HBASE-25887 Wait for appendExecutor to shutdown running tasks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
12m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

-1 :x:
mvninstall
9m 52s
root in branch-1 failed.

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 50s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 57s
branch-1 passed

+1 :green_heart:
shadedjars
3m 25s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 44s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 16s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 12s
branch-1 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
2m  0s
root in the patch failed.

+1 :green_heart:
compile
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 48s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 48s
the patch passed

+1 :green_heart:
checkstyle
1m 48s
hbase-server: The patch generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 11s
patch has no errors when building our shaded downstream artifacts.

-1 :x:
hadoopcheck
1m 44s
The patch causes 10 errors with Hadoop v2.8.5.

-1 :x:
hadoopcheck
4m 14s
The patch causes 10 errors with Hadoop v2.9.2.

+1 :green_heart:
javadoc
0m 34s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 46s
the patch passed

_ Other Tests _

-1 :x:
unit
166m 17s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

220m 34s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3264

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 0f3d0b59c2ff 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3264/out/precommit/personality/provided.sh

git revision
branch-1 / 8404470

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/1/artifact/out/branch-mvninstall-root.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/1/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/1/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/1/artifact/out/patch-javac-2.9.2.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/1/testReport/

Max. process+thread count
4411 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

-1 :x:
mvninstall
9m 59s
root in branch-1 failed.

+1 :green_heart:
compile
0m 47s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 55s
branch-1 passed

+1 :green_heart:
shadedjars
3m 29s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 47s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 23s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 19s
branch-1 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 59s
root in the patch failed.

+1 :green_heart:
compile
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 49s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 49s
the patch passed

+1 :green_heart:
checkstyle
1m 47s
hbase-server: The patch generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 12s
patch has no errors when building our shaded downstream artifacts.

-1 :x:
hadoopcheck
1m 44s
The patch causes 10 errors with Hadoop v2.8.5.

-1 :x:
hadoopcheck
4m 11s
The patch causes 10 errors with Hadoop v2.9.2.

+1 :green_heart:
javadoc
0m 33s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 17s
the patch passed

_ Other Tests _

-1 :x:
unit
168m  6s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

210m 54s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

hadoop.hbase.replication.TestMasterReplication

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3264

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 3799982ac6ea 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3264/out/precommit/personality/provided.sh

git revision
branch-1 / 8404470

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/2/artifact/out/branch-mvninstall-root.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/2/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/2/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/2/artifact/out/patch-javac-2.9.2.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/2/testReport/

Max. process+thread count
4364 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/2/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell @bharathv @shahrs87
As we had a little chat over Disruptor's constructor (as per 3.4.2 version) when I mentioned about ExecutorService being deprecated from it's constructor argument, on the same front, I just realized that HBase 2 is using recommended (non-deprecated) constructor and not passing ExecutorService and rather just providing ThreadFactory here
Wondering how we can ensure that Disruptor's own custom Executor is going to be properly shutdown and not leave any tasks in hanging state when we are just about to close OutputSteam.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

-1 :x:
mvninstall
9m 55s
root in branch-1 failed.

+1 :green_heart:
compile
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 52s
branch-1 passed

+1 :green_heart:
shadedjars
3m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 16s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 11s
branch-1 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 55s
root in the patch failed.

+1 :green_heart:
compile
0m 41s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 41s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 43s
hbase-server: The patch generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 12s
patch has no errors when building our shaded downstream artifacts.

-1 :x:
hadoopcheck
1m 44s
The patch causes 10 errors with Hadoop v2.8.5.

-1 :x:
hadoopcheck
4m 12s
The patch causes 10 errors with Hadoop v2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m  5s
the patch passed

_ Other Tests _

-1 :x:
unit
160m 15s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

201m 57s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3264

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 03df74e59309 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3264/out/precommit/personality/provided.sh

git revision
branch-1 / ddac801

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/3/artifact/out/branch-mvninstall-root.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/3/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/3/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/3/artifact/out/patch-javac-2.9.2.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/3/testReport/

Max. process+thread count
4339 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/3/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
11m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

-1 :x:
mvninstall
9m 52s
root in branch-1 failed.

+1 :green_heart:
compile
0m 41s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 47s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 53s
branch-1 passed

+1 :green_heart:
shadedjars
3m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 14s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 10s
branch-1 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 55s
root in the patch failed.

+1 :green_heart:
compile
0m 41s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 41s
the patch passed

+1 :green_heart:
compile
0m 48s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 48s
the patch passed

+1 :green_heart:
checkstyle
1m 43s
hbase-server: The patch generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  6s
patch has no errors when building our shaded downstream artifacts.

-1 :x:
hadoopcheck
1m 46s
The patch causes 10 errors with Hadoop v2.8.5.

-1 :x:
hadoopcheck
4m 19s
The patch causes 10 errors with Hadoop v2.9.2.

+1 :green_heart:
javadoc
0m 33s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m  8s
the patch passed

_ Other Tests _

-1 :x:
unit
159m 55s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

212m 13s

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestAdmin1

hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3264

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 1d06361d915e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3264/out/precommit/personality/provided.sh

git revision
branch-1 / ddac801

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/4/artifact/out/branch-mvninstall-root.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/4/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/4/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/4/artifact/out/patch-javac-2.9.2.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/4/testReport/

Max. process+thread count
4957 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/4/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

-1 :x:
mvninstall
9m 51s
root in branch-1 failed.

+1 :green_heart:
compile
0m 41s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 57s
branch-1 passed

+1 :green_heart:
shadedjars
3m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 44s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 16s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 14s
branch-1 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 56s
root in the patch failed.

+1 :green_heart:
compile
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 47s
the patch passed

+1 :green_heart:
checkstyle
1m 43s
hbase-server: The patch generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  6s
patch has no errors when building our shaded downstream artifacts.

-1 :x:
hadoopcheck
1m 46s
The patch causes 10 errors with Hadoop v2.8.5.

-1 :x:
hadoopcheck
4m 12s
The patch causes 10 errors with Hadoop v2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m  7s
the patch passed

_ Other Tests _

-1 :x:
unit
35m 41s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

77m 25s

Reason
Tests

Failed junit tests
hadoop.hbase.http.log.TestLogLevel

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3264

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 56159e406ad1 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3264/out/precommit/personality/provided.sh

git revision
branch-1 / ddac801

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/5/artifact/out/branch-mvninstall-root.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/5/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/5/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/5/artifact/out/patch-javac-2.9.2.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/5/testReport/

Max. process+thread count
734 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/5/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

TestLogLevel succeeded locally.
[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.http.log.TestLogLevel
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.857 s - in org.apache.hadoop.hbase.http.log.TestLogLevel
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]

hadoopcheck is failing and is tracked via HBASE-25890
@bharathv  could you please merge the PR ? Thank you !

 I am still trying to understand how appends/sync works in master branch.

master branch doesn't have appendExecutor at all. I am still trying to understand how appends/sync works in master branch.

Ya much of the code has been rewritten with async fshlog. Was curious if there is another manifestation of the same issue.

meanwhile, does this apply to other branches?

@bharathv This patch doesn't apply to other branches. master branch doesn't have appendExecutor at all. I am still trying to understand how appends/sync works in master branch.

That's what I was trying to bring up in one of our internal discussion. After bumping Disruptor version on branch-1, our current
Disruptor c'tor is deprecated and the one recommended does pass only ThreadFactory in place of Executor.
Disruptor 3.4.2 uses their custom internal BasicExecutor:
public class BasicExecutor implements Executor
{
    private final ThreadFactory factory;
    private final Queue<Thread> threads = new ConcurrentLinkedQueue<>();

    public BasicExecutor(ThreadFactory factory)
    {
        this.factory = factory;
    }

    @Override
    public void execute(Runnable command)
    {
        final Thread thread = factory.newThread(command);
        if (null == thread)
        {
            throw new RuntimeException("Failed to create thread to run: " + command);
        }

        thread.start();

        threads.add(thread);
    }

    @Override
    public String toString()
    {
        return "BasicExecutor{" +
            "threads=" + dumpThreadInfo() +
            '}';
    }

    private String dumpThreadInfo()
    {
        final StringBuilder sb = new StringBuilder();

        final ThreadMXBean threadMXBean = ManagementFactory.getThreadMXBean();

        for (Thread t : threads)
        {
            ThreadInfo threadInfo = threadMXBean.getThreadInfo(t.getId());
            sb.append("{");
            sb.append("name=").append(t.getName()).append(",");
            sb.append("id=").append(t.getId()).append(",");
            sb.append("state=").append(threadInfo.getThreadState()).append(",");
            sb.append("lockInfo=").append(threadInfo.getLockInfo());
            sb.append("}");
        }

        return sb.toString();
    }
}

@bharathv  @virajjasani  Please don't merge until @Reidddddd  gives a green light. He asked me to wait here.

I'm reading the disruptor shutdown code and now I'm a bit confused, lets hold off on merging this until I get back (by EOD).

That's what I was trying to bring up in one of our internal discussion. After bumping Disruptor version on branch-1, our current
Disruptor c'tor is deprecated and the one recommended does pass only ThreadFactory in place of Executor. That's what is being used by master and branch-2.
Disruptor 3.4.2 uses their custom internal BasicExecutor:

@virajjasani I think the bug is something else here. See my last comment. Its weird that disruptor is not closing that executor, I don't know why. In the deprecated version of c'tor we atleast have access to the executor to shut it down but doesn't seem like the case in the later versions. They explicitly state that they don't shutdown the executor.

Ok, after reading some disruptor code and it's shutdown routine, I think the issue is something else here.

Agree with @bharathv  that the bug lies in appending entries to ringbuffer while disruptor#shutdown is in progress.
Changed the patch moving setting closed flag before we shutdown the disruptor. That should make sure that we won't add entries to ringbuffer.

This bug also applies to branch-2

Looked at the master and branch-2 code, I don't think both the branches have this bug.
Below is the shutdown routine in above branches.
  @Override
  public void shutdown() throws IOException {
    if (!shutdown.compareAndSet(false, true)) {
      return;
    }
    closed = true;  -----> We set the closed flag here.
    // Tell our listeners that the log is closing
    if (!this.listeners.isEmpty()) {
      for (WALActionsListener i : this.listeners) {
        i.logCloseRequested();
      }
    }
    rollWriterLock.lock();
    try {
      doShutdown();  ------> We shutdown the disruptor here.
      if (logArchiveExecutor != null) {
        logArchiveExecutor.shutdownNow();
      }
    } finally {
      rollWriterLock.unlock();
    }
  }

Reference code here.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
15m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

-1 :x:
mvninstall
9m 52s
root in branch-1 failed.

+1 :green_heart:
compile
0m 52s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 54s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
2m 16s
branch-1 passed

+1 :green_heart:
shadedjars
3m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 56s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 50s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 47s
branch-1 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
2m  8s
root in the patch failed.

+1 :green_heart:
compile
0m 50s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
compile
0m 53s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 53s
the patch passed

+1 :green_heart:
checkstyle
2m  3s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 37s
patch has no errors when building our shaded downstream artifacts.

-1 :x:
hadoopcheck
2m 15s
The patch causes 10 errors with Hadoop v2.8.5.

-1 :x:
hadoopcheck
5m  8s
The patch causes 10 errors with Hadoop v2.9.2.

+1 :green_heart:
javadoc
0m 40s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 53s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
4m  9s
the patch passed

_ Other Tests _

-1 :x:
unit
171m  8s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

232m 17s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

hadoop.hbase.procedure.TestFailedProcCleanup

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3264

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4f25fb109a07 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3264/out/precommit/personality/provided.sh

git revision
branch-1 / ddac801

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/6/artifact/out/branch-mvninstall-root.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/6/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/6/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/6/artifact/out/patch-javac-2.9.2.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/6/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/6/testReport/

Max. process+thread count
4350 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/6/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Ran all the failing tests locally.
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.procedure.TestFailedProcCleanup

[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 79.461 s - in org.apache.hadoop.hbase.procedure.TestFailedProcCleanup
[INFO] Running org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
[INFO] Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 518.231 s - in org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
[INFO] Running org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
[INFO] Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 526.029 s - in org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
[INFO] Running org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
[INFO] Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 515.253 s - in org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 68, Failures: 0, Errors: 0, Skipped: 0

TestLoadIncrementalHFiles class is known to be flakey in branch-1. Seen them failing in most of branch-1 PR's.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

-1 :x:
mvninstall
9m 49s
root in branch-1 failed.

+1 :green_heart:
compile
0m 40s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 52s
branch-1 passed

+1 :green_heart:
shadedjars
3m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 15s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 11s
branch-1 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 56s
root in the patch failed.

+1 :green_heart:
compile
0m 43s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 47s
the patch passed

+1 :green_heart:
checkstyle
1m 44s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  5s
patch has no errors when building our shaded downstream artifacts.

-1 :x:
hadoopcheck
1m 43s
The patch causes 10 errors with Hadoop v2.8.5.

-1 :x:
hadoopcheck
4m 12s
The patch causes 10 errors with Hadoop v2.9.2.

+1 :green_heart:
javadoc
0m 33s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m  6s
the patch passed

_ Other Tests _

-1 :x:
unit
162m  7s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

203m 24s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

hadoop.hbase.regionserver.TestSplitTransactionOnCluster

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3264

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 2e8f0896c7ee 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3264/out/precommit/personality/provided.sh

git revision
branch-1 / ddac801

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/7/artifact/out/branch-mvninstall-root.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/7/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/7/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/7/artifact/out/patch-javac-2.9.2.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/7/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/7/testReport/

Max. process+thread count
4356 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/7/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

-1 :x:
mvninstall
9m 48s
root in branch-1 failed.

+1 :green_heart:
compile
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 47s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 56s
branch-1 passed

+1 :green_heart:
shadedjars
3m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 13s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  9s
branch-1 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 55s
root in the patch failed.

+1 :green_heart:
compile
0m 43s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 42s
the patch passed

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  5s
patch has no errors when building our shaded downstream artifacts.

-1 :x:
hadoopcheck
1m 46s
The patch causes 10 errors with Hadoop v2.8.5.

-1 :x:
hadoopcheck
4m 10s
The patch causes 10 errors with Hadoop v2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m  6s
the patch passed

_ Other Tests _

-1 :x:
unit
162m 49s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

203m 54s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3264

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux f3ba8a786a3f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3264/out/precommit/personality/provided.sh

git revision
branch-1 / ddac801

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/8/artifact/out/branch-mvninstall-root.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/8/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/8/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/8/artifact/out/patch-javac-2.9.2.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/8/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/8/testReport/

Max. process+thread count
4266 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/8/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
[INFO] Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 107.304 s - in org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
[INFO] Running org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
[INFO] Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 587.169 s - in org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
[INFO] Running org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
[INFO] Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 597.287 s - in org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 62, Failures: 0, Errors: 0, Skipped: 0

All the failed test succeeds on my local machine.
@bharathv  could you please review again and merge if okay ? Thank you !

Please hold it, for the release sake. @virajjasani and @bharathv already approved it, I'll do the merge later, no worries about this one.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m  0s
branch-1 passed

+1 :green_heart:
compile
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 47s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 54s
branch-1 passed

+1 :green_heart:
shadedjars
3m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 18s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 15s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  1s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 46s
the patch passed

+1 :green_heart:
checkstyle
1m 45s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 46s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 44s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 10s
the patch passed

_ Other Tests _

-1 :x:
unit
162m 51s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

207m 11s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3264

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 5da61e626e7b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3264/out/precommit/personality/provided.sh

git revision
branch-1 / c0ee153

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/9/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/9/testReport/

Max. process+thread count
5026 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/9/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Update WebStorm configuration for improved Tailwind CSS autocompletio…

This update significantly improves autocompletion support in WebStorm for projects using class-variance-authority (cva) with Tailwind CSS. The enhanced regex patterns address several edge cases reported by the community, particularly focusing on empty variant definitions and complex nested structures.
Tested with WebStorm 2023.1+. Feedback on edge cases or unexpected behavior is highly appreciated.

Description

Additional context
Webstorm Issue: https://youtrack.jetbrains.com/issue/WEB-69764/Tailwind-CSS-autocomplete-not-working-with-cva-in-WebStorm
I've attached two images to this pull request to visually demonstrate the improvement:
Before the fix:

After the fix:

What is the purpose of this pull request?

[X] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[X] Read the Contributing Guidelines.
[X] Follow the Style Guide.
[X] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[X] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

I need to improve the regex, closing...


Lighthouse audit frame blocked by Content Security Policy

The lighthouse plugin displays details for a specific audit in a frame. This frame is blocked by the default Content Security Policy.
Expected Behavior
A fresh installation of Backstage should display the Lighthouse audit view without errors.
Current Behavior
The lighthouse audit view displays a sad/blocked rectangle (in Chrome).
The Javascript console diplays Refused to frame 'http://localhost:7000/' because an ancestor violates the following Content Security Policy directive: "frame-ancestors 'self'".
If frame-ancestors is modified as below, the Javascript console instead displays Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self' 'unsafe-eval'". Either the 'unsafe-inline' keyword, a hash ('sha256-...'), or a nonce ('nonce-...') is required to enable inline execution.
Possible Solution
Adding the following configuration to app-config.local.yml fixes the problem:
backend:
  csp:
    frame-ancestors: ["'self'", 'localhost:3000']
    script-src: ["'self'", "'unsafe-inline'"]

frame-ancestors above would only apply to the local env where app and backend is separated, so adding this as a default value might be an easy fix. script-src is a different, and more dangerous, animal where it might be suitable to refactor the lighthouse audit service to avoid the need.
Steps to Reproduce

git clone git@github.com:backstage/backstage.git
Setup lighthouse as per https://github.com/backstage/backstage/blob/master/plugins/lighthouse/README.md

Start an instance of https://github.com/spotify/lighthouse-audit-service
Configure the lighthouse service url in your app-config.yaml

yarn dev
Browse to the lighthouse page (/lighthouse) and submit an audit for a website
When the audit has finished, click it to go the audit detail page (/lighthouse/audit/xxx)
Where the audit details should be seen, a grey/sad rectangle is shown instead and an error is written to the Javascript console

Context
This has cost me a few hours of debugging, and might do others. The unsafe-inline configuration might be a blocker for security conscientious adopters.
Your Environment

NodeJS Version (v12): v12.19.0
Operating System and Version (e.g. Ubuntu 14.04): OSX 10.15.7 (same issue when running Docker, node:12-buster image)
Browser Information: Chrome latest

I came here because I was having a similar problem when trying to serve Lighthouse Audit Service from Backstage's backend proxy, in order to simplify our infra.
For anyone having this problem, the "Possible solution" mentioned worked for me:
backend:
  csp:
    frame-ancestors: ["'self'", 'localhost:3000']
    script-src: ["'self'", "'unsafe-inline'"]


Ensure stable IDs for dfn refs in domintro sections

MDN and possibly other places have need to link to not just normative dfn terms/targets themselves in specs but also (actually, often) have need to link to secondary references to terms in other spec  sections — in particular, in informative (non-normative) spec sections written specifically for web developers.
WHATWG specs follow a convention of using class=domintro to mark up such written-for-web-developers sections, and some other specs (e.g., the IndexedDB spec) have also adopted that convention.
To facilitate having stable links to term references in those class=domintro sections, this change ensures that those references are output with IDs that have -dev appended — rather than prefixed with ref-to.
And while it’s true that some references in class=domintro sections may end up with -dev-②, etc., suffixes — with ②, etc., circled-digits also appended, rather than ending with just -dev  — that’ll likely happen mostly just for ancillary references that sites such as MDN won’t have need to link to anyway, while the “primary” initial references that MDN, etc., do have need for linking to will most likely end up with -dev suffixes without any additional ②, etc., circled-digits also appended.
Examining the changes to the test-case output in this PR branch confirms the assertion in the paragraph above about those “something that MDN has need for linking to” references in fact ending up with stable -dev suffixes without additional ②, etc., circled-digits also appended.
Without this change, even those terms references/links that are inside class=domintro sections are otherwise output with IDs of the form ref-foo-①, etc. — just as are the IDs output for such references/links outside of class=domintro sections.
So this change helps make it likely that primary references/links to terms inside class=domintro sections end up with stable IDs useful for referencing from MDN and other places — rather than ref-foo-②, etc., IDs that might change if some new reference to a term is added to a spec somewhere preceding a class=domintro section where the term is referenced.
cc @foolip

See the related discussion at https://github.com/mdn/browser-compat-data/issues/11088.
For MDN and possibly other sources, it’s not desirable to link from MDN to the spec target IDs for defined terms (<dfn>s) themselves (that is, the places which give implementors the normative definitions for the terms); it’s instead desirable to link from MDN to the spec target IDs for the places in the spec that for any given defined term provide non-normative information written specifically for web developers (that is, the sections for which the class=domintro convention is used in WHATWG specs and in other specs).
And for class=domintro sections, IDs in the ref-foo-① form are suboptimal — since the digit suffix part may change if some new reference to a term is added to a spec somewhere preceding a class=domintro section where the term is referenced.
So those ref-foo-① IDs rightly need to be considered unstable. And so that’s why it’d be better to have stable -dev IDs if we can get them. And the test-case output in this PR branch seems to show that in fact we can successfully get them.
And while this change is particularly useful for WHATWG specs, which all use the class=domintro convention (in particular, the DOM, Streams, and Fetch specs, which each use it quite heavily), we can also say the following:

the IndexedDB spec and the other specs with changed test-case output in this PR also already use the class=domintro convention, so this change will give the same benefits for those specs; and
some other specs, e.g., the WebUSB and Device Orientation specs, already have domintro-like parts (written specifically for web developers) that could benefit from this same change if they were to adopt the class=domintro convention

I see the CI failure is for lint failure that’s unrelated to the change in this PR —
https://github.com/tabatkins/bikeshed/pull/2094/checks?check_run_id=2939579605#step:7:8
And I see CI is green on the main branch and on other PR branches, so I’m not sure why this PR branch is running into that lint failure while other branches aren’t…

I haven't reviewed the change, leaving that to @tabatkins, but I like the approach, thanks @sideshowbarker!

You cite the possibility of these refs still getting number-suffixed; do we want to allow the author to specify an attribute on the domintro ancestor whose value will be used to further dedup the IDs in that block?

Yes, good point — I’ll add that.
As far as the attribute name, if we want consistency with what we do for the HTML spec, we could call it subdfn. That’s admittedly a bit arcane — but then so is domintro as a class name.
But anyway maybe having consistency with what HTML does isn’t super important.

As far as the attribute name, if we want consistency with what we do for the HTML spec, we could call it subdfn. That’s admittedly a bit arcane — but then so is domintro as a class name.

To be clear a bit more clear about what subdfn does — it’d be a value-less boolean attribute that effectively means “don’t de-dupe the ID generated for this element”. So if the element is a reference to a foo dfn, then subdfn on its own would deterministically ensure the element gets a foo-dev ID with no number suffix.
Anyway, I’ll take a shot at implementing it that way, and see if I can make it work.

You cite the possibility of these refs still getting number-suffixed; do we want to allow the author to specify an attribute on the domintro ancestor whose value will be used to further dedup the IDs in that block? If it's absent we'd just continue to use the approach already outlined here.

OK, implemented that using subdfn as the attribute name, and also added info about it to the docs

So if I'm understanding this code correctly, the presence of subdfn means that the link "claims" the un-numbered version of the dedupe'd ID (thus ensuring that its ID isn't dependent on the presence or absence of other refs earlier in the document), right?
Hm. It seems, then, like people would still need to liberally sprinkle subdfn in their document to actually get anything like a guarantee of stability, right? If they forget, then it's reasonably likely they might still run into a collision; only convention (WHATWG doesn't put many links in its domintro sections besides the one corresponding to the thing being defined) makes the "-dev" switch much more likely to succeed at stability. And even if they do use it, it still depends on site authors manually grabbing the ID from a link that doesn't expose it in a natural way.
I think I'd like to revisit this problem a little more thoroly and solve it more reliably.

So, the problem at hand is that domintro section, which provide an informative description of something officially defined somewhere nearby, are often more useful for reference sites to link to, since they're more human-readable for authors. However, domintro blocks don't guarantee that they have an ID or expose that ID for linkability if they have it, and so people end up linking to the ID of the main link instead; that link, however, just has a generated ID which is very much not stable if the document preceding it changes.
So here's another proposal:

Formalize domintro sections a little bit more, ensuring they're fit for this purpose. Require an ID on them, and visibly expose that anchor like we do for headings and such, so it's easy to spot what should be linked to.
Possibly, allow an author to indicate the "primary" link in a domintro section instead; this removes the need to manually provide an ID. Instead, we generate an ID for that link in a guaranteed-stable way and then visibly expose that link on the domintro block. (That is, the visible "§" or whatever links to the indicated link, rather than to the domintro block itself.)
Maybe still do an alternative ref-generation scheme on the rest of the links in a domintro, like what you have here, just so if someone still grabs one of those links manually it's at least more likely that the ID will be stable, even if it's not guaranteed.

Anything else I'm missing that we could address?

So if I'm understanding this code correctly, the presence of subdfn means that the link "claims" the un-numbered version of the dedupe'd ID (thus ensuring that its ID isn't dependent on the presence or absence of other refs earlier in the document), right?

Yes, that’s it exactly.

It seems, then, like people would still need to liberally sprinkle subdfn in their document to actually get anything like a guarantee of stability, right?

Right, yeah — that’s the downside.

I think I'd like to revisit this problem a little more thoroughly and solve it more reliably.

Sounds great — I’m definitely not wedded to the particular implementation if this I wrote up.

Formalize domintro sections a little bit more, ensuring they're fit for this purpose. Require an ID on them, and visibly expose that anchor like we do for headings and such, so it's easy to spot what should be linked to.

✅ All sounds reasonable

2. Possibly, allow an author to indicate the "primary" link in a domintro section instead; this removes the need to manually provide an ID. Instead, we generate an ID for that link in a guaranteed-stable way and then visibly expose that link on the domintro block. (That is, the visible "§" or whatever links to the indicated link, rather than to the domintro block itself.)

✅ I very much like the idea of exposing a visible indicator — which’ll help encourage people to use that anchor for citing elsewhere.
I think we do need some way for authors to indicate which reference in the primary link — rather than just taking the first reference in document order within a domintro section. The reason for that — which I maybe mentioned earlier — is that we do in fact have a number of domintro sections in which there one or more references in a domintro block that in document order precede what need to be the “primary” reference.

3. Maybe still do an alternative ref-generation scheme on the rest of the links in a domintro, like what you have here, just so if someone still grabs one of those links manually it's at least more likely that the ID will be stable, even if it's not guaranteed.

✅ OK — though perhaps we’re going to end up finding there will be no need for that if we get the mechanism working that you outlined in the steps #1 and #2.

Anything else I'm missing that we could address?

I don’t think you missed anything.


Wrong sorting order for the package version suggestions

If you try to get the highest package version via suggestions, you will face the issue when 3.9.0 is higher than 3.33.0. I assume the string comparison here is not the best way to sort the suggestions.

Thanks. Fixed in 1.0.29 version.


OCM-2276 | fix: more clarity into why it might have not found the prefix

Related issue: https://issues.redhat.com/browse/OCM-2276

lgtm

/retest

/lgtm


[Program]: Write a Julia program to find average of numbers by recursion

Description
Write a Julia program to find average of numbers by recursion
Average of numbers is the sum of all numbers divided by the number of numbers. For example, the average of 1, 2, 3, 4, 5 is 3. The average of 1, 2, 3, 4, 5, 6 is 3.5.
Average of numbers can be calculated by recursion. The average of numbers is the sum of the first number and the average of the rest of the numbers. The average of the rest of the numbers is the sum of the second number and the average of the rest of the numbers. The average of the rest of the numbers is the sum of the third number and the average of the rest of the numbers. And so on.
Input  : 1 2 3 4 5
Output : 3

How to contribute

Save the solution in program/program/find-average-of-numbers-by-recursion/program/find-average-of-numbers-by-recursion.jl file

!assign


forge: Initial version of application to help developers

Allow easy running of applications without installing them.

Cool idea, thank you - happy to merge depending on what you think about ⬆

Looks good to me, thanks for update.


subgraphs.xyz Reward APR incorrect

This is an issue on compound forks I noticed. The Reward APR is the same for both the supply and borrow side.
With these protocols the amount of reward token distributed to suppliers / borrowers is generally the same, but suppliers will get less for their share bc there is more of that asset being supplied.
The calculation should look something like this:
Supply Reward APR = (Supply Rewards Per Day USD / totalSupplyBalanceUSD) * 365 * 100
Borrow Reward APR = (Borrow Rewards Per Day USD / totalBorrowBalanceUSD) * 365 * 100

Fixed in https://github.com/messari/subgraphs/pull/592


Adding Blockchain Terminology & Bitcoin house

Looking to add the video/pictures of the TxStreet NFT's to the NFT page. Will continue to get more efficient with my commits, struggling to learn squashing/merging commits but will sit down for more time and learn.

bitcoin/live-stats.md


[FEATURE] Enable transaction coordinator by default

Is your feature request related to a problem? Please describe.
Currently KoP disables the transaction coordinator by default. However, the idempotent producer feature depends on it. Since Kafka client 3.2.0, the idempotent producer is enabled by default. So if KoP users don't configure kafkaTransactionEnabled=true, the producers might fail to produce.
Describe the solution you'd like
Enable transaction coordinator by default, and document the required configurations for old version users.

Is kafkaTransactionCoordinatorEnabled same as kafkaTransactionEnabled?

Yes, it's a typo by me


feat: Trust added certificates by default

:tada: This PR is included in version 1.26.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Custom selectors not working only on solidjs ( unocss )

Describe the bug
hi there, Im using unocss and i use this syntax to add classes for all span elements in a div [&_span]:bg-red , this will add bg-red to all span elements of the parent div
that syntax works in unocss playground
Where as it doesnt work when used with solidjs only
https://codesandbox.io/s/weathered-bush-nhq6ov?file=/src/index.jsx
Some examples provided by @high1   ( stackbiltz examples, look at the siduck text color, its not highlighted in only solid-js )
https://stackblitz.com/edit/github-4lynj1?file=src%2FClockFace.svelte%3AL69 ( svelte )
https://stackblitz.com/edit/github-hnrwfp?file=src%2FClockFace.tsx%3AL66 ( voby )
https://stackblitz.com/edit/github-prvqmz?file=src%2FClockFace.tsx%3AL71 ( solidjs )
@high1  affirmed me that this was a bug in solid-js, so made an issue here!
Your Example Website or App
https://codesandbox.io/s/weathered-bush-nhq6ov?file=/src/index.jsx
Steps to Reproduce the Bug or Issue
https://codesandbox.io/s/weathered-bush-nhq6ov?file=/src/index.jsx
https://github.com/eeek76/uno
Expected behavior
Custom selectors should work with unocss.
Platform
All browsers

I don't really understand enough what unocss is doing to speak to this. But inspecting the elements I don't see any difference just the CSS rules missing. I grabbed the HTML from the working example and inserted it in the DOM in the Solid example and it didn't work, and grabbed the HTML from Solid example and dropped it in the Svelte example and it did work.
So this points to something in how unocss detects styles...
Oh I figured it out. Put uno plugin first in vite.config. It must be reading off the compiled template strings and not be able to parse the escaped ampersands.

@ryansolid thanks for quick reply, i put unocss plugin before solidplugin, it works now!!! thanks a lot :D


feat(trading): use market code instead of market name in positions table

Related issues 🔗
Closes #4480
Description ℹ
A description of what this PR does. This should be non-dev readable. Technical stuff should go in the technical section below.
Demo 📺

@bglownia there is a min width applied to the market name column that should probably be reduce or removed


YJDH-631 | KS-Backend: Fix migrations related to target_group

Description :sparkles:
In PR #1234 / commit d4d73280c88f7c1edea0a6593d6362299e83adb9
target_group was renamed but the information added in the migration file
0031_rename_summer_voucher_exception_reason_to_target_group.py
was not completely in sync with the related Django models.
Fix this by renaming the help_text and verbose_name values in the
related Django models to coincide with the manually changed texts in the
migration and make a migration of the remaining incongruence between
EmployerSummerVoucher.target_group and
HistoricalEmployerSummerVoucher.target_group.
Also fix typo PRIMAERY_TARGET_GROUP -> PRIMARY_TARGET_GROUP.
Issues :bug:
YJDH-631
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #1335 (d7dd18c) into develop (f5d09ea) will increase coverage by 29.42%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           develop    #1335       +/-   ##
============================================
+ Coverage    64.82%   94.25%   +29.42%
============================================
  Files         1023      143      -880
  Lines        28063     6437    -21626
  Branches      2951        0     -2951
============================================
- Hits         18191     6067    -12124
+ Misses        9428      370     -9058
+ Partials       444        0      -444

Impacted Files
Coverage Δ

backend/kesaseteli/applications/models.py
96.40% <ø> (ø)

backend/kesaseteli/applications/enums.py
100.00% <100.00%> (ø)

...s/0032_alter_employersummervoucher_target_group.py
100.00% <100.00%> (ø)

...nd/shared/shared/service_bus/service_bus_client.py
27.65% <0.00%> (-57.45%)
:arrow_down:

backend/shared/shared/yrtti/yrtti_client.py
39.39% <0.00%> (-51.52%)
:arrow_down:

backend/shared/shared/common/lang_test_utils.py
80.00% <0.00%> (-20.00%)
:arrow_down:

backend/shared/shared/audit_log/admin.py
87.50% <0.00%> (-12.50%)
:arrow_down:

backend/shared/shared/audit_log/viewsets.py
88.60% <0.00%> (-7.60%)
:arrow_down:

frontend/shared/src/components/hocs/withAuth.tsx

frontend/benefit/handler/.testcaferc.js

... and 879 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Feature Request - composer

Make it composer compatible and publish it on packagist

I'll decide on this soon ;)

Any news on this…? ;)

+1
I'd love to install this repository via bower.
I don't see a problem here. Every modern packet manager expects the configuration files in the root folder (bower, npm, composer).

https://github.com/MadaManu/angularjs-maillinker - the AngularJS flavour of this. Maybe we can integrate somehow at some point. I have registered this one on bower. I will update with documentation soon.

As a workaround you can add this to your composer.json to install webmail-linker via composer:
{
   "type": "package",
   "package": {
      "name": "webmail-linker",
      "version": "0.1",
      "source": {
         "url": "https://github.com/thomasbachem/webmail-linker",
         "type": "git",
         "reference": "origin/master"
      }
   }
},


Added Claymorphism code files

Description
It's  a cool "Claymorphism List" with Hover effects with help of Html and CSS ,
which everyone will like to add in his or her Frontend Project.
Fixed -  #406

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Hey @VidhiBhatt01 , Checkout this PR
and all things good to go kindly merge it ...............

@ayush-sleeping

hey @VidhiBhatt01 , checkout now
fixed :
overlapping  text
getting cut.

hey @VidhiBhatt01 , Checkout now
Fixed : Overlapping text and getting cut.

hey @VidhiBhatt01 , When it will get merged

@arpit456jain


Remove the apache-commons-math dependency for stats module

It uses FastMath internally, which I think in recent JVMs is slower than just Math.
It won't cross to native.

I'm less concerned about JVM-only test dependencies (e.g. apache-commons-rng).

Done in https://github.com/armanbilge/schrodinger/pull/217.


Add Gitpod

Try it yourself: https://gitpod.io#https://github.com/wagtail/guide/

What is the purpose of apps/guide/settings/local.py.example? Rest LGTM.

Each settings file ends with a try: import local expecting a local.py. The local.py.example most often is provided as an example file to showcase possible settings.
local.py.example seems off topic in this PR, so I removed it.

Thanks @allcaps :+1:


Move page problem

Alo
I finded some problem with move page in grav.
When we have pages (example):
->name (/name)
->namesomething (/namesomething)
and want move page /name to /namesomething we have error:
Failed: Cannot set page parent to a child of current page
It's will be working when we try move /testsomething to /test.
Reason is in function move() in file /system/src/grav/common/page/page.php (line: 967)
This function in line 979 use function 'startsWith' to test rawrute:
if (Utils::startsWith($parent->rawRoute(), $this->rawRoute())) {
            throw new Exception('Failed: Cannot set page parent to a child of current page');
}

but function 'startsWith' [/system/src/grav/common/utils.php (line: 80)]
public static function startsWith($haystack, $needle)
    {
        $status = false;

        foreach ((array)$needle as $each_needle) {
            $status = $each_needle === '' || strpos($haystack, $each_needle) === 0;
            if ($status) {
                break;
            }
        }

        return $status;
    }

Function check only if string start like second string not compare full string.

Looks like the comparison simply needs a trailing / and it would work.


Traceback (most recent call last):   File "spawn_npc.py", line 26, in      from carla import VehicleLightState as vls ImportError: cannot import name 'VehicleLightState' from 'carla' (../carla/dist/carla-0.9.10-py3.8-linux-x86_64.egg/carla/init.py)

Traceback (most recent call last):
File "spawn_npc.py", line 26, in
from carla import VehicleLightState as vls
ImportError: cannot import name 'VehicleLightState' from 'carla' (../carla/dist/carla-0.9.10-py3.8-linux-x86_64.egg/carla/init.py)

I faced the same error, so I moved to the stable version that is 0.8.2, that seems to work, and has documentation if you select stable version on readthedocs

Have you solved this problem now?

Same issue. Installed carla with Python 3.7. Anyone solved this error?

I'm seeing the same error with py3.8 and Carla 0.9.11 on Windows. My Pythonpath seems to point to the correct egg but it complains

ImportError: cannot import name 'VehicleLightState' from 'carla'


track change of api/unversioned to apis/meta/v1 in 1.6

Consider solutions which don't break existing users.

closing in favor of #35


Document is empty

I'm getting this error when I try to run:
Traceback (most recent call last):
File "C:\Users\USER\AppData\Local\Programs\Python\Python36\lib\site-packages\pyquery\pyquery.py", line 95, in fromstring
result = getattr(etree, meth)(context)
File "src\lxml\etree.pyx", line 3213, in lxml.etree.fromstring
File "src\lxml\parser.pxi", line 1876, in lxml.etree._parseMemoryDocument
File "src\lxml\parser.pxi", line 1764, in lxml.etree._parseDoc
File "src\lxml\parser.pxi", line 1126, in lxml.etree._BaseParser._parseDoc
File "src\lxml\parser.pxi", line 600, in lxml.etree._ParserContext._handleParseResultDoc
File "src\lxml\parser.pxi", line 710, in lxml.etree._handleParseResult
File "src\lxml\parser.pxi", line 639, in lxml.etree._raiseParseError
File "", line 17
lxml.etree.XMLSyntaxError: Start tag expected, '<' not found, line 17, column 1
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\USER\Desktop\Twitter Stock Market\current.py", line 16, in
for tweet in get_tweets('trump', pages=3):
File "C:\Users\USER\AppData\Local\Programs\Python\Python36\lib\site-packages\twitter_scraper.py", line 78, in get_tweets
yield from gen_tweets(pages)
File "C:\Users\USER\AppData\Local\Programs\Python\Python36\lib\site-packages\twitter_scraper.py", line 26, in gen_tweets
url='bunk', default_encoding='utf-8')
File "C:\Users\USER\AppData\Local\Programs\Python\Python36\lib\site-packages\requests_html.py", line 419, in init
element=PyQuery(html)('html') or PyQuery(f'{html}')('html'),
File "C:\Users\USER\AppData\Local\Programs\Python\Python36\lib\site-packages\pyquery\pyquery.py", line 255, in init
elements = fromstring(context, self.parser)
File "C:\Users\USER\AppData\Local\Programs\Python\Python36\lib\site-packages\pyquery\pyquery.py", line 99, in fromstring
result = getattr(lxml.html, meth)(context)
File "C:\Users\USER\AppData\Local\Programs\Python\Python36\lib\site-packages\lxml\html_init_.py", line 876, in fromstring
doc = document_fromstring(html, parser=parser, base_url=base_url, **kw)
File "C:\Users\USER\AppData\Local\Programs\Python\Python36\lib\site-packages\lxml\html_init_.py", line 765, in document_fromstring
"Document is empty")
lxml.etree.ParserError: Document is empty

seconded

Closing due to inactivity :+1:

I am getting this same issue

I had same error as @LiquidPrototype @thorsummoner
it seems to happen because the r.json in twitter_scraper.py line 26 yields an empty json response for the items_html value
{'has_more_items': False,
 'items_html': '\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n \n',
 'min_position': None,
 'new_latent_count': 0}

breaking the while loop when encountering the empty html seems to avoid the error
while pages > 0:
  try:
      items_html = r.json()['items_html'].strip()
    if not items_html:
        break # exit the loop if the items_html is empty

Worth checking out my repo I made to get twitter data for bot identification purposes. I was using this repo until it broke for me too. https://github.com/jamesacampbell/botrnot and it is pip3 install botrnot

Same problem here, @adamhrv 's solution of breaking the loop does not work for me.


add time with date

add time with date so that , time specific task created.
example:-
      if i add a task at 19/12/2023 at 19:45. then same task should be added on 19/12/2023 at 19:47.

time specific task


let there be colour

Coverage remained the same at 92.192% when pulling 034d0b3d3631489c4673471260dbbf5905940cf2 on bashu:patch-1 into ceabd0f6318f129758341ab08292a20205d6f4cd on inonit:master.

Coverage remained the same at 92.192% when pulling 034d0b3d3631489c4673471260dbbf5905940cf2 on bashu:patch-1 into ceabd0f6318f129758341ab08292a20205d6f4cd on inonit:master.

Coverage remained the same at 92.192% when pulling 034d0b3d3631489c4673471260dbbf5905940cf2 on bashu:patch-1 into ceabd0f6318f129758341ab08292a20205d6f4cd on inonit:master.

Coverage remained the same at 92.192% when pulling 034d0b3d3631489c4673471260dbbf5905940cf2 on bashu:patch-1 into ceabd0f6318f129758341ab08292a20205d6f4cd on inonit:master.


Clarify extension and directoryness

Related to #3.
Currently detecting file path extensions (Fpath.{get_ext,has_ext,ext_exists,rem_ext,split_ext}) on directory paths (e.g. "hey.ho/"), results in having no extension. In other words these functions always operate on the path's last segment which is "" for directories.
However Fpath.{add_ext,set_ext} will add extensions to the empty path segment, resulting in dot files being created. E.g. Fpath.set_ext "png" (v "hey.ho/") = (v "hey.ho/.png"). This is clearly unsatisfactory.
We should either:

Make Fpath.{add_ext,set_ext} be the identity on directory paths.
Make all extension processing work on the last non-empty segment, doing nothing on root paths like "/" (these paths have no last non-empty segment).

In the model exposed by 1) it means that if you wish to operate on extensions you have to make sure to convert your path to a file path, possibly reinstating directoryness after having processed the extension which is a bit annoying.
In the model exposed by 2) you can do so regardless of directoryness which seems more user friendly API-wise and doesn't seem to pose any kind of conceptual problem.
Both 1) and 2) would behave the same on "/" since Fpath.dir_to_file (v "/") = (v "/")).

File extension operations now always operate on fpath's notion of basename and do nothing if it is empty (e.g. extensions won't be added to .. segments).


docs(NODE-4380): fix grammar issue in documentation

Description
There's a grammar issue in the documentation with the following period:
The programmatically provided options take precedent over the URI options.

the correct form is to take precedence.
What is changing?
Documentation grammar.
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Reducing confusion around the project's documentation.

Double check the following

[x] Ran npm run check:lint script
[x] Self-review completed using the steps outlined here
[.] PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
[ ] Changes are covered by tests
[ ] New TODOs have a related JIRA ticket

@hood Thanks for the catch!


chrome: update chrome beta w/experimental expectation

from #689, upstream bug in https://bugs.chromium.org/p/chromium/issues/detail?id=773613

cc @henbos


Unify packse find links urls

The sync scenarios script is broken, so i did the updates manually
$ ./scripts/sync_scenarios.sh
Setting up a temporary environment...
Using Python 3.12.1 interpreter at: /home/konsti/projects/uv/.venv/bin/python3
Creating virtualenv at: .venv
Activate with: source .venv/bin/activate
  × No solution found when resolving dependencies:
  ╰─▶ Because docutils==0.21.post1 is unusable because the package metadata was inconsistent and you require docutils==0.21.post1, we can conclude that the requirements are unsatisfiable.

      hint: Metadata for docutils==0.21.post1 was inconsistent:
        Package metadata version `0.21` does not match given version `0.21.post1`

The sync scenarios script is broken

I can't reproduce this, any idea what's going on there?

The docutils source dist is inconsistent about its version number: https://inspector.pypi.io/project/docutils/0.21/ . Haven't checked yet where that breaks uv

I tested with the sync script in https://github.com/astral-sh/uv/pull/2970


python client 初始化运行时报错

根据官方文档的例子我运行后报错,是我使用方法有问题吗？
t = cat.Transaction("Trans", "t3")
t.complete()
[Running] python3.7 -u "/Users/neil/Desktop/python/2.py"
cat sdk has not been initialized!
cat sdk has not been initialized!
Traceback (most recent call last):
File "/Users/neil/Desktop/python/2.py", line 22, in
test()
File "/usr/local/lib/python3.7/site-packages/cat/transaction.py", line 107, in wraps
return func(*args, **kwargs)
File "/usr/local/lib/python3.7/site-packages/cat/transaction.py", line 99, in exit
self.complete()
File "/usr/local/lib/python3.7/site-packages/cat/transaction.py", line 46, in complete
self._trans.complete(self._trans)
AttributeError: 'NoneType' object has no attribute 'complete'

python基本的环境以及语法可以在review下。

兄弟你解决了吗

pycat不支持windows 用mac或者linux核心的乌班图这种就好了


Update physics version for A-Frame v0.4.0

/cc @ngokevin

@ngokevin Should we give @donmccurdy rights to merge to the repo so he can help curating the registry?

Ok, also working on a bot for automated bumps


Widgets on lists with filters don't update on filter change

Bug report
What I did
Set up a CRUD list with filters and a widget displaying info based on the items in the list.
What I expected to happen
Widget info to update when filters are changed.
What happened
The widget doesn't update when filters are changed but the info is correct after a page refresh.
What I've already tried to fix it
??
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
### PHP VERSION:
PHP 7.3.10 (cli) (built: Sep 24 2019 12:36:21) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.10, Copyright (c) 1998-2018 Zend Technologies

### LARAVEL VERSION:
laravel/framework                     v6.5.0           The Laravel Framework.

### BACKPACK VERSION:
backpack/crud                         4.0.12           Quickly build an admin interfaces using Laravel 6, CoreUI, Boostrap 4 and jQuery.
backpack/generators                   2.0.4            Generate files for laravel projects
backpack/permissionmanager            v4.x-dev 65a7775 Users and permissions management interface for Laravel 5 using Backpack CRUD.
backpack/settings                     v4.x-dev 4891019 Application settings interface for Laravel 5 using Backpack CRUD.

Hi @oddvalue ,
Can I see the code for your widget please? And where you add it to your controller?
Cheers!

Hi @tabacitu ,
The widget is on a list of time logs for multiple users. The list has a filter for the users so ideally I'd like the widget to refresh when the filter is used based on the user id in the request: $this->request->input('user_uuid')
This is my widget code:
            $this->data['widgets']['before_content'] = [
                [
                    'type'        => 'progress_white',
                    'class'       => 'card mb-2',
                    'value'       => $userTime/60,
                    'description' => 'Time logged.',
                    'progress'    => floor($userTime/(6*60)*100),
                    'progressClass' => 'progress-bar bg-primary',
                ],
            ];

This is added in the setupListOperation method in the CRUD controller.
Thanks

Hello @oddvalue ,
if i understood correctly you have a Entity Crud and in that Entity Crud List View you have a Widget.
When you filter the Entity Crud List you would like the widget to show the info of the filtered results?
I think that would be a little tricky.
When you filter the list, an ajax call is made that returns the filtered results to display in table.
The only thing that is updated is the table with the filtered results not the view itself. Widget is already on page when the returned data reaches the view after the filter ajax call.
I can see that working (not tested just thinking and writing about it):
Create a custom widget (you can copy the boilerplate from one of the package widgets), the change that you would make is adding unique id's that you could later use to identify the elements.
@if (isset($widget['value']))

{!! $widget['value'] !!}

      @endif

Also when defining the widget in the controller make sure you use viewNamespace to point to your new widget.
Listen to draw event of the table:
$('#crudTable').on( 'draw.dt', function(element, dtsettings) {
//get the loaded user in table and updated the widget information
 }

Maybe there is a better option, but the purpose of widgets in the list view is not to show a specific item info. For that you could use the detailsRow that is something that is shown "per" row.
Hope it helps,
Pedro

Closing this as i think this is not really an issue.
If you think I am wrong please re-open it and add your toughts. It's not the first time i was wrong. :)
If you have further questions that is not a BUG/FEATURE you can ask them in our gitter channel .
Best,
Pedro

would be really nice to add this feature

@aizekjohn - totally agree. Bumped into this myself a few times, annoying to have to find workarounds every time. Added an issue for it here so we remember to get it done - https://github.com/Laravel-Backpack/ideas/issues/126

@chheng22 you can add widgets to any controller, see the docs here. But keep in mind that in order for those widgets to look like in the docs, they need the CSS & JS to be onpage. So your views should extend the backpack views. See the docs for creating custom pages in Backpack for more info.
Cheers!

Thank too much brother.
On Thu, Mar 3, 2022 at 11:02 PM Cristian Tabacitu @.***>
wrote:

@chheng22 https://github.com/chheng22 you can add widgets to any
controller, see the docs here
https://backpackforlaravel.com/docs/5.x/base-widgets#how-to-use. But
keep in mind that in order for those widgets to look like in the docs, they
need the CSS & JS to be onpage. So your views should extend the backpack
views. See the docs for creating custom pages in Backpack
https://backpackforlaravel.com/docs/5.x/base-about#custom-pages-1 for
more info.
Cheers!
—
Reply to this email directly, view it on GitHub
https://github.com/Laravel-Backpack/CRUD/issues/2200#issuecomment-1058198681,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWZ5WE4DNGGTX4GA44UMKK3U6DPCXANCNFSM4JJUTLLQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

hello sir, i want to separate when i got widgets from controller, i want to separate section can or not ? thank


fix: add error checks for integrated devnet process

Usage related changes

Users don't need to change anything, they will just receive better error messages if integrated-devnet fails suddenly

Development related changes

It should not affect CI/CD

Checklist:

[ ] Formatted the code
[ ] No linter errors
[ ] Tried to avoid introducing linter warnings
[ ] Performed a self-review of the code
[ ] Rebased to the last commit of the target branch (or merged it into my branch)
[ ] Documented the changes
[ ] Updated the test directory
[ ] Created a PR to the plugin branch of starknet-hardhat-example:

[ ] Modified test.sh to use my example repo branch
[ ] Restored test.sh to to use the original branch (after the example repo PR has been merged)

[ ] All tests are passing

Thanks for the clarification, I merged your PR into a non-master branch, and will combine it with #132


Add API CGWindowListCopyWindowInfo

add CGWindowListCopyWindowInfo  API to display.rs.

This change is

r? @pcwalton

@bors-servo: r+

:pushpin: Commit d1cb1a7 has been approved by pcwalton

:hourglass: Testing commit d1cb1a7 with merge 0d46652...

:sunny: Test successful - travis