Add support for psetv2

This contribs to the initial effort of @sekulicd in #184 and takes the psetv2 package to a ready-to-use version.
I made a huge refactor regarding named variables, errors messages, and, more importantly, the business logic.
In particular, the blinder role has been basically split into 2 fundamental parts:

confidential.BlinderHandler is the one in charge of handling private keys to unblind inputs and public keys to generate blinding data, ie. blinders, commitments, and proofs
psetv2.Blinder is the role in charge of adding blinding data to pset's input issuances or outputs.
This closes #167
This closes #189

Minor: I added some (tested) util methods to the elementsutils package and renamed the existing ones. They all come from projects using this lib. There, we noticed both the usefulness and the lack of such methods, so this seemed a gold opportunity to add them all.
Shouldn't be that problematic fixing their usage in other projects once updating go-elements to the next version.

I would prefer to rename blinder.Blind into blinder.AddBlinders or eventually split it up into two methods like blinder.AddIssuanceBlinders and blinder.AddOutputBlinders to keep the methods shorters if possible.
Also I am more fan of two separated method AddOutputBlindersNotLast and AddOutputBlindersLast instead of an implicit boolean, what do you think?

Understood splitting Issuance and Output blinders can be problematic with state, but would split last and nonLast methods?

I suggest that in future we do changes over existing PRs, since this way we lose commit and contributor history and its harder to review.

My branch adds commits to yours (the one for which you opened #184) in order to not lose any of your contributions indeed. And I also think this was the best way to go because otherwise, in order to add commits to your branch, I would have needed write rights on your repo. This is not something you should want to grant to other users over your repos, in general.

I dont understnad why it is important to extract some blind/sign logic from pset pkg itself.

Extracting the singing logic from the pset is essential to allow every wallet supporting psetv2 to use this library. Otherwise, following your idea, only wallets allowing to dump private keys and use them manually could use our psetv2 pkg. For sure this is not ideal for the usability of the library.
As you showed with your example, I think it's totally fine that one produces the signatures on his own and then uses our signer to add them to the partial transaction, with the role ensuring that everything's correct when doing such operation.
For blinding, we actually shouldn't need such "extraction". We need it though to make psetv2 not dependent from secp256k1-zkp, which is a CGO porting and cause troubles if we want to compile psetv2 to WASM.
So I decided to isolate blinding key management into the handler, which is dependent from secp256k1-zkp and responsible for generating commitments, proof etc and also to unblind blinded data, just like a wallet handle keys to produce signatures to make a comparison.
The other part is the pset's blinder role which ensures that everything's correct when adding commitments, proofs etc to input issuances or outputs. Furthermore, it takes care of keeping the global scalars up-to-date, which is something very pset related.

My branch adds commits to yours (the one for which you opened https://github.com/vulpemventures/go-elements/pull/184) in order to not lose any of your contributions indeed.

Hmm in my IDE i was not able to see history of commits, but now when i check GH history i see them, sorry.

Extracting the singing logic from the pset is essential to allow every wallet supporting psetv2 to use this library. Otherwise, following your idea, only wallets allowing to dump private keys and use them manually could use our psetv2 pkg. For sure this is not ideal for the usability of the library.

Sorry i dont understand this fully, if wallet wants to sign tx it needs to access to priv key? Can u elaborate more on this and maybe if you have example of a wallet which fits your scenario?

For blinding, we actually shouldn't need such "extraction". We need it though to make psetv2 not dependent from secp256k1-zkp, which is a CGO porting and cause troubles if we want to compile psetv2 to WASM.

secp256k1-zkp is referenced, in pset pkg, through confidential pkg and that is the reason I introduced this interface for "confidential" methods, so basically moving out blinder logic only to be able to compile WASM seems not a valid reson.

One last thing, I think we need to move pset_test.go in other pkg if we want to decouple pset from confidential.

Regarding decoupling from secp256k1-zkp, did u checked this?

One last thing, I think we need to move pset_test.go in other pkg if we want to decouple pset from confidential.
Regarding decoupling from secp256k1-zkp, did u checked this?

The package declared in pset_test.go is psetv2_test, which is  not psetv2. This lets us import psetv2 as external pkg to have the exact "pov" of the user. Importing psetv2 in other projects won't import psetv2_test too, therefore it's alright.

Sorry i dont understand this fully, if wallet wants to sign tx it needs to access to priv key? Can u elaborate more on this and maybe if you have example of a wallet which fits your scenario?

In the previous comment, after the blind/sign snippet, you said:

Remember that we are going to replicate above code in all of our projects and it is not part of any pkg but only test.

This is true only for now, just because every wallet we implemented so far are single key P2WPKH wallets, meaning that they sign the inputs in exactly the same way, the one you posted in the snippet.
If we created a sign method like Sign(privateKeys [][]byte, inIndexes[]uint32) implementing your snippet:

Only single-key P2WPKH wallets could use it
Such wallets must have an API to retrieve the list of private keys to provide to the sing method.

And guess what? The majority of single-key wallets outthere are neither native-segwit, nor they let the user directly manipulate private keys such that this hypothetical snippet is possible:
privateKeys := walletSvc.GetPrivateKeys()
signer := psetv2.NewSigner(ptx)
signedPtx :=  signer.Sign(privateKeys, inIndexes)

secp256k1-zkp is referenced, in pset pkg, through confidential pkg and that is the reason I introduced this interface for "confidential" methods, so basically moving out blinder logic only to be able to compile WASM (@tiero) seems not a valid reason.

I think your initial idea is good indeed, I just tried to improve it in order for the user to have a clear separation of things that require blinding keys from those that do not.

https://github.com/btcsuite/btcd/pull/1847


AC-143 new api end point to impersonate user

Description
This PR...

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

I'm struggling to see how this is limited to just root admins. What stops a normal user from accessing the new impersonateUser endpoint?

I need to still push the changes.

I'm struggling to see how this is limited to just root admins. What stops a normal user from accessing the new impersonateUser endpoint?

I need to still push the changes.


ModuleNotFoundError: No module named 'termcolor'

i am sure that i install all the pre-request and no error in that.
as soon in launch python3 eagle-eye.py here comes the error
Traceback (most recent call last):
File "eagle-eye.py", line 8, in
import utils.console as console
File "/root/EagleEye/utils/console.py", line 1, in
from termcolor import colored
ModuleNotFoundError: No module named 'termcolor'
help me please. i know i am noob

First make sure that you are using python3
Then just to make sure everything is installed do
$ sudo pip3 install -r requirements.txt
$ sudo pip3 install --upgrade beautifulsoup4 html5lib spry

Go into the interactive python shell python3
the output when importing termcolor should be:
Python 3.5.2 (default, Nov 23 2017, 16:37:01)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import termcolor
>>>

hi thank you for your reply.
when i did
$ sudo pip3 install -r requirements.txt -> requirement already satisfied
$ sudo pip3 install --upgrade beautifulsoup4 html5lib spry -> requirement already up-to-date
and for this
Python 3.5.2 (default, Nov 23 2017, 16:37:01)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.

import termcolor

it said
Python 3.6.3 (default, Apr  6 2018)
[GCC 6.3.0 20170406] on linux
Type "help", "copyright", "credits" or "license" for more information.

import termcolor
Traceback (most recent call last):
File "", line 1, in
ModuleNotFoundError: No module named 'termcolor'

what did i do wrong?

Maybe you have a pip for python 3.5 and for 3.6 list all your pip binaries with
$ ls /usr/bin | grep pip

For example my arch install has a pip3 (for python 3.5) and a pip3.6 (for python 3.6)

ls /usr/bin | grep pip
lesspipe
pip
pip2
pip3
pipal
pip3 --version
pip 9.0.1 from /usr/lib/python3/dist-packages (python 3.6)

import site; site.getsitepackages()
['/usr/local/lib/python3.6/site-packages']

what to do now

locate termcolor
/usr/lib/python2.7/dist-packages/termcolor-1.1.0.egg-info
/usr/lib/python2.7/dist-packages/termcolor.py
/usr/lib/python3/dist-packages/termcolor-1.1.0.egg-info
/usr/lib/python3/dist-packages/termcolor.py
/usr/lib/python3/dist-packages/pycache/termcolor.cpython-36.pyc
/usr/share/doc/python-termcolor
/usr/share/doc/python3-termcolor
/usr/share/doc/python-termcolor/CHANGES.rst
/usr/share/doc/python-termcolor/README.rst
/usr/share/doc/python-termcolor/changelog.Debian.gz
/usr/share/doc/python-termcolor/copyright
/usr/share/doc/python3-termcolor/CHANGES.rst
/usr/share/doc/python3-termcolor/README.rst
/usr/share/doc/python3-termcolor/changelog.Debian.gz
/usr/share/doc/python3-termcolor/copyright
/usr/share/pyshared/termcolor-1.1.0.egg-info
/usr/share/pyshared/termcolor.py
/usr/share/sqlmap/thirdparty/termcolor
/usr/share/sqlmap/thirdparty/termcolor/init.py
/usr/share/sqlmap/thirdparty/termcolor/init.pyc
/usr/share/sqlmap/thirdparty/termcolor/termcolor.py
/usr/share/sqlmap/thirdparty/termcolor/termcolor.pyc
/var/cache/apt/archives/python3-termcolor_1.1.0-1_all.deb
/var/lib/dpkg/info/python-termcolor.list
/var/lib/dpkg/info/python-termcolor.md5sums
/var/lib/dpkg/info/python-termcolor.postinst
/var/lib/dpkg/info/python-termcolor.prerm
/var/lib/dpkg/info/python3-termcolor.list
/var/lib/dpkg/info/python3-termcolor.md5sums
/var/lib/dpkg/info/python3-termcolor.postinst
/var/lib/dpkg/info/python3-termcolor.prerm
i am using kali linux on vmware

Try using the normal pip not pip3 to install the dependencies. I just used the pre.sh script on a Kali Linux Live Boot and it worked fine.

i did that.. still no module name termcolor. if i may know, what OS did u use to run the program? cause i really want to use this program

My personal Machine is Ubuntu 16.04.
I also tried it on a Kali Linux Live Boot (2018.1) and on a XUbuntu 16.04 Live Boot.
It worked perfectly on all of those Machines.
Note: If you are using Firefox ESR(like Kali does) please use the Geckodriver Version 17


[enhancement request] linter should warn about unpaired double quotes in values.yaml file

Problem: someone accidentally left a " in the values.yaml file, like so:
jobs:
  foo":
    enabled: true

Our templates/template.yaml looks like this:
{{- range $name, $details := .Values.jobs }}{{ if $details.enabled }}
---
apiVersion: batch/v1beta1
kind: CronJob
metadata:
  name: "{{ $name }}"
{{- /*
# more stuff
*/ -}}

When the chart is rendered with helmfile the " breaks the template, like so:

Solution
Linter warns when there is a unpaired quotation mark in a key
I'm still new to helm so my apologies if this isn't a valid issue.

Note that helm lint does not complain about the unpaired " either so maybe this is a issue with helm lint. If so just let me know and I can move the issue.

This issue can be caught by using helm template. For now to catch the error I've added a script to template the charts in our CI

Hmm... So this behaviour would be determined by the YAML parser if I'm not mistaken.
Looking at your image, there does appear to be a few red squiggly lines designating parser errors. Do those errors not provide enough information to determine the issue?
It's worth noting that helm lint only checks that the chart manifest is well-formed. It does not check whether or not the templates will render correctly - that is the responsibility of helm template.
Can you describe the action item you're suggesting we should address? I can't tell what's the expected outcome in terms of concrete action, e.g. "I want more red squiggly lines" or "when I run palette command X, I expect to see an error".
Thanks!


serverXmlFile option with certain directory does not update server.xml when changed

The serverXmlFile option should allow you to specify another file to use as server.xml. The semantics is to copy the specified file to the config directory of the Liberty server with the name server.xml. For example, use a valid server.xml file but call it alt-server.xml and store it in src/main directory of your project. Start the server as normal. Next modify src/main/alt-server.xml and the change will be copied into config/server.xml in the Liberty server and Liberty will honour the changes you made.
However, if you store alt-server in src/main/liberty/config then devmode will copy the file to config/server.xml and the server will seem normal. Then change alt-server.xml and devmode will copy the file to config/alt-server.xml in the Liberty server and the existing server.xml will not be modified and the server will not honour the change just made.
Reproduction steps: start with the demo-devmode project. Rename src/main/liberty/config/server.xml to src/main/liberty/config/alt-server.xml. Add the configuration shown below.
            <plugin>
                <groupId>io.openliberty.tools</groupId>
                <artifactId>liberty-maven-plugin</artifactId>
                <version>3.3.4</version>
                <configuration>
                    <serverXmlFile>src/main/liberty/config/alt-server.xml</serverXmlFile>
                </configuration>
            </plugin>

Start devmode and see the app runs normally. Edit src/main/liberty/config/alt-server.xml and add the feature <feature>mpGraphQL-1.0</feature>. Normally the server would reload feaures but it does not. Examine the directory target/liberty/wlp/usr/servers/defaultServer/ and see the file alt-server.xml and that server.xml is not modified.

We need to be careful how we change this behavior. We copy over all files from src/main/liberty/config as is. Just because alt-server.xml is a server.xml does not mean it should modify an existing server.xml file. This behavior supports having multiple config files and the server.xml should have include elements for those multiple config files. The serverXmlFile property is meant to copy a file from some other location (not src/main/liberty/config) to the server.xml in the created Liberty server. These are separate configurations.

I see from the code comments that the serverXmlFile property is meant to refer to a file outside the config directory. But I would argue that if you have such a property then over-writing an existing server.xml file is the expected behavior. Does it matter if the alternative file is in the config directory or not? Is there a behavior where Liberty reads in all *.xml files?

To summarize, normally (e.g. with liberty:create) the following happens:

Copy the files from src/main/liberty/config to the Liberty server
Copy the file specified in serverXmlFile to the Liberty server and name it as server.xml

According to this issue, if serverXmlFile property is pointing to a file in src/main/liberty/config, dev mode is copying the file to the Liberty server but not naming it as server.xml.  So this is a dev mode bug.

To build on the point from @cherylking ... a user can put any file in src/main/liberty/config and might just to have it get copied into the server config dir.
@ericglau @turkeylurkey ... are you thinking of adding a special case, e.g.:   copy everything in src/main/liberty/config unless it's also referenced via serverXmlFile, and then don't copy it.
Would the handling of jvmOptionsFile and serverEnvFile need to be revisited then?

If using liberty:create, based on the scenario in the original description, it would have two copies (alt-server.xml copied from src/main/liberty/config, and server.xml copied from serverXmlFile and renamed to server.xml).  @scottkurz yes, this ends up being an odd situation.  And I think the same would apply to jvmOptionsFile and serverEnvFile.
We have 3 options:

Don't support serverXmlFile, jvmOptionsFile, or serverEnvFile pointing to a file within the same directory as the configDirectory parameter (which by default is src/main/liberty/config).  Document this and give an error in the plugins for this scenario.  I don't like this approach since this may break current usage (in case the user pointed serverXmlFile to src/main/liberty/config/server.xml which is redundant but not wrong)
Leave create as-is, but fix dev.  So the problem with two copies of the same file can still occur as mentioned above.  But this shoudn't cause any issues at runtime, right?
Fix both create and dev.  Do the special case that @scottkurz mentioned e.g. copy everything from configDirectory unless it's also referenced via serverXmlFile, jvmOptionsFile, or serverEnvFile , and then don't copy it.

I'd like to focus on the statement "The serverXmlFile property is meant to copy a file from some other location (not src/main/liberty/config) to the server.xml." If there is a rule that serverXmlFile cannot specify anything in src/main/liberty/config then this bug can be avoided. We'll just validate serverXmlFile at start-up and terminate devmode. So this definition is needed to decide on the correct fix here.

I don't think there is a problem with jvmOptions or serverEnv because there is a special code block for serverXmlFile which we may not hit.
I am in favor of serverXmlFile overwriting server.xml because it is very easy to understand and to document. We just need to fix devmode to handle changes to the file and not treat it like other config files.

Let me clarify.  If you specify
                <configuration>
                    <serverXmlFile>/Users/eric/git/demo-devmode/src/main/liberty/config/alt-server.xml</serverXmlFile>
                    <serverEnvFile>/Users/eric/git/demo-devmode/src/main/liberty/config/alt-server.env</serverEnvFile>
                    <jvmOptionsFile>/Users/eric/git/demo-devmode/src/main/liberty/config/alt-jvm.options</jvmOptionsFile>
                </configuration>

Then currently the result from liberty-create is:

Generally, dev mode should follow the same behaviour as liberty-create.  The question is: is liberty-create wrong?

Note: we do support serverXmlFile to overwrite a config/server.xml file and we display the warning "The " + serverXMLPath + " file is overwritten by the "+serverXmlFile.

Let me clarify. If you specify
                <configuration>
                    <serverXmlFile>/Users/eric/git/demo-devmode/src/main/liberty/config/alt-server.xml</serverXmlFile>
                    <serverEnvFile>/Users/eric/git/demo-devmode/src/main/liberty/config/alt-server.env</serverEnvFile>
                    <jvmOptionsFile>/Users/eric/git/demo-devmode/src/main/liberty/config/alt-jvm.options</jvmOptionsFile>
                </configuration>

Then currently the result from liberty-create is:

Generally, dev mode should follow the same behaviour as liberty-create. The question is: is liberty-create wrong?

The reason you see the original files and the new files is because the xxxFile parameters referenced files in the src/main/liberty/config folder. The entire src/main/liberty/config folder gets copied over. Then the xxxFile parameters are processed. As documented, the referenced files are renamed to what the server expects (server.xml, jvm.options, server.env). Logic could be put in place to optimize the case where the xxxFile parameters reference files located in src/main/liberty/config. We just didn't foresee this scenario I think.

The problem was that devmode was executing the jvmOptions handling code for serverXmlFile changes rather than the serverXmlFile handling code. With this fix serverXmlFile changes will cause execution of the appropriate code and jvmOptions changes will still execute the jvmOptions handling code.


If customer login from checkout page then after logged in it should redirect to checkout page.

Framework Version: 0.1.6

Fixed


Bundle install with path and excluding a group fails when Gemfile.lock is present.

Here is my Gemfile and Gemfile.lock:
#Gemfile
source 'https://rubygems.org'
gem 'json', github: 'flori/json', group: :development

#Gemfile.lock
GIT
  remote: git://github.com/flori/json.git
  revision: f7394adf3a50631b443135a95ec1bc9d8b8f32ab
  specs:
    json (1.8.3)

GEM
  remote: https://rubygems.org/
  specs:

PLATFORMS
  ruby

DEPENDENCIES
  json!

BUNDLED WITH
   1.10.6

The following command fails if we don't have the gem from Github already checkout in vendor/bundle.
bundle install --path=vendor/bundle --without development
It works if the Gemfile.lock is not present. Removing the Gemfile.lock is a work around.
Shouldn't this work or is there anything I'm doing wrong?

Fails how? Can you please paste the output?

Hi, here is the output. This only happens when we try to do a bundle install locally without a group that has gem from git.
bundle install --path=vendor/bundle --without development
git://github.com/flori/json.git (at master) is not yet checked out. Run `bundle install` first.
Bundler gave the error "git://github.com/flori/json.git (at master) is not yet checked out. Run `bundle install` first." while processing "/Users/pareshsharma/Workspace/xtra/test/Gemfile". Perhaps you forgot to run "bundle install"?

I could reproduce the error following the steps you've described.
With a little digging, it seems that #resolve_if_need doesn't actually resolves the depencies when it should, or? This happens because local is set to true:
# ...
begin
  tmpdef = Definition.build(Bundler.default_gemfile, Bundler.default_lockfile, nil)
  # `tmpdef.missing_specs` is empty therefore `local` is set to `true`
  true unless tmpdef.new_platform? || tmpdef.missing_specs.any?
rescue BundlerError
end
# ...

I'm not sure however if JSON in that case should appear as a missing spec, since --without actually downloads but doesn't install the gems.

I think that missing_specs should have json in it if the gem is in the Bundle; the installer will skip installing the gem later if it's in a without group.

Verified that this has been fixed in v1.11.2.
$ bundle install --path=vendor/bundle --without development
Fetching git://github.com/flori/json.git
Fetching gem metadata from https://rubygems.org/.........
Fetching version metadata from https://rubygems.org/..
Resolving dependencies...
Using bundler 1.11.2
Bundle complete! 1 Gemfile dependency, 1 gem now installed.
Gems in the group development were not installed.
Bundled gems are installed into ./vendor/bundle.

@RochesterinNYC The issue still persists with v1.11.2. Please find below the trace for the same.
➜ ll
total 16
-rw-r--r--  1 paresharma  staff    84B Mar  5 22:10 Gemfile
-rw-r--r--  1 paresharma  staff   235B Mar  5 22:15 Gemfile.lock
drwxr-xr-x  3 paresharma  staff   102B Mar  5 22:12 vendor

➜ cat Gemfile
source 'https://rubygems.org'
gem 'json', github: 'flori/json', group: :development

➜ cat Gemfile.lock
GIT
  remote: git://github.com/flori/json.git
  revision: f7394adf3a50631b443135a95ec1bc9d8b8f32ab
  specs:
    json (1.8.3)

GEM
  remote: https://rubygems.org/
  specs:

PLATFORMS
  ruby

DEPENDENCIES
  json!

BUNDLED WITH
   1.11.2

➜ bundle --version
Bundler version 1.11.2

➜ bundle install --path=vendor/bundle --without development
git://github.com/flori/json.git (at master@f7394ad) is not yet checked out. Run `bundle install` first.

Okay, apologies. The exact Gemfile.lock you had was necessary to reproduce this.
Quick question, what is the intended/expected behavior here? That this would be essentially a no-op because of the --without development?

@RochesterinNYC: Hi, I am interested in resolving this

@asutoshpalai sure, go ahead.

Running bundle install should check out git repos that are missing—it shouldn't be possible to get the "not checked out yet" error while running the install command. Theoretically, git repos should not be checked out if you also pass the --local option, but that is currently not implemented. This is definitely a bug.

@asutoshpalai please let me know if you intend on resolving this, as I already might have a fix.

Yes, I am still interested in resolving this, but I see that there is a already pull request for a related issue.
Sorry for the delay, I was stuck in some inevitable circumstances. Should I still go ahead on this?

If you're referring to #4353, that is a pull request for something different than this exact issue (it's related to the part of @indirect's comment.

Yes, indirect's comment made me think so, my bad.  I had investigated the issue a bit and now I am writing a failing spec for this issue.

bundle install --path=vendor/bundle fails because bundle install --path=vendor/bundle --without development is ran once and so it is added to the .bundle/config. Then running bundle install --path=vendor/bundle actually run without the group development. If you run it on a fresh reproduction of the issue, it runs fine.


Sheet for Masks: a new generation in French

This is a straight french translation of the sheet made by Matt Morton.
Pictures containing text aren't translated yet, as Magpie Games has not given the pictures in french yet (should happen in a few months with the official french translation of the game).

We have stopped accepting "alternate translation" sheets to try and slim down the total number of sheets we have, see here for more info. If you want to add a new translation for a sheet, we ask that you use the character sheet translation tools. This will allow the original sheet to not only support French, but any other language one of our users might translate it to. I'm sorry for the inco


Improved Scrollbar

PR Fixes:
Resolves #520
Improved Scrollbar to associate with the Modern Look of CRM

hey @aakash-a-dev I have tried similar thing in #463

Hey @aakash-a-dev I have tried similar thing in #462 #463

Dont think this is needed atm


Compatibility with new linux kernel #16

Use the new wrapper functions in the Linux kernel

My merge request is inferior to https://github.com/myriadrf/xtrx_linux_pcie_drv/pull/17/files so I'm closing this MR in favor of the one from @myriadrf.


fix: DBTP-1375 - platform helper version get-platform-helper-for-project no longer validates config

Addresses DBTP-1375
When the platform-helper version get-platform-helper-for-project command was called, config validation was being done twice.  First, in the command decorators and again while executing the command.  These validations fail if the configuration found in platform-config.yml is for a different version of platform-helper than that currently installed, resulting in errors.
This PR fixes the errors by making the following changes:

add functions in platform_config.py to read and load the platform-config.yml file, ignoring yaml and configuration errors
new unit tests for the new load and read functions
get_environment_pipeline_names uses the new function so no longer validates config
get_platform_helper_for_project uses the new function so no longer validates config
get_platform_helper_for_project and version functions are moved into a new class, VersionCommand.  This is so that a new class instance can be created in tests, which re-evaluates the click decorators based on the current state of the filesystem.
new unit tests covering the version command given invalid config, and config with invalid yaml in platform-config.yml

Checklist:
Title:

[x] Scope included as per conventional commits
[x] Ticket reference included (unless it's a quick out of ticket thing)

Description:

[x] Link to ticket included (unless it's a quick out of ticket thing)
[x] Includes tests (or an explanation for why it doesn't)
[ ] If the work includes user interface changes, before and after screenshots included in description
[ ] Includes any applicable changes to the documentation in this code base
[ ] Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

[ ] Trigger the pull request regression tests for this branch and confirm that they are passing

@ksugden / @antroy-madetech I haven't had time/headspace to do a decent review on this. I trust you to to have it covered between you.


Email Extractor

Description 📜
A fully responsive web app based Email Extractor
Fixes #1306

Type of change 📝
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[x] Add a new project

Domain of Contribution 📊
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[x] Project using HTML, CSS & JS

Checklist ✅
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[x] I have performed a self-review of my own code or work.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[x] I'm GSSoC'22 contributor

Screenshots / Gif (Recommended) 📸
https://user-images.githubusercontent.com/82095877/167263879-22a14236-3efe-4eb2-86e6-552620edaa56.mp4

@gurjeetsinghvirdee pls bhai ji


UDP Hole Punch

https://github.com/CreggHancock/HolePuncher

[ ] migrate the code to v4.1.1 and cleanup
[ ] add support to the Network manager
[ ] provide resources to set up a rendezvous server

https://docs.google.com/document/d/10xLhy-lKzxeNbEQjZ63a5lshe-_nfrmTytyNMjp6Ouc/edit?usp=drivesdk

Netfox already has this (noray)


how to disable mini.paris when recording or playing macros

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini.pairs
Description
add an option to disable mini.pairs when recording or playing macro

vim.api.nvim_create_autocmd({ "RecordingEnter" }, {
  group = augroup("disable_minipairs_when_using_macro"),
  callback = function(event)
    vim.g.minipairs_disable = true
    vim.notify("minipairs disabled")
  end,
})
-- this only works for recording
-- how can we disable minipairs also on playing?

Thanks for the suggestion!
My advice would be to press <C-v> prior to any pair-specific character if you want it to be inserted literally.
If you don't want to do that, having this type of autocommand is the way to go. But don't forget to  also reenable pairs on RecordingLeave event. As to how disable them on replaying, there is no event for that (yet, see neovim/neovim#24565).
Closing as not planned.

https://github.com/windwp/nvim-autopairs/blob/0f04d78619cce9a5af4f355968040f7d675854a1/lua/nvim-autopairs.lua#L173
Thank you, found something in another repo.

<EMAIL_ADDRESS>Thank you, found something in another repo.

@echasnovski hello, I've tried with the approach linked by @konosubakonoakua and it works quite good, would you re-consider this feature?

I tried with something as simple as:

Having this logic inside H.is_disabled() is an interesting and reasonable approach. However, I do still stand by "My advice would be to press <C-v> prior to any pair-specific character if you want it to be inserted literally.".

I tried with something as simple as:

Having this logic inside H.is_disabled() is an interesting and reasonable approach. However, I do still stand by "My advice would be to press <C-v> prior to any pair-specific character if you want it to be inserted literally.".

I'm using <C-v> as well now.


Blocked by Please answer the CAPTCHA

I followed the example and am blocked by a CAPTCHA request:

import humblebundle
client = humblebundle.HumbleApi()
client.login("_", "_*_")
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python3.5/site-packages/humblebundle/decorators.py", line 20, in wrap
result = func(_args, **kwargs)
File "/usr/lib/python3.5/site-packages/humblebundle/client.py", line 115, in login
return handlers.login_handler(self, response)
File "/usr/lib/python3.5/site-packages/humblebundle/handlers.py", line 76, in login_handler
captcha_required=captcha_required, authy_required=authy_required)
humblebundle.exceptions.HumbleCaptchaException: Please answer the CAPTCHA

I'm not sure how to get past this error... Any suggestions?

Are you on master/v1.1?

I hit this with master (=32bb05c42979ac3de6d8abf103825412e473dfc9) but not immediately, only after the third attempt to run the script.


Change dynamic analysis requirements to SUGGESTED

I  think we should drop the dynamic analysis requirement to SUGGESTED.
The problem is that too many projects (including big ones) don't meet it, which means it's too strong a requirement to make it a MUST.
There are ways, of course, to meet the dynamic criteria. Dynamic analysis is all about running the code in a way that’ll help find bugs/vulnerabilities.  If you're writing a small C/C++ program that accepts files, American Fuzzy Lop (AFL) is really awesome.  If you're writing a web application, tools like OWASP ZAP are also awesome.  If you have high test coverage (80% or more), the current criteria text also accepts you.   In many other cases I’d write a fuzzer specific to its APIs & generate random inputs based on them, and add lots of assertions that are at least enabled during fuzzing.  If you know your API (or can introspect it), creating a specific fuzzer is pretty easy – grab your random number generator, set up an isolated container or VM for the fireworks, and go.
However, while it's possible to do it, this set of best practices isn't intended to be some sort of improbable-to-attain list.  We can make it a stronger requirement at higher badge levels, but we don't want to wash out lots of projects early on.

Yes, I've wanted this change for a while.
--
Dan Kohn<EMAIL_ADDRESS>tel:+1-415-233-1000
On Mon, Nov 2, 2015 at 9:55 PM, David A. Wheeler<EMAIL_ADDRESS>wrote:

I think we should drop the dynamic analysis requirement to SUGGESTED.
The problem is that too many projects (including big ones) don't meet it,
which means it's too strong a requirement to make it a MUST.
There are ways, of course, to meet the dynamic criteria. Dynamic analysis
is all about running the code in a way that’ll help find
bugs/vulnerabilities. If you're writing a small C/C++ program that accepts
files, American Fuzzy Lop (AFL) is really awesome. If you're writing a web
application, tools like OWASP ZAP are also awesome. If you have high test
coverage (80% or more), the current criteria text also accepts you. In many
other cases I’d write a fuzzer specific to its APIs & generate random
inputs based on them, and add lots of assertions that are at least enabled
during fuzzing. If you know your API (or can introspect it), creating a
specific fuzzer is pretty easy – grab your random number generator, set up
an isolated container or VM for the fireworks, and go.
However, while it's possible to do it, this set of best practices isn't
intended to be some sort of improbable-to-attain list. We can make it a
stronger requirement at higher badge levels, but we don't want to wash out
lots of projects early on.
—
Reply to this email directly or view it on GitHub
https://github.com/linuxfoundation/cii-best-practices-badge/issues/127.


Types

I have implemented the types (former AttributeValues) and renamed them to types to be closer to Mjml.
Most types are super easy, thanks to unit parser and composition.
I also realized that there is some type of cleanup. At least the color type implements something like this in MJML. So I have added the same. I did not went through all the code to find the place, but I am sure it works like I have described.

Closes #19

It looks like the blast radius would be the Allowed and Default attributes.

What do you mean with that?

Apologies, ignore my message. I'm happy to merge.


login.py: SOAP XML response with British pound symbol causes encoding error

While using British pounds for currency, during the SOAP API call to authenticate, a response is returned from Salesforce which contains this line:
<currencySymbol>£</currencySymbol>

The login.py code tried to parse the response with this line:
xml_value = xml.dom.minidom.parseString(response.text)

The following error occurred:
UnicodeEncodeError: 'ascii' codec can't encode character u'\xa3' in position 777: ordinal not in range(128)

I have a proposed fix for this, which is to remove the  node from the XML response string.  I will post the patch shortly.

I don't have rights to push a branch. Here is a diff for my code changes:
--- a/salesforce/login.py
+++ b/salesforce/login.py
@@ -3,6 +3,7 @@ from exception import AuthenticationFailed
 import urllib
 import utils
 import xml.dom.minidom
+import re

 class Authentication(object):
@@ -165,7 +166,10 @@ class LoginWithSoapAPI(Login):
                                       headers,
                                       data=data)

-        xml_value = xml.dom.minidom.parseString(response.text)
+        # Remove currency symbol from XML response
+        response_text  = re.sub('<currencySymbol>.*</currencySymbol>', '', response.text)
+
+        xml_value = xml.dom.minidom.parseString(response_text)
         access_token = utils.get_element_by_name(xml_value, 'sessionId')
         url = urlparse(utils.get_element_by_name(xml_value, 'serverUrl'))
         instance_url = '{0}://{1}'.format(url.scheme, url.netloc)

I forked the repo and created a pull request from my branch into this master: #9


fail gracefully when dat share is already running fixes #561

fixes #561

Looks good to me! Thanks for putting those error functions in one place!

Nice and simple, do we need a test?

I tried adding a test but couldn't figure out how to trigger it, the simple stupid way of running a dat instance, not closing it, and opening another one with the same command was not working.

I tried adding a test but couldn't figure out how to trigger it, the simple stupid way of running a dat instance, not closing it, and opening another one with the same command was not working.

did you try with a child process too?

added a test

thanks @joehand ! I forgot the {end: false}!


3D features ignore terrain elevation

Describe the bug
With terrain elevation turned on, everything is floating in the air. Location is irrelevant, only determines how high things float.
Expected behavior
Things should clamp to the ground.
Screenshots

System information

OS: macOS Ventura 13.3.1 (22E261)
Browser with version: Safari 16.4 (186<IP_ADDRESS>.23)

Additional context
Console shows possibly related warning:
[Log]     Vendor: Apple Inc.                         (main.460c71927472f098d2fd.js, line 4206)
          Renderer: Apple GPU
[Warning] Couldn't sample height                     (main.460c71927472f098d2fd.js, line 4192, x6)

Seems to be a Safari related problem, reported also with Safari 16.3 (link)

I experience a possibly related problem #133

I'm seeing the same issue with Safari 16.5.2, note that the buildings on the nearby mountain (Züriberg) at around 600m altitude seem to correctly elevated, while the buildings in the plains (~430m) seem to be flying.

It would be nice to know if on Safari the strange behavior shown in 133#issuecomment-1611086030 is also present.

Not that exact behavior, but it really is weird: https://www.youtube.com/watch?v=o66AbxiUXxE

pressed only a s and d, then panned with mouse a bit
Safari 16.4 (186<IP_ADDRESS>.23).

The issue still persists in Safari 17.2.1.

@bloerwald @ivanbranco @kayD @wiesmann @gy-mate
Hi guys, please let me know if any of you can still reproduce this problem. It seems like there was a bug in some webgl implementations related to immutable textures (or it's just me not using this part of the API properly), it should be fixed now.

@StrandedKitty No issues with floating any more, neither on Firefox 120.0, nor on Vivaldi 6.5! Thanks so much!

Also fixed in Safari, thank you very much.

Original location to confirm, beautiful drop down to the neighbouring village. :)

@bloerwald which one is the correct image, the elevation in the second screenshot is much more pronounced. Was this another problem apart from the floating buildings?

@bloerwald which one is the correct image, the elevation in the second screenshot is much more pronounced (can be easily seen by flipping the two images back and forth). Was this another problem apart from the floating buildings?

Bottom one is with enabled terrain, top with disabled, see settings in top right. Terrain was fine before, it was only the buildings from what I can remember. Features are now correctly attached to terrain.

 Thanks for the answer!


enclave-tls: introduce LVI mitigations by default

Signed-off-by: Shirong Hao<EMAIL_ADDRESS>

In addition, I don't see the mitigation part for trusted wolfssl.

Please  explain the use of mitigation in readme.


Support for Release Tracking

To match other clients, release is supplied as part of initial config.

This is great, thanks.  What do you think about handling this like context rather than its own parameter (like 'platform' or 'logger')?  This would allow it to change at runtime (although that should be rare) and wouldn't not need the Maybe.  This may result in more consistent behavior.  If you don't have a strong opinion about it, I will go ahead and make that change and release with that.

That makes sense :) thanks
On Tue, Jul 5, 2016, 14:24 Matt Harrington<EMAIL_ADDRESS>wrote:

This is great, thanks. What do you think about handling this like context
rather than its own parameter (like 'platform' or 'logger')? This would
allow it to change at runtime (although that should be rare) and wouldn't
not need the Maybe. This may result in more consistent behavior. If you
don't have a strong opinion about it, I will go ahead and make that change
and release with that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/getsentry/perl-raven/pull/14#issuecomment-230607549,
or mute the thread
https://github.com/notifications/unsubscribe/AAKPXHMmZjn8oC3qEEZXTYZ-d9-Fr4XAks5qSsuFgaJpZM4JDnFk
.

I've rolled your changes into https://github.com/getsentry/perl-raven/pull/15 which I am preparing for release.  Let me know if you have any concerns with the changes.


Ownca role has warning due to jinja templating delimeters being within a conditional statement 'when'

TASK [bloodymage.autonomy.ownca : Ensure we have a password for the Intermediate and Issuing Certificate Authorities.] ***********************************************************************************************************************
[WARNING]: conditional statements should not include jinja2 templating delimiters such as {{ }} or {% %}. Found: ownca_{{ item }}password == "password"
[WARNING]: conditional statements should not include jinja2 templating delimiters such as {{ }} or {% %}. Found: ownca{{ item }}password == "password"
[WARNING]: conditional statements should not include jinja2 templating delimiters such as {{ }} or {% %}. Found: ownca{{ item }}_password == "password
Not really sure how to fix this.

Split into multiple tasks

Completed


[Bug]: Aggregrate sensors for interior and exterior temperature not created

System Health details
System Information

version
core-2024.10.4

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.12.4

os_name
Linux

os_version
6.6.31-haos-raspi

arch
aarch64

timezone
Europe/Amsterdam

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

HACS Data
ok

GitHub API Calls Remaining
5000

Installed Version
2.0.1

Stage
running

Available Repositories
1459

Downloaded Repositories
37

Home Assistant Cloud

logged_in
false

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 13.2

update_channel
stable

supervisor_version
supervisor-2024.10.3

agent_version
1.6.0

docker_version
27.2.0

disk_total
109.3 GB

disk_used
81.8 GB

healthy
true

supported
true

host_connectivity
true

supervisor_connectivity
true

ntp_synchronized
true

virtualization

board
rpi4-64

supervisor_api
ok

version_api
ok

installed_addons
Mosquitto broker (6.4.1), Duck DNS (1.18.0), NGINX Home Assistant SSL proxy (3.11.0), Grocy (0.22.1), Log Viewer (0.17.1), File editor (5.8.0), SQLite Web (4.2.2), Grafana (10.1.3), ESPHome (2024.10.2), Zigbee2MQTT (1.40.2-1), InfluxDB (5.0.1), AdGuard Home (5.1.4), Home Assistant Google Drive Backup (0.112.1), Local VLC (18), Frigate (0.14.1), Studio Code Server (5.17.2), room-assistant (2.20.0), Advanced SSH & Web Terminal (19.0.0), Music Assistant Server (2.3.2), DbStats (0.5.11)

Dashboards

dashboards
4

resources
18

views
19

mode
storage

Recorder

oldest_recorder_run
October 29, 2024 at 5:58 PM

current_recorder_run
October 29, 2024 at 7:07 PM

estimated_db_size
587.43 MiB

database_engine
sqlite

database_version
3.45.3

Spotify

api_endpoint_reachable
ok

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of any previous issues..

Describe the issue
In a prior version, I had aggregrates for the interior and exterior temperatures.
That was quite handy combined with a template sensor to calculate the difference.
In the current version of Magic Areas, this is no longer working.
Sadly I did not keep track of from which version I upgraded.
The documentation about meta areas seems to suggest it should still work, and the configuration to specify the meta area of the regular areas is also still present.
The regular areas do have temperature aggregrates
There are roughly 4 such temperature aggregrates to be aggregrated to interior
(and yes, my regular areas are set to interior)
Note for the interior area, three aggregates were created. I've disabled these: Duration [s], Voltage [lux] and Voltage [V]
Reproduction steps

Have various temperature sensors in areas marked as being either interior (or exterior) areas
Configure the Interior (or Exterior) area to have aggregrates for temperature
2a. Note I have also tried this with a minimum of 1 sensor required for aggegrate creation
Hit save & exit
Restart home assistant
Debug log shows the Temperature sensor is present both in the Validationg aggregrate sensor for the Interior error as well as saving aggregrate sensor lines
Check the interior aggregrate entities, either through a direct entity search or through the entities related to the interior area in the Integration's page.

Debug logs
I'll try to attach it as a file, as GitHub is complaining it is too long.

Diagnostics dump
No response

home-assistant_magic_areas_2024-11-03T19-26-20.069Z.log
PFA the log Home Assistant presented after turning off debug logging.
I've done minor modifications for privacy's sake (removing coordinates, car license plate, etc.)

Hi, I'm currently traveling abroad and skimming logs through my phone is a nightmare. I'll be back later this week and will go over your logs. Meanwhile can you add screenshots of the magic area device entry for interior exterior and one area of each type?

Interior feature showing aggregrates is on

Interior aggregrates

Interior basic options excluding some temperature measures like the basement and the attic.

Living room basic page showing it's interior and that there are (at least) 3 temperature sensors which can be aggegrated

Living room no exclusions

Living room entities (clickthrough from MA main page - I'm still very happy with that page)

I notice it doesn't automatically set the area for these generated areas... That's not necessarily within the scope of this ticket, but it could be a potential cause. I think it should (with a check to prevent recursion back into the aggregrates).
For Exterior I see I need to check why some sensor devices are no longer linked to exterior areas. I've done some changing on those in the meanwhile (migrated to different weather service for example) so I propose to focus on the Internal example.

Hi, thanks for providing more information. I've still haven't got the time to look into it but it's on my plate and will circle back to you as soon as I can.

Not to worry @jseidl
Life happens, follow up when it's convenient to you

I've cleaned up that includes config, I think that's probably from a much older version.
Good to know they are auto including based on the area of the sensors/entities/devices - I do have that configured.
I haven't done any further debugging on my end, if you have an avenue to investigate I can follow up on or if you would like to hook up in a screen sharing session, happy to collaborate.
Happy holidays!


Win10: takes about 1 minute to return with data on a system with lots of processes

Is there any faster option to get at least some of the data?

Looks like it's not using streaming. Just builds a huge string then synchronously parses it.
My guess is this would just need a total rewrite to be more stream-y for the Windows case.


Fix Fix dict cols not be converted back to string type in some cases.

Proposed changes
Issue Number: close #xxx
Problem summary
Fix dict cols not be converted back to string type in some cases, which includes introduced by #19039.
For dict cols, we will convert dict cols to int32 type firstly, then convert back to string type after read block. The block will be reuse it, so it is necessary to convert it back.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


panics when trying to run

v v1.2.0
 RUST_BACKTRACE=full rustup-toolchain-install-master -n master  -f
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', libcore/option.rs:355:21
stack backtrace:
   0:     0x560a2cfb0a0e - std::sys::unix::backtrace::tracing::imp::unwind_backtrace::hf6a90546f230a7d0
                               at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1:     0x560a2cfa19e6 - std::sys_common::backtrace::print::hb75e59ddca9a1b7a
                               at libstd/sys_common/backtrace.rs:71
                               at libstd/sys_common/backtrace.rs:59
   2:     0x560a2cf9fcbd - std::panicking::default_hook::{{closure}}::h35bf369726f7ef7f
                               at libstd/panicking.rs:211
   3:     0x560a2cf9fa30 - std::panicking::default_hook::ha71a2a7fa5235450
                               at libstd/panicking.rs:227
   4:     0x560a2cfa032c - std::panicking::rust_panic_with_hook::h7d7e0e1ff988fee8
                               at libstd/panicking.rs:477
   5:     0x560a2cf9ff29 - std::panicking::continue_panic_fmt::he8d778b183a54215
                               at libstd/panicking.rs:391
   6:     0x560a2cf9fe25 - rust_begin_unwind
                               at libstd/panicking.rs:326
   7:     0x560a2cff8f1b - core::panicking::panic_fmt::h1c54d6121d2e9db5
                               at libcore/panicking.rs:77
   8:     0x560a2cff8e4a - core::panicking::panic::he4a84d173432c46d
                               at libcore/panicking.rs:52
   9:     0x560a2cf1ac34 - openssl::ssl::connector::ctx::h3b1144d6095d7f49
  10:     0x560a2cf1ac73 - openssl::ssl::connector::SslConnectorBuilder::new::h988528bab3697168
  11:     0x560a2cf19227 - native_tls::TlsConnector::builder::h7472044297d7c860
  12:     0x560a2cec611a - reqwest::async_impl::client::ClientBuilder::new::heee6c4a5a398a3d0
  13:     0x560a2ce79732 - reqwest::client::ClientBuilder::new::h580aea3999060b52
  14:     0x560a2cdf153f - rustup_toolchain_install_master::run::ha58f29e5809cc628
  15:     0x560a2cdf5f85 - rustup_toolchain_install_master::main::h366deb6f9b21c6d1
  16:     0x560a2cde4fd2 - std::rt::lang_start::{{closure}}::h977401b7b9fc0d1a
  17:     0x560a2cf9fdc2 - std::panicking::try::do_call::h7120cc99658f0544
                               at libstd/rt.rs:59
                               at libstd/panicking.rs:310
  18:     0x560a2cfc1879 - __rust_maybe_catch_panic
                               at libpanic_unwind/lib.rs:102
  19:     0x560a2cfac645 - std::rt::lang_start_internal::he861fec101d426ef
                               at libstd/panicking.rs:289
                               at libstd/panic.rs:392
                               at libstd/rt.rs:58
  20:     0x560a2cdf5fd3 - main
  21:     0x7fd5f68e2222 - __libc_start_main
  22:     0x560a2cde202d - _start
  23:                0x0 - <unknown>

I suspect your OpenSSL isn't properly configured.
Anyway I've updated reqwest in 1.3.0, could you retry with the latest version?

My distro has 2 openssl versions coninstalled at the same time (1.1.1 and 1.0.2) which probably confused something in the code.
Anyway, I can confirm that the update fixed the build as well as the runtime panic, thanks!


Error in metric.py

I think get_ner_BIO() in metric.py is wrong.
consider the example where label_list = [I-MISC, I-MISC, O, I-PER, I-PER, O, O, O, O, O I-ORG, O] according to current function the following will happen :
Since there is no tag involving B-, whole_tag and tag_index will always be []  and hence the output of the function is [] which is wrong?

infact in the above case tag_list will have only one null string

The metric is correct. You use the wrong data format, only BIO/BMES format are supported.
You need do more homework before doubt others code.

@jiesutd Yes, thank you for pointing that out, the above example is not even correct with respect to BIO or BIOES as first I-MISC is followed by another I-MISC, I just checked and the dataset I was using had other such sentences, I corrected it to BIOES format and It seems to be giving f-score (!=-1)
However, I have no reference to check if my converted dataset is correct, do you have such reference? Does CoNLL website provide BIO and BIOES format as well? (I don't have their dataset directly as it requires some manual authentication/NDA process)
comments?

You can refer this paper https://arxiv.org/pdf/1707.06799.pdf  for the difference between BIO/BIOES/IOB.


Fix compilation error (C-style string functions)

I had to change this include in order to be able to compile the project. Please, check that it works well for you too.
The reason behind this change is that you are using C-style string functions, which are defined in cstring header.

Thank you.


ci: edit semantic release preset to conventionalcommits

To which ticket/issue is this PR linked to?
https://jira.lyft.net/browse/MGW-451
What does this PR add, change or fix?

try conventionalcommits as preset instead of angular to see if we get more details in release notes

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Code refactoring
[x] CI/CD or build process changes
[ ] Other

:tada: This PR is included in version 2.4.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Initial (type / dimension) checks for packages

In GitLab by @jdelsman on Jan 11, 2021, 15:36
As a follow-up of issues #148 and #146, add a fast initialization check to packages, in addition to the more thorough value / nodata checking that is currently implemented (and described in #74). The latter requires other packages to be present, loading of values in memory and is usually deferred to just before rendering the model.
The fast initialization check includes:

type checking: floats if floats required, ints if ints required
proper dimensions in resulting package (layer, y, x)

In GitLab by @Huite on Jul 5, 2021, 16:59
Something that came up just now, bit specific: modflow6 bottom should be a constant, or a 2D array in case of structured.
Currently 3D arrays are also accepted. Modflow6 seems to run okay -- probably skips after first layer -- but it's not well formed input.


lbl_run.ini:  Why are files for HARPS, NIRPS etc. downloaded when working with SPIRou data ?

bug or is just a key missing in lbl_run.in to select the instrument ?
2023-11-14 14:29:07.917|G|LBLMASK_FP[00001]| Downloading Mdwarf Temperature Gradient Table file
from: https://www.astro.umontreal.ca/~artigau/lbl/models/Mdwarf_temp_gradient.fits
to /data/spirou4/apero-data/offline/lbl/models/Mdwarf_temp_gradient.fits
2023-11-14 14:29:08.611|G|LBLMASK_FP[00001]| Skipped Mdwarf Temperature Gradient Table file. Missing from server.
2023-11-14 14:29:08.615|G|LBLMASK_FP[00001]| Downloading Mdwarf Mask [HARPS] file
from: https://www.astro.umontreal.ca/~artigau/lbl/models/mdwarf_harps.fits
to /data/spirou4/apero-data/offline/lbl/models/mdwarf_harps.fits
100% [..........................................................................] 1630080 /<PHONE_NUMBER>3-11-14 14:29:09.865|G|LBLMASK_FP[00001]|
Downloaded tapas file.
2023-11-14 14:29:09.866|G|LBLMASK_FP[00001]| Downloading Mdwarf Mask [NIRPS-HA] file
from: https://www.astro.umontreal.ca/~artigau/lbl/models/mdwarf_nirps_ha.fits
to /data/spirou4/apero-data/offline/lbl/models/mdwarf_nirps_ha.fits
100% [............................................................................] 921600 /<PHONE_NUMBER>-11-14 14:29:11.096|G|LBLMASK_FP[00001]|
Downloaded tapas file.
2023-11-14 14:29:11.097|G|LBLMASK_FP[00001]| Downloading Mdwarf Mask [NIRPS-HE] file
from: https://www.astro.umontreal.ca/~artigau/lbl/models/mdwarf_nirps_he.fits
to /data/spirou4/apero-data/offline/lbl/models/mdwarf_nirps_he.fits
100% [............................................................................] 921600 /<PHONE_NUMBER>-11-14 14:29:12.335|G|LBLMASK_FP[00001]|
Downloaded tapas file.
2023-11-14 14:29:12.336|G|LBLMASK_FP[00001]| Downloading Mdwarf Mask [SPIROU] file
from: https://www.astro.umontreal.ca/~artigau/lbl/models/mdwarf_spirou.fits
to /data/spirou4/apero-data/offline/lbl/models/mdwarf_spirou.fits
100% [............................................................................] 921600 /<PHONE_NUMBER>-11-14 14:29:13.569|G|LBLMASK_FP[00001]|
Downloaded tapas file.
2023-11-14 14:29:13.570|G|LBLMASK_FP[00001]| Downloading Tapas file file
from: https://www.astro.umontreal.ca/~artigau/lbl/models/tapas_lbl.fits
to /data/spirou4/apero-data/offline/lbl/models/tapas_lbl.fits
100% [......................................................................] 180535680 /<PHONE_NUMBER>023-11-14 14:29:23.443|G|LBLMASK_FP[00001]|
Downloaded tapas file.

This is just Etienne dumping files in the models directory.
Currently the model directory is not instrument dependent.
Also this should be posted on the LBL github not the apero-drs github - it is not an APERO issue.
I've copied this issue to there (https://github.com/njcuk9999/lbl/issues/48)


updated documentation for fingertips mk.2

as per this issue

I'm testing the workflow. I'll let know when ready.

seems that the gh-pages bot has succesfully rendered the documentation page.
switching to ready for review


Update zio-magic to 0.2.0

Updates io.github.kitlangton:zio-magic from 0.1.12 to 0.2.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.github.kitlangton", artifactId = "zio-magic" } ]

labels: library-update, semver-minor

Superseded by #2.


Enable correct automapping for terms with the same label (i.e. consider namespace)

Some extensions like Audubon Core have terms with the same label (coming from a different namespace). E.g. type:

Automapping for these terms uses the header as usual, but then maps to both terms. So a column with header type would be mapped to both:

I think this is normal behaviour, but a bit annoying, as it might result in incorrect mappings: both terms have different definitions and expect different values (here literal strings vs URIs).
Could it be implemented that one can provide a namespace in the header to force mapping to the correct term, e.g.:

header
maps to
behaviour

type
both dc:type and dcterms:type
current behaviour, keep

dc:type
dc:type
new behaviour

eventDate
dwc:eventDate
current behaviour, keep

dwc:eventDate
dwc:eventDate
new behaviour

Thank you @peterdesmet
That makes sense, we'll try to add this in a future release

Done. Deployed to UAT

@peterdesmet you can check it there if you want. Closing this


Use bundled nvm dir, if present

Takes advantage of https://github.com/onmodulus/docker-build-node/pull/1

LGTM


p4: init at 2017.3.1601999

Motivation for this change
The visual client p4v already has a package, this adds the command-line client.
@nioncode, @nathyong, I set you as maintainers because you already have the p4v package and this is pretty similar, I hope that’s ok.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I also updated p4v.
It seems like the packages get updated in-place without changing the url though.
So e.g. the p4 package that I originally proposed did not work anymore now.
Any idea how to solve this? should we just use an older version which does not get updated anymore?

I guess there is not really a good way to package this if they regularly change the archive behind the link.


Old images on quay.

Hey,
Despite of fixes I see that all images even with latest tag are old on quay.io. Do you guys have any procedure to update them?

Outdated because of old versions of SW included by default that are not used anyways and therefore do not matter anyways? Yes, that could be.
Otherwise most of the images should be up to date with the relevant versions released upstream (e.g., piraeus-server contains the most recent version of LINSTOR). The piraeus-init container is an exception, it is currently all work in progress.
Still, all in all we need to further automate image creation/update, that is true. It is a young project, it has rough edges here and there.

@rck hey,
So despite merged fix for ubuntu https://github.com/piraeusdatastore/piraeus/pull/10 and it's obviously not yet included in the images. So yes the issue is more about the piraeus components than linstor components.

The piraeus-init container is an exception, it is currently all work in progress.

I will push a +1 version later today

v0.2 pushed and deploy yamls updated


feat(quantic): Aria-live regions announcements for quantic components

SVCC-2310
First version of an aria-live manager to announce changes in the UI for accessibility purposes.
For this version, I added:

Announcing the no results from quantic-no-results
Announcing the query errors from quantic-query-error
Announcing when a new query is executed through quantic-summary

Each component can import AriaLiveRegion from quanticUtils and declare a new region.
And then you can use dispatchMessage to send an event to update an aria region.
The QuanticSearchInterface if the QuanticAriaLive is present in its content, will listen for these event and trigger the updated message.
The message is invisible, but can be heard with a screen reader.

I tested this on the following screen readers and it worked:

JAWS
NVDA
iOS VoiceOver
macOS VoiceOver (the search box itself is unusable though)
TalkBack

I tested this on the following screen readers and it worked:

JAWS
NVDA
iOS VoiceOver
macOS VoiceOver (the search box itself is unusable though)
TalkBack

Wow thanks! I only tested it on NVDA and Windows narrator :P

Added the tests as promised:

Very cool solution! Given this relies on bubbling events I guess its usage is not as straight forward for interfaces with sibling components that aren't necessarily children of the quantic-search-interface. Correct? Also do we plan on adding it to the QuanticInsightInterface soon? There shouldn't be anything blocking for that right?

Yea definitely nothing blocking to do that.
Do we HAVE elements that are siblings outside of the quantic-search-interface?


Search: list.focusDown and list.focusUp don't work after opening again when the fields are filled

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.76.0 (system setup)
OS Version: Windows 11

Steps to Reproduce:

workbench.action.replaceInFiles to search all files
Type in something that results in multiple results
search.action.focusSearchList to go down to the results
Move up and down and see that files open when focusing on them for about half a second
workbench.action.closeAuxiliaryBar to close the search panel
workbench.action.replaceInFiles to search all files again
The search bar is still filled
search.action.focusSearchList to go down to the results
Move up and down and see that files no longer open

https://user-images.githubusercontent.com/22121365/223552188-06a21103-8ba0-4b89-87a8-67585e56df94.mp4

Hmm, I can't seem to reproduce this. Do you have any search-related settings that are non-default?

No. I still have the problem with all extensions disabled with code --disable-extensions and no settings whatsoever (I cleared settings.json for User settings, and there were no settings for Workspace).

Here I show that I have no settings, no extensions and I can reproduce the issue.
https://user-images.githubusercontent.com/22121365/225795286-89c1533f-29a5-4f9a-a728-e2d3ef52abbc.mp4

I've also noticed a related issue with the UX with the search sidebar. The focused input is the replace field, even though I would expect it to be the search field for consistency.

Does this still happen on vscode insiders? I made a fix a few weeks ago that had to do with focusSearchList. https://github.com/microsoft/vscode/issues/172894

That fixed it. Thank you very much.


[HELP] Is there a way to get random images?

Is there a way to do something like:
http://api.jikan.moe/v3/search/anime
and it returns with a random image of a character?

Sorry, there's currently no endpoint in Jikan for something like that.
You could use https://github.com/seanbreckenridge/mal-id-cache to randomly select a character ID and send a request to
https://api.jikan.moe/v3/character/1/pictures
where 1 is the character ID

Ah, I see.


fix: Different amount in thread header vs system message

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/46725
PROPOSAL: https://github.com/Expensify/App/issues/46725#issuecomment-2265703088
Tests

Precondition:

Delayed submission is enabled in Workflows
Workspace has an approver

Go to workspace chat
Submit an expense
Click on the expense preview to go to combined report
Send a message
Click Submit button
Click on the report header >Delete expense
Delete the expense
Right click on the "submitted $0.00" system message > Reply in thread
Verify that: The amount in thread header should be the same as the amount in the system message

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

Delayed submission is enabled in Workflows
Workspace has an approver

Go to workspace chat
Submit an expense
Click on the expense preview to go to combined report
Send a message
Click Submit button
Click on the report header >Delete expense
Delete the expense
Right click on the "submitted $0.00" system message > Reply in thread
Verify that: The amount in thread header should be the same as the amount in the system message

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/00ab0ab8-da95-461d-9a57-a97762c45399

Android: mWeb Chrome

https://github.com/user-attachments/assets/9574b17a-34d2-484f-97e0-3dca45d4160c

iOS: Native

https://github.com/user-attachments/assets/af797de1-0be1-42c9-b7cd-534f57603879

iOS: mWeb Safari

https://github.com/user-attachments/assets/0e352ba4-e230-4f9e-87ee-401542d1885e

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/1f6002d8-6496-4a88-be74-80afb3038c73

MacOS: Desktop

https://github.com/user-attachments/assets/b234d314-948d-4b59-9e43-b81ff225348f

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Hey, sorry, I think we should have discussed this earlier, but I think we should go with the second part of the alternative solution so we can keep this actions translated

Or if we want this action can be translated, we should update the getFormattedAmount function to accept the reportAction param and get the amount and currency from originalMessage of this action instead of the expense report.

I will update soon.

@allroundexperts @rlinoz i updated, please check again

@allroundexperts do you mind giving just one last look since we completely changed the PR?

Im gonna go ahead and merge this one!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.24-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.24-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[doc] Add an embryonic section on stdlib coding style

Add an extremely unfinished section on the stdlib coding style, specifically on naming internal things.

Why don't we just make https://github.com/apple/swift/blob/master/docs/AccessControlInStdlib.rst a section in this document?

That document is somewhat out of date -- we can now use private/fileprivate in the stdlib.

Sure, if we don't just remove it, we should update it as well. I prefer the manual being longer and fully incorporating this knowledge, but Github's markdown doesn't scale as well towards larger documents so that's a weak opinion.

Can one of the admins verify this patch?

@swift-ci smoke test and merge


[Draft] API for Optimizer executes optimizing plan tasks

Why are the changes needed?

Close #xxx.
This is a temporary PR created to show the API change, and an issue will also be established to describe the design.
Most changes are caused by moving some classes from server to core and hive, the API changes are in this commit https://github.com/NetEase/amoro/pull/2270/commits/da257f7bbaf12ad6a6accb138a93042388b6308b
Brief change log

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add pydash and fix self.rows.pop()

Fixes for #10  and #11 (first seen in #5 ).

I would like to change the try-catch to an if-then at some point.

@Lightslayer thanks for the pull request

Please update to v0.4.1.


Kubernetes component referencing whole directory

Which area this feature is related to?
/area api
Which functionality do you think we should add?
Allo referencing the whole directory for kubernetes component.
Why is this needed? Is your feature request related to a problem?
Currently, If you need to apply multiple k8s resources, you need to define the kubernetes component for each file.
components:
- name: resource-app
  kubernetes:
    uri: kubernetes/default/app.yaml

- name: resource-pvc
  kubernetes:
    uri: kubernetes/default/pvc.yaml

- name: resource-service
  kubernetes:
    uri: kubernetes/default/service.yaml

- name: resource-route
  kubernetes:
    uri: kubernetes/local/route.yaml

Then define apply command for each kubernetes component
commands:
- apply:
    component: resource-app
  id: deploy-app

- apply:
    component: resource-pvc
  id: deploy-pvc

- apply:
    component: resource-service
  id: deploy-service

- apply:
    component: resource-route
  id: deploy-route

And only then you can define a composite that will apply all those resources:
commands:
- composite:
    commands:
      - deploy-pvc
      - deploy-service
      - deploy-route
      - deploy-app
  id: deploy-k8s

This is quite a lot for simply wanting to apply yaml files i a directory.
Detailed description:
Describe the solution you'd like
Something like directory field for kubernetes component would be handy.
components:
- name: k8s-resources
  kubernetes:
    directory: kubernetes/default

closing as rotten


Rename all instances of 'telephone' with 'phone'

What
Does 3 things:

What the title says
Renames the Telephone numbers pattern page to Phone numbers
Sets up a netlify redirect

Why
This is a reimplimentation of @terrysimpson99's PR https://github.com/alphagov/govuk-design-system/pull/1793, updated to account for the netlify redirect and subtle but tricky changes to our filesystem. All credit to Terry for prompting this.

Oof, already spotted I missed some things:

The redirect is incorrect 🙈
We should add a 'telephone' alias to the phone numbers pattern

Actioning now


[Bug] No connection to the Internet

Current Behavior
No connection to the internet.
"JDownloader cannot connect to update.jdownloader.org! Please check the connection settings."
Expected Behavior
Connection to the internet after installation.
Steps To Reproduce
Run after installation
Environment

OS: DMS
OS version: 7.2.1 -69057 Update 5
CPU: Intel Celeron J4025
Docker version: 20.10.23-1437
Device model: DS220+
Browser/OS: Chrome

Container creation
docker run -d --name=jdownloader2
-p 3129:3129
-p 5800:5800
-p 5900:5900
-e USER_ID=1029
-e GROUP_ID=100
-e TZ=Europe/Bucharest
-e DARK_MODE=1
-v /volume1/docker/jdownloader2/config:/config
-v /volume1/docker/jdownloader2/output:/output
--restart always
jlesage/jdownloader-2
Container log
jdownloader2
date,stream,content
2024/08/16 10:17:49,stdout,[xvnc        ]  VNCSConnST:  Client pixel format depth 24 (32bpp) little-endian bgr888

2024/08/16 10:17:49,stdout,[xvnc        ]  VNCSConnST:  Server default pixel format depth 24 (32bpp) little-endian rgb888

2024/08/16 10:17:49,stdout,[xvnc        ]  SConnection: Client requests security type None(1)

2024/08/16 10:17:49,stdout,[xvnc        ]  SConnection: Client needs protocol version 3.8

2024/08/16 10:17:49,stdout,[xvnc        ]  Connections: accepted: /tmp/vnc.sock

2024/08/16 10:17:49,stdout,[xvnc        ] Fri Aug 16 11:17:49 2024

2024/08/16 00:32:07,stdout,[xvnc        ]  ComparingUpdateTracker: (1:13774.5 ratio)

2024/08/16 00:32:07,stdout,[xvnc        ]  ComparingUpdateTracker: 62.6837 Gpixels in / 4.55072 Mpixels out

2024/08/16 00:32:07,stdout,[xvnc        ]  Connections: closed: /tmp/vnc.sock

2024/08/16 00:32:07,stdout,[xvnc        ]  EncodeManager:          1.78718 MiB (1:24.1568 ratio)

2024/08/16 00:32:07,stdout,"[xvnc        ]  EncodeManager:   Total: 1.345 krects, 11.3134 Mpixels

Container inspect
No response
Anything else?
No response

Are you sure the container has access to the internet ? Do you have the firewall enabled on your Synology ?

I am so embarrassed. How could I missed it. Thank you. The ticket can be closed.

I have the same problem. Did you find a solution?

Did you confirm that deactivating the firewall fixes the problem ?

I don't know... but we must first understand where the problem is coming from. It's not clear to me if the container can access the internet at all or if it's a specific resource that has a problem.