How are the ne_XXXm datasets created?

I'm in the process of building my own tile service & am trying to get a better picture of the underlying data. So yea, how are these datasets created & then updated? Thank you!

I think I may have answered my own question as to their origins. Is this correct: http://www.naturalearthdata.com/downloads/10m-cultural-vectors/roads/ ?

Yes, exactly right. Those all come from the natural earth datasets.
We do some light processing on them first though. The shape files from natural earth are in the latlong projection (epsg:4326) and we reproject it into web mercator (epsg:3857). These are what get checked into the repo. We use ogr to do it:
ogr2ogr -f "ESRI Shapefile" -s_srs EPSG:4326 -t_srs EPSG:3857 <destination.shp> <source.shp>

And if there are encoding issues:
ogr2ogr -f "ESRI Shapefile" -s_srs EPSG:4326 -t_srs EPSG:3857 -lco ENCODING=UTF-8 <destination.shp> <source.shp>

Additionally, if the dataset that we include has very few features in them, we tile them up first, and then use that. This is to improve query performance. The script that we use for that can be found here.

Awesome, thank you!


Dependency updates for Prometheus Federator, helm project operator and helm locker

We want to work towards a versioning scheme of dependencies in :

https://github.com/rancher/helm-locker
https://github.com/rancher/helm-project-operator
https://github.com/rancher/prometheus-federator

That will be guaranteed to be compatible with specific versions of k8s / rancher and be maintainable through several releases,  as well as having e2e tests to verify behaviour of these controllers.

My initial proposal is to consolidate all these controller implementations into a single repository, likely https://github.com/rancher/prometheus-federator, so that there is a single point to manage dependencies in a consistent way across the controller implementations. This way we can have one repository with specific release branches, following the semcov of something like BRO,  with release/v5.0 branch and images 0.5.X being compatible with the k8s versions in rancher 2.9
To achieve that, I propose to :

Write some comprehensive integration/e2e tests for these controllers behaviour, like in https://github.com/rancher/helm-locker/pull/21
Once that is done, aggressively bump dependencies in each of these repos to ones compatible with rancher 2.9
Cut an rc for prometheus federator with the dependency bumps and pass that through QA
Combine the controller implementations into prometheus-federator

I have created a new PR that merges the helm-locker repo with the helm-project-operator repo. This was done in a manner that preserves ability to build and test helm-locker alone. However will reduce our current workflow burden for updating things in an effective manner.
Needs review by @joshmeranda when he is back, and then some follow up CI work based on his input. After merging that PR we can then "port" (lack of better term) the version bumps and improvements (that apply) from this PR alex had started into this repo.
We will also need to implement the proper branching policy per the ADR - we should decide if that should be done before or after porting PR 24 alex started over to this repo. As if those changes may affected older branches we need to create, we should create those first to preserve compatibility.

I have created a set of PRs, images and chart changes to allow for QA to test before merge. An issue to track that specific process is here: https://github.com/rancher/prometheus-federator/issues/94
I figured it makes sense for QA to use that issue instead of this one - since this one is really kind of an "Epic". And we're breaking it into multiple phases to make the huge effort more digestable.

I've completed a knowledge transfer on this effort to @jbiers - so she has some foundational understanding and can potentially work with Josh on this a bit when he's back (time permitting). The changes in my PRs will need to be merged first, but after that I also have a branch prepared to address https://github.com/rancher/rancher/issues/46764

Hit another milestone today - we merged the PR which combines both HPO+HL into PromFed. Working towards tagging a new PromFed RC version and updating charts.

Since we've completed merging code-bases of the projects and it's been QA'd once. I've created the PR for charts updates here: https://github.com/rancher/charts/pull/4588

Added @alexandreLamarre as an Assignee as he'll be working on the PRs to update dependencies of PromFed so he'll be closing out the final phase of the project which should solve this issue.


[RFC]: Macro for defining file system API with default function assigned

The PR is proposal of DEFINE_FILE_SYSTEM macro that could be used to define file system driver interface
and assign default function, returning -ENOTSUP, for all functions that the drivers fails to implement/provide.
TODO:

[ ] Tests
[ ] Update to documentation

What's the value of doing providing this?  We only have two in-tree file systems, and I don't imagine there'll be dozens of external ones.  Is the code and time required to check for an implemented function on each FS operation worth this?

What's the value of doing providing this? We only have two in-tree file systems, and I don't imagine there'll be dozens of external ones. Is the code and time required to check for an implemented function on each FS operation worth this?

I do not really follow you here. I am trying to drop the code that checks if function is implemented by just providing default one that returns -ENOTSUP instead. I am trying to shorten the fs_*.
In the commit for Kconfig I even say that if you trust the implementation you may set the option to N and no checks will be done.

OK, the goal is reduced code by sharing the not-supported functions.  I guess that's ok; personally I find macro magic like this to obscure what's going on.  I had to go to the C18 spec to confirm that it's actually legal to provide the same field initializer multiple times.  (FILE_SYSTEM_DEFINE is not acceptable in C++.)
Also the solution to provide a generic "return -ENOTSUP" function creates undefined behavior; see
iso-iec-9899-2018-draft-n2176 section <IP_ADDRESS>¶8:

A pointer to a function of one type may be converted to a pointer to a function of another type and back again; the result shall compare equal to the original pointer. If a converted pointer is used to call a function whose type is not compatible with the referenced type, the behavior is undefined.

I.e. because the generic function is specified as taking no arguments type retns (void) invoking it with arguments is undefined behavior.  If defined without a full prototype type ret ns() it avoids the compatible violation but stackoverflow suggests it's still undefined behavior to actually invoke the function.
So this just makes me a little uncomfortable.

I find macro magic like this to obscure what's going on. I had to go to the C18 spec to confirm that it's actually legal to provide the same field initializer multiple times. (FILE_SYSTEM_DEFINE is not acceptable in C++.)

OK. I got it covered by other macro, unfortunately requiring a little bit more typing.

Also the solution to provide a generic "return -ENOTSUP" function creates undefined behavior; see
iso-iec-9899-2018-draft-n2176 section <IP_ADDRESS>¶8:

A pointer to a function of one type may be converted to a pointer to a function of another type and back again; the result shall compare equal to the original pointer. If a converted pointer is used to call a function whose type is not compatible with the referenced type, the behavior is undefined.

I.e. because the generic function is specified as taking no arguments type retns (void) invoking it with arguments is undefined behavior. If defined without a full prototype type retns() it avoids the compatible violation but stackoverflow suggests it's still undefined behavior to actually invoke the function.
So this just makes me a little uncomfortable.
I can do default function for reach one, I just need to figure out some things.

I do not want to bend the standard. The ABI makes it work actually as long as the call type is the same as defined for function (cdecl here). The return type needs to match otherwise the volatile registers (and or stack) which are used for returning the value would not be written by the called as the caller would expect: eg, returning int where long is expected (if long requires two registers) would cause one register to be left in undefined state.
But anyway, I will generate all required function instead of being lazy.

OK, the goal is reduced code by sharing the not-supported functions. I guess that's ok;

Yes. This is RFC because I wanted to know whether the idea could fly. I will find out, whether there are gcc attributes that further reduce function by stripping it off preamble and cleanup code, specially for functions that are expected to only return value. I am used to do these things in assembly.

Below citation comes from https://github.com/zephyrproject-rtos/zephyr/pull/27910#discussion_r509592938

You may not agree with me but I think the NULL checks are not needed there as I believe that developers exactly know which functions are offered by the system driver or at least will gain the knowledge quickly.
Basically: when writing embedded software you get -ENOTSUP, specifically in the meaning "not implemented". once then you have to reorganize to solve the problem and you newer see it again.

It is controversial view and requires input from other project contributors.

See also https://github.com/zephyrproject-rtos/zephyr/issues/23727#issuecomment-714494782 which is a response to an out-of-band discussion that proposed that functions with this "blow up if things go wrong" behavior could use a distinct error result so the developer would be aware of the possibility.  Which, even though I floated it, isn't something I'd likely support: I'd rather see all code check all results for errors and respond appropriately.  (CWE-252 which I would swear was a MISRA requirement too, though I can't find it now.)


Bootstrap inputs with autofocus act strangely in Mobile Safari

This one has had me puzzled for a while and I've been trying to find a more specific cause, but I haven't managed to narrow it down further than Bootstrap.
The fiddle here is set up as follows:

https://maxcdn.bootstrapcdn.com/bootstrap/3.3.2/css/bootstrap.min.css
https://maxcdn.bootstrapcdn.com/bootstrap/3.3.2/js/bootstrap.min.js
Mobile Safari on the iOS simulator (iPhone 6 - iOS 8.1, although I have confirmed this to also be the case on a physical iPhone)

When clicking in the area marked in red:

The input is focused:

The issue here is two-fold:

Touching anywhere on the screen trigger the input to focus - this even occurs on a scroll event
The keyboard does not pop-up. Even if a user wanted to enter text into the input, they need to click it again to trigger the keyboard.

I have been able to confirm the following:

Removing EITHER bootstrap.min.css or bootstrap.min.js fixes the issue.
Removing class: form-control from the input style fixes the issue.
Mobile Safari does not attempt to autofocus form elements on its own.

Greatly appreciate your help in tracking down this issue. I'm not sure if it's a browser bug (caused by adding :focus styles to an element with the autofocus attribute set), or a javascript event.

Hi @asafbrukarz!
You appear to have posted a live example (http://fiddle.jshell.net/9ryem7u4/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 39, column 5: E003: Found one or more .rows that were not children of a grid column or descendants of a .container or .container-fluid

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Update the fiddle to remove superfluous rows and grids.

Possible duplicate of #14532.

None of our JS should be getting activated in this case, so the bug is very unlikely to be JS-related.

@cvrebert I wouldn't have thought that it was JS related either, but removing the JS file certainly makes a difference.

Right, but none of our JavaScript acts unbidden on forms or plain text form-controls... Maybe the mere act of adding a document event listener has some weird side-effect on Safari? IDK, just spitballing here.

Um, according to http://caniuse.com/#feat=autofocus autofocus isn't even implemented in iOS Safari.

Fork without the autofocus attribute: http://jsfiddle.net/gzxtb86c/

Yup, still happens without autofocus.

Also, I can't repro the "keyboard doesn't pop up" part with either fiddle. Using iOS 8.1 on an actual iPhone 5S.

You're correct. It's only on the simulator that the keyboard doesn't pop up.
Also, a touch start event will trigger this behaviour, so it's not limited to tapping.

Sorry, I accidentally closed this issue.
The other point to note is that in your fork the focus style is not applied to the input, where in the original, the blue outline has been applied - even though Mobile Safari should not support autofocus at all.

Just confirming that this is still an issue in 3.3.4

Is this a browser bug then that needs reporting?

I believe so, but don't have the means to test it.
On Saturday, 25 Apr 2015 at 6:06 pm, Mark Otto<EMAIL_ADDRESS>wrote:
Is this a browser bug then that needs reporting?
—
Reply to this email directly or view it on GitHub.

Anyone willing to test this out? If not, I'm probably going to punt on it until after v4.

@mdo Already confirmed it earlier.
Filed WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=146244

Filed Safari bug: http://openradar.appspot.com/21509310

Fixed in WebKit: http://trac.webkit.org/changeset/191954


feat: add support for strictPropertyInitialization

Enables strictPropertyInitialization and fixes all of the resulting compilation errors.
Fixes #13329.

@jelbourn this one' finally ready to go. It ended up introducing more than 800 compilation errors.

Ack on the ones you replied on

@jelbourn I've rebased it, fixed some more issues from master and addressed the feedback.

Switching this to a patch, but we should evaluate based on the presubmit.

Is this still something you want to try to get in?

I don't think getting this massive PR in one go is practical anymore. I left here mostly as a reminder that we need to do this eventually.

Is there a JIRA item associated with it? I suggest we close this but link to it from that item

You can close and make sure it's in jira

Closing since this is way out of date.


RFC: Use graphql-scalars

As suggested in #2088, RFC for graphql-scalars.
TLDR: More explicit GraphQL schema.

Useful scalars for us:

Date
EmailAddress
Latitude
Longitude
Precise Numbers: (Positive) Float/Int
URL
UUID
Hex Color Code

Pro:

It is easy to use
Makes the schema more explicit and better usable
Makes it easier to add "basic validation"

Con:

Validation is split between class-validator and GraphQL schema (we have this situation already, but this would amplify it)

Proposed Migration-Path:

Use JSONObject from "graphql-scalars" (which is based on "graphql-type-json", what we already use)
Rename our DateFilter to DateTimeFilter (as this is what it really is)
Leave it to the application, if they want to use it
Recreate #2088 by adding a DateFilter based on https://the-guild.dev/graphql/scalars/docs/scalars/date or allow the application to extend the filters

lgtm, i would say we should do that.
I'm not sure about changing ID though...
and another Con: You need to add it's type to codegen, this might be an argument against using PositiveInt


Certificate verify failed when running unit tests on macbook for nltk data download

Issue
When trying to run the unit tests for testing my development branches, I am unable to download the datasets. This blocks me from performing the tests.
Quick-fix
It seems like I can manually download these myself, using a custom fix. Instead of doing:
import ntlk

ntlk.download("stopwords")

I can do:
import nltk
import ssl

try:
    _create_unverified_https_context = ssl._create_unverified_context
except AttributeError:
    pass
else:
    ssl._create_default_https_context = _create_unverified_https_context

nltk.download("stopwords")

Solution
So having this fix seems relevant for this project. Could be that the issue is from some other library, but for now, it seems to be related to when initializing the BM25Encoder model. I would think other models which use datasets from nltk also could have issues.
I can draft a PR, if it is relevant to this project. If not, I can make a PR to whichever repo this issue originates from.
PyTest logs
___________________________________________________________________________________ ERROR collecting tests/unit/test_hybrid_layer.py ___________________________________________________________________________________
venv_test/lib/python3.10/site-packages/nltk/corpus/util.py:84: in __load
    root = nltk.data.find(f"{self.subdir}/{zip_name}")
venv_test/lib/python3.10/site-packages/nltk/data.py:583: in find
    raise LookupError(resource_not_found)
E   LookupError:
E   **********************************************************************
E     Resource stopwords not found.
E     Please use the NLTK Downloader to obtain the resource:
E
E     >>> import nltk
E     >>> nltk.download('stopwords')
E
E     For more information see: https://www.nltk.org/data.html
E
E     Attempted to load corpora/stopwords.zip/stopwords/
E
E     Searched in:
E       - '/Users/andreped/nltk_data'
E       - '/Users/andreped/workspace/semantic-router/venv_test/nltk_data'
E       - '/Users/andreped/workspace/semantic-router/venv_test/share/nltk_data'
E       - '/Users/andreped/workspace/semantic-router/venv_test/lib/nltk_data'
E       - '/usr/share/nltk_data'
E       - '/usr/local/share/nltk_data'
E       - '/usr/lib/nltk_data'
E       - '/usr/local/lib/nltk_data'
E   **********************************************************************

During handling of the above exception, another exception occurred:
tests/unit/test_hybrid_layer.py:77: in <module>
    sparse_encoder = BM25Encoder(use_default_params=False)
semantic_router/encoders/bm25.py:27: in __init__
    self.model = encoder()
venv_test/lib/python3.10/site-packages/pinecone_text/sparse/bm25_encoder.py:59: in __init__
    self._tokenizer = BM25Tokenizer(
venv_test/lib/python3.10/site-packages/pinecone_text/sparse/bm25_tokenizer.py:26: in __init__
    self._stop_words = set(stopwords.words(language))
venv_test/lib/python3.10/site-packages/nltk/corpus/util.py:121: in __getattr__
    self.__load()
venv_test/lib/python3.10/site-packages/nltk/corpus/util.py:86: in __load
    raise e
venv_test/lib/python3.10/site-packages/nltk/corpus/util.py:81: in __load
    root = nltk.data.find(f"{self.subdir}/{self.__name}")
venv_test/lib/python3.10/site-packages/nltk/data.py:583: in find
    raise LookupError(resource_not_found)
E   LookupError:
E   **********************************************************************
E     Resource stopwords not found.
E     Please use the NLTK Downloader to obtain the resource:
E
E     >>> import nltk
E     >>> nltk.download('stopwords')
E
E     For more information see: https://www.nltk.org/data.html
E
E     Attempted to load corpora/stopwords
E
E     Searched in:
E       - '/Users/andreped/nltk_data'
E       - '/Users/andreped/workspace/semantic-router/venv_test/nltk_data'
E       - '/Users/andreped/workspace/semantic-router/venv_test/share/nltk_data'
E       - '/Users/andreped/workspace/semantic-router/venv_test/lib/nltk_data'
E       - '/usr/share/nltk_data'
E       - '/usr/local/share/nltk_data'
E       - '/usr/lib/nltk_data'
E       - '/usr/local/lib/nltk_data'
E   **********************************************************************
--------------------------------------------------------------------------------------------------- Captured stderr ----------------------------------------------------------------------------------------------------
[nltk_data] Error loading punkt: <urlopen error [SSL:
[nltk_data]     CERTIFICATE_VERIFY_FAILED] certificate verify failed:
[nltk_data]     unable to get local issuer certificate (_ssl.c:1007)>
[nltk_data] Error loading stopwords: <urlopen error [SSL:
[nltk_data]     CERTIFICATE_VERIFY_FAILED] certificate verify failed:
[nltk_data]     unable to get local issuer certificate (_ssl.c:1007)>

Hi, I cannot replicate this, are you sure that the network you're running this from doesn't intercept your traffic? You shouldn't need to run without SSL verification.
In [5]: nltk.download("stopwords")
[nltk_data] Downloading package stopwords to
[nltk_data]     /Users/bogdanbuduroiu/nltk_data...
Out[5]: True

It could be that the network does, but this I cannot control. I have had similar SSL issues when installing some python packages in the past. Especially on VPN. This time I used the hotspot shared with my phone, as I was in transit.

As we're downloading a public dataset from a third party, we want to keep a strict SSL requirement to prevent against cybersec vulnerabilities (man-in-the-middle comes to mind first). Closing for now

we want to keep a strict SSL requirement to prevent against cybersec vulnerabilities

OK, thats understandable. Thanks for the clarification, @bruvduroiu! :]


AVRO-3347 Update addNamespace to AddNamespace

Jira

[ ] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"

https://issues.apache.org/jira/browse/AVRO-3347

Tests

[ ] My PR  does not need testing for this extremely good reason: non functional changes

Commits

[ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does

Thank you, @KyleSchoonover !


D230 privacy mode (switch.doorbell_privacy) missing in HA (available in Tapo app)

Description
I had power outage resulting in most of my doorbell entities being permanently unavailabel - I was unable to remove the device so pulled the plug on the hub, restarted HA and re-added the hub - all good.
However, the doorbell camera privacy mode no longer exists in HA (and the doorbell night vision is unable to be set to auto but this ticket is about the privacy mode).
Reproduction Steps

goto TP-link and add hub
Hub  is added and doorbell becomes available
doorbell privacy mode is missing as an entity.

Expected behavior
I expect doorbell privacy mode switch to exist (it exists in mu phone's Tapo app).
The privacy mode switch was available in HA prior to my outage.
If applicable, add error logs.
Not sure is this log entry is relevant:
This error originated from a custom integration.

Logger: custom_components.tapo_control
Source: helpers/update_coordinator.py:312
integration: Tapo: Cameras Control (documentation, issues)
First occurred: 10:55:43 (1 occurrences)
Last logged: 10:55:43

Unexpected error fetching Tapo resource status data
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 312, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 268, in _async_update_data
    return await self.update_method()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/tapo_control/__init__.py", line 463, in async_update_data
    raise e
  File "/config/custom_components/tapo_control/__init__.py", line 454, in async_update_data
    updateDataForAllControllers[controller] = await getCamData(
                                              ^^^^^^^^^^^^^^^^^
  File "/config/custom_components/tapo_control/utils.py", line 639, in getCamData
    data = await hass.async_add_executor_job(controller.getMost)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/pytapo/__init__.py", line 1871, in getMost
    results = self.performRequest(requestData)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/pytapo/__init__.py", line 618, in performRequest
    self.refreshStok()
  File "/usr/local/lib/python3.12/site-packages/pytapo/__init__.py", line 423, in refreshStok
    raise Exception("Invalid authentication data")
Exception: Invalid authentication data

Device Firmware
1.1.16 build 20240617 rel. 65780
Integration Version
5.4.26
Using stream component
No
Does camera work via official integrations?
Yes
Camera has all attributes filled out in developer tools
Yes
HASS Environment
Docker on RPi-4
Search for similar issues
Yes
Additional information
I wasn't sure if https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/issues/540 is related or not.  It has an invalid label.
I also mentioned my issue with being unable to select auto for night vision as not sure if it is relevant or not.  Selecting on or off works.  This ticket is not about that though (keeping it to one topic). However, for info, When I select 'auto' or off in the UI, I get the following error:

Hello try to remove the camera and add it back again

thanks for such a fast reply!
Doing it now.  The already better news is that I was able to remove it this time (without switching the hub off).  Will update in a few...

Hi - still missing

Are there any errors in the log?
Did you change anything else? Update integration or anything?

I did update HA from 2024.7.2 to 2024.7.3 - I can downgrade if you';d like me to try that?
I restarted after removing the hub/doorbell, so here are the logs since then...
2024-07-20 11:22:50.773 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration tapo_control which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-07-20 11:22:50.775 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration dyson_local which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-07-20 11:22:50.777 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration sun2 which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-07-20 11:22:50.778 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration hypervolt_charger which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-07-20 11:22:50.780 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration feedparser which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-07-20 11:22:50.782 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration hacs which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-07-20 11:23:05.103 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'hacs' calls hass.http.register_static_path which is deprecated because it does blocking I/O in the event loop, instead call `await hass.http.async_register_static_paths([StaticPathConfig("/hacsfiles/frontend", "/config/custom_components/hacs/hacs_frontend", False)])`; This function will be removed in 2025.7 at custom_components/hacs/frontend.py, line 54: hass.http.register_static_path(f"{URL_BASE}/frontend", locate_dir(), cache_headers=False), please create a bug report at https://github.com/hacs/integration/issues
2024-07-20 11:23:05.126 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'hacs' calls hass.http.register_static_path which is deprecated because it does blocking I/O in the event loop, instead call `await hass.http.async_register_static_paths([StaticPathConfig("/hacsfiles/iconset.js", "/config/custom_components/hacs/iconset.js", True)])`; This function will be removed in 2025.7 at custom_components/hacs/frontend.py, line 57: hass.http.register_static_path(, please create a bug report at https://github.com/hacs/integration/issues
2024-07-20 11:23:05.135 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'hacs' accesses hass.components.frontend. This is deprecated and will stop working in Home Assistant 2024.9, it should be updated to import functions used from frontend directly at custom_components/hacs/frontend.py, line 68: hass.components.frontend.async_register_built_in_panel(, please create a bug report at https://github.com/hacs/integration/issues
2024-07-20 11:23:05.151 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'hacs' calls hass.http.register_static_path which is deprecated because it does blocking I/O in the event loop, instead call `await hass.http.async_register_static_paths([StaticPathConfig("/hacsfiles", "/config/www/community", False)])`; This function will be removed in 2025.7 at custom_components/hacs/base.py, line 1162: self.hass.http.register_static_path(, please create a bug report at https://github.com/hacs/integration/issues
2024-07-20 11:23:08.494 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'dyson_local' calls async_forward_entry_setup for integration, dyson_local with title: Pure Cool and entry_id: 1c3f95d046f740418d0b03b4d2504fdc, which is deprecated and will stop working in Home Assistant 2025.6, await async_forward_entry_setups instead at custom_components/dyson_local/__init__.py, line 137: hass.async_create_task(, please create a bug report at https://github.com/libdyson-wg/ha-dyson/issues
2024-07-20 11:23:08.772 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration dyson_local with title: Pure Cool and entry_id: 1c3f95d046f740418d0b03b4d2504fdc, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
Stack (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
sys.exit(main())
File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
exit_code = runner.run(runtime_conf)
File "/usr/src/homeassistant/homeassistant/runner.py", line 190, in run
return loop.run_until_complete(setup_and_run_hass(runtime_config))
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
self.run_forever()
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
self._run_once()
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
handle._run()
File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
self._context.run(self._callback, *self._args)
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 2122, in async_forward_entry_setup
_report_non_awaited_platform_forwards(entry, "async_forward_entry_setup")
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1175, in _report_non_awaited_platform_forwards
report(
File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 151, in report
_LOGGER.warning(msg, stack_info=True)
2024-07-20 11:23:08.888 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration dyson_local with title: Pure Cool and entry_id: 1c3f95d046f740418d0b03b4d2504fdc, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
Stack (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
sys.exit(main())
File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
exit_code = runner.run(runtime_conf)
File "/usr/src/homeassistant/homeassistant/runner.py", line 190, in run
return loop.run_until_complete(setup_and_run_hass(runtime_config))
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
self.run_forever()
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
self._run_once()
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
handle._run()
File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
self._context.run(self._callback, *self._args)
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 2122, in async_forward_entry_setup
_report_non_awaited_platform_forwards(entry, "async_forward_entry_setup")
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1175, in _report_non_awaited_platform_forwards
report(
File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 151, in report
_LOGGER.warning(msg, stack_info=True)
2024-07-20 11:23:08.906 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration dyson_local with title: Pure Cool and entry_id: 1c3f95d046f740418d0b03b4d2504fdc, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
Stack (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
sys.exit(main())
File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
exit_code = runner.run(runtime_conf)
File "/usr/src/homeassistant/homeassistant/runner.py", line 190, in run
return loop.run_until_complete(setup_and_run_hass(runtime_config))
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
self.run_forever()
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
self._run_once()
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
handle._run()
File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
self._context.run(self._callback, *self._args)
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 2122, in async_forward_entry_setup
_report_non_awaited_platform_forwards(entry, "async_forward_entry_setup")
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1175, in _report_non_awaited_platform_forwards
report(
File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 151, in report
_LOGGER.warning(msg, stack_info=True)
2024-07-20 11:23:08.920 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration dyson_local with title: Pure Cool and entry_id: 1c3f95d046f740418d0b03b4d2504fdc, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
Stack (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
sys.exit(main())
File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
exit_code = runner.run(runtime_conf)
File "/usr/src/homeassistant/homeassistant/runner.py", line 190, in run
return loop.run_until_complete(setup_and_run_hass(runtime_config))
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
self.run_forever()
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
self._run_once()
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
handle._run()
File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
self._context.run(self._callback, *self._args)
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 2122, in async_forward_entry_setup
_report_non_awaited_platform_forwards(entry, "async_forward_entry_setup")
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1175, in _report_non_awaited_platform_forwards
report(
File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 151, in report
_LOGGER.warning(msg, stack_info=True)
2024-07-20 11:23:09.998 ERROR (MainThread) [homeassistant.helpers.event] Error while processing template: Template<template=({% from 'met_office_codes.jinja' import code2ha %} {% set dh = state_attr('sensor.local_datahub_3_hourly','timeSeries') %} {% set ns = namespace(forecast=[]) %} {% for ts in dh -%}
{% if 'T00' in ts['time'] or 'T12' in ts['time'] and ts['time']|as_datetime > now() -%}
{% set index = (dh|map(attribute='time')|list).index(ts['time']) -%}
{% set dhr = dh[((0,index-1,dh|count)|sort)[1]:((0,index+2,dh|count)|sort)[1]] %}
{% set tsd = { 'datetime': (ts['time']|as_datetime).isoformat(),
'is_daytime': 'T12' in ts['time'],
'condition': code2ha(ts['significantWeatherCode']),
'humidity': dhr|map(attribute='screenRelativeHumidity')|average|round(0),
'pressure': dhr|map(attribute='mslp')|average|round(0),
'temperature': dhr|map(attribute='maxScreenAirTemp')|max|round(0),
'templow': dhr|map(attribute='minScreenAirTemp')|min|round(0),
'precipitation_probability': dhr|map(attribute='probOfPrecipitation')|average|round(0),
'wind_speed': dhr|map(attribute='windSpeed10m')|average|round(0) } -%}
{% set ns.forecast = ns.forecast + [tsd] -%}
{% endif -%}
{% endfor %} {{ ns.forecast }}) renders=2>
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 604, in async_render
render_result = _render_with_context(self.template, compiled, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 2639, in _render_with_context
return template.render(**kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/jinja2/environment.py", line 1304, in render
self.environment.handle_exception()
File "/usr/local/lib/python3.12/site-packages/jinja2/environment.py", line 939, in handle_exception
raise rewrite_traceback_stack(source=source)
File "<template>", line 1, in top-level template code
TypeError: 'NoneType' object is not iterable
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 716, in async_render_to_info
render_info._result = self.async_render( # noqa: SLF001
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 606, in async_render
raise TemplateError(err) from err
homeassistant.exceptions.TemplateError: TypeError: 'NoneType' object is not iterable
2024-07-20 11:23:10.037 ERROR (MainThread) [homeassistant.components.template.template_entity] TemplateError('TypeError: 'NoneType' object is not iterable') while processing template 'Template<template=({% from 'met_office_codes.jinja' import code2ha %} {% set dh = state_attr('sensor.local_datahub_3_hourly','timeSeries') %} {% set ns = namespace(forecast=[]) %} {% for ts in dh -%}
{% if 'T00' in ts['time'] or 'T12' in ts['time'] and ts['time']|as_datetime > now() -%}
{% set index = (dh|map(attribute='time')|list).index(ts['time']) -%}
{% set dhr = dh[((0,index-1,dh|count)|sort)[1]:((0,index+2,dh|count)|sort)[1]] %}
{% set tsd = { 'datetime': (ts['time']|as_datetime).isoformat(),
'is_daytime': 'T12' in ts['time'],
'condition': code2ha(ts['significantWeatherCode']),
'humidity': dhr|map(attribute='screenRelativeHumidity')|average|round(0),
'pressure': dhr|map(attribute='mslp')|average|round(0),
'temperature': dhr|map(attribute='maxScreenAirTemp')|max|round(0),
'templow': dhr|map(attribute='minScreenAirTemp')|min|round(0),
'precipitation_probability': dhr|map(attribute='probOfPrecipitation')|average|round(0),
'wind_speed': dhr|map(attribute='windSpeed10m')|average|round(0) } -%}
{% set ns.forecast = ns.forecast + [tsd] -%}
{% endif -%}
{% endfor %} {{ ns.forecast }}) renders=4>' for attribute '_forecast_twice_daily' in entity 'weather.met_office_datahub'
2024-07-20 11:23:10.359 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'hacs' accesses hass.helpers.event. This is deprecated and will stop working in Home Assistant 2024.11, it should be updated to import functions used from event directly at custom_components/hacs/base.py, line 630: self.hass.helpers.event.async_track_time_interval(, please create a bug report at https://github.com/hacs/integration/issues
2024-07-20 11:24:30.668 ERROR (MainThread) [homeassistant.components.switch] Error while setting up tapo_control platform for switch
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 364, in _async_setup_platform
await asyncio.shield(awaitable)
File "/config/custom_components/tapo_control/switch.py", line 166, in async_setup_entry
switches = await setupEntities(entry)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/tapo_control/switch.py", line 144, in setupEntities
and "video_capability" in entry["camData"]["videoCapability"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'bool' is not iterable
2024-07-20 11:24:31.555 WARNING (MainThread) [homeassistant.components.select] Setup of select platform tapo_control is taking over 10 seconds.
2024-07-20 11:25:20.635 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [548047419664] Unexpected exception
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 241, in handle_call_service
response = await hass.services.async_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2731, in async_call
response_data = await coro
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2774, in _execute_service
return await target(service_call)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 999, in entity_service_call
single_response = await _handle_entity_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1071, in _handle_entity_call
result = await task
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/select/__init__.py", line 188, in async_handle_select_option
await self.async_select_option(option)
File "/config/custom_components/tapo_control/select.py", line 315, in async_select_option
result = await self._hass.async_add_executor_job(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/pytapo/__init__.py", line 1576, in setDayNightMode
return self.setNightVisionModeConfig("md_night_vision")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/pytapo/__init__.py", line 1586, in setNightVisionModeConfig
return self.executeFunction(
^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/pytapo/__init__.py", line 510, in executeFunction
raise Exception(
Exception: Error: 60305, Response: {"method": "setNightVisionModeConfig", "result": {}, "error_code": 60305}
2024-07-20 11:25:23.572 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [548047419664] Unexpected exception
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 241, in handle_call_service
response = await hass.services.async_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2731, in async_call
response_data = await coro
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2774, in _execute_service
return await target(service_call)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 999, in entity_service_call
single_response = await _handle_entity_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1071, in _handle_entity_call
result = await task
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/select/__init__.py", line 188, in async_handle_select_option
await self.async_select_option(option)
File "/config/custom_components/tapo_control/select.py", line 315, in async_select_option
result = await self._hass.async_add_executor_job(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/pytapo/__init__.py", line 1572, in setDayNightMode
return self.setNightVisionModeConfig("inf_night_vision")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/pytapo/__init__.py", line 1586, in setNightVisionModeConfig
return self.executeFunction(
^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/pytapo/__init__.py", line 491, in executeFunction
data = self.performRequest(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/pytapo/__init__.py", line 618, in performRequest
self.refreshStok()
File "/usr/local/lib/python3.12/site-packages/pytapo/__init__.py", line 423, in refreshStok
raise Exception("Invalid authentication data")
Exception: Invalid authentication data
2024-07-20 11:25:26.694 ERROR (MainThread) [custom_components.tapo_control] [initOnvifEvents] Initiating onvif connection failed.
2024-07-20 11:25:26.694 ERROR (MainThread) [custom_components.tapo_control]
2024-07-20 11:25:34.588 ERROR (SyncWorker_1) [homeassistant] Error doing job: Task exception was never retrieved (None)
Traceback (most recent call last):
File "/config/custom_components/tapo_control/utils.py", line 1175, in update_listener
hass.data[DOMAIN][entry.entry_id]["eventsDevice"] = onvifDevice["device"]
~~~~~~~~~~~^^^^^^^^^^
TypeError: 'bool' object is not subscriptable

Fixed in https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/releases/tag/5.4.27

should I now raise a separate issue for selecting auto for night vision or does the fix address both?

Yes please, make sure to document what you see in the app for that option as well please and we can take it from there.

great - thanks


onNotificationAPN and onNotificationGCM not called with cordova 3.4.0

Hi everybody,
I'm using PushPlugin and I have a problem with onNotification callback. Both don't work. Do you have any solution to fix it fastly ?
pushNotification.register(
successHandler,
errorHandler, {
"senderID":"12345678",
"ecb":"onNotificationGCM"
}
);

Thanks judis . your solution worked for me ...cheers!!!
Hi All, I faced the same problem " onNotificationGCM not defined". I tried the solution suggested by Judis, and it worked for me without any problem.
Solution:
Instead of
function onNotificationGCM(e) {
use
onNotificationGCM = function (e) {

Judis, your solution works for me! thank you

Sorry for the late response, Might be helpful for another developer like me.
Fixed the issue by simply changed the network connection and its start working.(with the same lines of code)


Non-generic Tasks

Hello,
Thanks for this useful library.
What is the guidance for working with non-generic Tasks? A simple repro of my issue:
let doesThisWork : System.Threading.Tasks.Task =
    task {
        do! System.Threading.Tasks.Task.Delay(1000)
    }

Which produces this error:
FS0001    This expression was expected to have type
    'Threading.Tasks.Task'
but here has type
    'Threading.Tasks.Task<unit>'

One workaround we have is:
type System.Threading.Tasks.Task with

    static member Ignore (task: Task<'T>) : Task =
        task :> Task

And then:
let doesThisWork : System.Threading.Tasks.Task =
    task {
        do! System.Threading.Tasks.Task.Delay(1000)
    } |> Task.Ignore

But this feels rather hacky.

Yes it feels pretty reasonable to me

@kentcb This is pretty standard when going from F# unit to void in C# where you have this "equivalent" type for the void case in C# but just a single type in F#.

Thanks all! Glad we're on the right track.


How to modernize ObjectWriter package?

In current master, ObjectWriter is the only project utilizing old-style RIDs (toolchain.{targetOS_name}.{targetOS_version}-{targetOS_arch}) and relying on nuspec files.
In order to bring it to new platforms such as Alpine Linux (#4552) and CentOS (#602), or new architectures such as aarch_32 (#3776) and x86_32 (#4589), it requires us to add file entries either with:

old RID scheme toolchain*
or modernize the ObjectWriter package and wire it up with build.{cmd,sh} in such a way that it will automajically light up the build for newly introduced RID in CoreRT repo.

IMO, modernizing the package is a better solution mostly for coherency.
If the code owners agree to upgrade this package to new packaging system, would it make sense to:

create a separate entry under :/pkg dir?

or perhaps include it as a dependency on existing :/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.{builds,pkgproj}?

anything else to consider before removing .nuspec files?

/cc @jkotas, @A-And

We would love to modernize ObjectWriter packaging. Thanks!

create a separate entry under :/pkg dir?

This should be a good start.

Great idea!
What jumps out as a thing to consider is that in CoreRT we haven't yet built a generalized packaging framework on par with the CoreCLR repo. As such there is a small amount of manual work to be done when setting up RID-targeted packages (so that runtime.json and the package itself are generated correctly) - see the current ILCompiler package.


Adding maxhy to proxmox plugin maintainers

Description

https://github.com/jenkinsci/proxmox-plugin
@justnom gave me (@Maxhy) maintainer permissions a few years ago on GitHub. I need appropriate permissions on artifactory to perform a real release now. Thanks.
Submitter checklist for changing permissions

Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[x] All newly added users have logged in to Artifactory at least once

Maintainer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
There are IRC Bot commands for it

@slide I updated the PR, can you review again? Thanks!


Incorrect solution to simple ILP problem

The following Python3 program:
import numpy as np
import cvxpy

v = np.array([-1, -1])
m = np.zeros((2, 2))
selection = cvxpy.Variable(2, boolean=True)
constraint = m @ selection <= v
problem = cvxpy.Problem(cvxpy.Minimize(0), [constraint])
print(problem.solve())

should surely not find a feasible solution, but it prints 0.0. Maybe I'm missing something?

Yes, it seems best to not have ECOS_BB as a default. It might even be best to not have any default integer solver at all, and if the user tries to solve an integer program cvxpy tells them to install one of various options.

Okay cool. Sometime soon I'll look into things a bit more just to be sure that the issue with ECOS_BB isn't because of some crazy canonicalization thing happening within cvxpy.
I don't really like the idea of not having a default integer programming solver. Are there licensing issues to making GLPK a dependency of cvxpy?

I have confirmed that the error is due to ECOS_BB, and not something on cvxpy's end; I've opened up a ticket https://github.com/embotech/ecos/issues/166 on the ECOS page.


Macro opens class hall panel with non-talented skill is in the macro

I found this issue using a different macro, the problem was that the macro used Horn of Winter on a DK, but without horn of winter talented, when the macro reached the cast for HoW, it will open the class order hall report pane.  I tested this by creating a macro with only the following:
Sequences['Test'] = {
-- This Sequence was exported from GSE 2.0.14.
  Author="Deathcyn",
  SpecID=251,
  Talents = "3123232",
  Default=1,
  MacroVersions = {
    [1] = {
      StepFunction = [[Sequential]],
      KeyPress={
        "/cast Horn of Winter",
      },
      PreMacro={
      },
      PostMacro={
      },
      KeyRelease={
      },
    },
  },
}

It should be noted that this only appears to happen when logging into the character if Horn of Winter is not talented.  Swapping to horn of winter then back to another talent the issue does not persist.  However if you log out and back in without selecting the horn of winter talent, then this behavior happens.
I have not tested this to see if there is a similar issue with other talents on other classes.  I did test this with only GSE2: Gnome Sequencer Enhanced and GS-E: WLM hih Performance Macros addon enabled.
I understand just removing Horn of Winter will fix the issue, however i assume that the correct functionality should just skip over even if its not talented, and opening the class order hall panel is not intended, in any scenario.

The problem is there is an item called hall of winter that is a follower upgrade. This item is what is causing the Class Hall dialog to open.  You don't have to have the item but just be 110.  It's a bug with WoW and can't be fixed at the GSE end.
TimothyLuke

On 10 Mar 2017, at 2:16 pm, malicyn<EMAIL_ADDRESS>wrote:
I found this issue using a different macro, the problem was that the macro used Horn of Winter on a DK, but without horn of winter talented, when the macro reached the cast for HoW, it will open the class order hall report pane. I tested this by creating a macro with only the following:
Sequences['Test'] = {
-- This Sequence was exported from GSE 2.0.14.
Author="Deathcyn@Area 52",
SpecID=251,
Talents = "3123232",
Default=1,
MacroVersions = {
[1] = {
StepFunction = [[Sequential]],
KeyPress={
"/cast Horn of Winter",
},
PreMacro={
},
PostMacro={
},
KeyRelease={
},
},
},
}
It should be noted that this only appears to happen when logging into the character if Horn of Winter is not talented. Swapping to horn of winter then back to another talent the issue does not persist. However if you log out and back in without selecting the horn of winter talent, then this behavior happens.
I have not tested this to see if there is a similar issue with other talents on other classes. I did test this with only GSE2: Gnome Sequencer Enhanced and GS-E: WLM hih Performance Macros addon enabled.
I understand just removing Horn of Winter will fix the issue, however i assume that the correct functionality should just skip over even if its not talented, and opening the class order hall panel is not intended, in any scenario.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


I am getting this error PermissionError: [Errno 13] Permission denied: '/home/projects'

I followed the  how to use custom_data with TimeEval guide, but somehow i am not able to do this, i keep getting the same error, tried on a window WSL, and on a Linux machine.  I believe this has something to do with the HPI_CLUSTER.akita_dataset_paths[HPI_CLUSTER.BENCHMARK], since am trying to use custom_dataset.
Traceback (most recent call last):
  File "/home/ubuntu/miniconda3/envs/timeeval/lib/python3.8/pathlib.py", line 1288, in mkdir
    self._accessor.mkdir(self, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/home/projects/akita/data/benchmark-data/data-processed'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/miniconda3/envs/timeeval/lib/python3.8/pathlib.py", line 1288, in mkdir
    self._accessor.mkdir(self, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/home/projects/akita/data/benchmark-data'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/miniconda3/envs/timeeval/lib/python3.8/pathlib.py", line 1288, in mkdir
    self._accessor.mkdir(self, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/home/projects/akita/data'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/miniconda3/envs/timeeval/lib/python3.8/pathlib.py", line 1288, in mkdir
    self._accessor.mkdir(self, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/home/projects/akita'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "main.py", line 57, in <module>
    main()
  File "main.py", line 19, in main
    dm = DatasetManager(HPI_CLUSTER.akita_dataset_paths[HPI_CLUSTER.BENCHMARK], custom_datasets_file=custom_dataset)
  File "/home/ubuntu/miniconda3/envs/timeeval/lib/python3.8/site-packages/timeeval/datasets/dataset_manager.py", line 80, in __init__
    df = self._create_index_file(self._filepath)
  File "/home/ubuntu/miniconda3/envs/timeeval/lib/python3.8/site-packages/timeeval/datasets/datasets.py", line 70, in _create_index_file
    dataset_dir.mkdir(parents=True)
  File "/home/ubuntu/miniconda3/envs/timeeval/lib/python3.8/pathlib.py", line 1292, in mkdir
    self.parent.mkdir(parents=True, exist_ok=True)
  File "/home/ubuntu/miniconda3/envs/timeeval/lib/python3.8/pathlib.py", line 1292, in mkdir
    self.parent.mkdir(parents=True, exist_ok=True)
  File "/home/ubuntu/miniconda3/envs/timeeval/lib/python3.8/pathlib.py", line 1292, in mkdir
    self.parent.mkdir(parents=True, exist_ok=True)
  [Previous line repeated 1 more time]
  File "/home/ubuntu/miniconda3/envs/timeeval/lib/python3.8/pathlib.py", line 1288, in mkdir
    self._accessor.mkdir(self, mode)
PermissionError: [Errno 13] Permission denied: '/home/projects'```

Assuming the issue is completed. If there are still open questions, please re-open the issue.


AKCORE-3: ShareGroupHeartbeat RPC implementation using group coordinator functionality

About
This PR completed the 2 TODOs mentioned in this PR-

Send the ShareGroupHeartbeatRequest to the group coordinator and receive the response as ShareGroupHeartbeatResponse
Uncomment the test which verifies the functionality mentioned in point 1

Reference - AKCORE-3
Build
The build is passing as shown in the screenshot

The check styles is passing as shown in the screenshot

Testing
The uncommented test passes as shown in the sacreenshot

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

LGTM. Can we have concise PR title, seems like a description to me.

yes, I have changed the description appropriately


[SPARK-12895] Implement TaskMetrics with accumulators

This was once part of #10717. It was split into its own patch so it's more reviewable. The high level idea in this issue is to implement TaskMetrics using accumulators internally to pave the way for SPARK-12896 in the future.
As of this patch, accumulators are now sent both ways between the driver and executors. Before this patch, accumulators were only sent from the driver to the executors. I intend to restore the original behavior in SPARK-12896, for which I already have changes ready (as shown in #10717). I'm introducing this temporary change in behavior only to break the original patch down so it is more approachable to reviewers.
As a result, there are a few TODO's in the code that describe these dangling behaviors, notably:

Accumulable#_value is no longer transient because the driver needs TaskMetrics values from the executors
Things like acc.value and acc = 10 are now allowed on the executors. Previously we detected whether we're on the executors or on the driver through readObject, but we can't do that anymore.
We have to explicitly set an accumulator to acc.zero in TaskContextImpl, because we can't do that in readObject anymore.

All of these are temporary and will no longer be the case once we do SPARK-12896.

Test build #49702 has started for PR 10835 at commit 7b5d840.

Test build #49702 has finished for PR 10835 at commit 7b5d840.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49702/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49711/
Test FAILed.

retest this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49714/
Test FAILed.

retest this please...

Test build #49718 has started for PR 10835 at commit 2069a78.

Test build #49718 has finished for PR 10835 at commit 2069a78.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49718/
Test FAILed.

Test build #49724 has started for PR 10835 at commit 40fd853.

Test build #49724 has finished for PR 10835 at commit 40fd853.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49724/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

retest this please

Test build #49729 has started for PR 10835 at commit 2a3cd27.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49728/
Test FAILed.

retest this please

Test build #49732 has started for PR 10835 at commit 2a3cd27.

Test build #49729 has finished for PR 10835 at commit 2a3cd27.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49729/
Test FAILed.

Test build #49747 has started for PR 10835 at commit 67a1bee.

Test build #49732 has finished for PR 10835 at commit 2a3cd27.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49732/
Test FAILed.

retest this please. This should pass tests.

retest this please. The latest commit should pass tests.

Test build #49752 has started for PR 10835 at commit 4ca7328.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49749/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #2416 has started for PR 10835 at commit 308db4c.

Test build #2417 has started for PR 10835 at commit 308db4c.

Test build #2418 has started for PR 10835 at commit 308db4c.

Test build #49753 has started for PR 10835 at commit 308db4c.

Test build #49747 has finished for PR 10835 at commit 67a1bee.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49747/
Test FAILed.

Test build #49752 has finished for PR 10835 at commit 4ca7328.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49752/
Test PASSed.

Test build #2417 has finished for PR 10835 at commit 308db4c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #2416 has finished for PR 10835 at commit 308db4c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #2418 has finished for PR 10835 at commit 308db4c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #49753 has finished for PR 10835 at commit 308db4c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49753/
Test PASSed.

@andrewor14 There 9 places mentioned SPARK-12896, how large is that patch going to be? I'm wondering that will it be more clear if we can include that in the same PR.

@davies I am preparing the other patch at the moment, which will build on top of the changes here. My guess is that the whole thing will be about 2.5k lines of code. I will open that one shortly so if you prefer to review both SPARK-12895 and SPARK-12896 together you also can.

@davies the bigger patch is ready: #10857. Let me know which one you prefer to review more. :)

I took a fairly broad pass over this and the bulk of the changes here look straightforward. Most of my comments above are fairly minor.
Let me take a closer look at the followup patch for SPARK-12896 in order to try to better understand the comments and disabled tests which reference it.
One high-level question: as part of this migration of task metrics to accumulators, I believe that we planned to introduce a mechanism to opt out of accumulator update de-duplication logic for these internal metric accumulators. Are you planning to do that change as part of these two patches or will that be deferred to followup

I believe that we planned to introduce a mechanism to opt out of accumulator update de-duplication logic for these internal metric accumulators. Are you planning to do that change as part of these two patches or will that be deferred to followup?

That's in the other patch #10857

I did a pass on #10857, LGTM.

Test build #50022 has started for PR 10835 at commit 12e60a4.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50021/
Test FAILed.

OK, I believe I addressed all of your comments @JoshRosen. Please let me know if there's something I missed.

Test build #50028 has started for PR 10835 at commit 13bdb5c.

Yep, this now looks good to me. Thanks!

Alright, as @JoshRosen and I discussed offline, I will just merge the changes in #10857 into here so it's easier to review, now that we've already looked at all the changes in SPARK-12895. Then this PR will be linked with both SPARK-12895 and SPARK-12896.

Test build #50033 has started for PR 10835 at commit ae15313.

Test build #50022 has finished for PR 10835 at commit 12e60a4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50022/
Test FAILed.

Test build #50028 has finished for PR 10835 at commit 13bdb5c.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50028/
Test FAILed.

Test build #50033 has finished for PR 10835 at commit ae15313.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
          \"Cannot merge estimator of class \" + other.getClass().getName()
public class IncompatibleMergeException extends Exception

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50033/
Test FAILed.

Test build #50064 has started for PR 10835 at commit 7e7c2f4.

Test build #50064 has finished for PR 10835 at commit 7e7c2f4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50064/
Test PASSed.

Merged build finished. Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50089/
Test FAILed.

Merged build finished. Test FAILed.

According to Reviewable I'm all caught up with the latest changes. This looks like it's in really good shape to me; I only had a few very minor comments upthread, plus one or two clarifying questions (I think everything is fine, but just wanted to double-check my understanding before a final sign-off). I think we're on track to get this by end-of-day tomorrow, if not earlier.

retest this please

Test build #50110 has started for PR 10835 at commit 6893419.

Test build #50110 has finished for PR 10835 at commit 6893419.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public final class BitArray
public abstract class BloomFilter
public class BloomFilterImpl extends BloomFilter
        \"Cannot merge bloom filter of class \" + other.getClass().getName()
class QuantileDiscretizer(JavaEstimator, HasInputCol, HasOutputCol):

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50110/
Test FAILed.

retest this please

@JoshRosen I believe I addressed all of your comments. The latest commit should pass tests. There are a few things I would like to do on my end that shouldn't block on the merging of this patch:

Do a final pass of self-review over the outstanding changes
Compile a list of changed public APIs
File follow-up JIRAs based on the few things we discussed in the review
Test HistoryServer reading Spark 1.6 logs

If this patch looks good to you and it passes tests, feel free to merge it. I'll keep working on these things in the mean time.

Test build #50163 has started for PR 10835 at commit 9f964f2.

Test build #50163 has finished for PR 10835 at commit 9f964f2.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class DefaultSource extends HadoopFsRelationProvider with DataSourceRegister
class ChiSqSelector(JavaEstimator, HasFeaturesCol, HasOutputCol, HasLabelCol):
class ChiSqSelectorModel(JavaModel):
 public static final class Array extends ArrayData
 public static final class Struct extends InternalRow
public class ColumnVectorUtils
 public static final class Row extends InternalRow

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50163/
Test PASSed.

I'm going to merge this now and we'll deal with those other tasks in followup patches. Thanks!

I have compiled a list of breaking @DeveloperAPI changes:
ExceptionFailure:

changed: apply, unapply, copy
removed: old constructor
deprecated: metrics

InputMetrics:

removed: old constructor, all case class methods, updateBytesRead, setBytesReadCallback, var bytesReadCallback
deprecated: apply, unapply, incBytesRead, incRecordsRead

OutputMetrics:

removed: old constructor, all case class methods
deprecated: apply, unapply

ShuffleReadMetrics:

removed: old constructor

ShuffleWriteMetrics:

removed: old constructor

TaskMetrics:

changed: accumulatorUpdates return type (Map[Long, Any] -> Seq[AccumulableInfo])
removed: hostname
deprecated: var updatedBlocks, set var outputMetrics, set var shuffleWriteMetrics

AccumulableInfo:

changed: update type (Option[String] -> Option[Any]), value type (String -> Option[Any]), name type (String -> Option[String])
removed: internal
deprecated: all existing apply methods

SparkListenerTaskEnd:

changed: taskMetrics is now @Nullable

SparkListenerExecutorMetricsUpdate:

changed: apply, unapply, copy
removed: old constructor, taskMetrics

I was able to verify that the changes in Accumulable and Accumulator do not break compatibility.


[Task] add debug information to the response header

Description
add debug information to the response header
Task List

[ ] add debug information to the response header;

[ ] add doc for this new feature;

log plugin has done it well, so I close this issue.


added CSS to project

This PR added CSS style sheet and updated HTML file for prework study guide application.


System notification appearing Twice in AEM ( AEM Cloud)

Required Information

[ ] AEM Version : AEM As cloud service
[ ] ACS AEM Commons Version: 6.5.0___
[ ] Reproducible on Latest? yes

Expected Behavior
When I create a system notification and when I enable it, it should come on the AEM page, only once
Actual Behavior
System notification appearing twice. It is not happening in local. This behaviour is only in cloud.
It is not happening in any AEM consoles like sites, tools , assets . It is happening only on AEM pages ( Created using some templates)
Steps to Reproduce
Create a System notification and enable it.
Create a page using Template in AEM
Open the newly created page.
User should be able to see the duplicate banners

NOTE:
Second banner is not dismissible
Links
similar to below issue
https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/1839

Can you check if the Clientlibs for this is getting loaded twice on the page?

Can you check if the Clientlibs for this is getting loaded twice on the page?

I checked our client libs. We are not calling the ACS AEM commons system notifications.
I observed below points.
There are 2 calls in the network tab

.adobeaemcloud.com/etc/acs-commons/notifications/jcr_content.list.html?=1713292140828
.adobeaemcloud.com/etc/acs-commons/notifications/_jcr_content.list.html
both are from the same initiator

in the page path if I remove the ui#/aem/editor.html then banner will come only once.
Note:
Second banner is not dismissible

@davidjgonzalez  and @joerghoh
any suggestion here please.

Hi Team,
Is anyone checking this ticket ?
CC: @davidjgonzalez @joerghoh

Hi @davidjgonzalez @joerghoh
I am facing the same issue
Is anyone checking this ticket?


Pre bday updates

Pulling in several changes for the birthday. @tianon changes to hack and his eval hits.  Also finally, finally, @thaJeztah's css stylings go live.
Brining in the ubuntu updates and installation menu fixes.
Last second tweak to the Kitematic location in the file to clarify the choices.

@jfrazelle this is failing DCO because of those same commits that keep causing problems on docs.  I think it will happen until we release.
Can you give me a LGTM anyway?

LGTM

Yeaaah! Thanks, @moxiegirl and good luck with the party.

LGTM


Can't use pretrained models

Hi!
I'm trying to run the evaluation as you describe in the README. However, I keep getting the message: Invalid MIT-MAGIC-COOKIE-1 key and nothing happens. Is there a link where I can download the pretrained weights?
Thanks!

Could you please double-check if this error is still there? It's probably due to a server update recently.

I'm getting at the beginning of the execution Invalid MIT-MAGIC-COOKIE-1 and later a connection refused error:
  File "/usr/lib/python3.8/urllib/request.py", line 1357, in do_open
    raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 111] Connection refused>
--------------------------------------------------------------------------
Primary job  terminated normally, but 1 process returned
a non-zero exit code. Per user-direction, the job has been aborted.
--------------------------------------------------------------------------
--------------------------------------------------------------------------
mpirun detected that one or more processes exited with non-zero status, thus causing
the job to be terminated. The first process to do so was:

  Process name: [[52950,1],0]
  Exit code:    1

That's wield. You could try to directly download the following two files:
<EMAIL_ADDRESS>https://hanlab.mit.edu/files/SPVNAS/spvnas_specialized/SemanticKITTI_val_SPVNAS@65GMACs/init

If that still does not work, it's probably due to some network settings.

Yes! thank you!


feat: update deployment guides for Data Proxy

Show how to deploy to

Cloudflare workers
Deno deploy
using Accelerate

Closed.


The Jobs dataset

Hello, I am doing some expreiments about causal inference. And I find jobs dataset in /perfect_match/data_access/jobs/, so I use them jobs_DW_bin.test.npz and jobs_DW_bin.train.npz. But I find there 17 covariates in your dataset, while ony 8 covarites in raw data(Lalonde dataset). May I ask why.
Thanks a lot!
Qidong Liu

Hi @liuqidong07
Thank you for your question.
jobs_DW_bin.(test|train).npz are the same preprocessed datasets used in Shalit, J, Sontag, ICML, 2017 (available at https://www.fredjo.com/).
However, unfortunately, their paper does not detail exactly how they preprocessed the original data. My assumption is that the number of covariates increased because they transformed categorical covariates with more than two distinct values into their one-hot encoded representation, since all categorical covariates are binary in the preprocessed dataset.
Please feel free to reach out to the original authors of Shalit, J, Sontag, ICML, 2017 if you require more details into their preprocessing pipeline.
Hope that helps.


Enhanced pyi file generation from the official docs

Hi Mr. Qin,
Thank you for your isaacgym python stubs! It really helps me a lot!
Currently, the stubs provides basic type hints, but I think there are no details regarding the parameter type and description. Therefore, I had developed a simple script (the enhance-pyi.ipynb in my forked repo), which parses the official html docs, and inserts the function and class docs into the current .pyi file. Here is a comparison between the original one and my enhanced one:
# gymapi.pyi, line 561-563

    def acquire_actor_root_state_tensor(self, arg0: Sim) -> Tensor: ...

    def acquire_dof_force_tensor(self, arg0: Sim) -> Tensor: ...

# gymapi-enhanced.pyi, line 649-675

    def acquire_actor_root_state_tensor(self, arg0: Sim) -> Tensor: ...
    ''' acquire_actor_root_state_tensor(self: Gym, arg0: Sim) -> Tensor
    Retrieves buffer for Actor root states.  The buffer has shape (num_actors, 13).
    State for each actor root contains position([0:3]), rotation([3:7]), linear velocity([7:10]), and angular velocity([10:13]).
    Parameters:
    param1 (Sim) - Simulation Handle

    Returns:
    GymTensor object containing buffer for actor root states

    Return type:
    isaacgym.gymapi.Tensor
    '''

    def acquire_dof_force_tensor(self, arg0: Sim) -> Tensor: ...
    ''' acquire_dof_force_tensor(self: Gym, arg0: Sim) -> Tensor
    Retrieves buffer for DOF forces. One force value per each DOF in simulation.
    Parameters:
    param1 (Sim) - Simulation Handle

    Returns:
    GymTensor object containing buffer for DOF forces

    Return type:
    isaacgym.gymapi.Tensor
    '''

As you can see, the docs are accompanied with the functions.  In IDEs such as VSCode, you can ctrl+left click the functions to jump into the .pyi file, and review the function descriptions in detail. I believe this can boost the developing speed even more. The following is a video demo:
https://github.com/yzqin/isaacgym-stubs/assets/74816944/ac7c718e-7fda-404e-90aa-301f7374021e
Steps to run my script:

Clone my repo and change to enhance branch.

Open the enhance-pyi.ipynb and set the HTML_PATH in the last cell to where isaacgym/docs/api/python/ locates.

Run the notebook, and the gymapi-enhanced.pyi would be produced. There is a copy here too.

Additional comments
I understand directly merging my branch into your repo may destroy the file structure and clearity. Therefore, I am raising this issue to introduce you about my work for this project. If you are interested with my enhanced version of .pyi file, please reply to me, and we can discuss about further details. Thank you!! 😃

Hi @I-am-Future
This is excellent! The enhanced version appears to be very user-friendly and the documentation string is superb! Given that the enhanced version is strictly better than the original one, I suggest replacing the original isaacgym-stubs/gymapi.pyi with your gymapi-enhanced.pyi in your repository first. Then, you could create a pull request to merge it into this repository and officially become a contributor.
I will also update the readme to include a link to the enhance-pyi.ipynb in your forked repository. I believe this script could be beneficial for other Python packages generated using pybind11 as well.

Hi Mr. @yzqin,
Thank you for your great comments to my work! I am really excited that I can contribute to your repo. Before that, I'll first make another check to ensure that my .pyi file's document strings are all correctly generated. Then, I will do the pull request.
One of my concern is that my .pyi is only made for the preview version 4. But I can help to generate the remaining version's enhanced .pyi file in the future. 😄
My enhance-pyi.ipynb script is originally designed for the Isaac Gym. But I think it probably can be used in other API reference's HTML page that generated by Sphnix with minor revisions on the script. 😆

Close this issue with PR #3


feat(icon): support playwright.config.mts

Fixes #IssueNumber
Changes proposed:

[x] Add
[ ] Delete
[ ] Fix
[ ] Prepare

https://github.com/microsoft/playwright/blob/a54ed48b42cdc898e6444f643ac8fb97cdb498f2/packages/playwright/src/common/configLoader.ts#L315-L321

Please associate this PR with an issue for better tracking.

issue added :）

issue added :）

Thank you


[WIP] Fix flexci bucket address, use GCR

fix flexci's bucket address for temp storage
use tempfs for speeding up
increase memory size for tempfs
use GCR(Google Container Registry) for speeding up

/test

/test


WIP: Include request id in error objects

[16:23:56] 'test-browser' errored after 14 s
[16:23:56] Error in plugin 'gulp-mocha-phantomjs'
test failed

npm ERR! Linux 3.16.0-30-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! node v4.4.7
npm ERR! npm  v2.15.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>prepublish: `gulp`
npm ERR! Exit status 1

happens on my box :/.

Now Circle would explain to you what went wrong in much greater detail.

@enykeev: Sweet. This should help me.


Add logger to deployment

Description

Add logger to deployment.

Motivation and Context

Deployment now has a detailed log on the progress to allow debugging issues during this stage.

How Has This Been Tested?

Screenshots
Types of changes

[x] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[ ] Unit Tests (work on Unit Tests, has no impact on code or features)
[ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@nfbot updatedependencies


[cli] locale.Error: unsupported locale setting

From Ubuntu 14.04 using the CLI from https://s3-us-west-2.amazonaws.com/opdemand/deis-ubuntu-dev.tgz
$ deis
Traceback (most recent call last):
  File "<string>", line 74, in <module>
  File "/home/jenkins/workspace/build-deis-cli-ubuntu/client/build/deis/out00-PYZ.pyz/locale", line 579, in setlocale
locale.Error: unsupported locale setting

I'm happy to provide more information for further debugging :-)

@fgrehm thanks a lot. I had the same issue, I owe a :beer:.

Also ran into this, ironically on the heroku ruby buildpack built and deployed on Deis.
2015-08-23T23:59:17UTC api[web.1]:   File "/var/lib/jenkins/jobs/build-deis-cli-installer-linux/workspace/src/github.com/deis/deis/client/build/deis/out00-PYZ.pyz/locale", line 579, in setlocale
2015-08-23T23:59:17UTC api[web.1]: locale.Error: unsupported locale setting

However, that environment does not allow you to change your locale to en_US.UTF-8:
slug@deab043cc24f:~$ export LANG=en_US.UTF-8
slug@deab043cc24f:~$ export LC_ALL=en_US.UTF-8
bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
slug@deab043cc24f:~$ ~/bin/deis
Traceback (most recent call last):
  File "<string>", line 89, in <module>
  File "/var/lib/jenkins/jobs/build-deis-cli-installer-linux/workspace/src/github.com/deis/deis/client/build/deis/out00-PYZ.pyz/locale", line 579, in setlocale
locale.Error: unsupported locale setting

It is apparently just called something different in that slug environment:
slug@deab043cc24f:~$ locale -a
C
C.UTF-8
POSIX

Then things seem to work.  Chronicling for future adventurers.
slug@deab043cc24f:~$ export LC_ALL=C.UTF-8
slug@deab043cc24f:~$ ~/bin/deis
Usage: deis <command> [<args>...]


[#4017] Implement proper resource leak detection for CompositeByteBuf

Motivation:
CompositeByteBuf only implemented simple resource leak detection and how it was implemented was completly different to the way it was for ByteBuf. The other problem was that slice(), duplicate() and others would not return a resource leak enabled buffer.
Modifications:

Proper implementation for all level of resource leak detection for CompositeByteBuf

Result:
Proper resource leak detection for CompositeByteBuf.

@Scottmitch @trustin @nmittler PTAL

@normanmaurer +1 this was badly needed! :)
Took a first pass ... just a few minor comments. Looks great!

LGTM. Great job!

Cherry-picked into 4.0 (18765a3bf7bf85b541897bc9b3dd8e0c57482614) and 4.1 (cdb70d31eebdf19e93191840bb817bcb351cbe3c)

@normanmaurer - lgtm ... great work!


Create LICENSE.md

Hi @baptiste-genest, can you merge this one?

Are you sure you want to release this software masterpiece for free? we could charge a small subscription fee of only 50.99€/month... xD
Thanks for the license!


Fix mage verify

Updates zeitgeist to v0.4.3 to fix version check
Adds nolint:gosec to digests in unit tests
Tested via go run mage.go
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes local (non-ci) builds using default mage target
Which issue(s) this PR fixes:
None
See: kubernetes-sigs/zeitgeist#739 and kubernetes-sigs/release-utils#96
Special notes for your reviewer:
If you have an existing version of zeitgeist before 0.4.3 you will have to do rm $GOPATH/bin/zeitgeist before go run mage.go
Does this PR introduce a user-facing change?
NONE

/test all

/ok-to-test


dynamically added tab page click not working.

Hello,
Please suggest me how to add new tab page in 'HTML-defined Tabs'.
thanks in advance.

Here's a plunk demonstrating adding a tab (Tab Number 11) and its tab-pane and then refreshing the plugin:
http://plnkr.co/edit/M4ofcV2XNNAb0m4jUoZn
This is the code that does it (it's in st-demo.js):
setTimeout(() => {
  console.log('----> Appending Tab Number 11');
  $('ul.nav-tabs').append('
Tab Number 11 (NEW!)
');
  $('.tab-content').append('
Tab 11 (NEW!) content...
');
  $('.nav-tabs').scrollingTabs('refresh');
}, 10);

I wrapped it in a setTimeout to give the plugin time to initialize before adding the new tab.
Is that what you're trying to accomplish?

Thank you Mike.
It's working fine.

Excellent! Glad to hear it's working for you now. 👍


New Version Release Banner/Info

Feature Description
For those of us running on prem, could we have a banner that pops up when you have released a new version, this would help us keep on top of releases and not fall behind.
Screenshots
No response

This has been implemented. It will only be seen by administrators in top of admin panel.

Curious, I am an admin and I have never seen it, we are on version 1.21.3

Because it has been disabled by default for long time:  Configure update checker on installation page #21655

Thanks, I've looked at the config cheat sheet and can't see an option to turn it on or see anything in the UI. What am I missing?

ref: https://docs.gitea.com/administration/config-cheat-sheet?_highlight=update_checker#cron----check-for-new-gitea-versions-cronupdate_checker

Ah, I didn't find it, I searched for the word "update", thank you for taking the time to send me the link, it is working now.


Extracting MGC parameter

Dear all,
Regarding to the WORLD vocoder, does the Merlin toolkit use to extract the MGC parameter by using "CheapTrick" spectral estimation algorithm?
Best regards,

yes, https://github.com/CSTR-Edinburgh/merlin/blob/master/tools/WORLD/test/analysis.cpp#L139

Thank you very much ...


electron-prebuilt and electron-packager upgraded

test this

@dgolovin, please review and merge if everything is OK.

rebased, @dgolovin, @jrichter1 please review and merge if everything is OK.

Pushed to master.


Encoding to JPEG transfer syntaxes

Decoding JPEG-based transfer syntaxes is already supported, but support for encoding a native DICOM object to JPEG would be good to have.
In a first phase, this amounts to implementing the encode method of the PixelRWAdapter implementation for JPEGAdapter.

I think I can take this issue.
Is there a way to test this new implementation after it is finished?

Is there a way to test this new implementation after it is finished?

By lack of a proper transcoding module (efforts are ongoing!), we can test the adapter in isolation by encoding one of the test files, reading the output as a JPEG file using the decoder and checking whether some meta-properties are correct (width, height...). Pixel data check could be done too, but we would need to allow an error margin to account for loss.


USHIFT-1122: set minimum container-selinux dependency to 2.208

microshift-e2e is failing with service-ca-controller in CrashLoopBackOff, so I think this version of container-selinux does not work on the 9.1 images.
container-selinux.noarch                      3:2.208.0-2.rhaos4.13.el9                                        @rhocp-4.13-for-rhel-9-mirrorbeta-x86_64-rpms
openvswitch-selinux-extra-policy.noarch       1.0-31.el9fdp                                                    @rhocp-4.13-for-rhel-9-mirrorbeta-x86_64-rpms
selinux-policy.noarch                         34.1.43-1.el9                                                    @anaconda
selinux-policy-targeted.noarch                34.1.43-1.el9                                                    @anaconda

/retest

/test microshift-e2e-arm
/test microshift-e2e

/test microshift-e2e-arm
/test microshift-e2e

Conformance-reduced[-arm]: These failures are expected since it's still being run on a rhel 9.1 VM on GCP.  A PR is on hold to update these tests, pending this one being merged.

e2e-arm: This is most likely from a bug in the CI scripts, but it's impossible to tell exactly what from the sparse logs. We'll need to merge this PR so that we can debug the CI scripts.

/pj-rehearse ack
/lgtm

/skip e2e-openshift-conformance-reduced-arm
/skip e2e-openshift-conformance-reduced
/skip microshift-e2e-arm

/override e2e-openshift-conformance-reduced-arm
/override e2e-openshift-conformance-reduced
/override microshift-e2e-arm

/override ci/prow/e2e-openshift-conformance-reduced-arm
/override ci/prow/e2e-openshift-conformance-reduced
/override ci/prow/microshift-e2e-arm

/cherry-pick release-4.13


Rename to GolfClapBot

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Add files via upload

replacing current image here- https://xsoar.pan.dev/docs/incidents/incident-pre-processing#example as it doesn't match the text

Status
Ready/In Progress/In Hold (Reason for hold)
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer

@Itay4 Kobbi doesn't have permissions to approve this. Can you?

From [potential phishing]? What do you suggest?

the text says: Therefore, we created, a condition for incoming incidents that have a subject line that contains the text, this is a phishing email.

@tschanfeld - In continuation to @Itay4's comment and the comments in the issue, I reviewed the page on the preview site and found a few things that still need to be modified:

The first paragraph:

In most cases, in a phishing campaign, the email subject will be similar. Therefore, we created, a condition for incoming incidents that have a subject line that contains the text, this is a phishing email.

In the image, the Email Subject field is compared to [potential phishing] while in the line above, it mentions that it compares it to 'this is a phishing email':

subject line that contains the text, this is a phishing email

We need to change the line above to match the image, i.e.:

subject line that contains the text '[potential phishing]'

The second paragraph:

As we know that this is a campaign, we are going to ask to close the incoming incident and link it to an already existing incident.

The image is showing a Drop and update action while the second sentence in the paragraph above mentions:

we are going to ask to close the incoming incident and link it to an already existing incident

We need to change the second sentence to match the actual action, Drop and update.
Let me know if you have any questions.

@Itay4  created new pull request with new image version

@kgal-pan The image was changed from drop and update to link and close, so the text should be correct. Does it make sense this way, in terms of the use case?


pGina Service dies right away: System.Security.Principal.IdentityNotMappedException

captured from comments in #77:
I don't know if this problem is connected, but I hope this helps. When I start the pGina service it stops right away, therefore I believe it also crashes. Here ist the pGina.Service.ServiceHost_log.txt which mainly reports this error:
pGina.Service.Exception: CurrentDomain_UnhandledException: System.Security.Principal.IdentityNotMappedException: Some or all identity references could not be translated.
Here you can download the full file: http://www.file-upload.net/download-3998514/pGina.Service.ServiceHost_log.txt.html

I'm not sure what version of windows this is, but I suspect its a non-english localized version? I think the use of a literal string "Users" is tripping things up.  I'm working on a fix, but confirmation of my assumption would be helpful...  thanks!

please try with version <IP_ADDRESS>+ and see if you have any different behavior?

Thank you for your fast response! I'm running a german Win 7 with sp1 and the latest patches. The new version <IP_ADDRESS> did the trick! The service didn't crash and works so far flawless.
In case you want to see the log file: http://www.file-upload.net/download-3999914/pGina.Service.ServiceHost_log.txt.html

Glad it works, closing this issue.