Using babel enviroment variables

I am looking to implement babel-plugin-react-remove-properties but the CRACO config file only seems to mention added babel plugins directly into the babel plugin array. Doesnt seem to add plugins depending on the environment.
The plugin installation shows applying only to production as so:
{
  "env": {
    "production": {
      "plugins": [
        "react-remove-properties"
      ]
    }
  }
}

Is this possible with CRACO?

Anyone able to point me in the right direction? Or where to go to find this out?

Hey. Me again - wondering if anyone has ever done this? Or knows who to speak to?

I think I have found a solution: Use whenDev/whenProd: https://github.com/gsoft-inc/craco/blob/master/packages/craco/README.md#when-whendev-whenprod-whentest

const { whenProd } = require('@craco/craco');

module.exports = {
    babel: {
        plugins: [
            ...whenProd(
                () => [
                    [
                        'react-remove-properties',
                        {
                            properties: ['data-testid']
                        }
                    ]
                ],
                []
            )
        ]
    }
};

you saved my day !

thank you very much for this solution!


add tests for lua functions that use integer types

Related to task: https://redmine.openinfosecfoundation.org/issues/4182 use lua_pushinteger for pushing integer types as integers instead of floats.
Change comparted to previous PR:

Add SV tests for SCFlowStats and SCRuleIds. The tests compare generated and expected output. PCAPs reused from test lua-output-http and alert-testmyids

Previous PR: https://github.com/OISF/suricata-verify/pull/516
Patch PR: https://github.com/OISF/suricata/pull/6279

Sorry and thanks I hadn't realised this approach. Incorporated that in PR https://github.com/OISF/suricata-verify/pull/523


Fixed Python Easy Issue

Python Easy Issue
Issue:
Create a function that prints the list and the sum of the list.
TESTS:
Passed

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Cannot prerender with service-worker presets

Environment
------------------------------
- Operating System: `Linux`
- Node Version:     `v16.14.2`
- Nuxt Version:     `3.0.0-rc.8-27698890.b90d286`
- Package Manager<EMAIL_ADDRESS>- Builder:          `vite`
- User Config:      `nitro`
- Runtime Modules:  `-`
- Build Modules:    `-`
------------------------------

Reproduction
https://stackblitz.com/edit/nuxt-starter-bqru3d?file=nuxt.config.ts
Describe the bug
When using service worker presets nitro fails to pretender API routes.

Seems that route.contents object in prerender:generate hook is readonly
https://github.com/unjs/nitro/blob/3aa3bcfef4b98528db6b31d620177a57a69afdf4/src/presets/service-worker.ts#L52-L55
See:
https://github.com/unjs/nitro/blob/d1d1015228f5297741951e596079900816241f50/src/prerender.ts#L60-L67
Additional context
No response
Logs
No response

Thanks for reporting early. Should be resolved in last edge


Update submodules

Changes

Use kokoboya's resources repo
Update grasscutter to latest stable

Notes

Untested (haven't had time for it yet)
Because it's no longer using dimbreath's bins, there is no need to keep the patched relic data either

As I explained on Discord already, I will not merge this unfortunately.
We are intentionally avoiding dependency on koko-boya's resources. While it is convenient, consolidating different sources of data ourselves instead of relying on a sole repository should help reduce the single point of failure risk when that repository gets taken down eventually. It also gives us more flexibility in choosing which data source we can depend on.


Controlling the robot arm through /scaled_joint_trajectory_controller/joint_trajectory topic

Good afternoon!
In ROS 2 Humble, I would like to send joint configurations for the robot to assume through the /scaled_joint_trajectory_controller/joint_trajectory topic through a script in C++. I built a publisher that sends the exact positions of the test_scaled_joint_trajectory_controller.launch.py launch file. When I try to do that, the robot won't move. The message is received correctly by the topic, but for some reason the information is not processed. The launch file works okay.
What am I missing? Is it possible that the launch file sets some options that cannot e seen in the script of publisher_joint-trajectory_controller.py?
`
#include "rclcpp/rclcpp.hpp"
#include "trajectory_msgs/msg/joint_trajectory.hpp"
#include "std_msgs/msg/float64_multi_array.hpp"
#include "trajectory_msgs/msg/joint_trajectory_point.hpp"
#include "builtin_interfaces/msg/duration.hpp"
int main(int argc, char * argv[])
{
// Initialize the ROS 2 node
rclcpp::init(argc, argv);
auto node = std::make_sharedrclcpp::Node("publisher_joint_trajectory");
auto pub = node->create_publisher<trajectory_msgs::msg::JointTrajectory>(
"/scaled_joint_trajectory_controller/joint_trajectory", 1);
// Construct a JointTrajectory message containing the joint configuration
auto msg = std::make_shared<trajectory_msgs::msg::JointTrajectory>();
msg->joint_names = {"shoulder_pan_joint", "shoulder_lift_joint", "elbow_joint",
                    "wrist_1_joint", "wrist_2_joint", "wrist_3_joint"};
auto point = std::make_shared<trajectory_msgs::msg::JointTrajectoryPoint>();
point->positions = {double(0.785), double(-1.57), double(1.23), double(0.785), double(0.785), double(0.0)}; // Set the desired joint configuration here
auto time_from_start = std::make_shared<builtin_interfaces::msg::Duration>();
time_from_start->sec = int(4);
point->time_from_start = *time_from_start; // Set the duration for this configuration
msg->points.push_back(*point);

// Publish the joint configuration
pub->publish(*msg);

// Spin the node until it is shutdown
rclcpp::spin(node);

// Shutdown the node
rclcpp::shutdown();

return 0;

}
`

There are few things you can check.

First for JointTrajectoryPoint for all fields (velocities, accelerations, effort) give same size of data given for positions. Just array with value 0 for joint names will do.
Not sure whether you are trying work on real robot or simulation. In general you have to provide header timestamp which is part of joint trajectory message. This timestamp will be used for filtering messages of wrong timeline.
Worst case still have issues then you can try actions instead of using topics.

:)

Just to add: Setting time_from_start might also be a good thing to do.

I assume this can be closed. If there is still anything missing please comment and / or reopen.


Polygon is visible on Android

I'm submitting a ...  (check one with "x")

[ ] question
[x] any problem or bug report

OS:  (check one with "x")

[x] Android
[ ] iOS
[ ] Browser

cordova information:  (run $> cordova plugin list)
cordova-admob-sdk 0.22.0 "AdMob SDK"
cordova-plugin-admob-free 0.25.0 "Cordova AdMob Plugin"
cordova-plugin-appcenter-crashes 0.2.2 "App Center Crashes for Cordova"
cordova-plugin-appcenter-shared 0.2.2 "App Center shared code for Cordova"
cordova-plugin-badge 0.8.8 "Badge"
cordova-plugin-device 2.0.2 "Device"
cordova-plugin-facebook4 4.2.1 "Facebook Connect"
cordova-plugin-file 6.0.1 "File"
cordova-plugin-googlemaps 2.4.6 "cordova-plugin-googlemaps"
cordova-plugin-inappbrowser 3.0.0 "InAppBrowser"
cordova-plugin-inapppurchase 1.1.0 "In App Purchase"
cordova-plugin-insomnia 4.3.0 "Insomnia (prevent screen sleep)"
cordova-plugin-ionic-keyboard 2.1.3 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 3.0.0 "cordova-plugin-ionic-webview"
cordova-plugin-local-notification 0.9.0-beta.2 "LocalNotification"
cordova-plugin-mauron85-background-geolocation 3.0.0-alpha.50 "CDVBackgroundGeolocation"
cordova-plugin-nativeaudio 3.0.9 "Cordova Native Audio"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-statusbar 2.4.2 "StatusBar"
cordova-plugin-whitelist 1.3.3 "Whitelist"
cordova-promise-polyfill 0.0.2 "cordova-promise-polyfill"

If you use @ionic-native/google-maps, please tell the package.json (only @ionic-native/core and @ionic-native/google-maps are fine mostly)
@ionic-native/core : 5.2.11
@ionic-native/google-maps : 4.21.0

Current behavior:

The polygon is still visible on android, despite I set the polygon visibility to false. Even when I hardcode the visibility in Java it doesn't work.
This works on iOS
Expected behavior:

The polygon shouldn't be visible even in Android.
Screen capture or video record:

Related code, data or error log (please format your code or data):
 if (!this.polygon) {
          this.map.addPolygon({
            'points': polyPoints,
            'strokeColor': '#0083ff',
            'strokeWidth': 5,
            'fillColor': '#3794e0',
            'visible': false
          }).then((polygon: Polygon) => {
            this.polygon = polygon;
            this.polygon.setVisible(false);
          });
        }

Support this plugin activity
I appreicate if you give me a beer :beer: from here

Please send a pull request

there is no PR. I was asking for help, because even changing the native code, didn't hide the polygon

Found the place of the Code. Created a PR #2600

(log) PR #2600 has merged to the multiple_maps branch.


BUG: integrate: fix refcounting bug in quad()

Decref'ing was completely forgotten in the callback, add it back.
 It's also high-impact, as anything calling quad/nquad will leak memory (possibly rapidly if the integrand is called many times).
Backport is needed.
Fixes gh-7214

Merged, thanks Pauli.

This one is indeed unfortunate, looks like we shouldn't wait too long to get this into a bugfix release.

Two months down the road I was wondering if there is already a schedule for a bugfix release that will fix this issue? This is quite a nasty one...

@prisae within a week now. sorry about the delayed response

@rgommers no problem, thanks for pushing it forward.

We just ran into this as well -- the system has scipy 0.19.0.
Could it be possible to catch such leaks during QA before a release?

Obviously it is in principle possible.
But I'm afraid concrete suggestions will be required.

Of course, you can simply upgrade to scipy 0.19.1.

I am afraid concrete suggestions will be more work on the maintainer side, and delay the deployment by one or two days. For example,
add a travis-ci hook for special 'pre-release' tags, which will
run valgrind and produce a log, with a suppression file;
the log is then potentially analysed and vetted by a maintainer, who
triages issues to point of contacts of the submodules; no release will
be posted until the PoC has agreed the errors are not an issue; then
the maintainer add the error to the suppression file.
Of course with leak-check valgrind may run a very long time and may timeout travis.
In addition, it is not guareenteed valgrind will identify all leaks; other python leak tools
can be added to track the type and number of objects at the end of test cases.

Since it's my fault of releasing 0.19.0 with the bug and not releasing 0.19.1 with the fix quickly enough, I'll add my 2 cents. Realistically, pretty much anything qualified with more work from the RM side is unlikely to fly given the current volunteer-only dev pool (case in point: this bug; after releasing 0.19.0 I got snowed under with day job/life and that delayed 0.19.1 until Ralf did it even though the fix was just sitting in the maintenance branch for several months).
We actually do have a time period for testing pre-releases: this is what the release candidate phase is for. If you know how to test for reference leaks, great, that would be really appreciated for the next rc. If you can document the procedure so that you're not the only one who can do that, even better. If you know how to set it up automatically, still better!
Stray thoughts: CPython has something called refleak buildbot, maybe this --- or something else, I've no idea --- can be adapted for the nightly tests that Matthew Brett runs in the MacPython repo.

Since it's my fault of releasing 0.19.0 with the bug and not releasing 0.19.1 with the fix quickly enough

don't take all the blame! I could have done it much faster as well (but also snowed under etc) :)

I suspect valgrind is not feasible, unless there is an automated way to get rid of false warnings. Naively running valgrind on a single test lists 4923 "blocks are possibly lost" message. Nobody, and certainly not a volunteer RM for scipy, will read through such lists manually and identify what is a real leak (in this case, it's very likely there were 0 real leaks).
Tracking reference counts with a Python debug build on the other hand might be feasible. Doing something similar to https://github.com/scipy/scipy/blob/master/scipy/conftest.py#L23 with sys.gettotalrefcount() can be feasible. This would have to be run on Travis as a separate build so that issues are caught already in the PR stage. I don't see any point in postponing fixing these to release stage. If someone wants to something like this up, PRs are welcome.

(Also, if you are trying to assign fault, the bug is of course mine :)

Refcount checking is easy to implement in principle: https://github.com/scipy/scipy/compare/master...pv:refcount
There's also a pytest plugin for this: https://pypi.python.org/pypi/pytest-leaks
However, numpy.vectorize and maybe also possibly other things in numpy seem to leak references.
The numpy issues would have to be solved, telling contributors to add stuff to whitelist sounds like a pita.

I am mentioning this mostly because I also triggered bad memory bugs previously.
On the valgrind path: Going though the initial 4923 checks will be hard, but we can produce a valgrind suppression file for the future. Most are probably just the CPython interpretor doing weird things in its memory allocator? It does check leaks in the non-python part of scipy.
Here is the refleak.py from python -- I haven't figured how this can be added to pytest.. It does run the payload several times and seems to be aware of warming up. There is no magic though; as it calls get_totalrefcount() in the end.
https://github.com/python/cpython/blob/896145d9d266ee2758cfcd7691238cbc1f9e1ab8/Lib/test/libregrtest/refleak.py
If the leak check can be done cheaply then I agree it shall be checked during a PR -- the assumption for postponing to RC was that leak checks are prohibitively expensive.

I think the valgrind path probably needs a python debug build --- or maybe a special valgrind-enabled build.
The refcount checks are confounded by refleaks in numpy. For that, the first thing would be to get numpy master to a state where it doesn't leak.

If nobody catch it before me, I will look into the valgrind stuff this weekend.
I will likely produce some scripts that collects what shall be done; and maybe some suppression files; very likely a non-travis solution initially.

Further discussion probably should go a separate issue:
https://github.com/scipy/scipy/issues/7795


bpf: Use builtin memcpy for copying addresses

TODO:

[ ] there are 16 git grep -n " = ip4->s"
[ ] there are 18 git grep -n " = ip4->d"

For both of these, I'll add ipv4_addr_copy

I've worked a little on a coccinelle check for finding these (and fixed various coccinelle things while doing so). Here's what I came up with so far:
address_copy.cocci
// SPDX-License-Identifier: GPL-2.0
/// Find cases where we copy IP addresses from BPF context (struct __sk_buff or
/// struct xdp_md) in an inefficient manner instead of using our memcpy()
/// implementation.
// Confidence: Low
// Copyright Authors of Cilium.
// Comments:
// Options: --include-headers

@initialize:python@
@@

cnt = 0

def print_msg(src, dst, pos):
    global cnt
    print("* file %s: copying %s to %s on line %s is inefficient, use memcpy() instead" %
        (pos.file, src.strip(), dst.strip(), pos.line))
    cnt += 1

@union_v6addr@
position p;
identifier dst;
union v6addr *src;
@@

(
- dst->d1 = src->d1@p;
- dst->d2 = src->d2;
+ memcpy(dst, src, sizeof(*dst));
)

@script:python@
p << union_v6addr.p;
dst << union_v6addr.dst;
src << union_v6addr.src;
@@

print_msg(src, dst, p[0])

@struct_iphdr@
position p;
expression dst, e;
struct iphdr *ip4;
@@

(
- dst = ip4->saddr@p;
+ memcpy(dst, ip4->saddr, sizeof(*dst));
|
- dst = ip4->daddr@p;
+ memcpy(dst, ip4->daddr, sizeof(*dst));
|
// Sometimes we apply a mask to the address
- dst = ip4->saddr@p & e;
+ memcpy(dst, ip4->saddr & e, sizeof(*dst));
|
- dst = ip4->daddr@p & e;
+ memcpy(dst, ip4->daddr & e, sizeof(*dst));
)

@script:python@
p << struct_iphdr.p;
ip4 << struct_iphdr.ip4;
dst << struct_iphdr.dst;
@@

print_msg(ip4, dst, p[0])

@ip4_as_struct_attr@
position p;
struct iphdr *ip4;
type T;
identifier obj, attr, parent_attr;
@@

(
  T obj = {
-   .attr = ip4->saddr@p & ...,
+   .attr = memcpy(dst, ip4->saddr, sizeof(*dst)),
  };
| T obj = {
-   .attr = ip4->daddr@p & ...,
+   .attr = memcpy(dst, ip4->daddr, sizeof(*dst)),
  };
// Recursive struct initialization
| T obj = {
    .parent_attr = {
-     .attr = ip4->daddr@p & ...,
+     .attr = memcpy(dst, ip4->daddr, sizeof(*dst)),
    },
  };
| T obj = {
    .parent_attr = {
-     .attr = ip4->saddr@p & ...,
+     .attr = memcpy(dst, ip4->saddr, sizeof(*dst)),
    },
  };
)

@script:python@
p << ip4_as_struct_attr.p;
ip4 << ip4_as_struct_attr.ip4;
attr << ip4_as_struct_attr.attr;
@@

print_msg(ip4, attr, p[0])

@finalize:python@
@@

if cnt > 0:
  print("""Use the following command to fix the above issues:
docker run --rm --user 1000 --workdir /workspace -v `pwd`:/workspace \\
    -e COCCINELLE_HOME=/usr/local/lib/coccinelle \\
    -it docker.io/cilium/coccicheck:2.4@sha256:24abe3fbb8e829fa41a68a3b76cb4df84fd5a87a7d1d6254c1c1fe5effb5bd1b \\
    spatch --include-headers --very-quiet --in-place bpf/ \\
    --sp-file contrib/coccinelle/address_copy.cocci\n
""")

It catches most occurrences of = ip4->(s|d), with a few exceptions:

One pair of occurrences in bpf/bpf_lxc.c is not reported, because it's located in a macro definition and I've no idea how to tell coccinelle to work with that.

One pair of occurrences in bpf/tests/bpf_ct_tests.c are under the TEST() macro and, again, I don't know how to make it work.

One pair of occurrences fails to be reported in bpf/lib/pcap.h because spatch stumbles on the _Pragma("unroll") and cannot parse the file correctly. One workaround would be to add #define _Pragma(x) in a separate file and pass it with spatch --macro-file ....

The replacement pattern and the messages should likely be updated to ipv4_addr_copy() once we have it.

:wave: I covered the IPv6 aspect in https://github.com/cilium/cilium/pull/30029.
Do we understand in which scenarios this byte-by-byte copy occurs for IPv4?


MRG: Check README.rst

Found with
python setup.py check --restructuredtext

And added to the Travis run, as now it's in make pep.

@massich we can merge as soon as the first Travis run comes back happy

I also removed the instruction to run this command from the Wiki, since now it's done continuously


Ask Kyle to send a lock: explain why it's better than sending him a script

As a developer working with a smart lock, I want to have a physical device on hand so that I can make sure it works and write scripts for it.

[ ] Ask Kyle to send us a lock
[ ] Determine who it's going to (address)

No for now


updated names and made alb logging optional

Removed rclone credentials as they are not needed anymore
updated names so that multiple deployments in same env are possible
Made alb logging optional (user should be able to deploy without too much extra effort; so nice to have but optional)

@edhipat thanks for contributing. Can you please add the issue number in your commit message? So it will be automatically closed.
Thx!

@edhipat thanks for contributing. Can you please add the issue number in your commit message? So it will be automatically closed.
Thx!

There is one last conflict remaining due to the SG naming done by EFS module. An issue has been raised with those maintainers: https://github.com/cloudposse/terraform-aws-efs/issues/61


Increment version

Commits were made to fix issue #56, but a version bump wasn't made. I realized I have the latest "version", but didn't have the fix because I use a caching registry. Could we get it bumped?

You got it<EMAIL_ADDRESS>


Next Steps Template Evaluation

Dynamically generates next steps using text templates, e.g.,
🔭 > If this is first time you are testing the extension,
🔭 > please login to your development store first by visiting
🔭 > https://test-shop.myshopify.com/password

🔭 > To create a checkout and test your extension please visit the following URL:
🔭 > https://example.ngrok.io/extensions/00000000-0000-0000-0000-000000000000

@vividviolet @t6d I've made the two discussed changes and edited the PR comment to reflect the new output. Please re-review.


CursorModeCaptured unable to recover the captured mode after an error (wasm)

Ebitengine Version
2.6.0-alpha-4
Operating System

[ ] Windows
[ ] macOS
[ ] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] Xbox
[X] Web Browsers

Go Version (go version)
1.18.3
What steps will reproduce the problem?
Run https://gist.github.com/Zyko0/d17ce3bb51c4df4ecd2373f472ca65a3
Try left-clicking to enable cursor capture
What is the expected result?
CaptureMode being switched to Visible and Captured when pressing left-click / Escape
What happens instead?
The cursor is simply never captured
Anything else you feel useful to add?
In this example, ebiten.SetCursorMode(ebiten.CursorModeCaptured) is set at the very beginning, which fails because it is too early, so there's no chance of even seeing the cursor mode being captured for the lifetime of the application.
However, removing line 38 and starting with visible cursor (default), allows the captured mode after a left-click.
But then, pressing Escape prevents you from ever get into captured mode ever again.
The following error shows up in the console whenever it can't lock the cursor.
When it happens, there's no way of locking the cursor again in the currently running application.

Tested on Chrome & Edge (OS: Windows).

In this example, ebiten.SetCursorMode(ebiten.CursorModeCaptured) is set at the very beginning, which fails because it is too early, so there's no chance of even seeing the cursor mode being captured for the lifetime of the application.

I don't think there is a solution for this issue unfortunately so far. You have to be careful not to call ebiten.SetCursorMode(ebiten.CursorModeCaptured) before user inputting happens.
I'll take a look more, but this is my current insight.

I don't think there is a solution for this issue unfortunately so far. You have to be careful not to call ebiten.SetCursorMode(ebiten.CursorModeCaptured) before user inputting happens.
I'll take a look more, but this is my current insight.

Yeah, but as I said, removing l.38, just delayed the error
Allows to get cursor captured a single time, but if we leave it (Escape) we can't come back

func main() {
	os.Setenv("EBITEN_GRAPHICS_LIBRARY", "opengl")
	ebiten.SetFullscreen(true)
	ebiten.SetVsyncEnabled(true)
	ebiten.SetCursorMode(ebiten.CursorModeCaptured)

	if err := ebiten.RunGame(&Game{}); err != nil {
		log.Fatal(err)
	}
}

Calling SetCursorMode(ebiten.CursorModeCaptured) before user interaction is the cause.
I might be able to improve the error message.

A further minimized example:
package main

import (
        "log"

        "github.com/hajimehoshi/ebiten/v2"
)

type Game struct{}

func (g *Game) Update() error {
        if ebiten.IsMouseButtonPressed(ebiten.MouseButtonLeft) {
                ebiten.SetCursorMode(ebiten.CursorModeCaptured)
        }
        return nil
}

func (g *Game) Draw(screen *ebiten.Image) {
}

func (g *Game) Layout(outsideWidth, outsideHeight int) (int, int) {
        return 1920, 1080
}

func main() {
        if err := ebiten.RunGame(&Game{}); err != nil {
                log.Fatal(err)
        }
}

So the issue is that the cursor is not captured at the second click after once escape from capturing.


DreymaR's Big Bag of Keyboard Tricks

Project description
Collection of various keyboard layouts
Metadata

homepage URL: https://github.com/DreymaR/BigBagKbdTrixXKB
source URL:https://github.com/DreymaR/BigBagKbdTrixXKB
license: mit
platforms: unix, linux

@fufexan

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/overlay-for-xkeyboard-config-causing-a-lot-of-other-packages-to-recompile-why/14483/4


No Transition From Vortex to Nano

Game very unfinished here, Going to Focus on 'Yes' Route for now.

Hmm, appears to be semi random if you crash in the transition or not.


[iconButton] Added hoverColor prop

[x] PR is linted.
[ ] PR has tests / docs demo.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Only tested manually on local project.
Linted with material-ui's eslint config.
Solves #5449.

Regarding tests, i just tried with copy pasting FlatButton.spec.js > replace FlatButton IconButton and run test:
fails  11 of them
I looked at the 1st failing test:
  it('renders children', () => {
    const wrapper = shallowWithContext(
      <IconButton>{testChildren}</IconButton>
    );
    assert.ok(wrapper.contains(testChildren), 'should contain the children');
  });

... i'm kinda lost with all those advanced childUtils i found in IconButton render() method: "extendChildren". I mean i understand the code is cloning children with nextProps, but i don't understand at all how to test that properly o.O

there were no IconButton.spec.js in the repo.

Oh right, now you know where the 52% test coverage is coming from :grin:

i just tried with copy pasting FlatButton.spec.js

The best approach would most likely to start from scratch.
The enzyme documentation would help a lot.
Try to be as simple as possible. I will most likely add some more behind yours.

I'm not sure, can i use chai-enzyme ?

I'm getting lot of npm err! on my windows:
npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\nodejs\\node.exe" "C:\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "test:unit" "--" "-c" "IconButton"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>test:unit: `cross-env NODE_ENV=test babel-node test/index.js unit "-c" "IconButton"`
npm ERR! Exit status 11
...

i honestly don't understand why cross-env fails to prevent this kind of error....

also the test 'renders children' still fails even when writing from scratch:
  1 passing (39ms)
  1 failing

  1) <IconButton /> renders children:
     AssertionError: should contain the children: expected false to be truthy
      at Function.assert.isOk (node_modules\chai\lib\chai\interface\assert.js:85:31)
      at Context.<anonymous> (src\IconButton/IconButton.spec.js:25:12)


Data Engine OMAS - update functionality

This issue covers the update functionality for the Data Engine OMAS.
The payload for updating processes will be the same as for the creation, Data Engine OMAS will add following checks for each process:
* verify if the process exists based on the provided qualified name, if it does it will update the process properties.
* verify if the portImplementations/portAliases are different from the new ones, based on the qualified names. Create the new ports, update properties for the existing ones and delete the old ones.
* verify if the schemType exists, based on the qualifiedName. If if does, update the proerties and verify the shcemaArributes. Update existing schemaAttributes, create new ones and delele the ond ones.
* verify if a relationship exist before creating it(for all relationships - ProcessPort, PortDelegation, PortSchema, LineageMapping)

@cmgrote , @mandy-chessell can you confirm that this is the desired behavior for Data Engie OMAS on update? I'm not sure about removing old ports and schema types(that are no longer present in the payload).
Can I assume that the payload for a process will always include all the ports & schemaTypes needed? And should the old ones be deleted on update?

In the case of DataStage, I expect to send you a complete payload each time even for the update (so that you can delete anything that is not included in the payload I send in the update that might already exist on your end).
However, I'm not sure whether we should assume this to be the case for all data engines...  As such, it might be worth adding an "update semantic" enumeration to the update payload -- something along these lines:

REPLACE would mean take only what is in the payload sent to the update, and remove anything that already exists that is not included in the payload
APPEND would mean add whatever is in the payload sent to the update to whatever already exists (ie. don't delete anything)

Thanks @cmgrote , I will add the new updateSemantic enum to the payload. It will only be taken into account at update time, and it will be optional. The default behavior if the enum is not present will be REPLACE.
Do we need it need at process level, or is it ok to have something like:
{
"processes": [
{...},
{...},
],
updateSemantic: "REPLACE"
}

Do we need it need at process level, or is it ok to have something like:

I think either way is reasonable -- up to you.

Resolved with Data Engine OMAS - implement update functionality #1808


[MINOR][CORE][PYTHON][SQL][PS] Fix some typos

What changes were proposed in this pull request?
Fix some typos.
Why are the changes needed?
Make the documentation easier to read
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA

@srowen FYI

This started with change ar to an, but now this PR is 100 lines and 18 files.
Do we need a JIRA for this?

Nah if it's just typos I don't see the need

For being a Norwegian, I have some problems with the English here
I can't find "misusage" in any dictionaries, but the word seems to be used in some examples
To prevent misusage, this method
"they were determined to defend themselves from misusage"
or
To prevent misuse, this method
"a misuse of power"
ValueError: Current DataFrame has more then the given limit 1000 rows.
or
ValueError: Current DataFrame has more than the given limit 1000 rows.
Type of parameters can be mixed.
or
The type of parameters can be mixed.

Ha yeah "misusage" is not a word. "misuse" is OK.
"has more than the given limit" is correct (more than , indeed)
Maybe better is something like "Current DataFrame's length exceeds the given limit of 1000 rows"
"The type of parameters can be mixed." is correct as a sentence. But more direct is "Parameter types can be mixed."

What do we want to have?
True: or True :
None: or None :

No space before colon seems a little bit better

Can one of the admins verify this patch?

There are some warning messengers being printed, to warn about data that will be collected to the driver.
(..) which is potentially expensive. In case of multi-index, all data is
transferred to a single node which can easily cause out-of-memory errors.
This method is based on an expensive operation due to the nature
of big data. Internally it needs to generate each row for each value, and
then group twice - it is a huge operation. To prevent misuse,(..)
This leads to moving all data into
a single partition in a single machine and could cause serious
performance degradation. Avoid this method against very large datasets.
Can we change those to something like this?
This moves/collects all data into the driver and therefore causes performance degradation.

The wording isn't super clear, but there I think the degradation is caused by using 1 partition, not the copy to the driver. The problem with copying to the driver is OOM, not slower perf. You can leave it if there is not an obvious typo fix

https://github.com/apache/spark/blob/a2ceff29f9d1c0133fa0c8274fa84c43106e90f0/python/pyspark/pandas/indexing.py#L1665
Normalized is predominantly used in 🇺🇸 American English (en-US) while normalised is predominantly used in 🇬🇧 British English (en-GB).
en-US or en-GB?

en-US by default, so "normalized". -ised vs -ized is a regular difference between the two spelling variations, yes

No space before colon seems a little bit better

Yes I agree with you on that. Should I fix this in this PR or should I take it in a new one afterwards?

Nah not worth changing, I think

Good cleanup, thank you. Merged to master


[Bug]: enable-prefix-caching option: RuntimeError: ptxas failed with error code 1

Your current environment
The output of `python collect_env.py`

PyTorch version: 2.1.2+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: Ubuntu 22.04.3 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.27.6
Libc version: glibc-2.35
Python version: 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-4.15.0-213-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.2.140
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA GeForce RTX 3090
GPU 1: NVIDIA GeForce RTX 3090
GPU 2: NVIDIA GeForce RTX 3090
GPU 3: NVIDIA GeForce RTX 3090
GPU 4: NVIDIA GeForce RTX 3090
GPU 5: NVIDIA GeForce RTX 3090
GPU 6: NVIDIA GeForce RTX 3090
GPU 7: NVIDIA GeForce RTX 3090
Nvidia driver version: 535.86.05
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.9.5
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Address sizes:                   46 bits physical, 48 bits virtual
Byte Order:                      Little Endian
CPU(s):                          104
On-line CPU(s) list:             0-103
Vendor ID:                       GenuineIntel
Model name:                      Intel(R) Xeon(R) Gold 6230R CPU @ 2.10GHz
CPU family:                      6
Model:                           85
Thread(s) per core:              2
Core(s) per socket:              26
Socket(s):                       2
Stepping:                        7
CPU max MHz:                     4000.0000
CPU min MHz:                     1000.0000
BogoMIPS:                        4200.00
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single intel_ppin ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke avx512_vnni md_clear flush_l1d arch_capabilities
Virtualization:                  VT-x
L1d cache:                       1.6 MiB (52 instances)
L1i cache:                       1.6 MiB (52 instances)
L2 cache:                        52 MiB (52 instances)
L3 cache:                        71.5 MiB (2 instances)
NUMA node(s):                    2
NUMA node0 CPU(s):               0-25,52-77
NUMA node1 CPU(s):               26-51,78-103
Vulnerability Itlb multihit:     KVM: Mitigation: Split huge pages
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Mmio stale data:   Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed:          Mitigation; Enhanced IBRS
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Enhanced IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; TSX disabled
Versions of relevant libraries:
[pip3] numpy==1.22.2
[pip3] onnx==1.14.0
[pip3] pytorch-quantization==2.1.2
[pip3] torch==2.1.2
[pip3] torch-tensorrt==0.0.0
[pip3] torchdata==0.7.0a0
[pip3] torchtext==0.16.0a0
[pip3] torchvision==0.16.0a0
[pip3] triton==2.1.0+e621604
[conda] Could not collectROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.4.0
vLLM Build Flags:
CUDA Archs: 5.2 6.0 6.1 7.0 7.2 7.5 8.0 8.6 8.7 9.0+PTX; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0	GPU1	GPU2	GPU3	GPU4	GPU5	GPU6	GPU7	CPU Affinity	NUMA Affinity	GPU NUMA ID
GPU0	 X 	PXB	PXB	PXB	PXB	PIX	PIX	PIX	0-25,52-77	0		N/A
GPU1	PXB	 X 	PIX	PIX	PIX	PXB	PXB	PXB	0-25,52-77	0		N/A
GPU2	PXB	PIX	 X 	PIX	PIX	PXB	PXB	PXB	0-25,52-77	0		N/A
GPU3	PXB	PIX	PIX	 X 	PIX	PXB	PXB	PXB	0-25,52-77	0		N/A
GPU4	PXB	PIX	PIX	PIX	 X 	PXB	PXB	PXB	0-25,52-77	0		N/A
GPU5	PIX	PXB	PXB	PXB	PXB	 X 	PIX	PIX	0-25,52-77	0		N/A
GPU6	PIX	PXB	PXB	PXB	PXB	PIX	 X 	PIX	0-25,52-77	0		N/A
GPU7	PIX	PXB	PXB	PXB	PXB	PIX	PIX	 X 	0-25,52-77	0		N/A
Legend:
X    = Self
SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
PIX  = Connection traversing at most a single PCIe bridge
NV#  = Connection traversing a bonded set of # NVLinks
🐛 Describe the bug
Encountered with abnormal triton compiling error under pressure test when the enable-prefix-caching option was on. @robertgshaw2-neuralmagic Please have a look.
/bin/bash: line 1: /tmp/compile-ptx-log-41c849: No such file or directory
ERROR 04-07 05:33:50 async_llm_engine.py:45] Engine background task failed
ERROR 04-07 05:33:50 async_llm_engine.py:45] Traceback (most recent call last):
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/engine/async_llm_engine.py", line 40, in _raise_exception_on_finish
ERROR 04-07 05:33:50 async_llm_engine.py:45]     task.result()
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/engine/async_llm_engine.py", line 499, in run_engine_loop
ERROR 04-07 05:33:50 async_llm_engine.py:45]     has_requests_in_progress = await asyncio.wait_for(
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/lib/python3.10/asyncio/tasks.py", line 445, in wait_for
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return fut.result()
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/engine/async_llm_engine.py", line 473, in engine_step
ERROR 04-07 05:33:50 async_llm_engine.py:45]     request_outputs = self.engine.step_async()
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/engine/async_llm_engine.py", line 227, in step_async
ERROR 04-07 05:33:50 async_llm_engine.py:45]     output = self.model_executor.execute_model(seq_group_metadata_list=seq_group_metadata_list,
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/executor/gpu_executor.py", line 143, in execute_model
ERROR 04-07 05:33:50 async_llm_engine.py:45]     output = self.driver_worker.execute_model(
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return func(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/worker/worker.py", line 230, in execute_model
ERROR 04-07 05:33:50 async_llm_engine.py:45]     output = self.model_runner.execute_model(seq_group_metadata_list,
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return func(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/worker/model_runner.py", line 663, in execute_model
ERROR 04-07 05:33:50 async_llm_engine.py:45]     hidden_states = model_executable(**execute_model_kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return self._call_impl(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return forward_call(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/model_executor/models/llama.py", line 394, in forward
ERROR 04-07 05:33:50 async_llm_engine.py:45]     hidden_states = self.model(input_ids, positions, kv_caches,
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return self._call_impl(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return forward_call(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/model_executor/models/llama.py", line 299, in forward
ERROR 04-07 05:33:50 async_llm_engine.py:45]     hidden_states, residual = layer(
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return self._call_impl(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return forward_call(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/model_executor/models/llama.py", line 241, in forward
ERROR 04-07 05:33:50 async_llm_engine.py:45]     hidden_states = self.self_attn(
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return self._call_impl(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return forward_call(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/model_executor/models/llama.py", line 184, in forward
ERROR 04-07 05:33:50 async_llm_engine.py:45]     attn_output = self.attn(q, k, v, kv_cache, attn_metadata)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return self._call_impl(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return forward_call(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/attention/layer.py", line 46, in forward
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return self.impl.forward(query, key, value, kv_cache, attn_metadata)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/attention/backends/xformers.py", line 262, in forward
ERROR 04-07 05:33:50 async_llm_engine.py:45]     output = PagedAttention.forward_prefix(
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/attention/ops/paged_attn.py", line 178, in forward_prefix
ERROR 04-07 05:33:50 async_llm_engine.py:45]     context_attention_fwd(
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return func(*args, **kwargs)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/home/kwx/vllm_newest/vllm/attention/ops/prefix_prefill.py", line 699, in context_attention_fwd
ERROR 04-07 05:33:50 async_llm_engine.py:45]     _fwd_kernel[grid](
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "", line 63, in _fwd_kernel
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/triton/compiler/compiler.py", line 476, in compile
ERROR 04-07 05:33:50 async_llm_engine.py:45]     next_module = compile_kernel(module)
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/triton/compiler/compiler.py", line 351, in
ERROR 04-07 05:33:50 async_llm_engine.py:45]     lambda src: ptx_to_cubin(src, arch))
ERROR 04-07 05:33:50 async_llm_engine.py:45]   File "/usr/local/lib/python3.10/dist-packages/triton/compiler/compiler.py", line 150, in ptx_to_cubin
ERROR 04-07 05:33:50 async_llm_engine.py:45]     return compile_ptx_to_cubin(ptx, ptxas, arch)
ERROR 04-07 05:33:50 async_llm_engine.py:45] RuntimeError: ptxas failed with error code 1:
ERROR 04-07 05:33:50 async_llm_engine.py:45]
ERROR:asyncio:Exception in callback functools.partial(<function _raise_exception_on_finish at 0x7f1179284040>, error_callback=<bound method AsyncLLMEngine._error_callback of <vllm.engine.async_llm_engine.AsyncLLMEngine object at 0x7f116c81a680>>)
handle: <Handle functools.partial(<function _raise_exception_on_finish at 0x7f1179284040>, error_callback=<bound method AsyncLLMEngine._error_callback of <vllm.engine.async_llm_engine.AsyncLLMEngine object at 0x7f116c81a680>>)>
Traceback (most recent call last):
File "/home/kwx/vllm_newest/vllm/engine/async_llm_engine.py", line 40, in _raise_exception_on_finish
task.result()
File "/home/kwx/vllm_newest/vllm/engine/async_llm_engine.py", line 499, in run_engine_loop
has_requests_in_progress = await asyncio.wait_for(
File "/usr/lib/python3.10/asyncio/tasks.py", line 445, in wait_for
return fut.result()
File "/home/kwx/vllm_newest/vllm/engine/async_llm_engine.py", line 473, in engine_step
request_outputs = self.engine.step_async()
File "/home/kwx/vllm_newest/vllm/engine/async_llm_engine.py", line 227, in step_async
output = self.model_executor.execute_model(seq_group_metadata_list=seq_group_metadata_list,
File "/home/kwx/vllm_newest/vllm/executor/gpu_executor.py", line 143, in execute_model
output = self.driver_worker.execute_model(
File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/home/kwx/vllm_newest/vllm/worker/worker.py", line 230, in execute_model
output = self.model_runner.execute_model(seq_group_metadata_list,
File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/home/kwx/vllm_newest/vllm/worker/model_runner.py", line 663, in execute_model
hidden_states = model_executable(**execute_model_kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/home/kwx/vllm_newest/vllm/model_executor/models/llama.py", line 394, in forward
hidden_states = self.model(input_ids, positions, kv_caches,
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/home/kwx/vllm_newest/vllm/model_executor/models/llama.py", line 299, in forward
hidden_states, residual = layer(
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/home/kwx/vllm_newest/vllm/model_executor/models/llama.py", line 241, in forward
hidden_states = self.self_attn(
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/home/kwx/vllm_newest/vllm/model_executor/models/llama.py", line 184, in forward
attn_output = self.attn(q, k, v, kv_cache, attn_metadata)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/home/kwx/vllm_newest/vllm/attention/layer.py", line 46, in forward
return self.impl.forward(query, key, value, kv_cache, attn_metadata)
File "/home/kwx/vllm_newest/vllm/attention/backends/xformers.py", line 262, in forward
output = PagedAttention.forward_prefix(
File "/home/kwx/vllm_newest/vllm/attention/ops/paged_attn.py", line 178, in forward_prefix
context_attention_fwd(
File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/home/kwx/vllm_newest/vllm/attention/ops/prefix_prefill.py", line 699, in context_attention_fwd
_fwd_kernel[grid](
File "", line 63, in _fwd_kernel
File "/usr/local/lib/python3.10/dist-packages/triton/compiler/compiler.py", line 476, in compile
next_module = compile_kernel(module)
File "/usr/local/lib/python3.10/dist-packages/triton/compiler/compiler.py", line 351, in
lambda src: ptx_to_cubin(src, arch))
File "/usr/local/lib/python3.10/dist-packages/triton/compiler/compiler.py", line 150, in ptx_to_cubin
return compile_ptx_to_cubin(ptx, ptxas, arch)
RuntimeError: ptxas failed with error code 1:

hi, have you solved this problem?

hi, have you solved this problem?

mkdir /tmp solves

Thanks for reply! but I have the /tmp folder ,and meet the same problem


Do not merge yet: PLANNER-560 stopgap fix random failure of testGetBestSolution()

We'll also need @sutaakar 's +1 on this before merging.

@ge0ffrey Seems that I found out why tests fails.
It is good old marshalling issue.
When best solution isn't yet initialized then Kie server returns empty score, for example in JAXB it is "". But it is unmarshalled into HardSoftScore with values -2147483648hard/-2147483648soft.

looks like it still suffers from the same instability issue, shall this be kept open?

Let's close it for now (I will close and the other one). I need to fix the initialized score problem first, I hope to have time for that in 3 weeks.


nixos/activation: expose activation scripts

Motivation for this change
Currently, you can't access the activation scripts once they've been set (try eval --json config.system.activationScripts). This makes them accessible, in a non-breaking way.

Any chance at a review or comment? :smile: @worldofpeace

@MatthewCroughan could you explain (to me or to anyone not familiar with activation Nix code, how does this change help? What do you mean by "access the activation scripts once they've been set"?

This seems to allow overriding the activation script.


go.mod doesn't exist

The issue is located in: security-secretstore-setup
When I used the Dockerfile located in edgex-go/cmd/security-secretstore-setup to build image, it reports "go.mod does not exist".
Should I just copy the edgex-go/go.mod to edgex-go/cmd/security-secretstore-setup?
Thanks a lot！

@Castle1984 May I know how do you build the image?  Are you using the Makefile?  Please provide the recreate steps.

@Castle1984 May I know how do you build the image? Are you using the Makefile? Please provide the recreate steps.

I wanna use the Dockerfile to build image, and I use the command "sudo docker build -t secret-setup:v1 ." in the path "edgex-go/cmd/security-secretstore-setup".
All I want to do is that I hope to use the image secret-setup generated by the Dockerfile to  test the exe security-secretstore-setup which is generated by the Makefile. Is that right? I'm not sure.
Once I use docker-compose.yml to build the image to test the secretstore(using command "docker-compose up"), and it works well. But I think the image used in this testdata  is pulled from the website, and it dosen't use the the exe security-secretstore-setup generated by myself.
Or could you give me another way to test the the exe security-secretstore-setup which is generated by the Makefile? That will help a lot!

@Castle1984 You need to build from the root of project, see https://github.com/edgexfoundry/edgex-go#installation-and-execution
cd edgex-go
make build

@Castle1984 You need to build from the root of project, see https://github.com/edgexfoundry/edgex-go#installation-and-execution
cd edgex-go
make build

Sorry, I think you may misunderstand what I mean. I did use the command "cd edgex-go&make build", and there will be a executable file 'security-secretstore-setup' in the path edgex-go/cmd/security-secretstore-setup. And now my question is how to test this exe 'security-secretstore-setup' , so I tried to use the Dockerfile in the path where there also exits the exe 'security-secretstore-setup'. But when using the command "cd edgex-go/cmd/security-secretstore-setup&sudo docker build -t secret-setup:v1 .", the error message is "go.mod does not exist".

@Castle1984

But when using the command "cd edgex-go/cmd/security-secretstore-setup&sudo docker build -t secret-setup:v1 .", the error message is "go.mod does not exist".

The go.mod is located at the root of project, you can see the correct command at the Makefile:
docker_security_secretstore_setup:
		docker build \
	    --build-arg http_proxy \
	    --build-arg https_proxy \
		-f cmd/security-secretstore-setup/Dockerfile \
		--label "git_sha=$(GIT_SHA)" \
		-t edgexfoundry/docker-security-secretstore-setup-go:$(GIT_SHA) \
		-t edgexfoundry/docker-security-secretstore-setup-go:$(DOCKER_TAG) \
		.

https://github.com/edgexfoundry/edgex-go/blob/master/Makefile#L179
So you should not build the docker image at the path edgex-go/cmd/security-secretstore-setup.

Thanks a lot. I 'm causing all you some troubles, for I'm not familiar with this project.
The answer does helps a lot.

Thx a lot. I 'm causing all you some troubles, for I'm not familiar with this project.
The answer does help a lot.


can't find repo when building for Android

Not sure if this is a bug, but for me building on Android failed because it could not find the datadog repo. Maybe we could add something to the readme, to add this to repositories in the root build.gradle for Android:
allprojects {
    repositories {
        ...
        maven { url "https://dl.bintray.com/datadog/datadog-maven" }
    }
}

Hello @mutablestudio! We are moving away from Bintray to Maven Central and our upcoming releases are already there (ex: https://search.maven.org/artifact/com.datadoghq/dd-sdk-android). So next release of dd-sdk-reactnative won't have a dependency on Bintray.


--bench-on=dirty

This one feels like it should work, but I get an error that "dirty" is not a valid revision.

Yeah this would be good as an alias. For right now the solution is to use the --script flag explicitly but would be good to have this as a patch

Yes, I just tried this package out yesterday and I agree those would be nice! I was surprised by how many options didn't have defaults.

These convenience features would be much appreciated!


CORELOG-179 try to fix http EOF error

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)

could you create and link an issue to this PR that describes the thing you're trying to fix.
and also name the branches according to the guidelines we introduced a few days ago.
it would also be nice to change the default PR description and informative about what we're working on

Don't leak internal tasks like CORELOG please.
Let's create issue and add PR to it.

[ ] Update version in top of Makefile

Closing this one.
Looks like the problem receiver/network related - connection got broken for some reason.


High level client API overview

Here we create some models and types to define how the overall API would look like going forward. We simply establish how the api is supposed to be used by consumer.
README now show examples of client usage.

@StefMa / @chb-ioki

To solve https://github.com/ioki-mobility/go-outline/issues/5 we also need a "publish document" function.

@StefMa I added https://github.com/ioki-mobility/go-outline/discussions/8 to answer some questions here. Also this PR is not meant to add any functionality it just wants to establish API usage pattern that is it. There are of course lot of this missing :) and nothing is 'polished'

@chb-ioki please approve if all looks good to you, thanks!

@rsjethani I guess we are good to go now 🙃
Feel free to merge. (Same applies for the other PR #9)


Select torrent option for TV Show Seasons it's not available

Expected Behavior
When opening the Context menu over a TV Show Season there should be an option to search and chose one of the found torrents.
Current Behavior
Currently only the AutoPlay option is available, which automatically selects the first torrent from the list.
Possible Solution
Treat it as a regular episode where you have the two options.
Steps to Reproduce (for bugs)

Browse through the menus up to a TV Show Season.
Open the context menu pressing "c".
Only available option is to AutoPlay.

Context
It'll be better to have the option to select the desired torrent as not always the first one is the best choice.
Your Environment
Android TV 8.0.0
KODI 17.6
Elementum 0.0.51
Burst 0.0.18

https://github.com/elgatito/elementum/issues/5#issuecomment-387304602

I have added another option to season context menu in v0.0.52.
Now there are both options.

Thanks much!


ImportError: cannot import name 'CLOSED' from 'websockets.connection'

I found a problem with version v11.0 (launched yesterday). I don't know how to solve this problem from current version, but I downgraded to v10.4 to keep using the lib.
Related post: https://stackoverflow.com/questions/75913380/importerror-cannot-import-name-closed-from-websockets-connection

I submitted changes to Sanic in November to prevent this issue:
https://github.com/sanic-org/sanic/commit/4c14910d5bbbbb6e12c1860572ecdc5c198f9b7e
Sanic has had two releases since then. Can you check that you're using the latest version of Sanic, please?
If you're sticking to an old version of Sanic, you have to stick to an old version of websockets. Indeed, Sanic used to rely on implementation details of websockets, before I submitted changes to rely on the public API.

Duplicate of https://github.com/sanic-org/sanic/issues/2733

I submitted changes to Sanic in November to prevent this issue: sanic-org/sanic@4c14910
Sanic has had two releases since then. Can you check that you're using the latest version of Sanic, please?
If you're sticking to an old version of Sanic, you have to stick to an old version of websockets. Indeed, Sanic used to rely on implementation details of websockets, before I submitted changes to rely on the public API.

It's true. My Sanic isn't the latest version. Thank you very much @aaugustin!


Icon of MaterialSimpleListItem disappear when scrolling.

I made a dialog with a x0 items based on MaterialSimpleListItem.
Some item hold a icon, some not. When I scrolled the list, icons which are hidden because of the scrolling wont re appeared when scrolled back. The icon kept on the screen are ok.
Additionally the first item that should hold an icon doesn't. Every item that should hold icon + are hidden, do not!
Item instantiation is done the same way for every item:
 adapter.add(
    new MaterialSimpleListItem.Builder(context)
    .content(topic.getMainTripName())
    .icon(context.getResources().getDrawable(R.drawable.medal_selected))
    .build());

Well, using context.getResources() here is unnecessary. Just use .icon(R.drawable.medal_selected).
But I'll look into this.

I'm unable to reproduce any issues related to this.


Bump version to v7.2.0

LGTM. Jenkins, test this please.

Jenkins CI test (for commit 44f63faf5c0482e750dc7115628116fdebaf5a5a, target branch v7) succeeded!


Autocomplete appears when typing type argument names

Type the following (and wait for intellisense to appear):
type Foo<'S

You'll notice that intellisense is suggesting names to complete with - it shouldn't be suggesting anything at this point.

I think this has been the case this @vasily-kirichenko's #2644 PR was merged

Check parse AST for that code. If there is no meaningful one, we cannot do anything with it (we could use the lexer though, but it's too hacky).

This has been significantly interfering with my ability to code this week, I'm using generics everywhere and this is making it even more painful than it needs to be.
@vasily-kirichenko can you point me in the right direction for the code that needs to be changed here?

@saul You can make https://github.com/Microsoft/visualfsharp/blob/master/src/fsharp/vs/ServiceUntypedParse.fs#L930 return CompletionContext.Invalid if we are at type parameters or add a new case into it and handle it in https://github.com/Microsoft/visualfsharp/blob/master/src/fsharp/vs/service.fs#L783

But I suspect there's no AST in code like type My<|


Add support for alpine linux boxes

I've added an alpine compatible jqbinary and a check to the run script that determines if the alpine based binary should be user.
I've pushed the code in this PR as a new step called 'github-upload-asset-forked' to test with. But cannot seem to pull it in my builds. I ran out of ideas on how to test this.
Fixes #4

Looks like the latest version of jq works fine with Alpine. So will create a new version with just 1 binary

@hatchan do you have an ETA for a new version that works on Alpine?

I'll release it first thing tomorrow

@hatchan did you manage to make a new release? My builds still break because of jq

@miguelaferreira Yes I have released a new version

Thanks a bunch, my builds are running again.


Map zooming and panning

I really enjoy playing as artillery in MTC and using your calculator for the funsies, but I sometimes struggle to properly set up the position markers (especially the one responsible for my vehicle's position) and in turn I have to resort to using browser's zoom functionality which is quite cumbersome/clunky. So I decided to enhance the map component by wrapping it in a container I made that supports semi-customizable zooming and panning features.
On a side note, I tried adding controls info required to pan, zoom and reset the map alongside the existing controls tips but to no avail because the entire UI's container would fill the whole window. And honestly I don't know the reason behind this.

Instead of:

Another issue I've encountered is related to a border; to be exact, using it right here on the Box component:
https://github.com/ari-party/mtc-artillery/blob/d54cb285a753cfc112e4dadef21f43ab9022eccc/src/components/molecules/canvas/Container.tsx#L32-L36
Whenever I tried setting a border on it, it would result in a "Maximum update depth exceeded" error. I tried fixing it but in the end I didn't manage do it. What I did understand though, is that it's definitely affected by the useEffect hook.
(This is my first ever open-source contribution and I'm aware that I may have made some mistakes, particularly because I've never worked with Next.js and have limited experience with barebones React. So please point out any issues, and I'll try my best to address them.)

I'm unable to control the map with scroll wheel?
Also with the container filling up the screen, it's not constrained, it can be any size it wants as long it's on a 1:1 aspect ratio.

Pressing and holding the middle mouse button in the container, then moving the mouse out of the container and releasing it, makes it think middle mouse button is still being held.

I completely overlooked that 😅, my bad. I'll get to fixing this ASAP.

I've fixed the issue, but now it got me thinking; should I make it so the map still can be moved when the mouse is outside of the container? Although at first glance it seems like I might have to play with a couple of more document mouse event listeners in order to do that, since I'm pretty sure it's impossible to detect middle click with pointer events...

Are you able to make it use LMB for dragging instead? Just like in game?

I am, however I'm not sure if I'll be to do it today.

Alright, I got it working, hope everything's good.

Currently looking into react-zoom-pan-pinch for possibly better support.


Transform JSX

Rename:

src/QiitaLogo.js -> src/QiitaLogo.jsx
src/SlideViewer.js -> src/SlideViewer.jsx
src/Tooltip.js -> src/Tooltip.jsx

then build following files and add them to npm package:

src/QiitaLogo.js
src/SlideViewer.js
src/Tooltip.js

to be able to import this package as ES module. (JSX is not ECMAScript)

let's remove rollup.config.js

Because hyperapp/hyperapp has zero dependencies, it can. On the other hand, this package depends on some npm packages so it needs some rollup plugins such as rollup-plugin-commonjs and rollup-plugin-node-resolve to bundle JavaScript and we cannot use these plugins via rollup CLI command so it can't.
I'm going to merge this PR and release v0.1.1


Support for multi-level includes

If a master/child view system is used (like in ASP.NET MVC) the views might look a bit like:
Child view
{{<Content}}
Some stuff here...
{{/Content}}
{{>Master}}
Master
Some content
{{>Content}}
Some more content
This works fine, but sometimes you might want a 3-level (or n-level) include hierarchy, with the Master template itself using a master, say "Base".  In this situation the current implementation doesn't find the TemplateDefinition sections properly, so I added a fix to support this.

Hey There,
I've just taken a look at this. I know it's been a long time since you wrote it but I can't seem to get it to work. I pulled this into a separate branch and the tests you wrote for it fail also this line stops the compilation as push only takes one argument.
If you'd still like it merged would you mind taking a look at these errors. I'd understand if you'd rather not as it has been a long time.
Thanks,

It passes the tests for the 3 year old version of the code I wrote it for (I just checked it out).  The Push() function seems to have been split into Push() and Enter() which is why it won't build.  Your master branch won't build so I can't rebase.

Sorry for the delay in replying. I'll have a look at the master branch not building when pulled fresh and get back to you. Thanks for replying after such a long delay.

After looking at the code again and with your note that the code was changed to use Enter() and Exit() I updated the merge and both tests path as expected. I'll push this out with the next release tomorrow.
Thanks again for the feature and apologies for the delay.

No problem at all, happy to contribute!


Access token

Hello,
After redirecting from google sign in, I only get id token and its data, I wonder how could I get access token so I can use it for firebase auth?
   final idToken = await GoogleSignWeb.instance!.token;

  final credential = GoogleAuthProvider.credential(
    accessToken:access_token,
    idToken: idToken,
  );

accessToken is not required

you should use responseType: "id_token". See the example.

@kunkaamd Thanks a lot I saw it in the readme
      GoogleSignWeb.init(
        ///id_token if you only want get user_id
        ///code if you need basic profile, access_token
        responseType: "code",
        scopes: ['email', 'profile'],
      );


feat: allow subscription to store more props

Fixes #75
cc @seriousme
BREAKING CHANGE: Drop support for nodejs 12

@seriousme Good to merge?

LGTM


ftp://ftp.rsa.com/pub/pkcs/ascii/layman.asc not accessible anymore ?

The README mentions ftp://ftp.rsa.com/pub/pkcs/ascii/layman.asc
The link seems to be broken.
Please could you indicate another link ?
Thanks.

Sat 5 Mar 2022 10:20:22 GMT
Hi @jlguenego (and anyone else looking for this):
The full document name is A Layman's Guide to a Subset of ASN.1, BER, and DER.
It is (currently) available at https://opensource.apple.com/source/Heimdal/Heimdal-520/doc/layman.asc.auto.html.


Resume last session

Feature request:
Resume from last position in the last opened chapter

I decided to not implement this as position on last opened chapter will have a lot of edge cases which seems to be more trouble than it's worth.
In my opinion, a rather simple bookmark (#14) is enough.


Bug when sharing a note

I use the code styler plugin to give titles and style my codeblocks with this syntax:
```python title:name
code
```

Notes containing this syntax cannot be shared. The pop-up at the start of the sharing process appears, but then nothing happens and the link isn’t updated.

Please upload a zip of a demo vault which exhibits this issue, and I will sort it out.

I am very sorry, In the end, I couldn't figure out where it was coming from. I finally failed to recreate the bug with a test vault, but I still haven't managed to share my note on my chest.
I use a lot of snippets and plugins, so I'm going to try disabling them one by one to see where it might be coming from.

Make sure to run the BRAT command to update your Share Note plugin, just in case. You should be on version 0.3.14.

Okay, this is really strange. Even after deactivating all css and plugins, and uninstalling-reinstalling obsidian share with brat, the note still doesn't share in my main vault. The other notes are well shared, and this note is well shared in a test box.
Just in case, here is my note:
Test.md

Close and reopen Obsidian after updating the plugin? Only other thing I can think of....

I've tried that too, but still no change.
However, I've just tried to remove this line, and without this, the note is finally shared in my main vault too.:
#### 1.7.2) Avec la bibliothèque WTF

So I still haven't found the real reason, but I'll be able to share my note in the end.

However, I now have a strange behavior. When reinstalling obsidian share, the css snippets I use are no longer taken into account for note sharing, even though they've been reactivated.

Please do the troubleshooting steps here first to see if that resolves your problem:
https://github.com/alangrainger/obsidian-share#troubleshooting

No, I've tried several times, but the snippets are still not taken into account.

I'll close this for now - if you want to upload a demo vault which exhibits the issue then I can look into it for you.

It's really strange but I'd given up for the moment. I tried again after the last update and miraculously, everything was working properly again. So I don't know what happened, but everything's fine.


Error when setting background to transparent

Cool theme! Really like the colors
However, I really want to have my background transparent. But when I set it using vim.g.tokyonight_transparent = true, I get this error:
E5108: Error executing lua ...ack/packer/start/tokyonight.nvim/lua/tokyonight/util.lua:13: hex_to_rgb: invalid hex_str: none
after which the bg is transparent, but the colorscheme either doesn't load at all or the colors are all over the place.
Any suggestions how to fix?

Should work now. Can you check again?

Should work now. Can you check again?

It does! Thanks a lot 👍


Failed to install node-sass in Azure DevOps container with Ubuntu 20.04

NPM version (npm -v):8.1.2

Node version (node -v):16.13.2

Node Process (node -p process.versions):

{
node: '16.13.2',
v8: '<IP_ADDRESS>-node.14',
uv: '1.42.0',
zlib: '1.2.11',
brotli: '1.0.9',
ares: '1.18.1',
modules: '93',
nghttp2: '1.45.1',
napi: '8',
llhttp: '6.0.4',
openssl: '1.1.1l+quic',
cldr: '39.0',
icu: '69.1',
tz: '2021a',
unicode: '13.0',
ngtcp2: '0.1.0-DEV',
nghttp3: '0.1.0-DEV'
}

Node Platform (node -p process.platform):linux

Node architecture (node -p process.arch):x64

node-sass version (node -p "require('node-sass').info"):

npm node-sass versions (npm ls node-sass):

Error shows as below:
[4/4] Building fresh packages...
error /home/vsts/work/1/s/node_modules/gulp-sass/node_modules/node-sass: Command failed.
Exit code: 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/vsts/work/1/s/node_modules/gulp-sass/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
gyp ERR! System Linux 5.11.0-1025-azure
gyp ERR! command "/usr/local/bin/node" "/home/vsts/work/1/s/node_modules/gulp-sass/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd /home/vsts/work/1/s/node_modules/gulp-sass/node_modules/node-sass
gyp ERR! node -v v16.13.2
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
Build failed with error code: 1

https://github.com/sass/node-sass#node-version-support-policy
That old node-gyp means you must be running an older version that we don't support running on Node 16

https://github.com/sass/node-sass#node-version-support-policy That old node-gyp means you must be running an older version that we don't support running on Node 16

so how can we relsove this issue, there are some internal packages in the project which is using older versions of gyp.


Add 'scenario_start' event

If used with scenario_success and scenario_failure, this will allow to measure a runtime of a scenario.

Coverage remained the same at 100.0% when pulling ac551a06390fcedb98ec536033c9498f96cf77a4 on dmand:feat/event-scenario-start into bbd33a9df6b6ed9372d3033a4c028ea75806e654 on loads:master.

Coverage remained the same at 100.0% when pulling ac551a06390fcedb98ec536033c9498f96cf77a4 on dmand:feat/event-scenario-start into bbd33a9df6b6ed9372d3033a4c028ea75806e654 on loads:master.


Race in Client::maintain_socket() drops data packets

If both a ServerConnectResponse and data packets are pending when Client::maintain_socket() is called, data packets received after the ServerConnectResponse are dropped. This results in a significant chance of dropping the first few data packets after a new connection is established.
Also, just more in general, if a data packet is received before the ServerConnectResponse due to jitter, it will be dropped.

Dustin thank you so much for getting in the weeds here! Glad to know people are still using this. This issue is def on the todo list for next release 👍

Unfortunately, to fix this I would require quite an extensive refactor to my current implementation of giving the responsibility of handling entire packets to either a pre-connection or post-connection handler. As is, Naia is designed to be able to tolerate dropped packets, and so will recover soon after connection. Perhaps next release.. Thank you for looking into this though Dustin!


Emmet problem with intellisense list with speed write

With speed write it very bad when i press tab it set first item of intellisense list.
We can use intellisense when user select item with arrows keys and Emmet without select any item.
The main problem is vscode select first item by default.

This is a duplicate of #20531.
Pls see this comment for a work around https://github.com/Microsoft/vscode/issues/20531#issuecomment-281091406


Sidebase Youtube Tutorial

Describe the feature
When I was searching for good learning methods & tutorials for vue/nuxt it was comparably more difficult than other frameworks' tutorials, although these days there are more and more good tutorials, it is still difficult to find up-to-date tutorials.
So, I suggest making Nuxt tutorials with Sidebase (which has up-to-date nuxt & related libraries)
This could help not only people who just start to use Sidebase scaffold but also people who start to learn Nuxt/Vue but don't know where to start.
Initial Tutorial Idea

Kick-off nuxt project
How to use API in Nuxt
How to use Nuxt3 built-in composables

Additional information
No response

Love the idea!
Let's expand on https://www.youtube.com/watch?v=Wu9LQ7L5BcU&feature=emb_title then with this (:

Closing this now, let's re-open this here or elsewhere once we want to push it further / more requests for this come in.
Thank you so much for the suggestion though @DaeunYoon (:


FLEX-4196 ~ Fixes device model deletion.

limit Model ID to 255 characters in web service, which is equal to the
database column
limit Model Description to 255 characters in web service, which is
equal to the database column

All is well.


[Request] Please make it available for web too.

We need web support!
🥺

We need web support. Please.
🥺

Please check the discussion #96


TFLint doesn't include the azure plugin

Describe the bug
TFLint has a plugin that makes it more specific for Azure resources but we don't include it.

We need to include a .tflint.hcl file with a reference to the plugin, but currently there seem to be a problem with how superlinter configures tflint. We need to wait for a version past 4.9.2 and check again.

Closed with https://github.com/microsoft/AzureTRE/pull/1919


Inserts ^] character instead of whitespace when used with ultimate-autopair.nvim

[x] Did you check Readme and existing issues?

Describe the bug
As was discussed in https://github.com/altermo/ultimate-autopair.nvim/issues/63 the multicursors.nvim plugin appears to miss the support for i_CTRL-] (:h i_CTRL-]), therefore when paired with the ultimate-autopair.nvim plugin inserting a space in multicursor>insert mode creates a ^] character in all but the current selections.
To Reproduce
You need to have docker, docker compose, just.

download ultimate-autopair.zip
unzip ultimate-autopair.zip
cd ultimate-autopair
just
press ia
see error

If instead just wo is run (step 3), then the ultimate-autopair.nvim plugin won't be executed, and a normal whitespace will be inserted in step 4.
Expected behavior
The whitespace character should be inserted in all the selections in the multicursor>insert mode.
Screenshots
just:

just wo:

Nvim version: 0.9.4
Multicursor version: 0.10.2
Additional context
If the solution seems too hard or some guidance is needed, please ask @altermo, the owner of the ultimate-autopair.nvim plugin. Together, we probably can resolve this much easier and quicker.

Abbreviation isn't  supported and probably never will be because how nvim works.
PS:  Please stick to the issue template for reprdocution in the future.

Nothing's broken, it just doesn't have any API for it.

Ooh, lack of API is the problem, okay. This means that vim.cmd[[ ]] isn't an option either?

If you mean an API to get abbreviation, Nvim now has the maplist() function.
Also see https://github.com/neovim/neovim/issues/26867

If you mean an API to get abbreviation, Nvim now has the maplist() function.

Thanks for the tip :+1: .


'Publish Later' Option for Updates

User story
Being able to draft posts and schedule them to be posted at a later date could be a helpful tool.
Best solution for this problem
Something like this:

Would love to work on this, can i pick this up?

@achmurali This issue lacks some design and technical specifications. Unless you feel really confident about it, I would recommend familiarizing with the codebase on simpler issues first.

+1 (and adding some keywords to this issue to make it easier to find): embargo schedule delay


Add autorollback functionality for database

if adding autorollback functionality is impossible, please uncomment  commit() function in transaction class.
class Transaction : public DbClient
{
public:
virtual void rollback() = 0;
// virtual void commit() = 0;
virtual void setCommitCallback(
const std::function<void(bool)> &commit Callback) = 0;
void closeAll() override
{
}
};

A transaction will rollback automatically on any query failure.

Thank you for your answer. In drogon when the Transaction object is destructed, the commit statement is automatically executed to end the transaction. But i need the opposite. I meant this.

A transaction will rollback automatically on any query failure.

We could add a setAutoCommit(bool) method to make the Transaction commit or rollback in destructor. In the meantime we should uncomment the commit() method to let user commit manually.
There is also an easy solution without any changes on the library.
class TransactionAutoRollback
{
  public:
    TransactionAutoRollback(std::shared_ptr<Transaction> &&trans)
        : trans_(std::move(trans))
    {
    }
    ~TransactionAutoRollback()
    {
        if (trans_)
            trans_->rollback();
    }
    const std::shared_ptr<Transaction> &get()
    {
        return trans_;
    }
    void commit(const std::function<void(bool)> &commitCallback)
    {
        if (trans_)
        {
            if (commitCallback)
            {
                trans_->setCommitCallback(commitCallback);
            }
            trans_.reset();
        }
    }

  private:
    std::shared_ptr<Transaction> trans_;
};

@an-tao Can we add setAutoCommit(bool) funtion for TransactionImpl class? I really need it.


emerald reward rarity must be configurable

This is a great plugin; however, i deeply believe that emerald reward rarity must be configurable.
They are rewarded too easily.  for example i barely start to kill much and i have already have 23 emeralds.  I would like to have this completely configurable, maybe a setting to set chance in percentage that an emerald is rewarded if at all.
Furthermore, i feel it should be chance per mob. example, pigs=0.0000001 chance; zombie=0.00001 chance; squid=0.0 chance; enderman=0.10 chance , and so on allowing us to configure every mob by our personal preference (with a default= if a mob is unspecified).
Please not: I am completely assuming my server's emerald rewards are offered via this plugin.  I do have other plugins that may be the rewarder -- i am unsure.
Thank you!

Gringotts does not alter item drops in any way, it only supplies an economy interface for whatever items you choose to make your server's currency. Please check your other plugins for one that awards money or items on kill.

Thank you, it was MobHunting in conjunction with Gringotts for anyone interested.  My gringotts was set for 0 decimal places, so MobHunting's reward was at minimum 1.0 money items which was Emeralds as per Gringott's default.


[Feature]: MacOS as server support

Description
I have some servers running on MacOS ; they also already run Docker perfectly fine.
Also, it is fairly easy to give a user root access on MacOS.
I feel there is no major blocker for that task, but I would love to know more about it if there is some.
I would happily add 50$ of bounty if someone confirms there is no major blocker for that task.
Minimal Reproduction (if possible, example repository)
I can provide access to a MacOS server if needed; currently I get this screen when trying to validate a server:

Note I can properly add and SSH login to the server, but I cannot setup the Coolify env.
Exception or Error
No response
Version
cloud (beta.306)

/etc/os-release doesn't exist on macos hence the error (no such file or directory)
looks like it's called both in : https://github.com/coollabsio/coolify/blob/e9158b7305bb9253fe75a0e76ef34af62f75199b/app/Jobs/ServerStatusJob.php#L73
and : https://github.com/coollabsio/coolify/blob/e9158b7305bb9253fe75a0e76ef34af62f75199b/app/Models/Server.php#L873
A mac os alternative would be :
$ sysctl kern.version
$ sysctl kern.ostype
$ sysctl kern.osrelease
$ sysctl kern.osrevision
or $ sw_vers
though only changing those wouldn't work, a lot of stuff relies on this file, e.g. the installer script (https://github.com/coollabsio/coolify/blob/e9158b7305bb9253fe75a0e76ef34af62f75199b/scripts/install.sh#L13)
and it's not even referenced in the supported os list : https://github.com/coollabsio/coolify/blob/e9158b7305bb9253fe75a0e76ef34af62f75199b/bootstrap/helpers/constants.php#L39
that said, I'm not sure this is the only thing you'd need to fix for proper macos support, a bunch of other stuff might break

From what I've understood of Coolify "server" setup ; it's mainly a bunch of Docker containers, so I guess that would be achievable as Docker runs perfectly fine on MacOS?

Yeah, I never used the cloud version nor tried to deploy coolify on my mac, so I can't really tell, but from the error message and the references in the source that's all I can tell. hope will come handy if you take a try at it :)

I actually went on my macbook to test this out, first of all I was able to run the docker compose and have coolify run here, as I don't have a macos server I can't try the Validate & Install thing, but looking at the code, here is the general flow :
When you click on the button, it calls the validateServer function: https://github.com/coollabsio/coolify/blob/e9158b7305bb9253fe75a0e76ef34af62f75199b/resources/views/livewire/server/form.blade.php#L39
which is basically dispatching an init message: https://github.com/coollabsio/coolify/blob/e9158b7305bb9253fe75a0e76ef34af62f75199b/app/Livewire/Server/Form.php#L166
the actual `init functions seems to be here : https://github.com/coollabsio/coolify/blob/e9158b7305bb9253fe75a0e76ef34af62f75199b/app/Livewire/Server/ValidateAndInstall.php#L46-L59
which at the end calls validateConnection, which itself calls validateOS which itself calls the $ cat /etc/os-release to check the os ID
https://github.com/coollabsio/coolify/blob/e9158b7305bb9253fe75a0e76ef34af62f75199b/app/Livewire/Server/ValidateAndInstall.php#L94
https://github.com/coollabsio/coolify/blob/e9158b7305bb9253fe75a0e76ef34af62f75199b/app/Livewire/Server/ValidateAndInstall.php#L97-L106
the 500 error comes from the fact that they most likely do not check if the command actually runs successfully, since the error is "no such file or directory", instead of the expected : "Server OS type is not supported. Please install Docker manually before continuing: documentation."

I tried to implement a solution for the docker installation issue, which is the main issue as coolify runs fine on a macbook as is. The issue now is finding a good alternative for systemctl based commands to install/enable docker on the server(macos machine). Since there is no default package manager on macos, brew would probably be the best option imo, but then it means adding an install step on macos to install brew, then docker, to be able to use brew services.
I also think using uname -s to detect if it's a macos machine (Darwin and not Linux/...) should be consistent and good enough since Darwin is an apple only thing.

I would love brew services to be the alternative to systemd as this is what I use myself for my existing workaround.
Also I think it is the most commonly used alternative on MacOS.

Really nice explanations about implications of such task; thank you so much for being so descriptive.

I might be wrong on this one, but I don't think there is a way to get the docker engine/daemon with brew unless you install Docker Desktop and run it, you may know more than me on this @Tahul , because it would annoy me if I had to use Docker Desktop instead of a brew service. I always used the full desktop install as I never got it to work without, I know there are alternatives like colima/podman and whatnot but I'd like to use docker if possible to avoid using other third parties that might cause issues later on.

yeah even the install script that they use from rancher is just redirecting to docker desktop

that's a bummer

I do use Colima on MacOS to run Docker w/o Docker Desktop:
https://github.com/abiosoft/colima
It might be a great solution for such kind of "docker-wrapper" like Coolify Server?

it was my second option anyways so I guess I'll go with that, I don't want to get a full install in there, plus it's going to be annoying to restart etc, as it's the desktop app, I'd basically have to kill the process and relaunch it which isn't ideal

The last issue I have right now is begin able to download the correct docker engine version that coolify wants, it's a bit of a pain but after this is figured out I guess I'll have a first PR ready to be tested on an actual server, I don't have any so I'll let you do that and hopefully it all goes well :)

Hello! I'm currently developing an AI tool that investigates issues, and I used this issue as a test to see if it could help. Below are the findings, which I hope might assist in resolving this issue faster.
Boosterbot.ai Findings:
The investigation identified key areas that need to be updated to support MacOS servers within the Coolify application. The Server.php model class should be updated to recognize MacOS as a valid operating system. The SSH connection handling code in remoteProcess.php and the ExecuteRemoteCommand trait should be reviewed to ensure compatibility with MacOS. The environment setup scripts (install.sh and upgrade.sh) and configuration management classes (ConfigureCloudflared and UpdateCoolify) should be updated to include support for MacOS-specific configurations. Additionally, the coolify.php configuration file should be reviewed to ensure that any environment-specific settings include support for MacOS.

Review the code responsible for server validation to understand how servers are recognized and validated within the Coolify application.
The Server.php file in the app/Models directory contains methods like validateOS, validateConnection, and validateDockerEngine that are crucial for server validation. The validateOS method should be updated to recognize MacOS as a valid operating system. Additionally, the config/coolify.php file should be checked to ensure that any OS-specific configurations include support for MacOS.
Investigate the SSH connection handling code to ensure that SSH connections to MacOS servers are properly managed.
The remoteProcess.php file in the bootstrap/helpers directory contains functions like generateSshCommand, instant_remote_process, and refresh_server_connection that manage SSH connections. These functions should be reviewed to ensure compatibility with MacOS. Additionally, the ExecuteRemoteCommand trait in the app/Traits directory should be checked to ensure that remote command execution works seamlessly on MacOS servers.
Examine the environment setup process to identify any OS-specific configurations or checks that might be causing issues with MacOS servers.
The install.sh and upgrade.sh scripts in the scripts directory handle the environment setup and upgrade process. These scripts should be reviewed to ensure they include support for MacOS. Additionally, the ConfigureCloudflared and UpdateCoolify classes in the app/Actions/Server directory should be checked to ensure that they handle MacOS-specific configurations correctly. The coolify.php configuration file should also be reviewed to ensure that any environment-specific settings include support for MacOS.

These suggestions are automatically generated based on the context of the issue description and repository code. If you have any feedback or want to try it on your own project, my email is on my profile. Thanks!

/attempt #2773

@jSchenkel could you remove your comment? I feel it is VERY disrespectful for the work of @Xiloe to come up with unsolicited AI generated content while some real people are pursuing the work in a serious manner.

@Tahul My apologies, my intention was to be helpful and share my tool. Given that this is a bounty and @Xiloe has already done great work on the issue, I realize now that I made a mistake sharing the AI results. Deleted. Sorry @Xiloe !

@jSchenkel ; no worries, the results seemed great tbh! Happy we come to the same conclusion, good job with your project!

Hi, I wasn't able to work on anything yesterday, will try to make a commit today :)

@Tahul Would you mind trying this branch on your macos server by any chance?
It's not perfect at all, especially the docker install script that I could test, it doesn't even use the version specified by $dockerVersion yet, though the rest should be working fine, maybe try to have docker installed already if it fails miserably. Hope you can give my some feedback :)

@Xiloe thank you so much ; is it possible to use your server version while on a Cloud setup?

Also now that there has been great efforts achieved on this task; would you mind taking a look/giving a feedback on the purpose of this issue @andrasbacsai? 🙏

@Xiloe thank you so much ; is it possible to use your server version while on a Cloud setup?

Not sure that's possible, you'd have to selfhost my branch and then add your macos server from there

Alright ; I have a sandbox server I'll try it from there.
Not sure I'd have the bandwith for it today but maybe in the beginning of next week.

@Tahul and @Xiloe I see there has been some great progress and even a WIP implementation here: https://github.com/coollabsio/coolify/compare/main...Xiloe:coolify:macos-server-support. My main issue with adding mac os support is still the docker issue, as MacOs does not have docker APIs, there would be the need for docker desktop (too slow), or Colima, or maybe Orbstack for better performance, but all of these are essentially running a Linux VM with Docker? so why use MacOS as a server at all, when you then are running linux anyways?
If there is still enough interest, I may be able to bring this up/ work on a full implementation in core Coolify.

Hey @peaklabs-dev I had the same thought pretty much, docker on macos is kind of a mess if you're not using the desktop app, and all the other solutions like colima etc runs a VM which is not ideal either imo, at this point using linux is just easier.

wait

@CavinHuang What did you want to say?
@Tahul Since you seem to be one of the main Mac guys, I would really like to hear the reason why this would be necessary (see my opinion in the comment): https://github.com/coollabsio/coolify/issues/2773#issuecomment-2311245860)

After thinking about it, I think it makes sense to support MacOs since we will also support Windows/Windows Server. MacOs is not the most recommended way, but at least it should work.
I am thinking about using Orbstack or maybe https://asahilinux.org/ to add Mac OS support (after v4 stable releases).

It would be cool to support docker desktop so users on Mac can try the stack on our local dev machines. Orbstack would be fine as well, but I'm guessing more devs already have Docker desktop running.

You can do sudo touch /etc/os-release but what then with the Docker detection?


fix describe table output and meta pretty instance

Fixes #535
now output is:
pact> (describe-table accounts.accounts)
{"module": "accounts"
,"name": "accounts"
,"type": "(defschema account "Row type for accounts table."  [balance:decimal, amount:decimal, ccy:string, rowguard:guard, date:time, data:object:*])"}```

Looks better, though I'm surprised the last line didn't break.


Removed negative sign from _takeoff_ramp_vz_init

Describe problem solved by the proposed pull request
If the initial _takeoff_ramp_vz_init value is negative, as it is now in master, the takeoff ramp will go from that negative value to the parameter 'MPC_Z_VEL_MAX_UP', which is positive:
https://github.com/PX4/Firmware/blob/e0f3fc8d00850292a8309416574b34f6fbabaaa3/src/lib/FlightTasks/tasks/FlightTask/FlightTask.cpp#L141
In mc_pos_control.cpp we assign the output of this ramp to constraint.ramp_up:
https://github.com/PX4/Firmware/blob/e0f3fc8d00850292a8309416574b34f6fbabaaa3/src/modules/mc_pos_control/mc_pos_control_main.cpp#L579
Which is then used in PositionControl.cpp:
https://github.com/PX4/Firmware/blob/e0f3fc8d00850292a8309416574b34f6fbabaaa3/src/modules/mc_pos_control/PositionControl.cpp#L229
Negative values in constraints.speed_up make no sense, that's why I think that this negative sign might be a bug.

@roangel Thanks for reporting this. I checked the code and in fact, the negative sign makes sense. The logic is the following:
The velocity PID controller has a feedforward of "hover thrust" in order to operate in a 0g environment. If we directly activate the controller during takeoff with a velocity setpoint of zero, the thrust would suddenly jump to hover thrust. To prevent that behavior, we compute the velocity setpoint that would lead to zero thrust. Since the output of the controller (ignoring I and D) is (vel_sp - vel) * P + hover_thrust, assuming zero velocity (vel = 0), vel_sp = - hover_thrust / P is the setpoint that generates a 0 thrust.


Depth maps in dataset

Dear Haoyu Ma, Thank you very much for the work I really like your paper.
I have one question regarding your dataset though, In your dataset, you only have defocused maps and not depth maps. My question is do you have depth maps available as well for the corresponding RGB images?

Hi,
Yes we have a depth map generated with the LightField Camera, but the quality is not good.
But if you want to get it, please response this message and I'm happy to share it with you by Google drive.

Hello, thank you for your reply, yes please, it would be a great help if you could share the Google drive with depth maps.

<EMAIL_ADDRESS>if possible please share the google drive here.

hello, would you please also share the google drive with me if possible. Many thanks
<EMAIL_ADDRESS>

hello sir,
would you please also share the google drive with me if possible.
<EMAIL_ADDRESS>

hello sirs, would you please also share the google drive with me if possible. Many thanks
<EMAIL_ADDRESS>