Artikkel: 📄 I innbyggeren sine sko

Branch: https://github.com/digdir/designsystem/tree/docs/bios-brukerinnsikt
PR: https://github.com/digdir/designsystem/pull/559

This ended up to be one article


Unfortunately, there's a wontfix bug with NPM wherein npm install also runs preublish. This manifests with a situation where a fresh git clone + install (or any install) yields a dirty checkout:
$ git clone git@github.com:FormidableLabs/radium.git

$ cd radium

$ npm install
# ... SNIPPED ...
><EMAIL_ADDRESS>deps-fix /Users/rroemer/Desktop/TEMP_RADUM/radium
> babel-node ./npm-scripts/move-babel-to-dependencies.js
# ... SNIPPED ...

$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

    modified:   package.json

no changes added to commit (use "git add" and/or "git commit -a")

There is some new discussion of changed behavior / a new hook to address this situation in npm v4 when that's released.

Yuck, that looks super annoying.

Oh right, forgot about that "feature" they are going to finally fix it in npm@4, but that doesn't really help us now. Ideas?
For now, I think making modification of Radium slightly less annoying is worth not having babel in published dependencies.

@ianobermiller -- This is a bit of a potentially inconvenient switch but if you went instead of a prepublish workflow doing a:
preversion
version
postversion

workflow, preversion doesn't have the bug that prepublish does.
but, you'd have to publish with npm version

Fixed in 92046c8234ec19b77e86dfbf78ecec5740500f94.


CTRL + F search not always non-case sensitive

while doing a search in my code I typed the word promise in the search bar. every occurance in the file was typed Promise but some were skipped until I titlized it

This is still relevant.
It seems to be case insensitive if you are not using uppercase and switch to sensitive if you do.

dupe of #1999


User Agent onInvite delegate cannot reach methods outside of it's scope

Describe the bug
The issue is when I'm trying to use the onInvite delegation on the UserAgentOptions I cannot access to any method or variable in my main class.
I'm not sure if it's a SIP.JS bug, or just a misunderstanding with how to implement it using code. Hopefully you can assist with shedding some light on it.
I tried to implement it like that (it resides in some class that handles all my call taking operations):
registerExtensionCommand() {
    ...
    setting some class variables
    ...
    const userAgentOptions: UserAgentOptions = {
        authorizationPassword: password,
        authorizationUsername: username,
        viaHost: userDomain,
        transportOptions,
        uri,
        delegate: {
            onInvite: this.onCallRecieve
        }
    };
}

..
..

onCallRecieve(invitation: Invitation)
{
    console.log("heyyy we have a new call! ");
    var self = this.getCallTakingObject();
    console.log(this.myextension);
    console.log(self.myextension);
}

Tried to set var self = this and also tried to create an additional method in my class that returns itself (like in the above example) but it also cannot see the method.
So for the above code I'm getting undefined on all methods / variables I'm trying to get inside the scope of the onInvite.
BUT! When I'm doing it like that IT WORKS fine:
registerExtensionCommand() {
	const userAgentOptions: UserAgentOptions = {
		authorizationPassword: password,
		authorizationUsername: username,
		viaHost: userDomain,
		transportOptions,
		uri
	};
	var self = this;
	this.extension = "2000";

	this.userAgent.delegate = {
		onInvite(invitation: Invitation): void
		{
			console.log("heyyy we have a new call! ");
			console.log(self.myextension);
		}
	}
}

Can't understand the difference, both ways should use the same interface and same method. No?
As far as I see when I'm printing this in the scope of onInvite it prints the onInvite function, which makes sense. But if I want to get the main object that this register command and the delegation of onInvite resides... is it possible at all in the first implementation?
Is it because the onInvite in my 2nd implementation has the var self = this before the onInvite which can be passed inside?
Or maybe there's a more complex way to doing this?
        delegate: {
            onInvite: this.onCallRecieve
        }

and also passing an additional variable where I can just pass the main object as a second parameter besides the invitation: Invitation parameter it gets.
Thanks!
Logs
The only log I can provide is when calling some method in the onInvite scope and I'm getting this error:
CallTaking.ts:1213 Uncaught (in promise) TypeError: Cannot read property 'getExtension' of undefined
    at Object.onCallRecieve [as onInvite] (CallTaking.ts:1213)
    at user-agent.js:635
onCallRecieve @ CallTaking.ts:1213
(anonymous) @ user-agent.js:635
Promise.then (async)
onInvite @ user-agent.js:630
receiveOutsideDialogRequest @ user-agent-core.js:642
receiveRequest @ user-agent-core.js:467
receiveRequestFromTransport @ user-agent-core.js:333
receiveIncomingRequestFromTransport @ user-agent-core.js:165
onTransportMessage @ user-agent.js:821
transport.onMessage @ user-agent.js:718
onWebSocketMessage @ transport.js:410
(anonymous) @ transport.js:202

Environment Information

SIP.JS 0.17.1
Chrome 86.0.4240.111

Not a SIP.js issue, but a lack of understanding of the javascript this variable and how it scopes to functions and how they are called. Questions like this should be asked on our Google Group.
You need to set the this reference when setting the callback. You can do it using .bind() or using ES6 Fat Arrow Functions.
Bind
registerExtensionCommand() {
    ...
    setting some class variables
    ...
    const userAgentOptions: UserAgentOptions = {
        authorizationPassword: password,
        authorizationUsername: username,
        viaHost: userDomain,
        transportOptions,
        uri,
        delegate: {
            onInvite: this.onCallRecieve.bind(this)
        }
    };
}

..
..

onCallRecieve(invitation: Invitation)
{
    console.log("heyyy we have a new call! ");
    var self = this.getCallTakingObject();
    console.log(this.myextension);
    console.log(self.myextension);
}

Fat arrow function
registerExtensionCommand() {
    ...
    setting some class variables
    ...
    const userAgentOptions: UserAgentOptions = {
        authorizationPassword: password,
        authorizationUsername: username,
        viaHost: userDomain,
        transportOptions,
        uri,
        delegate: {
            onInvite: (invitation) => this.onCallRecieve(invitation)
        }
    };
}

..
..

onCallRecieve(invitation: Invitation)
{
    console.log("heyyy we have a new call! ");
    var self = this.getCallTakingObject();
    console.log(this.myextension);
    console.log(self.myextension);
}

Not a SIP.js issue, but a lack of understanding of the javascript this variable and how it scopes to functions and how they are called. Questions like this should be asked on our Google Group.
You need to set the this reference when setting the callback. You can do it using .bind() or using ES6 Fat Arrow Functions.
Bind
registerExtensionCommand() {
    ...
    setting some class variables
    ...
    const userAgentOptions: UserAgentOptions = {
        authorizationPassword: password,
        authorizationUsername: username,
        viaHost: userDomain,
        transportOptions,
        uri,
        delegate: {
            onInvite: this.onCallRecieve.bind(this)
        }
    };
}

..
..

onCallRecieve(invitation: Invitation)
{
    console.log("heyyy we have a new call! ");
    var self = this.getCallTakingObject();
    console.log(this.myextension);
    console.log(self.myextension);
}

Fat arrow function
registerExtensionCommand() {
    ...
    setting some class variables
    ...
    const userAgentOptions: UserAgentOptions = {
        authorizationPassword: password,
        authorizationUsername: username,
        viaHost: userDomain,
        transportOptions,
        uri,
        delegate: {
            onInvite: (invitation) => this.onCallRecieve(invitation)
        }
    };
}

..
..

onCallRecieve(invitation: Invitation)
{
    console.log("heyyy we have a new call! ");
    var self = this.getCallTakingObject();
    console.log(this.myextension);
    console.log(self.myextension);
}

Thanks a lot, I'll check this.
Next time I'll open similar questions on the Google group.


feat: Support name_prefix in iam_role.enhanced_monitoring

Description
Add support for using name_prefix for the enhanced monitoring iam role.
Motivation and Context
Partially addresses https://github.com/terraform-aws-modules/terraform-aws-rds/issues/417.
One thing I did not do in this PR is make using the name_prefix default. Doing so would require current users to pass in monitoring_role_use_name_prefix = false to not change existing configurations if using current defaults.
Breaking Changes
No.
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

This PR is included in version 4.6.0 :tada:


Lower memory usage during AttnFuncWithCP.forward

Description
Release p2p_comm_buffers.
Fixes #952
Type of change

[ ] Documentation change (change only to the documentation, either a fix or a new content)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Infra/Build change
[ ] Code refractor

Changes
Please list the changes introduced in this PR:

Change A
Change B

Checklist:

[x] I have read and followed the contributing guidelines
[x] The functionality is complete
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/te-ci pytorch

Hi @i4never
Thanks for submitting the PR! Have you done any E2E training test with your PR? There is some case where communication can take longer time than compute, your code seems can set p2p_comm_buffers[i]=None before the async P2P communication is done, right? Wouldn't this result in any issue?
Actually, how critical is it for you to fix the issue? The communication buffers are temp buffers per transformer layer, while the attention fwd of a transformer layer is done, those buffers will be released dynamically. Assuming mbs=1, seq=64K, head_dim=128, GQA group of 8 (i.e., num of KV heads is 8), and BF16 precision. The total P2P comm buffer size is only<PHONE_NUMBER>8=256MB. For long sequence like 64K, you may apply TP. Assuming TP8, then total P2P comm buffer size will be 8 times smaller, i.e., 256/8=32MB. Do you have a special case which the buffer size is too big?
Thanks.


when subscriber can not get argo pod logs, make pod log message intuitive

Proposed changes
When experiment pods fail to get from Argo Pod, the imported logs always return the same value. This is not intuitive for users.
So, by fetching the phase state from the chaos experiment run, made the log message different for each experiment phase.
But the problem remains. I'm not sure which is the best way to write the logs.
	switch phase {
	case "Completed":
		return "Experiment pod is deleted"
	case "Stopped":
		return "Stopped"
	case "Running":
		return "Workflow Pod is initializing"
	case "Queue":
		return "Queue"
	case "NA":
		return "NA"
	default:
		return "Workflow Pod is initializing"
}

Special notes for your reviewer:
https://github.com/litmuschaos/litmus/issues/4532

Can you show us result screenshots? @kwx4957

yes i will add it


RDK-30526, RDK-30475: added client control westeros extension

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/379/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/5089/ started

Copyright scan failure
Commit: f311b1ebca195225c24e15ff8301a26b970ea5f9
Report detail: https://gist.github.com/b03f3f27d836c9f7472408ec4d564393

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/23971/ started.

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/2040/ started.

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/RDKShell/41/rdkcentral/RDKShell

Commit: f311b1ebca195225c24e15ff8301a26b970ea5f9

Report detail: gist

https://jenkins.code.rdkcentral.com/job/github-triggered/5091/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/23975/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/381/ started

Copyright scan failure
Commit: 0bcb5096a52033e24327b67d59167051db08cfa9
Report detail: https://gist.github.com/23ac87da4a5d184e910273c46c0668f5

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/2047/ started.

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/RDKShell/41/rdkcentral/RDKShell

Commit: 0bcb5096a52033e24327b67d59167051db08cfa9

Report detail: gist

https://jenkins.code.rdkcentral.com/job/github-triggered/5093/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/23977/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/382/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/2052/ started.

Hi Mateusz - I fixed the Blackduck errors (spurious pattern detected in the source code), and you have removed another match before I got to it, so all the compliance checks are passing.  But any new source code files should have an RDK Apache header, and some do not.  (This won't block merge but it should really be fixed.)
Thanks,
Martin
Martin Hughes, RDK CMF Compliance Team

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/389/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/5101/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/23981/ started.

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/2055/ started.

Hi Martin, I've added the missing RDK Apache headers.
Regards,
Mateusz Hobgarski

Many thanks Mateusz

https://jenkins.code.rdkcentral.com/job/github-triggered/5651/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/5651/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/25230/ started.

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/25230/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/825/ started

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/825/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/3032/ started.

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/3032/ started.

Smoke tests for ['build-rpi-hybrid-refapp-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71395/

Smoke tests for ['build-rpi-hybrid-refapp-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71395/

Smoke tests for ['build-qemux86-hyb-rdk-next'/'build-qemux86-mc-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71396/

Smoke tests for ['build-qemux86-hyb-rdk-next'/'build-qemux86-mc-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71396/

Smoke tests for ['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-mc-wpe-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71397/

Smoke tests for ['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-mc-wpe-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71397/

https://jenkins.code.rdkcentral.com/job/github-triggered/5654/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/5654/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/25235/ started.

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/25235/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/829/ started

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/829/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/3035/ started.

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/3035/ started.

Smoke tests for ['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-mc-wpe-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71412/

Smoke tests for ['build-qemux86-hyb-rdk-next'/'build-qemux86-mc-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71410/

Smoke tests for ['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-mc-wpe-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71412/

Smoke tests for ['build-qemux86-hyb-rdk-next'/'build-qemux86-mc-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71410/

Smoke tests for ['build-rpi-hybrid-refapp-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71411/

Smoke tests for ['build-rpi-hybrid-refapp-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71411/

'['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-hybrid-wpe-rdk-next']' Smoke test FAILURE, investigation pending.
Flash MC [SUCCESS]
Flash HYB [SUCCESS]
MC - Video Test [FAILURE]
Video HLS gst-launch [SUCCESS]
Video HLS rdkmediaplayer [SUCCESS]
Video Streaming using aamp-cli [SUCCESS]
Video local using gst-play-1.0 [SUCCESS]
Video Streaming using rmfApp [FAILURE]
RDKShell CI Tests [FAILURE]
checking thunder security
Thunder security is disabled
add key intercept test failed
add key listener test failed
Number of success test - 38
Number of failed test - 2
Video Streaming using rmfApp [SUCCESS]
HYB - Video Test [FAILURE]
Video HLS gst-launch [SUCCESS]
Video HLS rdkmediaplayer [SUCCESS]
Video Streaming using aamp-cli [FAILURE]
Video local using gst-play-1.0 [SUCCESS]
RDKShell CI Tests [FAILURE]
checking thunder security
Thunder security is disabled
add key intercept test failed
add key listener test failed
Number of success test - 38
Number of failed test - 2
Video Streaming using aamp-cli [SUCCESS]
https://jenkins.cmf.code.rdkcentral.com/job/test-rdkv-raspberrypi-flow/21086/

'['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-hybrid-wpe-rdk-next']' Smoke test FAILURE, investigation pending.
Flash MC [SUCCESS]
Flash HYB [SUCCESS]
MC - Video Test [FAILURE]
Video HLS gst-launch [SUCCESS]
Video HLS rdkmediaplayer [SUCCESS]
Video Streaming using aamp-cli [SUCCESS]
Video local using gst-play-1.0 [SUCCESS]
Video Streaming using rmfApp [FAILURE]
RDKShell CI Tests [FAILURE]
checking thunder security
Thunder security is disabled
add key intercept test failed
add key listener test failed
Number of success test - 38
Number of failed test - 2
Video Streaming using rmfApp [SUCCESS]
HYB - Video Test [FAILURE]
Video HLS gst-launch [SUCCESS]
Video HLS rdkmediaplayer [SUCCESS]
Video Streaming using aamp-cli [FAILURE]
Video local using gst-play-1.0 [SUCCESS]
RDKShell CI Tests [FAILURE]
checking thunder security
Thunder security is disabled
add key intercept test failed
add key listener test failed
Number of success test - 38
Number of failed test - 2
Video Streaming using aamp-cli [SUCCESS]
https://jenkins.cmf.code.rdkcentral.com/job/test-rdkv-raspberrypi-flow/21086/


feat: Support forward declarations

TODO:

[x] Add tests using external symbols
[x] Add tests using forward declarations
[x] Integration testing
[x] Rough benchmarks - https://github.com/sourcegraph/scip-clang/issues/139#issue-1637237375

Stdlib code is still not being indexed, due to what looks like a bug in the preprocessor handling, leading to stdlib files going missing from the file lists altogether.


RFC: feat(RequestLogging): Evaluate mixin fields JIT

Currently, getFieldsFn callback passed to createContextMiddleware is evaluated once per request when it is invoked in the middleware chain. This amortises the cost of the invocation and reduces the amount of data kept in async local storage.
A downside is that additional information that is added to the Koa context later in the middleware chain cannot be factored in to the logging fields. This is also easy to miss if you have permissive code where the logging fields are simply omitted if they aren't available on the context.
This exposes a nested mixin which could support this use case. I'm not convinced that this should be released as is as having two local storages and mixins likely does not make sense outside of backward compatibility.

Hmmmm I almost am in favour of people maintaining their own AsyncLocalStorage at this point 🤔
eg. in one of my APIs we make use of it to avoid the need to pass around tracing headers

👍 I was feeling similarly as it doesn't feel like contextMiddleware is a particularly useful abstraction in our case and the most we could save on is the mixin boilerplate:

That said, your example is actually interesting because tracing headers are to some degree standardised and could be an accessory to contextMiddleware if we commit to storing a reference to the Koa context god object in async local storage.

+1 I was feeling similarly as it doesn't feel like contextMiddleware is a particularly useful abstraction in our case and the most we could save on is the mixin boilerplate:

That said, your example is actually interesting because tracing headers are to some degree standardised and could be an accessory to contextMiddleware if we commit to storing a reference to the Koa context god object in async local storage.

Hmmm :thinking: let me mull it over. Friday brain has kicked in. If we do go with adding tracing header support we should probably move this out of RequestLogging and have examples of how to create a basic one.

Had a thought about this. Maybe we could leave this one as is and create a different one which allows for more flexibility. I don't know what this would look like but by default we could include logger context, a ref to ctx?


Custom User Model related name

First of all thank you for this package.
I have a custom user model. How can i add a reverse relation to get the organization belonging to that user?

The reverse relation name from user to organization should be the same regardless of what user model you use, organization_set, which is a ManyRelatedManager instance.

@bennylope
Thanks for your reply.
So this is what my custom user model looks like.
from organizations.models import Organization
class Team(Organization):
    pass

class User(without(AbstractUser, 'email')):
    team = models.ForeignKey(Team, null=True, blank=True, related_name='team')

    address = models.ForeignKey(Address, null=True, blank=True, related_name='address')
    profile = models.ForeignKey(Profile, null=True, blank=True, related_name='profile')
    phones = models.ManyToManyField(Phone, related_name='phones')

    is_blocked = models.BooleanField(choices=((False, 'False'), (True, 'True')), default=False)
    is_volunteer = models.BooleanField(choices=((False, 'False'), (True, 'True')), default=False)

Do i have to define organization somewhere to be able to use organization_set?

The reverse relationship from B->A is added when a foreign key is created from A->B. You get organization_set for free.
Because you're using multi-table inheritance you do not get a reverse relationship from User to your customer organization, Team, only to the Organization model. Because multi-table inheritance is built on a foreign key itself, you can use the reverse relation from Organization to your custom organization model.
>>> user.organization_set.all()[0].team

@bennylope  Thanks :+1:

So what if i use with OneToOneField... i can make a reverse relation but when a new organization is created it uses table oragnizations_organization so a new org is inserted in it and not in team table. So reverse relation does not work from user.team until i insert id of org manually.
from organizations.models import Organization
class Team(Organization):
    description = models.TextField()

class User(without(AbstractUser, 'email')):
    team = models.OneToOneField(Team, null=True, blank=True, related_name='team')

@bennylope Sorry im new to python/django so ignore my silly questions.
So i've made a model without a team foriegnKey. And get_user_model().objects.organizations_organization gives me the organizations attached to the user. Fair enough so far. How can i use a custom organization model so it supports organization image (thumbnail) field as well?
If i am going to be using like
from organizations.models import Organization
class Team(Organization):
    pass

How am i suppose to use Team class in User model?

Sorry, your questions are decent questions, but they're beyond the scope of this package.


Use parameters instead of variables in pipeline

Currently the YAML pipeline for Azure DevOps documents the required variables in comments, but they're actually configured separately with the pipeline.  Using parameters instead allows us to restrict the available options and declare defaults in the YAML document, instead of having them defined separately.

Here's what the Run Pipeline dialog looks like with this change:

Here's what the Run Pipeline dialog looks like with this change:


Help: composite PK with  ExportToJson feature

Hi,
I have created a single PK table, and it is working fine. i.e. I need the ExportToJson feature too. But now I need to make that as composite PK. So can you tell me how to handle that use case here? Thanks in advance.
createExtrasTable(): Promise<capSQLiteChanges> {
   const query = `
         CREATE TABLE IF NOT EXISTS Extras (
           ExtraId TEXT PRIMARY KEY NOT NULL,
           Amount REAL NOT NULL,
           Name TEXT NOT NULL,
           FareId TEXT NOT NULL,
           CreatedDate INTEGER NOT NULL,
           UserId TEXT NOT NULL,
           last_modified INTEGER DEFAULT (strftime('%s', 'now')),
           FOREIGN KEY(FareId) REFERENCES Fares(FareId)
          );

         CREATE TRIGGER IF NOT EXISTS Extras_trigger_last_modified
         AFTER UPDATE ON Extras
         FOR EACH ROW WHEN NEW.last_modified <= OLD.last_modified
         BEGIN
           UPDATE Extras SET last_modified= (strftime('%s', 'now'))
           WHERE ExtraId=OLD.ExtraId;
         END;
          `;

   return this.sqliteDbConnection.execute(query);
 }

With Composite PK
createExtrasTable(): Promise<capSQLiteChanges> {
    const query = `
          CREATE TABLE IF NOT EXISTS Extras (
            ExtraId TEXT NOT NULL,
            Amount REAL NOT NULL,
            Name TEXT NOT NULL,
            FareId TEXT NOT NULL,
            CreatedDate INTEGER NOT NULL,
            UserId TEXT NOT NULL,
            last_modified INTEGER DEFAULT (strftime('%s', 'now')),
            FOREIGN KEY(FareId) REFERENCES Fares(FareId),
            PRIMARY KEY (ExtraId, FareId)
           );

          CREATE TRIGGER IF NOT EXISTS Extras_trigger_last_modified
          AFTER UPDATE ON Extras
          FOR EACH ROW WHEN NEW.last_modified <= OLD.last_modified
          BEGIN
            UPDATE Extras SET last_modified= (strftime('%s', 'now'))
            WHERE ExtraId=OLD.ExtraId;
          END;
           `;

    return this.sqliteDbConnection.execute(query);
  }

So how can I define this line then?
UPDATE Extras SET last_modified= (strftime('%s', 'now'))
           WHERE ExtraId=OLD.ExtraId;

@Sampath-Lokuge  Did you try
UPDATE Extras SET last_modified= (strftime('%s', 'now'))
           WHERE ExtraId=OLD.ExtraId AND FareId=OLD.FareId

Due to the complexity of UI/UX and the new delete workflow changes on the plugin, I have decided to create a new Single PK  each and every time to avoid duplicate PKs with the deleted records. Thanks for the feedback.


Nested components with stores gives error "MobX injector: Store 'store' is not available! Make sure it is provided by some Provider" when trying to mount component in enzyme

What I'm trying to do
I'm trying to test a component with nested components, some of which have the store injected. I'm receiving the error "MobX injector: Store 'store' is not available! Make sure it is provided by some Provider" when trying to mount the component using enzyme. If I comment out the nested components which have the store injector, the error goes away. I am testing using Enzyme and Jest.
Example
Search component
import SearchBar from '../SearchBar';
import SearchButton from '../SearchButton';

@inject('store') @observer
export default class Search extends Component {
  render() {

      <SearchBar />
      <SearchButton />

  }
}

SearchBar component:
@inject('store') @observer
export default class SearchBar extends Component {
  render() {

Hi

  }
}

SearchInput component:
@inject('store') @observer
export default class SearchInput extends Component {
  render() {

Hey

  }
}

Test:
import Search from '../Search';
import { mount } from 'enzyme';

store = { searchTerm: '' }

describe('Search', () => {
  it('has a searchBar', () => {
    const component = mount(<Search store={store} />);
  });
});
}

The above test is what returns the error when run (given any assertion / test etc.). If I SearchBar and SearchInput out, the test runs fine - so I'm guessing that the error is due to the nested component's injection of the store?
Shallow rendering fixes the issue, but will not work for the tests I need to write, as I am testing lifecycle methods.

@sikemausa inject relies on context, so you have basically 4 options to pick here:

Do shallow rendering (as you mentioned), and pass in store explicitly, bypassing the outer inject
Use Provider in your tests: e.g. mount(<Provider store={store}><Search /></Provider>
Don't use inject on the deeper components, but pass store via props from Search to all the relevant descendants
You could also put a Provider inside the Search component, (re)injecting the store in the tree, but I think that is an ugly thing to do just for the sake of testing

Perfect - using the Provider in my test is precisely what I needed to do. I appreciate the response - thank you.

Kind request: close solved issues 😉


flashparams: fix memory leak when saving parameters

A large buffer on the heap was not deallocated when parameters were saved,
but there were no changes to the parameters. In that case
parameter_flashfs_write() was not called, which was previously responsible
for freeing the buffer.
This patch moves the responsibility of freeing the buffer to the calling
side, which already explicitly allocates the buffer.
Note that this only applies to the flash-based parameter backend.
@davids5 how do I execute the unit tests?
Why is the lock commented in param_lock? And flashfs uses static data, but there is no locking within or around parameter_flashfs_alloc and the others.

@bkueng
Thank you for fixing this.
Originally this code was created from Flowv2 with No OS. The allocation was static at init based one user with a fixed record size.  It was then ported to Firmware. The bug  came about because of a later change to the params that was always writing the changes which is bad on a FLASH and I added the delta check without releasing the ramifications.
The other not obvious thing that need to be realized is that the CPU is held off during Flash operations. The time varies during writes and is large during erases.
Unit test is a bad name for the #if def - it was just bring up code called from the src/drivers/board//xxxx_init.c to manually verify the write and wrap of sector code under JTAG.
RE:param lock - Please ask @LorenzMeier  about https://github.com/YUNEEC/Firmware/commit/fdc4521
There was an assumption the caller was serializing access.


Feature Request: add visitor capability to the graph

Hi @yamafaktory , I'm currently working with hypergraphs when I came across your library. I started to write my own but I'm wondering whether you would be ok if I contribute to yours by adding a way to visit the nodes and edges of the hypergraph as BFS or DFS walks.
If you are ok, I might come up with a PR soon. My idea would be to implement iterator or visitor patterns. WDYT?

Hi @cmichaudav !
Of course, feel free to contribute :)


PT-4248 Update rate-limit plugin to include trust-forward-headers config

Adds a new field for trust_forward_headers in rate-limit plugin.
Related
https://github.com/hellofresh/janus/pull/400

+1


Problem using org.springframework.cloud.stream.binder.rabbit.RabbitMessageChannelBinder to set up the subscribers on the Spring Cloud Bus

I have a system with three components.  A ConfigServer, ServiceA, and ServiceB.  When they register against the Spring Cloud Bus, they all end up being tied as consumers to the same queue registered against the binder.springCloudBus queue.  This causes round-robining of messages, where only one service will actually be delivered a notification on the bus.
In bindPubSubConsumer(String name, MessageChannel moduleInputChannel, Properties properties), it is not possible to give each queue a different name and have it bound to the same exchange.
 ConfigServer ----------------
                             |
                    ------------------
ServiceA ---------- | SpringCloudBus |
                    ------------------
                             |
ServiceB ---------------------

Exchange:  binder.topic.springCloudBus
Queue: binder.springCloudBus
The SINGLE queue ends up with three consumers.
This was discovered when we were working with the /refresh capabilities of spring-cloud.  In the scenario above, the refresh message is not passed to all necessary parties.

What does your configuration look like?

ConfigServer
bootstrap.yml
spring:
  application:
    name: configserver

application.yml
server:
  port: 8888

management:
  context-path: /admin

spring:
  cloud:
    config:
      server:
        git:
          uri: ssh://git@stash.csgsystems.com:7999/~bout01/config-repo.git
          basedir: config-repo

ServiceA
bootstrap.yml
spring:
  application:
    name: serviceA
  profiles:
    active: development
  cloud:
    config:
      uri: http://localhost:8888

application.yml
server:
  port: 8080

ServiceB
bootstrap.yml
spring:
  application:
    name: serviceB
  profiles:
    active: development
  cloud:
    config:
      uri: http://localhost:8888

application.yml
server:
  port: 8081

Ok, what version are you using?

For spring-cloud-bus...1.1.0.BUILD-SNAPSHOT
For spring-cloud-stream-binder-rabbit...1.0.0.BUILD-SNAPSHOT

same issues for me :(

I can verify this is happening.

@TabberGit @hacbq I've logged an issue with the spring-cloud-stream team and will await their feedback.

Tracking https://github.com/spring-cloud/spring-cloud-stream/issues/193 now

I changed to release version :)

Pull request from @garyrussell - https://github.com/spring-cloud/spring-cloud-stream/pull/194 will resolve this...

https://github.com/spring-cloud/spring-cloud-stream/pull/194 has been closed and should be in SNAPSHOTS. I will verify that it fixes this problem.

@spencergibb BindingProperties.group() now defaults to a random UUID (on master) so this change could be backed-out at some point if you wish.


19 script minor fixes

The PR was accidentally closed, so re-opening a PR to merge, Will also fix the size issue

I will change the branch I am merging in.
On Sun, Apr 21, 2019 at 7:23 PM nurrencd<EMAIL_ADDRESS>wrote:

Closed #21 https://github.com/os-vr/OSVR-Senior-Project/pull/21.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/os-vr/OSVR-Senior-Project/pull/21#event-2290344354,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA73OZP23GNZXVIMRYQYDTDPRTZOTANCNFSM4HHMSQTQ
.


Add from_list() constructor to GaussianResultList

The goal is to simplify this common snippet:
estimate_list = run_filter(ekf, x0, P0, input_list, meas_list)

# Postprocess the results and plot
results = GaussianResultList(
    [
        GaussianResult(estimate_list[i], states_true[i])
        for i in range(len(estimate_list))
    ]
)

to something like
estimate_list = run_filter(ekf, x0, P0, input_list, meas_list)

# Postprocess the results and plot
results = GaussianResultList(estimate_list, states_true, interp="nearest")
resullts = GaussianResultList.from_list(estimate_list, states_true, interp="nearest") # Alternative interface

done... will be in next PR


SAK-48145 New groups realms are using the creation date of the realm template

Well done @josecebe !


[Question] Light local to node?

Is it possible to create a light source which is local to a node, i.e. illuminate only only the node it is attached to or illuminate only the nodes which are its children, or something similar?

This is not currently possible. Thank you for the feature request!


What to do with an empty PR? [do not merge]

Git(Hub) keeps telling me my fork is 2 commits ahead, but those are only merge commits not containing any changes.
Is this expected? How can I get rid of them?

I've been wondering about these lately too - I think they are markers for a pull request with alot of commits. Since they have the same 'diff' as a commit, they don't actually update anything, but they should let us do a single revert on this merge commit and revert a whole pull request at once....
Thus, fixing a problem with pull requests I've been complaining about. I need to test this sometime.

Our conclusions after some experiments:
The merge commits duplicate all the diffs in each and every commit in the merge. As a result there is no diff, but there is a legitimate commit. This is so you can revert a merge. They are safe to have around.
A good walkthrough on reverting merges. It also handles the difficult case when you want to revert a reverted merge....


Prevent the toggle from submitting the form

Short description of what this resolves:
Prevent the toggle from submitting the form which happens when a <ion-toggle> is placed inside a <form> because the type of its underlying <button> element defaults to type="submit".
Changes proposed in this pull request:

Adds type="button" to the button element to prevent it from submitting the containing form

Ionic Version: 2.x
Fixes: #6120

We just fixed that one and snuck it in before this PR: https://github.com/driftyco/ionic/commit/f17f5172e30b0b8940b72dda9ec44d16a7a5c86e
Thanks for the help though! We really do appreciate all the great issues and PRs you've been submitting, thanks!

Wow, that was fast, thanks!


Upgraded last version

I´ve upgraded to last version and now i received this bug "DataTables warning (table id=""): Requested unkind parameter '' from the data source for row 0"
I also have bugs to load another scripts
Same code worked before upgraded
My code:
t

able = $table.dataTable(
Plugins.DataTablesPlugin.getOptions("usuarios",
{
aaSorting: [[5, "asc"]],
aoColumns: [
{
mData: "details",
bSortable: false,
mRender(data, type, row) {
return <a title='${resources["Title_ShowUserDetails"] }' href='${$("#urlUsers").val()}?userId=${row.Id }''>;
}
},
Thanks

Are there any javascript files which have failed to load (check the network tab)?

Code worked before upgraded, i attached network screen with scripts that failed after upgrading

You've uploaded the console logs but not the network screen...
Can you compare your scripts against https://aspdatatables.azurewebsites.net/?


onEnter after hook not being called (on VictoryScatter animations at least)

I have a VictoryScatter chart which is animating between data-sets which have different numbers of points.  If the chart data is updated to a set with more points, the new points do not appear (although I can make them do so by hovering as that overwrites the styles on them).
You can see from investigating the nodes in the console that they have opacity set to 0.  Further, this is because the defaultTransition for the VictoryScatter has a before hook which sets the new points' opacity to zero, and an after hook which is supposed to set them back to opacity 1.
Explicitly passing in hooks to overwrite these makes it fairly clear that the after hook isn't being called at all.

@richsilv sorry for the delay. I haven't been able to reproduce this issue. I made a gif with the before hook setting the opacity to 0.3 instead of zero so it's easier to see.

The animate prop for this chart looks like
animate={{
   onExit: {
     duration: 500,
     before: () => ({opacity: 0.3})
    },
    onEnter: {
      duration: 500,
      before: () => ({ opacity: 0.3 }),
      after: (datum) => ({ opacity: datum.opacity || 1 })
   }
}}

Can I see what your code looks like?


setDataValue does not update aggrageted value

I'm submitting a
[x] bug report => search github for a similar issue or PR before submitting

Current behavior
After applying grouping and default  sum aggregation  updating cell value using rowNode.setDataValue(colId, newValue) aggregated value remains old.
Expected behavior
Aggregated value should be updated
Minimal reproduction of the problem with instructions
Here  is quickly updated plunker(timeout in group-row-renderer.component.ts)

ag-Grid version: 9.0
Language: TypeScript 2.1.4

hi
If you call this.gridOptions.api.recomputeAggregates(); after your update the value it should do what you want it to do
thanks


[Docs]Dark mode logo issue for Meshery Adapter of Kuma

Current State
logo of Meshery Adapter for Kuma not visiable in dark mode at https://docs.meshery.io/
logo of meshery adapter for kuma not visiable in dark mode at /service-meshes/adapters/kuma/
Desired State
logo should be visiable

Contributor Guides and Handbook

📚 Instructions for contributing to documentation

Meshery documentation site and source

🛠 Meshery Build & Release Strategy
🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

I want to work on this issue

@Rajivkumawat3  How's the progress on your PR? If you're not actively working on it, please let us know. We're here to help, if you're not working on it do signal.

@thisiskaransgit sir i am working on it , today i will fix this isssue .

@Rajivkumawat3 Please let us know if you're still committed to this effort.
We can reassign if you're not.

@vishalvivekm  i tried to fix it , but after refreshing the page it goes it initial state . yes you can reassign it

@vishalvivekm sir you can assign this issue to someone else

If the issue still persists, can I please work on it?

@Rajivkumawat3 I don't think we will be able to fix this issue as there is no version of the logo adapted to the dark mode.


OneDrive for Buisness

Hi ,
When I am trying to get access token .
using below restAPI request  "https://login.microsoftonline.com/common/oauth2/v2.0/token?client_id={clientID}&client_secret={client_secret}&code={code}&grant_type=authorization_code&resource =https://api.office.com/discovery/&redirect_uri=http://localhost"
I am getting bad request.
Tried with all posibilites ,I have doubt on resource .Could you please let me know is it proper resource

can u pls closed this has your issue have been solved

Thank you for the support


Replace stop action by the reload option in reconfigureForceRestart

It seems that the reload option is better than the stop option, because stop action stop WebRTC communication. I have configured the reload option in another pull request.

I seem to have misunderstood something. Why when the user clicks on the orange button to reload the web server configuration, the action reconfigureForceRestart is launched? Isn't it better not to stop nginx, but just reload it?

It's also executed when you enable or disable nginx and hit apply.

Okay, I didn't know that. So it needed to separate the apply button than the reload, right ?

For one the code should not implement reconfigureAction() at all since it is outdated code and the default is likely much better. Secondly, reconfigureForceRestart() needs to be implemented as { return 0; } to avoid the stop on a reconfigure to reach the actual reload below...

So, if we had
protected function reconfigureForceRestart()
{
return 0;
}
It should be good ?

And reconfigureAction() removed, yes

Okay Thank you, I have tried it, and it seems to be good and just reload the configuration :).
Did I create a pull request for that ?
And I have a last question, when I delete reconfigureAction in Nginx ServiceController.php file, I use the default, in which file is the default reconfigureAction ?

Yes, the default comes from core:
https://github.com/opnsense/core/blob/b74b3799db80247c50524e066e0747c1c0f5d783/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableServiceControllerBase.php#L161-L167
Can you create a full PR with the required action added as well?

Okay, normally I did it properly.
Thank you for you help :).

Hello, it seems after the upgrade to 21.1.9 version, it's good, but after upgrade to 21.7, it rollbacks to the old configuration of the nginx plugin ...

I forgot about this, sorry. 21.7 upgrade reinstalls all plugins cleanly so you have to apply your code again. 21.7.1 will have this code most likely.
Cheers,
Franco

Thanks!

Hello, I had just upgrade an Opnsense to the 21.7.4 version, but it rollbacks to the old configuration of the nginx plugin ...


Trim down Mathematics library

Now we have a perfect picture of what we want + due to GH-49, we will be working towards using System.Numerics to reduce technical debt and to allow us to take advantage of .NET 7.0's improved mathematics library.

Finished in https://github.com/vignetteapp/sekai/commit/1a5f95e228d0061c013c39fcb3e3f53d3559d404. We will be retaining the rest as it was deemed important.


Enable support for downloading export data

Updating script to download export data into a new series (electricity_export) when configured. Export is not required and will be skipped if an export MPAN isn't provided.

Could I get a review please

@kevalpatel2106 ^^


Changes on Laravel Nova 3.19

Hi @anderly
I was just updating my Laravel Nova project to 3.19.1 when I faced the problem above:

After some analisys I observed that until 3.18 we'd the following scenario:

ResourceGroupMenu extends Tool;
Tool extends Card;
Card extends Element;
Element uses the trait Metable;

But on 3.19.1 (that I'm using now)

ResourceGroupMenu extends Tool;
Class Tool just use AuthorizedToSee, Makeble, ProxiesCanSeeToGate;

So many remaining methods that are used by ResourceGroupMenu are missing, like withMeta, width, and so on...
I suspect that this new change in Nova is very harmful, what do you think?
Best regards

This change is mentioned here: https://github.com/laravel/nova/pull/1148

This change is mentioned here: https://github.com/laravel/nova/pull/1148

Hi there, I'm getting:

Call to undefined method SaintSystems\Nova\ResourceGroupMenu\ResourceGroupMenu::jsonSerialize()

which is making the plugin to stop working.

Hi there, I'm getting:

Call to undefined method SaintSystems\Nova\ResourceGroupMenu\ResourceGroupMenu::jsonSerialize()

which is making the plugin to stop working.

I am experiencing the exact same issue as @newtongamajr.

I am experiencing the exact same issue as @newtongamajr.

on laravel nova v 3.22 same problem as @eugenevdm
jsonSerialize undefinded


audio: Use ALSA again for Linux

Now mixing happens on Ebiten side, there is no strong reason to keep using PulseAudio.
See also #1663
CC @nanoslayer

FYI getting a lot of clicking noise with the new version; going to bisect. Pulseaudio being at fault is a common theme, but I am gonna verify for real :)

Thank you for the reporting!


parse daemon's response for errors

This will parse the response for errors and will attempt the next authentication configuration if an error is found.
To easily communicate the errors found a new channel is created and the go routines that handles the parsing and reporting will be started and destroyed for each authentication attempt.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1449742

@pweil- can you review?

@ilackarms can you review?

Ping @pweil- @ilackarms this is pretty urgent. Can you review?

sorry, I am not getting any GH notifications for some reason.  Will review this today.

@pweil- can you take another look? Still closing the pipe manually, but I fixed other comments.
I am not sure how to signal to the decoding function that no more messages might come. I though using an input channel but then in the case that it takes long time to decode the messages it might cause us to skip some.

@pweil yes it is possible to get an error in the output and in the progress writer we detect it as well... https://github.com/openshift/imagebuilder/blob/master/imageprogress/progress.go
btw, that's another example of something that parses the pull output.
Just a couple of comments on this pull...

why not use something like https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/credentialprovider/keyring.go to parse docker configs and narrow down which auths should be attempted.

(line 244) looks like after the first auth failure, you exit the function and never try other auths

(line 244) looks like after the first auth failure, you exit the function and never try other auths

I totally missed that :1st_place_medal:

@pweil- I fixed your recent comments.
@csrwng about the authErr, I changed it to just err as authentication errors are no longer returned from there (This is why we are looking for them in the stream). About using the keyring, correct me I am wrong but thsi is for cases where the proccess lives longer. In our case "image-inspector" is called to pull one image and then goes away so it won't have a use for caching for the authentications.

@enoodle the keyring will narrow down the list of auths for you to use based on your pull spec; imho that seems better than just trying every auth entry from all your dockercfg's. You don't need to use that code exactly, but the approach seems better.

@pweil- PTAL (hopefully last one? ) as I have dealt with the client.PullImage error and the "double" closing of the pipe by putting that call in a go routine and pushing that error to the errors channel.

about the keyring - it looks like what we should be doing, but I prefer adding it in a different PR to keep one subject here.

latest impl looks really clean. LGTM I'm ok with a follow up issue for the keyring

@pweil- since I don't want to fix this more than once I asked @enoodle to look into the keyring now. If it's better and more reliable I'd prefer to go with that.
If not, then we'll go with this.

@enoodle it seems that this is way too large for the 2.1 release.
We'll commit the previous PR (the one @pweil- already acked) and we'll evaluate this for 2.2.

@simon3z I separated to another PR.


GPS is being queried permanently, whether or not it is needed

When LibreTasks is running, it constantly queries GPS, regardless of whether it’s needed for any active rule. I fear this is going to drain the battery pretty quickly.
I suggest requesting GPS location updates only when a location-based rule is active.

After a few weeks of digging through the code, I guess this might be difficult to implement, as location is a default attribute, available with any event, and which can occur in a variety of places:

Location events
Location-based filters
Location being used as an attribute in actions

The first two are probably easy to catch, but getting a list of all rules which use location attributes in their actions might not be doable in a manner that is guaranteed to be work even with future actions.
As a workaround, we might do the following:

Use the passive location provider instead of GPS. This will piggy-back on any other location-aware application—if any other app gets a location, we get a copy of that. Battery drain next to zero, but no guarantee on frequency of events.
Periodically poll location. We could implement this as a rule: on certain events (phone moves to a different cell, once every X minutes, X minutes after last location update, ...), request a location update. This would require new events and a new action. Battery drain can be controlled through the choice of events (and intervals) which trigger location polls.
Let the user select where to get the location from (GPS, network, or the first provider to respond). This could be implemented as a parameter in the location update action.

Any opinions on that?

Just another thought that came to my mind: make the location source configurable via two options in Preferences:

Check box: Use passive location provider (note: enabling this will save battery, but location-based rules may not fire accurately unless another app is currently accessing location information)
Option button: Location provider

GPS
Network
Other location providers present (if any, apart from the passive provider)
Any

If the first option is selected, subscribe (only) to the passive location provider. When a location is received, process it only if it matches the provider selected in the second option (“any” will match any provider).
If the first option is not selected, use the second option to decide which location provider to subscribe to (for “any”, subscribe to all location providers available).
On top of that, we can still implement “request location updates” as an action, potentially with the following parameters:

Request updates from a specific provider (which may be different from the one in Preferences), or from all providers
Unregister location listener after a certain timeout, or upon receiving a location, or through a separate action

Basic functionality (select passive location provider or a specific one) is available in #227 . Changes currently require a restart of LibreTasks (or some way of re-registering with the location provider). The optional parts are not part of the pull request. Default behavior is to use GPS, as before.

@mvglasow Hey, I am interested in using LibreTasks since I am running on an android version with no google services (copperhead). Thank you for addressing this issue. I will experiment with the location trigger, and depending on how it works out I may be looking to contribute some actions / triggers or other help with the project.

Closing as this is fixed in newest release


Support Address Literals

Supporting address literals which are formatted: 0x_____

There should be exactly 40 characters after 0x


Some words are not highlighted when selected in large files

[Enter steps to reproduce:]

Load a large file (My test is 10MB)
Select a highlightable word

Atom: 1.36.1 x64
Electron: 2.0.18
OS: Mac OS X 10.13.6
highlight-selected: 0.16.0
Demonstration video: https://photos.app.goo.gl/Au1vY9cbvBDw5Yi68
Non-Core Packages
atom-material-syntax 1.0.8
atom-material-syntax-dark 1.0.0
atom-material-ui 2.1.3
busy-signal 2.0.1
highlight-selected 0.16.0
intentions 1.1.5
language-log 1.10.1
language-swift 0.5.0
linter 2.3.0
linter-ui-default 1.7.1
minimap 4.29.9
minimap-bookmarks 0.4.2
minimap-cursorline 0.2.0
minimap-find-and-replace 4.5.2
minimap-highlight-selected 4.6.1
minimap-linter 2.2.1
minimap-pigments 0.2.2
minimap-selection 4.5.0
Sublime-Style-Column-Selection 1.7.5

Do you have the status bar enabled? If so you can easily see how many highlights have been added.
There's a setting that limits the number of highlights Maximum Highlights which is defaulted to 500.
See https://github.com/richrace/highlight-selected/pull/193 for motivation.

This makes the plugin essentially useless for too large files. There should be an option to search for occurrences only inside currently visible section of the file being edited.


Navigation made quicker (single page application)

Made changes in the navigation,
AS React is great for single-page applications So I used react-router-dom which was already in use.p
*when we click on the navigation link link the whole website reloads but in react only a component changes which makes tge website faster
Take a look at the changes Here

Issue #140

Great Job! @murtazajoo


fix(#1306): Tooltip react component type fix

Just a PR to merge BUGFIX into alpha

:tada: This PR is included in version 4.13.1-alpha.2 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.13.1 :tada:
The release is available on:

npm package (@BUGFIX dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.14.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.5.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: 返回网卡所在的网络名称信息

这个 PR 实现什么功能/修复什么问题:
返回网卡所在的网络名称信息
是否需要 backport 到之前的 release 分支:

release/2.11

/area region
/cc @swordqiu @yousong

Codecov Report

Merging #3205 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3205      +/-   ##
=========================================
- Coverage    7.15%   7.13%   -0.02%
=========================================
  Files         478     478
  Lines       77222   77245      +23
=========================================
- Hits         5524    5513      -11
- Misses      71235   71270      +35
+ Partials      463     462       -1

Flag
Coverage Δ

#aFlag
7.13% <0%> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/models/networkinterfacenetwork.go
0.84% <0%> (-0.14%)
:arrow_down:

pkg/compute/models/networkinterfaces.go
5.73% <0%> (-0.27%)
:arrow_down:

pkg/cloudcommon/cronman/cronman.go
49.51% <0%> (-5.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3e845...c741f02. Read the comment docs.

/lgtm

/approve


[flutter_tools] convert devtools URL to a better format

Prevents URI escaping from being run over the address in the query parameter.
https://github.com/flutter/devtools/issues/3158

Yeah launching through windows terminal or copy paste works fine, and so does the URL. Are there other workflows that I should verify first?

Yeah launching through windows terminal or copy paste works fine, and so does the URL. Are there other workflows that I should verify first?

No, both of those sound good.


Storage refresh!

Add a method to allow Bucket and File objects to refresh the data from the API.
refs #242

Bucket looks pretty much immutable to me. I was thinking maybe a Bucket's Acl could use refresh!, but it already has it. File definitely can use refresh!. OK to remove Bucket from this issue?

Bucket has data, its just not on the implementation yet. See #91. I say we implement it.

OK, great. So some/all of the mutable attributes in #91 will be on the bucket's @gapi object? In that case I'll go ahead.


Trouble with setting up cloned pserv on cori

I tried to setup a cloned copy of pserv on cori after setting up the stack and got the following:
brycek@cori12:~> source pserv/setup/setup.sh
eups declare: I'm unable to declare Pserv as tablefile ups/Pserv.table does not exist
Unable to find an acceptable version of Pserv

When I went into the setup script and changed the Pserv to pserv throughout then it worked. Is there a reason we have them capitalized? But I've definitely set this up before on my own computer and not had that problem, so I'm not sure if it's something specific about cori?

I should just delete that setup.sh script since it's not being maintained and we never settled on the "right way" to set up packages on eups.  In any case, somehow we got convince that package names should be all lower case because of Mac issues regarding case insensitivity regarding filenames, so I duly changed the filenames in the ups folder, but didn't update that setup.sh script since I never use it and don't really recommend anyone else to either, though ymmv.   In any case, this is a mac vs linux issue.

I pushed the change to master.

Oh, okay. Well, since there is a piece of code in the monitor that needs desc.pserv I will just comment that out for now as a hack.


Add support for Doctrine\DBAL\Platforms\MariaDB1060Platform

Would it be possible to add support for Doctrine\DBAL\Platforms\MariaDB1060Platform?
Thanks

I was trying to solve it directly on vendor code and it seems that works good only adding this:
private function getSpatialPlatform(AbstractPlatform $platform): PlatformInterface
{
if ($platform instanceof MySQLPlatform || $platform instanceof MariaDBPlatform) {
return new MySql();
}
    if ($platform instanceof PostgreSQLPlatform) {
        return new PostgreSql();
    }

    throw new UnsupportedPlatformException(sprintf(
        'DBAL platform "%s" is not currently supported.',
        $platform::class
    ));
}

I just saw that you are working on PR for that. Thanks


Not showing progress barn when using child_process spawn

It is possible to show the progress bar when spawning into another node script that uses cli-progress?

it depends on your architecture, especially the stream/tty forwarding

Ahh. I will investigate streaming/tty forwarding. Thanks!


feat: support ethabi Contract methods

Motivation
Fixes https://github.com/alloy-rs/core/issues/101
Struggling to write tests for load method from ethabi
Solution
Reference from methods from ethabi
PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

value: Error("invalid type: string "address", expected a valid internal type", line: 1, column: 250)'

this seems odd. can you link to the ABI file that you're using for tests?

okay i have tracked this down.

InternalType is deserialized by borrowing data from the deserializer with Visitor::visit_borrowed_str
serde_json::from_reader does not call Visitor::visit_borrowed_str.
Instead it calls Visitor::visit_string which implicitly calls Visitor::visit_str.
Neither of those are implemented for the ItVisitor.
Because the deserializer calls an unimplement vist_ method, it returns the unexpected error, even tho the input is actually expected

@andyrobert3 if you don't mind, I can push a fix to your branch. the fix will be loading the entire file into a string and then chaning to read_string, as well as making serde_json::from_reader always error

sure @prestwich feel free to push!
need to sleep since its a bit late here

cool i pushed. this solves the immediate issue, and should make it clearer for future users :)

needs cargo fmt

@DaniPopes mind re-reviewing with my additions? :)

Was going to work on the requested changes today, but thanks to @prestwich @DaniPopes for reviewing and making the required changes

yeah, hope you don't mind us getting it over the finish line. thank you for your contribution! 🎉


vNext: Expose Source Kind (Hand, controller, voice, etc)

To ensure titles can do the right thing based on the type of source the input came from.
Windows Mixed Reality provides source kinds of:

hand
controller
voice
other

We already do this

Thanks @StephenHodgson, I clearly overlooked that :)


Do not see many Watson nodes

I created an app from the Bluemix Node-RED Starter Boilerplate. In the Node-RED editor I don't see Watson nodes such as AlchemyData News nor Dialog.

Hi,
You have to use the
Watson Node-RED Bluemix Boilerplate: https://github.com/watson-developer-cloud/node-red-bluemix-starter
Just click on the Deploy button.
Enjoy !

Deploy to Bluemix fails with no further information or details.
Project creation failed
Cloning repository...
Configuring pipeline...
Deploying to Bluemix...

It's strange not to see a reason code behind the deployment failure. Check that you still have ample resource allocation to be able to instantiate a new boiler plate. That is memory, services and applications. Then try re-deploying from your clone.

I have a large account with lot of memory and # of services I can provision. Also interestingly, when I try to repeat the deploy process, it would not let me use the app name I chose the previous time. This has happened twice. I cannot see the apps with those names on the dashboard either.

Could be Bluemix residuals getting in the way.

@swamichandra try listing and clearing the app names via cf cli commands!

Check if the bluemix github (Jazz.net) project has been created. The first error message indicates some issues.
You can't create applications with identical names - Check your instances and your Jazz projects.
Cheers
J.

cf apps does not list the apps I tried to create and failed.
As usual and as always JazzHub says "We are currently experiencing problems. We are working the issue, and hope to be back online shortly. Please see our status page for more details."

Is there a option for me to clone this repo and do a cf push from locally?

Hi,
First of all, the one-click Deploy button procedure works fine for me
Please Follow instructions on : https://github.com/watson-developer-cloud/node-red-bluemix-starter
For example, I have created today this instance : http://node-red-watson-ylecleach-0502.mybluemix.net/red/  (I will remove it in one week).
You can also look at the corresponding Labs information : https://github.com/watson-developer-cloud/node-red-labs
If you want to contribute to new nodes on Watson, please refer to  : https://github.com/watson-developer-cloud/node-red-labs/blob/master/CONTRIBUTING.md
Note : it is possible to clone your Node-RED Watson Starter Project locally using git clone, then push it to a new bluemix app instance or to the same. Please describe me your need.
Do not hesitate to give us your feedback.

@swamichandra  : do not hesitate to close this defect is you are able to see Watson nodes. Thank you.

I was able to successfully deploy to an another Bluemix account I had. But I'm still not able to deploy to the other account where I had/have problems. Will investigate further and find out which account setting is causing this to be an issue. Let's close this issue for now.


Optimizations and UX improvements to the dashboard screen

No longer show how many builds a project has. This is expensive and not very useful
Instead, show the date of the last build
Fixes a performance issue affecting the corporate site

Note that I used the HTML5 <time> tag to represent the datetime. This tag has attributes that have a machine readable datetime as well as a title with a precise locale-specific human-readable datetime as opposed to the nebulous "a year ago". I think we should use this convention or something like it more widely.
This PR builds on some optimizations in #5472 and this should be refactored slightly if that is merged first.
Screenshot

I refactored this optimization to be on the manager instead of sprinkled in a few functions.

Seems like a better approach :)


Strict mypy

Description
Run mypy with --strict flag

[ ] Review existing code
[ ] Create new CI

New:

[x] Use double-quotes in the project #68

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/issues/41


Add push to client

Add push command to client. Update dist tool to use client for push.
This is the first update to get the dist tool using the client. Later updates will follow to get the remainder of commands using it.

Waiting on #938 to fix CI for Windows

I just merged #938, you can rebase :+1:

Codecov Report

Merging #937 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #937   +/-   ##
=======================================
  Coverage   59.55%   59.55%
=======================================
  Files           5        5
  Lines         759      759
=======================================
  Hits          452      452
  Misses        199      199
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec5c30...126aa07. Read the comment docs.

Rebased and green!

LGTM

LGTM


Training Issue

Hello @TianzhongSong
generator_output = next(self._generator)

File "/ds_data/C3D-keras-master/train_c3d.py", line 116, in generator_train_batch
x_train, x_labels = process_batch(new_line[a:b],img_path,train=True)
File "/ds_data/C3D-keras-master/train_c3d.py", line 71, in process_batch
img = imgs[symbol + j]
IndexError: list index out of range
Traceback (most recent call last):
File "/ds_data/C3D-keras-master/train_c3d.py", line 180, in
main()
File "/ds_data/C3D-keras-master/train_c3d.py", line 171, in main
validation_steps=val_samples // batch_size,verbose=None)
File "/usr/local/lib/python3.5/dist-packages/keras/legacy/interfaces.py", line 87, in wrapper
return func(*args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/keras/engine/training.py", line 2011, in fit_generator
generator_output = next(output_generator)
StopIteration
Process finished with exit code 1
help me to solve this error <3

Hello @TianzhongSong
generator_output = next(self._generator)
File "/ds_data/C3D-keras-master/train_c3d.py", line 116, in generator_train_batch
x_train, x_labels = process_batch(new_line[a:b],img_path,train=True)
File "/ds_data/C3D-keras-master/train_c3d.py", line 71, in process_batch
img = imgs[symbol + j]
IndexError: list index out of range
Traceback (most recent call last):
File "/ds_data/C3D-keras-master/train_c3d.py", line 180, in
main()
File "/ds_data/C3D-keras-master/train_c3d.py", line 171, in main
validation_steps=val_samples // batch_size,verbose=None)
File "/usr/local/lib/python3.5/dist-packages/keras/legacy/interfaces.py", line 87, in wrapper
return func(*args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/keras/engine/training.py", line 2011, in fit_generator
generator_output = next(output_generator)
StopIteration
Process finished with exit code 1
help me to solve this error <3


bug: unable to install add-on

running composer require silentz/mailchimp gives the error:
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
PHP Fatal error:  Access level to Edalzell\Mailchimp\ServiceProvider::bootConfig() must be protected (as in class Statamic\Providers\AddonServiceProvider) or weaker in /Users/luke/sites/domain.com/vendor/silentz/mailchimp/src/ServiceProvider.php on line 56

In ServiceProvider.php line 56:

  Access level to Edalzell\Mailchimp\ServiceProvider::bootConfig() must be pr
  otected (as in class Statamic\Providers\AddonServiceProvider) or weaker

Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 255

Installation failed, reverting ./composer.json to its original content.

This error still happens after running:
rm -rf vendor composer.lock
composer clear-cache
composer install

What version is it trying to install? The current version doesn't have that method at all?

Version 2.0.4
composer require silentz/mailchimp
Using version ^2.0 for silentz/mailchimp
./composer.json has been updated
Running composer update silentz/mailchimp
Loading composer repositories with package information
Updating dependencies
Lock file operations: 3 installs, 0 updates, 0 removals
  - Locking drewm/mailchimp-api (v2.5.4)
  - Locking silentz/mailchimp (2.0.4)
  - Locking spatie/laravel-newsletter (4.8.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 3 installs, 0 updates, 0 removals
  - Downloading drewm/mailchimp-api (v2.5.4)
  - Downloading spatie/laravel-newsletter (4.8.2)
  - Downloading silentz/mailchimp (2.0.4)
  - Installing drewm/mailchimp-api (v2.5.4): Extracting archive
  - Installing spatie/laravel-newsletter (4.8.2): Extracting archive
  - Installing silentz/mailchimp (2.0.4): Extracting archive

Huh, interesting. My guess is that you are not on PHP7.4 as 2.0.5 was the first version to require that.
Can you do it manually to confirm? Set the constraint to "silentz/mailchimp": "^2.2" in your composer.json then run composer update?

Yes I think you are right:
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - silentz/mailchimp[v2.2, ..., v2.2.4] require php ^7.4 -> your php version (7.3.10) does not satisfy that requirement.
    - Root composer.json requires silentz/mailchimp ^2.2 -> satisfiable by silentz/mailchimp[v2.2, ..., v2.2.4].

Upgrade to php 7.4 and you should be good to go!


Problems in executing the cell of OW_tutorial2.ipynb

Hello,
I am facing problem to execute the following code:
plt.figure(figsize=(12,5))
plt.plot(swdates,swAVG,label='sw',c='red',marker='.',linestyle='-')
plt.plot(aqdates,aqAVG,label='aq',c='blue',marker='.',linestyle='-')
plt.plot(snppdates,snppAVG,label='snpp',c='green',marker='.',linestyle='-')
plt.ylabel('Chl-a (mg/m^3)')
plt.legend()

The return of execution with errors like

TypeError: float() argument must be a string or a number, not 'cftime._cftime.DatetimeGregorian'

Please, help me to fix the issues.
Regards,
Rony

Thanks both, I made the changes to this tutorial.


Fix view definition capture in DataHub for Vertica schemas with uppercase letters

This PR fixes a bug where view definitions were not captured in DataHub when Vertica schema names contained uppercase letters. The table_schema column in V_CATALOG.VIEWS displays schema names exactly as they were created. For example, if a schema was created as CREATE SCHEMA myschema1;, it would be displayed as myschema1, while CREATE SCHEMA mySchema2; would be displayed as mySchema2, preserving the original casing.
The current code compares table_schema using table_schema = lower(any_schema_in_the_database), which causes issues with schema names that have uppercase letters.
This fix updates the query to use lower(table_schema) = lower(any_schema_in_the_database), allowing DataHub to capture view definitions for schemas regardless of whether their names contain uppercase characters.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix libbigquant_avx512.dylib can not find

LGTM

Need to release the nightly AZ that takes this fix; and also backport to BigDL 2.0

Need to release the nightly AZ that takes this fix; and also backport to BigDL 2.0

OK. Will work with @Le-Zheng to AZ and BigDL NB release.


Include example(s)

A working example included in the repository would be very beneficial for users trying to translate their documentation projects.

OK, I'll prepare it.

Done!
Working example is here: https://sphinx-intl.readthedocs.io/en/master/quickstart.html#quickstart-for-sphinx-translation


Enable Rubocop to exclude files based on config

When using --stdin, Rubocop requires that you also pass the associated
file name. ALE was previously passing _ as the filename. By passing
the actual relative path to the file and enabling the
--force-exclusion option, we can get Rubocop to respect excluded files
in the configuration.
Closes #197

Sorry for a bit of delay. This looks good to me. :+1: I'll merge this now.


Avoid redundant bindTexture calls

Only bind a texture if it isn't already bound.

This misunderstands how TexturedBatch works. Did you use the GL profiler and actually see redundant glBindTexture calls? That should not be happening. TexturedBatch only calls bindTexture when it is flushing a batch, and it only flushes a batch when the texture id changes (or when a batch is full).
So unless you're filling up a lot of batches with the same texture, you shouldn't see unnecessary glBindTexture calls. If you are drawing so many quads with the same texture that the batches are getting filled up and flushed and then run again with the same texture, you will see redundant glBindTexture calls, but these should be relatively infrequent. You can switch to TriangleBatch from QuadBatch because the former can send arbitrarily many quads with the same texture whereas the latter is limited by the number of Vector3 uniforms allowed by the driver, due to the way it works.
In any case, the code in your patch is not safe. A TextureBatch does not know what happens to the GPU outside of calls to begin/end and so it always needs to bind its texture at least once on the first flush after a begin. Your code will not work correctly if two or more TexturedBatches are used together because the second one will change the currently bound texture and the first one will still think it has bound the texture.
Use TriangleBatch if you really are seeing redundant glBindTexture in your profile output.


Flatten mod scoping into root

mod scoping is adding an unnecessary level to the mod hierarchy. It is true that the sub-modules are involved in 'scoping', but does that need to be taxonimized into the mod hierarchy? I argue that flattening the mod scoping into the parent mod reduces the complexity of the hierarchy without lossing meaning.

Sorry, I don't think I can agree. There's the two big themes of "actions" and "scoping" to srgn. While those are primarily end user-facing, I agree that doesn't necessarily have to be reflected in the source code, but why not? I don't see how it hurts.
Imports paths like use crate::scoping::scope::ScopeContext; are a bit crappy, I agree. That could be shortened to use crate::scoping::ScopeContext;, for example. However, the other paths make sense to me: there's scoping::regex, so that's clearly for scoping and not an action, or something auxiliary. Now there's just src/regex.rs, which loses that meaning. One could argue: Why not also flatten all actions as well at this point? That would be in the same spirit IIUC, but then it becomes pretty cluttered.
And languages are just a subcategory of scoping, which also makes sense in my mind. For example, it allows us to keep things like LanguageScoper in langs.rs.

Sorry, I don't think I can agree.

No need to be sorry, this is just how I try out ideas. I just make a PR and discuss it with the knowledge that it can be closed. I can handle being told "no" :laughing:

There's the two big themes of "actions" and "scoping" to srgn. While those are primarily end user-facing, I agree that doesn't necessarily have to be reflected in the source code, but why not? I don't see how it hurts.
Imports paths like use crate::scoping::scope::ScopeContext; are a bit crappy, I agree. That could be shortened to use crate::scoping::ScopeContext;, for example. However, the other paths make sense to me: there's scoping::regex, so that's clearly for scoping and not an action, or something auxiliary. Now there's just src/regex.rs, which loses that meaning. One could argue: Why not also flatten all actions as well at this point? That would be in the same spirit IIUC, but then it becomes pretty cluttered.

And languages are just a subcategory of scoping, which also makes sense in my mind. For example, it allows us to keep things like LanguageScoper in langs.rs.

The translation of taxonomic subcategories into namespaces is what I'm questioning.
But this is a suggestion, not something I feel strongly about.
The lang mod doesn't add value for me. LanguageScoper can just as easily live in scoping.rs and make as much sense.
If you apply the moduly_name_repetition clippy strictly. Types should not use the mod name as a prefix or postfix.
I take the view that the lang::LanguageScoper mod name repetition is a hint that it's in an overly specified/taxonimized namespace.
Maybe we could flatten langs into scoping?
If not, then I'll close the PR.


Text input filtering on a controlled component is difficult to edit middle text

What version of React-Table are you using?
6.7.6
What bug are you experiencing, or what feature are you proposing?
Text input filtering on a controlled component, when you try to edit the middle area of the text the cursor jumps to the end after the first char.
Example: https://react-table.js.org/#/story/controlled-component
Type a word "brother"  and move text cursor to after the b..  then delete the r and notice the text cursor jump to the end.

You really need to implement a specific component to do the editing for your own use-cases.  Using the example in the docs for production is not recommended.  That is because it uses the SAME state as ReactTable and therefore controlled changes to the input will cause ReactTable to refresh as well as the content in the input.  If you make a specific component with it's own state and then handle a callback when the data is ready to process then this issue will not happen.