23 simplecode not giving correct pure errors for edge case

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.25 :warning:

Comparison is base (758fda0) 95.68% compared to head (60a6594) 95.44%.

:exclamation: Current head 60a6594 differs from pull request most recent head 7d7b4a2. Consider uploading reports for the commit 7d7b4a2 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   95.68%   95.44%   -0.25%
==========================================
  Files          13       12       -1
  Lines        1276     1185      -91
==========================================
- Hits         1221     1131      -90
+ Misses         55       54       -1

Impacted Files
Coverage Δ

src/code_functions.jl
96.90% <100.00%> (-0.17%)
:arrow_down:

... and 11 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Crash when quickly creating sections while memory map is open

Version and Platform (required):

Binary Ninja Version: 3.6.4753-dev

Steps:

Open memory map
Run this in console:

for i in range(12):
    bv.add_user_section(name=f's{i}', length=1, semantics=1, start=i)

Fixed in 3.6.4754-dev


fix: add

resolves #1729
Checklist for profile addition

[ ] Name the PR fix: add <your-username>.
[ ] You've added file named your-username.json in the profiles directory.
[ ] You've linked the PR to the correct issue.

Other additions/changes

[ ] Changes made in this PR are mentioned below
[ ] Search previous suggestions before making a new one, as yours may be a duplicate.
[ ] I acknowledge that all my contributions will be made under the project's license.
[ ] I've read the contributing guidelines

This PR adds/fixes

Notes

hey can i know when was my pr are going to be merged?

hey can i know when was my pr are going to be merged?

It will be merged once two or more maintainers approve the PR. 🙂


add_two_matrix

add two matrix
Why:

Closes #ISSUE_NUMBER
What's being changed:

Please, make a reference to the issue you're trying to solve.


Do not allow "system" groups to be deleted

The "admins", "billing-admins", "clients" and "users" groups should be treated as "system" groups and should not be able to be deleted.

https://github.com/chef/chef-manage-issues/issues/62

@jeremiahsnapp Thanks for filing this.  It looks like it has also been filed here: https://github.com/chef/chef-server/issues/123 along with some implementation advice.  I'm going to close this version out so we only have to track it in one place.
Thanks again!


View nearby essentials not working

Describe the bug
View nearby essentials is not working.
To Reproduce
Steps to reproduce the behavior:

Go to Essentials
Click on View Nearby essentials
Nothing comes up

Expected behavior
Should work as before
Screenshots

/claim

It seems the import from Leaflet is wrong. I will fix this and send a PR

Seems obsolete now that Essentials was removed


Using the in box omnisharp for integration tests

How is this the "in box" OmniSharp. The version listed in the package.json is 1.30.1

I initially started with that, but then later we switched to the more recent versions. Apologies for the confusion.

FWIW, PR titles are editable. :smile:


Monitor Data Status

I am new to using docker and kafka connect. Now I am creating my own kafka cluster and kafka connect cluster on the local machine with docker compose.
Here is the scenario, I am using JDBC connector to connect from DB2 DB to Oracle DB and sync up my data. The volume of the data can be more than 10 million, so after generating the source & sink connector, how to check/monitor/verify if all the data(e.g. 10 million data) move into topics properly and move out to sink DB properly without any error.
If there is any error, for example, missing some data, how may I identify that data?
I know this might be some very easy questions, but again, I am very new here, so please share the idea. Thanks

Out of scope for this project, sorry


When previous check is killed, following check fails

When you trigger two checks quickly, for example by opening a file, entering a space (which seems to trigger an instance check) and then saving immediately (triggering another), it kills the first check, but then the new check also fails due to the output from Phpstan about the previous one failing.
[file-watcher] Document changed, checking
[check:10] Check started for file:///x.php
[check:10] Spawning PHPStan with the following configuration:  {"binCmd":"x/vendor/bin/phpstan","args":["analyse","-c","x/phpstan.neon","--error-format=raw","--no-interaction","--memory-limit=1G","--no-progress","x.php","-a","tmpx/autoload.php","-c","tmpx/config.neon"]}
[file-watcher] Document changed, checking
[check:11] Check started for file:///x.php
[check:10] Check completed for file:///x.php errors= {}
[file-watcher] Document changed, checking
[file-manager] Not checking file "file:///x.php", file check is pending (checkId=11)
[file-watcher] Document saved, checking
[file-manager] Not checking file "file:///x.php", file check is pending (checkId=11)
[file-watcher] Document active, checking
[file-manager] Not checking file "file:///x.php", file check is pending (checkId=11)
[check:11] Spawning PHPStan with the following configuration:  {"binCmd":"x/vendor/bin/phpstan","args":["analyse","-c","x/phpstan.neon","--error-format=raw","--no-interaction","--memory-limit=1G","--no-progress","x.php","-a","tmpx/autoload.php","-c","tmpx/config.neon"]}
[check:11] PHPStan process exited with error  filteredErr=PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 57 MB of memory.
To avoid this issue, allow to use more memory with the --memory-limit option.  rawErr=PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 57 MB of memory.

To avoid this issue, allow to use more memory with the --memory-limit option.
  data=
[check:11] Check completed for file:///x.php errors= {}

Ah good find. Will fix this as soon as I get the chance. Thanks for the detailed report!

I'm having a bit of a hard time reproducing it but I'm pretty sure I've got a good fix for it. Could you try out the attached .vsix file? Because github does not allow uploading of .vsix files I've renamed it to .zip. Just rename it and drop it into VSCode. Thanks!
phpstan-vscode-2.2.14.zip

I'll be publishing the fix (even though it's untested) because I'd rather potentially fix it than wait for a response. Please let me know if you get around to testing it again to verify that it worked.


MissionPlanner SILT

Greetings,
I've set up a SITL, Mavproxy and MissionPlanner on my kali Linux machine(debian) and when I run all of them I find that i am able to connect the "dronekit-sitl copter --home=35.9835973,-95.8742309,0,180
",  with the "mavproxy.py --master tcp:<IP_ADDRESS>:5760 --out udp:<IP_ADDRESS>:14551 --out udp:<IP_ADDRESS>:14550" but the MissionPlanner is unable to detect the "Mavlink". And to make matters worst every time i try to download the "Multirotor" "hexa" firmware in the "Simulation" tab I get the following popup error: "Failed to start the simulator System.componentModel.Win32Exception(0x80004005): Access denied"
which in the Terminal is translated into below:
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/ArduCopter.elf
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/ArduCopter.exe 26/09/2019 18:00:54 vs 26/09/2019 19:05:14
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/cyggcc_s-1.dll
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/cyggcc_s-1.dll 26/09/2019 18:00:56 vs 26/09/2019 19:05:15
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/cygstdc++-6.dll
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/cygstdc++-6.dll 26/09/2019 18:00:56 vs 26/09/2019 19:05:17
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/cygwin1.dll
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/cygwin1.dll 26/09/2019 18:00:56 vs 26/09/2019 19:05:24
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/sim_vehicle.py
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/pysim/vehicleinfo.py
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/default_params/copter.parm
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/default_params/copter-hexa.parm
INFO MissionPlanner.Utilities.Download - OK
xdg-open: unexpected option '-Mhexa'
Try 'xdg-open --help' for more information.
CustomMessageBox thread calling Base Thread
CustomMessageBox thread running Base Thread
And When I try to "install firmware" the "copter 3.6.10 Official"  I get the following error: "Failed to download new firmware : System.UriFormatException: Invalid URI: The URI is empty.
I am quite experienced on python and just recently found myself, hooking my attention into A.I development, hopefully I can leave my contribution to the world with respect to Drone Automation missions in the near future. But i need to know if this issue I am having is related to the choice on OS(kali linux) or a minor configuration issue?
Thank you in advance for you Attention
sitl_mavproxy_missionplanner setup.txt

neverminde turns out that i was suppose to use port 14551 and not 14550

Greetings,
I've set up a SITL, Mavproxy and MissionPlanner on my kali Linux machine(debian) and when I run all of them I find that i am able to connect the "dronekit-sitl copter --home=35.9835973,-95.8742309,0,180
", with the "mavproxy.py --master tcp:<IP_ADDRESS>:5760 --out udp:<IP_ADDRESS>:14551 --out udp:<IP_ADDRESS>:14550" but the MissionPlanner is unable to detect the "Mavlink". And to make matters worst every time i try to download the "Multirotor" "hexa" firmware in the "Simulation" tab I get the following popup error: "Failed to start the simulator System.componentModel.Win32Exception(0x80004005): Access denied"
which in the Terminal is translated into below:
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/ArduCopter.elf
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/ArduCopter.exe 26/09/2019 18:00:54 vs 26/09/2019 19:05:14
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/cyggcc_s-1.dll
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/cyggcc_s-1.dll 26/09/2019 18:00:56 vs 26/09/2019 19:05:15
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/cygstdc++-6.dll
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/cygstdc++-6.dll 26/09/2019 18:00:56 vs 26/09/2019 19:05:17
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/cygwin1.dll
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/cygwin1.dll 26/09/2019 18:00:56 vs 26/09/2019 19:05:24
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/sim_vehicle.py
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/pysim/vehicleinfo.py
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/default_params/copter.parm
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/default_params/copter-hexa.parm
INFO MissionPlanner.Utilities.Download - OK
xdg-open: unexpected option '-Mhexa'
Try 'xdg-open --help' for more information.
CustomMessageBox thread calling Base Thread
CustomMessageBox thread running Base Thread
And When I try to "install firmware" the "copter 3.6.10 Official" I get the following error: "Failed to download new firmware : System.UriFormatException: Invalid URI: The URI is empty.
I am quite experienced on python and just recently found myself, hooking my attention into A.I development, hopefully I can leave my contribution to the world with respect to Drone Automation missions in the near future. But i need to know if this issue I am having is related to the choice on OS(kali linux) or a minor configuration issue?
Thank you in advance for you Attention
sitl_mavproxy_missionplanner setup.txt

Greetings,
I've set up a SITL, Mavproxy and MissionPlanner on my kali Linux machine(debian) and when I run all of them I find that i am able to connect the "dronekit-sitl copter --home=35.9835973,-95.8742309,0,180
", with the "mavproxy.py --master tcp:<IP_ADDRESS>:5760 --out udp:<IP_ADDRESS>:14551 --out udp:<IP_ADDRESS>:14550" but once MissionPlanner is detects the "Mavlink". I am unable to download the "Multirotor" "hexa" firmware in the "Simulation" tab I get the following popup error: "Failed to start the simulator System.componentModel.Win32Exception(0x80004005): Access denied"
which in the Terminal is translated into below:
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/ArduCopter.elf
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/ArduCopter.exe 26/09/2019 18:00:54 vs 26/09/2019 19:05:14
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/cyggcc_s-1.dll
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/cyggcc_s-1.dll 26/09/2019 18:00:56 vs 26/09/2019 19:05:15
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/cygstdc++-6.dll
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/cygstdc++-6.dll 26/09/2019 18:00:56 vs 26/09/2019 19:05:17
INFO MissionPlanner.Utilities.Download - http://firmware.ardupilot.org/Tools/MissionPlanner/sitl/cygwin1.dll
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - got LastModified /home/dragoon/Mission Planner/sitl/cygwin1.dll 26/09/2019 18:00:56 vs 26/09/2019 19:05:24
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/sim_vehicle.py
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/pysim/vehicleinfo.py
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/default_params/copter.parm
INFO MissionPlanner.Utilities.Download - OK
INFO MissionPlanner.Utilities.Download - https://raw.githubusercontent.com/ArduPilot/ardupilot/master/Tools/autotest/default_params/copter-hexa.parm
INFO MissionPlanner.Utilities.Download - OK
xdg-open: unexpected option '-Mhexa'
Try 'xdg-open --help' for more information.
CustomMessageBox thread calling Base Thread
CustomMessageBox thread running Base Thread
And When I try to "install firmware" the "copter 3.6.10 Official" I get the following error: "Failed to download new firmware : System.UriFormatException: Invalid URI: The URI is empty.
I am quite experienced on python and just recently found myself, hooking my attention into A.I development, hopefully I can leave my contribution to the world with respect to Drone Automation missions in the near future. But i need to know if this issue I am having is related to the choice on OS(kali linux) or a minor configuration issue?
Thank you in advance for you Attention


Randomize feature for spectra

Added --randomize as an optional arg for spectra, and added a few lines of code within the spectra command to randomly allocate a variant to one of the haplotypes that harbor it

looks good to me


Faster even/odd check with bitwise operator

No need to use Math.abs() to extend logic to negative numbers and after that check using the modulo (%) operator.

Sorry, I will create a new one following the contribution guide :)


fix a typo dont -> dont't

fix a typo in line 252: dont -> don't
Signed-off-by: yeya24<EMAIL_ADDRESS>

Thanks


[feature] Puppetfile module substitution

So I've got a Puppetfile full of links to private copies of public modules referenced off an internal git server that I don't have access to at all.
What do you think of adding a feature where I can substitute back the public module or a local copy somehow?  Eg
Given something like:
hiera,
  git => 'https://git.megacorp.com:9999/scm/puppet/hiera.git',
  ref => '2.3.0

I'd like to be able to easily substitute in the upstream module, maybe by a symlink?  That way I can test without changing the Puppetfile.  I think this would have to be done module-by-module rather then inferred automatically but would be very handy

@GeoffWilliams You can specify a custom Puppetfile to use, would maintaining a "testing" Puppetfile work?

I think that will do what I want for the moment - cool!


Remove prefer_gems_rb setting

What was the end-user problem that led to this PR?
The problem was that we currently have a feature flag and setting, prefer_gems_rb, that currently does very very little, and it's not worth the maintenance cost in my opinion.
What was your diagnosis of the problem?
My diagnosis was that the only situation where this setting makes a difference at the moment is when a project has both a Gemfile and a gems.rb file. In that case, if prefer_gems_rb is enabled, the warning will tell the user to remove the Gemfile because it's being ignored, whereas if not enabled, it will tell the user to remove the gems.rb file because it's being ignored.
I think this setting might've made sense when we actually planned to really deprecate Gemfile's in the short term. Since I think we're not planning to deprecate Gemfile's at the moment, I think it's better to remove the setting.
What is your fix for the problem, implemented in this PR?
My fix is to remove the setting and keep supporting both names. In the weird case of both types being found in the same project, always prefer gems.rb and tell the user to remove the Gemfile.

seems like the right approach to me 👍
@bundlerbot r+


Undefined variable appears when deleting variable and changing sprites

Expected Behavior
No undefined variables
Actual Behavior
undefined variable appears
Steps to Reproduce

Go to Data. Create a variable.
Drag "set x to" block to workspace
In the dropdown, delete variable
You can also delete variables by right clicking on them in the flyout and choosing delete

all appears well

Add a new sprite or change to the costume tab
Return to the first sprite or the blocks tab

There is now a variable called "undefined"
Operating System and Browser
Windows 10 Chrome

The reason this is happening is because the monitored block for the variable reporter is not being deleted when the variable is deleted. The VM is actually running the opcode for getVariable, which runs a lookupOrCreateVariable, emphasis on the Create part. The variable was deleted but then re-created. vm/scratch3_data.js only passes the variable ID to lookupOrCreateVariable, which is what causes the variable name to appear as undefined.

@fsih we should move this issue to VM because it is only a vm problem, not scratch-blocks.

Moved to https://github.com/LLK/scratch-vm/issues/775. Thanks for investigating!


"time" command exists in Windows

There is a native time command in Windows to set the system time.  It is overridden in PowerShell but not in cmd. Maybe you could make a second shim with a different name as well.

Thanks for reporting this problem. You can use timecmd in cmd.exe now.


updated the UI with the new EXO resources

Pull Request (PR) description
updated EXO resources possible selection in the UI. We require it because we parse the ...GUI.psm1 file to get the resource display names.
I moved the EXO panel a bit above because there was free space, the panel was getting a bit high to display everything on normal monitor resolutions.
This Pull Request (PR) fixes the following issues
None

This change is

Codecov Report

Merging #386 into Dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              Dev     #386   +/-   ##
=======================================
  Coverage   90.24%   90.24%
=======================================
  Files          91       91
  Lines        9834     9834
  Branches       10       10
=======================================
  Hits         8875     8875
  Misses        949      949
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ce08df...9e85999. Read the comment docs.

I will approve the PR, and then submit another one myself, with the items sorted alphabetically and with the newly merged resources in there as well.


Issue #45 permission docs

Fixes #45
Description

Update docs to use more restrictions when using permissions

Use current logic and cdn.deno.land to get latest std release. The reason for this was we don't have to add 'raw.githubusercontent' into the --allow-net permission. Plus, the cdn provides the latest std version so the logic was pretty just pointless extra code

Other Notes

I would need to update dmm on website after this

The tests fail because the installation of the latest dmm release still needs access to raw.githubusercontent. Should i remove this bit from the ci? as it doesn't reflect PR's but just shows installing dmm works. Otherwise, it would show our ci fails, but the ci would pass after a new release

looks like this branch needs to be updated before being merged

btw, im pushing the docs related to this issue to staging

Np, i'll probs leave it (merging) until #62 is merged cause theres gonna be more conflicts


 window splitting not working for me

Hi, I purchased the pre-order $35 version and I'm on 0.4.0 OSX, for some reason I am not able to use Ctrl-w to instigate any window splitting commands. Other Ctrl commands such as Ctrl-v seem to work fine for me

Hi @davidwilde - thanks for logging the issue (and for supporting the project!)
Indeed, this looks like a bug - both the of those shortcuts to open a vertical and horizontal split are not hooked up. I think these is something in our transition of the window-management logic. Should be a straightforward fix.


ASU-1554: Fix reservation transfer to another customer

Fixed reservation transferring, which was broken because of a minor bug in reservation metadata handler field populating that managed to slip through when that same thing was fixed for other parts of the system a while ago.
This PR also includes a somewhat related fix to tests, which makes them test salesperson users better (this would have caught the bug).

Codecov Report

Merging #266 (e524b48) into develop (00cd329) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #266   +/-   ##
========================================
  Coverage    93.35%   93.35%
========================================
  Files          118      118
  Lines         4212     4212
  Branches       373      373
========================================
  Hits          3932     3932
  Misses         205      205
  Partials        75       75

Impacted Files
Coverage Δ

application_form/services/reservation.py
100.00% <ø> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


After reboot Flynn not starting up

Hi Guys,
Problem with our FLynn cluster after reboot. It is not starting up again.
Flynn-host ps gives us this:

As it is a production server, we really need this thing up again..

Try running flynn-host fix --min-hosts=N where N is the number of hosts in the cluster.

Kill your memory processess and then reboot.

It is up and running again!
Thanxs so much for your help in IRC @lmars 👍


Refactoring the Transaction class.

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
✔

Fixed issues

Not going to change the level for now. Thanks for suggestion though.


[Bug]: Error when editing project properties: the Parent project field is always filled with the value: “default” and an error occurs when saving.

Apache Hop version?
2.9.0
Java version?
jdk-22
Operating system
Windows
What happened?
When you want to update the properties of a project, the value “default” is systematically added to the project parent inherit... field. And an error appears when you save

Issue Priority
Priority: 3
Issue Component
Component: Hop Gui, Component: Metadata

I think this is a problem on multiple locations. Someone wanted to remove a non existing Execution information location and had a similar problem.


Open standards lightbox not working when website is in french

If you go on "normes-ouvertes.html"and click on the"Représentation de la date et l'heure" standard, the lightbox won't show up.

Peut-être à cause de l'accent.
The id used is représentation-de-la-date-et-de-l-heure maybe it does not work with the lightbox

You were right, the accent is the problem.

This bug is site wide.  We should look at using slugify: "latin"
https://jekyllrb.com/docs/liquid/filters/


fix(sse/stream_access_logs): handle invalid log

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[x] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes
Because we log the URL path in Fastly logs, if someone is hitting an invalid URL, we receive logs that are invalid. This pull request addresses this by logging them as warnings and moving on to the next row.
How did you test this code?

Updates unit test case to include invalid log

Codecov Report
Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (f88f334) 95.94% compared to head (590d3e4) 50.99%.
Report is 10 commits behind head on main.

Files
Patch %
Lines

api/tests/unit/users/test_unit_users_models.py
0.00%
43 Missing :warning:

api/features/import_export/views.py
45.45%
6 Missing :warning:

api/features/import_export/permissions.py
28.57%
5 Missing :warning:

api/features/import_export/tasks.py
33.33%
4 Missing :warning:

api/integrations/rudderstack/rudderstack.py
50.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3307       +/-   ##
===========================================
- Coverage   95.94%   50.99%   -44.95%
===========================================
  Files        1067     1001       -66
  Lines       32613    29555     -3058
===========================================
- Hits        31291    15073    -16218
- Misses       1322    14482    +13160

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Force stopping apps stops microG services

System: Android 6.0.1 with current nightlies installed as system apps.
I'm not quite sure, if this can be seen as a bug of microG, or is connected to the force close function.
Force stopping certain apps leads to a complete shutdown of the microG services. Afterwards a check-in or a reboot are necessary to initiate the heartbeat again.
All of these apps seem to have the location permission in common and it doesn't matter, if it is granted.

log for com.appgenix.bizcal: http://hastebin.com/xecahejufo.vhdl
log for com.google.android.apps.maps: http://hastebin.com/oyilacezad.vhdl
the same happens with de.wetteronline.wetterapp and probably others

Is this a CM or other custom ROM? How do you force close (In Settings>Apps or using a ROM specific feature)?
Killing an app should not cause microG to be killed as well, but according to your logs this happens. It does not happen on my system (which is Android 6.0).
When you force close microG it will not be able to heartbeat or receive push messages anymore.

Hi mar-v-in,
it is a custom ROM (minimal OS) and apps can be force closed by holding the back button for few seconds. The function needs to be enabled in the developer options first.
Stopping these apps via App Info doesn't kill the microG services, you are right.
I will stick to the official method then.

As you mentioned this to be a custom ROM specific feature, you might want to report it to the custom ROM. Closing here.


Allow quoted display name in address to end with a non-usascii part.

Right now the address:
"Marc André"<EMAIL_ADDRESS>comes out in the header as:
=?UTF8?Q?=22Marc_Andr=C3=A9=22_<marc@test.lindsaar.net>?=
This fixes it so it comes out correctly as:
=?UTF-8?B?TWFyYyBBbmRyw6k=?=<EMAIL_ADDRESS>I would have liked to write a spec expressing just this, but I could not find the right place for it.

Awesome! Thanks!


Get trades invalid symbol

Hi, I'm using your official client(v1.2.5) to retrieve recent trades from test-net.
This is my code:
var clientFactory = BybitApiClientFactory.newInstance(apiKey, apiSecret, BybitApiConfig.TESTNET_DOMAIN, true);
        var marketApiClient = clientFactory.newMarketDataRestClient();
        var request = MarketDataRequest.builder()
                .category(CategoryType.LINEAR)
                .symbol("BTCUSDT")
                .limit(1)
                .build();

        var response = marketApiClient.getRecentTradeData(request);
        log.info("response: {}", response);

And get in response:
{retCode=10001, retMsg=params error: symbol invalid, result={category=, list=[]}, retExtInfo={}, time=1717486429851}

Another API requests work fine with the same symbol.
Probably it's server side issue. Could somebody verify?

answered by case, will release a new version this week


sbt 1.8.1

Hi @domdorn,
Thank you for your contribution! We really value the time you've taken to put this together.
We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:
https://www.lightbend.com/contribute/cla

I did sign the CLA..


msgpack-cxx: 6.1.1 -> 7.0.0

Includes fixes for GCC 14. Has a breaking revert of a change from 2022 to how floats with no fractional component are serialized. Can’t test whether FoundationDB still builds until the OpenJDK 8 build is fixed, although our version is pretty outdated anyway so hopefully nobody is deploying it.

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Duplicate of https://github.com/NixOS/nixpkgs/pull/353400, which contains a fix for foundationdb.

Sorry for missing that!


UI License Agreement Screen

Completed

@hashirshoaeb this is a screen or a bottom sheet?

Its a full screen bottom sheet


SEOImprovements: User Story 1549065, Part 3

@damabe : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@aahill These are the articles (where you're listed as author) that I've updated for the SEO title metadata improvement story (https://dev.azure.com/mseng/TechnicalContent/_workitems/edit/1549065). They are ready for your review. Please let me know of any changes you'd like me to make.
Also: @carmonmills @KarlErickson @kasangi

Thanks @damabe these changes look good. Could you change the ms.date value as well? Thanks!

Looks good to me.

Closing and replacing with a PR in the private repo: MicrosoftDocs/azure-docs-pr#82978.


Jshint 2.9.1

It would be nice to have Jshint 2.9.1. Some things seem to have been fixed so that brackets-jshint gives different result than the new jshint.
I tried to only replace the jshint.js in the extension but it did not work. Then I saw something about monkey-patch of jshint in a previous commit. Would be nice to help with a pull request, but don't know where to start and why it is not just to replace the jshint.js file.

Next time I do another update I'll update the library. Unless someone else
does a PR first.
On Tue, Feb 2, 2016 at 9:46 AM, hacker112<EMAIL_ADDRESS>wrote:

It would be nice to have Jshint 291 Some things seem to have been fixed so
that brackets-jshint gives different result than the new jshint
I tried to only replace the jshintjs in the extension but it did not work
Then I saw something about monkey-patch of jshint in a previous commit
Would be nice to help with pull request, but don't know where to start and
why it is not just to replace the jshintjs file
—
Reply to this email directly or view it on GitHub
https://github.com/cfjedimaster/brackets-jshint/issues/85.

--
Raymond Camden, Developer Advocate for MobileFirst at IBM
Email<EMAIL_ADDRESS>Blog : www.raymondcamden.com
Twitter: raymondcamden

There seems to be a huge difference between the release 2.7.0 (repo/dist/jshint.js) https://github.com/jshint/jshint/releases/tag/2.7.0 and the 2.7.0 in used here. Why is it so? Is it take from somewhere else?

No idea. I normally grab from jshint's repo.  Would
gladly take a PR that would fix it and get it to 2.9.1 or latest. :)
On Fri, Mar 4, 2016 at 2:10 AM, hacker112<EMAIL_ADDRESS>wrote:

There seems to be a huge difference between the release 2.7.0
(repo/dist/jshint.js) https://github.com/jshint/jshint/releases/tag/2.7.0
and the 2.7.0 in used here. Why is it so? Is it take from somewhere else?
—
Reply to this email directly or view it on GitHub
https://github.com/cfjedimaster/brackets-jshint/issues/85#issuecomment-192175300
.

--
Raymond Camden, Developer Advocate for MobileFirst at IBM
Email<EMAIL_ADDRESS>Blog : www.raymondcamden.com
Twitter: raymondcamden

After finding that monkey patch that was needed it works :)
First I compared with 2.7 instead of 2.8 that was the last updated version. But when I compared the original to the monkey patched 2.8 I found the monkey patch and was able to add the same patch to 2.9.1.


Optionally show streaming url of the station currently played

Optionally show streaming url of the station currently played.

we can do that from the runtime commands. otherwise the UI will get ugly

will work on this

Thank you very much. I forgot to say - radio-active is in the current very mighty and really nice! Thanks. The "streaming url" request is "low prio" for me.

+1

will be available on 2.8.1

implemented. type "i' on runtime


How to use DevTools

Hello!
I have a problem. The lines only appear if I move the window and the scroll does not work correctly. I show you in this gif:

Thank you so much!

Hi @carolinarjona, thank you for the comment.
Nobody can find bugs in your code without reading the code, then I infer it.
Maybe you did make the lines before the elements are not rendered (positioned) yet.
Without reference to LeaderLine, when you develop something with web browsers, you should use DevTools of web browsers.
You can use it for checks above also. For example, write debugger statement at a breakpoint that you want to check.
debugger;
const line = new LeaderLine(document.querySelector('.card-1'), document.querySelector('.card-2'));

If you are using modern browser, the running is paused at the break point, and you can check the elements and you can do more in DevTools of your browser.
For example, input document.querySelector('.card-1') into "Console" (not console.log()), and push Enter key.
For test, wrap the code with setTimeout, for example, replace the code new LeaderLine(...) with setTimeout(() => { new LeaderLine(...); }, 400).
Also, it seems that the lines were added to another window (frame) from the window that has the elements.

Thanks!
I don't realize than I was using the 'leader-line-new' library to import easily in Angular (because I can't use the 'LeaderLine.positionByWindowResize = false' if I use 'leader-line-new' 🤪) and that's the problem buuuuut if I delete it and I use only the 'leader-line' I have the LeaderLine is not defined problem. I did it in Stackblitz (https://stackblitz.com/edit/angular-ivy-zsiwjm) and works fine but I can't recreate in my business project and I did the same but doesn't work 😢

Install library
Import the script in the index.html and in the angular.json
Declare var LeaderLine: any.

Sorry, my English is poor.
Do you mean that you are using "'leader-line-new" library?
If so, I don't know that library, sorry.

No reply came, then this abandoned issue is closed.


Using dependencies from viz.yaml (2)

The viz[['depends']] needs a bit of love to make it work for the script pattern we have.  Currently there are two ways to access something from depends:
process.timeAndMap <- function(viz) {
  timeData <- readData(viz[['depends']][1])
  mapData <- readData(viz[['depends']][2])
}

or if yaml looks like
-
  id: myProcess
  processor: timeAndMap
  depends: [ "firstDependency", "myDependency" ]
  timeData: firstDependency
  mapData: myDependency

then script can do something like:
process.timeAndMap <- function(viz) {
  timeData <- readData(viz[['timeData']])
  mapData <- readData(viz[['mapData']])
}

neither are very satisfying, as well as needing to call readData from script rather than having it at the ready.  So a couple topics of discussion:

Should we switch depends to a named list so code ends up looking like second script without duplication of ids?
Should data be read in automatically so script does not need to call readData() directly? (I don't think this is the main issue, but worth discussing)
Do we want to formalize in some way the second approach that the depends section isn't even required? (I'm thinking here maybe we replace all references with a sigil that denotes a dependency so we can still build our dependency graph; this would look something like @id, &id, or !id).
Are there other things here that I'm missing, what is the natural approach for using dependencies?

Maybe a bad idea (although not sure why), but what about keeping the dependencies with the code somehow and leaving them out of the yaml, kind of like #' @importFrom pkg fnc
something like
myfun <- function(viz){
    depends("firstDependency", "myDependency")
    time.range <- range(firstDependency)
    return(time.range)
}

Agreed, @jread-usgs - I like the idea of keeping dependencies with the code wherever possible.
Something that I haven't fully understood is why the viz[['depends']][1] paradigm rose to the top. Would you do it differently if I told you that
pd <- readData('precip-data')

also works? When I was sketching out pieces of vizlab this summer I had something more like this in mind:
processData.mungePrecip <- function(viz, precip_data=readData('precip-data')) {
  ...code using precip_data...
}

you still currently have to copy the dependencies from the function argument list over to viz.yaml (maybe that could be fixed) but even now I think I'd find it easier to use names in both places rather than using dependency indices within the function.

see also #94 and #82

  id: myProcess
  processor: timeAndMap
  depends: [
        - timeData: "firstDependency"
        - mapData: "myDependency" ]

This might just work!

can use what @jiwalker-usgs  showed in top comment.
can try what @ldecicco-USGS showed in comment 2 up from this
2a) Might need a little function to get the depends back into the vector

@wdwatkins will try 2) and 2a) first.

I think it is just working 🎉

id: matthew-flowlines
location: cache/matthew-flowlines.rds
processor: flowlines
scripts: scripts/process/process.flowlines.R
reader: rds
depends:
flow: "flowlines"
counties: "matthew-counties"

counties <- readData(viz[['depends']]$counties)
flowlines <- readData(viz[['depends']]$flow)

I think we'll only need to do this when there are multiple depends that need to be referenced by name inside a function.  It shouldn't matter in the publish sections when all the dependencies just need to be there.

☝ note that the indent for the two depends is getting erased by github

Would be good to test this more though to be sure

example illustrating jread's comment at https://github.com/USGS-VIZLAB/water-use/pull/17#discussion_r90333807, about an issue that i also find confusing:
viz.yaml:
process:
  -
    id: calc-waterData
    location: cache/wuClean.rds
    ...etc...
visualize:
  -
    id: wuBars
    depends:
      waterUse: calc-waterData
    ...etc...

the names that get assigned are the right-hand sides, and the viz IDs that get read are the right-hand sides. that seems strange to me - what's the point of the secondary IDs if they get ignored by readDepends?
viz <- getContentInfo('wuBars')
deps <- readDepends(viz)
names(deps)
[1] "calc-waterData"

it's also confusing because if i wanted to use readData instead of readDepends, i'd refer to the other id:
wu1 <- readData(viz[['depends']][['waterUse']])
wu2 <- readDepends(viz)$'calc-waterData'
all.equal(wu1, wu2)
## TRUE

wu1 and wu2 are the same, but i've had to refer to them by different IDs. is that really what we want?

Well, I for one had never heard of the function readDepends until today. I don't really care if we name the depends arguments in the viz.yaml for using readData, or don't and use readDepends. As long as I never again have to count and re-count what argument in depends I'm trying to use.

yeah, I think you are right, this seems backwards and I didn't look at it close enough.  The correct usage should be (for this example):
wu2 <- readDepends(viz)[['waterUse']]

at least that's how it is in my head

ohh...that's another handy looking function getContentInfo!

yeah, the internal documentation might not lead you to some of these functions

Was this ever addressed?

I think it can be called done, it will come up again if we aren't handling this right.


Calling MessageManager.displayMessage with reactNode throws an error

Describe the bug
MessageManager.displayMessage throws an error when reactNode is specified as a message.
To reproduce
Call MessageManager.displayMessage with reactNode as a message.
const reactNode =
Test
;
const message = new ReactNotifyMessageDetails(OutputMessagePriority.Info, { reactNode }, undefined, OutputMessageType.Sticky);
const displayedMessage = MessageManager.displayMessage(message);

Current behavior
Error is thrown:
Objects are not valid as a React child (found: object with keys {reactNode}). If you meant to render a collection of children, use an array instead.
Expected behavior
Message is displayed as a toast.

This should be fixed by #280 it was a missed port of a fix we had in 3.6


Cannot find bun file

Describe the bug
I use the command of run, but it throws an error saying the bun file does not exist, even though it does and it is on my PATH. I am using a Linux os on Android, namely Userland Ubuntu. When I type "which bun", it gives the exact same path that it uses when it says the file cannot be found.
Traceback
userland@localhost:~/PyneProj$ pc run
────────────────── Starting Pynecone App ──────────────────
────────────── Installing frontend packages ───────────────
Traceback (most recent call last):
File "/usr/local/bin/pc", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.10/dist-packages/typer/main.py", line 214, in call
return get_command(self)(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/typer/main.py", line 532, in wrapper
return callback(**use_params)  # type: ignore
File "/usr/local/lib/python3.10/dist-packages/pynecone/pc.py", line 120, in run
frontend_cmd(app.app, Path.cwd(), frontend_port)
File "/usr/local/lib/python3.10/dist-packages/pynecone/utils.py", line 634, in run_frontend
setup_frontend(root)
File "/usr/local/lib/python3.10/dist-packages/pynecone/utils.py", line 615, in setup_frontend
install_frontend_packages()
File "/usr/local/lib/python3.10/dist-packages/pynecone/utils.py", line 458, in install_frontend_packages
subprocess.run(
File "/usr/lib/python3.10/subprocess.py", line 501, in run
with Popen(*popenargs, **kwargs) as process:
File "/usr/lib/python3.10/subprocess.py", line 969, in init
self._execute_child(args, executable, preexec_fn, close_fds,
File "/usr/lib/python3.10/subprocess.py", line 1845, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/home/userland/.bun/bin/bun'
Screenshots
If applicable, add screenshots to help explain your problem.
** Specifics (please complete the following information):**

Python Version: 3.10.6
Pynecone Version: 0.1.20
OS: Linux
Browser (Optional):

Additional context
Add any other context about the problem here.

I see, can you try putting that path from which bun in your pcconfig for bun_path and see if you still get the error

You're referring to the config.py file, am I correct? I tried that and it
is still throwing up the same error. It is still saying the file does not
exist, even though it does.
On Mon, Mar 13, 2023, 11:44 PM Alek Petuskey @.***>
wrote:

I see, can you try putting that path from which bun in your pcconfig for
bun_path and see if you still get the error
—
Reply to this email directly, view it on GitHub
https://github.com/pynecone-io/pynecone/issues/672#issuecomment-1467350866,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXG3DUB4X6YUHHMLIZTLLUDW37ZTVANCNFSM6AAAAAAVZYXWNE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I think I figured it out. As far as I can tell, there isn't a 32-bit
version of bun and my system happens to be 32-bit (armv7l). I should have
specified that. Sorry for the confusion. Is there another way to use
Pynecone with my architecture?
On Tue, Mar 14, 2023, 7:06 AM Billy Johnson @.***>
wrote:

You're referring to the config.py file, am I correct? I tried that and it
is still throwing up the same error. It is still saying the file does not
exist, even though it does.
On Mon, Mar 13, 2023, 11:44 PM Alek Petuskey @.***>
wrote:

I see, can you try putting that path from which bun in your pcconfig for
bun_path and see if you still get the error
—
Reply to this email directly, view it on GitHub
https://github.com/pynecone-io/pynecone/issues/672#issuecomment-1467350866,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXG3DUB4X6YUHHMLIZTLLUDW37ZTVANCNFSM6AAAAAAVZYXWNE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Got it we need to make a fallback to npm if the system does not support bun.
Will get this in one of the next releases.

Now that I am thinking more about this feature I am going to make an argument in the pcconfig to not use bun. That way we don't manually have to keep track of which os works with that dependency.


To-Do: Implement music download functionality

How can I solve it?

What do you mean? Please send more details.


Feature: Support Virtual Tryon

Add virtual try on as new tab to conduct tryon as a postprocess for EasyPhoto.
For more details, you can refer to TryOn
UI with explanation:

效果还可以，在开源和开集的TryON上效果是不错的，但是后续如何合理规划UI，和产品思路我觉得需要再讨论一下。


Use SessionContext to parse Expr protobuf

Which issue does this PR close?

Partially addresses #1882
Rationale for this change

Add serialization of UDF/UDAF to Ballista and datafusion-proto. We serialize the UDF/UDAF by name and then use the functions registered in the SessionContext to deserialize.
Users can either initialize Ballista instances with an SessionContext registered with the relevant functions or use the plugin mechanism being built as part of #1881.
What changes are included in this PR?

Parsing logical Expr now requires an SessionContext. Additionally, extension codecs in Ballista now need an ExecutionContext.
Are there any user-facing changes?

Yes, the signatures for PhysicalExtensionCodec.try_decode and LogicalExtensionCodec.try_decode now take a reference to an SessionContext.

cc @yahoNanJing @mingmwang

Does this place need to be modified ？

Does this place need to be modified ？

No. The default AsLogicalPlan instance was updated to pass the context when deserializing.

Sorry for the late response. Looks like this PR is a little problematic and it has conflicts with the multiple tenancy SessionContexts. The major problem is in the Executor side, Executor side also need to run those methods to parse the  Expr protobuf to physical plan, but Executor side should not have SessionContexts, the optimizers, planner and physical planner does't make sense in  Executor side.
And for pluggable UDF/UDAF, I think we should have global level UDF/UDAF and session level UDF/UDAF.
For example all the build-in UDF/UDAF should be globally available.  Different users can also upload/add his own functions
to his session.

Hi, @thinkharderdev
I think this PR doesn't resolve the issue. One of the key problem is, users register the UDF/UDFS with SessionContext.register_udf(), but how does the SessionContexts (ExecutionContext) in all the Executors know the registered UDF? The information is not propagate to executor side.
For DataFusion, SessionContext.register_udf() is not a problem. But for Baliista, there are three different kind of SessionContext:

the context created in Ballista client and uses the BallistaQueryPlanner to send logical plans to Scheduler
the context created in Scheduler
the context created in Executor

I'm going to remove the context created in Executor because I think it does not make sense to have Executor hold a global SessionContext.
Hi, @yjshen @alamb
Please share your thoughts.

Hi, @thinkharderdev
I think this PR doesn't resolve the issue. One of the key problem is, users register the UDF/UDFS with SessionContext.register_udf(), but how does the SessionContexts (ExecutionContext) in all the Executors know the registered UDF? The information is not propagate to executor side.
For DataFusion, SessionContext.register_udf() is not a problem. But for Baliista, there are three different kind of SessionContext:

the context created in Ballista client and uses the BallistaQueryPlanner to send logical plans to Scheduler, see the method create_df_ctx_with_ballista_query_planner()
the context created in Scheduler
the context created in Executor

I'm going to remove the context created in Executor because I think it does not make sense to have Executor hold a global SessionContext.
Hi, @yjshen @alamb
Please share your thoughts.

I think the idea is that there are two ways to register the UDF/UDAF in the executors:

Build your own executor where you basically write your own entrypoint and setup the SessionContext with any extensions (codecs, udfs, udafs, optimizers, planners, etc) registered at startup.
Use the mechanism being developed in https://github.com/apache/arrow-datafusion/pull/1881 to load udf/udaf as plugins which are put in a plugin directory and dynamically linked into the out of the box scheduler/executor binary.

Based on the discussion in that PR we were thinking that the plugin mechanism could use the SessionContext to do the registration of plugins at application start so internally we could use the same mechanism for both approaches. That is, you can either use plugins or roll your own main method but you still end up with extensions registered in the SessionContext and we use that for deserializing udfs/udafs in the plan.
Ultimately I think we do need some sort of context in the executor if we are going to support all the extension points that DataFusion provides in Ballista.

Hi, @thinkharderdev
I think this PR doesn't resolve the issue. One of the key problem is, users register the UDF/UDFS with SessionContext.register_udf(), but how does the SessionContexts (ExecutionContext) in all the Executors know the registered UDF? The information is not propagate to executor side.
For DataFusion, SessionContext.register_udf() is not a problem. But for Baliista, there are three different kind of SessionContext:

the context created in Ballista client and uses the BallistaQueryPlanner to send logical plans to Scheduler, see the method create_df_ctx_with_ballista_query_planner()
the context created in Scheduler
the context created in Executor

I'm going to remove the context created in Executor because I think it does not make sense to have Executor hold a global SessionContext.
Hi, @yjshen @alamb
Please share your thoughts.

I think the idea is that there are two ways to register the UDF/UDAF in the executors:

Build your own executor where you basically write your own entrypoint and setup the SessionContext with any extensions (codecs, udfs, udafs, optimizers, planners, etc) registered at startup.
Use the mechanism being developed in add udf/udaf plugin #1881 to load udf/udaf as plugins which are put in a plugin directory and dynamically linked into the out of the box scheduler/executor binary.

Based on the discussion in that PR we were thinking that the plugin mechanism could use the SessionContext to do the registration of plugins at application start so internally we could use the same mechanism for both approaches. That is, you can either use plugins or roll your own main method but you still end up with extensions registered in the SessionContext and we use that for deserializing udfs/udafs in the plan.
Ultimately I think we do need some sort of context in the executor if we are going to support all the extension points that DataFusion provides in Ballista.

Hi, @thinkharderdev
I'm going to remove the SessionContext in Executor code and make the Executor itself implement FunctionRegistry trait
and pass the Arc down to the try_into_physical_plan() and other required methods.
The major reason is Executor side does not need optimizers, planner, actually Executor side should not run any planning logic. The planner logic should only runs in Scheduler side.  And to support multiple tenancy SessionContext, it is weird to keep a global SessionContext in Executor side.
For udf/udaf registration in Executor side,  I did not get a chance to scan the code in https://github.com/apache/arrow-datafusion/pull/1881.  The two approaches you just mentioned should both work. And to support session level udf/udaf(temporary functions),  we also need a way to propagate the temp functions' meta data and lib url or lib files from Scheduler side to Executor side.

Hi, @thinkharderdev
I think this PR doesn't resolve the issue. One of the key problem is, users register the UDF/UDFS with SessionContext.register_udf(), but how does the SessionContexts (ExecutionContext) in all the Executors know the registered UDF? The information is not propagate to executor side.
For DataFusion, SessionContext.register_udf() is not a problem. But for Baliista, there are three different kind of SessionContext:

the context created in Ballista client and uses the BallistaQueryPlanner to send logical plans to Scheduler, see the method create_df_ctx_with_ballista_query_planner()
the context created in Scheduler
the context created in Executor

I'm going to remove the context created in Executor because I think it does not make sense to have Executor hold a global SessionContext.
Hi, @yjshen @alamb
Please share your thoughts.

I think the idea is that there are two ways to register the UDF/UDAF in the executors:

Build your own executor where you basically write your own entrypoint and setup the SessionContext with any extensions (codecs, udfs, udafs, optimizers, planners, etc) registered at startup.
Use the mechanism being developed in add udf/udaf plugin #1881 to load udf/udaf as plugins which are put in a plugin directory and dynamically linked into the out of the box scheduler/executor binary.

Based on the discussion in that PR we were thinking that the plugin mechanism could use the SessionContext to do the registration of plugins at application start so internally we could use the same mechanism for both approaches. That is, you can either use plugins or roll your own main method but you still end up with extensions registered in the SessionContext and we use that for deserializing udfs/udafs in the plan.
Ultimately I think we do need some sort of context in the executor if we are going to support all the extension points that DataFusion provides in Ballista.

Hi, @thinkharderdev
I'm going to remove the SessionContext in Executor code and make the Executor itself implement FunctionRegistry trait and pass the Arc<dyn FunctionRegistry>  down to the try_into_physical_plan()and other required methods. The major reason is Executor side does not need optimizers, planner, actually Executor side should not run any planning logic. The planner logic should only runs in Scheduler side. And to support multiple tenancy SessionContext, it is weird to keep a global SessionContext in Executor side.
For udf/udaf registration in Executor side, I did not get a chance to scan the code in #1881. The two approaches you just mentioned should both work. And to support session level udf/udaf(temporary functions), we also need a way to propagate the temp functions' meta data and lib url or lib files from Scheduler side to Executor side.

Can I suggest using TaskContext instead. We can add the FunctionRegistry to the TaskContext and pass that in. We would still need the ObjectStoreRegistry to decode the physical plan protobuf and I think it is a good idea to have a more general way of adding extension points into the executor.

I don't have anything substantial to add to this conversation -- it sounds like the challenges are well understood and there are good ideas of how to do the mapping from "function name" to "UDF implementation" on the executor side.
It is great discussion to see.


Vhost not working as expected

Hello,
The gobuster vhost mode is not woking properly in the gobuster v3.6.
The command I put is : gobuster vhost --url http://webenum.thm -w /usr/share/wordlists/seclists/Discovery/DNS/subdomains-top1million-5000.txt
In the wordlist there are 2 values that are true and the expected output is this :

But the output I have is this :

Please note that the website is in my /etc/hosts with the IP address and the website works fine in firefox and with the other mode (dir) it works perfectly well but with vhost and dns modes it doesn't find any results.
Thank you in advance for your responses.

I guess you are missing the -append-domain and —domain switch. Without this the plain word from the wordlist will be sent in the host header which could explain the 400s. I’m planning to make this the default setting in the next version as it causes a lot of confusion

to show only 'Status: 200' use
| grep -E "Status: 200"

to just remove 302
| grep -vE "Status: 302"

I guess you are missing the -append-domain and —domain switch. Without this the plain word from the wordlist will be sent in the host header which could explain the 400s. I’m planning to make this the default setting in the next version as it causes a lot of confusion

So what the correct command would look like ? Please show us in detail because this make the tool not reliable for vhost enumeration

gobuster vhost -u http://webenum.thm -w subdomains-top1million-5000.txt --append-domain
Damn, I spent hours trying to figure this one out and earlier I even saw append domain as set to false when the scan ran, but I told myself, if the devs set that to default for vhosts, it must be for a reason. I'm kicking myself for not simply asking myself what if I change that option, makes sense right you're appending the domain to the prefix. But really, it should be default, unless there's a good reason not to have it as such.

But anyway thank you for making such a cool tool, wish I could be a gigachad like you and code such intricate tools. I'm only at the level where I'm figuring out how to use these tools. One day...

I was having the same issue @mijnog , so apparently with the append domain option you will get something like:
admin.webenum.thm
test.webenum.thm

without the append domain option you will get:
http://webenum.thm/admin
http://webenum.thm/test


[CL]: Investigate round down behavior incentives

Background
I added a test case in withdrawPosition that adds a full range liquidity position. When we claim rewards, we claim 3 less than what is expected. See the addition here.
As you can see in the test, the default positions do not have this rounding issue, but a full range position requires the use of osmomath rounding tolerance in order to pass.
Suggested Design
TBD
Acceptance Criteria

Investigate rounding behavior and determine if this is appropriate / expected behavior

If appropriate, leave reply here as well as in docs why this is happening
If not, fix and open PR

Hi @czarcas7ic, I have checked with the test cases that you have mentioned, it seems that we now don't have the error tolerance any more, I have removed the error tolerance and changed the test cases to check if they have the same values, confirmed that it works properly

Sweet, closing, thanks for the update @mattverse!


Distributed Replay support for SQL 2019

SQL 2017 is mentioned as supported, but there is no mention of SQL 2019.  Is there a technical challenge here?  Because this page is a SQL 2019 page, something should be said.  Is it supported, if not , when, does 2019 have a different trace file format.

Please say something about the editions (Enterprise, Standard) needed for DRC.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 64b93440-e7c0-d790-2981-9809ad885dff
Version Independent ID: c7aa5735-60cd-5fca-f77b-8e789868babc
Content: Distributed Replay requirements - SQL Server Distributed Replay
Content Source: docs/tools/distributed-replay/distributed-replay-requirements.md
Product: sql
Technology: tools-other
GitHub Login: @markingmyname
Microsoft Alias: maghan

@data-architect-tampa -- thank you for your feedback.  Please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@markingmyname -- please look into this issue.

@data-architect-tampa -- thank you for your feedback.  Please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@markingmyname -- please look into this issue.

@WilliamAntonRohm not sure why you referred them to a Q&A site here - this is a problem with the documentation, not a functionality question. The documentation has a bullet point list of versions that doesn't include SQL Server 2019.

@Matteo-T for awareness

Hi, @data-architect-tampa
If Tampa means Tampa Bay, then congrats on the recent Super Bowl win.
Also, we are still working on completing Dreplay to work with 2019, and that is why it is not listed yet.
There are a few pieces that we are working through before we are confident adding it to the list.
As such, Dreplay does not work with 2019 yet.
We apologize for any confusion or inconvenience.

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion, and we will reopen the issue. To see what the community is wanting, please visit the SQL Server User Feedback site.

I think that the documentation could say something about the state of
Dreply and 2019.  You can state that it is not working with release nnn and
that the page will be updated when it is working.  the only reason to go to
this page is to find out what releases are working.....  I think just
omitting it with no information is not the best you .
On Tue, Feb 9, 2021 at 2:42 PM Mark Ghanayem<EMAIL_ADDRESS>wrote:

Hi, @data-architect-tampa https://github.com/data-architect-tampa
If Tampa means Tampa Bay, then congrats on the recent Super Bowl win.
Also, we are still working on completing Dreplay to work with 2019, and
that is why it is not listed yet.
There are a few pieces that we are working through before we are confident
adding it to the list.
As such, Dreplay does not work with 2019 yet.
We apologize for any confusion or inconvenience.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/sql-docs/issues/5974#issuecomment-776193145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKDM6HPJTYCHFNCA444ONMDS6GFYVANCNFSM4WT76WAA
.


[BUG]: findFirst() returns array instead of single entity

What version of drizzle-orm are you using?
0.30.7
What version of drizzle-kit are you using?
--
Describe the Bug
The findFirst() query method returns an array.
Example code (I assume the table definition is irrelevant here):
  const dealer = await db.query
    .dealer
    .findFirst({
      columns: {id: true},
      where: eq(dealerDef.key, dealerKey)
    });
  console.debug(`!!!!!!!!!!!!! ${JSON.stringify(dealer)}`)

With logging turned on, a query that finds an entity shows:
Query: select "id" from "dealer" where "dealer"."key" = :1 limit :2 -- params: [{"name":"1","value":{"stringValue":"valid-key"}}, {"name":"2","value":{"longValue":1}}]
!!!!!!!!!!!!! [{"id":100001}]

A query that does not find  an entity shows:
Query: select "id" from "dealer" where "dealer"."key" = :1 limit :2 -- params: [{"name":"1","value":{"stringValue":"bad-key"}}, {"name":"2","value":{"longValue":1}}]
!!!!!!!!!!!!! []

Expected behavior
I expect to get an entity (in the "found" case) or undefined (in the "not found case"), as indicated in the return type for findFirst() (see the return type for findMany() for contrast), and as documented for findFirst() (documentation for findMany() for constast).
Environment & setup
I'm using aws-data-api/pg, not sure if the bug is specific to that client/db

With drizzle-orm/d1 the object (entity) or undefined is returned, so doing what you exepcted.
I came here as was wondering if it's possible to return null instead of undefined or whether it is possible to extend drizzle so I can add a findFirstOrNull method?

yes same issue. don't know will comes object or array. giving typescript error


Implement logging (or document API) for SetAnnotationObjectOptions

Is your feature request related to a problem?
Hello everyone
I use VisIt in an automated way. I generate scripts and then run VisIt in the CLI mode. To build my scripts, I use the GUI feature "Controls -> Command ... -> Record" to record a scripts based on manual actions in the GUI. This feature is great and allowed me to build fairly complex plotting pipelines.
Now I face a surprising problem. I wanted to add a simple text annotation to my plot. I used the GUI menu "Controls -> Annotations... -> Objects -> Text". When I tried to view the script needed for doing the same in an automated way, I found the following message:
"Logging for SetAnnotationObjectOptions is not implemented yet."

Also documentation did not help.
Is your feature request specific to a data set?
No.
Describe the solution you'd like.
I see two possible solutions:

Implement the logging mechanism for the SetAnnotationObjectOptions objecto so that the "Controls -> Command ... -> Record" feature can be used.

Add a documentation of this particular API so that it's clear how to add text annotations using a script.

Describe alternatives you've considered.
I tried to find other ways how I could add a custom text to the plot. I expected there will be e.g. an option to add a title to the legend or to override the database annotation with custom text. None of these worked for me.
Additional context
None.
Thank you for your effort developing VisIt!

Additionally, it would be good to add logging of CreateAnnotationObject and/or correct the following message: logging for AddAnnotaionObject is not implemented yet. AddAnnotaionObject doesn't exist.

@vsisl Some useful documentation for your perusal in the meantime:
Working with Annotations
CreateAnnotationObject
GetAnnotationObjectNames
GetAnnotationObject

Logging for annotation objects Resolved with #20028.
RTD documentation is already available and referenced above.


How to link a static library when creating a shared_lib using gyp?

I am using below code in my gyp file but it is throwing linking error. This works fine when I change the library type to static _library. Do I need to link with shared library only or I am missing something?
'targets': [
{
'target_name': 'abc',
'type': 'shared_library',
'conditions': [],
'dependencies': [],
'libraries':[
'mylib.a'
],
'mac_framework_dirs' : [
],
'all_dependent_settings': {},
},

Sorry we haven't been able to provide an answer @nehasharan. My suggestion is to have a look around at the many examples of addons that are doing things like this already.


Fidelity issues

The trailing icon becomes darker when clicked. On macOS it becomes lighter.
Dragging the trailing icon doesn't drag the toolbar on macOS.
Double clicking the trailing icon doesn't minimize the screen on macOS.
https://user-images.githubusercontent.com/351125/200045237-fbcc1a82-3aca-4773-beb2-1b5776ed1be9.mov

Hi @bernaferrari! Thanks for filing this issue.
Toolbar behavior is unfortunately pretty complex. We can certainly address the icon color discrepancy; as for the dragging/clicking issue, it will require deeper research.

You probably want some form of absorb pointer.

You probably want some form of absorb pointer.

I believe we have experimented with AbsorbPointer in this regard. @whiplashoo Can you confirm this?

@bernaferrari There is an issue for the double clicking behaviour in #308
Solving this, might as well solve the draging behaviour you mention. Currently the toolbar is completely handled by the native side. I guess we need to handle part of it from the Flutter side instead to solve both issues. The experiments @whiplashoo made didn't seem to work. See https://github.com/GroovinChip/macos_ui/issues/308#issuecomment-1270448273.
@GroovinChip You might want to use / or get inspired by https://github.com/leanflutter/window_manager or https://github.com/bitsdojo/bitsdojo_window.

Yes, it wouldn't work as the double click event gets captured by the native NSToolbar, which we use to have all the minimizing-maximizing native-like behavior of the toolbar. Blocking this in Flutter with widgets wouldn't work.
The window_manager plugin looks promising, will have a look when I find time

@whiplashoo using https://github.com/leanflutter/window_manager/issues/289 you could disable window zoom on button clicks and start a timer to re-enable it 300ms later.

Actually I'm closing this in favor of #308


working example of OGR forcing a single driver on read

https://github.com/pcjericks/py-gdalogr-cookbook/issues/154

This is vey interesting. Looks good!

Thanks!
http://pcjericks.github.io/py-gdalogr-cookbook/vector_layers.html#force-ogr-use-named-driver
Jared


NMS not compiled with GPU support

❓ Questions and Help
Trying to build and run the repo, and on running I am getting this runtime error:
2019-02-21 02:14:18,430 maskrcnn_benchmark.trainer INFO: Start training
Traceback (most recent call last):
  File "tools/train_net.py", line 174, in <module>
    main()
  File "tools/train_net.py", line 167, in main
    model = train(cfg, args.local_rank, args.distributed)
  File "tools/train_net.py", line 73, in train
    arguments,
  File "/raid/sanjay/maskrcnn-benchmark/maskrcnn_benchmark/engine/trainer.py", line 66, in do_train
    loss_dict = model(images, targets)
  File "/raid/sanjay/.conda/envs/nightly/lib/python3.6/site-packages/torch/nn/modules/module.py", line 492, in __call__
    result = self.forward(*input, **kwargs)
  File "/raid/sanjay/maskrcnn-benchmark/maskrcnn_benchmark/modeling/detector/generalized_rcnn.py", line 50, in forward
    proposals, proposal_losses = self.rpn(images, features, targets)
  File "/raid/sanjay/.conda/envs/nightly/lib/python3.6/site-packages/torch/nn/modules/module.py", line 492, in __call__
    result = self.forward(*input, **kwargs)
  File "/raid/sanjay/maskrcnn-benchmark/maskrcnn_benchmark/modeling/rpn/rpn.py", line 159, in forward
    return self._forward_train(anchors, objectness, rpn_box_regression, targets)
  File "/raid/sanjay/maskrcnn-benchmark/maskrcnn_benchmark/modeling/rpn/rpn.py", line 175, in _forward_train
    anchors, objectness, rpn_box_regression, targets
  File "/raid/sanjay/.conda/envs/nightly/lib/python3.6/site-packages/torch/nn/modules/module.py", line 492, in __call__
    result = self.forward(*input, **kwargs)
  File "/raid/sanjay/maskrcnn-benchmark/maskrcnn_benchmark/modeling/rpn/inference.py", line 138, in forward
    sampled_boxes.append(self.forward_for_single_feature_map(a, o, b))
  File "/raid/sanjay/maskrcnn-benchmark/maskrcnn_benchmark/modeling/rpn/inference.py", line 118, in forward_for_single_feature_map
    score_field="objectness",
  File "/raid/sanjay/maskrcnn-benchmark/maskrcnn_benchmark/structures/boxlist_ops.py", line 27, in boxlist_nms
    keep = _box_nms(boxes, score, nms_thresh)
RuntimeError: Not compiled with GPU support (nms at /raid/sanjay/maskrcnn-benchmark/maskrcnn_benchmark/csrc/nms.h:22)
frame #0: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x45 (0x7fd5399b58b5 in /raid/sanjay/.conda/envs/nightly/lib/python3.6/site-packages/torch/lib/libc10.so)
frame #1: nms(at::Tensor const&, at::Tensor const&, float) + 0xd4 (0x7fd52d3313a4 in /raid/sanjay/maskrcnn-benchmark/maskrcnn_benchmark/_C.cpython-36m-x86_64-linux-gnu.so)
frame #2: <unknown function> + 0x14ebf (0x7fd52d33debf in /raid/sanjay/maskrcnn-benchmark/maskrcnn_benchmark/_C.cpython-36m-x86_64-linux-gnu.so)
frame #3: <unknown function> + 0x11d55 (0x7fd52d33ad55 in /raid/sanjay/maskrcnn-benchmark/maskrcnn_benchmark/_C.cpython-36m-x86_64-linux-gnu.so)
<omitting python frames>

I am using nightly pytorch build (installed with conda install -c pytorch pytorch-nightly cuda92). I downloaded both the nightly pytorch build and the maskrcnn repo today (2/21).
Current versions are:
$ python -c "import torch; print(torch.__version__); print(torch.version.cuda)"
1.0.0.dev20190201
9.0.176

$ conda list | grep torch
cuda92                    1.0                           0    pytorch
libtorch                  0.1.12                  nomkl_0
pytorch-ignite            0.1.2                     <pip>
pytorch-nightly           1.0.0.dev20190201 py3.6_cuda9.0.176_cudnn7.4.1_0    pytorch
torch                     1.0.1.post2               <pip>
torchvision-nightly       0.2.1                     <pip>

maskrcnn version:
$ git log -1
commit b23eee0cb72af70f4e4a72e73537f0884cfd1cff
Author: Stzpz<EMAIL_ADDRESS>Date:   Wed Feb 20 07:47:10 2019 -0800

    Supported FBNet architecture. (#463)

I have seen other closed issues re: this problem and I have tried to follow the solutions in those issues but am still experiencing this error. I would appreciate any help on this. Thanks!

Could you please tell what is the output of python -c "import torch;from torch.utils.cpp_extension import CUDA_HOME;print(CUDA_HOME);print(torch.cuda.is_available())" ?
It should be something like :
/usr/local/cuda
True

ah! your question helped me realize my mistake. I was not running python setup.py with the CUDA_VISIBLE_DEVICES flag so the cuda code was not being compiled on any gpu. Thanks for your help!

Thanks @LeviViana for helping out figure the reason!

Can you tell me how to run python setup.py with the CUDA_VISIBLE_DEVICES flag?

On the command line I just ran
$ CUDA_VISIBLE_DEVICES=0 python setup.py <options>
with a 0 because when I ran $ nvidia-smi it showed the ID of the gpu as 0 (and with the options in the INSTALL.md instructions). This fixed the issue for me because running
$ python -c "import torch; print(torch.cuda.is_available())"
printed False but running
CUDA_VISIBLE_DEVICES=0 python -c "import torch; print(torch.cuda.is_available())"
printed True.

Thanks @sanjmohan
I'm getting the same error even after setting CUDA_VISIBLE_DEVICES flag. Also, even $ python -c "import torch; print(torch.cuda.is_available())" is returning True for me.
Can you please help me with this?

ah! your question helped me realize my mistake. I was not running python setup.py with the CUDA_VISIBLE_DEVICES flag so the cuda code was not being compiled on any gpu. Problem fixed. Thanks for your help!

That's quite helpful! I also can't compile before because I don't find CUDA_NAME in my computer, and I reinstall my NIVIDA driver. It works!!


Cannot convert EC key to PEM when in FIPS mode

It appears that when a system is in FIPS mode, it's not possible to convert a EC key to PEM format, the command fails:
# openssl ecparam -name secp384r1 -genkey | openssl ec -aes256 -out server.key
[...]
001E9731AB7F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:crypto/evp/evp_fetch.c:355:Global default library context, Algorithm (MD5 : 95), Properties ()
001E9731AB7F0000:error:03000086:digital envelope routines:evp_md_init_internal:initialization error:crypto/evp/digest.c:272:

This is because the PEM implementation in openssl explicitly requires MD5 digests, as seen in the code excerpt below (crypto/pem/pem_lib.c, line 383 as of Nov 20, "master" branch):
 319 int PEM_ASN1_write_bio(i2d_of_void *i2d, const char *name, BIO *bp,
 320                        const void *x, const EVP_CIPHER *enc,
 321                        const unsigned char *kstr, int klen,
 322                        pem_password_cb *callback, void *u)
 323 {
 :
 379         /*
 380          * The 'iv' is used as the iv and as a salt.  It is NOT taken from
 381          * the BytesToKey function
 382          */
 383         if (!EVP_BytesToKey(enc, EVP_md5(), iv, kstr, klen, 1, key, NULL))
 384             goto err;
 :

This is observed on both RHEL8 (openssl-1.1.1k-14.el8_6) and RHEL9 (openssl-3.2.2-6.el9_5.x86_64) and Upstream code, checking the sources.
There is another place in crypto/pem/pem_lib.c where MD5 is hardcoded (line 453):
 419 int PEM_do_header(EVP_CIPHER_INFO *cipher, unsigned char *data, long *plen,
 420                   pem_password_cb *callback, void *u)
 421 {
 :
 453     if (!EVP_BytesToKey(cipher->cipher, EVP_md5(), &(cipher->iv[0]),
 454                         (unsigned char *)buf, keylen, 1, key, NULL))
 455         return 0;
 :

Hello,
in order to reproduce/debug the issue I will need some details on your openssl configuration.
I will share what I was doing when I was trying to reproduce it in my test environment.
I was following README-FIPS to enable fips,
I'm using fips provider built from openssl-3.0.9. My openssl fips installation uses default .cnf with fips provider module
enabled. the diff to default .cnf reads as follows:
lifty$ diff -u openssl-master/ssl/openssl.cnf openssl-master.fips/ssl/openssl.cnf
--- openssl-master/ssl/openssl.cnf      Fri Nov 22 11:15:42 2024
+++ openssl-master.fips/ssl/openssl.cnf Fri Nov 22 11:16:10 2024
@@ -48,7 +48,7 @@
 # fips provider. It contains a named section e.g. [fips_sect] which is
 # referenced from the [provider_sect] below.
 # Refer to the OpenSSL security policy for more information.
-# .include fipsmodule.cnf
+.include /home/sashan/work.openssl/openssl.binaries/openssl-master.fips/ssl/fipsmodule.cnf

 [openssl_init]
 providers = provider_sect
@@ -58,7 +58,7 @@
 default = default_sect
 # The fips section name should match the section name inside the
 # included fipsmodule.cnf.
-# fips = fips_sect
+fips = fips_sect

 # If no providers are activated explicitly, the default one is activated implicitly.
 # See man 7 OSSL_PROVIDER-default for more details.
@@ -69,7 +69,7 @@
 # OpenSSL may not work correctly which could lead to significant system
 # problems including inability to remotely access the system.
 [default_sect]
-#activate = 1
+activate = 1

 ####################################################################

the fipsmodule.cnf got created using command:
openssl fipsinstall -out /home/sashan/work.openssl/openssl.binaries/openssl-master.fips/ssl/fipsmodule.cnf -module /home/sashan/work.openssl/openssl.binaries/openssl-master.fips/lib/ossl-modules/fips.so

Switching to my openssl.fips profile things seem to work as expected for me:
lifty$ openssl.env master.fips
lifty$ openssl ecparam -name secp384r1 -genkey | openssl ec -aes256 -out server.key
read EC key
writing EC key
Enter PEM pass phrase:
Verifying - Enter PEM pass phrase:

How did you build your openssl? what kind of compile time options you were using?
also can you share your openssl.cnf?
thanks.

@Sashan your configuration enables both fips and default providers. In such configuration, this will work, because MD5 will be fetched from the default provider.
For some reason the openssl ec command uses the traditional encrypted PEM format when outputting the key. The MD5 algorithm is really hardcoded there and cannot be changed. Instead use openssl pkey -aes256 -out server.key. That will use the encrypted PKCS-8 format which is FIPS-compatible.
We should change the default format for openssl ec to privatekeyinfo perhaps with adding the -traditional option as in other commands.

I'm still learning this stuff... so if I change the openssl.cnf by commenting out activate=1 in default_sect I should be running in FIPS mode only correct?
In this case the error I'm seeing is not caused by right hand side of the pipe command:
lifty$ openssl ecparam -name secp384r1 -genkey | openssl ec -aes256 -out server.key
read EC key
Could not open file or uri for loading private key from <stdin>
181613BCBB000000:error:16000069:STORE routines:ossl_store_get0_loader_int:unregistered scheme:crypto/store/store_register.c:237:scheme=file
181613BCBB000000:error:1608010C:STORE routines:inner_loader_fetch:unsupported:crypto/store/store_meth.c:360:No store loader found. For standard store loaders you need at least one of the default or base providers available. Did you forget to load them? Info: Global default library context, Scheme (file : 0), Properties (<null>)
unable to load Key
unable to write elliptic curve parameters
18464E7987070000:error:1D800065:ENCODER routines:OSSL_ENCODER_to_bio:reason(101):crypto/encode_decode/encoder_lib.c:55:No encoders were found. For standard encoders you need at least one of the default or base providers available. Did you forget to load them?

it is in fact coming from left hand side, which generates key:
lifty$ openssl.env master.fips
lifty$ grep -A 2 -B 2 activate  /home/sashan/work.openssl/openssl.binaries/openssl-master.fips/ssl/openssl.cnf
fips = fips_sect

# If no providers are activated explicitly, the default one is activated implicitly.
# See man 7 OSSL_PROVIDER-default for more details.
#
--
# If you add a section explicitly activating any other provider(s), you most
# probably need to explicitly activate the default provider, otherwise it
# becomes unavailable in openssl.  As a consequence applications depending on
# OpenSSL may not work correctly which could lead to significant system
--
# problems including inability to remotely access the system.
[default_sect]
#activate = 1

lifty$ openssl ecparam -name secp384r1 -genkey
unable to write elliptic curve parameters
1836429C1C030000:error:1D800065:ENCODER routines:OSSL_ENCODER_to_bio:reason(101):crypto/encode_decode/encoder_lib.c:55:No encoders were found. For standard encoders you need at least one of the default or base providers available. Did you forget to load them?

So if I understand situation right, we can not generate EC keys in FIPS mode at all. The openssl-ec can not generate key, the only option is to generate ec key in non-fips SSL and then convert it using openssl-pkey to PKCS-8 format.


x/exp/io: need to support compiling on OS X/Windows

Currently some files in the io packages only build on linux which causes issues if you are developing on a different OS and run IDE tools.
An idea would be to start by creating a mock implementation until we decide if we can/should have working implementations for other OSes.

Mock have been added to SPI and I2C packages.


chore: type device a1

Note: not 100% typed, but let's start

Codecov Report
Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 6.41%. Comparing base (4f18938) to head (ad9d960).

Files
Patch %
Lines

midealocal/devices/a1/message.py
0.00%
12 Missing :warning:

midealocal/devices/a1/__init__.py
0.00%
10 Missing :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #45      +/-   ##
========================================
- Coverage   6.41%   6.41%   -0.01%
========================================
  Files         77      77
  Lines       6581    6583       +2
========================================
  Hits         422     422
- Misses      6159    6161       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Move GlobalTracer from contrib to opentracing-java.

There seems to be general consensus on gitter to move the Java GlobalTracer into the opentracing-java project.
I took the liberty to use the version in https://github.com/opentracing-contrib/java-globaltracer/pull/8 for this PR as well. I propose to keep the discussion about that change confined to that PR as much as possible. I will make sure to keep them functionally aligned.
Discussion we could have here is:

Should this be a separate module?
Or should the GlobalTracer class be moved into the API module itself for even more exposure?

Given the tendency to move things like no-op out of the API, my initial choice was a separate module with the io.opentracing:opentracing-globaltracer groupId:artifact identity.
This allows migration of the current 'contrib' variant by publishing a new deprecated + delegated variant.

@sjoerdtalsma thank you for kicking this off!
IMO the separate module is the right approach, though I think it's fair game to have the OT-Java docs point directly towards it. I would also propose that we choose a Java package name that can stick if we want to move this into the core module in the future.

+1  a separate module

@bhs

I would also propose that we choose a Java package name that can stick if we want to move this into the core module in the future.

Currently I put it in the io.opentracing java package as there's only a single GlobalTracer class.
I actually doubted about io.opentracing.global (similar to the current contrib sub-package).
Let's go with the majority vote on this one 😉 ..

Currently I put it in the io.opentracing java package as there's only a single GlobalTracer class.
I actually doubted about io.opentracing.global (similar to the current contrib sub-package).
Let's go with the majority vote on this one :wink:

What about io.opentracing.util as a place for globaltracer and maybe future spanmanager? But then we should probably introduce some "opentracing-util" artifact instead of opentracing-globaltracer.

I like the 'util' suggestion as it seems more stable to me.

I did not follow the initial review of globaltracer therefore my following thoughts might not be relevant.

It the update of a tracer considered as safe at runtime? Is GlobalTracer intended to be used for changing tracer impl at runtime or is it used only for the initial tracer acquiring? e.g. GlobalTracer#register can cause app crash.

If that holds I think that tracer loading mechanism should be pluggable and GlobalTracer#register removed.

@pavolloffay I am afraid I don't quite understand your remark. If you have concerns about an app crash, please file an issue on the original repo, because that sounds dangerous.
Some background: GlobalTracer serves as a holder for some 'global' configured tracer. By-default it will lazily try to resolve a Tracer from the ServiceLoader, but it is equally valid to register your own (e.g. if it requires explicit configuration that can not automatically be provided).
The GlobalTracer is a singleton because I was afraid people will create constants for it (similar to current logging patterns). Switching between incompatible tracers is not the intention here, but having predictable behaviour before, during and after application initialization is.
Again, if you feel the code is dangerous in any way, please file an issue so we can address it explicitly.

So happy to see this here!

@bhs

i.e., returning the Tracer instance that was registered() at get()-time.

Two points:

That would not work with libraries that get loaded before the global tracer is registered and work with a constant reference.
The delegation forces using the Tracer interface.

Why it cannot be simplified to something like: https://pastebin.com/jijhG1NE

@sjoerdtalsma thanks for the explanation :+1: Then it makes sense. I think I missed my coffee.

lgtm

@bhs Any objections to merging this one soon and doing a release?

@sjoerdtalsma if there's urgency, we could probably merge ~now / today... otherwise I'd wait 24h since this is a more substantial change than most.

@bhs I'm no collaborator on the opentracing-java git repo, so I can't merge this in myself.

Done – thanks so much, @sjoerdtalsma!

@sjoerdtalsma oh, one other thing: want to make a small change to the OT-java README that mentions the GlobalTracer?

@sjoerdtalsma Good job!
@bhs Time for a release :) - would be good to start updating the framework integrations and agent.

@objectiser I just pushed a release tag... we should be good to go soon with 0.21.0.

👏 @sjoerdtalsma Glad to have this in opentracing-java, finally.

Thanks for the reviews everybody!


Update manusa/actions-setup-minikube action to v2.3.0

Upgrade manusa/actions-setup-minikube to use the latest version.
GitHub is rolling out Ubuntu 20.04 as the default environment. GitHub actions workflows using ubuntu-latest will soon  start an Ubuntu 20,04 instance instead of 18.04.
Prior versions of manusa/actions-setup-minikube have a check which won't allow the workflow job to run. Starting on 2.2.0, Ubuntu 20.04 is supported too (https://github.com/manusa/actions-setup-minikube/issues/26).

Our test suite doesn't work properly with PRs from external repositories, and I needed to rebase this, so closed with an equivalent change in #522. Thank you so much for reaching out with a PR and letting us know!

👍 no worries. The main purpose of these PRs I'd for you to notice before it's too late 😉

👍 no worries. The main purpose of these PRs I'd for you to notice before it's too late 😉


Suggested edit to concurrency / mmap locking behavior description in README.md

I found the following text in the README.md a little bit confusing, and it ended up costing me
a bunch of time / wasted code consequently:
Read-only transactions and read-write transactions should not depend on one another
and generally shouldn't be opened simultaneously in the same goroutine. This can cause a
deadlock as the read-write transaction needs to periodically re-map the data file but it cannot
do so while a read-only transaction is open.

In particular, a not-careful reading (like the one I gave it) might imply there are no locking problems whatsoever with concurrent read/read-write transactions so long as they are opened in different goroutines.
Perhaps it should say something like "under some circumstances (when the database memory map needs to grow), read/write Commit() will block until all read-only transactions in every goroutine are closed.  In particular, care should be taken to not try to commit a read-write transaction before closing all reads in a single goroutine"?

(Also, I'm speaking from a place of relative ignorance as I haven't gotten too deep into the bolt source yet, but it would be really nice if this sort of locking up on r/w Commit() didn't happen - is it somehow conceivable that this might be possible?   Perhaps by using copy-on-write paging or something like that? I've never encountered this with other k/v stores...)

@benbjohnson Just thinking about this now, is there a reason why we can only have one mapping of the database at a time?  I know 32bit arches would have issues, but 64bit should have tons of VM space.  Would a PR lifting this limitation but using multiple memory maps be considered?  I had some ideas for how it could be arranged, though no guarantees on when that might turn into code.
I'd understand if you consider that out of scope, since you want boltdb to be a minimal KV and that would be too complicated.  I just don't want to put pen to keyboard if that is the case.

With #453 and #472 merged in, you can set InitialMmapSize to a high number (e.g. 1TB) and it'll only mmap once. Then you won't have an issue with transactions blocking other transactions. That option needs to be added to the README.

Ah, that might work.  This would only be possible on a 64-bit system, however, correct?   Are there any downsides in performance characteristics are other concerns to be aware of mmap'ing a huge chunk of process space like that?

Yes, only on a 64-bit system. However, you wouldn't be able to mmap it in multiple smaller chunks on a 32-bit system since you would run out of virtual space.
I don't know of any perf downsides with that approach. That's the approach that LMDB suggests.

One thing I did come across is that on recent versions of Linux, the documentation claims that adding the MAP_HUGETLB flag to the mmap flags may be more performant for large mappings (it seems it encodes addresses differently internally, that way).   I couldn't see a difference in my test cases, but if if it does make a difference perhaps it should be defaulted in if the initial mmap size is larger than some threshold value...

I'd be up for adding it to the documentation but I'd like to avoid surprises when users bump from one size to another. There's a DB.MmapFlags field where users can add additional flags if they'd like (e.g. MAP_POPULATE) but many of those are dependent on use case.

Makes sense.  (I also just noticed it fails with EINVAL on kernel versions that don't support it!)
Looks like my original problem was completely resolved by #472 (thanks!) and setting initial map size, will leave this open for the sake of that doc change though.