feat/question: support compilation to wasm32 with std

Feature Summary
cargo check --package ibc  --target wasm32-unknown-unknown  --features=std

should work.
But I get now
error: the wasm*-unknown-unknown targets are not supported by default, you may need to enable the "js" feature. For more information see: https://docs.rs/getrandom/#webassembly-support
   --> /home/dz/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.11/src/lib.rs:290:9
    |
290 | /         compile_error!("the wasm*-unknown-unknown targets are not supported by \
291 | |                         default, you may need to enable the \"js\" feature. \
292 | |                         For more information see: \
293 | |                         https://docs.rs/getrandom/#webassembly-support");
    | |________________________________________________________________________^

error[E0433]: failed to resolve: use of undeclared crate or module `imp`
   --> /home/dz/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.11/src/lib.rs:346:9
    |
346 |         imp::getrandom_inner(dest)?;
    |         ^^^ use of undeclared crate or module `imp`

For more information about this error, try `rustc --explain E0433`.

Proposal
Fix it, or suggest what to do.
I not sure. Would it all work if I just use ibc without std when compiling std CosmWasm contract.
This is typical for Polkadot SDK when trying to compile runtime to wasm, but in no_std. Not sure so what combination gives error in std/wasm.
May be fix should have been done long ago in getrandom. Just feature them with proper no_std/std wasm support...

I was about to point out that this usually comes from two upstream crates: tendermint-rs and primitive-types. The primitive-types one is pulled in because of the ICS-20 implementation.
But if you're compiling any chunk of the ibc-rs implementation other than ICS-20, you can roll with sub-crates like ibc-core and ibc-clients or their sub-libraries. This way, you won't have to pull in getrandom unnecessarily.

Currently wasm32 uses same crates inside as core and alloc, and reexports, so fix should work. As real no_std (Solana?) will not use  std target, things should work.

Currently blocked on: https://github.com/paritytech/parity-common/issues/805

I patched parity, they merged, but not released yet. So all deps on deps still broken. Neither got merged https://github.com/cosmos/ibc-rs/pull/1162 as workaround.
seem blocked


BUG:  Download Button Not Functioning on Real Devices

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Description:
There is an issue with the download button functionality in the ExamTime repository. When the download button is clicked, the file does not download on real devices.
Steps to Reproduce:

Open the ExamTime app on a real device.
Navigate to the section where the download button is available.
Click the download button.
Observe that the file does not download on the real device.

Observed Behavior:

The file does not download on real devices when the download button is clicked.

Expected Behavior:

The file should download successfully on real devices when the download button is clicked.

Possible Cause:

There might be an issue with the file path or storage permissions when the app is run on real devices.
Differences in how real devices handle file storage and permissions could be causing the issue.

video sample
https://github.com/Yashshukla11/ExamTime_android/assets/123234840/d43f5b9d-ea07-498e-bbc9-4c7754e74763
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'24 contributor
[X] I want to work on this issue

just reclone repo its working well


Allow multiple query combined with versionfilter to json source

Signed-off-by: Olblak<EMAIL_ADDRESS>As discussed on https://github.com/updatecli/updatecli/issues/942#issuecomment-1284561424
I realized that it would be super usefull to be able to do a multiple query combined with versionfilter on the json resource
This pullrequest allows the following manifest to work
sources:
  semverVersion:
    kind: json
    name: Get latest version from remote json file
    spec:
      file: https://api.github.com/repos/updatecli/updatecli/releases
      key: ".[*].tag_name"
      multiple: true
      versionfilter:
        kind: semver
        pattern: "v0.35"

Example
+++++++++++
+ PREPARE +
+++++++++++

Loading Pipeline "/tmp/updatelci.yaml"

SCM repository retrieved: 0

++++++++++++++++++
+ AUTO DISCOVERY +
++++++++++++++++++

++++++++++++
+ PIPELINE +
++++++++++++

##################
# UPDATELCI.YAML #
##################

SOURCES
=======

semverVersion
-------------
Searching for version matching pattern "v0.35"
✔ Value "v0.35.1", found in file "https://api.github.com/repos/updatecli/updatecli/releases", for key ".[*].tag_name"'

=============================

REPORTS:

- UPDATELCI.YAML:
	Source:
		✔ [semverVersion] Get latest version from remote json file (kind: json)

Run Summary
===========
Pipeline(s) run:
  * Changed:	0
  * Failed:	0
  * Skipped:	1
  * Succeeded:	0
  * Total:	1

Test
To test this pull request, you can run the following commands:
go build -o bin/updatecli .
./bin/updatecli --config manifest_mentioned_here.yaml
go test

Additional Information
Tradeoff

Potential improvement
I'll try to find some time to open a similar pullrquest for toml and csv as they also use Dasel
I need to investigate for the xml resource but it should be possible
Unfortunately, it won't work for the yaml resource as it doesn't support multiple query

Like in https://github.com/updatecli/updatecli/issues/945#issuecomment-1285044879, it seems that this would be a broader change as it implies having a multi-valued source.
How is the order managed?

Can you update the PR description to show the result? The example is not clear on what is it doing exactly?

Like in #945 (comment), it seems that this would be a broader change as it implies having a multi-valued source.

The source output doesn't change as we still return one single value. Here versionfilter works the same way than for plugins

githubrelease
giteaTag
gittag
dockerimage

Basically we retrieve a list of information and we delegate the responsability to the versionfilter to identify the value we are looking for
So this pullrequest introduced two parameters

multiple: It's used to describe that we are looking for multiple values from the json query and not only one. Because .[*].tag_name is a valid json key identifer
versionfilter: It's used to filter the result from the multiple query

In the context of a source, both must be used together

Can you update the PR description to show the result? The example is not clear on what is it doing exactly?

I added an example in the PR body

I am open to change if it makes things clearier. Ideally I would like to use the same wording for csv/toml/xml/json/yaml
Maybe @hervelemeur has some opinion too

Before merging I need to correctly deprecate the key multiple previously used for conditoin and target


support for require('@scoped/package-name')

Is it possible that browserify doesn't support scoped packages?
I'm trying to require a package that has a scope in its name:
require('@axa-ch/style-guide')

However, this fails with cannot find module '@axa-ch/style-guide'.
Also, importing the package by path didn't work neither...
require('../node_modules/@axa-ch/style-guide')

... while it would work for other modules...
require('../node_modules/baconjs')

I've never had any issues with requiring scoped packages. I'm pretty sure they should just work. Can you publish a repro case?

You're totally right @bjoerge! Everything is fine with scoped module loading...
While I was reproducing the case, I found out that my module simply missed the { main: 'js/index.js' } file. Since it didn't find the main file, browserify returned with the error cannot find module '@axa-ch/style-guide'.
While the error message could've been more precise, this is absolutely my fault. Closing. Thx @bjoerge!


Unable to associate MSBuild with custom cl bundle

I have created a striped down version of Visual Studio build tools (Only CL & rest of its dependencies), I'm unable to compile the project using MSBuild.
I tried using ClToolPath, it picks the correct cl compiler, but it uses INCLUDE & LIB path from default Visual Studio path.
msbuild /p:ClToolPath="custom/cl/path" Foo.sln
Is there a way to pass system INCLUDE & LIB paths also to msbuild?

The C++ tasks and targets aren't open source and don't live in this repo. The best way to get support for them is using the "send feedback" functionality in Visual Studio.
One note: please be careful with the licensing and redistribution of Microsoft software that isn't open source (like the C++ stuff).


dts: arm: nrf54l: Add nodes required by MCUboot

The commit adds nodes needed by MCUboot.
It also modifies chosen list by addition of MCUmgr port and code-partition.

@anangl ping, do you folks want to merge this for 3.6? It's not quite a bugfix bug you may make an argument about it

@anangl ping, do you folks want to merge this for 3.6? It's not quite a bugfix bug you may make an argument about it

@anangl ^^

I don't know if this is needed for 3.6. @michalek-no @nvlsianpu Is it?

@anangl We need this for NCS 2.6.0
Don't know whether this imply that it should go in v3.6

rebase

@carlescufi Can this be merged?

@carlescufi Can this be merged?

Formally this needs @anangl approva, we have a dashboard and this does not even show as mergeable until the approver approved. Or we can change the approver, does not touch any core file so I suppose it's fine to move over to one of the mcubook collabs.

That was easy, thanks @anangl :-)


Apply branch protection rules

first experiments

I have asked here the sig-k8s-infra WG questions we have with Stephan about the branchprotector tool.

Sure, we will announce the rollout of branch protection automation. I guess it will take some time until we have a working implementation as the branchprotector tool misses some options.

I didn't get a concrete answer by the prow community but looking into github APIs and the prow implementation I think that we need to add the required_approving_review_count parameter as documented in the Github API docs to the prow code here

I create a PR for the branchprotector to add the missing feature for PR bypass configuration.

The PR for the branchprotector is merged. I tried the feature and it looks good. We should be able now to implement the branchprotection RFC.

For the record, since @Gerg asked about it: each WG would opt into these branch-protection rules with a new config.generate_rfc0015_branch_protection_rules parameter in the embedded YAML document in the charter file. (https://github.com/cloudfoundry/community/blob/c62f00f8dbab5301f45c62d2b290357bf0537f32/org/org_management.py#L117 is the place where the automation checks for that new flag.)


[SPARK-38660][PYTHON] PySpark DeprecationWarning: distutils Version classes are deprecated

What changes were proposed in this pull request?
Using packaging.version instead of distutils.version to silence the deprecation warnings

Why are the changes needed?
PEP 632

Does this PR introduce any user-facing change?
No

How was this patch tested?
No additional tests were required and added

A reasonable PR for me. Some useful info:

distutils is deprecated since 3.10 with removal planned for Python 3.12.
distutils Version class it seems is deparecated before 3.10, that's we get distutils Version classes are deprecated. Use packaging.version instead in python 3.8.
packaging is a 3rd party lib instead of distutils std lib, it make sense to reorder import.
An alterante way is using packaging.version.parse, version.parse either returns a Version or a LegacyVersion, this might useful for if a version is not follow pep-0440. But for our case, there are only string version and numpy pyarrow matplotlib pandas version, no more legacy version possiablity, so I'm +1 using Version directly execept others guy has some other concern.

Can one of the admins verify this patch?

Well I put a slim version of packaging.version in pyspark, just like cloudpickle.

Maybe just leave this until it must change, if distutils is actually removed

Maybe just leave this until it must change, if distutils is actually removed

Well the primary intention is to silence the warnings @srowen
Also, I would appreciate it if someone could help me with the failing check.

Ok, can it just be silenced instead of changing modules?
Not sure about that error. Can you rebase and force push?

Ok, can it just be silenced instead of changing modules?

We can do something like: warnings.filterwarnings("ignore", category=DeprecationWarning) but is it better than getting rid of distutils?

Not sure about that error. Can you rebase and force push?

Last time I tried rebase and force push, no luck.

I don't have a strong opinion on it, but sure that could be better than the slight increase in complexity contemplated here. Eventually this has to be replaced, but not necessary just to remove the warning

Merged to master


Feature Request: bKGD info

Currently, there is no straightforward way to access an image's background color from the bKGD chunk.
png::stream::StreamingDecoder lacks a method to parse these chunks and png::common::Info lacks a field for this data. This chunk type is in common use and it should be accessible to the client.
The benefits of this would include displaying images with the intended background color as well as combining an image's alpha channel with the background color to produce an opaque image.

Is kBGD actually implemented by anyone? I think IE6 was the last application that couldn't handle alpha and had a reason to use it. I haven't seen any other application that used it.

Some programs will erase color data from transparent pixels when exporting an image to PNG and/or save the background color in a bKGD chunk. The current version of GIMP does both by default.

Seems reasonable to add bKGD support. Feel free to make a PR if you'd like, there's been a few recent PRs adding other chunks that you can use for reference


Schema not updated when selecting another table in Query Console Tab on Pinot UI

Copied from Slack
Context:

I've got 2 tables with 2 separate schemas
I'm on the Query Console Tab

Problem :

I click on  a table, the schema appears below it - the schema is valid (the one corresponding to this table)
I then click on the other table, the schema of the previous table remains
If I reload the page and click on the other table first, its schema remains after I click on the other table

Info:

The schemas really are different
Actually the API calls when inspecting the page return the correct schemas
So it seems it only is a UI-related issue
Force reloading Firefox page (ignore cache) doesn't solve the issue
Version is 0.7.0-SNAPSHOT-621ceb021cefa1640708f3bb4d576270717f70d6

https://user-images.githubusercontent.com/22521284/115054939-21648c80-9ee1-11eb-92b5-4e24e72f7ae7.mp4

Thanks for reporting @MrNeocore I am able to reproduce this and working on a fix for it.

Fixed and created a PR - https://github.com/apache/incubator-pinot/pull/6806


After successfully running the requisite steps, I'm getting some issues related to SystemStyleObject

Hi mParticle Team
After running the npm install and start command, I'm getting these errors showing up in the command line and also in the web browser console. Any ideas on how to fix this? Thank you

Stack trace:
TypeScript error in /Users/jhaw/Downloads/mparticle-web-sample-apps-main/core-sdk-samples/higgs-shop-sample-app/src/components/NavigationMenu/NavigationMenu.tsx(116,9):
No overload matches this call.
Overload 3 of 3, '(props: DefaultComponentProps<ExtendButtonBaseTypeMap<MenuItemTypeMap<{}, "li">>>): Element', gave the following error.
Type 'SystemStyleObject | CssVariableType | ((theme: Theme) => string | number | SystemStyleObject)' is not assignable to type 'boolean | SystemStyleObject | ((theme: Theme) => SystemStyleObject)'.
Overload 3 of 3, '(props: DefaultComponentProps<ExtendButtonBaseTypeMap<MenuItemTypeMap<{}, "li">>>): Element', gave the following error.
Type 'SystemStyleObject | CssVariableType | ((theme: Theme) => string | number | SystemStyleObject)' is not assignable to type 'boolean | SystemStyleObject | ((theme: Theme) => SystemStyleObject)'.  TS2769
114 |         </IconButton>,
115 |

116 |         <MenuItem
|         ^
117 |             aria-label='Mobile Home Page'
118 |             data-testid='mobile-nav-home-button'
119 |             key='home'

@alexs-mparticle i'm running on node v17.0.1
jhaw-mbp16:higgs-shop-sample-app jhaw$ node -v
v17.0.1

Thanks for letting me know. We developed this using node v16.x, so please try that just so we can rule out that there's something new in 17.x that's causing an issue. I'd recommend using NVM to manage your node versions locally if you can.
I'm going to set my dev environment to 17.0.1 to see if I can reproduce your issue.

Hi Alex!
I've downgraded to v16.14.0 of node but I'm still getting some issues launching the app. Any ideas?

When you downgrade, delete your node_modules folder and package-lock.json then run npm install again. That should work.

Hi mParticle Team!
After pulling this version - https://github.com/mParticle/mparticle-web-sample-apps/pull/5 and setting my environment to the following version:
node -v
v16.14.0
npm -v
8.5.4
deleted package-lock.json
run npm install
then npm start, I was able to run the sample web application without any issues
Thank you


Add ODBC driver support for the SQL Server agent

What does this PR do?

Adds support for using the Microsoft ODBC driver in the SQL Server agent for dockerized builds. This relies on this change in the datadog-agent. I tested this on a sandbox instance using the following docker command (with a test internal docker image)
docker run -d \
  -e "DD_API_KEY=${DD_API_KEY}" \
  -v /var/run/docker.sock:/var/run/docker.sock:ro \
  -l com.datadoghq.ad.check_names='["sqlserver"]' \
  -l com.datadoghq.ad.init_configs='[{}]' \
  -l com.datadoghq.ad.instances='[{
    "dbm": true,
    "host": "dbm-agent-integration-managed-instance-ao.cfcc2366ab90.database.windows.net,1433",
    "connector": "odbc",
    "ssl": "require",
    "driver": "{ODBC Driver 18 for SQL Server}",
    "tags": [
      "service:jm-test-odbc-mi",
      "env:dev"
    ],
    "managed_identity": {
      "client_id": "c8d2cd7d-3e43-46cb-9bd9-050706399f52"
    },
    "azure": {
      "deployment_type": "managed_instance",
      "fully_qualified_domain_name": "dbm-agent-integration-managed-instance-ao.cfcc2366ab90.database.windows.net"
    }
  }]' \
  registry.ddbuild.io/datadog-agent:dbm-e42db67-73ab9acfdc

... inspecting the logs / looking in the UI it looks like we are collecting information correctly (note I am generating no load, so its just agent queries)

The agent status output looks like this, which shows we are collecting DBM data properly:
    sqlserver (15.0.1)
    ------------------
      Instance ID: sqlserver:a591d2bd90702c92 [OK]
      Configuration Source: container:docker://34cef60ae06f79a9cf0825f9813ca55079b26eff2b8d0fdd94e53f28b88224b8
      Total Runs: 2
      Metric Samples: Last Run: 316, Total: 603
      Events: Last Run: 0, Total: 0
      Database Monitoring Activity Samples: Last Run: 2, Total: 2
      Database Monitoring Metadata Samples: Last Run: 1, Total: 1
      Database Monitoring Query Metrics: Last Run: 1, Total: 1
      Database Monitoring Query Samples: Last Run: 6, Total: 6
      Service Checks: Last Run: 7, Total: 11
      Average Execution Time : 6.207s
      Last Execution Date : 2023-12-14 18:38:12 UTC<PHONE_NUMBER>000)
      Last Successful Execution Date : 2023-12-14 18:38:12 UTC<PHONE_NUMBER>000)
      metadata:
        resolved_hostname: dbm-agent-integration-managed-instance-ao.cfcc2366ab90.database.windows.net

Motivation

We added support to connect to SQL Server using Azure managed authentication a few agent versions ago https://github.com/DataDog/integrations-core/pull/15591. However, the ODBC driver 17+ is required to use Managed Auth. Prior to this commit, the agent could not use the ODBC driver in docker. This limited customers ability to use this type of authentication to only self-install agents. This limits peoples ability to automate deployments / automation of the agent.
Additional Notes

During testing I noticed this being logged frequently
2023-12-14 18:33:44 UTC | CORE | INFO | (pkg/collector/python/datadog_agent.go:133 in LogMessage) | - | (_universal.py:514) | Request URL: 'http://<IP_ADDRESS>/metadata/identity/oauth2/token?api-version=REDACTED&resource=REDACTED&client_id=REDACTED'
Request method: 'GET'
Request headers:
    'Metadata': 'REDACTED'
    'User-Agent': 'azsdk-python-identity/1.14.0 Python/3.9.18 (Linux-5.15.0-1042-azure-x86_64-with-glibc2.38)'
No body was attached to the request
2023-12-14 18:33:44 UTC | CORE | INFO | (pkg/collector/python/datadog_agent.go:133 in LogMessage) | - | (_universal.py:550) | Response status: 200
Response headers:
    'Content-Type': 'application/json; charset=utf-8'
    'Server': 'IMDS/150.870.65.1125'
    'Date': 'Thu, 14 Dec 2023 18:33:44 GMT'
    'Content-Length': '2056'

Since we frequently open/connections in the agent we re-request the token every time. AFAIK these tokens have TTLs associated with them, so a nice improvement might be to cache the token locally & only re-request the token after it expires. That would prevent frequent Azure API requests while using this feature.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Error: Unable to connect to SQL Server, see https://docs.datadoghq.com/database_monitoring/setup_sql_server/troubleshooting#common-driver-issues for more details on how to debug this issue. TCP-connection(OK), Exception: Error('01000', "[01000] [unixODBC][Driver Manager]Can't open lib 'ODBC Driver 18 for SQL Server' : file not found (0) (SQLDriverConnect)") configured odbc driver {ODBC Driver 18 for SQL Server} not in list of installed drivers: ['ODBC Drivers', 'FreeTDS']

Is it still required to manually install the drivers? it seems this above is not working...

👋 hey there @marceloboeira, so yes it is still required to install the driver for a non-dockerized agent. Starting with the release of 7.51 of the agent (a few weeks from now), you can use the ODBC driver in docker. Previously we only supported FreeTDS, which doesn't work with Azure MI auth as described here https://github.com/DataDog/integrations-core/pull/15591

@jmeunier28 thanks for the quick reply. Looking forward to ODBC driving in docker <3


Centralized Locking PR

Wanted to get your input on the current implementation of testing locking/unlocking.

The tests are looking soooooo much better! There is still stuff to do on them, but the patterns are looking good. Note that the tests here will probably be the most rigorous ones in this entire project (and rightfully so given the nature of the locking code).
There is still one test missing, the test that passes both checks in RemoveStaleLocksOnce (note that because the inversion(s) this used to be slightly different). I think you should be able to make this test if you manually lock/unlock lockManagerMutex. So you can make sure a lock will pass the first guard, lock lockManagerMutex, call RemoveStaleLocksOnce on another thread, wait, edit the lock's lockData, unlock lockManagerMutex, make sure the lock still exists.

Is this not describing what TestStaleLockRetention does? The only difference being manually locking/unlocking the lock manager and manually editing the locks lockData, which TestStaleLockRetention does by just calling Lock and Unlock which automatically acquires the lockmanagermutex and resets the timestamp.


Where are performance results of experiments stored

Hi,
thank you very much for sharing your code!
I ran the example from the readme and the parts of the few-shot-pretrained-3b-100k.sh script. However, the dev_scores.json for the readme example only contains the line:

{"accuracy": 0.6101083032490975, "score_gt": 0.3983679488032303, "score_cand": 0.6958685107394676}

And for t03b_copa_seed42_ia3_pretrained100k (the first experiment of few-shot-pretrained-3b-100k.sh):

{"accuracy": 0.85, "score_gt": 0.06061243396921782, "score_cand": 0.4640417302213609}

Those are just the results of the "Validation sanity check" right at the beginning, so I wondered where the validation results after each epoch are stored or am I missing something here?
Thanks!

Hi Stefan, I came across a similar problem and I hope my solution is helpful.
I noticed that in 11b model experiments there is a flag "eval_epoch_interval=50"
https://github.com/r-three/t-few/blob/217cfa3b73aa66a07594826e4ebbbc516b331461/bin/few-shot-pretrained-11b-100k.sh#L5
So I added it to the few-shot-pretrained-3b-100k.sh as well. With this, the dev_scores.json file will have multiple lines, and the get_result_table.py will only read the last row in the dev_scores.json.

Hi Qinyuan, sorry for coming back to you so late. That was exactly what I was looking for. Thank you very much!


testdata is missing empty folders

Git does not add empty folders to a repository by design. Therefore the test for a folder structure containing empty folders and sub-folders, will fail if the code has gone into Git and back out again. There is no way to fix this when using Git. However, a workaround is for the test suite to generate the test file/folder structure first, before running the test to check a correct hash is generated. This bypasses the empty folder situation.

The test folder structure is now created on the fly by the test suite. The original folder structure has been removed as it is now redundant.


AG: Remove no longer published data from scraping

The information about risk-area-travelers is not published in the excel source anymore. Scraper will fail because the sheet is missing.

I hope the data comes back up (we will contact AG to ask). But in the meantime: thanks for your contribution.


Any Plans to integrate Mojo?

The lookup and evaluations could highly benefit from mojo especially in terms of parallelizing.

Do you mean this? It seems irrelevant to our project. On top of that, Mojo is not even open source (as of now).


Unused code?

@K-Meech @KateMoreva Are we using this class at all?
public class N5ZarrWriter extends N5ZarrReader implements N5Writer

I don't think so. The N5OmeZarrWriter is basically a copy of this class, with minor changes to make it fit the OME spec. So I think the N5ZarrWriter is a direct copy of the saalfeld lab one: https://github.com/saalfeldlab/n5-zarr/blob/master/src/main/java/org/janelia/saalfeldlab/n5/zarr/N5ZarrWriter.java

If we don't use it, we could probably remove it, is it?

If we don't use it, we could probably remove it, is it?

It was removed in develop.


Adjust cron-jobs run period

Cron-jobs should only run between 9:00 -  18:00

Closed due to #404.


Add tls authentication for redis scaler

Provide a description of what has been changed
Allow defining TLS config in TriggerAuthentication for Redis scaler.
Checklist

[ ] When introducing a new scaler, I agree with the scaling governance policy
[ ] I have verified that my change is according to the deprecations & breaking changes policy
[ ] Tests have been added
[ ] Changelog has been updated and is aligned with our changelog requirements
[ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[ ] A PR is opened to update the documentation on (repo) (if applicable)
[ ] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4917

Relates to #

Looking good but there are still some things to do, could you update docs and the changelog please?
Does adding this to redis stream too make sense?

Thanks for your review, done.

/run-e2e redis


Feature request: Add direct PostCSS support

It would be nice if Remix could support custom ESbuild plugins. In that way, plugins like esbuild-plugin-postcss could be included to avoid the need to spawn a second process (i.e. for compiling files from ./styles to ./app/styles) and overall project structure will look cleaner.
Another suggestion could be to enable PostCSS plugin by default to offer more of an out-of-the-box configuration with optimization in mind for people who want to minify/autoprefix their CSS.
By the way, awesome project. So far I have really liked it, keep it rocking 🤘🏻

We currently have a very large codebase with a hundreds of components written in css modules and webpack style css importing.
without this support we can’t really move any of our website to remix, I really hope you guys add support! Love the tool so far

Thanks

@ryanflorence @mjackson is there any plans to implement this?


Cannot resolve symbol for both RetryExceptionWrapper.class

Describe the bug
Please provide details of the problem, including the version of Spring Cloud that you
are using.
Resilience4j version: spring cloud circuit breaker version: 3.0.1

Java version: 17+
I tried updating some legacy code to JDK 17 and spring boot 3.0.7. But I noticed that the following error is thrown:
Cannot resolve symbol for both  RetryExceptionWrapper.class and CircuitBreakerOpenException . But CircuitBreakerOpenExceptionseems to be available via the
org.springframework.integration.handler.advice.RequestHandlerCircuitBreakerAdvice

dependency.
Code snippet is shown:
public Mono<MyModel> getSomeModelIdEtc(int id) {
        // DONE Auto-generated method stub
        return Mono.zip(
                        .......
                        someClass
                                .getSomeModelId(id)
                        .onErrorMap(RetryExceptionWrapper.class, Throwable::getCause)
                        .onErrorReturn(CircuitBreakerOpenException.class, getFallbackValue(id)),
    }

This just happens when changing the JDK version?  Could you provide a sample that reproduces the problem?

Do I create an example? Because the issue was encountered while working on a huge project. Seems to be disappear when I used  io.github.resilience4j.circuitbreakerand related plugins. Yes this happens with migrating the code to spring boot 3.0.7, spring cloud 2022.0.2 and JDK 17.

We are running out builds with JDK 17 and don't see that problem, so a project to reproduce the problem will help figure out what is going on.

I will try to prepare a minimal example then.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

I included a method from the following :
[https://github.com/ENate/kafka-mstreams/blob/main/composite-service/src/main/java/com/minejava/kafkastreams/compositeservice/servicescom/UserServicesCompI.java] (methodA with name userByUserId)
to demonstrate how I used the spring-boot-start-circuitbreakerresilient4j dependency:
<dependency>
            <groupId>org.springframework.cloud</groupId>
            <artifactId>spring-cloud-starter-circuitbreaker-resilience4j</artifactId>
        </dependency>

to implement a circuitbreakerresilience4j call in the following manner:
// implement getUserId for methodA
public Mono<UserserviceAg> getByUserId(String userId) {
		return Mono.zip(
			  values -> createUserAg(
				 (UserPayload) values[0],
				 (List<SubjectUtilAg>) values[1],
				 serviceUtil.getHostAddress()),
			  compositeService
				 .getUserById(userId)
				 // Legacy code uses the following
				 // .onErrorMap(RetryExceptionWrapper.class, Throwable::getCause)
				 // <<<<< Decided to change to RetryException class >>>>>>>>
				 .onErrorMap(RetryException.class, Throwable::getCause)
				 .onErrorReturn(CircuitBreakerOpenException.class, getUserFallbackValue(userId))
		   .doOnError(ex -> log.warn("getUser failed: {}", ex.toString()))
		   .log());
	}

with a call  to the method:
// Get user with given userId - methodB
    @CircuitBreaker(name = "users")
    @TimeLimiter(name = "users")
    @Retry(name = "users")
    public Mono<UserPayload> getUserById(String userId) {
        LOG.info("Getting desired used using the Id: {}", userId);
        return webClient
                .get()
                .uri(userIdString+userId)
                .retrieve()
                .bodyToMono(UserPayload.class)
                .onErrorMap(WebClientResponseException.class, this::handleException);
    }

with methodB' s link is:
[https://github.com/ENate/kafka-mstreams/blob/main/composite-service/src/main/java/com/minejava/kafkastreams/compositeservice/service/CompositeService.java](getUserById for methodB)
will result in the following exception/error:
Cannot resolve symbol for both RetryExceptionWrapper.class and CircuitBreakerOpenException

The code seems to run for now (But I need to verify the via testing) if replacing the line
.onErrorMap(RetryExceptionWrapper.class, Throwable::getCause)
with
 .onErrorMap(RetryException.class, Throwable::getCause)

Using the following dependencies seem to work
<dependency>
            <groupId>io.github.resilience4j</groupId>
            <artifactId>resilience4j-spring-boot2</artifactId>
            <version>${resilience4j.version}</version>
        </dependency>
        <dependency>
            <groupId>io.github.resilience4j</groupId>
            <artifactId>resilience4j-reactor</artifactId>
            <version>${resilience4j.version}</version>
        </dependency>
        <dependency>
            <groupId>io.github.resilience4j</groupId>
            <artifactId>resilience4j-circuitbreaker</artifactId>
            <version>${resilience4j.version}</version>
        </dependency>
        <dependency>
            <groupId>io.github.resilience4j</groupId>
            <artifactId>resilience4j-micrometer</artifactId>
            <version>${resilience4j.version}</version>
        </dependency>

but I want to stay with the spring boot stack. Thanks.

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Music Player For Goole Drive does not open music in android devices( moto g 4g LTE)

Music Player For Goole Drive does not open music in android devices( moto g 4g LTE)

I may ha ve fixed this a couple days ago. If you try this again and it doesn't work please let me know.


Last item in list view - expanding not immediately allowing scroll to reveal secondary-view

Hi @AndreiMisiukevich
This might be a bug issue (again have attached GIF of issue in action). Basically issue seems to occur when ExpandableView Item in ListView is the last item (scrolling down the page to that item is the only way to replicate as well) and when expanding does not immediately allow user to scroll down further to reveal the SecondaryView, rather what is required is to scroll up the page a certain amount and then down a few times before it expands and reveals the SecondaryView.
You can see in the GIF below that I attempt to scroll down to show the collapsed SecondaryView but that  doesnt work initially without scrolling up and down a few times.

ExpandableView: 1.0.9,
Xamarin Forms: <IP_ADDRESS>5677
Also I am using the new Xamarin.Forms.Visual.Material: <IP_ADDRESS>5677
Android Device is 5.1.1 (Galaxy Tab A 7.0 SM-T280),
I also have Target Android Version 9.0 (API Level 28) and minimum android version 5.0 (API Level 21)

Attached is a sample repo:
SampleTest.zip
let me know if you have any issues running the sample but it should be okay

Thanks
i will check
but not sure, that expandableview can be used with listView

Thanks @AndreiMisiukevich
Regarding ExpandableView working with ListView, this was working previously (this issue specifically).
I have cloned your repo sample project and had the same issue.
See attached for ExpandableView in ListView with your sample project:
ExpandableView-master (2).zip

Okay so I have manage to solve this, turns out I was wrapping a ContentView around the ExpandableView in the ViewCell, the ContentView being the root parent view in the viewCell,
Once I removed that the issue went away.
As previously mentioned this didnt seem to be an issue, but has resolved my issue.

Okay so I think the need is to call ForceUpdateSize() on the viewcell when the StatusChange Changes.
private async void onStatusChanged(object sender, StatusChangedEventArgs e)
        {
            if (e.Status == ExpandStatus.Collapsed || e.Status == ExpandStatus.Expanded)
            {
                if (e.Status == ExpandStatus.Collapsed)
                {
                    await arrowDropDownImage.RotateTo(0, 250, Easing.BounceIn).ConfigureAwait(false);
                }
                else if (e.Status == ExpandStatus.Expanded)
                {
                    await arrowDropDownImage.RotateTo(180, 250, Easing.BounceIn).ConfigureAwait(false);
                }
            }
            Device.BeginInvokeOnMainThread(() =>
            {
                this.ForceUpdateSize();
            });
        }

Can you confirm if this resolves on your end as well - applies to both issues I raised

@LeoJHarris hmm. i think it's big performance penalty..

@AndreiMisiukevich Yes but there doesnt appear to be an alternative i think.

@AndreiMisiukevich yes regarding other issue. It solves that too. Although that was a strange issue, im not sure why that was occuring in the first place. As mentioned i believe it happens on last item in listview when no remaining space on screen to display is currently visible

@AndreiMisiukevich Im not sure if worth keeping issue open, although i might try switching to not use expandableview and just toggle visibility, but i think i may need to call forceupdatesize anyhow but i try with change. At least may not have performance issue withat method

@LeoJHarris i'm sure you will have to call forceUpdateSize anyway
just wonder, what will happen if you try CollectionView WITHOUT this method

Thanks @LeoJHarris, this can be considered as workaround
private async void onStatusChanged(object sender, StatusChangedEventArgs e)
{
    if (e.Status == ExpandStatus.Collapsed || e.Status == ExpandStatus.Expanded)
    {
        if (e.Status == ExpandStatus.Collapsed)
        {
            await arrowDropDownImage.RotateTo(0, 250, Easing.BounceIn).ConfigureAwait(false);
        }
        else if (e.Status == ExpandStatus.Expanded)
        {
            await arrowDropDownImage.RotateTo(180, 250, Easing.BounceIn).ConfigureAwait(false);
        }
    }
    Device.BeginInvokeOnMainThread(() =>
    {
        this.ForceUpdateSize();
    });
}


Linter using the wrong procedure for linting

Describe the bug
If you use a copybook to define procedure prototypes, you'll most likely end up having "No reference to definition" errors on definitions in an rpg source using said copybook, even if the definitions are actually being used.
To Reproduce
Create a copybook with a prototype definition on a specific line range (e.g. 8-12). Use said copybook in an rpg source, define a field and use it once. If either the definition or the usage of said field is in the line range of our prototype definition in the copybook, then the definition will be marked as unused. It's not important if the prototype is actually being used in the copybook/rpg source or not. If you move the prototype definition to another line range which doesn't interfere with the field definition and usage (e.g. 14-18), the "no reference" warning disappears.
Example copybook:
**free
// empty line
// empty line
// empty line
// empty line
// empty line
// Some prototype
dcl-pr SomePrototype;
  Parameter1 char(1);
  Parameter2 char(1);
  Parameter3 char(1);
end-pr;

Example rpg source:
**free
ctl-opt main(Main);
/copy 'QCPYLESRC/somecopybook.rpgle'
// --
dcl-proc Main;
  dcl-pi *n;
  end-pi;

  dcl-s SomeFlag ind inz(*off);

  SomeFlag = *on;
end-proc;

Expected behavior
The linter should not be marking the definition as "No reference to definition." if it's actually being used.
Screenshots
See example code given above
Environment

Extension version v0.26.9
IBM i OS version 7.4

Additional context
I found that while looping through statements, the linter assigns the wrong currentProcedure (it's using the prototype "SomePrototype" instead of the actual "Main" procedure). Similar to #323, the corresponding .find statement shoud be extended with "&& data.uri === proc.position.path".
When trying to assign "defRef", you first check on currentProcedure scope and subItems before trying to check via globalScope. If currentProcedure isn't the procedure containing the actual definition, then you wont find the defRef there. And somehow globalScope never seems to find anything in my case. This leads the linter to not adding every reference to a definition.
As some of our (service) programs are using multiple copybooks with up to 2-3k lines, those rpg sources are flooded with "no reference" warnings and most of them are gone with this change.

@EVLSDE I just released 0.26.11 which might fix this problem.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_27211f7c-b290-4819-94ad-c15935650e23/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_27211f7c-b290-4819-94ad-c15935650e23.git

Docs Build status updates of commit 9942bf0:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/opstest2/docs-archive-test-source. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Caching of configs is undocumented and unexpected

README.md should mention that configs are cached, and whilst it may not be best practice, if you are trying to manipulate config.resource between JUnit tests, then really your only option is to call ConfigFactory#invalidateCaches.
At the moment this is undocumented and so (at least for me) unexpected behavior. I have just removed my head from the large whole in the wall I have been progressively banging it into for the last 4 hours :-(

It is documented in the reference manual for ConfigFactory.load: https://typesafehub.github.io/config/latest/api/com/typesafe/config/ConfigFactory.html#load--
What section of the README were you looking at? No harm in adding some mention there too perhaps.

@havocp Excellent thanks


Fix 735

Description

Fixes #735
Had to read on https://tomgregory.com/all-about-the-gradle-task-graph/ and use this to verify the new task is inserted in the right place. I then tested building random provider with and without the change and see that it fixes the issue.
plugins {
    ...
    id 'org.barfuin.gradle.taskinfo' version '1.0.5'
}

./gradlew tiTree publish

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works

[ ] I have updated the CHANGELOG-PENDING file with my change

[ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

Thank you!!


Cross Compile Error

When I compile with arm-gcc 4.4,I add tag "-std=c++0x".
In file included from /home/eclipse-workspace/Push/src/base/Logging.h:17,
                 from Push.cpp:12:
/home/eclipse-workspace/Push/src/log/glog/logging.h: In function 'T google::CheckNotNull(const char*, int, const char*, T&&)':
/home/eclipse-workspace/Push/src/log/glog/logging.h:1333: error: 'nullptr' was not declared in this scope

GXX_EXPERIMENTAL_CXX0X is defined while the gcc version is smaller than 4.7

Similar issue when I try to cross compile to mips_24kc with OpenWrt Imagebuilder:
src/symbolize_unittest.cc: In function 'int main(int, char**)':
src/symbolize_unittest.cc:410:3: error: 'TestWithPCInsideInlineFunction' was not declared in this scope
   TestWithPCInsideInlineFunction();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/symbolize_unittest.cc:411:3: error: 'TestWithPCInsideNonInlineFunction' was not declared in this scope
   TestWithPCInsideNonInlineFunction();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/symbolize_unittest.cc:412:3: error: 'TestWithReturnAddress' was not declared in this scope
   TestWithReturnAddress();
   ^~~~~~~~~~~~~~~~~~~~~

Similar to

https://github.com/google/glog/issues/207
https://github.com/google/glog/issues/104

glog: v0.4.0
gflags: v2.2.2

Similar issue when I try to cross compile to mips_24kc with OpenWrt Imagebuilder:
src/symbolize_unittest.cc: In function 'int main(int, char**)':
src/symbolize_unittest.cc:410:3: error: 'TestWithPCInsideInlineFunction' was not declared in this scope
   TestWithPCInsideInlineFunction();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/symbolize_unittest.cc:411:3: error: 'TestWithPCInsideNonInlineFunction' was not declared in this scope
   TestWithPCInsideNonInlineFunction();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/symbolize_unittest.cc:412:3: error: 'TestWithReturnAddress' was not declared in this scope
   TestWithReturnAddress();
   ^~~~~~~~~~~~~~~~~~~~~

Similar to

#207
#104

glog: v0.4.0
gflags: v2.2.2

Same problem, have you solved it?

I solved this issue by

reinstall gflag with -DBUILD_SHARED_LIBS=ON
do not use ./autogen.sh && ./configure to generate Makefile, instead use cmake


[Safari] Can't find variable: AudioContext

Plugin doesn't support in Safari browser.
ReferenceError: Can't find variable: AudioContext

Fix 1d92992 (1.1.4)
Thanks! 🥇


fix enum from preloaded script in export

without triggering unnecessary reloads and parsing.
Fixes #17025

Thanks!

I find this change a bit strange, I think it will fail the parse if the resource is not in the cache. It also affects all preloads, which is not always a script. How does this fare when preloading another type of resource?

The cache should load the resource using ResourceLoader, if it isn't loaded already (and in case of scripts that load triggers parsing).
Using that cache is supposed to avoid unnecessary reloading and because of that parsing.
I did a quick test by looking at the plattformer 2d demo, there the player script does some preloading of a tscn, and it didn't show any errors in the editor, unless I changed the path to something that doesn't exist.


Cannot Copy From Editor

If I select a block of text and hit ctrl+c or use the dropdown menu from edit, nothing is copied to the clipboard. Pasting into the editor works fine with ctrl+v.
Right-clicking on text doesn't show a menu to copy either so the only methods I have to copy are ctrl+c or using the edit dropdown menu and hitting copy.

@CaptainKraft Is this still valid with recent versions of Godot (1.1 or recent 2.0 alpha builds)?

@akien-mga I won't be able to test that because I'm not using the same setup anymore. I also haven't used Godot in some time.

Thanks. As there haven't been any confirmation from another user, let's assume that it was a corner case and/or that it might have been fixed.


[WIP-Improve][CDC] Upgrade debezium to 1.9.8.Final

Purpose of this pull request

Upgrade debezium to 1.9.8.Final
Does this PR introduce any user-facing change?

How was this patch tested?

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

// debezium 1.6.4.Final

    private ChangeEventQueue(Duration pollInterval, int maxQueueSize, int maxBatchSize, Supplier<LoggingContext.PreviousContext> loggingContextSupplier,
                             long maxQueueSizeInBytes, boolean buffering) {
        this.pollInterval = pollInterval;
        this.maxBatchSize = maxBatchSize;
        this.maxQueueSize = maxQueueSize;
        this.queue = new LinkedBlockingDeque<>(maxQueueSize);
        this.metronome = Metronome.sleeper(pollInterval, Clock.SYSTEM);
        this.loggingContextSupplier = loggingContextSupplier;
        this.maxQueueSizeInBytes = maxQueueSizeInBytes;
        this.buffering = buffering;
    }

https://github.com/debezium/debezium/blob/c6c40201d2a3cf70832525d77f87fc3270af145f/debezium-core/src/main/java/io/debezium/connector/base/ChangeEventQueue.java#L87-L98
// debezium 1.9.8.Final

    private ChangeEventQueue(Duration pollInterval, int maxQueueSize, int maxBatchSize, Supplier<LoggingContext.PreviousContext> loggingContextSupplier,
                             long maxQueueSizeInBytes, boolean buffering) {
        this.pollInterval = pollInterval;
        this.maxBatchSize = maxBatchSize;
        this.maxQueueSize = maxQueueSize;
        this.queue = new ArrayDeque<>(maxQueueSize);
        this.loggingContextSupplier = loggingContextSupplier;
        this.sizeInBytesQueue = new ArrayDeque<>(maxQueueSize);
        this.maxQueueSizeInBytes = maxQueueSizeInBytes;
        this.buffering = buffering;
    }

https://github.com/debezium/debezium/blob/393291bba54edc745f45a679ffd7b2aa7110f454/debezium-core/src/main/java/io/debezium/connector/base/ChangeEventQueue.java#L84-L94
Some JdbcSourceFetchTaskContext class (like MySqlSourceFetchTaskContext) set  size of ChangeEventQueue on Integer.MAX_VALUE. It will lead OOM because ArrayQueue  preallocated memory after upgrade debezium to 1.9.8.Final.
https://github.com/apache/seatunnel/blob/7b48a1674f0b2d6e978fb7c9ad30cbb2cc99cf87/seatunnel-connectors-v2/connector-cdc/connector-cdc-mysql/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/source/reader/fetch/MySqlSourceFetchTaskContext.java#L125-L145

https://github.com/debezium/debezium/commit/858557d1846f229bbebe81fb697a6f9b7efa874b


Updated test case with for data-prepper jenkins job

Description
This PR updates the test case for the data-prepper job with a different approach, which does not mock our the libraries.
We can see from the txt file, that the sign.sh script is being called for /tmp/workspace/release/archives/linux/build/distributions and .sig which is the expectation. These details will be more apparent and useful as the library being used is made more complex.
I have also mocked sh whose output was being used for printArtifactDownloadUrlsForStaging. Looking at the txt file, we can see that print is called for artifact.tar.gz and artifact.tar.gz.sig which is the expectation.
Issues Resolved
https://github.com/opensearch-project/opensearch-build/issues/1450
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dlvenable - Tagging you here for review since I am not able to add you to the reviewers. Thank you in advance for your inputs!

I like this better than mocking the libs, but I don't like how we throw the kitchen sink of variables. It's too easy to copy from another job and we end up with a bunch of setup we don't need. So maybe we can get the best of both worlds by creating setup functions that map to each library? For example setupUploadToS3() that corresponds to uploadToS3()?

I was thinking something similar. But, I think it would also be important to have a verifyUploadToS3().
The current implementation inserts all the details of the uploadToS3() method. I think this test would be better if instead of that, we have a verifyUploadToS3() method. This can verify that the inputs are valid. So for example, it can check that file is a valid local path or path is a valid S3 path.
This method could be maintained along with the actual implementation of uploadToS3(). In this way, changes to the implementation require changing only one additional function: verifyUploadToS3(). I think this will be much better than changing boilerplate strings throughout the code base.

I like this better than mocking the libs, but I don't like how we throw the kitchen sink of variables. It's too easy to copy from another job and we end up with a bunch of setup we don't need. So maybe we can get the best of both worlds by creating setup functions that map to each library? For example setupUploadToS3() that corresponds to uploadToS3()?

I was thinking something similar. But, I think it would also be important to have a verifyUploadToS3().
The current implementation inserts all the details of the uploadToS3() method. I think this test would be better if instead of that, we have a verifyUploadToS3() method. This can verify that the inputs are valid. So for example, it can check that file is a valid local path or path is a valid S3 path.
This method could be maintained along with the actual implementation of uploadToS3(). In this way, changes to the implementation require changing only one additional function: verifyUploadToS3(). I think this will be much better than changing boilerplate strings throughout the code base.

I am not 100% sure I understand what you're proposing with verifyUploadToS3(), would like to see it.

I like this better than mocking the libs, but I don't like how we throw the kitchen sink of variables. It's too easy to copy from another job and we end up with a bunch of setup we don't need. So maybe we can get the best of both worlds by creating setup functions that map to each library? For example setupUploadToS3() that corresponds to uploadToS3()?

I like this idea. I'll implement these here. We could extend the suite as the tests grow. Maybe we can have a class which holds all these functions that does the setup? Then every test could call functions from the same class

I'm putting together a quick concept that I'll share as a draft PR shortly.

@dblock , @abhinavGupta16 , I put together a quick draft PR: #1483.
I also think this concept could be extended to check that sh is used only for known commands. Or perhaps just check for common mistakes. This could have helped with my original usage of wget when curl was the only option.

Codecov Report

Merging #1471 (9cdca8a) into main (fa1f6f2) will decrease coverage by 7.70%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1471      +/-   ##
============================================
- Coverage     94.45%   86.74%   -7.71%
  Complexity       12       12
============================================
  Files           141       23     -118
  Lines          3084       83    -3001
  Branches          8        8
============================================
- Hits           2913       72    -2841
+ Misses          164        4     -160
  Partials          7        7

Impacted Files
Coverage Δ

tests/jenkins/jobs/SignArtifacts_Jenkinsfile
100.00% <ø> (ø)

tests/jenkins/jobs/UploadToS3_Jenkinsfile
100.00% <100.00%> (ø)

src/assemble_workflow/bundles.py

src/assemble_workflow/dist.py

src/ci_workflow/ci_args.py

...teg_test/integ_test_start_properties_opensearch.py

src/build_workflow/build_args.py

src/run_checkout.py

...rkflow/integ_test/service_opensearch_dashboards.py

src/sign_workflow/sign_artifacts.py

... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa1f6f2...9cdca8a. Read the comment docs.

Moving towards a model where the direct dependencies are explicitly setup is great, as seen here with using applying bindings for UploadToS3. This means that contributors don't need to understand the functionality of the dependency exactly, but can still benefit from configuration/validation used.
I would recommend having a way to register all of these at once in the beginning of a test, which enforces that for each registered component its configuration and validation are executed.

The developer would be forced to add setUpVariables function, otherwise, the test would fail to run. Although, I am not sure how to enforce that all verifyParams methods are called after calling the job automatically. Any suggestions?

Quickly written in notepad, so no guarantees this is copy-pastable.  Here is an example if PrintArtifactDownloadUrlForStaging() was the library function that we wanted to cover.  The new class that implements LibFunctionTester looks similar to what you've already setup with some minor differences, the arguments to verify are passed into its constructor, and it uses those parameters as fields to perform the configuration / verification.
This allows for the parameters to be used in the test case in additional ways over time, also allows for sensible defaults to be used if nothing is provided by the caller.
/** For shared library functions provide a way to configure the tests */
interface LibFunctionTester {
   public void configure(Helper h, Bindings b);
   public void verify(Helper h);
}

public PrintArtifactDownloadUrlsForStagingTester implements LibFunctionTester {
   public PrintArtifactDownloadUrlsForStagingTester(List artifacts, String uploadPath) {...}
   public void configure(Helper h, Bindings b) {
        b.setVariable('filenamesForUrls', this.artifacts)
        b.setVariable('UPLOAD_PATH', uploadPath)
   }
   public void verify(Helper h);
      def calls = helper.callStack.findAll { call ->
            call.methodName == 'printArtifactDownloadUrlsForStaging'
        };
     assertThat(calls.size(), equalTo(1))
     assertThat(call.get(0).args.artifactFileNames.first(), equalTo(this.artifacts))
     assertThat(call.get(0).args.uploadPath.first(), equalTo(this.uploadPath))

     def echoCalls = helper.callStack.findAll { call -> call.methodName == 'echo'};
     assertThat(echoCalls.size(), equalTo(this.artifacts.size()))
   }
}

public TestUploadToS3 ... {
   public TestUploadToS3() {
      this.registerLibTester(new PrintArtifactDownloadUrlsForStagingTester(
         ['file1.txt', 'file2.txt'],
         '$workspace/release/archives/linux/build/distributions'
      ))
   }
}

public BuildPipelineTest ... {
   private List testers = [];
   public void registerLibTester(LibFunctionTester tester) {
     testers.add(tester)
   }
   public void setup() {
      ...
      testers.each(tester -> tester.configure(helper, bindings))
      ...
   }
   public void after() {
      ...
      testers.each(tester -> tester.verify(helper))
      ...
   }

new PrintArtifactDownloadUrlsForStagingTester(
['file1.txt', 'file2.txt'],
'$workspace/release/archives/linux/build/distributions'
))

Thank you for the suggestion. I have implemented this.

@dlvenable - Updated the test design


Tried all options but stretching isnt filling up the whole screen

Are you looking for an option for filling the screen ignoring the aspect ratio?


Error on ob deploy push

I'm running MacOS mojave.
After updating the obelisk thunk in my project I get this error when trying to run ob deploy push
error: a 'x86_64-linux' with features {big-parallel} is required to build '/nix/store/69dl1mqva8b62d0wm31wkbqip
5fm5zq2-linux-4.19.87.drv', but I am a 'x86_64-darwin' with features {benchmark, big-parallel, nixos-test}

Process exited with code 1; nix-build /Users/aallen/Documents/haskell/reflex-retro-deploy2/src -A server.system
 --argstr hostName ec2-1-11-111-111.compute-1.amazonaws.com --argstr adminEmail<EMAIL_ADDRESS>--args
tr routeHost ec2-1-11-111-111.compute-1.amazonaws.com --argstr version 9a5245e53dd83195824d0718719f173dac1e5532
 --arg enableHttps false --builders $'obelisk-docker-nix-builder x86_64-linux /Users/aallen/.local/share/obelis
k/nix-docker-builder/id_ed25519_obelisk_vm 1 1 kvm' --no-out-link

Not sure what the current state is but deploys from macOS are a different story: https://github.com/obsidiansystems/obelisk#from-macos

I'm able to deploy with an older revision of obelisk without issue, but after updating to latest I get the above error.
This is the older revision, which does work:
-  "rev": "4f2d3f1c1312d833ae814b7a86cf7b65ea0614ec",
-  "sha256": "1shk8yy5pbakcw8aq6b8s3g2xblzf24l78mq0ca0asnvifnp83yb"


/en-US/docs/Web/API/SVGGraphicsElement getScreenCTM

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details
Windows 10, Firefox(73.0b9 (64-bit)) and Chrome (79.0.3945.79 (Official Build) (64-bit) ;
Looking at an svg element in the browser console it turns out to be an SVGSVGElement and
calling getScreenCTM() on it returns and SVGMatrix.
The current MDN content for SVGSVGElement does not mention getScreenCTM() but says SVGSVGElement  inherits from SVGGraphicsElement which does list getScreenCTM() as a method but says it returns a DOMMatrix.

Also, when/if updating the docs it would be good to mention that getScreenCTM is a misnomer/misleading (as mentioned in the docs). The matrix returned relates to the SVG's containing document or viewport (more confusion possible there with "SVG's viewport")  and not the screen.


Question: Can aqt install qtcreator?

I was trying to install the latest qtcreator w/o the "online/offline" installer both of which have issues w/ the platform plugin.

The prerelease versions of aqt (v2.0.0b5) can install qtcreator using this command:
    $ aqt tool <host> <target> tools_qtcreator

The stable release of aqt (v1.2.4) has an older version of the aqt tool subcommand; using it will require that you read some Updates.xml files at https://download.qt.io/online/qtsdkrepository/ to find out the version and PackageUpdate that you want to install; I do not recommend this.
However, you mentioned before that you were running debian buster on a Chromebook. In my experience, Debian runs in a VM on Chromebooks, and it cannot launch GUI apps. Be aware that this might be a problem.

Hi David,
Thanks for the info.  I'll give it a shot.  It seems crostini has come a long way, I can run all kinds of GUI apps (gitkraken, emacs, qtcreator, etc.) w/o any serious issue.  There are some visual quirks in qtcreator (pop-up windows that don't stay in the viewable area if you click too near the top of the editor window; I mostly use shortcuts so it is doesn't bother me much).  There is an issue using the debugger where I try to click on a set breakpoint that it pops up the complete list of breakpoints which I really dislike (tooltips on steroids).  I'll provide feedback.  What is it looking for ?

In case someone else tries qtcreator on debian, there is a missing liib libxcb-util.so.1 which can be fixed by making a sym link to libxcb-util.so.  QtCreator 4.15.2 works like a charm w/o the obnoxious "breakpoint popup".


Fix possible deadlock  in durable mode on CloseAndFlush()

A bit of regression was introduced in the last rapid release: calling Dispose()/CloseAndFlush() from UI context while there is an outstanding work will result in deadlock. Correct fix is to use ConfigureAwait(false) everywhere inside tick handler or setting SynchronizatonContext to null before calling it.

Ah, thanks. Will push this one through.


Fix HTTP Method in JWT login request to be a POST

When trying out JWT login into Vault I got errors on the vault server saying GET was not supported. Looking at the API docs and the source comments shows it should be a POST.
Changed the method to be POST and the code runs successfully now.

Nice catch, thanks for the PR.


Implements ms_teams params as configurable env variables

Hello jertel and community,
first i want to thank you for the great work with elastalert2. We are using it at work and are so happy to have it. I wanted to give something back.
We had the requirement not to add credentials (like usernames, password, but also webhook urls) into the repository of the rules. We are handling credentials in kubernetes secrets all the way. So i created this pull request. And this is what it does.

Remove the requirement for the ms_teams_webhook_url setting in the Microsoft Teams alert - basically transforming this to an optional setting. Still works if set though.
Instead enables the user to define an environment variable that contains the value for the setting

The process works like this

The user can define a new prefix variable in the alerter settings like this: ms_teams_env_prefix: "MY_PREFIX"

Then the user will create an environment var using the prefix and the fixed identifier for the settings like this: MY_PREFIX_MS_TEAMS_WEBHOOK_URL="https://webhookurlhere"

This will enable the user to create various env variables for various teams alerters by just changing the prefix or even using the same prefix if the webhook url is used more than once

Then just use the alerter as normal

This also works for the proxy setting, too. You can set it via env variable but this is optional, too. It also uses the prefix.

Documentation is updated and included
Tests are updated and included for the new additions

Please let me know if i could do something better or something is not correctly done. I am not that fluent in python :)
Best regards, keep up the good work

This PR appears to include two concepts:

Introduction of an environment prefix, so that rules can pull secrets from a pool of secrets tied to an environment.
The ability to pull environment variables from the OS during rule initialization.

The first concept is interesting and I can see the usefulness but I believe something like this would be best applied across all rule and alert settings, rather than only being supported for a single alerter, in this case MS Teams.
The second concept seems to be replicating YAML parsing functionality that can already substitute environment variables during the rule parse phase, rather than during the (later) rule initialization phase. Please take a look at this PR which was accepted into the project several weeks ago: https://github.com/jertel/elastalert2/pull/149.
Given that #2 can be accomplished today with $FOO values inside of rule yaml, I'm not sure that there is much value then to adding #1. When I hear "environment" I think of DEV, PRE-PRODUCTION, and PRODUCTION. In that type of environment structure there would not be a need to include an environment prefix, because each environment would only ever have a single set of secrets defined. Perhaps you could give an example of how you're using environments to better illustrate the benefit.

I forgot to delete the code that I think I added to teams.py for confirmation during development.
teams.py L28
print(webhookUrl)
teams.py L31
print(self.ms_teams_webhook_url)

Hey @jertel
thank you very much for your time! :)
I will have a look at your advice in a few days - currently in release stress.
Regarding the environment variable question:
We are deploying on k8s so indeed we have different cluster nodes etc. for each deployment environment (staging, production ...)
What I wanted to accomplish with this is, we are using various rules with teams webhook alerts per deployed environment - so we need various environment variables with different webhook urls for different teams channels. That's what the prefix is for. To distinguish between the different specified alerts because the name of the  MS_TEAMS_WEBHOOK_URL env variable is the same for each rule without a specifix prefix. So like this we could define one prefix per teams alert definition and one teams webhook url per alert definition in the same environment.
But i think your proposal is better anyway so i will have a look again in a few days.

Closing this PR due to staleness. I suspect @dNvl chose to utilize the proposed solution in https://github.com/jertel/elastalert2/pull/290#issuecomment-868774372.


Adding oled to ecrf?

How hard would it be to add an oled screed to the board using an arduino oled and header pins

There are currently no visible pads to solder this. You will need to solder this directly to the pins of the ESP

Is there a license I can buy from you to purchase the complete schematics,
bom and gerber files to make only 1? I would like to build 1 and try to add
a couple functions as well as redesign it a little and make extremely good
quality enclosures with my creality cr-30 3d printer. I would be more than
happy to share all of my work back with you and send you anything you need.
Please help me, I have been completely obsessed with this project and can't
sleep because of all the ideas I have.  I can't find a single one to buy
anywhere and I'm so impatient.  Thank you for the reply, I how to hear from
you soon.
On Mon, Feb 7, 2022, 6:05 AM Joel Serna Moreno @.***>
wrote:

There are currently no visible pads to solder this. You will need to
solder this directly to the pins of the ESP
—
Reply to this email directly, view it on GitHub
https://github.com/joelsernamoreno/EvilCrow-RF/issues/21#issuecomment-1031393288,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATZ5VPAAWWO6TXXJFEQ5AWLUZ6YPRANCNFSM5NWIMV7A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Are there any Java examples for reading dhall files?

Not familiar with Scala, was wondering if there are any Java examples? I cursorily looked at the repo to find any test files in Java but couldn't find any.
Would be very helpful for intro to this lib.

Agreed, thanks. I haven't had much time to work on this library lately, but this is something I'll try to prioritize when I do.


Skip CRDs from disabled Dependencies

Performing a helm show CRDs will display CRDs from a disabled dependency.
In the example Chart.yaml below, if maester.enabled is set to false, CRDs will still be installed. CRDs from oathkeeper maester will be shown with helm show CRDs.
apiVersion: v2
appVersion: "v0.40.1"
name: mychart
version: 0.28.0
...
type: application
dependencies:
  - name: oathkeeper-maester
    version: 0.28.0
    condition: maester.enabled
    alias: oathkeeper-maester
    repository: file://../oathkeeper-maester
    # repository: https://k8s.ory.sh/helm/charts

A similar issue was raised here, and @mattfarina asked for an example of why this would  be helpful and for whom.
If  a helm chart is to be redhat certified, it must contain no CRDs, so any charts that use another (optional) subchart cannot be certified.
Edit 28/02/23: As @fenech points out, the install command works as expected
Output of helm version:
version.BuildInfo{Version:"v3.10.2", GitCommit:"50f003e5ee8704ec937a756c646870227d7c8b58", GitTreeState:"clean", GoVersion:"go1.19.3"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:28:09Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"0", Minor:"1", GitVersion:"", GitCommit:"", GitTreeState:"", BuildDate:"", GoVersion:"", Compiler:"", Platform:""}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):

Is this something you can contribute?

CRDs will still be installed

This isn't true. They will show up in the output of helm show crds but they will not be installed if the chart that defines them is disabled.

Together with @stephenpmurray, we have identified the source of the issue and would like to discuss some possible fixes before making any changes.
The underlying issue is that loader.Load adds all dependencies to the chart object that it returns, regardless of whether the subchart is enabled. This is usually corrected after that, by calling chartutil.ProcessDependencies, which resets the list of dependencies based on the chart's values. This is why e.g. helm install and helm template both work as expected.
So our proposed fix would be to make sure that we also call chartutil.ProcessDependencies in this case, and there are a few places that we could do that:
1. Inside loader.Load
This would ensure that any chart object created by this method would always have its list of dependencies set according to the chart's built-in values.
2. Inside action.Show
We could adapt the Run function to behave like action.Install, and filter out any disabled dependencies here.
This feels like the right place to do it, but it wouldn't fix existing code that calls:
c := loader.Load("/path/to/chart")
c.CRDObjects() // this would still return the full list, including CRDs from disabled charts

3. Inside CRDObjects()
Since we have a "getter method", we could reprocess the dependencies when this method is called. But since chartutil.ProcessDependencies also requires some values to be passed, this would involve changing the signature of CRDObjects to pass values into there.
What do you think?

3 is out for helm 3 because that would be a breaking change.
2 seems the least intrusive and the least likely to break any API users that have built their own software against known behavior.

I'm not sure if the issue should be closed, given that there is a pull request with a proposed implementation awaiting review.


Configuration flag: restart if you haven't gotten an event

@victorges  Does this relate to any ongoing product priorities? Trying to figure out the priority of some of these backlog tickets.

@pglowacky This is more of a reliability workaround, which was thought when we were having a lot of connectivity errors between analyzer and RabbitMQ. This started happening much less often in the past few weeks, since @iameli improved our nodes situation regarding disk&cpu pressure and upgraded our wireguard version and that apparently improved the RabbitMQ reliability.
I'm going to close this one for now, and we can re-evaluate if we want it in the future. But we probably don't need it right now (it was very much a workaround since inception).

Actually, this is still happening. We might need to implement it when we have time to kill some tech debt that affects our (stream health) reliability.


Expose props to CatalogGraphPage

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@benjdlambert   Updated the changeset. but still it's failing

@benjdlambert can you pls review ?

@benjdlambert , want to track progress for same. Need this feature for CatalogGraphPage at earliest. 🙂

@shubhamjajoo I think that the original issue has been fixed for those types now, do you want to try and rebase this? :praY:

https://github.com/backstage/backstage/pull/17427

@benjdlambert rebase my branch.
PTAL once.

@benjdlambert can you pls review and merge this?

Thanks


Checkout ORT vs syft for generating SBOM

Is your feature request related to a problem? Please describe.
No known problem.
Describe the solution you'd like
Currently this project auto generated SBOM with syft. After attemting the SBOM Devroom on the fosdem I'm currious if ORT will be generating a better SBOM than syft.
Ort claims, that it will include not just software dependencies from the package manager, it will also include warpped libs like from C++. Also, is has an Open Source Policy Checker included.
If this works as promised, we could run ORT on each PR for OpenSource licencing check and generate the SBOM with it.
Describe alternatives you've considered
Keep using syft
Search

[X] I did search for other open and closed issues before opening this.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Additional context
No response

I think this is a topic where a lot of stuff is happening currently. E.g. github released sbom export a few days ago: https://github.blog/2023-03-28-introducing-self-service-sboms/. Tbh I don't know much about it so I don't have much opinion on it.


feat: Add after_block_num to the faucet

This PR introduces a current_block_number to the FaucetClient and spawns a thread while running the faucet that is in charge of updating the current_block_number after CHAIN_TIP_UPDATER_INTERVAL time.
This PR also addresses an issue with the .masm file adding the execution hint field.
Closes #440

Would the solution proposed by @igamigo in https://github.com/0xPolygonMiden/miden-node/issues/440#issuecomment-2297068005 be simpler than a separate task?


Editing the manifest lands in following error

CannotDeleteEnabledEntitlement

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b43c1f83-067b-e79d-fe7b-572beb92f135
Version Independent ID: 07a83ff0-b3e2-402a-1184-755cfe34e27e
Content: Deploy Azure Blockchain Workbench
Content Source: articles/blockchain-workbench/blockchain-workbench-deploy.md
Service: azure-blockchain
GitHub Login: @PatAltimore
Microsoft Alias: patricka

#2 in following is confusing.. Existing applications doesn't allow editing the id, when I didn't change the existing id - then the save happened successfully
Modify application manifest
Next, you need to modify the application manifest to use application roles within Azure AD to specify Blockchain Workbench administrators. For more information about application manifests, see Azure Active Directory application manifest.
For the application you registered, select Manifest in the registered application details pane.
Generate a GUID. You can generate a GUID using the PowerShell command [guid] :: NewGuid () or New-GUID cmdlet. Another option is to use a GUID generator website.
You are going to update the appRoles section of the manifest. In the Edit manifest pane, select Edit and replace "appRoles": [] with the provided JSON. Be sure to replace the value for the id field with the GUID you generated.

Looks like a known issue from Portal side
https://feedback.azure.com/forums/169401-azure-active-directory/suggestions/19002091-bug-unable-to-delete-an-application-s-approle
Alternative solution
https://stackoverflow.com/questions/43517110/deleting-an-applications-approle-in-azure-active-directory

Yes @Saurabh I am unblocked.. but the documentation needs to be changed to ensure the Id is not replaced with new GUID created... Agree?

@mganeshphani Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

@SaurabhSharma-MSFT Do appreciate your redirection to content author's.. have a nice day.

@mganeshphani Thanks for the feedback. In future updates, it's likely several of the prerequisite Azure AD steps won't need to be documented. So, these steps will likely go away. Did you have a suggestion how to make it more clear? The documentation only highlights updating the appRoles section of the JSON.
Thanks,
Pat
#in-progress

@PatAltimore The basis of confusion is related to editing the app manifest in UI with the new GUID generated.. the scenario did work for me, even without editing the app manifest.. hence I believe this section can be ignored

@mganeshphani As far as I know, you still need AppRoles defined for the Blockchain Workbench administrator functionality to work correctly. That section needs to be part of the article.

#please-close


Would it be possible to release this on opam?

I'd like to use this library in one of my own packages.

It is. You may have to wait until tuesday though.

https://github.com/ocaml/opam-repository/pull/5901


An inference driver in a local env without onnx-mlir

A model can be compiled directly with the onnx-mlir docker image. A python script using subprocess is provided at onnx-mlir/docker/onnx-mlir.py. I also tried to do the same task with docker package to hide the details of start docker and mount the disk. ( will be checked in).
Now many of us run into the issue: how to use the compiled result, say model.so, to performance inference?
Inside the onnx-mlir container, we use the script PyRuntime.py to create and run the ExecutionSession. This pyruntime.py relies on the built library PyRuntimeC..so, which convert python tensor to c array with pybind11.
If I tried to the compiled PyRuntimeC..so, along with PyRuntime.py from docker image into my local env.  However, the PyRuntimeC.*.so cannot be imported by PyRuntime.py in the local env because of the mismatch of the python version between the python inside the docker and the one in the local env.
ldd lib/PyRuntimeC.cpython-310-s390x-linux-gnu.so
	linux-vdso64.so.1 (0x000003ffd1ffe000)
	libpython3.10.so.1.0 => not found
	libstdc++.so.6 => /lib/s390x-linux-gnu/libstdc++.so.6 (0x000003ff9a200000)
	libm.so.6 => /lib/s390x-linux-gnu/libm.so.6 (0x000003ff9a100000)
	libgcc_s.so.1 => /lib/s390x-linux-gnu/libgcc_s.so.1 (0x000003ff9a500000)
	libc.so.6 => /lib/s390x-linux-gnu/libc.so.6 (0x000003ff99f00000)
	/lib/ld64.so.1 (0x000003ff9a880000)

Q1: can we make the two python versions the same? I do not know the answer. Even if it solves the problem, this solution has obvious limitation.
Then I tried to build the PyRuntimeC.*.so locally. But  the current code for ExecutionSession is using llvm::sys::DynamicLibrary to handle the model.so. We need to break that dependence to llvm. We will keep the pybind11 locally.
Q2. Can we make this approach work?
@gongsu832 suggested to use cython to break all the dependences. Here is an educational link he provided.

Currently PyRuntimeC..so is built during onnx-mlir building. Can we separate them? say, PyRuntimeC.so will be built later when we build the python interface package. By that way, the python package would use the current python verson in the user machine.

Exactly, as we discussed with Tong, the idea would be to split the Runtime dir into a RuntimeSupport and RuntimeForInference with all the code that is needed for the Python interface to go in the RuntimeForInference and the stuff that is helping our binary run (e.g. compute random, unique maps..., print tensors...) goes into the RuntimeSupport. That later one can use LLVM galore, as it is compiled with onnx-mlir. RuntimeForInference, however, should be ideally gcc/clang agnostic, not dependent on anything LLVM/MLIR so that it can be build "from scratch" in "any" environment without dependences on anything but standard packages.
Note the names are my own, and can be changed as you may see fit.


API docs license

Hi
I'm looking to add .NET Core to DevDocs (https://github.com/Thibaut/devdocs). However, it seems the API docs are not generated from code at https://github.com/dotnet/corefx. Any idea where this content is coming from and what the license is?
Thanks

You're right @Thibaut. They are not currently being generated from the source in corefx but they will be eventually. Currently, they're being generated from the IntelliSense files.
I don't know about the license. Maybe @richlander can comment on that.

Hello. These docs would be very interesting as a developer often on the go. Any news about the license?

Cool, thanks for following up.
I think I've got everything I need to get started. For the API docs it'd be great if you could make a static HTML version available to download. Otherwise I have to scrape the website directly, which takes longer.
I see that you've changed the license of the ASP.NET docs to CC BY which is also very cool. CC BY-NC was too restrictive for DevDocs.
I'll post here once the docs are up.

@chenkennt do we have the HTML files for our API docs somewhere?

No, the only way is to get the html is to scrape the website.

@Thibaut We're definitely interested in helping you. Right now, we're working through getting our docs (API and conceptual) established. There are lots of improvement's we're asking the team to make on the doc tools. Once we get past all of that, we'd be happy to look at a better hand-off mechanism. For now, screen scraping is the best bet. Sorry about that, but it's really the best we can do for now.
Glad you like the licensing changes. I've been getting all our docs moved to CC-BY. We also had some other content than was CC-BY-NC that we got changed.
You can contact me offline if you want to discuss details: rlander@ms

Quick followup: I look into adding the .NET docs to DevDocs a little while ago but realized that without the API docs + with the guides being very much work-in-progress, the docset would probably not be that useful, and might cause support debt on my side (people wondering why the API docs are missing).
I'll wait for the API docs to be released under CC-BY before doing all the work.

There, From what I see here (https://github.com/dotnet/docs/blob/master/license.txt), the license has been updated, but this issue hasn't been updated.
@Thibaut is there sufficent for you to include .net documentation into DevDocs ?

@cmaneu see my comment above. The .NET API docs are currently not part of this repo. AFAICT they're unlicensed / subject to docs.microsoft.com's terms of use, which prohibit redistribution.

The API docs will be made open relatively soon, I expect in H1 2017. This is a strong goal of ours.

We've open sourced our API docs earlier this month. 🎆

Thanks @mairaw and @richlander.
There's still a major blocker for me to add your docs to DevDocs, in that I'd need a static version to scrape/convert into DevDocs format locally (https://docs.microsoft.com/en-us/dotnet/api/ doesn't work / isn't crawlable without JavaScript + the documentation is huge, so scraping the website isn't really an option), but this is unrelated to this GH issue, so I'll close it.

@Thibaut is there another GH issue I can follow about that?


NR-17236 make SM subset of GM for ext-factorio_game

The goal of this PR is to make SM a subset of GM.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Albert Bres seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add preglobal lane lines to dash display

Confirm if ES_LDW has the required signals to show left and right lane in the dash. Rename the message and signals to same as Global (ES_LKAS_State LKAS_Left_Line_Visible, LKAS_Right_Line_Visible)?

Also requires finding Counter and Checksum fields for preglobal ES_LKAS_State (ES_LDW)


seaweedfs: 3.34 -> 3.38

Description of changes
Repo is now under the seaweedfs org.

Changelog: https://github.com/seaweedfs/seaweedfs/compare/3.34...3.38
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 208950 run on x86_64-linux 1

1 package built:

seaweedfs


Connection problem between ROS2 in WSL2 and Unity in Windows(In ros2-for-unity)

Hello! Thank you for your outstanding work.
I am trying to build a system, which includes using ROS2 robots and some of its tools.
However, I don't want to install ROS2 on Windows, as it doesn't meet my actual needs, so I installed ROS2 in WSL2 and have modified the system to RMW=rmw_cyclonedds_cpp，ROS_DOMAIN_ID=42.
On Windows, I have installed Unity and used the standalone version of R2FU, and through the system environment, I have modified the system to RMW=rmw_cyclonedds_cpp, ROS_DOMAIN_ID=42.
But when the Unity project is running, it can't connect to the ROS2 system in WSL2.
I'm sorry, I don't know if there is any special instruction or setting to enable it.
I don't know where to write this request, so I decided to write it as a question.
Thank you for your help.

This is not a problem with Unity - WSL2. Apparently, if one installs ROS2 on Windows and WSL2 on the same machine, the two are not able to communicate. This has something to do with the communication/firewall settings of WSL2 and windows.
The best you may achieve is seeing topic names being listed on WSL2 when you run a node on Windows but nothing more.
I had to install husarnet  on both my Windows and WSL2 system to get around this issue. I also had a standalone build in Unity of R2FU for unrelated reasons and the only way for ROS2 nodes in Unity were able to talk to the ROS2 nodes in WSL2/any other machine was via husarnet.
P.S. I am not sure if it works without an explicit installation of ROS2 on Windows as well but you can give it a try since you now know that there is a limitation outside of Unity :smile:


Kgostic issue14 addrenvinstall

Closes issue #14
Feel free to reject Sam if you think there's a better solution

Ok, we can trash it.


add dark/light mode

adding dark/light mode themes switcher which enhance the user interface

add label Hacktoberfest label 2 pls!!

@harshit1142 add gssoc ext label

This project is not under gssoc ext


Better exception management for the software

The software lacks some exception management right now.
The idea is to manage failures to find a file, a model ... And to notify the user of the exact error.
Ideally the user should never encounter a Python error when launching the software axondeepseg.

Related to issue #76 (Implement more complete testing module), the exception handling should be tested for as well.

[ ] Add exception handling for case in issue #29

Stale / been done piecewise over the years, it's much better than when this issue was opened


Issue defining multiple assets in trades.js

Hello again. I am facing another issue that I am unable to solve on my own. I defined multiple assets for buying in trade.js however I am getting a syntax error again and I can't figure out where my snytax is wrong. I tried to follow how trades are defined in the .env file with { and } encapsulating every asset, but I get the error below. I tried without { and } and with a singe { and } encapsulating the entire list of 5 assets but nothing works.
It looks like the bot is taking issue with the { in line 14, the second asset, and I do not know why.
See screenshot below.

Can you help me one more time?

 The , is in the wrong spot. It doesn't have to be behind the WED, but behind the }, ...


Terminal doesn't show with VSCode 64bit

VSCode Version: 1.14.2 64bit
OS Version: Windows 10 Creator Update

Steps to Reproduce:

Open VSCode 64bit
Toggle Terminal

Reproduces without extensions: Yes

Duplicate of https://github.com/Microsoft/vscode/issues/27915


scrollOffsetX and scrollOffsetY can't renew State

I have many tabs. Every tab have the data-grid. When I switch the tabs, scrollOffsetX and scrollOffsetY cannot be updated as previously set.
Bug only if value does not change
It's only true when switching tabs for the first time
### Tasks

can you please explain in more detail?

I set scrollOffsetX={2000} and Switch tabs back and forth between the two as tabs sheet
scrollOffsetX will be return to default (0)
even though I set it to 2000

I apologize for the delay. I really need a demo. I dont understand what is wrong still.


fix: Issue #14: Resetting Global color in config does not work as expected

Goal
To be able to change the config. Meaning that you can now change the animations behavior.
https://github.com/ivanvorobei/SPConfetti/issues/14
Checklist

[x] Testing in compability platforms
[x] Installed correct via Swift Package Manager and Cocoapods

It seems the problem stems from the shared.view never receiving updates when the environment values for .confettiParticlesConfiguration is changed. This is because the SPConfettiView is create once for the SPConfetti and loads the current static SPConfettiConfiguration.particlesConfig when its first created, but never updates it again.
This solution passes the particleConfiguration into the SPConfettiView each time an animation is played. This already sort of happens because the ConfettiPlaceholderView.UnderlyingView.play() functions sets SPConfettiConfiguration.particlesConfig = particleConfig. So another solution to this could be to directly set the views particlesConfig to the SPConfettiConfiguration.particlesConfig in the SPConfetti.startAnimating() function: shared.view.particlesConfig = SPConfettiConfiguration.particlesConfig

It seems the problem stems from the shared.view never receiving updates when the environment values for .confettiParticlesConfiguration is changed. This is because the SPConfettiView is create once for the SPConfetti and loads the current static SPConfettiConfiguration.particlesConfig when its first created, but never updates it again.
This solution passes the particleConfiguration into the SPConfettiView each time an animation is played. This already sort of happens because the ConfettiPlaceholderView.UnderlyingView.play() functions sets SPConfettiConfiguration.particlesConfig = particleConfig. So another solution to this could be to directly set the views particlesConfig to the SPConfettiConfiguration.particlesConfig in the SPConfetti.startAnimating() function: shared.view.particlesConfig = SPConfettiConfiguration.particlesConfig

The solution proposed here does seem more correct when considering the use of SwiftUI Environment values for setting the configurations. As passing them to a static value kinda defeats the purpose of the environment value.


Update README.rpm.md

fixed spelling of authenticator in the README.md

This change is

Fixed spelling error in README

I don't look at pull requests until CLA is signed
Closing this pull request since the PAM code moved to https://github.com/google/google-authenticator-libpam


Binance US

Does the binance us api work with this bot? Im sorry if this question has been answered I searched for it and was unable to find anything specific about binance us.

I switched the node dependency and then pointed the app(binance.js) towards us-binance dependency instead and everything seems to be working OK

Interesting. Just did a quick research and seems you can use it by changing the endpoint
https://github.com/Ashlar/binance-api-node/issues/307
But it seems doesn't support WebSocket based on the official doc - https://github.com/binance-us/binance-official-api-docs/blob/master/rest-api.md#general-information-on-endpoints
It means, you can use it for the current master version, but not for the upcoming update. Hmm...

I switched the node dependency and then pointed the app(binance.js) towards us-binance dependency instead and everything seems to be working OK.
https://www.npmjs.com/package/us-binance-api-node

I found where to change these in binance.js, package.json as well as package-lock.json. Is this all the places I need to make a change?

Yes that should work

I keep coming up with problems trying to get the us support to work. Either I run into API issues(live) using the multiple tracking of coins, or I try the orig install and run into unhandled promise rejection.
I wish I were smarter when it came to this stuff. Possible to get a us supported version to work?

ERROR: binance-api/38 on d5102b6c907b: Something wrong with trailing-trade-common cache (version=0.0.66, gitHash=unspecified, server=websocket, e={})     payload: {       "command": "latest",       "data": {}     }
@chrisleekr any ideas?
binance.js
const Binance = require('us-binance-api-node').default;
package.json
"us-binance-api-node": "~0.9.10",

@Jacques717 sorry for the late reply.
I haven't had time to test Binance US.
I think the best way is to use https://github.com/ccxt/ccxt
It will give much flexibility to expand to different exchanges.
However, I found free version does not provide the WebSocket feature, which is a critical feature for this bot.