Importer throws NullPointerException on Model Import

Hi,
trying to import a file with Version 4.2.2, which is imported successfully with Version 3.3.2 now throws a NullPointerException after xAL address element:
[16:05:38 ERROR] core:Address (unknown gml:id): Failed to interpret xAL address element.
[16:05:38 ERROR] An error occurred: null
[16:05:38 ERROR] Aborting due to an unexpected java.lang.NullPointerException error.

I could share a small data set for debugging if necessary...
kind regards,
Daniel

Hi Daniel, a test dataset would indeed be very helpful.

Hi Claus,
I'm not allowed to post the data but here.
Sending them via email?

Sure. You can use the email from my GitHub profile<EMAIL_ADDRESS>

Your dataset violates the CityGML schema. For two addresses, the <xAL:AddressDetails> element is given as direct child element of <core:Address>. However, there must be a <core:xalAddress> property element inbetween (check lines 220340 and 220364). You can simply validate your CityGML input datasets by clicking the "Just validate" button on the "Import" tab. Interestingly, all other address elements in your dataset are correct.
Nevertheless, there was also a bug which caused the import process to fail for invalid address elements. I fixed this bug (3825ebb2991d0329028dcd0f7acfaba73bb88076). Simply build a new version of the importer from the master branch to benefit from the bugfix.

Thanks a lot, dataset is importing now. The model was exported from proprietary software. Trying to inform the manufacturer about the bug...


Turn directory hotkeys into a menu

Honestly, I just feel like archiving them. I don't use them often, and now with Explorer Tab Utility, running a selection won't be smooth.


ok

error... :-)

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

2 out of 4 committers have signed the CLA.

[x] raygj
[x] scarolan
[ ] root
[ ] jpapazian2000

root seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.

error on my side


Homepage not working on iOS browsers

I think this only happens some older version of iOS browser (I tried with 2 iPad and was able to replicate with old one).
After debugging, it showed ReferenceError: Can't find variable: Bigint and I don't think I can add polyfill to avoid that.

Tried to add babel polyfill but seems not working. Any idea @jefflau ? https://github.com/ensdomains/ens-app/compare/bigint

Here are screenshots of what I see on an iPhone (latest version of iOS) in Chrome (latest version). I also see the exact same problems on Safari on the iPhone.

Ah ok, I thought it was the homepage of app.ens.domains. Can @jefflau take a look?

I've identified it's just safari, not specifically iOS. I can replicate in the Safari browser. It feels like it must be something to do with some kind of advanced javascript that safari doesn't support by default

@jefflau No, those screenshots above are from Chrome on iOS. And right now I'm testing it and I'm getting the problems on my iPhone in Chrome, Brave, and Safari (all the ones I've checked so far on iOS).

Can't replicate on my local (I get the bug on ens.domains but not on localhost). I'm redeploying now to see if that changes anything.

Super weird. I was going back in time to try and find a commit where the bug didn't exist, now I can't even replicate it. Will pause for now and investigate later. Can't pinpoint what it is right now

I believe this is fixed now.


Rm duplicates from end_nodes in toposort

The end_nodes argument of toposort can contain duplicates, when a user jits a function with repeated outputs (something like lambda x: (x, x)). It seems toposort handles this situation badly, and the length of its return value can be (much) higher than the number of nodes in the original graph.
A simple repro:
from jax.util import toposort
from collections import namedtuple

Node = namedtuple('Node', 'parents')

# Create a graph containing 11 nodes
n = Node([])
for i in range(10):
    n = Node([n])

print(len(toposort((n, n))))         # prints 22, should be 11

The length scales with the number of parents that n has and the number of times it is repeated. In my code this was causing serious performance issues (toposort was generating a list with ~80 million elements for a graph with ~3000 nodes).
This pr contains a straightforward fix, by removing duplicates from end_nodes at the start of toposort.

Pinging @dougalm.

Is it possible to use list(set(node_list))?

If we make the boxes (which are JaxprTracers) hashable then we can do that. The equivalent thing in Autograd was hashable iirc and I wonder if it was a conscious choice to not make JaxpTracers hashable.
Not sure though. Perhaps this issue justifies making them hashable to enable the simplification that you suggest.


Enhancement: See the distribution for different timezones.

It would be cool to have a selectbox where you can choose a timezone. The chart will show the info based on the chosen timezone.
It would be also cool to be able to configure the timezones you want to be available in this selectbox.

I've created a pull request that implements this feature.
The number of the timezones can be configured in the pulse.php cofing:
    /*      * The timezone to be available in the select dropdown of the usage hours card.      */     'usage_hours' => [         'timezones' => [             'UTC',             'Europe/Berlin',             'Asia/Bangkok',         ],     ],


Add support for fetching controller manager logs in must-gather

closing as this was addressed in #366


Shortcuts Disappear after closing and reopening Firefox

REPORT
Describe the bug
Shortcuts don't save to home screen after I close and reopon Firefox
To Reproduce
Steps to reproduce the behavior:
Not really sure, I just installed user.js and it started happening
Expected behavior
A clear and concise description of what you expected to happen.
I should see my shortcuts after I enabled them. After closing and reopening Firefox, they disappear again.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: Windows 11
Browser: Firefox
Version: 119.0.1

Additional context
Add any other context about the problem here.

Please read https://github.com/yokoffing/Betterfox#getting-started
Review https://github.com/yokoffing/Betterfox/wiki/Common-Overrides#new-tab-shortcuts

Thank you for your help. I changed this to true:
user_pref("browser.newtabpage.activity-stream.feeds.topsites", true);


should forbid a symlink containing a symlink when pushing

By design, a symlink containing a symlink is forbidden, as it introduces security risks. An error is returned at pull when such a link is detected, as shown in #636.
However, pushing such a symlink works fine. We should add a check to push as well. The behavior of push and pull should be consistent.

Closing this feature request as it conflicts with #644.


Unable to compute derivatives due to calling .item()

Hello, i am getting the error below whenever i try to compute the jacobian of my network.
RuntimeError: vmap: It looks like you're either (1) calling .item() on a Tensor or (2) attempting to use a Tensor in some data-dependent control flow or (3) encountering this error in PyTorch internals. For (1): we don't support vmap over calling .item() on a Tensor, please try to rewrite what you're doing with other operations. For (2): If you're doing some control flow instead, we don't support that yet, please shout over at https://github.com/pytorch/functorch/issues/257 . For (3): please file an issue.
the error can be traced back to the line below.
weights = interpolation_weights.prod(-1)
Is there a way around this ?
Thank you .

Hi @elientumba2019, thanks for the issue! Are you able to share more of the code with us? In testing locally, I'm not able to reproduce this using toy data with a prod call so want to check out what's happening. Thanks!

@elientumba2019 if you could also let us know what version of PyTorch you're using, that would be great. This problem was likely fixed in PyTorch 1.13, so upgrading to the latest PyTorch may make it go away.

@zou3519 @samdow   Thank you for the suggestion. I have upgraded my PyTorch version and the problem seems to have been fixed.


Add Ethereum

Add awesome-ethereum to decentralized systems, since there is no such resource yet.

https://github.com/void4/awesome-ethereum#readme
There are lists of Bitcoin and other decentralized systems, but not one for the Ethereum system, the second largest system in operation.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

You have to review at least 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. I seem to be unable to comment on other PRs
I have read and understood the instructions for creating a list.
This pull request has a descriptive title in the format Add Name of List (Example: Add Swift), not Update readme.md or Add awesome list. ✓
The entry in the Awesome list should:

Include a short description about the project/theme of the list. It should not describe the list itself. Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..  ✓
Be added at the bottom of the appropriate category. ✓

The list I'm submitting complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent. ✓
It's the result of hard work and the best I could possibly produce. ✓
Non-generated Markdown file in a GitHub repo. ✓
Includes a succinct description of the project/theme at the top of the readme. [(Example)] (https://github.com/willempienaar/awesome-quantified-self) ✓
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics. ✓
Not a duplicate. ✓
Only has awesome items. Awesome lists are curations of the best, not everything. ✓
Includes a project logo/illustration whenever possible. ✓

Either centered, fullwidth, or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge. ✓

Should be placed on the right side of the readme heading. ✓

Can be placed centered if the list has a centered graphics header.

Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents. ✓
Should be the first section in the list. ✓
Should only have one level of nested lists, preferably none. ✓

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc. ✓
WTFPL and Unlicense are not acceptable licenses.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js. ✓

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme. ✓

Go to the top and read it again.

The image for Ethereum logo seems to be broken

Fixed.

Interesting list but most entries don't have a description. Would improve greatly by adding a description to each entry.

Okay, added descriptions to most of them.

Thank you for the submission. However, it seems like you're missing the contribution guidelines. Proper and consistent spelling/grammar and more descriptive descriptions could would be a huge improvement as well.

Looks good, but it seems that there's another pull request about Ethereum opened: https://github.com/sindresorhus/awesome/pull/1452. I don't know what's the way to solve this kind of situations, maybe @sindresorhus can help with this 😄


Question about XPaths in dataset

Hi there,
I'm interested in using the dataset provided in your "Web Page Segmentation Revisited" paper for my research, and I was wondering if you could clarify something about the XPaths included in the dataset.
I've noticed that the XPaths provided in the dataset seem to differ from the XPaths I generate using browser tools or my own code. Could you provide some insight into how the XPaths in the dataset were constructed, and why they might be different from what I'm generating on my own?
For instance, data of 000192, the XPath for the "Callsign" element is "/html/body/div[3]/div[3]/form/div/text()[1]" while in your dataset, It is "/HTML[1]/BODY[1]/DIV[1]/DIV[3]/FORM[1]/DIV[1]/text()[1]". You may notice the 3rd elements, which are div[3] and div[1], are indexed differently.
Thanks in advance for your help!

Hi!
That is a very good question! I had another look at our old code and I think you indeed found a bug in it:
It seems we increased the count only if the nodes were actually visible:
https://github.com/webis-de/webis-web-archiver/blob/master/resources/de/webis/webarchive/environment/browsers/get-elements.js#L48
That would indeed explain the difference in the specific case you mentioned.
Thank you a lot for pointing this out! I am not sure yet how to best fix it, but I'll have a look what I can do. In case you have ideas: they are welcome ;)

Hi!
I don't know if you have done any steps to fix this issue. But I have an idea.
With the existing code, you can construct incorrect Xpaths and then write new code to find the correct Xpaths. Once you have a list pairing incorrect Xpaths with their correct counterparts, you can replace the incorrect Xpaths in the current dataset with the new ones. This approach saves time and preserves the rendered position without the need to reproduce the entire web page. Regarding invisible Xpaths, you can simply ignore them because the dataset focuses on web page segmentation, where invisible nodes can be disregarded.
Hope it would help.

Hi!
I don't know if you have done any steps to fix this issue. But I have an idea.
With the existing code, you can construct incorrect Xpaths and then write new code to find the correct Xpaths. Once you have a list pairing incorrect Xpaths with their correct counterparts, you can replace the incorrect Xpaths in the current dataset with the new ones. This approach saves time and preserves the rendered position without the need to reproduce the entire web page. Regarding invisible Xpaths, you can simply ignore them because the dataset focuses on web page segmentation, where invisible nodes can be disregarded.
Hope it would help.

Thanks, I already had a look, but unfortunately, I am not in the office until June 7th and can't really continue until then.
I already tried to match the incorrect XPaths to existing XPaths from the dom file, but there is a lot of ambiguity. So it looks like I will have to reproduce the web pages and write the files with the correct XPaths. But you are true: better to replace the paths in the files than to re-create everything.
Sorry that I can not make progress on this issue at the moment :(


convert to eslint

Removed tslint in favor of eslint.
Fixed many of the eslint errors, or comment-ignored the rest.

There are two unit tests currently failing as result of my refactoring. I'll look into them tomorrow, but you can go ahead and review this for now since I expect those changes to be extremely minor.


CORE-14583: change logging level to info for updateVirtualNodeState endpoint

The updateVirtualNodeState endpoint has been failing occasionally in various e2e tests. This PR changes the logging level in this endpoint to be info, so that we can hopefully get a better idea of where it is going wrong.
Recent example of a flaky build: https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda5-e2e-tests/detail/release%2F5.0/705/tests/

so that we can hopefully get a better idea of where it is going wrong.

Do we see this flake in the 5.1 branch too? If so, I'd rather this temporary logging level change was only merged there.

The flake is appearing in 5.1 also, and I have this logging there already. Sure, I can wait until we see the failure on that branch. Thanks.


MediaUpload in Core

[ ] MediaUpload with FileInfo
[ ] MediaUpload with Stream
[ ] Update Added Media
[ ] Tests


Review v2

Current coverage is 98.70% (diff: 92.00%)

Merging #21 into master will decrease coverage by 1.29%

@@           master        #21   diff @@
========================================
  Files           5          6     +1
  Lines         134        155    +21
  Methods        23         26     +3
  Messages        0          0
  Branches        9         14     +5
========================================
+ Hits          134        153    +19
- Misses          0          2     +2
  Partials        0          0

Powered by Codecov. Last update f25ffb9...9520984

Coverage decreased (-1.3%) to 98.675% when pulling<PHONE_NUMBER>3360fa16d22b44c1d9290a24197ba3 on reviewV2 into f25ffb9f48a231aab8bd7730c55137288079a87e on master.

Coverage remained the same at 100.0% when pulling cab5d9d6eef99a75e273e9aa53a309141c5bee25 on reviewV2 into f25ffb9f48a231aab8bd7730c55137288079a87e on master.

Coverage remained the same at 100.0% when pulling f88d340e9af3a6e901fe13343933470fb596d34c on reviewV2 into ec2af6c7eb9349dee5961d7150ac60d4ecbeb477 on master.


Eliah Kagan: Watch greekcodes.com.np

Eliah Kagan requests the watch of the watch_keyword greekcodes\.com\.np. See the MS search here and the Stack Exchange search here.

greekcodes\.com\.np has been seen in 1 true positive, 0 false positives, and 0 NAAs.


Bump react-helmet version to resolve unsafe lifecycle methods

Bump react-helmet's version to resolve the unsafe lifecycle methods. The package is used to manipulate document title and meta tags from the React codebase.
The warning is currently suppressed by:
"resolutions": {
  "react-side-effect": "^2.1.0"
},

https://github.com/gaearon/react-side-effect/issues/54
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

This has been resolved by updating to react-helmet-async.


OpenGL 4 deprecated

OpenGL 4 has been deprecated in 4.23 and removed in 4.24. We might need to remove the -opengl flag from the python side when we're launching the holodeck-engine. It failed to start up for me on version 4.24. I had to go to UnrealEngine/Engine/Config\BaseEngine.ini and uncomment +TargetedRHIs=GLSL_430. There's a deprecation warning right above that line (2077)

FWIW, I don't even know why we have this option. We should ask the wise
sages who came before us why it exists


Task 21,22,23,24

@sunnyJT
Task -21
Code verified.
Task -22
Code verified.
Task -23
Code verified.
Task -24
Code verified.


highlight json differences in orchestration admin page

Going to look into this asap but will hold off implementation until I can pair with someone with better frontend experience.

notes - include code editor, include highlightjs, and then show the diff)


Chinese (Hanzi)

Generally following ALA/LC table, but some rarely used Chinese characters are not Romanized
An extra space always shown in between romanized character and punctuation; Most punctuation are romanized correctly (except for no romanization of wite corner brackets 『 』)
All "ü" (the only diacritic in ALA/LC Chinese Romanization Table) are showing incorrectly as "u"

Some additional information is needed:

Which rare Chinese characters are not romanized? These could be added to the table.
Which us are showing incorrectly and which ones are legit? E.g. 铝 transliterates lü, but I can't tell which other romanizations are expecting a "ü".

The extra space issue might be a logic problem. The transliteration table for Hanzi has an added space after each Romanized term, so if punctuation is encountered, there is an unwanted space. I thought I had addressed this but I have to look at the code and get back to this ticket. We may need to define a list of punctuation characters that suppress the space from the preceding token. This could be a good fit for the on_tx_token_match hook: read one extra character (without advancing the index), and if it is one of the punctuation symbols in the above mentioned list, strip whitespace from the end of the current match.

Closing this for now, as we are moving toward a whole new Chinese table. We'll open specific issues as they arise.


OpenMP support

Is there a way to install through Conda for a build with OpenMP support? I'm using a project that needs libfftw3_omp.

It is possible, but does not currently exist. Currently we do support pthreads though.
To support OpenMP, we would probably want to either make that a different package or maybe a feature that one could enable for this package. Personally I'd lean towards a different package because feature support for conda is weak and the change to the build seems pretty significant. I say all this for two reasons.

We build with pthreads currently.
We are building with the system clang on Mac.

Thus building support for OpenMP would mean not supporting pthreads FWICT. Also it would mean building with the gcc package and/or potentially the clang package. Given the nature of these changes, it seems reasonable to separate it somehow from the standard build.
Let's see what others say though.

Hi again,
Right, thanks. Thought I was going nuts trying to find it!
It's not the case that you can only build with one or the other - the core functionality is in libfftw3, and the parallel implementations are found in libfftw3_threads and libfftw3_omp. An application has to link libfftw3 and either libfftw3_threads or libfftw3_omp however.
See the following below from the docs of FFTW.
I agree that it might be reasonable to separate the build however given the other things you've said. I'll look into creating a new feedstock.

I have the same problem. I'm currently developing the feedstock for galario and need to link to libfftw3_omp.so and libfftw3f_omp.so. Getting openmp support across linux and mac seems to be a big pain.
It would be great to have these libfftw*_omp.so libraries built. I can add some keywords that may help. The conda forge clangdev and openmp packages should deliver a compiler and the openmp runtime from within conda, so one doesn't have to rely on the system libraries.

I would be in favor of just adding OpenMP libs to this existing feedstock since the library names do not conflict.  For example, the system packages for debian/ubuntu include both variants.  It will increase the build time a little, but hopefully it will still be within the CI limits.
I am not certain what the current best practice on conda-forge is for adding OpenMP support on OS X.  In some past recipes I had used gcc/libgcc on OS X to get it, but now that the clangdev and openmp feedstocks exist, perhaps that is a better alternative?

As a workaround, I decided to link to libfftw_threads.so etc. in all cases; i.e., no exception in the build process when on conda forge as we had done it for pyfftw.
I"m not sure about the performance implications but I guess for laptops and desktops there won't be a major difference between openmp and pthreads, yet I didn't find a comparison. I couldn't get my cmake code to recognize the openmp compiler features at build time with clangdev so I opted for gcc/libgcc.
@grlee77 can you point to feedstocks where you used this for openmp on mac os? What did you do for openmp on linux? Just assume that gcc/libgcc exists?

@grlee77 can you point to feedstocks where you used this for openmp on mac os? What did you do for openmp on linux? Just assume that gcc/libgcc exists?

Here is an example recipe using OpenMP on both linux and OS X:
https://github.com/conda-forge/nfft-feedstock/blob/master/recipe/meta.yaml
For both linux and OS X, gcc is listed in the build requirements and libgcc in the run requirements.

So Anaconda (formerly Continuum) has put together some compilers for Linux and macOS that would be a better fit. Would suggest trying those. Here are the docs. @msarahan may be able to add more info.

The compiler things you mentioned @jakirkham look useful; maybe that's the way to go. I completely forgot about this issue to be honest, although I agree with other suggestions that it's better to have one feedstock for all the libs given that they don't conflict. I've also never seen a pthread vs OpenMP comparison @fredRos, I'd be interested in seeing one though.

A side note: in the master branch of pyfftw, you can now build and pick the threads library. The default is openMP and pthreads the fall back. If you have both libraries and prefer pthreads, set the environment variable PYFFTW_USE_PTHREADS before building pyfftw

@fredRos Oh, cool! We have some hand wrapped FFTW calls in our C extension for performance reasons, so I need FFTW directly rather than from Python, but I suppose that means we can link against the install of FFTW used in pyfftw without much difficulty.

Hi friends! I have this working for the Anaconda compilers. There is the question of what to do about the toolchain build. I am wondering if we should special case it and not build the openmp libs for it. Any thoughts?

I just installed this package from conda-forge, and it doesn't have the libfftwf_omp.so -- did this get taken out since the above PR was merged? Or am I misunderstanding something?

You are looking for the wrong file. It should be libfftw3f_omp.so

Sorry, I meant that. That file is not in my anaconda/env/lib/ (no FFTW files with _omp.so are there).

Can you send the output of conda-list? The anaconda defaults channel may not have this part of the build.

conda-list.txt
Hmmm, maybe it's because I used conda-forge rather than default anaconda channel?

I don't see fftw in this environment at all. ;p

I'm so confused... just did conda install -c conda-forge fftw on a fresh env and all the _omp.so files are there.... not sure why they weren't there the other night when doing (ostensibly) the same thing. Perhaps it was the lateness of the night...
I will get back to you if this problem comes up again and I can determine why. Sorry for the bother! And thanks for packaging this!


Lose Swagger Auth on Page Reload

Is it expected behavior for the Swagger docs auth lock to reset every time I refresh or reload the page and have to login again?

Yes.  It doesn't use session or local storage by design.  There's currently a feature request and PR in the swagger-ui project to add this, FastAPI just uses swagger-ui on that page.

https://github.com/swagger-api/swagger-ui/issues/5803

gotcha I'll close this then.

Thanks for the help here @chris-allnutt ! :clap: :bow:
Thanks for reporting back and closing the issue @btotharye  :+1:


Realtime kernel install fails with ''fakeroot: nested operation not yet supported"

The instructions on this page do not work for me on Ubuntu 18.04 trying to install kernel 5.2.21. I get this error message at the step fakeroot make deb-pkg:
make clean
/bin/bash ./scripts/package/mkdebian
  TAR     linux-5.2.21-rt15.tar.gz
origversion=$(dpkg-parsechangelog -SVersion |sed 's/-[^-]*$//');\
	mv linux-5.2.21-rt15.tar.gz ../linux-5.2.21-rt15_${origversion}.orig.tar.gz
dpkg-buildpackage -r"fakeroot -u" -a$(cat debian/arch)  -i.git -us -uc
dpkg-buildpackage: warning: using a gain-root-command while being root
dpkg-buildpackage: info: source package linux-5.2.21-rt15
dpkg-buildpackage: info: source version 5.2.21-rt15-1
dpkg-buildpackage: info: source distribution bionic
dpkg-buildpackage: info: source changed by root <root@osx-panda-desk>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source -i.git --before-build TESTlin
 fakeroot -u debian/rules clean
fakeroot: FAKEROOTKEY set to<PHONE_NUMBER>
fakeroot: nested operation not yet supported
dpkg-buildpackage: error: fakeroot -u debian/rules clean subprocess returned exit status 1
scripts/package/Makefile:71: recipe for target 'deb-pkg' failed
make[1]: *** [deb-pkg] Error 1
Makefile:1422: recipe for target 'deb-pkg' failed
make: *** [deb-pkg] Error 2

I'm not entirely sure, but could it be that you are still within the sudo session of the previous apt-get install command (assuming you ran that using sudo or something else previously with sudo the last 15 minutes)?
Then fakeroot tries to set up a fake root while running as root which gives the nested operation error.

I'm not entirely sure, but could it be that you are still within the sudo session of the previous apt-get install command (assuming you ran that using sudo or something else previously with sudo the last 15 minutes)?
Then fakeroot tries to set up a fake root while running as root which gives the nested operation error.

Having the same problem and, no, not within a previous sudo session (explicitly used sudo -k).
Any ideas?

I had this issue when installing the real-time kernel. I am not sure what the problem is, but I ended up finding a different tutorial to install real-time kernel that worked. Both of these tutorials worked for me, however I could not start from where the franka tutorial stopped working (I had to start from the beginning): https://stackoverflow.com/questions/51669724/install-rt-linux-patch-for-ubuntu.
https://hmenn.github.io/pages/UbuntuRT_patch.html. For reference, the tutorial in the ROS 2 documentation also did not work for me.

Related to https://github.com/frankaemika/libfranka/issues/62.

We updated the documentation like @rickstaa mentioned. Now fakeroot shouldn't be needed anymore. Check the current documentation here


Running multiple independent ASP.NET Core projects side by side within the same solution

I'm am trying to create a WebAPI backend that ties in with a decoupled JavaScript Framework powered website, but I'm unsure of how I launch both with ease at the same time using Visual Studio.
I would like it so that I can click the debug button in Visual Studio, and it will then launch two ASP.NET Core projects, each with a Startup class, under two separate ports in IIS Express, and have it so that I can step through both projects at the same time.
At the moment, the only way I see of making this possible is by writing a lot of boilerplate code.
I think this is a Visual Studio problem more than it is a .NET Core problem, but I think the same applies to Visual Studio code, so it may make sense to solve this problem in code, rather than updating Visual Studio to support such a set up.
Apologies if this functionality does already exist, I did spend a considerable amount of time looking for solutions and the best I found was:
https://www.strathweb.com/2017/04/running-multiple-independent-asp-net-core-pipelines-side-by-side-in-the-same-application/
Which I feel is close, but a lot of coding is involved, and is not exactly what I was wanting.
In essence I'd like to spin up two processes, one for each app, each under a different port.
We could even take this one step further and allow any number of processes to be launched at the same time.

Ignore me, just spotted what I'm after.
Right-click on the solution and use the Set startup projects to select multiple projects.


Fixes issue with contentful old contentful versions

fixes: https://github.com/contentful/contentful_rails/issues/30

@sebbean for contentful gem please add a ~> 1.0, as release 2.0.0 is almost out of the gate, and will break this library if not constrained.
As soon as 2.0.0 gets released I will update this gem accordingly to support the new version.

Hey @sebbean, it's the 2.0.0 of contentful not contentful-management
Cheers


feat: create ui for users profile.

Expected Behavior
Create Users profile Page.

Can I work on these?

Allow me to make the users Profile page

@5h15h1r please comment on an unassigned issue.

@GrayFlash  please specify a specific CSS framework to use , one PR was done with bootstrap and one with just CSS .


FlowableOrderedMerge for ParallelFlowables

It would be nice to have a orderedMerge method which can be used with ParallelFlowables if I'm correct the FlowableOrderedMerge could be easily adjusted to provide such functionality by simply changing the constructor from:
    FlowableOrderedMerge(Publisher<T>[] sources, Iterable<? extends Publisher<T>> sourcesIterable,
            Comparator<? super T> comparator,
            boolean delayErrors, int prefetch) {

to
    FlowableOrderedMerge(ParallelFlowable<T> source,
            Comparator<? super T> comparator,
            boolean delayErrors, int prefetch) {

and changing the subscribeActual method to:
    @Override
    protected void subscribeActual(Subscriber<? super T> s) {
        final MergeCoordinator<T> parent = new MergeCoordinator<T>(s, comparator, this.source.parallelism(), prefetch, delayErrors);
        s.onSubscribe(parent);
        this.source.subscribe(parent.subscribers);
    }

I don't know how you want to integrate the change to support both cases but it would be very useful to have :)

There is the sorted operator.
Otherwise, PR welcome.

Yeah but the sorted operator only works on finite streams and works quite differently than the FlowableOrderedMerge operator. I have tested the changed FlowableOrderedMerge in my application with ParallelFlowables and it works like a charm :)

You can post a PR that adds it to ParallelFlowables then.

Merged with #17


Time of day values are not validated to be time of day values

May be an old issue at this point apparently. Unsure.

This is probably upstream? Maybe an example would help?

I'm not sure we're using a time data-type, so we can't take advantage of docassemble's time field. We'll just have to not validate it for now. We can put it one of the stretch goals or something. I'll make a Trello card for it.

https://trello.com/c/4u7cJvmE/89-validate-time-of-day-values-can-use-das-time-datatype-at-this-link


Backport changes from 0.31.0 to 0.31.2.

Includes 48396ae, 1edc5e5, and 75af4ed.

[Current coverage][cc-pull] is 69.20%

Merging [#1732][cc-pull] into [develop][cc-base-branch] will increase coverage by <.01%

2 files (not in diff) in src/ripple/json/impl were modified. more

Misses -9
Hits +9

3 files (not in diff) in src/ripple/core/impl were modified. more

Misses -5
Hits +5

2 files (not in diff) in ...rc/ripple/beast/nudb were modified. more

Misses +1
Hits -1

2 files (not in diff) in src/ripple/app were modified. more

Misses +3
Hits -3

3 files (not in diff) in src/ripple were modified. more

Misses +7
Hits -7

@@            develop      #1732   diff @@
==========================================
  Files           858        858
  Lines         62048      62157   +109
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          42899      43010   +111
+ Misses        19149      19147     -2
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [44e3312...ec09520][cc-compare]
[cc-base-branch]: https://codecov.io/gh/ripple/rippled/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/ripple/rippled/compare/44e33121c7c798daf3edfcaddbe8648a34f8a735...ec09520d00044bd1e1973b220e497d5f258d43e6
[cc-pull]: https://codecov.io/gh/ripple/rippled/pull/1732?src=pr

:+1:

Merged as ceb01fb6a34b87bd91cdb4d693b11326cd726a14, 321e2a94fe8b9ba61baff3bcbc9852665b084606 and 7f52249e407e362e2c3bbcb4decfc62df0efe718.


[Feature] Modal should be listed as a widget so that the user can create modals from the widget pane

Adding modal into the widget list would help user to create new modal

@Nikhil-Nandagopal How will the modal widget be dragged on to the screen? Today the modal can't be moved around or placed anywhere but the center.
Three ways of dealing with the modal here.

Should we let the user drag and drop a modal widget where they please?
Should they drag and drop the modal but it always gets positioned in the center?
Should they have to click the modal to create a modal?

Ass a UX, I vote for #2. Makes it intuitive for people and the modal automatically centers itself onto the screen.

Considering we do not have the feature to move widgets we cannot always place it in the centre. We should let them design a modal and reuse it within a widget, but that modal will not be visible when they click on deploy.

I think we should do #1 because it gives users the option to create drawers if they want. Allow users to drop and resize the modal however they please

Can you explain drawers a little more?

@Debsourabh a drawer is what we have for the API pane right now. it's a modal that sticks to one side of the screen.

https://www.figma.com/file/wj5oTtuQkT3FEpdGb8o57y/?node-id=0%3A1
The link for the Modal Widget.

https://www.figma.com/file/wj5oTtuQkT3FEpdGb8o57y/?node-id=0%3A1
The link for the Modal Widget.

Note:

When dragging a modal widget from the widget cards pane, the modal background overlay appears
When the user drops modal on the overlay, the modal snaps to the center of the overlay


Use entry when adding listeners

Hello, thank you for your work on this crate!
I've been using this crate as a reference to create a dispatcher for my specialized use case (singlethreaded sync dispatcher supporting event types that include references). I've uploaded it here if you want to take a look. While working on it, I've found some things that may also be of interest to you:

If multithreading is not needed, it's possible to get this crate's transitive dependencies down from 120 to zero, by making multithreading an optional feature in Cargo.

It's possible to extend the dispatcher's interface to accept not just closures, but any owned Listener, changing the dispatcher's dichotomy from traits vs fns to weakrefs vs owned. This is done through a blanket impl making all closures implement Listener.

It's possible to further generalize this to get rid of the dichotomy altogether, through another blanket impl making all weakrefs to Listeners implement Listener. Through this, it's possible to view weakrefs not as weakrefs to listeners, but as owned listeners themselves. This gets rid of the FnsAndTraits type and a bunch of special casing can be removed.

Finally, it's possible to add support for event types that hold references, but this unfortunately can't be done as elegantly. Reference-holding event types will be parametric over lifetimes. Due to how lifetime variance works in Rust, this requires using higher-ranked trait bounds, but these don't work with generics. However, it's possible to support them by using a macro that does the monomorphization manually. This is more of a workaround than a proper solution, so I don't propose doing this in this crate, but I still wanted to let you know.

(I've been limiting myself to single-threaded sync dispatchers, so it's possible that some of the above don't hold for other dispatchers.)
I've also found a smaller thing that I'm opening this pull request for: Adding a new listener to a dispatcher currently gets the matching event ID key from the HashMap, and if it doesn't exist, creates one. This can be replaced by entry which improves performance by avoiding an extra lookup if the key doesn't exist. It also allows removing a lot of duplicated code from the add methods.

Hey, many mentioned points are true. I reworked the crate and will release it soon!


Markdown paste pastes inside of a link

I was trying to paste a link into [product.json](HERE) but when I did it pasted as a full link:

This feature should be smart enough to not do this if I'm already in a link.

I believe this issue also covers not pasting inside a link: https://github.com/microsoft/vscode/issues/186289
Matt suggested working making the feature smarter in a future iteration!


Support Android 11 display cutouts, waterfall, synchronized IME

DisplayCutout.getSafeInset…() now returns screen safe areas like iOS
We can also follow the keyboard animation now with setOnApplyWindowInsetsListener(new View.OnApplyWindowInsetsListener())
We can also move the keyboard now with getWindowInsetsController().controlWindowInsetsAnimation() to support https://github.com/flutter/flutter/issues/57609 on Android
Need to do https://github.com/flutter/flutter/issues/56597 first

Splitting keyboard synchronization to #62876

The upstream API has been slightly updated. New doc https://developer.android.com/reference/android/view/DisplayCutout

https://github.com/flutter/engine/pull/20921 Implements merging DisplayCutouts into existing API.

I filed a new issue to track exposing the detailed rects https://github.com/flutter/flutter/issues/65088


Add option to export plot in pl.heatmap

Description
Add return_figure option to :func:cellrank.pl.heatmap which will return the underlying figure object to be edited directly.
How has this been tested?
No testing done.
Closes
closes  #869

Hi @rschauner , thanks a lot for the PR; I just fixed the linter; merging this.


disable hardcoded checks for actions/ folder

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Changed directly in master during mob session!


Add support for Windows Agents

High-level description
This is needed for Hybrid cloud testing with Windows nodes spawned via dcos-launch
Currently the Environment variables for WINDOWS_HOSTS and WINDOWS_PUBLIC_HOSTS are ignored .
This will add the Windows nodes to the slaves , public_slaves list

@orsenthil  There was a 5 spaces indent in my original commit. I changed it to 4 spaces, the same indent used in the entire file.


Github repository to publish clojure koan changes to.

I guess it would be pretty rad to introduce people to the usual git cadence of committing and pushing changes to a published repo in github.

Yes! We actually forked koans https://github.com/clojurebridge-minneapolis/clojure-koans for previous ClojureBridges and upstream accepted our changes! So now our repo is rebased and we could take PR's from students/TA's immediately (and then forward them upstream).

I love the idea, especially if you branch too.
On Sat, Nov 5, 2016 at 1:03 PM, Melissa Voegeli<EMAIL_ADDRESS>wrote:

I guess it would be pretty rad to introduce people to the usual git
cadence of committing and pushing changes to a published repo in github.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/clojurebridge-minneapolis/installfest/issues/74, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAKdn2X3q46xHBQJnoZ3W6J7yLZVitkaks5q7MTcgaJpZM4KqVhN
.


SubscriptionDataFile no longer works

From version 0.8.8 onwards, specifying the SubscriptionDataFile no longer seems to work:
   $subDataFileName = "C:\testsub.xml"
   remove-item  $subscriptionDataFileName
   $subName = "Test Account"
   $publishSettingsFile = "C:\test-settings.publishsettings"
   Import-AzurePublishSettingsFile $publishSettingsFile -SubscriptionDataFile $subDataFileName
   Select-AzureSubscription -SubscriptionName $subName -SubscriptionDataFile $subDataFileName
   Test-AzureName -Website -Name "any name"

This results in the error:
   Test-AzureName : Account with name '895E08EE21F248EDBD1EC9CDFC5435A0EAF3E461' does not exist.
   Parameter name: accountName
   + Test-AzureName -Website -Name "any name"
   + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       + CategoryInfo          : CloseError: (:) [Test-AzureName], ArgumentException
       + FullyQualifiedErrorId :       Microsoft.WindowsAzure.Commands.CloudService.TestAzureNameCommand

To confirm, the above works fine in version <IP_ADDRESS> and below
Thanks
Dan

@markcowl - Is there any update on this please?
Ta
Dan

Please fix this issue!

We see that this is resolved in 0.8.13 or higher. Is that not the case, @Danjuro, @kuangweizhang, @waiteandrew?

I just upgraded to 0.8.14 and I'm still seeing this problem.  The subscriptions from my SubscriptionDataFile are getting picked up just fine, but none of the cert accounts are recognized.
sample subscriptionDataFile
    {
      "Environments": [],
      "Subscriptions": [
        {
          "Id": "<redacted sub id>",
          "Name": "Playlab",
          "Environment": "AzureCloud",
          "Account": "<redacted cert thumbprint>",
          "Properties": {
            "SupportedModes": "AzureServiceManagement"
          }
        }
      ],
      "Accounts": [
        {
          "Id": "<redacted cert thumbprint>",
          "Type": 0,
          "Properties": {
            "Subscriptions": "<redacted sub id>"
          }
        }
      ]
    }

This is still an issue in 0.8.14.
The SubscriptionDataFile parameter has been removed in 0.8.15


Call prompt as a single function

Reimplement workaround for truncated strings (https://github.com/rafaelrinaldi/pure/issues/49) using single function as currently recommended in https://github.com/fish-shell/fish-shell/issues/904#issuecomment-242048093 instead of event handler.
Update first line of the prompt when moving through directory history with "Alt + ←" and "Alt + →" (https://github.com/rafaelrinaldi/pure/issues/66).
Also resolve https://github.com/rafaelrinaldi/pure/issues/62 and https://github.com/rafaelrinaldi/pure/issues/67.

Re-comitted to fix Travis tests as suggested by https://github.com/rafaelrinaldi/pure/pull/70#issuecomment-383083819

@schrodincat I think the reason why the travis build fails is due to the dist: xenial option within the travis configuration. See #71

@schrodincat Could you please update your local version of pure and confirm if the issue still persists?
cc @boyeborg

@schrodincat test are green, could you resolve the conflict so we can move forward with your PR?

Will fix this tomorrow, sorry for the delay😔

Manual install script was a little bit broken (https://github.com/rafaelrinaldi/pure/issues/81), but after fixing it, I haven't noticed any problems whatsoever. It seems, merge conflict was because some spaces or other nonsense.
I didn't add any tests yet, though.

I appreciate your efforts here @schrodincat.

Seems fine even after recent changes. @rafaelrinaldi feel free to let me know, if something need to be changed.
I’m also interested in implementing Git async functionality.
Sent with GitHawk

@edouard-lopez I’ll look into it and fix it at Tuesday. Thanks for the review🌚
Sent with GitHawk

This approach also fixes multiple spaces before git arrows

@schrodincat could you allow changes on your PR so I can resolve conflict by rebasing it on master and help with the work?

They're allowed

@edouard-lopez I'm working on the PR right now, please, wait, before making changes

Phew, I hope, this time everything is dandy😅

Awesome work! :heart:
Now there is plenty of things we can tests and thanks to you it will be a lot easier to do so and prevent further bug :clap:


Ability to rotate axis labels

I'd like to see the ability to rotate the axis labels so that I can display them veritically or at some arbitrary angle.

I was trying to fix this, but aftet trying I think the best solution is to create a new charts, for example add a row chart (inverse of column chart), stacked row chart and inverse line and are chart

Can you create a branch with your efforts? I'll take a shot at it.

Sadly I deleted that because I saw no future.

Okay.  I'll browse the code and see if I can do it.  It really should be a feature.  Other graphs can do it.

yes your idea is good, What I didnt liked was my code, thats why I did not save it

Usually a good idea.  I'll take a look.  Planning on creating a prop on the series for rotation, then applying a render transform.  There may be a few gotchas, but I'll work through them.

This is now supported, see exmaples here
Bars
https://github.com/beto-rodriguez/Live-Charts/tree/master/ChartsTest/BarExamples/RotatedBar
Lines
https://github.com/beto-rodriguez/Live-Charts/tree/master/ChartsTest/Line Examples/RotadedLine
Stacked Bar
https://github.com/beto-rodriguez/Live-Charts/tree/master/ChartsTest/StackedBarExamples/StackedBarRotated


Deltas for Convert from microseconds to milliseconds in CosmosDiagnostics

Convert from microseconds to milliseconds in CosmosDiagnostics

replaced "durationInMicroSec" with to "durationInMilliSecs"
changed type from long to double

All unit tests in CosmosDiagnosticsTest.directDiagnostics succeed.

Can we add a diagnostics output sample in the description part?


test: add a unit-test for apis/opts/ports.go

Ⅰ. Describe what this PR did
add a unit-test for ports.go
Ⅱ. Does this pull request fix one issue?

fix issues https://github.com/alibaba/pouch/issues/1906
Ⅲ. Describe how you did it
Build unit test by condition combination coverage(ccc).
Ⅳ. Describe how to verify it
By code review and walk-through
Ⅴ. Special notes for reviews

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhixuan.liuzhixuan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #1978 into master will increase coverage by 0.05%.
The diff coverage is n/a.


Problem with installing

Unable to install package pillow==9.3.0: ERROR: Cannot install pillow==9.3.0 because these package versions have conflicting dependencies. ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
same problem as #24 tries to solve

This is with the latest 1.0.2

Me to, same Error

I see the problem, with the upcoming Home Assistant release you should be able to install the integration again. So long you can downgrade the version to 1.0.1. As long as the version comes out I will change the realease to a beta release.

this kind of creates a new 'problem' : I've already updated to 1.0.2 and now HACS says there's an update, however it wants to actively downgrade from 1.0.2 to 1.0.1. You marked the new release as 'pre-release' instead of 'beta' ??

You need to turn off the "Show beta versions" switch, then the version will not be shown to you as an update.

HA 2022.12 is out and therefor version 1.0.2 is needed. Can you release it?

The version is released.


gulp-live-server does not apply the changes

Hello @iDev0urer,
I am very impressed by such good job behind of this project. I was reviewing it and I found two problems:

I think in the last commit you have removed "node": "registry:dt/node#6.0.0+20160909174046" from the globalDependencies. I had to add it back in order to do not have some TypeScript warnings.

gulp-live-server seems to does not apply any change from html/js/scss. I have been trying different solutions and no clue. What about swapping it with Browsersync?

Thank you!

Hey @ChristianPuckSolutions, thanks for checking this out! I am trying to figure out a way to remove typings altogether and just use the @types npm repo. I've been having issues with that however. I did realize that removing "node": "registry:dt/node#6.0.0+20160909174046" caused an issue, so I'll see about putting that in.
As far as the gulp-live-server goes I've been having trouble with it from the beginning, so if you come up with another solution that works feel free to make a PR and I'll get it merged in quickly. Thanks!


Add wf_unit tests in Instance.v

https://github.com/sifive/ProcKami/commit/99f61768010613dde30c61831a1d8669ee3d8362


Robot shutting down randomly

Describe the bug
Robot shutting down randomly.
To Reproduce
Heavy compute
Expected behavior
Robot doesn't hang and shutdown

Removed open source realsense drivers and shifted to kernel level drivers. problem seems to be resolved.


[feature request] How to see version of iasl used?

Well, subject says all

When you have compiled a file, the "Basic Information" at the bottom of the file displays the following message:
Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20210930
Copyright (c) 2000 - 2021 Intel Corporation
Above is the version information.
Also, you can update iasl files yourself, which are located (in the case of mac systems) :
/Applications/Xiasl.app/Contents/MacOS/iasl


Don't set client to nil when closing broker

Fixes 2352

This kind of makes sense. Really, isn't the broker type missing an Open call, which should be called before the broker type is used? This seems to be just changing how Close works, when what is missing the Open? Or am I missing something?

To be clear, in Open the client would be set to non-nil, it seems to me. This seems a fix to allow a broker object to be re-used after Close() has been called, but that would indicate a broken API. Make sense?

The client is already created and set when the broker is created here: https://github.com/influxdb/influxdb/blob/master/broker.go#L47
This nil pointer is in the http.Client here: https://github.com/golang/go/blob/release-branch.go1.4/src/net/http/client.go#L304
Since we're using the DefaultTransport and http.Client are supposed to be reused, setting it to nil doesn't make sense.

OK, very good -- thanks @jwilder . That was the context I was missing.
+1


Database connection string issue.

Hi @kgrzybek ,
Thanks for your nice work.
I have set up connection string in the appsettings.json file but I am experiencing an exception. I will be grateful if someone help me with this. Thanks in advanced.

Hello @majedur, I thinkk the structure of your json it`s incorrect.
Try this:

Hi Beirinha,
It's working. Thanks for your help.


refactor(storage-node): refatcor finalize logic

Type of change:

[x] Refactor
[ ] Bugfix
[ ] New feature provided
[ ] Improve performance
[ ] Backport patches

What this PR does / why we need it:

Refactor StorageNode finalize
Now in finalize, if not is marked delete, we will set StorageNode.Status.Phase to Deleting to MAKE SURE our StorageNode will be deleted.  we don't need to set Deleting status based on rds instances status.
We will still try to sync rds instance status if it is exits.
If in Deleting phase and all instance are deleted, we will mark phase to DeleteComplete, and remove finalizer in next reconcile.
Pre-submission checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?

approve


fix: error

💡 What is the current behavior?

GitHub Issue Number: #
🆕 What is the new behavior?

🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):

[ ] 🦮 Accessibility (a11y) features were implemented
[ ] 🗺 Internationalization (i18n) - no hard coded strings
[ ] 📲 Responsiveness - components handle viewport changes and content overflow gracefully
[ ] 📄 Documentation was reviewed/updated (pnpm run docs)
[ ] 🧪 Unit tests were added/updated and pass (pnpm test)
[ ] 📸 Visual regression tests were added/updated and pass (Guide)
[ ] 🧐 Static code analysis passes (pnpm lint)
[ ] 🏗 Successful compilation (pnpm build, changes pushed)

👨💻 Help & support

/snapshots:approve --args=blind.e2e

/snapshots:approve --args=blind.e2e

/snapshots:approve --args=blind.e2e


README for setting up the backend and database locally

Hello,
Can you provide some details on how to setup everything up for devs to work on the project as a boilerplate? there does not seem to be any documentation in the readme on setup. Specifically for the backend and database.
Thanks.

hi, it seems the local api setup is not working the localhost:8888 is giving this error {"success":false,"message":"Api url doesn't exist "}

@shabfactor
change it here this file :
frontend/src/config/serverApiConfig.js

@Flinze
## Setup backend

1) just create MongoDB Atlas accout database url
2) change this file name .variables.env.tmp to  .variables.env
3) open  .variables.env and paste your MongoDB url here :  DATABASE=your-mongodb-url
4) npm install
5) npm setup

## Setup frontend
1) cd frontend
2) npm install
3) change api config to loaclhost in this : src/frontend/src/config/serverApiConfig.js

## start server
1) npm start

## start react app
1) cd frontend
2) npm start

@shabfactor change it here this file : frontend/src/config/serverApiConfig.js

@idurar
should i change it to http://localhost/api/ or http://localhost:8888/api/?

To http://localhost:8888/api/ , and make sure that server is running on 8888

@idurar can you please help me to setup backend??

Hey @shabfactor, what did you change in the file :  frontend/src/config/serverApiConfig.js. because I also have same error as you

Hey @shabfactor, what did you change in the file : frontend/src/config/serverApiConfig.js. because I also have same error as you


Reconciler error while creating InferenceService: failed to call webhook kserve-webhook-server-service.kserve.svc context deadline

/kind bug
What steps did you take and what happened:
I am trying to start quick-start example with sklearn-iris-predictor.
Problem: webhook that is called when I create InferenceService doesn't work during longtime (~several hours) and then suddenly it works and creates the service.
What I see in the logs of kserve-controller-manager pod:
{"level":"info","ts":"2024-06-28T13:36:26Z","logger":"v1beta1Controllers.InferenceService","msg":"Inference service deployment mode ","deployment mode ":"Serverless"}
{"level":"error","ts":"2024-06-28T13:36:36Z","msg":"Reconciler error","controller":"inferenceservice","controllerGroup":"serving.kserve.io","controllerKind":"InferenceService","InferenceService":{"name":"sklearn-iris","namespace":"app-kserve"},"namespace":"app-kserve","name":"sklearn-iris","reconcileID":"70cc0679-6371-40ab-b5cb-59abfa3c882f","error":"Internal error occurred: failed calling webhook \"inferenceservice.kserve-webhook-server.defaulter\": failed to call webhook: Post \"https://kserve-webhook-server-service.kserve.svc:443/mutate-serving-kserve-io-v1beta1-inferenceservice?timeout=10s\": context deadline exceeded","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}

These 👆 two lines are constantly repeated. And manager-pod tries this hook again and again till it succeeds. But it takes a lot of time to eventually create InferenceService and start the predictor pod.
I tried to follow debug guide but it offers solution when predictor pod have been already created :(
The consequence of this problem is that when I try to delete this InferenceService it hangs indefinitely because the webhook timeouts the same way.
What did you expect to happen:
InferenceService must start immediately and webhook must be stable and send respond immediately.
What's the InferenceService yaml:

InferenceService
apiVersion: v1
kind: Secret
metadata:
  name: s3creds
  annotations:
    serving.kserve.io/s3-endpoint: *** # replace with your s3 endpoint e.g minio-service.kubeflow:9000
    serving.kserve.io/s3-usehttps: "1" # by default 1, if testing with minio you can set to 0
    serving.kserve.io/s3-region: "***"
    serving.kserve.io/s3-useanoncredential: "false" # omitting this is the same as false, if true will ignore provided credential and use anonymous credentials
type: Opaque
stringData:
  AWS_ACCESS_KEY_ID: "****"
  AWS_SECRET_ACCESS_KEY: "****"
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: s3-model-serving
secrets:
  - name: s3creds
---
apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
  name: "sklearn-iris"
spec:
  predictor:
    serviceAccountName: s3-model-serving
    model:
      modelFormat:
        name: sklearn
      storageUri: "s3://***/model/"
---

How I start it
$ kubectl create ns app-kserve
$ kubectl apply -n app-kserve -f app/sklearn-iris.yaml

Other debug info
$ kubectl get MutatingWebhookConfiguration
NAME                                            WEBHOOKS   AGE
cert-manager-webhook                            1          37d
inferenceservice.serving.kserve.io              2          2d20h
kyverno-policy-mutating-webhook-cfg             1          6d19h
kyverno-resource-mutating-webhook-cfg           0          6d19h
kyverno-verify-mutating-webhook-cfg             1          6d19h
prometheus-crd-kube-promet-admission            1          37d
vault-secrets-webhook                           2          37d
webhook.domainmapping.serving.knative.dev       1          7d3h
webhook.istio.networking.internal.knative.dev   1          7d3h
webhook.serving.knative.dev                     1          7d3h

$ kubectl get deployments -n kserve
NAME                        READY   UP-TO-DATE   AVAILABLE   AGE
kserve-controller-manager   1/1     1            1           3d1h

$ kubectl get svc -n kserve
NAME                                        TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)    AGE
kserve-controller-manager-metrics-service   ClusterIP   <IP_ADDRESS>   <none>        8443/TCP   3d1h
kserve-controller-manager-service           ClusterIP   <IP_ADDRESS>   <none>        8443/TCP   3d1h
kserve-webhook-server-service               ClusterIP   <IP_ADDRESS>    <none>        443/TCP    3d1h

$ kubectl get svc -n knative-serving
NAME                         TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)                                   AGE
activator-service            ClusterIP   <IP_ADDRESS>    <none>        9090/TCP,8008/TCP,80/TCP,81/TCP,443/TCP   7d3h
autoscaler                   ClusterIP   <IP_ADDRESS>   <none>        9090/TCP,8008/TCP,8080/TCP                7d3h
autoscaler-bucket-00-of-01   ClusterIP   <IP_ADDRESS>     <none>        8080/TCP                                  7d3h
controller                   ClusterIP   <IP_ADDRESS>   <none>        9090/TCP,8008/TCP                         7d3h
domainmapping-webhook        ClusterIP   <IP_ADDRESS>    <none>        9090/TCP,8008/TCP,443/TCP                 7d3h
net-istio-webhook            ClusterIP   <IP_ADDRESS>     <none>        9090/TCP,8008/TCP,443/TCP                 7d3h
webhook                      ClusterIP   <IP_ADDRESS>    <none>        9090/TCP,8008/TCP,443/TCP                 7d3h

Anything else you would like to add:
I test KServe installation in fully isolated "fresh" K8S cluster with no access to the web.
I installed KNative + Istio from scratch following documentation guides.
Environment:

Istio Version: 1.16.7
Knative Version: 1.9.4
KServe Version: 0.13.0
Kubeflow version: no Kubeflow
Cloud Environment: isolated cloud
Kubernetes version: 1.25.8-r0-<IP_ADDRESS>

Please help 🙏

can you share your - kubectl get pods -A

@roseaysina Did your Kserve controller got restarted  ? Could you provide full logs for the KServe controller ? Also what are the steps you followed to install KServe ?

I got the same problem. It's annoying. Everything that calls the webhooks are failing due to timeouts
https://kserve-webhook-server-service.kserve.svc:443/validate-serving-kserve-io-v1alpha1-clusterservingruntime?timeout=10s
https://kserve-webhook-server-service.kserve.svc:443/mutate-serving-kserve-io-v1beta1-inferenceservice?timeout=10s
Im starting to think that the problem resides in our company's internal networking. This problem could be happenstance after all.

I got similar issue
In my case, quick-start example with sklearn-iris-predictor is working with no problem.
But error ocure in running custom model with kserve.
kubectl get pods -A
NAMESPACE            NAME                                                       READY   STATUS    RESTARTS      AGE
cert-manager         cert-manager-5799666d46-76vfv                              1/1     Running   0             168m
cert-manager         cert-manager-cainjector-7c8bcfdd69-zrlk8                   1/1     Running   0             168m
cert-manager         cert-manager-webhook-6dd97d9768-x6sf8                      1/1     Running   0             168m
istio-system         istio-ingressgateway-67f78db64-wgskc                       1/1     Running   0             168m
istio-system         istiod-864c454b9b-7whzb                                    1/1     Running   0             168m
knative-serving      activator-7f86fb77f8-nvl7v                                 1/1     Running   0             168m
knative-serving      autoscaler-657cb48c96-bxrj6                                1/1     Running   0             168m
knative-serving      controller-5649857ccc-d2xjd                                1/1     Running   0             168m
knative-serving      domain-mapping-5ffd4df948-64nvh                            1/1     Running   0             168m
knative-serving      domainmapping-webhook-859df874cb-pcd4m                     1/1     Running   0             168m
knative-serving      net-istio-controller-79dc5cdb78-6q2qb                      1/1     Running   0             168m
knative-serving      net-istio-webhook-55c8775bfd-p6576                         1/1     Running   0             168m
knative-serving      webhook-74b6f5cf75-lncl5                                   1/1     Running   0             168m
kserve-service       sklearn-iris-predictor-00001-deployment-58c8dc468f-82fvn   2/2     Running   0             54m
kserve               kserve-controller-manager-77779646dd-tvjzz                 2/2     Running   0             167m
kube-system          coredns-5dd5756b68-6n6w7                                   1/1     Running   1 (15d ago)   16d
kube-system          coredns-5dd5756b68-v4kdm                                   1/1     Running   1 (15d ago)   16d
kube-system          etcd-ai-control-plane                                      1/1     Running   0             15d
kube-system          kindnet-8w8tj                                              1/1     Running   1 (15d ago)   16d
kube-system          kindnet-q5h89                                              1/1     Running   1 (15d ago)   16d
kube-system          kube-apiserver-ai-control-plane                            1/1     Running   0             15d
kube-system          kube-controller-manager-ai-control-plane                   1/1     Running   1 (15d ago)   15d
kube-system          kube-proxy-mvmf6                                           1/1     Running   0             14d
kube-system          kube-proxy-pf97g                                           1/1     Running   0             14d
kube-system          kube-scheduler-ai-control-plane                            1/1     Running   1 (15d ago)   15d
local-path-storage   local-path-provisioner-888b7757b-stzgv                     1/1     Running   2 (15d ago)   16d
monitoring           grafana-69965959c-c25kq                                    1/1     Running   1 (15d ago)   16d
monitoring           loki-0                                                     1/1     Running   1 (15d ago)   16d
monitoring           loki-promtail-9lgf2                                        1/1     Running   1 (15d ago)   16d
monitoring           loki-promtail-pczwc                                        1/1     Running   1 (15d ago)   16d
monitoring           prometheus-alertmanager-0                                  1/1     Running   0             14d
monitoring           prometheus-kube-state-metrics-79c867c577-gtknq             1/1     Running   0             14d
monitoring           prometheus-prometheus-node-exporter-lcbcj                  1/1     Running   0             14d
monitoring           prometheus-prometheus-node-exporter-lrwzd                  1/1     Running   0             14d
monitoring           prometheus-prometheus-pushgateway-57c548bd6f-7s9nd         1/1     Running   0             14d
monitoring           prometheus-server-6459547474-xk8kh                         2/2     Running   0             14d

kubectl apply -f kserve-custom-model.yaml
Error from server: error when creating "kserve-custom-model.yaml": admission webhook "inferenceservice.kserve-webhook-server.defaulter" denied the request: json: cannot unmarshal number into Go struct field EnvVar.spec.predictor.containers.env.value of type string

hi,
are there is this issue resolved ?


feat: Jasmine test framework should be added as a library

Jasmine is one of the most mature JavaScript testing frameworks and so should be added as a library to JSBin! It was surprising that QUnit is there, but not Jasmine. This would encourage people to write more tests against their code

See #2498 - same applies.


[BEAM-13298] KafkaIO Sink Output PCollection

KafkaIO's write has historically returned a PDone.
The change is to pass the original input as an output with a new class WriteRecordsWithOutput.
WriteRecords delegates to this class but still retains it's return signature.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@weifonghsia Kind ping on this. Are you still going to work on this?

@aromanenko-dev - it has slipped on my schedule, let me see if I can find time soon to add in the two missing tests from my side.


[core] Cursor/window position offset issue

When creating a window it is not at the intended position. This only happens when the height matches the monitor height (which is in my case 1080). The screen position no longer matches the cursor position.
Example code:
#include "raylib.h"

int main(void){
    InitWindow(1920, 1080, "");
    //this one works: InitWindow(1920, 1050, "");
    SetTargetFPS(60);
    while(!WindowShouldClose()){
        BeginDrawing();
            ClearBackground(RAYWHITE);
            DrawCircleV(GetMousePosition(), 5, RED);
        EndDrawing();
    }
    CloseWindow();
    return 0;
}

Edit:
UndecorateWindow is not the problem as I first thought. However, windowed mode (decorated or not) is. In fullscreen mode this works fine.

Finally found a reasonable workaround:
#include "raylib.h"

int main(void){
    SetConfigFlags(FLAG_WINDOW_UNDECORATED);  // <--- :-)
    InitWindow(1920, 1080, "");
    SetTargetFPS(60);
    while(!WindowShouldClose()){
        BeginDrawing();
            ClearBackground(RAYWHITE);
            DrawCircleV(GetMousePosition(), 5, RED);
        EndDrawing();
    }
    CloseWindow();
    return 0;
}

raylib has some security checks to avoid placing the Window outside of the display area.
Using FLAG_WINDOW_UNDECORATED is the best option.


Parsing default params when the default is set to "{}"

When setting a default parameter to an object (e.g. funcName(argOne = {})), the @param component is parsed incorrectly.
I tracked down the issue to ParamParser.js where the regex used in the match function assigning to match and the replace function assigning to value are not the same.  I am not sure if these are purposely different but I changed them to match and added tests to account for the changes made.
Example:

@blindman Hi! Thanks for this PR. And sorry for late reply.
I want to merge this! But now, conflicts with tests...
I accept only src/Parser/ParamParser.js without test codes. after merged, I will write test codes based on your test code.

@h13i32maru Yes, totally understandable. You might want to add that to CONTRIBUTING.md though.  The main reason I wrote the tests is because I didn't want to submit the PR with failing tests caused by my code.  Would you like me to re-submit the PR without the tests?

@blindman Normally test codes are needed. However I was late to merge this at this time.
I merged this PR with resolve the conflicts by myself.
Thanks.


Why are GitHub permissions needed?

Lately, LGTM.in requests permissons at GitHub:

Why is that? Can this be avoided?

We do not send emails unless it is to warn users that they are violating fair use guidelines.
Before we sought to read email addresses from github, we had a periodic problem with pornographic images and hate speech. Dad to say, but these permissions are a necessary evil.


Mouse interaction example

First of all, thank you for maintaining this awesome browser plugin for ue4! As an independent developer, it is very good to know someone are putting efforts into developing something so useful.
I know it has already been mentioned in the previous comments, but is it possible what we can have an example of how to use mouse to interact with the plugin or simple way of use the plugin as a texture?
Best Regards,
K

by this weekend I will present demo with examples

Thank you very much for your response!

Thank you very much for your response!

np: there is already demo available to download getnamo did already add it in "realease" section. And here is demonstration https://www.youtube.com/watch?v=PRxO0yCO3Kk  PS: I'm still working on new update with more clean instruction and demonstration also included some additional new features.

Thank you very much for your response!

New demo update is up: https://www.youtube.com/watch?v=iCAe7dyy9dw

Thank you very much for your response!

New demo update is up: https://www.youtube.com/watch?v=iCAe7dyy9dw

These are some truly amazing examples! Very informative and complete. Thank you again for the amazing work!

Hope to support 4.25

Hope to support 4.25


vowels should be represented as diphthongs

we have many aspects where we have a case like "b o u ŋ", where ou should be represented as diphtong.
A way to handle this is to assemble all vowel sounds and define all possible combinations between them. Another way is to parse the data with CLTS and check for vowel sounds in the profiles and extract them. In any case, with this dataset, it seems very reasonable to do so.

@LinguList should this be addressed before release?


DispatchQueue.main not working (on Windows)

Describe the bug
Closures passed to DispatchQueue.main.async will never be called. Similarly, Swift Concurrency Tasks scheduled to run on @MainActor are never called.
To Reproduce
These print statements are never executed when using Adwaita for Swift on Windows:
DispatchQueue.main.async {
  print("Hi!") // Never called
}

Task { @MainActor in
  print("Hi, too!") // Never called
}

Expected behavior
I expect that the Main Dispatch Queue and the Main Actor can be used normally. Alternatively, the library should surface a similar API to run code on the Main Thread.
Additional context
I assume, to make this work, the GTK run loop must be integrated with libdispatch. Maybe this can be helpful: https://stackoverflow.com/questions/10291972/integrating-a-custom-run-loop-with-libdispatch

Thanks for opening the issue! I will look into this at some point. Currently, you can use Idle which calls GLib.idle_add to add functions to the main context (e.g. for updating the UI).

This issue has moved to https://git.aparoksha.dev/aparoksha/adwaita-swift/issues/38


bug: XCode T&C causes incorrect error message during a build

Type: bug
Platform: ios 8 webview
$ ionic build ios
The provided path ".../platforms/ios" is not a Cordova iOS project.

I'm guessing this is a Cordova CLI problem being passed through Ionic?
Can we improve error messages?

Thanks for opening the issue. It seems that issue has been resolved. I am going to close this issue but please feel free to reopen another issue if this occurs again.


Wiki - GetImage API missing properties

The createdOn and expires properties are missing from the documented API call for Get Image in the Wiki.

@JohnGoyette I have updated the WiKi to include the missing properties.

Changes look good to me. I will close the issue.


react-native preset allows string based createElement while it should not

Do you want to request a feature or report a bug?
bug
What is the current behavior?
react-native preset allows string based createElement
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal repository on GitHub that we can npm install and npm test.
import 'react-native';
import React from 'react';

import renderer from 'react-test-renderer';

it('renders correctly', () => {
  const Root = 'View';
  const App = () => <Root/>;

  const tree = renderer.create(
    <App />
  ).toJSON();
  expect(tree).toMatchSnapshot();
});

What is the expected behavior?
It should fail at it.
See https://github.com/facebook/react-native/issues/144#issuecomment-78541664. I am unsure this is fixable. Just that I can write code that ultimately will fail on react-native. Looking at ways to maybe test differently, maybe this is integration testing here.
Run Jest again with --debug and provide the full configuration it prints. Please mention your node and npm version and operating system.

Yes, this is because we are rendering using react's test-renderer which allows to bottom out at string based components. We don't have access to native components so we need to render to strings, instead of a native View, we render to a "View (string)".


Kubelet: stop logging "Error on reading termination-log..." messages

If a pod was deleted and the associated volumes/directory were removed, there
could be a window where the pod worker is still active. If the pod worker tries
to inspect the logs, such an error would be logged. Since the pod has been
deleted, such error messages are meaningless.
This change stops logging this error, but stores the error string in the pod
status. The pod status will be updated for pods that are still alive, and will
be discarded eventually for deleted pods.
This fixes #8223

This PR doesn't eliminate other error messages caused by the race condition in kubelet.log, but is still an improvement.

/cc @dchen1107 @thockin

LGTM

LGTM

LGTM too


example project view controller class simplified

Hey @slxl this looks good. We are merging #67 into master soon so it'll probably have to be updated to Swift 3 after that point

@slxl #67 is merged now if you wanna rebase this

pardonne moi delay :)

No problem the same on my part :)


Outdated documentation for ValidateBytes

The documentation presents examples such as
 errs, err = rs.ValidateBytes(invalidPerson)
whereas the function definition is
func (s *Schema) ValidateBytes(ctx context.Context, data []byte) ([]KeyError, error) {
Can you provide me an example on how I should pass the context to this function? What is the benefit of this change?
For now, I go with
ctx := context.TODO()
errs, err := rs.ValidateBytes(ctx, metadataBytes)

Definitely interested to hear about "What is the benefit of this change?"

Ah this is a great point, we'll get the documentation fixed up, but to speak to the benefit of the change:
we pass a context because the jsonschema spec states validation should be able to make web requests to fetch referenced schemas. Those requests can end up taking time (a slow server or a high-latency connection), and you might want to put a boundary on that request. Here's an example:
// create a context that times out after one second. whenever we create a context with values,
// we need to cancel it in all cases, so we defer a call to cancel
// we're passing the "background" context to "WithTimeout" because there's no deeper
// context to build on. context.Backround() has the same functionality as context.TODO()
ctx, cancel := context.WithTimeout(context.Background(), time.Second)
defer cancel()

// call validation. If the root schema makes web requests, and those web requests
// take longer than one second, we'll get an error that is or wraps err.DeadlineExceeded
errs, err :=  rs.ValidateBytes(ctx, metadataBytes)

if err != nil {
  if errors.Is(err, context.DeadlineExceeded) {
    fmt.Println("request timed out!")
  }
  // handle other errors...
}

But if you don't want a deadline, the code you've written will work just fine! It's common practice to use context.Background() whenever you don't really need context cancellation. context.TODO() is generally reserved for code that's being upgraded to use contexts.
Hope that helps explain things! We'll mark this issue as closed when the docs are updated.

The docs have been updated as part of https://github.com/qri-io/jsonschema/issues/77. However I definitely think that the above higlights the rationale a lot more than just the code sample.


Add OpenSSF best practices badge

Fix https://github.com/kubewarden/kubewarden.io/issues/128
Please also review the answers in https://bestpractices.coreinfrastructure.org/projects/6502. Feel free to modify them

I would consider the left over cryptographic practices to be met. But it feels so weird to mark them as met for the foreseeable, without an external audit..


Convert cron task to object format to support redcron

This converts to the object format of tasks so redcron can support it https://github.com/excl-networks/strapi-plugin-redcron

LGTM (lol)

Thanks for the contribution!


Core Data and SwiftDDP - Custom sort issue

Hey,
I'm using "MeteorCoreData" - https://github.com/siegesmund/MeteorCoreData
When I'm trying to fetch my collection with my custom sort:
"let dateDescriptor = NSSortDescriptor(key: "preview_message.submitted_at.$date", ascending: false)"
Its doesn't work. when conversation is update in the web I get update:
fields =     {         "created_at" =         {             "$date" =<PHONE_NUMBER>651;         };     };
And when I'm reloading the tableview in "controllerWillChangeContent"  I think MeteorCoreData is fetching by "created_at" sort and won't order as I want.
How can I change it? Thank you very much!

I wouldn't recommend using MeteorCoreData. It's and undocumented, out of date, unfinished project.

But you can not give me help on this particular issue?


Another attempt on SafeMath assert->require but for a different reason

The different reason is the formal verification module we're building in Solidity. I'll start with a general argument from my side, then I'll talk about the FV module.
I've read the multiple discussions in different issues/PRs, and first of all I need to say that I do disagree with having asserts in SafeMath. What the code does is filtering inputs, therefore requires should be used.
I've also read that the idea is that the users should filter their input, and SafeMath would use the assertions to enforce no overflow. Well, nobody does it, and the reason is that the asserts in SafeMath already do kind of the same, so why would people bother? Moreover, if users filter their inputs with require(b <= a), for example, then having an extra assert(b <= a) from SafeMath's sub is just a waste of gas.
Assuming that users do not filter their input and rely on SafeMath to guarantee no underflows/overflows, this breaks formal verification. The reason is that the verifier sees no filtering (no assumptions on the input), and then sees the assertion assert(b <= a) which it tries to prove, since it is a verification target. The verifier will report that the assertion is not true for all cases, and easily provide counterexamples, since there are no assumptions on a and b.
So, from a verification perspective it would also make more sense to have requires in SafeMath, such that the underflow/overflow cases would be simply filtered out of the execution path, and the rest of the path would have the safe invariant due to an assumption, not a target.
I'd love to hear your thoughts on it, even though it's a repetitive discussion...

Thanks for bringing this up @leonardoalt! Could you provide some examples on what you'd consider valid uses of assert?

Hi @nventuro
One simple example could be:
function max(uint a, uint b) returns (uint) {
  uint c = a;
  if (b > c)
    c = b;
  assert(c >= a && c >= b);
  return c;
}

Of course this is a very simple example, but it illustrates that the invariant c >= a && c >= b should be true before the assert no matter what input values are given, the contract's state etc, therefore an assertion fail means a bug somewhere.
Another simple example:
function transfer(address to, uint amount) {
  require(balance[msg.sender] >= amount);
  uint sum = balance[msg.sender] + balance[to];
  balance[msg.sender] -= amount;
  balance[to] += amount;
  uint newSum = balance[msg.sender] + balance[to];
  assert(sum == newSum);
}

Similarly, the assertion should be true regardless the state of the whole thing.
Another more complex example would be, that after sorting an array, you could assert for each position that the element is <= the next.
Summary: conditions in asserts should be true no matter what before the assert.
So I think in the end it kinda comes down to what's expected from the user, and what should the user expect from SafeMath.
@shrugs I hope it's ok to copy over here what you said in #778:
"they should be invariants but obviously they aren't because nobody is doing requires before calling safemath anyway"
In my opinion:

If the idea is that users should filter inputs and SafeMath only enforces it, then assert is correct;
If the users don't have to guarantee the invariants and SafeMath is used as the input filter, then require is correct.

From a practical verification point of view: if 1 is the case, people have been doing it wrong which leads to me having to think about hacks in the verification tool to find those cases :p

We're also playing with verification and moving the assert -> requires seems like the right thing to do (or at least if would be very helpful). Since the semantics are the same modulo gas, it's more about intent.
For verification purposes we treat

asserts as "find an execution that fails the assert, or show that none exists";
requires as "assume this holds while proving stuff that follows it".

The intent doe SafeMath is more in line with "let's assume that this holds" and use it (and if doesn't hold, it's OK due to revert). Considering the amount of contracts using SafeMath this is a big deal for verification attempts since, in most cases, it's not hard to trigger the overflows and these would then be reported as bugs (while they shouldn't).

I see what you mean and agree with the raised points. Would asserts be optimized out in a production build, then?
Also, regarding SafeMath: this is the current implementation of div:
function div(uint256 a, uint256 b) internal pure returns (uint256) {
  // assert(b > 0); // Solidity automatically throws when dividing by 0
  // uint256 c = a / b;
  // assert(a == b * c + a % b); // There is no case in which this doesn't hold
  return a / b;
}

Would you suggest changing that first comment to require(b > 0), to prevent Solidity from throwing?

asserts are still used as runtime checks that might catch compiler/EVM/etc bugs, so I wouldn't remove it even if a static analyzer says the assertion is true.
Regarding div: yes, I'd do the same as #1121. My personal reasoning is that if I'm writing a contract without SafeMath I'll explicitly add such a require. If I'm using SafeMath I'd expect it to keep the path clean for me everywhere.

I just found a curious situation in #915, where an assert was added in the manner you describe: coveralls is now reporting our test coverage dropped, since that assertion is always true (as expected). I looked into solidity-coverage a bit, and they consider this the intended behavior.
I worry other tools may be taking the same approach, leading to issues due to different interpretations on the semantics of assert. What do you think about this?

In my opinion they got asserts wrong. As you just said, it is expected that the assertion is always true, and if a test case breaks an assertion there should be a bug, therefore it shouldn't be considered in coverage.
I see your point about a consistent interpretation of asserts throughout the projects. I'm not aware of other projects interpreting asserts like that, even though they probably exist.
Ideally we'd need everyone on the same page, even if it takes some time.

I created an issue on their repo to get their opinions regarding this, and see if we can start getting the community on board with this proposal :)

Nice, thanks @nventuro !

Thanks for such an interesting discussion guys! I was convinced that we should change SafeMath to use require.


Possible integer overflow when dealing with wormhole mass >2.147m tons

While playing around with the mass tracking functionality of Pathfinder, I noticed an issue with the total mass displayed particularly on the K346 type wormhole, which should have a mass of 3 million tons +/- 10%. Pathfinder displays the total mass of the wormhole as 2,147,483,647 tons, as seen here:

I'm assuming there's some kind of integer overflow or type error here. Can confirm this is reproducible at least with K346-type holes of ~3m mass, haven't been able to try with other wormhole types of similar size or greater yet.

:heavy_check_mark: Issue resolved
This issue was resolved by the commit(s) and/or the comments above.
It will be auto-closed with the upcoming release ( merge into master branch). Please check the attached Milestone information.
Many thanks to all participants/contributors for the helpful comments! :+1:
:information_source: Please reopen/comment this, if you have problems/questions about it.

Auto-generated response


24-bit addressing support

Originally, Macs used 24-bit addressing. Apple introduced 32-bit addressing as an option with System 7 on 68020 and later processors, and made it mandatory some time later. This caused compatibility problems for quite a few applications.
Executor only implements 32-bit addressing and shows a warning for applications that are not explicitly marked as 32-bit compatible by their developers.
Background: The original 68000 processor ignored the upper 8 bits of every 32-bit address. Some programs took advantage of that and stored other information there, others even relied on the Memory Manager storing some information there in some situations.
TODO:

implement a 24-bit address mapping mode for syn68k
make sure that executor's memory use "fits" in 4 * 4MB
make the memory manager store its attribute bits where old apps expect them

Affected Apps (that are known to crash for this reason):

Turbo Pascal 1.0

To my knowledge, PowerPC never implemented 24-bit addressing, so if it ends up being a launch-time switch, perhaps disabling PowerPC code translation could speed some things up.

Yes, 24-bit was dead long before the PowerPC came along, so all PowerPC programs are definitely 32-bit compatible.
I don't think it's even easy to make it a launch-time switch - the first attempt will be a compile time thing.
The SYN68K_TO_US macro (defined in syn68k_public.h) is the central point for translating addresses, this is where it should be done. Unfortunately, adding an extra "if" there will already slow things down considerably.

How does Apple cope with that on a 32bit clean system?

@Godzil, cope with what exactly?
They didn't have the SYN68K_TO_US problem, because the processor does that, and they just didn't support 24-bit mode on later systems.


Navbar is split over two lines on mobile

Navbar should only ever occupy one row. Consider a smaller font or dropping the text “search”.
Bly ever

Removed the word search from the navbar.
This change makes space for additional buttons and collapsed the navbar back to one row, on mobile.


Oops! NFCError:2

LOG  Oops! NFCError:2
"react": "18.1.0",
"react-native": "0.70.4",
"react-native-nfc-manager": "3.0.3"
Both ios and android error. i using tech NfcTech.IsoDep

@phucph1998 Hi, I have met same problem.
Have you fixed? any solutions?

Hey there, look at the log window of xcode. I had the same issue and I fixed it by setting the correct AID in the Info.plist.


Adding scenarios for using the local logging (or other log driver results) effectively

Probably more a Discussion, but a solid feature would be how to use that content to understand how Docker Desktop is being used and if there are issues that could be popping up in the environment.
Using Windows as an example the %LOCALAPPDATA%\Docker\log.txt seems to aggregate events from all the different features of the product.  The challenge is it is trace level so the events can be a a bit low level or difficult to connect to an interaction like a login/refresh, image lifecycle, container lifecycle, or extensibility features of the product.
Given I don't think there is a clear cut event for a human interaction so likely you would need to infer something from one or more events.  And given an event like a container create uses the SHA you may not be able to get the context you want (what image in human readable form) was launched.
That type of scenario metadata may not be as simple as a regex, but if there are recommended patterns for parsing events in the daemon logs (or other logs) having those available as a "known good" can help folks add that type of usage or issue telemetry into existing systems of record.
In this case I am not talking about logging from the app running in DD, but the product itself.  So it's a bit of a different scenario than the telemetry that may come from a server config.  And if there are existing patterns for using something like Filebeat to collect all the content and Logstash to reduce the noise that would be great. If not and there are those known good parsing routines maybe I can get it going and open a PR.

@byjrack, it would be great to get your thoughts on https://github.com/DockerSolutionsEngineering/WhaleSongs/commit/4d7202dfa2bfec2ad090fd039d17ac59bc8de17d. There is still some work and collaboration to be done, but this might be a good start.

Yup was thinking that would be the same basic pattern for read and load, but whats to stop the same event from being added to the evtlog on the next run?  Given you can't find by time since the stamp will follow the event.write and not the parsedTime it feels like you might need to create a hash of the message and prefix/suffix message with that content and do a get-event call to check if not exists.  It would be great if there was a real metadata model on events, but 100% its limited.
The other is noise reduction in the eventlog.  The docker logs are pretty verbose and have tons of noisy activity that someone may not want so likely a param for the posh would include some method of filtering out material events from general noise in the log.  This is more what i was getting at with "parsing" the log file versus just the string data format parsing.  Also the more noise the heavier the cost will be for that message hash check routine.
I will open an item on the roadmap backlog for a windows driver proxy.  local driver can write into the filesystem, but i imagine the host process has some pipe into daemon. So if there was a winevtproxy driver for daemon that can trigger something in the host process (electron or other DD host process) which writes the evt to event log realtime.  now there will be some drift between the daemon event and when it would be added to the host evtlog, but it should be pretty small.  Or another option might be a syslog server process in DD so use the same driver, but it handles the push into windows evtlog.  Feels like there should be a oss project on that, but its buried under all the evtlog to syslog efforts.


add cross type tests to magnitude

Tests for magnitude don't have cross data type tests. It can be added.

Magnitude is a scalar function, so there is no need to test cross-type arrays


Notebook 02 breaks when model_name other than 'resnet_model" provided

Notebook 00 asks for model_name to be provided by the user however  model_name is hardcoded as "resnet_model" in scoring script so when user provides different model_name, scoring script breaks. Also, unclear why and how _MODEL_NAME  is used in 02.

addressed. removed the input parameter model_name


sdk: Deprecate timing::duration_as_*() functions

Problem
See https://github.com/anza-xyz/agave/pull/2584 for a bit more context, but essentially, the sdk::timing::duration_as_*() provided functionality that is now natively supported in std::time::Duration. Thus, there is no need for for these functions any longer
Summary of Changes

Remove all usage of sdk::timing::duration_as_*() functions in the repo.
Add deprecation notes to the sdk::timing::duration_as_*() functions

Note: This will currently fail CI until https://github.com/anza-xyz/agave/pull/2584 lands; will update this PR once that happens

After the fact, I'm wondering if we should put a deprecation notice in the CHANGELOG. I get the impression this is something that we mostly used internally, but it is in sdk so maybe we should CHANGELOG it for the sake of consistency / just incase someone else was using it