failed to activate leetcode plugins after install(Extension initialization failed)

🐛 Bug Report
cannot activate leetcode plugins after install
Expected behavior
succeed to activate leetcode plugins after install and login in
Extension Output
v12.16.1
undefined:1
{"solution.discuss":false,"company":false,"cache":true,"retry":true}"leetcode.cn":false}
^
SyntaxError: Unexpected string in JSON at position 68
at JSON.parse ()
at Object.cache.get (/Users/corndai/.vscode/extensions/shengchen.vscode-leetcode-0.16.1/node_modules/vsc-leetcode-cli/lib/cache.js:16:15)
at Function.Plugin.init (/Users/corndai/.vscode/extensions/shengchen.vscode-leetcode-0.16.1/node_modules/vsc-leetcode-cli/lib/plugin.js:86:23)
at initPlugins (/Users/corndai/.vscode/extensions/shengchen.vscode-leetcode-0.16.1/node_modules/vsc-leetcode-cli/lib/cli.js:62:14)
at Object.cli.run (/Users/corndai/.vscode/extensions/shengchen.vscode-leetcode-0.16.1/node_modules/vsc-leetcode-cli/lib/cli.js:100:3)
at Object. (/Users/corndai/.vscode/extensions/shengchen.vscode-leetcode-0.16.1/node_modules/vsc-leetcode-cli/bin/leetcode:3:23)
at Module._compile (internal/modules/cjs/loader.js:1158:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
at Module.load (internal/modules/cjs/loader.js:1002:32)
at Function.Module._load (internal/modules/cjs/loader.js:901:14)
undefined:1
{"solution.discuss":false,"company":false,"cache":true,"retry":true}"leetcode.cn":false}
To Reproduce

download vscode
install node.js
install leetcode plugins from vscode extensions
Click LeetCode plugins on left bar

Your Environment

os: MacOS 10.15.4
extension settings:
"leetcode.defaultLanguage": "java",
"leetcode.endpoint": "leetcode-cn",
"leetcode.hint.commandShortcut": false,
"leetcode.hint.configWebviewMarkdown": false,
"leetcode.hint.commentDescription": false,
nodejs version: 12.16.1
vscode version:  1.43
extension version: 0.16.1

I also encountered a similar initialization problem. I have no clue how to solve this problem.
Extension Output
v14.4.0
internal/validators.js:121
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at validateString (internal/validators.js:121:11)
    at Object.join (path.js:1039:7)
    at Object.file.homeDir (/root/.local/share/code-server/extensions/shengchen.vscode-leetcode-0.16.2/node_modules/vsc-leetcode-cli/lib/file.js:28:15)
    at Object.file.configFile (/root/.local/share/code-server/extensions/shengchen.vscode-leetcode-0.16.2/node_modules/vsc-leetcode-cli/lib/file.js:50:25)
    at Config.init (/root/.local/share/code-server/extensions/shengchen.vscode-leetcode-0.16.2/node_modules/vsc-leetcode-cli/lib/config.js:97:28)
    at Object.cli.run (/root/.local/share/code-server/extensions/shengchen.vscode-leetcode-0.16.2/node_modules/vsc-leetcode-cli/lib/cli.js:94:10)
    at Object.<anonymous> (/root/.local/share/code-server/extensions/shengchen.vscode-leetcode-0.16.2/node_modules/vsc-leetcode-cli/bin/leetcode:3:23)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32) {
  code: 'ERR_INVALID_ARG_TYPE'
}
internal/validators.js:121
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at validateString (internal/validators.js:121:11)
    at Object.join (path.js:1039:7)
    at Object.file.homeDir (/root/.local/share/code-server/extensions/shengchen.vscode-leetcode-0.16.2/node_modules/vsc-leetcode-cli/lib/file.js:28:15)
    at Object.file.configFile (/root/.local/share/code-server/extensions/shengchen.vscode-leetcode-0.16.2/node_modules/vsc-leetcode-cli/lib/file.js:50:25)
    at Config.init (/root/.local/share/code-server/extensions/shengchen.vscode-leetcode-0.16.2/node_modules/vsc-leetcode-cli/lib/config.js:97:28)
    at Object.cli.run (/root/.local/share/code-server/extensions/shengchen.vscode-leetcode-0.16.2/node_modules/vsc-leetcode-cli/lib/cli.js:94:10)
    at Object.<anonymous> (/root/.local/share/code-server/extensions/shengchen.vscode-leetcode-0.16.2/node_modules/vsc-leetcode-cli/bin/leetcode:3:23)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32) {
  code: 'ERR_INVALID_ARG_TYPE'
}
Error: Command ""/usr/bin/node" "/root/.local/share/code-server/extensions/shengchen.vscode-leetcode-0.16.2/node_modules/vsc-leetcode-cli/bin/leetcode",plugin,-i,company" failed with exit code "1".

Environment

os : Ubuntu 20.04 Linux 5.4.0-37-generic  x86_64 x86_64 x86_64 GNU/Linux
extension settings :
"terminal.integrated.shell.linux": "/bin/bash",
"leetcode.nodePath": "/usr/bin/node"
extension version : 0.16.2
nodejs version : 14.4.0
vscode version : 1.45.1 (code-server: v3.4.1)

Reproduce

New Ubuntu 20.04 Server
sudo apt update && sudo apt upgrade
Install Node.js

curl -sL https://deb.nodesource.com/setup_14.x -o nodesource_setup.sh
sudo bash nodesource_setup.sh
sudo apt install nodejs

Install VS Code via @cdr/code-server

curl -fOL https://github.com/cdr/code-server/releases/download/v3.4.1/code-server_3.4.1_amd64.deb
sudo dpkg -i code-server_3.4.1_amd64.deb
systemctl --user enable --now code-server

Install leetcode extension

# From the Coder extension marketplace (Same as manual installation
code-server --install-extension shengchen.vscode-leetcode

Click leetcode plugin icon on left bar

Some try
Clear the cache and reinstall
There is no $HOME/.lc folder after installation, so I try to restart VS Code service firstly. The situation remains the same. After that I mkdir $HOME/.lc and its subfolder leetcode leetcode.cn ,then I restart VS Code. The same error occurred.
Install VS Code by docker codercom/code-server:latest
This docker seems to be using a Debian system. I entered the container and executed the same command as above to install nodejs v14.4.0 then mannually install leetcode plugin. It works! But I am a docker rookie, I can not easily manage the server directly through code-server webpage, such as nginx mysql php on the server.
Change Nodejs Version to 13.x or 12.x
I can get return with command node -v but the same error occurred.
Change OS to Cent OS 8.2
I always want to use the latest system, even if it caused me a lot of trouble 🤣

After a simple initial update and installations of nodejs and vscode, the same error occurred.
Change OS to Cent OS 7.3 & Nodejs Version to 13.14.0
This test was on a server in China created a long time ago, when I installed nodejs v13.14.0. After installing the plugin manually, the plugin works fine.
Now I still haven't found a solution...

@skydai From your output, the json is ruined with wrong format. So, please remove the cache ~/.lc and try again

@monsterxcn Does your problem also have in standard VS Code? Since it seems that you are using code server(a third-party distribution)

@monsterxcn Does your problem also have in standard VS Code? Since it seems that you are using code server(a third-party distribution)

Nope. I don't have this problem on my laptop.
But on the server, sometimes it works normally, sometimes it doesn't. If it is a problem with code-server, it should go wrong in other situations. But I can run normally in the container codercom/code-server:latest and code-server on Cent OS 7.3 & Nodejs 13.14.0 .
That's strange. 😅

I think I should have solved my problem. It's indeed a problem with code-server. Just install Node.js in the command line of the code-server instead of directly installing it in the SSH connection as the root user. My problem should be caused by user permissions .

@monsterxcn Good to know the problem has been solved.


copy & paste doesn't work

I experience it constantly on Windows 10. (I was using mysql2 but I'm not sure if this is related).
I think it's something to do with the way Windows encodes newlines maybe?

Open winword
write in a text document (over two lines)

select
1

Copy these two lines and paste into sqlpad. Run query.

I get this message on the log, and the GUI is counting "Query time: ..." indefinitely.
So there are two problems here, one is the inability to parse the query, and the other, feedback not presented on GUI.
   2020-05-31T11:30:20.98+0300 [APP/PROC/WEB/0] OUT {"level":50,"time":"2020-05-31T08:30:20.980Z","pid":7,"hostname":"0c9fe0be-0e4e-45e8-4e32-98e9","name":"sqlpad-app","stack":"Error: invalid syntax at line 1 col 7:\n\n  Select\r\n        ^\n    at Lexer._token (/usr/app/node_modules/moo/moo.js:533:13)\n    at Lexer.next (/usr/app/node_modules/moo/moo.js:480:19)\n    at getStatements (/usr/app/node_modules/sql-limiter/src/get-statements.js:79:18)\n    at Object.apiGetStatements [as getStatements] (/usr/app/node_modules/sql-limiter/src/index.js:52:22)\n    at Batches.create (/usr/app/models/batches.js:48:8)\n    at create (/usr/app/routes/batches.js:36:41)\n    at /usr/app/lib/wrap.js:3:35\n    at Layer.handle [as handle_request] (/usr/app/node_modules/express/lib/router/layer.js:95:5)\n    at next (/usr/app/node_modules/express/lib/router/route.js:137:13)\n    at mustHaveConnectionAccess (/usr/app/middleware/must-have-connection-access.js:11:16)\n    at Layer.handle [as handle_request] (/usr/app/node_modules/express/lib/router/layer.js:95:5)\n    at next (/usr/app/node_modules/express/lib/router/route.js:137:13)\n    at mustBeAuthenticated (/usr/app/middleware/must-be-authenticated.js:5:12)\n    at Layer.handle [as handle_request] (/usr/app/node_modules/express/lib/router/layer.js:95:5)\n    at next (/usr/app/node_modules/express/lib/router/route.js:137:13)\n    at mustBeAuthenticated (/usr/app/middleware/must-be-authenticated.js:5:12)\n    at Layer.handle [as handle_request] (/usr/app/node_modules/express/lib/router/layer.js:95:5)\n    at next (/usr/app/node_modules/express/lib/router/route.js:137:13)\n    at Route.dispatch (/usr/app/node_modules/express/lib/router/route.js:112:3)\n    at Layer.handle [as handle_request] (/usr/app/node_modules/express/lib/router/layer.js:95:5)\n    at /usr/app/node_modules/express/lib/router/index.js:281:22\n    at Function.process_params (/usr/app/node_modules/express/lib/router/index.js:335:12)","type":"Error","msg":"invalid syntax at line 1 col 7:\n\n  Select\r\n        ^"}
   2020-05-31T11:30:20.98+0300 [APP/PROC/WEB/0] OUT {"level":30,"time":"2020-05-31T08:30:20.981Z","pid":7,"hostname":"xxx","name":"sqlpad-web","req":{"id":187,"method":"POST","url":"/api/batches"},"res":{"statusCode":500},"err":{"type":"Error","message":"failed with status code 500","stack":"Error: failed with status code 500\n    at ServerResponse.onResFinished (/usr/app/node_modules/pino-http/logger.js:71:38)\n    at ServerResponse.emit (events.js:323:22)\n    at onFinish (_http_outgoing.js:730:10)\n    at onCorkedFinish (_stream_writable.js:721:5)\n    at afterWrite (_stream_writable.js:528:5)\n    at afterWriteTick (_stream_writable.js:515:10)\n    at processTicksAndRejections (internal/process/task_queues.js:83:21)"},"responseTime":5,"msg":"request errored"}

Ahh cool workaround. If I hit shift-enter to "prettify" the query and then run, it works.

I'll look into this quick. It likely is the encoding for line endings which will need to be supported by the parser. Not having an error indication in the UI is unexpected as well.

This should be fixed in latest/master. If the SQL tokenizer fails to tokenize the query, the error is handled like a query error and displayed in the UI accordingly.
The underlying library used to tokenize the SQL statement has also been fixed to support Windows line endings. https://github.com/rickbergfalk/sql-limiter

works now :-)


Bump test suite

Doesn't look like the ci script runs the tests, it just lints them. Presumably you ran the tests locally and the output is still as expected with these changes?

Doesn't look like the ci script runs the tests, it just lints them. Presumably you ran the tests locally and the output is still as expected with these changes?

Yes, and I have added running tests as part of the CI process


[FEATURE REQUEST] HTML report generation

Is your feature request related to a problem? Please describe.
Currently the tool supports a limited type of output formats. Generating a HTML report is one solution to very easily review the results generated.
Describe the solution you'd like
ffuf has a good working example of this. Anything that has some sort of DataTables on top, to be able to do sorting/search is more than enough.
An advanced version of this feature would be to combine all the results from parallel/multiple scans in one HTML report file - which would be awesome.
Describe alternatives you've considered
None.
Additional context
Thanks for your work! This tool seems amazing, good work 🙏

thank you for the kind words and the request!
i like the idea of supporting more output formats and a final html report would be nice.
I'm currently enrolled in offsec's new course, so don't plan on working anything significant for ferox until that's complete, just as a heads up. Though, I'd be more than happy to accept a PR for this in the interim if anyone would like to work it.
Thanks again for taking the time to make a request!

Hi, @epi052 can I take this issue?

@poorpy of course! Please hit me up if you have any questions 🎉🎉

@poorpy as far as the command line, what do you think of adding --format FORMAT and then redirecting --json to whatever the underlying dispatcher is for different formats?   That would maintain the old api in case folks are using --json in scripts etc, and would also allow for additional formats to be added easily later on.  What are your thoughts?

@epi052 yeah, I think that's the way to go. Imo deprecating/removing --json flag should happen in separate release (if ever desired).

@poorpy below is my personal checklist for adding a new command line option. I've forgotten things enough times to necessitate its creation.

Add new command line option checklist

config/container.rs

add value to Configuration struct
add value to Configuration::default
update Configuration docstring
add value to Configuration::parse_cli_args
add value to Configuration::merge_config

config/tests.rs

update Configuration::tests::setup_config_test with new value
update Configuration::tests::default_configuration with new value
add test to check config parsing

ferox-config.toml.example

add new value

banner/container.rs

add new BannerEntry to Banner struct
update Banner::new with a BannerEntry
update print_to with whether to print or not

tests/test_banner.rs

add new test so that the new BannerEntry is displayed and examined under test

Cargo.toml

bump version - minor release +1 - patch release = 0

README.md

update default config section (if needed)
update example config file section
update help output section
consider adding an example (new or existing)
update comparison table (if needed)

parser.rs

add the option

wherever.rs

implement the new feature

Hey @poorpy! Just curious if you're still working on this issue or if you need any help? If not, would you mind if I took a crack at it? Please let me know. Thanks!

Hi @GobiasSomeCoffeeCo, feel free take over this issue.

Hope this question makes sense:
Hey @epi052, I started to look at this issue. Can you point me in the direction of where the finalized state is held/updated? Looking around the codebase, it seems FeroxResponse is responsible for this task, but I'm not exactly sure which file is handling the logic that is actually performing the task? Any help would be appreciated.

Yes, your question makes sense. There are a few structures you'll probably care about. The first is the Stats struct.  Next is FeroxResponses. Both of those structures can be serialized individually or as part of the FeroxState struct.
If it were me, I'd approach this issue by first examining what data is available to be reported. This would include the members of the Stats struct as well as the different items in a FeroxResponse (status code, url, etc...). After noting all of the data and what is relevant as an end user, I'd begin work on the html report, using dummy data as a starting point.
Once an html report is ready using dummy data, I'd then ping the project owner and figure out a good strategy on integrating the change into the larger project :wink:
Hopefully that's enough to get you going in the right direction. Lmk if you need anything else.

After thinking about it a bit, you could get the dummy data from a scan with -o and --json. I believe that'll have the configuration, each FeroxResponse, and the Statistics struct all serialized into json.

Appreciate the info! That'll help a lot. I was printing out the structs in different places last night to get a sense of where it was being handled.

Looking at the original request, and having some free time last night, my first instinct was to write a csv output file for the html report (as it's easy to search through different columns (IMO)).
I wrote what might be a naive solution to this, but wanted to test it out by integrating it into the larger project. I've been looking around, and was wondering where I could incorporate the logic?
The utils::write_to takes a ferox response, output file, and boolean json value and handles it. Was thinking something similar for writing a csv file? Hoping that I can take a response struct, the output file designated by the user, and create a report. Something along the lines of rust pub fn write_to_csv(ferox_data: &FeroxResponse, file: file: &mut io::BufWriter<fs::File>
and match on a Command::Report or creating a similar arm called Command::CSVReport?
Let me know if I am going in the right direction, or if I'm taking crazy pills and should restart from the beginning of the rust book with a hello world 😆?  If I need to do a 180, no issues, just want to make sure it fits into your larger picture with where you'd like it to go. Let me know! Thanks!

@GobiasSomeCoffeeCo sorry! I saw this message, and then spaced on the reply.  I saw the PR, I'll get a review going soon and provide feedback there directly. Thanks!


Found Error on crawl_cat_list.py

Python version: 3.10.4
PIP version: 22.1
OS: Windows 11 22000.675
Found problem if origin other then shopee.vn:
Example:
shopee.co.id
shopee.com.my
shopee.sg
Code:
import time
from shopee_crawler import Crawler`

crawler = Crawler()
crawler.set_origin(origin="shopee.co.id")

keyword = 'Beauty'
start = time.time()
data = crawler.crawl_by_search(keyword=keyword)
data = crawler.crawl_cat_list()
end = time.time()

print("Time : ",end - start, "seconds")

Error:
INFO:shopee_crawler.toolkit.crawl_by_search:There are 6516 products in "Beauty"
Traceback (most recent call last):
  File "D:\Program Files\Python310\lib\site-packages\urllib3\connection.py", line 174, in _new_conn
    conn = connection.create_connection(  File "D:\Program Files\Python310\lib\site-packages\urllib3\util\connection.py", line 72, in create_connection
    for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
  File "D:\Program Files\Python310\lib\socket.py", line 955, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno 11001] getaddrinfo failed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\Program Files\Python310\lib\site-packages\urllib3\connectionpool.py", line 703, in urlopen
    httplib_response = self._make_request(
  File "D:\Program Files\Python310\lib\site-packages\urllib3\connectionpool.py", line 386, in _make_request
    self._validate_conn(conn)
  File "D:\Program Files\Python310\lib\site-packages\urllib3\connectionpool.py", line 1040, in _validate_conn
    conn.connect()
  File "D:\Program Files\Python310\lib\site-packages\urllib3\connection.py", line 358, in connect
    self.sock = conn = self._new_conn()
  File "D:\Program Files\Python310\lib\site-packages\urllib3\connection.py", line 186, in _new_conn
    raise NewConnectionError(
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPSConnection object at 0x000001E33565F070>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\Program Files\Python310\lib\site-packages\requests\adapters.py", line 440, in send
    resp = conn.urlopen(
  File "D:\Program Files\Python310\lib\site-packages\urllib3\connectionpool.py", line 785, in urlopen
    retries = retries.increment(
  File "D:\Program Files\Python310\lib\site-packages\urllib3\util\retry.py", line 592, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='banhang.shopee.co.id', port=443): Max retries exceeded with url: /help/api/v3/global_category/list/?page=1&size=16 (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x000001E33565F070>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\project\shopee-crawler\index.py", line 14, in <module>
    data = crawler.crawl_cat_list()
  File "D:\Program Files\Python310\lib\site-packages\shopee_crawler\crawler.py", line 31, in crawl_cat_list
    return crawl_cat_list(self.origin)
  File "D:\Program Files\Python310\lib\site-packages\shopee_crawler\toolkit\crawl_cat_list.py", line 28, in crawl_cat_list
    total_count = get_total(origin)
  File "D:\Program Files\Python310\lib\site-packages\shopee_crawler\toolkit\crawl_cat_list.py", line 12, in get_total
    return curl(url)['data']['total']
  File "D:\Program Files\Python310\lib\site-packages\shopee_crawler\toolkit\curl.py", line 17, in wrapper
    return func(url)
  File "D:\Program Files\Python310\lib\site-packages\shopee_crawler\toolkit\curl.py", line 32, in curl
    return requests.get(
  File "D:\Program Files\Python310\lib\site-packages\requests\api.py", line 75, in get
    return request('get', url, params=params, **kwargs)
  File "D:\Program Files\Python310\lib\site-packages\requests\api.py", line 61, in request
    return session.request(method=method, url=url, **kwargs)
  File "D:\Program Files\Python310\lib\site-packages\requests\sessions.py", line 529, in request
    resp = self.send(prep, **send_kwargs)
  File "D:\Program Files\Python310\lib\site-packages\requests\sessions.py", line 645, in send
    r = adapter.send(request, **kwargs)
  File "D:\Program Files\Python310\lib\site-packages\requests\adapters.py", line 519, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='banhang.shopee.co.id', port=443): Max retries exceeded with url: /help/api/v3/global_category/list/?page=1&size=16 (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x000001E33565F070>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed'))

bug is now fixed on version 0.2.2.
Please re-install and try again.
!pip install shopee-crawler==0.2.2


Use simple USB API to expose UX on Mac

Using a simple USB API we need to write a Mac app to allow control of the ZMZ-1. I'd like to write it in Swift but may choose to do it in TCL/TK and run that under Python

Done!


Fix typo in custom-editor doc example code

The example code has a typo, the actual code right above is correct.

@jehartzog  thanks :)


Temp clone management

Summary
I'm working on a simple note taking app that auto-saves after user input. I've ran into some issues with temps and clones not behaving as I expected.

[x] Tell us about the problem your pull request is solving.

Calling clone.save() multiple times creates multiple rows in the DB because clones do not get the ID after the first create. This can be avoided by re-cloning after create succeeds, but that discards any changes to the clone that occur while waiting for the API server's response. So you have to copy modified properties to a temp object, then re-clone. This is tedious and can be avoided by just adding the ID received from the create response to the instance's clone.
Similar to above, clones keep their __isTemp status after successful create. This means subsequent calls to clone.commit() add __isTemp back to the original model instance. I didn't have any major issues with this, but it made debugging more confusing.
I am using the makeFindMixin to retrieve list items for my notes. When querying with temps: true, I briefly get a Duplicate keys detected ... This may cause update error. error from Vue after create succeeds. This is because my v-for's key is bound to the query result's item.id. But the real reason is that during the process of moving models from tempsById to keyedById, find() runs again and includes the model from both tempsById and keyedById. I can avoid this error by just binding the v-for's key to the v-for's index, but then I lose reactivity per item. ~The actual issue is that the addOrUpdate action is awaited when it doesn't need to be async at all. This wait causes the find() to run in the next tick which finds the model in both places and throws the duplicate keys error before addOrUpdate finishes moving the model.~ That only solved my issue because my API server is not sending created events back to the client that caused them. So I think a more general solution is to take the union (by ID or temp ID) between keyedById and tempsById in the find getter when temps: true.

[ ] Are there any open issues that are related to this?

no

[ ] Is this PR dependent on PRs in other repos?

no

Other Information
n/a

Thanks @hamiltoes!  Do you consider this ready to merge?

Yep!
Although after reviewing things today, I realized the find getter doesn't have to change if we just move the temp directly to keyedById in the updateTemp mutation. This would actually mean we could get rid of tempsByNewId. Then the addOrUpdate action could be simplified because it doesn't need to worry about tempsByNewId at all. It would just add or update based on whether the item already exists in keyedById.
Would you prefer I submit a new PR for that or just include it here?

I think I understand what you are saying. Feel free to update this PR
Sent from my iPhone

On Apr 25, 2020, at 6:09 PM, hamiltoes<EMAIL_ADDRESS>wrote:

Yep!
Although after reviewing things today, I realized the find getter doesn't have to change if we just move the temp directly to keyedById in the updateTemp mutation. This would actually mean we could get rid of tempsByNewId. Then the addOrUpdate action could be simplified because it doesn't need to worry about tempsByNewId at all. It would just add or update based on whether the item already exists in keyedById.
Would you prefer I submit a new PR for that or just include it here?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I think this simplifies the process of promoting a temp to a "real" item a bit

Released to npm in<EMAIL_ADDRESS>


Instruction to install package references wrong repo url

The command for installing the package seems to be outdated.
! pip install --quiet git+https://github.com/brunolajoie/taxifare_deep
It should be
! pip install --quiet git+https://github.com/lewagon/taxi-fare-deep

@krokrob can you have a look at this? It's a short one.


A formal release can be made now

[x] make a release in github
[x] register the pipy
[x] push a version to pipy
[x] add document to include a easy installation approach

solved in #62


New release?

it looks like a lot has been done, would be nice to get a new release is possible.
103 commits to master since this release

We are marching towards a v1.1.0 release, you can watch the progress with the above link or via v1.1.0


Check if python semantic release publish has support for removing/reverting tags/releases if not successful

Describe the bug
Quite recently, we have experimented a few issues related to the release process. While attempting to do a deployment, we had a problem while publishing the project to PyPi. According to the error, the email used to be published (vikas´s) needed to be verified from his account to publish the package. Once the email was verified, we re-tried the deploy again but it was not possible due to the tag for the current version already existed because it was created before the package tried to be published to PyPi.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
Ideally if the process fails after all, it should be handling the things created in a way that can be revertible or not affect the re run of the process.
Screenshots / Logs.
Verify email error:

Release tag already exists error:

Environment

OS: [e.g. iOS]
Python version:
Installed packages:

So this should be possible by decoupling the stages in the actions pipelines.
It's something I can look into.


FILLUP COMMIT is deprecated as of App::Dochazka::REST version 0.526


Back Button

User stories
As a User I want to be able to get back to the page I was before in order to get an intuitive UX
Dependencies
Depends on:

#4

Acceptance Criteria

[ ] Back button

We are unsure what type of back button is requested by this story.
It could be implemented as a back button with the same functionality as the browsers back button that is visible on all pages.
The drawback would be that this button would also be visible on pages that don't require a back button (f.e. the homepage) and it would also carry no semantic information about where the user would want to go.
Our proposed alternative would be as follows: We wait until other teams have created their pages (until Spring 2) and add our back button to each page that requires a back button.
Are you fine with that?

Not needed by Cient


Rename tools/lint-all to tools/lint.

Fixes #4574.

@timabbott not sure how to deal with the backend error..

Hmm, yeah, that backend failure automatically fix itself when we merge this.  Since it's at the end of the test suite, I don't think it's masking some other failure.
Merged, thanks @lonerz!


Backend - Update Task self sprint 2

This pull request implements a new feature for issue #82  allowing admins to create new tasks. To create a new task, send a PUT request to the /tasks/id/update endpoint with the following payload which are all optional:
{
'title': 'string',
'details': 'string',
'mentorManagers': ['string'],
'mentors': ['string']
}
Be sure to replace 'string' with the appropriate values for your task. Once the request is sent, the task will be updated and can be viewed by all users with the appropriate permissions.

Made a PR to the wrong change.


Add support for Jenkins Blue Ocean

See codecov/codecov-node/issues/55

This change should do the trick: https://github.com/codecov/codecov-bash/blob/a7792cd49f92cd359d789cc0aa576d1e562bac49/codecov#L410
The git log -1 --format="%H" is built into the bash uploader already.
Look good to you?

@stevepeak This change includes Groovy syntax which is invalid bash (see failing tests). Also, it doesn't take the CHANGE_ID for the pull request and it might result in an empty URL in some cases.

Thank you! Adding now and deploying soon.


fix: move additional args

What this PR does / why we need it:
Move additionalArgs to fall under controllerManager instead of controllerManager.image.
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #320
Special notes for your reviewer:

Codecov Report

Merging #326 (085c52c) into main (b644c33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   24.61%   24.61%
=======================================
  Files          10       10
  Lines         524      524
=======================================
  Hits          129      129
  Misses        383      383
  Partials       12       12

Flag
Coverage Δ

unittests
24.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703c8e0...085c52c. Read the comment docs.


Add missing feedback

New feedback etc. added while processing hacmkd.
Note: In the future, cut and paste the note away as a first step. That way if new stuff is added, it's new and can remain for the next day.

Working on the two remaining ones ...

Thanks @bast ! I will merge this.


[Speech] Moth speech bubble

About the PR

it's just cool, believe me.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: PuroSlavKing

add: Added custom speech bubble for the moth cloak.

theyre sneaking moth content into the repo


[Feature] Import and Export a project/app on cloud/local and vice versa

Summary
Let's say I have developed a project using docker on a local machine. I want to export this project to the appsmith cloud or different cloud and vice-versa
Motivation
Currently, It's difficult to share/ship a project built to a local machine to production on a cloud

Closing as duplicate of #488.
@s2agrahari Please feel free to add your thoughts and use-case on the other issue.


chore(lint): bump to tslint 4.3.0 and add a few new rules

Adds a few rules introduced or fixed by tslint 4.3

import-spacing
unified-signature
prefer-const
typeof-compare

and removes a rule for codelyzer (now handled by tslint directly):

import-destructuring-spacing

Fixes test.ts to use const instead of let.

It looks like most of the .spec blueprints need let/const changes as well.

@clydin 👍 that should be fixed now.

LGTM. Thanks!


Improve session timeout testing and add protection for spam handshakes

What was wrong?
In #209 - sessions will only timeout if the handshake has not been completed. The testing around session timeout is insufficient to determine that we actively timeout a session before the handshake is able to complete. discussion.
How can it be fixed?
Update the test to validate that the proper session_timeout event is emitted when a session times out due to a lack of response - for both the recipient and initiator.
This will likely need to be done by manually initiating the handshake and then halting it before completion since the Client APIs do not provide a reliable mechanism for halting a handshake midway.

I identified another improvement that will help mitigate this attack vector.
https://github.com/ethereum/ddht/blob/2f52f321bd57738ff354fb37b394318736810f15/ddht/v5_1/dispatcher.py#L271-L285
This function is sub-optimal as the running coroutine will wait longer than it needs to wait in the case where the handshake completes quickly.  This means that if we initiate a lot of handshakes, even if they all complete quickly, we'll accumulate a large number of waiting processes that are not strictly necessary.
What needs to be done is to change the mechanism.
def _wait_handshake_completion(session: SessionAPI):
    with trio.move_on_after(SESSION_TIMEOUT_SECONDS) as scope:
        await session.wait_handshake_complete()
    if scope.cancel_caught:
        ...  # remove session and emit the session timeout event.

Alongside this, we need to run these in a nursery.  At present, they get run as child tasks to the Dispatcher service.  Recently, we instituted a cap to the number of child tasks a service may run.  This limit is being hit right now in production.
The function above gets run in these two places:

https://github.com/ethereum/ddht/blob/c68797de8f2a79d18e244afcc87d43029a2505c3/ddht/v5_1/dispatcher.py#L317
https://github.com/ethereum/ddht/blob/c68797de8f2a79d18e244afcc87d43029a2505c3/ddht/v5_1/dispatcher.py#L344

We should instead switch to use the Events API to listen for newly created sessions instead of manually doing this at these call sites.
class Dispatcher:
    def _monitor_new_sessions(self) -> None:
        async with trio.open_nursery() as nursery:
            async with self.events.session_created.subscribe() as subscription:
                async for session in subscription:
                    nursery.start_soon(self._monitor_session_timeout, session)

This way all of these can be run in a single nursery without the overhead of all of the async-service mechanisms that aren't necessary for this case.

@njgheorghita I think that doing the fix I just outlined will also allow you to more easily test sessions being timed out since you can then manually fire the events.session_created() event with a running dispatcher and you should be able to then monitor for the timeout without having to actually do any of the manual handshaking stuff that was previously needed (because of how session timeout management was previously managed).
Also, it's sort of medium/high priority because it's causing crashes in production :grimacing:

@njgheorghita you can test if your solution is working by pulling down https://github.com/ethereum/ddht/pull/242 and running it with ddht --protocol-version v5.1
I've consistently hit the crash within a few minutes.

@pipermerriam 👍 I've got it working locally, and I'm no longer hitting the max child task limit - however, at about the same time (within 30 seconds or so) that I was hitting the child task limit, now I'm crashing with this error
https://github.com/ethereum/ddht/blob/2fcfaf7ddcd3805feb58734f2c0d50b76ad887fd/ddht/v5_1/client.py#L392-L395
It seems to me that the session is now timing out, causing this error. What is the desired behavior in case of an invalid response - do we want to still raise an exception?


SAP ECC 6.0 EHP 6 SAP Table

Hi,
We are going to start to implement ETL processes based on source SAP ECC 6.0 EHP 6.
I would like to know if the Version of SAP is supported by the DataFactory SAP table connector.
Thanks in advanced.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6445960a-ba4e-8e08-d9a7-326d35f902b6
Version Independent ID: fddcb50b-f74e-ce0d-af42-991587f456ca
Content: Copy data from an SAP table - Azure Data Factory
Content Source: articles/data-factory/connector-sap-table.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@alamoiker can you post a link to the doc you are referring to?

Sure! https://docs.microsoft.com/en-us/azure/data-factory/connector-sap-table#supported-capabilities
Thanks

@alamoiker Thanks for the feedback. We are actively investigating and will get back to you soon.

Hi,
Another question related to the previous one, which is the SAP component that Datafactoy  connects to?
In our Sap instance we have the following components:

SAP_BASIS
SAP_ABA
PI_BASIS
ST-PI
SAP_BW
SAP_AP
SAP_APPL
FINBASIS
ECC-DIMP
AIF
ST-A/PI

Thanks in advanced

@alamoiker Specifically, this SAP table connector supports:
Copying data from an SAP table in:

SAP ERP Central Component (SAP ECC) version 7.01 or later (in a recent SAP Support Package Stack released after 2015).
SAP Business Warehouse (SAP BW) version 7.01 or later (in a recent SAP Support Package Stack released after 2015).
SAP S/4HANA.
Other products in SAP Business Suite version 7.01 or later (in a recent SAP Support Package Stack released after 2015).

For more details, you check out the supported capabilities section: https://docs.microsoft.com/en-us/azure/data-factory/connector-sap-table#supported-capabilities
Hope this helps.


"Avrămești", "Andreeni", "Cechești" and "Goagiu" are listed in the drop-down menu

Description:
"Avrămești", "Andreeni", "Cechești" and "Goagiu" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Andreeni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Andreeni, HARGHITA (Avrămești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Cechești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Cechești, HARGHITA (Avrămești)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Type "Cechești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Cechești, HARGHITA (Avrămești)".


Release Google.Cloud.SecretManager.V1Beta1 version 2.0.0-beta04

Changes in this release:
No API surface changes; just dependency updates.

Created release for Google.Cloud.SecretManager.V1Beta1-2.0.0-beta04


[Bug Report] Can resize table headers by selecting header name

Element UI version
2.0.8
OS/Browsers version
Linux Debian Jessie (8) / Google Chrome 59
Vue version
2.5.13
Reproduction Link
https://codepen.io/ozanmuyes/pen/mpOdaM?editors=1010
Steps to reproduce
The last header of the table is unresizable, but if you hover the mouse to previous header's edge and let the cursor change to resize icon ('ew-resize' specifically) and then try to select the text of the unresizable header you see the header resizes.
What is Expected?
Expectation is the unresizable column's width stay fixed - unless of course a CSS change.
What is actually happening?
Can resize a column with :resizable="false" attribute.

The last column is "reassign" rather than "resize". Because el-table will dynamic reassign column width, it is hard to detect users' real purpose. Maybe it is a better solution to give last column a specific width?

Yes for the time being it seems a feasible solution. But nonetheless assigning fixed (pixel) widths (to be more generic anything fixed as measure) bloats the responsible architecture. Say if I want my table to have 50% of the device width for the first two columns under a CSS breakpoint I must do it in JavaScript. This is not always the desirable solution.
Also setting the width of the last 'unresizable' column will look ugly if I have right-fixed column, there will be a gap between last column's right edge and the fixed-right column's left edge. Stating no width for the last (last to fixed-right) column should have render it fluid. Wouldn't it be better?
Another question is reassigning to what exactly? Reassigning onto itself?

What is "reassign"
"reassign" means reassign width of this column.

fit: whether width of column automatically fits its container

el-table has a property called fit which will automatically reassign widths of columns(no specific width) to fit its container width.

gap

You will only see the gap if the sum of columns' width less than its container

I am sorry to confuse you about the meaning of "reassign". What i mean here is that el-table will use all available space of its container to fit container's width if you have not specific columns' width.
The demo you provided did have a gap between last column and the right fixed column. This is because that the container width is half of the device(el-col :sm="12"). So if you specific the width of each column and the sum of these widths is less than half of the device, it will show a gap because the right fixed columns should align its container's right edge.

Sorry, we do not think this is a bug report.


Beautifying the messages coming from the hooks

using terminal coloring tricks and giving the messages a better look (no need for relying on any 3rd party)

I would like to work on this one @lnxpy, If no one else currently does! What do you think?

@Farhaduneci that's amazing. Take your time. :))

@Farhaduneci that's amazing. Take your time. :))

Ok, please share any ideas that might inspire me 🤗


MockBackEnd backend for development unsing local json files

I need to code my app without backend using local json files.
I used ng-token-auth in a previous project and it worked very well.
    constructor(private _tokenService: Angular2TokenService) {
        this._tokenService.init({
           apiPath: this.endPointUrl
        });
    }

When I'm using rails server it's running ok, but using my local validate_token.get.json(as a simple copy of rails server log) is not working running this console error.

Who knows how can I solve it?

Looks like a problem with your CORS configuration to me. Did you check here?

@neroniaky I created a express backend to simulate it. We need a more complex mockup.
Thanks for your feedback!


A way to execute script functions

Looking through documentation, I couldn't find information about executing public functions of custom scripts. Is it possible?
For something like:
const { Menu } = globalsWatcher.useContext();
return <button onClick={() => { Menu.ExitGame(); }}>Exit to desktop</button>;

Where Menu is a game object with a script, holding the public ExitGame.
If not, is this a planned feature?

That's really, cool. Thanks!


No targets for training

When I train the VQA model I get the warning "Sample list has not field 'targets', are you sure that your ImDB has labels? you may have wanted to run with --evalai_inference 1"
I executed the same command as mentioned:
python -m torch.distributed.launch --nproc_per_node 4 tools/run.py --tasks vqa --datasets m4c_textvqa --model m4c_split --seed 13 --config configs/vqa/m4c_textvqa/tap_refine.yml --save_dir save/m4c_split_refine_test --resume_file save/pretrained/textvqa_tap_base_pretrain.ckpt training_parameters.distributed True
Can you provide additional details on this and how to train the model with the targets? And can you point out where the targets and the predictions are getting compared to compute loss?

Hi @abhinavkcs11 ,
The loss function is here: https://github.com/microsoft/TAP/blob/main/pythia/modules/losses.py.
Maybe we could trace from the "sample_list" in the loss functions, back to the data loader (e.g., https://github.com/microsoft/TAP/blob/352891f93c75ac5d6b9ba141bbe831477dcdd807/pythia/datasets/vqa/m4c_textvqa/dataset.py#L296) and see which part is not working as expected? Thank you.

When I train the VQA model I get the warning "Sample list has not field 'targets', are you sure that your ImDB has labels? you may have wanted to run with --evalai_inference 1"
I executed the same command as mentioned: python -m torch.distributed.launch --nproc_per_node 4 tools/run.py --tasks vqa --datasets m4c_textvqa --model m4c_split --seed 13 --config configs/vqa/m4c_textvqa/tap_refine.yml --save_dir save/m4c_split_refine_test --resume_file save/pretrained/textvqa_tap_base_pretrain.ckpt training_parameters.distributed True
Can you provide additional details on this and how to train the model with the targets? And can you point out where the targets and the predictions are getting compared to compute loss?

Have you solved this problem?

Hi @abhinavkcs11 ,
The loss function is here: https://github.com/microsoft/TAP/blob/main/pythia/modules/losses.py.
Maybe we could trace from the "sample_list" in the loss functions, back to the data loader (e.g.,
https://github.com/microsoft/TAP/blob/352891f93c75ac5d6b9ba141bbe831477dcdd807/pythia/datasets/vqa/m4c_textvqa/dataset.py#L296
) and see which part is not working as expected? Thank you.

Thank you for your excellent work.
I got a similar problem when I train Textcaps model, there is no "target"in sample_info in textcaps dataset.py as you know, so what I should do to fix this?


Use ArmeriaHttp(Client|Server)Parser by default in Brave decorators

Motivation:
We'd better to use our default parser for HttpTracing which are ArmeriaHttp(Client|Server)Parser
rather than Brave's default parser.
Modification:

Override (Client|Server)(Request|Response)Parser with ArmeriaHttp(Client|Server)Parser
if they are the default brave parsers in Brave(Client|Service).

Result:

ArmeriaHttp(Client|Server)Parser are used by default in Brave(Client|Service).

/cc @eonezhang

Thanks, @minwoox !

hmm I think next time ping someone who works on zipkin also? because the side effect if I understand correctly is if the parsers are what brave considers default.. armeria will modify them to not be default. This is intentionally inconsistent with other clients, so is a surprising choice especially when it is possible to override defaults.


Don't apply max_frag_len checking if no Max Fragment Length extension

Don't check the Max Fragment Length if the it hasn't been negotiated. We
were checking it anyway, and using the default value
(SSL3_RT_MAX_PLAIN_LENGTH). This works in most cases but KTLS can cause the
record length to actually exceed this in some cases.
Fixes https://github.com/openssl/openssl/issues/23169
While investigating this I encountered a build error on FreeBSD if KTLS is enabled, so I have fixed that too.
The test is tentative. I expected the test would reproduce the failure - but it didn't. I currently don't know under what conditions the failure occurs.

I've taken this out of draft - please review. I still can't replicate the problem directly, but the reporter has confirmed that this fixes the issue. The test does not seem to trigger the problem - but it does no harm to have it there anyway.

This pull request is ready to merge

Pushed to master and 3.2


Ghost container with broken rendering

Probably a backend issue, since the container doesn't exist anymore and the container doesn't disapper when reloading the UI nor waiting for a few minutes. Seems to have been part of a pod which failed to deploy:
vagrant@vagrant-ubuntu-vivid-64:~$ kubectl get pods
NAME                        READY     STATUS             RESTARTS   AGE
auth-2438279588-vidyc       1/1       Running            0          13m
dynamodb-4mz6p              1/1       Running            0          15m
fons-proxy-xd063            1/1       Running            0          3m
frontend-3616253037-0y0pz   1/1       Running            0          12m
hello-4088345290-ni49w      1/1       Running            0          13m
k8s-master-<IP_ADDRESS>        3/3       Running            0          15m
mailcatcher-qzsgp           1/1       Running            0          15m
sqs-ant9o                   1/1       Running            0          15m
users-db-esyk8              0/1       ImagePullBackOff   0          15m
weave-scope-app-kesb2       1/1       Running            0          15m
weave-scope-probe-qbd74     1/1       Running            0          15m

It's pause counterpart does exist though:
vagrant@vagrant-ubuntu-vivid-64:~$ docker ps -a | grep users
d361fd661fa0        gcr.io/google_containers/pause:2.0                   "/pause"                 17 minutes ago      Up 17 minutes                                k8s_POD.327e00d3_users-db-esyk8_default_83b9e460-0d59-11e6-a059-0800279b9f1d_e671a846

Report: report_ghost_container.json.gz

@2opremio have you ever seen this again?

We haven't seen this again. -> closing.


Add conda check and enable/disable options in plugin manager

Description

Type of change

[x] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

Fixes https://github.com/napari/napari/issues/5633
How has this been tested?

[x] example: the test suite for my feature covers cases x, y, and z
[x] example: all tests pass with my change
[x] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

@aganders3 and @psobolewskiPhD, this should handle the cases you outlined. A third case I mentioned has to be dealt differently and will think about it 🤔 and open a separate PR.

Testing in my non-conda env this works and I no longer get the option to install plugins with conda.
However, because of the issue you brought up with editable installs I'm actually not sure how to test this in a conda env now... My conda env with an editable install of napari also hides the conda option in the plugin manager.

However, because of the issue you brought up with editable installs I'm actually not sure how to test this in a conda env now... My conda env with an editable install of napari also hides the conda option in the plugin manager.

Since the PR is really small, we could do
conda create -n napari-test napari -c conda-forge
conda activate napari-test

and then manually change this line:
        if len(self._versions_conda) is not None:
        if (
            is_conda_package('napari')
            and len(self._versions_conda) is not None
        ):

Annoying, but... cant think of anything else

However, because of the issue you brought up with editable installs I'm actually not sure how to test this in a conda env now... My conda env with an editable install of napari also hides the conda option in the plugin manager.

Well to test that it does work we could just add a dummy file called
napari-0.4.17devwhatever-0.json in the conda-meta directory of the env, and then that should be enough to pass the is_conda_package check ?

I built a conda package from this branch and installed it locally. The good news is it does show the conda option in the plugin manager. Unfortunately it's also now giving me the conda option for non-conda packages (e.g. napari-boids) with an empty list of versions.
I also get errors when attempting to install. I think the first error here is basically that napari-boids does not have a conda package. The second is maybe related to the fact that I built this napari conda package locally and it's trying to pin it when installing natari?
Starting '/Users/aandersoniii/mf/bin/conda' with args ['install', '-y', '--prefix', '/Users/aandersoniii/mf/envs/napari', '--override-channels', '-c', 'conda-forge', 'napari-boids==']

CondaValueError: invalid package specification: napari-boids==

Task finished with exit code 1 with status 0.
Starting '/Users/aandersoniii/mf/bin/conda' with args ['install', '-y', '--prefix', '/Users/aandersoniii/mf/envs/napari', '--override-channels', '-c', 'conda-forge', 'natari==0.2.7']
Collecting package metadata (current_repodata.json): ...working...
done
Solving environment: ...working...
failed with initial frozen solve. Retrying with flexible solve.
Solving environment: ...working...
failed with repodata from current_repodata.json, will retry with next repodata source.

ResolvePackageNotFound:
  - napari=0.5

Task finished with exit code 1 with status 0.

Hmmm I just pushed what I think should fix it, could you test again?

This now appears to be working correctly for me, with the exception of what is already noted as FIXME. So I can't actually test installing conda packages, but testing both conda- and venv-based virtual environments shows what I would expect for the plugin installation sources.

Adding the ready to merge label and start counter @napari/core-devs ? 🚀

I think this constraint comes from trying to pin napari to the current installed version, such that installing a plugin that does depend on napari does not accidentally update your installed version of napari (a previous bug I think maybe you called out, @psobolewskiPhD?).
How did you install napari in the test environment? I think this is similar to the issue I had (in reverse) above and is called out in the code here: https://github.com/goanpeca/napari/blob/84fa8b2b26374c766f8575bc76ebaf6afc818e82/napari/_qt/dialogs/qt_package_installer.py#L219
All this to say I don't have a great solution in mind here 😕. I can give it some thought though.

it was pip install -e .[dev] --- not sure how else to pip install and get this branch.
I did raise the issue of napari getting downgraded by a plugin that had a napari version pin, which happens with a regular pip install as well. So here, with the manager, If a plugin pinned 0.4.17 (or lower) and I have 0.5.0dev I'd expect the install to fail.
But regular pip install seems content with a newer napari being present if a plugin depends on just napari. So it's a surprise to me that this pip install via the manager does not. I hope this is an edge case of dev napari, but it's a real use case: the conda nightly is an easy way to use napari given how long it's been since we had a release, so installing plugins by default method should work.
And yeah I saw that FIXME, but that's in the conda installer code? while I'm using pip install (the default), so I think that's using:
https://github.com/goanpeca/napari/blob/84fa8b2b26374c766f8575bc76ebaf6afc818e82/napari/_qt/dialogs/qt_package_installer.py#L89

I hope this is an edge case of dev napari, but it's a real use case: the conda nightly is an easy way to use napari given how long it's been since we had a release, so installing plugins by default method should work.

💯 - we should make this work

It will be nice to have information if a plugin has napari in its dependencies. As if the napari is not in dependencies or is in optional dependencies and conda env is used then the plugin could be installed from conda.

Starting with:

Mamba succeeds with no errors:
Starting '/Users/piotrsobolewski/Dev/miniforge3/bin/mamba' with args ['update', '-y', '--prefix', '/Users/piotrsobolewski/Dev/miniforge3/envs/napari-main', '--override-channels', '-c', 'conda-forge', 'napari-animation==0.0.5']

conda-forge/osx-arm64                                       Using cache
conda-forge/noarch                                          Using cache

Transaction

  Prefix: /Users/piotrsobolewski/Dev/miniforge3/envs/napari-main

  Updating specs:

   - napari-animation==0.0.5

   - ca-certificates
   - certifi
   - openssl

  Package             Version  Build         Channel                  Size
────────────────────────────────────────────────────────────────────────────
  Upgrade:
────────────────────────────────────────────────────────────────────────────

  - napari-animation    0.0.3  pyhd8ed1ab_0  conda-forge
  + napari-animation    0.0.5  pyhd8ed1ab_0  conda-forge/noarch     Cached

  Summary:
  Upgrade: 1 packages
  Total download: 0 B

────────────────────────────────────────────────────────────────────────────

Looking for: ['napari-animation==0.0.5']

Pinned packages:
  - python 3.10.*
  - napari 0.5.*
  -
Preparing transaction: ...working...
done
Verifying transaction: ...working...
done
Executing transaction: ...working...
done
Task finished with exit code 0 with status 0.

And that's despite the napari 0.5.*  too... 🤔 It did work:
napari-animation          0.0.5              pyhd8ed1ab_0    conda-forge

So the update behavior needs to be fixed. The conda docs indicate that conda update installs the latest version, rather than a specific one like that commands wants.
And yes with this conda nightly (again, not this PR), pip install (the default) does work.
I made a new pip install env and tested things there and also pip install was OK, so I guess I had something messed up with envs or git branches?
So my action item is to dismiss the erroneous review, but we should double check the conda update behavior!

From the PR party, @goanpeca should we migrate this to https://github.com/napari/napari-plugin-manager ?

@goanpeca we discussed this at the PR party.
Given the split off of the plugin manager and the fact that that won't go live till 0.5.0, then this PR should probably just me migrated to the other repo.
What do you think?

@goanpeca we discussed this at the PR party.
Given the split off of the plugin manager and the fact that that won't go live till 0.5.0, then this PR should probably just me migrated to the other repo.
What do you think?

Sounds good, will do it!


Class SilverStripe\Discoverer\Service\SearchServiceAdaptor does not exist

Module version
Which tagged version (or commit hash) are you using?
1.0.0
39bcae0360699f222e70ca6af99b9b362f292831
Problem statement
After following the simple search setup I'm getting an error Class SilverStripe\Discoverer\Service\SearchServiceAdaptor does not exist
Steps to reproduce
Set up controller to search from the basic setup guide
https://github.com/silverstripeltd/silverstripe-discoverer/blob/main/docs/simple-usage.md
Additional context
I've removed my vendor folder and re-run composer install and composer cache-clear

@vinstah can I please confirm that you also installed an integration module?
This is the error you receive if no integration module is installed.
I will update some docs in the meantime to try and make it a bit more clear that this module won't work without an integration module.

I've updated the module docs, and at the moment I'm assuming this error was because there wasn't an integration module installed.
Please let me know if that's not the case though, and I can re-open.


nimble-switch Component

😯 Problem to Solve
Need to create a new nimble-switch component.
💁 Proposed Solution
Should be able to use a fast-foundation switch class without any modification. Switch needs to be styled like the following visual design.

FAST component: https://explore.fast.design/components/fast-switch
Visual Design: https://xd.adobe.com/view/8ce280ab-1559-4961-945c-182955c7780b-d9b1/screen/3698340b-8162-4e5d-bf7a-20194612b3a7/variables/

📋 Tasks

[x] nimble-switch spec
[ ] nimble-switch custom element
[ ] nimble-switch unit tests
[ ] nimble-switch Storybook tests
[ ] nimble-switch Storybook docs
[ ] nimble-switch Angular wrapper
[ ] Add to Angular example app
[x] Update Component Status table in README

Related PRs

#403
#424
#432

Duplicate of #387


Add reblog and favorite API

This PR provides reblog and favorite API.

[x] GET /api/v1/statuses/:id/reblogged_by
[x] GET /api/v1/statuses/:id/favourited_by
[x] POST /api/v1/statuses/:id/reblog
[x] POST /api/v1/statuses/:id/unreblog
[x] POST /api/v1/statuses/:id/favourite
[x] POST /api/v1/statuses/:id/unfavourite

Coverage increased (+1.2%) to 37.955% when pulling 74901c994cc6a68f786e92524c64b84d7483e8a3 on 178inaba:statuses into b92f648ec3ccdffbc3bd16c6dd4a6d9fcbf3f86d on mattn:master.

Coverage increased (+2.4%) to 39.148% when pulling 6891f221bcf1570fac62f7d6ff4736888228ef82 on 178inaba:statuses into b92f648ec3ccdffbc3bd16c6dd4a6d9fcbf3f86d on mattn:master.

Coverage increased (+3.6%) to 40.296% when pulling bbb4df76cabed842ae899ed142a127b65c6379b3 on 178inaba:statuses into b92f648ec3ccdffbc3bd16c6dd4a6d9fcbf3f86d on mattn:master.

Coverage increased (+4.5%) to 41.24% when pulling 1495b1fb025cb2f9160b750ee43998fc6754abb9 on 178inaba:statuses into b92f648ec3ccdffbc3bd16c6dd4a6d9fcbf3f86d on mattn:master.

As it was related, changed the arg of the status func from string to int64.
Added a test of GetStatus.

Thanks! 👍 💯


ENH: Fast Lomb-Scargle Periodogram

Is your feature request related to a problem? Please describe.
The current implementation of the Lomb-Scargle Periodogram available in scipy has a number of issues / quirks; according to https://jakevdp.github.io/blog/2015/06/13/lomb-scargle-in-python/ :

The SciPy Lomb-Scargle periodogram is a C implementation of the naive O[N2] algorithm. The algorithm cannot account for noise in the data, and has some other quirks as well:

it requires you to center your data (by subtracting the mean) before computing the periodogram. If you do not, the results will be garbage.
it computes the unnormalized periodogram, which can be normalized manually as we'll see below.
it takes angular frequencies as the argument.

Describe the solution you'd like.
There are some faster and less quirky implementations available in other packages. However, these packages are often "subfield specific / tainted", and it would be great to have a high quality implementation that is shared across all fields and provided by scipy, rather than by a specific repo and package from the astonomy community, or the life science community, etc.
According to https://jakevdp.github.io/blog/2017/03/30/practical-lomb-scargle/ :

I'd recommend AstroPy's LombScargle in most cases today

and https://docs.astropy.org/en/stable/timeseries/lombscargle.html does look very good and detailed, with several algorithmic implementations (see "Summary" section there).
Would it be possible to pull the implementation(s) from there into scipy, and remove all astronomy specific aspects (should be none in the code itself, and come mostly from the documentation / blogs etc), to help diffuse these algorithms to a wider community?
The motivation for this is that, for many of us, scipy is the "default goto" solution, and if a method / functionality is available in scipy, we often use it and trust that it is good / high quality / as optimal as it should be and use it without digging further. Pulling the better implementations from astropy into scipy would allow people like me (and many others around me) who default to scipy when scipy provides a functionality, to have access to the better solution by default, without the need to use some hours to search the web and make their mind about what alternative solution is best.
Describe alternatives you've considered.
After some time making my mind, I think that https://docs.astropy.org/en/stable/timeseries/lombscargle.html is the best available, and I will use it for now.
Additional context (e.g. screenshots, GIFs)
No response

extra materials:

https://arxiv.org/pdf/1703.09824.pdf
https://arxiv.org/pdf/1502.01344.pdf

Thanks for raising this issue! Adding one small piece: here is how astropy wraps the scipy lombscargle function to add the various normalization schemes it supports: https://github.com/astropy/astropy/blob/main/astropy/timeseries/periodograms/lombscargle/implementations/scipy_impl.py

(and as an additional side note, https://github.com/astropy/astropy/tree/main/astropy/timeseries/periodograms/lombscargle/implementations is also where the faster implementations are available :) ).

I am broadly supportive of this, yes.

it requires you to center your data (by subtracting the mean) before computing the periodogram. If you do not, the results will be garbage.
it computes the unnormalized periodogram, which can be normalized manually as we'll see below.

#21277, #21721 and #21729 address those points.

it takes angular frequencies as the argument.

For backward compatibility reasons, I do not think it is possible to fix this.
Feel free to open a new issue, if I overlooked a relevant point in this discussion.


Consider using msgpack for Redis protocol

Right now the protocol is completely internal and uses the BinaryWriter APIs in .NET (which don't interoperate with anything else). If we want to open this up for allowing others to publish to clients via redis we should use something more standard (and also document and version the protocol).

I figured out why this is problematic. SerializedHubMessage's serialization logic lives in the core in order to allow it to be serialized by any lifetime manager. I think I can reasonably move it out.


Generate initializer functions in the Res file to avoid the MethodTooLargeException

Should we add a reproduction of MethodTooLargeException case to test-projects?

I don't think so. the test will require a lot of time to run.

Should we add a reproduction of MethodTooLargeException case to test-projects?

done


💡Vite + Angular - add to awesome-vite ??

updated: see https://github.com/xiaoxiangmoe/vite-ng-app-demo - idea from these closed issues:

https://github.com/vitejs/vite/issues/543
https://github.com/angular/angular-cli/issues/18599

add to https://github.com/vitejs/awesome-vite ??

P.S. I am extremely new Vite, hoping to try it out in the near future

Ojito


"preprocessing.py" and "content" missing

Dear authors,
first of all, thanks for sharing your very nice software. I'm trying to conduct a simple test with my own data, but I'm not able to find the "preprocessing.py" script. Also there is no "content" folder. Could you help me with that?
Thanks in advance.

Hey daormar,
I just added that for FoTo. Please feel free to check out the one that's there for WTM, my other project

Perfect, thanks very much for all your help!


RecordedTest attribute improvements

Consider making the test result configurable when a test is successfully re-recorded. Currently the result is an error to indicate that a re-recording was performed. Perhaps this should be configurable via env variable to support silent success in this case.
Add documentation to the attribute to indicate that setting the TF_BUILD environment variable will disable the re-record functionality. Consider also creating a separate variable that can be configured independently of TF_BUILD

For us (Storage) disabling the feature is important for situation where we bump service version across the board. Therefore decoupling the "kill switch" from CI is important and making it easy is also important (e.g. runsettings, global variable or both).

Closing this since there hasn't been any significant feedback since it was created.


Allow Setting the Custom Song Path Directly

i dont know if your still working on this but i use songcore too load my songs from my hard drive and that doesnt work because of how you get the song path

as a quick fix i just modified the code with dnspy


Expose Outputs of a Partially Built Transaction

Currently .config() method of a TxBuilder exposes some pieces of information about the state, such as collectedInputs, consumedInputs (are these two identical by the way?), totalOutputAssets, etc., but there is no property such as producedOutputs.
Having access to the outputs alleviates any need for keeping an external record.

will go with this approach, https://github.com/Anastasia-Labs/lucid-evolution/issues/188


[IMPROVEMENT] Telemetry storage metrics to break out nvme

Is your improvement request related to a feature? Please describe (👍 if you like this request)
We currently get a pie chart splitting between HDD/SSD. I think this is a distinction between HDD and flash instead (rotational or not) and should perhaps be relabeled?
If possible, could we break out HDD, SSD, and NVMe instead?
Describe alternatives you've considered
Something like hwinfo --disk can tell us the Driver:, which is even more detailed (we'd even be able to tell the USB connection mode from that, if that's a possibility.

cc @c3y1huang


Generate mock devices and traffic incrementally

The python driver should incrementally generate new devices and traffic -- just like in the real deployment.
Right now, it generates 30 devices at once, and then their traffic incrementally -- which is not realistic.

New feature in the mock data generation script: It generates...

two new devices every 10 seconds, up to 30 devices
traffic to/from all devices continuously


Added Dutch Translation

If you need more translations dm me.
Discord => Dark_Ville#4281
Twitter => @Dark_Ville1

Thanks :)


[102] Code coverage

Issues
#102 code coverage reporting
We don't currently have code coverage reporting, so we're using https://github.com/bcoe/nyc to instrument it in conjunction with our Ava tests.
Steps to Reproduce
Run npm run cover to run it once, or npm run cover:watch to continuously run.

DTM. As we start writing tests, I think it will be helpful for folks to have some guidance on how to interpret the coverage table even though we'll rely on our CI to let them know things failed. In short, some docs in frontier-codebook around testing would be great


[Question] How to write some docs for input types

Hey there! Is it possible to write some docs for my input types?
When I use the @Field annotation, I can use the phpdoc and the comment is transferred to the GQL field. When using a factory this won't happen 😞
Examples:
This is not working:
class MyFactory
{
    /**
     * @param string $value This comment won't be visible anywhere
     * @GQL\Factory(name="MyInput", default=true)
     */
    public function createMyInput(string $value)
    {
        return new MyObject($value);
    }
}

class MyObject
{
    /**
     * Even this comment won't be visible anywhere
     */
    public string $value;

    public function __construct(string $value)
    {
        $this->value = $value;
    }
}

This is working
/**
 * @GQL\Type()
 */
class MyType
{
    /**
     * This comment is visible as docs for this field.
     * @GQL\Field()
     */
    public function getValue(): string
    {
        return 'value';
    }
}

Please see #289

Hey @oojacoboo, thanks for your answer! Any thoughts about the release of that feature?

I believe this will be released in the upcoming 4.2 update.  I'm still waiting for clarity around this though.  We should have this update tagged and released soon.


mediaelementjs.com broken

@johndyer the website is referring to the file http://mediaelementjs.com/js/mejs-2.22.2/mediaelement-and-player.min.js when it should be referring to http://mediaelementjs.com/js/mejs-2.22.0/mediaelement-and-player.min.js. It's just a typo

THanks!


Original images aren't getting copied to snapshots folder

Describe the bug
Even though the snapshots folder gets created the original images aren't getting copied there when the web server is enabled.
Additional context
Looks like a call to copyToLocalStorage is missing.

Not a bug, this was never implemented. Will cover with #350


Not Returning objectSid for groups?

pulling for groups and I can't seem to get the following attributes:

objectGUID
objectSid

here is the snippet
    var ad = new ActiveDirectory(domainConfig);
    var query = 'CN=*';
    ad.findGroups(query, function (err, result) {
        if (err) {
            console.log(err);
            log.error("No Groups found.");
        }
        log.info(result);
    });

am I missing something?
by default the all attributes are returning, correct?

attributes - attributes to select and return (if these are set, the server will return only these attributes). Defaults to the empty set, which means all attributes.

+1 for this question


BW clock, does not play well with sunrise_clockinfo

TITLE: BW clock hangs and locks when sunrise_clockinfo is installed.
CONFIGURATION:
Bangle 2.
Firmware 2.16.7
BW clock 0.23
Slopeclock++ 0.5
Sunrise Info Clock 0.1
Latest everything else.
Steps to reproduce

install slopclock++ and observe that sunrise and sunset options are not displated in the clock info menu's
install BW clock and scroll through the Bangle menu without issue
install sunrise_clockinfo and observe sunrise and sunset options now in the clock info menus.
start up BW clock and select the Bangle menu.  At some point it will hang.

You will see the following on the IDE console:
Uncaught Error: Unhandled promise rejection: undefined
in function "altUpdateHandler" called from line 1 col 2110 in bwclk.app.js
...;alt="--";altUpdateHandler();
                              ^
in function "show" called from line 29 col 190 in bwclk.app.js
...ings.menuPosY-1];item.show();
                              ^
in function "drawMenuAndTime" called from line 38 col 509 in bwclk.app.js
....length+1);drawMenuAndTime();}if(is_upper){if(e.y<widget_size)...
                                ^
in function called from system
>

You will not see a sunrise or sunset option in the Bangle Menu.
Thereafter a black bottom half of the screen is displayed whenever you load BW clock.

logged again using BUG template


Simple i2c_master driver. TI Sensors Boostpack example.

Connects to https://github.com/tock/tock/pull/1190

Not sure if the TI Sensor BoosterPack example is desirable. I can pop that commit if not - it does add a lot of lines of code but is a useful example of how to hack some off-the-shelf drivers into libtock-c

Will do. I have an improved version that uses buttons and interrupts that I will complete and then write up in the next week or so.


Preload TextTracks as per default video element

Link to related issue (if applicable)
#1791
Summary of proposed changes
These changes bring Plyr captions download behaviour in line with that of the default video element in major browsers. Specifically, text tracks now only download as they are required. Previously all text tracks would download when the Plyr instance was instantiated - which becomes an issue when e.g. many translations are available.
For a track to be downloaded it must either be the default track, the active track when captions are toggled on, or selected from the captions menu.
Checklist

[x] Use develop as the base branch
[x] Exclude the gulp build (/dist changes) from the PR
[x] Test on supported browsers

Thanks for doing this 👍

Hey @sampotts I've just created another related feature request that I'd be keen to submit a PR for. Don't want to spend any time if it's not a good idea for core. Are you able to have a quick squiz / comment on #1803 - it has a demo linked.


Resolve pubsub future only when nothing can happen anymore

With these changes PubsubConnectionInner should complete only if every PubsubConnection have been dropped.
It should be enough to guarantee that:

there are no open subscriptions (PubsubStream keeps a reference to PubsubConnection and unsubscribes when dropped)
there's no one waiting on pending subscriptions (the promise keeps a reference to PubsubConnection)
no one will subscribe again (you need a PubsubConnection to do that)

Fixes #50

Any chance this PR could be accepted ?


Add an option to hide the Recommended section in the Start menu.

Is your feature request related to a problem? Please describe.
Title. Windows shouldn't be recommending stuff. It's annoying IMO.
Describe the solution you'd like
Title. All the Start menu replacements I know of (Start11, StartAllBack, etc.) are all paid, a Start menu that isn't recommending stuff would be nice.
Describe alternatives you've considered
N/A.
Additional context
N/A.

Ugh...

@MagmaBro123 It sadly isn't one "simple thing". If you have the Windows Education edition (SE) you can follow this article.
If not and you prefer not to use a 3rd party application, you are most likely out of luck...

If this helps please close this issue.


access: go-approvers

See https://golang.org/wiki/GithubAccess
Hi! Could I maybe have access to https://github.com/orgs/golang/teams/go-approvers for gardening issue tracker? It would be wonderful and love to help with mobile, stdpkg, and more.

Activity: issues
Contributions: gerrit, golang/go, golang/mobile

cc @golang/release @dmitshur @hyangah @hajimehoshi @bcmills @odeke-em

I support this!

Thanks for your contributions to to the Go project, and requesting this access—it is now granted. Your GitHub account should be invited now, so closing.
As a reminder, please be sure to review https://go.dev/wiki/Gardening and https://go.dev/wiki/HandlingIssues as part of helping garden issues. If uncertain about something, don't hesitate to ask.
Thank you again!


jwt: refactor e2e tests to not to wait for 1 minutes blindly for each test case

For https://github.com/istio/istio/issues/15641, this will save us for at most 4 minutes for each successful run of the security e2e tests.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
22cf0f622802b46de9c626a8c683baa4a774303e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
22cf0f622802b46de9c626a8c683baa4a774303e
link
/test lint_istio

integ-istioio-k8s-tests_istio
22cf0f622802b46de9c626a8c683baa4a774303e
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
22cf0f622802b46de9c626a8c683baa4a774303e
link
/test lint_istio

integ-istioio-k8s-tests_istio
22cf0f622802b46de9c626a8c683baa4a774303e
link
/test integ-istioio-k8s-tests_istio

integ-new-install-k8s-tests_istio
22cf0f622802b46de9c626a8c683baa4a774303e
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
765584f22d79d3422af8c5581d675b862e284e07
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
765584f22d79d3422af8c5581d675b862e284e07
link
/test integ-new-install-k8s-tests_istio

integ-security-k8s-tests_istio
765584f22d79d3422af8c5581d675b862e284e07
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
765584f22d79d3422af8c5581d675b862e284e07
link
/test integ-new-install-k8s-tests_istio

integ-security-k8s-tests_istio
765584f22d79d3422af8c5581d675b862e284e07
link
/test integ-security-k8s-tests_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
d49cd3ec05f70c446f75e538b567decbc2ad7b7e
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
765584f22d79d3422af8c5581d675b862e284e07
link
/test integ-security-k8s-tests_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
d49cd3ec05f70c446f75e538b567decbc2ad7b7e
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
d49cd3ec05f70c446f75e538b567decbc2ad7b7e
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio
d49cd3ec05f70c446f75e538b567decbc2ad7b7e
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
d49cd3ec05f70c446f75e538b567decbc2ad7b7e
link
/test integ-new-install-k8s-tests_istio

integ-mixer-k8s-tests_istio
d49cd3ec05f70c446f75e538b567decbc2ad7b7e
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


encode_and_sign vs sign_in

It seems like sign_in and encode_and_sign both set :guardian_default_token on conn. From reading the documentation I would expect sign_in to put the token on the conn, but not encode_and_sign. I would expect encode_and_sign to only place the token within :req_headers on conn.
Has this changed, or am I thinking of this incorrectly?

Hi @denvaar,
Not sure how encode_and_sign would put anything on the conn. It doesn't have access to it. Can you show the code that is resulting in this behaviour please?


window config in rust

I am trying to set window configuration from rust in tauri.
I saw in your website Through the Window in Rust but cannot understand what I must to do.
I cannot find any .with_title or .with_decoration in my rust source.
Operating System - Ubuntu, version 20.04 X64

Node.js environment
  Node.js - 14.18.1
  @tauri-apps/cli - 1.0.0-beta.10
  @tauri-apps/api - 1.0.0-beta.8

Global packages
  npm - 6.14.15
  yarn - 1.22.17

Rust environment
  rustc - 1.52.1
  cargo - 1.52.0

App directory structure
/dist
/src-tauri
/.vscode
/node_modules

App
  tauri.rs - 1.0.0-beta.8
  build-type - bundle
  CSP - default-src blob: data: filesystem: ws: wss: http: https: tauri: 'unsafe-eval' 'unsafe-inline' 'self' img-src: 'self'
  distDir - ../dist
  devPath - ../dist

Where did you see the .with_X methods in the docs? Those are tao methods which are not exposed in tauri.
You need to use Window or WindowBuilder and the methods they provide.