Resource requirements too high?

Are the resource requirements correct:
"two vCPUs and 350 MB memory per component."
or even
"three vCPUs and 600 MB memory per component"??
If I multiply by 3 then I have to have 6 vCPUs and 1 Gb of RAM just for this?? That cannot be, my current cluster is hosting 130+ pods and consists of 4 nodes Standard_E2ads_v5, should I double it just for Azure Policy?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b1d98d35-46d2-eb6f-6a0b-21df4d6438a8
Version Independent ID: 1a7a0c68-fa1c-d457-2be9-a919d4a5e64f
Content: Learn Azure Policy for Kubernetes - Azure Policy
Content Source: articles/governance/policy/concepts/policy-for-kubernetes.md
Service: azure-policy
GitHub Login: @timwarner-msft
Microsoft Alias: timwarner

@deyanp
Thanks for your feedback! We will investigate and update as appropriate.

@deyanp Can you clarify why we are multiplying by 3 here? Is it because the Azure Policy Add-on requires three Gatekeeper components to run?
The numbers shared (2-3 vCPUs and 350-600 MB per component) are intentionally on the conservative side so you are prepared and avoid usage risks.
The vCPU and MB usage ultimately depends on

the number of constraints the user applies and
the number of Kubernetes components that the constraints are evaluating

both of which are variable depending on your input.
If you have fewer constraints (i.e., less than 15), you can expect lower consumption.

Hi,
Perhaps I misunderstood the "The Azure Policy Add-on requires three Gatekeeper components to run" and the resource reqs to apply to each pod ...
Still, I would say the reqs are way too "generous". 3 vcpus is an amazing amount of processing power for just checking constrains and intercepting admin cmds.  Are the pods written in Python or what?  Speaking from my experience of hosting 130 pods on 8 vcpu with avg utilization of 10%, processing tons of business trxs per day ...
I know requests/limits are not actuals but how can anyone with a small cluster use Azure Policy then???
As usual, Security at MS is not built in, but comes with super high reqs....


A README that actually helps and encourages people to use & contribute to the package.

More informative
Easy to understand
Authentic because of the Razorpay branding(You might want to update the logo)
As per the generally adopted "The PHP League's" standards/structure for Package readme's.

Please update the docs in the wiki and proof-read the contributing guidelines. You might want to copy & paste the readme content on stackedit to preview how it would look.

Hey @introwit, thanks for the PR :100:

added @akshaybhalotia as reviewer for the contribution guide.

@captn3m0 @akshaybhalotia I have made the changes you said and can't discuss more where you will always adopt what you want at the end irrespective of the discussion made. I give up :disappointed:

@introwit I see you've granted write access to your branch. I'll push any further changes there if needed (/cc @akshaybhalotia)


what is addNavigationHelpers for?

I tried to follow this example to integrate redux but I consistently get exception: "cannot read property routes of undefined"
https://github.com/react-community/react-navigation/blob/master/docs/guides/Redux-Integration.md
However, I am able to integrate navigation state into redux without applying addNavigationHelpers. At least, I have the navigation state in the redux state tree when I console.log(store.getState()).
Can anyone tell me what is addNavigationHelpers used for? Is it required or optional?

Can you post your code?

It is required. As you can see from the source code, it is used to add necessary navigation helpers, like navigate etc. Thanks to that, you, as user, only have to supply dispatch and store function. That makes it easy to replace built-in state management with e.g Redux.
Your issue looks different to me (and I am pretty sure I've seen these errors already).

Duplicate of #485


feat: add missing connection info to various service types

About this change—what it does

Adds missing connection info to various service types.

Why this way

It was missing.

Tests: https://github.com/aiven/terraform-provider-aiven/actions/runs/9080783827

Tests: https://github.com/aiven/terraform-provider-aiven/actions/runs/9092119734

These changes require per service tests.

Sadly, automatically testing this isn't feasible. We can do manual tests, but I'm afraid implementing automatic tests for this would require enormous effort.

Tests: https://github.com/aiven/terraform-provider-aiven/actions/runs/9092732969

Tests: https://github.com/aiven/terraform-provider-aiven/actions/runs/9101292668


DEFAULT_MAX_MESSAGES

I assumed from the documentation that if create a dispatcher and subscribe (like the trivial example given in readme.md), then the pending limits would be set to the defaults. (DEFAULT_MAX_MESSAGES and DEFAULT_MAX_BYTES)
What I'm seeing under a debugger is that the dispatcher (NatsDispatcher) has a limit of 0, which means unlimited.
Is this intentional? Have I misread the documentation, and actually it is required to call setPendingLimits to have any limits?

That is a bug, the value should be the DEFAULT constants. I will fix.


New release for Ruby 3.0 support

Hi,
Would you be inclined to release a new version of this gem? The development branch supports Ruby 3 for a while now but there has been no new version since 1.1.0 (August of 2019). I'd like to keep using ssh_data without having to use the master branch on Github and pin it to a specific commit.
Looking forward to your reply!

@fuegas 👋 sorry for the delay in response! I think that is a reasonable thing to ask. Let me talk with some folks on cutting a release to put on Rubygems. I can't promise a turn around time on it but I have a note to get this done.

Well, that was quicker than expected. 1.2.0 has been pushed to rubygems.org.

Hi @vcsjones, thanks for the swift action and support! 💯


Fix editable tree item bugs

Fix some bugs seen in editable tree items:

In pages explorer, since the items were changed to show page display names instead of node names, the renaming feature was confusing and could even cause pages to be deleted unintentionally. Fix: Changed the renaming to update display name instead of node name.
In page hierarchy explorer, somehow clicking near the outside of an item triggered a blur event that cleared the editable input. Fix: I removed a state update to the value of this input that didn't seem like it was doing anything.
When deleting a page that is not the active page from the explorer, Toolpad changed to an empty app screen.

Before:
https://github.com/mui/mui-toolpad/assets/10789765/c9071693-1158-460b-8827-18282908496b
After:
https://github.com/mui/mui-toolpad/assets/10789765/ef648dc0-29aa-458e-a6cd-6393fa6d5ab9

Interesting. It feels a bit counterintuitive to me. :Like, you have a page "users". And you rename it to "employees". Now you have "pages/users/page.yml" in the file system and "employees" in the editor file tree. Maybe we need to change the editor file tree back to use page name? And then show the display name in a tooltip?

Interesting. It feels a bit counterintuitive to me. :Like, you have a page "users". And you rename it to "employees". Now you have "pages/users/page.yml" in the file system and "employees" in the editor file tree. Maybe we need to change the editor file tree back to use page name? And then show the display name in a tooltip?

Yeah originally when we added display names I thought the pages explorer would stay the same.
Let's change it back to showing the file names then but still show the display names, a tooltip might work!

Yeah originally when we added display names I thought the pages explorer would stay the same.

👍 I changed that, didn't give it enough thought

a tooltip might work

👍 another alternative is pageName (Display Name). But maybe that would create too long strings.

Yeah originally when we added display names I thought the pages explorer would stay the same.

👍 I changed that, didn't give it enough thought

a tooltip might work

👍 another alternative is pageName (Display Name). But maybe that would create too long strings.

Maybe this works? Just not a lot of space, but in most cases probably still enough. https://github.com/mui/mui-toolpad/pull/3187/commits/fbb838eb89e59b39b37dc51d39e722567899224e
https://github.com/mui/mui-toolpad/assets/10789765/60bda73f-5224-4e64-8baa-26c61a782d89

Ok, looks like a Tooltip does the job, just not as immediately visible but I think that's fine?
https://github.com/mui/mui-toolpad/assets/10789765/d8d34f2a-b89c-42f3-9e62-2e4e74990df6

Ok, looks like a Tooltip does the job, just not as immediately visible but I think that's fine?
https://github.com/mui/mui-toolpad/assets/10789765/d8d34f2a-b89c-42f3-9e62-2e4e74990df6

This feels like the best option to me 👍


Remove duplicate code

Just remove duplicate line of code.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>269f13613783a67ccfdf5ee3a98c9f-PR-6

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.954%

Totals

Change from base Build 79e120ded84645192af372a5a45f9256ddb83313:
0.0%

Covered Lines:
80

Relevant Lines:
87

💛  - Coveralls

Thank you!


Possible SingleOrDefaultAsync issue?

Hi Guys,
I bumped into a really strange issue when working on a project while using URF.core. I noticed that in my unit test a really simpel assert failed. But because there was a lot of custom code involved i first thought it was a mistake on my side so i skipped over it. Today I ran into the same issue again so I updated my fork of urf.core and added a simpel unit test:
[Fact]
        public async Task Product_Should_Not_Be_Null_After_A_Contains_Query()
        {
            // Arrange
            var repository = new Repository<Product>(_fixture.Context);

            // Act
            var products = await repository.Query().Where(p => p.ProductId == 1).SelectAsync();

            // Assert
            Assert.NotNull(products);

            // Act
            var product = await repository.Query().SingleOrDefaultAsync(s => s.ProductId == 2, new System.Threading.CancellationToken());

            // Assert
            Assert.NotNull(product);
        }

To my suprise this unit test is failing as well! Am i making a mistake or doing something wierd?
You can clone my fork to see it failing: https://github.com/Domitnator/URF.Core
I believe there is something going wrong in the SingleOrDefaultAsync because if i would replace that line with FindAsync:
[Fact]
        public async Task Product_Should_Not_Be_Null_After_A_Contains_Query()
        {
            // Arrange
            var repository = new Repository<Product>(_fixture.Context);

            // Act
            var products = await repository.Query().Where(p => p.ProductId == 1).SelectAsync();

            // Assert
            Assert.NotNull(products);

            // Act
            var product = await repository.FindAsync(2);

            // Assert
            Assert.NotNull(product);
        }

It works!
But it also works when i also request product with id 2 in the first query:
[Fact]
        public async Task Product_Should_Not_Be_Null_After_A_Contains_Query()
        {
            // Arrange
            var repository = new Repository<Product>(_fixture.Context);

            // Act
            var products = await repository.Query().Where(p => new List<int> { 1, 2 }.Contains(p.ProductId)).SelectAsync();

            // Assert
            Assert.NotNull(products);

            // Act
            var product = await repository.Query().SingleOrDefaultAsync(s => s.ProductId == 2, new System.Threading.CancellationToken());

            // Assert
            Assert.NotNull(product);
        }

So i'm not quite sure if it has anything to do with the SingleOrDefaultAsync method.
Hopefully you can help me out.

In the Repository implementation they have something like:
        private readonly IQuery<TEntity> _query;

        public Repository(DbContext context)
        {
            Context = context;
            Set = context.Set<TEntity>();
            _query = new Query<TEntity>(this);
        }

public virtual IQuery<TEntity> Query() => _query;

So when you use Query() and some subsequent query operations, it will remember the expressions because this instance is used throughout the existence of the Repository.
Which is wrong in my opinion, because queries are supposed to be fire and forget.
I have fixed it by removing the local field from Repository class and using this instead:
public virtual IQuery<TEntity> Query() => new Query<TEntity>(this);
This way every time I call Query(), the query is not caching expression trees from past execution.

Great catch! Will try to add something similar to my code. But i'd rather not change URF internals as this would force me to add project references instead of nuget packages.
@tonysneed @lelong37 How do you guys feel about this? If you want i can make a PR for this issue?

@Domitnator, yes I think a PR would be good.

@Domitnator if you could be so kind to issue a PR on this, that would be great.

Any idea when this pull request will be merged? I'm facing the same issue over here as well.

Fixed in https://github.com/urfnet/URF.Core/releases/tag/v2.2.0


Backport: Update UI for nodedriver fields

Backport rancher/rancher#20787

Will be available in v2.2.5-rc2

Version: v2.2.5-rc2
I carefully tested again like as was done in the source issue in v2.3 milestone but with v2.2.5-rc2:
I can confirm that we now see multi-line fields for fields that have UI hints.
For example, with openstack, privateKeyFile and is a multi-line field.
Also, userDataFile has been added in the API and this too is multiline. They don't initially appear as multiline (not apparent) but they are indeed multiline and in my browser I can use the handle at the bottom-right to expand these:

We do not have test accounts for other providers that might utilize ui hints, but the expected behavior is exactly the same. This is for situations where a UI is not provided by 3rd party drivers only so testing openstack should be sufficient.


feat(html): add more attributes

Hi.
Will using @kitajs/html for mailing, I figure that there is some missing html attributes on some tags.

valign is deprecated

Yep. Making mails template compatibility is a mess...
One can relay on deprecated attributes to ensure that all clients get the table based madness right...
https://www.caniemail.com/features/html-valign/
@arthurfiorette Should I remove this attribute ?

i think you can just add a /** @deprecated */ to it :)

Deal :handshake:


Update Cloud.py

Added getconnectstatus(deviceId) function to check is device connected to Tuya cloud

Great addition!  Thanks @Paxy !


Visibility in Encounter tracker doesn't track with actual token visibility

When combatants are added to the encounter tracker, the encounter tracker shows the correct visibility for the tokens.
Changing the visibility of the combatant in the encounter tracker or the token on the canvas, does not change the visibility in the other.

This would be a core feature.


Batch method

I need to write multiple document at the same time to the database. Is there a way to use firestore batch method with this api?

You should take a look at the set function, it should do the trick for you.


webintents?

Te should look into whether or not we want to use web-intents for making interactions with other apps easier. Currently there's native support in Chrome and a shim for other browsers (that uses http://webintents.org/'s API though).
This would give us a simple way to access and provide access for the following functionalities:

Share (!)
Edit
View
Pick
Subscribe
Save

+1 .. a possible lab-day project?

too old


Update basemap to be BCGov instead of ESRI Imagery

Overview
Update basemap to be BCGov instead of ESRI Imagery
Screenshots

This PR is a perfect example of why phasing out snapshot tests is the way to go, haha

exactly haha


List attended events on a member's page

Only the member/ a super user should be able to see which specific events they have attended.
This should be a single query with some fancy syntax to get the list of events back - because we can do a join on the attendance table. Might be hard to write in sql.

Turns out this is much easier than I thought it would be - I did the opposite for the list of attended members on an event


Additional Test Cases for Experimental Pipeline API

Change Summary
Note: PR still in progress.
(So far) Added the following test cases to test_pipeline.py:

test_parse_ge_le()
test_parse_multipleOf()
test_parse_tz()

Pre-PR Coverage of pipeline.py: 62.23%
Current Coverage of pipeline.py w/ this PR: 77.07%
Related issue number

fix #9524
Checklist

[x] The pull request title is a good summary of the changes - it will be used in the changelog
[ ] Unit tests for the changes exist
[ ] Tests pass on CI
[ ] Documentation reflects the changes where applicable
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Amazing thank you very much!


feat: added shopify mode to our SDK

Desciption
We are updating our SDK to work in Shopify store environment. For that we are doing a bunch of modifications to support this use case. I will list down the general philosophy we have followed.

Introduced a new mode in Account. For now this is an internal change and we have not exposed setting mode by customers. By default its WEB. We are controlling all the Shopify related changes using this new mode variable.
A new endpoint /shopify is added.
Added an async read and write mechanism in StorageManager since Shopify api returns a promise for reading and writing into localStorage. Also added a saveMode in StorageManager which will be used to determine which method to call.
Wrapped all window calls in a condition isWindowDefined to make sure we do not run into any runtime errors while calling window.

Closing this in favour of a new pr with a permanent branch /shopify


Question: Possible to start script on OBS Startup?

So, I noticed if I start OBS like normal and stream, my OBS commands don't work. I have to manually go to Tools>Scripts>Right-click the script>Reload each time and then it will work. Any way to fix that?

I will look into that.
If possible send me your logs, please?

My OBS logs?

Script logs.


[Snyk] Security upgrade io.netty:netty-all from 4.1.106.Final to 4.1.108.Final

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

keycloak-plugins/radius-plugin/pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

658/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.3
Allocation of Resources Without Limits or Throttling SNYK-JAVA-IONETTY-6483812
io.netty:netty-all:  4.1.106.Final -> 4.1.108.Final
No
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling

superseded by 4.1.109


[VL] Add partial hash aggregation memory configurations to avoid OOM

What changes were proposed in this pull request?
HashAggregation will check these four config value to decide whether abandon partial aggregation or not. We may need fine-tune these config value to avoid OOM in Large-scale Spark job.
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested.


Bump the helm version to latest release in Kanister build image

Describe the bug
Bump the helm version to 3.12.2 from 3.2.0. The older version is causing the integration tests to fail when using the latest helm chart for postgresql
Related issue: https://github.com/kanisterio/kanister/issues/2155

Fixed by PR https://github.com/kanisterio/kanister/pull/2206


404 Page for Flex Shrink Docs

the Docs link goes to:
https://tailwindcss.com/docs/shrink
"404: This page could not be found"
when it should go to:
https://tailwindcss.com/docs/flex-shrink

FIxed @kimstewartca


rviz: 1.14.17-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository rviz to 1.14.17-1:

upstream repository: https://github.com/ros-visualization/rviz.git
release repository: https://github.com/ros-gbp/rviz-release.git
distro file: noetic/distribution.yaml
bloom version: 0.11.2
previous version for package: 1.14.16-1

rviz
* Fixup to #1759 <https://github.com/ros-visualization/rviz/issues/1759>
* Contributors: Robert Haschke

I observed another regression and will file a new release later.


C# doens't propose me using namespace or framework installed related to add them automatically to the class

Environment data
dotnet --info output:
VS Code version:
C# Extension version:
Steps to reproduce
Expected  behavior
Actual behavior

n fact, I'm following a tuto on Udemy about .NET CORE and Angular, and the C# extension or Visual Code doesn't show me the quick fix when there is an error. It doesn't underline the error, it seems it doesn't recognize the new classes added and the new framework added too.

It doesn't recognize new classes or new package added :/ I don't know what to do :/

Closing as duplicate of https://github.com/OmniSharp/omnisharp-vscode/issues/3738


docker-compose VSTS task doesn't work with absolute paths pointing to the additional docker-compose files on windows agent

Environment

VSTS. Repro can be done with any docker-compose deployment

Issue Description
docker-compose VSTS task doesn't work with absolute paths, which is very common as you usually might select the docker-compose files from the GitHub path.
This is the task with the issue:

Sample VSTS deployment config. where it works with the deprecated docker-compose VSTS task but doesn't work with the latest VSTS docker-compose task:

Error logs
If using the latest docker-compose task, it crashes with the following errors:
2017-12-01T22:15:18.1585031Z ==============================================================================
2017-12-01T22:15:18.1595017Z Task         : Docker Compose
2017-12-01T22:15:18.1595017Z Description  : Build, push or run multi-container Docker applications. Task can be used with Docker or Azure Container registry.
2017-12-01T22:15:18.1595017Z Version      : 0.4.7
2017-12-01T22:15:18.1595017Z Author       : Microsoft Corporation
2017-12-01T22:15:18.1595017Z Help         : More Information
2017-12-01T22:15:18.1595017Z ==============================================================================
2017-12-01T22:15:20.3332853Z 36beab50-613b-4ee1-bba9-9265e8b95917 exists true
2017-12-01T22:15:20.3542537Z 217c3051-888c-4191-83dd-d87b0d2b2048 exists true
2017-12-01T22:15:22.0996245Z [command]"C:\Program Files\Docker\docker-compose.exe" -f d:\a\r1\a\dotnet-architecture_eShopModernizing\VM\eShopModernizedMVC\docker-compose.nobuild.yml -p eshopmodernizedmvc up -d
2017-12-01T22:15:23.4674867Z Creating network "eshopmodernizedmvc_default" with the default driver
2017-12-01T22:15:23.5763650Z HNS failed with error : The parameter is incorrect.
2017-12-01T22:15:23.6033651Z ##[error]Creating network "eshopmodernizedmvc_default" with the default driver
2017-12-01T22:15:23.6033651Z ##[error]HNS failed with error : The parameter is incorrect.
2017-12-01T22:15:23.6123662Z ##[error]C:\Program Files\Docker\docker-compose.exe failed with return code: 1
2017-12-01T22:15:23.6203641Z ##[section]Finishing: Deploy to QA Azure VM with Docker Compose command
2017-12-01T22:15:23.6253899Z ##[section]Finishing: Release
Workarounds
A. Looks like if you provide a relative path to the additional docker-compose files it works properly.
B. The deprecated docker-compose VSTS task works right in this regard, however, it is not recommended to be used as it has a security issue.
I talked to the VSTS team and this fix will be rolled out in the next VSTS deployment.
VSTS contacts:

Engineering: Jitendra Kumar & Aseem Bansal
Marketing: Dmitry Lyalin

#5994


Library/Dependency information

The LSP should define a request from the client to server to obtain the libraries/dependencies on workspace that can be used to display and browse the 3rd part dependencies of a project.

That would be a good feature.
However, it brings some questions:

Assuming we have a LS with 2 different and unrelated files open, and LSP doesn't really have a concept of resolving a given file to a project/dependency set. It seems to me that without introducing in LSP a structure of "projects", then the request would have to be made once for each file. LSP has the concept of workspace roots, but if you take JDT.LS as example, there is one workspace root but several dependency sets (basically one per Maven module or even per Maven source folders).
How would you expect for example to have the Maven depedencies rendered in an IDE using JDT-LS and showing basically a filesystem tree? Dependencies would be added as children on folders and apply to the folder children until another child overrides the dependencies? If so, what would be the right request to send to LS? Ask for all known dependency sets in the workspace? Or maybe something like workpsace/resourcesWithDependencySets: void -> URI[] resources (typically resolving to Maven modules) and then workpace/resolveDependencies: URI resource -> Dependency[] ?
What is the final use-case you have in mind? Is this a one similar to the one above -inclusion in the tree view of a project-, or mostly a way for a users to discover possible dependencies to add to the project?
It would requires a way to browse a dependency content, but this is not necessarily a filesystem content so we couldn't rely on expected filesystem browser provided by the IDE and would have to define a browsing model for dependencies in the LSP. Do we have strong enough semantics of what are the content of a dependency to define a common data type in the LSP? Basically, imagining we are using the requests as specified as above, what sould be the content of Dependency to cover the use case well?

There is some related discussion in https://github.com/Microsoft/language-server-protocol/issues/470 specifically the linked Build Server Protocol may be able to answer these questions.
At Sourcegraph we need to solve this problem around dependencies. The extensions we built on top of LSP allows us to provide cross repository find references for example. I'd be happy to discuss them further and maybe we can come up with proposals to LSP and/or BSP. It is a bit out of date, but you can see in master and PRs some of the changes we made to LSP https://github.com/sourcegraph/language-server-protocol

we need to solve this problem around dependencies.

Can you detail what is this problem in your case. I'm not sure your need for dependencies is the same as @gorkem 's one and that the same solution can fit both.
What's the user story you want to cover?

The model we were discussing recently is more about enhancing the browsing model than anything else. Basically, the language server could add nodes to the children of a particular folder URI. In this way, the semantics of this would be completely up to the language server.

Reminds me of Eclipse Common Navigator Framework and TreeContentProviders ;)
This indeed seems like something necessary in any IDE at some point. So it's not only dependencies but about adding treeNodes. So a request could be something like workspace/extraTreeNodes: URI|ExtraNodeUUID node -> ExtraNode[] children, with ExtraNodeUUID: {String uuid} and ExtraNode: { ExtraNodeUUID uuid; String label; String? iconData}.
Is this the kind of stuff you have in mind?

@keegancsmith as @tsmaeder said we had more of a browse model on mind which may include browsing inside the dependency too. Your case probably needs more attributes than we had in mind to be useful for you. Do you have any ideas on what kind of data you need?

@mickaelistria LSP uses URIs to identify stuff. If an implementor would like to put a UUID in the URI, that's their prerogative, but I would not mandate it in the API.

We heavily rely on using custom URIs to achieve cross dependency browsing. Our uris are essentially git://git/clone/url?path/to/file#rev. However, in the case of dependencies you quite often don't know much about the provenance of a package, all you have is the artefact you get from the package manager. So our attributes we store/index are really as much info as we can get about a dependency, but its very much language specific.

From my experiences these kind of information need to come from a project system which in many cases are connected to the used build system. Taking TS as an example this information needs to come from the settings in the tsconfig.json file since it determines which lib*.d.ts file to use. I like the discussion around this especially in the light of the proposed build server protocol. For the BSP we need to think about that in complex systems the LSP needs to consult the build system to for example correctly handle requests like call hierarchies / find references.

For the BSP we need to think about that in complex systems the LSP needs to consult the build system to for example correctly handle requests like call hierarchies / find references.

I agree. In my experience, getting this information from tsconfig.json falls short for more complicated use cases, and I believe there is a lot of value in connecting language server/editors with build tools via BSP.
In the case of Scala, for example, our build systems are flexible and customizable, and that makes it difficult to get correct diagnostics from the language servers alone since all the compiler information and project dependencies live in the build systems.
Our goal with BSP is to query the source of information in an extensible way, covering a subset of all the information covered by most of the build tools. As you see, it is also strongly inspired by LSP.
@dbaeumer I'm open to collaborating with people interested in supporting BSP for any build tool. I propose a way we could move this forward in https://github.com/Microsoft/language-server-protocol/issues/470.

I think there are two somewhat independent problems here:

The problem of logical problem model (which build target does this file belong too? What are the dependencies of the build target, as build system sees it?). This is hellishly complicated and necessary language and build-system specific.

The editor UI problem: if the user goes to the definition and ends up in the library file, what they actually see in the explorer?

I think we can tackle the second part relatively easy in a language and build-system independent manner. The simple UI solution here is to add additional read-only roots to the Explorer UI. The API could look like this:
direction: :arrow_right_hook: from client to server
method: workpsace/libraryRoots
params: none
response: LibraryRoot[]
export interface LibraryRoot {
	/**
	 * The associated URI for this library root.
	 */
	uri: string;

	/**
	 * The name of the library root. Defaults to the
	 * uri's basename.
	 */
	name: string;
}

For example, for Node projects, libraryRoots would include node_modules in the parent directories, for Rust, some paths from ~/.cargo/registry/src, for Python the site-packages of the current Python.
There's a curious case of Java's JAR files, but the API covers this case as well: uri can have a scheme like jar://, and then the client could, via custom file system provider, read the Jar and draw an explorer-like tree. If add a DidChangeLibraryRoots server to client notification, we solve the refresh problem as well.


update oe-selftests to use wait-until-provisioned feature

Just pushed up the changes. Still testing.

When I try to set up environment and bitbake, this happened:
liping@shovel:~/meta-updater-repo/_master$ source meta-updater/scripts/envsetup.sh qemux86-64
-bash: /home/liping/meta-updater-repo/updater_repo_master/meta-updater/scripts/../../poky/oe-init-build-env: No such file or directory
-bash: conf/bblayers.conf: No such file or directory
-bash: conf/bblayers.conf: No such file or directory
-bash: conf/bblayers.conf: No such file or directory
-bash: conf/local.conf: No such file or directory

@Zee314159 Hard to say without seeing your directory structure, but it looks like your layers aren't where we expect them to be. Let's move to chat.

The tests passed locally.
CI error message:
$ docker pull "$BITBAKE_IMAGE" || docker pull "$BITBKAE_IMAGE_MASTER" || true
Cannot connect to the Docker daemon at tcp://docker:2375. Is the docker daemon running?
Cannot connect to the Docker daemon at tcp://docker:2375. Is the docker daemon running?
$ docker build --pull --cache-from "$BITBKAE_IMAGE_MASTER" --cache-from "$BITBAKE_IMAGE" -f ./scripts/ci/Dockerfile.bitbake -t "$BITBAKE_IMAGE" ./scripts/ci
time="2019-07-23T13:25:35Z" level=error msg="failed to dial gRPC: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?: dial tcp <IP_ADDRESS>:2375: connect: connection refused"
Cannot connect to the Docker daemon at tcp://docker:2375. Is the docker daemon running?
ERROR: Job failed: exit code 1

Sounds like you need to rebase on master due to the problem that Laurent fixed in https://github.com/advancedtelematic/meta-updater/pull/560.


Fix/day of week offsets

This PR fixes two distinct issues parsing strings with time offsets relative to days of the week.
The first issue is that the modifier "offset" is being turned into a week offset for the day of week.  This makes sense for parsing some modifiers ('next', 'last', 'prior', 'previous'), but not for others ('from', 'before', 'after').
The second issue is that even with the previous issue fixed, backwards offsets were not applied properly for day-of-week modifiers.  The day of week was resolved properly, but parsing of the remaining chunk was left to the caller and would always offset forward.
The added test cases demonstrate the issues and the fix, as do the examples below.
Before:
>>> datetime.datetime.now()
datetime.datetime(2016, 2, 16, 14, 5, 24, 684154)
>>> cal.parse('Thursday')                 # correct
(time.struct_time(tm_year=2016, tm_mon=2, tm_mday=18, tm_hour=14, tm_min=5, tm_sec=34, tm_wday=3, tm_yday=49, tm_isdst=-1), 1)
>>> cal.parse('one day after Thursday')  # should give 2/19
(time.struct_time(tm_year=2016, tm_mon=2, tm_mday=26, tm_hour=9, tm_min=0, tm_sec=0, tm_wday=4, tm_yday=57, tm_isdst=-1), 1)
>>> cal.parse('one day before Thursday') # should give 2/17
(time.struct_time(tm_year=2016, tm_mon=2, tm_mday=12, tm_hour=9, tm_min=0, tm_sec=0, tm_wday=4, tm_yday=43, tm_isdst=-1), 1)

After:
>>> datetime.datetime.now()
datetime.datetime(2016, 2, 16, 15, 19, 6, 123021)
>>> cal.parse('Thursday')
(time.struct_time(tm_year=2016, tm_mon=2, tm_mday=18, tm_hour=15, tm_min=19, tm_sec=10, tm_wday=3, tm_yday=49, tm_isdst=-1), 1)
>>> cal.parse('one day after Thursday')
(time.struct_time(tm_year=2016, tm_mon=2, tm_mday=19, tm_hour=9, tm_min=0, tm_sec=0, tm_wday=4, tm_yday=50, tm_isdst=-1), 1)
>>> cal.parse('one day before Thursday')
(time.struct_time(tm_year=2016, tm_mon=2, tm_mday=17, tm_hour=9, tm_min=0, tm_sec=0, tm_wday=2, tm_yday=48, tm_isdst=-1), 1)

Current coverage is 77.03%

Merging #153 into master will increase coverage by +0.07% as of 2a987bc

@@            master    #153   diff @@
======================================
  Files           14      14
  Stmts         1554    1563     +9
  Branches       294     297     +3
  Methods          0       0
======================================
+ Hit           1196    1204     +8
- Partial         94      95     +1
  Missed         264     264

Review entire Coverage Diff as of 2a987bc

Powered by Codecov. Updated on successful CI builds.

Thanks for the fix and with tests!


Ensure all Memcached errors are surfaced

{  failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

/test openstack-operator-build-deploy


Migrate version of Text Pastry plugin.

Support Atom 1.x

thanks for reporting @dspaudio! This repository is seriously in the need of an update! I'll take a look later this week!

great PR! fixes #16 and #15


Manage 429 errors (too many requests)

Hi,
Sometimes my bot sends many notification messages, and it gets 429 errors (Too Many Requests).
To manage that, in SendWebRequest I've added:
... catch (HttpRequestException e)   {       if (e.Message.Contains("429 (Too Many Requests)"))       {                Thread.Sleep(10000);                return await SendWebRequest<T>(method, parameters);       } }
(in my actual code, I also added a limit to the number of retries)
But the bot keeps getting 429 errors, even after several retries; and without having sent other messages...
Am I doing wrong? Or did I miss something?

have you read the faq about this?

I did, but I forgot the limitation for groups :D
I think I'll have to wait 1 minute in that case.
Thanks ;)


Slovak translation

Here is Slovak translation. There are 2 files in ZIP: PowerPitch.csv and PowerPitch.sk.translation. Hope it's enough. Would you, please, pull it for me?
power_pitch.zip

Thanks much, just added your translation. But I need your name and github email to add you as a contributor:

Github needs your email address to add you as a contributor.

My name: Rudolf Kovalčík
email<EMAIL_ADDRESS>Thanks!
On Sun, Oct 14, 2018, 11:46 Nathan Lovato<EMAIL_ADDRESS>wrote:

Thanks much, just added your translation. But I need your name and github
email to add you as a contributor:
[image: image]
https://user-images.githubusercontent.com/12694995/46915079-5080a700-cfe1-11e8-89b3-862a215de257.png
Github needs your email address to add you as a contributor.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GDquest/godot-slides/issues/81#issuecomment-429610879,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ap9pvO_7XjOhINnT70qTrQVwYjMn6eTAks5ukwfYgaJpZM4XVceu
.


SecurityException: Binder invocation to an incorrect interface: V0.8.5

I'm getting this exception when i try to send(message) using messenger.
enforceInterface() expected 'com.firebase.jobdispatcher.IRemoteJobService' but read 'android.os.IMessenger'

In April 2019 we announced that Firebase Job Dispatcher would be deprecated today, April 7th 2020.  For this reason we are going to close all open issues and archive the repository.  We will also stop supporting FJD for new app installations (such as those targeting sdk versions greater than Android Q).  Existing apps that rely on FJD should continue to function as usual.
While we will no longer work on FJD, we encourage you to migrate to Work Manager which is a superior tool and fully supported by the Android team.
Thank you for taking the time to try the library and provide this feedback.  We sincerely appreciate your effort and we apologize for not addressing it in time.


Merge bitcoin#13134: net: Add option -enablebip61 to configure sending of BIP61 notifications

Tests currently fail. I did my best to fix them, this is a dependency for further p2p refactoring and changes I have done.

Needs rebase

rebased on develop

rebased again to (hopefully) resolve tests


Unable to import identity through ziti-edge-tunnel

Using ZEDW <IP_ADDRESS> Service 0.18.16, I cannot import an identity into ZEDW.
When I try and import using the client, using this command
c:\Program Files (x86)\NetFoundry, Inc\Ziti Desktop Edge\ziti-edge-tunnel.exe" enroll --cert cert.pem --key server.key --jwt autoenroll.jwt

I get the error StartServiceCtrlDispatcher failed (1063).
However, when I use the same files with the ziti cli, I get a .json file as expected.
ziti edge enroll --cert cert.pem --key server.key --jwt autoenroll.jwt --out id.json
INFO    enrolled successfully. identity file written to: id.json

I am working through trying to auto-enroll clients and having to download the ziti cli as a separate app to enroll an ID at the command line is a lot of extra work for something that should be quite simple/easy.  Also, the current work around involving copying the JSON file to the correct place and restarting the client would be a better experience if the application could monitor for any changes and reload itself, or when using ziti-edge-tunnel enroll that it would perform a reload by itself.

Hi @gooseleggs, thanks for the submission. We'll prioritize and take a look at this. I've marked it as a bug.

A recent change to the ziti-edge-tunnel fixed the command line version of this - but I want to keep this issue open until we can do this same sort of thing with the UI.


Translation

How do we change the language on the site - I'd assume SF has to do this also given our population's language needs.

I added an issue that is similar.. I think it might be nice if there are two increments of this.
Increment 1. Google Translate button (maybe closing out that issue that I just added)
Increment 2. The real feature. Real string translation with a cool system for contributions from native speakers/writers. (This issue)

Do you think this is the right framework---the built-in Rails Internationalization API?
http://guides.rubyonrails.org/i18n.html

@arena - just saw your post on Slack. Would love to hel0.. Ping me via email on Gmail (same ID as Github).

@siruguri - just sent you a dm via OpenOaklands slack team. :)

Sorry to be antiquated, but can we switch to old-fash email? I like to minimize my ADD by having only one channel of communication :)

@siruguri I've created these related issues
https://github.com/city72/city-72/issues/156
https://github.com/city72/city-72/issues/153
Thanks for the advice, help, and general awesomeness helping me wrap my head around the scope of this translation project.


[Bug]: Change Source Type Field in Table 414 to Enum for Extensibility

Describe the issue
The Source Type field in the IC Outbox Transaction table (ID 414) is currently defined as an Option. This limits its extensibility, as it cannot be customized by developers or partners.
Expected behavior
The Source Type field should be defined as an Enum to allow for extensibility and customization.
Steps to reproduce

Attempt to extend the Source Type field in the IC Outbox Transaction table.
Notice that the Option type does not support extensibility.

Additional context
This enhancement aligns with the extensibility principles of Business Central, allowing developers to better customize solutions for both SaaS and on-prem environments.
I will provide a fix for a bug

[x] I will provide a fix for a bug

That's an extensibility request. Transferring issue to correct repo.


Validate rewrite against various public repositories

closing in favor of linking commits here: https://github.com/openrewrite/rewrite-spring/issues/36


Add to npm

What are your thoughts about adding this to the Node Package Manager system, so that folks can use it that way.
I know that npm supports adding dependencies directly from github, but a distribution version of this would be great!
I'm more than happy to do the legwork here.

Good to hear from you, Dan!  It would be great if you could add jsfbp to npm - you sound like you're familiar with all these arcane tools!  Does npm have a way of publicizing new packages?
Have you used jsfbp - if so, did it hold up, and what enhancements do you see it needing?  It has been a point of frustration for me that I hear all these js gurus saying we can never get a JS tool accepted that relies on multiple stacks (via fibers), whereas I feel this results in much simpler (and more like "classical" FBP) JS FBP implementations!
Can I add you as a contributor?
Regards,
Paul

Great! I'm working on a pull request.
Since you don't know me, let me just say that I am not precious about my code, so please be direct about your feedback... I can take it :)
I am just getting into jsfbp. I tinkered with noflo but was frustrated about their bias towards coffeescript (to the point of not including JS examples in places).
As an ex-firmware developer, I actually really like fibers (as opposed to threads). The ability to multiplex without worrying so much about pre-emption is great!
You can certainly add me as a contributor (I actually did that in my update to package.json
I'll be creating a few more issues for questions and bug reports. Hope that's OK!

Hi Dan,
I really have to reeducate myself on jsfbp!  I have merged both your PRs,
and added you as a collaborator - although it seems that this isn't really
necessary as it looks like anyone can edit jsfbp... is this OK?
Feel free to go ahead with enhancements, bug fixes, etc.!
Cheers,
Paul M.
PS Why would the JS community resist fibers?!
On Wed, May 25, 2016 at 12:05 PM, Dan Rumney<EMAIL_ADDRESS>wrote:

Great! I'm working on a pull request.
Since you don't know me, let me just say that I am not precious about my
code, so please be direct about your feedback... I can take it :)
I am just getting into jsfbp. I tinkered with noflo but was frustrated
about their bias towards coffeescript (to the point of not including JS
examples in places).
As an ex-firmware developer, I actually really like fibers (as opposed to
threads). The ability to multiplex without worrying so much about
pre-emption is great!
You can certainly add me as a contributor (I actually did that in my
update to package.json
I'll be creating a few more issues for questions and bug reports. Hope
that's OK!
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/jpaulm/jsfbp/issues/36#issuecomment-221621157

And lo! it was so: https://www.npmjs.com/package/jsfbp

That's amazing!  Thanks a million!
Best regards,
Paul
On Thu, May 26, 2016 at 11:24 AM, Dan Rumney<EMAIL_ADDRESS>wrote:

And lo! it was so: https://www.npmjs.com/package/jsfbp
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/jpaulm/jsfbp/issues/36#issuecomment-221904266

Sorry, Dan, Marcel, I have just destroyed the copy of jsfbp on my C drive,
and my Readme instructions don't seem to work any more!  I run Win7.   It
started because I couldn't get access to .git/FETCH_HEAD after upgrading
posh_git...  Someone suggested deleting it, but that doesn't seem to help!
Could one of you take a look at the readme, and see what is going wrong?
TIA
PS Pls ignore title of this note
On Thu, May 26, 2016 at 11:24 AM, Dan Rumney<EMAIL_ADDRESS>wrote:

And lo! it was so: https://www.npmjs.com/package/jsfbp
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/jpaulm/jsfbp/issues/36#issuecomment-221904266

I just created #42 to track this


It crashes when i load in a game

everytime i inject in menu its fine but when i load in a game it crashes

Try to redownload the sourcr

i have done that twice

do u think u can add me on disc and send the dll please?

Just recompile it under x86 Release using AVX/AVX2 compilation under Project Settings. It will compile a more enhanced and optimized version of the cheat unique to your hardware. Therefore there will be a minimal % of crashes.

Just recompile it under x86 Release using AVX/AVX2 compilation under Project Settings. It will compile a more enhanced and optimized version of the cheat unique to your hardware. Therefore there will be a minimal % of crashes.

How do I recompile it as an AVX in visual studio?

It still crashes ;c

It still crashes ;c

Delete the csgo folder in the directory and check the integrity of the game files.

Have u got discord?


Name!?

So the app is inconsistent as to whether its name is "timesheet" or "Time Tracker". I have a very slight preference for the latter, but would appreciate any feedback. Also alternate suggestions are totally welcome.

Time Tracker feels more productive personally :+1:

I'm also wondering if there's a catchier/more appropriate name out there. After all, this app is more than just a timesheet/time tracker anyway - it's a combined ToDo list and time tracker.

Someone proposed to me yesterday the idea of using a completely unrelated name that is catchy, sort of like "Toggl" (as in the mildly-relatedness, not using a name similar to "Toggl"). He suggested "AWOL", which is catchy, but I'm not sure if it's even mildly related.

Rolling with "Time Tracker" for now.


Roadmap for Alpha

Necessary

[ ] #55
[x] #106
[ ] #123
[x] #134
[x] #157

Nice-to-have
Almost necessary, but coming up something better than the current placeholder icon of GodSVG can be postponed to further down the line. #51
Everything else are just nice-to-haves. I'm not restricting development to just these five things, there may be other features and bugfixes before releasing an alpha. Also, after everything is finished, there will be half a week spent on bugfixing and polishing to make GodSVG more presentable.

Closing as almost everything is resolved, the remaining few can be pinned.


Make BLEClient::connect (BLEAddress address) to be a non blocking call

Hello,
it's a great library so I want to thank You, and I have a little proposal.
Make BLEClient::connect (BLEAddress address) to be a non-blocking call or at least provide a way to set a timeout.
Thanks
Ivan

Studying ... the core function behind BLEClient::connect() is the API called esp_ble_gattc_open.  Checking  to see what its timeout properties may be.

Yes, if in time frame between scanning and connecting to the server, it disappears, or stop responding, or change it's address and then we try to connect to it, entire our app will 'hang', waiting for server to be back online. I know it's a rare situation, but it happened to me ,while developing and experimenting.

Hello again,
I think I found an answer to my question in following example explanation:
https://github.com/espressif/esp-idf/blob/5ee7233b5bc09d7446c14cdda74868b491495cd2/examples/bluetooth/gatt_client/tutorial/gatt_client_example_walkthrough.md

Finally if the remote device name is the same as we have defined above, the local device stops scanning and tries to open a connection to the remote device using the esp_ble_gattc_open() function. This function takes as parameters the Application Profile GATT interface, the remote server address and a boolean value. The boolean value is used to indicate if the connection is done directly or if it’s done in the background (auto-connection), at the moment this boolean value must be set to true in order to establish the connection....

Thanks for help and if You find a way to solve this problem please let us know.
Ivan

Is there any progress or update on this?
This would be great especially in context with the esp32's ability to connect multiple devices. The first device can then already be used while the connection to the second on is in progress.
Is it e.g. possible to run the connect in a separate esp32 process or similar? Or implement a custom version of connect?

Is it e.g. possible to run the connect in a separate esp32 process or similar? Or implement a custom version of connect?

You can try. When you create new BLEClient object it will have its own set of semaphores, thia may work as long as there is no limitation in hardware or bluedroid stack.

I want to use an ESP32 as a BLE->WiFi gateway to handle multiple servers where the servers come and go a lot. I'd really like to see a non-blocking API.

esp32 emulating a WeMo smart switch.  Sending BLE reads and writes when on/off commands are received by the Wemo code.  The Wemo becomes unresponsive when the BLE code blocks.  Even when the BLE server is in range,  it can take 1050mS for connect to comeback.


Add coverage checks to build, no functional changes

Coverage increased (+3.09%) to 100.0% when pulling 29c0d05f557881c66822450329422389d4c1a93b on knugie:master into 6cd7ad53228166b401c750fe324699d82f584871 on Sage:master.

Coverage increased (+3.09%) to 100.0% when pulling 98bb53c5095e8931e1540e647f1700c8c4d8a5b3 on knugie:master into 6cd7ad53228166b401c750fe324699d82f584871 on Sage:master.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[ ] Appropriate changes to README are included in PR

Fixed the validation.py script to only allow the first letter of the username to start with an alphabet.


v 2.0.0 failing to install via NuGet

With error
Could not install package 'Cirrious.FluentLayout 2.0.0'. You are trying to install this package into a project that targets 'MonoTouch,Version=v1.0', but the package does not contain any assembly references or content files that are compatible with that framework.
My project is not targeting the Unified API (yet) - could that be the reason for the error? If so, what earlier version can I install?
Thanks!

Thanks for your email.
For free open source support, I point people towards open public
communication - e.g. towards StackOverflow. A question and answer in public
can involve 100s of people - a question and answer in email involves just
two.
For paying customers, I do work in email. But most people seem to prefer
"free"!
Stuart
On 16 January 2015 at 09:16, mrtnkrstn<EMAIL_ADDRESS>wrote:

With error
Could not install package 'Cirrious.FluentLayout 2.0.0'. You are trying to
install this package into a project that targets 'MonoTouch,Version=v1.0',
but the package does not contain any assembly references or content files
that are compatible with that framework.
My project is not targeting the Unified API (yet) - could that be the
reason for the error? If so, what earlier version can I install?
Thanks!
--
Reply to this email directly or view it on GitHub
https://github.com/slodge/Cirrious.FluentLayout/issues/15.

Going through some old issues...as of 2.0 we are indeed built on the unified API. That was also our first NuGet release, so if you need a non-unified version your best bet is to pull down the code from before that commit and create a build that way.
I do suggest you just migrate to unified if you haven't already, though! :smile:


Define scope of this Electron App's MVP

What do we want the electron app to be? What level of polish/features should it include? Is it intended to be a sample 'guide' to embedding voyager.

Let's discuss what's important as a MVP to demonstrate how to embed Voyager.
I think it's still important what are the basic operations that Voyager wrapper would expect to do.
Input
Important

[ ] Open an TSV.
[x] Open a JSON file.

Less important
(Possibly out of scope)

[ ] Open a .vl.json file and load both the data and encoding into the shelf

Output

[ ] ...

cc: @tafsiri  I'm replacing the note in the board with this issue :)

[ ] Also need to clean up the app view itself

@kanitw @vlandham. I've made a TODO list above for some generic things to do in the app. Open questions still include what if any output comes from voyager, but unless we have an idea of what we'd want to demonstrate in this app; that may be an issue better made in the main voyager repo.

Closing this as all the items are complete or broken out into other issues.


[SPARK-20642][core] Store FsHistoryProvider listing data in a KVStore.

The application listing is still generated from event logs, but is now stored
in a KVStore instance. By default an in-memory store is used, but a new config
allows setting a local disk path to store the data, in which case a LevelDB
store will be created.
The provider stores things internally using the public REST API types; I believe
this is better going forward since it will make it easier to get rid of the
internal history server API which is mostly redundant at this point.
I also added a finalizer to LevelDBIterator, to make sure that resources are
eventually released. This helps when code iterates but does not exhaust the
iterator, thus not triggering the auto-close code.
HistoryServerSuite was modified to not re-start the history server unnecessarily;
this makes the json validation tests run more quickly.

For context:

Project link: https://issues.apache.org/jira/browse/SPARK-18085
Upcoming PRs that build on this code: https://github.com/vanzin/spark/pulls

Test build #80420 has started for PR 18887 at commit 842589d.

Test build #80422 has started for PR 18887 at commit 1f08bd7.

Test build #80420 has finished for PR 18887 at commit 842589d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class KVStoreMetadata(
case class LogInfo(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80420/
Test PASSed.

Test build #80431 has started for PR 18887 at commit 1ec1a67.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80422/
Test PASSed.

Test build #80431 has finished for PR 18887 at commit 1ec1a67.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80431/
Test FAILed.

hmm... @squito @ajbozarth @jerryshao

Test build #80639 has started for PR 18887 at commit b696f96.

Test build #80639 has finished for PR 18887 at commit b696f96.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80639/
Test PASSed.

Test build #80701 has started for PR 18887 at commit 519dab0.

Test build #80701 has finished for PR 18887 at commit 519dab0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80701/
Test PASSed.

Merged build finished. Test PASSed.

Test build #80750 has started for PR 18887 at commit dc642bd.

I feel like we should have one version where the old code is still available, controlled by a feature flag.

I'm not sure exactly what you're suggesting. The default behavior is still, as much as possible, the old one: everything is kept in memory. Keeping the exact old code in place would mean forking FsHistoryProvider, which is not something I see as desirable.
Also, forgot to reply to an earlier comment by @jerryshao :

looks like we removed some synchronizations here, I'm not sure if

KVStore instances are thread safe, so a lot of the old synchronization in this class does not apply. There was code before that used non-thread-safe data structures (such as attemptsToClean), which has been replaced with storing things in the KVStore instance instead.

I feel like we should have one version where the old code is still available, controlled by a feature flag.

I'm not sure exactly what you're suggesting. The default behavior is still, as much as possible, the old one: everything is kept in memory. Keeping the exact old code in place would mean forking FsHistoryProvider, which is not something I see as desirable.

long-term, definitely not desirable.  My concern is that there is a lot of new code taking effect here, on some important functionality -- we don't want some bug to prevent adoption of 2.3. For one version, you could leave the old one available, rename it to something else, and put a big disclaimer in the code that its obsolete, and as long as thing are smooth for 2.3 delete it entirely for 2.4.  The HS isn't as core or tricky as the network module but I'm thinking of this like netty vs. nio.

There's quite a log of unit tests that cover this code; forking would mean also making those unit tests run against both versions of the code so that no one breaks anything, and potentially fixing bugs in two different places if they're found.
I'd rather avoid the overhead. The bulk of FsHistoryProvider, which is the part that actually monitors the file system and makes decisions about when to parse things, is mostly unchanged.
And the rest of this project is way more disruptive than this one change.

Test build #80750 has finished for PR 18887 at commit dc642bd.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80750/
Test FAILed.

retest this please

Test build #80757 has started for PR 18887 at commit dc642bd.

Test build #80757 has finished for PR 18887 at commit dc642bd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80757/
Test PASSed.

Merged build finished. Test PASSed.

Just to keep others in the loop, Marcelo and I talked about this some offline.  I think this PR itself is fine, but to me this is an important point in the larger history server project he's doing, so I'm going to take a look at the rest of the changes as well before I feel comfortable merging.  Also he explained why it extremely complicated to keep both the old & new version available, which make sense to me, though I may poke at a version myself just to see how complex it is.

I futzed around for a while with trying to keep the old stuff around, and I realized it really would be quite a mess.  The biggest problem is that the old rest api is just waay too tied into the UI, eg https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/status/api/v1/ExecutorListResource.scala#L26 , probably my fault in that implementation of the rest apis.  You could keep the old code around, but would involve so much moving and refactoring that it seems pointless.
I'm still looking at the other changes in the larger project, and I'd encourage other reviewers to do the same.

I have the same concern, as @squito said above https://github.com/apache/spark/pull/18887#pullrequestreview-56700674. Refactoring the old codes does not seem pointless to me.
To evaluate the impacts, I have a few questions:

What is the migration proposal/guides?
What is the proposal when users have multiple different Spark versions in their production environment or migration procedure?
How users should do when users hit a serious bug we are unable to find at this stage?
What are the external behavior changes between the new and the old ones?

What is the migration proposal/guides?

Not sure what you mean. There's no change in behavior by default, so there's no migration of anything needed.

What should users do when they hit serious bugs that we are unable to find at this stage?

This is always a question when you introduce a change. This particular project makes it a bit worse since it's a bigger change. But the answer is the same: file a bug, we fix it, next release has the fix; if it's really important for you, you can patch your own Spark, or revert to an older release, as many people do when they find blockers.
The changes in this project do not influence whether your application will fail or not; they're isolated to the UI, so at worst it will make things harder to debug until the issues are fixed.
On the other hand, a lot can be mitigated by testing; there's already a lot of test coverage for parts of this code, but the UI is kinda the exception there. So the longer these changes stay in review instead of being committed, the less coverage they'll have in people's day to day testing, actually increasing the risk that some bug might be missed.

What are the external behavior changes between the new and the old ones?

None by default.

Test build #81697 has started for PR 18887 at commit 9020184.

Test build #81697 has finished for PR 18887 at commit 9020184.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81697/
Test PASSed.

Test build #81890 has started for PR 18887 at commit 56b68a0.

Test build #81890 has finished for PR 18887 at commit 56b68a0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81890/
Test PASSed.

Merged build finished. Test PASSed.

can you also include the format? i.e. how to convert the list information to key-value entries

@cloud-fan not sure I understand your question. What format are you talking about?

nvm, I looked at your previous PRs, the "format" is already defined in kv-store, as the kv-store can read/write objects directly.

Test build #82154 has started for PR 18887 at commit b2b969c.

Test build #82155 has started for PR 18887 at commit cd2172a.

Test build #82154 has finished for PR 18887 at commit b2b969c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82154/
Test PASSed.

Test build #82155 has finished for PR 18887 at commit cd2172a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82155/
Test PASSed.

LGTM

Thanks for your work!

Test build #82206 has started for PR 18887 at commit 5eff2c5.

Test build #82206 has finished for PR 18887 at commit 5eff2c5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82206/
Test PASSed.

Merged build finished. Test PASSed.

LGTM, merging to master!

sorry, this is causing a checkstyle error for me while building the project due to the presence of a finalizer method. I can't understand how this was able to pass the Jenkins test. Does someone have any clue on that? Thanks.

hmmm weird, @srowen any ideas?

Oh, is it because SBT doesn't run checkstyle but Maven does, and SBT runs the PR builder? This could be my fault, for recently re-enabling checkstyle. This may be why. Well, for now, I'd at least just submit the hotfix to suppress this checkstyle rule

yea the PR build use SBT. But I think SBT also run checkstyle before?

I don't think so because checkstyle is for Java only and SBT won't compile Java code.
I'd kind of love to stop mixing SBT and Maven but that's quite a separate thing.
I'll put up a HOTFIX that both fixes the style violation and disables checkstyle again. Now I remember this was the reason -- it wasn't because we used to compile Java code separately from the Scala code.


[Enh]: Add .sqlite as valid file extension

Thanks!

Thanks for the tool :) Happy to replace yet another stovepiped app!


[Accelerate] [vDSP] Elementwise Vector-Vector and Vector-Scalar Arithmetic

This PR contains a suite of Swift-friendly overlays to the vDSP elementwise arithmetic operations.
The overlays simplify the API to the existing functions and accept collections that implement _ContiguousCollection.
cc: @moiseev @airspeedswift @stephentyrone

I might even drop the label from subtract (though I’m sure someone will think that’s a bad idea). The trouble is that there’s no X in English that makes this work: “subtract(a, X: b, result: c)” (well, except for “minuend”, you nerd you), while if there’s no label I reasonably assume the order matches the math.

I was vacillating over label names for commutative operations, but I agree, they don't offer any benefit and make the API cleaner. So, those are gone.
With regard to subtract, the guidelines state "Prefer method and function names that make use sites form grammatical English phrases." - and that's exactly what from does (and the by for division). So, I'd like to keep those.
That said, having vectorA be the parameter for b in the pseudocode is potentially confusing, so I've rectified that. For example, for vDSP_vsub, Parameter vectorA: the ainc[i] = a[i] - b[I]``.

With regard to subtract, the guidelines state "Prefer method and function names that make use sites form grammatical English phrases." - and that's exactly what from does (and the by for division). So, I'd like to keep those.

Yes, by all means we should prefer grammatical phrases, but not at the cost of misuse. An API that reverses a - b to read subtract(b, from: a) will get used incorrectly.

With regard to subtract, the guidelines state "Prefer method and function names that make use sites form grammatical English phrases." - and that's exactly what from does (and the by for division). So, I'd like to keep those.

Yes, by all means we should prefer grammatical phrases, but not at the cost of misuse. An API that reverses a - b to read subtract(b, from: a) will get used incorrectly.

OK, so what are your feelings on subtract(_ lhs, _ rhs)? I can implement the same naming for all functions.

Yes, by all means we should prefer grammatical phrases, but not at the cost of misuse. An API that reverses a - b to read subtract(b, from: a) will get used incorrectly.

OK, so what are your feelings on subtract(_ lhs, _ rhs)? I can implement the same naming for all functions.

I think it's reasonable.
To be clear, my only worry and objection is to reversing the order of the arguments insubtract(_:from:). I have no problem with either divide(_:_:) or divide(_:by:), so if others prefer the latter then I suppose we can consider subtract(from:_:).

Yes, by all means we should prefer grammatical phrases, but not at the cost of misuse. An API that reverses a - b to read subtract(b, from: a) will get used incorrectly.

OK, so what are your feelings on subtract(_ lhs, _ rhs)? I can implement the same naming for all functions.

I think it's reasonable.
To be clear, my only worry and objection is to reversing the order of the arguments insubtract(_:from:). I have no problem with either divide(_:_:) or divide(_:by:), so if others prefer the latter then I suppose we can consider subtract(from:_:).

I've made these functions mirror their pseudo-code, for example:
   /// - Parameter vectorA: the `a` in `c[i] = a[i] - b[i]`.
    /// - Parameter vectorB: the `b` in `c[i] = a[i] - b[i]`.
    /// - Parameter result: The `c` in `c[i] = a[i] - b[i]`.

    public static func subtract<T, U, V>(_ vectorA: U,
                                         _ vectorB: T,
                                         result: inout V)

It's interesting to note that some operations have their parameters reversed in the original Accelerate implementation (for example, vsub)


Default Hotkey - PowerToys Run

Microsoft PowerToys version
0.65.0
Installation method
GitHub
Running as admin
None
Area(s) with issue?
PowerToys Run
Steps to reproduce
Very minor, but the default hotkey Alt+Spacebar is already used to open a context menu in Windows applications. It opens the window that allows you to Move/Minimize/Resize.... windows.
I suggest using an alternate default hotkey that does not overlap with an already existing Windows hotkey.
✔ Expected Behavior
All default hotkeys to not overlap with basic WIndows hotkeys which includes things like Alt+Tab, Alt+Space, Alt+F4 etc...
❌ Actual Behavior
Installing and using this application causes a hotkey conflict and Alt+Space will no longer open a context menu for windows, it will instead Launch PowerToys Run.
Other Software
No response

I just found that you can press and hold one of the Alt keys, press and release the other Alt key, then press Space to bring up the system Alt+Space menu without invoking PowerToys Run, just like what you can do to bring up the old XP-style Alt+Tab switcher in newer versions of Windows. (assuming that you do not enable the "use centralized keyboard hook" option)
Finding a key combo that does not overlap with the hotkeys used by Windows and other programs, yet is still easy to press, might not be that easy. Key combos without the Windows logo key are more likely to conflict with application hotkeys, so most of the default hotkeys in PowerToys choose to include the Windows key. However, most of the "Windows key + a single key" combinations are used by Windows itself (see the "Windows logo key keyboard shortcuts" section in Keyboard shortcuts in Windows), so PowerToys has to use three-key combinations like "Win+Ctrl+T" to avoid conflicts. (Having said that, the Screen Ruler utility chooses to use Win+Shift+M, which is already used by Windows to undo "minimize all windows (Win+M)")
PowerToys Run needs an easy-to-press key combo so that users can launch it quickly. So, the developers chose to "redefine" a two-key combination, Alt+Space. This might not be a good decision, but:

Alt+Space is easy to press.
It's been a system hotkey for a long time, so no other program would choose to use Alt+Space as its own hotkey.
As a system hotkey, Alt+Space is not frequently used by most users (maybe). The menu it brings up only allows users to restore/minimize/maximize the window, or to move/resize the window with keyboard keys. But users can also close the window with Alt+F4, and restore/minimize/maximize the window with Win+Arrow keys. As for moving/resizing, most users would use a mouse.

I'm still using Alt+Space to minimize windows, because Win+DownArrow cannot minimize a window without restoring it first. So I agree that it would be better if PowerToys Run could choose another hotkey by default.
In Windows 10 and 11, Win+S and Win+Q do the same thing (launches Windows Search). You can assign one of them to PowerToys Run and still have a way to launch Windows Search. But I guess using one of those hotkeys by default might still be a bad idea.

Appreciate the detailed response. I haven't fully explored PowerToys yet, but I understand the decision here.

Yeah I agree with the comment and I always advise Win+Q too.

/dup #3838


failing test with python3.12rc1

Describe your issue
Noticed this when looking at 3.12-dev CI runs on #5620
pstats_profile_test and pstats_profile_test_pyfunc are failing on 3.12. This is the source. Maybe the expected profiling output has changed for 3.12 due to inlining comprehensions.
That seems to be the only failing test on HEAD with 3.12rc1.

Duplicate of #5470


There must have a react version of every component

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
It is difficult for a user to modify the copied code everytime in a react file. So if we can give that user a react version of that bootstrap code, the productive time will be increased for that user. So please assign it to me @twbs-grunt
Motivation and context
I faced difficulties myself while learning react with bootstrap. Here I get the motivation to improve this thing by contributing.
Before fixing code the navbar inside a react app:

After fixing code the navbar preview inside a react app:

Here is the code URL :
https://codepen.io/rancho2002/pen/rNvRGro
And this type of change is necessary for all the other components.

@samadpls pls look into this issue and assign it to me

Hi @julien-deramond pls check this isse

Hi @Rancho2002 please check the documentation. Among the popular options, you can check React Bootstrap.

Hi @Rancho2002 please check the documentation. Among the popular options, you can check React Bootstrap.

Sorry, I have not notice this documentation earlier. Thanks for your reply.


Terragrunt run-all destroy attempts to delete "dependent" configurations outside the folder on which the destroy is occuring.

If I have a folder structure as follows:
root--------folder1
|------folder2------folder3
| -----folder5        |-----folder4
And I run a run-all destroy against folder2, I would expect the configuration state files to be removed for folder2, folder3 and folder4, as 3 and 4 are nest under folder2. I would not expect folder1 to be deleted if HCL files in any of the 3 folders being deleted depend upon the output of folder1's configuration, but Terragrunt run-all -destroy does this today. Can the code be modified so that only the parent folder on which the "destroy" is being run and any of its children be deleted, but not any dependent Terraform configurations?

Hi,
will be helpful to provide an example where this issue happens - from the provided structure it is not clear which dependencies are used where

If root contains folder1 and folder2 and I do a run-all with a destroy flag against folder2, folder1 will be destroyed if any HCL files in folder2 have a dependency on folder1. In other words, I am trying to confine the destroy of folder2. If there are HCL files within folder2 that have dependencies outside of folder2, I DO NOT want those dependent state files to be destroyed.

My previous two post are not correct. I am still learning Terragrunt, so it difficult to articulate what I am attempting to say, but I think I have a better way of phrasing this now. I believe when you do a "run-all" against an HCL file, it will run and create state for the module associated with the HCL AND any HCL file dependent upon that "parent" HCL file. Is that correct?
If so, when I run "run-all" with the "destroy" flag against the same "parent" HCL file, I want the Terraform state of that file and all dependent HCL files destroyed, BUT NOT the Terraform state files on which the "parent" HCL file is dependent. Does this make more sense?
Sorry for the confusion and thanks for your time.

Hey @kansberry-kr ,
Sorry we let this PR go stale. I think the root cause is that you need to include --terragrunt-strict-include to make sure that you only include the items you explicitly intend to. I think we can improve our documentation to call this out, and provide better default behavior for run-all destroy so that it's not as surprising. Let me know if using that flag helps. You might need to add some extra --terragrunt-include-dir flags to explicitly pull in what you're trying to delete once you do that.

Also @kansberry-kr ,
If you need help with the terms used in Terragrunt, take a look at the following docs we added recently:
https://terragrunt.gruntwork.io/docs/getting-started/terminology/
We are trying to make it easier to know how to talk about Terragrunt early on when using it, so any feedback on things you feel like you still can't describe would be helpful so that we can update those docs.


massively upgraded the readme to include my opinion on candy

I do like candy.  I'd like your service more if it delivered candy.

Candy is the best :+1:

This pull request was to test ReviewNinja, and will now be closed.


Gitlab step issue with the new release

safety version: 2.1.0
Python version: 3.8
Operating System: Gitlab

Description
It seems like there is an issue with the new release. This is how my Gitlab CI looks like which prior to the latest version(2.1.) was working just fine.
  script:
    - cd $RELATIVE_DIR
    - pip install safety
    - poetry export -f requirements.txt --output requirements.txt
    - safety check -r requirements.txt -o text
    - safety check -r requirements.txt

For some reason, I'm getting this error message now:
$ safety check -r requirements.txt -o text
Unhandled exception happened: [Errno 2] No such file or directory: 'git'

I can confirm that the same error happens in Bitbucket CI. Downgrading safety to v2.0.0 fixes the issue temporarily for me.

Safety 2.1.1 is out and published with this fix!

Thank you for the quick reaction, guys.


Reduce scatter produces incorrect output in some cases

This configuration is used in TG Llama and results in PCC issue when running single link or hang when running multi-chip:
            (1, 1, 32, 320),  // output tensor shape
            (32, 32),           // output shard shape
            ttnn.CoreRangeSet({ttnn.CoreRange(ttnn.CoreCoord(0, 0), ttnn.CoreCoord(4, 1))}),  // shard grid

workaround available. Hit hang regressions. Fixed those, hit new PCC issues which need to be investigated by my priorities are currently elsewhere to bring up the EDM fabric for TG Llama


Sketch for supporting Swift Testing

An initial look at what support for Swift Testing could look like. Without this change, tests always pass because XCTFail does not fail Swift Testing tests.
Known issues:

Snapshots are not saved as XCTAttachments when tests fail

Hi @DavidBrunow, thanks for starting this!
However, there is still a lot more work to be done. Currently we use test observers in a few spots (e.g. here and here), and currently swift-testing has no concept whatsoever of test observers. There are plans for it, but in the meantime we are going to have to approximate that concept with "custom execution" traits, which are currently an @_spi experimental feature of swift-testing.
We are also deep in the process of updating all of our libraries to be swift-testing compliant, and we have some really exciting things to share soon. But for the time being I think there's too many additional things to think about before we can accept a PR like this. How do you feel about closing this PR and starting a discussion instead?

Hi @DavidBrunow, thanks for starting this!
However, there is still a lot more work to be done. Currently we use test observers in a few spots (e.g. here and here), and currently swift-testing has no concept whatsoever of test observers. There are plans for it, but in the meantime we are going to have to approximate that concept with "custom execution" traits, which are currently an @_spi experimental feature of swift-testing.
We are also deep in the process of updating all of our libraries to be swift-testing compliant, and we have some really exciting things to share soon. But for the time being I think there's too many additional things to think about before we can accept a PR like this. How do you feel about closing this PR and starting a discussion instead?

Done! Sorry for the noise here – I regularly forget about the Discussions feature.


[MINOR][DOCS] Fix broken ML paper links

What changes were proposed in this pull request?
There are several links to ML papers that are now broken. This change updates the links to targets that still exist.
Why are the changes needed?
Broken links are annoying.
Does this PR introduce any user-facing change?
Yes, it fixes user-facing documentation.
How was this patch tested?
I built the docs successfully.
Was this patch authored or co-authored using generative AI tooling?
No.

Merged to master.


(test) Fix test_agent_controller.py mock exceptions

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
The test_agent_controller.py unit test generated several async-related errors due to missing close() statements for the controller object.

Give a summary of what the PR does, explaining any non-trivial design decisions

Added controller.close() to tests.
In agent_controller.py itself prevent an AttributeError within these tests.

Other references
These unit tests were introduce with #3357

Without the "close()" this would appear in the unit test:
task: <Task pending name='Task-16' coro=<AgentController._start_step_loop() running at /mnt/d/github/OpenDevin/openhands/controller/agent_controller.py:154> wait_for=<Future pending cb=[Task.task_wakeup()]>>```

With the fix in the test script itself, the change in the agent_controller.py is no longer needed, so reverted that.
This should be good now.


Issue with LIST -a /test

A client of ours noticed that Netbeans wasn't working properly with our FTP server but worked fine with PureFTPd and vsftpd. Here's a sample of the work flow done through lsftp:
lftp guppy@localhost:~> cd test
cd ok, cwd=/test
lftp guppy@localhost:/test> ls -a
-rw-rw-rw-   1 ftpuser  ftpuser      1939 Nov 22 18:18 utils.pm
lftp guppy@localhost:/test> ls -a /test
lftp guppy@localhost:/test>
For the sake of this issue, our Netbeans project is set to use / as it's root. The first thing it does is a LIST -a / (which fails as well, same issue), I put a hack in place to strip "-a /" and now I can get a file listing, if I click on one of the directories that it showed me, the first thing it does is a CWD to that directory and the LIST -a /directory.
This works fine in PureFTPd and vsftpd but not in pyftpdlib. I'm not sure what the standard is but given two very popular FTP servers support it, I think pyftpdlib should as well.

Yes, this should definitively be handled by pyftpdlib. I don't have time to work on a patch.
If you want, feel free to submit a pull request.
This is where it is supposed to be done:
https://github.com/giampaolo/pyftpdlib/blob/6165a40fd4f7c7cd2d549dbb816b3208091ffdff/pyftpdlib/handlers.py#L1465
...as you see, the code already handles the case where uncompliant clients specify "-a", "-l" etc. but not the case where a path occurs after "-a" / "-l" (e.g. LIST -l /foo/bar).


Added sections to logger from external modules

Add ability for other modules/plugins to call logging functions to add sections to the main json botlog.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read CONTRIBUTING.md
[x] I fully understand Github Flow.
[x] My code adheres to the code style of this project.
[x] I have updated the documentation in /docs if I have changed the config, arguments, logic in how the bot works, or anything that understandably needs a documentation change.
[x] I have updated the config file accordingly if my change requires a new configuration setting or changes an existing one.
[x] I have tested the bot with no issues for 24 continuous hours. If issues were experienced, they have been patched and tested again.

Looks good.


M1 mac unittests seem to be flaky

🐛 Describe the bug
https://github.com/pytorch/vision/pull/7448 fails
2023-03-23T16:22:00.7959200Z FAILED test/test_transforms_v2_functional.py::TestKernels::test_against_reference[affine_bounding_box-137] - AssertionError: Tensor-likes are not equal!

but I don't see how I could have caused this.
https://github.com/pytorch/vision/actions/runs/4502612277 on main failed with
2023-03-23T16:23:55.8792360Z FAILED test/test_transforms_v2_consistency.py::test_call_consistency[ElasticTransform-080] - AssertionError: Tensor image consistency check failed with:

can look at rest of failures at https://github.com/pytorch/vision/actions/workflows/test-m1.yml
Versions
master

That is most likely not on you. If you look at the HUD, our CI (build and test) is flaky AF right now. We haven't had time to fix that yet.


Catching errors in cross-canister calls

Do we need to handle catching errors with cross-canister calls? Ah yes...each call has a result. I am not exposing that result at all right now, I think I need to create a result type for all of the cross-canister or asynchronous APIs.

Look into how Motoko does this, do they have some kind of result type for their calls?


Added Redis password to env variables

Take a look at the changes when you have a chance. It SHOULD pull the rpass from env if supplied.


Align text in input

Align text in input

left or right

Oh interesting... working on it.

It's ready @ChemaBautista
You can use the attribute "align" with "left" or "right" for move the text in input
Any other inconvenience or comment do not hesitate to tell me.


unable to return property as a multiple choice option

Whilst using the Prompt with multi-choice feature, i am unable to call properties previously set as options. The value is not being returned.
Steps to reproduce the behaviour:

create a multiple choice response. text: I have found several products on your account. Which one are you interested in setting up a repayment plan for?
create user input choice using the simple choice feature. choice should be: ${conversation.productCurrent[0]} and ${conversation.productCurrent[1]} (note these values were set at the start of the dialog. ${conversation.productCurrent[0]} =="Mobile" ${conversation.productCurrent[1]} == "Broadband"
test it
see error (screenshots attached)

Excepted behaviour:
able to call back the properties as a user input

being able to add multiple different conditions to one value

Hi @jessthorne This is a limitation with choice prompts. Specifically with Simple or Structured choices.
What you need to do is use an expression. Simply, you can just call that array such as:
=${conversation.productCurrent}
Example:

You can of course be more dynamic/thorough with it and put it in a template if needed.

Hi, thank you for your response. when i follow this pattern i get a warning (see attached)

Looks like your property is just text (test). Needs to be an array.

        {
          "$kind": "Microsoft.SetProperty",
          "$designer": {
            "id": "KM6BUY"
          },
          "value": [
            "Mobile",
            "Broadband"
          ],
          "property": "conversation.productCurrent"
        },

@jessthorne I'm closing this as it seems that it answers your question/situation. If not, please le us know.

Thank you - is it possible to have 2 options calling the stored property and one being text?
e.g.

Thanks!

Yes. You would need to use templates and adaptive expression functions to accomplish that.

@dmvtech i am unable to make ${conversation.MSISDN.product_list} appear in different buttons, is this possible?


Regarding add stm32 l496rgt3

Issue Type: Feature Request
i want interface and debug stm32 l496rgt3 so this board is not added on platformIO please add this boards or give me step how to add custom  boards on PlatformIO
VS Code version: Code 1.35.1 (c7d83e57cd18f18026a8162d042843bda1bcf21f, 2019-06-12T15:16:14.389Z)
OS version: Windows_NT ia32 10.0.17763

Please file issue against the corresponding PlatformIO extension


Updating gallery items reset the drag&drop zones inside

Whenever I update the collection that is the item source of the gallery wherein the drag&drop zones are found, the drag&drop items are flung back to the master zone. Is this normal behaviour? And if so, how can I prevent this?
Thanks!

Found out you simply have to patch the items (in the collection you used for it) after the OnDrop event and set their Zone to the DropZoneId of the current zone they are in.
Like this:
`ForAll(
Filter(DragDropControl.CurrentItems, HasMovedZone=true) As DragDropItem,
// Update local collection
Patch(collection,
    LookUp(collection, 'id' = DragDropItem.ItemId),
    {
        Zone: DragDropItem.DropZoneId
    }
);

)`
A gallery reset will cause them to fall back on the zone assigned in the collection (their starting zone basically).


Automatically annotate file paths if dynamicPaths include JS modules or is a function

This is a bit messy, especially the leaky abstraction of the config file, but it would fix the problem.
Some alternate approaches I thought about while writing this:

Unconditionally enable file annotations

This is simpler, but creates a larger diff and is unneeded on many data apps.

Enable annotation on dynamicPath modules and all of their transitive dependencies.

This would be a lot harder for me, and I'm not sure if it would be robust enough.

Somehow force that file annotations are enabled, possibly by rebuilding JS files, when deploying.

Haven't quite figured this one out yet

Reject un-annotated builds on the server side if they seem required.

Unconditionally enable file annotations sounds good to me.

Reject un-annotated builds on the server side if they seem required.

I feel like this is the way to go. Even with this PR, old releases of Framework will still not work, so we’d need to enforce that a minimum version of Framework is used. So why not more directly enforce that Framework was built with path annotation enabled? (I don’t recall if we stash some metadata when building, but we certainly could if we aren’t already.)


Label per language

From @olivierbuffon on January 11, 2018 15:15
You already create new PRs with the dependencies label, which is nice! But in addition I would suggest to add another label that would match the language behind those dependencies (e.g: ruby, javascript).
This would really help us to differentiate every PR (for now we're doing this operation manually which is a bit painful)
Copied from original issue: dependabot/feedback#74

From @olivierbuffon on January 16, 2018 12:44
@greysteil that's smart but unfortunately not covering my case here since we're using multiple languages in the same repo (monolithic app ruby + javascript) so this mean I'll need multiple labels. Am I wrong?

@olivierbuffon - apologies for the slow reply on this one. Have you already tried removing the dependencies label that Dependabot places on PRs and replacing it with your own (e.g., dependendencies:ruby)? If you do that then Dependabot will ask you if it should always use that label for the associated language (for the given repo).
We don't currently support doing the above for handling additional labels, because I didn't want to make Dependabot too noisy, but I'll have a think on whether there's a slick way we could.

From @olivierbuffon on January 16, 2018 12:46
Oh ok nice, well I'll give it a try! Thanks for your help :)

Dependabot will only adjust the label for PRs of the same language, so it should automatically start labelling Ruby updates and JS updates differently (for example).

Just updated the logic so Dependabot can handle creating multiple labels for you by default. If you say @dependabot use these labels on a PR with multiple labels then it will start using them in future for PRs to that repo, for that language.
Thanks for the feedback!

From @olivierbuffon on January 22, 2018 17:9
Amazing thx @greysteil ! :)


launch the Galaxy instance on AWS failure with GLV

FAILURE
Create appliance task failed: An error occurred (AccessDenied) when calling the GetRole operation: User: arn:aws:iam::101035347665:user/Galaxy_Cloudman is not authorized to perform: iam:GetRole on resource: role cearch-cloudman-20-20-09-27t07-09-cm2-kube-role

Please refer to this issue for info: https://github.com/galaxyproject/cloudlaunch/issues/198#issuecomment-655128278


Gracefully exit when ghci exits

Note that this won't gracefully exit until a reload is triggered, though.

Current dependencies on/for this PR:

main

PR #73

PR #74

PR #75

PR #76

PR #77

PR #78

PR #86

PR #92

@Gabriella439 It's in the Linear ticket. Matt hit an OOM or something:
[6641 of 6641] Compiling TestMain         ( test/TestMain.hs, interpreted ) [EnumsSpecTest changed]
Ok, 6641 modules loaded.

Error: cabal: repl failed for lib:test-dev from mwb-0. The build process was
killed (i.e. SIGKILL). The typical reason for this is that there is not enough
memory available (e.g. the OS killed a process using lots of memory).

• Adding new modules to ghci:
  • /home/matt/Projects/.../Handler.hs

ErrorHook { error: Handler { ctx: "action worker", err: "  \u{1b}[31m×\u{1b}[0m Broken pipe (os error 32)\n" }, critical: OnceCell(Uninit) }

ah yeah in that case you probably wouldnt be able to recover by restarting


Failed to remap ReplayMod with StackOverflowError

Mod Name
ReplayMod
Mod Homepage
https://www.replaymod.com
Minecraft version
1.20.1 (LTS)
Describe the bug
Failed to launch the client with ReplayMod and connector installed, failing with StackOverflowError
Steps to reproduce

Install FFAPI, Connector and ReplayMod (all are latest version at the moment of writing this issue post), with Forge 47.1.3 as README describes.
Start the client
Client crashes with StackOverflowError, see logs for more.

Logs
https://mclo.gs/umwL4PB
Additional context
ReplayMod version 2.6.15 for MC 1.20.1 has no failure with Connector but latest version (this post uses 2.6.20) does.

duplicate of #1590 but leaving this open as I think it still make sense to regard it as a bug.

As our LTS support target, 1.20.1 now only receives critical fixes related to Connector bugs. Please upgrade to the latest version for mod compatibility support.

Just thinking if this isn't a connector bug? as its remapper raises the issue.


Combine Awin Tap Variants

Migrated from GitLab: https://gitlab.com/meltano/hub/-/issues/228
Originally created by @pnadolny13 on 2022-04-06 13:55:44

Based on https://gitlab.com/meltano/hub/-/merge_requests/229#note_901717955
There are 3 different Awin taps:

https://github.com/ideavateltd/tap-awin - uses a deprecated API
https://github.com/Horze-International/tap-awin-advertiser - uses the advertiser API
https://github.com/gthesheep/tap-awin-publisher - uses the publisher API and the SDK, might eventually also use the advertiser API

We can combine these somehow, maybe removing the raw tap-awin and making that a variant of one of the others. Or put all of them under the tap-awin namespace and make tap-awin-publisher the default.

View 2 previous comments from the original issue on GitLab


Update leaflet.directive.wrapper.d.ts

Fixed error for Ionic "Cannot find namespace 'L'".

I'm going to make this change in the source. The issue is that the getMap method needs to explicitly return L.Map, and then I have to add an import of leaflet.

see pr https://github.com/Asymmetrik/ngx-leaflet/pull/84

Resolved in #84 and deployed as version 2.4.1. Thanks for letting me know about the issue!


Possible to edit without showing markdown ?

It would be great to have a mode, like preview - but with editing.
Some of my users are non-technical, so I could show them a version of the editor that doesn't have the markdown available.

I'm not sure this is the right editor for that but I will leave this ticket open for others to discuss it.