VSCode tries to use wrong shell path with no way to change it

Does this issue occur when all extensions are disabled?: Yes

Hello! Now - gonna preface this that I'm 99% sure this is something I've done wrong, but I honestly don't even know where to start with this one. At some point or other I set my shell explicitly to a fish version in homebrew (incorrectly), but despite changing that back anywhere I can possibly think of and even doing a full grep of my home directory looking for any mention of this string, I still can't find what's causing it.
The main deal is that VSCode is refusing to use any other shell than this mysterious fish instance that no longer exists and doesn't give me any way of changing it - there's multiple preferences that supposedly do this even mentioned in the docs, but they show up with a squiggly line on mine and don't do anything:

... and the quick option "Terminal: Select Default Shell", which is just entirely missing:

I'm not really sure where to go from here. It's probably something pretty silly I've done, but I'm also totally lost on where those options are at that are even mentioned in the docs.

VS Code Version: Version: 1.86.2
OS Version: Darwin arm64 22.6.0

Steps to Reproduce:

Launch Visual Studio Code

Presented with error:

Launching a terminal also fails:

I also tried completely wiping my ~/.vscode, and the Code folder in Application Support.

@aiday-mar This doesn't seem related to the Python extension, hence re-assigning.

We pull in the default shell via $SHELL which is controlled via chsh. You need to fix this up outside of VS Code or alternatively set a default profile explicitly (creating it if necessary, see https://code.visualstudio.com/docs/terminal/profiles)

We pull in the default shell via $SHELL which is controlled via chsh. You need to fix this up outside of VS Code or alternatively set a default profile explicitly (creating it if necessary, see https://code.visualstudio.com/docs/terminal/profiles)

The issue is that $SHELL already points to the correct shell, and I already have it set correctly via chsh:

(chsh output without any arguments)
And /opt/homebrew/bin/fish points to the correct version:

I have no idea where 3.6.1 is coming from, nor the hardcoded string pointing to that version.
I have now been able to now manually add fish as a profile, but the constant errors will not stop pointing to this erroneous path, which isn't referenced anywhere I can find. I understand that this is very likely user error, but I have nothing left to go off, nor does vscode offer any way to at least suppress these errors - though that would not be my preferred solution.

Unable to resolve shell environment is because we launch $SHELL when VS Code starts up in order to source the user's development/terminal environment. Unfortunately this has to be an issue on your end as we don't cache this and we can't really debug it effectively for you. Here is the code that determines where that shell is pulled from if that's helpful:
https://github.com/microsoft/vscode/blob/5e9e54773a6924b88d64dd61c64142bf355a74fb/src/vs/base/node/shell.ts#L29-L61
It's a good thing that you can't suppress the error as some things won't work properly until you fix this problem.


no error on GSCFile if bucket does not exist

When bucket in passed path does not exists, GSCFile fails on close (or when buffer is flushed), with a generic error like
Exception KeyError: ('location',) in <bound method GCSFile.__del__ of <GCSFile new_bucket/test>> ignored
GSCFile.__init__ should check on bucket existence and either create (preferred) or explicitly error out e.g. Bucket xxx does not exist
First option preferred to minimize pre-processing but requires parameters for storage class & location. Although could be defined as defaults.
Btw - do not use paranthesis in folder name, you cannot browse it in Google Console (bug reported)

Note error only shows up after suggested code reorder by @martindurant on issue #31


Add ViewComponent::Collection to @param of #render_inline

Summary
I found out my IDE (Intellij IDEA) tells me my code is not compatible with #render_inline when I pass an instance of ViewComponent::Collection. As far as I see, #render_inline seems to allow us to receive an instance of ViewComponent::Collection because it defines #render_in method internally.
So, I want to add ViewComponent::Collection to @param of #render_inline.
Other Information
I updated docs/CHANGELOG.md and docs/index.md, following Submitting a pull request.

@yykamei thank you for your contribution ❤


README: False claims about image's inclusion of self-signed cert?

Docker commands that you execute
Per https://github.com/jenkinsci/docker/blob/master/README.md#passing-jenkins-launcher-parameters :
FROM jenkins/jenkins:lts

COPY https.pem /var/lib/jenkins/cert
COPY https.key /var/lib/jenkins/pk
ENV JENKINS_OPTS --httpPort=-1 --httpsPort=8083 --httpsCertificate=/var/lib/jenkins/cert --httpsPrivateKey=/var/lib/jenkins/pk
EXPOSE 8083

Actual result
$ docker build -t jenkins_jaj ./
Sending build context to Docker daemon  3.584kB
Step 1/5 : FROM jenkins/jenkins:lts
 ---> a15183f6519b
Step 2/5 : COPY https.pem /var/lib/jenkins/cert
COPY failed: stat /var/lib/docker/tmp/docker-builder128658152/https.pem: no such file or directory

$ docker run --rm --user root jenkins/jenkins:lts find / -iname 'https.*'
$

Expected outcome
The README suggests that self-signed certs are available in the image, but my results suggest otherwise.

N/A
Output of docker version
Docker version 18.03.1-ce, build 9ee9f40
Other relevant information
$ docker image ls | grep lts
jenkins/jenkins                                                       lts                 a15183f6519b        10 days ago         700MB

it says

The following sample Dockerfile...

The following sample Dockerfile...

What does that mean? Does that somehow suggest because it's a sample Dockerfile that it will not work, or does it suggest because it is a sample Dockerfile, it does not work because it requires more docker directives?

I recommend throwing that snippet out of the README.md unless it works. Furthermore, I'm not going to put any more effort into trying to debug this. Rather, some redundant easier approaches can be done, such as using a light weight reverse proxy, and putting a certificate on it.

For reference, the official Docker documentation about the Dockerfile'sCOPY directive states that the first (non flag) argument (eg. the https.key string for instance) is a file expected to be in the Docker build context.
The error message on this issue shows that there is no file in the build context of the reporter.
Closing this issue as there is no error in the Jenkins documentation, it's an old issue with no activity and it is a specific Docker behavior.
Feel free to reopen with reproduction example, or a documentation suggestion if you feel like there is still a problem.


Error attempting to install on AWS Linux

Trying to install nodegit on AWS Linux gives the following error:
[nodegit] Failed to install prebuilt binary:
{ [Error: Command failed: node-pre-gyp ERR! install error
node-pre-gyp ERR! stack Error: 403 status code downloading tarball https://nodegit.s3.amazonaws.com/nodegit/nodegit/nodegit-v0.11.5-node-v11-linux-x64.tar.gz
node-pre-gyp ERR! stack     at Request.<anonymous> (/home/ec2-user/testcode/node_modules/nodegit/node_modules/node-pre-gyp/lib/install.js:101:37)
node-pre-gyp ERR! stack     at Request.emit (events.js:117:20)
node-pre-gyp ERR! stack     at Request.onRequestResponse (/home/ec2-user/testcode/node_modules/nodegit/node_modules/node-pre-gyp/node_modules/request/request.js:952:10)
node-pre-gyp ERR! stack     at ClientRequest.emit (events.js:95:17)
node-pre-gyp ERR! stack     at HTTPParser.parserOnIncomingClient [as onIncoming] (http.js:1744:21)
node-pre-gyp ERR! stack     at HTTPParser.parserOnHeadersComplete [as onHeadersComplete] (http.js:152:23)
node-pre-gyp ERR! stack     at CleartextStream.socketOnData [as ondata] (http.js:1639:20)
node-pre-gyp ERR! stack     at CleartextStream.read [as _read] (tls.js:514:12)
node-pre-gyp ERR! stack     at CleartextStream.Readable.read (_stream_readable.js:341:10)
node-pre-gyp ERR! stack     at EncryptedStream.write [as _write] (tls.js:369:25)
node-pre-gyp ERR! System Linux 4.1.17-22.30.amzn1.x86_64
node-pre-gyp ERR! command "node" "/home/ec2-user/testcode/node_modules/nodegit/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build=false"
node-pre-gyp ERR! cwd /home/ec2-user/testcode/node_modules/nodegit
node-pre-gyp ERR! node -v v0.10.42
node-pre-gyp ERR! node-pre-gyp -v v0.6.21
node-pre-gyp ERR! not ok

Any advice on how to resolve this would be greatly appreciated.

We don't support node v10. Please upgrade and try again.

Shame, I was looking to use it with AWS Lambda and that is only running on version v0.10.36, so even earlier.

@johnhaley81 - is there a version of nodegit that did support node v0.10?

To answer my own question, and to help anyone else who might run across this - it looks like v0.4.0 seems to work on Node v0.10.


Erro when trying to run CVAT: Could not check authorization on the server Error: Request failed with status code 502. "Bad Gateway".

My actions before raising this issue

[yes] Read/searched the docs
[yes] Searched past issues
I've seen this issue on multiple ocasion, but it seems to be related to multiple separate bugs/missconfigurations, often described as solved / with suggestion to create a separate ticket.

Expected Behaviour
Normal login.
Current Behaviour
Error when trying to run CVAT:
localhost:8080 shows:
Could not check authorization on the server Error: Request failed with status code 502. "Bad Gateway".
http://localhost:8080/auth/login shows:
Could not check authorization on the server Open the Browser Console to get details
Steps to Reproduce (for bugs)

git clone https://github.com/opencv/cvat
cd cvat
docker-compose up -d
open localhost:8080 in chrome browser

Context
I used to have a running cvat instance, but a did git pull in the repository due to different problem (unable to create task from backup). Then I started to get this error.
I issued
rm -rf cvat
docker-compose down
docker rm -f $(docker ps -a -q)
docker volume rm $(docker volume ls -q)

before cloning new CVAT to make sure I have a clean version
Your Environment

Git hash commit (git log -1):

Author: Anastasia Yasakova<EMAIL_ADDRESS>Date:   Wed Nov 16 13:07:59 2022 +0200

    Fix: visibility and ignored information fail to be loaded (MOT dataset format) (#5270)

Docker version docker version (e.g. Docker 17.0.05):
20.10.18
Are you using Docker Swarm or Kubernetes?
Operating System and version (e.g. Linux, Windows, MacOS):
Ubuntu 20.04.5 LTS
Other diagnostic information / logs (I've used docker logs cvat_server because cvat is not there):
https://pastebin.com/UsMu0gxQ
My chrome console shows:
https://pastebin.com/mzPTRsrh

@Huxwell , let's try to investigate. CVAT server needs time to start up. For many seconds in the beginning it runs some service code.  For example, prepare the database. While it is in the state, it returns 502 HTTP error. After 30 seconds or so, you should be able to authenticate yourself.
Could you please run docker logs cvat_server and post output as a file here? I believe together we will find an answer.
And thanks for the report. We will try to make CVAT more stable in the next release.

cvat_docker_logs.txt
The error appears even without me doing anything - just entering localhost:8080 is enough.
Waiting for a few minutes unfortunatelly doesn't help - when I try to login, I get another similar error.

@Huxwell Hi, seems you are using old cvat images that you have locally, try to update with docker compose pull or build yourself with docker compose -f docker-compose.yml -f docker-compose.dev.yml build

After docker-compose pull I am able to sucessfully login!
I am supprised that following commands didn't trigger pulling new images before:
docker rm -f $(docker ps -a -q)
docker volume rm $(docker volume ls -q)

Thanks for helping me out!

i have same question ，but when i run docker-compose pull ， the progress can't run
i use mac apple m2 ，please help me


Deploy parse server example to Digital Ocean

I successfully deployed parse server example to heroku and access it with parse dashboard.
Now I want to deploy it to Digital Ocean but I 'm not getting any clue that how to achieve this. I already spent hours on this but didn't find anything enough clear to follow.
Advise to towards right direction

Digital Ocean wrote a guide you can follow: https://www.digitalocean.com/community/tutorials/how-to-run-parse-server-on-ubuntu-14-04


enable use of ’sbt publish local’

I could not find the public repo for the plugin, so as mitigation I’m using an sbt ’publish local’
I assume you want to align the naming in sbt plugin config and sbtPluginExtra in SbtJgivenScalatestReporterPlugin.scala:13, otherwise you get an sbt error.
addSbtPlugin("fr.fpe" % "sbt-jgiven-scalatest-reporter" % "0.1-SNAPSHOT")

If any issue please let me know.
PS: thanks for your plugin, great to get nice JGiven reports with scalatest.

Thank you for this contribution @jlcanela 👍

Thank you for this contribution @jlcanela 👍


Extractor:JSONDecodeError

Summary
While extracting chat data, sometimes JSONDecodeError occurs and abort.

Fix
Fixed at v<IP_ADDRESS>.
Implemented retry when JSONDecodeError has occurred. (3 seconds per time, up to 3 times.)


onboard new repo.

What this PR does / why we need it:
onborad new repo: https://github.com/IBM/multicloud-application-monitoring-dashboard
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Specify your PR reviewers:

/cc @gyliu513
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

/lgtm


Redo the quickstart guide to odo 3.0.0

What type of PR is this:

/kind documentation
What does this PR do / why we need it:
This PR adds examples to the odo quickstart guide in order to go into
details with the odo init, odo dev and odo deploy commands.
Which issue(s) this PR fixes:

N/A, part of multiple PR's
PR acceptance criteria:

[X] Unit test

[X] Integration test

[X] Documentation

How to test changes / Special notes to the reviewer:

This is up for a PRELIMINARY review!
I'm still adding the other examples, but I'd like to get some feedback on the Node.js format / how it is.
Thanks!

Updated! Thanks @feloy

Ready for one last lgtm / approval as I've removed the sections about .Net and Springboot now!

/lgtm
(since we only need 1 approval for docs)

/retest

/override Kubernetes Integration Tests/Kubernetes Integration Tests
/override OpenShift Integration tests/OpenShift Integration tests
Doc only


Add new change types.

cc @dstufft @JordonPhillips @jamesls @kyleknap

Codecov Report

Merging #1153 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1153   +/-   ##
========================================
  Coverage    97.95%   97.95%
========================================
  Files           45       45
  Lines         7093     7093
========================================
  Hits          6948     6948
  Misses         145      145

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7219d...994c4e9. Read the comment docs.

Looks good. Go ahead and use this for the rest of your PR's and those should be good as well.


[0.12.0] Processing description.ext issue

Repository: https://github.com/KillahPotatoes/KP-Liberation/tree/master
Branch: master
In this branch the description.ext processing runs endless and the indexing stays at 0%. The output of SQFLint shows just:
Indexing workspace...
Parsing: c:\Users\macio\Documents\KP-Liberation\Missionframework\description.ext
Parsed: c:\Users\macio\Documents\KP-Liberation\Missionframework\description.ext
Proccessing: c:\Users\macio\Documents\KP-Liberation\Missionframework\description.ext

Repository: https://github.com/KillahPotatoes/KP-Liberation/tree/v.0.96.7
Branch: v.0.96.7
In our current working branch for the version which will be released in a few days it actually shows an error and crashes.
Indexing workspace...
Parsing: c:\Users\macio\Documents\KP-Liberation\Missionframework\description.ext
Parsed: c:\Users\macio\Documents\KP-Liberation\Missionframework\description.ext
Proccessing: c:\Users\macio\Documents\KP-Liberation\Missionframework\description.ext
Error while parsing c:\Users\macio\Documents\KP-Liberation\Missionframework\description.ext SyntaxError: Expected "/*", "//", ";", comment, end of line, or whitespace but ")" found.
    at peg$buildStructuredError (c:\Users\macio\.vscode\extensions\senfo.sqflint-0.12.0\server\parsers\grammars\pegjs-hpp.js:403:16)
    at Object.peg$parse [as parse] (c:\Users\macio\.vscode\extensions\senfo.sqflint-0.12.0\server\parsers\grammars\pegjs-hpp.js:3238:15)
    at Object.parse (c:\Users\macio\.vscode\extensions\senfo.sqflint-0.12.0\server\parsers\hpp.js:17:43)
    at c:\Users\macio\.vscode\extensions\senfo.sqflint-0.12.0\server\modules\ext.js:256:44
    at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:61:3) {
  message: 'Expected "/*", "//", ";", comment, end of line, or whitespace but ")" found.',
  expected: [
    { type: 'other', description: 'whitespace' },
    { type: 'other', description: 'end of line' },
    { type: 'other', description: 'comment' },
    { type: 'literal', text: ';', ignoreCase: false },
    { type: 'other', description: 'whitespace' },
    { type: 'literal', text: '/*', ignoreCase: false },
    { type: 'literal', text: '//', ignoreCase: false },
    { type: 'other', description: 'end of line' },
    { type: 'other', description: 'whitespace' },
    { type: 'literal', text: '/*', ignoreCase: false },
    { type: 'other', description: 'whitespace' },
    { type: 'other', description: 'end of line' },
    { type: 'other', description: 'comment' }
  ],
  found: ')',
  location: {
    start: { offset: 186240, line: 6563, column: 45 },
    end: { offset: 186241, line: 6563, column: 46 }
  },
  name: 'SyntaxError'
} [
  '        class KP_GroupList: KPGUI_PRE_ListBox {',
  '            idc = 758038;',
  '            x = KP_GETCX(KP_X_VAL_C,KP_WIDTH_VAL_C,0,1);',
  '            y = KP_GETCY(KP_Y_VAL_C,KP_HEIGHT_VAL_C,4,16);',
  '            w = KP_GETW(KP_WIDTH_VAL_C,(4/3)); <--- ERROR LINE',
  '            h = KP_GETH(KP_HEIGHT_VAL_C,(24/5));',
  '            onLBSelChanged = "ctrlSetText [758039, groupId (KPPLM_groups select (lbCurSel 758038))]";',
  '        };',
  '',
  '        class KP_ButtonJoin: KPGUI_PRE_InlineButton {',
  '            text = "$STR_KPPLM_JOIN";',
  '            x = KP_GETCX(KP_X_VAL_C,KP_WIDTH_VAL_C,3,4);',
  '            y = KP_GETCY(KP_Y_VAL_C,KP_HEIGHT_VAL_C,4,16);',
  '            w = KP_GETW(KP_WIDTH_VAL_C,4);',
  '            h = KP_GETH(KP_HEIGHT_VAL_C,(48/5));'
]
Starting SQFLint Background-Server
SQFLint: Process crashed Error: spawn java ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:264:19)
    at onErrorNT (internal/child_process.js:456:16)
    at processTicksAndRejections (internal/process/task_queues.js:77:11) {
  errno: 'ENOENT',
  code: 'ENOENT',
  syscall: 'spawn java',
  path: 'java',
  spawnargs: [
    '-jar',
    'c:\\Users\\macio\\.vscode\\extensions\\senfo.sqflint-0.12.0\\bin\\SQFLint.jar',
    '-j',
    '-v',
    '-s'
  ]
}
(node:22648) UnhandledPromiseRejectionWarning: Error: write EPIPE
    at afterWriteDispatched (internal/stream_base_commons.js:146:25)
    at writeGeneric (internal/stream_base_commons.js:137:3)
    at Socket._writeGeneric (net.js:698:11)
    at Socket._write (net.js:710:8)
    at doWrite (_stream_writable.js:418:12)
    at writeOrBuffer (_stream_writable.js:402:5)
    at Socket.Writable.write (_stream_writable.js:302:11)
    at c:\Users\macio\.vscode\extensions\senfo.sqflint-0.12.0\server\sqflint.js:190:37
    at new Promise (<anonymous>)
    at SQFLint.parse (c:\Users\macio\.vscode\extensions\senfo.sqflint-0.12.0\server\sqflint.js:180:16)
(node:22648) UnhandledPromiseRejectionWarning: Error: write EPIPE
    at afterWriteDispatched (internal/stream_base_commons.js:146:25)
    at writeGeneric (internal/stream_base_commons.js:137:3)
    at Socket._writeGeneric (net.js:698:11)
    at Socket._write (net.js:710:8)
    at doWrite (_stream_writable.js:418:12)
    at writeOrBuffer (_stream_writable.js:402:5)
    at Socket.Writable.write (_stream_writable.js:302:11)
    at c:\Users\macio\.vscode\extensions\senfo.sqflint-0.12.0\server\sqflint.js:190:37
    at new Promise (<anonymous>)
    at SQFLint.parse (c:\Users\macio\.vscode\extensions\senfo.sqflint-0.12.0\server\sqflint.js:180:16)
(node:22648) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:22648) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:22648) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:22648) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
SQFLint: Process crashed with code -4058

The mentioned syntax error in the output is at least a hint. But personally I can't see what SQFLint sees exactly as issue there:
https://github.com/KillahPotatoes/KP-Liberation/blob/v.0.96.7/Missionframework/KP/KPPLM/ui/KPPLM_dialog.hpp#L156
Many thanks for your time and willingness to keep this extension running. 👍

The issue the parser has is "(4/3)", the ")" to be percise.
Gonna need to alter the regex to fetch that, nothing too bad.
Thanks for the report


Use logging framework

Use logging framework such as slf4j so that we can easily output some debugging information and error messages to log file instead of console.

+1

Will it be done, or it won't be applied ?

SLF4J has been added to the pom.xml, also logging for request/response messages has been added.
A separate issue has been raised to further improve the logging #109 .

Thanks !


foreign cluster: fix missing return when not found

Description
This PR fixes a missing return in the foreign cluster controller, when the foreign cluster gets deleted.

/rebase test=true

/merge


Remove script templates for Javascript

Javascript support has been deprecated in Unity3D as a programming language (note that I'm not pointing to Javascript plugins when you export for WebGL platform). So script templates should be removed from the library or move them to a legacy folder.

yes, i'd say just remove - no need to keep (since they are totally useless)

This issue is solved in #50, please close.


Sharable links --> Shareable links

Typo in 'Sharable links' heading

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@MikePlumleyMSFT PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


ability to update domain and subdomains

same issue as in #33
where you replied on adding the ability to update domain and subdomain, altogether

Good suggestion!  I'll consider to add it, thanks!

Originally posted by @TimothyYe in https://github.com/TimothyYe/godns/issues/33#issuecomment-457039340
later issue #33 got offtrack and closed
is there any chance to have this ability on future releases?
here's my config:
      "domain_name": "example.com"
    },{
      "domain_name": "example.com",
      "sub_domains": ["*"]
    }
  ],

[ ] alidns
[X] cloudflare
[ ] dnspod
[ ] dreamhost
[ ] duck
[ ] google
[ ] he
[ ] noip

cdf32c509d4bd6c1a033632feb2f36c16ae1e3cd

[ ] alidns
[X] cloudflare
[ ] dnspod
[ ] dreamhost
[ ] duck
[ ] google
[ ] he
[ ] noip

cdf32c509d4bd6c1a033632feb2f36c16ae1e3cd

I would've never thought this isn't supported... is there a reason why? It's like the main reason for software like this no? And from the PR it seems its basically no change?!?

Hello @iskrisis . I think this issue is about the typical free-time and resource starvation that every open source project have.
Yes, it's true that the implementation that fix this issue for Cloudflare seemed really easy, but that doesn't mean the same solution applies to the other services. The easy-path solution for Cloudflare was that the API is the same for domains and subdomains, so I only needed to return the domain as a subdomain in order to fix this issue. I don't have the need and the resources (because I just use Cloudflare as my DNS Domain provider) to investigate and fix this issue for the other services.
And here comes the magic of the open-source. Someone with the tech-skills, needs, and resources could come here with a PR to fix the other services. Meanwhile, you can incentive this kind of uninterested behavior with a good-looking, maintained, and healthy project. I came here with this PR because I had the need to have a DDNS in my router (GoLang is a good portable language), the code was easy to understand, and it supports Cloudflare. When I saw that my requirements was easy to fix with just a few lines, I sent the patch. Help us to maintain a good looking project (better codes/docs, with community, etc) and eventually someone with the same requirements will send us a PR for the other services.
Even I'll encore you to try to send any PR that could help this project healthy. GoLang is an easy language to start programming. Grab any issue or start working on anything that you think can help this project to be attractive to more persons. :-)

@jlsalvador please don't take this the wrong way. I understand the burden of OSS and i am fully aware that i can make PRs. I also maintain some stuff.
But i think there is also other side of the coin and thats if you are making DDNS client and you for some reason don't support updating of root records which is definition of CORE feature... It seems like very artificial limitation considering software is already able to do it.
Maybe just don't pose as super nice software with LOGO and documentation.. support tables.. Mention that it's not supporting root records in those docs. The project looked like the most legit of the ones i found. It took me quite some time to figure out that it won't update root records. I thought i must have made configuration error.
Maybe you are without reason wasting time of someone who can't help you with Go and can't even build the project and uses the release binary. This happens when you offer the software to the world. Yes lame people use it. And yes you have all the rights but there is also something about being precious about your users.

@iskrisis Calm down bro, the original reason was, when the first time I design this tool, I only had one domain. I use root record to host my personal blog and use sub-domain for DDNS purposes. If one domain can be used for multiple purposes, then it looks good to me. For my personal scenario, I don't have the need to update the root record for DDNS. Sorry for the time you wasted, if you think updating root records is definitely a CORE feature, I will add it.
@jlsalvador Thanks for your patient and explanation, and thanks for the PR again.

@TimothyYe  i don't want you to add anything. I was just asking for more clear description. Something like this https://github.com/TimothyYe/godns/pull/99 There are many DDNS projects. Yours just looks the best and the most complete (you even mention its rewrite of different projects so it looks double legit) so one would expect its super feature packed and complete.
Just saying guys

Close this issue since it is already supported by V2.3.4 (https://github.com/TimothyYe/godns/releases/tag/V2.3.4)


Add a "channels:archived" search filter

We should add a channels:archived filter to make it possible to search only in archived channels, or only in non-archived channels by negating it. (The naming is analogous to channels:public).

CZO thread

@zulipbot claim

@zulipbot claim

@alya can i Take up this issue?

Sure, unassigning @eriksimonson , since there haven't been any updates.

@alya do i need to update the help section about filtering archived channels?


Animations causing navbar-fixed-top to disappear while scrolling

I have a website based on BS3 where the navbar-fixed-top is acting rather strange while viewed in mobile mode. When the page is loaded the toggle switch is not visible, if i scroll a little it appears. When i scroll further down to other animations it disappears once again, and appears slowly.
This problem does not occur while in desktop mode.

I have exactly the same issue, any suggestions on how to fix that?


ReloadAfter does not work in deployed MVC Web API 3.1

System Manager ReloadAfter works fine running this executable locally on development machine.
Unfortunately, the ReloadAfter functionality in SystemsManagerConfiguration does not work in our .NET solution running/deployed in AWS when the application is running inside a Docker container (default Microsoft/Alpine base image mcr.microsoft.com/dotnet/core/aspnet:3.1-alpine) deployed to ECS/Fargate
In the AWS deployment Parameter values are loaded at startup but remain the same during the lifetime of the instance.
The Parameter values are loaded at started up and then not reload when deployed in AWS. Locally the Parameters values are reloaded every 2 minutes as specified by call to ReloadAfter

This is a :bug: bug-report

Similar to https://github.com/aws/aws-dotnet-extensions-configuration/issues/17

Hi @jaretts,
Good afternoon.
Looks like we have the similar issue https://github.com/aws/aws-dotnet-extensions-configuration/issues/17 which is already prioritized and queued. Hence closing this issue. If required, you can add yourself to watchlist of the other issue.
Thanks,
Ashish


refs(HMSPROV-351) - hide confirm modal after a launch success

the wizard context is not accessible on the top level, we can split the wizard root component to make it work, but I guess it makes sense to do so only if we will need the launch status in another step.

Ok, sure, let's not optimize prematurely and go with simple solution for now 👍


Updated Node.js engine and npm to recent version

Updated. 😄
Tested by deploying on Glitch. Works fine there.

Can you please try to deploy to now.sh?

@gr2m , I deployed it on now.sh using now-cli. And, it's deployment is working fine. [See screenshot]
Note that by updating package.json by using >=, with this, it's updating Node.js to version 9.10.1, (most recent stable version with latest features).
"engines": {
    "node": ">=8.3.0",
    "npm": ">=5.3.0"
  },

And by just using the old statement, it's updating it to Node.js version 8.11.1 (most recent version of Node.js version 8).
"engines": {
    "node": "8",
  },

:tada: This PR is included in version 2.4.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added new ip addresses to Availability tests

These are the ip addresses for the new scale units we added to the service. Please approve.

@jacobmsft : Thanks for your contribution! The author, @mrbullwinkle, has been notified to review your proposed change.

#sign-off


[BEAM-10925] Don't publish udf-test-provider to Maven.

This cherry-picks https://github.com/apache/beam/pull/13967

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @ibzib


Support . as a row:column separator in terminal link detector

The motivation here is the Sail language compiler which outputs errors conforming to the GNU style
https://www.gnu.org/prep/standards/html_node/Errors.html
I think they must be the only people in the world actually using the line0.col0-line1.col1 format. I did have an attempt to capture the ending line/column but it is very difficult with regex, and not that useful anyway so I've opted for the simpler option of just ignoring the - part.
Fixes #190350
The easiest way to test this is to make a file test.txt containing something like this:
Error: some error test.txt:1.10

Then cat it in the integrated terminal and click the links.

Wow thanks for the fast review!
I did think about adding that one but then I saw that it would involve adding a new regex and changing the code that reads the capture groups and I wasn't even sure VSCode actually uses the end lines/columns... Maybe that's just an excuse for my laziness :-)

A new regex is fine for the class of links that contain them interleaved like that, I expect it to work fine with the new regex. Feel free to leave this PR as is and create a new one to include that (or not bother, no commitment).


ci: Disable nix cache on self-hosted runners

In an attempt to speed up Nutanix e2e tests.

Disabling the cache sped up the build by about 2m45s.
Without this PR: 15m13s (https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/actions/runs/9792020236/job/27036984336)
With this PR: 12m27s (https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/actions/runs/9792133640/job/27040403767)
Specifically the Install devbox step sped up from 4m15s to 2m32s.


Load fat jar but do not analyse dependencies [TG-9521]

Branch used for analysis for this benchmark is add-jacoco, see https://diffblue.atlassian.net/wiki/spaces/DOC/pages/51282069/Dashboard+benchmarks
With all dependencies on the classpath but "context-excluded", we expect the coverage to be the same as before after this change, and the analysis time should not be much longer.
We should probably wait until at least the day after https://diffblue.atlassian.net/browse/TG-9673 is done to merge this.

It turns out including com.floragunn.searchguard. is too general, as there is a dependency for a package com.floragunn.searchguard.ssl. I will double-check if there are any other dependencies with this prefix.

I checked with
diff <(jar tf search-guard-6-6.x-HEAD-SNAPSHOT.jar | grep "\.class$" | sort) <(jar tf search-guard-6-6.x-HEAD-SNAPSHOT-with-dependencies.jar | grep "\.class$" | sort) | less

and com.floragunn.searchguard.ssl is the only package that starts with com.floragunn.searchguard and is not part of the project. I have used --context-exclude to exclude it.


Create Dark Mode button

Feature request:
Add a button that can toggle between dark and light mode.
Describe the solution you'd like:
Use the common header file, to place the button to avoid any sort of confusion, and when the user first visits the website is in light mode but when the user clicks on the button the theme changes to dark mode.
Describe alternatives you've considered:
A better user experience would be adding a toggle instead of a button. Just like how GitHub gives used to give us a toggle.
Describe how this feature will be useful to our readers:
Well, the dark mode would be better useful to readers during night time, as this prevents blue light from affecting the eyes of users.
Additional context:

Note:

If you want to work on an issue, you should check if it has already been assigned to anyone.

Sir,
I want to work on this issue. Please assign it to me.

Sir,
I want to work on this issue. Please assign it to me.

Done. But make sure to use a common header file for placing the toggle.

Sir,
I want to work on this issue. Please assign it to me.

Done. But make sure to use a common header file for placing the toggle.

Will keep that in mind.
Thank you!

I am GSSOC'21 Participant. I added a PR for this issue,thanks for merging it.


Add upgrade guide for Link.copyparams changes

For #4997.
This PR also fixes broken heading. (duplicated "Chainer v5")

Jenkins, test this please.

Jenkins CI test (for commit 3e1bfed5547a62baac52483fbd9cf98d3903cc05) succeeded without errors!


Rewire Subscription for Python to use default tag

Automation for azure-libraries-for-java
Nothing to generate for azure-libraries-for-java

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-node


Support tags injection via JAEGER_TAGS environment variable

For the sake of consistency, it would be useful if tags could be aggregated via JAEGER_TAGS environment variable like in the Java and, as of recently, Python clients.

Done in #9


Client Allocation Request for: ratohe

Client Allocation Questions
Core Information

Name: ratohe
Website / Social Media:
Region: Europe
DataCap Requested: 10TiB
Addresses to be Notarized: f3stzriiqe6hxoig363uhi6jf77o2a4s4lodpf6oguxvt52jzpu6dcmsun6n4ithh2r7mml6vou2haaig6sipa
Notary Requested: cryptowhizzard

@ratohe Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hi!
I could not sign this one ( It did not pop up on the dashboard ). I therefore did a assignment for 10 TB with a private request that went through.
@galen-mcandrew @dkkapur


Don't call customElements.define if definition already exists

This guards against defining a Custom Element if it has already been defined previously. Without this, instantiating the app multiple times throws an error: Uncaught DOMException: Failed to execute 'define' on 'CustomElementRegistry': the name "my-app" has already been used with this registry.
Our use case is that we embed an Ember app in a parent app under a certain route. When navigating between different routes in the parent app, a user can enter the Ember app, go to a different route, then go back to the Ember app. Each time the Ember app renders, ember-embedded-snippet tries to define the Custom Element.
Unfortunately it is not possible to unregister a Custom Element, so the only way to avoid throwing the error is to check if a definition already exists and not do anything if that's the case.

@kevinkucharczyk sorry it took so long to get to this, apparently I missed notifications for this repo. Will try to get this repo into shape again, and cut a new release! Thanks for working on this!


rds: Blue/Green Deployments for database updates

What problem are you facing?
Updates of major versions lead to downtime.
How could Official AWS Provider help solve your problem?
I want to be able to use the new Blue/Green Deployments feature for database updates with Crossplane.
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/blue-green-deployments.html

I'm closing because I discovered that the feature was already implemented.
I must have read the documentation with little attention; I am sorry for the noise caused.


Fix issue #129

Fix issue #129
I will rebase it tommorow

Sorry @jadb the PR has been closed while i was trying to rebase it


Skins are missing initial width/height change

During skin construction registerListeners() is called last, but width and height of the control change during initGraphics() when adding the children. This results in wrong layout of the skin when no further layout change happens.
using: Oracle VM 1.8.172 on Windows

Can you provide a code snippet that reproduces the issue please?

Ok...with your code I see the problem and will take a look at it. I guess you know it but nevertheless it is not a good idea to add/remove nodes to the scene graph after it has been initialized. You could simply avoid this problem by adding the gauge before the stage will be shown e.g. Group group = new Group(gauge);

Where did you see that effect originally? In SceneBuilder?

This happens in the gui builder part of our application, which is not based on SceneBuilder.
I know there are performance considerations when changing an initialised scene graph, but modifications are dictated by the dynamic nature of gui builders.
For now I removed the listener on layoutBounds and wait for the layout pass to set needsLayout to false instead.

Should be fixed with last commit (7f21691e1e0d6f23938144c744a96e52c6ab)


docs!: improve the instructions to follow breaking changes (#231)

Improve the README instruction on where to find breaking changes. Included a suggestion to subscribe to the github issue to get notified about changes.

I recommend making this PR a breaking change by adding feat! in front of the commit message, so Packer emphasizes it in its status display (https://github.com/hrsh7th/nvim-cmp/issues/896#issuecomment-1099035112)

I'm confused: I agree with the comment in general, but this PR isn't a breaking change

I know it's not, but by saying it is, you'll make it more visible

I updated the commit to include pointers to the issue as well, so hopefully people will gain knowledge about this issues and can subscribe to it.


Add a Retry-After header when rate limit is exceeded

This PR is a first attempt to address issue #3702.
Ideally we would use a timeout based approach, but for now this PR adds a Retry-After response header from the throttling code and the Do method in request.go observes this and waits for the retry period and makes about 10 retries before giving up. @bgrant0607
Still working out how to test this.

Please do not merge until I can produce a unit test for this. Thanks.

Great! LGTM. FWIW, I'd be fine if the unit test were a separate PR.

Great. I will do a separate PR for the unit test since this will take a little bit work and could use its own PR. Please merge when you're ready, thanks.

Thanks! Let's keep an eye on builds starting after 10:41AM to make sure this change does not cause problems -- if it does or we think it might then let's revert it ASAP.


Graham Wallis is not in the US

can this be closed?

I think we can vote this one as the most obscure issue to date :)


Request For Info: Growing Trees indoors

I am trying to find information on how dynamic trees might be grown indoors if the mod supports some artificial light source in place of the open sky above the tree.  I've tried modifying the config regarding the scaleBiomeGrowthRate hoping that might allow for it, but no luck.  Is there any way at all or are indoor trees doomed?

You can make light conduits that channel sky light from above ground.  Aside from that, no you can't grow with artificial light and it will never be a feature that you can.


[1/2] Extract Kibana configuration into a separate job

This way, Kibana can use a remote Elasticsearch host that is configured with Shield.
This is a breaking change, so I'll call the release with this code 2.0.

:shipit:

(reviewed in person) 🚢


SQL generation fails when the model table name is already quoted

Error encountered: django.db.utils.ProgrammingError: zero-length delimited identifier at or near """"
This issue occurs when attempting to do a bulk_update_or_create with a model which already has double-quotes in the table name. This occurs if you define your model with a table_name which includes a double-quoted schema name prefix, like so:
class MyModel(models.Model):
class Meta:
db_table = '"schema"."mymodel"'

Thanks for report and PR. I'll watch review your PR as soon as possible

Released v3.4.1

Released v3.4.1


kb_compress_temps - MultipleObjectsReturned

I'm getting the following error when trying to run kegbot-admin.py kb_compress_temps
pykeg.core.models.MultipleObjectsReturned: get() returned more than one ThermoSummaryLog -- it returned 2! Lookup parameters were {'date': datetime.datetime(2011, 4, 2, 0, 0), 'period': 'daily'}
Full details:  http://dpaste.com/604220/

Fixed by commit 8a2e1c79.


Add IO tests for resqpy.organise and resqpy.well objects

Contingent on #18 being merged

Codecov Report

Merging #45 (955dc6d) into master (95afcb2) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master     #45   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files          48      48
  Lines       21531   21546   +15
======================================
- Misses      21531   21546   +15

Impacted Files
Coverage Δ

resqpy/organize.py
0.00% <0.00%> (ø)

resqpy/well.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95afcb2...955dc6d. Read the comment docs.


MngClusterProvider does not update launch template after upgrading to EKS v1.24

Describe the bug
The managed node group need manual update to apply latest AMI of the new EKS version

export function EksComponents(env: EnvironmentConfig) {
  const MngProvider = new MngClusterProvider({
    version: KubernetesVersion.V1_24,
    id: `${env.pattern}-vc-${env.stage}-Mng`,
    minSize: 2,
    maxSize: 2,
    instanceTypes: [
      InstanceType.of(InstanceClass.T3A, InstanceSize.MEDIUM),
      InstanceType.of(InstanceClass.T3, InstanceSize.MEDIUM),
    ],
    amiType: NodegroupAmiType.BOTTLEROCKET_X86_64,
    nodeGroupCapacityType: CapacityType.SPOT,
  });
  return MngProvider;
}

Expected Behavior
Launch template of managed node group is updated automatically
Current Behavior
Manual update
Reproduction Steps
Upgrade EKS v1.23 to v1.24
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.60.0
EKS Blueprints Version
1.5.4
Node.js Version
v18.9.1
Environment details (OS name and version, etc.)
MacOS 13.1
Other information
No response

@vumdao is it still relevant? It was a miss to not respond sooner, please ping me directly if you see no progress on your issues. Please see this doc page on data plane upgrade that should be coupled with the control plane upgrade. Look up of AMI will be required but there is no need to update individual node groups manually.


Adding my event

Just doing some clean-up. This will obviously never get merged. Hope you're doing awesome :+1:

I wanted to merge it. It didn't auto-merge, and I was too lazy to rebase and PR your PR. Sorry @kentcdodds. You are the best. I would love to merge it.

In that case, I'll create another PR :-)


Guide/latest - broken link

These is one malformed link in the guide:
On this page https://docs.vulkan.org/guide/latest/layers.html near the top, this link:
/data/local/debug/vulkan
Points to:
hhttps://cs.android.com/android/platform/superproject//android-9.0.0_r1:frameworks/native/vulkan/libvulkan/layers_extensions.cpp;l=454[returns%201],%20then%20the%20loader%20will%20look%20in%20link:https://cs.android.com/android/platform/superproject//android-9.0.0_r1:frameworks/native/vulkan/libvulkan/layers_extensions.cpp;l=67
The schema has an extra h (hhttps) and the URL appears to be non-existent, once the schema is corrected.

Transferred from the Antora repo - this is a typo in chapters/layers.adoc ('hhttps://' instead of 'https://') and once fixed here, will propagate through to the Antora site as well. In the github render the link text just shows up as dead text rather than a broken link.


Store chart data, add band options, fix sample image layout

Store chart data after initial load of each data type, add band options for Landsat visualization, fix sample image layout to match actual layout.

src/main/resources/public/jsx/geo-dash.js

1250, this line is way to long

graphRef: this.createChart(
    widget.id,
    widget.graphBand != null ? widget.graphBand : indexName,
    this.state.chartData[this.props.degDataType].data,
    widget.graphBand != null ? widget.graphBand : indexName
),

1250, is ok for widget.graphBand to be undefined? If not use

graphRef: this.createChart(
    widget.id,
    widget.graphBand || indexName,
    this.state.chartData[this.props.degDataType].data,
    widget.graphBand || indexName
),

1250, 1354 why are you passing the same value to createChart in two parameters?
1232, 1461 Length cant be less than 0. What are you checking for here?
1321 I think you are missing some parentheses.  this.props.degDataType !== "sar" || this.props.degDataType === "sar" is always true.

---------  A group of related changes

1286 this is not scoped where it is used
1290 - 1294, this can be done simpler with filter and map.
1295 Remove. Dont assign a value to itself.  Also sort() mutates the original array so it doesnt need to be reasinged.
1298 how can this have a value if Object.keys(res.timeseries[0][1]).length === 0
1299 data: res.timeseries.filter(v => v[0]).map(v => [v[0], v[1]]).sort((a, b) => a[0] - b[0]);
1367 Remove unneeded function.

1298 Object.keys(res.timeseries[0][1]).length === 0 is checking to see which format is being returned.  This is a format that is returned with no keys.

src/main/resources/public/locale/geodashhelp_en.json
src/main/resources/public/locale/geodashhelp_es.json
40-42, remove space after : for consistency


feat(CI): upload static link library as artifact (ubuntu and macos)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.11%. Comparing base (c260513) to head (e8c3219).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #645       +/-   ##
===========================================
+ Coverage   62.45%   95.11%   +32.66%
===========================================
  Files          60        8       -52
  Lines        8320      737     -7583
  Branches      877        0      -877
===========================================
- Hits         5196      701     -4495
+ Misses       3124       36     -3088

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

please merge this PR to fix https://github.com/apache/incubator-graphar/issues/647


Test PlayReady CBCS content not playing on the Xbox

Have you read the FAQ and checked for duplicate open issues?
Yes
What link can we use to reproduce this?
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;panel=HOME;build=uncompiled
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;panel=CUSTOM CONTENT;build=uncompiled
What version of Shaka Player are you using?
v3.0.7-uncompiled
What browser and OS are you using?
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.141 Safari/537.36
Edge on the XBOX 360
What did you do?

Using the test stream from
http://testweb.playready.microsoft.com/Content/Content4X

MPEG-DASH (protected)
https://test.playready.microsoft.com/media/dash/APPLEENC_CBCS_BBB_1080p/1080p.mpd

LA URL
http://test.playready.microsoft.com/service/rightsmanager.asmx?cfg=(persist:false,ck:W31bfVt9W31bfVt9W31bfQ==,ckt:aescbc)

Error DRM.failed_to_create.CDM
Also used https://github.com/Axinom/public-test-vectors
CBCS test links
https://media.axprod.net/TestVectors/v9-MultiFormat/Encrypted_Cbcs/Manifest_1080p.mpd
Same error
Error DRM.failed_to_create.CDM
What did you expect to happen?
Playback
What actually happened?

I'm sorry, but we don't currently have any way to directly support Xbox 360.  We don't have one to test or debug with, so Xbox 360 support will have to be community-driven.
We do support Xbox One, though we are currently waiting on a replacement for a broken device.  Do you know if this content works correctly on Xbox One?
Can you try the code currently in the master or v3.0.x branches to see if the issue has been fixed there?  It's possible that this will be corrected by the v3.0.8 release we are about to publish.

I'm sorry, but we don't currently have any way to directly support Xbox 360.  We don't have one to test or debug with, so Xbox 360 support will have to be community-driven.
We do support Xbox One, though we are currently waiting on a replacement for a broken device.  Do you know if this content works correctly on Xbox One?
Can you try the code currently in the master or v3.0.x branches to see if the issue has been fixed there?  It's possible that this will be corrected by the v3.0.8 release we are about to publish.

Hello
It was a typo, It is an XBOX one
We are using the public
https://shaka-player-demo.appspot.com/demo/#build=uncompiled URL for testing
On Wed, Jan 27, 2021 at 2:01 PM Joey Parrish<EMAIL_ADDRESS>wrote:

I'm sorry, but we don't currently have any way to directly support Xbox
360. We don't have one to test or debug with, so Xbox 360 support will have
to be community-driven.
We do support Xbox One, though we are currently waiting on a replacement
for a broken device. Do you know if this content works correctly on Xbox
One?
Can you try the code currently in the master or v3.0.x branches to see if
the issue has been fixed there? It's possible that this will be corrected
by the v3.0.8 release we are about to publish.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/shaka-player/issues/3119#issuecomment-768503093,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDOMLCIGHY7FYIKXZYG35TS4BPJFANCNFSM4WSX4ZFQ
.

--
David Eisenbacher

Hello
It was a typo, It is an XBOX one
We are using the public
https://shaka-player-demo.appspot.com/demo/#build=uncompiled URL for testing
On Wed, Jan 27, 2021 at 2:01 PM Joey Parrish<EMAIL_ADDRESS>wrote:

I'm sorry, but we don't currently have any way to directly support Xbox
360. We don't have one to test or debug with, so Xbox 360 support will have
to be community-driven.
We do support Xbox One, though we are currently waiting on a replacement
for a broken device. Do you know if this content works correctly on Xbox
One?
Can you try the code currently in the master or v3.0.x branches to see if
the issue has been fixed there? It's possible that this will be corrected
by the v3.0.8 release we are about to publish.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/shaka-player/issues/3119#issuecomment-768503093,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDOMLCIGHY7FYIKXZYG35TS4BPJFANCNFSM4WSX4ZFQ
.

--
David Eisenbacher

I don't think xbox edge supports drm?
https://answers.microsoft.com/en-us/xbox/forum/xba_acc/how-to-turn-on-drm-on-edge-xbox-one/eb451440-138d-4a57-86a5-bf25fbdced29?auth=1
Does this report playready support: https://bitmovin.com/docs/player/articles/browser-drm-support

I don't think xbox edge supports drm?
https://answers.microsoft.com/en-us/xbox/forum/xba_acc/how-to-turn-on-drm-on-edge-xbox-one/eb451440-138d-4a57-86a5-bf25fbdced29?auth=1
Does this report playready support: https://bitmovin.com/docs/player/articles/browser-drm-support

Hello
Maybe we were trying to take a shortcut on testing by just trying to use
edge and load the player in the browser on the Xbox
What is the proper way to test the Shaka player on XBOX one?
David
On Thu, Jan 28, 2021 at 5:37 PM hamesjarden<EMAIL_ADDRESS>wrote:

I don't think xbox edge supports drm?
https://answers.microsoft.com/en-us/xbox/forum/xba_acc/how-to-turn-on-drm-on-edge-xbox-one/eb451440-138d-4a57-86a5-bf25fbdced29?auth=1
Does this report playready support:
https://bitmovin.com/docs/player/articles/browser-drm-support
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/shaka-player/issues/3119#issuecomment-769445095,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDOMLBJKDK7IJPMNIBAPVTS4HRJXANCNFSM4WSX4ZFQ
.

--
David Eisenbacher

Hello
Maybe we were trying to take a shortcut on testing by just trying to use
edge and load the player in the browser on the Xbox
What is the proper way to test the Shaka player on XBOX one?
David
On Thu, Jan 28, 2021 at 5:37 PM hamesjarden<EMAIL_ADDRESS>wrote:

I don't think xbox edge supports drm?
https://answers.microsoft.com/en-us/xbox/forum/xba_acc/how-to-turn-on-drm-on-edge-xbox-one/eb451440-138d-4a57-86a5-bf25fbdced29?auth=1
Does this report playready support:
https://bitmovin.com/docs/player/articles/browser-drm-support
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/shaka-player/issues/3119#issuecomment-769445095,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDOMLBJKDK7IJPMNIBAPVTS4HRJXANCNFSM4WSX4ZFQ
.

--
David Eisenbacher

The issue isn't Shaka. You need to determine if Edge on xbox supports playready. I do not believe it does.

The issue isn't Shaka. You need to determine if Edge on xbox supports playready. I do not believe it does.

When I try with the Edge app, it doesn't support PlayReady.  You can check support with https://shaka-player-demo.appspot.com/support.html.  It's odd that you would see that error instead of seeing no support early.  You could take a look at google/generic-webdriver-server#12 for an example UWP app that should support PlayReady.  You could use this to test.

Yes, we found the same.  Though I recall once many years ago being able to test Shaka on Xbox in Edge, it may have been clear content or they may have removed PR support since.
Try this on a Windows host with VS and all the prerequisites set up:
npm install -g xbox-one-webdriver-server
xbox-one-webdriver-cli --hostname=XBOX-IP --username USERNAME --password PASSWORD --url https://shaka-player-demo.appspot.com/


Pull todos into github issues

Codecov Report

Merging #17 (9d0dae3) into master (72c2126) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   80.28%   80.47%   +0.19%
==========================================
  Files           8        8
  Lines         421      420       -1
==========================================
  Hits          338      338
+ Misses         70       69       -1
  Partials       13       13

Impacted Files
Coverage Δ

parser/lexer.go
98.23% <ø> (+0.86%)
:arrow_up:

sql_adaptor/adaptor.go
90.90% <ø> (ø)

sql_adaptor/sql.go
53.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c2126...9d0dae3. Read the comment docs.


[DF] Remove all references to Calcite and update with DataFusion

There are several places in the code base where Calcite is mentioned in the comments. All of those instances should be remove and replaced with the correlating DataFusion comment. This is not a simple find/replace but rather the wording needs to be adjusted to ensure it is still valid in DataFusion. If something doesn't fit it can just be removed.

@ChrisJar Does this one make sense to you? If not I can take it. Just wanted to check.

Yep! I can tackle this


Avoid deprecated set-output command

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Thanks for the contribution @klieret 🚀


[Addon: Knobs] Updating text fields is laggy and frequently overwrites keys.

Describe the bug
Editing text fields in knobs seemingly lags behind key presses, and deletes any characters after one of such instances.  It's like the state is updating in a convoluted manner, and previously entered characters are overwritten. For example, quickly typing "Kris Tremblay" at the same speed I'd normally type yielded "Krisblay".
To Reproduce
Steps to reproduce the behavior:

Open any component with a text knob
Change the text knob to a string that is more than a couple characters long (maybe write your name)

Expected behavior
The field should act as a normal input, and changes should be reflected in the component.
Code snippets
The following is my test story for an ActionButton component.
import { storiesOf } from '@storybook/vue';
import { withKnobs, text, select, boolean} from '@storybook/addon-knobs';

import ActionButton from '../src/components/ActionButton.vue';

const actionButtonStories = storiesOf('Action Buttons', module);
actionButtonStories.addDecorator(withKnobs);

const actionButtonClasses = {
  Attention: 'action__button--attention',
  No: 'action__button--no',
  Ok: 'action__button--ok',
  Primary: 'action__button--primary'
};

actionButtonStories.add('with added Sexy', () => ({
  components: { ActionButton },
  props: {
    className: {
      default: select('Class', actionButtonClasses, 'action__button--primary')
    },
    disabled: {
      default: boolean('Disabled', false)
    },
    text: {
      default: text('Text', 'Action Button')
    }
  },
  template: `<div>
    <ActionButton :class="className" :disabled="disabled">{{ text }}</ActionButton>
  </div>`
}));

System:

OS: Windows 10
Device: Beefy PC
Browser: Replicated in Chrome and Edge
Framework: VueJS
Addons: Knobs
Version: 5.0.1

Is it possible it has something to do with the debounce in KnobStore?

@CodeByAlex mind taking a look at this? I suspect it's related to https://github.com/storybooks/storybook/pull/5811

@kristremblay, do you know if this was introduced in 5.0.1 or was it present in 5.0.0

@CodeByAlex I just started using Storyboard today so I actually don't know.

@kristemblay, welcome to the community! Would you mind reverting your version of addon/knobs to 5.0 and check.; A separate piece of code that debounces other than what you mentioned above was added to fix the symptoms you are seeing. It would be great if we could pinpoint whether or not that change had an unintended impact.
On a separate note, I’m wondering what if the need for the 50ms Debounce in the store is still needed.

Thanks!  This is a great product you guys have made and it's certainly making my life easier :)
It looks like it is working properly in 5.0.0.  I saw the debounce and assumed that had something to do with it.

That’s good to know. @shilman I’ll take a look into this further. The issue may be caused by multiple Debounce functions that could be conflicting with each other.

@CodeByAlex @ndelangen How about posting the knob change when the user hits enter or focus leaves the text field, rather than on every key press?

I have the exact same issue. Was happening in 5.0 and upgraded to 5.0.1 and the issue seemed to be fixed slightly but I still have to type slower than usual without characters being dropped. I think posting the knob update on blur of the knob would be better IMO

@shilman @ndelangen it looks like the Debounce that was added to reduce lag on the Angular side caused the choppy text entry that @kristremblay was mentioning. We will have to back that out and put in a different solution. The frameworks seem to react differently to this knobs rendering logic in general.

I can provide links to anyone who picks up this issue with examples that we are experiencing this on both 5.0.0 and 5.0.1, I just can't share the links publically since its a proprietary storybook. If you DM me (shared them with @shilman on discord as well).

@shilman @kylepeeler @kristremblay
Heres what Im thinking
const debouncedOnKnobChanged = debounce(change => {
  knobStore.markAllUnused();
  forceReRender();
}, 400);

function knobChanged(change) {
  var name = change.name,
  value = change.value; // Update the related knob and it's value.
  var knobOptions = knobStore.get(name);
  knobOptions.value = value;
  debouncedOnKnobChanged(change);
}

So as of the 5.0.1 updated, the logic in the de dunction consisted of:
  var name = change.name,
  value = change.value; // Update the related knob and it's value.
  var knobOptions = knobStore.get(name);
  knobOptions.value = value;
  knobStore.markAllUnused();
  forceReRender();

After adding the following back in the onchanged function before the debounce, the issue in vue is resolved:
  var name = change.name,
  value = change.value; // Update the related knob and it's value.
  var knobOptions = knobStore.get(name);
  knobOptions.value = value;

To better handle the debouncing and force rendering, instead of waiting for a user to click out of the field, we should wait for a longer pause before rendering. In the 5.0.1 version, its waiting 150ms which is a little faster than the average typing speed. I suggest we wait closer to 400ms and then just have it render when the user has completed their thought. What do you guys think?

I think that's a good solution.  Let's see how it works in the next commit :)

PR for this change can be found here: https://github.com/storybooks/storybook/pull/6022

Crikey!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.5 containing PR #6022 that references this issue. Upgrade today to try it out!
Because it's a pre-release you can find it on the @next NPM tag.
Closing this issue. Please re-open if you think there's still more to do.

@shilman Perhaps I'm doing something wrong, but running npm install @storybook/knobs@next and installing 5.1.0-alpha.5 causes a problem where clicking on the Knobs tab kills the application.  White screen with the following console dump:
vendors~main.c2014981fb34776cf713.bundle.js:129299 Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
    in Unknown (created by Context.Consumer)
    in Styled(Component) (created by KnobPanel)
    in KnobPanel
    in div (created by Context.Consumer)
    in Styled(div)
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown
    in Unknown
    in Unknown (created by Context.Consumer)
    in _default (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Panel)
    in Panel (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in Main (created by Layout)
    in Layout (created by Context.Consumer)
    in WithTheme(Layout) (created by ResizeDetector)
    in ResizeDetector
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by ResizeDetector)
    in ResizeDetector
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root
warningWithoutStack @ vendors~main.c2014981fb34776cf713.bundle.js:129299
warning @ vendors~main.c2014981fb34776cf713.bundle.js:129714
createElementWithValidation @ vendors~main.c2014981fb34776cf713.bundle.js:130841
(anonymous) @ vendors~main.c2014981fb34776cf713.bundle.js:4666
renderWithHooks @ vendors~main.c2014981fb34776cf713.bundle.js:97120
mountIndeterminateComponent @ vendors~main.c2014981fb34776cf713.bundle.js:99202
beginWork @ vendors~main.c2014981fb34776cf713.bundle.js:99807
performUnitOfWork @ vendors~main.c2014981fb34776cf713.bundle.js:103494
workLoop @ vendors~main.c2014981fb34776cf713.bundle.js:103534
renderRoot @ vendors~main.c2014981fb34776cf713.bundle.js:103617
performWorkOnRoot @ vendors~main.c2014981fb34776cf713.bundle.js:104524
performWork @ vendors~main.c2014981fb34776cf713.bundle.js:104436
performSyncWork @ vendors~main.c2014981fb34776cf713.bundle.js:104410
interactiveUpdates$1 @ vendors~main.c2014981fb34776cf713.bundle.js:104677
interactiveUpdates @ vendors~main.c2014981fb34776cf713.bundle.js:86398
dispatchInteractiveEvent @ vendors~main.c2014981fb34776cf713.bundle.js:89110
vendors~main.c2014981fb34776cf713.bundle.js:129299 Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
    in Unknown (created by Context.Consumer)
    in Styled(Component) (created by KnobPanel)
    in KnobPanel
    in div (created by Context.Consumer)
    in Styled(div)
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown
    in Unknown
    in Unknown (created by Context.Consumer)
    in _default (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Panel)
    in Panel (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in Main (created by Layout)
    in Layout (created by Context.Consumer)
    in WithTheme(Layout) (created by ResizeDetector)
    in ResizeDetector
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by ResizeDetector)
    in ResizeDetector
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root
warningWithoutStack @ vendors~main.c2014981fb34776cf713.bundle.js:129299
warning @ vendors~main.c2014981fb34776cf713.bundle.js:129714
createElementWithValidation @ vendors~main.c2014981fb34776cf713.bundle.js:130841
(anonymous) @ vendors~main.c2014981fb34776cf713.bundle.js:4666
renderWithHooks @ vendors~main.c2014981fb34776cf713.bundle.js:97120
mountIndeterminateComponent @ vendors~main.c2014981fb34776cf713.bundle.js:99202
beginWork @ vendors~main.c2014981fb34776cf713.bundle.js:99807
performUnitOfWork @ vendors~main.c2014981fb34776cf713.bundle.js:103494
workLoop @ vendors~main.c2014981fb34776cf713.bundle.js:103534
callCallback @ vendors~main.c2014981fb34776cf713.bundle.js:84377
invokeGuardedCallbackDev @ vendors~main.c2014981fb34776cf713.bundle.js:84427
invokeGuardedCallback @ vendors~main.c2014981fb34776cf713.bundle.js:84484
replayUnitOfWork @ vendors~main.c2014981fb34776cf713.bundle.js:102760
renderRoot @ vendors~main.c2014981fb34776cf713.bundle.js:103650
performWorkOnRoot @ vendors~main.c2014981fb34776cf713.bundle.js:104524
performWork @ vendors~main.c2014981fb34776cf713.bundle.js:104436
performSyncWork @ vendors~main.c2014981fb34776cf713.bundle.js:104410
interactiveUpdates$1 @ vendors~main.c2014981fb34776cf713.bundle.js:104677
interactiveUpdates @ vendors~main.c2014981fb34776cf713.bundle.js:86398
dispatchInteractiveEvent @ vendors~main.c2014981fb34776cf713.bundle.js:89110
vendors~main.c2014981fb34776cf713.bundle.js:84283 Uncaught Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
    at invariant (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:84283:15)
    at createFiberFromTypeAndProps (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:94420:11)
    at createFiberFromElement (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:94441:15)
    at reconcileSingleElement (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:96713:23)
    at reconcileChildFibers (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:96770:35)
    at reconcileChildren (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:98584:28)
    at mountIndeterminateComponent (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:99246:5)
    at beginWork (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:99807:16)
    at performUnitOfWork (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:103494:12)
    at workLoop (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:103534:24)
invariant @ vendors~main.c2014981fb34776cf713.bundle.js:84283
createFiberFromTypeAndProps @ vendors~main.c2014981fb34776cf713.bundle.js:94420
createFiberFromElement @ vendors~main.c2014981fb34776cf713.bundle.js:94441
reconcileSingleElement @ vendors~main.c2014981fb34776cf713.bundle.js:96713
reconcileChildFibers @ vendors~main.c2014981fb34776cf713.bundle.js:96770
reconcileChildren @ vendors~main.c2014981fb34776cf713.bundle.js:98584
mountIndeterminateComponent @ vendors~main.c2014981fb34776cf713.bundle.js:99246
beginWork @ vendors~main.c2014981fb34776cf713.bundle.js:99807
performUnitOfWork @ vendors~main.c2014981fb34776cf713.bundle.js:103494
workLoop @ vendors~main.c2014981fb34776cf713.bundle.js:103534
callCallback @ vendors~main.c2014981fb34776cf713.bundle.js:84377
invokeGuardedCallbackDev @ vendors~main.c2014981fb34776cf713.bundle.js:84427
invokeGuardedCallback @ vendors~main.c2014981fb34776cf713.bundle.js:84484
replayUnitOfWork @ vendors~main.c2014981fb34776cf713.bundle.js:102760
renderRoot @ vendors~main.c2014981fb34776cf713.bundle.js:103650
performWorkOnRoot @ vendors~main.c2014981fb34776cf713.bundle.js:104524
performWork @ vendors~main.c2014981fb34776cf713.bundle.js:104436
performSyncWork @ vendors~main.c2014981fb34776cf713.bundle.js:104410
interactiveUpdates$1 @ vendors~main.c2014981fb34776cf713.bundle.js:104677
interactiveUpdates @ vendors~main.c2014981fb34776cf713.bundle.js:86398
dispatchInteractiveEvent @ vendors~main.c2014981fb34776cf713.bundle.js:89110
vendors~main.c2014981fb34776cf713.bundle.js:101299 The above error occurred in one of your React components:
    in Unknown (created by Context.Consumer)
    in Styled(Component) (created by KnobPanel)
    in KnobPanel
    in div (created by Context.Consumer)
    in Styled(div)
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown
    in Unknown
    in Unknown (created by Context.Consumer)
    in _default (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Panel)
    in Panel (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in Main (created by Layout)
    in Layout (created by Context.Consumer)
    in WithTheme(Layout) (created by ResizeDetector)
    in ResizeDetector
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by ResizeDetector)
    in ResizeDetector
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root

React will try to recreate this component tree from scratch using the error boundary you provided, LocationProvider.
logCapturedError @ vendors~main.c2014981fb34776cf713.bundle.js:101299
logError @ vendors~main.c2014981fb34776cf713.bundle.js:101335
callback @ vendors~main.c2014981fb34776cf713.bundle.js:102276
callCallback @ vendors~main.c2014981fb34776cf713.bundle.js:100615
commitUpdateEffects @ vendors~main.c2014981fb34776cf713.bundle.js:100654
commitUpdateQueue @ vendors~main.c2014981fb34776cf713.bundle.js:100645
commitLifeCycles @ vendors~main.c2014981fb34776cf713.bundle.js:101546
commitAllLifeCycles @ vendors~main.c2014981fb34776cf713.bundle.js:102918
callCallback @ vendors~main.c2014981fb34776cf713.bundle.js:84377
invokeGuardedCallbackDev @ vendors~main.c2014981fb34776cf713.bundle.js:84427
invokeGuardedCallback @ vendors~main.c2014981fb34776cf713.bundle.js:84484
commitRoot @ vendors~main.c2014981fb34776cf713.bundle.js:103130
(anonymous) @ vendors~main.c2014981fb34776cf713.bundle.js:104600
unstable_runWithPriority @ vendors~main.c2014981fb34776cf713.bundle.js:135906
completeRoot @ vendors~main.c2014981fb34776cf713.bundle.js:104599
performWorkOnRoot @ vendors~main.c2014981fb34776cf713.bundle.js:104528
performWork @ vendors~main.c2014981fb34776cf713.bundle.js:104436
performSyncWork @ vendors~main.c2014981fb34776cf713.bundle.js:104410
interactiveUpdates$1 @ vendors~main.c2014981fb34776cf713.bundle.js:104677
interactiveUpdates @ vendors~main.c2014981fb34776cf713.bundle.js:86398
dispatchInteractiveEvent @ vendors~main.c2014981fb34776cf713.bundle.js:89110
vendors~main.c2014981fb34776cf713.bundle.js:84283 Uncaught Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
    at invariant (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:84283:15)
    at createFiberFromTypeAndProps (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:94420:11)
    at createFiberFromElement (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:94441:15)
    at reconcileSingleElement (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:96713:23)
    at reconcileChildFibers (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:96770:35)
    at reconcileChildren (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:98584:28)
    at mountIndeterminateComponent (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:99246:5)
    at beginWork (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:99807:16)
    at performUnitOfWork (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:103494:12)
    at workLoop (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:103534:24)
invariant @ vendors~main.c2014981fb34776cf713.bundle.js:84283
createFiberFromTypeAndProps @ vendors~main.c2014981fb34776cf713.bundle.js:94420
createFiberFromElement @ vendors~main.c2014981fb34776cf713.bundle.js:94441
reconcileSingleElement @ vendors~main.c2014981fb34776cf713.bundle.js:96713
reconcileChildFibers @ vendors~main.c2014981fb34776cf713.bundle.js:96770
reconcileChildren @ vendors~main.c2014981fb34776cf713.bundle.js:98584
mountIndeterminateComponent @ vendors~main.c2014981fb34776cf713.bundle.js:99246
beginWork @ vendors~main.c2014981fb34776cf713.bundle.js:99807
performUnitOfWork @ vendors~main.c2014981fb34776cf713.bundle.js:103494
workLoop @ vendors~main.c2014981fb34776cf713.bundle.js:103534
renderRoot @ vendors~main.c2014981fb34776cf713.bundle.js:103617
performWorkOnRoot @ vendors~main.c2014981fb34776cf713.bundle.js:104524
performWork @ vendors~main.c2014981fb34776cf713.bundle.js:104436
performSyncWork @ vendors~main.c2014981fb34776cf713.bundle.js:104410
interactiveUpdates$1 @ vendors~main.c2014981fb34776cf713.bundle.js:104677
interactiveUpdates @ vendors~main.c2014981fb34776cf713.bundle.js:86398
dispatchInteractiveEvent @ vendors~main.c2014981fb34776cf713.bundle.js:89110
vendors~main.c2014981fb34776cf713.bundle.js:101299 The above error occurred in the <LocationProvider> component:
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root

Consider adding an error boundary to your tree to customize error handling behavior.
 You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
    at invariant (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:84283:15)
    at createFiberFromTypeAndProps (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:94420:11)
    at createFiberFromElement (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:94441:15)
    at reconcileSingleElement (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:96713:23)
    at reconcileChildFibers (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:96770:35)
    at reconcileChildren (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:98584:28)
    at mountIndeterminateComponent (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:99246:5)
    at beginWork (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:99807:16)
    at performUnitOfWork (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:103494:12)
    at workLoop (http://localhost:6006/vendors~main.c2014981fb34776cf713.bundle.js:103534:24)
invariant @ vendors~main.c2014981fb34776cf713.bundle.js:84283
createFiberFromTypeAndProps @ vendors~main.c2014981fb34776cf713.bundle.js:94420
createFiberFromElement @ vendors~main.c2014981fb34776cf713.bundle.js:94441
reconcileSingleElement @ vendors~main.c2014981fb34776cf713.bundle.js:96713
reconcileChildFibers @ vendors~main.c2014981fb34776cf713.bundle.js:96770
reconcileChildren @ vendors~main.c2014981fb34776cf713.bundle.js:98584
mountIndeterminateComponent @ vendors~main.c2014981fb34776cf713.bundle.js:99246
beginWork @ vendors~main.c2014981fb34776cf713.bundle.js:99807
performUnitOfWork @ vendors~main.c2014981fb34776cf713.bundle.js:103494
workLoop @ vendors~main.c2014981fb34776cf713.bundle.js:103534
renderRoot @ vendors~main.c2014981fb34776cf713.bundle.js:103617
performWorkOnRoot @ vendors~main.c2014981fb34776cf713.bundle.js:104524
performWork @ vendors~main.c2014981fb34776cf713.bundle.js:104436
performSyncWork @ vendors~main.c2014981fb34776cf713.bundle.js:104410
interactiveUpdates$1 @ vendors~main.c2014981fb34776cf713.bundle.js:104677
interactiveUpdates @ vendors~main.c2014981fb34776cf713.bundle.js:86398
dispatchInteractiveEvent @ vendors~main.c2014981fb34776cf713.bundle.js:89110

@kristremblay Hmm try clearing out node_modules and reinstalling?

@shilman No luck, same errors.

Have you tried deleting your package.lock file?
On Tue, Mar 12, 2019 at 8:38 PM Kris Tremblay<EMAIL_ADDRESS>wrote:

@shilman https://github.com/shilman No luck, same errors.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/storybooks/storybook/issues/6005#issuecomment-472234504,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcYoBiAfAV30ulIrrAmzekbJ5X8EfScMks5vWEhsgaJpZM4bnfUw
.

Yup, still busted.

I’ll have to double check when I get home in a few hours.
Reverting to 5.0.x works (with 5.0.0 being the best one as far as the debounce issue is concerned).
I really appreciate the responsiveness, I just wanna see it work :D

Same error after upgrade to alpha5.
Folder node_modules was deleted.
Story without knobs working fine, crashing only on story with knobs.
(Vue project created with vue cli and vue cli storybook)
In package.json:
"@storybook/vue": "^v5.1.0-alpha.5",
"@storybook/addons": "^v5.1.0-alpha.5",
"@storybook/addon-actions": "^v5.1.0-alpha.5",
"@storybook/addon-cssresources": "^v5.1.0-alpha.5",
"@storybook/addon-knobs": "v5.1.0-alpha.5",
"@storybook/addon-links": "^v5.1.0-alpha.5",
"@storybook/addon-notes": "^v5.1.0-alpha.5",
"@storybook/addon-storysource": "^v5.1.0-alpha.5",

@shilman
@Nejik beat me to it. This is what I’m experiencing.

Jeepers creepers!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.2 containing PR #6022 that references this issue. Upgrade today to try it out!

since the 4.2 alpha introduced my changes to the storybook vue, debouncing the knobs should not be necessary at all for vue, since we properly change the props of the components in a reactive "vue way".

General note:
Debounce can be necessary on systems with poorly functioning keyboards (not that macbooks have ever had anything other than perfect keyboards).
However, debounce should, by default, only take effect for quickly repeated instances of the same character.


Add earth theme

Link to Ticket
Description of Changes Made
Adds the earth colour theme
Updates the styleguide so that both the styleguide and typography pages use the theme switcher
How to Test

Edit any page in a local build and change the theme to 'earth', and then view
Use the colour switcher in http://localhost:8000/pattern-library/render-pattern/patterns/styleguide/typography/typography.html and http://localhost:8000/pattern-library/render-pattern/patterns/styleguide/components/components.html to select the earth theme

Screenshots

Expand to see more

MR Checklist

[ ] Add a description of your pull request and instructions for the reviewer to verify your work.
[ ] If your pull request is for a specific ticket, link to it in the description.
[ ] Stay on point and keep it small so the merge request can be easily reviewed.
[ ] Tests and linting passes.

Unit tests

[ ] Added
[ ] Not required

Documentation

[ ] Updated build docs
[ ] Updated editor guidelines (https://docs.google.com/document/d/1PAWccdQ4tfaZsrEWmpDhvP3GH5RRmBOARFVp4b-kje8/edit?usp=sharing)
[ ] Updated field spec (https://docs.google.com/spreadsheets/d/1v1yqcSC54Vag4mxmTp8e6ZrnxITqzbjCA4A9XPQdXk8/edit?usp=sharing)
[ ] Not required

Browser testing

[ ] I have tested in the following browsers and environments (edit the list as required)

Latest version of Chrome on mac
Latest version of Firefox on mac
Latest version of Safari on mac
Safari on last two versions of iOS
Chrome on last two versions of Android

[ ] Not required

Data protection

[ ] Not relevant
[ ] This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Accessibility

[ ] Automated WCAG 2.1 tests pass
[ ] HTML validation passes
[ ] Manual WCAG 2.1 tests completed
[ ] I have tested in a screen reader
[ ] I have tested in high-contrast mode
[ ] Any animations removed for prefers-reduced-motion
[ ] Not required

Sustainability

[ ] Images are optimised and lazy-loading used where appropriate
[ ] SVGs have been optimised
[ ] Perfomance and transfer of data considered
[ ] If JavaScript is needed alternatives have been considered
[ ] Not required

Pattern library

[ ] The pattern library component for this template displays correctly, and does not break parent templates
[ ] The styleguide is updated if relevant
[ ] Changes are not relevant the pattern library

Thanks @helenb. I tested the following pages locally and can't find any issues:

Home
Blog index page
Blog
Event index
Impact report page
Person index page
Person
Service
Standard page
Work index page

I couldn't find or add an Event page - I guess this is because they link off to external urls?
Two things I did spot and are not related to this MR:

It might be worth setting a negative outline-offset on the main nav items on mobile - currently you can't see the left or right side of the lines:

Before

After

We're not showing the custom focus ring on the logos in the footer:

Screen

Wasn't sure if that was intentional or not.
Anyway, not ones to cover in this MR but thought they were wort flagging. Everything else here looks great though!


PHP#GRPC Failed to receive large data, Prompt Stream removed

I use Swoole as the GRPC server.  I requested the Swoole server using the GRPC extension。
If I request less than 200 items of data can return normally。If an exception occurs when I request more than 200 items of data, throw。
{
    "metadata": [],
    "code": 2,
    "details": "Stream removed"
}

My environment is following:
Linux 10-devenvapplication-ubuntu20-<IP_ADDRESS> 5.4.0-73-generic #82-Ubuntu SMP Wed Apr 14 17:39:42 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
PHP 7.3.26-1+ubuntu20.04.1+deb.sury.org+1 (cli) (built: Jan 13 2021 08:01:31) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.26, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.26-1+ubuntu20.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies

client grpc

grpc support => enabled
grpc module version => 1.38.0

Directive => Local Value => Master Value
grpc.enable_fork_support => 0 => 0
grpc.poll_strategy => no value => no value
grpc.grpc_verbosity => no value => no value
grpc.grpc_trace => no value => no value
grpc.log_filename => no value => no value

server swoole

Swoole => enabled
Author => Swoole Team<EMAIL_ADDRESS>Version => 4.6.7
Built => Jul  5 2021 01:12:10
coroutine => enabled with boost asm context
epoll => enabled
eventfd => enabled
signalfd => enabled
spinlock => enabled
rwlock => enabled
openssl => OpenSSL 1.1.1k  25 Mar 2021
dtls => enabled
http2 => enabled
json => enabled
curl-native => enabled
pcre => enabled
zlib => 1.2.11
mutex_timedlock => enabled
pthread_barrier => enabled
async_redis => enabled

Directive => Local Value => Master Value
swoole.enable_coroutine => On => On
swoole.enable_library => On => On
swoole.enable_preemptive_scheduler => Off => Off
swoole.display_errors => On => On
swoole.use_shortname => Off => Off
swoole.unixsock_buffer_size => 8388608 => 8388608

I have no problem using the Swoole client to call the Swoole server。 How can I handle it?

swoole have fixed it.
FYI: https://github.com/swoole/swoole-src/pull/4394
https://github.com/hyperf/hyperf/issues/4006#issuecomment-914167667


Refactor map demo

Refactor map demo to the new OBEX stack

GetFolderListing, GetMessageListing, and GetMessage is working now (tested on Android phone).
However, the GetMessage call inside MNS_Listener_ConnectionReceived will not receive any response.
https://github.com/BestOwl/MyPhone/blob/dd28a43e3b7972a5088130628bb35dd7204b13f5/MyPhone.Demo/MapClient.cs#L528-L538
I checked the device log of my Android phone, it shows that the phone already send a response back. Not sure what went wrong.
@xtremehpx can you help me to check that out?

@xtremehpx I invited you to become a collaborator of this repo. It would be great if you can push subsequent changes directly to this repo.

GetFolderListing, GetMessageListing, and GetMessage is working now (tested on Android phone).
However, the GetMessage call inside MNS_Listener_ConnectionReceived will not receive any response.
https://github.com/BestOwl/MyPhone/blob/dd28a43e3b7972a5088130628bb35dd7204b13f5/MyPhone.Demo/MapClient.cs#L528-L538
I checked the device log of my Android phone, it shows that the phone already send a response back. Not sure what went wrong.
@xtremehpx can you help me to check that out?

I'm actually having similar issue. But in my case the requested message packet is returned from Phone but not back to the calling function. I will pull your branch and see what I can find.

I fixed this. But I cannot push the code and create PR?

What do you mean by saying you cannnot push the code and create PR? If you accept the invitation, you can directly push to this repo.

never mind, I created a new PR. Please check.

What do you mean by saying you cannnot push the code and create PR? If you accept the invitation, you can directly push to this repo.

somehow I don't see the invitation anymore, can you please send again?

What do you mean by saying you cannnot push the code and create PR? If you accept the invitation, you can directly push to this repo.

somehow I don't see the invitation anymore, can you please send again?

https://github.com/BestOwl/MyPhone/invitations

Thanks. Accepted the invitation. I updated PR to merge into the "xtremehpx/refactor-map-demo" branch. Please review the changes.

The notification problem has been resolved!

The notification problem has been resolved!

This is great. I will pull and check it out. BTW, a quick glance at the code, I only see the RequestQueue been used to queue the handle, but never been consumed? is the code complete?