Change Either[A, B] encoding and decoding to unwrap the Either

I'm decoding & encoding json-api with circe (nice lib btw - love that I can use it in ScalaJS) and I've found that json-api has keys that can be one of two types, so I'm representing that as an Either in Scala.
My observation would be that you almost never see json of the form "Left": {"value": "someval" } so the current default behaviour is nearly always not what is wanted.
I've written the following encoder/decoder pair to unwrap/wrap the values in an Either:
  implicit def encodeEither[A, B](implicit
    encoderA: Encoder[A],
    encoderB: Encoder[B]
  ): Encoder[Either[A, B]] = {
    o: Either[A, B] =>
      o.fold(_.asJson, _.asJson)
  }

  implicit def decodeEither[A, B](implicit
    decoderA: Decoder[A],
    decoderB: Decoder[B]
  ): Decoder[Either[A, B]] = {
    c: HCursor =>
      c.as[A] match {
        case Right(a) => Right(Left(a))
        case _ => c.as[B].map(Right(_))
      }
  }

Would there be any love for me submitting this as a pull request?

This doesn't work right for Either[T, T] or other cases where you can deserialise the serialised version of B as a valid A.

As @jurisk points out, the issue here is that we try to avoid instances that don't round-trip values in circe, and using this encoding of Either introduces the possibility of ambiguity.
There are a few possible solutions here. One is to define custom instances as you have, although note that the decoding side can be made more concise:
implicit def decodeEither[A, B](implicit
    decoderA: Decoder[A],
    decoderB: Decoder[B]
  ): Decoder[Either[A, B]] = decoderA.either(decoderB)

Another approach would be to use Shapeless's coproducts (unlabeled) and circe-shapes:
scala> import io.circe.jawn.decode, io.circe.shapes._, shapeless._
import io.circe.jawn.decode
import io.circe.shapes._
import shapeless._

scala> decode[String :+: Int :+: CNil]("1")
res1: Either[io.circe.Error,String :+: Int :+: shapeless.CNil] = Right(Inr(Inl(1)))

scala> decode[String :+: Int :+: CNil](""""a"""")
res2: Either[io.circe.Error,String :+: Int :+: shapeless.CNil] = Right(Inl(a))

I guess we could provide something like a io.circe.disjunctionCodecs.untagged for this case—I'll think about it.


Bug report: dwarf-fortress installation fails

General troubleshooting steps

[x] I have checked the instructions for reporting bugs (or making requests) before opening the issue.

[x] None of the templates was appropriate for my issue, or I’m not sure.

[x] I ran brew update-reset && brew update and retried my command.
[x] I ran brew doctor, fixed as many issues as possible and retried my command.
[x] I understand that if I ignore these instructions, my issue may be closed without review.

Description of issue
I had the old home-brew version of dwarf-fortress installed (not cask) and tried to 'upgrade' to cask version; I got no errors on upgrading but it would not run (complained about SDL errors).  So I completely removed it and tried to install fresh from cask instead (and got this error).  It seems to be trying to back up my saves even though I don't have any since the game isn't installed yet...
Output of your command with --verbose --debug
==> Hbc::Installer#install
==> Printing caveats
==> Caveats
During uninstall, your save data will be copied to /tmp/dwarf-fortress-save

==> Hbc::Installer#fetch
==> Satisfying dependencies
==> Installing Cask dependencies: sdl-framework, sdl-ttf-framework
sdl-framework ...
already installed
sdl-ttf-framework ...
already installed
complete
==> Downloading
==> Downloading http://www.bay12games.com/dwarves/df_43_05_osx.tar.bz2
Already downloaded: /Users/sandlst/Library/Caches/Homebrew/Cask/dwarf-fortress--0.43.05.tar.bz2
==> Downloaded to -> /Users/sandlst/Library/Caches/Homebrew/Cask/dwarf-fortress--0.43.05.tar.bz2
==> Verifying download
==> Determining which verifications to run for Cask dwarf-fortress
==> Checking for verification class Hbc::Verify::Checksum
==> 1 verifications defined
Hbc::Verify::Checksum
==> Running verification of class Hbc::Verify::Checksum
==> Verifying checksum for Cask dwarf-fortress
==> SHA256 checksums match
==> Hbc::Installer#stage
==> Extracting primary container
==> Determining which containers to use based on filetype
==> Checking container class Hbc::Container::Pkg
==> Checking container class Hbc::Container::Ttf
==> Checking container class Hbc::Container::Otf
==> Checking container class Hbc::Container::Air
==> Checking container class Hbc::Container::Cab
==> Checking container class Hbc::Container::Dmg
==> Executing: ["/usr/bin/hdiutil", "imageinfo", "/Users/sandlst/Library/Caches/Homebrew/Cask/dwarf-fortress--0.43.05.tar.bz2"]
==> Checking container class Hbc::Container::SevenZip
==> Checking container class Hbc::Container::Sit
==> Checking container class Hbc::Container::Rar
==> Checking container class Hbc::Container::Zip
==> Checking container class Hbc::Container::Xar
==> Checking container class Hbc::Container::Tar
==> Using container class Hbc::Container::Tar for /Users/sandlst/Library/Caches/Homebrew/Cask/dwarf-fortress--0.43.05.tar.bz2
==> Executing: ["/usr/bin/tar", "-x", "-f", "/Users/sandlst/Library/Caches/Homebrew/Cask/dwarf-fortress--0.43.05.tar.bz2", "-C", "/var/folders/9k/trvx5bm93xg9cb06227fbnxh0000gn/T/d20170403-9557-ol3u5w"]
==> Executing: ["/usr/bin/ditto", "--", "/var/folders/9k/trvx5bm93xg9cb06227fbnxh0000gn/T/d20170403-9557-ol3u5w", "/usr/local/Caskroom/dwarf-fortress/0.43.05"]
==> Creating metadata directory /usr/local/Caskroom/dwarf-fortress/.metadata/0.43.05/20170403153417.301
==> Creating metadata subdirectory /usr/local/Caskroom/dwarf-fortress/.metadata/0.43.05/20170403153417.301/Casks
==> Installing artifacts
==> Determining which artifacts are present in Cask dwarf-fortress
==> 3 artifact/s defined
#<Hbc::Artifact::PreflightBlock:0x007fb0a5289350>
#<Hbc::Artifact::Binary:0x007fb0a5289210>
#<Hbc::Artifact::PostflightBlock:0x007fb0a52890d0>
==> Installing artifact of class Hbc::Artifact::PreflightBlock
==> Installing artifact of class Hbc::Artifact::Binary
==> Linking Binary 'df.wrapper.sh' to '/usr/local/bin/dwarf-fortress'.
==> Executing: ["/bin/ln", "-h", "-f", "-s", "--", "/usr/local/Caskroom/dwarf-fortress/0.43.05/df_osx/df.wrapper.sh", "/usr/local/bin/dwarf-fortress"]
==> Adding com.apple.metadata:kMDItemAlternateNames metadata
==> Executing: ["/usr/bin/xattr", "-p", "com.apple.metadata:kMDItemAlternateNames", "/usr/local/Caskroom/dwarf-fortress/0.43.05/df_osx/df.wrapper.sh"]
==> Existing metadata is: ''
==> Executing: ["/bin/chmod", "--", "u+rw", "/usr/local/Caskroom/dwarf-fortress/0.43.05/df_osx/df.wrapper.sh", "/usr/local/Caskroom/dwarf-fortress/0.43.05/df_osx/df.wrapper.sh"]
==> Executing: ["/usr/bin/xattr", "-w", "com.apple.metadata:kMDItemAlternateNames", "(\\\"dwarf-fortress\\\")", "/usr/local/Caskroom/dwarf-fortress/0.43.05/df_osx/df.wrapper.sh"]
==> Installing artifact of class Hbc::Artifact::PostflightBlock
==> Reverting installation of artifact of class Hbc::Artifact::Binary
==> Unlinking Binary '/usr/local/bin/dwarf-fortress'.
==> Reverting installation of artifact of class Hbc::Artifact::PreflightBlock
==> Executing: ["/bin/cp", "-rf", "/usr/local/Caskroom/dwarf-fortress/0.43.05/df_osx/data/save", "/tmp/dwarf-fortress-save/"]
==> cp: directory /tmp/dwarf-fortress-save does not exist
==> Purging files for version 0.43.05 of Cask dwarf-fortress
Error: private method `load' called for Hbc:Module
Follow the instructions here:
  https://github.com/caskroom/homebrew-cask#reporting-bugs
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cask_loader.rb:39:in `block (4 levels) in load'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cask_loader.rb:36:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cask_loader.rb:36:in `block (3 levels) in load'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cask_loader.rb:32:in `chdir'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cask_loader.rb:32:in `block (2 levels) in load'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/abstract_flight_block.rb:35:in `instance_eval'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/abstract_flight_block.rb:35:in `block in abstract_phase'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/set.rb:232:in `each_key'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/set.rb:232:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/abstract_flight_block.rb:34:in `abstract_phase'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/abstract_flight_block.rb:24:in `install_phase'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:144:in `block in install_artifacts'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:141:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:141:in `install_artifacts'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:87:in `install'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:25:in `block in install_casks'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:19:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:19:in `install_casks'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:10:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:115:in `run_command'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:158:in `process'
/usr/local/Homebrew/Library/Homebrew/cmd/cask.rb:8:in `cask'
/usr/local/Homebrew/Library/Homebrew/brew.rb:91:in `<main>'
Error: Kernel.exit
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:169:in `exit'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:169:in `rescue in process'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:149:in `process'
/usr/local/Homebrew/Library/Homebrew/cmd/cask.rb:8:in `cask'
/usr/local/Homebrew/Library/Homebrew/brew.rb:91:in `<main>'

Output of brew cask doctor
==> Homebrew-Cask Version
Homebrew-Cask 1.1.12-2-g5ab904ed
caskroom/homebrew-cask (git revision 7ccc4; last commit 2017-04-03)
==> Homebrew-Cask Install Location
<NONE>
==> Homebrew-Cask Staging Location
/usr/local/Caskroom
==> Homebrew-Cask Cached Downloads
~/Library/Caches/Homebrew/Cask (2 files, 155.1MB)
==> Homebrew-Cask Taps:
/usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask (3630 casks)
/usr/local/Homebrew/Library/Taps/cartr/homebrew-qt4 (0 casks)
/usr/local/Homebrew/Library/Taps/goldcaddy77/homebrew-firefox (16 casks)
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-bundle (0 casks)
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-command-not-found (0 casks)
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core (0 casks)
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-dupes (0 casks)
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-fuse (0 casks)
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-games (0 casks)
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-versions (0 casks)
==> Contents of $LOAD_PATH
/usr/local/Homebrew/Library/Homebrew/cask/lib
/usr/local/Homebrew/Library/Homebrew
/Library/Ruby/Site/2.0.0
/Library/Ruby/Site/2.0.0/x86_64-darwin16
/Library/Ruby/Site/2.0.0/universal-darwin16
/Library/Ruby/Site
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0/x86_64-darwin16
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0/universal-darwin16
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/x86_64-darwin16
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/universal-darwin16
==> Environment Variables
LANG="en_US.UTF-8"
PATH="~/Qt5.5.1/5.5/clang_64/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/share/dotnet:/Library/Frameworks/Mono.framework/Versions/Current/Commands:~/.bin:/usr/local/Homebrew/Library/Taps/homebrew/homebrew-bundle/cmd:/usr/local/Homebrew/Library/Taps/homebrew/homebrew-command-not-found/cmd:/usr/local/Homebrew/Library/Homebrew/shims/scm"
SHELL="/usr/local/bin/zsh"

Verified:
-bash-4.4.12- /Users/miccal [> brew cask install dwarf-fortress
==> Caveats
During uninstall, your save data will be copied to /tmp/dwarf-fortress-save

==> Satisfying dependencies
==> Installing Cask dependencies: sdl-framework, sdl-ttf-framework
sdl-framework ...
==> Downloading https://www.libsdl.org/release/SDL2-2.0.5.dmg
######################################################################## 100.0%
==> Verifying checksum for Cask sdl-framework
🍺  sdl-framework was successfully installed!
done
sdl-ttf-framework ...
==> Downloading https://www.libsdl.org/projects/SDL_ttf/release/SDL_ttf-2.0.11.dmg
######################################################################## 100.0%
==> Verifying checksum for Cask sdl-ttf-framework
🍺  sdl-ttf-framework was successfully installed!
done
complete
==> Downloading http://www.bay12games.com/dwarves/df_43_05_osx.tar.bz2
Already downloaded: /Users/miccal/Library/Caches/Homebrew/Cask/dwarf-fortress--0.43.05.tar.bz2
==> Verifying checksum for Cask dwarf-fortress
==> Linking Binary 'df.wrapper.sh' to '/usr/local/bin/dwarf-fortress'.
==> Unlinking Binary '/usr/local/bin/dwarf-fortress'.
==> cp: directory /tmp/dwarf-fortress-save does not exist
Error: private method `load' called for Hbc:Module
Follow the instructions here:
  https://github.com/caskroom/homebrew-cask#reporting-bugs
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cask_loader.rb:39:in `block (4 levels) in load'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cask_loader.rb:36:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cask_loader.rb:36:in `block (3 levels) in load'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cask_loader.rb:32:in `chdir'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cask_loader.rb:32:in `block (2 levels) in load'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/abstract_flight_block.rb:35:in `instance_eval'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/abstract_flight_block.rb:35:in `block in abstract_phase'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/set.rb:232:in `each_key'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/set.rb:232:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/abstract_flight_block.rb:34:in `abstract_phase'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/abstract_flight_block.rb:24:in `install_phase'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:144:in `block in install_artifacts'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:141:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:141:in `install_artifacts'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:87:in `install'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:25:in `block in install_casks'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:19:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:19:in `install_casks'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:10:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:115:in `run_command'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:158:in `process'
/usr/local/Homebrew/Library/Homebrew/cmd/cask.rb:8:in `cask'
/usr/local/Homebrew/Library/Homebrew/brew.rb:91:in `<main>'

Pinging @brewingcode.

Will be fixed in https://github.com/caskroom/homebrew-cask/pull/31856.

@vitorgalvao This bug is due to the /tmp/dwarf-fortress-save directory not existing when cp tries to copy to it. I saw caskroom/homebrew-cask#31862 to fix this, and I think a good addition to that PR would be and additional mkdir -p command:
 uninstall_preflight do
+    system_command '/bin/mkdir', args: ['-p', '/tmp/dwarf-fortress-save']
-    system_command '/bin/cp', args: ['-rf', "#{staged_path}/df_osx/data/save", '/tmp/dwarf-fortress-save/']
+    system_command '/bin/cp', args: ['-rf', "#{staged_path}/df_osx/data/save", '/tmp/dwarf-fortress-save/'] if File.exist?("#{staged_path}/df_osx/data/save")

This bug is due to the /tmp/dwarf-fortress-save directory not existing when cp tries to copy to it.

That is incorrect. That copy only tries to happen at uninstall time, so it has no bearing on installation. What happens is that Hbc.load in the postflight is no longer valid (needs to be Hbc::CaskLoader.load) and as such fails. When it does, the casks tries to reverse the installation, which is why that copy is tried at all.
In addition, creating the directory on purpose just so it can be moved is a weird solution. It’s best to just check first if it exists and only try to copy it in that case.
As mentioned, I already have an open PR that fixes those issue.

Whoops, right you are.
Thanks for fixing it. :)

Forgot to mention that for anyone in a hurry, brew cask install https://raw.githubusercontent.com/caskroom/homebrew-cask/297ca740ec0b42fcbf7e6deb8528875e88cd1780/Casks/dwarf-fortress.rb will get you setup.


Management blueprint; add kptfile and use workload identity mode for CNRM

management/instance needs a Kptfile to work with the latest versions of kpt

Per #13 we don't want to run CNRM in namespace mode because this burdensome
instead we use workload identity mode; i.e. the same GCP sa to administer
multiple projects.

Related to #13 - Use workload identity mode
Related to kubeflow/gcp-blueprints#102 Fix blueprint

Remove cluster and nodepool patches from instance; we aren't actually patching anything.

/assign @Bobgy

/lgtm
/approve


question about exercise 12 in chapter 12

Hi,
I have a bit of a more general question related to exercise 12 in chapter 12 "Implement a custom layer that performs Layer Normalization": from the code it is not clear whether layer normalization computes running averages to be used at test time the way batch normalization does? Does layer normalization uses running averages at all?
Thank you,
Denise

Hi @deniseduma ,
Good question! No, Layer Normalization does not use any running averages. It just normalizes across each instance's features. This can be done in exactly the same way during training and during inference.
In contrast, Batch Normalization normalizes across the instances in a batch. Imagine if Batch Normalization worked in exactly the same way during training and during inference, by just normalizing each feature over the batch (independently of the other features). This model would not be very reliable during inference, especially if you made predictions on a small batch (since the mean and variance would only be estimated on few instances). And the math equations would even break down entirely if you tried to make a prediction for a single instance (since there would be no variance). This is why we need slightly different equations during training and during inference for Batch Normalization. But this problem does not exist for Layer Normalization, which is why it's the same equations during training and inference.
I hope this helps.

Very helpful explanation, thank you very much!


Outdated MIME type for Javascript

Hi Team!
Angie packages contain a MIME types map and, basing on IANA Media Types, it's outdated at least in regard of Javascript.

https://trac.nginx.org/nginx/ticket/1407


[Snyk] Security upgrade ch.qos.logback:logback-classic from 1.2.3 to 1.2.13

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

641/1000  Why? Recently disclosed, Has a fix available, CVSS 7.1
Denial of Service (DoS) SNYK-JAVA-CHQOSLOGBACK-6094942
ch.qos.logback:logback-classic:  1.2.3 -> 1.2.13
No
No Known Exploit

641/1000  Why? Recently disclosed, Has a fix available, CVSS 7.1
Denial of Service (DoS) SNYK-JAVA-CHQOSLOGBACK-6094943
ch.qos.logback:logback-classic:  1.2.3 -> 1.2.13
No
No Known Exploit

641/1000  Why? Recently disclosed, Has a fix available, CVSS 7.1
Uncontrolled Resource Consumption ('Resource Exhaustion') SNYK-JAVA-CHQOSLOGBACK-6097492
ch.qos.logback:logback-classic:  1.2.3 -> 1.2.13
No
No Known Exploit

641/1000  Why? Recently disclosed, Has a fix available, CVSS 7.1
Uncontrolled Resource Consumption ('Resource Exhaustion') SNYK-JAVA-CHQOSLOGBACK-6097493
ch.qos.logback:logback-classic:  1.2.3 -> 1.2.13
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

Are we giving this integration a pass on DCO?


Test story

User Story

[ ] Have to add a function in the Compliance pipeline
[ ] Add a logic to find the nodeid in ES
[ ] Implement a function to insert the data to E

Acceptance Criteria

This should have this api working with these inputs.
Should produce this output

Implementation Details

In this file, add this function.

Definition of Done

All things specified in User Story Acceptance Criteria should be fulfilled.
All Exceptions are Handled Properly
Ensure logs have no unnecessary data.
Test coverage for the new feature is done to at least 70%
If needed raise Docs PR and tag documentation.
Swagger Documentation updated
Smoke Test done.
Ensure Build and Integration Pipelines are Green.
PR has 2 approvers.
All Code Review Comments are Resolved.
README doc should be updated, if needed.

This was a test story


RISC-V: Fix system crash when FPU is in use

FPU registers need to be written prior to updating CSR_STATUS
Summary
Fixes full system crash due to illegal instruction when accessing FPU when it is too late
Impact
Fixes system crash
Testing
icicle:nsh and icicle:knsh, ostest fails at once prior fix, passes with fix

@pussuw
I noticed that fpu_test with rv-virt:nsh64 on QEMU failed.
If I revert this PR, it works.
$ ~/opensource/QEMU/qemu-6.2/build/riscv64-softmmu/qemu-system-riscv64 -nographic -cpu rv64 -smp 8 -M virt -bios none -kernel ./nuttx
user_main: FPU test
Starting task FPU#1
fpu_test: Started task FPU#1 at PID=4
riscv_exception: EXCEPTION: Illegal instruction. MCAUSE:<PHONE_NUMBER>000002
riscv_exception: PANIC!!!  I get an immediate crash due to illegal instruction if this patch is not in place, so the exact opposite behavior to yours.

@masayuki2009 I am not able to reproduce on hardware (mpfs icicle:nsh):
user_main: FPU test
Starting task FPU#1
fpu_test: Started task FPU#1 at PID=6
FPU#1: pass 1
Starting task FPU#2
fpu_test: Started task FPU#2 at PID=7
FPU#2: pass 1
FPU#1: pass 2
FPU#2: pass 2
FPU#1: pass 3
FPU#2: pass 3
FPU#1: pass 4
FPU#2: pass 4
FPU#1: pass 5
FPU#2: pass 5
FPU#1: pass 6
FPU#2: pass 6
FPU#1: pass 7
FPU#2: pass 7
FPU#1: pass 8
FPU#2: pass 8
FPU#1: pass 9
FPU#2: pass 9
FPU#1: pass 10
FPU#2: pass 10
FPU#1: pass 11
FPU#2: pass 11
FPU#1: pass 12
FPU#2: pass 12
FPU#1: pass 13
FPU#2: pass 13
FPU#1: pass 14
FPU#2: pass 14
FPU#1: pass 15
FPU#2: pass 15
FPU#1: pass 16
FPU#2: pass 16
FPU#1: Succeeded
FPU#2: Succeeded
fpu_test: Returning

user_main: Exiting
ostest_main: Exiting with status 0
nsh>

I'm wondering if this is somehow related:
https://github.com/apache/incubator-nuttx/pull/6125
This PR:
https://github.com/apache/incubator-nuttx/pull/6101
Changed the order in which FPU and CSR_STATUS are restored, 6134 (this PR) basically just restores the original ordering. In my case, without 6134 the system crashes totally randomly, not even necessarily during the FPU test. With 6134 I don't get crashes and FPU test also works fine.

@masayuki2009 I am not able to reproduce on hardware (mpfs icicle:nsh):

@pussuw
I confirmed that maix-bit:smp works on real hardware.
nsh> uname -a
NuttX 10.3.0-RC0 aaa5316235 Apr 26 2022 17:30:16 risc-v maix-bit
nsh> mount
  /proc type procfs
nsh> ps
  PID GROUP CPU PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK   STACK   USED  FILLED COMMAND
    0     0   0   0 FIFO     Kthread N-- Assigned           00000000<PHONE_NUMBER>72  53.6%  CPU0 IDLE
    1     1   1   0 FIFO     Kthread N-- Running            00000000<PHONE_NUMBER>92  29.6%  CPU1 IDLE
    2     2   0 100 RR       Task    --- Running            00000000<PHONE_NUMBER>56  74.2%  nsh_main
nsh> free
                   total       used       free    largest  nused  nfree
        Umem:    2079920      11984    2067936    2067936     38      1

...

nsh> ostest
stdio_test: write fd=1
stdio_test: Standard I/O Check: printf
stdio_test: write fd=2
stdio_test: Standard I/O Check: fprintf to stderr
ostest_main: putenv(Variable1=BadValue3)
ostest_main: setenv(Variable1, GoodValue1, TRUE)
ostest_main: setenv(Variable2, BadValue1, FALSE)
ostest_main: setenv(Variable2, GoodValue2, TRUE)
ostest_main: setenv(Variable3, Variable3, FALSE)
ostest_main: setenv(Variable3, Variable3, FALSE)
show_variable: Variable=Variable1 has value=GoodValue1
show_variable: Variable=Variable2 has value=GoodValue2
show_variable: Variable=Variable3 has value=GoodValue3
ostest_main: Started user_main at PID=24
...

user_main: FPU test
Starting task FPU#1
FPU#1: pass 1
fpu_test: Started task FPU#1 at PID=25
Starting task FPU#2
FPU#2: pass 1
fpu_test: Started task FPU#2 at PID=26
FPU#1: pass 2
FPU#2: pass 2
FPU#1: pass 3
FPU#2: pass 3
FPU#1: pass 4
FPU#2: pass 4
FPU#1: pass 5
FPU#2: pass 5
FPU#1: pass 6
FPU#2: pass 6
FPU#1: pass 7
FPU#2: pass 7
FPU#1: pass 8
FPU#2: pass 8
FPU#1: pass 9
FPU#2: pass 9
FPU#1: pass 10
FPU#2: pass 10
FPU#1: pass 11
FPU#2: pass 11
FPU#1: pass 12
FPU#2: pass 12
FPU#1: pass 13
FPU#2: pass 13
FPU#1: pass 14
FPU#2: pass 14
FPU#1: pass 15
FPU#2: pass 15
FPU#1: pass 16
FPU#2: pass 16
FPU#1: Succeeded
FPU#2: Succeeded
fpu_test: Returning

....

So the issue might only happen with rv-virt:nsh64 on QEMU.

I have never used any emulated environment so obviously I did not notice this issue. I ran several tests with FPU enabled/disabled and with flat/protected mode, and both work with this patch, but at least protected mode fails randomly without.
I'll continue monitoring this.

@pussuw

I confirmed that maix-bit:smp works on real hardware.

I noticed that fpu_test works ** without ** this PR on maix-bit (real hardware).
So I think that something is wrong with your icicle.

@masayuki2009
I also did testing on icicle:nsh (BUILD_FLAT) and it works with and without this patch.
However, with icicle:knsh (BUILD_PROTECTED) the issue is 100% reproducible. FPU gets enabled, but ostest does not run fpu_test as it only compiles with build flat. With knsh, the system crashes at random locations during ostest, which has never completed successfully without this patch, and I have not seen an error *with this patch.
The way I found this (potential) issue, is by bisecting:
5b6dd876b87196cc82dd45258d77e22d0c8b033b <- good commit (risc-v/riscv_assert.c Fix dumping of status from ISR)
c29a3b7bd89c45d3781133679ae875e0e835bdd4 <- bad commit (pipe: Increase buffer size by one byte to ompensate the full indicator)
So somewhere between those two commits there is an issue.
48b81bda0904a426360fa809fd747e3966d29024 <- (arch/risc-v: Change riscv_savefpu/riscv_loadfpu to macro) by partially reverting this commit the crash goes away. The partial revert is to move loadfpu back to where it was prior to 48b8...
So this is how I made this patch. Of course there can be some other issue and I just masked it with this patch. One clear candidate can be riscv_get_newintctx(), because ostest creates / destroys new tasks for certain tests

@masayuki2009 It has been a while but I was revisiting the context saving code and remembered you had an issue with FPU on QEMU. I found at least one issue, that might be the cause for my crashes:
The int/fpu register restoration ordering in exception_common:
  load_ctx   sp
  riscv_loadfpu sp

is bad, because riscv_loadfpu uses registers t0,t1,t2
.macro riscv_loadfpu out

#ifdef CONFIG_ARCH_FPU
  REGLOAD      t0, REG_INT_CTX(\out)
  li           t1, MSTATUS_FS
  and          t2, t0, t1
  li           t1, MSTATUS_FS_INIT
  ble          t2, t1, skip_load_fpu

So the bad ordering restores the original integer registers including t0,t1,t2, and then these are immediately destroyed by riscv_loadfpu.
One potential fix would be use the "bad" ordering above, but to restore t0,t1,t2 from the context after the FPU context is restored:
skip_load_fpu:
... restore t0,t1,t2

I will try this again when I have time, but if you ever get the urge to get FPU working on QEMU this might be a potential fix.


Web bluetooth pairing acting up (DC)

Hello dear Darthcloud. I'd like to bring up a weird issue. The story so far: I've done a DC internal mod according to this guide:

I pair ESP32 to the web server via Bluetooth, set some config and then nothing happens. Esp32  isn't recognised anymore when DC is booted up, only during the intro swirl. Cutting 5v and providing usb power helps restore the connection, but only with DC power off which interrupts the pairing with an error. Is there maybe something wrong with soldering or anything else? Note: controller port board is VA0 Japan, black wire is 5v and white is GND, temporarily desoldered to provide usb power.

Update: the power may not be enough. Like Yamaha GD-ROM and Samsung GD-ROM, VA0 controller board runs off 3.3V while VA1 consumption is 5V. There's simply not enough voltage

I got both VA0 and VA1 Dreamcast working fine personally.
Your soldering job look bad, too long expose wire and residue all over, do it again make sure to strip minimum length wire and cleanup up the board with alcohol after.
try getting an official DevKit-C (Get it on Digikey or Mouser)
Moving to discussion


Set nuget properties and versions via csproj file

Set all nuspec properties set in csproj (dosc/*.nuspec files become obsolete)
Don't use hardcoded _AssemblyInfo.cs files. Let dotnet properly generate it automatically based on nuspec props and versions
Set additional nupkg props, e.g. title, tags, urls, license, author, ...

TODO: Add additional authors to the nuspec props

I prefer that the sln can control all the nuget package generation, so e.g. "dotnet pack -c Release" can be started from the sln folder. The sln is responsible to generate all the nupkg files, which must be pushed.
To make this work, IsPackable=false must be added to all the csproj which should not generate nupkg files.
In this case the Create nuget package would be a simple:
dotnet pack -v normal -c Release --include-symbols --include-source -p:PackageVersion=$VERSION -o nupkg
If it is ok. I can add it to this PR

Plans look good, go ahead.


Update to Makie.jl v0.20 & Add ".gitignore"

To ensure that the new version of Makie will work, I tested all the examples in the documentation and they all worked as expected.
closes #27

Thank you very much for your contribution!


AttributeError while fetching page

Describe the bug
When I execute a query without proxy, I have an error at captcha resolution blocking the fetch.
Here is the error:
13:31:36 - Getting https://scholar.google.com/scholar?hl=en&q=Perception%20of%20physical%20stability%20and%20center%20of%20mass%20of%203D%20objects&as_vis=0&as_sdt=0,33
13:31:39 - Got a captcha request.
13:31:44 - Exception AttributeError while fetching page: ("'str' object has no attribute 'domain'",)
13:31:44 - Retrying with a new session.
13:31:54 - Got a captcha request.
13:32:01 - Exception AttributeError while fetching page: ("'str' object has no attribute 'domain'",)
13:32:01 - Retrying with a new session.
13:32:06 - Got a captcha request.
13:32:13 - Exception AttributeError while fetching page: ("'str' object has no attribute 'domain'",)
13:32:13 - Retrying with a new session.
13:32:18 - Got a captcha request.
13:32:25 - Exception AttributeError while fetching page: ("'str' object has no attribute 'domain'",)
13:32:25 - Retrying with a new session.
13:32:42 - Got a captcha request.
13:32:48 - Exception AttributeError while fetching page: ("'str' object has no attribute 'domain'",)
13:32:48 - Retrying with a new session.
Traceback (most recent call last):
  File "C:\Users\**\Google Scholar Scrapper\src\main.py", line 8, in <module>
    search_query = scholarly.search_pubs('Perception of physical stability and center of mass of 3D objects')
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\**\Google Scholar Scrapper\venv\Lib\site-packages\scholarly\_scholarly.py", line 160, in search_pubs
    return self.__nav.search_publications(url)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\**\Google Scholar Scrapper\venv\Lib\site-packages\scholarly\_navigator.py", line 296, in search_publications
    return _SearchScholarIterator(self, url)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\**\Google Scholar Scrapper\venv\Lib\site-packages\scholarly\publication_parser.py", line 53, in __init__
    self._load_url(url)
  File "C:\Users\**\Google Scholar Scrapper\venv\Lib\site-packages\scholarly\publication_parser.py", line 59, in _load_url
    self._soup = self._nav._get_soup(url)
                 ^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\**\Google Scholar Scrapper\venv\Lib\site-packages\scholarly\_navigator.py", line 239, in _get_soup
    html = self._get_page('https://scholar.google.com{0}'.format(url))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\**\Google Scholar Scrapper\venv\Lib\site-packages\scholarly\_navigator.py", line 190, in _get_page
    raise MaxTriesExceededException("Cannot Fetch from Google Scholar.")
scholarly._proxy_generator.MaxTriesExceededException: Cannot Fetch from Google Scholar.

Process finished with exit code 1

The issue seems to come from _proxy_generator.py#_handle_captcha2, line 403 where the cookie variable doesn't have the expecting value.
This error isn't present when proxies are activated.
To Reproduce
import logging
from scholarly import scholarly

logging.basicConfig(format=f'%(asctime)s - %(message)s', level=logging.INFO, datefmt='%H:%M:%S')

search_query = scholarly.search_pubs('Perception of physical stability and center of mass of 3D objects')
scholarly.pprint(next(search_query))

Expected behavior
The print of the first result of the query.
Desktop (please complete the following information):

Proxy service: /
python version: 3.11
OS: Windows
Version 11

Do you plan on contributing?
Your response below will clarify whether the maintainers can expect you to fix the bug you reported.

[ ] Yes, I will create a Pull Request with the bugfix.

I see this error appearing even when proxies are in use. I see the exception thrown whenever a captcha is encountered.
In _proxy_generator.py, the self._session object is an httpx.Client, and the cookies property on this client is a special Cookies store provided by httpx.
According to the httpx docs, it is not possible to access the parts of a cookie directly, which can be verified as follows:
In [1]: from httpx import Cookies
In [2]: cookies = Cookies()
In [3]: cookies.set("chocolate cookie", "tasty", domain="example.org")
In [4]: type(cookies['chocolate cookie'])
Out[4]: str
In [5]: cookies['chocolate cookie']
Out[5]: 'tasty'
In [6]: cookies['chocolate cookie'].domain
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[6], line 1
----> 1 cookies['chocolate cookie'].domain
AttributeError: 'str' object has no attribute 'domain'
In [7]: cookies['chocolate cookie'].value
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[7], line 1
----> 1 cookies['chocolate cookie'].value
AttributeError: 'str' object has no attribute 'value'

What's strange is that if that's right, then the code on lines 405-413 could never have worked, which seems unlikely?

I am unable to reproduce this error, but the attributes from the httpx cookies certainly seem incorrect. These used to work on requests, but httpx doesn't seem to have the same behaviour.

Hi,
I see the error whenever a captcha is found. So for me, I have a program which invokes scholarly to try to get some abstracts from Google. After about 10-15 requests, even with random pauses in between, I encounter captcha, and this code block is entered, an exception thrown. The exception is caught, so the scholarly carries on trying to do what it was doing, though unsuccessfully.

Reactivating this issue here because I encounter the same problem, and hoping someone with more expertise might be able to solve it. I investigated a little bit and it seems that the cookies variable -- at least in my case -- is just a string (e.g. 'NID' or 'GSP'). Hence the error Exception AttributeError while fetching page: ("'str' object has no attribute 'domain'",). Any help is very much appreciated! Thanks


Shield event and tags

Currently there is no way to know if a player is using a shield or not.
It would be nice if we had something such as:
"On player starts/stops/toggles using shield"
And a boolean tag for checking if a player is using a shield or not.

Currently there is no way to know if a player is using a shield or not.
That would be <PlayerTag.is_blocking>

There doesn't appear to be an underlying event in Spigot, and the Spigot forums suggest just using the click events and figuring it out from there.
We might be able to hack together a better event via packet stuff, not sure...

I hacked in a packet-driven shield toggle event, after discovering that:
hold up shield = PacketPlayInBlockPlace
put shield down = PacketPlayInBlockDig
(Minecraft is stupid)
on player raises/lowers/toggles shield
Note that this is very imperfect, as there are a variety of odd cases. I've tried to catch the reasonable ones (if a player quits, dies, changes held item, drops the shield item, ... I added handlers that will still fire it).
I've been able to perform a case that doesn't get detected that honestly I'm of a mind should be considered a Minecraft bug and either way I'm not going to try to account for it because wtf:
If you have multiple shields in your hotbar, you can raise one shield, then swap to another shield. This will mean you're now holding a lowered shield, and the 'lowers' event fires accordingly.
However... if you keep holding the right mouse button even while switching, no other shields will raise... but if you scroll back to the original shield item, it will automatically be raised again, without refiring the relevant packet. This is some form of ridiculous nonsense and I refuse to acknowledge its existence by trying to workaround the event firing for that specific case.


Movie classification issue #152

Pull Request for PyVerse 💡
Issue Title : Movie Genre Classification Feature Implementation 🎬📽 #152

Info about the related issue (Aim of the project) :
Name: Sree Praveen challa
GitHub ID: praveenarjun
Email ID<EMAIL_ADDRESS>**Idenitfy yourself: Gssoc Ext,Hackbefest

Closes: #152
Describe the add-ons or changes you've made 📃
I add a File in MAchine Learning folder-> Movie Classification->Movie classification.ipynb && readme file
Type of change ☑
What sort of change have you made:

New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update:
Yes I added Readme file so that User can Understand much better way

How Has This Been Tested? ⚙

Describe how it has been tested : Just run it on google colab
Describe how have you verified the changes made
Checklist: ☑

[Yes ] My code follows the guidelines of this project.
[ Yes] I have performed a self-review of my own code.
[ Yes] I have commented my code, particularly wherever it was hard to understand.
[Yes ] I have made corresponding changes to the documentation.
[ Yes] My changes generate no new warnings.
[ Yes] I have added things that prove my fix is effective or that my feature works.
[ Yes] Any dependent changes have been merged and published in downstream modules.

I made the changes as you said I updated the readme file

Ok I added the dataset so you can recheck again


add compiled credentials to outputs

This is the iteration of #105
I'd like to have compiled credentials as an output. I'm not sure about commiter, it's just how I'll be using it. Perhaps credentials is a better name?
My use case is that the following quite lengthy:
  - uses: org/gitops@v2
    with:
      github-token: ${{ steps.app-auth.outputs.token }}
      repo: gitops-repo
      commiter: "${{steps.app-auth.outputs.app-slug}}[bot] <${{ steps.app-auth.outputs.installation-id }}+${{ steps.app-auth.outputs.app-slug<EMAIL_ADDRESS>
And I'd like to use something less verbose, like this:
  - uses: org/gitops@v2
    with:
      github-token: ${{ steps.app-auth.outputs.token }}
      repo: gcp-domain-name
      commiter: "${{ steps.app-auth.outputs.credentials }}"

Im going to use this credentials as a commiter value for the gitops commits, while keeping the author as pull-request authors
What do you think of this idea? Are you open to this addition? if you are open to the idea and credentials is acceptable name, I will update docs and test to finalise the pull-request

shame really, I'm writing an gitops action for developers and it will be so much easier to use committer output field rather than asking them to construct it by themselves

I'm writing an gitops action for developers and it will be so much easier to use committer output field rather than asking them to construct it by themselves

you will have to document usage of your action anyway, which will include the use of this action. Adding another step to create a new output for the committer really doesn't add much, your users will end up copy-and-pasting your usage example anyway.
Here is an example
      - uses: actions/create-github-app-token@main
        id: app-auth
        with:
          app-id: ${{ vars.GR2M_GITHUB_APP_ID }}
          private-key: ${{ secrets.GR2M_GITHUB_APP_PRIVATE_KEY }}
      - id: committer
        run: echo "string=${{steps.app-auth.outputs.app-slug}}[bot] <${{ steps.app-auth.outputs.installation-id }}+${{ steps.app-auth.outputs.app-slug<EMAIL_ADDRESS>>> "$GITHUB_OUTPUT"
      - run: echo "committer string is ${{steps.committer.outputs.string}}"

I'll add that to our README

there you go, let us know what you think: https://github.com/actions/create-github-app-token/pull/142


User user-friendly names for recommended extensions. @joao

This requires a server call. If for any reason the server doesn't reply, we'll just show the ID just as well, after a timeout.


Long freezes when copying text to the clipboard when using Clipjump.

Hangs for a few seconds and cursor stays unchanged after copying to clipboard when used Clipjump.
Quite a specific program, but extremely convenient and quite popular in narrow geek circles.

Clipjump is a multiple clipboard management utility for Windows. It was built to make working with multiple clipboards super fast and super easy. The program records changes in the system clipboard, stores them without any limits and provides innovative ways to work with them.

@vctsvz Thank you, I have now fixed this issue and will do a release shortly


Fix attachment bug when cancel the attachment selection

Issue #: 306
Description of changes:
Fix attachment bug in chat demo app when user sends a message with attachment. The bug is, when sending a message with an attachment, after user selects the attachment, if user click on the "x" to cancel/de-select the attachment, the current bug will send the attachment instead. This code change fixes the behavior to allow user to de-select or cancel the attachment.
Testing

How did you test these changes?
Run the demo app locally and verified that the issue is fixed.
Can these changes be tested using one of the demo application? If yes, which demo application can be used to test it? Yes the chat demo application can be used to test it.
If applicable, have you run npm run build successfully locally to fix all warnings and errors? Yes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Do you also want to fix it in this demo https://github.com/aws-samples/amazon-chime-sdk/blob/c1916bef61478f5f374de109c7e49a89364ab203/apps/televisit-demo/frontend/src/containers/input/Input.jsx#L110 ?


Add tests for limitrange transformer

Changes
This commit adds test cases for pods where container resource requirements
are inconsistent with limitranges already deployed in the namespace (for example,
with requests lower than the limitrange minimums).
This commit doesn't change existing behavior of the limitrange transformer.
The existing behavior is inconsistent with the behavior we have documented,
and may result in in an invalid pod (i.e. requests > limits). (#5278)
Either the code or the documentation will be fixed in a later PR.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

n/a Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
n/a Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
n/a Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/approve
Seems solid to me - having tests verifying the existing behavior probably should have been there from the start, so we would have known the existing behavior wasn't what we thought it was! =)

/lgtm


timeout does not pass through exit code of command being run

The timeout command will not pass through the exit code of the command being run and instead will always exit '0' if the time out was not reached.
Example;
echo 'exit 10' >/tmp/test_timeout
./target/release/timeout 5 bash /tmp/test_timeout
echo $?

The echo $? should show '10'.

Let me know if the linked PR fixes the problem for you.

Yes, this is fixed


Download InternVid Dataset Issues

Hello, thanks for the great work!
I am trying to download the InternVid 10M Dataset through yt-dlp but it seems that YouTube blocks the IP address fairly quickly, after maybe 30-50 thousand video clip downloads.
How did you get around this problem of YouTube blocking the ip address or throttling the downloading speed?
Thanks.

Try this site.


allow specification of more diverse kubectl verbs in functional testing

What would you like to be added:
Investigate update to functional testing to allow verbs such as kubectl create instead of only supporting apply.
Why is this needed:
Adds capability to the CI to test a more diverse spectra of polices covering a wider variety of  changes which might be requested against a cluster.

Ideas:
  - manifests
  - test-deploy01.yaml
  - create:"kubectl create blah blah"
  - delete:test-deploy01.yaml

  - kind: deployments
    desired: fail
    script:
    manifests:
      - test-deploy02.yaml
    singletons:
      - "kubectl create something"

  - kind: deployments
    desired: fail
    script:
    manifests:
      - test-deploy02.yaml
    creates:
      - "something"


Update filters-helpers, ... to 2.8.9

Updates

com.typesafe.play:filters-helpers
com.typesafe.play:play-akka-http-server
com.typesafe.play:play-docs
com.typesafe.play:play-ehcache
com.typesafe.play:play-guice
com.typesafe.play:play-logback
com.typesafe.play:play-server
com.typesafe.play:play-specs2
com.typesafe.play:play-test
com.typesafe.play:sbt-plugin

from 2.8.7 to 2.8.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.play" } ]

labels: library-update, early-semver-patch, semver-spec-patch

Superseded by #40.


[App Config] Add sample for UpdateSyncToken

This fixes #16119.  I added two files, updateSyncTokenSample.ts and testData.ts, and modified the package.json in the appconfiguration folder. Also updated common/config/rush/pnpm-lock.yaml. Here is what I specifically did for each file:

updateSyncTokenSample.ts:

Contains a sample of decoding an event received from EventGrid, filtering for events specific to app configuration, and then logging the updated configurations. To reduce the complexity of the sample, updateSyncTokenSample uses a hard coded EventGridEvent instead of incorporating another service to act as a receiver.

testData.ts

Contains a hard coded example of an EventGridEvent in string form.

package.json

Added a devDepedency on EventGrid for this package.

common/config/rush/pnpm-lock.yaml

Pushed changes created due to adding a dependency to EventGrid in the AppConfiguration package

Testing:
To test this sample, I created an app configuration resource on Azure, connected to it using the connection string, and verified that the sample behaved as expected.
@jeremymeng if you could review as well that would be appreciated!

@HarshaNalluru thanks for reviewing!
@bbrusniak We will need to publish the sample by following the https://github.com/Azure/azure-sdk-for-js/wiki/Samples-v2-Migration-Guide.  We also want to add this sample to the skip list in the package.json so it doesn't get picked up for automated testing.

Based on the build failures, it looks like something is wrong with the pnpm-lock file.
Can you

delete the pnpm-lock file in your branch
copy the one in the main branch in the repository instead
And then run rush update?

@jeremymeng I added the sample to the "skip" list and published using the following commands.
$ rm -rf samples
$ rushx build
$ npx dev-tool samples publish

I got the following error:
`samples-dev/featureFlag.ts:82:31 - error TS-AZURE: unsupported ES2020 "NullishCoalesce" syntax
82     clientFilter.parameters = clientFilter.parameters ?? {};
Suggestion: try clientFilter.parameters || {} if it does not affect runtime behavior, or use an explicit if block to handle the nullish case
`
I updated the featureFlag.ts file to use "||" instead of "??" and verified that the sample had the same output.
I think everything should be good to go now

@HarshaNalluru I ran rush update locally and pushed the pnpm-lock which seems to have fixed the build issues.

`samples-dev/featureFlag.ts:82:31 - error TS-AZURE: unsupported ES2020 "NullishCoalesce" syntax

Thanks for the fix @bbrusniak. Yes, we want the samples to run with lower versions too so new syntaxes are not supported.


[Request] Option to prefer stream over download for soundcloud

Hello,
For an application I am working on, I use streams from soundcloud to play music. This fails when the file for the track is available for download. I was wondering if there a way (perhaps as a parameter?) to support getting the stream as opposed to the download if preferred by the user.
Example:
(Download NOT available, gives stream URL)
brick@treef ~ % youtube-dl --prefer-insecure -i -g http://soundcloud.com/madeon/technicolor-original
https://ec-media.soundcloud.com/B1H78RLx4hf2.128.mp3?f10880d39085a94a0418a7ef69b03d522cd6dfee9399eeb9a522009c6bfdb73b188c326458f08b1f7ee6ceb309f0104c492b4322561fa73050cd328fed3f14ff1ad9797a6b&AWSAccessKeyId=AKIAJNIGGLK7XA7YZSNQ&Expires=1410459762&Signature=OrwuRHiclh9m%2BvmIELm%2F0PRt%2BxI%3D

(Download available, returns download URL)
brick@treef ~ % youtube-dl --prefer-insecure -i -g http://soundcloud.com/totalbiscuit/shania-bain-that-dont-impressa-me-much
https://api.soundcloud.com/tracks/165922504/download?client_id=b45b1aa10f1ac2941910a7f0d10f8e28

The second one would fail for my use.
I'm guessing this may not be possible because of implementation on soundcloud's end, or because it is not a common enough case to warrant adding an option. Thanks!

You can use youtube-dl 'http://soundcloud.com/totalbiscuit/shania-bain-that-dont-impressa-me-much' -f mp3 (in general you can see the available formats with -F). Use -f mp3/best if you don't want it to fail if there isn't a mp3 format.


NullReferenceException in IISHttpContext

I am receiving the following exception with all my asp.net core 3.0 apps when they are deployed to an azure app service.
System.NullReferenceException at Microsoft.AspNetCore.Server.IIS.Core.IISHttpContext.GetOriginalPath
The exception seems to occur during startup.  I have not seen it cause any major issues.
#6075 speaks to the exact same issue.

@jkotalik  this is a dup of #6075
Is this something we should document?

No, this should have been fixed. The following check was added to avoid this issue: https://github.com/aspnet/AspNetCore/blob/d7bfbb5824b5f8876bcd4afaa29a611efc7aa1c9/src/Servers/IIS/IIS/src/Core/IISHttpContext.cs#L196. I remember verifying this didn't occur anymore as well.
@vsadams is there more information you can provide us here? For example, .NET runtime version, line numbers, and the full stack trace? That would be helpful in identifying what the issue is here.

I am running into a similar issue, Here is the stack trace:
System.NullReferenceException:
at Microsoft.AspNetCore.Server.IIS.Core.IISHttpContext.GetOriginalPath (Microsoft.AspNetCore.Server.IIS, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Server.IIS.Core.IISHttpContext.InitializeContext (Microsoft.AspNetCore.Server.IIS, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Server.IIS.Core.IISHttpContextOfT1+<ProcessRequestAsync>d__2.MoveNext (Microsoft.AspNetCore.Server.IIS, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60)    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)    at System.Runtime.CompilerServices.TaskAwaiter1.GetResult (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Server.IIS.Core.IISHttpServer+d__27.MoveNext (Microsoft.AspNetCore.Server.IIS, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60)

@snalwani this fix was only done in 3.0. Is it possible for you to upgrade to 3.0 and verify this behavior persists?

I might have spoke too soon.  Looking at the logs closer its showing the 2.2.6 version of the AspNetcore.Server assembly.  There might have been something weird that happened after deploying the 3.0 upgraded versions of the apps. Im closing this issue til I can reproduce it with the correctly versioned assembly.


ci(.github/workflows): Add check dependencies step

:heavy_check_mark: Checklist:

[ ] Have only one commit (if not, squash them into one commit)
[ ] Tests for the changes have been added (for features / bug fixes / refactoring)

Codecov Report

Merging #234 (280ccd0) into main (da87702) will increase coverage by 4.45%.
The diff coverage is 64.92%.

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   66.84%   71.30%   +4.45%
==========================================
  Files          10       12       +2
  Lines         368      568     +200
==========================================
+ Hits          246      405     +159
- Misses        111      130      +19
- Partials       11       33      +22

Impacted Files
Coverage Δ

internal/apischema/find.go
0.00% <0.00%> (ø)

internal/openapi3/parse.go
47.97% <50.32%> (+13.36%)
:arrow_up:

internal/openapi3/openapi3.go
60.00% <60.00%> (ø)

internal/apischema/apischema.go
73.33% <73.33%> (ø)

internal/openapi3/schema.go
75.00% <75.00%> (ø)

internal/faker/faker.go
96.92% <100.00%> (+1.64%)
:arrow_up:

internal/openapi3/example.go
100.00% <100.00%> (ø)

internal/openapi3/mediatype.go
100.00% <100.00%> (+14.28%)
:arrow_up:

internal/server/handler.go

internal/server/server.go

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b8072...280ccd0. Read the comment docs.


ProjectGrep super slow with large codebases

Hi,
using :FzfPreviewProjectGrep is super slow with larger codebases. It literally crashes at some point. Try it with a large codebase...kinda extreme example: https://github.com/torvalds/linux. But you get the point.
Using :FzfPreviewProjectGrep <term> works reasonably fast though, so i assume it's because of the fact it renders every file into the list, which IMO should be avoided anyways. Tbh that usage seems to be better in general... performance-wise.
I think when opening the floating window without a searching term, no sources should be listed and the prompt in the floating window would call the according command afterwards, that way you'd also do stuff like -w <term>.
What do you think? Does it make sense?
Regards

It is difficult to generate resources step by step fzf.
To solve the crash problem, FzfPreviewProjectGrep changes the argument to mandatory
The same behavior as before can be realized with FzfPreviewProjectGrep .
Thanks

Fixed 8093128dce5a24eab6c221c1bcbfc3b8fa575e32


fix: output dir is dir

In this code snippet:
let OutputDir = getRunnerInput('output_dir', 'built', getRunnerPath);
let OutputDirIsDir = false
try {
    OutputDirIsDir = fs.lstatSync(OutputDir).isDirectory();
} catch { }
if (!OutputDirIsDir) {
    OutputDir += OutputDir.endsWith("/") ? "" : "/"
    CreateOutputDirectory(OutputDir);
}

The current logic is - if the output directory is not a directory, then ensure it ends with a slash.
The logic should be - if the output directory is a directory, then ensure it ends with a slash.

@BaileyJM02 , just in case u didn't receive the notification on the pull request :)


Remove depecated functionality

Remove generate_qpd_samples. Replaced by generate_qpd_weights.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 93.748%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
2429

Relevant Lines:
2591

💛  - Coveralls


Extract isChildPath, resolveSafeChildPath, resolvePackagePath from backend common to the plugin api

Context
Ref: https://github.com/backstage/backstage/issues/24493
In preparation for the new backend system stable release, we will deprecate the backend-common package.
Description
All path utilities such as isChildPath, resolveSafeChildPath and resolvePackagePath should be extracted  to the backend-plugin-api package.
Acceptance criteria

Utilities should de used by the app and plugins without cyclical dependencies
Extracted code should be re-exported from the new module in the old package
Deprecation exports in the old packages must be declared in a deprecated.ts file
Deprecation exports should be annotated with @deprecated and contain a comment explaining their replacements
Other packages' import statements should be updated to use bindings from the new package
Documentation examples should be revisited to use code from the new package instead

Closed by https://github.com/backstage/backstage/pull/24565


Update for Keycloak 25.0.0

Since Keycloak 25, specifically
bbb83236f5251e3c4718eac63ab0e640a80913f1, the idp config is passed into the constructor of BrokeredIdentityContext instead of using a setter method later. Changes here are analogous to OIDCIdentityProvider.
Tested manually with both "regular" web login (goes through sendTokenRequest()) and token exchange (goes through validateAppleIdToken()).

Awesome!
Thank you for your contribution and the amount of testing. Really appreciate it!
Will create a new release asap

Thank you!


feat(codemod): codemod PermissionOverwrite typings as well

Summary
codemod the final part of permission typings :)
Checklist

[x] If code changes were made, then they have been tested

[x] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running task lint
[x] I have type-checked the code by running task pyright

[x] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Could you add a changelog entry for the now fixed use_application_commands and use_embedded_activities annotations?

Could you add a changelog entry for the now fixed use_application_commands and use_embedded_activities annotations?

Didn't notice those were missing, fixed in https://github.com/DisnakeDev/disnake/pull/777/commits/6c86cd2b9fd84f53d6863f1fd8befe4722420132


Query for existing Dataset metadata from client/CLI

Add support for getting state metadata of the Dataset object for an existing dataset to the dmod.client package and CLI functionality.  In particular, make sure the DataDomain can be obtained.

Closed by #631.


Plugin initialization fails in a typed actor system

The pekko plugin fails to initialize in a typed actor system with the failure
org.apache.pekko.actor.ActorInitializationException: pekko://SinkControllerTest/system/inmemory-journal: exception during creation, root cause message: [cannot create top-level actor [JournalStorage] from the outside on ActorSystem with custom user guardian]
That problem was already fixed in the original akka version (https://github.com/dnvriend/akka-persistence-inmemory/issues/50). The problem was then introduced again in some changes but did not make it into an official release. Since the pekko fork is orginated from these unreleased changes it contains the problem too.
The reason is the creation of the plugin actor using
val newActor = system.actorOf(props, actorName)
which should be
val newActor = system.systemActorOf(props, actorName)
in src/main/scala/io/github/alstanchev/pekko/persistence/inmemory/extension/ActorSingletonSupport.scala:18
If desired I can provide  a PR that fixes the problem.

Hi @sdeigm a PR will be greatly apreciated.

Hi @alstanchev, I was on vacation for the last three weeks :-)
I just created the pull request

Fixed in #13


Incorrect format detection

Input: dataset (text documents + manifests)
Output: format_correct: True/False added to manifest
Here: https://github.com/mglabska/speakleash_filters/blob/master/quality_format.py

AdamJot gonna take care of this issue.

Comments and minor updates added for more clarity.


🔨 [FIX] Fixes EMA implementation (#97)

Reinstated ema.update() in ModelTrainer.train_one_batch().
Reworked ema.apply_shadow() and ema.restore() methods to properly restore the original model_state_dict.
ModelTrainer.save_checkpoint function now properly saves both the state_dict and shadow values.
YOLO.save_load_weights function loads EMA values if found in checkpoint.
YOLO.save_load_weights function can now load both old and new checkpoints (was there as TODO).
If EMA is enabled, model validation will use the EMA values during training.
fixes #97

Sorry for the change history. Took a while to get it right (first time).

This pull request is no longer compatible nor relevant after the lightning update, so I'm closing it.


Revert Pandas 1.3.0 Compatibility Patch

Once xgboost releases to >= 1.4.2 with this fix, the changes made to estimator.py here to force dataframe columns to a list of integers can be reverted as xgboost's DMatrix will be able to properly handle RangeIndex rather than just Int64Index.
estimator.py L72-73
# These two lines can be removed.
if isinstance(X.columns, range.RangeIndex):
    X.columns = [x for x in X.columns]

@chukarsten Are we looking for XGBoost to release to >1.4.2? I see that the most recent release is 1.4.2, and I'm working on https://github.com/alteryx/evalml/pull/2484 to unpin our XGBoost version (which would install 1.4.2) so I was curious!


fix: Always update selection on a re-render

This will allow it to be set on an auto-recover of the parent form
Previously, the selection would be set to [] on mount, and then an auto-recover would change the form field (updating the field value), but not update the live_select selection, because it was already set.
This couldn't be avoided by setting the value for the live_select component because that triggers a client event, which seems to invoke an infinite loop between the phx-blur and phx-change events defined for the component, when invoked after an auto-recover.

This is my first time using the library so there may be a better way to approach this (that doesn't break a bunch of the tests!), but this change seems to work for our use case...

Hi @sevenseacat and thanks for looking into this.
Unfortunately, your change causes the selection to always be overridden when the update/2 callback is triggered. For example if I select multiple options and then I type something in the text box, all already selected options will disappear. See all the tests that are failing.
Also, even with your change, form recovery still didn't work for me. I'm using the showcase app (after adding ids to the form elements, which were missing). Maybe you can point me to a repo or an example where it works?
Form recovery works by triggering the phx-change event on the form. So the only way I can imagine how it could work is if the live view (or component) that receives the event sent the value (and possibly also options to display the correct labels) to live_select with a send_update/3.
Again, if you could point me to an example that works, that would be great!

Form recovery works in Phoenix by calling the event defined with the phx-auto-recover attribute - which is what I'm using to update my form with data, which is getting passed down to the live-select - but it has no effect, because on the initial mount, the selection is set (so assign_new on update doesn't overwrite it).
I'll have a look at the showcase app and see if I can replicate the issues.
I'm not seeing options being cleared on a re-render in my app - I have a component like this
<CoreComponents.live_select
              id="hub_id"
              label="Hub *"
              field={form[:hub_id]}
              placeholder="Search for Hub"
              options={@hub_options}
              phx-blur="blur_hub_id_field"
            />

Which passes all the attributes through to LiveSelect.live_select, with some extra styling. @hub_options is a map of tuples and doesn't get cleared - it does get filtered on type, and reset on blur, but never cleared.

Form recovery works in Phoenix by calling the event defined with the phx-auto-recover attribute

Yes, that's the fancy way of doing auto recovery, but there's also the basic way that relies solely on phx-change. See here.
In any case, thanks for sharing your code. It's clear that your options don't get reset upon rerendering - because you're setting them in the markdown using the @hub_options assign. The showcase app sets them to [] in the markdown and so they're cleared upon rerendering. In general, whatever initial value one sets for options in the markdown, it will be restored upon rerender.

Yeah I see exactly why this breaks now - for the tags approach, the existing tags aren't always going to be in the list of available options so they get stripped. Hmmm....

Alternatively, the changes in this PR could be discarded and the push_event that is called when the value attribute is provided, could be removed. That seems to be fine within the showcase, and also in our app when trying to auto-recover data.
A lot of tests still break but they're about testing/verifying the push_event call specially, so could be removed.
Do you see any issues with doing that?

Alternatively, the changes in this PR could be discarded and the client_select that is called when the value attribute is provided, could be removed. That seems to be fine within the showcase, and also in our app when trying to auto-recover data.

The problem with this idea is that that client_select has a purpose: it's used to trigger a change event when the selection is changed programmatically using the value assign.
I dug down a bit deeper and to me the issues can be thus summarized:

The component only uses the field assign to set the selection during the first render (via the assign_new). Subsequent changes to field are ignored. This is clearly bad and in particular it prevents form recovery as you have discovered

Even if (1) was not an issue, you could have the situation where form recovery would be broken because the options that were set in the component are lost. Imagine the following:
a. I search for "New". The options are set to "New York", "New Haven" etc..
b. I select "New York". The value of the selection is now the coordinates of New York [X,Y], the label is "New York"
c. Server crashes. Client is disconnected
d. Client reconnects. Form recovery is triggered, but the client currently only sends the value (in this case, the coordinates), and not the label
e. the form recovery event on the server only gets the coordinates. In order to display the right label, the server will have to fetch it again from the source

I fixed (1) and I pushed the changes to main.
For (2), one option is to have the server retrieve the label again from the source on form recovery. Another option might be for the client to store both label and value and send them to the server. Not sure how this would work in detail yet.
Can you please try your code against the current main and see if (1) is fixed? You should now be able to run your form recovery logic, keeping the caveat of (2) in mind. Thanks!

I just realized that (2) isn't a problem only when you're dealing with form recovery, but in general when you update the selection from the form in tags mode. If the selection contains some values that do not match the set of currently available options, the label won't be correct.
So for example in:

I search for "New", the options are now all cities that begin with "New". I find "New York", and select it
I search for "Par". The options will now contain all cities that begin with "Par", New York won't be among them
I select "Paris" and add it to the selection
Now the selection in the form contains the coordinates for "Paris" and "New York", but "New York" is no longer in the options. LiveSelect won't be able to find the right label

Not sure how you can solve this problem.

The changes in main fix the issue we're seeing in our app - this code obviously isn't going to be merged, and we don't use the tags mode in our app, only the single select mode.
I'm happy to close this PR, and perhaps we can open up a separate issue to track other changes (or use #44)

Yes, with the current code form recovery should work if label = value in your selection.
I'm currently trying to make it work also when labels and values differ. I think I found a way, I just have to work on the details.
#44 is should also already be fixed by the current code.
When form recovery is fully functional, I'll release a new version.
Thanks for opening this PR!

FYI: I released 1.3.0 which fully supports form recovery


Make Teleport Hotspots functional for users [Experimental feature]

Overview
The current iteration of Teleport Hotspots are unusable for users, as the hotspots attempt to raise and cancel teleport events during the OnFocusEnter and OnFocusExit events. This PR removes this level of management from the hotspots, ensuring that users can experiment with the feature before we graduate it.
This fix is necessary to provide a functional experience, and thus make our docs for this feature useable.

Updated in-editor gizmo visuals

/AZP RUN

@MaxWang-MS added an example under experimental showcasing how to use the teleport hotspot.

/azp run

/azp run

/azp run

/azp run

/azp run


Remove the open-vm-tools only for RedHat <= 6

It is not necessary to remove it every time on RedHat >= 7 because VMWare Tools are never installed

Thanks a lot...
Merged...


Copying selected text from a file gets wrong text

I'm using ForkHub on a Nexus 5X. I've found that when I view a file, select some text, tap the copy button, and then paste the text elsewhere, the wrong text gets pasted. Instead, text from further up in the file was copied. Please let me know if there's anything I can do to help diagnose this.

@jonan What kind if View is used to render the code UI?

I believe Webview is used to render a CodeMirror page.

I experience the same issue on Android 7 consistently


fix: Avoid error looking up tgw_route_table when resource is not crea…

Description
When sharing a tgw across aws accounts (tgw_share=true and tgw_create=false), the module runs into an error when looking up the transit gateway route table. By introducing a local variable with 'try' we can circumvent the issue.
Motivation and Context
Module fails when trying to share across accounts. Previous issues reported:
https://github.com/terraform-aws-modules/terraform-aws-transit-gateway/issues/61
https://github.com/terraform-aws-modules/terraform-aws-transit-gateway/issues/46
https://github.com/terraform-aws-modules/terraform-aws-transit-gateway/issues/47
https://github.com/terraform-aws-modules/terraform-aws-transit-gateway/issues/56
Breaking Changes
none

Looks like this PR solves the issues I'm running into as well.
terraform_version: v1.1.7
module_version: 2.5.1

I'm hitting this now as well trying to do a cross-account TGW attachment.  I hate to be a pest, but @antonbabenko is there any chance we can get a 2.5.2 released with this fix in it?

hey all, would anyone be willing to double check PR #68 and let me know if this resolves the issue? The proposed changes here won't work either because doing try(var.some_variable, ....) will always succeed and take var.some_variable. It will only fail if you do a lookup on an attribute/value that doesn't exist. For example, these all will fail the try() check and continue down the chain:

try(var.foo.bar, null) if var.foo doesn't contain bar in its map attributes
try(aws_some_resource[0].id, null) if aws_some_resource` is not created
try(each.value.foo, null) if the map that is being looped over with for_each doesn't contain foo in its attributes

This issue has been resolved in version 2.6.0 :tada:


Update libreoffice-language-pack to 5.4.4

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

@mahori would you mind replacing the line
depends_on cask: 'libreoffice'

with
depends_on cask: [
                   'libreoffice',
                   'libreoffice-still',
                 ]

and adding the following appcast:
appcast 'https://download.documentfoundation.org/libreoffice/stable/',
        checkpoint: 'e10b6d6d5b9d7d21174049291ce78cb5eca63d91ccf5aaed3f0b6715022629ca'


ci added

hello @fmrico  I just added the ci workflow

changed to ros-tooling as you suggested

LGTM !!!!
May you include in this PR also the badges in README.md?


Reduce usage of inttoptr

We should avoid using IRBuilder.inttoptr for storing constant runtime addresses in the IR.  We need to use <TargetContext>.add_dynamic_addr so we mark where runtime addresses are used and indicate the caching layer that caching to not allowed.

Looks good.  Ready to merge.


Browser Production version local file system support novel effort started to complete.

Dear Friends.
Hope all will improve with US.

I think it may be really not a drawback to add local file system project and asset stored on, remember  "exclude desktop functionality from browser target", now to include it slightly modified.

I have started the code modifications, made a few changes, paused on next:

Can you advance by pointing up why the "Type Error: window.require is not a function?"
I searched the codes and found only appearances of !!window["require"] and no specific error dialog display invocations...
The objective is to make the Open Local Project working fully in Browser as in the Electron version within my version of the VoTT codes, please point up which files to consider and which changes to make?
Kind Regards,
Paul.

Hi Paul,
VoTT uses electron's IpcRenderer to implement the local file system backend. You will need to rewrite the file system provider to use something else.
Take a look at ipcRendererProxy.ts which is used by all the localFileSystemProxy methods.
IpcRendererProxy.ipcRenderer = (window as any).require("electron").ipcRenderer;

Hi Steven.
Tnx for your response and hint.

Will check ipcRendererProxy.ts later on...

Still, why this error: ""Type Error: window.require is not a function?"

What is meant in my idea is that the VoTT web browser version in previous commits was supporting opening projects from both cloud and local file systems, right? It is that is meant in my post, how to recover (which particular commit, code version) production build still supports both local file system and cloud(web-based) for web-based version(GUI)?

Best Regards,
Paul.

The VoTT web browser version has never supported local file systems. There is no commit that has local file system working for the web based version.
Before the v2.0 release, VoTT was electron-only.


undefined symbol: _ZN2v811HandleScopeC1Ev

Waf: Entering directory /mnt/uw/node_modules/bcrypt/build' [1/4] cxx: src/blowfish.cc -> build/default/src/blowfish_1.o [2/4] cxx: src/bcrypt.cc -> build/default/src/bcrypt_1.o [3/4] cxx: src/bcrypt_node.cc -> build/default/src/bcrypt_node_1.o [4/4] cxx_link: build/default/src/blowfish_1.o build/default/src/bcrypt_1.o build/default/src/bcrypt_node_1.o -> build/default/bcrypt_lib.node Waf: Leaving directory /mnt/uw/node_modules/bcrypt/build'
'build' finished successfully (3.003s)
tonyg@ubuntu10:/mnt/uw/node_modules/bcrypt$ nodeunit /test
The "sys" module is now called "util". It should have a similar interface.
node: symbol lookup error: /mnt/uw/node_modules/bcrypt/build/default/bcrypt_lib.node: undefined symbol: _ZN2v811HandleScopeC1Ev

I setup it from git-clone-make and from npm-install --- the same result :(

Which version of node are you using? Do you have ssl installed?
What version of the module did you try? The sys module isn't in bcrypt...
➜  Code  cd node.bcrypt.js
➜  node.bcrypt.js git:(master) ack-grep "sys" --js
➜  node.bcrypt.js git:(master) ack-grep "sys"
src/bcrypt.cc
50:#include <sys/types.h>

src/blowfish.cc
47:#include <sys/types.h>

What command are you using to build it?
What OS are you running this on?

Ubuntu 10.04.1 kernel <IP_ADDRESS>.44
SSL dev lib -  libssl-dev 0.9.8k-7ubuntu8.6
node -v v0.7.0-pre
npm -v 1.1.0-beta-7
bcrypt v 0.5.0
use npm install bcrypt
npm http GET https://registry.npmjs.org/bcrypt
npm http 304 https://registry.npmjs.org/bcrypt

<EMAIL_ADDRESS>install /home/tonyg/node_modules/bcrypt
make build

rm -f bcrypt_lib.node
rm -Rf build
node-waf configure
Checking for program g++ or c++          : /usr/bin/g++
Checking for program cpp                 : /usr/bin/cpp
Checking for program ar                  : /usr/bin/ar
Checking for program ranlib              : /usr/bin/ranlib
Checking for g++                         : ok
Checking for program gcc or cc           : /usr/bin/gcc
Checking for program ar                  : /usr/bin/ar
Checking for program ranlib              : /usr/bin/ranlib
Checking for gcc                         : ok
Checking for node path                   : ok /home/tonyg/.node_libraries
Checking for node prefix                 : ok /usr/local
Checking for function RAND_bytes         : yes
'configure' finished successfully (2.047s)
node-waf build
Waf: Entering directory /home/tonyg/node_modules/bcrypt/build' [1/4] cxx: src/blowfish.cc -> build/default/src/blowfish_1.o <command-line>: warning: "EV_MULTIPLICITY" redefined <command-line>: warning: this is the location of the previous definition [2/4] cxx: src/bcrypt.cc -> build/default/src/bcrypt_1.o <command-line>: warning: "EV_MULTIPLICITY" redefined <command-line>: warning: this is the location of the previous definition [3/4] cxx: src/bcrypt_node.cc -> build/default/src/bcrypt_node_1.o <command-line>: warning: "EV_MULTIPLICITY" redefined <command-line>: warning: this is the location of the previous definition [4/4] cxx_link: build/default/src/blowfish_1.o build/default/src/bcrypt_1.o build/default/src/bcrypt_node_1.o -> build/default/bcrypt_lib.node Waf: Leaving directory /home/tonyg/node_modules/bcrypt/build'
'build' finished successfully (3.387s)
comment "EV_MULTIPLICITY" have no effect

tonyg@ubuntu10:~/node_modules/bcrypt/test$ node async.js
node: symbol lookup error: /home/tonyg/node_modules/bcrypt/build/default/bcrypt_lib.node: undefined symbol: _ZN2v811HandleScopeC1Ev

waiting for solution...

first, do this, nodeunit -v
next, try this, make test

I just compiled and ran the tests fine, but you'll want the more recent version of nodeunit for it, at least 0.6.x.

nodeunit -v 0.7.3
tonyg@ubuntu10:~/node_modules/bcrypt$ make test
rm -f bcrypt_lib.node
rm -Rf build
node-waf configure
Checking for program g++ or c++          : /usr/bin/g++
Checking for program cpp                 : /usr/bin/cpp
Checking for program ar                  : /usr/bin/ar
Checking for program ranlib              : /usr/bin/ranlib
Checking for g++                         : ok
Checking for program gcc or cc           : /usr/bin/gcc
Checking for program ar                  : /usr/bin/ar
Checking for program ranlib              : /usr/bin/ranlib
Checking for gcc                         : ok
Checking for node path                   : ok /home/tonyg/.node_libraries
Checking for node prefix                 : ok /usr/local
Checking for function RAND_bytes         : yes
'configure' finished successfully (0.678s)
node-waf build
Waf: Entering directory /home/tonyg/node_modules/bcrypt/build' [1/4] cxx: src/blowfish.cc -> build/default/src/blowfish_1.o <command-line>: warning: "EV_MULTIPLICITY" redefined <command-line>: warning: this is the location of the previous definition [2/4] cxx: src/bcrypt.cc -> build/default/src/bcrypt_1.o <command-line>: warning: "EV_MULTIPLICITY" redefined <command-line>: warning: this is the location of the previous definition [3/4] cxx: src/bcrypt_node.cc -> build/default/src/bcrypt_node_1.o <command-line>: warning: "EV_MULTIPLICITY" redefined <command-line>: warning: this is the location of the previous definition [4/4] cxx_link: build/default/src/blowfish_1.o build/default/src/bcrypt_1.o build/default/src/bcrypt_node_1.o -> build/default/bcrypt_lib.node Waf: Leaving directory /home/tonyg/node_modules/bcrypt/build'
'build' finished successfully (2.753s)
The "sys" module is now called "util". It should have a similar interface.
node: symbol lookup error: /home/tonyg/node_modules/bcrypt/build/default/bcrypt_lib.node: undefined symbol: _ZN2v811HandleScopeC1Ev
make: *** [test] Error 127

I ran c++filt for the on the undefined symbol and it results in:
➜  node.bcrypt.js git:(master) c++filt _ZN2v811HandleScopeC1Ev
v8::HandleScope::HandleScope()

It seems like v8 isn't getting dynamically loaded correctly for the module...have you had any issues with other native modules like libxmljs? I'm wondering if it has to do with your configuration.
Where did you install node and the node headers/libs? It seems like it is to /home/tonyg/.node_libraries, is that true?
Basically, it compiles fine because the includes are all ok, but when it actually goes to use the libraries it is choking.
So, I've commit a change to the wscript. Can you try it out in your exact setup and let me know if it works for you? Thanks!

I make buld with new wscript but it's not help...

Have you tried any other node addons (not simply JS modules)?

rbytes works well for me))

Currently? rbytes hasn't been updated in over a year, although it doesn't appear to be doing anything crazy. However, if that works fine for you, so too should bcrypt...have you reinstalled rbytes (recompiled and all of that) recently?

Yes, I did... I install new system about 1 week ago. I so 2 ways: you will try to install node 0.7 or I try do downshift to node 0.6 ))

So... I install node 0.6.11 on to my notebook and everything okey with bcrypt. Be ready to mass-migration to node 0.7.x ))

The module works fine with 0.7.x-pre for me. I can't reproduce your issue which is why I'm having a hard time with this. So, by your line and my setup, the module is ready for 0.7.x...


⚠ ClamAV has degraded performance

In 59c243c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 245 ms

Resolved: ClamAV performance has improved in 8943fad.


Boards cypress tests

Summary
Focalboard Cypress tests currently run with Personal Server. When code gets moved to mono-repo, we will lose those tests.
This PR moves the current focalboard tests into the mattermost-webapp codebase to run along-side the other cypress tests.
Release Note
NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

Hello @lindy65, could you please help check if each automated test case has corresponding written test case? If yes, then please ask to add test case ID (E2E docs at item 4). If none, then please submit a PR to add the new test case to test management repo so that once merged, we could add test case ID here as well.

Hello @sbishel, hope it's fine with you that I pushed changes to fix some of the test (https://github.com/mattermost/mattermost-webapp/pull/12232/commits/02058fcb95424a26f736a599d33175e2a0daa2e2). All passed in local but will run E2E here and see if all passed and nothing needs to change in the pipeline.

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

/e2e-test

Hey @saturninoabril - I've added missing test case IDs from the existing test cases in Zephyr

Thanks Lindy! Appreciate so much!


kernel crash with AMD gfx1035 device

Hi @StRigaud ,
I'm just testing this notebook by replacing pyclesperanto_prototype with pyclesperanto (version 0.8.1). The kernel dies when calling voronoi_otsu_labeling and there is no error message. I'm running on Windows 10. What other information do you need to reproduce this?
Thanks!
Best,
Robert

I can narrow it further down: The error happens on an AMD GPU:
cle.get_device()

(OpenCL) gfx1035 (OpenCL 2.0 AMD-APP (3354.13))
	Type: GPU
	Compute Units: 6
	Global Memory Size: 12916 MB
	Maximum Object Size: 10523 MB

If I activate the NVidia GPU ,it works;
cle.select_device("RTX")

(OpenCL) NVIDIA GeForce RTX 3050 Ti Laptop GPU (OpenCL 3.0 CUDA)
	Type: GPU
	Compute Units: 20
	Global Memory Size: 4294 MB
	Maximum Object Size: 1073 MB

Can you try it with some intel device? To check if it only crashes on AMD device.
I do not have any AMD devices so this a blind spot for me.

From memory I already had issues with device named 'gfx1035' during workshop with users.
If it is not related to drivers and OCL installation, this may need to be debuged from the C++ side.

Maybe we do it in an upcoming hackathon?

I renamed the issues for more explicite name related to the bug in case people use the search option for similar issues

It's an AMD Radeon GPU, built into a Ryzen 9 6900HS CPU btw.

After some digging with @haesleinhuepf the issue is related to the cache system witht the call of
// saveBinaryToCache() OpenCL backend file
err = clGetProgramInfo(program, CL_PROGRAM_BINARIES, binary_vec.size(), &pointer_to_binary_vec, nullptr);

See [here}(https://community.amd.com/t5/archives-discussions/problem-with-clgetprograminfo-cl-program-binaries/td-p/139105) for possible lead to solve the issue

Just for completeness: These are the things we modified during our mini-hackathon: https://github.com/clEsperanto/CLIc/compare/robert_screwing_up_things?expand=1

I push some code in https://github.com/clEsperanto/CLIc/tree/robert_screwing_up_things
I doubt if will change things because it is just a more complicated (c-style) way to do what I was already doing.
When you have 5 min to run, otherwise we can have a look at our next zoom


Wrong Calculations on floating point (double)

Thank you for taking the time to file an issue!
This tracker is for issues related to:

dev_compiler

Simple just try to run the code below on dart pad or any ide
void main() {
var x= 4.235;
var y=100;
var result= x * y;
print(result); //423.50000000000006
}

That's how floating point works. See https://floating-point-gui.de/ for more details.


Repo sync for protected CLA branch

The pull request is created from master637376016857849824 to master to fix git push error for protected CLA branch

@cmcclister : Thanks for your contribution! The author(s) have been notified to review your proposed change.


SPIKE: How to find expense authority information other than MOU

Describe the Issue
This ticket is a result of a meeting with Rosemarie, Catherine, Abibat, and I about the current state of the quarterly billing reports. Rosemarie stated that it takes a sizeable amount of time to sort through the MOUs (stored on the LAN) to find expense authority information. There is apparently no lookup tool to find expense authority contact based on account coding, but may be worth looking into. It also may be worth exploring if there is a way to correlate information we already store to an MOU. Another option might be to just store the Expense Authority name and contact in our metadata somewhere.
Additional Context
Add any other context, attachments or screenshots
Acceptance Criteria

[ ] investigate if there is a way to look up expense authority information based on account coding
[x] is there information that we already store that we could show in the spread sheet that would make it easier to match the MOU with the account coding?
[ ] look into where we would store expense authority information if we wanted to include it in the spread sheet
[ ] meeting with team to discuss findings
[ ] findings recorded somewhere
[ ] relevant tickets created

Regarding the second acceptance criteria, the project set's team name is in the MOU file name. We could add a column with a list of team names that are related to the account coding. That may help relate Account Coding to an MOU, and subsequently an expense authority.


[firebase_dynamic_links] getInitialLink() not working on Android on version 0.5.0+8

Describe the bug
I'm using dynamic links for passwordless login with firebase and getInitialLink() is always returning null on version 0.5.0+8.
If I use version 0.4.0+4 and retrieveDynamicLink() instead of getInitialLink() it works fine.
To Reproduce
Since it's working in version 0.4.0+4 I assume the problem is not on Firebase settings.
This is how I'm sending the email:
final FirebaseAuth user = FirebaseAuth.instance;
    try {
      user.sendSignInWithEmailLink(
          email: _email,
          androidInstallIfNotAvailable: true,
          iOSBundleID: "com.mydomain.myappname",
          androidMinimumVersion: "16",
          androidPackageName: "com.mydomain.myappname",
          url: "https://myAppName.page.link/fJc4",
          handleCodeInApp: true);
    } catch (e) {
      _showDialog(e.toString());
      return false;
    }

And then to retrieve it:
@override
  void didChangeAppLifecycleState(AppLifecycleState state) {
    if (state == AppLifecycleState.resumed) {
      _retrieveDynamicLink();
    }
  }

  Future<void> _retrieveDynamicLink() async {
    final PendingDynamicLinkData data = await FirebaseDynamicLinks.instance.getInitialLink();
    print('data == ' + data.toString());

    final Uri deepLink = data?.link;
    print(deepLink.toString());

    if (deepLink != null) {
      _link = deepLink.toString();
      _signInWithEmailAndLink();
    }
    return deepLink.toString();
  }

data is always null on the new version with getInitialLink(). It works on the previous version with retrieveDynamicLink().
Expected behavior
Get a non null link
Additional context
I'm testing it on Android. I haven't tested for iOS yet.
Here's the flutter doctor:

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.9.1+hotfix.6, on Microsoft Windows [Version 10.0.17763.864], locale pt-BR)
[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[√] Android Studio (version 3.5)
[!] VS Code (version 1.40.0)
X Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[√] Connected device (1 available)
! Doctor found issues in 1 category.

On my iOS devices with iOS version 10 and 12 I had to implement a short delay after appstart before calling getInitialLink(), otherwise it returned null. Havent tested how long this delay has to be, but with a 2 second delay it works. Tested both with v1.7.8.hotfix+4 and 1.9.1.hotfix+6
Tested with 0.5.0+6 and 0.5.0+8, didnt work without the delay

@gisinator I saw this workaround somewhere else but it doesn't work for Android. Tried with 3 seconds delay and the problem persists.

Same issue on iOS. On Android all OK.

The two second delay fix is working. Otherwise, getInitialLink got null

Firebase 0.6.0, same on iOS.
getInitialLink() returns null time to time but pretty often.

Hey @allco, @sanekyy you could try https://github.com/FirebaseExtended/flutterfire/pull/3567 - I experienced with same problem in ios and found a reason when the initial link is being overwritten by null later so there is a race condition...

Hello @madmag77. Your PR works great. Thanks.

@Salakar Hi!
Could you close this issue because of merge https://github.com/FirebaseExtended/flutterfire/pull/3567 ?

@Salakar Hi!
Could you close this issue because of merge https://github.com/FirebaseExtended/flutterfire/pull/3567 ?


Support for iframe-video-area with a preview image first

What we want for video-iframes is this:
Editor set up an area that shall contain an embedded video and may also specify an (internal) preview-image.
Visitor sees initially: (both those that not has accepted and those who has accepted that category)
Preview-image and a play button on top of it.
If editor did not specify a preview-image a default is used.
(I.e. it only load data from us, never the external service)
When visitor presses image or play-button:
If visitor has accepted that service, the video with the iframe is displayed. (loading data from external service)
If visitor not (yet) has accepted it displays a text and buttons on top of the image (white-faded).  Just as iframemanager looks like when you not yet have accepted the service.
"Accept this", and ( "Accept all of type X" or "Open cookie settings" ). The first one only loads the iframe of that vidoe and the second one calls cookieconsent to accept all of that type or open dialog.
NOTE: Currently I have set this up myself with cookieconsent, and are not (yet?) using iframemanager.

What I think this boils down to is a feature request for a setting on categories to initially display only the preview image and another for the url of the image on top (the play button in this case). And handle the checking and displaying when someone clicks on it.

Sorry, this won't be worked on as I don't like the idea; it forces the user to take an extra step.


Update filter theme and add debouncing on the search bar

Notes for Reviewers
This PR fixes #

Remove the cardURL from the catalog card
update filter sidebar theme for mobile devices
add meshery filter icon
add debouncing on the styled search bar component

Signed commits

[x] Yes, I signed my commits.

Depends on this PR


Improve the case search stuff / showing info from existing cases in the filing interview

This is addressed in 243557dce6d2476cb57fe73bfdddac64b866e634