Relicense under dual MIT/Apache-2.0

This issue was automatically generated. Feel free to close without ceremony if
you do not agree with re-licensing or if it is not possible for other reasons.
Respond to @cmr with any questions or concerns, or pop over to
#rust-offtopic on IRC to discuss.
You're receiving this because someone (perhaps the project maintainer)
published a crates.io package with the license as "MIT" xor "Apache-2.0" and
the repository field pointing here.
TL;DR the Rust ecosystem is largely Apache-2.0. Being available under that
license is good for interoperation. The MIT license as an add-on can be nice
for GPLv2 projects to use your code.
Why?
The MIT license requires reproducing countless copies of the same copyright
header with different names in the copyright field, for every MIT library in
use. The Apache license does not have this drawback. However, this is not the
primary motivation for me creating these issues. The Apache license also has
protections from patent trolls and an explicit contribution licensing clause.
However, the Apache license is incompatible with GPLv2. This is why Rust is
dual-licensed as MIT/Apache (the "primary" license being Apache, MIT only for
GPLv2 compat), and doing so would be wise for this project. This also makes
this crate suitable for inclusion and unrestricted sharing in the Rust
standard distribution and other projects using dual MIT/Apache, such as my
personal ulterior motive, the Robigalia project.
Some ask, "Does this really apply to binary redistributions? Does MIT really
require reproducing the whole thing?" I'm not a lawyer, and I can't give legal
advice, but some Google Android apps include open source attributions using
this interpretation. Others also agree with
it.
But, again, the copyright notice redistribution is not the primary motivation
for the dual-licensing. It's stronger protections to licensees and better
interoperation with the wider Rust ecosystem.
How?
To do this, get explicit approval from each contributor of copyrightable work
(as not all contributions qualify for copyright, due to not being a "creative
work", e.g. a typo fix) and then add the following to your README:
## License

Licensed under either of

 * Apache License, Version 2.0, ([LICENSE-APACHE](LICENSE-APACHE) or http://www.apache.org/licenses/LICENSE-2.0)
 * MIT license ([LICENSE-MIT](LICENSE-MIT) or http://opensource.org/licenses/MIT)

at your option.

### Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted
for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any
additional terms or conditions.

and in your license headers, if you have them, use the following boilerplate
(based on that used in Rust):
// Copyright 2016 gitignore.rs Developers
//
// Licensed under the Apache License, Version 2.0, <LICENSE-APACHE or
// http://apache.org/licenses/LICENSE-2.0> or the MIT license <LICENSE-MIT or
// http://opensource.org/licenses/MIT>, at your option. This file may not be
// copied, modified, or distributed except according to those terms.

It's commonly asked whether license headers are required. I'm not comfortable
making an official recommendation either way, but the Apache license
recommends it in their appendix on how to use the license.
Be sure to add the relevant LICENSE-{MIT,APACHE} files. You can copy these
from the Rust repo for a plain-text
version.
And don't forget to update the license metadata in your Cargo.toml to:
license = "MIT OR Apache-2.0"

I'll be going through projects which agree to be relicensed and have approval
by the necessary contributors and doing this changes, so feel free to leave
the heavy lifting to me!
Contributor checkoff
To agree to relicensing, comment with :
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

Or, if you're a contributor, you can check the box in this repo next to your
name. My scripts will pick this exact phrase up and check your checkbox, but
I'll come through and manually review this issue later as well.

[ ] @nathankleyn
[ ] @m-n

@m-n As a contributor, would you be happy if I dual licensed this under Apache as described above?

I don't mind either way. I'll paste the magic words, so that I'm not blocking whichever decision you make.
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@m-n Thanks a tonne - that's awesome - I'll add the second license tonight and get this all sorted.

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.


Add Server Side Rendering

Hi, Would it be possible to have an Express server with SSR in this project?

Hi, @danjonesdev, I don't have any plans for SSR at the moment. You can fork the repo and add it by yourself. I will gladly help you with the implementation.

Sweet mate, I'll have a go at implementing this myself and will no doubt pester you in the near future! :)


Revert "Use cardano-config project from github."

This reverts commit 441115e3fe023144f633dd3e70c657738eca6024.
Further it introduces a new package cardano-git-rev to better capture what this code does.
Namely providing a mechanism for both cabal and nix to provide a git sha in the --version flag for cardano-node.

bors r+

bors r+

bors r+


Error on augment expr

pr off https://github.com/microsoft/typespec/pull/4849 that adds a breaking change that validate that you cannot augment model expression instead of just silently failing
Needs to be rebased when #4849 is merged

All changed packages have been documented.

:white_check_mark: @typespec/compiler
:white_check_mark: @typespec/openapi3

Show changes
@typespec/compiler - feature ✏

Overall of the symbol resolution. TypeSpec is able to resolve anything that can be statically linked. Augment decorators in turn are able to target any statically linkable types.

@typespec/openapi3 - internal ✏

Fix test host

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


Refactor sparse tensor code

This PR refactors the sparse tensor code according to the CR comments in this https://github.com/dmlc/mxnet/pull/5800.

Could you fix window build?
         c:\projects\mxnet\src\common\../operator/nn/cast_storage-inl.h(70): error C3861: 'accumulate': identifier not found (C:\projects\mxnet\src\operator\upsampling.cc) [C:\projects\mxnet\build\mxnet.vcxproj]

Awesome work!!! Thanks for refactoring the code. One step closer to the merge

The lint is clean. I will add "#include" to fix Windows build.

just to double check, did you test all the gpu tests?

Some gpu tests failed after the refactor: http://ec2-52-25-96-65.us-west-2.compute.amazonaws.com/blue/organizations/jenkins/mxnet/detail/PR-5800/85/pipeline


feat: integrate vllm

Feature description
https://github.com/vllm-project/vllm
Motivation
vllm is a tool for optimization of model serving. huggingface models etc. are supported - it is worth to have it
Additional context
No response

compare with lama.cpp


[crypto] Rename ValidKey to ValidCryptoMaterial

Motivation
Renaming ValidKey to ValidCryptoMaterial because it's used in signature payloads as well (not only keys).
Have you read the Contributing Guidelines on pull requests?
YES
Test Plan
N/A
Related PRs
No

btw, I'll hijack this PR to ask: what is the purpose of this trait?
It seems like it is not used without ValidKeyExt, and it seems like it is mostly used to derive serialization and deserialization.
In this case why not combining both traits? And why not renaming it to what it specifically targets: SerializableKey

@mimoo this is used in Serialization as well, and it states that only valid materials are serialized (in SerializeKey macro, this to_bytes is what goes to LCS)

@bors-libra delegate+
I also suggest ValidCryptoMaterialExt instead since it is extending ValidCryptoMaterial

:v: @kchalkias can now approve this pull request

@bors-libra r+

:pushpin: Commit 8150390 has been approved by kchalkias

:hourglass: Testing commit<PHONE_NUMBER>0b6dbd8432bcf42908280425432cba with merge ce8747fe246f0082cddfd70cd7f591621cb10ab7...

:broken_heart: Test failed - checks-actions_land_blocking_test

Looking in the cluster test failure(it most likely not related to PR)

@bors-libra retry

:hourglass: Testing commit<PHONE_NUMBER>0b6dbd8432bcf42908280425432cba with merge 5832eb7b8cd6348c3fe9c5405a819127fbcb245e...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: kchalkias
Pushing 5832eb7b8cd6348c3fe9c5405a819127fbcb245e to master...


Too many bubble column particles

There is an issue with the bubble_column_up particles produced by magma blocks underwater, when you stand right next to the magma blocks there will be way too many particles. This is probably because they don't despawn/pop on the way down like they do in vanilla.

This mod also is not compatible with Make Bubbles Pop mod. (bubble particles don't show at all)

btw I#m in 1.21 with the newest fabric loader and api and the newest version of the mod


Voice input

Hello! I've been playing with this for a while and thought I'd go ahead and open a PR to get some feedback. I'm not sure it's quite ready to be merged, but it's fairly usable at any rate.
This adds another option next to "speech" that supports voice command input. I don't have a whole lot of experience with ATC but I tried to match the readbacks and stuff so that saying the commands felt natural. I'm sure however that there could be more flexibility to support more accurate spoken commands. I tried to add "ducking" so that the "speech" and "voice" modules would respect each other. speech_say requests will queue up while you're speaking, and voice recognition will stop while speech_say is running. While potentially annoying, this does seem to add a bit of realism :) On the other hand, it would probably be nice to be able to reduce the frequency of arrivals when using this mode, since things quickly get unmanageable due to the delay caused by Chrome deciding whether or not you're done speaking.
One thing you'll notice is that there's a lot of comparing and filtering going on. The speech recognition provided by Chrome is apparently more suited to dictation, and while the spec calls for passing in grammar files, it seems that feature is not implemented by anyone. So, callsign recognition in particular has many layers of fallbacks to try to figure out which plane you might have actually meant.
Included is test/voice.js, a unit test file intended to be run with node.js. I just got so many weird results from Chrome's speech-to-text that I thought it would be good to document the cases to make sure algorithm tweaks didn't break recognition of other cases.
To run the test:
npm install -g mocha
npm install chai
cd test
mocha voice.js

One final thing to note is that Chrome will constantly ask you for permission to use the microphone unless this you're running on https. Github pages seems to support that, which is good, and it's easy enough to set up a self-signed cert for local testing. I used the server provided by npm install -g http-server  and run with hs -S.
Let me know what you think!

Wow, thanks! This is (rather obviously) a big change though, so it'll take a while to go through and make sure it doesn't break anything.

The ATC repository is being migrated to it's new home at https://github.com/openscope/openscope, and thus, all pull requests are being closed. If you would still like to see this merged into the simulator, please reopen the pull request at the new repo. Thank you!
Closing this PR.


[SSOC'23] Basic banking System Website

Describe the project
Hey @TusharKesarwani , I want to add "Basic Banking System" website. so please assign me this issue under gssoc'23.
Issue Type:

[ ] Bug Report
[ ] Feature Request
[ ] Documentation
[X] New Project

Screenshots (optional)

Hey @TusharKesarwani, please assign me this issue under SSOC'23.

https://github.com/TusharKesarwani/Front-End-Projects/issues/1498


Develop proposal to implement in-line images in EML schema

Both project pages and data papers need the ability to reference inline images and tables so they can be displayed at the appropriate locations in data paper or project page.  Modify EML to include such references.  The likely best way to do this is to 1) include all images and objects to be inlined as entities in the EML document, and 2) create a mechanism for referencing those locally.

Proposed to use Markdown in text blocks for image layouts. See https://github.com/NCEAS/eml/issues/275.


feat: remove eol images

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #690
Special notes for your reviewer:

Codecov Report

Merging #696 (ad94d9a) into main (8ae806a) will increase coverage by 0.00%.
The diff coverage is 28.57%.

:exclamation: Current head ad94d9a differs from pull request most recent head 3f64e3d. Consider uploading reports for the commit 3f64e3d to get more accurate results

@@           Coverage Diff           @@
##             main     #696   +/-   ##
=======================================
  Coverage   14.58%   14.58%
=======================================
  Files          13       13
  Lines        1694     1700    +6
=======================================
+ Hits          247      248    +1
- Misses       1419     1424    +5
  Partials       28       28

Flag
Coverage Δ

unittests
14.58% <28.57%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/scanners/trivy/trivy.go
0.00% <0.00%> (ø)

pkg/scanners/trivy/types.go
23.52% <33.33%> (-0.23%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[WIP] Testing PB for CRI-O + OpenShift Installer

Signed-off-by: Chris Evich<EMAIL_ADDRESS>

@cevich @mrunalp Is this still something we need want?

@rhatdan something we want(ed at some point), there's a trello-card for it.  No need to leave this stub PR sitting around though, can always re/open a new one.


logs: hide timestamp by default

while prepending log lines with timestamp may be a good feature, it must be disabled by default, the same way as all other programs do

An option should be added, but it's under discussion whether to enable this option by default. To me, it should be explicitly enabled by the node user if needed, otherwise the original behaviour should be preserved.

It's ok to print timestamp by default, if the program is intended for developers.
In case it's intended for users -- the default should be not to show timestamps.

Advanced logging with application timestamps can be output in debug mode. By default, debugging mode should be disabled. As an option, enable debugging mode depending on the application version; it will be enabled on pre-release versions.

I would not like to receive additional timestamps when enabling debug logging.
It should be a separate control or presence of controlling terminal.

Level is orthogonal to format. For now I tend to think that tty magic is the best way to handle the problem.


Documentation Spelling Issues in Arguments Markdown

The SBOM arguments markdown file contains several spelling issues. Proposing the following changes:
Line 17: Validate section - manifest

...certificate of the manfiest.

...certificate of the manifest.

Line 26: CatalogFilePath section - Add a space after sentence

...standard directory structure.The path

...standard directory structure. The path

Line 60: BuildListFile - included

...will be inlcuded in the generated manifest.

...will be included in the generated manifest.

Line 76: AdditionalComponentDetectorArgs - representing

respresenting command-line switches.

representing command-line switches.

Thank you for you contribution! Closing this as your PR has been merged.


Possible to have Challenge-Response (posession) AND Password (knowledge) security ?

Hi,
Is it possible with your ykfde initramfs hook (for archlinux :)), to do as you wrote:
1.) so use the challenge configured in the config file and send it to the key to receive the response
2.) and either before or after (or before AND after) this response to add a PASSWORD, that one has to type in every time (in addition to touching the yk4)
?
I think that would be awesome, becuase even if someone would have both laptop and yk4 they still would need the password like this.
Thanks a lot in advance,
Tormen

I believe this was included in your last PR. Can you confirm @Tormen ?

No, sorry, this came after. I will recreate PR.

Yes, in deed!

Yes, in deed!


ENOSPC: no space left on device, write

After following the instructions detailed on the README file, using Cloud9 for build and deployment I got the following error:
error /home/ec2-user/environment/amazon-chime-sdk-classroom-demo/node_modules/electron-chromedriver: Command failed.
Exit code: 1
Command: node ./download-chromedriver.js
Arguments:
Directory: /home/ec2-user/environment/amazon-chime-sdk-classroom-demo/node_modules/electron-chromedriver
Output:
/home/ec2-user/environment/amazon-chime-sdk-classroom-demo/node_modules/electron-chromedriver/download-chromedriver.js:21
    if (error != null) throw error
                       ^

Error: ENOSPC: no space left on device, write

My guess was that the EBS wasn't successfully resized when cloud9-resize.sh was called but, as far as I can tell the EC2 instance is using the right EBS with 100GB of space. I'm clueless

@oscarnevarezleal I am unable to reproduce this error. When I follow the Cloud9 README instructions it works for me. Just curious, which region did you try in?

🤦♂ I misspelled the region. It works.


Added python-networkx-pip

Added python-networkx-pip as the OS package manager python-networkx packages are all on the 1.x release series, whereas pip is on the 2.x series, which came out last September.

If we put this in, it will break any package that depends on the system installed version.

For some reason I had though just having the rosdep rule be a different name would avoid that, but that's clearly not the case, you're right. I'll look at other solutions. Thanks.


Dowload failed on Windows 11

should be fixed, please let me know if it works for you now

It worked


fix Makefile

I just encountered the following error, which can be fixed by this PR.
make: *** No rule to make target 'CHIME6_DIR', needed by 'cache/chime6.json'.  Stop.

Thanks.


Compilation Error

Hey,
I tried to compile your program, but I'm getting errors. First, I got a huge list of errors (I have a 800kb file that I can send you, if you want). I got rid of most of them by setting CMAKE_CXX_STANDARD to 17 in CMakeLists.txt, but one error remains:
[ 83%] Building CXX object CMakeFiles/OCM.dir/home/philipp/2024-pace-submissions/heuristic/13-kongqi/pace-2024-pace-2024/Test/TestCoreOCM.cpp.o
In file included from /home/philipp/2024-pace-submissions/heuristic/13-kongqi/pace-2024-pace-2024/Test/TestCoreOCM.cpp:14:
/home/philipp/2024-pace-submissions/heuristic/13-kongqi/pace-2024-pace-2024/Build/Linux/../../GOAL/ThirdParty/Protobuf.h: In function ‘std::string goal::protobufToJson(const T&, bool)’:
/home/philipp/2024-pace-submissions/heuristic/13-kongqi/pace-2024-pace-2024/Build/Linux/../../GOAL/ThirdParty/Protobuf.h:37:13: error: ‘using JsonPrintOptions = struct google::protobuf::json::PrintOptions’ {aka ‘struct google::protobuf::json::PrintOptions’} has no member named ‘always_print_primitive_fields’
   37 |     options.always_print_primitive_fields = true;
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/OCM.dir/build.make:132: CMakeFiles/OCM.dir/home/philipp/2024-pace-submissions/heuristic/13-kongqi/pace-2024-pace-2024/Test/TestCoreOCM.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/OCM.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

Do you have any idea what I can do to fix this error? I'm using Ubuntu 22.04 LTS.
Best
Philipp

OK, I got it to work, following this issue of another project that had the same problem: https://github.com/rizsotto/Bear/issues/566
In GOAL/ThirdParty/Protobuf.h, I replaced line 37
options.always_print_primitive_fields = true;

by
#if GOOGLE_PROTOBUF_VERSION < 5026000
    options.always_print_primitive_fields = true;
#endif

Together with the change in CMakeLists.txt outlined above, I could now compile the code.


  PLEASE DON'T ASK FOR WORKAROUNDS OR TIMELINES - THIS IS FREE SOURCE CODE
I tried to figure out how I can implement Actions into my Push Notifications. Something like that:

However I was not able to get it working (only tried on Android) and surfed the code a little.
I found that in the NotificationManager_Channels.cs

and saw that the ApplyChannel method never seems to be used in the project.
Is that the right method which should be applied for Notification Actions to work? If so and you want me to I could try to create a PR for that. Of course, if you know that Action Types are working for Android already and I did something wrong just let me know and I will try some other things
Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[ ] iOS
[ X] Android
[ ] UWP

PLATFORMS THAT YOU CANNOT FILE ISSUES ON RIGHT NOW: Tizen, watchOS, tvOS, macOS
Feature Library
beta components are not fully done - issues MUST include full reproducible sample and stacktrace or they will be closed without explanation!!!

[ ] Core
[ ] Locations
[ ] HTTP Transfers
[ ] Notifications
[ ] Push
[ ] Push - Azure Notification Hub
[X ] Push - Firebase (beta)
[ ] Sensors
[ ] AppCenter Logging Integration
[ ] Location Sync (beta)
[ ] Photo Sync (alpha)
[ ] BluetoothLE (beta)
[ ] Beacons (beta)
[ ] SQLite Integration

Version of Library
<IP_ADDRESS>2-preview
Version of OS(s) listed above with issue
Android 9 and 10
Steps to Reproduce

Set a channel:

var c = new Channel();
            c.Identifier = "benach";
            c.Importance = ChannelImportance.Critical;
            c.Actions = new List<ChannelAction>
            {
                new ChannelAction
                {
                    Identifier="o",
                    Title="OKAY",
                    ActionType= ChannelActionType.OpenApp
                },
                new ChannelAction
                {
                    Identifier="t",
                    Title="Text Reply",
                    ActionType= ChannelActionType.TextReply
                }
            };
            await NotificationManager.CreateChannel(c);
            await NotificationManager.SetChannels(c);

Send a Push Notification with a ChannelId OR a normal Notification:
await NotificationManager.Send(new Notification
            {
                Channel = "benach",
                Title = "Test",
                Message = "Hallo",
            });

Look how the Notification is shown

Expected Behavior

Actual Behavior

Sample
Be careful Sample is a bit messy :)
https://github.com/Codelisk/ShinyFirebasePushSample

Push has nothing to do with this.  The bug is 100% in the notifications library which has be resolved for the next preview release.


Standalone Version need "admin right" on windows

All the versions on the downlaod page "Standalone installers" need admin rights in windows. Is it possible to have a complete standalone version (with all in user space in windows) ?
Thanks
-->
Page URL:
https://www.qgis.org/en/site/forusers/download.html#

The osgeo4w installer doesn't need admin rights.

Yes, thank you.
You can close this issue.


should I put useQuery inside a useEffect and should I store returned data in state?

Still wrapping my head around using this library with modern react hooks patterns.
Because data fetching is considered a side effect I've seen this pattern a lot in tutorials and docs.
const [data, setData] = useState([]);
  useEffect(() => {
    fetch("http://localhost:3001/links/")
      .then(response => response.json())
      .then(data => setData(data));
  },[]);

Should I be doing a similar pattern with this library? ie putting useQuery in useEffect and storing the data returned from useQuery inside useState
Or can I simply just use useQuery as is and directly access the data returned in my components.
Lets assume I'm just building a simple todo app where I want to create, update and delete todo items.

I don't store return data from query to react state. I just feel like that's an anti-pattern. You should just use the returned data as it is like below:
const { loading, data, error } = useQuery(SOME_QUERY)

if (loading) return <Loader />
if (error) return <Error />

// safe to assume data now exist and you can use data.
const mutatedData = React.useMemo(() => {
  // if you want to mutate the data for some reason
  return data
}, [data])

return <YourComponent data={mutatedData}  />

But if you must store the returned data, could do below:
const { loading, data, error } = useQuery(SOME_QUERY)
const [state, setState] = React.useState([])

React.useEffect(() => {
  // do some checking here to ensure data exist
  if (data) {
    // mutate data if you need to
    setState(data)
  }
}, [data])

Yeah the useQuery should be already an "effect" hook, so you don't have to do that inside useEffect.
the useEffect was meant for async stuff, like fetch, but the useQuery is not an async function, it will immediately return result (loading:true, data:null). Then re-return the result when data is ready. so it does not have to be in useEffect.

the useEffect was meant for async stuff

It's meant to perform any side effects from state changes. Async stuff is one use case. Using apollo to fetch data, I rarely use useEffect for async fetching.

Thanks @jinshin1013, useMemo is a nice idea since setting state for mutated data in onCompleted was causing an infinite loop (onCompleted called infinitely)

const { loading, data, error } = useQuery(SOME_QUERY)

if (loading) return <Loader />
if (error) return <Error />

// safe to assume data now exist and you can use data.
const mutatedData = React.useMemo(() => {
  // if you want to mutate the data for some reason
  return data
}, [data])

return <YourComponent data={mutatedData}  />

React throws compile time error that you can't use useMemo conditionally.
React Hook "useMemo" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?

You are right. No need to use useMemo.

What do you think in the case you have for example 3  Components that the 2do one values depend on the 1st one, and the 3rd one depends on the 2nd one.
So we need need to use 3 interdependent useQuery calls  in the same Component.
Do you think in that case will have the sense to use several useEffect?

@JuanmaMenendez I running into this issue myself. Did you find a solution to this or find a better way to structure your queries?

@mmborado there is no need to use useEffect.
You should add the skip  property to the dependent useQuery
Example:
//first query
const { data, error, loading } = useQuery(GET_DOGS);

//second query that depends on the first one.
const result2 = useQuery(GET_BREEDS, {  skip: !data,  variables: { dogId: data && data.dogs[0].id },});

@mmborado @JuanmaMenendez You could always use the apollo client directly and create a custom hook like:
const useCompoundQueries = () => {
  // Grab the Apollo client
  const client = useApolloClient()

  const [data, setData] = useState(null)
  const [loading, setLoading] = useState(false)

  async function runQuery() {
    // Set the loading true.
    setLoading(true)

    // Manually query your queries.
    const query1Result = await client.query({ query: QUERY1 })
    const query2Result = await client.query({ query: QUERY2, variables: {...} })
    ..... rest of the logic

    // Reset the loading state.
    setLoading(false)
    setData(data)
  }

  // You can either start the query when this gets mounted or manually run it.
  useEffect(() => {
    // Automatically run the query if you want
    runQuery()
  }, [query])

  return {
    loading,
    data,
    runQuery,
  }
}

It's very simplified and haven't tested but you get the idea.

@jinshin1013  honestly I think to use the skip property is much easy and cleaner but it is always good to see different solutions to a problem, thanks for your answer.

But if you must store the returned data, could do below:
const { loading, data, error } = useQuery(SOME_QUERY)
const [state, setState] = React.useState([])

React.useEffect(() => {
  // do some checking here to ensure data exist
  if (data) {
    // mutate data if you need to
    setState(data)
  }
}, [data])

How can use the loading and error variable when I am storing the returned data using useEffect hook?

something like this?
useEffect(() => {
    // here, you can use loading and/or error variable, for example:
    if(loading === false && data){
        setState(data);
    }
}, [loading, data])

So what is the answer? lol

Optionally using refetch (or poll), (?)
From Apollo docs,

Refetching enables you to refresh query results in response to a particular user action, as opposed to using a fixed interval.
(Apollo-refeching)
(with optionally setting up the caching strategy)

function App () {
    const { loading, data, refetch } = useQuery(THE_QUERY);

    return (
      loading
        ? <div>..loading</div>
        : <ComponentWIthFormAndView refetch={refetch} /> // call refetch after a user action
    )

  }

I don't store return data from query to react state. I just feel like that's an anti-pattern. You should just use the returned data as it is like below:
const { loading, data, error } = useQuery(SOME_QUERY)

// If you absolutely need to cache the mutated data you can do the below. But
// most of the time you won't need to use useMemo at all.
const cachedMutatedData = useMemo(() => {
  if (loading || error) return null

  // mutate data here
  return data
}, [loading, error, data])

if (loading) return <Loader />
if (error) return <Error />

// safe to assume data now exist and you can use data.
const mutatedData = (() => {
  // if you want to mutate the data for some reason
  return data
})()

return <YourComponent data={mutatedData}  />

But if you must store the returned data, could do below:
const { loading, data, error } = useQuery(SOME_QUERY)
const [state, setState] = React.useState([])

React.useEffect(() => {
  // do some checking here to ensure data exist
  if (data) {
    // mutate data if you need to
    setState(data)
  }
}, [data])

If use setState inside the useEffect, isn't going to re-render the component thus create an infinite loop?

I don't store return data from query to react state. I just feel like that's an anti-pattern. You should just use the returned data as it is like below:
const { loading, data, error } = useQuery(SOME_QUERY)

// If you absolutely need to cache the mutated data you can do the below. But
// most of the time you won't need to use useMemo at all.
const cachedMutatedData = useMemo(() => {
  if (loading || error) return null

  // mutate data here
  return data
}, [loading, error, data])

if (loading) return <Loader />
if (error) return <Error />

// safe to assume data now exist and you can use data.
const mutatedData = (() => {
  // if you want to mutate the data for some reason
  return data
})()

return <YourComponent data={mutatedData}  />

But if you must store the returned data, could do below:
const { loading, data, error } = useQuery(SOME_QUERY)
const [state, setState] = React.useState([])

React.useEffect(() => {
  // do some checking here to ensure data exist
  if (data) {
    // mutate data if you need to
    setState(data)
  }
}, [data])

Thank you so much, I was about to pluck my eyes out, now I can sleep peacefully. This solved my problem.

Is there any way to use multiple queries before a component render inside the component itself?

I don't store return data from query to react state. I just feel like that's an anti-pattern. You should just use the returned data as it is like below:

If data is a collection, and you're going to mutate that data, I often see people attaching refetch queries on the mutation to pull it all back from the server after adding/removing. This seems like an anti-pattern.
Instead, it is better to use the returned data from the query as state, then add or remove the results of the mutation to it. No refetch.

Is there a reason why my example below fetches 4 times? Using @jinshin1013's example above fetches only once, but that feels like it is defeating the purpose of Apollo Client and I don't know if I am losing caching benefits (not to mention loading, error, etc.)
import { useQuery } from "@apollo/client";
import { OneExample } from "./query";

export const Example = () => {
  const id = "FVox336y";
  const { data, loading, error } = useQuery(OneExample, {
    fetchPolicy: "cache-first",
    variables: {
      accessId: id,
    },
  });

  return loading ? "loading" : "data";
};

I don't store return data from query to react state. I just feel like that's an anti-pattern. You should just use the returned data as it is like below:
const { loading, data, error } = useQuery(SOME_QUERY)

// If you absolutely need to cache the mutated data you can do the below. But
// most of the time you won't need to use useMemo at all.
const cachedMutatedData = useMemo(() => {
  if (loading || error) return null

  // mutate data here
  return data
}, [loading, error, data])

if (loading) return <Loader />
if (error) return <Error />

// safe to assume data now exist and you can use data.
const mutatedData = (() => {
  // if you want to mutate the data for some reason
  return data
})()

return <YourComponent data={mutatedData}  />

But if you must store the returned data, could do below:
const { loading, data, error } = useQuery(SOME_QUERY)
const [state, setState] = React.useState([])

React.useEffect(() => {
  // do some checking here to ensure data exist
  if (data) {
    // mutate data if you need to
    setState(data)
  }
}, [data])

Good

I found that in the doc, you can use "useContext" and it will bring up a promised based query helper for you instead. Use that if you don't want to use hooks.
https://trpc.io/docs/useContext


Release git history borked

Looks like we forgot to merge 0.3.2 release back into main.  When I erroniously rebaseed main to release for the 0.4.0 release, the merge from release to main will add duplicate commits.

[ ] fix git history
[ ] Document click by click release steps here: https://github.com/Kitware/nrtk-explorer/pull/127/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R69-R73
[ ] Maybe simplify steps.  Like just target main for manual semantic release job and drop release branch.

There is a CI job that merges release to main after every commit in release. Unfortunately it did not trigger since there has been a change in the branches settings for push requirements.
The error was:   Changes must be made through a pull request. // See: https://docs.github.com/rest/branches/branches#merge-a-branch I have changed the settings to solve this.
The rationale for having a release branch is that we wanted to have an state in master that was different to the release. This was specially important for features that took multiple PRs. Having a release branch gives us control into what goes in a release (which it was needed).

There are not duplicated commits, there are either backported commits to the release branch (that was the reason of having a release branch) or you are seeing a merge commit. We want to always merge release to main (we do an -s ours merge) to avoid future merge conflicts.

Is it OK that we don't automaticly merge release back to main after semantic release makes its version commit?
Do we need to merge release back to main for 0.4.0 right now?

Is it OK that we don't automaticly merge release back to main after semantic release makes its version commit?

It is safer to merge after releases so that releases are reachable from main and also we avoid potential merge conflicts in the future.

Do we need to merge release back to main for 0.4.0 right now?

it is already merged https://github.com/Kitware/nrtk-explorer/commit/1c9359e87b4e0255ab232b32263680f8314f043f

You might want to close this since this was solved by restoring the github branch settings.


Add a tag when scenario used invalid/unknown severities

Add a tag when scenario used invalid/unknown severities
Context
Currently, the scenario which use an unknown severity (like ihghinstead of high) are marked with the flag No Severity.
Expected
Scenario with invalid/unknown severities or countries should show in executions (with the same CSS as the No Severity) with the label Wrong Severity! (or Wrong Country!).

add @prerequisite flag to avoid the @no-severity flag


Emitted Transactions fee is too high

Issue Description
Emitted Transactions fee is too high
Steps to Reproduce

node doubler.js saUC1cTtSLiD9hfGWmC4gqifX4ub2

node pay.js sn8NQoG6cwwhgyhMpNWDDfhppE1yZ 1 rNFokMEF3VEHLd5t8SKC1KNS9vhvtPgnvA

when got the etmitted tx
./rippled tx A27866C93C2B0D3C573FC1A3B8CBA5E186BE4C41D5A2DCC44C3CD214546BED20
{ "result" : {    "Account" : "rNFokMEF3VEHLd5t8SKC1KNS9vhvtPgnvA",    "Amount" : "2000000",    "Destination" : "rGMWrC2cStr8gHsH2QWtwfbUue5gGbWARL",    "DestinationTag" : 0,    "EmitDetails" : {       "EmitBurden" : "0000000000000001",       "EmitCallback" : "rNFokMEF3VEHLd5t8SKC1KNS9vhvtPgnvA",       "EmitGeneration" : 2,       "EmitNonce" : "39938C2A0F93238F44D2961E1A741A39E7D3EDC52E9DEC415A01A9BA403B9289",       "EmitParentTxnID" : "18AE8BFFC65C6067FF07AAF43319C58CB7AF8A17D7B7EB89C56ED24CDBF43F06"    },    **"Fee" : "81468750",**    "FirstLedgerSequence" : 1143886,    "Flags" :<PHONE_NUMBER>,    "LastLedgerSequence" : 1143890,    "Sequence" : 0,    "SigningPubKey" : "000000000000000000000000000000000000000000000000000000000000000000",    "SourceTag" : 0,    "TransactionType" : "Payment",    "date" : 675583570,    "hash" : "A27866C93C2B0D3C573FC1A3B8CBA5E186BE4C41D5A2DCC44C3CD214546BED20",    "inLedger" : 1143886,    "ledger_index" : 1143886,    "meta" : {......

Result
the fee is 81XRP, is too high.
Environment
wss://hooks-testnet.xrpl-labs.com

Discussion: https://github.com/XRPL-Labs/xrpld-hooks/discussions/16

https://hooks-testnet-explorer.xrpl-labs.com/tx/5D0AFFCF9EBDDB60B0BB4233FB4E78E6D910D95754B8EA57E563C66F0AEED5BA

Migrated from Discussion:

Discussed in https://github.com/XRPL-Labs/xrpld-hooks/discussions/16

Originally posted by yxxyun May 28, 2021
Just test the doubler:

@RichardAH

A simple XRP transaction emission from hook cost around 81 XRP as of testing.
Sample code: high_fee.zip
Running Instructions.

Run the run.js file with following parameters.

Hook secret
Rippled server URL

node run.js sn6Eh5HPDsmsPG4RgnHCVFSgoo7FH ws://localhost:6005

Note:

The script will compile the hook code.
Create the hook account with given secret.
Upload to the hook account.
Emit transactions to invoke transaction emission from hook.


[BUG]: [UAT | No pending task shown after Advocates chose their Opt-Out dates in UAT]

Describe the bug
No pending task shown after Advocates chose their Opt-Out dates in UAT
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hi @rajeshcherukumalli tested in uat env, working fine

cc : @Ramu-kandimalla


Poor example

If you create acr like using the following terraform resource than any example from documentation does not work.
resource "azurerm_container_registry" "this" {
  name                          = var.name
  resource_group_name           = var.resource_group
  location                      = var.location
  sku                           = "Premium"
  public_network_access_enabled = false
  anonymous_pull_enabled        = true

  network_rule_set {
    default_action = "Deny"

    virtual_network = [
      for subnet_id in var.allowed_subnets_ids : {
        action    = "Allow"
        subnet_id = subnet_id
      }
    ]
  }
  tags = {
    Terraform = true
  }
}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: dcf0e2ac-c706-a08d-c667-ecbd073a8fdb
Version Independent ID: 2b3a8b16-e689-8cc5-3134-af72f351e08d
Content: Build and push Docker images to Azure Container Registry - Azure Pipelines
Content Source: docs/pipelines/ecosystems/containers/acr-template.md
Service: azure-devops
Sub-service: azure-devops-ecosystem
GitHub Login: @azooinmyluggage
Microsoft Alias: atulmal

@Draqun -- Damian, thank you for your feedback.  I'm not sure what your sentence is trying to convey.  Please add more details.

Hi.
Well, none of the examples in the documentation include examples of how to push an image to a repository, built using the script above. As you can see, the repository (Azure Container Registry) is not public, and also rejects connections from outside the indicated networks (The var.allowed_subnets_ids variable contains information about the subnet within which the function runs). For security reasons, the repository cannot be public. Without anonymous_pull_enabled the function will not download the image, and filtering by subnets cuts off Azure Devops. How to get around this?

@Draqun -- Damian, thank you for your follow-up.  Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

Hi. Give me a week, I need find some time to read it and verify it works. Anyway I still thinking documentation has a lot of lacks.
Best regards.
Draqun

@Draqun -- Damian, I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


Add depth control

To safely keep files off git, I often keep my projects as
.
├── gorv
│   ├── site
│   └── originals
├── slate
│   ├── site
│   └── originals

So running wipe-modules on . won't work.
Perhaps getopts can be implemented to safely get arguments and flags instead of using $1/$2/...
The tree command I used to generate that display above has the flag -L
usage: tree [-acdfghilnpqrstuvxACDFJQNSUX] ...
  ------- Listing options -------
  -L level      Descend only level directories deep.

@bfred-it Mm... interesting, any ideas on how to implement it?
Talking about depth control, that also could help finding the exact old projects in the directory.
Currently, to determine how "old" a project is wipe-modules checks the last modification date (mtime) of each project directory, the thing is... That date value only changes when a root level file is modified, not subdirectories, and most of the time when working on a project modification in files inside folders occur.
So implementing depth control will also help to solve that, to find with better precision, and obviously, to better locate the structure to work on as you said.

I think it's as easy as mapping a --level flag to find . -maxdepth $level. The $d in wipe "$d" will automatically be gorv/site, no longer gorv. Implementation details of how you figure out how old a project is is irrelevant to this specific feature, I believe.

Yep right, and yeah that may be the way to go.

Yeah I just found some node_modules from an old project that were never found because they were 3-4 levels deep

A little update, today I was working on implementing depth control, so far it does the searching of the modules at the specified level, the only thing that's left to implement is to actually move to the directory and remove the node_modules folder.
Also, I added support for getopts as @bfred-it suggested.

@bfred-it Any reason this was never published to NPM as a new version?

@pix2D the functionality for depth control is not 100% complete yet, so far the program only shows you what can be removed but not an option to remove the found modules, I'll be working on this beginning January and then publish version 1.3.0, meanwhile, a pull req is appreciated 😄happy new year! 🎉

I ended up just always using this. If I need some project I'll reinstall it.
# This shows what it will delete
find . -name node_modules

# This will delete all the folders
find . -name node_modules -exec rm -r "{}" \;


Add graph functionality

Starting from @avanetten's https://github.com/cosmiq/apls/src/graphTools.py, re-write code to load a graph from a geojson/write a graph to a geojson.

Resolved with #11.


Fix pom issues when deploying to OSSRH

Following error occurred during deployment to OSSRH:
[ERROR] Rule failure while trying to close staging repository with ID "iotheves-1002". [ERROR]  [ERROR] Nexus Staging Rules Failure Report [ERROR] ================================== [ERROR]  [ERROR] Repository "iotheves-1002" failures [ERROR]   Rule "pom-staging" failures [ERROR]     * Invalid POM: /io/theves/denon4j/0.7/denon4j-0.7.pom: Project name missing, SCM URL missing [ERROR]  [ERROR]  [ERROR] Cleaning up local stage directory after a Rule failure during close of staging repositories: [iotheves-1002] [ERROR]  * Deleting context bb5aca8e15958.properties [ERROR] Cleaning up remote stage repositories after a Rule failure during close of staging repositories: [iotheves-1002] [ERROR]  * Dropping failed staging repository with ID "iotheves-1002" (Rule failure during close of staging repositories: [iotheves-1002]).

Works since commit 22a7124


Estimated time of arrival for next release?

The latest version npm of vscode-languageserver is 5.2.1, which was released 6 months ago, any ETA for a new release?

We are working on a new release. There are already 5.3.0-next.* versions available.

There is no concrete ETA. Are you looking for any specific feature?


Post merge promote aux coord to dim

✨ Feature Request
Suggestion: After merge, if the result has multiple aux coords representing the same dimension, and all but one contain a single repeating point, then that one coord should be promoted to a dim coord, and the others demoted to scalars.
Motivation
When loading certain model output, the pressure coord for geopotential height is not a dim coord, it's an aux coord. There is a forecast period and a time coord, for the same dimension, which contain a single reapeating value. This doesn't happen for other cubes in the same file, which get normal pressure dim coords. This causes the saved netcdf output to contain two separate pressure coordinates, causing problems downstream - mainly in Met and ncview, I think. Ncview also doesn't seem to realise it's pressure at all, it's just called dim0 and shows up as indices instead of pressure levels.
Additional context
We can work around this using loading callbacks.

First, I should warn that many attempts to 'incrementally improve' merging (and especially merge-on-load) have already fallen due to the 'too much breaking change' problem !
For instance : #3344 #3603
All the same, we can look into this, because the behaviour seems odd to me..
Given that you are loading "model output" I guess this is PP or FF format data ?
In which case, all dimensions except the horizontal are split across multiple input fields, and hence must be re-constructed by the merge operation (within the load function).
What puzzles me about this, is not so much having coords on a common auxiliary dimension, but rather why merge is creating those coords with repeating values instead of making them scalars.
The examples I have tried result in scalar coords.
It's not, by any chance, because your load specifies some additional constraint which is post-indexing the results ?
To debug this, I think you should print out what the "raw cubes" are before the merge -- i.e. results from iris.load_raw.
If you could show what that looks like, we can work out what is going on here.

Hi @pp-mo , I pasted a link to the input file in the internal avd forum. I was advised not to include that in this public area.
I can stop the problem happening by loading raw slices and extracting forecast_period=6. They then merge correctly. Without the fp extraction, a couple of pressure levels get extra slices, for other forecast periods, and that seems to stop the merge for working. Is that helpful info?

@SciTools/peloton there may be something odd going on here, but we probably don't have time to investigate.
From offline discussion, a workaround is available for the original problem, anyway.
So closing :-(
Unless it's a real problem for someone ?  -- in which case please re-open.


Rename 2_[目标检测]和[实例分割]任务数据标注.md to 2_[实例分割]数据标注.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: Added a service for displaying snacks

Checklist
A service has been written that will help you use flutter_easy_dialogs to display snacks "out of the box".
https://github.com/surfstudio/surf-flutter-app-template/assets/39735343/142d53c3-d05f-4d2c-b4de-421ab6411766

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Is there an existing issue for this PR?

link issue here (use keywords like fix, close, resolve etc. if necessary)

[x] Have the files been linted and formatted?
[ ] Have the docs been updated to match the changes in the PR?
[ ] Have the tests been updated to match the changes in the PR?
[x] Attached videos/screenshots demonstrating the fix/feature.
[ ] Have you run the tests locally to confirm they pass?

New Features
What new capabilities does this PR add?
What docs changes are needed to explain this?

Codecov Report
Attention: Patch coverage is 0.77519% with 128 lines in your changes are missing coverage. Please review.

Project coverage is 23.25%. Comparing base (339c48c) to head (59786b9).
Report is 17 commits behind head on main.

Files
Patch %
Lines

...tures/snack_queue/presentation/snack_queue_wm.dart
0.00%
61 Missing :warning:

...k_queue/presentation/default_snack_controller.dart
4.16%
23 Missing :warning:

...tures/debug/presentation/ui_kit/ui_kit_screen.dart
0.00%
18 Missing :warning:

.../features/debug/presentation/ui_kit/ui_kit_wm.dart
0.00%
8 Missing :warning:

...s/snack_queue/presentation/snack_queue_widget.dart
0.00%
5 Missing :warning:

...snack_queue/presentation/snack_queue_provider.dart
0.00%
4 Missing :warning:

...atures/snack_queue/presentation/top_snack_bar.dart
0.00%
4 Missing :warning:

lib/l10n/app_localizations_en.g.dart
0.00%
2 Missing :warning:

lib/l10n/app_localizations_ru.g.dart
0.00%
2 Missing :warning:

...es/snack_queue/presentation/snack_queue_model.dart
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   26.39%   23.25%   -3.14%
==========================================
  Files          55       61       +6
  Lines         917     1045     +128
==========================================
+ Hits          242      243       +1
- Misses        675      802     +127

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow a user to associate an ephemeral public IPv4 address with the runner instance

Useful in cases where a user wants to deploy the instance in a non-default public subnet (one for which automatic public IP assignment is disabled).
Should retain backwards compatibility (defaults to false).
Fixes #52.

@machulav Do you have automated tests to test this with?

Closing, in favor of leveraging EC2 launch templates to set spot options (see #65)


add the subtract function and a test - resolves #2

This pull request adds the subtract function and a test.
resolves #2

Looks good to me!


225 runtime panic when an asset is finalized before an investor list is assembled

Added a check to prevent owner share distribution if there are not enough funds in Fees_account

Codecov Report

Merging #226 (3bc1490) into main (51e926a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   81.49%   81.51%   +0.02%
==========================================
  Files          58       58
  Lines        5463     5465       +2
==========================================
+ Hits         4452     4455       +3
+ Misses       1011     1010       -1

Impacted Files
Coverage Δ

node/src/chain_spec.rs
0.00% <ø> (ø)

pallets/share_distributor/src/lib.rs
85.71% <ø> (ø)

runtime/src/lib.rs
11.00% <ø> (ø)

pallets/share_distributor/src/functions.rs
91.66% <100.00%> (+0.98%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


New-HTMLTable - List of Features Plugins we should consider

List of different plugins we should consider:

https://cdn.datatables.net/plug-ins/1.10.21/
https://cdn.datatables.net/plug-ins/1.10.21/features/
https://cdn.datatables.net/plug-ins/1.10.21/integration/

[ ] Font Awesome integration - https://datatables.net/blog/2014-06-06
[ ] https://stackoverflow.com/questions/44982621/how-to-use-datatables-font-awesome-icons
[ ] https://datatables.net/forums/discussion/55874/font-awesome-plus-circle-and-minus-circle-instead-of-image-for-controlling-child-rows
[ ] https://datatables.net/examples/api/row_details.htm

Is there a current way to link HTMLTables to Charts, similarly like you're able to do with Digrams where you can click on a node to find it in a table? I'd like to be able to click on a pie or bar chart and have it auto-lookup the data in a Table.

Open another issue for it. It's not possible now but possible to integrate I think. Make sure to fully describe how you see it.


[Improve] Improve streampark-flink module based on [3.5 Concurrent Processing]

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
[Improve] Improve streampark-flink module based on 3.5 Concurrent Processing
Usage Scenario
No response
Related issues
#2986
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

i pick it

Please apply to close this issue


first steps towards zenojam submission, includes downward raycast

@Thaewyn you can keep working on this branch, I'm not deleting it


Let node set the Z Values of its children

After testing the z_value of nodes I think it would make sense to offer a checkbox which lets
a node also set the z value of its children.
I think at that same point maybe a checkbox for child nodes ignore the parents z value.
This will give a quick opportunity to set the z values of many nodes whithout going through each single node.
So in conclusion. I think 2 checkboxes would be nice.

set child z
ignore parent z

why not a checkbox that says "inherit parent z"?

added that today
On Tue, Jan 13, 2015 at 9:15 PM, Manson Mamaril<EMAIL_ADDRESS>wrote:

why not a checkbox that says "inherit parent z"?
—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/issues/1194#issuecomment-69847626.

So this can be closed


Algorithm accuracy

Hi, everyone,
first of all congrats by this project. Great work !
it's just a suggestion, not really an issue:

implement the algorithm accuracy to show us how accurate the trainning is!
Thank you very much

I have just implemented !! if you interested
it gives us the coefficiente of determination R^2 of the prediction
same algorithm used on sklearn (LinearRegression) score() method.
double simple_linear_regression::r2()
{
double avgX = sigma_X / X.size();
double avgY = sigma_y / y.size();
double y_intercept = avgY - m * avgX;

double smyres = 0.0;
double smres = 0.0;
for (int i = 0; i < y.size(); i++){
    double yres = pow(y[i] - y_intercept - (m * X[i]), 2);
    smyres += yres;
    // current residual square
    double res = pow(y[i] - avgY ,2);
    smres += res;
}

return ((smres - smyres) / smres);

}


elmah.MVC, remote Access, Too many redirects after enabling requiresAuthentication

Hi
I enabled requiresAuthentication and used allowedRoles with 'admin' value (enabling AuthCaseSensitive).
When accessing /elmah from remote, it correctly redirects me to /Account/Login.
But after I log in and it redirects me to /elmah, it seems elmah cannot distinguish that I'm logged in and redirects me back to /Account/Login which results in too many redirects.
Did I perform anything wrong?

I resolved the issue.
I had also enabled 'allowedUsers' option with '?' value. That was the problem.


Add coverage badge and skip coverage on tools/cmd

Codecov Report

Merging #77 into master will increase coverage by 32.43%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #77       +/-   ##
===========================================
+ Coverage   49.11%   81.54%   +32.43%
===========================================
  Files          25       19        -6
  Lines        2079     1252      -827
===========================================
  Hits         1021     1021
+ Misses        992      165      -827
  Partials       66       66

Impacted Files
Coverage Δ

tools/otdgen/simple_array.go

tools/otdgen/model_dict.go

tools/otdgen/model_array.go

tools/otdgen/otdgen.go

tools/otdgen/simple_dict.go

tools/otdgen/struct.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bacd802...cb61a45. Read the comment docs.


DevTools appends duplicate fonts on HMR change

Every HMR change of nuxi dev, the DevTools for fonts appends a new duplicate of the font files in use. No changes are made elsewhere
https://github.com/user-attachments/assets/896de0e7-28f0-4c05-9b5e-3b872db73d7c
This is an effectively empty new Nuxt project, using the local provider.
Here's the project that's behaving this way. Outside of eslint being installed it's an empty new Nuxt 3 project so can be used as a minimal reproduction.

I think this line is causing the issue

Thanks for the tip @arashsheyda!
Problem here is indeed that the fonts variable might already contain the font that's passed into the function when HMR runs. I'm not too familiar with the flow of data here, so not entirely sure if my solution is correct, but I'll open a PR in a sec here that checks if the font already exists in the 'loaded fonts' array before putting it in again and broadcasting it.


Bump to latest uptest and build submodule

Description of your changes
Bumping uptest and build submodule to latest.
I have:

[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
I'll test with e2e workflow.

/test-examples="examples/iam/user.yaml"


Paper properties

Paper size enum for A1, A2, A3, A4, A5, A6 etc
Pass margins
Paper orientation (for when paper size enum used)
Set specific paper size. Unit to start with mm

Also include fonts.


Add test cases to test one or both missing scales

This PR is adding test cases.
The goal is to test the annotations behaviors when one or both scales are missing.

@LeeLenaleee it seems there is a issue with CC: https://docs.codeclimate.com/docs/fetch-failed. Could be the integration between GH and CC?

Don't know but since its only test's that have been added in this PR I wouldn't worry about it


add turkish language to audio-transformers-course

I have translated from chapter 0 to chapter 2 but If I have enough time to translate, I will do it. 🤗

Hi @tanersekmen ! Thanks a lot for translating the first few chapters. Two more files need to be updated in order to build the course in a new language - .github/workflows/build_documentation.yml and .github/workflows/build_pr_documentation.yml.
Please add tr to the list of languages similar to how it's done here.

Hi @MKhalusova, okay.
I missed that part.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hi, @merveenoyan, can you check my PR when you have time?  I can not see any problem in the preview section.

@tanersekmen sanırım çeviride openai gibi bir model kullanıp kendiniz çevirmemişsiniz, benim bu PR'ı kaçırmam kötü olmuş. Bunu düzeltmek ne yazık ki çok vaktimi alacak, lütfen bir daha böyle bir PR açmayın.


add commemt and change import

sorry if it not correct

@googlebot cla?

What is this PR attempting to do? Could you describe the problem you're attempting to solve?


Rename suggestion: "Mozilla Persona" to "Mozilla/Firefox"

Because when I tried it, I have to register firefox.com first.
After I got firefox.com account, I was able to create mozilla.org account.
(and the deletion step was easy. just suggesting a title rename)

https://addons.mozilla.org/en-US/firefox/
https://oauth.accounts.firefox.com/
https://accounts.firefox.com/oauth/signin...

I actually removed it, because the service was shut down.


Download speed too slow

Steps to reproduce
1.go to any manga
2.click on download icon next to any chapter
3.The download speed is extremely slow.
Expected behavior
The chapter should have downloaded at a decent speed close to my wifi's download speed.
Actual behavior
The download speed is 100 times slower than my wifi's download speed(6 MBps).
The download speed is somewhere about 40-60 KBps.
Crash logs
No response
Mihon version
0.16.5
Android version
Android 14
Device
Realme GT 6T
Other details
The loading speed is good, so the chapters are easily readable with an active internet connection, but the download speed is horrible.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Mihon doesn't have, associate, or provide any extensions/content. Just cause you have internet/"fast download speed" doesn't mean there isn't other factors.
Could be ratelimited by the source or whatever extension you're using to reduce the chance of you getting blocked from them. Check with whoever maintains your extensions instead to see if there's anything they know about this.


Fix handling of controlflow ops when control flow is in basis

Summary
This commit fixes the handling of ControlFlowOps in the Unroll3QOrMore transpiler pass when the the control flow ops are in the basis set. Previously, the check for whether the operation was native to the target was done before recursing into the control flow block. This effectively skipped the conversion that should have happened in the block. To fix this the control flow operation handling is moved before the basis check. Later passes (mainly basis translation) will fail if the control flow operations aren't available on the target and we should always recursively unroll gates in this pass.
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
72 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 84.67%

Files with Coverage Reduction
New Missed Lines
%

src/sampled_exp_val.rs
14
63.93%

src/results/marginalization.rs
58
55.17%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
61866

Relevant Lines:
73067

💛  - Coveralls

Just manually updating the PR so it'll automerge after only one run of tests rather than two, since this PR is on the critical path for 0.22rc2.


Update build script to use std=c++11

Checklist

[X] Used a fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[X] Ensured the license file is being packaged.

Explicitly tell CMAKE to use the C++11 standard to solve compatibility issue with legacy Fermitools code

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


use the prop-types package (propTypes deprecated)

Hi ! Firstable, thank you for react-skylight, it works fine for me !!
Since a few weeks, there is an error for everyone :
"Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead."
The problem is : I installed prop-types but the error is still visible.
After doing what brianvaughn recommanded, it figured that the problem comes from react-skylight
http://stackoverflow.com/questions/43303761/accessing-proptypes-via-the-main-react-package-is-deprecated
Can you fix it ?
Thank you again !!

Hi,
New version 0.4.2 fix this issue.


Updated logrus-logstash-hook for logrus 1.0.3 compatibility fix

Coverage remained the same at 77.114% when pulling 409dfda338de593b29e4aad56a605590241ae24f on hotfix/logrus-logstash-hook into 65bfc842bdc30b48d6cf9a6e28c474993398d420 on master.

Coverage remained the same at 77.114% when pulling 103146630b71b5ca6a9c373d23888eb980359225 on hotfix/logrus-logstash-hook into 65bfc842bdc30b48d6cf9a6e28c474993398d420 on master.

Coverage remained the same at 77.114% when pulling 103146630b71b5ca6a9c373d23888eb980359225 on hotfix/logrus-logstash-hook into 65bfc842bdc30b48d6cf9a6e28c474993398d420 on master.

Coverage remained the same at 77.114% when pulling 831666b5717ecf35cd973ab9439bcad1286f932c on hotfix/logrus-logstash-hook into 65bfc842bdc30b48d6cf9a6e28c474993398d420 on master.

Coverage remained the same at 77.114% when pulling 831666b5717ecf35cd973ab9439bcad1286f932c on hotfix/logrus-logstash-hook into 65bfc842bdc30b48d6cf9a6e28c474993398d420 on master.

Coverage remained the same at 77.114% when pulling 831666b5717ecf35cd973ab9439bcad1286f932c on hotfix/logrus-logstash-hook into 65bfc842bdc30b48d6cf9a6e28c474993398d420 on master.

+1

+1


Latching not disappearing completely when using 320x240 display

everything else works perfectly with an ili9341 (#define ILI9341_DRIVER and #define SPI_FREQUENCY  40000000 changed in user_setup.h and resolution set to 320 x 240 in FreeTouchDeck.ino) same wiring and pinout as the ili9488 resistive photo attached in the project.

maybe something to do with the spacing and "rounding" of the buttons due to resize??

That is a good point. The latching dot is a fixed distance from the image on the button. What happens is, when the dot is drawn outside the button boundaries that part is not redrawn when "unlatching".
In drawhelper.h on line 16 the latching dot is drawn:
  tft.fillRoundRect((KEY_X - 37 + col * (KEY_W + KEY_SPACING_X)) - 12, (KEY_Y - 37 + row * (KEY_H + KEY_SPACING_Y)) - 12, 18, 18, 4, generalconfig.latchedColour); }
The number 12 is responsible for the offset. You could change it to a smaller number to bring in the dot closer. I do not have a 320*240 screen but when resize my screen and use 2 instead of 12, the latching dot falls completely within the button.
Maybe if you can let me know what position works for you. I can change the code to make it a ratio of the screen size. Or just put and if statement to check whether the screen is 480320 or 320240.

tft.fillRoundRect((KEY_X - 37 + col * (KEY_W + KEY_SPACING_X)) - 2, (KEY_Y - 37 + row * (KEY_H + KEY_SPACING_Y)) - 2, 18, 18, 4, generalconfig.latchedColour); worked great!!

also had to set text size to 1 (instead of 2 ) in line 1496 in Drawhelper.h for getting the system information to fit the screen..
everything else works ok with this ili9341 display, even the sleepwake function with the touch interrupt!
thank you and happy new year!!!

Thanks for that @charliejgallo. In the next update I will include a few lines that checks the size of the display and then decides where to put the latching dot. I will also do the same for the size of the any text that is displayed on the screen so that it fits!

Thanks for that @charliejgallo. In the next update I will include a few lines that checks the size of the display and then decides where to put the latching dot. I will also do the same for the size of the any text that is displayed on the screen so that it fits!

I resolved this in https://github.com/DustinWatts/FreeTouchDeck/commit/8b1e782ab99d6dabfde170a4ac81ebcca9947a5d If this works for you, you may close the issue ;)

I resolved this in https://github.com/DustinWatts/FreeTouchDeck/commit/8b1e782ab99d6dabfde170a4ac81ebcca9947a5d If this works for you, you may close the issue ;)

0.9.7 works great!!!! (just had to update the esp32-ble-keyboard for the version number update)

0.9.7 works great!!!! (just had to update the esp32-ble-keyboard for the version number update)


[ISSUE] Helm upgrade without secrets extraction steps does not trigger validation error between v9 and v10

Describe the issue:
https://camunda.slack.com/archives/C03UR0V2R2M/p1715673565744409
There are situations where a user may upgrade from 9.3.3 to 10.0.5 without specifying their existingSecrets, and for the error message must not be empty, please add '--set ... to not happen.

Actual behavior:
Helm upgrade will fail initially due to
Error: UPGRADE FAILED: cannot patch "cpt-identity" with kind Deployment: Deployment.apps "cpt-identity" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"camunda-platform", "app.kubernetes.io/component":"identity", "app.kubernetes.io/instance":"cpt", "app.kubernetes.io/managed-by":"Helm", "app.kubernetes.io/name":"camunda-platform", "app.kubernetes.io/part-of":"camunda-platform"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

And if you delete the identity deployment to bypass that, then the helm upgrade will succeed unexpectedly.

Expected behavior:
Error message is expected due to not supplying existingSecrets during the upgrade process:
Error: UPGRADE FAILED: execution error at (camunda-platform/charts/identity/templates/tasklist-secret.yaml:10:22):
PASSWORDS ERROR: You must provide your current passwords when upgrading the release.
                 Note that even after reinstallation, old credentials may be needed as they may be kept in persistent volume claims.
                 Further information can be obtained at https://docs.bitnami.com/general/how-to/troubleshoot-helm-chart-issues/#credential-errors-while-upgrading-chart-releases

    'global.identity.auth.tasklist.existingSecret' must not be empty, please add '--set global.identity.auth.tasklist.existingSecret=$TASKLIST_SECRET' to the command. To get the current value:

        export TASKLIST_SECRET=$(kubectl get secret --namespace "camunda" "camunda-platform-test-tasklist-identity-secret" -o jsonpath="{.data.tasklist-secret}" | base64 --decode)

How to reproduce:

Install helm install cpt camunda/camunda-platform --version 9.3.3
Upgrade helm upgrade cpt camunda/camunda-platform --version 10.0.5
If you didn't get any validation errors before it tries to apply a manifest, then you've reproduced it.

Logs:
No error message means no logs :cry: .

Environment:
Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

Platform: KIND
Helm CLI version: v3.15.0
Chart version: 9.3.3 -> 10.0.5
Values file: default values.yaml

If you run into
Error: UPGRADE FAILED: cannot patch "cpt-identity" with kind Deployment: Deployment.apps "cpt-identity" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"camunda-platform", "app.kubernetes.io/component":"identity", "app.kubernetes.io/instance":"cpt", "app.kubernetes.io/managed-by":"Helm", "app.kubernetes.io/name":"camunda-platform", "app.kubernetes.io/part-of":"camunda-platform"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

when testing, you can run
kubectl delete deployment cpt-identity

And then continue with the upgrade. I would still expect the secrets extraction validation error message to appear, but it does not

After doing a git bisect, I found that the following commit caused this behavior:
7fb7b0ae feat(pre-alpha): initial support multi-namespace deployment (#1084)
I used the following script to find it
#!/bin/bash
releaseName=cpt make -e helm.uninstall
helm install --set global.identity.keycloak.url.host=jesse.com --set global.identity.keycloak.url.port=80 --set global.identity.keycloak.url.protocol=http cpt charts/camunda-platform
export go_to="$(git log --oneline main | grep -B 1 $(git rev-parse --short HEAD) | tail -n 1 | awk '{print $1}')"
export return_to="$(git rev-parse --short HEAD)"
git checkout "$go_to"
helm upgrade --set global.identity.keycloak.url.host=jesse.com --set global.identity.keycloak.url.port=80 --set global.identity.keycloak.url.protocol=http cpt charts/camunda-platform
git checkout $return_to

lookup is used to look up resource in a running cluster. When used with the helm template command it always returns an empty response.

https://helm.sh/docs/chart_template_guide/function_list/#lookup
I think this might be relevant.


README lists ENABLE_RESOURCE_EMBED option, but CMakeLists lack it

Was it forgotten or removed? I would be nice to have it working.

I am trying to make lagrange work on old macOS, building it Unix way, but it fails to find resources on launch:
36-25% /opt/local/bin/lagrange
Xlib:  extension "RANDR" missing on display "/tmp/launch-hZ8URc/:0".
failed to load resources: No such file or directory

IIRC, embedding resources was removed when it become impractical due to several megabytes of fonts being distributed with the app. It became too unwieldy to both generate the source file with the embedded data and to compile it. There may exist methods to do the embedding more efficiently, however I also preferred to avoid adding further dependencies on external tools.

on old macOS, building it Unix way, but it fails to find resources on launch:

I believe the macOS build assumes an application bundle is always in use, so it does not check the standard Unix locations. The locations are specified in the beginning of src/app.c, and the actual checked paths can be found around line 1120 in app.c. A new build option would have to be added to disable the application bundling, also affecting the paths checked when loading resources.lgr.

I believe the macOS build assumes an application bundle is always in use, so it does not check the standard Unix locations.

I was able to get around enforced bundling, I believe, and get lagrange installed, but launching fails due to missing resources. I will check the specific location you refer to and update here.

I've now finally remembered to update the README, removing this obsolete option.

@skyjake Thank you. By the way, in principle would it work to make a local patch on our side to restore embedding into the current version? Or did something else change that would prevent this from working?

Yes, there were other changes. The resources are now expected to come in a ZIP archive when they are loaded by resources.c. So after creating the resources.lgr (=zip), it would then have to be converted into a C source file and embedded as is. In the old version, the individual resources were embedded separately. Finally, init_Resources() would have to read from the embedded byte array instead of trying to load the ZIP archive from a file.


how to attach/associate an existing thread pool to a set of HystrixCommands

I have observed that hystrix creates a threadpool according to the HystrixCommandGroupKey value.
i.e. all commands with the same HystrixCommandGroupKey will execute in the same threadpool.
and hystrix creates the thread pool using the value of HystrixCommandGroupKey
but in my application, i already have a thread pool.
is there a way to associate my existing threadpool to a HystrixCommandGroupKey ?
e.g. all commands with HystrixCommandGroupKey="SoapRequest" will run in an existing thread pool ? and  hsytrix will use the specified thread pool instead of creating one?
thanks!!

is there any example of using HystrixCommandExecutionHook ?

is there any example of user supplied HystrixThreadPool

closed by mistake.

hello, can someone please suggest a solution?

Use custom HystrixConcurrencyStrategy and override getThreadPool method and return your existing thread pool so that will be used by hystrix. I hope this helps.


Add a --threshold-scale parameter

In kofam_scan, the --threshold-scale can be used to control the stringency of annotation. It simply multiplies the bitscore cutoff by a constant.
This could be an useful feature to have in pykofamsearch.

Thanks for adding this scaling threshold.  Did you catch any other thresholding features in the kofamscan code that isn't implemented here?

Not on the top of my head. I can think of a few extra features that could be useful (e.g. a command to automatically download and build a database, include module and pathway information in the output), but nothing really crucial.


Proposal: A shared trait for tls acceptors that are implemented by both async-tls and async-native-tls

I have some code that implements this using wrapper types, but would really love for a trait like this to exist:
A proposed async-tls-acceptor crate that publishes this trait:
#[async_trait]
pub trait Acceptor<Input>: Clone + Send + Sync + 'static
where
    Input: AsyncRead + AsyncWrite + Send + Sync + Unpin + 'static,
{
    type Output: AsyncRead + AsyncWrite + Send + Sync + Unpin + 'static;
    type Error: std::fmt::Debug + Send + Sync;

    async fn accept(&self, input: Input) -> Result<Self::Output, Self::Error>;
}

The implementation for async-native-tls would be:
#[async_trait]
impl<Input> Acceptor<Input> for async_native_tls::TlsAcceptor
where
    Input: AsyncRead + AsyncWrite + Send + Sync + Unpin + 'static,
{
    type Output = async_native_tls::TlsStream<Input>;
    type Error = async_native_tls::Error;
    async fn accept(&self, input: Input) -> Result<Self::Output, Self::Error> {
        async_native_tls::TlsAcceptor::accept(&self, input).await
    }
}

Would this be welcomed?
refs: https://github.com/async-rs/async-tls/issues/43

at first sight this seems reasonable to me.  Let's see what async-tls thinks about this as well.


Update system_update_settings.php

Tidied the Dashboard update settings text

Thanks for the feedback, I went with D as I thought "Dashboard" was a
proper noun relating to that component. Happy to use whatever the
convention is, however.
On 16 August 2017 at 19:36, Renato Botelho<EMAIL_ADDRESS>wrote:

@rbgarga commented on this pull request.
In src/usr/local/www/system_update_settings.php
https://github.com/pfsense/pfsense/pull/3798#discussion_r133531623:

@@ -158,7 +158,7 @@ function get_repo_name($path) {
$section->addInput(new Form_Checkbox(
'disablecheck',
'Dashboard check',

'Disable the automatic dashboard auto-update check',

'Disable the Dashboard auto-update check',

Dashboard shouldn't be capitalized IMO
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pfsense/pfsense/pull/3798#pullrequestreview-56724303,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzxsi1Q2JZFgz0fDC3NI1OygYtB7uMcks5sYzafgaJpZM4OzeDT
.


FileNotFoundError: No such file or directory: pytorch_model.bin while loading a HF repository

I encountered an error
FileNotFoundError: [Errno 2] No such file or directory: '/home/cloud/.cache/huggingface/hub/models--yentinglin--Taiwan-LLM-13B-v2.0-chat/snapshots/419f643a34e4aa53ee5bc87bc1f52d956758f91a/pytorch_model.bin'
while executing the following line of code:
client = mii.serve("yentinglin/Taiwan-LLM-13B-v2.0-chat/")

The model functions correctly when utilizing Hugging Face's transformers library.

Thanks for trying out MII, i see this model https://huggingface.co/yentinglin/Taiwan-LLM-13B-v2.0-chat/tree/main only has checkpoints in safetensors. We currently don't support loading safetensors but plan to add this soon as it shouldn't be a lot of code change. We also welcome PRs :)
I believe the core changes to support safetensors will be here: https://github.com/microsoft/DeepSpeed/blob/136fe337fdd22defc29608f23c5b21a9c2b37297/deepspeed/inference/v2/checkpoint/huggingface_engine.py#L49-L56
and here to load via the safetensors library (https://huggingface.co/docs/safetensors/index#load-tensors) https://github.com/microsoft/DeepSpeed/blob/136fe337fdd22defc29608f23c5b21a9c2b37297/deepspeed/inference/v2/checkpoint/huggingface_engine.py#L87
This might be a good first issue for someone who has used some of the HF APIs


Add Vlc player to video players list to change scale factor in full screen and increase buffer cache network

Hello, thank you so much for this worderful awesome amazing exeptional IPTV Player!
Please I have some request and suggestion, I have an iptv which broadcasts an old cartoon anime and although I have changed the aspect ratio of the IPTVnator player, the video does not occupy the full screen because there are large black bands on the right and left, so I used vlc player and with the keyboard shortcuts, I was able to activate the "increase the scale factor" option and the video occupies the entire screen in full screen, but the problem is that vlc player does not have an interface as pretty as IPTVnator and I cannot save my favorite tv channels via vlc player, so it will be great to add in the settings of IPTVnator that I installed on windows an option to add a new video player like vlc player, mpc-hc, mpc-be, potplayer, smplayer.... so we will have the choice to be videojs player and html5 player and other media players like vlc because vlc player also allows me to increase the network cache buffer when my connection becomes weak and avoid jerky sreaming and vlc  allows me to pause the video streaming and disable deinterlacing or hardware acceleration....
so, when needed, we can use vlc player using the magnificent interface of IPTVnator!
Thanks very much !

Hello, I find another video player like vlc thant can play ip tv m3u and have many addon and scripts that we can add, so it will be awesome if our beloved IPTVnator include this player to the list of video players so, when some streams are may be difficult to play with videojs player and html5 player, we can use this video player (that has timeshift option) and IPTVnator in the same time, thank you very much !
http://plst.rf.gd/
http://iptv.gen12.net/dokuwiki/doku.php/start?id=mantis:simpletv:start
I request that beacause i find this website that has many various different free tv from all over the world
https: //www.apsattv.com/streams.html
that's why having multiple video players in IPTVnator could may be solve problems if there is problem playback with some streaming streams....


Remove package-lock.json from .gitignore

First of all, nice work addressing the event-stream issue (https://github.com/dominictarr/event-stream/issues/116) so quickly yesterday! In light of that (and other past & future issues) I'd like to suggest using a package-lock.json (or yarn.lock) file committed to source control.
package-lock.json is currently added to .gitignore with the following comment:
# package-lock file since it just causes merge conflicts
package-lock.json

It's true they can be a bit of a pain, but in my experience the benefits outweigh the risks here. For example, the VSCode repo itself would have been hit with the event-stream issue if not for using a lock file.

Here's a PR: https://github.com/Microsoft/vscode-azurefunctions/pull/820

@dpwatrous thanks for the suggestion. We've gone back and forth on package-lock.json and I'm definitely open to either option.
I understand that package-lock.json prevents getting the latest (malicious) packages like the recent event-stream, but doesn't it also slow us down in getting the latest helpful security updates?

Yeah, it's a tradeoff for sure - the downside is you have to be much more active in managing the project's dependencies or as you said you'll fall behind. IMO that's the cost of taking on dependencies, which is often under-appreciated in the Node/NPM ecosystem.
That said, the tooling around lock files definitely helps. Running an update command is a lot easier than bumping versions by hand. :)

Sounds fine to me. Although we have several repos and I'd like to keep the process consistent. @StephenWeatherford @nturinski @PrashanthCorp any objections to adding back the package-lock.json to our repos?

Discussed offline with team and they're okay with it. Thanks!

Awesome, thanks, Eric. I've been digging the extension by the way!


Buggy support for binary string data

I wanted to check whether I could use this library to store binary data w/o prior encoding to base64. Therefore I wrote the following simple function
static void TestBinDump()
{
    const char* data = "A\x13""B\x8B\0C";
    std::string s(data, data + 6);

    json js;
    js["key"] = s;

    auto dump = js.dump(4);
    std::cout << s.size() << " " << dump << std::endl;

    auto jd = json::parse(dump.begin(), dump.end());
    std::string v = jd.at("key");
    std::cout << v.size();
}

This correctly outputs 6 { "key": "A\u0013Bï\u0000C" }. The first surprise is that byte data has been encoded to 16-bit Unicode, so I wanted to see whether "8-bit" Unicode characters would get translated back to 8-bit values. I didn't get so far because parsing threw invalid_argument exception with message "parse error - unexpected '\"'".
I'm using version 2.1.1.

I realized that on my machine, the key is serialized to "A\u0013B\213\u0000C". That byte \213 made me think: \213 or \x8B is 10001011 as binary, which is invalid UTF-8: bytes starting with 10 must follow bytes starting 11which is not the case for the B which is 01000010. That said,  the given byte sequence in data is not valid UTF-8 and therefore its serialization cannot be expressed in this library (or maybe even JSON at all).
Your output shows ï which is Unicode U+00EF and would need to the string literal \u00ef rather than \213. That said, input A\x13""B\u00ef\0C yields serialization A\u0013Bï\u0000C which properly roundtrips (not the size of the input string is then 7 instead of 6 bytes).
I'm not entirely sure whether my take on this is right, so I would be happy for feedback on this.

FWIW, Python rejects serializing it (throws "UnicodeDecodeError: 'utf8' codec can't decode byte 0x8b in position 3: invalid start byte").

I don't understand why you have to assume that the input is encoded as UTF8. ECMA-404 has to say the following on strings:

A string is a sequence of Unicode code points wrapped with quotation marks (U+0022).  [...] Any code point may be represented as a hexadecimal number. The meaning of such a number is determined by ISO/IEC 10646. If the code point is in the Basic Multilingual Plane (U+0000 through U+FFFF), then it may be represented as a six-character sequence: a reverse solidus, followed by the lowercase letter u, followed by four hexadecimal digits that encode the code point. [...] To escape a code point that is not in the Basic Multilingual Plane, the character is represented as a twelve-character sequence, encoding the UTF-16 surrogate pair.

The first two sentences seem to imply that you can dump any binary data verbatim by treating pairs of bytes as Unicode characters, except if such pair of bytes would represent a character that MUST be quoted. If you end-up with a single-byte remainder of the string, represent it as \u00XX. Decoding would reverse the process.
If you put in meaningful Unicode, ASCII or UTF-8 data, the data is still meaningful (i.e., "readable text") after encoding. (Thus, you'd need to adopt "big-endian" convention for representing wide characters, but the spec doesn't say anything about this and there's even a special Unicode code point used for that purpose.) If you put in binary data, you get "garbage", but valid garbage after encoding. In both cases, decoding can reconstruct both length and data.

As you quote, a JSON string is a sequence of "Unicode code points" -- but the technical term "code point" has NOTHING to do with bits and bytes. Bits and bytes happen once you start talking about encodings, like UTF-8 or UTF-16.
For example, if you have the "Unicode code point U+0058" (the letter X), then we still have no idea what that looks like in memory. It depends on what encoding you attach to your in-memory string. It could look like "58" (UTF8) or "0058" or "5800" (UTF16-LE, -BE), etc.
JSON cannot encode arbitrary binary, just sequences of code points -- which, again, has nothing to do with binary representations :)
The nlohmann library has chosen that strings be encoded in UTF8 (see the README); he could have chosen any of the Unicode encoding format (or support them all!), but he had to pick one of them, and UTF8 is a great one (see http://utf8everywhere.org/ for a great read on Unicode and encodings; it's a fascinating topic).
Therefore, your input is not valid UTF8, and therefore should have been rejected by the encoder.
And, in case you still don't believe me, do a quick search for "JSON encoding binary" and you'll see lots of people trying to figure out good ways to do this -- which should be a hint that it's not natively supported by JSON. (For example, this popular StackOverflow question: http://stackoverflow.com/questions/1443158/binary-data-in-json-string-something-better-than-base64)

What I'm saying is that you can pretend that your input data is big-endian UTF16. With minimal munging of data (escaping what must be escaped), you can serialize binary data w/o loss of information. At least, the serializer/deserializer could have an option to switch from assuming UTF8 to munging of binary strings.

You're right that there are ways of encoding illegal bytes (for example, like Python does with surrogate escapes). Another great way to do it is to encode the binary in Base64 or Base96, or as a string of hex digits [A-F0-9]. There are infinite ways to put arbitrary binary into a string, but:

none of these bin->str protocols are specified by the JSON spec
they're not universal or portable (for example, if you put "A\x13B\x8B\0C" through the encoder you imagine, and then load that file.json through any other JSON parser, like Python or Ruby or whatever, then I guarantee that you will NOT get back the bytes "A\x13B\x8B\0C" from any of them)

Look, I know you're trying to solve a good problem, and what you're proposing is reasonable on its face. However, the decoding/encoding you're proposing has to take place on a layer higher than the JSON parser/encoder, and I don't think that layer belongs in this library -- but, in the end, that's not my call, so you dont have to convince me :)

JSON is encoded uniformly. If you want to encode binary, then you need to use CBOR, Message Pack, or BSON. This library includes 2 of those options. If you encode std::vector as JSON, you might want to use an array, not a string, then use CBOR or Message Pack on the wire. (I forget what the function names are, but they're in the README.md.

I think I need to better understand the expectation for this.
In C++, a string is just a sequence of bytes, and their meaning depends on the encoding. The example "A\x13B\x8B\0C" is a sequence of the bytes 0x41 (A), 0x13 (\x13), 0x42 (B), 0x8b (\213), 0x00 (\0), 0x43 (C).
When we want to create an nlohmann::json value from this byte sequence, we assume a UTF-8 encoding (see the notes). The simple assignment from std::string to nlohmann::json has no check implemented which throws an exception in case the string isn't properly encoded (as it is the case here). Whether such a check should be implemented should be discussed, but seems not to be the subject of this issue.
However, the byte sequence is not valid UTF-8, UTF-16, or UTF-32. Therefore, I fail to understand what we should do with the input in the first place.

I think I need to better understand the expectation for this. [...] However, the byte sequence is not valid UTF-8, UTF-16, or UTF-32. Therefore, I fail to understand what we should do with the input in the first place.

I can describe the expectation simply. Given a byte sequence (which may or may not be a valid UTF8 string), apply a minimally munging transformation which introduces UTF16 characters to encode groups of bytes with high bit set. The rest is passed through verbatim.
Concrete algorithm: when current are next character are both printable ASCII, pass both through unchanged. When any of them is a control character or has a high bit set, convert it to 16-bit Unicode value. The example would thus become `"\u4113\u428B\u0043". Given ordinary ASCII text like "ABCDE", the output would be "ABCDE". Mixture like "AB\xA9CEFGH" would become "AB\uA943EFGH".
Now any decoder which is told that the input encoding is big-endian UTF16 would reconstruct the same binary string.
Does this seem like a reasonable expectation?

Now I understand. Indeed, the required "algorithm" would be similar to the one required in #330. However, I am not yet convinced that this should be done in an assignment from std::string to json - maybe an additional function would be more suited here.

I have no preference for either way. Would maybe prefer to have an additional function instead of a flag to make it obvious what's going on. But what about decoding/extraction? The decoder has to be told in some way to not convert Unicode escapes to UTF8.

I don't understand. I only support UTF-8.

I assume that when your parser encounters an escape like \uA933 it will convert it to UTF-8 representation, right? For the above transformation to work, the parser has to output the two bytes verbatim.

When this json parser sees the JSON string "\uA933", the parser will be return the UTF8 string with 3 bytes: 0xEA, 0xA4, 0xB3.  (See: http://www.utf8-chartable.de/unicode-utf8-table.pl?start=43312&view=3).

The parser has to be told in some way to not convert Unicode escapes to UTF8.

No, this does not make sense. It is the duty of the parser to convert JSON strings into the target encoding, which is UTF-8 in this library. If you want the strings to remain the same, why use a JSON parser in the first place?

Yes, I'm well aware of that, hence my comment. Regardless of whether this transformation is implemented automatically in assignment from string to json, or as a separate function, the parser has to be told to not convert Unicode escapes to UTF8.

To make clear: the assignment from string to json has nothing to do with the parser, and I shall not change the parser in this regard. Parsing escaped Unicode shall always return an UTF-8 encoded string.

Implementing this as a parser mode flag costs little, but greatly increases the utility of the library because it spares all users of implementing their own binary->string encodings, yet you dogmatically reject this. I guess it's fork time.

I won't touch the parser to not cope with UTF-8. This would be out of scope of this library.
Good look forking!


Rolling background image like Windows Themes

Description of the new feature/enhancement
What about a set of rolling background images instead of a single one that Windows Terminal currently supports?  Looking at the same background all the time gets boring.
I like Windows Themes w/ the desktop backgrounds slideshow feature.    What about that same concept w/ Windows Terminal? Thoughts? 💭
Screenshot reference of Windows 10:

Proposed technical implementation details (optional)
add a "backgroundImages" : [ "file1.jpg", "file2.jpg" ] property to profiles.

This isn't something we're likely to implement in version 1.0, but we would be willing to accept community contributions here. When we eventually have an extension model, this might make a good extension. Thanks!

Adding request for slowly panning big images; and option to configure a folder of images.

Lumping these feature requests into this issue too, since we need a consolidated story for how to handle multiple background images.
From https://github.com/microsoft/terminal/issues/14111#issue-1393159162:

Introduce a keyword like random or a setting for your settings.json
or a "pickBackgroundImage": [ "foo", "bar", "baz"]

From https://github.com/microsoft/terminal/issues/7279#issue-678688656:

I would like the ability to specify an array of filesystem paths in the backgroundImage property, in my profile(s), and have Windows Terminal randomly select one from the array upon initialization.

I'm also upgrading this issue to be the main issue for handling multiple background images. Seems like the desired scenarios so far are...

[ ] use a new background image each time this profile is instantiated
[ ] switch to a new background image every few minutes

Any update on this?

Nope. We need to come up with a reasonable spec for settings to cover the scenarios outlines above, and then someone needs to actually write the code. If someone wants to help contribute a plan here, we'd be more than willing to help review 😄


Support images of different shapes

Issue description
For now we ask the dataset to have images of the same size, we should support resizing images of different shapes into the same shape.
There are two methods

resize the 3D numpy array inside generator
resize the image once it's parsed into tensor in the tf.dataset

Type of Issue

[ ] New feature request
[ ] Test request

this one relates to a bigger change to account for different resolutions - see a discussion with adria here: #24

@mathpluscode are we still planning this before r1? if not please add post-r1 label

@mathpluscode  actually i'm closing this as it is duplicate #114


Following Unicode 10.0 by default

On June 20th, Unicode 10.0 released! We can use many newly emoji! Yappie! :tada:
Now, I think cl-emoji's default emoji version should follow Unicode 10.0. Supported Emoji version in Unicode 10.0 is Emoji 5.0 and CLDR 31 (CLDR defines annotations). For details, see the URL http://www.unicode.org/reports/tr51/tr51-12.html.
In this PR I updated default emoji version in src/cl-emoji.lisp and README to notice that cl-emoji supports Unicode 10.0.

It's happy day! I'm glad to be able use this. :congratulations: