Adds workflow for snapshot releases

Please squash and merge

Hi @FrankSchnicke,
looks good to me! Two questions:
The workflow will require a GITHUB_ACTOR as another secret, right?
Second, you import gradle via a step (line 24 of gradle-publish-package.yml). Couldn't we use the gradlew executable directly?
Nothing critical though. Critcal is however that I don't have permissions to merge anything in this repo :-)

Maybe @alw-iwu ?

Thanks for your feedback.
GITHUB_ACTOR is a preconfigured environment variable (see https://docs.github.com/en/actions/learn-github-actions/environment-variables). Thus, there's no additional configuration necessary.
You're right, we could use gradlew directly. However, I'm not 100% sure why gradlew is used in this project. I can gladly change this if required.
I requested @alw-iwu as Reviewer :-)

Yea, actually it'd be great if we could use gradlew directly. Documentation says it's common practice.


Can't set default array value on extends

Zephir
namespace Ice;

class Test
{
    protected rules = [] { set, get };
}

PHP
<?php
use Ice\Test;

class Users extends Test
{
    protected $rules = [
        'username' => 'required',
    ];
}

$user = new Users();
var_dump($user->getRules());

$user->setRules([
        'username' => 'required'
]);

var_dump($user->getRules());

Output:
array(0) {
}
array(1) {
  ["username"]=>
  string(8) "required"
}

Expected to get it after an object is initialized. Looks like https://github.com/phalcon/zephir/issues/537 returned.

PHP 7.4.5 (cli) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies

@mruz Could you please check previous Zephir version just to clarify we don't break anything in https://github.com/phalcon/zephir/pull/2078

@sergeyklay seems fine on zephir 0.12.17, I also added a test for if.

@dreamsxin I need your help here. Could you please take a look. Also see https://github.com/phalcon/zephir/pull/2090

@sergeyklay create_object  is later than declare property.
test_properties_protectedproperties_ce->create_object = zephir_init_properties_Test_Properties_ProtectedProperties;

Fixed in the development branch. Thank you for the bug report!

@sergeyklay thank you!

You're welcome


Remove breaking spaces

Hello, this is a possible solution to issue #536 :)
It looks like this may be a more general problem than just one folder name, and it requires a separate folder identifier and a user-friendly folder name. Please let me know if you would like me to prepare such changes.
But at the same time, Run After Create Database is a specific folder, and perhaps it can be fixed without major changes to the project. At least for now.

Thanks a lot for your contribution, @XelgoSett . I see that I'm comparing apples and oranges here. As I mention in the linked issues, the folder confiuguration has become a bit messy, unfortunately. The whole configuration, and mess with knows folders, known folder names, and known folder keys should be re-written. They are. the result of the folder structure being fixed with RoundhousE, which I have inherited the start of grate from, and the folder configuration being fully dynamic in grate. I think I'd like to rewrite it a bit differently, and include a unit test to ensure that we know that the change works.
When fixing bugs, I usually start with writing a test that fails, to demonstrate the issue in a simple and easily reproducible way, and then implement the change, and see the test turning green. Then,  I'm fairly sure that I have fixed the issue. And, all the other tests ensure (hopefully) that we haven't broken anything else

Superceded by #565


Nested promises are not properly unwrapped in Promise.then

lib Update Request
Configuration Check
My compilation target is ES2017 and my lib is the default.
Missing / Incorrect Definition
I think the definition of Promise.then is incorrect
https://github.com/microsoft/TypeScript/blob/a9efe2be6040e581100231891dea78a7fbc4f46c/src/lib/es5.d.ts#L1476-L1482
Sample Code
const z = new Promise<Promise<string>>(
	resolve => resolve(new Promise<string>(
		resolve => resolve('z'))
	)
)
// Correctly typed as Promise<Promise<string>>

z.then(str => console.log(str))
//     ^ Incorrectly typed as Promise<string>

Playground Link
Fix
The correct function definition could be (replace T with Awaited<T>):
then<TResult1 = T, TResult2 = never>(onfulfilled?: ((value: Awaited<T>) => TResult1 | PromiseLike<TResult1>) | undefined | null, onrejected?: ((reason: any) => TResult2 | PromiseLike<TResult2>) | undefined | null): Promise<TResult1 | TResult2>;

then<...>(...): PromiseLike<Awaited<TResult1 | TResult2>>;

If you amend your example to the following, it should type check correctly:
const z = new Promise<string>(
    resolve => resolve(new Promise<string>(
        resolve => resolve('z'))
    )
)
// Correctly typed as Promise<string>

z.then(str => console.log(str))
//     ^ Correctly typed as string

It is a known caveat that we cannot currently restrict the type of T in Promise<T> to only be a non-promise type, as that would require negated types (i.e., interface Promise<T extends not PromiseLike> { ... }). We also cannot change the type for value to Awaited<T> without breaking assignability with existing third-party promise libraries such as Q, rsvp, etc. We ran into issues with this with the old awaited T PR, so I'm not sure this is something we can change at this point.

Thanks for the heads up @rbuckton! Unfortunately, the Promise<Promise<Something>> is created by a library. I'll use as Promise<Something> to work around this issue.


Allow filtering and sorting of plugins

Liking the site.
I think for people like me who are already pretty tuned-in to plugins organizing by star doesn't help much because you kinda know if you will be using coc.nvim pretty early on.
Would love if we could sort and filter this list by things like update date so we can see the new stuff coming out.

Additionally, the default sorting should be newest added plugins first.

Thanks for the feedback!
I added sorting by stars, created at, and updated at -- data grabbed from github.
We currently do not store when a resource was added to our system so sorting by that would require recording that data.
I'll think about adding that metadata soon.

Marking as completed!  Thanks again!


Suddenly - ""error":"Unable to load cars.""

Hi there!
As of 1 day ago I'm suddenly seeing the error ""error":"Unable to load cars."" as a result in the api call.
Log shows
[GIN] 2023/06/10 - 12:28:01 | 200 |       29.59µs |   <IP_ADDRESS> | GET      "/api/v1/cars/1/status"
2023/06/10 12:28:36.963039 [error] TeslaMateAPICarsStatusV1 - (/api/v1/cars/2/status). Unable to load cars.; sql: Scan error on column index 1, name "name": converting NULL to string is unsupported
[GIN] 2023/06/10 - 12:28:36 | 200 |     715.882µs |   <IP_ADDRESS> | GET      "/api/v1/cars/2/status"
2023/06/10 12:28:01.867631 [error] TeslaMateAPICarsStatusV1 - (/api/v1/cars/1/status). no info on this car ID; -
[GIN] 2023/06/10 - 12:27:01 | 200 |      30.612µs |   <IP_ADDRESS> | GET      "/api/v1/cars/1/status"
2023/06/10 12:29:01.903511 [error] TeslaMateAPICarsStatusV1 - (/api/v1/cars/1/status). no info on this car ID; -
[GIN] 2023/06/10 - 12:29:01 | 200 |      30.542µs |   <IP_ADDRESS> | GET      "/api/v1/cars/1/status"
I've tried a full reboot of the node and teslamate. Teslamate data showing just fine.
On v 1.16.1
Any suggestions? Thanks!

Same problem here.
Log shows:
teslamate_1     | 2023-06-11 11:45:27.618 [info] GET https://owner-api.teslamotors.com/api/1/vehicles/removed/vehicle_data -> 408 (9104.728 ms)
teslamate_1     | 2023-06-11 11:45:27.619 [warning] TeslaApi.Error / %{"error" => "{"error": "timeout"}", "error_description" => "", "response" => nil}
teslamate_1     | 2023-06-11 11:45:27.619 car_id=2 [error] Error / :unknown
teslamate_1     | 2023-06-11 11:45:55.218 car_id=2 [info] Suspending logging
teslamateapi_1  | [GIN] 2023/06/10 - 19:01:21 | 200 |     1.97747ms | 192.168.XXX.XXX | GET      "/api/v1/cars/2/status"
teslamateapi_1  | 2023/06/10 19:01:25.294859 [error] TeslaMateAPICarsStatusV1 - (/api/v1/cars/2/status). Unable to load cars.; sql: Scan error on column index 1, name "name": converting NULL to string is unsupported

Hi @chamsters and @haexpo,
From the output of @haexpo to tell it seems to be TeslaMate that has issues itself since it gets a 408 response from the owner-api. TeslaMateApi uses the PostgreSQL database in which TeslaMate feed information like vehicle information and it would be there where the issue would be.
I've noticed the same thing on my setup and I encountered the same issue. After upgrading to the latest TeslaMate version (I use edge) it works fine. It's the commit https://github.com/adriankumpf/teslamate/commit/6af97bafc8cfee6bd22911a1014dae8dcbe1f419 that is required for TeslaMate to behave correct again, so we'll have to wait for a new release of TeslaMate to be published or you can temporarily switch to using edge.
Some issues/discussions on TeslaMate repo:
https://github.com/adriankumpf/teslamate/issues/3183
https://github.com/adriankumpf/teslamate/discussions/3234
https://github.com/adriankumpf/teslamate/discussions/3238
Same issue has also been reported in the tesla-api repo from timdoor:
https://github.com/timdorr/tesla-api/issues/728
I'll set the issue to close, but get back to me if you have any further questions.
Regards,
Tobias


Compilation fixes for acmev2 branch

I was able to use lego to fetch a multi-domain wildcard cert using the acmev2 branch. While it mostly worked, there were a few compilation fixes needed. Perhaps needed from changes to upstream deps?

merging in master does make the full diff a little tougher to review... but i think i've addressed your feedback.

Hmm, I'd rather we just merge acmev2 into master. Will wait for @xenolf to decide on that though, since I wasn't sure if he's quite done with acmev2 yet.


OrientDB failing to start on Ubuntu 16.04 with systemd

OrientDB Version, operating system, or hardware.

I last tried this with 2.2.5 on Ubuntu 16.04 on an AWS EC2 t2.medium instance.

Operating System

[x] Linux
[ ] MacOSX
[ ] Windows
[ ] Other Unix
[ ] Other, name?

Expected behavior and actual behavior
When starting orientdb, it should keep running.
Ubuntu 16.04 is the first LTS since Ubuntu switched from upstart to systemd.  I followed the documentation to setup systemd, but it doesn't work well.  When I start, orientdb startup up, but according to the logs, systemd or something immediately issues the stop command, so the service stops.
Steps to reproduce the problem
Follow the current orientdb documentation for running on ubuntu with systemd.
Additional details are available on my stack overflow question:
http://stackoverflow.com/questions/38644653/systemd-stops-orientdb-immediately-after-it-starts-on-ubuntu-16-04
I also asked on the mailing list:
https://groups.google.com/forum/#!topic/orient-database/OF1brvaY3uc
Let me know if you need any more information.  I'm happy to help!
Thanks!

hi @austinsmorris,
I think that the orientdb.sh script was thought for SystemV use and SystemD behave in a different way, i'll check what's going on and i'll try to understand why it block

Hi,
I got the same issue with OpenSUSE Leap 42.1 and OrientDB 2.2.7.

I'm investigating the problem.

Hi, I just pushed on develop branch an orientdb.service file and a new orientdb-sysd.sh script to be used by the service definition. I will update the doc. In the meanwhile you can take this files

Thanks Roberto, these new files work for me (OpenSuse Leap 42.1 + OrientDB 2.2.7).

cool, we are still experimenting, maybe we will change something. It is my first time with systemd.

I have installed the latest version of orientdb 3.06 on Centos 7 and facing the same issue with service.
Could you please help me out.


api documentation with Postman

We need to create the use-case for our command and query api endpoints ; using Postman
We need to cover all of the endpoints with postman requests , covering success of failure scenarios

successful/main scenarios postman is ready
failing scenarios are not ready yet


Add cancel account button to Admin user edit view

Allow admins to delete old accounts.
https://github.com/QutBioacoustics/baw-server/blob/develop/app/views/devise/registrations/edit.html.haml#L19
https://github.com/QutBioacoustics/baw-server/blob/develop/app/views/user_accounts/edit.html.haml

Okay, as #321 progresses, I realise I have stated the requirements ambiguously.
Currently, there is a "cancel my account" button on a user's profile page. However, we've realised how dangerous this is with our current database structure.
We have two deletion scenarios:

A long-historied user, that has many associated records, wishes to end their association with us
An account was accidently created and has no associated records

In case 1. it is dangerous to cascade delete the user - we could potentially loose thousands of records. We'll only archive that record (soft delete) via the acts_as_paranoid gem.
For an archived/soft deleted User:

can they reactivate their account? yes - but through a contact us form (admin intervention only)
we'll keep identifiable information for now, and only anonymize (delete email/username) on request (TODO: add a note to terms and conditions)
we'll show user ids (e.g. in data exports and API responses) where relevant and in other places (e.g. the modified/created tags) we'll add some generic fallback text (maybe: "Anonymous user")

In case 2. it will be useful to actually hard delete the user and all associated records. A hard deletion should be a very rare event and should be preceded by a manual database backup.
UI requirements:

A user's profile should have a deactivate my account" to imply we will keep the data. Add explaining terminology:

When your account is deactivated, you can no longer log in, or make any changes. No other user will be able to see your identifiable information.

An admin should be able to also deactivate another user's account
Last modified/created tiles that reference an archived user should say "Anonymous user"
Annotation exports should export user ids (as normally set by FK fields), but leave username fields blank
Note: no UI presence for hard deleting users

Serverside requirements

The User model should include acts_as_parnoid behaviour
The User model should have {delete: :cascade} set for all foreign relations

[Optional]: other behaviours like set all FK references to null, or replace all FK references with another user's id are acceptable (but I suspect more difficult?) - choose the easiest option

Only a user with the Admin role should be able to hard delete a user

Wiki
Additionally, I'll add a help guide to the wiki for deleting users.


Support Prometheus metrics when using loadbalancer/multiple instances bound to the same IP.

Which version are you using?
v0.15.4
Which operating system are you using?
OS

[X ] Linux
[ ] Windows
[ X] macOS

Architecture

[ X] amd64
[ ] arm64
[ ] arm7
[ ] arm6

Hi,
I have a unique issue where by I have RTSS running on multiple VM instances in proxy mode. All of these instances are assigned to a cloud load balancer which distributes traffic based on health/status of the respective VM's.
In order to make the rtsp streaming work I have needed to edit the config.yml file to assign the listenIP of each instance to be that of public facing load balancer address. (Each VM in my pool of proxy vm's are bound to the same external IP).
This works as expected for the actual RTSP streaming but doesn't allow me access to the respective prometheus metrics from each instance as they are being bound to the loadbalancer address by virtue of the ListenIP being set in the rtss.yml
Is there an obvious solution which would still allow me to access the :9998/metrics from each instance on their own external IP's while still continuing to bind the rtps streaming to the load balancer IP?
Maybe you could implement a seperate bind IP for the prometheus metrics in the config file, or point me in the right direction for modifying the source to solve this problem.
Thanks
I can provide access (privately) to VM's to replicate issue if this will help

Maybe you could implement a seperate bind IP for the prometheus metrics in the config file

Yes, probably is better to allow the user to set the bind IP for each listener, unfortunately we have to wait for a major release, since it's a breaking change.

now it's possible to set a different IP for each listener. The feature will be available in the next release.

added in v0.16.0


[Event Request] table 36 "Sales Header" - OnInitRecordOnBeforeUpdateLocationCode

Can we please get the following event?
procedure InitRecord()
var
    ArchiveManagement: Codeunit ArchiveManagement;
    IsHandled: Boolean;
begin

    ...

    if "Document Type" = "Document Type"::Quote then
        CalcQuoteValidUntilDate;

    IF "Sell-to Customer No." <> '' THEN
        GetCust("Sell-to Customer No.");

    //+EVENT
    IsHandled := false;
    OnInitRecordOnBeforeUpdateLocationCode(Rec, IsHandled);
    if not IsHandled then
    //-EVENT
        UpdateLocationCode(Cust."Location Code");

    ....

end;

[IntegrationEvent(false, false)]
local procedure OnInitRecordOnBeforeUpdateLocationCode(var SalesHeader: Record "Sales Header"; var IsHandled: Boolean)
begin
end;

Hi,
There are few requests to avoid/replace validate location code. Is it ok for you to use existing event OnBeforeUpdateLocationCode?

Hi,
right now we only want to handle the update of the Location Code in some special situation an processes.
Since the procedure UpdateLocationCode isn't local this procedure might being called from external and in many different scenarios.
I thought about if it helps to add add a parameter CalledByFieldNo to the event OnBeforeUpdateLocationCode, but we still wouldn't know that the current process is coming from the InitRecord procedure.
Therefore simple switching to the event OnBeforeUpdateLocationCode is not really an option for us right now.
Maybe you have some other ideas, about adding a parameter to the already existing event to deal with the situation, that his procedure is called from many different processes...

There is a workaround here - to analyze the callstack. It is a bit tricky but could help you to understand where this function is called from. Here is an example:

table 50000 MyTable
{
    DataClassification = ToBeClassified;

    fields
    {
        field(1; MyField; Integer)
        {
            DataClassification = ToBeClassified;

        }
        field(5700; "Responsibility Center"; Code[10])
        {

            trigger OnValidate()
            begin
                UpdateLocationCode();
            end;
        }
    }

    keys
    {
        key(Key1; MyField)
        {
            Clustered = true;
        }
    }

    procedure InitRecord()
    begin
        UpdateLocationCode();
    end;

    procedure CopySellToCustomerAddressFieldsFromCustomer()
    begin
        UpdateLocationCode();
    end;

    procedure UpdateLocationCode()
    var
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeUpdateLocationCode(Rec, IsHandled);
        if IsHandled then
            exit;

        Error('UpdateLocationCode');
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeUpdateLocationCode(var MyTable: Record MyTable; var IsHandled: Boolean)
    begin
    end;
}

page 50000 MyPage
{
    PageType = Card;
    SourceTable = MyTable;

    layout
    {
        area(Content)
        {
            group(GroupName)
            {
                field("Responsibility Center"; "Responsibility Center")
                {
                    ApplicationArea = All;

                }
            }
        }
    }

    actions
    {
        area(Processing)
        {
            action(InitRecord)
            {
                ApplicationArea = All;

                trigger OnAction()
                begin
                    InitRecord();
                end;
            }
            action(CopySellToCustomerAddressFieldsFromCustomer)
            {
                ApplicationArea = All;

                trigger OnAction()
                begin
                    CopySellToCustomerAddressFieldsFromCustomer();
                end;
            }
        }
    }
}
codeunit 50000 MyCodeunit
{
    trigger OnRun()
    begin

    end;

    [EventSubscriber(ObjectType::Table, 50000, 'OnBeforeUpdateLocationCode', '', false, false)]
    local procedure OnBeforeUpdateLocationCode(var MyTable: Record MyTable; var IsHandled: Boolean)
    var
        CallStack: Text;
    begin
        if ThrowError() then;
        CallStack := GetLastErrorCallStack();

        if StrPos(CallStack, 'InitRecord') <> 0 then
            Message('InitRecord');

        if StrPos(CallStack, 'CopySellToCustomerAddressFieldsFromCustomer') <> 0 then
            Message('CopySellToCustomerAddressFieldsFromCustomer');

        if StrPos(CallStack, 'Responsibility Center') <> 0 then
            Message('Responsibility Center');

        IsHandled := true;
    end;

    [TryFunction]
    local procedure ThrowError()
    begin
        // Throw an error to get the call stack by GetLastErrorCallstack
        Error('');
    end;
}

Is it ok for you to use that kind of approach?

Only to ensure that I understand the code correctly, the TryFunction ThrowError does not lead to a rollback of the complete processing, but only for the code inside the TryFunction?
I haven't thought about such an approach, but I think this should work for our integrations.

This approach does not rollback transaction.
Here is updated sample, where I create a new record instead of showing message:

table 50000 MyTable
{
    DataClassification = ToBeClassified;

    fields
    {
        field(1; ID; Integer)
        {
            DataClassification = ToBeClassified;
            AutoIncrement = true;
        }
        field(2; Description; Text[250])
        {

        }
        field(3; "Created DateTime"; DateTime)
        {

        }
        field(5700; "Responsibility Center"; Code[10])
        {

            trigger OnValidate()
            begin
                UpdateLocationCode();
            end;
        }
    }

    keys
    {
        key(Key1; ID)
        {
            Clustered = true;
        }
    }

    procedure InitRecord()
    begin
        UpdateLocationCode();
    end;

    procedure CopySellToCustomerAddressFieldsFromCustomer()
    begin
        UpdateLocationCode();
    end;

    procedure UpdateLocationCode()
    var
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeUpdateLocationCode(Rec, IsHandled);
        if IsHandled then
            exit;

        Error('UpdateLocationCode');
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeUpdateLocationCode(var MyTable: Record MyTable; var IsHandled: Boolean)
    begin
    end;
}

page 50000 MyPage
{
    PageType = List;
    SourceTable = MyTable;

    layout
    {
        area(Content)
        {
            repeater(GroupName)
            {
                field(Description; Description)
                {
                    ApplicationArea = All;
                }
                field("Created DateTime"; "Created DateTime")
                {
                    ApplicationArea = All;
                }
                field("Responsibility Center"; "Responsibility Center")
                {
                    ApplicationArea = All;
                }
            }
        }
    }

    actions
    {
        area(Processing)
        {
            action(InitRecord)
            {
                ApplicationArea = All;

                trigger OnAction()
                begin
                    InitRecord();
                end;
            }
            action(CopySellToCustomerAddressFieldsFromCustomer)
            {
                ApplicationArea = All;

                trigger OnAction()
                begin
                    CopySellToCustomerAddressFieldsFromCustomer();
                end;
            }
        }
    }

}

codeunit 50000 MyCodeunit
{
    trigger OnRun()
    begin

    end;

    [EventSubscriber(ObjectType::Table, 50000, 'OnBeforeUpdateLocationCode', '', false, false)]
    local procedure OnBeforeUpdateLocationCode(var MyTable: Record MyTable; var IsHandled: Boolean)
    var
        CallStack: Text;
    begin
        if ThrowError() then;
        CallStack := GetLastErrorCallStack();

        if StrPos(CallStack, 'InitRecord') <> 0 then
            AddRecord('InitRecord');

        if StrPos(CallStack, 'CopySellToCustomerAddressFieldsFromCustomer') <> 0 then
            AddRecord('CopySellToCustomerAddressFieldsFromCustomer');

        if StrPos(CallStack, 'Responsibility Center') <> 0 then
            AddRecord('Responsibility Center');

        IsHandled := true;
    end;

    local procedure AddRecord(NewDescription: Text[250])
    var
        MyTable: Record MyTable;
    begin
        MyTable.Init();
        MyTable.Description := NewDescription;
        MyTable."Created DateTime" := CurrentDateTime();
        MyTable.Insert();
    end;

    [TryFunction]
    local procedure ThrowError()
    begin
        // Throw an error to get the call stack by GetLastErrorCallstack
        Error('');
    end;
}

Thanks for your feedback and help to find a solution without requiring new events.
I close this issue and the others, since your suggestion (https://github.com/microsoft/ALAppExtensions/issues/15497#issuecomment-1016349222) looks promising for our integration.


onCompletion not called

Hello. After call forceStopTask() onCompletion not called. I think it's bug.
P.S.
This for
startDownloadRepeat or startUploadRepeat

This is not a bug for the speed test listener ISpeedTestListener, the right behavior is that onCompletion is called when the download/upload is complete. If forceStopTask() is called unexpectedly it triggers onInterruption callback. onInterruption exactly means that the task was interrupted because of forceStopTask() .
@Override
public void onInterruption() {
    //triggered when forceStopTask is called
}

This helps to distinguish the onError which occurs when something unexpected happened from the onInterruption when you expect the speed test to stop.

Okay. Can you add in ISpeedTestListener finish callback? Thanks.

onCompletion indicates that download/upload is complete
onInterruption indicates that the download/upload has been stopped

onInterruption will be removed in next release. onCompletion will be called instead


tools/mkdeps: Always look in the current directory

Signed-off-by: Xiang Xiao<EMAIL_ADDRESS>Summary
Impact
Testing

what's the motivation of this?

what's the motivation of this?

make and cc search the current path always, this patch align the makdeps behavior like make/cc. So we don't need always add these two line now:
VPATH =
DEPPATH = --dep-path .


Add threads count to class mtmp::Tread (cpp)

Duplicate issue - won't fix.
Just tried the Android App interface to create this issue. This was not a good idea.


Add DataFrame.drop_duplicates

This PR adds DataFrame.drop_duplicates.

Codecov Report

Merging #458 into master will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff            @@
##           master    #458      +/-   ##
=========================================
- Coverage   93.31%   93.3%   -0.02%
=========================================
  Files          29      29
  Lines        3711    3719       +8
=========================================
+ Hits         3463    3470       +7
- Misses        248     249       +1

Impacted Files
Coverage Δ

databricks/koalas/missing/frame.py
100% <ø> (ø)
:arrow_up:

databricks/koalas/frame.py
94.81% <88.88%> (-0.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcb209...7f3d602. Read the comment docs.

Tests passed. I double checked it works as Pandas'

Let me get this in. the doc is matched and input/output is matched with Pandas' too.


to forward guest port 80 to host port 80 conflicts with other tools (e. g. skype)

suggested change:
config.vm.network "forwarded_port", guest: 80, host: 8080

thx, done.

an addition: it's not necessary and works even when it's completely removed


chore(ts_indexer): Use more standard syntax for lambda

@evmar can you verify this change?

LGTM

I'm confused as to why we need to eta-expand this, but OK

In general,
f(g.p) is not equivalent to f(x => g.p(x))
because

if g.p depends on the value of this, those two provide different values for it (depends on what f does in the former, is bound to g in the latter)
if f passes multiple arguments to the given function, the latter swallows all but the first

I'm not sure why it was necessary here though.


Add testp-tests, testp-examples, and testp-benchmarks targets

Both files have this target:
test syncfttest mpisyncfttest: LIBS
	$(MAKE) -C ../tests $@
	$(MAKE) -C ../examples $@
	$(MAKE) -C ../benchmarks $@

We should add testp here, right?

Both files have this target:
test syncfttest mpisyncfttest: LIBS
	$(MAKE) -C ../tests $@
	$(MAKE) -C ../examples $@
	$(MAKE) -C ../benchmarks $@

We should add testp here, right?
test syncfttest mpisyncfttest testp: LIBS

Yes, I missed that. Thanks for catching it @evan-charmworks. Fixed in the latest commit.

Should it go in src/scripts/Makefile too?

Should it go in src/scripts/Makefile too?

I think so, yes. Another option would be to ìnclude Makefile.testsinsrc/scripts/Makefile`.

Should it go in src/scripts/Makefile too?

I think so, yes. Another option would be to include Makefile.tests in src/scripts/Makefile.

This is good idea. I created cmake/Makefile.tests.common that contains the common test targets of both the build systems. It is included by both cmake/Makefile.tests and src/scripts/Makefile. This will avoid the copying of targets to maintain consistency.


modules: mcux: introduce CONFIG_MCUX_CORE_SUFFIX

MCUX SDK depends on "core suffixes" in order to identify which core a build is targeting on a multicore part. Previously, this information was parsed from the CONFIG_SOC string, but with hardware model v2 this is no longer possible. Introduce the Kconfig MCUX_CORE_SUFFIX, which multicore SOCs can set to inform MCUX which core the build is targeting.

so the idea is that MCUX_CORE_SUFFIX is a string representation of cpuclusters, like PART_NUMBER or SOC for PART_NUMBER_XX and SOC_XX respectively? shouldn't be this generic and not specific to MCUX

Yes, that's the idea- I made this specific to MCUX because I felt that the strings our SDK chose to describe cpuclusters were sometimes a bit arbitrary- IE the LPC parts use _cm33_core0 and _cm33_core1 for each core, or the LPC54114 uses _cm4 and _cm0plus. If you'd like it to be generic, I have no problem adding a generic Kconfig instead.

If you'd like it to be generic, I have no problem adding a generic Kconfig instead.

Generic solutions are always welcome 🙂
So a solution where we make the CPU cluster name available in Kconfig, similar to what we do with SoC name sounds reasonable,
Just remember that in such case we should also ensure CPU cluster name in Kconfig is aligned with its soc.yml counterpart, just like we try to do with SoC names.

@danieldegrasse, the patch in this PR has been merged by through https://github.com/zephyrproject-rtos/zephyr/pull/69400/commits


Disabling ghosts for t intersections dev

Description
Resolves #5074
This reverts the -disable-ghost-zones-for-t-intersections flag back to -enable-ghost-zones-for-t-intersections and disables the creation of ghost zones for t-intersections by default. The purpose is to avoid a bottleneck performance issue that occurs with datasets that contain few AMR levels.
Type of change
Enhancement.
How Has This Been Tested?
I've visualized an AMR dataset with and without the -enable-ghost-zones-for-t-intersections flag and confirmed the appropriate behavior was occurring with the help of a print statement. Just to be safe, I also ran the Chombo and mfem tests (all pass).
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
:x: I have commented my code, particularly in hard-to-understand areas
[x] I have updated the release notes
:x:  I have made corresponding changes to the documentation
:x:  I have added debugging support to my changes
:x:  I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
:x: I have added any new baselines to the repo
[x] I have assigned reviewers (see VisIt's PR procedures for more information).

Looks good so far. DId you look into adding a GUI option?

It looks like this process occurs in "PopulateDatabaseMetaData", so it would require the user to re-open the file. @brugger1 @rusu24edward do you guys think I should go ahead and add a GUI option, or is the flag sufficient?

Looks good so far. DId you look into adding a GUI option?

It looks like this process occurs in "PopulateDatabaseMetaData", so it would require the user to re-open the file. @brugger1 @rusu24edward do you guys think I should go ahead and add a GUI option, or is the flag sufficient?

I think it could be valuable to have it. Then the user would only have to reopen the file for the changes to take effect instead of relaunching VisIt.

I think it could be valuable to have it. Then the user would only have to reopen the file for the changes to take effect instead of relaunching VisIt.

The only case where this extra work is useful is for the AMRStitchOperator, which I believe is pretty rare. While it is useful for any AMR code, I believe it was added for the boxlib folks and I don't know how many of the users of boxlib know about the existance of the operator. Unrelated, but if we decide to add it, it could only go on develop.

The only case where this extra work is useful is for the AMRStitchOperator, which I believe is pretty rare. While it is useful for any AMR code, I believe it was added for the boxlib folks and I don't know how many of the users of boxlib know about the existance of the operator. Unrelated, but if we decide to add it, it could only go on develop.

It sounds like there are a few options here:

Skip adding to the GUI.
Add the GUI option to this PR and change milestone to 3.2 (only merge develop).
Add the GUI option to a new branch/PR that has a 3.2 milestone, and merge the current changes into dev and rc.

There's also the question of where this would go in the GUI (maybe Options->Preferences->Database ?).
I'm looking into the easiest route to making these changes right now, but I'll stop if the path forward is to skip the GUI because it's not used often enough.

It sounds like there are a few options here:

Skip adding to the GUI.
Add the GUI option to this PR and change milestone to 3.2 (only merge develop).
Add the GUI option to a new branch/PR that has a 3.2 milestone, and merge the current changes into dev and rc.

There's also the question of where this would go in the GUI (maybe Options->Preferences->Database ?).
I'm looking into the easiest route to making these changes right now, but I'll stop if the path forward is to skip the GUI because it's not used often enough.

Hmm... I figured it would be pretty simple to get a GUI option in by following the same method used in the Engine, but VisIt doesn't seem to be picking up the changes when it comes from the GUI. I'll need to do a little more digging to figure out how to accomplish this.

Hmm... I figured it would be pretty simple to get a GUI option in by following the same method used in the Engine, but VisIt doesn't seem to be picking up the changes when it comes from the GUI. I'll need to do a little more digging to figure out how to accomplish this.

if the path forward is to skip the GUI because it's not used often enough.

The GUI was option was suggested by Gunther here: https://github.com/visit-dav/live-customer-response/issues/139#issuecomment-692967060
I don't really have a sense of how popular this is. There could be a bit of a gotcha by putting this in the settings if users don't realize that they've activated it in the past and run into performance issues. I wonder if there is a away to put it as a setting in the AMRStitchOperator? Probably not very easily given that it sounds like VisIt would have to reload the database. Maybe the best interface is to require users to launch it with the command line flag.

if the path forward is to skip the GUI because it's not used often enough.

The GUI was option was suggested by Gunther here: https://github.com/visit-dav/live-customer-response/issues/139#issuecomment-692967060
I don't really have a sense of how popular this is. There could be a bit of a gotcha by putting this in the settings if users don't realize that they've activated it in the past and run into performance issues. I wonder if there is a away to put it as a setting in the AMRStitchOperator? Probably not very easily given that it sounds like VisIt would have to reload the database. Maybe the best interface is to require users to launch it with the command line flag.

I wonder if there is a away to put it as a setting in the AMRStitchOperator? Probably not very easily given that it sounds like VisIt would have to reload the database. Maybe the best interface is to require users to launch it with the command line flag.

Yeah, that might be a bit odd, especially since the user doesn't interact with the stitch operator for this to take effect. It's more of a database option. At any rate, getting this into the GUI seems a bit more complicated than I anticipated. I vote to just use the command line flag (at least for now). I can always investigate this again if we get some user interest.

I wonder if there is a away to put it as a setting in the AMRStitchOperator? Probably not very easily given that it sounds like VisIt would have to reload the database. Maybe the best interface is to require users to launch it with the command line flag.

Yeah, that might be a bit odd, especially since the user doesn't interact with the stitch operator for this to take effect. It's more of a database option. At any rate, getting this into the GUI seems a bit more complicated than I anticipated. I vote to just use the command line flag (at least for now). I can always investigate this again if we get some user interest.

I agree, let's consider this done. You can add a new enhancement request referencing the SRE ticket Eddie mentioned.

I agree, let's consider this done. You can add a new enhancement request referencing the SRE ticket Eddie mentioned.


Directory restructure for CR and test projects

Adjusted projects so that individual project tests can be run during publish.
Tried to get as close to as possible to running our clientruntime published nugets to be run with their tests.
Fixed bug to pick up all projects during CI

@azuresdkci test this please

@azuresdkci test this pelase


Show Webmin update on the dashboard without a page update

On the dashboard i can see when there are new updates but the updates for Webmin will not show up until i update the page.

If i open the Package updates i will find the Webmin update here but it would be nice if it could indicate that there is a new Webmin update available. It could be very simple, show an * or something. It is not always you perform an update on the dashboard now when many updates are live.

It will also create this side effect that the message about Webmin update will still be there after i update it from a terminal window

Hi,
Sorry for not answering for a while. I was working on adding caching to search results in File Manager.
Alerts seems to not have background updates yet. Do you think it's necessary? I guess I could make it work.

Okay, it appears that this was already implemented for alerts, I just forgot to add update for the Dashboard.
It's fixed.
Thanks for reporting.

So it is work much better now?

It's now going to update (add/remove) those alert messages (in yellow square, about update/reboot and other) dynamically, without reloading the dashboard.


Added writeVoidPromise to reduce GC for Group Channel Writes.

Added 2 methods to ChannelGroup & DefaultChannelGroup.
This will reduce GC by allowing voiding of promises to all channels.
Closes #3127.
Took a while learning Github.

Missed a Section of code and will use correct commit message


Setup for Spoke/Hub Model

Hello, I wanted to ask if this tool supports Spoke/Hub model?
When pointing OKTA_AWS_APP_URL, OKTA_ORG to the HUB, it works.When changing this variables to the Spoke I get:
 16:55:28.957 [main] ERROR com.okta.tools.awscli -  You do not have access to AWS through Okta.  Please contact your administrator.
AWS Application nevertheless is working on fine in the Browser.
Best regards,
Joaquín

Interesting. Have you verified that the OKTA_AWS_APP_URL is correct for the spoke? I would suggest reaching out to<EMAIL_ADDRESS>for support on this, since helping you get this working will likely involve looking at settings on your Okta orgs, which isn't really appropriate for a public forum.

Hello, I've reached them about this. In the Spoke model, When using
ORG_TO_ORG link in the OKTA_AWS_APP_URL then we have problems with this line
https://github.com/oktadeveloper/okta-aws-cli-assume-role/blob/4dbfb4a7d7ddfb85e5567781d55e3736421c9282/src/main/java/com/okta/tools/awscli.java#L344
because
there's already a RelayState paremeter in the URL.
Tried using a one time session token and then using curl to
https://ORG.okta.com/app/okta_org2org/HASH/sso/
saml?RelayState=/home/amazon_aws/HASH/ID&onetimetoken=TOKEN
https://olx-central.okta.com/app/okta_org2org/HASH/sso/saml?RelayState=/home/amazon_aws/HASH2/272.
When doing this, the SAMLResponse doesn't have any AWS keywords.
Best regards,
On Tue, Feb 7, 2017 at 12:11 AM, Joël Franusic<EMAIL_ADDRESS>wrote:

Interesting. Have you verified that the OKTA_AWS_APP_URL is correct for
the spoke? I would suggest reaching out to<EMAIL_ADDRESS>for
support on this, since helping you get this working will likely involve
looking at settings on your Okta orgs, which isn't really appropriate for a
public forum.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/oktadeveloper/okta-aws-cli-assume-role/issues/24#issuecomment-277844945,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ5nlJ3n-XJqI9803lgSO4P67T8QZGCHks5rZ6iagaJpZM4L0CoU
.

--
Joaquin Rinaudo
*Information Security Head *
Central Infrastructure Team
Berlin - Germany
Mobile: +49-17-4341-3815
Skype: jmrinaudo1
E-mail<EMAIL_ADDRESS><EMAIL_ADDRESS>

I am having the same issue. Was there a fix?

Hello,
I'm getting the same problem while implementing it on my laptop (Win 10). Can someone please assist me?

java -classpath oktaawscli.jar;../lib/aws-java-sdk-1.11.141.jar com.okta.tools.awscli
Username: razique.anjum
Password:
12:00:58 [main] ERROR com.okta.tools.awscli -
You do not have access to AWS through Okta.
Please contact your administrator.

OKTA_AWS_APP_URL is also correct and having the access and no issue while accessing it on browser.
Thanks,
Razique

I am now getting this error as well.  Is there a fix?  What URL should I be using?  We have a single AWS cred account and a single Okta app.

@etendards
I suspect, you have no AWS roles assigned to you in your Amazon Web Services Okta app.
You should make sure:

provisioning is enabled on your Amazon Web Services Okta app
the IAM credentials it has can read your AWS account’s IAM Roles
your AWS account’s IAM Roles have a trust relationship allowing your Okta Identity Provider to use them
your AWS account’s IAM Roles have a policy allowing them to assumeRole on themselves (strange, but true)

You should use the App Embed URL.
It might be worth stepping through the setup instructions for the Amazon Web Services Okta app provided on its sign-in tab in the admin console.

Our Okta Admin turned on App level MFA and that is why my script broke.  This app only seems to work with Global MFA in Okta.

@etendards I’ll give app-level MFA a try in oktapreview and see if I can fix this. Thank you for the update 😊

I wasn't able to figure this out. I can't find docs on this, so I've reach out to Okta Developers list for support. I'll keep you posted.

AFAIK, There is currently no support for App-Level MFA policies via the API only the global one.  Now, I think it may change with the OIDC flow.  Will need one of the other experts to chime in here...

Thank you, @mmahadevan-okta. That seems to be what I've discovered after some troubleshooting. The App Embed Link presents a org signin form. I'm going to consider this unsolvable for the moment and pause it :)

Thank you all for looking into this.  If anyone finds a way to do this with Okta MFA at the App level, please share.   So far Okta has no solutions for this need.

@joaquinrinaudo-olx for hub and spoke with Amazon Web Services apps in the spokes, I think you would need to add novel support to this code base. It would be non-trivial to say the least.
There wouldn't be a single Amazon Web Services app, but many. This tool is only designed to support a single Amazon Web Services app. It's conceivable that setting the OKTA_AWS_APP_URL to the Okta2Okta (or other app you are using between hub and spokes) and adding a fromURI query param on it with the URL encoded path of the downstream Amazon Web Services app. Even then, this would still only support a single spoke.
I think it would be better for you to put a single Amazon Web Services app in the Hub org and grant access to distinct AWS accounts and roles by Okta Group or Active Directory Group. You don't lose precision of access, but you do wind up losing granularity of Okta administration of the Amazon Web Services app, if that was a design goal for your Hub/Spoke arrangement.

Once there is a release based on #109, you should be (in principle at least) able to get hub/spoke use of this working by setting OKTA_BROWSER_AUTH to true and OKTA_AWS_APP_URL to your hub Okta IdP URL assuming you have configured or appended the RelayState to it correctly.

@AlainODea do you have an example on how to configure / append the RelayState correctly?

This is an analysis I did to tease apart how RelayState and fromURI work in Okta:
https://gist.github.com/AlainODea/d92edeab5edc9eaa4be83fa4cf540267

FYI, please don’t @ me in general as I’m off this project now. https://github.com/oktadeveloper/okta-aws-cli-assume-role/issues/292


nix/review_shell.nix: use ignoreFileOutputs whenever available

This PR depends on NixOS/nixpkgs#353752 and fixes #408 partially.
Cc: @corngood

Considering that the single-file-output error is a potential way to enforce the correctness of meta.outputsToInstall, we may want to preserve such behavior while proving options to ignore those single-file outputs.
I prepared the implementation to support nixpkgs-review --ignore-single-file-outputs locally. I could push it up if we agree that this should be supported through a flag.
@Mic92, what do you think?


[WIP] Add Windows support

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no/yes (tbd)

Deprecations?
no

Related tickets
#656

License
Apache 2.0

What's in this PR?
(Adding more information soon) This PR adds logging support for Windows nodes.
Additional context
This PR was based on previous experiences with Rancher projects using Windows.

https://github.com/rancher/fluentd
https://github.com/rancher/fleet
https://github.com/rancher/dapper

Checklist

[ ] Code meets the Developer Guide
[ ] User guide and development docs updated (if needed)
[ ] Related Helm chart(s) updated (if needed)

To Do

[ ] If the PR is not complete but you want to discuss the approach, list what remains to be done here

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @nickgerace!
First of all, thanks for your contribution.
Sadly I didn't mention your issue in our PR and because of this, you didn't get the information that we are working on your problem.
Sorry about that.
So, we had good progress on this, but now we have an issue with the fluent-bit windows/amd64 container. There isn't any official support for that in the fluent dockerhub.
We made our build from the official win-docker file, but of course, it's not working by default ...
Now we are working on this issue, but because we don't have too strong knowledge in the containerized windows world and especially with the debugging this isn't looking now an easy trip...
If you could help us with this issue it would be great.
Thanks!

Hi @ahma! Thank for the update and it's exciting to see your progress. I'd be happy to help.
What does the new nodeAgent do exactly? It appears to be a controller that creates a fluentbit daemonset (among other required resources), but I'm curious what functionality does nodeAgent give that the core operator cannot already do?

@nickgerace, Yeah, you're right.
Now you can define multiple fluentbit daemonsets whith the nodeAgent deffinition. e.g.:
nodeAgents:
  - name: winagent
    type: windows
    nodeAgentFluentbit:
      metrics:
        serviceMonitor: false
        prometheusAnnotations: true
  - name: linuxagent
    nodeAgentFluentbit:
      metrics:
        serviceMonitor: false
        prometheusAnnotations: false

In long term, it could be useful if we want to support not just fluent-bit but for example promtail, or anything else.
A little status update:
The latest 1.6.5 Windows image seems to work now. Our next problem is that the fluent-bit can not catch any container logfile update under the /var/log/containers/. The route cause of the problem could be some symlink following miss function, but that is just an early guess from me.

Closing in favor of https://github.com/banzaicloud/logging-operator/pull/665
Thank you for the explanation @ahma. I've been using the builds from that branch with my clusters. Seems like it is close!


python310Packages.awswrangler: init at 2.19.0

Description of changes
~This depends on #213053 and #213054.~
Adds AWS SDK for Pandas (awswrangler on PyPI):

https://github.com/aws/aws-sdk-pandas
https://pypi.org/project/awswrangler/

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This breaks eval:
error: Function called without required argument "SPARQLWrapper" at pkgs/development/python-modules/awswrangler/default.nix:2

because SPARQLWrapper is an alias.

This also fails to build since https://github.com/NixOS/nixpkgs/pull/213324 was merged.


Revert "Add ≡ (equivalent to ==) and ≢ (equivalent to !=)"

Reverts Raku/doc#3674

3 reverts for what? Yes, the op is wrong, but it could've been fixed with just one commit.

Well, I use rebase instead of squash usually. No big deal.

@lizmat you're on a mission to downvote all my comments, or what?

So, to clarify, a relatively new contributor submitted a PR that you reviewed poorly. Then, once it was pointed out that there's a little mistake and it talks about a different operator, you reverted the whole thing with three revert commits, instead of just adding missing parens. Not only it unnecessarily clutters the git history, but it also makes it somewhat hard for new contributors to proceed. Why revert it in the first place? You sure that the revert sends the right message?
But, as it seems, this is considered normal around here, and it's not the first time I see this attitude. The downvotes that completely fail to understand the issue, and are there just because I pointed it out, are also very telling.


OSC doesn't work

OSC stopped working at some point.
I had to make a hack to get OSC to work.

Solved (I think) in https://github.com/loopier/animatron/commit/f9191cbfc6425fbff73fb57821d0a62604c3b83c

@totalgee suggested that this should work withouth OscReceiver being a Node.
So I'm undoing it and reopening the issue.
The object is added as a child in this line but it's not working. We need to find out why.

I posted the question on Godot's forum.

You can't add it as a child if it's not some kind of Node, the deferred add_child probably fails. In the _physics_process() for Main you could just call the OscReceiver method to get messages.

Or, make it extend Node. In fact, I see that is how the code is in develop, whereas in main branch it does not extend Node. That's likely why one is working and the other not.

Yes, I changed it in develop to see if it worked, but you suggested OscReceiver should not be a Node (or so I recall).
I tried also calling _physics_process from Main but that slowed down the app. Should we then just convert OscReceiver to Node?  Why did it work before, then?


test: ignore spec on coverage & better comments in app-factory

Pull Request Guidelines
Our guidelines for submitting a pull request.
Before submitting your PR, please verify the following:

[ ] The commit message follows our guidelines:

Make sure you prefix your commit message with the type of change you are making.

Fixing a bug : fix: description of the change.
Adding a new feature : feat: description of the change.

See the options for the different types of changes you can make in the package.json file of your project.
Leave the options below unchecked if they are not applicable to your Pull Request.

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Test
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If yes Please describe the impact and mitigation strategy for existing applications.
What was changed?
Please describe what you have changed in this PR.
Other information
Any other information that is important to this PR.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.08%. Comparing base (9d0bc7e) to head (698053d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   83.08%   83.08%
=======================================
  Files          44       44
  Lines        2016     2016
  Branches      288      288
=======================================
  Hits         1675     1675
  Misses        341      341

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Managed Grafana tutorial of managed prvate endpoint for oss Prometheus

Managed Grafana tutorial of managed prvate endpoint for oss Prometheus

@weng5e,
Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
After you make your changes in the private repo, review the articles on staging, and fix any validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.
Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Get started contributing to the Microsoft Learn platform.
We'll close this PR. Thank you.


Unable to do any new releases

The upload-release-assets script has the following error:
Run csexton/release-asset-action@master
Uploading release assets to: https://uploads.github.com/repos/adafruit/Adafruit_CircuitPython_MatrixPortal/releases/33758645/assets{?name,label}
Uploading file: bundles/adafruit-circuitpython-matrixportal-5.x-mpy-1.9.1.zip
Uploading file: bundles/adafruit-circuitpython-matrixportal-6.x-mpy-1.9.1.zip
Uploading file: bundles/adafruit-circuitpython-matrixportal-examples-1.9.1.zip
Uploading file: bundles/adafruit-circuitpython-matrixportal-py-1.9.1.zip
Uploading file: bundles/z-build_tools_version-1.5.0.ignore
Error: Upload failed: Error uploading to https://github-production-release-asset-2e65be.s3.amazonaws.com: 403 undefined
Uploaded adafruit-circuitpython-matrixportal-examples-1.9.1.zip
Error: Upload failed: Error uploading to https://github-production-release-asset-2e65be.s3.amazonaws.com: 403 undefined
Uploaded adafruit-circuitpython-matrixportal-6.x-mpy-1.9.1.zip
Error: Upload failed: Error uploading to https://github-production-release-asset-2e65be.s3.amazonaws.com: 403 undefined
Uploaded z-build_tools_version-1.5.0.ignore
Error: Upload failed: Error uploading to https://github-production-release-asset-2e65be.s3.amazonaws.com: 403 undefined
Uploaded adafruit-circuitpython-matrixportal-5.x-mpy-1.9.1.zip
Error: Upload failed: Error uploading to https://github-production-release-asset-2e65be.s3.amazonaws.com: 403 undefined
Uploaded adafruit-circuitpython-matrixportal-py-1.9.1.zip

See https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal/runs/1382462959.
The release only has 2 assets attached instead of 7 so they won't be included with the bundle. Attempting to re-run this  results in a different error saying the uploads already exist or something.

I noticed it was included in the latest bundle, but couldn't verify the version of the file included.

The server must have been having a bad day because I was able to release 1.9.3 without any issues.


Support all predefined States errors

In GitLab by @EpicWink on May 9, 2019, 07:17
Related to #2, but for only the States errors.
Defined at the bottom of the spec, currently:

States.ALL
States.Timeout
States.TaskFailed
States.Permissions
States.ResultPathMatchFailure
States.ParameterPathFailure
States.BranchFailed
States.NoChoiceMatched

In GitLab by @EpicWink on May 9, 2019, 07:24
closed via commit f8f84dd9b01adbf0f7efb5fc10cefcc84ef0e58f

In GitLab by @EpicWink on May 9, 2019, 08:02
mentioned in commit f8f84dd9b01adbf0f7efb5fc10cefcc84ef0e58f


feat: added assert API's for listbox control

Assert API for listbox control:

All the Drona tests have been passed.

[like]  Kavin Palanisamy reacted to your message:

From: Sairam S @.>
Sent: Sunday, August 27, 2023 1:17:23 PM
To: solitontech/SLL-Drona @.>
Cc: Kavin Palanisamy @.>; Author @.>
Subject: Re: [solitontech/SLL-Drona] feat: added assert API's for listbox control (PR #86)
@Sairam0496 requested changes on this pull request.
address the comments in each file and mark conversations resolved
—
Reply to this email directly, view it on GitHubhttps://github.com/solitontech/SLL-Drona/pull/86#pullrequestreview-1597135519, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BAKWDGPQ3Q2TKT5RVUVI7KDXXNCGHANCNFSM6AAAAAA36PKWFQ.
You are receiving this because you authored the thread.Message ID: @.***>


Code Coverage Not showing all Lines

Describe the bug
Code Coverage does not show all lines of code that were excecuted.
That makes it hard to reach 90 percent Code coverage with the testapp.
The Lines were executed. I've debugged through it.
To Reproduce
AL Code to reproduce the issue
Expected behavior
Screenshots
5. Versions:

AL Language: 4.0.199169

Business Central: Version: DE Business Central 15.1 (Platform 15.0.37769.0 + Application 15.1.37793.0)

Hi! Can you please provide a sample test app and a sample app so that we can investigate this issue?

This issue has been closed because it needs more information and has not had recent activity. Please open a new issue if you believe this has not been resolved and reference the current issue.


Core cleanup: two stage shutdown

Description:
Cleanup core with change to a 2 stage shutdown system. First stage (EVENT_HOMEASSISTANT_STOP) close all device/component relevant stuff. In second stage (EVENT_HOMEASSISTANT_CLOSE) we can now close stuff who is needed in first stage. In this way the core need not to know what he need to close before the loop will end.

🐬
Ok to merge when tests pass


Action proba

fixed action probability for continuous (#126), multiDiscrete and multiBinary actions with actor-critic models
added optional parameter to action_probability for likelihood calculation of given action being taken. (#127)

Nice! Thanks


Add CI jobs for Windows

The job builds a single-file version of the Au library, and runs a
simple test.  This test is enough to reproduce the errors in #143:
https://github.com/aurora-opensource/au/actions/runs/5496101666/job/14882361539
It also catches another few compiler errors on other versions of MSVC,
which we fix here.  The issue is that function parameters can't be used
in a constexpr context in general.  These particular parameters are
monovalue types
(https://aurora-opensource.github.io/au/main/reference/detail/monovalue_types/),
so the compiler's being a little pedantic in enforcing this rule, but
this also means that it's easy to fix the error.
With this PR, we go from 0 to 1 in terms of CI jobs for "best effort"
platforms.  This gives us a pattern we can use for future new platforms.
Helps #144.

Since these new jobs are the first in the "best effort" tier, technically they don't have to always be passing.  However, I think we want to make, well, our best effort to keep them passing, so I'll make them blocking unless and until something forces us to let them fail.


useLoaderData() returns incorrect type

What version of Remix are you using?
1.6.4
Steps to Reproduce
In the following code, the events variable has the wrong type:
import { json } from "@remix-run/node"
import { useLoaderData } from "@remix-run/react"
import type { Event } from "@prisma/client"

import { getEvents } from "~/models/events.server"

export const loader = async () => json({ events: await getEvents() })

const Events = () => {
  const { events } = useLoaderData<typeof loader>()

  return (
    <>

Events

      {events.map(event => <Event key={event.id} event={event} />)}
    </>
  )
}

const Event = ({ event }: { event: Event }) => {
  const { title, start, end } = event
  return
{event.title}

}

export default Events

yielding an error on the map() function:

Steps to reproduce

Copy this code into an events.tsx route

import { json } from "@remix-run/node"
import { useLoaderData } from "@remix-run/react"
import type { Event } from "@prisma/client"

export const loader = async () => json({ events: [
  {id: 'adasdasd', title: "Event 1", start: "day 1", end: "day 2"},
  {id: 'qweqweqw', title: "Event 2", start: "day 2", end: "day 3"},
] })

const Events = () => {
  const { events } = useLoaderData<typeof loader>()

  return (
    <>

Events

      {events.map(event => <Event key={event.id} event={event} />)}
    </>
  )
}

const Event = ({ event }: { event: Event }) => {
  const { title, start, end } = event
  return
{event.title}

}

export default Events

Hover over events to see the type

I'll create a test once this bug's confirmed.
Expected Behavior
I'd expect useLoaderData() to give me the type:
Event[]

or on the example with a hardcoded array:
{
  id: string,
  title: string,
  start: string,
  end: string
}

Actual Behavior
useLoaderData<typeof loader>() type is SerializeObject<UndefinedToOptional<Event>>[]

Hey @andrecasal, I would recommend upgrading your Remix packages to at least 1.6.5, where we enhanced type inference from loader and action: https://github.com/remix-run/remix/releases/tag/remix%401.6.5
Closing this as it's already fixed.

Awesome, thanks!

I just realized the version I'm using 1.7.5 for @remix-run/node and @remix-run/react. I mistakenly looked at the 1.6.4 for the dev dependencies @remix-run/dev, @remix-run/eslint-config, and @remix-run/serve.

@andrecasal make sure you use the same version for all packages, or you might have some inconsistent behaviors.
As for the loader, you need to hint its parameter with LoaderArgs for type inference to work:
export async function loader(args: LoaderArgs) {
   return json(data);
}

or
export async function loader({request}: LoaderArgs) {
  // do your thing with request
   return json(data);
}

All packages (dev and otherwise) have been updated to 1.7.5, but the problem still persists. Here's my package.json:
{
	"name": "andrecasal.com",
	"private": true,
	"description": "",
	"license": "",
	"sideEffects": false,
	"scripts": {
		"dev": "remix dev",
		"build": "remix build",
		"start": "remix-serve api"
	},
	"prisma": {
		"seed": "ts-node prisma/seed.ts"
	},
	"dependencies": {
		"@prisma/client": "^4.5.0",
		"@remix-run/node": "^1.7.5",
		"@remix-run/react": "^1.7.5",
		"@remix-run/vercel": "^1.7.5",
		"@vercel/node": "^2.6.1",
		"front-matter": "^4.0.2",
		"marked": "^4.2.2",
		"react": "^18.2.0",
		"react-dom": "^18.2.0",
		"remark-toc": "^8.0.1",
		"styled-components": "^5.3.6",
		"tiny-invariant": "^1.3.1"
	},
	"devDependencies": {
		"@remix-run/dev": "^1.7.5",
		"@remix-run/eslint-config": "^1.7.5",
		"@remix-run/serve": "^1.7.5",
		"@types/marked": "^4.0.7",
		"@types/node": "^18.11.9",
		"@types/react": "^18.0.25",
		"@types/react-dom": "^18.0.8",
		"@types/styled-components": "^5.1.26",
		"eslint": "^8.27.0",
		"prisma": "^4.5.0",
		"ts-node": "^10.9.1",
		"typescript": "^4.8.4"
	}
}

Please try the function form as mentioned in the release note.
export async function loader({request}: LoaderArgs) {
    return json({ events: await getEvents() });
}

@machour Using both function or arrow function should work here.
I think the problem is Event has some properties that are changing types when serializing them (for instance Date that becomes string)

@MichaelDeBoey you're right start and end where being declared as DateTime in the Prisma schema:
model Event {
   id               Int      @id @default(autoincrement())
   title            String   @unique
   type             String
   image            String
   start            DateTime
   end              DateTime
   description      String
   location         Location @relation(fields: [locationId], references: [id])
   locationId       Int
   streamLink       String?
   registrationLink String
   price            Int
}

model Location {
   id      Int     @id @default(autoincrement())
   name    String  @unique
   address String
   lat     Float
   lng     Float
   Event   Event[]
}

The Prisma client returns all DateTime as native Date objects, which breaks the type checking when communicating values from the backend to the frontend.
I changed start and end to String for now and it worked 👌

Out of curiosity, how would you deal with DateTimes In Prisma?
It's saved as a String in the DB anyway, but the client converts them to Date objects.
Do you avoid DateTimes entirely or convert Date objects back to strings before sending them off to the frontend?

Checkout remix-typedjson which was written spefically to handle non-JSON types. You get full type inferrence and type fidelity.
https://github.com/kiliman/remix-typedjson

Is adopting typedjson in Remix's roadmap and making this transparent for the developer?

@andrecasal I don't think it's the case.
You can open a discussion (proposal category) to see how much traction this idea gets.


[RPC] graduate tvm.contrib.rpc -> tvm.rpc

RPC has been under contrib for two releases and has becoming one of the key features we rely on, this PR graduates tvm.contrib.rpc -> tvm.rpc

cc @yzhliu @eqy @merrymercy @Laurawly


Data gets deleted after the extension version is updated.

Hi,
I've created an extension having table. I've also added the upgrade codeunit but after installing the extension through the Visual Studio Code, the data gets deleted related to the extension.

This feature has been implemented and you can read more about it here:
https://docs.microsoft.com/en-us/dynamics-nav/developer/devenv-retaining-data-after-publishing


Feature/should-not-assert method

added new assert for should-not include
demo

Thank you! can you also please add a test for it?
https://github.com/ShellyDCMS/cypress-test-utils/blob/main/src/cypress-helper.cy.ts


[WIP] Monitoring in Chainstate

Codecov Report

Merging #49 (2f2c440) into master (8225116) will decrease coverage by 2.32%.
The diff coverage is 18.28%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   64.08%   61.75%   -2.33%
==========================================
  Files          90      100      +10
  Lines        8219     8642     +423
==========================================
+ Hits         5267     5337      +70
- Misses       2615     2964     +349
- Partials      337      341       +4

Flag
Coverage Δ

unittests
61.75% <18.28%> (-2.33%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

chainstate/chainstate.go
95.12% <0.00%> (-4.88%)
:arrow_down:

chainstate/client.go
62.50% <0.00%> (-4.17%)
:arrow_down:

chainstate/client_options.go
90.51% <0.00%> (-7.13%)
:arrow_down:

chainstate/filters/planaria-d.go
0.00% <0.00%> (ø)

chainstate/filters/pubkeyhash.go
0.00% <0.00%> (ø)

chainstate/filters/rarecandy.go
0.00% <0.00%> (ø)

chainstate/monitor.go
0.00% <0.00%> (ø)

client.go
63.91% <0.00%> (-2.04%)
:arrow_down:

client_internal.go
76.05% <0.00%> (-13.95%)
:arrow_down:

client_options.go
75.00% <0.00%> (-2.28%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8225116...2f2c440. Read the comment docs.


Hold FY2020 Q2 compliance meetings (including prep and retro)

In order to meet compliance criteria,  we want to hold our quarterly account review and annual contingency plan rehearsal.

Security considerations
None
Implementation
Quarterly account review

Peter needs to review and stage work so our meeting goes efficiently (1h)
Hold the team meeting
Update doc for next time

Contingency plan

Review draft plan with Ron or Eddie and operations team repr
Draft scenario
Run meeting

Held part one on 2020-03-30, notes are: https://docs.google.com/document/d/1xJsKfUJa3SESSvLy3Il43wWYk_dUWTNcxQ209-sN2bI/edit#heading=h.91k8aedczj1s
We spent an hour on the policy work, will review roles/accounts on 4/13.


MCF Browser: tmcf+csv to mcf

parse-tmcf.js contains functions to parse tmcf+csv and convert to mcf

Christie -- I see some commits. Can you confirm if this is ready for another review?

I'll merge this PR now.  Please fix the minor comment change in follow up PR.


remove excessive loading of url requests

Task/Issue URL :https://app.asana.com/0/392891325557410/1198194737172882
Tech Design URL:
CC:
Description:
Fix a bug where the tab history would get messaged up when GPC was enabled.
Steps to test this PR:

Visit https://news.ycombinator.com/
Scroll down the page and navigate to a site
Go back - button should be disabled and location on page should not have change
Check that GPC header is still being sent

Internal references:
Software Engineering Expectations
Technical Design Template

Thanks @SlayterDev !


CONNECTION_REFUSED

I'm getting the following error:
(index):707
   POST http://<IP_ADDRESS>:8080/api/rrweb/save net::ERR_CONNECTION_REFUSED

great tutorial and repository, but I have this error :(

I also tried on localhost and I get the error below:
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://localhost:8080/api/rrweb. (Reason: CORS request did not succeed). Status code: (null).

something related to  CORS  "Access-Control-Allow-Origin"  but I haven't managed to solve it yet.

using the CORS unblock extension I can access without error, I could update the spring bot to allow sending Access-Control-Allow-Origin ?

I managed to get around the problem by creating an endpoint with nodejs to perform the query on the api and then manipulate the response and add "Access-Control-Allow-Origin" to the request header. Correction is in my git, any questions just call :D


Ui overhaul

the new handlers folder is missing from the "packages" field in setup.py, add ModulineWebUI/handlers to it

the new handlers folder is missing from the "packages" field in setup.py, add ModulineWebUI/handlers to it

done

lgtm


Support for GitHub releases

Would be nice if releases could be uploaded

Definitely a good idea, I'll have a look into getting Linux and macOS building first (just have to figure out how to get Rust & Node in the same travis build).
Once I've done that I'll see if I can get a Windows build running on appveyor.

I'd appreciate this, since compiling it under windows is pretty painfull.

All the required changes:
https://github.com/amilajack/popcorn-time-desktop/blob/master/package.json#L24
https://github.com/amilajack/popcorn-time-desktop/blob/master/.travis.yml#L79
https://github.com/amilajack/popcorn-time-desktop/blob/master/appveyor.yml#L49
I can PR for this


openshift-preflight container scan fixes

Dockerfile:

fixes HasLicense: copy LICENSE information to /license folder in container image
fixes HasRequiredLabel: add label information with name, vendor, version, summary and description
fixes BasedOnUbi, HasNoProhibitedPackages, HasModifiedFiles: add registry.access.redhat.com/ubi8/ubi as base image

Signed-off-by: Travis Janssen<EMAIL_ADDRESS>

End-to-end protect and failover tests passed


C#: Fix incorrect types used in ArrayMesh docs

The equivalent of GDScript's Packed*Arrays are C# arrays.
MeshInstance was renamed to MeshInstance3D in 4.0.
Closes https://github.com/godotengine/godot/issues/65937.

Thanks!

Are the docs still wrong?  I followed this in beta5 and it didn't work.  I needed to do .ToArray() on my Array to get it to work.

@delinx32 The docs are correct. The method .ToArray() returns a Vector3[] which is the same type the docs already use, sounds like you are using Godot.Collections.Array<Vector3>() which is from the old incorrect docs.


fix: item should not include not

如果审核状态里不为空，但其中包含了“未”字，则也表明此行数据尚未审核
Signed-off-by: Frankzhaopku<EMAIL_ADDRESS>

Codecov Report

Merging #45 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master     #45      +/-   ##
=========================================
- Coverage   29.87%   29.8%   -0.08%
=========================================
  Files          17      17
  Lines         405     406       +1
  Branches       18      19       +1
=========================================
  Hits          121     121
- Misses        284     285       +1

Impacted Files
Coverage Δ

app/schema/table.ts
50% <50%> (-5.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2968de...5f6cb99. Read the comment docs.


Opening new tab fails after previously closing a tab

New editor tabs fail to open after an editor tab has been closed. The correct contents load into the ace session, however the tab itself does not display.

delete editorSession[<key>]; does not delete the key from editorSessions in EditorService.fileRenamed() and EditorService.closeSession().


Use ESLint for Web UI

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7136/
Test FAILed.

@calvinjia PTAL, thanks

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7153/
Test FAILed.

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7164/
Test PASSed.

alluxio-bot, merge this please.


Added ability to submit messages with cmd+Enter (#328).

Pull request checklist

[x] Your code contains tests relevant for code you modified
[x] You have linted and tested the project with bin/check

Looks great! Thanks for the contribution.


problem with the health bar

Describe your bug here.
every time I add something custom (like a song, a chart, a character, an icon or a background) the health bar disappear

Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
i only added a chart and a song in the photo

You have Hide HUD on

💀