always load all scripts in type/, command/ and handler/

Mmm… on a second thought, this would be broken if I have any source files from the same directories that must be loaded in a specific order, perhaps due to some dependency. There is no easy way to fix that…

Mmm… on a second thought, this would be broken if I have any source files from the same directories that must be loaded in a specific order, perhaps due to some dependency. There is no easy way to fix that…

We could switch to making proper (sub)modules rather than bulk-including everything into the Main-Module

Separating type definitions allows you to use it in multiple files without worrying about the order of the included files. It's simpler to just place it at the beginning of includes than trying to figure out how to order the rest of the files.

But why do multiple independent plugins need the same types? 👀 This already suggest some coupling which makes me think whether it should be designed differently anyway.

Right, independent plugins don't generally need the same types -- except in the case that a common set of utilities are made available for the plugin's, which is quite conceivable.  In any case, I think we should work on #11.


bootstrap tabs and gumshoe conflict

I noticed a conflict between bootstrap tabs and gumshoe... the first doesn't work at all 'till gumshoe is loaded. Any idea?

Bootstrap's scripts may be waiting for all elements on a page to be loaded before running? You could try using Tabby, my lightweight alternative, instead. All of my script were designed to work together.


config Package

Develop the config package, which handles configuration loading and management using Viper. This package manages settings at global, user, and workspace levels.
Responsibilities

Load and merge configurations from different levels.
Provide access to configuration values.
Ensure configurations are available to other components via AppContext.

Implementation Details

Use Viper for configuration management.
Configurations can be in YAML, JSON, or TOML format.
Precedence: Workspace > User > Global.
Handle missing configuration files gracefully.

Interactions

Initialized by the Core Controller with the workspace root.
Provides configurations to other components via AppContext.
Other components access configurations as needed.

Tasks

[x] Set up the config package.
[x] Implement LoadConfigurations function.
[x] Ensure configurations are merged correctly with proper precedence.

Config implemented here:

https://github.com/matthewchivers/dodl/pull/15

Ultimately this actually looks at "user" and "workspace" and omits any kind of "global" settings (YAGNI). The project just isn't big enough for that yet (and honestly, I'm not actually sure it's even big enough for the "user" level, but I think it could prove useful sooner than global...).


Bump<EMAIL_ADDRESS>

I want to update the default example reflecting this change! Where can I find the documentation of the info button of Scarab?

This is how you use it: https://github.com/mapzen/scarab/blob/master/test/index.html#L41
Without a "description" property in options, a button won't show up at all.
I should update the README, will do it now in the repo.


replace tests/data/... with json-fg dataset

Hm, the 3dbag_5907.json is a json-fg file. Isn't it what you meant?

oh shoot. I got confused by the .jsonfg extension of the sample data at https://data.3dgi.xyz/jsonfg/3dbag/jsonfg/ (I guess it should be changed to .json?). False alarm then!

I think it is still up for discussion.
I was not consistent in this repo. I used .jsonfg in the converted data to distinguish the files. I'll rename this one to .jsonfg too.

to be honest .json might be better, easier to handle with software that reads json. Also the same as geojson.


Resolves #47 repository structure updates

Ends up that this was a little more than a minor directory update. But makes things way more consistent for moving everything forward.
Biggest things to see:

Moves all source assets to three folders depending on how they are intended to be exported:

framer
src
utils

Moves some previous, complex root level config into their own dirs:

.cosmos
.jest

Deprecated use of running cosmos scoped to a specific package to keep toolchain maintenance easier
Moved some complex commands for test builds on Cosmos into root package.json for easier reuse

@CaffeinatedAllie this also means specs and tokens are now located in the src folder. But at least this makes things more consistent where we look for everything.

New:

Old:

TBH I would look for the spec files in the SRC folders anyways :) So I approve of this change! 👍

:partyparrot:


[Enhancement] (nereids)implement showCreateViewCommand in nereids

showCreateView command is supported in legacy planner but not in nereids(new doris fe planner). you need implement the following showCreateView command in nereids:
unsupportedshowCreateViewStatement
SHOW CREATE VIEW name=multipartIdentifier

@starocean999 @LiBinfeng-01 @morrySnow Please assign this issue to me


Idle Notifier: No Notifications for Pottery Crafting

Describe the bug
The Idle Notifier does not notify the user when they are finished interacting with the Potter's Wheel nor when using the Pottery Oven.
Secondly, there is no notification when a player levels up using these crafting methods (as a workaround, a player can be notified by turning on the Screenshot module), even though this feature is present when fishing.
To Reproduce
Steps to reproduce the behavior:

Use "soft clay" on Potter's Wheel and select an option.
Wait to finish.
No notification when finished.

--

Use "unfired X" (from previous steps) on Pottery Oven and select an option (if applicable).
Wait to finish.
No notification when finished.

Expected behavior
Upon transforming all of the items available in your inventory into the finished product, the Idle Notifier should throw a "... is now idle!" notification. Runelite should also notify the player when they level up using these methods.
Screenshots
This screenshot shows that Runelite did not output into chat that the player had become idle due to stopping from leveling up while using the pottery crafting benches.
https://i.imgur.com/1AkvZIz.png
Environment (please complete the following information):

OS: Windows 10
RuneLite version: 1.5.20
Launcher version: 1.6.0

Level-ups don't trigger any notifications in general, so I don't see why it should specially do so while crafting pottery. (Turn on notifications from the screenshot plugin and enable screenshots of level-ups if you want that)
Sounds like the pottery animation just needs to be tracked in the idle plugin.

Ah, I thought there was a notification for leveling up. It was probably just the screenshot module, then.


Export bucket properties type for use in other modules/apps

We have (badly) duplicated bucket property type specs across Riak - these were needed in Yokozuna so clean up/export them here. Later work should revisit other places where we use bucket properties but have not specified them well.

Love this. ❤

@JeetKunDoug Squash 3 commits into one?  Cleanliness next to godliness, and all that jazz?

+1 9f3cfbf

@borshop merge


[Responsive] Fixed sample web build failed

The CI/CD is failing because of the npm package.json is not in the project for install

Info: Azure Pipelines hosted agents have been updated and now contain .Net 5.x SDK/Runtime along with the older .Net Core version which are currently lts. Unless you have locked down a SDK version for your project(s), 5.x SDK might be picked up which might have breaking behavior as compared to previous versions. You can learn more about the breaking changes here: https://docs.microsoft.com/en-us/dotnet/core/tools/ and https://docs.microsoft.com/en-us/dotnet/core/compatibility/ . To learn about more such changes and troubleshoot, refer here: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/build/dotnet-core-cli?view=azure-devops#troubleshooting
##[error]Dotnet command failed with non-zero exit code on the following projects : [
  'D:\\a\\1\\s\\IdentityAdmin\\tests\\Wangkanai.IdentityAdmin.Test.csproj'


MVP Documentation Site

Todo:

Detailed API docs for Rely & FCP
Better logo animation
Better banner logo

Preview:
https://kpsuperplane.github.io/reason-native
Builds off many of the excellent readme's written by @bandersongit

This is awesome!


Add zIndex property

This is the only property I've found that takes a dimensionless value (Int in this case), so I just show it to String, rather than creating a newtype and corresponding Val Int instance.
Closes #65

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

FYI the CI build failed because of something unrelated:
$ npm run -s build
* Error: Unrecognised arguments: --censor-lib, --strict
Usage: pulp [global-options] <command> [command-options]

Thanks! Int makes sense here for sure.


How do you resend a failed email

If the JSON shows that there was an error sending the email, how do you resend it after correcting it?

Closing  - Not a documentation issue - this sort of question is better asked in the forums


Is video upload is supported

Hi is video upload is supported.? Thanks!

Hi, currently the public Instagram API does not support this feature.

Hi Thanks for letting me know.


Problems building apex with ROCm-5.4, 5.5, and 5.6

Describe the Bug
The latest master branch fails to build with several ROCm versions, including 5.4, 5.5, and 5.6.
Rolling back to the commit made on June 20 (git checkout 10c7482) allows ROCm-5.4 to build.  The build still fails for 5.5 and 5.6 but with a different error.
Minimal Steps/Code to Reproduce the Bug

For ROCm-5.4.3, I use the following to build:
virtualenv --system-site-packages env
source env/bin/activate

pip3 install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/rocm5.4.2

git clone --recursive https://github.com/ROCmSoftwarePlatform/apex.git
cd apex

export DISTUTILS_DEBUG=1
export __HIP_PLATFORM_HCC__
export __HIP_PLATFORM_AMD__
export HCC_AMDGPU_TARGET=gfx90a
export PYTORCH_ROCM_ARCH=gfx90a
export ROCM_HOME=/opt/rocm-5.4.3
export CC=gcc
export CXX=g++
pip3 install -v --disable-pip-version-check --no-cache-dir --no-build-isolation --config-settings "--build-option=--cpp_ext" --config-settings "--build-option=--cuda_ext" ./

The build fails when compiling csrc/mlp_hip.hip with errors like the following:
  csrc/mlp_hip.hip:65:53: error: unknown type name 'hipblasOperation_t'; did you mean 'hipsparseOperation_t'?
  static rocblas_operation hipOperationToRocOperation(hipblasOperation_t op)
                                                      ^~~~~~~~~~~~~~~~~~
                                                      hipsparseOperation_t
  /opt/rocm-5.4.3/include/hipsparse/hipsparse.h:317:3: note: 'hipsparseOperation_t' declared here
  } hipsparseOperation_t;
    ^
  csrc/mlp_hip.hip:69:10: error: use of undeclared identifier 'HIPBLAS_OP_N'
      case HIPBLAS_OP_N:
           ^
  csrc/mlp_hip.hip:71:10: error: use of undeclared identifier 'HIPBLAS_OP_T'
      case HIPBLAS_OP_T:
           ^
  csrc/mlp_hip.hip:73:10: error: use of undeclared identifier 'HIPBLAS_OP_C'
      case HIPBLAS_OP_C:
           ^
  csrc/mlp_hip.hip:79:8: error: unknown type name 'hipblasStatus_t'; did you mean 'hipsparseStatus_t'?
  static hipblasStatus_t rocBLASStatusToHIPStatus(rocblas_status error)
         ^~~~~~~~~~~~~~~
         hipsparseStatus_t
  /opt/rocm-5.4.3/include/hipsparse/hipsparse.h:188:3: note: 'hipsparseStatus_t' declared here
  } hipsparseStatus_t;
    ^

Rolling back to the commit from June 20 allows the build to complete:
cd apex

git checkout 10c7482
git submodule init
git submodule update

export DISTUTILS_DEBUG=1
export __HIP_PLATFORM_HCC__
export __HIP_PLATFORM_AMD__
export HCC_AMDGPU_TARGET=gfx90a
export PYTORCH_ROCM_ARCH=gfx90a
export ROCM_HOME=/opt/rocm-5.4.3
export CC=gcc
export CXX=g++
pip3 install -v --disable-pip-version-check --no-cache-dir --no-build-isolation --config-settings "--build-option=--cpp_ext" --config-settings "--build-option=--cuda_ext" ./

Building apex from master with ROCm-5.5 and ROCm-5.6 fail with errors similar to each other, but errors that are distinct from ROCm-5.4.  Here are the steps I used to build with ROCm-5.6:
virtualenv --system-site-packages env
source env/bin/activate

pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/rocm5.6

git clone --recursive https://github.com/ROCmSoftwarePlatform/apex.git
cd apex

export DISTUTILS_DEBUG=1
export __HIP_PLATFORM_HCC__
export __HIP_PLATFORM_AMD__
export HCC_AMDGPU_TARGET=gfx90a
export PYTORCH_ROCM_ARCH=gfx90a
export ROCM_HOME=/opt/rocm-5.6.0
export CC=gcc
export CXX=g++
pip3 install -v --disable-pip-version-check --no-cache-dir --no-build-isolation --config-settings "--build-option=--cpp_ext" --config-settings "--build-option=--cuda_ext" ./

That fails with the following error:
  csrc/mlp_hip.hip:91:10: error: use of undeclared identifier 'rocblas_status_excluded_from_build'
      case rocblas_status_excluded_from_build:
           ^
  csrc/mlp_hip.hip:104:10: error: use of undeclared identifier 'rocblas_status_arch_mismatch'; did you mean 'rocblas_status_size_query_mismatch'?
      case rocblas_status_arch_mismatch:
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
           rocblas_status_size_query_mismatch
  /opt/rocm-5.6.0/include/rocblas/internal/rocblas-types.h:212:5: note: 'rocblas_status_size_query_mismatch' declared here
      rocblas_status_size_query_mismatch = 8, /**< Unmatched start/stop size query */
      ^
  csrc/mlp_hip.hip:104:10: error: duplicate case value 'rocblas_status_size_query_mismatch'
      case rocblas_status_arch_mismatch:
           ^
  csrc/mlp_hip.hip:96:10: note: previous case defined here
      case rocblas_status_size_query_mismatch:
           ^

In this case, rolling back to the June 20 commit fails with a different error:
  csrc/mlp_hip.hip:89:7: error: use of undeclared identifier 'rocblas_datatype_f64_r'
        rocblas_datatype_f64_r,
        ^
  csrc/mlp_hip.hip:92:7: error: use of undeclared identifier 'rocblas_datatype_f64_r'
        rocblas_datatype_f64_r,
        ^
  csrc/mlp_hip.hip:96:7: error: use of undeclared identifier 'rocblas_datatype_f64_r'
        rocblas_datatype_f64_r,
        ^
  csrc/mlp_hip.hip:99:7: error: use of undeclared identifier 'rocblas_datatype_f64_r'
        rocblas_datatype_f64_r,
        ^
  csrc/mlp_hip.hip:101:7: error: use of undeclared identifier 'rocblas_datatype_f64_r'
        rocblas_datatype_f64_r,
        ^
  csrc/mlp_hip.hip:102:7: error: use of undeclared identifier 'rocblas_gemm_algo_standard'
        rocblas_gemm_algo_standard,
        ^

Building with the June 20 commit, I see that the csrc/mlp_hip.hip file contains the following for ROCm-5.5 and ROCm-5.6 (which fails):
/* Includes, cuda */
#include <hipblas/hipblas.h>
#include <hip/hip_runtime.h>

but it has the following for ROCm-5.4 (which builds):
/* Includes, cuda */
#include <rocblas/rocblas.h>
#include <hip/hip_runtime.h>

Expected Behavior

Environment

I'm seeing this as well, a number of errors like those above while building the cuda_ext.
/apex/csrc/mlp_hip.hip:65:53: error: unknown type name 'hipblasOperation_t'; did you mean 'hipsparseOperation_t'?
  static rocblas_operation hipOperationToRocOperation(hipblasOperation_t op)

FYI @jithunnair-amd

Hi @adammoody and @loadams, if you are using PyTorch 2.0 or earlier, please use master branch for apex. If you are using PyTorch 2.1+, please use torch_2.1_higher branch.
There are some changes related to CUDA to HIP conversion.
export HIP_PLATFORM_HCC
export HIP_PLATFORM_AMD
these two commands are not needed.
I am not apex developer.


browser.ShowDeveloperTools(); does not work

When I call this method, I do not see the developer tools anywhere. Nothing happens.

Nevermind, it will open if it's called a short while after it is launched, just not immediately


Shield tests(if needed), reviews and approves AWS 19.1.0

Please review the release notes, make sure that the components have right versions and test WCs creation/upgrade if needed. We will only merge when we have approval from all the teams. PR: https://github.com/giantswarm/releases/pull/1147

released


Support tabs in addition to spaces in config file

https://github.com/sentriz/flagconf/blob/9fe528a80ff4365ab2fcb24c87c671c2667c0d3b/flagconf.go#L163C48-L163C52
Hi ! It would be great to be able to use tabs in addition to spaces in the config file.
Right now if one uses tabs between key and value it fail silently. Had the issue in Gonic.
What do you think ?

i think this makes sense. that said, i don't belive it was supported in previous versions of gonic either? https://github.com/peterbourgon/ff/blob/main/parse.go

I guess I wasn't :) But I started using Gonic only a few weeks ago so I only used the version with flagconf.

ah i see :+1:

Tested in Gonic : works fine :) Thanks !


When "Chair" role is not defined, member list formatting gets broken

From 1636.1 document:

== Participants

=== Working group
...

=== Balloting group

item:: 0xSenses Corporation
item:: AAC Technologies
item:: Alibaba China Co. Ltd.
item:: Alipay(China) Technology Co., Ltd
item:: Arpacorp Limited
item:: Beijng Baidu Netcom Science Technology Co., Ltd.
item:: Chaincomp Technologies Co., Ltd.
item:: China Electronics Standardization Institute
item:: Eduworks Corporation
item:: Ericsson AB
item:: InsightOne Tech Co., Ltd.
item:: Lenovo Group Limited
item:: Megvii Technology Limited
item:: Shandong Computer Science Center (National Supercomputing Center in Jinan)
item:: Shanghai Fudata Technology Co., Ltd.
item:: Zhejiang Lab
item:: Zhejiang University

=== Standards board
...

produces:

If I add a chair item:

This is merely a failure on my part to allow for
item:: person

as a replacement of
* person

The current code expects all definition lists to be nested, but they needn't be.


Broken installer in Windows 11

All *msi versions of installer are broken in Windows 11. Everything ends with "BOSSA 1.9.1 Setup Wizard ended prematurely because of an error..." without any additional details.

Solved. Insider build locks driver installation during OS upgrade in the background, so the app installer stopped.


Remove Lock Screen Apps Guidance

Lock Screen Apps and use of Background Tasks for them were an 8.1 concept. They are not a concept in Windows 10 and the section around guidelines for them should be removed from the Background Task documentation.

@cc-cortes,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Thanks Chris. Someday we may stop finding references to this lock screen stuff.


[tosa] Add legalization for TF/TFL conv3d

TFL doesn't have quantized implementation support for conv3d at the moment, only floating is supported in this patch.

Adopt the suggested review comments throughout the patch.

@stellaraccident, I accidentally removed request for you.

@tatwaichong  Can you please resolve conflicts? Thank you!

FYI. This is the change in the reference model to verify the legalization in TF/TFL.


dates for multi-day talk don't work

I'm trying to use the 'talk' widget for a multi-day talk (aka a workshop) that I'm about to give.
in the index.md for the talk, I specify dates as follows:
date: "2019-07-08"
date_end: "2019-07-12"
all_day: true
For some reason, it never shows the end date, only the start. I understand that usually a talk has the same start and end day with just a few hours in between, so I'm doing something slightly different, but shouldn't it still work? What am I missing? Or is the talk widget simply not meant for this? Thanks!

The feature was originally intended for a single talk (where the dates are timestamps on the same day) rather than multi-day events. Therefore this would be a feature request to extend the scope beyond talks.


Trains Won't Spawn on Certain TCC Track Lengths

BkCommonLib version: 791
TrainCarts version: 654 (TCC: 170)
Spigot version: 112 (Latest)

Problem or bug: It seems to depend on a straight-ish line in order to be able to spawn a train or else it won't happen.
Expected behaviour: Train spawns on any angle/curve/etc.
Steps to reproduce: Attempt to spawn a longer train in front of a curve/diagonal.

This is intended behaviour I order to avoid issues with spawning on curves.


[Communication] - phone-numbers - Core V2 migration

Packages impacted by this PR

@azure/communication-phone-numbers

Issues associated with this PR

https://github.com/Azure/azure-sdk-for-js/issues/20056
https://github.com/Azure/azure-sdk-for-js/issues/15814

Describe the problem that is addressed by this PR
Migrate the HTTP pipeline to the new architecture in Azure Core V2. Refer to the following documentation for more details: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-rest-pipeline/documentation/core2.md
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
For information on the Core V2 migration, refer to: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-rest-pipeline/documentation/core2.md
This migration introduced the following two compatibility issues:

The phone numbers API uses relative URLs for nextLink values in endpoints that support paging, which is not supported out-of-the-box in the new client. While the current REST API guidelines state that they should be absolute URLs, this was introduced after the initial release of the API (for more details, see the PR discussion that introduced the change).
LROs in the phone numbers API have status-monitors given by the operation-location header; however, the @azure/core-lro implementation expects it to be in the legacy azure-asyncoperation header. While the current version of the guidelines discourage the later approach, they indicate that client code should look for both. For more details, refer to the Azure REST API guidelines.

In order to solve both issues, custom pipeline policies were implemented to make the HTTP responses have the form expected by the Core V2 libraries. These policies are workarounds and should be cleaned up once the incompatibilities are addressed.
Are there test cases added in this PR? (If not, why?)
Yes, the test cases for the policies implemented as workarounds for compatibility issues.
Provide a list of related PRs (if any)

https://github.com/Azure/azure-sdk-for-js/pull/20337

Checklists

[x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

FYI, the following issue was created to track the LRO incompatibility: https://github.com/Azure/azure-sdk-for-js/issues/20647

@lucasrsant the phone number that is present in the recordings is actually the sanitized value. We even explicitly use it as a fake number in one of our tests: https://github.com/danielortega-msft/azure-sdk-for-js/blob/0b5233eec003cf06439612349d9023bf50fee51a/sdk/communication/communication-phone-numbers/test/public/get.spec.ts#L37.
You can check in the recorded client configuration that the actual phone numbers are replaced with it.
const replaceableVariables: { [k: string]: string } = {
  COMMUNICATION_LIVETEST_STATIC_CONNECTION_STRING: "endpoint=https://endpoint/;accesskey=banana",
  INCLUDE_PHONENUMBER_LIVE_TESTS: "false",
  SKIP_UPDATE_CAPABILITIES_LIVE_TESTS: "false",
  COMMUNICATION_ENDPOINT: "https://endpoint/",
  AZURE_CLIENT_ID: "SomeClientId",
  AZURE_CLIENT_SECRET: "azure_client_secret",
  AZURE_TENANT_ID: "SomeTenantId",
  AZURE_PHONE_NUMBER: "+14155550100",
  COMMUNICATION_SKIP_INT_PHONENUMBERS_TESTS: "false",
};

@jeremymeng @automagically @lucasrsant I updated the PR based on your comments, can you please do another review?

FYI, the following issue was created to track the LRO incompatibility: https://github.com/Azure/azure-sdk-for-js/issues/20647

The LRO bug has been fixed and I will make a release on Monday, 3/7.

API changes have been detected in @azure/communication-phone-numbers. You can review API changes here
API changes
- export interface PhoneNumbersClientOptions extends PipelineOptions { }
+ export interface PhoneNumbersClientOptions extends CommonClientOptions { }

Looks good to me! I only have some minor comments.

Thanks for the feedback @jeremymeng. I will merge this PR for now and, once the LRO fix is released, I will create a new one addressing your comments.


Added Ancestry and Classmates

Since it's my first commit, I think it's only fitting to get some outside review on it so everything works fine.
Ancestry lines are 165 - 178 I copied the notes from animal crossing as it applies to Ancestry as well.
Classmates lines are 767 - 772 easy removal with link to removal page included.

Hello @Anymou ,
This repo is not being maintained anymore, but we are trying to keep it alive on a detached fork here, would you kindly submit your PR there and close this one here? :)


EXTRACT_GTF_TRANSCRIPTS - change process priority

When I run this on a small bed file I get the following error:

[Task submitter] ERROR nextflow.processor.TaskProcessor - Error executing process > 'EXTRACT_GTF_TRANSCRIPTS'
Caused by:
Process requirement exceeds available CPUs -- req: 2; avail: 1
awk -F'       ' '$3 ~ /transcript|mRNA/' Gallus_gallus.GRCg6a.97.gtf > Gallus_gallus.GRCg6a.97_transcript_extract.gtf

It seems as if this is set to be "process_low". Could it be upped in priority or constrained to use a single thread?

Hmmm, I see that process_low does call for 2 cpus. I have no idea why it isn't able to get two cpus when I run it on create. I'll try run it with the create profile (nf-core/configs/create).


Support for incremental models

Describe the feature
Right now, datamocktool has no special handling for incremental models. While you can run a unit test on an incremental model, I am not sure what will happen (i.e. whether it will run on the initial step or the incremental step).
We should support running on incremental models - presumably against the incremental and non-incremental steps separately.
A good UX would be that the user can:

add 2 mock data sets for an incremental model: the initial and the incremental
add 2 expected outputs (the initial and the final)
datamocktool will automatically check that both steps succeed

Describe alternatives you've considered

You can probably test just the initial step right now, though I am not totally sure

Additional context
Who will this benefit?

Multiple people have mentioned wanting this, either in the context of datamocktool or more generally

Are you interested in contributing this feature?
I plan to, but would love if someone else would like to as well!

What we have done is use a variable named force_incremental.
In our models, instead of {% if is_incremental() %}, we have {% if is_incremental() or var('force_incremental') %}
We have set up our tests to either test the full refresh:
dbt test --select tag:test-refresh

Or run the incremental test:
dbt test --select tag:test-incremental --vars 'force_incremental: true'

@mkkuba genuis! I love it.
Are there any issues with this approach or does it work well for you?

@mkkuba genuis! I love it.
Are there any issues with this approach or does it work well for you?

@mjirv thank you!  This has worked well for us so far.  Our usage with dbt is still just beginning, however, so we only have a few models using it.

Hi! I tried out your approach @mkkuba but i cant get it to work. I get an error in the incremental code when i try to do a (select max(date) from {{this}})  which evaluates to a dataset which does not exist -- it is the same name that of my dataset but with a suffix of "_dbt_test__audit"
404 Not found: Dataset myproject:mydataset_dbt_test__audit was not found in location europe-north1
I like the approach of testing like this but the two tests "test-refresh" and "test-incremental" will not be related will they? I would need a test to test the incremental logic, not only compiling and running the code on an empty table: test input run 1 -> expected run 1 . Test input run 2 (adds to run 1, incremental test) -> expected run 2

Hi @pettersoderlund , thanks for trying out the approach.  If your incremental update makes use of {{ this }}, you will have to add {{ this }} in the input_mapping section of the unit test, and provide seed data for that.  For our incremental tests, we have 3 seed tables usually: table_input, table_existing, and table_expected.  {{ this }} would be mapped to table_existing.
To your question, the two tests are basically independent and the incremental test does not necessarily "build" on the results of the other.  I suppose it might be possible to write the tests in such a way that some of the data could be re-used, but in our case we keep them separate.

Thank you for feedback @mkkuba !
I am currently trying to implement a function in data mocktool. I might ask for some feedback @mjirv :) I had some discussions with a colleague though and wouldn't the most straightforward unit test for an incremental model be to specify the current state of the incremental table instead of specify two mock data sets for input? This would very much mimic the style @mkkuba is trying out but I would like not having to use the tagging system/variable system since it would complicate CI/CD etc.

@pettersoderlund yep, I think you're right about that. Let me know if there's anything you want me to take a look at!

What we have done is use a variable named force_incremental.
In our models, instead of {% if is_incremental() %}, we have {% if is_incremental() or var('force_incremental') %}
We have set up our tests to either test the full refresh:
dbt test --select tag:test-refresh

Or run the incremental test:
dbt test --select tag:test-incremental --vars 'force_incremental: true'

Great approach, @mkkuba !
Just a question here...How are you adding the variable in the yml file? You need that variable to be defined in order for the incremental test to work properly when running dbt build, for example.

hey @mjirv  :)
I have made an attempt in https://github.com/mjirv/dbt-datamocktool/pull/58
br Petter


Updating operations with SortedSet

Complete 31/35

Remove blocking operations from this PR (this is a topic for a separate PR)
Add native zset tests to CI script
Ignore (for a while) the fact that we cannot create comparison test for ZRANK WITHSCORE with Jedis 4.x
Make this PR "green"


add firefox workflow

closes #84

Problem restoring NPM cache stored as a root user for node user!

Hmm, probably need to add user id to the cache key?

Opened https://github.com/cypress-io/github-action/issues/104 to investigate how to set any non-root user

in addition, our actual GH example workflow is slightly different from README example - we use local action file and run it in the subfolder @Bkucera So it is not one to one with README example


Ring of Sponge deletes waterlogged blocks

While running around using the ring of sponge looking for sunken ships, I noticed that it destroys waterlogged blocks - not that big of an issue for most, but it's pretty noticeable and annoying when it destroys a chest and spams the area with a bunch of items.

Fixed in the latest version. Thanks for the report!
Forge:
1.15.2: https://www.curseforge.com/minecraft/mc-mods/rings-of-ascension/files/3023715
1.16.1: https://www.curseforge.com/minecraft/mc-mods/rings-of-ascension/files/3023716
Fabric:
1.15.2: https://www.curseforge.com/minecraft/mc-mods/fabric-rings-of-ascension/files/3023718
1.16.1: https://www.curseforge.com/minecraft/mc-mods/fabric-rings-of-ascension/files/3023724


ARROW-16813: [Go][Parquet] fix go parquet dictionary encoding writer property

@zeroshade advise if this is worth creating a jira issue for, for now labeled as "minor"

@mdepero Probably should make a JIRA issue for it, just to track it and be able to reference it in the next release changelog

@mdepero Probably should make a JIRA issue for it, just to track it and be able to reference it in the next release changelog

done, thanks again!


Image bugs

Closes #239
Many of the images on component pages were using a hack/workaround with markup for styling or a custom component for a grid layout. These were missed when copying over content to the new website.
Changelog
Changed
Went through page by page to try and catch all images that weren't styled correctly, or were displaying too large or too small.
Added docs around when to use image-grid and image-component wrapper divs.
Added image-grid css from old site back in.
Testing
Make sure nothing is broken.

merging this fix in. this should hopefully hit 95% of all of the broken/mis-sized component images. We should do another pass/check at some point though. cc @designertyler


[Task]: Stop unnecessary uncaught promise errors to sentry

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
We don't need all of these errors to be logged into sentry, they are mostly user errors.
https://sentry.io/organizations/appsmith/issues/2877416816/events/?environment=Production&project=1546547&statsPeriod=14d

@Rishabh-Rathod @satbir121 could we prioritize this and fix it in the current sprint? I'm guessing the fix should be simple. Our Sentry quotas are being breached and we're missing out on the actual platform errors.

Related: #16618

@arunvjn would #19515 fix this?

Yes @bharath31. Closing this ticket


Detect cluster version rather than requiring it as part of config

Having the right of a cluster is critical in order communicate. It is likely that this information is available as part of the cluster API and can be fetched via a simple GET request.
Figure out where this is defined in the API and perform an initial check against the cluster to determine its version before proceeding.

This information can be pulled from the /version route on the k8s manager (must be logged in).
λ aqui get -C -u <k8s-username> -p <k8s-password> https://<k8s-host>/version
{
  "major": "1",
  "minor": "8+",
  "gitVersion": "v1.8.7-gke.1",
  "gitCommit": "192ccad06d24af9828cbf42330e1d915cb586406",
  "gitTreeState": "clean",
  "buildDate": "2018-01-31T21:39:04Z",
  "goVersion": "go1.8.3b4",
  "compiler": "gc",
  "platform": "linux/amd64"
}

    connection : close
content-length : 269
  content-type : application/json
          date : Fri, 09 Feb 2018 20:21:30 GMT

GET https://<k8s-host>/version

This was implemented in version 1.13.0


fix: delete the old apps folder

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstrachan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pr-build
f4d60f4d276013a400bb5e6d93a306f9e70cac5c
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

/override pr-build

@jstrachan: Overrode contexts on behalf of jstrachan: pr-build

In response to this:

/override pr-build

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

/test gke

/test gke

/test gke

/retest

/test all

@jstrachan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pr-build
f4d60f4d276013a400bb5e6d93a306f9e70cac5c
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

/test gke

/test gke

@jstrachan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gke
f4d60f4d276013a400bb5e6d93a306f9e70cac5c
link
/test gke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test gke

/override pr-build

@jstrachan: Overrode contexts on behalf of jstrachan: pr-build

In response to this:

/override pr-build

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jstrachan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gke
f4d60f4d276013a400bb5e6d93a306f9e70cac5c
link
/test gke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test gke

/test gke


Http basic authentication.

Hi there,
I am looking forward to using your library for a project, but I need the ability to use basic http authentication from it, which seems to be missing, would you consider pushing a new change to the CamundaClient.cs that would allow passing an HttpClient object in a new constructor so RestService.For can be called using a string or the HttpClient object? I am attaching the patch.
patch.txt
Thank you for considering this and hoping this may make it to your library & the corresponding NuGet
package.
Best Regards.
Samuel Meza

Hi, sorry for late reponse, I didn't get any notification. Your change is now available in 1.0.3 version.

Hey Jan, this is so great, thank you very much!


missing .env.sample file when building.

hi @toluaina ,
I don't see .env.sample file when building,
What is special in that?
ERROR: Service 'pgsync' failed to build: ADD failed: stat /var/lib/docker/tmp/docker-builder050697468/.env.sample: no such file or directory

Resolved in the latest trunk as well


AppSourceCop gives breaking change error whil change is not breaking ( AS0036)

1. Describe the bug
When checking the new version of my app for appsource on breaking changes etc. (using Run-ALValidation, which uses AppSourceCop), the result says it will fail when submitting the app to app source because of a breaking chance while as far as I can see the change is not breaking.
Previous app (published on app source) has a whole table set to access = internal. So I assume this means all fields in this table are internal. In my new app version I removed the access = internal from the table, so the table is now public, but I set some fields in this table to access = internal.
Now validation code says these fields were not internal before, so it is breaking, but they were in a table that was completely internal, so the fields were never public.
Concluding: I feel like the AppSourceCop incorrectly says the change is breaking.
error AS0036: The property 'Access' for field 'FieldNameHere' in Table 'TableNameHere' has changed from value 'Public' to value 'Internal'. This is not allowed because it will break upgrade of existing installations and dependent extensions.
2. To Reproduce
Create a table with a property access = internal on it.
Add a few fields with no access property on them.
Publish app.
Remove access = internal property from table and add it to one of the fields in the table.
Publish app.
Compare the two results for app source validation using Run-ALValidation. This will give you the above error message.
In code:
table 50100 "Setup"
{
    Caption = 'Setup';
    Access = Internal;

    fields
    {
        field(1; "Code"; Code[1]) {}
        field(2; "Another Field"; Integer){ }
    }
}

table 50100 "Setup"
{
    Caption = 'Setup';

    fields
    {
        field(1; "Code"; Code[1])
        {
            Access = Internal;
        }

        field(2; "Another Field"; Integer)
        {
            Access = Internal;
        }
    }
}

3. Expected behavior
I expect the change not to be breaking.
4. Actual behavior
A clear and concise description of what happened accompanied by images, animations, or a link to a video showing the issue occurring
5. Versions:

AL Language: v7.1.453917
Visual Studio Code: v1.56
Business Central: BC18
List of Visual Studio Code extensions that you have installed:

What happens if you use 2 steps? First set the fields to internal, while the table is still internal and then update the app again and remove the internal for the table?

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 27686 and VS Code Extension Version 8.0.487599.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://freddysblog.com/2020/06/25/working-with-artifacts/


Dr. Ralf Ackermann

Twitter

One of the first to experiment with modifying iPhone hardware to support Bluetooth keyboard inputs. See: https://arstechnica.com/gadgets/2009/02/iphone-bluetooth-device-to-device-communications-achieved/

"dev for the iPhone internal bluetooth module" Flickr Set


Fix license designation

Not sure if I'm missing something or if this is the correct fix. The preceding clause lends some indication about the possible intent, but I definitely came close to not using this project when I saw Copyright (c) 2016 Availity, LLC under ## License as opposed to the expected MIT / BSD or similar

Deploy preview ready!
Built with commit 5bcfd5c98617fc2e445453fca5d96245d8f54b29
https://deploy-preview-12--react-block-ui.netlify.com

Coverage remained the same at 97.561% when pulling 5bcfd5c98617fc2e445453fca5d96245d8f54b29 on brianfeister:master into 315c5f6ff153a169f6c100c62c2668e048687315 on Availity:master.

I just write the code so I'll have to check with the powers that be in legal at Availity. Looking around, I think it needs to change to something like

Copyright (c) 2016-present Availity, LLC Released under the MIT license

Which indicates that people are allowed to use it and such under MIT, but just need to include Availity as the copyright owner (as MIT says "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.")
Even react's fancy new (well, new to react, not a new license) MIT license is the same way, they just don't state it in the readme, it's only in the actual license file. For some reason Availity likes to have it in both the license and the readme :shrug:


Create coupling tables with iMOD Python

Similar to metamod coupling, we need to create coupling tables with iMOD Python when Ribasim is added to the mix

also include the Ribasim2metaswap coupling table


Use the main branch instead of Hex version as default dependencies for nx and exla

The current CI pipe in the Axon repo is always failing with this error. The problem is the mismatch of the Nx version in Axon and Axon-ONNX when running the onnx check. In Axon it now uses the main branch as the default, so I changed the mix file to match it and I think this should solve the issue.
Does this sound correct? I think it is good that the Nx version matches in both libs, unless there's a reason not to. WDYT, @seanmor5 ?

Hey @Ian-GL thank you for this and your many other contributions, unfortunately there were a lot of other changes needed in AxonOnnx to make it pass the CI. I addressed these in #44

Nice to see those addressed, @seanmor5 !


Added timeout tests

This is to start a discussion about if we should do dispose timeouts at all. There are 2 places right now where we can time out existing connections.

The transport is still running after the application closes
The application is still running after the transport closes

In both cases, we're stuck in dispose async forever. We need to do something about the transport for sure since that's not user code running and as far as the user is concerned, their application code has ended and that should signal to the transport to close. This works well for everything but websockets as it waits forever today. I'll probably just implement that one first.
#361

Why is Travis taking so long?

@moozzyk OSX took longer for some reason. Nothing to do with this change.

@muratg @davidfowl - it's "normal" that OSX takes longer.


Provide alternatives to ext-crypto

This commit makes ext-crypto an optional dependency.

Fixed the typo. Did you find anything else?

Rest looked fine to me. Should we tag a new version, if so, what would it be?


Add stubs for FrankenPHP

Try to fix https://github.com/JetBrains/phpstorm-stubs/actions/runs/10575852193/job/29300999760 (failure introduced in #1665).
I don't manage to run tests locally.

@dunglas Don't worry about that failing test. Your changes looks correct so possibly it's an issue with test itself. I'll take a look at it. BTW adding extension name to tests/TestData/Providers/Stubs/PhpCoreStubsProvider.php isn't a correct way since this extension doesn't belong to core PHP extensions

@dunglas I apologize for the wrong comment. Actually your fix is absolutely correct and I just messed the failing test with another one. It seems today you know stubs tests better than me :) So I'll reopen PR and merge it

😅 No worries, done!


result.show() not displaying bounding boxes correctly

Bug description
I've discovered that using straighten_pages=True with images that are wider than they are tall and rotated by 90 or -90 degrees, appears to return incorrect bounding box coordinates. This is evidenced by result.show() not displaying the bounding boxes accurately.
Example input:

Output:

Code snippet to reproduce the bug
predictor = ocr_predictor(
  pretrained=True,
  assume_straight_pages=False,
  straighten_pages=True,
  detect_orientation=True,
  resolve_blocks=True
)

file_name = "/content/vecteezy_modern-professional-business-card-creative-and-simple_9010481 - Copy.jpg"
image = Image.open(file_name)
image = ImageOps.exif_transpose(image)

result = predictor([np.asarray(image)])
result.show()

Error traceback
No error
Environment
DocTR version: v0.9.0
TensorFlow version: 2.17.0
PyTorch version: 2.3.1+cu121 (torchvision 0.18.1+cu121)
OpenCV version: 4.10.0
OS: Ubuntu 22.04.3 LTS
Python version: 3.10.12
Is CUDA available (TensorFlow): Yes
Is CUDA available (PyTorch): Yes
CUDA runtime version: 12.2.140
GPU models and configuration: GPU 0: Tesla T4
Nvidia driver version: 535.104.05
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.9.6
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.9.6
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.9.6
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.9.6
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.9.6
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.9.6
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.9.6
Deep Learning backend
is_tf_available: False
is_torch_available: True

Hi @hienphan161 :wave:;
Thanks for reporting, i was able to reproduce the issue.
It happens in the special case if we need to expand the image while correcting the rotation.
https://github.com/mindee/doctr/blob/d7f453329f583798c0d2774f343e29ab24450a4d/doctr/models/predictor/base.py#L105
The image is expanded correctly but the loc_preds aren't.

Thanks for looking into the issue so quickly.
I’m also curious why we only expand the image if it’s wider than it is tall. If we have an image that’s taller than it is wide and need to rotate it 90 or -90 degrees, wouldn’t we still need to expand the width of the image before rotation to avoid losing any part of it?

@hienphan161 fix on the way :)

Hi. I have another question about the 'straighten page' option. If I take a picture of a card at a 45-degree angle, like the one below, and I use the 'straighten page' option, the picture will be straightened perfectly. But, if the card isn't in the middle of the picture, we might end up cutting off some parts of the card, right?
Origin Image:

Rotated Image:

With the latest version v0.9.0. yes, but the fix is already merged (also linked here: https://github.com/mindee/doctr/pull/1697)
So available on the main branch (v0.9.1) or with the next release :)


Exponential Notation is not allowed in search space

Describe the issue:
The Exponential Notation is not working in search space.
Similar to the previous issue, I just found the expression of Exponential Notation in search space would lead to an error after I updated to nni2.5.
{
"lr": {"_type": "uniform", "_value": [1e-6, 1e-3]}
}
But it works normally when I set the search space in decimals
{
"lr": {"_type": "uniform", "_value": [0.000001, 0.001]}
}
Considering the previous issue, I test it on pyyaml== 6.0 and 5.4.1. The Exponential Notation expression is not working in both cases.
Environment:

NNI version: 2.5
Training service (local|remote|pai|aml|etc): local
Client OS: ubuntu
Server OS (for remote mode only):
Python version: 3.8
PyTorch/TensorFlow version: PyTorch 1.9.1
Is conda/virtualenv/venv used?: conda
Is running in Docker?: no

Configuration:

Experiment config (remember to remove secrets!):
Search space:
{
"lr": {"_type": "uniform", "_value": [1e-6, 1e-3]}
}

Log message:

dispatcher.log:

[2022-01-06 15:00:37] INFO (nni.runtime.msg_dispatcher_base/MainThread) Dispatcher started
[2022-01-06 15:00:37] ERROR (nni.common.hpo_utils.validation/Thread-1) search space "lr" (uniform) must have float values : OrderedDict([('_type', 'uniform'), ('_value', ['1e-6', '1e-3'])])
[2022-01-06 15:00:37] INFO (hyperopt.tpe/Thread-1) tpe_transform took 0.000977 seconds
[2022-01-06 15:00:37] INFO (hyperopt.tpe/Thread-1) TPE using 0 trials
[2022-01-06 15:00:37] ERROR (nni.runtime.msg_dispatcher_base/Thread-1) must be real number, not str
Traceback (most recent call last):
File "/home/shuyu/anaconda3/envs/trajectory/lib/python3.8/site-packages/nni/runtime/msg_dispatcher_base.py", line 88, in command_queue_worker
self.process_command(command, data)
File "/home/shuyu/anaconda3/envs/trajectory/lib/python3.8/site-packages/nni/runtime/msg_dispatcher_base.py", line 147, in process_command
command_handlerscommand
File "/home/shuyu/anaconda3/envs/trajectory/lib/python3.8/site-packages/nni/runtime/msg_dispatcher.py", line 102, in handle_request_trial_jobs
params_list = self.tuner.generate_multiple_parameters(ids, st_callback=self.send_trial_callback)
File "/home/shuyu/anaconda3/envs/trajectory/lib/python3.8/site-packages/nni/tuner.py", line 132, in generate_multiple_parameters
res = self.generate_parameters(parameter_id, **kwargs)
File "/home/shuyu/anaconda3/envs/trajectory/lib/python3.8/site-packages/nni/algorithms/hpo/hyperopt_tuner.py", line 280, in generate_parameters
total_params = self.get_suggestion(random_search=False)
File "/home/shuyu/anaconda3/envs/trajectory/lib/python3.8/site-packages/nni/algorithms/hpo/hyperopt_tuner.py", line 457, in get_suggestion
new_trials = algorithm(new_ids, rval.domain, trials, random_state)
File "/home/shuyu/anaconda3/envs/trajectory/lib/python3.8/site-packages/hyperopt/tpe.py", line 870, in suggest
return rand.suggest(new_ids, domain, trials, seed)
File "/home/shuyu/anaconda3/envs/trajectory/lib/python3.8/site-packages/hyperopt/rand.py", line 20, in suggest
idxs, vals = pyll.rec_eval(
File "/home/shuyu/anaconda3/envs/trajectory/lib/python3.8/site-packages/hyperopt/pyll/base.py", line 913, in rec_eval
rval = scope._impls[node.name](*args, **kwargs)
File "/home/shuyu/anaconda3/envs/trajectory/lib/python3.8/site-packages/hyperopt/pyll/stochastic.py", line 38, in uniform
return rng.uniform(low, high, size=size)
File "mtrand.pyx", line 1106, in numpy.random.mtrand.RandomState.uniform
TypeError: must be real number, not str
[2022-01-06 15:00:41] INFO (nni.runtime.msg_dispatcher_base/MainThread) Dispatcher exiting...
[2022-01-06 15:00:43] INFO (nni.runtime.msg_dispatcher_base/MainThread) Dispatcher terminated
Thanks for your kindly reply!

Please check your pyyaml version: python3 -c 'import yaml ; print(yaml.__version__)'.
It should no less than 5.4.
Then try to load the search space file directly:
import yaml
space = yaml.safe_load(open('search_space.json'))
print(space)

Thanks and Looking forward to the new NNI.


Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.

$ composer update
...
Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.

PR welcome


Update Pages “index”

Automatically generated by Netlify CMS

👷 Deploy Preview for osamagatsbystarter processing.

Name
Link

🔨 Latest commit
0514e2fca4c1d59fd95ba1a2ff9e52c3015aeef2

🔍 Latest deploy log
https://app.netlify.com/sites/osamagatsbystarter/deploys/62d1a57b1bfca800080ad4f9


add filter column + ignore errors (fixes #2241)

fixes #2241

The admin UI has the filter column now

I don't get why lmsys/lmsys-chat-1m has a red cross for filter if https://datasets-server.huggingface.co/is-valid?dataset=lmsys/lmsys-chat-1m
{"preview":true,"viewer":true,"search":true,"filter":true}

I think it's due to some responses not having 4 fields in the response... and we don't hardcode the number of columns or the name of the fields, so... maybe we're filling another row.

Indeed, the second one: https://datasets-server.huggingface.co/is-valid?dataset=andersonbcdefg/synthetic_retrieval_tasks
has no filter field:
{"preview":true,"viewer":true,"search":true}

I don't want to spend too much time on the admin UI. @lhoestq feel free to look at it if you want (to hardcode the expected fields, maybe). I'll be looking at why some cache entries still miss the 'filter' field

ok !

It's a green cross now:

yes because https://datasets-server.huggingface.co/is-valid?dataset=andersonbcdefg/synthetic_retrieval_tasks is fixed and has 4 fields now, not 3

I mean for lmsys/lmsys-chat-1m ;)

I mean for lmsys/lmsys-chat-1m ;)

I mean this too, and that's the bug: the red cross in lmsys/lmsys-chat-1m was a consequence of andersonbcdefg/synthetic_retrieval_tasks only having 3 fields. Because we fill the cells in order, not necessarily 4 cells per rows, we can introduce a shift (1 cell on one row, then 3 cells in the following one, which is completely incoherent)...


Added noise texture icon

See issue https://github.com/godotengine/godot/issues/22704
By running the optimize script, several other icons were also optimized/reformatted and hashes changed.

Thanks!

Wait, does this actually make the icon show next to "New NoiseTexture"? I thought there was more to it than just adding an icon...

The Scons build system generates a header file from all SVG files in the editor/icons folder of godotengine. It's fully automatic.

Ah... alright. Thanks for clarifying.


GEODE-5197: Synchronized update cache service profiles

* new lock created for updating the region's cache service profile
* synchronized the addition / validation / removal of LuceneIndexCreationProfile in the data region.

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

This is to fix the previous commit message.
all checks and review completed on the previous PR


Modify cluster verification to bypass proxy and directly talk to cluster apiserver

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: Nginx proxy is flaky. Cluster verification script that talks to the apiserver via proxy intermittently fails and this can cause the cluster bringup script to take a long time to start or intermittently fail. Verifying directly against apiserver is a reliable way to ensure actual cluster is fine. The test will still use proxy as per architecture.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/approve

/lgtm


500 internal error

Expected behavior
Opening web address in my browser opens JAM
Actual behavior
Opening https://<IP_ADDRESS>:7501/jam displays "500 Internal Server Error / nginx"
Steps to reproduce the problem

JAM is installed and running on latest version of Raspiblitz node
run JAM from Raspiblitz menu, it displays the required web address (see above) to open
error 500 (See above for exact message) is given

Specifications

Version: JAM 0.1.0?
Platform: Raspiblitz 1.10.0
Browser: Firefox latest

Additional context

ping @openoms

Will try to reproduce.
Does the problem persist after the restart of the node?

Yes, it does unfortunately. I have little stuff activated on my node - only LND and 'run behind TOR', RPC Explorer, JM and JAM.

@rookey Could you run netstat -lntp | grep 8080 command in terminal and paste output here? It will show which process binds on port 8080.

@kristapsk this will be an issue on all raspiblitzes. 8080 is the LND REST port. Need to find a way to avoid the collusion.

@rookey can you try to set:
onion_serving_port = 8080

to something else like:
onion_serving_port = 8181

the easiest on the raspiblitz is to enter the joininbox menu -> JM -> CONFIG -> JMCONF, press down to find the line and change it

Thanks @openoms and @kristapsk for the amazingly fast response. Also thanks to @rookey for report :pray:
May the port issues all be resolved soon :  -)

Here's experimental branch of JM with support for automatic random free port selection (just specify onion_serving_port = auto in joinmarket.cfg), waiting for some feedback, then may open a PR. https://github.com/kristapsk/joinmarket-clientserver/tree/onion_serving_port-auto

Here's experimental branch of JM with support for automatic random free port selection (just specify onion_serving_port = auto in joinmarket.cfg), waiting for some feedback, then may open a PR. https://github.com/kristapsk/joinmarket-clientserver/tree/onion_serving_port-auto

Nice. Providing first feedback here directly: Often 0 is used for "random free port" - maybe this is applicable here too? But this is just a minor detail. Small but great improvement. However, I won't be able to test in the next Two Weeks™ :grimacing:

@rookey now that that the port is set restart the node or just the jm api:
sudo systemctl restart joinmarket-api

see if runs.
Logs are at:
sudo journalctl -fu joinmarket-api -n50

Closing due to inactivity. Please reopen if you think this is a mistake. :pray:


add guessingsheet object and display in gameScene

Render a hacky guessing sheet.

Show/hide by clicking the button in the bottom left.

Looks pretty good!


Datepicker automatically causing a postback in ASP.NET

I use Datepicker with an ASP.NET Web Forms site. Version 1.4.1 worked fine for me but as of 1.5.0 I am noticing the following bug:
If an ASP.NET TextBox with the setting "AutoPostBack=true" is used as the base element for a Datepicker, the datepicker code automatically triggers a page postback, which causes the page to reload, which causes the postback to be triggered, etc. In other words, the page keeps refreshing indefinitely.
It is not easy to make a sample snippet of ASP.NET code but here is how I am creating a textbox:
        <asp:TextBox runat="server" ID="rangeStartBox" CssClass="input-small datepicker" AutoPostBack="true"/>

Normally that should trigger a POST only when the textbox is actually changed, but starting in 1.5.0 a POST is triggered every time the Datepicker is initialized.

I have been having the same issue.    I'll update my comment if I'm able to find a better work-around.

Hi Guys,
I have the same problem in version 1.6.4.
To temporaly solve my problem, i commented the line 802 in bootstrap-datepicker.js:
from this:
this.fill();
this.element.change();
return this;

to this:
this.fill();
//this.element.change();
return this;

I did not see any negative impact on the page.

Hi,
I think the main issue in this case if that the update event is triggered at startup, but should not, am I right ?

You are correct.

This is fixed in the upcoming version 1.7.0.
See the commit here:  https://github.com/uxsolutions/bootstrap-datepicker/commit/110b12072cf424480a7fe0cd10ec917458a2e4a8

this.fill();
//this.element.change();
return this;
work fine


Pong Stretch Goal: Paddle AI for Single Player

Write an AI script that can follow the ball so you can play with only one player. Following the ball would be easy, but would make the AI impossible to beat by a player, so make the AI less than perfect.

See commit ea132f1908adc43dc7b53a96dbf631ddddbd460a


add all_lane_counts feature to enable non-power-of-2 lane counts <= 64

as discussed here: https://rust-lang.zulipchat.com/#narrow/stream/257879-project-portable-simd/topic/experimental.20feature.20to.20allow.20non-power-of-2.20vector.20lengths

I'm curious if this will dramatically slow down CI.  I remember some sort of issue in the past with testing too many lane counts (though maybe that's not an issue anymore?)

I'm curious if this will dramatically slow down CI. I remember some sort of issue in the past with testing too many lane counts (though maybe that's not an issue anymore?)

the only ci jobs with the feature enabled finished waay faster than a lot of other jobs, i'd expect no slowdown.


Now that coverex has updated to take my patch, let's stop using my fork. (Yay!)

Thanks @alfert!

Coverage remained the same at 88.276% when pulling dbe5245c39633838bd4452435aa8e9cd917f93dd on back-to-main-coverex into 6cb69dcedd2c1109c22ead01991acc7df976110b on master.


Roadmap update (Ledger support)

This is a small update to the roadmap, to add ledger support as an achievement.

Tested ok on the following platforms:
| Edge | IE 11 | Chrome | Firefox | Opera | Vivaldi
-- | -- | -- | -- | -- | -- | --
Windows 7 | - | OK | OK | OK | OK | OK
Windows 10 | OK | OK | OK | OK | OK | OK
Ubuntu 18.04 | - | - | OK | OK | OK | OK
CentOS 7 | - | - | - | OK | OK | OK

Ready for review @erciccione @mattcode55 @MaxXor
For already translated roadmaps, as usual @erciccione / @hrumag / @qwert95 & @zofiazinha, if you send me the localized sentence Ledger Hardware Wallets Support, i can add it to the PR.

The Italian translation could be: Supporto per hardware wallet Ledger.

As they have the actual nano S and an upcoming Blue, I'll say Wallets...

thanks @erciccione it's added.

Hi, here's the Polish translation:
Support dla portfeli Ledger Hardware.
Em qua, 13 de jun de 2018 10:44, erciccione<EMAIL_ADDRESS>escreveu:

@erciccione approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/monero-project/monero-site/pull/763#pullrequestreview-128382128,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjJiCYMGSTadug2xXLyan0o9_fWYCLp0ks5t8Rc5gaJpZM4UlBlS
.

Thanks @zofiazinha it's added.
Ready to merge is no more reviewer wants to say something.


Archive failed when installed by cocoapods

Hi
I get the following error when archive
[18:03:23]: ▸ ❌  error: unexpected duplicate task: CopyPlistFile /Users/ios/Library/Developer/Xcode/DerivedData/ETURecord-aihjngexeivjzlgyldazycpbvucf/Build/Intermediates.noindex/ArchiveIntermediates/TeacherDev/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/RxFeedback.framework/RxFeedback.plist /Users/ios/Projects/eturecorder-teacher/ios/Pods/RxFeedback/Sources/RxFeedback/RxFeedback.plist (in target 'RxFeedback')
[18:03:23]: ▸ ❌  error: unexpected duplicate task: CopyPlistFile /Users/ios/Library/Developer/Xcode/DerivedData/ETURecord-aihjngexeivjzlgyldazycpbvucf/Build/Intermediates.noindex/ArchiveIntermediates/TeacherDev/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/RxFeedback.framework/RxFeedback.plist /Users/ios/Projects/eturecorder-teacher/ios/Pods/RxFeedback/Sources/RxFeedback/RxFeedback.plist (in target 'RxFeedback')

This can be worked around by removing RxFeedback.plist from compile source. I think by changing s.source_files  = "Sources/**/* to s.source_files  = "Sources/**/*.swift in RxFeedback.podspec would fix this issue.

Hi @dvlprliu ,
thnx for reporting this, want to make a PR, or should I do it?

Hi @kzaher  thanks for response. I’ll make PR . :)
Sent with GitHawk


i18n(ja): Update imports.mdx

Description (required)

Update imports.mdx.

https://github.com/withastro/docs/pull/8818
https://github.com/withastro/docs/pull/8981
https://github.com/withastro/docs/pull/9711
https://github.com/withastro/docs/pull/9728

Related issues & labels (optional)

Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ja
guides/imports.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


SNOW-877653: Package create / lookup no longer displays output

Python version
No response
Platform
No response
What happened
Previously when running something like:
snow snowpark package create sktime

I would see the output of the pip job it's kicking off so I saw what packages were being installed. Were also some messages the CLI could send with updates. in 1.0.0 those seem to no longer show and I only get a few of the messages. I assume they may have been prints or some other write that is being suppressed by default? not sure
Console output
No response
How to reproduce
No response

Thanks jeff for reporting . @sfc-gh-turbaszek  Can we look into ? seems its a regression issue

Have you used --verbose flag?

--verbose and --debug didn't work for this command. Did try. Said flag not supported or something.
Do we have logging that is enabled by default without flag? Info logging? Some of the text output here we would want to appear by default. Either that or maybe for this flag we do --debug by default somehow

@jeffhollan currently --verbose is a flag on main level. So you need to do snow --verbose snowpark package create sktime. We are working on making this flag available on every level.

This does work:
snow --verbose snowpark package lookup pandas
2023-08-10 13:37:01 INFO Package pandas is available on the Snowflake anaconda channel.
However, that's very confusing, is there not a better way?

Fixed in #325


chore(vac/sc): add community-contracts-vault-token-airdrop milestone

This introduces a new milstone focussing on the airdrop functionality in Community vaults.

Rebased to resolve conflicts.
Merging ahead as this was already approved.


Add fallback ErrorString function

This change adds a fallback ErrorString function that is used when the nvmlErrorString function cannot be resolved. For example, when the library is not loaded.
Closes #82

Does this mimic what we did in go-nvlib?

Does this mimic what we did in go-nvlib?

The fallbackErrorString function is the same. The mechanics is different since I don't set a global function var but do a symbol lookup with every call. I thought that this was simpler since it didn't require state (the global) function pointer to be updated.
Note that when we originally implemented the logic in go-nvlib, we didn't have the Lookup function exposed at a package level here.

Seems reasonable. Given that we only end up calling this on error conditions, the extra bit of time to look up the symbol should be negligible.

@elezar @klueska
// nvml.ErrorString()
func ErrorString(r Return) string {
	if err := GetLibrary().Lookup("nvmlErrorString"); err == nil {
		return nvmlErrorString(r)
	}
	return fallbackErrorStringFunc(r)
}

I think that it should use err == nil.

Yes, you're right. Thanks for your PR. I think it would be better to invert the return statements.


API plans?

Any plans to add a simple API even on a server running from Python?
BaGRoS

Hi!
The goal of this repository is to create a very simple script so people can translate data for their research without losing any time writing their own script. However, I could consider writing a Gradio demo that runs a server if it can be useful for people. It should be very easy to reformat the code into a gradio server.
Gradio demos can be run as an interface and you can also make API calls to the server.  Is this the idea you had in mind?
https://www.gradio.app/demos

I would like to use this to translate a wordpress blog into multiple languages.
I have two ways to go.
The first is to write everything in Python, a longer solution.
The second is to use a translation plugin that supports custom API calls so that I can just configure it to a local translator.

Hey @BaGRoS, if you are okay with only calling the NLLB model, you can check out nllb-api. It performs ~1000x faster than Easy-Translate's Streamlit API.


release version 0.0.3

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   95.79%   95.79%
=======================================
  Files          12       12
  Lines         690      690
  Branches       48       48
=======================================
  Hits          661      661
  Misses         27       27
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a3621f...1191ede. Read the comment docs.


generate benchmarking data for MogonII

upon working stage-in/out:

generate 3-fold benchmarks for map_reads for

broadwell & skylake nodes
with and without stage-in (turn off stage-in by out commenting the relevant lines in the config)
scaling for 20, 40 (broadwell) and 64 threads (skylake)

generate benchmarks for the samtools nodes (architecture: irrelevant)

test scaling for 1 (baseline), 2, 4, 8, 16 threads (1-fold)
evtl. higher thread numbers
for highest scaling 3-fold benchmark

tabulate all data in README file for this project

ggfs. bei 64 threads `constraint: skylake’


Critical error in --release build: remove() with an exist key returns None

I say release build because it's correct in debug build.

Thanks for reporting the issue!
Would you please elaborate on the symptom a little bit further?
I need to know,

The type of the data structure. I assume that you're talking about HashMap, but need to be sure about it.
A possible reproducible scenario. E.g., parallel insert/remove? or single-threaded insert/remove?
The crate version that you use.
Criticality. The whole source code is not part of my job, and it's a kind of my free-time activity, so I might not be able to prioritize debugging of the issue unless it's very critical.

Hi @zitsen
There was a problem with SCC 0.8.x with the retain_* methods; https://github.com/wvwwvwwv/scalable-concurrent-containers/issues/77.
Could you try SCC 0.11.x instead?

Acknowledged the problem; looks like something's been changed in Rust 1.65.0. I'll try to fix it as soon as possible.

MaybeUninit handling has changed since Rust 1.65.0 - fixed it. After cleaning up the code, I'll upload SCC 0.11.3.

I admit that it was a touch bug. Anyway, fixed in SCC 0.11.3, @zitsen thanks for reporting this bug!


[SDK] Method to Obtain Latest Block Prior to a Block Event

Objective
Modify the SDK to fetch the latest block upon connection to the pocket node.
Origin Document
In order for gateways to send relays the SDK requires the latest block height. Currently the latest block height is only available once a new block has been created and the SDK receives it through the block client.
The effect is gateways cannot send relays until a new block has been created.
Goals

Enable the SDK to obtain block data upon connection, rather than solely waiting for a new block.

Deliverables

[ ] PR containing enhancement to fetch block data on initial connection to node.

General deliverables

[ ] Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
[ ] Testing: Add new tests (unit and/or E2E) to the test suite.
[ ] Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @ezeike
Co-Owners: @red-0ne

@ezeike Reminder to also update the GitHub Issue metadata. I updated it on this one to streamline things.

Needed for gateways when block times become large. Another ~ 4-6 hours of work before finishing.

@red-0ne Can we also add a metric (gauge) - something like blockchain_height, and we update this value whenever we get information about the new block on appgateserver and relayminer?
That way, we will know what block there is from our off-chain actors' Point of View. E.g. if our off-chain actor connects to the outdated full node or something - the operator could set an alert on that and troubleshoot the issue.

Super awesome idea @okdas. + 💯


not supporting ios9?

Hello, after doing a research about an ios plugin to choose files in ios this was the best option (only one) that i find, but i tested in my device (ios 9 iphone 5s) and it doesn't display nothing.
My question is if it supports ios 9 update due some of the code snippets that i check over ionic forums claim that it might be supported but wasn't been tested on a device

I've just tested on an iPod touch with iOS 9.1 and worked.
Did you follow the steps including the xcode part?

yes with the options selected in the image that is displayed in the
prerequisites
2015-10-26 13:52 GMT-06:00 Julio César<EMAIL_ADDRESS>
I've just tested on an iPod touch with iOS 9.1 and worked.
Did you follow the steps including the xcode part?
—
Reply to this email directly or view it on GitHub
https://github.com/jcesarmobile/FilePicker-Phonegap-iOS-Plugin/issues/2#issuecomment-151264057
.

--
"...los hombres fuertes se cuidan a si mismos; pero, los mas fuertes cuidan
a los demas..."

My bad, it turns out that the plugins wasn't loaded i just checked and all works like a charm
Enviado desde mi iPhone

El 26/10/2015, a las 13:52, Julio César<EMAIL_ADDRESS>escribió:
I've just tested on an iPod touch with iOS 9.1 and worked.
Did you follow the steps including the xcode part?
—
Reply to this email directly or view it on GitHub.


feat(scope-manager): Add no-op implementations of ScopeManager

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #100    +/-   ##
======================================
  Coverage     100%   100%
======================================
  Files          12     15     +3
  Lines         619    726   +107
  Branches       75     85    +10
======================================
+ Hits          619    726   +107

Impacted Files
Coverage Δ

src/NoopScopeManager.ts
100% <0%> (ø)

src/index.ts
100% <0%> (ø)

src/types.ts
100% <0%> (ø)

@rochdev @mayurkale22 I addressed the reviews

@vmarchaud Could you please rebase master and add back -p ../../ based on https://github.com/open-telemetry/opentelemetry-js/pull/101.

@mayurkale22 done


Why do we need Annotation files for unlabelled dataset?

In tools/train.py on line 175 you create a cfg_u for unlabelled files. This function uses X_U and all_anns.
Now all annotations contains the annotation files for both the labeled set and unlabeled set. Why do I need the annotations for the unlabelled set ? Isn't this against the idea of active learning that you dynamically create the labels for unlabelled set and use them to enhance your model ?

You can have a look at the loss function in lines 479 and 565 in mmdet/models/dense_head/MIAOD_head.py, which are belongs to the step re-weighting and minimizing/maximizing instance uncertainty. In these two steps, if y_loc_img is negative, the corresponding prediction of the model will be set to 0, which prevent it from participating in network training. And if y_loc_img is negative, it means that the corresponding data is from the unlabeled set X_U, referring to the lines 74 and 92 in epoch_based_runner.py. The normal y_loc_img, which is the annotation of the bounding box, should be positive in the original dataset. Therefore, we didn’t use any annotation of the unlabeled set X_U in model training.


Slightly unintuitive behavior around null and undefined JS values for 'clamp'

Having tried clamp out, it appears that undefined works as per my intuition, but null behaves differently.
// undefined min - works as expected
clamp(undefined, 4, 5)  // 4
clamp(undefined, 4, -5)  // -5

// undefined max - works as expected
clamp(1, undefined, 5)  // 5
clamp(1, undefined, -5)  // 1

// null min or max - strange behavior
clamp(null, 4, -5)  // null
clamp(1, null, 5)  // throws an error

Should this be changed? I'm happy to submit a pull request if the Ramda team think it's worth pursuing

My thought was probably coming from an English language perspective where 'undefined maximum' basically means the same thing as 'no maximum'.
I would certainly agree with you if Javascript were a typed language, as undefined would have no place in this particular polymorphic function. However, in Ramda, as in Javascript, there is a balance to be struck between pragmatism and idealism, and treating undefined-like values as the absence of a limit seems a good, pragmatic use-case.
Either way, null and undefined should work the same as each other.

However, in Ramda, as in Javascript, there is a balance to be struck between pragmatism and idealism

indeed. that seems to keep coming up around here :smile:

treating undefined-like values as the absence of a limit seems a good, pragmatic use-case.

I think I disagree; JS provides Infinity and -Infinity that are certainly a better fit there. I think overloading undefined and null to mean +/- Infinity would be muddying the water.

Well, undefined and null wouldn't just mean +/- Infinity. Since clamp is polymorphic over Ord, they would also mean 'A'/'z' and new Date(-8640000000000000)/new Date(8640000000000000).
I would find it a useful convenience to not have to know those values when I simply mean to state an unrestrained minimum or maximum.

Since clamp is polymorphic over Ord, they would also mean 'A'/'z' and new Date(-8640000000000000)/new Date(8640000000000000).

Good point. However, I don't think this implies that undefined/null should fill the gap. But I am curious to hear from others on this.

Since clamp is polymorphic over Ord, they would also mean 'A'/'z'

Where do 'A' and 'z' come from? Why should the range be from '\u0041' to '\u007A'? This strikes me as arbitrary. Why not the ASCII range or the Unicode range? Also, why single-character strings? 'zz' > 'z' = true, so why not 'zz' rather than 'z'?
I'm strongly opposed to changing the type from Ord a => a -> a -> a -> a to Ord a => Nullable a -> Nullable a -> a -> a. I don't want null or undefined to appear anywhere in my programs.

... and treating undefined-like values as the absence of a limit seems a good, pragmatic use-case.

I think that if we want that behavior, it would be more in keeping with the spirit of Ramda to define clampBelow and clampAbove than to make a parameter do double-duty.  I don't know if we'd accept a PR for those, but I promise it would receive a full hearing if you think such behavior is important enough to justify new functions.

Either way, null and undefined should work the same as each other.

When convenient, yes.  But I don't spend a lot of time worrying about the behavior of functions when people supply such inputs.

I'm closing this issue down due to a lack of support for my proposed solution. Thanks to all for taking the time to read and consider my suggestion.


New flake8 shows full module path for F401, Fixes #211

This change will split on . and take the last part, should still work for old flake8 users.

I'd love to see this one merged sooner rather than later 😁

@hvdklauw Sorry for not getting to this sooner, can you fix the lint issues CI is complaining about?

Yes, I'll have a look tomorrow!
On Mon, 25 Jul 2016, 20:47 Landon Abney<EMAIL_ADDRESS>wrote:

@hvdklauw https://github.com/hvdklauw Sorry for not getting to this
sooner, can you fix the lint issues CI is complaining about?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AtomLinter/linter-flake8/pull/218#issuecomment-235046880,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA2M-55t74X-dp74ZWnVvtoJvX-SxLHks5qZQTFgaJpZM4JHzIp
.

Awesome, sorry about the incredibly long delay, lost this in my notifications and only just saw it looking at the list of PRs again.

Fixed the error (not the warning, that was already there).

Looks like this got lost in the Travis-CI API downtime, trying to close/reopen to trigger the build.

Looks like the CI build passed and I just forgot to check back, sorry!

Odd, there are no conflicts merging this locally, not sure why GH thinks it can't me merged without attention...

Published in v1.13.3 🎉


Export barrel dependencies for conditional imports

Problem Statement
I have a Flutter Web application that needs to have Cookie in headers.
To enable sending Cookie in request headers we need to add the following code to our Dio object:
// conditional import to support BrowserHttpClientAdapter for Web.
import 'package:dio/dio.dart'
    if (dart.library.io) 'package:dio/native_imp.dart'
    if (dart.library.html) 'package:dio/browser_imp.dart';

_dio.options = BaseOptions(
      receiveTimeout: receiveTimeout,
      connectTimeout: connectTimeout,
      sendTimeout: sendTimeout,
      extra: kIsWeb ? {'withCredentials': true} : null, // allow sending Cookie in header
 );

When running or building for Web we have these compile errors:
lib/data/repository.dart:236:8: Error: Type 'Dio' not found.
    late Dio _dio;^^^^
lib/data/repository.dart:246:20: Error: The method 'BaseOptions' isn't defined for the class '_RepositoryImpl'.
 - '_RepositoryImpl' is from 'package:zireh/data/repository.dart' ('lib/data/repository.dart').
Try correcting the name to the name of an existing method, or defining a method named 'BaseOptions'.
    _dio.options = BaseOptions(^^^^

Failed to compile application.

What this pull request solves
This pull request is exporting dependencies for both native and web implementations of Dio.

Kinda related https://github.com/flutterchina/dio/issues/1362

For your example it should be sufficient to just import dio/dio.dart.
The platform handling is done automatically, unless you want to configure something on the DefaultHttpClientAdapter or BrowserClientAdapter but then you need to create platform specific files anyways.
I know that we can improve the adapter exports but I don't see how this PR fixes anything.

@kuhnroyal
I am using withCredentials feature which is only available at BrowserClientAdapter through browser_imp.dart
This pull request exports dependencies for both native and web implementations of Dio
Without this PR it is not possible to achieve this, except importing from /src/**.

Yea but withCredentials is just a value in the extras map. You don't need to set the BrowserClientAdapter, it is configured automatically.

Exporting BrowserClientAdapter for native probably also breaks native because you can't use web on dart:io platforms

So to be clear, this does the same thing:
import 'package:dio/dio.dart';

_dio.options = BaseOptions(
      receiveTimeout: receiveTimeout,
      connectTimeout: connectTimeout,
      sendTimeout: sendTimeout,
      extra: kIsWeb ? {'withCredentials': true} : null, // allow sending Cookie in header
 );

@kuhnroyal @ueman
The below code is not sufficient to use withCredentials, because we don't have access to BaseOptions and even Dio in our conditional import.

import 'package:dio/dio.dart';

_dio.options = BaseOptions(
receiveTimeout: receiveTimeout,
connectTimeout: connectTimeout,
sendTimeout: sendTimeout,
extra: kIsWeb ? {'withCredentials': true} : null, // allow sending Cookie in header
);

Here we say to import implementations for dio:

import 'package:dio/dio.dart'
if (dart.library.io) 'package:dio/native_imp.dart'
if (dart.library.html) 'package:dio/browser_imp.dart';

So, dependencies are not visible to the consumer package. because native_imp.dart and browser_imp.dart are not exporting anything!

@kuhnroyal

Yea but withCredentials is just a value in the extras map. You don't need to set the BrowserClientAdapter, it is configured automatically.

That's not the case for Dio, We only have access to this option here:
https://github.com/flutterchina/dio/blob/0e12e0198f5cd0bdd7992a1f0c529f203ba3385c/dio/lib/src/adapters/browser_adapter.dart#L34

Dio uses the BrowserClientAdapter on web because it does
import 'package:dio/dio.dart'
    if (dart.library.io) 'package:dio/native_imp.dart'
    if (dart.library.html) 'package:dio/browser_imp.dart';

under the hood itself to set the correct adapter based on the underlying platform.

Dio uses the BrowserClientAdapter on web because it does
import 'package:dio/dio.dart'
    if (dart.library.io) 'package:dio/native_imp.dart'
    if (dart.library.html) 'package:dio/browser_imp.dart';

under the hood itself to set the correct adapter based on the underlying platform.

Exactly, the BrowserClientAdapter is used by default on web. You don't need to manually configure it.

@kuhnroyal @ueman
This code this the trick:
import 'package:dio/dio.dart';
import 'package:dio/native_imp.dart' if (dart.library.html) 'package:dio/browser_imp.dart';

Thanks for your time.


Redesign the lesson content page

Things to redesign

Lesson parts nav

Large and unstyled

Elements spacing & letter spacing

Margin between elements and codeblocks

Fonts

The fonts are inconsistent. The should be `Inter` font

Challengebar font, size, colors, weight, and letters spacing

Table of content

It's too large

Text length

It's hard to read lengthy text

We can use the design mock we created in the past for this page. I think it would do the job.

Is anyone working in this issue? I want to work on this issue. Can @flacial explain a bit more about it?

Is anyone working in this issue? I want to work on this issue. Can @flacial explain a bit more about it?

No one is working on this issue. The main thing to do is to change the page's design to this mock design. Doing so will fix some UI issues that affect the student experience while studying (also polish the page).

@flacial It was my bad.....in understanding your issue. Unfortunately i am not a designer. I thought you have the design and You need me to code this up. Anyways.....I am new here, exploring open source issues. Nice talking to you.

I thought you have the design and You need me to code this up.

From what I understand, the designs are ready and someone needs to code them up. I think you misunderstood @flacial's words

After a bit of tweaking, thanks to @flacial for the help, here is the new lessons page redesign to match our new design, there are two variants, left TOC and right TOC, we can vote on which one we should implement.

Right TOC page:

Right TOC scroll:

Left TOC page:

Left TOC scroll:

If you guys have any feedback, i would love to hear it.

@SlyBouhafs I vote for Left TOC page. It looks perfect!

I like the idea of having a container around the content (especially headers):

With the current design, things look like they're floating around and nothing to contain them (not pretty):

With the current design, things look like they're floating around and nothing to contain them (not pretty):
I agree, that header is mostly for students/mentors, we need to adapt to that it works with the admin pages too, i will work on it too.


Familiar Ring is not storing familiars

Describe the bug
Right clicking a familiar with the ring simply removes the familiar. It isn't stored in the ring and cannot be released.
To Reproduce
Steps to reproduce the behavior:

Summon a Mummy
Right Click with a Familiar Ring

Expected behavior
The Familiar should be stored in the ring
System (please complete the following information):

Occultism Version: occultism-1.20.4-neoforge-1.114.1
OS: [e.g. Windows] Windows
Minecraft Version: 1.20.4
Modpack Link and Version, or list of mods:

That sounds like another victim of the capability rework - will check it out!

Next patch will introduce a potential fix - feedback will be appreciated as I am not sure if it works 100%.
Note that it cannot restore familiars captured before at he issue is related to saving - but familiars captured after should work

This issue seems to be related https://github.com/AllTheMods/ATM-10/issues/142

Just tested in 1.161.0 and these guys are working fine. Can put a deer in a familiar ring and get it back out again.


How to set the window size of images before loading

You can use CSS to do that.
img-loader {
  display: block;
  min-height: 300px; // set it to the height you think your image would be
}


Multiple issues using LVM-mode on a HW-based system

Testing has been mostly happening on emulated devices so far.
Here is some notes resulting from trial on HW-based system.
We may have multiple/cascading issues, so I write down some notes as a start.
Some of issues seem caused by underlying unclean state of namespaces.
Cluster has 3 nodes, one node has 4x128GB of Optane DIMMs organized
as two 256GB regions, interleave_set size is 2.
I tried reference deployment in LVM mode as per README steps.

too many small namespaces (addressed already in #275, will be resolved by #277).
volume provisioning fails, timing/race issue?

I0521 10:07:57.873824       1 glog.go:58] GRPC call: /csi.v1.Controller/CreateVolume
E0521 10:07:58.205146       1 glog.go:119] FlushDevice: /dev/ndbus0region0fsdax/4ed6ff15-7bb0-11e9-b208-a6ef1e106519 does not exist
E0521 10:07:58.205204       1 glog.go:119] GRPC error: rpc error: code = Internal desc = CreateVolume: failed to create volume: stat /dev/ndbus0region0fsdax/4ed6ff15-7bb0-11e9-b208-a6ef1e106519: no such file or directory

After namespace creation completes, corresponding device does not appear in time inside container, but is attempted to flush immediately?
Side question: does this also happen with code before moving to Clear-based container?
This seems to be cause to e2e tests failures/regression that are documented in #280.
Note that repeated e2e hits this in emulated storage as well. But seems to be even more systematic on HW.
Then I stopped driver, tried to get rid of LV state, and destroy all namespaces.
Some namespaces (belonging to same Region) were not deleted after ndctl destroy-namespace all --force.
That Region remains in some bad state, as next VG operations start to fail on that:
I0521 10:45:10.697547       1 glog.go:58] No Vgroup with name ndbus0region0fsdax, mark for creation
I0521 10:45:10.697569       1 glog.go:58] Executing: vgcreate --force ndbus0region0fsdax /dev/pmem0.10 /dev/pmem0.20 /dev/pmem0.2 /dev/pmem0.12 /dev/pmem0.22 /dev/pmem0.4 /dev/pmem0.6 /dev/pmem0.26 /dev/pmem0.8 /dev/pmem0.1 /dev/pmem0.3 /dev/pmem0.5 /dev/pmem0.7 /dev/pmem0.9
I0521 10:45:10.763600       1 glog.go:58] Output:   Can't open /dev/pmem0.2 exclusively.  Mounted filesystem?
  Can't open /dev/pmem0.4 exclusively.  Mounted filesystem?
  Can't open /dev/pmem0.10 exclusively.  Mounted filesystem?
  Can't open /dev/pmem0.12 exclusively.  Mounted filesystem?
  Can't open /dev/pmem0.20 exclusively.  Mounted filesystem?
  Can't open /dev/pmem0.22 exclusively.  Mounted filesystem?
E0521 10:45:10.763639       1 glog.go:119] Failed volumegroup creation: exit status 5

I also tried reference deployment in Direct mode, and that worked without issues.
(volumes where provisioned using healthy Region)

I rebooted the host and after that I was able to delete the remaining leftover namespaces.
Then I retried the LVM-mode reference deployment with namespacesize=128 i.e. with drastically reduced number of namespaces, results 2 namespaces per Region, total 4 namespaces.
The reference deployment worked without issues.
So it seems LVM-mode troubles can be avoided/reduced by avoiding big number of namespaces.
As next step, I will try with applied changes of #277

Tried with changes of #277, overall pretty good, deployment works in LVM mode, but there are 3 LVs created as one had "no such file" issue.
Should we perhaps introduce some retry/wait loop after LV creation to see if the device appears with slight delay, and fail only after that?

One more scenario discovered that creates driver confusion and leaves unclean state behind:
Reference deployment with 2 volumes with increased sizes (like 2x 160 GB). Note that one volume has eraseafter=true, means there will be shred -n 1 /dev/DEVICE upon deletion.

Create pvcs, then delete pvcs (this triggers flush and shred).
shred will run for multiple minutes.
Without waiting for shred to end, create 2x pvc again using same deployment file.

As we have locking around Create, creation calls stop at lock-acquire, which causes Kubernetes to repeat those, producing 20 (10 of each pvc) waiting calls.
After few minutes shred exits, all those calls run in order, and 2 pvc get to Bound state.

delete pvc. On deletion, there are few errors "Volume not created by this driver"
which is sign bookkeeping has been messed up about which volumes exist.
After deletion, there are 4 leftover LV volumes, another sign of same.

This case demonstrates driver does not withstand repeated Creation calls that get blocked by global  lock.
We should consider making locking more granular than device lock. That global lock was added (by me) in "just in case" style without thinking about scenarios where lock remains held for longer time. We used to test on small volumes only back then.
One volume erase does not need global lock, it could work with volume-level lock to avoid double erase of same volume. Also, we can consider changing create/delete locks to be volume-group level in LVM-case, instead of global. I will try those ideas.

The "long shred blocking" issue described in previous comment is worked around via mutex locking change added as separate commit under #277. With change of #277 applied, the scenario delete-big-pvc (starts long shred), recreate at once gets handled sensibly: there are creation failures "no region has size" while shred is ongoing. But k8s keeps retrying creation, and after shred finishes and size becomes available, the next pvc gets created and reaches Bound state. The state remains consistent.

In https://github.com/intel/pmem-CSI/issues/289#issuecomment-495524038 you described a certain scenario where the current code fails. Does it only fail on real hardware or also on emulated hardware?
Either way, we should have an automated test which triggers this problem. Otherwise we can't verify (or at least not easily) that your proposed fix really works and, more importantly, we can't be sure that it continues to work when we make future changes.

Does it only fail on real hardware or also on emulated hardware?

Emulated HW is smaller (32GB emulated vs. 160GB I used on HW), so failure rate/probability is likely lower, but it's fair to expect similar failures. I will try.

we should have an automated test which triggers this problem

This particular case is easy to program using sequence of kubectl commands, I can create this.
Should we store,collect such test cases in repository? From one side, it is appealing to add such case(s) to bigger test suite , like e2e. But OTOH, checking output and debugging using e2e output is not so pleasant task, so in that sense I would prefer single-shot approach with short output. Then again, an automated run and CI style needs a "run all" approach anyway with sensible results presenting method.

Doing automated tests with shell scripts would need a whole lot of scaffolding to run the tests and get their results included in the overall test run. I also don't believe that debugging a failing test that is written in Go and part of the E2E test suite is harder. I would argue the opposite:

you can single-step through the operations in a debugger
the output of all sidecars is already captured automatically
parallelism and complex flows are easier to implement than in shell code

I understand that there is some learning required before doing all this, but it should be worthwhile.


chore: remove list peers poll when opening channels in devimint

Core lightning's ConnectRequest appears to block until the peer has been connected to, so this poll shouldn't be necessary.

needs'a'rebase


How to write camera permissions for RN project?

I'm very new on React-Native and typescript I want to write a permission module for camera.My idea is like this begin ;
 async componentWillMount() { //
	// tslint:disable-next-line:prefer-const
	let options:Camera []*/

but don't forward anymore I referenced facebook rN permissions,yonah permissions
Sum how I will continue this module ?

You could refer to https://github.com/lwansbrough/react-native-camera.

@facebook-github-bot stack-overflow