Feat/credentialz 2

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

Pull Request Functional Test Report for #2600 / c3a192302ebeabb3d59dc4e68144d7c39f62e39d
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

Credentialz-2: SSH Password Login Disallowed

Cisco 8000E

Credentialz-2: SSH Password Login Disallowed

Cisco XRd

Credentialz-2: SSH Password Login Disallowed

Juniper cPTX

Credentialz-2: SSH Password Login Disallowed

Juniper ncPTX

Credentialz-2: SSH Password Login Disallowed

Nokia SR Linux

Credentialz-2: SSH Password Login Disallowed

Openconfig Lemming

Credentialz-2: SSH Password Login Disallowed

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

Credentialz-2: SSH Password Login Disallowed

Cisco 8808

Credentialz-2: SSH Password Login Disallowed

Juniper PTX10008

Credentialz-2: SSH Password Login Disallowed

Nokia 7250 IXR-10e

Credentialz-2: SSH Password Login Disallowed

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Closing this PR due to CLA issues. New PR opened 3355.


test/e2e/memcached_test.go: Add metrics test

Description of the change:
The test gets the metrics data via the proxy and checks the metrics
are present. It also checks the lint of metrics using the prometheus
linter.
Note: There is an invalid metric in upstream Kubernetes, which is fixed
in 1.14 release. We choose to ignore that one, until we migrate to 1.14
release.
Motivation for the change:
To ensure we always have working metrics in generated operators.

LGTM after addressing @estroz's comments

@AlexNPavel @estroz please take a look again, thanks!

Blocked until https://github.com/operator-framework/operator-sdk/pull/1157 gets merged.

@joelanford despite the tests failing, it's due to the finalizers PR not being merged yet, you can still look at the changes I made based on your comments, thanks! :)


Fix source sort not saving in TileMap editor

Fixup to #66713
The sorting was only remembered when set in TileSet editor.

Thanks!


Nuget packages from AWS CodeArtifact

Hi, is there any way to read from aws codeartifact ?

Hello, I am not familiar with AWS CodeArtifact but having a quick look at the docs it seems they do not support simple token based authentication. So then the answer is no, sorry. Even for Visual Studio they seem to require some plugin.


[feature] implement pysqa as additional backend

Switching between the local backend and the remote submission backend should be as easy as changing one variable. At the moment FileExecutor has a separate interface: https://github.com/pyiron-dev/remote-executor/blob/main/example.ipynb

This was done in https://github.com/pyiron/executorlib/pull/452


JavaScript CloudFare Bypass

Testing Evilginx2, which is supposed to help me bypass 2FA on web servers by using the MITM proxy phishing attack.
I run into problems with web servers using Cloud fare based JavaScript security to mitigate MITM proxy phishing techniques such Evilginx2.
This leaves my phishing domain hanging on cloud fare's DDOS protection page with the text below.
Checking your browser before accessing cloudflare-protected.site.
This process is automatic. Your browser will redirect to your requested content shortly.
Please allow up to 5 seconds…
DDoS protection by Cloudflare
Ray ID:
Anyway i can use this to bypass this issue?

You problem is probably domain.
if I understood correctly, it works this way:
User (fake domain) <-> your host (proxy) <-> real service (correct domain)
Cloudflare uses only domain name length to solve challenge. So just make domain with the same length.
Another method is that you could manually (or by my script) solve challenge and include cf cookie in request between your host and real service.

As no replies, I am closing this issue.


auth: feature flag for authentication

Up to this point, only the SPIRE installation & integration were put behind a feature flag.
This PR introduces an additional feature flag to disable the auth module. It is enabled by default.
Cilium config: auth-mesh-enabled
Helm value: authentication.enabled
Be aware, that this doesn't affect the auth policy enforcement.

/test

/test


this is transpiled incorrectly in a class instance field

Describe the bug
I have a library, which is transpiled (by Vite) to something like this
'use strict';

Object.defineProperties(exports, {
  __esModule: { value: true },
  [Symbol.toStringTag]: { value: 'Module' },
});

class MutationManager {
  runMutation = (variables) => {
    console.log('RUN MUTATION');
  };
  currentState = {
    runMutation: this.runMutation,
  };
}

exports.MutationManager = MutationManager;

Note the currentState property.
When this library is loaded into a Vite app, and built (ie npm run build), currentState is transformed incorrectly, where runMutation: this.runMutation becomes
__publicField(this, "currentState", {
  runMutation: commonjsGlobal.runMutation
});

The Vite.new link below reproduces this all in full (after running npm run build)
Reproduction
https://stackblitz.com/edit/vitejs-vite-f18nb2?file=vite.config.js&terminal=dev
System Info
Repro is the same on my machine vs the sandbox link above, but for whatever it's worth, mine is
System:
    OS: macOS 12.3
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 442.83 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.11.1 - /usr/local/Cellar/nvm/0.38.0/versions/node/v16.11.1/bin/node
    Yarn: 1.22.17 - /usr/local/Cellar/nvm/0.38.0/versions/node/v16.11.1/bin/yarn
    npm: 8.0.0 - /usr/local/Cellar/nvm/0.38.0/versions/node/v16.11.1/bin/npm
  Browsers:
    Chrome: 100.0.4896.75

Used Package Manager
npm
Logs
n/a

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Looks like an upstream issue in @rollup/plugin-commonjs: https://github.com/rollup/plugins/issues/922

Fixed in https://github.com/rollup/plugins/pull/1537


Error when validating XML with namespace prefixes

Hello!
I was attempting to validate the XML attached below, and got this error:
Traceback (most recent call last):
  File "/home/matteb/code/czi-to-ome-xslt/ome_types_test.py", line 49, in <module>
    from_xml(str(ome))
  File "/home/matteb/virtualenvs/czi-to-ome-xslt/lib/python3.9/site-packages/ome_types/__init__.py", line 42, in from_xml
    return OME(**d)  # type: ignore
TypeError: __init__() got an unexpected keyword argument 'ome:Experimenter'

From what I can gather, ome-types  expects to find Experimenter, but is stumbling on the namespace prefix in ome:Experimenter. However, using namespace prefixes like this is valid XML, and I have validated this file against the OME schema using several other methods (xmlschema, lxml, and xmlvalid).
Anything I'm missing here?
produced.ome.zip

thanks @MatteBailey and thank you for the example.
that's a bug...
you're correct, it's getting validated and parsed correctly by xmlschema, but we need to strip the global namespace in this case before passing that parsed dict to OME() ... will patch soon.

@MatteBailey, one more question regarding that specific XML example...
The ome:AcquisitionDate is 2019-06-27T18:39:25.8078869Z (7 digits of subseconds)... which xmlschema has an issue with:
            elif (kwargs['microsecond'] // 1 ** zeros) > 999999:
                msg = "Invalid value {} for microsecond"
>               raise OverflowError(msg.format(kwargs['microsecond']))
E               OverflowError: Invalid value 8078869 for microsecond

and from a little googling, I can't see many examples of the ISO 8601 standard showing more than 6 digits.
I can fix the namespace issue pretty easily... my preference would be to not special-case the digits (which means you'd have to catch it on your end).  that ok with you?

@tlambert03 Interestingly, I can't reproduce the error you're seeing with xmlschema. Below is what I'm running with xmlschema 1.4.1, let me know if there's something different I should try.
from xmlschema import XMLSchema

if __name__ == '__main__':
    ome_schema = XMLSchema('ome.xsd')
    ome_schema.validate('produced.ome.xml')

Regardless, I don't think we necessarily need support for seven digits of subseconds, I believe it's just what was included in the file from the microscope.

yeah, strange:  here's my full output if you're curious (I know it's peripheral to the main point here... sorry for the delay in the fix,  busy week)

In [1]: from xmlschema import XMLSchema, __version__

In [2]: print(__version__)
1.4.1

In [3]: schema = XMLSchema('https://www.openmicroscopy.org/Schemas/OME/2016-06/ome.xsd')

In [4]: schema.validate('/Users/talley/Downloads/produced.ome.xml')
---------------------------------------------------------------------------
OverflowError                             Traceback (most recent call last)
<ipython-input-4-a9d24c0e93bc> in <module>
----> 1 schema.validate('/Users/talley/Downloads/produced.ome.xml')

~/miniconda3/envs/ome/lib/python3.8/site-packages/xmlschema/validators/schema.py in validate(self, source, path, schema_path, use_defaults, namespaces)
   1410         :raises: :exc:`XMLSchemaValidationError` if XML *data* instance is not a valid.
   1411         """
-> 1412         for error in self.iter_errors(source, path, schema_path, use_defaults, namespaces):
   1413             raise error
   1414

~/miniconda3/envs/ome/lib/python3.8/site-packages/xmlschema/validators/schema.py in iter_errors(self, source, path, schema_path, use_defaults, namespaces)
   1509                     return
   1510
-> 1511             for result in xsd_element.iter_decode(elem, **kwargs):
   1512                 if isinstance(result, XMLSchemaValidationError):
   1513                     yield result

~/miniconda3/envs/ome/lib/python3.8/site-packages/xmlschema/validators/elements.py in iter_decode(self, elem, validation, **kwargs)
    620                     yield self.validation_error(validation, error, **kwargs)
    621
--> 622             for result in content_decoder.iter_decode(elem, validation, **kwargs):
    623                 if isinstance(result, XMLSchemaValidationError):
    624                     yield self.validation_error(validation, result, elem, **kwargs)

~/miniconda3/envs/ome/lib/python3.8/site-packages/xmlschema/validators/groups.py in iter_decode(self, elem, validation, **kwargs)
    755                 continue
    756
--> 757             for result in xsd_element.iter_decode(child, validation, **kwargs):
    758                 if isinstance(result, XMLSchemaValidationError):
    759                     yield result

~/miniconda3/envs/ome/lib/python3.8/site-packages/xmlschema/validators/elements.py in iter_decode(self, elem, validation, **kwargs)
    620                     yield self.validation_error(validation, error, **kwargs)
    621
--> 622             for result in content_decoder.iter_decode(elem, validation, **kwargs):
    623                 if isinstance(result, XMLSchemaValidationError):
    624                     yield self.validation_error(validation, result, elem, **kwargs)

~/miniconda3/envs/ome/lib/python3.8/site-packages/xmlschema/validators/groups.py in iter_decode(self, elem, validation, **kwargs)
    755                 continue
    756
--> 757             for result in xsd_element.iter_decode(child, validation, **kwargs):
    758                 if isinstance(result, XMLSchemaValidationError):
    759                     yield result

~/miniconda3/envs/ome/lib/python3.8/site-packages/xmlschema/validators/elements.py in iter_decode(self, elem, validation, **kwargs)
    679                             value = kwargs['filler'](self)
    680             else:
--> 681                 for result in content_decoder.iter_decode(text, validation, **kwargs):
    682                     if isinstance(result, XMLSchemaValidationError):
    683                         yield self.validation_error(validation, result, elem, **kwargs)

~/miniconda3/envs/ome/lib/python3.8/site-packages/xmlschema/validators/simple_types.py in iter_decode(self, obj, validation, **kwargs)
    595
    596         try:
--> 597             result = self.to_python(obj)
    598         except (ValueError, DecimalException) as err:
    599             yield XMLSchemaDecodeError(self, obj, self.to_python, reason=str(err))

~/miniconda3/envs/ome/lib/python3.8/site-packages/elementpath/datatypes/datetime.py in fromstring(cls, datetime_string, tzinfo)
    266             elif (kwargs['microsecond'] // 1 ** zeros) > 999999:
    267                 msg = "Invalid value {} for microsecond"
--> 268                 raise OverflowError(msg.format(kwargs['microsecond']))
    269             else:
    270                 kwargs['microsecond'] = int(match.groupdict()['microsecond'][:6])

OverflowError: Invalid value 8078869 for microsecond

should be fixed in 0.2.5, which is now released.  I added this xml to the tests as well (with a modified acquisition date, which we can tackle later if you want).  thanks for reporting!


Upgrading IncludingJSON to IncludingNetworkResponse

I couldn't come up with an acceptable way to compose the IncludingJSON and a new IncludingHTTP request struct (they're structs, so there's no inheritance, and the functionality doesn't come from a protocol I could extend, so it seemed like I would've had to create separate structs for JSON, HTTP, JSONAndHTTP, which seemed not good). So I beefed up the existing IncludingJSON struct to be a more encompassing IncludeNetworkResponse struct where I've dumped the json payload and the HTTP response properties. I had to make my own HTTPResponse class because I couldn't tell the existing Foundation HTTPURLResponse class to conform to Decodable.
Thoughts welcome, I know this is not what was expected from our conversation earlier this week.

P.S. I've pointed my Remind branch at this branch to test out, works as expected with just the send(...) label change.


aiger suprove engine crash

Steps to reproduce the issue
using the files from the enclosed zip
MCVE.zip
from the command line run "sby -f MCVE.sby"
Note: as configured this elementary example contains a purposeful fail condition (line 37 should contain an addition rather than AND operator).
Expected behavior
When the config file is reconfigured to use the "abc pdr" engine the following response is seen:
SBY 12:18:14 [MCVE] Removing direcory 'MCVE'.
SBY 12:18:14 [MCVE] Copy 'MCVE.sv' to 'MCVE/src/MCVE.sv'.
SBY 12:18:14 [MCVE] engine_0: abc pdr
SBY 12:18:14 [MCVE] nomem: starting process "cd MCVE/src; yosys -ql ../model/design_nomem.log ../model/design_nomem.ys"
SBY 12:18:14 [MCVE] nomem: finished (returncode=0)
SBY 12:18:14 [MCVE] aig: starting process "cd MCVE/model; yosys -ql design_aiger.log design_aiger.ys"
SBY 12:18:14 [MCVE] aig: finished (returncode=0)
SBY 12:18:14 [MCVE] engine_0: starting process "cd MCVE; yosys-abc -c 'read_aiger model/design_aiger.aig; fold; strash; pdr; write_cex -a engine_0/trace.aiw'"
SBY 12:18:14 [MCVE] engine_0: ABC command line: "read_aiger model/design_aiger.aig; fold; strash; pdr; write_cex -a engine_0/trace.aiw".
SBY 12:18:14 [MCVE] engine_0: Warning: The last 6 outputs are interpreted as constraints.
SBY 12:18:14 [MCVE] engine_0: Output 0 of miter "model/design_aiger" was asserted in frame 3.  Time =     0.01 sec
SBY 12:18:14 [MCVE] engine_0: finished (returncode=0)
SBY 12:18:14 [MCVE] engine_0: Status returned by engine: FAIL
SBY 12:18:14 [MCVE] base: starting process "cd MCVE/src; yosys -ql ../model/design.log ../model/design.ys"
SBY 12:18:14 [MCVE] base: finished (returncode=0)
SBY 12:18:14 [MCVE] smt2: starting process "cd MCVE/model; yosys -ql design_smt2.log design_smt2.ys"
SBY 12:18:14 [MCVE] smt2: finished (returncode=0)
SBY 12:18:14 [MCVE] engine_0: starting process "cd MCVE; yosys-smtbmc -s yices --noprogress --append 0 --dump-vcd engine_0/trace.vcd --dump-vlogtb engine_0/trace_tb.v --dump-smtc engine_0/trace.smtc --aig model/design_aiger.aim:engine_0/trace.aiw --aig-noheader model/design_smt2.smt2"
SBY 12:18:14 [MCVE] engine_0: ##   0:00:00  Solver: yices
SBY 12:18:14 [MCVE] engine_0: ##   0:00:00  Skipping step 0 (and assuming pass)..
SBY 12:18:14 [MCVE] engine_0: ##   0:00:00  Skipping step 1 (and assuming pass)..
SBY 12:18:14 [MCVE] engine_0: ##   0:00:00  Skipping step 2 (and assuming pass)..
SBY 12:18:14 [MCVE] engine_0: ##   0:00:00  Checking assertions in step 3..
SBY 12:18:14 [MCVE] engine_0: ##   0:00:00  BMC failed!
SBY 12:18:14 [MCVE] engine_0: ##   0:00:00  Assert failed in MCVE: MCVE.sv:37
SBY 12:18:14 [MCVE] engine_0: ##   0:00:00  Writing trace to VCD file: engine_0/trace.vcd
SBY 12:18:14 [MCVE] engine_0: ##   0:00:00  Writing trace to Verilog testbench: engine_0/trace_tb.v
SBY 12:18:14 [MCVE] engine_0: ##   0:00:00  Writing trace to constraints file: engine_0/trace.smtc
SBY 12:18:14 [MCVE] engine_0: ##   0:00:00  Status: FAILED (!)
SBY 12:18:14 [MCVE] engine_0: finished (returncode=1)
SBY 12:18:14 [MCVE] summary: Elapsed clock time [H:MM:SS (secs)]: 0:00:00 (0)
SBY 12:18:14 [MCVE] summary: Elapsed process time [H:MM:SS (secs)]: 0:00:00 (0)
SBY 12:18:14 [MCVE] summary: engine_0 (abc pdr) returned FAIL
SBY 12:18:14 [MCVE] summary: counterexample trace: MCVE/engine_0/trace.vcd
SBY 12:18:14 [MCVE] DONE (FAIL, rc=2)

Actual behavior
what is seen with the suprove engine:
SBY 12:13:58 [MCVE] Removing direcory 'MCVE'.
SBY 12:13:58 [MCVE] Copy 'MCVE.sv' to 'MCVE/src/MCVE.sv'.
SBY 12:13:58 [MCVE] engine_0: aiger suprove
SBY 12:13:58 [MCVE] nomem: starting process "cd MCVE/src; yosys -ql ../model/design_nomem.log ../model/design_nomem.ys"
SBY 12:13:58 [MCVE] nomem: finished (returncode=0)
SBY 12:13:58 [MCVE] aig: starting process "cd MCVE/model; yosys -ql design_aiger.log design_aiger.ys"
SBY 12:13:58 [MCVE] aig: finished (returncode=0)
SBY 12:13:58 [MCVE] engine_0: starting process "cd MCVE; suprove model/design_aiger.aig"
SBY 12:13:58 [MCVE] engine_0: finished (returncode=127)
Traceback (most recent call last):
  File "/usr/local/bin/sby", line 388, in <module>
    retcode |= run_job(t)
  File "/usr/local/bin/sby", line 346, in run_job
    job.run(setupmode)
  File "/usr/local/bin/../share/yosys/python3/sby_core.py", line 634, in run
    self.taskloop()
  File "/usr/local/bin/../share/yosys/python3/sby_core.py", line 251, in taskloop
    task.poll()
  File "/usr/local/bin/../share/yosys/python3/sby_core.py", line 170, in poll
    self.handle_exit(self.p.returncode)
  File "/usr/local/bin/../share/yosys/python3/sby_core.py", line 108, in handle_exit
    self.exit_callback(retcode)
  File "/usr/local/bin/../share/yosys/python3/sby_engine_aiger.py", line 81, in exit_callback
    assert retcode == 0
AssertionError

Do you know which version of suprove you are using? It seems to work with the one I have installed:
SBY 14:39:49 [MCVE] Removing direcory 'MCVE'.
SBY 14:39:49 [MCVE] Copy 'MCVE.sv' to 'MCVE/src/MCVE.sv'.
SBY 14:39:49 [MCVE] engine_0: aiger suprove
SBY 14:39:49 [MCVE] nomem: starting process "cd MCVE/src; yosys -ql ../model/design_nomem.log ../model/design_nomem.ys"
SBY 14:39:50 [MCVE] nomem: finished (returncode=0)
SBY 14:39:50 [MCVE] aig: starting process "cd MCVE/model; yosys -ql design_aiger.log design_aiger.ys"
SBY 14:39:50 [MCVE] aig: finished (returncode=0)
SBY 14:39:50 [MCVE] engine_0: starting process "cd MCVE; suprove model/design_aiger.aig"
SBY 14:39:50 [MCVE] engine_0: finished (returncode=0)
SBY 14:39:50 [MCVE] engine_0: Status returned by engine: FAIL
SBY 14:39:50 [MCVE] base: starting process "cd MCVE/src; yosys -ql ../model/design.log ../model/design.ys"
SBY 14:39:50 [MCVE] base: finished (returncode=0)
SBY 14:39:50 [MCVE] smt2: starting process "cd MCVE/model; yosys -ql design_smt2.log design_smt2.ys"
SBY 14:39:50 [MCVE] smt2: finished (returncode=0)
SBY 14:39:50 [MCVE] engine_0: starting process "cd MCVE; yosys-smtbmc -s yices --noprogress --append 0 --dump-vcd engine_0/trace.vcd --dump-vlogtb engine_0/trace_tb.v --dump-smtc engine_0/trace.smtc --aig model/design_aiger.aim:engine_0/trace.aiw model/design_smt2.smt2"
SBY 14:39:50 [MCVE] engine_0: ##   0:00:00  Solver: yices
SBY 14:39:50 [MCVE] engine_0: ##   0:00:00  Skipping step 0 (and assuming pass)..
SBY 14:39:50 [MCVE] engine_0: ##   0:00:00  Skipping step 1 (and assuming pass)..
SBY 14:39:50 [MCVE] engine_0: ##   0:00:00  Skipping step 2 (and assuming pass)..
SBY 14:39:50 [MCVE] engine_0: ##   0:00:00  Checking assertions in step 3..
SBY 14:39:50 [MCVE] engine_0: ##   0:00:00  BMC failed!
SBY 14:39:50 [MCVE] engine_0: ##   0:00:00  Assert failed in MCVE: MCVE.sv:37
SBY 14:39:50 [MCVE] engine_0: ##   0:00:00  Writing trace to VCD file: engine_0/trace.vcd
SBY 14:39:50 [MCVE] engine_0: ##   0:00:00  Writing trace to Verilog testbench: engine_0/trace_tb.v
SBY 14:39:50 [MCVE] engine_0: ##   0:00:00  Writing trace to constraints file: engine_0/trace.smtc
SBY 14:39:50 [MCVE] engine_0: ##   0:00:00  Status: FAILED (!)
SBY 14:39:50 [MCVE] engine_0: finished (returncode=1)
SBY 14:39:50 [MCVE] summary: Elapsed clock time [H:MM:SS (secs)]: 0:00:00 (0)
SBY 14:39:50 [MCVE] summary: Elapsed process time [H:MM:SS (secs)]: 0:00:00 (0)
SBY 14:39:50 [MCVE] summary: engine_0 (aiger suprove) returned FAIL
SBY 14:39:50 [MCVE] summary: counterexample trace: MCVE/engine_0/trace.vcd
SBY 14:39:50 [MCVE] DONE (FAIL, rc=2)

And looking closer at the output you posted:

SBY 12:13:58 [MCVE] engine_0: finished (returncode=127)

Return code 127 usually means command not found. Are you sure you have suprove installed properly? Can you run suprove on aiger files on the command line?

ok, so I can run super_prove from the command line but not suprove
incidentally I get a similar but different result when trying to use avy:
SBY 14:21:21 [assert_seq_proof] engine_0: starting process "cd assert_seq_proof; avy --cex - model/design_aiger.aig"
SBY 14:21:21 [assert_seq_proof] engine_0: finished (returncode=139)

running on the command line I get:
[sprigg@krypton assert_seq_proof]$ avy --cex - model/design_aiger.aig
Warning: The last 7 outputs are interpreted as constraints.
Segmentation fault

ok, so I can run super_prove from the command line but not suprove

Did you create a suprove wrapper, as described in https://symbiyosys.readthedocs.io/en/latest/quickstart.html#super-prove?
This is what I see when running avy:
SBY 16:06:01 [MCVE] Removing direcory 'MCVE'.
SBY 16:06:01 [MCVE] Copy 'MCVE.sv' to 'MCVE/src/MCVE.sv'.
SBY 16:06:01 [MCVE] engine_0: aiger avy
SBY 16:06:01 [MCVE] nomem: starting process "cd MCVE/src; yosys -ql ../model/design_nomem.log ../model/design_nomem.ys"
SBY 16:06:01 [MCVE] nomem: finished (returncode=0)
SBY 16:06:01 [MCVE] aig: starting process "cd MCVE/model; yosys -ql design_aiger.log design_aiger.ys"
SBY 16:06:01 [MCVE] aig: finished (returncode=0)
SBY 16:06:01 [MCVE] engine_0: starting process "cd MCVE; avy --cex - model/design_aiger.aig"
SBY 16:06:01 [MCVE] engine_0: finished (returncode=1)
SBY 16:06:01 [MCVE] engine_0: Status returned by engine: FAIL
SBY 16:06:01 [MCVE] base: starting process "cd MCVE/src; yosys -ql ../model/design.log ../model/design.ys"
SBY 16:06:01 [MCVE] base: finished (returncode=0)
SBY 16:06:01 [MCVE] smt2: starting process "cd MCVE/model; yosys -ql design_smt2.log design_smt2.ys"
SBY 16:06:01 [MCVE] smt2: finished (returncode=0)
SBY 16:06:01 [MCVE] engine_0: starting process "cd MCVE; yosys-smtbmc -s yices --noprogress --append 0 --dump-vcd engine_0/trace.vcd --dump-vlogtb engine_0/trace_tb.v --dump-smtc engine_0/trace.smtc --aig model/design_aiger.aim:engine_0/trace.aiw model/design_smt2.smt2"
SBY 16:06:01 [MCVE] engine_0: ##   0:00:00  Solver: yices
SBY 16:06:01 [MCVE] engine_0: ##   0:00:00  Skipping step 0 (and assuming pass)..
SBY 16:06:01 [MCVE] engine_0: ##   0:00:00  Checking assertions in step 1..
SBY 16:06:01 [MCVE] engine_0: ##   0:00:00  Status: PASSED
SBY 16:06:01 [MCVE] engine_0: finished (returncode=0)
Traceback (most recent call last):
  File "/usr/local/bin/sby", line 388, in <module>
    retcode |= run_job(t)
  File "/usr/local/bin/sby", line 346, in run_job
    job.run(setupmode)
  File "/usr/local/bin/../share/yosys/python3/sby_core.py", line 634, in run
    self.taskloop()
  File "/usr/local/bin/../share/yosys/python3/sby_core.py", line 251, in taskloop
    task.poll()
  File "/usr/local/bin/../share/yosys/python3/sby_core.py", line 170, in poll
    self.handle_exit(self.p.returncode)
  File "/usr/local/bin/../share/yosys/python3/sby_core.py", line 108, in handle_exit
    self.exit_callback(retcode)
  File "/usr/local/bin/../share/yosys/python3/sby_engine_aiger.py", line 129, in exit_callback2
    assert task2_status == "FAIL"
AssertionError

Meaning avy produced a model but then yosys-smtbmc using yices was not able to verify that model. Strange.
$ avy --cex - MCVE/model/design_aiger.aig
Warning: The last 6 outputs are interpreted as constraints.
1
b0
00000000000
0000000000000000
0000000000000000
.

That looks like an issue in avy, For one, that witness is too short. Here is the witness from abc pdr:
cat MCVE/engine_0/trace.aiw
000000000000
0000000000000000
1010000000001000
1000000000001000
1010000000001001# DONE

And here is the witness from suprove:
$ cat MCVE/engine_0/trace.aiw
1
b0
00000000000
0000000000000001
1110000000000000
1100000000000000
1110000000000000
.

Both 4 cycles deep, both not completely zeros. I guess there's a bug in avy here. However, that does not seem to be the issue you are fighting. That one I can't reproduce it seems.

ok thanks, so a type-o in our suprove wrapper, now sorted.
The avy, I just get a segmentation fault when run manually:
[sprigg@krypton symbyosys]$ cd assert_seq_proof; avy --cex - model/design_aiger.aig
Warning: The last 7 outputs are interpreted as constraints.
Segmentation fault

The avy, I just get a segmentation fault when run manually:

Funny. I'm using git master of avy, built earlier today.
However, I now ran it in valgrind and there are errors. So it really looks like there is an avy issue here. I'll investigate further..


swap shas for images to fix update issues

Quick fix to change the sha's for the image versions to the tags

Apologies for spacing issue, should be all good now :+1:


Export classification to csv

Resolves #111
Dendrogram (left) vs. export result (right)

When I load a bunch of datasets into this plugin, I feel a bit uncomfortable that the plugin might write into the projects without me clicking a save button, potentially destroying my data.

Good point. This is not actually part of this PR. Also it was explicitly requested as such by a user. The setting is false by default. I added a note about this to the respective GUI param to make this behavior more transparent to the user.

The save PNG, SVG and CSV is hidden so well in the popup menu. It's hard to remember it's there. I would wish for a more prominently placed button.

Also a good point. I added a ⋮ button to show the export options in the dendrogram view:


Documentations and tutorials

We need a website like http://cycle.js.org/ with more comprehensive API docs like https://facebook.github.io/immutable-js/docs/
Maybe TypeDoc would help.

Do you need this to have a databased version or could we implement it without it for now? I could get started on a basic scratch page.

Or Jekyll can be used to manage it.

I was planning on a JavaScript solution, but Jekyll is perfectly fine, too.

Ok, which JS solution were you thinking of using? An SPA solution?

A static page generator by using Webpack. I haven't make it working smoothly, so let's start with Jekyll.

Ok I can get started this weekend. What about the logo?

I'll ask someone to make the logo :)

Sorry, I've been terribly busy, how about this weekend? I want to use Raneto.

Me too (lol). I was still busy last weekend, but we can do something about the docs this weekend :)

A tutorial is available at https://egghead.io/courses/cycle-js-fundamentals
FWIW,


[Bug] problems of RssMapOutputCollector

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug
The connection between the client and shufflerserver is not closed. As a result, the maptask container does not exit.
1.map container does not exit when reduce is running
2.When cluster resources are used up and some maps are not allocated, am waits for a one-minute timeout, kills the completed map container, and allocates resources to other maps
error log like:
2023-03-11 02:42:16,826 INFO [Ping Checker] org.apache.hadoop.yarn.util.AbstractLivelinessMonitor: Expired:attempt_1676901654399_1531374_m_000190_0 Timed out after 60 secs
In the close method of the RssMapOutputCollector, closing the shuffle client solves this problem
Affects Version(s)
master
Uniffle Server Log Output
No response
Uniffle Engine Log Output
No response
Uniffle Server Configurations
No response
Uniffle Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Is it a occassional case?

An inevitable case

Could you raise a pr to fix this issue?

closed by #882


Fix screen size check in InitPlatform()

Fixes a comparison error between two undefined variables (width, height) and also the definition of CORE.Window.currentFbo.height

@Bigfoot71 thanks for testing and the fix!


FormAction: If validation fails then stories flow till last action

Rasa Core version: 0.9.7
Python version: 3.6.5
Operating system (windows, osx, ...): Windows 10
Issue: In validate method of FormField class of forms.py I have added a custom logic for checking if the value is 'India' or 'Bangladesh'. When bot promp for country name, I answer 'indi' which is not valid. My expectation was bot will again prompt for country name. bot does so but problem is bot flows till story end and also print 'None' which come from utter_show_result. Why this happens and how to solve this?
Thanks.
Content of domain file (if used & relevant):
slots:
  corporate_rate_keywords:
    type: text
  corpcountry:
    type: text
  requested_slot:
    type: unfeaturized
  result:
    type: unfeaturized
entities:
- country
- dummy
- corporate_rate_keywords
intents:
- corporate_rate_bot
templates:
  utter_ask_corpcountry:
    - "Ok, for which country?"
  utter_show_result:
    - "{result}"

actions:
- utter_show_result
- bot.ActionSlotReset
- bot.ActionRestarted
- bot.corporteRateTaxForm

Stories:
## Generated Story<PHONE_NUMBER>345560092
* corporate_rate_bot
    - corporate_rate_tax_form
    - slot{"requested_slot": "corpcountry"}
* corporate_rate_bot{"country": "china"}
    - corporate_rate_tax_form
    - slot{"corpcountry": "china"}
    - slot{"result": {"fulfillmentText": "Unable to process your query.", "fulfillmentMessages": "", "source": "", "payload": "", "outputContexts": "", "followupEventInput": ""}}
    - utter_show_result
    - export

## Generated Story -4230161521642477024
* corporate_rate_bot{"country": "china"}
    - corporate_rate_tax_form
    - slot{"corpcountry": "china"}
    - slot{"result": {"fulfillmentText": "Unable to process your query.", "fulfillmentMessages": "", "source": "", "payload": "", "outputContexts": "", "followupEventInput": ""}}
    - utter_show_result
    - export

Chatito nlu:
%[corporate_rate_bot]
    @[corporate_rate_keywords]
    Give me @[corporate_rate_keywords]
    @[corporate_rate_keywords] of a country
    I want to know @[corporate_rate_keywords] of a country
    @[corporate_rate_keywords] of a @[country]
    I want to know @[corporate_rate_keywords] of a @[country]
    @[country]
@[corporate_rate_keywords]
    corporate rate
    corporate rates
    corporate tax
    corporate tax rate
    corporate tax rates
@[country]
    Bangladesh
    India
    China
    Mexico
    Argentina
    Brazil
    Russia

nlu_model_config:
language: "en"
pipeline:
- name: "nlp_spacy"
  case_sensitive: false
- name: "tokenizer_spacy"
- name: "intent_entity_featurizer_regex"
- name: "intent_featurizer_spacy"
- name: "ner_crf"
- name: "ner_synonyms"
- name: "intent_classifier_sklearn"

Debugging result:

do you have a story to teach your bot how to behave if this slot isn't successfully set?

@amn41 I've tried for a story where validation failed for one time and it was not working. Now checked for three times and seeming works. Have to check for more bots. Thanks.


List ConvertAll not supported.

The normal behavior is:
List<string> list = new List<string>{"1", "2", "3"};
List<int> converted = list.ConvertAll(int.Parse);

I have to now do:
List<string> list = new List<string>{"1", "2", "3"};
List<int> converted = new List<int>();
list.ForEach(v => converted.Add(int.Parse(v)));

instead.
I have a defenition for it:
public static List<T2> ConvertAll<T,T2> (this IEnumerable<T> value, Func<T, T2> function)
        {
            List<T2> result = new List<T2>();
            foreach (T item in value)
            {
                result.Add(function(item));
            }
            return result;
        }

For references: .ConvertAll() [MSDN article[(https://msdn.microsoft.com/en-us/library/73fe8cwf(v=vs.110).aspx).
@michaelcheers, just for your information - we are open to pull requests. More information in CONTRIBUTING.md.

Your particular test case works fine
http://live.bridge.net/#79e83d05bf2733f4435b
But there are some limitations
See https://github.com/bridgedotnet/Bridge/issues/743
We are going to fix #743 in 1.12

Pull Request


Null reference exception when using NavigationManager with HeadOutlet

I get:

System.NullReferenceException: 'Object reference not set to an instance of an object.'

on this line of code:
<component type="typeof(HeadOutlet)" render-mode="ServerPrerendered" />
This happens when I try and redirect from one of my components:
@using System.Web;
@inject NavigationManager Navigation

@code {
    [Parameter]
    public string ReturnUrl { get; set; } = null!;

    protected override async Task OnInitializedAsync()
    {
        var loginEndpoint = "Login?redirectUri=" + HttpUtility.UrlEncode(ReturnUrl);
        Navigation.NavigateTo(loginEndpoint, forceLoad: true);
        await base.OnInitializedAsync();
    }
}

A little luck, but still not sure what to do. I found this on another thread: https://github.com/dotnet/aspnetcore/issues/33868#issuecomment-925968851
I notice both the _Host and the Index have @page "/" at the top of them.
Any ideas?

Repro: https://github.com/VictorioBerra/MudBlazorHeadOutletIssue

Hi.
I believe the issue is not related to MudBlazor or the Templates, but please correct me if I'm mistaken. The problem seems to be caused by a 17 line in the App.razor: <MudText Typo="Typo.h3" GutterBottom="true" Style="@($"color:{Theme.Palette.Error};")">Access Denied</MudText>
By commenting out this line, everything seems to work fine. However, even if you replace it with a different non-native MudBlazor component, such as <InputFile></InputFile>, the error still occurs. I'm unable to provide a clear explanation for this behavior, so it would be advisable to ask in the aspnetcore repository.

Thank you.


ServiceX dataset should be the title

A short version of the dataset name would make for a much nicer display

All the backend stuff now has this - next step is to figure out how to integrate it into the running notebook in a sensible way.


Enable KeyVault-Keys samples with custom config dir for az cli

Follow-up from https://github.com/Azure/azure-sdk-for-cpp/pull/5800 with a manual AZURE_CONFIG_DIR defined.

/azp run cpp - keyvault

/azp run cpp - keyvault

/azp run cpp - keyvault

/azp run cpp - keyvault

/azp run cpp - keyvault

Closing as no longer needed https://github.com/Azure/azure-sdk-for-cpp/pull/5800#issuecomment-2235335065


Delete image

Hi, and thanks for sharing pictshare !!
Upload is working perfectly but delete has some glitches...
I'm using a post call and although delete works, it returns 404 with this html message
Warning: unlink(/var/www/vhosts/xxx/xxx.com/upload/delete_temp.csv): No such file or directory in /var/www/vhosts/xxx/xxx.com/models/pictsharemodel.php on line 145.
I have the same behavior even if I send the delete url by hand.
Am I doing something wrong ?

thanks :)
The 404 is okay since the image can't be found after being deleted. Might add an error image in the future

Thanks for replying !
An end point like backend.php but for delete, that returns a json response might be more elegant and useful.... :-)

good idea!


Adding dateFormat

PR to test the flow...

Just an idea: how about defining a more generic FormattingFilter?
It could:

either dispatch to all sorts of FormattingExtension based on format* option
or just use the Formatter? Like ${date @ formatter='...'}. Unfortunately, the format option is already in use

hi @vladbailescu ,
thanks for your feedback, given that 'format' is already used, I think it was more complex / confusing how this can be used.

What is missing in this PR is

Support for new Java8 date classes: http://www.oracle.com/technetwork/articles/java/jf14-date-time-2125367.html
The locale is not specified in the SimpleDateFormatter constructor. This should be taken from the request by default (and passed to the SimpleDateFormatter, https://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat.html#SimpleDateFormat(java.lang.String, java.util.Locale)). Also there should be a possibility to overwrite that with an additional option, similar to what we have for i18n, https://github.com/Adobe-Marketing-Cloud/htl-spec/blob/master/SPECIFICATION.md#123-i18n.

What is also missing here is the timezone to express the date (it would default to the system default, which is not necessarily the time you want).

hi @wolfpl , great suggestion! I added the support for timezones.

@raducotescu @heervisscher, this has been fixed at https://issues.apache.org/jira/browse/SLING-6102. We should probably close this.

With the upcoming migration to git this repository will be deleted. If the pull request contains data that should be re-submitted I suggest that you save the changes locally and resubmit them after the migration, which will likely happen on Monday the 9th of October.


Multi-Second Lag on Line Break (maybe minimum hardware requirements?)

Is anyone else seeing a lot of lag: unpredictable on typing(can be seconds), multiple seconds before parinfer indents after a line-break.
I'm running the Jar version of 2.1.5
My laptop is a little old: 1.8 GHz (AMD) quad core, 8 gigs ram.
I'm seeing this on Linux (Mint 17) and Win 7 32-bit.
Maybe we can hash out some minimum requirements for hitting the Doherty Threshold.

I think I fixed this issue in 2.3.0 (I was unnecessarily refreshing when I didn't need to be). Please let me know if you still consider it an issue after trying that version.


Another attempted fix (w/ help from izy521)

Also, I'm bad at git and keep pushing those commits every single time. >_<


Tiny change to the quickstart guide

This is just a tiny change to make the quickstart guide more precise.

hey, @andresgalante - thanks for polishing this 💯


How to bind two keypress without prefix

is it possible to bind with 2 keypress . for instance:
(map! :leader
      :desc "save and quit"  **"wq"** #'evil-save-and-close
      ...

i'm just curious is there way to do that? i hope that make sense.

(map! :leader :desc "save and quit" "wq" #'evil-save-and-close)

Did you try it?

it didn't work.

well, also have bind for "w" to write . Apparently, it didn't work when i bind at the "wq" for write and quit at the same time.

You cannot use a key as a prefix (e.g. wq) and a keybind (e.g. w). It's one or the other, unless you're up to write some gnarly elisp hackery to get it working. I'd recommend just binding the latter to ww instead.
(map! :leader
      "wq" #'evil-save-and-quit
      "ww" #'evil-write)

Or just use SPC b s (saves the buffer) to save and SPC q q (saves buffers and quits)

Oh got it. Thank you for you time!


Fixing instructions for a fresh install

I followed the instructions and added all informations that I found to be missing after discussions with the project owners.

Thanks for the great work!

regarding the tokenizer (which I see this pull request does not address)

cl_toplang_128k does not exist on the entirety of github outside of this repository.
I believe it is equivalent to the llama3 tiktoken BPE file provided from the original llama source files. This should be pullable from HF directly without authentication via, e.g. Nous

also, your trap addition to setup/download_prepare_hf_data.py is broken. you should add a ; or && or etc.

What about this line from #18 ?
https://github.com/facebookresearch/lingua/pull/18/files#diff-6279f47e1d2b54a7d47a77ef48b01587926a2a6a5e47a98a2dcd1fefd45ef821R27
Could be related to #26, too.


Pytyle3 development status

Is pytyle3 under active development? The last edit was a configuration fix a year ago and there are multiple open issues.
Just for clarification: It is completely okay if a project is discontinued. But I think a lot of people like pytyle and don't want to let it die. This said: I would like to know the status and your opinion before I decide what I should/can/would do … f.e.: fork it and close issues.

I am personally not doing any work on it. I haven't done any work on it in many years and don't plan on continuing in the future. A few years ago, I wrote my own window manager which subsumed pytyle functionality (i.e., Openbox meets Xmonad).
Fork away. Or I can add you as a committer to this repo. Up to you.

Wow. Let me check out wingo a couple of days!
Do you think it would work with xfce4? I switched from Openbox to xfce4
because it is a little bit more clickybunty and I started to like that.
I will get back to you! Thanks!
Excerpts from Andrew Gallant's message of 2015-10-22 18:24:38 +0200:

I am personally not doing any work on it. I haven't done any work on it in many years and don't plan on continuing in the future. A few years ago, I wrote my own window manager which subsumed pytyle functionality (i.e., Openbox meets Xmonad).
Fork away. Or I can add you as a committer to this repo. Up to you.

Reply to this email directly or view it on GitHub:
https://github.com/BurntSushi/pytyle3/issues/24#issuecomment-150279530

I don't know, sorry. I haven't used a DE in years.


Use rust's clippy utility...

We should be using a linter to help clean up the codebase.  Clippy seems to be great, let's use it.
root@9eaaabfc2ea8:/home/test/safeposix-rust# cargo clippy
...
warning: `rustposix` (lib) generated 422 warnings
error: could not compile `rustposix` (lib) due to 13 previous errors; 422 warnings emitted

Right now, we have a long way to go to appease clippy.  I am predicting we will find a lot of errors when doing this cleanup!

I've started to look through why clippy isn't happy with rustposix and see the following:
174 of the warnings are for unnecessary return statements.  As someone who hasn't really wrapped their head around Rust fully, I prefer the style that clippy complains about over the version it wants us to change our code to use.  So I would consider this case low priority to fix.  If we want to fix it, clippy will do so automatically for us.
There are a few dozen other warnings that are also likely not a real issue and may be low priority to fix.  For example, there are a fair number of warnings about us doing type conversions to the same type.  Auto dereferencing also would be done in some cases where we are explicit.  Redundant field initialization is another case of this.  To me these are examples of situations where we likely do not make the code less clear by being explicit, but then again, maybe the fact we're doing a redundant operation will confuse some readers?  Fixing these seems like it isn't the highest priority.
There are another few dozen which are likely efficiency bugs that we could fix.  For example, apparently a length comparison to zero is often much less efficient than is_empty().
The remainder of issues noted by clippy are a mix of possible bugs and things that could cause buts.  These require deeper understanding of the code and need to be examined manually.   For example, there are places where we are doing operations that have no effect, having if statements where the if and else blocks do the same thing, etc.  These are likely errors that we do not realize we have in our code.  The zero_prefixed_literal warnings are particularly scary!  I think a lot of places we use these, the assumption is they are binary or hex values!!!
I don't know how to judge the errors, but there are only 13 of them, so someone should take a closer look.  I do think they are much more likely to be safe / correct than the errors above.
I propose we prioritize things in the last category and temporarily turn off clippy's warnings for things in the first two categories like unnecessary return statements.

I've looked more through here.  There are a lot of benign things which are likely not a problem but we may want to change for style reasons.  There are also a bunch that are mild performance issues, but not security bugs.  I see quite a few that should be obviously fixed, but which aren't likely causing us an actual issue.
For things which may be a bigger concern, I've listed them here.  I honestly can't tell in these cases, but they seem to have the potential to be an actual problem.  Note there are often multiple copies of each of these, but I'm only listing one here.  If any are an issue, please let me know and I can potentially give more examples.
error: written amount is not handled
   --> src/interface/file.rs:201:17
    |
201 |                 fobj.write(buf)?;
    |                 ^^^^^^^^^^^^^^^^
    |
    = help: use `Write::write_all` instead, or handle partial writes
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
    = note: `#[deny(clippy::unused_io_amount)]` on by default

warning: this let-binding has unit value
   --> src/interface/file.rs:269:9
    |
269 |         let _newsize = f.set_len((COUNTMAPSIZE + mapsize) as u64).unwrap();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `f.set_len((COUNTMAPSIZE + mapsize) as u64).unwrap();`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
    = note: `#[warn(clippy::let_unit_value)]` on by default

    |
187 |     for <item> in slice.iter_mut().take(count) {slice[i] = 0u8;}
    |         ~~~~~~    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: this public function might dereference a raw pointer but is not marked `unsafe`
   --> src/interface/misc.rs:192:55

warning: this lifetime isn't used in the function definition
   --> src/interface/types.rs:352:22
    |
352 | pub fn get_ioctl_int<'a>(ptrunion: IoctlPtrUnion) -> Result<i32, i32> {
    |                      ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
    = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default

warning: this `if` has identical blocks
    --> src/safeposix/syscalls/fs_calls.rs:1686:55
     |
1686 |                       if operation & LOCK_NB == LOCK_NB {
     |  _______________________________________________________^
1687 | |                         lock.unlock();
1688 | |                     } else {
     | |_____________________^
     |
note: same as this
    --> src/safeposix/syscalls/fs_calls.rs:1688:28
     |
1688 |                       } else {
     |  ____________________________^
1689 | |                         lock.unlock();
1690 | |                     }
     | |_____________________^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
     = note: `#[warn(clippy::if_same_then_else)]` on by default

warning: unnecessary operation
    --> src/safeposix/syscalls/net_calls.rs:1838:25
     |
1838 |                         epollfdobj.registered_fds.remove(&fd).unwrap().1;
     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `epollfdobj.registered_fds.remove(&fd).unwrap();`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
     = note: `#[warn(clippy::unnecessary_operation)]` on by default

warning: redundant closure
  --> src/safeposix/filesystem.rs:26:36
   |
26 |     interface::RustLazyGlobal::new(|| interface::RustHashMap::new());
   |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `interface::RustHashMap::new`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
   = note: `#[warn(clippy::redundant_closure)]` on by default

error: read amount is not handled
  --> src/lib_fs_utils.rs:78:9
   |
78 |         hostfile.read(hostslice.as_mut_slice()).unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: use `Read::read_exact` instead, or handle partial reads
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount


Smart select dark theme issue

I have theme-dark class applied to .view class
On some pages I create smart select options dynamically than append to html
Looks like there are two bugs or I am doing something wrong

when opening smart select, I can't see selected value until I press on it
dark theme doesn't apply on popup

video http://screenshots.justapps.eu/Screencast_12-47_11-10-2019.mp4

Because smart select which is opened in modal opened outside of the View where you added theme-dark. Add that class to main container or add cssClass: 'theme-dark' smart select parameter to make it dark theme

Check this please https://jsfiddle.net/qgm8uv7s/
Open About page than toggle after that open smart select

Have you read what i wrote above? https://jsfiddle.net/azgLxj87/


Update node-notifier in version 5

Laravel Mix Version: 5.0.9 (npm list --depth=0)
Node Version (node -v): irrelevant
NPM Version (npm -v): irrelevant
OS: irrelevant

Description:
I'm using the latest version of Laravel Mix v5.x, but have recently gotten a warning from GitHub informing me about a vulnerable package (node-notifier)–see screenshot below.
I'm unable to update said package because Laravel Mix (at least in v5.x) requires v6.x of node-notifier (the vulnerable package), whereas v8.0.1 is the earliest version with a fix.
TLDR–would it be possible to patch node-notifier to v8.0.1 or higher in Laravel Mix v5.x?

I'm just now seeing that this is due to webpack-notifier being "stuck" at v1.5.x.

@JeffreyWay bumping in case you haven't seen this.

@JeffreyWay bumping in case you haven't seen this.


Force ILC to compile a function to native even its never been called in code

I am using corert to against tempering and improve the safety of my software, in order to hide my  corert DLL's function address , I need to hide it from DLL export , I want to generate a map file and call it directly from its base address ,however it seems like  ILC  doesn't compile any function that is never been called  inside of its project.
I know I can just make a fake control flow to call this function, however, this means my function will still have some connection in the assembly from the entry point of the DLL to the function I wanted to hide, is there any other way I can have the function compiled?

You can use RD.XML to force inclusion of types and methods that would otherwise not be compiled. The primary goal of RD.XML is to make the method accessible by reflection, but the side effect is a generated method body.
See sample of how to write RD.XML here: https://github.com/dotnet/corert/blob/cf34d38409ff12797ad56e4399c1a9b029c8dbaf/samples/WebApi/rd.xml
(You'll probably want a Type directive.)
You'll need to reference the RD.XML from your project like this: https://github.com/dotnet/corert/blob/cf34d38409ff12797ad56e4399c1a9b029c8dbaf/samples/WebApi/SampleWebApi.csproj#L8


Add "enterprise" badge in kong.websocket articles

Where is the problem?
https://docs.konghq.com/gateway/3.2.x/plugin-development/pdk/kong.websocket.client
What happened?
Howdy! Unlike kong.jwe there is no "enterprise" badge for following articles: kong.websocket.client, kong.websocket.upstream.
What did you expect to happen?
Add an "enterprise" badge to avoid confusion for users.
Code of Conduct and Community Expectations

[x] I agree to follow this project's Code of Conduct
[X] I agree to abide by the Community Expectations

bump, was shocked to find I cannot use this part of the sdk in my plugin. if you're going to kneecap kong's functionality for oss users then at least make a note in the documentation so people don't spend hours on an implementation that uses methods not available to them!


fix: insert new does not focus cell

fixes https://github.com/react-page/react-page/issues/1012
@PeterKottas that uses your new focusAfter option

:tada: This PR is included in version 2.2.10 :tada:
The release is available on:

v2.2.10
GitHub release

Your semantic-release bot :package::rocket:

Looks good. I am not using the drawer, so this slipped through the cracks. Now (with sensible default value) I quite like that you can control the behavior.


Check no changes err in DelegateDNS in cf/project.go

Right now, in the DelegateDNS function in project.go, we call update here. If there's an error, we bubble it up and it eventually stops environment creation, this is fine.
We should, however, swallow the errChangeSetEmpty error - since it just means there were no updates needed.
Right now, if you run env init twice, and this delegation was successful the first time, it will cause the the update to fail.

?????????????????

????????????????????????????????????????????????????????????????????????????????

happy to take on this. is it ok for non-first time contributor to tackle another "good first issue"?

Hi @sandyleo26!
It's totally okay for a non-first time contributor to tackle another "good first issue"! They're used more as an indicator on how much prior knowledge you might need about the codebase.


A better CSS support

The current CSS support is horrible and we should find a way to integrate selectors into the svgdom.

@RazrFalcon Would you consider supporting CSS Variables as well? Or is the subset fixed to SVG 1.1?

For now, I want to support at least a decent CSS 2.
The current problem is the parser and selector itself. The only option for now is cssparser+selectors, but they are too bloated. And sort of low-level (CSS variables should be resolved manually). So I plan to write my own CSS resolver in the future.

A decent CSS 2 support (not complete) was added via an updated simplecss crate.


release artifacts for release v0.0.2

Signed-off-by: Amine Hilaly<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Chore/update ac codes for prop and vote

Description ℹ
Updates AC references to match the new codes being used in the specs repo for VOTE and PROP

Seems to be a duplicate PR. Closing


cascade_lifecycle: 2.0.0-3 in 'jazzy/distribution.yaml' [bloom]

Increasing version of package(s) in repository cascade_lifecycle to 2.0.0-3:

upstream repository: https://github.com/fmrico/cascade_lifecycle.git
release repository: https://github.com/ros2-gbp/cascade_lifecycle-release.git
distro file: jazzy/distribution.yaml
bloom version: 0.12.0
previous version for package: 2.0.0-2

cascade_lifecycle_msgs

No changes

rclcpp_cascade_lifecycle
* Fix clear_activation
* Contributors: Francisco Martín Rico

Bug detected. aborting

Sorry for the open-reopen. I thought I had found a critical bug, but all is ok :)


Document Deployment restartPolicy

Closes https://github.com/kubernetes/kubernetes/issues/24725
@kubernetes/docs

@bgrant0607 PTAL

Sorry for the piecemeal review. Finished a complete pass this time.

@bgrant0607 PTAL

LGTM


AIRFLOW-51 && AIRFLOW-71 && AIRFLOW-516 docker_operator improvements

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

[AIRFLOW-51] Rename param Docker cpus -> cpu_shares
[AIRFLOW-71] docker_operator - pulling from private repositories
[AIRFLOW-516] removing stopped container.

@mistercrunch, please review the PR.
p.s. the build process doesn't give a deterministic results.

@asnit any updates on this?


Cannot connect to websocket with wrangler dev

🐛 Bug report

Describe the bug
I keep getting this message when trying to connect to websocket using wrangler dev. Non-websocket routes work fine though.
[2021-05-04 22:54:59] GET dev-bug.ulrjch.workers.dev/ws HTTP/1.1 400 Bad Request
[2021-05-04 22:55:08] GET dev-bug.ulrjch.workers.dev/ HTTP/1.1 200 OK

Reproduce the bug

Clone https://github.com/universse/wrangler-bug
Enter account_id in wrangler.toml
Run wrangler dev
Open index.html
Above error messages would appear in terminal.

Optional: It works fine when published.

Run wrangler publish
Replace websocket link in index.html
Open index.html
Websocket connection is successful.

Expected behavior
Should be able to connect to websocket using wrangler dev.
Environment and versions
Fill out the following information about your environment.

operating system: Windows 10 Home
output of wrangler -V:  wrangler 1.16.0-durable-objects-rc.0
output of node -v: v15.10.0
content of wrangler.toml: per repo

I have tried type: "webpack" for wrangler.toml as well. It doesn't work still.

We currently do not support WebSocket debugging in wrangler dev, but obviously we should. Will get back to you as we figure out the complexity for this addition.

Hey it's September now, how's this doing? I've found the same issue with wrangler dev and can confirm it only works when published.
$ wrangler -V
wrangler 1.19.3

We've scheduled to fix this in q4 (ie - before the end of this year) Until then, the recommendation is to use miniflare https://github.com/cloudflare/wrangler/issues/2079#issuecomment-924759723 Sorry for the delay on this, we'll fix it soon.

Just a heads up to maybe update the note at https://developers.cloudflare.com/workers/learning/using-websockets#writing-a-websocket-server in case this should already be fixed in production!

Good catch! sent a PR that removes the message https://github.com/cloudflare/cloudflare-docs/pull/3082. Thanks!


RankSources replace key with inlet

When using set_rank we'll only be setting the rank for a single site and species so we can just use the inlet height instead of a key.

Should this link to PR 177 - "Changes key to inlet on RankSources"?

This was done with #177 .


Experimental work on background tasks

Here, the goal is to use only one timer in place of one for each tenant background task group. Working in progress, so not fully tested and not sure it's done in the right way. At least, it seems to work as before.

So, in the only one timer callback, for each group and according to their delay, we call DoWorkAsync() as it is already implemented. This by using a new dedicated class BackgroundTaskGroup.

There are different ways to call groups, full parallelism or not ... E.g we could use Parallel.ForEach() but, again, maybe there would be too much threads, but we can limit the degree of paralelism ...

So, just for testing, currently i use Task.WhenAll().

Finally, not yet implemented but i also think about a multi instances scenario where we would want that only one instance executes all or part of background tasks. Maybe we would need a locking system using the database as in O1.

It was just an experimentation, so i close it.

Trying it with 500 tenants i didn't see a significant difference in terms of memory and threads. I only saw a different distribution of the cpu usage.

With hundreds of unsynchronized timers, on my machine there is always +20% of cpu usage. With only one main timer we have about +40% of cpu usage but every minute and during a few seconds.


Honour fell down

I am arnab1998 . My honour fell down by 1000. please check it.

As explained in this post:

My honour fell down too . Can it be fixed? Please let me know... Username: arnab1998

Please do not reuse old threads which are already fixed and closed. Your issue is totally unrelated to the original topic of this thread.
Your points were taken away because many of your solutions for difficult kata were copies of solutions of other users. The best way out of this situation is to delete the current account, create a new one, and use it to submit only your own solutions, not copied from other users, and not copied from web.
Please create a new ticket if you want to discuss the matter further.

Answering the follow-up question:

Can it be recovered for the codes of mine only .please

I don't think this will happen. No one knows which solutions are yours, and no one is going to spend time to evaluate all solutions and check which might be honest, and which are not. Starting from scratch will be just easier.

not an isse.


ELM327 OBD II mini return strange initial value

Hi
I was testing with ELM 327 OBD II adapter but there are many problem with it.
Here is the adapter:
https://www.amazon.co.jp/gp/product/B00J7CC4T2/ref=s9_simh_gw_g263_i3_r?pf_rd_m=AN1VRQENFRJN5&pf_rd_s=desktop-1&pf_rd_r=CWQZA5C1423S3A1CGSS4&pf_rd_t=36701&pf_rd_p=9d539fa0-72bc-4756-8b94-2163f0a38a88&pf_rd_i=desktop
After connect to adapter, all of initial value is very strange.
Speed is 11565 ( It should be 0 km/h)
RPM, Distance v.v.v.. also is really strange.
Has anyone seen this problem before ?
Thank

Hello,
I am also receiving some strange values for most of the parameters. I am using the ECUsim 2000 simulator and for example, the Speed and RPM is displayed like this:
Speed: 410D941:DAF11803410D942:DAF12803410D94
RPM: 410CFFFF1:F11804410CFFFF
When i manually change the value of the parameters of the ECUsim, these parameters are updated but are displayed in the same format.
Is this a format issue, incompatibility or am i doing something wrong ?
Thank you !

@bitaromulus that is incompatibility. You are seeing can responses. I am busy working on getting can to work, however my vehicle's do not respond in can so it's taking longer than expected.
Could you please post more raw responses along with what the value should be (roughly).

@kaorijp could you please post your raw responses?

@Pho3niX90
Hello again,
My ECUsim 2000 has 5 knobs which can be used to manually update the values of the parameters.
The parameters that can be monitored are:

Knob 1: Engine Coolant Temperature;
Knob 2: Engine Speed (RPM);
Knob 3: Vehicle Speed;
Knob 4: Oxygen Sensor Voltage (I don't know if this is actually available in the current API, didn't check);
Knob 5: Mass Air Flow (MAF).

This simulator, also has a Configuration DIP Switch (has two switches that set the protocol attributes for ISO 15765-4(CAN). Switch number 1 is also used to select the init type for ISO 14230-4:
a) 29 bit / 11 bit - Selects CAN frame ID type;
b) 500 kbps / 250 kbps - Selects CAN baud rate;
c) Fast Init / 5 Baud Init - Selects the type of initialization for ISO 14230-4).
When i wrote the previous message, i was using the simulator with the following settings:
29 bit / Fast Init + 500kbps
With these settings, i was receiving those strange values for most of the parameters, to be more precise: Knob 1, Knob 2 and Knob 3.
Meanwhile, i changed to the following settings:
11 bit / 5 Baud Init + either 500 kbps or 250 kbps
After i did this, i ran the Android application once again and i've noticed that the values for Knob 1(Engine Coolant Temperature) and Knob 2(Engine Speed (RPM)) are displayed correctly. Knob 3(Vehicle Speed) is still the same strange format, though.
Currently, for Knob 3(Vehicle Speed) the displayed value is as follows:

With Knob 3 set at max, the displayed value is: 410DFF2:0DFF4000103700
With Knob 3 set at min, the displayed value is: 410D002:0D003000103700

Knob 3 should give as a returned value 0x00 for min and 0xFF for max (0~255km/h).
What is suprisingly is that certain bits of the displayed parameter, are constantly updated:
410DFF2:0DFF4000103700
The numbers marked in bold are being updated constantly (it doesn't has an exact period of time, it just changes at about 5~10 seconds).
If you need any other information, please let me  know and i will try to help in whatever way is possible for me.
Thank you in advance !

Good morning !
@Pho3niX90
Regrading the raw data, I'm sorry that I didn't save it before. I will take the screenshot or file log in next testing time.
BUT, all of strange value look likes a [Max value] that is described on Wiki page:
https://en.wikipedia.org/wiki/OBD-II_PIDs
For examples :
RPM 16,383
Distance 65,535
etc...
@bitaromulus
Have you think the protocol type is a one of reasonable ?
( At that time, I choosed AUTO )

Good morning,
@kaorijp I've tried with all of the available protocols and only the CAN ones provide good data (except for the Vehicule Speed). The other ones do not work, NODATA is displayed in most of the cases.
Currently, i also use AUTO setting.
This evening, i will also try to post a screenshot and if possible, a log file. I guess this way, it will be better.
Thank you and have a nice day !

@bitaromulus
Thank for your reply.
As far as I know, the Vehicle speed is the most important value.
Anyway, I'm waiting your next report.
I will also try to test with all protocols. I just need to get Timing, Speed, Distance only .
Report you soon....

Hello once again,
I've tested once again the application but it's the same problem with the vehicle speed.
I am attaching the log file, i hope it helps to identify more easily the source of this problem:
OBDReader_logcat_1466540907052.txt
If you need any other information, please let me know.
Thank you and have a nice day !

Hello @bitaromulus
I have a question for you.

I've tried with all of the available protocols and only the CAN ones provide good data (except for the Vehicule Speed).
What kind of CAN protocol that has been confirmed ?
There are many CAN protocols type that is defined in source code .
Ex:
IOS_15765_4_CAN
IOS_15765_4_CAN_B
IOS_15765_4_CAN_C
IOS_15765_4_CAN_D
SAE_J1939_CAN
USER1_CAN

Hello @kaorijp
You are right, i should have been more specific regarding the protocol which i use.
My ECUsim 2000 is not full featured, this means that it currently supports only the Standard ISO 15765-4.
I currently have chosen the AUTO option from the configuration menu, but it always uses IOS_15765_4_CAN_C (except for the Vehicle Speed, everything works for me with this protocol).
If i choose a different protocol, NODATA is received/displayed.
I hope this information is useful for you.

So I have been testing on real car ( Toyota Voxy 2014).
I didn't test with each of protocol type. Just set as AUTO.
Beside that, I do not use Wifi , my expected is what is the real result that retuning by OBD II command only .
I dont want to get distance by GPS.
Can you help me to test Distance MIL with out GPS ?

@kaorijp Distance MIL is not distance traveled, it's distance traveled with MIL light on.

@bitaromulus thank you for the examples you have posted.
My pc crashes and need to resetup everything from scratch again. Once I have done that I will work on a solution for the can messages.  I will look into acquiring the ecusim as well for the multiprotocol development. Currently I use win-obdsim for testing but only supports kline messages.

@bitaromulus
Could you please post example of these mods
29 bit / Fast Init + 500kbps
11 bit / 5 Baud Init + either 500 kbps or 250 kbps
With 2 raw examples of each knob, for each protocol above? That would be a considerable help to improve the library @ https://github.com/pires/obd-java-api/issues/115

Good evening!
@Pho3niX90
Thanks for your explain.
So , OBD 2 is not currently supporting distance traveled command (PID) ?

@kaorijp no it doesn't have such a function. Only distance travelled with MIL on, and since codes cleared. See https://en.wikipedia.org/wiki/OBD-II_PIDs

Hello @Pho3niX90
I have managed to group some raw incoming/outgoing data for each of the Knobs.
In the pictures, you will see incoming/outgoing data from the ECUsim 2000, which i've captured using TeraTerm. I've started with min value for each knob and gradually increased it until the max value (you will notice that the values will modify).
Also, for each Knob, i've associated the log file.
11 bit / 5 Baud Init + 250 kbps
Knob 1 (Engine Coolant Temperature)
ECUsim LOG:

Android App LOG: -  (I forgot to send the logfile. If it's necessary, i can upload it later.)
Knob 2 (RPM)
ECUsim LOG:

Android App LOG:
[RPM]OBDReader_logcat_1466705645131.txt
Knob 3 (Vehicle Speed)
ECUsim LOG:

Android App LOG:
[VH. SPEED]OBDReader_logcat_1466706265806.txt
Knob 4 (Oxygen Sensor Voltage) - Not available
ECUsim LOG: -
Android App LOG: -
Knob 5 (Mass Air Flow)
ECUsim LOG:

Android App LOG:
[MAF]OBDReader_logcat_1466706011275.txt
29 bit / Fast Init + 500kbps
Knob 1 (Engine Coolant Temperature)
ECUsim LOG:

Android App LOG:
[ENGINE COOLANT TEMP.]OBDReader_logcat_1466707547676.txt
Knob 2 (RPM)
ECUsim LOG:

Android App LOG:
[RPM]OBDReader_logcat_1466708093893.txt
Knob 3 (Vehicle Speed)
ECUsim LOG:
[VH. SPEED]OBDReader_logcat_1466707754477.txt
Android App LOG:

Knob 4 (Oxygen Sensor Voltage) - Not available
ECUsim LOG: -
Android App LOG: -
Knob 5 (Mass Air Flow)
ECUsim LOG:

Android App LOG:
[MAF]OBDReader_logcat_1466707977783.txt
When do you think it will be possible to fix the displayed format for the Vehicle Speed ?
If you need any more information, let me know and if it's possible for me, i will try to help.
Thank you and have a nice evening !

@bitaromulus
@Pho3niX90
I'm so sorry for ask you again about Distance traveled.
I'm really confused with three Module $ PID

01 21   -> Distance traveled with malfunction indicator lamp (MIL) on
01 31   -> Distance traveled since codes cleared
04 NA  -> Clear trouble codes / Malfunction indicator lamp (MIL) / Check engine light
(Clears all stored trouble codes and turns the MIL off.)

From my understanding,we can get value that return from command Distance travelled with MIL on
And then, if (04 NA) command has been called , it means the MIL if OFF.  At this time, we can use command (01 31) to get value in this case ( Since codes cleared) . What does value of (01 31) mean ?
So my confusion is :

What is the difference beween distance travelled , distance travelled with MIL on and distance travelled with MIL off ( in case of since codes cleared)

@kaorijp What are you trying to achieve?

@Pho3niX90
Ex: A car travels from point A to point B.
How many km driven in this case?

@kaorijp Then there is no pid for you. 31 has a max value it will display and does not get reset on each trip. 31 is distance travelled after the last time errors were cleared. And it's not supported by most vehicles as far as I have seen

@Pho3niX90 I have KM on the display of my car :) and I suppose that its have some pid to get this KM. If its have this KM (of production without reset) a car travels from point A to point B = km B - km A

@sytolk There is no generic PID for this. Therefore not possible in this project. You will have yo run a sniffer on your vehicles network to find it. But this is different per brand and per model. I personally do not see a need for this so cannot assist in persuing it when the gps works flawlessly.

@kaorijp My only suggestion to what you want to achieve is monitor the cars speed over the session time and calculate the distance.

@Pho3niX90 this is good idea. @kaorijp can you check distance calculated from speed like: List speedChanges = [30,10,30,25,5];
if(curr_speed != previous_speed) //add to array
int avgSpeed = 100/5=20 km/h
distance (km)= 20 x time(h)

Its wrong :) its need to have timestamp attached to the HashMap speed => timestamp

If you take the memorized distance traveled and subtract from the actual and display it, that could satisfy?
You just need to consider that other option when he uses the other PID for the calculation the distance traveled due to MIL ocurrence.
It will not be good if you clear those trouble codes, once you need it to know whats going on in your vehicle.

Maybe some mix if pid 31 and 21 supported by vehicle use it. If not it will be good to have distance based on speed changes or to enable both methods +GPS and match the results. Who can provide PR ? :)

@Pho3niX90

31 has a max value it will display and does not get reset on each trip

What does max value mean in this case ?
@sytolk
@Pho3niX90

My only suggestion to what you want to achieve is monitor the cars speed over the session time and calculate the distance

Yep. This is my workaround until now.
I also tested this case and has a litle difference from the real kilometer on car.
Results
In fact, I have driven 2.2km and spent 15 minutes. But the calculation is returned 1.9 ~ 2.05 km
Maybe the calculation the not good BUT the main problem is the speed is not updated in real time !
( Around 2 seconds is delay than real kilometer )


emmylua - callback signatures, some fixes

I also could add callback signatures to classes like CustomMovableBehavior, but the comments there didn't have the parameter type

We can add them there too, shouldn't be much trouble. I can add some comments on main if you like (when I have time)

While this PR is still up: could you add that the <br/> in the comments is omitted for the spel2.lua?
could also do something with [name](#name) links, but it's not that big of a deal

Also i added new constructor for AABB in my PR #276 (from tuple so it's only for the internal use), but the /// NoDoc didn't work for the emmylua so spel2.lua got that constructor

Should I make deprecated functions to also be printed on spel2.lua and mark them as ---@deprecated?

Should I make deprecated functions to also be printed on spel2.lua and mark them as ---@deprecated?

I'd avoid them there.

You sure? I think it would be better to include the deprecated ones, so when people update spel2.lua they still see the functions like set_post_statemachine instead of just showing that the function doesn't exist, and also showing the warning that the function is deprecated, like this:

You sure? I think it would be better to include the deprecated ones, so when people update spel2.lua they still see the functions like set_post_statemachine instead of just showing that the function doesn't exist, and also showing the warning that the function is deprecated, like this: image](https://user-images.githubusercontent.com/20376110/214326668-37c4b8b8-8a0f-47b4-bd0a-56c18ba7a4a0.png)

I think the main reason not to include them is autocomplete, very little people will probably read that message, and the whole idea of deprecated functions is to discourage people from using them.
I also think in the API docs they should be much more clearly marked as well

I end up with functions that just aren't in the spel2 lua all the time and just assume they're missing rather than deprecated. If a deprecation does a strike through like in estabanfer's example thats much more clear that it shouldn't be used than the yellow squiggle which could just mean it's not defined to to a bug or using an old spel2.lua or any number of other reasons

I agree with gary, had the same thing happen before with functions showing as missing.
Also, on autocomplete for vscode, deprecated functions show like this

I think that I'm done with the changes, though I think I need to change the constructors to use ---@overload because on autocomplete it only shows the last constructor declared instead of all of them, but I think I'll leave that for another PR.
Also ig I'll leave the deprecated functions stuff it for another PR if it's going to be added.


DockerCertificates from String and InputStream

Sometimes the docker certificates are storage in other places than files.
Maybe DockerCertificates could load from InputStream or String instead of Path / File.
This is a suggestion.
private methods of DockerCertificates could be protected, and Builder could have InputStreams for cert properties instead of Paths ...

Codecov Report

Merging #755 into master will decrease coverage by 1.36%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #755      +/-   ##
============================================
- Coverage     65.59%   64.22%   -1.37%
- Complexity      656      782     +126
============================================
  Files           153      158       +5
  Lines          2883     3712     +829
  Branches        335      491     +156
============================================
+ Hits           1891     2384     +493
- Misses          845     1156     +311
- Partials        147      172      +25


add support for peers that can't handle BUNDLE

Thank you for this excellent library! I have a decent understanding of WebRTC, and was running into issues getting this library connecting to Ring Camera's WebRTC endpoints. It turned out it was because Ring does not support BUNDLE (and werift only supports BUNDLE), and the transceiver ice/dtls parameters would get clobbered in this loop:
https://github.com/shinyoshiaki/werift-webrtc/blob/399859537c0f9ed189dd18e043fdd477f594f18e/packages/webrtc/src/peerConnection.ts#L759
From what I understand, WebRTC should may have ice/dtls transports per transceiver, so I implemented that and confirmed the peer connection with Ring works now. It also still supports bundle. The packages/webrtc tests are passing.
This is still a work in progress, but I wanted to get your initial feedback.

I also took the liberty of optimizing your lodash imports. I am using this library in a webpack/esbuild environment and wanted to reduce the overall size.

Thanks for the PR.
WebRTC agents do not have ice/dtls transports per transceiver if they are doing "group:BUNDLE".
The entire PeerConnection will share one ice/dtls transport.
With this change, a different transport is used for each m-line even when Bundle is enabled, which causes a degrade that prevents communication with Bundle enabled clients that handle multiple media.
The reason "packages/webrtc tests" is passing is because it is an incomplete test.
In the root directory
yarn e2e

in the root directory to run the E2E test with Chrome in the /e2e directory. If you incorporate this change, the E2E test will no longer pass.
I think there are two possible responses that can be taken.

Make it possible to set the Bundle policy in the constructor of RTCPeerConnection, so that RTCPeerConnection can correctly handle both Bundle and Non-Bundle.
Create a NonBundleRTCPeerConnection that is a dedicated RTCPeerConnection class for Non-Bundle.

In the end, we should do the first one, but since the implementation/verification cost is high, how about we take the second one for this PullRequest?

Thanks for your feedback. I hope you'll bare with me as I am not fully versed on the spec.
Here is Safari's offer (with group:BUNDLE): https://gist.github.com/koush/f0469aa8be3aa7f00c265f82e9159810
I believe every m-line has a different transport.
Here is Chrome (Chromecast)'s answer: https://gist.github.com/koush/67d3462021ae99643f62679f3a6b875c
It is also group:BUNDLE and only has a single set of candidates for the entire connection.
Here is Ring's answer: https://gist.github.com/koush/ff6e1b6f9de96a96217c40ed8b2c3779
It does not support group:BUNDLE and has two sets of candidates.

With this change, a different transport is used for each m-line even when Bundle is enabled, which causes a degrade that prevents communication with Bundle enabled clients that handle multiple media.

That is correct. I believe the offer with BUNDLE should send non-BUNDLE candidates, and if the answer includes BUNDLE, it uses the bundle connection? From my testing, these changes did in fact use a single BUNDLE when both sides agreed to it. I coalesce into a BUNDLE transport in setRemoteDescription. And it properly uses the originalnon-BUNDLE offer when the answer did not include BUNDLE.
Thanks for letting me know about the e2e tests, I will take a look.

Thanks for sharing SDP.
From the description of each SDP and WebRTC-PC, can consider
https://www.w3.org/TR/webrtc/#rtcbundlepolicy-enum

safari
RTCBundlePolicy === max-compat

chrome
RTCBundlePolicy === max-bundle

werift
Effectively, "max-bundle". However, it outputs ICE information for each media.

can say that it is

For DTLS sessions, if using BUNDLE, need to share one DTLS session with the BUNDLE group
https://datatracker.ietf.org/doc/html/rfc8843#section-11

It seems that we need to follow the specification of rtcbundlepolicy and RFC8843 in order to correctly guarantee the compatibility of BUNDLE and NonBundle clients.

In the end, we should do the first one, but since the implementation/testing cost is high, how about we take the second one for this PullRequest?

Another thought was detecting a non-BUNDLE response (that would be outside the scope of this library), and then parsing that out into a peer connection per m-line, each with their own transports, and setting up two peer connections with werift.

It seems that we need to follow the specification of rtcbundlepolicy and RFC8843 in order to correctly guarantee the compatibility of BUNDLE and NonBundle clients.

I think the issue here is that the dtls parameters are the same per bundle, but the ice parameters are different per m-line. (see the aforementioned Ring SDP). The webrtc implementation on the ring side may very well be buggy.
These are different (see last few characters) of the Ring SDP:
m=audio
a=ice-ufrag:cgrE1dbhZ4TrpnNybSKuLOBa4Zkm9vC0 <----
a=ice-pwd:dK36VKRQcdbpkHD0lLRsr6Qf+czXT0Ds

m=video
a=ice-ufrag:cgrE1dbhZ4TrpnNybSKuLOBa4Zkm9vC1 <----
a=ice-pwd:dK36VKRQcdbpkHD0lLRsr6Qf+czXT0Ds

The fingerprint is the same between m-lines:
sha-256 78:AB:F2:56:F0:05:92:58:DF:A3:BF:EC:63:F3:8E:64:E7:D4:08:99:F6:9D:CF:25:D7:AD:FF:DB:52:38:A0:CD

This is where werift assumes ice ufrag/pwd is the same and clobbers per m-line:
https://github.com/shinyoshiaki/werift-webrtc/blob/399859537c0f9ed189dd18e043fdd477f594f18e/packages/webrtc/src/peerConnection.ts#L759
Does the spec allow different ice parameters per m-line on BUNDLE?

I think the issue here is that the dtls parameters are the same per bundle, but the ice parameters are different per m-line.

I think so too.
As for ring's SDP, it does not use BUNDLE, so there is no problem even if the ice parameter is different for each m-line.
Also, even if the dtls fingerprint is the same for each m-line, it does not mean that they are sharing the same DTLS session.
Perhaps the RING is using the same certificate for all DTLS sessions, so the fingerprint is the same.

Does the spec allow different ice parameters per m-line on BUNDLE?

In the situation where BUNDLE is used, it is not allowed to use different ice parameters for each m-line.

I coalesce into a BUNDLE transport in setRemoteDescription

I've read the code in the relevant part of the PR and will comment on it.

Thank you for pointing that out. That also addressed some other bugs I saw in my builds. I had some issues getting the end to end tests running, but I'll get that figured out sometime this week.

If you have any progress or questions, please feel free to let me know.

Hi, I ran the tests and they seem to be passing:

Chrome Headless 102.0.4958.0 (Mac OS 10.15.7): Executed 20 of 20 SUCCESS (13.243 secs / 13.223 secs)

seem to be getting regression in "test_connect_datachannel_modern_sdp" at packages/webrtc/tests/integrate/peerConnection.test.ts

Thanks for giving me the PR.
It seems to pass the test now, so I will merge it.
After merging this PR, I will release a new version of the NPM package after I do the implementation regarding bundlePolicy.
When I release the new version, I would appreciate it if you could check if it works for your project.

@koush
Thanks for giving me the PR.
It seems to pass the test now, so I will merge it.
After merging this PR, I will release a new version of the NPM package after I do the implementation regarding bundlePolicy.
When I release the new version, I would appreciate it if you could check if it works for your project.


Use structured logging

Use structured logging in json format if -logging-format=json is specified. The same setup functions as for K8s core packages are used (component-base).
Also, contextual logging is used (beta in 1.30, so no feature-gateway is needed).
Fixes #48
This PR will be a draft until all code is changed to use structured/contextual logging.

/cc @pohly
@pohly Can you please review the updates in main() in the first commit? I don't want to do any fundamental mistakes. The rest I think I can manage.

Example output:
# kubectl logs -n kube-system   kube-network-policies-8hb7p | jq
...
{
  "ts":<PHONE_NUMBER>865.8306,
  "caller": "cache/reflector.go:359",
  "msg": "Caches populated for *v1.Pod from pkg/mod/k8s.io/client-go@v0.30.2/tools/cache/reflector.go:232",
  "v": 2
}
{
  "ts":<PHONE_NUMBER>953.2607,
  "caller": "cache/shared_informer.go:320",
  "msg": "Caches are synced for kube-network-policies",
  "v": 0
}
{
  "ts":<PHONE_NUMBER>953.3674,
  "caller": "networkpolicy/metrics.go:61",
  "msg": "Registering metrics",
  "v": 0
}
{
  "ts":<PHONE_NUMBER>953.4724,
  "caller": "networkpolicy/controller.go:344",
  "msg": "Syncing nftables rules",
  "v": 0
}

Lint complaints:
Error: cmd/main.go:81:3: exitAfterDefer: os.Exit will exit, and `defer cancel()` will not run (gocritic)

This is just as bad with klog.Fatalf, but lint misses that. A pattern seem to be:
func main() {
  os.Exit(run())
}
func run() int {
  return errorCode
}

Shall we use it? Else I restore klog.Fatalf in main()

func main() {
  os.Exit(run())
}
func run() int {
  return errorCode
}

that sounds like the right way to do it

@uablrek what is missing here? it lgtms
/lgtm
/approve

@uablrek what is missing here? it lgtms

Lots and lots of Infof(), and friends, should be changed to InfoS().
Also i was planning to introduce contextual logging, but I think that can wait.

Structured logging allows a nice optimization possibility. Without this p.String() is always called, regardless of verbosity.
	// evaluatePacket() should be fast unless trace logging is enabled.
	// Logging optimization: We check if V(2) is enabled before hand,
	// rather than evaluating the all parameters make an unnecessary logger call
	tlogger := logger.V(2)
	if tlogger.Enabled() {
		tlogger.Info("Evaluating packet", "packet", p)
		tlogger = tlogger.WithValues("id", p.id)
	}

Example packet log in JSON format:
{
  "ts":<PHONE_NUMBER>838.3552,
  "caller": "networkpolicy/controller.go:461",
  "msg": "Evaluating packet",
  "v": 2,
  "packet": {
    "Id": 9,
    "Family": "IPv4",
    "SrcIP": "<IP_ADDRESS>",
    "DstIP": "<IP_ADDRESS>",
    "Proto": "TCP",
    "SrcPort": 33803,
    "DstPort": 6000
  }
}

I will squash commits later

let me know once is ready for merging

Rebased, updated after review, and use klog.KObj. Ready for review.
Please note that payload is empty for TCP/SYN, which is the only TCP packets we see:
I0721 08:56:53.060501       1 controller.go:491] "Evaluating packet" packet=<
        [10] <IP_ADDRESS>:34751 <IP_ADDRESS>:6000 TCP
 >

let me know once is ready for merging

@aojea Ready for review at least. I hope for merging. No logic is altered (except in main()), but very many log printouts

The flag-logging can be made in different ways:

The "structured object way" (this doesn't look so good for non-json logging):

	flag.VisitAll(func(flag *flag.Flag) {
		logger.Info("flag", "flag", flag)
	})

{
  "ts":<PHONE_NUMBER>411.8074,
  "caller": "cmd/main.go:83",
  "msg": "flag",
  "v": 0,
  "flag": {
    "Name": "nfqueue-id",
    "Usage": "Number of the nfqueue used",
    "Value": 100,
    "DefValue": "100"
  }
}

The "name/value way" (this is what I selected)

	flag.VisitAll(func(flag *flag.Flag) {
		logger.Info("flag", "name", flag.Name, "value", flag.Value)
	})

{
  "ts":<PHONE_NUMBER>630.011,
  "caller": "cmd/main.go:83",
  "msg": "flag",
  "v": 0,
  "name": "nfqueue-id",
  "value": "100"
}

Non-json logging:
I1117 11:05:07.914817  119614 main.go:83] "flag" name="nfqueue-id" value="100"

The "non structured logging way" (not recommended)

	flag.VisitAll(func(flag *flag.Flag) {
		klog.Infof("FLAG: --%s=%q", flag.Name, flag.Value)
	})

{
  "ts":<PHONE_NUMBER>913.3442,
  "caller": "cmd/main.go:84",
  "msg": "FLAG: --nfqueue-id=\"100\"",
  "v": 0
}

The failing test seem unrelated to the updates. I ran e2e:
(BASE_FAMILY=IPv6 PROXY_MODE=nftables)
export SKIP=NOTHING
export FOCUS=Netpol
Ran 50 of 6622 Specs in 132.293 seconds
SUCCESS! -- 50 Passed | 0 Failed | 0 Pending | 6572 Skipped

/retest

/lgtm
/hold
waiting for @paulgmiller review, we can unhold tomorrow if he does not have time to review
@paulgmiller just do /hold cancel if you are happy with the PR


could you support the case "every 5minutes"?

Now it only supports every minute,but not supoort "every N minutes", for example ”*/5 * * * *" .

This feature has been addressed in other issue, it should be included in the next release :) thanks for you input.

Sorry but this feature has been pushed back to a farther release, I will keep you updated.

I would love this feature as well. I needed this functionality where I need to run one background job every 3 minutes. I am hard coding it as of yet :-(

Hi @jacobscarter ,
Any idea when this could be delivered?

need to support "every 30 seconds" plz

I would love this feature as well. I needed this functionality where I need to run one background job every 3 minutes. I am hard coding it as of yet :-(

Hi, I am looking for a solution that the user's location should be pushed into the database by calling an API. This should run for infinite at an interval even if the app is in the background. Do you have any solution for this?
Sunil Gupta

Did anyone find a workaround for this since the project is no longer maintained?


Complie error?

I get an error while try to run python setup_cuda.py install from GPTQ-for-LLaMa after copied the modified kernel files:
error: no instance of overloaded function "atomicAdd" matches the argument list
I have cuda 11.7 installed and running windows.

Maybe you can try the latest version. If still cannot compile, remove the half support in the source code because they're not used currently.

what GPU? Sounds like an issue I raninto with GPTQ and an older one (M40), see: https://github.com/qwopqwop200/GPTQ-for-LLaMa/pull/58

I tried the new version but got the same error. Then i found this and it fixed my issue: https://github.com/johnsmith0031/alpaca_lora_4bit/issues/9
I got 4.16s/it on a Tesla P40 with the 13B llama.
Thx for the help!

That is like the fix for M40.. we have half precision on 6.1.


Some typos in wiki re config

We noticed some mistakes in the wiki for configuration.
The short switches for includerepos and excluderepos should be ir and er respectively. The wiki has them the wrong way around.
Incidentally, the highlighting of global is also slightly wrong.

Fixed, thanks.


Very new to choco - help with set logs location

Hi Everyone,
Loving the product! just started to use it and will try to incorporate with Azure Image Builder to deploy apps to my VM's.
I am finding an issue setting the log file location - following the doc url and setting the value:
choco config set log-file c:\temp
Close PowerShell and open new window > install product and I get this at the end:
Chocolatey installed 2/2 packages.  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
When opening config file I can see:
<add key="log-file" value="c:\temp" />
So nothing is written to C:\Temp
Am I doing something wrong here?
Thanks Everyone

HI @ii-batman I believe this is because log-file is a global argument accepted by all commands, and is not actually a configuration option. The choco config command allows you to put anything you want in the configuration file, even if it's not actually a valid configuration option.
To be able to set a default for the log file location doesn't seem an unreasonable request to me. I would recommend looking through the issues on chocolatey/choco and open an issue there if there isn't already one.

@corbob
No worries, I managed to adapt my script to log into my desired location:
`$Packages = 'googlechrome', 'git', 'notepadplusplus', 'adobereader'
ForEach ($PackageName in $Packages) {
$action = choco install $PackageName -y  -force --log-file='C:\buildartifacts\Working_CS_Apps\Choco_Apps\Choco.log'
Write-Host "Customization: Installing Chocolatey Applications - $action"
}
$Installed = choco list --local-only
`
Loving the choco! Makes life so much easier!

@ii-batman
That's great to hear. I'm going to close this issue off as it appears we've answered your question. I would definitely suggest taking a look through the choco issues and if there's not already one for having a configuration option for log file location open an issue there to track that it would be good to add to the configuration.


fix corrupted compound command results and provide key-value pair formatting

When compound commands are used, e.g. in a scenario where the application controls hardware with multiple channels we found that some some parts go missing. *IDN?;*IDN? works, other queries that would return "0;1;2" only return "0;".
fix:
use netconn_write(u->io, data, len, NETCONN_COPY). NETCONN_NOCOPY is not allowed here, as data doesn't stay valid until sending is complete. See https://doc.ecoscentric.com/ref/lwip-api-sequential-netconn-write.html for details.
enhancement:
provide SCPI_ResultCommand() to facilitate prepending results with the command in question.
example: MEAS:VOLT:CH1?;CH2?;CH3?;CH4?:MEAS:CURR:CH1?
reply (prepend on): MEAS:VOLT:CH1,0.123;MEAS:VOLT:CH2,2.048;MEAS:VOLT:CH3,1.337;MEAS:VOLT:CH4,0;:MEAS:CURR:CH1,0.42
reply (default): 0.123;2.048;1.337;0;0.42

Please keep in mind, that the library itself was never designed with multiple sessions in mind. It can fail hardly in more complex cases.
E.g. if you allow two simultanouse clients and one sends in one TCP packet *ID and in second packet N?\r\n and the other client will send in between MEAS?\r\n, then the result in the buffer for parsing will be *IDMEAS?\r\nN?\r\n which is wrong for both.
So in my opinion, the only correct way of solving this is to introduce real multi session ability. The easiest approach would be to have multiplle scipi_t context for each session and somehow share status of the device between them. So introduce some  functions to have some "master" session and for every client, derive new "slave" session, which will be discarded, after client disconnect.

I've been wondering about possible benefits for multiple sessions. While it's again not an issue with scpi-parser itself but a defect in the example I aim to resolve, a single line* sent in a single session, like

MEAS:VOLT:CH1?;CH2?;CH3?;CH4?:MEAS:CURR:CH1?\r\n

seems to produce garbled output. When sending

MEAS:VOLT:CH1?\r\n
MEAS:VOLT:CH2?\r\n
MEAS:VOLT:CH3?\r\n
MEAS:VOLT:CH4?\r\n
MEAS:CURR:CH1?\r\n

no issue is observed, though I haven't tested sending the commands in one go. In its current state I believe the server example implementation has no means to manage the buffers it passes to netconn_write(), and its documentation points out that the buffers need to stay valid for an indeterminate amount of time (when kept in the re-send queue).
Copying buffers via NETCONN_COPY takes more resources, but I think it's the only legitimate way to use netconn_write() in the current example implementation. Other approaches will need a handler to be called when the tcp packet has been successfully received, or output to be written directly to a TX buffer.

(*) IEEE 488.2 allows the designer some discretion on how compound headers are handled
within the rules of section <IP_ADDRESS>. SCPI imposes additional requirements regarding how a
compound command is parsed.
Multiple <PROGRAM MESSAGE UNIT> elements may be sent in a <PROGRAM
MESSAGE>. The first command is always referenced to the root node. Subsequent
commands, however, are referenced to the same tree level as the previous command in a
message unit.
https://www.ivifoundation.org/docs/scpi-99.pdf

NETCONN_NOCOPY vs NETCONN_COPY is deffinitely a problem which sould be solved. Buffer with data is reused, while it is sending, which is wrong.
But, I don't understand the rest of the PR.
SCPI specification allows multiple PROGRAM MESSAGE UNIT in PROGRAM MESSAGE but I don't know, if it allows multiple "queries" (commands ending with ?) in single message. It is possibly this library extension (I hope it is not against the spec to support it).

rest of the PR

The other two commits probably need to be in another branch and require some more thought / a separate PR. This PR can then focus on 9afb267.

So, can you please remove the other two commits so this can be easilly merged?


User/colinli02/11 publish ros package actions final

Description

Resolves #11
⚠ Two relevant branches, since modifications to 2 repos: ⚠

(This branch linked in PR from network_systems) + sailbot_workspace branch

Verification

When running its CI, you can notice within "Actions" on both workspaces that it works, example:
//this one calls itself
//this one calls sailbot_workspace

Implementation
When this is merged into main, make sure within these files on line 22:

Network_systems relevant yml file
Sailbot_workspace relevant yml file
to switch to @main instead. I currently have it set to call my branches for verification, if you want to check.

Implementation
When this is merged into main, make sure within these files on line 22:
Network_systems relevant yml file Sailbot_workspace relevant yml file to switch to @main instead.

I think this would be the best way to merge everything in:

Merge in sailbot_workspace PR

I temporarily disabled "automatically delete head branches" so that even the main branch CI will pass

Make and merge in a PR in sailbot_workspace to use main branch
Update this PR to use main branch

This seems to appear, so checkout looks fine. Is this on my end?

All that's left is to

Run CI after the sailbot_workspace PR is merged in
Get approval from @hhenry01