Proposal: SemiPartial

Would there be any interest in adding the below type?
type SemiPartial<T, K extends keyof T> = Partial<Exclude<T, K>> & Pick<T, K>;

The idea behind it is to allow for objects where all the fields are optional (i.e. Typescript's Partial<T>) except for those that are specified.
For example:
interface Foo {
    foo: string;
    bar: string;
    baz: string;
}

let foo: SemiPartial<Foo, 'foo' | 'bar'>;

// VALID - 'foo' & 'bar' are non-optional, 'baz' is optional
foo = {
    foo: "foo",
    bar: "bar",
};

// INVALID - both 'foo' and 'bar' must be present
foo = {
    baz: "baz",
};

// INVALID - 'bar' is present but 'foo' is not
foo = {
    bar: "bar",
    baz: "baz",
};

The main use I had in mind for this is working with GraphQL types. Typically properties on GraphQL types are optional by default and can be marked as required (using the ! operator). In this respect it's the opposite of Typescript. This allows for a subset of that type to be provided when calling queries/mutations.
For example, in the below a User is identified using an email (which is marked as required) but the other properties are optional for the purpose of updating. This means that, as an example, the firstName can be updated by just providing the email and firstName and the lastName is not required.
type User {
  email: String!
  firstName: String
  lastName: String
}

mutation {
  updateUser(user: User)
}

You could define your Typescript interfaces to exactly match the GraphQL schema but there's a strong possibility that the domain model has different optionality requirements. For example, in the above it may be that both firstName and lastName are required fields for a User but optional for GraphQL queries/mutations. So your code might have something like:
// This would be the 'true' domain model
interface User {
  email: string;
  firstName: string;
  lastName: string;
}

// This would be the type that is used to pass details to GraphQL queries/mutations
type GraphQLUser = SemiPartial<User, 'email'>

I've had  a look at the MarkRequired type that was discussed and implemented here, and this differs in that it makes non-optional properties optional unless specified, whereas MarkRequired only affects properties that were already optional.
Let me know what you think!

let foo: SemiPartial<Foo, 'foo' | 'bar'>;

I think you can do the same with a combination of MarkRequired and Partial. Does this satisfy your use case?
let foo: MarkRequired<Partial<Foo>, 'foo' | 'bar'>;

If yes, I don't think it's enough to warrant a new type, since the construction above is simple. If it would be useful, we could maybe add the opposite of MarkRequired -- MarkOptional, which would make the given keys optional.

Yeah, that works in the same manner and I think it's also more readable than my own implementation. Thanks!
If you don't think it warrants a new type then I'm fine with that but I'm happy to do the leg work to add it if it wants adding. 🙂

@DomParfitt Thanks for this idea. Usually what we do is we keep such issues open for some time to see if there any other people interested in this.

@all-contributors please add @DomParfitt for ideas

I also had a use case for the MarkOptional type when supplying default values for an interface that requires them.
I'm using:
type MakeOptional<T, K extends keyof T> = Omit<T, K> & Partial<Pick<T, K>>;

Done by @macbem, it's called MarkOptional 👌
Released as<EMAIL_ADDRESS>


window._sharedData

JSON Query to accounts/login/: Could not find "window._sharedData" in html response. [retrying; skip with ^C]
JSON Query to accounts/login/: Could not find "window._sharedData" in html response. [retrying; skip with ^C]
Traceback (most recent call last):
File "/data/user/0/ru.iiec.pydroid3/files/aarch64-linux-android/lib/python3.9/site-packages/instaloader/instaloadercontext.py", line 410, in get_json
raise QueryReturnedNotFoundException("Could not find "window._sharedData" in html response.")
instaloader.exceptions.QueryReturnedNotFoundException: Could not find "window._sharedData" in html response.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/data/user/0/ru.iiec.pydroid3/files/aarch64-linux-android/lib/python3.9/site-packages/instaloader/instaloadercontext.py", line 410, in get_json
raise QueryReturnedNotFoundException("Could not find "window._sharedData" in html response.")
instaloader.exceptions.QueryReturnedNotFoundException: Could not find "window._sharedData" in html response.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/data/user/0/ru.iiec.pydroid3/files/aarch64-linux-android/lib/python3.9/site-packages/instaloader/instaloadercontext.py", line 410, in get_json
raise QueryReturnedNotFoundException("Could not find "window._sharedData" in html response.")
instaloader.exceptions.QueryReturnedNotFoundException: Could not find "window._sharedData" in html response.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/data/user/0/ru.iiec.pydroid3/files/accomp_files/iiec_run/iiec_run.py", line 31, in
start(fakepyfile,mainpyfile)
File "/data/user/0/ru.iiec.pydroid3/files/accomp_files/iiec_run/iiec_run.py", line 30, in start
exec(open(mainpyfile).read(),  main.dict)
File "", line 7, in
File "/data/user/0/ru.iiec.pydroid3/files/aarch64-linux-android/lib/python3.9/site-packages/instaloader/instaloader.py", line 651, in login
self.context.login(user, passwd)
File "/data/user/0/ru.iiec.pydroid3/files/aarch64-linux-android/lib/python3.9/site-packages/instaloader/instaloadercontext.py", line 259, in login
csrf_json = self.get_json('accounts/login/', {}, session=session)
File "/data/user/0/ru.iiec.pydroid3/files/aarch64-linux-android/lib/python3.9/site-packages/instaloader/instaloadercontext.py", line 448, in get_json
return self.get_json(path=path, params=params, host=host, session=sess, _attempt=_attempt + 1,
File "/data/user/0/ru.iiec.pydroid3/files/aarch64-linux-android/lib/python3.9/site-packages/instaloader/instaloadercontext.py", line 448, in get_json
return self.get_json(path=path, params=params, host=host, session=sess, _attempt=_attempt + 1,
File "/data/user/0/ru.iiec.pydroid3/files/aarch64-linux-android/lib/python3.9/site-packages/instaloader/instaloadercontext.py", line 436, in get_json
raise QueryReturnedNotFoundException(error_string) from err
instaloader.exceptions.QueryReturnedNotFoundException: JSON Query to accounts/login/: Could not find "window._sharedData" in html response.
[Program finished]

Same

Same

Hard life

same

https://github.com/instaloader/instaloader/issues/2044#issuecomment-1665274954

same


Ember Data and ajaxOptions

Ember Data calls adapter.ajaxOptions within the ajax method.  Since both instanceOp and classOp use this method the data payload gets run through  JSON.stringify twice.  This can be very confusing for a backend (at least in the case of Rails, it doesn't parse it at all).
Would it work to only pass in custom options + the data payload into ajax instead of running them through adapter.ajaxOptions?

this sounds like a real concern, and your proposed solution is reasonable. Let me work up a few test cases and see if I can get in a fix today

@thec0keman - Just published a v0.0.3 that fixes this issue. Thanks for reporting this problem

Thanks for the quick fix!


[WIP] adopt new mlx-c api

Adopt new API from https://github.com/ml-explore/mlx-c/pull/38 and move to mlx v0.21.0 (just adopting API, not picking up new ops yet)
This is complete (now that mlx-c is tagged)

I'm a bit daunted by the size of the diff 😅 . I can peruse but (other than you inline comments) is there anything specific that would be good to have reviewed?

I'm a bit daunted by the size of the diff 😅 . I can peruse but (other than you inline comments) is there anything specific that would be good to have reviewed?

It is mostly mechanical -- I was able to do a good chunk of the work with creative search and replace.  The metal kernel code is the biggest change because the structure of the back end changed (and it is complicated anyway).
It is big but mostly uninteresting.

Tests clear, LGTM. Thanks for getting this one done!!

Awesome, thanks for looking!  I will merge and tag it in the morning.


[Bug] - GUI doesn't show error when accepting an offer before the wallet has synced up

What happened?
While running the 1.6.1 rc5 build on mac intel in wallet only mode, I tried accepting an offer I copied from Dexie and while the wallet sync status showed "orange", I tried accepting an offer. I didn't get an error message and after clicking on the accept button, nothing happened. I clicked on it twice thinking it didn't take the first time. Eventually the GUI errored out into a 500 second timeout issue.

We should show an error message in the GUI if user can't accept an offer while the wallet is still syncing to prevent any confusion on the user's part.
Version
1.6.1 rc5
What platform are you using?
macOS
What ui mode are you using?
GUI
Relevant log output or stacktrace
No response

@rifeljm when clicking the "Accept Offer" button we should check if the wallet is synced, and if not, display an alert. We can use either the useIsWalletSynced() hook, or useWalletState() to determine if the wallet is synced. We can do something like:
    if (state !== SyncingStatus.SYNCED) {
      throw new Error(t`Please wait for wallet synchronization`);
    }


add support for pulling images from private repository

Looks like this isn't building due to checkstyle errors. We use the Google Java Style guide.
Would you mind fixing the style and squashing your commits? You can see the specific errors at the end of the build log:
https://circleci.com/gh/iouardi/docker-client/2

We should close this as the original fork has been deleted and we can use the original AuthConfig class instead of creating a new one. See https://github.com/spotify/docker-client/pull/118

Closed in favor of #118 .


docs: add section about using custom URLs

Preview URL: https://docs-git-docs-custom-urls-nhost.vercel.app/

Codecov Report

Merging #2009 (564ce1a) into main (c1b024c) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main    #2009   +/-   ##
=======================================
  Coverage   87.10%   87.10%
=======================================
  Files          85       85
  Lines        9282     9282
  Branches      550      550
=======================================
  Hits         8085     8085
  Misses       1197     1197


horizontally and vertically center canvas and text layer

Also fixes an issue where text layer is not exactly on top of the canvas when cavas width is less than screen width (which happens often in landscape mode or when fully zoomed out)

since my changes rely purely on html/css and contains way less code, i think it is also an overall better implementation of what #213 tries to do, so merging my changes should also close #213
as far as testing goes, i've tested my changes in both landscape and portrait mode with pdf of various shapes and sizes and so far there doesn't appear to be any regressions and layout appears as expected in all of these four cases (at most four cases are possible depending on the zoom value and pdf's width-height ratio):

pdf width < screen width && pdf height < screen height: pdf is centered both horizontally and vertically
pdf width < screen width && pdf height >= screen height: pdf is centered horizontally and occupies full height
pdf width >= screen width && pdf height < screen height: pdf occupies full width and is centered vertically
pdf width >= screen width && pdf height >= screen height: pdf occupies full width and height

by 'pdf occupies full length (width or height)', i mean that the pdf covers the full length of the screen and the hidden part can be made visible by scrolling in the appropriate direction
bugs related to zooming in and out (e.g. pdf goes out of the view and jumps back in some cases) remain, which i'm planning to fix via another pull request


perf(core): only load local modules once

PR Checklist

[x] A description of the changes is added to the description of this PR.
[ ] If there is a related issue, make sure it is linked to this PR.
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated

Description of changes
Local modules retrieval is currently done multiple times, as it's done in a for loop. This PR makes sure that it's only done once, greatly reducing the run time on big projects.

Codecov Report

Merging #242 (8b5ad30) into main (8a71695) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #242   +/-   ##
=====================================
  Coverage   95.7%   95.7%
=====================================
  Files         32      32
  Lines        914     915    +1
  Branches     203     203
=====================================
+ Hits         875     876    +1
  Misses        26      26
  Partials      13      13

Impacted Files
Coverage Δ

deptry/core.py
97.6% <100.0%> (+<0.1%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add optional H264 support

Optional H264 support. Not negotiated since we are forwarding packets. SMB offers one or the other by selecting video codec in the config file for the application lifetime. Default is VP8
Packetization mode 0 and 1 are supported
Unit tests added for header and rewriter

Tested manually with and without simulcast in example/simpleclient as well as with Eyevinn WHIP broadcast components.
@reddvl1980 Since you are the H264 expert here, please let me know if I missed anything regarding keyframe detection for mode 0 and 1.

LGTM. Maybe we could consider later adding a VideoSourc in the Integration test parts to produce fake H264 packets with valid headers.

CI failed in tcheck (likely due to really slow thread scheduling)
It failed in release due to a tcp connectivity problem, which we see occasionally.
It also failed in addr sanitizerrr and that one looked a bit more suspicious. I am re-running now, but it may be something we need to investigate.

CI failed in tcheck (likely due to really slow thread scheduling) It failed in release due to a tcp connectivity problem, which we see occasionally. It also failed in addr sanitizerrr and that one looked a bit more suspicious. I am re-running now, but it may be something we need to investigate.

Seems to pass now. Ok to merge, or was the asan error in the new code? In that case I can try to run that locally.

Ok to merge?

@olofkallander did you see anything that needs to be addressed? If everything looks ok, could you approve the PR? Thanks.


docs: Rename "Testing and writing tests" section to "Testing overview".

The section doesn't really explain anything about actually writing
tests, so "Testing overview" seems like a more fitting name.
Addresses concern raised in https://chat.zulip.org/#narrow/stream/95-new-members/topic/GSoC.202020/near/818364

Merged!  Thanks @mateuszmandera


L5.1 Support

Seriously, this support would be much needed !

L5.2 supported needed now. Is this package abandoned?


The npm link is wrong

The npm link should be corrected to "@maicol07/material-web-additions" everywhere, especially in the README.

Thanks! There was indeed a typo with the package scope!


Parallel dequeue

Addresses https://microsofthealth.visualstudio.com/Health/_workitems/edit/99473/

/azp run


Optimise by serving multiple formats

Thank you so much for the library!
Is your feature request related to a problem? Please describe.
I want to be able to serve next gen formats (webp, avif) to those on compatible browsers while allowing for a fallback to jpg/png for those on incompatible browsers.
Describe the solution you'd like
I provide a jpeg/png image. The library converts those images to webp/avif in the relevant sizes and serves all of the possible formats in all possible sizes, depending on what the browser supports.
Similar to the current convert formats functionality, but supporting multiple formats and serving optimised images from the original format too.
Describe alternatives you've considered
https://github.com/Niels-IO/next-image-export-optimizer supports this.
Additional context
The functionality I am looking for is the same that is available in next.js - see: https://nextjs.org/docs/app/api-reference/components/image#formats

@HandyHat
Hi.
At the moment it is possible to convert to webp or avif itself!
https://next-export-optimize-images.vercel.app/docs/Configurations/basic-configuration#convertformat
However, we are currently unable to provide support for various extensions that use browser functionality such as using the picture element 😭
https://github.com/Niels-IO/next-image-export-optimizer I thought that this library probably does not support the above picture element either…?

Now that we have the groundwork in place to add this feature, we will proceed with this as well👍.

Thank you so much for looking into this and accepting this feature request!

https://github.com/Niels-IO/next-image-export-optimizer I thought that this library probably does not support the above picture element either…?

next-image-export-optimizer does not use the picture element but instead uses a data image to check which formats are supported by the browser, and then serves images of the right format in an srcset

I opened PR #667 that enables serving images in multiple formats. This is also directed at #653.
It adds a new config.
const config = {
  generateFormats: ['jpg'],
}

I created a demo project to show how multiple images can be served.
Check PictureImage.tsx component for details.
Essentially you can use unstable_getImgProps from next/image to create srcset for each source as long as the image is actually generated.


Unreferenced variable warning

I'd like to make a suggestion to suppress warning C4100 (unreferenced variable) for microsoft compiler or to update code correspondingly. We build our project with 'treat warnings as errors' and to fix build error we have to add #pragma warning( disable : 4100 ) to vk_mem_alloc.h.

C4100 is one of the warnings that are already disabled temporarily for the inclusion of vk_mem_alloc.h in the sample application, as you can see in file src\VmaUsage.h. I recommend you do the same in your code.
I don't want to add such directives to the library itself. Maintaining C++ code to compile and work correctly on so many different platforms is hard enough, so I consider being free of any compiler warnings, on any version of any compiler, as not feasible.


Layout broken on 1080p in Firefox (Ubuntu)

Describe the bug
The layout seems broken, with some elements appearing outside of their boxes, or some boxes being set to sizes that require scrolling
To Reproduce
Steps to reproduce the behavior:
Set resolution to 1080p open the application in Firefox (I'm on version 73)
Expected behavior
Elements fitting within their borders, elements that don't require additional scroll
Screenshots

Desktop (please complete the following information):

Ubuntu Eoan
Firefox 73

3 screenshots as example, however problem appears on more pages

Yea, I noticed that on Chrome / Windows as well.

It's a known problem, i had a hard time figuring out how to structure the Vuetify project to have a consistent layout.
I'm quiet sure it's an easy fix.

@gizahNL @bbrendon It's fixed in develop branch and will be included in a futur release.


[WIP] Adding function to convert from utc to local

invitations: Invited at column shows UTC instead of local time. #7664
UTC time being displayed on admin 'invitation' tab when admin sent the email to user.

@zulipbot remove "needs review"

@zulipbot label "wip"

@zulipbot label "in progress"

@zulipbot assigness "snlkapil"

@zulipbot assignee "snlkapil"

@zulipbot assignee "skapil"

I think the right way to fix this is to have the backend send a timestamp rather than a formatted time, and then copy how we display times in other settings (using functions in timerender.js).

@rishig Thanks for comment.
when you say backend, you mean directly from the model:
https://github.com/zulip/zulip/blob/119bc141822dfa8976f819c45b8a4f6e18b6921c/zerver/models.py#L805

Feel free to ask in #development help. But basically the frontend code here is calling functions in zerver/views/invite.py, which are calling functions in zerver/lib/actions.py, that are doing a funny conversion, e.g. like
   return prereg_user.invited_at.strftime("%Y-%m-%d %H:%M:%S")

to figure out the right thing to do here I would follow the codepaths of other times that are shown in the settings code (e.g. the uploaded files tab), and see what they do.

Thanks @rishig .. Let me take a look 👍

@zulipbot assignee "skapil"

@zulipbot label "needs-review"

@zulipbot label "needs review"

@rishig can I get review please. Here is how it looks now. The time shows same as upload files.

Thanks @skapil! Left a small comment. The commits also need to be squashed, and the commit message fixed to follow our guidelines (the area can be settings: ). Feel free to ask on #development help if you need help with the commit message guidelines!

@rishig Let me know, if everything looks good!!

The commit message can be:
settings: Show local time instead of UTC in invitations tab.

Fixes #7664.

Also, the description of the commit says there are two functions that need this fixing, whereas I only see one change to actions.py?

@rishig Thanks for pointing out!

@rishig Can you please have a look!! thanks for all the comments 👍

Added @showell for review! (Steve, haven't done a final review.)

Merged! Thanks @skapil @rishig


fixed to proper formatting, DWORD is long unsigned

LGTM. Can you please adjust the commit message to follow the convention outlined in CONTRIBUTING.md ? Thanks!

updated, sorry for that

Landed in 6cf935b, thanks!


Promise is undefined

Hi,
I get "Promise is undefined" error from sweetalert2.min.js.
 $.ajax({
        type: 'GET',
        url: url,
        data: {
            test: test
        },
        error: function (xhr, status, error) {
            swal('Sorry...!', 'Server Message:

' + error, 'error');
            // Throw expection "Promise is undefined"
        }
    }).done(function (data) {

    });

Thanks...

Most probably you're getting this exception in IE.
For IE support Promise polyfill should be included beside sweetalert2.js:

Hi @limonte, thanks for help.
I added this script and problem resolved. But "OK" button and background click event not working in IE 11.

But "OK" button and background click event not working in IE 11.

As I can see all works fine in IE11. Probably it's up to your environment.

How do you add Promise polyfill without bower?

Came here from google; so just for reference this is what I added to my main page to prevent it from loading on non-IE browsers (borrowing from @samturrell's example):

<![endif]-->```

If you need to target a specific version, see here: https://msdn.microsoft.com/en-us/library/ms537512(v=vs.85).aspx

Adding core-js is the fix for IE. I tried adding the es6-promise but the button clicks still did nothing. After adding core-js it worked as expected.

core-js is the preferred polyfill, yes. It's pretty good and contains lots of polyfills.

How to add core-js to my project?


Redoc Param

Expand 200 & 201 on page load
Expand JSON sample responses 3 levels deep
Order properties based on required first

Approved, but I'm not sure why the Redocly Registry validation is failing and I can't access the details.

@sudoku-lord - can you merge this PR?


Some optimisations to async reading.

MoveToContentAsync is often called in states where it will immediately return true without any reading. In this case return AsyncUtils.True avoiding allocation or async state-machine.
DoReadAsync is a very heavily hit method, and can often be fulfilled without creating another state machine, so do this.
The remaining looping async case is the only use of ParsePostValueAsync, so inline it into the calling method, so there is one less task allocation.
Return value of EatWhitespaceAsync is never used, returning void reduces the number of locals and hence the size of the state-machine. Do the same for EatWhitespace though the impact is less.

I was thinking about doing something similar to DoReadAsync last night. Looks good to me.


Create credentials CRD

Support a credential CRD with the following api version and kind
apiVersion: ci.estafette.io/v1
kind: credentials

And the following fields in the spec:
name: <string, required and needs to be unique>
type: <string, required>
whitelistedTrustedImages: <string, optional>
whitelistedPipelines: <string, optional>

additionalProperties: <map[string]interface{}, optional>

See https://github.com/estafette/estafette-ci-contracts/blob/master/config.go#L43-L51
For the additional properties it would be nice if they can be inlined like we already do in the configmap, but not sure if that's possible since kubebuilder tries to create protos for the CRDs.

Yeah, kubebuilder doesn't even allow map[string]interface{} to be used.
I've found this: https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/de0b9e0704/examples/dashboard-operator/api/v1alpha1/dashboard_types.go#L28
but in our case we will need to define the fields that could go into the additional properties.

Maybe we can have one CRD per credential type, ex.: registrycredential, slackcredential, etc.

The reason they're not strongly typed is that anyone can come up with new types belonging to some extension container without Estafette having any knowledge of the type whatsoever. Making a CRD per type renders that impossible. I'm up for ways to make it easier to validate the properties, while keeping the freedom to add new types without touching the core of Estafette.

got it, makes sense :+1:


Consider a new name

"custom-elements.json" is a filename and not necessarily a description of the file's contents or purpose. The file specific name also might not be required to be custom-elements.json. On npm it could be referenced from a package.json field, like the "types" field. In other systems, like databases, the name might not matter or even exist.
A few options to consider:

Custom elements manifest
Custom elements docs file
Package docs file

Considering that the format will be capable of pretty fully describing package contents, being a "package docs file" might make sense. There very well might be other communities interested in shared docs infrastructure, even if that isn't a primary goal right now.

I personally dont mind the fact that its a filename, but I'd be interested to hear some more thoughts/opinions here.
I could see it be called custom elements manifest, manifest seems to be "popular" (manifest.json, precache manifest) i could see custom elements manifest "fit in" perhaps a bit better.

Consider: in the docs for web app manifest, MDN recommends the filename manifest.webmanifest.

I like the name "Custom Elements Manifest". The filename would presumably still usually be custom-elements.json though we should also standardize a package.json field to point to the manifest so that indexers can see that a package has a manifest without having to unpack the entire tarfile.

I like the name "Custom Elements Manifest". The filename would presumably still usually be custom-elements.json t

sounds fine to me 👍

without having to unpack the entire tarfile.

yeah that's a huge pain-point.
So we could have something like this in the package.json?
"custom-elements-manifest": "./custom-elements.json"

Manifest sounds good to me.

I like manifest too 👍

Manifest sounds good to me too!

I also think that manifest sounds good here.
Not to spend too much time in the bikeshed, but to compare to similarly relevant art, I would submit https://github.com/AdobeXD/design-system-package-dsp#understanding-the-dsp.json-file (not that I worked on this, even though I work at Adobe). The idea of a "Design System Package" could nicely pair with the idea of a "Custom Element Package" long term (as it hints at the ability to scale up to larger amounts of support documentation/files/etc. and the possibility of things in the "package" beyond just definitions, e.g. CSS module scripts to apply to self or parents or share, JSON module scripts, image/font assets, etc), and also points a bit to the conversation around the "Web Packaging Format" https://github.com/WICG/webpackage.
However, don't stop moving forward on my account as Manifest support much (or likely all) of the context referenced by the "Package" context as well.

Manifest sounds good to me too!

Manifest works for me!

Sounds like consensus to me :)

without having to unpack the entire tarfile.

yeah that's a huge pain-point.
So we could have something like this in the package.json?
"custom-elements-manifest": "./custom-elements.json"

I would use camelCase to keep consistency with other fields
"customElementsManifest": "./custom-elements.json"

Lets discuss the name in #29


Building with an alternative libffmpeg

Since https://github.com/electron/electron/pull/4530, Electron is using libffmpeg as a shared library (so/dylib/dll).
I'm trying to swap libffmpeg.so with one that supports a wider range of codecs, so that I can play back AC3 audio tracks from an Electron app.
Currently, the build process for this looks pretty involved
As far as I can tell, you have to modify four separate codebases:

Custom build of electron. Electron downloads libchromiumcontent from S3. You can specify your own download URL and a custom LIBCHROMIUMCONTENT_COMMIT
Custom build of libchromiumcontent. libchromiumcontent references the Chromium source tree at https://chromium.googlesource.com/chromium/src.git, as defined in vendor/chromium/.gclient. I guess you could replace this with your own fork of Chromium.
Custom build of chromium. Chromium references ffmpeg by once again referring to a git repo, which looks like it's cloned into third_party/ffmpeg. You can replace that with your own fork of ffmpeg.
Custom build of ffmpeg Finally, in your own fork of ffmpeg, you could add a new ffmpeg_branding value. The built-in values are Chrome, Chromium, ChromeOS, and ChromiumOS. I tried adding a fifth one I called CompleteCommonCodecs, which adds support for AC3.

Questions

Is there an easier way to do this, maybe using the patches folder here in libchromiumcontent?
Is it possible to do this without modifying libchromiumcontent at all, just swapping in a custom libffmpeg.so into the finished Electron build?
Has anyone else done this before?

@zcbenz @felixrieseberg @RSATom any advice much appreciated!

@dcposch, I can invite you to private slack room where you will find guys who did it already for well known torrent related project "which-name-better-not-call-in-public"
.

@dcposch, could you send me your email? I'll send you invite. my email<EMAIL_ADDRESS>

@feross, btw, I can invite you too, but don't sure if you'll like it. Guys there want get you there long time already...

@RSATom, I found these patches, in case these are what you mean:

https://github.com/kjthegod/ffmpeg/compare/b9d631d0ad277109678e86d729acc889793b4b94...master
https://github.com/kjthegod/chromium/compare/b48a69e540a7b6ed6155acfa428cd06ee8f3cbd9...master

They're off of older versions of Chromium and FFmpeg than what we're using.

I can invite you to private slack room where you will find guys who did it already for well known torrent related project "which-name-better-not-call-in-public"

Haha, you don't have to censor the name, they're not Voldemort.
Their project encourages piracy so I'd rather not work with them. Thanks for the invite though.

@RSATom I don't think there's even one person that is still working with Voldemort in there now.

I'm also pretty sure that no one is using a re-built Electron 0.37+ with extended ffmpeg support. Only the Butter guys are using NW.js with extended ffmpeg support if i'm not mistaken, but none do it with Electron atm.

@dcposch, I've talked more about Butter Project than Popcorn-Time - but it's your decision, and I respect it. So, if you would like get access to mentioned above room, just notify me, I will be glad get you there. Anyway, I respect your decision.

@jaruba, you are right, but every one should have a choice :)

@dcposch To add support for more codecs in Electron, you basically need to do 2 things:

Add a patch in libchromiumcontent to make Chromium recognize more codes, and I will be good merging it to upstream;
Replace the ffmpeg library in Electron with your own one.

Isn't it easier to use the system installed ffmpeg? I do it in my Electron package for Arch Linux by compiling Chromium with a patch from Gentoo. Then you can configure your system ffmpeg as you like.

@tensor5 if you just used the system installed ffmpeg would everything still play through the video tag?
@RSATom is butter going the route of using a modified libchromiumcontent?  I really love your library webchimera but with the headache i've had with node and native libraries I'm starting to wish I could just recompile libchromiumcontent to support more codecs.

@hadees the video tag works.

@tensor5 cool, and the video tag will work with any codex ffmpeg supports?  That does seem a lot easier.

@hadees

@RSATom is butter going the route of using a modified  libchromiumcontent ?

It depends... If you are able build ffmpeg yourself - then yes, it could give you benefits in some aspects. But most of Electron users just not skilled enough to do it.

On other side <video> tag api is limited, that's why some prefer use WebChimera.js

Hey, has there been any progress on this? I am too trying to get more / most! codecs work in the video tag and as you know this is pretty hard. I have a lot of questions

Has anyone succeeded in compiling this and distributes it somewhere?
Also @RSATom is your Slack still alive?
How does it work using the system's ffmpeg to play videos in the <video> tag?
And while I am here: Is there any decent documentation on how to compile ffmpeg / libchromiumcontent  to make Electron support more videos?

For reference, I asked the maintainers to provide a "full" ffmpeg alongside the "normal" distribution here https://github.com/electron/electron/issues/9534

Also @RSATom is your Slack still alive?
Don't know. Didn't use it long time. Better ask @luigiplr

Hey @RSATom long time no ~see~ ping, @LukasBombach it is alive yes.. however discussion regarding torrent'ing clients ended a while back. Would be happy to throw you a invite should you be interested.
A few have compiled nw.js successfully with ~full~ pretty good codec support, we ran into alot of perf problems decoding in the wild though (was a while back so i don't recall the specifics).
Have you investigated the usage of Web Chimera as an alternative?

WebChimera is almost dead, don't think it's good idea use it.

Yeah, I read that (that it's dying), very sad. In the WebChimera issues I found an alternative, but as I read in their issues, this library is also heavy on the CPU, so a "native" playback would still be much better.

I found there are some work on build chromium from customized ffmpeg  henrypp/chromium , so I extend it to libchromiumcontent.
The basic method is very similar to @dcposch's post, I'm working on it.

@jchwei  would you mind to send a PR to electron/libchromiumcontent ? It would be great to have a flag enabling whatever codecs we want from ffmpeg.

hello, after yearsssssssssssss of nwjs i still can t find a better way for this problem than live transcoding thru http pipe / ffmpeg (if canPlay fail) i still can read any video with not that much cpu (and in 2018 shitty pc have i5 so lol) i ll try to make a basic project with this one day  :p

@smolleyes did you manage to make the shuffling  work as well ?(i.e. convert byte ranges used by the browser to time ranges used by ffmpeg)

hi, dammnnn just added the dxva2 support to my ffmpeg command line and it s huge improvement ! now my nwjs app play youtube 4k videos like a breeze :D

@themihai you mean seeking ?

@jchwei is there a chance you can share your codec-enabled binaries?
@smolleyes Do you have a demo project we can learn from?
<3

hey @LukasBombach everything is in my github... streamstudio is my first project from years ago ... code is a real shit lol but still working, look at the js/ht5server.js (shame on me)... i started a small project from an electron / react boilerplate and i ll just add this system if possible (in clean es6)... when i ll have time

@smolleyes  yeah I mean seeking.

@themihai i dont have any problems with seeking :), just use the -ss option of ffmpeg

ok, so I would like to replace thelibffmpeg.so from electron with a custom one that is built for RPI with hw decoding enabled. I managed to build ffmpeg and also have an MPV player using it with plays videos super smooth in the RPI, however I am not able to build  libffmpeg.so that I can use to replace the standard one, I just get a list of .so libraries like these:
libavcodec.so
libavdevice.so
libavfilter.so
libavformat.so
libavutil.so
libswresample.so
libswscale.so
libpostproc.so

For building ffmpeg I used this flags in configure:
./configure --prefix=/usr --enable-gpl --enable-nonfree --enable-shared --enable-libtheora --enable-libvorbis --enable-omx --enable-omx-rpi --enable-mmal --enable-libxcb --enable-libfreetype --enable-libass --enable-gnutls --disable-opencl --enable-libcdio --enable-libbluray --extra-cflags="-march=armv8-a+crc -mfpu=neon-fp-armv8 -mtune=cortex-a53" --enable-libx264 --enable-libfdk-aac --enable-libmp3lame --extra-cflags="-fPIC" --enable-pic --extra-ldflags="-Wl,-Bsymbolic"

Do you guys know how to create the desired libffmpeg.so?

@LukasBombach Here is the windows x64 release .

If you want to do this the same way Electron does, see the GN build docs. Instead of building the electron target, you can build the //third_party/ffmpeg target (with your changes applied to that directory). A bit heavyweight since you'll need to check out the whole chromium repository, but it'll definitely work.
See https://github.com/electron/electron/blob/77f73830e8fea5c5acbb745985732ceff5091fce/.circleci/config.yml#L284 for how we do this in CI.

@jchwei Could you reference your build instructions, please?


XMLNotepad <IP_ADDRESS> -  21H2 Compatible

Does anyone know if XML Notepad v <IP_ADDRESS> is windows 21H2 compatible

Yep, also works on Windows 11, but I would recommend the latest version of XML notepad which is <IP_ADDRESS>

Thank you!!!!
Lori Iadevaia-Francisco
Manager, Application Development
CapAbilities CRG – Business & Operations Lead
CapAbilities Community Outreach
CVS Community Ambassador
Security Ambassador
@.***
Office:<PHONE_NUMBER>  | 1 CVS Drive, Mail Drop 1180, Woonsocket, RI 02895 |<EMAIL_ADDRESS>@.***
Security Ambassador
Visit Global Security Awareness
for the latest security news and alerts.
CVShttps://mylife.cvshealth.com/webcenter/portal/mylife/Departments/BusinessTechnology/iss/SecurityAwareness / Aetnahttps://aetna.unily.com/sites/information-security-infosec/SitePage/344074/home
CONFIDENTIALITY NOTICE: This communication and any attachments may contain confidential and/or privileged information for the use of the designated recipients named above.  If you are not the intended recipient, you are hereby notified that you have received this communication in error and that any review, disclosure, dissemination, distribution or copying of it or its contents is prohibited.  If you have received this communication in error, please notify the sender immediately by telephone and destroy all copies of this communication and any attachments.
From: Chris Lovett @.>
Sent: Thursday, May 12, 2022 2:06 PM
To: microsoft/XmlNotepad @.>
Cc: Francisco, Lori A. @.>; Author @.>
Subject: [EXTERNAL] Re: [microsoft/XmlNotepad] XMLNotepad http://<IP_ADDRESS> - 21H2 Compatible (Issue #205)
**** External Email - Use Caution ****

Yep, also works on Windows 11, but I would recommend the latest version of XML notepad which is <IP_ADDRESS>http://<IP_ADDRESS>
[Image removed by sender. image]https://user-images.githubusercontent.com/18707114/168140201-8758ffab-f348-4be0-942e-37397c782548.png
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/XmlNotepad/issues/205#issuecomment-1125281646, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZERHXPLYNLBVSDYOUTCSUTVJVCCHANCNFSM5VZBBPVQ.
You are receiving this because you authored the thread.Message ID: @.***>


Restrict datasources based on CH user

Is it possible to restrict datasources defined in the datasources folder in the bridge to specific users in the clickhouse db.

Unfortunately it's a no. This is because ClickHouse does not pass the execution context(e.g. current user, role, profile, session, query id etc.) to jdbc bridge, and it's hard for jdbc bridge to "guess" the context based on the query.

no problem I understand. Thanks for getting back to me.

Link to ClickHouse/ClickHouse#33803


Update wiki for N3

The wiki has has a release schedule that doesn't seem to have been uphold for a while now. Should we drop mentioning any time schedule to avoid failing to meet readers expectations?
The releasing page(s) now still have a special Releasing next. After releasing v5.0.0 this page should be obsolete and can be dropped. I assume the Releasing latest information becomes accurate again once the next branch is renamed to dev?

Updated wiki, removing release schedule. The release instructions are valid for  latest and should not block v5 release. We can do the clean up after the release.


error: could not compile 'oatmeal' ( bin "oatmeal") due to 2 previous errors; 1 warning emitted

Im running one oatmeal instance on my FreeBSD 14.1-RELEASE laptop and tried to compile oatmeal on my WS with FreeBSD 14.1-STABLE got two error and could not compile oatmeal.

error[E0277]: the trait bound `impl ratatui::widgets::Widget + '_: Widget` is not satisfied
   --> src/application/ui.rs:117:37
    |
117 |                 frame.render_widget(textarea.widget(), layout[1]);
    |                       ------------- ^^^^^^^^^^^^^^^^^ the trait `Widget` is not implemented for `impl ratatui::widgets::Widget + '_`
    |                       |
    |                       required by a bound introduced by this call
    |
    = help: the following other types implement trait `Widget`:
              BarChart<'a>
              Canvas<'a, F>
              Chart<'a>
              Gauge<'a>
              LineGauge<'a>
              List<'a>
              Paragraph<'a>
              Sparkline<'a>
            and 4 others
note: required by a bound in `Frame::<'_>::render_widget`
   --> /home/evo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ratatui-0.24.0/src/terminal.rs:598:12
    |
596 |     pub fn render_widget<W>(&mut self, widget: W, area: Rect)
    |            ------------- required by a bound in this associated function
597 |     where
598 |         W: Widget,
    |            ^^^^^^ required by this bound in `Frame::<'_>::render_widget`

error[E0308]: mismatched types
    --> src/domain/models/textarea.rs:12:13
     |
11   |           textarea.set_block(
     |                    --------- arguments to this method are incorrect
12   | /             Block::default()
13   | |                 .borders(Borders::ALL)
14   | |                 .border_type(BorderType::Double)
15   | |                 .title("Enter prompt")
16   | |                 .padding(Padding::new(1, 1, 0, 0)),
     | |__________________________________________________^ expected `ratatui::widgets::block::Block<'_>`, found `ratatui::widgets::Block<'_>`
     |
     = note: `ratatui::widgets::Block<'_>` and `ratatui::widgets::block::Block<'_>` have similar names, but are actually distinct types
note: `ratatui::widgets::Block<'_>` is defined in crate `ratatui`
    --> /home/evo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ratatui-0.24.0/src/widgets/block.rs:230:1
     |
230  | pub struct Block<'a> {
     | ^^^^^^^^^^^^^^^^^^^^
note: `ratatui::widgets::block::Block<'_>` is defined in crate `ratatui`
    --> /home/evo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ratatui-0.27.0/src/widgets/block.rs:67:1
     |
67   | pub struct Block<'a> {
     | ^^^^^^^^^^^^^^^^^^^^
     = note: perhaps two different versions of crate `ratatui` are being used?
note: method defined here
    --> /home/evo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tui-textarea-0.4.0/src/textarea.rs:1648:12
     |
1648 |     pub fn set_block(&mut self, block: Block<'a>) {
     |            ^^^^^^^^^

warning: variable does not need to be mutable
  --> src/configuration/config.rs:72:13
   |
72 |         let mut config_path = dirs::cache_dir().unwrap().join("oatmeal/config.toml");
   |             ----^^^^^^^^^^^
   |             |
   |             help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default

Some errors have detailed explanations: E0277, E0308.
For more information about an error, try `rustc --explain E0277`.
warning: `oatmeal` (bin "oatmeal") generated 1 warning
error: could not compile `oatmeal` (bin "oatmeal") due to 2 previous errors; 1 warning emitted

Same issues if i run --locked
Also before i got to this line i had to run cargo update due to rust  API changes  and needed to update time to other version.
This is same issue #37  and you say you pinned your dependencies in issue #33 . How can i do it ? Or update to use never version of Ratatui is on the way ?

Fixed.
After cloning git repo. cd /oatmeal
cargo update time
cargo build --release

Fixed.
After cloning git repo. cd /oatmeal
cargo update time
cargo build --release


Mlops 117 --params changes

Codecov Report

Merging #28 (c54d81e) into master (6b86c44) will decrease coverage by 0.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   73.59%   72.71%   -0.88%
==========================================
  Files          55       55
  Lines        2386     2434      +48
==========================================
+ Hits         1756     1770      +14
- Misses        630      664      +34

Impacted Files
Coverage Δ

src/wanna/cli/plugins/pipeline_plugin.py
0.00% <ø> (ø)

src/wanna/core/deployment/vertex_pipelines.py
55.55% <0.00%> (-24.45%)
:arrow_down:

src/wanna/core/services/pipeline.py
91.30% <0.00%> (-0.55%)
:arrow_down:

src/wanna/core/models/pipeline.py
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Missing description in CDS Connect artifact

I noticed that the following multimodal artifact does not include a description (https://cds.ahrq.gov/cdsconnect/artifact/neurology-traumatic-brain-injury-tbi).
If you would like to develop a description, I would be happy to copy/paste it in to the artifact.
Thanks!

@linophth Would you like to provide descriptions for the composites? IIRC this is an issue that came up during content development, and ultimately not of them were populated.

Thanks Preston and Linda.
There are only two multimodal artifacts that don't include descriptions - the TBI one and the hypoglycemia one.
https://cds.ahrq.gov/cdsconnect/artifact/endocrinology-hypoglycemia
https://cds.ahrq.gov/cdsconnect/artifact/neurology-traumatic-brain-injury-tbi

I will be happy to create descriptions for hypoglycemia and TBI.  Will you help me a little by reminding me where in the XML the descriptions are located?  It has been awhile, and I would like to review descriptions from earlier artifacts to remind myself how we framed them.  Right now I can't find them!

Thanks @linophth - The XML zipfiles for the 2 artifacts are uploaded in the Technical File section of each of the artifacts accessible via the hyperlinks above.

I don't have any trouble finding the artifacts.  As soon as somebody reminds me where in the XML artifacts to look for the descriptions then I can very quickly provide you what you need for hypoglycemia and TBI.

@linophth Sorry for the delay, I've been absorbed in related projects. :(  In KNART XML, there should always be a "description" element below (or near) the title element. For example: https://github.com/OSEHRA/vha-kbs-knarts/blob/daa237f0c1feaf7f5611d98bf76c38ed0086b8aa/content/endocrinology_hypoglycemia/b33/CDSK_KRprt_OS_B33Hypogly.xml#L25
IIRC I had done an en masse change to add this element in cases where they it was missing, but looks like some fell through the cracks. After it's changed, the various metadata files need to be updated .. I usually do that.

Hi Lee,
See my earlier email.  Neither hypoglycemia nor TBI include a composite artifact, so what artifacts are we talking about that need descriptions?
Linda Wedemeyer, MD, RN, MS
Physician Informatician, Clinical Decision Support
Clinical Informatics and Data Management Office (CIDMO)
Mobile<PHONE_NUMBER>
Los Angeles, CA
From: Preston Lee<EMAIL_ADDRESS>Sent: Friday, April 19, 2019 2:49 PM
To: OSEHRA/vha-kbs-knarts<EMAIL_ADDRESS>Cc: Wedemeyer, Linda<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [OSEHRA/vha-kbs-knarts] Missing description in CDS Connect artifact (#479)
@linophthhttps://github.com/linophth Sorry for the delay, I've been absorbed in related projects. :( In KNART XML, there should always be a "description" element below (or near) the title element. For example: https://github.com/OSEHRA/vha-kbs-knarts/blob/daa237f0c1feaf7f5611d98bf76c38ed0086b8aa/content/endocrinology_hypoglycemia/b33/CDSK_KRprt_OS_B33Hypogly.xml#L25
IIRC I had done an en masse change to add this element in cases where they it was missing, but looks like some fell through the cracks. After it's changed, the various metadata files need to be updated .. I usually do that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/OSEHRA/vha-kbs-knarts/issues/479#issuecomment-485022387, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJEGBVOEX6DLMENIDFYMAP3PRI425ANCNFSM4HESS5MQ.

@linophth , it is my understanding that the multi-modal artifacts represent the super set of "sub-artifacts" within that white paper. If an implementer chose to do so, they might implement all of the CDS expressions outlined in the white paper (e.g., the hypoglycemia order set, rule and documentation template), therefore the multi-modal artifact.
Some of the VHA multi-modal artifacts include descriptions (see https://cds.ahrq.gov/cdsconnect/artifact/mental-health-consult-depression), only 2 do not (the hypoglycemia and the TBI ones).
It would be nice to have at least 1 sentence explaining what the hypoglycemia and TBI multi-modal artifacts are.

The mental health depression consult includes a composite knowledge artifact designed to coordinate the activity of other artifacts (e.g. order set and documentation template), in this case in the context of a consult request to mental health for depression.  Not all white papers include composite knowledge artifacts, which is what we have been calling them.  The only overarching artifact artifact when there is no composite knowledge artifact is the white paper, and I did not create descriptions for any of the white papers.  I think we need Preston's input here.

@preston @linophth Thank you for clarifying that not all white papers include composite knowledge artifacts. Based on the list of artifacts available here: http://vha-kbs-knarts.healthcreek.org/, it seems that the two artifacts that I am concerned about are composite artifacts.
Table of Contents
Composites
Cardiology: Electrophysiology Consult
Mental Health: Consult for Depression
Diagnostic Breast Imaging Consult Request/Composite
Cardiology: Pre-Op Risk Assessment Composite
Endocrinology: Hypoglycemia
Neurosurgery Radiculopathy (Lumbar Thoracic)
Rheumatology: Rheumatoid Arthritis
GI: Colonoscopy
Hepatitis C
Neurosurgery Radiculopathy (Cervical)
Neurology: Traumatic Brain Injury (TBI)
Cardiology: Chest Pain (CP) / Coronary Artery Disease (CAD)
I think it would be helpful to have a very brief description for Repository viewers to understand what they are viewing when they open the artifact, in order to provide context for the remainder of the information. If it is not feasible to create a 1-2 sentence description, we can leave the artifacts as is.
Thanks for your review and consideration of this feedback

I have no idea what artifacts you are talking about that need descriptions, because neither the TBI nor the hypoglycemia artifacts include composites.
Here are the TBI KNARTS:
Neurology KNART
Associated CLIN
Traumatic Brain Injury (TBI) Screening – Event Condition Action (ECA) Rule
CLIN0003AA
Traumatic Brain Injury (TBI) Screening - Documentation Template
CLIN0005AB
Traumatic Brain Injury (TBI) Screening - Documentation Template/Consult Request
CLIN0005AB
Traumatic Brain Injury (TBI) Polytrauma Interdisciplinary Rehabilitation Clinic - Order Set
CLIN0004AA
Traumatic Brain Injury (TBI) Polytrauma Concussion - Order Set
CLIN0004AA
Traumatic Brain Injury (TBI) Rehabilitation Medicine Spasticity Clinic - Order Set
CLIN0004AA
Traumatic Brain Injury (TBI) Screening - Composite/Consult Request
N/A
Here are the hypoglycemia KNARTS:
Hypoglycemia KNART
Associated CLIN
Hypoglycemia – Event Condition Action (ECA) Rule
CLIN0003AA
Hypoglycemia – Order Set
CLIN0004AB
Hypoglycemia – Documentation Template
CLIN0005AB
Linda Wedemeyer, MD, RN, MS
Physician Informatician, Clinical Decision Support
Clinical Informatics and Data Management Office (CIDMO)
Mobile<PHONE_NUMBER>
Los Angeles, CA
From: ssebast2<EMAIL_ADDRESS>Sent: Tuesday, April 30, 2019 7:50 AM
To: OSEHRA/vha-kbs-knarts<EMAIL_ADDRESS>Cc: Wedemeyer, Linda<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [OSEHRA/vha-kbs-knarts] Missing description in CDS Connect artifact (#479)
@prestonhttps://github.com/preston @linophthhttps://github.com/linophth Thank you for clarifying that not all white papers include composite knowledge artifacts. Based on the list of artifacts available here: http://vha-kbs-knarts.healthcreek.org/, it seems that the two artifacts that I am concerned about are composite artifacts.
Table of Contents
Composites
Cardiology: Electrophysiology Consult
Mental Health: Consult for Depression
Diagnostic Breast Imaging Consult Request/Composite
Cardiology: Pre-Op Risk Assessment Composite
Endocrinology: Hypoglycemia
Neurosurgery Radiculopathy (Lumbar Thoracic)
Rheumatology: Rheumatoid Arthritis
GI: Colonoscopy
Hepatitis C
Neurosurgery Radiculopathy (Cervical)
Neurology: Traumatic Brain Injury (TBI)
Cardiology: Chest Pain (CP) / Coronary Artery Disease (CAD)
I think it would be helpful to have a very brief description for Repository viewers to understand what they are viewing when they open the artifact, in order to provide context for the remainder of the information. If it is not feasible to create a 1-2 sentence description, we can leave the artifacts as is.
Thanks for your review and consideration of this feedback
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/OSEHRA/vha-kbs-knarts/issues/479#issuecomment-487982860, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJEGBVLMM7M5M4HRZPY4UDDPTBMBXANCNFSM4HESS5MQ.

@linophth, @preston The Hypoglycemia artifact was uploaded to the Repository as a Composite artifact. https://cds.ahrq.gov/cdsconnect/artifact/endocrinology-hypoglycemia (see the XML file attachment named "Composite Artifact"). The same is true for the TBI multi-modal artifact (https://cds.ahrq.gov/cdsconnect/artifact/neurology-traumatic-brain-injury-tbi).
It might be best as this point to leave things as is, but moving forward, we will adjust how we approach multi-modal artifacts.
Thanks for your engagement on this concern.

Preston can you explain this?  There is no composite artifact for hypoglycemia.
From: ssebast2<EMAIL_ADDRESS>Sent: Tuesday, April 30, 2019 1:11 PM
To: OSEHRA/vha-kbs-knarts<EMAIL_ADDRESS>Cc: Wedemeyer, Linda<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [OSEHRA/vha-kbs-knarts] Missing description in CDS Connect artifact (#479)
@linophthhttps://github.com/linophth, @prestonhttps://github.com/preston The Hypoglycemia artifact was uploaded to the Repository as a Composite artifact. https://cds.ahrq.gov/cdsconnect/artifact/endocrinology-hypoglycemia (see the XML file attachment named "Composite Artifact"). The same is true for the TBI multi-modal artifact (https://cds.ahrq.gov/cdsconnect/artifact/neurology-traumatic-brain-injury-tbi).
It might be best as this point to leave things as is, but moving forward, we will adjust how we approach multi-modal artifacts.
Thanks for your engagement on this concern.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/OSEHRA/vha-kbs-knarts/issues/479#issuecomment-488097443, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJEGBVLTU5QU3YWZDUOU3TDPTCRVLANCNFSM4HESS5MQ.


Adding 2.4.2 to the matrix

This did not result in what I was expecting. I'll file an issue to address my specific issue.


Get-RsCatalogItemRole when used on a non-local server is unable to bind policy parameter

While doing some testing of Get-RsCatalogItemRole between two servers that can see each other, I noticed that while running the cmdlet locally, there was not an error, but when it was used with -ReportServerUri to another server, it returned the output, but still complained.  Please see attachment.

Thank you.

Top image is running command from SSRSTEST01 against http://SSRSTEST02/reportserver
Bottom image is running command on SSRSTEST01 against itself.

From a cursory look from the code either this line didn't get any policy
https://github.com/microsoft/ReportingServicesTools/blob/ffe49b6f1e7dde68503ce94a3ffc87b76d9341c5/ReportingServicesTools/Functions/Security/Get-RsCatalogItemRole.ps1#L95
or this line didn't find any policy that match the user
https://github.com/microsoft/ReportingServicesTools/blob/ffe49b6f1e7dde68503ce94a3ffc87b76d9341c5/ReportingServicesTools/Functions/Security/Get-RsCatalogItemRole.ps1#L99
It will require debugging and if it is an issue a PR with the fix, I would like to invite you to contribute to it

After more testing, it has nothing to do with the use of the -ReportServerUri parameter; it's tied to the use of -Recurse value.  I will look at the code, but since -Path is a FALSE requirement parameter, the code is most likely defaulting to / for any recursiveness.  In my test scenarios, I am pulling out rights at a higher level folder to demonstrate the surgical precision of the Grant-RsCatalogItemRole cmdlet.
How would you classify this?  It's not necessarily a bug, but the error message is misleading.  As you can see from my attached images, I was able to remove the error message by adding back in rights on the higher level folder.
When I put in the -PATH parameter, tellling Get-RsCatalogItemRole where to start, then it did not report an error.

It fits in the enhancement category, the cmdlet could report that there is not policy for the user in the specified path

Is that something I can do with a PR?
Get Outlook for Android
On Fri, Sep 27, 2019 at 9:13 AM -0700, "Jaime Tarquino"<EMAIL_ADDRESS>wrote:
It fits in the enhancement category, the cmdlet could report that there is not policy for the user in the specified path
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

you could add a  Write-Verbose if the  $parentPolicy is null showing up that there is not policy matching


update arc-swap to latest

fix #207

1.2 is latest https://github.com/vorner/arc-swap/blob/master/CHANGELOG.md

1.2 is latest https://github.com/vorner/arc-swap/blob/master/CHANGELOG.md

@estk current pin equals "^1.0" which can be resolved to "1.2".

@estk current pin equals "^1.0" which can be resolved to "1.2".

@estk Could you recheck this PR? I have been a while.

Hi @shuoli84 and @zonyitoo,
I should have been more direct with my original comment, sorry for that. As a policy, I never knowingly specify a yanked version of a crate<EMAIL_ADDRESS>was yanked and therefore this PR would violate said policy.
Technically you are correct @shuoli84 that 1.0 is resolved to 1.2, but it begs the question: if we know 1.0 is yanked and we mean that log4rs should depend on 1.2, why wouldn't we just say that? Also, I don't fully understand cargo's strategy wrt. version caching and if there may be an edge case there. Finally, and least importantly specifying a yanked version of a crate especially one with a soundness bug seems like a poor defensive security strategy. Why would we potentially open us or our users up to that?
Is there any reason not to just specify "1.2"?

Well, maybe you could just modify it directly.

@estk I thought the lib can just pin to relative wider version because some other libs may pinned to explicit version, then just let cargo pick the right one. Arc-swap 1.1 has soundness issue which makes pin to 1.2 more reasonable, I didn't aware this. Thanks for pointing that out. 👍

Great. Looking forward for publishing.

@zonyitoo any reason for the rush? I'm happy to expedite the next release if it's blocking you on something.

There is no rush at all, except that there were 2 different arc-swaps in my project, which is just annoying.

Haha, I know how that is. In the next week or so I'll try to see if there
is anything else ready to go out.
Best,
Evan
On Wed, Mar 24, 2021 at 6:57 PM ty @.***> wrote:

There is no rush at all, except that there were 2 different arc-swaps in
my project, which is just annoying.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/estk/log4rs/pull/208#issuecomment-806302762, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAC7HSXTRALLIQVKKFJC26LTFKKAPANCNFSM4WAQCYPA
.


Question :- Total number of connections per gateway and business worker

Hi Walkor,
How can we find out how many clients are connected to each Gateway and Business Worker.
Thanks
Abhinav

I tried Gateway::getAllClientIdCount() but it giving me the all gateways connections count

Hi Walkor,
I also need the answer.

Ok. Actually I am working on system monitor to show the number of connection in each gateway. So how can we get the number of connection in each gateway.

You can refer to Gateway::getAllClientIdCount to implement the interface you need.


Average of frames over ROI

Ease of use: Select single frame with click in image, without clicking on extra button

Should we actually defer the rest of this ticket (average over ROI) to 0.2?

Yes, I'd say so. 👍On Aug 8, 2018 15:53, Alexander Clausen<EMAIL_ADDRESS>wrote:Should we actually defer the rest of this ticket (average over ROI) to 0.2?
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

This is now implemented, starting with a disk-shaped ROI


enhancement: update noDataComponent, and fix colspan for the externalLoadingComponent

I would want that when there is no data to display, the table will still show with a custom component inside just like the externalLoadingComponent.
Also theres a wierd thing with the externalLoadingComponent colspan, it only spans the entire table when useGriddleStyles={true}, i think the defaulsColSpan should be the same even if i dont use griddle styles.
These are some easy additions that would benefit me alot, if i have missed something and it is possible to do those things now please tell me how.

Hi,
I have the same issue with the loading component not being centered when useGriddleStyles is set to false.
Having the defaultColSpan set outside the if statement also works for me (in gridTable.jsx:231).
Thanks for the great work!
Sajoscha

Hi and sorry about the extreme delay in getting back with a response on this one! We've recently released Griddle 1.0 -- the customization options in Griddle 1.0 should make this no longer an issue. Please feel free to open a new issue if there are any problems that are encountered. :+1:


Bump rails <IP_ADDRESS> -> <IP_ADDRESS>

We pick up bumps in the other rails gems, which gets us some security
fixes:

activestorage: CVE-2020-8162
actionpack: CVE-2020-8164
activesupport: CVE-2020-8165
actionview: CVE-2020-8167

The other gem bumps are minor

Eagerly merging since these are all minor/patch bumps.


Install deb packages automatically

Using latest version of Eget on Ubuntu 21.10.
❯ eget --asset=deb --asset=amd64 cli/cli
https://github.com/cli/cli/releases/download/v2.11.3/gh_2.11.3_linux_amd64.deb
Downloading 100% [======================] (7.7/7.7 MB, 44.170 MB/s)
Extracted `gh_2.11.3_linux_amd64.deb` to `gh_2.11.3_linux_amd64.deb`

In this scenario, it would be nice if Eget could automatically do the equivalent of sudo dpkg -i ./gh_2.11.3_linux_amd64.deb && rm ./gh_2.11.3_linux_amd64.deb.
Cheers

I for one would not want the install to happen, since I don't have sudo access on the box. I always download tarballs to avoid that. But this could go behind a feature flag.

Debs aren't the only package format to be supported, prolly better to generalize this with a list of delegates to be invoked (eg. rpm, appimage, flatpak, etc.)

I’m not sure there should be a special flag for automatically running package installers. You can use stdout to do this with something like eget -q -a .deb -a amd64 cli/cli —to /dev/stdout | sudo dpkg -i /dev/stdin

@zyedidia Your suggestion doesn't work: pkg: error: archive '/dev/stdin' is not a regular file (https://askubuntu.com/a/170441)

Ah alright, I guess you'll have to create a temporary file: eget -q -a .deb -a amd64 cli/cli --to /tmp/cli.deb && sudo dpkg -i /tmp/cli.deb


max filter breaks animated gifs

Issue Summary
Uploading a gif (this one in particular):
breaks wagtail /admin/images route.
The error is fun, this line https://github.com/emcconville/wand/blob/4fe2c6ba9cb0d4105361cea6e9e9e83116080473/wand/image.py#L1501 gets two different values, 421and 420, raising an error in _abs function.
I am not sure whether this comes from Wagtail or Wand, and I would like some help to track this down.
Fix : There is a fix for this issue : replacing max by fill here helps get rid of it https://github.com/wagtail/wagtail/blob/main/wagtail/images/templates/wagtailimages/images/results_image.html#L18
Steps to Reproduce

Add Wand to your wagtail project to support animated gifs
In wagtail admin, go to http://localhost:8000/admin/images/multiple/add/ and upload the gif
Go to http://localhost:8000/admin/images/
Enjoy 🍿

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes, on https://github.com/wagtail/docker-wagtail-develop I added Wand as a dependency, and the error occurs.

Traceback below if it can be of any help
Environment:

Request Method: GET
Request URL: http://localhost:8000/admin/images/

Django Version: 3.2.10
Python Version: 3.8.12
Installed Applications:
['bakerydemo.base',
 'bakerydemo.blog',
 'bakerydemo.breads',
 'bakerydemo.locations',
 'bakerydemo.search',
 'wagtail.contrib.search_promotions',
 'wagtail.contrib.forms',
 'wagtail.contrib.redirects',
 'wagtail.embeds',
 'wagtail.sites',
 'wagtail.users',
 'wagtail.snippets',
 'wagtail.documents',
 'wagtail.images',
 'wagtail.search',
 'wagtail.admin',
 'wagtail.api.v2',
 'wagtail.contrib.modeladmin',
 'wagtail.contrib.routable_page',
 'wagtail.core',
 'rest_framework',
 'modelcluster',
 'taggit',
 'wagtailfontawesome',
 'debug_toolbar',
 'django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'django.contrib.sitemaps']
Installed Middleware:
['debug_toolbar.middleware.DebugToolbarMiddleware',
 'django.middleware.security.SecurityMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'wagtail.contrib.redirects.middleware.RedirectMiddleware']

Template error:
In template /code/wagtail/wagtail/images/templates/wagtailimages/images/results_image.html, error at line 18
   421 > 420
   8 :  This behaviour caused a confusing error on the images listing view where it
   9 :  would go blank if one of the images was invalid.
   10 :
   11 :  Separating the image rendering code into this file allows us to limit Django's
   12 :  crash/blanking behaviour to a single image so the listing can still be used when
   13 :  the issue occurs.
   14 : {% endcomment %}
   15 :
   16 : {% load wagtailimages_tags %}
   17 :
   18 : <div class="image"> {% image image max-165x165 class="show-transparency" alt="" %} </div>
   19 :

Traceback (most recent call last):
  File "/code/wagtail/wagtail/images/models.py", line 307, in get_rendition
    rendition = self.renditions.get(
  File "/usr/local/lib/python3.8/site-packages/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/django/db/models/query.py", line 435, in get
    raise self.model.DoesNotExist(

During handling of the above exception (Rendition matching query does not exist.), another exception occurred:
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 204, in _get_response
    response = response.render()
  File "/usr/local/lib/python3.8/site-packages/django/template/response.py", line 105, in render
    self.content = self.rendered_content
  File "/usr/local/lib/python3.8/site-packages/django/template/response.py", line 83, in rendered_content
    return template.render(context, self._request)
  File "/usr/local/lib/python3.8/site-packages/django/template/backends/django.py", line 61, in render
    return self.template.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 170, in render
    return self._render(context)
  File "/usr/local/lib/python3.8/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/loader_tags.py", line 150, in render
    return compiled_parent._render(context)
  File "/usr/local/lib/python3.8/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/loader_tags.py", line 150, in render
    return compiled_parent._render(context)
  File "/usr/local/lib/python3.8/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/loader_tags.py", line 150, in render
    return compiled_parent._render(context)
  File "/usr/local/lib/python3.8/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/loader_tags.py", line 62, in render
    result = block.nodelist.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/loader_tags.py", line 62, in render
    result = block.nodelist.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/loader_tags.py", line 195, in render
    return template.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 172, in render
    return self._render(context)
  File "/usr/local/lib/python3.8/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/defaulttags.py", line 312, in render
    return nodelist.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/defaulttags.py", line 211, in render
    nodelist.append(node.render_annotated(context))
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/loader_tags.py", line 195, in render
    return template.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 172, in render
    return self._render(context)
  File "/usr/local/lib/python3.8/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/code/wagtail/wagtail/images/templatetags/wagtailimages_tags.py", line 107, in render
    rendition = get_rendition_or_not_found(image, self.filter)
  File "/code/wagtail/wagtail/images/shortcuts.py", line 13, in get_rendition_or_not_found
    return image.get_rendition(specs)
  File "/code/wagtail/wagtail/images/models.py", line 321, in get_rendition
    generated_image = filter.run(self, BytesIO())
  File "/code/wagtail/wagtail/images/models.py", line 476, in run
    willow = willow.crop(transform.get_rect().round())
  File "/usr/local/lib/python3.8/site-packages/willow/plugins/wand.py", line 87, in crop
    clone.image.crop(left=rect[0], top=rect[1], right=rect[2], bottom=rect[3])
  File "/usr/local/lib/python3.8/site-packages/wand/image.py", line 1089, in wrapped
    result = function(self, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/wand/image.py", line 1098, in wrapped
    result = function(self, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/wand/image.py", line 4490, in crop
    bottom = abs_(bottom, self.height)
  File "/usr/local/lib/python3.8/site-packages/wand/image.py", line 4472, in abs_
    raise ValueError(repr(n) + ' > ' + repr(m))

Exception Type: ValueError at /admin/images/
Exception Value: 421 > 420

Technical details

Python version: 3.8.12
Django version: 3.2.10
Wagtail version: 2.15.1

We have also just run into this and can largely confirm your report. We're experiencing the error with (so far):

Animated gif, 450x253, 328 KB
Animated gif, 450x252, 327 KB
Static gif, 450x252, 57 KB

I can also confirm that your suggested fix works, though I am not sure what side effects it may have.

First side-effect that comes to mind is that it will display a cropped image when max would preserve original ratio

Additional data points from trying different aspect ratios:

Didn't work: animated gif, 450x368, 766 KB
DID work: animated gif, 500x409, 486 KB

No clue why the 500px one worked but none of the ones at 450px have worked.

Let's focus on the issue at hand. The error comes from somewhere in https://github.com/wagtail/wagtail/blob/main/wagtail/images/image_operations.py#L264-L272 called via https://github.com/wagtail/wagtail/blob/main/wagtail/images/models.py#L479-L480

Yeah, I'm looking suspiciously at that .round() on https://github.com/wagtail/wagtail/blob/main/wagtail/images/models.py#L480

@cb109 And the image chooser results.html as well?

@cb109 And the image chooser results.html as well?

yes, clicking "Choose an Image" will only open the modal when I replace max- with fill- in the template you posted.

For assistance in further investigations, here are the gifs I referenced in my earlier comments. Unsure if GitHub does any processing on upload, though, so I also attached a ZIP of them.

animated_450x253_328k
animated_450x252_327k
static_450x252_57k
animated_450x368_766k
animated_500x409_486k_WORKS

scotchester_test_gifs.zip

Proposed fix in https://github.com/wagtail/Willow/pull/92, but we should also adhere to the "be conservative in what you send" half of Postel's Law and fix the rounding error that causes us to pass an out-of-bounds crop rectangle to Willow.

OK, this turns out to be quite hairy...

The max-165x165 filter is translated to a MinMaxOperation instance
MinMaxOperation.run calculates the appropriate final size for the image, with both dimensions rounded to integers, and passes this to ImageTransform.resize
ImageTransform.resize reverses the calculation MinMaxOperation just did to get an X and Y scale factor, which is how ImageTransform represents scale operations internally. (Note: even though this resize operation is supposed to preserve aspect ratio, the integer rounding in the previous step means that the X and Y factors are liable to end up slightly different. I think this detail is a red herring though...)
The Filter object managing this whole process then calls willow.crop(transform.get_rect().round()).
transform.get_rect() calculates the crop rectangle to apply to the original image, by multiplying the target size by the scale factors. Since the max filter doesn't do any cropping, this should just return the original image size. However, this unnecessary division and multiplication causes floating point inaccuracies to creep in, and the result is in some cases infinitesimally larger. Taking the original 640x420 image from this issue as input, the resulting rectangle is Rect(left: -0.0, top: -0.0, right: 640.0, bottom:<PHONE_NUMBER>0000006)
Rect.round() rounds the dimensions up - presumably to avoid zero-sized images - resulting in Rect(left: 0, top: 0, right: 640, bottom: 421)
Finally, this is passed to Willow to perform a crop operation on the image. (There's no check to see if a crop is actually needed, so even if we did get the calculations right, this would be totally redundant...) Pillow is happy to handle a crop rectangle larger than the original image, but Wand (which is used for animated gifs) fails.

Have now released Willow 1.4.1 which fixes this - will open a new lower-priority ticket for addressing the underlying rounding error issue.


Fix TypeError when some timestamps of items in NodePool._dead_nodes are not unique

Makes node objects comparable by overriding the < operator on the BaseNode class.
Fixes #114

Hello, closing for now as you haven't signed the CLA, sorry. Feel free to reopen when you have.

Hey, I tried to sign it before but it looks like something went wrong.
Is there an issue if I sign it using the Github generated email I used to commit the changes with?

Thanks! Reopened.


set :rsync?

Hi,
When you include your gem, I imagine it will always assume rsync, but it would be better to give us the option in our capfile to use it or not e.g.
set :scm, :rsync

Rsync is not The SCM.


Shapefile building source has lat & lon flipped

See Slovenia buildings wrongfully plotted into Yemen:

Source: https://github.com/openaddresses/openaddresses/pull/5907
Shapefile data: https://raba.openstreetmap.si/openaddresses/si-buildings-latest.zip has correct positions
Job: https://batch.openaddresses.io/job/210651

Related:

Example: https://github.com/openaddresses/openaddresses/pull/5907
Similar issue for CSV: https://github.com/openaddresses/batch/issues/90
Fix for CSV #25

Progress

2022-02-09: Confirmed that input data looks good
2022-02-09: Confirmed that output data is flipped


Is there a way to trigger the animation manually while autoplay is false?

Hi, I've been trying to find a way to trigger the animation manually based on some conditions, but it looks like the only way to get a reference to the animation instance is through one of the begin, update or complete callback functions, and they all require the autoplay prop to be true to trigger. Is there any way that we can get the animation instance when the component mount?

dude, you are using react, change autoplay={true|false} whenever you need it

To be fair that's a pretty poorly named prop.

Changing autoplay to true|false does not work as intended for me. Changing this, removes all children on the Anime component


The inspector not work if run with option "--debug-brk"

origin question is here: http://stackoverflow.com/questions/29371262/what-is-the-difference-between-node-debug-index-js-and-run-node-inspector-th
If run node with --debug-brk to attach to the inspector, then I could not set breakpoints and debugger being ignored.
But if use node --debug, then the inspector works perfectly. :)
The problem appears in osx 10.10.2.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10295907-the-inspector-not-work-if-run-with-option-debug-brk?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github).

What is your Node.js version? There is a known issue #534 that --debug-brk does not work correctly in Node v0.12 and io.js 1.x.

my node is v0.12 :O
sorry for the duplicate issue :)
在 2015年4月1日 下午3:24:19, Miroslav Bajtoš<EMAIL_ADDRESS>写到:
What is your Node.js version? There is a known issue #534 that --debug-brk does not work correctly in Node v0.12 and io.js 1.x.
—
Reply to this email directly or view it on GitHub.

No worries, I am closing this as a duplicate then.


Cursor type is not pointer when hover on toggle-settings-button

Issue type
I'm submitting a ...  (check one with "x")

[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Issue description
Current behavior:

When hovering on toggle-settings-button the cursor remains the default one.
Expected behavior:

The cursor should be a pointer to indicate a call to action
Steps to reproduce:

Go to /pages/dashboard for example (or whatever page) the toggle-settings-button is on the right in green
Related code:

insert short code snippets here

Other information:
npm, node, OS, Browser
Chrome, FF

**Angular, Nebular**

Many other buttons also have this "wrong" behavior. It seems that the Css Nebular theme is overiding the original behavior of buttons in Bootstrap. Is it a choice not to show a pointer?

Closed as fixed


[9.x] Adds package argument to vendor:publish command

This pull request introduces a few changes to the vendor:publish command.

So, if this pull request gets merged, to get started, when users type php artisan vendor:publish, they will be asked to select a package, instead of selecting a provider class:

As you can see, I've added a small description next to the package name, and the description contains details of the files that will be published. In addition, the user can enjoy nice autocompletion while selecting the package:

Next, once the user selects the package, he will be able to select which files (tags) he wish to publish:

But of course, if there is 1 or 0 tags, we will publish everything of that package.

Now, this pull request also adds the new argument package that users may use to specify the package directly. Yet, we will question the user about the tags, if the user don't specify it via the --tag option:

Next, the user may combine the argument package with the --all option, to publish everything related to the given package:

Finally, it's important to keep in mind that there is no breaking changes - and previous options work on the same way:

Looks very nice, what if..
[1] spark-config config/spark.php
If numeric use index, else use autocomplete

Great addition @nunomaduro
What if, instead of creating the package name, you can just choose the number based on the package index?

Really great work once again @nunomaduro 🙏

How about “checkboxes” for multiple selection ?

How about “checkboxes” for multiple selection ?

@renoki-co mentioned comma separate on twitter.. thought that would be pretty cool. config, views

@dillingham @robsontenorio @nunomaduro Yeah, pretty much selecting more would be useful. It works when deploying Sail assets 🤔 I think this can be a good way to specify more comma-separated values to avoid re-running the command for each number.

@taylorotwell done.


style: throw exception if cache directory is not created

Sorald is unable to run on repairnator CI. I will push commits here and release SNAPSHOT versions and then ~ask @Sofi1410 to trigger the CI until the issue is fixed~ push commits here to trigger CI.

The problem seems to be resolved now. See https://ci.eclipse.org/repairnator/job/repairnator-ci/job/PR-1256/31/.


Fix rms-set-scales function to make it work with sass 3.4

Quoting sass backwards incompatibilty change in 3.4.0:
"All variable assignments not at the top level of the document are now local by default.
If there’s a global variable with the same name, it won’t be overwritten unless the
!global flag is used. For example, $var: value !global will assign to $var globally.
This behavior can be detected using feature-exists(global-variable-shadowing)."
@see http://sass-lang.com/documentation/file.SASS_CHANGELOG.html
@see http://stackoverflow.com/q/27706643/1026660

Thanks for the PR :) Could you also update the Gem dependencies to specify Sass 3.4+ and Compass 1.0+?

Sure ! Done, I updated the versions.

Awesome, thank you!


NIFI-2495: Ensure that we always close Index Searchers when we're fin…

…ished with them

I ran the "testModifyIndexWhileSearching" test on Windows and it successfully ran when using this PR.


Searching a blog with many posts and tags is painfully slow

Chrome locks up when I initiate a search through the admin UI, sometimes for 30+ seconds (the issue is significantly worse on my laptop). The blog has around 130 posts, with each post having up to 20 tags.
Looking at a Chrome timeline of the issue, it seems to be to do with observing an array and performing many dom manipulations. resulting is an awful lot of layout thrashing. I would expect all the work to be done with the DOM nodes being added to a document fragment which is added when it's ready.
Here's a screenshot of the timeline after searching for "l":

I'm on Ghost 0.7.5.

Hey @Tyriar, are you sure you're on 0.7.5? Your timeline looks like it's showing code paths that were removed in that release in order to fix this issue.
To be sure you click visit http://yourblog.com/ghost/about which will list the currently running version.

@kevinansfield Ah I'm 0.7.3 actually, didn't know about the about page so I looked at DigitalOcean's droplet version which must have been updated shortly after deploying. I'll upgrade, thanks!


localhost:8080 get 404 page not found after installation in Ubuntu

Hi, after following the installation instruction for Ubuntu (I'm using Ubuntu 20.04) without any outstanding error, I got 404 page not found after opening Chrome browser and going to localhost:8080. Any idea why this might happen, or anything I have overlooked? Thank you in advance for any help!

The issue is solved after close and restart the terminal somehow

For anyone else that finds this issue, the cause is setting CVAT_HOST variable properly; if you set the variable wrong, it gives you an undescriptive 404 error, but if you restart the terminal like described above, it unsets CVAT_HOST causing it to default to the behavior of using localhost.


RYA-342 RYA-321 Added documentation on the shell and PCJ Updater

Description
Added documentation on the shell and PCJ Updater
Tests
N/A
Links
Jira RYA-342
Jira RYA-321
Checklist

[ ] Code Review
[ ] Squash Commits

People To Reivew
@meiercaleb
@amihalik
@pujav65

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/482/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/494/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/502/


docs(readme): add chore into README

Also testing title

@xmnlab can you take a look into the project to see if you find any improvements to do? thanks!

note: dist dir is automatically generated by TypeScript


392 - Fixed migrations Issues in Model Program

Fixed migrations issues by removing datetime.now() as default value for release_date in models.py
Fixed metadata populating error in edit mode
Cleaned old/unused code

@Castronova - bringing this in with the understanding that follow on work may need to be done. It looks to resolve the always generate a new migration file issue which is good.
Will subsequently check migrations and squash what it possible to squash following this merge


Add S.both function

I've chosen to only implement the both part of #102 for the moment just to get a feel for what's expected. The examples I've given in the docs are pretty contrived because there's really only S.test that returns a boolean. I could have used something like R.has but I wasn't sure what the policy of including Ramda functions in the docs was or even defining a custom function at the head of the S.both docs. I'll squash everything down to one commit at the end of code review.

All done. :)

Is there something up with Github? I'm seeing some line notes in email but when I look in the browser they're not there.

Reveal the hidden diff comments. ;)

Aha. :mag:

We should close this in favour of the lift approach.


better scaling

This change uses a scaled window size with a fix logical screen size in order to let Ebitengine do a better scaling.
Updates #24
Updates hajimehoshi/ebiten#2951

Can confirm this fixes the issue for both scale 1

and fractional values

This PR focues on a rendering quality and doesn't resolve the issue at https://github.com/hajimehoshi/ebiten/issues/2951.

This PR focues on a rendering quality and doesn't resolve the issue at hajimehoshi/ebiten#2951 yet.

Oh, makes sense then


Many to Many Relationships

It's not clear to me how to handle many-to-many relationships in the module builder. I have a number of junction tables in my database. The EF6 database-first behavior would be to generate virtual lists of child elements automatically and hide the junction tables. How is this done in entityworker?

It all depends on how you design your class, fallow this example https://dzone.com/articles/how-to-handle-a-many-to-many-relationship-in-datab
give me more information on what you want.
and also have a look at https://github.com/AlenToma/LightData.CMS/blob/master/source/LightData.CMS.Modules/Library/Menus.cs

To be more specific, I have an existing database with a number of junction tables to handle many-to-many relationships, e.g.,
Extisting database tables:
Class1
Class2
Class1_Class2 (which is a junction table with foreign key columns Class1_ID and Class2_ID)
Desired Entity mapping:
public Class1
{
  [PrimaryKey]
  public long ID {get;set;}

  [IndependentData]
  public List<Class2>{ get; set; }
}
public Class2
{
  [PrimaryKey]
  public long ID { get; set; }

  [IndependentData]
  public List<Class2>{ get; set; }
}

I may be missing it, but I don't see anything in the EntityWorker examples illustrating a similar relationship.

no your are right. you have to create a new class and call it class1Assignment that will look like this fo example
public class class1Assignment {
[PrimaryKey]
public long ID{get; set;}
[ ForeignKey(typeof(Class1))]
public long Class1Id {get; set;}
[ ForeignKey(typeof(Class2))]
public long class2Id {get; set;}
public class1 class1{get; set;}
}
now in class 1 you will have a list of class1Assignment
public Class1
{
[PrimaryKey]
public long ID {get;set;}
//  [IndependentData]
public List{ get; set; }
}
this is one way the other way is that you add a fogenkey in class2 thet refer to class 1. and no need to change class 1

I forgat to show how class2 should look like
public class class2
{
[PrimaryKey]
public long ID{get; set;}
[ ForeignKey(typeof(Class2), "class2List")]
public long class2ParentID {get; set;}
public list class2List{get; set;}
}

Added Many to Many Relationships Sektion to show how this work


fix(tooltip): remove tooltips when element destroyed with event='hover'

I have a list of recent files in the Electron version of my app that changes when the contents of the file system do, and I found that when a file disappeared at the same time that I had a hover tooltip visible for it, that tooltip got stuck onscreen. This appears to fix the problem. I tried to create a unit test for it but found some very strange behavior:

The setTimeout functions used on the existing tests are never called. It seems as though they should be using Jasmine's done() mechanism to force the test to wait for the timeout function.
When I tried doing this, or creating a test for hover by calling timeout.onMouseEnter() and timeout.onMouseLeave(), calling expect(tooltip.tooltipElement).toBeUndefined() caused the browser to hang.

please rebase on master


High CPU usage/memory leak in Joplin 2.13.5

For some reason the plugin seems to continuously use CPU and increase memory usage when installed on 2.13 or 2.14 at least on macOS Sonoma 14.3 Intel. This is the only installed plugin. I have ~500 notes in Joplin.

Thank you for the report @runrunrirun!
Do you have additional info on the following?

Is the high CPU + memory happen transiently? Does it happen only on a specific action or does it persist?
Is high CPU + memory usage evident when Joplin is started? Or does it take some time for the performance to degrade?
Would you be willing to share your Joplin vault privately to help with troubleshooting this issue?

There was an infinite loop that can occur when there are a lot of notes for a single day. (Caused by pagination logic that didn't actually increment the page). #19 may fix the performance issues seen here.

Missed the earlier post, sorry! But it appears to be fixed now, tested in Joplin 2.14.16, memory and CPU use are now stable with this plugin active, thanks!


Missing upcoming events.

There should be events on

Feb 4th
March 4th
April 1st (April fools, lol)
etc.

Right?

Yes. Generally I like to include an agenda, but we can post them in advance and then update the event with the agenda later.

The Feb 4th event is here BTW: https://rushstack.io/community/event/?id=11


Clear up master vs 3.0 vs 4.0 branch vs.  branch-alias for Neos.Form

It's a mess:

Ok, not as bad as I thought, but still the alias is wrong, since we have 4.0.1 out already, so master would need to be 4.0.x. And we never had 3.0.0. Oh… sigh.

Ok, those branches are gone already. Leaves only the branch alias to be fixed. Yay!


lsm: Forcibly relabel all initial state

This is attempting to handle the "install selinux-enabled target from selinux-disabled host". We're kind of papering over effectively ostree design bugs here as in this case libostree itself should be setting the labels, but doing that is a bit hard and awkward right now.

This seems like a good idea to me, but I'm not sure I have a good enough grasp of all the moving parts to ack it :) Also, is there any testing that would cover this, or does the current test suite passing inherently prove it doesn't break things?
Not sure what's up with the failing test, those look like rust errors.

Not sure what's up with the failing test, those look like rust errors.

Just to explain this a bit...the bootc install is a cargo feature that can be disabled.  Basically some operating systems/distros may have their own installer and don't want to support bootc carrying its own.
(That said increasingly I'm thinking at least bootc install-to-filesystem should always be on...but bootc install-to-disk is way more opinionated and something that one might want to replace)

Actually forgot I'd started on this one here.  This is obsoleted by https://github.com/containers/bootc/pull/397


Added missing libengine-pkcs11-openssl dependency

Ahhh yeah, that makes sense - sorry about that!


Add an ACKNOWLEDGEMENTS property to SCHEMA

A free-text field where people can put credit or funding source or other thoughts.

More generally, we will need to make sure we have all the necessary canonical properties for citation of the schema.

The acknowledgments property is in paleobot/pbot-api@449acb69a395fe0723d2ae127e76dd762f8276f3 and paleobot/pbot-client@bc9794aec9decf3d3dc16145c1dff1214354c1a2.
See what I did there?