xgb.importance fails

I've been using xgb.importance for a model, but after some feature tweaking, the function failed. The model file is enclosed -- I believe that this code snippet should reproduce the error:
model = xgb.load(unzipped_model_file)
xgb.importance(model)

This code gives me the following error:
Error in `[.data.table`(td, isLeaf == FALSE, `:=`((branch_cols), { :
  Supplied 9936 items to be assigned to 9937 items of column 'Feature'. If you wish to 'recycle' the RHS please use rep() to make this intent clear to readers of your code.

With the following traceback
4: `[.data.table`(td, isLeaf == FALSE, `:=`((branch_cols), {
       matches <- regmatches(t, regexec(branch_rx, t))
       xtr <- do.call(rbind, matches)[, c(2, 3, 5, 6, 7, 8, 10),
           drop = FALSE]
       xtr[, 3:5] <- add.tree.id(xtr[, 3:5], Tree)
       as.data.table(xtr)
   }))
3: td[isLeaf == FALSE, `:=`((branch_cols), {
       matches <- regmatches(t, regexec(branch_rx, t))
       xtr <- do.call(rbind, matches)[, c(2, 3, 5, 6, 7, 8, 10),
           drop = FALSE]
       xtr[, 3:5] <- add.tree.id(xtr[, 3:5], Tree)
       as.data.table(xtr)
   })]
2: xgb.model.dt.tree(feature_names = feature_names, text = model_text_dump,
       trees = trees)
1: xgb.importance(model = model)

Any guidance you can provide would be extremely helpful! Apologies if this is obvious user error.
season_xgb_no_adv.zip

Hi, which xgboost version are you using?

Hello! I'm using <IP_ADDRESS>

I have reproduced it in 1.3 but I think it's fixed in 1.5.  Feel free to reopen if the problem persists on 1.5 for you.  Thanks for opening the issue.


How to send all error messages to Plugin (Ionic2)?

Hello ,
I can't figure out in the documentation how to send all crashes automatically to the plugin. I only see the loads in my Fabric Dashboard - saying I am 100 % crash free.
Unfortunately, that's not true, I had some native crashes and handled errors.
How to send all of them to the plugin?
Thx a ton!

I created a custom ErrorHandler (the stacktrace part is only required for my pull request) - this will forward everything to fabric and will show a nice error message as of ionic2.rc3
in your providers (app.module.ts) add the following line:
{provide: ErrorHandler, useClass: FabricErrorHandler},

import {Injectable} from "@angular/core";
import {Analytics} from "./analytics";
import {IonicErrorHandler } from 'ionic-angular';
import * as stacktrace from 'stacktrace-js';

@Injectable()
export class FabricErrorHandler extends IonicErrorHandler {
    constructor (public analytics: Analytics) {
        super();
    }

    handleError(error) {
        // do something with the exception
        this.analytics.addLog('crash triggered');
        stacktrace.get().then(
            trace => this.analytics.sendNonFatalCrash(error.message, trace)
        );

        super.handleError(error);
    }
}

@wodka Where did you get the module used in import {Analytics} from "./analytics"; to get typings? At the moment I'm using (<any>window).fabric.Crashlytics but your approach seems better.

@Iyashu5040 minimal ts file - I use the same injectable to collect other stuff for fabric Answers
import {Platform} from "ionic-angular";
import {Injectable} from "@angular/core";

@Injectable()
export class Analytics {
    private handler:any;

    constructor (public platform: Platform) {
        platform.ready().then(
            () => this.setup()
        )
    }

    private setup() {
        if (!(<any>window).fabric) {
            return;
        }

        this.handler = (<any>window).fabric;
    }

    setUserIdentifier(id:string) {
        if (!this.handler) {
            console.warn('fabric not available: setUserIdentifier', id);
            return;
        }

        this.handler.Crashlytics.setUserIdentifier(id);
    }

    setUserName(name:string) {
        if (!this.handler) {
            console.warn('fabric not available: setUserName', name);
            return;
        }

        this.handler.Crashlytics.setUserName(name);
    }

    setUserEmail(email:string) {
        if (!this.handler) {
            console.warn('fabric not available: setUserEmail', email);
            return;
        }

        this.handler.Crashlytics.setUserEmail(email);
    }

    addLog(message:string) {
        if (!this.handler) {
            console.warn('fabric not available: addLog', message);
            return;
        }

        this.handler.Crashlytics.addLog(message);
    }

    sendNonFatalCrash(message:string, stacktrace?: any) {
        if (!this.handler) {
            console.warn('fabric not available: sendNonFatalCrash', message, stacktrace);
            return;
        }

        this.handler.Crashlytics.sendNonFatalCrash(message, stacktrace);
    }

    sendSignUp(type:string, success:boolean, attributes?:any) {
        if (!this.handler) {
            console.warn('fabric not available: sendSignUp', type, success);
            return;
        }

        this.handler.Answers.sendSignUp(type, success, attributes);
    }
    sendLogin(type:string, success:boolean, attributes?:any) {
        if (!this.handler) {
            console.warn('fabric not available: sendLogin', type, success);
            return;
        }

        this.handler.Answers.sendLogIn(type, success, attributes);
    }

    sendCustomEvent(name:string, attributes?:any) {
        if (!this.handler) {
            console.warn('fabric not available: sendCustomEvent', name);
            return;
        }

        this.handler.Answers.sendCustomEvent(name, attributes);
    }

    sendStartCheckout(totalPrice:number, currency:string, itemCount:number, attributes?:any) {
        if (!this.handler) {
            console.warn('fabric not available: sendStartCheckout', totalPrice, currency ,itemCount);
            return;
        }

        this.handler.Answers.sendStartCheckout(totalPrice, currency, itemCount, attributes);
    }

    sendContentView(name:string, type:string, id:string, attributes?:any) {
        if (!this.handler) {
            console.warn('fabric not available: sendContentView', name, type, id);
            return;
        }

        this.handler.Answers.sendContentView(name, type, id, attributes);
    }
}

The answer is provided in this thread, and it is tested and working. This issue can be closed if there is no further discussion.

The Javascript error catching is working well for me on all platforms, but Android does not report full app crashes in the same manner that iOS does. Further investigation required.

@emcniece what do you mean exactly?

The error catching that you (@wodka) have provided works really well for "console" errors, or events that happen within the webview on each platform. However there are still events that do not result in console errors (like memory leaks) that can cause the webview itself to crash.
I am finding that while iOS Crashlytics is reporting full crashes properly, it is not reporting this on Android. All of my Android builds have a 100% crash-free statistic, even though I have witnessed the app dump many times.
Crashlytics can be configured to send in-thread crash events (sendNonFatalCrash() in your example) which I think requires Javascript to be executing, but I am not sure how Crashlytics sends a full crash report when the app exits completely. @sleepybuddha's question doesn't make a distinction between these two types of crash events.
Any ideas?

In theory the log should be sent when the app starts again. Regular messages are being sent from crashlytics?


The configuration of Calico network when joining a Windows node to the Kubernetes cluster is not effective.

I first configured a Kubernetes Linux cluster and then added a Windows worker node according to the documentation.

Official documentation: https://docs.tigera.io/calico/latest/getting-started/kubernetes/windows-calico/requirements

Under the title "Linux platform requirements," I used the command kubectl patch ippool default-ipv4-ippool -p '{"spec":{"ipipMode":"Never","vxlanMode":"Always"}}'. During two validation processes, the first time I disabled the BGP network mode, and the command did not take effect. Later, I switched to the BGP network and modified the command to kubectl patch ippool default-ipv4-ippool -p '{"spec":{"ipipMode":"Never","vxlanMode":"Never"}}', but this command also did not work.

However, by directly modifying spec.encapsulation: None through kubectl edit installation default -o yaml -n tigera-operator, I was able to see that the network information changed after running kubectl get ippool default-ipv4-ippool -o yaml. This issue has been resolved, and I am only providing this test record as feedback.

Thanks for raising this - sounds like our documentation still asks users to modify the IP pools directly, instead of modifying the operator Installation yaml.
This will vary based on install method - for operator-based installations, IP pools should be edited via the Installation.
For manifest based installs, you will need to modify the IP pools directly.


Need to transfer to tc39

@ljharb This is in tc39-transfer.  It should probably end up in tc39 soon.  Ideally, I'd also get commit rights at some point.

cc @leobalter @littledan @bterlson

You should already have commit rights.

@mikesamuel I sent you an invite to the delegates team at the @tc39 org. I'm now transferring this project.

@leobalter Thanks much.  Looks good now.  Closing.

Anytime!


Gallery images disappear, even though they're still there in the backend

Issue Summary

The website itself also omits them entirely. These were added just fine, displayed just fine, and are available just fine in the backend folder structure as expected.
Steps to Reproduce

Add gallery + images successfully
Images eventually disappear (their placeholder remains, and the images are available in the back end, but the gallery does not display them anymore)

Ghost Version
latest
Node.js Version
?
How did you install Ghost?
docker
Database type
Other
Browser & OS version
No response
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Hey petruut, thanks for creating the issue.I have just tried repeating the same steps on the latest Ghost version, and I haven't been able to reproduce the bug.Could you provide a video recording of the bug you're experiencing? Any other information that could help us reproduce it?

thanks for the quick reply - is there any way for me to look at the code in the gallery/ logs on galleries already with this issue on the website?
(also, is there a way to relink images already in the /content folder on ghost, without always re-reuploading new copies?)

In the browser, if can open your dev tools, then open the Network tab, you can see backend requests to ghost/api/admin/images/upload/ for each image that is being uploaded in the Gallery card. Relinking images from your content folder is unfortunately not supported at the moment.

Once published on your website, you could inspect the source of the relevant <img> tags:

re the networking: I can only see assets for the 4 images that are actually displaying (even though the gallery is formed of 7 images, all available in the /content subfolder that ghost uploaded them to)

also, I can't see any errors etc. but then again, I don't know what I'm looking at.
re inspecting the source:

so it looks like, by the time the website is rendering, it only renders the 4 images (as opposed to the 7)

In the browser, if can open your dev tools, then open the Network tab, you can see backend requests to ghost/api/admin/images/upload/ for each image that is being uploaded in the Gallery card.
CleanShot.2024-09-18.at.13.07.09.mp4
Relinking images from your content folder is unfortunately not supported at the moment.

my networking screenshot is from the published website. re the upload in the backend, I know that works because I can see the images in the file manager in the right /content folder

Hm, unfortunately I'm not seeing how to help further with these elements, as I don't have a way to reproduce the bug at the moment. Does this happen for you with a new post as well?

@petruut 👋
Given that we have not been able to find a clear reproduction of the bug and that it seems environment-specific, we suggest that you open a thread on the Ghost forum to get more help, if you're still experiencing the issue.


Combine redux-dag-history and dag-history-component into a monorepo

Hi @darthtrevino, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Chris Treviono (Applied Technical Systems Inc)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

👍


Fix broken git URL

The git clone section in Tools.md has an incorrect repository name, this should fix it!

Muchas gracias


chore: Convert webhooks webhooks TestCase to normal test function

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[x] ~I have added information to docs/ if required so people know about the feature!~
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes
I'm working through re-writing the TestCase classes into normal test functions. Rewrote the existing TestCase and replaced with fixtures instead of recreating everything. There are other PRs that are similar to this one.
How did you test this code?
I manually changed the tests one at a time to refactor them as I went then ran the full test suite afterwards.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (da21b8c) 95.93% compared to head (33006c6) 26.70%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3374       +/-   ##
===========================================
- Coverage   95.93%   26.70%   -69.24%
===========================================
  Files        1077     1000       -77
  Lines       32950    28853     -4097
===========================================
- Hits        31612     7706    -23906
- Misses       1338    21147    +19809

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


revendor libnetwork and netlink in engine component

bumping vendor of docker/libnetwork to 411846172fb457a6459ea94eb536f91717ee0a04
Signed-off-by: Andrew Hsu<EMAIL_ADDRESS>

LGTM


Update members.json

Added tejasagarwal.tech

Howdy @tejasag, could you add the icon to the website?

Alright, looks good now!


How to fetch Azure devops service connection id

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: here
Enter Task Name: here
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines or TFS on-premises?

If using TFS on-premises, provide the version:

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version:

Issue Description
[Include task name(s), screenshots and any other relevant details]
Task logs
[Enable debug logging and please provide the zip file containing all the logs for a speedy resolution]
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
[Insert error from the logs here for a quick overview]

I presume your need is to query endpoint connection from your custom task.
Tasks typically use aure-pipelines-task-lib for this. You can refer the task lib documentation here.
You can refer how the tasks  for examples.

Closing this since Muthu has already given an answer. Re-open with details, if you are looking for some other information.


README: These typed values are not currently exported

The types (parquet.<Type>Page) are not currently exported.  Is the intent to export them?  If so we can toss this PR and make that change instead.

Cool, I'll update to that then!


permission group specific

It can be sent according to the player's specific permission. All players can see the gift package of the special permission group, but they must have the permission group to receive

An easy way to do this without needing to integrate a permission API is to set up five different permission in the plugin, name it
premiumgift.level1
premiumgift.level2
premiumgift.level3
premiumgift.level4
premiumgift.level5

and then have any permission plugins to add these permissions to the players, that way there can be five different groups of specific gift packages.


Semicolons before immediately executed functions

Adding semicolons before all immediately executed functions makes UMD safe in concatenation scenarios. Without the initial semicolon in UMD, a file not ending with a semicolon (A) concatenated with a file using UMD (B) might be parsed in an unexpected way:
var foo = 'bar' // File A
(function () { /* UMD */ }()); // File B
// TypeError: string is not a function

var foo = 'bar' // File A
;(function () { /* UMD */ }()); // File B
// good

If all people used the right tooling with a correct setup we wouldn't have to care... Most concatenation at least adds a newline so I'm :-1: for this.

The example I gave does have newlines and still fails. Only explicitly setting ";" as a concat separator will prevent the error. I agree that this is an edge case, but I think UMD should be as complete (universal) as possible.
Also gulp-umd (which UMD recommends in its readme) does use the semicolon.

I'm going to side with @arthurvr  on this one.  UMD is to get around concrete problems that result in module system incompatibilities. Not a best practices for broken build systems.

I'm closing this out as won't fix. No modern build system uses such simple concatenation afaik.


Form inputs not focusable in popup

I think the heading says it all. If I am trying to put a form in a popup, the form elements are not focusable and no events are triggered
This is what I am trying to achieve: https://gyazo.com/4e9a210a26e785dba035ba83b9bcc7d3

        Topic

        About Us

        Jobs

        Locations

            <button class="ui primary button">Registrieren</button>

            <button class="ui button" suiPopup [popupTemplate]="loginPopup" popupTrigger="outsideClick" [popupPlacement]="loginPipupPlacement">Login</button>

<ng-template #loginPopup>
    <form class="ui form">

            Username
            <input name="first-name" placeholder="Username">

            Passwort
            <input type="password" name="last-name" placeholder="Passwort">

        <button class="ui button">Login</button>
    </form>
</ng-template>

This happens because popups don't allow focus to be lost by default (to make the focus popup work correctly), but it appears it breaks other things.
I have an idea on how to sort this, will work it into the next release 😄

Thanks :D

This is now live in 0.9.5. Let me know if you have any further issues 😄

Thanks now everything is working! :+1:


Ctrl+C is not working after Ctrl+O and exiting editor

Platform e.g. macOS, Windows 10, ...
Windows 10
Version	10.0.19045 Build 19045
Terminal software e.g. gnome-terminal, Apple Terminal.app, ...
wezterm 20240203-110809-5046fc22
I type in a command line, then I press Ctrl+O. This opens up $env.EDITOR, which is nvim in my case.
I exit nvim but I don't want to run the command, I would like to cancel it with Ctrl+C but nothing happens. I have to delete the command to empty the line the press enter.
Steps to reproduce

$env.EDITOR = nvim
type 'ls'
type Ctrl+O
quit nvim
type Ctrl+C

Screenshots/Screencaptures
Very helpful if the display doesn't seem to work

I can't reproduce the problem on macos

I don't have real linux to try it, on WSL I cannot reproduce. However, on WSL nushell behaves strange: every key I  type scrolls the screen buffer up one line.

If you're using wezterm on windows you probably need to disable osc133 in the config file.

disabling osc133 fixes auto scrolling, however my original issue on windows still exists :(

What version of Nushell and Neovim are you using?

nu: 0.100.0
neovim:
NVIM v0.10.2
Build type: Release
LuaJIT 2.1.1713484068


Instructor Workshops are all 404ing

Agree, these are showing 404.  @Rich, I see there are options for partner-led training options in the marketplace, but unsure if you'd like to repoint to those resources.  I'm going to approve this pr; these can be added back if needed (would also need to indicate which offerings are specifically paid for options)

Agree, these are showing 404.  @Rich, I see there are options for partner-led training options in the marketplace, but unsure if you'd like to repoint to those resources.  I'm going to approve this pr; these can be added back if needed (would also need to indicate which offerings are specifically paid for options)


SSO iam accepts idp

Is your feature request related to a problem? Please describe.
I need to be able to set the IDP for IAM.
Describe the solution you'd like
add an attribute in the IAM config as kcIdpHint
Describe alternatives you've considered
I'm mutating the config and adding idp into the IAM instance

captured this plus more discussion in #32


'choice': fix unique parameter, extend, & make a provider

Close #484 by converting choice to a provider. Additionally:

Fix (& extend testing accordingly) for a bug noticed but not picked up by tests when setting unique=True. The number of elements provided was inconsistent  with number if there were insufficient unique elements in items:
>>> choice(['a', 'b', 'c'], number=4, unique=True)
['b', 'c']
>>> choice(['a', 'b', 'c'], number=4, unique=True)
['c', 'a', 'b']

Now raise an error if there are not enough unique elements to satisfy number (now length - see
below)

Change the interface slightly to be more intuitive: in #484 there was the distinction between 'multiple choice', returning a list, & 'choice', returning an uncontained element. In this implementation, number is renamed length implying a sequence length. The user would like a sequence. So if specified (& valid i.e. a positive integer), a sequence is returned, but if unspecified, just return a bare element i.e. one not in a sequence. Prevent input of empty sequences, as making a random choice over these makes little sense.

Extend the functionality so that the output for other sequences that make sense in context (i.e. tuple & str) will be of the same type as the input items, not always a list.

Document choice, which was previously missing from the docs. Interactive shell examples are included in the API reference (copied for illustrative convenience here):
>>> from mimesis import Choice
>>> choice = Choice()

>>> choice(item=['a', 'b', 'c'])
'c'
>>> choice(item=['a', 'b', 'c'], length=1)
['a']
>>> choice(item='abc', length=2)
'ba'
>>> choice(item=('a', 'b', 'c'), length=5)
('c', 'a', 'a', 'b', 'c')
>>> choice(item='aabbbccccddddd', length=4, unique=True)
'cdba'

@sobolevn Do you have something to add to my comments?

Thank you for the quick & helpful feedback @lk-geimfari! I've addressed and squashed into the one commit the trivial parts.
I am not sure about the unique parameter feedback suggestion.

Maybe just return as many unique as we have in sequence?

For cases where there are fewer unique elements in items than the length (or number before) this would seem not correct (inconsistent) behaviour to me as length would be different to the provided sequence length, as demonstrated in my initial comment examples. Though another option is to maybe change that variable name to max_length? Else there is the way I implemented to raise an error for inconsistency.
Can we get a second opinion from reviewer 2? I will happily change the code to implement whatever you both think is best with respect to unique, though (just maybe get another perspective first).

@sadielbartholomew Sure! @sobolevn 🏓

@sadielbartholomew So, let's keep your solution (I'm about unique)!

@sadielbartholomew Do you checked other my comments, can we merge this PR?

@lk-geimfari sorry for the delay, I had to wait until my lunch break. Yes, this is ready for merging if you are both happy. Thanks!

@sadielbartholomew Great! Thank you!


Manage hierarchies of data

Given a data
When the data references an other
Then the other can be selected when editing the data

To do: how to store hierarhices in the abstract syntax graph? Fix test

https://johnderasia0.crm8.dynamics.com/
<EMAIL_ADDRESS>: Secret123

Clean up components. Rename sub components. Make sure order of fields and imports.
Fix look up accounts
Add filetring to list of conctacs of accounts
Navigate back to contac list from sub contact form of accounts
Add account to the contact created under the account
Fix Navigation bar


Fails on WSL, OK on Windows; " EACCES: permission denied, mkdir '/mnt/undefined/Users/undefined/AppData/Local/lighthouse.59445321'"

Bug description
└ $ snap-tweet https://twitter.com/jack/status/20
[snap-tweet] Error: EACCES: permission denied, mkdir '/mnt/undefined/Users/undefined/AppData/Local/lighthouse.59445321'
✖ EACCES: permission denied, mkdir
  '/mnt/undefined/Users/undefined/AppData/Local/lighthouse.59445321':
  https://twitter.com/jack/status/20

Reproduction
snap-tweet https://twitter.com/jack/status/20 on WSL
Environment

snap-tweet version: 1.2.3
Operating System: Ubuntu 20.04.6 LTS
Node version: v20.7.0
npm version: 10.1.0

Related to https://github.com/GoogleChrome/chrome-launcher/issues/324

@privatenumber this will be a bit more complicated to fix (and potentially upstream), for now it works fine on Windows so not a huge deal


Tools: Add symbol converter

Tools: Add symbol converter
Description
Adds a kicad symbol library to faebryk component library converter.
Checklist
Please read and execute the following:

[x] My code follows the coding guidelines of this project
[x] My PR title is following the contribution guidelines
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (if applicable)
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I ran Black to format my code

Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct:

[x] I agree to follow this project's Code of Conduct

superseded


Generate typedefs from dts files

Emit declaration files and import type defs from them
Closes: #143

Werid @gimenete
To me even inside a then it types it properly

@SferaDev weird, this is a video with more information:
https://user-images.githubusercontent.com/50486/166913318-664c1df3-9491-4b86-97e2-9c45e4806cc8.mp4
If you think I'm doing something wrong, let me know 😅

Something is up with VSCode then, it works on my machine. Video doing the same as you:
https://user-images.githubusercontent.com/2181866/166917398-50de72eb-6d39-4770-ad9d-8e752a2455f6.mp4
I'm in Insiders build, with TS 4.7 dev. But not sure it should make a difference...

@SferaDev ok, no worries. I'll try to figure it out 😅


Release 2.1

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Who is Luyi?
On May 20, 2015 7:51 PM, "Luyi"<EMAIL_ADDRESS>wrote:

Closed #1399 https://github.com/DataTorrent/Malhar/pull/1399.
—
Reply to this email directly or view it on GitHub
https://github.com/DataTorrent/Malhar/pull/1399#event-310194020.


#146 Implement automated coverage tools

closes #146 implement automated coverage tool
Jacoco has been added
Coverall has been added to the GitHub workflow, to be used in PRs
Some Steps are needed to activate Coverall:

[x] 1. Sign up to Coveralls.io on their website using the Repo owner
[x] 2.  On the Coverall website navigate to settings and Activate "leave comments?" and set them to detailed, bevor saving the changes. (Once signed up the link to the settings will be https://coveralls.io/github/devonfw/IDEasy/settings )
[x] 3. The coverall bot needs to be added to the repo, with write permissions (https://github.com/coveralls)

(Documentation can also be found on the Coveralls docu page )

I was able to skip step 1. and complete step 2. (as I was allowed to change settings in coverall for defonfw/ideasy)

... and complete step 2. (as I was allowed to change settings in coverall for defonfw/ideasy)

I think this setting can be changed by anyone on the web. Can we restrict this?

... and complete step 2. (as I was allowed to change settings in coverall for defonfw/ideasy)

I think this setting can be changed by anyone on the web. Can we restrict this?

The settings can be changed by anyone within the Devonfw Github Group, but i can look into restricting it further

For the record: I did not grant "Write permissions" to coveralls as reading the documentation I found out that read access is sufficient. We will see if all works out or not.

one last thing @moritzLanger
IMHO you forgot to add the badge for coveralls to our README in this PR.
Can you afterwards create a new PR for that.

one last thing @moritzLanger IMHO you forgot to add the badge for coveralls to our README in this PR. Can you afterwards create a new PR for that.

I just did it myself. Done.


chore(deps): update fastify to v4

This updates fastify and all its plugins to v4

:tada: This PR is included in version 3.2.0-rc.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


It would be useful to have ability to embed on a background

I've found that we often want an image to result in an exact size even if the resized image would be less than the requested size. Sharp has a embed() function that works similar to max but fills in the background out to the requested dimensions.
I've created a PR that adds this
https://github.com/humanmade/tachyon/pull/41

Proposed solution now on https://github.com/humanmade/tachyon/pull/44

Thanks for accepting #45 @joehoyle

Thanks so much!


Output of the run shows sensitive outputs

Because the output of the run is being got directly from the state it prints sensitive output values to the github action log.
Would be good to suppress this like the CLI does or at least make it an option.

Ouch, that's not good. We are indeed just printing all outputs here...
https://github.com/kvrhdn/go-tfe-run/blob/104d8cce779fddd82ad7a9e81fe74090b02742a9/tferun.go#L311-L314
I see it's possible to mark an output as sensitive: https://www.terraform.io/docs/language/values/outputs.html#sensitive-suppressing-values-in-cli-output
Do you know if this is recorded in the state file as well?
The current implementation downloads the state file from Terraform Cloud and then maps the received []byte onto a minimal implementation of the state file. If sensitive is part of the state file, we can also parse it and filter it from the printing then.
IMO there are two good options:

add an option to not print any outputs at all
check that an output is sensitive, if so don't print it

What would work best for your workflow?

For my workflow I don't need outputs to be printed at all.
If you get the state version through the API (and include the outputs with ?include=outputs) https://www.terraform.io/docs/cloud/api/state-versions.html#fetch-the-current-state-version-for-a-workspace the response will tell you if an output has been marked sensitive or not.

Created a PR for this https://github.com/kvrhdn/go-tfe-run/pull/19


Md-expansion panel opened and close events not firing on prod build

Bug, feature request, or proposal:
Looks like a bug.
What is the expected behavior?
Event handler is invoked when opened and closed events happen.
What is the current behavior?
Event handler is not invoked on opened and closed events.
What are the steps to reproduce?
Attach handlers for such events in the template and check if they are invoked after being built with angular cli's ng build --prod.
What is the use-case or motivation for changing an existing behavior?
Has to be working in production build
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?
I'm attaching event handlers like this:
<md-expansion-panel       (closed)="onCollapse()"       (opened)="onExpand()">
and process them in component. But these handlers are not invoked after prod build. It works OK when I do ng build --dev or ng serve.

@tarasbobak I was not able to replicate the issue you are seeing.
I made a quick minimal repro.  You should be able to clone this repo and then run ng serve --prod.  On expand and collapse of the expansion panel the counters should increase.

@josephperrott Thank you for your response. I was investigating it a bit by myself and it look loke that it works OK when I use beta.10 in package.json and it is reproducable when targeting material builds or specific build. The reason why I need it is because if thew ability to set expanded and collapsed height to the wxpansion panel.

Here is the simplest reproduction as you asked: https://github.com/tarasbobak/ng-repros

The issue is reproducible in beta.11.

Turns out this was actually caused by not including the opened and closed outputs in the decorator for MdExpansionPanel,  #7309 should fix it.

Thanks @josephperrott .
If you're like me and just upgraded your project and even ran the md -> mat upgrade so you really don't want to rollback, you can get by with this horrible hack if you were already tracking if the expansions panel was open or closed in a variable:
<mat-expansion-panel (click)="expanded=!expanded;expanded?onExpand():onCollapse()">

This won't work if people use the keyboard to open and close a panel but it'll get me by until the next version is out.

You can also run ng build --prod --aot=false. That way it won't be broken if aot is not critical until it is fixed in next release.

Thanks @rfuhrer for the workaround.

Was this fixed with beta 12?

@marxxxx no, the issue is reproducible in beta.12.

@rfuhrer thanks for sharing this workaround!

Any update on this? Still broken in 2.0.0-beta.12

@mswilson4040 This has been resolved now in #7309 and is merged into the master. However I'm not sure if it made it to the 5.0.0-rc0 version.

@steve-todorov I'm still having the issue. The only way I can get it to work is to remove both --prod and --aot flags. What (specifically) needs to be upgraded to get this fix?

@mswilson4040 the fix will be included in the next release. Right now, you can use one of the workarounds listed above, or try out the snapshot builds at angular/material-builds.

@mswilson4040 The exact fix is here: https://github.com/angular/material2/pull/7309/files#diff-8646582ffcbe6b80a7296f9526f5b263 but unless you are planning to build Angular Material yourself and use that in your project, you'll probably just have to use my workaround and wait for 5.0.0rc1.  The fix was merged into master after rc0 was cut but I think it's all but guaranteed that there will be another RC especially since the main point of Angular 5 was to make AOT and Build Optimizer the defaults for the CLI based projects

Did the fix get documented?  The current version of the docs (Please, I am begging you to host versioned docs so I can deep link to something that isn't going to change in a week!) has an example of a "self aware panel" but it doesn't actually work:

And on the API page, it does not list any outputs for any of the components there, including opened / closed.
While you're in there anyway, wouldn't it be more consistent with the APIs of the other components to have a single event that emits a boolean representing whether it's open or not?  openedChange is what SideNav uses.

@thw0rted It looks like the docs were generated after the fix was in, but the doc site is still using the current release (rc0) of the code which has this feature broken.  If you look at my workaround you can see that you can access the "expanded" property of a mat-expansion-panel, so you can make a "self aware" panel work even without working open and close events.
Current Docs:
<mat-expansion-panel (opened)="panelOpenState = true"
                        (closed)="panelOpenState = false">
     <mat-expansion-panel-header>
       <mat-panel-title>
         Self aware panel
       </mat-panel-title>
       <mat-panel-description>
         Currently I am {{panelOpenState ? 'open' : 'closed'}}
       </mat-panel-description>
     </mat-expansion-panel-header>

I'm visible because I am open

   </mat-expansion-panel>

A way that would work with the current version:
<mat-expansion-panel #expPanel>
     <mat-expansion-panel-header>
       <mat-panel-title>
         Self aware panel
       </mat-panel-title>
       <mat-panel-description>
         Currently I am {{expPanel.expanded? 'open' : 'closed'}}
       </mat-panel-description>
     </mat-expansion-panel-header>

I'm visible because I am open

   </mat-expansion-panel>

The docs will fix themselves here when the next version comes out.  Your point about the Output's not being listed is definitely valid though.  I'm sure the team would accept your pull request if you added that to the docs

Has there been any discussion of changing the two events (open/close) to one boolean event, to keep it in line with how Sidenav works?

The issue with the docs has been fixed.

Seems like the issue still exists in angular material 5.0.2. mat-expansion-panel does not open in prod build, but works fine with dev buid and ng serve.


Gradient of elasticity wrt to position

Hi Guys, Thank you for this work,
i am trying to learn the contact parameters from simulation data but the problem i have, is that i have a real simulation data and pred simulation data with random elasticity value(everything the same except elasticity)? the goal i want to learn elasticity value by computing the loss between real position and pred position then compute the gradient of elasticity and update the elasticity parameter value? the problem when i compute the gradient wrt to velocity i get a non-zero gradient but when i compute it wrt to position i get a zero gradient? any one has an idea why this is the case?

Hi @amine789 , is the gradient of position computed wrt the entire trajectory? Also which physics backend are you using? Can you provide a reproducible script?
For the sake of simplicity / sanity check, I would first use a black-box optimizer to make sure you can optimize position for elasticity

the gradients are working fine, it was a bug in the code


Fix a number of shutdown crashes in TermControl

The TSFInputControl may get a layout event after it has been removed
from service (and no longer has a XAML tree)

Two fixes:

first, guard the layour updater from accessing detached xaml
objects
second, shut down all pending throttled functions during close
(not destruction!¹)

The TermControlAutomationPeer may be destructed before its events
fire.
The TermControlAutomationPeer may receive a notification after it has
been detached from XAML (and therefore has no dispatcher).

¹ Close happens before the control is removed from the XAML tree;
destruction happens some time later. We must detach all UI-bound events
in Close so that they don't fire between when we detach and when we
destruct.
Fixes MSFT-32496693
Fixes MSFT-32496158
Fixes MSFT-32509759
Fixes MSFT-32871913

I will port this forward to 1.8, but I will need some assistance in porting it for 1.9.

In general (/cc @zadjii-msft), we need to be very crisp on what constitutes "teardown" for UI objects and teardown for the control. All of these crashes are caused by the UI being in a torn down state, but the control itself not being a torn down state and trying to manipulate the UI.

These account for 65% of all the WT Stable crashes in Watson (!)


Typo in the test code & different behavior in command

Hi
In the exists_test there is a typo that said return 1 but it should return 0
Deno.test("when the key does not eist", async (t) => {
  await t.step("it returns 1", async () => {
    const key = newKey();

    const res = await new ExistsCommand([key]).exec(client);
    assertEquals(res, 0);
  });
});

Also composing the bitpos command from Redis and Upstash console is different.
for example this command in upstash return 24 but in Redis has error because it does not defined bit which is 0 or 1, even if you define it the value is different from Upstash.
set key "Hello World"
-> OK
bitpos key 2 3
-> 24

if you run same command in Redis, it said The bit argument must be 1 or 0 if you define it return 16

Thanks again, good catch.
I've fixed the typo and forwarded the bitpos difference to the redis team.

@rebaz94: Currently Upstash checks only if the bit is equal to 1 or not. The result for any bit value except 0 and 1 should be considered undefined, as the BITPOS command contact is defined. But you're right, it'd better to return an error if the bit value is invalid.
I didn't understand what you mean by;

... even if you define it the value is different from Upstash.

and

... if you define it return 16

What do you mean by define here?

@mdogan The upstash-redis library send the command which does not include bit. as you said it default to 1.
if send this
set key "Hello World"
bitpos key 2 3

// result will be 24

if we set the bit and run same code in upstash console

Same example in redis.io

As you can see, the result should be 17 because the bit is default to 1 and both redis and upstash correct in that case.
So I'm confused why it return 24 in upstash reset but not in CLI?

Ah I understand the confusion now... Spec of the BITPOS command is:

Now I see that upstash-redis library is missing a bit arg in the command definition.

Thank you, let the issue open so I can fix on my side.

Fixed bitpos in #122, I'll merge and release later today.


Start Your MDK Application in the Editor

Tutorials: https://developers.sap.com/tutorials/cp-mobile-dev-kit-offline-app.html
Write here what you need help with ...
I am unable to deploy the application on Mobile Services I get the error message as
Deploy failed. Detail: Failed with response code:404 detail:Not Found.

The Web application seem to deploy but it reflects the same error when I open the application. Screen grab below

As per the below log
https://blogs.sap.com/2018/03/15/troubleshooting-tips-for-mobile-development-kit/#404
I checked the destination on the BTP platform . I have configured the destination as per the steps mentioned in the below link
https://developers.sap.com/tutorials/cp-mobile-dev-kit-ms-setup.html
I get 400 status when I check connection from the destination screen.

Can you please let me know where I could be going wrong.
Appreciate your Support
Regards
Advit

Hello Team,
I was wondering if you had a chance to look into this

@jitendrakansal Do you have an update?

@advit-ramesh can you once check the URL? I see that URL has some additional info which is not correct.

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


Switch to jwt authentication

Removes username and password authentication.
The --brkt-token arg is now used to pass a
jwt through userdata to the encryptor.
The jwt must be created with the make-jwt
command
Testing: encrypted an image in gce

LGTM. But before we push out this change to customers, we should document the steps for generating JWTs as this will be an additional operation that users will have to perform.

Could you please hold off on merging this PR?
It will conflict mightily with my latest one (#335) and I suspect it will be much easier to make these changes once #335 is merged in (compared to re-working #335 after this one is merged).

I'll hold off

OK, I merged in #335.  I'm hoping rebasing these changes won't be too tricky.


Category question answers to not render if not "Multi select"

Answer show as "No Response".

I tested this feature by submitting a new application. The question appeared for the applicant. The response appeared on the submission. Thank you!


feat: expose evm internal fns

If 3rd parties want to build custom stack executors or stack states, they will need access to the datatypes defined inside this module
also adds auto_impl to implement common traits for Box, Arc, & and &mut variants.

@sorpaas done. I also added https://github.com/rust-blockchain/evm/pull/62/commits/66a729ba793ab41faf27d75dc6057b708e9138d5 because I am trying to hook on some of the EVM's internals downstream here and they were not visible before.

@sorpaas I also added https://github.com/rust-blockchain/evm/pull/62/commits/bbb1ba18a1efd87b1d578aec5dda9264932ddf2c which is a nice expansion on the types that implement the traits. should be straightforward to review.

Bump!

Sorry for taking so long. I'll have to add no_std tests first. After that I'll merge this!

Sounds great to me. Thank you!

Let me get the no_std tests later.

https://github.com/auto-impl-rs/auto_impl/pull/73
auto_impl not support no_std. Why the PR was merged?


Sophos Endpoint security detecting Anki as Network Threat C2/Generic-A after 4/11/21 SSL update

As the title says -- after the recent update on 4/11/21, Sophos Endpoint security detects a network threat C2/Generic-A possibly after enabling SSL. Any solutions for this issue?

That's strange, enabling SSL should be a security enhancement. Does it happen to some specific images only or all the images?

My apologies, please disregard. There was an issue with another add on (Anki Killstreaks) not this one.


fix: Cypress plugin stop error

When running tests with cypress plugin and Cypress 10, an exception is thrown when the stop() function is called to stop the server.
Changing method to close() doesn't throw any exception or warning and the server gets closed correctly.
https://github.com/vuejs/vue-cli/issues/7230
What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Underlying tools
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

@iriadp Thanks for your work!

hey guys, any news about the new build of this fix ?

Hi guys, any news about it?

Any update on when this could be fixed?
This is also blocking our company to upgrade to version 10

@yifaneye is there any timeline for this bug fix?

@AlbinSahlbom We've been waiting for this as well for several months. Gave up and switched to vite and it was surprisingly painless. Now we're on cypress 12 and as a bonus a much faster dev/build experience.

@iriadp can you request reviewers with write accesss


Create guide on how to use ENV variables with Platformatic

There seem to be a lot of confusion on this one, so maybe we should document it.
The current flow is:

add options to your plugins (async function (app, options) {})
add those options to your platformatic.json in the plugins section, using env variable replacement syntax {MY_ENV} as values
add those variables to .env

Will start working on this in the new week.


unable to install framework-res.apk on Windows 10

when trying to run 'apktool if framework-res.apk' I receive the following output. I am using Windows 10 Home x64 and I have launched Command Prompt as Admin. Apktool.jar and apktool.bat are both in my C:\Windows directory and I am able to decompile apks using 'apktool d apk.apk'.
C:\Windows>apktool if framework-res.apk
S: WARNING: Could not write to (C:\Users\Tyler\AppData\Local\apktool\framework), using C:\Users\Tyler\AppData\Local\Temp\ instead...
S: Please be aware this is a volatile directory and frameworks could go missing, please utilize --frame-path if the default storage directory is unavailable
I: Framework installed to: C:\Users\Tyler\AppData\Local\Temp\1.apk

I think the fix on windows is easy, even without the --frame-path [folder] option. I just had to create the non existing directory c:\Users\[username]\AppData\Local\apktool\framework where [username] is your username. Once it was there, installing the framework used the folder correctly, which makes me feel the installation procedure or apktool.bat could just verify the directory existence and create it in case it's  missing.

S: WARNING: Could not write to (C:\Users\rahul17.singh\AppData\Local\apktool\framework), using C:\Users\RAHUL1~1.SIN\AppData\Local\Temp\ instead...
S: Please be aware this is a volatile directory and frameworks could go missing, please utilize --frame-path if the default storage directory is unavailable
I: Loading resource table from file: C:\Users\RAHUL1~1.SIN\AppData\Local\Temp\1.apk
during time of decompile and bind m getting this error but i m able to bind apk but it not working in my phone please let me know how to fix this issue

I have the same problem


Context provider

added context to app, re-wrote ProductDetail component tests to reflect use of context, cleaned up a lot of warnings from test logs.

@AdamPJohnson Looks good!


Unable to install xhtml2pdf Python package on macOS Big Sur due to reportlab

Attempting to install the xhtml2pdf Python package (pip install xhtml2pdf) fails on macOS Big Sur, due to xhtml2pdf's reportlab dependency. See the corresponding issues reported in the reportlab group and on SO for more details:
https://groups.google.com/g/reportlab-users/c/4E0odEkk9pc
https://groups.google.com/g/reportlab-users/c/3fwVJPtNIuo
https://stackoverflow.com/questions/64871133/reportlab-installation-failed-after-upgrading-to-macos-big-sur

It appears that the reportlab team knows about this issue and is attempting a patch; perhaps a new reportlab release will be ready soon, in which case the fix for xhtml2pdf is to update the dependency.
https://hg.reportlab.com/hg-public/reportlab/log

It appears that reportlab 3.5.56 is released! Just tested it, performing a fresh install of xhtml2pdf works on Big Sur now.


[Bug] Shakey user profiles

Describe the Bug
This doesn't happen all the time, but sometimes when I go to click on someone's profile, it starts almost "bouncing" and I can't interact with their profile.
To Reproduce
As I mentioned above, this doesn't always happen but when you click on someone's discord profile it starts to bounce.
Expected Behavior
Nothing should happen
Screenshots
https://gifyu.com/image/SL5mh
Discord Version
Just normal discord
Additional Context
N/A

That's an issue with Discord itself, although sometimes plugins can make it worse, but that's still not BD client related.


Input string was not in a correct format.

@tonerdo
Getting this error on build server, works fine in local.
Command
dotnet test /p:CollectCoverage=true
Error
C:\test.nuget\packages\coverlet.msbuild\2.0.1\build\netstandard2.0\c
overlet.msbuild.targets(23,5): error : Input string was not in a correct format.

@tonerdo This issue has been fixed without any change.. Just tried today and it worked.


chore: only run aurora integration tests

Summary
Only run Aurora Integration tests in the manually triggered workflow.
Description
run-standard-integration-tests.yml already runs all the docker tests and it runs for all commits to main and all pull requests. We can simplify and speed up the other workflow to only run the Aurora integration tests.
Additional Reviewers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing this PR since we have decided to separate MySQL and Postgres Runs


updated README.md and AndroidApp.md

Corrected the links in README.md.
In development setup, mentioned explicitly to move to android folder inside root directory to compile and run the app

[Current coverage][cc-pull] is 10.98%

No coverage report found for development at 8b44225.

Powered by Codecov. Last updated by [8b44225...9a06f5f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/fossasia/open-event-android/branch/development?src=pr
[cc-compare]: https://codecov.io/gh/fossasia/open-event-android/compare/8b4422584ffb9894f542fdbab233e16b68e915d2...9a06f5f2aeab0bf2ea8aa58e6893d83311bf4631?src=pr
[cc-pull]: https://codecov.io/gh/fossasia/open-event-android/pull/496?src=pr

LGTM, merging.


Add dependabot

Purpose
Keep dependencies up to date.
Changes

Add a dependabot.yaml file

Checklist

[x] Update CHANGELOG.md file

[x] Merge in main so the most recent CHANGELOG.md file is being appended to
[x] Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
[x] Add a link to this PR at the end of the description with the PR number as the text. example: #1

[ ] Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
If docs updated (select one):

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Good unit test/integration test coverage
[ ] This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
[ ] The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket
Fixes #

@sanders41 Everything looks good to me but I'm not sure how to validate that the yaml file works as expected since it runs once a week. Do you know if there is a way to do that?

We can manually run it at any time, but not until the yaml file is in place. It is basically like the workflow files, no way to test first. The good news is it just opens PRs so if anything is wrong we can close the PR and try again so no harm done.

I fixed the conflict.

@sanders41 & @TheAndrewJackson, let me know how you get on with the volume of Dependabot auto-PRs in this repo when it's configured for version updates.
My experience of it is that it's very noisy, especially in repos with npm manifest files, creating one PR per dependency bump per manifest file.
From a security perspective there's no issue if the PRs keep getting reviewed and merged, but I'd be slightly concerned about PR fatigue in the fidesops team, resulting in a security update being missed.
An alternative could be to just configure it for security updates or even just fall back to alerts.
The levels of Dependabot go something like:

Dependency graph enabled
Dependabot alerts enabled
Dependabot security updates enabled
Dependabout version updates enabled
Dependabot PRs auto-merged without human review

I'm happy with just alerts enable for most repos. Anyway, please let me know how it goes.


Adding bg theme for light green?

I've needed to set up a card with light green similar to a valid form or success row in a context table.
What are thoughts on this?
I use bg-help but could also see bg-success-light

example of my card, don't see the exact green in our variables but could use something similar I'm sure

I don't know if it's the color you are using but they look like the light variant of our green color. I found them on the master branch:

https://github.com/Availity/availity-uikit/blob/master/less/variables.less#L29


[#noissue] Build Requirements : java9

Codecov Report

Merging #4080 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4080      +/-   ##
==========================================
+ Coverage   41.18%   41.18%   +<.01%
==========================================
  Files        2338     2338
  Lines       73713    73713
  Branches     9983     9983
==========================================
+ Hits        30361    30362       +1
+ Misses      40563    40558       -5
- Partials     2789     2793       +4

Impacted Files
Coverage Δ

.../profiler/sender/StandbySpanStreamDataStorage.java
72.88% <0%> (-3.39%)
:arrow_down:

...corp/pinpoint/rpc/stream/StreamChannelManager.java
69.54% <0%> (-2.88%)
:arrow_down:

...pinpoint/profiler/monitor/DeadlockMonitorTask.java
18.6% <0%> (-1.17%)
:arrow_down:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
72.11% <0%> (ø)
:arrow_up:

...point/rpc/client/DefaultPinpointClientHandler.java
71.38% <0%> (+0.32%)
:arrow_up:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
74.16% <0%> (+1.66%)
:arrow_up:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
63.82% <0%> (+2.12%)
:arrow_up:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
85.36% <0%> (+2.43%)
:arrow_up:

...r/response/DefaultResponseTimeMetricCollector.java
100% <0%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691316e...b4f0809. Read the comment docs.


Cannot find module '@babel/core', while trying to run PizzaApp example app

I followed the instructions to create a new app. Installation seemed to go fine. When I tried to run, I hiy the following error in Metro bundler:
Bundling `index.js`  [development, non-minified]  0.0% (0/1), failed.
error: bundling failed: Error: Cannot find module '@babel/core' (While processing preset: "/Users/***/PizzaApp/node_modules/babel-preset-react-native/index.js")
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/***/PizzaApp/node_modules/@babel/plugin-transform-block-scoping/lib/tdz.js:6:13)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)

Any advice?

Steps to reproduce

npm install -g ignite-cli
ignite new PizzaApp
cd PizzaApp/
react-native run-ios

ignite doctor results:
  platform           darwin
  arch               x64
  cpu                4 cores                                                Intel(R) Core(TM) i5-3427U CPU @ 1.80GHz
  directory          /Users/***/PizzaApp

JavaScript
  node               8.11.1       /Users/***/.nvm/versions/node/v8.11.1/bin/node
  npm                5.8.0        /Users/***/.nvm/versions/node/v8.11.1/bin/npm
  yarn               0.16.1       /usr/local/bin/yarn

React Native
  react-native-cli   2.0.1
  app rn version     0.50.4

Ignite
  ignite             2.0.0        /Users/***/.nvm/versions/node/v8.11.1/bin/ignite

Hey, can you try downgrading your Metro version? I saw some chatter about them doing a release within the past few hours upgrading Babel and potentially being breaking changes.

Unlikely to be the cause. React-native has the metro-bundler version set as follows:
node_modules/react-native/package.json:    "metro-bundler": "^0.20.1",

@kevinvangelder, let me know if I am not understanding your comment properly. Where would I change the Metro version?  I do not have it installed globally.

After making sure I did not have any old metro-bundler processes running, I do not get the above error anymore, but running the app in the simulator shows the red screen below:

Hmm I guess if babel bundling failed, that makes sense that there would be no .jsbundle file...

I know there are a lot of variables in building a react-native app, but it would be nice if Ignite would publish known working configurations so that people have something that works to start with.
I was able to get it working back in 12/16, but just trying to get an example app to work right now is unnecessarily frustrating. Of course, I could be doing something wrong on my end. But nowhere do I see specific set versions of OS/Xcode/iOS (equivalent on Android), react-native, and so on. And of course I would not be asking if it was just working out of the box.

Support for this package is sadly lacking. Here is what I had to do to make it work:

react-native upgrade
(I said yes to replacing the files it prompted about)

Then I made the following changes to package.json (related to https://github.com/infinitered/ignite-ir-boilerplate/pull/185):
-    "react-navigation": "^1.0.0-beta.21",
+    "react-navigation": "^1.5.11",
+    "react-navigation-redux-helpers": "^1.0.4",
...
-    "ignite-ir-boilerplate": "^2.3.1",
+    "ignite-ir-boilerplate": "git+https://github.com/infinitered/ignite-ir-boilerplate.git",

Finally, I add to manually modify some files, again because of the above:
diff --git a/App/Navigation/ReduxNavigation.js b/App/Navigation/ReduxNavigation.js
index 154f599..652d53c 100644
--- a/App/Navigation/ReduxNavigation.js
+++ b/App/Navigation/ReduxNavigation.js
@@ -1,5 +1,6 @@
 import React from 'react'
 import * as ReactNavigation from 'react-navigation'
+import { createReduxBoundAddListener } from 'react-navigation-redux-helpers'
 import { connect } from 'react-redux'
 import AppNavigation from './AppNavigation'

@@ -8,7 +9,8 @@ function ReduxNavigation (props) {
   const { dispatch, nav } = props
   const navigation = ReactNavigation.addNavigationHelpers({
     dispatch,
-    state: nav
+    state: nav,
+    addListener: createReduxBoundAddListener('root'),
   })

   return <AppNavigation navigation={navigation} />
diff --git a/App/Redux/CreateStore.js b/App/Redux/CreateStore.js
index 2a9e63e..963275e 100644
--- a/App/Redux/CreateStore.js
+++ b/App/Redux/CreateStore.js
@@ -2,6 +2,7 @@ import { createStore, applyMiddleware, compose } from 'redux'
 import Config from '../Config/DebugConfig'
 import createSagaMiddleware from 'redux-saga'
 import ScreenTracking from './ScreenTrackingMiddleware'
+import { createReactNavigationReduxMiddleware } from 'react-navigation-redux-helpers'

 // creates the store
 export default (rootReducer, rootSaga) => {
@@ -10,6 +11,13 @@ export default (rootReducer, rootSaga) => {
   const middleware = []
   const enhancers = []

+  /* ------------- Navigation Middleware ------------ */
+  const navigationMiddleware = createReactNavigationReduxMiddleware(
+    'root',
+    state => state.nav
+  )
+  middleware.push(navigationMiddleware)
+

@kevinvangelder, do you know why the project hasn't been updated to fix those issues?

One more step if using (broken) dev screens:

npm i --save react-native-device-info
react-native link react-native-device-info
react-native run-ios

Still getting a FontAwesome error on the Plugin examples dev screen. I saw another thread on this, will update when I have the resolution.

To update react-native after that, I did:

npm i -g react-native-git-upgrade
react-native-git-upgrade
npm install

That was not sufficient, so I proceeded to do:

react-native upgrade
(said yes to all prompts, your mileage may vary)
react-native link

then finally:

react-native run-ios

and it worked 😄

Hey, sorry you had a bad experience. We're currently focused on getting the next version of our boilerplate ready, but it typically takes us a few days to respond to issues. If you used our default boilerplate without a custom version of RN than you were using a known-working generator. If you added libraries via plugins they should be automatically linked.
What versions of RN did you start with and end up with?

I should have originally said babel-preset-react-native rather than metro, I didn't have complete information at the time, I just saw something that looked like it could have been related to the issue you were seeing, but probably wasn't.

I started with the RN version specified in the ignite-red package.json, 0.50.4. I am now using 0.55.3.

We test it every time we issue an update. This is the other issue that I thought might be related: https://github.com/facebook/react-native/issues/18962

Do you publish what environment you use for such testing?
Here is my babel-preset-react-native version, so not related to 5.0.0 changes:
    "babel-preset-react-native": "^3.0.2",
I know I am behind the times on several packages, but I was trying to be conservative when working to resurrect my project from 1+ year back.

@kevinvangelder: Forgot to say, thank you for trying to help me out 😀


Navbar to the website

I would like to work on this from 10th July under DCP'21

I would also like to design the navbar under DCP'21

Please start working on these. Please join our channel, you will find the link in random channel.

@sifa123 Can I work on this issue under DevIncept'21


Simple examples or tutorial?

Dear developers
is there any simple wiki webpage or tutorial to use HopTB? from band structure, to import Wannier/openMx
wave-functions and do on?
best
Claudio Attaccalite

Ok in the while, I'm creating a simple list of tutorial (for myself)
http://www.attaccalite.com/wiki/learning-hoptb-tight-binding-code/

Thank you.
Admittedly, the documentation of HopTB is far from sufficient, but no one is actively working on documentation now. It's nice to see some examples out there instead of pointing users to the test folder.


process: sync commits from Aspect-internal silo

Commit range https://github.com/aspect-build/silo/compare/a03515edba43f9546cb8ee8990838114dcc7a484..4525e80cbee246850bdb2325ca202fea0d60d0a9

See https://github.com/aspect-build/aspect-cli/pull/730


Error message is inconsistent with the corresponding code

Actually, Proba2Labels requires one of three arguments.
https://github.com/deepmipt/DeepPavlov/blob/8726173c92994b3f789790b5879052d2f7953f47/deeppavlov/models/classifiers/proba2labels.py#L69-L78

Fixed in #946.


Misleading documentation regarding res = Ok()

When I try to use the statement res = Ok() I get a TypeError, which says

Ok.init() missing 1 required positional argument: 'value'

This is contradictory to the library's documentation, which shows the following example:
>>> res1 = Ok()
>>> res1.value
True

I'm totally fine with writing res = Ok(True), because the same statement in Rust would have been let res = Ok(()) anyways and not let res = Ok(), because Result<T, E> is generic over some T. This wouldn't even compile, since there's no type to infer the type of res from and there's no type we could annotate res with...
Proposal
The solution I'd propose to this issue is to remove the misleading example from the API documentation and to add the following example to it:

When the type of the Ok value is irrelevant, we suggest using Ok(True) as in the Rust language we'd use Ok(()).

>>> res1 = Ok(True)
>>> res1.is_ok()
True

Yes, it's possible the documentation has gone out of date with the actually API due to some recent changes.
Ok now requires a value.
Would you like to submit a PR request to fix this issue in the documentation?


gpio: Add zephyr,gpio-keys support for software debounce algorithm

Add support for software debounce gpio algorithm.
Signed-off-by: Al Semjonovs<EMAIL_ADDRESS>https://github.com/zephyrproject-rtos/zephyr/issues/52344

Probably best to split the PR into a few commits.

dt bindings
driver
tests

@henrikbrixandersen - how is this looking to you?


Remote debug not working on ubuntu

Is this a bug report?
Yes

Have you read the Contributing Guidelines?
Yes
Environment

Environment:
OS: Linux 4.13
Node: 8.9.4
Yarn: 1.3.2
npm: 5.6.0
Watchman: 4.9.0
Xcode: N/A
Android Studio: Not Found // I install 3.0.1 and think this is a bug of info command
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.53.3 => 0.53.3
Steps to Reproduce

Enable remote debug on ubuntu
Expected Behavior

Actual Behavior
Metro Bundler echo the following error
Google Chrome exited with error: Error: Exited with code 1
    at ChildProcess.<anonymous> (/home/user/Developer/AwesomeProject/node_modules/opn/index.js:86:8)
    at Object.onceWrapper (events.js:317:30)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:925:16)
    at Socket.stream.socket.on (internal/child_process.js:346:11)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at Pipe._handle.close [as _onclose] (net.js:554:12)

Reproducible Demo

react-native init AwesomeProject

Same problem here, using Ubuntu, react-native 0.53

+1

+1


Bulk-create standard Base Build tickets?

Is there is an efficient way to create all the standard tickets for Base Builds? We were creating a budget for a new base build pitch (Healing Advocates Fund) and discussing the time that gets spent on every project creating all the tickets. Mike:

Might be interesting to look into look into https://github.com/gavinr/github-csv-tools as an import tool for github issues. It's somewhat limited since it doesn't appear to use an issue template, so that might be a none-starter. But if we could get that working, it would be amazing to create a tab with a list of "Required" rows with correct concatenated titles and descriptions that would jump start issue building.

Note that these wouldn't have to be only for Base Build projects! Ideally we could take this approach to the standard tickets that apply to any project.

@bdimaggio I played with this concept last year for Amnesty. I converted a google sheet to github tickets using Zapier. It was mostly a common starting point, but with Base Build we probably wouldn't need to change much.

This wound up getting done in a general, non-BB-specific way. But — done!


Update format-specifiers-in-cpp.md

Added new specifier information.

@hharshada : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hharshada : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hharshada - do you want to fix or close this pull request? Thank you!

Hey Mike,
I think I made a suggested fix for this already.
From: Josée Martens @.>
Sent: Saturday, June 5, 2021 3:45 PM
To: MicrosoftDocs/visualstudio-docs @.>
Cc: Harshada Chandrakant Hole @.>; Mention @.>
Subject: Re: [MicrosoftDocs/visualstudio-docs] Update format-specifiers-in-cpp.md (#6705)
@hharshadahttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhharshada&data=04|01|Harshada.Hole%40microsoft.com|72b824b460804c93980608d928737d11|72f988bf86f141af91ab2d7cd011db47|1|0|637585298750985184|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=xc8mmdKIp%2FZWMJ%2BeFwXwEtPahyX3V%2ByMKyBQBRcXdSQ%3D&reserved=0 - do you want to fix or close this pull request? Thank you!

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fvisualstudio-docs%2Fpull%2F6705%23issuecomment-855305877&data=04|01|Harshada.Hole%40microsoft.com|72b824b460804c93980608d928737d11|72f988bf86f141af91ab2d7cd011db47|1|0|637585298750995198|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=bEaUV00tVH1vDvLAGlF%2FzDz6g2r7mNJBXvcan%2BUBPAQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPKMJDLJVOVVLNIBACK2HE3TRKSFDANCNFSM45N7U54A&data=04|01|Harshada.Hole%40microsoft.com|72b824b460804c93980608d928737d11|72f988bf86f141af91ab2d7cd011db47|1|0|637585298750995198|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=cnWtOSCHbG0NEBJHHbItNXqcr%2FnP17SbZgmzUcjVg%2F8%3D&reserved=0.

@Mikejo5000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


News Feed Plugin: Favicon Overlay to Indicate News Sources

In the news feed plugin, it's not always clear which posts are news posts and which are just tweets. So, it'd be great if each entry had the favicon of the site that the news source is from. For example, tweets would have a twitter icon, news posts would have the RuneScape home page icon, and Runelite updates would have the Runelite icon.

We've removed the news feed plugin as Twitter's API is no longer freely accessible, and OSRS/RuneLite posts are more easily accessed directly via their websites.


Fix peer.close -> peer.destroy

Same to your commit a while ago.
Ref: https://github.com/leader22/webrtc-samples/commit/c322bd8be0e01d4128b3e8f8571d542a35b0e2fd

Nice catch! 👍
but I've already fixed it, as you know... 🌞


Add new class for functional tests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

132 of 132 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.594%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5230

Relevant Lines:
14292

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

132 of 132 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.594%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5230

Relevant Lines:
14292

💛  - Coveralls


BlobLoggerProvider forces rigid Blob folder structure

Issue Title
Azure BlobLoggerProvider forces rigid blob folder structure of Year/Month/Day/Hour/ApplicationId_applicationLog.txt
General
When using Azure BlobLoggerProvider class to log items, the resulting file structure is deeply nested in Year/Month/Day/Hour/ with a very long applicationId as part of the file name. Every hour in the day, the blob file structure changes. If there is a complaint, finding the log is difficult because the complaint may come from a different time zone than Azure blob time zone. Going through year, month, day, hour, and download the long log name is not practical if the hour is not definite.
I am proposing a change to overload AzureAppServiceLoggerFactoryExtension and modify BlobLoggerProvider to output a flat blob folder structure with custom filaname prefix and date without hour as part of the filename

Wrong section. I reposted in the correct section here: https://github.com/dotnet/extensions/issues/3384


The Fleet Carrier screen is void

Describe the bug
By opening the section dedicated to Carrier, the screen appears very small and empty.
It is not possible to trace any component present in that screen.
In the EDMC settings, the CAPI section connected to Fleet Carriers is active.
Log files
EDMarketConnector-debug-P1.log
EDMarketConnector-debug-P2.log
EDMarketConnector.log
To Reproduce
Steps to reproduce the behavior:

On the home page, click on the Fleet Carrier icon
The window appears incomplete and empty

Expected behavior
After opening the Fleet Carrier section I would expect to see related information.
Screenshots

Desktop:

OS: Windows 11 and 10
Plugin Version 3.6.1 to 4.0.0-a2
EDMC Version 5.10.6

That is definitely breaking when trying to initially load the window so there should be errors logged to the EDMC log files.
Could you attach your logs to this issue or DM them to me on Discord if you want to keep them private. See the troubleshooting page for the location of these.

That is definitely breaking when trying to initially load the window so there should be errors logged to the EDMC log files.
Could you attach your logs to this issue or DM them to me on Discord if you want to keep them private. See the troubleshooting page for the location of these.

The log files are already present in the original post.
However, if you need specific logs in which I have to perform specific actions, please tell me the sequence to perform.

That is definitely breaking when trying to initially load the window so there should be errors logged to the EDMC log files.
Could you attach your logs to this issue or DM them to me on Discord if you want to keep them private. See the troubleshooting page for the location of these.

The log files are already present in the original post.
However, if you need specific logs in which I have to perform specific actions, please tell me the sequence to perform.


logging actions dispatched from async effects

hi there! we are using redux-loop on our project, and noticed that redux-logger doesn't log actions dispatched from async effects. is there anything i can do about this?

i realised this isn't really an issue! solved


[Doc Improvement][Add SSO update][3465379]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/add-single-sign-on.md
94
9
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/add-single-sign-on.md
94
9
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Update sig-infra issue template description

Hi, there is still some old clarification: Catena-X NG project is deprecated. This could lead to misunderstandings :)

related to infos to here: https://github.com/eclipse-tractusx/sig-infra/pull/504


Promote the up-board out of beta

Fixed by https://github.com/resin-os/resin-up-board/pull/34

https://github.com/resin-os/resin-up-board/pull/34 has been merged so we close this issue here


Design guidelines (do's and don'ts)

General Support Request
Design guidelines for hyperlink will be added to the Figma blueprint file.
Link

Great progress. Looking awesome!

Added all guidelines.

So great! Good job!


Support Parquet bloom filter

Description
Hi Velox community,
Parquet 1.12 has defined the bloom filter feature which allows to filter out more data precisely when reading. Here's the detail spec in parquet-format: https://github.com/apache/parquet-format/blob/master/BloomFilter.md
Recent Spark has also imported this feature and will automatically do bloom filtering if it exists in metadata.
https://github.com/apache/spark/blob/branch-3.3/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala#L1895-L1923
It would be great to have this feature in Velox native parquet reader as it would benefit the table scan performance a lot. The write code path may require time as arrow parquet write seems does not support this feature yet.
CC: @mbasmanova @oerling
Thanks, -yuan

@zhouyuan Would you be interested in adding this functionality?

@mbasmanova yes, have done some local tests here and I could help to implement this.
-yuan

Can you share your implementation plan here?  This is not Parquet-only work and need some common filter framework support.
How would you design the bloom filter interface that will be passed to filters?  How do you decide the hashing for strings?  This bloom filter interface must be generic enough and not restricted to the Parquet bloom filter implementation above.  It needs to handle both int64 and strings.  Once the interface is decided (say an interface class IBloomFilter), we can add Filter::testBloomFilter(const IBloomFilter&) const to all the filters.
Then for the Parquet specific part, you can implement a subclass of IBloomFilter, and in ParquetData::rowGroupMatches, parse the Parquet metadata into this subclass, then check if the filter is disjunctive with the bloom filter using Filter::testBloomFilter you added before.

There is a method in ScanSpec that checks a stats against a Filter. The Bloom filter itself is encapsulated inside ColumnStats. The hash  for different data types is specified by the file format, as is the layout of the Bloom filter. We switch on the format kind by subclassing ColumnStats, for example.
This operates on metadata only.
Pushing down an approximate filter, like an approxinmate variant of BigintValues is a different thing and not needed for this occasion.


Convert weights for use with Theano backend and TH dim ordering

Since Tensorflow and Theano implement convolutions in different ways it is necessary to port a new set of weights for use with the Theano backend with TH dim ordering.

Per the changes in c5e47d1dcd1f96089798f581e20fa7911a0e1681, the convolution weights are fully converted for theano with th dim ordering.
However, according to @fchollet it is also necessary to row-shuffle the weights of the Dense layer.
Currently have tried a few things but will continue to work on this as I have time or until someone else finds a solution (PR's welcome!).

This issue has been solved, see 90d71706bc708602b40db0e9ee9c52220f4ec2ca for details.


Use the Plugin DOM in other DOM objects

Signed-off-by: Nate Koenig<EMAIL_ADDRESS>🎉 New feature
Summary
A lot of file have changed, but most of the changes all follow an identical pattern.
There is a Plugin DOM object, but only the GUI DOM object was using it. This is particularly problematic when attempting to build and use a programmatically created DOM. For example, Ignition Gazebo is currently relying on the Element() function(s) to access plugin information. This will not work for programmatically create DOM objects.
I've also added input and output stream operators to the Plugin class. This is here to facilitate the use of VectorSerialization. This is also the reason why I choose to access a std::vector of Plugins rather than use the ByIndex and ByName pattern.
Example usage in https://github.com/ignitionrobotics/ign-gazebo/pull/1352.
Test it
Run the tests.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[x] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

 [8263e52](/ignitionrobotics/sdformat/pull/858/commits/8263e520cd0a71be599f719c635ce7e2132fa5be)

Added in 8263e52

This pull request has been mentioned on Gazebo Community. There might be relevant details there:
https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1


New Category Request

This issue is a:
[ ] Bug Report
[ ] Enhancement suggestion
[X] Feature request
Enhancement suggestions / feature requests
Would you consider adding a new category under Tools & Frameworks? I want to add RabbitMQ product but I couldn't choose a suitable category.

To be honest, we'd be happy with it under Databases or Architecture. At the moment we want to tightly control categories only splitting them out when we have sufficient apps in there to need them. if we get a few more similar things, then we would likely split it out.

Okay. I continue with the Architecture category. Thank you.


utilities to be used for writing metatheorems about duality

For now, this is just a start. (Do not merge yet, just putting it up so other folks can give feedback in the meantime.)
The most notable metatheorem here so far is DualizeEquationLawImplication, which allows us to convert e1 = e2 -> e3 = e4 to e1* = e2* -> e3* = e4*. However, it is still very clunky to use, since ⊧ is defined in terms of substitution functions Nat -> G. As a proof of concept I'd like to add an example showing how DualizeEquationLawImplication can be used to deduce Equation3_implies_Equation23 from Equation3_implies_Equation8, but I haven't gotten to this yet.
I also notice that @codyroux has given their own definition for ⊧ which differs from mine in that it is more polymorphic. This is fine - I think their PR should be merged before this one, and then I'll clobber my definition with theirs and fix any of my existing theorems to work with that definition.

Cool! The PR is now #123, which contains more stuff (and hopefully passes the dry-run). I'm happy to fix this myself if it's easier.

@codyroux I've gone ahead and updated my duality work to be consistent with your definition of ⊧. (I like your polymorphic version better. ☺)

awaiting-review
This is ready for review now that #123 is merged.

It seems that this is overlapping with https://github.com/teorth/equational_theories/blob/main/equational_theories/MagmaOp.lean, sadly we should have coordinated earlier. Maybe this one can subsume that one? @franklindyer do you want to open a channel on the Zulip to discuss this?

It seems that this is overlapping with https://github.com/teorth/equational_theories/blob/main/equational_theories/MagmaOp.lean, sadly we should have coordinated earlier. Maybe this one can subsume that one? @franklindyer do you want to open a channel on the Zulip to discuss this?

Oops, I did not notice that. Looks like it proves the duality theorem a heck of a lot more quickly haha - I will just go ahead and close this PR. Might open separate PRs for some of bits and pieces that can be salvaged from this.


Automator: update proxy@master in istio/istio@master

Generated by Automator - 2024-07-07T14:32:31+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
924b1de104cc1f382e24ee9d5dda667b4c7e9d00
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
ec32ca5508d122282a733b37f42d12dddd44829e
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


[GEP-18] Fix basic auth secret migration for secrets without CSV data

How to categorize this PR?

/area security
/kind bug
What this PR does / why we need it:
With #5608 we are migrating the monitoring-ingress-credentials{-users} secrets from the legacy secrets management to the new secrets manager. However, for existing shoot clusters which were created a long time ago, the existing secrets do not have the .data["basic_auth.csv"] key (this was only introduced with #353). Hence, the migration failed with
Flow "Shoot cluster reconciliation" encountered task errors: [task
"Reconciling Grafana for Shoot in Seed for the logging stack" failed:
retry failed with context deadline exceeded, last error: invalid CSV for
loading basic auth data:  task "Deploying Shoot monitoring stack in Seed"
failed: retry failed with context deadline exceeded, last error: secret
"observability-ingress" not found]

Special notes for your reviewer:
/cc @timebertt @ialidzhikov
Release note:

A bug has been fixed which prevented the migration of existing basic auth secrets without CSV data to the new secrets manager.

/cherrypick release-v1.44


cloudbase-init doesn't support cidata label

An attempt was made to correct this, however the value passed through to this function is still 'config-2'
https://github.com/cloudbase/cloudbase-init/blob/4bb6895f115c8cb20ee9be37d5facc84243d0113/cloudbaseinit/metadata/services/configdrive.py#L30
We recently got a request to customize cloud-utils due to this.

I just filed a PR for this.
Aside: Gerrit seems to be preventing contributions. I only went through with it because I plan to submit a PR against Nova soon, which also uses it. Learning a new workflow for one-off contributions like this is painful.

I just filed a PR for this.
Aside: Gerrit seems to be preventing contributions. I only went through with it because I plan to submit a PR against Nova soon, which also uses it. Learning a new workflow for one-off contributions like this is painful.

Hello, thank you for the PR. I know that the Gerrit is not a straightforward experience, we are planning to move to Github in the future. Will update the Gerrit review page with my comments on the fix.
Thank you!

It looks like commit 9b17eaf1d4 hasn't been released yet, which probably explains why the user has to use the config-2 label.
When is the next cloudbase-init release expected? I'd like to let the user know when they can expect this feature will be available.
Since this is an upcoming feature in cloudbase, I don't think that adding a short-lived workaround to cloud-utils makes sense, so I just rejected the proposal to add arbitrary label names to cloud-utils.

Hello, thank you for the PR. I know that the Gerrit is not a straightforward experience, we are planning to move to Github in the future. Will update the Gerrit review page with my comments on the fix.
Thank you!

+1 Great! :)

Hello, we have a few small PR backlog to merge first before a new release, but it should happen in the next month or so (already one year since the last release). I will update this issue once a new stable version has been released.
Thank you,
Adrian.


RSS Feed - Dumb question...

Apologies, I've been poking around in the docs and not found the solution...
How do I remove the RSS Feed link from the footer?
Any help/advice gratefully accepted...

You'll have to pull out this line from _includes/scripts.html

 {{ site.data.ui-text[site.locale].feed_label | default: "Feed" }}

https://github.com/mmistakes/minimal-mistakes/blob/master/_includes/footer.html#L21

Star! 🥇

could this be made an config option?

How would this work if I use the remote theme?

@stefanbschneider It works the same way as gem based theme. Copy _includes/footer.html to your local repo, make whatever changes you need.
Local copies of _includes, _layouts, etc. override those in the theme. There's more documentation on this at the official Jekyll docs.

The fix works like a charm, but now disables my email link in the both the footer and sidebar.

For anyone coming from Google, the feed can be disabled by setting the follwing configuration property in _config.yml:
atom_feed:
  hide: true


add slider to elements #7

#7
Created a functioning value slider element

Tested with lighthouse and it gets a 100% in a11y, there is no styling so far. Also it looks like every component has a markdown file and a stylus file have not implemented those just yet may need some instruction on those

Checklist:

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

 It seems you missed this https://github.com/creativecommons/cc-vocabulary/issues/7#issuecomment-524533760 from the discussion on the issue.

On Tue, Oct 15, 2019 at 2:49 PM Dhruv Bhanushali<EMAIL_ADDRESS>wrote:

I hate to break it to you, but you got the wrong component friend. It
seems you missed this #7 (comment)
https://github.com/creativecommons/cc-vocabulary/issues/7#issuecomment-524533760
from the discussion on the issue.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/creativecommons/cc-vocabulary/pull/45?email_source=notifications&email_token=ABKCOHCT2SQHJKQCJ6LA2A3QOYNE7A5CNFSM4JAWVBK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBKAAIA#issuecomment-542375968,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKCOHFHOPK4SJ4JFLMKPVDQOYNE7ANCNFSM4JAWVBKQ
.

can you let me know which component I am suppose to be working on?
--

Striving to be better every day

so you want a double range slider instead of just a one range slider?
On Tue, Oct 15, 2019 at 4:34 PM Rashad Madison<EMAIL_ADDRESS>wrote:

On Tue, Oct 15, 2019 at 2:49 PM Dhruv Bhanushali<EMAIL_ADDRESS>wrote:

I hate to break it to you, but you got the wrong component friend. It
seems you missed this #7 (comment)
https://github.com/creativecommons/cc-vocabulary/issues/7#issuecomment-524533760
from the discussion on the issue.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/creativecommons/cc-vocabulary/pull/45?email_source=notifications&email_token=ABKCOHCT2SQHJKQCJ6LA2A3QOYNE7A5CNFSM4JAWVBK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBKAAIA#issuecomment-542375968,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKCOHFHOPK4SJ4JFLMKPVDQOYNE7ANCNFSM4JAWVBKQ
.

can you let me know which component I am suppose to be working on?
--

Striving to be better every day

--

Striving to be better every day

Oh I could just expand from the code I already have. Should not take that
long.
On Tue, Oct 15, 2019 at 4:56 PM Rashad Madison<EMAIL_ADDRESS>wrote:

so you want a double range slider instead of just a one range slider?
On Tue, Oct 15, 2019 at 4:34 PM Rashad Madison<EMAIL_ADDRESS>wrote:

On Tue, Oct 15, 2019 at 2:49 PM Dhruv Bhanushali <
<EMAIL_ADDRESS>wrote:

I hate to break it to you, but you got the wrong component friend. It
seems you missed this #7 (comment)
https://github.com/creativecommons/cc-vocabulary/issues/7#issuecomment-524533760
from the discussion on the issue.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/creativecommons/cc-vocabulary/pull/45?email_source=notifications&email_token=ABKCOHCT2SQHJKQCJ6LA2A3QOYNE7A5CNFSM4JAWVBK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBKAAIA#issuecomment-542375968,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKCOHFHOPK4SJ4JFLMKPVDQOYNE7ANCNFSM4JAWVBKQ
.

can you let me know which component I am suppose to be working on?
--

Striving to be better every day

--

Striving to be better every day

--

Striving to be better every day

Is PR #60 meant to supersede this?


Docs do not explain the maximum allocatable size

The documentation does not explain what the maximum allocatable size is per the media used.

This depends on the allocator and platform used. You can see (and change) defaults in config.h: http://rhelmus.github.io/virtmem/config_8h_source.html


intelsgx: update GetQeTargetInfo() API

There are 3 schemes:
Scheme 1

GetQeTargetInfoEx() should be renamed to GetQeTargetInfo() and replace the legacy GetQeTargetInfo() for EPID.
All callers to the legacy GetQeTargetInfo() need to change to add the quote type parameter.
The quote type parameter is acquired from the caller's context.

Scheme 2

Keep GetQeTargetInfo() constant, still without explicitly specifying quote type by the callers.
Implement isDcap() internal to intelsgx.
In GetQeTargetInfo(), isDcap() decides the dispatch to GetQeTargetInfoEx() or the legacy GetQeTargetInfo().

Scheme 3

Based on scheme 1, allow the existing callers to specify a quote type called quoteTypeDefault, which implies calling isDcap() mentioned in scheme 2 to determine the actual quote type.

Note: the legacy GetQeTargetInfo() for EPID must be renamed, but it should not be removed because the old version of psw may not support init-quote-ex pb message. In other word, if quote type is related to EPID but init-quote-ex pb message is unavailable (return error), try to call the legacy codes in the legacy GetQeTargetInfo().

I will achieve ecdsa.GetTargetInfo and epid.GetTargetInfo(WIP).


Animation clipping through walls

Would it be possible to do something about animations clipping through floors and walls?

I don't think so.
It's the way how isometric 2D game work when you have sprites larger than a tile size.