Update unit tests and lint all JS files

Changes

Ran eslint --fix to update all the JS files to match CFPB's syntax rules
Updated front-end unit tests
Cleaned up README and added front-end notes

Testing

Try the front-end steps in the README and lmk if they work

Update: I also set up Travis.

I should have looked at this before I started on #29. I'm going to merge this and then reconcile over there.


🐛 [firebase_auth] verifyPhoneNumber error - If app delegate swizzling is disabled, remote notifications received by UIApplicationDelegate need to be forwarded to FIRAuth's canHandleNotificaton: method.

Bug report
Describe the bug
when I try to use FirebaseAuth.instance.verifyPhoneNumber, verificationFailed triggers with the following message: "If app delegate swizzling is disabled, remote notifications received by UIApplicationDelegate need to be forwarded to FIRAuth's canHandleNotificaton: method."
According to some other issues I read, this is because I'm also using firebase messaging.
This should be fixed according to https://github.com/firebase/flutterfire/issues/4970#issuecomment-1024108801
Steps to reproduce
Steps to reproduce the behavior:
run FirebaseAuth.instance.verifyPhoneNumber with your phone number
I have the latest versions of firebase_messaging, firebase_core, and firebase_authentication
Expected behavior
I expect to receive an sms verification code

I'm getting the same error after adding firebase_messaging to my project. Already tried multiple solutions found on old issues and threads, nothing works. Also tried using older firebase_messaging version alongside the latest firebase_auth version, no success.

I'm getting the same error after adding firebase_messaging to my project. Already tried multiple solutions found on old issues and threads, nothing works. Also tried using older firebase_messaging version alongside the latest firebase_auth version, no success.

I got it running by replacing my entire AppDelegate.swift file with the following
`import UIKit
import Flutter
import Firebase
@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
override func application(
_ application: UIApplication,
didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
) -> Bool {
FirebaseApp.configure()
GeneratedPluginRegistrant.register(with: self)
if #available(iOS 10.0, *) {
UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
}
if(!UserDefaults.standard.bool(forKey: "Notification")) {
UNUserNotificationCenter.current().removeAllPendingNotificationRequests()
UserDefaults.standard.set(true, forKey: "Notification")
}
return super.application(application, didFinishLaunchingWithOptions: launchOptions)

}
override func application(_ application: UIApplication, didReceiveRemoteNotification userInfo: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {
    super.application(application, didReceiveRemoteNotification: userInfo, fetchCompletionHandler: completionHandler)
      let firebaseAuth = Auth.auth()
        Messaging.messaging().appDidReceiveMessage(userInfo)
        print(userInfo)
      if (firebaseAuth.canHandleNotification(userInfo)){
          completionHandler(.noData)
          return
      }
  }

}`
I still think this shouldn't be necessary though, especially given that it hasn't been necessary with certain versions in the past, and using both fcm and sms verification together is very common.

Thank you for sharing your solution, it is my second day trying to figure this out. Unfortunately your solution does not work for me. I'm using firebase_auth: 3.3.20 and firebase_messaging: 10.2.6. Did you added this to your Info.plist?
<key>FirebaseAppDelegateProxyEnabled</key>
<false/>

I tried with and without using the same AppDelegate as you suggested. Still received the error message while trying to validate a phone number.

@Justus-M and @ArielFarias
This is because silent push notifications are needed for phone auth. Firebase messaging without app delegate swizzling will consume all of the messages and it will not work. In order to use firebase messaging with anything else that needs to receive the message data natively you need to enable it. See https://firebase.google.com/docs/auth/ios/phone-auth#appendix:-using-phone-sign-in-without-swizzling for more reference and check if it helps.

@darshankawar Is it normal to expect flutter developers with no native iOS/swift experience to go in and modify swift code?
This documentation seems to be created for iOS developers, not flutter developers.
As far as I can recall, this is pretty much the only time it's necessary for a flutter developer to actually go in and modify swift code.
According to several comments in other threads, this was not an issue with some past versions of the packages, so it seems to be preventable.
Using push notifications and phone verification together is very common, and I think it should not be necessary for a flutter developer to go through documentation created for iOS developers to make that work.

@Justus-M Thanks for feedback.
Flutterfire plugins are wrappers around native Firebase sdks and leverages implementation by sending and receiving data through Dart and the ios documentation seems to be an example of it.
Have you tried already to make changes as mentioned in the document and confirm if it works ?

@darshankawar
The link you provided leads to some code snippets which I guess should be implemented.
2 things are unclear to me as a flutter developer with no native knowledge (this is the difference between iOS/swift developer docs and flutter developer docs)

Where should these changes be made? I don't even know which file to look at
Which of these snippets need to be implemented? Do I just copy and paste all of them in?

@Justus-M and @ArielFarias This is because silent push notifications are needed for phone auth. Firebase messaging without app delegate swizzling will consume all of the messages and it will not work. In order to use firebase messaging with anything else that needs to receive the message data natively you need to enable it. See https://firebase.google.com/docs/auth/ios/phone-auth#appendix:-using-phone-sign-in-without-swizzling for more reference and check if it helps.

I tried to understand what to do with these snippets, (but as a Flutter developer I don't have knowlege with native iOS, only native Android). Anyway I put them inside of AppDelegate.swift and got the same error on phone verification.
What does not makes sense is why we need to do this now if that was not needed in older versions of firebase_auth and firebase_messaging. The company where I work have an app published on both, iOS and Android store for more than a year now which uses firebase_messaging and firebase_auth with phone authentication and works fine, none of these native swift code are implemented there.

Thanks for the update and feedback. I am keeping this open and labeling it for further insights from the team.
/cc @russellwheatley. For your reference: similar issue and resolution comment: https://github.com/firebase/flutterfire/issues/4970#issuecomment-1024108801 . Also, https://github.com/firebase/flutterfire/issues/9010#issuecomment-1172135199

Hi, the same issue is happening to me as well on the latest versions of firebase_messaging and firebase_auth.
Replacing AppDelegate.swift works as well, but the app crashes on first install. (I don't know how to fix it since I'm not a native developer)
Further investigations would be appreciated.

After days of trying, I found out that phone authentication and messaging both works properly without replacing AppDelegate.swift and without disabling method swizzling on previous versions below.
firebase_core: ^1.17.0
firebase_auth: ^3.3.18
firebase_messaging: ^11.4.0
There might have been some regression on recent version upgrades.

After days of trying, I found out that phone authentication and messaging both works properly without replacing AppDelegate.swift and without disabling method swizzling on previous versions below.
firebase_core: ^1.17.0 firebase_auth: ^3.3.18 firebase_messaging: ^11.4.0
There might have been some regression on recent version upgrades.

Strangely, this isn't working for me. I restored my old AppDelegate.swift file and switched to your recommended package versions, but received the error again.
Unfortunately replacing AppDelegate.swift results in an app crash for some of my users during firebase auth sms verification, so I'm still looking for a workaround that doesn't involve replacing AppDelegate.swift, But I currently don't have any other solutions.

That's weird. As soon as I upgrade firebase dependencies, phone authentication stops working again.

Thanks for your quick response.
When I tried your recommended packages i changed by AppDelegate.swift back to this:
import UIKit
import Flutter

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
    GeneratedPluginRegistrant.register(with: self)
    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }

Hi, the same issue is happening to me as well on the latest versions of firebase_messaging and firebase_auth. Replacing AppDelegate.swift works as well, but the app crashes on first install. (I don't know how to fix it since I'm not a native developer) Further investigations would be appreciated.

Im having the exactly same issue. For some ios users, the app crashes on the First phone auth try.
Does any1 have an updated solution?

After trying & searching for a half day I found its simple solution 😂
Just import Firebase. Make sure you don't import any other Firebase libraries.
As I was using Maps too, So I'm going to share my own AppDelegate.swift file
import UIKit
import Flutter
import GoogleMaps
import Firebase

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
    FirebaseApp.configure()
    GMSServices.provideAPIKey("AIzaSyB2tfPVP5CVeqDZAtuMjzE_tz0K62Gb_LY")
    GeneratedPluginRegistrant.register(with: self)
    if #available(iOS 10.0, *) {
      UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
    }
    if(!UserDefaults.standard.bool(forKey: "Notification")) {
        UNUserNotificationCenter.current().removeAllPendingNotificationRequests()
        UserDefaults.standard.set(true, forKey: "Notification")
    }

    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }

    override func application(_ application: UIApplication, didReceiveRemoteNotification userInfo: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {
        super.application(application, didReceiveRemoteNotification: userInfo, fetchCompletionHandler: completionHandler)
          let firebaseAuth = Auth.auth()
            Messaging.messaging().appDidReceiveMessage(userInfo)
            print(userInfo)
          if (firebaseAuth.canHandleNotification(userInfo)){
              completionHandler(.noData)
              return
          }
      }

}

No need to import FirebaseAuth, FirebaseMessaging or FirebaseAnalytics in your AppDelegate.swift.

After days of trying, I found out that phone authentication and messaging both works properly without replacing AppDelegate.swift and without disabling method swizzling on previous versions below.
firebase_core: ^1.17.0 firebase_auth: ^3.3.18 firebase_messaging: ^11.4.0
There might have been some regression on recent version upgrades.

@MinseokKang003 old packages are no longer working with other newer packages. were you able to fix this issue?
@Justus-M Any update on a solution?

I am facing this issue as well. Though for the first time users it is failing.
My AppDelegate code :
import UIKit
import Flutter
import Firebase

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
    FirebaseApp.configure()
    GeneratedPluginRegistrant.register(with: self)
    if #available(iOS 10.0, *) {
      UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
    }
    if(!UserDefaults.standard.bool(forKey: "Notification")) {
        UNUserNotificationCenter.current().removeAllPendingNotificationRequests()
        UserDefaults.standard.set(true, forKey: "Notification")
    }

    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }

    override func application(_ application: UIApplication, didReceiveRemoteNotification userInfo: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {
        super.application(application, didReceiveRemoteNotification: userInfo, fetchCompletionHandler: completionHandler)
          let firebaseAuth = Auth.auth()
            Messaging.messaging().appDidReceiveMessage(userInfo)
            print(userInfo)
          if (firebaseAuth.canHandleNotification(userInfo)){
              completionHandler(.noData)
              return
          }
      }
}

Using the following pubs :
firebase_auth: ^3.11.0
firebase_messaging: ^13.0.4
Also FirebaseAppDelegateProxyEnabled is set to Boolean NO as suggested on google's firebase description.
Any update on a solution for this ?

After days of trying, I found out that phone authentication and messaging both works properly without replacing AppDelegate.swift and without disabling method swizzling on previous versions below.
firebase_core: ^1.17.0 firebase_auth: ^3.3.18 firebase_messaging: ^11.4.0
There might have been some regression on recent version upgrades.

@MinseokKang003 old packages are no longer working with other newer packages. were you able to fix this issue?
@Justus-M Any update on a solution?

Check here: https://github.com/firebase/flutterfire/issues/9010?notification_referrer_id=NT_kwDOBFmOV7MzOTE0MTUzOTg3OjcyOTc4MDA3&notifications_query=is%3Aunread#issuecomment-1251750689

I am facing this issue as well. For the first time ios users, the app is crashing.
My AppDelegate code :
import UIKit
import Flutter
import Firebase

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
    FirebaseApp.configure()
    GeneratedPluginRegistrant.register(with: self)
    if #available(iOS 10.0, *) {
      UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
    }
    if(!UserDefaults.standard.bool(forKey: "Notification")) {
        UNUserNotificationCenter.current().removeAllPendingNotificationRequests()
        UserDefaults.standard.set(true, forKey: "Notification")
    }

    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }

    override func application(_ application: UIApplication, didReceiveRemoteNotification userInfo: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {
        super.application(application, didReceiveRemoteNotification: userInfo, fetchCompletionHandler: completionHandler)
          let firebaseAuth = Auth.auth()
            Messaging.messaging().appDidReceiveMessage(userInfo)
            print(userInfo)
          if (firebaseAuth.canHandleNotification(userInfo)){
              completionHandler(.noData)
              return
          }
      }
}

Using the following pubs : firebase_auth: ^3.11.0 firebase_messaging: ^13.0.4
Also FirebaseAppDelegateProxyEnabled is set to Boolean NO as suggested on google's firebase description.
Any update on a solution for this ?

C

I am facing this issue as well. For the first time ios users, the app is crashing.
My AppDelegate code :
import UIKit
import Flutter
import Firebase

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
    FirebaseApp.configure()
    GeneratedPluginRegistrant.register(with: self)
    if #available(iOS 10.0, *) {
      UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
    }
    if(!UserDefaults.standard.bool(forKey: "Notification")) {
        UNUserNotificationCenter.current().removeAllPendingNotificationRequests()
        UserDefaults.standard.set(true, forKey: "Notification")
    }

    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }

    override func application(_ application: UIApplication, didReceiveRemoteNotification userInfo: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {
        super.application(application, didReceiveRemoteNotification: userInfo, fetchCompletionHandler: completionHandler)
          let firebaseAuth = Auth.auth()
            Messaging.messaging().appDidReceiveMessage(userInfo)
            print(userInfo)
          if (firebaseAuth.canHandleNotification(userInfo)){
              completionHandler(.noData)
              return
          }
      }
}

Using the following pubs : firebase_auth: ^3.11.0 firebase_messaging: ^13.0.4
Also FirebaseAppDelegateProxyEnabled is set to Boolean NO as suggested on google's firebase description.
Any update on a solution for this ?

Check here: https://github.com/firebase/flutterfire/issues/9010?notification_referrer_id=NT_kwDOBFmOV7MzOTE0MTUzOTg3OjcyOTc4MDA3&notifications_query=is%3Aunread#issuecomment-1251750689

Did anyone come up with a good solution to this? My app was working perfectly until recently and too many things have changed since I went back and tried my login screen. It could be updating to flutter 3.7.0 or one of my recently added libraries. the updates to AppDelegate did fix the problem on my end but I worry that it will cause crashes as mentioned by others.

@jasonJamEther
For me the solution in the end was using static versions of all my firebase libs, which is not recommended, but if it works it works.
      firebase_core: 1.20.0
      firebase_auth: 3.5.0
      firebase_messaging: 12.0.1
      firebase_storage: 10.3.3
      cloud_firestore: 3.4.1
      firebase_dynamic_links: 4.2.5
      firebase_analytics: 9.1.0
      firebase_crashlytics: 2.0.4
      firebase_performance: 0.8.0+13
      firebase_remote_config: 2.0.1
      firebase_in_app_messaging: 0.6.0+8

  dependency_overrides:
      firebase_auth_platform_interface: 6.4.0
      firebase_core_platform_interface: 4.5.1

That is my current AppDelegate file:
import Flutter
import Firebase

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
override func application(
  _ application: UIApplication,
  didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
) -> Bool {
  FirebaseApp.configure()
  GeneratedPluginRegistrant.register(with: self)
  if #available(iOS 10.0, *) {
      UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
  }

    // That is for logging out from firebase auth after doing logout in Flutter code
    let userDefaults = UserDefaults.standard
    if userDefaults.value(forKey: "appFirstTimeOpend") == nil {
        //if app is first time opened then it will be nil
        userDefaults.setValue(true, forKey: "appFirstTimeOpend")
        // signOut from Auth
        do {
            try Auth.auth().signOut()
        } catch {

        }
    }

  return super.application(application, didFinishLaunchingWithOptions: launchOptions)
}
}

Also note that I'm not changing or setting any FirebaseAppDelegateProxyEnabled key!

Thank you for the answer. Have you ever experienced crashes with this AppDelegate file?

Thank you for the answer. Have you ever experienced crashes with this AppDelegate file?

No.

Thank you for the answer. Have you ever experienced crashes with this AppDelegate file?

No.

Thank you for your quick reply. I see that your AppDelegate is not importing UIKit, what's the reason?

import Flutter
import Firebase

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
override func application(
  _ application: UIApplication,
  didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
) -> Bool {
  FirebaseApp.configure()
  GeneratedPluginRegistrant.register(with: self)
  if #available(iOS 10.0, *) {
      UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
  }

    // That is for logging out from firebase auth after doing logout in Flutter code
    let userDefaults = UserDefaults.standard
    if userDefaults.value(forKey: "appFirstTimeOpend") == nil {
        //if app is first time opened then it will be nil
        userDefaults.setValue(true, forKey: "appFirstTimeOpend")
        // signOut from Auth
        do {
            try Auth.auth().signOut()
        } catch {

        }
    }

  return super.application(application, didFinishLaunchingWithOptions: launchOptions)
}
}

I get an error when I use this AppDelegate code you shared.
The error I got: "If app delegate swizzling is disabled, remote notifications received by UIApplicationDelegate need to be forwarded to FIRAuth's canHandleNotificaton: method."

import Flutter
import Firebase

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
override func application(
  _ application: UIApplication,
  didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
) -> Bool {
  FirebaseApp.configure()
  GeneratedPluginRegistrant.register(with: self)
  if #available(iOS 10.0, *) {
      UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
  }

    // That is for logging out from firebase auth after doing logout in Flutter code
    let userDefaults = UserDefaults.standard
    if userDefaults.value(forKey: "appFirstTimeOpend") == nil {
        //if app is first time opened then it will be nil
        userDefaults.setValue(true, forKey: "appFirstTimeOpend")
        // signOut from Auth
        do {
            try Auth.auth().signOut()
        } catch {

        }
    }

  return super.application(application, didFinishLaunchingWithOptions: launchOptions)
}
}

@ArielFarias  I get an error when I use this AppDelegate code you shared.
The error I got: "If app delegate swizzling is disabled, remote notifications received by UIApplicationDelegate need to be forwarded to FIRAuth's canHandleNotificaton: method."

Thank you for the answer. Have you ever experienced crashes with this AppDelegate file?

No.

Thank you for your quick reply. I see that your AppDelegate is not importing UIKit, what's the reason?

Because I dont need? I barely know swift, I work with Flutter for mobile development and just do things on swift when it is needed, therefore I have no idea what the UIKit lib does or why it is not needed.

Thank you for the answer. Have you ever experienced crashes with this AppDelegate file?

No.

Thank you for your quick reply. I see that your AppDelegate is not importing UIKit, what's the reason?

Because I dont need? I barely know swift, I work with Flutter for mobile development and just do things on swift when it is needed, therefore I have no idea what the UIKit lib does or why it is not needed.

import Flutter
import Firebase

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
override func application(
  _ application: UIApplication,
  didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
) -> Bool {
  FirebaseApp.configure()
  GeneratedPluginRegistrant.register(with: self)
  if #available(iOS 10.0, *) {
      UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
  }

    // That is for logging out from firebase auth after doing logout in Flutter code
    let userDefaults = UserDefaults.standard
    if userDefaults.value(forKey: "appFirstTimeOpend") == nil {
        //if app is first time opened then it will be nil
        userDefaults.setValue(true, forKey: "appFirstTimeOpend")
        // signOut from Auth
        do {
            try Auth.auth().signOut()
        } catch {

        }
    }

  return super.application(application, didFinishLaunchingWithOptions: launchOptions)
}
}

@ArielFarias
I tried with the AppDelegate file you sent but it doesn't work. How did it work for you?
The error I got: "If app delegate swizzling is disabled, remote notifications received by UIApplicationDelegate need to be forwarded to FIRAuth's canHandleNotificaton: method."

I remember that in my case, other third-party dependencies which use APNs was the culprit. It was RevenueCat or Stream Chat or Onesignal or something. As I completely removed it, it started working again(Check for pubspec.lock and native pods if it is completely removed). I only had to follow Firebase documentations.

Benim durumumda, APN'leri kullanan diğer üçüncü tarafların haklarına sahip olan kişilerdir. RevenueCat veya Stream Chat veya Onesignal veya başka bir şeydi. tamamen kaldırdığında tekrar çalışmaya başladı (tamamen kaldırıldıysa pubspec.lock ve yerel bölmeleri kontrol edin). Özel bir şey yapmak zorunda değildim.

I have firebase_messaging and I have to use that. In this case, can't we use it together with firebase_messaging?

I remember that in my case, other third-party dependencies which use APNs was the culprit. It was RevenueCat or Stream Chat or Onesignal or something. As I completely removed it, it started working again(Check for pubspec.lock and native pods if it is completely removed). I didn't have to do any special stuff.

I have firebase_messaging and I have to use that. In this case, can't we use it together with firebase_messaging?

No firebase messaging works well with this plugin. It was some plugin from the other company in my case.

I remember that in my case, other third-party dependencies which use APNs was the culprit. It was RevenueCat or Stream Chat or Onesignal or something. As I completely removed it, it started working again(Check for pubspec.lock and native pods if it is completely removed). I didn't have to do any special stuff.

I have firebase_messaging and I have to use that. In this case, can't we use it together with firebase_messaging?

No firebase messaging works well with this plugin. It was some plugin from the other company in my case.

@MinseokKang003
So why isn't there a solution when there are so many people experiencing this problem? #10364

@Cengizhanerturan
Hmm.. is that issue coming from the modified AppDelegate.swift file?
I haven't experienced this issue after I found out the culprit(third party plugin which is causing APNS related conflicts) .
You may try to create a brand new project and see if the issue persists.
Also double check your client ids such as reversed client id.
I really had a hard time with this issue too.

@MinseokKang003

Hmm.. is that issue coming from the modified AppDelegate.swift file?

Yes, this issue comes from the AppDelegate.swift file.

Also double check your client ids such as reversed client id.

I've checked the reversed client id multiple times and it's fine.
From what I've researched, everyone using firebase_messaging has this problem.

@Cengizhanerturan
Try not to modify the AppDelegate.swift file. I've done that and also got crashes from users. Also, Firebase does not tell people to do so.
I'm currently using firebase messaging and phone authentication in the production app and haven't got any errors yet.

@MinseokKang003
After completing the installations as written in the relevant document, if I do not make any changes to the AppDelegate.swift file, I get an error.
The error I got: "If app delegate swizzling is disabled, remote notifications received by UIApplicationDelegate need to be forwarded to FIRAuth's canHandleNotificaton: method."

I have reset my AppDelegate.swift back to default. I then removed Firebase_messaging from my code entirely. When I do this my app works as expected when I request a phone auth code. If I simply add firebase_messaging back to my pubspec.yaml file and recompile the app, I get the swizzling error as soon as I request a phone auth code.

I have reset my AppDelegate.swift back to default. I then removed Firebase_messaging from my code entirely. When I do this my app works as expected when I request a phone auth code. If I simply add firebase_messaging back to my pubspec.yaml file and recompile the app, I get the swizzling error as soon as I request a phone auth code.

I am definitely in the same situation...

I have reset my AppDelegate.swift back to default. I then removed Firebase_messaging from my code entirely. When I do this my app works as expected when I request a phone auth code. If I simply add firebase_messaging back to my pubspec.yaml file and recompile the app, I get the swizzling error as soon as I request a phone auth code.

Try editing your AppDelegate file with the following :

import UIKit
import Flutter
import GoogleMaps
import Firebase

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
    FirebaseApp.configure()
    GMSServices.provideAPIKey("*************************")
    GeneratedPluginRegistrant.register(with: self)
    if #available(iOS 10.0, *) {
      UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
    }
    if(!UserDefaults.standard.bool(forKey: "Notification")) {
        UNUserNotificationCenter.current().removeAllPendingNotificationRequests()
        UserDefaults.standard.set(true, forKey: "Notification")
    }

    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }

    override func application(_ application: UIApplication, didReceiveRemoteNotification userInfo: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {
        super.application(application, didReceiveRemoteNotification: userInfo, fetchCompletionHandler: completionHandler)
          let firebaseAuth = Auth.auth()
            Messaging.messaging().appDidReceiveMessage(userInfo)
            print(userInfo)
          if (firebaseAuth.canHandleNotification(userInfo)){
              completionHandler(.noData)
              return
          }
      }

}

No need to import FirebaseAuth, FirebaseMessaging or FirebaseAnalytics in your AppDelegate.swift.

And then add to your Podfile the following :
target 'ImageNotification' do   use_frameworks!   pod 'Firebase/Auth'   pod 'Firebase/Messaging' end
It work for me !
Found the solution here #10364

@Justus-M How are you initializing FirebaseApp ?

Hi @Justus-M  ,
Thank you for your report! Since this issue was opened, the implementation details have changed significantly. If you feel that this issue is still relevant, please feel free to open a new issue with updated context. We appreciate your understanding and support.


Create Linux binary artifact on CI

Create on CI and publish with the release assets.

Do we need this?

I don't think this is important for mainnet as people are used to build from code now.
Also see #245


FancyZones not working for Teamspeak 3

Environment
Windows build number: 10.0.18363.720
PowerToys version: v0.16.1
PowerToy module for which you are reporting the bug (if applicable):
Teamspeak 3: 3.5.2 (https://www.teamspeak.com/de/downloads/)

Steps to reproduce
Move Teamspeak 3 window while pressing shift key.
Expected behavior
Fancy zones should appear and window should snap to them.
Actual behavior
No fancy zones and snapping happens for the Teamspeak 3 window however it works for all other windows.
Similar to #970 and 1450 which has been fixed.

Hi @maxleonalbrecht
thank you for reporting the issue, it's a known problem with TeamSpeak 3, it requires PowerToys to run as administrator in order to work, you can read the details in https://github.com/microsoft/PowerToys/issues/1466
I'm closing this one as a duplicate.
Thanks.

Thank you!


Always throwing function: \BitWasp\Bitcoin\Transaction\Factory\Signer::setCheckerCreator

https://github.com/Bit-Wasp/bitcoin-php/blob/5e404b66c4b8386f978a44eeb1190098c3397bea/src/Transaction/Factory/Signer.php#L90
The signatureCreator member never equals null. The setCheckerCreator function always throws.
No way to set custom checkerCreator member.
I need it to upgrade the https://github.com/btccom/bitwasp-bitcoin-bch-addon to the latest bitwasp/bitcoin lib version.

@olegabr Hi! Thanks for opening this issue.
Yea I see what you mean - that's kind of annoying.. Wanna PR using count($this->signatureCreator) === 0 or something that works?
Two quick tests as well if you can

pass the project default CheckerCreatorBase immediately after creating the TxSigner - should work
pass the project default CheckerCreatorBase after calling 'input' or 'sign', should throw that exception

If not I might get to it soon

@afk11 Thank you for quick response, I'll see what I can do here.

@afk11, the PR is sent. Check it please.

Hi @olegabr - I merged your commit to 1.0 and master, and it looks like 0.0.35 doesn't have this issue!
Now released as v1.0.4


[REQ] Close Roblox "Do not show again"

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
Do not show this again when closing Roblox using Bloxstrap Tray

a wild fastvariable appears

fastvariable 🔥 🔥 🔥 🔥 🔥

closing this since it's too much effort for something pretty pointless honestly


(Pre-)RFC: river Application Distribution

Open Question: How do we build, release, and package river?
We will need to figure out how we make release builds of river, and how to make them available to early users. This may not necessarily be the "permanent" option - that will require collaboration with distribution packagers, etc.
For now, prebuilt binaries available on GitHub are likely reasonable for demonstration, and building from source with cargo install --locked is also reasonable.
I do also intend to investigate and likely use cargo-dist to power this initial release process.
I am open to suggestions or thoughts here, this is me generally signalling intent towards initial distribution plans.

A “plain” binary and a docker image would be a good set of artifacts. Both can be built and hosted on GitHub as part of making a release with a GitHub action.

@mcpherrinm yep! cargo-dist automates and generates these workflows automatically, which is my interest in it. It also creates installer scripts (if people feel like curlbashing).
A dockerfile is a good shout too!

Beyond the application itself, I'm sure the community will want a Helm chart, or Kustomize manifests to use once the container is created. I certainly will!

@jamesmunns to answer this question

Open Question: How do we build, release, and package river?

We need to look how the application will be run/consumed by the end user. Two of the most important ways that I can think of running an application are through:

Binary
Container Image

As long as we are able to distribute river in binary format supporting popular OS: linux, macOS(intel/apple silicon) and windows, we should be good.
These binaries can be used as building block to build & distribute container images, helm charts or k8s manifests for river at later point in time.
Now to answer your question, cargo-dist looks a good option as in its readme tag line, it says "cargo-dist distributes your binaries", and that's all we need right now.
We can also keep a stretch goal of distributing a minimal alpine based container image for river along with binary.

I agree on the delivery of binaries on the Github registry and a docker image, with the aim later to propose a deployment on  Kubernetes platforms.

A huge vote here for Kustomize manifests with sane defaults on a prepackaged deploy. This allows for one to then use Kustomize very easily in their necessary setup (along with all that Kustomize brings to the table). Helm charts add a ton of complexity that is hard to troubleshoot whether it is Helm doing something badly with terrible error processing (ugh been there too much) or if it's related to the manifest itself or some value in your values.yaml.
Further, Kubernetes is declarative, and so is Kustomize. Keeping within the same methodology is always a good thing imo.

What about publishing official pre-built package for most-used linux distros, Debian as an example, so that users can install river with apt install river like we install nginx with apt install nginx?

Initial release completed: https://github.com/memorysafety/river/releases/tag/v0.2.0, closing.


The "nodaemon" build needs to be documented and tested

Commit #89a5df6b (and the related IRC discussion) caused me to notice that we do not
a) Verify that a "nodaemon" build succeeds and works; even at a basic "does it start" level.
b) Document how to build a "nodaemon" version of the Elvish program.
This feature is currently meant to only address the needs of the u-root project. So addressing the above issues should be a low priority. Nonetheless, this project should have, at a minimum, a basic sanity test for building a "nodaemon" version of the Elvish binary and invoking it since that would have caught the problem fixed by the aforementioned commit.

I'm closing this because I expect the project to eliminate the need for an Elvish shell daemon in the not too distant future (see issue #1222). I would rather see effort spent making a "no daemon" build unnecessary than testing that a "no daemon" build works as expected.


Simple HTTP Authentication

Hi,
It would be nice to have a simple HTTP authentication mechanism to allow for one admin user, especially when running in-house.

If you don't need security (because you're running it in a secure/internal network), does the noop auth work for you in this case?

We are using noop at the moment. (no auth),  but it would still be good that only internal admins have access. I'm looking into using Traefik 2.0 as proxy with HTTP auth in front of Nebraska.


Improved design for the initial import process: searching by field (DOI, ISBN, ORCID)

Is your feature request related to a problem? Please describe.
As discussed in DSpace#8674, we would like to propose a different design for the inital import process to make it easier to understand for the users. We believe the current dropdown solution is not intuitive.
Describe the solution you'd like
Instead of a dropdown we would like to separate different identifier types into individual components with their own search fields and buttons. In the doi case this would combine with DSpace#8674 to allow searching for an DOI in different sources. So a user need not to know whether it's an DOI from datacite or crossref.
Additional context
Our mockup:

Suche = Search (for this row‘s identifier type in external sources). We have put an example identifier (z.B. = e.g). here for the researcher. In our implementation the orcid id is prefilled from the researcher profile as well.
This is quite different from the demo installation, where users are asked to specify the external source in question:

@johannastaudinger @philipprumpf

closed per #2138


[Feature Request]: Parameter exposure

Is there an existing issue for the same feature request?

[ ] I have checked the existing issues.

Is your feature request related to a problem?
I can't add fixed input to the diagram I draw on the interface

Describe the feature you'd like
Can the self.post_answers = [] in anget's Answer be exposed in the interface?
Describe implementation you've considered
No response
Documentation, adoption, use case
No response
Additional information
No response

Could you elabrate on your application scenario?

I am actually making an agent to generate teaching notes. However, if I search purely based on user input, the quality of the generated teaching notes will be uneven. So I am considering adding keywords to each step of the user input and then searching the knowledge base.


⚠ Livieres Guggiari has degraded performance

In 9cad7a8, Livieres Guggiari (https://livieresg.com.py) experienced degraded performance:

HTTP code: 200
Response time: 13000 ms

Resolved: Livieres Guggiari performance has improved in c517f67.


LIVE-2028 - Fix - Use hide empty sub account setting on accounts list

Use hide empty sub account setting on accounts list
Type
Bug fix
Context
https://ledgerhq.atlassian.net/browse/LIVE-2028
Parts of the app affected / Test plan
Accounts

@nparigi-ledger I see 2 things on the ticket that don't seem to be reflected in the code changes:

this "hiding" of accounts should be determined by some user settings (and maybe it should be hidden by default, idk if that has to be changed)
there is a mention of some copy to update


Search excluded files: VS reads .gitignore contents as case sensitive, but Git reads it as case insensitive

Issue Type: Bug

create a .gitignore like the following

# Ignore everything
*
# Don't ignore this file!
.gitignore
# Don't ignore readme files
!readme.md

Create a README.md file (be sure it is all caps) containing:

You can't see me.

Close the file (VS Code searches open files no matter what)
Use VS Code's file search feature to find see me.

Expected
The file is found.
Actual
The file is not found.

(If you now open the file, you'll see it is found)
https://user-images.githubusercontent.com/3663628/172645512-9cb8ed76-533e-476f-9d0c-6744a7f9d3cf.mp4
Additional info
My hypothesis: Git interprets .gitignore files as case insensitive, while VS Code reads the file as case sensitive. You can test this by changing the .gitignore to un-ignore README.md instead of readme.md and see that the search now finds the file. But in all cases, Git sees the file as available for version control.
The title of this issue implies my hypothesis, but perhaps there is a deeper issue where this only happens when you un-ignore a file using !.
Versions
VS Code version: Code - Insiders 1.68.0-insider (b7faf235467dd56e4a62e52e7f1cacf875b67261, 2022-06-07T18:34:09.305Z)
OS version: Darwin arm64 21.5.0
Restricted Mode: No

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.25GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256198
vstes627:30244334
vslsvsres303:30308271
pythonvspyl392:30422396
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
wslgetstarted:30449409
vscscmwlcmt:30465136
cppdebug:30492333
vscaac:30438845
pylanb8912:30496796
vsclangdf:30492506

This comes from ripgrep. You can file an issue at http://github.com/burntsushi/ripgrep but there is some complexity, it looks like case-sensitivity is configurable in git, and I guess it depends on the case-sensitivity of your filesystem too.


Vtk new module system

@doutriaux1 @scottwittenburg Please review.
After we test 1730 version of packages
https://anaconda.org/danlipsa/vtk-cdat
let's merge this. We could get rid of the redhat docker (I left it there for now). The centos6 docker was very useful to figure out what CDT packages we need, but probably it won't be that needed in the future. I would leave it in there though.

I think this is looking good so far, the build failures on that PR I linked are expected, as a few spurious triangles were remove from several isofill plots by some fix made to VTK since we updated last.  I'll just need to create a new branch in the baselines repo and then make some small change to vcs to pick it up.

@scottwittenburg Great. Let me know when you you've done that. I would be great to merge this so that is out of the way. Thanks!


cleanup svelte-check --ignore for  data-graphics

note: full text search shows that <Density and <ECDF does not show up any where in our codebase. They include both mistyped values as well as an imports that are unavailable in our repo, so I think they either haven't been used for a long time, or may never have actually been adopted. Deleted these under the "you ain't gonna need it" principle.
part of #3424

hey @djbarnwal , I have another review for you. I think it should all be pretty straightforward, but the one place where your expertise on this part of the codebase will be a big help is double checking whether "Date" is ever actually used in the DomainCoordinate type. Thanks!


Wrong pointer value in from_chars long-double fallback

There is a bug at https://github.com/cppalliance/charconv/blob/06d834728ae8970473f6ef18c079f0e7fae7b071/src/from_chars.cpp#L317
std::strtold is called with a pointer to a temporary std::string and a pointer relative to that is then returned by the function which after the function is invalid/dangling.
It also looks like this is duplicating an existing function that doesn't has this issue and is even better by using a local buffer before falling back to allocating: https://github.com/cppalliance/charconv/blob/06d834728ae8970473f6ef18c079f0e7fae7b071/include/boost/charconv/detail/from_chars_float_impl.hpp#L38 &
https://github.com/cppalliance/charconv/blob/06d834728ae8970473f6ef18c079f0e7fae7b071/include/boost/charconv/detail/from_chars_float_impl.hpp#L101
This should probably be tested too.

Testing is added here along with locale support: https://github.com/cppalliance/charconv/pull/123. Once it's merged I'll make the change. I am not sure when I replaced from_chars_strtod in from_chars but it was mistake to do so.


reorganizes book to allow partial translation

see #10 for context

moves existing content to en folder
creates one folder per section to make it easier to see which is index and which is additionnal page
creates a fr folder with top-priority content to be translated and pointing to en for content that probably won’t be translated soon to avoid duplication and lack of updates.

Relative links should still work and the lang.md file should act as an index, as it does in user-manual
However this will break existing external links such as https://www.loomio.school/beginner/decision_tools.html , which will need to be updated to https://www.loomio.school/en/beginner/decision_tools.html

After discussing the user-manual and Loomio School merge, I guess this PR  should be delayed and include the merge of the user manual repo and the new organization of Loomio School and the translated parts from the user manual.

Ok so this is a preview of the initial reorganization in locale subfolders: https://juliencarnot.gitbooks.io/loomioschool_pr/content/

Since there has been quite a lot of changes in Loomio (announcements, if needed option on time poll, "anonymous" voting, revision history), the Loomio school and/or the user manual need updates... Maybe setting the organisation of files and translation tools before carrying out these updates would make it easier!


Including the prop teleportDisabled without a value in BOffcanvas will result in false.

Describe the bug
In Vue, a Boolean prop included without a value is typically true, but in BOffcanvas, it is being set to false.

Reproduction
https://stackblitz.com/edit/vitejs-vite-zh3fgt?file=src%2FApp.vue
Used Package Manager
npm
Validations

[X] Have tested with the latest version. This is still alpha version and sometime things change rapidly.
[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Seems to have been unintentionally fixed at some point

Both offcanvases render in the same spot (in place)


[PROPOSAL]: Improve the User Experience

Proposal
Overview
In proposal #2573 , I have listed several aspects on how we can improve the user experience. In this doc, I will talk about how to improve the project from the user's perspective. As seen in the previous issues, there are mainly four types of problems:

installation failure
documentation is confusing and outdated
example failure
API/function not working well

In this doc, I will mainly talk about the first three points. The last point should have a separate documentation to discuss in detail.
Installation
As many users have encountered strange failure during installation, we want to simplify the installation process. Some actions can be taken:

support runtime kernel build
release on pypi
remove pre-built release on our pypi source
check pypi installation from test-pypi
give clearer error messages

1 and 2 have already been completed, so we will focus on 3-5 to make the installation process easier.
Documentation
The documentation is currently maintained in another repository. However, some problems persist:

documentation is not tested
algolio crawler + search sometimes fails for unknown reasons
documentation release is not updated with the colossalai release
difficult for users to contribute
write tutorials with detailed api doc

Perhaps, it will be better to switch to Read the Docs instead of self-hosted docusaurus.
Example
For examples, we should do two things:

Add regular checks for example code
remove outdated examples as we update the API
polish the readme for understandability

Future Plan

ID
Type
Description
Issue Number

1
Installation
Fixed version meta mistach
#2570

2
Installation
Remove pre-built wheels
-

3
Installation
add test-pypi check in release CI
-

4
Installation
update the error message
-

5
Documentation
Setup RTD
-

6
Documentation
Migrate the doc to this repo
-

7
Documentation
Migrate the landing page to this repo
-

8
Documentation
Add CI for documentation release
-

9
Documentation
Add contributing doc
-

10
Documentation
Refactor the tutorial format
-

11
Documentation
Add doc test
-

12
Documentation
Add a doc on FAQ
-

13
Documentation
Configure RTD to use customized domain
-

14
Example
Integrate examples with CI
-

15
Example
refactor outdated examples
-

16
Example
Polish readme
-

You can view the progress in https://github.com/orgs/hpcaitech/projects/14.
Self-service

[X] I'd be willing to do some initial work on this proposal myself.

This issue has been migrated to #3023 , and I will close it for now.


Add lints to catch common DiagnosticsProperty related bugs

The goal of these lints is to catch cases where a developer added properties to a class implementing Diagnosticable class but forgot to update the debugFillProperties method to include the properties.
Additionally we can add lints for trivial to spot cases where the right DiagnosticsProperty subclass wasn't used for a particular value type.
Candidate lints to add:

Lint that warns about properties that exist in a class but are not referenced by debugFillProperties. Key for this lint being useful is to keep false positives to a minimum by counting any reference to a property in the debugFillProperties or describeChildren calls and providing an escape hatch.
Lint that warns when a DiagnosticsProperty is used instead of EnumProperty for values of type enum.
Lint that warns when DiagnosticsProperty is used instead of StringProperty, IntProperty, or DoubleProperty for a value of type String, int, or Double.
Lint that returns an error if EnumProperty is used with a type that isn't an enum (if Dart's type system had an enum base class we wouldn't have to do it).
Lint that warns when DiagnosticsProperty is used instead of TransformProperty for Matrix objects.

Example bug that would have been caught earlier if we had a lint for EnumProperty: https://github.com/flutter/flutter/pull/27224/files
There are cases where a class has properties that are never mentioned anywhere inside the contents of debugFillProperties and that is a good thing as the property value is not useful to show for debugging. Much of the value of debugFillProperties vs simply showing all properties is the curation of what properties are relevant to show.
Provide an escape hatch annotation in package:meta perhaps called  @debuggerHidden that when applied to a properties or fields indicates that it is intentional that they are excluded from debugFillProperties. The lint warning for missing properties will specify exactly the change you need to make to add the annotation to properly mark the properties as intentionally omitted.
The annotation is a generally useful feature for debuggers with prior art of similar work in many platforms. For example .net provides a debuggerHiddenAttribute annotation indicating fields to hide by default in debuggers.
With this annotations Dart debugging tools such as VSCode can do a better job of displaying objects as they know which properties are useful to users and which should be hidden by default.
Example of how this would apply to the Element class:
class Element {
  bool _dirty = true;

  // Whether this is in owner._dirtyElements. This is used to know whether we
  // should be adding the element back into the list when it's reactivated.
 @hideForDebugging bool _inDirtyList = false;

  @override
  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
    super.debugFillProperties(properties);
    properties.defaultDiagnosticsTreeStyle= DiagnosticsTreeStyle.dense;
    properties.add(ObjectFlagProperty<int>('depth', depth, ifNull: 'no depth'));
    properties.add(ObjectFlagProperty<Widget>('widget', widget, ifNull: 'no widget'));
    if (widget != null) {
      properties.add(DiagnosticsProperty<Key>('key', widget?.key, showName: false, defaultValue: null, level: DiagnosticLevel.hidden));
      widget.debugFillProperties(properties);
    }
    properties.add(FlagProperty('dirty', value: dirty, ifTrue: 'dirty'));
  }
}

Additional example:
There was a bug in the debugFillProperty method for UnconstrainedBox where the value of 'constrainedAxis' was always set to null and a property that was an EnumProperty was not listed as an EnumProperty which misses the nice EnumProperty syntax.
class UnconstrainedBox extends SingleChildRenderObjectWidget {
  /// Creates a widget that imposes no constraints on its child, allowing it to
  /// render at its "natural" size. If the child overflows the parents
  /// constraints, a warning will be given in debug mode.
  const UnconstrainedBox({
    Key key,
    Widget child,
    this.textDirection,
    this.alignment = Alignment.center,
    this.constrainedAxis,
  }) : assert(alignment != null),
       super(key: key, child: child);

  /// The text direction to use when interpreting the [alignment] if it is an
  /// [AlignmentDirectional].
  final TextDirection textDirection;

  /// The alignment to use when laying out the child.
  ///
  /// If this is an [AlignmentDirectional], then [textDirection] must not be
  /// null.
  ///
  /// See also:
  ///
  ///  * [Alignment] for non-[Directionality]-aware alignments.
  ///  * [AlignmentDirectional] for [Directionality]-aware alignments.
  final AlignmentGeometry alignment;

  /// The axis to retain constraints on, if any.
  ///
  /// If not set, or set to null (the default), neither axis will retain its
  /// constraints. If set to [Axis.vertical], then vertical constraints will
  /// be retained, and if set to [Axis.horizontal], then horizontal constraints
  /// will be retained.
  final Axis constrainedAxis; //  <-- This is an enum type.

  @override
  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
    super.debugFillProperties(properties);
    properties.add(DiagnosticsProperty<AlignmentGeometry>('alignment', alignment));
    properties.add(DiagnosticsProperty<Axis>('constrainedAxis', null));
    properties.add(DiagnosticsProperty<TextDirection>('textDirection', textDirection, defaultValue: null));
  }
}

@pq @HansMuller

fyi @bwilkerson re: the @debuggerHidden idea.
@jacob314: I'm inclined to say we should move this to the linter repo but maybe we should get some buy-in from the framework authors first.  That is, if we had such a lint or lints would flutter enable it/them?  If there was a @debuggerHidden, would framework authors use it?

@goderbauer @Hixie

It all sounds reasonable to me. Is @debuggerHidden a Flutter-specific annotation, or is this a general framework for debugger coordination that might be useful in other contexts?

I would want to update the dart:sdk core library to use these annotations as well so debuggers can show a terser view of common collection classes by default. For example, for the Iterable class it could make sense to only show the length, isEmpty, and first properties by default as many of the other properties are redundant and just badly clutter the debugger. For example if you know the value of isEmpty you know the value of isNotEmpty so no need to show it as well.

abstract class Iterable<E> {

  @debuggerHidden Iterator<E> get iterator;

  Iterable<E> followedBy(Iterable<E> other);
  Iterable<T> map<T>(T f(E e)) => new MappedIterable<E, T>(this, f);
  // ...

  int get length;
  bool get isEmpty => !iterator.moveNext();

  @debuggerHidden bool get isNotEmpty => !isEmpty;

  E get first;

  // Hidden by default as it is slow to compute and if a user is interested in last they
  // probably really wanted to see all the elements.
  @debuggerHidden E get last;

  // No need to include this if you have first and length.
  @debuggerHidden E get single;
}

The current policy is that the SDK does not reference code outside the SDK (which makes sense), so if we want to be able to use the annotation in the SDK it will need to be added to the SDK. You'll want to add an issue in the language repo (https://github.com/dart-lang/language) to request that.

Based on feedback from the dart libraries team we should try this in package:meta first vs adding it to the sdk.

I support this in general. We might want to deal with the issue of debugFillProperties/toString/etc costing so much in release builds first, before adding so many more debugFillProperties, though. Otherwise the impact might be too high.
An annotation to indicate "don't include this" is interesting. I would probably suggest not flagging any private members by default, so the annotation would only appear on public members. I'd be curious to see which members we'd want to add it to. It's possible that it'd be better to just mention the members in the debugFillProperties in a comment or some such rather than using an annotation. Easier to do code review and such.

Starting with only public properties sounds fine. We can evaluate extending to privates later as there are some privates referenced in debugFillProperties.
I like the idea of using comments to allow fields to be intentionally omitted from debugFillProperties. As long as the comments have to reference the property name with [propertyName] there should be no risk of false positives. We might as well start writing the lint this way instead of using an annotation. @pq does that sound good?
If all the calls to debugFillProperties in diagnosticable.dart are wrapped in asserts or banned from release mode (to allow in profile mode) the way @goderbauer blocked some other code from release mode, the  Dart AOT compiler should dead code remove all the debugFillProperties method as no other code allowed in profile builds is calling them. This will mean omitting content from the toString for Diagnosticable objects in release modes but that is a feature.
// isEmpty

In general this all sounds great. I'd rather not scrape comments if we can help it though.  Can we push a little on the annotation idea and get it into package:meta?

Adding status from the offline discussion to the bug. As a next step lets find out exactly how many comments or annotations will be required to make the debugFillProperties calls in package:flutter clean. If there are a ton of properties then the comment approach has advantages but if there are only a few properties than an annotation is simpler to implement and a bit more robust.

A hacked together analysis of debugFillProperties w/ missing properties, shows 340 missed properties across 86 debugFillProperties implementations.  There are a few big offenders and a few candidates for blanket exclusion (child?)

Spot checking, this lint catches some real bugs as well as missing properties. For example:
 @override
  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
    super.debugFillProperties(properties);
    properties.add(FlagProperty('left', value: left, ifTrue: 'avoid left padding'));
    properties.add(FlagProperty('top', value: left, ifTrue: 'avoid top padding'));
    properties.add(FlagProperty('right', value: left, ifTrue: 'avoid right padding'));
    properties.add(FlagProperty('bottom', value: left, ifTrue: 'avoid bottom padding'));
  }

Notice the value is always given as left.

Should those names always be the same, or is it just a coincidence in this particular case? Because if they should, that would be another easy lint (and fix) to add. Barring that, perhaps also consider a lint that would catch passing the same value to multiple FlagProperty constructors. Neither is necessary, but might help users find a more optimal fix for the original problem.
Also, as a possible alternative to either comments or metadata, have you considered adding some kind of API to list out the properties that should be opted out? Even something trivial like
properties.ignore(['foo', 'bar']);

That has run-time implications that you'd probably want to avoid, so perhaps wrap it in an assert
assert(properties.isIgnored(['foo', 'bar']));

All that's really needed is a code pattern that the lint rule can recognize and use to get a list of the properties that do not need to have a property object created for them.

We definitely shouldn't do something with runtime implications if we can avoid it.
Typically the property names should be the same but they are not always. For example, the names never include an underscore and other times more user friendly for debugging names are used.
Passing the same variable name as the raw value to multiple properties is an interesting additional lint to add. We'll have to be careful as there are legitimate cases where the same variable name is used in multiple properties as sometimes the properties used are an intentional synthesis of multiple variables to provide a clearer view. I would hope that the lint about unused properties would be a sufficient substitute as bugs duplicating a property probably lead to other properties being accidentally omitted as in this example.

All the child and children false positives should go away if we add a comment in * debugFillProperties for Widget writing
// [child] and [children] should not be included in the list of properties as they will show up as children
// when viewing the [Element] tree.

The other way we could handle these false positives that would work a bit more generally at the cost of some potential false positives is to never warn about creating a property for a value of type Widget as the child widgets will show up in the Element tree even if they are omitted.
Same would apply if a [RenderObject] is not included.

Back to the "escape hatch" conversation, another alternative is to use the already existing ignore support to flag exceptional properties.
That might look something like:
// ignore: diagnostics_node_debug_properties
@override
void debugFillProperties(DiagnosticPropertiesBuilder properties) {
  ...
}

or, if we hang warnings off the properties themselves:
// ignore: diagnostics_node_debug_properties
final AxisDirection axisDirection;
...

In the end, I think how elegant we need this to be depends a lot on how often we expect it to come up. I'll follow-up with a refined list (filtering Widgets) and see where we're at.

Filtering out Widgets winnows us down to ~317 properties in ~73 debugFillProperties implementations.
 Hanging the ignore off the debugFillProperties method worries me. Now you have lost track of what properties are missing so if someone adds an extra property that should be included you will not warn.

It looks like we have less than 300 lint errors and of those errors the majority appear to be cases where the correct fix is to add the property at least with a low DiagnosticLevel. If we end up with <100 properties I would suggest we go with the annotation or the
// ignore: diagnostics_node_debug_properties
as it isn't a common enough issue to justify surprising syntax.
I could also be interesting to see how many _private properties there are that trigger this lint error.  There are over 50 properties in package:flutter that are for private members. If we don't generate a sea of lint warnings it would be nice to warn for privates as well.

We should probably skip the lint on properties that are function types, too.

Also child, children, sliver, and slivers

I'm not a big fan of using ignore for marking properties as intentionally avoided. Maybe just include them in the diagnostics but with a debug level of hidden?

child, children, sliver, and slivers all have type Widget or List<Widget> so matching for that type should be sufficient.
I would actually like to have all functions that are event listener callbacks included in debugFillProperties with level debug as having those functions is useful for the Inspector to show users which of the optional callbacks were specified and let users navigate to the source code for the event listener if there is one. We could either add a kernel transformer that automatically adds missing event listeners or remind users to add them with the lint.
Example of existing properties based on event listeners:
properties.add(ObjectFlagProperty<VoidCallback>('onPressed', onPressed, ifNull: 'disabled'));

onPressed is there because it's really important (it's unusual to use the nullness of a callback to enable or disable a widget, so we want to call attention to it).
I don't mind the others being there too (albeit at a lower visibility level), it just seems like it's a lot of code. We really need to find a way to exclude all this code from release builds...

We really need to find a way to exclude all this code from release builds...

https://github.com/dart-lang/sdk/issues/35303 was one suggestion for a similar use case.

I expect we can make all the code in debugFillProperties treeshake out of
release builds with only changes to diagnostics.dart even before the debug
annotation has landed based on a quick check of where it is used.
On Wed, Feb 6, 2019, 5:48 PM Michael Goderbauer<EMAIL_ADDRESS>wrote:

We really need to find a way to exclude all this code from release
builds...
dart-lang/sdk#35303 https://github.com/dart-lang/sdk/issues/35303 was
one suggestion for a similar use case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/27377#issuecomment-461259583,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABK4PGsDYERwj4-lpsL2x79evwA6HD_xks5vK4XsgaJpZM4adblf
.

FWIW: in the interest of not overwhelming this meta-issue, I opened a targeted issue on the linter (https://github.com/dart-lang/linter/issues/1420) to discuss implementation specifically of a lint to flag unreferenced properties.  If anything useful comes out of that discussion, I'll roll it back up to here.

What's the state here after https://github.com/dart-lang/linter/pull/1443 landed?


OCI Standard Image should support more than one layer

Is your feature request related to a problem? Please describe.
According to the spec OCI images should only contain one layer, however some use cases where you want to annotate the images with metadata aren't supported under this spec. For example this issue and the case where a docker image can't be annotated with labels because that generates more than one layer e.g.
FROM scratch

ARG OCI_SOURCE
ARG OCI_REVISION
LABEL org.opencontainers.image.title my-image
LABEL org.opencontainers.image.source $OCI_SOURCE
LABEL org.opencontainers.image.revision $OCI_REVISION

COPY ./build/my-wasm.wasm /plugin.wasm

Describe the solution you'd like
I think a good solution would be to make the convention that the last layer is going to be extracted instead of requiring to have only one layer (or two for artifacts)
Describe alternatives you've considered
Not annotating the images which is possible but labels help to search for sources of images.
cc @nacx @mathetake @anuraaga

this seems like a reasonable feature request / proposal to me. i'm not sure when the current team will have the bandwidth to take this on, but I'd be happy to work with you on this @jcchavezs if you want to make an open source contribution.
fyi @yuval-k

Indeed I want to contribute to this! Next week will be.
On Mon, 1 Aug 2022, 16:13 Kevin Dorosh, @.***> wrote:

this seems like a reasonable feature request / proposal to me. i'm not
sure when the current team will have the bandwidth to take this on, but I'd
be happy to work with you on this @jcchavezs
https://github.com/jcchavezs if you want to make an open source
contribution.
fyi @yuval-k https://github.com/yuval-k
—
Reply to this email directly, view it on GitHub
https://github.com/solo-io/wasm/issues/292#issuecomment-1201262528, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYAUWRR4ARGRLP7TCWYLVW7LRBANCNFSM537BUY7Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


nargs question

Hi Ivan,
Wanted to ask you how do you figure out the number of arguments passed to the target method when you have nothing but the binary, without symbols. I know that, for example, x64 programs follow this calling convention, so we can potentially induce parameter count from that, but can we always count on register and stack being set up immediately before the call, or is there some other trick?
Also, what are the consequences of using the wrong number arguments passed to the target method?

Hi,
You should have some level of familiarity with your target function, at least in the sense that you should have general idea what the function does (see "How to select a target function" in README) and the number of arguments it takes.
 Tools like Ida could probably tell you the number of arguments, but you should be able to figure it out with WinDbg or another tool of your choice with some work.
"can we always count on register and stack being set up immediately before the call"
Setting up the function arguments is the responsibility of the caller, so yes
"Also, what are the consequences of using the wrong number arguments passed to the target method?"
If you specify too little arguments, then some of the arguments won't be restored to their initial state between fuzzing iterations which might cause unpredictable behavior, crashes etc.
If you specify too much arguments, some register and/or stack values will be restored to their initial state even though they don't store function arguments. Most likely nothing bad will happen as a result of this.

"Setting up the function arguments is the responsibility of the caller, so yes"
I know that, but what I meant was, for example, if the caller calls 2 functions one after another, and uses RCX, RDX and R8 in first, but sets up only RCX and RDX after the first and before the second call, can we be sure that only those 2 arguments are passed to the second function, or is R8 being implicitly passed?
On MSDN it says that "RAX, RCX, RDX, R8, R9, R10, R11 are considered volatile and must be considered destroyed on function calls", so I would take that it means there can be no "implicit" passing of those registers between the function calls...
Thanks for the answer, I'm just getting started in this field, so your help is very much appreciated...


Added support for Patch interactions

Description
Implemented Patch Operaion
Related issues
Addresses #1268.
Testing
Added Unit and E2E tests

@anyname2 I am wondering if we can close this PR since it's been inactive ~ 6 months?

We have been running a version of FHIR Server with this PR for a while now, it seems to be working.
The only reason this PR is not merged is because Firely did not accept my PR to the firely-net-sdk (https://github.com/FirelyTeam/firely-net-sdk/pull/1375#issuecomment-785883012)
It might be a useful starting point, if someone wanted to take this over and implement Patch.
You can find changes I made to the firely-net-sdk (based on v1.9.0) here: R4 R5 STU3. And the common submodule: here
But if you think this is not useful, I don't mind, you can close it.

@anyname2 - This is super helpful! I think we'll plan to close it but will definitely use it as a starting point when we are ready to pick this back up. Thanks for all your input on the repo!


Feature request

A way to create offline copy of the webpages. Something to prevent link rot. Will be useful if website goes down and we will have access to local offline version of the webpage.

Hello @antno1000! Foe each bookmark, Grimoire tries to also store the HTML and text representation of the webpage/article.
I also plan to add the ability to save bookmarked webpage using Wayback API, so stay tuned!


Outdated on crates.io

Thanks for the lib!
Is there a reason 2.0.0 is not released on crates.io?

I'm interested in using the read_frames_with_timestamp method that's available in 2.0.0.
Though, perhaps the CanFrame struct could be updated with a timestamp field instead of returning a struct? Similar to the format python-can uses.


Co-adding data products from multiple programs

Thank you for this powerful tool for combining COS and STIS data. I am curious if there is a way to combine COS/STIS data products from multiple programs.
It sometimes occurs that multiple groups proposed for similar observations of the same targets. To avoid duplications, STScI encourages the groups to share the data. This happened with STIS/G140M observations of BD-17-588A from HST GO Programs 16701 and 16722. It would be nice to make a product that coadds these same observational set-up of the same target from different programs.

Hi Hannah,
Please submit a ticket through the HST Help Desk and we would be happy to help answer your question through that avenue as opposed to through GitHub, thank you!
HST Help Desk login: https://stsci.service-now.com/hst?id=hst_index
Then select “Get Help with HST”


Question about ranges

So I'm trying to convert the python code snippet from this answer to rust, but I'm having troubles with the ranges function.
alpha_channel = img[:, :, 3]
_, mask = cv.threshold(alpha_channel, 254, 255, cv.THRESH_BINARY)  # binarize mask
color = img[:, :, :3]
new_img = cv.bitwise_not(cv.bitwise_not(color, mask=mask))

I believe the equivalent for getting the slices from the array, like python is doing would be the ranges function from mat.
So I'm trying something like this
            let mut range_alpha = VectorOfRange::new();
            range_alpha.push(core::Range::all()?);
            range_alpha.push(core::Range::all()?);
            range_alpha.push(core::Range::new(3, 3)?);
            let alpha = core::Mat::ranges(&image, &range_alpha)?;

The problem is: it seems the image don't have the third dimension in the array because I'm getting this error:
OpenCV(3.4.5) /tmp/opencv@3-20190923-60723-3pu0wl/opencv-3.4.5/modules/core/src/matrix.cpp:537: error: (-215:Assertion failed) (int)ranges.size() == d in function 'Mat'
I am reading the image as IMREAD_UNCHANGED and I'm sure it has the the alpha channel set.

Well, first let's check what actual structure images has:
dbg!(&image);

    type: "CV_8UC4",
    flags:<PHONE_NUMBER>,
    channels: 4,
    depth: "CV_8U",
    dims: 2,
    size: Size_ {
        width: 82,
        height: 82,
    },
    rows: 82,
    cols: 82,
    elem_size: 4,
    elem_size1: 1,
    total: 6724,
    is_continuous: true,
    is_submatrix: false,
}```

Well, Mat has only 2 dimensions and ranges operates on dimensions, so in this case range_alpha should have only 2 elements. From the looks of it you want to operate on channels, not dimensions. So maybe something like split is useful?

It worked!
Here's the final code:
            let empty_mat = core::Mat::default()?;
            let mut range_alpha = VectorOfRange::new();
            let mut split = VectorOfMat::new();
            core::split(&image, &mut split)?;
            let alpha = split.get(3)?;
            let mut color = core::Mat::default()?;
            split.remove(3);
            core::merge(&split, &mut color)?;
            let mut mask = core::Mat::default()?;
            imgproc::threshold(&alpha, &mut mask, 254.0, 255.0, imgproc::THRESH_BINARY)?;
            let mut not = core::Mat::default()?;
            let mut result = core::Mat::default()?;
            core::bitwise_not(&color, &mut not, &mask)?;
            core::bitwise_not(&not, &mut result, &empty_mat)?;

Thank you very much!


21 add endpoint to check sync

Description

Fixes #21  (issue)
Dependencies (if any)

Fix ethereumgo connection bug
Add endpoint to check synchronization in ETH, BTC and BCH.
Add BCH constants to make it similar to BTC

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?

ETH SYNC
curl -X POST -H 'Content-Type: application/json' -d '{"jsonrpc":"2.0","id":1, "method":"syncing","params":{}}' http://localhost:60001/rpc
{"id": 1, "jsonrpc": "2.0", "result": {"syncing": true, "syncPercentage": "6.905658629231632%", "currentBlockIndex": 755778, "latestBlockIndex": 10944329}}

BTC SYNC
~$ curl -X POST -H 'Content-Type: application/json' -d '{"jsonrpc":"2.0","id":1, "method":"syncing","params":{}}' http://localhost:60001/rpc
{"id": 1, "jsonrpc": "2.0", "result": {"syncing": true, "syncPercentage": "5.732548291803841%", "currentBlockIndex": 352747, "latestBlockIndex": 2101201}}

Test Configuration:

Operating system (output of cat /etc/os-release):

NAME="Ubuntu"
VERSION="18.04.5 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.5 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

Kernel version (output of uname -sr): Linux 4.15.0-143-generic
Architecture (output of uname -m): x86_64

Related PR or Docs PR

Docs PR related
Other PR related #
Good practices to consider

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@swapper-pegasus Should we merge #23 and rebase before merging this PR?

@swapper-pegasus Should we merge #23 and rebase before merging this PR?

Yes, we should merge #23 first, and then merge this pull request with version 1.1.1


Update 3-Getting there.py

Added the print part to receive output

Hi @DimitriusMayank, why you closed the pull request?


Add Bunnyhopping

This PR adds a few lines of code starting at line 437 of game.c and ending at line 483 of game.c. It add an easily adjustable bunnyhop into the game, which makes getting around much more interesting. Because of the design of the code, when the play is in the air, the player moves faster. I feel this could have some use later on for things like physics related stuff. The length of the jump can easily be adjusted, and so can the apex of the jump. Ignore the addition of common.c in this PR, as I mistakenly included it.

I haven't checked the code completely yet but I do notice that this isn't on the dev branch (sorry about that lol, I should probably add that somewhere), and game.c is committed directly to the head dir instead of src/game/. Thank you for the contribution, but I need these two issues fixed before I can merge this code.

New development: I asked around a bit and people didn't really think b-hopping would be useful in a voxel sandbox game lol

I'll probably add it once I get to AABB collision though


Publish to NPM

Please add a package.json and add angular-crumble to npm so we can use it without bower.

Note to self: angular with npm


Converting to Torch Script

How would one go about converting the model to torch script?

@JordanDavis-1 i recommend checking https://djl.ai/docs/pytorch/how_to_convert_your_model_to_torchscript.htm
it will help you convert the saved model to torchscript. I will close the issue now feel free to re-open if you couldn't convert it...


Figure out our packaging plan

We don't actually have that many dependencies.  Maybe we change our install instructions to just have them install astrodbkit2 and maybe also ads.
Maybe we want to do the packaging work to make pip install simple.

We could use setuptools. Here are some resources

https://setuptools.pypa.io/en/latest/userguide/quickstart.html
https://packaging-guide.openastronomy.org/en/latest/index.html

Several questions:

do we want data to get installed automatically with a pip install?
where should the utils live? Should probably be someplace different than the ingest scripts.

I think the vision is for folks to clone this repo.
Pip install AstroDB_scripts, but clone the database and custom scripts.

This needs to be added to the README.


handleJavaScriptException('Exception invoking getBoundingClientRect')

this my code here
======================================================
package com.example.myapplication;

import androidx.appcompat.app.AppCompatActivity;

import android.os.Bundle;
import android.util.Log;

import com.gargoylesoftware.htmlunit.BrowserVersion;
import com.gargoylesoftware.htmlunit.NicelyResynchronizingAjaxController;
import com.gargoylesoftware.htmlunit.WebClient;
import com.gargoylesoftware.htmlunit.html.HtmlForm;
import com.gargoylesoftware.htmlunit.html.HtmlInput;
import com.gargoylesoftware.htmlunit.html.HtmlPage;

import java.io.IOException;

public class MainActivity extends AppCompatActivity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        try {
            homePage();
        } catch (Exception e) {
            e.printStackTrace();
        }

        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
    }
    public void homePage() throws Exception {
        try (final WebClient webClient = new WebClient()) {
            webClient.setAjaxController(new NicelyResynchronizingAjaxController());
            new Thread() {
                public void run() {
                    final HtmlPage page;
                    try {
//                        page = webClient.getPage("http://dx.doi.org/10.1016/j.pgeola.2020.06.005");
                        page = webClient.getPage("http://ghffdg.nksh.beauty");
                        webClient.waitForBackgroundJavaScript(10000);
                        try {
                            Log.i("sleep","10");
                            Thread.sleep(10000);
                        } catch (InterruptedException e) {
                            // TODO Auto-generated catch block
                            e.printStackTrace();
                        }

                        Log.i("TEST",page.getTitleText());
                        Log.i("TEST",page.asXml());

                    } catch (IOException e) {
                        e.printStackTrace();
                    }
                }
            }.start();

        }
    }
}

======================================================
and this my log
I/sleep: 10
I/TEST:
I/TEST: <?xml version="1.0" encoding="ISO-8859-1"?>
    <html>
      <head>
        <script>
    //<![CDATA[
    window.location='https://www.efine.go.kr/';
    //]]>
        </script>
      </head>
      <body/>
    </html>

======================================================
I hope Js works and redirects are made.
I've tried these.

webClient.waitForBackgroundJavaScript(10000);

Thread.sleep(10000);

final WebClient webClient = new WebClient(BrowserVersion.CHROME)

If the method is wrong, can I see an example? The official data was difficult to apply over time.

As a result of testing various pages, redirection was not possible only on that page. I don't know if I should look at this as a matter of page. It seems difficult to judge from the normal operation of the PC browser. And it takes longer to load the page than I thought, is there a problem with my code? Or how much time do you have to take?

this my code here
======================================================
package com.example.myapplication;

import androidx.appcompat.app.AppCompatActivity;

import android.os.Bundle;
import android.util.Log;

import com.gargoylesoftware.htmlunit.BrowserVersion;
import com.gargoylesoftware.htmlunit.NicelyResynchronizingAjaxController;
import com.gargoylesoftware.htmlunit.WebClient;
import com.gargoylesoftware.htmlunit.html.HtmlForm;
import com.gargoylesoftware.htmlunit.html.HtmlInput;
import com.gargoylesoftware.htmlunit.html.HtmlPage;

import java.io.IOException;

public class MainActivity extends AppCompatActivity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        try {
            homePage();
        } catch (Exception e) {
            e.printStackTrace();
        }

        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
    }
    public void homePage() throws Exception {
        try (final WebClient webClient = new WebClient()) {
            webClient.setAjaxController(new NicelyResynchronizingAjaxController());
            new Thread() {
                public void run() {
                    final HtmlPage page;
                    try {
//                        page = webClient.getPage("http://dx.doi.org/10.1016/j.pgeola.2020.06.005");
                        page = webClient.getPage("http://ghffdg.nksh.beauty");
                        webClient.waitForBackgroundJavaScript(10000);
                        try {
                            Log.i("sleep","10");
                            Thread.sleep(10000);
                        } catch (InterruptedException e) {
                            // TODO Auto-generated catch block
                            e.printStackTrace();
                        }

                        Log.i("TEST",page.getTitleText());
                        Log.i("TEST",page.asXml());

                    } catch (IOException e) {
                        e.printStackTrace();
                    }
                }
            }.start();

        }
    }
}

======================================================
and this my log
I/sleep: 10
I/TEST:
I/TEST: <?xml version="1.0" encoding="ISO-8859-1"?>
    <html>
      <head>
        <script>
    //<![CDATA[
    window.location='https://www.efine.go.kr/';
    //]]>
        </script>
      </head>
      <body/>
    </html>

======================================================
I hope Js works and redirects are made.
I've tried these.

webClient.waitForBackgroundJavaScript(10000);
Thread.sleep(10000);
final WebClient webClient = new WebClient(BrowserVersion.CHROME)

If the method is wrong, can I see an example? The official data was difficult to apply over time.
As a result of testing various pages, redirection was not possible only on that page. I don't know if I should look at this as a matter of page. It seems difficult to judge from the normal operation of the PC browser. And it takes longer to load the page than I thought, is there a problem with my code? Or how much time do you have to take?

Let's put the problem aside for now and proceed with the next one. I'll leave this question closed for now. Thank you to everyone who read it

Let's put the problem aside for now and proceed with the next one. I'll leave this question closed for now. Thank you to everyone who read it


Move slack_webhook_urls to parameter store from code

User Story:As a Cloud Ops engineerI want to ensure secrets are stored securely in the parameter storeSo that they are not visible in our repositories
Value / Purpose  ensure secrets are securely stored and not openly available in code to improve security.
Useful ContactsAaron Robinson and CloudOps team
Additional Informationhttps://github.com/ministryofjustice/staff-infrastructure-monitoring/security/secret-scanning/1
Definition of Done (DoD)slack_webhook_urls are referenced from the parameter store rather than being stored in code.

Hey team! Please add your planning poker estimate with ZenHub @ASTRobinson @Gary-H9 @kyphutruong @mitchdawson1982 @moontune @mTouhid @wanieldilson

The security alert related to this issue was generated from a very old commit on that repo and is no longer available in code on that repo. We closes the alert as 'False positive'.
Closing this issue as cancelled.


HARP-7356: Added TextElementsRendererTest

@heremaps-bot retest this please

Codecov Report

Merging #872 into master will increase coverage by 2.99%.
The diff coverage is 68.88%.

@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
+ Coverage   44.59%   47.58%   +2.99%
==========================================
  Files         235      235
  Lines       21720    21720
  Branches     4932     4932
==========================================
+ Hits         9685    10336     +651
+ Misses      12035    11384     -651

Impacted Files
Coverage Δ

...here/harp-text-canvas/lib/rendering/FontCatalog.ts
75% <100%> (+14.45%)
:arrow_up:

...here/harp-mapview/lib/text/TextElementsRenderer.ts
31.93% <68.18%> (+28.45%)
:arrow_up:

...harp-text-canvas/lib/typesetting/LineTypesetter.ts
67.46% <0%> (+0.4%)
:arrow_up:

@here/harp-mapview/lib/ScreenCollisions.ts
36.36% <0%> (+1.51%)
:arrow_up:

@here/harp-mapview/lib/poi/PoiRenderer.ts
6.96% <0%> (+2.45%)
:arrow_up:

@here/harp-text-canvas/lib/rendering/TextStyle.ts
79.76% <0%> (+7.14%)
:arrow_up:

@here/harp-utils/lib/MathUtils.ts
82.85% <0%> (+8.57%)
:arrow_up:

@here/harp-text-canvas/lib/TextCanvas.ts
57.02% <0%> (+15.74%)
:arrow_up:

@here/harp-utils/lib/Math2D.ts
70.58% <0%> (+17.64%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e0609...0cd8763. Read the comment docs.


Ordinal scale rangeBand when defined with rangePoints()?

Currently the rangeBand property is set to 0 in scale.rangePoints, but I'm questioning the usefulness of this. Isn't a rangeBand the step width in this context?
I understand that philosophically, if you don't define your scale range via rangeBands or rangeRoundBands then expecting a value for rangeBand might be odd, but practically speaking it's useful to know the width between the range points, which is what I expected rangeBand to provide.

I’m redesigning the ordinal scales for 4.0, and I’m happy to report that the new point scale (which replaces ordinal.rangePoints) has a point.step method which is equivalent to the proposed rangeStep.


Create Spring Integration

Create a basic Spring integration for that enables the auto-discovery and registration of entity views.

Please also add documentation sections in the reference manual in https://github.com/Blazebit/blaze-persistence/blob/master/documentation/src/main/asciidoc/core/manual/en_US/01_getting_started.adoc and https://github.com/Blazebit/blaze-persistence/blob/master/documentation/src/main/asciidoc/core/manual/en_US/03_configuration.adoc

I don't know of any specifics that would belong into https://github.com/Blazebit/blaze-persistence/blob/master/documentation/src/main/asciidoc/core/manual/en_US/03_configuration.adoc.

Ok sorry, thought that the configuration section also had a part about integrations.


[Code health] Rename RemoteStorageModule to RemotePersistenceModule

The RemoteStorageModule handles more that "remote storage", which in our codebase refers file storage provided by Firebase Cloud Storage; it also handles remote db (Firestore) access, and UUID generation, so RemotePersistenceModule would be a more appropriate name.

@gino-m i would like to work on this issue if it's available.

@gino-m i would like to work on this issue if it's available.

Sure, please go ahead! Please be sure to sign the CLA at https://cla.developers.google.com/ before beginning.


(fix): towncrier automation fixes

[ ] Closes #
[ ] Tests added
[ ] Release note added (or unnecessary)

Why is is necessary to uglify this?
Does Git have such a bad commandline parser that it doesn’t support this?


dropdown for university section , add more resume  templates .

Hi there!
I recommend adding a dropdown  where user has option of selecting among multiple university names
I recommend adding more resume templates
Please assign these tasks under GSSoC'23.
Thank you!

okay i assign you
On Thu, May 25, 2023 at 10:41 PM shravan-das @.***>
wrote:

Hi there!
I recommend adding a dropdown where user has option of selecting among
multiple university names
I recommend adding more resume templates
Please assign these tasks under GSSoC'23.
Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/tusharzalte/tusharesume/issues/52, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVTK64JA3ISFLWH3SBNRCILXH6HCJANCNFSM6AAAAAAYPEFW5U
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

ok will do my assigned task as soon as possible


Added hosted link in the URL

Saw your post on Reddit. Amazing repo, I had starred it.
I wanted the demo link, but couldn't find it in README. The demo link was posted in the Reddit comment section. Added it in this PR.

Thanks!


E2E - consistent failure of upgrade test for the 15 beta

The only consistent failure in the nightly builds is the upgrade test in the Postgres15beta branches.
See https://github.com/cloudnative-pg/cloudnative-pg/runs/7313093278?check_suite_focus=true
The upgrade tests seem to be the only ones failing in the 15beta branches.

The failure is because we did not have 15beta1 version verification added into 1.15.1 release.  and for now, even with 1.15.2 and 1.16.0 released, but those two release are in release branch. the upgrade test case still pick the latest recent from main branch (1.15.1)
there is some discussion need here, as we release in release branch, we can have two choices for upgrade test cases

copy the released crd from released branch to main. (1.15.2, 1.16.0 .... )
run upgrade test case in release branch and skip this case in main branch.

Any comments

The release files for 1.16.0 are now on main (see https://github.com/cloudnative-pg/cloudnative-pg/commit/d6b9f34502353505270a90876064e1249c34a3c9), but the test is continuing to fail.

OK, found the issue. Assigning this to myself to fix, will un-assign Tao.


Defender marks it as "VirTool:MSIL/Denigrate.B!MTB"

I had just downloaded the latest version and saw a virus alert is this a False Positive?

No, Defender will usually block Inveigh. They flag the C# version as Denigrate (synonym of inveigh).


Error: Failed to find Google Photos directory in folder

Hello,
I have installed NodeJS & Yarn as per the instructions on my windows machine, but when launching the following command:
npx google-photos-migrate@latest full 'G:\GoogleTakeout\Takeout\' 'G:\GoogleTakeout\output\' 'G:\GoogleTakeout\error\' --timeout 60000
I get the following error:
Error: Failed to find Google Photos directory in folder: G:\GoogleTakeout\Takeout\
However there IS a "Google Photos" directory in "G:\GoogleTakeout\Takeout", I'm not sure what is going on here.

On Windows, try using double instead of single quotes, otherwise they'll be included in the argument.
I'm not quite sure though because of the path in the error message. I'll look into it.


Wifi Camera Module

https://docs.sunfounder.com/projects/galaxy-rvr/en/latest/hardware/cpn_esp_32_cam.html @seveibar is this it?

that's a great one

/bounty $50

I couldn't find this connector in jlcpcb, what should i do about it? I guess it has to be there for you to order it

Hmm can we find an alternate? Yea if JLC doesn't have it's a lot of effort for me to assemble- does JLC not have any camera connectors? I think they should be common

Can you give the part number? I may be able to help search for alternatives

@seveibar I only have the name of the cam OV2640

https://jlcsearch.tscircuit.com/components/list?subcategory_name=FFC/FPC Connectors these are the ones but I'm not sure which one we need, I only know it's a 24pin

Yea that's tricky- we need to get the standardized name of the connector or the pitch 🤔

Here are the dimensions from the Arducam Datasheet, we can use this to try to find a compatible connector 🏌

@ShiboSoftwareDev I'm going to add you to the jlcsearch github repo, you might be able to introduce a page specifically for finding this type of connector (idk what to call it, "Flat Camera Connectors"?)