BUG

Describe the bug
when i was trying to delete the ScriptTag By using SDK then a error occurred while all of the Api's request is working Fine like POST/GET but i am not understanding why it is happening when i choose the DELETE operation ,
This is my error :
Fatal error: Uncaught Shopify\Exception\ApiException: Client error: DELETE https://edd46b2c4ddb1469dbef46434614bfbab:***@testtechievolve.myshopify.com/admin/api/2019-10/script_tags.json?id=187190444172 resulted in a 406 Not Acceptable response in C:\xampp\htdocs\shopifySDK\vendor\shopifychamp\shopify-api-php-sdk\src\Client.php:277 Stack trace: #0 C:\xampp\htdocs\shopifySDK\vendor\shopifychamp\shopify-api-php-sdk\src\Client.php(200): Shopify\Client->request('DELETE', 'https://edd46b2...', Array) #1 C:\xampp\htdocs\shopifySDK\header.php(19): Shopify\Client->call('DELETE', 'script_tags', Array) #2 C:\xampp\htdocs\shopifySDK\index.php(2): require('C:\xampp\htdocs...') #3 {main} thrown in C:\xampp\htdocs\shopifySDK\vendor\shopifychamp\shopify-api-php-sdk\src\Client.php on line 277
This is my code :
187190444172 : This is my created ScriptTag id
$script_tag_array = array(
'id' =><PHONE_NUMBER>72
);
$scriptTag = $client->call('DELETE','script_tags',$script_tag_array);
echo "";
print_r($scriptTag);
Expected behavior
I want to delete any ScriptTag by using this SDK  .
Error Screenshots
image URL : https://www.awesomescreenshot.com/image/34970264?key=05e25bf63ba437cdf61458e5832dcc14
Additional context
when i was trying to delete the ScriptTag By using SDK then a error occurred while all of the Api's request is working Fine like POST/GET but i am not understanding why it is happening when i choose the DELETE operation , can you please check my above code and if i am doing wrong in my code then please correct them.
Your Any Help must be appreciated ,
Thanks

issue resolved now


Add dist make target for build packaging

Add dist make target to be consistent with other OpenSDS projects so
build artifacts can easily be collected in a consistent way across the
different deliverables.

lgtm


Password change not working

Description of bug
As Admin I want to change the password for a user.
Whatever I enter here I always get the message "Your new password was not accepted for security reasons. Please enter a password that you haven't used before and is long and complex enough to meet the site's password complexity requirements."
How can I fix this?
Steps to reproduce
List the steps to reproduce the behavior:

Login as Admin
goto Users->Click on the ... -> Change Password
Enter a password e.g. "aldo1234+#"
See error

Current result
Error Message
Expected result
Password ist changed
Affected version

[x] 9.3.2
[ ] 9.3.1 (not installed)
[ ] 9.2.2
[x] 9.2.1 (previous version)
[ ] 9.2
[x] 9.1.1 (happend already here)
[ ] 9.1
[ ] 9.0

Affected browser

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer
[x] Edge

If you go into Settings -> Security -> Member Accounts -> Registration Settings, you will see the currently configured password requirements, such as minimum lenght, minimum amount of special characters, etc. Did you check if your password matches those requirements?

Oh yeah, this and in web.config, here ist the screen shot.
Surprisingly, when creating a new user I get info about password strength, which again does not follow the rules in screen shot. I was required to enter at least a numeric character.
I know its not best strength but for some reason I need characters only.

Here snippet of web.config:
<add name="AspNetSqlMembershipProvider" type="System.Web.Security.SqlMembershipProvider" connectionStringName="SiteSqlServer" enablePasswordRetrieval="false" enablePasswordReset="false" requiresQuestionAndAnswer="false" minRequiredPasswordLength="7" minRequiredNonalphanumericCharacters="0" requiresUniqueEmail="false" passwordFormat="Hashed" applicationName="DotNetNuke" description="Stores and retrieves membership data from the local Microsoft SQL Server database" />

Do you have anything in the event log, the browser console or in the Portals/_default/logs folder that might provide some hints about what is happening...

Yes, here it is:
2019-05-20 09:52:05,351 [ha01s017-wh][Thread:49][ERROR] Dnn.PersonaBar.Users.Services.UsersController - System.Configuration.ConfigurationErrorsException: Password Reset is not enabled    at DotNetNuke.Entities.Users.UserController.ResetPassword(UserInfo user, String passwordAnswer)    at DotNetNuke.Entities.Users.UserController.ResetAndChangePassword(UserInfo user, String newPassword)    at Dnn.PersonaBar.Users.Components.UsersController.ChangePassword(Int32 portalId, Int32 userId, String newPassword) 2019-05-20 09:52:05,351 [ha01s017-wh][Thread:49][ERROR] Dnn.PersonaBar.Users.Services.UsersController - System.Exception: Your new password was not accepted for security reasons.  Please enter a password that you haven't used before and is long and complex enough to meet the site's password complexity requirements.    at Dnn.PersonaBar.Users.Components.UsersController.ChangePassword(Int32 portalId, Int32 userId, String newPassword)    at Dnn.PersonaBar.Users.Services.UsersController.ChangePassword(ChangePasswordDto changePasswordDto))
I'm pretty shure that the password in question hasn't been used for this user so far.
here is what I found in Browser Console (Chrome):
[Deprecation] The keyword 'caret' for -webkit-appearance CSS property is deprecated and will be removed in M75, around June 2019.  So this is an issue with this setting. As a temporary workaround you can go in the web.config, search for enablePasswordReset and change the value to true....

Upgraded from 9.3.2 to 9.4.1, now password change throws an error, see attached file.
errorlog.zip
Btw. this seems to be the same error as here: https://github.com/hismightiness/dnnextensions/issues/177

@digitalsigi this error looks like is unrelated, it comes from the Repository module search indexer.
Di you try changing the reset password setting?

Thanks for looking into this.
Yes, I tried the password change, but no success. Passwort reset is off at my site.
I hope 4.9.2 is ready soon :-)

Yes, 9.4.2 is in RC stage in a few hours, but that will not change anything until we can reproduce this issue and build a fix for it. For now I was not able to reproduce it unless the password reset setting was disabled.

I have researched this as far as I can, without completely bypassing ASP.NET Memberships underpinnings we cannot address this issue in a safe manner as it is against the intended API structure.

@mitchelsellers Aha. Honestly I have no idea about the ASP.NET Memberships. I any event I will try with newest version.
But what is your recommendation in our case?

The only real workaround is to turn reset on, make the change then take it off.
But that will restart the app two times


ci: define semantic types and title only

Add semantic.yml to define accepted Semantic Commits types to enforce. See https://github.com/Ezard/semantic-prs.

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (b9f60e5) compared to base (b5a1418).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           27        27
=========================================
  Hits            27        27

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


chore: synch metaphysics schema

The type of this PR is: chore

This PR fixes the failure here https://github.com/artsy/eigen/pull/5890
Description

Synch metaphysics schema with metaphysics

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Synch metaphysics schema - mounir

#squashOnGreen

This PR contains the following changes:

Dev changes (Synch metaphysics schema - mounir)

  Generated by :no_entry_sign: dangerJS against 90c781fcb54475a05da0706982b3763cec6e7659


Re-enable localized descriptions of System Models

Since we're breaking the API during the porting to Ash, this could be a possibility to revisit how they're handled since we practically never supported locales other than the default tenant locale

Closing as implemented by #524


[BEAM-13479] [Playground] Change logic with Cancel method.

[BEAM-13479]
Change logic with Cancel method.;
Set false flag as a default value before calling the Process method;

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @AydarZaynutdinov @ilya-kozyrev @KhaninArtur @daria-malkova

LGTM

LGTM


SK kernel scale testing

Scale, load, and perf testing of SK Kernel.

Closing since this was completed


Fix Forms is already taken as from line 32 & will fix other now

wait
i gotta fix other bug u send me:)


feat: fs operations in Bueno namespace

I had no luck turning these into op2s. Definitely something to do in a future PR.

Related to #4

opening another PR, with conflicts fixed.


Problems with dev dependencies when deploying to Azure Web App

I'm just trialing out nuxt.js and i'm trying out deployment to an Azure Web App.
I'm experiencing issues when running npm run build requiring the dev dependencies (es-lint, etc) when building.
This happens even though the NODE_ENV environment variable is set to production and even if I run the command with  a NODE_ENV prefix
set NODE_ENV=production&& npm run build
I can get it to build if I install the dev dependencies first.
I'm using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Update: It seems like this was caused my ESLint being set to run on save in nuxt.config.js (set by the starter kit).


Stuck on gulp build - Error TS2345: Argument of type Property 'flags' is protected but type 'SPHttpClientConfiguration' is not a class derived from 'SPHttpClientConfiguration'.

Hi Guys I'm stuck in this I tried remove the node-modules and replace it with a freshly folder from a new project, I tried remove the import from dependencies, I tried install again the npm install Sp-http, nothing worked for me
please help
Error - [tsc] src/webparts/clbHome/components/ChampionvView.tsx(236,11): error TS2345: Argument of type 'import("C:/Temp/Trial1001/node_modules/@microsoft/sp-http/dist/index-internal").SPHttpClientConfiguration' is not assignable to parameter of type 'import("C:/Temp/Trial1001/node_modules/@microsoft/sp-component-base/node_modules/@microsoft/sp-http/dist/index-internal").SPHttpClientConfiguration'.
[15:29:36] [tsc] Property 'flags' is protected but type 'SPHttpClientConfiguration' is not a class derived from 'SPHttpClientConfiguration'.
This is what I have on package,json
"dependencies": {
"@fluentui/date-time-utilities": "^7.9.1",
"@fluentui/react": "^7.177.2",
"@material-ui/core": "^4.12.3",
"@material-ui/data-grid": "^4.0.0-alpha.37",
"@material-ui/lab": "^4.0.0-alpha.60",
"@microsoft/sp-application-base": "^1.15.2",
"@microsoft/sp-core-library": "1.13.0",
"@microsoft/sp-http": "^1.15.2",
this is the import on my file
import {
SPHttpClient,
SPHttpClientResponse
} from "@microsoft/sp-http";
this is what the webpart code has it from the folder downloaded zip  (what I marked on bold is where the issue shows up)
public options() {
let optionArray = [];
let optionArrayIds = [];
if (this.state.edetails.length == 0)
this.props.context.spHttpClient
.get(
      "/" +
      this.state.inclusionpath +
      "/" +
      this.state.sitename +
      "/_api/web/lists/GetByTitle('Events List')/Items",
      ****SPHttpClient.configurations.v1****
    )
    **.then(async (response: SPHttpClientResponse)** => {

Hi @PearlNava,
Thanks for reaching out to us.
May I know if you are trying to customize the app or are you trying to just deploy the app as it is.
Thanks.

Hi I’m trying to at least rebuild the package without make any modifications yet, because yes I need to do some modifications like change the title of the app on teams, change the add member to nominate member, add some admin sección to regular member area, etc. But before to do any modifications I wanted to be sure I was able to re-built the package I hope you could help I’m really stuck PerlaOn Oct 27, 2022, at 11:01 PM, v-saikirang @.***> wrote:
Hi @PearlNava,
Thanks for reaching out to us.
May I know if you are trying to customize the app or are you trying to just deploy the app as it is.
Thanks.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

HI @PearlNava,
Unfortunately we will not be able to support customizations. I am afraid we will not be able to help you here.
Few suggestions:

Make sure you have the right development environment set up. This template is compatible with Node 14 and built on SPFX version 1.13.0.
Try creating a blank project and see if it works without any issues
If a blank project works you can try to compare and narrow down the issue.

Thanks.

Yes I’m trying to customize the app, but first wanted to re-built the package at least without make any modifications that does not even work PerlaOn Oct 27, 2022, at 11:01 PM, v-saikirang @.***> wrote:
Hi @PearlNava,
Thanks for reaching out to us.
May I know if you are trying to customize the app or are you trying to just deploy the app as it is.
Thanks.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Hi I’m trying to at least rebuild the package without make any modifications yet, because yes I need to do some modifications like change the title of the app on teams, change the add member to nominate member, add some admin sección to regular member area, etc. But before to do any modifications I wanted to be sure I was able to re-built the package I hope you could help I’m really stuck PerlaOn Oct 31, 2022, at 6:03 AM, Perla Nava Perales @.> wrote:Hi I’m trying to at least rebuild the package without make any modifications yet, because yes I need to do some modifications like change the title of the app on teams, change the add member to nominate member, add some admin sección to regular member area, etc. But before to do any modifications I wanted to be sure I was able to re-built the package I hope you could help I’m really stuck PerlaOn Oct 27, 2022, at 11:01 PM, v-saikirang @.> wrote:
Hi @PearlNava,
Thanks for reaching out to us.
May I know if you are trying to customize the app or are you trying to just deploy the app as it is.
Thanks.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

I had this versions:
PS C:\Users\PXN> node --version
v14.20.1
PS C:\Users\PXN> npm ls -g --depth=0
C:\Users\PXN\AppData\Roaming\npm
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>Now I have this:
PS C:\Users\PXN> npm ls -g --depth=0
C:\Users\PXN\AppData\Roaming\npm
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>--<EMAIL_ADDRESS>and now is not allowing me to install npm install is erroring  npm ERR<EMAIL_ADDRESS>preinstall: npm install --package-lock-only --ignore-scripts && npx npm-force-resolutions`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

After install the npm install i still got the same error
[13:41:10] Finished subtask 'copy-static-assets' after 3 s
[13:41:19] Finished subtask 'lint' after 9.33 s
[13:41:27] Error - [tsc] src/webparts/clbHome/components/ChampionvView.tsx(234,11): error TS2345: Argument of type 'import("C:/Temp/microsoft-teams-apps-champion-management-main/node_modules/@microsoft/sp-http/dist/index-internal").SPHttpClientConfiguration' is not assignable to parameter of type 'import("C:/Temp/microsoft-teams-apps-champion-management-main/node_modules/@microsoft/sp-component-base/node_modules/@microsoft/sp-http/dist/index-internal").SPHttpClientConfiguration'.
[13:41:27] [tsc] Property 'flags' is protected but type 'SPHttpClientConfiguration' is not a class derived from 'SPHttpClientConfiguration'.
[13:41:27] Error - [tsc] src/webparts/clbHome/components/ChampionvView.tsx(236,15): error TS2345: Argument of type '(response: SPHttpClientResponse) => Promise' is not assignable to parameter of type '(value: SPHttpClientResponse) => void | PromiseLike'.
[13:41:27] [tsc] Types of parameters 'response' and 'value' are incompatible.
[13:41:27] [tsc] Type 'import("C:/Temp/microsoft-teams-apps-champion-management-main/node_modules/@microsoft/sp-component-base/node_modules/@microsoft/sp-http/dist/index-internal").SPHttpClientResponse' is not assignable to type 'import("C:/Temp/microsoft-teams-apps-champion-management-main/node_modules/@microsoft/sp-http/dist/index-internal").SPHttpClientResponse'.
[13:41:27] [tsc] Types have separate declarations of a private property '_correlationId'.
[13:41:27] Error - [tsc] src/webparts/clbHome/components/ChampionvView.tsx(358,9): error TS2345: Argument of type 'import("C:/Temp/microsoft-teams-apps-champion-management-main/node_modules/@microsoft/sp-http/dist/index-internal").SPHttpClientConfiguration' is not assignable to parameter of type 'import("C:/Temp/microsoft-teams-apps-champion-management-main/node_modules/@microsoft/sp-component-base/node_modules/@microsoft/sp-http/dist/index-internal").SPHttpClientConfiguration'.
[13:41:27] Error - [tsc] src/webparts/clbHome/components/ChampionvView.tsx(360,13): error TS2345: Argument of type '(response: SPHttpClientResponse) => Promise' is not assignable to parameter of type '(value: SPHttpClientResponse) => void | PromiseLike'.
Any ideas ? please help

Hi @PearlNava,
Please allow us some time. We will look in to this and get back you.
Thanks.

Hi I have created Fresh new project and an empty SP WebPart/React then try to create the package of that WebPart and it was created successfully :S,
Tried to add the ClbHome Webpart and still having some issues
[14:24:42] Finished subtask 'tslint' after 8.98 s
[14:24:49] Error - [tsc] src/webparts/clbHome/components/ChampionsCards.tsx(725,69): error TS2339: Property 'find' does not exist on type 'any[]'.
[14:24:49] Error - [tsc] src/webparts/clbHome/components/ChampionsCards.tsx(726,72): error TS2339: Property 'find' does not exist on type 'any[]'.
[14:24:49] Error - [tsc] src/webparts/clbHome/components/TOTCreateTournament.tsx(684,22): error TS2339: Property 'includes' does not exist on type 'string'.
[14:24:49] Error - [tsc] src/webparts/clbHome/components/TOTLandingPage.tsx(550,27): error TS2339: Property 'includes' does not exist on type 'any[]'.
[14:24:49] Error - [tsc] src/webparts/clbHome/components/TOTLeaderBoard.tsx(139,51): error TS2339: Property 'findIndex' does not exist on type 'any[]'.
[14:24:49] Error - [tsc] src/webparts/clbHome/components/TOTLeaderBoard.tsx(245,66): error TS2339: Property 'find' does not exist on type 'any[]'.
[14:24:49] Error - [tsc] src/webparts/clbHome/components/TOTMyDashboard.tsx(141,51): error TS2339: Property 'findIndex' does not exist on type 'any[]'.
[14:24:49] Error - [tsc] src/webparts/clbHome/components/TOTMyDashboard.tsx(307,64): error TS2339: Property 'find' does not exist on type 'any[]'.
[14:24:49] Error - 'tsc' sub task errored after 15 s
exited with code 2
[14:24:49] 'build' errored after 18 s
And this problem I think this is related to this
file: tsconfig.json,
"message": "'compilerOptions/lib' must NOT have duplicate items (items ## 5 and 1 are identical).",
The tsconfig.json looks like this:
{
"extends"<EMAIL_ADDRESS>"compilerOptions": {
"target": "es5",
"forceConsistentCasingInFileNames": true,
"module": "esnext",
"moduleResolution": "node",
"jsx": "react",
"declaration": true,
"sourceMap": true,
"experimentalDecorators": true,
"skipLibCheck": true,
"outDir": "lib",
"inlineSources": false,
"strictNullChecks": false,
"noUnusedLocals": false,
"resolveJsonModule": true,
"allowSyntheticDefaultImports": true,
"typeRoots": [
"./node_modules/@types",
"./node_modules/@microsoft"
],
"types": [
"webpack-env"
],
"lib": [
"es5",
"dom",
"es2015.collection",
"es2015.promise"
]
},
"include": [
"src//*.ts",
"src//*.tsx"
]
}
I'm a beginner on SPFX, anything can help

Hi @PearlNava ,
Below are the configurations, we have in our dev environment
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>node v14.18.2
npm 6.14.15
Can you please follow the below steps, to fix the above issues/errors ?

Download the code from this repo
Please make sure to have the development environment with the above configurations.
In VSCode, open the code and remove this line from package.json file
"preinstall": "npm install --package-lock-only --ignore-scripts && npx npm-force-resolutions"
Delete the package-lock.json file
Run npm install
Then run the below command to install these specific versions
npm i<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
These versions will resolve most of the above issues/errors:
https://github.com/OfficeDev/microsoft-teams-apps-champion-management/issues/136#issue-1426211983 - This issue is because of the<EMAIL_ADDRESS>version.
https://github.com/OfficeDev/microsoft-teams-apps-champion-management/issues/136#issuecomment-1297447437 - This is related to the @types/react and @types/react-dom version

Run gulp build
In case if you receive the below errors

[20:12:46] Error - [tsc] src/webparts/clbHome/components/ApproveChampion.tsx(248,27): error TS2322: Type '{ value: number; onChange: (eve: FormEvent<HTMLElement | HTMLInputElement>, isChecked: boolean) => void; checked: any; }' is not assignable to type 'IntrinsicAttributes & ICheckboxProps'.
[20:12:46] [tsc] Property 'value' does not exist on type 'IntrinsicAttributes & ICheckboxProps'.
[20:12:46] Error - [tsc] src/webparts/clbHome/components/ChampionvView.tsx(5,8): error TS2307: Cannot find module '@fluentui/react/node_modules/office-ui-fabric-react/lib/DatePicker' or its corresponding type declarations.
[20:12:46] Error - [tsc] src/webparts/clbHome/components/Header.tsx(1,10): error TS2305: Module '"../../../../node_modules/@fluentui/react/lib/Tooltip"' has no exported member 'DirectionalHint'.
[20:12:46] Error - [tsc] src/webparts/clbHome/components/TOTCreateTournament.tsx(17,10): error TS2305: Module '"../../../../node_modules/@fluentui/react/lib/Tooltip"' has no exported member 'DirectionalHint'.

Fix these errors in the below components.
In Header.tsx - Update the import to this
import { DirectionalHint, TooltipHost } from '@fluentui/react';
In TOTCreateTournament.tsx -  Update the import to this -
import { DirectionalHint, ITooltipProps, TooltipHost } from '@fluentui/react';
In ChampionvView.tsx - Update the import to this -
import { DatePicker, DayOfWeek, IDatePickerStrings } from "office-ui-fabric-react/lib/DatePicker";
In ApproveChampion.tsx, Remove this property from the Checkbox component
value={item.ID}

Run gulp build again and see if it gets succeeded.

Wha-whoo! It worked successfully!!
THANK YOU, GUYS! Really appreciate your help !!


Feature request: custom logger

Hi!
Currently in Bootstrap() the BaseApp.logger is a private var. Why not make it public?
I want to use my own logger (sending logs to an external service) but because its a private var set with initLogger() in Bootstrap() there is no easy way to customize it. Or did I miss something?

There are no plans to make the default app logger customizable but with the refactoring there will be dedicated hooks that will allow listening to the individual log writes.
To some extend you can do that already with something like:
app.OnAfterBootstrap().Add(func(e *core.BootstrapEvent) error {
	app.LogsDao().BeforeCreateFunc = func(eventDao *daos.Dao, m models.Model, action func() error) error {
		if log, ok := m.(*models.Log); ok {
			// do something with the log model...
			fmt.Println(log)
		}
		return action() // proceed with the normal operation
	}

	return nil
})

Thank you for the very fast reply!
From a first quick test this seems to only works for requests? Not for debug? Maybe also not for error or warning messages? Maybe I can set a level somewhere else?

You can control the min log level from the Admin UI > Logs > Logs settings popup.

Aha, did not know that one. Thanks!


Flatten is missing in exported DataPipe object type

Hi, firstly thanks for a great project.
I tried to use flatten on DataPipe object, but the type is missing it. Could you add it?
Also in web docs it is misspelled as "Flattern".
One last thing: in web docs, there is a mention that groupBy can also take string or array of strings. Again types denies that.

yeah, feel free to fork and raise PR with your changes

fixed and added flattenObject method as well


Update Lights chapter of the manual with Light shape / Area lights information

https://developer.playcanvas.com/en/user-manual/graphics/lighting/lights/

This issue belongs here: https://github.com/playcanvas/developer.playcanvas.com/issues

This issue belongs here: https://github.com/playcanvas/developer.playcanvas.com/issues


IBM Header action icon colour

I know this forum is for bug requests, but I don't know where else to ask.
The document is not very clear on the usage of IBM Carbon themed icons in the Angular project.
  <ibm-header-global>
    <ibm-header-action aria-label="User">
      <ibm-icon-user20></ibm-icon-user20>
    </ibm-header-action>
  </ibm-header-global>

The above code adds a black user icon against a black background.
I'll appreciate if anyone can guide me towards the right icon type or CSS.

Check out https://github.com/carbon-design-system/carbon/tree/master/packages/icons-angular for more usage instructions for icons-angular.
You may find the directive form more useful - <svg ibmIconUser20></svg>

Thanks, this is perfect


PHP 8 fatal error

Starting with PHP 8.0, get_resource_type with a GD image argument, will throw a Fatal Error.
The __destruct method causes this error:

PHP Fatal error: Uncaught TypeError: get_resource_type(): Argument #1 ($resource) must be of type resource, GdImage given.

Fix:
  public function __destruct() {
    if ($this->image !== null && ((gettype($this->image) == "object" && get_class($this->image) == "GdImage") || get_resource_type($this->image) === 'gd')) {
      imagedestroy($this->image);
    }
  }

Thanks. Are you interested in making this a PR?

Sorry, seems to be fixed in the latest release 👍


Allow moving bots between channels.

Currently when bot is moved from one channel to another player disconnects. This fixes the issue.

Sorry for this mess. I thought i can help but apparently not. Locally in JS it works fine but it looks like TS is vastly different and i cannot figure out what am i doing wrong. Sorry once again.

Typescript is only telling u that you need to do some type checking, reopen the PR and join the discord and I'll explain the errors


Dockerfile: use deadsnakes

The other PPA didn't work for me today, but deadsnakes appears to work today.

I also got an OpenGL error from cv2: ImportError: libGL.so.1: cannot open shared object file: No such file or directory so I added a fix to this PR.  I'm using nvidia-docker.


[Reward Model Training] Inconsistent accuracy caused by flash-attention

Many thanks for your excellent work~
When training the reward model, I found that flash attn affected the final accuracy. I followed the README exactly to reproduce sft10k and then use it to train a reward model. I used all the default parameters, but found that using flash attn or not made a 3.4% difference in accuracy (w/ flash-attn 60% v.s. w/o flash-attn 56.6%). The results are shown in the figure below. The pink plot is for w/o flash-attn and the blue plot is for w/ flash-attn. Is this accuracy gap normal?
I noticed that only the inference consistency was tested in tests/test_flash_llama.py. Did the author test the back-propagation?

Thanks for raising this issue. The difference in accuracy you get there is more likely due to the randomness in training than any other reason.
Due to finite arithmetic, results with and without FlashAttention will differ slightly. This is because the underlying algorithm and implementation differ for FlashAttention and standard attention. The backward pass of FlashAttention is implemented in the original flash-attn codebase and has been appropriately tested; PyTorch's autograd engine handles the rest. So it's unlikely there's a bug with the backward pass.
I did another ablation with and without FlashAttention. From the figure below, you can see that the difference is small and not statistically significant. Each curve is based on three independent runs (note I fixed the validation set to be the same for all runs). The full experimental log can be found here.


No easy way to associate a ReferenceSet to a FeatureSet or other container entities

Since there is no required standard way to specify a definitive reference set in GFF3 or VCF files, this becomes an exercise for the server maintainer at the time that datasets are ingested.
Related to #689

Closed by #1166.


add support for downloading file

https://core.telegram.org/bots/api#getfile
Use https://api.telegram.org/file/bot<token>/<file_path> to get the file.

IMO, handling the logic of file downloading in Nadia is not a good idea.
Maybe we could have a get_file_link method.
Anyway, pull requests are always welcome.

for example, what should get_file_link method do?

in search of other implementations I found download_file method. maybe i should implement it?

nadia has get_file_link/1 now since #16 has been merged.
I think it's enough in most cases, if there's still needs to have a download_file method, feel free to reopen this issue.


[Bug] Split to new window

Binary Ninja Version: 1.1.1525-dev Personal, ca3f5f03
Platform: macOS 10.14
Split to new window when not in Disassemble Graph window will crash

Fixed in build 1.1.1529-dev.


Audio?

Is it me or do I need any audio resources like the soundtracks?

MAIN/DATA/REALITY.FC contains the soundtrack. If you are just wondering how to get the demo to run from the repository, read this write-up: http://fabiensanglard.net/second_reality/

Thanks.


Code the actual health check algorithm

Written functions for evaluating RMS, MSE, MAE, etc..

Health check using simple statistics is now ready. We compare measurements to references in a diaggui XML files. To trigger comparison, there must be at least 2 references that were measured in the same way the new measurement was done, i.e. same resolution, bandwidth, channel names, type, etc. In the middle of this, we discovered the issue https://github.com/gw-vis/vishack/issues/8.


Updated code to PEP8 and updated documentation

Coverage remained the same at 90.04% when pulling b382cb99cc9bb11d71af053cb96efb880b22c9a5 on shirishagaddi:develop into 3e100d410a8fb55bc255bbcaeb1f921aebb15f44 on MicroPyramid:master.


Cant create file to termux location ver1.5.3

when i create file and Its happened (termux location path/)

The file is not saved! When i open the app again its happen

If i choose termux location is "path/:" with ':' its happened

Don't create files in the root directory of Termux. Create your files is Termux/storage/


Mamba installation requiring downgrading pandas version

Current Behaviour
I'm not sure if this is a ydata-profiling bug or a mamba/conda problem. I have conda-forge as a channel. When I try to install with the command: mamba install ydata-profiling I get the following output:
...
  Package            Version  Build            Channel           Size
───────────────────────────────────────────────────────────────────────
  Install:
───────────────────────────────────────────────────────────────────────

  + wordcloud          1.9.2  py310h6729b98_1  conda-forge      163kB
  + phik              0.12.3  py310ha51cec0_0  conda-forge     Cached
  + dacite             1.8.0  pyhd8ed1ab_0     conda-forge     Cached
  + visions            0.7.5  pyhd8ed1ab_0     conda-forge     Cached
  + ydata-profiling    4.5.1  pyhd8ed1ab_1     conda-forge      203kB

  Downgrade:
───────────────────────────────────────────────────────────────────────

  - pandas             2.1.0  py310h5262a37_0  conda-forge     Cached
  + pandas             2.0.3  py310h5e4fcda_1  conda-forge       12MB

  Summary:

  Install: 5 packages
  Downgrade: 1 packages

Where it's finding the current version of ydata-profiling but it's requiring pandas to downgrade from the current version 2.1.0 to 2.0.3.
Expected Behaviour
Expected behavior would be to simply install ydata-profiling without downgrading the pandas installation. I saw previous bugs where conda / mamba was trying to install an old version of ydata-profiling but this is the first that I've seen that's asking for pandas to be downgraded.
Data Description
N/A
Code that reproduces the bug
No response
pandas-profiling version
v4.5.1
Dependencies
pandas==2.1.0
python==3.10

OS
MacOS
Checklist

[X] There is not yet another bug report for this issue in the issue tracker
[X] The problem is reproducible from this bug report. This guide can help to craft a minimal bug report.
[X] The issue has not been resolved by the entries listed under Common Issues.

Hi @jbwhit ,
because pandas 2.1.0 is introducing some breaking changes, in ydata-profiling we have kept the pandas version bounded to versions that are below to 2.1.0 as per our setup file.
How relevant is for you to be using pandas 2.1.0? Can you please share a bit more on your experience?
I'll keep this request open so it can be upvoted by the community!

We can close this. I just tested this with the newest pandas release v2.2.0 and it looks to work without requiring a downgrade. It does seem to require numpy to be downgraded, but that's another for another issue.
  - numpy                    1.26.3  py310h4bfa8fc_0    conda-forge
  + numpy                    1.25.2  py310h7451ae0_0    conda-forge/osx-64     Cached


code formatting

re-format of codes to follow pep8 standards

changed cond == True  to cond is True  (and similar cases)
removed unused definitions of sympy symbols
changed sticker to actually ignore line-length errors (E501 error of pycodestyle)
(the previous config-file was somehow ambiguous as it ignores pep8 error E501 but then sets
a max-line-length of 255 for flake8)

should we format the code to have a fixed max-line-length?


Add a step to check for required executables

Proposed syntax:
DSC:
   ...
   executables: sfa_mix

It is tricky to check version numbers because not all software has version info avaiable via exec --version. Will leave it for now.

Current behavior is to check existence of variable, but not the version of it.


No full AWS SDK binary for macOS in the releases

I'm trying to import @aws-sdk/client-cloudwatch in my code. According to the README, it looks like I should use the -full-sdk binary when doing so. However, looking at the releases I can only see the following binaries for macOS:

llrt-darwin-arm64.zip
llrt-darwin-x64.zip

Should the -full-sdk binary for macOS be added to the releases so that people don't have to build from source to generate the binary?
Thanks! (loving LLRT btw!)

Yes, we should add this to releases as well! Thanks for your suggestion!

Until now, I had to forego multi-flavor support other than llrt-lambda-* and llrt-container-* because I was not sure how much need there would be.
Now that I am aware of the need, I will work on it. :)


Ignoring prefer candidate check by ICE failure because signal connection interrupted

Describe the bug
One of my colleagues experience this issue. While beeing conected with OpenVPN, it works fine. When directly connected to the Company-WAN, it does not.. It happens all the time in Firefox@113. In Chrome it is working fine currently.

First connection attempt fails with PeerConnection timeout,
Second connection attempt with the same token also fails, there is an error in the browser that websocket connection cannot be estabilished. (Currently we try to connect for the second time to force livekit-server to switch from UDP in case it is blocked - this has helped in other PeerConnection timeout scenarios so far)

Server

Version: [1.4.2]

Client

SDK: [js]
Version: [1.6.9]

Server logs

2023-05-30T10:58:07.632Z	INFO	livekit	rtc/room.go:331	new participant joined	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "pID": "PA_azihnwLSzqfS", "participant": "1275", "protocol": 9, "options": {"AutoSubscribe":true}}
2023-05-30T10:58:07.635Z	INFO	livekit	service/rtcservice.go:263	new client WS connected	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_azihnwLSzqfS", "remote": false, "connID": "CO_bQZMwa6jfsgs", "reconnect": false, "reconnectReason": "RR_UNKOWN", "adaptiveStream": true}
2023-05-30T10:58:07.635Z	INFO	livekit	rtc/room.go:265	participant state changed	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "state": "JOINED", "participant": "1275", "pID": "PA_azihnwLSzqfS", "oldState": "JOINING"}
2023-05-30T10:58:08.808Z	INFO	livekit	rtc/transport.go:602	selected ICE candidate pair	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_azihnwLSzqfS", "remote": false, "transport": "SUBSCRIBER", "pair": "(local) udp4 host  <-> (remote) udp4 prflx  related :0"}
2023-05-30T10:58:18.808Z	INFO	livekit	rtc/transport.go:472	connect timeout after ICE connected	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_azihnwLSzqfS", "remote": false, "transport": "SUBSCRIBER", "timeout": "10s", "iceDuration": "1.129446248s"}
2023-05-30T10:58:18.808Z	INFO	livekit	rtc/transport.go:582	short ICE connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_azihnwLSzqfS", "remote": false, "transport": "SUBSCRIBER", "pair": "(local) udp4 host  <-> (remote) udp4 prflx  related :0", "duration": "10.000925095s"}
2023-05-30T10:58:18.808Z	INFO	livekit	rtc/transportmanager.go:627	prefer TCP transport on both peer connections	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_azihnwLSzqfS", "remote": false}
2023-05-30T10:58:18.809Z	INFO	livekit	rtc/transportmanager.go:528	setting ICE config	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_azihnwLSzqfS", "remote": false, "iceConfig": "preference_subscriber:ICT_TCP  preference_publisher:ICT_TCP"}
2023-05-30T10:58:18.809Z	INFO	livekit	rtc/participant_signal.go:286	closing signal connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_azihnwLSzqfS", "remote": false}
2023-05-30T10:58:18.809Z	INFO	livekit	service/rtcservice.go:236	finishing WS connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_azihnwLSzqfS", "remote": false, "connID": "CO_bQZMwa6jfsgs"}
2023-05-30T10:58:33.809Z	INFO	livekit	rtc/participant.go:1306	closing disconnected participant	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_azihnwLSzqfS", "remote": false}
2023-05-30T10:58:33.809Z	INFO	livekit	rtc/participant.go:660	participant closing	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_azihnwLSzqfS", "remote": false, "sendLeave": true, "reason": "PEER_CONNECTION_DISCONNECTED"}
2023-05-30T10:58:33.809Z	INFO	livekit	rtc/room.go:265	participant state changed	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "state": "DISCONNECTED", "participant": "1275", "pID": "PA_azihnwLSzqfS", "oldState": "JOINED"}
2023-05-30T10:59:10.228Z	INFO	livekit	rtc/transportmanager.go:528	setting ICE config	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_8H2jey87m5Ga", "remote": false, "iceConfig": "preference_subscriber:ICT_TCP  preference_publisher:ICT_TCP"}
2023-05-30T10:59:10.228Z	INFO	livekit	rtc/room.go:331	new participant joined	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "pID": "PA_8H2jey87m5Ga", "participant": "1275", "protocol": 9, "options": {"AutoSubscribe":true}}
2023-05-30T10:59:10.229Z	INFO	livekit	service/rtcservice.go:263	new client WS connected	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_8H2jey87m5Ga", "remote": false, "connID": "CO_etoSbUBPTWTe", "reconnect": false, "reconnectReason": "RR_UNKOWN", "adaptiveStream": true}
2023-05-30T10:59:10.229Z	INFO	livekit	rtc/room.go:265	participant state changed	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "state": "JOINED", "participant": "1275", "pID": "PA_8H2jey87m5Ga", "oldState": "JOINING"}
2023-05-30T10:59:15.317Z	INFO	livekit	rtc/transport.go:439	tcp ice connect timeout	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_8H2jey87m5Ga", "remote": false, "transport": "SUBSCRIBER", "timeout": "5s", "signalRTT": 89}
2023-05-30T10:59:15.317Z	INFO	livekit	rtc/transport.go:586	force short ICE connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_8H2jey87m5Ga", "remote": false, "transport": "SUBSCRIBER"}
2023-05-30T10:59:15.317Z	INFO	livekit	rtc/transportmanager.go:630	prefer TLS transport both peer connections	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_8H2jey87m5Ga", "remote": false}
2023-05-30T10:59:15.317Z	INFO	livekit	rtc/transportmanager.go:528	setting ICE config	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_8H2jey87m5Ga", "remote": false, "iceConfig": "preference_subscriber:ICT_TLS  preference_publisher:ICT_TLS"}
2023-05-30T10:59:15.317Z	INFO	livekit	rtc/participant_signal.go:286	closing signal connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_8H2jey87m5Ga", "remote": false}
2023-05-30T10:59:15.318Z	INFO	livekit	service/rtcservice.go:236	finishing WS connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_8H2jey87m5Ga", "remote": false, "connID": "CO_etoSbUBPTWTe"}
2023-05-30T10:59:20.684Z	INFO	livekit	service/roommanager.go:256	removing duplicate participant	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_8H2jey87m5Ga", "remote": false}
2023-05-30T10:59:20.684Z	INFO	livekit	rtc/participant.go:660	participant closing	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_8H2jey87m5Ga", "remote": false, "sendLeave": true, "reason": "DUPLICATE_IDENTITY"}
2023-05-30T10:59:20.685Z	INFO	livekit	rtc/transportmanager.go:528	setting ICE config	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false, "iceConfig": "preference_subscriber:ICT_TLS  preference_publisher:ICT_TLS"}
2023-05-30T10:59:20.685Z	INFO	livekit	rtc/room.go:331	new participant joined	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "pID": "PA_fq8erZAJr8Ya", "participant": "1275", "protocol": 9, "options": {"AutoSubscribe":true}}
2023-05-30T10:59:20.685Z	INFO	livekit	rtc/room.go:265	participant state changed	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "state": "JOINED", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "oldState": "JOINING"}
2023-05-30T10:59:20.685Z	INFO	livekit	service/rtcservice.go:263	new client WS connected	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false, "connID": "CO_HWQaNtwk985H", "reconnect": false, "reconnectReason": "RR_UNKOWN", "adaptiveStream": true}
2023-05-30T10:59:31.744Z	INFO	livekit	service/rtcservice.go:236	finishing WS connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false, "connID": "CO_HWQaNtwk985H"}
2023-05-30T10:59:32.033Z	INFO	livekit	service/roommanager.go:236	resuming RTC session	{"room": "521501298", "nodeID": "ND_MJd5gtdO", "participant": "1275", "reason": "RR_SIGNAL_DISCONNECTED"}
2023-05-30T10:59:32.033Z	INFO	livekit	rtc/participant_signal.go:286	closing signal connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false}
2023-05-30T10:59:32.035Z	INFO	livekit	service/rtcservice.go:263	new client WS connected	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false, "connID": "CO_VYvr9azQpNPe", "reconnect": true, "reconnectReason": "RR_SIGNAL_DISCONNECTED", "adaptiveStream": true}
2023-05-30T10:59:32.149Z	INFO	livekit	service/rtcservice.go:236	finishing WS connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false, "connID": "CO_VYvr9azQpNPe"}
2023-05-30T10:59:33.289Z	INFO	livekit	rtc/room.go:331	new participant joined	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "pID": "PA_SzNPQizUrHv9", "participant": "1276", "protocol": 9, "options": {"AutoSubscribe":true}}
2023-05-30T10:59:33.290Z	INFO	livekit	service/rtcservice.go:263	new client WS connected	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "remote": false, "connID": "CO_LxVoAx6UxMV7", "reconnect": false, "reconnectReason": "RR_UNKOWN", "adaptiveStream": true}
2023-05-30T10:59:33.290Z	INFO	livekit	rtc/room.go:265	participant state changed	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "state": "JOINED", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "oldState": "JOINING"}
2023-05-30T10:59:34.469Z	INFO	livekit	rtc/transport.go:602	selected ICE candidate pair	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "remote": false, "transport": "SUBSCRIBER", "pair": "(local) udp4 host  <-> (remote) udp4 prflx  related :0"}
2023-05-30T10:59:44.470Z	INFO	livekit	rtc/transport.go:472	connect timeout after ICE connected	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "remote": false, "transport": "SUBSCRIBER", "timeout": "10s", "iceDuration": "1.122500387s"}
2023-05-30T10:59:44.470Z	INFO	livekit	rtc/transport.go:582	short ICE connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "remote": false, "transport": "SUBSCRIBER", "pair": "(local) udp4 host  <-> (remote) udp4 prflx  related :0", "duration": "10.00056701s"}
2023-05-30T10:59:44.470Z	INFO	livekit	rtc/transportmanager.go:627	prefer TCP transport on both peer connections	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "remote": false}
2023-05-30T10:59:44.470Z	INFO	livekit	rtc/transportmanager.go:528	setting ICE config	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "remote": false, "iceConfig": "preference_subscriber:ICT_TCP  preference_publisher:ICT_TCP"}
2023-05-30T10:59:44.470Z	INFO	livekit	rtc/participant_signal.go:286	closing signal connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "remote": false}
2023-05-30T10:59:44.471Z	INFO	livekit	service/rtcservice.go:236	finishing WS connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "remote": false, "connID": "CO_LxVoAx6UxMV7"}
2023-05-30T10:59:47.037Z	INFO	livekit	rtc/participant_signal.go:286	closing signal connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false}
2023-05-30T10:59:55.909Z	INFO	livekit	rtc/transport.go:624	peer connection failed	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false, "transport": "SUBSCRIBER"}
2023-05-30T10:59:55.909Z	INFO	livekit	rtc/transportmanager.go:578	ignoring prefer candidate check by ICE failure because signal connection interrupted{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false, "lastSignalSince": "25.190939895s", "signalValid": true}
2023-05-30T10:59:55.909Z	INFO	livekit	rtc/transport.go:1538	ice candidates	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false, "transport": "SUBSCRIBER", "lc": ["udp4 host ", "tcp4 host ", "udp6 host [2a02:cbf3:22e:1:ffff::16]:54243", "tcp6 host [2a02:cbf3:22e:1:ffff::16]:7881", "udp6 host [2a02:cbf3:22e:1:2037:aff:fede:e901]:50763", "tcp6 host [2a02:cbf3:22e:1:2037:aff:fede:e901]:7881", "tcp4 host ", "udp4 host ", "udp4 host ", "tcp4 host "], "rc": [], "lc (filtered)": [], "rc (filtered)": []}
2023-05-30T10:59:59.471Z	INFO	livekit	rtc/participant.go:1306	closing disconnected participant	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "remote": false}
2023-05-30T10:59:59.471Z	INFO	livekit	rtc/participant.go:660	participant closing	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "remote": false, "sendLeave": true, "reason": "PEER_CONNECTION_DISCONNECTED"}
2023-05-30T10:59:59.472Z	INFO	livekit	rtc/room.go:265	participant state changed	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "state": "DISCONNECTED", "participant": "1276", "pID": "PA_SzNPQizUrHv9", "oldState": "JOINED"}
2023-05-30T11:00:06.024Z	INFO	livekit	rtc/transportmanager.go:528	setting ICE config	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_ELPAqj5CjTWQ", "remote": false, "iceConfig": "preference_subscriber:ICT_TCP  preference_publisher:ICT_TCP"}
2023-05-30T11:00:06.024Z	INFO	livekit	rtc/room.go:331	new participant joined	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "pID": "PA_ELPAqj5CjTWQ", "participant": "1276", "protocol": 9, "options": {"AutoSubscribe":true}}
2023-05-30T11:00:06.025Z	INFO	livekit	rtc/room.go:265	participant state changed	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "state": "JOINED", "participant": "1276", "pID": "PA_ELPAqj5CjTWQ", "oldState": "JOINING"}
2023-05-30T11:00:06.025Z	INFO	livekit	service/rtcservice.go:263	new client WS connected	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_ELPAqj5CjTWQ", "remote": false, "connID": "CO_Sa6poBU6U2DZ", "reconnect": false, "reconnectReason": "RR_UNKOWN", "adaptiveStream": true}
2023-05-30T11:00:10.910Z	INFO	livekit	rtc/participant.go:1306	closing disconnected participant	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false}
2023-05-30T11:00:10.910Z	INFO	livekit	rtc/participant.go:660	participant closing	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "remote": false, "sendLeave": true, "reason": "PEER_CONNECTION_DISCONNECTED"}
2023-05-30T11:00:10.910Z	INFO	livekit	rtc/room.go:265	participant state changed	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "state": "DISCONNECTED", "participant": "1275", "pID": "PA_fq8erZAJr8Ya", "oldState": "JOINED"}
2023-05-30T11:00:11.106Z	INFO	livekit	rtc/transport.go:439	tcp ice connect timeout	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_ELPAqj5CjTWQ", "remote": false, "transport": "SUBSCRIBER", "timeout": "5s", "signalRTT": 81}
2023-05-30T11:00:11.106Z	INFO	livekit	rtc/transport.go:586	force short ICE connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_ELPAqj5CjTWQ", "remote": false, "transport": "SUBSCRIBER"}
2023-05-30T11:00:11.106Z	INFO	livekit	rtc/transportmanager.go:630	prefer TLS transport both peer connections	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_ELPAqj5CjTWQ", "remote": false}
2023-05-30T11:00:11.106Z	INFO	livekit	rtc/transportmanager.go:528	setting ICE config	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_ELPAqj5CjTWQ", "remote": false, "iceConfig": "preference_subscriber:ICT_TLS  preference_publisher:ICT_TLS"}
2023-05-30T11:00:11.106Z	INFO	livekit	rtc/participant_signal.go:286	closing signal connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_ELPAqj5CjTWQ", "remote": false}
2023-05-30T11:00:11.107Z	INFO	livekit	service/rtcservice.go:236	finishing WS connection	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_ELPAqj5CjTWQ", "remote": false, "connID": "CO_Sa6poBU6U2DZ"}
2023-05-30T11:00:16.404Z	INFO	livekit	service/roommanager.go:256	removing duplicate participant	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_ELPAqj5CjTWQ", "remote": false}
2023-05-30T11:00:16.405Z	INFO	livekit	rtc/participant.go:660	participant closing	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_ELPAqj5CjTWQ", "remote": false, "sendLeave": true, "reason": "DUPLICATE_IDENTITY"}
2023-05-30T11:00:16.406Z	INFO	livekit	rtc/transportmanager.go:528	setting ICE config	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_YcfRZr8AkYTR", "remote": false, "iceConfig": "preference_subscriber:ICT_TLS  preference_publisher:ICT_TLS"}
2023-05-30T11:00:16.406Z	INFO	livekit	rtc/room.go:331	new participant joined	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "pID": "PA_YcfRZr8AkYTR", "participant": "1276", "protocol": 9, "options": {"AutoSubscribe":true}}
2023-05-30T11:00:16.406Z	INFO	livekit	rtc/room.go:265	participant state changed	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "state": "JOINED", "participant": "1276", "pID": "PA_YcfRZr8AkYTR", "oldState": "JOINING"}
2023-05-30T11:00:16.407Z	INFO	livekit	service/rtcservice.go:263	new client WS connected	{"room": "521501298", "roomID": "RM_9nUDecKAaEWF", "participant": "1276", "pID": "PA_YcfRZr8AkYTR", "remote": false, "connID": "CO_TCJnmCf25gLr", "reconnect": false, "reconnectReason": "RR_UNKOWN", "adaptiveStream": true}

There are two participants in your log 1275 and 1276, which one has the problem? And I see both participants are switched to TLS candidate as expectedly since they have udp&tcp connection issues.
If your signal connectin is broken when short ice detected, the sfu will not prefers to next candidate intentionally as the interrupt might cause by network change, switch candidate will not help in this case and it might cause connection quality worse

@cnderrauber It's for 1275. Have you got any suggestions where to look for more information? Maybe it is more client related issue.

The problem is dtls handshake can't be completed in udp mode, after switch to tcp and tls, ice can't connect to the server, it should be a client network issue, it seems like turn/tlc is blocked too, which turn server are you using?

@cnderrauber I use livekit's built in turn.
turn:
    enabled: true
    domain: example.com
    cert_file: ""
    key_file: ""
    tls_port: 5349
    udp_port: 443
    external_tls: true

Hello, I have encountered this situation as well. When my network structure had only one layer of NAT, everything worked fine. However, when passing through two layers of NAT, I received the error message "ignoring prefer candidate check by ICE failure because no signal received in the ice failed window." I would like to know how to resolve this issue. Do I need to set up my own TURN server in a multi-NAT scenario, or could there be other reasons? I look forward to your response.

@cnderrauber Anything new regarding this issue?


refactor(routes): refactor Protected to layout route

https://reactrouter.com/en/main/start/concepts#layout-routes

Codecov Report

Merging #920 (2e57676) into master (90bcad8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #920   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           83        83
  Lines          847       849    +2
  Branches       125       126    +1
=========================================
+ Hits           847       849    +2

Impacted Files
Coverage Δ

src/routes.tsx
100.00% <ø> (ø)

src/components/Protected/Protected.tsx
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Better handling of primer repeated names

Addressed in https://github.com/manulera/ShareYourCloning_frontend/commit/37c7e56aa7c6799873ef9d0d1ba10830038cacb7


First link in the repo page

The first link here goes straight back to the repo, which doesn't make much sense to me:

Wouldn't it be better if the link went to https://docs.abapgit.org instead?

¯_(ツ)_/¯

closing, lets keep as is for now, thanks for the suggestion 👍

@larshp please change this. It's impossible to PR as this is part of the repo description. If the first thing you see in the repo is completely pointless, it sets a bad example for the rest :)

updated

thanks! this will no longer keep me up at night


[UVM,DOC] Define AHB address alignment requirements and enforce in UVM test env

Update Hardware spec to describe access alignment requirements on AHB.
Update UVM predictor to flag alignment violations, but allow unaligned Reads to SRAM in direct mode.
Update RDL with Mailbox SRAM (direct mode) address, add to caliptra_top internal address document.
Closes #575

Update Hardware spec to describe access alignment requirements on AHB. Update UVM predictor to flag alignment violations, but allow unaligned Reads to SRAM in direct mode. Update RDL with Mailbox SRAM (direct mode) address, add to caliptra_top internal address document. Closes #575

"but allow unaligned Reads to SRAM in direct mode" - This should be worded as allow byte-reads on non-DWORD aligned addresses. DWORD-reads (and writes) on non-DWORD aligned addresses should still flag alignment violations.

Update Hardware spec to describe access alignment requirements on AHB. Update UVM predictor to flag alignment violations, but allow unaligned Reads to SRAM in direct mode. Update RDL with Mailbox SRAM (direct mode) address, add to caliptra_top internal address document. Closes #575

"but allow unaligned Reads to SRAM in direct mode" - This should be worded as allow byte-reads on non-DWORD aligned addresses. DWORD-reads (and writes) on non-DWORD aligned addresses should still flag alignment violations.

It's possible this review is for a stale version of the doc. My latest commit revised this phrasing, let me know what you think.

Update Hardware spec to describe access alignment requirements on AHB. Update UVM predictor to flag alignment violations, but allow unaligned Reads to SRAM in direct mode. Update RDL with Mailbox SRAM (direct mode) address, add to caliptra_top internal address document. Closes #575

"but allow unaligned Reads to SRAM in direct mode" - This should be worded as allow byte-reads on non-DWORD aligned addresses. DWORD-reads (and writes) on non-DWORD aligned addresses should still flag alignment violations.

It's possible this review is for a stale version of the doc. My latest commit revised this phrasing, let me know what you think.

This text is from description of the task:

Update Hardware spec to describe access alignment requirements on AHB. Update UVM predictor to flag alignment violations, but allow unaligned Reads to SRAM in direct mode. Update RDL with Mailbox SRAM (direct mode) address, add to caliptra_top internal address document. Closes #575

"but allow unaligned Reads to SRAM in direct mode" - This should be worded as allow byte-reads on non-DWORD aligned addresses. DWORD-reads (and writes) on non-DWORD aligned addresses should still flag alignment violations.

It's possible this review is for a stale version of the doc. My latest commit revised this phrasing, let me know what you think.

This text is from description of the task:

Ah, I see. Fixed :)


🐞 - addon-doc fails to compile in Angular v18 app

Playground Link
No response
Description
addon-doc causes the following error when compiling Angular v18 project:
<EMAIL_ADDRESS>- Error: Module build failed (from ./node_modules/@angular-devkit/build-angular/src/tools/babel/webpack-loader.js):
TypeError: Cannot create property 'message' on string<EMAIL_ADDRESS>Errors found in the template:
Unsupported expression in a two-way binding ([(open)]="!!openPagesArr[index]"): node_modules\@taiga-ui\addon-doc\fesm2015\taiga-ui-addon-doc-components.js@1285:2821

Angular version
18.0.3
Taiga UI version
3.84.0
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[X] Windows
[ ] Linux
[ ] iOS
[ ] Android

Additional Notes
New error introduced in https://github.com/angular/angular/pull/55342

@splincode do you have time to fix this or should I make a PR?


Replace our $ with $_ as some websites use jquery and it comflicts with our solution.

Hi @IndrekV, Are you talking about function $ defined in common.js:5 ?
thanks, Kris

Exactly. the $ conflicts on some tools with jQuery.
It would have to be changed in common.js and all the places that use it (all content script).
Also all document.querySelector references can be replaced with $_ after this replacement.

This is actually not needed as the content scripts are kept separate from the regular javascript used on the page and can't conflict. I was getting conflicts when testing things in the developer console.


Improve context and details of existing errors

Context

Many of our application errors are poorly self-documenting. For instance, when the network is unreachable, we get a ErrNetworkUnreachable Text where this Text is raw network error without any context.
Another example, when we fail to select coins because there's not enough money, we return a ErrNotEnoughMoney Word64 Word64 capturing the available UTxO amount and the payment amount.
In the first example, it could be useful to know what endpoint we were trying to reach, and with which request. Perhaps even, we could parse this Text to identify whether in some cases, retrying could help. etc..
In the second example, what's particularly interesting to know in practice is details about the transaction. How many inputs? How many outputs? Their size? What's the UTxO distribution, etc...
These are not details we necessarily want to put in the server response, but, that are useful to have in the logs when debugging and trying to pinpoint an issue.
Decision

Review existing errors and enhance the context and details we give for each
Introduce new errors when relevant, that are more fine-grained and better described ambiguous situation

Acceptance Criteria

Errors and failures must come with additional context that make debugging easier
Context for errors may be printed and scattered across multiple messages, bound together via a common reference or context (e.g. a request id).

Development Plan

PR

Number
Base

#?
master

QA

@KtorZ I'm guessing the first task here would be to build a complete list of these errors, and for each error, specify the metadata we intend to attach to it. (This could be reviewed separately, before actually attempting to implement the change.)

Sounds like a good start for a development plan indeed :smile:

Closed. As discussed, this will be an ongoing work we'll do as part of refining our logging and error types as we ran into issues that aren't sufficiently detailed with context.


Not able to pull 2018 pre-season stats

How to update schedule so that it includes 2018 games?
Shouldn't nflgame.update_sched.run() work?

Yeah - I'm having the same issues myself!

Please try the steps noted in https://github.com/BurntSushi/nflgame/issues/363#issuecomment-409084354 and let me know if you are still having problems.

I have been using the live function to output games of the week to a LED sign I made. It seems this function isn't corrected by the solution you mentioned. I appreciate the help though

I'm still not following what's not working...
S:\>python
Python 2.7.14 (v2.7.14:84471935ed, Sep 16 2017, 20:19:30) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import nflgame
>>> games = nflgame.games(2018, kind='PRE', week=3)
>>> for game in games:
...     print game
...
NYJ (13) at WAS (15)
PIT (34) at GB (51)
PHI (20) at NE (37)
KC (28) at ATL (14)
MIA (20) at CAR (27)
BUF (19) at CLE (17)
NYG (30) at DET (17)
ARI (20) at NO (15)
CIN (21) at DAL (13)
CHI (24) at DEN (23)
SF (13) at HOU (16)
SEA (14) at LAC (24)
OAK (15) at LA (19)
JAX (14) at MIN (10)
TB (30) at TEN (14)
>>>

Hello, we have a forked version of this project setup here.  You are welcome to try out our new alpha release which includes some fixes to get nflgame.
pip install nflgame-redux==1.2.22a2

Does nfldb work with the forked version?

I have not tested this but nflgame-redux should be a drop in replacement in nfldb.  maybe @ochawkeye  can speak to this.
However, you should have no problems but will need to manually install the nflgame-redux repository somehow.  Easiest would probably be forking and changing setup.py to reference nflgame-redux.
I am considering forking all of the nfl* code but I am undecided and need to reach out ot more contributors across the projects.

Yes, this fork of nflgame works with nfldb.  Whether intentional or not, pip install nflgame-redux actually replaces/overwrites the nflgame package installed in ..\PATH\TO\PYTHON\Lib\site-packages (it installs in \nflgame not in \nflgame-redux)
S:\>python
Python 2.7.14 (v2.7.14:84471935ed, Sep 16 2017, 20:19:30) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import nfldb
>>> db = nfldb.connect()
>>> q = nfldb.Query(db)
>>> q.game(season_year=2018, season_type='Preseason')
<nfldb.query.Query object at 0x020E4410>
>>> for game in q.as_games():
...     print game
>>>

Preseason 2018 week 2 on 08/20 at 07:00PM, BAL (20) at IND (19)
Preseason 2018 week 2 on 08/18 at 07:00PM, TB (30) at TEN (14)
Preseason 2018 week 2 on 08/18 at 12:00PM, JAC (14) at MIN (10)
Preseason 2018 week 2 on 08/18 at 03:00PM, OAK (15) at LA (19)
Preseason 2018 week 2 on 08/18 at 09:00PM, SEA (14) at UNK (24)
Preseason 2018 week 2 on 08/18 at 07:00PM, SF (13) at HOU (16)
Preseason 2018 week 2 on 08/18 at 08:05PM, CHI (24) at DEN (23)
Preseason 2018 week 2 on 08/18 at 06:00PM, CIN (21) at DAL (13)
Preseason 2018 week 2 on 08/17 at 07:00PM, ARI (20) at NO (15)
Preseason 2018 week 2 on 08/17 at 06:00PM, NYG (30) at DET (17)
Preseason 2018 week 2 on 08/17 at 06:30PM, BUF (19) at CLE (17)
Preseason 2018 week 2 on 08/17 at 06:30PM, MIA (20) at CAR (27)
Preseason 2018 week 2 on 08/17 at 06:00PM, KC (28) at ATL (14)
Preseason 2018 week 2 on 08/16 at 06:30PM, PHI (20) at NE (37)
Preseason 2018 week 2 on 08/16 at 07:00PM, PIT (34) at GB (51)
Preseason 2018 week 2 on 08/16 at 07:00PM, NYJ (13) at WAS (15)
Preseason 2018 week 1 on 08/11 at 08:00PM, MIN (42) at DEN (28)
Preseason 2018 week 1 on 08/11 at 09:00PM, UNK (17) at ARI (24)
Preseason 2018 week 1 on 08/10 at 09:30PM, DET (10) at OAK (16)
Preseason 2018 week 1 on 08/10 at 06:30PM, ATL (0) at NYJ (17)
Preseason 2018 week 1 on 08/09 at 09:00PM, IND (19) at SEA (17)
Preseason 2018 week 1 on 08/09 at 09:00PM, DAL (21) at SF (24)
Preseason 2018 week 1 on 08/09 at 06:00PM, PIT (31) at PHI (14)
Preseason 2018 week 1 on 08/09 at 06:00PM, CLE (20) at NYG (10)
Preseason 2018 week 1 on 08/09 at 06:30PM, WAS (17) at NE (26)
Preseason 2018 week 1 on 08/09 at 06:00PM, TB (26) at MIA (24)
Preseason 2018 week 1 on 08/09 at 07:30PM, HOU (17) at KC (10)
Preseason 2018 week 1 on 08/09 at 06:00PM, NO (24) at JAC (20)
Preseason 2018 week 1 on 08/09 at 07:00PM, TEN (17) at GB (31)
Preseason 2018 week 1 on 08/09 at 06:00PM, CHI (27) at CIN (30)
Preseason 2018 week 1 on 08/09 at 06:00PM, CAR (28) at BUF (23)
Preseason 2018 week 1 on 08/09 at 06:30PM, LA (7) at BAL (33)
Preseason 2018 week 0 on 08/02 at 07:00PM, CHI (16) at BAL (17)
Preseason 2018 week 4 on 08/30 at 07:00PM, MIN (0) at TEN (0)
Preseason 2018 week 4 on 08/30 at 06:30PM, JAC (0) at TB (0)
Preseason 2018 week 4 on 08/30 at 09:00PM, OAK (0) at SEA (0)
Preseason 2018 week 4 on 08/30 at 09:00PM, UNK (0) at SF (0)
Preseason 2018 week 4 on 08/30 at 06:30PM, CAR (0) at PIT (0)
Preseason 2018 week 4 on 08/30 at 06:00PM, NYJ (0) at PHI (0)
Preseason 2018 week 4 on 08/30 at 06:00PM, NE (0) at NYG (0)
Preseason 2018 week 4 on 08/30 at 07:00PM, LA (0) at NO (0)
Preseason 2018 week 4 on 08/30 at 07:30PM, GB (0) at KC (0)
Preseason 2018 week 4 on 08/30 at 07:00PM, DAL (0) at HOU (0)
Preseason 2018 week 4 on 08/30 at 06:00PM, CLE (0) at DET (0)
Preseason 2018 week 4 on 08/30 at 06:00PM, IND (0) at CIN (0)
Preseason 2018 week 4 on 08/30 at 07:00PM, BUF (0) at CHI (0)
Preseason 2018 week 4 on 08/30 at 06:30PM, WAS (0) at BAL (0)
Preseason 2018 week 4 on 08/30 at 06:00PM, MIA (0) at ATL (0)
Preseason 2018 week 4 on 08/30 at 09:00PM, DEN (0) at ARI (0)
Preseason 2018 week 3 on 08/26 at 07:00PM, ARI (0) at DAL (0)
Preseason 2018 week 3 on 08/26 at 03:00PM, CIN (0) at BUF (0)
Preseason 2018 week 3 on 08/25 at 07:00PM, NO (0) at UNK (0)
Preseason 2018 week 3 on 08/25 at 03:00PM, TEN (0) at PIT (0)
Preseason 2018 week 3 on 08/25 at 06:00PM, BAL (0) at MIA (0)
Preseason 2018 week 3 on 08/25 at 03:00PM, HOU (0) at LA (0)
Preseason 2018 week 3 on 08/25 at 06:00PM, ATL (0) at JAC (0)
Preseason 2018 week 3 on 08/25 at 03:30PM, SF (0) at IND (0)
Preseason 2018 week 3 on 08/25 at 12:00PM, KC (0) at CHI (0)
Preseason 2018 week 3 on 08/24 at 07:00PM, DET (0) at TB (0)
Preseason 2018 week 3 on 08/24 at 06:30PM, DEN (0) at WAS (0)
Preseason 2018 week 3 on 08/24 at 09:30PM, GB (0) at OAK (0)
Preseason 2018 week 3 on 08/24 at 06:30PM, NYG (0) at NYJ (0)
Preseason 2018 week 3 on 08/24 at 07:00PM, SEA (0) at MIN (0)
Preseason 2018 week 3 on 08/24 at 06:30PM, NE (0) at CAR (0)
Preseason 2018 week 3 on 08/23 at 07:00PM, PHI (0) at CLE (0)

@ochawkeye - This was SEMI intentional (as the project ocupies the same namespace).... however i was unaware it would actually overwrite the code.
Does it matter what order you install them in?

The two cannot coexist.
pip didn't make any effort to resolve the conflict in names.  Every file in the \site-packages\nflgame directory was replaced with its counterpart in the nflgame-redux package.

Does it matter what order you install them in?

If one were to pip install nflgame-redux and then later pip install nflgame your code would be wiped out by whatever PyPi has sitting out there in nflgame.
In my mind I would have import nflgame-redux as nflgame vs import nflgame to test the same code but that ship has sailed.  My previous install of nflgame was replaced by this forked version.
Probably not a huge deal since this fork serves as the normal evolution of the old nflgame, but does strike me as a big pip issue.  Say I released to PyPi a packaged called totally-NOT-urllib3-I-promise but inside it called it urllib3.  pip install totally-NOT-urllib3-I-promise would nuke my real urllib3 library really without any sort of warning.

Ehhh I, not so passionately, disagree with import nflgame-redux as nflgame.  Keeping the same namespace is something i've seen other revival forks do when it is intends to pick up a dead or dying project and, for me personally, is 100% desired.
In an ideal situation we gain enough traction for the fork to get acknlowedged and replace the entire pypi listing and existing repository to us.  Or some version of events similar to that.

Also this needs to be clearly documented to avoid the situation I put you in.


Allow PredictionWriter to create different kinds of saved output

Perhaps write_prediction could be an input argument, and maybe you could specify a different writer function for different use cases?  Not sure if this could work.
Now we write batches as separate CSV output files with write_prediction()
https://github.com/cellarium-ai/cellarium-ml/blob/ca4d6f11a4b26f6c3573a190a783066b9eaccd8f/cellarium/ml/callbacks/prediction_writer.py#L14-L38
Is it possible to do something like keep appending to the same h5 file, for instance?  Perhaps PredictionWriter could be made to accommodate other kinds of output writers.

Maybe the more sensible thing to do is have a separate PredictionWriter, like PredictionWriterH5, for that kind of thing


Relay failure handling

Codecov Report

Merging #1 (e455d00) into master (655beb0) will increase coverage by 2.95%.
The diff coverage is 20.12%.

@@             Coverage Diff              @@
##             master       #1      +/-   ##
============================================
+ Coverage     22.21%   25.17%   +2.95%
- Complexity       57       63       +6
============================================
  Files           163      132      -31
  Lines          4150     3893     -257
  Branches        595      407     -188
============================================
+ Hits            922      980      +58
+ Misses         3206     2892     -314
+ Partials         22       21       -1

Impacted Files
Coverage Δ

...otlin/org/jetbrains/projector/agent/common/Misc.kt
0.00% <ø> (ø)

...common/transformation/ProjectorClassTransformer.kt
0.00% <ø> (ø)

...gent/common/transformation/TransformationResult.kt
0.00% <ø> (ø)

...or/agent/common/transformation/TransformerSetup.kt
0.00% <ø> (ø)

...ector/agent/ijInjector/IjBrowserUtilTransformer.kt
0.00% <ø> (ø)

...nt/ijInjector/IjFastNodeCellRendererTransformer.kt
0.00% <ø> (ø)

...jetbrains/projector/agent/ijInjector/IjInjector.kt
0.00% <ø> (ø)

...ains/projector/agent/ijInjector/IjInjectorAgent.kt
0.00% <ø> (ø)

...agent/ijInjector/IjLigaturesDisablerTransformer.kt
0.00% <ø> (ø)

...ains/projector/agent/ijInjector/IjMdTransformer.kt
0.00% <ø> (ø)

... and 186 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6cb4c2...e455d00. Read the comment docs.


Add support for default or initial state to handleAction

Fix for #23.

Hey @seniorquico, can you please rebase so the tests are running against the latest master? Thanks.

@timche Done. Let me know if I can help in any other way. Thanks!

Thanks, I've merged it :)

@timche, This is on master now, but doesn't seem to be in a release, in case you intended that. The docs for it are now showing on the homepage, but the code I can npm install (v. 0.9.1) doesn't include these changes (specifically, defaultState).

Right, I forked this repo so I can get the latest unreleased fixes in master. Not sure why it hasn't been released.

Sorry guys, I'll reach out to @acdlite asap to release the latest master on npm.

New version has been published on npm! :)


ProgressReporter erroneously counts 0 total tests and emits warning when used with minitest-focus

I am trying to use minitest-focus with minitest-reporters, specifically using the ProgressReporter format.
To summarize minitest-focus: if you put focus immediately before a test method, only that single test will be executed; all others will be ignored. For example:
class Chandler::ConfigurationTest < Minitest::Test
  focus
  def test_default_git
    # ...
  end

  # other tests are ignored
end

However this screws up ProgressReporter. When focus is used, ProgressReporter somehow thinks that 0 tests are being executed, when in fact 1 test is being executed. And a progress bar with 0 length causes problems. Here's what happens:
Started with run options "-n=/^(Chandler::ConfigurationTest\\#test_default_git)$/" --seed 10224

  0/0: [==================================================================================] 100% Time: 00:00:00, Time: 00:00:00
 FAIL["test_default_git", Chandler::ConfigurationTest, 0.0022607849996347795]
 test_default_git#Chandler::ConfigurationTest (0.00s)
        Expected: "../test/git"
          Actual: "../test/.git"
        /Users/mbrictson/Code/chandler/test/chandler/configuration_test.rb:22:in `test_default_git'

  0/0: [==================================================================================] 100% Time: 00:00:00, Time: 00:00:00
WARNING: Your progress bar is currently at 0 out of 0 and cannot be incremented. In v2.0.0 this will become a ProgressBar::InvalidProgressError.
  0/0: [==================================================================================] 100% Time: 00:00:00, Time: 00:00:00

Finished in 0.00462s
1 tests, 2 assertions, 1 failures, 0 errors, 0 skips

You can see that 1 test executed, but the progress bar reported 0. Furthermore the warning indicates that this will completely crash when ruby-progressbar 2.0.0 is released.
My guess is that DelegateReporter#total_count (source) is to blame here, but I haven't gotten much further than that. Any ideas?

Need to looks how list of tests is collected now in minitest.

need help?

Help is always welcome :)

The first step to help: please provide a test project which reproduces the problem

Good news! This no longer seems to be an issue with the latest versions of minitest-focus and minitest-reporters. Closing.


External MQTT?

Hi guys,
If I want to set an external MQTT, how exactly to configure FB, so it uses it? I tried updating MQTT_HOST, but it still tries to connect to the local MQTT. See log and my config bellow.
Basically I need to configure authentication and host location.
config
MQTT_HOST=<IP_ADDRESS>
API_HOST=<IP_ADDRESS>
API_PORT=3000
POSTGRES_PASSWORD=not_actual_value
DEVISE_SECRET=not_actual_value
ADMIN_PASSWORD=not_actual_value
SECRET_KEY_BASE=not_actual_value
RAILS_ENV=production
NO_EMAILS=TRUE
MQTT_WS=ws://<IP_ADDRESS>/ws
TRUSTED_DOMAINS=not_actual_value
RABBIT_MGMT_URL=http://<IP_ADDRESS>:80

log from farmbot-web-app_rabbit_jobs_1
W, [2019-09-09T18:48:04.730116 #1]  WARN -- #<Bunny::Session:0x5605d4a19fc0 admin@mqtt:5672, vhost=/, addresses=[mqtt:5672]>: Could not establish TCP connection to mqtt:5672: getaddrinfo: Name or service not known
Connecting to broker in 3 seconds. (#<Bunny::TCPConnectionFailedForAllHosts: Could not establish TCP connection to any of the configured hosts>)

Thanks!
results of git log -1
commit 973b403524a30dece3cd0bd42a97bba920599aba (HEAD -> master, origin/master)
Merge: 1bbc83c bb76d99
Author: Rick Carlino<EMAIL_ADDRESS>Date:   Tue Aug 27 15:53:43 2019 -0500

    Merge pull request #1398 from RickCarlino/master

    Adjust CSP policy

@radoslav-stefanov You are the first person to attempt this outside of FarmBot, Inc. so it is not a well documented feature, although we (FarmBot, Inc) do setup our own servers this way, it is not something that any third-party self hosters have yet requested. Can you tell me more about your use case? Is it safe to assume that you are using RabbitMQ and not a third party alternative (eg: Mosca, Mosquitto, HiveMQ, etc..). The reason I ask is because although the Web App and many third party farmwares use MQTT, FarmBot OS uses AMQP internally, so it would not work with alternaitve brokers. RabbitMQ is the only broker that will support FarmBot currently.
With that being said, you must make sure that you set the (undocumented) RABBITMQ_URL ENV var. It will follow the format of amqp://USERNAME:PASSWORD@HOST/VHOST. The HOST must match the host set in MQTT_HOST.
Please let me know if that fixes your issue.

Hi @RickCarlino
Thanks for the swift reply!
We are using HASSIO's addon https://github.com/hassio-addons/addon-mqtt/blob/master/README.md which has its own Mosquitto MQTT.
So I guess we should stick to the internal MQTT provided by FarmBot's docker-compose file?

I'm actually not familiar with hass.io, but it looks cool! Is MQTT the only means of writing an integration?
Combining FarmBot into another product's MQTT server would be non-trivial because:

We would need to re-write the parts of FBOS that use AMQP.
We would need to re-visit all security related code since currently, RabbitMQ offloads all authn/authz tasks to the RabbitMQ HTTP Auth Backend.

If there was a specific use case you had in mind, I might be able to offer you alternative approaches. For the time being, I think it would be best to run the MQTT server provided by the docker-compose file. I'm very interested to hear about your use case, though.

Hi @RickCarlino
I will ask someone from the group of people I work with to share insights on our use case. I am not that deeply familiar yet.

Closing this issue for now, but still open to discussion as needed.


Better assets caching

css handled by webpack use extract plugin (to get an actual css file,
not the css embed in js file - make more sense for us while we are
style serving as some static content)
assets version is not the latest commit hash. The reason is if a
commit affect a README file (for example), it make no sense at all to
change version of the assets, so instead of that we use a “content
hash” (that why I remove uglify in this commit, I need to find a way -
didn’t try yet) to get success build build from the same source that
give the same source - so content hash do not change because mangled
variables get renamed again (let’s say “a” to “b”…). During dev, no
hash used, for prod, webpack is run before metalsmith build so we can
easily share hashed name for the assets.
React layouts have been splited from modules, to make maintenance
easier when you have to update all layouts (even if they are just react
class). Maybe we can find a better way for the import of the module,
this can still be improved, for now, we just import from
“../../modules/*”
I removed some useless files (src/modules/base*) that are unused
since we use metalsmith-react

This commit also remove the usage of env variables, so it should helps to close #402

After more tests, uglify gives consitent build if the source is the same (make sense after all).
I am merging to go foward, feel free to review even if merged.


Fix kube auth provider test

Fixes #629

Proposed Changes

:bug: KubernetesAuthProviderTest kubernetes mock now uses plain http. Https in the mock server seems to be causing some issues on some JDKs (see https://github.com/knative-sandbox/eventing-kafka-broker/pull/825/checks?check_run_id=2399698957)
:wastebasket: Using the new junit5 kubernetes server mock, removed old junit4 rule migration support

/cc @pierDipi


Task Schedule Definition Config Deprecation Correction

Hey, I just made a Pull Request!
Updated the TaskScheduleDefinitionConfig deprecated comment to point to SchedulerServiceTaskScheduleDefinitionConfig
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks @freben 🚀


Pixi 2 width and height issues in Text and DisplayObjectContainer

Issue 1:
With resolution applied to the renderer, When I tried to access width and height of Text, the text is getting blurred.
console.log(_label.height);

Issue 2:
Similarly when I tried to trace width and height of DisplayObjectContainer in stage resize event I am seeing different values on each event trigger.

I'm also noticing problems with dimensions when adding elements to a container.  Has anyone got a fix for this?

As long as you set the resolution properly in the text as well it should be fine.

Sorrt, @englercj, I should've been more clear.  The dimensions of containers containing a mixture of text, sprites, and other containers are being reported incorrectly.

Please open a new issue with a running example.

I am also getting blurred text after accessing a width or height value of a PIXI.Text element as in the examples above. It seems like this was not resolved since the first report? Is there a workaround?

@davidafeil you have to make font size something about 0.5x-2x of what you actually want. For example if height is 100px, then font size must be about 50px-200px , otherwise it wont be that good.

This should be sorted in v4 now 👍


workaround for PAT_STATIC bug in zsh

ZSH versions less than 5.3.2 (or 5.4) have a bug that prevents
history-incremental-pattern-search-backward for working
correctly (the history stops searching after the first found item).
Closes #407

Isn't is-at-least itself using patterns and therefore causing the exact same bug it tries to prevent?
We should probably determine and remember this beforehand when sourcing z-sy-h, also for performance reasons.

@m0vie as soon as I read your comment, I realized you had to be right. I double checked in my plain-vanilla "fake" config and my work-around didn't work.
I pushed up a revised version that stores the value and uses that.  It's also easier to read, which I like.

@m0vie Thanks for reviewing.
@docwhat Besides my other comment (just posted), I have only a few minor style tweaks.  Will go through them once the functionality is settled.

@docwhat Feel free to join us on #zsh-syntax-highlighting on freenode.

Pulling this out for visibility...
@danielshahaf said:

Could we reword this to reflect that 5.3.2 is not yet released (and will probably be called 5.4)? I'll update #412 to refer to this.

Right now it describes what the code does...

Will zsh ever release a 5.3.2?
If so, would it just include security patches, or would it include this patch to?
Should I just change the is-at-least to 5.4?

@docwhat The next zsh feature release will be 5.4.  There may be a 5.3.2 hotfix release before then.  In principle, zsh may decide to release a <IP_ADDRESS>, but that's unlikely.  And in either of the three cases, we can't be sure whether the release would fix the PAT_STATIC bug: @m0vie's patch might be reverted or the bug accidentally reintroduced before upstream's release.
Now, I won't release z-sy-h with an is-at-least condition that refers to a future zsh release, and people who use zsh from master should use HEAD of master; therefore, I think it doesn't matter what version number we pass to is-at-least, so long as we have a note on #412 to fix it after zsh's release and before z-sy-h's release.
Makes sense?

@danielshahaf:
Just so I understand what my action item is: I should set the is-at-least check to <IP_ADDRESS> (as you suggested previously?
Can we push zsh to release 5.3.2 sooner rather than later and release it with that version check (as you mentioned above)?

@danielshahaf:
Just so I understand what my action item is: I should set the
is-at-least check to <IP_ADDRESS> (as you suggested previously?

My current idea is that it doesn't matter whether the code says is-at-least <IP_ADDRESS> or is-at-least 5.3.2, since I will wait for the next zsh release — and update the argument to is-at-least accordingly — before releasing z-sy-h.  Makes sense?

Can we push zsh to release 5.3.2 sooner rather than later and release it with that version check (as you mentioned above)?

We certainly can.  All it takes is for someone to email zsh-workers@ and ask/convince them to do so. :)

It's been a while, @danielshahaf -- Is there anything else I need to do with this PR? Or are we still good?

@movie's patch is workers/40453, zsh-users/zsh@e51c9c17af51e4055efb5a2cc36739d1d7ae457f.

@docwhat Apologies for dropping the ball.  Merged this and updated #415 accordingly.
If anyone wants to push upstream for a 5.3.2 (as per my penultimate comment), feel free :-)

@docwhat Apologies for dropping the ball.

No apologies necessary! Thanks!


some way to hide thinking in output of gemini-2.0-flash-thinking-exp

as the title says, if it's not too much, i can bare with it though. because it filled context quick and effects the model's behavior.

In principle, there are certain features that allow you to determine where reasoning ends and the final answer starts. However, these features are undocumented, which means Google could change the implementation at any time, so I wouldn't risk relying on them.
At the moment you can determine the start of the final response by the "|>" marker, so perhaps that will be enough for you.

thank you 🙏


Invalid login details

I followed step by step installation to the point of creating an administrator user, after that I get a box that allows me to return to the panel.
The problem is when I want to start session, because when I press the button "log in" only is refreshed, after a few minutes I try again and appears "Invalid login details."

remove the data/users/whatevername.json file and run install again.

The problem is in the security section of inc/lib.php I think it has to do with most Linux distributions are now on higher versions of php such that what was relied up on to make the security doesn't actually work anymore.
If you don't care about security change the last two functions in inc/lib.ph to read
// Securely encrypt a password
function bcrypt($str) {
/*
        $salt = strtr(base64_salt(22),'+','.');
        $work = 13;
        $salt = sprintf('$2y$%s$%s',$work,$salt);
        $hash = crypt($str,$salt);
        if(strlen($hash)>13)
                return $hash;
        else
                return false;
*/
return $str;
}

// Verify a bcrypt-encyrpted string
function bcrypt_verify($str,$hash) {
        return $str == $hash;
}

and then you will be able to log in and out consistently.
I did not submit this as a pull request because it is a dirty hack. If someone can come up with a reliable way to make the security work despite the version of php or any salting and encrypting mechanism, then please rewrite these functions to handle that and that is what should be PR'd.


Bug - Piping spec failure

What is the context of this PR?
During the piping cypress spec whilst creating metadata in the piping spec some of the text would be cut off from the metadata alias. This was because the network request for updating the metadata key had come back whilst cypress was updating the alias - this caused the entity managed by withEntityEditor to be updated and hence the field was cleared out.
The solution to this was to track the field that was dirty and to "merge" it into the returned data so the user's changes aren't lost.
This change does not handle the situation where the network request is so slow that multiple changes are in flight simultaneously but I haven't seen that yet so that can be dealt with later.
How to review

Add a metadata row
Slow your network speed in Chrome to "Slow 3G".
Update the key to a value
Tab to update the alias and change it (but don't blur).
The network request for the first update should complete but your changes in the alias field should not be lost.

Changing how I manage this as this failing on routing specs.


antisense_lncRNA (SO:0001904) vs antisense_RNA (SO:0000644)

Hi
I am looking at this term:
antisense_lncRNA (SO:0001904)
Def: Non-coding RNA transcribed from the opposite DNA strand compared with other transcripts and overlap in part with sense RNA.
Child of: lnc_RNA (SO:0001877), which itself a child of ncRNA (SO:0000655)
and I am wondering why it is not also a child of this term:
antisense_RNA (SO:0000644)
Def: "Antisense RNA is RNA that is transcribed from the coding, rather than the template, strand of DNA. It is therefore complementary to mRNA."
Child of: ncRNA (SO:0000655)
Is it because an 'antisense_RNA' is defined to be specifically transcribed from a 'coding' strand and thus is complementary to 'mRNA', whereas this is not necessarily true of a 'antisense_lncRNA' - i.e. the latter could be antisense to another non-coding RNA?
I ask because there are 100s of D. melanogaster ncRNAs in FlyBase that are >200nt and which are antisense (in part) to a mRNA, and I'm wondering which of these terms we should use to annotate?  As things stand, I think we'd have to use both, but that's not great as several applications require we use a single label for ncRNA type.
Any insights appreciated!

Hi
I don't have a good answer for this.
I have not thought about this in a while but lncRNA are not usually overlapping with protein coding sequence right? If this premise has changed, then the definitions may not make sense anymore.
Is there a good reference for lncRNA that overlap CDS? I am wondering if the best solution is to add a child term that has both of those terms you mention as a parent. Something like antisense_lncRNA_CDS_overlap  This would be ugly but could work.

Hi Karen
Here are 5 examples of a D. melanogaster lncRNAs (i.e. ncRNAs >200nt) that are antisense to a mRNA (including coding regions) of an overlapping gene:
asRNA:CR11538-RC (2386 nt) (http://flybase.org/reports/FBtr0347179.html)
asRNA:ASTR-RA (1374 nt) (http://flybase.org/reports/FBtr0309985.html) (see PMID:26504165)
asRNA:CR42254-RG (1372 nt) (http://flybase.org/reports/FBtr0347232.html)
asRNA:CR43637-RA (1117 nt) (http://flybase.org/reports/FBtr0309994.html)
asRNA:CR43820-RA (807 nt) (http://flybase.org/reports/FBtr0332216.html)
I'm also attaching a GBrowse screenshot of the first example below.

So, for these (and many others), it seems that "antisense_lncRNA (SO:0001904)" is most appropriate, given current definition. That's fine, but that means that these guys aren't categorized under "antisense_RNA (SO:0000644)" and so don't show up if you search using that term (because antisense_lncRNA isn't a child of it).
From my (somewhat naive!) point of view, making antisense_lncRNA a child of antisense_RNA (in addition to being a child of lnc_RNA) would work.  Or is that problematic for a reason I'm missing?

Thinking some more...
I guess the main issue is that the def for antisense_RNA says it is "transcribed from the coding strand" (i.e. not necessary the coding region) and is "complementary to mRNA" (i.e. UTRs + CDS). So I think that means a ncRNA (of any length) that is antisense (at least in part) to a UTR and/or a CDS of a protein-coding gene should have this term. The only exclusions would be ncRNAs that are antisense to introns of an overlapping gene model.
Would you agree?
If "antisense_lncRNA" follows the same constraints (i.e. the lncRNA must be antisense to a UTR or CDS) then I think making it a child of "antisense_RNA" is correct.
The D. melanogaster antisense lncRNAs I'm talking about are all antisense to UTR/CDS.

Hi, There's been no response to this for over 2 years :-(
Is someone able to review this ticket and implement the proposal above (or suggest a different approach)?

Dave – can you look at this?
Thanks
--K
From: Steven Marygold<EMAIL_ADDRESS>Reply-To: The-Sequence-Ontology/SO-Ontologies<EMAIL_ADDRESS>Date: Tuesday, December 15, 2020 at 6:40 AM
To: The-Sequence-Ontology/SO-Ontologies<EMAIL_ADDRESS>Cc: Karen Eilbeck<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [The-Sequence-Ontology/SO-Ontologies] antisense_lncRNA (SO:0001904) vs antisense_RNA (SO:0000644) (#443)
Hi, There's been no response to this for over 2 years :-(
Is someone able to review this ticket and implement the proposal above (or suggest a different approach)?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/The-Sequence-Ontology/SO-Ontologies/issues/443#issuecomment-745292613, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACS6AF5V4PPOYIYFQHOVXRLSU5RLZANCNFSM4FQFXUNQ.

Hi @sjm41,
I have added the relationship 'is_a' antisense_RNA to antisense_lncRNA. If there are any changes requested here that were not addressed, please comment and I will reopen the issue.
Thanks,
Dave

Works for me, thanks!