Login button and social icons disappear on sexy home page when screen shrinks

Why does the menu disappear?

Good point...


torch_inference.py   How to output the desired image

https://github.com/openvinotoolkit/anomalib/blob/main/tools/inference/torch_inference.py

How to output the desired image
No text required
No blank space required

I want to directly obtain this type of image

\anomalib\src\anomalib\post_processing\visualizer.py
 elif self.task == TaskType.CLASSIFICATION:
 return image_result.heat_map

Problem solving
I have modified this


SpanMarker: Increment minimum version to most recent

Hello!
Pull Request overview

Increment minimum version for SpanMarker.

Details
I recently released version 1.4.0 for SpanMarker, which includes a patch for XLM-RoBERTa models. I'd like for this patch to also be applied for the inference API, and I'm not sure how or when this version is ever updated. That said, I assume the change from this PR will do it.

Tom Aarsen

Thanks all! Looks like it's already live. The XLM-R models (e.g. this one) work live a glove now 😄

Tom Aarsen

Nice!


unix: modify argv[0] when process title is set

Ensures that argv[0] is changed when uv_set_process_title is called. Before, on some unix systems uv__set_process_title was being called but argv[0] was not modified.
See #1396 for more details.
This partially reverts commit 78c17238f48d9083359206a2215fc63dd7a0283d.

Without having reviewed the code, I applied this on top of the libuv update PR in Node. CI: https://ci.nodejs.org/job/node-test-pull-request/9724/

Looks like the CI is showing everything fine again (apart from those unrelated windows failures?)

Another CI looks good: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/407/. Landing.

Landed in afc05a3ab0ad2ab79385f3e3f029eb34849eda0e. Thanks!


An existing connection was forcibly closed by remote host.

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.07.13. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.07.13

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl.exe -v -c -f 1-540 https://www.lynda.com/Security-tutorials/Foundations-IT-Security-Core-Concepts/410329-2.html<EMAIL_ADDRESS>--password=aayyyy
([download] Downloading video 15 of 24
[lynda] 430060: Downloading video JSON
[lynda] 430060: Checking 0-720 video format URL
[lynda] 430060: Checking 0-360 video format URL
[lynda] 430060: Checking 0-540 video format URL
[lynda] 430060: Checking 2-720 video format URL
[lynda] 430060: Checking 2-360 video format URL
[lynda] 430060: Checking 2-540 video format URL
[lynda] 430060: Checking 1-720 video format URL
ERROR: Unable to download webpage: [WinError 10054] An existing connection was forcibly closed by the remote host (caused by ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpc5h2pb0m\build\youtube_dl\extractor\common.py", line 394, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpc5h2pb0m\build\youtube_dl\YoutubeDL.py", line 1955, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 464, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 482, in _open
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpc5h2pb0m\build\youtube_dl\utils.py", line 838, in http_open
  File "C:\Python\Python34\lib\urllib\request.py", line 1186, in do_open
  File "C:\Python\Python34\lib\http\client.py", line 1227, in getresponse
  File "C:\Python\Python34\lib\http\client.py", line 386, in begin
  File "C:\Python\Python34\lib\http\client.py", line 348, in _read_status
  File "C:\Python\Python34\lib\socket.py", line 378, in readinto

C:\youtube-dl>''')
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue required an account credentials please provide them or explain how one can obtain them.

verbose_log_1.txt
verbose_log_2.txt

Same happens for PluralSight
verbose_log_1.txt
verbose_log_2.txt

This indicates an issue with your internet connection. Can you watch it in browser? If you are using a proxy you must pass with --proxy.

yes got it.
It may be internet connection because now its working fine.
Not using any proxy.


221 ngsi ld migrate v2 datamodels in ld

close #221 #220

Will the attribute functions for NGSI-LD be implemented? Or will we not use them at all?

The data models have been mostly implemented. The fine-tuning will be done together with the endpoints. To this end, this PR is closed.


Sunrider Academy (340730) works

Hey @RyuzakiKK, just wanted to check you’ve been able to play this through getting it on Steam? It wasn’t with the demo 340740?

I personally tried the demo and it works. Also this guy confirmed that the full game works on Linux http://steamcommunity.com/app/340730/discussions/0/610573009244270155/

OK :) For future patches, if you’re not able to confirm that appid yourself, would you include some info (like that link) to help us verify the claim.
Trying to avoid accidental inclusion of faulty data, you see…

Ok, I'll do next time.


How to get Asset from a given Handle

I am trying to get the asset data that is behind a handle, but I can't figure out how to achieve that. The Assets::get() function is what you would typically use, but that doesn't work too nicely with the AssetLoader, at least I don't see how.
Any ideas how to get the Asset from a Handle?

but that doesn't work too nicely with the AssetLoader,

Are you writing an asset loader or what is your use case?

What I wanted to do was essentially this, getting the Assed data that is behind a Handle. Which is exactly what I tried but somehow I thought it didn't work for whatever reason. Sorry for wasting your time, and thank you for trying to help :+1:


Fix null duration

It avoids the error: The method '_mulFromInteger' was called on null.
Here I explain my case: https://github.com/CaiJingLong/flutter_photo/issues/66

Is it already available from pubspec?

Version 0.4.3 contains this PR.


Fix double duplication of blocks with Ctrl+D

Description

Fix bug where Ctrl+D will duplicate selected blocks twice.
What is the current behavior?

Select blocks
Press Ctrl+D to duplicate
Every selected blocks will be duplicated twice (one of them hidden behind the other)

What is the new behavior?

Union blocks before copying

Thanks for the PR.


feat: carousel added for collaborators

Issue #110
Created a carousel for mobile view while keeping the previous desktop view intact
Mobile view

Desktop/ laptop view (no changes made)

@Saurav-Pant , should I make any more changes or is this fine?


feat: [M3-7358] - Add AGLB Feedback Link

Description 📝
Add AGLB Feedback Link.

Before
After

How to test 🧪
Verification steps
(How to verify changes)

Navigate to http://localhost:3000/loadbalancers.
Verify Feedback link in all AGLB pages.
Verify LandingHeader Docs link alignment across the CM.
Link should navigate to google forms in a new tab.

As an Author I have considered 🤔
Check all that apply

[x] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[x] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[x] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

@cpathipa - You might have already mentioned this to UX, but can we maintain consistent styling across our products in beta? VPC looks a little different in #9879.

@cpathipa - You might have already mentioned this to UX, but can we maintain consistent styling across our products in beta? VPC looks a little different in #9879.

@mjac0bs I'm not aware of this PR, I will make the Icon changes consistent with VPC feedback link.

@abailly-akamai My initial thought was to maintain a separation of concerns, which is why I chose to implement a separate code block for the feedback component. This decision resulted in hiding the default icon that appears after the link text. However, our requirement was to display the icon before the link text. Additionally, I was not aware of https://github.com/linode/manager/pull/9879 that might have addressed this.

Verified:

[ ] Feedback link appears in all AGLB pages.
[ ] LandingHeader Docs link has proper alignment across CM
[ ] Link navigates to google forms in a new tab

Thanks for aligning this with our previous design

@mjac0bs Added left margin for small screen. 33c441d


patch_cursor_position doesn't work when opts.relative=cursor

Nvim Version
NVIM v0.10.0-dev-3057+g9e2f378b6d
Build type: RelWithDebInfo
LuaJIT 2.1.1713773202

Code to reproduce
local Input = require("nui.input")
local event = require("nui.utils.autocmd").event

local input = Input({
  relative = "cursor",
  position = {
    row = 0,
    col = 0,
  },
  size = {
    width = 20,
  },
  border = {
    style = "rounded",
    text = {
      top_align = "center",
    },
  },
}, {
  default_value = "Hello",
})

-- mount/open the component
input:mount()

-- unmount component when cursor leaves buffer
input:on(event.BufLeave, function()
  input:unmount()
end)

patch_cursor_position is used when exiting insert mode with <CR> places cursor one character backward. When relative is cursor, the patch_cursor_position function doesn't run due to target_cursor and cursor not relate.
https://github.com/MunifTanjim/nui.nvim/blob/cbd2668414331c10039278f558630ed19b93e69b/lua/nui/input/init.lua#L12-L22
In this context, the target_cursor is actually the cursor position of the input prompt not the previous cursor position before open prompt. This commit https://github.com/MunifTanjim/nui.nvim/commit/3dc46d725f7b94bee5117c0a699b57b1902b5d65 I don't know what problem it fixes but revert it works like expected.
https://github.com/MunifTanjim/nui.nvim/assets/13571960/1530b96b-11a6-47ae-a00a-135a7ffd8a62

Should be fixed now.


How to apply the configuration to the loaded apps before Padrino.configure_apps()?

Just a little question - For example, the situation is below:
# boot.rb (pseudo code)
require "bundler/setup"
Bundler.require :default, RACK_ENV # => SomeApp was required
Padrino.load!

# apps.rb (pseudo code)
Padrino.configure_apps do
  # ... config ...
end
Padrino.mount("SomeApp").to("/some")
# => SomeApp does not have config

I found two ways seems to work well in the followings:
1. Explicitly call App.default_configuration!() on Padrino.after_load()
# boot.rb (pseudo code)
Padrino.after_load do
  SomeApp.default_configuration!
end

2. Write Padrino.configure_apps() before loading app
# boot.rb (pseudo code)
require "bundler/setup"
require "padrino"
Padrino.configure_apps do
  # ... config ...
end

Bundler.require :default, RACK_ENV # => SomeApp was required
Padrino.load!

Isn't there another way for that?

The second way looks reasonable to me because the configuration is executed at the same time with inheriting Padrino::Application.

Would this work?
# Gemfile
gem 'mygem', :require => false

# boot.rb
require "bundler/setup"
Bundler.require :default, RACK_ENV # => mygem was NOT required

Padrino.configure_apps do
  # ... config ...
end

require 'mygem'

Padrino.load!

Closing as answered.


v1.0.0

[x] Remove unneeded files in init that are automatically generated by PatternPack v1.0.2+
[ ] pattern filenames are always pattern.md and pattern.scss

@johngully The Yeoman generator for patterns always seems to generate <location>/<pattern name>/pattern.md and <location>/<pattern name>/pattern.scss
Was it intentional to nest them within a folder? Everywhere else we've used the pattern of <location>/<pattern name>.md or .scss

We should be creating patterns using the "type of pattern" and "pattern name".
{src}/{pattern-type}/{pattern-name}.md
{src}/{pattern-type}/{pattern-name}.{css-type}

Example
./src/atoms/buttons.md
./src/atoms/buttons.scss

I think we should take a look at keeping some of the empty folders.
What happens if the /dist folder is configured but does not exists?  If it is created, then we should not make it part of the generator, if it breaks then we should do something about that.
I think giving the user a place to put images and js has some value, because it provides direction.  I know they can do whatever they like, but the idea of the generator is to provide an opinion of what to do.

We should be creating patterns using the "type of pattern" and "pattern name".

Do you remember how to do this from the Yeoman docs? I can go dig if you can't.

We may want to consider creating this file. It allows the user to immediately modify the file before running a build. But if we keep this file, it should use the same template as the one in the patternpack project

The thinking here was to keep Yeoman as "stripped down" as possible for future debugging. Basically offload as much file generation to PatternPack as we are willing to build in, and use Yeoman to extend that.

What happens if the /dist folder is configured but does not exists? If it is created, then we should not make it part of the generator, if it breaks then we should do something about that.

I'll double check, but I don't think anything breaks. /dist is not generated by default with PatternPack, but it gets created upon patternpack:release.

I think giving the user a place to put images and js has some value, because it provides direction. I know they can do whatever they like, but the idea of the generator is to provide an opinion of what to do.

I can see your point. I'll add those but leave the generation of everything else up to PatternPack.

The generator has been published at v0.9.0


Support for multiple hooks

Hi
How do I specify multiple hooks in the json file?
It works when I only have one id there. But when I add another one, but it returns "Hook not found"
Here is my hooks.json file:
[
  {
    "id": "pihole-block",
    "execute-command": "/home/trinsteradm1n/webhook/block.sh",
    "command-working-directory": "/home/trinsteradm1n/webhook",
    "response-message": "Block Complete"
  }

  {
    "id": "pihole-unblock",
    "execute-command": "/home/trinsteradm1n/webhook/unblock.sh",
    "command-working-directory": "/home/trinsteradm1n/webhook",
    "response-message": "Unblock Complete"
  }
]

Use valid JSON. You need a comma between the two blocks.

Thank you! That fixed it :)


Add date filters fx

Enable users to filter the responses by start/end date.

Fixed at https://github.com/mobilizingcs/responsetool/commit/badb5d0389e67ffa82b8f7e48f0a246d39ba3c85.

@jeroenooms The filter works great on chrome but not on FF (windows 7 and mac yosemite) and Safari (mac yosemite)

Thanks. I think this is fixed now.

Fixed on both FF and Safari now!


Update viscosity to 1.7.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 627077acaa55e0206d971c22c76fe60e7d5a73ac. Your contribution is still credited to you.


OpenPrescribing outlier detection issues following ICB changes

Following the recent ICB changes there are some new issues with the outlier detection pages.
Broadly, STP reporting needs to be changed to ICB reporting and CCG reporting needs to be changed to sub-ICB location.
These are the particular parts I've found that would need to change:

Links to outlier detection from ICB pages are broken - e.g. https://openprescribing.net/icb/QRV/ links to https://openprescribing.net/labs/outlier_reports/html/static_stp_QRV.html which gives a 404 error
Sub-ICB locations link to correct reports but CCG references in text (and possibly URL) need to change to sub-ICB location e.g. https://openprescribing.net/labs/outlier_reports/html/static_ccg_W2U3Z.html
This page continues to list STPs and CCGs.
References in text at the top of each page need CCG references change to sub-ICBs and STP to ICB.

PCN and practice level seem to link/display fine.

Coming here to say this!
Is it possible to get an ETA on a fix? Not for pressure but I'm intending to do some STP talks as part of broader show and tell of our work. I can schedule for later in the year if this is a problem that will take awhile to fix.

Database changes

Create ICB/ sub-ICB level outlier tables (x6 total) : 30 mins
Change builds configuration table to assert which dataset builds correspond to which NHS org structure : 1h
Change build_outliers() sproc to build dynamic SQL statements for per-entity-level dataset creation based on above configuration : 1d

Update data processing layer

Change constants for known entity types : 5 mins
Change DatasetBuild class to support configurable hierarchical entity structure : 1d ( _get_hierarchy(), _truncate_results() and _truncate_entities() are monster functions that took me several goes to get right last time round)
Update "friendly-name" getters for new entity types: 30 mins

Update frontend code

Update entity name formatting functions: 5 mins
Update Table of Contents generation to support configurable hierarchical entity structure : 0.5d
Check HTML templates

@Jongmassey @inglesp just reviewing OP issues - is there an update to this?

It's not on my current to-do list, scheduling is an @inglesp  matter


Update custom-routes-enable-kms-activation.md

IP Address of kms.core.windows.net is solved in <IP_ADDRESS>.

@stefanogelmini : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@stefanogelmini Thanks for submitting the PR. The main host IP for kms.core.windows.net is <IP_ADDRESS>.  Other IPs are not static. So to avoid confusing,  we will not add these IPs to the articles.


Mobile Support

[ ] Android Support
[ ] iOS Support

Linked to ticket #36

Anon Aadhaar is supported on mobile browsers.
I'm closing this ticket but we can open a new one for the next step which is native mobile proving.


download_sysext: HTTP client timeout and retry

Set the default timeout to 20 seconds, so HTTP client can abort after that timeout.
If HTTP client fails to download, retry to download once in 1000 msec, up to 20 times.
Fixes https://github.com/flatcar/ue-rs/issues/15

It doesn't retry in this case: During download I deactivated my wifi and the connection was stuck because we don't have the read timeout (see issue). When activating my wifi again the download seems to continue but directly failed without retry:
read 13926158/28371306 ( 49%)Error: unable to download data(url Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("update.release.flatcar-linux.net")), port: None, path: "/amd64-usr/3815.0.0/oem-azure.gz", query: None, fragment: None })

Caused by:
    0: failed to get response chunk
    1: request or response body error: error reading a body from connection: end of file before message length reached
    2: error reading a body from connection: end of file before message length reached
    3: end of file before message length reached

I think I see the problem: We only retry getting a response (the header) but we don't retry the full download. We need to wrap the whole function and can't split it into two parts.

As discussed, this PR is re-implemented without tryhard crate.

If we want to keep ? for error handling we should retry the whole function - eg. with a helper function download_and_hash_retry that loops around it.

If we want to keep ? for error handling we should retry the whole function - eg. with a helper function download_and_hash_retry that loops around it.

With https://github.com/flatcar/ue-rs/pull/44 this will be easier

Brought back to a simple local wrapper version without tryhard, without passing File, without tokio, based on https://github.com/flatcar/ue-rs/pull/44.


Create Redirects for images hosted in FTP

[ ] Redirect /everywhere/1a.jpg to https://cdn.crimethinc.com/assets/everywhere/1a.jpg
[ ] https://crimethinc.com/rt/pics/rt32b.jpg
[ ] https://crimethinc.com/summer/poster.pdf
[ ] https://crimethinc.com/texts/battle/images/header2000.jpg
[ ] https://crimethinc.com/texts/democracy/images/bridge.gif
[ ] https://crimethinc.com/texts/from-ferguson-to-the-bay/images/quote1370.jpg
[ ] https://crimethinc.com/texts/police1.gif
[ ] https://crimethinc.com/texts/police3.gif
[ ] https://crimethinc.com/texts/reaction/images/trump1370.jpg
[ ] https://crimethinc.com/tools/downloads/pdfs/anarchyandalcoholreading.pdf
[ ] https://crimethinc.com/tools/downloads/pdfs/forgetterrorismafterthefall.pdf
[ ] https://crimethinc.com/tools/downloads/pdfs/huntergatherer.pdf
[ ] https://crimethinc.com/tools/downloads/pdfs/jointhewar.pdf
[ ] https://crimethinc.com/tools/downloads/posters/pdfs/millionsofdollarsinprizescolor.pdf
[ ] https://crimethinc.com/tools/downloads/preview/killagain.gif
[ ] https://crimethinc.com/tools/downloads/previewbig/bulletbig.gif
[ ] https://crimethinc.com/tools/posters/genderbig.gif
[ ] https://crimethinc.com/wp-content/uploads/2008/01/bradwillrollingstone.pdf
[ ] https://crimethinc.com/wp-content/uploads/2016/03/1a-2.jpg
[ ] https://crimethinc.com/wp-content/uploads/2013/07/2b2.jpg from https://crimethinc.com/2013/07/06/is-she-an-informant-a-ten-point-checklist
[ ] etc

Is it normal that when I try to access https://cdn.crimethinc.com/assets/everywhere/1a.jpg I get an access denied error?

Looking at the S3 bucket, that file path doesn't exist.
I think what I meant when I wrote this ticket was: that was just an example.
But I think the ideal version would be to find the actual places where each of those files actually are lives now, and redirect to  correct image. Rather than just having a junk drawer of misc redirected images.

But maybe this whole ticket is a moot point because most everything will be in ActiveStorage soon, which doesn't have static URLs (AFAIK at least).

The right way to do the redirection is probably to find all images in the public folder and in the content and redirect them to CDN.
Oh, you plan to migrate all image with static link to Active Storage? I'm wondering how we can handle redeployment or stuff like that since in local we have to reinsert every image from the bucket, tho?

I'm not sure how we should handle Active Storage + local development.
I don't think we should put all images the CDN or Active Storage. Like the logo and stuff, that should probably stay in app/assets/images. But the stuff in public/ that was there for old features or TCE etc. Those should all move into: app/assets/images or the CDN.


fix: typos and grammer errors

I fixed some typos and grammer errors, I'll deep dive into moccasin later

Thank you!


Update s3, sdk-core, sqs to 2.17.109

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.104 to 2.17.109.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #395.


Cleanup tqdm leftovers

After moving to logging (#115), there are some leftovers of tqdm.

https://github.com/ynop/audiomate/blob/master/audiomate/utils/download.py
Check that there are no other occurrences
Remove tqdm dependency

Fixed in e28811ac59c5c6df9dcd495b5b804ab4dac533c1


[writer]Surround string by double quote instead of simple

I would like to be able to take a json object like this :
{
    translation:
        {
            key: 'this_is_a_key',
            value: 'this is a value'
        }
}

and output a yml file like this :
- translation :
    key: "this_is_a_key"
    value: "this is a value"

I've tried several method but was only able to achieve either
- translation :
    key: this_is_a_key
    value: this is a value

or
- translation :
    key: '"this_is_a_key"'
    value: '"this is a value"'

note that in the latter this is not three quotes but a single quote followed by a double quote
Is there any way to do this with this module?

There's no settings for this at the moment. The dumper tries to choose "minimal" possible scalar style to represent each particular string.
Ability to specify preferred scalar styles would be nice addition though. Contributions on this matter are welcomed.

Okay thanks for the answer, will see if i can contribute.

Any news on this feature?

I'd appreciate this too!

Fixed by https://github.com/nodeca/js-yaml/commit/7b256d7612a4c29cdf5dfd48a15e01c8dbbb5291 in dev branch, gonna be released later.
console.log(require('js-yaml').dump({ key: "this_is_a_key" }, { quotingType: '"', forceQuotes: true }))
// outputs:
// key: "this_is_a_key"


Make use of UnionFS optional for single-jar sources (opt-in via system property for now)

I approved this, but I would like a report on how this runs in different production scenarios, both moddev as well as normal production.

I thought it implemented the jar scheme??? WTF


added llama-3.2-90b-vision-preview model

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

I don't think adding the Llama 3.2 90B model is necessary. The only difference between this model and the Llama 3.1 70B model is the 30B vision adapter.
Since this extension currently doesn't support using screenshots, adding this model wouldn't make much sense.

Closing as it doesn't make sense to add


Update LAB_16_explore_azure_policy.md

Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:

Submitted by jfinleynz on behalf of MOC Labs Review

The step currently states "Exit of the ASC page..."  Per the screen shot, the page is referred to as ASC Default.  Leaving the item as is and closing out this item.


Jest unit tests - SyntaxError: Unexpected token 'export'

My application codebase is in NextJs with React.
I have a component Media, that needs user consent to enable a script that collects data, so we created a hook that verifies if we can load this Media component.
I can run more atomic (atomic pattern design) unit tests without any problems, but when coming to organisms, I start getting this error.
Can you guys assist me on this?
yarn run v1.22.19
$ jest --silent Hero.spec.tsx
 FAIL  src/components/organisms/Hero/__tests__/Hero.spec.tsx
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /<APPLICATION>/node_modules/@s-group/react-usercentrics/dist/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){export { UsercentricsDialogToggle } from './components/UsercentricsDialogToggle.js';
                                                                                ^^^^^^

    SyntaxError: Unexpected token 'export'

    > 1 | import {
        | ^
      2 |   getServicesBaseInfo,
      3 |   hasServiceConsent,
      4 |   ServiceInfo,

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1505:14)
      at Object.<anonymous> (src/hooks/usePermission.ts:1:1)
      at Object.<anonymous> (src/hooks/useMarketo.ts:3:1)
      at Object.<anonymous> (src/hooks/index.ts:9:1)
      at Object.<anonymous> (src/components/molecules/media/Media.tsx:4:1)
      at Object.<anonymous> (src/components/molecules/media/index.ts:1:1)
      at Object.<anonymous> (src/components/organisms/Hero/Hero.tsx:7:1)
      at Object.<anonymous> (src/components/organisms/Hero/index.ts:1:1)
      at Object.<anonymous> (src/components/organisms/Hero/__tests__/Hero.spec.tsx:3:1)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        8.356 s
error Command failed with exit code 1.

The error message is pretty descriptive, sounds like your configuration is not supporting ESM packages natively and some transpilation is necessary!


Fix app crash when admin pay elsewhere and open the report

Details

App crash when admin pay elsewhere and then open the one-expense report.
Fixed Issues

$ https://github.com/Expensify/App/issues/47542
PROPOSAL: https://github.com/Expensify/App/issues/47542#issuecomment-2292980394
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Create a Control workspace.
Submit an expense as an employee.
Pay the expense as the admin.
As admin navigate to payed thread transaction

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/a861196a-e930-438d-89ff-f4e5f4c8b916

Android: mWeb Chrome

https://github.com/user-attachments/assets/9549ff38-10fe-474d-bae0-d0007b924445

iOS: Native

https://github.com/user-attachments/assets/54337107-ecdb-400e-8738-525d1a327aee

iOS: mWeb Safari

https://github.com/user-attachments/assets/59344670-0468-4dd4-becc-6f635facb579

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/550201f3-2bd7-4979-af3c-34c39d31af2a

MacOS: Desktop

https://github.com/user-attachments/assets/37bdb2e0-427b-470e-94c1-554fe2823776

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Image dimensions

The maintainer team has spotted that there were typescript interfaces indicating support for checking image dimensions. Users could've passed width and height constraints as parameters to the hook config.
It turned out that dimensions checking wasn't implemented, and these values were being ignored, so to not delude users further I implemented that.
Don't bother with lines changed count - it's yarn.lock because I've also bumped tslib version to 2.2, so it stopped complaining about unsupported spread operator in dev (while of course it is supported). The actual amount of changed lines is about ~170 which effectively doubles the bundle size, but I still think it is quite small (5 KB minified).

Looks good to me, good job. I will test it soon

Pr closed because of the newer approach to solving this problem. See: #19


Add support for Linuxbrew

First pass at adding Linuxbrew support.
Use on_macos/on_linux and on_arm/on_intel as Homebrew stanzas instead of Hardware::CPU.type
Update insta snaps.
Fixes #501

Thanks for catching those missing do statements. Updated along with the name fixes.

Done, just pushed another commit.

Thanks again! We'll include this in a future release, most likely 0.6.0.


Locality Based Routing Support

Description:
Implement locality based routing support by default in EG. Now that we we can have individual endpoints as backend to EG. Can we support region/zone/subzone based routing based on EndpointSlice information, node labels etc.?

Hey @tanujd11 from a user perspective can you share what you like to happen on the data plane ( from gateway to multiple backend endpoints with different topology info )

I understand this is very useful for optimizing East West traffic within a cluster, is that also the case for north South ?

I think for an Envoy gateway running in us-east-1/us-east-1a should prefer the same zone backend to prevent cross zonal traffic. I think this behaviour could be made as default as cross zone communication is obviously costly. WDYT?

thanks, here's something more to think about

opt in or default - K8s service has a opt in annotation https://kubernetes.io/docs/concepts/services-networking/topology-aware-routing/#enabling-topology-aware-routing service.kubernetes.io/topology-mode
Is this a soft preference (weighted) or hard preference (priority)

there's a new field in the Service spec (trafficDistribution.preferClose) https://kubernetes.io/docs/concepts/services-networking/service/#traffic-distribution that we could consider using to automate priority amongst endpoints within a Service

there's a new field in the Service spec (trafficDistribution.preferClose) https://kubernetes.io/docs/concepts/services-networking/service/#traffic-distribution that we could consider using to automate priority amongst endpoints within a Service

Could be an option when this new field is stable and corresponding K8s version is adopted by massive companies.
Before that, IMO it's better to do load balancing accross endpoints in the cluster via Envoy's capability.
Currently EG has implemented locality weighted load balancing ^1, one BackendRef is translated to one LocalityLbEndpoints.
locality := &endpointv3.LocalityLbEndpoints{
	Locality: &corev3.Locality{
		Region: fmt.Sprintf("%s/backend/%d", clusterName, i),
  	},
	LbEndpoints: endpoints,
	Priority:    0,
}

// Set locality weight
var weight uint32
if ds.Weight != nil {
	weight = *ds.Weight
} else {
	weight = 1
}

Actually endpoints inside a LocalityLbEndpoints may be running in different zone, cross zone cost can't be saved in this way.

Through Envoy's capability, priority levels ^2 or zone aware routing ^3 ^4 can archive the goal to save cross zone cost.
priority levels

Backend endpoint should be set with correct zone, it can be retrieved from EndpointSlice, inherited from Node topology.kubernetes.io/zone label.
Envoy's command options should be set with --service-zone option, means which zone Envoy Pod is running in.
EG rearranges EDS resources for each Envoy, if Envoy and Backend endpoint are in same zone, priority as 0, else 1.

zone aware routing

This approach is mutually exclusive with locality weighted load balancing, since in the case of locality aware LB, we rely on the management server to provide the locality weighting, rather than the Envoy-side heuristics used in zone aware routing.

Backend endpoint should be set with correct zone, it can be retrieved from EndpointSlice, inherited from Node topology.kubernetes.io/zone label.
Envoy's command options should be set with --service-zone option, value meaning which zone Envoy Pod is running in.
Envoy's bootstrap config should be set with cluster_manager. local_cluster_name, means which fleet Envoy Pod belongs to, it will be irKey in implementation.
Add cluster corresponding to cluster_manager. local_cluster_name to CDS resources.
Design a mechanism to discover Envoy Pods belongs to cluster_manager. local_cluster_name as endpoints and add them to EDS resources.
Both Envoy and Backend cluster are not in panic mode ^5.

personal preference
Since step 1 and 2 is required by both, priority levels can work with implemented locality weighed load balancing, but zone aware routing can't. Apparently priority levels are easier to implement. But it requires EDS resources should be arranged in xds/cache module for individual Envoy. No matter EG do this, or create new xDS Hook API, like PostEndpointModify(ClusterLoadAssignment, Node) which allow extension server to do this.

thanks for outlining the steps @aoledk ! we currently have https://github.com/envoyproxy/gateway/issues/3055 open to get explicit priority per backendRef and program that into the xds cluster resource.
In the future, we can use this issue to make sure we track the auto priority work, the field in k8s preferClose could be the knob for users to say they want to opt in to this feature

Hi @aoledk, regarding:

priority levels
[...]
EG rearranges EDS resources for each Envoy, if Envoy and Backend endpoint are in same zone, priority as 0, else 1.

Is this option viable? Can our XDS server produce different EDS for different envoy pods that are part of the same Envoy deployment?

I think it's possible. xDS server can read the locality info of envoy node.

The cache will be keyed based on a pre-defined hash function whose keys are based on the Node information.

// Identifies a specific Envoy instance. Remote server may have per Envoy configuration.
message Node {
  // An opaque node identifier for the Envoy node. This must be set.
  string id = 1;
  // The cluster that the Envoy node belongs to. This must be set.
  string cluster = 2;
  google.protobuf.Struct metadata = 3;
  Locality locality = 4;
  // This is motivated by informing a management server during canary which
  // version of Envoy is being tested in a heterogeneous fleet.
  string build_version = 5;
}

Thanks for pointing that out @modatwork. My other concerns wrt. to this approach are:

Conflict with general-purpose use cases of priorities (e.g. to support things like active/passive failover)
Possible impact on memory consumption if we have to maintain a copy of the cache for each locality. Not sure if that's already the situation today. @arkodg  - do you know?

In general:

I'm +1 to supporting zone-aware routing in EG.
I would avoid using priorities for this feature in EG's built-in feature set.
The the extension-server approach to EP priority manipulation could work. If we don't have a per-locality cache, maybe that should be an opt-in feature.

Is there a reason to prefer the Priority-based approach? I'm not sure that it's significantly simpler than enabling zone-aware routing.

is @modatwork the same person as @aoledk :) ?

Possible impact on memory consumption if we have to maintain a copy of the cache for each locality. Not sure if that's already the situation today. @arkodg - do you know?

@guydc we have are dumuxing on gateway/IR, with locality it would add another dimension lookup and would increase memory by num localities * total (xds per gateway * gatways)

@arkodg I work together with @modatwork

hey @aoledk , adding this issue to the v1.2 milestone, is this something you can help with ?

Lets configure zone aware routing in envoy by default https://www.envoyproxy.io/docs/envoy/latest/faq/configuration/zone_aware_routing
If a Service has TrafficDistribution set to PreferClose https://kubernetes.io/docs/concepts/services-networking/service/#traffic-distribution, lets rearrange the EDS endpoint (so Service opts in)

hey @aoledk , adding this issue to the v1.2 milestone, is this something you can help with ?

Lets configure zone aware routing in envoy by default https://www.envoyproxy.io/docs/envoy/latest/faq/configuration/zone_aware_routing
If a Service has TrafficDistribution set to PreferClose https://kubernetes.io/docs/concepts/services-networking/service/#traffic-distribution, lets rearrange the EDS endpoint (so Service opts in)

@arkodg I can help.

awesome thanks @aoledk !

hey @aoledk still planning on working on this one for v1.2 ?

hey @aoledk still planning on working on this one for v1.2 ?

Hi @arkodg nowadays I'm working on bring in EG v1.1., next month I will continue on this feature, but not sure whether it can be merged into v1.2 (Due by October 30, 2024), maybe v1.3.

thanks for the update @aoledk, let us know if you hit any issues while running EG v1.1
moving this issue into backlog

@arkodg LGTM.

Hi @aoledk! Are you still looking into implementing it yourself? If not, I’m interested in this feature and can work on bringing it to life.

@flyik recently I'm busy with bringing in EG, you can go ahead.

@flyik I've unassigned myself, you can assign to yourself.


Do not try to use unsupported Auth method

If OIDC discovery returns a list of  token_endpoint_auth_methods_supported, and token_endpoint_auth_method option was not provided, do not pick first from the list of IdP supported methods, instead pick first supported by library.
https://github.com/pingidentity/lua-resty-openidc/blob/8c15adb55b2290c80808e98b9f1503941ea87376/lib/resty/openidc.lua#L545
Out of 4 methods, described in discovery spec (client_secret_post, client_secret_basic, client_secret_jwt, and private_key_jwt) looks like only first 2 are actually supported.
Also it will be more clear if validation will be done against supplied token_endpoint_auth_method, that it is actually supported by library, not only that it is present in discovery response.

@betalb I think #96 should solve this.


Endergy Totemic Capacitor recipe is totally unbalenced...

Issue Description:
I have installed EnderIO and the Endergy Addon, and when I look the recipes and try each new capacitor, the Totemic one (how sincerly is probably one of the most difficult one to make) as just zero benifit over the Crystaline one (how is used into the recipe...). I compare the speed of the machine, the power consumption and the total amount of power capacity, everithing is same... This look totally illogical and unbalanced...
For sure, I can change the recipe my self (And I will probably do for my modpack), but, I think you should look to change somes things about that ;)
What you expected to happen: This capacitor should give a good boost or use other cheaper capacitor into the recipe...
Steps to reproduce:
1.Install EnderIO + Endergy
2.Test!!
...

Affected Versions (Do not use "latest"):

EnderIO: 5.0.40
Endergy: 5.0.40
EnderCore: 0.5.45
Minecraft: 1.12.2
Forge: <IP_ADDRESS>06
SpongeForge? no
Optifine? no
Single Player and/or Server? Single Player, but for sure on server it will be the same!

Your most recent log file where the issue was present: I don't think you need logs, because this is not a bug, but possibly an Unexpected Feature!!
Fireztonez

if you enchant it with efficiency it gets better. ALOT better

I just try with differents enchants, but I can't find any enchant how boost the efficiency... For what I see now, the only big difference is the fack the Totemic Capacitor have durability, and the Crystaline one is unbreakable... So yeah, again, for me this is one look completly useless for the cost... For what I see, using an Octadic Capacitor in the recipe will be really more balanced than using the Crystaline one...
If you know whta enchant I can apply to make it more Efficient, I really whant to know!!

Ok, sorry, I just saw that I had misread your answer @tyler489, so, indeed, to have tested with the enchante Effectiveness 5, it is rather Crazy !! But, I find myself with the problem that the capacitor can not receive the enchanted Efficiency in survival mode in my ModPack. But I just live on a clean instance it works, so the problem is on my side, I'll have to analyze which mod creates the problem.
Thank's for your help!

My Bad, I just try again, and this is just impossible to apply Efficiency Enchant with an anvil on Totemic Capacitor in survival.
Mods installed in the Dev Pack

Mods:
CodeChickenLib-1.12.2-<IP_ADDRESS>3-universal
CraftTweaker2-1.12-4.1.14
Cucumber-1.12.2-1.1.3
EnderCore-1.12.2-0.5.45
EnderIO-1.12.2-5.0.40
EnderIO-endergy-1.12.2-5.0.40
EnderTweaker-1.12.2-1.1.4
ExtendedCrafting-1.12.2-1.5.2
jei_1.12.2-<IP_ADDRESS>7
mpbasic-1.12.2-1.4.5
MPUtils-1.12.2-1.5.4

So this test modpack is really clean, so, I don't thinkthis is a conflict with other mod...
Thank's
Fireztonez

    if (enchantment.getName().equals("efficiency")) {
      return true;```

I cannot enchant the Capacitor in the Enchanting Table...

Sorry I actually had a reply written but I didn't click the "comment" button to sand it for some reason.
Can you test that with just Ender IO? It works for us, but I want to rule out that there's something weird going on before I start blaming other mods...

Like I said, I have try with only EnderIO somes small other tweak mods, but, the only mods real mod adding thing in that pack is Extended Crafting... You can see the list of mod installed into the small test pack...
But I have try to remove the 3 or 4 mods I have added, so, whit the smallest pack possible, with only EnderIO, JEI, Endergy and EnderCore, still doesn't work... I have no crafttweaker, nothing in that pack now, so, if this is still in my end, this is caused by forge or Java directly, but this really really look with a bug on your end...

Are you using the single jar of enderio and energy or the split jars?

I also can't enchant it with efficiency...  I thought it might have been the quark matrix enchanting being screwy since that's still a beta feature, but it doesn't show up in JEI and the /enchant command with a non-enchanted totemic cap in hand doesn't work either, saying it can't be added to the item.  According to /ct enchants the efficiency enchant hasn't had an ID change...
-enchantment:minecraft:efficiency - Efficiency I (at level 1, max level 5, treasure: no, enchant id 32)
Aside from the quark-modified vanilla table which works with everything else, tried the vanilla anvil which doesn't allow enchanting with any level of efficiency book,  the cyclic enchanter which doesn't do anything to it at all including allowed enchantments, and attempted to throw it on the botania mana enchanter but that won't accept it for whatever reason.
Adding it manually via /give with the NBT data worked and retained the enchantment when combined with another on the anvil but that was the only way I could get it there.

Other thing I saw, I don't know if this is intended or not, but Efficiency 5 clearly give a big Efficiency Boost, but, Efficiency 1 doesn't have any effect, I have don't try every level, but that what I saw after couples tests...

Other thing I saw, I don't know if this is intended or not, but Efficiency 5 clearly give a big Efficiency Boost, but, Efficiency 1 doesn't have any effect, I have don't try every level, but that what I saw after couples tests...

That looks like a bug to me...
https://github.com/SleepyTrousers/EnderIO/blob/12df4e5aa3278ed0cac8f56a58f262e0726ec52b/enderio-endergy/src/main/java/crazypants/enderio/endergy/capacitor/ItemTotemicCapacitor.java#L74
Integer division by 2 of the enchantment level means level 1 does nothing, l2-3 add 1, and l4-5 add 2, so there doesn't seem to be a point to applying L1 (or L5 over L4) at the moment.   There should probably be a float cast in there so it scales evenly.

@EpicSquid

I rename the issue question of making the title more clear about what is exactly the issue. I hope this is fine for you...

So, any news about that issue?
Do you have time to look in the code why this is not possible to enchant with Efficiency at all in survival and why Efficiency 1 doesn't give any bonus?

The issue is still existing and is exacly the same with the new update:
Endergy: 5.0.43
Ender IO: 5.0.43
Ender Core: 0.5.52
Still impossible to enchant with efficiency the Totemic Capacitor and the Efficiency 1 still doesn't have any effect... Do you have look about that issue or not have time yet to look about that?

@EpicSquid @HenryLoenwind @tyler489
I want to know if you think you will be able to fix that issue one day, because, this have been open for more than 2 mouths, 4 EnderIO update later, and the ther ehave absolutly no advancements and no news about that. Without having that issue fixed, there have absolutly no poin ts to craft a Totemic Capacitor,  because you can't enchant with Efficiency at all, so, this is basically a downgrade for the Crystalline Capacitor...
I know this is not the only thing you have to do, and I can understand, but I just want to have somes news about that..
Thank's

I still cannot replicate the issue in any tests I have used. Enchanting it with an efficient book in an anvil still works for me. I will take another look again soon, but it's still surprising me this issue has persisted

@EpicSquid Have you try to enchant in survival, because in creative every enchant can be apply on anything with the anvil... I just try again, in a new instance with only EnderIO, Endergy, EnderCore and Just Enough Items and it still doesn't work.
For sure, I can enchant in creative mode, but, for sure, you have to be able to enchant with Efficiency in survival.
For now, in my modpack I have add custom crafting table recipe for the enchant with an Enchanted Book, the capacitor + somes XP level, question to be able to obtain the capacitor with the Efficiency Enchant...
If you are still not able to reproduce, I really wonder if the issue is not caused by something more specific with my machine... If it can help, I run the modpack on Windows 10, with Java <IP_ADDRESS>... I install the mod with the Twitch App, but run by Multi-MC or directly by the Twitch app...
Version:
forge-<IP_ADDRESS>38
EnderCore 0.5.57
EnderIO 5.0.44
EnderIO Endergy 5.0.44
Fireztonez

This is an Ender IO bug, nothing to do with mods.


Remove references to deprecated v1 Android embedding

Remove references to deprecated v1 Android embedding
To ensure this plugin will work with users running the next stable version of Flutter remove references to the v1 embedding.
The v1 embedding was deprecated around 6 and a half years ago. In Flutter 3.22, the Flutter tool dropped support for building v1 apps entirely. Flutter plans to delete version one of it's Android embedding in the next stable release, per https://medium.com/flutter/whats-new-in-flutter-3-22-fbde6c164fe3 (in the "Removal of v1 Android embedding" section).
When that deletion happens, any apps using plugins that still have references to the removed classes will fail to build when updating to the next stable version (probably Flutter 3.26).
As a part of this deprecation, the Flutter Android team is doing community outreach by filing bugs and submitting some pull requests to update plugins to minimize the impact this removal has on the community.
Some example PRs:

Flutter team maintained plugins: https://github.com/flutter/packages/pull/6494
android_alarm_manager_plus https://github.com/fluttercommunity/plus_plugins/pull/2864

Consequences:

This change should have no impact on users of this plugin that are building apps using the v2 embedding (we don't have a percentage to share, but this is the vast majority of users).
It will remove support for users that are still using the v1 embedding on versions of Flutter older than 3.22.

If this change doesn't land, this plugin will instead be broken for all apps building on the next stable version of Flutter and beyond.
Is there a way to support both v1 and v2 embedding apps in the next stable version of Flutter?
No.
This is the PR where we are removing the deprecated engine classes: https://github.com/flutter/engine/pull/52022

https://github.com/flutter/engine/pull/52022 has been merged. Users targeting Flutter master and beta/stable releases after (but not including) 3.27 will fail to compile if the plugin has references any v1 embedding classes.
To aid in identifying these classes here is a search query you can run in github on your repo.
("io.flutter.view.FlutterMain" OR "io.flutter.view.FlutterNativeView" OR "io.flutter.view.FlutterView" OR "io.flutter.embedding.engine.plugins.shim" OR "io.flutter.app" OR "PluginRegistry.Registrar")

Still no response. @reidbaker do you have a fork?

I do not have a fork and will not be creating one.

I think the main problem with this plugin is that no updates are pushed out. E.g. a fix from me https://github.com/fryette/webview_cookie_manager/pull/66 was merged in march and is still not published.

I guess we just have to use your git reference then. @rekire

@rekire the for that you made. Was it the v1 to v2 embedding migration?

I am not sure, I would need to review what is actually required and what I did in the past. My guess is no.
My comment was more about that this package seems to be unmaintained at the moment.


The highlight doesn't contain the final "}“ after inserting an item

OS: Mac
Build: 20200528.2
Repro Steps:

Open a template file in VS Code.
Right click in editor --> Insert an item.
Check the result.

Expect:
The highlight contains the final "}“.
Actual:
The highlight doesn't contain the final "}“.

We're not actually trying to highlight anything, we're placing the cursor (and therefore the selection) inside the value's expression so the user can start typing.  Ideally this would be a snippet, maybe we'll make that change sometime in the future.


Hard-coded context length in DAM ranking model?

I'm training a DAM neural ranking model following the example for Ubuntu V2 dataset. I want to repeat the same analysis with my own data with varying context length size.
However, I think there is a problem in line 99 of "deep_attention_matching_network.py". The call
super(DAMNetwork, self).__init__(*args, **kwargs)
does not allow custom context lengths, but always reverts to the default 10 (in "tf_base_matching_model.py" line 46).
The correct behavior (at least no errors) is achieved by replacing above call with:
super(DAMNetwork, self).__init__(num_context_turns=num_context_turns,*args, **kwargs)
Could you check if this is a bug in the code. Or maybe there is something missing in "ranking_ubuntu_v2_mt_word2vec_dam.json" config file.

Yes, this is a bug. Thank you. We will fix it in the nearest release.


Fix Travis and add Codecov

I think the person doing this would need admin rights on the repo.
You don't have sufficient rights to enable this repo on Travis.
Please contact the admin to enable it or to receive admin rights yourself.

When you fork you can also run the tests in your own repo.

Ahh, good point.

I opened a PR for this. Let me know what you think. I think it is a decent start, but could be cleaner.

Ta!


Feature request: Disable/customize automatic builds (from orig. old-repo issue "Don't compile automatically", included)

Refiled from an old issue at https://github.com/JakeBecker/elixir-ls/issues/120 (by @crbelaus)
The simplest suggestion I saw was simply adding a config option to disable automatic builds. See comment from @toranb for a potential spot to put the config check.
Related ideas for helping similar issues:

Add support for config options already supported by mix compile (assuming that's the command ElixirLS uses to build). Even something as simple as a string option whose contents are just appended to the mix compile command. Especially the :build_embedded option, though I wouldn't be surprised if that flag would impact performance significantly.
Add a --no-compile option for dialyzer, like provided by dialyxer.

Original post
with choice comment(s) to help anyone trying to write a PR.
NOTE: original post discussion might be dated, taking place from 2018 to early 2019.

crbelaus commented on Sep 11, 2018

Environment
* Elixir & Erlang versions (elixir --version): 1.7.1

* Operating system: Mac OS

* Client (editor or IDE): Visual Studio Code

Currently, when I save a file ElixirLS automatically compiles in the environment specified by the elixirLS.mixEnv setting (by default test). I am working in a project that has many files and modifying some of them triggers lots of additional recompilations. Having ElixirLS automatically recompile them with every change usually puts a high load on my CPU.
I've tried to change the elixirLS.mixEnv setting to dev with the hope of having ElixirLS and my local Phoenix server to use the same build and avoiding each one of them to perform a separated compilation. Turns out that this does not work as expected because Phoenix builds are stored in _build while ElixirLS builds are stored in .elixir_ls/build.
My question is, is there any way to avoid ElixirLS trigger automatic recompilations and instead use the builds generated in the _build directory? Something along the lines of what the extensions vscode-elixir and atom-elixir do which use the _build directory files for inference and autocompletion.

...
OvermindDL1 commented on Sep 11, 2018

Except that 'feature' in vscode/atom causes so many bugs and miscompiled beam files that I had to change them to use test exclusively so there wouldn't be any concurrent recompilation breakages like zero-sized beam files. What elixir-ls currently does is far superior.

...
crbelaus commented on Sep 12, 2018

Yes @OvermindDL1 I've found the same problems when two sources try to save the build artifacts to the same path. What I meant was to make the extension use the build artifacts stored in _build but don't compile anything itself.
This way I could control when the application is compiled by running mix compile manually or using the Phoenix autoreload feature. The extension would limit itself to read those compilation artifacts.
Thank you @JakeBecker ! I will try to build a PR 🔬

...
toranb commented on Apr 11, 2019

I would also love this config option but a gentle nudge in the right direction might help land a PR sooner ;) rather than later
edit: I would guess this might be an easy escape valve to check for configuration before doing the re-compile
https://github.com/JakeBecker/elixir-ls/blob/master/apps/language_server/lib/language_server/server.ex#L298

If relevant, here's my env info
Environment

Elixir & Erlang versions (elixir --version):

 Erlang/OTP 22 [erts-<IP_ADDRESS>] [source] [64-bit] [smp:16:16] [ds:16:16:10] [async-threads:1] [hipe]
 Elixir 1.9.2 (compiled with Erlang/OTP 20)

Operating system: Mac
Editor or IDE name (e.g. Emacs/VSCode):  VSCode
Editor Plugin/LSP Client name: jakebecker.elixir-ls

I would LOVE to be able to disable compiling.
As i'm coding on a sshfs mounted drive and i'm getting constant conflicts with the server end and my dev end.
also argon2 nmake over sshfs hangs my whole system (which is an unrelated issue)

PRs are welcome

@laodc I don't have much spare time to go after it on my own, but I might be able to point you in the right direction for where to start. I'm not familiar with this repo at all, but if you wanna go after it and need help just ping me back :)


The handler's MauiContext cannot be null

In iOS and Android everything works well, but in Windows I have this error everytime.
Could it be related to the Microsoft.Maui.Controls.Compatibility present in the CardsView? Is there something I could do to workaround this?

Hi @riccardomartins
It seems to be maui issue
https://github.com/dotnet/maui/issues/11600

Thank you @AndreiMisiukevich


Make THEME_URI available in twig files

Hello,
I'm sure you will tell me there is already a wonderful way to do this that I don't know about, but I had to add this in so that I could access THEME_URI in my .twig files. If this is no good then don't add it obviously, but if there is no way to do this currently then it would be good to have something like this added in.
File changed: app/Services/Shortcode.php
Line added: 87

Hey Chris,
You can use context argument
wpkit()->addIntegrations(array(
   'timber' => array(
     'file' => '',
      'context' => array(
          'path' => THEME_URI
      )
   )
));


Safe Area needs to be added.

Great widget :)
Can you add a safearea at the bottom for devices which need it. On a iPhone XS Max when scrolling the picker at the bottom of the page it sometimes grabs the bottom bar and then swipes the whole application to close.

支持 我也需要这个功能

I got SafeArea working by using the makePicker() method and building it with showModalBottomSheet.
For example:
await showModalBottomSheet(
   context: context,
   builder: (BuildContext context) {
        return SafeArea(
          child: Picker( ... ).makePicker(null, true),
        );
     },
  );
}

It's not as clean as a simple boolean would be, but it works. A built-in solution would definitely be nice, though.


Cannot debug a function that takes a STDIN input

Description:
The VS Code extension doesn't support debugging a STDIN as there is no way to enter the user input via the debug console.
Steps to reproduce:
Try to debug with the following code.
string input = io:readln();

Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Created https://github.com/ballerina-platform/ballerina-lang/issues/36561 to track this issue.


conntrack: Configurable timeouts

This PR allows configuring different timeouts for connections based on their key fields.
conntrack:
  keyDefinition:
    fieldGroups:
    - name: protocol
      fields:
      - Proto
    # ...
  scheduling:
  - selector: # UDP connections
      Proto: 17
    endConnectionTimeout: 5s
    updateConnectionInterval: 40s
  - selector: {} # Default group
    endConnectionTimeout: 10s
    updateConnectionInterval: 30s

Implementation: Instead of using a single Multi-Order Map in the connection store for all the connections, the connection store will have a Multi-Order Map for each scheduling group. In addition, the store has a new hashId2groupIdx map that given a connection hash ID, finds the Multi-Order Map of the connection.
Other changes:

Add a scheduling group label to the conntrack_memory_connections operational metric. This allows monitoring the number of active connections per scheduling group.

Codecov Report

Merging #357 (4731b57) into main (cfbf733) will increase coverage by 0.83%.
The diff coverage is 97.88%.

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   68.57%   69.41%   +0.83%
==========================================
  Files          87       88       +1
  Lines        5063     5234     +171
==========================================
+ Hits         3472     3633     +161
- Misses       1369     1382      +13
+ Partials      222      219       -3

Flag
Coverage Δ

unittests
69.41% <97.88%> (+0.83%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/pipeline/extract/conntrack/store.go
80.70% <96.38%> (+18.70%)
:arrow_up:

pkg/api/conntrack.go
89.68% <100.00%> (+2.68%)
:arrow_up:

pkg/pipeline/extract/conntrack/conn.go
90.62% <100.00%> (+0.46%)
:arrow_up:

pkg/pipeline/extract/conntrack/conntrack.go
92.00% <100.00%> (-0.78%)
:arrow_down:

pkg/pipeline/transform/transform_generic.go
71.01% <0.00%> (-23.11%)
:arrow_down:

pkg/api/transform_network.go
83.33% <0.00%> (-16.67%)
:arrow_down:

pkg/pipeline/extract/timebased/heap.go
97.82% <0.00%> (-2.18%)
:arrow_down:

pkg/pipeline/transform/kubernetes/kubernetes.go
7.90% <0.00%> (-0.26%)
:arrow_down:

pkg/confgen/config.go
33.33% <0.00%> (ø)

pkg/api/encode_prom.go
100.00% <0.00%> (ø)

... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I tired to improve isMatchSelector(). Instead of converting both values to string and compare strings,
I added a check for the type of the value and convert the selector to that type. So at the end we have only one conversion and the comparison is in the original type.
Currently, I implemented checks only for uint32, uint64, int64, int and bool since these types are in use by the protobuf decoder. Other types fallback to the string conversion-comparison.
I added a benchmark test to compare the performance of both approaches.
It seems that the new approach is faster. But, I'm not pleased with the code. It feels too verbose to me.
@jotak @KalmanMeth wdyt?, do you have ideas for improving?
goos: linux
goarch: amd64
pkg: github.com/netobserv/flowlogs-pipeline/pkg/pipeline/extract/conntrack
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkIsMatchSelectorStrings
BenchmarkIsMatchSelectorStrings/Proto_1
BenchmarkIsMatchSelectorStrings/Proto_1-4         	10560730	       133.7 ns/op
BenchmarkIsMatchSelectorStrings/Proto_2
BenchmarkIsMatchSelectorStrings/Proto_2-4         	10563658	       100.8 ns/op
BenchmarkIsMatchSelectorStrings/Multiple_fields_1
BenchmarkIsMatchSelectorStrings/Multiple_fields_1-4         	 2900412	       413.0 ns/op
BenchmarkIsMatchSelectorStrings/Multiple_fields_2
BenchmarkIsMatchSelectorStrings/Multiple_fields_2-4         	 5226672	       203.3 ns/op
BenchmarkIsMatchSelectorGeneric
BenchmarkIsMatchSelectorGeneric/Proto_1
BenchmarkIsMatchSelectorGeneric/Proto_1-4                   	24312217	        50.79 ns/op
BenchmarkIsMatchSelectorGeneric/Proto_2
BenchmarkIsMatchSelectorGeneric/Proto_2-4                   	28917752	        41.54 ns/op
BenchmarkIsMatchSelectorGeneric/Multiple_fields_1
BenchmarkIsMatchSelectorGeneric/Multiple_fields_1-4         	10039882	       119.5 ns/op
BenchmarkIsMatchSelectorGeneric/Multiple_fields_2
BenchmarkIsMatchSelectorGeneric/Multiple_fields_2-4         	12100579	        99.83 ns/op
PASS

(and sorry for the delay!)
/lgtm

@ronensc iirc we have the same kind of "unelegant but better" conversion somewhere in the code for loki... FLP is in a position where we must not neglect optimizations, so faster is better IMO


New interpreter with Reducer and GenericDist

Dependent on:

https://github.com/QURIresearch/squiggle/pull/68
https://github.com/QURIresearch/squiggle/pull/69
EDIT: also dependent on 68 followup https://github.com/QURIresearch/squiggle/pull/107

Edit the dispatch switch case in Reducer_Extension.res file to talk to distributions via the content of pull 69.

My guess is that this will be a fair amount of work to fully do, so we should do in steps.

Feels like we should close since present branch deploys are running through reducer.


Guide phrase for vehicle type selection.

Plz give your opinion on Guide Phrase.

Please enter the type of car you want.
SM3 Z.E, Ray EV, Soul EV, Nissan Leaf, Ioniq EV, BMW i3, Spark EV, Bolt EV, Tesla


DynamoDB support

Add DynamoDB support because DynamoDB is a fantastic DB-as-a-service and it integrates nicely with AWS Lambda.
This was quite the refactoring, because I had to abstract the DB layer. But it was a fun project.
Now it is easy to add support to other DBs as well.

https://github.com/kuka-js/kuka/pull/90


name 'SendSmsApi' is not defined

Hello.
I get this error win I try to send an SMS
from infobip_api_client.api_client import ApiClient, Configuration from infobip_api_client.model.sms_advanced_textual_request import * from infobip_api_client.model.sms_textual_message import * from infobip_api_client.model.sms_destination import *
can someone help
Thanks.

Hello @ayoubaayoub
I see, the issue you are experiencing is similar to the #14
If you browse through the dependency, you will see that SmsTextualMessage model is located within the sms_textual_message.py file.
In your attempt, you successfully directly imported ApiClient and Configuration models.
As well as all of the models included within the sms_advanced_textual_request.py file.
Hence to properly import SmsTextualMessage, you would have to import it separately as well:
You can do that by adding either:
from infobip_api_client.model.sms_textual_message import SmsTextualMessage
or alternatively, to import all models from that file:
from infobip_api_client.model.sms_textual_message import *

Ah, now I see you completely changed the issue :)
Let me quickly read that again

So, same as above...
If you browse through the dependency, you will see that SendSmsApi API class is located within the send_sms_api.py file.
Hence use either:
from infobip_api_client.api.send_sms_api import SendSmsApi
or with an asterisk:
from infobip_api_client.api.send_sms_api import *

@kiselica-aldin  thank you very much :).


remoeAll error

remoeAll error
for (int i = 0; i < playlist.length; i++) {
  remove();
}

In the end there is always one that cannot be cleared

Sorry, I haven't been working on this repo for over a year. You've probably already either solved your problem or abandoned it. I'm going to close this issue, but if you ask on Stack Overflow, I'll be glad to add a bounty to your question. Just ping me.


Storage: Refactor DMContext to avoid being misused

What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tiflash/issues/8312
Problem Summary:
What is changed and how it works?

Rename DMContext::db_context to DMContext::global_context
Always save global_context as member in DMContext
Remove a lock in DeltaMergeStore::newDMContext that does not have concurrent issue in the latest code

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-integration-test

/run-integration-test


[backport] Fixed sound buffering issues with compressed formats

Releated pull request for master: https://github.com/FreeRDP/FreeRDP/pull/6607
already tested with 2.2: http://debomatic-armhf.debian.net/distribution#buster-backports/freerdp2/2.2.0+dfsg1-1~bpo10+1.1

#6432


Are you open for mantaining data?!

There is only English data return, I would like add some foreign languages, such as Chinese.

Hi!
I think it would be pretty hard to implement. As I said on the website, I merge several public databases to get the location. Those databases don't provide anything else than English.
One of the solutions could be to call a translation service but it would greatly slow the response and it would make me rely on other services. I'm not a big fan of this idea.
Thanks for the suggestion but it won't be one of my priorities for now.
If you need the data in Chinese, maybe you could take the response userinfo sends and try to resolve it on a translation service (e.g. https://cloud.google.com/translate/docs).

@vdurmont Yes, I have tried Google Translate, it doesn't translate well on some locations. It not really focusing on GEO domain. I might create a opensource project, but if there is exiting one, it would be better.


Try it.

Welcome! Please use this template for reporting documentation issues on https://developers.google.com/web/.
For questions about Chrome DevTools, checkout the
google-chrome-devtools tag on StackOverflow.
For questions about Chrome, check the google-chrome
tag. If you think you've found a Chrome bug, check out our
feedback page for more details on how to file it.
Page Affected: https://developers.google.com/web/TODO

_npm gib lib vm nanokernel js.os swap browser cache --vram///nodejs.break.cloud:8080p2p<IP_ADDRESS>
host: js.os///vmwarevbox/uefi/npm/
dapp: js.os_libs-server-open-node.js://
cloud: /uefi/:uefi/;/uefi:/uefi/;;activembd -vm vim hash cherry oogles

[ ] Appropriate type-something label has been added.
[ ] Appropriate section-something label has been added.

Well idk what to think.


hnp_population

This pull request contains the code for the world bank population data from the health, nutrition and population database

hi aarushi - please provide the context for the change -- was there an import doc?
a readme would be great as well. some questions that we, as reviewers, would need context on:

where is the data from?
what is the data about?
any thing of note that you had to handle in processing this?

please also add tests.
take a look at some of the more recent imports for some examples of these.

Hi Carolyn,
Thanks, I will include the import doc here. I'll commit it to this
Thanks,
Aarushi
On Wed, Sep 15, 2021, 22:03 Carolyn Au @.***> wrote:

hi aarushi - please provide the context for the change -- was there an
import doc?
a readme would be great as well. some questions that we, as reviewers,
would need context on:

where is the data from?
what is the data about?
any thing of note that you had to handle in processing this?

please also add tests.
take a look at some of the more recent imports for some examples of these.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/datacommonsorg/data/pull/504#issuecomment-920176154,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATIDWI5RY6JSLLVL5YBVQJTUCDDFJANCNFSM5ECANDOA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Have you written and shared an import doc with the team? Here's a recent one - it's much easier to go over the broad strokes of the schema there.
https://docs.google.com/document/d/1fpi480t_fPqLBPemnDCo1hH6IlSOqqYIqxTJ15zxzYE/edit#
Please also add tests and a README. You can see lots of examples in the repo. Thanks!

I have written an import doc - there are some changes I'm making to it, as
well as to the code itself. I'll upload it as a readme once it's done
On Sat, Sep 18, 2021, 05:47 Carolyn Au @.***> wrote:

Have you written and shared an import doc with the team? Here's a recent
one - it's much easier to go over the broad strokes of the schema there.
https://docs.google.com/document/d/1fpi480t_fPqLBPemnDCo1hH6IlSOqqYIqxTJ15zxzYE/edit#
Please also add tests and a README. You can see lots of examples in the
repo. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/datacommonsorg/data/pull/504#issuecomment-922144145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATIDWIZFCSKMSTT7YZS4EXLUCPLDNANCNFSM5ECANDOA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

https://docs.google.com/document/d/16Qz9C3-Eyqd6KcwQ1hkMowfXnBQvyVg-L5b0EBhNWWU/edit
This is the current document
On Mon, Sep 20, 2021, 10:53 Aarushi Tiwari @.***> wrote:

I have written an import doc - there are some changes I'm making to it, as
well as to the code itself. I'll upload it as a readme once it's done
On Sat, Sep 18, 2021, 05:47 Carolyn Au @.***> wrote:

Have you written and shared an import doc with the team? Here's a recent
one - it's much easier to go over the broad strokes of the schema there.
https://docs.google.com/document/d/1fpi480t_fPqLBPemnDCo1hH6IlSOqqYIqxTJ15zxzYE/edit#
Please also add tests and a README. You can see lots of examples in the
repo. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/datacommonsorg/data/pull/504#issuecomment-922144145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATIDWIZFCSKMSTT7YZS4EXLUCPLDNANCNFSM5ECANDOA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@googlebot I signed it!

@googlebot I signed it

Hi Aarushi - did you mean to close the PR, or turn it into a draft instead?

Note: This was migrated to #520. Aarushi, please ensure that all comments from this PR have been addressed (and please respond to the comment that you've addressed them).


WIP: inplace upgrade: add initial upgrade logic

Adds inplace upgrade logic to the nodepool controller that will,
upon seeing a new machineconfig or release image, do the following:

create a upgrade namespace
create a configmap, which contains the new rendered config fetched
from the ignition server endpoint
create pods to perform the upgrade, and write necessary annotations
delete the pods and update nodepool status when done

This commit should be in a state that is ci-testable, with the caveat
that the MCD image used is being built from an external quay location.
The TODOs are as following:

Create CI for Hypershift and MCO repos
Add drain logic to the controller
Add disruptionless updates (and consider cert rotation)
Delete manifests (currently only pods are deleted)
Honour maxUnavailable
Harden logic for multiple upgrades

With additional considerations:

Config fetching, configmap parsing/compression (MCS will error
for a bit, but eventually succeed during upgrades)
Potential for sync to not automatically recover from fixed broken
states
MCD basiacally can be a daemonset, we have a state machine in there
Updates do not differentiate between version and config
Master configs are still being used via MCS
Scalability of the syncs with many nodepools (and lots of syncs)

Unit tests and docs not included.
To test, deploy this branch, and create a nodepool like:
apiVersion: hypershift.openshift.io/v1alpha1
kind: NodePool
metadata:
  name: ${NAME}
  namespace: clusters
spec:
  clusterName: ${CLUSTER_NAME}
  management:
    autoRepair: false
    upgradeType: InPlace
  nodeCount: 2
  platform:
    aws:
      instanceProfile: ${PROFILE}
      instanceType: m5.large
      rootVolume:
        size: 120
        type: gp3
      securityGroups:
        - id: &{SG_ID}
      subnet:
        id: ${SUBNET_ID}
    type: AWS
  release:
    image: quay.io/openshift-release-dev/ocp-release:${VER}

Then either create a MachineConfig:
apiVersion: v1
kind: ConfigMap
metadata:
  name: test-machineconfig
  namespace: clusters
data:
  config: |
    apiVersion: machineconfiguration.openshift.io/v1
    kind: MachineConfig
    metadata:
      labels:
        machineconfiguration.openshift.io/role: worker
      name: 99-test
    spec:
      config:
        ignition:
          version: 3.2.0
        storage:
          files:
          - contents:
              source: data:,hello%20world%0A
            mode: 420
            overwrite: true
            path: /home/core/test

And edit your nodepool to include:
spec:
  config:
    - name: test-machineconfig

Or edit your nodepool's spec.release.image to a newer release.

Corresponding MCO PR: https://github.com/openshift/machine-config-operator/pull/3068

/retest-required

@yuqi-zhang  dropped some more nits, lgtm otherwise. We can merge and proceed with e2e testing after addressing those.

Ack, will do some fixups and squash commits. Thanks!

Addressed comments and added unit testing as requested. Lifting WIP but willing to additionally harden before merge.

/lgtm
/approve
/hold
@yuqi-zhang feel free to cancel.

Rebased, squashed, and re-tested

Thanks @yuqi-zhang!
/lgtm
/hold cancel

Thanks for all the helpful reviews!


fix: memory operations should be unaligned

Can confirm that unaligned mem ops fix this issue #61.
Ran old repro that was used to isolate the error and it works just fine with this patch:
https://github.com/0xDmtri/segfault-revmc-repro


Remove loadPlan call and verbose logging

Removed call for loadPlan in getQueryAnalyzersRevision as this will introduce cycling dependency for cluster and database features.
If plan is not loaded  - no revisions is assumed.
Removed verbose logging of missing vocbase case (for views/collections)  from ClusterInfo. That was proven useless for debugging and was just bloating logs
Backports required for: 3.7
This change is already covered by existing tests, such as arangosearch feature tests and cluster resilience tests
https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/11532/

Tests blue


[SPARK-13382][DOCS][PYSPARK] Update pyspark testing notes in build docs

What changes were proposed in this pull request?
The current build documents don't specify that for PySpark tests we need to include Hive in the assembly otherwise the ORC tests fail.
How was the this patch tested?
Manually built the docs locally. Ran the provided build command follow by the PySpark SQL tests.

Test build #51577 has started for PR 11278 at commit 59afdb6.

Test build #51577 has finished for PR 11278 at commit 59afdb6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51577/
Test PASSed.

Test build #52586 has started for PR 11278 at commit 36d1397.

Test build #52586 has finished for PR 11278 at commit 36d1397.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52586/
Test PASSed.

Merged build finished. Test PASSed.

Maybe @jkbradley could merge this? Super simple update.

This is going to be outdated soon, since there's ongoing effort to remove the need to build assemblies before running tests.

Ok - I can close this if we think thats going to be fixed soon (e.g. before the next release).

So looking at the PR which went in - it seems we don't need the assembly jar but we do need to explicitly build with package & hive support for the PySpark tests which isn't necessarily clear in the current docs so I think this remains a reasonable change - what are your thoughts @JoshRosen ?

Test build #55746 has started for PR 11278 at commit 0853b07.

Test build #55746 has finished for PR 11278 at commit 0853b07.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55746/
Test PASSed.

Merged build finished. Test PASSed.

re-ping @JoshRosen thoughts?

cc @markgrover who updated the building docs most recently, what are your thoughts?

Left some comments, overall, it's a change in the right direction. Thanks for working on this, @holdenk!

Test build #56268 has started for PR 11278 at commit 47045c2.

Test build #56268 has finished for PR 11278 at commit 47045c2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56268/
Test PASSed.

Merged build finished. Test PASSed.

Rad, wanted to make sure people were still up for adding a note about the hive requirement even though we got rid of the assembly requirement. I've changed it to just say built with hive and dropped the extra bits from the build argument (were there to match the rest of the build reference in the doc but for Python tests probably not relevant).

LGTM. +1 (non-binding)

Since we've branched for 2.0 would this maybe be a good time to merge this?

ping @jkbradley

ping @JoshRosen ?

If no one objects maybe @markgrover could just go ahead and merge this?

Would love to help, but I am not a committer:-)

Merging to master / 2.0.


Literal style objects

The way to create styles in OL3 is currently via multiple class constructors, for example:
new ol.style.Style({
    fill: new ol.style.Fill({
      color: 'rgba(255, 255, 255, 0.6)'
    }),
    stroke: new ol.style.Stroke({
      color: '#319FD3',
      width: 1
    })
});

The equivalent of the above in literal style would be:
{
  "fill": {
    "color": "rgba(255, 255, 255, 0.6)"
  },
  "stroke": {
    "color": "#319FD3",
    "width": 1
  }
}

Less verbose but the main reason for me is that it is acceptable as plain JSON. Similar literal styles could be supported for layers, sources etc. I already have some initial code supporting this as I wanted a way to represent a fully configured map in JSON.

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

+1 for this.
I'm storing styles for vector layers in a mongoDB collection so I'll found very helpfull to be able to parse JSON and automatically instanciate ol.style objects (including style for select etc...).
I understand that introducing literal objects can't be done everywhere but styling is maybe a particular case where more simplicity and readability would be helpfull.
In OL2 we have StyleMap including selected style etc... and it was great!
Here is a first modest draft to transform json style to OL objects at the application level (not fully tested yet). Feel free to improve/correct, I'll be interested.
function buildOlStyleFromJSON(obj) {
    for (var i in obj) {
        if(!obj[i])
          delete obj[i];
        if(i == 'stroke' && typeof obj[i] === 'object'){
          //Instantiate ol.style.Stroke
          obj[i] = new ol.style.Stroke(obj[i]);
        }else if(i == 'fill' && typeof obj[i] === 'object'){
          //Instantiate ol.style.Fill
          obj[i] = new ol.style.Fill(obj[i]);
        }else if(i == 'image' && typeof obj[i] === 'object'){
          //Instantiate ol.style.Circle recursively
          obj[i] = new ol.style.Circle(buildOlStyle(obj[i]));
        }else if(i == 'text' && typeof obj[i] === 'object'){
          //Instantiate ol.style.Text recursively
          obj[i] = new ol.style.Text(buildOlStyle(obj[i]));
        }else if(typeof node === 'object'){
          obj[i] = buildOlStyle(obj[i]);
        }
    }
    return obj;
};
var Style = new ol.style.Style( buildOlStyleFromJSON(JsonStyle));

We've discussed it already, but I honestly don't think this will happen anytime soon.

Closing due to lack of activity.

Hey, I know it's been a while since this issue came up but I made a thing:
import { loadStyle } from "ol-json-style";

const json = {
    "Style": {
        "fill": {
            "Fill": {
                "color": "red"
            }
        },
        "stroke": {
            "Stroke": {
                "color": "blue"
            }
        }
    }
}

const myStyle = loadStyle(json);

// You can then use it in a layer
const layer = new VectorLayer({
    source: mySource,
    style: myStyle,
});

It's my very first npm package so please be nice 😉


add "application/xml" to dictionary of drivers

Fix for #97

Thanks, can you add a small test for this?
And if you merge main and repush then the CI failures should be fixed.

Hi @TomAugspurger , sure! I have added a test based on the single-file STAC that was already in the repo, checking whether the media types for all assets are listed in the drivers dictionary. I have also thought it was a good idea to check whether all common media types listed in PySTAC are also listed among the drivers, and realised that image/tiff is actually missing. Should I add it to the dictionary as well (I guess with rasterio as driver)?

Thanks, that would be great. Either here or as a followup would be fine.

Thanks @fnattino!


Instance Mode

Hey!
I was in need of p5.grain for instance mode (wanted to render like 100 of my sketches at once on a page).
So, wrote this, hope you like it! Still seems to work with global mode.
Mostly all is the same except removing global shim, so probably a breaking change for anyone using it.

Hi there!
Thanks for your contribution! Having instance mode would definitely be awesome to have.
Since I would also like to implement JS module syntax, so required functions can be imported like so:
import { granulateChannels, tinkerPixels } from 'p5.grain';

I'll have to check how instance mode pertains to the module syntax.
Kinda busy atm but I'll have a look as soon as I can and I'm definitely considering this.

Sounds great! I needed it for myself, so built it, but figured would be useful for you. Feel free to take into the library at your own pace!

@campionfellin I finally had a chance to have a look at this and it looks great overall! Just fixed two small bugs.
However, having instance mode this way would complicate a little bit the syntax for offscreen graphic buffers:
Previous syntax:
pg.granulateSimple(42);

New syntax:
p5grain.granulateSimple(42, false, pg);

Previous syntax:
pg.tinkerPixels((index, total) => {
   // ...
});

New syntax:
p5grain.tinkerPixels((index, total) => {
    // ...
}, true, pg); // <-- shouldUpdate = true

All arguments have to be specified, since pg is the last argument.
That's why I've made some changes which makes instance mode possible and keeps the previous syntax, by keeping the code where p5grain methods were registered on p5.prototype and on p5.Graphics.prototype.
And instead of using instanceMode and instanceRef there is now one instance property. If it's set, then "instance mode is enabled".
I was also wondering whether a single pre-initialized p5grain instance, that can be used on multiple p5 instances, might suffice. 🤔
I've pushed the changes on this repositorie's campionfellin/main branch. Could you please pull and check whether this solution works for your use case? It it works for you, let's merge it to your fork's main branch, then I can merge it here.
I'm here, if you have any question and thanks again for your time and for implementing this!
I guess I'll be preparing a contributors section next 🤭

Hey hey! @meezwhite sorry I have not got a chance to try this yet. I ended up with a different route (not using instance mode anymore). Feel free to merge!