showAgentAvailability

Hi, I can't seem to get this working, has it been added? Will it be added? Is there a workaround for this? Thanks!

Hey! Sorry for the late reply. Unfortunately this can not be done at this point in time as it utilizes Phoneix Presence, which is not implemented on the package we are using for managing the connection.

https://github.com/papercups-io/papercups_flutter/issues/16

Update: Presence is now implemented on the library side, I'll work on this ASAP


Make colocations be compatible with DistributionStrategy in SyncReplicasOptimizer

This is a compatibility improvement related to DistributionStrategy.  The ops.colocate_with in 'SyncReplicasOptimizer' should be replaced with distribution.colocate_with_vars to support DistributionStrategy

Hi @yuefengz .
This is a small code change related to SyncReplicasOptimizer. Please check it.
Thanks.

Hi, @rmlarsen
These UT failures seem not related to me. Could you start it again?
Thanks.

Hi @rmlarsen @yuefengz ,
All CI test has passed. Could you please help review this PR? It has been pending for long time.
Thanks.

@wangsiyu Sorry for the delayed response. What is the use case for using SyncReplicaOptimizer with DistributionStrategy? You should be able to use a TensorFlow optimizer with DistributionStrategy without requiring to wrap it in a SyncReplicasOptimizer.

@anj-s Thank you for response. My use case is to use ParameterServerStrategy with sync mode between workers. So the SyncReplicasOptimizer should be inserted into the model to wrap the original optimizer. Is there any other way to use sync mode between workers in DistributionStrategy?

@wangsiyu I guess this should work but I am not sure @anj-s is planning anything for colocation. Also prefer to use CollectiveAllReduceStrategy for synchronous training.

@yuefengz CollectiveAllReduceStrategy  is in sync mode but it is not based on Parameter Server architecture. Sometimes the users pick ParameterServerStrategy for distributing the training variables across servers.

@wangsiyu We currently don't support sync mode with ParameterServerStrategy. It is definitely a use case that we want to support in the future but we are not actively working on it. We want to explore other solutions that don't depend on SyncReplicaOptimizer going forward.
Does the CollectiveAllReduceStrategy not work for your use case? What issues do you run into?

@anj-s This is because many businesses use sync mode based on Parameter Server architecture in Alibaba including CNN and Seq2Seq models. CNN may works well with CollectiveAllReduceStrategy  because we usually don't need to partition variables across different servers. However, some Seq2Seq tasks may involved with large variables but update in sparse.  Although async mode is also suitable for computation in this case but sync mode may be better for convergence.
You mentioned that you are not actively working on sync mode in PS strategy and will explore other solutions which is not depend on SyncReplicasOptimizer. Does it mean PS strategy will deprecat SyncReplicasOptimizer in the future? Why ? Is it because we cannot avoid modifying models code to wrap common optimizer？

This change looks good to me and we will have a better story for SyncReplicaOptimizer soon.

Nagging Assignee @rmlarsen: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


Extra visual debt

This is just an attempt to fix the type-hinting mess inside the library. This is a BC break, as inheritance may be broken if the child classes do not respect the parent class signature.
Also, I suggest removing all the scanner stuff before merging.

Originally posted by @Ocramius at https://github.com/zendframework/zend-code/pull/123

@Ocramius: I think that the scanners would profit from a refactoring. If they will get replaced eventually then there is no need for that.
Is the scanner stuff going to get deprecated? Replaced by what? nikic/PHP-Parser?
Thanks for any hint. :)

Originally posted by @fhein at https://github.com/zendframework/zend-code/pull/123#issuecomment-342328177

Is the scanner stuff going to get deprecated? Replaced by what? nikic/PHP-Parser?

https://github.com/Roave/BetterReflection

Originally posted by @Ocramius at https://github.com/zendframework/zend-code/pull/123#issuecomment-342386442

@fhein @Ocramius It would be nice to drop all scanners from this library too for 4.0, similarly to annotations, because roave/better-reflection or goaop/parser-reflection or even nikic/php-parser can handle this work separately, whereas this library will solve only one task: provide an API for source code generation.
Will prepare a separate PR for dropping scanners after rebasing and merging this one.

Originally posted by @lisachenko at https://github.com/zendframework/zend-code/pull/123#issuecomment-382381896

after rebasing and merging this one.

Dropping the scanners is probably a better idea for now.

Originally posted by @Ocramius at https://github.com/zendframework/zend-code/pull/123#issuecomment-382383085

Dropping the scanners is probably a better idea for now.

Ok, let me check if they could be easily dropped..

Originally posted by @lisachenko at https://github.com/zendframework/zend-code/pull/123#issuecomment-382384483

Dropping the scanners is probably a better idea for now.

I've checked some dependencies and this is short summary:

Whole Scanner namespace could be removed, there are only dependencies in Reflection namespace, eg. Zend\Code\Reflection\DocBlockReflection::reflect uses DocBlockScanner class, as well Zend\Code\Reflection\FileReflection::reflect uses CachingFileScanner. All remaining integration parts could be removed as they unused.
Classes from the Reflection namespace adds some public API to the PHP internal classes, thus Reflection namespace could not be easily dropped if we want to support *Generator::fromReflection() methods that accept only Zend\Code\Reflection classes and use specific methods from reflection.
If we decide to drop fromReflection() method from all generators or replace typehint in them with built-in PHP classes, then whole Scanner and Reflection namespace could be dropped, but it will be significant BC break as we remove all functionality that are not related directly to the code generation.

What is your vision about that?
I like the idea to drop both Scanner and Reflection namespaces from the code. Missing functionality will be covered by external reflection libraries. Make fromReflection methods accepts PHP's core classes instead of Zend's one, this will give quick way for integration via Reflection classes.

Originally posted by @lisachenko at https://github.com/zendframework/zend-code/pull/123#issuecomment-382443064

Whole Scanner namespace could be removed, there are only dependencies in Reflection namespace, eg. Zend\Code\Reflection\DocBlockReflection::reflect uses DocBlockScanner class, as well Zend\Code\Reflection\FileReflection::reflect uses CachingFileScanner. All remaining integration parts could be removed as they unused.

Yeah, this stuff can be dropped. At this point, pointing to roave/better-reflection for most of the "brute-forcing the filesystem, looking for symbols"

Classes from the Reflection namespace adds some public API to the PHP internal classes, thus Reflection namespace could not be easily dropped if we want to support *Generator::fromReflection() methods that accept only Zend\Code\Reflection classes and use specific methods from reflection.

Not sure about this one. I think the initial idea was that ext-reflection had huge potholes, and the library tried to fill them. I'd keep this for a separate issue, to figure out if the Zend\Code\Reflection namespace actually does anything more than ext-reflection these days. Considering that Zend\Code\Reflection is the entry point to all of the usages of this library (including the generators), I think that would make the migration path too painful at first.

If we decide to drop fromReflection() method from all generators or replace typehint in them with built-in PHP classes, then whole Scanner and Reflection namespace could be dropped, but it will be significant BC break as we remove all functionality that are not related directly to the code generation.

The ::fromReflection() constructors are extremely useful to mimick API without rewriting all of it manually, so I'd probably keep them in place. Instead, I think that allowing core reflection classes as parameters would be a better solution here.

I like the idea to drop both Scanner and Reflection namespaces from the code.

Let's start with the Scanner only for now.

Originally posted by @Ocramius at https://github.com/zendframework/zend-code/pull/123#issuecomment-382547482

Moved to #155 to separate issue discussion.

Originally posted by @lisachenko at https://github.com/zendframework/zend-code/pull/123#issuecomment-382702745

Closing here: most of the scanner is gone in #58, while #45 is tracking most of the work to be done to improve the library at type level.


Add random screen names to zk-transfer-web

Background
This task is part of a larger project to create an interactive web demo / playground for users to learn about zero-knowledge assets and gain intuition about them by directly transacting with the contracts on-chain.
Task Description and Examples
A static demo, created with react-scripts, not connected to the blockchain, is currently running on:
https://vigilant-wiles-4b7d39.netlify.com/
with source code in this directory:
https://github.com/invisible-college/democracy/tree/master/packages/zk-transfer-web
Your task has three parts:

restore any screen name from localStorage.
if none is found, add Docker-style random screennames to the auto-created Ethereum address for each user, save to localStorage

Restore Screenname from localStorage
In the path
localStorage.getItem(`demo/{demo.chainId}/thisScreenName`)

if it is non-null, should be the screen name from any previously stored session. Use this value to populate the screenname in the header (currently it's the static string "Jame Cameron")
The value of chainId can be read from the global symbol demo.chainId after await demo.clientInit() is called.
Random Screennames
If no previous screen name is found / restored in the previous section, a
a new random screen name should be generated, using this algorithm from the Docker random name generator
Then save this new screen name with
localStorage.setItem(`demo/${demo.chainId}/thisScreenName`)

There does not need to be any relationship between the screen name and the auto-created address. (That is, it's okay if the screen name gets erased, and the user gets a different random screen name for the same Ethereum address upon page refresh).
How to Work on This Task
Fork this repo. Clone and install Lerna bootstrap dependencies following the instructions on the main page:
https://github.com/invisible-college/democracy#get-the-source-code-to-experiment-and-run-tests
Make your changes in the zk-transfer-web package, and then you can auto-rebuild the page and serve it using react-scripts start or similar commands.
Host your work-in-progress on Netlify and post that link in this thread as you work for feedback, help, and collaboration. For Netlify you may find the following helpful:
Build commands
lerna bootstrap
cd packages/zk-transfer-web
react-scripts build

Build directory
packages/zk-transfer-web

Create a pull request against your forked repo (master branch) onto this repo (master branch), and commit and push your source code there as you work.
When it's ready, I'll merge from that PR onto the master branch, and ask you to turn over ownership of the Netlify instance to the Democracy.js team. Looking forward to working with you on this project.

Hey @cryptogoth I'm done with the feature just have one concern. The demo.clientInit() takes a quite seconds to return the chainId field. Which leaves the field empty until the clientId is received.

Great @mul53 can you post a link to a netlify instance showing your work, and also a link to your pull request?
It's true, wallet initialization takes a few seconds. Can you merge or rebase commits to the latest master, which I merged yesterday from @owonwo? He added a way not to block page rendering during clientInit, and then to update the wallet address after loading.
Let's discuss the code with a review, then I'll close the issue when I merge it.
Thank you
On Jan 14, 2020, 2:32 PM, at 2:32 PM, mul53<EMAIL_ADDRESS>wrote:

Hey @cryptogoth I'm done with the feature just have one concern. The
demo.clientInit() takes a quite seconds to return the chainId field.
Which leaves the field empty until the clientId is received.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/invisible-college/democracy/issues/43#issuecomment-574335368


The "Payment Pending..." item is not deleted after tapping the "Delete" button. Happens 1/3

Description
The "Payment Pending..." item is not deleted after tapping the "Delete" button. Happens 1/3
Precondition

Register a new account
The "Send" link is created
The main page is opened

Steps to reproduce

Swipe left the "Payment Pending..." item
Tap the "Delete" button
Pay attention to the "Feed" section
Reload the page
Pay attention to the screen

Actual result: The "Payment Pending..." item is not deleted after tapping the "Delete" button. Happens 1/3
Expected result: The "Payment Pending..." item is deleted after tapping the "Delete" button
Supporting data
Env https://goodqa.netlify.com
iPhone6 12.3.1, Safari
https://www.screencast.com/t/QYlyGT6dq

@qatests1001 this happened multiple times? and sometimes the payment is deleted and sometimes it isnt? the same item gets deleted the second or third time you try to delete it?

this happened multiple times? - Yes
and sometimes the payment is deleted and sometimes it isnt? - Yes
the same item gets deleted the second or third time you try to delete it? - It can be deleted on second or third time I try to delete it

feels like the document is not completely propagated/persisted/or something around that. Because it's marked as deleted, and the feed item is removed from the list due to the .on listener placed in Dashboard, but before the promises from the delete calls are resolved.
even if I wait for the promise to resolve, and refresh... the document will re-appear in the feed list.
@sirpy, may it be possible that the database didn't propagate properly and the changes are overwritten from remote nodes?

@fernandomg after its marked as deleted the record changes back to the previous value?

@fernandomg after its marked as deleted the record changes back to the previous value?
can you verify that by directly getting the feeditem record from gun?
userstorage.feed.get('byid')...
maybe its just the dashboard feed items that are not updated correctly.
what happens if you refresh the page? item is still in feed?

@sirpy, This happens if you refresh the page immediately after the feed item dissapears, as in the video

@fernandomg

check then the data of the feeditem in gundb directly like i've asked above, before refreshing the page and after refreshing the page. compare what fields have changed.
maybe it has something to do with blockchain events, maybe we get the tx event again and its added again to the feed?
follow the different console logs we have on that

@sirpy, update...

now, for some reason (latest changes in master? not sure) I'm not being able to reproduce the feedItem's status change.
this exposed a new issue related to this refresh-after-delete thing: as the "cancel payment"  process first calls to delete  the feedItem and after that calls to cancel the deposit, I we refresh before the_cancel_ call the feedItem will be removed from the feed list but the deposit won't be canceled
solution: instead of calling the cancel action, after deleting the feedItem we should reactively call the cancel for the deposit whenever we find a feedItem whose status === 'deleted' && type === 'send', what do you think?
regarding the status change deleted -> completed reported in this issue, I'll continue working to reproduce it, and fin the fix anyway.

@fernandomg lets do the delete once the cancel has a TX hash
we also delete once we get a receipt so i think we should be fine there

The issue doesn't reproduce on QA env


wxkg17lm

Can I get a dump of the firmware of the two key versions? Thank you.

I don't have the two-key device. If you dump the FW, I can add it to the repo.


s/Tipically/Typically

oh - didn't realize I wouldn't be able to merge this...

Why not? Is there something wrong with my fix?

Nah, something weird with my permissions.


update steps to tag branch/commit also. this allows easy reverts to …

…specific versions

Looks Good! 👍


Does Go BLE support Mac El Captain?

Hello,
Does Go BLE support Mac El Captain? I am looking for something similar to Bleno but using Go.
Thanks

Yes, it does. We leverage @raff' work for the OS X port. Checkout the
examples. They should work with both Linux and OS X.  The API are still
being tweaked every now and then. But we'll make sure the examples adapt
the changes and works.
On Sat, Aug 27, 2016, 07:21 Jeff Prestes<EMAIL_ADDRESS>wrote:

Hello,
Does Go BLE support Mac El Captain? I am looking for something similar to
Bleno but using Go.
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/currantlabs/ble/issues/10, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF8XCstYQCn_Izg_7UJax4ActfNiFjXks5qkEfbgaJpZM4JutHd
.

I can confirm that the current master branch scanner and explorer examples work in El Capitan. This issue can probably be closed now.


Add standard icon spacing classes

Doing an install also upgraded to bootstrap 3.3.7

Screenshots available at https://github.com/ComputerScienceHouse/conditional/pull/65

Thanks for making this change over here! I'm going to merge this as-is, but I do want this applied to navbar glyphicons automatically. If you have a moment to do that, that would be great; otherwise  I'll do it this weekend before I release v1.0.1.


Introduce a burn address for cdk_erigon

This PR closes #92.
This PR introduce a burn address BurnAddr when the cdk_erigon feature is activated. The BurnAddr receives the burnt fees when the feature is activated. This is achieved similarly to the fee payment for the sender: first, we add the maximum fee to the burn address, then we deduct the fee corresponding to the remaining gas.
For now, the default value (0x0) is set in the trace decoder.

@LindaGuiga If you merge latest develop the clippy errors will go away.

I'm good with this once rebased + revert the changes linked to macro -> global label post #492

@0xaatif will you review the latest changes following resolved discussions or defer to other code owners? (what your latest comment seems to imply)
Just to clarify so that @LindaGuiga knows what to do once last comments are addressed


plot_chiq does not work in Jupyter

@shellydkelly and I are testing the latest Github version of Larch in Jupyter Notebooks. We noticed a potential syntax error in plot_chiq(). It returned an error that

'kmin' is not defined.

We tried to fix it locally by adding kmax=None as one of the default kwargs in the plot_chiq() function.

@Cathyhjj OK, I'll look into that. Is that using the "plotly" version "plot_chiq" function?  If not, can you give a brief example?

Yes, it's using plotly:
from larch.plot.plotly_xafsplots import plot_chiq
plot_chiq(dgroup)
I just realized that I had a small typo before. kmin=None needs to be added as a default kwarg in the plot_chiq() function for this function to work.

@Cathyhjj  Thanks, yes that will fix it.  I added a similar fix to the development version of the code too.

Thank you! I'll close this issue.


Update bittorrent-sync.rb

The url is updated on the website

Thank you for the contribution. It needed some fixes, so they were made in 8a82164cc944d21154a40e5071f2e9c883daad40. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Makefile bundle-build incorrect path to bundle.Dockerfile

Bug Report
What did you do?
Run make bundle-build
What did you expect to see?
A bundle image created locally.
What did you see instead? Under which circumstances?
bundle.Dockerfile was not found
Environment
N/A
Possible Solution
Point at the correct file, located under target -
docker build -t $(BUNDLE_IMG) -f target/bundle/$(PACKAGE_NAME)/bundle.Dockerfile target/bundle/$(PACKAGE_NAME)

Add the following under src/main/resources/application.properties
quarkus.container-image.name=<package name>-controller
quarkus.operator-sdk.bundle.package-name=<package name>
quarkus.operator-sdk.bundle.channels=<channels>
quarkus.container-image.registry=<registry>
quarkus.container-image.group=<group or repo name>

Additional context
Sample Makefile - https://github.com/skattoju/simple-java-operator/blob/cleanup/Makefile#L91

cc: @skattoju

Hi @itroyano ,
thx we will take a look on it.
@metacosm this seems to me more like a QOSDK issue, maybe consider move it under that repo.

This is actually a multiple combination issue :)
The core issue is in fact in the operator-sdk plugin and this is actually something I've been working on lately to clean this up. I also need to adapt the container building instructions with respect to changes in Quarkus 3 as well.

Hi @metacosm thanks for taking a look at this!
There's a couple of gaps and I've only raised a single issue.
If you look at https://github.com/opdev/simple-java-operator/commit/905a6eaa1799218bbaaef5e5e15075fdf3c3b1c2
That's the diff vs. what has been generated by operator-sdk originally.
Many of these are optional / QoL stuff we added to our sample operator,  but some are actually mandatory to get an image build working,  and the docker-build make target doesn't do anything without them -

pom xml changes.
dockerfile.jvm (was not generated by sdk).
the bundle build mentioned in this issue.

In addition I've been trying - so far unsuccessfully - to get podman working instead of docker.  looks like only native profile supports passing a flag for an image build engine....  but then I get an out of memory 137 in the build (on a Mac).
the initial attempt can be seen here https://github.com/opdev/simple-java-operator/commit/800ed75ac928e3fdbd789f656f1ba9f91fbd7654#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52

/remove-lifecycle stale


"Get-ChildItem -Filter" is much slower in PowerShell 7 than in Windows PowerShell 5.1

Running
Get-ChildItem -LiteralPath <somedir> -Filter 'wontmatchanything*.txt'

(especially when the filter excludes all/most files) is much slower in PowerShell 7 than in Windows PowerShell 5.1:

Digging seems to reveal that the .NET Core API (invoked from PowerShell) would be the culprit, but I was unable to repro using raw C#:

Steps to reproduce

Extract the test harness from TestHarness.zip
edit the locations.json file to define the location of one or more test directories
populate the directories by running Populate.ps1
optionally, add/remove/change testcases by editing the testcases.json file
run RunTestCampaign.ps1

Results are output to results.csv.
Expected behavior
The performance of PowerShell 7 should be higher than Windows PowerShell 5.1, or at least on par with Windows PowerShell 5.1
Actual behavior
PowerShell 7 is way slower
Environment data
> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.0.1
PSEdition                      Core
GitCommitId                    7.0.1
OS                             Microsoft Windows 10.0.18363
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Yellow lines on second screenshot shows that it is .Net Core issue.
You could enhance your tests using enumerationOptions parameter in EnumerateFiles(string path, string searchPattern, System.IO.Enume rationOptions enumerationOptions)

That was also my line of thinking. But I wrote a C# program and couldn't show that difference between .NET Framework and .NET Core. Something wrong in that C# repro attempt?
What enumerationOptions would you suggest trying?

You could play with MatchType.
As for C#, you should measure with PerfView to see all call stack. Perhaps PowerShell force antivirus API.

EnumerateFiles(String, String, EnumerationOptions) is not supported under .NET Framework, so there's not much I can compare there.
I'm not sure I understand what you want me to profile.
The PowerShell test harness clearly reveals a performance difference between 5.1 and 7.0.
I can't repro a similar performance difference when calling EnumerateFiles(String, String) in .NET Framework 4.8 and .NET Core 3.1.
Maybe I could try using WPR on the PowerShell tests?

If you send me a private message, I can share the WPR capture off my OneDrive.


insert js code in SunEditor

function editPageContent() {
const editable = document.querySelectorAll(".sun-editor-editable");
editable.forEach((element) => {
let sg = document.createElement("script");
let sd = document.getElementsByTagName("script")[0];
sg.text = "alert(1111)";
sd.parentNode.insertBefore(sg, sd);
element.appendChild(sg);
});
}
editPageContent();
i made it from browser console
an alert(1) is not something serious,
but i think it is a kind of XSS

I think you can do that on literally any webpage, also for example github. Just grab a random element and do the same as above. All SunEditor can do (and should do and does) is to prevent

i have put the script tag in database using SunEditor and script i post above, not only display on page i make script execution from console.
So i have injected js code in SunEditor textarea and after this was sended request to server.

I'll modify the "getContents" method to check the HTML once again.
And I'll consider using MutationObserver later.

The 2.44.4 version has been updated.
Thank you.


ACS Commons bundle is not activate in stage environment.

Required Information
ACS Commons version 5.3.0
Expected Behavior
bundle should active in all environments.
Actual Behavior
I am trying to add ACS Commons using pom.xml, the bundle and packages of ACS commons is working fine on my local but when i am trying to add same dependency using same way in stage environment the state of bundle is in install state instead of active state.
i tried to reproduce the same issue on local by changing the state of ACS commons bundle as install and hit the URL http://localhost:4502/etc/acs-commons/exporters/exporter.html
i am getting the same error as reproduced in stage we have same exported.html available on stage environment.
Steps to Reproduce

install ACS commons package using pom.xml
change the state of bundle from system/console
http://localhost:4502/etc/acs-commons/exporters/exporter.html hit the URL.

What version of AEM are you running?
What is the status of the ACS AEM Commons bundle on in the OSGi console - the fact you have to start it manually tells me something is amiss.
Are you sure you have all the other packages installed? ui.apps, ui.content, etc?
Also, anything in the error logs? This very much sounds like an issue with your AEM rather than ACS Commons, but i could be wrong!

Hi @davidjgonzalez, kindly find my comments below as highlighted.
What version of AEM are you running? - AEM as a cloud
What is the status of the ACS AEM Commons bundle on in the OSGi console - the fact you have to start it manually tells me something is amiss. - On dev,  after inspect we found that getting 400 server bad request ( Cannot serve request to /etc/acs-commons/exporters/export/_jcr_content.init.json on this server ) error.
Note: We manually change the acs bundle state as installed to reproduce the issue in local environment. We got the same error in local as well after changed the state of the bundle.
Are you sure you have all the other packages installed? ui.apps, ui.content, etc? - Yes all the related acs packages are installed.
Also, anything in the error logs? This very much sounds like an issue with your AEM rather than ACS Commons, but i could be wrong! - Did not find any specific errors related to acs
The actual issue was that we could not able to access the miscadmin & create exporter pages. We are following the recommended approach in order to get the access for the same on higher environments.
below paths are not accessible on higher environments:
/etc/acs-commons/exporters/users-to-csv.html
/miscadmin#/etc/acs-commons/exporters
Approach that we have tried:
Updated pom.xml with the acs 5.3.0 dependencies & deployed.
Packages were installed & but couldn't able to find state of the bundle since we don't have access on dev & others.
Kindly let me know if anything else info is required.
Thank you

Hi @gowtami-betireddy
Did you check to see if the Bundles is in-fact stopped on AEM CS Author in the Stage env using the Developer Console > Bundles? https://experienceleague.adobe.com/docs/experience-manager-learn/cloud-service/debugging/debugging-aem-as-a-cloud-service/developer-console.html?lang=en#bundles
Or if you look through the Develop Console > Components .. and see if UsersInitServlet is unsatisfied, and if it is - why (it should tell you what in that is unsatisfied)
I tried 5.3.0 on latest AEM SDK  and the bundle starts automatically:


Mongoid support

In the strategies.rb file, my app won't run this gem because of the ActiveRecord line for Paperclip. Can you please alter this so that it recognizes Mongoid::Document as well?

have you figured out how to use this with mongoid

Are you planning to give mongoid support?


Crash after several Invoke calls on VBScriptEngine

Hi,
If you run the program below several times, you'll probably see that ~90% of processes crash silently on 6th engine.Invoke call, the rest throws an AccessViolationException  on 7th only if the previous (6th) was a CStr invocation, it never reach the 8th.
using System;
using System.Collections.Generic;
using System.Linq;
using Microsoft.ClearScript.Windows;

public class Program
{
    public static void Main()
    {
        using (var engine = new VBScriptEngine())
        {
            var random = new Random();
            var functions = new List<string>
            {
                "CDate", "CStr", "CDbl", "CSng", "CCur",
                "CLng", "CInt", "CByte", "CBool"
            };

            foreach (var (method, index) in functions.
                OrderBy(f => random.NextDouble()).Select((m, i) => (m, i + 1)))
            {
                Console.Write($"Call {index}: {method} is being invoked. ");
                engine.Invoke(method, "1");
                Console.WriteLine("Done.");
            }
        }
    }
}

2 typical outputs:
Silent crash:
>Program.exe
Call 1: CDate is being invoked. Done.
Call 2: CStr is being invoked. Done.
Call 3: CInt is being invoked. Done.
Call 4: CLng is being invoked. Done.
Call 5: CCur is being invoked. Done.
Call 6: CDbl is being invoked.

Crash with exception:
>Program.exe
Call 1: CInt is being invoked. Done.
Call 2: CByte is being invoked. Done.
Call 3: CLng is being invoked. Done.
Call 4: CDbl is being invoked. Done.
Call 5: CDate is being invoked. Done.
Call 6: CStr is being invoked. Done.
Call 7: CSng is being invoked.
Unhandled Exception: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
   at Microsoft.ClearScript.Util.COM.IDispatchEx.InvokeEx(Int32 dispid, Int32 lcid, DispatchFlags flags, DISPPARAMS& args, IntPtr pVarResult, EXCEPINFO& excepInfo, IServiceProvider svpCaller)
   at Microsoft.ClearScript.Util.COM.DispatchExHelpers.InvokeMethod(IDispatchEx dispatchEx, String name, Boolean ignoreCase, Object[] args)
   at Microsoft.ClearScript.Windows.WindowsScriptItem.<>c__DisplayClass20_0.<InvokeMethod>b__0()
   at Microsoft.ClearScript.Windows.WindowsScriptEngine.<>c__DisplayClass57_0`1.<ScriptInvoke>b__0()
   at Microsoft.ClearScript.ScriptEngine.ScriptInvokeInternal[T](Func`1 func)
   at Microsoft.ClearScript.ScriptEngine.ScriptInvoke[T](Func`1 func)
   at Microsoft.ClearScript.Windows.WindowsScriptEngine.ScriptInvoke[T](Func`1 func)
   at Microsoft.ClearScript.Windows.WindowsScriptItem.InvokeMethod(String name, Object[] args)
   at Microsoft.ClearScript.ScriptEngine.Invoke(String funcName, Object[] args)
   at Program.Main() in C:\<path>\Program.cs:line 23

Hi @skacurt,
Unfortunately these functions don't seem to support external invocation; that is, the only way to call them safely is from script code.
One thing you could do is invoke them from user-defined wrappers:
var wrappers = functions.Select(f => $"function my{f}(x):my{f}={f}(x):end function");
engine.Execute(string.Join(":", wrappers));

And then:
engine.Invoke("my" + method, "1");

We've tested this with up to 100,000 iterations and encountered no issues.
Good luck!

Unfortunately these functions don't seem to support external invocation; that is, the only way to call them safely is from script code.

Then I can live with that. Thanks!


High CPU causes cluster failures but no node eviction

The AWS S3 upload step of our backup scripts is getting caught in some loop, spiking CPU through the roof, and rendering a node mostly inoperable. This has caused several outages across multiple clusters.
This has several unfortunate side effects:

The failure is below the threshold of AWS's auto-termination (preventing the issue from autohealing)
The high CPU usage renders the node unavailable to SSH for diagnostic purposes
The node is still semi-functional, so it is still participating in the overall Flynn cluster.

 However, Flynn doesn't evict the node even though its involvement is bringing down the other nodes; in one case, a long enough outage resulted in a cluster which could not recover at all, even after the offending node was removed.
@josephglanville worked with me to debug this, and can describe some of how the failures looked from within Flynn.

Is there a reasonable way to detect this? If the flynn-host and discoverd APIs are operating, then I'm not sure what we can do. If they aren't, it will look like a network partition and our failure logic will kick in.

I don't know. I was hoping @josephglanville would comment more with what the failures looked like inside Flynn. At this point, I suspect he may lack the context to do so meaningfully.
The trigger of this problem has been resolved, so I suppose we can close this for now. However, it's still a danger, as far as I'm concerned, anytime a process outside Flynn starts overconsuming resources.


[R-package] pass R-configured compiler flags to checks in configure

Investigating #4131 , I've been re-reading the section of "Writing R Extensions" that discusses configure scripts.
I believe the R package's current configure script is not currently following some of that manual's advice. When it does configure tests (e.g. to check for an included mm_malloc), it isn't passing through the compiler flags that R will use when compiling lib_lightgbm.

You will very likely need to ensure that the same C compiler and compiler flags are used in the configure tests as when compiling R or your package

You can use R CMD config to get the value of the basic configuration variables... If you do, it is essential that you use both the command and the appropriate flags, so that for example CC must always be used with CFLAGS

Packages written with C++ need to pick up the details for the C++ compiler and switch the current language to C++

This PR ensures that the relevant flags are passed through to those checks.

/gha run r-solaris

/gha run r-valgrind

/gha run r-solaris

/gha run r-solaris

/gha run r-valgrind

Ah I forgot, valgrind tests here will fail until we merge #4504 (https://github.com/microsoft/LightGBM/pull/4504#issuecomment-896442336).
I'll just add {Matrix} here as well (only for the valgrind test) so this PR can be tested without waiting on #4504 to be merge.

/gha run r-valgrind

triggering new valgrind and solaris checks now that I've merged #4504 into master and master into this branch

/gha run r-valgrind

/gha run r-solaris

/gha run r-valgrind

/gha run r-solaris

QEMU build hit the 3-hour timeout
https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=10728&view=results

Here's how far it made it through the tests:
Successfully installed lightgbm-<IP_ADDRESS>
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
============================= test session starts ==============================
platform linux -- Python 3.9.6, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /LightGBM
collected 618 items

../tests/c_api_test/test_.py ..                                          [  0%]
../tests/python_package_test/test_basic.py ............................. [  5%]
......................                                                   [  8%]
../tests/python_package_test/test_consistency.py ......                  [  9%]
../tests/python_package_test/test_dask.py .............................. [ 14%]
........................................................................ [ 26%]
........................................................................ [ 37%]
......s...............s...............s...............s................. [ 49%]
##[error]The operation was canceled.
Finishing: Setup and run tests

I'm going to re-run it.

Here's how far it made it through the tests:

Just 49%? 😨


FE: Add tooltips to Top-Bar action buttons

Requirements

Top-Bar buttons must contain tooltip with a hint indicating their action.
Affected icons:

[ ] Collapse SideBar
[ ] Show SideBar
[ ] Mark read
[ ] Mark unread
[ ] Delete
[ ] Quick Filters
[ ] Return to list
[ ] Reply all
[ ] Forward

Created by

#214

Hi Marc,
Your BrowserStack account registered to @.** is now active for testing, till 27th Mar, 2020.
Your sponsored plan details are:
Automate Mobile x 5 Parallel Tests (Up to 5 Users) [New]
If you need any help getting started or inviting your team members to BrowserStack, reply to this email and we will be in touch.
Happy Testing!
The BrowserStack Team
www.browserstack.com

Hi Marc,
Welcome to BrowserStack's Open Source community!
I have activated your sponsored subscription for 1 year. You now have full access to our paid products and benefits. On 27th of March, 2020, we will review and renew your subscription.
Happy testing!
Regards,

add labels in compose view to please
There button looks like Trash bin (delete draft & back to mail-list button)

in right bottom corner

Hints should be available in all TopBar elements, QA is not completed yet, but you should be able to see them.


Feedback form - strengthening messaging about personal information

Updating the feedback purpose to strengthen the messaging about people not providing personal information like name and date of birth
Trello card https://trello.com/c/2n8WjmWN
Context
Changes proposed in this pull request
Guidance to review

@GayeCord For some reason, this has failed to build (not sure why) - to discuss on Monday


fix broken link

Fixes https://github.com/MicrosoftDocs/feedback/issues/2071

@mairaw : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Link fixes confirmed. Thanks.


AIM2 metrics integration

Hi,
Is it possible to launch the backend server with the AIM2 metrics?

The backend server and the old metrics are implemented in Python 2. The new AIM2 metrics are implemented in Python 3.
The plan is to first revise and update all the old metrics, after which we will update the backend server to be compatible with them and Python 3.

Please, see the "aim2" branch which as of now includes a refactored codebase (incl. the web application) and the AIM2 metrics published earlier last year.


[7/n] @next/font/google: Add font weight, style to css and js properties

This adds font-weight, font-style, and a fallback font both to the css styled by the exported className as well as to the exported style object.
Test Plan:
Given const inter = Inter({weight: "500", fallback: ["Arial"]});, verified the following css properties were generated and the following js was exported:
.className◽\[project-with-next\]... {
    font-family: 'Inter', 'Arial';
    font-weight: 500;
    font-style: normal;
}

{
  className: ".className◽\[project-with-next\]...",
  style: {
    "fontFamily": "'Inter', 'Arial'",
    "fontWeight": 500,
    "fontStyle": "normal"
  }
}

Current dependencies on/for this PR:

main

PR #2963   👈

PR #2964

This comment was auto-generated by Graphite.


Fix finder preview window size issues

Fixes #204 and #190

What's the status on this PR?

hmm I will check in next weekend because I am in hospital
--------------原始邮件--------------
发件人："sieuwerts @.>;
发送时间：2021年6月17日(星期四) 晚上7:08
收件人："glepnir/lspsaga.nvim" @.>;
抄送："Subscribed @.***>;
主题：Re: [glepnir/lspsaga.nvim] Fix finder preview window size issues (#207)
What's the status on this PR?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

hmm I will check in next weekend because I am in hospital
Don't stress it, feel better first. 👍

@glepnir Oh no, I hope you're doing ok. Get well soon!

hmm I will check in next weekend because I am in hospital

😢 hope you are okay.

For anyone else that stumbles upon this issue and wants a temporary solution while waiting for @glepnir to get a chance to review (hopefully you're doing well), you can temporarily replace your plugin line with this:
Plug 'jasonrhansen/lspsaga.nvim', {'branch': 'finder-preview-fixes'}
Then remember to PlugClean and PlugInstall.
I've confirmed that @jasonrhansen 's fix does work correctly, and it's currently not behind master at all. Once @glepnir finds the time to review, obviously replace it back with the regular path.

Thanks

This patch works well for me; prior to using this branch, the preview window was very small and almost unusable. This seems to fix things and the code looks good.

can confirm too, works as expected now
if anybody is using Packer:
  -- use 'glepnir/lspsaga.nvim'
  use {'jasonrhansen/lspsaga.nvim', branch = 'finder-preview-fixes'}

as temp fix
Get well soon @glepnir all the best

Till @glepnir  go back, there's a temporary repo for hotfixes https://github.com/tami5/lspsaga.nvim.


homework_1 done.

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
add an image of the table.
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

HW1 marked.

HW2 marked.

HW 3, 4, 5 marked and HW6 is missing.


Modified package.json to use shorter repository location syntax

Like mentioned in the npm package.json specification here:
For GitHub, GitHub gist, Bitbucket, or GitLab repositories you can use the same shortcut syntax you use for npm install
This also resolves a problem when installing via CITGM.

This also resolves a problem when installing via CITGM.

What's the issue there? I'm curious to know what problem we're solving.
Otherwise, I can't imagine why we'd want to have a less specific repository setting (the URL is pretty specific, and by definition, "universal")

CITGM explicitly looks for repository.url, so while I think CITGM will still work after this change I want to point out that any CITGM failures will be unrelated to this change
https://github.com/nodejs/citgm/blob/master/lib/lookup.js#L46

Closing because the comments above suggest that this is unnecessary.


yesplaymusic: drop

It seems like YesPlayMusic has been effectively abandoned upstream with numerous usability and API bugs preventing it from working, while using old, unsupported Node versions (14 and 16) and Electron versions (22).
While there have been forks and projects created in its image (see https://github.com/qier222/YesPlayMusic/issues/2344), it would be better if we drop YesPlayMusic first, and package any fork that manages to garner enough momentum.
Part of #296939

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Cc @LostAttractor as maintainer

Cc @LostAttractor as maintainer

I’m not using this for a long time. If anyone still want to use this.
Try packaging this: https://github.com/stark81/my_yesplaymusic


Replace references to nix run with nix shell

This replaces references references to nix run (from Nix 2.3) to nix shell (used from Nix 2.4 and later).

@OpsBotPrime merge

Pull request approved for merge by @Riscky, rebasing now.

Rebased as cd6c2da6edc15a5dd92be7cbdf55bc1739db4892, waiting for CI …

CI job :yellow_circle: started.


Prevent margin-bottom on vertical button groups

This will override the margin-bottom on labels when they're in a vertical button group.
Fixes #20298

Fixed in #20827.


fix: ignore error messages from all error types

This PR targets the branch of https://github.com/turbot/steampipe-plugin-gcp/pull/476 to allow ignoring error messages from more APIs (e.g. Redis).
See https://github.com/turbot/steampipe-plugin-gcp/pull/476#discussion_r1866266030

Thanks @ParthaI, done!


Change the colour scheme based on temperature / weather type

Change the websites appearance to match the weather conditions. The Apple Weather app has some cool examples in iOS 15, check them out here.

I would like to work on this issue

Group 3 working on this


Chrome is crashing while trying to select a file

Hi,
I´ve googled for a while now, but I can´t find any solution for my problem. I just try to upload rather small files... <1 MB and I am using angular-file-upload. As soon as I hit the "Select files"-Button in Chrome, it opens the file dialog and then crashs. That does not happen everytime, but at least to often.
I can reproduce the crashs if I go and click quite fast on this button right after the page has been loaded.
Does anyone else experience this problem? I´ve tried Firefox and it´s just working. It looks like it´s just Chrome.
Hope you can help,
Patrick

RAM?

Hmm,
I don´t think so. Actually my laptop has about 8GBs of RAM and the upload file is 300kb. That should fit into my memory.
Any other ideas?

Ok, Do you have any extension? I have problems with Dropbox extension, it crash my chrome. Try again in private navigation.

Hmm.. I´ve tried private navigation... looks like my problem.

If you figure out which extension causes that problem please post it here for other people to know.


Production build breaks code that works in development

import React from "react"

export default class App extends React.Component {
  render() {
    return (

Parent

        <AppItem />

    )
  }
}

const AppItem = () => {
    return
child

}

Works with npm start
Breaks with npm build, giving Element type is invalid error
If you rearrange the code so that AppItem is defined before App (or you use a hoisted function declaration) it works in both environments.
I suspect this has something to do with the react inline elements transformer?

It seems to be because of babel-plugin-transform-react-constant-elements

@hzoo Does this look like a Babel bug to you? Worth filing an issue?

Yeah seems like it, can look at it later - looks like https://phabricator.babeljs.io/T6878, https://phabricator.babeljs.io/T7126

I can fix this.

I fixed this. babel/babel#3596

🐈

PR merged. I guess this can be closed.

We pin versions so I’d like to leave it open for posterity until we pin to the version fixing this.

The fix is in a transitive dependecy so users will get the updated version regardless and you have no version to update as it's not a direct dependency.

We use bundledDependencies, I’m not sure whether this complicates the issue or not..

Seems like having to watch your deps more closely and releasing more often to get dep fixes out might be an implicit tradeoff for the single download and version stability from deduping and bundling all your deps:
<EMAIL_ADDRESS>

Released v6.12.0 with this fix https://github.com/babel/babel/releases/tag/v6.12.0 (and like @kittens said it's a fix in the babel-traverse pkg)

Thank you so much! I’ll be using these for next release.
Since we can’t pin a transitive anyway (lol I don’t know npm), I’m closing.

This should be fixed in latest alpha. Please give it a try and let us know. https://github.com/facebookincubator/create-react-app/pull/190


Add the possibility to filter the get command with the go text/template package

Codecov Report
Attention: Patch coverage is 0% with 133 lines in your changes are missing coverage. Please review.

Project coverage is 29.29%. Comparing base (c1172a3) to head (b3863cf).

Files
Patch %
Lines

pkg/ovp8xx/portinfo.go
0.00%
44 Missing :warning:

cmd/ovp8xx/cmd/get.go
0.00%
36 Missing :warning:

cmd/ovp8xx/cmd/ports.go
0.00%
26 Missing :warning:

internal/versioninfo/version.go
0.00%
18 Missing :warning:

cmd/ovp8xx/ovp8xx.go
0.00%
8 Missing :warning:

cmd/ovp8xx/cmd/root.go
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##               v2      #13      +/-   ##
==========================================
- Coverage   33.83%   29.29%   -4.55%
==========================================
  Files          19       22       +3
  Lines         857      990     +133
==========================================
  Hits          290      290
- Misses        566      699     +133
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: wireup foxPage OtherOpportunites

Description
Wire up of the <OtherOpportunities /> component. This:

wires up the component as app code
adds a new useOtherOpportunities hook, responsible for rendering static opportunities, with injected APR data from useLpApr, useFarmingApr and useFoxyApr hooks
adds missing descriptions for both FOX and FOXy opportunities, and consume them programmatically depending on the currently selected asset
adds missing key props in various mapped over components
moves common dependencies from src/plugins/foxPage/constants.ts to src/plugins/foxPage/FoxCommon.tsx, which has been renamed to src/plugins/foxPage/FoxCommon.ts since it has no JSX in it, thus doesn't need this extension

since this change requires imports to be updated across a few modules, renames FoxAssetId and FoxyAssetId to FOX_ASSET_ID and FOXY_ASSET_ID along the way

Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
closes https://github.com/shapeshift/web/issues/1834
Risk
None that I can see, this is a new domain. CSP entry is already present.
Testing

Go to Fox Page
The opportunities should be shown for FOX, matching the ones in https://fox.shapeshift.com/fox-farming minus the oneFOX ones
The ElasticSwap opportunity should be displayed for FOXy
APRs should be displayed for all FOX opportunities, matching the ones in https://fox.shapeshift.com/fox-farming
ElasticSwap APR should show --
Links should be working, routing to the right external opportunity

Screenshots (if applicable)
FOX

FOXy

@shapeshift/product Can we get a quick review of the screenshots? The mockups are a bit inconsistent with usages of Protocol name vs. Pool name V<version>, and same goes for the icons (pool icons vs. protocol icon).
Tried to keep it as consistent as possible with Fox Farming, as well as the mocks, LMK if there's any change needed here!


String deserialization broken in 1.5.0

String deserialization appears to be broken in version 1.5.0 if I set the value to a JSON object. It will deserialize successfully even though the value is not a string.
I have a class like this:
@JsonObject("ClientLogMessage")
export class ClientLogMessage extends LogMessage {
    @JsonProperty("code", String)
    @Validator.IsNotEmpty()
    @Validator.IsString()
    public code: string = undefined;
}

In a unit test, I set testData.code = { name: "code" } and call converter.deserializeObject(testData, ClientLogMessage);. In 1.4.1, it throws an error as expected. In 1.5.0, it does not and results in code being set as the JSON object.

Thank you again for this issue.
This was a tricky one because no test existed and it is a rare error. Usually, we just have bad primitive types and not completely different types.
A fix will be published to NPM in the next minutes.

@andreas-aeschlimann Happy to help! Thank you for the quick fix!


Exec not working

My guess is that the command is not passed as a string so bash just runs "docker"

yes i am facing same issue


Let undeclared build service usage nag point to the upgrade guide

Followup to #19342

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test and merge

OK, I've already triggered a build for you.

Your PR is queued. See the queue page for details.

@bot-gradle test and merge

Pre-tested commit build failed.

OK, I've already triggered a build for you.


x/tools/gopls: incremental gopls scaling

Incremental gopls
This is an umbrella issue to track the work we've been doing to change the way gopls scales (and significantly reduce memory usage and CPU on large codebases). We've been working off an internal design, but I wanted to share some of that here and have a public issue to track the work.
The main goal of this project is to use on-disk export data and indexing to allow gopls to persist data across sessions, reloading on-demand, thereby reducing its overall memory footprint and startup time.
As a result of this change, gopls memory usage (at least related to package information) will be O(open packages), rather than O(workspace). Furthermore, we will break global relationships between elements of gopls' cache, simplifying gopls' execution model and eliminating multiple categories of bugs.
Background
Gopls, as it very recently existed, was a monolithic build system. Certain algorithms relied on a global package graph containing the full set of workspace packages. For example, to find references to a given identifier, gopls simply walked all packages in the reverse transitive cone of the declaring package(s) and checked types.Info.Uses for references to the declared object. In order for this algorithm to be correct and sufficiently fast, gopls must hold all type-checked packages in memory (including many redundant intermediate test variants!).
We can't solve gopls' scaling problems until we rewrite these algorithms and fix all the places where gopls makes assumptions of global identity. This is what we've been working on.
High level plan

[x] Design a shallow export data format that does not bundle its transitive closure.
[x] Add a mechanism for on-disk caching.
[x] Implement package analysis using export data.
[x] Rewrite workspace-wide queries to use indexes that are independent of types.Package or types.Object identity.

[x] workspace symbols
[x] references
[x] call hierarchy
[x] implementations
[x] rename (may require re-implementing types.Identical and types.AssignableTo with a new notion of object identity, c.f. #57497)
[x] Unimported completion

[x] Separate the concept of a "syntax package" (something containing AST and types.Info) from an "export package" (a types.Package with type information for exported symbols). Syntax packages are used to fully understand the syntax a user is working on.  Export packages are used for type checking. Currently, gopls has a concept of "exported parse mode", which produces a syntax package on a truncated AST. This exists to reduce memory, but means that syntax packages may be partial, a source of many historical and current bugs.  All current uses of partial packages in the package graph can (and must) be eliminated or replaced with a judicious use of parsing or type-checking on-demand.
[x] Create a control plane to manage package information that must be preserved in memory vs re-computed on demand or transiently cached.
[x] When importing during type-checking, use export packages for packages outside the workspace. For now, continue to produce syntax packages for all packages inside the workspace.
[x] Persist and load export packages from disk.
[x] Load xrefs and methodset indexes from disk, rather than hanging them off of syntax packages.
[x] Drop all syntax packages, except those with open files.
[ ] Implement precise pruning
[ ] Investigate holding on to packages imported by open packages, to reduce re-type-checking latency.
[ ] Revisit diagnostic storage and retrieval: diagnostics are re-accessed in multiple places, assuming they will be free to retrieve: fix TestBadlyVersionedModule
[ ] Improve the UX around indexing (better progress notifications, partial results, etc).

Using gopls@master I noticed that diagnostics are updated with a significant delay in comparison with<EMAIL_ADDRESS>And this delay is the same for both small and large projects.
I managed to find a CL that introduced this behavior. Is is https://go.dev/cl/477979 (gopls/internal/lsp: reorder the way we compute diagnostics):

gopls@83c1ba19d (before the CL)
gopls@d52bc5689 (after the CL)

I would like to ask, is it an intended behavior? For me this delay looks like a performance issue.

@ShoshinNikita this is unintended.
We set the diagnostics delay to a higher number, and I think that made it more apparent that certain type-checking errors are not getting published immediately for the recently changed file.
The intended behavior is that you get diagnostics immediately for the file you are editing.
I can reproduce.


Clamp scrollOffset to prevent textfield bouncing

Fixes https://github.com/flutter/flutter/issues/38417 and https://github.com/flutter/flutter/issues/37377
This PR clamps the scrollOffset between 0 and the height of the paragraph to prevent overscrolling while typing.

It is unclear to me how I can repro the exact conditions in a test, since it is font/language/device/platform/timing dependent.

Looks like the height of the paragraph isn't quite what I need to clamp by to prevent this on the bottom edge. The top edge is fixed by clamping to zero though.

Need to clamp to height of the text minus height of the field.

This new version should clamp properly for both the top and bottom. Adding tests.

That fixed it for me, thanks!  I'll give this a final review when you finish the tests.

@justinmc Should be ready for review!


generate a csv of features supported across all models

execute as bin/rails r tools/feature_support_matrix.rb
A sample Google Docs output is here

Model
Associate a Floating IP
Basic control operations
CloudTenant mapping
Deletion
Disassociate a Floating IP
Discovery of Managers for a Provider
Evacuation
Query for events
Launch Cockpit UI
Live Migration
Migration
Provisioning
Reconfiguration
Regions of a Provider
Resizing
Retirement
Smartstate Analaysis

VmOrTemplate

x

Vm

x

x

x

x

ManageIQ::Providers::InfraManager::Vm

x

x

x

x

ManageIQ::Providers::Vmware::InfraManager::Vm

x

x

x

x
x

ManageIQ::Providers::Redhat::InfraManager::Vm

x

x

x
x

ManageIQ::Providers::Microsoft::InfraManager::Vm

x

x

x
x

VmXen

x

x

x

x

ManageIQ::Providers::CloudManager::Vm

x

x

x

x

ManageIQ::Providers::Openstack::CloudManager::Vm
x
x

x

x

x
x

x
x
x

ManageIQ::Providers::Google::CloudManager::Vm

x

x

x

x

ManageIQ::Providers::Amazon::CloudManager::Vm

x

x

x

x

ManageIQ::Providers::Vmware::CloudManager::Vm

x

x

x

x

ManageIQ::Providers::Azure::CloudManager::Vm

x

x

x

x
x

VmServer

x

x

x

x

MiqTemplate

x

ManageIQ::Providers::InfraManager::Template

x

ManageIQ::Providers::Openstack::InfraManager::Template

x

x

ManageIQ::Providers::Vmware::InfraManager::Template

x

x

x

ManageIQ::Providers::Redhat::InfraManager::Template

x

x

x

ManageIQ::Providers::Microsoft::InfraManager::Template

x

x

TemplateXen

x

ManageIQ::Providers::CloudManager::Template

x

ManageIQ::Providers::Openstack::CloudManager::Template

x

x

x

ManageIQ::Providers::Google::CloudManager::Template

x

x

ManageIQ::Providers::Amazon::CloudManager::Template

x

x

ManageIQ::Providers::Vmware::CloudManager::Template

x

ManageIQ::Providers::Azure::CloudManager::Template

x

x

x

Service

x

ServiceOrchestration

x

ServiceAnsibleTower

x

ManageIQ::Providers::Vmware::InfraManager

x

x

ManageIQ::Providers::Redhat::InfraManager

x

ManageIQ::Providers::Microsoft::InfraManager

x

ManageIQ::Providers::Openstack::CloudManager

x

x

ManageIQ::Providers::Google::CloudManager

x

x

ManageIQ::Providers::Amazon::CloudManager

x

x

x

ManageIQ::Providers::Azure::CloudManager

x

x

x

@miq-bot assign blomquisg
@miq-bot add_label pluggable providers
cc @jameswnl @gauravaradhye

/cc @mfeifer

❤

@durandom Can you reword the commit message to say ruby instead of bin/rails runner?  I already updated the description of the PR but the commit is still lying.  Note, bin/rails runner still works but is not very friendly.


unknown type name 'stack_t' in suse sle_11 SP3

when i am trying to build corert on suse sle_11 sp3  it gives following error

/usr/include/sys/ucontext.h:137:5: error: unknown type name 'stack_t'
stack_t uc_stack;"

error log is attached
CMakeError.txt

More details from gitter: Fixed in coreclr under this ticket dotnet/coreclr#514 and the fix is available in corert as well but the issue remain same.
cc @janvorli

For the older versions of glibc than glibc 2.20 ( 2.11.3 is the glibc version building for ) adding  feature test macro _BSD_SOURCE worked,

@RimashMohomed You are welcome to submit PR with the proposed fix.

PR submitted https://github.com/dotnet/corert/pull/1927


Using template literals in assets path are not replaced with the finger printed checksum.

Using string literals in asset path is not replacing the finger printed value because string literal expressions are not captured in the regex.
Example -
   `${this.get('assetPath')}/images/asset.png`  // this has no effect
   this.get('assetPath') + '/images/asset.png'  // this works

I am getting this too, (I've worked around it the same way that you have).
I was wondering if it's because this library is only intended for HTML/CSS/HBS and not JS?
e.g. This comment doesn't mention JS files: https://github.com/rickharrison/broccoli-asset-rewrite/blob/8cb5062189939d03b1f238eb95e61e7dbd45e9fe/index.js#L94
@rickharrison Is this library intended to replace paths in JS files, too?
Also, is this library actively taking changes at the moment? (I've seen some other comments about trying to have maintenance moved to the Ember team). If so I might try to put up a PR for the change + tests. (Time permitting)

Yes, it was intended to replace most paths in js files as well.
Most of the ember team already had commit/publish access to the repos. Let me know if I need to add anyone else!

Thanks for the quick response, Rick!
Okay, thanks. Well I'll have a dig in and see what I can come up with.
Cheers,

I got hit by this today trying to drop support for IE11 😅 I just stumbled upon this open issue after opening a similar one over at broccoli-asset-rev.
@rwjblue @dnahodil is there any chance we could get the PR in https://github.com/ember-cli/broccoli-asset-rewrite/pull/73 merged?


Cache panel: monkey-patch caches at module level

Fixes https://github.com/django-debug-toolbar/django-debug-toolbar/issues/799.

It's not early enough for celery though: it will have a different caches instance.

Can you add a test to verify the fix for #799 to avoid regressions in the future?

@tim-schilling
Won't be easy probably, and I'm not sure if it's the right thing to do here.

This should probably be closed in favor of #982?


Ensure index.html is gzipped when deployed.

This updates to store the index.html as gzipped content in S3 and adds the Content-Encoding: gzip header. This was already being handled properly by the ember-deploy-s3 adapter that is used for assets.
This brings the index.html payload from 4.5KB to 2.0KB.
Closes #273.

:+1:  Nice!

This is awesome @rwjblue !


Attributes of nuisance functions

Is it possible to access the attributes of the nuisance functions? For example, if the nuisance function is a RandomForestRegressor, then the sklearn package allows one to access the attributes such as estimators_, feature_importances_ etc. Attributes like feature_importances_ can perhaps help identify the confounding variables in the model.

The current version of DoubleML allows to save models trained during the crossfitting.
This small example shows how to access models.
import numpy as np
import doubleml as dml
from doubleml.datasets import make_plr_CCDDHNR2018
from sklearn.ensemble import RandomForestRegressor
from sklearn.base import clone

learner = RandomForestRegressor(n_estimators=100, max_features=20, max_depth=5, min_samples_leaf=2)

ml_l = clone(learner)
ml_m = clone(learner)

np.random.seed(42)
data = make_plr_CCDDHNR2018(alpha=0.5, n_obs=500, dim_x=20, return_type='DataFrame')

obj_dml_data = dml.DoubleMLData(data, 'y', 'd')
dml_plr_obj = dml.DoubleMLPLR(obj_dml_data, ml_l, ml_m)

dml_plr_obj.fit(store_models=True)

dml_plr_obj.models

This results in the following output
{'ml_l': {'d': [[RandomForestRegressor(max_depth=5, max_features=20, min_samples_leaf=2),
    RandomForestRegressor(max_depth=5, max_features=20, min_samples_leaf=2),
    RandomForestRegressor(max_depth=5, max_features=20, min_samples_leaf=2),
    RandomForestRegressor(max_depth=5, max_features=20, min_samples_leaf=2),
    RandomForestRegressor(max_depth=5, max_features=20, min_samples_leaf=2)]]},
 'ml_m': {'d': [[RandomForestRegressor(max_depth=5, max_features=20, min_samples_leaf=2),
    RandomForestRegressor(max_depth=5, max_features=20, min_samples_leaf=2),
    RandomForestRegressor(max_depth=5, max_features=20, min_samples_leaf=2),
    RandomForestRegressor(max_depth=5, max_features=20, min_samples_leaf=2),
    RandomForestRegressor(max_depth=5, max_features=20, min_samples_leaf=2)]]}}

Remark that this estimation does include a lot of different models such that e.g. feature_importances_ can be accessed via
dml_plr_obj.models['ml_l']['d'][0][0].feature_importances_

where one has to specify the learner ml_m, the treatment d, the repetition index (only relevant if n_rep is greater than 1 ) and the fold index.
Output:
array([0.61409976, 0.02077143, 0.04488945, 0.01676835, 0.01991063,
       0.03105536, 0.02633215, 0.02430967, 0.01446739, 0.01645629,
       0.01145071, 0.02729037, 0.01306299, 0.02018805, 0.02620404,
       0.01579891, 0.01091846, 0.01715312, 0.01666732, 0.01220554])

I hope this clarifies how to access attributes of the fitted models.


chore: require changeset or label

What/Why/How?
Not every PR requires a changeset. However, when working on a feature (especially a big one), it's easy to forget to add one in the end. This PR aims to eliminate the need to review if there's a changeset by failing an action if there are actual code changes unless the  'No Changeset Needed' label was explicitly set. This will help us avoid missing required changesets.
Reference
https://github.com/changesets/changesets/blob/main/packages/cli/README.md#status
Testing
Tested on this PR. Needs further testing on a release PR after merging.
Screenshots (optional)

Has code been changed?

[ ] Tested with redoc/reference-docs/workflows (internal)
[ ] All new/updated code is covered with tests

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

I hope you don't mind

@lornajane not at all, thank you for the review!


Question for classes in route files

Hey, I found the idea of modular very helpfull for me.
But I see the example in the generated route file and there we need to import our classes with use clause.
I have very large module with 20 Controllers. Do I need to import all of them and every time when I create new controller or there is other way?

Right now we don't plan to support the RouteServiceProvider-style implicit namespacing, but you can do the same with a group. Something like:
Route::namespace('Modules\MyModule\Http')->group(function() {
	Route::get('/foo', 'FooController@index');
});


Option to stop wheel from spinning when created.

Is your feature request related to a problem? Please describe.
I want to start spinning with   a button but wheel starts spinning when I create it.
Describe the solution you'd like
Option to chose if wheel shall spin when created.

Found it !


Compiling simple AsyncJulia::init test fails.

Compiling this code copied from the examples/async_tasks/src/main.rs code, but now as test:
#[test]
fn async_init() {
    let (julia, handle) = unsafe {
        AsyncJulia::init(16, 2, 16, 1)
            .expect("Could not init Julia")
    };
}

fails with
  --> jlrs/tests/runtime.rs:41:9
   |
40 |     let (julia, handle) = unsafe {
   |         --------------- consider giving this pattern the explicit type `(jlrs::multitask::AsyncJulia<T, R>, JoinHandle<std::result::Result<(), Box<JlrsError>>>)`, where the type parameter `R` is specified
41 |         AsyncJulia::init(16, 2, 16, 1)
   |         ^^^^^^^^^^^^^^^^ cannot infer type for type parameter `R`
   |
   = note: cannot satisfy `<_ as ReturnChannel>::T == _`
   = note: required by `jlrs::multitask::AsyncJulia::<T, R>::init`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0284`.
error: could not compile `jlrs`

Why?

What are you trying to do, exactly? Tests for the async runtime are included in the jlrs_async_tests crate and you won't be able to successfully run any by adding tests for that runtime to the normal jlrs tests because Julia can only be initialized once and the async runtime is initialized differently than  the sync one. You can't convert a sync to an async runtime.
AsyncJulia needs to send the results of a task back and to do this you need to pick a "return type" T and "channel type" R which is consistent for all implementations of JuliaTask.

What are you trying to do, exactly? Tests for the async runtime are included in the jlrs_async_tests crate and you won't be able to successfully run any by adding tests for that runtime to the normal jlrs tests because Julia can only be initialized once and the async runtime is initialized differently than  the sync one. You can't convert a sync to an async runtime.
AsyncJulia needs to send the results of a task back and to do this you need to pick a "return type" T and "channel type" R which is consistent for all implementations of JuliaTask.

... I see: for it to succeed AsyncJulia::init needs the information of an implemented JuliaTasks.

... I see: for it to succeed AsyncJulia::init needs the information of an implemented JuliaTasks.

The idea behind the design is that I don't want to force users to use a boxed dyn Any + Send + Sync as return type for these tasks, and similarly I wanted to allow users to use the async runtime without using async code elsewhere.

The idea behind the design is that I don't want to force users to use a boxed dyn Any + Send + Sync as return type for these tasks, and similarly I wanted to allow users to use the async runtime without using async code elsewhere.

I think I've answered your question so I'm closing this issue. Feel free to create a new issue if you have any questions, I'm happy to answer them here on GitHub.

I think I've answered your question so I'm closing this issue. Feel free to create a new issue if you have any questions, I'm happy to answer them here on GitHub.

Indeed. thanks.
On Wed, Jan 27, 2021 at 6:10 PM Thomas van Doornmalen <
<EMAIL_ADDRESS>wrote:

I think I've answered your question so I'm closing this issue. Feel free
to create a new issue if you have any questions, I'm happy to answer them
here on GitHub.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Taaitaaiger/jlrs/issues/27#issuecomment-768472816,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5WVT5GFL73MJDKDAAAO4LS4BJIZANCNFSM4WGKW7XA
.

Indeed. thanks.
On Wed, Jan 27, 2021 at 6:10 PM Thomas van Doornmalen <
<EMAIL_ADDRESS>wrote:

I think I've answered your question so I'm closing this issue. Feel free
to create a new issue if you have any questions, I'm happy to answer them
here on GitHub.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Taaitaaiger/jlrs/issues/27#issuecomment-768472816,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5WVT5GFL73MJDKDAAAO4LS4BJIZANCNFSM4WGKW7XA
.


Provide Makefile for better builds

Manually requiring the go dependencies in homebrew is a little bit of a PITA:
https://github.com/leipert/homebrew/blob/add-dlite-formula/Library/Formula/dlite.rb#L13-L76
A Makefile with make build target would be awesome. If you want I could help you with that.
Also is there something like a better go dependency management?

yeah, i can vendor the dependencies and add a makefile to simplify things for you


Ensure new entries always have an ID

For new entries created in a call to CachedList - which should be all of them - enable creating an ID as-needed by adding the parent ID to the context to be used by those cached operations. This should avoid any scenario where we can't determine a cache ID.
Also remove prefetching. It's mostly not needed and creates lots of implicit traffic that can
slow the rest of the experience. There are some scenarios where prefetching improved responsiveness, but it was equally likely to exceed rate limits on APIs and cause errors.
We could explore re-adding it with something like https://gobyexample.com/worker-pools (and maybe rate limiting) to limit concurrent requests so local responsiveness when not immediately using the prefetched data isn't impacted and to avoid running into rate limiting on APIs we use.

Added comments.


OBS Browser - Hardware acceleration nvidia working

I noticed your comment here:
https://github.com/materusPL/Nixerus/blob/90839912fe9caea93ce0b2802a5b6cd65d337a8d/pkgs/apps/obs/default.nix#L172-L172
I can tell you that whatever changes you've made here for the hardware acceleration also works on my nvidia gpus!

libcef provides ANGLE lib but it's not used in nixpkgs, kinda surprising it works for some people with native opengl libs.
There are changes in draft pull request so it will probably work on obs from nixpkgs when it'll get updated to 30.0.*


Newboard

Issue that this pull request solves
Closes: #314
Proposed changes- In the slidermenu the toolbox(text) and close option are having some margin issue.
Brief description of what is fixed or changed
Types of changes- CSS
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[x ] Other (please describe): CSS styling changes

Checklist
Put an x in the boxes that apply

[x ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
[x ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x ] My changes generate no new warnings
[x ] My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request

Thanks for Updating, @shivaamm!

Thanks for Updating, @shivaamm!


image gets shrinked/hidden or shows different background color while loading on Dialog Mui

I am trying to load this library on material ui dialog box with preloaded set of region coordinates, most of the time it works, but sometimes the library breaks, it shrinks the image or hides the image or it shows image with different color background, can you please fix this or let me know any fix for this

sometimes shows like this too on console


Update to Go v1.19

ref:

https://github.com/stolostron/backlog/issues/26056

/cherry-pick release-2.6


Support default base repositories

This change considers .github within the same org to be a default
base repository if none is specified.  This works even when no config
file is specificed in the inheriting repository.
Issue: #1
Dependency: #6

And I reviewed without updating my much longer comment facepalm after I realized my first comment was irrelevant.
Any ways, I realized that you implemented version 2 of https://github.com/probot/probot-config/issues/1#issuecomment-389671116 which has some risks, such as the danger of certain bots and their destructive power, like stale, see: https://github.com/atom/atom/issues/15494. There are definitely use cases where orgs might want 1 or a few repos excluded from the universal configs, but maybe that could be added to the specific repos through a dontExtend: true field or something similar.
I think if we do go this route, we need to make it more explicit in the readme the universal power over repos that the .github repo configuration adds

maybe that could be added to the specific repos through a dontExtend: true field or something similar.

Would it be sufficient for such repos to just specify all the settings they want to have control over?  It's not perfect, but it does keep things simple.

From the best practices docs

Never take bulk actions without explicit permission
Being installed on an account is sufficient permission for actions in response to a user action, like replying on a single issue. But a app must have explicit permission before performing bulk actions, like labeling all open issues.
For example, the stale app will only scan a target repository for stale issues and pull requests if .github/stale.yml exists in that target repository.

☝is one thing we need to consider with adding this functionality. I don't think having a file in the .github should count as explicit permission.
A few ideas:

Make this an option each app can opt-in to. I don't know exactly what the syntax would look like, but the function to fetch the config would have an option to always look to the .github repository
Add a list of enabled repositories in .github repository config.

What is the bulk action in this instance?

Make this an option each app can opt-in to.

If this is something that requires a config in the individual repository, it works against one of the purposes of this feature (to have configurations for some repos without adding any files).

Add a list of enabled repositories in .github repository config

I think this would work.

Add a list of enabled repositories in .github repository config.

Might be more efficient/practical for large orgs to have a list of disabled repositories.
Also thanks @bkeepers for better explaining the destructive power of "bulk actions"! ☺

I agree with the convenience of listing disabled repos, but a couple thoughts thoughts:

As far as permission concerns go, I'm not sure opt-out is sufficient to address the points raised.
Unless the maintainer proactively updates the global config, this would create a race condition for new repos that do want to opt-out.

Maybe we could have some config that says whether the list is an opt-out list or an opt-in list?

Hmm, that's a good point, I was thinking more about convenience.

Maybe we could have some config that says whether the list is an opt-out list or an opt-in list?

That could be doable, but is a bit more painful implementation wise.

Yes, it would be =\
Maybe something else we could do is rather than an opt-in list of repos, we have an opt-in list of repo patterns/regexes...if someone wants all, they can just use * to mark all of them.
Another issue is that once the .github/ repo itself needs a configuration, we have to come up with somewhere to put it that doesn't conflict with other things.  Maybe if we opt to only store inherited configs at the root of the repo, we can store its own config inside a .github/ directory.

When you install the GitHub app, you select whether you want it installed for the org or select repositories.  Is that itself not sufficient control for which repositories the application is applied to?  What does an additional list of either included or excluded repos in the probot config add that isn't accomplished by simply choosing which repos to install the app on?  (I feel like I'm most certainly overlooking something, so am genuinely curious)

@willnorris the main reason for an include exclude list is that some apps (like stale) have power to take bulk action that may not be wanted on every single repo which is the reasoning for the opt out/opt in.
I think in this case however, there's a lot of folks who want only some of their repositories to have the app act on them. Therefore, I think we should move forward with an optOut list that includes only repositories you don't want the app to act on.

Unless the maintainer proactively updates the global config, this would create a race condition for new repos that do want to opt-out.

New repos are usually empty and without issues/PRs, which are usually things the apps need to act on, so I'm not super worried about this use case. I think the solution is being extremely explicit in our docs about the power of the .github repo.

Maybe something else we could do is rather than an opt-in list of repos, we have an opt-in list of repo patterns/regexes...if someone wants all, they can just use * to mark all of them.

I'm not opposed to this for the future, but I think v1.0 of org wide config should just be an opt out list.

I was imagining that the org-wide config would be treated as a default, but not an automatically extended base config.
So if there is a repo config, then only that file applies.  That file can choose to extend another config, but that doesn't happen automatically.  If there is no repo config, then the org config applies if present.
You can achieve both opt-out and opt-in flows depending on how you name the config file in your org config.
Opt-out
# octocat/.github:stale.yml
daysUntilStale: 60
daysUntilClose: 7

# octocat/repo1
# no explicit .github/stale.yml file, so org config applies

# octocat/repo2:.github/stale.yml
# empty file.  opted out of org config

# octocat/repo3:.github/stale.yml
# explicitly extends base config, and overrides some values
_extends: octocat/.github/stale.yml
daysUntilStale: 30

Opt-in
To achieve opt-in, you simply rename the org-wide file, for example by prepending an underscore.  This means that there technically isn't a default org-wide config that gets automatically applied, but there is a base file that can be extended on an opt-in basis.
# octocat/.github:_stale.yml
daysUntilStale: 60
daysUntilClose: 7

# octocat/repo1
# no explicit .github/stale.yml file, so the stale app never does anything

# octocat/repo2:.github/stale.yml
# explicitly extends base config, thereby opting in to the org-wide config.
# Can optionally override values if desired
_extends: octocat/.github/stale.yml

@cco3 reminded me that some apps might choke on the empty files, since they may be assuming that certain values are present.  We'd need to double check that.
Would this cover the use cases people have in mind?  (We walked through all of Google's use cases, and are pretty sure this covers ours)

The idea of renaming the org wide file and prepending it with a special character like an underscore had not occurred to me, and I really like it! 👍
But I'd like to hear some more feedbacks from other folks in @probot/maintainers about this topic, since there are so many different use cases for this.

But I'd like to hear some more feedbacks from other folks in @probot/maintainers about this topic, since there are so many different use cases for this.

I feel like what's outlined in https://github.com/probot/probot-config/pull/7#issuecomment-391834615 is a pretty solid solution, given that it allows for an Org to explicitly opt-in or opt-out all its repositories to the config.
What worries me is we don't have any way to ensure the downstream repositories have access to view the default config. It's possible for an admin to configure permissions on the .github repository in a way that it's not even readable by others in the Org, which would mean a config can be applied to their repositories that they can't see (and therefore wouldn't know how to extend).
I'm not sure if there's a scalable way to enforce this at the moment, and I think it's an edge case, but we should at least write documentation to state that an admin should ensure that everyone in the Org has at least Read permission to the .github repository.

It was me who commented :wave: I also think it’ll work :) I still see my comment here: https://github.com/probot/probot-config/pull/7/files#r191297970  But odd that the comment is not appearing in the PR timeline

But odd that the comment is not appearing in the PR timeline

aha, found it.  It's in the thread above 😄

Friendly ping.  Does this change look alright?  Anything I should change?

Sorry for the delay! I'd love to see a more extensive documentation update according to what we've discussed here and would be happy to help with that if necessary. I think the examples outlined in https://github.com/probot/probot-config/pull/7#issuecomment-391834615 are a great starting point for this.

OK, I'll add something.  All the functionality at this point has been described in the README, so at this point we are talking about offering recipes for common problems.  I'm not sure whether or not this should go in its own section.  I'll write something up, but feel free to chime in if you have opinions.

I agree since this is pretty major, it might warrant it's only section, to be as clear as possible.

OK, well this is a good exercise, because as I write it, I realize that specifying the path an inherited file wasn't already part of the functionality.  How would we prefer to do this?
Like @willnorris said: _extends: octocat/.github/_stale.yml
Or we could standardize on the _ prefix and say that an explicit _extends declaration to a .github project will look for the file with a prepended _.  I.e.,
_extends: .github
We'd be introducing something mildly backwards incompatible given that the previous change would use this and grab a file without an underscore, but I'm not sure if that's a major concern since that was never in a versioned release.

OK, I think using syntax similar to what @willnorris suggested would be best, given that one may want to have several alternative configurations at different paths in a .github project.
Anyway, I've put up another change at #8 for this.

Thanks!
This isn't ready to merge just yet:

I was going to add a recipes section as @hiimbex requested.
It turns out opt-in doesn't work yet (I didn't realize custom paths weren't supported).  I've added a change for this (#8)

I was going to add a recipes section

That can maybe wait for a followup PR? It would be nice to get this merged so folks can start testing it out and reporting back any issues. :)

Out of date comment, sorry.  It's already written at this point.

SO is this ready to 🚢 from your perspective @cco3 ?

Yes, just rebased it on the other change...good to go.

Thanks so much for your work on this @cco3! I'm excited to see organizational level config become easier through probot 🎉

No problem!  Happy to help!


Added Cooking Measurement Calculator

Fixes Issue🛠
Closes #1463
Description👨💻
his tool is particularly useful for recipes that require precise measurements and for those who need to convert between different units of weight commonly used in cooking.
Type of Change📄

[x] New feature (non-breaking change which adds functionality)
[ ] Style (non-breaking change which improves website style or formatting)
[ ] Documentation (non-breaking change which updates or adds documentation)

Checklist✅

[x] I am an Open Source contributor
[x] I have performed a self-review of my code
[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷
HOME PAGE:

WORKING DEMONSTRATION:

@codercake Add you calc in main index.html file in alphabetical order. Also add empty field validations.

could you review the PR? @Nihal4777 @Rakesh9100

Attach the HOME PAGE: and WORKING DEMONSTRATION: in the PR description nicely @codercake

Attach the HOME PAGE: and WORKING DEMONSTRATION: in the PR description nicely @codercake

done! @Rakesh9100

can you check the updated changes made to pr? @Rakesh9100

@Rakesh9100 This PR is reviewed & can be merged.

@codercake You shouldn't add images from other sources. Instead you can download it and save in assets folder.

done! @Nihal4777

Are you assigned to the issue, no right? The mentor asked you a question there but you have still not answered that @codercake
Also, in issue you have mentioned these (e.g., cups to grams, tablespoons to milliliters) but only Ounces and Pounds are there!


Invoke: gRPC errors are wrapped multiple times - cannot get the status code

Describe the bug
Creating a client and server in Go, I need to return a proper error status code.
My handlers look like these:
daprSrv.AddServiceInvocationHandler("new", func(ctx context.Context, in *common.InvocationEvent) (out *common.Content, err error) {
	if ... {
		return nil, status.Error(codes.InvalidArgument, "Invalid content type")
	}
	return res, nil
})

The problem is that the errors are wrapped multiple times, both in the server and in the client. Because of that, it looks impossible to retrieve the status code.
On the client-side, the error is wrapped multiple times, including on https://github.com/dapr/go-sdk/blob/ff2b836a2e9e65bf73234ccb861541b01f4fb6a6/client/invoke.go#L29
On the server-side, OnInvoke method wraps the error here: https://github.com/dapr/go-sdk/blob/ab924fba7d8fbf3c797c26db57ad6d3bc1a04127/service/grpc/invoke.go#L46
It's possible to unwrap the error as wrapped on the client side with a code like:
for {
	unwrapped := errors.Unwrap(err)
	if unwrapped == nil {
		break
	}
	err = unwrapped
}

grpcErr, ok := status.FromError(err)
if !ok {
	// Not a gRPC error
	return
}

However because the error is wrapped in the server too, it's not a gRPC error object anymore, so on the client grpcErr has always code = Unknown and I can't get the status code.
Expected behavior
gRPC errors in the client and server should not be wrapped so the original status code and message are preserved. Otherwise, all errors arrive with status code Unknown and it's not possible for the client to understand what kind of error it is.

FYI @skyao


[R] open_dataset very slow on heavily partitioned parquet dataset

Opening a (particular) partitioned hive-style parquet dataset is very slow (45s to 1 minute).  I have a reproducible example below that takes 780 csv files and writes them to parquet using the open_dataset("csv files") |> group_by(vars) |> write_dataset("parquet") suggested here. Opening and querying the subsequent parquet dataset is much slower than doing it on the original csv files, which is not what I expected.

library(arrow)
library(dplyr)
library(tictoc)

zipfile <- "ahccd.zip"
csv_dir <- "data/csv"
parquet_dir <- "data/parquet"

dir.create(csv_dir, recursive = TRUE)
dir.create(parquet_dir, recursive = TRUE)

# A zip of 780 csvs of daily temperature data at Canadian climate stations (one file per station)
download.file("https://www.dropbox.com/s/f0a18jp0lvbp1hp/ahccd.zip?dl=1", destfile = zipfile)

unzip(zipfile, exdir = csv_dir)

csv_schema <- schema(
  field("stn_id", string()),
  field("stn_name", string()),
  field("measure", string()),
  field("date", date32()),
  field("year", int64()),
  field("month", int64()),
  field("temp", double()),
  field("province", string()),
  field("stn_joined", string()),
  field("element", string()),
  field("unit", string()),
  field("stn_last_updated", string()),
  field("flag", string())
)

csv_format <- FileFormat$create(format = "csv", quoting = FALSE)

# Write to parquet, partitioning on stn_id, year, measure
tic("write csv to parquet")
arrow::open_dataset("data/csv", schema = csv_schema,
                    format = csv_format) |>
  group_by(stn_id, year, measure) |>
  write_dataset(parquet_dir, format = "parquet")
toc()
#> write csv to parquet: 2067.093 sec elapsed

stations <- c("1100031", "1100120", "1100119", "1036B06")

## Query directory of original csv files
tic("query csv")
foo <- arrow::open_dataset(csv_dir, schema = csv_schema,
                           format = csv_format) |>
  filter(year >= 1990,
         year <= 2020,
         stn_id %in% stations,
         measure == "daily_max") |>
  collect()
toc()
#> query csv: 12.571 sec elapsed

## Query the hive-style parquet directory
tic("query parquet")
bar <- arrow::open_dataset("data/parquet") |>
  filter(year >= 1990,
         year <= 2020,
         stn_id %in% stations,
         measure == "daily_max") |>
  collect()
toc()
#> query parquet: 41.79 sec elapsed

## It turns out that it is just the opening of the dataset
## that takes so long
tic("open parquet dataset")
ds <- arrow::open_dataset("~/Desktop/arrow-report/data/parquet")
toc()
#> open parquet dataset: 45.581 sec elapsed

ds
#> FileSystemDataset with 191171 Parquet files
#> stn_name: string
#> date: date32[day]
#> month: int64
#> temp: double
#> province: string
#> stn_joined: string
#> element: string
#> unit: string
#> stn_last_updated: string
#> flag: string
#> stn_id: string
#> year: int32
#> measure: string

tic("query already openend dataset")
ds |>
  filter(year >= 1990,
         year <= 2020,
         stn_id %in% stations,
         measure == "daily_max") |>
  collect()
#> # A tibble: 44,469 × 13
#>    stn_name date       month  temp province stn_joined     element        unit
#>    <chr>    <date>     <int> <dbl> <chr>    <chr>          <chr>          <chr>
#>  1 ALBERNI  1992-01-01     1   6.5 BC       station joined Homogenized d… Deg C…
#>  2 ALBERNI  1992-01-02     1   5.5 BC       station joined Homogenized d… Deg C…
#>  3 ALBERNI  1992-01-03     1   3.5 BC       station joined Homogenized d… Deg C…
#>  4 ALBERNI  1992-01-04     1   6   BC       station joined Homogenized d… Deg C…
#>  5 ALBERNI  1992-01-05     1   0.5 BC       station joined Homogenized d… Deg C…
#>  6 ALBERNI  1992-01-06     1   0   BC       station joined Homogenized d… Deg C…
#>  7 ALBERNI  1992-01-07     1   0   BC       station joined Homogenized d… Deg C…
#>  8 ALBERNI  1992-01-08     1   1.5 BC       station joined Homogenized d… Deg C…
#>  9 ALBERNI  1992-01-09     1   4   BC       station joined Homogenized d… Deg C…
#> 10 ALBERNI  1992-01-10     1   5.5 BC       station joined Homogenized d… Deg C…
#> # … with 44,459 more rows, and 5 more variables: stn_last_updated <chr>,
#> #   flag <chr>, stn_id <chr>, year <int>, measure <chr>

toc()
#> query already openend dataset: 0.356 sec elapsed

The above reprex is self-contained, but will take a while to run, specifically the writing of the parquet dataset can take up to 30 min. It also downloads a 380MB zip file of csvs from my Dropbox.
Environment: macOS Mojave, R 4.1.1
Reporter: Andy Teucher / @ateucher
Note: This issue was originally created as ARROW-15069. Please see the migration documentation for further details.

Closing this as the last interaction here was nearly 2 years ago and it looks like a resolution was found in not partitioning on as many vars - feel free to reopen if this is incorrect.