Fix locale determination in confirm/choice inputs

Fixes #4981
Description
This is a port of https://github.com/microsoft/botbuilder-js/pull/2534, and it should help adaptive dialogs handle unexpected locales better in Composer
Specific Changes

Implement PromptCultureModelsTests.ShouldNotThrowWhenLocaleIsNull
Fix MapToNearestLanguage so that it doesn't throw when the locale is null and so it's more efficient and easier to read and closer to the TypeScript implementation
Rename GetCulture to DetermineCulture in ConfirmInput and ChoiceInput to align with other classes
Fix DetermineCulture in ConfirmInput and ChoiceInput so that it uses MapToNearestLanguage
Have DetermineCulture accept a second parameter in ChoiceInput to align with ChoicePrompt
Rework ConfirmPrompt and ChoicePrompt constructors so that the default choice options are only generated when needed, aligning with best practices and the TypeScript implementations
Clean up ConfirmPrompt, ChoicePrompt, ConfirmInput, and ChoiceInput according to Visual Studio suggestions

Testing
PromptCultureModelsTests.ShouldNotThrowWhenLocaleIsNull

@microsoft/bf-adaptive
@microsoft/botframework-sdk
Please review

    /// ChoiceSet or expression which evalutes to a ChoiceSet.

Typo. Please fix.

Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Input/ChoiceInput.cs:71 in 54c40ed. [](commit_id = 54c40edfe92b5525d0702748f0228547acd5ceae, deletion_comment = False)

    /// ChoiceOptions or expression which evluates to ChoiceOptions.

Typo. Please fix.

Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Input/ChoiceInput.cs:107 in 54c40ed. [](commit_id = 54c40edfe92b5525d0702748f0228547acd5ceae, deletion_comment = False)

    public ObjectExpression<FindChoicesOptions> RecognizerOptions { get; set; } = null;

Not needed.

Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Input/ChoiceInput.cs:119 in 54c40ed. [](commit_id = 54c40edfe92b5525d0702748f0228547acd5ceae, deletion_comment = False)

    /// Replaces the result with the FoundChoice value if possible, then proceedes to <see cref="Dialog.ResumeDialogAsync(DialogContext, DialogReason, object, CancellationToken)"/>.

Typo. Please fix.

Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Input/ChoiceInput.cs:122 in 54c40ed. [](commit_id = 54c40edfe92b5525d0702748f0228547acd5ceae, deletion_comment = False)

    /// Called when input has been received, recognices choice.

Typo. Please fix.

Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Input/ChoiceInput.cs:171 in 54c40ed. [](commit_id = 54c40edfe92b5525d0702748f0228547acd5ceae, deletion_comment = False)

    /// The locale (en-us, nl-nl, etc) or expression which evluates to locale.

Typo. Please fix.

Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Input/ConfirmInput.cs:56 in 54c40ed. [](commit_id = 54c40edfe92b5525d0702748f0228547acd5ceae, deletion_comment = False)


doc verifier token

I found necessary to pass the verifier token in the callback action, that was for fitbit
https://wiki.fitbit.com/display/API/OAuth+Authentication+in+the+Fitbit+API

Closing for no activity.


proxy authentication error calling gulp-protractor.webdriver_update

We have an issue when we call gulp-protractor.webdriver_update on windows 7 behind an authenticated proxy
here is the output, is there a way to specify username/password for the proxy?
I/downloader - selenium standalone: downloading version 2.53.1 I/downloader - curl -o C:\projets\exemples-jspm\jspm-project-es5\node_modules\protractor\node_modules\webdriver-manager\selenium/selenium-server-standalone-2.53.1.jar https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.1.jar I/downloader - chromedriver: downloading version 2.22 I/downloader - curl -o C:\projets\exemples-jspm\jspm-project-es5\node_modules\protractor\node_modules\webdriver-manager\selenium/chromedriver_2.22win32.zip https://chromedriver.storage.googleapis.com/2.22/chromedriver_win32.zip E/downloader - { [Error: tunneling socket could not be established, statusCode=407] code: 'ECONNRESET' } E/downloader - { [Error: tunneling socket could not be established, statusCode=407] code: 'ECONNRESET' }

Could you please check whether this is helpful to resolve your problem?


Display names instead of ID for fields like TestResult, TestType, etc.

Enhancement proposal in the idea of submitting a pull request:
Some fields in the certificate are identifiers that refer to elements declared at https://github.com/ehn-dcc-development/ehn-dcc-schema/blob/release/1.3.0/valuesets/. These elements have a display name in a human readable sentence.
With the certificate decoded, it would be nice to print display names instead of (or in addition to) identifiers.
For example, display :
TestType:   Nucleic acid amplification with probe detection
TestResult: Not detected

Instead of:
TestType: (string) (len=8) "LP6464-4",
TestResult: (string) (len=9) "260415000",

I wrote an implemention but I’m not confident with the method or the code quality.
The ID -> Name translation is called in cmd/coronadecode/coronadecode.go:
func printCertificate(decoded *coronaqr.Decoded) {
        fmt.Printf("\n")
        fmt.Printf("COVID certificate:\n")
        fmt.Printf("Issued:     %v\n", decoded.IssuedAt)
        fmt.Printf("Expiration: %v\n", decoded.Expiration)
        fmt.Printf("Contents:   ")
-       spew.Dump(decoded.Cert)
+       fmt.Printf("Tests:          \n")
+       for _, test := range decoded.Cert.TestRecords {
+               fmt.Printf(" - Target:         %v\n", test.GetTargetName())
+               fmt.Printf("   Type:           %v\n", test.GetTypeName())
+               fmt.Printf("   Name:           %v\n", test.Name)
+               fmt.Printf("   Manufacturer:   %v\n", test.Manufacturer)
[…]

Because of removing the spew.Dump(…) line, we have to code the printing of each field, now and each time a field is added to the certificate structure…
The ID -> Name mapping is implemented in coronaqr.go:
+func (tr *TestRecord) GetTypeName() string {
+       if tr.TestType == "LP6464-4" {
+               return "Nucleic acid amplification with probe detection"
+       } else if tr.TestType == "LP217198-3" {
+               return "Rapid immunoassay"
+       } else {
+               return "Unknown type ID: " + tr.TestType
+       }
+}

ID->Name is hardcoded in the file, in functions attached to the Test/Vaccine/RecoveryRecord structures. It would be nice to load the JSON files from the official source. ID tables may be big! Unfortunately it’s out of my skills at this time.

Because of removing the spew.Dump(…) line, we have to code the printing of each field, now and each time a field is added to the certificate structure…

An alternative would be to implement a function, say convertToHumanReadable, which takes a certificate, replaces the field contents, and returns the modified certificate. Then, just spew.Dump() that new certificate with its human-readable fields.

ID->Name is hardcoded in the file, in functions attached to the Test/Vaccine/RecoveryRecord structures. It would be nice to load the JSON files from the official source. ID tables may be big! Unfortunately it’s out of my skills at this time.

Are the official sources the GitHub repository releases, or is there another data source for these mappings?


renovatebot(deps): update dependency com.twilio.sdk:twilio to v7.40.0

This PR contains the following updates:

Package
Update
Change

com.twilio.sdk:twilio (source)
minor
7.39.0 -> 7.40.0

Release Notes

twilio/twilio-java
v7.40.0
Compare Source
Library

PR #464: Add [archunit] rules. Thanks to @sullis!

Autopilot

Adds two new properties in Assistant i.e needs_model_build and development_stage

Preview

Changed phone numbers from URL|Path to X-XCNAM-Sensitive headers (breaking change)

Verify

Add MessagingConfiguration resource to verify service

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.null seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Installers for Windows / MacOS / Linux

@mkutmon you want this for the new release as well, right?


Null check operator used on a null value when run retrofit

Failed to run retrofit_generator, here is the swagger.

@theoolee  for temp solution use retrofit_generator 7.0.8

@theoolee for temp solution use retrofit_generator 7.0.8

It works 👍🏻

@theoolee, you can upgrade the version to 8.0.2

@theoolee, you can upgrade the version to 8.0.2

Nice work.

Failed to run retrofit_generator, here is the swagger.

@Carapacik my swagger file still meets the same error.

@Carapacik
I faced the same error, too.
Occurs when there is only one "type: object" field in the request body.
The following is a concrete schema.
post:
  summary: Create a favorite_spot
  operationId: createFavoriteSpot
  tags:
    - favorite_spot
  security:
    - bearerAuth: []
  parameters:
    - in: path
      name: spot_id
      required: true
      schema:
        type: string
      description: ID of the spot
  requestBody:
    content:
      application/json:
        schema:
          type: object
          properties:
            user: # Perhaps this is not handled well.
              type: string
              description: User ID
              example: "user123"

  responses:
    "201":
      description: FavoriteSpot created
      content:
        application/json:
          schema:
            type: object
            properties:
              result:
                $ref: "../schema/favorite_spot.yaml#/favorite_spot"
              status:
                type: string


Add more MiniLM rankers

Added Sentence Transformers MiniLM L-4 and MiniLM-L-6 models with full precision (in ONNX) to provide more choice between TinyBert and MiniLM L-12

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Exclude Samba shares from file watcher

As per this comment in 2019, it seems that Samba shares are not supported by the file watcher.
https://github.com/microsoft/vscode/issues/67934#issuecomment-461114239
Is this still the case today?
If I add \\machine\** to the exclude list, it doesn't seem to work. VSCode still scans recently opened files under the Samba host whenever I open a new VSCode window. I can verify this by running fatrace on the Samba host when opening VSCode.

It is possible that an extension installs a file watcher on their own, ignoring the exclude setting.
We use https://github.com/parcel-bundler/watcher as file watcher now, so the question for Samba support is best asked to them. I think we still do not support it, it depends on the underlying native OS functions to support Samba shares, we are not doing anything special on top.

How can I narrow down whether it is happening from another extension?

Even with extensions disabled, I was still seeing my Samba share being accessed. I verified this by looking at my Samba logs with/without extensions enabled; both cases result in access.

Is there a specific scenario when this happens or does it happen right on startup without any file opened?

Oh, the easiest to test is actually to configure files.watcherExclude to ** which would disable the file watcher overall, so maybe let us start with that.

This happens when I open a plain VSCode window without pointing to any file or folder (File > New Window)
With
        "**": true
    },

In my user settings.json, the access still occurs.

One more update: I can trigger the access upon opening any VSCode window (either blank or an existing workspace).
As per the previous comment, so long as the duration between the last unsuccessful access is long enough that VSCode will attempt to access the Samba share again, VSCode will trigger the access, and the error appears on my Samba logs.

Can you try to run code --disable-extensions --user-data-dir <directory> where <directory> is an empty folder? This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.

Unfortunately this still causes an access

Could you clarify what you mean by resource?

I meant, which path exactly gets accessed on the samba share when you start VS Code?

So what makes you think the file watcher triggers this? The file watcher is typically only watches files on the workspace root and below, but not that top level.

How do you suggest we narrow this down? Short of reinstalling VSCode

Wondering if other apps built on top of the same framework cause this:

specifically for Electron: https://www.electronjs.org/fiddle/
Chrome for the browser part

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Documentation updates required to use GitHub rather than SVN

I noticed when going in the contributor guide that it would require some updates to replace SVN by GitHub.
The pages from the contributor guide that needs rewrite:

https://github.com/ZOO-Project/ZOO-Project/blob/main/docs/contribute/code.rst
https://github.com/ZOO-Project/ZOO-Project/blob/main/docs/contribute/doc.rst
https://github.com/ZOO-Project/ZOO-Project/blob/main/docs/contribute/dev.rst
https://github.com/ZOO-Project/ZOO-Project/blob/main/docs/contribute/release.rst

Other:

https://github.com/ZOO-Project/ZOO-Project/blob/main/docs/install/download.rst
https://github.com/ZOO-Project/ZOO-Project/blob/main/docs/install/debian.rst

The web site has been updated to include these new links.


Finish Combat Tab

[x] Implement a list of rollable combat powers/actions.

[x] Style list to look nice
Can currently fit 16 rollable items fully (at default character-sheet height).
[x] Show the roll's source (item it came from) in chat card

[x] Implement Team Maneuvers

This is as complete as it needs to be for initial release, i think. Note, there are no mechanical changes when a team maneuver is active/activated, just a cosmetic change in the combat tab. I consider mechanical changes to be improvements which can come after the initial release. If anyone finds a bug with the implementation, that can be opened in a new issue.


Cordova integration getting build error for iOS with phonegap

Hello,
We integrated the new version of branch into our cordova app. Its working good in Android, but when we build the app with phonegap the build server returns the error as "Error - A plugin in your app does not support the compulsory arm64 (64-bit support) architecture." for iOS.
Please help us to resolve this issue.

Can you provide more details in regards to this issue?

Complete error log
Cordova & plugin versions
iOS version

Thanks

Phonegap build complete error log
error-log.txt
My complete config.xml file
config.txt

Thanks @Mushaqdeen ,
Will look in to the logs provided. I'll give you a feedback once I've found the cause of the error.
Cheers,
Rene

@Mushaqdeen , could you also include the list of plugins that you are using?
Do cordova plugin list in the command line.
Thanks

@renesansz , In the config file there will be the list of plugins that I used in my project.

I see, will look into it.

Hi @Mushaqdeen , For the nth time in creating test app, I can't replicate the issue that you are having.
However I've found this article related with 64-bit support for iOS (link).
So I've tried to increase the minimum Cordova build version from 3.0.0 to 3.5.0 hoping that this would resolve the issue.
See & test PR #114 if this will resolve the issue.
Cheers,
Rene

Had this issue, I think I solved it indirectly by specifying the deployment target to be 7 (something required for intercom.io integration).

Hello,     Now the build got success without any error, but the Branch.initSession() not working also not works the DeepLinkHandler(data) function in iOS.
function DeepLinkHandler(data) {    alert(JSON.stringify(data));}
  From: Renemari Padillo<EMAIL_ADDRESS>
To: BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK<EMAIL_ADDRESS>Cc: Mushaqdeen<EMAIL_ADDRESS>Sent: Tuesday, 19 April 2016 1:40 PM
Subject: Re: [BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK] Cordova integration getting build error for iOS with phonegap (#100)
Hi @Mushaqdeen , For the nth time in creating test app, I can't replicate the issue that you are having.
However I've found this article related with 64-bit support for iOS (link).
So I've tried to increase the minimum Cordova build version from 3.0.0 to 3.5.0 hoping that this would resolve the issue.
See & test PR #114 if this will resolve the issue.Cheers,
Rene—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@Mushaqdeen ,
Good to know that it fixes your build error. Closing the issue now.
For the mean time, could you report a separate issue for this?
Hello,     Now the build got success without any error, but the Branch.initSession() not working also not works the DeepLinkHandler(data) function in iOS.
function DeepLinkHandler(data) {    alert(JSON.stringify(data));}

Cheers,
Rene


Audio Directive Support

Added complete support for audio directives and it's accompanied required objects. It's not perfect and I'm open to feedback on what could be better but I also know how badly needed this support is.
Thanks!

Thanks for this contribution! I'll review and merge soon.

FYI, I've now got a skill certified and public at Amazon with this build.

Great!! Would it be possible to upload a sample project that shows how you are calling these directives?
What is the name of your skill? Can I enable it under my Echo to listen?

Sorry for the delayed response. Yes, it went live last week. The skill name is Church of The Highlands (Unofficial) and it is running my fork of this project. I never had any feedback from Amazon with regards to anything "framework related." Just a few standard bugs here and there.

Anyway you can put a sample project or give some code snippets on how to call Play, enqueue, pause intents using this code?
Thx

This should be enough to get you started.
private CreateAudioResponse(string url, long? offset, string token)
{
            var response = new SpeechletResponse();
            var dir = new Directive
            {
                AudioItem = new AudioItem
                {
                    Stream = new AudioStream
                    {
                        Url = url,
                        Token = token ?? Convert.ToBase64String(Guid.NewGuid().ToByteArray())
                    }
                }
            };
            dir.Type = "AudioPlayer.Play";
            dir.PlayBehavior = "REPLACE_ALL";
            dir.AudioItem.Stream.OffsetInMilliseconds = offset.GetValueOrDefault(0);

            response.Directives = new List<Directive> { dir };

            response.ShouldEndSession = true;
            return response;
}

thanks.. will try it out.

Any word on this?

@dg-racing Sorry for the delay and thanks again for you contribution! Please sign the Contributor License Agreement (see your pull request) so can we accept it in the project.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 7 committers have signed the CLA.:white_check_mark: dg-racing:x: stefann42:x: leonmeijer:x: Ian Clanton-Thuon:x: chrispauly:x: jsvasani:x: dustinsoftwareIan Clanton-Thuon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Sorry about the confusion earlier. I had a commit with a bad email address and had to roll it back. All should be good now for the pull request.

Any chance we can get this merged?

Bro. Merge? Please?

What's the deal here? This pull request has been sitting for 6 months waiting on a merge. Is this library not getting any updates any further? If not, can you turn it over to someone or some group that would be willing to continue maintaining it? This is really frustrating.

Can you resolve the merge conflicts and get this guy merged?

hi all, any plan to merge this PR?

@stefann42 Please merge this and bump a new version.  The audio capability is vital to well-rounded skills and your library is the gold standard so many of depend upon.  Thank you!

@stefann42 I can merge this PR together with #49, #52 and #53 to provide consolidated version. Will it work for you?

@ElvenMonky Yes, please.


Why propensity scored precision can be less than precision?

As the formula suggests, 1/p_l=1+C(N_l+B)^(-A) should be always larger than one. So psp@k = 1/k * \sum  y_l/p_l should be larger than p@k = 1/k \sum y_l. Thus I am confused by the results shown on XML repo website, in which most of the time psp numbers are smaller.

Hi, psp@k numbers must be normalized by highest psp any model can achieve for top k prediction. Hence, these numbers are often less

I am confused by highest psp any model can achieve for top k prediction. Does this mean the psp@k of a model which predicts all result correctly, i.e. p@k=100%? Can you give a formula for this?

consider test point (doc) with ground truth as 1,2,3,4,5,6 with inverse
propensity scores as 4,5,6,1,2,3. Now, for maximum psp@k(k=3)_max any
model can achieve is (6+5+4)/3 = 15/3 = 5. and let say top 3 prediction
of your model is 4, 5 , 6 which have psp@k_model score of (1+2+3)/3 = 2.
Now normalized psp or simply psp = psp@k_model/psp@k_max = 2/5 = 0.4 or
40%. Here, p@3 is 100% but still psp@3 is less than p@3.
Please let us know if it clears your doubt.
On 19/03/20 4:17 pm, Odaimoko wrote:

I am confused by |highest psp any model can achieve for top k
prediction|. Does this mean the psp@k of a model which predicts all
result correctly, i.e. p@k=100%?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/kunaldahiya/pyxclib/issues/3#issuecomment-601111994,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD3QUNMIXZBSHJ5BMFIDFH3RIHZ4FANCNFSM4LOTIFWQ.

Yes it does. Thank you very much!

Could you help me find the reason/reference for normalizing PSP@k to the maximum possible value?
I understood the pros of doing this, including scaling to 0~1 and making the measure comparable among different datasets, but I still want to know a more clear reference on this.
I've read a few papers, including Jain et al. 2016 (Extreme Multi-label Loss Functions for Recommendation, Tagging, Ranking & Other Missing Label Applications), but I couldn't find it yet.
Sorry for asking in an old thread. Thank you very much!


add support for .node-version

not sure what a good icon is for that file, but we use .node-version across our projects. Currently it looks kinda sad without a custom icon.

I think the same could be used for .nvmrc files
for reference, in the icon pack I'm currently using (material icons), the nodejs logo is being used

I'll likely use the node logo as well


Problem with Anndata2SpatialData conversion

Greetings all,
I'm trying to create a SpatialData object from an Anndata object using the from_legacy_anndata function. The Anndata file was created with Squidpy's read_nanostring (Squidpy version 1.5.0) from this Nanostring CosMx public dataset. I'm using a Windows machine. Unfortunately, I'm obtaining this error.
{
	"name": "UnboundLocalError",
	"message": "cannot access local variable 'lowres' where it is not associated with a value",
	"stack": "---------------------------------------------------------------------------
UnboundLocalError                         Traceback (most recent call last)
Cell In[47], line 1
----> 1 sdata = spatialdata_io.experimental.from_legacy_anndata(adata)

File c:\\Users\\Gabriele\\anaconda3\\envs\\cell2loc_env\\Lib\\site-packages\\spatialdata_io\\converters\\legacy_anndata.py:300, in from_legacy_anndata(adata)
    298     scale_hires = Scale([tissue_hires_scalef, tissue_hires_scalef], axes=(\"x\", \"y\"))
    299     shapes_transformations[f\"{dataset_id}_downscaled_hires\"] = scale_hires
--> 300 if lowres is not None:
    301     # prepare the lowres image
    302     assert (
    303         tissue_lowres_scalef is not None
    304     ), \"tissue_lowres_scalef is required when an the lowres image is present\"
    305     lowres_image = Image2DModel.parse(
    306         lowres, dims=(\"y\", \"x\", \"c\"), transformations={f\"{dataset_id}_downscaled_lowres\": Identity()}
    307     )

UnboundLocalError: cannot access local variable 'lowres' where it is not associated with a value"
}

Even if the reason of the error is clear (the lowres is actually absent in the uns slot) does it mean that I must have a lowres image to convert an Anndata object to a SpatialData object?

Hi, thanks for reporting. It looks like a bug as the image should not always be expected. Can you please try this PR? https://github.com/scverse/spatialdata-io/pull/172

Maybe tiny adjustments are needed to that PR, in such case a contribution would be welcome 😊


Better comment about default value of reports_count

thank you @txaj!

@nibalizer would you like to update our metadata.json now that metadata-json-lint has out-dated it ;)

haha really? I'll try but very busy here today.


[Feature Request] Ctrl+A in git side bar should select all files

Ctrl+A keyboard shortcut on focused git side bar should select all files in it. That's pretty much it. :)

Hey guys, I am a new almost contributor so this looks like a good story to get my feet wet with. I will pick up this one if that is okay

@acarrab Are you still up for this?

Hey sorry it has been a busy week. Honestly, I have been focusing on reading through a lot of the code that there is  in my free time. I don't know if I should have asked for a task if I had not read through some of that stuff yet. So pretty much you could take it if you like :), but if not I should get to it soon. I don't mind finding other tasks though as well

@acarrab if you don't want this I'd like to try it. I'm also a new contributor looking to get started with the VS Code codebase. @Lixire any suggestions where to begin / what files are relevant?

@JamesEarle You should start off looking at the scmViewlet.ts file. The viewlet is defined there and the command should be provided by it. More information about how the command should behave is here: https://github.com/Microsoft/vscode/pull/26843 .


eliminate nested SpliceObjects

Improve query times containing multiple aliases.
Fixes #2841

@rintcius, good to know. I'll trash those files and push the changes.

@jsantos17, ready for another look. Let me know what you think of that nested splice object. I tried modeling it after your example query in #2841.

@nicflores needs merge from master. Any idea why Travis didn't run the build for this?

Happy once Travis is green.
@jsantos17 I think Travis doesn't run when it has conflicting files at the moment the PR is created


When location is ? Map should not show any pins :octocat: !

When location is ? Map should not show any pins :octocat: !

by restuta

We have to have all locations. What do you mean?

@Me4ta sometimes we don't have a location for whatever reason, we should not have events like that, but when we do (mb it's a draft or who knows) we don't need to show a map maker


[BUG] Unencrypted public DM response

Describe the bug
When replying to a DM in the notification tab, a public unencrypted note is published that references the encrypted DM.
To Reproduce
Steps to reproduce the behavior:

Go to notifications
Click reply to a DM notification
Write a note, assuming it is private, send it
See error, the not is public and references the encrypted DM note.

Expected behavior
Never ever send DM messages unencrypted.
Example
note1czmw59q3gm3k60z60f52kwl9wmkdzvg6l8ex5ue6j9m87ze8uehqw6u92e
Device (please complete the following information):

Phone Brand/Model: Pixel 6
App Version: 31.3

Thanks Max!
It was fixed yesterday: https://github.com/vitorpamplona/amethyst/commit/a8a3915c8d7ad27b597d0bf018f97a79b44bd6bf

That's the best way to respond to a bug report, awesome, thanks!


[FLINK-3776] Flink Scala shell does not allow to set configuration fo…

The current version of FlinkShell creates a new Configuration object when creating a LocalFlinkMiniCluster in FlinkShell.fetchConnectionInfo().
Instead of creating a new one, FlinkShell just needs to get a configuration object which was already created when GlobalConfiguration.loadConfiguration() is called (which is before FlinkShell.fetchConnectionInfo() is called).
Therefore, just one line modification figures out this issue as shown in this pull request.

Thanks for the pull request. Looks good. Have you tested that the configuration is loaded correctly?

@mxm
Yes, I tested it by simply assigning a non-existent directory to taskmanager.tmp.dirs in $FLINK_CONF_DIR/flink-conf.yaml which is read and parsed by GlobalConfiguration.loadConfiguration().
I got the following error messages:
~/flink/flink-dist/target/flink-1.1-SNAPSHOT-bin/flink-1.1-SNAPSHOT/bin$ start-scala-shell.sh local
Starting Flink Shell:
Exception in thread "main" java.io.IOException: Temporary file directory /tmp/east does not exist.
at org.apache.flink.runtime.taskmanager.TaskManager$$anonfun$checkTempDirs$1.apply(TaskManager.scala:2162)
at org.apache.flink.runtime.taskmanager.TaskManager$$anonfun$checkTempDirs$1.apply(TaskManager.scala:2157)
at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:108)
at org.apache.flink.runtime.taskmanager.TaskManager$.checkTempDirs(TaskManager.scala:2157)
at org.apache.flink.runtime.taskmanager.TaskManager$.startTaskManagerComponentsAndActor(TaskManager.scala:1752)
at org.apache.flink.runtime.minicluster.LocalFlinkMiniCluster.startTaskManager(LocalFlinkMiniCluster.scala:142)
at org.apache.flink.runtime.minicluster.FlinkMiniCluster$$anonfun$3.apply(FlinkMiniCluster.scala:319)
at org.apache.flink.runtime.minicluster.FlinkMiniCluster$$anonfun$3.apply(FlinkMiniCluster.scala:312)
at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at scala.collection.immutable.Range.foreach(Range.scala:141)
at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
at scala.collection.AbstractTraversable.map(Traversable.scala:105)
at org.apache.flink.runtime.minicluster.FlinkMiniCluster.start(FlinkMiniCluster.scala:312)
at org.apache.flink.runtime.minicluster.FlinkMiniCluster.start(FlinkMiniCluster.scala:269)
at org.apache.flink.api.scala.FlinkShell$.fetchConnectionInfo(FlinkShell.scala:148)
at org.apache.flink.api.scala.FlinkShell$.liftedTree1$1(FlinkShell.scala:187)
at org.apache.flink.api.scala.FlinkShell$.startShell(FlinkShell.scala:186)
at org.apache.flink.api.scala.FlinkShell$.main(FlinkShell.scala:134)
at org.apache.flink.api.scala.FlinkShell.main(FlinkShell.scala)

Looks good. Do you think we could make this more explicit by passing the loaded configuration object to the fetchConnectionInfo method? That way we don't depend on global variables and we load the config only once.

Seems fine but it seems to go against the design of GlobalConfiguration``. The singleton GlobalConfiguration``` object is already get and used in that way on few places.
How do you think?

GlobalConfiguration doesn't ensure that the config has been loaded when you call get(). It will give you an empty Configuration if you do not call loadConfiguration explicitly. If you pass the config after you called the load method, it is clear that the config has been loaded.
Your code works, I'll will just open a follow-up issue to make GlobalConfiguration more explicit, i.e. fail on get() if the config hasn't been loaded explicitly.

Okay, I got the idea.

Thanks for the PR!


Attribute transclusion and is-active attr

Add is-active toggle to rg-header-item
transcludeAttrs method to move attrs to first child with ng-transclude
Integrate transcludeAttrs on rg-header-item for sref and href

TP https://rockabox.tpondemand.com/entity/11496

LGTM


Parameters are fixed for docker

do you need to keep a set of working params for the cluster too? maybe set the config file location with an env var?


[MNT] test_write_to_tsfile_unequal_length occasionally raises a FileNotFoundError

Describe the issue
This happens sporadically, see:
https://github.com/aeon-toolkit/aeon/actions/runs/5013217453/jobs/8986467056
https://github.com/aeon-toolkit/aeon/actions/runs/4990819828/jobs/8995302918?pr=318
Suggest a potential alternative/fix
No response
Additional context
No response

huh, I'll take a look


BUG - Can't submit Argo Workflow via Hera on Nebari 2023.7.1

The following script throws an error.
import os

from hera.shared import global_config

os.environ['ARGO_HTTP1'] = "true"

os.environ['ARGO_SECURE'] = "true"

os.environ['KUBECONFIG'] = '/dev/null'

os.environ['HERA_TOKEN'] = os.environ['ARGO_TOKEN'] #.strip('Bearer ')
os.environ['GLOBAL_CONFIG_HOST'] = f"https://{os.environ['ARGO_SERVER'].rsplit(':')[0]}{os.environ['ARGO_BASE_HREF']}/"  # trailing slash required for proper urljoin inside of hera
os.environ['GLOBAL_CONFIG_NAMESPACE'] = os.environ['ARGO_NAMESPACE']

global_config.host = os.environ['GLOBAL_CONFIG_HOST']
global_config.token = os.environ['HERA_TOKEN']  # Copy token value after "Bearer" from the `argo auth token` command

from hera.workflows import Steps, Workflow, script

@script()
def echo(message: str):
    print(message)

with Workflow(
    generate_name="hello-world-hera-",
    entrypoint="steps",
    namespace=os.environ['GLOBAL_CONFIG_NAMESPACE'],
) as w:
    with Steps(name="steps"):
        echo(arguments={"message": "Hello world!"})

w.create()

The error thrown is
BadRequest: Server returned status code 400 with message: `admission webhook "wf-validating-admission-controller.dev.svc" denied the request: An internal error occurred in nebari-workflow-controller while mutating the workflow.  Please open an issue at https://github.com/nebari-dev/nebari-workflow-controller/issues.  The error was: Traceback (most recent call last):
  File "/opt/conda/envs/default/lib/python3.10/site-packages/nebari_workflow_controller/utils.py", line 136, in get_keycloak_uid_username
    keycloak_username = kcadm.get_user(keycloak_uid)["username"]
  File "/opt/conda/envs/default/lib/python3.10/site-packages/keycloak/keycloak_admin.py", line 868, in get_user
    return raise_error_from_response(data_raw, KeycloakGetError)
  File "/opt/conda/envs/default/lib/python3.10/site-packages/keycloak/exceptions.py", line 192, in raise_error_from_response
    raise error(
keycloak.exceptions.KeycloakGetError: 404: b'{"error":"User not found"}'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/conda/envs/default/lib/python3.10/site-packages/nebari_workflow_controller/app.py", line 47, in validate
    keycloak_user = get_keycloak_user(request)
  File "/opt/conda/envs/default/lib/python3.10/site-packages/nebari_workflow_controller/utils.py", line 104, in get_keycloak_user
    keycloak_uid, keycloak_username = get_keycloak_uid_username(
  File "/opt/conda/envs/default/lib/python3.10/site-packages/nebari_workflow_controller/utils.py", line 142, in get_keycloak_uid_username
    preferred_username = workflow["metadata"]["labels"][
KeyError: 'workflows.argoproj.io/creator-preferred-username'

Unwrangling hera a bit via
import json
import yaml
json_str = w.build().json(exclude_none=True, by_alias=True, exclude_unset=True, exclude_defaults=True)
print(yaml.dump(json.loads(json_str), indent=4))

shows me that what is submitted is
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
    generateName: hello-world-hera-
    namespace: dev
spec:
    entrypoint: steps
    templates:
    -   name: steps
        steps:
        -   -   arguments:
                    parameters:
                    -   name: message
                        value: Hello world!
                name: echo
                template: echo
    -   inputs:
            parameters:
            -   name: message
        name: echo
        script:
            command:
            - python
            image: python:3.8
            source: 'import os

                import sys

                sys.path.append(os.getcwd())

                import json

                try: message = json.loads(r''''''{{inputs.parameters.message}}'''''')

                except: message = r''''''{{inputs.parameters.message}}''''''

                print(message)'

Workaround for the time being is to disable Nebari Workflow Controller in the nebari config yaml.
argo_workflows:
  enabled: true
  nebari_workflow_controller:
    enabled: false

I've confirmed that the error goes away and hera/argo is functional after disabling NWC

As I see it, there are at least three ways ways of submitting Argo-Workflows now:

via the Argo UI
via Argo-Jupyter-Scheduler (argo details are hidden from the end user)
via Hera-Workflows

Submitting workflows via Hera-Workflows has always required the user to copy and paste their ARGO_TOKEN from the Argo UI. The difference now is that the user's JupyterLab server already has an ARGO_TOKEN set based on which keycloak group they are a member of (analyst, developer, admin). The "default" ARGO_TOKEN needs to be replaced by your personal ARGO_TOKEN and things should work:
import os
from urllib.parse import urljoin

from hera.workflows import Workflow, script
from hera.shared import global_config

def authenticate():
    namespace = os.environ["ARGO_NAMESPACE"]
    if not namespace:
        namespace = "dev"

    token = "Bearer v2:ey....."  # <-- copied from Argo UI

    if token.startswith("Bearer"):
        token = token.split(" ")[-1]

    base_href = os.environ["ARGO_BASE_HREF"]
    if not base_href.endswith("/"):
        base_href += "/"

    server = f"https://{os.environ['ARGO_SERVER']}"
    host = urljoin(server, base_href)

    global_config.host = host
    global_config.token = token
    global_config.namespace = namespace

    return global_config

authenticate()

with Workflow(
    generate_name="hello-world-",
    entrypoint="hello",
    arguments={"s": "world"},
) as w:
    hello()

w.create()

One workaround that doesn't require you to copy over your ARGO_TOKEN would be explicitly set your creator-preferred-username label on the workflow as follows:
import os
from urllib.parse import urljoin

from hera.workflows import Workflow, script
from hera.shared import global_config

def sanitize_label(s: str) -> str:
    s = s.lower()
    pattern = r"[^A-Za-z0-9]"
    return re.sub(pattern, lambda x: "-" + hex(ord(x.group()))[2:], s)

def authenticate():
    namespace = os.environ["ARGO_NAMESPACE"]
    if not namespace:
        namespace = "dev"

    token = os.environ["ARGO_TOKEN"]
    if token.startswith("Bearer"):
        token = token.split(" ")[-1]

    base_href = os.environ["ARGO_BASE_HREF"]
    if not base_href.endswith("/"):
        base_href += "/"

    server = f"https://{os.environ['ARGO_SERVER']}"
    host = urljoin(server, base_href)

    global_config.host = host
    global_config.token = token
    global_config.namespace = namespace

    return global_config

authenticate()

labels = {
    "workflows.argoproj.io/creator-preferred-username"<EMAIL_ADDRESS>}

with Workflow(
    generate_name="hello-world-",
    entrypoint="hello",
    arguments={"s": "world"},
    labels=labels,
) as w:
    hello()

w.create()

The long-term solution is to generate personalized Argo tokens for each user and add them to as env vars on the user's JupyterLab pod. This has been captured in this issue.

One workaround that doesn't require you to copy over your ARGO_TOKEN would be explicitly set your creator-preferred-username label on the workflow as follows:

Allowing users to set their own creator-preferred-username is a vulnerability since now users can claim to be any user they want and have those files mounted.  I'll open an issue to correct that.


Kraken: Retrieve symbols and pairs from Kraken exchange.

Retrieve symbols and pairs from Kraken exchange. (no more hardcode translations needed)
Updated with new pairs and symbols from kraken exchange for tests.
Updated according new api format with market fees and leverage buy and sell information

@timmolter This is the new pull request with all my changes. All test are running now.

@Achterhoeker
My app is failing to get the currency scale for EUR now.  Is this due to these recent changes?

... i thin k is it.   Currency metadata seems missing.
My bot is running this code for several days without problems, but it isn't using this currency meta data. It also seems that this feature isn't test by any unit test.
Sorry for missing it.
@npomfret Are you able to add it and test it ? I'm currently limited in my time. First possibility i could change it is on Friday.

@npomfret New pull request added with suggested change


Experimenter page

Template name: input.txt
The Save option doesn't always work

Still having the saving issue - any help would be appreciated.


evaluation

Evaluation -> Learn how to use the evaluation system (BLEU, CS, RG, CO)

Done the BLEU and ROUGE evaluation (haven't upload to github)


Make TransactionApiModule non-global

Depends on #1365

The TransactionApiModule was made Global to facilitate overriding this module in the tests (with a fake one).
Since NestJS now provides the ability to override modules based on the respective token, we should require the respective dependants to declare the need for it (increasing encapsulation).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 93.06%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
6548

Relevant Lines:
6786

💛  - Coveralls


net: lwm2m: Fix Invalid ACK when server is using message ID 0

Fixes #28283 based on #28281

Please rebase to pick up a fix for the failed check


Is there a TFRA package that  is compatible with TensorFlow 1.x?

Hi,
I found that TFRA only supports TF 2.4.1 for now, but I often use TF 1.x in my code.
I want to confirm if there are any plans to release a TF1.x-Compatible package?

Hi @amznero, if you need to work with other versions of TensorFlow, we recommend you installing from source by follow the guide on home page.

Hi,
I got some error messages when I use Bazel to build TFRA.
It seems like there is no lookup_util.h file in my TensorFlow packages.

failed command
bazel build --enable_runfiles build_pip_pkg

Build log:
Starting local Bazel server and connecting to it...
WARNING: /home/jovyan/.cache/bazel/_bazel_jovyan/9656d07a7182332e1e30eaea9fdcde12/external/local_config_tf/BUILD:4889:1: target 'libtensorflow_framework.so.1' is both a rule and a file; please choose another name for the rule
INFO: Analyzed target //:build_pip_pkg (29 packages loaded, 146 targets configured).
INFO: Found 1 target...
ERROR: /home/jovyan/codes/recommenders-addons/tensorflow_recommenders_addons/dynamic_embedding/core/BUILD:7:1: C++ compilation of rule '//tensorflow_recommenders_addons/dynamic_embedding/core:_cuckoo_hashtable_ops.so' failed (Exit 1)
In file included from tensorflow_recommenders_addons/dynamic_embedding/core/kernels/cuckoo_hashtable_op.cc:18:0:
tensorflow_recommenders_addons/dynamic_embedding/core/kernels/cuckoo_hashtable_op.h:25:49: fatal error: tensorflow/core/kernels/lookup_util.h: No such file or directory
 #include "tensorflow/core/kernels/lookup_util.h"
                                                 ^
compilation terminated.
Target //:build_pip_pkg failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 13.982s, Critical Path: 7.11s
INFO: 2 processes: 2 local.
 It seems like this repo only supports Bazel v3.1 to build packages. (setting in recommenders-addons/.bazelversion)

Hi @amznero , can you execute python -c 'import tensorflow as tf; print(" ".join(tf.sysconfig.get_compile_flags()))' and check the file in the tensorflow_core/include ?

Hi @rhdong, sorry for the late reply.
I have tried to build it in tf1.15 and tf2.4.
TF 1.15 ENV
After I execute the above command, I got -I/home/nero/miniconda3/envs/myenv/lib/python3.7/site-packages/tensorflow_core/include -D_GLIBCXX_USE_CXX11_ABI=0.
And I listed that dir
>> ls /home/nero/miniconda3/envs/myenv/lib/python3.6/site-packages/tensorflow_core/include/tensorflow/core/
>>     common_runtime/ example/        framework/      graph/          grappler/       lib/            platform/       protobuf/       public/         util/

It seems like there is no kernel dir in it.
I have tried to install tensorflow==1.15 from PyPI or Conda, they have both failed with the same error message.

TF 2.x ENV
I compiled it successfully when the tensorflow==2.4.
>> python -c 'import tensorflow as tf; print(" ".join(tf.sysconfig.get_compile_flags()))'
>>   -I/home/nero/miniconda3/envs/tf2/lib/python3.7/site-packages/tensorflow/include -D_GLIBCXX_USE_CXX11_ABI=0
>>

>> ls /home/nero/miniconda3/envs/tf2/lib/python3.7/site-packages/tensorflow/include/tensorflow/core/
>>   common_runtime/      distributed_runtime/ graph/               lib/                 profiler/            summary/
>>   data/                example/             grappler/            nccl/                protobuf/            tpu/
>>   debug/               framework/           kernels/             platform/            public/              util/

The include dir and the content inside are different between tf1.x and tf2.x. Is this the reason why I can't compile TFRA?

Hi @amznero , I have make a personal branch for compiling with tf1.15.2 version ,and there are some work to do for merge to master, before that you can use this branch to try TFRA. The next version will be released before May 10th that will be compatible with TF1.x and well tested.
https://github.com/rhdong/recommenders-addons/tree/rhdong/compile-with-tf1152

@rhdong  Thanks! I will try it as soon as possible.


Add new options to Article Filters

Coverage: 76.19% (-0.04%) from 76.235% when pulling 5adf7c0ca9e3ce35ad7795ad81ccca13fc1a60d0 on article-filters into 03966069b6d8371ad3814cc2b827539c384ebee3 on master.


Cant change default model?

Hi, here is my config where I chagned default models:

but it is still calling mistral by default. Not sure if this is bug, or I'm missing somehting

if your "actions" are still using mistral you might have params.model defined as mistral for the given action:

Thanks, indeed that was issue.  Btw. now I'm not sure what is wrong but when I try to use 'optimize code' action, the selected code is  pasted in left  window, but it is not wrapped into action template:

and  model is doing nothing (I assume it should start outputting optimized code right  away...)
I can ask it for optimization, but then is  behaves like it did not see the selected code at all:

Code explain seems to work ok. I can only assume   "edit" strategy actions types, are messed up..

this MR should fix it for you,

Thanks. Seems to work ok now.  awesome work on the plugin.


Documentation fixes for Propel 1 versionable behaviour

There's two minor fixes here for this doc page as detailed in #995. Would someone review and merge into the gh-pages branch?

Ah, the gh-pages branch won't build - I presume the Travis failure is to be expected? If so, can a committer take a look and offer PR feedback?

(Presuming 1.0 is abandoned, so closing).


Fix equality comparison and code consistency in runtime.ts

Hi Apache Team,
I'm thrilled to submit my seventh contribution to Apache! I've addressed the issue of weak comparing ==  inside the runtime.ts. Paying attention to such details is vital for code quality, and I'm committed to enhancing the project.
I've made some changes to the runtime.ts file to ensure consistent usage of equality comparison and improve code readability. Here's a summary of the changes made in this pull request:
Changed == to === for equality comparison in the following places:

In endScope(): Changed if (this.autoDisposeScope.length == 0) to if (this.autoDisposeScope.length === 0)
In attachToCurrentScope(): Changed if (this.autoDisposeScope.length == 0) to if (this.autoDisposeScope.length === 0)
In DLDevice constructor: Changed if (tp == "string") to if (tp === "string")
In DLDevice constructor: Changed } else if (tp == "number") to } else if (tp === "number")
In sync(): Changed if (this.deviceType == DeviceStrToEnum.webgpu) to if (this.deviceType === DeviceStrToEnum.webgpu)
In NDArray constructor: Changed if (this.dtype == "float32") to if (this.dtype === "float32")
In Instance class: Various changes to ensure consistent equality comparison using ===

These changes enhance the codebase by using strict equality comparison and maintaining consistent coding style.
-- MAX

Moved to #15621


chore: add sorting to peers table

Rebased for master.
Sorting in peer table with default sorting based on latency column

@fsdiogo oops. Thanks for catching that. Fixed and pushed.

Thank you @JustMaier!

Yay! Happy to have been able to contribute a little something to the cause :)


Why the recommendation to disable TLS1.2?

Hello,
I'm trying to understand why this is the recommendation in this article:
Click Disable for the following settings:
TLS 1.2 only mode
Thanks,
Brendan

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ca07bf8-d285-e7ae-aaf1-a9292bbdf75c
Version Independent ID: 7694cb10-8eb6-397d-2cbb-4e249556b88d
Content: Secure Azure AD Domain Services
Content Source: articles/active-directory-domain-services/secure-your-domain.md
Service: active-directory
Sub-service: domain-services
GitHub Login: @Justinha
Microsoft Alias: justinha

@BrendanHere
Thanks for your feedback! We will investigate and update as appropriate.

@BrendanHere
Thank you for your time and patience!
I was able to find another issue where this might be a typo, and I also checked in with my team regarding this. However, I'll assign this issue to the author to investigate and update the docs as needed.
Additionally, I've created a PR to update the documentation and it's currently waiting for the author to review and sign off.
If you have any other questions, please let me know.
Thank you!

Fantastic. Thank you for the rapid turnaround.
I definitely don’t want to disable that security feature, and it is disconcerting that it’s authored in that way.
Thank you,
Brendan
From: James Tran-MSFT @.>
Sent: Wednesday, May 5, 2021 1:02 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Brendan Mütz @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] Why the recommendation to disable TLS1.2? (#74788)
@BrendanHerehttps://github.com/BrendanHere
Thank you for your time and patience!
I was able to find another issue where this might be a typo, and I also checked in with my team regarding this. However, I'll assign this issue to the author to investigate and update the docs as needed.
Additionally, I've created a PR to update the documentation and it's currently waiting for the author to review and sign off.
If you have any other questions, please let me know.
Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/74788#issuecomment-832857618, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHOVIRZUMB5WOGS4CNMIURLTMF2ZTANCNFSM44DPHFJQ.

@BrendanHere thanks for pointing this out. I revised the topic and added a section about using Azure Policy to ensure compliance with TLS 1.2 usage.
#please-close


sarasa-gothic: 1.0.5 -> 1.0.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/fonts:sarasa-gothic/versions.
meta.description for sarasa-gothic is: A CJK programming font based on Iosevka and Source Han Sans
meta.homepage for sarasa-gothic is: https://github.com/be5invis/Sarasa-Gothic
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0.6 in filename of file in /nix/store/c39x42jq6ymwrslvgac5yc10y71322cl-sarasa-gothic-1.0.6

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
sarasa-gothic

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c39x42jq6ymwrslvgac5yc10y71322cl-sarasa-gothic-1.0.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A sarasa-gothic https://github.com/r-ryantm/nixpkgs/archive/8f4aac3e180413f1b0389081d48ee12c97faf124.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8f4aac3e180413f1b0389081d48ee12c97faf124#sarasa-gothic

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c39x42jq6ymwrslvgac5yc10y71322cl-sarasa-gothic-1.0.6
ls -la /nix/store/c39x42jq6ymwrslvgac5yc10y71322cl-sarasa-gothic-1.0.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

sarasa-gothic

Maintainer pings
cc @ChengCat for testing.

This doesn't compile. The url path https://github.com/be5invis/Sarasa-Gothic/releases/download/v1.0.6/Sarasa-TTC-<IP_ADDRESS>z does not exist.


Add support for 8

Description
Add php 8
Steps to reproduce

Expected Behavior

Actual Behavior

Metadata
Typesense Version:
OS:

+1

+1

I've opened a PR for monolog: https://github.com/typesense/typesense-php/pull/34


Fix YAMLLoadWarning

#91

Coverage remained the same at 79.583% when pulling a67e2f31d99f943af44740a7144faab8958e8d3b on diggerdu:master into 537bb7bad0601fc58e4fff8404f71658b86ef60e on marl:master.


build: investigate static binary

torcx is currently a dynamic binary, but we should investigate if it is possible to bring it back to a plain-static binary.
After initial investigation, the cgo bits seems to be coming from two of our dependencies:

containers/image: it links agains libgpgme. This can however be disabled via a buildtag (containers_image_openpgp)
viper: its dynamic configuration brings in cgo for inotify support. This doesn't seem to be configurable, but needs further investigation. We don't strictly rely on it, so we can possibly get rid of it alltogether.

Other: we may still need cgo for our own internal purposes (eg. mounting), in which case we'll just admit that torcx has to be a dynamic binary. This needs to be re-assed once we are close to features completeness.

I also think that torcx should be simply a static binary file. It's not fun to take care of dependent libraries at runtime.
As for libgpgme, it's already done, isn't it? Both Makefile and scripts/build.sh already have the buildtag containers_image_openpgp, which causes containers/image to be built without cgo. (= go-native)
As for viper, AFAIK torcx doesn't need to watch config changes that depends on fsnotify. So it's already possible to disable cgo, I suppose. I just tested torcx without cgo, it works fine.
Though I'm not sure if there will be other use cases in the future.

Yeah, libgpgme is already ok. viper is actually maybe overkill here, I'm actually considering to drop it completely. But yes, we definitely don't need the fsnotify part as you noticed (was it just fine with CGO_ENABLED=0?).
I wasn't spending too much effort on this right now as it could maybe get re-introduced later, but if it is a simple change and you already tried it, a PR is welcome!

@lucab Yep, it's just fine with CGO_ENABLED=0. I'll create a PR.


Model::create([]) does not work well when arrays are accessed in values

Example:
$data = $event->getData();

User::create([
    'value_one' => $data['value_one'],
    'deep_value' => $data['response']['deep_value'],
]);

The plugin inspects and completes $data array key names when it should not.

This is slightly related to #40 . Might be addressed together 🤷🏻♂

Might be related to #56 .


[query] Support tx places in queries

Right now we only allow placeholders in patterns, so you can't write:
[:find ?tx :where [?x ?a "foo" ?tx]]

See constrain_to_tx and apply_pattern_clause_for_alias, and the test in tests/query.rs.

@rnewman
Currently [:find ?name :where [?x :foo/name ?name ?tx]] with ?tx provided a value in the inputs returns the most recent value associated with the attribute, not the one associated with the transaction id.
Does this bug also include enabling this?

Ignore previous comment. Was forgetting to add :in.


Add pr ci

When someone pulls request, github can action.

Thanks for your contribution.
I added some fully functional workflows to automate the execution of test and release recently, so I will close this PR.


Error in running code

Run python clipscore.py example/good_captions.json example/images/
An error occurred as follows：
Traceback (most recent call last):
File "D:\ConZIC-main\clipscore-main\clipscore.py", line 273, in
main()
File "D:\ConZIC-main\clipscore-main\clipscore.py", line 232, in main
image_feats = extract_all_images(
File "D:\ConZIC-main\clipscore-main\clipscore.py", line 126, in extract_all_images
for b in tqdm.tqdm(data):
File "C:\Users\Prc\anaconda3\envs\pytorch\lib\site-packages\tqdm\std.py", line 1180, in iter
for obj in iterable:
File "C:\Users\Prc\anaconda3\envs\pytorch\lib\site-packages\torch\utils\data\dataloader.py", line 359, in iter
return self._get_iterator()
File "C:\Users\Prc\anaconda3\envs\pytorch\lib\site-packages\torch\utils\data\dataloader.py", line 305, in _get_iterator
return _MultiProcessingDataLoaderIter(self)
File "C:\Users\Prc\anaconda3\envs\pytorch\lib\site-packages\torch\utils\data\dataloader.py", line 918, in init
w.start()
File "C:\Users\Prc\anaconda3\envs\pytorch\lib\multiprocessing\process.py", line 121, in start
self._popen = self._Popen(self)
File "C:\Users\Prc\anaconda3\envs\pytorch\lib\multiprocessing\context.py", line 224, in _Popen
return _default_context.get_context().Process._Popen(process_obj)
File "C:\Users\Prc\anaconda3\envs\pytorch\lib\multiprocessing\context.py", line 327, in _Popen
return Popen(process_obj)
File "C:\Users\Prc\anaconda3\envs\pytorch\lib\multiprocessing\popen_spawn_win32.py", line 93, in init
reduction.dump(process_obj, to_child)
File "C:\Users\Prc\anaconda3\envs\pytorch\lib\multiprocessing\reduction.py", line 60, in dump
ForkingPickler(file, protocol).dump(obj)
AttributeError: Can't pickle local object 'CLIPImageDataset._transform_test..'

It looks like you are on a windows machine. I believe that pytorch uses pickle when doing dataloading. And it looks like there's something different about pickle on windows. I don't have much experience working on windows machines, but have you tried looking around for "windows" "pickle" "pytorch dataloader" + "multiprocessing"?

Thank you for your warm answer. I have already solved this problem. Set num_ Workers=0


go/constant: panic in Int64Val

This program panics when built and run with a tip Go distribution:
http://play.golang.org/p/AOMz-2Sduz
	million := constant.MakeFromLiteral("1e6", token.FLOAT, 0)
	constant.Int64Val(million) // panic: 1000000 (constant.ratVal) not an Int

It works under Go 1.5.

Working as intended.
With the go/constant semantic change you need to call ToInt first:
package main

import (
	"go/constant"
	"go/token"
)

func main() {
	million := constant.MakeFromLiteral("1e6", token.FLOAT, 0)
	million = constant.ToInt(million)
	x, ok := constant.Int64Val(million) // panic: 1000000 (constant.ratVal) not an Int
	println(x, ok)
}

works fine.

Of course.  Sorry for the noise.


another try

👷 Deploy Preview for johare-cv processing.

Name
Link

🔨 Latest commit
a975931238eef609ffc001344bfd044b82ab1459

🔍 Latest deploy log
https://app.netlify.com/sites/johare-cv/deploys/65db9f466e64fb0008010670


Non-recoverable error

Problem Description
I'm getting an error while playing Pyanodon's. I hadn't had any problems up until now. Save file here: .....pY pY Again....zip
The mod Factory Planner (1.1.72) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event factoryplanner::Custom event (ID 310)
__factoryplanner__/ui/main/production_table.lua:331: attempt to perform arithmetic on field 'satisfied_amount' (a nil value)
stack traceback:
	__factoryplanner__/ui/main/production_table.lua:331: in function 'fuel'
	__factoryplanner__/ui/main/production_table.lua:319: in function '?'
	__factoryplanner__/ui/main/production_table.lua:424: in function 'render_lines'
	__factoryplanner__/ui/main/production_table.lua:432: in function 'refresh_production_table'
	__factoryplanner__/ui/main/production_table.lua:461: in function 'registered_handler'
	__factoryplanner__/ui/event_handler.lua:307: in function <__factoryplanner__/ui/event_handler.lua:287>
	[C]: in function 'raise_event'
	__factoryplanner__/util/raise.lua:14: in function 'refresh'
	__factoryplanner__/ui/base/main_dialog.lua:243: in function 'registered_handler'
	__factoryplanner__/ui/event_handler.lua:307: in function <__factoryplanner__/ui/event_handler.lua:287>
stack traceback:
	[C]: in function 'raise_event'
	__factoryplanner__/util/raise.lua:14: in function 'refresh'
	__factoryplanner__/ui/base/main_dialog.lua:243: in function 'registered_handler'
	__factoryplanner__/ui/event_handler.lua:307: in function <__factoryplanner__/ui/event_handler.lua:287>

.....pY pY Again....zip
Reproduction
The crash does not happen when I use the shortcut keys or the button to open the main window, but using the shortcut keys for the mini-window or the button on the mini-window to switch to the main window, it crashes, giving the error log. This only occurs with this Shale Oil subfactory.
If I switch to another subfactory in my list make it so I can switch from main to mini without a problem. But then, if I switch back to the Shale Oil subfactory, the error occurs.

Hello, appreciate the report! Unfortunately, your save zip seems corrupt in some way, it just unpacks to an empty folder for me. But that's okay, there's another thread with the same issue where people posted information as well. I'll close this one, so please everyone refer to #114


swift-package: error: unsatisfiable with version 2

Hi, I'm trying to work with Vapor MySQL and Kitura but I always get the error in the title when I run swift build or swift package generate-xcodeproj. It only happens with new version 2, I works perfectly with latest version 1. Here is my Package.swift
let package = Package(
  name: "Kitura-Starter",
  targets: [
    Target(name: "Kitura-Starter",
           dependencies: [.Target(name: "Controller")]),
    Target(name: "Controller")
  ],
  dependencies: [
    .Package(url: "https://github.com/IBM-Swift/Kitura.git", majorVersion: 1, minor: 7),
    .Package(url: "https://github.com/IBM-Swift/HeliumLogger.git", majorVersion: 1, minor: 7),
    .Package(url: "https://github.com/IBM-Swift/Kitura-Credentials", majorVersion: 1, minor: 7),
    .Package(url: "https://github.com/IBM-Bluemix/cf-deployment-tracker-client-swift.git", majorVersion: 3),
    .Package(url: "https://github.com/IBM-Swift/BlueCryptor.git", majorVersion: 0, minor: 8),
    .Package(url: "https://github.com/vapor/mysql.git", majorVersion: 2)
])

I copied your dependencies into a new project and it resolved just fine. Perhaps you have a Package.pins file lying around from an older build? Try removing that along with the .build folder and building again.

OK, it worked for me tu delete Package.pins and .build folder but now, I'm working on Ubuntu, it require a cmysql package that it can't find and I don't know where to search for.
cmysql libcurl4-openssl-dev openssl libssl-dev
E: Unable to locate package cmysql

The cmysql package is available in Vapor's own APT repository. See the documentation.


Host MDS has no NIDS

Description
We are using iml-<IP_ADDRESS> to monitor existing lustre file-system. After adding server in monitored mode  while running detect file system it is throwing an error host mds has no NIDS.
Repro
The lustre file system is working fine and we able to do lctl ping to all mds, oss and client nodes.
Version
What version of IML?
iml- <IP_ADDRESS>
What Operating System?
Centos7.5

Duplicate of https://github.com/whamcloud/iml-common/issues/58


Add image secrets

What this PR does / why we need it:  This PR allows the user to set the imagePullSecrets for the image.  This allows the user to specify an image in a private registry
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #7206
Special notes for your reviewer:

@davidkarlsen  is this all good then?

bump?

/ok-to-test

/lgtm

/assign @icereval

/approve


Remove automatic state spread

Currently, the implementation of the underlying reducer is the following:
if (state && typeof state === "object") {
  return { ...state, ...action.newState };
}
return action.newState;

It was implemented this way to remove some burden from the developer of having to spread the current state themselves. The action then becomes simply returning only the mutated state.
However, this design decision has the side-effect of making the governor unable to 'forget' state.
I suggest changing the underlying return to be:
return action.newState;`

This would allow for an action to 'forget' state, but at the cost of the developer having to spread the current state into their returns from actions manually. For simple contracts, like the one in the readme, this means that the developer can elect to ignore that requirement:
const contract = {
  increment(state) {
    return {
      count: state.count + 1
    };
  },
  add(val, state) {
    return {
      count: state.count + val
    }
  }
};

This code CAN remain as-is unchanged since there is only a single property of the returned object, and both functions return it (e.g. state.count will always exist after an action is invoked). However, in more complicated use-cases, the developer may now perform actions which forget state and do not need to rely on the initial state to do so:
const contract = {
  login(username, password) {
    /* business logic */
    return {
      ...this.state,
      user: someUserObject
    };
  },
  logout() {
    /* business logic */
    const toRet = { ...this.state };
    delete toRet.user;
    return toRet;
  }
};

Resolved by #14


Use environment variables for secrets in prod

Updating in place does not apply to connection strings specifically since they are usually configured at startup as singletons.
This brings consistency with the development experience.
Gets rid of AddTyeBindings
"Less secure", sure but to be pedantic env variables are stored in virtual file on disk while the process is running. I'd argue if you want full security then use keyvault/vault/name your secret store.

Fixes #313

@rynowak good to merge?


Forked futures do not capture errors

When using a forked future that triggers an error, the future does not capture the error and we get a debugger.

label := (BrLabel new)
	aptitude: BrGlamorousLabelAptitude;
	withAsyncFutureDo: [:anElementFuture |
		anElementFuture
			whenSuccess: [:aLabel :aStatus |
				aLabel text: aStatus asString];
			whenError: [:aLabel :anError |
				aLabel text: 'Error: ' , anError description];
			whenPending: [:aLabel |
				aLabel text: (aLabel text asString asRopedText
					foreground: Color gray)]];
	yourself

label asyncFuture
	future: [  1/0 ] asAsyncForkedFuture

Works now:


Debug Console Messages

Hi @waldo1001,
I noticed that the extension pollutes the debug console a bit, see the screenshot below:

I can understand logging the activation/deactivation of the extension, but I think the other messages should not be there (e.g., printing the path of my user folder from SnippetFunctions.js).
While developing another VSCode extension, these messages pop up every time.
Could this be cleaned up? 😉

Thanks for your message.  It makes sense to diminish the amount of logs, although I'll keep quite a few of them - since they give me a lot of feedback when something goes wrong...


⚠ Bofrost.be has degraded performance

In cd2e8c9, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1345 ms

Resolved: Bofrost.be performance has improved in bb9a7d6 after 13 minutes.


modified for building Cachebench on CentOS9

When building in CentOS9 had found the path missing (found there was an additional path compared to other build function)

Thanks for reporting this issue. We are aware of this and let us piggy-back this to the patch fixing the same issue for Centos Stream 9 build.


STYLE: Renamed ImageRange to ImageBufferRange

Renamed Experimental::ImageRange to Experimental::ImageBufferRange, to clarify
that this particular range iterates over the entire image buffer (rather than
over a specific region). Adjusted source file names and tests accordingly.
Note that Experimental::ImageRange was only merged to the master branch of ITK
on December 1, 2018 (SHA-1: 225da5a4a0f1ae973bf349f1986c611b60a2c2ab), and it
was never in a final ITK release, so this commit is unlikely to break a lot of
user code.

This PR is part of the outcome from the discussion with @thewtex and @blowekamp at https://discourse.itk.org/t/imagerange-a-range-of-iterators-to-the-pixels-of-an-image/1455

LGTM! Thanks!


Extension API to show all Walkthroughs contributed by extension

Hi,
VSCode provides a command to open a specific walkthrough contributed by an extension such as workbench.action.openWalkthrough(fullyQualifiedWalkthroughID: string, toSide?: boolean)
Is there a command to show all Walkthroughs contributed by an extension?
Thanks!

I suggest you use vscode.extensions.getExtension(extensionId).packageJSON?.contributes?.walkthroughs

Thanks @gjsjohnmurray I was hoping there's an API that can show the filtered list of walkthrough in a quickpick. But it seems that the capability doesn't exist yet?
We can use that command to build our own quickpick then. Thanks!


Update MD file on new branch 2017-29-02_05-12-38

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


haskell: get cabal-install <IP_ADDRESS> building on ghc-8.6.5 and ghc-8.8.1

Motivation for this change
Taking a look at hdyra, it appears that cabal-install has recently been updated to <IP_ADDRESS>, but it is failing to build on both GHC-8.6.5 and GHC-8.8.1:

job: https://hydra.nixos.org/eval/1539239
GHC-8.8.1: https://hydra.nixos.org/build/99351396
GHC-8.6.5: https://hydra.nixos.org/build/99458404

This PR tries to fix cabal-install-<IP_ADDRESS> so it builds on both GHC-8.6.5 and GHC-8.8.1.
Here's a summary of why cabal-install-<IP_ADDRESS> doesn't work on both GHCs, and the changes I made in this PR:

GHC-8.6.5:

cabal-install requires the resolv package.  However, the most recent version of resolv (<IP_ADDRESS>) requires base-4.13 (GHC-8.8.1).  So this PR makes sure a resolve_0_1_1_2 is generated, and then uses that to build cabal-install.  (Although, I haven't actually generated hackage-packages.nix, so this code shouldn't work until hackage-packages.nix is regenerated).

GHC-8.8.1:

cabal-install has an unnecessary dependency on base <= 4.13, so it has been jailbroken.

the regex-base package needs to be jailbroken (and patched) to work with base-4.13 (GHC-8.8.1), however the build-depend is in a conditional, which it appears jailbreak-cabal can't deal with.  So I've had to do this by hand.

I also removed the cabal-install-3 derivation, since it isn't needed anymore.
With these changes, I am now able to build cabal-install:
$ nix-build -A haskell.packages.ghc865.cabal-install
/nix/store/91gdifa89jp99123kkklxakkyl234jxb-cabal-install-<IP_ADDRESS>
$ nix-build -A haskell.packages.ghc881.cabal-install
/nix/store/ggz9mffjm73kryx517xyja1xx6hakvv1-cabal-install-<IP_ADDRESS>

Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @peti @Infinisil

@peti Is there anything you'd like me to do to help out with this?  It looks like there are some conflicts now, so should I update them?

should I try to fix them and rebase this on the current haskell-updates?

Yes, that would be very helpful! Please re-base the PR and ping me one more time. I'll take a lot of the remainder of the changes then. Sorry for the delay!

Looks like this is all already building on the current haskell-updates branch, so I'm going to go ahead and close it.
Thanks!


feat: Elrond to MultiversX [web-multiversx]

Description
Closes: BDU-744

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] ran linting via yarn lint
[ ] wrote tests where necessary
[ ] included the correct type prefix in the PR title
[ ] targeted the correct branch
[ ] provided a link to the relevant issue or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed
[ ] added a changeset via yarn && yarn changeset

LGTM, please add a change set and update jest snapshot as well


add api key in get started docs

We were missing a section in the get started tutorial for how to create an API key.

Whoa. I literally could not have expected for my feedback to turn into a fix any quicker. Kudos @kkowalsky


Add 'None of these' feature to checkboxes

What
Add guidance and possibly code to checkboxes to allow a 'None of these'
Why
We previously had this guidance in Dropbox Paper. The alternative is the user selects no checkboxes and clicks continue, which is an implicit answer. This is arguably less clear than an explicit answer, and there is a risk the user clicked continue accidentally.

@timpaul We've not yet got any client side javascript to deselect or disable other checkboxes when 'none' is selected. This may be because with our question there isn't really room for interpretation, but can't say for certain. When we validate server side we return an error that you can't select 'none' and something else. I've just had a look and we've seen that error 23 times in the past 6 and a bit months which is pretty low. We are adding a new page with this pattern again so will be keeping an eye on the errors for this page and push to add a js feature. It's worth noting that our events vs unique events (meaning one checkbox being clicked more than once) is for the most case almost identical, meaning very few people are changing their mind once selected. So from our perspective it seems like having no client side javascript is working fine and server side validation is sufficient for when js isn't available.

I'd suggest an error message something like:
"You cannot select 'None of these' and other options"

@joelanman Yeh, we currently have Cannot select 'none' and a benefit when none and something else is selected and Select the benefits they were getting or waiting to hear about, or select 'none' when nothing is selected, which both seem to work fine when they do appear.

GOVUK (specifically @alex-ju ) have added this as a component in their own component library: https://github.com/alphagov/govuk_publishing_components/pull/1478

We'll need to think about conditional reveals when we do this – at the minute the logic for checkboxes assumes that we only need to sync the conditional reveal state for the checkbox that was clicked:
https://github.com/alphagov/govuk-frontend/blob/6e3a9920ba1785c0f5cfaf4d70c8626f1836a109/src/govuk/components/checkboxes/checkboxes.js#L68-L77
We'll also need to think about scope – do we scope to the immediate module, or make it act like a radio button and deselect any checkboxes with the same name in the same form?

We added something for this in my service.
More abstractly it creates 'mutually exclusive' groups - which get defined using data attributes on each checkbox. When a checkbox is checked, checkboxes in groups other than the current one get unchecked. The idea for this came from someone on the cross gov slack - but I don't remember who suggested it (they were doing similar).
This generically supports where you might have more than one group. eg:
[] a
[] b
[] c
or
[] d
[] e

example from the census

Alt text
Do any of the following people also live at [address] on Sunday 21 March 2021?
Who to include
Do any of the following people also live at 47 East Road, London on Sunday 21 March 2021?
Select all that apply. You can select more than one for each person
Family members and partners
Include babies born on or before 21 March 2021, children, students and schoolchildren who live away from home during term time
Housemates, tenants or lodgers
People who usually live outside the UK who are staying in the UK for 3 months or more
People temporarily away
For example, working away, on holiday, in the armed forces, living in an establishment such as a care home for up to 6 months, abroad for up to a year
People staying temporarily who usually live in the UK but do not have another UK address
For example, UK residents between addresses or currently without a home
Or
Or, None of these apply, I am the only person who usually lives here


Option to disable routing

This might sound like a weird suggestion, but it would be nice to have an option to make a modal non-routable (basically being able to disable the primary feature of this addon.
Here is why:

in the case of the security modal, i.e. "Please confirm you really want to delete your account", we should not be able to access that route directly: example.com/user/settings/delete-confirmation
for styling and to avoid code duplication, to fix 1. we don't want to move to another, second ember modal addon such as https://github.com/yapplabs/ember-modal-dialog

So yes, I currently have to use both ember-routable-modal and ember-modal-dialog, but would like to use only one of them (yours!).
What do you think?

Agreed, I'd also like to consolidate on using just one modal addon rather than two! Development has been a little slow on this addon recently but I'm going to be carving out some time soon to focus on it and this is definitely one of the things I want to implement 👍


An object property for indicating taxa included in a taxonomic unit

Proposed term: includes_taxon
Definition: Indicates a taxon included in a Taxonomic Unit (#10).
Domain: Taxonomic Unit (#10)
Range: dwc:Taxon
See also: PHYX context
Competency questions:

Which taxa are explicitly included in a taxonomic unit?

This is currently implemented in our tools as a has_scientific_name term that indicates scientific names that themselves indicate taxa. However, refocusing this term to directly include a taxon provides us with a clearer link to Darwin Core and is structured similarly to includes_specimens (#12).

What is a taxon that is not a TU? I think that question has to be answered first.

I would like to talk about this when we meet in person in New Zealand. There si something I am not sure I understand or appreciate here
Nico

On Aug 21, 2018, at 9:19 PM, Gaurav Vaidya<EMAIL_ADDRESS>wrote:
It does indeed! We're interested in two things when it comes to TUs:
A node on a phylogeny represents some biological entity, whether a specimen or a taxon.
A phyloreference defines a clade which must include or exclude a specimen, a taxon or another phyloreference.
So, a taxon is always a TU, but a TU may also include individual specimens and -- ideally -- should be stretchable enough to include lineages.
An interesting solution to this problem is used by the Population and Community Ontology (PCO) and the Biological Collections Ontology (BCO): the PCO has a class for an organismal entity http://purl.obolibrary.org/obo/PCO_0000031, which has subclasses for a single organism or virus http://www.ontobee.org/ontology/PCO?iri=http://purl.obolibrary.org/obo/CARO_0001010 as well as for a collection of organisms http://purl.obolibrary.org/obo/PCO_0000000. The BCO allows an organismal entity to be related to a dwc:Taxon http://www.ontobee.org/ontology/BCO?iri=http://rs.tdwg.org/dwc/terms/Taxon via an Identification http://purl.obolibrary.org/obo/BCO_0000084, but also appears to assert that a dwc:Taxon is itself a collection of organisms.
So, one possible solution for us would be to use organismal entity http://purl.obolibrary.org/obo/PCO_0000031 instead of TUs. We would need to invent a term for the CDAO ontology to assert that a cdao:Node represents a particular organismal entity, but then we could immediately define the entity in terms of particular specimens or assert that it has been identified as a particular taxon without needing to clarify the definition of TUs in CDAO (#10 https://github.com/phyloref/phyloref-ontology/issues/10). I think CDAO would benefit from having such a term, and we would benefit from being about to use the BFO and PCO in building the taxon- and specimen-related parts of our model.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/phyloref/phyloref-ontology/issues/13#issuecomment-414874385, or mute the thread https://github.com/notifications/unsubscribe-auth/ACaXwUzyQkz91oEHFEqoHzrbSwmdrwGCks5uTLGmgaJpZM4UbXbr.

I think we're going to have to look at a data model we're driving towards in the form of a graph. @gaurav I'm not convinced by your argument that what we need can't be achieved in a simpler way, but if we look at this in a graphical way maybe it becomes clearer.

I would argue that given our curation results there is ample evidence supporting the conclusion that there is no discernible difference between a specifier and a referent to a taxon concept. Hence, for these questions raised earlier:

We are interested in two things:

A node on a phylogeny represents some biological entity, whether a specimen or a taxon.

In the CDAO model, a node on a phylogeny represents a cdao:TU. Arguably, the class of cdao:TU may be broader than a taxonomic concept, but at least it subsumes taxon concepts, such as tc:TaxonConcept. A taxon concept can be qualified by a variety of properties, including a specimen, a scientific taxon name, etc. The TCAN ontology (see #28) formalizes this.

A phyloreference defines a clade which must include or exclude a specimen, a taxon or another phyloreference.

I think we can be much more specific: A phyloreference defines a clade that must include or exclude certain taxon concepts. I think that's well supported by our curation results so far.
Note also that #29 introduces phyloref:includes_TU. In light of that and the above, I think this issue should be closed.

A node on a phylogeny represents some biological entity, whether a specimen or a taxon.
Technically, a sequence, too, which is different from a specimen or taxon.

Nico

In the CDAO model, a node on a phylogeny represents a cdao:TU. Arguably, the class of cdao:TU may be broader than a taxonomic concept, but at least it subsumes taxon concepts, such as tc:TaxonConcept. A taxon concept can be qualified by a variety of properties, including a specimen, a scientific taxon name, etc. The TCAN ontology (see #28 https://github.com/phyloref/phyloref-ontology/pull/28) formalizes this.
A phyloreference defines a clade which must include or exclude a specimen, a taxon or another phyloreference.
I think we can be much more specific: A phyloreference defines a clade that must include or exclude certain taxon concepts. I think that's well supported by our curation results so far.
Note also that #29 https://github.com/phyloref/phyloref-ontology/pull/29 introduces phyloref:includes_TU. In light of that and the above, I think this issue should be closed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/phyloref/phyloref-ontology/issues/13#issuecomment-448453335, or mute the thread https://github.com/notifications/unsubscribe-auth/ACaXwWdxM94bgRrM-e_mFkABqS63pHjKks5u6a0WgaJpZM4UbXbr.

Technically, a sequence, too, which is different from a specimen or taxon.

It still represents an OTU (cdao:TU), and arguably a taxon concept, even if possibly a very narrow one.

I thought you wanted to be exhaustive in listing anything that a node can represent.

On Dec 18, 2018, at 10:52 PM, Hilmar Lapp<EMAIL_ADDRESS>wrote:
Technically, a sequence, too, which is different from a specimen or taxon.
It still represents an OTU (cdao:TU), and arguably a taxon concept, even if possibly a very narrow one.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/phyloref/phyloref-ontology/issues/13#issuecomment-448460772, or mute the thread https://github.com/notifications/unsubscribe-auth/ACaXwdl2C3s2Odu1Z5WqFsa1Nl3d7ig1ks5u6bfwgaJpZM4UbXbr.

No. This is about what specifiers given in clade definitions can represent, and how we map that to what what a node in a tree represents. My argument is that based on what we have seen from the curation results, both are cdao:TUs.

Ah. I didn't state this, I simply quoted it from an earlier comment of @gaurav's. It's sometimes hard to see in email, one of the reasons I usually go to Github for commenting rather than email.

Coming in here somewhat blind, but two thoughts jumped to mind.

Why do you need to worry about the concept of a TU?  Isn't your core concept a "node TU"?  I.e. you don't want to define everything you could say about a TU, but rather the nature of the TU as it merges with the concept of a phylo node?  Perhaps constrain your new concept discussion to what is special about the concept of a TU as it relates to a phylo node.  In this vein it strikes me that the node concept must include something relating the nature of the (old) TU concept which includes some core evoluationary concept (e.g. DNA, or anatomy in the context of homology).  Those concepts (and/or others) must be present or the phylogeny (set of nodes/edges) is not a phylogeny.  I.e. I can make a tree of herbivocres and carnivores and omnivores, but I as a scientist don't want this to be interpretted as a phylogeny, why, because I have not asserted any data of a particular type (genetic, homology hyptheses).

So, do you need this/these properties?  What is gained? You already know the class of the thing that is part of(?) the node thanks to some other classification (e.g. dwc:Taxon).

With this pattern you're going to have enumerate every possible thing that can be part of a TU
I haven't looked hard at the ontology, it might exist, but can you have a general purpose property that includes stuff into a "node TU",  if need be you could restrict the property by domain;range (but this is also enumerating all possible things)
I.e. rather than assert that the thing in the TU is an X, assert that X is also a (node) TU.  Given 1) then you can infer that there is some "phylogenetic" information/data is recorded/asserted about X.

Because we're changing over to using property restrictions instead of TU individuals in our model (see https://github.com/phyloref/phyloref-ontology/issues/9#issuecomment-461604456 for a fuller write-up on how this looks), I think the question of including taxa in a taxonomic unit is now moot: a TU restriction will match another TU restriction only if the properties being restricted match, either directly (identical scientific names) or through other assertions (if we assert two scientific names as being synonymous, say). In this view, I'm not sure we will ever need to express the idea of multiple taxa being combined into a single TU, which is what this issue envisioned. Combining multiple TUs also makes it harder to clearly express how those TUs are related to each other, while relationships between scientific names and specimens should be easier to express thanks to ontologies like Nomen. Therefore, I think this line of development should be abandoned and this issue should be closed.

Good summary, @gaurav. I agree.


GROOVY-10710: operator == is slow when comparing primitive arrays and…

… lists

Applies the same treatment also to some primitive toSet operations which were double copying.


Unify lint tests into one workflow, one badge

Trying to clean up our initial attempt at Actions.
Needs to be integrated with #388
Closes #376

Moving this back to a draft. I got a reminder this morning that Ubuntu 20.04 test images are available, even if the ubuntu-latest target hasn't been moved forward. I'd like to try a matrix build against both 18 and 20 before merging this.

Scratch that, 20.04 is still in pre-release and I think Actions will upgrade -latest right about the time we're planning to move. Not worth the doubled runtime to pursue at this point, IMO.


Add hex.pm version badge

Use shields.io to render a badge with the latest hex-published version
Use markdown for badges

Pull Request Test Coverage Report for Build 49

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.561%

Totals

Change from base Build 43:
0.0%

Covered Lines:
411

Relevant Lines:
417

💛  - Coveralls

Thanks!


Sveltekit: missing-declaration

Removing the JS imports for components throws the missing-declaration error:

This would need to be suppressed.
Maybe add a hint on how to configure this in the svelte.config.js file.
(Unfortunately, I don't know how)

Are you using VSCode? It seems the warning message comes from one of its plugins

Isn't this by design? Nothing is informing the language service about the imports so it complains.
unplugin-vue-components solves this by generating a components.d.ts file that informs the language service about the components.
It looks like this:
// generated by unplugin-vue-components
// We suggest you to commit this file into source control
// Read more: https://github.com/vuejs/vue-next/pull/3399

declare module 'vue' {
  export interface GlobalComponents {
    Alert: typeof import('./components/Alert.vue')['default']
    Alerts: typeof import('./components/Alerts.vue')['default']
    Chart: typeof import('./components/Chart.vue')['default'];
    ChartExample: typeof import('./components/ChartExample.vue')['default']
    Donut: typeof import('./components/Donut.vue')['default'];
    FaSolidBolt: typeof import('~icons/fa-solid/bolt')['default']
    FaSolidCheckCircle: typeof import('~icons/fa-solid/check-circle')['default']
    FaSolidExclamationCircle: typeof import('~icons/fa-solid/exclamation-circle')['default']
    FaSolidInfoCircle: typeof import('~icons/fa-solid/info-circle')['default']
    FaSolidPlug: typeof import('~icons/fa-solid/plug')['default']
    FaSolidSlidersH: typeof import('~icons/fa-solid/sliders-h')['default']
    FaSolidTimesCircle: typeof import('~icons/fa-solid/times-circle')['default']
    Logo: typeof import('./components/Logo.vue')['default']
    LogView: typeof import('./components/LogView.vue')['default']
  }
}

export { }

@felixheidecke did you get this figured out? I'm still seeing this regardless of what I do in my d.ts file

The d.ts file will silence errors by typescript that it cannot find the module. The mentioned warning here is from the Svelte compiler, which cannot be silenced like this. There currently isn't a way to silence a warning across svelte-check, the ide and Kit through a single setting, but they all have ways to silence this on their own.

This sole issue is the only reason I avoid using this library.
You won't believe how many times I've been allured into using Nuxt 3 instead, just for this feature.

FYI, if you're willing to be a bit heavy-handed, you can disable this warning under the Svelte extension for VSCode:

This will at least suppress the warning and let you use the editor without red squigglies. @dummdidumm linked the other places you may have to suppress it.


how should i do to get the child dom's props  via react-test-renderer  unless using children in deep

Do you want to request a feature or report a bug?
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal repository on GitHub that we can npm install and npm test.
What is the expected behavior?
Run Jest again with --debug and provide the full configuration it prints. Please mention your node and npm version and operating system.

This is not a support forum, please ask your question on StackOverflow. Thank you!


Allow Database to connect to memory

Currently when you try to connect the Database class to :memory: it returns a FortifySQL error. Being able to connect to :memory: (a valid sqlite3 database) would be handy for some use cases

Fixed but unreleased

Fixed in 0.4.0


timezone

I've just recently installed a PV system with a goodwe inverter. When I installed it, the timezone was UTC+1 (CET) and this time was configured on the inverter. On the last weekend in March DST was set in the Netherlands. The time on the inverter remained in the UTC+1 timezone, the timezone on my computer which runs gw2pvo switched to CEST (UTC+2).
The data on the sems portal shows timestamps which correspond to UTC+1, same as the inverter.
The cfg file contains city = Amsterdam.
Timezone in pvoutput: UTC+1:00 Europe/Amsterdam
Adjust for DST = Both + manual = correct
Adjust for DST = None + manual = 1 hour behind
Adjust for DST = Both + systemd service = 1 hour ahead
Adjust for DST = None + systemd service = correct
manual command:
~/venv/bin/python ~/venv/bin/gw2pvo --config ~/gw2pvo.cfg --date $(date +%Y-%m-%d)
systemd service:
ExecStart=/home/gw2pvo/venv/bin/python /home/gw2pvo/venv/bin/gw2pvo --config /home/gw2pvo/gw2pvo.cfg
I'd like to have a setup whereby I don't need to change anything for DST changes. How do other users do this?

I changed the time on the inverter to the current time (UTC+2) yesterday. This morning is was changed back to UTC+1. I guess the inverter resets the time when it starts up.


generate project, svg inside image will appear error!

Environment

Operating System: Linux
Node Version:     v16.20.0
Nuxt Version:     3.6.5
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      vite
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-t1mz7m?file=app.vue
Describe the bug
npm run generate, it will show error that ELOOP: too many symbolic links encountered. The main reason the svg code inside image tag.
example:
<svg>
<path></path>
<image />
</svg>

How can avoid this error?
Additional context
No response
Logs
No response

Thanks! Let's track in https://github.com/unjs/nitro/issues/1527.


Wait for the driver test to settle before collecting screenshots

Sometimes the driver would tap the screenshot generating test before it was read. This fixes that.

@yjbanov