Public files are not copying to language directory on static build

Environment

Operating System: Darwin
Node Version:     v20.10.0
Nuxt Version:     3.9.0
CLI Version:      3.10.0
Nitro Version:    2.8.1
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      modules, app, css, devtools, runtimeConfig, features
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction

Start a new project
Add a script file from the public directory using useHead

useHead({
    title: 'Page Home',
    meta: [{ property: "og:title", content: "this is og title for about page" }],
    script: [
      {src: 'js/home2.js'}
    ]
  });

Add noScripts to nuxt.config.ts

export default defineNuxtConfig({
  modules: [
    [
      '@nuxtjs/i18n',
      {
        /* module options */
        locales: [
          {
            code: 'en',
            iso: 'en-US',
            name: 'English'
          },
          {
            code: 'es',
            iso: 'es-ES',
            name: 'Español'
          }
        ],
        defaultLocale: 'en',
        strategy: 'prefix_except_default',
        baseUrl: 'https://example.io'
      }
    ]
  ],
  app: {
    head: {
      charset: 'utf-8',
      viewport: 'width=device-width, initial-scale=1',
    }
  },
  css: ['~/assets/scss/_global.scss'],
  devtools: { enabled: true },
  },
  features: {
    noScripts: true
  }
})

Create a static build using npm run generate

Describe the bug
The provided js file in the useHead is working fine for the default language. ie., for English.
However for other locales, i.e., es (Spanish), the script URL in head becomes
https://example.io/es/js/home2.js

However, the home2.js file is not copied to the es directory resulting in a 404 error.the
Additional context
No response
Logs
No response

Closing this due to inactivity and lack of reproduction, if you're still experiencing this issue please open a new issue with a (minimal) reproduction.
Just a guess, have you tried changing the script path to have a leading / (e.g. {src: '/js/home2.js'})?


Add topic on runtimeconfig.json

Add topic on runtimeconfig.json
I couldn't find any topics on the file format and the set of options that you can configure with it.

Some info can be found here: https://github.com/dotnet/cli/blob/master/Documentation/specs/runtime-configuration-file.md


Error - failed version compatibility check with elasticsearch - fleet server on branch tls

Problem description
After setting up elk stack on tls using your docker-compose i would like to integrate fleet server with the stack.
Following your documentation I've set up fingerprint in kibana.yml that i get from running docker-compose up tls and in fleet-compose.yml as i saw that is perhaps required on some other issue
But when the fleet container is running i get the following log message being repeated from the fleet docker logs.
Extra information
{"log.level":"error","@timestamp":"2024-01-25T15:21:35.247Z","log.origin":{"file.name":"coordinator/coordinator.go","file.line":557},"message":"Unit state changed fleet-server-default (STARTING->FAILED): Error - failed version compatibility check with elasticsearch: EOF","log":{"source":"elastic-agent"},"component":{"id":"fleet-server-default","state":"HEALTHY"},"unit":{"id":"fleet-server-default","type":"output","state":"FAILED","old_state":"STARTING"},"ecs.version":"1.6.0"}`

Stack configuration

diff --git a/.env b/.env
index 7a556b7..ad046ae 100644
--- a/.env
+++ b/.env
@@ -7,36 +7,36 @@ ELASTIC_VERSION=8.11.4
 #
 # Superuser role, full access to cluster management and data indices.
 # https://www.elastic.co/guide/en/elasticsearch/reference/current/built-in-users.html
-ELASTIC_PASSWORD='changeme'
+ELASTIC_PASSWORD='xxxxxxxxx'

 # User 'logstash_internal' (custom)
 #
 # The user Logstash uses to connect and send data to Elasticsearch.
 # https://www.elastic.co/guide/en/logstash/current/ls-security.html
-LOGSTASH_INTERNAL_PASSWORD='changeme'
+LOGSTASH_INTERNAL_PASSWORD='xxxxx'

 # User 'kibana_system' (built-in)
 #
 # The user Kibana uses to connect and communicate with Elasticsearch.
 # https://www.elastic.co/guide/en/elasticsearch/reference/current/built-in-users.html
-KIBANA_SYSTEM_PASSWORD='changeme'
+KIBANA_SYSTEM_PASSWORD='xxxxxx'

 # Users 'metricbeat_internal', 'filebeat_internal' and 'heartbeat_internal' (custom)
 #
 # The users Beats use to connect and send data to Elasticsearch.
 # https://www.elastic.co/guide/en/beats/metricbeat/current/feature-roles.html
-METRICBEAT_INTERNAL_PASSWORD=''
-FILEBEAT_INTERNAL_PASSWORD=''
-HEARTBEAT_INTERNAL_PASSWORD=''
+METRICBEAT_INTERNAL_PASSWORD='xxxxx'
+FILEBEAT_INTERNAL_PASSWORD='xxxxxx'
+HEARTBEAT_INTERNAL_PASSWORD='xxxxx'
 # User 'monitoring_internal' (custom)
 #
 # The user Metricbeat uses to collect monitoring data from stack components.
 # https://www.elastic.co/guide/en/elasticsearch/reference/current/how-monitoring-works.html
-MONITORING_INTERNAL_PASSWORD=''
+MONITORING_INTERNAL_PASSWORD='xxxxx

 # User 'beats_system' (built-in)
 #
 # The user the Beats use when storing monitoring information in Elasticsearch.
 # https://www.elastic.co/guide/en/elasticsearch/reference/current/built-in-users.html
-BEATS_SYSTEM_PASSWORD=''
+BEATS_SYSTEM_PASSWORD='xxxxxxxxxx'
diff --git a/docker-compose.yml b/docker-compose.yml
index 8720347..cc5ddc6 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -84,7 +84,7 @@ services:
       - 9300:9300
     environment:
       node.name: elasticsearch
-      ES_JAVA_OPTS: -Xms512m -Xmx512m
+      ES_JAVA_OPTS: -Xms9000m -Xmx9000m
       # Bootstrap password.
       # Used to initialize the keystore during the initial startup of
       # Elasticsearch. Ignored on subsequent runs.
@@ -112,7 +112,7 @@ services:
       - 50000:50000/udp
       - 9600:9600
     environment:
-      LS_JAVA_OPTS: -Xms256m -Xmx256m
+      LS_JAVA_OPTS: -Xms4000m -Xmx5000m
       LOGSTASH_INTERNAL_PASSWORD: ${LOGSTASH_INTERNAL_PASSWORD:-}
     networks:
       - elk
diff --git a/extensions/fleet/fleet-compose.yml b/extensions/fleet/fleet-compose.yml
index 17486ee..9dd101b 100644
--- a/extensions/fleet/fleet-compose.yml
+++ b/extensions/fleet/fleet-compose.yml
@@ -21,6 +21,7 @@ services:
       FLEET_SERVER_CERT_KEY: /usr/share/elastic-agent/fleet-server.key
       ELASTICSEARCH_HOST: https://elasticsearch:9200
       ELASTICSEARCH_CA: /usr/share/elastic-agent/ca.crt
+      FLEET_SERVER_ELASTICSEARCH_CA_TRUSTED_FINGERPRINT: xxxxxx
       # Fleet plugin in Kibana
       KIBANA_FLEET_SETUP: '1'
       # Enrollment.
diff --git a/kibana/config/kibana.yml b/kibana/config/kibana.yml
index 7bbf738..e60bbca 100644
--- a/kibana/config/kibana.yml
+++ b/kibana/config/kibana.yml
@@ -27,7 +27,7 @@ elasticsearch.ssl.certificateAuthorities: [ config/ca.crt ]
 ## Communications between web browsers and Kibana
 ## see https://www.elastic.co/guide/en/kibana/current/configuring-tls.html#configuring-tls-browser-kib
 #
-server.ssl.enabled: false
+server.ssl.enabled: true
 server.ssl.certificate: config/kibana.crt
 server.ssl.key: config/kibana.key

@@ -55,7 +55,7 @@ xpack.fleet.outputs:
     type: elasticsearch
     hosts: [ https://elasticsearch:9200 ]
     # Set to output of 'docker-compose up tls'. Example:
-    #ca_trusted_fingerprint: xxxxxxx
+    ca_trusted_fingerprint: xxxxxx
     is_default: true
     is_default_monitoring: true

diff --git a/logstash/Dockerfile b/logstash/Dockerfile
index bde5808..71ab598 100644
--- a/logstash/Dockerfile
+++ b/logstash/Dockerfile
@@ -3,5 +3,14 @@ ARG ELASTIC_VERSION
 # https://www.docker.elastic.co/
 FROM docker.elastic.co/logstash/logstash:${ELASTIC_VERSION}

+
+# certs/keys for Beats and Lumberjack input
+USER root
+RUN mkdir -p /etc/pki/tls/{certs,private}
+ADD ./logstash-beats.crt /etc/pki/tls/certs/logstash-beats.crt
+ADD ./logstash-beats.key /etc/pki/tls/private/logstash-beats.key
+USER logstash
+
+
 # Add your logstash plugins setup here
 # Example: RUN logstash-plugin install logstash-filter-json
diff --git a/logstash/pipeline/logstash.conf b/logstash/pipeline/logstash.conf
deleted file mode 100644
index 5cb4708..0000000
--- a/logstash/pipeline/logstash.conf
+++ /dev/null
@@ -1,21 +0,0 @@
-input {
-       beats {
-               port => 5044
-       }
-
-       tcp {
-               port => 50000
-       }
-}
-
-## Add your filters / logstash plugins configuration here
-
-output {
-       elasticsearch {
-               hosts => "elasticsearch:9200"
-               user => "logstash_internal"
-               password => "${LOGSTASH_INTERNAL_PASSWORD}"
-               ssl => true
-               cacert => "config/ca.crt"
-       }
-}

Docker setup
Client:
 Version:           24.0.5
 API version:       1.43
 Go version:        go1.20.3
 Git commit:        24.0.5-0ubuntu1~22.04.1
 Built:             Mon Aug 21 19:50:14 2023
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          24.0.5
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.3
  Git commit:       24.0.5-0ubuntu1~22.04.1
  Built:            Mon Aug 21 19:50:14 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.7.2
  GitCommit:
 runc:
  Version:          1.1.7-0ubuntu1~22.04.1
  GitCommit:
 docker-init:
  Version:          0.19.0
  GitCommit:

docker-compose version 1.29.2, build unknown
docker-py version: 5.0.3
CPython version: 3.10.12
OpenSSL version: OpenSSL 3.0.2 15 Mar 2022

Container logs
KIBANA
kibana_1         | [2024-01-25T15:21:10.671+00:00][WARN ][plugins.licensing] License information could not be obtained from Elasticsearch due to ConnectionError: connect ECONNREFUSED <IP_ADDRESS>:9200 error
kibana_1         | [2024-01-25T15:21:20.718+00:00][ERROR][plugins.security.authentication] License is not available, authentication is not possible.
kibana_1         | [2024-01-25T15:21:20.728+00:00][WARN ][plugins.licensing] License information could not be obtained from Elasticsearch due to ConnectionError: connect ECONNREFUSED <IP_ADDRESS>:9200 error
kibana_1         | [2024-01-25T15:21:21.676+00:00][ERROR][plugins.security.authentication] License is not available, authentication is not possible.
kibana_1         | [2024-01-25T15:21:21.688+00:00][WARN ][plugins.licensing] License information could not be obtained from Elasticsearch due to ConnectionError: connect ECONNREFUSED <IP_ADDRESS>:9200 error
kibana_1         | [2024-01-25T15:21:29.890+00:00][ERROR][elasticsearch-service] Unable to retrieve version information from Elasticsearch nodes. security_exception
kibana_1         |      Root causes:
kibana_1         |              security_exception: unable to authenticate user [kibana_system] for REST request [/_nodes?filter_path=nodes.*.version%2Cnodes.*.http.publish_address%2Cnodes.*.ip]
kibana_1         | [2024-01-25T15:21:31.746+00:00][ERROR][plugins.security.authentication] License is not available, authentication is not possible.
kibana_1         | [2024-01-25T15:21:31.766+00:00][INFO ][plugins.monitoring.monitoring.kibana-monitoring] Starting monitoring stats collection
kibana_1         | [2024-01-25T15:21:31.837+00:00][INFO ][plugins.fleet] Agent policies updated by license change: []
kibana_1         | [2024-01-25T15:21:32.562+00:00][INFO ][status] Kibana is now available (was critical)
kibana_1         | [2024-01-25T15:21:32.667+00:00][INFO ][status] Kibana is now degraded (was available)
kibana_1         | [2024-01-25T15:21:33.058+00:00][INFO ][plugins.fleet] Fleet Usage: {"agents_enabled":true,"agents":{"total_enrolled":0,"healthy":0,"unhealthy":0,"offline":0,"inactive":0,"unenrolled":0,"total_all_statuses":0,"updating":0},"fleet_server":{"total_enrolled":0,"healthy":0,"unhealthy":0,"offline":0,"updating":0,"total_all_statuses":0,"num_host_urls":1}}
kibana_1         | [2024-01-25T15:21:38.528+00:00][INFO ][status] Kibana is now available (was degraded)
kibana_1         | [2024-01-25T15:36:35.605+00:00][INFO ][plugins.fleet] Fleet Usage: {"agents_enabled":true,"agents":{"total_enrolled":0,"healthy":0,"unhealthy":0,"offline":0,"inactive":0,"unenrolled":0,"total_all_statuses":0,"updating":0},"fleet_server":{"total_enrolled":0,"healthy":0,"unhealthy":0,"offline":0,"updating":0,"total_all_statuses":0,"num_host_urls":1}}
kibana_1         | [2024-01-25T15:51:35.690+00:00][INFO ][plugins.fleet] Fleet Usage: {"agents_enabled":true,"agents":{"total_enrolled":0,"healthy":0,"unhealthy":0,"offline":0,"inactive":0,"unenrolled":0,"total_all_statuses":0,"updating":0},"fleet_server":{"total_enrolled":0,"healthy":0,"unhealthy":0,"offline":0,"updating":0,"total_all_statuses":0,"num_host_urls":1}}

ELASTIC-SEARCH
elasticsearch_1  | {"@timestamp":"2024-01-25T16:14:13.390Z", "log.level": "WARN", "message":"received plaintext http traffic on an https channel, closing connection Netty4HttpChannel{localAddress=/<IP_ADDRESS>:9200, remoteAddress=/<IP_ADDRESS>:42440}", "ecs.version": "1.2.0","service.name":"ES_ECS","event.dataset":"elasticsearch.server","process.thread.name":"elasticsearch[elasticsearch][transport_worker][T#4]","log.logger":"org.elasticsearch.http.netty4.Netty4HttpServerTransport","elasticsearch.cluster.uuid":"fJcSqqO5SqyHacd0EqrkUw","elasticsearch.node.id":"nO4mwj7GT1ibYUBl2h7LZQ","elasticsearch.node.name":"elasticsearch","elasticsearch.cluster.name":"docker-cluster"}
elasticsearch_1  | {"@timestamp":"2024-01-25T16:14:15.393Z", "log.level": "WARN", "message":"received plaintext http traffic on an https channel, closing connection Netty4HttpChannel{localAddress=/<IP_ADDRESS>:9200, remoteAddress=/<IP_ADDRESS>:36918}", "ecs.version": "1.2.0","service.name":"ES_ECS","event.dataset":"elasticsearch.server","process.thread.name":"elasticsearch[elasticsearch][transport_worker][T#6]","log.logger":"org.elasticsearch.http.netty4.Netty4HttpServerTransport","elasticsearch.cluster.uuid":"fJcSqqO5SqyHacd0EqrkUw","elasticsearch.node.id":"nO4mwj7GT1ibYUBl2h7LZQ","elasticsearch.node.name":"elasticsearch","elasticsearch.cluster.name":"docker-cluster"}
elasticsearch_1  | {"@timestamp":"2024-01-25T16:14:15.394Z", "log.level": "WARN", "message":"received plaintext http traffic on an https channel, closing connection Netty4HttpChannel{localAddress=/<IP_ADDRESS>:9200, remoteAddress=/<IP_ADDRESS>:36932}", "ecs.version": "1.2.0","service.name":"ES_ECS","event.dataset":"elasticsearch.server","process.thread.name":"elasticsearch[elasticsearch][transport_worker][T#7]","log.logger":"org.elasticsearch.http.netty4.Netty4HttpServerTransport","elasticsearch.cluster.uuid":"fJcSqqO5SqyHacd0EqrkUw","elasticsearch.node.id":"nO4mwj7GT1ibYUBl2h7LZQ","elasticsearch.node.name":"elasticsearch","elasticsearch.cluster.name":"docker-cluster"}
elasticsearch_1  | {"@timestamp":"2024-01-25T16:14:15.396Z", "log.level": "WARN", "message":"received plaintext http traffic on an https channel, closing connection Netty4HttpChannel{localAddress=/<IP_ADDRESS>:9200, remoteAddress=/<IP_ADDRESS>:36940}", "ecs.version": "1.2.0","service.name":"ES_ECS","event.dataset":"elasticsearch.server","process.thread.name":"elasticsearch[elasticsearch][transport_worker][T#8]","log.logger":"org.elasticsearch.http.netty4.Netty4HttpServerTransport","elasticsearch.cluster.uuid":"fJcSqqO5SqyHacd0EqrkUw","elasticsearch.node.id":"nO4mwj7GT1ibYUBl2h7LZQ","elasticsearch.node.name":"elasticsearch","elasticsearch.cluster.name":"docker-cluster"}
elasticsearch_1  | {"@timestamp":"2024-01-25T16:14:15.397Z", "log.level": "WARN", "message":"received plaintext http traffic on an https channel, closing connection Netty4HttpChannel{localAddress=/<IP_ADDRESS>:9200, remoteAddress=/<IP_ADDRESS>:36948}", "ecs.version": "1.2.0","service.name":"ES_ECS","event.dataset":"elasticsearch.server","process.thread.name":"elasticsearch[elasticsearch][transport_worker][T#9]","log.logger":"org.elasticsearch.http.netty4.Netty4HttpServerTransport","elasticsearch.cluster.uuid":"fJcSqqO5SqyHacd0EqrkUw","elasticsearch.node.id":"nO4mwj7GT1ibYUBl2h7LZQ","elasticsearch.node.name":"elasticsearch","elasticsearch.cluster.name":"docker-cluster"}

<IP_ADDRESS> is fleet docker
fleet-compose.yml
version: '3.7'

services:
  fleet-server:
    build:
      context: extensions/fleet/
      args:
        ELASTIC_VERSION: ${ELASTIC_VERSION}
    volumes:
      - fleet-server:/usr/share/elastic-agent/state:Z
      # (!) TLS certificates. Generate using the 'tls' service.
      - ./tls/certs/ca/ca.crt:/usr/share/elastic-agent/ca.crt:ro,z
      - ./tls/certs/fleet-server/fleet-server.crt:/usr/share/elastic-agent/fleet-server.crt:ro,Z
      - ./tls/certs/fleet-server/fleet-server.key:/usr/share/elastic-agent/fleet-server.key:ro,Z
    environment:
      FLEET_SERVER_ENABLE: '1'
      FLEET_SERVER_HOST: <IP_ADDRESS>
      FLEET_SERVER_POLICY_ID: fleet-server-policy
      FLEET_URL: https://fleet-server:8220
      FLEET_SERVER_CERT: /usr/share/elastic-agent/fleet-server.crt
      FLEET_SERVER_CERT_KEY: /usr/share/elastic-agent/fleet-server.key
      ELASTICSEARCH_HOST: https://elasticsearch:9200
      ELASTICSEARCH_CA: /usr/share/elastic-agent/ca.crt
      FLEET_SERVER_ELASTICSEARCH_CA_TRUSTED_FINGERPRINT: xxxxxx
      # Fleet plugin in Kibana
      KIBANA_FLEET_SETUP: '1'
      # Enrollment.
      # (a) Auto-enroll using basic authentication
      ELASTICSEARCH_USERNAME: elastic
      ELASTICSEARCH_PASSWORD: ${ELASTIC_PASSWORD:-}
      # (b) Enroll using a pre-generated service token
      #FLEET_SERVER_SERVICE_TOKEN: <service_token>
    ports:
      - 8220:8220
    hostname: fleet-server
    # Elastic Agent does not retry failed connections to Kibana upon the initial enrollment phase.
    restart: on-failure
    networks:
      - elk
    depends_on:
      - elasticsearch
      - kibana

volumes:
  fleet-server:

Thanks for the detailed report :+1:
With just a few log lines it is difficult to tell what is going on. Sometimes the reason for something not working is not directly visible inside WARN/ERROR log entries, but instead scattered around the logs.
Are you seeing the Fleet server inside Kibana?
I noted a few things:

"plain text" errors could indicate that you didn't rebuild images after switching branches (see README)
The FLEET_SERVER_ELASTICSEARCH_CA_TRUSTED_FINGERPRINT variable is not necessary. The Elasticsearch CA certificate is already mounted inside the Fleet Server container. Only the kibana.yml file requires this fingerprint.

 Sometimes the reason for something not working is not directly visible inside WARN/ERROR log entries, but instead scattered around the logs.
Are you seeing the Fleet server inside Kibana?
I noted a few things:

"plain text" errors could indicate that you didn't rebuild images after switching branches (see README)
The FLEET_SERVER_ELASTICSEARCH_CA_TRUSTED_FINGERPRINT variable is not necessary. The Elasticsearch CA certificate is already mounted inside the Fleet Server container. Only the kibana.yml file requires this fingerprint.

Thanks for the fast reply!
what more logs you need? elastic search just repeats that whole line for the whole buffer.
I dont see the fleet server inside kibana

its allready rebuilded:
user@host:/etc/elastic-stack/docker-elk# docker-compose -f docker-compose.yml -f extensions/metricbeat/metricbeat-compose.yml -f extensions/filebeat/filebeat-compose.yml -f extensions/heartbeat/heartbeat-compose.yml -f extensions/logspout/logspout-compose.yml -f extensions/fleet/fleet-compose.yml build
Building elasticsearch
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

Sending build context to Docker daemon  5.632kB
Step 1/2 : ARG ELASTIC_VERSION
Step 2/2 : FROM docker.elastic.co/elasticsearch/elasticsearch:${ELASTIC_VERSION}
 ---> b7c0bf7f2e52
Successfully built b7c0bf7f2e52
Successfully tagged docker-elk_elasticsearch:latest
Building metricbeat
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

Sending build context to Docker daemon  11.78kB
Step 1/2 : ARG ELASTIC_VERSION
Step 2/2 : FROM docker.elastic.co/beats/metricbeat:${ELASTIC_VERSION}
 ---> 9f5035931f3d
Successfully built 9f5035931f3d
Successfully tagged docker-elk_metricbeat:latest
Building filebeat
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

Sending build context to Docker daemon  10.24kB
Step 1/2 : ARG ELASTIC_VERSION
Step 2/2 : FROM docker.elastic.co/beats/filebeat:${ELASTIC_VERSION}
 ---> 7c0012435993
Successfully built 7c0012435993
Successfully tagged docker-elk_filebeat:latest
Building kibana
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

Sending build context to Docker daemon  14.85kB
Step 1/2 : ARG ELASTIC_VERSION
Step 2/2 : FROM docker.elastic.co/kibana/kibana:${ELASTIC_VERSION}
 ---> a5ee2c00b338
Successfully built a5ee2c00b338
Successfully tagged docker-elk_kibana:latest
Building fleet-server
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

Sending build context to Docker daemon  19.97kB
Step 1/3 : ARG ELASTIC_VERSION
Step 2/3 : FROM docker.elastic.co/beats/elastic-agent:${ELASTIC_VERSION}
 ---> 69a3e94d378d
Step 3/3 : RUN mkdir state
 ---> Using cache
 ---> cf291c5d6d6e
Successfully built cf291c5d6d6e
Successfully tagged docker-elk_fleet-server:latest
Building logstash
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

Sending build context to Docker daemon  33.79kB
Step 1/7 : ARG ELASTIC_VERSION
Step 2/7 : FROM docker.elastic.co/logstash/logstash:${ELASTIC_VERSION}
 ---> d3299608a390
Step 3/7 : USER root
 ---> Using cache
 ---> 582d5d80ef66
Step 4/7 : RUN mkdir -p /etc/pki/tls/{certs,private}
 ---> Using cache
 ---> 832d1896e9b1
Step 5/7 : ADD ./logstash-beats.crt /etc/pki/tls/certs/logstash-beats.crt
 ---> Using cache
 ---> 2f357c084d4e
Step 6/7 : ADD ./logstash-beats.key /etc/pki/tls/private/logstash-beats.key
 ---> Using cache
 ---> 3f416862328f
Step 7/7 : USER logstash
 ---> Using cache
 ---> 090723fffaaa
Successfully built 090723fffaaa
Successfully tagged docker-elk_logstash:latest
Building logspout
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

Sending build context to Docker daemon   7.68kB
Step 1/2 : FROM gliderlabs/logspout:master
# Executing 3 build triggers
 ---> Using cache
 ---> Using cache
 ---> Using cache
 ---> a0594aaf2145
Step 2/2 : ENV SYSLOG_FORMAT rfc3164
 ---> Using cache
 ---> e31afb72e052
Successfully built e31afb72e052
Successfully tagged docker-elk_logspout:latest
Building heartbeat
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

Sending build context to Docker daemon  9.728kB
Step 1/2 : ARG ELASTIC_VERSION
Step 2/2 : FROM docker.elastic.co/beats/heartbeat:${ELASTIC_VERSION}
 ---> ea7959d45f2d
Successfully built ea7959d45f2d
Successfully tagged docker-elk_heartbeat:latest
user@host:/etc/elastic-stack/docker-elk# docker-compose -f docker-compose.yml -f extensions/metricbeat/metricbeat-compose.yml -f extensions/filebeat/filebeat-compose.yml -f extensions/heartbeat/heartbeat-compose.yml -f extensions/logspout/logspout-compose.yml -f extensions/fleet/fleet-compose.yml up -d
docker-elk_elasticsearch_1 is up-to-date
docker-elk_kibana_1 is up-to-date
docker-elk_heartbeat_1 is up-to-date
docker-elk_metricbeat_1 is up-to-date
docker-elk_logstash_1 is up-to-date
docker-elk_filebeat_1 is up-to-date
docker-elk_fleet-server_1 is up-to-date
docker-elk_logspout_1 is up-to-date

Ok thanks for confirming about the image builds.
Right now the issue is not obvious to me. I wasn't able to reproduce and the automated tests are still passing. I'll try to dig a bit more during the weekend.

I have a theory.
Could it be that Kibana was originally set up on the main branch, and registered the following Elasticsearch output while bootstrapping the Fleet configuration?:
https://github.com/deviantony/docker-elk/blob/eeb8026baf5f9550bf0ac01e63b9b3d16e7b0e0d/kibana/config/kibana.yml#L30-L39
You should be able to check the Elasticsearch URL propagated to Fleet agents on the Settings tab of the Fleet menu, as described in the docs.

All good, it seems like Kibana did update the output's URL.
If your stack does not contain any critical data, would you mind trying a complete reset as follows? (notice the -v flag for "delete volumes")
https://github.com/deviantony/docker-elk/blob/2f8d50d9807d74c683c47747ba0b7e4866143bef/.github/workflows/ci.yml#L241-L250

ive made a new vm and deployed it from the get go before making my configurations to my needs as done in the old vm.
fleet is working and is recognized from the start in kibana ui. all i done at the cloned repo files was inserting the fingerprint.
ill continue with my configurations and let you know what breaks the fleet if at all. Thanks for the help!


Intermittent Network Overloads and Connection Drops When Accessing Blackett from UoM

According to conversations between @rwf14f, @shaikhhasib, this is a known problem, and a temporary fix is to connect to it from outside UoM.
Edit: symptom and background: UoM has its own firewall and Blackett while geographically located within UoM, has their own firewall outside UoM. Connections from within UoM to Blackett are mostly fine, but sometimes it will just disconnect and succeeding reconnection refused.

@shaikhhasib, have you experienced the same issue lately? Do you know if it was fixed already?

@ickc, its hasn't change, it break the connection

Thanks.
By the way, did @earosenberg experience this too? Is it a big problem?

I've had slow data transfer rates (~45 mins to transfer 1GB python tarball from my laptop by sftp) but not sure if this is the same problem

@earosenberg, sorry, this issue is not well documented. I changed the title and add a text:

symptom and background: UoM has its own firewall and Blackett while geographically located within UoM, has their own firewall outside UoM. Connections from within UoM to Blackett are mostly fine, but sometimes it will just disconnect and succeeding reconnection refused.

Regarding throughput from your laptop, I'll open a new issue tracking that.

From an internal conversation, it seems that an internal link is saturating so it is a "won't fix".


Arent we able to customize the listtile?

This package looks great but it doesnt seem to be possible to customize the listtile? So this list only allows to display a single String in the listtile? What if i want each name to be tapable in order to select them like lets say in whatsapp when you want to create a new chat you can select members to join the chat.

We'll have a look into this.


Python binding is broken: it ignores PYTHON_EXECUTABLE and installs into a wrong prefix

When multiple puthon versions are installed PYTHON_EXECUTABLE is used to set which python to use.

I set PYTHON_EXECUTABLE=/usr/local/bin/python3.8 but 3.10 is still used

It installs python binding into the root directory / instead of the python site libs folder.

Hello, @yurivict . I imagine that you are trying to distribute OTIO in FreeBSD? I found https://github.com/freebsd/freebsd-ports/tree/main/multimedia/opentimelineio, but my FreeBSD knowledge is... non existent. But's I'll try to answer your questions or help you as best as I can.

When multiple puthon versions are installed PYTHON_EXECUTABLE is used to set which python to use.
I set PYTHON_EXECUTABLE=/usr/local/bin/python3.8 but 3.10 is still used

You will need to set Python_EXECUTABLE, not PYTHON_EXECUTABLE. See https://github.com/PixarAnimationStudios/OpenTimelineIO/blob/main/setup.py#L88 as a reference.
But that makes me wonder how are you building OTIO right now? Aren't are you going through the setup.py?

It installs python binding into the root directory / instead of the python site libs folder.

I'm lacking a little bit of details, here (regarding how you build), but I would guess that OTIO_PYTHON_INSTALL_DIR isn't set.
If you have some builds logs that you can share, I'll be more than happy to look at them to confirm what I just said applies to you. Any additional information you have will help us help you.

You will need to set Python_EXECUTABLE [...]

This works, thanks.

But that makes me wonder how are you building OTIO right now? Aren't are you going through the setup.py?

I use cmake with PYTHON=ON.

So this appears to be a bug that it doesn't install the python files when PYTHON=ON.
On the other hand, using setup.py is a more suitable way for FreeBSD ports because it installs the binding separately.

So this appears to be a bug that it doesn't install the python files when PYTHON=ON.

OTIO doesn't know what is PYTHON. It knows about OTIO_PYTHON_INSTALL.
But yes I agree that if you can install OTIO using the setup.py, that is our preferred (and only officially supported) option to install the python bindings.
Though, just as a side note, it won't build the C++ libraries and install the C++ headers. It will simply build everything statically and create the python bindings. You can see that here: https://github.com/PixarAnimationStudios/OpenTimelineIO/blob/main/setup.py#L90-L91.
If you want to have the C++ libraries build as shared libraries and have the Python extension link against these, then you will have to invoke cmake manually. The variables Python_EXECUTABLE="path o interpreter", OTIO_PYTHON_INSTALL=ON, OTIO_SHARED_LIBS=ON, OTIO_CXX_INSTALL=ON and OTIO_PYTHON_INSTALL_DIR="path to site-packages" will need to be passed to CMake.

Sorry, I meant OTIO_PYTHON_INSTALL.

Some projects install python files with a cmake option, some others don't. This can be confusing for users. IMO both ways to install python files should work to avoid confusion in the future,

If you want to have the C++ libraries build as shared libraries and have the Python extension link against these, then you will have to invoke cmake manually.

Ideally setup.py should be able to link against shared libraries built and installed by the C++ project, but I guess you don't currently support it.

Is that the resolution, allowing setup.py to use an externally supplied set of OTIO libs, in addition to the present mechanism? That sounds fine to me.


rRTSPServer issue with Yi Home new firmware <IP_ADDRESS>_202007141512

I've different Yi Home cams on my project and I've encountered some issues with RTSP Server which stops working after a certain amount of time, especially at day when image changes are high. I've looked at the #204 issue and installed the last rRTSPServer.gz compiled version of rRTSPServer by @roleoroleo which nicely solved my issue.
However, when I've installed this new compiled RTSP Server on my last fresh Yi Home camera with the new firmware <IP_ADDRESS>_202007141512, the streams is working any more, I've tested the low res.
As you can see, I've renamed the original rRTSPServer as rRTSPServer.ori and put the new compiled one.

I'm using the y21ga Allwinner-v2 firmware for this camera.
When I launch manually the server by
RRTSP_AUDIO=yes RRTSP_RES=both RRTSP_DEBUG=1 ./rRTSPServer
I got this log (extract) :

and streams is not working with VLC client.
If I re-run the original rRTSPServer.ori to get the stream back, I got this log :

Maybe, is it due to the y21ga hack firmware for my camera or something is going wrong with stream descriptor...
I've to deep dived in the rRTSP code to find some explanations or if you have any idea @roleoroleo :-)
Thanks a lot for your work anyway !

You can't use the binary from this hack to the Allwinner-v2 version.
The frame buffer where rRTSPServer extracts the stream is different.

You can't use the binary from this hack to the Allwinner-v2 version.
The frame buffer where rRTSPServer extracts the stream is different.

I suspected it indeed... is there a branch where I could find your modified rRTSPServer sources and see what could I do with the Allwinner-v2 platform ? Thanks @roleoroleo

I suspected it indeed... is there a branch where I could find your modified rRTSPServer sources and see what could I do with the Allwinner-v2 platform ? Thanks @roleoroleo

Check the allwinner-v2 repo:
https://github.com/roleoroleo/yi-hack-Allwinner-v2

Check the allwinner-v2 repo:
https://github.com/roleoroleo/yi-hack-Allwinner-v2

are your recent changes on rRTSPServer available on the Allwinner repo ? (I mean changes to get your last rRTSPServer.gz file) I will compare them with the Allwinner-v2 src files to see if I could fix it with the new frame buffer. Thanks.

are your recent changes on rRTSPServer available on the Allwinner repo ? (I mean changes to get your last rRTSPServer.gz file) I will compare them with the Allwinner-v2 src files to see if I could fix it with the new frame buffer. Thanks.

I pushed the last changes 15 minutes ago.
I ported the changes from allwinner to allwinner-v2 but I need to test them.

I pushed the last changes 15 minutes ago.
I ported the changes from allwinner to allwinner-v2 but I need to test them.

yes I've just seen your changes @roleoroleo ;-) Thanks for this great push, hope tests will go well, I will try to compile it on my side to test on my camera.

yes I've just seen your changes @roleoroleo ;-) Thanks for this great push, hope tests will go well, I will try to compile it on my side to test on my camera.

@roleoroleo could you provide the new rRTSPServer.gz for the Allwinner-v2 platform please as I'm not able to compile source files, I do not have the livemedia subdirectory for compiling. I'm compiling within a docker container but seems that I do not have all requirements for compiling.
Thanks. Have a good day !

@roleoroleo could you provide the new rRTSPServer.gz for the Allwinner-v2 platform please as I'm not able to compile source files, I do not have the livemedia subdirectory for compiling. I'm compiling within a docker container but seems that I do not have all requirements for compiling.
Thanks. Have a good day !

Please open a new issue in the v2 repo.
I don't want to upload a file here, it could be confusing.

Please open a new issue in the v2 repo.
I don't want to upload a file here, it could be confusing.

you're right @roleoroleo, I will put my request there. Thanks

you're right @roleoroleo, I will put my request there. Thanks


Can add support for CocoaPods.

Hi,
Thank you for wring this great library.
Any specific reason it's not on CocoaPods?

Hi,
Thank you for wring this great library.
Any specific reason it's not on CocoaPods?

Hello there,
No, just I'm not fan of using coca pods. :)
If you believe this can be helpful, please feel free to open a PR and add support for it so I can merge it into the code.


Allow the final parameter to include slashes

If the final parameter ends with '...', it should be allowed to include slashes (like in beeline).
Example: the route  /files/:user/:path... should match the URL /files/zocky/path/to/a/file and this.params.path should then be path/to/a/file.

++

Is there any way to setup a wildcard path like this now?

:+1:

This is easy to achieve with /files/:user/:path(.*)


xml regex validator failing

If the xml report has the keys in a different order than in the regex, e.g.
<?xml version="1.0" ?> <coverage branch-rate="0" branches-covered="0" branches-valid="0" complexity="0" line-rate="0.789" lines-covered="344" lines-valid="436" timestamp="1662319474790" version="6.4.4">
the regex in your action code is .*<coverage.*lines-valid="(?<total>[\\d\\.]+)".*lines-covered="(?<covered>[\\d\\.]+)".*line-rate="(?<ratio>[\\d\\.]+)"
which doesnt validate, the xml attributes are just in a different order than expected.

Hey @rienafairefr  thank you for your issue!
How do you make the coverage report? which package & which version
If you use pytest-cov can you update to pytest-cov==3.0.0 and retry please?
Thanks

coverage.py version 6.4.4, running pytest under it, without pytest-cov. In the end I'm using another action (irongut/CodeCoverageSummary)

Should work now! @rienafairefr you. Can you can retry to run this action


gracefully fail with unsupported HTTP methods

Codecov Report

Merging #102 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #102      +/-   ##
============================================
+ Coverage     79.59%   79.61%   +0.01%
- Complexity     1644     1646       +2
============================================
  Files           156      156
  Lines          5529     5534       +5
  Branches        712      713       +1
============================================
+ Hits           4401     4406       +5
  Misses          849      849
  Partials        279      279

Impacted Files
Coverage Δ
Complexity Δ

...m/google/api/server/spi/dispatcher/HttpMethod.java
100% <100%> (ø)
2 <1> (+1)
:arrow_up:

...ogle/api/server/spi/dispatcher/PathDispatcher.java
100% <100%> (ø)
5 <0> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af49d7...e5a37e6. Read the comment docs.


state.route not updated after navigate event triggered by pushState

Expected behavior
Expecting to have my subscription to the navigate event trigger and report the current (as in just navigated to) route in state.route
Actual behavior
I see the initial route reported in the navigate listener, ie. showing a state.route equal to / after I trigger emit('pushState', '/shazam') rather than state.route equal to /shazam.
Steps to reproduce behavior
See my gist https://gist.github.com/akiva/fed503aed3a76be6bbf1dada30f9018b, which is using choo@next.

Closing as a dupe of #530  (re-open this if i'm missing something but they seem to be the same issue)


issue 21 + strategy unit testing

Hello @GaetanDu! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file autopycoin/layers/nbeats_layers.py:

Line 94:80: E501 line too long (86 > 79 characters)
Line 229:80: E501 line too long (80 > 79 characters)

In the file autopycoin/layers/strategy.py:

Line 29:80: E501 line too long (119 > 79 characters)
Line 68:1: E302 expected 2 blank lines, found 1

In the file autopycoin/layers/strategy_test.py:

Line 42:32: E261 at least two spaces before inline comment
Line 42:80: E501 line too long (120 > 79 characters)
Line 53:80: E501 line too long (80 > 79 characters)

In the file autopycoin/models/nbeats_test.py:

Line 566:80: E501 line too long (129 > 79 characters)


Remove SMIRFF/SMIRNOFF remnants from this repo

We've now migrated the SMIRNOFF forcefield to a new repo:
http://github.com/open-forcefield-group/smirnoff
I was able to preserve commit history on all files that made the transition, though renaming smarty to smirnoff makes it harder to view this history in github.
Once that is stable, we should remove SMIRNOFF from this repo.

Excellent, thanks, @jchodera !!

Let's hold on this until I update the new repo according to our slack discussion.

I have completed the bulk of the reorganization in https://github.com/open-forcefield-group/openforcefield. Please go there and comment/contribute PRs!

We have now completed the migration to http://github.com/open-forcefield-group/openforcefield, so should remove SMIRNOFF and ChemicalEnvironment from this repo.

Agreed. Just haven't had the time to do anything about it - still catching up after last week.

I have this working on my local machine. I'm working on changing the travis settings so the tests on github will work.
See pull request #250

Thanks, @bannanc .

This was fixed in openforcefield PR#7


PROXY as global in http.lua

Line 189 and 201 uses global variable PROXY.
It breaks my tests as I am using a strict globals checker to make sure no globals were declared.
This was fixed 5 Jul 2013 in https://github.com/diegonehab/luasocket/commit/1f9ccb2b586c3a7e29db3c99a23ac1cee6907cf2 but the patch was not released as a rock yet.
Since latest release(v3.0-rc1) was quite some time ago - 14 Jun 2013, when can I expect a new release that fixes that issue?

@diegonehab do you have time to review/merge the pull requests @catwell mentioned?

:+1: For now I have to patch all occurrences of http.lua I find (e.g. in ZeroBrane Studio). I'd prefer a released version with the fix

Which one are you taking about? The HTTP proxy one 110? Although it is open, isn't the code merged anyway? The uClibc one (#90) has conflicts. If it is adjusted and tested, I can merge. I need someone to take charge of #81 and test it properly, as it seems to be a delicate change. #101 is not a big deal, and if somebody tests it I can also merge.

@jjvbsag ?

Sorry, was busy on the job...
This is the patch, I'm talking about:
--- http.lua.orig	2018-11-03 10:54:52.997376028 +0100
+++ http.lua	2018-11-03 10:55:33.496561255 +0100
@@ -186,7 +186,7 @@
 local function adjusturi(reqt)
     local u = reqt
     -- if there is a proxy, we need the full url. otherwise, just a part.
-    if not reqt.proxy and not PROXY then
+    if not reqt.proxy and not _M.PROXY then
         u = {
            path = socket.try(reqt.path, "invalid path 'nil'"),
            params = reqt.params,
@@ -198,7 +198,7 @@
 end

 local function adjustproxy(reqt)
-    local proxy = reqt.proxy or PROXY
+    local proxy = reqt.proxy or _M.PROXY
     if proxy then
         proxy = url.parse(proxy)
         return proxy.host, proxy.port or 3128

See also pkulchenko/ZeroBraneStudio#950 for how to reproduce
(the second issue mentioned there is already fixed in your master)

About testing. For me it is all about a project on an ARM target. I am willing to try anything there, but as the project time line is extremely tight I can make no promises about when...

Will the tagging of a new release solve this problem?
We're reviewing open items in preparation for a release.  If action is needed here, please add a comment.  Otherwise, this issue will be closed on or after 24-Feb-2019.
Thanks!

Hi! Its in the master branch, so releasing a new tagged version seems fine for me...
Regards

This issue has been fixed for a long time and a release has been shipped since then, closing.


Add rules_testing to BCR

cc @comius

looks like the failures here are real

Ok, fixed, I think; I guess we'll see what CI says.
Couple questions:

Are the files under the versioned directory still needed if bazelbuild/rules_testing is already setup with BCR pushing? Or can we simply add the metadata.json file? bcr push config
I think I've got bazelbuild/rules_testing setup with BCR pushing correctly, but it fails with this error:

Could not find a candidate bazel-central-registry fork to push to.
Publish to BCR must be installed to a BCR fork in either:
  a) the same account as the ruleset
  b) the release author's account
Install the app here: https://github.com/apps/publish-to-bcr.

As far as I can tell, I've done that. So I'm not sure if this error is trying to say "you have to do something in bazel-central-repository first" or if there's some other config thing somewhere I need to do.

@kormide

Ok, fixed, I think; I guess we'll see what CI says.
Couple questions:
* Are the files under the versioned directory still needed if bazelbuild/rules_testing is already setup with BCR pushing? Or can we simply add the metadata.json file? [bcr push config](https://github.com/bazelbuild/rules_testing/tree/master/.bcr)

The app requires all of the template files. Any changes you make to the metadata file (e.g., updating maintainers) get reflected in the pull request made by the bot.

* I _think_ I've got bazelbuild/rules_testing setup with BCR pushing correctly, but it fails with this error:

Could not find a candidate bazel-central-registry fork to push to.
Publish to BCR must be installed to a BCR fork in either:
  a) the same account as the ruleset
  b) the release author's account
Install the app here: https://github.com/apps/publish-to-bcr.

As far as I can tell, I've done that. So I'm not sure if this error is trying to say "you have to do something in bazel-central-repository first" or if there's some other config thing somewhere I need to do.

Weird. You've installed the app to rickeylev/bazel-central-registry?

You've installed the app to rickeylev/bazel-central-registry

Ah, no I had not. I just installed it in bazelbuild/rules_testing. I've installed it now to mine and it looks like it successfully sent a PR. Thanks!


Bad DTO

https://github.com/basf/metis-gui/blob/378bfde894467a3ee78c0b8f6b2ab37c309c03f8/src/types/dto.d.ts#L31
the progress field should be on the calculations, not on the datasources

Also, engine name and id are missing.


CaptureAward has some invalid types

Well, all invalid types. They're all sent as bytes.

This doesn't look correct at all... I'll MITM my phone today while capturing a Pokemon and see if I can get a rough message from that.

Notes:

candy (3) seems to always be <03, 00, 00>

Will update when I have more data...

if you pass it into the right type it will work.

if you pass it into the right type it will work.

This is not the goal of this project though. We want to have a correct message here so that people can use it and have the right values.

You means this?
Response for CatchPokemon  { status: 'CATCH_SUCCESS',
captured_pokemon_id: 'REDACTED',
capture_award:
{ activity_type: [ 'ACTIVITY_CATCH_POKEMON' ],
xp: Int32Array { '0': 100 },
candy: Int32Array { '0': 3 },
stardust: Int32Array { '0': 100 } } }

Yes. That doesn't seem to work for me with repeated int32. Is it working for you with this exact proto file?

Yes, thats with the currect POGOProtos.
For multiple activities (like great throw):
Response for CatchPokemon  { status: 'CATCH_SUCCESS',
capture_award:
{ activity_type: [ 'ACTIVITY_CATCH_POKEMON', 'ACTIVITY_CATCH_GREAT_THROW' ],
xp: Int32Array { '0': 100, '1': 50 },
candy: Int32Array { '0': 3, '1': 0 },
stardust: Int32Array { '0': 100, '1': 0 } } }

Odd. What language are you using with this?

POGOLib C# and pokemon-go-mitm-node (javascript)

It works for java api too in its current state

Please see my pull request. I suspect this will fix your problem.


Misleading error message when gokube start fails to verify ssh connectivity

When gokube start fails due to ssh connectivity, one of the proposed solution in error message is

Use --force to override this connectivity check

This option is unsupported:
gokube start --force WARNING: Cannot find gokube latest release, please check your connection Error: unknown flag: --force
gokube-force.txt
Possible workaround is to call twice

gokube start

Better solution is to let define a timeout how long the gokube should wait before giving up ssh connectivity check and returning an error

Thank you to post an issue here !
This message is printed by minikube start command, which is launched by gokube init command. gokube will not call minikube with this flag as enforcing SSH connectivity check will lead to other errors later (helm installation) and the objective of gokube is to generate automatically a VM up and ready to serve without need of hacking it after. If there are errors, it is better to try to understand them (environment, network or virtualbox issues ?)
There is actually a misleading thing with this flag as gokube init command (not start) also has its own --force flag (you can see it in typing gokube init --help) that does something else (remove a warning message). Maybe an improvement could be to rename this flag to avoid confusion.

+1 for renaming.

gokube --force flag for init and stop commands has been replaced by --quiet


Typo in introduction-to-github-packages.md in Japanese: nmp → npm

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/ja/packages/learn-github-packages/introduction-to-github-packages
Only Japanese doc is affected.
What part(s) of the article would you like to see updated?
I found a typo at https://docs.github.com/ja/packages/learn-github-packages/introduction-to-github-packages#:~:text=GitHub Packagesは、-,nmp,-、RubyGems、Apache Maven. Please fix "nmp" in the sentence to "npm".
Additional information
Screenshot

Notes
The same doc in English ( https://github.com/github/docs/blob/main/content/packages/learn-github-packages/introduction-to-github-packages.md ) is no typos.

H

G

@taigakiyokawa Great catch! Thanks for opening this 👍
Our translations are handled via an internal process, so I'm going to go ahead and close this issue and raise it for review internally. 💖
Thank you for your interest in improving GitHub Docs! ✨ :


Refactor task_timeout/--task-timeout/EWMS_PILOT_TASK_TIMEOUT [minor]

Renames task/subprocess-related timeout variables. "Sub-process" is an overloaded term and "task" is a central term of EWMS.
Maintains backward support of EWMS_PILOT_SUBPROC_TIMEOUT env var, since the Skymap Scanner uses that. If EWMS_PILOT_TASK_TIMEOUT is given, it overrides.
Warnings are logged when EWMS_PILOT_SUBPROC_TIMEOUT is used.

Seems fine.  My only question is if you need to maintain EWMS_PILOT_SUBPROC_TIMEOUT or can just upgrade skydriver.

Seems fine. My only question is if you need to maintain EWMS_PILOT_SUBPROC_TIMEOUT or can just upgrade Skymap Scanner.

I suppose I can throw an error if it's used. As opposed to silently not using the value. What do you think?

Ultimately decided to retain backward compatibility for SkyDriver's sake. This way it can run old images


error

when i click on the python file it runs the cmd and then the cmd window closes all at the same time.
and i tried typing python viewbot.py it says ' python: can't open file 'C:\Users\Digital Tree\viewbot.py': [Errno 2] No such file or directory ' .

same here getting the same issue


About the Code

Can you tell me how to run your tool from the source code(using an IDE) rather than the step you provided.
Cause i find it difficulty to understand the structure of the code. It is complex~

If you want to explore and modify the source code, you can open the project tool_files/intellij_2017/bayou with IntelliJ and tool_files/py_charm_2017 with PyCharm. You can then run the pre-defined automated tests from the IDE. To run Bayou end-to-end with a trained model, however, you have to use the command line, as we have not configured it to work with an IDE. Follow the instructions in the main README.

Thank you so much, i'll have a try.


Use more standard fid/kid calculation

#7

Using your KID calculation as it seems to be relatively close to cleanfid's but is not stochastic as theirs
Had to use cleanfid's numpy calculation for FID since the results were quite different
Resize is using cleanfid's PIL resizing. resize_right was relatively close (a_tol=1e-3) but this still changes FID too much

Thanks for providing this very well written code, it has been very nice to read and compare :D

Had to use cleanfid's numpy calculation for FID since the results were quite different

How different btw? (Does mine have a bug or is it up to fp32 vs fp64? or is it the epsilon?)
We need to use the dataloader to load images instead of loading them from a directory because we may not have a directory, I am going to add webdataset later which we just have an iterator for, not a directory.

My KID is less stochastic bc I don't partition the data into subsets to compare pairwise yet, KID for 50,000 reals vs 50,000 fakes would require a 50,000x50,000 matrix to be materialized and that's kind of big so usually people take random subsets to compare pairwise and average the results.

As for FID I use a different formula for Wasserstein-2 distance between multivariate Gaussian distributions, given on https://djalil.chafai.net/blog/2010/04/30/wasserstein-distance-between-two-gaussians/, in order to explicitly handle the case where the covariance matrices do not commute (sigma_1 sigma_2 != sigma_2 sigma_1), since I have seen this in practice, the usual formula is only valid when they commute. I don't know if this is the source of the difference, maybe I just have a bug somewhere else or it is because I am doing the calculation in fp32. :)

in order to explicitly handle the case where the covariance matrices do not commute (sigma_1 sigma_2 != sigma_2 sigma_1), since I have seen this in practice

Apparently their formula does work, you just have to use a sqrtm routine that handles non-symmetric matrices. Since sqrtm_eig() only works on SPD matrices I had to use the other formula instead, I can try a different sqrtm if that's the problem.

I think I fixed sqrtm_eig() to work on nonsymmetric matrices that have real eigenvalues and eigenvectors but I need to test it, and I'm still not sure if that's the source of the difference.
class _MatrixSquareRootEig(torch.autograd.Function):
    @staticmethod
    def forward(ctx, a):
        vals, vecs = torch.linalg.eig(a)
        vals, vecs = vals.real, vecs.real
        ctx.save_for_backward(vals, vecs)
        return vecs @ vals.abs().sqrt().diag_embed() @ vecs.transpose(-2, -1)

    @staticmethod
    def backward(ctx, grad_output):
        vals, vecs = ctx.saved_tensors
        vals, vecs = vals.real, vecs.real
        d = vals.abs().sqrt().unsqueeze(-1).repeat_interleave(vals.shape[-1], -1)
        vecs_t = vecs.transpose(-2, -1)
        return vecs @ (vecs_t @ grad_output @ vecs / (d + d.transpose(-2, -1))) @ vecs_t

def sqrtm_eig(a):
    if a.ndim < 2:
        raise RuntimeError('tensor of matrices must have at least 2 dimensions')
    if a.shape[-2] != a.shape[-1]:
        raise RuntimeError('tensor must be batches of square matrices')
    return _MatrixSquareRootEig.apply(a)

Resize is using cleanfid's PIL resizing. resize_right was relatively close (a_tol=1e-3) but this still changes FID too much

As I commented elsewhere you need to clamp the resizeright output, it leaves the overshoot from bicubic/etc. in by default because clamping makes the gradient wrt the image 0 for out of range values and it is intended to be differentiable. :)

What FID are you supposed to get on an untrained 32x32 model (samples are noise) btw?

As I commented elsewhere you need to clamp the resizeright output, it leaves the overshoot from bicubic/etc. in by default because clamping makes the gradient wrt the image 0 for out of range values and it is intended to be differentiable. :)

The closest results I have gotten are with clamping :) It passes atol=1e-3 when the images are scaled to 0-255 so it's quite close. https://github.com/samedii/nicefid/blob/master/nicefid/resize.py
I tested resize_right again and I'm getting FID<PHONE_NUMBER>755488 (reference) vs<PHONE_NUMBER>7144617 (resize right) on my very small test dataset so that could be fine.
The features are significantly different though:
[0.1625934 , 0.09377331, 0.14070226, ...
vs
[0.1617, 0.0937, 0.1421, ...
I think it could be viable to switch to resize_right but I would want to test on another dataset too.

We need to use the dataloader to load images instead of loading them from a directory because we may not have a directory, I am going to add webdataset later which we just have an iterator for, not a directory. Also we need to compute the features in parallel for speed, does your code do that?

The library allows you to input an iterator that yields batches of NCHW tensors so you don't need to save the images to a directory first Features.from_iterator(...). The features are calculated for a batch at a time. Is that sufficient?
I also added support for input:ing the model manually because I saw you wrapping your models with accelerator (but we don't want the lib to do that by default) but I'm not sure if that's something that's actually needed. I'm not familiar with accelerator.

As for FID I use a different formula for Wasserstein-2 distance between multivariate Gaussian distributions, given on https://djalil.chafai.net/blog/2010/04/30/wasserstein-distance-between-two-gaussians/, in order to explicitly handle the case where the covariance matrices do not commute (sigma_1 sigma_2 != sigma_2 sigma_1), since I have seen this in practice, the usual formula is only valid when they commute. I don't know if this is the source of the difference, maybe I just have a bug somewhere else or it is because I am doing the calculation in fp32. :)

I don't think I tried using double there but I'll keep it in mind. The difference is too large now for it to be the cause at the moment. It is FID 307 vs 310.

I think I fixed sqrtm_eig() to work on nonsymmetric matrices that have real eigenvalues and eigenvectors but I need to test it, and I'm still not sure if that's the source of the difference.

I started trying another implementation of sqrtm but gave up. I think it is part of the issue. I changed eps and it didn't help.
I can have a go with your new implementation and see how it looks.

I tested resize_right again and I'm getting FID<PHONE_NUMBER>755488 (reference) vs<PHONE_NUMBER>7144617 (resize right) on my very small test dataset so that could be fine.

How are you getting that, I tried picking the CleanFID feature extractor out and I am getting values like 18 or 43, and KID values that indicate no difference between random noise fakes and reals...!

class InceptionV3FeatureExtractor(nn.Module):
    def __init__(self, device='cpu'):
        super().__init__()
        self.model = InceptionV3(resize_input=False, normalize_input=False).to(device)
        self.size = (299, 299)

    def forward(self, x):
        if x.shape[2:4] != self.size:
            x = resize(x, out_shape=self.size, pad_mode='reflect').clamp(-1, 1)
        return self.model(x * 127.5 + 127.5)[0][:, :, 0, 0]
``` Something's really wrong with this feature extractor.

Updates:

New sqrtm_eig is very similar. FID 310.23 (reference) vs 307.8188 (yours)
Tried comparing two sets of 128 random noise images and got a large difference for smaller FIDs as well 14.10 (reference) vs 11.93 (yours with new sqrtm_eig)

Something's really wrong with this feature extractor and I can't figure out what. :/

You are looking at the wrong model though. They are using InceptionV3W in "clean" mode.

How are you getting that, I tried picking the CleanFID feature extractor out and I am getting values like 18 or 43, and KID values that indicate no difference between random noise fakes and reals...!

Did you see that their model expects values between 0-255?

What FID are you supposed to get on an untrained 32x32 model (samples are noise) btw?

Not sure but I've seen values very early on in training above 300.

Not quite, see here https://github.com/GaParmar/clean-fid/blob/main/cleanfid/inception_torchscript.py

Do you mean the normalization difference? 127.5 is how you actually get from a -1-1 range image to a 0-255 range image, I assume the 128 value in clean-fid is just wrong?

Ah my bad, I just didn't see that you were wrapping the cleanfid implementation. I don't think the clamping is necessary but I might be wrong

Thank you so much for your feedback/correctness checks on my clean-fid wrapper (and for motivating me to complete it!)


Adjust1-393 issue with unused deductions for tagged bail not displaying a banner

Ready for re-review


Compile from App Server Class Path / Can't find stylesheet to import.

Hi,
I´m currently would like to integrate this Library into my Webapp (WildFly) application.
My process is like this:

Open the file
Load content to string
Change color codes to my needs (search and replace) and get a new string
Compile this new adjusted string (with other colors codes)

It seems this lib is not handling vFS from the war, because I got an issue that I cannot open the path:
Error: java.lang.IllegalArgumentException: Can't handle url: vfs:/Applications/Software/wildfly-21.0.0.Final/standalone/deployments/myApp.war/WEB-INF/lib/myExternalJarApp-1.0-SNAPSHOT.jar/files/template/jsf/primefaces/rain/sass/theme/_theme_dark
If I execute the same code via simple Main method (no WildFly), it will work.
My SCSS - File is something linke this:
`$primaryLightColor: #eeee90 !default;
$primaryColor: #eeee89 !default;
$primaryDarkColor: #eeee88 !default;
$primaryDarkerColor: #eeee87 !default;
$primaryTextColor: #eeee86 !default;
@import '../sass/theme/_theme_light';`
I´ve tried this and than I got this exception
URL url = Thread.currentThread().getContextClassLoader() 					.getResource("files/template/layout-light.scss"); CompileSuccess compileSuccess = sassCompiler.compile(url);
Issue seems for me in the class CustomUrlImporter" in function:
protected boolean isFile(URL url)

If I execute it via Main function I have as protocol:

If I execute via App - Server I have another protocol:

No condition is matching and therefore I got this exception:

At the end I would also need only the string from the File, do some color changes, compile it and get the css code....
Than I´m trying it with the other function (compileScssString):
Here the code for it:
URL url = Thread.currentThread().getContextClassLoader() 					.getResource("files/template/layout-light.scss"); File file = new File(url.getFile()); String content = IOUtils.toString(new FileInputStream(file), StandardCharsets.UTF_8); CompileSuccess compileSuccess = sassCompiler.compileScssString(content);
But than I´m got this exception (also in my simple Main - function):
Exception in thread "main" de.larsgrefer.sass.embedded.SassCompilationFailedException: Error: Can't find stylesheet to import.
  ╷
4 │ @import '../../sass/variables/_layout_light';

String content is like this:
$primaryColor: #eeee89;
$primaryTextColor: #eeee86;

@import '../../sass/variables/_layout_light';
@import '../../sass/layout/_layout';

So seems sassCompiler.compileScssString(content); cannot handle references to other files?
And this is working?
CompileSuccess compileSuccess = sassCompiler.compileFile(file);
Are there some fixes needed in the lib or I´m doing something wrong?

Could you share an example project which I can try/debug myself?

It seems this lib is not handling vFS from the war, because I got an issue that I cannot open the path:

Yes, the vfs protocol seems to be the problem here. When resolving imports like ../foo, the import could refer to ../foo.scss, ../foo.sass, ../_foo.scss, ../_foo.sass. The AutoCanonicalizingImporter generates all the possible targets and then checks, which of these actually exist (is an actual file). This check is only implemented for file:, jar: and http(s): protocols, but fails for vfs: URLs.

So seems sassCompiler.compileScssString(content); cannot handle references to other files?

Yes, compileScssString cannot handle (relative) imports by default, because the compiler can't know where to search.
You could try to circumvent this, by providing an additional Importer to SassCompiler#registerImporter.

Thank you for your answer....
As example you can use any WildFly project and than just add this line:
URL url = Thread.currentThread().getContextClassLoader() .getResource("files/template/layout-light.scss"); CompileSuccess compileSuccess = sassCompiler.compile(url);
Is there any option to extend the protocols that it works also for vfs?
Otherwise I will get always this exception.

Could you try again with version 1.13.0 ?

Thank you Lars, that´s working.
I´ve created a new ticket regarding the issue:
CompileSuccess compileSuccess = sassCompiler.compileScssString(content)
https://github.com/larsgrefer/dart-sass-java/issues/236


isw_field_type = 1 error?

Hi,
@JakeNeau and I are trying to run SIMPLE with initial particle positions specified by VMEC coordinates.  We set isw_field_type = 1 in simple.in.  However, we run simple.x with this input, we get an error stating "Illegal field type" for eval_field and the message of Unknown field type.  Is this the correct way to be runing SIMPLE with particle positions in VMEC coordinates and a corresponding VMEC file?  Furthermore, what is isw_field_type specifying?
Thanks,
Ben

Hi Ben, that's fine - you can use either canonical or Boozer coordinates as a switch. Those are only used internally and initial positions are always VMEC coordinates.

Thank, Christopher, I appreciate the clarification!


Only show explore button when in detail view

Bug fix for #7695
Made spacing consistent:

@richard-cox Updated as per your feedback


Complex indent method fix

Lem didn't correctly indent Lisp forms whenever the
method registered for a symbol ended in &rest <integer>. For instance, multiple-value-bind` was indented like that:
  (multiple-value-bind (a b
                          c d
                          e f)
      g
    h)

However, it should be:
  (multiple-value-bind (a b
                        c d
                        e f)
      g
    h)

I also added an error-check before setting some Lisp indentation method. Tested error checking all methods both in static and dynamic tables, no error was found. Indentations now is like Emacs in all tests I made.

Reading the documentation from Emacs, the function is treating &whole wrongly. It was already wrong before: &whole should be accepted anywhere. Also, sublists indentation count up from the 0th element (it was previously "skipped". I'm gonna change it now according to documentation.

Emacs spec is not what it does actually. Changed compute-complex-indent-method based on Emacs source code,
By the way, I see this code is far from optimal when using modes like Emacs aggressive-indent-mode. Now I understand why Emacs have slow performance with that mode and very large sexps. I believe it would be much better if we previously parse the indent-mode before placing it in the table, transforming it in a vector, for instance. Then, for indentation, we use (aref parsed-method n) instead of iterating inside a list. It would be a cleaner and better code.
Plus, indenting regions could be better coded so that paths are computed more efficiently, reusing the same path prefix for an entire sexp.


optimize appender with unsafe append API

reserve the space first and use unsafe append, this should make the array builder faster

#203


Add missing linux-firmware package in Rocky Linux 9

Does it have to wait for CI? Looks like there's no influence

approved - please try to fix it in DIB upstream as well

https://review.opendev.org/c/openstack/diskimage-builder/+/894905
Root cause was the package list was copied from fedora-container element


latest dev docs broken

/home/docs/checkouts/readthedocs.org/user_builds/pyro-ppl/checkouts/dev/docs/source/contrib.gp.rst:6: WARNING: autodoc: failed to import module u'pyro.contrib.gp'; the following exception was raised:
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/pyro-ppl/envs/dev/local/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 658, in import_object
    __import__(self.modname)
  File "/home/docs/checkouts/readthedocs.org/user_builds/pyro-ppl/checkouts/dev/pyro/__init__.py", line 14, in <module>
    import pyro.infer as infer
  File "/home/docs/checkouts/readthedocs.org/user_builds/pyro-ppl/checkouts/dev/pyro/infer/__init__.py", line 9, in <module>
    from pyro.infer.advi import ADVI, ADVIMultivariateNormal, ADVIDiagonalNormal
  File "/home/docs/checkouts/readthedocs.org/user_builds/pyro-ppl/checkouts/dev/pyro/infer/advi.py", line 16, in <module>
    from contextlib2 import ExitStack  # python 2
ImportError: No module named contextlib2
/home/docs/checkouts/readthedocs.org/user_builds/pyro-ppl/checkouts/dev/docs/source/contrib.gp.rst:15: WARNING: autodoc: failed to import module u'pyro.contrib.gp.models.model'; the following exception was raised:
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/pyro-ppl/envs/dev/local/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 658, in import_object
    __import__(self.modname)
  File "/home/docs/checkouts/readthedocs.org/user_builds/pyro-ppl/checkouts/dev/pyro/__init__.py", line 13, in <module>
    import pyro.distributions as dist
AttributeError: 'module' object has no attribute 'distributions'

may possibly be from #961 and/or #951. can we error on these warnings in travis? because the docs build succeeds even if exceptions are thrown.

:+1: to erroring if doc build fails

Yes this was from #951. We probably need to add pip install contextlib2 to the docs build dependency


Sample efficiency experiment

As in the original T5 paper, we train T5 (and GPT for reference) with a varying number of epochs (e.g. 1, 8, 64, etc) on C4 and see at which point test perplexity and SuperGLUE score degrades noticeably from that of the one epoch training. We also vary the size of the model (e.g. Base, Large, XL for 128B tokens) to see how the threshold moves w.r.t. the model size.

Closing as we are not currently planning on implementing encoder-decoder models


UseContract Function Uncaught Promise Reject Transaction

Describe the bug
When using Contract Functions and this function is rejected in wallet, use contract error throw error of uncaught promise
To Reproduce
ReactDOM.render(

,
document.getElementById('root')
)
const useAdminContractMethod = (methodName: string) => {
const { state, send, events } = useContractFunction(
AdminContract,
methodName,
{ transactionName: methodName }
);
return { state, send, events };
};
const { state: EventMethodState, send: EventMethod } = useAdminContractMethod("methodFunctionName");
Call Function, open browser wallet (Metamask, Magic) and then reject transaction
Expected Behavior

Manage error in state: Event MethodState
Current Behavior
uncaught error in promise

Browser: Chrome
Wallets/Providers

Metamask
Magic Link
WalletConnect
Network: Polygon-Mumbai

Software versions

useDapp version 1.1.5
Package manager npm
Node version 14

Additional context
It work ok in useDapp version 1.0.12 when reject a transaction in wallet, useContractFunction state manage the error correctly

Hey @faillacec
Thanks for reporting.
This issue has been fixed (but not released yet).
In the meantime, you can either:

Test the new dev version -<EMAIL_ADDRESS>Wrap the send in a try-catch

Let me know how that goes.

@faillacec That looks like it is coming from the extension.
So it happens when you reject - are there any other symptoms other than the error in developer console?
If there are no other symptoms, and the user is not impacted, then I think the error in the console can be ignored.

Hi @rzadp, That was only an example to show you the error, the problem is that none notification is showed  when I call a function from contract using useContractFunction the  the state (const { state, send, events } = useContractFunction) never  is updated, it never change whether error or successfull or rejected (when rejected or error in transacction show uncaught error) never throw this error to catch


Expose Error Serialization To Consumers to Allow Ergnomoic Middleware

Description
As part of work I have done recently to prevent un-bounded memory growth in s3s, I put a basic middleware in front of my service that checks the signature mechanism and content-length, denying requests that will incur massive memory usage.
In doing this, I realized I would need to write my own serialization to send the error response using Hyper. This PR exposes the internal serialize_error method so it can used in consumer's middleware.
I was not quite sure how you would prefer this to be exposed / if you think this is a good idea at all. Let me know your thoughts / suggestions.

impl Service<hyper::Request<hyper::body::Incoming>> for PreCheck {
    type Response = hyper::Response<Body>;

    type Error = S3Error;

    type Future = BoxFuture<'static, Result<Self::Response, Self::Error>>;

    fn call(&self, req: Req) -> Self::Future {
        if (some_check_on_req(req)) {
            // Handle the request as normal
            return self.inner.call(req);
        }

        // Oh Dear, I don't want to handle this one!
        let response = s3s::serialize_error(s3_error!(
            AccountProblem,
            "You ain't paid your bills!"
        ), true).map(Into::into);

         Box::pin(
            future::ready(
                response
            )
         )
    }
}

Caveats
This is currently built atop the PR I opened earlier, #156 .

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

CI Failure seems to be related to how I have exposed this. I will wait for general feedback on the PR before I dive into fixing that.

I've switched to using a method on the S3Error type rather than exposing it at the top level. Let me know what you think. :+1:


⚠ Bofrost.es has degraded performance

In ed3654b, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1692 ms

Resolved: Bofrost.es performance has improved in 08bbeaf after 8 minutes.


Documentation missing for punctuation methods in SettingKey

The documentation at http://www.scala-sbt.org/0.13.11/api/index.html#sbt.SettingKey does not contain descriptions for the various obfuscation rockets like <+=, <++=, ~= etc.  Even basic methods like := are are missing.

+1

This should really read "The API documentation is almost completely absent".  I originally went there to  decode the punctuation that appears everywhere in .sbt files but now I see that almost nothing is documented, even for prior sbt versions.

The best source of explanation for sbt 0.12 style operators is sbt 0.12 documentation - https://www.scala-sbt.org/0.12.4/docs/Getting-Started/More-About-Settings.html
Closing this since those are now removed in sbt 1.


Issues with compiling when used with firebase emulators

Gettings this syntax error:
import {promisify} from 'util';
^^^^^^

SyntaxError: Cannot use import statement outside a module .......

Version 7.0.1 uses require( ... ), and I do not get any errors when using that version. I am using the latest version of Firebase. Don't know if it is actually Firebase emulators or a bug.

Saw that a issue with this is already opened.


ConstantRange incorrectly converted to ConstantIntValue

"import net.minecraft.loot.ConstantRange" (1.16) should become "import net.minecraft.world.level.storage.loot.providers.number.ConstantValue"; unfortunately, you converted it to "ConstantIntValue", which doesn't exist in Minecraft and greatly confused my IDE, which thought it was from the sun.jvm package.

The script only remaps to Mojmaps based on what Minecraft version you start with as that is how it is designed. In 1.16.5, the class is in fact called ConstantIntValue in mojmaps, which is correct. The script does not deal with class renames across versions, so this is not a bug with the script.


skate.emit()

Skate should have a function that triggers events on a given element.
It should:

Trigger a CustomEvent on a single element.
Trigger multiple events using a space-separated string or array of event names.
Allow you to override default options.
Simulate bubbling on detached elements. (supported in Firefox, but seemingly non-standard).
Return an array of events names that were cancelled. If no events were cancelled it returns an empty array.

Number 4 is very useful for web components because it allows a descendant to communicate with the parent in a decoupled manner without having to be in the DOM. There's an overwhelming amount of use cases for this.
var element = document.createElement('div');
var options = { detail: true };
var cancelled1 = skate.emit(element, 'event1 event2', options);
var cancelled2 = skate.emit(element, ['event1', 'event2'], options);

Implemented in #258.


Use requirejs modules instead of registry

@SylvainCorlay here is what we talked about yesterday.
closes #414

This has broken the tests legitimately because the test don't use requirejs

@blink1073 Goog led me to this: https://github.com/webpack/webpack/issues/1952  Looks like I'm retracing some of your steps :stuck_out_tongue:

Good times.

Turns out the test have been broken for a long time and have been artificially passing because an npm install step is failing and not returning a code...

This is ready

:+1:


npm install problem

hey got an issue and i don't know where it comes from so here's the log:
0 info it worked if it ends with ok
1 verbose cli [
1 verbose cli   'C:\Program Files\nodejs\node.exe',
1 verbose cli   'C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js',
1 verbose cli   'run',
1 verbose cli   'build'
1 verbose cli ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prebuild', 'build', 'postbuild' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin;C:\Users\alexo\destreamer\node_modules.bin;C:\Program Files\Git\cmd;C:\Program Files (x86)\Common Files\Intel\Shared Libraries\redist\intel64\compiler;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files (x86)\QuickTime\QTSystem;C:\Program Files\MATLAB\R2019b\bin;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Users\alexo\AppData\Local\Microsoft\WindowsApps;C:\Users\alexo\AppData\Local\Programs\Microsoft VS Code\bin;C:\Users\alexo\AppData\Local\Programs\MiKTeX 2.9\miktex\bin\x64;C:\Users\alexo\AppData\Roaming\npm;C:\ffmpeg-4.2.2-win64-static\bin;
9 verbose lifecycle<EMAIL_ADDRESS>CWD: C:\Users\alexo\destreamer
10 silly lifecycle<EMAIL_ADDRESS>Args: [
10 silly lifecycle   '/d /s /c',
10 silly lifecycle   'echo Transpiling TypeScript to JavaScript... && node node_modules/typescript/bin/tsc && echo Destreamer was built successfully.'
10 silly lifecycle ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec build script
13 verbose stack Error<EMAIL_ADDRESS>build: echo Transpiling TypeScript to JavaScript... && node node_modules/typescript/bin/tsc && echo Destreamer was built successfully.
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter. (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\index.js:332:16)
13 verbose stack     at EventEmitter.emit (events.js:310:20)
13 verbose stack     at ChildProcess. (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\lib\spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:310:20)
13 verbose stack     at maybeClose (internal/child_process.js:1021:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd C:\Users\alexo\destreamer
16 verbose Windows_NT 10.0.18362
17 verbose argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "build"
18 verbose node v12.16.3
19 verbose npm  v6.14.4
20 error code ELIFECYCLE
21 error errno 1
22 error<EMAIL_ADDRESS>build: echo Transpiling TypeScript to JavaScript... && node node_modules/typescript/bin/tsc && echo Destreamer was built successfully.
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>build script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

Taking a wild guess you don't have git installed. Check requirements in README and reporr back.

alright, i did npm instal typescript and it worked

but now when I try to download one video it displays that
Launching headless Chrome to perform the OpenID Connect dance...
Error: Failed to launch the browser process! spawn C:\Users\alexo\destreamer\node_modules\puppeteer.local-chromium\win64-722234\chrome-win\chrome.exe ENOENT
TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md
at onClose (C:\Users\alexo\destreamer\node_modules\puppeteer\lib\Launcher.js:750:14)
at ChildProcess.<anonymous> (C:\Users\alexo\destreamer\node_modules\puppeteer\lib\Launcher.js:741:65)
at ChildProcess.emit (events.js:310:20)
at Process.ChildProcess._handle.onexit (internal/child_process.js:273:12)
at onErrorNT (internal/child_process.js:469:16)
at processTicksAndRejections (internal/process/task_queues.js:84:21)

Unhandled error!
Timeout or fatal error, please check your downloads directory and try again

I think you missed the npm install step. Please go back to the README and follow along.

@AlexUnise Can we close this one or are you still unable to install dependencies?

still having trouble with that, it seems that there is a problem with tokens

I would start over. Clone the repository to a new path, build and try again. Do all that in cmd.exe.
https://www.youtube.com/watch?v=bspR2LsNFjk&feature=youtu.be

Hello, I got a different error here. Here's the log file and the screenshot of the error message. I'm sure that I'd followed the instruction. Do anyone have ideas about it? Thank you.
2020-05-29T10_16_51_370Z-debug.log

Are you up to date with Node and npm versions?

Are you up to date with Node and npm versions?

Thanks for reply. The low versions seems to be the reason of getting error messages. The scripts run correctly after I upgrade my node and npm. :)

Cool. Happy you got this working.


Change import of pylab, changed import statement

Using the ColorMap in the current version leads to an error:
Example:
# converting the obesity into a color
cmap = ColorMap('Reds', alpha=255, levels=40)

def get_color(properties):
    return cmap.to_color(properties['Obesity'], maxvalue=40,scale='lin')

ImportError: cannot import name 'get_cmap' from 'pylab' (/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pylab/__init__.py)

Since the import has changed from
from pylab import get_cmap

to
from matplotlib.pylab import get_cmap

Any chance we could update this and publish the new version to PyPi, @andrea-cuttone ? 😊

👍to this. Just ran into this same issue.


remove deprecated styleci linting

https://styleci.readme.io/docs/change-log#section-14042018-april-fixer-updates

Finally, the long deprecated "linting" config option has now been removed.

Thanks!


[OpenAI] Add tests for files

WIP

API change check
API changes are not detected in this pull request.


Sonarr installs with root user

On my Ubuntu 17.04 machine, Sonarr install into /opt/NzbDrone with root user, causing Sonarr to complain. No other product that I have installed through atomic has this problem.

Thanks for bring this to my attention.
I've fixed this in my branch and will push the changes up when I've finished a few other apps I'm working on.

Tom

I think this should now be resolved. Although I've tried to test the changes can someone give it a try and confirm its ok now?
Thanks
Tom

Closing this as I believe this has now been fixed and i've not heard of any further issues.
Closing as has now been added and not heard of any issues.


ovn-tester: Don't try creating the veth twice.

For some reason the exact same veth creation command is run twice in a
row when provisioning. Adding some debugging, I saw the following:
2021-09-01 14:06:15,391 | ovn_sandbox  |WARNING| Command docker exec ovn-scale-1 ip link add veth0 type veth peer name veth1 exited with status 2
2021-09-01 14:06:15,391 | ovn_sandbox  |WARNING| stderr: RTNETLINK answers: File exists
The error is benign, but we may as well get rid of it.

Looks good to me, thanks!


Svelte won't build when using prerender with mdsvx

Hello @mattcroat,
I have followed your Youtube and blog tutorial on how "Sveltekit Markdown Blog". Everything is working pretty well on local both when prerender option is disabled and enabled.  But once I want to build it with the prerender option enabled (true)  then the issue will be thrown. And if I build the project without prerender option enable (false), then the dynamic route will throw 404 instead.
I have checked your code in this repo but seem like your code is building it from scratch rather than using mdsvx.
Here is the log i get when pressing pnpm build:

vite v4.4.9 building for production...
✓ 44 modules transformed.
.svelte-kit/output/client/_app/version.json                                  0.03 kB │ gzip: 0.05 kB
.svelte-kit/output/client/vite-manifest.json                                 2.47 kB │ gzip: 0.46 kB
.svelte-kit/output/client/_app/immutable/nodes/0.ec4cd187.js                 0.55 kB │ gzip: 0.37 kB
.svelte-kit/output/client/_app/immutable/chunks/preload-helper.a4192956.js   0.89 kB │ gzip: 0.55 kB
.svelte-kit/output/client/_app/immutable/nodes/1.3877a54b.js                 0.98 kB │ gzip: 0.57 kB
.svelte-kit/output/client/_app/immutable/nodes/2.c5c53d50.js                 2.04 kB │ gzip: 1.05 kB
.svelte-kit/output/client/_app/immutable/chunks/singletons.d155d5dc.js       2.85 kB │ gzip: 1.46 kB
.svelte-kit/output/client/_app/immutable/nodes/3.a19eb04d.js                 2.93 kB │ gzip: 1.48 kB
.svelte-kit/output/client/_app/immutable/entry/app.bd70efe8.js               5.01 kB │ gzip: 1.86 kB
.svelte-kit/output/client/_app/immutable/chunks/index.838feb98.js            7.13 kB │ gzip: 2.88 kB
.svelte-kit/output/client/_app/immutable/entry/start.ebf8f3c0.js            24.82 kB │ gzip: 9.78 kB
✓ built in 689ms
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/pc/Desktop/app/.svelte-kit/output/server/entries/pages/blog/1.md' imported from /home/pc/Desktop/app/.svelte-kit/output/server/entries/pages/blog/_slug_/_page.js
    at new NodeError (node:internal/errors:399:5)
    at finalizeResolution (node:internal/modules/esm/resolve:326:11)
    at moduleResolve (node:internal/modules/esm/resolve:945:10)
    at defaultResolve (node:internal/modules/esm/resolve:1153:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:838:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ESMLoader.import (node:internal/modules/esm/loader:525:22)
    at importModuleDynamically (node:internal/modules/esm/translators:110:35)
    at importModuleDynamicallyCallback (node:internal/process/esm_loader:35:14) {
  code: 'ERR_MODULE_NOT_FOUND'
}
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/pc/Desktop/app/.svelte-kit/output/server/entries/pages/blog/1.md' imported from /home/pc/Desktop/app/.svelte-kit/output/server/entries/pages/blog/_slug_/_page.js
    at new NodeError (node:internal/errors:399:5)
    at finalizeResolution (node:internal/modules/esm/resolve:326:11)
    at moduleResolve (node:internal/modules/esm/resolve:945:10)
    at defaultResolve (node:internal/modules/esm/resolve:1153:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:838:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ESMLoader.import (node:internal/modules/esm/loader:525:22)
    at importModuleDynamically (node:internal/modules/esm/translators:110:35)
    at importModuleDynamicallyCallback (node:internal/process/esm_loader:35:14) {
  code: 'ERR_MODULE_NOT_FOUND'
}

node:internal/event_target:1012
  process.nextTick(() => { throw err; });
                           ^
Error: 500 /blog/1 (linked from /blog)
To suppress or handle this error, implement `handleHttpError` in https://kit.svelte.dev/docs/configuration#prerender
    at file:///home/norin/Desktop/app/node_modules/.pnpm/@sveltejs+kit@1.24.1_svelte@3.59.2_vite@4.4.9/node_modules/@sveltejs/kit/src/core/config/options.js:212:13
    at file:///home/norin/Desktop/app/node_modules/.pnpm/@sveltejs+kit@1.24.1_svelte@3.59.2_vite@4.4.9/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:64:25
    at save (file:///home/norin/Desktop/app/node_modules/.pnpm/@sveltejs+kit@1.24.1_svelte@3.59.2_vite@4.4.9/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:403:4)
    at visit (file:///home/norin/Desktop/app/node_modules/.pnpm/@sveltejs+kit@1.24.1_svelte@3.59.2_vite@4.4.9/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:236:3)
Emitted 'error' event on Worker instance at:
    at [kOnErrorMessage] (node:internal/worker:300:10)
    at [kOnMessage] (node:internal/worker:311:37)
    at MessagePort.<anonymous> (node:internal/worker:212:57)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:737:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28)

Node.js v18.16.0
 ELIFECYCLE  Command failed with exit code 1.

I also commit the code to this repo, just in case you want a quick review. Thanks

@SBV2020 If you need help make a reproduction and ask your question on Discord instead of using issues.


clarify wss proxy tunnel

Release Playbook

[x] Rebase against master
[ ] Code review
[ ] Merge into master
[ ] Verify changes at http://site-staging.convox.com
[ ] Promote release on site-production in the convox/production Rack

Addressing https://github.com/convox/rack/issues/1928

@mwarkentin It's always used TLS, just stating that explicitly now :)

Exactly.. glad it's spelled out now. :)


--analyze flag could add the BundleAnalyzerPlugin

This would facilitate debugging of the size of our bundles.

cozy-scripts already has an option --analyzer which launch webpack-bundle-analyzer, you can find more informations about it in the documentation.
Is this what you're looking for?

Nice, thanks !


Show all markers by default.

If x/y coords and focus_entity  have not been provided, the map will now default to showing all current markers via leaflets fitBounds mechanism.
This seems like a sensible default for cases where a more specific choice has not been made. It also makes it easy to just see all markers, automatically focusing closer if they all happen to be near.
fixes https://github.com/nathan-gs/ha-map-card/issues/66

Hi @nathan-gs, that makes sense. Have pulled the initial display logic out to its own stand alone method. Given we only ever call in by the one function, seemed sensible to skip doing a full class for this, but your call if you prefer that style 👍 Easy enough to swap it over.


Scan bigger/fewer jsdoc tokens

Works on #52959, more detail later

The PR appears to have some errors so I don't know if the above is believable, unfortunately.

I can't reproduce those errors locally, although I haven't tried very hard yet, just runtests-parallel.

@typescript-bot perf test this

@typescript-bot perf test this faster

I ran the current state on my perf machine with --predictable and this is what I got:

Details
Loading benchmark and comparing to baseline.
Comparison Report - main..HEAD

Metric
main
HEAD
Delta
Best
Worst
p-value

Angular - node (v16.18.1, x64)

Memory used
292,240k (± 0.00%)
292,396k (± 0.00%)
+156k (+ 0.05%)
292,396k
292,397k
p=0.003 n=6

Parse Time
3.36s (± 0.15%)
3.18s (± 0.32%)
🟩-0.18s (- 5.35%)
3.17s
3.20s
p=0.004 n=6

Bind Time
1.30s (± 0.40%)
1.10s (± 0.47%)
🟩-0.19s (-14.91%)
1.10s
1.11s
p=0.004 n=6

Check Time
10.29s (± 0.11%)
10.50s (± 0.05%)
+0.21s (+ 2.09%)
10.50s
10.51s
p=0.004 n=6

Emit Time
8.75s (± 1.12%)
8.70s (± 0.35%)
~
8.67s
8.75s
p=0.145 n=6

Total Time
23.70s (± 0.42%)
23.49s (± 0.14%)
-0.21s (- 0.89%)
23.46s
23.53s
p=0.005 n=6

Compiler - node (v16.18.1, x64)

Memory used
173,738k (± 0.01%)
173,790k (± 0.04%)
+52k (+ 0.03%)
173,762k
173,929k
p=0.003 n=6

Parse Time
2.01s (± 0.26%)
1.99s (± 0.20%)
-0.02s (- 1.08%)
1.99s
2.00s
p=0.003 n=6

Bind Time
0.93s (± 0.55%)
0.93s (± 0.00%)
~
0.93s
0.93s
p=0.174 n=6

Check Time
9.01s (± 0.16%)
9.00s (± 0.12%)
~
8.99s
9.02s
p=0.111 n=6

Emit Time
3.81s (± 0.27%)
3.78s (± 0.11%)
-0.03s (- 0.83%)
3.78s
3.79s
p=0.003 n=6

Total Time
15.77s (± 0.14%)
15.70s (± 0.10%)
-0.07s (- 0.43%)
15.69s
15.73s
p=0.005 n=6

Compiler-Unions - node (v16.18.1, x64)

Memory used
192,385k (± 0.00%)
192,441k (± 0.02%)
+56k (+ 0.03%)
192,426k
192,513k
p=0.003 n=6

Parse Time
1.78s (± 0.29%)
1.81s (± 0.28%)
+0.03s (+ 1.68%)
1.81s
1.82s
p=0.004 n=6

Bind Time
0.92s (± 0.00%)
0.92s (± 0.56%)
~
0.91s
0.92s
p=0.174 n=6

Check Time
10.94s (± 0.17%)
10.96s (± 0.12%)
~
10.94s
10.98s
p=0.086 n=6

Emit Time
3.78s (± 0.11%)
3.75s (± 0.40%)
-0.03s (- 0.75%)
3.74s
3.78s
p=0.010 n=6

Total Time
17.43s (± 0.07%)
17.45s (± 0.04%)
+0.03s (+ 0.15%)
17.44s
17.46s
p=0.007 n=6

Monaco - node (v16.18.1, x64)

Memory used
343,038k (± 0.00%)
343,131k (± 0.00%)
+93k (+ 0.03%)
343,131k
343,131k
p=0.001 n=6

Parse Time
3.01s (± 0.53%)
2.89s (± 0.28%)
🟩-0.11s (- 3.82%)
2.89s
2.91s
p=0.004 n=6

Bind Time
1.48s (± 0.35%)
1.46s (± 0.00%)
-0.02s (- 1.13%)
1.46s
1.46s
p=0.002 n=6

Check Time
8.69s (± 0.25%)
8.68s (± 0.06%)
~
8.68s
8.69s
p=0.803 n=6

Emit Time
5.03s (± 0.37%)
5.00s (± 0.08%)
-0.03s (- 0.50%)
5.00s
5.01s
p=0.021 n=6

Total Time
18.21s (± 0.34%)
18.04s (± 0.06%)
-0.17s (- 0.94%)
18.02s
18.05s
p=0.005 n=6

TFS - node (v16.18.1, x64)

Memory used
298,807k (± 0.06%)
298,806k (± 0.00%)
-1k (- 0.00%)
298,806k
298,806k
p=0.045 n=6

Parse Time
2.55s (± 0.00%)
2.56s (± 0.33%)
~
2.55s
2.57s
p=0.176 n=6

Bind Time
1.11s (± 0.00%)
1.11s (± 0.00%)
~
1.11s
1.11s
p=1.000 n=6

Check Time
8.49s (± 0.06%)
8.49s (± 0.15%)
~
8.48s
8.51s
p=0.448 n=6

Emit Time
4.98s (± 2.27%)
5.43s (± 0.10%)
+0.46s (+ 9.14%)
5.43s
5.44s
p=0.004 n=6

Total Time
17.13s (± 0.65%)
17.59s (± 0.07%)
+0.46s (+ 2.67%)
17.57s
17.60s
p=0.005 n=6

material-ui - node (v16.18.1, x64)

Memory used
472,153k (± 0.00%)
472,570k (± 0.00%)
+417k (+ 0.09%)
472,570k
472,570k
p=0.001 n=6

Parse Time
3.46s (± 0.12%)
3.34s (± 0.12%)
🟩-0.12s (- 3.47%)
3.34s
3.35s
p=0.003 n=6

Bind Time
1.18s (± 0.44%)
1.12s (± 0.46%)
🟩-0.07s (- 5.63%)
1.11s
1.12s
p=0.004 n=6

Check Time
20.63s (± 0.11%)
20.66s (± 0.07%)
+0.03s (+ 0.14%)
20.64s
20.67s
p=0.042 n=6

Emit Time
0.00s (± 0.00%)
0.00s (± 0.00%)
~
0.00s
0.00s
p=1.000 n=6

Total Time
25.27s (± 0.09%)
25.11s (± 0.07%)
-0.16s (- 0.63%)
25.10s
25.14s
p=0.005 n=6

xstate - node (v16.18.1, x64)

Memory used
526,990k (± 0.00%)
528,114k (± 0.00%)
+1,124k (+ 0.21%)
528,114k
528,114k
p=0.001 n=6

Parse Time
4.70s (± 0.16%)
4.29s (± 0.15%)
🟩-0.41s (- 8.69%)
4.28s
4.30s
p=0.004 n=6

Bind Time
1.59s (± 0.00%)
1.57s (± 0.33%)
-0.02s (- 1.05%)
1.57s
1.58s
p=0.002 n=6

Check Time
3.52s (± 0.00%)
3.33s (± 0.00%)
🟩-0.19s (- 5.40%)
3.33s
3.33s
p=0.001 n=6

Emit Time
0.10s (± 0.00%)
0.09s (± 0.00%)
🟩-0.01s (-10.00%)
0.09s
0.09s
p=0.001 n=6

Total Time
9.90s (± 0.04%)
9.29s (± 0.04%)
🟩-0.61s (- 6.19%)
9.28s
9.29s
p=0.003 n=6

System

Machine Nameelcheapo
Platformlinux 6.2.1-arch1-1
Architecturex64
Available Memory8 GB
Available Memory7 GB
CPUs6 × Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz

Hosts

node (v16.18.1, x64)

Scenarios

Angular - node (v16.18.1, x64)
Compiler - node (v16.18.1, x64)
Compiler-Unions - node (v16.18.1, x64)
Monaco - node (v16.18.1, x64)
TFS - node (v16.18.1, x64)
material-ui - node (v16.18.1, x64)
xstate - node (v16.18.1, x64)

Benchmark
Name
Iterations

Current
HEAD
6

Baseline
main
6

(Which is to say, confusing.)

:shipit:

I haven't reviewed the code since your last changes, but this is definitely a lot better! Here's how it looks on my "War, What is it Good For?" benchmark from https://github.com/microsoft/TypeScript/issues/52959
$ bash bench.sh | grep "Parse"
+ node ../built/local/tsc.js -p tsconfig-split.json
Parse time:                 0.58s
+ node ../built/local/tsc.js -p tsconfig-split-space.json
Parse time:                 0.47s
+ node ../built/local/tsc.js -p tsconfig-split-AAA.json
Parse time:                 0.54s
+ node ../built/local/tsc.js -p tsconfig-single.json
Parse time:                 0.43s
+ node ../built/local/tsc.js -p tsconfig-single-AAA.json
Parse time:                 0.32s

It would be very neat if we could get the last two examples on parity though.
I tried looking for the differences, but couldn't find much just yet. As an aside, I noticed there are some small differences I found with pprof are outside of the concern of the parser itself. For example, I noticed that 33ms is spent on slice from Buffer.

I wondered if it had something to do with decoding, and indeed, War and Peace has some non-base ASCII characters like in the line

* tête-à-tête talk with the friend of her childhood, Princess Anna

Replacing these characters with As gets rid of that small difference.

@typescript-bot perf test this

Would you be able to investigate what's getting slower on every benchmark that's not getting a speed boost?

Would you be able to investigate what's getting slower on every benchmark that's not getting a speed boost?

Specifically parsing in Compiler-Unions gets slightly (but significantly!) slower.

A profile of compiler-unions shows that parseTrailingComments is slower, and that scanJSDocCommentTextToken adds to the time previously taken by scanJSDocToken. That doesn't make sense, since those calls should be replacing calls to scanJSDocToken.
I'm going to (1) re-run perf measurements on the most recent commit (maybe it's a fluke!) (2) step through comment parsing in compiler-unions to see if I can figure out if there's some problem there I'm missing.
@typescript-bot perf test this

My suspicion is that we're changing object allocation so much that GC is happening at a different time and causing other steps to take longer. But, I have no evidence for this besides --predictable changing things slightly.

Notably, with --predictable, the latest commit on my machine does not show a significant difference in total time for Compiler or Compiler-Unions.
And profiling a second time makes parseTrailingComments not a problem anymore. It doesn't seem to be stable.
I stepped through a few example parses in compiler-unions and didn't see anything suspicious either.

After the latest commit, compiler-unions parsing is not significantly different on node 18, a tiny bit slower on 16 and slower on 14. But node 14 also transfers half of xstate's parser speedup to the binder.
I think we're seeing noise. At worst the code is better on most codebases and slightly worse on a few.

@typescript-bot perf test this


pytest failures

Hi,
I built from master with Python 3.8, h5py 2.10.0, netCDF4 1.5.4, and hdf5 1.10.4.
Running py.test -v h5netcdf/  (with WITHRESTAPI not set) I got the following two failures:
FAILED h5netcdf/tests/test_h5netcdf.py::test_invalid_netcdf4[testfile.nc] - AssertionError: assert 'phony_dim_0' == 'phony_dim_1'
FAILED h5netcdf/tests/test_h5netcdf.py::test_invalid_netcdf4_mixed[testfile.nc] - AssertionError: assert 'y1' == 'z1'

Any idea what's up with these?
Tried again with h5py 2.8.0 and got the same result.  Strange, as it looks like the travis tests are passing.

What version of libnetcdf are you using? If I recall correctly, this requires a relatively recent bug-fix to libnetcdf.

@jready This is implemented in netcdf-c 4.7.3 and available in h5netcdf=0.8.0. Please reopen if still an issue.