rosbag2: 0.22.0-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository rosbag2 to 0.22.0-1:

upstream repository: https://github.com/ros2/rosbag2.git
release repository: https://github.com/ros2-gbp/rosbag2-release.git
distro file: rolling/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.21.0-2

mcap_vendor

No changes

ros2bag

No changes

rosbag2

No changes

rosbag2_compression
* Add message definition read API (#1292 <https://github.com/ros2/rosbag2/issues/1292>)
* rosbag2_storage: add type description hash to topic metadata (#1272 <https://github.com/ros2/rosbag2/issues/1272>)
* Contributors: james-rms

rosbag2_compression_zstd

No changes

rosbag2_cpp
* Add type_hash in MessageDefinition struct (#1296 <https://github.com/ros2/rosbag2/issues/1296>)
* Add message definition read API (#1292 <https://github.com/ros2/rosbag2/issues/1292>)
* rosbag2_storage: add type description hash to topic metadata (#1272 <https://github.com/ros2/rosbag2/issues/1272>)
* Fix for flaky TimeControllerClockTest::unpaused_sleep_returns_true test (#1290 <https://github.com/ros2/rosbag2/issues/1290>)
* Contributors: Michael Orlov, james-rms

rosbag2_examples_cpp
* rosbag2_storage: add type description hash to topic metadata (#1272 <https://github.com/ros2/rosbag2/issues/1272>)
* Contributors: james-rms

rosbag2_examples_py

No changes

rosbag2_interfaces

No changes

rosbag2_performance_benchmarking
* Add tests for rosbag2_performance_benchmarking pkg (#1268 <https://github.com/ros2/rosbag2/issues/1268>)
* Contributors: Michael Orlov

rosbag2_performance_benchmarking_msgs
* Add tests for rosbag2_performance_benchmarking pkg (#1268 <https://github.com/ros2/rosbag2/issues/1268>)
* Contributors: Michael Orlov

rosbag2_py
* Add type_hash in MessageDefinition struct (#1296 <https://github.com/ros2/rosbag2/issues/1296>)
* Store message definitions in SQLite3 storage plugin (#1293 <https://github.com/ros2/rosbag2/issues/1293>)
* Add message definition read API (#1292 <https://github.com/ros2/rosbag2/issues/1292>)
* rosbag2_storage: add type description hash to topic metadata (#1272 <https://github.com/ros2/rosbag2/issues/1272>)
* Contributors: Michael Orlov, james-rms

rosbag2_storage
* Add type_hash in MessageDefinition struct (#1296 <https://github.com/ros2/rosbag2/issues/1296>)
* Add message definition read API (#1292 <https://github.com/ros2/rosbag2/issues/1292>)
* rosbag2_storage: add type description hash to topic metadata (#1272 <https://github.com/ros2/rosbag2/issues/1272>)
* Contributors: Michael Orlov, james-rms

rosbag2_storage_default_plugins

No changes

rosbag2_storage_mcap
* Add type_hash in MessageDefinition struct (#1296 <https://github.com/ros2/rosbag2/issues/1296>)
* Add message definition read API (#1292 <https://github.com/ros2/rosbag2/issues/1292>)
* rosbag2_storage: add type description hash to topic metadata (#1272 <https://github.com/ros2/rosbag2/issues/1272>)
* Contributors: Michael Orlov, james-rms

rosbag2_storage_sqlite3
* Add type_hash in MessageDefinition struct (#1296 <https://github.com/ros2/rosbag2/issues/1296>)
* Store message definitions in SQLite3 storage plugin (#1293 <https://github.com/ros2/rosbag2/issues/1293>)
* Add message definition read API (#1292 <https://github.com/ros2/rosbag2/issues/1292>)
* rosbag2_storage: add type description hash to topic metadata (#1272 <https://github.com/ros2/rosbag2/issues/1272>)
* Contributors: Michael Orlov, james-rms

rosbag2_test_common

No changes

rosbag2_test_msgdefs

No changes

rosbag2_tests
* Add type_hash in MessageDefinition struct (#1296 <https://github.com/ros2/rosbag2/issues/1296>)
* Contributors: Michael Orlov

rosbag2_transport
* Read message definitions from input files in bag_rewrite (#1295 <https://github.com/ros2/rosbag2/issues/1295>)
* Add message definition read API (#1292 <https://github.com/ros2/rosbag2/issues/1292>)
* Move rosbag2_transport::Recorder implementation to pimpl (#1291 <https://github.com/ros2/rosbag2/issues/1291>)
* rosbag2_storage: add type description hash to topic metadata (#1272 <https://github.com/ros2/rosbag2/issues/1272>)
* Contributors: Emerson Knapp, Michael Orlov, james-rms

shared_queues_vendor

No changes

sqlite3_vendor

No changes

zstd_vendor

No changes

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/preparing-for-iron-branching-on-rolling-2023-04-18/30980/2


Members list is not refreshed when clicking on "Members" menu

Issue Summary
The list of members is not refreshed when clicking on the "Members" menu item.
To Reproduce

Go to "Members" in Ghost Admin to doublecheck your latest members.
Click on a different menu item (e.g. "Staff" or "Posts")
Sign up as a member on the site. Click on "Activate my account" in the confirmation email.
Go back to the Admin and click on Members

💥 The new member doesn't appear automatically in the list of members, only if you refresh the Admin. The member list should refresh when navigating to it.
Technical details:

Ghost Version: 3.32.0
Node Version: 12.18.1
Browser/OS: Firefox
Database: sqlite

The members list data is only refreshed once it's >60sec old when navigating around so that navigation speed away from then back to the members list is reasonable.

Closing as this is expected behaviour, but can reopen if we need to review the timeout.


DartPad on Safari can't view Flutter samples

DartPad on Safari attempts to compile Flutter code samples with the compile API call, as opposed to the compileDDC call used by Chrome. This leads to compilation errors from the dart-services backend, which isn't set up for compiling flutter on the compile path.

Where did you see this? Was it on the playground or one of the embedded layouts?

Where did you see this? Was it on the playground or one of the embedded layouts?

Main page, which I’m guessing is the playground?

I think this was resolved in the latest publish, which removed the popup for Safari. I can't replicate it.
(if you can, reopen)


[ENH] Added root endpoint with welcome message and API docs link

Closes #199

Changes proposed in this pull request:

Created root endpoint with welcome message and API docs link

Checklist

[X] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
[ ] PR has a label for the release changelog or skip-release (to be applied by maintainers only)
[X] PR links to GitHub issue with mention Closes #XXXX
[ ] Tests pass
[ ] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

3 of 4 (75.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 99.679%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/main.py
3
4
75.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
931

Relevant Lines:
934

💛  - Coveralls

output:

:rocket: PR was released in v0.2.0 :rocket:


No installed build tools found. Install the Android build tools version 19.1.0 or higher.

on my Mac，ionic build android

What went wrong:
A problem occurred evaluating root project 'android'.

No installed build tools found. Install the Android build tools version 19.1.0 or higher.

but i had install build tools? How to fix it?

Hello! Thank you for opening an issue with us!
The Ionic Framework issues list is designated for the reporting of bugs with the Ionic Framework or for requesting new features. As this seems like more of a support question I am going to close this issue.
I urge that you ask this question on our forum or on our slack channel.
Also, please make sure you have done the stuff shown here: https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html
Thanks for using Ionic!

I've the same issue.

Install Android Studio (NOTE: Chose SDK location to your root dir ~/Android)
Add the path to your ~/.bash_profile:
export ANDROID_HOME=/Android/sdk export PATH=$ANDROID_HOME/platform-tools:$PATH export PATH=$ANDROID_HOME/tools:$PATH
Quit your terminal and start again

Other things you might need in your bash_profile
export PATH="/Library/Frameworks/Python.framework/Versions/3.6/bin:${PATH}" export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home

I finally found the solution.

Please launch android studio. Then go to Preferences -> Appearance & Behavior -> System SEttings -> Android SDK. You will find "Android SDK Location".
In my PC, it's "/Users/{$user_name}/Library/Android/sdk".

Go to "SDK tools" tab and check "show package details". Please make sure Android SDK build tools 19.1.0 or higher is installed.

Edit .bash_profile and set ANDROID_HOME as "Android SDK Location" which you find in the Android Studio.
In my case,
ANDROID_HOME= /Users/{$user_name}/Library/Android/sdk
export PATH=${PATH}:$ANDROID_HOME/tools:$ANDROID_HOME/platform-tools

@marusker you're the man!

@marusker come on... you're the best

I had the same issue. Setting a system environment variable ANDROID_HOME to the proper location C:\Users...\AppData\Local\Android\android-sdk   fixed the issue.
Additional info: In that folder, you should have 'platforms' subfolder and there are downloads for Android SDK, for instance: folder 'android-24'  is for API 24 (Android 7.0). If you are missing API you would like to use for build download additional API with SDK manager.


Add support for suppressing response body via parameter

Adds supporting for suppressing the response body for status codes, that would otherwise include one, via a querystring parameter or header value.
Fixes #132

One final request - can you pop a note on the default view so that people know this exists/how to use it? After that, it's good to merge.


TypeScript rules

After talking with @bterlson today, here goes an initial list of rules for TypeScript we could implement:

[x] use strict mode
[ ] check if TS is installed globally and if so flag it as an error
[ ] inline sourcemaps is the most reliable way to use them
[x] importHelpers can help reducing the final size avoiding repeated code
[ ] esModuleInterop should be true and allowSyntheticDefaultImports shouldn't be set. This property helps avoid issues when the generated code is going to be used by another tool like Babel that might require the code differently.
[ ] decorators should be false
[x] forceConsistentCasingInFileNames should be true to avoid possible issues when working with *nix and Windows on the same project
[ ] Look into https://github.com/RyanCavanaugh/tsbuild, it's still early in the development but will be useful for monorepo projects and will have its own configuration file

One thing that came up during the conversation is to have a rule that will check that your bundle is the smallest one. This could actually be a mix of several checks, like importHelpers and no-comments and maybe other ones.
@sonarwhal/core I'm opening this issue so we can start the discussion, see if there's anything we can do initially, etc.
@bterlson if you know of someone else that could be interested in this kind of rules for TS please add them to the conversation.

[x] use strict mode (done in https://github.com/sonarwhal/sonarwhal/commit/69aab2d66a631b4213d0873416c15ebac5a644cd)
[x] importHelpers can help reducing the final size avoiding repeated code (done in https://github.com/sonarwhal/sonarwhal/commit/6565accdb94ece1c1a94b19c840a7fe8edede69d)
[x] forceConsistentCasingInFileNames should be true to avoid possible issues when working with *nix and Windows on the same project (done in https://github.com/sonarwhal/sonarwhal/commit/a9a97fca6f853b72d02151f4e7674bbf8f659b2c)

@DanielRosenwasser thanks for the feedback!

Closing in favor of https://github.com/webhintio/rfcs/issues/9


Add encrypted keys for Sonatype/Bintray

Problem
The Maven Central synchronization is not working (Travis CI is building the jars, but can't copy them to maven central).
Solution
This is the result of removing the previously encrypted keys, and running this script (authenticated as ReactiveSocketAdmin).
travis encrypt bintrayUser=*** --add
travis encrypt bintrayKey=*** --add
travis encrypt sonatypeUsername=*** --add
travis encrypt sonatypePassword=*** --add

Yay!


Document accesslog

We need to document our logger system.
Full process may take a while, let's start from access log.
@redixin please review.

Changed description for %t


Comment tree building / rebuilding exhibits odd behaviour.

After clicking a "Load more comments" button, for example, one of the nearby comments will sometimes be skipped over entirely in the newly built navigation tree.
I think it might be important to take another look at the comment tree system and make adjustments. Building the entire tree first - and then determining next/previous elements after the entire tree is built - may be beneficial.

I've reworked the system to build the whole tree at once. It is still unreliable with loaded sections for some reason. I'll need to take some more time to work on it.


Postgres wallet storage plug-in and related changes

Signed-off-by: Ian Costanzo<EMAIL_ADDRESS>Supersedes PR #1175 (refactor in-mem storage) - this PR includes:
Plug-in wallet storage for Postgres
Updates to CLI to register dynamic storage for wallets
And from the in-mem PR (1175):
Added a new shared library containing inmem wallet storage plug-in (to demonstrate and test dynamic storage loading).
Added python wrapper functions to load wallet storage from shared library.
Updated unit tests to optionally use dynamic storage rather than default via environment parameters:
STG_CONFIG - json configuration string to pass to the wallet on creation and open
STG_CREDS - json credentials string to pass to the wallet on creation and open
STG_TYPE - storage type to create
STG_LIB - c-callable library to load (contains a plug-in storage)
(if specified will dynamically load and register a wallet storage)
STG_FN_PREFIX - prefix for all plug-in functions (allows standard function naming)
For example to run tests against the inmem wallet:
STG_TYPE=inmem_custom STG_LIB=../samples/storage/storage-inmem/target/debug/libindystrginmem.dylib STG_FN_PREFIX=inmemwallet_fn_ cargo test issuer_create_and_store_credential_def_works

Updated to re-factor shared code (between libindy and storage plug-ins) into separate library.

We'll discuss all of these changes in the context of PR 1282.
https://github.com/hyperledger/indy-sdk/pull/1282


Error text is too pale

Set the error text color, like the text people see if they enter a taken game name, back to red.

Relates to gh-416.


Instruction to run the experiments

Hi @PaulDaoudi ,
Thank you for your amazing works!
I'm trying to run your code and reproduce your experiments in the FOOD's paper.
I have looked at readme file but couldn't find any instruction about it.
Could you please help me and give some instruction to run the experiments and get FOOD's results.
Thank you so much and have a good day.
Best.
Linh

Hi Linh,
I am glad that you took interest in our paper!
First, please note that the code is not entirely finished: some (minors) errors of my FOOD reimplementation (closely following the original code) must be corrected. It should be finished in the following weeks.
Second, the original trained policies are no longer available, but you can recreate them to gather the target trajectories and obtain the results. Here are the steps to follow:

Train an RL policy solely in the source and save the associated weights,
Gather trajectories of the target environment with this policy,
Filter the trajectories by removing any "bad trajectories" if they exist (for example the ones that lead to the robot's direct fall),
Train FOOD with the filtered trajectories.

I will keep you updated when the code will be entirely finished.
Thanks again for your patience and interest in our work!
Best,
Paul

@PaulDaoudi ,
Thank you for your reply.
As you mentioned about the original code, may I ask you where I can find it?
Second, about training the policy to gather the source trajectories, how can I train the policy? Do you provide any source code for training and gathering (filtering bad trajectories too) in your repo?
Thank you again and have a nice day.
Best,
Linh


Can't generate on OS X

When I run ./generate/generate.sh or ./generate.sh I get the following errors:
Traceback (most recent call last):
  File "generate.py", line 605, in <module>
    Visitor().visit(ast)
  File "/usr/local/lib/python3.4/site-packages/pycparser/c_ast.py", line 120, in visit
    return visitor(node)
  File "/usr/local/lib/python3.4/site-packages/pycparser/c_ast.py", line 127, in generic_visit
    self.visit(c)
  File "/usr/local/lib/python3.4/site-packages/pycparser/c_ast.py", line 120, in visit
    return visitor(node)
  File "generate.py", line 518, in visit_Typedef
    node.type.type.my_name = node.type.declname
AttributeError: 'Struct' object has no attribute 'my_name'
cp: generate/*.cr: No such file or directory
rm: generate/*.cr: No such file or directory

This is my environment:
Crystal 0.7.4
Python 3.4.3
CSFML 2.3
pycparser 2.14

As I recently found out, some release of pycparser made it so I can't write my custom data to its objects. This means that (at least for now) version 2.10 is the last version that works.
pip3 install --user 'pycparser<=2.10'

(--user is optional, I just like it)

https://github.com/BlaXpirit/crsfml/commit/9b7534de0af941b73da06f65a3a57c1afe65c4be
Let me know if this helps, and I'm also curious about why you need to generate.

@BlaXpirit I got it wrong. I should just require the .cr files, but I thought I had to compile them before using. Thank you anyway, your comment made me understand.


not working with zIndex

Guys,
At least in iOS 12 it is not working when position absolute zIndex is set.
Workaround is to not use zIndex and use view hierarchy correctly.

Another solution I've found is to nest the BlurView inside a View which can still have zIndex applied to it.


have you considered using google/nearby as a dependency?

Google offer NearBy library and it is open source.
even if you don't use it, it may speed up your understanding.
Great work!

I have, but, as with everything that comes out of Google, this library is way too complicated and generalized for its job.


Mat/Par : Parental Leave – Leave allowance dates content edits

Under the Parental Leave – Leave allowance dates:
This should be “intend”

Within the tab: Parental leave - leave allowance dates, the second bullet list has been updated with the word 'intend'

Perfect - Deploy ready!

tested in PROD, content change is updated correctly.


Deprecate VM stuck in status alerts

Signed-off-by: João Vilaça<EMAIL_ADDRESS>
What this PR does / why we need it:
In #7918, a few alerts were added but they are very opinionated and don't fit all clusters, creating noise for clusters that don't need them. It makes sense to remove them.
Fixes #8957
jira-ticket: CNV-23339
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Deprecate VM stuck in status alerts

/retest

/retest

/lgtm


Add support for load_in_8bit and trust_remote_code model params

Added support for load_in_8bit (allows the model to run with less vram) and trust_remote_code (enables running new models that aren't supported yet) in model params

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Related Issue: #419

Cool, thank you too!


⚠ Samsung has degraded performance

In e9b55c8, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2245 ms

Resolved: Samsung performance has improved in 7d5f94d.


fix startOffset

fixes #1079
fix drain parameter

can you add a test on that?

Not quickly, there is no existing proper test I could build upon

We need a unit test.


Issue on Create Request

Hi team,
We have an issue whereby we are using this library (version: 0.5.10) in Azure Function.
We have a code whereby it will create the record using this SDK, however we receive an issue from Azure Function as below:
We’ve detected that threads are mixing synchronous code with asynchronous code
Azure App Service has identified that 50 threads may be mixing synchronous code with asynchronous code. Application code is calling Task. Result and is synchronously waiting on the Task object, which can lead to deadlocks in the process.

The function calling Task.Result is Microsoft.PowerPlatform.Dataverse.Client.ServiceClient.ExecuteOrganizationRequestImpl(Microsoft.Xrm.Sdk.OrganizationRequest, System.String, Boolean, Boolean), but the entire thread's call stack should be reviewed to identify the blocking pattern. Please review the call stack closely and make sure that your code is using the C# await keyword.

GCFrame
HelperMethodFrame_1OBJ
System.Threading.ManualResetEventSlim.Wait
System.Threading.Tasks.Task.SpinThenBlockingWait
System.Threading.Tasks.Task.InternalWaitCore
System.Threading.Tasks.Task`1[[System.__Canon System.Private.CoreLib]].GetResultCore
System.Threading.Tasks.Task`1[[System.__Canon System.Private.CoreLib]].get_Result
Microsoft.PowerPlatform.Dataverse.Client.ServiceClient.ExecuteOrganizationRequestImpl
Microsoft.PowerPlatform.Dataverse.Client.ServiceClient.Create

Possible to know if it is our coding issue or the SDK problem?
Thank you for help.

For those calls you should be using await .CreateAsync
Can you check your code for that operation?

IOrganizationService itself is a Sync interface,
The 0.5.17 client has that capability, you would IOrganizationServiceAsync as the interface, that interface is only available in the Dataverse ServiceClient at this time,  You can cast from IOrganizationServiceAsync to IOrganizationService and back from a DvClient.. see : https://github.com/microsoft/PowerPlatform-DataverseServiceClient/blob/07b3400f94af784f12e488038222a2ef538321ab/src/GeneralTools/DataverseClient/Client/Interfaces/IOrganizationServiceAsync.cs#L16

@JounouchiAng Yes.. the DvServiceClient, and the OrgnaizationSerivceFactory(plugins) are both IOrganizationService based, You do not need to cast them when passing them to a method that accepts an IOrganizationService interface.
The Plugin Runtime does not currently support Async operations against the API, thus IOrganizationServiceAsync is not available there.
So you have a few choices,

You can live with the warning being generated from the Azure function execution.
You can call the service.create and wrap it with a Task.FromTask,
You can modify the version of your code running on functions to use service.CreateAsync

The last choice is what I recommend, and you can do that by creating a variant of your code that calls the local client using whichever call pattern your host us using.  that would let you share the logic of your code while externalizing the call to Dataverse using the Async pattern from an azure function and the sync pattern from within a plugin.

@JounouchiAng Please reopen this issue if the suggestions above didn't work.


Incorrent behavior of JSON.parse for id

Execute of select id from table where id=8216118575463666095 returns {id:<PHONE_NUMBER>463666000}
This problem describes in https://stackoverflow.com/questions/18755125/node-js-is-there-any-proper-way-to-parse-json-with-large-numbers-long-bigin
Bellow screenshot of execution manticoresearch-javascript client:

BTW it also fails in JQ version 1.6 (latest at the moment):
➜  ~ echo '{"id":<PHONE_NUMBER>463666095}'|jq .
{
  "id":<PHONE_NUMBER>463666000
}

➤ Nick Sergeev commented:
As this issue relates to the basic constraint of Javascript's number type  (Number.MAX_SAFE_INTEGER =<PHONE_NUMBER>740991), we now handle it by converting such data to string when parsing JSON response.


 Running the build copies the vanillajs/index.html file into the build directory. If so, maybe the build failed before it got to that part?
To fix it, try running yarn build-vanilla, which will run just that particular part of the build.

yarn build before yarn start


Milestone2_01-build-skeleton

I am on this.
What's done:

Dropdown menu with country

TBD:

Overall structure formatting
Radio buttons
Creating spaces for plots

Thanks Jake - by tomorrow do you think you can share the the updated code with us? We can provide some feedback and and begin to plug our functions in?


Fix for the LM_HEAD issue

(WIP) Fix for the LM_HEAD issue
Root Cause. The error is caused by incorrect segments passed to the lora_b_sgmv kernel during the prefill stage. This happens because we do not want to forward all the tokens in the prompt through lm_head and associated adapters. The goal is to save compute and memory by not having to forward the tokens that are not involved in generating the next token. Only the last token is needed for this purpose. However, doing this changes the shape of the net batch size (batch size times number of tokens) that the lora kernel sees, but the segment start and end tensors are not changed. These tensors are used to slice/segment the batch in the kernel. Hence, keeping them unchanged is incorrect. Additionally, the resulting error from this problem not reported correctly since the kernel has a catch-call condition that reports a generic kernel not found for the dtype message. My guess is that it's an out-of-bounds memory access, but confirming this would require changing the kernel. This is out of the scope of this investigation.
Description of the Fix. The fix simply goes over the adapters for lm_head and adjusts the segment start and end tensors to correctly point to the segments in the batch. For now, this is done only during the prefill stage and when a LoRA adapter for the lm_head is present.
Tests. TBD

Fixes #163
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Was this discussed/approved via a Github issue or the discord / slack channel? Please add a link
to it if that's the case.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Sounds good. Will make those changes and do a basic testing round with a few different model+LoRA combinations.


Getting error when using --aot

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Linux Ubuntu 16.04

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.18
node: 6.9.4
os: linux x64
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

Created by angular-cli
The log given by the failure.

Normally this include a stack trace and some more information.

sudo ng build --aot
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
  0% compilingError encountered resolving symbol values statically. Function calls are not supported. Consider replacing the function or lambda with a reference to an exported function (position 100:25 in the original .ts file), resolving symbol AppModule in /home/amerbank-dash/src/app/app.module.ts
Error: Error encountered resolving symbol values statically. Function calls are not supported. Consider replacing the function or lambda with a reference to an exported function (position 100:25 in the original .ts file), resolving symbol AppModule in /home/amerbank-dash/src/app/app.module.ts
    at simplifyInContext (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/static_reflector.ts:534:15)
    at StaticReflector.simplify (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/static_reflector.ts:538:18)
    at StaticReflector.annotations (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/static_reflector.ts:94:28)
    at _loop_1 (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/codegen.ts:77:48)
    at CodeGeneratorModuleCollector.readFileMetadata (/home/amerbank-dash/node_modules/@angular/compiler-cli/src/codegen.js:79:13)
    at /Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/codegen.ts:51:56
    at Array.map (native)
    at CodeGeneratorModuleCollector.getModuleSymbols (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/codegen.ts:51:33)
    at CodeGenerator.codegen (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/codegen.ts:124:5)
    at AotPlugin._make (/home/amerbank-dash/node_modules/@ngtools/webpack/src/plugin.js:186:43)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/@ngtools/webpack/src/plugin.js:151:75)
    at Compiler.applyPluginsParallel (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:156:14)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:463:8)
    at Compiler.applyPluginsAsync (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:73:70)
    at Compiler.compile (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:456:7)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:219:10)
    at Compiler.readRecords (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:367:10)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:216:9)
    at next (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:81:11)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/CachePlugin.js:34:58)
    at Compiler.applyPluginsAsync (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:85:13)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:213:8)
    at next (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:81:11)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/node/NodeEnvironmentPlugin.js:23:3)
    at Compiler.applyPluginsAsync (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:85:13)
    at Compiler.run (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:210:7)
    at /home/amerbank-dash/node_modules/angular-cli/tasks/build-webpack.js:26:29
    at Class.run (/home/amerbank-dash/node_modules/angular-cli/tasks/build-webpack.js:25:16)
    at Class.run (/home/amerbank-dash/node_modules/angular-cli/commands/build.js:50:26)
    at Class.<anonymous> (/home/amerbank-dash/node_modules/angular-cli/lib/models/command.js:152:17)
    at tryCatch (/home/amerbank-dash/node_modules/rsvp/dist/lib/rsvp/-internal.js:215:12)
    at invokeCallback (/home/amerbank-dash/node_modules/rsvp/dist/lib/rsvp/-internal.js:230:13)
    at publish (/home/amerbank-dash/node_modules/rsvp/dist/lib/rsvp/-internal.js:198:7)
    at flush (/home/amerbank-dash/node_modules/rsvp/dist/lib/rsvp/asap.js:85:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Mention any other details that might be useful.
Something here makes problem I think:
{
            provide: Http,
            useFactory: (xhrBackend: XHRBackend, requestOptions: RequestOptions, router: Router, getToken: AuthTokenService) => new HttpInterceptorService(xhrBackend, requestOptions, router, getToken),
            deps: [XHRBackend, RequestOptions, Router, AuthTokenService]
}

That part is in providers in app.module.ts and it uses to create http interceptor because there is no way in angular cli to add it with terminal.
Also I here is some nice features which can be really useful if it have in angular-cli:
-Add http intreceptors with command line
-Create routing with command line
-Integrate Angular Universal to have some command like this for example ng new AngularUniversalWithCli --au
-Integrate NativeScript with Angular-cli there is already pkg: https://github.com/wwwalkerrun/nativescript-ngx-magic but it would be useful if there is command like this in angular-cli: ng new AngularWithNativeScript --ns
Anyway thanks for awsome tool. Keep doing great job!

Thanks! We'll be in touch soon.

@vforv export the function for useFactroy. (also the latest version is beta 30 so I would also recomend updating)
export function interceptorFactory(xhrBackend: XHRBackend, requestOptions: RequestOptions, router: Router, getToken: AuthTokenService) {
     return new HttpInterceptorService(xhrBackend, requestOptions, router, getToken)
}
...
{
            provide: Http,
            useFactory: interceptorFactory,
            deps: [XHRBackend, RequestOptions, Router, AuthTokenService]
}
...

Thanks, it is look fixed but I get new error... Some problems with routes:
can't find symbol undefined exported from module /home/amerbank-dash/src/app/app.router.ts, resolving symbol AppModule in /home/amerbank-dash/src/app/app.module.ts, resolving symbol AppModule in /home/amerbank-dash/src/app/app.module.ts
Error: can't find symbol undefined exported from module /home/amerbank-dash/src/app/app.router.ts, resolving symbol AppModule in /home/amerbank-dash/src/app/app.module.ts, resolving symbol AppModule in /home/amerbank-dash/src/app/app.module.ts
    at simplifyInContext (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/static_reflector.ts:534:15)
    at StaticReflector.simplify (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/static_reflector.ts:538:18)
    at StaticReflector.annotations (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/static_reflector.ts:94:28)
    at _loop_1 (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/codegen.ts:77:48)
    at CodeGeneratorModuleCollector.readFileMetadata (/home/amerbank-dash/node_modules/@angular/compiler-cli/src/codegen.js:79:13)
    at /Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/codegen.ts:51:56
    at Array.map (native)
    at CodeGeneratorModuleCollector.getModuleSymbols (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/codegen.ts:51:33)
    at CodeGenerator.codegen (/Users/iminar/Dev/angular/modules/@angular/compiler-cli/src/codegen.ts:124:5)
    at AotPlugin._make (/home/amerbank-dash/node_modules/@ngtools/webpack/src/plugin.js:186:43)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/@ngtools/webpack/src/plugin.js:151:75)
    at Compiler.applyPluginsParallel (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:156:14)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:463:8)
    at Compiler.applyPluginsAsync (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:73:70)
    at Compiler.compile (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:456:7)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:219:10)
    at Compiler.readRecords (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:367:10)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:216:9)
    at next (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:81:11)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/CachePlugin.js:34:58)
    at Compiler.applyPluginsAsync (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:85:13)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:213:8)
    at next (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:81:11)
    at Compiler.<anonymous> (/home/amerbank-dash/node_modules/webpack/lib/node/NodeEnvironmentPlugin.js:23:3)
    at Compiler.applyPluginsAsync (/home/amerbank-dash/node_modules/tapable/lib/Tapable.js:85:13)
    at Compiler.run (/home/amerbank-dash/node_modules/webpack/lib/Compiler.js:210:7)
    at /home/amerbank-dash/node_modules/angular-cli/tasks/build-webpack.js:26:29
    at Class.run (/home/amerbank-dash/node_modules/angular-cli/tasks/build-webpack.js:25:16)
    at Class.run (/home/amerbank-dash/node_modules/angular-cli/commands/build.js:50:26)
    at Class.<anonymous> (/home/amerbank-dash/node_modules/angular-cli/lib/models/command.js:152:17)
    at tryCatch (/home/amerbank-dash/node_modules/rsvp/dist/lib/rsvp/-internal.js:215:12)
    at invokeCallback (/home/amerbank-dash/node_modules/rsvp/dist/lib/rsvp/-internal.js:230:13)
    at publish (/home/amerbank-dash/node_modules/rsvp/dist/lib/rsvp/-internal.js:198:7)
    at flush (/home/amerbank-dash/node_modules/rsvp/dist/lib/rsvp/asap.js:85:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Here is my routes file:
import {RouterModule} from '@angular/router';

import {LoginComponent} from './login/login.component';
import {RegisterComponent} from './register/register.component';
import {ActivateComponent} from './activate/activate.component';
import {BankComponent} from './bank/bank.component';
import {ForgotComponent} from './forgot/forgot.component';
import {RecoverComponent} from './recover/recover.component';
import {ShowbankComponent} from './showbank/showbank.component';
import {EditlenderComponent} from './editlender/editlender.component';
import {ShowlenderComponent} from './showlender/showlender.component';
import { BankmainComponent } from './bankmain/bankmain.component';
import { LendermainComponent} from './lendermain/lendermain.component';
import { DepartmentmainComponent } from './departmentmain/departmentmain.component';
import { ShowdepartmentComponent } from './showdepartment/showdepartment.component';

import {AuthTokenService} from './auth-token.service';

const routes = [
    {path: '', component: LoginComponent, as: 'login', useAsDefault:true},
    {path: 'register', component: RegisterComponent, as: 'register'},
    {path: 'forgot', component: ForgotComponent, as: 'forgot'},
    {path: 'recover/:code', component: RecoverComponent, as: 'recover'},
    {path: 'code/:code', component: ActivateComponent, as: 'activate'},
    {path: 'table', component: BankComponent, as: 'table', canActivate: [AuthTokenService]},
    {path: 'banks', component: BankmainComponent, as: 'banks', canActivate: [AuthTokenService]},
    {path: 'bank/:id', component: ShowbankComponent, as: 'showbank', canActivate: [AuthTokenService]},
    {path: 'edit/lender/:id', component: EditlenderComponent, as: 'editlender', canActivate: [AuthTokenService]},
    {path: 'show/lender/:id', component: ShowlenderComponent, as: 'showlender', canActivate: [AuthTokenService]},
    {path: 'lenders/:bankId', component: LendermainComponent, as: 'showlenders', canActivate: [AuthTokenService]},
    {path: 'departments/:bankId', component: DepartmentmainComponent, as: 'showdepartments', canActivate: [AuthTokenService]},
    {path: 'department/:departmentId/:bankId', component: ShowdepartmentComponent, as: 'showdepartment', canActivate: [AuthTokenService]}
];

export default RouterModule.forRoot(routes);

try exporting everything and see if the error goes away

Heya, errors like Error encountered resolving symbol values statically mean that there has been some problem in statically analyzing your app.
The CLI always runs statical analysis on code to ensure it will run when compiled with AOT. This may cause a lot of static analysis errors to surface when importing your project into the CLI, or upgrading for older versions where we didn't run this kind of analysis.
A good resource on how to to debug these errors is https://github.com/rangle/angular-2-aot-sandbox#aot-dos-and-donts.


TypeError AnnealedValue = list[float]

Description
Running python main.py --0 gives an error with TypeError.
  File "main.py", line 9, in <module>
    from nerf.provider_image import NeRFDataset as ImageOnlyNeRFDataset
  File "/data/ruihan/projects/realfusion/nerf/provider_image.py", line 13, in <module>
    from .options import Options
  File "/data/ruihan/projects/realfusion/nerf/options.py", line 13, in <module>
    AnnealedValue = list[float]
TypeError: 'type' object is not subscriptable```

### Steps to Reproduce

python main.py --0

### Expected Behavior

Run the code.

### Environment

Ubuntu 20.04, cudatoolkit 11.3.1, pytorch 1.11.0, transformers 4.28.1, diffusers 0.15.1

I tried  from typing import List, Tuple and changed
AnnealedValue = list[float]
radius_range: tuple[float, float] = [1.0, 1.5]
fovy_range: tuple[float, float] = [40, 70]

to
AnnealedValue = List[float]
radius_range: Tuple[float, float] = [1.0, 1.5]
fovy_range: Tuple[float, float] = [40, 70]

It passed the syntax check but got error
 /data/ruihan/projects/realfusion/sd/utils.py:15 in add_tokens_to_model                           │
│                                                                                │
│   12 │   # Loop over learned embeddings                                                          │
│   13 │   new_tokens = []                                                                         │
│   14 │   for token, embedding in learned_embeds.items():                                         │
│ ❱ 15 │   │   embedding = embedding.to(text_encoder.get_input_embeddings().weight.dtype)          │
│   16 │   │   if override_token is not None:                                                      │
│   17 │   │   │   token = override_token if isinstance(override_token, str) else override_toke    │
│   18                                                                                │

AttributeError: 'tuple' object has no attribute 'get_input_embeddings'

I also ran into this same issue (the tuple object having no attribute error).
What solved it for me was to downgrade the diffusers library from the latest version (0.15.1  as of the time I'm writing this) down to version 0.12.0. I ran the below command (and it should not affect other project dependencies):
pip install diffusers==0.12.0

I suppose the reason this happened is some functionality of the library became deprecated or was changed, returning incorrect objects. I narrowed it down to the class StableDiffusionModel in the sd custom module, where something goes wrong with newer versions.

That works for me, thanks a lot!

Hey @ManuelSerna and @RuihanGao,
I am facing few issues #16. If you have successfully implemented the code, could you kindly take a look at issue #16  and assist me.
Thank you.
Regards,
Anand Varrier


Failing e2e tests - scorecard-latest-release on ossf-tests/scorecard-action

Matrix: null
Repo: https://github.com/ossf-tests/scorecard-action/tree/main
Run: https://github.com/ossf-tests/scorecard-action/actions/runs/5204815554
Workflow name: scorecard-latest-release
Workflow file: https://github.com/ossf-tests/scorecard-action/tree/main/.github/workflows/scorecards-latest-release.yml
Trigger: push
Branch: main

rate limit related


discard extra snark work even if there is space and budget

When including snarks in a block, don't add "extra" snarks even if there is space and budget to do so

!approved-for-mainnet


The authorization mechanism you have provided is not supported

When I use your library I have the following error:
ClientError: An error occurred (InvalidRequest) when calling the PutObject operation: The authorization mechanism you have provided is not supported. Please use AWS4-HMAC-SHA256.
This is the bucket: https://s3.eu-west-2.amazonaws.com/k-media-s3-bucket/media/
DEFAULT_FILE_STORAGE = 's3_folder_storage.s3.DefaultStorage'
DEFAULT_S3_PATH = "media"
MEDIA_ROOT = '/%s/' % DEFAULT_S3_PATH
MEDIA_URL = 'https://s3.eu-west-2.amazonaws.com/%s/media/' % AWS_STORAGE_BUCKET_NAME
Any idea?

Hmm...
have you tried the django settings var:
AWS_S3_SIGNATURE_VERSION=True reference
or
the env var:
S3_USE_SIGV4=1 reference

For people facing  AWS4-HMAC-SHA256 error in django-storages (images not loading). Try using this values in settings.py:
if using boto3
AWS_S3_REGION_NAME = 'us-east-2' #change to your region
AWS_S3_SIGNATURE_VERSION = 's3v4'
if using boto
AWS_S3_HOST = 'us-east-2' #change to your region
S3_USE_SIGV4 = True

Thanks! Was stuck at that problem, exactly, and @Venka1995 's fix did the trick. It sure would be nice to simply solve this even in the library's code. I don't understand why the issue was closed.


Add Expressive Code to Starlight

What kind of changes does this PR include?

Changes or translations of Starlight docs site content
Changes to Starlight code

Description

Integrates astro-expressive-code into Starlight
Adds an expressiveCode config option & schema that allows configuring the integration.
Adds expressiveCodeI18nSchema including all translatable strings, similar to the Pagefind schema.
Adds information about the configuration options and i18n to the docs.
Closes #461

This is looking super great :tada: Amazing work!
I'll play more with it later and make a more thorough review but I have a few small questions:

Is the font change expected, shouldn't it respect --sl-font-system-mono? Same question for the font size.
I see you are using color-mix() which seems to have landed fairly recently on some browsers, e.g. March 2023 on Chrome, May 2023 on Firefox, and 10 days ago on Chrome for Android if I read that correctly. Could it be a concern? Wouldn't it be a bit too early to use it?
"file names/titles" in code block are not selectable, is that expected? I have to say, even more for new files, it's super handy to be able to quickly select it to copy it. At least that would be my expectation.

Again, great work! :clap:

Thank you for the valuable feedback, @HiDeoo!

Great catch regarding the font family & font size! I have now referenced the CSS variables var(--__sl-font-mono) and var(--sl-text-code) that Starlight also uses for inline code.
The file names / titles were not selectable due to a pseudo-element blocking the inputs. I have also fixed this. Thank you for testing this!
I intentionally only used color-mix() for a single border style that looked too prominent otherwise. If the browser does not support this function, the border will simply become transparent, which does not impact the overall look and usability in my opininon.

Wow, thanks for the quick and efficient updates and answers! Really appreciate it.

One small nits,

code blocks were slightly updated from sharp to rounded corners.
the syntax highlight seems to be different from the previous default

Before
After

Both correct, good observations!
The slightly rounded corners could be turned off by providing a styleOverrides setting of { borderRadius: '0' }. However, I honestly like the rounded ones better - especially in combination with the tabs. Starlight also has rounded corners in other places like the next/previous page navigation buttons at the end of pages, so I hoped that this is close enough. 😄 If it's a hard requirement to keep the previous style, we could of course change the defaults.
The different syntax highlighting colors are a result of different default themes. Starlight only supported a single theme before and used custom CSS variables to make this one theme work in both dark and light mode, while Expressive Code supports freely definable separate dark and light themes and uses the GitHub dark and light themes as the default. If you have another VS code / Shiki theme in mind that you'd like to use instead of github-dark, please let me know. We could even develop our own themes, which might be interesting from a branding perspective! I just picked these ones for now because they are already bundled with Shiki and seemed to be a popular choice.

I have a bit more high-level question (and I am also curious ^^).
With these changes, we would be shifting away from the css-variables theme to the good old shiki approach of rendering & shipping every code blocks twice. According to this comment from Fred, there was a bit of a pushback from the Astro community regarding that last approach, which is what actually led to the css-variables theme. I am wondering if with Starlight's emphasis on page weight, this could also be a concern?
Was any thought or experimentation done regarding using shikiji (Anthony Fu ESM-focused rewrite of shiki) which replaces the css-variables theme by a new interesting approach to support light/dark themes? Or maybe the idea would be to wait until this is ported back to shiki itself, if that ever happens, as this seems to be the plan?

I'm honestly not a big fan of the CSS variables theme as it's making it impossible to ensure an accessible color contrast ratio when adding annotations to code. Expressive Code puts an emphasis on accessibility by always checking the color contrast and tweaking the syntax highlighting colors when necessary. With CSS variables, it cannot know what the actual syntax token color is going to be, so we might end up with bad accessibility. Due to this, I even intentionally disabled the CSS variables theme in Expressive Code.

Just had a look at Shikiji, and an approach like this definitely looks more promising than the CSS variables theme to me!
However, themes in Expressive Code are more than just syntax highlighting. The themes provide a full spectrum of UI colors as well, and these will be used by plugins like frames to render editor tabs, terminal windows etc., all of which Shikiji doesn't address because it seems to be focused on syntax highlighting only.
I think we can (and I will) explore approaches for more efficient multi-theming for sure, but this would take a considerable amount of time and should not be done in the scope of this PR in my opinion.

I totally agree with you regarding the css-variables theme approach to use CSS variables to read the colors for the tokens.
The shikiji new approach to use CSS variables to actually store the colors on each token is a very interesting one indeed and I was curious to get your opinion on it (hence the "more high-level question" comment). Thanks for taking the time to detail how theming works in Expressive Code as this is not something I'm in-depth familiar with and also your plans to explore more ideas. 🙌 Very interesting!
PS: Definitely outside the scope of this PR to experiment with this, I agree.

Sure thing! I love both Orta's and Anthony's work on this and think that a Shikiji-like approach might work even for UI theming in Expressive Code. Finding a way to get efficient multi-theme output is on my roadmap as well. Thank you for all the valuable input and context!

Ok, so I couldn't get this out of my head and experimented with CSS variable-based approaches to multi-theming inspired by Shikiji - and it seems to work!
One of the next Expressive Code releases will always generate a single output per code block, no matter how many themes you define. The theme-based parts of the UI (everything you can see in styleOverrides) will all be migrated to CSS variables, too.
This migration will take me a while though, so I think it's your decision whether the current version is good enough for Starlight and we'll integrate it now and just upgrade the dependency later when the new rendering is available, or if you'd rather want to wait for the more efficient multi-theme rendering. I know how much we are focused on performance and minimal footprint (and I care a lot about that myself), but I also know how many devs are already waiting for Expressive Code features like text markers or the copy button. 😄 Probably not easy to decide - I'm fine with both options!

Ok, so I couldn't get this out of my head and experimented with CSS variable-based approaches to multi-theming inspired by Shikiji - and it seems to work!

Oh boy, this is all my fault. I'm so sorry. Altho, I find it excellent news to know that the discussion could lead to some improvements in that area and that their approach could potentially work in a way more complex setup like the one from Expressive Code. :tada:
Personally, and it's only my own opinion of course, I think it would be fine to pursue with the proposed changes in this PR and later, when it's ready, upgrade the dependency. This would mean people can benefit from the amazing Expressive Code features as soon as possible. When I mentioned the double rendering, I did that asking in a question if it could be a concern because I have no idea personally so maybe some other people will have a better idea about it.

No worries at all! It's not your fault if you provide great input to successfully nerd-snipe me! 😄

A few more high-level comments:

I think the code blocks section in the Authoring Content in Markdown guide could be updated to describe some new syntaxes added by Expressive Code? It may also be worth linking to the Expressive Code docs for Markdown/MDX usage for the frames and text markers plugins?
There are many places in the documentation where we could use some Expressive Code text markers, but I guess it may be easier to add them in a follow-up PR. I'll try to prepare a list of places where I think we could use them.

A bit late to the party so feel free to disregard, but when we were doing some work on other UI components the Starlight design system has a pattern of interactive components having rounded corners and non-interactive having square corners. Here's a link to the Figma file in case you wanted to take a peek: https://www.figma.com/file/GrDkcguAR7tSWPFuLVDixq/Theme---Starlight-Docs?type=design&node-id=1%3A2&mode=design&t=ypLDqrL9TDbNrovJ-1
Regardless, I'm super excited to see this and I know myself (as well as some of our readers over at Tauri) are excited for it! 🥳

The migration to the new efficient multi-theme rendering is complete now. :) I also implemented all review suggestions. Please have a look if there is anything else you'd like to change!

Thank you for the amazing work!
Would it make sense to mention expressive-code in the "Authoring Content in Markdown" page and maybe show a simple example?

Would it make sense to mention expressive-code in the "Authoring Content in Markdown" page and maybe show a simple example?

That's a great idea! I'll have a look and add some examples that I already wrote for the Expressive Code docs. :)

I added some examples to the Authoring Content in Markdown page to highlight the features provided by Expressive Code.
Thank you @Genteure and @HiDeoo for this suggestion!

I'm not sure if it was visible enough from my previous commit message: EC is now no longer inlining its CSS, but creating an immutable stylesheet with a hashed file name instead that can be cached indefinitely by browsers. The HTML size difference should be negligible now.

Thank you for that performance improvement @hippotastic!
Here’s my table again to show the impact. Since the last comparison, we migrated to Vercel, so these are now Brotli compressed HTML responses instead of GZip:

route
Prod
EC PR
change

/getting-started/
12.97k
13.27k
+0.30k  (+2%)

/manual-setup/
11.32k
11.79k
+0.47k  (+4%)

/guides/css-and-tailwind/
13.36k
14.24k
+0.88k  (+7%)

/reference/configuration/
14.17k
16.10k
+1.93k (+14%)

(The /reference/configuration/ one seems bigger, but bear in mind that this PR also adds a new section the reference page.)

Nice! And we should also keep in mind that this size already includes two independently configurable themes with full syntax support, whereas the current Starlight code blocks only have a single limited CSS variables theme.

Btw, I just updated to the latest version of astro-expressive-code to add the automatic frontmatter block cleanup logic we discussed in the context of Astro Docs. It's also affecting one location in the Starlight docs:
Before:

After:


Kanban board icon

Describe the requested icon
A kanban board icon similar to the existing colums/rows icons.

Added kanban in v1.4.0!


Setup pre-commit black'ing and linting similarly to dandi-cli

@yarikoptic It is set up; the configuration is copied directly from dandi-cli.  In what way is it not working appropriately?

@yarikoptic It is set up; the configuration is copied directly from dandi-cli.

d'oh -- my bad, indeed it is there and I see the pre-commit hooks in .git/hooks.

In what way is it not working appropriately?

for #34 I managed to do locally commit and then push to only get linters unhappy with fixes to follow in https://github.com/dandi/dandischema/pull/34/commits/f129f151cb229fd496eb3cee6ba8022d7e397ed4 (unused imports, comments format), and https://github.com/dandi/dandischema/pull/34/commits/a27108402e0b3a78d4ff1b9aed0a99af9173432b (too long lines).
May be there is a quick way to just run tox -e lint as part of the precommit to at least ensure (but IIRC for dandi-cli I have black splitting long lines etc) that I am not committing with a lint?

just an fyi. this is the pre-commit file i'm using in nobrainer and this will take care of a lot of the issues. https://github.com/neuronets/nobrainer/blob/master/.pre-commit-config.yaml
(that repo also has the precommit-ci setup).

@yarikoptic Black just does formatting; it doesn't care about unused imports.  It also, for some reason, doesn't edit comments beginning with multiple #'s despite those sometimes being rejected by flake8.  As for long lines, if they're long because they contain a long string, black won't break the string up (but I think that might be on black's to-do list).
One wouldn't run tox itself through pre-commit; one would instead directly run the lint commands it runs.

ok, could we run the lint command we use for tox?


update mk.php

translation for february was not correct and it causes problems with createFromFormat method. it was 'фебруари' and it should be 'февруари'.

Can someone confirm this? :)

@ichernev proposed февруари too on moment:
https://github.com/moment/moment/blame/develop/src/locale/mk.js#L8

Hello @jenssegers still no plan to upgrade to Carbon and rely on our translation instead of maintaining the whole thing twice?


Failed to load of Read-only permission PDF

What were you trying to do?
Now there is a read-only permission PDF that I want to split
How did you attempt to do it?
Call the load method directly
await PDFDocument.load(pdfBuffer)

What actually happened?
error - unhandledRejection: Error: Input document to PDFDocument.load is encrypted. You can use PDFDocument.load(..., { ignoreEncryption: true }) if you wish to load the document anyways.
What did you expect to happen?
I have read the readme and encryption related issues and understand that processing encrypted documents is not currently supported
But i realize what I'm meeting is a permissions issue, can it be handled in this case?
How can we reproduce the issue?
Relevant attachments have been uploaded

Screenshot of open the  PDF through edge browser
PDF file

Version
1.17.1
What environment are you running pdf-lib in?
Node
Checklist

[X] My report includes a Short, Self Contained, Correct (Compilable) Example.
[X] I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes

（There is no link to the pdf file for now, I can provide it if needed）

I'm having the same issue, did you found a solution @ppbl ?


processor queued_retry is deprecated.

https://github.com/open-telemetry/opentelemetry-helm-charts/blob/f8c80ed4f4d5ebd518236ef8f8b8d342f8234a80/charts/opentelemetry-collector/values.yaml#L17

QueuedRetry processor is deprecated. Use exporter queued retry config.

reference

Close as there is already #19.


Cannot reset my password anymore - server does not send mails

When I try to reset my passwort and type in the correct email I got the following message

and no mail

On sunday we updated/upgraded the ubuntu-18.04 of out prod machine. Now it has the same level as our test machine. This may be the cause of the problem.
But: Mail to internal and external adresses works fine with the test server.

The upgrade of Ubuntu lead to a restriction in name resolution. The name of the postfix server me-roblab-prod could nor be resolved anymore. Changes in the start parameters of the server are needed: Instead of me-roblab-prod the ip address of the gateway of the docker network ora-net (that is <IP_ADDRESS> on the prod machine) has to be used

fixed with changed mail properties


support aarch64

[x] Add CI test in aarch64 https://github.com/chaos-mesh/chaosd/pull/168
[x] #196
[ ] Find replacement of endpoint-repo on arm for CentOS
[ ] Publish aarch64 chaosd binary
[x] #197

For the first task, I don't know where the https://mirrors.chaos-mesh.org/latest/stress-ng comes from :cry:

I fork a repo to build static stress-ng in https://github.com/chaos-mesh/stress-ng/releases

Is arm64 supported now?


[wip] Precision Plugins should be part of Training Type Plugins

🚀 Feature
Precision Plugin should be a property of the training type plugin, not the accelerator. these can overlap, and interleaving sequences of operations across the two in the accelerator can be challenging to get fully right.
cc @justusschock @awaelchli @tchaton
todo:  fill out in more detail

Motivation
This would make management of things like this easier:

https://github.com/PyTorchLightning/pytorch-lightning/issues/7271
https://github.com/PyTorchLightning/pytorch-lightning/issues/7217

Pitch

Alternatives

Additional context

@ananthsub This was discussed quite a few times already now and I think the agreement was to change this, when we maybe also move the accelerator inside the training type plugin
cc @SeanNaren

Thanks @ananthsub for making this. I recall doing an initial POC of this a few months back and realised there is quite some work to make this change when being careful of BW compat.
It would also make these 'shell' classes obsolete, like we see with deepspeed: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/plugins/precision/deepspeed_precision.py
all the above logic should live within the TrainingTypePlugin really. We do have to be careful though, I do like distinctions to remain (precision logic to be separate if possible).

It might be helpful to compare how the implementation of one training type or plugin would look if this was done. As it stands, it is not clear to me exactly what the benefits of this are


split_size_or_sections

Sorry, my English is not very good. Why split_size_or_sections is  self.hidden_dim? There are only 4 variables to receive the result, I think self.hidden_dim should be changed to 4
44     cc_i, cc_f, cc_o, cc_g = torch.split(combined_conv, self.hidden_dim, dim=1)

Author is right.becacuse the second parameter(split_size_or_sections) of  torch.split means the size of each chunks splited from the original tensor.


Error in @sap/cds: 3.34.1

In version 3.34.1 of CDS, there is a bug in one of the method. stack trace is attached. a Patch fixing the issue is attached as well.
basic correction is to check if the object is undefined before applying a function to it.
Since I fixed the issue locally, this is locally not a big deal. On CF Deployments it is a problem, unfortunately, as I would need to apply the patch on postinstall or something.

==== patch ====
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -820,7 +820,7 @@

 const _generateCQN = (context, columns, serviceName, model) => {
   // TODO: How to get from context? Maybe with new CSN
-  if (context._.odataReq.getUrlObject().path.endsWith('SiblingEntity')) {
+  if (context._.odataReq && context._.odataReq.getUrlObject().path.endsWith('SiblingEntity')) {
     return _siblingEntity(context, columns, model)
   }

also filed as SAP Incident 333945 / 2020

not supported scenario. Got a different way to get the required data without running into this issue


How to get rate and delay of the current connection hotspot?

I want to get the rate and delay of the hotspot，I don't understand the meaning of your return the ping information.
I get the ping information :
{      "requestTimeout":false,    "stat":{         avg:"17.134",       max:"67.707",       min:"4.703",       packetLoss:"0",       stddev:"22.657",       time:"33409"    } }
can you help me?

the plugin is discontinued.


Shipping address is disabled after selecting Billing address

What I'm trying to achieve
I'm trying to implement a new payment gateway (Mercado Pago). For some reason, after and empty initialization using saleor-platform, I go to checkout to check everything is working.
Steps to reproduce the problem

Use saleor-platform to build the project but first using the 3.4.1 release in saleor and saleor-dashboard and the latest changes in react-storefront
Add some products to the cart and go to checkout.

What I expected to happen
Be able to select the shipping address to proceed with the payments
Screenshots and logs

System information
saleor 3.4.1
saleor-dashboard 3.4.1
react-storefront main
Saleor version:

[ ] dev (current main)
[x] 3.0
[ ] 2.11
[ ] 2.10

Operating system:

[ ] Windows
[x] Linux
[ ] MacOS
[ ] Other

Also, the logs of the server don't say anything and the developer console of the browser is without any error even in the network tab


CLOUDP-57844: List matcher fields, Atlas

Jira ticket: CLOUDP-57844
Checklist

[x] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code

Further comments

waiting on https://github.com/mongodb/go-client-mongodb-atlas/pull/70


Allow manual install

Relying on Composer for the installation is causing us one big problem: the library can't be installed via our distribution's package manager. If you don't use Composer for the install, then Recaptcha doesn't work out-of-the-box: none of the class includes are in the files that use them. (This also crashes the test suite.)
The least-intrusive way to fix this (I could also have re-added the require statements?) was to supply a simple autoloader along with the library. This allows users to include the src/autoload.php even without Composer present on the target machine. Distributions can package src/autoload.php normally since it doesn't have to be generated on-the-fly. Finally, the test suite can bootstrap using it -- so now the test suite will run from a clean checkout.

CLA is signed.

Thanks @orlitzky I'll take a look at this over the weekend.

Thanks, I'm not married to this particular implementation, but I didn't want to show up empty-handed =)
If you'd prefer to do it some other way I can always rewrite and send another PR.

Thanks again, @orlitzky and sorry for taking a while to jump back on this. I've made some comments. If you're happy to do the changes that would be cool, otherwise I'll drop an implementation in sometime in the next few days.

Thank you for merging this! I should be able to package the next release for inclusion in Gentoo.


tests: fix eval unit tests

Looks like they are actually broken since the introduction
of justWarning.
It is not a big deal, because the correct behaviour of the
code is ensured by the functests, which are reportedly OK.
The test themselves are a bit fragile and needs to be improved.
Signed-off-by: Francesco Romani<EMAIL_ADDRESS>

/cc @ksimon1 let's discuss this patch


Standard nomenclature (pt, pt-br)

I realized in pt and pt-br have some different things than others. In english and some other languages, the first of the characters is in uppercase. So why is different in pt and pt-br?
I started to implement the change, missing the tests yet and adjust in locale/pt. But I wonder if I can adjust.
Note: DON'T merge this PR yet. Tests Failing.

@caio-ribeiro-pereira what do you think.
@raphamorim you will need to fix the tests

Yeah @ichernev, I talked about it.
I'll finish the code, if makes sense apply this changes :)

For me it's okay!

but one simple question, why all nomenclature are strings to be splited instead a simple array?

Good question @caio-ribeiro-pereira.
I'll finish the changes and update this PR at the morning (I'm out of my macbook now).

Oh! I realized this happens in others locales. So I adjust pt and en too. :octocat:

Simple array is more characters. Compare
["a", "b", "c", "d", "e", "f"]
"a b c d e f".split(" ")

Well, its kind of a hack, but we use it for all locales, so its not a big problem.
I'll merge this in next release.

Well I didn't know about this hack, but in my opinion it's not necessary
worry about hacks when you are building javascript client-side libs because
when you minify it, a lot of js hacks are applied to make the code smaller
and faster.
Att,
Caio Ribeiro Pereira
Software Engineer
http://crpwebdev.com
On Apr 17, 2015 1:12 AM, "Iskren Ivov Chernev"<EMAIL_ADDRESS>wrote:

Simple array is more characters. Compare
["a", "b", "c", "d", "e", "f"]"a b c d e f".split(" ")
Well, its kind of a hack, but we use it for all locales, so its not a big
problem.
I'll merge this in next release.
—
Reply to this email directly or view it on GitHub
https://github.com/moment/moment/pull/2328#issuecomment-93889418.

Merged in 0843b0e5944639038975611f46dda45243c88234


Gummi Skip mod just removes worlds.

I'm sure I downloaded everything right, but just in case I'm uploaded photos of my files.  Playing on epic games and I had the gummi skip mod before the update and it worked.
P.S. Discord link is also expired.

I will look into this shortly, I am not really the maintainer for 2FM stuff as I just translate what Sonic does into a more uniform format so might take a bit. Thanks for the heads up on the link it will also get replaced with a non expiring one.

Never mind found what I messed up should be going up later today.


How does it compare to nuclei

How does nuclei compare to this? To be frank, I don't understand nuclei or this that good. Any benchmarks possible?

Also another question, Monoio says this on their README.md:

Monoio can not solve all problems. If the workload is very unbalanced, it may cause performance degradation than Tokio since CPU cores may not be fully utilized.

Am I right in guessing this is also valid for compio?

How does nuclei compare to this? To be frank, I don't understand nuclei or this that good. Any benchmarks possible?

Its io-uring impl is unsound, and I don't know about other parts. Its API does not count into completion-based IO (so does entire Rust eco system, basically) and does nothing to guarantee the safety (e.g., adding a shim buffer like we do) , so...

Am I right in guessing this is also valid for compio?

Well, yes. Compio is not a silver bullet.
CPU balance is always a hard problem. On Linux, io-uring is optimized for single-threaded runtime, which means the CPU is unbalanced if the workload is unbalanced.
In addition, if you wouldn't like the runtime taking the ownership of the buffers, tokio is still the better choice, because the language design of Rust is not fully suitable for completion-based async.


More query types

See https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-bool-query.html

We really miss must_not)


[firebase_admob] Provide a default MobileAdTargetingInfo for RewardedVideoAd.load()

Description
Provides a default MobileAdTargetingInfo for RewardedVideoAd.load() method to be aligned with MobileAd's implementation as follows:
abstract class MobileAd {
  /// Default constructor, used by subclasses.
  MobileAd({
    @required this.adUnitId,
    MobileAdTargetingInfo targetingInfo,
    this.listener,
  }) : _targetingInfo = targetingInfo ?? const MobileAdTargetingInfo() {
    assert(adUnitId != null && adUnitId.isNotEmpty);
    assert(_allAds[id] == null);
    _allAds[id] = this;
  }
...

Related Issues

https://github.com/FirebaseExtended/flutterfire/issues/44

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@bparrishMines Added a test for RrewardedVideoAd. Please review and let me know whether it's okay or not.

It looks like the integration tests have stopped passing after I added the version bump. They haven't passed after re-runnning them either. I'll try and see if I can get them to pass before merging.

I'm going to go ahead and merge this since the failing tests seem to be flaking in PRs. I'll revert if this doesn't pass the test on master.


These tests were accidently left out when I moved #2621 to master

I found these when answering someone's questions.  Mo tests, mo better!
\cc @chef/client-core

:+1: pending travis

:+1: Yay tests!


Pingback without express

It's a bit hard to figure out, how to use pingback without express.
Could you give an example on how to do that?

You can use the middleware without express, since express middleware is like any other function that takes a callback.
var Pingback = require('pingback')
  , http = require('http');

var ping = Pingback.middleware(function(source, target) {
  console.log('Successful ping from: ' + source.href);
});

http.Server(function(req, res) {
  ping(req, res, function(err) {
    if (err) console.log(err);
  });
});

Thank you.


Update sbt-scalafmt to 2.2.0

Updates org.scalameta:sbt-scalafmt from 2.0.7 to 2.2.0.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-scalafmt" } ]

labels: semver-minor

Codecov Report

Merging #735 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #735      +/-   ##
===========================================
- Coverage    89.38%   89.34%   -0.04%
===========================================
  Files          114      114
  Lines         8955     8955
  Branches       330      330
===========================================
- Hits          8004     8001       -3
- Misses         951      954       +3

Impacted Files
Coverage Δ

...ala/com/twitter/algebird/ApproximateProperty.scala
72% <0%> (-10%)
:arrow_down:

...ain/scala/com/twitter/algebird/AdaptiveCache.scala
72.22% <0%> (-5.56%)
:arrow_down:

.../main/scala/com/twitter/algebird/Successible.scala
87.5% <0%> (-4.17%)
:arrow_down:

...src/main/scala/com/twitter/algebird/Interval.scala
84.34% <0%> (ø)
:arrow_up:

.../main/scala/com/twitter/algebird/BloomFilter.scala
95.13% <0%> (+0.44%)
:arrow_up:

.../main/scala/com/twitter/algebird/Applicative.scala
61.76% <0%> (+5.88%)
:arrow_up:

...in/scala/com/twitter/algebird/scalacheck/Gen.scala
100% <0%> (+9.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c54fc4...366e243. Read the comment docs.


Add support for Solidity structs

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
When structs are passed as function parameters, or return values, or emitted in an event, the abi produced for them is actually a tuple. An array of structs is a tuple[]. This is done so that both the name and the type of the internal struct fields are available in the abi.
Right now we don't support this. It isn't a big deal right now. Since we don't support making state changing calls, we only care when calling a contract function that returns contract storage data, and it is returned as a tuple, or if an event is emitted a struct (I have yet to see an event do this, but that doesn't mean we won't come across it soon).
Note that Neither rust web3 or web3js support it yet (web3js will be in the next version).
Also Note, solidity has a tuple type, but we aren't concerned about this here. We are concerned specifically about the tuple produced in the ABI from a struct.
But.... we still have to deal with the ABI Error
So, if we don't support it, we should give a better error message, or else skip these functions and events all together. Right now the error is:
Failed to generate types: Failed to generate types for contract ABIS: Error: Failed to generate types for contract ABI: Unsupported type: tuple
I had to delete about 20 functions out of the 0x contracts, which was cumbersome, and makes the argument for skipping these. This also makes me wonder, should we really be importing the WHOLE abi ? Because this error was caused by functions I was not even using. If we required the .json file for the ABI to only contain the exact events and functions used in the subgraph, it would avoid errors as such. However, I do see that the UX of just taking the compiled abi directly from solc is also nice. I am unsure of which is better. I suggest leaving it as is for now.
How to fix this issue
I think making the error message better should be done should be done. Skipping the functions so it doesn't error out does not provide the user with the information that events and functions from the abi were not made into types for assembly script, and so they might expect a type to exist that never got created.

Would love this feature. This is currently preventing me from using this project. 0x v2 emits structs in events and I am working on a project that makes use of this heavily. It's a shame web3js@beta still doesn't have this feature but ethers does. There's also a lot of patterns where functions return structs, and this also seems to be unsupported.

Yep, we'll look into it, either by trying to contribute it to ethabi or to our own codebase.

Tracked here: graphprotocol/graph-node#766.


AddRecordCommand Related Classes

Coverage decreased (-2.0%) to 76.501% when pulling a994afdb89651483d36e673c99281dbe2358598d on iMarbles:dev-add into d3d3449b42e83ad8fa99863424abee646d39b963 on CS2103-AY1819S1-W16-2:master.


Container Startup Fails on daemon start: opendkim

Hey guys,
tried to provision a container instance for my kopano environment today. The initial container startup and also the following startups  are failing at the daemon start function:
1155 function _start_daemons_opendkim()
I am using LDAP as user store, and also as mentioned in #478 the opendkim setup logic is not supporting ldap user store at the moment.
How to Reproduce:
In this example I'm not providing any config folder as volume mount (that's why I'm using ENABLE_LDAP, otherwise Startup procedure would fail, complaining about no users for postfix specified):
docker run --hostname "test.domain.com" -it --rm -e ENABLE_LDAP=1 -e DMS_DEBUG=1 --name mailtest tvial/docker-mailserver:latest
Starting mail server
 Starting cron  [ OK ]
 Starting rsyslog  [ OK ]
 Starting dovecot services  [ OK ]
 Starting opendkimfalse
  *  [ FAILED ]
Error: Please fix your configuration. Exiting...

Investigation:
start-mailserver.sh is calling /etc/init.d/opendkim start
This fails because opendkim is expecting the file KeyTable at /etc/opendkim/KeyTable (as defined in the config file for opendkim).
Starting OpenDKIM: opendkim: /etc/opendkim.conf: refile:/etc/opendkim/KeyTable: dkimf_db_open(): No such file or directory

Proposal/Fix:
The easiest thing would be to extend the _setup_dkim() function (Line 722):
[...]
if [ -e "/tmp/docker-mailserver/opendkim/KeyTable" ]; then
		[...]
	else
		notify 'warn' "No DKIM key provided. Check the documentation to find how to get your keys."

                # >>>
                local _f_keytable="/etc/opendkim/KeyTable"
                [ ! -f "$_f_keytable" ] && touch "$_f_keytable"
                # <<<
fi
[...]

I created the folder + file myself manually in config/ directory and the issue went away.
It would be great if this could be fixed automatically by the startup script.

Related to #491


Show progress

All the benchmarks can take long time to complete. And in the meantime, there is no user feedback. It would be nice to have some progress information.

Initial simple progress has been added but it can be improved even more.


Adding workflow key and annotations props

Signed-off-by: Tihomir Surdilovic<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
Please specify parts this PR updates:

[ x] Specification
[x ] Schema
[ ] Examples
[ ] Extensions
[ ] Roadmap
[ ] Use Cases
[ ] Community
[ ] TCK
[ ] Other

What this PR does / why we need it:
Adds workflow key and labels properties
key: an alternative workflow unique identifier (in case where id is auto-generated). id and key are mutually exclusive
labels: list of helpful terms describing the workflows intended purpose
Special notes for reviewers:
Additional information (if needed):

approved in team meet today. merging


PRO-2588: Add support for verifying via fingerprint template

Currently, only verifying via fingerprint image is supported. If we're going to push templating into the client, then we need to support verifying via template.
Signed-off-by: Jeff Kennedy<EMAIL_ADDRESS>

Looks good! Do you think we should have 2 tests - 1 for images 1 for templates to ensure the switching logic works?

Good call. Just enhanced the fingerprint e2e test suite to include a test using a template.


wslg windows not able to be placed in fancyzones

Microsoft PowerToys version
0.77
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
Open any gui window from wsl2 using wslg
✔ Expected Behavior
I was expecting that a wslg window would behave similar to all my other windows in terms of snapping and fancyzones placement
❌ Actual Behavior
The wslg windows seem to completely ignored by fancyzones
Other Software
No response

/dup #10942


Move main.py

There, I fixed your repo's organisation for you. There's no need for a main folder, so why not remove it? 👀

Git gave a warning that mentioned some kind of conflict in terms of whitespacing; here's what it said:

warning: CRLF will be replaced by LF in main.py.

This has something to do with the whitespace encoding techniques used in both macOS and Windows, and that they're different. Just be careful, I guess!

You argue that the main.py file is the only file within the main folder, and that this clashes with the overall organisation. However, I would require you to think about what organisation is. What is it based on, and why? Is a single file within a folder really a problem?
Let's think back to the original purpose of a folder, to contain paper. Say you only had a single practice paper within said folder, would you simply throw that folder away and stow your raw paper? No, because the point of the folder is to categorise that paper within said folder.
Now, let's apply that concept to the organisation of a repository. If we had simply thrown out the main.py program from the main folder, it would get mashed along with the rest of the files within the repository, leaving users confused about what needs to be ran or accessed to get GroceryScraper running.
Hence, I will be closing this pull request for this said reason within 24 hours. If you are able to come up with a reason for me to merge this pull request, it will be closed on the 26th of Februrary, 11:47:20.

Hey @karlorjalo, thank you for sharing your two cents on the matter. While you have made good points, it's imperative for me to share some of my own as well. I reckon we need the involvement of @kohjasper and @N4G4-54I to be the judges here — it's critical to have a non-biased source to make the final decision, and I firmly believe you believe so too.
I'll start by mentioning your analogy on folders. While your point remains valid that folders are to categorise files, the same case can be said to be unnecessary in this instance. I refer to the content in the main directory — or more of the lack thereof. There is one Python file, main.py, and nothing else inside. While you are right that physical folders help to maintain the quality of physical files, the same may not be applied to digital folders. Folders are used to categorise and group like files together; in your instance, there is only one. Doesn't this make your folder system redundant? Unless you do intend to have multiple files of similar categories nested together, it has no use for just one file.
I'll also like to raise my point that having a redundant folder like main is counter-productive to the efficiency of developing the code. In practically every OS a common user would use — Windows, macOS, maybe even Linux —, their file systems would list folders along with other files in the same directory but not the contents. This would make navigation much harder — especially when many folders are involved (take macOS, where there is already /Users/<username>/ required to be appended before anything else). This can be seen to be counter-productive since it'll take more time for a developer to navigate to the right directory.
You mentioned that moving main.py to the root directory will result in it mixing with other files in your repositories. You will have two files, in that instance — main.py and README.md. Given that I'm a user who has no idea which to run, which of the two would I likely pick? One that says "read me", or the other which looks like code at first glance?
My case still stands that main.py should be brought out to the root of the repository directory. Thanks and have a great day!


update tungstenite, tokio-tungstenite

Update tungstenite and tokio-tungstenite to 0.24.0

Released as 0.15.0! Thanks!


tensorflow: 1.15.2 -> 1.15.3

Motivation for this change
tensorflow 1.15.3 was released.
The first commit fixes the build for opt-einsum (see PR #93107), but I also wanted to check whether tensorflow builds.
Actually, my main motivation for this is that I want to upgrade bazel to 3.4.1, but they removed the --incompatible_disable_deprecated_attr_params command line flag, which is used by dm-sonnet. So I tried to upgrade dm-sonnet, hoping that they would not need this flag anymore. But that did not work because it depends on tensorflow and tensorflow did not build because of the broken test in opt-einsum.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Tensorflow doesn't seem to build for me with python 3.7 or 3.6, did it build for you when you opened this PR?

seems to fail with:
tensorflow/python/lib/core/bfloat16.cc:607:25: note:   no known conversion for argument 2 from '<unresolved overloaded function type>' to 'PyUFuncGenericFunction' {aka 'void (*)(char**, const long int*, const long int*, void*)'}
tensorflow/python/lib/core/bfloat16.cc:645:36: error: no match for call to '(tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>) (const char [8], <unresolved overloaded function type>, const std>
  645 |                       compare_types)) {

With how often tensorflow_1 breaks. It's largely amazing to me that it ever builds.

I'm skeptical you can get tensorflow 1.15 to work with anything but bazel 0.26 - see https://github.com/tensorflow/tensorflow/blob/v1.15.3/configure.py#L52-L53.
Is tensorflow 1 still being actively used in the community? I was hoping we could fix tensorflow 2 derivations, then remove the tensorflow 1 stuff.

looks like the older bazel packages were restored, it should be able to call bazel with the older versions.

We are still using TF 1.x. Please keep it around, I hope to find a revision that works.

Is tensorflow 1 still being actively used in the community?

There are still projects that haven't migrated, e.g. https://github.com/photoprism/photoprism/issues/222

Tensorflow doesn't seem to build for me with python 3.7 or 3.6, did it build for you when you opened this PR?

I started this PR before leaving for vacation and I just got back. I can't really remember, but I think it did not finish successfully.

I'm skeptical you can get tensorflow 1.15 to work with anything but bazel 0.26 - see<EMAIL_ADDRESS>
I am not trying to build tensorflow with an updated bazel version, it's just that dm-sonnet is build with bazel 3 and tensorflow needs to be build as a dependency. I don't fully understand why. :thinking:

seems to fail with:
tensorflow/python/lib/core/bfloat16.cc:607:25: note:   no known conversion for argument 2 from '<unresolved overloaded function type>' to 'PyUFuncGenericFunction' {aka 'void (*)(char**, const long int*, const long int*, void*)'}
tensorflow/python/lib/core/bfloat16.cc:645:36: error: no match for call to '(tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>) (const char [8], <unresolved overloaded function type>, const std>
  645 |                       compare_types)) {

With how often tensorflow_1 breaks. It's largely amazing to me that it ever builds.

Apparently, this is caused by an ABI change of numpy 1.19.0 - see https://github.com/tensorflow/tensorflow/issues/40688

This PR should unblocked by #98083

Since #98083 has been merged, this is ready to review.

Tensorflow is already at 1.15.4


fix: Add dependency boto3 to solve issues#1618

solving https://github.com/OpenDevin/OpenDevin/issues/1618

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@6150ab6). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1619   +/-   ##
=======================================
  Coverage        ?   62.67%
=======================================
  Files           ?       92
  Lines           ?     3754
  Branches        ?        0
=======================================
  Hits            ?     2353
  Misses          ?     1401
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Strange Y axis values with statsd counters

I've got a statsd counter used to record each time certain events happen. It seems like statsd and ultimately graphite are receiving the messages just fine, but I'm getting weird fractional Y axis value:
http://i.imgur.com/hCCDU5A.png
I'm always incrementing by 1, so I'm expecting the Y axis to be 0 to some arbitrary integer instead of 0 to arbitrary fractional values.
Any ideas? This seems like super weird behavior.
Here's my storage-schemas.conf:
# Schema definitions for Whisper files. Entries are scanned in order,
# and first match wins. This file is scanned for changes every 60 seconds.
#
#  [name]
#  pattern = regex
#  retentions = timePerPoint:timeToStore, timePerPoint:timeToStore, ...

# Carbon's internal metrics. This entry should match what is specified in
# CARBON_METRIC_PREFIX and CARBON_METRIC_INTERVAL settings
[carbon]
pattern = ^carbon\.
retentions = 60:90d

[stats]
priority = 110
pattern = .*
retentions = 10:2160,60:10080,600:262974

I've been seeing similar issues.  I've tracked it down to being dependent upon the size of the time range over which the data is being viewed.  For example, the following is the same data set shown over 3 different size time intervals:
2 Months:

1 Week:

1 Day:

The left-hand graphs are the monotonic count, and the right-hand graphs are the derivative.  As you can see, each change should be a count of 1, so all the derivatives should be 1.  However, they're around 0.04 for the 2 month graph, 0.33 for the 1 week graph, and (correctly) 1 for the 1 day graph.
This illustrates that the underlying data is sound (as confirmed with the format=raw parameter) but the rendering of it gets more inaccurate as the time interval increases.
This isn't a critical issue for me, but it would be nice to see a solution.

I am new to graphite graphs, I am also facing the same problem with y axis value.
Any one got sollution?

A I only one who doesn't get what the problem is?
For me all graph looks completely sane.
As documentations of derifative() says " This function does not normalize for periods of time, as a true derivative would. Instead see the perSecond() function to calculate a rate of change over time."

I have a counter metric which increases by 1 at a time,
the first graph renders when I select time range of 1 day, and 2nd graph rendered when I select time range of 1 week.
The y-axis value changing according to time but i need the fixed Y-axis value without fractional values(exact count of metric).

@sravanireddyl:
What you mean "i need the fixed Y-axis value without fractional values(exact count of metric)"?
You need logins per second/minute/hour ? Use perSecond() and scale it as documentation says.
Or, if perSecond() is not in your Graphite - use scaleToSeconds(nonNegativeDerivative(...),1) - which is exactly the same. But it still be fractional too, I think, because of rounding errors.

scaleToSeconds(nonNegativeDerivative(...),60) will give you logins per minute, scaleToSeconds(nonNegativeDerivative(...),3600) - per hour/etc

@deniszh
Thank you for your reply.
I have applied functions "scaletoseconds" and "nonNegativeDerivative", still am getting the graph with fractional values as below.

How can i identify number of logins per minute with that graph.?
(This question seems to be silly to you but I am very new to all these graphs and dashboards.)

scaleToSeconds(nonNegativeDerivative(...),60) will give you number of logins per minute. But I don't think it will be exact integer, because of nature of derivative and rounding errors.

But the value changing when I change the date range.

Then it's depends on your storage schema. By default retention function is avg, but for counters it's need to be sum. Check this article for details - http://www.franklinangulo.com/blog/2014/5/20/graphite-series-3-whisper-storage-schemas-aggregations

Is this issue resolved ? I am facing the same issue

@bilal-fazlani - it's not Graphite issue, it's your storage schema / aggregation issue. Could you please check links above -  http://www.franklinangulo.com/blog/2014/5/20/graphite-series-3-whisper-storage-schemas-aggregations ?
What's your /opt/graphite/conf/storage-schemas.conf and /opt/graphite/conf/storage-aggregation.conf looks like?

storage-aggregation.conf
[min]
pattern = \.lower$
xFilesFactor = 0.1
aggregationMethod = min

[max]
pattern = \.upper(_\d+)?$
xFilesFactor = 0.1
aggregationMethod = max

[sum]
pattern = \.sum$
xFilesFactor = 0
aggregationMethod = sum

[count]
pattern = \.count$
xFilesFactor = 0
aggregationMethod = sum

[count_legacy]
pattern = ^stats_counts.*
xFilesFactor = 0
aggregationMethod = sum

[default_average]
pattern = .*
xFilesFactor = 0.3
aggregationMethod = average

storage-schemas.conf
[default]
pattern = .*
retentions = 10s:6h,1min:6d,10min:365d

[catch_em_all]
pattern = .*
retentions = 10s:6h,1min:6d,10min:365d

This confused me for a while as well. I sent a few test counts via nc and the Y values on the graph are incorrect for a 60 minute time range, but correct for 59 minutes or below.
Here's at a 60 time range:

Then at 59 minutes:

You can see the Y values in the second screen shot are correct, but the first screen shot shows values that are half of what they should be.


txn: return lock info in CheckTxnStatus

What is changed and how it works?
Async commit recovery needs to get the min_commit_ts of the primary key through CheckTxnStatus. https://github.com/pingcap/kvproto/pull/671 changes CheckTxnStatus to return the whole lock info instead of part of it. This PR implements the proto change.
Related changes

https://github.com/pingcap/kvproto/pull/671

Check List
Tests

Unit test

Release note
Part of async commit

/run-integration-tests tidb=pr/19563

/run-integration-tests tidb=pr/19563

/run-integration-tests tidb=pr/19563

/run-all-tests

/merge


Adds vendor property to physical_server

Adding vendor property to physical_server by this migration

Travis got error from OpenStack. Do anybody know something?

@Odravison master is 🔴 , so you are inheriting that problem.  I believe #14495 was put together to solve it, but it is not working.  Once that one is merged, then this one should be ok.

Odravison master is :red_circle: , so you are inheriting that problem. I believe #14495 was put together to solve it, but it is not working. Additionally, #14505 also seems to be helping. Once those are merged, then this one should be ok.

Thanks, @Fryguy

Why this PR wasn't already merged?

@Fryguy Can you please merge this?
I need this migration to be able to review/test https://github.com/ManageIQ/manageiq-ui-classic/pull/755. Thanks.

@simaishi I am ok with this coming back to fine, but we might run into issues because of the numbering  cc @carbonin I might need your help on this...it might need to be renumbered (not sure how that will affect devs)

@Fryguy thanks. @carbonin let me know about renumbering... there is also https://github.com/ManageIQ/manageiq/pull/14277 and https://github.com/ManageIQ/manageiq/pull/14644

Marking as fine/conflict for now due to numbering issue/concern (https://github.com/ManageIQ/manageiq/pull/14277#issuecomment-292642376)

Fine backport details:
$ git log -1
commit c9d35e1f7adae6496d351dd9746abb680bf9e62a
Author: Greg Blomquist<EMAIL_ADDRESS>Date:   Tue Apr 4 17:01:16 2017 -0400

    Merge pull request #14488 from Odravison/migration_to_physical_server

    Adds vendor property to physical_server
    (cherry picked from commit 77ebf9317a62822cec8a75514df14c24f772f908)