add option to change log level

This is one possible solution to #57.
This way the current functionality is kept as default but gives the user the option to choose another logging level.
I am not sure how to write a unit test to check where the log message is being printed (ideas are welcome), so I just tested it locally.

Thanks for this very clean PR! Initially, I thought it would be better to just use rospy.logerr_throttle() or even better rospy.logerr_throttle_identical(). This would have the advantage that we could do it locally inside the convert_dictionary_to_ros_message function and wouldn't have to make the external API more complex. But then I realized this isn't possible because we don't call rospy.init_node() (and don't want to).
So in the end I believe your PR is the best solution. Thanks, merging!


Explain possible Internal (Embedded) vs External Browser version (capabilities) mismatch.

It seems it might be beneficial to point out that -- especially for cutting-edge web platform features -- the Internal (Embedded) viewer may be few versions behind the External (Desktop) counterpart on the same machine.
STR for the record / those interested:
HTML document
<!DOCTYPE html>

  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <meta name="color-scheme" content="dark light">
  <title>useragent string and css color mix support test</title>

Color-mix support is:

In the Embedded / Internal browser of current VSC Insiders:

In regular Edge:

Anecdotally, I've ran into this particular problem in the very first (re-)encounter with this otherwise absolutely awesome extension, and it indeed took me some time to find out why I see different things in the Internal and External views (hence the STRs). For me it was the color-mix() CSS property, that became supported quite recently (2023-03) in Chromium v.111 (that came to Electron in v24 (?)), yet current VSC Electron version v22.3 in Insiders apparently contains only Chrome v.108-ish.

BTW, whilst command is called "Live Preview: Show Preview (Internal Browser)", this feature seems to be consistently called "Embedded [something]" in the Readme. Maybe also opportunity for some unification?

Sure, yes it makes sense, Chrome 114 from Electron 25 in that screenshot indeed supports the feature in demo STRs, that was introduced in 111.
I just meant that more as an example - subject of this issue is to prevent confusion and clarify that Internal and External views may show differences stemming from different versions (even though both can happen to use same engine).
For example current stable Chromium used in production versions of major Chromium-based browsers is still one version ahead: 115, according chromiumdash -- matches what I see when looking what current Edge on my machine -- so there are potentially other features that folks will see working in their desktop browsers and not in the Embedded views.  Presumably everything mentioned in "new in 115" article , but haven't verified.
Sure, folks hitting this issue will most probably be aware of the fact they are using "cutting-edge" features and that VSCode has its own rendering engine different from their browser, but considering from my aforementioned experience event then it may cost some time to investigate.
Optimal solution from my point of view would be if the readme (/ extension's description) contained this information straight away, ideally even with Chromium / V8 versions that it will use in the embedded views. (I guess the latter is not possible, since that's something extensions cannot control.)


Vfs::child : Name comparison fails due to extra whitespace

Old german mod Karibik has the world PINTA_GANG.ZEN but the corresponding trigger_change_level has attribute level_name="PINTA_GANG.ZEN " with a trailing whitespace. When triggered in OpenGothic loading does not work because the extra whitespace makes the equality check fail in Vfs::child.
Original Gothic works so it seems whitespaces are ignored there.

Yes, that would be correct. Gothic has its own hand-rolled file path parsing implementation which fully parses paths passed into it and re-creates them again before opening a file. Potential fix: in VfsNode::child and VfsNode::remove, trim trailing whitespace from name.

Could you verify if 9e8458ed fixes this issue, please?

Not sure if this is the same bug, but I just noticed the file "OW_FIREDRAGON_ VOLCANO_03-C.TEX" would not be found within my  "Textures.vdf" archive of Gothic 2 NOTR, even though the file is there.

Issue is gone, thanks.


OS dependent path for vaults

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[x] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[ ] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
When additional vaults are created in Windows, paths in dendron.code-workspace and dendron.yml are stored using \ as path separator; this causes dendron not to fetch them if you later try use the same repository under linux.
    "folders": [
        {
            "path": "dependencies\\localhost\\work\\notes",
            "name": "work"
        },

workspace:
    vaults:
        -
            fsPath: dependencies\localhost\work
            selfContained: true
            name: work
        -

Apparently, dendron already handle this correctly for other settings (e.g. "pasteImage.path": "${currentFileDir}/assets/images"), so I tried to do the same, and that (ie manually changing \ to /) solved the issue.
To Reproduce
Steps to reproduce the behavior:

Create a workspace in Windows
Add another (local) vault
Remove the line from .gitignore so that it will be in the same repository
Commit to remote repository
Restore in Linux

Expected behavior
Should be able to use all vaults in Linux, too
Desktop (please complete the following information)

OS: Windows, Linux
Versions (all that apply to bug):

Dendron Extension: 0.97.0
VS Code version: 1.67.2
Dendron CLI:

Thanks for the report. Agreed that Dendron should either normalize the paths when writing them, or when reading them.

Hi! Starting with 0.101, Dendron will always use UNIX-style paths for new vaults. For existing vaults, you'll need to manually update them. Please let us know if this issue continues to happen.


Classnames are hyphenated, too.

I like the simplicity of your system, but it hyphenates classnames, too. I'd suggest to exclude all attributes, classnames, ids, etc.

That would take away from the simplicity of the system. :-)
If I understand it correctly you pass your entire HTML to the hyphenation function. That is not how this library should be used.

Then what's the use of your system, if I can only have one paragraph hyphenated, and cannot even have a essential text in that paragraph?

The library is basically not for hyphenation of a HTML page, but for any other application written in JavaScript or TypeScript that needs a hyphenation method.
In my case I use it in a word processing like application and only every pass to it the words at the end of a line that no longer fit into the line.
For your case you could traverse the DOM and pass to it the content of every innerText attribute (not innerHTML!). But there are other libraries that are especially designed to deal with hyphenation on a HTML page. Please take a look at this answer here: https://stackoverflow.com/questions/16886258/which-javascript-library-should-i-use-for-client-side-hyphenation/54514561#54514561

The library is basically not for hyphenation of a HTML page, but for any other application written in JavaScript or TypeScript that needs a hyphenation method.
FC: You could've fooled me, with the JS Fiddle example... I guess I'll have to stay with the more complicated systems then. I knew them already but like  said, I liked the simplicity of yours. Thanks for the replies.

You are right that the example can fool someone into believing that the library should be used to hyphenate HTML. But since it only scans the input string for hyphenation points and insert a specified hyphen character at those point, one should not pass HTML as an input string. Otherwise not only class names but also tag names (eg: section) will get hyphenated.
As said one solution could be to traverse the DOM tree recursively and only every pass text nodes to the hyphenation function. But that needs some tinkering around on ones own and why not use Hyphenopoly.js for this task then, if it was especially created for HTML pages in the first place.
PS: This library is not "mine". I've just contributed one bugfix to the code so far.

@FrankConijn @krisztianb prevent HTML hyphenation added in v1.3.0

@ytiurin How does it work? Is it an optional feature?

@krisztianb same as before but now it skips everything between angle brackers like this <will not hyphenate>will hyphenate

So if I have a very long text and now add < at the beginning and > at the end, the entire text isn't hyphenated anymore?
Or consider the following text:

In math we can have operators like xx to define if something is greater or less then.

Would this also deactivate hyphenation for the <y and we can also use y> part? :-)
Is it possible to deactivate this? This might have unwanted side-effects in the application (a simple word processor) I'm using your library. :-(
I really like the simplicity of your library. It has the single purpose of hyphenating text. Removing/ignoring HTML should not be part of the library imho. If somebody has such a problem he/she should use another library to remove HTML first and then use yours to hyphenate.

@krisztianb sure, I will make it a seperate option with old behavior as default

@ytiurin Great! Thanks a lot. 👍

@krisztianb sure, I will make it a seperate option with old behavior as default

OK, but how to activate it then? How to use that option?

@FrankConijn there is an example on the start page (README). You need to use the hyphenation function that has HTML in its name: hyphenateHTML or hyphenateHTMLSync.
Or if you are using the createHyphenator factory function, you must pass HTML: true as option. There is also an example for that on the REAME page.

You're overestimating my knowledge. With all your answer details, I wonder: how, where?

What exactly are you trying to achieve? Where do you want to use the library? Did you follow the installation instructions?

Your questions are clearly and plainly answered at the beginning of this thread. And in other threads in which you've replied. If you don't want to help me, please don't reply. Otherwise, please take the JS Fiddle as departing point and help me to get it working, including leaving the HTML tags alone.

I know that it is frustrating to get things done when you are not that tech savvy. I'm not the maintainer of the package and I'm also not responsible for how this library is documented. I'm really trying to help you out here. Sorry, that I didn't read the original question. I hope that the answer given here #23 is going to help you. Good luck. :+1:


change to improve fbdirect functioning

This solves bug described in issue 81, we can study enhancements to support regexps, to indicate places in sentences where bot response may vary without being incorrect (e.g weather of a city, the city name and the forecast could vary)

Got build output:
/home/rof/src/github.com/codeforequity-at/testmybot/src/helpers/jasmine.js
13:66  error  Extra semicolon                     semi
16:30  error  Trailing spaces not allowed         no-trailing-spaces
17:14  error  Missing space before =>             arrow-spacing
17:17  error  Missing space after =>              arrow-spacing
18:32  error  Missing space before =>             arrow-spacing
18:35  error  Missing space after =>              arrow-spacing
19:13  error  Expected space(s) after "if"        keyword-spacing
19:20  error  Missing space before opening brace  space-before-blocks
20:24  error  Extra semicolon                     semi
22:19  error  Extra semicolon                     semi
23:13  error  Extra semicolon                     semi
11 problems (11 errors, 0 warnings)
11 errors, 0 warnings potentially fixable with the --fix option.
please run "npm run build" before pushing to avoid such eslint errors.
Some days ago I wrote a "contribution guide", but it's just a start ... https://github.com/codeforequity-at/testmybot/blob/master/CONTRIBUTING.md

by the way, i don't know if the Codeship output is visible to you as contributor ?

Regexps are supported - there is a capability named "SCRIPTING_MATCHING_MODE" (possible values: regexp, include, includeLowerCase, equals). by default, the "includeLowerCase" is used, but when switching to regexp, the bot response is treated as regular expression


Pygeos installation doesn't work with python 3.11

pip install pygeos didn't work with python 11 on  Windows.
I tried pygeos version 0.10, 0.12, 0.13, all didn't work.
Here is the error message
(ibrusenv) PS C:\Users\aniwax\Documents\GitHub\iBrusCoreSim> pip install pygeos==0.12
Collecting pygeos==0.12
  Downloading pygeos-0.12.0.tar.gz (141 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 141.4/141.4 kB 8.2 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: numpy>=1.13 in c:\users\aniwax\documents\github\ibruscoresim\ibrusenv\lib\site-packa
(from pygeos==0.12) (1.23.4)
Building wheels for collected packages: pygeos
  Building wheel for pygeos (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for pygeos (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [65 lines of output]
      Could not find geos-config executable. Either append the path to geos-config to PATH or manually provide the ude_dirs, library_dirs, libraries and other link args for compiling against a GEOS version >=3.5.
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build\lib.win-amd64-cpython-311
      creating build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\constructive.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\coordinates.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\creation.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\decorators.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\enum.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\geometry.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\io.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\linear.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\measurement.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\predicates.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\set_operations.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\strtree.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\testing.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\_version.py -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\__init__.py -> build\lib.win-amd64-cpython-311\pygeos
      creating build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\common.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_constructive.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_coordinates.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_creation.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_creation_indices.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_geometry.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_io.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_linear.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_measurement.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_misc.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_predicates.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_set_operations.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_strtree.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\test_testing.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      copying pygeos\tests\__init__.py -> build\lib.win-amd64-cpython-311\pygeos\tests
      running egg_info
      writing pygeos.egg-info\PKG-INFO
      writing dependency_links to pygeos.egg-info\dependency_links.txt
      writing requirements to pygeos.egg-info\requires.txt
      writing top-level names to pygeos.egg-info\top_level.txt
      reading manifest file 'pygeos.egg-info\SOURCES.txt'
      adding license file 'LICENSE'
      writing manifest file 'pygeos.egg-info\SOURCES.txt'
      copying pygeos\_geometry.c -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\_geometry.pyx -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\_geos.c -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\_geos.pxd -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\_geos.pyx -> build\lib.win-amd64-cpython-311\pygeos
      copying pygeos\_pygeos_api.pxd -> build\lib.win-amd64-cpython-311\pygeos
      UPDATING build\lib.win-amd64-cpython-311\pygeos/_version.py
      set build\lib.win-amd64-cpython-311\pygeos/_version.py to '0.12.0'
      running build_ext
      building 'pygeos.lib' extension
      creating build\temp.win-amd64-cpython-311
      creating build\temp.win-amd64-cpython-311\Release
      creating build\temp.win-amd64-cpython-311\Release\src
      "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29910\bin\HostX86\x64\cl. /c /nologo /O2 /W3 /GL /DNDEBUG /MD -IC:\Users\aniwax\Documents\GitHub\iBrusCoreSim\ibrusenv\include -IC:\Users\an\AppData\Local\Programs\Python\Python311\include -IC:\Users\aniwax\AppData\Local\Programs\Python\Python311\Include \Users\aniwax\AppData\Local\Temp\pip-build-env-qbniyqoa\overlay\Lib\site-packages\numpy\core\include "-IC:\Program s (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29910\ATLMFC\include" "-IC:\Program Files (x86)rosoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29910\include" "-IC:\Program Files (x86)\Windows Kits\10\ide\10.0.19041.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\shared" "-IC:\Program Files (xWindows Kits\10\include\10.0.19041.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt" "-ICogram Files (x86)\Windows Kits\10\include\10.0.19041.0\cppwinrt" /Tcsrc/c_api.c /Fobuild\temp.win-amd64-cpython-311ease\src/c_api.obj
      c_api.c
      C:\Users\aniwax\AppData\Local\Temp\pip-install-_1zaabxl\pygeos_d9dff3765b834eccab5867e3e841624b\src\geos.h(13arning C4068: unknown pragma 'GCC'
      C:\Users\aniwax\AppData\Local\Temp\pip-install-_1zaabxl\pygeos_d9dff3765b834eccab5867e3e841624b\src\geos.h(14arning C4068: unknown pragma 'GCC'
      C:\Users\aniwax\AppData\Local\Temp\pip-install-_1zaabxl\pygeos_d9dff3765b834eccab5867e3e841624b\src\geos.h(15atal error C1083: Cannot open include file: 'geos_c.h': No such file or directory
      error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Tools\\MSVC\\14.28.29\bin\\HostX86\\x64\\cl.exe' failed with exit code 2
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pygeos
Failed to build pygeos
ERROR: Could not build wheels for pygeos, which is required to install pyproject.toml-based projects

Is the solution similar to this issue, https://github.com/pygeos/pygeos/issues/358 ?

The solution mentioned here worked https://github.com/pygeos/pygeos/issues/358.
But I guess it would be nicer if this works out of the box

Any updates on when pygeos wheels for 3.11 will be released?

Sorry for the late reply, there is now a PR up over here: https://github.com/pygeos/pygeos/pull/458


Added support for resource-specific destination table for API Management

Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes

Adds support for setting resource-specific destination table in diagnostic setting for API Management

Breaking Changes
Testing Evidence

Testing URLs
The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Azure US Gov (Fairfax)

As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[ ] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[ ] Ensured contribution guidance is followed.
[ ] Updated relevant and associated documentation.
[x] Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

Hi @chrholt, the branch you are submitting from is quite far behind what is currently live. Kindly update your fork, and address merge conflicts please.

Opened a new PR #1324
Closing this one.


Update quanta to 0.11.0

This resolves RUSTSEC-2020-0168

Closing: addressed in 9805689.
Thank you for your contribution regardless, since it jumpstarted me to do this as part of some other long overdue maintenance. :)

Any plans, when this will be released?

Released as<EMAIL_ADDRESS><EMAIL_ADDRESS>and<EMAIL_ADDRESS>


[5.2] Added third parameter to Collection::slice to preserve keys

See #13697
The definition of Collection::slice now matches slice and array_slice

Preserve keys should just be the default. If you don't wnat keys call ->values() after calling this method.


Updated and fixed ZMX Metric Reference docs.

Made docs up to date according to latest ZIO Metric API.
partially closes #21

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Vladislav Ugryumov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@petoalbert thank you for your review! I fixed typos and removed any ZMX reference from this part of doc as we discussed with @adamgfraser in a Discord.
I suppose that ZMX references should also be removed from other parts of doc.
I could do it in this PR or in another one.

Thank you @Grryum . If you could rename all the other ZMX references in this PR, that would be nice.

@petoalbert I tried to remove all ZMX references from docs and sources. Also tried to actualize samples.
I did not touch main README.md and could not recreate some of screenshots with ZMX references. Don't know if it matters.
Please check it out.
@calvinlfer your turn :)

Thank you @Grryum! I think the README needs a significant update anyway, so we can do that later.


Updated info about PATCH requests

Based on the description provided by the RFC 5789 specification,
I believe that PATCH requests are not necessarily idempotent (in the same vein as POST requests).
I'm quoting the specific lines from that document for reference:

PATCH is neither safe nor idempotent as defined by [RFC2616], Section
9.1.
A PATCH request can be issued in such a way as to be idempotent,

@adhulipa Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@adhulipa Thank you for signing the Contributor License Agreement!


Fish shell always start in absolute root / rather than in project dir

VSCode Version: 1.32.3 (1.32.3)
OS Version: macOS 10.14.3 (18D109)
fish, version 3.0.1

Steps to Reproduce:

set setting {"terminal.integrated.shell.osx": "/usr/local/bin/fish"}
open new integrated terminal instance

result
$ pwd
/

expected /Users/user/projects/awersome

Does this issue occur when all extensions are disabled?: Yes

@vscodebot-authors, thank you! :)


Windows error

it continually presses C and makes an error noise whenever I press a note on the midi piano.

These are both explained in the FAQ


treewide: 2.10引入go modules支持

这个 PR 实现什么功能/修复什么问题:
treewide: 2.10引入go modules支持
是否需要 backport 到之前的 release 分支:
NONE

/cc @swordqiu

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@84ba38e). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.10.0   #1371   +/-   ##
================================================
  Coverage                  ?   7.77%
================================================
  Files                     ?     372
  Lines                     ?   58284
  Branches                  ?       0
================================================
  Hits                      ?    4529
  Misses                    ?   53352
  Partials                  ?     403

Flag
Coverage Δ

#aFlag
7.77% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ba38e...1fd7eeb. Read the comment docs.

/lgtm
/approve


bug: Enhancer Rating Shows Only one player per search

Prerequisites

[X] I have searched for existing issues that already report this problem, without success.

Script Version
1.1.8
Platform
Webapp
Current Behavior
when using rating field in enhancer, it shows cards of only player per search
Expected Behavior
to show every card with the desired rating, not only one player
Steps to Reproduce
write 84 for example in the "rating" field in enhancer, and then in transfer market of autobuyer click on search, the results will show cards of one player only per search, not showing every 84 rated card
Additional Information
No response

This is not possible , because the EA's api does not support searching multiple players at a time..


Fix to use epoch for time value only in datetimevalue/datevalue.

Fix issue: https://github.com/microsoft/Power-Fx/issues/1608.
Fix the check to make sure we use epoch for time only value.
Add tests to covers all possible cases.

✅ No public API change.

✅ No public API change.


Revert flask_dapr pkg

Description
Revert flask_dapr pkg. flask_dapr pkg doesn't include files properly. We will revert it for 0.5.0a0 release.
Issue reference
n/a
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@chinzhiweiblank Hi This is not working. flask_dapr pkg includes nothing. have you validated this before ? For now, I am reverting.


liblarch fails test at master

Steps To Reproduce
Steps to reproduce the behavior:

Try to build liblarch
Fails at tests

Build log
...
running install tests
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
running egg_info
writing liblarch.egg-info/PKG-INFO
writing dependency_links to liblarch.egg-info/dependency_links.txt
writing top-level names to liblarch.egg-info/top_level.txt
reading manifest file 'liblarch.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching 'README'
adding license file 'LICENSE'
adding license file 'AUTHORS'
writing manifest file 'liblarch.egg-info/SOURCES.txt'
running build_ext
Traceback (most recent call last):
  File "/build/source/nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
  File "setup.py", line 35, in <module>
    setup(
  File "/nix/store/w8kdsv5prmkklpqkp8pyhazaknzahfli-python3.10-setuptools-63.2.0/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 177, in setup
    return run_commands(dist)
  File "/nix/store/w8kdsv5prmkklpqkp8pyhazaknzahfli-python3.10-setuptools-63.2.0/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 193, in run_commands
    dist.run_commands()
  File "/nix/store/w8kdsv5prmkklpqkp8pyhazaknzahfli-python3.10-setuptools-63.2.0/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 968, in run_commands
    self.run_command(cmd)
  File "/nix/store/w8kdsv5prmkklpqkp8pyhazaknzahfli-python3.10-setuptools-63.2.0/lib/python3.10/site-packages/setuptools/dist.py", line 1217, in run_command
    super().run_command(command)
  File "/nix/store/w8kdsv5prmkklpqkp8pyhazaknzahfli-python3.10-setuptools-63.2.0/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 987, in run_command
    cmd_obj.run()
  File "/nix/store/w8kdsv5prmkklpqkp8pyhazaknzahfli-python3.10-setuptools-63.2.0/lib/python3.10/site-packages/setuptools/command/test.py", line 224, in run
    self.run_tests()
  File "/nix/store/w8kdsv5prmkklpqkp8pyhazaknzahfli-python3.10-setuptools-63.2.0/lib/python3.10/site-packages/setuptools/command/test.py", line 227, in run_tests
    test = unittest.main(
  File "/nix/store/9wa02q541sxq7372f8zv27rl57aribxj-python3-3.10.5/lib/python3.10/unittest/main.py", line 100, in __init__
    self.parseArgs(argv)
  File "/nix/store/9wa02q541sxq7372f8zv27rl57aribxj-python3-3.10.5/lib/python3.10/unittest/main.py", line 124, in parseArgs
    self._do_discovery(argv[2:])
  File "/nix/store/9wa02q541sxq7372f8zv27rl57aribxj-python3-3.10.5/lib/python3.10/unittest/main.py", line 244, in _do_discovery
    self.createTests(from_discovery=True, Loader=Loader)
  File "/nix/store/9wa02q541sxq7372f8zv27rl57aribxj-python3-3.10.5/lib/python3.10/unittest/main.py", line 154, in createTests
    self.test = loader.discover(self.start, self.pattern, self.top)
  File "/nix/store/9wa02q541sxq7372f8zv27rl57aribxj-python3-3.10.5/lib/python3.10/unittest/loader.py", line 349, in discover
    tests = list(self._find_tests(start_dir, pattern))
  File "/nix/store/9wa02q541sxq7372f8zv27rl57aribxj-python3-3.10.5/lib/python3.10/unittest/loader.py", line 405, in _find_tests
    tests, should_recurse = self._find_test_path(
  File "/nix/store/9wa02q541sxq7372f8zv27rl57aribxj-python3-3.10.5/lib/python3.10/unittest/loader.py", line 483, in _find_test_path
    tests = self.loadTestsFromModule(package, pattern=pattern)
  File "/nix/store/w8kdsv5prmkklpqkp8pyhazaknzahfli-python3.10-setuptools-63.2.0/lib/python3.10/site-packages/setuptools/command/test.py", line 57, in loadTestsFromModule
    tests.append(self.loadTestsFromName(submodule))
  File "/nix/store/9wa02q541sxq7372f8zv27rl57aribxj-python3-3.10.5/lib/python3.10/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/build/source/tests/test_liblarch.py", line 23, in <module>
    gi.require_version('Gtk', '3.0')  # noqa
  File "/nix/store/d0m1mk1zbsjysrm1bq44087njrygnl7w-python3.10-pygobject-3.42.1/lib/python3.10/site-packages/gi/__init__.py", line 126, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gtk not available
error: builder for '/nix/store/0qsbrpprpa

Additional context
Relevant to https://github.com/NixOS/nixpkgs/pull/181819
Notify maintainers

@oyren
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.18.10, NixOS, 22.11 (Raccoon), 22.11.20220714.4a01ca3`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.9.1`
 - channels(root): `""`
 - channels(user): `""`
 - nixpkgs: `/etc/nix/channels/nixpkgs`

This fail is somewhere in the last 12 days.

https://github.com/NixOS/nixpkgs/pull/181620

Surely since PR #181620 merged in 29316ab.

Not sure what have broke, but adding buildInputs with gtk3 seems to fix it.
https://github.com/NixOS/nixpkgs/pull/184046


Add font_colour to the network widget

Adds the font color to the network widget to be able to change the color of the details text. As far as I understand the docs are generated automatically

Looks good. Thanks.

Actually... Can you change the parameter name to foreground to be consistent with other qtile widgets?

Yes, I will tomorrow. However, I copied the name from your UPowerWidget ;)

@elParaguayo Done. Thanks!

Yes, I will tomorrow. However, I copied the name from your UPowerWidget ;)

Ha. I'll fix that separately as I'll need to add a deprecation warning about the change in parameter name too.

Same holds for the brightness widget and, possibly, other ones

Make sense. I wrote most of those when I first started using qtile (and before I joined the team).
Will review them all later.


Add AGSProjectTeam.AdventureGameStudio <IP_ADDRESS>

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/azp run

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-07-07 15:54:10.492 [FAIL] Installer failed security check. Url: https://github.com/adventuregamestudio/ags/releases/download/v<IP_ADDRESS>/AGS-<IP_ADDRESS>-P4.exe Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
(Automated response - build 886.)

/azp run

/azp run


Arduino framework does not work with network boot.

Code (e.g blink.ino) generated with platformio-2.8.2 or platformio-3.0.0dev fails to work with Ariadne or Netload bootloader.
If i compile with various versions of the Arduino IDE the upload over ethernet works.
see also https://github.com/codebendercc/Ariadne-Bootloader/issues/22
Robert

Update: found out that the issue results from binary validation in the bootloader but i can't figure out why
PlattfromIO produces different kind of binaries with the same compiler.
Could you please delete this topic until i find more details.

PlatformIO uses own code builder and build flow. We don't hide what we build. You can see all commands in the build output. Please contact with authors of the bootloader.


feature: request management system page

Date: 18 Feb 2024

Developer Name:  Swapnil Gawande

Issue Ticket Number
693

Description
This PR consists of html , css and Js code for new Out-Of-Office requests listings UI.

Integrated OOO requests listing API along with the UI.
Integrated OOO requests accept/reject API with UI.
Added sort and filter functionality for OOO requests.

Documentation Updated?

[ ] Yes
[✓] No

Under Feature Flag

[✓] Yes
[ ] No

Database Changes

[ ] Yes
[✓] No

Breaking Changes

[ ] Yes
[✓] No

Development Tested?

[✓] Yes
[ ] No

Screenshots

Mobile and Destop View Screenshort as test with local backend setup APIs.

Test Coverage

Screenshot 1

Additional Notes

No OOO requests found! message should be in the center of the screen

OOO tab name should be OOO not Ooo

Can you change the style of the selector like this and arrow icon should be rotate based on state of the selector

https://github.com/Real-Dev-Squad/website-dashboard/assets/70854507/20e9de35-93a6-4dbf-96a0-8d7ae5d7f98f
please observe and fix this issue

Recording.2024-02-20.200740.mp4
please observe and fix this issue
issue :

@sahsisunny, The PUT api to update OOO request does not accept "Reason" as a "Null" value. that why this error is coming. I think we should make the API accept "Reason" as a "Null" value because in some cases admin might just accept request without any reason. what your thought on this ?

Recording.2024-02-20.200740.mp4
please observe and fix this issue
issue :

@sahsisunny, The PUT api to update OOO request does not accept "Reason" as a "Null" value. that why this error is coming. I think we should make the API accept "Reason" as a "Null" value because in some cases admin might just accept request without any reason. what's your thought on this ?

When the reason is null then not send in the body

Recording.2024-02-20.200740.mp4
please observe and fix this issue
issue :

@sahsisunny, The PUT api to update OOO request does not accept "Reason" as a "Null" value. that why this error is coming. I think we should make the API accept "Reason" as a "Null" value because in some cases admin might just accept request without any reason. what's your thought on this ?

When the reason is null then not send in the body

Okay got it

OOO tab name should be OOO not Ooo

Tab name is changes to "OOO.

Can you change the style of the selector like this? The arrow icon should rotate based on the state of the selector, and we can call the API based on the selection. I don't think we need to click on the search button until we have added text to search input.

suggested icon change is done.

Recording.2024-02-20.200740.mp4
please observe and fix this issue
issue :

@sahsisunny, The PUT api to update OOO request does not accept "Reason" as a "Null" value. that why this error is coming. I think we should make the API accept "Reason" as a "Null" value because in some cases admin might just accept request without any reason. what's your thought on this ?

When the reason is null then not send in the body

Change implemented as per suggestion. now accept/reject functionality working fine without remark.

triangle icon should be clickable

Can you  also add query parm for tabs and filters?

UI is breaking

this issue is now fixed. please check.

triangle icon should be clickable

icon is now clickable.

Can you also add query param for tabs and filters?
For tab:

http://localhost:5500/requests/?q=type:OOO+state:PENDING

can we take this in the next task? also, I don't get what the purpose of doing this. as we have already triggered the backend API properly (http://localhost:3000/requests?type=OOO&state=REJECTED&dev=true)

Removed Filters Screenshot

Why tabs are shifting when toast is showing?

Amd author name "Real Dev Squad" in mera tag

Why tabs are shifting when toast is showing?

I kept it like that by design. should i make is overlap ?

Amd author name "Real Dev Squad" in mera tag

change done.

Why tabs are shifting when toast is showing?
now made it overlap.

@Swapnil099 Add a working proof for the whole feature. I'm not seeing any videos
Here is the working proof. Please check.

https://github.com/Real-Dev-Squad/website-dashboard/assets/88383863/58988b50-21f0-4006-81c0-cf3b4e99fb9e

@Swapnil099 where is the tests for this feature?
Test cases have not been written yet, as I thought they would be added in the next task, can I write them in the next PR/Task?

Did you put this feature behind the feature flag? I'm not seeing a feature flag in your working proof.

Added dev feature flag. The video is attached.
CC: @sahsisunny can you please check and confirm?
https://github.com/Real-Dev-Squad/website-dashboard/assets/88383863/53236733-5e6c-48a2-b001-8531bfc83983

@Swapnil099 where are the tests for this feature?
Test cases have not been written yet, as I thought they would be added in the next task, can I write them in the next PR/Task?

@Swapnil099 open an issue ticket for test and assign this ticket yourself

@Swapnil099 where are the tests for this feature?
Test cases have not been written yet, as I thought they would be added in the next task, can I write them in the next PR/Task?

@Swapnil099 open an issue ticket for test and assign this ticket yourself

okay

Did you put this feature behind the feature flag? I'm not seeing a feature flag in your working proof.

Added dev feature flag. The video is attached. CC: @sahsisunny can you please check and confirm?
ooo_dev_flag.mp4

Why it's showing N/A in the name field?

I had set first_name to null in my local DB for testing the edge cases where user first_name is not available. that's why it is showing N/a here.

okay, No worries


prefer-array-literal: Error when using Array in a type annotation

Perhaps this is the intended behavior, but from the description of the rule, the prefer-array-literal rule looks like its purpose is to disallow using Array when instantiating new arrays:
new Array();
new Array(4,5);
// etc...

However, this rule also disallows using Array as a type parameter, which is one of the recommended ways of declaring Array types in the handbook:
// these throw "Replace generic-typed Array with array literal" linting error

let myArray: Array<MyObject> = [];

interface MyInterface {
    myArray: Array<number>;
}

I expected this rule to throw errors on the first set of examples above but allow the second set.

Good find! Our coding standard says to prefer the literal syntax, even when declaring the array type.
We can add a parameter to the rule that will let you turn this on.
Why do you prefer
let myArray: Array<MyObject> = []

instead of
let myArray: MyObject[] = [];

The 2nd is shorter and gives your code base one single, consistent way to declare array types. If it were me, I would just follow the rule's advice. But that's a bit unfair because I wrote the rule :)

Thanks for the response, @HamletDRC.  I don't necessarily prefer the Array<> syntax, but my team's existing codebase uses it heavily.  Adding an option to ignore this error when the syntax is part of a type declaration would make it much easier to integrate this rule into our project.

I prefer the first method because it reads more fluently. Array of Objects as opposed to Object Array

Try this: (Type1 | Type2)[]

how can one specify the size of the array?
const foo = new Array(10)
?

@ogiexela You can use const foo = Array(10) instead of const foo = new Array(10). The result will be the same but prefer-array-literal will be disappeared immediately.
https://stackoverflow.com/a/8205709/568901

Oh that sounds like a bug in the rule...

@JoshuaKGoldberg OK. how can I help this issue?

That'd be great! Would you mind filing a new issue describing what you're seeing regarding being allowed to use = Array(10) but not new Array(10)? Including the normal information included with issues (version, code snippets, etc).

@JoshuaKGoldberg Yes, I will do. I just checked which ts-lint actually does prefer-array-literal and I found it is by tslint-microsoft-contrib.
https://github.com/palantir/tslint/issues/2946#issuecomment-310581618
I am going to test it with up-to-date version of tslint-microsoft-contrib then I will create issue.

@jonascarlsonschmidt Created. Thanks for guiding me.
https://github.com/Microsoft/tslint-microsoft-contrib/issues/839


Breaking httpx changes for enconnect and respx

https://github.com/langchain-ai/langserve/issues/796
https://github.com/lundberg/respx/issues/277
https://github.com/lundberg/respx/pull/278

RESPX version 0.22.0 released

Thank you @lundberg for letting me know! That was very kind.


Text selection handle color should be accent color by default

The text selection handle color in text widgets is primarySwatch[300] by default (https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/theme_data.dart#L135), but it should be the accent color.
The relevant guideline appears to be gone from the material documentation, but it's documented Google-internally at: https://material.googleplex.com/patterns/selection.html#selection-item-selection

/cc @HansMuller

This old issue appears to be wrong according to native testing. According to android and ios text input design specs, the cursor color should default to primary color, and the handles on both android and ios always default to match the cursor color. Of course, these can all be overwritten, but the default should be the primary color to match the outline color of the new text input design specifications.
I would suggest this issue be closed as well now that the material component redesign is being worked on.

I think accent color is the better choice. Sometimes, primary color may be same as background color of the input text field.

I think accent color is the better choice. Sometimes, primary color may be same as background color of the input text field.

It could just be overridden in the theme in that case. The default should still be according to material design specs. Your case may be why it's not a rule though and only a default.

I think accent color is the better choice. Sometimes, primary color may be same as background color of the input text field.

It could just be overridden in the theme in that case. The default should still be according to material design specs. Your case may be why it's not a rule though and only a default.

After specifying accent color in the themes, it should automatically adapt that color. I have seen this bug in many open sourced flutter applications.
Here are some screenshots for better understanding.
 I could create a pull request to set those correctly, but I think it would just be a stopgap while the material design is still being worked on. My point here was more that this issue is about changing it to the accent color, when it really should be primary color by default. Would it make sense for me to open the pull request?

Well, you are absolutely right. It is not kind of a bug that require urgent fix. Rather, it is more of an enhancement.

I once again ran into similar issue.
I have specified almost every color in my ThemeData. Still I am getting that standard dark theme color of flutter at random places. For example:
What I am getting

What I want

Basically, if I am specifying all the colors, then that "default" color should not come anywhere.
We can maybe give an option to totally overwrite that color.

That's a widget issue rather than a theme issue, unrelated to the text selection handle. The Checkbox widget has a hard-coded color in its build method which needs to be overridden by the checkColor property. The other color may come from the theme's toggleableActiveColor, unselectedWidgetColor, focusColor or hoverColor properties. Basically it would fall under the Material Design Overhall being worked on. I would look at a separate issue for that one.
I will look into creating a pull for all the items listed here though to try to fix some of the errors people are having at least :-) Hopefully it will get accepted.

@jpc-ae - we'd appreciate such a PR however it's likely to be complicated by the fact that we're in the middle of overhauling the theme system, see flutter.dev/go/material-theme-system-updates.

@HansMuller Yes, thank you. I guess my pr would be mainly for temporary backwards compatibility, but I suppose it would depend on how long the Material Design overhaul take if it  ever makes it into a release (in anything but a deprecated state).
If I wanted to help out with a specific component of the overhaul as well, would that be a waste of time? Or is there a timeline I could check so I could work on those that won't be for a while?

Okay, I created a pull request #60821. I'm not sure which test I should update for it though, if any.

I believe this is handled by the new TextSelectionTheme that we just finished migrating to: #62014, #66061, #66482. The defaults are now based on the primary color for the color scheme, but can be set to anything you want using the new theme.


[graphql][1/n] Refactor gas-related convert_to fns to utilize async-graphql's Object macro

Description
This PR refactors convert_to_gas_input, convert_to_gas_cost_summary, and convert_to_gas_effects in favor of utilizing the #[Object] macro. These convert_to functions are intended to convert struct objects into GraphQL objects, but the issue is that they will always make computations and data fetches for each field, even if the caller did not specify those fields. For example, if I make a query for TransactionBlock for the gasInput field and only specify the gas_price, we nonetheless make the extra conversions for gas_sponsor, gas_budget, and the data fetch for gas_payment.
Continuing with the example above, in this refactor, the struct definition of the GraphQL object GasInput now has the corresponding "native" fields, and implements From SuiGasData. The impl Object for GasInput block then resolves those fields, doing the necessary conversions and data fetches.
1/n as there are other convert_to fns I'd like to refactor.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Thanks for this clean-up @wlmyng !  This also helps answer a question I had around how to avoid fetching fields that weren't in the query!  One question I had though:  What is your proposed rule of thumb for when to use SimpleObject vs when to use Object?  Reason I ask: I had thought that types that were purely data, without edges (like GasCostSummary) would be good candidates for remaining as SimpleObject but this PR ports that type too. (There's a clear cut case for porting GasInput in my opinion, because it has edges to Objects).

What is your proposed rule of thumb for when to use SimpleObject vs when to use Object? Reason I ask: I had thought that types that were purely data, without edges (like GasCostSummary) would be good candidates for remaining as SimpleObject but this PR ports that type too. (There's a clear cut case for porting GasInput in my opinion, because it has edges to Objects).

Yeah that's a fair call-out. After diving into the distinctions between SimpleObject and Object within async-graphql, my take is that any object that requires a graphql type conversion (such as u64 to BigInt, exemplified by GasCostSummary) or necessitates a data retrieval would benefit from being ported. So if we need to do any kind of transformation, the type is better served as an object instead of a simple object. This might be overkill ... but as of now, I don't think for example the data provider needs to know what to convert u64 to, that can be the responsibility of the impl Object. If we later decide that we want to map u64 to another custom graphql type, the changes would be localized to that block.
By extension, we could have the Rust struct, which mirrors the GraphQL object name, encompass the necessary fields for generating the corresponding GraphQL object. I initially thought these structs could be wrapper types, so sui_graphql_rpc::GasCostSummary(sui_json_rpc_types::GasCostSummary) but 1. this would mean we couple the typings to another library 2. we pass a lot of & data and I didn't want to get into lifetimes lol
Lmk what your thoughts are. If that's too extensive, then I think in the very least we should port objects that have edges

I buy the separation of concerns around type conversions as well, thanks for clarifying @wlmyng ! I think that does mean basically everything gets turned into an Object rather than a SimpleObject, but that's okay with me, just wanted to make sure there was a rubrik we were following here.


feat(config): able to include/filter orgs

Able to filter or include orgs

@AkashRajpurohit a little one can help person like me to filter work orgs from our backup

hey @qlaffont can you share how have you tested this? From what I understand it will fetch repos to which you have access (your PAT token) and I tested with my setup and where I have some repos from different orgs, it was able to fetch those correctly but the condition of repo.GetOrganization() is also nil for all repos so not sure how have you tested any verified that it is able to filter out repos based on orgs 🤔

I didn't test it (As I mentioned it before !). I will try !

I didn't test it (As I mentioned it before !). I will try !

Sure, ping if you need any help about this :)

I fixed it but @AkashRajpurohit i don't undertstand why i got nil for getOrganization :thinking: any clue ?

why i got nil for getOrganization.getName

Yeah I also did not get this, I would've expected it to not be nil if the repo was infact part of organization, might have to check in the upstream github package.

@AkashRajpurohit Thanks I have made the changes and it works ! You can review it again and squash and merge if you want :)

@all-contributors please add @qlaffont for code.


fix: Unable to search by TopicId issue

fix: Unable to search by TopicId issue

Tested. Topic ID filtering is working. Thank you.


⚠ ClamAV has degraded performance

In 1972710, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 64 ms

Resolved: ClamAV performance has improved in 32c3b18.


An argument named "mtu" is not expected here.

Hello Team,
Thanks for fabulous minimal modules. I'm trying to create a minimal VPC with following script:
module "gke_vpc" {
  source     = "github.com/terraform-google-modules/cloud-foundation-fabric/modules/net-vpc"
  project_id = var.project_id
  name       = "gke-vpc"
  subnets = [
    {
      ip_cidr_range       = "<IP_ADDRESS>/24"
      name                = "gke-sub"
      region              = var.region
      secondary_ip_range  = {
        pods     = "<IP_ADDRESS>/20"
        services = "<IP_ADDRESS>/24"
      }
    }
  ]
}

Getting following error:
# terraform plan -var-file=dev-env.tfvars
Error: Unsupported argument
  on .terraform/modules/gke_vpc/modules/net-vpc/main.tf line 91, in resource "google_compute_network" "network":
  91:   mtu                             = var.mtu
An argument named "mtu" is not expected here.

Checked .terraform modules directory. It has mtu variable declared variable.tf.
Any help what's wrong here?

Hey! Thanks for the kind words on the modules. :)
The mtu attribute was added in version 3.45.0 of the Google provider, we probably need to bump the minimum provider version in the module. Can you try changing it and seeing if it fixes your issue, which is faster than waiting for a PR/merge?

Hey! Thanks for the kind words on the modules. :)
The mtu attribute was added in version 3.45.0 of the Google provider, we probably need to bump the minimum provider version in the module. Can you try changing it and seeing if it fixes your issue, which is faster than waiting for a PR/merge?

Hi @ludoo
Appreciate the quick response!
I was referring to old providers. Bumped up provider version to 3.45 to get it worked.
old
provider "google" {
  version = "~> 3.43.0"
}
provider "google-beta" {
  version = "~> 3.43.0"
}

New
provider "google" {
  version = "~> 3.45.0"
}
provider "google-beta" {
  version = "~> 3.45.0"
}

Able to get plan generated. Thanks for help!
You can close the issue. I'm not sure If I can close this.

Hi @ludoo
Appreciate the quick response!
I was referring to old providers. Bumped up provider version to 3.45 to get it worked.
old
provider "google" {
  version = "~> 3.43.0"
}
provider "google-beta" {
  version = "~> 3.43.0"
}

New
provider "google" {
  version = "~> 3.45.0"
}
provider "google-beta" {
  version = "~> 3.45.0"
}

Able to get plan generated. Thanks for help!
You can close the issue. I'm not sure If I can close this.

Thanks for confirming! I will keep this open so we remember to bump the module's version.

Thanks for confirming! I will keep this open so we remember to bump the module's version.


omit comments from commands

Fixes #546
Since our sqlcmd doesn't have a real grammar like the ODBC sqlparser we have to special case some aspects of the syntax.
The sqlcmd syntax isn't clearly documented either.

The changed file(s) look like they just handle single line comments. Would this address comments using the /* ... */ format as well? Such as:
PRINT 1
:QUIT /*This is a test*/

and
PRINT 1
:QUIT /*This is a Test.
             This is a Test.
             This is Test.*/

The changed file(s) look like they just handle single line comments (though admitted, I "can't read" Go). Would this address comments using the /* ... */ format as well? Such as:
PRINT 1
:QUIT /*This is a test*/

and
PRINT 1
:QUIT /*This is a Test.
        This is a Test.
        This is Test.*/

good catch
our sqlcmd isn't built on a modified sql grammar so some of our shortcuts have had consequences like this.
We also have a limitation that : commands fit on a single line which I am not yet able to free up enough time to really fix. I can add /* to the comment removal though.

hmm looks like ODBC sqlcmd doesn't like /* comment */ either
 9:21:14.32 e:\git\go-sqlcmd>"C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn\SQLCMD.EXE" -S davidshi-2019
1> :xml /*foo*/ ON
Sqlcmd: Error: Syntax error at line 1 near command ':xml'.
1> :xml /* foo */ ON
Sqlcmd: Error: Syntax error at line 2 near command ':xml'.
1> :xml ON
1> :xml ON /* on */
Sqlcmd: Error: Syntax error at line 4 near command ':xml'.
1>


Support for IPv6 clusters

No idea if this works.  This is literally my first Go code (my "hello world" but IPv6 attempt).
Closes #369
📑 Description
Detect if a ClusterIP is IPv6 or IPv4.  Choose the appropriate string format based on Go documentation.
https://pkg.go.dev/net

A literal IPv6 address in hostport must be enclosed in square brackets, as in "[::1]:80", "[::1%lo0]:80".

I've tested locally that it compiles with make.  I've not done any extra testing beyond that.  My development environment is Ubuntu 22.04.
✅ Checks

[x] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[x] All the tests have passed

ℹ Additional Information
I've successfully run make test from my development environment.
$ go version
go version go1.21.6 linux/amd64

This doesn't appear to have been added to the v0.1.1 release notes

The pull request isn't a conventional commit e.g. feat/chore, so unfortunately the bot didn't pick it up and I didn't notice.

No worries I was curious is all

The contributing doc doesn't cover specially formatted commit messages

@AlexsJones can you manually update release notes for v0.1.1 GH release to include mention of the new feature?  I also suggest updating contributing with what you expect to be specifically formatted messages when contributors open PRs.  I'm still not entirely certain what it needed to be.

@AlexsJones please update the 0.1.1 release notes with my contribution of IPv6 support

@AlexsJones please update the 0.1.1 release notes with my contribution of IPv6 support


Tags show commit should open commit same as blame

Any reason the behavior here is not standardized?  One opens a new tab, the other uses an output panel?  I could submit a PR to standardize this.  Can we agree on a single behavior?  Or a configuration option to choose behavior?

The reason was that I didn't catch it in review :)  @p3lim, was there a reason you preferred the panel over a scratch view?  I prefer the scratch view because 1) it doesn't disappear after closing/re-opening sublime, and 2) it is easier to review long diffs.  However, I'm not averse to making this configurable if there's a good reason.

Oh I'd prefer scratch also.

Personally, I prefer the panel, simply because it doesn't take me out of the original view I was in, it just overlays with temporary information (commits/diffs), which could become especially useful in the graph view.
I can agree on it not being the default method of showing it, but I would like to see an option for it somewhere down the road.

Fair enough. And there's no need to change the behavior without making it configurable as part of the same effort.

What is needed here?  A global setting for all "open related view in" or is this something where we need a hash and someone should be able to choose how they want content opened depending on the source of the open request?

A global setting, but this is probably put on hold until @divmain ends his merge to the new interface model.

Thanks for waiting :)  Status view is ported, and tag view is up next.  Once that is done, this should have the green light.

This was completed as part of 7dc5438b773cf8fde9b4d01a76c6af1c55bcc7d6.


[AutoPR securityinsights/resource-manager] Adding incident info to GetBookmarks

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7663

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/8856


Can envelope run nested loops ?

Hi,
Can envelope run nested loops ?
For Example how to implement following logic in envelope,
for (String str:values)
{
for(String str1:values2){
somestep(str1,str)
{
}

Hi @sgulati89,
Yes, in general Envelope can run nested loops. In the current version (v0.6.1) this is known to work when the values are provided by a range or by a step. In the next minor version (v0.7.0) this will also work when the values are provided by a list.
Here's an example of using a range for the outer loop and a step for the inner loop:
> cat loop.conf
steps {
  step_source {
    deriver {
      type = sql
      query.literal = "SELECT 1 UNION ALL SELECT 2"
    }
  }

  outer_loop {
    type = loop
    source = range
    range {
      start = 10
      end = 12
    }
    mode = serial
    parameter = outer
  }

  inner_loop {
    dependencies = [outer_loop, step_source]
    type = loop
    source = step
    step = step_source
    mode = serial
    parameter = inner
  }

  print_parameters {
    dependencies = [outer_loop, inner_loop]
    deriver {
      type = sql
      query.literal = "SELECT ${outer} AS outer, ${inner} AS inner"
    }
    print.data.enabled = true
  }
}

> spark-submit envelope-0.6.1.jar loop.conf
...
+-----+-----+
|outer|inner|
+-----+-----+
|   10|    1|
+-----+-----+
...
+-----+-----+
|outer|inner|
+-----+-----+
|   10|    2|
+-----+-----+
...
+-----+-----+
|outer|inner|
+-----+-----+
|   11|    1|
+-----+-----+
...
+-----+-----+
|outer|inner|
+-----+-----+
|   11|    2|
+-----+-----+
...
+-----+-----+
|outer|inner|
+-----+-----+
|   12|    1|
+-----+-----+
...
+-----+-----+
|outer|inner|
+-----+-----+
|   12|    2|
+-----+-----+

Hope that helps.


Bundle Node builtins

Currently, it seems it does not bundle them, because I can find
/* 0 */
/***/ (function(module, exports) {

module.exports = require("process");

/***/ }),

In the bundle. And worse, it does not use the webpack require but the normal one and I can bet it won't work in the browser.
Even without this problem, it still won't work in the browser because it module.exports = webpack stuff, so I can suggest a new flag to bundle for the browser.

I don't think the goal of ncc is to run in the browser (that would basically be browserify).
The motivation in README says "Only ship relevant app code to serverless environments"
It's meant for the server (ironically, serverless here is a type of server).

Browser shims are a non-goal for ncc. It's meant to bundle Node.js apps.


What about Air Fryer Cinnamon Roll Bites?

Yes please! Would you create a PR?

Please see our Contributing Guidelines: https://github.com/lnnrtwttkhn/recipes/blob/main/CONTRIBUTING.md

Added a Pull request #108


programs.steam: Maintainers wanted

I'm currently the single maintainer for the steam module and as such usually the only person pinged.
I'd like to ask the community to step up and help, since my time and experience in this area of nixpkgs is quite limited
Comment here if you wanted to be added. A steam team will be created later.

Sure, I can help.

cc @samueldr @k900 @zhaofengli from Jovian

I can probably help.

I use Steam frequently, have touched the Steam module before and somewhat maintain buildFHSEnv, I can help out.

@hrdinka @abbradar @tadfisher @jagajaga @jonringer you are currently listed as a maintainer for steam/steam-runtime/steamcmd. would it be ok to add you to the steam team and then set maintainers for all steam packages to teams.steam?

(And do you actually still maintain Steam?)

I haven't really touched it in a while, I might just remove myself ig.

I'll help out, still use it regularly

I've merged the PR now, the package maintainers were left untouched, only the module was updated. Feel free to use the team in packages aswell.

done in https://github.com/NixOS/nixpkgs/pull/292817


feat: add private properties to policy definition entity

What this PR changes/adds
Add private properties to policy definition entity. The implementation supports in-memory and postgres as a store.
Why it does that
The private properties are required to provide the owner with the possibility to add extra properties which should not be exposed outside. This requirement was initiated when we want to add administrative properties like (createdBy, createdAt, chnagedBy, chnagedAt), policyType (Access, usage). We assume that the private properties can be used to store such a requirement after registering a listener on the policy definition.
More information is in this discussion:
https://github.com/eclipse-edc/Connector/discussions/2592#discussioncomment-7379257
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes https://github.com/eclipse-edc/Connector/issues/3567

@suh-rao Can you please not open-and-close PRs like this as it puts an administrative burden on the reviewers? Stick to one PR per topic.

@suh-rao Can you please not open-and-close PRs like this as it puts an administrative burden on the reviewers? Stick to one PR per topic.

@jimmarino : ECA was not updated with old PR even after retrigger. Hence need to close and reopen it again. Will stick to this PR now for the feature

Removing my review as I am out of office

We're currently processing your upload.  This comment will be updated when the results are available.

Add @paullatzelsperger to review when he is back since this is an area he has worked on extensively.

still missing:

a test where a Policy is queried by a private property
E2E tests in the PolicyDefinitionApiEndToEndTest. It's not needed to re-test all test cases,  tests for creating policies with private props, querying with private props, one update scenario and a delete scenario would suffice.

a test where a Policy is queried by a private property
I followed approach done for contractdefinition. In this PR can I only do changes regarding storing privateProperties as JSON and query part later in next PR?

still missing:

a test where a Policy is queried by a private property
E2E tests in the PolicyDefinitionApiEndToEndTest. It's not needed to re-test all test cases,  tests for creating policies with private props, querying with private props, one update scenario and a delete scenario would suffice.

a test where a Policy is queried by a private property

I followed approach done for contractdefinition. In this PR can I only do changes regarding storing privateProperties as JSON and query part later in next PR?

Hello, I am unable to add label to pill request.
Also is it ok to have query part later? (As mentioned in above point)

I'm ok with tackling the query in a subsequent pr, please open an issue related to it

https://github.com/eclipse-edc/Connector/issues/3623. This is new issue created for search

@paullatzelsperger

I'm ok with tackling the query in a subsequent pr, please open an issue related to it

#3623. This is new issue created for search

Hey @suh-rao thanks for creating the issue, however it's not an adoption request, just a feature request. Adoption requests are for bigger features, for example "Support XYZ Database in EDC". Please adapt the description of #3623 thus.

I'm ok with tackling the query in a subsequent pr, please open an issue related to it

#3623. This is new issue created for search

Hey @suh-rao thanks for creating the issue, however it's not an adoption request, just a feature request. Adoption requests are for bigger features, for example "Support XYZ Database in EDC". Please adapt the description of #3623 thus.

Changed issue description as "feature request"

I'm ok with tackling the query in a subsequent pr, please open an issue related to it

#3623. This is new issue created for search

Hey @suh-rao thanks for creating the issue, however it's not an adoption request, just a feature request. Adoption requests are for bigger features, for example "Support XYZ Database in EDC". Please adapt the description of #3623 thus.

Hey @paullatzelsperger I updated issue description

I already said it in my previous review: please extend PolicyDefinitionApiEndToEndTest, so that it uses private properties, and add corresponding test assertions.
Also, Checkstyle is failing.

Hey @paullatzelsperger I updated endtoend tests also checkstyle issues. All workflows should be green now. Please have a look at into it.

I'm ok with tackling the query in a subsequent pr, please open an issue related to it

#3623. This is new issue created for search

Hey @suh-rao thanks for creating the issue, however it's not an adoption request, just a feature request. Adoption requests are for bigger features, for example "Support XYZ Database in EDC". Please adapt the description of #3623 thus.

Hey @paullatzelsperger I updated issue description

I already said it in my previous review: please extend PolicyDefinitionApiEndToEndTest, so that it uses private properties, and add corresponding test assertions.
Also, Checkstyle is failing.

Hey @paullatzelsperger I updated endtoend tests also checkstyle issues. All workflows should be green now. Please have a look at into it.

dependency check still failing.

I'm ok with tackling the query in a subsequent pr, please open an issue related to it

#3623. This is new issue created for search

Hey @suh-rao thanks for creating the issue, however it's not an adoption request, just a feature request. Adoption requests are for bigger features, for example "Support XYZ Database in EDC". Please adapt the description of #3623 thus.

Hey @paullatzelsperger I updated issue description

I already said it in my previous review: please extend PolicyDefinitionApiEndToEndTest, so that it uses private properties, and add corresponding test assertions.
Also, Checkstyle is failing.

Hey @paullatzelsperger I updated endtoend tests also checkstyle issues. All workflows should be green now. Please have a look at into it.

dependency check still failing.

In this PR I havent changed any dependencies. So not sure what can be the issue. I synched the branch to main now.

In this PR I havent changed any dependencies. So not sure what can be the issue. I synched the branch to main now.

@suh-rao just take a look at the failing check, you need to replace the contents of your DEPENDENCIES file with whatever the job output says. unfortunately, this can happen without any of your (or our, for that matter) doing.

In this PR I havent changed any dependencies. So not sure what can be the issue. I synched the branch to main now.

@suh-rao just take a look at the failing check, you need to replace the contents of your DEPENDENCIES file with whatever the job output says. unfortunately, this can happen without any of your (or our, for that matter) doing.

@paullatzelsperger All 17 checks passed now. Sync to main branch resolved the issue with dependency.

In this PR I havent changed any dependencies. So not sure what can be the issue. I synched the branch to main now.

@suh-rao just take a look at the failing check, you need to replace the contents of your DEPENDENCIES file with whatever the job output says. unfortunately, this can happen without any of your (or our, for that matter) doing.

@paullatzelsperger All 17 checks passed now. Sync to main branch resolved the issue with dependency.

Hello @paullatzelsperger : can it be merged now? I can work on search by properties feature after that.


update the api of "github.com/gonum/matrix/mat64"

*mat64.Dense has removed the "Col" function.

oh, it's good to know that. thanks for letting me know and thanks for the effort!


Grouping apps in app drawer by first letter

This PR fixes #98 and groups each app in the app drawer by their beginning letter[^1], resulting in the following video.
[^1]: Credits to Patxi Bocos for a nice tutorial.

The letters are also displayed when searching for an app and are not (yet) sticky when scrolling.
Moreover, from a design perspective, I chose to align the letters on the right side of the screen. I thought on the left side would make the drawer a little bit crowded. @jkuester What do you think? Should they be rather on the left side as well? And do you think we should be able to disable this?

Are you keeping up with the project? I'm sorry I have no knowledge in code, I'm just a big fan of Unlauncher wondering if we could expect an update anytime.


Fix homogeneous_aggregate? check for aarch64 types

Previously we recorded all return and arg types as though they weren't homogeneous aggregates. This minor changes fixes #12407

Side note: This also fixes the ImGui bindings from my emulator :)

Added a test now that I got the specs to run locally. Apologies for the force push 😬

Is this not going to make it in 1.5.1?

@mattrberry That's a good point. I think we can still pull this into 1.5.1. It should've been released today, but I suppose we can push it a bit to incorporate this fix.


Logger cannot be resolved to a type and Red5LoggerFactory cannot be resolved

Hello,
When I try to add oflaDemo classes on Eclipse, I have this error message :

Logger cannot be resolved to a type
Red5LoggerFactory cannot be resolved

I add external jars : red5-server.jar and red5-service.jar
Thanks

You'll also need to add the red5-server-common.jar


Daylight Saving Time Issues - Yet another Time

First of all, many thanks for your awesome gem!
I would love to use it in a project, but sadly our test suite failed when checking some nasty DST changes.
After digging deeper, I was able to build a minimal failing example:
require 'ice_cube'
require 'active_support/time'

# Set a fixed timezone
Time.zone = 'Berlin'

# Setup required dates (daily from 16 to 9 o'clock the next day)
start_time = Time.zone.parse '2017-10-01 16:00' # Within DST
end_time   = Time.zone.parse '2017-10-02 09:00' # Within DST

# Build schedule
schedule = IceCube::Schedule.new(start_time, end_time: end_time)
schedule.add_recurrence_rule IceCube::Rule.daily

# Set reference date, which is at 8 o'clock and should be within the schedule
now = Time.zone.parse '2017-10-29 08:00' # Not within DST (nasty stuff here)

puts schedule.next_occurrence now, spans: true

# Result
#  2017-10-29 16:00:00 +0100 - 2017-10-30 09:00:00 +0100
# but actually the "real" next occurrence should be
#  2017-10-28 16:00:00 +0200 - 2017-10-29 09:00:00 +0100

This happens on master as well as on the full_tz branch.
There some related (closed) issues, but I could not see if this is the expected behavior or a concrete "bug".
An attempt to fix that issue has been done here: https://github.com/MarkusHarmsen/ice_cube/commit/0d6f6eff17475a193d93eeb2596656a1b533f1db
but although it works "correcting" the DST change for the end_time in an occurrence, it fails to catch the edge case seen above (it seems that the ValidatedRule skips the required date).
Greetings,
Markus

Thanks @MarkusHarmsen,
Your assessment looks correct. Is the spans: true option relevant to this? I could not see a difference in the output.
We did recently fix an issue with doubled occurrences over DST, and removed some complicated code that was handling it. (See: #404) We previously had a similar method there to wind_back_dst around these scenarios, similar to what you wrote. I will take a closer look and determine if we need to reverse some of those changes.

Hey @avit,
I'm not 100% sure about the next_occurrence implementation, but I understood that spans: true can be set if a "overlapping" occurrence is fine as well (i.e start_time is before - and end_time is after reference date) or if the next occurrence must start after given reference date (i.e. both start_time and end_time have to be after the reference date).
If that understanding is correct, spans: true would be required to return the expected occurrence from the example above (2017-10-28 16:00:00 +0200 - 2017-10-29 09:00:00 +0100). spans: false should return the current result of the example above (2017-10-29 16:00:00 +0100 - 2017-10-30 09:00:00 +0100).

Ok, I looked into this further and confirmed it's not a bug.
Your example schedule has a duration of 17 hours: that means each occurrence must have the same length.
Because the end of DST adds one hour, that occurrence actually ends at 08:00, not at 09:00 like on other days, so the selection of the "next occurrence" is correct.
I considered whether the occurrence should have a different length in this situation, but based on the spec, it should not. Internally, we specify the duration in seconds so it should always be an exact period. However, the spec does allow for setting duration in different amounts, e.g. "1D" should mean a day, regardless of whether it is 24 or 25 hours... IceCube currently doesn't support this, but it could be added without changing the current meaning of duration.


feat(kooltip)!: refactor to kpop and restyle

Summary
Adds new design for tooltips and composes KPop to take advantage of positioning and appending to the DOM functionality KPop has. We also didn't have opaque black colors, so I add those to our styles. I aligned our props so that it makes a bit more sense re: message -> label, and position -> placement. The "alignment" prop was used to align text, but we weren't ever using it. Users can now slot the content if they want to text align.

Changes made:

feat(style) add solid black colors

feat(kooltip)!: kooltip implemented with kpop

fixes issues with placement
uses new styling and adds kpop as a dependency
adds ability to have slotted html content

BREAKING CHANGE: props and styles completely updated

docs(kpop) typos

PR Checklist

[x] Does not introduce dependencies
[x] Functional: all changes do not break existing APIs and if so, bump major version.
[x] Tests pass: check the output of yarn test packages/
[x] Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
[x] Framework style: abides by the essential rules in Vue's style guide
[x] Cleanliness: does not have formatting issues, unused code (e.g., console.logs), or leftover comments
[x] Docs: includes a technically accurate README, uses JSDOC where appropriate

Fixes #262

I don't see the content appearing for me

@xitongzou I think because @darrenjennings added colors you need to build the css before running the docs

@xitongzou I think because @darrenjennings added colors you need to build the css before running the docs

Doh! forgot about that. Thanks. Works now.


add Infernal robotics model rework - utility pack

Depends on #951 and requires a solution to https://github.com/KSP-CKAN/NetKAN/issues/932 since it depends on those mods. An alternate route might be to have this install and conflict with CIT-Util and ActiveStruts since it redistributes them within the .zip.
We'll see once #951 is merged how to resolve this, CIT mods might be back on the market by the time IR-Rework have had their first release.

#rebuild

It seems the bot wont index other IR stuff because this one is missing and this won't resolve through Jenkins because the other mods aren't indexed properly. I'm merging this hoping it'll resolve the issue. In a perfect world everything works after this merge, in the real world I'll probably spend the next hour trying to fix something I didn't forsee.


Mina Local Network Manager extraction and documentation (Compatible)

Resolves #11691

Yes, I was planning to announce that, thank you!


SLA file is missing

I load your files into a new subfolder
C:\Program Files (x86)\Ghidra\Ghidra\Processors\C166
and Ghidra complains that the SLA file is missing.
java.io.FileNotFoundException: C:\Program Files (x86)\Ghidra\Ghidra\Processors\C166\data\languages\c166.sla
All other processors have a SLA file.
What is wrong here ?

sorry for the late answer
Ghidra should automatically compile SLA from SLASPEC files on first run. Looks like it doesnt have access rights to write new files to Program Files folder.
Also you can manually compile SLA with Program Files\Ghidra\support\sleigh.bat
But please note, that this module not completed yet. Main issue is EXTP/EXTR/etc instructions not working.

Thanks for your answer.
I changed  the directory permissions and  now it works.

Thanks for your answer.
I changed  the directory permissions and  now it works.

elmu, how did you grant permission? I think I know how, but it is not working for me. different processor, but it is having issues, supposedly if I delete the SLA and then start ghidra it will fix it, however, it is not creating a new SLA

elmu, how did you grant permission?

I cannot believe that you want to use Ghidra (which supposes that you are an advanced cracker) and you don't know how to set the permissions of a folder in Windows!
Use Google to find how you set folder permissions!

Tell me about it! I discovered Ghidra 5 months ago, learning curve has been brutal. Here's my YT channel on automotive ECU disassembly https://youtu.be/jRo1wr7o80g?si=WXrUi5MLlD1-Xo3y. feel free to drop in and drop some knowledge, or shame lol. Ghidra is definitely a powerful tool. yeah, I followed the instructions I found by googling. it still isn't creating an .SLA. Trying to figure out what is going wrong.
tHaNks for the help CrAckEr

Tell me about it! I discovered Ghidra 5 months ago, learning curve has been brutal. Here's my YT channel on automotive ECU disassembly https://youtu.be/jRo1wr7o80g?si=WXrUi5MLlD1-Xo3y. feel free to drop in and drop some knowledge, or shame lol. Ghidra is definitely a powerful tool. yeah, I followed the instructions I found by googling. it still isn't creating an .SLA. Trying to figure out what is going wrong.
tHaNks for the help CrAckEr

elmu, how did you grant permission?

I cannot believe that you want to use Ghidra (which supposes that you are an advanced cracker) and you don't know how to set the permissions of a folder in Windows!
Use Google to find how you set folder permissions!

Tell me about it! I discovered Ghidra 5 months ago, learning curve has been brutal. Here's my YT channel on automotive ECU disassembly https://youtu.be/jRo1wr7o80g?si=WXrUi5MLlD1-Xo3y. feel free to drop in and drop some knowledge, or shame lol. Ghidra is definitely a powerful tool. yeah, I followed the instructions I found by googling. it still isn't creating an .SLA. Trying to figure out what is going wrong.
Thanks for the help Cracker

Hi @GhidrAuto ! Haha, this world is a small enough ;-)
I advice you to install Ghidra in your work folder, not in common Program Files (as I understood from your videos, you are on Windows).
Also it can be useful to try to compile .slaspec files with Ghidra\support\sleigh.bat - it is a commandline tool, and it can wrote some useful info if something going wrong.
But please note that this module still in abandoned state, and I haven't found a good way to support such confusing memory addressing (almost all 16-bit MCUs is a big pain).

Here I send you my project for the C166 processor.
Copy the files into Ghidra\Processors creating a new subfolder C166.
IMPORTANT:
I have created these files for Ghidra 9.2.  I have no idea if they still work with newer Ghidra versions.
If it does not work download the old Ghidra version.
IMPORTANT:
I have made many changes on the SLA file.
But nevertheless there are several problems with the decompilation.
This never worked perfectly.
The resulting code has several issues.
I was not able to fix this as Ghidra file format is practically undocumented and it seems that this processor is very different from others and so there is no solution.
C166.ZIP


API hook for getting dates

I can add an api hook that’s like:
getDate({calendar? = default, format? = format-from-settings })

Thanks, I appreciate it!

Thanks, I appreciate it!


Jira docs 3.0 channel subscriptions edits

Summary
I'm adding some edits here for the PR at https://github.com/mattermost/mattermost-plugin-jira/pull/739. I'm making a separate PR, as there are a decent amount of changes I want to be reviewed in isolation.
Some things left to be done:

Make sure all the links in the docs work correctly. @justinegeffen is there a way we can test this?
Add a picture of the channel subscriptions modal
Change the output of /jira webhook to point to docs instead of going in detail with Legacy Webhooks in output
Clean up images folder in a separate PR. Right now the images are named image.png, image (1).png, and so on.

Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-31410

@hanzei Any ideas why ci lint is failing on go.mod issues in this docs PR?

@mickmister Since the latest update of the plugin-ci orb go mod tidy is now enforced. The CI issue was fixed on master with https://github.com/mattermost/mattermost-plugin-jira/pull/746. Cherry-picking https://github.com/mattermost/mattermost-plugin-jira/commit/4f416fcb0480d24db45f46ba181bf1ad42853465 into this branch will fix CI.

/update-branch

Self-reminder to changes references to the webhook URLs to use the new format that includes the instance ID, as pointed out here https://github.com/mattermost/mattermost-plugin-jira/pull/739#discussion_r602690177

Codecov Report

Merging #754 (e63241f) into jira-docs-3.0 (490c1a8) will increase coverage by 0.30%.
 Consider uploading reports for the commit 7ba365c to get more accurate results

@@                Coverage Diff                @@
##           jira-docs-3.0     #754      +/-   ##
=================================================
+ Coverage          32.10%   32.41%   +0.30%
=================================================
  Files                 52       52
  Lines               5270     5359      +89
=================================================
+ Hits                1692     1737      +45
- Misses              3384     3421      +37
- Partials             194      201       +7

Impacted Files
Coverage Δ

server/atlassian_connect.go
0.00% <0.00%> (ø)

server/auth_token.go
3.75% <0.00%> (ø)

server/instance_cloud.go
0.00% <0.00%> (ø)

server/instance_server.go
7.14% <0.00%> (ø)

server/stats.go
10.65% <0.00%> (-0.18%)
:arrow_down:

server/user_cloud.go
0.00% <0.00%> (ø)

server/user_server.go
6.81% <0.00%> (+1.15%)
:arrow_up:

server/utils.go
16.88% <0.00%> (+2.43%)
:arrow_up:

server/utils/kvstore/entity.go
0.00% <0.00%> (ø)

server/utils/kvstore/id_index.go
0.00% <ø> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec2604...7ba365c. Read the comment docs.

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.


feat: Add R cataloger

Add a cataloger that detects installed R packages by looking for DESCRIPTION files.
fixes: https://github.com/anchore/syft/issues/730

To make a JSON schema update you can add your new metadata struct to https://github.com/anchore/syft/blob/main/schema/json/generate.go#L32 and follow the steps in https://github.com/anchore/syft/blob/main/schema/json/README.md#json-schema on how to bump .


Plugins in 4.4.dev3, not working

Change the signal connection to editor_script_changed, and the plugin will work
old: EditorInterface.get_script_editor().script_changed.connect(_on_script_changed)
new: EditorInterface.get_script_editor().editor_script_changed.connect(_on_script_changed)

I will make the change once 4.4 releases, thank you for documenting it here!

This change is needed for 4.3 as well.

I saw the error on my part earlier. Working through one of the PRs at the moment which includes it!

fixed in 86b654b6e6e7b6a1551c84681d585ac7af969125


feat: add configurable push container registries

What this PR does / why we need it
Allows for pushing to multiple container registries.
Also adds support to authenticate with AWS ECR.
Jira ID
DT-4464

As a side-note -- amout of code is close to uncomfortable to use without tests, we'll have to move from Shell to something more controllable at some point in future

There is infrastructure to start migrating everything to Go (via Mage) but it hasn't yet been a priority.
That being said I can add some tests for the new get_box_array function.


Add Brentwood School

@zweizwei any luck?

@whitj00 sorry for the delay. Could you please add .txt extension to the path and I'll add the domain?

@zweizwei Done :)

@zweizwei Any Luck?


baseTexure destroyed on a frame, can't find why

Hello,
I updated my engine with the latest version of PIXI and migration is ok except this point and I cannot find why this is happening, maybe it's the same problem than https://github.com/GoodBoyDigital/pixi.js/issues/1741 ?
I never call "destroy", I looked with a global search and this is only inside PIXI.
This is how I instantiate my sprite:
  PIXI.Sprite.call( this, PIXI.utils.TextureCache[ frameId ] );

First time goes well, and if I reload the level later I got an error "cannot read hasLoaded of undefined".
I type "PIXI.utils.TextureCache[ "island-1" ]" in console and see "baseTexture = null".
I would like to fix this, after checking commits history there is tons of things changed.
Maybe you have an idea to locate approximately where this is coming from, and I will be able to investigate much more.
I'm trying to reproduce this bug on a smaller project.

The only time a texture's baseTexture should be null is if it is destroyed, or set to null manually.
I can't think of any reason this would happen if you never call destroy. Hopefully you can reproduce with a focused test case so I can look into it.

Agree. What is strange is I didn't got this problem with 3.0.0-rc4.

Ok I found the origin.
I call "destroy" on my containers with true arguments because I push other container inside.

Should I wrote a middle-ware for doing my stuff (it's easy ofc) or should we must include this option inside PIXI ? (am I the only one using container this way ?)

If you don't think it's useful to look for an option inside PIXI just close this issue and I'll do a middle-ware :)

You can call removeChildren on the container, it will return the removed children. Then loop on them and call destroy without parameters.

This happens because we break an OOP rule by making the overriden sprite destroy take different params than the parent (adding params is fine, but changing them makes this happen). IMO sprite destroy should take in destroyChildren as the first param, then its extra spritey stuff, but that is a breaking change we can't make :(
Instead, @JiDW's method will work for you.

There is a simple way to do this in my case but thanks @JiDW
@englercj yeah, or maybe (this is nasty I assume, but will not change anything in "usage") add something like
  if (children[i].texture )
    children[i].destroy(); // no params for things getting texture
  else
    // basic destroy call

There is few options to do this fix without changing destroy method on Renderer prototypes, this is surely the nastier but faster.
I can look on a better way to fix this properly.

Yeah I've thought about doing that too, but I'm not the ducktype is sufficient. I'll keep thinking about this problem, thanks!

I just met the same issue, it took me some time finding out why this happened and found it is already known.
Personally, I think it should be mentioned somewhere more accessible before it is resolved. (Would the documentation for PIXI.Container be a good place?)
Anyway, pixi.js is great for me! Thanks for all the work.

closing for now as this seems sorted. thanks all :+1:

Glad to hear :)


Unable to catch keyerror exception

Unhandled exception in thread started by <bound method CallSerializer.call_functions of <system_hotkey.util.CallSerializer object at 0x7ff390e6fe10>>
It seems that keyerror exception is triggered in another thread, so it cannot be caught in the main thread. After keyerror exception starts, the register method will fail.

#11

   try:         if hk.keybinds.get(tuple(hk.order_hotkey(("f8",)))):             hk.unregister(("f8",))     except UnregisterError:         pass
This can be done for the time being.