Question: Is there a way to deploy just enough to expose /dev/kvm to containers?

For context my real use case is a requirement to deploy existing containers that launch VMs and the main prerequisite is access to /dev/kvm from the container (they also use /dev/net/tun but that works just using a volume mount).
I came across this: https://github.com/kubevirt/kubevirt/issues/1276 and used that as the basis of an experiment:
apiVersion: v1
kind: Pod
metadata:
  name: kvm-and-tun-consumer
spec:
  containers:
  - name: alpine
    image: alpine:3.5
    command: ["/bin/sleep", "36000"]
    resources:
      limits:
        devices.kubevirt.io/kvm: "1"
    volumeMounts:
    - mountPath: /dev/net/tun
      name: dev-tun
    securityContext:
      capabilities:
        add:
        - NET_ADMIN
      privileged: false
  volumes:
  - hostPath:
      path: /dev/net/tun
      type: CharDevice
    name: dev-tun

I deployed the kubevirt-operator.yaml and kubevirt-cr.yaml following the quickstart instructions
After I got over my initial issues with AppArmor and finally got KubeVirt deployed I was able to deploy the yaml above and successfully kubectl exec to the Pod then install and launch qemu
apk add --update qemu-system-x86_64 bzip2 wget
wget http://mirrors.us.softlayer.com/coreos/stable/2135.5.0/coreos_production_qemu_image.img.bz2
bzip2 -d coreos_production_qemu_image.img.bz2
qemu-system-x86_64 -m 1024 -enable-kvm -hda coreos_production_qemu_image.img -nographic

That all looks pretty promising for my needs.
But as I say all I really need is the kvm device and as nice as KubeVirt is for being able to integrate traditional/legacy virtualised workloads I don't really need all of the features, so my question really is whether there is a way to deploy "just enough" to expose the kvm device to my containers to be usable in a similar way to the Pod definition above?
In issue 1276 that I cribbed for this it mentions "The device manager of virt-handler creates a device plugin for both /dev/kvm and /dev/net/tun." which suggests that (maybe) just the virt-handler Daemon Set is the minimal thing needed to expose /dev/kvm as above.
TBH I have no familiarity with the KubeVirt code and wouldn't know where to begin, so I was hoping for some expert pointers.... I had come across the kvm device plugin in the kubernetes-device-plugins subdirectory https://github.com/kubevirt/kubernetes-device-plugins/blob/master/docs/README.kvm.md however although that is logically a very close fit to what I actually want to achieve that is marked as archived so I was hoping to be able to achieve the same based on the main KubeVirt images as that feels maybe like a more "sustainable" approach.
MTIA

If you only need to run your own containers with qemu, why do you need KubeVirt at all? I think you can simply expose /dev/kvm  and perhaps some other devices to the container. Also you will need to setup permissions and potentially some other tweaks. But it should work I think.

That's kind of the point. I don't really need KubeVirt per se, but I do need /dev/kvm and I'm not sure how best to expose that to the containers.
As I say above /dev/net/tun (which is the other device I need in my containers) doesn't seem to be an issue in that I can make that visible simply by using a volume mount, but that approach doesn't work for /dev/kvm
I've actually tried this in plain Docker too where using  --device /dev/net/tun and --device=/dev/kvm works obviously and -v /dev/net/tun:/dev/net/tun with --device=/dev/kvm works too and lets me create my tap device inside the container, however -v /dev/net/tun:/dev/net/tun with -v /dev/kvm:/dev/kvm does not work so kvm clearly needs the extra "magic" that using --device provides, which I guess is some cgroups set up.
I can obviously run my Pod with privileged:true and that would give me /dev/kvm directly, but I'd really rather not do that for application Pods.
So I think I kind of just need the device plugin aspects, but as I say the kubernetes-device-plugins subdirectory is marked as archived so that got me wondering whether it was possible to just deploy the virt-handler daemon set bits and have the kvm device exposed to Pods that way.
If you can think of any good way to expose /dev/kvm to unprivileged Pods in a relatively simple way then that would be really helpful as that is, as you observe, all I really need for this particular use case.

Ah, I probably missed that you wanted unprivileged Pods. Right, access to the devices need to be configured via cgroups for containers.
The device manager's code of KubeVirt lies here: https://github.com/kubevirt/kubevirt/tree/main/pkg/virt-handler/device-manager. Maybe you could reuse that somehow and write your own device plugin? I think that would be the bare minimum. Though perhaps someone else has better ideas on that.
One more thing: why not using KubeVirt directly? Yeah, its somewhat 'huge' but It will simplify things a lot. If you have existing VMs you may consider various ways of importing them e.g. via CDI. Or if you want to run VMs in 'your own' containers you can rebuild virt-launcher. Might that be a solution?

What I'm actually doing is something closer to containers in concept, but using a hypervisor as an additional security layer.
I'm actually using Firecracker as the hypervisor and the gist is that I'm taking existing container images and running a transformation step to generate the root filesystem. In general the original containers are "microcontainers" so really quite minified to the minimum needed to run the application and I basically init Firecracker more or less directly to the application - so conceptually a bit closer to a Unikernel appliance than to a traditional VM, if that makes sense. The "container side" starts the tap and sets up routing inside the the container's network namespace from the container's eth0 to the tap used by Firecracker and the container's startup does things like resize the rootfs, which gets minified as part of the step where I generate the rootfs from the original container image layers.
So basically I'm "transforming" a "vanilla" image into an image containing FC, its kernel and a roots derived from the vanilla image plus some startup code so you basically have a derived image that behaves essentially the same as the source image (notwithstanding some constraints imposed by running in Firecracker). It requires relatively few privileges - CAP_NET_RAW and CAP_NET_ADMIN needed to run ip/iptables to set up the routing - and runs as a non-root user. As I say I just need a reasonably clean way to expose /dev/kvm and is should all run happily in k8s.
Conceptually I just want to use containers and TBH reducing the available kernel surface using a bespoke application sepcific seccomp would probably be my preference, but its not always easy to convince people that can be just as secure as hypervisors so I figured hooking up Firecracker in the way I describe gives the guest kernel/hardware virtualisation/software fault isolation mechanisms that keep the "hypervisors are the answer now what was the question" folks happy so I can get back to basically just using containers. There are also some additional potential benefits using a hybrid container/Firecracker where I can do fun things like build minimal kernels and restrict comms to the guest, so the use case is a little different than just wanting to host a legacy VM, which don't get me wrong is a cool thing, but "conceptually" as I say I'm running a container that just happens to need  /dev/kvm as a mechanism for isolating its workload.

BTW re One more thing: why not using KubeVirt directly? to be clear, when I deployed KubeVirt (and thanks again for the AppArmor thoughts that was super-helpful) I was able to deploy an unprivileged Pod from the yaml I mentioned at the top of this thread and was able to launch a qemu VM in that so the
    resources:
      limits:
        devices.kubevirt.io/kvm: "1"

stuff seem to work as far as I can tell from that experiment. So I could just deploy the KubeVirt operator and what I want to do should actually work, nothing to see here, move along and all that. But on the other hand as I say the full KubeVirt is doing a lot more than I actually need, so this thread was really just about asking whether there might be a (reasonably straightforward) way to deploy just the bits that I need. I'd definitely have gone down the path of https://github.com/kubevirt/kubernetes-device-plugins/blob/master/docs/README.kvm.md had it not been marked as archived.

What I'm actually doing is something closer to containers in concept, but using a hypervisor as an additional security layer.
I'm actually using Firecracker as the hypervisor and the gist is that I'm taking existing container images and running a transformation step to generate the root filesystem. In general the original containers are "microcontainers" so really quite minified to the minimum needed to run the application and I basically init Firecracker more or less directly to the application - so conceptually a bit closer to a Unikernel appliance than to a traditional VM, if that makes sense. The "container side" starts the tap and sets up routing inside the the container's network namespace from the container's eth0 to the tap used by Firecracker and the container's startup does things like resize the rootfs, which gets minified as part of the step where I generate the rootfs from the original container image layers.
So basically I'm "transforming" a "vanilla" image into an image containing FC, its kernel and a roots derived from the vanilla image plus some startup code so you basically have a derived image that behaves essentially the same as the source image (notwithstanding some constraints imposed by running in Firecracker). It requires relatively few privileges - CAP_NET_RAW and CAP_NET_ADMIN needed to run ip/iptables to set up the routing - and runs as a non-root user. As I say I just need a reasonably clean way to expose /dev/kvm and is should all run happily in k8s.
Conceptually I just want to use containers and TBH reducing the available kernel surface using a bespoke application sepcific seccomp would probably be my preference, but its not always easy to convince people that can be just as secure as hypervisors so I figured hooking up Firecracker in the way I describe gives the guest kernel/hardware virtualisation/software fault isolation mechanisms that keep the "hypervisors are the answer now what was the question" folks happy so I can get back to basically just using containers. There are also some additional potential benefits using a hybrid container/Firecracker where I can do fun things like build minimal kernels and restrict comms to the guest, so the use case is a little different than just wanting to host a legacy VM, which don't get me wrong is a cool thing, but "conceptually" as I say I'm running a container that just happens to need /dev/kvm as a mechanism for isolating its workload.

@fadams are you aware of (kata container with firecracker) [https://gokulchandrapr.medium.com/kata-containers-on-kubernetes-and-kata-firecracker-vmm-support-28abb3a196e7]? Not sure if this could be a better fit than KubeVirt for your use. Apologize if you already evaluated it :)

@alicefr thanks, yeah I was aware of Kata Containers but I wasn't super-keen on the idea of an additional container runtime and moreover Kata seems to run basically a container runtime plus an agent (and I think a few other things) inside the Guest VM and TBH I wasn't over keen on increasing the potential available Guest attack surface - in my case I basically init to a minimised app (no extra binaries nor libraries) using a minimal init to set up the environment and do some namespacing. I also want the flexibility to use a custom kernel, possibly minimised to restrict more devices and networking.
I'm fairly happy with the shape of my containers and the approach to creating them, as I say I really just need a nice way to expose /dev/kvm. The device plugin exposed by KubeVirt does actually work for me, but it'd be nice if I could just deploy that (or even the virt-handler daemon set I guess) without having to deploy all of KubeVirt.

@alicefr thanks, yeah I was aware of Kata Containers but I wasn't super-keen on the idea of an additional container runtime and moreover Kata seems to run basically a container runtime plus an agent (and I think a few other things) inside the Guest VM and TBH I wasn't over keen on increasing the potential available Guest attack surface - in my case I basically init to a minimised app (no extra binaries nor libraries) using a minimal init to set up the environment and do some namespacing. I also want the flexibility to use a custom kernel, possibly minimised to restrict more devices and networking.

Yes the agent is the init and does the namespacing. It should be relatively small and not require a lot of libraries. Kata containers could avoid the need of creating a VM image as you can deploy container images as they are. You can also use a custom kernel if you need it. The main goal of kata container is to isolate the container workload and it reminded me your use case. But I understand if you want to use something more specific to your need :)

I'm fairly happy with the shape of my containers and the approach to creating them, as I say I really just need a nice way to expose /dev/kvm. The device plugin exposed by KubeVirt does actually work for me, but it'd be nice if I could just deploy that (or even the virt-handler daemon set I guess) without having to deploy all of KubeVirt.

I think you need to separate the device plugin from virt-handler and use that in a separate program if you want to run it standalone.

I think you need to separate the device plugin from virt-handler and use that in a separate program if you want to run it standalone.

Yes +1 on that one. The idea of having the device plugins separated floated around in the early stage of kubevirt, but we need full control over it, need to minimize the complexity of the architecture in production and need an easy way to evolve it together with kubevirt features, therefore it is part of virt-handler itself.
Closing this one as "resolved". Feel free to reopen if neede.
/close


why not support USB human interface device class

how to make connection to USB human interface device class

@CorrM  what kind of device do you want to use?

Also if you're using with recent versions Android, USB HID should be plug and play. You get the input from Activity#dispatchKeyEvent Activity#onKeyUp Activity#onKeyDown, etc Sharing more info on what you want to achieve plus the device will help


Replace deprecated SGX SDK header in eservice and pservice

Building the eservice and pservice with SGX SDK version >= 2.13 results in a number of the following deprecated header warnings:
/opt/intel/sgxsdk/include/sgx_uae_service.h: warning: #warning This header is deprecated. Please consider using one of the 3 headers "sgx_uae_launch.h", "sgx_uae_epid.h" and "sgx_uae_quote_ex.h".

To bring our codebase up to date with newer SDK versions, we should replace this deprecated header.

Addressed in #394


Fix Wrong Shape Offsets in Tileset

Closes #30994 and closes #25610.
When modifying the properties of a tileset in the editor, some properties only apply to the first tile (such as the shape offset).
This change resolves that issue by traversing the changes to all of the shapes in the tileset instead of the first one.

Thanks a lot! This also fixes #25610 , while #30994 was a duplicate of it.

Thanks!

Note to release maintainers: if this is cherry-picked, #33452 should be included too to fix the #33395 regression.


treewide: use pypa/build to build setuptools projects

Experimental. This WILL break things that have both a pyproject.toml and a setup.py.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/pull/271597#issuecomment-1843603739 is a better idea.


test: improve code coverage for the files below

100% Code Coverage for:

CompletionTime (Closes #90)
Name (Closes #91)
ServingSize (Closes #92)
Step (Closes #95)
Tag (Closes #96)

Codecov Report

Merging #97 (bd258ac) into master (93e1755) will increase coverage by 1.74%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #97      +/-   ##
============================================
+ Coverage     36.82%   38.57%   +1.74%
- Complexity      229      248      +19
============================================
  Files            75       75
  Lines          1488     1488
  Branches        140      140
============================================
+ Hits            548      574      +26
+ Misses          876      860      -16
+ Partials         64       54      -10

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/recipe/Name.java
100.00% <0.00%> (+33.33%)
:arrow_up:

src/main/java/seedu/address/model/tag/Tag.java
100.00% <0.00%> (+35.71%)
:arrow_up:

src/main/java/seedu/address/model/recipe/Step.java
100.00% <0.00%> (+36.36%)
:arrow_up:

...n/java/seedu/address/model/recipe/ServingSize.java
100.00% <0.00%> (+42.85%)
:arrow_up:

...ava/seedu/address/model/recipe/CompletionTime.java
100.00% <0.00%> (+42.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e1755...bd258ac. Read the comment docs.


(GH-112) Remove config package dependency

Remove the config package dependency.
There is no hurry to merge this or create a new version of the package.
Closes #112

@pauby your changes have been merged, thanks for your contribution 👍

@pauby your changes have been merged, thanks for your contribution 👍


kompose.service.type issues

For some odd reason, our example no longer works:
version: "2"

services:

  redis-master:
    image: gcr.io/google_containers/redis:e2e
    ports:
      - "6379"

  redis-slave:
    image: gcr.io/google_samples/gb-redisslave:v1
    ports:
      - "6379"
    environment:
      - GET_HOSTS_FROM=dns

  frontend:
    image: gcr.io/google-samples/gb-frontend:v4
    ports:
      - "80:80"
    environment:
      - GET_HOSTS_FROM=dns
    labels:
      kompose.service.type: LoadBalancer

▶ kompose convert -v
DEBU Checking validation of provider %skubernetes
DEBU 'docker-compose.yml' not found: stat docker-compose.yml: no such file or directory
DEBU Docker Compose version: 2
DEBU Opening compose files: docker-compose.yaml
DEBU [0/1] [frontend]: Adding
DEBU [0/1] [redis-master]: Adding
DEBU [0/3] [redis-slave]: Adding
DEBU [0/3] [default]: EventType: 32
DEBU [0/3] [default]: EventType: 32
DEBU [0/3] [default]: EventType: 32
DEBU Default network found
FATA kompose.service.type can't be set if service doesn't expose any ports.: LoadBalancer defined in service frontend with no ports present. Issues may occur when bringing up artifacts.

@kadel @surajnarwade @surajssd
Should we release 0.7.1? This is a huge bug in regards to the main demo. At the moment, our main example does not work due to this issue.

@cdrage yeah

@cdrage yeah :+1:

@kadel @surajnarwade @surajssd
So I was double-checking everything, it seems that we dont need to do a release as long as #674 is merged in.
When I was testing the binary, I was testing 0.7.0 as well as the latest master (had it in two different bin directories), hence the reason why I was getting this error half the time.
Funny enough, #674 was actually a separate bug.


the link of OAuth 2 Simplified is wrong

Yes it seems that we just have both links to the same destination.


After a short time after startup, the omnibox suggestions are no longer shown.

System Details

OS: Windows 11 23H2
Thorium Version 126.0.6478.231

Problem
After a short time after startup, the omnibox suggestions are no longer shown.
If I create a new window, the suggestions are shown in that window, but they remain hidden in the existing window.
This problem has been occurring at some point in time, so we do not know when it occurs clearly.
Additional Notes
This is a problem that I had discovered at the time of M124.0.6367.218, but I report that it was still the same at M126.0.6478.231.
I have never had this problem using Chrome or Edge.

@RHEF19 Interesting. Never had this happen and I use Thorium on Linux and Windows. Although I don't use Win 11, and I've been getting alot of weird reports from people using 23H2.
If the next M128 release still doesn't fix it, I will install it in a Win11 VM and see if I can reproduce and debug.

@Alex313031 Unfortunately, this problem did not go away when I got to M128.0.6613.189.
After a little research, I found that this problem does not occur when using the standard IME, but when using the Japanese IME called ATOK.
I am not certain if this is a Thorium or ATOK problem, but I suspect it may be difficult to resolve.
If it looks too difficult, you may close this issue.


I want to hide the searchView and suggestions without clearing query and results . what shall I do?

Faced with this issue. I start to write the query, I find the right suggestion, I click on that, the part of query became the full, but suggestion doesn't disappear. How to manage this?


Change desired shards metric to report raw calculated value

Output desired shards as the calculated float rather than the integer that may be incorrect by up to 30%.
Also, the reshard log line was trying to log the metric rather than the value which was not working.
cc: @cstyan

@cstyan I would love a review when you have a moment :)


Draft: CAMEL-17500: Simplified Dynamic Router control channel messages.

This pull requests provides simplification to the Dynamic Router EIP component with regard to control channel messages.  Instead of only having the option to create and send a POJO for all of the parameters of subscribing or unsubscribing, this pull request allows a user to:

use the URI for all parameters, or to use a combination of URI parameters and a bean in the registry that contains the exchange filtering predicate
use a combination of URI parameters and a Predicate as the message body to use as the exchange filtering predicate
omit the subscription ID URI parameter to have the subscription ID generated as a UUID string and returned as the message body

The asciidoc file has been updated accordingly.
A pull request will follow this one, in the near future for an update to the corresponding Spring Boot example.  The spring boot starter, itself, is not affected.  Pull request is : https://github.com/apache/camel-spring-boot-examples/pull/46 but will not pass until this one is merged.

[x] JIRA issue
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations.

Hi, @davsclaus and @zregvart I did not get this same error when running the exact same command on my machine.  It is also in a different module, so do you have any idea what might be causing the checkstyle violation?

@davsclaus and @oscerd  please don't merge this yet.  I have questions about parallel processing of exchanges.  Merging this in will result in a broken dynamic router component (which is why it's marked as draft).  I posted to the mailing list, for whenever you might have some time.  Thank you!

You can make a PR as "draft"

@davsclaus and @oscerd If you guys still approve, it should be ok to merge this now, and if the performance can be improved for the mode that matches all recipients, then we can do that in a follow-up pull request, if you both agree.


⚠ Bofrost.com has degraded performance

In 4d6b966, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 629 ms

Resolved: Bofrost.com performance has improved in 2fefad0.


Update keyspaces-lambda-csharp.csproj

Security patching purpose, bumping Newtonsoft version from 12.0.3 to 13.0.2
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nwheeler81 @michaelraney can you approve & merge this


Remove suppressed extensions

Remove express-route, privatedns and keyvault-preview as they are included in azure-cli and suppressed.
The source code of keyvault-preview is in another repo: https://github.com/Azure/azure-keyvault-cli-extension

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@jsntcy @msyyc  for awareness


Use ARIA live region for collection/object detail changes

Is your feature request related to a problem? Please describe.
When user selects a collection or object in the context section, that change will not be detected unless the user navigates  back to that section on the page.
Describe the solution you'd like
Implement ARIA live region (polite) on record details so that the screen reader will announce the change in page content. Research how this relates to changing urls (issue #120 ).
Additional context
Consider a solution like react-aria-live.

This is a good read on aria-live in React, and why I thought we may need to use react-aria-live (but I admit I wasn't fully understanding all of the implications). But I do think we can simplify and just have the records title h1 (not the accordion divs) announced when it changes. That way the user knows that there is a change and can navigate to the associated records details as necessary.


Commerce Scenarios Example

New Scenarios for Sitecore Habitat Commerce including different
personnas with different user agents.
Contains good and bad queries with Clicks and Views

@SLangevin You really want to add all those to the examples?
I have moved my actual real use scenarios into another repository of mine because I did not want to have to do pull requests to modify scenarios, it makes it harder to keep track of the code changes.

I would like to have them available for now to help newcomers in the Sitecore/Commerce world. This is only a few of these scenarios and I will most likely push a ReadMe in a few days to explain what does what.


signature verification failed: generic_verify_fail

OS: Ubuntu 18.04.4 LTS
GNOME: 3.28.2
likely repeat of other reported issues.

have a look here: #454. this worked for me

Fixed, please see https://github.com/micahflee/torbrowser-launcher/pull/526


[WIP]Android darwin clang

WIP, test with travis

Coverage increased (+0.16%) to 70.32% when pulling 8b232b7a4089fb9c27f483d6b7d19974d08b0ccd on krocard:android-darwin-clang into 7ba789f53ed8c8070a218785bc6539af09d9b35f on 01org:master.

Coverage increased (+0.16%) to 70.32% when pulling 7bcb05f5cf23035d0b1a64229dbc87c8a3832636 on krocard:android-darwin-clang into 7ba789f53ed8c8070a218785bc6539af09d9b35f on 01org:master.

Coverage increased (+0.16%) to 70.32% when pulling 378169de718534ff75e90175abec62a93ffba564 on krocard:android-darwin-clang into 7ba789f53ed8c8070a218785bc6539af09d9b35f on 01org:master.

Coverage increased (+0.16%) to 70.32% when pulling c3f098f2f96a7f938c836520135e5655869aff02 on krocard:android-darwin-clang into 7ba789f53ed8c8070a218785bc6539af09d9b35f on 01org:master.

Coverage increased (+0.16%) to 70.32% when pulling ed21dc1cdde06a79972bb2212e05c232c5743e58 on krocard:android-darwin-clang into 7ba789f53ed8c8070a218785bc6539af09d9b35f on 01org:master.

:+1: @dawagner @OznOg Please review. These are essentially your patches a bit reworked (added comments) for some.


groovy: 2.4.15 -> 2.5.0

Motivation for this change
Update groovy to latest stable version.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: groovy
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: groovy
Partial log (click to expand)
/nix/store/zdvn74qgsj7fzrkxkgdvb1cn9001aj0n-groovy-2.5.0/bin/startGroovy: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
/nix/store/zdvn74qgsj7fzrkxkgdvb1cn9001aj0n-groovy-2.5.0/bin/.grape-wrapped: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
/nix/store/zdvn74qgsj7fzrkxkgdvb1cn9001aj0n-groovy-2.5.0/bin/.java2groovy-wrapped: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
/nix/store/zdvn74qgsj7fzrkxkgdvb1cn9001aj0n-groovy-2.5.0/bin/.groovy-wrapped: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
/nix/store/zdvn74qgsj7fzrkxkgdvb1cn9001aj0n-groovy-2.5.0/bin/.groovydoc-wrapped: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
/nix/store/zdvn74qgsj7fzrkxkgdvb1cn9001aj0n-groovy-2.5.0/bin/.groovyc-wrapped: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
/nix/store/zdvn74qgsj7fzrkxkgdvb1cn9001aj0n-groovy-2.5.0/bin/.groovysh-wrapped: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
/nix/store/zdvn74qgsj7fzrkxkgdvb1cn9001aj0n-groovy-2.5.0/bin/.groovyConsole-wrapped: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/zdvn74qgsj7fzrkxkgdvb1cn9001aj0n-groovy-2.5.0...
/nix/store/zdvn74qgsj7fzrkxkgdvb1cn9001aj0n-groovy-2.5.0


Moved viewDidLoad code into viewWillAppear

Investigated issue #418 and discovered preferences were not initialising on OS X < 10.10 due to the
initialisation code being placed in viewDidLoad which wasn't being called after the transition to MASPreferences.
MASPreferences calls viewWillAppear so the initialisation code has been
moved into that. NSViewController has viewWillAppear in 10.10 and so a
check has been added before calling it on super.

@barijaona this has been tested on a 10.9 VM (also compiled as 32-bit to see if there was any weird behaviour there) and all appears well.


checkImageAvailability function in send_event_newArtifact.go wrongly checks docker.io

There seems to be a minor bug in the checkImageAvailability function in the  module send_event_newArtifact.go. I can see that the function checks for 2 conditions: HasPrefix docker.io or if the Image name has exactly 1 forward slash (/) in the image name.
**if strings.HasPrefix(newArtifact.Image, "docker.io/") || strings.Count(newArtifact.Image, "/") == 1
But if I have a local image in my registry, being exposed as myregistry.mydomain.com/myimage:latest, since the image name has exactly 1 slash, the function enters inside the if block and does a http.Get operation on https://index.docker.io/v1/repositories/tag/myimage, which will most likely fail.
I believe the condition strings.Count(*newArtifact.Image, "/") should not be there or you should have && instead of ||, to force a check on image name with one / in docker.io.
Hope I am clear in my explanation. :)
Regards,
Ganesh.

Hi, thanks for bringing this up. Just for reference for everybody, these are the lines that are being discussed:
https://github.com/keptn/keptn/blob/b36446097980a7a0ca44ab268f025b827acd14a5/cli/cmd/send_event_newArtifact.go#L147-L176
I think you are right, the behaviour is wrong, as right now you can not use any registries other then the ones specified in the code above, and it will always fall back to docker.io.
I believe that
	if strings.HasPrefix(*newArtifact.Image, "docker.io/") || strings.Count(*newArtifact.Image, "/") == 1 {

could be simplified to
	if strings.HasPrefix(*newArtifact.Image, "docker.io/") {

as we are checking for docker.io/ (which already has a / in it).
Furthermore, we should probably add the possibility to fetch images from any docker registry (but that might be something for the future; we should however document that docker and quay are supported right now).
Also pinging @agrimmer on this issue for an opinion.

I've noticed that in our onboarding tutorial the following two lines are listed:
keptn send event new-artifact --project=sockshop --service=carts-db --image=mongo

keptn send event new-artifact --project=sockshop --service=carts --image=docker.io/keptnexamples/carts --tag=0.9.1

When using --image=mongo, the code linked above will log Availability of provided image cannot be checked., while --image=docker.io/keptnexamples should work.
This has partically been documented in this PR, but we should furthermore clarify within the tutorial that we using --image=mongo is equal to using --image=docker.io/mongo.
Long term I recommend that we refactor checkImageAvailability such that we always use docker.io as a fallback for checking image availability.

Thanks Christian. You are right.. But the problem is my image name is mydomain.com/myimage. Since this has one / in it, it goes inside and fails throwing an error image not found.

That's true.
I think @agrimmer is in the process of fixing this, so this should work in the next release.

 Thank you for making this issue!
We thought that an image always has to be contained in a Docker-organization. Therefore, we added this check strings.Count(*newArtifact.Image, "/") == 1. But this is not true.
I fixed it here: https://github.com/keptn/keptn/pull/994

Thanks a lot Andreas & Christian for updating this and fixing this quickly.... Much appreciated...


The app crashes on 10.15.3 Catalina

After deploying the app using Cloud9, the app crashes with the following error:
Process:               ___app_name__ [25858]
Path:                  /Applications/___app_name__.app/Contents/MacOS/___app_name__
Identifier:            com.amazonaws.services.chime.sdk.classroom.demo.___app_name__
Version:               1.0.0 (1.0.0)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           ___app_name__ [25858]
User ID:               501

Date/Time:             2020-04-13 13:28:08.677 -0700
OS Version:            Mac OS X 10.15.3 (19D76)
Report Version:        12
Bridge OS Version:     4.2 (17P3050)
Anonymous UUID:        7EC3097D-4428-9C32-1409-D82CA5F7F039

Time Awake Since Boot: 1100 seconds

System Integrity Protection: enabled

Crashed Thread:        0

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    DYLD, [0x1] Library missing

Application Specific Information:
dyld: launch, loading dependent libraries

Dyld Error Message:
  Library not loaded: @rpath/Electron Framework.framework/Electron Framework
  Referenced from: /Applications/___app_name__.app/Contents/MacOS/___app_name__
  Reason: no suitable image found.  Did find:
  /Applications/___app_name__.app/Contents/MacOS/../Frameworks/Electron Framework.framework/Electron Framework: file too short
  /Applications/___app_name__.app/Contents/MacOS/../Frameworks/Electron Framework.framework/Electron Framework: stat() failed with errno=1

Binary Images:
       0x10b93a000 -        0x10b962fff +com.amazonaws.services.chime.sdk.classroom.demo.___app_name__ (1.0.0 - 1.0.0) <CD315A0C-AE44-3040-8C05-F56E5800F953> /Applications/___app_name__.app/Contents/MacOS/___app_name__
       0x10edb5000 -        0x10ee45cb7  dyld (733.😎 <EBC07CB6-870A-3A8E-B48A-67F62EA161F3> /usr/lib/dyld
    0x7fff32a01000 -     0x7fff32ab8ff5  com.apple.MediaPlayer (1.0 - 1.0) <AD327638-B751-39B7-AE10-544E1E19D8BD> /System/Library/Frameworks/MediaPlayer.framework/Versions/A/MediaPlayer

Model: MacBookPro16,1, BootROM 1<IP_ADDRESS>.0 (iBridge: 17.16.13050.0.0,0), 6 processors, 6-Core Intel Core i7, 2.6 GHz, 16 GB, SMC
Graphics: kHW_IntelUHDGraphics630Item, Intel UHD Graphics 630, spdisplays_builtin
Graphics: kHW_AMDRadeonPro5300MItem, AMD Radeon Pro 5300M, spdisplays_pcie_device, 4 GB
Memory Module: BANK 0/ChannelA-DIMM0, 8 GB, DDR4, 2667 MHz, Micron, 8ATF1G64HZ-2G6E1
Memory Module: BANK 2/ChannelB-DIMM0, 8 GB, DDR4, 2667 MHz, Micron, 8ATF1G64HZ-2G6E1
AirPort: spairport_wireless_card_type_airport_extreme (0x14E4, 0x7BF), wl0: Dec  6 2019 11:24:25 version <IP_ADDRESS>.32.5.41 FWID 01-69cdfdf2
Bluetooth: Version 7.0.3f5, 3 services, 27 devices, 1 incoming serial ports
Network Service: Wi-Fi, AirPort, en0
USB Device: USB 3.1 Bus
USB Device: Apple T2 Bus
USB Device: Composite Device
USB Device: Touch Bar Backlight
USB Device: Touch Bar Display
USB Device: Apple Internal Keyboard / Trackpad
USB Device: Headset
USB Device: Ambient Light Sensor
USB Device: FaceTime HD Camera (Built-in)
USB Device: Apple T2 Controller
Thunderbolt Bus: MacBook Pro, Apple Inc., 51.7
Thunderbolt Bus: MacBook Pro, Apple Inc., 51.7

Also seeing this. It appears that the Electron Framework is being copied as a text file rather than as a symlinked directory.

@jsteer I'm not sure whether this is the same issue. The electron-builder dependency has an ongoing issue that users can't open the macOS app from the ZIP file.
https://github.com/electron-userland/electron-builder/issues/4299
In your macOS, after deploying the script, could you open the generated releases folder and try launching the app in the DMG file? (Note that DMG file does not exist if you have deployed in Cloud9.)

Hi @jsteer
I just tried building and running app on my iMac running (Catalina 10.15.6) without any issues using a build binaries from both Cloud9 and local mac os build. Tested the application as well for video, audio, screen-share all functions properly.  I will resolve this ticket but feel free to reopen if you still experiencing running issue on latest commit.


⚠ HDBits has degraded performance

In 14d5847, HDBits ($HDB) experienced degraded performance:

HTTP code: 200
Response time: 4622 ms

Resolved: HDBits performance has improved in ec26560 after 6 minutes.


Initial fuzzing harness for animated images

Animated images with the "loop forever" flag currently cause an infinite loop in the decoder.
The AFL seed images didn't seem to contain any animated ones, so I made these seed images myself from the sample image linked from the official Google documentation: webp_animated_fuzz_seeds.tar.gz
Resolves (?) #31

At the moment, next_frame intentionally starts over back at the beginning of the animation until it has concluded loop_count many passes. With the "loop forever" flag it'll return each frame an infinite number of times.
For displaying the image, that seems like desirable behavior. However, if you're trying to collect all the frames of the animation (say to convert them to a different format) then it is far less helpful. Perhaps the right approach would be to expose extra methods to query the loop count and number of frames?

I think there needs to be a lower-level interface that exposes all the frames and separately the data on how many times they should be looped, and optionally a higher-level one that does the right thing for displaying the image (that's how the current interface works).
I wonder, does the current interface decode all the frames once and store them in memory, or does it decode them over and over?

The current interface decodes each frame as it is requested and also does compositing at the same time. Which can involve blending pixels with the values from previous frames. And the raw frame data can also be limited to only the "cropped" section that changed from the previous frame so we account for that as well.
Other than not automatically looping the animation, are you imagining there would be any other differences with the lower-level interface?

Well, an image editing tool like GIMP would require access to the raw data of the layers - but I don't think anyone else would care. I think just not automatically looping is a good start. We can add the even lower-level interface useful for image editors once someone who wants to use it actually shows up. I feel it's easy to design something useless in absence of actual users who can tell us what they need.

I'll go ahead and merge this, and then API improvements can come as a followup.


Add ResourceListType

controller-runtime expects we have this type. For an existing
example look at VirtualMachineList.

Pull Request Test Coverage Report for Build 214332294

-81 of 99 (18.18%)  changed or added relevant lines in 7 files are covered.
190 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-9.08%) to 24.42%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

hack/generator/pkg/astmodel/reference_graph.go
0
1
0.0%

hack/generator/pkg/codegen/pipeline_remove_type_aliases.go
0
2
0.0%

hack/generator/pkg/astmodel/file_definition.go
0
3
0.0%

hack/generator/pkg/astmodel/type.go
0
8
0.0%

hack/generator/pkg/astmodel/resource_list.go
0
67
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/zips/env.go
3
0%

pkg/zips/types.go
25
54.76%

pkg/zips/client.go
75
3.96%

pkg/zips/template.go
87
26.32%

Totals

Change from base Build 214328367:
-9.08%

Covered Lines:
821

Relevant Lines:
3362

💛  - Coveralls

Pull Request Test Coverage Report for Build 214332294

18 of 99 (18.18%)  changed or added relevant lines in 7 files are covered.
190 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-9.08%) to 24.42%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

hack/generator/pkg/astmodel/reference_graph.go
0
1
0.0%

hack/generator/pkg/codegen/pipeline_remove_type_aliases.go
0
2
0.0%

hack/generator/pkg/astmodel/file_definition.go
0
3
0.0%

hack/generator/pkg/astmodel/type.go
0
8
0.0%

hack/generator/pkg/astmodel/resource_list.go
0
67
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/zips/env.go
3
0%

pkg/zips/types.go
25
54.76%

pkg/zips/client.go
75
3.96%

pkg/zips/template.go
87
26.32%

Totals

Change from base Build 214328367:
-9.08%

Covered Lines:
821

Relevant Lines:
3362

💛  - Coveralls

It's not 100% clear that a new type was the best way to do this but all the other ways I came up with seemed sorta complicated (is a resourceList a resource? Probably not. Is it just an Object? Maybe but there's no way currently to embed types in our objects so would have to add that).


Add --tag-message to support custom message templates for tags

This closes #185
The default behavior of git tag --annotate <version> --message <version> is preserved if tag_message is not set neither as parameter for the update command nor in the config file. The same substitutions as for commit_message can be used, e.g. --tag-message "Tagging {new_version} release".
If tag_message is an empty string a lightweight tag will be created, when using Git as VCS, instead of an annotated tag using git tag <version> instead. See https://git-scm.com/book/en/v2/Git-Basics-Tagging.
Checklist

[x] Add tests
[x] Run: make test fmt lint
[x] Update documentation

Just experienced that test_hg_tag_message fails with make citest. I guess the cause is an old version of mercurial used in the docker image (version 4.0) while locally I'm using mercurial 6.4.5.


No such file or directory: 'openroad'

I've installed the docker version of SiliconCompiler using your Dockerfile.
When I compile a design (even heartbeat.v) I get this error
| INFO    | job0    | syn          | 0   | Warnings: 18 unique messages, 113 total
Traceback (most recent call last):
  File "/siliconcompiler/siliconcompiler/core.py", line 3161, in _runtask_safe
    self._runtask(step, index, active, error)
  File "/siliconcompiler/siliconcompiler/core.py", line 3411, in _runtask
    proc = subprocess.run(cmdlist, stdout=PIPE, stderr=subprocess.STDOUT, universal_newlines=True)
  File "/usr/lib/python3.8/subprocess.py", line 493, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'openroad'
| ERROR   | job0    | floorplan    | 0   | Uncaught exception while running step floorplan.
| ERROR   | job0    | floorplan    | 0   | Halting step 'floorplan' index '0' due to errors.
| ERROR   | job0    | physyn       | 0   | Halting step due to previous error in floorplan0
| ERROR   | job0    | physyn       | 0   | Halting step 'physyn' index '0' due to errors.
| ERROR   | job0    | place        | 0   | Halting step due to previous error in physyn0
| ERROR   | job0    | place        | 0   | Halting step 'place' index '0' due to errors.
| ERROR   | job0    | cts          | 0   | Halting step due to previous error in place0
| ERROR   | job0    | cts          | 0   | Halting step 'cts' index '0' due to errors.
| ERROR   | job0    | route        | 0   | Halting step due to previous error in cts0
| ERROR   | job0    | route        | 0   | Halting step 'route' index '0' due to errors.
| ERROR   | job0    | dfm          | 0   | Halting step due to previous error in route0
| ERROR   | job0    | dfm          | 0   | Halting step 'dfm' index '0' due to errors.
| ERROR   | job0    | export       | 0   | Halting step due to previous error in dfm0
| ERROR   | job0    | export       | 0   | Halting step 'export' index '0' due to errors.
| ERROR   | job0    | ---          | -   | Run() failed, exiting! See previous errors.

These are all the openroads I see
# find / -iname "openroad*"
/Workarea/sc/build/heartbeat/job0/floorplan/0/openroad.py
/Workarea/sc/build/heartbeat/job0/floorplan/0/__pycache__/openroad.cpython-38.pyc
/siliconcompiler/third_party/pdks/virtual/asap7/pdk/r1p7/apr/openroad_tracks.tcl
/siliconcompiler/third_party/pdks/virtual/asap7/pdk/r1p7/apr/openroad_tapcells.tcl
/siliconcompiler/third_party/tools/openroad
/siliconcompiler/third_party/tools/openroad/tools/OpenROAD
/siliconcompiler/third_party/tools/openroad/tools/OpenROAD/src/cmake/openroad.cmake
/siliconcompiler/third_party/tools/openroad/tools/OpenROAD/src/OpenRoad.tcl
/siliconcompiler/third_party/tools/openroad/tools/OpenROAD/src/OpenRoad.cc
/siliconcompiler/third_party/tools/openroad/tools/OpenROAD/src/OpenRoad-py.i
/siliconcompiler/third_party/tools/openroad/tools/OpenROAD/src/OpenRoad.i
/siliconcompiler/third_party/tools/openroad/tools/OpenROAD/include/ord/OpenRoad.hh
/siliconcompiler/third_party/tools/openroad/flow/platforms/asap7/openRoad
/siliconcompiler/.git/modules/third_party/tools/openroad
/siliconcompiler/.git/modules/third_party/tools/openroad/modules/tools/OpenROAD
/siliconcompiler/siliconcompiler/tools/openroad
/siliconcompiler/siliconcompiler/tools/openroad/openroad.py
/siliconcompiler/siliconcompiler/tools/openroad/__pycache__/openroad.cpython-38.pyc
/siliconcompiler/_skbuild/linux-x86_64-3.8/cmake-build/third_party/tools/openroad
/siliconcompiler/_skbuild/linux-x86_64-3.8/cmake-build/third_party/tools/openroad/tools/OpenROAD

Looks like libboost-serialization-dev and libboost-thread-dev are required.

See PR #909

#909 merged, did that fully resolve the issue? If not, feel free to reopen.


[PE-D][Tester A] Wrong command result

input: mark 10
output: does not display all trips and all events in bucket list, instead it closes the summary window.

Labels: type.FunctionalityBug severity.Low
original: jhchee18/ped#15

This bug has been fixed.


More frequent 'pessimistic lock not found' since v5.3.0

Bug Report

We met more frequent 'pessimistic lock not found' errors than before since async-io which changes how to call proposed callback( https://github.com/tikv/tikv/pull/11147). We need to figure it out.

Does the store-io-pool-size change to a non-zero value when testing?
#11147 should not take effect if store-io-pool-size is 0 by default.

Does the store-io-pool-size change to a non-zero value when testing? #11147 should not take effect if store-io-pool-size is 0 by default.

No, use the default config.

Any progress on the issue?

Any progress on the issue?

None

Does it need to be solved? Or is it an improvement?


tool tip for pre disabled button doesn't removed

Please be more descriptive and make a code pen

okay :)
so when u have tooltiped button and when u hover it the usual thing that is the tooltip appears
but for some reason you may need to disable the button after clicking it and
when you do that the tooltip stayed and its doesn't removed
codepen :
http://codepen.io/baraamashaal/pen/xGbPBa

Once you disabled something it no longer receives events. Take a look at my fix here.
http://codepen.io/Dogfalo/pen/EjjVaZ

i got it thx man :D


How to skip project even though project included

Related Samples

My root project contains 30+ subprojects. In order to speed up build, I use Substitution to replace some projects with modules. For example:
// build.gradle of project A
implementation project("B")
implementation project("C")

As you see, B and C now is useless however there are configuring every build life cycle. It seems to be useless. So how can I skip these two projects although they are included.
You may ask me: why don't you not include these two projects? Yes I must, because there are required by project A. If I don't include them,  gradle  will report error: B and C project not found.
Context

What do you mean by "substitution"?

What do you mean by "substitution"?

Such as:
substitutions.substitute(":B").with("com.example:B:1.0.0")


build(deps): persistently bump word-wrap from 1.2.3 to >=1.2.5

Commit to be reviewed

build(deps): persistently bump word-wrap from 1.2.3 to >=1.2.5
Primary Changes
---------------

1. Added word-wrap in resolutions in package.json

Fixes: #2569
Pull Request Requirements

[x] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[x] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[x] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

[x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[x] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

LGTM


Update Ghost to 1.8.2

Lots of Ghost updates these last weeks.
A few bugs have been corrected since 1.5.0 (https://github.com/TryGhost/Ghost/releases), no impact on this project as far as in can tell.

Thanks. Will try this with my next blog post.


Add ONEPANEL_HOST=<host> system environment variable

Changes needed:

Add onepanel ConfigMap in onepanel namespace.
Add method to API to grab this value.
Auto inject this as a parameter in Workflows.

@rushtehrani For bullet 2, what do you mean by API? An endpoint?

@rushtehrani For bullet 2, what do you mean by API? An endpoint?

Meant we need to update this method to return this info as well.

This should be ready for review.


Fixed simulation not driving like real rovers

sBrdige would not map speeds correctly and the max speed was to low for rotation
This has been corrected to allow 4.5 radians per second and 0.6 m/s for respective movments and roughly mapping -255 - +255 onto -4.5 - +4.5 for rotation and the equivalent for linear
Also the maximum alignment error was increased by 0.05 radians to prevent possible oscilliaions.
Known additonal bug, robot may seem to freeze on rare occasion biased towards the start of sim but it will eventually turn to correct heading and drive.

@JCHJones, do the sim rovers drive at the same speed as the real rovers with this change?


Issue #7615: allow fields to reference interfaces in typescript-mongodb plugin

Description
This change allows users to reference interfaces in the type fields of their GraphQL schema and generate correct MongoDB output. Previously, using the @link directive would cause the typescript-mongodb plugin to always assume the @link referenced an object, when the GraphQL spec explicitly allows users to reference interfaces. This would cause the generated TypeScript to break immediately as it would try to reference a DbObject that was never generated, because it should have instead tried to reference a DbInterface.
Related #7615

Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[X] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):
I don't believe this is relevant, but let me know if you'd prefer something.
How Has This Been Tested?
A new test was added to the bottom of typescript-mongo.spec.ts that checks that referecing an interface in a type's field does not try to access output that was never generated.

[X] Interfaces should be valid field types, not just objects - issue #7615

Test Environment:

OS: macOS Monterey v12.2.1
@graphql-codegen/typescript-mongodb: 4.4.1
NodeJS: 17.2.0

Checklist:

[X] I have followed the CONTRIBUTING doc and the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

Further comments
This change works by checking whether the type referenced in a field with the @link directive is an object, union, or interface in the user's GraphQL schema. If it's an object or union we can use the config's dbTypeSuffix and if it's an interface we can use the config's dbInterfaceSuffix to generate the correct output. However, despite the fact that this feature was never documented, the @link directive can take an overrideType argument. While this isn't an issue if the user references an overrideType that is explicitly defined in the schema, it is an issue if it's not defined. In fact, typescript-mongo.spec.ts even references an instance when it's not (look for @link(overrideType: "MachineDocument", MachineDocument is never defined in the schema). One way to account for this was to just check whether the type is an interface, and if so use the dbInterfaceSuffix and in all other instances use the dbTypeSuffix. This would not break backwards-compatibility as previously dbTypeSuffix was (incorrectly) always used. However, this felt like a duct-tapey hacky fix, and it made much more sense to me to add a new value to the config of typescript-mongodb which I called defaultLinkOverrideTypeSuffix, which has a default value of DbObject. Then, the code can explicitly check if a specified type is an object, interface, or union in the schema, and in all other instances default to the new config value. By default, it is of value DbObject, which maintains backwards-compatibility and passes all current checks.
Next steps to proceed from here might be to include a new overrideTypeMap value (or something like that) in the config to explicitly map out what overriden types should look like, as the defaultLinkOverrideTypeSuffix approach is farily inflexible and just a stopgap that maintains backwards-compatibility. This will require a broader conversation, though, and I would definitely appreciate input.

Hi!
All community plugins (see list below) have been moved to a new dotansimha/graphql-code-generator-community.

Community plugins:

@graphql-codegen/typescript-react-apollo
@graphql-codegen/typescript-graphql-request
@graphql-codegen/typescript-apollo-angular
@graphql-codegen/typescript-apollo-client-helpers
@graphql-codegen/typescript-react-query
@graphql-codegen/typescript-urql
@graphql-codegen/named-operations-object
@graphql-codegen/urql-introspection
@graphql-codegen/flow-resolvers
@graphql-codegen/typescript-vue-apollo
@graphql-codegen/typescript-rtk-query
@graphql-codegen/flow-operations
@graphql-codegen/typescript-msw
@graphql-codegen/typescript-mongodb
@graphql-codegen/typescript-type-graphql
@graphql-codegen/jsdoc
@graphql-codegen/typescript-vue-urql
@graphql-codegen/kotlin
@graphql-codegen/typescript-vue-apollo-smart-ops
@graphql-codegen/java
@graphql-codegen/c-sharp-operations
@graphql-codegen/hasura-allow-list
@graphql-codegen/typescript-stencil-apollo
@graphql-codegen/relay-operation-optimizer
@graphql-codegen/typescript-oclif
@graphql-codegen/java-resolvers
@graphql-codegen/java-apollo-android
@graphql-codegen/flutter-freezed

Please move your PR by following these steps:
From your current PR branch:

git remote add codegen-community git@github.com:dotansimha/graphql-code-generator-community.git
git fetch codegen-community
git push codegen-community

Open the PR on dotansimha/graphql-code-generator-community and close this PR.
Thank you!

Hey @benhchoi 👋 I'm closing this PR, but if you want to continue your work, please follow the steps provided here: https://github.com/dotansimha/graphql-code-generator/pull/7641#issuecomment-1305396562


chore: bump ustr to v1.0.0

hmm ... there's a change to ahash https://github.com/anderslanglands/ustr/commit/11c81783a1dd15559f76a0d90190c22affd30ab0#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R22

ustr bumps ahash, from the doc https://github.com/tkaitchuck/aHash
ecause it does not have a fixed standard, different computers or computers on different versions of the code will observe different hash values.
hash values are not consistent :-)


how to set many Workers?

I want to build multiple async function works. How can I do this? The following cannot be achieved
Monitor::new()
    .register_with_count(6, move |_| {
        WorkerBuilder::new(worker_storage.clone())
            .layer(SentryJobLayer)
            .layer(TraceLayer::new())
            .build_fn(queue::send_email)
            .build_fn(queue::send_message)
            .build_fn(queue::and_more)
    })

Do you mean something like this example?

Related to #8

FYI one worker can only take one job fn. If you need to use the same layers you could just use an enum.

FYI you can use the steer feature by tower too:
https://docs.rs/tower/latest/tower/steer/index.html


[ACQ] 202110993J

Url : https://jbp.botalista.community/#/acquisition/edit/51898
Username : paris
Description : null

Error details
Request url: https://jbp.botalista.community/api/acquisition/pov/2
Request method: POST
Status Code: 405 (Method Not Allowed)
Data send:
{"typeEntite":"J","version":0,"idAcquisition":51898,"uid":"2eaf921f-9526-4aca-bf2f-9b8101102264","sector":{"version":0,"idFunctionalUnit":7,"name":"Pôle indigène","site":"Parc Floral","type":"enum_sector","uid":"60fcb65e-5ef9-4d82-adbf-f0b1852a78b2","archive":false,"location":null},"acquisitionDate":"2021-07-09","institute":"JBP","acquisitionDatePrecision":"day","specimenNumber":993,"provenanceMode":"enum_harvest","materialType":"enum_wholeplant","unit":"enum_piece","amount":1,"provenanceType":"enum_garden","acquisitionName":"Tussilago farfara L.","requireDetermination":false,"determinations":[{"version":0,"iddetermination":52057,"provisionnal":false,"taxon":{"uid":"55934746-5c95-4a45-afad-ca3f76cab643","id":19886,"idDivision":56609,"division":"Angiosperms","divisionHybride":false,"idOrdo":13633,"ordo":"Asterales","ordoAuthority":"Link","ordoHybride":false,"idFamily":30945,"family":"Compositae","familyAuthority":"Giseke","familyHybride":false,"idGenus":28558,"genus":"Tussilago","genusAuthority":"L.","genusHybride":false,"idSpecies":36480,"species":"farfara","speciesAuthority":"L.","speciesHybride":false,"povUid":"eb813851-8850-4dce-b6db-7d7f8e869e45","name":{"nodeChain":36480,"uid":"2035bed8-e874-4f51-8164-bff30f4cf9c0","completeName":"Tussilago farfara L."},"authority":"L."},"date":"2021-07-09","datePrecision":"day","dateunknown":false,"status":"enum_none","accepted":true,"collective":null,"quality":null,"complement":null}],"ipenCode":"XX-0-JBP-20210993","ipenRestriction":false,"number":"20210993J","productionType":{"version":0,"id":9,"name":"uncertain"},"oldID":null,"site":{"name":"Parc Floral"},"referenceNumber":null,"country":{"idPoliticalPlace":83},"harvest":{"idHarvest":44741},"parent":null,"countryCultivar":null,"obtainingDate":null,"note":null,"maturity":null,"wildType":null}
Error Type: com.botalista.lib.core.errors.container.CriticalError
Error message:
undefined


Add new Dark theme.

Suggestion for adding one new brilliant dark color theme.

And the screenshot :)

@tanyogeorgiev, the extension is now available in both insider and stable builds of ADS.


Nuxt-Bridge ' [worker] Invalid or unexpected token '

I'm trying to use bridge in my nuxt app, but this error its showing after build, if I remove '@nuxtjs/tailwindcss' from  buildModules the error goes away. Any idea ?
Loader.moduleStrategy (internal/modules/esm/translators.js:145:18)
async link (internal/modules/esm/module_job.js:67:21)

This comes from the config viewer. It should work if you temporarily disable it by
  tailwindcss: {
    viewer: false,
  },

in your nuxt config.

The problem still persists, and hopefully will be fixed as part of https://github.com/nuxt-community/tailwindcss-module/pull/407


Bump to <IP_ADDRESS> & Rakefile

Updated to Summernote 0.8.12 & Rakefile is updated so that bundle exec rake update copies ALL dist files & updates font URLs in all CSS files

Hello @luciuschoi @hackerwins ! Can you check this out please ? Thank you 🙏

Thank you for your nice devotion.

Thanks to you! Do you know when will it be released?


onWidgetResize is called only on initial draw

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
I'm writing a new dashboard widget (not associated with any plugin) and I've noticed that onWidgetResize is called only on a initial draw of the widget. I've reduced the code to this stub below and it stil does not call this method more than once. I've added similar console message to the WOL widget and it's being printed normally on each resize, and both widgets have similar structure.
I've tried to debug it on my own but I've hit a wall, so any help would be appreciated.
export default class IfClientsWidget extends BaseTableWidget {
    constructor() {
        super();
        this.test_cnt = 0;
    }

    getMarkup() {
        let $container = $('

');
        let $if_cli_table = this.createTable('if-clients-table', {
            headerPosition: 'none'
        });

        $container.append($if_cli_table);
        return $container;
    }

    async onWidgetTick() {
        this.test_cnt += 1;
        let rows = [];
        rows.push([`${this.test_cnt}`,`${this.test_cnt}`]);
        super.updateTable('if-clients-table', rows);
    }

    onWidgetResize(elem, width, height) {
        console.log('resize-widget');
        return super.onWidgetResize(elem, width, height);
    }
}

To Reproduce

Create a widget from template above
install it and add to dashboard
resize window
No 'resize-widget' messages printed
Reload window
Single 'resize-widget' message printed

Expected behavior
onWidgetResize method is called each time window size changes
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 24.7.4-amd64

I cannot reproduce this:
Firefox:

Chrome:

Metadata file formatted as documented? e.g.
    <ifclientswidget>
        <filename>IfClientsWidget.js</filename>
        <translations>
            <title>Test</title>
        </translations>
    </ifclientswidget>

Thank you!
I had dashes in the metadata main field name:
    <if-clients-widget>
        <filename>IfClientsWidget.js</filename>
        <translations>
            <title>Test</title>
        </translations>
    </if-clients-widget>

This file had been used to some extent (translations had been used and I could do API calls), but I couldn't resize.
Once I've removed the dashes it works as intended.
Thanks again! I wouldn't have found it otherwise :)

@m3e-g Glad you found it :)


Change default size to allow different MobileNet sizes

@fchollet There is a MobileNet image size selection problem in the current implementation.
Due to the use of _obtain_input_shape(...), the default_size provided is a static 224. While this generally works well for models with only 1 input size, for the MobileNet family of models, it is not suitable.
The issue is that when one passes input_shape as anything other than the default of 224 (128, 160 and 192 are supported as well), an error stating that the default size required with include_top=True is (224, 224, 3) is raised. This is a problem, since there exist weights for smaller input size models. They just can't be accessed with the standard working of _obtain_input_shape.
There are two possible ways to fix this :

Make _obtain_input_shape support a list of default sizes. Usage of this method would be simpler then, though a very clean implementation would be a tad bit more difficult (but can be managed).

Do a pre-check for input_shape (if provided), check it is one of the possible sizes supported by MobileNet, and then change the default_size to match this input size. There is a fallback to the default_size = 224 if the provided input shape is not in the list of supported sizes (and then _obtain_input_shape can check and raise errors if needed).
This means there is no need to change the _obtain_input_shape code, and the task falls to the method caller to make sure the correct default_size is provided.

In my opinion, since it is relatively rare for a single model to be trained on different image sizes, I prefer option 2. Therefore, that has been implemented in this PR.

Rerunning tests, because most of them failed due to pip errors.

There is a MobileNet image size selection problem in the current implementation.

Please add a unit test.
Don't worry about the CI failure, Travis is currently having some issues.

@fchollet Added a unit test to check whether the 4 valid input shapes are correctly built using the model, and in invalid image size test to make sure a ValueError is raised from _obtain_input_shape is raised.


Release Google.Cloud.BigQuery.Migration.V2 version 1.0.0-beta01

Changes in this release:
Initial release.

Created release for Google.Cloud.BigQuery.Migration.V2-1.0.0-beta01


irobot_create_msgs: 2.1.0-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository irobot_create_msgs to 2.1.0-1:

upstream repository: https://github.com/iRobotEducation/irobot_create_msgs.git
release repository: https://github.com/ros2-gbp/irobot_create_msgs-release.git
distro file: rolling/distribution.yaml
bloom version: 0.11.2
previous version for package: null

irobot_create_msgs
* rename DockServo action into Dock and Dock msg into DockStatus
* Contributors: Alberto Soragna

Hi, any chance we can merge this?
We also need to release the create3-simulator package which depends on this.

Rolling is currently in a sync hold, it will be merged with the hold is released.


invite me to organization

Contact Details
No response
Discord Username
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey, @CodingSpecies can you create a new issue with the details asked in the issue. For now, I am closing this issue.


Toggle key please

Currently using another training software JUST because it can make toggle-able keys. Ofc, fedoraware is better than that one, but the fact that theres no toggle-able keys in fedoraware makes me use the other thing. So please, add toggleable keys :D

Sorry brother, the pasters don't know how to make toggle keys sadly so you need to buy a rijin or nullcore for a key toggle.

i tried to make toggles but i accidentally toggled off my brian


Shorten path printing?

examples/user_guide/Network_Graphs.ipynb::D:\code\ioam\holoviews\examples\user_guide\Network_Graphs.ipynb PASSED                              [ 98%]

Is there a reason to include both these paths in each message?  Seems like either the relative or absolute path would be sufficient, and using only one would  make the output much more readable.  I'd prefer the relative one (perhaps with the cwd printed at the top of the run to show what the absolute path would be) so that output is more easily compared across systems. (Plus the relative output is shorter!)
BTW, next time you're in Texas, we'll have to check out https://www.nbsmokehouse.com .

I doubt there's a good reason for the way it is now - using just the relative path sounds like a good idea.


Using Chaos Mesh to enhance pegasus's stability

Hello, I am Chaos Mesh maintainer. Chaos Mesh is a open source chaos engineering platform for Kubernetes.
As you may have known, chaos engineering is a promising method that can guarantee system resilience. We have been practicing chaos engineering for long on databases and have found many issues in various fault scernarios (for example data consistency issue caused by excessive recovery time). Some of the issue records at https://github.com/orgs/chaos-mesh/projects/1. There are also many adopters who are using Chaos Mesh to test their systems, such as PingCAP, Daily motion, Xpeng Motors, Meituan-Dianping, Apache pulsar, etc.
That said, I would like to invite you to use Chaos Mesh to enhance pegasus's stability. You can directly use Chaos Mesh or integrate it with your test platform. Chaos Mesh supports rich injection methods, such as pod/container kill, network partition, network interruption, CPU/memory usage, time rollback, disk failure, etc.
Welcome to use it to enhance the stability of pegasus. If you have any questions,  submit an issue at https://github.com/chaos-mesh/chaos-mesh, or send me an email<EMAIL_ADDRESS>Hope this helps and look forward to further communications. ❤

@zhouqiang-cl You guys are pretty nice :) We actually have an objective to integrate Chaos Mesh in our system. I think this is a very practical and innovative tool to improve our testing process.
Nevertheless, there're some problems the Pegasus needs to solve out first. The prerequisite for Chaos Mesh is a Pegasus deployment automated inside k8s. But this is not trivial since Pegasus is a stateful service. We do not have "tidb-operator"-like stuff.

@zhouqiang-cl You guys are pretty nice :) We actually have an objective to integrate Chaos Mesh in our system. I think this is a very practical and innovative tool to improve our testing process.
Nevertheless, there're some problems the Pegasus needs to solve out first. The prerequisite for Chaos Mesh is a Pegasus deployment automated inside k8s. But this is not trivial since Pegasus is a stateful service. We do not have "tidb-operator"-like stuff.

Sorry for the late reply.
Very glad that you have the interest,  If you have any problem in using Chaos Mesh, we are very pleasure if we can help
Waiting for your great news  ❤


[Animation] Using SpringAnimation like UIScrollView's rebound

Are tension & friction (or speed & bounciness) sufficient to mimic the rebounding in Apple's UIScrollView?
I assume not, since CASpringAnimation has mass, damping, & stiffness properties.
For example, when you fling a UIScrollView and it hits the upper bound while decelerating, there is a noticeably longer overshoot than I've experienced with React Native's SpringAnimation. But perhaps this effect is achievable with tension & friction (or speed & bounciness)?
Maybe SpringAnimation should have mass, damping, & stiffness properties?
RBBSpringAnimation seems like a good place to start.
cc @sahrens

@facebook-github-bot stack-overflow

@facebook-github-bot feature

Are tension & friction (or speed & bounciness) sufficient to mimic the rebounding in Apple's UIScrollView?

Maybe they are, I'm not sure. What's the specific issue you've ran into. Have you found a use case where the tension and friction don't work well enough?

I'll close this as I don't see how the issue is actionable (yet) but feel free to use this issue for discussion.

This is my main issue:

when you fling a UIScrollView and it hits the upper bound while decelerating, there is a noticeably longer overshoot than I've experienced with React Native's SpringAnimation

After tinkering with the values of tension/friction and speed/bounciness, it seems impossible to get a longer overshoot using SpringAnimation.


Angular app with library fails on prod build

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
Unsure, as this is the first time building a library.
Description
Running ng build --prod fails with Module not found error, but every ng build (without prod) works.
The bug is present every time we build for prod on either Windows, Mac or Ubuntu.
🔬 Minimal Reproduction

Clone https://github.com/hafslundnett/hal-components/tree/build-prod-error
yarn
yarn build-hal
ng build --prod

The library is small, but let me know if you want a more stripped down version.
🔥 Exception or Error
The total error message is really long, here is the first 50 lines. Let me know if you need the rest.

ERROR in ./dist/hal-components/hafslundnett-hal-components.ngfactory.js
Module not found: Error: Can't resolve '@hafslundnett/hal-components' in 'C:\Users\jgh\Documents\hal-components\dist\hal-components'
resolve '@hafslundnett/hal-components' in 'C:\Users\jgh\Documents\hal-components\dist\hal-components'
  Parsed request is a module
  using description file: C:\Users\jgh\Documents\hal-components\dist\hal-components\package.json (relative path: .)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      looking for modules in C:/Users/jgh/Documents/hal-components/
        using description file: C:\Users\jgh\Documents\hal-components\package.json (relative path: .)
          Field 'browser' doesn't contain a valid alias configuration
          using description file: C:\Users\jgh\Documents\hal-components\package.json (relative path: ./@hafslundnett/hal-components)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              C:\Users\jgh\Documents\hal-components\@hafslundnett\hal-components doesn't exist
            .ts
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .tsx
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            as directory
              C:\Users\jgh\Documents\hal-components\@hafslundnett\hal-components doesn't exist
      C:\Users\jgh\Documents\hal-components\dist\hal-components\node_modules doesn't exist or is not a directory
      C:\Users\jgh\Documents\hal-components\dist\node_modules doesn't exist or is not a directory
      C:\Users\jgh\Documents\node_modules doesn't exist or is not a directory
      C:\Users\jgh\node_modules doesn't exist or is not a directory
      C:\Users\node_modules doesn't exist or is not a directory
      C:\node_modules doesn't exist or is not a directory
      looking for modules in C:\Users\jgh\Documents\hal-components\node_modules
        using description file: C:\Users\jgh\Documents\hal-components\package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
          using description file: C:\Users\jgh\Documents\hal-components\package.json (relative path: ./node_modules/@hafslundnett/hal-components)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              C:\Users\jgh\Documents\hal-components\node_modules\@hafslundnett\hal-components doesn't exist
            .ts
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .tsx
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            as directory
              C:\Users\jgh\Documents\hal-components\node_modules\@hafslundnett\hal-components doesn't exist
[C:\Users\jgh\Documents\hal-components\@hafslundnett\hal-components]
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
🌍 Your Environment

Angular CLI: 8.3.17
Node: 10.16.0
OS: win32 x64
Angular: 8.2.13
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.803.17
@angular-devkit/build-angular      0.803.17
@angular-devkit/build-ng-packagr   0.803.17
@angular-devkit/build-optimizer    0.803.17
@angular-devkit/build-webpack      0.803.17
@angular-devkit/core               8.3.17
@angular-devkit/schematics         8.3.17
@angular/cdk                       8.2.3
@angular/cli                       8.3.17
@angular/language-service          8.1.3
@angular/material                  8.2.3
@ngtools/webpack                   8.3.17
@schematics/angular                8.3.17
@schematics/update                 0.803.17
ng-packagr                         5.7.1
rxjs                               6.5.3
typescript                         3.5.3
webpack                            4.39.2

Anything else relevant?
Present on Windows, Mac and Ubuntu

Hi, the problem is that your library is named ```https://github.com/hafslundnett/hal-components/blob/860da33c19a15fabdc9e7812392684e5bc70946b/projects/hal-components/package.json#L2
However you are importing this via hal-components https://github.com/hafslundnett/hal-components/blob/b42ed822b82c07739227c23b1f5dafc92c408b68/src/app/shell/shell.component.ts#L3
There are two things here;

rename your library to hal-components

or

Change the imports from hal-components to @hafslundnett/hal-components
Change also the path mappings in https://github.com/hafslundnett/hal-components/blob/b42ed822b82c07739227c23b1f5dafc92c408b68/tsconfig.json#L23-L29 to

      "@hafslundnett/hal-components": [
        "dist/hal-components"
      ],
      "@hafslundnett/hal-components/*": [
        "dist/hal-components/*"
      ]

Didn't know the name in the package file in the library impacted the build process. Using @hafslundnett there so it's published to that organisation on NPM when publishing. Updated the imports and the tsconfig file and it compiles now. Thanks a lot for your help!

It inconsistent that is only fails with the prod flag, given that the name and imports are wrong in both cases. Any chance this will be fixed with Angular 9 and Ivy?

Hi @JGH153, the reason why this fails with prod only is that in prod mode the AOT compiler is used instead of the JIT compiler.
While this is valid in JIT, it is not for AOT because of metadata symbols. In version 9 under Ivy both AOT will be enabled for both development and production builds.


Wrong display amount for international currency

I am getting an issue to display amount of 1000 EURO, while actual transaction amount goes for payment of 10 EURO.
We have already processed amount of 10 EURO, which displays 1000 EURO.
Following is the code to process and display amount:
$currencyAmount = 10;
$displayCurrency = 'EUR';
$orderData = [
    'receipt'         => 3456,
    'amount'          => (int)$currencyAmount * 100, // 2000 rupees in paise
    'currency'        => $displayCurrency,
    'payment_capture' => 1 // auto capture
];

Here, transaction amount is going to proper with 10 EUR while issue is having only with displaying amount of 1000 EUR in place of 10 EUR

I am also experiencing the same issue.

@alkesh211 @chan2020  This issue has been fixed i have checked this from my side and it showing correct amount

Closing this issue for now let me know if you are still getting this issue


Highlighted word is the previous candidate word when using fuzzy search

Version confirmation

[X] Confirm

Following prerequisites

[X] Confirm

Neovim version
NVIM v0.9.1
Operating system/version
ubuntu22.04
Terminal name/version
kitty0.29
$TERM environment variable
No response
Branch info
main (Default/Latest)
Fetch Preferences
SSH (use_ssh = true)
How to reproduce the issue
no
Expected behavior
Highlighted word should be candidate word
Actual behavior

Additional information
No response

try

I fixed this long time ago and don't use wilder now

Can reproduce.

try
I fixed this long time ago (forget how) and don't use wilder now so not sure if it works

sovled, many thanks


Add roadmap docs

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #408 (9a5f600) into main (d3dea0c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   38.53%   38.53%
=======================================
  Files          80       80
  Lines        6204     6204
=======================================
  Hits         2391     2391
  Misses       3475     3475
  Partials      338      338

Flag
Coverage Δ

unittests
38.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


chore: update

Codecov Report

Merging #124 (9d87410) into main (c3801cf) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 9d87410 differs from pull request most recent head 0c1f410. Consider uploading reports for the commit 0c1f410 to get more accurate results

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   18.51%   18.51%
=======================================
  Files          40       40
  Lines         351      351
  Branches       45       45
=======================================
  Hits           65       65
  Misses        277      277
  Partials        9        9

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Copy all property descriptors to installed methods

Purpose (TL;DR) - mandatory
Fix #347 by copying symbol own-properties to installed methods.
Background (Problem in detail)  - optional
The for...in loop used to copy properties only copies string own-properties to installed methods, which omits util.promisify.custom necessary for util.promisify support on Node as added in #292.
Solution  - optional
This PR copies all own-property descriptors to get both Symbol own-properties and to copy any getters/setters that may be added in the future.
If there's a reason getters/setters should not be copied, let me know and I can add an Object.assign polyfill to sinonjs/commons and use that instead.
Thanks for considering,
Kevin
Fixes: #347

I don't know why this has been dormant for five months, but I see @benjamingr approved it, so I guess it's good. Just merge it the next time, Benjamin, unless there's something specific you want a second pair of eyes on (in which case you just ping that someone) 🙂


Deduplication: add a step that deduplicates events

move duplicate events to a temporary table
delete those events from atomic.events
combine true duplicates
move non-true duplicates to their own tables (e.g. bot-generated)

See #24 for a detailed treatment of the problem

Thanks @alexanderdean.
I discussed this with @yalisassoon this morning, and the idea was to have this as a SQL Runner step after each load. Natural copies get deduplicated, while synthetic copies get moved to a separate events table.

Sounds good!
On 6 Jul 2015 1:02 pm, "Christophe Bogaert"<EMAIL_ADDRESS>wrote:

Thanks @alexanderdean https://github.com/alexanderdean.
I discussed this with @yalisassoon https://github.com/yalisassoon this
morning, and the idea was to have this as a SQL Runner step after each
load. Natural copies get deduplicated, while synthetic copies get moved to
a separate events table.
—
Reply to this email directly or view it on GitHub
https://github.com/snowplow/snowplow/issues/1866#issuecomment-118833774.


Fix path type detection for differing remote path type.

This change will use the CWD to detect the path type where the
debugger is running and use that to determine whether the target was
supplied with an absolute or relative path.

Looks like a reasonable approach.
It is based on the following

Since the CWD is expected to be an absolute path in the debugger's environment

but that assumption is never checked, is it? (I know that I've used a relative cwd and/or . in the past, possibly only for the hack "tell the extension to attach, then do the actual attaching via autorun commands", which doesn't need to work forever.

Looks like a reasonable approach. It is based on the following

Since the CWD is expected to be an absolute path in the debugger's environment

but that assumption is never checked, is it? (I know that I've used a relative cwd and/or . in the past, possibly only for the hack "tell the extension to attach, then do the actual attaching via autorun commands", which doesn't need to work forever.

@GitMensch, I was trying to think of a case in which a non-absolute CWD might be supplied and we'd think it was okay to do so.  Your scenario might be the case...although a probably unexpected case.  However, with an attach, we don't use target within initCommands anyway, so even if it was constructed with the wrong path type, that is probably fine (since it isn't subsequently used).  I just tested the attach with GDB for attaching to a PID as well as a remote attach and they worked fine with a "." CWD, since the subsequent target is not used.
I did notice other places of the code (outside the initCommands) that likely don't work with attaching when you don't supply an absolute CWD.   Once place is the LLDB attach (since it issues the file-exec-and-symbols command here).  Another would likely be the "extended remote".  So your method probably only works in certain attach scenarios but not all, but I don't believe the changes here would have affected those scenarios.  Additionally, I'd think if the changes as described in #329 are implemented, this would probably at least make the GDB attach to PID not work with your method either, if it follows the LLDB approach.

If this still doesn't seem sufficient, I could first check that the target path is not a POSIX absolute path and not a Win32 path before attempting to detect the path type from the CWD for the subsequent join.  This might be a little safer in the case where the target is already specified as an absolute path, but the CWD isn't.
if (!path.posix.isAbsolute(target) && !path.win32.isAbsolute(target)) {
	const debuggerPath = path.posix.isAbsolute(cwd) ? path.posix : path.win32;
	target = debuggerPath.join(cwd, target);
}

I think a Win32 relative path using a leading / path separator could be misinterpreted this way as a POSIX absolute path though.  Let me know what you think of this, or if you have a better idea on an approach.

Any decision on this?  I'd like to resolve this as HEAD is essentially broken right now for SSH connections due to this problem.  If the fix is to just to do the change as suggested in https://github.com/WebFreak001/code-debug/commit/43cc39e7773f1122ab61cc863256d2264a865e3c, that's fine, but this problem blocking me from addressing some of the other issues.

Seems like it did not come through the mail gateway, so here directly again.
I'm undecided.... if @WebFreak001 does not say otherwise then I'll merge tomorrow (= this evening) as I guess you've tested SSH from posix->posix, win32->win32, posix->win32, win32->posix.
If you didn't test some of those please drop a note and I'll test the missing pieces directly after the merge.

Thanks for working on this.
If you know a test was missing, please drop a note (in general it will be better than my half commit that was there before).

I have a setup on Windows now as well.  I did test all 4 combinations that you mention above and they all seem to be working as expected.


add issue labelers for the pkgs packages

add issue labelers for the pkgs packages

This will normalize what people see when filing issues.

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Should we add cross-package issue type? Sometimes it is not clear what package it is about.

The 'open issue' screen as-is will look something like this:

They do have a 'file a general issue' link at the bottom, but I agree it's not always clear to the user that it's there. We could update the text for the package:leak_tracker one to say 'this is the one that you likely want to use'; YMMV. Happy to make changes to this PR (or, have the templates updated after this lands).

I'll land this; we can see how it looks then, and possibly do more to make the package:leak_tracker more visible.


Make generic checker functions

Maybe we should have a wrapper function that accepts an error instance instead of reimplementing this function for every error type?
Originally posted by @kerzhner in https://github.com/statechannels/statechannels/pull/2446

stale

stale


Fix broken links

the SQL statement links on this page were going to the wrong place.

Thanks for finding these. However, you need to point to the docs.microsoft.com location; MSDN exists only in the archive now. I'll fix these links this time.

Docs Build status updates of commit d860d00:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

access/Concepts/Structured-Query-Language/create-and-delete-tables-and-indexes-using-access-sql.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Linda-Editor ok, but i just copy and pasted the links from CREATE and DROP

If you click the links, they redirect to the docs.microsoft.com URLs, which we should use going forward.


Crypto::shared() as mentioned in docs does not exist

should be: Crypto::shareable()
(see vendor/yab/crypto/src/Services/Crypto.php)

Thanks - now updated!


Issues relating to Time tracking (Farming Related Stuff)

There will be times where time tracking shows wrong progression bar at times. In addition there are issues where diseased or dead plants only show when you are right next to the plant. If the player is not next to the dead plant it may show as green (making them think it is still healthy) until they go near it.

The times can be fixed by calibrating the tracker. This is done by observing a tree grow
For years now (since around the release of the Geomancy spell), the client has been unaware of the state of patches globally. This is not a bug; Jagex intentionally changed that, and it's impossible to get it back.


Write table properly for multiple tables.

The bug was actually that table titles were not being written when
-progressive was set to false. It just happens that when specifying
multiple tables, -progressive gets set to false by default.
Use the right option (self.options.title) instead of self.title.
Also add a test to cover this so we'll know if it breaks again.
This fixes #350.
@dmehra

+1 lgtm


Import Wallet.dat > Node is disconnected

DeFi app V2.3.0
Error message shown on the display:

Unable to start blockchain

Displayed error message in the debug.log file:

Wallet.dat corrupt, salvage failed

I moved the Wallet.dat file and restarted the computer. After that, the app worked. When I try to import the Wallet.dat file, the programme crashes and I get the error message "Node is disconnected". After that I restart the app and get the same error message as above again.

Unable to start blockchain

Attached are all the documents. Log data and also the Wallet.dat file.
210302 RobinTorque - app_binLog_appConfig_db.zip

Same here. After the 2.3.0 upgrade (on macos Big Sur) I'm unable to successfully restore my wallet.

Hi @RobinTorque , thanks for your feedback, please give us time to investigate.

I resolved my issue myself; selecting my backed-up wallet when restoring causes the app to point to the wallet.dat file, not import it. As my wallet.dat backup was on read-only storage, using that as an active wallet was an issue.
Simply copying wallet.dat to another folder on my Mac and restoring from that location worked.
Might I suggest your restore process instead copies the wallet.dat file to the %appdata% or Application Support folder? Seems that would make most sense, don't you think? The process is named "restore wallet", not "open wallet".
; )

Hi @q20 , thanks for your feedback, good to know that you manage to Restore your wallet via wallet.dat. The wallet.dat files are crucial hence kept in a hidden folder so only the user himself can access it. There are events where user decides to delete & reinstall the app and/or proceed to delete files they're unfamiliar with. This mitigates the issue of them losing their wallet.dat — serves as a backup for these kind of case scenario. Of course we can't cover all 100% scenarios but the team decided that this the the best solution thus far. I understand it's a bit tedious to find it, but from now on, you can save it in a more accessible folder. Thank you for your understanding.

Hi @RobinTorque @q20 , update v2.3.1 is out.
 Do give a thumbs up to this comment if your issue has been resolved, otherwise, please leave a comment with new information (include screenshots) and app logs. Thank you.

As I was able to resolve my issue myself, I will be unable to comment on whether the 2.3.1 update coulda/shoulda/woulda help.  ; )

Hi @izzycsy
For me this problem has been solved. I have created an error correction for the other people in the wiki.

Hi @RobinTorque , noted with thanks. I'll close this issue in the mean time.