Discovery and Pairing

Hi,
I need to be able to create an app that will discover a Bluetooth device and pair it with a mobile device (smartphone/tablet). I came across this Cordova plugin as I am using Cordova to build the application. I have installed the plugin and build the apk from the example included. The enable and disable buttons work as expected but the discovery button doesn't display any results even though I have other Bluetooth devices on and ready for discovery.
The second part of my question is after device discovery how would I pair?
Thanks and Regards

Hey,
What version of Cordova are you using? Back when I was (relatively) active in developing the plugin I think the Cordova version was something like 3.0, so I can't really say everything works fine if you're using the latest versions. Take a look at what the application is logging when you try to discover devices, the console.log commands should be sent to the Eclipse debugger IIRC.
I think you might want to take a look at some of the more recently updated plugins, that also support the low energy stuff.

Hello Taneli,
I'm using the latest version of Cordova 4.0. I'm not currently using Eclipse as my dev environment I'll probably have to set that up. I tried looking at a couple of the newer plugins but yours is the only one that I have working in any form so far.
I'm assuming my test devices may lack proper support for BLE just guessing here. I'm using a Nexus 7 2013 and a Sony Xperia M (first generation). I'm trying to pair them with a Bluetooth 3.0 headset.
Thanks for your response.

Hi,
I have no testing experience with Cordova 4., so I can't really guarantee this plugin works properly with that. I've not tested this plugin with any BLE devices so I can't really comment on that.
Hope you get your app working!

Thanks Taneli,
I understand. Not sure what my next move is yet. Thinking I may just have
to exclude Bluetooth integration for now if I can't find a working solution
in the next few days. Thank you for your help.
Regards,
Stewart
On 16 June 2015 at 06:39, Taneli Hartikainen<EMAIL_ADDRESS>wrote:

Hi,
I have no testing experience with Cordova 4., so I can't really guarantee
this plugin works properly with that. I've not tested this plugin with any
BLE devices so I can't really comment on that.
Hope you get your app working!
—
Reply to this email directly or view it on GitHub
https://github.com/tanelih/phonegap-bluetooth-plugin/issues/31#issuecomment-112393256
.

Hi Taneli,
I continued to play around with your plugin I have found that the discovery works. It just doesn't display the list of devices found after discovery is run. I'm not familiar with backbone.js or underscore.js so it's not clear to me how to make this happen. Do you think you can assist me here.
Regards,
Stewart

Hey,
Glad to hear you got the discovery working.
Do you have a way to see the output of the console.log commands from the JavaScript code? You should be able to verify that you are discovering the devices by listening to the console.log here. If you're seeing any errors or warnings from the code, that might also help finding the solution to this problem.
With backbone.js the "flow" of the device data from the actual plugin code to the front end you're seeing (or currently not seeing), is relatively simple. Discovered devices are wrapped in a Device::Backbone.Model instance and added to the single DeviceCollection::Backbone.Collection in the example application. This collection is set as the "data source" for the DeviceListView::Backbone.View, which listens to the reset and add events on the collection and renders itself.
Check out this code to see the device discovery process which takes the device data received from the plugin and adds it to the backbone collection.
It might also be useful to check that the BluetoothState is not jammed in the Busy state for some reason.
There is also the scary fact that the packages mentioned in the bower.json file are not locked to the specific version but are relaxed in terms of patch updates. These updates should never break any backwards compatibility but you never know. Check which versions of the dependencies you are running,  and test if you can get the specific versions mentioned in the bower.json by removing the ~ character from before the semver number.

Hello,
I'm using alerts instead of the console.log I can see from my alerts that my device is discovered I had to modify your code a little but it returns the device address and name.
I am reading through your code and I'm beginning to slowly decipher it :)
I have the latest versions of the packages from the bower.json file but his is because I downloaded and added them myself. I revert to the versions in the bower.json and let you know if anything changes.
Thanks again

Hey,
I have the code working now the way I want it. I am pairing my android phone with a headset. Everything works as expected and the phone is paired. My concern now is the headset it's actually playing any audio. When I pair the devices through the phone's Bluetooth settings the audio is played through the headset.
Any ideas why I might be having this issue
Thanks

Hi,
I'm not sure if it's possible to transmit audio using the basic BluetoothDevice instance used by the plugin. I think you might need to edit the plugin code to use the BluetoothHeadset if the BluetoothClass of the device happens to be something akin to "headset". You might need to modify the plugin code so that it sets the paired device as the audio output if it's something like a headset or some sort of an audio output capable device.
Take a look at the documentation for BluetoothHeadset and Bluetooth in general. I've no experience with audio and Bluetooth, so I'm afraid I can't really offer much help with that matter.
If you need to modify the plugin code to support audio devices, I suggest creating a fork of this repository and then adding your modified fork as a dependency to your project.

Hi, forgive me for my english, i'm brazilian.
I read the previous posts and have a similar problem. The discovery works fine, but my alert in the function onDeviceDiscovered show me Object Object, instead of the device.
onDeviceDiscovered = function(device) {
alert('found device ' + device);
devices.collection.add(new Device(device));
}
Thanks, and sorry abount my english again.

Hey,
The alert coerces the device object into a string, hence the [Object object] notation. You'll probably want to use the following way to verbosely log out the object you receive from the callback:
alert('found device ' + JSON.stringify(device) + '');

My problem, besides this, was with versions of packages. Now, it's ok, but when i click on the button connect, next to device, it always enters onFail, when this function is called:
window.bluetooth.connect(onConnection, onFail, {
uuid:    device.uuids[0],
address: self.model.get('address')
});
I know it's hard to know what it is, having a superficial view of the problem, but can you help me?

Can you print out the error that you're receiving? That would be a start. 🕵

this alert it refers to that function:
var onFail = function(error) {
alert(JSON.stringify(error));
Bluetooth.set({
state: BluetoothState.Ready
});
self.$('.btn-bt-connect').button('reset');
}

What is the device you're trying to connect to? Are you sure there is a bluetooth server accepting connections in it?

I managed to solve the problem: on some devices i had to catch device.uuids[1], because the uuids[0] was giving error(I don't know the reason). Now, i need change message between two android devices, and the function write is working. I saw the parameter onDataRead in startConnectionManager, but I don't know how to read the message received.


New version: GeoMakie v0.4.0

Registering package: GeoMakie
Repository: https://github.com/JuliaPlots/GeoMakie.jl
Created by: @asinghvi17
Version: v0.4.0
Commit: b6eae8f339706b271e06883a4322da4318ab6749
Reviewed by: @asinghvi17
Reference: https://github.com/JuliaPlots/GeoMakie.jl/commit/b6eae8f339706b271e06883a4322da4318ab6749#commitcomment-73176316
Description: Geographical plotting utilities for Makie.jl

[noblock] cc @Datseris @lazarusA


Update Astroid to Version 2.12.2

astroid version 2.12.1

[x] Check the upstream
https://github.com/PyCQA/astroid/tree/v2.12.1

[x] Check the pinnings

setuptools~=62.6
wheel~=0.37.1
https://github.com/PyCQA/astroid/blob/v2.12.1/pyproject.toml#L2
requires-python = ">=3.7.2"
https://github.com/PyCQA/astroid/blob/v2.12.1/pyproject.toml#L33

[x] Check the changelogs

https://github.com/PyCQA/astroid/blob/v2.12.2/ChangeLog
What's New in astroid 2.12.2?
=============================
Release date: 2022-07-12

Fixed crash in modulo operations for divisions by zero.
Closes #1700
Crash in modulo expression
https://github.com/PyCQA/astroid/issues/1700

Fixed crash with recursion limits during inference.
Closes #1646
Infinite loop when inferring from token import *
https://github.com/PyCQA/astroid/issues/1646

What's New in astroid 2.12.1?
Release date: 2022-07-10

Fix a crash when inferring old-style string formatting (%) using tuples.

Fix a crash when None (or a value inferred as None) participates in a
** expression.

Fix a crash involving properties within if blocks.

[x] Additional research
https://github.com/conda-forge/astroid-feedstock/issues

There are currently no open issues mentioned in the upstream.

[x] Verify the dev_url
https://github.com/PyCQA/astroid

[x] Verify the doc_url

https://pylint.pycqa.org/projects/astroid/en/latest/?badge=latest

[x] License is spdx compliant
LGPL-2.1-or-later

[x] License family is present
LGPL

[x] Verify that the build_number is correct

[x] Verify if the package needs setuptools
setuptools

[x] Verify if the package needs wheel

[x] pip in the test section
python

[x] Veriy the test section

[x] Verify if the package is architecture specific or Noarch

[x] Private variables are not mentioned on the recipe For example: (_private_variable)

Results:
Based on the research findings and the results we can conclude
that it is safe to update astroid to version 2.12.1

LGTM

Before uploading v2.12.2 we have to build and upload v2.11.7 https://github.com/PyCQA/astroid/tree/v2.11.7 for pylint 2.14.5, see https://github.com/PyCQA/pylint/blob/566ffca72a1a08c9e7ec14383c4710d64165c592/setup.cfg#L50


image-picker: Set storageOptions.cameraRoll and storageOptions.waitUntilSaved.

See the documentation: https://github.com/react-community/react-native-image-picker#options
Prior to this fix, it was impossible to send an image taken after directly launching the camera. There was no fileName property on the response object passed to ComposeMenu.handleImagePickerResponse.
In the React Native Remote Debugger, this manifested as a console warning that String.prototype.split was being invoked on an undefined value in getFileExtension.
On iOS, when sending a message via directly taking an image from the camera for the first time, iOS will ask for 3 permissions via modal - first, to access the camera, second, after taking the image, to add to the photo library, and third, to access the photo library (read and write). The first time  after granting these permissions, the taken image will not send, which is a bug.
To prevent this bug in the future, those permissions can be granted when the application starts and can be checked whenever the UI for directly launching is used.
@gnprice

Thanks -- merged!
I cut the detailed description of the remaining issue in favor of a link to your followup issue #2973 , because it made it a bit confusing what was new vs. old and what this commit did. :)


Way to edit contactline

Hey! Is there a way to edit the contact line to not consist of the link to the personal website?

In PlushCV.cls I modified the block defined by \newcommand{\contactline} to remove the personal website and phone number
%Contact Line
\newcommand{\contactline}[3]{\begingroup
\setbox0=\hbox{
\includegraphics[scale=0.23,trim={0cm 1.25cm -0.4cm 0cm}]{icons/main/github.png}{#1}\hspace{0.3cm}
\includegraphics[scale=0.23,trim={0cm 1.25cm -0.4cm 0cm}]{icons/main/linkedin.png}{#2}\hspace{0.3cm}
\includegraphics[scale=0.23,trim={0cm 1.25cm -0.4cm 0cm}]{icons/main/mail.png}{#3}\hspace{0.3cm}
}\parbox{\wd0}{\box0}\endgroup}

@Seanny123 thanks for helping out!


nvidia-vaapi-driver: unstable-2022-12-01 -> 0.0.8

Description of changes

The latest release enables the usage of the direct backend with NVD_BACKEND=direct which allows for hardware accelerated decoding on 525 drivers. https://github.com/NixOS/nixpkgs/issues/203705
https://github.com/elFarto/nvidia-vaapi-driver/releases/tag/v0.0.8
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

vainfo is happy, but can't get firefox working on my optimus system.

vainfo is happy, but can't get firefox working on my optimus system.

I needed MOZ_DISABLE_RDD_SANDBOX=1 and NVD_BACKEND=direct set for it to work for me.

would love for this to go through!

Sorry about that, I was attempting to rename my master branch to do more work.


https -> mixed mode blocking

hi,
you should do a quick fix to get all externals fetched from the same domain (e.g. not github.io & github.com to prevent mixed mode blocking of e.g. glfx.js when using https)

@evanw additionally, lately github.io page broke due to a missing library at http://evanw.github.com/glfx.js/glfx.js


Pass max_old_space_size to TSServer

Per discussion here: https://github.com/Microsoft/TypeScript/issues/18055
Some things I noticed while looking into this:

I believe either --max_old_space_size or --max-old-space-size works, v8 args can be dashes or underscores. Underscores work for sure.
TSServer appears to have special logic if global.gc is available, so maybe consider adding --expose-gc as well.
I believe the maximum settings for 64-bit builds of Node is 4096
There's this: https://github.com/electron/electron/issues/9693. Essentially when running VS Code with the ./script/code.sh script, setting these flags in execArgv options in typescriptserviceclient.ts had no effect. I think it'll work if Electron is packaged and ran normally, but I'm not positive.

I gave this a shot but was unable to get it working even when using a production build of VS Code. Looks like this is blocked by: https://github.com/electron/electron/issues/10413

@mjbvz I'm running into the same issue. Our project has to tsc with 4GB of memory, and investigations with @amcasey seem to indicate the issue is a lack of memory for tsserver.
It looks like both Electron issues are resolved, so is this issue now unblocked? It would be great if tsserver memory were configurable in workspace settings.

@MLoughry Can you try making the change and submit a PR if it works? Here's the code where we spawn the tsserver process: https://github.com/microsoft/vscode/blob/f4524551e98945a3025f6038d3d32500182ff167/extensions/typescript-language-features/src/tsServer/spawner.ts#L88

I'll try to set up an enlistment today/tomorrow and try adding a hard-coded value to see if it works. If it does, do you have a quick pointer on where the guide/code to add a new setting would be?

@mjbvz We did an A/B test when VS made this change and OOMs did go down (as you might hope).  When I debugged locally with @MLoughry, we also tried with VS (which passes max_old_space_size) and I don't believe we saw a server crash (though I didn't specifically look for one).

To verify:

Set "typescript.tsserver.maxTsServerMemory": 128
Now open VS Code
This should cause the TSServer to get into a bad state because we cannot load the VS Code project in that amount of memory
Now set it to "typescript.tsserver.maxTsServerMemory": 4000
The project should now load (you may need to restart VS Code)

Works as specified and I can see that tsserver is started with --max-old-space-size=4000/128 through htop


Service and documentation for istio (mesh mode)

closes #56
Changes
This PR adds documentation to run the autoscaler-keda extension with Istio injection.
@skonto I opened this on top of #81, that is why the set of changes is larger. Feel free to directly review only this PR.
Minor Changes

:gift: split development guidelines adding a specific section for Istio.
:gift: documented istio in mesh mode.
:gift: documented installation of prometheus in its own namespace (to facilitate mTLS setup with the documentation provided by Istio) and edits to the config-autoscaler-keda configmap to scrape metric from a specific prometheus address.

istio:
before scaling:
$ kubectl get po -A
NAMESPACE            NAME                                                     READY   STATUS    RESTARTS      AGE
cert-manager         cert-manager-67c98b89c8-gxvtb                            1/1     Running   0             35m
cert-manager         cert-manager-cainjector-5c5695d979-s6jbj                 1/1     Running   0             35m
cert-manager         cert-manager-webhook-7f9f8648b9-zd6jj                    1/1     Running   0             35m
istio-system         istio-ingressgateway-5f8bcfbff9-5cq27                    1/1     Running   0             34m
istio-system         istio-ingressgateway-5f8bcfbff9-lpcpv                    1/1     Running   0             34m
istio-system         istio-ingressgateway-5f8bcfbff9-wh486                    1/1     Running   0             34m
istio-system         istiod-85877f7d98-9gjr9                                  1/1     Running   0             34m
istio-system         istiod-85877f7d98-b87bg                                  1/1     Running   0             34m
istio-system         istiod-85877f7d98-cvchw                                  1/1     Running   0             34m
keda                 keda-admission-webhooks-685d94fcff-kjvlw                 1/1     Running   0             24m
keda                 keda-operator-65f5568c7b-9kbc8                           1/1     Running   1 (24m ago)   24m
keda                 keda-operator-metrics-apiserver-69c577c9cf-qxxhx         1/1     Running   0             24m
knative-serving      activator-5754bdb79d-9gpn5                               2/2     Running   0             34m
knative-serving      autoscaler-57d66f69d9-cmv6j                              2/2     Running   0             34m
knative-serving      autoscaler-keda-fc6b797b4-lvmss                          2/2     Running   0             21m
knative-serving      controller-f48959855-lhrwz                               2/2     Running   1 (34m ago)   34m
knative-serving      net-istio-controller-69858b66f7-qfnq8                    1/1     Running   0             34m
knative-serving      net-istio-webhook-5645569675-jvj2r                       2/2     Running   0             34m
knative-serving      webhook-778946f8-ftjps                                   2/2     Running   0             34m
kube-system          coredns-5dd5756b68-d92j4                                 1/1     Running   0             36m
kube-system          etcd-minikube                                            1/1     Running   0             36m
kube-system          kube-apiserver-minikube                                  1/1     Running   0             36m
kube-system          kube-controller-manager-minikube                         1/1     Running   0             36m
kube-system          kube-proxy-dczz8                                         1/1     Running   0             36m
kube-system          kube-scheduler-minikube                                  1/1     Running   0             36m
kube-system          storage-provisioner                                      1/1     Running   1 (36m ago)   36m
metrics-test-istio   metrics-test-istio-00001-deployment-7d57bbb8d8-86zsg     3/3     Running   0             14m
prometheus           alertmanager-prometheus-kube-prometheus-alertmanager-0   2/2     Running   0             24m
prometheus           prometheus-grafana-69f9ccfd8d-72xb8                      3/3     Running   0             25m
prometheus           prometheus-kube-prometheus-operator-6f4fc4dcbd-2hzqm     1/1     Running   0             25m
prometheus           prometheus-kube-state-metrics-57c8464f66-7h25x           1/1     Running   0             25m
prometheus           prometheus-prometheus-kube-prometheus-prometheus-0       2/2     Running   0             24m
prometheus           prometheus-prometheus-node-exporter-h7gp6                1/1     Running   0             25m

During scaling:
$ kubectl get hpa -n metrics-test-istio
NAME                       REFERENCE                                        TARGETS           MINPODS   MAXPODS   REPLICAS   AGE
metrics-test-istio-00001   Deployment/metrics-test-istio-00001-deployment   105370m/5 (avg)   1         10        1          15m

$ kubectl get po -n metrics-test-istio
NAME                                                   READY   STATUS    RESTARTS   AGE
metrics-test-istio-00001-deployment-7d57bbb8d8-2b7ss   3/3     Running   0          69s
metrics-test-istio-00001-deployment-7d57bbb8d8-2frvl   3/3     Running   0          54s
metrics-test-istio-00001-deployment-7d57bbb8d8-7wn9b   3/3     Running   0          54s
metrics-test-istio-00001-deployment-7d57bbb8d8-86zsg   3/3     Running   0          16m
metrics-test-istio-00001-deployment-7d57bbb8d8-bpbt4   3/3     Running   0          54s
metrics-test-istio-00001-deployment-7d57bbb8d8-fz7qs   3/3     Running   0          39s
metrics-test-istio-00001-deployment-7d57bbb8d8-gx5sb   3/3     Running   0          69s
metrics-test-istio-00001-deployment-7d57bbb8d8-l4ght   3/3     Running   0          54s
metrics-test-istio-00001-deployment-7d57bbb8d8-qdp5j   3/3     Running   0          69s
metrics-test-istio-00001-deployment-7d57bbb8d8-s848s   0/3     Pending   0          39s

/kind documentation
/kind enhancement

I will open another issue for documenting Openshift ServiceMesh.


Allow passing in AWS credentials instead of only using environment variables

Is your feature request related to a problem? Please describe.
Yes, the current implementation of the library only allows for AWS credentials to be passed via environment variables or metadata endpoint. This can be limiting in scenarios where the user wants to pass credentials dynamically or when they want to use different credentials for different services.
Describe the solution you'd like
I would like the library to be updated to allow AWS credentials to be passed in as parameters to the relevant functions or methods. This would provide more flexibility and control to the user over which credentials to use.
Describe alternatives you've considered
An alternative could be to allow the user to set the credentials in a configuration file that the library can read from. However, this might not be as flexible as passing the credentials directly to the functions or methods.
Additional context
This feature would be particularly useful in multi-account AWS setups, where different services might be running under different accounts. Being able to specify the credentials at the function or method level would make it easier to manage such setups.
Here's a rough idea of what I'm suggesting:
https://github.com/googleapis/google-auth-library-nodejs/blob/6a6e49634863f61487688724d0d20632e03f0299/src/auth/awsclient.ts#L90-L108
 constructor(
    options: AwsClientOptions,
    additionalOptions?: AuthClientOptions,
    awsCredentials?: AwsSecurityCredentials,
  ) {
    super(options, additionalOptions);
    this.environmentId = options.credential_source.environment_id;
    // This is only required if the AWS region is not available in the
    // AWS_REGION or AWS_DEFAULT_REGION environment variables.
    this.regionUrl = options.credential_source.region_url;
    // This is only required if AWS security credentials are not available in
    // environment variables.
    this.securityCredentialsUrl = options.credential_source.url;
    this.regionalCredVerificationUrl =
      options.credential_source.regional_cred_verification_url;
    this.imdsV2SessionTokenUrl =
      options.credential_source.imdsv2_session_token_url;
    this.awsRequestSigner = null;
    this.region = '';
    this.credentialSourceType = 'aws';
    this.awsCredentials = awsCredentials || null;

and the retrieveSubjectToken() function
https://github.com/googleapis/google-auth-library-nodejs/blob/6a6e49634863f61487688724d0d20632e03f0299/src/auth/awsclient.ts#L164-#L169
      this.awsRequestSigner = new AwsRequestSigner(async () => {
        // Check provided credentials first
        if (this.awsCredentials) {
          return this.awsCredentials;
        }
        // Check environment variables for permanent credentials next.
        // https://docs.aws.amazon.com/general/latest/gr/aws-sec-cred-types.html
        if (this.securityCredentialsFromEnv) {
          return this.securityCredentialsFromEnv;
        }

Here's the example I wrote:
https://github.com/aliciazavala/google-auth-library-nodejs/blob/allow_aws_creds/src/auth/awsclient.ts

Resolved in v9.9.0:

https://github.com/googleapis/google-auth-library-nodejs/pull/1795


Connection callbacks

I need to respond to connection drops on the client, can you add reconnect() and close() callback handlers to ClientExt? I could make a PR if you're busy.

I'll work on that on #18
Are you sure if reconnect() is needed, if you have closed(), you can simply add something like
#[async_trait]
impl ezsockets::ClientExt for MyClient {
    // ...

    async fn closed(&mut self) -> Result<(), ezsockets::Error> {
        tokio::time::sleep(ezsockets::DEFAULT_RECONNECT_INTERVAL).await;
        // Now it should be basically at the same moment as the `reconnect()` you've suggested
        Ok(())
    }
}

And if you specifically want to handle connections, there'll be also function connected() added on the same PR.

This looks very nice, thank you!


Point domains at the correct locations

I've set up nginx as a reverse proxy for port 3001 on the apps server. I am waiting for the domain name to point to this ip address so that I can set up SSL with that domain name. I still need to set up nginx for the manifold server.

I need to remember to add the nginx config files to the project repository.

I set up SSL for apps.picolabs.io. The certificate expires november 5th this year.

This is blocked because the domain still points at the github ip address. I can't successfully create an SSL certificate because it keeps challenging the wrong ip address.

I think I found the problem. Give it some time to propagate and try again.

On Aug 8, 2018, at 3:44 PM, Connor Grimm<EMAIL_ADDRESS>wrote:
This is blocked because the domain still points at the github ip address. I can't successfully create an SSL certificate because it keeps challenging the wrong ip address.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/Picolab/Manifold/issues/118#issuecomment-411562532, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQyh39WyTImDHca4pQ3raWm-RjS8g0-ks5uO1vUgaJpZM4Vw02G.

All the domains point at the right places.


Fixed malformed JSON.

It seems that JSON was invalid for this demo, thus no asset was being created.

@miodragArsic Please review and merge request if it works correctly.

Why do you think this was wrong?  It had been working ok for more then 2 years.

There was a } missing at the end. Also single quotes are not valid JSON. It's possible our API was indeed parsing it correctly however I wouldn't rely on it.


[BUG] Some gremlin queries not generating graphs in Air-Routes-Gremlin.ipynb

Describe the bug
Several of the cells in the Air-Routes-Gremlin.ipynb do not generate results in the graph tab.
To Reproduce
Steps to reproduce the behavior:

Go to Air-Routes-Gremlin.ipynb
Scroll down to the text "The next query also produces a result that is fun to explore using the Graph tab"
Run the "my_node_labels" cell
Run the gremlin query cell
There is only a Console and Query Metadata tabs.

Expected behavior
A graph tab with interesting results.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 20.04
Browser: Chrome
Version: 97.0.4692.99

Additional context
Latest version of graph-notebook 3.1.1
Backend gremlin-server using instructions here.
Seeded with %seed in notebook.

Hi Adam!
I just tested this against Neptune as the backend and it seems to work OK. Which DB are you using in your case?

Hey!  I'm using the gremlin-server backend.  I updated the properties per the docs.  Is there an easy way to debug?  I'm not seeing any errors in the console where the notebook was started.

If appears that if the output is a simple path, e.g.:
path[YT, e[56072][3640-contains->1670], DZA]
the graph tab is available.  when the path contains objects, it doesn't.  e.g.:
path[{<T.id: 1>: '3', <T.label: 4>: 'airport', 'country': ['US'], 'code': ['AUS'], 'longest': [12250], 'city': ['Austin'], 'elev': [542], 'icao': ['KAUS'], 'lon': [Decimal('-97.66989898681640625')], 'type': ['airport'], 'region': ['US-TX'], 'runways': [2], 'lat': [Decimal('30.19449996948240055871792719699442386627197265625')], 'desc': ['Austin Bergstrom International Airport']}, 722, {<T.id: 1>: '187', <T.label: 4>: 'airport', 'country': ['US'], 'code': ['STL'], 'longest': [11019], 'city': ['St Louis'], 'elev': [618], 'icao': ['KSTL'], 'lon': [Decimal('-90.370002746582002828290569595992565155029296875')], 'type': ['airport'], 'region': ['US-MO'], 'runways': [4], 'lat': [Decimal('38.74869918823240055871792719699442386627197265625')], 'desc': ['Lambert St Louis International Airport']}, 3191, {<T.id: 1>: '217', <T.label: 4>: 'airport', 'country': ['IS'], 'code': ['KEF'], 'longest': [10056], 'city': ['Reykjavik'], 'elev': [171], 'icao': ['BIKF'], 'lon': [Decimal('-22.60560035705569958963678800500929355621337890625')], 'type': ['airport'], 'region': ['IS-2'], 'runways': [2], 'lat': [Decimal('63.98500061035159802713678800500929355621337890625')], 'desc': ['Reykjavik, Keflavik International Airport']}, 870, {<T.id: 1>: '1811', <T.label: 4>: 'airport', 'country': ['GL'], 'code': ['GOH'], 'longest': [3117], 'city': ['Nuuk'], 'elev': [283], 'icao': ['BGGH'], 'lon': [Decimal('-51.6781005858999975544065819121897220611572265625')], 'type': ['airport'], 'region': ['GL-U-A'], 'runways': [1], 'lat': [Decimal('64.1909027100000031396120903082191944122314453125')], 'desc': ['Godthaab / Nuuk Airport']}, 887, {<T.id: 1>: '3017', <T.label: 4>: 'airport', 'country': ['IS'], 'code': ['RKV'], 'longest': [5141], 'city': ['Reykjavik'], 'elev': [48], 'icao': ['BIRK'], 'lon': [Decimal('-21.940599441500001631766281207092106342315673828125')], 'type': ['airport'], 'region': ['IS-1'], 'runways': [3], 'lat': [Decimal('64.129997253400006229639984667301177978515625')], 'desc': ['Reykjavik Airport']}]

I have some more information.  It appears that if I remove lat and lon from the valueMap, all queries seem to render the graph tab.  So it appears that when something like [Decimal('44.123123123')] is in the value of a property, the graph tab does not render.  Still looking.

Thanks for the updated info. I think that is probably it.

I'm not sure how I'd change them.  They're coming like that from gremlin.  The graphml has it as double.  The query I'm running is below.  Can you typecast in valueMap?
%%gremlin -p v,oute,inv,oute,inv,oute,inv,oute,inv -g country -d $my_node_labels
g.V().
  has('code','AUS').
  repeat(outE().inV().where(without('x')).store('x')).
  times(4).
  limit(50).
  path().
    by(valueMap(true,'airport','country','code','type','desc','longest','city','elev','icao','region','runways')).
    by('dist')

Thanks for the follow up. It seems that for some reason the values are getting serialized back as Decimals even though they are created as doubles. Will dig into this more. Seems we have two actions:

Figure out why Gremlin Server is sending back Decimal types.
Add support for Decimal types to the graph-notebook code, which may also require looking at the Jupyter JSON libraries as I don't think they support Decimal today.

I ran a small test to help figure out at least what that value conversion you are seeing is using:
from decimal import *
a = Decimal(64.1299972534)
print(a)

64.129997253400006229639984667301177978515625

I setup a test environment with the latest graph-notebook and Gremlin Server 3.5.2 running locally. I loaded air routes into the graph using  g.io('air-routes.xml').read() from a Gremlin Console and then tried your queries from the notebook and everything worked fine. My local Java is still Java 8, my Python version is 3.7.6. I'll keep digging

After much experimentation we figured out the difference. I had originally used g.io() to load data into my Gremlin Server. The GraphML file explicitly states the values are doubles. When loaded via %seed the data is getting converted to java.math.BigDecimal form. Will need to do some more investigating but now the cause is understood.

I have pushed a change for csv-gremlin that we can use to re-build the air-routes %seed data. This will stop the problem that @holleyism ran into. We should also update the notebooks to handle Decimal types correctly. https://github.com/awslabs/amazon-neptune-tools/pull/201


Run SwiftFormat and SwiftLint in the generated code

Use .swiftformat and .swiftlint.yaml in the repo as the config files when running swiftFormat and swiftlint.

This will change the install directions right? Now the user would need swiftlint and swiftformat installed prior to running?

When developer use brew to install 'swiftlint', 'swiftformat', they will be installed to '/usr/local/bin/'

/azp run


BC - Email and Password Log In Page

What

Email Input
Secure Password Input
Sign In Button
Sign Up Button
Issue Ticket #12

Evidence

LGTM


Slow startup / crashes - unusable

Hello,
since the release of VS Code v0.10.1 I cannot use it anymore - yes, I already tried to reinstall it.
It takes minutes to start and all I'm getting is the following:

I am using Windows 10 Pro on my Microsoft Surface Pro 3.

Duplicate of #160

@tominon I already went through that issue, but it's not that much of a duplicate. Everyone is having issues related to php and stuff, while I just try to open up the Editor via the code.exe / desktop icon.

@Morgy93 can you run code.exe from the program files directory with the "--verbose" flag and attach the output you are seeing?

@bpasero I hope I didn't get it wrong. This is what I put into the "Target:" property of the icon, but there is no extra output on startup.

Even if I go for View -> Toggle Output there's just "Output for 'Git'" with lots of empty space.

@Morgy93 sry, I meant to say that you try from the windows command prompt.

@bpasero Alright, here we go:
### VSCode main.js ###
c:\Program Files (x86)\Microsoft VS Code\resources\app { pathArguments: [],
  programStart: 0,
  workers: -1,
  enablePerformance: false,
  verboseLogging: true,
  debugPluginHostPort: undefined,
  debugBrkPluginHost: undefined,
  logPluginHostCommunication: false,
  firstrun: false,
  openNewWindow: false,
  openInSameWindow: false,
  gotoLineMode: false,
  pluginHomePath: undefined,
  pluginDevelopmentPath: undefined,
  pluginTestsPath: undefined }
Lifecycle#unload() 1

Here it just takes forever for Code to start .. then the "crash" happens:
[VS Code]: detected unresponsive

And if I go for "Keep Waiting" or just do nothing, this gets added:
IPC#vscode-workbenchLoaded

And Code is ready for use now it seems .. after like two to three minutes of waiting.
For the easiness, full log:
C:\Users\Thomas>"C:\Program Files (x86)\Microsoft VS Code\code.exe" --verbose

C:\Users\Thomas>
### VSCode main.js ###
c:\Program Files (x86)\Microsoft VS Code\resources\app { pathArguments: [],
  programStart: 0,
  workers: -1,
  enablePerformance: false,
  verboseLogging: true,
  debugPluginHostPort: undefined,
  debugBrkPluginHost: undefined,
  logPluginHostCommunication: false,
  firstrun: false,
  openNewWindow: false,
  openInSameWindow: false,
  gotoLineMode: false,
  pluginHomePath: undefined,
  pluginDevelopmentPath: undefined,
  pluginTestsPath: undefined }
Lifecycle#unload() 1
[VS Code]: detected unresponsive
IPC#vscode-workbenchLoaded

@Morgy93 can you try starting code.exe -n (will open an empty workbench without folder) to see if it changes anything?

@bpasero Well, it still took minutes to show up while using around 30% of my CPU, but at least I didn't got the "crash" message and were able to use it right away.

@Morgy93 any extensions installed? Otherwise I am totally clueless...

@bpasero Nope, I just made the automatic update from my previous version to the v0.10.1 which immediately caused this issue. Like I said I already reinstalled it, but nothing changed. I also don't know what else to do. Anything else I could provide to resolve this issue?

@Morgy93 maybe use process explorer to analyze which process within code.exe actually causes the slowness, we start with more then one process and it would be interesting if one of them is spiking and consuming most startup time.

Also can you try running "code.exe --disable-gpu" from a command prompt from the installation folder of code to see if it makes any difference?

@bpasero Sadly --disable-gpu doesn't help.
Maybe here's something that helps? (Phew, a lot of parameters..)

I'll have a look at this process explorer thing in the meanwhile..

@Morgy93 yes please, there are processes within the one that is selected in your screen shot that could cause that one to take so long.

@bpasero I took this one: https://technet.microsoft.com/de-de/sysinternals/processexplorer.aspx
But the output is most likely the same:

"C:\Program Files (x86)\Microsoft VS Code\code.exe" --type=renderer --no-sandbox --lang=de --app-user-model-id=Microsoft.VisualStudioCode --node-integration=true --enable-pinch --device-scale-factor=1 --enable-delegated-renderer --num-raster-threads=2 --gpu-rasterization-msaa-sample-count=8 --content-image-texture-target=3553 --video-image-texture-target=3553 --channel="11656.1.1109162074\190479848" /prefetch:673131151

Don't really know what's important for you within this tool, so please be a bit more precise. :)

@Morgy93 I am using process explorer and it allows to group processes hierarchically and then I can expand the renderer process of code.exe to see spawned children within:

Can you use the same tool and then see if any of the processes within the renderer is busy or actually really the renderer?

@bpasero Actually that's just what I did, but there is no other process before the editor is fully loaded.
Have a look at the comparison:
I am starting VS Code and wait for the UI to load a bit (nothing changed till here):

Then suddenly I get the no response error message and still nothing changed:

Just after waiting for a little longer, the editor is fully loaded and two new processes spawned within the one which was consuming the cpu power.

That's pretty much everything that happens.
Maybe I provide Teamviewer access or something similar to you and you play around with it for yourself? I don't mind struggling around with it like that, but maybe that boosts the process of solving the problem. :)

Just to let you know:
I just installed version 0.9.2 from this source https://az764295.vo.msecnd.net/public/0.9.2/VSCodeSetup.exe over my existing installation and VS Code started up fast again.
Now I installed the latest release from the official website over the 0.9.2 installation and .. see.. it's slow again.
So I assume that there are code changes between 0.9.2 and 0.10.1 which cause this issue.

@Morgy93 good insights, thanks. Especially good to know that 0.9.2 loads fast for you. There are two things that changed for the 0.10.x release: Lots of code changes on our end but also an update to the cross platform framework (Electron).
First of all we need to understand if this is caused by code changes or by Electron. The easiest to start with is to set you up to run Code from its sources so that we can tweak changes and rapidly see if it helps.
Can you follow https://github.com/Microsoft/vscode/wiki/How-to-Contribute#build-and-run-from-source and when you launch code see if you see the same issue of slow startup?

@Morgy93 another thought I had was if - once VS Code is up and running - you could see if reloading the application is also slow. For that you can just trigger View | Command Palette | Reload Window.
If that action turns out to be as slow, we have a chance to run a profiler to see where the time is spent. For that - before reloading - run Help | Toggle Developer Tools, click Profiles, then press the Start button and run the reload action. After that, press the Stop button. You should get a list of function calls and their timings. You can export this report from the little "Save" button next to "Profile 1" on the left.

By the way I just updated to version 0.10.2 but the issue remains. But from now on I will most likely rely on that version, if no other instructions are given.
@bpasero I'll try the build and run from source at the weekend. (If needed)
The Reload Window option is also slow, cpu consuming and causes the "does not respond" error message.
Here's the Profile dump:
CPU-20151126T100506.txt (Original filetype was .cpuprofile)
[code.txt] (https://github.com/Microsoft/vscode/files/44784/code.txt)(Original filetype was .dmp)
And some picture:

@Morgy93 thanks a lot for the profile, this helped identify the issue and in fact many more users are hit. This likely qualifies for an update that we will push out to all users but we need some verification first. So I have a couple of asks for you:
1.) can you download the following build of VS Code (standalone zip, no installer) and open Code.exe to see if performance is better. I uploaded the zip to my onedrive: http://1drv.ms/1NQvCOu
2.) if performance is better: close the instance and open \resources\app\out\vs\workbench\electron-browser\index.html in that zip and make the following console.log additions after this line:
process.env['VSCODE_SHARED_IPC_HOOK'] = configuration.sharedIPCHandle;

console.log('URL length: ' + window.document.URL.length);
console.log(JSON.stringify(configuration, null, '\t'));

Then save the file and run Code again from the zip and hit Help | Toggle Developer Tools. You should then see potentially lots of output from the log statements. I would need the entire log, since it may contain user data it should probably be not attached to this issue but you can send it via mail (benjpas@microsoft.com).

@bpasero Performance is good again - log sent via mail.

To people hitting this issue: We might not be able to release a new version until next week. But there is a workaround:
If you can start Code eventually:

select File | Open Recent | Clear Items
restart and things should be fast again

If you cannot start Code:

close Code
locate storage.json (see https://code.visualstudio.com/Docs/supporting/FAQ#_how-do-i-opt-out-of-vs-code-autoupdates for how to find it)
delete the file or rename it
start Code

Sorry for the trouble :heart:

Hi, I can still reproduce the issue in version 0.10.3.
When I open a JSON file which size is about 4M, the VS code stops responding. It used to be OK before 0.10.1.

@slayerxj that seems like a different issue that should get filed, please do that!

@bpasero Sorry, I thought they were same because the first time I met this issue, that JSON file was supposed to be shown at startup. So I did experience slow startup / crashes :) And now after reading the discussions I realized they're different.


171668 [High][Newsroom] - Industry Topic pages [BR, ES, SG, JP, PT, DE] - No news cards displayed

Priority - 2 High
Description of the issue: No news cards displayed
Steps to Reproduce:
Open the url(s):
Adobe Franklin migrated page:
BR - https://main--accenture-newsroom-br--hlxsites.hlx.live/br/industries/retail
ES - https://main--accenture-newsroom-es--hlxsites.hlx.live/es/industries/retail
SG: https://main--accenture-newsroom-sg--hlxsites.hlx.live/asia-pacific/industries/news
JP: https://main--accenture-newsroom-jp--hlxsites.hlx.live/jp/industries/talent-organization-performance
PT: https://main--accenture-newsroom-pt--hlxsites.hlx.live/pt/industries/talent-organization-performance
Legacy newsroom page:
BR: https://newsroom.accenturebr.com/br/industries/retail/
ES: https://newsroom.accenture.es/es/industries/retail/
SG: https://newsroom.accenture.sg/asia-pacific/news/
JP: https://newsroom.accenture.jp/jp/industries/talent-organization-performance
PT: https://newsroom.accenture.pt/pt/industries/talent-organization-performance
Expected Result:

Actual Result:

Adobe Franklin migrated page:
DE: https://tempnewsroom.accenture.de/de/industries/banken
Legacy newsroom page:
DE: https://newsroom.accenture.de/de/industries/banken#
Expected Result:

Actual Result:

Please test this again. the links look fine to me
Example from BR:

@zozo-j
The following are empty as there're no matching news for these categories
https://newsroom.accenture.jp/jp/industries/talent-organization-performance
https://newsroom.accenture.pt/pt/industries/talent-organization-performance
https://main--accenture-newsroom-de--hlxsites.hlx.live/de/industries/banken isn't showing the results as https://main--accenture-newsroom-de--hlxsites.hlx.live/query-index.json?offset=0&limit=255&sheet=articles is still showing cached json. I've reached out internally to flush this out, this may take some time.
Except the above every other url is showing the news cards.
created https://github.com/hlxsites/accenture-newsroom/issues/328 for /news/ articles

cache for https://main--accenture-newsroom-de--hlxsites.hlx.live/query-index.json?offset=0&limit=255&sheet=articles is cleared, now https://main--accenture-newsroom-de--hlxsites.hlx.live/de/industries/banken is working fine.
cc: @zozo-j

Please note that https://tempnewsroom.accenture.de/de/industries/banken is still not working as https://tempnewsroom.accenture.de/query-index.json?offset=0&limit=255&sheet=articles is cached in your CDN level.
But this is working fine in https://main--accenture-newsroom-de--hlxsites.hlx.live/de/industries/banken as https://main--accenture-newsroom-de--hlxsites.hlx.live/query-index.json?offset=0&limit=255&sheet=articles is working fine.


Proposals/RFCs: Communicate and collaborate on broad design changes

Currently, there is no forum for proposing large scale Qiskit changes to our developers and community members. Github issues are better suited to smaller changes and do not easily serve as a wide-reaching, persistent and amendable document. Consider this recent Terra issue which is providing an overview of the proposed Pulse API. It was necessary to create this as a Github issue to expose it to the community. This is not the proper medium since it is difficult to track changes to the document and have community members review specific sections.
Other opensource projects have created different solutions for the above problem and have created a proposal document repositories with clear submission and acceptance guidelines:

Python: PEPs
Tensorflow:  TF-RFCs

+1, great idea

@lerongil is this something you'd like to take up?

@nonhermitian can you think about this or close it if we dont have the time to make this possible. I think it is a good idea just we are too small to do it now.

This is now closed with the creation of the RFC repository


[WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2

What changes were proposed in this pull request?
In hadoop 3.2, orc.classfier is empty.
https://github.com/apache/spark/blob/d841b33ba3a9b0504597dbccd4b0d11fa810abf3/pom.xml#L2924
here is incorrect.
https://github.com/apache/spark/blob/101839054276bfd52fdc29a98ffbf8e5c0383426/dev/deps/spark-deps-hadoop-3.2#L181-L182
Why are the changes needed?
Update dev/deps/spark-hadoop-3.2
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @wangyum

Thank you @dongjoon-hyun for ping me. @AngersZhuuuu We need to fix dev/test-dependencies.sh. The manifest generated by ./dev/test-dependencies.sh --replace-manifest.

Thank you @dongjoon-hyun for ping me. @AngersZhuuuu We need to fix dev/test-dependencies.sh. The manifest generated by ./dev/test-dependencies.sh --replace-manifest.

Checking this, will remove WIP after fix this problem.

In sql/core module, in pom have this, and this module's build-classpath isright.
    <dependency>
      <groupId>org.apache.orc</groupId>
      <artifactId>orc-core</artifactId>
      <classifier>${orc.classifier}</classifier>
    </dependency>
    <dependency>
      <groupId>org.apache.orc</groupId>
      <artifactId>orc-mapreduce</artifactId>
      <classifier>${orc.classifier}</classifier>
    </dependency>

Get  dependency:build-classpath of parent pom, it will get correct orc jar path(not nohive)  for all module.
If we get dependency:build-classpath for sub-module，  it will get wrong  orc jar path(nohive).
But profile hadoop-3.2 truly work, for zookeeper jar in hadoop-2.7 version is 3.4.6, in hadoop-3.2 version is 3.4.13, it truly works when we get dependency:build-classpath of assembly with profile hadoop-3.2.
cc @wangyum @srowen @dongjoon-hyun
So I change dev/test-dependencies.sh to use -am with -pl assembly to get build result.
See the change in dep/deps/spark-deps-hadoop-3.2
I have check all change, seem all reasonable.

Does this -am change affect the output of the Hadoop 2.7 deps?
I agree it sounds like this is a better way to identify what JARs are in the published binary release, as that is what the licenses must reflect. Is it possible to build the Hadoop 3.2 release and spot check whether the changes are correct -- removed deps really don't end up in the jars/ folder, and new deps do?
If there are real changes to 3.2 or 2.7 deps, we need to also reevaluate what is in our LICENSE-binary / license-binary/ files to ensure we have the right statements.

Does this -am change affect the output of the Hadoop 2.7 deps?

Won't change hadoop-2.7.

Is it possible to build the Hadoop 3.2 release and spot check whether the changes are correct.

Checked project deps in IntelliJIDEAL, it truly removed and new dep added. I will build  a hadoop-3.2 release to double check.

If there are real changes to 3.2 or 2.7 deps, we need to also reevaluate what is in our LICENSE-binary / license-binary/ files to ensure we have the right statements.

Have considered about this. Since -am won't change spark-deps-hadoop-2.7 's output. So we just need to check changes about new added in spark-deps-hadoop-3.2`

@srowen
There are some hive jars added with hive group
hive-beeline-2.3.6.jar
hive-cli-2.3.6.jar
hive-common-2.3.6.jar
hive-exec-2.3.6-core.jar
hive-jdbc-2.3.6.jar
hive-llap-common-2.3.6.jar
hive-metastore-2.3.6.jar
hive-serde-2.3.6.jar
hive-service-rpc-2.3.6.jar
hive-shims-0.23-2.3.6.jar
hive-shims-2.3.6.jar
hive-shims-common-2.3.6.jar
hive-shims-scheduler-2.3.6.jar
hive-storage-api-2.6.0.jar
hive-vector-code-gen-2.3.6.jar

since origin LICENSE-binary add  org.spark-project.hive group hive jars.
In hadoop-3.2, we add jars in org.apache.hive group, I think we should update this too, what do you think?

Is it possible to build the Hadoop 3.2 release and spot check whether the changes are correct -- removed deps really don't end up in the jars/ folder, and new deps do?

@srowen  Build a hADOOP 3.2 release and checked it. Removed deps don't show in jars/ folder and new deps in the folder.

It seems that we need to change branch-2.4, too.

Yes to branch-2.4 too. I'd do that separately as I expect (hope?) there is little additional change compared to what the new Hadoop 3.2 profile might have presented here.

ok to test

And, @AngersZhuuuu . Please update the PR description.

Test build #111843 has started for PR 25984 at commit 79d8bf6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16823/
Test PASSed.

Test build #111843 has finished for PR 25984 at commit 79d8bf6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111843/
Test PASSed.

New dependencies like org.apache.hive:hive-beeline etc need to be listed in LICENSE-binary

Have done this and checked other changes.

This is a little annoying, but I'd check the new Hive dependencies for a NOTICE file in each and add them to NOTICE-binary where they don't already exist, along with the existing Hive NOTICE entries.

I will check this today

I think we need to add a line for velocity in LICENSE-binary? It's already in NOTICE-binary, so not sure what happened to the former entry

Not very clear what you mean.

Test build #111861 has started for PR 25984 at commit c3b0069.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16841/
Test PASSed.

Test build #111861 has finished for PR 25984 at commit c3b0069.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111861/
Test PASSed.

Test build #111874 has started for PR 25984 at commit 143afd3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16855/
Test PASSed.

Test build #111875 has started for PR 25984 at commit cc36db9.

Test build #111874 has finished for PR 25984 at commit 143afd3.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #111875 has finished for PR 25984 at commit cc36db9.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111875/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111874/
Test FAILed.

retest this please

Test build #111884 has started for PR 25984 at commit cc36db9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16865/
Test PASSed.

Test build #111884 has finished for PR 25984 at commit cc36db9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111884/
Test PASSed.

Re: Velocity, I mean that it appears to be a dependency, but is not listed in LICENSE-binary. It needs an entry in there somewhere.
Re: Hive, it is looking good now. What's that question about org.apache.hive?

Re: Velocity, I mean that it appears to be a dependency, but is not listed in LICENSE-binary. It needs an entry in there somewhere.
Re: Hive, it is looking good now. What's that question about org.apache.hive?

For Velocity, it has been in LICENSE-binary,  https://github.com/apache/spark/blob/de360e96d776f51c0fd7c31dcec142feabf3d543/LICENSE-binary#L411
For hive , I think it's ok, seems no more need to supplement.

Oh OK good I missed that. I think this looks pretty OK. Are there any more changes you want to make?

Oh OK good I missed that. I think this looks pretty OK. Are there any more changes you want to make?

Need to check if any hadoop 3.2 deps jars have been added to LICENSE-binary.
I'm not sure if the previous changes will leave such problems since previous spark-deps-hadoop-3.2 is not correct. I will check this.

@srowen  I have updated some LICENSE-binary, some jar I can't find's notice.
If you knew could you provide some solution?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16875/
Test PASSed.

Test build #111899 has started for PR 25984 at commit 240a411.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16877/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16886/
Test PASSed.

Test build #111908 has started for PR 25984 at commit f7bd663.

Test build #111899 has finished for PR 25984 at commit 240a411.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111899/
Test PASSed.

Test build #111908 has finished for PR 25984 at commit f7bd663.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111908/
Test FAILed.

@dongjoon-hyun
test failed but seems not my error. Could you help to trigger again?

retest this please

Test build #111928 has started for PR 25984 at commit f7bd663.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16908/
Test PASSed.

Unfortunately, Jenkins is down. Let's wait until Jenkins is back.

Unfortunately, Jenkins is down. Let's wait until Jenkins is back.

Unfortunately, Jenkins is down. Let's wait until Jenkins is back.

Bad news, wait for Jenkins back.

retest this please

Test build #111943 has started for PR 25984 at commit f7bd663.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16959/
Test PASSed.

Test build #111943 has finished for PR 25984 at commit f7bd663.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111943/
Test FAILed.

Test build #4895 has started for PR 25984 at commit f7bd663.

Test build #4895 has finished for PR 25984 at commit f7bd663.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #111989 has started for PR 25984 at commit e56a8c6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17004/
Test PASSed.

Test build #111989 has finished for PR 25984 at commit e56a8c6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111989/
Test PASSed.

Merged to master


close all connections when shutting down the kernel

currently, users have to manually close connectios via --close. But in most cases, it'd be better to close them automatically. for example, when they restart the kernel or they shut down jupyterlab
we can use the atexit module to do that: https://docs.python.org/3/library/atexit.html and close all connections right before the kernel shuts down.

AC:

Add new method close_all_connections(cls) inside class Connection to close all connections
Use atexit.register(Connection.close_all_connections) after Connection class definition. This is called automatically when the program exits, ensuring that all connections are closed before the kernel shuts down.


Autocomplete stop working with accents

VSCode Version: 1.25.1
OS Version: macOS High Sierra 10.13.6

Steps to Reproduce:

In a js / jsx file, write some method with accent
const teste = {  testéste: 1 }
Try autocomplete this
teste.test
Accents stop the autocomplete

Starting autcomplete

After accent

Does this issue occur when all extensions are disabled?: Yes

@jrieken This is related to filtering the suggestions.

@rodrigojcmello How do you enter the é?

@jrieken ' + e (our macbook keyboard in Brazil is equal US keyboard)

Ok, thanks. It's like pressing Alt+e and then e on the US mac keyboard. This happens because the suggestions are filtered again test´ already. We should wait for the composition to be completed first.

@jrieken The issue has been resolved, but because of some more recent update the problem has returned.

@rodrigojcmello I don't see the issue in either the latest stable (1.27.2) or the latest insiders. What version are you using?

@ramya-rao-a I am on 1.27.2, I deactivated all extensions and the problem persisted, I uninstalled, rebooted the MacBook and reinstalled without any extension and the problem persisted. I tested Windows 10 also build 1.27.2 and there autocompletion works normally. The problem is apparently to wait for the accent on OSX. I remember testing it as soon as the build came out with this fix (1.27.1?) And everything was fine, but by upgrading to the latest build I realized that the problem had returned.

The problem is apparently to wait for the accent on OSX.

Can you elaborate on this?
Also, you can get the older 1.26.1 version from https://code.visualstudio.com/updates/v1_26. Can you try that to confirm that the problem was indeed fixed in 1.26.1 for you?


[BUG] Domain admin: Identify and access > Roles should not be visible

Describe the bug
'Identify and access > Roles' screen is visible but the domain admin has no access there so it doesn't make sense.
To Reproduce
Steps to reproduce the behavior:

Log in as domain admin, go to 'Identify and access > Roles'

Expected behavior
'Identify and access > Roles' should not be visible when logged as domain admin.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 18.04 LTS
Browser: Chrome
Version: 80.0.3987.132 (Official Build) (64-bit)

Additional context
None.

cc @shwstppr we probably need a show method for the tab that can check if API is available for the user to see the rules tab api in store.getters.apis...

@vladimirpetrov cc @borisstoyanov please test latest master and close.

Fix confirmed, closing the issue.


Switch to using NimbleParsec for parsing protocol messages

Parsing isn't a humongous bottleneck right now, but it definitely had some room for improvement. After reading recently about nimble_parsec I thought it might be a good option for efficiently parsing protocol messages.
I wanted to record some better benchmarks before making the upgrade so I went ahead and pulled in the client/server scripts from recent benchmarking attempts and split out the benchmarks into separate files where we test 16 byte, 128 byte and 1024 byte message sizes.
Here are some of the metrics I found from before/after the change to nimble parsec:

Metric
Parser
Parsec

Parse 16 byte ips
89.35k
365.37k

Parse 128 byte ips
88.70k
345.51k

Parse 1024 byte ips
89.11k
327.81k

req/sec 16 byte
11.1k
13.1k

median req latency
43.8ms
36.6ms

the throughput metrics were based on running the server.exs and client.exs on the same 2-core machine with 4 connections and 512 parallel requests

One interesting thing I noticed while working on this was that the nats protocol documentation says that subject names should be

non-empty alphanumeric strings with no embedded whitespace, and optionally token-delimited using the dot character

We currently generate an inbox subjects like _INBOX.nuid().nuid(). The _ is not alphanumeric and the base64 encoded data might include +, / or = characters as well. It looks like the gnatsd server handles all of these just fine, so I relaxed the constraint on the new parsing to include pretty much all printable ascii characters other than whitespace and control codes.
Should we avoid non alphanumeric characters in our subject names?


NodePort as Proxy

Hello there.
I'm trying to use your graph as View for my own graph data structure.
And i'm stuck on NodePort API usage.
For the reason that i have my own memory Object, i need option specify Owner and FieldInfo as External source of NodePort
public NodePort(BaseNode owner, string fieldName, PortData portData)
		{
			this.fieldName = fieldName;
			this.owner = owner;
			this.portData = portData;

			fieldInfo = owner.GetType().GetField(fieldName, BindingFlags.Public |                                                      BindingFlags.NonPublic | BindingFlags.Instance);

If it possible  Port Source data should be wrap as your PortData for use it like abstraction

Hey,
Would add a new constructor that takes directly a FieldInfo in parameter help in your case ? If it works for you I can add it to the API.
Also I don't know if it's relevant in your case but you could also emulate your nodes through mine using the custom port API: https://github.com/alelievr/NodeGraphProcessor/blob/master/Assets/Examples/DefaultNodes/Nodes/CustomPortDataNode.cs#L37. It allows you to generate any number of ports different name / types from a single property.
That being said if you only want to visualize your graph data structure and not interact with it (no manipulation like edge connection, creating new nodes, etc.) it may be easier to do with the Unity GraphView API since it only handles the visualization part: https://docs.unity3d.com/ScriptReference/Experimental.GraphView.GraphView.html

Hello
You are correct. It would be nice if you add API
like that into NodePort:
/// <summary>
		/// Constructor
		/// </summary>
		/// <param name="owner">owner node</param>
		/// <param name="fieldName">the C# property name</param>
		/// <param name="portData">Data of the port</param>
		public NodePort(BaseNode owner, string fieldName, PortData portData) :
			this(owner, owner, fieldName, portData)
		{

		}

		/// <summary>
		/// Constructor
		/// </summary>
		/// <param name="owner">owner node</param>
		/// <param name="fieldOwner"></param>
		/// <param name="fieldName">the C# property name</param>
		/// <param name="portData">Data of the port</param>
		public NodePort(BaseNode owner,object fieldOwner, string fieldName, PortData portData)
		{
			this.fieldName = fieldName;
			this.owner     = owner;
			this.portData  = portData;
			this.valueOwner = fieldOwner;

			fieldInfo = valueOwner.GetType().GetField(
				fieldName,
				BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance);
			customPortIOMethod = CustomPortIO.GetCustomPortMethod(owner.GetType(), fieldName);
		}

And i notice your are use direct FieldInfo.Get/Set Value call. I think it would be nice to move it into separate method of port api to future extend-ability and SRP(hope that's helpful)
About my usage of your tools. Right now i use self-refactored version of XNode graph for Unity for implement Full Reactive Graph system.
https://github.com/UniGameTeam/UniGame.GameFlow
And so I need support base operations like: create, remove, connect etc. But your version fully based on Scriptable Object as a Data container.
If you can add separate inheritance hierarchy tree for support MonoBehaviour/Prefabs Data Container for scene asset reference, then i can use your tool directly without Adapter between two systems
Thx for advice about multiport support.

Hey, sorry for the delay. I added a new constructor in the NodePort class based on what you posted: 931fb7ec920668745b844d9352d5b98e36bd68f0.
I also patched the calls to Get/SetValue with the good field owner so tell me if it works for you :)

Thank you. That's very helpful for me


Disallow declaring reserved @@variable names

Description
Now that variables named @@myvar are supported (see PR #3073), we should also address the issue of being able to declare a user-defined variable with the same name as a predefined global @@ variable, for example @@SPID.
Babelfish has always allowed such declarations even though referencing the declared variable would actually reference the predefined global @@variable, thus producing a wrong result. For example:
1> declare @@spid int = 123
2> select @@spid
3> go
spid
-----------
      20902     <===== WRONG!

This fix does not allow predefined @@ global variables to be used as user-defined variables or parameters, and will raise a syntax error as expected in T-SQL.
A special case is the @@PGERROR variable which was introduced by Babelfish: when declaring a variable with this name, the error message will additionally point out that @@PGERROR is a reserved name in Babelfish.
Signed-off-by: Rob Verschoor<EMAIL_ADDRESS>Issues Resolved
BABEL-5388: Disallow declaring reserved @@variable names
Test Scenarios Covered

Use case based - Yes

Boundary conditions - Yes

Arbitrary inputs - N/A

Negative test cases - Yes

Minor version upgrade tests - Yes

Major version upgrade tests - N/A

Performance tests - N/A

Tooling impact - N/A

Client tests - N/A

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

20 of 20 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 74.815%

Totals

Change from base Build<PHONE_NUMBER>2:
0.008%

Covered Lines:
46466

Relevant Lines:
62108

💛  - Coveralls


htmx based gui

nice system architecture with Cue and NATS. Kind of perfect light system
htmx or htmz based GUI would be nice. If you have a Issue / Epic for it I can take a shot at it.
htmz is an iframe hack: https://github.com/Kalabasa/htmz

@gedw99 thanks for your interest! By "GUI" do you you mean web UI or terminal UI?
We are using HTMX already for the web UI.
https://github.com/verifa/horizon/blob/ed4e3a49b64e533b4cf9bd26e6d7298ed6633988/pkg/gateway/server.go#L32
And we've built an http proxy over nats, so the different extensions will serve their own HTML to be rendered in the gateway. In Go, this is done by creating our ownhttp.RoundTripper that allows sending http messages over nats quite nicely:
https://github.com/verifa/horizon/blob/ed4e3a49b64e533b4cf9bd26e6d7298ed6633988/pkg/gateway/portal.go#L69
Some help is definitely appreciated with the UI. What are your main interests that you would like to help with?

Hey
Thanks for the links @jlarfors
I have an idea which maybe is worth considering.  Lets call it HTMX Chrome.
I use HTMX a lot, and one thing that Horizon is capable of doing ( based on its architecture ) is to add hinting to the Web GUI in the browser.
When your in Dev mode, we could add "hints" into the current html output via our Proxy layer, so devs can more easily understand what is happening with the HTMX meta tags in the HTML. Thats the generalised idea.
There are various opportunities here once that basic stuff is in place:
The link could open up the code in vscode etc of where the HTML came from.  It could however also do a lot more thanks to NATS being integrated into the system. All we are doing is adding a little bit of extra HTML to the GUI to show the code files where the HTML came from.
We could later use the HTMX meta tags to help hint about the linkage of a HTMX swap ( and other OPs that HTMX does ), etc. HTMX is sort of cool how your just replacing html at runtime, but it can get a little complex on large projects where you loose track of what is modifying what and what depends on what.
We could even load the main web site in an Iframe and show the HTMX aspects in a left pane to allow editing the actual code tags to reroute a HTMX. This is just one idea of where it could go.
When in Prod Mode, we dont show the HTMX Chrome.
I totally get this is "a bit different", but when I saw the way HTMX and NATS is integrated I just seems natural.    I also realise that Horizon is a new project and it's still got a long way to go, so think of this as a base for an idea. Even just the Providence aspect could be done if we have the basic concept of DEV / PROD distinction. Then later as we use it some of the other ideas like editing the HTMX routing could be worth playing with.

@gedw99 thanks for the suggestion and interesting idea.
I think your idea is out of scope for what Horizon is trying to be. Horizon is aimed at "platform teams" (as defined in Team Topologies), or any kind of similar team (some call it DevOps Teams, DevEx Teams, whatever). So it is a portal for developers to use to enable their work, not a development tool, per se.
The main use for HTMX right now is how parts of the HTML page are stitched together, with something like this:

The HTTP service receiving this converts the http.Request to []byte and sends it over NATS to another service that converts it back to an http.Request and has it's own HTTP server to handle it. The response is then sent back over NATS and finally into the UI.
This kind of technique could absolutely be applied to what you are suggesting and feel free to get inspiration from this code base.

I am going to close this issue. There are now some better examples, e.g. https://github.com/verifa/horizon/blob/75e57350d17bb8f52ac20f1e6241b15f0443a476/examples/greetings/portal.templ#L36

thanks @jlarfors for all th direction and the greetings example. It really helps to have examples.


Refactor config to be more accessible and expandable

should make Config and possibly other functions accessible globally without  importing individual modules. This will make adding new config options for influx2 easier.

feature branch feature-influx2 has these changes completed.

Merged changes to wip branch with #18


portforward does not work when pod is using host network

In our environment, we start tiller server with host network. We then connect to tiller with portforward using helm list. And an error returns
E0417 05:02:29.988555   22051 portforward.go:331] an error occurred forwarding 34086 -> 44134: error forwarding port 44134 to pod 6b79d2ed658ad32c0719b807e83f3fce882fc7271a28047ca3e21a6cc65b6e30, uid : network namespace for sandbox "6b79d2ed658ad32c0719b807e83f3fce882fc7271a28047ca3e21a6cc65b6e30" is closed

I think the check here https://github.com/containerd/cri/blob/master/pkg/server/sandbox_portforward.go#L57 fails. If a pod uses host network, I guess the network namespace will not be created?

@qiujian16 Good catch!


range-base for loop can't contain another execute operation.

when i use range-base for loop and sub, the assert happend. this is the pseudocode：
auto& res = cnx.execute("select * from xxx");
for(auto& row : res)
{
......
auto res1 = cnx.execute("select * from yyy"); //assert error
}
you konw this situation is very common, hope you resolve the problem, thanks.

This is a limitation of the underlying PostgreSQL library libpq - C Library. You cannot run two SQL commands in parallel in the same connection. You must collect the ALL result of a command before being able to reuse the connection, or you to use two connections.

Actually I reopen this one. This is not a limitation of the underlying PostgreSQL library. It can be supported if using the single row mode which is used by default in the current implementation of libpqmxx. This mode allows to handle large results set and that's why I've initially chosen it. But I realize this is not convenient and I should support both modes and not make the single row mode the default.

That' rigth, expect the solution.

have you resolved the problem?


Improve speed of writing large molecules to GROMACS

Description
Checklist

[ ] Add tests
[ ] Lint
[ ] Update docstrings

I've worked around a double-nested loop, which cuts down on quite a bit of the execution time:

This is the code I'm using, trying to keep it limited to well-worn PDB files containing only one protein:
import pathlib

from openmm.app import ForceField, PDBFile, PME
import time
from openff.interchange import Interchange

with open("times.csv", "w") as f:
    f.write("atoms,import_time,export_time\n")

for path in pathlib.Path(".").rglob("../protein-ligand-benchmark/**/*.pdb"):
    try:
        protein = PDBFile(path.as_posix())
    except:
        continue

    if protein.topology.getNumAtoms() < 0:
        continue
    if protein.topology.getNumAtoms() > 2_000_000:
        continue

    try:
        system = ForceField("amber14-all.xml").createSystem(
            protein.topology,
            nonbondedMethod=PME,
        )
    except ValueError:
        continue

    time0 = time.time()

    interchange = Interchange.from_openmm(system=system, topology=protein.topology)

    import_time = time.time() - time0

    print(f"{import_time=}")

    # Lazy shim for https://github.com/openforcefield/openff-interchange/issues/1007
    # some of PLB has residue indices that start at -3!
    for atom in interchange.topology.atoms:
        atom.metadata['residue_number'] = 1

    time1 = time.time()

    interchange.to_top("tmp.top")

    export_time = time.time() - time1

    print(f"{export_time=}")

    with open("times.csv", "a") as f:
        f.write(f"{protein.topology.getNumAtoms()},{round(import_time, 3)},{round(export_time, 3)}\n")

Most of the time is spent in this loop, which I should be able to work around as well:
https://github.com/openforcefield/openff-interchange/blob/095ecf5c993ea2b277b72d38338312891b729a0c/openff/interchange/smirnoff/_gromacs.py#L290-L294

Here's the same plot after c24a2097736ede5d76059bc4cc2b8095c9370993:

And the data it's from

atoms
import_time
export_time
export_time/1000atoms
import_time
export_time_pr1018
export_time_1018/1000atoms

10456
10.917
321.86
30.78232594
9.91
51.871
4.960883703

2448
2.706
12.963
5.295343137
2.294
4.193
1.712826797

3579
3.568
29.323
8.19307069
3.47
5.413
1.512433641

There are some more gains that could be had, but profiling indicates there isn't a single, major bottleneck anymore:

The _convert_angles and _convert_bonds could be checked for double loops and rewritten.
Also, just gathering the residue names from a topology is roughly a quarter of the execution time, here: https://github.com/openforcefield/openff-interchange/blob/095ecf5c993ea2b277b72d38338312891b729a0c/openff/interchange/smirnoff/_gromacs.py#L204-L207

Looking much better now


Dutch translations are outdated

Steps to reproduce
Start Vim with language set to Dutch.
Observe that many messages are in English
Expected behaviour
Most messages are translated to dutch
Version of Vim
8.2
Environment
Dutch
Logs and stack traces
No response

@donnut


How to Upgrade etcd.

If I want to upgrade from 3.0.15 to 3.0.16, Can I just use rolling update strategy? or just shutdown whole cluster and then upgrade? also in the future maybe I want to upgrade from 3.1 to 3.2. Is it possible to upgrade with  zero-downtime?

See https://github.com/coreos/etcd/tree/master/Documentation#upgrading-and-compatibility.
Basically you can do rolling upgrade one node by one node.


Not able to make this working: callback never called after itentity provided successful login

I'm struggling trying to make a connection from Remix to a Keycloak server.
This package seems to move in the right direction, but I'm probably missing something obvious not mentioned in the README.
The browser is properly redirected to the Keycloak login, but after the authentication nothing happend.
I end up in the configured page with all of the keycloak status information (like …/logged-in?state=48c6c96b-f749-42b0-xxxxx&session_state=81b2d7c9-636e-xxxxx) but I'm not authenticated.
What I noticed: the callback described in the readme is never called:
https://github.com/neverstew/remix-auth-oidc/blob/29ed9c7691b36fcc6a2f5027757776f7e4b32694/README.md?plain=1#L56
Any tips on how to debug this behaviuor?

@keul did you ever end up getting this working? I'm running into the same issue.

@JWTappert I spent a lot of time on this, tried multiple approaches and add-on based on remi-auth-oidc, nothing worked.
After asking for help on the Discord channel, I migrated to a totally different approach (express + openid-client + remix context) and, as it works like a charm, I never looked back.


Sunil

Checklist

[ ] I'm reporting a broken site support
[ ] I've verified that I'm running youtube-dl version 2020.01.24
[x] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar issues including closed ones

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE

Fantastic

Not


fixed #11 Project section

I added the project section inside the html file. Stylesheet was moved to a folder named css/ and I also added an Img/ folder to store all the images that we can use for the project. Feel free to let know if there should be any more changes. I couldn't find the images for this section of the project so I added empty image files for now.

Please pull the latest changes and make a PR to develop branch and not the master branch. Closing this PR. Please submit a new PR with the changes mentioned. Thanks.


draft: dev-tools: drop neofetch in favour of fastfetch

Neofetch is officially not supported anymore[0], and fastfetch is.
Furthermore, fastfetch has upstream support for Torizon OS [1] and it goes vrooom vrooom super fast.
Here's how it looks

[0] https://github.com/dylanaraps/neofetch
[1] https://github.com/fastfetch-cli/fastfetch/blob/dev/src/logo/ascii/torizoncore.txt

@LinusDierheimer I'm not sure if you're familiar with Yocto, but it's a build system for embedded Linux distros. I proposed to use it here for our binary distro (we used neofetch before), but the "recipe", ie, what actually lets users use fastfetch with Yocto is general enough that everyone using this build system can use it. Let me know if it's interesting for you to have this officially somewhere and I can maintain it.

Drafted because some 3rd-party dependencies will have to be removed to be compliant with MIT. See https://github.com/fastfetch-cli/fastfetch/issues/533#issuecomment-2097050743.

@hiagofranco did package fastfetch for Debian and you guys can take a look at the "makefile" in https://salsa.debian.org/debian/fastfetch/-/blob/debian/latest/debian/rules?ref_type=heads
He also did have to remove some third party embedded libs, but I think we'll want to keep libyyjson

Closed by https://github.com/torizon/meta-toradex-torizon/commit/95eee8f475606c1d5e774ae23c7092dc8ea66cbb


Use LANG=C in example

Incomplete fix: I don't know where to add the environment for the JSch example, and I haven't checked the code in the examples/ directory.

Coverage remained the same at 92.138% when pulling 89410044fbd73281476d99b8bcd815986c415237 on toolforger:patch-1 into 5acbe1f8f895fe1dbd63e29bf3ab8e5bbf0873c3 on Alexey1Gavrilov:master.

Test failure is unrelated to the change.

Can you please elaborate why LANG=C is needed in the example code?

LANG=C eliminates internationalization.
E.g. on my machine, ls does not respond with total XXX but with insgesamt XXX, making the script fail.


Provide an API to set generic Pull-Request sidebar content

Feature Description
It'd be nice if we could offer a API where third-party integrations like code coverage could create sidebar content into a PR, like for example coverage.
I could see it accepting something like
{
  "title": "CodeCov Coverage",
  "value": "55.32% (+0.15%)"
  "link": "https://codecov.example.com/pr-1234",
  "details": "more verbose markdown content..."
}

details and maybe value could accept Markdown. details content could be used to display a popup on mouseover that shows detailed content.
Related:
https://app.codecov.io/gh/feedback/p/support-gitea-scm
https://github.com/go-gitea/gitea/issues/23746#issuecomment-1487308032

For this example use case about reporting test coverage of a PR, isn't commit status suited for that?
https://try.gitea.io/api/swagger#/repository/repoCreateStatus

It could be generalized as "PR Metadata" and "PR file metadata" on the API. Thought I guess if we want to integrate deeply and show progress bars and such, there is no way around specifically supporting the Coverage use case with specific APIs.

It could be generalized as "PR Metadata" and "PR file metadata" on the API. Thought I guess if we want to integrate deeply and show progress bars and such, there is no way around specifically supporting the coverage use case with specific APIs tailored to it.

 Because you don't know which model users will use with Gitea.

look the action also need it, ref:  https://github.com/go-gitea/gitea/issues/23722 https://github.com/go-gitea/gitea/issues/23721

I think the checks run feature in github is a good solution for this issue, looks it's Upgraded commit status. the difference betwen check run and commit status :

in my view, looks  check run = commit status + code review
some tips about do it:

github api document: https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28
wonder whether create a new table named as CheckRun or just upgrade the CommitStatus struct
in github's document description, it bound with App feature, but in fact, looks  it bound with Action also
To show it on ui, maybe we can reuse commit status and code comment ui
checkRun db struct in my view:

type ChekRun struct {
	ID         int64                  `xorm:"pk autoincr"`
	RepoID     int64                  `xorm:"INDEX UNIQUE(repo_sha_index)"`
	Repo       *repo_model.Repository `xorm:"-"`
	State      int64                  // difference with `CommitStatus`
	Conclusion int64                  // difference with `CommitStatus`

	SHA       string           `xorm:"VARCHAR(64) NOT NULL INDEX UNIQUE(repo_sha_index)"`
	TargetURL string           `xorm:"TEXT"`
	NameHash  string           `xorm:"char(40) index"`
	Name      string           `xorm:"TEXT"`
	Creator   *user_model.User `xorm:"-"`
	CreatorID int64

	StartAt     timeutil.TimeStamp // difference with `CommitStatus`
	CompletedAt timeutil.TimeStamp // difference with `CommitStatus`

	OutPut  *ChekRunOutPut  `xorm:"-"` // difference with `CommitStatus`
	Actions []ChekRunAction `xorm:"-"` // difference with `CommitStatus`

	CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
	UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
}

type ChekRunAnnotation struct {
	Path            string
	StartLine       int64
	EndLine         int64
	StartColumn     int64
	EndColumn       int64
	AnnotationLevel string
	Message         string
	Title           string
	RawDetails      string
}

type ChekRunOutPut struct {
	ID          int64 `xorm:"pk autoincr"`
	ChekcRunID  int64 `xorm:"INDEX"`
	Title       string
	Summary     string
	Text        string
	Annotations []ChekRunAnnotation `xorm:"JSON"`
}

type ChekRunAction struct {
	ID          int64 `xorm:"pk autoincr"`
	ChekcRunID  int64 `xorm:"INDEX"`
	Label       string
	Description string
	Identifier  string
	Url         string
}


resolve topic: Add fancier styling for displaying resolved topics.

The new "Resolve topic" option in the left sidebar topic menus is handy.  However, the visuals in the left sidebar are not ideal:

What we'd like to do is change how resolved topics are displayed. For topics that are resolved, strip the ✔  from the displayed "topic_name" and instead display the a checkmark in its own column in the cutter to the left of the topic name.  We may want to use some sort of fancier icon, or at least scale up the font size for the unicode checkmark as well to make better use of the space.  (This is purely meant to be a visual change)
This would result in the textual parts of the topic names being vertically aligned.
 Any progress with this?


refactor: use pydantic for message validation

Summary of Changes
Use pydantic to easily describe valid messages.

:tada: This PR is included in version 0.13.0 :tada:
The release is available on:

v0.13.0
GitHub release

Your semantic-release bot :package::rocket:


Fix "Module not found" on Windows

This should fix issue #3 by registering the module in setup.py, under py_modules.

blackclue.exe sounds like you made an executable from the python script. Maybe the packaging did not include all files. If this is the case, please refer to the packager documentation on how to proceed.

Building a .exe is actually a thing Python for Windows does to register executables on the path.

Thank you for the PR


mac-19 is dead.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
mac-19 is dead.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

mac-19 is up and running fine, machine is out of sync with Salt master. Run command "sudo salt-call state.apply" to re-sync with Salt master again.


[fix][broker] Fix NPE calling PulsarService.getBrokerId() in checkTopicNsOwnership method during broker startup

Fixes #22975
Motivation
PulsarService.getBrokerId() will fail with NPE if it's called before the broker has been started.
Modifications

don't use brokerId in log message in org.apache.pulsar.broker.service.BrokerService#checkTopicNsOwnership method since the method might get called in the startup sequence, before brokerId is available.

Additional Context
There's a more complete fix to address the root cause, that's #22977.
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

This PR is now obsolete after #22977 has been merged.


Fixing the merge of 21.06 to 21.08 for comment changes in Profiling tool

Fixing the merge of 21.06 to 21.08 for comment changes.  Conflict was in QualificationInfoUtils.scala

build


Added find duplicate characters problem in python string section.

PR Checklist:

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is on refer on the language README.md file
[x] My addition does not have a spelling problem
[x] My submission has a proper and user-friendly description of the algorithm
[x] My submission has the time complexity of the algorithm
[ ] My submission has sample input-output of the program (NOT FOR PYTHON)

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR

Other information:

I have added a problem about finding duplicate characters in the string category of python language.
Please review my code and merge the PR request.
Thanks.

Updated checklist


Ring 2FA

Just turned on Ring 2FA on my app and now the plugin says cannot authenticate?

This plugin is now DEPRECATED... you will find a vastly superior plugin here!


table.query is not a function

I tried using Table inside a Function, and got this error. The generated code seems to be missing every method. Did I do this right?
ddbTable.addGlobalSecondaryIndex({
  indexName: 'GSI1',
  partitionKey: { name: 'PK', type: aws_dynamodb.AttributeType.STRING },
  sortKey: { name: 'SK', type: aws_dynamodb.AttributeType.STRING },
  projectionType: aws_dynamodb.ProjectionType.ALL,
});

const table = new Table<ITable, 'PK', any>(ddbTable);

const defaultAuthFunction = new Function<AuthContext, AuthResponse>(
  this,
  'LambdaAuthorizer',
  {
    logRetention: 14,
  },
  async (c) => {
    const apiKey = c.authorizationToken;

    // Look up the account using the auth token.
    const item = table.query({
      index: 'GSI1',
      query: {
        expression: 'PK = :pk',
        expressionValues: { ':pk': { S: apiKey } },
      },
    }).items[0];

    // If it exists and it's a valid account, allow request.
    if (item?.entityType === 'Account') {
      const accountId = item.Id;
      return {
        isAuthorized: true,
        // Add account id and api key into the resolver context.
        resolverContext: { accountId, apiKey },
        deniedFields: [],
      };
    }

    //
    return {
      isAuthorized: false,
      resolverContext: {},
      deniedFields: [],
    };
  },
);

And here is the part of the generated code with the __table object.
var __table = {};
var __table_query = {};
__table_query.kind = "Table.query";
__table_query.unhandledContext = __f5;
var __table_query_native = {call: undefined, preWarm: undefined};
__table_query.native = __table_query_native;
__table.query = __table_query;

Table.* Doesn't work in function right now.
You can use $AWS.DynamoDB.Query()
The reason is table.* Use the app sync contracts right now, we have a ticket to resolve this, but it's non trivial to recreate the next token and other parts of the app sync to dynamo contract.
The larger issue is that lambda doesn't give an error at compile/synth time which I'll look into.

Got it. I'll try that. $AWS.DynamoDB.Query() isn't a great option because it returns Dynamo types, which trip up Typescript when discriminating on tagged unions,  and I would have to erase the types entirely.

I'm getting this error now
CfnSynthesisError: Resolution error: Supplied properties not correct for "CfnFunctionProps"
  environment: supplied properties not correct for "EnvironmentProperty"
    variables: element 'env__functionless315': [{"indexName":"GSI1","keySchema":[{"attributeName":"PK","keyType":"HASH"},{"attributeName":"SK","keyType":"RANGE"}],"projection":{"projectionType":"ALL"}}] should be a string.

Is TableName supposed to be a string or a Table? The types tell me it's a Table.

Is TableName supposed to be a string or a Table? The types tell me it's a Table, but the error message implies that it should be a string.

It supposed to be a reference to a Table. I used the field TableName for consistency with the AWS sdk. But in hindsight, that was likely confusing. We should change it.
The reason it takes a reference is for type safety.

@sam-goodwin Do you know how I can work around that error?

Pass the table reference as TableName.
Or do you mean the CFN synthesis error? First time seeing that, will take a look soon.

The closure serializer serializes the entire table object. We attempt to remove unnecessary fields that don't serialize well, but it's a manual process to find them.
After removing unnecessary fields, we try to turn all token into environment variables.
And apparently env variables must eventually resolve to literal strings.
Ran into this on Friday and had not figured out who to detect or normalize yet.

For now, not using GSIs should bypass the issue. Will prioritize making the token serialization more robust.

Even after removing the GSI, I'm still getting that error.

Oh, you meant to remove the GSI from the table, I guess. That does bypass the issue.

We should also prioritize these two issues. It's clear that new users are going to quickly stumble into these same problems - appsync-only resolvers in lambda and incomplete dynamo index support.
https://github.com/functionless/functionless/issues/136
https://github.com/functionless/functionless/issues/132

My list right now is...

In/multi etc support for app sync vtl (almost done)
#237
Async

Another big breaking change like #132 can follow async.

Closing in favor of
#241
#132
#237


Babel configuration update

I updated babel setting to match the latest and better approach "babel-preset-env" and also added useful links to check feature compatibility

Thanks so much for your first PR


Fix null setting on reused objects

[x] Do only one thing
[x] Non breaking API changes
[ ] Tested

What did this pull request do?
Starting from v1.25.1 GORM seems to not reset null fields, causing incosistent behavior compared to the previous way GORM was working.
The fixes I have added are fixing this for Scanner interfaces and time.Time, however there's still a test failure in case of the int and most likely other primitive variables.
I am opening this PR just to illustrate the fixes, but I think we need to debate it further what's the expected behavior.

User Case Description

The regression seems to be coming from this PR: https://github.com/go-gorm/gorm/pull/6311
The unit tests are still failing on the integer default value setting. I can dig that out too @jinzhu, but this partially reverts #6311. What do you think about this fix?

This PR is being closed due to failed tests.

Just came here to say that I've also concluded that this is problem for us and it's not 100% clear to me what the previous PR was trying to solve. Will try and get another PR up to fix this but will also make sure I understand completely what's going on first.