DropdownButton's menu position doesn't update on MediaQuery changes

Originally posted by @LasseRosenow in https://github.com/flutter/flutter/issues/22075#issuecomment-549048926

It's not perfect though..

As you can see:

The dropdown stays open, but the position of the popup changes as the keyboard closes... so the position of the dropdown is weird.

Hi @DattatreyaReddy, Thanks for filing the issue. please share a minimal and complete sample code along with the output of flutter doctor -v.

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text("Test App"),
      ),
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            showModalBottomSheet(
                context: context,
                enableDrag: false,
                isScrollControlled: true,
                builder: (context) {
                  return Padding(
                    padding: MediaQuery.of(context).viewInsets,
                    child: const TestBottomSheet(),
                  );
                });
          },
          child: const Text("Bottom Sheet"),
        ),
      ),
    );
  }
}

class TestBottomSheet extends StatefulWidget {
  const TestBottomSheet({
    Key? key,
  }) : super(key: key);

  @override
  State<TestBottomSheet> createState() => _TestBottomSheetState();
}

class _TestBottomSheetState extends State<TestBottomSheet> {
  int _counter = 0;
  final List<int> _counterList = [0, 1, 2, 3];
  @override
  Widget build(BuildContext context) {
    return Padding(
      padding: const EdgeInsets.all(16.0),
      child: Column(
        mainAxisSize: MainAxisSize.min,
        crossAxisAlignment: CrossAxisAlignment.stretch,
        children: [
          DropdownButton<int>(
            value: _counter,
            items: _counterList
                .map(
                  (e) => DropdownMenuItem<int>(
                    value: e,
                    child: Text("$e"),
                  ),
                )
                .toList(),
            onChanged: (status) async {
              setState(() {
                _counter = status ?? 0;
              });
            },
          ),
          const TextField(),
        ],
      ),
    );
  }
}

steps to reproduce:

Click on BottomSheet button

click on textfield

Then, click on dropdown menu when textfield is on focus

Thanks for the update @DattatreyaReddy, I am able to reproduce the issue on the latest stable and the master channel. DropDownButton Menu doesn't update the position on MediaQuery Changes.

flutter doctor -v (mac)
[✓] Flutter (Channel stable, 3.0.4, on macOS 12.4 21F79 darwin-arm, locale en-IN)
    • Flutter version 3.0.4 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 85684f9300 (4 days ago), 2022-06-30 13:22:47 -0700
    • Engine revision 6ba2af10bb
    • Dart version 2.17.5
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-32, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (3 available)
    • sdk gphone arm64 (mobile) • emulator-5554 • android-arm64  • Android 11 (API 30) (emulator)
    • macOS (desktop)           • macos         • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)              • chrome        • web-javascript • Google Chrome 103.0.5060.53

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.1.0-0.0.pre.1594, on macOS 12.4 21F79 darwin-arm, locale en-IN)
    • Flutter version 3.1.0-0.0.pre.1594 on channel master at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 082ad11422 (2 days ago), 2022-07-11 11:40:07 +0200
    • Engine revision 2b5d5c3b2d
    • Dart version 2.18.0 (build 2.18.0-271.0.dev)
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-32, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (3 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
    • macOS (desktop)        • macos            • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)           • chrome           • web-javascript • Google Chrome 103.0.5060.114

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

I think I have seen a simialr issue for this But I can't find it right now.
Probably related to: https://github.com/flutter/flutter/issues/31683

Is there any way to move the bottom sheet without media query view insets?

Is there any way to move the bottom sheet without media query view insets?

Probably you can try DraggableScrollablesheet, But You will to manually calculate the number of pixels you need to move the bottom sheet, Perhaps that's not the right way.

But that process is too big

Thank you but that process is not exactly fissible for me

I am able to reproduce this issue on the latest stable and master channels.

Code Sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text("Test App"),
      ),
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            showModalBottomSheet(
                context: context,
                enableDrag: false,
                isScrollControlled: true,
                builder: (context) {
                  return Padding(
                    padding: MediaQuery.of(context).viewInsets,
                    child: const TestBottomSheet(),
                  );
                });
          },
          child: const Text("Bottom Sheet"),
        ),
      ),
    );
  }
}

class TestBottomSheet extends StatefulWidget {
  const TestBottomSheet({
    Key? key,
  }) : super(key: key);

  @override
  State<TestBottomSheet> createState() => _TestBottomSheetState();
}

class _TestBottomSheetState extends State<TestBottomSheet> {
  int _counter = 0;
  final List<int> _counterList = [0, 1, 2, 3];
  @override
  Widget build(BuildContext context) {
    return Padding(
      padding: const EdgeInsets.all(16.0),
      child: Column(
        mainAxisSize: MainAxisSize.min,
        crossAxisAlignment: CrossAxisAlignment.stretch,
        children: [
          DropdownButton<int>(
            value: _counter,
            items: _counterList
                .map(
                  (e) => DropdownMenuItem<int>(
                    value: e,
                    child: Text("$e"),
                  ),
                )
                .toList(),
            onChanged: (status) async {
              setState(() {
                _counter = status ?? 0;
              });
            },
          ),
          const TextField(),
        ],
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 3.11.0-1.0.pre.65, on macOS 13.3 22E252 darwin-arm64, locale en-NG)
    • Flutter version 3.11.0-1.0.pre.65 on channel master at /Users/dammya/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9b36fda920 (3 hours ago), 2023-05-05 01:54:23 -0400
    • Engine revision a885ed472e
    • Dart version 3.1.0 (build 3.1.0-77.0.dev)
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/dammya/Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    ✗ CocoaPods installed but not working.
        You appear to have CocoaPods installed but it is not working.
        This can happen if the version of Ruby that CocoaPods was installed with is different from the one being used to invoke it.
        This can usually be fixed by re-installing CocoaPods.
      To re-install see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.77.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.62.0

[✓] Connected device (3 available)
    • TECNO LC6a (mobile) • 044882598G014637 • android-arm    • Android 9 (API 28)
    • macOS (desktop)     • macos            • darwin-arm64   • macOS 13.3 22E252 darwin-arm64
    • Chrome (web)        • chrome           • web-javascript • Google Chrome 112.0.5615.137

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Flutter (Channel stable, 3.7.12, on macOS 13.3 22E252 darwin-arm64, locale en-NG)
    • Flutter version 3.7.12 on channel stable at /Users/dammya/fvm/versions/stable
    ! Warning: `flutter` on your path resolves to /Users/dammya/fvm/versions/master/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/dammya/fvm/versions/stable. Consider adding /Users/dammya/fvm/versions/stable/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/dammya/fvm/versions/master/bin/dart, which is not inside your current Flutter SDK checkout at /Users/dammya/fvm/versions/stable. Consider adding /Users/dammya/fvm/versions/stable/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d9e56e694 (2 weeks ago), 2023-04-17 21:47:46 -0400
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/dammya/Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    ✗ CocoaPods installed but not working.
        You appear to have CocoaPods installed but it is not working.
        This can happen if the version of Ruby that CocoaPods was installed with is different from the one being used to invoke it.
        This can usually be fixed by re-installing CocoaPods.
      To re-install see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.77.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.62.0

[✓] Connected device (3 available)
    • TECNO LC6a (mobile) • 044882598G014637 • android-arm    • Android 9 (API 28)
    • macOS (desktop)     • macos            • darwin-arm64   • macOS 13.3 22E252 darwin-arm64
    • Chrome (web)        • chrome           • web-javascript • Google Chrome 112.0.5615.137

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

This https://github.com/flutter/flutter/issues/107614#issuecomment-1185556413 is a possible workaround.
Here is a sample code that works for more context:
 showModalBottomSheet(
                context: context,
                enableDrag: false,
                isScrollControlled: true,
                builder: (context) {
                  return DraggableScrollableSheet(
                      initialChildSize: 0.64,
                      minChildSize: 0.2,
                      maxChildSize: 1,
                      expand: false,
                      builder: (context, scrollController) =>
                          Column(children: []));
                });


Yaml is invalid?

Description

Running ramsey/composer-install@v2 gives a weird error:
Error: The template is not valid. ramsey/composer-install/v2/action.yml (Line: 61, Col: 12): An error occurred trying to start process

Steps to reproduce

I'm not sure yet, only just started happening - everything was working fine before
Expected behavior

It works as it did before?
Environment details

version of this package: v2 tag, so latest v2
PHP version: 7.4
OS: Ubuntu 20.04 (GitHub Hosted Runner, ubuntu-latest)

Additional context

It was working fine before, we've made no workflow changes.

Please share the relevant YAML lines. Thanks!

Erm... they are in your YAML files not mine?

Oops! I missed that part. 😳
I'm not sure what that error is about, but try hard-coding the version with<EMAIL_ADDRESS>and see if that helps.

Appears to work as normal now, haven't made any changes on our end but the warning is gone... weird!

Great to hear. Maybe just some momentary blip in GitHub Actions.


Defined return types do not match implementation

Describe the bug
There are numerous places where return type defined in method signature does not match the actual return type.
An example is toJson(), the method signature returns a string; however, the implementation directly returns .toISO() which returns a string | null
Additional context
With nearly every property having null (or Nan in the case of numbers) return type option the use of this library in a project with strict: true is painful as every property needs to be non-null asserted - gross - or if guarded to keep TS happy.
Personally, I think a more TS friendly approach would be properties/methods return the expected type of a valid object, or throw an error in the case of invalid objects. It would then be the callers responsibility to validate the object prior to use, by either checking isValid() or enabling throwOnInvalid.

Man this is not the way of creating an issue.

"Numerous places". Then you only report 1.
I can't change the implementations (e.g. throwing on invalid). They need to be coherent with the original Luxon. There are a few things I changed (for the better I hope), but it's small things. The "Invalid" state of luxon is handled with null returns.
Yes I guess we could remove the | null where it can return null when invalid.

I'll check the toJson method.

v 4.5.1
Removed the latest null return types I added

Man this is not the way of creating an issue.

"Numerous places". Then you only report 1.
I can't change the implementations (e.g. throwing on invalid). They need to be coherent with the original Luxon. There are a few things I changed (for the better I hope), but it's small things. The "Invalid" state of luxon is handled with null returns.
Yes I guess we could remove the | null where it can return null when invalid.

I'll check the toJson method.

@tonysamperi - I'm sorry the wording, maybe, multiple would have been a better choice of words.
As far are examples, you are correct, I provided a single example; however, I felt the a simple single example would highlight the underlying issue and didn't feel highlighting every method that was incorrectly typed would bring value to the topic. I now understand you do see value in that, so in the future I will be sure to do so.

Man this is not the way of creating an issue.

"Numerous places". Then you only report 1.
I can't change the implementations (e.g. throwing on invalid). They need to be coherent with the original Luxon. There are a few things I changed (for the better I hope), but it's small things. The "Invalid" state of luxon is handled with null returns.
Yes I guess we could remove the | null where it can return null when invalid.

I'll check the toJson method.

@tonysamperi - I'm sorry the wording, maybe, multiple would have been a better choice of words.
As far are examples, you are correct, I provided a single example; however, I felt the a simple single example would highlight the underlying issue and didn't feel highlighting every method that was incorrectly typed would bring value to the topic. I now understand you do see value in that, so in the future I will be sure to do so.

Yes, now you're talking! If you have concrete examples of bad typings let me now and I'll check.
Cheers


Support multiple (separate) values

This library is great for showing the progress of something that is loading or playing. Is there a way to show both load progress and play progress, ie. have supporting multiple values?
For example, if I'm loading audio via html, I can start playing before the entire audio file has loaded. It would be great to show load progress as it continues to load and also animate the circle as it plays.
This is more of a feature request than a bug.

Hi!
I see that you did a big job with your pull-request, it looks really high-quality and professional...
However, I'm not sure that this functionality belongs to the library core. It looks very custom, not everybody will need/use it.
I'm trying to avoid overwhelming the library core. But you may use your fork as a customization for your needs, if you want to.
Actually, I was going to advise you to not modify the library but rather to create 2 circles, one over another - so you'll have what you need without any code modifications. Here is a snippet of how it can be done.

Hey, thanks for the feedback and snippet! You're right, this doesn't belong in the library core. Are there any plans to make this project more modular?

Yes, I have this idea for a long time. And I'd appreciate if you wish to participate in its implementation ;)

I've created a ticket to implement plugin-compatible architecture - #111.
I'm going to close this ticket. I really believe that it's better to create 2 separate circles, but it's up to you.
And I'm going to reject your PR, sorry about that.


[AutoPR billing/resource-manager] Adding Transactions and BillingSubscription to the BillingRP spec

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4005

$text_pr

Build output:
azure-mgmt-billing-1.0.0-beta.jarazure-mgmt-billing-1.0.0-beta-javadoc.jarazure-mgmt-billing-1.0.0-beta.pomazure-mgmt-billing-1.0.0-beta-sources.jar


Migrate WML crypto usage ot CHIP /crypto

Problem
For compile purposes, WML baseline added headers-only of original weave crypto.
Proposed Solution
These should be replaced with /crypto includes and long term goal is to align crypto support with Secure Channel Tiger Team crypto instructions.
Only crypto defined for CHIP Spec should be used instead original weave core constructs.

We don't need to migrate WML crypto to CHIP crypto since all users of current WML crypto are going to retire and replaced with SCTT defined new protocol.
We need to take this as sub-task of #2096. Close this one for now.

Besides SecurityManager and profile, WML crypto is stilled used by other components. Reopen this issue.

Not valid since WML solution is not selected


Examples hosting port on Windows changes

When I npm run develop on Mac, examples are always available on localhost:5000. But on Windows platform, the port is always different, for example http://localhost:63109. Could we use consistent port here as well?
Close it this cannot be (easily) done.

The port is pre specified as a serve parameter but its probably conflicting with an existing one so will change it


Missing referenced secure file azure-aks-node-ssh-key.pub

This secure file azure-aks-node-ssh-key.pub referenced in aksAgentSshPublicKeyFilename: 'azure-aks-node-ssh-key.pub' from /devops/infrastructure/prepare-stage.yml is not present in /scripts/.ssh.
The public key generated is azure-aks-gitops-ssh-key.pub
Therefore, this will cause the build to fail until either the file name or the referenced name is changed.

This has been resolved now and merged into the master branch. Thanks for calling this out.


Extremely slow and using lots of memory

I was using some code adapted from https://github.com/joeyballentine/ESRGAN and then I tried to use this library for
other architectures, but it performs at least 2-3x slower on the same models.
I don't know whether this library doesn't support mps and is falling back to cpu, or does more calculations that really slow it down. I ended up using the original code for ESRGAN models and this library for the others. For reference my code is at https://github.com/Tenpi/waifu2x/blob/master/scripts/upscale.py
It also uses up a ton of memory and I get an error upscaling anything above around 500x500px. The original code seems to handle larger images around 1000x1000px.

That definitely seems like a bug. I don't think we're really doing anything different that could be causing that, but we'll look into it, thanks


add START_GAME saga which will route to new Game component.

Codecov Report

Merging #36 into feature/#26-add-svg-cards will decrease coverage by 0.42%.
The diff coverage is 0.00%.

@@                      Coverage Diff                      @@
##           feature/#26-add-svg-cards      #36      +/-   ##
=============================================================
- Coverage                      40.32%   39.89%   -0.43%
=============================================================
  Files                             24       24
  Lines                            186      188       +2
=============================================================
  Hits                              75       75
- Misses                           111      113       +2

Impacted Files
Coverage Δ

src/main/webapp/src/redux/saga/game.saga.js
9.09% <0.00%> (-2.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b4e2b...44458ed. Read the comment docs.


Subdomainless SAML

Fixes #11070
Highlights: This is an easy change, just allow SAML to read the organization name from URL and not just subdomain. But there are two changes that affect the entire sessions controller. I think they are fine, I tested them with subdomainless and domainful and they work, but it's worth thinking about them for a while.

@javitonino if you want this CR please make a PR based on azavea-feature/cloudniner/saml-authentication instead, so the diff is narrower, please :)

Merging because the conflict was only at NEWS.md (command line resolved it automatically, indeed).


Registration

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/71389
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" be36469c39556ef70bce390673d238ec0fdaa516
git push origin v0.1.0


only build packaging-related commits

Tracked in https://github.com/serilog/serilog/issues/1224

Thanks, good catch!


Sequencer current step public API

I'd like to access the current step description.
I want to be able to know the step ID, if it's the last step of the sequence.
Describe the solution you'd like
Define a sequence
Ground : GroundSequence(THIS^);
In Main method
Ground.IsLastStep
Ground.CurrentStepId
I want to be able to access them with autocomplete. _currentStep works, but since it's not suggested, I'm hesitant to use it.
I'd be ok with read only properties.
Describe alternatives you've considered
I could add these variables into my extended fb, but imho this functionality should be supported out of the box.

Sure... we need property that returns currentstep info.


Rewrite message pump logic.

cc @zorkian
Right now TestMessagePump passes but I'm not sure if the entire setup works correctly because the test suite is currently broken. Uploading this now so it is online while I'm away.
For posterity, the purpose of this change is to 1) improve the shutdown flow, and 2) limit the extent to which the consumer's message channel will be full of uncommittable messages when a claim expires with a large buffer.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


MAINT: better naming of function to set up netcon

I was really misled by the name "connect_to_target". The actual connection happens when you call _PC.gid_connect inside _Cell.parconnect_from_src

Thanks for the review @rythorpe !


Fix relative URLs in README.md

Fix several broken URLs in the README.
I'm<EMAIL_ADDRESS>I don't think I need an extra CLA for this, but let me know if there's anything else needed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.611%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1658

Relevant Lines:
1983

💛  - Coveralls

thanks for the fix


Syntax highlighting error in typescript after double dot

From @Franziskus1988 on May 10, 2016 6:1

VSCode Version: 1.1.0, 1.0.0
OS Version: Windows 10 x64

Steps to Reproduce:

Set color theme to Dark+
Type something like: var testvar = isTrue ? "hello" : "goodbye"

Copied from original issue: Microsoft/vscode#6228

Duplicate of https://github.com/Microsoft/TypeScript-TmLanguage/issues/81


Can not  use React Native 'RC' version

When i use<EMAIL_ADDRESS>, and execute npm install ,i encountered :

npm WARN EPEERINVALID<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><1.0.0 but none was installed.

because in react-native-i18n 's package.json ,you defined
"peerDependencies": {
    "react-native": ">=0.4.0 <1.0.0"
  }

can you fix it ?
Thanks a lot~

@jinzhaoyu I think that should be better to include this dependency in your project with git clone repo, and after change yourself package.json, because (IMHO) is not a good practice to include RC in depencencies.

Ok, Thanks for your help :)


Add configuration instructions for Ubuntu 20.04

Ubuntu 20.04 (focal) has been released today in WSL2 and Azure. The packages.microsoft.com repo already supports focal and it would be useful to add the instructions here. Also, feel free to update the MSFT contacts pointing to me if necessary.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25943cc5-9927-5ca7-b9db-4c1d398726c5
Version Independent ID: ae5bf48b-26cf-b5c8-22c8-68fa9a70258f
Content: Linux Software Repository for Microsoft Products
Content Source: WindowsServerDocs/administration/Linux-Package-Repository-for-Microsoft-Software.md
Product: windows-server
Technology: compute
GitHub Login: @szarkos
Microsoft Alias: szark

+1

Hi, I believe this was fixed with https://github.com/MicrosoftDocs/windowsserverdocs/commit/c08ff2b68f01df2c40942f4d6c76051017ee0680

Hi, I believe this was fixed with https://github.com/MicrosoftDocs/windowsserverdocs/commit/c08ff2b68f01df2c40942f4d6c76051017ee0680

(or the closing commit hash: https://github.com/MicrosoftDocs/windowsserverdocs/commit/b18effcba95c85d6e08e7d29808b576491a5352e )

(or the closing commit hash: https://github.com/MicrosoftDocs/windowsserverdocs/commit/b18effcba95c85d6e08e7d29808b576491a5352e )

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


A new take on GlowFilter GL path.

GL implementation of all 4 variations of GlowFilter; glow, inner glow, knockout glow and inner knockout glow.

This is cool

Pushed DropShadowFilter as well

Does this also work in conjunction with scrollrects? It seems that was usually what was causing a number of issues (at least for me)


Add displayName

:tada: This PR is included in version 1.15.0-beta.3 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.15.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


openssl 1.0.2 is not supported anymore

Upstream ended 1.0.2 support with 2019, but we still have many packages depending on it.
$ (git grep -l openssl_1_0_2 pkgs/; grep openssl_1_0_2 pkgs/top-level/all-packages.nix) | wc -l
65

I know of no issues since the last release, so I'm not marking it as vulnerable yet, but the dependents would better start migrating in advance.
Stable: it's unclear to me what we do about these in 19.09, but perhaps there won't be any notable vulnerabilities before 19.09 support ends :-)  1.0.2 is the default in 19.03, but we don't support that anymore.

List of files:
pkgs/applications/blockchains/pivx.nix
pkgs/applications/networking/cluster/hadoop/default.nix
pkgs/applications/version-management/git-and-tools/git-dit/default.nix
pkgs/applications/version-management/p4v/default.nix
pkgs/development/compilers/crystal/default.nix
pkgs/development/compilers/mint/default.nix
pkgs/development/interpreters/python/pypy/default.nix
pkgs/development/interpreters/python/pypy/prebuilt.nix
pkgs/development/libraries/globalplatform/default.nix
pkgs/development/libraries/globalplatform/gppcscconnectionplugin.nix
pkgs/development/libraries/openssl/default.nix
pkgs/development/mobile/androidenv/lldb.nix
pkgs/misc/emulators/epsxe/default.nix
pkgs/os-specific/darwin/apple-source-releases/network_cmds/default.nix
pkgs/servers/sql/postgresql/default.nix
pkgs/shells/powershell/default.nix
pkgs/tools/misc/mongodb-tools/default.nix
pkgs/tools/security/pbis/default.nix
pkgs/top-level/all-packages.nix
pkgs/top-level/beam-packages.nix
pkgs/top-level/perl-packages.nix
pkgs/top-level/python-packages.nix
pkgs/top-level/static.nix

I think we should mark it vulnerable. Other EOL packages have been marked vulnerable because of the EOL before, e.g. Firefox, and if there’s any package we should be extra-careful with, its OpenSSL.

I bumped it to fix the last CVE minutes before opening this ticket, so I was obviously biased against marking it immediately ;-)

BTW, it's still a decision to make, as there's surely some LTS distro that will still ship 1.0.2 for some time, so patching the worst probably won't be too difficult.  I'm personally not willing to invest significant time into it, though :-)

BTW, it's still a decision to make, as there's surely some LTS distro
that will still ship 1.0.2 for some time, so patching the worst
probably won't be too difficult.  I'm personally not willing to
invest significant time into it, though :-)

Best way to motivate somebody to volunteer is to mark it as insecure. ;)

OK, I think the we've given enough time and now we should press on a bit: https://github.com/NixOS/nixpkgs/pull/80746


support SQLAlchemy 1.4.26+

sqlalchemy.exc.SAWarning: Dialect bigquery:bigquery will not make use of SQL compilation caching as it does not set the 'supports_statement_cache' attribute to True.  This can have significant performance implications including some performance degradations in comparison to prior SQLAlchemy versions.  Dialect maintainers should seek to set this attribute to True after appropriate development and testing for SQLAlchemy 1.4 caching support.   Alternatively, this attribute may be set to False which will disable this warning. (Background on this error at: https://sqlalche.me/e/14/cprf)

https://source.cloud.google.com/results/invocations/98c79c9a-dc03-49b5-bba9-db389866d284/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigquery-sqlalchemy%2Fpresubmit%2Fpresubmit/log
More info here: https://sqlalche.me/e/14/cprf
Also, I recall caching may have been the root cause in https://github.com/googleapis/python-bigquery-sqlalchemy/issues/368 ?

https://github.com/googleapis/python-bigquery-sqlalchemy/pull/384 capped the maximum version of SQLAlchemy due to these failing compliance tests. Version 1.4.25 is the last known working version, but we just know that it started failing between 1.4.25 and 1.4.29.
It's not clear if something changed with SQLAlchemy that started this breakage or the compliance tests need additional configuration or a bit of both.
See https://github.com/googleapis/python-bigquery-sqlalchemy/issues/386 for more information.

I know we won't be able to support 1.4.29, but I'll try to expand support as much as we can in https://github.com/googleapis/python-bigquery-sqlalchemy/pull/391

1.4.28 fails with similar errors to 1.4.29.
https://source.cloud.google.com/results/invocations/e36ef56c-83ea-49b9-816f-6680c0dfef60/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigquery-sqlalchemy%2Fpresubmit%2Fpresubmit/log

1.4.27 has fewer failures, but still fails
___________ ExpandingBoundInTest_bigquery+bigquery.test_typed_str_in ___________
Traceback (most recent call last):
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/testing/suite/test_select.py", line 1147, in test_typed_str_in
    self._assert_result(
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/testing/suite/test_select.py", line 1020, in _assert_result
    eq_(conn.execute(select, params).fetchall(), result)
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1289, in execute
    return meth(self, multiparams, params, _EMPTY_EXECUTION_OPTS)
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/sql/elements.py", line 325, in _execute_on_connection
    return connection._execute_clauseelement(
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1473, in _execute_clauseelement
    compiled_sql, extracted_params, cache_hit = elem._compile_w_cache(
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/sql/elements.py", line 533, in _compile_w_cache
    compiled_sql = self._compiler(
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/sql/elements.py", line 555, in _compiler
    return dialect.statement_compiler(dialect, self, **kw)
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/sqlalchemy_bigquery/base.py", line 192, in __init__
    super(BigQueryCompiler, self).__init__(dialect, statement, *args, **kwargs)
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/sql/compiler.py", line 776, in __init__
    Compiled.__init__(self, dialect, statement, **kwargs)
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/sql/compiler.py", line 451, in __init__
    self.string = self.process(self.statement, **compile_kwargs)
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/sql/compiler.py", line 486, in process
    return obj._compiler_dispatch(self, **kwargs)
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/sql/visitors.py", line 82, in _compiler_dispatch
    return meth(self, **kw)
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/sql/compiler.py", line 1590, in visit_textclause
    BIND_PARAMS.sub(
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/sql/compiler.py", line 1574, in do_bindparam
    return self.process(textclause._bindparams[name], **kw)
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/sql/compiler.py", line 486, in process
    return obj._compiler_dispatch(self, **kwargs)
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/.nox/compliance-3-10/lib/python3.10/site-packages/sqlalchemy/sql/visitors.py", line 82, in _compiler_dispatch
    return meth(self, **kw)
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/sqlalchemy_bigquery/base.py", line 525, in visit_bindparam
    assert_(self.__expanded_param(param), f"Unexpected param: {param}")
  File "/tmpfs/src/github/python-bigquery-sqlalchemy/sqlalchemy_bigquery/base.py", line 68, in assert_
    raise AssertionError(message)
AssertionError: Unexpected param: (__[POSTCOMPILE_q])
- generated xml file: /tmpfs/src/github/python-bigquery-sqlalchemy/compliance_3.10_sponge_log.xml -

https://source.cloud.google.com/results/invocations/2cc08719-cc62-45a9-a5f0-e0260888937c/targets

My team is currently on SQLAlchemy 1.4.31 and we're planning to integrate with sqlalchemy-bigquery — based on the warning in the OP, it doesn't seem like there'll be actual breakage with using 1.4.31 it would just mean poor performance for querying bigquery tables with the ORM while this issue is being worked on. Is that right?

It does seem to at least mostly work. The system tests we had written were passing, but the compliance tests are much more thorough, so I've capped the version until we can figure that out.

Do you have any news on that by now?
It blocks me (and I guess others) from upgrading SQLAlchemy and pyarrow.

@tswast I guess this is not your top priority right now, but do you have any news on when or if this is going to be fixed?
Right now there are two new versions released Would be great to be able to update pyarrow in the projects I am using python-bigquery-sqlalchemy.

Unfortunately, you're right that it's not a top priority at the moment. If you or someone makes some progress with the compliance test suite on later versions, I'm sure a PR would be much appreciated. See https://github.com/googleapis/python-bigquery-sqlalchemy/pull/408

given that it related to warnings: is there any chance you could release a version that doesn't require your compliance tests to pass?
I ask as i'm in a enviornment where we are using poetry and that project has made the opinionated approach to not allow installation of conflicting versions.
I'd like to use bigquery-sqlalchemy just to keep my bigquery tables in sync via alembic and wouldn't be using it for anything else, so performance on the DDL updates isn't as big of issue.
but since i'm on python 3.10 there is no version of bigquery-sqlalchemy that doesn't have the strict version checking, which would require me to pin entirely to sqlalchemy<=1.4.27.

I'm also looking for a way to relax the sqlalchemy version requirements.  I'd be willing to contribute any help needed to allow this to support the sqlalchemy 2.0 pre-release.

@cofin @woidda
I have a PR #499 that is pending that should remove the restriction on the sqlalchemy version. Hoping to get this knocked out shortly.

@chalmerlowe, Thanks for the quick reply.  I had just cloned your branch and was going to give it a test.
For the poetry users:
While waiting for this to be merged, it's possible to use this branch now by using the following dependency in pyproject.tonl.
sqlalchemy-bigquery = { git = "https://github.com/googleapis/python-bigquery-sqlalchemy.git", branch = "version-fix"}

Something about the PR has broken something different in our suite of tests, so YMMV and that is what I am trying to figure out/resolve.


Install fails with Jupyterlab 3.0.7

Hey there, nice work sofa. Unfortunately install fails with Jupyterlab 3.0.7 on Mac (Big Sur).
ValueError: The extension "@pyviz/jupyterlab_pyviz" does not yet support the current version of JupyterLab.
Conflicting Dependencies:
JupyterLab                        Extension      Package

=3.0.4 <3.1.0                    >=2.0.0 <3.0.0 @jupyterlab/application
=3.0.3 <3.1.0                    >=2.0.0 <3.0.0 @jupyterlab/apputils
=3.0.4 <3.1.0                    >=2.0.0 <3.0.0 @jupyterlab/notebook
=3.0.3 <3.1.0                    >=2.0.0 <3.0.0 @jupyterlab/rendermime-interfaces
=6.0.3 <6.1.0                    >=5.0.0 <6.0.0 @jupyterlab/services
See the log file for details:  /var/folders/k4/9l0_d86n3qn8wp609m1c6tmc0000gn/T/jupyterlab-debug-wlhnr7lj.log

Regards

You no longer have to install the extension explicitly, it is automatically installed when you install the Python package. We've also updated documentation about everywhere (but in some cases the docs have not yet been rebuilt).

I guess, we **could

Dear maintainers, in the referenced issue on plotly, installing pyviz_comms breaks plotly. Looking at the package.json file in this project, it seems you missed an important configuration for ipywidgets when porting this package to JupyterLab 3 (see second point on shared packages of Updates for widget maintainers).
To clarify that configuration, it forces webpack to not include @jupyter-widgets/jupyterlab-manager in the Javascript artifacts of this extension. So it will use the JS package provided by the python package ipywidgets. This is critical as only one manager should be loaded to ensure all widget extensions got registered properly.

Configuration and implementation inspired from https://github.com/voila-dashboards/voila-gridstack/blob/master/packages/jupyterlab-gridstack/src/widgets/index.ts may be better.

@fcollonval If you could look into it that would be incredibly helpful!

@philippjfr is there an issue remaining here or can this be closed?


Update index.mdx

The schema path can also be called when using prisma studio

Thanks for the adjustment Martin 🙌


Update html navbar

resolves #156

updates navigation bar in html to be more clear

Thanks @kellijohnson-NOAA and @e-gugliotti-NOAA for the idea to clarify these links and then making it happen.
Regarding the issue link, the number of github issues in either doc or stock-synthesis reported by folks outside of the SS3 team has been tiny, so I think it's fine just like it is. If someone reports a issue in the doc repo that would be better moved to stock-synthesis, we can just move it over: https://docs.github.com/en/issues/tracking-your-work-with-issues/transferring-an-issue-to-another-repository.


[MQ Goals]  ARM Template for java Feature/live test resource mgmt

Our goal is to create common Azure resources using ARM template for each module. And pipeline to manage common resources and drop them in end.  This will save cost and remove unwanted resources after  test is complete or stopped in between
There will be one  ARM  template per service. For example Storage will have one common arm template for Queue, File and Blob.
The pipeline will run ARM template and  create common resources for example resource group, Accounts etc.
The pipeline will pass on names of these resources as ENV variable into test. For example  AZURE_APPCONFIG_CONNECTION_STRING
In the end pipeline will also delete these common resources which  it created earlier and that  will cause all the resources created to be removed.

/azp run java - appconfiguration - tests

/azp run java - appconfiguration - tests

/azp run java - keyvault- tests

/azp run java - keyvault - ci

/azp run java - keyvault- tests

/azp run java - keyvault - tests

/azp run java - appconfiguration - tests
/azp run java - keyvault - tests
/azp run java - storage - tests

/azp run java - appconfiguration - tests

/azp run java - keyvault - tests

/azp run java - storage - tests

/azp run java - appconfiguration - tests

/azp run java - keyvault - tests

/azp run java - storage - tests

/azp run java - appconfiguration - tests

/azp run java - appconfiguration - tests

/azp run java - eventhubs - tests

/azp run java - keyvault- tests

/azp run java - keyvault - tests

/azp run java - appconfiguration - tests

/azp run java - keyvault - tests

/azp run java - storage - tests

The ARM template for ApConfig is ready for review. Here are test run in pipeline. There is one MAC OS test failing , which is failing in nightly run also.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=216316&view=results
@mssfang  @alzimmermsft

/azp run java - keyvault  -  tests

/azp run java - keyvault - tests

/azp run java - keyvault - tests

/azp run java - keyvault - tests

/azp run java - storage - tests

@g2vinay   I have compare live test run for this branch with  master run.  And  this branch have same failure as master.
I know you are working on fixing text issue in master branch.
I think the work is complete from ARM point of view for KV. Please review KV ARM Template  and approve them in this PR.
If you are interested to review test results, they are here ..
KV pipeline from master branch
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=225059&view=logs&j=4d5db6ce-0b7f-527e-b115-2367ee6e1fef&t=b7d16dfc-4abf-5ff2-eaa7-e82f3df2ef1b&l=1360
KV pipeline run for this branch
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=223036&view=logs&j=4d5db6ce-0b7f-527e-b115-2367ee6e1fef&t=b7d16dfc-4abf-5ff2-eaa7-e82f3df2ef1b&l=1425

/azp run java - storage - tests

/azp run java - storage - tests

/azp run java - storage - tests

/azp run java - storage - tests

/azp run java - storage - tests

@alzimmermsft   I have added needed Roles for storage account for test. Have a look at the run https://dev.azure.com/azure-sdk/internal/_build/results?buildId=228040&view=logs&j=d4b67cd2-6572-561e-035e-54acb01c3f6e&t=e0165002-68ce-55b0-d006-544d028d5587
If no more resource creation is needed for  storage test, Can we consider storage ARM template complete ?

azp run java - eventhubs - tests

/azp run java - eventhubs - tests

@alzimmermsft I have added needed Roles for storage account for test. Have a look at the pipeline run https://dev.azure.com/azure-sdk/internal/_build/results?buildId=228040&view=logs&j=d4b67cd2-6572-561e-035e-54acb01c3f6e&t=e0165002-68ce-55b0-d006-544d028d5587
If no more resource creation is needed for storage test, Can we consider storage ARM template complete ?

Those tests look to be running correctly, the failing tests have been seen outside the scope of this change.

/azp run java - eventhubs - tests

/azp run java - eventhubs - data


elixir: add multistage example

Updates #31

@wingyplus I'm sorry we didn't merge this PR yet. But, we've moved all of the examples to https://github.com/dagger/dagger/tree/main/examples. Could you please reopen PR there? 🙏 Thank you!
We will archive this repo.


Multiple benchmark set support is inconsistent, bound_label doesn't seem to work

Several issues as I put together a coding example with the package, having to do with multiple sets of benchmark covariates, and the use of labels for the benchmark sets. All start from the example Darfur code:
import sensemakr as smkr
import statsmodels.formula.api as smf
darfur = smkr.load_darfur()
reg_model = smf.ols(formula='peacefactor ~ directlyharmed + age + farmer_dar + herder_dar + '\
                    'pastvoted + hhsize_darfur + female + village', data=darfur)
darfur_model = reg_model.fit()

The bound_label argument doesn't seem to do anything (note this is the same whether I do ['a'] or 'a'):

darfur_sense = smkr.Sensemakr(model = darfur_model,
                              treatment = "directlyharmed",
                              benchmark_covariates = ['female'],
                              bound_label=['a'])
# Label is '1x female'
darfur_sense.summary()
# Label is '1x female'
darfur_sense.plot()

Benchmark sets can be labeled by passing a named dict of string lists, but this is undocumented.

darfur_sense = smkr.Sensemakr(model = darfur_model,
                              treatment = "directlyharmed",
                              benchmark_covariates = {'a':['female']})
# Label is '1x a'
darfur_sense.summary()
# Label is '1x a'
darfur_sense.plot()

There is support for multiple sets of benchmarks by passing a list of lists (similar to a named list of vectors in the R version) or a named dict but this is undocumented, and also this only works for .summary(), not .plot()

darfur_sense = smkr.Sensemakr(model = darfur_model,
                              treatment = "directlyharmed",
                              benchmark_covariates = [['female'],
                                                      ['pastvoted','female']])
# Works fine
darfur_sense.summary()
# Error "AttributeError: 'Series' object has no attribute 'append'"
darfur_sense.plot()

Results are the same if using {'a':['female'], 'b':['pastvoted','female']} instead of  [['female'], ['pastvoted','female']]

Hi @NickCH-K thanks so much for bringing these here! Keep them coming!
@KennyZhang-17 can you take a look at it?

Thanks for pointing these out @NickCH-K!  We could definitely document the benchmark_covariates better. The error raised in (3) plot seems due to the deprecation of append method in pandas 2.0 or newer. It should be relatively easy for me to fix this by replacing append with the concat (I will reply to this once a newer version is coming out).
The bound label issue in (1) is more complicated. The "bound label" argument is mainly for the use of defining the sensemakr object without a good benchmark covariate name (defining with r2dyz.x for example). In the case where we already have bound labels like "1x ['female']", "2x ['female']", "1x ['pastvoted', 'female']", it would be ambiguous which one to replace with (maybe a dimension check could help).  For now, the labels can be changed if you go to darfur_sense.bounds and change the bound_label manually (or alternatively using a named dict as in (2)). I think a similar phenomena can be observed in R (@carloscinelli) with:

data("darfur")
runs regression model
model <- lm(peacefactor ~ directlyharmed + age + farmer_dar + herder_dar +

            pastvoted + hhsize_darfur + female + village, data = darfur)

sensitivity <- sensemakr(model, treatment = "directlyharmed",

                                               benchmark_covariates = "female",

                                               kd = 1:3, bound_label='a')

plot(sensitivity)

Thank you! I will go ahead with the example for now and cross my fingers for the multiple-benchmark plot working by the time it's relevant.

[ ] (1) improve documentation of "bound_label" argument, it should explicitly mention it is intended to only provide labels for bounds provided manually; maybe include a warning if "bound_label" is provided without a manual bound, such as "no manual bound provided, bound_label ignored;"
[ ] (2) document the use of dictionaries for multiple benchmarks; this should be the preferred approach, where you can provide easily provide names to the benchmarks.
[ ] (3) document the use of lists of lists for multiple benchmarks and fix the plot. But we should comment that the preferred approach is (2).

@NickCH-K you can already do multiple benchmarks using dictionaries, and it should be working. We will fix the bug on the list of lists use and also document it, but personally I would use dictionaries when doing multiple benchmarks, it is cleaner.

Thank you! I like the dict syntax best anyway. Once it updates I will try it again to see if the plotting works.

Fantastic! Thank you very much.


Unable to use useState hook with .net core project template

Moved from @mookhoo on https://github.com/aspnet/AspNetCore.Docs/issues/12405 ...

I am trying to create a new page that utilizes useState hook in the project created by this template, I have been unsuccessful. I have tried several ways, creating a function, and I end up getting error. Do you have an example on how to create a new page in this template and utilize "useState" hook? Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 261c9875-3db6-4d30-f9d6-922a9334ecb2
Version Independent ID: b8f8f7c4-9c90-869d-9fd7-a887bc28f262
Content: Use the React project template with ASP.NET Core
Content Source: aspnetcore/client-side/spa/react.md
Product: aspnet-core
Technology: aspnetcore-clientside
GitHub Login: @SteveSandersonMS
Microsoft Alias: scaddie

At the time of writing the default ClientApp project doesn't support it. You can upgrade the create-react-app manually. I did that by deleting node_modules, updating the package.json, and do npm install in the ClientApp folder.
The package.json I used:
{
"name": "just-a-project",
"version": "0.1.0",
"private": true,
"dependencies": {
"react": "^16.8.6",
"react-dom": "^16.8.6",
"react-scripts": "3.0.1"
},
"eslintConfig": {
"extends": "react-app"
},
"scripts": {
"start": "rimraf ./build && react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject"
},
"browserslist": {
"production": [
">0.2%",
"not dead",
"not op_mini all"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
}
}

This does not answer my question.
I am unable to utilize useState or useEffect because these hooks can only be used within a function. However, the project utilizes class by extending Component. Converting the class into a function throws errors for other methods that are utilized in the project. I hope this clarifies the issue I am facing, and hoping for a solution/suggestion.

import React from 'react';
export function Counter(props) {
const [currentCount, incrementCounter] = React.useState(0);
return (

Counter

This is a simple example of a React component.

Current count: {currentCount}

  <button className="btn btn-primary" onClick={() => incrementCounter(currentCount + 1)}>Increment</button>

);
}

https://gist.github.com/nickkaczmarek/c15193f9251a921be7511a6105cf8ac7

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


git-new-pull-request: custom PR commands

allow a .gitconfig override for custom PR commands outside of GitHub/Bitbucket

Can you please share details which service you use? Maybe we can add a driver for it.

@colinsf bump. Any response to @kevgo's question?

Closing due to lack of response. Please reopen if necessary

heyyy sorry i ignored this forever
self-hosted gitlab was my target use case

gitlab support was added in 3.1.0. Please try that out as it may cover your use case. docs

:beers:


Providing instructions on how to generate Swift client code

Describe the issue
I'd like to generate Swift client code from Smithy models I already created. Would it be possible to provide step-by-step instructions on how to do this? For instance, in the README.md file like you did for the smithy-typescript repository.
Links
https://github.com/awslabs/smithy-swift/blob/main/README.md

Related to https://github.com/awslabs/aws-sdk-swift/issues/186


Make RocksDB problem crash master

What changes are proposed in this pull request?
Currently the RuntimeException from RocksInodeStore will crash the master from InodeTreePersistentState. But the same exception from RocksBlockStore will only make RPCs fail instead of crashing the master.

Closed as the solution depends on discussion in https://github.com/Alluxio/alluxio/issues/16381


pytest-django: tests fail due to sandbox on aarch64-darwin

Describe the bug
pytest-django fails to build on aarch64-darwin due to failing tests due to a sandbox issue.
See also: https://github.com/NixOS/nixpkgs/pull/282912
Steps To Reproduce
$ nix build --rebuild .#python311.pkgs.pytest-django
error: builder for '/nix/store/l35qps1mk6nxhwwa9ijblsk6xw8q2fnf-python3.11-pytest-django-4.7.0.drv' failed with exit code 1;
       last 10 log lines:
       > ERROR tests/test_fixtures.py::TestLiveServer::test_change_settings - socket.gaierror: [Errno 8] nodename nor servname provided, or not known
       > ERROR tests/test_fixtures.py::TestLiveServer::test_transactions - socket.gaierror: [Errno 8] nodename nor servname provided, or not known
       > ERROR tests/test_fixtures.py::TestLiveServer::test_serve_static_dj17_without_staticfiles_app - socket.gaierror: [Errno 8] nodename nor servname provided, or not known
       > ERROR tests/test_fixtures.py::TestLiveServer::test_db_changes_visibility - socket.gaierror: [Errno 8] nodename nor servname provided, or not known
       > ERROR tests/test_fixtures.py::TestLiveServer::test_item - socket.gaierror: [Errno 8] nodename nor servname provided, or not known
       > ERROR tests/test_fixtures.py::TestLiveServer::test_url - socket.gaierror: [Errno 8] nodename nor servname provided, or not known
       > FAILED tests/test_fixtures.py::TestLiveServer::test_specified_port_django_111 - PermissionError: [Errno 1] Operation not permitted
       > FAILED tests/test_fixtures.py::TestLiveServer::test_serve_static_with_staticfiles_app - Failed: nomatch: '*test_a*PASSED*'
       > ============= 2 failed, 202 passed, 2 skipped, 10 errors in 25.24s =============
       > /nix/store/ymqnr6q4slam0ns76mjpcjry70fa8h3i-stdenv-darwin/setup: line 1591: pop_var_context: head of shell_variables not a function context
       For full logs, run 'nix log /nix/store/l35qps1mk6nxhwwa9ijblsk6xw8q2fnf-python3.11-pytest-django-4.7.0.drv'.
$ nix build --rebuild .#python311.pkgs.pytest-django --option sandbox false
$ echo $?
0

Expected behavior
Tests should pass, allowing the package build to succeed.
Notify maintainers
none listed for pytest-django specifically, @hexa for django in general
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-darwin"`
 - host os: `Darwin 23.2.0, macOS 14.2.1`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.19.2`
 - channels(n8henrie): `""`
 - channels(root): `""`
 - nixpkgs: `/nix/store/64npyyxn3bb6cxciz12yigldfc2p9fh1-source`

Add a :+1: reaction to issues you find important.

https://discourse.nixos.org/t/dealing-with-tests-that-require-networking-support/13804
In a case like this, would disabling these tests be appropriate?
They seem to only need access to localhost -- is that permissible in a sandboxed build?

They seem to only need access to localhost -- is that permissible in a sandboxed build?

Future self: this was fixed by adding __darwinAllowLocalNetworking, which seems to currently have zero mentions in the nixpkgs manual (or the nixos manual) or https://nix.dev/manual/nix/2.19/language/advanced-attributes.
Defined in nix: https://github.com/NixOS/nix/blob/40254092dd7bc402642b3fb4a66d4c999b3b7b0f/src/libstore/build/local-derivation-goal.cc#L2087
It adds -D _ALLOW_LOCAL_NETWORKING=1 to the sandbox-exec call.


Update manifesto-section.tsx

Adding Joj as signatory

Changed the CI script from npx prettier to pnpm exec prettier. The former uses the latest version, as nothing is installed. It might have different rules than the prettier in the lockfile.
From the logs of the failed run:
Run npx prettier --check './apps/**/*.{ts,tsx}'
npm warn exec The following package was not found and will be installed<EMAIL_ADDRESS>Checking formatting...
[warn] apps/logs-frontend/src/components/ui/tree-view.tsx
[warn] Code style issues found in the above file. Run Prettier with --write to fix.


toml: type mismatch for config.Protocol: expected table but found string

If you have a configuration problem, please first try to create a basic configuration following the instructions on the wiki before filing an issue.
Please answer the following questions.
Which version of matterbridge are you using?
version: 1.7.1 0f5274f
Please describe the expected behavior.
Running a bridge between Discord and IRC.
Please describe the actual behavior.
Use logs from running matterbridge -debug if possible.
Output is just:
INFO[2018-02-15T09:41:05+01:00] Enabling debug
INFO[2018-02-15T09:41:05+01:00] Running version 1.7.1 0f5274f
2018/02/15 09:41:05 toml: type mismatch for config.Protocol: expected table but found string

Any steps to reproduce the behavior?
Download go and setup $GOPATH. Download and place matterbridge-linux-amd64 (v1.7.1) in $GOPATH/bin. Setup Discord bot and run config (with your own token).
Please add your configuration file
[irc]
Server="irc.server.com:6667"
Charset="utf-8"
Nick="bridge"

[discord]
Server="My Server"
Token="sometoken"

[[gateway]]
name="gateway1"
enable=true

[[gateway.inout]]
account="irc"
channel="#somechannel"

[[gateway.inout]]
account="discord"
channel="general"

Please follow the configuration on https://github.com/42wim/matterbridge/wiki/How-to-create-your-config
The irc, discord and gateway configurations are not correct, should be something like below
[irc.myirc]
Server="irc.server.com:6667"
Charset="utf-8"
Nick="bridge"

[discord.mydiscord]
Server="My Server"
Token="sometoken"

[[gateway]]
name="gateway1"
enable=true

[[gateway.inout]]
account="irc.myirc"
channel="#somechannel"

[[gateway.inout]]
account="discord.mydiscord"
channel="general"


Testing for list scope -endpoint

Testing for list scope -endpoint

duplicate with #28
Closing this.


When should I use a factory function?

The docs mention the factory functions API, but not when (or why) they should be used.
Looking at issue #247, it looks like factory functions are intended to solve some transform issues that happen when passing around the normal functions.
It's worth updating the docs (both the README and the wiki) around these functions, because currently typia's API is pretty confusing, two ways to reach the same result without an obvious difference between them.

Will update guide documents on https://typia.io
Thanks for suggestion.


Adding imaginary unit

This should be the good one @m-mohr. Sorry for the chaos with the previous PRs, I did a mess.

just curious: what is this for, and how are complex numbers expected to be handled in data cubes? E.g. do you get a data cube with some band-like dimension, having a real and imaginary bands?

hmm I wonder if this should have been merged,
I don't think we were already sure that adding the imaginary unit was a good first step for #455

@soxofaan, Well noted, my bad. It's reverted on #464 . Could you approve the revert?


log4j command line file configuration

Hey @sandain this is related to the last PR I sent for log duration.  I want to configure the logger to use a timestamp that has enough info to observe things like which players are online the most, how long since they were last online, etc.  I've got it working with a modified copy of msctl, but wanted to run this by you before doing a PR to hear your thoughts on it.  I tried adding -Dlog4j.configurationFile=... via $SERVER_ARGS but it looks like JVM args need to precede the jarfile in the command line.  What do you think of adding $JVMARGS?
related info:
local change I made to msctl to get log4j configurationFile working
minecraft@minecraft> diff -u git/mscs/msctl /usr/local/bin/msctl
--- git/mscs/msctl      2019-11-06 21:39:59.397528513 +0000
+++ /usr/local/bin/msctl        2019-11-06 22:57:08.767932902 +0000
@@ -1340,6 +1340,7 @@
     printf "$SERVER_COMMAND\n"
     exit 1
   fi
+  echo SERVER_COMMAND: $SERVER_COMMAND
   # Start the server.
   nohup sh -c "tail -f --pid=\$$ $WORLD_DIR/console.in | {
     $SERVER_COMMAND mscs-world=$1 > $WORLD_DIR/console.out 2>&1; kill \$$;
@@ -2260,7 +2261,7 @@
 DEFAULT_INITIAL_MEMORY=$(getDefaultsValue 'mscs-default-initial-memory' '128M')
 DEFAULT_MAXIMUM_MEMORY=$(getDefaultsValue 'mscs-default-maximum-memory' '2048M')
 DEFAULT_SERVER_LOCATION=$(getDefaultsValue 'mscs-default-server-location' $LOCATION'/server')
-DEFAULT_SERVER_COMMAND=$(getDefaultsValue 'mscs-default-server-command' '$JAVA -Xms$INITIAL_MEMORY -Xmx$MAXIMUM_MEMORY -jar $SERVER_LOCATION/$SERVER_JAR $SERVER_ARGS')
+DEFAULT_SERVER_COMMAND=$(getDefaultsValue 'mscs-default-server-command' '$JAVA -Xms$INITIAL_MEMORY -Xmx$MAXIMUM_MEMORY -Dlog4j.configurationFile=$HOME/log4j2.xml -jar $SERVER_LOCATION/$SERVER_JAR $SERVER_ARGS')
 # Each world server can override the default values in a similar manner by
 # adding certain key/value pairs to the world's mscs.properties file.
 #

minecraft@minecraft> mscs restart rickyninja
The cached copy of the version manifest is up to date.
Use the force-update option to ensure a new copy is downloaded.
Restarting Minecraft Server: rickyninjaSERVER_COMMAND: /usr/bin/java -Xms128M -Xmx2048M -Dlog4j.configurationFile=$HOME/log4j2.xml -jar /opt/mscs/server/minecraft_server.1.14.4.jar nogui
Erase is control-H (^H).
.

example of altered timestamp:
minecraft@minecraft> mscs console rickyninja
Connecting to server console: rickyninja.
   For help, type "help"
[2019-11-06 16:19:38 MST] [INFO]: Starting GS4 status listener
[2019-11-06 16:19:38 MST] [INFO]: Query running on <IP_ADDRESS>:25565
[2019-11-06 16:20:28 MST] [INFO]: UUID of player ricky_ninja is 2ca2332f-429c-46b9-926f-03f9d7dc8049
[2019-11-06 16:20:29 MST] [INFO]: ricky_ninja[/<IP_ADDRESS>:48136] logged in with entity id 541 at (-165.87925058759774, 64.0, -376.71651520180245)
[2019-11-06 16:20:29 MST] [INFO]: ricky_ninja joined the game
[2019-11-06 16:20:40 MST] [INFO]: ricky_ninja lost connection: Disconnected
[2019-11-06 16:20:40 MST] [INFO]: ricky_ninja left the game

Hi @rickyninja.
I think adding a $JVMARGS variable makes sense to make this use case easier.  This is a little convoluted in the code, so let me know if you have any questions why creating a PR. Look to the other variables, like $JAVA, for inspiration.

https://github.com/MinecraftServerControl/mscs/pull/228


Incorrect window size in dev mode

Description
If I run an application in dev mode (with yarn run dev), the browser reports (in fullscreen)  window.innerWidth = 2103 (my screen size is 1920) which causes incorrect size of the webpage in webview (the page is cropped).
If I build the application and run it, the page is displayed correctly. So I guess it is caused by some setting or plugin which is enabled in dev mode only.
How to reproduce
Create an app with a webview that occupies the whole page. For example, I open Google Inbox in webview and the right part with Compose button is not visible:
In dev mode

In production mode

Node version: v8.11.2
NPM version: 5.6.0
Operating System: fedora 28

What are the settings on your BrowserWindow object?

Nothing special, I hope!
    mainWindow = new BrowserWindow({
        width: 1200,
        height: 800,
        autoHideMenuBar: true,
});

Hmmm, how are you shrinking down the web page? Seems to me like you're getting some scaling in Chrome, which is why it's reporting the window width as wider than your monitor. e.g. if you zoom out by ~10% you'll get a number around 2100pixels.
Try adding this on the renderer thread:
var webFrame = require('electron').webFrame;
webFrame.setVisualZoomLevelLimits(1, 1);
webFrame.setLayoutZoomLevelLimits(0, 0);

(in src/renderer/main.js for example)

Hmm.. I have just cleared my profile directory and the issue is gone :/


Speedup PowApprox using faster methods with rounding differences in core loop

This is subtly state breaking, but helps speed up a very slow edge case query. And speeds up every invokation of this logic (which is non 50-50 balancer pools)
This can change rounding behavior of the final PowApprox result from +1 ULP to -1 ULP (or vice versa) due to very subtle rounding changes.
We only rely on this result being accurate to 1 ULP anyway though, and not on rounding direction. This is left unchanged.
This should cause no issues in production, for any balancer pool with non-zero spread factor. For a pool with zero spread factor, there could be a one time rounding error change, which could lead to a slight LP loss that I believe should at most be on the order of 0.0001%. However there is only one non-50/50 balancer pool on mainnet with a zero spread factor.
Benchmark improvement (Note: There are slower allowed queries in this)
OLD:
pkg: github.com/osmosis-labs/osmosis/osmomath
cpu: 13th Gen Intel(R) Core(TM) i7-1355U
BenchmarkSlowPowCases-12    	      18	  59050529 ns/op	 3763835 B/op	  168195 allocs/op

NEW:
BenchmarkSlowPowCases-12    	      38	  39404833 ns/op	 1000578 B/op	  125014 allocs/op

Summary by CodeRabbit

Refactor

Improved precision in mathematical calculations by adjusting the method used for term calculation in PowApprox function.

New Features

Introduced new functions for complex calculations involving precision adjustments.

Tests

Added tests for the new legacy multiplication operation to ensure accuracy and reliability.

Note tests are failing due to rounding behavior change
I'll try speeding up the mul mut's as well before fixing tests

Current speed on my laptop, with the improved LegacyMultiMulMut function. Almost a 4x speedup over the original, and allocs roughly halved. Bytes allocated is decreased as well. I think the CPU improvement of 2x and 30% lower alloc improvement means this should always be better than the version without LegacyMultiMulMut, even though it 3x'd the total bytes allocated.
BenchmarkSlowPowCases-12    	      69	  16325676 ns/op	 3108501 B/op	   86274 allocs/op

BenchmarkSlowPowCases-12    	      87	  15769120 ns/op	 3107894 B/op	   86270 allocs/op

Can you ping for review when tests are passing?

Legacy MultiMut is a pretty good idea, and can be of use in more spots across the repo. I don't have time to get this pushed through here, so going to close this PR.


Allow tweaking low-level RigidBodyBuilder

I'd like a capability to tweak RigidBodyBuilder's parameters at rigid body spawn time in an arbitrary manner.
My concrete interest for now is turning on ccd_enabled - but something else might be required later (I can imagine sleeping and related stuff).

Hi,
For each of theses needs (but only when actually needed), I would rather improve heron to add a dedicated component to the API. So for your current need we could feature a ContinuousCollisionDetection component. And we may add a Sleeping component when the need will arise for someone.
I understand it means that heron's is more limited, as one has to wait until heron add support for each feature.
But it is somewhat the point of this plugin. Users that want full power of rapier out-of-the box (at the cost of higher complexity) can use bevy_rapier, and the point of having heron as an alternative, is to provide a well-crafted data-oriented API (at the cost of being more limited).


I think test code might be ran more than once and that causes errors with values.

macros.lsp: test-log-form-and-value
The following macro fails the first test (which checks if the log is empty to start with).
(defvar *log-with-value* nil)

;; you must write this macro
(defmacro log-form-with-value (form)
  "records the body form, and the form's return value
    to the list *log-with-value* and then evalues the body normally"
`(let ((logform nil)
            (retval ,form))
    (push '(:form ,form  :value ,(eval form)) *log-with-value*)
    retval))

    (define-test test-log-form-and-value
    "log should start out empty"
        (assert-equal nil *log-with-value*)  => FAIL
      .....) => (FAIL PASS FAIL PASS PASS FAIL PASS PASS)

When I throw in a print statement within the test, it says that log-with-value is set to:
((:FORM (- 2013 1978) :VALUE 35))
Which would be the last value logged (hinting that the value is being carried over from the last time the test was ran).
By throwing a setf at the begginning of the test, ALL of the tests pass:
 (define-test test-log-form-and-value
        (setf *log-with-value* nil)
    "log should start out empty"
        (assert-equal nil *log-with-value*)  => PASS
      .....) => (PASS PASS PASS...)

I had a similar issue with other koans (though I don't remember which specifically). In those instances removing the print statements made the tests pass. However, this is not the case for this particular test. So I'm not sure if it's my macro or the test that is incorrect.

Just experienced the very same problem.  I think our macros are identical, though, so can't rule out that we're both making some mistake:
(defmacro log-form-with-value (form)
  "records the body form, and the form's return value
   to the list *log-with-value* and then evalues the body normally"
  `(let ((logform nil)
         (retval ,form))
     (push '(:form ,form :value ,(eval form)) *log-with-value*)
     retval))

I am not sure exactly what's going on (I'm still learning CL too!).
  That is a clue that there is another solution (that will work).

as astronaut-wannabe hinted at there are two local variables. I use both but also get the same result..
(defvar log-with-value nil)
(defmacro log-form-with-value (form)
`(let ((logform '(:form ,form :value ,(eval form)))
(retval ,form))
(push logform log-with-value)
retval))


Sample project outdated

Hey,
I've downloaded your sample project today.
There are two outdated methods in NavigationMetricsWrapper:
Error:(13, 66) error: method buildArriveEvent in class MapboxNavigationEvent cannot be applied to given types; required: String,String,String,double,double,String,String,int,int,int,Date,int,boolean,String,String,String,int,int,String,int,int found: String,String,String,double,double,String,String,int,int,int,Date,int,int,int,boolean,<null>,<null>,String,int,int,<null>,int,int reason: actual and formal argument lists differ in length Error:(48, 66) error: method buildDepartEvent in class MapboxNavigationEvent cannot be applied to given types; required: String,String,String,double,double,String,String,int,int,int,boolean,String,String,String,int,int,String,int,int found: String,String,String,double,double,String,String,int,int,int,boolean,<null>,<null>,String,int,int,<null>,int,int,int,int,int,Date reason: actual and formal argument lists differ in length
To run the project I just commended the lines in the two methods out. But this shouldn't be the solution ;)
Best regards
Patrick

Sry, wrong repo.


Unable to login after database update

Firstly, the instructions here are incredible. Thanks for making this so easy. I had everything running well in my installation where I could push my new theme and composer plugins to heroku, and login to WP Admin to change my theme. However I realised I forgot to run $ heroku run wp core update-db.
After doing this I see the login screen but upon entering my details it simply returns back to wp-login.php. I checked the Heroku logs and this is what I found (removed sensitive information and added line breaks for easy of reading):
WordPress database error INSERT command denied to user
<EMAIL_ADDRESS>for table 'wp_options' for query
INSERT INTO `wp_options` (`option_name`, `option_value`, `autoload`) VALUES ('nonce_salt', 'saltysaltysalty', 'no') ON DUPLICATE KEY UPDATE `option_name` = VALUES(`option_name`), `option_value` = VALUES(`option_value`), `autoload` = VALUES(`autoload`)
made by require('wp-load.php'),
require_once('wp-config.php'),
require_once('wp-settings.php'),
do_action('wp_loaded'),
WP_Hook->do_action,
WP_Hook->apply_filters, Jetpack->register_assets,
wp_script_is,
wp_scripts,
WP_Scripts->__construct,
WP_Scripts->init, do_action_ref_array,
WP_Hook->do_action,
WP_Hook->apply_filters,
wp_default_scripts,
wp_create_nonce,
wp_hash,
wp_salt,
update_site_option,
update_network_option,
add_network_option,
add_option

Clearing the redis cache doesn't seem to work either.
Other notes:

fresh install today
migrated a database from an existing wp installation (this could be it, however everything was running fine with the existing content and new theme before the problem occurred)

Any thoughts?

Okay I'm closing this. The problem is that the default JawsDB has a 5MB limit and it revokes the INSERT privileges after this. We should add a note in the readme for this one.


Review - Testing and Reproducibility

This PR contains responses to reviewer comments regarding the testing and reproducibility of MicroTracker.
Reproducible package manifests

Additionally, for the purpose of the paper, could the authors also document the versions of all dependencies used. For Julia dependencies this could be in the form of a (Julia)Manifest.toml. While this Manifest.toml should not necessarily be at the package root, perhaps it could be included in the paper directory. If a Project.toml is included along with this manifest, then the project could be activated and instantiated. To clarify, the purpose of this pair of Project.toml and Manifest.toml is needed to document the project used to generate the examples in the paper. Additonally, the versions of the Python packages should be documented. This could be done by exporting an environment.yml file via conda. Establishing the versions of all dependencies is required for future reproducibility.

Originally posted by @mkitti in https://github.com/openjournals/joss-reviews/issues/5804#issuecomment-1747573844
The Manifest.toml is now included in the paper directory. Is the Project.toml at the root of the package suitable, or should another copy be added to the paper directory?
The Python package versions are now documented in the form of a standard environment.yml, and included in the paper directory as suggested.
Test output with several warnings

After making sure that PyCall.jl and Conda.jl were properly configured I was able to execute the tests. The tests emit several warnings, and I would appreciate if the authors could discuss if these warnings are expected and how the user should respond to such warnings.

Test output with several warnings
Test Summary:       | Pass  Total  Time
numerical functions |    5      5  5.0s
Test Summary:      | Pass  Total  Time
FFT + line fitting |    6      6  2.2s
[ Info: New MicroTracker project created in /home/mkitti/review_temp/packages/MicroTracker/2n7hT/test/deletethis
[ Info: ImageJ macro created at /home/mkitti/review_temp/packages/MicroTracker/2n7hT/test/deletethis/imagej_macro.ijm. See MicroTracker segmentation docs for instructions on how to use it.
Test Summary:    | Pass  Total  Time
Project Creation |    7      7  1.4s
Test Summary:                  | Pass  Total  Time
Image loading and manipulation |   15     15  3.5s
Test Summary:    | Pass  Total   Time
Python functions |    6      6  10.5s
[ Info: Loading particle data for 5_13p5_61p35
[ Info:  -> looks like ImageJ data, extracting frame column and making X Y lowercase.
[ Info: adding info columns: ["B_mT", "FPS", "f_Hz"]
[ Info: adding info columns: ["B_mT", "FPS", "f_Hz"]
[ Info: Linking 5_13p5_61p35 ...
┌ Info:
│ Done! 54 trajectories present.
│ Filtered out stub trajectories < 0.5s resulting in 21 trajectories.
└
┌ Warning: Center point of trajectory 5_13p5_61p35-0 is out of bounds.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:254
┌ Warning: Snipped trajectory from 5_13p5_61p35-0 is now too short. Deleting.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:296
┌ Warning: Center point of trajectory 5_13p5_61p35-1 is out of bounds.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:254
┌ Warning: Snipped trajectory from 5_13p5_61p35-1 is now too short. Deleting.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:296
┌ Warning: Center point of trajectory 5_13p5_61p35-2 is out of bounds.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:254
┌ Warning: Snipped trajectory from 5_13p5_61p35-2 is now too short. Deleting.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:296
[ Info: Loading particle data for 5_13p5_61p35
[ Info:  -> looks like ImageJ data, extracting frame column and making X Y lowercase.
[ Info: adding info columns: ["B_mT", "FPS", "f_Hz"]
[ Info: Linking 5_13p5_61p35 ...
┌ Info:
│ Done! 54 trajectories present.
│ Filtered out stub trajectories < 0.5s resulting in 21 trajectories.
└
┌ Warning: Center point of trajectory 5_13p5_61p35-0 is out of bounds.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:254
┌ Warning: Snipped trajectory from 5_13p5_61p35-0 is now too short. Deleting.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:296
┌ Warning: Center point of trajectory 5_13p5_61p35-1 is out of bounds.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:254
┌ Warning: Snipped trajectory from 5_13p5_61p35-1 is now too short. Deleting.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:296
┌ Warning: Center point of trajectory 5_13p5_61p35-2 is out of bounds.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:254
┌ Warning: Snipped trajectory from 5_13p5_61p35-2 is now too short. Deleting.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:296
[ Info: Loading particle data for 5_13p5_61p35
[ Info:  -> looks like ImageJ data, extracting frame column and making X Y lowercase.
[ Info: adding info columns: ["B_mT", "FPS", "f_Hz"]
[ Info: Loading particle data for 5_13p5_61p35
[ Info:  -> looks like ImageJ data, extracting frame column and making X Y lowercase.
[ Info: adding info columns: ["B_mT", "FPS", "f_Hz"]
[ Info: Linking 5_13p5_61p35 ...
┌ Info:
│ Done! 54 trajectories present.
│ Filtered out stub trajectories < 0.5s resulting in 21 trajectories.
└
┌ Warning: Center point of trajectory 5_13p5_61p35-0 is out of bounds.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:254
┌ Warning: Snipped trajectory from 5_13p5_61p35-0 is now too short. Deleting.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:296
┌ Warning: Center point of trajectory 5_13p5_61p35-1 is out of bounds.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:254
┌ Warning: Snipped trajectory from 5_13p5_61p35-1 is now too short. Deleting.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:296
┌ Warning: Center point of trajectory 5_13p5_61p35-2 is out of bounds.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:254
┌ Warning: Snipped trajectory from 5_13p5_61p35-2 is now too short. Deleting.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:296
[ Info: Loading particle data for 5_8p4_28p68
[ Info:  -> looks like ImageJ data, extracting frame column and making X Y lowercase.
[ Info: adding info columns: ["B_mT", "FPS", "f_Hz"]
[ Info: Linking 5_8p4_28p68 ...
┌ Info:
│ Done! 18 trajectories present.
│ Filtered out stub trajectories < 0.5s resulting in 16 trajectories.
└
Test Summary:                | Pass  Total   Time
Particle data to linked data |   18     18  16.2s
┌ Warning: Center point of trajectory test-1 is out of bounds.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:254
┌ Warning: Center point of trajectory test-1 is out of bounds.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:254
┌ Warning: Snipped trajectory from test-1 is now too short. Deleting.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/linked_data.jl:296
Test Summary:       | Pass  Total  Time
Trajectory clipping |    8      8  0.7s
Test Summary:    | Pass  Total  Time
helper functions |    1      1  0.2s
[ Info: filtered trajectories 35 -> 21
Test Summary:  | Pass  Total  Time
Collapsed data |    9      9  8.3s
┌ Warning: framenumber 500 is greater than the last frame in the data, 340. Using the last frame instead.
└ @ MicroTracker ~/review_temp/packages/MicroTracker/2n7hT/src/plotting.jl:97
[ Info: Creating animation: Frame = 120
qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
┌ Warning: ffmpeg() is deprecated, use the non-do-block form
│   caller = ip:0x0
└ @ Core :-1
[ Info: Saved animation to /home/mkitti/review_temp/packages/MicroTracker/2n7hT/assets/test_animation.mp4
Test Summary: | Pass  Total   Time
plotting      |    7      7  17.5s
     Testing MicroTracker tests passed

Originally posted by @mkitti in https://github.com/openjournals/joss-reviews/issues/5804#issuecomment-1747623712
These messages are expected, so they shouldn't be listed as warnings. For messages that are expected but still useful to the user, the @info tag is now used. Additionally, to simplify the output of testing, the log level is lowered in runtests.jl to exclude info messages while still permitting warnings. This results in a cleaner output where the user can more easily tell if something is wrong.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4eb8548) 93.87% compared to head (7bd7992) 93.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           review      #49   +/-   ##
=======================================
  Coverage   93.87%   93.87%
=======================================
  Files           9        9
  Lines         408      408
=======================================
  Hits          383      383
  Misses         25       25

Files
Coverage Δ

src/linked_data.jl
90.43% <100.00%> (ø)

src/plotting.jl
88.60% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

The Manifest.toml is now included in the paper directory. Is the Project.toml at the root of the package suitable, or should another copy be added to the paper directory?

It would be convenient but not necessary to have the Project.toml there. The convenience is that one would be able to directly use Pkg.activate("paper") to enter the exact Julia environment used for the paper. As long as there is a git tag or hash available for the version at publication, the current situation should work.

It would be convenient but not necessary to have the Project.toml there. The convenience is that one would be able to directly use Pkg.activate("paper") to enter the exact Julia environment used for the paper.

Great, I added a copy of the Project.toml in the paper directory for convenience.


Fix failing completion tests in language server module

Description:
The tests disabled in following commit are failing. Please fix and enable.
https://github.com/ballerina-platform/ballerina-lang/pull/16268/commits/2110328129f0112c39792197d3bf42af19def46a
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Duplicate


Handle the case where "metadata" key is not present

In kub-prometheus-stack, there is a List entry which has no metadata field and this makes the plugin crash.
Proposal would be to update the Get function like so (in k8s.go, line 81):
func (name *Name) Get(dataMap string) (string, error) {
	var kindYaml map[string]interface{}
	if err := yaml.Unmarshal([]byte(dataMap), &kindYaml); err != nil {
		return "", err
	}

	if len(kindYaml) != 0 {

		metadata, metadataExists := kindYaml["metadata"].(map[string]interface{})
		if !metadataExists {
			return "", &ImageError{Message: "failed to get 'metadata' from the manifest"}
		}

		value, failedManifest := kindYaml["metadata"].(map[string]interface{})["name"].(string)
		if !failedManifest {
			return "", &imgErrors.ImageError{Message: "failed to get name from the manifest, 'name' is not type string"}
		}

		return value, nil
	}

	return "", nil
}

@sboutet06, may I know the steps to reproduce this issue?
can you pass on the value files to reproduce this?

Sure, you just need to add at least one entry in the addtionalServiceMonitors:
prometheus:
  additionalServiceMonitors:
    - name: "toto"


I'd like to be the maintainer (too)

Hey there! Thanks for volunteering. I've added you to this repo and to carmen.
Our most urgent needs are PR triaging and updates for Rails 4. Ping @CDainMiller, @ecbypi, or me if you have any questions and we'll try to help.

Hey J! Glad to have ya. :)
I agree with Jim, would be great to get some Rails 4 love.
Let us know if you have any Questions!

Hey guys,
Thanks for the add, I’ll try to contribute to this great project, and sure, I’ll start to work to implement the support for Rails 4. Let me know if have any other plan.
Greetings!

On Apr 15, 2015, at 6:04 PM, Dain Miller<EMAIL_ADDRESS>wrote:
Hey J! Glad to have ya. :)
I agree with Jim, would be great to get some Rails 4 love.
Let us know if you have any Questions!
—
Reply to this email directly or view it on GitHub https://github.com/jim/carmen-rails/issues/55#issuecomment-93592803.

Hi guys,
I want to ask you what is the development process I should follow, I mean, branch off from "master" and later create a PR to master or create a “develop” branch and the PRs to it and later to “master"? sorry to bother you guys, I’m doing some quick fixes to support Rails > 4.0
Thanks

On Apr 15, 2015, at 6:04 PM, Dain Miller<EMAIL_ADDRESS>wrote:
Hey J! Glad to have ya. :)
I agree with Jim, would be great to get some Rails 4 love.
Let us know if you have any Questions!
—
Reply to this email directly or view it on GitHub https://github.com/jim/carmen-rails/issues/55#issuecomment-93592803.

We haven't had a very formal process so far, but we typically do
development with PRs to master. In the past I have used longer-lived
development branches for big changes, but for most work it is probably
overkill.
Thanks for helping out, and feel free to ask any other questions!
--
Jim Benton
312-730-7550
On Fri, Apr 17, 2015 at 4:22 PM, Jonathan Tapia<EMAIL_ADDRESS>wrote:

Hi guys,
I want to ask you what is the development process I should follow, I mean,
branch off from "master" and later create a PR to master or create a
“develop” branch and the PRs to it and later to “master"? sorry to bother
you guys, I’m doing some quick fixes to support Rails > 4.0
Thanks

On Apr 15, 2015, at 6:04 PM, Dain Miller<EMAIL_ADDRESS>wrote:
Hey J! Glad to have ya. :)
I agree with Jim, would be great to get some Rails 4 love.
Let us know if you have any Questions!
—
Reply to this email directly or view it on GitHub <
https://github.com/jim/carmen-rails/issues/55#issuecomment-93592803>.

—
Reply to this email directly or view it on GitHub
https://github.com/jim/carmen-rails/issues/55#issuecomment-94096086.

Hi,
Working with Rails 4.2, I noticed that we need to do some changes to support it, some methods changed, etc. I was woking fixing the test build and for Rails 4.2 we need Nokogiri, etc., my question is, should we consider to create a rails4 branch? or should I try to find a way to make them fixed on master branch?
Thanks!

@jtapia, I started a branch to get tests working across different versions of rails: rails-testing. There are some issues with the Appraisal gemfiles on some builds (no clue why) and failures from removing byebug and debugger from the gemspec but not test_helper.rb.
Feel free to take a look.

Hi guys,
I sent a PR to add support for Rails 4.2, basically I started using Eduardo Gutierrez branch(rails-testing) and fix some things to run tests and everything is working well, I think it’s in good shape to be merged, could you take a look and tell me what do you think?
Thanks!


Add release coordination to CODEOWNERS based on AC assignments

@bot-gradle test and merge

I've triggered a build for you.


Link component in navbar ul

I'm using the Link component to populate the links in my site's navbar. It's great that the react-router link component automatically gives the appropriate link the class active.
However I'd like to nest this anchor tag within an unordered list and list item - ul > li > a
And then style the li when the anchor is a.active to let the user know where they are in the site. Sadly CSS has no parent selector, so the alternative is to do some hacky javascript to set the li that's a parent of the a.active link.
my code
  render: function() {
    var links = this.state.links;
    var val = links.map(function(link) {
        return (

            <Link to={ link.path }>{ link.name }</Link>

        );
    });

    return (

          { val }

    );

produces

  home

  connect

  blog

I'd like the first li to have a class of active as well.
could anyone advise on how to achieve my desired effect? I think navbars built around an unordered list is a common approach.

I wish I could write a bot that identifies this question :P
Check out the State mixin, the example does exactly what you want: https://github.com/rackt/react-router/blob/master/docs/api/mixins/State.md

great that works! Is there any way to get a # part of the url?
I have /,/#foo and /blog routes. The hash one is useful because it gets the browser to scroll directly to that section. Does this information ever reach the backend? if so any way to get it from the State mixin?

browsers don't send the hash part of a url to the server, no.


Structure of the instrument module

In my opinion having classes for the instrument description might be a nicer interface.
The different loading and writing functions could then be class methods and be used like this:
from ctapipe.instrument import InstrumentDescriptiion

instrument = InstrumentDescription.from_hessio('/path/to/file')
instrument.to_fits('instrument.fits')

agreed. This same concept is mentioned in #49

Similar to your example, this is from the discussion in #49 :
from instrument import OpticsDescription

od = OpticsDescription.from_file("test.eventio.gz")
od = OpticsDescription.from_metadata(obsid=123456, telid=56)