"Provide Feedback" doesn't work

Problem encountered on https://dotnet.microsoft.com/en-us/learn/aspnet/blazor-tutorial/create#
Operating System: windows
Steps to reproduce:
Go to https://dotnet.microsoft.com/en-us/learn/aspnet/blazor-tutorial/create#
Read article
Run into an issue
Press "I ran into an issue"
(An overlay opens with options "Report an issue" and "Provide feedback")
Press "Provide feedback"
Expected outcome
Any variation of feedback mechanism - texbox opens, default email program opens, windows help feedback app
Actual outcome
The "I ran into an issue" overlay closes.

You don't get this window then when you press Provide feedback?

I do not.

What browser and version are you using?

OS:  Windows 10.0.19045,
Browser: Edge 109.0.1518.55 (Official build) (64-bit)

extensions: uBlock Origin 1.46.0

Problem arises both with uBlock enabled and disabled, I haven't tried with uBlock entirely deleted

@Mehul I believe you use uBlock, no? Can you check if you can repro this problem?

I tested this on Mac Edge (with and without uBlock) and I can confirm that this is an issue as described. I also tested this on Safari with no extensions and it is an issue. Hope that helps.

I managed to repro by installing ublock origin on my Windows sandbox. Not in any other case. I'll reach out to the company who provides that control for us.

Glad to hear you're able to repro. You may want to check it on MacOS too.

I did using browserstack and didn't repro. Charging my mac now to try it on a real machine.

Did a quick safari recording if it helps: https://microsoft-my.sharepoint.com/:v:/p/mehulharry/ERlKInA1-HRAr12uuKO69MMBaWm7LIozzDOssO4dwxJpCQ?e=KwisNV
I am on a dual monitor setup and this only happens when I'm not on the main macbook screen. If I use the attached screens then it fails. Hope that helps.

I returned to the issue and re-tested.
With an updated browser ( now 112.0.1722.64 (Official build) (64-bit) ) and whatever updates happened on your end, my experience is:

uBlock disabled: Feedback form works as expected
uBlock enabled: Feedback form does not work.

As far as I'm concerned, the issue is fixed - I do not expect arbitrary websites to function when I'm running uBlock - but you may disagree about your own site so I'll leave it up to you whether you want to close the issue or not.


really fixed the json proublem this time. Also fixed the travis build

Fixed the json problem and the travis build.

:laughing: Nice one :+1:


Update xiami to 3.1.1-621

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thanks for the PR!


Can't see file downloaded in ios files app

I use this ->
await FileSystem.cpExternal(`${Dirs.CacheDir}/private_key_${fileName}.txt`,	`app_${fileName}.txt`,'downloads')
to download file in android and this -> await FileSystem.writeFile(`${Dirs.DocumentDir}/app_${fileName}.txt`, pk); to download in ios. Its says successful in both the cases. I can check the downloads directory in android and the file is indeed there but incase of ios I cannot see the file in files app. I have already enabled UIFileSharingEnabled and LSSupportsOpeningDocumentsInPlace in the Info.plist file. Tried using FileSystem.cp as well and also FileSystem.cpExternal for ios but no luck getting the file in files app. Am I missing something or we can't see the file in the files app at all?

Hmm, sounds like you did the correct steps...  You could try enabling UISupportsDocumentBrowser. Also, you could try rebooting the device. iOS sometimes fails to update app permissions in dev mode.
Is this simulator, or physical device?


API/method to overwrite specific request without using PUT api as it completely overwrites the entire data

This appends the supplied simulation JSON to the existing simulation data in Hoverfly. Any pair that has request data identical to the existing ones will not be added.
As per the documentation POST adds the supplied JSON, but lets say I have need to overwrite the existing content just for single request match NOT the whole simulations set, and API suitable for just this will be helpful.
We are looking for alternative to our existing mock solution. So in hoverfly we are looking for a way to not bring down a service and also NOT overwrite the whole set, but for something which can support multiple team members to use the same service in their own way. And many a times we end up changing the stubbed data, so we can not afford to overwrite and disrupt others.
If you have more questions, please let me know.

Hoverfly hardly takes any time to update the entire simulation data as it is in memory and takes exclusive locks before modifying the simulation data. It won't disrupt the other services but at times call will be slower.
You are probably asking for a PATCH call but there is no mechanism to identify that request/response pair.

@tommysitu  do you want to do this?

@tommysitu  do you want to do this?

We need a way to identify the request-response pair first. Have you got any idea?

@tommysitu we can add auto generated id to each request response pair and identify using the same. What do you say?

Hey guys, any update on this?

@tommysitu  what do you say about this?

we can add auto generated id to each request response pair and identify using the same. What do you say?

you can compute a hash code for the request struct and use the code for checking equality.

sure @tommysitu I can proceed in that way.

@atif-github-venture  I will start working on this and get back with more updates.

@kapishmalik what's your plan? Are you creating a new admin API or updating the POST simulation API?

@tommysitu I am planning to create new PATCH admin API endpoint to update a particular request. Shall I go ahead with that?

Yup, that's an idea. I will get back in few days with PR.


Interducing Arb-cells.tk (Help Needed)

in the frist i would thank u for making this cool server for us and i would say is our bots service are made with ur servers and i wanna ask u to help me with this problems frist on is when someone uses his skin from shop its shows for him but when some one look to him he didnt see it
2nd is could some one help me to put bots control in my ext the link for it is right here www.arb-cells.tk

Amazing, :D im wait @Megabyte918  accept!

@AlexByte918 Can you stop demanding people what to do. It seems wrong really. Be more respectful to the owner of this repo. He's a kind-hearted man. What do ever do to you?

@kareemman00 Your extension was originally Raga Minions , as they (Raga.pw) have full rights to the product they have the right to sue you . I do recommend you to take your extension down .

@FantasyIsBae That would make a crazy court case.
Judge: So, what do these bots do?
Raga.pw: We um. Lag Agar.io Servers and make profit from Miniclip's creation.
Judge: WAT!
Raga.pw: AND THESE KIDS ARE STEALING OUR ILLEGAL SOFTWARE.
Judge: Case Closed.

Well , thats not exactly true , obviously they have to say what their software does , but they still have authors rights , and as theres no source , they have a right to take legal action .

@Tyler3D

And im only reminding him as he doesn't know the legalities of copying software 😄

Oh yeah , please do NOT promote your extensions on here @kareemman00 , thanks

Fantasy


Where is setting.json?

https://github.com/Dickurt/vscode-php-formatter/wiki/Setup
I followed that link->Manual way, but I don't know where is setting.json.
Help me please.

On Windows/Linux - File > Preferences > Settings
On macOS - Code > Preferences > Settings


bug: slowly increasing time drift tampers with index look-ups

This PR is a collaboration between @lassulus and me.
When running Stenographer for a long stretch of time, Stenographer's time-based index look-ups get increasingly (though slowly) less accurate due to a clock skew affecting the timestamped index file names.
This error can be observed best, by tracking the difference between an index filename and its creation time over a long period of time (on our system we noticed ~ 5 seconds per day, but this will definitely vary between environments). Ultimately,  queries submitted via stenoread require an ever larger time-bracket for a successful response, though the actual packets returned will show the expected timestamp.
The time drift originates in using monotonic time measurements, i.e., CLOCK_MONOTONIC or rather CLOCK_MONOTONIC_RAW.  We suspect, that Stenotype's designers have deliberatly decided for this "nonstandard clock" mode to avoid index file collisions or index look-up inconsistencies due to a change of the system's clock time, e.g., by an inadvertent or careless user interaction. In a typical server-environment, time adjustments are supposed to occur in an orderly fashion only, e.g., via NTP.
The PR introduces the USE_CLOCK_REALTIME build flag to force a realtime clock read. We do not expect a performance hit as, e.g., Professional Linux Kernel Architecture, Mauerer, Wolfgang, Wrox, 2008, mentions only that

read[ing] the fine-grained time [...] is simple for the monotonic clock (the value delivered by the current clock source can be directly used), but some straightforward arithmetic is required to convert the value into the real system time.

This flag has been set in Stenotype's Makefile as a default; in case the original monotonic behavior is desired instead, this setting has to be actively overridden at build-time.

Interesting!  Would you consider the approach of adding a command-line flag to flip this instead of a #define?

It's funny you are asking. We were considering a command-line flag, but decided against it to keep the PR as small as possible.
We made an assumption about your use of a monotonic time measurement (see above), but would you mind sharing your thoughts, as to why someone might decide to flip this behavior?

Monotonic time was done to avoid duplicate file names, as you've guessed, and also because the Stenographer server determines what to keep/delete based on lexigraphical order of filenames.  So, if your clock jumped back really far, your "newest" files would be deleted to save on disk for the ones that looked newer based on filename.
That said, I'm pretty much fine with fully switching to clock time over monotonic; your bug on skew is totally understandable, and there's such a small probability of issue that I'm fine with having realtime be the default everywhere.

@googlebot I signed it!

@googlebot I fixed it.

We've tested this version on our side for several days in a row and achieved the desired result: w/o the time drift query look-ups benefit from the more accurate time brackets.
We agree, that it is hard to believe, a user would actively want to switch between the two modes. If you prefer, we could remove the build default.
Any second thoughts on your side?

Makes perfect sense.

Thanks for the help!


Can Streamplify be used to produce k-permutations of n?

Can Streamplify be used to produce k-permutations of n (https://en.wikipedia.org/wiki/Permutation#k-permutations_of_n)?
For instance:
P(n,r)=P(5,3)=5!(5−3)!= 60 (https://www.calculatorsoup.com/calculators/discretemathematics/permutations.php?n=5&r=3&action=solve)
Or for n = {Alice, Bob, Eve, Mallory} to produce P(4,2)=4!(4−2)!=12 results:
(Alice,   Bob)
(Alice,   Eve)
(Alice,   Mallory)
(Bob,     Alice)
(Bob,     Eve)
(Bob,     Mallory)
(Eve,     Alice)
(Eve,     Bob)
(Eve,     Mallory)
(Mallory, Alice)
(Mallory, Bob)
(Mallory, Eve)
Thank you.

Yes, it is possible. See this example.

Thank you for the prompt response.
This is indeed exactly what I was looking for.
I see that org.beryx.streamplify.permutation.Permutations already selects the right Permutations implementation depending on the permutation length, so I expect that it will support length greater than LongPermutations.MAX_LENGTH=20 but less then BigIntegerPermutations.MAX_LENGTH=20_000.
The example states

However, for improved performance, you may provide implementations based on the
org.beryx.streamplify.LongIndexedSpliterator and org.beryx.streamplify.BigIntegerIndexedSpliterator

Does it mean that there is another more efficient way of producing k-permutations of n that is different from this example and uses org.beryx.streamplify.LongIndexedSpliterator and org.beryx.streamplify.BigIntegerIndexedSpliterator? Is there an example for that anywhere?
Thank you.

I have tried it with small number of n & k and it worked fine. However when n is large it fails with "java.lang.OutOfMemoryError: Java heap space" and strangely is seems to be using org.beryx.streamplify.LongIndexedSpliterator and not BigIntegerIndexedSpliterator as I expected for n>20
I've added a sample repo https://github.com/LeonidShamis/NamesPermutations to demonstrate the issues.
In my program I get the (n) names from the input file and then produce k permutations of n names. I've tried with k=5 and 2 input files with 23 and 1700 names respectively.
When running with a smaller file (run.cmd 23_names.txt) it works, but when running with a larger file (run.cmd 1700_names.txt) it does not work even though I allocate really large heap:
...
...
k-permutations of n names from the input file 1700_names.txt
press any key to continue or Ctrl^C to exit...
Permutations on array length 1700
java.lang.OutOfMemoryError: Java heap space
Dumping heap to java_pid10216.hprof ...
Heap dump file created [1314200336 bytes in 9.657 secs]
Exception in thread "main" java.lang.OutOfMemoryError: Java heap space
at java.util.Arrays.copyOf(Arrays.java:3332)
at java.lang.AbstractStringBuilder.expandCapacity(AbstractStringBuilder.java:137)
at java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:121)
at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:421)
at java.lang.StringBuilder.append(StringBuilder.java:136)
at java.lang.StringBuilder.append(StringBuilder.java:76)
at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:457)
at java.lang.StringBuilder.append(StringBuilder.java:166)
at java.util.StringJoiner.add(StringJoiner.java:185)
at java.util.stream.Collectors$$Lambda$5/933699219.accept(Unknown Source)
at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at org.beryx.streamplify.LongIndexedSpliterator.forEachRemaining(LongIndexedSpliterator.java:167)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
at java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:270)
at org.beryx.streamplify.LongIndexedSpliterator.forEachRemaining(LongIndexedSpliterator.java:167)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
at permutations.ArrangementsStreamplify.main(ArrangementsStreamplify.java:72)

ArrangementsStreamplify(1700, 5) uses Permutations(5) and Combinations(1700, 5). In both cases a LongIndexedSpliterator can still do the job.
However, if you call ArrangementsStreamplify(1700, 6), you'll see in the stack trace that a BigIntegerIndexedSpliterator is needed for Combinations.
And if you call ArrangementsStreamplify(1700, 21), you'll see that a BigIntegerIndexedSpliterator is needed for both Permutations and Combinations.
The problem in your code is with the last collect in the statement below, which tries to join all arrangements into a single String:
System.out.println(new ArrangementsStreamplify(namesArray.length, 5)
    .stream()have
    .map(arr -> Arrays.stream(arr).mapToObj(i -> namesArray[i]).collect(Collectors.toList()).toString())
    .collect(Collectors.joining("\n")));

With 1700 names and k=5 you have 1700!/(1700−5)! arrangements, which is a 16-digit number.
By joining the representations of all these arrangements you end up with a string that exceeds your computer's memory.
The solution is to print each arrangement at the moment when it is retrieved from the stream.
(Streamplify doesn't store the stream elements in memory, it generates them one by one when needed.)
Stream<String> permStream = new ArrangementsStreamplify(namesArray.length, 5)
    .stream()
    .map(arr -> Arrays.stream(arr).mapToObj(i -> namesArray[i]).collect(Collectors.toList()).toString());
permStream.forEach(System.out::println);

Due to the huge number of arrangements, it will take extremely long to print all solutions, but the program should work with even much bigger lists of names,
Currently, there is no other another more efficient implementation for producing k-permutations of n.
An implementation based on the LongIndexedSpliterator and BigIntegerIndexedSpliterator implies coming up with efficient algorithms for the methods computeNext() and unrank(). I expect the unranking part to be quite tricky.  It's an interesting intellectual challenge, but for practical purposes the performance gain would probably be negligible.

Brilliant!
Hardly using any heap. I have also changed it slightly to use parallelStream() instead of stream() for multi-core parallel stream.
Great project - (many) Star(s) project.
Thank you so much!!


Is there any way to avoid multiple duplicate lines regex match?

just like https://github.com/VirusTotal/yara/issues/504
when I use regex rule in yara, it match the same line multiple times. How to avoid it or is there any usage for this condition?

Can you provide some example of a rule, input file and results you are expecting?

rule $re = /ab.{,4}/
match result:  abc ab. ab.c ab.cd
desired result: the longest match, like ab.cd


Update for readme template (removes build command and adds support section)

Why should creating the documentation be interesting for the end user? The user wants to read the documentation and not create it himself.
Preview:

{repo}

This library provides ...
Installation
Run the following to install this library:
$ composer require {org}/{repo}

Documentation
Browse the documentation online at https://docs.zendframework.com/{repo}/
Support

Issues
Chat
Forum

I agree, you read the docs online. Even if you made changes to the docs for a PR, you don't need to build the docs.

Thanks, @froschdesign.


Use go 1.23.4

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.02%. Comparing base (6a1918b) to head (be0f9b8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1214   +/-   ##
=======================================
  Coverage   95.02%   95.02%
=======================================
  Files         104      104
  Lines       12556    12556
=======================================
  Hits        11931    11931
  Misses        475      475
  Partials      150      150

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


i18n(es): translate link-buttons

Description

What does this PR change? Give us a brief description.
Translates link-buttons to spanish.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

es
components/link-buttons.mdx
Localization added, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


distributed architecture and preparation for higher load

Hey,
I've been tasked with implementing a production-ready Chia pool for one of my clients (actually may be more than one, demand on chia pools seems to be at an all-time high!), but during review of the code in this repository a pattern quickly emerged. There is a separate object responsible for persistence. By default it uses sqlite, which can only handle a few transactions per second and a real pool could use a different database in place of the sqlite, by implementing PoolStore interface. That got us thinking. What if the implementation of that class didn't really do anything, but instead it would relay all the calls to a REST API backend? Then you could write that backend in whatever programming language you'd like, you could deploy it on a serverless platform, the new cloudflare worker edge computing thing and you could scale the resources for it separately from the pool-reference code.
It would not be a lot of work and it would allow people who use php, java, .net etc to implement pools. I heard that the chia core team would like to have a good ecosystems of pools. Making it more accessible to software developers of the world seems like a step in the right direction.
There are a couple of things that would need to be factored out to the REST API backend that are not in the PoolStore interface, specifically I'm thinking about the difficulty adjustment algorithm... But that's also not a lot of work.
I would like to inquire - would a PR adding (optional) REST API backend architecture be welcome? We'd refactor the PoolStore thing to become an abc.abcmeta AbstractPoolBackend, which would only have empty methods describing the interface, and we'd move the current PoolStore to SQLitePoolBackend or SimplePoolBackend or something like that, maintaining the current functionality of the system, just moving the code around a little bit. Finally (in a separate PR), we'd add a RESTPoolBackend or HttpPoolBackend which would use simple rpc-like calls to enable pool logic to be handled by a separate host. Nobody would be forced to use RESTPoolBackend if they didn't want to. People could easily add ZeromqPoolBackend, XMLRPCPoolBackend, ThriftPoolBackend, gRPCPoolBackend and all kinds of things if they wanted to, once our first PR is in (not necessarily making them opensource, but hopefully they'd share it).
We have to get it done one way or another. Fortunately I can make the REST API changes opensource, the only question now is whether I can work within the pool-reference code to make it available to everyone, or is this not the right place for this sort of flexible backend layer?

Hi @ppolewicz! Thank you for your post.
I think that the performance of sqlite is probably sufficient for this use case, up to a pretty large pool size. Sqlite can do many thousands of transactions per second if it is configured properly. Of course this would require some tweaking, since we didn't do any performance testing.
That said, I understand that some people might prefer other databases or solutions. I would be open to looking at a PR, but cannot commit to merging it at this point. Thank you for making your work open source

god almighty. serverless madness

@mariano54 I've submitted a PR that introduces these changes: https://github.com/Chia-Network/pool-reference/pull/99


Make dask submits/maps indicate that we are not using pure functions.

EAs fitness function are never pure, and we need to tell dask that.
https://distributed.dask.org/en/latest/client.html#pure-functions-by-default

This may be having an impact on Summit performance.  We'll see shortly if that's the case after making these changes and testing them there.

Done and tested.  And I figured out that some of my earlier woes with imports had to do with dask.distributed imports not working suddenly when importing from just distributed was preferred.


Running zend-xmlrpc without BigInteger

[ x] I was not able to find an open or closed issue matching what I'm seeing.
[ ] This is not a question. (Questions should be asked on chat (Signup here) or our forums.)

I was trying to use zend-XMLRPC today and I was receiving data back with type i8 from the XMLRPC server. As noted here, an i8 is a 64-bit integer. I am running the XMLRPC client on a 64-bit machine, where PHP_INT_MAX is<PHONE_NUMBER>854775807, and I feel that using BigInteger is not required in this situation.
Would it be possible to add some sort of flag or configuration option, or perhaps detect if the machine is 64-bit, and in that case disable BigInteger support and simply use PHP's native integer for XMLRPC i8 types?
Code to reproduce the issue
// See https://github.com/zendframework/zend-xmlrpc/blob/9f1bf634995d0956fb1af9f63e394787c1211594/src/AbstractValue.php#L193

Expected results
BigInteger is not required on a 64 bit machine
Actual results
Error "Big integer math support is not detected" since either gmp or bcmath module is not installed.

Please see https://github.com/zendframework/zend-xmlrpc/pull/40

This repository has been closed and moved to laminas/laminas-xmlrpc; a new issue has been opened at https://github.com/laminas/laminas-xmlrpc/issues/1.


Text watcher

I decided not to merge :-( Seems like there're too many changes and not so many features. Seems like the behaviour is completely different :-( Perhaps, next time? :-/


Wave client disconnected

Ubuntu 22.04 I've got the dialog window with logs:
[2023-11-25 16:50:17] try reconnect (1)
[2023-11-25 16:50:17] connection error/disconnected
[2023-11-25 16:50:17] sleeping 2s
[2023-11-25 16:50:19] try reconnect (2)
[2023-11-25 16:50:19] connection error/disconnected
[2023-11-25 16:50:19] sleeping 5s
[2023-11-25 16:50:24] try reconnect (3)
[2023-11-25 16:50:24] connection error/disconnected
[2023-11-25 16:50:24] sleeping 10s
[2023-11-25 16:50:34] try reconnect (4)
[2023-11-25 16:50:34] connection error/disconnected
[2023-11-25 16:50:34] sleeping 10s
[2023-11-25 16:50:44] try reconnect (5)
[2023-11-25 16:50:45] connection error/disconnected
[2023-11-25 16:50:45] sleeping 30s
[2023-11-25 16:51:15] try reconnect (6)
[2023-11-25 16:51:15] connection error/disconnected
[2023-11-25 16:51:15] sleeping 60s
Nothing helps with it.

Thanks for submitting.  This usually means the golang backend of the application crashed for some reason.  Can you look at the end of ~/.waveterm/wavesrv.log .  If you see any errors in there (or stack traces) can you post them?

Hi, I have the similar issue:

waveterm-linux-x64-v0.5.0/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by waveterm-linux-x64-v0.5.0/Wave-linux-x64/resources/app/bin/wavesrv)

thanks for the log entry, really helpful!  will work on resolving this dependency issue

good write up of what i think is going on:
https://utcc.utoronto.ca/~cks/space/blog/programming/GoAndGlibcVersioning
putting it here for my reference to fix.

This is problematic. Linking to glibc 2.34 breaks compatibility with (for example) Debian Bullseye LTS. Please link to 2.31 instead.

waveterm-linux-x64-v0.5.0/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by waveterm-linux-x64-v0.5.0/Wave-linux-x64/resources/app/bin/wavesrv)

Same problem here. Unable to run Waveterm. Linking to glibc 2.34 breaks compatibility with (for example) Debian Bullseye LTS. Please link to 2.31 instead.

 NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133858.415776:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133858.417125:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133858.417174:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133858.417196:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133858.417219:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133858.417273:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133858.417292:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133858.419976:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133858.420057:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133859.124774:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133859.124881:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133859.126486:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133859.126523:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133859.126536:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133859.126598:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133859.126632:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133859.126646:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133900.607230:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133900.607280:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133900.608557:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133900.608578:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133900.608591:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133900.608606:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133900.608620:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133900.608632:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133900.612844:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry! [2578706:1128/133900.612911:ERROR:check.cc(297)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry!

/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/gxon/UOS/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv)
/home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/gxon/Program/Wave-linux-x64/resources/app/bin/wavesrv)

Okay, so there are two issues here.  One for waveshell/mshell and one for wavesrv.
I've fixed the waveshell issue.  There we weren't explicitly setting CGO_ENABLED=0, and when not cross compiling it gets defaulted to 1.  Since there are no CGO dependencies for waveshell, we now have a nice static binary that doesn't depend on glibc.  This is now checked in to main and will go out with v0.5.1.
The wavesrv problem is harder to solve because we're using sqlite3 for data storage, meaning we need CGO and that causes dynamic linking.  I have some leads though.  It might be possible to link sqlite3 and still get a static binary.

Same issue here:
/home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv)
/home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv)
/home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv)
/home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv)
/home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv)
/home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/amir/Desktop/Wave-linux-x64/resources/app/bin/wavesrv)

This should be fixed in v0.5.1.  For the Linux builds I've switched both wavesrv and waveshell to be statically linked so there should be no glibc version issues.

@sawka , thanks, able to launch the application now.

i am facing the same issue

i am facing the same issue in version 0.5.3
/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34'

So am I... (I am running it via WSL though)


Allow change history to be expanded with JS

**REVIEWERS: I'm not really happy with the way I've written these tests, and would appreciate any ideas how I can make them a bit better. Also, I'm not 100% happy with looping through the items twice in the view, but perhaps this has to be done because each set of items should be in a different unordered list.
**
This exists because we are going to show page history in Service Manual guide pages: https://trello.com/c/qzHbv9S9/181-show-change-notes-and-page-history-at-the-bottom-of-guidance-page
Allow change history to be expanded with JS
When using the document_footer component, you can now pass in
expand_full_history.
This will cause only the first history item to be shown, and a link will
allow you to show the rest of the history items. This uses javascript
toggle.
Before expand has been clicked:

After expand has been clicked:

For any change to a component it's good to include updated fixtures and screenshots to demonstrate the changes - and makes them easier to review. Could you add those and i'll have a look at the actual changes?

@dsingleton Thanks, doing that now.

@dsingleton Updated docs and added two screenshots

Having a toggle that shows content above the link feels counterintuitive.
We have this pattern elsewhere:

https://www.gov.uk/government/consultations/property-ownership-and-public-contracting-by-foreign-companies-improving-transparency

@fofr I tend to agree. I'll move it.

+1 to be consistent with existing GOV.UK patterns, even if they're not a component yet, they'll have been battle tested/researched/etc. It'd be worth checking if there are any other similar patterns of page history on other parts of GOV.UK too.

Added a few comments, hopefully they make sense, if not i'm happy to chat about them.
Some of the things I mentioned should definitely be documented, because they're not intuitive right now, and i'm hoping to find time to do that soon, so apologies :)

@dsingleton Thanks. If you let me know the things you want documented I'll add them in when I get a chance!

@dsingleton Thanks. If you let me know the things you want documented I'll add them in when I get a chance!

No worries - it's actually on a team backlog to make space/time for me to do it, but i'd appreciate feedback when I do :)

@dsingleton I've made the changes you suggested in a second commit, though please don't merge this because I would prefer squashing that commit with the former.

Core Formats team have some work in progress to migration detailed guides, which will need a pretty similar pattern for expanding change history (example).
It'd be good for someone working on that to review this and make sure it supports both service manual and the version being migrated - consolidating any differences in the process. That'll most likely be @tvararu or @binaryberry.
@AndrewVos: That work should be happening soon, but let us know if waiting for Core to look at the component is going to hold you up?

Had a chat offline and we agreed the easiest way forward will be for the service manual to duplicate the bits of document_footer it needs in it's frontend and modify them there - and not be dependant on the component right now.
This gives service manual team a bit more freedom, and core formats can add the functionality we need separately.


chore(dist): fix release

fixes #430 and #432. This uses the generated lib files when requiring/importing from npm module (not not using treeshaking (webpack1)). This does NOT fix the dist/ files (such as the UMD build) being generated incorrectly.

👍

Hi, when will this fix be merged/released?

@eddywashere is this going to be tagged as a release?

@will-stone @th3fallen 4.6.2
thanks again @TheSharpieOne!

@eddywashere thanks for that, have you received this error since the release?    Cannot find module 'react-transition-group/TransitionGroup' from 'Modal.js'

@th3fallen not seeing that output in tests. the peer deps recently changed. Can you make sure react-transition-group is installed? New install instructions are: npm install --save reactstrap react-transition-group react react-dom. feel free to update changelog with this upgrade info if it helps.

yeah, that was it manually installing fixed, it i was literally on the way here to post that but you beat me to it.

This fix is incorrect. By pointing it at the lib, you're now having people include a 300kB version of Reactstrap instead of 91kB. Each individual lib file contains a copy of the React helpers, resulting in their size being ~3x as big.
#474 is the right fix. I will include a revert of this PR in that fix.

@balloob that is incorrect, as reference please see every other library ever made. For those using non es modules, this is the way it is done. There is another property in the package.json for es modules.


Change the default finite element state to be scalar-valued

This changes our default finite element state to be scalar valued. This is more in line with MFEM and other finite element libraries.

LGTM

LGTM

Codecov Report

Merging #349 (b24cec7) into develop (d42a585) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #349      +/-   ##
===========================================
+ Coverage    90.87%   90.89%   +0.02%
===========================================
  Files           43       43
  Lines         1787     1791       +4
===========================================
+ Hits          1624     1628       +4
  Misses         163      163

Impacted Files
Coverage Δ

...c/serac/physics/utilities/finite_element_state.hpp
88.88% <ø> (ø)

src/serac/physics/elasticity.cpp
92.98% <100.00%> (+0.12%)
:arrow_up:

src/serac/physics/nonlinear_solid.cpp
97.00% <100.00%> (+0.04%)
:arrow_up:

src/serac/physics/thermal_conduction.cpp
93.25% <100.00%> (ø)

...c/serac/physics/utilities/finite_element_state.cpp
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42a585...b24cec7. Read the comment docs.

Codecov Report

Merging #349 (b24cec7) into develop (d42a585) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #349      +/-   ##
===========================================
+ Coverage    90.87%   90.89%   +0.02%
===========================================
  Files           43       43
  Lines         1787     1791       +4
===========================================
+ Hits          1624     1628       +4
  Misses         163      163

Impacted Files
Coverage Δ

...c/serac/physics/utilities/finite_element_state.hpp
88.88% <ø> (ø)

src/serac/physics/elasticity.cpp
92.98% <100.00%> (+0.12%)
:arrow_up:

src/serac/physics/nonlinear_solid.cpp
97.00% <100.00%> (+0.04%)
:arrow_up:

src/serac/physics/thermal_conduction.cpp
93.25% <100.00%> (ø)

...c/serac/physics/utilities/finite_element_state.cpp
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42a585...b24cec7. Read the comment docs.

LGTM

LGTM

LGTM

LGTM

@jonwong12 @samuelpmishLLNL could you take a look at this?

LGTM

LGTM

LGTM


Fix misalignment of the OAuth buttons

Description
It fixes the improper alignment of the UI of the OAuth buttons in login page.
Fixes #137
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Responsive Testing?
(Only applicable for Frontend changes)
Checked for: (width in px)

[x] Laptop L - 1440px
[x] Laptop - 1024px
[x] Tablet - 768px
[x] Mobile M - 375px

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in modules

Screenshots:

Note for Reviewer:
The Login button is misaligned and needs to be centered. The OAuth buttons are centered according to the container.

Hey, the issue was to fix the UI. Since you've aligned it better, can you also fix the "Login" button's alignment and the "new user signup" text too

I made the necessary changes. I updated the screenshots as well. I also fixed another issue in login page in the last commit where the heading text was being overlapped by navbar. Please take a look.

Hey @j-mahapatra, can you also convert the page into tailwind? Like remove the css file for this

Can you create a separate issue for converting the CSS into tailwind? You can assign me to it.

Looks like this messed up the Signup Page

Can you create a separate issue for converting the CSS into tailwind? You can assign me to it.

sure

Yes, the signup page is also using the 'login-container' class. I removed it on instinct because of its name. I will fix it in a minute.

Can you create a separate issue for converting the CSS into tailwind? You can assign me to it.

#140

Join us on Discord for better discussion.

@pranshugupta54 i am working on this,will update soon..

Hey @j-mahapatra, did you fix it?

I was caught up with something. I will push the final commit soon.

Hi @pranshugupta54, I made the changes as required and updated the PR description with new screenshots. Please take a look.

Hey @j-mahapatra, we're getting a small right gap in this (on Login Page, works fine for signup)

I made a small change to manage overflows in the login container which is fixing the above issue. Please take a look.

You can also use same design for Signup Button like Login

Also add a line like "Already registered? Login"

{error} div needs some fix
When there's an error to authenticate, the div is changing alignment too

@j-mahapatra, we're getting a horizontal scroll on Mobile - S
Preview: https://deploy-preview-139--v2-digitomize.netlify.app/login

https://github.com/digitomize/digitomize/assets/76090263/7e206217-fe70-41f8-9e03-f5200df31677

[ ] Input boxes are increasing in size

https://github.com/digitomize/digitomize/assets/76090263/369071ed-ce31-4661-8242-5ecb8a456894

The input box size increase issue is not happening on my end.
https://github.com/digitomize/digitomize/assets/107102771/500cec27-edbc-4099-b13d-ef591bc49fd3

I'm getting this in Brave and Chrome (in Mac)

Basically the input fields have w-full 🤔, so when the parent-parent div changes size due to error, it increases the width too.
Just try if you can fix this otherwise we'll merge it.

I am still not able to replicate the above issue on my device. I understood why it is happening in the video that you have shared but it doesn't occur on my end for some reason. Should I just set a fixed width for the input containers?

Yes, you can set fixed widths (depending on screen size)

I have made a simple change that should fix the issue. I am not able to test it because I am not getting the behavior that we are discussing. Please check it on your end once.

@j-mahapatra Perfect 🎉

Thank you so much for fixing this!

is this done ?

hey @inbuilt-aura, this is done and merged!

@all-contributors please add j-mahapatra for code


support config sidecar pod resource

Can we provide a way to config the sidecar container resource or set a default resource? In some scenes, the pod is requested to have a resource config, eg. a namespace with quota configured,  every pod in the namespace need to have the config resource section.
example config:
--PodQuota=0.5c,512m

Resolved in #552


Varargs support for parameters

Closes #148

LGTM

Uh oh, this collides with my intention to kill nearly every class with the *Writer suffix. Though I can certainly bring this along.

Yeah. Just unblocking ourselves on current JW3 usage. Keep killing.

Please do! I'm trying to mass generate lots of classes with varargs.


Most creatures don't work - error reading 'match'

Trying to use the module and almost any combination of creatures I try gives me a blank list of friendly and hostile combatants and the following error in the console:
ActorUtils.js:919 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'match')
    at ActorUtils.getDamageWithResistance (ActorUtils.js:919:37)
    at ActorUtils.getInfoForAttackObject (ActorUtils.js:1048:47)
    at CombatEstimateDialog.getActorCombatSummary (dialog.js:154:18)
    at CombatEstimateDialog.populateCombatants (dialog.js:91:33)
    at CombatEstimateDialog.activateListeners (dialog.js:37:8)
    at CombatEstimateDialog._render (foundry.js:3090:10)
    at async CombatEstimateDialog._render (foundry.js:3764:5)

It does work with some combinations of monsters. I added one PC and this Polar Bear and it caused the error. Attaching the json for reference
fvtt-Actor-polar-bear.txt
.

After some further investigation the cause appears to be attempting to match on enemyTraitsObject.dr.custom and enemyTraitsObject.di.custom when those values are null. If you add an if statement checking if they are null before attempting to the do the match, it works fine. There are 4 incidents of this in ActorUtils.js

Fixed with this release.
https://github.com/etriebe/combat-estimate/releases/tag/1.0.22


fix(Variance): Add better prop sorting tests

Overview

Found some borked behavior with the previous tests just being wrong
Added a better safeguard here for shorthand properties and a more exhaustive test to ensure that the most general shorthands are ordered first to ensure the cascade behaves as expected border is above borderColor to prevent incidental overrides.
This ensures that within the same scope worrying about the cascade is not important.  This is necessary to determine due to composition being ad hoc, having predictability when users may not have full access to cascading beyond merge order.

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.9.10-alpha.748ee8.0@codecademy/gamut-kit@0.3.8-alpha.748ee8.0@codecademy/gamut-labs@13.3.8-alpha.748ee8.0@codecademy/gamut-styles@9.3.1-alpha.748ee8.0@codecademy/gamut-tests@2.3.7-alpha.748ee8.0@codecademy/gamut@29.9.3-alpha.748ee8.0@codecademy/konamimojisplosion@0.2.7-alpha.748ee8.0@codecademy/markdown-overrides@0.5.20-alpha.748ee8.0@codecademy/styleguide@33.8.5-alpha.748ee8.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6070b925b7ad0d4bc670e167--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.9.10-alpha.262401.0@codecademy/gamut-kit@0.3.8-alpha.262401.0@codecademy/gamut-labs@13.3.8-alpha.262401.0@codecademy/gamut-styles@9.3.1-alpha.262401.0@codecademy/gamut-tests@2.3.7-alpha.262401.0@codecademy/gamut@29.9.3-alpha.262401.0@codecademy/konamimojisplosion@0.2.7-alpha.262401.0@codecademy/markdown-overrides@0.5.20-alpha.262401.0@codecademy/styleguide@33.8.5-alpha.262401.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6070c2d1fa22a45f1c4a9fc6--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.9.10-alpha.1b5e69.0@codecademy/gamut-kit@0.3.8-alpha.1b5e69.0@codecademy/gamut-labs@13.3.8-alpha.1b5e69.0@codecademy/gamut-styles@9.3.1-alpha.1b5e69.0@codecademy/gamut-tests@2.3.7-alpha.1b5e69.0@codecademy/gamut@29.9.3-alpha.1b5e69.0@codecademy/konamimojisplosion@0.2.7-alpha.1b5e69.0@codecademy/markdown-overrides@0.5.20-alpha.1b5e69.0@codecademy/styleguide@33.8.5-alpha.1b5e69.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6070ca40144bb400a470885a--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.9.10-alpha.d797d7.0@codecademy/gamut-kit@0.3.9-alpha.d797d7.0@codecademy/gamut-labs@13.4.1-alpha.d797d7.0@codecademy/gamut-styles@9.3.1-alpha.d797d7.0@codecademy/gamut-tests@2.3.7-alpha.d797d7.0@codecademy/gamut@29.9.3-alpha.d797d7.0@codecademy/konamimojisplosion@0.2.7-alpha.d797d7.0@codecademy/markdown-overrides@0.5.20-alpha.d797d7.0@codecademy/styleguide@33.9.1-alpha.d797d7.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6070cc35d2f5ec00a52af474--gamut-preview.netlify.appDeploy Logs


fix(client): Fix typescript issue in the Attachment model

Fixes
Motivation
This PR addresses an inconsistency in the TypeScript type definition for the Attachment model that prevents proper use of TypeScript with the library.
Issue
The Attachment model's TypeScript type definition does not match the expected data structure for the SendGrid API. Specifically, the contentId field should be content_id to align with the API requirements. This discrepancy does not impact JavaScript users but hinders TypeScript usage by causing type errors.
Solution
I store attachment details in the appropriate class with the toJSON method to ensure the content_id field is correctly included in the API request payload.
Also, I added tests to confirm the content_id field is correctly handled and included in the API request payload.
Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the Contribution Guidelines and my PR follows them
[x] I have titled the PR appropriately
[x] I have updated my branch with the main branch
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added the necessary documentation about the functionality in the appropriate .md file
[ ] I have added inline documentation to the code I modified

I've just hit this issue... what needs to happen to get this PR reivewed?

I do not know. @thinkingserious can yo suggest?

Review in progress.


Allow setting custom_tags for traces

It allows setting trace tags based on literal values, environment variables, or request headers.
Based on https://www.envoyproxy.io/docs/envoy/latest/api-v3/type/tracing/v3/custom_tag.proto#custom-tag
tag_headers should be deprecated in favor of custom_tags. I haven't worked with CRDs and field deprecations. What's the procedure?
When it comes to updating the documentation, where is that handled? I cannot find any reference to TracingService inside the docs folder.

Hey @psalaberria002! As I understand it:

Any TagHeader can be expressed as a CustomHeader, but not the other way around; and
Transforming a TagHeader to a CustomHeader is trivial and mechanical.

That implies to me that the best answer here is:

v3alpha1 should consider TagHeader to be deprecated

if only CustomHeader is set, great
if only TagHeader is set, translate to CustomHeader
if both TagHeader and CustomHeader are set, log a warning, ignore TagHeader, and use CustomHeader
you should rename the TagHeader field internally to DeprecatedTagHeader, but leave the JSON tag as TagHeader

v2 should gain a V3CustomHeader field, used only for translations

When translating from v3alpha1 to v2:

the v3alpha1 CustomHeader field should be saved unaltered as the v2 V3CustomHeader field

When translating from v2 to v3alpha1:

if v2 V3CustomHeader is set, it should be copied unaltered to v3alpha1 CustomHeader
otherwise, if v2 TagHeader is set, it should be translated to v3alpha1 CustomHeader
the translation code must never set v3alpha1 DeprecatedTagHeader

In v3 final, the DeprecatedTagHeader field will go away.

How does that sound?

Makes sense. I have tried to follow that approach in the last commit. It would be nice to have CI for this PR :)

@psalaberria002 - Thanks for being patient on this. With the recent release master has diverged quite a bit. Can you please rebase this back on master and push it. I will then get CI running on it.
Note: it's probably good to run git fetch origin --prune to ensure you are not holding onto any old refs for master before re- pulling it. I had that issue ☹ .

Already pulled from master, cherry picked my change, and force pushed.

@psalaberria002 - lets get this rebased on master and update the release notes so that it will land on the upcoming 3.1.0 release. Once that is done I will pull it in and get CI running to make sure all is still green. I want to get a second review from one of the teammates as well.
Again thanks for the patience on this.

@psalaberria002 - lets get this rebased on master and update the release notes so that it will land on the upcoming 3.1.0 release. Once that is done I will pull it in and get CI running to make sure all is still green. I want to get a second review from one of the teammates as well.
Again thanks for the patience on this.

Rebased. I am not able to run tests locally. It would be great if you could run this in CI.

@psalaberria002 - Landed this in https://github.com/emissary-ingress/emissary/pull/4268 per our discussion in slack. Closing this one out.


Use actual versioning instead of asserting it

The version ppx allows you to write deriving version {asserted} for a type, which generates definitions so that the type appears to be versioned. Except for test code, it's a goal that the codebase not contain any uses of asserted.
To find such uses, run:
git grep -n "version {asserted}" | grep -v ppx_coda

If you remove the asserted option from version, Merlin should indicate what part of the type still needs versioning.

Mostly done, except for crypto (types that rely on Field.t and Proof.t).

Issue #1010 is about versioning Snarky types, which we don't have a story for.

Done, except for some crypto types where it's unavoidable.


URL not parsed when it starts with double slash

I was trying to generate a URL with the url function sending a param which starts with double slash the url function just return the same param.
$url = url('//uploads/brand_1/cWWvlh3JBn3k0HqA.mp4');
outputs: //uploads/brand_1/cWWvlh3JBn3k0HqA.mp4
But i think this is not the real problem, cause I was forming that path with the following flow:
$absolutePath = public_path('/uploads/brand_1/cWWvlh3JBn3k0HqA.mp4');
outputs: /home/user/dev/project/public//uploads/brand_1/cWWvlh3JBn3k0HqA.mp4
Then in another method I move the file to another location and return its http url.
return url(str_replace(public_path(), '', $absolutePath));
outputs: //uploads/brand_1/cWWvlh3JBn3k0HqA.mp4
It will be nice if public_path(), storage_path(), config_path(), url() generate the path replacing the double slash to just one slash.
By now I'm replacing the public_path() and the double slash like this:
return url(str_replace([public_path(), '//'], ['', '/'], $absolutePath));
outputs: https://localhost/project/uploads/brand_1/cWWvlh3JBn3k0HqA.mp4
Using Laravel 5.2

Why do you want to add / at the beginning of the path?
public_path('uploads/brand_1/cWWvlh3JBn3k0HqA.mp4') would solve your problem.

I don't want to, but it came from the src attribute of a video tag, or img in case of an image
<video src="/uploads/brand_1/cWWvlh3JBn3k0HqA.mp4"></video>
This is not a big deal I know but in some cases it will helps.
If the param for the url function starts with double slash and it's an invalid value, should not it throw an exception?

I think that it would be better for you to simply trim the '/' like so:
public_path(trim('/uploads/brand_1/cWWvlh3JBn3k0HqA.mp4', '/'));

Because if you have a website that may be under https in some situations you may use the url starting with '//' for external requests so it's not a real 'invalid' url and thus some folks might be using it this way.

You are right @fernandobandeira


Mark the type which is coming from the comment

This PR gives the capability to know if a type is created from a comment or not.
In my case I need this information to support validation with comments https://github.com/angelozerr/tern-lint/issues/30

@marijnh note that this new property type.fromComment  could be used too for completion, find type, when type must be found. Like preferFunction query option, we could have preferDoc too query option.

You really can't just assign to type values like that. They may be shared (it might be the bool type, etc).

@marijnh the type can be created with different mean :

with JSON Type Definition
with JSDoc
by guess

It should be very cool if we could know which mean has created the type. In my case I need it for validation, but I think we could use too to get the type (with preferDoc, etc).

@marijnh when you have time, could you give me some direction to know the origin of the type create (from JSON Type Definition, JSDoc comment, guess). Thanks!

You really can't just assign to type values like that. They may be shared (it might be the bool type, etc).

You are right, that's why I have created the new PR https://github.com/marijnh/tern/pull/542 which supports for the moment just simple type like boolean, string, number.


It looks like an error occurred: unauthorized

New install on ubuntu.
Happens when I click Deploy, Images or Nodes
No containers are visible.
The get request to /containers/json?all=1 is returning "unauthorized"
It seems that swarm is stuck, this is from docker ps:
937f7a54295b        shipyard/shipyard:latest        "/bin/controller --d   13 minutes ago      Up 13 minutes                       <IP_ADDRESS>:8080->8080/tcp                           shipyard-controller
c12e5a8fa61f        swarm:latest                    "/swarm j --addr 45.   13 minutes ago      Restarting (1) 6 minutes ago        2375/tcp                                         shipyard-swarm-agent
15419e3d17dd        swarm:latest                    "/swarm m --replicat   13 minutes ago      Restarting (1) 6 minutes ago        2375/tcp                                         shipyard-swarm-manager
ed15da0be1a3        shipyard/docker-proxy:latest    "/usr/local/bin/run"   13 minutes ago      Up 13 minutes                       <IP_ADDRESS>:2375->2375/tcp                           shipyard-proxy
7a491de0ff9d        alpine                          "sh"                   13 minutes ago      Up 13 minutes                                                                        shipyard-certs
20ea8a7ceb7d        microbox/etcd:latest            "/bin/etcd -addr 45.   13 minutes ago      Up 13 minutes                       <IP_ADDRESS>:4001->4001/tcp, <IP_ADDRESS>:7001->7001/tcp   shipyard-discovery
1368e6d05b55        rethinkdb                       "rethinkdb --bind al   13 minutes ago      Up 13 minutes                       8080/tcp, 28015/tcp, 29015/tcp                   shipyard-rethinkdb

logs from 1st swarm container:
FATA[0000] invalid format "discovery:4001", missing
logs from 2nd swarm container:
FATA[0000] flag provided but not defined: -replication

Solved, I needed to update the swarm image first.
#docker pull swarm


Ctor should set default values for a property that returns an Enum

To make it clear to the developer and to prevent accidentally changed behavior, properties that return Enum values should be set via the .ctor.
Following code SHOULD report an issue:
public class TestMe
{
    public TestMe() { }

    public StringComparison Comparison { get; }
}

Reason: The .ctor does not set the value directly, and there is also no value set via any property initializer.
In contrast to the example above, following code should NOT report an issue:
public class TestMe
{
    public TestMe() { }

    public StringComparison Comparison { get; } = StringComparison.OrdinalIgnoreCase;
}

Reason: The .ctor does not set the value directly, but it is set via property initializer.

Following code should not report an issue:
public class TestMe
{
    public TestMe() { }

    public StringComparison Comparison { get; } = StringComparison.OrdinalIgnoreCase;
}

The ctor does not set the value directly, but it is set via property initializer.

Maybe it is better to report the property itself and not the .ctor as issue. A codefix could then apply a property initializer.

Resolved in 5ba0600f7059281cc8b3841c966ca19bdca9c396


EWPTool does not start even after clicking “Select source folder”

Hi Team
After replacing the PC and reinstalling EWARM, I installed EWPTool, but the message "The specified file could not be found" pops up and EWPTool cannot be started.
I tried installing EWARM several times, but nothing changed.
This occurred with EWPTool 4.2.4, and I tried using 4.2.6 afterwards, but it didn't improve.
Windows 11
EWARM 8.42.1 and 8.50.10
Thanks,

Hi @kazw01
Thank you for your question.
Please make sure you extracted the contents of EWPtool-4.2.6.zip inside the common/ folder [see: #installing steps].
Examples:
\IAR\EW\ARM\8.42.1\common\bin\EWPtool.exe
\IAR\EW\ARM\8.42.1\common\config\EWPtool.toolitems

\IAR\EW\ARM\8.50.10\common\bin\EWPtool.exe
\IAR\EW\ARM\8.50.10\common\config\EWPtool.toolitems

By default, EWPtool.toolitems will point to $EW_DIR$\common\bin\EWPtool.exe. Extracting the .zip archive inside the arm/ folder will also make the IDE to display the Tools' menu items -however- the EWPtool.exe executable itself will not be found.
EWPtool 4.2.6 was tested in both Windows 10 and 11. You can test by double-clicking directly on the executable from Windows Explorer:

Let us know if that helps.

Hi Support team
Thank you for your feedback. I was able to solve it.
I was copying it under arm folder. It seems that I had completely misunderstood.
Thanks,
Kazuhiro Watanabe
Infineon Technologies Innovates G.K.
An Infineon Technologies Company
IFINV ATV MC TM CES5
Office: +81 22 796 3869
<EMAIL_ADDRESS>From: Felipe Torrezan @.>
Sent: Thursday, February 22, 2024 3:45 PM
To: IARSystems/project-migration-tools @.>
Cc: Watanabe Kazuhiro (ATV MC TM CES5) @.>; Mention @.>
Subject: Re: [IARSystems/project-migration-tools] EWPTool does not start even after clicking “Select source folder” (Issue #47)
Caution: This e-mail originated outside Infineon Technologies. Do not click on links or open attachments unless you validate it is safehttps://intranet-content.infineon.com/explore/aboutinfineon/rules/informationsecurity/ug/SocialEngineering/Pages/SocialEngineeringElements_en.aspx.
Hi @kazw01https://github.com/kazw01
Thank you for your question.
Please make sure you extracted the contents of EWPtool-4.2.6.zip inside the common/ folder [see: #installinghttps://github.com/IARSystems/project-migration-tools?tab=readme-ov-file#installing steps].
Examples:
\IAR\EW\ARM\8.42.1\common\bin\EWPtool.exe
\IAR\EW\ARM\8.42.1\common\config\EWPtool.toolitems
\IAR\EW\ARM\8.50.10\common\bin\EWPtool.exe
\IAR\EW\ARM\8.50.10\common\config\EWPtool.toolitems
By default, EWPtool.toolitems will point to $EW_DIR$\common\bin\EWPtool.exe. Extracting the .zip archive inside the arm/ folder will also make the IDE to display the Tools' menu items -however- the EWPtool.exe executable itself will not be found.
EWPtool 4.2.6 was tested in both Windows 10 and 11. You can test by double-clicking directly on the executable from Windows Explorer:
image.png (view on web)https://github.com/IARSystems/project-migration-tools/assets/54443595/b737a2bd-5655-4114-aec2-0eb4c90a49ab
image.png (view on web)https://github.com/IARSystems/project-migration-tools/assets/54443595/1deac734-0807-465a-8378-386146a74d08
Let us know if that helps.
—
Reply to this email directly, view it on GitHubhttps://github.com/IARSystems/project-migration-tools/issues/47#issuecomment-1958807152, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGK3QCRPIYKQGOLELRKHGX3YU3SNPAVCNFSM6AAAAABDUEFIM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJYHAYDOMJVGI.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hi Watanabe-san,
Thank you very much for your feedback. Feel free to reach out to us in the future in case you have further questions.


Flush awt images

:pushpin: References

Issue: (https://github.com/pedrovgs/Shot/issues/304)
Related pull-requests: list of related pull-requests (comma-separated): #1, #2

:tophat: What is the goal?
To reduce OOM errors
How is it being implemented?
Call flush on every created java.awt.BufferedImage
How can it be tested?
Mostly when there's a lot of differences and/or big screenshots that need a lot of re-combination.

Unfortunately not the complete solution


Bigtable: 'list_instances' systest flakes w/ simultaneous runs

See: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/7441
The fix from #5476 didn't account for the fact that the "other" test run might be deleting instances, too.

We should probably just check to make sure that the instance(s) we know exist are in the list.

@AVaksman, FYI

The tests/system.py module computes EXISTING_INSTANCES at the beginning of the test run, and expects that those instances will be present for its duration (at least until test_list_instances runs).  However, when two CI runs overlap, one can tear down / remove its temporary instance after the other has started, but before the test_list_instances run.
We can fix this one of two ways:

Exclude CI-generated instances from EXISTING_INSTANCES (any matching the patterns g-c-p-{unique_id}, new-{unique_id} or ndef-{unique_id}).
Update test_list_instances to assert only that the one instance known to be created (w/ INSTANCE_ID) is present.

Update test_list_instances to assert only that the one instance known to be created (w/ INSTANCE_ID) is present.

#5696 implements the second option.


Setup of v12.0.0-beta1 fails

[N] I ran "add_firewall_rules.bat" as adimistrator and checked that the ports are open in the firewall: I did not do this as the file is missing in this version.
[Y] I read the ALVR Wikis here and here

Clicking "Add firewall rules" causes ALVR server to give error code -1
Clicking next and clicking to install the driver causes a window with the title "ALVR crashed" to popup. Inside the window, it says "The system cannot find the file specified. (os error 2)".
I did run ALVR server as admin.
Environement
What hardware do you have: CPU, GPU, Audio: AMD Ryzen 5 3600, AMD Radeon 580, Generic USB sound card
What version of ALVR and SteamVR have you tried: ALVR server v12.0.0-beta.1 and SteamVR 1.13.10
Do you have the latest Windows updates?: Windows version is 2004 (OS Build 19041.388)

Apparently it matters what folder you run it from. I was running it from the downloads folder where I unpacked it. I put it in my user folder, and it works fine.

-1 error on firewall rules means failed to get admin privileges. This is maybe because you were already running with admin privileges. The error when registering the driver is because you have a non standard location for the steamvr installation.

I verified that it does not matter where you extract ALVR server. The firewall rules fail is because either you didn't install SteamVR or you didn't launch it one time (before launching ALVR), so it didn't do it's first time setup.

Weird, SteamVR was installed and being used prior to this. I was using it with Virtual Desktop Streamer.


hashRouter option isn't work

Bug report
Hi, first thank you for provide awesome framework.
I tried publish docz build files to github pages and it works well.
But i got some problem which is refresh error on SPA. (Client side routing problem)
So, i added hashRouter option to my doczrc.js configuration file.
And i expected like this ...
When i click Getting started link

url is localhost:3003/#/getting-started

when i click Examples link

url is localhost:3003/#/examples

But i got this results ...
When i click Getting started link

url is localhost:3003/getting-started

when i click Examples link

url is localhost:3003/examples

doczrc.js
const pkg = require('./package.json')

module.exports = {
  title: pkg.name,
  description: pkg.description,
  base: `/${pkg.name}/`,
  hashRouter: true,
  dest: 'docs',
  host: '<IP_ADDRESS>',
  port: 3003,
  menu: [
    'Getting started',
    'Examples'
  ]
}

Versions

Docz
v1.2.0

https://www.docz.site/docs/migration-guide#remove-hash-router-support
Docz has decided to deprecated the hash router support.

@ronghang Oh, i just saw that docs. I will close this issue. Thank you 😊

@socker210 feel free to follow #763 if you are interested in bringing hash router back.


Change ms.service value: 'azure-arc-data' to azure-resource-manager

Description:
This PR is part of a global effort to improve metadata quality. These changes make reports cleaner, easier to use, more consistent, and more reflective of current business.
After you accept changes and they're merged, standard dashboards and reports will reflect new values, so you'll need to use new filter values. If you have any custom dashboards or Kusto queries, you might need to update those also.
Fixing #568887 -Remove ms.service value: azure-arc-data
Change:
Item: https://dev.azure.com/ceapex/Content Learning Content Architecture/_workitems/edit/568887
Replace ms.service = azure-arc-data
With ms.service= azure-resource-manager

Docs Build status updates of commit 7988c8a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/latest/resourcemanager-msi-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-msi-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@weidongxu-microsoft - could you please help  with approval?


2 Qubit ControlledOperations should be supported in convert_to_sycamore_gates

Description of the Issue
We check isinstance(op, GateOperation) while verifying that the given operation can be decomposed using analytical / tabulation methods. This leads to the problem that we don't recognize two qubit controlled operations as known gates and hence don't support them.
https://github.com/quantumlib/Cirq/blob/12530f1531e5da663a6b172b1967763e08819912/cirq-google/cirq_google/optimizers/convert_to_sycamore_gates.py#L111
For example:
num_qubits = 3
qubits = cirq.GridQubit.rect(1, num_qubits, 4, 4)
circuit = cirq.Circuit(cirq.QuantumFourierTransformGate(num_qubits)(*qubits))
cirq.Circuit(cirq.google.ConvertToSycamoreGates().convert(circuit), device = cirq.google.Sycamore)

The above code fails with the following error:
TypeError: Don't know how to work with cirq.S(cirq.GridQubit(4, 4)).controlled_by(cirq.GridQubit(4, 5)). It isn't a native xmon operation, a 1 or 2 qubit gate with a known unitary, or composite.

The reason it fails is because ControlledOperations don't satisfy the isinstance(gate, GateOperation) constraint.
op = cirq.S(cirq.GridQubit(4, 4)).controlled_by(cirq.GridQubit(4, 5))
print(type(op), isinstance(op, cirq.GateOperation))

gives
<class 'cirq.ops.controlled_operation.ControlledOperation'> False

However,  the gate is actually just a two qubit controlled gate and should be decomposable into the native gateset via known_two_q_operations_to_sycamore_operations.
op = cirq.S(cirq.GridQubit(4, 4)).controlled_by(cirq.GridQubit(4, 5))
print([*known_two_q_operations_to_sycamore_operations(op.qubits[0], op.qubits[1], op, None)])

gives the following decomposition
[cirq.PhasedXZGate(axis_phase_exponent=-1.1102230246251565e-16, x_exponent=0.7239292897100449, z_exponent=0.08333333333333348).on(cirq.GridQubit(4, 5)), cirq.PhasedXZGate(axis_phase_exponent=0.5416666666666665, x_exponent=0.0, z_exponent=0.916666666666667).on(cirq.GridQubit(4, 4)), cirq_google.SYC.on(cirq.GridQubit(4, 5), cirq.GridQubit(4, 4)), cirq.Rx(rads=0.5922772837339743).on(cirq.GridQubit(4, 4)), cirq_google.SYC.on(cirq.GridQubit(4, 5), cirq.GridQubit(4, 4)), cirq.PhasedXZGate(axis_phase_exponent=-0.08333333333333315, x_exponent=0.7239292897100451, z_exponent=-0.916666666666667).on(cirq.GridQubit(4, 5)), cirq.PhasedXZGate(axis_phase_exponent=0.22741638234956674, x_exponent=2.220446049250313e-16, z_exponent=0.25).on(cirq.GridQubit(4, 4)), cirq.Rz(rads=0.7853981633974483).on(cirq.GridQubit(4, 5)), cirq.Rz(rads=0.7853981633974483).on(cirq.GridQubit(4, 4))]

Proposed Solution
https://github.com/quantumlib/Cirq/blob/12530f1531e5da663a6b172b1967763e08819912/cirq-google/cirq_google/optimizers/convert_to_sycamore_gates.py#L111
should be modified to also recognize two qubit ControlledOperations.
Cirq version
0.11.0.dev

I'm assuming the GateOperation check is supposed to filter out Operations that don't have gates.
We have had these discussions about Operation hierarchy and how the type checks are used as proxies for whether there is an underlying Gate or not. I think it's useful to have a has_gate protocol that actually tries to get the underlying gate and performs not-None, etc checks. This would be more pythonic than type checking IMO.

op.gate is not None seems about as simple as cirq.has_gate(op), and I think that's basically all the has_gate method would do anyway. Certainly the isinstance(op, cirq.GateOperation) checks are too restrictive in this case.

The protocol will also be doing a getattr check for gate first. op.gate is not None assumes that op is some Operation type which might not be the case for all instances of these checks in Cirq.

Upd: Similarly, _is_native_xmon_op checks for isinstance(op, cirq.GateOperation) and hence does not recognize gates like CS(0, 1) to be native gates which leads to much worse (decomposed) target circuit lengths. xref #4172

Discussed in Cirq sync: Recent work on the circuit transformers should fix this.


fix idempotency issue in SP connections

Description
fix idempotency issue in SP connections
Added dict_merge method to make deep merge of nested dictionaries
Issues Resolved
Fixes #171
Check List

[x] New functionality includes testing.

[x] All tests pass. ($ ./build.sh).

[ ] New functionality has been documented in the README if applicable.

[ ] New functionality has been thoroughly documented in the examples (please include helpful comments).

Correct copyright year in oneview.py

Done


Change branch link behavior on pull request site

Move the link to a separate icon next to the name
Focus the branch name on click

Why?

I use that label to copy pull request names to check them out locally.

Then it would make more sense to have a button to copy the branch name, but not sure we want that either.

Yes, definitely. That link now shows up for all branch references. It doesn't look that good.
I'd keep it consistent and switch back to a url.
Any reason you don't like a separate button to copy the name?
We could add it next to the edit button of a pr title.

@marcbachmann Do you have git completion in your shell? You can check out a branch by using just the first few characters and tab completion?
There's also hub which allows you to check out a PR locally by pasting the URL.

Hehe. Sure I do. But if you're on the website and want to checkout something, it's much faster to quickly copy the whole string than tabbing through a few matches where you have to find it.
I also use the alias fetch-pr  = "!f() { git fetch origin refs/pull/$1/head:pr/$1; } ; f" to check out a specific pr, but that doesn't keep the branch name.
... ok, I didn't know that hub also has a checkout enhancement. That's good enough. 😆

In a way, I see the benefit, but even then, I wouldn't implement it this way, because there could be a username with a colon there and this won't work in a normal git-checkout (1). And for some reason I don't like the copy button either. 🤷♂

💡 Right-click and select "Copy".

Tripple click works without this extention, that's why it broke my workflow.


how to dubbo-provider using host ip of docker container

when dubbo-provider run in docker container ,it rigistried by the ip of contaner ,which unvisitable by other server

You can add --net=host to docker run command, for example, docker run --net=host dubbo-provider.

So that can not deploy multiple dubbo apps on a docker, unless use different port. It is not recommended, suggest to use the virtual IP of docker.  @ryankong

Hi, @vangoleo, thanks for your reply, what about running a dubbo-provider in a k8s cluster? As we konwn, dubbo register the podIP rather than a nodeIP to registry(zookeeper), thus consumer outside of k8s cluster cannot reach to the providers within k8s. Any solution to register nodeIP to ZK instead?

Please check this example: https://github.com/dubbo/dubbo-samples/tree/master/dubbo-samples-docker

Please check this example: https://github.com/dubbo/dubbo-samples/tree/master/dubbo-samples-docker

It is not found now.

@baozi-2019 Moved to https://github.com/apache/dubbo-samples/tree/master/2-advanced/dubbo-samples-docker


Rely's output format doesn't look good when using dune runtest

I'm trying to use Rely in combinaison with dune runtest.
Here's my dune file:
(library
 (name Spin_test)
 (public_name spin.test)
 (flags -open Base -linkall -g -w -9)
 ; Make the library optional to skip building test on Opam
 (optional)
 (libraries base rely.lib spin.lib)
 (modules
  (:standard \ test_runner)))

(test
 (name test_runner)
 (modules test_runner)
 (libraries base spin.test)
 (flags -open Base)
 (action
  (run %{test} -q --color=always)))

(include_subdirs unqualified)

When I use the test stanza and run dune runtest, the output format looks like this:

It's hard to see what's failing.
In comparison, the output for the same test suite when using a normal executable looks like this:

Is there anything I can do to improve the output format with dune?
Thanks!

Do you have an example repo I can clone and try it out? It wasn't immediately trivial for me to set up dune runtest in an example repo I had

Sure! I've created a repo here: https://github.com/tmattio/dune-rely-demo
git clone git@github.com:tmattio/dune-rely-demo.git
cd dune-rely-demo
esy

Then I've added two scripts:

esy test-dune to run the test with dune runtest
esy test-exe to run the test with an executable

Here's the diff I have on my machine:

The default Rely reporter is optimized for running directly in the terminal as opposed to with dune runtest (which captures stdout for diffing purposes and I imagine is getting tripped up by the ANSI escape sequences we use to give cleaner terminal output).
If you want to use dune test stanzas and aren't using Pastel you could add Pastel.setMode(Disabled) to the top of your TestFramework file.

Thanks @bandersongit!
Adding Pastel.setMode(Disabled) didn't work, but setting FORCE_COLOR to false did.
I'm loosing the color, but at least the output is readable!
I might take a look at implementing a custom reporter yes, I'm trying to support releasing packages on Opam that use Rely, and using a test stanza is the only solution I've found. Would be cool to keep the colors as well 😄

Thanks for the repo, that was helpful! I did some experimenting on this as well, basically the same findings as Ben.
Quick fix is to use Pastel.setMode(Disabled) at the top of test_dune/support/test_runner.re (this worked for me).
This definitely has to do with escape codes, but it is also hard for me to debug to see how dune is affecting the escape codes. Due to their own color detection turning off colors when you start piping it places, and because it's using stderr not stdout.
For example I can see exactly how Rely prints with color by using this command:
esy test-exe | sed -n l

Running 1 test suite$
\r\033[7m\033[1m\033[33m RUNS \033[27m\033[22m\033[39m \033[97mUtils\033[39m\033[50D\033[K\033[7m\033[1m\033[32m PASS \033[27m\033[22m\033[39m \033[97mUtils\033[39m$
$
\033[1m\033[97mTest Suites: \033[22m\033[39m0 failed, \033[1m\033[32m1 passed\033[22m\033[39m, 1 total$
\033[1m\033[97mTests:       \033[22m\033[39m0 failed, \033[1m\033[32m2 passed\033[22m\033[39m, 2 total$
\033[1m\033[97mTime:        \033[22m\033[39m< 1ms$
$

But when trying with esy dune-test, no matter what I do I can't see what the actual error codes dune is converting too:
esy test-dune --force 2>&1 | sed -n l

 test_runner alias test_dune/runtest$
Running 1 test suite$
\r RUNS  Utils PASS  Utils$
$
Test Suites: 0 failed, 1 passed, 1 total$
Tests:       0 failed, 2 passed, 2 total$
Time:        < 1ms$
$

You can see all the color codes are removed already, even though there should be some in the output if dune didn't detect these pipes weren't a terminal. I figured the (run %{test} -q --color=always))) in the dune file would make it always print colors, but I guess not? 🤷
If you're able to play around with it and see exactly how dune is messing with the error codes we can debug it a bit further and it would probably help in setting up a custom printer/reporter to work with dune better.

Oh actually I was able to get the output, it is definitely doing something crazy with escape codes:
(Mac version of calling script to fake a tty according to stack overflow)

script -q /dev/null esy test-dune --force 2>&1 | sed -n l

Done: 0/0 (jobs: 0)\r                   \rDone: 41/43 (jobs\
: 1)\r                     \r\033[2;32m test_runner\033[0m \
alias test_dune/runtest\r$
Running 1 test suite\r$
\r\033[7;1;33m RUNS \033[0m\033[7;1;33;27;22;39m \033[0m\
\033[7;1;33;27;22;39;97mUtils\033[0m\033[7;1;33;27;22;39;97\
;39;50D\033[K\033[7;1;32m PASS \033[0m\033[7;1;33;27;22;39;\
97;39;50D\033[K\033[7;1;32;27;22;39m \033[0m\033[7;1;33;27;\
22;39;97;39;50D\033[K\033[7;1;32;27;22;39;97mUtils\033[0m\r\
$
\r$
\033[7;1;33;27;22;39;97;39;50D\033[K\033[7;1;32;27;22;39;97\
;39;1;97mTest Suites: \033[0m\033[7;1;33;27;22;39;97;39;50D\
\033[K\033[7;1;32;27;22;39;97;39;1;97;22;39m0 failed, \033[\
0m\033[7;1;33;27;22;39;97;39;50D\033[K\033[7;1;32;27;22;39;\
97;39;1;97;22;39;1;32m1 passed\033[0m\033[7;1;33;27;22;39;9\
7;39;50D\033[K\033[7;1;32;27;22;39;97;39;1;97;22;39;1;32;22\
;39m, 1 total\033[0m\r$
\033[7;1;33;27;22;39;97;39;50D\033[K\033[7;1;32;27;22;39;97\
;39;1;97;22;39;1;32;22;39;1;97mTests:       \033[0m\033[7;1\
;33;27;22;39;97;39;50D\033[K\033[7;1;32;27;22;39;97;39;1;97\
;22;39;1;32;22;39;1;97;22;39m0 failed, \033[0m\033[7;1;33;2\
7;22;39;97;39;50D\033[K\033[7;1;32;27;22;39;97;39;1;97;22;3\
9;1;32;22;39;1;97;22;39;1;32m2 passed\033[0m\033[7;1;33;27;\
22;39;97;39;50D\033[K\033[7;1;32;27;22;39;97;39;1;97;22;39;\
1;32;22;39;1;97;22;39;1;32;22;39m, 2 total\033[0m\r$
\033[7;1;33;27;22;39;97;39;50D\033[K\033[7;1;32;27;22;39;97\
;39;1;97;22;39;1;32;22;39;1;97;22;39;1;32;22;39;1;97mTime: \
       \033[0m\033[7;1;33;27;22;39;97;39;50D\033[K\033[7;1;\
32;27;22;39;97;39;1;97;22;39;1;32;22;39;1;97;22;39;1;32;22;\
39;1;97;22;39m< 1ms\033[0m\r$
\r$
Done: 41/43 (jobs: 1)\r                     \r$

I think I see what dune is trying to do. It looks like it is trying to shorten/optimize the escape codes but doing so incorrectly, if you look at dune's (top) compared to corresponding normal escape codes (bottom):
\033[7;1;33m
\033[7m\033[1m\033[33m

Then it looks like in the next instance of "optimizing" it forgets to stop adding 7;1;33:
\033[7;1;33;27;22;39m
\033[27m\033[22m\033[39m

Okay I see what the issue is, I'll file a bug against dune. It keeps reapplying cursor movement escape codes.
In general what it's doing is not terrible. It collected error codes that apply to each section of text, resets them, then reapplies them all. I was missing the error codes from before:
\033[7m\033[1m\033[33m
\033[7;1;33m

Then:
\033[27m\033[22m\033[39m
# \033[0m is a reset, so 7;1;33 need to be reapplied
\033[0m\033[7;1;33;27;22;39m

In general this would be fine, but we use control sequences to move the cursor and delete text (`\033[50D\033[K). These obviously have side effects and cannot be "escaped" then continuously reapplied. It would just keep moving the cursor to weird places and deleting text resulting in the weird output you see.

Hopefully they can fix this issue in dune: https://github.com/ocaml/dune/issues/3160
It may also be worth adding a feature to Rely to not print any side-effect escape codes with cursor movement/line deletion.

That's awesome @kyldvs, thanks a lot for looking into this!
I can look into adding a feature to remove these escape codes. Do you have any recommendation on how to implement it? Would it be part of another reporter?

Yeah I think you could almost use exactly the same TerminalReporter.
I think what needs to happen is we disable all of this runningDisplayLength and printing of \027[XXD, and \027[K escape codes: https://github.com/facebookexperimental/reason-native/blob/master/src/rely/reporters/TerminalReporter.re#L330,L355
(maybe needs to be replaced with new lines instead)
Since everything else can basically be the same, we can probably just extend the createTerminalReporter to have an additional option like onlyPrintDetailsForFailedSuites. I would suggest a name like ~simpleTerminalControlSequences or something: https://github.com/facebookexperimental/reason-native/blob/master/src/rely/reporters/TerminalReporter.re#L22
Then enable it in the CLI via some option: https://github.com/facebookexperimental/reason-native/blob/master/src/rely/RelyCLI.re#L18-L52

@tmattio It looks like another workaround can be to use --no-buffer when calling dune runtest! https://github.com/tmattio/dune-rely-demo/compare/master...kyldvs:master
(I don't know how to use base, but you want an extra newline before calling into Rely because dune prints some things first)

Yes I think it could still be beneficial! Perhaps as another format for CI or other non-interactive places.
(Also I believe along with --no-buffer the -j1 flag should be passed as well btw)

Got it, I'll try to look into it 🙂


Extract text from images embedded in pdfs

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

First of all, thanks for the awesome demo code. Works like a charm in the first attempt. Considering I am new to Azure and CLI commands, the instructions are super clear.
I am trying to extract texts from the images embedded in PDFs. I believe I could add a skillset for OCR in the search service and rerun the index.

Looking for your recommendations on how to add it in prepdocs.py. Is there a way to extract the texts from images (as well from the supplied PDFs) through form recognizer?
Any log messages given by the failure

Expected/desired behavior

Use the backend chat application to perform on search text embedded in the images.

OS and Version?

Mac OS Monterey

azd version?

run azd version and copy paste here.

Versions

azd version 1.0.2

Mention any other details that might be useful

Thanks! We'll be in touch soon.

This is still a valid feature request and I have heard it a few times. I have not looked into this myself, however. Leaving it open.

I think that the current DI chunking process already does that. I can see text from embedded images in the index of app we are building. @pamelafox is this somethin you can confirm?


DOC: move OS prereqs out of "advanced configuration"

Thank you for the great work, and in advance for your consideration!
Environmental Info:
K3s Version:
k3s version v1.28.3+k3s1 (49411e70)
go version go1.20.10

Node(s) CPU architecture, OS, and Version:
Linux mgrant.sb.anacondaconnect.com 4.18.0-477.27.1.el8_8.x86_64 #1 SMP Thu Aug 31 10:29:22 EDT 2023 x86_64 x86_64 x86_64 GNU/Linux

Describe the bug:
As the documentation says, nm-cloud-setup must be disabled for installation to proceed. I didn't see this, and therefore struggled to understand why the service would not start. I inspected the startup commands, and found the reference to nm-cloud-setup, and that led me to the conclusion it should be deleted.
"Well, problem solved, RTFM, right?" Indeed. And yet. I would like to suggest that installation prerequisites should not go into a section called Advanced Options / Configuration.  It would therefore not occur to me to read anything in a section with Advanced in the title. There is nothing to suggest I'd need to do this in the Quick Start Guide, nor in the Requirements section.
I would like to suggest the following:

A blurb that links to Requirements at the top of the Quick Start Guide. No matter how quick you want to be, you need to meet the requirements, right?
A clear callout in said Requirements to common OS-specific requirements such as this. Perhaps is entire section should be moved out of Advanced Options / Configuration and into Requirements.
I'd consider copying the nm-cloud-setup check in the systemctl script into the get.k3s.io install script as well, perhaps along with checks for ufw and firewalld.

EDIT: Oh, one more add: I discovered the SELinux enforcement with the default k3s-selinux ruleset is not compatible with local-path-provisoner; that should probably be called out as well. See here: https://github.com/rancher/local-path-provisioner/issues/362
Thank you again!

I'm not above doing this work myself, mind you—if I get some down time I'll consider doing a doc PR.

Closing in favor of https://github.com/k3s-io/docs/issues/195


Netmatch - missing logo

ENVIROMENT: production
URL: https://scrapers.peviitor.ro/
Browser: Opera
Device: laptop
OS: Windows 11
STEPS TO REPRODUCE:
1.Open URL in browser
2.Type "netmatch" in the search bar
3.Check the logo
EXPECTED RESULTS:
The logo must be displayed in the middle of the screen.
ACTUAL RESULTS:
There is no logo displayed.

Fixed


Not a real bug but wrong example

In READ.ME I had te rename label into name for tekst to appaer

Indeed, there was a mistake in the doc, but it is already corrected since some days...


fix: legend color 与实际渲染颜色不一致

Checklist

[ ] npm test passes
[ ] tests and/or benchmarks are included
[ ] commit message follows commit guidelines

Description of change

v3.8.11 有同样的bug，请修复。