Disable Catchment-CN4.5 land model option (LSM_CHOICE=3) for GCM simulations

This PR disables the option for using the Catchment-CN4.5 land model (LSM_CHOICE=3) in GCM simulations. The PR also fixes a minor typo that was present in the error message displayed for invalid values of LSM_CHOICE.
This PR is zero-diff.
Related PRs:
https://github.com/GEOS-ESM/GEOSldas/pull/707
https://github.com/GEOS-ESM/GEOSgcm_GridComp/pull/900
cc: @gmao-rreichle , @biljanaorescanin

Note to @sshakoor1: this will probably need to be done in #544 as well. Though I suppose once this gets in, git would merge the change...

Has someone tried running gcm_setup after these mods?
Yes, I ran gcm_setup with these modifications trying both LSM_CHOICE=2 and LSM_CHOICE=3 (which is no longer a valid choice). The only options for LSM_CHOICE that are displayed in the interactive script are 1 (Catchment) and 2 (Catchment-CN4.0). And trying to set LSM_CHOICE=3 (Catchment-CN4.5), triggers the error message (which is how I noticed the typo in the error message)

Yes, I ran gcm_setup with these modifications t

Thanks, @gmao-jkolassa.    I'm marking this as "ready for review", @sdrabenh.  Please let us know if you have any questions.


languages added: asciidoc, org-mode and ipython-notebook

Forgot to add tests, will add again shortly


IOS 10 - Redirect to 3rd party apps after you take a picture not working as expected

My app is being closed when I try to redirect to 3rd party apps.
whenever I call other app using this sample code:
navigator.camera.getPicture(function (srcUri) {
        supersonic.app.openURL("youtube://");
      }, function(error) {
        console.log(error);
      }, {
        quality: 25,
        destinationType: navigator.camera.DestinationType.FILE_URI,
        sourceType: navigator.camera.PictureSourceType.CAMERA
      });

Youtube is open but my app gets close and re-open in background. It's like my app loses its state.

Same here. +1


Undefined names in test_product.py

https://github.com/mirumee/saleor/blob/master/tests/dashboard/test_product.py#L268-L273
flake8 testing of https://github.com/mirumee/saleor on Python 3.6.3
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
./tests/dashboard/test_product.py:268:12: F821 undefined name 'response'
    assert response.status_code == 302
           ^
./tests/dashboard/test_product.py:269:34: F821 undefined name 'response'
    assert get_redirect_location(response) == reverse('dashboard:product-list')
                                 ^
./tests/dashboard/test_product.py:271:14: F821 undefined name 'product_list'
    for p in product_list:
             ^
3     F821 undefined name 'response'
3

Looks like a wrong merge

The commit that added those tests: https://github.com/mirumee/saleor/commit/aa5dc88d6260b1e0371a3395dcb48052810d6e62#diff-70296847f6f51488c62795d05f3cb4e4R258
The commit that broke the tests: https://github.com/mirumee/saleor/commit/e53ef3038928ccbc2c559586a4ef809e08cf07a6#diff-70296847f6f51488c62795d05f3cb4e4R256

How comes pytest doesn't raise a NameError?

Because PyTest does not attempt to build an Abstract Syntax Tree for all .py files in the project/


Fix offer application parameters for Oscar 1.1

Fixes #104

The previous pull-request (#101) also includes this patch.

Thank you for your PR, but this won't work across different Oscar versions. #101 seems to be compatible across both.


conf: fixup override usage

Combining overrides with += is not officially supported, and will
trigger a warning in newer yocto releases [1]:
WARNING: MACHINE_FEATURES:remove += is not a recommended operator combination, please replace it.
[1] https://docs.yoctoproject.org/dev/migration-guides/migration-4.0.html#append-prepend-in-combination-with-other-operators
Signed-off-by: Jonas Gorski<EMAIL_ADDRESS>

As in bisdn/meta-switch#90, there should be no space prefixes for remove (only for append).

Fixed.


Fixed persian translation

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
no

Fixed issues
nothing

Merged. Thanks!

<3


CI should be automated, not manual Jenkins

CI currently is run manually on Jenkins. That means we cannot make it a blocking part of PRs - "do not allow merge until CI has passed" - or an automated part of post-merge.
We need to move it from Jenkins into a support CI-as-a-service. GitHub Actions probably is easiest, but circleci and drone and others are fine.
In any case, this is an OSS project and needs to have open CI.

It's not manual. It's triggered by Github push, but now it's itmo repo. I plan to integrate Jenkins to Github, so you know whether the PR pass the test.

Got it. OK, I will close this issue and open a new one to reflect.


demoit: unstable-2019-05-10 -> unstable-2020-06-11

Motivation for this change
Update demoit package to a more recent snapshot
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/223

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/258


[typescript] Simplify display of slot props types

This changes the display of slot props types from the quite cryptic
type ButtonUnstyledRootSlotProps = Omit<{}, keyof UseButtonRootSlotOwnProps> & UseButtonRootSlotOwnProps & {
    ownerState: ButtonUnstyledOwnerState;
    className: string;
    children?: React.ReactNode;
}

to more readable
type ButtonUnstyledRootSlotProps = {
    'aria-disabled'?: Booleanish | undefined;
    disabled?: boolean | undefined;
    tabIndex: number;
    // ...
}

The shape of the types remains unchanged. Just the display in the editor is affected.
The idea was taken from https://effectivetypescript.com/2022/02/25/gentips-4-display/

when should we use it?

Good question. I found the applicable types by trial and error. Whenever I saw an incomprehensible type display, I tried wrapping the type in Simplify and saw if it helps.
I had good results with it being applied on slot props types. We can default to these for now and if anything else turns out to be applicable as well, we may include it.

How do we make sure we don't forget to use the new generic?

I can't think of anything other than code review for now. Perhaps a linter rule could be created but we would first have to identify applicable cases.


after upgrading abapgit a dialog appeared asking for creating an interface

A nice feature if we want to scare people.

This should have been a sigh on Slack random channel. Sorry!


Add period inference from freq strings to sktime

Issue #, if available:
Description of changes:

Add period inference from freq strings to sktime
Add pred_time_test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1914-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1914/1/index.html

Job PR-1914-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1914/2/index.html

Job PR-1914-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1914/3/index.html


Fixes test_classes on ABAP 7.02

As per https://github.com/larshp/abapGit/pull/588#issuecomment-276269777
@christian1020-94 Could you please test again after pull? All my sandbox systems are 7.4 😭

thanks, LGTM

@EduardoCopat this time no syntax errors found :smile_cat:


Custom Guard for each panel return Session Database user_id to null

Package
filament/filament
Package Version
v3
Laravel Version
v10
Livewire Version
No response
PHP Version
8.2
Problem description
When logging in to a default panel with a declared authGuard('web') is working fine however, logging in to other panel with a custom authguard it failed to add user id in the session table.
Expected behavior
custom guard supposed to be working.
Steps to reproduce

Create a two different panel
Create a custom Authenticatable model
Create a custom guard and provider using the eloquent provides
Add the guard to the panel
login to the panel that use the custom guard
check the session table in the database, then user_id column is null

Reproduction repository
https://github.com/OSSAdmiral/Recruit/
Relevant log output
No response

For additional information, please see below information that might help resolve the issue more faster.
auth.php
'guards' => [
        'web' => [
            'driver' => 'session',
            'provider' => 'users',
        ],
        'api' => [
            'driver' => 'jwt',
            'provider' => 'users',
        ],
        'candidate_web' => [
            'driver' => 'session',
            'provider' => 'candidates',
        ],
    ],
'providers' => [
        'users' => [
            'driver' => 'eloquent',
            'model' => App\Models\User::class,
        ],
        'candidates' => [
            'driver' => 'eloquent',
            'model' => App\Models\CandidateUser::class,
        ],

here are the panel configurations.
for the panel that used the custom guard:
return $panel
            ->id('candidate')
            ->path('portal/candidate')
            ->authGuard('candidate_web')
            ->authPasswordBroker('candidate_users')
            ->passwordReset()
            ->emailVerification()
            ->login()
  //...

for the panel that used the default guard:
return $panel
            ->default()
            ->maxContentWidth('full')
            ->id('recruit')
            ->path('')
            ->passwordReset()
            ->authGuard('web')
            ->authPasswordBroker('users')
            ->emailVerification()
            ->login()
 //....

I have an assume that the filament uses the default web' guard and doesn't respect the provided guard under the panel configuration ->authGuard('candidate_web')`

Hi, please create a new repository. We would like a minimal reproduction of the issue, with thorough instructions, instead of having to install your entire app with all its dependencies and feature.
Also, creating a new repository can sometimes help you figure out that the issue is on your side and not with Filament.

Hi, please create a new repository. We would like a minimal reproduction of the issue, with thorough instructions, instead of having to install your entire app with all its dependencies and feature.
Also, creating a new repository can sometimes help you figure out that the issue is on your side and not with Filament.

Hi Thank you for your response.
I've create a fresh installation with Filament, and setup the a two different panels, however during the time I access the web page for the 2nd panel (the panel path setup is ->path('');) it return an error Route [login] not defined.` it supposed to be a login page of the 2nd panel.
I can't move forward and reproduce the issue I've encountered for the session database since I've encountered a new issue. not sure if it is only me.
Installed Filament version: v3.1.17
Here is the Repository https://github.com/MarJose123/example1

Laravel requires it. You just need to define a route with the name "login" that redirects to the main login page. I usually put it at the /laravel/login

I know that Route [Login] not defined error is from the Authenticate middleware but it will only occur if you visit a page that required authentication and laravel will force you to authenticate by sending the route to login page.
In my case I'm navigating only to the http://<IP_ADDRESS>:8000/ as defined in my panel path ->path('/') as mentioned in the documentation to login to the filament.

You need ->login() for the StandardPanelProvider otherwise we cant redirect the user anywhere.

Closing this as I think ->login() solves, let me know otherwise


Sending notification emails?

Hi, thanks for putting this Dockerfile together!
One thing that's apparently lacking is outgoing email notification support. Do you happen to know how that could be added? Unfortunately my own experience level with this stuff ranges from "minimal" to "nonexistent".
It looks like the required steps are something like this:

Install and configure MSMTP to act as a sendmail alternative, because the Busybox built-in sendmail is very limited
Configure PHP to use MSMTP as above, via sendmail_from and sendmail_path in php.ini file.
Add the appropriate variables to the Docker-compose file for your send-from address, SMTP account info, etc., and inject them into the Dockerfile where needed.

Does that seem right?
And step 3 this actually need to be done? Or can php.ini be safely written in the data directory from the "host side", once the container has been created?

Hi @gwerbin, I have updated the compose example which provides a simple SMTP relay service to be used with Dokuwiki and its SMTP plugin.

Wow, thank you!


UI changes need for tablet

Because of the larger screen size some things on the tablet are a little off. Here's a list I created when going through the tutorial.

Offline mode button text too big
ElectrodeSelector should be larger
SideMenu text should be a little bit bigger
SideMenu 'Offline Mode' or 'Connected' title should be centered
More space around boxes in PopUpList

Fixed these in newest prod version. Will test at next hacknight


Cannot select a path outside the workspace to save the file

ADD ISSUE DESCRIPTION HERE
Version: 1.81.1
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: vscode.dev

Steps:

Open a repo on vscode.dev
Open a file in any directory
Double-click the blank space to create a new file and use the shortcut key to save it
You can find the path to save the file can directly click on the previous level

Although the path beyond the current workspace is not saved successfully, in theory, it should not be possible to choose such a path.

The code to determine whether you can continue to select the upper directory is here：
https://github.com/microsoft/vscode/blob/9e927a6111882ef550806e06efb82be9b1b55571/src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts#L956

@alexr00 Is it possible to add an attribute to ISaveDialogOptions to indicate that paths outside the workspace cannot be selected?

We now show an error in the simple file picker if you try to safe in a place that doesn't support it with Remote Repositories.


Updating Formula Result

It's unclear from the documentation how I would go about doing this.
I want to read in an existing XLS file, update some values, and then get the new computed results of formulae.
For example, if I have this spreadsheet:
A1=3
A2=4
A3=7
A4=sum(A1:A3)

I'd like to update A3 to equal 8 and for A4's value to then yield 15.

worksheet.getCell('A3').value = 8;
// assuming A4 is a formula value with formula and result fields
worksheet.getCell('A4').value.result = 15;

@guyonroche what I understand is that formulas are not computed by the library but retrieved from the source file?

Yes - the library is not a replacement for Excel, it won't calculate the results for you - at least not yet anyway.

I understand that the ExcelJS software does not recompute formulas. (That is Excel's job.)
However, when I modify values in cells that are referred to in formulas and export it to an Excel file, I would expect Excel to recompute the values that are formulas when it opens up the spreadsheet for the first time.
However it does not do this.

If I edit the formula in the cell and hit , the value for that one cell is recalculated correctly.
Does anyone know if there is anything I can do in ExcelJS to tell Excel to recalculate the formula cells when it first opens the spreadsheet?

I discovered that Shift-F9 ("recalculate worksheet" in Excel) does not sufficiently recalculate the spreadsheet but that Ctrl-Shift-Alt-F9 (in Excel) does recalculate the spreadsheet successfully.
However, since I don't want to have to do a recalculation in Excel, I found this work-around.
I actually have calculated the results of the formulas in Node.js, so I tried the following.
// value is the value I want to set to the cell
// cell is the cell object from the worksheet
if (cell.value && typeof(cell.value) === "object" && cell.value.formula) {
cell.value.result = value;     // I would think this would work but it doesn't
}
else {
cell.value = value;
}
However, when I try to set the result of a formula cell like that (above), it doesn't seem to work.
The result does not stick.
If I print out the cell.value.result before and after, it is unchanged. (!?!)
There seems to be some object magic happening on the value of a formula cell that I'm not understanding.
So I did the following instead, and it works perfectly.
The new result shows up in Excel for the formula cell when the file is opened up.
// value is the value I want to set to the cell
// cell is the cell object from the worksheet
if (cell.value && typeof(cell.value) === "object" && cell.value.formula) {
cell.value = {
formula: cell.value.formula,    // copy in the old formula from the old cell.value
result: value                            // put the newly computed value in as the result
};
}
else {
cell.value = value;
}
IMPORTANT: This method does not cause Excel to recalculate the values of the formulas.
For that, you still have to Enable Editing of the downloaded spreadsheet and press Ctrl-Shift-Alt-F9.
This method merely allows that if you have computed the result of the formula correctly in Node.js, then you can set it so that Excel will display it when the file is first opened.

Going back to the original post by morgante, I would like to use node (exceljs) to update a value and then read the new computed value from a cell containing a formula that references the updated value. The example by spadkins above seems to bi-pass the work that Excel should be doing for us.  To clarify, I don't want to ever "open" the excel file, but rather use it in the background as a calculation engine.  Is this possible using the exceljs module?

If I print out the cell.value.result before and after, it is unchanged. (!?!)

I experienced the same issue here and did the same. Had to change the whole object. Any idea why this is happening?
I did console log of the property descriptors of the object. Both cell.value.formula as well as cell.value.result are enumerable, configurable as well as writable. But I still was not able to override the cell value result.

With regard to the question asked by @ifocusdata, having Excel running in the background as a calculation engine is NOT possible using the exceljs module. The exceljs module is not Excel, and it is completely oblivious to whether Excel is installed on the machine or not. It is merely a Javascript/Node module that reads and writes an Excel-formatted file.
At the time I described the work-around (described in a previous comment), if you wanted to change the value of a cell, and if that cell should cause other cells to be updated, you had to compute those new values yourself and use my work-around.
The documentation (https://www.npmjs.com/package/exceljs#formula-value) seems to indicate that my work around is in fact the way that the module is to be used. Also, "Note that ExcelJS cannot process the formula to generate a result, it must be supplied." So for @WinstonMarvel, all I can say is that the documentation I just cited says to do it the way I eventually found to do it.
Having said that, it would be a nice (but difficult) enhancement to write a workbook.recalculate() method or a worksheet.recalculate() method that would emulate what Microsoft Excel does in recalculating values. This would have to parse every formula and implement every Excel formula function, and it might be able to get most of the calculations right. (There would still be lots of complex issues it would probably never get right like references to cells in other spreadsheets, etc.)
Alternatively, it would still be nice to know how to modify the file so that when it is opened in real Excel, Excel would automatically do the recomputations. This is the problem I was stuck on that caused me do my own (limited) recomputations.


Memory leak on version 3.29.0

Expected Behavior
Calico uses resources correctly and without memory leaks.
Current Behavior
We are observing a memory leak on version calico 3.29.0. The problem with the account is observed on the controller and nodes.

log.txt
Also, we noticed an increase in the exec-time (felix_exec_time_micros) and an increase in Internal Dataplane Msg Batch Size (felix_int_dataplane_apply_time_seconds)

calico-node-log.txt
Steps to Reproduce (for bugs)

Install calico version 3.29.0
after 3-7 days check metrics memory utilization of pods calico and check increase memory utilization
after 3-7 days check increase metrics of felix_exec_time_micros and felix_int_dataplane_apply_time_seconds

Your Environment

Calico version is 3.29.0 on ebpf dataplane.
Felix configuration

apiVersion: crd.projectcalico.org/v1
kind: FelixConfiguration
metadata:
  annotations:
  name: default
spec:
  bpfEnabled: true
  bpfExternalServiceMode: Tunnel
  bpfLogLevel: ""
  logSeverityScreen: Debug
  prometheusMetricsEnabled: true
  reportingInterval: 0s
  vxlanEnabled: true
  vxlanPort: 4799
  vxlanVNI: 4096

Orchestrator version (e.g. kubernetes, mesos, rkt): kubernetes v1.22.15
Operating System and version: Ubuntu 20.04.4 LTS, kernel: 5.15.0-67-generic, cri: containerd://1.5.5
calico-3.29.0-manifest.yaml.txt

after 3-7 days check metrics memory utilization of pods calico and check increase memory utilization

Is there a pod churn or is the cluster stable in terms of pods and services? Do you also observer the same with iptables (if you also use iptables only or anyone observing this issue)

@legolego621 would you be able to provide us with some memory profiles?
KubeControllersConfiguration has a DebugProfilePort field that enables a profile server: https://github.com/caseydavenport/calico/blob/627acd5bd2ab181df998d0933e627149ef9c38bf/api/pkg/apis/projectcalico/v3/kubecontrollersconfig.go#L66-L68
For felix, set DebugMemoryProfilePath and then send felix a sigusr1 or enable the debug server in felix by setting DebugPort/Host

@tomastigera
Hi, I'll be able to check this closer to Monday.
Thanks

@tomastigera
Hello, I received the profile file.
Attached to message.
I set in KubeControllersConfiguration debugProfilePort (I think it was useless for me).
I set in FelixConfiguration
debugHost: <IP_ADDRESS>
debugPort: 9792
debugMemoryProfilePath: /tmp/felix-mem.pprof

apiVersion: crd.projectcalico.org/v1
kind: KubeControllersConfiguration
metadata:
  name: default
spec:
  controllers:
    namespace:
      reconcilerPeriod: 5m0s
    node:
      leakGracePeriod: 15m0s
      reconcilerPeriod: 5m0s
      syncLabels: Enabled
    policy:
      reconcilerPeriod: 5m0s
    serviceAccount:
      reconcilerPeriod: 5m0s
    workloadEndpoint:
      reconcilerPeriod: 5m0s
  debugProfilePort: 9792
  etcdV3CompactionPeriod: 10m0s
  healthChecks: Enabled
  logSeverityScreen: Info
  prometheusMetricsPort: 9094

---
apiVersion: crd.projectcalico.org/v1
kind: FelixConfiguration
metadata:
  generation: 13
  name: default
spec:
  bpfEnabled: true
  bpfExternalServiceMode: Tunnel
  bpfLogLevel: ""
  debugHost: <IP_ADDRESS>
  debugMemoryProfilePath: /tmp/felix-mem.pprof
  debugPort: 9792
  logSeverityScreen: Info
  prometheusMetricsEnabled: true
  reportingInterval: 0s
  vxlanEnabled: true
  vxlanPort: 4799
  vxlanVNI: 4096

On node
$ ss -ntpl | grep 9792
LISTEN    0         30000            <IP_ADDRESS>:9792             <IP_ADDRESS>:*        users:(("calico-node",pid=11099,fd=11))
$ ps -aux | grep calico
root      6857  0.0  0.3 1943344 62516 ?       Sl   13:15   0:00 calico-node -status-reporter
root      6859  0.0  0.3 2091320 64696 ?       Sl   13:15   0:00 calico-node -allocate-tunnel-addrs
root      6860  0.0  0.3 1944112 62964 ?       Sl   13:15   0:00 calico-node -monitor-addresses
root      6861  0.0  0.3 1943856 59552 ?       Sl   13:15   0:00 calico-node -monitor-token
root     11099  1.9  0.5 3419776 95608 ?       Sl   13:18   0:13 calico-node -felix
root     19466  0.0  0.0   3444   724 ?        R+   13:30   0:00 grep --color=auto calico
$ kill -SIGUSR1 11099

felix-mem.zip

@tomastigera
Hi, were you able to view the profile?

It doesn't show anything exciting, there is about 16M of mem used, no massive outliers:
Showing nodes accounting for 8424.94kB, 50.65% of 16632.95kB total
Showing top 10 nodes out of 158
      flat  flat%   sum%        cum   cum%
 1541.19kB  9.27%  9.27%  1541.19kB  9.27%  regexp/syntax.(*compiler).inst
 1106.08kB  6.65% 15.92%  1106.08kB  6.65%  github.com/gogo/protobuf/proto.RegisterType
 1033.49kB  6.21% 22.13%  1033.49kB  6.21%  regexp.onePassCopy
 1026.25kB  6.17% 28.30%  1026.25kB  6.17%  github.com/projectcalico/calico/felix/config.loadParams
 1024.10kB  6.16% 34.46%  1024.10kB  6.16%  fmt.Sprintf
  583.01kB  3.51% 37.96%   583.01kB  3.51%  github.com/projectcalico/calico/felix/bpf/proxy.(*Syncer).apply
  536.37kB  3.22% 41.19%   536.37kB  3.22%  github.com/projectcalico/calico/felix/bpf/proxy.(*Syncer).startupBuildPrev.func1
  536.37kB  3.22% 44.41%   536.37kB  3.22%  github.com/projectcalico/calico/felix/deltatracker..ReplaceAllIter.func1
  520.04kB  3.13% 47.54%   520.04kB  3.13%  golang.org/x/net/http2.init.func5
  518.02kB  3.11% 50.65%   518.02kB  3.11%  k8s.io/kubernetes/pkg/proxy.(*EndpointSliceCache).updatePending

How did you obtain the profile? We would need a heap profile like http://localhost:6060/debug/pprof/heap

Another possible leak; could be a dupe: https://github.com/projectcalico/calico/issues/9603

@legolego621 please can you try this nightly build of v3.29.next https://2024-12-19-v3-29-viper.docs.eng.tigera.net/ (follow the usual docs but replace the .yaml you'd apply with the one from the link).  It fixes a file handle leak, which may be the cause of the memory leak that you're seeing.

@fasaxc Hello, Thank you very much for the patch. We has started testing this version of calico.
I`ll be back with feedback after 1 week.
I have a small question, I see the following logs on the controller.


Training does not work properly and agent does not beyond first traffic light in TOWN02

Hello Idree,
I was going through your code, and I had a question about a specific part of it. I was training a new agent from scratch in TOWN02. The training was going well (the average reward is increasing every timestep), however, out of a sudden at any point the training stopped and then “exit” is printed in the command window prompt. Basically, the training is not finished, and it does not get to the end of the training (the print “Terminating the run” does never appear). I run the training several times and still doing the same situation but at different timesteps. I am making sure that in the while loop timestep < TOTAL_TIMESETPS, does not break because of this condition.  I have attached a screenshot of the situation when the training stops and jumps to the printed exit. I don’t know if run into a similar issue.
Another issue is that the agent does not go beyond the first traffic light corner. I run the code until 2M timesteps but every time the agent restart and stops in that specific point. I don't not if this issue is related to training is stopped unexpected.
Thank you,
Oscar

Hello Idree,
I was going through your code, and I had a question about a specific part of it. I was training a new agent from scratch in TOWN02. The training was going well (the average reward is increasing every timestep), however, out of a sudden at any point the training stopped and then “exit” is printed in the command window prompt. Basically, the training is not finished, and it does not get to the end of the training (the print “Terminating the run” does never appear). I run the training several times and still doing the same situation but at different timesteps. I am making sure that in the while loop timestep < TOTAL_TIMESETPS, does not break because of this condition. I have attached a screenshot of the situation when the training stops and jumps to the printed exit. I don’t know if run into a similar issue.
Another issue is that the agent does not go beyond the first traffic light corner. I run the code until 2M timesteps but every time the agent restart and stops in that specific point. I don't not if this issue is related to training is stopped unexpected.
Thank you, Oscar
I think you have the same problem with me, what is your carla version? I trained it in town7 and it will exit in less than 150 eposides

Hello Idree,
I was going through your code, and I had a question about a specific part of it. I was training a new agent from scratch in TOWN02. The training was going well (the average reward is increasing every timestep), however, out of a sudden at any point the training stopped and then “exit” is printed in the command window prompt. Basically, the training is not finished, and it does not get to the end of the training (the print “Terminating the run” does never appear). I run the training several times and still doing the same situation but at different timesteps. I am making sure that in the while loop timestep < TOTAL_TIMESETPS, does not break because of this condition. I have attached a screenshot of the situation when the training stops and jumps to the printed exit. I don’t know if run into a similar issue.
Another issue is that the agent does not go beyond the first traffic light corner. I run the code until 2M timesteps but every time the agent restart and stops in that specific point. I don't not if this issue is related to training is stopped unexpected.
Thank you, Oscar

@DeLeonOscar Can I ask you something? With what parameters did you achive those results? Bacuse I am running it for a few days now with differenet experimentes but my rewards are keep getting increased in a much lower degree.


Check we're handling .sass files correctly

Once https://github.com/andrew/node-sass/issues/324 has shipped we'll have pretty much automatic support for .sass files thanks to https://github.com/hcatlin/libsass/pull/181/files by @mgreter.
We'll need to check that this is working correctly and add some tests for .sass files.
The only place I can see that needs to be updated is in https://github.com/andrew/node-sass/blob/master/lib/middleware.js#L82-L89, as well as updating documentation everywhere to show we support both kinds of syntax.

Hi there,
I was wondering whether .sass syntax is supported via data? like the example below:
var result = sass.renderSync({
  data: '$font-family: \"Helvetica Neue\", Helvetica, Arial, sans-serif\r\n$font-size:   13px\r\n\r\n$brand-primary: darken(#428bca, 6.5%)\r\n$brand-success: #5cb85c\r\n\r\n\r\nbody\r\n  min-height: 100%\r\n  font-family: $font-family\r\n  font-size: $font-size\r\n  ',
  success: function (result) {
    console.log(result.css)
  }
});

@pongstr, certainly with indentedSyntax set to true like so:
var result = sass.renderSync({
  data: '$font-family: \"Helvetica Neue\", Helvetica, Arial, sans-serif\r\n$font-size:   13px\r\n\r\n$brand-primary: darken(#428bca, 6.5%)\r\n$brand-success: #5cb85c\r\n\r\n\r\nbody\r\n  min-height: 100%\r\n  font-family: $font-family\r\n  font-size: $font-size\r\n  ',
  indentedSyntax: true,
  success: function (result) {
    console.log(result.css)
  }
});

produces:
// on probing 'result'
{ stats:
   { entry: 'data',
     start:<PHONE_NUMBER>878,
     includedFiles: [],
     end:<PHONE_NUMBER>886,
     duration: 8 },
  css: 'body {\n  min-height: 100%;\n  font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;\n  font-size: 13px;
}\n',
  sourceMap: '{}' }

Thanks @am11

@andrew, should this be closed as resolved? Also, we have couple of tests for indented syntax to signify: all is well. :sunglasses:


Update the style guide with to improve topic segmentation and branching

See: https://docs.google.com/document/d/1LU-szHDxPqmwqu_mYhr3fCE0f2cSWhPhDMELuWiyu_I/edit

Duplicate of #18


Can this project support embeded payload in FCM notifycations.

The payload can be used when push by APNS, but payload couldn't be supported if used FCM.

Sorry, I have made a mistake, this project support payload verywell.


Please add an option to configure composer root path

Hey, @jaguadoromero
Thank you for this useful extension!
After c32bbd4bce92ddd9946211cc3b24d33a4cb7e8e4 the plugin is disabled for projects with composer.json in a subfolder instead of project root.
Can you please add an option to configure the project root folder?
Thanks!

the instructions on the extension page are not clear. side by side when we try to create a new class that time the error message says that the command "phpCreateClass.createClass" is not found.

now my question where should I add these commands? please give us proper instructions

@ktogias  Since version 1.11.0, the plugin is activated also when composer.json is present in a subfolder and detects the correct namespace


Predicting using Cityscapes

💡 Your Question
Hello,
I want to predict using the Cityscapes dataset and weights available from the model zoo.
I tried using this notebook as a base, but I keep running into a problem with this line: mask = ToPILImage()(mask.float())
Since the function ToPILImage() takes an image with 1, 3 or 4 channels. I want to use all 19 classes of Cityscapes, is this possible? When I predict using 1, 3, 4 channels I don't get good results.
Thank you
Versions
No response

@shovalfaibish We will introduce soon .predict() functionality for our segmentation models (like we have for YoloNAS).
The notebook's predict is fixed for binary labels,


bug: cairo-lang-casm does not compile making cairo-test uninstallable

Bug Report
Cairo version: tried all
Current behavior:
Not having any trouble install/compiling Rust packages in general, but none of the following commands work:
cargo install cairo-lang-test-runner
cargo install<EMAIL_ADDRESS>cargo +nightly install cairo-lang-test-runner

FYI - the installation process until failure is also very slow (~2-5 min.).
Here is an example of an error (but there are many more):
note: associated function defined here
   --> /Users/~/.cargo/registry/src/github.com-1ecc6299db9ec823/cairo-vm-0.1.3/src/vm/vm_core.rs:105:12
    |
105 |     pub fn new(trace_enabled: bool) -> VirtualMachine {
    |            ^^^
help: remove the extra arguments
    |
293 |     let mut vm = VirtualMachine::new(true);

...

error: could not compile `cairo-lang-casm` due to 34 previous errors
warning: build failed, waiting for other jobs to finish...
error: failed to compile `cairo-lang-test-runner v0.1.0`, intermediate artifacts can be found at `/var/folders/2r/klcq017520n9y17fq1wklky80000gn/T/cargo-installdQu0Tf`

Suggests that different versions are being compiled at once.
Expected behavior:
It should successfully install.
Steps to reproduce:
cargo install cairo-lang-test-runner

Reproduction:
This is the branch where CI fails:
https://github.com/auditless/cairo-erc4626/pull/17
This is the failing CI run:
https://github.com/auditless/cairo-erc4626/actions/runs/4231249943/jobs/7349532142

I also tried compiling cairo locally by running cairo build on the repo and it also fails due to a cairo-lang-casm compiler error.

Closing as @abdelhamidbakhta confirmed that this is not a valid installation path right now.


Refactor RequestBuilder and Endpoint

Issue/Task Number: related to #45
Overview
I implemented some of the proposed changes in #45.  I refactored RequestBuilder so that only this class is responsible for building url requests. This pull request does not cover refactoring on HTTPClient and Request, only covers RequestBuilder and  Endpoint.
Changes
I moved methods in RequestParameters for adding header fields to requests, and removed RequestParameters class. From now on, necessary information to build url requests (except for endpoint) is passed via ClientConfiguration class.

Thank you for the review. I will fix them.

Sorry, for the self. I meant that you should update it everywhere when needed :)

In case you missed my replay above, it is ready for reviewing!

Can you add self. where missing please ? :)

@mederic-p Thank you. I edited AUTHORS file. it's good to go💪🏻


removed run script as no longer needed in lieu of make commands

What
Removed the run script as this is no longer in use, in lieu of Make commands being accessible.
Additional project files were auto generated; have left them in as I was unsure if they're required.
How to review
Check that run script is removed and app still builds
Determine whether or not the auto generated files are needed, or if they can be deleted
Who can review
Describe who worked on the changes, so that other people can review.

Might want to remove eclipse project files from this PR and then also add them to the .gitignore
.settings
.classpath
.project


HA>Edit Config missing edit button

Hi,
First off love the changes to the interface, looks awesome.
It looks like the edit button is missing on the HA > Edit Config page.
The servers are listed and available from the drop down, but you cant edit.
That's on v3.5.1
R

Thank you)
I will check it and fix
Отправлено из Mail.ru для Android понедельник, 07 октября 2019г., 10:01 +03:00 от rabievdm<EMAIL_ADDRESS>:

Hi,
First off love the changes to the interface, looks awesome.
It looks like the edit button is missing on the HA > Edit Config page.
The servers are listed and available from the drop down, but you cant edit.
R
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly,  view it on GitHub , or  mute the thread .

I fixed it, please update and try

Working


PDF version rather broken

I normally like to use the PDF version of guides, but the PDF version of your (otherwise great) guide is pretty terrible compared to the web version:

TOC doesn't contain links to sections
Images on different pages than their description
Page breaks in the middle of sentences:

Page breaks in the middle of tables:

Page breaks in the middle of code blocks:

I realize most of this is because it's not easy to make PDF-friendly pages in Markdown, but especially the dead links are annoying, and I'd expect the tooling to try to avoid page breaks at silly places when possible. Are there really no good MD to PDF tools, or is it a matter of configuration?
I'd maybe also consider finding a way to scale back on the "help and discussion" links. They're huge and annoying in the PDF. Maybe just have an icon that links to the relevant h&d page (with a note on what these icons are in the preface)?
Anyway, thanks for an amazing guide. It really takes a lot of the doubts and questions out of starting with the AWS serverless products!

Ah, I see you're already looking for better ways. I'll leave this open for now, maybe then it can function as a kind of registry over some of the drawbacks to the current way (I guess it's MD->HTML->PDF).

Hey @LosD, we are working in this improvement, please take a look a this pdf version and epub too and give us your feedback, still needs improvements, but as its so long its better to have more eyes on it.

@pepas24 It's been a while, but from what I remember, readability has improved A LOT :)
Still some issues with code and tables crossing page breaks when small adjustments could have avoided it, but I'm not sure there's really a way around it without either some stringent rules, or manual inspection (and of course, sometimes it's just too long), so it's probably not worth it to fuss too much about.
Still quite a few problems with fitting text and images. For a pretty bad example, check page 660-672: There's a sentence and an image on each page... But the text is always referencing the image on the next page, making the whole section rather confusing. I realize that it's not easy to fix, but in this case, I think the extra work would be worth it to help readibility.
Unfortunately, there's still no links to sections in the TOC.
Anything I can do to help?


test: add more converage on GetComposeStatus method

Description
Add new unit test cases to getComposeStatus method on client/imageBuilder
FIXES:
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[X] Tests update
[ ] Refactor

Codecov Report
Base: 53.88% // Head: 57.25% // Increases project coverage by +3.36% :tada:

Coverage data is based on head (57a05c5) compared to base (a7328d4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1927      +/-   ##
==========================================
+ Coverage   53.88%   57.25%   +3.36%
==========================================
  Files          70       70
  Lines        9932     9944      +12
==========================================
+ Hits         5352     5693     +341
+ Misses       4106     3738     -368
- Partials      474      513      +39

Impacted Files
Coverage Δ

pkg/services/updates.go
68.89% <0.00%> (-0.09%)
:arrow_down:

config/config.go
59.78% <0.00%> (+0.07%)
:arrow_up:

pkg/routes/imagesets.go
65.74% <0.00%> (+2.07%)
:arrow_up:

pkg/clients/imagebuilder/client.go
57.77% <0.00%> (+11.14%)
:arrow_up:

pkg/services/images.go
57.21% <0.00%> (+19.74%)
:arrow_up:

pkg/services/repo.go
100.00% <0.00%> (+66.66%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


computed() doesn't update when deleting from a ref(Map)

Vue version
3.3.4
Link to minimal reproduction
https://play.vuejs.org/#eNrFVt9v2zYQ/lcuwgDb8K+leTMcd93QhwxYF3QF+jANCS2dbTYyKZCUnSDI/76PpKTItedtfWmCKCL53d133/FIPSfvynKyqziZJXObGVk6suyqcpEquS21cfRMmd6WleN8RIZX9EIro7fUg1EvVamaTkluxVoqJrcRDg+m+9LovMqcvadcOOE9sI12QtG72xv8y1u4ZRKGqbEJLsNarlXP0UbsvGuWBhCZwREYUlVOSOn9iPZMe6HgSNMDc0nSgc+2cmJZcHDlQ2lVPMHMB9WB4VJkD34oYPQ03omiAgEhzSisYo6WLNU6jGpidzJv/fnpYBTxiveRW6oyraxrc6Fr+jNVRM/+QSTzGV2O4rsSW55R7xNbdwkhiV7CQgf55hj55jTy6hzyr7pKn5kyw8JB7UD4N1FCvQ1Deq+hLAqyTmNUK9BRBTVp8goFuPY7oV876Q8GdYRaGeXrvfQbYqndJrhrKxKKb9iWcOeDYl1XBjMicxJ1xs7xEe5pK8omaLP/bmtRP8PqtiHSLPb7A7pedDYR0QQ++qtKwbNW1L8rzaAVbUX9GGkSspxshPWAicwHLYjIzwQYAh3A1+waOA2pRz8EtaG3V8K/GDSRUd5BKEMrkdtIi90IkY1cr9lYFMNwnQTJIF3MBxYxfalQti0rF3IGEx85ZHmD6Mg50PUZXZxKqUG2aR2A0Eod0Ih+RNhX/oG7f/i/Al13h5o3NE4J0tIa0qW3ORurdYaYQbhv0yfn763P/1ZnHNXxnF5tFnD+nzh0dQvx6xJ15cs1WxyeF41IUEjv+J8UOgiXM3LhLiRV82m8HHAtYOB4WxY4SDAimudyF0nvxittrtMEnRUsR/4UGXSLdtzBaRJtZ4DCFM84E1zjjHtuOnrizzZ6CakSjfFzhIid+vYt9T7omFK4KZ7Y9U4YzpeVczgXfsoKmT0g9uE+apLwLZ4mi/F4Po0GNbMj88M2/cp8OPw3806BvrL9GFZiQgde5lNIHyqC94vxmCBd+M15Wa2bAfRfaeQdTTam/n+5aI7K+RSDcKG0Utpar0O4r9chOJzBp6DRy/DY5sxZ7v3Mp+3eSkaJs9i8K7mefLFa4QslNEeaeB+yYPN76Q92bKFZ0zZpIopC738Nc87gem7msw1nDyfmv9hHP5cmt7iU2Ow4Tdo1JwwaNy6//+MDP+K9XdyCPz4wzi1+ZKuLynOMsJ8rlYN2BxfY3oTvLHxsfLLvHx0r2yTlib5e92mCL65fzqT+SvdqctWcDMnL35OqU88=
Steps to reproduce
1- Create a new ref with a new Map inside like the following: const prices = ref(new Map())
2- Define a computed() fn that uses the ref with the Map
3- Delete item from Map and see how that doesn't trigger a recompute. (Keep in mind .set() does trigger a recompute.)
What is expected?
Trigger a recompute when deleting item from Map
What is actually happening?
It doesn't trigger a recompute when deleting an item from Map
System Info
No response
Any additional comments?
No response

I believe the computed is recomputing as expected.
The problem is that you're modifying the items in products inside computedProductsWithPrices. That would be considered a side effect and should be avoided. When the price is deleted from the map it is re-running computedProductsWithPrices, but the old value for price is still present on the item in products from the last time it ran.
The debug info you're including in the template is misleading. products is being changed, but the updated version is not being rendered because products in not reactive.
Here's a tweaked version of your example, but with the addition of delete _pr.price inside computedProductsWithPrices to remove the old price. It works fine:
Example
However, as I noted earlier, the computed here still has a side effect. A better way to do this would be to avoid modifying products in the first place by taking a copy of each item before adding the price property:
Example


Error

That look fine and working, Just browse http://<IP_ADDRESS>:4000/ I don't think its not working.

why this not working
On Thu, Jul 27, 2017 at 9:02 AM, Devkota<EMAIL_ADDRESS>wrote:

That look fine and working, Just browse http://<IP_ADDRESS>:4000/ I don't
think its not working.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Classof2020/classof2020.github.io/issues/38#issuecomment-318247213,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXTBedmytsw3-hOFZooCL-qgoz9uSeNLks5sSAE3gaJpZM4OkQmH
.

I've added a favicon, fixed this!


Fix digest email links

To test this:
Log on as Hamlet.
Have Hamlet send Cordelia two PMs--one direct, one huddled w/Othello.
Log out.
Watch server log for missed message emails (can be a minute or so).
Only now log on as Cordelia.
Go to "/emails" page.
Verify links in missed message emails addressed to Cordelia.

The modern URLs are less likely to break due to email changes or strange encoding bugs (in either our code or browsers or email clients or anything in the path).

Looks great, merged, thanks @showell!  Glad to see the us finishing what are hopefully the last bits of this migration.


[Form Validation] How to change identifier?

On the usage page for form validation it says

A validation object includes a list of form elements, and rules to validate each against. Fields are matched by either the id tag, name tag, or the data-validate metadata matching the identifier provided in the settings object.

It's unclear to me what settings exactly I need to change in order to change the identifier. Is it the metadata property under DOM Settings?

either specify a form fields name, id or data-validate="' property.
Here's an example of all three (although you only need one to match)
<input type="text" name="username" id="username" data-validate="username">

Ah so it checks all the fields. Thanks!


Update https://nixos.org/nixpkgs/packages-unstable.json.gz more frequently

We have started to use "Repology" data in Nixpkgs through nix-update. Repology takes the .json file provided by nixos.org and finds outdated packages. It updates hourly.
This works well, but the data is frequently out of date:
$ curl -I https://nixos.org/nixpkgs/packages-unstable.json.gz
HTTP/1.1 200 OK
Date: Sun, 25 Mar 2018 03:22:34 GMT
Server: Apache/2.4.29 (Unix) OpenSSL/1.0.2n
Strict-Transport-Security: max-age=15552000
Last-Modified: Wed, 07 Mar 2018 16:00:44 GMT
ETag: "13c573-566d4a9650dba"
Accept-Ranges: bytes
Content-Length: 1295731
Content-Type: application/json
Content-Encoding: x-gzip

Can we set this to update more frequently? It's currently more than 2 weeks old, giving us bad data from Repology.

Not exactly. The update happens once per week:
https://github.com/NixOS/nixos-org-configurations/blob/cf5d68f9e5d735f8ed47c710d31d8f821b5258cf/nixos-org/webserver.nix#L267
If the channel hasn't update since then, it will take even longer. Maybe this can be put into a release job?

@matthewbauer easiest bet would be to just update the startAt to happen more frequently, and send a PR.

@matthewbauer That actually means it runs every 20 minutes.

There's some problem there.  The last update of both points to commits done on July 10.  We've had lots of channel bumps since then.

This time, it looks like the error is:
[nix-shell:~/.../nixos/nixos-homepage]$ make nixpkgs/packages-unstable.json.gz
nixpkgs=$(nix-instantiate --find-file nixpkgs -I nixpkgs=https://nixos.org/channels/nixos-unstable/nixexprs.tar.xz); \
(echo -n '{ "commit": "' && cat $nixpkgs/.git-revision && echo -n '","packages":' \
  && nix-env -f '<nixpkgs>' -I nixpkgs=https://nixos.org/channels/nixos-unstable/nixexprs.tar.xz -qa --json --arg config 'import ./discover-more-packages-config.nix' \
  && echo -n '}') \
  | sed "s|$nixpkgs/||g" > nixpkgs/packages-unstable.json.tmp
error: 'mkHomepage' at /nix/store/kzah1l6dcmc0ci49bk2cpa0b2pjhi4m8-nixexprs.tar.xz/pkgs/development/r-modules/default.nix:54:18 called with unexpected argument 'biocVersion', at /nix/store/kzah1l6dcmc0ci49bk2cpa0b2pjhi4m8-nixexprs.tar.xz/pkgs/development/r-modules/default.nix:35:21
python -mjson.tool < nixpkgs/packages-unstable.json.tmp > /dev/null
No JSON object could be decoded
make: *** [Makefile:226: nixpkgs/packages-unstable.json] Error 1

Well, there was another error 👀. It just updated. Funny how there was more than one error at once...

How hard would it be to have the manual, packages-unstable.json.gz, NixOS options set be generated and published by a hydra jobset directly? It would be more natural if these things were updated simultaneous to a channel release.

Closing this, as the issue is separate (monitoring, or a hydra publish job, etc.)


Deezer Recommendations

At this moment, the Deezer public API does not provide a method for getting recommended tracks based on (a) track(s). Feel free to comment on ideas for getting recommendations from Deezer.

If related tracks information is not available, we can use search() with artist name.

This might create a loop where after a certain song, it repeats itself due to deezer returning the most popular song of the artist as its first pick.

We can use youtube for related songs by searching song name with artist name

This might create a loop where after a certain song, it repeats itself due to deezer returning the most popular song of the artist as its first pick.

random selection it is


Mouse without borders - change temporary clipboard path to some system's temporary folder

Description of the new feature / enhancement
Now all copied files from mouse without borders appear on the desktop. Change it to some temp folder, so I don't need to remove these files to clean up desktop
Scenario when this would be used?
someone wants to have a clean desktop needs to remove these files
Supporting information
No response

This is exactly the feature I want. That is to make the folder path configurable.


drop restify-clients dep, use restify.createJsonClient

Originally this was added in #1 to get a newer restify-clients that
supported the requestTimeout client option. Since then the restify
dep was updated to a ver (4.x) that supports these options with its
'restify.createJsonClient'.

Actually, at this point I haven't verified that this will work to solve the MANTA-4030 issue. The particular case is for mackerel -> libmanta -> moray -> fast -> kang -> restify.   That depth makes it hard/tedious for me to jigger up npm installable deps that will verify this.

Okay, I was wrong on the dependency chain. This change will not help mackerel workaround the MANTA-4030 issue. I've removed the following from the opening comment:
This change has one side-effect that will help apps that use kang to
workaround the<EMAIL_ADDRESS>breakage. Currently with both restify
and restify-clients as deps -- each with their own different lru-cache
dependency -- one cannot explicitly add a higher-level `"lru-cache":
"4.1.3"` dep and have `npm install` (at least with npm@2) avoid the
restify@4 dep installing<EMAIL_ADDRESS>See MANTA-4030 for details.

However, the change is still worthwhile to reduce the number of deps that kang has.

I almost wonder if we should drop restify instead?  I've usually preferred restify-clients because it seems to be smaller and more stable.  I think restify is only in there for the convenience of being able to start up a server for you, but we could make this an optional dependency or just provide a handler and have end users start the server?

Handled by https://github.com/joyent/kang/pull/10


Restarting from point when termination occurred

Hi,
I'm wondering if there is a way to start the run from a place where the job was terminated. In this instance, my job took longer than anticipated and was terminated due to the maximum time being reached. I can see from the time.tsv file that the final steps were being processed when the job was terminated.
Thank you
Mike

I don't think we have implemented that yet. It's in our list of things to do. Try 1.4 with HydraMPP it's super fast.

Version 1.4.0 has some improvements on this feature, although it is not fully tested and still experimental.

We are working on a way for it to restart mid-way for MetaCerberus. But, it's currently not ready. We will let you know when it is. However, HydraMPP in 1.4 is so much faster than Ray that it may be better just to re-run it.
Closing for now. Let us know if you have any other questions?
Thank you for using MetaCerberus.


Failed to compile

Description
I have tried to compile the application right after downloading the application.
I have not modified any files yet.
  Line 11:61:  Parsing error: Unexpected token, expected ","

   9 |
  10 | export default function useRoom(localTracks: LocalTrack[], onError: Callback, options?: ConnectOptions) {
> 11 |   const [room, setRoom] = useState<Room>(new EventEmitter() as Room);
     |                                                             ^
  12 |   const [isConnecting, setIsConnecting] = useState(false);
  13 |   const optionsRef = useRef(options);
  14 |

To Reproduce

Clone from git
npm install
npm run build

Environment (please complete the following information):

OS: Windows 10
Browser: Google Chrome | 86.0.4240.75 (Build oficial) (64 bits) (cohort: Stable)
App Version: 0.2.0
Node.js version: 12.14.1

Log
0 info it worked if it ends with ok
1 verbose cli [
1 verbose cli   'C:\\Program Files\\nodejs\\node.exe',
1 verbose cli   'C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js',
1 verbose cli   'run',
1 verbose cli   'build'
1 verbose cli ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prebuild', 'build', 'postbuild' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: [...]
9 verbose lifecycle<EMAIL_ADDRESS>CWD: C:\twilio-video-app-react
10 silly lifecycle<EMAIL_ADDRESS>Args: [ '/d /s /c', 'node ./scripts/build.js' ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec build script
13 verbose stack Error<EMAIL_ADDRESS>build: `node ./scripts/build.js`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\index.js:332:16)
13 verbose stack     at EventEmitter.emit (events.js:223:5)
13 verbose stack     at ChildProcess.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\lib\spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:223:5)
13 verbose stack     at maybeClose (internal/child_process.js:1021:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd C:\Users\Víctor\Desktop\NODE\twilio-video-app-react
16 verbose Windows_NT 10.0.18363
17 verbose argv "C:\Program Files\nodejs\\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "build"
18 verbose node v12.14.1
19 verbose npm  v6.13.4
20 error code ELIFECYCLE
21 error errno 1
22 error<EMAIL_ADDRESS>build: `node ./scripts/build.js`
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>build script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

Thanks for the bug report @VGordillo-Resulto!
Unfortunately, I'm not able to reproduce the issue you described. I tried the steps you described on a MacOS and a Windows 10 machine, and I was able to successfully build the app both times.
I found an issue reported on Stack Overflow where a user encountered the same error as you did, also in a create-react-app application. The issue is here: https://stackoverflow.com/questions/60547153/eslint-parsing-error-unexpected-token-on-typescript-cast-operator-as
One user stated in their solution: "I had to correct PATH and make sure workspace folders are detected correctly."
Maybe your app is using a configuration that might be available in a parent directory? Also, in your error message, line 9 shows that the CWD is C:\twilio-video-app-react, but line 15 shows the CWD as C:\Users\Víctor\Desktop\NODE\twilio-video-app-react. I'm not sure what this would mean, but perhaps it's clue.
Sorry I couldn't be of more help. Hopefully the stack overflow issue will point you in the right direction.
In the meantime, I'll close this issue, as it appears that the bug does not exist in this app. But please do let me know if you have any other questions. Good luck!


After change the Graph widget Style, the position is recover

Technical
WATT/VSC
Description
After change the Graph widget Style, the position is recover
Steps to reproduce

Create a new project in Design Editor
Drag&Drop the Graph widget
move the position to below
Select the Graph and Attribute -> Style -> Change to "bar chart"

Expected behaviour
Keeping the position
Actual behaviour
Move the position

Work in progress. I have to fixup few more things before it would be finish and clean up the commit.
https://github.com/pkaczmarczy/TAU-Design-Editor/tree/issue-271-graph-is-moved-after-changing-pre-defined-style

The PR fixes the problem with graph.
To fully replace previous functions we need to:

Add way of defining child elements inside template
Implement mechanism of filling template content based on element content (see listelement components)
Convert old-style templates to new definitions

Also graph has problems with dynamicly changing chart type (without destroying widget as previously).

PR has been merged.
Graph widget change will be visible after TAU update in WATT.

@pkaczmarczy could you check with @TomaszLukawskiSam TAU update?

@pkaczmarczy I updated TAU in WATT
https://github.com/Samsung/WATT/commit/d7f9891752c9f0c1a1d91bee73e1c9ba829e3243

@singa2000 I tested this change with latest TAU 1.1.4 project in VSC,
after grapgh type change no movement occurs

I test latest TAU 1.1.4 project in VSC,
After graph type change Attribute->Widget Options-> Graph Type no movement occurs.
But Attribute -> Style , I can't select the Time series or Multiple series.
The Attribute Style is same with Attribute Widget Option Graph Type?
If so, would you remove the Attribute Style of Graph widget?

@singa2000 issue you mention was reported for TAU
https://github.com/Samsung/TAU/issues/347
problem is with refreshing wiget
Temporary I disabled graph styles in
PR https://github.com/Samsung/TAU-Design-Editor/pull/363

DE PR 363 merged

We can close the issue


Question: Support for JSX file extension

Does next.js support the jsx file extension? From trying locally under dev it seems that only .js files are loaded not .jsx?
If this is the case is not supposing .jsx in the loader a deliberate design choice?
Thanks

@timReynolds next.js does not support the jsx file extension. There are many reasons for limiting to js files being simplicity for pages detection and linting configuration some of them.


Let ConfigurationCacheBuildServiceIntegrationTest out of flaky test quarantine

Fixes #24887.

The merge queue build has failed. Click here to see all failures.

WARN: The milestone of this PR is 8.10 RC1, but the base branch version is 8.9


no error information in some cases

If the validation in ./src/nni_manager/rest_server/restValidationSchemas.ts fails, the experiment will fail then. In this case, there is no error information, and nnictl could not find the experiment's information, such as experiment id.

https://github.com/Microsoft/nni/pull/75


Vpath

This resolves #3.

Kicking this back to you for rebasing ('cause you told me to!)

Reopening and assigning to myself for the rebase. The rebased code will show up in this same PR when it's ready.


glTF-loaded actor material sync failure

glTF-loaded actors always initially have their glTF material, not the current material assigned to that actor in the app. Those update patches aren't getting applied, if they're sent at all.

Confirmed, this is all-up actor patching when the actor was batch-generated.


KYLIN-3851 Flink cubing step : merge dictionary

JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3851

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Codecov Report

:exclamation: No coverage uploaded for pull request base (engine-flink@ea34ffc). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             engine-flink     #540   +/-   ##
===============================================
  Coverage                ?   24.14%
  Complexity              ?     5029
===============================================
  Files                   ?     1173
  Lines                   ?    71300
  Branches                ?    10111
===============================================
  Hits                    ?    17215
  Misses                  ?    52345
  Partials                ?     1740

Impacted Files
Coverage Δ
Complexity Δ

...he/kylin/engine/mr/steps/UpdateDictionaryStep.java
0% <0%> (ø)
0 <0> (?)

...kylin/engine/flink/FlinkBatchMergeJobBuilder2.java
0% <0%> (ø)
0 <0> (?)

...che/kylin/engine/flink/FlinkMergingDictionary.java
0% <0%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea34ffc...48e1bdd. Read the comment docs.


PHOENIX-5479 IndexMasterObserver needs to implements MasterCoprocessor

https://issues.apache.org/jira/browse/PHOENIX-5479

JIRA is already resolved, closing PR


Remove no longer needed declare_namespace()

This fix removes declare_namespace() which is no longer needed. it used old style namespaces which has been using pkg_resources module which is part of the setuptools and which is as well depreceted now.

Thanks, I hadn't come across this before and wasn't aware that it was redundant. Tests are all passing 👍🏻

Thank you 👍 😄


Raspberry Pi cant install module

Why can't I install xrpl.py module in Rasbian (Raspberry Pi)?
Error:
Could not find a version that satisfies the requirement xrpl.py (from versions : )
No matching distribution found for xrpl.py
How do i fix this issue?

The name of the module is xrpl-py, not xrpl.py.

The name of the module is xrpl-py, not xrpl.py. Are you able to find that?


Can not build on web when this package is referenced.

We have an app that is targeting iOS and Android, but it runs in test mode in the browser.  When running in the browser we would use mock data and never call the DTLS API directly. Like:
onPress: (){
  if(kIsWeb){
    // use mock data
  } else {
    // call native APIs
  }
}

Currently when trying to run on web, if the package is imported at all, we get an error and can not build the application:
/C:/Users/Shawn/AppData/Local/Pub/Cache/hosted/pub.dev/dtls2-0.16.0/lib/src/dtls_client.dart:6:8: Error: Dart library 'dart:ffi' is not available on this platform.
import "dart:ffi";
       ^

I know we could maybe do some sort of conditional compilation on the app side, but it would be a much nicer dev UX if the package could handle it. Is this even possible?

Hi @esDotDev, thank you for opening this issue! If I see it correctly, conditional imports are not that well supported by Dart, but according to this article (and others), you can do something like this:
import "something.dart" if (dart.library.io) "other.dart"

Maybe you can try to integrate that into your app already, I will also have a look into adding this to the package so that the dev experience will be improved :)

Thanks for looking at this! Yes I think it is probably possible to do with conditional compilation downstream, but it's a bit involved as you would need to make dummy classes for every public datatype and method.
We're actually relying on a package that depends on yours (flutter_hue), so it's maybe even trickier to deal with conditionally, as flutter_hue has many types we consume on the client side.


How many host-serevr PC are needed for running the full mode?

To run the full mode, I need to provide 2 ip addresses, so should I run the same server but on two different server with the same command or just one server computer with two IPs? What is the specifc steps to run full mode?

Just one server with two IP addresses.
The full command I run on stunprotcol.org is this:
./stunserver --ddp --mode full --family 4 --protocol udp --primaryinterface <IP_ADDRESS> --altinterface <IP_ADDRESS> --primaryadvertised <IP_ADDRESS> --altadvertised <IP_ADDRESS>

Where --primaryinterface <IP_ADDRESS> and --altinterface <IP_ADDRESS> specify the loca IP addresses on that box.  And --primaryadvertised <IP_ADDRESS> and --altadvertised <IP_ADDRESS> are the corresponding public IP addresses.

About once a year, on AWS, I have to clumsily revisit how to make an AWS instance with two IP addresses for both IPv4 and IPv6.  And Amazon seemingly changes how this is done through their EC2 console each time.

Thank you for responding Jselbie, But considering I am not using cloud services,  I am still curious if it is feasible to run on two seperate hosts while they have their own public IP respectively. If yes then how? Otherwise, any requirements in terms of the way for obtaining dual-IPs?

The code does not have have support for chaining two basic-mode servers to logically act as a full mode server. It was something I considered a long time ago adding, but once I learned some rudimentary system administration stuff such that a single NIC machine can have multiple IP addresses, it didn't seem relevant anymore.  A handful of security issues to work through as well.
The first thing you need to successfully host a full server mode STUN server is two public IP addresses. They don't have to be on the same LAN.
You can do any of the following:

A single server box with two NICs. Each NIC has an independent connection to the Internet (not going through the same NAT).
A single server box with a single NIC, but you're on your own on how to get two public IP addresses. That's some advanced system admin stuff I have to re-learn each time.

What if your environment and network topology? And what are you really trying to do?
For what it's worth, most applications, including WebRTC, really don't need "full mode".  Full-mode only exists to complete the specification for enabling clients to determine what their own NAT classification is.  But if your client applications follow the ICE methodology of similar, only the basic model of STUN is required.

My purpose is to detect the NAT types of users/clients so that to know in advance about if they can connect each other. Now everything is clear. Thank you sooo much. Have a great day! _

If you use the ICE methodology for P2P connectivity, the clients will not need to detect their own NAT type. The WebRTC stack is a great starting point for ICE connectivity.

Ya, I agree with you for setting up connections. But at our scenario we use this data to help clients to make decisions as you know Turn Server shall bring in additional latencies.


Update bug-severity-guidelines.rst

Edited headings from Camel Case > sentence case, edited severity levels section.

@justinegeffen Hope you don't mind that I opened a new PR for this for further iterations here: https://github.com/mattermost/docs/pull/3467. I applied your editor review suggestions from this PR. I'll ask for your editor review once it's ready for review.


Pull request for issue #703

Description
The underline was hiding the text behind. Now it is moved to the back of the text. closes #703
Fixes # (issue)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
I have tested the changes by running them on my local.
Checklist:

[x] I have performed a self-review of my own code

@atapas I think these difference are because of the pretter extension that I have installed in my vs code. It formatted the file.

@atapas I think these difference are because of the pretter extension that I have installed in my vs code. It formatted the file.

I can see the diffs are beyond prettier changes. Lots of changes around motivation play. Not sure whats going on.

@atapas I think these difference are because of the pretter extension that I have installed in my vs code. It formatted the file.

I can see the diffs are beyond prettier changes. Lots of changes around motivation play. Not sure whats going on.


fix: change useScriptGoogleTagManager implementation since Third Party Capital type definition update

🐛 The bug
const { dataLayer } = useScriptGoogleTagManager();

onMounted(() => {
  dataLayer.push({
    event: 'xxxx',
    xxxx: 'xxxx',
  });
});

Is not working anymore because GoogleAnalyticsApi was updated on third-party-capital library (version 1.1.1, automatically fetched by nuxt/scripts with a fresh yarn lockfile):
https://github.com/GoogleChromeLabs/third-party-capital/pull/52
It requires now a default DataLayer name, and this PR seems to recommend for wrappers to manage that.
To quick fix it I must do this:
const { dataLayers } = useScriptGoogleTagManager();

onMounted(() => {
  dataLayers['GTM-DataLayer'].push({
    event: 'xxxx',
    xxxx: 'xxxx',
  });
});

(cannot reproduce on Stackblitz since I cannot change dependencies myself, I tried by editing directly pnpm lockfile with no success)
🛠 To reproduce
https://stackblitz.com/edit/nuxt-starter-kgzm6t?file=pages%2Findex.vue
🌈 Expected behavior
Make dataLayerName optional, or managed by wrapper?
const { dataLayer } = useScriptGoogleTagManager();

onMounted(() => {
  dataLayers.default.push({
    event: 'xxxx',
    xxxx: 'xxxx',
  });
});

ℹ Additional context
No response

hello :wave:
this will be fixed with https://github.com/nuxt/scripts/pull/176

Perfect 💯

Thanks for reporting this. I'll keep the issue open until it's live just in case anyone else runs into it.


fix: improved types for useUserSession()

Issue: https://github.com/Atinux/nuxt-auth-utils/issues/38
By explicitly typing the useUserSession() we fix the types not being exported correctly.
I tried to also fix the type augmentation with it, my PHPStorm was freaking out on types though so was hard to see if its fixed.
As far as I could test, if you augment UserSessionUserData the user should have the right data. Maybe worth confirming on your end.

Closing in favour of #54


Routing to multiple Views, not just APIs

Expected Behavior / New Feature
I am trying to set up Ocelot to route to separate views, but have only seen examples of routing to different apis (makes sense, it is an API Gateway after all). Is there a way for Ocelot to have two downstream hosts, for example Google.com and Bing.com. set to the Ocelot URL, localhost:5000. In this example, I want to connect to Google with the UpstreamPathTemplate /Google/{url} and connect to Bing with /Bing/{url}.
Actual Behavior / Motivation for New Feature
If I set a website such as the Downstream host then I am just redirected to that website. I have several tools/app services that can be accessed under different URL's, and I am trying to use Ocelot to connect to all of them as well as to work with IdentityServer4. The tools are related, so I want to be able to access them using Ocelot like so, localhost:5000/tool1 || localhost:5000/tool2. If I set the upstream paths as such, then I cannot load any content. I can access one of the services if I set the upstreampathtemplate to {url}
Steps to Reproduce the Problem
Specifications
Here is a snippet of my ocelot.json. If i try to go to localhost:5000/tool2 then none of the content will load.
{
  "DownstreamHostAndPorts": [
    {
      "Host": "localhost",
      "Port": 4200
    }
  ],
  "DownstreamPathTemplate": "/{url}",
  "UpstreamPathTemplate": "/tool2/{url}",
  "UpstreamHttpMethod": [ "Get", "Post", "Put", "Delete" ],
  "ReRouteIsCaseSensitive": false,
  "DownstreamScheme": "http"
}

Version: 10.0.4
Platform:
Subsystem:

Thanks for working on this great project!

@michiwib this should work OK there are people who use Ocelot to route to pages that return HTML etc, there might be an issue loading subsequent assets though. Can you share your program.cs / startup.cs and full json configuration so I can take a closer look?

Thanks for getting back to me about this, it is good to know that this is possible. The browser developer tools show that some of the files are missing, so I may be having issues loading associated assets.
Here is my ocelot.json:
{   "ReRoutes": [     {       "DownstreamPathTemplate": "/api/{url}",       "UpstreamPathTemplate": "/service1/{url}",       "UpstreamHttpMethod": [ "Get", "Post", "Put", "Delete" ],       "DownstreamHostAndPorts": [         {           "Host": "localhost",           "Port": 64228         }       ],       "DownstreamScheme": "http"     },     {       "DownstreamPathTemplate": "/{url}",       "UpstreamPathTemplate": "/service2/{url}",       "UpstreamHttpMethod": [ "Get", "Post", "Put", "Delete" ],       "DownstreamHostAndPorts": [         {           "Host": "localhost",           "Port": 4200         }       ],       "DownstreamScheme": "http"     }   ],   "GlobalConfiguration": {     "BaseUrl": "http://localhost:5000"   } }
My Program.cs:
namespace TestGatewayFromScratch {     public class Program     {         public static void Main(string[] args)         {             new WebHostBuilder()                .UseKestrel()                .UseContentRoot(Directory.GetCurrentDirectory())                .ConfigureAppConfiguration((hostingContext, config) =>                {                    config                        .SetBasePath(hostingContext.HostingEnvironment.ContentRootPath)                        .AddJsonFile("appsettings.json", true, true)                        .AddJsonFile($"appsettings.{hostingContext.HostingEnvironment.EnvironmentName}.json", true, true)                        .AddJsonFile("ocelot.json")                        .AddEnvironmentVariables();                })                .ConfigureServices(s => {                    s.AddOcelot();                })                .ConfigureLogging((hostingContext, logging) =>                {                 //add your logging             })                .UseIISIntegration()                .Configure(app =>                {                    app.UseOcelot().Wait();                })                .Build()                .Run();         }     } }
And my Startup.cs:
`namespace TestGatewayFromScratch
{
public class Startup
{
// This method gets called by the runtime. Use this method to add services to the container.
// For more information on how to configure your application, visit https://go.microsoft.com/fwlink/?LinkID=398940
public void ConfigureServices(IServiceCollection services)
{
}
    // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
    public void Configure(IApplicationBuilder app, IHostingEnvironment env)
    {
        if (env.IsDevelopment())
        {
            app.UseDeveloperExceptionPage();
        }

        app.Run(async (context) =>
        {
            await context.Response.WriteAsync("");
        });
    }
}

}`

@michiwib there could be a few things causing you issues here.
If you change your config to say
{
  "ReRoutes": [{
      "DownstreamPathTemplate": "/{url}",
      "UpstreamPathTemplate": "/service1/{url}",
      "UpstreamHttpMethod": ["Get", "Post", "Put", "Delete"],
      "DownstreamHostAndPorts": [{
        "Host": "threemammals.com",
        "Port": 80
      }],
      "DownstreamScheme": "http"
    },
    {
      "DownstreamPathTemplate": "/{url}",
      "UpstreamPathTemplate": "/service2/{url}",
      "UpstreamHttpMethod": ["Get", "Post", "Put", "Delete"],
      "DownstreamHostAndPorts": [{
        "Host": "threemammals.com",
        "Port": 80
      }],
      "DownstreamScheme": "http"
    }
  ],
  "GlobalConfiguration": {
    "BaseUrl": "http://localhost:5000"
  }
}

and then call http://localhost:5000/service1/ocelot you should see the Ocelot site load but some things will be broken such as images etc.
if you call http://localhost:5000/service1/ you will get a 404 because Ocelot will only match on /service1/something when you have configured /service1/{url}. you would need something like /service1/ configured if you want something to load for root.
In terms of the assets not coming down you basically need to set up ReRoutes specifically for them.
Does that make any sense?

Ah, that makes sense. I was able to get this working with a similar config to what you suggested, and I could get multiple downstream hosts to work by adding another reroute that handles the static assets for each of them.

OK awesome :D


can't parse a domain with underscore

probably because of this code
  // allowed hostname characters according to RFC 3986
  // ALPHA DIGIT "-" "." "_" "~" "!" "$" "&" "'" "(" ")" "*" "+" "," ";" "=" %encoded
  // I've never seen a (non-IDN) hostname other than: ALPHA DIGIT . -
  URI.invalid_hostname_characters = /[^a-zA-Z0-9\.-]/;

Do you want to send a PR for that? (maybe also adding an URL with a _ in its domain to urls.js for testing)

sure ill send a pr

submitted a pr:
https://github.com/medialize/URI.js/pull/349

submitted a PR with a relevant test:
https://github.com/medialize/URI.js/pull/348

@rodneyrehm is there a possibility to have
host:name.something.com

?

the hostname could be an IPv6 address and that may contain :. A domain name may not - as far as I know - but then, I wasn't aware _ was legal either…

host:name.something.com currently fails in tests because name.something.com is considered the port

When you opened the PR I thought I'd immediately close the issue because _ is not legal in domain names per RFC 1034. However, the URL spec seems to permit it and Chrome's implementation parses it. That said, : is considered an illegal code point

gotcha. so the PR can be merged i think.

fixed in v1.18.12


Animations not working

I know this is commented in the animations demo but just opening a discussion here. I've been playing with this a little this morning and not having luck using plain TransitionGroup (not CSSTransitionGroup) and can never get the componentWillEnter to call.
I've struggled to get non-CSS TransitionGroups working before though, so wanted to open this here first before going too far into it.

@natew any luck on this? I'm curious if anyone has fixed this. I have some ideas on how I might, but I don't want to do it if I don't have to.
I need componentWillEnter, componentDidEnter, etc to be passed down. They currently are not.
I tried making my AppHandler use RouteHandlerMixin and then do: "{this.getRouteHandler(_.assign({}, this.props, { key: routeName }))}" instead of , and it works...but then things like willTransitionFrom, willTransitionTo doesn't work.
Ideas?

@skevy yea this actually is still an issue if you use the RouteHandler component. I actually ended up submitting a pull request (#559) that moved most of RouteHandler into a mixin (mixins/RouteHandler). You can see in that pull request how it allows you to avoid using the RouteHandler component.

I haven't tested this with animations fully, I actually ended up using a different strategy that avoids TransitionGroup (but basically does the same thing as it does, just as a mixin as well in my classes).

@natew So I actually did the this.getRouteHandler thing, but do you know if it works with the statics (like willTransitionFrom)?

I'm probably just gonna fix this...on a tight deadline and don't have time to wait on things from this project (as much as I love it and everyone working on it)...but if it's actually good code, I'll send a pull request. But at the very least, I'll update this ticket.

Should work with statics, because the child route is given to you directly.
this.getRouteHandler().type.XXX

Does that work? Sorry, haven't touched this code in a while so my memory's fuzzy on it. Let me know what you come up with.

@natew The best way I can think of to solve this issue is to just get rid of <RouteHandler> altogether and require people to mix in Router.RouteHandler to their route handler components. It's kind of clunky tho...
Is there a better way?

I actually kind of like that change, if it were implemented. Makes everything a bit less magical.

@gaearon is there a way we could automatically mix in RouteHandler to people's route handler components? or at least warn them when they don't do it themselves? i just want to avoid the situation where someone is staring at a blank screen, wondering why nothing is rendered, because they forgot the mixin.

Thats what I'm doing now, mixing it in and using this.getRouteHandler(). It works as of today actually.
It feels better in some ways in that it breaks less things, but maybe isn't as simple and consistent with React syntax. I like it overall though.
One thing is passing down props you don't get the JSX syntax:
this.getRouteHandler(Object.assign(this.props, { key: this.subRouteKey() }))

But to me, thats a really minor trade-off.

Would be really nasty, but react-router could inject createClass and make this.getRouteHandler log out a warning that it needs a mixin? I feel icky typing that though :)

@natew wait a sec...
Isn't that what ReactInjection.Class.injectMixin is for?!
We could just put that in and be done with it.

Honestly never used it, @gaearon or @petehunt probably knows a lot more in this area.

Ya, it's probably not a great idea because we'd be adding the mixin to every single class that way...
I guess we'll just need to keep the separate mixin for people who want to do fancy stuff, like animations. We should def document it tho.

injectMixin would put it into every class so it's not an option.

Edit: I guess you could do this, no? Perhaps not, the new JSX changes still haven't stuck in my head.
var Handler = this.getRouteHandler();
return <Handler {...this.props} />;

Indeed, this should work.
I agree “mixin for special cases” seems good if it is documented.

is there a way we could automatically mix in RouteHandler to people's route handler components?

Once class is created, you can't inject a mixin into it, so no.

sounds like we just need docs here, no action items until somebody has a brilliant idea.

Are there any solid answers to this problem yet. I'm still not exactly sure how to use the RouteHandlerMixin in a way that allows children to receive the TransitionGroup hooks.

+1 (really confused about RouteHandlerMixin  and the new createChildRouteHandler) love to se some docs or updated animation example.

+1

+1

Reapp does this. Basically you extract most stuff from RouteHandler into a mixin:
https://github.com/reapp/reapp-routes/blob/master/src/react-router/ParentRouteMixin.js
Then I made a new class called a React.Page:
https://github.com/reapp/reapp-kit/blob/master/src/lib/Page.js
(Note it mixes in RoutedViewListMixin which is just ParentRouteMixin with some Reapp helpers that automatically set properties needed for animations when routes change).
I'd like to write more on how this all works, just slammed with client work atm.

I would also love to get some clairity on how to best implement this. While I appreciate @natew 's example, it doen't quite provide the clairty I'm looking for. Does anyone have a simple example?

It seems the main problem here is that the RouteHandlerMixin is now removed from the react-router project. So has the one solution that people were claiming to work been abandoned? Is it safe to say that react-router is simply NOT compatible with ReactTransitionGroup?

1.0 now uses props for child route components, so animating with react router is identical to animating with any other component.


MNT: fix CI and fix install on Linux

This PR does 2 things:

Fixes CI
Fixes the build/install on Linux, which is currently broken

I tested it on my own fork against main, and you can see the Github actions CI running there and the build and test works.  https://github.com/jdavies-st/pyregion/pull/1
Running the workflows on this PR will need to be enabled by a maintainer.  @pllim ?
These 2 simple things above involve

Tearing out astropy-helpers, which means modifying the build system and sphinx config to work without it.
Using modern PEP517 build tools such as pyproject.toml, build, setuptools-scm, etc.  This project uses Cython and numpy as build dependencies, so of course these modern tools make everything just work.
Fix up any problems with the doc build or tests exposed by the CI.

Resolves #121
Resolves #139
Resolves #140
Resolves #147
Resolves #148
Resolves #150
Resolves #151
Resolves #156
Resolves #158
Resolves #160
Closes #144
Closes #149
Closes #155
Closes #157

Running the workflows on this PR will need to be enabled by a maintainer

It won't run here until after this PR is merged, so we'll have to trust the run from your fork. 🤞

Overall, I love the +302 −1,662 clean-up. Thanks!
I guess you don't want to be bothered with tox here? Just wondering if you are aware of https://github.com/OpenAstronomy/github-actions-workflows and would like to use that to further simplify your CI or not. If you don't want to do that now, we can always defer too.

Yes, I figured the minimal "getting CI working" would be what I have here.  Happy to implement tox and the OpenAstronomy workflow in a future PR if that's wanted.  I'd prefer to defer to later on this.

Hard to tell if RTD would build or not until after merge.

It does!  Though I don't know how the rtd builds are triggered on this repo.  Maybe they're not?  It seems the current docs are a bit behind the current release, and there was no rtd yml file in here before.  A mystery.  I did make sure that every page is identical to what is currently there.

If I am reading the diff correctly, you completely gutted pyregion/conftest.py, is that intentional?

Yes, though I realize I can include pytest-astropy-header and get that stuff back.  I've done that.

Why remove pyregion/tests/__init__.py?

Not necessary, as tests is not an importable package.

Just curious - what features do you need from this package?

grizli depends on it.  And that is the workhorse package for all science being done with JWST grism data right now.  The official jwst pipeline is not feature-complete for grism.  And currently pyregion cannot be listed in install_requires for grizli because it cannot by pip installed on Linux. So one has to separately install it from source.  Irritating for grizli CI and installation.
I figured fixing up the installation for pyregion would be much easier than trying to port over grizli to the new regions API, though that would be a nice project to do at some point as well.  And this extends the lifetime of this package as well, given that regions is not feature complete yet.

Though I don't know how the rtd builds are triggered on this repo.

Well, the admin from https://readthedocs.org/projects/pyregion/ (@astrofrog) would need to enable https://docs.readthedocs.io/en/stable/pull-requests.html for RTD to build for PRs. Otherwise, we'll find out when this is merged...

tests is not an importable package.

You will have to add that __init__.py back if you want the test runner back (i.e., pyregion.test()).

I note that this partially duplicates the work in #157 which was opened two months ago and was never reviewed.

We apologize for the oversight, @smaret ! This package is minimally maintained. For future contributions, please contact other Astropy Project maintainers if you do not hear back. We have a several places for communication: https://www.astropy.org/help.html

I knew this was just a matter of time. Pyregion is part of many packages due to its age. Perhaps we can create easy porting guidelines for people wanting to port their code 🤔?

Great idea, @prajwel ! I opened https://github.com/astropy/regions/issues/488


gtkwave: 3.3.117 -> 3.3.118

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/gtkwave/versions.
meta.description for gtkwave is: VCD/Waveform viewer for Unix and Win32
meta.homepage for gtkwave is: https://gtkwave.sourceforge.net
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.3.118 with grep in /nix/store/a1g8nhhylgs1w2n2mjn2yqakva47sc3j-gtkwave-3.3.118
found 3.3.118 in filename of file in /nix/store/a1g8nhhylgs1w2n2mjn2yqakva47sc3j-gtkwave-3.3.118

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
gtkwave

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/a1g8nhhylgs1w2n2mjn2yqakva47sc3j-gtkwave-3.3.118 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gtkwave https://github.com/r-ryantm/nixpkgs/archive/733efba1f5a5f645481fdba4035293611a6d0028.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/733efba1f5a5f645481fdba4035293611a6d0028#gtkwave

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/a1g8nhhylgs1w2n2mjn2yqakva47sc3j-gtkwave-3.3.118
ls -la /nix/store/a1g8nhhylgs1w2n2mjn2yqakva47sc3j-gtkwave-3.3.118/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

gtkwave

Maintainer pings
cc @thoughtpolice @jiegec @jleightcap for testing.

Deep breath..
CVE-2023-32650
CVE-2023-34087
CVE-2023-34436
CVE-2023-35004
CVE-2023-35057
CVE-2023-35128
CVE-2023-35702
CVE-2023-35703
CVE-2023-35704
CVE-2023-35955
CVE-2023-35956
CVE-2023-35957
CVE-2023-35958
CVE-2023-35959
CVE-2023-35960
CVE-2023-35961
CVE-2023-35962
CVE-2023-35963
CVE-2023-35964
CVE-2023-35969
CVE-2023-35970
CVE-2023-35989
CVE-2023-35992
CVE-2023-35994
CVE-2023-35995
CVE-2023-35996
CVE-2023-35997
CVE-2023-36746
CVE-2023-36747
CVE-2023-36861
CVE-2023-36864
CVE-2023-36915
CVE-2023-36916
CVE-2023-37282
CVE-2023-37416
CVE-2023-37417
CVE-2023-37418
CVE-2023-37419
CVE-2023-37420
CVE-2023-37442
CVE-2023-37443
CVE-2023-37444
CVE-2023-37445
CVE-2023-37446
CVE-2023-37447
CVE-2023-37573
CVE-2023-37574
CVE-2023-37575
CVE-2023-37576
CVE-2023-37577
CVE-2023-37578
CVE-2023-37921
CVE-2023-37922
CVE-2023-37923
CVE-2023-38583
CVE-2023-38618
CVE-2023-38619
CVE-2023-38620
CVE-2023-38621
CVE-2023-38622
CVE-2023-38623
CVE-2023-38648
CVE-2023-38649
CVE-2023-38650
CVE-2023-38651
CVE-2023-38652
CVE-2023-38653
CVE-2023-38657
CVE-2023-39234
CVE-2023-39235
CVE-2023-39270
CVE-2023-39271
CVE-2023-39272
CVE-2023-39273
CVE-2023-39274
CVE-2023-39275
CVE-2023-39316
CVE-2023-39317
CVE-2023-39413
CVE-2023-39414
CVE-2023-39443
CVE-2023-39444


no_weak_imports: call ENV.append, not .add

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully run brew tests with your changes locally?

👍


Spring Guide - Building a Gateway - https://spring.io/guides/gs/gateway/

I followed this guide and initialized the project from start.spring.io.
I'm trying to create a new route using Java RouteLocator API but i can't find this class in the jar "spring-cloud-starter-gateway-mvc".
Upon doing some research i found out that this class is part of "spring-cloud-starter-gateway" jar which is for a Reactive Cloud Gateway.
The guide title and description says the example given is for non reactive. Please check.
Thanks

Hi @girishyt. You are correct that the gateway guide had an issue with how we resolved the gateway dependency. This should be solved by the recently merged PRs in the gs-gateway project. As a reminder, please use the specific guide repositories when possible to open issues.  Additional context for the root of the problem is located in those PRs.
This should now be fixed with the 2 recent PRs:

Update Dependencies
Update README

I'll close the issue as resolved. If you try and are still having difficulties, please submit a follow up issue in the gs-gateway repository and we can have another look.


Fix Ruby 1.9 compatibility

From the latest Rack spec:

The Body must respond to each and must only yield String values. The Body itself should not be an instance of String, as this will break in Ruby 1.9.

Wrapping in an array should work!
Side-note: to run the tests on ruby 2.4 requires a gem install test-unit-minitest

Thanks for the update. I'm surprised that this thing even still works!


Vault provider chokes on non-regex paths without permissions

Describe the bug
When we use dataFrom.find with a regex e.g. ^teamb.* I would expect the provider to never look at e.g. teama.
It still sadly does try to recurse into teama and since it has no permission to do so - fails.
cannot read secret data from Vault: Error making API request.

URL: GET https://vault.foo.bar/v1/gala/metadata/live/teama?list=true
Code: 403. Errors:

* 1 error occurred:
	* permission denied

To Reproduce
Steps to reproduce the behavior:

See example above
Remove list permission from teama

Expected behavior
Since the regex is anchored it should never recurse anywhere where the path does not match the regex. Here everything not teamb.
Additional context
From the code is seems like it naively recurses through all metadata without consulting regex. This implementation might be too naive.

hi @AndreasBergmeier6176 . Can you please share your manifests?

Of course, if you by any chance know a regexp magic to perform validation without even querying vault API, I'd happily review that PR 😄 My take this is not going to be an easy task as you'd need to implement logic for the full https://pkg.go.dev/regexp implementation (like ^(a|[bc])+[def]+/foo. would IMO render it impossible to determine preflight all the root paths - but hey if you know how to, PRs are welcome)


FaceTime links don't generate but call answers on laptop

Hello. I'm on server 1.9.2 on macos Sonoma (14.2.1) using the Android app version (1.12.7) on a degoogled android (grapheneos). I've also attached a log for the app and server when a call is initiated and answered.
I see this feature is experimental but wanted to open the issue anyway in case there's something I can change on my end to increase the chance of it working.
When a call is made to my phone I get a notification and tap answer. After this the "generating link" dialogue spins and then ultimately fails or I have to cancel. On the server side the facetime call is answered and I have to hang up from there or the calling party has to hang up. I've also tried declining the call (logs not included) and it doesn't decline the call. Let me know if any more test cases or information is needed. I redacted the number and IP for privacy.
bluebubbles-applog.txt
bluebubbles-serverlog.txt
Edit:
Also lmk if I should move this issue to the app repo instead of this one.

Sorry that no one ever responded here. We dont know the full cause of this, but we need to look into it more. Leaving this open for now

So I noticed before that in the list of devices my android wasn't there. I've recently wiped my phone and it seems to be somewhat working. It generated the link but for some reason I'm not admitted to the room. Not sure if I should open a separate bug for that or not


tags are broken

but it's 2:30am so i'm opening an issue for myself :zzz:

fixed d281993acc5255d8877b2794e709a07a2113d595


Map changing colours

Describe the bug
When clicking on a time, the map doesnt stay on the correct colours and seemes to change after about 1 second
0.4.5 - https://nowcasting-qpgkjcwdf-openclimatefix.vercel.app/
0.4.6 - https://nowcasting-51lbxde6a-openclimatefix.vercel.app/
0.4.7 - https://nowcasting-cepdnlfxq-openclimatefix.vercel.app/
To Reproduce
Steps to reproduce the behavior:

Go to dev.quartz.solar, or app.quartz.solar
Click on a time 4 hours in the future
wait
See changing map

Expected behavior
Stay on map colour that we expect

Is it worth looking at odd version on Vercel, and seeing if this happens. Then we can narrow it down?

On 4.7 i dont see this problem, I note that this only happens once or twice, compare to x10 on live

We do see this on dev and on staging and on 0.4.8 - TODO

I do see this locally when running 0.4.8, off c7c2f17

if i comment out
{/*           {!isProduction && ( */}
{/*             <SitesMap */}
{/*               className={currentView(VIEWS.SOLAR_SITES) ? "" : "hidden"} */}
{/*               sitesData={sitesData} */}
{/*               aggregatedSitesData={aggregatedSitesData} */}
{/*               sitesErrors={sitesCombinedErrors} */}
{/*               activeUnit={activeUnit} */}
{/*               setActiveUnit={setActiveUnit} */}
{/*             /> */}
{/*           )} */}
{/*           <DeltaMap */}
{/*             className={currentView(VIEWS.DELTA) ? "" : "hidden"} */}
{/*             combinedData={combinedData} */}
{/*             combinedErrors={combinedErrors} */}
{/*             activeUnit={activeUnit} */}
{/*             setActiveUnit={setActiveUnit} */}
{/*           /> */}

lines in index.tsx it still does it

I tried upgrading components, but it didnt seem to help