Transition from eqMac2 to the new eqMac

Do I need to remove eqMac2 or install on top of it? If necessary, how to do it correctly (they wrote here that it is not completely deleted and remains in audio devices)
How to transfer saved presets?

the new eqMac upon installation nukes the driver for eqMac2 to avoid potential issues as seen here:
https://github.com/bitgapp/eqMac/blob/master/native/app/Source/Scripts/install_driver.sh#L6-L12
I've tested on my machine and it does remove eqMac2 audio device from the list. Not sure what's going on if it stays there for you :(
In terms of transitioning presets, that should be shipped very soon (for the advanced 10 band EQ)

Closing in favour of #234


Text colours are gone

Describe the bug
It seems that since the newest version "schemes" don't work properly. It only changes the background and not the text
To Reproduce
Build Hugo with peaceiris/actions-hugo
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser chrome
Version 111.0.5563.64

Additional context
`[Params]
Note: This is for the meta description, which is different from the "description" displayed in the terminal.
description = "40K custom forge world"
baseURL = "https://nick-caris.github.io/"
[Params.Terminal]
Note: color scheme
Note: You can choose between
Note: ["monokai", "powershell", "gruvbox_light", "gruvbox_dark", "solarized_light", "solarized_dark", "ubuntu", "shell-retro"]
Note: If you want to use the Goph theme, set it to "goph" (See README.md)
scheme = "Molokai"
Note: in terminal
[userName]@[pcName]:~/$ cd [workDir]
[userName]@[pcName]:~/[workDir]$ cat [profile]

[description]

Note: if you set Params.Tree > use = true
[userName]@[pcName]:~/[workDir]$ tree ./[folderName]/
./[folderName]/
...
Note: result of the tree command
userName = "Scribe#1312"
pcName = "Terminal"
workDir = "ForgeWorlds"
profile = "Malleaton"
Note: speed at which text is displayed on the terminal
Note: if set to 0, typing animation will be disabled
Note:
Note: if you want to enable Mathjax, you need to set it to 0
Note: and set "math: true" at front matter in your Markdown file
ps1Delay = 0 # prompt speed : [userName]@[pcName]:~/$ , [userName]@[pcName]:~/[workDir]$
stdoutDelay = 0 # stdout speed : [description] , files in Params.Tree
commandDelay = 50 # command speed : cd [workDir] , cat [profile] , tree ./[folderName]/
Note: speed at which text is displayed on the activity pages
Note: if set to 0, typing animation will be disabled
Note:
Note: if you want to enable Mathjax, you need to set it to 0
Note: and set "math: true" at front matter in your Markdown file
titleDelay = 0 # title speed : "title" in front matter
contentDelay = 0 # content speed : content in .md file
activityDelay = 5 : deprecated
description = """
Malleaton, also known as the "The broken forge" is an Imperial Forge World of the Adeptus Mechanicus that is located in....
"""
Note: If you want to use a Markdown file, you can use the following
description = "/description.md"
Note: and put the description.md in /content/description.md
[Params.Tree]
use = true
folderName = "Malleaton"
Note: ["ACTIVITY", "URL or PATH TO YOUR MARKDOWN FILE"]
files = [
["Goverment", "/post/goverment.md"],
["Colours", "/post/colours.md"],
["History", "/post/history.md"],
["Geography", "/post/geography.md"],
["Manufactoria Capabilities", "/post/some-activity.md"],
]`

Thank you for your report.
I am aware of this issue and have corrected it in d643b39 .
You can either recreate the site or type the following command to correct the problem.
git submodule update --remote


feat: Karma Graph

Added a karma graph.
Limited to 293 clusters of 1 week.
Also added some variables to the .env
# Karma graph width and height. Defaults to 500x300 (WxH)
KARMA_GRAPH_WIDTH=
KARMA_GRAPH_HEIGHT=

# Karma graph QuickChart Chart URL creator
KARMA_GRAPH_CHART_API_URL="https://quickchart.io/chart/create"

:tada: This PR is included in version 3.3.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


per_page param in searches

Hi!
I'm trying to add the per_page param to the Tentacat.Search.users request but no options can be passed for that. Is there any other way of doing it?
I have seen this PR #106 which seems to add this, but it hasn't be merged. Are you planning to merge it?
Thanks in advance

Yes I'm planning to merge soon!

Cool, thanks!


Blur Radius always resets to 8 when re-opening client with this mod, no matter what other value you set it to.

No matter what value you have set, upon re-opening the client the blur radius is always the default 8. Even if the modmenu UI shows it's not 8, it is.

Cannot reproduce on my end, could you provide more information? Which minecraft version are you using? Are you using any other mods?

Cannot reproduce on my end, could you provide more information? Which minecraft version are you using? Are you using any other mods?

https://youtu.be/rpDfwvzSfTs is the video showcasing the issue. No other mods installed.

https://youtu.be/rpDfwvzSfTs is the video showcasing the issue. No other mods installed.

Same issue here. Version is 1.16.5

Could you try if it also happens on 2.1.0?

It does, just confirmed.

Well actually it happens 100% of the time when blur radius is set to 0, and sometimes when it is set to 1 or above.

Doesn't seem to occur in the latest version anymore, can you confirm?


copy OCP bump script from assisted-service

Move OCP bump script, so we can have all management Python scripts in one place.
Ultimately, it will also help moving this job from Jenkins to prow.

/unhold

/cc @eliorerz @romfreiman


[FEATURE]: Fairs for fast search faces

Description
Faiss is a library for efficient similarity search and clustering of dense vectors. It contains algorithms that search in sets of vectors of any size, up to ones that possibly do not fit in RAM. Faiss allows you to quickly perform the operation of searching for the k nearest vectors for a given vector.
It will help speed up the search through a large database of photos.
Additional Info
I use Faiss with DeepFace a Flake outside of the repo. And i can share it for other users.
If you want I will raise a pull request.

A-nn tools should be implemented externally
https://sefiks.com/tag/nearest-neighbor/


Parameter type "callback" in php doc blocs

Hi there,
is it correct that there are multiple occurrences of the parameter type "callback" in the php doc blocks? For example https://github.com/Shardj/zf1-future/blob/master/library/Zend/EventManager/GlobalEventManager.php#L98
Our PHPStan is complaining about it and according to https://phpstan.org/writing-php-code/phpdoc-types#basic-types, I think that it needs to be changed to "callable".
If so, I would apply a PR.
Thanks
Michael

I created PR https://github.com/Shardj/zf1-future/pull/266 for this

Merged


Feat: Text overflow while hovering

Describe the feature
while hovering the cards after faqs section, text comes out of the box and that could be corrected
also i'm not sure under which that comes (like is it a part of reviews?) , if those cards comes under seperate section, i would like to work on that section.
the 5th star in the 3rd card is missing.
please assign me this under gssoc and give appropriate labels to it.
Thankyou.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hi, @Kalivarapubindusree. Please assign this issue to me under GSSoC.

@HritikaPh plse make an issue separately then I will assign


Rating: please update the song and chart constant database for the japanese version.

New songs and albums are not yet updated for buddies plus. This causes missing songs and wrong chart constant (internal level) for the b50 calculation.
Some charts, such as パーフェクション master (shows as 13.5 but actually 13.4), uses the old constant. The image generation also doesn't show newer songs from buddies plus.

Thanks for the feedback! The latest data has been updated and can you please kindly see if they are fixed?
Regarding inaccurate chart constants, to ensure they are as accurate as possible I'm utilizing the data from https://twitter.com/maiLv_Chihooooo to populate the dataset. It seems that for the "パーフェクション Master" chart specifically, constant of such chart in Buddies Plus has not been investigated yet. Whenever the upstream dataset updates the site should reflect it.

Hmm, I was comparing it with another tool and not sure where they get the chart constant data from that is currently missing from the spreadsheet. I'll try asking.
The other calculations are correct now, thanks. Seems like there's an image missing for the image output though:
`"error: ENOENT: no such file or directory, open '/root/dxrating-assets//images/cover/v2/c4c2a77c66fe531962def38cc8d048a3b6ad5fd15bf366d061573ca72e3e5954.jpg'"

Hmm, I was comparing it with another tool and not sure where they get the chart constant data from that is currently missing from the spreadsheet. I'll try asking.
The other calculations are correct now, thanks. Seems like there's an image missing for the image output though: error: ENOENT: no such file or directory, open '/root/dxrating-assets//images/cover/v2/c4c2a77c66fe531962def38cc8d048a3b6ad5fd15bf366d061573ca72e3e5954.jpg'

Thanks for the report. We have updated the rendering server resources so this shall be fixed now.

Thank you!


Remote Assets

Motivation
When using Repack with Module Federation the only way to access the assets is to inline them via Repack's assetLoader. This solution results in assets being bigger in size by themselves and embedded into the bundle itself resulting in bigger size of it as well.
Description
Proposed solution is to handle the assets the same way they're handled on the web - by keeping them separate and downloading them in the app only if needed. To achieve that, we would need to emit a directory containing all of the assets that would need to be uploaded to the remote host (e.g. CDN). Another step would be to change the result of RePack's require when using remote assets. The goal here is to make it compatible with ReactNative's Image component. Similarly to how inlining assets works, the result of the require would look something like this:
const source = {
    uri: url.href,
    width: size?.width,
    height: size?.height,
  };

This solution involves encoding asset's dimension during compilation which eliminates the problem where the remote asset won't be displayed by Image component without styling the component (similar to inlined assets).
The URL inside of source object would be the result of prepending PUBLIC_PATH provided via assetsLoader configuration to the relative path of the resource. There is an important limitation in here that PUBLIC_PATH needs to be known at compile-time, similar to how it's done in Webpack
Here's how the configuration object for assetsLoader could like with options for remote assets:
export interface Options {
  platform: string;
  scalableAssetExtensions: string[];
  devServerEnabled?: boolean;
  inline?: boolean;
  publicPath?: string;
  remote?: {
    enabled: boolean;        // useful for switching between development and production env
    publicPath: string;      // hostname of the target remote location
    outDir?: string;         // name of the resulting directory containing remote assets
    publicOutDir?: string;   // name of the directory appended to the publicPath in case it's different than the outDir
    scalableAssets: 'min' | 'max' | 'default' | 'all'  // what scale to choose for the remote asset
  };
}

By proper configuration of the RePack's assetsLoaders, the developer could work on the local assets as before, and only use the remote functionality for the production build (after uploading the assets to the remote host).
When dealing with remote assets there's also aspect of asset's scalability. Simple solution to that would be to only choose 1 scale of the asset to emit as remote, and let the user configure the behaviour that governs it, e.g. whether we want to take the smallest one, the biggest or the default one with @1x scale. It would be a good idea to leave it as a default solution while also providing an option to disable that behaviour in case someone wants to emit every asset at every scale and handle the scalability themselves (e.g. via query params?).
Summary
What needs to be done involves the following:

Add asset transformer that will replace the result of RePack's require with Source object containg the URL
Add mechanism to select only one scale from scalable assets
Handle outputting the asset's directory
Add relevant configuration to assetsLoader options

Relevant PRs
feat(assetLoader): support remote assets - this PR aims to deliver similar functionality

i changed assets config in webpack to this code
              test: Repack.getAssetExtensionsRegExp(
                 Repack.ASSET_EXTENSIONS.filter((ext) => ext !== "svg")
              ),
              loader: 'file-loader',
              options:{
                postTransformPublicPath:(p)=>(`{uri:${p}}`)
              },

this code worked in development, not tested in production.

Hey @jbroma, just so this issue today. Do you think we can work together to make this solution a reality? (based on the linked PR I made a while back)

i changed assets config in webpack to this code
              test: Repack.getAssetExtensionsRegExp(
                 Repack.ASSET_EXTENSIONS.filter((ext) => ext !== "svg")
              ),
              loader: 'file-loader',
              options:{
                postTransformPublicPath:(p)=>(`{uri:${p}}`)
              },

this code worked in development, not tested in production.

how we can deploy the ios/android build to production without running the dev server, please provide me one document

for production i have changed it
 test: Repack.getAssetExtensionsRegExp(
            Repack.ASSET_EXTENSIONS.filter((ext) => ext !== "svg")
          ),

          loader: "file-loader",
          options: {
            publicPath: (url, resourcePath, context) => {
              const dimensions = sizeOf(resourcePath);

              let publicPath = `__webpack_public_path__ + ${JSON.stringify(
                url
              )} `;

              return `{uri:${publicPath},width:${dimensions.width},height:${dimensions.height}}`;
            },
            postTransformPublicPath: (p) => {
              return JSON.parse(p);
            },
          },

Hey @crash7 , sorry for not replying earlier. I've done some research on the subject and changed the proposed solution slightly. I've investigated your approach with the AssetsRegistry but that didn't yield any satisfactory results. I've managed to get the scales working too, which might be of interest to you. Here's the PR: #331


dotnet-sdk: 2.1.302 -> 2.1.401

Motivation for this change
Fix version of dotnet-sdk released, this is required for some newer packages.
I have changed sha256 to sha512, since it ca be copy pasted from the website directly.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build dotnet-sdk

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: dotnet-sdk
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: dotnet-sdk
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: dotnet-sdk
Partial log (click to expand)
head: error writing 'standard output': Broken pipe
head: error writing 'standard output': Broken pipe
head: error writing 'standard output': Broken pipe
head: error writing 'standard output': Broken pipe
head: error writing 'standard output': Broken pipe
head: write error: Broken pipe
head: error writing 'standard output': Broken pipe
head: write error: Broken pipe
head: write error: Broken pipe
checking for references to /build in /nix/store/pj4vifg24dhag3jqckljmahwabkwcz88-dotnet-sdk-2.1.401...


Make builds a bit faster, but mostly cleanup

This PR does the following:

shaves off about 40% of the build time by doing map lookups instead
remove extraneous code that was never used (social stuff)
remove zod which was only used to do some validation that had no impact on the list output

RNBW-2860


resolves #686 use character spacing to fine-tune width of placeholder for inline image

use character spacing to distribute extra space not covered by placeholder chars
force at least one placholder char for narrow images and use negative character spacing to recover overrun
simplify how spacer count is computed

Depends on #685.


GUI elements ui_action usage, improvements

Popupmenu now uses UI actions instead of key presses
Tree now uses UI actions instead of key presses
Line edit up/down focus pass through
When line edit receive a up/down and the cursor is at beginning/end it will not set the input as handled
Properly sets input as handled when closing modal
Scrollbar now uses UI actions instead of key presses
Add two new default actions ui_end, ui_home, used by Slider and Scrollbar (I can remove this if found useless)
Add item_focused signal to OptionButton (and id_focused to PopupMenu)
This is useful if for example you want to add UI sounds to your game.

Closes #16946
Closes #17159

This fixes #16946.

thanks, added it to the PR description so it should get closed automatically when merged

Awesome. Thanks.

I've tested this and it seems to work.
I still have an issue where a popup panel does not react to any focus events on a keyboard. I try to find out if this is related or a separate issue.

As no one seems to find the courage to merge this even though it's been tested and approved by a few, I'll abuse my newly acquired power and do it myself :grin:

I'm sure there will be plenty of time to take the blame before 3.1 is out if something breaks :smirk_cat:

Is there any chance to see these fixes in 3.0.3?
I don't think these changes would break the compatibility and half of them are bugfixes anyway.

May I also point to #18715 that I think is related?

Hi @Faless, would you be open to revisiting this code to see if you can fix the issues with keyboard navigation that seemed to occur as a result of the "Tree now uses UI actions instead of key presses" changes?
Assuming my assessment of the situation is correct, the issues have had a significant negative impact on the accessibility & usability of the Tree control both within the editor & third-party games/apps.
There's some further details in #41014 & #36291.


sample_vpp.exe -rotate do not work on Media SDK 2020 R1 windows version

test command:
sample_vpp.exe -sw 1920 -sh 1080 -scc nv12 -dw 1080 -dh 1920 -dcc nv12  -i 1nv12.data -o 1nv12Out.data -rotate 90
input data:

out put data:

@zhaoye1 , as we talked about, I am following up with it.

We have reproduced it and rooted cause it. Will provide the patch once code is ready..

Please use sample_vpp.exe -sw 1920 -sh 1080 -scc nv12 -dw 1080 -dh 1920 -dcc nv12 -i 1nv12.data -o 1nv12Out.data -rotate 90 -d3d11. We checked DX11 command, it is working.

https://docs.microsoft.com/en-us/windows/win32/api/dxva2api/ns-dxva2api-dxva2_videoprocessbltparams does not have rotation parameters. Hence, to perform rotation, recommend to use DX11.

It’s worked on Media SDK 2020.R1 with DX11 FLAG @zhaoye1 . Please consider to close this issue.

Talked to @zhaoye1 , we can close this issue. @zhaoye1  will communicate with the customers if the customers would like to upgrade to MSDK 2020 R1.


Improve doc about documenting API RESTful

Hello,
I'm looking http://flask-restful.readthedocs.org/en/0.3.1/
I was looking for REST API documentation generation with flask-restful.
But I didn't find anything here.
I've found https://github.com/rantav/flask-restful-swagger
but also http://stackoverflow.com/questions/14295322/what-tools-are-available-to-auto-produce-documentation-for-a-rest-api-written-in
but nothing seems to be really standardized.
Maybe doc should be improved to give some guidance about it.
Kind regards

We used sphinx HTTP domain extension to document the API. I believe it is one of the best options at this moment.
http://pythonhosted.org/sphinxcontrib-httpdomain/
I also don't think the project should endorse any specific tool. I think it is out of the project scope.

I've been using the Apiary format (basically markdown) for my projects. I would love a package like flask-restful-swagger for apiary docs, but I agree with @stas that it's outside the scope of this project.


Warning  using self.async_update_ha_state(), without enabling force_update

Version of the custom_component
1.0.0

Configuration
Done via GUI
Add your logs here.

## Describe the bug
A clear and concise description of what the bug is.

HA generate warning message when i use the switch
## Debug log

<!-- To enable debug logs check this https://www.home-assistant.io/components/logger/ -->

```text

Add your logs here.

Sorry, re-opened the wrong issue


Sources for MaSSHandra?

I've heard  that MaSSHandra had autodiscovery feature. Seems very useful if it pairs it with automatic layout algorithm. However, I couldn't find the source code. Is it available?

Hello.
MaSSHandra has autodiscovery features but I'm afraid MaSSHandra is not opensource.
I'll add in the future autodiscovery functions to NetworkMaps.


Drone CLI displays HTML page

If you try to generate a .drone.sec file and the repository is not activated you get an HTML page. It just happened with drone-plugins/drone-hg to me.

Same thing when you ask info about a non-existent repo
e.g.
drone build last org/non-existent

or
drone repo info org/non-existent

this will go away when we move to the react-based ui ... it will allow us to return a proper json message in stead of the 404 not found webpage. I'm going to mark this as wont-fix because we are not going to implement a fix but instead replace the UI


Buttons  issue

Hello,
I'm using bootstrap3-wysiwyg on two forms, one is working perfectly but on the other, I have this :

This is my textarea
<textarea class="form-control input-sm" id="textarea" cols="0" rows="30"></textarea>
And here my scripts (i'm using Laravel)
`{!! HTML::script('style/js/bootstrap3-wysihtml5.all.min.js'); !!}
{!! HTML::script('style/js/locales/bootstrap-wysihtml5.fr-FR.js'); !!}
`
Did someone already resolve this issue and have a solution ?
Thanks you

forgot to include bootstrap3-wysihtml5.min.css ^^


Update dependencies with 'flutter update-packages --force-upgrade'

This bump is to get DDS 2.2.1 which contains a bug fix in the base DAP debug adapter.
Updated packages:
convert: 3.0.1 -> 3.0.2 (changelog)
ffi: 1.2.1 -> 2.0.0 (changelog)
path_provider_linux: 2.1.6 -> 2.1.7 (changelog)
path_provider_windows: 2.0.6 -> 2.1.0 (changelog)
win32: 2.6.1 -> 2.7.0 (changelog)
csslib: 0.17.1 -> 0.17.2 (changelog)
dds: 2.2.0 -> 2.2.1 (changelog)

test-exempt: rolling dependencies

Thanks!
@goderbauer do you have any visibility of what the Google-testing bot is doing? I'm not familiar with how long it normally takes, so unsure if it's stuck.


add funs for kt-module

What this PR does / why we need it?
add funs for kt-module
Summary of your change
Usage
        val input = ByteArrayInputStream(
            "{\"id\":1,\"name\":\"fastjson\"}\n{\"id\":2,\"name\":\"fastjson2\"}\n".toByteArray()
        )

        input.parseObject<User> {
            when (it.id) {
                1 -> assertEquals("fastjson", it.name)
                2 -> assertEquals("fastjson2", it.name)
            }
        }

        input.parseObject<User>(Charsets.UTF_8) {
            when (it.id) {
                1 -> assertEquals("fastjson", it.name)
                2 -> assertEquals("fastjson2", it.name)
            }
        }

        input.parseObject<User>(Charsets.UTF_8, '\n') {
            when (it.id) {
                1 -> assertEquals("fastjson", it.name)
                2 -> assertEquals("fastjson2", it.name)
            }
        }

Please indicate you've done the following:

[ ] Made sure tests are passing and test coverage is added if needed.
[ ] Made sure commit message follow the rule of Conventional Commits specification.
[ ] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Codecov Report

Merging #231 (da89f2f) into main (fd0c804) will decrease coverage by 4.18%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #231      +/-   ##
============================================
- Coverage     73.77%   69.58%   -4.19%
+ Complexity     9495     9128     -367
============================================
  Files           423      423
  Lines         46150    46154       +4
  Branches       9318     9322       +4
============================================
- Hits          34045    32115    -1930
- Misses         8209    10233    +2024
+ Partials       3896     3806      -90

Impacted Files
Coverage Δ

...tlin/src/main/kotlin/com/alibaba/fastjson2/JSON.kt
0.00% <0.00%> (ø)

...main/java/com/alibaba/fastjson2/JSONReaderStr.java
21.94% <0.00%> (-56.57%)
:arrow_down:

...n/java/com/alibaba/fastjson2/util/UnsafeUtils.java
30.18% <0.00%> (-49.06%)
:arrow_down:

...main/java/com/alibaba/fastjson2/util/JDKUtils.java
40.25% <0.00%> (-30.07%)
:arrow_down:

...va/com/alibaba/fastjson2/reader/ValueConsumer.java
16.66% <0.00%> (-16.67%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONReaderASCII.java
65.06% <0.00%> (-15.73%)
:arrow_down:

...java/com/alibaba/fastjson2/JSONWriterUTF8JDK9.java
73.41% <0.00%> (-8.87%)
:arrow_down:

...m/alibaba/fastjson2/annotation/NamingStrategy.java
91.30% <0.00%> (-8.70%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java
52.04% <0.00%> (-6.23%)
:arrow_down:

.../main/java/com/alibaba/fastjson2/util/IOUtils.java
55.06% <0.00%> (-5.07%)
:arrow_down:

... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd0c804...da89f2f. Read the comment docs.


Workflow ui refactoring

Current coverage is 61.77% (diff: 0.00%)

Merging #579 into master will not change coverage

@@             master       #579   diff @@
==========================================
  Files            59         59
  Lines          2789       2789
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1723       1723
  Misses         1066       1066
  Partials          0          0

Powered by Codecov. Last update a7b72a0...077d8da

I'll probably squash all the commits. Just wondering if you wanted to have the full history for review or not.

@TristanWright can you double check the EC2 side of things?

sure will do.
On Wed, Jan 25, 2017 at 9:26 PM, Sebastien Jourdain <
<EMAIL_ADDRESS>wrote:

@TristanWright https://github.com/TristanWright can you double check
the EC2 side of things?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Kitware/HPCCloud/pull/579#issuecomment-275305227, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AMs36W_Eb-CCzMedqFwyWgx374vbXwC6ks5rWCBpgaJpZM4LlEaX
.

--

Tristan Wright

R&D Engineer
Kitware Inc.

It's nice that the actions are queued more independently from the component but I'm a bit confused how they get managed. e.g. there's a missing 'rerun' action on the pyfr/sim/view step, when I make it more like the NWChem view I end up with two rerun buttons which do the same thing? Some doc for this would be good.
I can run on EC2 all success.
No change to the workflow definitions 👍 everything else seems to work as before.

Let's take 5 minutes together so we can fix it. thx for the review.

ctest -R pvwproxy -VV suddenly failing @cjh1 ideas?
https://travis-ci.org/Kitware/HPCCloud/jobs/195978238#L3731

Looks like a Girder issue ...

I will take a look

Fix on Girder master now, I will restart the build


Bring back Markdown editor

Have a view for rendered MD
see: https://vuejs.org/examples/#markdown
https://ckeditor.com/docs/ckeditor5/latest/features/markdown.html (research the license)
https://github.com/hanhdt/vue-trix
https://everright.site/en/formEditor/introduction.html
https://github.com/vriteio/vrite
https://github.com/nhn/tui.editor
https://milkdown.dev/
https://simplemde.com/

Have gone with milkdown
I have a POC view linked in the title bar


⚠ SkipTheCommericals has degraded performance

In 23cccbd, SkipTheCommericals ($STC) experienced degraded performance:

HTTP code: 200
Response time: 4444 ms

Resolved: SkipTheCommericals performance has improved in 32cbdd3.


Allow configuration of additional ingresses for gRPC

The current templates only allow for a single ingress keyed off of service.port, which defaults to the HTTP server. Practically, this means that ingress cannot be enabled for both HTTP and gRPC. The templates could be modified to create multiple ingress objects, and potentially allow for the injection of different backends for different rules.

@alee792 thanks for the issue. Yeah, this is a limitation. For the sake of getting a chart out more quickly, we chose to prioritize the HTTP endpoint integration first, but we plan on supporting an ingress definition for the gRPC service as well. I'll work on getting this change in 👍


Double-quote error

The double-quote error as shown in the example is shown when importing a CSV with newlines and quotes exported by Excel for Office 365.
I find it strange that it's not possible to import a CSV file that is generated by Excel.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4296d1cc-f211-9d17-d97f-2b0858fdea7d
Version Independent ID: cc66dfee-adde-cdfb-b3f5-5d58d89d3c81
Content: Import work items from a csv file through the web - Azure Boards
Content Source: docs/boards/queries/import-work-items-from-csv.md
Product: devops
Technology: devops-agile
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@vanbroup  Thank you for the feedback.
There is a similar issue currently active with the product team posted here.  If this describes what you're experiencing please add a comment there and/or link back to this issue.
Also, an Excel work-around has been posted here, please see if this can be used in the interim.

Thanks, they look to have fixed the double quote manually, this is not really an option with hunderds of records.
The plugin work-around is an option and this seams to work (when you have administrator rights and don't mind to make your excel a little unstable).

Thanks for your question. It looks like your question isn't an issue with the documentation, but an issue or a question specific to your scenario or implementation, or a bug in the product itself.
For help with a specific task, here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot

If you've encountered an issue with the product itself, to make sure it gets in front of the right people, please submit your bug here.
If you have an idea for improving the product, please submit your idea here.


Allow matchers to be reused

This addresses issue #1287.
Previously, matchers retained state after being used as an argument to RSpec::Expectations::ExpectationTarget#to.  In particular, it leaked @extra_items, @missing_items, @best_solution, and @pairings_maximizer. This caused incorrect results when reusing a matcher in subsequent expectations.
This PR addresses the issue by reinitializing the matcher's state when the matcher is reused.
Co-authored by: Rai Feren<EMAIL_ADDRESS>

why ruby 2.2 on windows fails in CI

It segfaulted last time, passed this time, and crashed with no message the first time. I don't think it is caused by your changes or can be fixed. It is not a blocker to merge this PR.

@pirj @JonRowe 👋 Anything I can do to get this PR merged?

Thank you!


Only download required files from segment for metadata push

Currently in SegmentPushUtils.generateSegmentMetadataFile(PinotFS fileSystem, URI tarFileURI), it calls
    fileSystem.copyToLocalFile(tarFileURI, tarFile);

to download the segment from deep store and create a temp copy locally. It then unpacks and untars the segment, extracts the two files of interest (creation.meta and metadata.properties), creates a new tarball with these two files, and then pushes that to the controller.
The actual amount of data extracted from each segment is a tiny fraction of the segment's total size. e.g. For a 200MB segment, the two files of interest are about 4K bytes. When a large number of segments are being pushed, this results in a significant performance hit.
Instead, it's possible to stream/unpack the segment and extract only the data from the two target files, via something like:
        String uuid = UUID.randomUUID().toString();
        File segmentMetadataTarFile = new File(FileUtils.getTempDirectory(), "segmentMetadata-" + uuid + ".tar.gz");
        if (segmentMetadataTarFile.exists()) {
          FileUtils.forceDelete(segmentMetadataTarFile);
        }
        GzipCompressorOutputStream gzOut = new GzipCompressorOutputStream(new FileOutputStream(segmentMetadataTarFile));
        TarArchiveOutputStream tos = new TarArchiveOutputStream(gzOut);

        TarArchiveInputStream tis = new TarArchiveInputStream(new GZIPInputStream(fileSystem.open(segmentUri)));

        TarArchiveEntry tarEntry;
        while ((tarEntry = tis.getNextTarEntry()) != null) {
            System.out.format("%s: %d\n", tarEntry.getName(), tarEntry.getRealSize());

            String fullName = tarEntry.getName();
            String filename = fullName.substring(fullName.lastIndexOf('/') + 1);
            if (tarEntry.isFile() && (filename.equals("metadata.properties") || filename.contentEquals("creation.meta"))) {
                TarArchiveEntry ae = new TarArchiveEntry(filename);
                ae.setSize(tarEntry.getRealSize());
                tos.putArchiveEntry(ae);
                IOUtils.copy(tis, tos);
                tos.closeArchiveEntry();
            }
        }

        tos.finish();
        tos.close();
        tis.close();

The above is just example code, without exception handling, etc. but it is able to create the required tarball from a source segment.
The real performance win is because the two files of interest occur in the segment tarball before the big files (columns.psf, star_tree_index, etc) so it would be appropriate to enforce this ordering in the segment writer utility code.

We can use TarGzCompressionUtils.untarOneFile() to untar one single file from the segment tarball

@Jackie-Jiang - the problem with TarGzCompressionUtils.untarOneFile() is that it still requires the segment to be previously downloaded from deep storage to local storage, which is the time-consuming bit that can be avoided.

Oh I see the problem you referred to. There are 2 versions of metadata push, one also push the segment metadata to the controller so that controller doesn't need to download the segment from the deep store.

Hi @Jackie-Jiang - yes, re using a metadata push so that the controller doesn't have to download the segment. But I'm curious what the 2 versions of metadata push were. I only know of a full segment push, and a metadata push (at least from how you can configure the job yaml).

Just went over the code, and we are actually using the proper metadata push API (the other way is letting the controller download the segment and extract the metadata). The inefficiency comes from not using the metadata from the local generated segment.
Ideally, we should follow these steps when generating and pushing the segments:

Generate the segments from the raw data
Cache the segment metadata from the local files
Tar the segments and upload to deep store
Push segments using the cached metadata

Hi @Jackie-Jiang - yes, it would be more efficient to save the metadata when doing a generate-and-push job. But for our use case, we run Hadoop map-reduce jobs to build segments (highly parallelized) and save to HDFS, and then separately have Pinot jobs to push the segments. So for that use case, we'd want to still do this optimization. Others on Slack have suggested saving the metadata files to a separate directory during build time, but in my mind that adds both complexity and the potential for data miss-match without much benefit.

Make sense.
To achieve the benefits described above, we need to ensure 2 things:

The metadata files should be put in the beginning of the tar ball
The PinotFS.open() implementation only download block of data instead of the whole file (checked the S3PinotFS and seems that is not the case)

Others on Slack have suggested saving the metadata files to a separate directory during build time, but in my mind that adds both complexity and the potential for data miss-match without much benefit.

The benefit is a guarantee that this works everywhere. Could you elaborate on how the the mismatch scenario arises in concrete terms?

Hi @richardstartin - could you explain what you mean by "this works everywhere"? That makes me feel like I don't really understand what you're proposing, and/or that you don't understand what I'm proposing. Streaming unpack of files should also "work everywhere", and should be highly performant, with minimal code changes.
As to the mismatch scenario, I'm assuming the idea is to store segments in directory A, and associated metadata in directory B. If an ops person copies updated segments to an archive dir, and forgets to copy the associated metadata, you would have miss-matched data. My previous experience dealing with Hadoop map files, which had an index and an associated data file, taught me the dangers of having to keep files in sync. But maybe there's a very different approach you're proposing that I'm missing, so some clarification would be great.

could you explain what you mean by "this works everywhere"? That makes me feel like I don't really understand what you're proposing, and/or that you don't understand what I'm proposing. Streaming unpack of files should also "work everywhere", and should be highly performant, with minimal code changes.

I understand what you’re proposing. You want to start downloading the segment and, relying on the metadata being at the start of the segment, essentially abort the download once you have the metadata. The motivation is to save the download time for most of the segment file. Is that correct?
By everywhere, I mean for all filesystem implementations and for all segments, no matter how they have been generated or by what. It is not currently specified where the metadata file is within the segment file, segment files may not have been generated by the code within this repository, and the metadata may not be at the start of the file.

As to the mismatch scenario, I'm assuming the idea is to store segments in directory A, and associated metadata in directory B. If an ops person copies updated segments to an archive dir, and forgets to copy the associated metadata, you would have miss-matched data.

Without meaning to appear facetious, this sounds a bit like what happens when users occasionally tamper with transaction logs in RDBMS and hope for same outcomes. Shouldn’t the user just not do that?
Regarding directories, assuming metadata is stored in a separate file from the segment, is there a good reason for it to be in a different directory? WDYT @mcvsubbu? I know you expressed similar concerns to mine on slack.

@richardstartin - yes, re aborting the download once the two files of interest (metadata.properties and creation.meta) have been extracted. This will still work even if these files aren't near the beginning of the file, or before the bigger data files. It will just not be as much of an optimization, but even in the worst case it will be faster than the current code (no creation of temp files on local disk).
As to what happens with copying of files - it's not really the same as messing with transaction logs. Ops people (like the team for one of our clients) copy around segment files all the time, as they try out our different optimizations for how data is indexed, or manually roll back after there's an issue with the data being used to build new segments.
Re where to put the metadata files - If the two metadata files are packaged as as currently expected by the controller, then they'll be <blah>.tar.gz files. In that case they really shouldn't be in the same directory as the actual segment tarballs, as segment pushes will try to push everything with that suffix to the controller. If you do a metadata push then it could rely on a naming convention to only process the metadata files.
You could leave the files untarred, but now you have a bunch of <name>-metadata.properties and <name>-creation.meta files littering the segment directory. We have HDFS directories with 1200+ segments, so adding another 2400 of these tiny files doesn't feel clean.

So the analogy with transaction logs was messing with a system’s state without fully understanding the consequences. You do it at your own risk, and file structures shouldn’t be optimised to simplify manual actions.
I agree that the exact order of the segment file changing doesn’t create a correctness problem, but it does make a very worthwhile optimisation brittle. My concern is that this optimisation is always an optimisation and doesn’t break for silly reasons.
Clean is a very subjective term. It means different things to different people. Files with different suffixes in the same directory as the segments does not feel unclean to me.

@Jackie-Jiang - good catch re S3PinotFS buffering the entire file into memory on the open() call. I've checked the other FS implementations, and they don't seem to be doing a complete download, but rather are returning a stream to the original source data. I've pinged @KKcorps on Slack to find out the reasoning here, as it seems possible to use the S3Client support for getObject() to avoid the download.

For the sake of considering alternatives, if the required metadata could be squeezed into 2KB it could be stored in the file attributes on the segment file. S3 allows retrieval of all attributes without downloading the file via a HeadObject request, and HDFS extended file attributes support a similar lightweight access protocol. Naturally, GCS has the same concept, as does Azure. I believe this would address concerns about separation, directory structures, but also provide good guarantees., the only catch is the limit of 2KB for user defined attributes.
The metadata written into creation.meta consists of a crc and creation time, metadata.properties is heavier, but it could all be written in to a JSON object which could be compressed, base64 encoded and saved as a single file attribute on the segment file.
Optimistic HeadObject/getfattr requests would be made to the filesystem. Support for old segment files without the correct metadata would be provided by falling back to the mechanism proposed here, and eventually metadata would always be retrieved successfully first time by reading file attributes without downloading any segment files.


Train with 3D vertices only

Hi,
Thank you for your great work! As my data only have 3D vertices (no joints), I want to use the vertice loss only. I modified the loss here to
loss = args.vertices_loss_weight * loss_vertices
But it raises the error:
RuntimeError: element 0 of tensors does not require grad and does not have a grad_fn.
Do you have any idea about using vertice loss only? Thank you!

Hello @zgzxy001 ,
May I know do you fix this problem.
And how you deal with the data without joints.
For me I'm confusing to generate the data by my own 3D mesh(.obj file) without joints.
Thanks !

Hi all, sorry for the late reply.
In order to train with vertex loss only, there are some possible ways:
(1) Simplify use fake joint GTs in our training pipeline. Also, set "joint_loss_weight" to zero. Although it is hacky, this requires less minimal modification, and it might be easier to debug.
(2) Modify our network by removing any joint query tokens. Also, remove 2d/3d joint related loss functions.
In addition, you may need to tune a little bit for "vertices_loss_weight". The default setting may not work in this case.


Performance Regression Testing: Add timestamps to results and make filenames unique.

Description
The regression testing results currently do not output the time they were taken which is a bit of an oversight. It now uses the default serde serialization for chrono::DateTime<UTC> so it can be easily deserialized the same way. Uniqueness added to filenames by pulling the epoch time out of the DateTime value.
I have verified locally that the output file has all the newly added components correctly written out.
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

Manually triggered the GitHub Action to make sure the flow works. I won't merge till this passes.

It passes the github action flow now.


Make health check in Dockerfile honor context path setting

When using the context path setting the health check defined in Dockerfile fails, reporting the container state as unhealthy. That's because the path to the health endpoint is hardcoded to /health in Dockerfile, while the actual endpoint is provided under ${LD_CONTEXT_PATH}/health.
This patch changes the path in Dockerfile to honor the value of LD_CONTEXT_PATH.

Thanks!


⚠ Bofrost.at has degraded performance

In c7d3a75, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2704 ms

Resolved: Bofrost.at performance has improved in 78a317d after 6 minutes.


decouple timestamp from observable

Decoupled timestamp from observable, please review.
and Merry Christmas! :christmas_tree:
Thank you,
Grigoriy

Merry Christmas!🎄


Add dockerfile for imposm3 including mapping generation

This PR introduces a dockerfile for imposm3 to ease build process and update maintenance.
Beware, as paths differ between docker and local architectures, your original imposm3.conf should be preserved to run without docker
The docker build operation includes the mapping.json file generation with Python help.
Tegola server will get its own dockerfile as well in another PR. A docker-compose file could be included finally.

@russss did you manage to dockerise imposm3 as well?

Sorry again for re-implementing this in a different way!


Bicep Community Call - August '23

We are hosting our August Bicep Community Call Thursday, August 31st at 2PM PST!
(We will switch off from 9AM to 2PM PST every other month to accommodate for different time zones)
Use this issue to address topics you would like to discuss, questions you have for our team, further demos you would like to see, and any high or low points you would like to share. This is an open space for our users to discuss any topics they would like to talk about with our team.
You can list topics of discussion in this thread OR you can ask questions during the Q&A portion of the call.
Please sign up here to get an invite to the call. See you there!

Thanks for heads up! we have uses cases where we want to have the function loadJsonContent load contents dynamically, so something like this:
param path string

var objects = loadJsonContent(path)

This is not currently possible. Any Plans to implement this? Is there a current option with the current status of bicep to have such flexibility?

Is it possible to get an update on this issue?
https://github.com/Azure/bicep/issues/10494
There was a comment about it being discussed in April but no response back in the issue comments.
This would be an awesome feature if its possible! Thanks for the great work on this project 👍

Is #10345 happening for the 0.21 milestone and is the feature behavior fully described? With a growing number of modules and API references I want insight into where I could be lagging behind whether it's a preview or stable version, and also regardless of age. (Some resource providers are more dynamic than others.)

I've been struggling lately with the (advanced?) use case where I would like to output the private IP address of a private endpoint I just created. Would it be possible to showcase how to solve this, or point me to an existing example? I couldn't find any working example...
So I have a bicep module to create the private endpoint, and I'm trying to output the IP address of the (first) nic/ip configuration created:
resource endpoint 'Microsoft.Network/privateEndpoints@2021-05-01' = {
   ...
}

output plinkNicId string = endpoint.properties.networkInterfaces[0].id
output privateIp string = endpoint.properties.networkInterfaces[0].properties.ipConfigurations[0].properties.privateIPAddress

This bicep extension in my VSCode validates the above code (I created the definition of the privateIp output using intellisense), but when I deploy it, there seems to be something wrong with that output definition:
13:54:31 - The deployment 'xxxx' failed with error(s). Showing 3 out of 4 error(s). Status Message: The template output 'privateIp' is not valid:
     | The language expression property 'properties' doesn't exist, available properties are 'id'.. (Code:DeploymentOutputEvaluationFailed)  Status Message: The template output
     | 'privateIp' is not valid: The language expression property 'properties' doesn't exist, available properties are 'id'.. (Code:DeploymentOutputEvaluationFailed)  Status
     | Message: Unable to evaluate template outputs: 'privateIp'. Please see error details and deployment operations. Please see https://aka.ms/arm-common-errors for usage
     | details. (Code: DeploymentOutputEvaluationFailed)  - The template output 'privateIp' is not valid: The language expression property 'properties' doesn't exist, available
     | properties are 'id'.. (Code:DeploymentOutputEvaluationFailed)   CorrelationId: xxx-xxx-xxx-xxx

What am I missing or is there another technique?

@jbtcode Try this:
output privateIp string = endpoint.properties.customDnsConfigs[0].ipAddresses[0]

@jbtcode Try this: output privateIp string = endpoint.properties.customDnsConfigs[0].ipAddresses[0]

Yes, that works, thanks a lot! A bit obscure but I won't complain 😄

@stephaniezyen when will the recording be uploaded to the youtube channel?

@fabge It was uploaded yesterday! :) You can find it here

Is it already possible to test out the dynamic type loading feature presented by Ariel Silverman? Now the import namespace is not recognized with nightly builds.

Is it already possible to test out the dynamic type loading feature presented by Ariel Silverman? Now the import namespace is not recognized with nightly builds.

@asilverman -- can you take a look at this one?


SROA: Do scalar replacement on structs with no partial references.

This change allows for scalar replacement of structs with no references to their individual components. This was previously disabled, likely due to concern about increasing shader size.
While theoretically one might be able to write a shader for which this change may cause the shader to become larger when optimized, in practice all the shaders observed did not get larger, and a few shaders experienced moderate to large size decreases. This is because SROA allows better analysis of struct references enabling improved dead code detection, among other optimizations.
The new test in this commit demonstrates the code pattern which benefits from this change. It is a pattern similar to that generated when a struct valued function with early returns is inlined. This test also demonstrates how such a pattern can mask dead code and how this change allows for its deletion by subsequent passes.

@alan-baker Please review this change. Are you aware of specific real-life shaders for which this change would increase their optimized size?

The effect this has is that when we do the load-store removal, the OpPhi instructions that get generated will be split up.  Without this change, there will be 1 OpPhi merging the entire structure.  I can definitely see this helping some of the shaders I've been looking at.

I believe I have addressed all concerns with my last round of commits.

@greg-lunarg Does this have an issue associated with it?

Does this have an issue associated with it?

No. I wrote the PR to include what I would put into an issue.

Rebased, squashed and committed as ca4457b4b6e20f8f37731a3cf086e963fa52ff31.


Allow specifying multiple protocols on a single port / Add PROXY protocol support

Originally written by @hyangtack in #1100
Motivation:
In some environment, a user may need to serve HTTP and HTTPS on a single port, but Armeria does not allow it.
Modifications:

Make ServerPort have a list of SessionProtocols in order to allow to serve HTTP and HTTPS on a single port.
Add support for PROXY protocol in order to interoperate with HAProxy well.
Expose source and destination addresses delivered from PROXY protocol as ProxiedAddresses.

Result:

Closes #1099

Added Javadoc and updated the web site to mention PROXY protocol support.

@minwoox @anuraaga PR updated

@anuraaga @minwoox Fixed all. Please review again.

Thanks, reviewers!


Support --timings extra argument

Motivation
Currently, the --timings (Typst source) extra argument is unsupported, triggering a "failed to parse typstExtraArgs" error. Supporting this extra arg could be useful to analyze compilation time and work on optimizations for templates or specific files.
Description
N/A
Examples/Questions
N/A

https://github.com/Myriad-Dreamin/tinymist/pull/166

Ah, missed that! Thank you.


Restraunt Ordering System Project

🛠 Issue (Number)

Closes # 688
Description

The project is based on a Utopian theme inspired by Elon Musk's vision of life on Mars in 2050.-
The system eliminates the need for waiters in the restaurant.
The aim is to provide an innovative and futuristic dining experience to customers.

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] The title of my pull request is a short description of the requested changes.

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Hey @Vanshiii203  The project I have developed encompasses both the customer and admin sides of a restaurant. In addition, it features a unique 3D display using webgl that showcases the restaurant's menu items. As such, it differs from the project you previously mentioned which lacks these distinctive features .

The mentioned project doesn't have a admin side to manage the orders and allocate the number per order/table .

I believe that my project is unique and I am I look forward to getting it merged.

Hey @Arun9739  Thank you for suggesting the change . I wanted to let you know that I have already created a readme file and included it in the project files when I pushed the project and opened a pull request here!

If you have any specific feedback or changes that you would like me to make to the existing readme file, I would be happy to work with you to make those revisions. Please let me know if there is anything else that I can assist you with.

Attaching a screenshot for your refference here.

@Arun9739 Please review the changes, Project submission deadline is approaching

Can you remove that duplicate label @Vanshiii203


Avoid empty generators where possible.

This commit was inspired by #218. It turns out that it ends up being
very easy to accidentally create empty generators (that will never
return Some(_) values) unnecessarily. The particular issue was around
usage of Gen.sized, but there are a number of other combinators that
end up creating empty generators in some cases.
Previously, when the arguments to a combinator make it impossible to
produce a value, ScalaCheck has preferred to produce empty Gen[T]
values. After this change, combinators whose arguments make it
impossible to generate values will instead throw exceptions during
creation. This makes it easier for the author to realize and correct
their mistake.
The commit also tightens up a bunch of the internal logic around
generating collections, numbers in a given range, etc. to minimize the
use of empty generators.
The reason why empty generators are a much bigger problem now than
before is the introduction of Cogen[T]. When we produce an arbitrary
A => B value, we do so by using a Cogen[A] to permute the PRNG,
and then use a Gen[B] to produce a B value from that PRNG
state. If our generator is empty (or even if it's a very sparse
partial generator), this process will fail when we try to apply the
function to an A value.
Since ScalaCheck allows empty generators (as QuickCheck does) there's
probably no backwards-compatible way to be 100% sure a Gen[B] is
safe to use. However, in practice most Gen instances could be safe
to use this way (as they are in QuickCheck), but are not due to how
easy it is to end up with empty (or mostly empty) generators.
This changes is binary compatible with the last release (check with
MiMA). It does introduce new runtime behavior (in the form of some new
exceptions users might see), but I think the change is worth it to get
faster (and safer) generators, as well as more reliable function
generators.
Review by @rickynils, @xuwei-k, and anyone else interested.

@non I haven't looked through everything yet, but so far it looks great! Do you think it would be possible to split it up a bit, though? For example, the improvements you've made to Choose, could it be a separate commit? On the surface it looks like an isolated change, but I might have missed things.

@rickynils Sure! I can split it out into two parts (although it is related, since the old Choose classes would use empty generators when the bounds were impossible).

@rickynils If you want I can close this PR and try to redo it with 2-3 atomic commits (that each pass MiMA/tests).

@non Yeah, that would be awesome, if you're up for it

OK, will do. I'll leave this open now and will close it when I open the new one.

Closed in favor of #258.


Port 1194 not open

Hi, I have instal pivpn and when I check my raspberry pi don't have the port 1194 open, so what should I do , open it my self and pivpn will take the reste or must I do something else.

::: Copy saved to /tmp/debug.txt
:::

Yes, just open the udp 1194 port on your router and it should work fine.

@Insinfi
First things first... how have you checked it the port is open?
Are you sure it isn't open on the pi but closed on the router?
Provide the output of
iptables -t nat -S
iptables -S

closing issue as no reply was given.

I'd like if this question was re-opened. I ran through booting up a pivpn on my RPi and don't see port 1194 being open at the end of the scripted setup. I'm seeing that the port isn't open because I run ($ telnet <IP_ADDRESS> 1194) from my laptop and connection is refused. But running ($ telnet <IP_ADDRESS> 22) does grant access to my ssh server on my RPi.

Same here, port 1194 is not opened.

@osethan @bobblkabb
Not reopening ... open a new issue with all the proper information needed!!
Make sure the port is properly open and forwarded on the router side ... and provide the information I have requested previously ...I really want to help people around here but ...  we don't guess things!
Thank you


PUT /api/teams/:id Returns success on empty body

Response is always success and response body is always "1". Need to determine what to respond with and also need to add some middleware to check if request body contains data

 PUT /api/teams/:id Returns success on empty body


🌱 Add tuminoid as a reviewer

Add Tuomo to the reviewers list.
Contribution https://github.com/metal3-io/cluster-api-provider-metal3/pulls?q=is%3Apr+author%3Atuminoid+is%3Aclosed

/approve
/lgtm
/test-ubuntu-integration-main

/lgtm
I had to rebase the PR did not get merged

/test-ubuntu-integration-main

/lgtm

/cherry-pick release-1.3

/cherry-pick release-1.2


Reinstall win 10 in an other ssd  use sdk  issue

Executing task: C:\Users\Wu\AppData\Roaming\npm\asconfigc.cmd --flexHome e:\Program Files\Adobe\Adobe Flash Builder 4.7 (64 Bit)\eclipse\plugins\com.adobe.flash.compiler_<IP_ADDRESS>9722\AIRSDK --debug=true <

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.common.base.internal.Finalizer (file:/E:/Program%20Files/Adobe/Adobe%20Flash%20Builder%204.7%20(64%20Bit)/eclipse/plugins/com.adobe.flash.compiler_<IP_ADDRESS>9722/AIRSDK/lib/guava-r08.jar) to field java.lang.Thread.inheritableThreadLocals
WARNING: Please consider reporting this to the maintainers of com.google.common.base.internal.Finalizer
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
??????: e:\Program Files\Adobe\Adobe Flash Builder 4.7 (64 Bit)\eclipse\plugins\com.adobe.flash.compiler_<IP_ADDRESS>9722\AIRSDK\frameworks\flex-config.xml
e:\Program Files\Adobe\Adobe Flash Builder 4.7 (64 Bit)\eclipse\plugins\com.adobe.flash.compiler_<IP_ADDRESS>9722\AIRSDK\frameworks\flex-config.xml:47
??: ?????e:\Program Files\Adobe\Adobe Flash Builder 4.7 (64 Bit)\eclipse\plugins\com.adobe.flash.compiler_<IP_ADDRESS>9722\AIRSDK\frameworks\libs\player\11.1\playerglobal.swc??
e:\Program Files\Adobe\Adobe Flash Builder 4.7 (64 Bit)\eclipse\plugins\com.adobe.flash.compiler_<IP_ADDRESS>9722\AIRSDK\frameworks\flex-config.xml (line: 47)

Does compilation fail? I'm not sure what I'm looking at here in your output. I don't see any mentions of errors.

thanks！Compilation done！ what mean about "All illegal access operations will be denied in a future release",  can update at new release at future

This warning is from AIR SDK compiler when it's running on Java 9. Adobe needs to update one of its dependencies.


[FLOC-3366] Split the loopback API into its own module.

https://clusterhq.atlassian.net/browse/FLOC-3366
I didn't factor out the tests, since they are tied tightly to the deployer tests.

Great.  Thanks.  Please merge when buildbot is green.


Copy report to clipboard does not work in new multi-destination world

The text in the clipboard is like this:
Meeting on 2024-10-29 at 11:20
Destination: [object Object],[object Object]
Attendee: Zara, From: Manchester Piccadilly, Departure: 08:15, Arrival: 11:12, Duration: 191 minutes
Attendee: Leah, From: Norwich, Departure: 08:30, Arrival: 10:57, Duration: 173 minutes
Attendee: Sara, From: Combe (Oxon), Departure: 09:03, Arrival: 11:05, Duration: 155 minutes

Note the [object Object] bits.

Destination is now working, attendee station now broken
Meeting on 2024-11-22 at 10:40
Destination: Manchester Piccadilly
Attendee: Dave, From: undefined, Destination: Manchester Piccadilly, Departure: 06:53, Arrival: 10:19, Duration: 232 minutes
Attendee: Mary, From: undefined, Destination: Manchester Piccadilly, Departure: 07:11, Arrival: 10:19, Duration: 212 minutes
Attendee: George, From: undefined, Destination: Manchester Piccadilly, Departure: 07:26, Arrival: 10:19, Duration: 197 minutes
Attendee: Ian, From: undefined, Destination: Manchester Piccadilly, Departure: 06:53, Arrival: 10:29, Duration: 231 minutes

I suspect this typo may have something to do with it (or not, either way it's a typo)


Simplify media url

Coverage remained the same at 94.367% when pulling 20406fd786754145362cdc5d032efb4c242a2359 on rahul-simplify-media-url into 34fe5647b09e31b9c95ad6366a639b1dcca400b5 on main.


[DOC] Add overall documentation and instructions on how to connect data sources for security analytics

What do you want to do?

[ ] Request a change to existing documentation
[X] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

The security analytics team has built something that is potentially very valuable, but using it is quite hard. For example:

Okay, network events. Sounds interesting. I want to use it, questions that come to mind:

Network events is quite general, what is it?
Which data sources should I use?
How do I connect these data sources?
How do I connect these data sources effectively so mapping efforts are minimal?

The documentation is very minimal, there is very little attention paid to how data is ingested while this is the foundation of the functionality of this module.
Ideally you would relate this based on something like the NIST security framework, which identifies risks and gives tips on how to mitigate. You can use this to drill down in the documentation:
High level risk - monitoring category - how to connect the different data sources for this monitoring category.
I.e.
DE.CM-1: The network is monitored to detect potential cybersecurity events - Network detection Response - How to connect Suricata and what document structure would be ideal (plus some instruction for configuring fluent-bit, logstash, data prepper
Throw this is a table for all data monitoring categories and sources and this would be very helpful to the users. The framework can also guide the team on what sources to add and in what order.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
https://www.nist.gov/cyberframework/framework

I got the question to open a new issue in https://forum.opensearch.org/t/using-security-analytics-is-hard-mostly-because-of-a-lack-of-documentation/16271 and fond my own issue :) So I can just reference this issue there, this sums up the needs quite well. I had a really good call with Xenia. I'm open to plan another call if needed.
How to ingest logs in such a manner that it can be processed by the plugin is totally unclear. Which log ingesters to use, do you need certain index pipelines, how to map the data? For each log type the flow needs to be described end to end.


Add gitlab_omniauth_providers

After #105 was merged, you are able to add extra settings like these via that parameter.


How do I pass task='regression' to DeepTable'?

I haven't figure out how to pass the task which I want done to DeepTable. I saw that I can pass it to DeepModel(task='regression'). However, I want to pass it to DeepTalbe.
Edit: The reason I want to do this is that the auto-task categorizes the task as a multiclass classification if I pass ints as y, and the number of classes < 1000 (which they are in my case). I could, of course, convert the ints to float32, but I want the control over the model directly.

@gladomat Not supported yet, we will improve it as soon as possible.Thank you very much for your suggestions!

@gladomat @jackguagua you can set it in ModelConfig now just like：
config = deeptable.ModelConfig(nets=deepnets.DeepFM, auto_discrete=True,  task='regression', metrics=['MAE'])
dt = deeptable.DeepTable(config=config)

model, history = dt.fit(df_train, y, epochs=2)

The optional values for the attribute task are:

'auto' (as default value, infer from dataset .)
'binary'
'multiclass'
'regression'

Update code from master branch and try again, good luck !


Replace ryanj/pillar-base with a simple hapi app

We need a basic Hapi application that we can use as an example, and a foundation for Node.js examples on OpenShift. See: https://github.com/bucharest-gold/origin-s2i-nodejs/tree/master/nodejs.org#usage
Currently that is https://github.com/ryanj/pillar-base but we should have something of our own that we can build on.

https://github.com/bucharest-gold/s2i-nodejs#the-app
/
/info
/status

Excellent!


multi usb cameras (d435i and others)

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D435i

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 16.04.4 LTS

Kernel Version (Linux Only)
4.9

Platform
sda845

SDK Version
2.29.0

Language
c++

Segment
Robot

Issue Description
<Describe your issue / question / feature request / etc..>
HW condition :
I'm using two d435i and three usb cameras(logitech c930e).
hw connection is like below.
( d435i 2ea ) -> 3.0 usb port -> pcie   ───────> sda845
( c930e 3ea ) -> 3.0 usb hub -> 2.0 port ─┘
I enabled one d435i RGB stream (848480, 30fps). (didn't enable the other d435i yet.)
c930e 1,2,3 are streaming RGB (mjpg 960540, 30fps).
I am capturing every 66ms,
Enabling one depth stream of two d435i, sometimes causes frames to come too late. (over 120ms.)
With all depth stream enabled, frames come out very late.!
Is there any way to improve it?
I want to enable at least one depth stream of the two d435i.
and i hope all frames come out in time. (66ms)

Hi @jjuhee  You stated that you enabled the RGB stream of a D435i at 848x480 and 30 FPS.  Then you enable 'one depth stream of two D435i'.
Are you using both RGB and depth on one of the D435i and finding that the depth FPS rate drops to half, please?

i'm sorry for not explaining properly.
if i enabled both RGB and Depth of one d435i, then c930e device is often slow to receive frame.
i'm using 4 threads for each camera device, and measured the time to receive the frame.
(forget about the other d435i. (connected but not using), so one d435i , three c930e)
i mesured the time between 1 and 2 marked below. :(
getRSFrameThread()  { // thread for d435i
1
*sensor_ok = pipe.try_wait_for_frames(&fs, 1000U);
2
}
getMultiUVCFrameThread()  { // thread for c930e
1
bRet = m_vstUVCVideoCaptures[idx].oVideoCapture.grab();  // opencv VideoCapture API
2
}

good case :

[03-01 02:45:13.831692]  [RS2::UVC] getMultiUVCFrameThread() idx 1 Check time duration(us) : 291 / 66000
[03-01 02:45:13.831893]  [RS2] getRSFrameThread() Check time duration(us) : 36 / 66000
[03-01 02:45:13.850964]  [RS2::UVC] getMultiUVCFrameThread() idx 2 Check time duration(us) : 894 / 66000
[03-01 02:45:13.867213]  [RS2::UVC] getMultiUVCFrameThread() idx 0 Check time duration(us) : 534 / 66000
[03-01 02:45:13.886333]  [RS2::UVC] Check time duration(us) : 56398 / 66000 // total duration measured in main function.

bad case :

[03-01 02:45:19.971425]  [RS2] getRSFrameThread() Check time duration(us) : 34 / 66000
[03-01 02:45:19.971894]  [RS2::UVC] getMultiUVCFrameThread() idx 0 Check time duration(us) : 638 / 66000
[03-01 02:45:19.989775]  [RS2::UVC] getMultiUVCFrameThread() idx 1 Check time duration(us) : 722 / 66000
[03-01 02:45:20.127627]  [RS2::UVC] getMultiUVCFrameThread() idx 2 Check time duration(us) : 119637 / 66000
[03-01 02:45:20.153968]  [RS2::UVC] Check time duration(us) : 183027 / 66000

Thanks very much for the clarification and additional detail.  I researched the c930e and see that it has a lighting auto-correction feature called RightLight.  It may be worth turning the D435i away from the c930e if they are facing each other to see whether that improves the c930e's timing.  This is because the D435i's IR emitter component might be causing disruption if the laser is projecting light into the c930e 's field of view.

they are not facing each other.

Are the D435i and c930e cameras synced in any way or do they opoerate completely independently?

how can i know that they synced ?
i just wait for all threads to join() and use.

If you are not deliberately syncing the cameras then they would not be synced and would be operating independently.
For example, the link below has a past case of a RealSense user who deliberately synced their RealSense camera with a non-RealSense camera using camera metadata.
https://github.com/IntelRealSense/librealsense/issues/2186

I don't know if I can check it this way.
I checked CAP_PROP_POS_MSEC in opencv api.
In the good case, the time difference between each thread is about 50ms,
but in the bad case, it seems to increase to 200~300ms.

good case:

[03-01 00:02:28.811777]  [RS2] getRSFrameThread() Check time duration(us) : 33 / 66000
[03-01 00:02:28.812196]  [RS2::UVC] getMultiUVCFrameThread() idx 0 Check time duration(us) : 505 / 66000
[03-01 00:02:28.830648]  [RS2::UVC][jhee] idx 0 CAP_PROP_POS_MSEC: 143571
[03-01 00:02:28.832606]  [RS2::UVC] getMultiUVCFrameThread() idx 2 Check time duration(us) : 349 / 66000
[03-01 00:02:28.846266]  [RS2::UVC][jhee] idx 2 CAP_PROP_POS_MSEC: 143514
[03-01 00:02:28.847819]  [RS2::UVC] getMultiUVCFrameThread() idx 1 Check time duration(us) : 454 / 66000
[03-01 00:02:28.863777]  [RS2::UVC][jhee] idx 1 CAP_PROP_POS_MSEC: 143648
[03-01 00:02:28.870354]  [RS2::UVC] Check time duration(us) : 58884 / 66000

bad case:

[03-01 00:02:30.549906]  [RS2] getRSFrameThread() Check time duration(us) : 41 / 66000
[03-01 00:02:30.748760]  [RS2::UVC] getMultiUVCFrameThread() idx 1 Check time duration(us) : 198820 / 66000
[03-01 00:02:30.768686]  [RS2::UVC][jhee] idx 1 CAP_PROP_POS_MSEC: 145641
[03-01 00:02:30.771193]  [RS2::UVC] getMultiUVCFrameThread() idx 0 Check time duration(us) : 705 / 66000
[03-01 00:02:30.788643]  [RS2::UVC][jhee] idx 0 CAP_PROP_POS_MSEC: 145101
[03-01 00:02:30.790122]  [RS2::UVC] getMultiUVCFrameThread() idx 2 Check time duration(us) : 335 / 66000
[03-01 00:02:30.803618]  [RS2::UVC][jhee] idx 2 CAP_PROP_POS_MSEC: 145439
[03-01 00:02:30.807423]  [RS2::UVC] Check time duration(us) : 258636 / 66000

Referring back to your original diagram about the USB configuration:

I note that the c930e cameras are connected to a USB 3.0 hub but the hub is apparently connected to a USB 2.0 port.  That is likely to result in a speed bottleneck, as the hub would be treated as a slower USB 2.0 device.  It is like how a device on a USB 3 cable that is plugged into a USB 2 port will be treated as USB 2.  A USB 3 device needs to be connected to a USB 3 port to take advantage of its full capabilities.

c930e is actually USB2.0 supported device. So I use 2.0 hub also.

could it be a bandwidth issue ?
Is it possible to get RGB camera data in Y8 format from C3D to reduce the amount of data?

The RealSense Viewer's Add Source button allows the adding of sources that are not RealSense camera models, such as the built-in webcam of a laptop (see the image below).  I do not have an external USB webcam to test with though.

Hi @jjuhee  Do you require further assistance with ths case, please?  Thanks!

Sorry to late.
but I don't know your intentions.
I can attach the webcams with the latest version of Realsense viewer. what should I do after that ?

I do not have an ordinary webcam to test with.  But I would assume that if the RealSense Viewer is able to detect the webcams then they would be listed if you click on the Add Source button at the top of the Viewer's options side-panel.  You could then left-click on a webcam in the list to add it to the Viewer.

Hi @jjuhee  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


Is it known which models are supported?

Hi,
can you tell if the SolarEdge SE5K inverter supports modbus TCP? I only saw modbus on RS485 in the documentation, but I may have missed something.
Thanks
Rainer

Reading inverter values over Modbus (TCP) is supported by all inverters with firmware version 3 and higher.
Have a look at this document, specifically the section "Modbus over TCP configuration."


Syntax highlighting for Swift doesn't work

For Swift all text inside fences is rendered in the same color.
Works correctly using DocDock theme.

This is by design, highlight.js only ships with support for a few core languages and Swift is not included in this list. Visit https://highlightjs.org/download/ and see which languages are included by default.
If you want to enable Swift support visit the highlightjs download page and select the languages you want to support. Replace js/highlight.pack.js and css/hybrid.css in the theme with the downloaded versions and you should be good.


Hi, this function name is confusing...

Love you guys, it took me 2 days to figure out what this function described, and I hope it helps others to better align with ML data science. again... with love.

I don't know if it's something from my end, but I've been fighting a Denial of Service Attack for a week and they keep logging in as admin under my name.  If it is from "me"...sorry.
s


Add DataCollectionSynth

Going to leave this as draft because I'd like to explain my use case and see if you folks are willing to accept this. If so, I will add tests.
In my project I have a custom DataCollection called StationCollection and because I'm using Livewire (v3), I had it implement Wireable. However, the WireableSynth in Livewire expects properties:
    function set(&$target, $key, $value) {
        $target->{$key} = $value;
    }

Which throws an error when used.
To work around this I created a DataCollectionSynth that handles things properly, and then made a custom synth that inherits from DataCollectionSynth to deal with my custom stuff (mostly type hinting).
Note that to use this, one would have to add this to your service provider, Livewire::propertySynthesizer(DataCollectionSynth::class);
Does that sound reasonable?

Hi @edalzell,
Thanks for the PR, I first need to get started with LiveWire 3 and read myself into the hydration and synthesizers part. When that's done I'll again take a look at this PR!

Just pushed a fix, we need to dehydrate recursively (thanks Josh!)

Still on my radar, now I have some time since v4 is our gonna take a look at this next week or the week after that.

Thanks!


[BEAM-6988] Implement a Python 3 version of getcallargs_forhints

This new version uses inspect.signature instead of getfullargspec and
getcallargs (partially for now - see TODO).
The difference is that version 3.7 introduces function signatures for
builtins, but getcallargs has a bug with treating optional positional
arguments https://bugs.python.org/issue36920 and it's deprecated.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Here's my suggestion for fixing #8530. I tried to keep changes to a minimum and behavior similar.
R or CC: @NikeNano @tvalentyn @fredo838 @robertwb

run python postcommit

run python postcommit

looks like test_convert_to_beam_type[s] test are currently failing on Py3.5.

How do you see this? I have check the logs and as far as I can see it only say: "sdks:python:test-suites:direct:py35:postCommitIT" for Python SDK PostCommit Tests on Python 3. In the console output.

@NikeNano Valentyn was referring the precommit test's failure: https://builds.apache.org/job/beam_PreCommit_Python_Commit/6421/
As for the postcommit test failure I see this line in the console log (viewing the full log):
test_big_query_legacy_sql (apache_beam.io.gcp.big_query_query_to_table_it_test.BigQueryQueryToTableIT) ... FAIL

Right now my guess is that the postcommit failure is a flake, and I'll try to run it against once I address the review comments.

run python postcommit

Run Python Postcommit

Run Python PostCommit

Let's try to get a green run again.


Added Amaro

#13  😄

Can you please rebase to fix merge conflicts? This should be less of a problem in the future once you get up to date with #242 :/ sorry about it for now!

Would it be better for you if I just close this PR and create a fresh new one? I'd prefer that, rebasing my forked master would be a bit more complicated.


Fixing grafana toolkit and typescript versions

fix: adjust the grafana toolkit version to 8.3.6 and ts to range >=3.3.1 and <4.4.0 according to Brian Gann requirements (via email)

Also, a package-lock.json file was pushed, I believe we are using yarn on this repo. So I think is better to keep just yarn.lock for now.

@alvarowolfx, fixed!


HDFS-16914. Add some logs for updateBlockForPipeline RPC.

https://issues.apache.org/jira/browse/HDFS-16914

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+0 :ok:
detsecrets
0m  2s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
53m 24s

trunk passed

+1 :green_heart:
compile
1m 53s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 39s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
1m 55s

trunk passed

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 53s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 38s

trunk passed

+1 :green_heart:
shadedclient
29m 45s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 23s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 51s

the patch passed

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 14s

the patch passed

+1 :green_heart:
shadedclient
24m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
52m 24s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

185m 23s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRenameWhileOpen

hadoop.hdfs.TestWriteReadStripedFile

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5381

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d4122b1006c2 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b4c21b807fa8761416b2c548a916b2fde4ccab8f

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/1/testReport/

Max. process+thread count
2546 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 18s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 24s

trunk passed

+1 :green_heart:
compile
1m 29s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 33s

trunk passed

+1 :green_heart:
shadedclient
28m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 30s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

the patch passed

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 32s

the patch passed

+1 :green_heart:
shadedclient
28m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
312m 43s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

439m 36s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5381

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4bb9340092b1 4.15.0-197-generic #208-Ubuntu SMP Tue Nov 1 17:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3218e76dac31765950e3d865c4148723e9997d6e

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/2/testReport/

Max. process+thread count
2311 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 26s

trunk passed

+1 :green_heart:
compile
1m 29s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 32s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 31s

trunk passed

+1 :green_heart:
shadedclient
28m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 27s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

the patch passed

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 29s

the patch passed

+1 :green_heart:
shadedclient
28m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
225m 17s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

353m 50s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5381

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 1e505f69f21a 4.15.0-197-generic #208-Ubuntu SMP Tue Nov 1 17:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 01476206ece8c667398a1506dbdc78ef4e7a38dd

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/3/testReport/

Max. process+thread count
2103 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989 @tomscut modify the log content.  add "success" literal.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 10s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 34s

trunk passed

+1 :green_heart:
shadedclient
28m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 28s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

the patch passed

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 31s

the patch passed

+1 :green_heart:
shadedclient
28m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
227m 34s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

354m 51s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5381

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4c42e84abc99 4.15.0-197-generic #208-Ubuntu SMP Tue Nov 1 17:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 26a24245b3bd80b8f4fde78ad252e0a96f2fb865

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/4/testReport/

Max. process+thread count
2122 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5381/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @hfutatzhanghb for your contribution! And Thanks @slfan1989 for your review!


Rice document: Render table notes

They're rendering now; remaining task is to make sure tfoot is created for them, and that any new rows for them have no border.

Need to be numbered consecutively.


If there are multiple source requests inside a single test file they are merged together.

If I have 4 tests, each with their own image sources, then all 4 tests will end up using all the sources, not the source specified for the test.
documentation_tests.zip

Thanks. I'll look into that.

I've located the bug. Working on a solution


perf(semantic): attempt at removing extra condition ast records.

testing a theory, probably won't work!

#4307  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on  Graphite

didn't work as expected