IntelliJ shows already commited files in changelist

What steps will reproduce the problem?
Steps to reproduce the behavior:

Commit in IntelliJ
What is the expected output?
No Changes afterwards
What happens instead?
Intellij shows previously commited files as to be commited in the next commit, but they are the same content/equal/no changes
Environment:

OS: [e.g. Windows 10]

Additional context
I have found that a workaround is to execute in a postcommit hook "git update-index -g". Can you add this?

Please follow the bug issue template.


I wish /docs/user-guide/simple-nginx/ started a rc

I wish /docs/user-guide/simple-nginx/ started a rc

@jflewis the default now with kubectl run is to create a deployment.
That's what the docs show.
Are you ok with the page now ? can we close the ticket ?


Support raw SQL Alchemy

This is an attempt to fix https://github.com/mgood/flask-debugtoolbar/issues/71.
It adds a new argument sqlalchemy_engine to DebugToolbarExtension(app, sqlalchemy_engine=None). If no engine is passed, the old behavior is maintained. If an engine is passed, then the query recording events are installed on that engine and no flask-sqlalchemy db is touched. The event registration still uses flask-sqlalchemy code.
This still requires flask-sqlalchemy to be installed in order to record queries, but it does not require the user to use it to declare models and query for data; raw sqlalchemy engines and tables can be used instead. I added a basic app example that uses plain sql alchemy under basic_app_raw_sqlalchemy.py

What about this request? Does actually this extension is maintained by someone?
Me also highly interested in debug toolbar without flask sqlalchemy.

Sorry, yes I've been rather behind on the maintenance of this project. I'll follow up on the original issue #71 with some thoughts on this.

Would be great to support raw SQLAlchemy. I have a app built on Flask for web and Tornado for IM and push service, and I reused the model layer on raw SQLAlchemy.
Would be nice to hear raw SQLAlchemy support!

any news of this front ?
something needed to be fixed for the review ?

There's a conflict now.

I would like to add support for raw SQLAlchemy here. It's been a while since this was looked at though, so I'm not sure what changes are needed... @dtheodor do you mind rebasing to fix merge conflicts so we get a clean slate for testing/discussing the actual implementation?

For anyone that wants this sort of functionality, a separate python module exists called fdt-sqlalchemy. It has a bug where there is an errant print, which I've removed and documented a workaround for here.

I know it's been a long time, but do you still have any interest in this?
If so, it will need to catch it up with master and retest. If not, we'll probably close it out.
Is it safe to say this one should be superseded by #110 ?


Endpoint configuration for Llama2/Ollama running on runpod

Hi,
I have ollama running on a runpod, basically by following these steps:
https://docs.runpod.io/tutorials/pods/run-ollama
I can connect to the API using curl, e.g.:
curl -X POST https://{POD_ID}-11434.proxy.runpod.net/api/generate -d '{
  "model": "mistral",
  "prompt":"Here is a story about llamas eating grass"
 }'

When I try to generate a title for a document with paperless-gpt's webinterface, I get:
"Failed to generate suggestions."
The logs show:
time="2024-12-10T08:07:30Z" level=info msg="Processing Document ID 2288..."
time="2024-12-10T08:07:30Z" level=debug msg="Title suggestion prompt: I will provide you with the content of a document that has been partially read by OCR (so it may contain errors).\nYour task is to find a suitable document title that I can use as the title in the paperless-ngx program.\nRespond only with the title, without any additional information. The content is likely in English.\nAGAIN: ONLY RESPOND WITH A TITLE, nothing else, no intro.\n\n\nContent:\n[...]\n"
time="2024-12-10T08:07:30Z" level=error msg="Error processing document 2288: error getting response from LLM: invalid character 'p' after top-level value"
time="2024-12-10T08:07:30Z" level=error msg="Error processing documents: Document 2288: error getting response from LLM: invalid character 'p' after top-level value"
[GIN] 2024/12/10 - 08:07:30 | 500 |  401.095454ms |   <IP_ADDRESS> | POST     "/api/generate-suggestions"

I looked into the TCP traffic and I saw that paperless-gpt seems to be using an API endpoint that's not compatible with my setup:
Request:
GET /api/chat HTTP/1.1
Host: <IP_ADDRESS>:60201
User-Agent: langchaingo (amd64 linux) Go/go1.22.10
Accept: application/x-ndjson
Accept-Encoding: gzip, br
Cdn-Loop: cloudflare; loops=1
Cf-Connecting-Ip: <IP_ADDRESS>
Cf-Ipcountry: DE
Cf-Ray: 8efbbdde8d583660-FRA
Cf-Visitor: {"scheme":"https"}
Content-Type: application/json
Referer: http://dl36yl1740hrts-11434.proxy.runpod.net/api/chat
X-Forwarded-For: <IP_ADDRESS>, <IP_ADDRESS>
X-Forwarded-Host: dl36yl1740hrts-11434.proxy.runpod.net
X-Forwarded-Proto: https

Response:
HTTP/1.1 404 Not Found
Content-Type: text/plain
Date: Tue, 10 Dec 2024 08:07:30 GMT
Content-Length: 18

Am I doing something wrong? Can I configure the endpoints?

docker compose is:
  paperless-gpt:
    image: paperless-gpt #icereed/paperless-gpt:latest
    environment:
      PAPERLESS_BASE_URL: 'http://192.168.x.x:8000'
      PAPERLESS_API_TOKEN: '...'
      LLM_PROVIDER: 'ollama' # or 'ollama'
      LLM_MODEL: 'llama2'     # or 'llama2'
      OPENAI_API_KEY: 'your_openai_api_key' # Required if using OpenAI
      LLM_LANGUAGE: 'English' # Optional, default is 'English'
      OLLAMA_HOST: 'http://...-11434.proxy.runpod.net' # If using Ollama
      VISION_LLM_PROVIDER: 'ollama' # Optional (for OCR) - ollama or openai
      VISION_LLM_MODEL: 'minicpm-v' # Optional (for OCR) - minicpm-v, for example for ollama, gpt-4o for openai
      LOG_LEVEL: 'debug' # Optional or 'debug', 'warn', 'error'
    volumes:
      - ./prompts:/app/prompts # Mount the prompts directory
    ports:
      - '8080:8080'
    depends_on:
      - webserver


D3 4.9.1 returns different value for .style(“transform”)

In d3 4.9.1 if I make  call to get transform of element that has style like this:
<g style="transform: translateX(3.84559px);"></g>

Operation:
d3.select(this).style("transform")

Output in d3v4.9.1 :
translateX(3.84559px)

But in d3v4.8.0 it has different output:
matrix(1, 0, 0, 1, 3.84559, 0)

Is there any change in this new version that is causing this issue?
I was having function to find different parameters of transform property, which is now broken:
contents.getTransformation = function (transform) {
    // console.log(transform);
    var g = document.createElementNS("http://www.w3.org/2000/svg", "g");
    g.setAttributeNS(null, "transform", transform);
    var matrix = g.transform.baseVal.consolidate().matrix;
    var a = matrix.a;
    var b = matrix.b;
    var c = matrix.c;
    var d = matrix.d;
    var e = matrix.e;
    var f = matrix.f;
    var scaleX = Math.sqrt(a * a + b * b);
    var scaleY = Math.sqrt(c * c + d * d);
    var skewX = a * c + b * d;
    if (scaleX) {
        a /= scaleX;
        b /= scaleX;
    }
    if (skewX) {
        c -= a * skewX;
        d -= b * skewX;
    }
    if (scaleY) {
        c /= scaleY;
        d /= scaleY;
        skewX /= scaleY;
    }
    if (a * d < b * c) {
        a = -a;
        b = -b;
        skewX = -skewX;
        scaleX = -scaleX;
    }
    return {
        translateX: e,
        translateY: f,
        rotate: Math.atan2(b, a) * Math.PI / 180,
        skewX: Math.atan(skewX) * Math.PI / 180,
        scaleX: scaleX,
        scaleY: scaleY
    };
};

Ref: https://stackoverflow.com/questions/38224875/replacing-d3-transform-in-d3-v4

Please read the RELEASE NOTES. As of d3-selection 1.1.0, selection.style now returns the inline style, if present. (#120)
Your code is unnecessarily complicated because you are copying the value of the transform attribute from one G element (this) to an off-screen G element created by document.createElementNS. Inlining your code a little bit:
var transform = d3.select(this).style("transform");
var g = document.createElementNS("http://www.w3.org/2000/svg", "g");
g.setAttributeNS(null, "transform", transform);
var matrix = g.transform.baseVal.consolidate().matrix;

Instead, just access the transform on the existing G element directly:
var matrix = this.transform.baseVal.consolidate().matrix;

You’ve already posted this to Stack Overflow, but as a reminder: please use Stack Overflow tag d3.js to ask for help. Although I make an effort to assist everyone that asks, I am not always available to provide help promptly or directly. Stack Overflow provides a better collaborative forum for self-help: tens of thousands of D3-related questions have already been asked there, and some answered questions may be relevant to you.
When asking for help, please include a link to a live example that demonstrates the issue, preferably on bl.ocks.org. It is often impossible to debug from code snippets alone. Isolate the issue and reduce your code as much as possible before asking for help. The less code you post, the easier it is for someone to debug, and the more likely you are to get a helpful response.
If you have a question about D3’s behavior and want to discuss it with other users, also consider the d3-js Google Group or joining the d3-js Slack.
Thank you! 🤗

Thanks. Will change my function. :-)


HikariConfig#setDriverClassName ClassLoader precedence is backwards

We provide bundled reference JDBC driver jars for our customers that use open source databases but allow them to upload and use their own version at runtime. We recently discovered that this isn't working as expected and tracked it down to the code in HikariConfig#setDriverClassName():
public void setDriverClassName(String driverClassName)
{
   Class<?> driverClass = null;
   try {
      driverClass = this.getClass().getClassLoader().loadClass(driverClassName);
      LOGGER.debug("Driver class found in the HikariConfig class classloader {}", this.getClass().getClassLoader());
   } catch (ClassNotFoundException e) {
      ClassLoader threadContextClassLoader = Thread.currentThread().getContextClassLoader();
      if (threadContextClassLoader != null && threadContextClassLoader != this.getClass().getClassLoader()) {
         try {
            driverClass = threadContextClassLoader.loadClass(driverClassName);
            LOGGER.debug("Driver class found in Thread context class loader {}", threadContextClassLoader);
         } catch (ClassNotFoundException e1) {
            LOGGER.error("Failed to load class of driverClassName {} in either of HikariConfig class classloader {} or Thread context classloader {}", driverClassName, this.getClass().getClassLoader(), threadContextClassLoader);
         }
      } else {
         LOGGER.error("Failed to load class of driverClassName {} in HikariConfig class classloader {}", driverClassName, this.getClass().getClassLoader());
      }
   }
....

The same code appears in DriverDataSource
     if (driver == null) {
        LOGGER.warn("Registered driver with driverClassName={} was not found, trying direct instantiation.", driverClassName);
        Class<?> driverClass = null;
        try {
           driverClass = this.getClass().getClassLoader().loadClass(driverClassName);
           LOGGER.debug("Driver class found in the HikariConfig class classloader {}", this.getClass().getClassLoader());
        } catch (ClassNotFoundException e) {
           ClassLoader threadContextClassLoader = Thread.currentThread().getContextClassLoader();
           if (threadContextClassLoader != null && threadContextClassLoader != this.getClass().getClassLoader()) {
              try {
                 driverClass = threadContextClassLoader.loadClass(driverClassName);
                 LOGGER.debug("Driver class found in Thread context class loader {}", threadContextClassLoader);
              } catch (ClassNotFoundException e1) {
                 LOGGER.warn("Failed to load class of driverClassName {} in either of HikariConfig class classloader {} or Thread context classloader {}", driverClassName, this.getClass().getClassLoader(), threadContextClassLoader);
              }
           } else {
              LOGGER.warn("Failed to load class of driverClassName {} in HikariConfig class classloader {}", driverClassName, this.getClass().getClassLoader());
           }
        }
     }

The problem is that the reference JDBC jar is in the same classloader as the HikariCP jar - it will always be loaded before the Thread's currentContext classloader is checked. It should be the other way around - the reason for a thread-specific classloader is to allow the developer to have runtime flexibility.
We've identified a potential workaround of creating our own classloader and immediately instantiating the JDBC driver class and registering it with the DriverManager. I don't know if it will work since some of the customer-uploaded drivers are actually multiple jars (e.g., for enhanced authentication or encryption) and we might have issues with assignments between objects loaded from different classloaders,
This isn't an abstract concern - we've been burned by it. We might have an assignment between "identical" objects but one object was loaded via reference from an object loaded from classlooader A and the second object loaded via reference from a class loaded classloader B. Identical classes, literally the same physical file, but classes loaded via different classloaders are not assignable. The "solution" is to ensure you have the jar visible to a single classloader but it's not always possible.
There are a few other places where classloader assumptions are made but it's not clear what the impact would be. E.g., ConcurrentBag
private boolean useWeakThreadLocals()
{
   try {
      if (System.getProperty("com.zaxxer.hikari.useWeakReferences") != null) {   // undocumented manual override of WeakReference behavior
         return Boolean.getBoolean("com.zaxxer.hikari.useWeakReferences");
      }

      return getClass().getClassLoader() != ClassLoader.getSystemClassLoader();
   }
   catch (SecurityException se) {
      return true;
   }
}

Bear
Environment
HikariCP version: 2.7.2-SNAPSHOT and before
JDK version     : 1.8.0_111
Database        : All
Driver version  : x.x.x

All perfectly reasonable.  The thread context classloader change was a contributed enhancement; I agree that the context classloader should be tried first.
The other classloader usage, in ConcurrentBag, is there to determine whether HikariCP itself in running in application container (Tomcat, JBoss, etc).  If HikariCP believes it is running in an environment where in situ restart/redeploy is possible, it will use WeakReferences in ThreadLocals to avoid memory leaks.  That determination is fairly simplistic; if HikariCP's classloader is the Java root classloader, it behaves as if in a standalone application (no WeakReferences). Anyway, unrelated to the above issue.

@beargiles HikariCP v2.7.2 containing this fix has been released.


dart/transferable_throws_test is skipped on asan bot due to oom handling

Refactor or fix the test to maximize things that can be run on asan bot.

the test is passing, has been for awhile it seems


Fixed #24576 -- Deletion of related objects made deterministic

Do you it would be possible to reused or adapt the delete.tests.DeletionTests.test_deletion_order method instead of creating a new testing application?

@charettes Adjusted delete.tests.DeletionTests.test_deletion_order

Buildbot, add to whitelist.

merged in 7862cbda86cdbced5fbfe4f0056105e657c1f92c, thanks!


docs: fix import in the example code: ContextRelevance -> ContextRelevancy

Description

Fixed an incorrect import statement in the context relevancy example code within the documentation.
Ensured the file ends with a newline character.

Changes walkthrough
Relevant filesDocumentation

context_relevancy.mdFix Incorrect Import in Context Relevancy Documentation

docs/concepts/metrics/context_relevancy.md
Corrected the import statement from ContextRelevance to ContextRelevancy.  Added a newline at the end of the file.

+3/-3

💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

/codeantai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

thank you so much @izikeros 🙂


Updated the code with some text information

Added a file for Git instructions

I hope this thing works... Am not sure of the state of this text.


Fix unreliable change events

related to: https://github.com/rancher/dashboard/issues/1368

related to: https://github.com/rancher/rancher/issues/29183


Project link not opening

Great work. The link to view the project at https://menshut.pythonanywhere.com is not working. Can you look into this please.

Its working fine for me. Check in some other browser maybe.... I also host at pythonanywhere and maybe at some times they're down for maintenance.

It's working for me


Is it possible to see chinese characters in pdf or png?

I am trying to prepare pdf or png label from zpl code. I want to be able to use chinese characters in label. I prepared zpl code to make this. I am able to see characters on labelary. But I cannot see on https://binarykits-zpl-viewer.azurewebsites.net/.

I also cannot see these characters using the BinaryKits.Zpl.Viewer in the code.
I will not use any printer, I just want to get correct pdf or png. This is my code to get this.
            var zpl = @$"^XA
                        ^CI28
                        ^FX First section with bar code.
                        ^BY4,2,150
                        ^FO60,140^BCN,150,N^FDUM2408100000^FS
                        ^FX Second section with address
                        ^CF0,40
                        ^FO50,300^FDDelivery Address^FS
                        ^CFJ,30
                        ^FO50,350^FD中国, 山东省, 青岛市^FS
                        ^CFJ,30
                        ^FO50,400^FD香港东路6号, 5号楼, 8号^FS
                        ^XZ";

            var drawOptions = new DrawerOptions()
            {
                PdfOutput = true
            };
            IPrinterStorage printerStorage = new PrinterStorage();
            var drawer = new ZplElementDrawer(printerStorage, drawOptions);

            var analyzer = new ZplAnalyzer(printerStorage);
            var analyzeInfo = analyzer.Analyze(zpl);

            foreach (var labelInfo in analyzeInfo.LabelInfos)
            {
                var imageData = drawer.DrawPdf(labelInfo.ZplElements, 100, 100, 8);
                File.WriteAllBytes("label.pdf", imageData);
            }

Here is the output for this code.
label.pdf

pls refer code as flowing
      private static DrawerOptions BuildDrawOption(string fontName = "NotoSansSC-SemiBold")       {           var fontFile = Path.Combine(AppContext.BaseDirectory, "fonts", $"{fontName}.ttf");           var drawOptions = new DrawerOptions           {               FontLoader = fontName => { return SKTypeface.FromFile(fontFile); },               OpaqueBackground = false,               PdfOutput = false,               RenderFormat = SKEncodedImageFormat.Png,               RenderQuality = 100,               Antialias = true,               ReplaceDashWithEnDash = false           };           return drawOptions;       }


Proc Macro For Sealed Traits

It would be nice if there was a proc-macro crate to automatically seal a trait, but I do not yet know of such a library.  I think the boilerplate reduction would be worth creating one.

Looking through top 32 pages of Rust patterns crates, found

https://crates.io/crates/sealed

Will check later for requirements

Ended up making my own traitful crate to handle this


docker gitpitch/desktop:pro hangs on local repo directory

Hi
It seems the docker container startup is hanging when I point to my local GitHub repo directory.
(base) USC02ZX15JMD6R:gitpitch-docker<EMAIL_ADDRESS>docker-compose up
Recreating gitpitch-docker_gitpitch_1 ... done
Attaching to gitpitch-docker_gitpitch_1
gitpitch_1  | 2020-03-10 18:59:10,855 [info] c.g.s.DesktopService - GitPitch Desktop Pro Edition started.

[hangs here]

If I point to a project inside the repo directory with a PITCHME.md then it starts up and finishes the file sweep, but of course doesn't show any other repos with PITCHME.md files.
(base) USC02ZX15JMD6R:gitpitch-docker<EMAIL_ADDRESS>docker-compose up
Recreating gitpitch-docker_gitpitch_1 ... done
Attaching to gitpitch-docker_gitpitch_1
gitpitch_1  | 2020-03-10 19:11:51,012 [info] c.g.s.DesktopService - GitPitch Desktop Pro Edition started.
gitpitch_1  | 2020-03-10 19:11:51,225 [info] c.g.s.RefreshService - SWEEP directory watcher detected 65 files in 170 ms.
gitpitch_1  | 2020-03-10 19:11:51,227 [info] c.g.s.RefreshService - SWEEP directory watcher using default interval 250 ms.
gitpitch_1  | 2020-03-10 19:11:51,903 [info] play.api.Play - Application started (Prod)
gitpitch_1  | 2020-03-10 19:11:52,094 [info] p.c.s.NettyServer - Listening for HTTP on /<IP_ADDRESS>:9000

here is the docker-compose file
services:
  gitpitch:
    image: gitpitch/desktop:pro
    volumes:
      - /Users/Michael.Moore4@ey.com/Documents/GitHub:/repo
    ports:
      - "9000:9000"
    environment:
      - PORT=9000

is this the expected behavior?

Hi Michael. The docker-compose file that you shared attempts to mount the following directory on your host machine:
<EMAIL_ADDRESS>What is in that directory?
If it is a self-contained repo directory I would expect the Desktop to launch without any problem.
If it is a directory that contains anything else - such as sub-directories where each sub-directory is a self-contained repo then I would expect the launch to fail.
More generally, the directory you mount when launching the Desktop should be the base directory of a single, local Git repository. The Desktop then executes within the context of that single repo until you shut it down.
Until I know exactly what's in your Documents/GitHub directory I can't answer your question definitively. But if I had to guess you are attempting to mount a directory that itself is not a self-contained repository. And that is why you are seeing the failure that you have reported.

yes - it's a collection of repos, cloned from GitHub.
Thanks for clarifying that it is looking for a single repository.


change design of the feedback form to align with the website (Issue #1248)

Issue:#1248

[x] I have added screenshots and videos to show before and after the working of my code.
[x] I have ensured that the screen size is set to 100% while making the video.
[x] I have synced the latest fork with my local repository and resolved any conflicts.
[x] I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
[x] I understand that if any the above conditions are not met , my PR will not be MERGED .

the font is different , kindly check

closing PR due to no response


[mysql-cdc] Add upsert changelog mode to avoid UPDATE_BEFORE records push down

Is your feature request related to a problem? Please describe.
I try to use flink sql to write mysql cdc-data into redis as a dimension table for other business use. When executing UPDATE DML, the cdc-data will be converted into -D (UPDATE_BEFORE) and +I (UPDATE_AFTER)  two records to sink redis. However, delete first will cause other data streams to be lost(NULL) when join data, which is unacceptable.
Describe the solution you'd like
I think we can add support for upsert changelog mode by adding changelogMode option with mandatory primary key configuration.Basically, with changelogMode=upsert we will avoid UPDATE_BEFORE rows and we will require a primary key for the table.
Describe alternatives you've considered
n/a

Hi @leonardBang, I am happy to send a PR for this if you agree this makes sense.

Postgresql connector's changelog mode can be configurated through Flink SQL API while MySQL connector's cannot.
I hope @yeezychao proposed PR would be reviewed & merged soon. @leonardBang

Closing this issue as it has been migrated to Apache Jira.

FLINK-35313


macOS MIDI: memory leak when freeing song

This bug report was migrated from our old Bugzilla tracker.
Reported in version: 2.0.4
Reported for operating system, platform: macOS 10.13, x86_64
Comments on the original bug report:
On 2019-03-30 14:11:03 +0000, ioanch wrote:

I've discovered a memory leak when using MIDI music on macOS (I'm on Mojave).
When freeing a song, DisposeMusicSequence returns error "kAudioToolboxErr_CannotDoInCurrentContext" (-10863, https://www.osstatus.com/search/results?platform=all&framework=all&search=-10863 ), unless you call "MusicPlayerSetSequence(song->player, NULL);" before it.
See my fix I did on my fork of SDL2_mixer here: https://bitbucket.org/ichera/sdl_mixer/commits/713acbd976efd31c441e37906d76b7fa790572dd?at=macos-music-leak-fix

On 2019-04-04 09:39:04 +0000, Ozkan Sezer wrote:

Ryan, is this patch correct?

On 2019-07-03 08:32:13 +0000, Ozkan Sezer wrote:

Ryan:  Should we apply this?

On 2019-07-03 09:32:16 +0000, Sam Lantinga wrote:

Patch added, thanks!
https://hg.libsdl.org/SDL_mixer/rev/1c557e8ac98f

A segmentation fault was reported to me with this patch on El Capitan in
the SDL-1.2 branch. @ioan-chera, @slouken, @icculus: Can anyone reproduce?
Can anyone reproduce with main SDL2 branch?
El Cap 10.11.6
Xcode Version 8.1 (8B62)

$gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 8.0.0 (clang-8<IP_ADDRESS>)
Target: x86_64-apple-darwin15.6.0

Playing /Users/admin/new/ABBA_-_Dancing_Queen.mid
Segmentation fault: 11 (core dumped)

$lldb --core /cores/core.53424
(lldb) target create --core "/cores/core.53424"
warning: (x86_64) /cores/core.53424 load command 111 LC_SEGMENT_64 has a fileoff + filesize (0x28ff2000) that extends beyond the end of the file (0x28ff1000), the segment will be truncated to match
warning: (x86_64) /cores/core.53424 load command 112 LC_SEGMENT_64 has a fileoff (0x28ff2000) that extends beyond the end of the file (0x28ff1000), ignoring this section
Core file '/cores/core.53424' (x86_64) was loaded.
(lldb) bt
* thread #1: tid = 0x0000, 0x00007fff93bc98ea libsystem_kernel.dylib`__kill + 10, stop reason = signal SIGSTOP
  * frame #0: 0x00007fff93bc98ea libsystem_kernel.dylib`__kill + 10
    frame #1: 0x00007fff926f852a libsystem_platform.dylib`_sigtramp + 26
    frame #2: 0x00007fff8d6de84a AudioToolbox`Sequence::LazyCreateDefaultGraph() + 10
    frame #3: 0x00007fff8d6e0d3c AudioToolbox`SequencePlayer::CleanupPlayState() + 32
    frame #4: 0x00007fff8d6e0a82 AudioToolbox`SequencePlayer::~SequencePlayer() + 40
    frame #5: 0x00007fff8d6e0dec AudioToolbox`SequencePlayer::~SequencePlayer() + 14
    frame #6: 0x00007fff8d6daeb9 AudioToolbox`DisposeMusicPlayer + 27
    frame #7: 0x00000001052321f5 libSDL_mixer-1.2.0.dylib`native_midi_freesong(song=0x00007fe183d2f480) + 69 at native_midi_macosx.c:261 [opt]
    frame #8: 0x0000000105230e58 libSDL_mixer-1.2.0.dylib`Mix_FreeMusic(music=<unavailable>) + 168 at music.c:789 [opt]
    frame #9: 0x000000010519cb2c playmus`main(argc=<unavailable>, argv=<unavailable>) + 1020 at playmus.c:233 [opt]
    frame #10: 0x00007fff96f6f5ad libdyld.dylib`start + 1
    frame #11: 0x00007fff96f6f5ad libdyld.dylib`start + 1

PING for https://github.com/libsdl-org/SDL_mixer/issues/258#issuecomment-931260899 ?

Cherry-picked the fix to SDL-1.2 branch as https://github.com/libsdl-org/SDL_mixer/commit/3bc1b796e53a45a8df944a8dcf7ccb6a48a7681a


Fix legacy version

Trying this here, because it looks like the Github Actions weren't firing properly on #501. Maybe because it was a cross-repo PR?

No idea what happened there, but starting this PR kicked the other one into working. Weird.


Migrate to Go 1.16.2

I shall try to operate from the shell (not via Github's UI). Give me some time

Please also use "go edit" to update go.mod to the same version

Hm, I got this:

$ go edit
go edit: unknown command
Run 'go help' for usage.

I am using

$ go version
go version go1.16.2 windows/amd64

Please also use "go edit" to update go.mod to the same version

Hm, I got this:

$ go edit
go edit: unknown command
Run 'go help' for usage.

I am using

$ go version
go version go1.16.2 windows/amd64

Sorry, as the README says it is
go mod edit


Flutter crashes on Android on FlutterMain.startInitialization ( appCtx )

It looks likeinside FlutterMain.listLibs
File[] files = (new File(applicationInfo.nativeLibraryDir)).listFiles();
sometimes returns null, thus a NullPointerException on the next line for
files.length
Android 9 / Pixel 2XL

That code was just removed on the master branch:
https://github.com/flutter/engine/commit/4d6847466d0b8223f2d3ba9572e397306b6debf4


cargo -Zscript uses invalid package names when the file name starts with a digit

Problem
When the file name starts with a digit, e.g. 0.rs, cargo -Zscript 0.rs defaults the package name to -0 and fails
Steps
echo 'fn main() {}' > 0.rs
cargo -Zscript 0.rs

warning: `package.edition` is unspecifiead, defaulting to `2021`
error: failed to parse manifest at `<...>/0.rs`

Caused by:
  invalid character `-` in package name: `-0`, the first character must be a Unicode XID start character (most letters or `_`)

Possible Solution(s)
When the first character of the file name is invalid, insert _ instead of -, which makes the package name valid. So for 0.rs, the package name would default to _0. This is #12329's approach
Notes
Related: #12207, https://github.com/rust-lang/cargo/pull/12329#issuecomment-1620857167
Version
cargo 1.72.0-nightly (5b377cece 2023-06-30)
release: 1.72.0-nightly
commit-hash: 5b377cece0e0dd0af686cf53ce4637d5d85c2a10
commit-date: 2023-06-30
host: x86_64-unknown-linux-gnu
libgit2: 1.6.4 (sys:0.17.2 vendored)
libcurl: 8.1.2-DEV (sys:0.4.63+curl-8.1.2 vendored ssl:OpenSSL/1.1.1u)
ssl: OpenSSL 1.1.1u  30 May 2023
os: NixOS 23.11.0 [64-bit]

I'm curious, was 0.rs the scenario you ran into this or something else?
My primary concern with unilaterally applying _ is if the file name is one where we'd also apply - elsewhere as mixing _ and - looks a bit odd, see b116864d7963a19c3dcea1131a13a966a0c1e839 from #12255.
The question is whether there is a viable alternative.
Purely for brainstorming purposes

We add an arbitrary letter
We strop the leading invalid digit.  If nothing is left, we

Use an arbitrary letter
Try turning the invalid item into a word (best effort)

We go ahead and error unlike all of the other sanitation effort to avoid errors.
We instead always validate instead of sanitize

I'm curious, was 0.rs the scenario you ran into this or something else?

Yes. I set up my editor (neovim) to create temporary files using vim.fn.tempname(), which returns non-negative integers, and makes the temporary file names start with a digit.

We add an arbitrary word

Out of the ideas you listed, this is the best option in my opinion (tied with my initial approach)

We instead always validate instead of sanitize

I'm not sure what this means, does it mean that cargo -Zscript 0.rs will fail due to 0 being an invalid package name (instead of -0)?

We can also unconditional add an arbitrary word, so both 0.rs and foo.rs would become e.g. script-0 and script-foo

Yes. I set up my editor (neovim) to create temporary files using vim.fn.tempname(), which returns non-negative integers, and makes the temporary file names start with a digit.

So not necessarily 0.rs but 980980809.rs?

We instead always validate instead of sanitize

I'm not sure what this means, does it mean that cargo -Zscript 0.rs will fail due to 0 being an invalid package name (instead of -0)?

Yes

We can also unconditionally add an arbitrary word, so both 0.rs and foo.rs would become e.g. script-0 and script-foo

For users with files with more meaningful names, this would be a regression in user messages
For users wanting to build binaries or publish packages from their script, this would be a blocker
We are looking to allow these packages as workspace members, so cargo test -p <name> should work rather than cargo test -p script-<name>

Most likely we'd also make the prefix be "package".  "script" is unlikely to be in any of the official naming as this isn't really a script though it behaves somewhat like people are used to using scripts.

So not necessarily 0.rs but 980980809.rs?

Yes

I suggest we go with #12329 for now, considering that it is a partial revert of #12255 which caused a regression

The behavior pre-#12255 was fairly arbitrary so reverting some of it isn't going to any better state but going to some state.  Seeing as this is an unstable feature and this isn't the biggest of concerns for resolving for stabilization, I don't think we need to rush a specific answer but lets figure out a proposal of what it should be and document it so we reduce the number of caveats, rather than just transferring this caveat into a different one.
At the moment, I lean towards stripping invalid package-name start chars until we find a valid one.  If we don't find any valid ones, we substitute in package.


os/signal: code example for Notify tries to catch os.Kill which doesn't work

In the code example for os/signal/#Notify,
signal.Notify(c, os.Interrupt, os.Kill)

tries to catch os.Kill signal, which doesn't work on Linux platforms.
Steps to reproduce:
Code is taken from the doc.
$ cat kill.go
package main

import (
        "fmt"
        "os"
        "os/signal"
)

func main() {
        c := make(chan os.Signal, 1)
        signal.Notify(c, os.Interrupt, os.Kill)
        s := <-c
        fmt.Println("Got signal ", s)
}

$ go build kill.go
$ ./kill &
[1] 10300
$ kill -KILL $!
$
[1]+  Killed                  ./kill

Ctrl-C / -s SIGINT works fine but SIGKILL is not caught.

SIGKILL	9   Kill(can't be caught or ignored) (POSIX), the SIGKILL like can't be caught.

@wolf0403 @Yooke would either of you like to send a pull request to fix the example?
https://golang.org/doc/contribute.html


[Feature]: Add BrowserType.ConnectOverCDP(endpointURL[, options]) for .NET

Feature request
Add BrowserType.ConnectOverCDP(endpointURL[, options]) for .NET like other versions have

Closing as duplicate of #1291.


Comma-delimited format validation

Only modifies the existing process slightly, but, the gist:

assumes that it's JSON
if it's not, validate the format against format as specified in de-facto standard
Send an error message if it's not, explain it couldn't be parsed

@rkamudhan in the spec doc as it stands, the proposal I gave was based on the DNS1123 label format, matching what kube uses for validating namespaces, with the addition of / & @ (@ mentioned only in the addendum/appendix, I think) allowed to separate "units" of those labels. I changed the examples that were out of date with upper case to have the lowercase.

Latest push takes into account:

Allowing spaces between elements separated by commas (thanks Tomo)
Validates the DNS1123 label format for each element as separated by comma, slash & @ by moving the validation logic into the parsePodNetworkObjectName() and leveraging work done there

Previous commit would've allowed some bad formatting like foo@@@bar//quux

Does not yet allow upper/lower case, added item to spec for discussion there.

Looks good to me, Doug.
Thank you for your incorporation!


Figure out sources of bloat (e.g do lots of modules add a bunch of boilerplate?)
Consider trying other minifiers, e.g closure
Compare gzipped sizes

Also see #129

Consider removing non-shim implementations in util.js

Consider splitting up util.js to only keep functions store-engine.js depends on (for a minimal build)

consider not using util.js in store-engine.js

Consider splitting out plugin code into its own file, and not importing it in store.minimal.js

Allow uglifyjs to mangle property names (store.js v1 did much of this manually by using almost exclusively locally scoped variables instead of objects)
Create a minimal build which doesn't depend on the browserify require module runtime, but uses minimal file concatenation of store-engine.js and a minimal-build.js.

You could use rollup, since that can heavily improve the size of a bundle with treeshaking + putting everything in the same scope.

@PaulBGD 👍👍 wasn't aware of rollup! Will check it out - thanks!


The layout of https://olm.operatorframework.io/docs/ is broken

Bug Report
What did you do?
Check https://olm.operatorframework.io/docs/
What did you expect to see?
The lateral menu
What did you see instead? Under which circumstances?

Environment

operator-lifecycle-manager version:

Kubernetes version information:

Kubernetes cluster kind:

Possible Solution

Additional context
Add any other context about the problem here.

@camilamacedo86 can you provide the OS/browser you are seeing this in?

@camilamacedo86 can you provide the OS/browser you are seeing this in?

@matthewcarleton I'm seeing this on fedora 33/chrome
Note that this issue is not there when the browser is extended and takes up the full screen. It only happens when the size of the browser starts to get reduced.
I've heard similar feedback from users on mac os/chrome too.

@matthewcarleton I'm seeing this on fedora 33/chrome
Note that this issue is not there when the browser is extended and takes up the full screen. It only happens when the size of the browser starts to get reduced.
I've heard similar feedback from users on mac os/chrome too.

It can also be reproduced by zooming in on the page.
Things seem fine till the page in my browser is zoomed in till 125%. As soon as I go to 150% this starts happening.

It can also be reproduced by zooming in on the page.
Things seem fine till the page in my browser is zoomed in till 125%. As soon as I go to 150% this starts happening.

Hi folks,
I use chrome in a mac. WDYT about we push the layout config from https://github.com/operator-framework/operator-sdk/tree/master/website to the olm-docs? I think it would solve this problem and others as ensure that all have the same appearance.

Hi folks,
I use chrome in a mac. WDYT about we push the layout config from https://github.com/operator-framework/operator-sdk/tree/master/website to the olm-docs? I think it would solve this problem and others as ensure that all have the same appearance.

I'm all for both the sites looking the same. We might wanna be a little careful in adding whatever's there in https://github.com/operator-framework/operator-sdk/tree/master/website though since some of the decisions made for the sdk doc site were different than the olm site. The one to concern ourselves with here is that sdk decided not to expand the menu on the left nav panel, whereas olm decided to expand it, which is why we see the scroll bar. And it's the scroll bar that's causing the problem here as far as I can tell.

I'm all for both the sites looking the same. We might wanna be a little careful in adding whatever's there in https://github.com/operator-framework/operator-sdk/tree/master/website though since some of the decisions made for the sdk doc site were different than the olm site. The one to concern ourselves with here is that sdk decided not to expand the menu on the left nav panel, whereas olm decided to expand it, which is why we see the scroll bar. And it's the scroll bar that's causing the problem here as far as I can tell.

/close
fixed by https://github.com/operator-framework/olm-docs/pull/92

/close
fixed by https://github.com/operator-framework/olm-docs/pull/92


2px border in input group.

Just look this code: http://jsfiddle.net/8fhoc4bL/
If I put input group addon and it is not last or first, 2px border becomes between input and this addon.

Hi @inferusvv!
You appear to have posted a live example (http://fiddle.jshell.net/8fhoc4bL/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 44, column 25: E015: Having multiple add-ons on a single side of an input group is not supported

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Closing as invalid since, as the bot says, we don't support that.


Fix bug for supporting nodeselector

The nodeselector doesn't work.I review the project code and I found there is something wrong with the following code.

/assign

/cc @dtantsur

/triage accepted
/kind bug


[PE-D][Tester D] Edit command does not show the Date of Birth tag in command result message

After using the edit command, the result message does not have the "Date of Birth:" preceding the Date of Birth. Only the date is shown in the result message.

Labels: severity.Low type.FeatureFlaw
original: thaddeusong/ped#6

Minor issue, remember to include DoB


[Costmetic][Chart List View]: Viz type filter should use friendly names

Screenshot

Description
The vis type should display as user-friendly chart type names (same as viz type select when creating a chart), instead of the internal registration key.
Design input
Not needed

Any pointers on how to get those names? These values are coming from the chart registry

We should also probably change the column display to match too


Tunnelbroker (Network) : Is unreachable

Trying to make ip-rotation due too many requests and constant ratelimits by youtube, following https://blog.arbjerg.dev/2020/3/tunnelbroker-with-lavalink, all good until i reach the ping6 google.com step, which return Connection : network is unreachable
Totally sure i've followed and done right each step before.

if you see this I am in the discord as I own the vps, so i'd go there if I were you


Consider using whatever_list.gather() instead of whatever_list[0], whatever_list[1] in interview order code block

Currently, our model is to generate code like this:
code: |
  str(plaintiffs[0])
  str(plaintiffs[1])

Is there a reason for us not to use plaintiffs.gather()?

See #69. I totally agree this is the way to go. The reason for the existing design is because the variable names do two different things: they trigger list gathering, and they get inserted into the template block for a PDF. Using .gather() will be much clearer but we still need to use the plaintiffs[0] method in the attachment block at times, so it will require a bigger refactoring.

See #69. I totally agree this is the way to go. The reason for the existing design is because the variable names do two different things: they trigger list gathering, and they get inserted into the template block for a PDF. Using .gather() will be much clearer but we still need to use the plaintiffs[0] method in the attachment block at times, so it will require a bigger refactoring.

#143 fixed this. Guess github's auto-close doesn't handle commas, lol.


infrastructure is not an optional parameter

Contrary to what the documentation claims, infrastructure is not an optional parameter.

Please share more detailed info related to which CLI command.

The infrastructure parameter is in the section for parameter which are optional, it needs to be removed from this section on the page and placed with the parameters which are mandatory, i.e. those parameter you must specify in order for the controller to be created successfully.

@chrisadkin - the --infrastructure parameter is a tricky one.  The default is auto which will attempt to determine the infrastructure automatically by looking at the current context Kubernetes node annotations.  If it can automatically determine it then it is not required as a user input.  If it cannot be automatically determined and the user didn't provide it, then the CLI will prompt for it.

With the latest Azure CLI updated yesterday, the Arc SQL MI instance failed
to deploy, the CLI stated that the infrastructure parameter needed to be
provided and then exited.
On Thu, 19 Aug 2021 at 05:13, Travis Wright @.***>
wrote:

@chrisadkin https://github.com/chrisadkin - the --infrastructure
parameter is a tricky one. The default is auto which will attempt to
determine the infrastructure automatically by looking at the current
context Kubernetes node annotations. If it can automatically determine it
then it is not required as a user input. If it cannot be automatically
determined and the user didn't provide it, then the CLI will prompt for
it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-cli/issues/19261#issuecomment-901595093,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADTRYC7ZSFBMXCKDGFAMRMDT5SAFXANCNFSM5CMB4LVQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

@chrisadkin  - --infrastructure isn't a parameter to az sql mi-arc create so that seems unlikely.  Do you mean that the data controller create failed?  If so, that's by design if you are running on an infrastructure where the infrastructure [aws, azure, gcp, ..] cannot be automatically detected.  If you are running the az arcdata dc create command in interactive mode and  you don't provide the parameter value and it cannot be automatically detected then you will be prompted for it.  If  you are running it in a script/non-interactive mode then if it cant be automatically detected then the script will exit and output that you need to provide the --infrastructure parameter value.
If this really is happening on az sql mi-arc create, please let me know.  Otherwise it seems that this is by design and should be closed.


Add codecov github action

update logo

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f1663aa). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage        ?   95.88%
=======================================
  Files           ?       22
  Lines           ?      681
  Branches        ?        0
=======================================
  Hits            ?      653
  Misses          ?       28
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1663aa...ceb80df. Read the comment docs.


Test report for RC3

I have pushed RC3 here :
https://github.com/KipK/openevse-gui-v2/releases/tag/1.0.0-rc3
There's a binary build for openevse_wifi_v1 module that can be installed safely.
@fhteagle, @jeremypoulter If you can give a look.

So I had not been active with testing as my unit was completely non-functional on wifi. Seemed to be a problem with 4.1.5, but I finally got a chance to be stubborn and power cycle it a few dozen times, so I could get 4.1.7 loaded onto it. We'll see if it behaves from here on out, wish me luck. Testing things now...
Typo on Configuration tab: "Developer" instead of "Developper".

@fhteagle, there's now daily builds with new ui here: https://github.com/OpenEVSE/ESP32_WiFi_V4.x/releases/tag/v2_gui?fbclid=IwAR1Ty7Wr735bHMQkGC1wAZp0_K4FcNVNFThaVxQ9_hIbti59UYKUKpWAVb8
Do not put 4.1.7 it has a bug with MQTT making wifi drops and more.
Use daily builds instead for now

@fhteagle , I have fixed the time setting issue, if you can test that now everything is workoing ok for you

At release:
https://github.com/OpenEVSE/ESP32_WiFi_V4.x/commit/d98e8b7d4d6c8d6b595657b24e12a247801aecbf
Agreed that your nightly is more stable than the official 4.1.7 . Wifi is working way better than it has since about 4.1.3 or so. Any chance we can get the version incremented in the UI so we can see we are not on "stock" 4.1.7 anymore? A version string like 4.1.7-rc3-d98eb7d4 would help to assure the user that their uploaded nightly build firmware did in fact get applied.
Visual glitch: on Vivaldi on Android, the top part of the status bar is cutoff. The two icons at the top left for charge status and vehicle connection status, the OpenEVSE logo, and the time block at the upper right all cannot be seen. Firefox Focus, stock Chrome browser on Android display as expected.
On Opera on Android, the "Connection Error" banner shows all the time, even when tabs load with correct data.
On the history tab, I cannot see a way to read the content of an Error event line. For example, I had a false "No Ground" detection a few days ago. I see the red caution triangle with ! icon, but no way to see that that line is a No Ground event.
I did test time setting. Manual seems to work reliably, but the time jumps to UTC when the Manual option is first selected. Local time option works reliably for me. Setting UTC time zone when NTP is selected does technically work, but feels a bit of a hack to me. It works, just could be a bit more slick. If time zone is not going to be retained, maybe ask the user the correct timezone immediately, or focus and highlight the timezone entry box?
I will keep exploring the UI and see if I can find anymore issues. Thanks.

Can you try the latest daily build for V2 ?
I think some of your comments are already fixed.
I have tested on Vivaldi and have no such problem

Vivaldi above, and opera here :

Also you'll notice there's UX difference between some forms. I have started to rework them, like HTTP ,MQTT m, Time and RFID. They will all be done the same way without save button ( but only if really necessary )

Updated to the nightly build from 5 hours ago.
Tooltips on icons in history works, merci beaucoup. However, I just noticed that the date/time column of history appears truncated:

Using OEM Android 12 on OnePlus 7T:
Still seeing the truncated status block in Vivaldi 5.6.

Same with the connection error banner on Opera 72.5.3767.69342.

I can start checking other phones if we need to track these display bugs down further.
On MQTT settings, the "Show" tickbox does not reveal the password.

Also, on the history tab, rightmost column, can we get the Temp to be a consistent precision? I really do not care if it is an integer only (17) or one decimal place (17.2), but having them all the same precision makes the column look cleaner.

Thanks  @fhteagle , I think I've covered all your issue but the Opera websocket disconnection error I can't reproduce.
If you can catch up something on developper console log ...

I tested again on an S9 with Android 10. Could not reproduce either the Vivaldi or Opera bugs on that phone. So both UI display glitches may be a one off issue with my OnePlus 7T.
I have a friend who sends me all kinds of current events and political stuff, some of it useful alternative news, but some of it is straight up crazy conspiracy theory stuff. I use Opera Privacy Tabs to load the links from him, so it does not get associated with my usual digital footprint lol. Just thought I would try the GUIv2 out there as well (not in a privacy tab of course), just for testing purposes. Agreed that is not a high market share browser and probably not worth spending too much time worrying about.

Hey
I have made a dirty hack to handle the OpenEVSE time bug can you try latest build?
I reset the TZ to UTC to manual and save the previous tz setting on browser local storage .
It restores it when ntp is selected .
There's still some glitches appearing on time displayed at save but it corrects itself fast as it refetch /status just after and overwrite the first time event.
I'll remove that when @jeremypoulter solve it on api

Dirty hack seems to operate as expected from every browser I checked. Agreed that the first status block update with the completely random time is odd, possibly confusing for the user. Is there a way to mask the first wrong time refresh and keep it from displaying? Perhaps replace with "Updating time...."?

I could make the websocket ignore time property for the first receive time update. But that's a really dirty hack 😁

After GUI-triggered restart of EVSE and Wifi board, time gets stuck at UTC until I do a manual change of time and back to NTP. Probably a result of the "dirty hack". Not sure it is worth fixing, though, maybe just wait for the API to get fixed properly....

Other really really really minor thing, I am testing Homeassistant controlling the OpenEVSE through an integration that uses primarily HTTP API. When the "max amps" is selected in HomeAssistant, sometimes the GUI does not update the max amps on the main charging tab, even after a few of the 30 second update ticks have gone by. If it does update, I get an extra zero in the front of single digit amp values.
Note to self: do more digging to see if the integration is updating the wrong soft vs hard max amps variable..........

I wonder why the max_current value is modifiable through HA. This is a one time setup. Shouldn't they adjust charge_current instead?

Home assistant should probably expose both as you could use it to implement many use cases, however the charge_current should be the main one that shows up by default, the max current should probably be hidden by default.

If HA use max_current_soft from /config, it then should display in the UI slider max pos as it should download automatically the new /config if there's a change.

This is what I was trying to confirm about in this issue over there:
https://github.com/firstof9/openevse/issues/120

Retested GUIv2 release from 3 hours ago, the following bug remains:
On MQTT settings, the "Show" tickbox does not reveal the password.

it's normal, it only reveal while you have typed it yourself. The api doesn't send the password so it stays hidden

Okay, suggestions to handle that behavior more elegantly:
a. hide the Show tickbox if there is nothing to show yet, and/or
b. instead of "password dots", fill the password textbox with  placeholder instead
I think both of these would more clearly communicate that the GUI does not know what the password is, so do not expect to be able to show it...
Just grabbed the latest nightly build, planning on going through everything I can test on my setup very thoroughly today.

Thanks for the input.  I consider hiding the tickbox yes, it's on my list.
I have fixed some other stuff so be sure to get the latest build before testing :)

For the v1 UI we show nothing when the show password is selected on an existing password. We do this because it is likely that the user wants to enter a new password

I have considered that,but then we don't know a password has been set before.
the change with no checkbox is on latest builds

I am not seeing any other showstopper bugs in GUI v2 after a couple of weeks of pretty thorough testing on the nightlies, trying to break things, etc. Great work @KipK on this.

I've been pulling each new build as it shows up here: https://github.com/OpenEVSE/ESP32_WiFi_V4.x/releases/tag/v2_gui
Or is there a different branch that needs more testing?

No it is this one. Have you tested the new Limit engine?

Just noticed the new limit box on the main tab. I will try it out and report back.

Hold one, I've just test the generated fw on githb and it's not the good version, UI is ok but not the latest fw. I tell you when it's ok

my PR was merged yesterday ( https://github.com/OpenEVSE/ESP32_WiFi_V4.x/pull/535 ), I've pushed the Limit branch on UI too, but the UI_V2 branch of wifi fw has not been updated yet. So it generated a build with the Limit UI but without the feature on fw :)
Should be fixed in a few

Nope It's a wifi fw feature only

good to go now . Thanks for your help

Found a quirk: If session is already in progress, and a time or energy limit is set below values already accumulated, the session goes straight to disable. This could be problematic for users and especially automations that are not aware of existing session amounts.
Potential solutions:

Add limit amount to existing session values. I.E., if I have already been charging for 38 minutes, and select a 20 minute limit, add the two to actually establish a 58 minute limit (20 minutes remaining from time it is set), or
Reject any limits that are less than current session accumulated values, and/or
GUI popup prompt "Are you sure you want to set a limit less than already used"?

I am not sure which option is most beneficial to users. I can make reasonable arguments in my head for each of them. How did GUI v1 handle this situation?
Also, rounding needed on time remaining figure:

Also, is it not possible to set both a time and energy limit simultaneously? Is this by design?

With no schedule set, there is no "robot head" icon for automatic mode. With limit elapsed, either charging active nor charging disabled is indicated.

Consider adding the robot head icon for automatic mode any time a limit is set as well.

Also, is it not possible to set both a time and energy limit simultaneously? Is this by design?

yes for now only one limit. I thought about allowing multiple limits, but I've not found real use case but gadget ones. And it complicates the UX.
However, the engine could handle that with few mod if well thought. For now it's already better than the evse fw limit. Let start with this.

With no schedule set, there is no "robot head" icon for automatic mode. With limit elapsed, neither charging active nor charging disabled is indicated on "Toggle Charge" icon row.

Consider adding the robot head icon for automatic mode any time a limit is set as well.

Robot Icon means there's an active service controlling the states Enable the EVSE.
If icon disappear it means there's no schedule, nor RFID, nor Divert, etc. Service that can booth enable and siable.
Limits is only made to disable the state. It's not part of automation features as it's still enabled when state is forced to active with Manual override.

Can you post this first & last issues on github ? I'm leaving for 10 days and don't want to forget.

@KipK  -
Time limit display bug fix verified, thanks, looks much better.
I'm not sure which of my observed behavior comments you were wanting to have split to separate issue items. Happy to write-up the split, just need to know which ones.

I mean the 2 bugs / suggestions reports you've made but you can also create one for the simultaneous limits.  It's easier to track them separated.

Okay, split these into #27 and #28 .


Add support for X-NuGet-Protocol-Version header

Will have the same functionality as X-NuGet-Client-Version

Any background info?

@anangaur will have a blog about the protocol this/next week.


add mocks for unsupported locales

This PR requires https://github.com/Shopify/quilt/pull/1302 because the new mocks need the new type signature
Description
Adding more mocks for the tests in https://github.com/Shopify/quilt/pull/1301.
Type of change

[x] @shopify/address-mocks Minor: New feature (non-breaking change which adds functionality)

Dependencies

[ ] bump @shopify/address-consts to get the new type signature

moving the changes in this PR into https://github.com/Shopify/quilt/pull/1301


Serializing Date objects?

Does post-robot support sending Date objects? Just tried to return a date object within an object and found that it returns an empty object. It looks like perhaps there is a minimal check if (typeof item == "object") which will be true for Date objects. Should it have a stronger check like item.constructor === Object and throw an error if false?

This is supported now.


[Request] Add Jabut

Please add this awesome sync software https://jabut.de/

Please add this awesome sync software https://jabut.de/

It seems difficult to include jaBuT as the website forbids hot-linking to the binaries. :(


Resnet

Hey there,
I am trying to understand where the skip connections are in your resnet implementation? I would love to use it but I am having trouble understanding this minor detail. Thanks!

Hi @DriesSmit I think we call them shortcut in the code. You should be able to see them in the __call__ method of the blocks:
https://github.com/deepmind/sonnet/blob/0e25f47fac469c0c2180abba0b985aca46f529ce/sonnet/src/nets/resnet.py#L91-L104
https://github.com/deepmind/sonnet/blob/0e25f47fac469c0c2180abba0b985aca46f529ce/sonnet/src/nets/resnet.py#L166-L179

I see thanks :+1:


Process 1 in container can't  reap zombie process

Description
If a process write in go run in container as 1 pid(process A). If other process B(B is not created by A) is exited sometime process 1 will be chosed to be it's ppid. If this B process is Zombie, process A will not reap Zombie process
for example  k8s yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: sx-heap
  labels:
    app: test
spec:
  replicas: 1
  selector:
    matchLabels:
      app: test
  template:
    metadata:
      labels:
        app: test
    spec:
      containers:
        - name: busybox-1
          image: docker.io/library/test:1
          imagePullPolicy: IfNotPresent
          command: ['/home/main']
          lifecycle:
            postStart:
              exec:
                command: ["/bin/sh", "-c", "sleep 201 &"]

main.go
package main

import (
	"fmt"
	"os/exec"
	"time"
)

func main() {
	cmd := exec.Command("sleep", "10000")
	err := cmd.Start()
	if err != nil {
		fmt.Println(err)
		return
	}

	go cmd.Wait()
	time.Sleep(time.Second * 36000)
}

Dockerfile
From alpine
ADD main /home/

ps -auxf
root      531129  3.0  0.1<PHONE_NUMBER>8 ?        Sl   18:39   0:00 /usr/bin/containerd-shim-runc-v2 -namespace k8s.io -id bdd8d75f2b7ffe2b48d9df6a55068527e0d270ff760b317318831d
65535     531151  3.0  0.0    996     4 ?        Ss   18:39   0:00  \_ /pause
root      531208  0.0  0.0 710244  2944 ?        Ssl  18:39   0:00  \_ /home/main
root      531225  0.0  0.0   1612     4 ?        S    18:39   0:00      \_ sleep 10000
root      531242  0.0  0.0   1612     4 ?                Sl   18:39   0:00 /usr/bin/containerd-shim-runc-v2 -namespace k8s.io -id bdd8d75f2b7ffe2b48d9df6a55068527e0d270ff760b317318831d
65535     531151  0.0  0.0    996     4 ?        Ss   18:39   0:00  \_ /pause
root      531208  0.0  0.0 710244  2944 ?        Ssl  18:39   0:00  \_ /home/main
root      531225  0.0  0.0   1612     4 ?        S    18:39   0:00      \_ sleep 10000
root      531242  0.0  0.0      0     0 ?        Z    18:39   0:00      \_ [sleep] <defunct>

kill -9 531225 (531225 will be reaped by process1 in container  which pid is 531208 on host)
root      531129  0.0  0.1<PHONE_NUMBER>8 ?        Sl   18:39   0:00 /usr/bin/containerd-shim-runc-v2 -namespace k8s.io -id bdd8d75f2b7ffe2b48d9df6a55068527e0d270ff760b317318831d
65535     531151  0.0  0.0    996     4 ?        Ss   18:39   0:00  \_ /pause
root      531208  0.0  0.0 710244  2944 ?        Ssl  18:39   0:00  \_ /home/main
root      531242  0.0  0.0      0     0 ?        Z    18:39   0:00      \_ [sleep] <defunct>

pid  531225 was reaped by process 1 in container,but  531242 will not.
I know shareProcessNamespace: true or use tini will slove it.
can we have another way to reap zombie process ?
Steps to reproduce the issue

Describe the results you received and expected
Process 1 will reap zombie process
What version of containerd are you using?
1.7.6
Any other relevant information
containerd 1.7.6
Show configuration if it is related to CRI plugin.
No response

That looks about right.
This issue is why docker has a --init flag where it injects a proper init process as PID1 of the container.

That looks about right. This issue is why docker has a --init flag where it injects a proper init process as PID1 of the container.
I want process 1 in container which is writed by myself can reap all zombie processes.
use  "shareProcessNamespace: true" is not safe enough, use --init will use some cpu or mem, it is a little heavy.

I don't think containerd is the right layer for this really. A higher level (docker for example, and they already do as @cpuguy83 mentions) runtime can add the ability to inject some init that will reap processes for you, otherwise if you're on k8s you'll need to explicitly ask pid 1 in your container to be some init that you know will do this job.

Wait now that I'm thinking about it, don't zombies get reparented to the shim and then should subsequently get reaped?

can we have another way to reap zombie process ?

It seems we set the shim to be a subreaper, so if you had pid namespace sharing off it seems like they should be getting reaped. I can confirm sometime tomorrow

Wait now that I'm thinking about it, don't zombies get reparented to the shim and then should subsequently get reaped?

can we have another way to reap zombie process ?

It seems we set the shim to be a subreaper, so if you had pid namespace sharing off it seems like they should be getting reaped. I can confirm sometime tomorrow

Process1 in container will reap orphan process  but can't reap zombie process, the top codes write by myself. delete ReapZombiePid() will not reap zombie process  (if orphan process exited it will become zombie process ).
root      531208  0.0  0.0 710244  2944 ?        Ssl  18:39   0:00  \_ /home/main
root      531225  0.0  0.0   1612     4 ?        S    18:39   0:00      \_ sleep 10000
root      531242  0.0  0.0   1612     4 ?        S    18:39   0:00      \_ sleep 201

sleep 10000 will be   reaped but sleep 201 will not.

Wait now that I'm thinking about it, don't zombies get reparented to the shim and then should subsequently get reaped?

can we have another way to reap zombie process ?

It seems we set the shim to be a subreaper, so if you had pid namespace sharing off it seems like they should be getting reaped. I can confirm sometime tomorrow

after this commit https://github.com/torvalds/linux/commit/c6c70f4455d1eda91065e93cc4f7eddf4499b105?diff=split shim will not reap zombie process


Social updates including fixing forum link

Docs Build status updates of commit 7c3984c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/community.md
:white_check_mark:Succeeded
View

sysinternals/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Extra jars included in package

The package.xml file should explicitly exclude the kafka-connect-avro-converter package so as to avoid duplicating all the connect framework jars that will already exist when the connector is deployed.

@dbtucker thanks


⚠ Bofrost.at has degraded performance

In 306fd65, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 7582 ms

Resolved: Bofrost.at performance has improved in 222bbbf after 21 minutes.


Adds Signal

What does this PR do?
Adds post save signal
Description of Task to be completed?
A notification is sent every time an assignment is created
How should this be manually tested?
After cloning the repo, run the server through python manage.py runserver command. Post assignments, every time an assignment is created you should get a notification that reads "Assignment Created!"

@Jeffkungu tests


allow for gcp headers to be included on uses_gcp_auth option

Pull request
Description
Addresses #1081
Will enhance usage of rest sinks by allowing for GCS credentials to be specified when specifying uses_gcp_auth feature, and specifying a credentials file with GOOGLE_APPLICATION_CREDENTIALS env var
Checklist

[x] The RFC, if required, has been submitted and approved
[ ] Any user-facing impact of the changes is reflected in docs.tremor.rs
[ ] The code is tested
[ ] Use of unsafe code is reasoned about in a comment
[ ] Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
[ ] The performance impact of the change is measured (see below)

Performance
should not have significant impact to performance.
This will only authenticate against GCP API by specific request by a user specifying the uses_gcp_auth option. No other performance impact should be noticeable.

Coverage increased (+0.001%) to 84.006% when pulling e9d77925e5d26fc5df25037b139cd6ed7ae8acd5 on wayfair-contribs:gcp_basic_auth_option into 83970b5abbe7f55bdb198816874d2ca8fb61a38c on tremor-rs:main.

LGTM🚀

Could we change the config format for this to be:
offramp:
  - id: gcp_rest
    type: rest
    config:
      auth: gcp

So that we can easily add other auth methods for other apis and not have a gcp specific key here?


Broken link in README.md

This link in Readme is broken
Run mobile and desktop performance tests for your deployed site using **Google PageSpeed Insights** V2 with tidy reporting for your build process.

Links to: https://developers.google.com/speed/docs/insights/v2/getting_started

It looks like the URL was updated to https://developers.google.com/speed/docs/insights/v2/getting-started. We should update it for sure.


Fails to launch puppeteer due to missing package

Hey!
I've added the buildpack to my Heroku application and deployed it. However, when the app tries to launch puppeteer, it gives the following error:
Error: Failed to launch chrome! /app/node_modules/puppeteer/.local-chromium/linux-515411/chrome-linux/chrome: error while loading shared libraries: libcairo-gobject.so.2: cannot open shared object file: No such file or directory
Do you have any idea what the problem could be?
Thanks.
EDIT:
#6 Submitted a pull request to fix the issue

Same issue here

Now it fails to launch due to libXinerama.so.1

Thanks @robertistok and @korroktheslavemaster for letting me know. Can you both check that you are running Puppeteer with the following flags set? const browser = await puppeteer.launch({args: ['--no-sandbox', '--disable-setuid-sandbox']}).
I just double checked the dependencies on Puppeteer and chromium and the current list is correct, and its been working for me on Heroku for quite some time. We can figure it out one way or another though!

Exact same issue as @robertistok
@korroktheslavemaster Is there a way to manually install dependencies in Heroku ?

@jontewks In my case, I have the same flags set. Are you running Heroku-16 stack ?

@stanislasdrg yeah I'm also on Heroku 16. Looking at the list of installed dependencies for Heroku 16 it looks like the package in question is available, but they mark it as only available during build time and not at run time.
If you find a chance, can you try redeploying your app and forcing it through the build phase again? I'm not able to repro this issue on any of my deployed apps at the moment. If that doesn't fix it I'll accept that PR to add it, I don't think there is any downside to extra deps unless someone is hitting the max slug size or something

@robertistok @korroktheslavemaster @stanislasdrg looking at what I originally had for this buildpack I'm seeing those deps manually installed even though they are available on heroku. I guess that makes a difference on Heroku but not when running debian manually so I'm going to accept #6 and also add the additional ones that were there before

Created the new release with all deps here: https://github.com/jontewks/puppeteer-heroku-buildpack/releases/tag/v1.1.1

Thanks again for the quick issue creation!

Thanks for creating this package! :)

Hi! please help me!, I am a newbie in Heroku-18
my buildpacks:
https://github.com/mcollina/heroku-buildpack-graphicsmagick
https://github.com/royalgarter/heroku-buildpack-phantomjs-2.0
https://github.com/heroku/heroku-buildpack-apt
heroku/nodejs
https://github.com/heroku/heroku-buildpack-google-chrome
heroku: 18
puppeteer: 1.8.0
project: Node JS
All worked fine for me but I need chrome headless = false
I changed "https://github.com/heroku/heroku-buildpack-google-chrome" to "https://github.com/royalgarter/heroku-buildpack-xvfb-google-chrome" then error: "libcairo-gobject.so.2: cannot open shared object file: No such file or directory"
I need another buidpack or a another way to launch Chrome with headless = false.
Thank for help!

Hey @voduycan. Heroku doesn't have a GUI, and so running puppeteer in headless: false mode won't work. You can still do all the same things when running in headless mode on heroku, but you won't be able to inspect it visually. Screenshots are a good way to see what puppeteer is doing at any point in time though.

@jontewks Hi, I need to run puppeteer with headless: true (GUI) to do some works. so what any way I can do it?

Run it locally instead of on heroku. Then once you have your scripts set up you can run it headless on heroku if you need. This buildpack is for getting puppeteer running on heroku, so if you have further questions about how to use puppeteer or about running it with a GUI locally, you might be better off asking on the puppetter repo or in their forums.

I have a captcha step, so I need GUI. my project is booking ticket automatic on other website. and this web has captcha step in booking

Captchas are designed to stop things like puppeteer from running without a human, so you probably don't want to use heroku for this. Again this buildpack is just for getting puppeteer running on heroku, so anything beyond that I can't guarantee any help. If you have any issue with this buildpack specifically feel free to open a new issue but like I mentioned, you probably want to look elsewhere for next steps.


@azure/abort-controller - 1 more sample?

The samples for @azure/abort-controller are good but just a touch too abstract. Could there be 1 more sample with a bullet-proof (ish) task like listing resource groups, that could demonstrate the time out functionality?
The timeout operation also makes me wonder, what is the default timeout period for the Azure SDK calls, if the abort signal isn't passed in? Probably doc'd someplace so please include that link if you can.

Once more question - is the ref docs supposed to have methods, properties, etc? It just shows the readme-seems to be missing the TOC.


Fix support for multiple generated sprites in local

If tarmac generates multiple spritesheets, they would overwrite previous spritesheets with --target local due to having the same sprite names (spritesheet).
This addresses that and suffixes each spritesheet with a number that's incremented per spritesheet.
E.g. two spritesheets -> spritesheet-1, spritesheet-2.

Hey! Sorry I need to check my notification settings, I didn't even know you submitted a PR 😬 Thanks for your contribution it's awesome!
That seems like a reasonable fix! Can you run rustfmt so that CI checks are green? You can run cargo fmt and it should fix it.
Again, sorry the delay! Next time ping me on discord if I don't reply a few days

Alright I think it's good now.

I'm not sure how that vanished, should be fixed now. Apologies for the very late response. Been quite busy.


Handle Timeout Exception in SImpleHttpRequestSender

During one of my tests of the latest build, I attempted to connect to a validator that was offline. I noticed that the timeout exception wasn't handled. I wasn't sure if we were going to expose SimpleHttpRequestSender as public, or if we were going to expose the interface only (using SimpleHttpRequestSender for testing only). If it will be public we may want to handle timeout exceptions.

Isn't this related to #30 ?? as an effort to create unified Exceptions??

In a way, but the exception isn't handled currently. In the other service models we have placed generic exceptions.

Let's start slowly, then, with handling this one :)

I will try to work on this one today once the day job is behind me. It's a strange exception and I think I may have it written down somewhere already 😂


Error when scrolling on the response tab inside a network call

When scrolling on the response tab on a network call it gives me an error when scrolling:
The Scrollbar's ScrollController has no ScrollPosition attached.

A Scrollbar cannot be painted without a ScrollPosition.

The Scrollbar attempted to use the PrimaryScrollController. This ScrollController should be associated with the ScrollView that the Scrollbar is being applied to.When ScrollView.scrollDirection is Axis.vertical on mobile platforms will automatically use the PrimaryScrollController if the user has not provided a ScrollController. To use the PrimaryScrollController explicitly, set ScrollView.primary to true for the Scrollable widget.

Thanks for opening an issue.
I'll tackle it in the coming release.

Thanks! I love this package!

Thanks! I love this package!

My pleasure.


[WIP] [CON-692] Add support for updating ES index definition.

add update supprot so that indices that have changed can be updated
add ES version checking
use ES version to determine field type mappings.

TODO:

[x] validate change detection and versoin behavior under ES 2.3
[ ] validate update logic against ES5 - has been done by hand/manual PUTs so far:

bring up chef-backend with ES 2.x
upgrade to 5.x package
reconfigure chef server
verify that the index changes are applied by querying the ES API and inspecting the new definition (all string types have been replaced with keyword or text. )

I'e pushed up my latest changes for reference but I am closing this PR.
ES5 is backwards compatible with ES2 for our index. We will need to address the string type changes (split to text/keyword) , but the number of additional checks required for safely detecting when we need to change the index based on the resource declaration adds more complexity than we can meaningfully test .
A better approach may be to make a specific command to apply ES5 index updates and a reindex  when the customer upgrades their external ES (backend or other) to ES5, possibly via a separate chef client run.  This would alllow us to not handle the special upgrade case inside the standard reconfigure behavior.

@marcparadise OK, thanks for the update.  Does that mean for the purposes of the next release we aren't going to consider this blocking? Or do we still want to address the required changes for ES5 on new installs before the next release.

Interestingly, the mappings using the old string definitions  - when applied to ES 5 on a new CS instance and examining the index we get back on query - they resolved exactly the way our attempted remapping did. (All non-analyzed fields -> keyword; the data field is text)
What this means is that:

anyone installing on ES2 is fine
anyone installing on ES5 is fine
anyone upgrading backend to the ES5 version will be fine in the medium  term; but we will need to provide a path to safely drop/recreate/reindex before we move chef-backend to ES6 (and before we can support customers using ES6)

In the PR I also tried to go the route of drop/recreate - but ran into a number of issues - the first of which was reliably detecting when the index def had changed.  Since we don't reindex in the normal case, an index recreate in a normal reconfigure is a thing to avoid.
Here
Note:       Mapper for [X_CHEF_id_CHEF_X] conflicts with existing mapping in
other types:
mapper [X_CHEF_id_CHEF_X] has different [index] values
mapper [X_CHEF_id_CHEF_X] has different [doc_values] values
mapper [X_CHEF_id_CHEF_X] has different [analyzer]"
}
Once I realized this was going pear-shaped I split off work into a new branch - final version (including some false attempts and workarounds I wouldn't want to actually ship) is in the branch ' mp/ES5-index-updating'.


Integrating tokenized CCB to main

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
Rerun of #752. Bringing CCB vNext to main. (https://github.com/microsoft/fluentui-apple/commit/b5bfef4685f3571a8777c08c5c493dba9fdca1db)
Verification
pod lib lint + manual verification reflected in #705
https://user-images.githubusercontent.com/22566866/136869603-27f3256f-4d83-4aa1-a237-4ca19e31c8aa.mov
Pull request checklist
This PR has considered:

[x] Light and Dark appearances
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)

Microsoft Reviewers: Open in CodeFlow

Closing due to sGen deprecation


Metrics - Prometheus

This PR adds support for Prometheus metrics.
The implementation includes the following changes:

Defining an interface Metrics that defines the methods for creating and incrementing the Prometheus metrics
Create a struct prom that implements the Metrics interface
Includes tests

This change allows for decoupling the implementation of the metrics from the main implementation and easily swap out the Prometheus implementation for another metrics implementation if needed.
Signed-off-by: naveensrinivasan<EMAIL_ADDRESS>

@pxp928 @lumjjb @mihaimaruseac  👀

LGTM! I think something like that - for metrics and counters we want to store, we will need to have a design doc before additional impl. However, this PR is enough of an isolated library.

I've designed this in a GoKit style so that any package can use it.
Could you explain why we need a design document?
It makes sense to create a design document for larger implementations. As we design, the metrics counters and summary will likely evolve, which is the natural process of software development.

I think one thing that sticks out to me, is whether this should be in internal/.

Keeping this package internal would prevent consumers from being able to use the  create their own implementation metricsimplementation. What are your thoughts on this?
In my opinion, it would be beneficial to keep the number of internal packages to a minimum. Thoughts?

So, regarding design docs: for each major piece of infrastructure, it is better to have a design doc to see how it is planned to be deployed, what alternatives are considered, what are the benefits of picking this approach compared to the others, what are the downsides. Without this, it is very likely that another PR could implement a similar functionality or that a few months after the feature lands we discover that it is not doing a key critical job and needs to be scrubbed.
Like, for this PR alone, I am wondering what metrics we'd like to collect and why collecting them from Go vs collecting them from elsewhere (e.g. from database backend on GCP - when that exists) is better. I'm sure a design review can uncover even more questions and can crystallize usage pattens. Plus, it serves as documentation!


Tools can't resize Window

I'm trying to use winLayout, WindowGrid, WindowManager, all of them can resize all my other programs' windows, BUT processhacker and its system information, why would that be?

Best guess is those tools injecting code and getting blocked.

Best guess is those tools injecting code and getting blocked.

aright, in that case can I enable this code ejection in process hacker?
Thanks


leaks my client usage to third parties

Predictably, as a web wrapper, Nimbus makes all of the same 3p connections that irccloud.com does, including ones to Google and Facebook:

I don't expect desktop client software to do this, generally, so I wanted to report this as a violation of the principle of least surprise.  I've no experience with Electron; is it possible to bundle these dependencies into the client app so these requests aren't made?

Not really, the app is just webkit view that loads irccloud.com. You could try to integrate more deeply with irccloud.com and try to be smart what to load and keep local copies of dependencies like you suggest but that will be a nightmare to maintain considering it could break every time they change something. Less effort to write a native app using their APIs at that point


ST sends MQTT, but receive (or act on) see sent commands

In the the ST log I can see when an action happens that it sends the message via MQTT. I am subscribed and can see the MQTT messages being sent by ST (switches, energy usage, etc).
I can also see that the MQTT Bridge is receiving the commands sent via HA and Node-RED, but watching the ST live logging, it doesn't appear that it ever sees receives MQTT command.
MQTT Bridge Config:
mqtt:
    host: mqtt://st-mqtt:1883
    preface: smartthings
    state_read_suffix: state
    state_write_suffix: set_state
    command_suffix: cmd
port: 8081

MQTT Bridge log:
2018-05-24T22:29:40.117Z - info: Subscribing to smartthings/Foot Rest/switch/cmd, smartthings/Foot Rest/switch/set_state, smartthings/Peanut Plug/switch/cmd, smartthings/Peanut Plug/switch/set_state, smartthings/System/notify/cmd, smartthings/System/notify/set_state, smartthings/Foot Rest/energy/cmd, smartthings/Foot Rest/energy/set_state, smartthings/Peanut Plug/energy/cmd, smartthings/Peanut Plug/energy/set_state
...
2018-05-24T22:33:14.483Z - info: Incoming message from MQTT: smartthings/Foot Rest/switch/cmd = on
2018-05-24T22:33:20.124Z - info: Incoming message from MQTT: smartthings/Foot Rest/switch/cmd = off
2018-05-24T22:33:23.826Z - info: Incoming message from MQTT: smartthings/Foot Rest/switch/cmd = on

2018-05-24T22:33:37.593Z - info: Incoming message from SmartThings: smartthings/Foot Rest/switch/state = on ## NOTE: This happened when I sent a command to ST via IFTTT.

2018-05-24T22:33:42.714Z - info: Incoming message from SmartThings: smartthings/Foot Rest/energy/state = 8.51000074606552
2018-05-24T22:34:20.971Z - info: Incoming message from SmartThings: smartthings/Peanut Plug/energy/state = 42.75410946741374

Sorry, found the solution here: https://community.home-assistant.io/t/smartthings-mqtt-bridge/269/144
I had entered the wrong MAC address in to the SmartApp's settings.


Ruby: Generated smoke tests are broken when config uses optional parameters

What
Smoke tests that are given a config that has optional parameters set causes the optional parameters to be passed in a required parameters
Example in Logging
logging_service_v2_client = LoggingServiceV2Client.new
formatted_log_name = LoggingServiceV2Client.log_path(project_id, "test-" + Time.new.to_i.to_s)
resource = MonitoredResource.new
labels = {}
entries = []
response = logging_service_v2_client.write_log_entries(formatted_log_name, resource, labels, entries)

The method call should actually look like this:
logging_service_v2_client.write_log_entries(
  formatted_log_name,
  resource: resource,
  labels: labels,
  entries: entries)

cc @swcloud @geigerj

@landrito Can you add a priority to this?

Done.

@landrito If it's P1, can you assign it?

Done.

@landrito What's the status of this issue?

Haven't gotten around to this issue.

@eoogbe, could you PTAL?

cc @lukesneeringer This is a problem with nodejs as well as seen in this CI build error. https://circleci.com/gh/googleapis/nodejs-logging/162?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link