consume NATS properties via BOSH link if available

Signed-off-by: Fabio Berchtold<EMAIL_ADDRESS>

Hi @JamesClonk
Thank you for submitting the PR. I can see from the commit that only route registrar job has been changed to consume NATs link and not gorouter. Any particular reason?
Regards
Shash

Hi @shashwathi
I was mainly interested in the route-registrar since we are using that colocated in various other bosh releases to register routes to CF.
But you're right, it makes sense to also allow the Gorouter to consume the NATS link.
I added the changes for the gorouter too.
Regards
Fabio

Hi @JamesClonk
Thank you for updating your PR.
Regards
Shash

When consuming a BOSH link there must only be 1 instance_group providing it under the same name, otherwise BOSH cannot decide which one to pick.
It seems in that bosh-lite manifest used there was the "old" way of setting up availability zones by defining them in separate instances_groups/jobs, rather than using the native AZ feature. Therefore you end up with 2x (or more) NATS jobs, all of them providing the "nats" link under the name "nats".
The solution to this is to either just have 1 NATS instance_group, like for example in the big cf-deployment manifest example: https://github.com/cloudfoundry/cf-deployment/blob/e90128d6af980c575156dede7028f99bc00fb9f1/cf-deployment.yml#L68-L71
Or to explicitly name the links these instance_groups provide.
For example:
instance_groups:
- name: nats_z1
  jobs:
  - name: nats
    release: nats
    provides:
      nats:
        as: nats_z1
    properties: ...
- name: nats_z2
  jobs:
  - name: nats
    release: nats
    provides:
      nats:
        as: nats_z2
    properties: ...

when consuming you can then also specify the link name explicitly:
instance_groups:
- name: gorouter
  jobs:
  - name: gorouter
    release: routing
    consumes:
      nats:
        from: nats_z1
    properties: ...

there's more info on BOSH links in the docs: http://bosh.io/docs/links.html

@JamesClonk thanks for this PR!
@shashwathi this is a known side-effect of using links in a "BOSH 1.0" manifest, and has a standard solution: https://github.com/cloudfoundry/cf-release/blob/7bb139ef2aca118764929ef78d890260f6d183b5/templates/cf.yml#L1453-L1454.  A PR to cf-release in anticipation of this change would be required.  It would be better to test this against cf-deployment.
@JamesClonk comparing the logic in this PR to the logic in the nats-release (https://github.com/cloudfoundry/nats-release/blob/32490a93bd4f2269cc0a74f77785e08bcd7f3c1d/jobs/smoke-tests/templates/config.json.erb), it appears your code will allow things like nats_password to simply be nil if it isn't provided as an explicit property or via a link.  If these nats properties are required (as they are in the case of route registrar), it would be better to fail fast than to allow this value to be nil.  WDYT?
/cc @dsabeti @JesseTAlford @dsboulder

@Amit-PivotalLabs ah yes, makes sense. Thanks! I changed the PR.

@JamesClonk : Thank you for updating PR.
@Amit-PivotalLabs : I realised about this work around from @dsabeti. Routing team will take care of updating templates in cf-release to support this PR.
Regards
Shash

@JamesClonk @shashwathi I see that this PR is preferring properties over links if both are provided. Since links are the more modern approach, I believe that we should prefer them over properties. cf-mysql-release has a good example of this here. This allows us to treat properties as fallbacks, eventually deprecating and removing them. If an operator still wishes to manually provide connection information, they can do so with manual linking.

/cc @cppforlife
On Fri, Jan 20, 2017 at 6:06 PM, Dan Wendorf<EMAIL_ADDRESS>wrote:

@JamesClonk https://github.com/JamesClonk @shashwathi
https://github.com/shashwathi I see that this PR is preferring
properties over links if both are provided. Since links are the more modern
approach, I believe that we should prefer them over properties.
cf-mysql-release has a good example of this here
https://github.com/cloudfoundry/cf-mysql-release/blob/a3cdac2e5b2c1fa0876019397d11bb7ac639a343/jobs/cf-mysql-broker/templates/mylogin.cnf.erb.
This allows us to treat properties as fallbacks, eventually deprecating and
removing them. If an operator still wishes to manually provide connection
information, they can do so with manual linking
https://bosh.io/docs/links-manual.html.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cloudfoundry-incubator/routing-release/pull/59#issuecomment-274224946,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC9t3nSDM1I28Vud-OgoLkAJA2gczP05ks5rUWgogaJpZM4Lbynt
.

I just spoke with @robdimsdale and he brought up a point about backwards-compatibility with directors that do not support links. If routing-release wants to support these older directors (earlier than v255.5, released March 2016), either keeping the priority order as is would work, or checking for respond_to?(:if_link) as a "version check" would work.

@wendorf @Amit-PivotalLabs
According to the above comments, it sounds like the PR looks good for now but something to note in the future to update. Is that correct?
Regards
Shash

@shashwathi I did a little more talking with different people for recommendations, and it sounds like I was mistaken. It's easier (and has cleaner backward compatibility) to prefer links, so this PR looks great from my perspective.


Upgrade Docker image to be based on Python 3.11

Describe what the PR does:
This PR updates the Docker image to be based on Python 3.11.
Does this fix a specific issue?
N/A
Checklist:

[ ] Confirm that one or more new tests are written for the new functionality.
[x] Run tests and ensure everything passes (with 100% test coverage).
[ ] Update README.md with any new documentation.
[ ] Add yourself to AUTHORS.md.

Docker image fails to build because piwheels.org doesn't have a cryptography wheel for this version yet. We're not in a rush; going to mark this as draft until that resolves.

Still active.


Tensor parallel  distributed strategy without using deepspeed

Tensor parallel by extending GaudiLlamaAttention -> TPGaudiLlamaAttention  and GaudiLlamaMLP -> TPGaudiLlamaMLP
use parameter --distributed_strategy="tp" to invoke this code path

https://github.com/huggingface/optimum-habana/pull/1121


Fix hydration of boundaries with abstract types

This commit ensures boundaries relying on abstract queries specify the abstract type name in the resolver directive. This is necessary to ensure the correct type is resolved when the boundary is hydrated.
I'm working on a project that stitches some types via abstract queries. I noticed that a dynamically composed version of the supergrapgh works fine, but a supergraph hydrated from the dumped SDL is generating invalid subgraph queries—it's not including the necessary inline fragment.
Example
Schema A
type Query {
  nodes(ids: [ID!]!): [Node]! @stitch(key: "id")
}

type Post implements Node {
  id: ID!
  title: String!
}

Schema B
type Query {
  post(id: ID!): Post @stitch(key: "id")
}

type Post {
  id: ID!
  summary: String!
}

Supergraph query
query {
  post(id: "gid://my-app/Post/123") {
    title
    summary
  }
}

Current invalid query on schema A
query {
  _0_result: nodes(ids: ["gid://my-app/Post/123"]) {
    title
  }
}

Fixed query on schema A
query {
  _0_result: nodes(ids: ["gid://my-app/Post/123"]) {
    ... on Post
      title
    }
  }
}

Wow, good find! I'll take a closer look later this weekend. Thanks for the PR.

Abstract boundaries are hard. Thanks, good sleuthing!


Calculate combined expenses instead of combined taxes

This needs to include pension contributions, etc.

On the other hand, this would affect the effective tax rate and marginal tax rate. Should pension contributions really be included?


Cannot get 3-day view to remain; it toggles between 7-day view.

I love this plugin, really glad it's here, as it lets me stay in Obsidian for longer.
My main issue is that sometimes the interface displays a  7-day view, and sometimes it displays a 3-day view.  The 7-day view is squished up, and not great for a column in Obsidian.

The 3 day view is ideal. But I don't know how to toggle it, or get it so that it is always in 3 day view. 3 day is more compact and does not have giant letters for the date at the top.
Is there a way to get it set at 3 day view? Is there a reason it keeps toggling between the 2?  Thanks!!! Again, it's a fantastic plugin and I'll use it regardless of if this issue can be fixed.

The 3 day view is toggled based on the detected width of your device. @litchaikov what kind of device are you using? If on a desktop/laptop, are you using a narrow window or pane? I would recommend using a wider pane. If you are on a mobile device, then this is a bug that the 7 day view should be visible at all.

Closing this since it hasn't had activity in a month. Feel free to comment on it if this issue keeps happening.

Full Calendar does not completely load on mobile devices (iphone, ipad). Window remains blank no matter if I change view settings or restart


Fix Segment error on development environment

By running the website locally with yarn dev, we have a Segment error because no Segment API key is provided:

Segment shouldn't try to push data on development environment, so a check should be added.

Resolved with #519


Add simple log processor implementation and unit tests

This is part of the SDK component of the Logging prototype in # 337.
This PR adds:

A simple processor implementation and unit tests
A log exporter interface, required for the processor unit tests

The simple log processor sends Log Records from the SDK directly to an exporter in a batch of one. Its design follows the traces specification.
cc @alolita

Codecov Report

Merging #8 (3015792) into master (88d43a3) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   95.01%   95.01%
=======================================
  Files         171      171
  Lines        7186     7186
=======================================
  Hits         6828     6828
  Misses        358      358

Impacted Files
Coverage Δ

sdk/include/opentelemetry/sdk/logs/processor.h
100.00% <ø> (ø)

sdk/test/logs/logger_provider_sdk_test.cc
90.32% <0.00%> (ø)

sdk/test/logs/logger_sdk_test.cc
91.66% <0.00%> (ø)


Dropdown for multiple select disappears when selecting options.

Describe the error in 1 sentence
When using a multiple select with ng-options, selecting an option causes the dropdown to disappear.
Steps to reproduce

Open Fiddle: http://jsfiddle.net/gmse4pgc/8/
Click on select
Select option

What exactly is supposed to happen
The select dropdown should remain open.
What exactly does happens
The select dropdown closes.
Note: This only happens when uses ng-options. When using ng-repeat directly on  tags, it works. But I need to use ng-options as adding an ng-model when using ng-repeat causes an infinite loop when using ng-change.
A link to a page clearly demonstrating the issue
http://jsfiddle.net/gmse4pgc/8

did you find the solution for this?

@Srimal94 did you find something on this ?


Running testing with realm work on local machine but not in CI/CD

What happened?
Run unit/integration testing locally with realm but in CI/CD github action does not work
Repro steps
https://github.com/realm/realm-dart/issues/1619
Version
3.24.0
What Atlas Services are you using?
Atlas Device Sync
What type of application is this?
Flutter Application
Client OS and version
Windows
Code snippets
https://github.com/yegobox/flipper/actions/runs/10332144404/job/28603071678
Stacktrace of the exception/crash you're getting
- "C:\Users\runneradmin\AppData\Local\Pub\Cache\hosted\pub.dev\realm-3.3.0\windows\binary\windows\realm_dart.dll"

Relevant log output
No response

@richard457 Add a dart run realm install before the flutter test .. call.
Unlike flutter drive .. or flutter test integration_test/..,  flutter test doesn't actually create and run an app bundle. In particular there is no way (currently - we are eagerly awaiting the native assets feature) to hook into the build process and ensure that the binaries are downloaded during flutter test.
The reason you didn't have to do this on your developer machine is (most likely) that you have actually tried running an actual flutter app dependent on realm 3.3.0 (probably the app you are developing) in which case we can do the download during build. For iOS and macOS this happens via cocoa pods, for Android via gradle, and for Linux and WIndows via cmake.
On CI you are starting setup more or less from scratch on each run, so the pub cache won't be primed, and something needs to trigger the download explicitly.
Anyway, you are not the first to have trouble with flutter test and packages with native dependencies, such as realm. I hope this helps.


DRAFT: code highlighting with hljs

wip for #81
todo: consider adding option to theme via feature flag
not sure whether we need this or we can just make a better example documentation
https://highlightjs.readthedocs.io/en/latest/readme.html#in-the-browser
https://highlightjs.readthedocs.io/en/latest/readme.html#common-js-omit-in-toc
https://highlightjs.org/download
Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.
Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.
If the UI is being changed, please provide before/after screenshots.

References

Include any links supporting this change such as a:

GitHub Issue/PR number addressed or fixed
Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If there are existing unit and/or integration test suites, tests should be added for new functionality and existing tests should complete without errors.
Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.
Also include details of the environment this PR was developed in (language/platform/browser version).

[ ] This change adds test coverage for new/changed/fixed functionality

Checklist

[ ] I have added documentation for new/changed functionality in this PR or in mkdocs-terminal/documentation
[ ] All active GitHub checks for tests, formatting, and security are passing

code highlighted but lost the custom background color


WCF hosting - Multiple IIS hostnames

Hi there,
I'm trying to deploy a Nancy webservice via WCF hosting in an IIS website/application. When i add two hostname bindings to the application, the second one returns a 404.
The service is configured via a RouteTable in combination with a custom WebServiceHostFactory derived class:
RouteTable.Routes.Add(
new ServiceRoute("MyServiceName", new MyNancyServiceHostFactory(),
typeof(NancyWcfGenericService)))
Are multiple IIS hostnames a supported scenario? If so, how to make it work?

I don't see any reason why this wouldn't work, however this issue seems dead in the water. I did test the diagnostics myself in a sub directory and it works, but I don't have IIS to test with sub applications.


[SPARK-12012][SQL] Backports PR #10004 to branch-1.6

test this please

Jenkins is shutting down for quite a while (at least two hours).

Actually it doesn't seem to be scheduled. The message "Jenkins is going to shut down" has been there for at least 6 hours.

Test build #47521 has started for PR 10250 at commit 69b3dbd.

Test build #47521 has finished for PR 10250 at commit 69b3dbd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47521/
Test FAILed.

retest this please

Test build #47523 has started for PR 10250 at commit 69b3dbd.

Test build #47523 has finished for PR 10250 at commit 69b3dbd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47523/
Test PASSed.

Merged build finished. Test PASSed.

For backport, it will be great if we still use the original title. I am merging it in and change the title.

I have merged it. Let's close this PR.


Issue with location of the Server Farm

hello team,
there is an issue with the template. If you choose a different location than westerneurope the deployment fails because the serverFarm has location harcoded to West Europe:
original template:

I forked the repo and I have replaced "West Europe" with
[parameters('NewOpenAIResourceLocation')]
so that now it uses always the same location.

I have requested a pull request with the change

Hi Augustin,
Yes Aadrika has already notified me, and I've fixed it probably 20 minutes ago.
Many thanks for letting me know as well.
Samer

From: Agustin Mantaras @.>
Sent: Tuesday, March 14, 2023 3:33 PM
To: samelhousseini/km-openai @.>
Cc: Subscribed @.***>
Subject: [samelhousseini/km-openai] Issue with location of the Server Farm (Issue #2)
hello team,
there is an issue with the template. If you choose a different location than westerneurope the deployment fails because the serverFarm has location harcoded to West Europe:
original template:
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F41587804%2F224988030-356af1ad-24f9-40ab-af4e-6c22f92974e3.png&data=05|01|samer.elhousseini%40microsoft.com|0487290fc4f646a71c9508db247ff37b|72f988bf86f141af91ab2d7cd011db47|1|0|638143904211143545|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=MoNGtr8Gvsa7fJN88pGzMBm7%2BKDwi0uSVtjtrNororQ%3D&reserved=0
I forked the repo and I have replaced "West Europe" with
[parameters('NewOpenAIResourceLocation')]
so that now it uses always the same location.
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsamelhousseini%2Fkm-openai%2Fissues%2F2&data=05|01|samer.elhousseini%40microsoft.com|0487290fc4f646a71c9508db247ff37b|72f988bf86f141af91ab2d7cd011db47|1|0|638143904211143545|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=ZgWXj6IOH5RzefdL6GZlvjE49OVhNN9jHzsoKw6oVUo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZ2RAUTYLSTGW5IXANJGJVTW4BJRBANCNFSM6AAAAAAV2KDLUQ&data=05|01|samer.elhousseini%40microsoft.com|0487290fc4f646a71c9508db247ff37b|72f988bf86f141af91ab2d7cd011db47|1|0|638143904211143545|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=5LaQ68tfwNzkXWvEXaa85cx%2FBbDhDpUfNmN3h7wl5lQ%3D&reserved=0.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


How to add a custom message for the extension-method

Using the code example shown on this page
https://jqueryvalidation.org/extension-method/
How can I add a custom message?
Currently the error message reads "Please enter a value with a valid extension."
I'd like to change it to something else.

From the .rules() page:

Both rules and messages can be specified using data attributes, using data-msg (a generic, not
method specific message), data-msg-[method] and data-rule-[method].

Another reference with a list of rules: Using the jQuery Validate Plugin with HTML5 Data Attribute Rules

Many thanks. I ended up creating a custom method which solved the problem.


Add Sentry.io or equivalent for error reporting

Adding sentry looks straight forward. We need two things to get started:

A sentry.io account. @igor-ka do you think you can make an account for Rangle, and pass the credentials off to @stevenkampen?
Install raven-js and initialize it using the account set up above: https://docs.sentry.io/clients/javascript/install/#es2015-es6


NW6| Bakhat Begum| HTML-CSS | Wireframe | Week 1

Learners, PR Template
Self checklist

[x] I have committed my files one by one, on purpose, and for a reason
[x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[x] I have tested my changes
[x] My changes follow the style guide
[x] My changes meet the requirements of this task

Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.

@BakhatBegum can you explain your PR and tell me what you would like us to look at? We are here in Code Review looking through work but your message is blank.

Hi Sally, Apology for that. It is just a simple HTML and CSS project which consists of several tags, elements, layout, and syntax.
Receiving feedback regarding the wireframe structure and its codes would be great.

Thanks for the feedback.
On Tue, 17 Oct 2023 at 19:30, Musa @.***> wrote:

@.**** commented on this pull request.
In Wireframe/index.html
https://github.com/CodeYourFuture/Module-HTML-CSS/pull/113#discussion_r1362584084
:

What is Git?

Git is a version control system that helps you

         track changes in your files and collaborate with others on software

         development projects. It allows you to save

         different versions of your work and manage them efficiently.

Great job on using semantic HTML correctly! It's fantastic to see that
you're following best practices for structuring your web pages. Keep up the
good work!
To further enhance the readability of your code, I recommend using a code
formatter, such as Prettier, for consistent and standardised
indentations. It ensures that your code is consistently formatted, making
it easier to read and understand.
In Wireframe/index.html
https://github.com/CodeYourFuture/Module-HTML-CSS/pull/113#discussion_r1362595752
:

      <img

       class="article__img"

Great job on using descriptive class names, @BakhatBegum
https://github.com/BakhatBegum ! To enhance your naming further,
consider adopting the BEM (Block Element Modifier) naming convention. A
more structured approach to class naming. You can learn more about BEM
here https://getbem.com/naming/. Keep up the good work!
—
Reply to this email directly, view it on GitHub
https://github.com/CodeYourFuture/Module-HTML-CSS/pull/113#pullrequestreview-1683090719,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7AJUM7QZMWKHVDVY5VBTKDX73FFLAVCNFSM6AAAAAA5ONGKDGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOBTGA4TANZRHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Improve opt-out handling

[x] Send additional info through to Jembi on opt-out
[x] Move logic out of app to utils
[x] Use interstitial over on:enter

@imsickofmaps Please review.  Will implement sending different Jembi optout types in #154.

just the comment then :+1:


MNEMONIC is leaking in the logs

🙂 Expected behavior
What was expected?
When using --tx-signing-mnemonic <TX_SIGNING_MNEMONIC> or --tx-signing-mnemonic-file <TX_SIGNING_MNEMONIC_FILE>, their content should be hidden from logs since its considered sensitive information.
🫠 Actual behavior
What happened instead?
The MNEMONIC content should never be logged,
🧪 Minimal test case
Start a rollups-node using configuring the authority-claimer with --tx-signing-mnemonic and looking at the logs.
...
tx_signing_config: Mnemonic { mnemonic: "you should not be seeing this twelve words that are part of secret" account_index: None }
...

🌎 Environment
rollups-node:1.2.0
✔ Possible solutions
Hide the MNEMONIC content from logs, like it was already done in previous versions.

I suppose PR #203 will fix this via the redact property in the Config.toml file.
@renan061 can you confirm this, please?


Opening TSDB ReadOnly can corrupt TSDB (non-sequential files)

When we Open TSDB in read only, programmatically, we should still take the lock. Not doing so often leads to "un-sequential" mmap files errors, if Prometheus is still running. I think that this behavior is not correct and that we should take the lock to prevent that kind of issues.

The whole point of ReadOnly is that we can use it when Prometheus is running.

Then we should take the necessary action to prevent it to corrupt tsdb

Agree, help wanted to ensure this :upside_down_face:

Now with the read-repair of m-map chunks we have a issue that the "read only" DB is not read only anymore.

But I am curious how opening in read only mode can corrupt the DB, we don't write anything that can corrupt it (minus the repair now), it would only read the file. Any steps to reproduce?

Do we know if this is still the case? If I use tsdb.OpenReadOnly(), will it corrupt the database that it's reading?

@roidelapluie have you faced any issues lately? Maybe it is time to close this issue.

The RO Head can alter the mmap chunks in repairLastChunkFile and also in removeCorruptedMmappedChunks
But it can also cut new chunks while playing the WAL processWALSamples->mmapChunks as we see here https://github.com/prometheus/prometheus/issues/11618.
I'm working on a patch here https://github.com/prometheus/prometheus/pull/13218

Fixed by #13218.


line numbers, horiz scrolling

per https://github.com/aspnet/Docs/issues/1054
@ardalis @danroth27 @shirhatti please review

Replaced with https://github.com/aspnet/Docs/pull/1168


Feature/#1240 medusa pull secret ref

What this PR does:
Which issue(s) this PR fixes:
Fixes #1240
Checklist

[x] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated not needed IMHO because it fixes something what is already documentated
[x] CHANGELOG.md updated (not required for documentation PRs)
[x] CLA Signed:  DataStax CLA

Hi @tuxBurner, your branches has some conflicts and can't make it into the release we're cutting out today.
Once the release is done, please fix those conflicts after rebasing and we'll issue a patch release with it.
Thanks!

@adejanovski okay merge conflict is fixxed

@adejanovski well now suddenly i get a failure on the Quality Gate check. But the Code was fine before 👍 Am i supposed to fix this or can I ignore it ?

You can ignore it, no worries

:partying_face: thanks a lot

Thank you for your contribution @tuxBurner! 🎉


Fix compiling error of testcases.

I think the testcases of ConsulProvier need to rewrite. I fix the compiling error, but it's still failed.

OK, I will merge this in and work from there 👍🏻


playground: share blocked from Russia

My public IP is 2a00:1ec8:77:101:7a24:afff:fe89:e7f3. According to https://www.iplocation.net/ it's Russia. And I am in Russia indeed.
DNS gives me California server for play.golang.org:
$ dig play.golang.org

; <<>> DiG 9.10.4-P3-RedHat-9.10.4-2.P3.fc24 <<>> play.golang.org
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 61863
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 4, ADDITIONAL: 5

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;play.golang.org.		IN	A

;; ANSWER SECTION:
play.golang.org.	13	IN	A	<IP_ADDRESS>

;; AUTHORITY SECTION:
golang.org.		77248	IN	NS	ns4.google.com.
golang.org.		77248	IN	NS	ns2.google.com.
golang.org.		77248	IN	NS	ns1.google.com.
golang.org.		77248	IN	NS	ns3.google.com.

;; ADDITIONAL SECTION:
ns1.google.com.		179243	IN	A	<IP_ADDRESS>
ns2.google.com.		179243	IN	A	<IP_ADDRESS>
ns3.google.com.		179243	IN	A	<IP_ADDRESS>
ns4.google.com.		179243	IN	A	<IP_ADDRESS>

;; Query time: 2 msec
;; SERVER: <IP_ADDRESS>#53(<IP_ADDRESS>)
;; WHEN: Thu Nov 03 16:23:11 MSK 2016
;; MSG SIZE  rcvd: 206

But I don't see share button on play.golang.org and I get "Forbidden" when going to shared playground code.
I know that you have some restrictions for China according to open source playground code, but I am in Russia.

@broady, could you file an internal geolocation bugs like the previous ones we've filed?

Interesting. Google also thinks this IP is in Russia. It might be specific to App Engine. I will follow up.


Fixes for Python 3

specview also needs to be fixed to work with Python 3 - I can look into it later

Well done! Thanks!