Yum and Apt repositories for Telegraf

Would it be possible to setup a yum repo for this project, something like this:
[telegraf]
name=telegraf
baseurl=https://packagecloud.io/telegraf/stable/el/6/$basearch
repo_gpgcheck=1
enabled=1
gpgcheck=1
gpgkey=https://packagecloud.io/gpg.key https://telegraf.s3.amazonaws.com/RPM-GPG-KEY-telegraf
sslverify=1
sslcacert=/etc/pki/tls/certs/ca-bundle.crt

That way we don't have to check for a new release, download and run the upgrade manually.

I agree, and am also going to include Apt repos while we're at it. Should be able to use something like packagecloud or bintray to host this for us, thanks for your suggestion!

This would help greatly with updating on multiple servers :+1:

Is the new release imminent?

Well 3 releases in August and 2 in September is a bit of work if you have a few servers :)

Not if telegraf updates with yum, right?

Yeah, if they add yum and apt it would be easy as pie :cake:

Except that Telegraf is so much dependent on InfluxDB, which is not yet updatable using yum, plus that InfluxDB is going through heavy changes with broken compatibility from one version to another. Hope that all of this will get stable one day, before we get tired of running into problems with the updates.

Any news about this? I'd so much like to just have it updated along with other libraries.

@skynet No update yet. We should have progress made on this sometime this week, though. I'll send out an update as soon as it's been added.

any luck on this?

Just noticed that influxdb provides telegraf packages:
yum provides telegraf
Loaded plugins: priorities, update-motd, upgrade-helper
572 packages excluded due to repository priority protections
telegraf-0.2.0-1.x86_64 : InfluxDB Telegraf agent
Repo        : influxdb

telegraf-0.2.4-1.x86_64 : InfluxDB Telegraf agent
Repo        : influxdb

telegraf-0.2.4-1.x86_64 : InfluxDB Telegraf agent
Repo        : @influxdb

@skynet Yes, sorry for not updating this. Telegraf packages are now officially available through the repos.influxdata.com repository. Let me know if anyone runs into any issues!

thanks much @rossmcdonald


[MINOR][YARN]False report isAllNodeBlacklisted when RM is having issue

What changes were proposed in this pull request?

Improve the check logic on if all node managers are really being backlisted.
Why are the changes needed?

I observed when the AM is out of sync with ResourceManager, or RM is having issue report back with current number of available NMs, something like below happens:
...
20/05/13 09:01:21 INFO RetryInvocationHandler: java.io.EOFException: End of File Exception between local host is: "client.zyx.com/x.x.x.124"; destination host is: "rm.zyx.com":8030; : java.io.EOFException; For more details see:  http://wiki.apache.org/hadoop/EOFException, while invoking ApplicationMasterProtocolPBClientImpl.allocate over rm543. Trying to failover immediately.
...
20/05/13 09:01:28 WARN AMRMClientImpl: ApplicationMaster is out of sync with ResourceManager, hence resyncing.
...
then the spark job would suddenly run into AllNodeBlacklisted state:
...
20/05/13 09:01:31 INFO ApplicationMaster: Final app status: FAILED, exitCode: 11, (reason: Due to executor failures all available nodes are blacklisted)
...
but actually there's no black listed nodes in currentBlacklistedYarnNodes, and I do not see any blacklisting message from:
https://github.com/apache/spark/blob/master/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala#L119
We should only return isAllNodeBlacklisted =true when we see there are >0  numClusterNodes AND 'currentBlacklistedYarnNodes.size >= numClusterNodes'.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

A minor change. No changes on tests.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Hi @srowen , thanks for reviewing this. I have addressed your review comment. Let me know if there's further changes needed.

@attilapiros what do you think? seems like a plausible logic change but I don't know this part well, maybe you do better.

Jenkins test this please

Test build #123061 has started for PR 28606 at commit 508a746.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27700/
Test PASSed.

Test build #123061 has finished for PR 28606 at commit 508a746.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123061/
Test PASSed.

@attilapiros is this minor change correct and complementary, or needs to be a part of the larger PR?

Yes, this is correct on its own.

Thanks @attilapiros for pointing out #26343. I see the same issue is addressed in #26343, so if #26343 goes in, we can just close this minor PR.

Not sure what the status of that PR is, so I will merge this and attach to the JIRA as a partial fix.


Docker container does not respond to SIGTERM signal

When calling docker stop snitch the container does not shutdown the services and exits. So it does not respond to SIGTERM signals. Docker will wait some time, by default 10 seconds, and then send SIGKILL to kill the process. Always waiting 10 seconds is kind of annoying. As a consequence your app won't shutdown gracefully at all in case that is important.
The issue is that you are calling bash entrypoint.sh to start 3 processes and bash ignores signals and does not forward them to processes. As a workaround I have to use docker run --init to let docker insert a small init process as PID 1 which then manages your bash entrypoint.sh process. That way I don't have to wait 10 seconds, but signals still won't be forwarded to your processes for graceful shutdown.
So at least add --init to your tutorial and/or make your PID 1 process more compliant.

Got to admit that Docker isn't my strongest suit, I'll do some reading and fix it - thanks for the tips!

A common work around for providing signal handling without implementing it, is to wrap tini around the entrypoint, and it will take care of the rest.

krallin/tini: A tiny but valid `init` for containers

It's a low effort solution.


fix(typography): remove useless width

This PR implements these following specifications: https://github.com/okp4/ui/issues/239

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[ENG-3237][ENG-3238] Fix accessibility problems on collections submission page

Tickets:
ENG-3237
ENG-3238
Feature flag: n/a

Purpose
Fix the accessibility problems on the Collections submission page
Summary of Changes

Darken header text for each input section
Add aria label to search text input
Add aria label to search action button
Remove hidden label from bibliographic checkboxes
Add aria label to bibliographic checkboxes

Screenshot(s)

Side Effects
No, these should be isolated
QA Notes
Functionality shouldn't be affected, only accessibility.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 71.912%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
4769

Relevant Lines:
6360

💛  - Coveralls


check process state while exec delete

check process state while exec delete.

Could you pls rebase the PR against latest changes in main to rerun CI?


Placeholder and input text are not even

Hey,
I have problem because placeholder and input are not even (see attachment). Is there possibility to make them even? Maybe after accepting PR#48 and exposing paddingY property as public I could solve this problem.

Thanks in advance,

This issue is fixed in latest commit.


Milestone 0.0.7

Coverage remained the same at 100.0% when pulling 47bed007e375e10cb024a78b079a20ef0d646c25 on milestone-0.0.7 into<PHONE_NUMBER>b8af821a955c8af70eb7f67b2cfd30 on master.

Coverage remained the same at 100.0% when pulling ed72fdb6207d8c42cab452bc486a0b6724a9fb59 on milestone-0.0.7 into<PHONE_NUMBER>b8af821a955c8af70eb7f67b2cfd30 on master.

Coverage remained the same at 100.0% when pulling ed72fdb6207d8c42cab452bc486a0b6724a9fb59 on milestone-0.0.7 into<PHONE_NUMBER>b8af821a955c8af70eb7f67b2cfd30 on master.

Coverage remained the same at 100.0% when pulling ed72fdb6207d8c42cab452bc486a0b6724a9fb59 on milestone-0.0.7 into<PHONE_NUMBER>b8af821a955c8af70eb7f67b2cfd30 on master.

Coverage remained the same at 100.0% when pulling ed72fdb6207d8c42cab452bc486a0b6724a9fb59 on milestone-0.0.7 into<PHONE_NUMBER>b8af821a955c8af70eb7f67b2cfd30 on master.


Account block

Any recent ideas for the API to not get blocked after some time? Limiting and timing the messages makint it as real as it could be but still getting blocked frequentlly

What does blocking look like for you? Permanent ban or temporary lockout?

#852


openni2_camera: 0.2.6-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository openni2_camera to 0.2.6-0:

upstream repository: https://github.com/ros-drivers/openni2_camera.git
release repository: https://github.com/ros-gbp/openni2_camera-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.5.21
previous version for package: null

openni2_camera
* [fix] Compile for OSX #30 <https://github.com/ros-drivers/openni2_camera/issues/30>
* [fix] Crash on OSX and warning fixes.
* Contributors: Hans Gaiser, Isaac I.Y. Saito, Michael Ferguson

http://build.ros.org/job/Ksrc_dJ__openni2_camera__debian_jessie__source/9/
The source build is failing for Jessie. Can you rerun bloom and accept the new actions (say yes when Bloom prompts you to update the actions)?

I've disabled the source job for now, can you tag me as a reminder to reenable once this is fixed?

The job will reenabled itself when:

a new pull request changes the entry of this repo and
when all cjobs are being reconfigured in the night (so if the fix won't be released today the job will start failing in the night again)

@jacquelinekay @dirk-thomas I re-ran bloom and it opened a new PR. https://github.com/ros/rosdistro/pull/11445


Fixed Cyrillic с in 'kube-proxy-cm'

There was a typo (wrong character) in kube-proxy-cm.yaml - Cyrillic с (UTF-8 0x0441) was used instead of Latin c.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.10 Features: set Milestone to 1.10 and Base Branch to release-1.10
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>
Please delete this note before submitting the pull request.

/lgtm


Question: using bower to manage test dependencies

Hi there,
I am spinning up the development environment so I can start contributing back as it seems like several of the issues are things we're going to need. While doing so I noticed that the test dependencies are vendored.
Would you be open to a pull request that used bower to manage these dependencies?
I feel like it would make it easier to try out new dep versions while developing and potentially allow testing against multiple version of Ember.
Thank you very much for creating ember-pusher we'll be wiring it up today and it provides a huge boost to our app to be able to do so quickly.

Hey @elskwid, glad to have the help! Certainly pulling in dependencies in a better way is desirable. This library was written at a time when I had to hand-roll everything.
Pulling in deps for the test harness with bower seems reasonable.

Neat! Thanks for the quick reply ... now where did I put that VM?

I'm working ember-cli'izing ember-pusher making this a moot point.

Ah, well, let me know if you need a hand. I'll poke around on some of the other stuff if you like.

@jamiebikies given that you're making some changes is it okay to create pull requests for other things? I'd love to take a stab at a few of the issues.

Yeah go for it! What were you thinking?

I was looking at #1 and #6. We will need #1 sooner rather than later and I have time allocated to work on it. If you'll have me.

#1 I've wanted to work on for a long time now!


[$1000]  Save button does not throttle requests and keeps user on upload page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open Android > Chrome
Sign into www.staging.new.expensify.com
Tap on Avatar (chat view)
Tap on Avatar (settings view)
Tap on Avatar (profile view)
Tap Upload photo
Select a picture to upload
Click on "Save" multiple times

Expected Result:
The profile picture should be saved on the first click and the user should be redirected to the profile page. The save button should be disabled or throttled after the first click.
Actual Result:
The save button sends multiple requests and keeps the user on the upload page until they stop clicking.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.98-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/231262832-ea7c2ae5-20ca-40d4-9bfd-4d349c7f6eec.mp4
https://user-images.githubusercontent.com/43996225/231262978-8568ce79-df6e-46cc-883c-1d0e6264b8af.mp4
Expensify/Expensify Issue URL:
Issue reported by: @nathan-mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681205238881809
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01671170d7fd17cd5a
Upwork Job ID:<PHONE_NUMBER>891558400
Last Price Increase: 2023-04-12

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~01671170d7fd17cd5a

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Tapping the "Save" button in rapidly multiple times results in multiple requests being sent and keeps the user on the page.
What is the root cause of that problem?
The button is dispatching multiple events due to the repeated presses which trigger the actions repeatedly. This is due to the lack of debouncing to prevent the same action being repeated quickly.
What changes do you think we should make in order to solve the problem?
Disable the button immediatelg after it's pressed, and then re-enable it the button once the request is completed.
What alternative solutions did you explore? (Optional)
None.

Please re-state the problem that we are trying to solve in this issue.
Multiply calls to "Save" button onClick handler results in multiple requests to API and prevents navigation.
What is the root cause of that problem?
This happens because we allow multiple calls to button handler
What changes do you think we should make in order to solve the problem?
We can throttle the function passed as onClick handler

Proposal
Please re-state the problem that we are trying to solve in this issue.
Multiply calls to "Save" button onClick handler results in multiple requests to API and prevents navigation.
What is the root cause of that problem?
Root cause of the problem is not disabling button while click happens.
What changes do you think we should make in order to solve the problem?
We can use lodash throttle method to disable multiple presses on button preventing multiple request added to queue.
File to modify with code below (AvatarCropModal)
const cropAndSaveImage = useCallback(throttle(() => {
        ...
    }, 3000, {trailing: false}), [...]);

What alternative solutions did you explore? (Optional)
We can use custom made 'throttle' handling with useEffect and setTimeout but lodash seems like better solution.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Tapping Avatar photo "Save" button rapidly results in multiple requests being sent and prevent page navigation.
Same problem happen when saving User Avatar as well as Workspace Avatar.
What is the root cause of that problem?
Save button is still pressable when we are waiting for cropAndSaveImage to complete.
We should disable it when Save is being processed.
What changes do you think we should make in order to solve the problem?
The problem happens to both Profile and Workspace Avatar, we want to implement consistent approach to resolve problem in both pages.
At the moment, AvatarWithImagePicker.js is already having props.isUploading, it is being set to props.policy.isAvatarUploading within WorkspaceSettingsPage.js (not set for User Profile page yet, more on that below), I propose reuse the same props for the fix, by adding props.isUploading to AvatarCropModal.js component (default to false), and use it to set the Save Button isLoading props
e.g.
            <Button
                success
                style={[styles.m5]}
                onPress={cropAndSaveImage}
                pressOnEnter
                text={props.translate('common.save')}
                isLoading={props.isUploading}
            />

The changes above would fix the problem for Workspace Avatar; As for User Avatar, we need to modify PersonalDetails.js updateAvatar action to add a new currentUser personalDetails bool field named isAvatarUploading
Note: simplified for brevity
    const optimisticData = [{
        onyxMethod: CONST.ONYX.METHOD.MERGE,
        key: ONYXKEYS.PERSONAL_DETAILS,
        value: {
            [currentUserEmail]: {
                ...
                isAvatarUploading: true,
            },
        },
    }];
    const successData = [{
        onyxMethod: CONST.ONYX.METHOD.MERGE,
        key: ONYXKEYS.PERSONAL_DETAILS,
        value: {
            [currentUserEmail]: {
                ...
                isAvatarUploading: false,
            },
        },
    }];
    const failureData = [{
        onyxMethod: CONST.ONYX.METHOD.MERGE,
        key: ONYXKEYS.PERSONAL_DETAILS,
        value: {
            [currentUserEmail]: {
                ...
                isAvatarUploading: false,
            },
        },
    }];

This field will then be usable in ProfilePage.js to populate the props.isUploading for AvatarWithImagePicker component used in the page.
e.g.
    <AvatarWithImagePicker
        isUploading={lodashGet(props.currentUserPersonalDetails, 'isAvatarUploading', false)}
        isUsingDefaultAvatar={ReportUtils.isDefaultAvatar(lodashGet(currentUserDetails, 'avatar', ''))}
        source={ReportUtils.getAvatar(lodashGet(currentUserDetails, 'avatar', ''), lodashGet(currentUserDetails, 'login', ''))}
        onImageSelected={PersonalDetails.updateAvatar}
        onImageRemoved={PersonalDetails.deleteAvatar}
        anchorPosition={styles.createMenuPositionProfile}
        size={CONST.AVATAR_SIZE.LARGE}
    />

Applying the proposed changes above would resolve the problem in both User Avatar and Workspace Avatar in consistent manner.
What alternative solutions did you explore? (Optional)

📣 @honnamkuan! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e4e8672c242b9da0

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@Beamanator Are there any planned changes to the profile avatar page that are already happening as per Account Settings design doc?
The issue is:

The save button should be disabled or throttled after the first click

But I am thinking that this behavior would be provided by using the Form component by default. And if we aren't using it now maybe we had some plans to do so in a push to page fashion?

@marcaaron No changes planned for Account Settings doc. The only final changes left for that doc are related to contact methods.
But we might do a few modifications via the Onboarding doc? Does the Form component throttle submissions? I don't think I've ever seen that before :think

Not quite throttle. If you are submitting then you can't submit again the logic is here:
https://github.com/Expensify/App/blob/1f535603b57c64e37938c326c9a4d3a39377481e/src/components/Form.js#L150-L154

@eVoloshchak, @marcaaron, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@eVoloshchak @marcaaron are we going with any of these proposals or still waiting for tweaks before committing to one?

@akinwale, your proposal uses setTimeout, which is highly discouraged unless absolutely necessary. Is there a reason we should be using it, or is there another way?
@alexxxwork's and @KevinBdev  proposals would technically work, but I think using _.throttle is a workaround, which doesn't resolve the root cause. Additionally, it would still break if the image takes longer to upload than our throttle period.
@honnamkuan's proposal looks promising, but we can achieve the same result with @Ollyws's proposal, which is much simpler.
@Ollyws's proposal looks good to me. It's short and simple, and does precisely what we need to do.
However, WorkspaceSettingsPage uses Form, which, as @marcaaron has mentioned above, already has a logic for not submitting the form if the form is already submitting. I think we should try to use the universal logic if possible, especially when it comes to something as widely used as submitting a form.
@Ollyws, can we use this logic? If the answer is yes, we'll also need to use Form on ProfilePage

@Ollyws, makes sense, thank you
I think we should proceed with @Ollyws's solution, it's simple and universal (we're making changes only to AvatarCropModal component, so the problem will be resolved for all pages)
🎀👀🎀 C+ reviewed
cc: @marcaaron

@akinwale, your proposal uses setTimeout, which is highly discouraged unless absolutely necessary. Is there a reason we should be using it, or is there another way?

During testing, I noticed that the button could reappear before the modal was dismissed, and if the user clicked on the button again, with the chance to click repeatedly the modal would not actually close. With this timeout, the button is set to only reappear after the modal has been closed, for the next time it's open.

I think we might want to check if this is still reproducible
This should have been fixed by https://github.com/Expensify/App/pull/17326, the logic there is almost identical to @Ollyws's proposal

I think we might want to check if this is still reproducible
This should have been fixed by https://github.com/Expensify/App/pull/17326, the logic there is almost identical to @Ollyws's proposal

@eVoloshchak The problem still occurs on staging. I just verified it.
https://user-images.githubusercontent.com/111440031/232562011-8f4e50fe-0a48-4668-817a-8d5d7310c316.mp4

@Nathan-Mulugeta, thanks for verifying!
I think currently you can't submit image multiple times by pressing Save multiple times (thanks to this line), but the button is still active while the image is uploading.
So adding a loading spinner would be a good addition.
@Ollyws, could you please update your proposal incorporating changes that have already been made in https://github.com/Expensify/App/pull/17326?

Hey @eVoloshchak did you notice how the profile picture flickers repeatedly? I think it matches the number of times the save button is clicked. Isn’t that uploading the image multiple times?

@Nathan-Mulugeta , oh, it turns out https://github.com/Expensify/App/pull/17326 wasn't deployed to staging just yet , so we were testing different code :)

📣 @Ollyws You have been assigned to this job by @marcaaron!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@marcaaron, this was already fixed by https://github.com/Expensify/App/pull/17326
The only thing we could add here is a loading spinner while the image is uploading

Ah thanks, let's close it then. Loading spinner sounds like an improvement we should discuss separately from this bug report and is more of a feature request I think.

Hello, @marcaaron. I would like to bring to your attention that I reported this bug before it was fixed by a PR. As per the contributors guideline, I have verified the dates and it shows that my bug report was submitted before this #17326 PR that fixed it. Could you please review this and let me know if I qualify for the compensation for my bug report?

Hey @Nathan-Mulugeta feel free to raise any concerns in the #expensify-open-source room, thanks!

Okay thanks for replying @marcaaron .


Code separation for supporting block and file storage types

What this PR does / why we need it:
This PR is for the code separation for supporting block and file storage types
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
https://github.com/opensds/nbp/issues/269
Special notes for your reviewer:
The modification highlights:

csi/client directory removed as it is not used anymore
csi/common package is added to handle the flows common to both file and block storage support
csi/server is removed and subfolders are reorganized
csi/plugins contains code specific to the respective plugin
csi/cmd directory contains docker files and main functions for both plugins
Makefile and README updated accordingly
deployment/example yamls are updated
wiki need to be updated and it will be handled through another PR

Detailed Test report:
Test Report.zip
Release note:

Sushanth Please check the branch


clang: error: linker command failed with exit code 1 (use -vto see invocation

I am using the visit_libsim_mandelbrot_example for the purpose of in situ visualtion with LibSim+ Visit. The code is present on the below page of VisIt tutorial page
http://visitusers.org/index.php?title=VisIt-tutorial-in-situ#Building_the_example
I am using the Makefile with my changes included below:
Makefile for building mandelbrot simulation using libsim.
###############################################################################
############################## USER EDIT SECTION ################################
Fill in the Path to the VisIt installation. This is the directory that contains
VisIt's 2.13.0 directory. Mac users may want to
use /path/to/VisIt.app/Contents/Resources to locate the "visit" directory
within an app bundle.
VISITHOME=/home/muzafar/Downloads/installations
Set this to the version of VisIt that you use
VISITVERSION=3.1.4
Choose one, depending on your system architecture
#VISITARCH=darwin-x86_64
VISITARCH=linux-x86_64
Edit your compiler and its settings
CXX=clang++
CPPFLAGS=
CXXFLAGS=-O3
LDFLAGS=
LIBS=
#################################################################################
SIMDIR=$(VISITHOME)/$(VISITVERSION)/$(VISITARCH)/libsim/V2
SIM_CXXFLAGS=-I$(SIMDIR)/include
SIM_LDFLAGS=-L$(SIMDIR)/lib
SIM_LIBS=-lsimV2 -ldl
SRC=mandelbrot.C patch.C
OBJ=$(SRC:.C=.o)
SRC_BATCH=mandelbrot_batch.C patch.C
OBJ_BATCH=$(SRC_BATCH:.C=.o)
all: mandelbrot mandelbrot_batch
clean:
rm -f mandelbrot mandelbrot_batch $(OBJ)
mandelbrot: $(OBJ)
$(CXX) -o mandelbrot $(OBJ) $(LDFLAGS) $(SIM_LDFLAGS) $(SIM_LIBS) $(LIBS)
mandelbrot_batch: $(OBJ_BATCH)
$(CXX) -o mandelbrot_batch $(OBJ_BATCH) $(LDFLAGS) $(SIM_LDFLAGS) $(SIM_LIBS) $(LIBS)
.C.o:
$(CXX) $(CXXFLAGS) $(SIM_CXXFLAGS) $(CPPFLAGS) -c $<
and the Error I am getting is described as below. I am not able to figure out what the issue is
muzafar@MUZI:~/Downloads/visit_libsim_mandelbrot_example$ make
clang++ -o mandelbrot mandelbrot.o patch.o  -L/home/muzafar/Downloads/installations/3.1.4/linux-x86_64/libsim/V2/lib -lsimV2 -ldl
patch.o: file not recognized: file format not recognized
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:47: mandelbrot] Error 1
Can anyone let me know what I have done wrong

We chatted a bit about this issue and suspect that you have inadvertently wound up mixing different versions of stuff which may be hanging around on different sites and/or that maybe you've done this example at some point in the distant past (producing patch.o with whatever tools you had then) and upon re-trying it now (after possibly updates to tools), you are encountering an issue.
Best thing is to start from a clean slate...
This example is tested in our nightly testing...

https://github.com/visit-dav/visit/blob/develop/src/test/tests/simulation/mandelbrot.py
https://visit-dav.github.io/dashboard/2021-08-28-22:00/pascal_trunk_serial/simulation_mandelbrot.html

@biagas and @brugger1 and @BradWhitlock I worry that perhaps in #4503 I removed instances of Makefile.in that I thought were obsoleted by transition to CMake but which were actually there to facilitate stand-alone builds of these examples without requiring anyone to have CMake. Can you have a look?

@biagas ... might you know how to run this example outside of any dependence on the test suite or other developer-related stuff? I think that might be the key issue for this user...how to make this work stand-alone...with a version of VisIt maybe which is a binary download and maybe vanilla make.

@markcmiller86 not offhand.  Might be good to download the example referenced above from visit-users and see what may need to be tweaked in the Makefile provided there. Also, see if the actual source has changed any.

Ok, found the problem. The tarball dataset is http://portal.nersc.gov/project/visit/cyrush/2018_02_ecp/visit_libsim_mandelbrot_example.tar.gz and when I download it, I find there is a patch.o file inside it already....
cleanup.sh
go_mandelbrot_batch.sh
go_mandelbrot.sh
Makefile
mandelbrot_batch.C
mandelbrot.C
mandelbrot.ui
patch.C
patch.h
patch.o
SimulationExample.h

So, the tarball that got downloaded isn't clean and when the user went to rebuild, patch.o is for a different architecture. @MuzafarWani try removing ALL the .o files there and remaking and see if you get further.

@markcmiller86 It did work after removing the ALL .o files.
I tried to follow all the steps for running the simulation and accessing the data using visit but it is not working.
trace.txt
Once I start running the simulation in one terminal with the command
./mandelbrot -trace trace.txt
On another terminal I run the visit but after the step
There should be a file ######.mandelbrot.sim2 that you'll want to open. If there are multiple files that match that pattern then open the most recent one.
the terminal one which is running the simulation shows "VisIt did not connect: Failed to open the VisIt library: (null)"
and I am not able to access anything using the UI of VISIT. I have attached the trace file. What am I missing here. Please let me know.

@MuzafarWani thanks for the trace file. That helps.
The key issue I see in that trace file I think is this...

Calling dlopen(libsimV2runtime_ser.so)
Failed to open the VisIt library: libsimV2runtime_ser.so: cannot open shared object file: No such file or directory

I have tried repeating your steps and was experiencing similar problems with a binary download install. However, I had a little more success using my own build of develop. Did you try the -dir <path-to-visit-home> command-line argument to the ./mandelbrot? That made the difference for me. I think it would be...
./mandelbrot -trace trace.txt -dir /home/muzafar/Downloads/installations/3.1.4/linux-x86_64

@biagas and @brugger1 FYI...this example does work with develop. I did run into a few things though and will put those issues in #16989

If you take a look at trace.txt does anything stand out for you?
I see there...
LoadVisItLibrary
Calling dlopen(libsimV2runtime_ser.so)
Failed to open the VisIt library: libsimV2runtime_ser.so: cannot open shared object file: No such file or directory

Calling getenv(LD_LIBRARY_PATH)
LoadVisItLibrary Failed to open the VisIt library: (null)

That hints at something.
Can you confirm libsimV2runtime_ser.so exists in your VisIt installation?
find /home/muzafar/Downloads/installations/3.1.4/linux-x86_64 -name libsimV2runtime_ser.so

You should see something like this after running that command (below is from my mac and things are named a little differently there but its the same idea...
find /Applications/VisIt.app/Contents/Resources/ -name libsimV2runtime_ser.dylib
/Applications/VisIt.app/Contents/Resources//3.2.0/darwin-x86_64/lib/libsimV2runtime_ser.dylib

If  libsimV2runtime_ser.so is there try setting LD_LIBRARY_PATH to the directory containing it before running mandelbrot. For example...
env LD_LIBRARY_PATH/home/muzafar/Downloads/installations/3.1.4/linux-x86_64/lib ./mandelbrot -trace trace.txt -dir /home/muzafar/Downloads/installations/3.1.4/linux-x86_64

or, if your env. already has LD_LIBRARY_PATH set to some value...
env LD_LIBRARY_PATH=/home/muzafar/Downloads/installations/3.1.4/linux-x86_64/lib:$LD_LIBRARY_PATH ./mandelbrot -trace trace.txt -dir /home/muzafar/Downloads/installations/3.1.4/linux-x86_64

If none of these ideas work, I think we are out of options.

FYI...I've tried similar steps but on a Linux system instead of my macOS system...I have been UNable to get it to work on Linux and I've tried a lot of different things.
I suspect that we haven't tested running a libsim example from outside of our regular development environments in quite some time (like myabe before we updated osmesa) and we're hitting some new issues.
@ARSanderson you use libsim quite a bit. Does any of this sound familiar?

@markcmiller86  Thanks for you replies
**Can you confirm libsimV2runtime_ser.so exists in your VisIt installation?**_
Yes it is in visit. It exists in two locations one is /home/muzafar/Downloads/installations/3.1.4/linux-x86_64/lib and second one is
/home/muzafar/Downloads/installations/current/linux-x86_64/lib. I set LD_LIBRARY_PATH varaiable to both of the locations but it is still showing
LoadVisItLibrary
Calling dlopen(libsimV2runtime_ser.so)
Failed to open the VisIt library: libsimV2runtime_ser.so: cannot open shared object file: No such file or directory
Calling getenv(LD_LIBRARY_PATH)
LoadVisItLibrary Failed to open the VisIt library: (null)
Will the example work on windows system.
Also there are few other links mentioned on page
One is: https://github.com/visit-dav/visit/tree/develop/src/tools/data/DataManualExamples/Simulations
Another one is : https://github.com/visit-dav/visit/tree/develop/src/tools/data/DataManualExamples/Simulations/contrib/pjacobi/
Another Link is: https://github.com/visit-dav/visit/tree/develop/src/tools/data/DataManualExamples/Simulations
Will any of the above work on linux system. I want to run one example and then follow the same procedure for the application:
https://github.com/mrnorman/miniWeather

@markcmiller86 I resolved the issue. the code worked on a different version of ubuntu os. Thank you for your help.
The source code of mandelbrot simulation contains code which calls visit. I tried to find the code of mandelbrot simulation without the visit code so that I can understand the changes needed to be done to make a simulation work with visit. Can you please point me where the source code of mandelbrot is without visit code.

@MuzafarWani I worry that the mandelbrot example may not have been written as a stand-alone simulation into which libsim has been integrated. Instead, I think mandelbrot is merely trying to exercise and show the power of the libsim interface and so there likely isn't a version of mandelbrot without the libsim and just the simulation.

@MuzafarWani you might find the progression of examples shown in the sim*.c examples here helpful. The first, sim1.c has no VisIt stuff in it. The next several, sim2.c, sim3.c, ... have progressively more VisIt stuff.
Also, there are a number of other examples in that directory that might be helpful.


Show depositor default embargo terms and other sharing rules during upload process

During upload process, query the OA Button Permissions API (or Sherpa Romeo) and display default sharing rules for the particular article version. Sharing rules can include an embargo, a license, and/or a set statement that should accompany deposit. Allow depositor to override these defaults. For items not found in the OAB Permissions API, encourage depositor to contact<EMAIL_ADDRESS>Implementing shareyourpaper.org (#73) would probably take care of this. Update: We decided not to do that.

@anaelizabethenriquez I ran some analysis on the OAB permissions API with a sampling of several thousand Publications we have in RMD.  I also downloaded what OAB claims to be all their data as a CSV.  What I was finding in the API seems to match up with the CSV, except that I was finding some publications in the API with a "cc0" license and "None".  The comprehensive list looks like this:
CC-BY-NC-ND
CC-BY-NC
Other (non-commercial)
Other-closed
CC-BY-NC-SA
unclear
CC-BY
CC-BY 3.0
CC-BY 4.0
cc0
None
Here is what's in our dropdown:

Some of the licenses look like they map to something in our dropdown.  Perhaps we can just ignore ones that are "None", "unclear", or blank.  The "Other-closed" and "Other (non-commercial)" ones I am not too sure about.  Also, there is one that is just "CC-BY" and another that is "CC-BY 3.0" that I'm not too sure about either.  Do you know if these can be mapped to anything we have?

Here's how I would map (I think we can map everything):

API value
RMD list

CC-BY-NC-ND
CC BY-NC-ND 4.0

CC-BY-NC
CC BY-NC 4.0

Other (non-commercial)
All rights reserved

Other-closed
All rights reserved

CC-BY-NC-SA
CC BY-NC-SA 4.0

unclear
All rights reserved

CC-BY
CC BY 4.0

CC-BY 3.0
CC BY 4.0

CC-BY 4.0
CC BY 4.0

cc0
CC0 1.0 Universal

None
All rights reserved


ADDED : Flutter & Dart - The Complete Guide [2020]

This is one of my first PR and I've added one of the best Flutter Course I've seen till now and have also been through this awesome course. Hope, my developer fellows benefit from this addition!

Hey @Aarju02 ! Thank you for taking out the time to contribute to this project and thanks for creating a PR.
However, I'm sorry I can't merge this PR, because as per the contributing guidelines, only PR submissions which include free resources are valid. Please either commit the changes in this PR or close this one and create a new PR, with a free course.

Hey @Aarju02 !
Congrats on submitting your pull request. Your PR has been merged and the changes will be reflected on the website in a few minutes,.
Do leave a star, if you liked the repo ;)
Happy hacking ! 🎊

Hey, thanks for the acceptance and for helping all of us out to improve through your repo!
Have a great day!


wind QC

We want to implement a wind QC in level1e script.

0 km/h <= WS < 500 km/h
0° <= WD < 360 °
WS == 0 -> WD == 0

Hi @sjnoone, we are trying to implement a wind QC in our marine processing tool. I hope you can help us with these questions:

How do you differentiate between calm wind and baffling wind in your glamod_land QC?
What values do you set in your CDM observations-wd tables for these two wind "directions"? calm wind -> 0.0; bafflin wind -> 99.0?
Do you know how the models interpret the data?

I think we should both set the same values for both calm and baffling wind in our CDM tables.

Hi @ludwiglierhammer the best person to talk to about QC for wind is Robert Dunn @rjhd2 but he is on leave until early August.
best
Simon

@sjnoone: Thanks for your fast reply.

Hi @sjnoone, we are trying to implement a wind QC in our marine processing tool. I hope you can help us with these questions:

How do you differentiate between calm wind and baffling wind in your glamod_land QC?
What values do you set in your CDM observations-wd tables for these two wind "directions"? calm wind -> 0.0; bafflin wind -> 99.0?
Do you know how the models interpret the data?

I think we should both set the same values for both calm and baffling wind in our CDM tables.

Hi @rjhd2, could you please help us with these questions?

Hi @rjhd2, thanks for your reply.

Do you mean variable direction?

Yes, this is exactly what I meant. Sorry for the confusion.

For Variable wind (and also some Calm wind measurements), the subdaily data sometimes come with "V-Variable" or "C-Calm" comments in the wind_direction_Measurement_Code field. If these are present and the wind_direction measurement 999 then in my QC scripts I convert that to a np.nan which is then removed on writing back out to our final files.  Our system is that missing or flagged data are just not listed at all (empty data field) so this makes things consistent.  These flag comments are retained in the data files, so that users can see what was done.
One of the sets of wind QC checks is a set of logical arguments, so that directions are 1-360 for non-zero wind speeds, and 0N for calm winds etc.  But it is possible for a wind speed to exist without a direction (e.g. in the case of a "V-Variable" flag), though we don't do any specific QC on the observations with variable directions.  If there are conventions to follow, then I'm happy to do this - though would need to be careful with any choice of value to use.
I don't know how any models or reanalyses use the variable wind information, I'm afraid.

Thanks for your detailled reply, @rjhd2.
In our ICOADS data, wind direction of calm winds is given as 361° and direction of variable winds as 362°.
Do you know this denotation in your input data?
Just for my understanding (after your QC):

calm winds: direction is 0; speed is 0
variable winds: direction is np.nan; speed is any value

Is this right?
Our wind QC, which has not yet been implemented, flags the following:

speed < 0 m/s
speed > 99.9 m/s (in our ICOADS data there are only 3 digits for wind speed)
direction < 0°
direction > 360°
speed == 0 m/s and direction != 0° (calm winds)
speed != 0 m/s and direction == 0° (variable winds; maybe we should set direction to np.nan in this cases tobe consistent with you, isn't it?)

Is this similar to your wind QC?
Sorry for all those questions. I just try to untie the knot in my head 😵

In order.
I've not come across that notation for calm and variable winds before.  Our QC flags directions >360 (northerly winds). However, if this is a common way of presenting these two specific wind conditions, then it's something we could investigate to include in our QC.
If our wind speed=0, then direction should =0.  If no direction is given (no data or masked) then we could recover the direction if we presume the wind speed is correct.  If direction !=0 is given then we flag that.
We don't try and do anything with a variable direction - this flag may be in another column from the input source, but in that case we just have a speed value and a missing value for the direction at the moment.
The subdaily land-QC script is this one  We follow a table of logical checks from Table 2 in De Gaetano et al.
So some of your checks are the same but there are some conventions within that paper that we follow (e.g., that calm winds speed=0 have direction=0, but then northerly winds speed >0 have direction=360).  The maximum speed is checked by our world records check (113.2m/s) - granted this is from a TC, but it's the value thats listed on the WMO records  page.
Any values which are removed (we've got an open ticket about the direction=0/360 convention) are set to np.nan, but these are then removed from the datastream when we write out the final files.
Does some of that help?

Many thanks for your explanation. This will help us a lot.
I haven't seen this notation anywhere else either.

Your land QC looks quite similar to ours 👍

@aanderss: How should we deal with both wind directions 361 and 362?

Hi @rjhd2, I have a few more questions about your landQC workflow.

Do you also map your input data to the CDM likewe do? I think so, but I am not entirely sure.
If so, is your output format similar to ours?
And could you please show me your input and output data?
When exactly do you perform your QC in your workflow? We use it after mapping the input data to the CDM.

These questions are just for my understanding. Also, I am trying to make things similar/consistent since we are working in the same project.
Thanks a lot!

We've got two stages of data formatting.  The first is converting to the standardised format (IFF) that we use for the subdaily from the individual sources.  Subsequent processing occurs to mingle stations together (MFF) and then QC them (QFF).  As the files are used by NOAA and C3S we then have a separate reformatting stage which converts only those elements to the CDM.  Unfortunately there's not a full link from the repo that does that reformatting (glamod_nuim) to the CDM definitions and tables (yet).
I will leave it to @sjnoone to confirm the similarity in the outputs of the CDM formatted in-situ sub-daily files as I'm not that familiar with them.  However from a glance, they do look similar, yes.
For the input and output data, do ping me an email and I can send an example file.  I've got plans to include tests in my QC repo in the next 6 months, so some example files will appear then, but there aren't any in the repo at the moment.

[Email with example input and output data sent]

@aanderss: How should we deal with both wind directions 361 and 362?

Convert these ICOADS specific wind directions as stated in the comment above
361/calm winds: direction is 0; speed is 0
362/variable winds: direction is np.nan; speed is any value
This conversion should be implemented in the initial format conversion with mdf reader/mapper,

Issue fixed in https://github.com/glamod/glamod-marine-processing/pull/22


ng build -prod + AsyncRoute (router-deprecated)

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Mac El Capitan

Versions. Please run ng --version. If there's nothing outputted, please
run in a Terminal:
node --version
And paste the result here.

v4.2.6

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.

Create an app ng new TestProdBuild
Create a route ng g route test
Adding a link to the main component to check if the route is working.

ng build -prod is working properly

Replacing the router with the router-deprecated (changed package.json and system-config.ts)
Change the router annotation to use the Sync routing

ng build -prod is working properly

Use AsyncRoute and obviously the loader tries to load the js file (that doesn't exist)

The log given by the failure. Normally this include a stack trace and some
more information.

After the step 6 I get this in the browser:
zone.js:101 GET http://localhost:8181/app/+test/index.js 404 (Not Found)
EXCEPTION: Error: Uncaught (in promise): Error: Error: XHR error (404 Not Found) loading http://localhost:8181/app/+test/index.js
  at XMLHttpRequest.wrapFn [as _onreadystatechange] (http://localhost:8181/vendor/zone.js/dist/zone.js:769:30)
  at ZoneDelegate.invokeTask (http://localhost:8181/vendor/zone.js/dist/zone.js:356:38)
  at Object.inner.inner.fork.onInvokeTask (http://localhost:8181/main.js:19:22470)
  at ZoneDelegate.invokeTask (http://localhost:8181/vendor/zone.js/dist/zone.js:355:43)
  at Zone.runTask (http://localhost:8181/vendor/zone.js/dist/zone.js:256:48)
  at XMLHttpRequest.ZoneTask.invoke (http://localhost:8181/vendor/zone.js/dist/zone.js:423:34)
Error loading http://localhost:8181/app/+test/index.js

@filipesilva that was my problem, what are my options here? Should I avoid AsyncRoute until we get the new (new) router?
Thanks,
Dem

This... doesn't work at all at the moment. Bundling in the CLI didn't get as far as async routers yet, unfortunately.

Work working on getting async loading to work, but only on the new router. I don't have any details to share but since we're not focusing on the deprecated router anymore, I'll close this issue.


How to extend Swagger UI to support basic authorization?

Hi there,
sorry for the basic question but i'm totally lost. I'm trying to use Swagger UI with a Web API that uses basic authorization. I know that i have to add a HTTP header for basic authorization but how do i do that in NSwag? I'm currently trying to copy & paste & adjust various code samples from the internet for my Startup.cs but all these examples are based on OAuth or JWT. Anyone can help?
My current findings:
Basic authorization in repo NSwag.AzureFunctionsV2 (does not work obviously as classes are missing)
https://github.com/Jusas/NSwag.AzureFunctionsV2#advanced-usage
Some example configurations but those are not targeting basic authentification
https://github.com/RicoSuter/NSwag/wiki/AspNetCore-Middleware#enable-api-key-authentication
So lonG

Did you try using this enum value:
https://github.com/RicoSuter/NSwag/blob/master/src/NSwag.Core/OpenApiSecuritySchemeType.cs#L21
?

Not relevant anymore for me, using OIDC with implicit flow now


Understanding hcxdumptool output , PMKIDs (zeroed and useless) ?

Hi there,
I am launching this attack to some of my routers succesfully before,
Now I've changed and I'm doing it with some other newones , and for some reason I am getting just 2 PMKIDS when I use to have like more than 6
This is the output I get after  putting the following input.
_root@kali:~# hcxdumptool -i wlan1mon -o sberXXXXX.pcapng --enable_status=1
initialization...
warning: wlan1mon is probably a monitor interface
interface is already in monitor mode
start capturing (stop with ctrl+c)
NMEA 0183 SENTENCE........: N/A
INTERFACE NAME............: wlan1mon
INTERFACE HARDWARE MAC....: 00c0ca96b1d9
DRIVER....................: rt2800usb
DRIVER VERSION............: 5.3.0-kali2-amd64
DRIVER FIRMWARE VERSION...: 0.36
ERRORMAX..................: 100 errors
FILTERLIST ACCESS POINT...: 0 entries
FILTERLIST CLIENT.........: 0 entries
FILTERMODE................: 0
WEAK CANDIDATE............: 12345678
PREDEFINED ACCESS POINT...: 0 entries
MAC ACCESS POINT BROADCAST: 4876048f206b
MAC ACCESS POINT..........: 4876048f206c (incremented on every new client)
MAC CLIENT................: c8aacc11eb69
REPLAYCOUNT...............: 63833
ANONCE....................: d3d821027bac5443166495d06b3f928ed027c1f341ed93a32a70e8c049ae7cc3
SNONCE....................: 5440d9011830720d7946618188dafb6768f1a93da09631a987bfc0d301dcbd4d
21:30:02   6 020fb511eb69 <-> b8ee0edc4588 MP:M1M2 RC:0 EAPOLTIME:4816 (BTHub6-XXXX)
21:30:02   6 020fb511eb69 <-> b8ee0edc4588 MP:M2M3 RC:1 EAPOLTIME:4591 (BTHub6-XXX)
21:30:22  10 c8aacc11eb69 <-> e4a7c58fe46e PMKID:03a7d262d18dadfac106555cb02b3e5a (XXXX)
21:34:29   4 50dce793923c <-> d80d17b01042 MP:M1M2 RC:63833 EAPOLTIME:18569 (XXXXX)
21:34:29   4 50dce793923c <-> d80d17b01042 MP:M2M3 RC:2 EAPOLTIME:3335 (XXXXXX)
21:34:51   6 a8e5440e91dd <-> 342eb6534f22 MP:M1M2 RC:3 EAPOLTIME:28274 (XXXXXX)
21:37:03  11 6cc7ec9ae7f3 <-> bca5111434c8 MP:M1M2 RC:1 EAPOLTIME:6143 (XXXXXXX)
21:38:08   3 14205ece9987 <-> b8c1a2642040 MP:M1M2 RC:0 EAPOLTIME:130530 (XXXXXXX)
21:38:47   4 cc50e3527ef9 <-> 4876048f207b MP:M1M2 RC:63833 EAPOLTIME:9369 (XXXXX)
21:42:07  10 c0eefbd7f0e8 <-> 0c8063a465a8 MP:M2M3 RC:2 EAPOLTIME:3371 (XXXXXX)
21:47:47   3 5c7776913ddd <-> 4876048f206f MP:M1M2 RC:63833 EAPOLTIME:78069 (blackberry)
21:49:43   1 c048e6f2b52c <-> 4c1b86b5e39e MP:M1M2 RC:63833 EAPOLTIME:54867 (BT-XXXX)
21:52:59   6 bc98df062aa2 <-> d05794b19bb8 MP:M1M2 RC:63833 EAPOLTIME:111927 (XXXXX)
22:00:11   8 7c2a314055ce <-> 4876048f2089 MP:M1M2 RC:63833 EAPOLTIME:141684 (XXXXX)
22:04:45  11 020fb51990c9 <-> b8ee0eddb4c2 MP:M1M2 RC:63833 EAPOLTIME:11049 (BTHub6-XXXXX)
22:05:47   6 c49ded1b9b29 <-> 6ecb4d65d6de MP:M1M2 RC:63833 EAPOLTIME:9889 (iPhone)
22:09:00  11 a45046ebde97 <-> 40313c90220f MP:M2M3 RC:2 EAPOLTIME:3018 (BTHub6-XXXXXX)
22:14:27   3 7c2a314055ce <-> ac3b7702a69e MP:M1M2 RC:63833 EAPOLTIME:35285 (XXXXX)
22:15:26  11 c0e8621990c9 <-> 18c5014b03d8 MP:M1M2 RC:2 EAPOLTIME:7142 (EXT2-BTHub6-XXXX)
22:15:26  11 c0e8621990c9 <-> 18c5014b03d8 MP:M2M3 RC:3 EAPOLTIME:22938 (EXT2-BTHub6-XXXX)
22:16:20   1 020fb53b2089 <-> 5890432a2470 MP:M1M2 RC:63833 EAPOLTIME:14804 (BTHub6-XXX)
22:21:14   6 c49ded1b9b29 <-> ce4b1b8e9326 MP:M1M2 RC:63833 EAPOLTIME:6875 (iPhone)
22:25:06   3 047295239e9b <-> 4876048f2099 MP:M1M2 RC:63833 EAPOLTIME:16940 (BTHub6-XXX)
22:28:08   6 c49ded1b9b29 <-> 2ac02d3c5a16 MP:M1M2 RC:63833 EAPOLTIME:18735 ()
22:28:14  11 c49ded1b9b29 <-> 1e3483e9e2f9 MP:M1M2 RC:63833 EAPOLTIME:19336 (iPhone)
22:32:27   6 a477331d5c56 <-> ac3b7702806a MP:M1M2 RC:63833 EAPOLTIME:49890 (BTHub6-XXXX)
22:38:22  11 18810e5e2da9 <-> c83a35f3a2b0 MP:M1M2 RC:0 EAPOLTIME:23963 (EXT-XXXXX)
22:48:05   4 a20460eaa829 <-> b8ee0edc17f2 MP:M1M2 RC:63833 EAPOLTIME:12500 (BTHub6XXX)
22:59:35   1 94fb293a0293 <-> 4876048f209e MP:M1M2 RC:63833 EAPOLTIME:138163 (XXXXX)
23:00:10   6 806c1bc3e46c <-> 08d59da2110c MP:M1M2 RC:0 EAPOLTIME:3568 (BTHub6-XXX)
23:06:06  11 d89c67ce490d <-> 589043c3a69c MP:M1M2 RC:63833 EAPOLTIME:35047 (BTHub6-XXX)
23:29:43   4 60f4455a0bf3 <-> b8ee0edcd642 MP:M1M2 RC:63833 EAPOLTIME:5009 (BTHub6-XXXX)
23:32:59   8 c49ded1b9b29 <-> a00460eaa829 MP:M1M2 RC:63833 EAPOLTIME:83953 (BTHub6-TXXXT)
23:42:50   6 2816a85a4674 <-> 50d4f7aadc93 MP:M1M2 RC:63833 EAPOLTIME:7735 (BTHub6-XXXX)_
Of those when I do the conversion to hashcat readable files it  only gets me 2 PMKIDS

_root@kali:~# hcxpcaptool -E essudkust -I identitylist -U usernamelist -z sbeXXXXXX.16800 sberXXXXXX.pcapng
reading from sbXXXXXX.pcapng
summary capture file:
file name........................: sXXXXXX.pcapng
file type........................: pcapng 1.0
file hardware information........: x86_64
capture device vendor information: 00c0ca
file os information..............: Linux 5.3.0-kali2-amd64
file application information.....: hcxdumptool 6.0.1 (custom options)
network type.....................: DLT_IEEE802_11_RADIO (127)
endianness.......................: little endian
read errors......................: flawless
minimum time stamp...............: 20.02.2020 21:29:27 (GMT)
maximum time stamp...............: 20.02.2020 23:44:29 (GMT)
packets inside...................: 7017
skipped damaged packets..........: 0
packets with GPS NMEA data.......: 0
packets with GPS data (JSON old).: 0
packets with FCS.................: 0
beacons (total)..................: 347
beacons (WPS info inside)........: 94
beacons (device info inside).....: 1
probe requests...................: 138
probe responses..................: 251
association requests.............: 34
association responses............: 90
reassociation requests...........: 12
reassociation responses..........: 24
authentications (OPEN SYSTEM)....: 137
authentications (BROADCOM).......: 62
authentications (APPLE)..........: 8
EAPOL packets (total)............: 5984
EAPOL packets (WPA2).............: 5984
PMKIDs (zeroed and useless)......: 194
PMKIDs (not zeroed - total)......: 2
PMKIDs (WPA2)....................: 203
PMKIDs from access points........: 2
best handshakes (total)..........: 34 (ap-less: 23)
best PMKIDs (total)..............: 2
summary output file(s):
2 PMKID(s) written to sbXXXX.16800_

Does anyone knows how to understand what are the above zeroed and useless,  and why I can only use 2 at the end?
What am I posibly doing wrong?
Has the attack already been patched by the router manufacturers or some kind of like that?
Thanks for your assistance comunity!!

Zeroed PMK mean:
The initial EAPOL sequence is calculated using a zeroed PMK. It is not the real PMK of the network. That can happen if a CLIENT run an empty wpa_supplicant.conf or an AP run an empty hostapd.conf. hcxdumptool receive and accept that because it is designed as penetration testing and analysis tool (as well as hcxtools).
Zeroed PMKID mean:
On first connect of a CLIENT, the AP use an initial zeroed PMKID. You can't recover a PSK from it.
Additional you received 2 warnings and you got to take this seriously:
warning: wlan1mon is probably a monitor interface
interface is already in monitor mode
Do not use airmon-ng to set monitor mode! It is designed to run in combination with aircrack-ng suite and creates a virtual NETLINK interface!
hcxdumptool need full access to the hardware and run it's own monitor mode. It doesn't use NETLINK.
NETLINK is good to stream multimedia, but not to perform high speed attacks.
https://www.quora.com/What-are-the-differences-between-netlink-sockets-and-ioctl-calls
Keep also in mind:
Not every router transmit a PMKID!!
Closed this, because it isn't an issue, but you can still ask your questions, here.

PMKIDs (WPA2)....................: 203
PMKIDs from access points........: 2
best PMKIDs (total)..............: 2
You received 203 PMKIDs total, but 201 are duplicates. So only 2 unique PMKIDs left!

Thanks your help really.
You shouldnt be dealing with n00bs like me haha. Thanks again for the
community for such a strong tool.
On Fri, 21 Feb 2020, 08:31 ZerBea<EMAIL_ADDRESS>wrote:

PMKIDs (WPA2)....................: 203
PMKIDs from access points........: 2
best PMKIDs (total)..............: 2
You received 203 PMKIDs total, but 201 are duplicates. So only 2 unique
PMKIDs left!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ZerBea/hcxdumptool/issues/100?email_source=notifications&email_token=AJIPVQPZES6X7DDKIBO6LC3RD6GORA5CNFSM4KYZ43PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMR5T4Y#issuecomment-589552115,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJIPVQINHL2K6NTOWOSJOBLRD6GORANCNFSM4KYZ43PA
.

No problem at all, you're welcome.
802.11 stuff is really hard core. hcxtools are designed as analysis tools. So every tool will show you a complete information (all useful frames and how often they are detected).

Thanks. I will have a look.
Btw just as a personal question. Im quite interested in Cybersecurity.
Do you have yourself a private career about it? Did you thought about? Do
you think this will have potential in the futurre? Any relevant university
degree or course?
Thanks for your time.
B. R.
Rafael
On Fri, 21 Feb 2020, 16:51 ZerBea<EMAIL_ADDRESS>wrote:

No problem at all, you're welcome.
802.11 stuff is really hard core. hcxtools are designed as analysis tools.
So every tool will show you a complete information (all useful frames and
how often they are detected).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ZerBea/hcxdumptool/issues/100?email_source=notifications&email_token=AJIPVQMSJJ6AX33KM5RLN4TREABAVA5CNFSM4KYZ43PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMTLCVA#issuecomment-589738324,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJIPVQP6A6KJ475NX7OWEXDREABAVANCNFSM4KYZ43PA
.

Unfortunately I can't answer this. I have never been in this profession.

No probs just wondering. Thanks for the opinion anyways.
B. R.
On Fri, 21 Feb 2020, 21:22 ZerBea<EMAIL_ADDRESS>wrote:

Unfortunately I can't answer this. I have never been in this profession.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ZerBea/hcxdumptool/issues/100?email_source=notifications&email_token=AJIPVQJUERHEJQMKXL33TSTREBAYPA5CNFSM4KYZ43PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMUEASY#issuecomment-589840459,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJIPVQN6ICQMYDEJWI7L5ATREBAYPANCNFSM4KYZ43PA
.


Add accordion component

Accordion is build on top of the aria attributes by the w3c example:
https://www.w3.org/TR/wai-aria-practices-1.1/examples/accordion/accordion.html

            <button id="accordion-button-1" aria-expanded="false" aria-controls="accordion-body-1">
                Header 1
            </button>

            Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut
            labore et dolore magna aliquyam erat, sed diam voluptua.

            <button id="accordion-button-2" aria-expanded="false" aria-controls="accordion-body-2">
                Header 2
            </button>

            Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut
            labore et dolore magna aliquyam erat, sed diam voluptua.

import Accordion from '@sulu/web/packages/components/accordion/accordion';
var component = new Accordion();
component.initialize(document.getElementById('accordion'), {});

https://jsfiddle.net/26gj8mdh/1/
@luca-rath did on top of your implementation created the accordion here. Adjusted to remove the data classes and build it on top of the aria attributes, so less need to be written by the developer which use the component. Also jquery is removed as I not longer want to build components here on top of jquery, so websites build are smaller. So we maybe could remove in the project jquery or lazy load it where required.

Code looks good, will try it in a project next week

Just tested using the jsfiddle, looks good, therefore I'm going to merge it now


Octopod Icon

Since you guys were talking about possibly getting a new icon for the app I'd like to submit a couple of ideas myself.
https://www.dropbox.com/s/vpr9z5qqk6ftu88/Octopod-01.jpg?dl=0
https://www.dropbox.com/s/e5i0nqf4v6ke790/Octopod-02.jpg?dl=0

Wow @jessearmstrong. Could you post those icons in #278 so others can comment. I think we have very nice contenders. The first one looks very cool.
Thanks,
Gaston

@jessearmstrong did you design these icons? I posted it in the other thread and someone asked if it would be possible to add some eyes to the octopus. What do you think?

I actually hired someone to make these icons (I am a designer also but I haven't had the time to tackle it myself, and this guy's other work has been very good). But I put the request in with him and I'll post a revision when I hear back.

Thanks @jessearmstrong for your help. Let me know what you hear back. Got really good feedback about https://www.dropbox.com/s/vpr9z5qqk6ftu88/Octopod-01.jpg. The idea of adding a face is to make it feel friendlier if that makes sense.

Hey @jessearmstrong, have you heard anything from the designer? I might need to push a quick release to address #296 (see https://github.com/OllisGit/OctoPrint-DisplayLayerProgress/issues/136 for more info). Chances are that I will update icon on 3.4 since many people are hitting that bug.
Thanks,
Gaston

I haven't heard back yet but I was a little slow to get the feedback to him. I'll let you know as soon as I do.

Here's the new version!

Sweet!! Not sure how to turn that image into the icon image.
We need it as an icon for Apple TV that follow this spec and for iOS that follow this spec. Can the designer provide those PNG? If he gives us an SVG I can try converting it into PNGs. For Apple TV we need an image for the background and an image for the foreground.
Thanks a lot for the help!!
Gaston

I'll get the final deliverables.

Octopod.zip
This is the final package of deliverables, he actually included a bit more than I was expecting. If you need help with these let me know. I have a long history as a designer, but I just didn't have the time to tackle this on my own.

@jessearmstrong , I updated iOS and Apple Watch with the new icon. It's looking good. :) However, for Apple TV I need the following to complete this work:

An SVG with the octopus alone (no background)
An SVG with black background (entire screen black not only the shape like iOS has)
An SVG with the octopus and a full black background (entire screen black not only the shape like iOS has)

I guess that if I have the Octopus alone, I can add a black background with Gimp.
Do you think the designer can provide us with this?

I can probably handle those. Let me have a quick look.

Octopod (Apple TV).zip
Is this what you need?

EXCELLENT!!! So fast! Love it. I can now resume this work. I thought I had to wait another day! Yay!

Here is the Apple TV version

One last request, could the designer fix the case sensitive in the name? He wrote Octopod and the app appears as OctoPod. Maybe in the future we may need the new icon with the name below.
Thanks again and this looks amazing! Wife really loves it!

Wow! That really does look great! I’ll send that note over to him.

OctoPod-2.zip
Here are the revisions with the Correct case for OctoPod.


changed moonstone-app-tutorial to match new jsfiddle

Enyo-DCO-1.1-Signed-off-by: Derek Tor<EMAIL_ADDRESS>

Updated and changed it back to http://api.com

Here are the updated JSfiddle links up for review as well.


[workloadmeta/collectors] Fix linter issues

What does this PR do?
Fixes a variety of linter issues in the workloadmeta collectors directory that I found while working on the code.
All the fixes are minor. The list includes:

rename some vars to follow Go's guidelines (avoid using "_").
sort imports.
fix some typos.
delete redundant aliases in imports.
delete redundant "//+build".
improve error handling in some tests.

Describe how to test/QA your changes
Skip.

/merge


Perform recursive lookups for group members that are themselves groups

In Google groups it is possible to make groups members of other groups. If A is
a member of group G and group G is a member of group H, then A should also be
considered a member of group H.
This change will append any groups found when listing group members to the
array of groups to iterate through, so that eventually all top-level and nested
groups will be used to check membership for the user. It is not clear whether
cyclic group membership is permitted by Google but it is being checked for just
in case.

Why is this not merged?

Hello, looking around for groups handling, I found this MR also reworking this part: https://github.com/bitly/oauth2_proxy/pull/500
Looks like this may fix this problem, with simplified code: groups are filtered by user email, server side (scheduled for 2.3).


Drop deprecated wasmbus.evt.{latticeID} subject

As of https://github.com/wasmCloud/wasmCloud/pull/1090, the host now emits events on wasmbus.evt.{latticeID} as well as wasmbus.evt.{latticeID}.{eventName}
Prior to 1.0, we should drop the former, as it is deprecated. Clients which wish to continue subscribing to all events can do so with a wasmbus.evt.{latticeID}.> subject filter

Note this is blocked by https://github.com/wasmCloud/wasmCloud/issues/1091

Completed in #1613


Collaborative editing spike

Things that aren't done yet

media file is broken because it doesn't ask the user to find the equivalent file on their computer yet
"join" and "host" buttons should open modals rather than just leaving free form text inputs all over the place

Wow 😍
Just curious, what's the plan for video preview on remote connections? I imagine it's tricky since the video is local to the host.

My thought is that when you join a session as a guest, you’re prompted to choose the same video file from your local machine, and then all collaborators have independent video previews (i.e. playback positions etc aren’t synced, just the transcription edits)

I'll merge with the flag disabled so the UI doesn't show and then put the inputs behind buttons / a modal in a follow up


[travis] Disabling cleanup on travis pypi deployment step

The pypi deploy plugin in TravisCI appears to checkout the git repository again, with a clean stage environment. While the logic around development releases is working as intended, a duplicate 0.9.0 release is attempted;
This PR swaps out the built-in travis-ci plugin for twine commands, and allows us more granular control of the build environment.

/do-e2e-tests

Does setting cleanup to false reuse the existing build workspace?
I don’t think it’s needed with the new workflow.
https://github.com/aws-quickstart/taskcat/blob/master/.travis.yml#L135

Let's find out.

/do-e2e-tests

Looks like it's skip_cleanup for the current version (dpv1)
https://docs.travis-ci.com/user/deployment#uploading-files-and-skip_cleanup

/do-e2e-tests

Codecov Report

Merging #368 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   71.76%   71.73%   -0.04%
==========================================
  Files          30       30
  Lines        2692     2692
  Branches      457      457
==========================================
- Hits         1932     1931       -1
  Misses        665      665
- Partials       95       96       +1

Impacted Files
Coverage Δ

taskcat/_lambda_build.py
85.24% <0%> (-1.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cde01...aca9c22. Read the comment docs.


reg:linear is missing in the documentation

In the options list given in https://github.com/dmlc/xgboost/blob/master/doc/parameter.rst#learning-task-parameters , the option "reg:linear" is not described.

Please use reg:squarederror instead.


feat!: Add support for preserve_host_header

Description
Adds https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb#preserve_host_header
Motivation and Context
Argument is supported by there is no option to disable it in this module.
Important
We wish to add this to version 6.x since we user a lower aws provider version
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[ ] I have executed pre-commit run -a on my pull request

This argument was added in AWS provider version 4.25.0 - https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#4250-august--4-2022
Please update versions.tf accordingly and reopen this PR, if you want to add this.


error in flexiblespacebar while i'm using image.network, image showing but i got an error

Steps to Reproduce

...
...
...

Logs

Can you post the code for a minimal app that reproduces this?  I'm not sure exactly how to track this down.


Add deployment values to repo

Extract secrets from values.yml files on the k8s master nodes.
Add them non-secret values to repo

They will be saved by https://github.com/QCDIS/infrastructure/issues/5, closing as specific issue.


Combine function attribute statments

Also deleted getInput keyword and added buttonsState keyword.
Note that the __attribute__ declaration(s) for getInput() have never worked. There was a colon left at the end of getInput(), so the __atribute__ statement wasn't associated with anything and did nothing. I've corrected this.

Since the whole point of this was 1.0.5 support does this syntax actually confirmed to work on 1.0.5?

Just tried it with IDE 1.0.5 and, yes, it works.

Just tried my IDE 1.0.5 using the original way, with the message as a parameter of deprecated:
void start() __attribute__((deprecated("use begin() instead")));
It works fine. So we can't trust using an Arduino IDE 1.0.5 as an indication of how codebender is going to behave.


Define test scenarios

Closed for now.
Ping pong test will be the first one.
The outcome of this will need to be discussed for further test scenarios


Update nrf52840 linker script.

This PR fixes two minor issues with nrf52840 linker script.

Codecov Report

Merging #1671 into master will decrease coverage by 2.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
- Coverage   69.91%   66.95%   -2.96%
==========================================
  Files         163      169       +6
  Lines       19013    21124    +2111
  Branches     2314     2594     +280
==========================================
+ Hits        13292    14144     +852
- Misses       4903     6064    +1161
- Partials      818      916      +98

Impacted Files
Coverage Δ

src/core/thread/lowpan.hpp
86.84% <0%> (-10.53%)
:arrow_down:

src/core/thread/thread_netif.hpp
92.85% <0%> (-3.44%)
:arrow_down:

src/core/thread/lowpan.cpp
92.47% <0%> (-0.72%)
:arrow_down:

src/core/thread/mesh_forwarder.cpp
77.87% <0%> (-0.61%)
:arrow_down:

src/core/thread/mle_router.cpp
77.41% <0%> (-0.59%)
:arrow_down:

src/core/api/jam_detection_api.cpp
0% <0%> (ø)

src/ncp/hdlc.cpp
76.34% <0%> (ø)

src/ncp/ncp_base.cpp
29.62% <0%> (ø)

src/ncp/ncp_base.hpp
0% <0%> (ø)

src/core/utils/jam_detector.hpp
0% <0%> (ø)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19440f5...4c627da. Read the comment docs.


IChangeListener registered for Async Daemon on AsyncListeners get executed before DB transaction is committed

Issue
IChangeListener.AfterCommitAsync() for Async Daemon, registered in AsyncListeners, get executed before the actual DB transaction is committed to DB.
From my observation and review of the code this is the current sequence:

ProjectionUpdateBatch.Page run to DB (ProjectionUpdateBatch.ApplyChangesAsync())
IChangeListener run (ProjectionUpdateBatch.ApplyChangesAsync())
DB transaction commits (DocumentSessionBase.ExecuteBatchAsync())

Versions
At least from version 5 to latest of version 6.
Impact
Due to information in docs can be misleading at the least.
On typical usage scenario to produce side effects across a system, through follow-up actions triggered by events or direct calls, due to the race condition between subsequent reads and commits process still ongoing, resulting in potential errors and inconsistencies.

This hook means currently is executing after all the changes to projection were applied.
I think that if we want to change the behaviour of the AfterCommit hook then it has to be in the major version. Plus we should have the BeforCommit then. I agree that the name is not great but I know that there are  users that depend on the behaviour as is to publish read model changes as I described here: https://event-driven.io/en/publishing_read_model_changes_from_marten/
If we change that then they will lose at-leathe projection were applied.

I think this changes as part of our "First Class Subscription" feature in V7 -- which I'm not sure we've even added to the backlog yet.

From my perspective this issue can be closed, as even though semantics can be somewhat misleading, the rationale for current implementation is understandable at light of the "at least once" guarantee.
For future API should be made clearer, feel free to reopen if useful to keep in backlog for v7.


Make bladed flatcap embed on hit

About the PR

Makes the item embed into entities when thrown/drag-pushed.
Why / Balance

It is currently being dragged and flung-pushed to damage entities multiple times.
Changelog
:cl: Whisper

tweak: Bladed flatcaps now embed on throw.

feels like we should just fix the dragging being throwing code since it affects like 500 other things rather than implementing fixes for it being bad

fyi pulling no longer uses throw code so you may want to just close this

yeah this isnt necessary anymore

Thank god


Fix Key Vault project files

/azp run net - core - ci

We probably just need to update some recorded tests in Azure.Identity.
ServiceVersion in CryptographyClientOptions.cs https://github.com/Azure/azure-sdk-for-net/blob/cddefe7d93026be8b4ad835d0cb7c64969c4ff46/sdk/keyvault/Azure.Security.KeyVault.Keys/src/Cryptography/CryptographyClientOptions.cs#L19 has moved ahead of what is present in our recorded tests.
https://github.com/Azure/azure-sdk-for-net/blob/b015ef33bf4945661d74c4f18411e986558fbefe/sdk/identity/Azure.Identity/tests/SessionRecords/ManagedIdentityCredentialImdsLiveTests/ValidateImdsUserAssignedIdentity.json#L4
This should unblock for now although I don't think reverting the KeyVault package versions make a difference

Then all the tests using PackageReferences would break, which are 4 platforms. I think the long term solution needs more thought to how this could work when service versions rev.


Remove timeouts

@spalger, apparently the build for the current version of the package is failing (which is odd since the badge in the readme displays "passing"). Maybe some dependency update broke it?

@Slayer95 the "current" build is just the latest build of the pr

https://travis-ci.org/spalger/gulp-jshint/builds
https://travis-ci.org/spalger/gulp-jshint/pull_requests

The badge on the repo is filtered to the master branch

https://travis-ci.org/spalger/gulp-jshint.svg?branch=master

Actually, the Current tab displays a different commit with a minimal delta that I pushed to this branch before
https://github.com/spalger/gulp-jshint/commit/5e989cccc6d7e43ffe99465e292f022cd991b56d
And it also fails the build.
https://travis-ci.org/spalger/gulp-jshint/jobs/65357850
Running gulp test locally also fails before this commit.
Probably the passing result is simply a cache from a previous sucessful build?

hmm, tests run fine for me. What failure do you get?

npm version, npm ls, and gulp test:
http://hastebin.com/orilofegih.tex
This patch fixes the failing tests for me, but it may or may not be the ideal fix
http://hastebin.com/elaruboqur.js

Both failing tests pass on reversion to JSHint 2.7.0.
Apparently, from 2.7.0 to 2.8.0 the errors and warnings change:
<EMAIL_ADDRESS>E2 W0 I0
E4 W0 I0
<EMAIL_ADDRESS>E2 W2 I0
E4 W4 I0
It looks like https://github.com/spalger/gulp-jshint/commit/ad8ce6043aee3d045c1c059d079ffcb24d8b203e passed the tests due to pure chance.
https://github.com/spalger/gulp-jshint/pull/114 fixes this.

Rebased and it passes now! :]

Thanks @Slayer95 :)


Resource windows_dns_record support for dns_server property

Describe the Enhancement:
Ability to specify a remote DNS server for the windows_dns_record resource.
Describe the Need:
We utilize a managed AD in AWS for which we can only manage the DNS remotely.
Current Alternative
The alternative is just to specify a dsc_resource instead of using the windows_dns_record resource
Can We Help You Implement This?:
Yes, I will be linking my PR shortly.

PR #10120

Related PR has been merged to master


Matroska container header meta data parsing

From what I've gathere online, Matroska (mkv) files don't provide the same interface as MP4 files for reading metadata. Duration and creation date are not stored in the stream section, but in the container section.
Mainly 3 additions:

Duration is read from the format section only if it's not set already (haven't found too much information on this, but based on my personal files the stream metadata seems to be more accurate for the duration)
Bit rate from the format section overwrites previously found bit rates (since the stream bit rate really only accounts for video, it makes more sense to use the average overall bit rate)
Creation date also overwrites previous creation dates (found no file in my collection where these two were not the same).

I've also added a testcase for mkv metadata parsing and updated the bit rates for the other testcases.
tldr: before this PR any mkv files in my library would use the filesystem modification time, now the embedded creation time is used.

Thank you for the clean PR.
This might also help with #682 (need to check)


ISPN-15523 Fix the blocking publisher in the restore procedure

https://issues.redhat.com/browse/ISPN-15523
Just updating the flowables. See the comments: https://github.com/infinispan/infinispan/pull/12131#discussion_r1532260892

Image pushed for Jenkins build #5:
quay.io/infinispan-test/server:PR-12178

@jabolina This seems to fix the issue. I executed the test 20 times (once the build issue was resolved) and there was a single failure, which was not related to the restore procedure.
https://ci.infinispan.org/job/Infinispan Operator/job/PR-2036/

Thanks for the help, @ryanemerson! I'll remove the label so we can get this in, and later I'll add the commit to the open backport.

Image pushed for Jenkins build #6:
quay.io/infinispan-test/server:PR-12178

Image pushed for Jenkins build #7:
quay.io/infinispan-test/server:PR-12178

@jabolina org.infinispan.server.security.authorization.AuthorizationKerberosIT$Rest.testRestAdminsMustAccessBackupsAndRestores looks related

@ryanemerson Good catch! Updated with a fix.
The issue was that we ran both HotRod and REST tests in the same container, so we had configuration from HotRod with indexing enabled "leaking" into the REST. The operations with the index enabled would block somewhere, causing the issue.
I've updated it to consider the "restore from file" blocking. Initially, I assumed that only reading the zip was blocking. Now, we have even the put operation considered blocking. This change will "hide" if an operation blocks by mistake.

Image pushed for Jenkins build #8:
quay.io/infinispan-test/server:PR-12178

Thanks @jabolina


multiple org support framework

This has the libraries that support multiple organizations.  Each action that supports multiple orgs have to call
self._reset(<org name>)

before it uses the self.client

No, this PR doesn't address the single sensor issue.


Add 'event-model' group to maintainers

This PR is to add NSLS-II contingent to the list of maintainers. Similar to https://github.com/conda-forge/bluesky-feedstock/blob/5222051a915defe3bbe418859a6b7184094202d8/recipe/meta.yaml#L62.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender.

@mrakitin Can you explain how conda-forge/event-model resolves to a list of maintainers, is it a github team?

@cjh1, it adds a team https://github.com/orgs/conda-forge/teams/event-model, which is originally defined in https://github.com/conda-forge/event-model-feedstock/blob/3926e46cd1ee49ede01bc3bd9def1cf7e3fc1140/recipe/meta.yaml#L43-L46.
Not sure why the team's link is not rendered properly in README.md, probably it's an issue with conda-smithy's templates...

@mrakitin  hanks for the explanation

@cjh1, this does not seem to work. I think we encountered such an issue for one of our projects. I'll check with CF folks.
@conda-forge, the event-model team does not seem to be applied correctly here. Could you please have a look?

It seems like github API doesn't work as advertised sometimes and adds read only permission. Instead of calling add_to_repos at https://github.com/conda-forge/conda-smithy/blob/master/conda_smithy/github.py#L273, we should be calling set_repo_permission with push permission.

Thanks for the investigation, @isuruf!
I noticed that the README.md file has a link to a non-existent URL - https://github.com/conda-forge/event-model/. Is it something that should be changed to https://github.com/orgs/conda-forge/teams/event-model to work properly with the ownership too?

It's not necessary, but would love to have that change too.


Revert "Rollback maven to 3.5.4 (#213)"

This reverts commit 9593a30e82f96aa9d95968d52e11056f7887766b.
Looks like the downgrade won't help us

We do need this


[Feature] Possible option to change clock position

As a player who using this mod, I want to change clock position like:

top-left
top-center
top-right
center-left
center-center
center-right
bottom-left -> set as default for backward compatibility settings
bottom-center
bottom-right

so I can choose where I want to see the clock.

Working on this now.
Trying with enums first, if that works nicely I'll have an update today.

Implemented in 2.5, curseforge is processing it now.


Issue with XsuaaJkuValidator when application is bound to both system plan and application/broker plan

Hi,
XsuaaJkuValidator is also registered as one of the token validator in SAPOfflineTokenServicesCloud which checks if the jku in the token matches the domain in the xsuaa binding.
For application & broker plan the uaadomain is the same and it does not match with the system plan.
During runtime, when a token is created for system plan flow, the jku in token is : "https://uaa.cf.sap.hana.ondemand.com/token_keys".
This gets validated by XsuaaJkuValidator.java with "authentication.sap.hana.ondemand.com" which was initialized with xsuaa application instance and throws error.
The error is:
Issuer is not trusted because 'jku' 'https://uaa.cf.sap.hana.ondemand.com/token_keys' does not match uaa domain 'authentication.sap.hana.ondemand.com' of the identity service.
Can you help me out here.
Thanks & Regards
Manoj

HI @manoj-mathivanan
the question, why do you leverage system plan at all?
Do you deploy your application on XSA or on Cloud Foundry?
Thanks for clarification.
Best regards,
Nena

Hi Nena,
Thanks a lot for your reply.
We use Cloud Foundry. We have a dashboard attached to the service instance with which he can view some information about the service instance and configure the service instance. This dashboard uses system plan to authenticate the user.
Thanks & Regards
Manoj

Hi @manoj-mathivanan
how have you done it previously? Is it a feature request?
I'm not aware of such a use case...
Have you tried to setup a validation only for that dashboard-with-system-plan case as it is described here:
https://github.com/SAP/cloud-security-xsuaa-integration/blob/master/java-security/README.md#basic-usage
Instead of "Setup Step 1: Load the Service Configuration(s)" you can setup the config for Xsuaa Service of plan "system" by your own:
CFEnvironment.loadForServicePlan(Service.XSUAA, Plan.SYSTEM)

Further references:
https://jam4.sapjam.com/questions/PAhvDCnLAOLcBVP6WUHcE2

Hi Nena,
Thanks a lot for your suggestions.
This is not a new feature request from our side, using System plan, application. broker in the same app was being done for a long time.
Our product - Enterprise Messaging which was released more than a year back has been using it. So we have a release version available.
Due to the disadvantages you have mentioned, we have discontinued System plan for new customers for the last few months. But we still support this feature for the existing customers.
This is the reason for still supporting all the plans.
The problem poped when we started migrating to the new security libraries. In the old set up I guess we did not have jku validation in the library and everything was working fine.
We are exactly using the code what you have suggested. The link to the file change is below:
https://github.wdf.sap.corp/enterprise-messaging/xbem-hub/blob/354f84e0f0f141a66d54561d02d765578c34ccc2/ehub-app/src/main/java/com/sap/xbem/ehub/app/config/security/WebSecurityConfig.java#L113
As I already mentioned I guess the issue is with the Jku validation for system plan tokens.
Thanks & Regards
Manoj

Hi @manoj-mathivanan,
I guess your current solution is not working, right?
Because SAPOfflineTokenServicesCloud does not (yet) support xsuaa services that differentiate in their uaa domain and this was not what I've suggested above.
My suggestion above was to setup another validator only for the system plan and to validate these kind of tokens separately, e.g. as part of the endpoint and not as part of this configuration...
Would that be a feasible intermediate solution?

You have to remove the "authenticated" check as part of the configuration.
Instead you setup another validator bean as described here for system plan configuration:
CombiningValidator<Token> validators = JwtValidatorBuilder.getInstance(serviceConfig).build();
As part of your endpoint you perform the token validation

Otherwise we have to enhance XsuaaJkuValidator that it supports different domains. Which is only necessary for this special case, which is not recommended at all...
Best regards,
Nena

Hi Nena,
Getting the OAuth2ServiceConfiguration for system plan manually and building the JwtValidatorBuilder throws the error:
XsuaaJkuValidator requires uaaDomain.
The exact code which was done is:
OAuth2ServiceConfiguration xsuaaSystemConfig = CFEnvironment.getInstance().loadForServicePlan(Service.XSUAA, Plan.SYSTEM);
CombiningValidator<Token> validators = JwtValidatorBuilder.getInstance(xsuaaSystemConfig).build();

When the build() method is called, it creates an XsuaaJkuValidator which throws the error XsuaaJkuValidator requires uaaDomain.
To overcome this, I tried out the below approach.
OAuth2ServiceConfiguration xsuaaSystemConfig = CFEnvironment.getInstance().loadForServicePlan(Service.XSUAA, Plan.SYSTEM);

OAuth2ServiceConfiguration serviceConfig = OAuth2ServiceConfigurationBuilder.fromConfiguration(xsuaaSystemConfig).withProperty(CFConstants.XSUAA.UAA_DOMAIN, "uaa.cf.sap.hana.ondemand.com").build();

validators = JwtValidatorBuilder.getInstance(serviceConfig).build();

Does this approach look good?
Overall, I created a Filter for the URLs which uses system plan and I cached the token manually using: SecurityContext.setToken(token); and removed the pattern from spring "authenticated" part.
Hope this is what you meant.
Thanks & Regards
Manoj

Hi @manoj-mathivanan
can you pls share with me, the uaa domain of VCAP_SERVICES for plan system?
Best regards,
Nena

Hi Nena,
The xsuaa environment looks like:
{
    "binding_name": null,
    "credentials": {
     "apiurl": "https://api.authentication.sap.hana.ondemand.com",
     "clientid": "sb-xbem-ui-xbem-perf-tests!s298",
     "clientsecret": "qEY7_bASOHSrXstkCKlBvvSMV7k",
     "identityzone": "uaa",
     "identityzoneid": "uaa",
     "sburl": "https://internal-xsuaa.authentication.sap.hana.ondemand.com",
     "tenantid": "e55b04c5-e75a-4357-92e1-af7d54e405c9",
     "tenantmode": "dedicated",
     "url": "https://uaa.cf.sap.hana.ondemand.com",
     "verificationkey": "-----BEGIN PUBLIC KEY-----MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEArnSd/Sxq+AqXqtc6fYYcyvgvrN2g+dd643AsTYjLZJxVBBdxADyhW/R408tRyrcZzlkC1pAbyxD3cc5tglmHEiAl6dWd8rCVQeWeQMma+vDR2WkpqmhUGqdy13Y/esezrqhvc2RNCCtrtCFf3i3JRzh9hS7pnWlqzzyRaVETOcpS9Q5jeyytZrxXjZAYX77QCDgQdpELNhL/iz0GzvalGT2h4Jdb3i7y7Co/9cfm3jAuS8N1qbqsR/o6rzzeIrjDCuI5/BLL3Bph76TvgdHTe/tN+iRNG5xlg0460GyjSwQqp1mR21+sVFmTE2Flc2fAI2473B93Xk6IEoEI96eqYwIDAQAB-----END PUBLIC KEY-----",
     "xsappname": "xbem-ui-xbem-perf-tests!s298"
    },
    "instance_name": "xbem-xsuaa-system",
    "label": "xsuaa",
    "name": "xbem-xsuaa-system",
    "plan": "system",
    "provider": null,
    "syslog_drain_url": null,
    "tags": [
     "xsuaa"
    ],
    "volume_mounts": []
   }

It doesnot have a uaa domain. Thats the problem.
Regards
Manoj

Ok.
Then you could implement it so:
OAuth2ServiceConfiguration serviceConfig = OAuth2ServiceConfigurationBuilder
				.fromConfiguration(xsuaaSystemConfig)
				.withProperty(CFConstants.XSUAA.UAA_DOMAIN, xsuaaSystemConfig.getUrl().getHost())
				.build();

The rest should fit!
Best regards,
Nena

Hi Nena,
Thanks a lot for helping out.
Regards
Manoj


create samples for three datasets

Preliminary workbooks for the datasets.
Has an issue that newly uploaded values will overwrite old values of the same variable (in the FSI dataset), regardless of timestamps.

@Otamio We do not want to upload the data files to github. Remove them from Github and upload to google drive:
https://drive.google.com/drive/u/1/folders/1lQcWDfkN_SA7STg0dXaipc6tTtm8m__E

Datasets have been removed.