Forest start_process fails to restart auxin on Auxin crash

Sometimes auxin crashes crash forest bot. The following Auxin in 0.1.8 crash ended up crashing forest core.
#Auxin 0.
Guess is that when auxin fails, the following assert causes start_process to fail
https://github.com/mobilecoinofficial/forest/blob/4f8bc65d0c1f49634579ef77403f282a373609f0/forest/core.py#L138
And then because the task is stored within the class dict, no error is sent because the task is never garbage collected.
https://github.com/mobilecoinofficial/forest/blob/4f8bc65d0c1f49634579ef77403f282a373609f0/forest/core.py#L534-L536
We should

Not use assert for stdin monitoring (asserts are for values always expected to be true, shouldn't be used on values likely to change), we should explicitly check its status and if we detect stderr, restart auxin
Monitor the start_process() task and if it is in error state, dereference and start a new task.

https://github.com/mobilecoinofficial/forest/pull/99 <- This pull is the proposed fix

This issue has been mostly solved by:

Fixing Auxin Crashes
Implementing Logging of Start_Process


Parse all mapping registries as a preprocessing step

Instead of loading the mappings registries client side from the network, lets

Create a Makefile with a makegoal

mappings.yml: mapping-server.yml
      python scripts/read_mapping_registry_metadata.py --registry $< --metadata $@

This goal should read the mapping-server.yml, load all the mapping sets and create one big yaml file with mapping set metadata.
2. Use mappings.yml  for the VUE component to render.

I added two more registries:
https://github.com/mapping-commons/mapping-commons.github.io/commit/22391074a848f32124b44c61c08e1b11ee3e29ee

Fixed!


Support tele-op for Franka Kitchen environments ("vel" mode)

Changes Summary:

Add ee_target to Franka Kitchen xml
Fix bug in normalize_actions
Handle teleop action for "vel" mode envs

Motivation:
Currently, the teleop code only supports "pos" mode environments, where the expected input action is the qpos coordinates. Other environments, like the Franka Kitchen envs, are "vel" mode - where input action is the velocity of each joint.
NOTE: Normalizing the qvel does not work, the values are too small and the end effector never reaches the teleop target. Is there some issue with how the normalization is called?

I haven't tested in cases you are using it now. This might be a good chance for me to test those. I'm traveling this week. I'll be able to take a look next week.

Bump on this PR. Even though the teleop works, it would be good to know if the implementation is correct, especially since it doesn't work when I normalize the velocities.

Let me know when its ready for a merge and I'll do a thorough review.


Making the Code Easier to Read and update

In your project's README, you mentioned that when you first made this code, you didn't have much experience with Objective C/CoreFoundation. Even though you thought the code might not be great, the app works well and many people use it. I wanted to make the code easier to understand, so I changed the names of some functions and variables.
I fixed a part of the code called find_itemname() because it wasn't being used before. I also removed sidebar_insert() because it didn't do anything. It seems like you were waiting for find_itemname() to work properly before making sidebar_insert() useful. But after six years, no one has asked for it, so I deleted it.
I made the error checking clearer by putting it into two new functions, ValidArguments() and ValidateSideBarList(). This makes it easier to see what the add, remove, and list options are doing. I also made a new function called ClearSideBarItems() to remove everything at once, which means RemoveSideBarItem() now just removes one item with the help of the improved FindItemByName().
I updated the xcodeproj files needed to make the code work with the newest Mac Silicon chips.
It's a bit difficult to read the diffs, so checking out the final version of the code might be simpler: https://github.com/mosen/mysides/blob/ebd838ade305e850962f88f492dc1ac559834940/src/main.m
With these changes, the code should be easier for you or anyone else to read and work with in the future. You did a great job making something that helps so many people with automating their Macs, even after all this time.

Thank you for this code, I use the sidebar all the time and will be automating this using SoundFlow (this runs the command-line code for me via stream deck triggers). It seems that in the latest version the "insert" option has been removed (to place an item at the beginning of the list / top of the sidebar). I installed via Homebrew. Is it possible to add this back in?


Use d3.pairs in place of custom implementation

Fixes #359

Heh, this has happened far too often! I never thought to check d3 in this case.


INC - application_private_key

Good evening,
First of all thank you for your tool, I'm a big fan of it!
I am using Terraform for configuration purposes for an organization. When using Terraform to create GitHub Secrets Actions.
Key creation scheme :

Follow the tutorial on README.md
Transforming the PEM key into Base64 for Terraform
Terraform uses the Crypto tool
The key is created on GitHub correctly

When I try to use it through your workflow in this way :
- name: Get token
        id: get_token
        uses: peter-murray/workflow-application-token-action@8e1ba3bf1619726336414f1014e37f17fbadf1db
        with:
          application_id: ${{ secrets.ID_AUTOSYNCBOT }}
          application_private_key: ${{ secrets.PEM_AUTOSYNCBOT }}

I find myself facing this error when using it:
$ Run peter-murray/workflow-application-token-action@8e1ba3bf1619726336[4](https://github.com/wr-projects/first-contributions/actions/runs/3634830314/jobs/6145186475#step:5:5)14f1014e37f17fbadf1db
Error: Error: Input required and not supplied: application_private_key
Error: Failed to initialize GitHub Application connection using provided id and private key

Maybe I'm going the wrong way, or maybe the Crypto module provided by Terraform is simply not recognized by your workflow?
Best regards,

Hi 👋 the Error: Input required and not supplied: application_private_key would seem to be implying that the private key itself is not being passed in as that is an early failure; https://github.com/peter-murray/workflow-application-token-action/blob/8e1ba3bf1619726336414f1014e37f17fbadf1db/index.js#L9

I'm seeing something similar where this worked with v1 but not with v2. Still investigating.
I also wanted to say this action is awesome btw

Ah I added
organization: myorg
and now everything works again.

Closing as I think this has been answered in the comments here and the error did seem to indicate the value failing a pre check

That must have been a fluke because I have come back after holiday and it looks like it is broken again


Add 'renderCopyrights' prop

How to

Add 'renderCopyrights' option to be able to render copyrights
Rename 'renderCopyrights' to 'renderAllCopyrights' to avoid name conflict wit the new param

Others

[x] It's not a hack or at least an unauthorized hack :).
[ ] The images added are optimized.
[x] Everything in ticket description has been fixed.
[x] The author of the MR has made its own review before assigning the reviewer.
[x] The title means something for a human being.
[x] The title contains [WIP] if it's necessary.
[x] Labels applied. if it's a release? a hotfix?
[x] The new class' members & methods are well documented
[ ] Tests added.

Or maybe I should rename it 'render' simply?


Switch to parallel-comemo using GIT dependency

Make use of parallel comemo using a GIT dependency until a release of comemo is made (so that we can properly test it)

Thanks!


Material table: mat-cell method calls are executed twice

Bug, enhancement request, or proposal:

Detailed Reproduction Steps:
Just create a simple material data table with one column f.e. and call a method in this column defenition like this:
    <ng-container matColumnDef="test">
       test
       {{test()}} °
    </ng-container>

this calls the method test():
public test(): void {
console.log('test');
}
What is the expected behavior?
The expected behavior would be that the method test() is executed for each row in the table ONCE.
What is the current behavior?
The current behavior is that the method test() is executed twice for each row in the table.
What is the use-case or motivation for changing an existing behavior?
If the method call does complex compution the performance will drop by performing it twice for each row in the table.
Which versions of AngularJS, Material, OS, and browsers are affected?

Angular: 8.1.4
Angular Material: 8.1.4
OS: Windows 10
Browsers: Chrome

Is there anything else we should know? Stack Traces, Screenshots, etc.

If you need to do complex calculations, you should do them ahead of time, not by function calls through the template. This is a simple change detection effect.

That is how I solved it now. But isnt it strange change detection calls everything twice? Once should be enough?

Don't quote me on that but I think that in dev change detection runs twice to detect possible issues. Can you confirm that it also happens in production?
Also you should avoid binding functions in your template since these functions are executed at every change detection cycle.

Yes, in development mode change detection runs twice so that the famous "ExpressionHasChangedAfterItHasBeenCheckedError" can be thrown.

Angular itself makes no assurances about how many time functions within expressions will be called. You shouldn't ever depend on functions being called only a certain number of times by Angular's change detection engine.


Ctrl+Z messes up the Z-index

I couldn't reproduce it but it was something like this:
On the canvas there was an arrow (1) with highlight (2) over it.

Add an arrow
Ctrl + Z
Arrow(1) appears above the highlight(2)
Add an arrow
Ctrl + Z
Arrow(1) appears under the highlight(2)
Add an arrow
Ctrl + Z
Arrow(1) appears above the highlight(2)
etc.

Hypothesis: both arrow(1) and highlight(2) had the same z-index

This bug cannot happen with new-Canvas architecture #70


Default value not handled by the datepicker

Specify a default such as: $scope.myDate = '2015-01-01';
The datepicker is still pointing on today.
Demo
Bests

@willks, I believe the code is two way binding, but it wasn't monitoring the change of the value afterwards.

ok, i really hate the code is grunted, so i don't really know how to extend the code other than just add the following two lines
        scope.$watch('pickADate', function() {
            element.pickadate('picker').set('select', scope.pickADate);

        });

Well for whatever reason, I couldn't get it working, so I just go back to the pickadate.js and then add the following directive (which is just the simplified version), and it worked. So there must be some bug in the current code.
app.directive('pickADate', function() {
    return {
        restrict: 'A',
        scope: {
            pickADate: '=',
            pickADateOptions: '='
        },
        link: function(scope, elem, attrs) {

            elem.pickadate();

            setTimeout(function() {
                if (scope.pickADate) {
                    elem.pickadate('picker').set('select', scope.pickADate);
                }
            }, 1000);

            scope.$watch('pickADate', function() {
                elem.pickadate('picker').set('select', scope.pickADate);
            });
        }
    }
});

works for me if my initial date is (whyever) a javascript date object.
anyway, code should be improved to get rid of the timeout and only use scope.$watch -> see here: https://github.com/jonathan-reisdorf/angular-datepicker/commit/f89b770cd45504294cfc9c7ac4ce4defd2b3139d

Works fine if we set default date as,
pick-a-date="startDate"  //startDate as $scope variable with whatever default date you want to
and set date format as,
$scope.options = {
format: 'yyyy-mm-dd'
};
at controller end.


Add script to send CanaryTest messages to datadog.

The messages will be sent if CANARYERRORS is set in/etc/default/server-env .
This additional variable is added to the server-env file by the Canary
stage in the UserData for the Canary cluster.

I think that in the long run having this configuration pass through the user data will be confusing. Lets leave it like this for now because its done. Maybe next time we can make an endpoint that we can hit to spawn a new thread that executes the script. That would be a lot more useful for demo-ing this feature.


operator [O] project-quay (3.10.3)

Add 3.10.3 to community operators

/merge possible

/merge possible


Implement getFieldMapping on SDKRestClient

NOTE: This PR will require updating to conform to the changes in #613 that @kokibas is working on.  Feel free to review and suggest changes, but let's get #613 merged and I can update that variable rather than causing churn for that other PR. :-)
Description
Implements the IndicesClient getFieldMapping() method on the SDKRestClient.
This provides identical functionality to the Transport Call on AD extension (GetFieldMappingsAction.INSTANCE) used for validating the time field, enabling its migration without exposing OpenSearch TransportActions to extensions.
Issues Resolved
Fixes #361
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #672 (2b0865a) into main (e80ee7c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main     #672      +/-   ##
============================================
+ Coverage     64.08%   64.11%   +0.03%
  Complexity      274      274
============================================
  Files            55       55
  Lines          1161     1162       +1
  Branches         38       38
============================================
+ Hits            744      745       +1
  Misses          404      404
  Partials         13       13

Impacted Files
Coverage Δ

src/main/java/org/opensearch/sdk/SDKClient.java
92.30% <100.00%> (+0.07%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I was about to comment that DEFAULT should be replaced by options since https://github.com/opensearch-project/opensearch-sdk-java/pull/613 got merged but you were fast! Haha


The backup is not point in time if a tailed oplog's last timestamp is before a mongodump's.

This is only for a sharded cluster, and could occur frequently for small sharded clusters.
So the current process is:
start tailed oplogs
start mongodumps of each replicaset with --oplog
finish mongodumps
stop tailed oplogs
Then the evaluation is made using Resolver.get_consistent_end_ts() which looks at the tailed oplogs, and then appends the oplog entries from the tailed oplogs to the mongodump oplogs.
However, in its current state, it could be common that the backups taken are not point in time.
When I was testing, I found that the optime on the configservers update a lot less frequently. In fact, it looks like it can be every 10 seconds:
configReplSet:PRIMARY> db.oplog.rs.find({}, {'ts': 1, 'op': 1, 'o': 1}).sort({$natural:-1})
{ "ts" : Timestamp(1496305850, 1), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:50.770Z") } } }
{ "ts" : Timestamp(1496305848, 2), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:48.833Z"), "waiting" : true } } }
{ "ts" : Timestamp(1496305848, 1), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:48.830Z"), "up" : NumberLong(8444197), "waiting" : false } } }
{ "ts" : Timestamp(1496305839, 1), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:39.157Z") } } }
{ "ts" : Timestamp(1496305838, 2), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:38.823Z"), "waiting" : true } } }
{ "ts" : Timestamp(1496305838, 1), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:38.817Z"), "up" : NumberLong(8444187), "waiting" : false } } }
{ "ts" : Timestamp(1496305828, 3), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:28.961Z") } } }
{ "ts" : Timestamp(1496305828, 2), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:28.809Z"), "waiting" : true } } }
{ "ts" : Timestamp(1496305828, 1), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:28.804Z"), "up" : NumberLong(8444177), "waiting" : false } } }
{ "ts" : Timestamp(1496305820, 1), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:20.765Z") } } }
{ "ts" : Timestamp(1496305818, 2), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:18.800Z"), "waiting" : true } } }
{ "ts" : Timestamp(1496305818, 1), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:18.796Z"), "up" : NumberLong(8444167), "waiting" : false } } }
{ "ts" : Timestamp(1496305809, 1), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:09.151Z") } } }
{ "ts" : Timestamp(1496305808, 2), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:08.789Z"), "waiting" : true } } }
{ "ts" : Timestamp(1496305808, 1), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:30:08.782Z"), "up" : NumberLong(8444157), "waiting" : false } } }
{ "ts" : Timestamp(1496305798, 3), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:29:58.955Z") } } }
{ "ts" : Timestamp(1496305798, 2), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:29:58.776Z"), "waiting" : true } } }
{ "ts" : Timestamp(1496305798, 1), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:29:58.771Z"), "up" : NumberLong(8444147), "waiting" : false } } }
{ "ts" : Timestamp(1496305790, 1), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:29:50.764Z") } } }
{ "ts" : Timestamp(1496305788, 2), "op" : "u", "o" : { "$set" : { "ping" : ISODate("2017-06-01T08:29:48.770Z"), "waiting" : true } } }

This becomes a problem because...
The last mongodump that finishes, it's oplog time would be near the current time. But when they finish, the oplog tailers are killed off almost immediately, which means, a config server oplog tailer may have a last_ts of up to 10 seconds ago.
When the evaluation for get_consistent_end_ts() is made the ResolverThread then has a max_end_ts of the config server's last_ts. This means, tailed oplog entries are appended to the mongodump oplog only if they're prior to this max_end_ts, however, one of the mongodump's oplog already exceeds the max_end_ts. This leaves one mongodump with a higher oplog time than the others.
I was testing this by adding around 1000 documents per second against the mongos for one of the sharded collections, and then comparing the documents.
I can work around this by adding a sleep after the mongo dumps finish, given the tailed oplog for the configserver a chance to write it's next timestamp, of which a point in time backup is then made.
The graceful fix for this would be:
Once the mongodumps finish, take the last oplog timestamp from the mongodumps, and then ensure the oplog tailers exceed this. This way, the get_consistent_end_ts() would then be correct.
Please feel free to ask if you need any further information.
Thanks,

Hi @rob256,
I believe this probably true in 2 scenarios but maybe you can help me confirm:

Any 0.x release of the tool
1.0.x with non-replica-set config servers

I added support to "safely" stop the oplog tailers in 1.0.0 that I believe avoids what you're describing:

After mongodump threads complete a .stop() is called on the Tailer object: https://github.com/Percona-Lab/mongodb_consistent_backup/blob/master/mongodb_consistent_backup/Main.py#L386
The Tailer object in 1.x will get the current oplog timestamp from each Primary and wait until each TailThread.py reaches that timestamp: https://github.com/Percona-Lab/mongodb_consistent_backup/blob/master/mongodb_consistent_backup/Oplog/Tailer/Tailer.py#L84-L95

The state of the 'last_ts' of each TailThread.py is passed from parent to thread with OplogState.py: https://github.com/Percona-Lab/mongodb_consistent_backup/blob/master/mongodb_consistent_backup/Oplog/OplogState.py (thread safe due to multiprocessing.Manager)
If all of this is correct I would assume what you're describing is only possible before 1.x or if you have non-replica-set based config servers where there is no oplog to safely stop using timestamps.
Does this sound correct?

I will check which version of the code I was using tomorrow, but I may have been using HEAD as of a couple of days ago. Thanks.

Yes, I  have that, but that seems to wait until the time of the oplog for the ReplicaSet that it's tailing, rather than the maximum time across all ReplicaSets. This means, if the ConfigServer's mongodump oplog finished 5 seconds before the others, its tailer would also finish 5 seconds before the rest.
Following this, the Resolver.get_consistent_end_ts() calculates the max_end_ts by looking at the earliest timestamp across all of the Tailers, which calculates at 5 seconds before one of the mongodumps - this is when the issue occurs.

Hi @rob256, I follow what you're saying but I think part of that isn't the case. A the same time this is very important code I wrote long ago so I appreciate a review of this logic!
In Main.py the code waits for all backups (mongodumps) to finish before calling the code that waits for the current optime of the Primary. The .run() on self.backup is blocking until all mongodumps finish or it will throw an exception that will cause the tool to exit cleanly: https://github.com/Percona-Lab/mongodb_consistent_backup/blob/master/mongodb_consistent_backup/Main.py#L379. I think all of this part is working fine.
I've always wanted to add a bit more safety to Resolver.get_consistent_end_ts() but I think the serial order of events in Main.py before the tailers are stopped prevents any consistency issues. There is a possibility that the last oplog timestamp of a given set is before the end-time of the MongodumpThread but that would only happen if there were no writes but the backup would still be consistent to whichever time it chose in .get_consistent_end_ts().
Could you sanity check those assumptions for me?

Doh, I see what you're saying now - this code take a while to wrap my head around.
Yes, choosing the minimum timestamp is dangerous if no writes have occurred in some time and mongodumps complete. Good point.
I suppose the correct logic would be to leave the oplog tailing code as-is, but move .get_consistent_end_ts() to find the lowest oplog tailer end ts that is greater-or-equal to the end time of the last mongodump. If all tailers do not have an update after the end of all mongodumps than the end time of the last mongodump would be the fallback. Does that logic check out @rob256?

I've created a commit with the logic I mentioned in my last reply here to demonstrate: https://github.com/timvaillancourt/mongodb_consistent_backup/tree/issue_164_max_resolver_ts.
It might be more precise to use the time MongodumpThread.py gets an exit from mongodump but as the oplog dumping is the final step of mongodump, after the dumping of collection data, I consider this safe for now.
I've also made it round up the consistent_max_ts second because I'm rounding-down the increment counter to zero in this method. This will catch the last subsecond incremented ops.

Thank you @timvaillancourt for taking the time to look into this. I've reviewed your modification and I'll test this out on Monday. I'll let you know how it goes. Thanks.

Hi @timvaillancourt, I've tested your fork and so far it looks good. I'll give it another test early next week and will see if I can tweak my test to hit it a bit harder. Currently my test environment only has 2 shards. Thanks.

Thanks for your testing @rob256!
I will merge this to our 1.0.4 branch (to become a release soon) as this is at least safer than the current logic. This will be merged with other improvements here: https://github.com/Percona-Lab/mongodb_consistent_backup/tree/1.0.4.
I will delete this test fork when you're done testing.

This fix has moved up to the 1.1.0 release now: https://github.com/Percona-Lab/mongodb_consistent_backup/tree/1.1.0

Hi @rob256, has this fix resolved the problems you noticed 100%? If so I will close this one


Accessory types

Hello,
I am using Blynk and I would like to know why in HomeKit it only identifies buttons / switches, regardless of the type of accessory that I put on it. Is there a way that I can identify temperature sensors or other things?
Thank you and have a nice day.

It's the only thing that I have implemented right now.  I haven't added more functionality outside of these controls.  Is there anything in particular which would be wanted first?

Hello, i am using this plugin with Blynk and Homekit, but in Blynk we are using a "Button" a "Labeled Value" and a "Slider" so i would like that these 3 things to be interpreted in Homekit, because we are using the "BUtton - switch a plug On/Off" the "Labeled Value - show how much Watt we are consuming" and the "Slider - to give more or less power on the plug". So it would be very nice to have that in the plugin to be showed in Homekit.

Hey,
I love your plugin, but I miss a solution to read temperature for a nice automation. Is it possible for you to implement a temperature accessory? It would be very nice!

Great plugin.
I would also like to add a solution for reading temperature, humidity, air pressure, etc.
Thanks

Added several types that I could quickly test and corrected a handful of additional bugs I found


chore: add more test tags for pendo

Description

Added some additional tags for pendo on the defi modals

Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[x] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
closes #1713
Risk
low risk
Testing
n/a
Screenshots (if applicable)

merging without a second approval as these are data-test tags and CI has passed


Invisible triple intersection

I have a scenario with 3 circles and venn.js can't draw the triple intersection, the problem is that the label is invisible and I want to show it in the intersection location.
the scenario:
var sets = [ {sets: ['A'], size: 1200, label:'1200'},
{sets: ['B'], size: 1200, label:'1200'},
{sets: ['C'], size: 1200, label:'1200'},
{sets: ['A','B'], size: 20, label:'20'},
{sets: ['B','C'], size: 20, label:'20'},
{sets: ['A','C'], size: 20, label:'20'},
{sets: ['B','C','A'], size: 10, label:'10'},];
the result:

I want to see the label "10" at the center of the Venn.
what can I do?

Did you figure out a way do make them intersect? If so how?


Bump signing_clients for bug 1130109

r? @rtilder

There's a test failure, seems there's an issue with one of those two lines.
@rtilder do you have a clue? What can we do to help you investigate the matter?

Bug fix needed for signing-clients.  We'll need to bump the rev again.


Update version to 1.63.0 and remove lint

The automated 1.63.0 PR had some lint. Here I removed it.

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.
Here's what I've got...
For recipe/meta.yaml:

This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see https://github.com/conda-forge/conda-forge.github.io/issues/2102.

For recipe/meta.yaml:

libstdcxx-ng has been superseded by libstdcxx. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:build:
  ignore_run_exports_from:
    - {{ compiler("cxx") }}

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Thank you!


Bump identity.apps.console.version version to 2.9.8

Bump identity.apps.console.version to v2.9.8

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6939488292

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6939488258

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6939488292
Status: cancelled

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6939488258
Status: failure


white page with "loading..." in next.js

Hello everyone, I am using this code to expose an endpoint to view the UI, but I am getting a white page with the black text Loading...
All the loaded files like:
http://localhost:3000/admin/redis-manager/static/main.60a877d10e7392b80012.css
are responding with a 404
Any solutions?
This file is located at: /src/pages/api/admin/redis-manager.js
import { ExpressAdapter, createBullBoard, BullAdapter } from '@bull-board/express'
import express from "express";
const app = express();
const serverAdapter = new ExpressAdapter();
const basePath = "/api/admin/redis-manager";

serverAdapter.setBasePath(basePath);

createBullBoard({
  queues: [],
  serverAdapter
})

app.use(
  basePath,
  serverAdapter.getRouter()
);

module.exports = app;

If you mount the app at /api/admin/redis-manager you should open the app at this path

The basePath variable defines the path that you are mounting the app to.
Mounting point = what is the path that the app will operate on

Inside this I am sure the path is correct, because if it was wrong I wouldn't even get the "Loading..." text
app.use(
basePath,
serverAdapter.getRouter()
);
I am not sure about:
serverAdapter.setBasePath(basePath);
I already tried with
serverAdapter.setBasePath("/src/pages/" + basePath);
serverAdapter.setBasePath("/pages/" + basePath);

But none of them are working

I'm not sure how Next.js works with this exported Express app....
Is something any other end point on that express app works this way?

This is indeed not a traditional way to do it, as I tried every other configuration posted here (next-connect), but they all resulted in a "not found".
that's why I used this simpler approach, and it's working great but the only problem I am facing is this issue with loading css and js files from @bull-board/ui

Thank you for supporting me 🙏🏼
Will you be able to share your screen via Discord?
I'll available in one hour or so...will happy to check your setup.

My pleasure!
I'll be happy to do it, do you have a discord server that i can join?

felixmosh#0178

I added you, just write me a message when you are free

Can we close this issue? :)

Sure, apologize for the delay, and thanks once again for the help
For anyone else interested my solution was to name the file following the wildcard format:
[[[...index]].js]
import { queues } from "../../../../config/queue.mjs";

import { ExpressAdapter, createBullBoard, BullAdapter } from '@bull-board/express'
import express from "express";
const handler = express();
const serverAdapter = new ExpressAdapter();
const basePath = "/api/admin/redis-manager";

serverAdapter.setBasePath(basePath);

const router = serverAdapter.getRouter();

createBullBoard({
  queues: queues.map(q => new BullAdapter(q)),
  serverAdapter
})

handler.use(
  basePath,
  router,
);

export default handler;

Sure, apologize for the delay, and thanks once again for the help
For anyone else interested my solution was to name the file following the wildcard format: [[[...index]].js]
import { queues } from "../../../../config/queue.mjs";

import { ExpressAdapter, createBullBoard, BullAdapter } from '@bull-board/express'
import express from "express";
const handler = express();
const serverAdapter = new ExpressAdapter();
const basePath = "/api/admin/redis-manager";

serverAdapter.setBasePath(basePath);

const router = serverAdapter.getRouter();

createBullBoard({
  queues: queues.map(q => new BullAdapter(q)),
  serverAdapter
})

handler.use(
  basePath,
  router,
);

export default handler;

Hi, I'm new to nextjs can you please help me with this? , if possible can we connect?

I've sent u a request

From: Felix Mosheev @.>
Sent: 15 March 2023 17:02
To: felixmosh/bull-board @.>
Cc: Manoj Ravichandran @.>; Comment @.>
Subject: Re: [felixmosh/bull-board] white page with "loading..." in next.js (Issue #526)
I'm available on discord felixmosh#0178
—
Reply to this email directly, view it on GitHubhttps://github.com/felixmosh/bull-board/issues/526#issuecomment-1469839074, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A53PKL5VOKEEAA6BYCIQPFTW4GSFLANCNFSM6AAAAAAUD7FARI.
You are receiving this because you commented.Message ID: @.***>

Anyone have an updated method for Next.js's app router?


In dist/esm/index.mjs: swallowed error “TypeError: traverse is not a function”

I’m using import-remap in a "type": "module" package, imported as:
import remap from 'import-remap'

However, remap() was mysteriously not doing anything. After some confused debugging, I discovered a try{...} catch(e){} block swallowing all exceptions; when I removed it, I got:
TypeError: traverse is not a function
    at remap (file:///.../node_modules/import-remap/dist/esm/index.mjs:5:917)

Changing traverse(i,o) in that file to traverse.default(i,o) makes this error go away, which makes me think that something has gone wrong in the build process; but I'm not familiar with “moduloze” so I figured I’d report this and see what you had to say.

Hmmmm. I'm super confused.
Moduloze takes the original statement var { default: traverse, } = require("@babel/traverse"); in src/index.js file and transpiles that to import traverse from"@babel/traverse";. I believed that to be correct, because the babel docs indicate that's how you import the traverse(..) function correctly.
But in fact, if I try to import it in a test file, it's coming in as an object and not a function.

It seems clear that Babel's docs are wrong, or at least that they don't work in Node (I tried v14, v16, and v18).
I can't exactly recall, but I don't know if I ever actually tested the ESM build of import-remap (as a library), honestly. I know for sure that the projects where I personally use import-remap, I always use the CLI tool (not the library), and that tool definitely uses the Node/CJS version.
Seems like I definitely would have tested the ESM, but I cann't find any evidence that I did (or that it would have ever worked). So perhaps it's been some long-standing oversight. Ick.
I think we need to figure out definitively from Babel how it's supposed to be imported -- because the docs are clearly wrong -- and then I'll need to see if there's some way to make sure the Moduloze transpilation does that correctly for both ESM and CJS. Since the CJS already works, I need to make sure it doesn't break with accommodating the ESM. Could be tricky, not sure. Might have to change Moduloze, depending on how it shakes out.

https://github.com/babel/babel/issues/13855#issuecomment-945123514 seems to have the answer, or at least part of it:

The docs are imprecise. They have been written before that Node.js released native support for ES modules, and they assume that you are transpiling your @babel/traverse usage.
If you are using native ESM, whenever the docs use a default import (such as import traverse from "@babel/traverse") you need to get the default property of the default import:
import _traverse from "@babel/traverse";
const traverse = _traverse.default;

This is a side-effect of how the CJS-ESM interop has been designed, and we will fix it in Babel 8 (since it's a breaking change).

...so I guess their transpiling is conflicting with your transpiling, which is annoying. I guess Moduloze needs to special-case this somehow? (I haven’t tried it, but I’d guess import {default as traverse} from "@babel/traverse" would also work.)
Incidentally, I’m not using import-remap after all (it turned out not to be a good fit for my use case, so I ended up making my own little tool to import rewrites using acorn), so this bug is not currently blocking anything on my end.

it turned out not to be a good fit for my use case

other than the bug, I would be curious if you could share what was not a good fit.. always helps to understand other use cases besides the ones I have. :)

I’d guess import {default as traverse} from "@babel/traverse" would also work

Unfortunately, not... These two are not equivalent:
import {default as traverse} from "@babel/traverse"

import _traverse from "@babel/traverse";
const traverse = _traverse.default;

Very annoying conflict in transpilation strategy. I can't really think of any way for Moduloze to tell the difference... again, since it works fine for the CJS case already.

I would be curious if you could share what was not a good fit

Sure! I’m building a tool that takes a folder full of assets, and sticks hashes in the filenames (so you can serve them with Cache-Control: immutable). Obviously this also requires rewriting the imports, so that they still point to the right file after the rename. So my plan was to hash everything to the new filenames, then build an import map and remap everything (since this of course changes the contents of the file, rehash and repeat until it stabilizes, or build a DAG but I didn't bother to do that).
So the main reason remap wasn't a great fit is it only does exact-match rewriting, whereas I mainly want to to relative path rewrites. I considered adding support for that to import-remap, but I also want to move some files around in the hierarchy at the same time (so in order to get the right path in the end, the rewriter needs to keep track of both where the the files think they are and also where they’ll actually end up), which is straightforward in the design I ended up implementing but not really something that import maps are prepared to deal with.
As a more minor aesthetic concern, since import-remap round-trips through the Babel AST, it reformats the output file into a different style. (Notably it does entirely its own indentation, but it also does things like moving comments around a bit.) Since I was writing my own logic anyway, I solved this in my implementation by carefully clipping out bits from the original string rather than running codegen on the modified AST.

sticks hashes in the filenames (so you can serve them with Cache-Control: immutable)

Just for clarification, you mean something like "foo.js" becoming "foo.28djrkx4h9.js", right?
If so, is the hash the same across the whole set of files, or is it unique to each file?
I always thought just putting all the original named files in a generated sub-directory name, like "28djrkx4h9/foo.js" would be a better approach to this. And that wouldn't need an import-remap if the import URLs were all relative. But I never looked much further into it.

it only does exact-match rewriting, whereas I mainly want to to relative path rewrites

Yeah. The import-map "spec" is now stable (was changing a lot for awhile before it shipped in browsers). I planned to circle back and re-implement all the relative and wildcard matching features once that settled down.
Ironically, now that import-map is close to shipping in all major browsers, this tool will become rapidly less important and eventually mostly redundant.

I also want to move some files around in the hierarchy at the same time

Ahh, well... yeah that's definitely not a feature import-map would likely be helpful with.

the Babel AST, it reformats the output file into a different style.

Sigh. Yes, I've been frustrated with the lossy AST format JS tools use for more than a decade. I tried for years to get a better lossless "concrete sytax AST" format defined and adopted. But the Babel folks (at the time) resisted/refused, so as far as I was concerned, the effort died. And here we are. Most of the working group didn't think it was that big of a deal.
Of course, if TypeScript-in-comments had been a common thing back then, they probably would have cared more. Shrugs.
In any case, aren't you minifying production build assets that you're serving with cache:immutable headers? I would expect that for most usages of import-map.

In any case, thanks for your insight. Very helpful to consider future features (if any). :)

sticks hashes in the filenames (so you can serve them with Cache-Control: immutable)

Just for clarification, you mean something like "foo.js" becoming "foo.28djrkx4h9.js", right?
If so, is the hash the same across the whole set of files, or is it unique to each file?

Unique to each file. Putting the hash in the directory name would invalidate the entire cache whenever a single file changed.

I also want to move some files around in the hierarchy at the same time

Ahh, well... yeah that's definitely not a feature import-map would likely be helpful with.

I may be going a bit overboard on prettifying my URLs here, it's definitely not a critical feature to have :smiley:

In any case, aren't you minifying production build assets that you're serving with cache:immutable headers? I would expect that for most usages of import-map.

I remember the days when you’d see a cool feature on a website and use View Source to see how it was done :slightly_smiling_face: so since my files are small enough that minifying wouldn’t have any actual benefits, I decided to expose how the sausage worked, so to speak.


Update vpn-gateway-ipsecikepolicy-rm-powershell.md

we have a bug on 3600 seconds lifetime (RDtask 9459737)
so we shouldn't use exactly that value as an example. we can use 7200 seconds as we already have such an example later in the page.

@stegag,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@stegag : Thanks for your contribution to the Azure documentation! The author, @yushwang, has been notified to review your proposed change.

#sign-off


API Keys Feedback

You write: The Rack may be temporarily unavailable while the change takes effect.. Truth is it takes up to an hour. There is not notice... no logs... nothing. It's just "click reload for an hour like an idiot`. Come guys get some notifications for god's sake.

 Docs: Keyroll


crypto configs

Hi there. i dont know how to contact you
Have a question about crypto configs. Can you explain where to put it?
Thx

Hi, you can place it anywhere and run nodes with config path parameter.
DASH example:
dashd -conf=/root/.dashcore/dash.conf

Etherium example:
geth --http --http.api personal,eth,net,web3 --config "/root/.etherium/config.toml" --cache 2048

Monero example:
monerod --detach --config-file=/root/.bitmonero/monerod.conf
monero-wallet-rpc --disable-rpc-login --config-file /root/.bitmonero/monero-wallet-rpc.conf

Bitcoin config default location:
/root/.bitcoin/bitcoin.conf

Zcash config default location:
/root/.zcash/zcash.conf

Thx for your answer. Sorry for an issue, i didn't find any contacts here to contact you directly.
Found and set.
Awesome repository. Almost all working without any issues. Only have issues with BE install (


busybox: fix patchShebangs & build

Our patchShebangs expect coreutils stat instead of busybox stat.
This broke patching the dispatch script. By enabling strict
dependencies and using explicit --host parameter we not only
avoid cross-compiling breackages but also work around this problem.
Signed-off-by: Jörg Thalheim<EMAIL_ADDRESS>
Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Fixes the nixos tests on staging-next. LGTM.
❯ nix-build -A busybox
/nix/store/kbz9qzjqkv2x5y4gkxcqgjfj8d0y0adh-busybox-1.32.1
❯ nix-build nixos/tests/knot.nix
/nix/store/8cl3k1rq5jpq0q3li9niy5i746c8jncb-vm-test-run-knot


Allow dismissing beta notification

This commit lets the user dismiss the beta notification and saves whether the notification has been dismissed or not in local storage. The branch build history link is moved to the header so that it remains visible even after the notification has been dismissed.
I added a css class to the link so it should be easy for use to see in heap how often people are clicking this button.

@gchomatas @jonathanwgoodwin @markhazlewood

LGTM


Provide example configuration files for common setups

We should provide configuration files for the common setups, so it's easy to get started. We should cover at least:

All cloud providers (already done with walkthroughs, but maybe we can improve that)
All operating systems (Ubuntu, CentOS, CoreOS)
Other (please comment if you have ideas!)...

/close
duplicate of #254


Warn about unsaved changes

Description
Following @happyimadesignr's request, this adds a standard warning about unsaved changes to the heatmap page.

It's gated on being admin like the save button.
@happyimadesignr did you expect this to prompt on the first save only or all unsaved changes? As it stands, it works on all unsaved changes.
Test

open a heatmap
click back, see no warning
open a heatmap
change taxon level
click back, see warning
open a heatmap
change taxon level
save
click back, see no warning
create a new heatmap
click back, see no warning

Hey @gregdingle, I think all unsaved changes works.

Is this only for the back button or does it show up when users click outside the page, like on the logo or somewhere else in the nav dropdown?

I think for browser back button you can only use the default message right? But do we have any other control over how the content is displayed? Like can we change the "Leave Site?" wording?

For exiting the page from within the page, can we use a custom message.
@tfrcarvalho Created this for the warning for when someone is making their project public:

@MarkAZhang and I had talked about having this when exiting the upload flow, but I'm not currently seeing it.

Replies to @happyimadesignr

Is this only for the back button or does it show up when users click outside the page, like on the logo or somewhere else in the nav dropdown?

It will show up whenever someone navigates to a new page or closes the tab.

I think for browser back button you can only use the default message right? But do we have any other control over how the content is displayed? Like can we change the "Leave Site?" wording?

No, we do not. This actually changed in the last few years because of abuse by sites. Now the browsers only display a standard message, like the Chrome one here.

For exiting the page from within the page, can we use a custom message.

No unfortunately for the reason above.


Unable to run the ExampleApp

Hi! I am trying to run the example app but i am getting this error:
diff: /../Podfile.lock: No such file or directory
diff: /Manifest.lock: No such file or directory
error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.
I understand i need to install cocoa pods, but i am unclear as to why if i am using swift?

Yes, build fails for me too with same error

You need to run 'pod install' first


upgrade (mostly) production deps

after #3016 but before v4.0.0, these production deps should be upgraded to the latest version, if not too painful:

commander
debug
diff
glob
lodash.create
readable-stream
supports-color

the following dev deps should be upgraded as well, with caveats:

karma-phantomjs-launcher: this should be part of #2979
karma: depends on previous item
browserify: unknown effect on browser bundle

merged


Change way PostgreSQL version is displayed

For example
PostgreSQL 9.3.6
instead of PostgreSQL 9.03<IP_ADDRESS>

Thanks Graham!

No worries, very exciting for me to get my first bit of code int the project!
Thanks for the opportunity
g


Set icon color in Top Navigation based on pimary colour defined in global theme

💬 Question
I have an icon defined in my TopNavigationAction, but the icon colour defaults to white. In my global theme I have set orange as primary colour. How can I configure the TopNavigationAction or Icon to recognize the orange colour I have set in my global theme?
As shown in the screenshot, the bottom tab icons are orange (following the colours I have defined in global theme), I would like to have the same orange colour as the icon in the TopNavigation.

Below is a snippet of the code:
import React from 'react'
import { Layout, TopNavigation, Icon, TopNavigationAction } from '@ui-kitten/components'

const AppBar = () => {
  return (
    <TopNavigation accessoryLeft={() => <TopNavigationAction icon={props => <Icon {...props} name={'person-add-outline'} />} />} />
  )
}

const FriendsScreen = () => {
  return(
    <Layout style={{ flex: 1 }}>
      <AppBar />
    </Layout>
  )
}

export default FriendsScreen

Thanks in advanced!
UI Kitten and Eva version

Package
Version

@eva-design/eva
2.1.0

@ui-kitten/components
5.1.0

Hey 👋
There actually are two ways to achieve this:

Configure it with mapping

Basically you need to override this variable with color-primary-default in mapping file of your app. Also, don't forget about the state colors, at least active color, to achieve a proper touch effect.

Override the color with JS

This, however, doesn't solve the problem completely because it's not possible to override the icon color in pressed state.
import { useCallback } from 'react';
import { TopNavigation, TopNavigationAction, Icon, useTheme } from '@ui-kitten/components';

const AppBar = () => {

  const theme = useTheme();

  const renderBackIcon = useCallback((props) => (
    <Icon
      style={[props.style, { tintColor: theme['color-primary-default'] }]}
      name='person-add-outline'
    />
  ), []);

  const renderBackAction = useCallback((props) => (
    <TopNavigationAction icon={renderBackIcon} />
  ), []);

  return (
    <TopNavigation accessoryLeft={renderBackAction} />
  );
};


UML-1631 - Remove commands for AWS Code Artifact

Purpose
Python packages have been moved to PyPi so gathering user credentials and logging into code artifact are no longer needed.
Approach
Learning
Checklist

[x] I have performed a self-review of my own code
[ ] I have added relevant logging with appropriate levels to my code
[x] I have updated documentation where relevant
[ ] I have added tests to prove my work
[ ] I have run the integration tests (results below)

Nice  🚀

Just going to check opg-lpa works locally before merging


[FEATURE REQ] Identify untranslatable value exists in FormRecognizer CustomModel analysis

Library or service name.
Azure.AI.FormRecognizer
Is your feature request related to a problem? Please describe.
When processing a document against a custom trained model, when a value is present but not able to be translated (such as a signature), would it be possible to include something in the response to identify it as having a value though it wasn't able to be processed?
The specific use case is that our client needs to know that a document was signed by the parties involved.  Without this feature, someone will be required to manually review thousands of document images per week to verify that they have been signed.
I have attached an example of mock data to illustrate the issue.

The Form Recognizer library does provide functionality that can tell you if something was handwritten (and if you know the field and location, you could assume it is a signature).
For example, on a RecognizedForm object you could look at the Lines property https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/formrecognizer/Azure.AI.FormRecognizer/tests/samples/Sample2_RecognizeCustomFormsFromUri.cs#L80 and look at the Appearance.
Here is an example: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/formrecognizer/Azure.AI.FormRecognizer/tests/samples/Sample1_RecognizeContentFromUri.cs#L42
Let me know if this helps


requireWithJadeify might not need to specify variables

We might be able to just use benv.require and determine what we need to set

Thanks @1aurabrown !


Relocate dependencies_* methods to private field of Dash class

This PR proposes to relocate three methods:

dependencies_set
dependencies_get
dependencies_get_internal

to the private field of the Dash R6 class. Closes #65.

@TahiriNadia If you could take a look, would be grateful. Thanks in advance! 🙂

@TahiriNadia Please review this PR, and confirm that removing these methods does not cause any issues with loading DashR apps. It should not cause any issues, but we'll need to be certain. Thanks 🙂

The update gives me an error
Error in eval(parse(text = example.ready.for.eval)) :
  attempt to apply non-function
Calls: source ... withVisible -> eval -> eval -> <Anonymous> -> eval -> eval
Execution halted

eval(parse(text=example_string)) is used in utils.R file
LoadAndDisplayComponent <- function(example_string) {
  return(htmlDiv(list(
    htmlDiv(
      children=dccSyntaxHighlighter(example_string),
      className='code-container'
    ),
    htmlDiv(
      className='example-container',
      style = list("overflow-x" = "initial"),
      children=eval(parse(text=example_string))
    )
  )))
}

eval(parse(text=example_string)) is used in utils.R file

@TahiriNadia The utils.R script is not part of the DashR package; there are no eval(parse calls in DashR itself.
Could you try again, but instead of the DashR docs, try a simpler test application or two? Remember that this branch is old enough that it still uses layout_set instead of layout.
I just re-ran my code, and there are no issues on my side when removing these methods (they aren't essential for writing a basic app, so it makes sense). Thanks in advance for your help.

I think I see what's happening here. The methods have been :hocho:, but the docs need to be regenerated to reflect this.
I believe it makes sense to :hocho: these, they aren't necessary anymore -- we should use assets, external_stylesheets, and external_scripts to serve dependencies, as this is idiomatic for Dash in Python as well.
Since I'm not using this API either, it feels a bit pointless to privatize it at this point. This is the old way, we're pretty close to abandoning htmltools altogether, and it seems likely they'll eventually fail. My plan post-release is to refactor dependency management to more closely mimic the Python side of things anyhow.
@alexcjohnson @nicolaskruchten May I excise these methods :point_up: ?

Yes, 🔪

I agree 🔪 if not needed. You can 💃


fix: [dashboard][co-edit] Round client-side lastModifiedTime

SUMMARY
In #11220 and #11305, we introduced a feature that prevent mid-air collision when 2 users editing same dashboard. There are some users in airbnb reported that when only 1 user editing dashboard a couple of times they will see the warning message, even there is no co-editing happens, see issue #11477
When i debug this issue, i found when error happens, it shows client-side last_updated_time and dashboard's changed_on has a very subtle mis-match, for example:
remote:1604869261.688
changed_on:1604869262.0

it seems dashboards table's changed_on is rounded-up to second level, while client-side last_update_time is not.
So i will add a round function in client-side and try to make this number match in the second level.
TEST PLAN
CI and manual test
ADDITIONAL INFORMATION

[x] Has associated issue: #11220 and #11305

cc @ktmud @eschutho @mistercrunch @zuzana-vej

Codecov Report

Merging #11614 (158fa13) into master (849e7e9) will decrease coverage by 1.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11614      +/-   ##
==========================================
- Coverage   62.26%   60.92%   -1.35%
==========================================
  Files         873      422     -451
  Lines       42256    26282   -15974
  Branches     3961        0    -3961
==========================================
- Hits        26310    16011   -10299
+ Misses      15766    10271    -5495
+ Partials      180        0     -180

Flag
Coverage Δ

javascript
?

python
60.92% <ø> (-1.00%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
31.91% <0.00%> (-59.58%)
:arrow_down:

superset/db_engine_specs/hive.py
53.90% <0.00%> (-30.08%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
69.76% <0.00%> (-12.53%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/api.py
81.94% <0.00%> (-6.02%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 466 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 849e7e9...158fa13. Read the comment docs.

Mmmh, it feels like using/comparing the client time and server time is a brittle approach as time zones and/or a wrong client clock would create problems.
Could we just rely on the server time stamp and use it as the equivalent of a version number? Meaning even when we save the server could return a payload with a new server side timestamp that we can stick into the redux store and send on the next save event a an equivalent to a version id.

Could we just rely on the server time stamp and use it as the equivalent of a version number? Meaning even when we save the server could return a payload with a new server side timestamp that we can stick into the redux store and send on the next save event a an equivalent to a version id.

Yes, i am also looking for a solution like that. Currently /save_dash/ API only response status without no changed_on timestamp:
https://github.com/apache/incubator-superset/blob/29554a9f02264b7f619829cbe01dc6d5c25b30f8/superset/views/core.py#L1089
what is best way to get its changed_on after an update?

I pushed the 2nd solution: server-side returns last_modified_time (which is changed_on after latest update) in save_dash API. Front-end updates redux state, and send back this value for the next save request.

Hey side note (totally supportive of merging this!) but wanted to try and understand better how we prevent users from colliding with themselves. I think we have many ways that we update the dashboard definition (many modals)

Do we check the version on all/some of the endpoints?

Do we check the version on all/some of the endpoints?

Hi @mistercrunch All the changes from dashboard header dropdown list, go through single API /save_dash/.
But changes in Dashboard Properties Modal, first save to /dashboard/api/v1, then save again to /save_dash/.
Please see my findings here: https://github.com/apache/incubator-superset/pull/10834#issuecomment-707508315


Add Ubuntu 20 to local dns bypass template

Live test is failing on Ubuntu with local DNS error we have faced in the past on Ubuntu 1804 image. We are facing this issue again on Ubuntu 20.04 image. PR is to run bypass DNS step on Ubuntu 20.04 as well.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

For some reason this was not mereged.


Rename NeMo-related TOML configurations to reflect the exact model

Summary
Rename NeMo-related TOML configurations to reflect the exact model
Test Plan
[TODOs]

First, we need to make sure we are on the same page. Otherwise, we should discuss.
Second, we need to reach out to anyone using GPT- or LLaMA-related configurations to confirm everything is functioning properly.

I believe we need @Bohatchuk's approval.


New version: QuestSoft.QTranslate version 6.9.0

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


[FR] More accurate error message for named exports in <script setup>

Currently, it's "Modifiers cannot appear here." which is very general and gives the user the impression that it's not a Vue related error, I suggest changing it to something like "Named exports can't be used in <script setup>.", which is more accurate.

Fixed by #2582


Minor cleaning in BaseEnv classes

Description
This cahnge adds annotations for abstract methods and fixes a repeated override
Motivation and Context
Code cleaning

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Remove all that do not apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)
[ ] Example (update in the folder of examples)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[X] I have read the CONTRIBUTION guide (required)
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly (required for a bug fix or a new feature).
[ ] I have updated the documentation accordingly.

For the linting, check
https://github.com/pytorch/rl/blob/main/CONTRIBUTING.md
TL;DR running pre-commit will do  the work!

Oh ok sorry missed that, when I finish travelling I’ll look into updating the tests


Errors should have a bound for Debug + Display

Error types (most notably Deserializer::Error) are not bounded to implement Debug or Display, which means that at all points where the actual Error type is not known, the error cannot be printed.
I'd suggest adding those bounds to the actual Error trait, perhaps through using std::error::Error. http://doc.rust-lang.org/std/error/trait.Error.html

Is this blocked only on the gitcop issue on the pull request? This would be really great to have.

No, that was me just dropping the ball. Merged it in to the 0.7.x (master) branch.


Add type annotations

Resolves #3 by adding type annotations!

It's always WYD and never LYWSD03MMC :'(


[WIP] Sync ec2 instances with re:invent 2019 announcements

Tracking EC2 instance type announcements from re:invent.
Signed-off-by: Naadir Jeewa<EMAIL_ADDRESS>

/assign @detiber @chuckha @vincepri


GUVNOR-2933: Guvnor ALA integration

Hello  @manstis @porcelli  this is just a minor PR derived from the one in kie-wb-commons.
Would you mind review?
Depends on droolsjbpm/kie-wb-common#714
Thanks.

Jenkins please retest this.

Jenkins please retest this.


add ReadFileWithRedact function to redact sensitive data in log output

This is for issue https://github.com/cloudfoundry/bosh-utils/issues/69

Hey @gu-bin,
The team took a look at this and we see the use-case that is being addressed here. However, we felt that the responsibility of redacting should be moved out to whoever is consuming bosh-utils. There is currently a way to prevent the file contents from being logged.
Does that sound reasonable?
Thanks,
aakash

Hi @aashah, thanks for the reply.
We do need to log the file content as there are other useful but not credential informations in it. If redact the file content before consuming bosh-utils, we need to create a new file with credentials redacted and pass the new file path to bosh-utils. Then bosh-utils will log the redacted file content but also return the redacted one to the caller which is not expected. The caller needs the actual file content without any redact. So we only want fs.logger.DebugWithDetails called in bosh-utils to take the redacted file content. Please consider the requirement. Thanks.

I do not fully understand your concerns, it's unclear why another file must be created as part of this workaround. I'm interested in hearing a clarification, but I'll also try to clarify my original response as well -
There is a flag in the existing ReadFileWithOpts (ReadOpts.Quiet) to prevent the file from being logged. Here's some psuedocode for what I'm describing:
content, err := bosh-utils-fs.ReadFileWithOpts("/some/path.txt", ReadOpts{Quiet: true})
redactedContent := redact(content)
myLogger.Info(redactedContent)

With this way, you can use the existing bosh-utils, redact the contents, and log them.
Can your problem be solved this way?
thanks
aakash

@gu-bin Bumping to see if you had a chance to look over @aashah's comment. We're gonna close this PR for now, but please don't hesitate to re-open.


Ensures all publisher's and subscriber's settings are configurable

Addresses #92's point:

Revisit configuration, make sure all settings are configurable via a bean, e.g., RetrySetting

Why not just make the SubscriberBuilder a constructor argument here?

@meltsufin because the subscription builder takes a subscription name that we only pass in getSubscriber().
Do you think there's value in taking in a Subscriber.Builder in the constructor and then just complement that builder with the subscription name at getSubscriber() time?


1:1 Federation Chat doesnt seem to work

I've done everything suggested in this document for 1:1 Federated chat to work, and nothing seems to work. Each time an error appears stating "Failed to send. We ran into a problem sending this message. Try again later". I've test this with three or four different O365 Tenants that have Teams functional internally - it's the external federation that seems to not be working. Additionally, the scenario 1, 2 and 3 do not make sense - how can open federation on one tenant allow incoming and outgoing messages, yet the second tenant requires the domain to be added in "Allow"?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59900927-5e5f-77a4-04be-e05a91330fca
Version Independent ID: 1e4d6b87-f57c-fa45-1630-3c32b821d93c
Content: Manage external access (federation) in Microsoft Teams
Content Source: Teams/manage-external-access.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@AndrewCalvo Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@nomorephones - can you help out here please?

@AndrewCalvo - Did you wait 24 hours to test it?

@AndrewCalvo - What apps are you trying to get working?

@tonysmit I did wait 24 hours, and it seems to be working between certain tenants. I was under the impression that it would be instantaneous, it didn't indicate that it may take 24 hours to take effect. One tenant it is not working through is one that is on the GCC, could that be a limitation whereas a Non-GCC and GCC tenant cannot have 1:1 Federation?
The app we were trying to get working is just basic Microsoft Teams chat, either via web interface or smartphone app.
In addition, I'll reiterate that the instructions are confusing in Scenario 1; the instructions state "It lets people in your organization find, call and send instant messages, as well as set up meetings with people external to your organization". Yet the next sentence states external domains must be setup to allow your domain. If both organizations are setup as "Open Federation" then the requirement to "allow your domain" is not relevant.

@AndrewCalvo - Thanks for the explanation and details. I will make sure to include a note that replication across DCs may take up to 24 hours. I'm not sure of the limitations with GCC, but I will ping the PM.
For the last part in Scenario 1: I copied this sentence from the doc.
"When you use this set up, your users can communicate with ALL external domains that are running Teams but have set up their domain/organization to allow your domain."
The other Teams domain/organization must also either being using Open Federation OR have your domain listed as an allowed domain. I don't see the problem with that sentence to be honest.

@tonysmit - By adding that additional sentence "The other Teams domain/organization must also either be using Open Federation OR have your domain listed as an allowed domain" clears up any confusion.
Due to the text "..but have setup their domain/organization to allow your domain" I read Scenario 1: as requiring Tenant B needing to be setup as specified as Scenario 2:. In order words, two Open Federation tenants cannot communicate with each other - unless one of the two tenants is utilizing the Allow or Block scenario.
Thank you for clarifying this for me.

@AndrewCalvo - Of course and thanks for the feedback. It makes it very clear now. Appreciate it.


Adding more secure settings

Adding ordered cipher list, stronger settings in generate-ssl-certs script, and hsts settings

accidentally removed last commit...closing this..


Fix unconditional removal of last byte #53

Fix unconditional removal of last byte which is supposed to be a null byte, by adding a check for whether the last byte is a null terminator and adjusting size accordingly.

https://doc.rust-lang.org/std/ffi/struct.CStr.html#method.to_str
The function appears to have always been broken


fix: Ref was not being passed through for Picker

Pass through ref to SpectrumPicker correctly
Added a useMultiRef hook for handling multiple refs being passed in

I tested this with DHE, looks to be working correctly.


Support for pandas.core.series.Series type

I am trying to dispatch on class pandas.core.series.Series with code like,
import pandas as pd
@dispatch
def foo(x: Union[list, tuple, pd.core.series.Series]) -> str:
    ...

and I got error:
plum.function.NotFoundLookupError: For function "_quote", signature Signature(pandas.core.series.Series) could not be resolved.
It seems panas.core.series.Series is not considered as a class/type to be dispatch on. Can it be implemented? Or, it is there, but my code was wrong?

this might related to something else. I will check and confirm

I just tried and it works.

Yes, I think this should just work. @pengguanya let us know if you can't manage to figure it out!


Interesting doit use

Raising this so you can see an interesting advanced usage of this project in my latest package.
https://github.com/z3z1ma/alto

cool. thanks for letting me know.
would like to add a "success story"?
https://pydoit.org/stories.html


Google Map Must move on location change

Is this a bug report?
Yes
   When the showUsersLocation is enabled, on change of location the bule dot will move. But the map won't move.

Have you read the Installation Instructions?
yes
Environment
react-native: 0.45.0
react: 16.0.0
react-native-maps: 0.15.2

Steps to Reproduce
(Write your steps here:)

Install the plugin.

 Include the MapView
     <MapView
                  provider={PROVIDER_GOOGLE}
                  region={this.state.mapRegion}
                  onRegionChange={this._handleMapRegionChange}
                  showsUserLocation = {true}
     >

Expected Behavior
Map must move along with blue button when ever the location changes
Actual Behavior
Map is not moving along with blue dot

@RidaRidss Thanks for your response. My requirement is when ever user changes location, the map should recenter automatically to his position as google maps works. But your code works only when user clicks the button,  it will recenter to user position ?

yes it will

#2032 closes this

I don't think it should follow the user location by default but only when explicitly requested to do so. A prop for this could be named something like userTrackingMode.
MapKit (iOS) has the userTrackingMode property for this exact case. Possible values are none (default), follow, and followWithHeading.
Don't know if Google supports this though – as I can't seem to find any method on the Google Documentation about this – but perhaps something can be worked out manually now that https://github.com/react-community/react-native-maps/pull/2032 got merged.

@bramus great investigation. Actually now it's implemented with followUserLocation prop and by  [mapView setRegion:region animated:YES];

Well, for Android unfortunately you have to DIY, but it gives you greater control.
First the map:
        <MapView
          onUserLocationChange={this._setMyLocation}
          onRegionChangeComplete={region => this.setState({ region })}
          ref={ref => (this.map = ref)}
          showsUserLocation={this.state.showsUserLocation}
          followsUserLocation={this.state.followsUserLocation}
        >

State of course:
  state = {
    region: {},
    myLocation: {},

Then I put 2 buttons that control showing and following user location.
          <TouchableOpacity
            onPress={() => this.setState({ showsUserLocation: !showsUserLocation })}
          >

and
          {showsUserLocation && myLocation ? (
            <TouchableOpacity
              onPress={() => {
                if (!followsUserLocation) {
                  this._gotoCurrentLocation();
                }
                this.setState({ followsUserLocation: !followsUserLocation });
              }}
            >

And finally the methods:
  _gotoCurrentLocation() {
    const { myLocation, region } = this.state;
    this.map.animateToRegion({
      latitude: myLocation.latitude,
      longitude: myLocation.longitude,
      latitudeDelta: region.latitudeDelta,
      longitudeDelta: region.longitudeDelta
    });
  }

  _setMyLocation = event => {
    const myLocation = event.nativeEvent.coordinate;
    this.setState({ myLocation });
    if (
      this.state.followsUserLocation &&
      this.state.myLocation.latitude &&
      this.state.myLocation.longitude
    ) {
      this._gotoCurrentLocation();
    }
  };

Hope this helps.

Try to pass the parameter "distanceFilter: 10" in watchPosition. Set to 0 to not filter locations. Defaults to 100m.

Very old issue, and seems to have various solutions for it, closing.

Try this, put your marker in center of map, when user move the map, get the last location with onRegionChangeComplete. You can read the concept from this link
https://alizahid.dev/blog/keep-marker-in-center-and-move-map-around-it


add new prql file and text editor context menus

as described in #113, #115, #116 and #117.

New file explorer context menus:

Very nice!


GrpcClientMetricAutoConfiguration conflicts with MeterRegistryCustomizer due to eager initialization of MeterRegistry

The context
Added a custom MeterRegistryCustomizer to add a default tag (micrometer provided) to all the metrics.
The bug
What's the problem? What's not working? What do you expect to happen.
Expect the custom tag to be added to all the metrics captured by the application. However, when adding this library, the custom tags are not added. Excluding certain AutoConfiguration classes (e.g. GrpcClientMetricAutoConfiguration) causes the tags to be added. It seems, these tags are skipped before MeterRegistryPostProcessor is able to post-process the MeterRegistry bean and add MeterRegistryCustomizer logic.
Stacktrace and logs
Is there a stacktrace or a hint in the logs? (very important)
Screenshots work as well, but don't screenshot your logs.
"Bean 'metricsClientInterceptor' of type [net.devh.boot.grpc.client.metrics.MetricsClientInterceptor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [grpcClientBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.",   "Bean 'net.devh.boot.grpc.client.autoconfigure.GrpcClientMicrometerTraceAutoConfiguration' of type [net.devh.boot.grpc.client.autoconfigure.GrpcClientMicrometerTraceAutoConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [grpcClientBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.",   "Bean 'org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration' of type [org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [grpcClientBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.",   "Bean 'observationRegistry' of type [io.micrometer.observation.SimpleObservationRegistry] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [grpcClientBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.",   "Bean 'globalObservationClientInterceptorConfigurer' of type [io.micrometer.core.instrument.binder.grpc.ObservationGrpcClientInterceptor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [grpcClientBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.",   "Bean 'grpcClientConfig' of type [in.dailyhunt.reco.service.interceptor.GrpcClientConfig$$SpringCGLIB$$0] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [grpcClientBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.",   "Bean 'customInterceptor' of type [in.dailyhunt.reco.service.interceptor.UserProfileServiceClientInterceptor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [grpcClientBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.",   "Bean 'asyncStubFactory' of type [net.devh.boot.grpc.client.stubfactory.AsyncStubFactory] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [grpcClientBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.",   "Bean 'blockingStubFactory' of type [net.devh.boot.grpc.client.stubfactory.BlockingStubFactory] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [grpcClientBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.",   "Bean 'futureStubFactory' of type [net.devh.boot.grpc.client.stubfactory.FutureStubFactory] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [grpcClientBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies."
Steps to Reproduce
Steps to reproduce the behavior:

Implement a custom MeterRegistryCustomizer
@Bean MeterRegistryCustomizer<MeterRegistry> metricsCommonTags() {  return registry -> registry.config().commonTags(Tags.of("host", "host-1").and("module", "mymodule")); }
Use the library to implement a GrpcClient implementation.
Start the application with @SpringBootApplication(exclude = {GrpcClientMetricAutoConfiguration.class}) and without. When starting with the auto-configure classes excluded, the tag 'host' and 'module' are added to all metrics. If we do not exclude the autoconfigure classes, the metrics do not carry these tags.

The application's environment
Which versions do you use?

Spring (boot): 3.2.3
grpc-java: 1.47.0
grpc-spring-boot-starter: 3.1.0.RELEASE
java: version + architecture (64bit?) 21, linux-x64 and aarch64
Other relevant libraries... spring-boot-actuator and prometheus

Additional context

Did it ever work before? Not sure.
Do you have a demo? Not immediately but should be easy to create one.

I have same problem.
It happens because BeanPostProcessor initializes beans eagerly in postconstruct, it makes every dependency (including transitive) being unavailable for post processing.
It can prevent exporters like prometheus to be initialized properly, because it's also done via BeanPostProcessor

I have the same problem. With the GrpcClientMetricAutoConfiguration, the JVM metrics are not returned.
When I start the application with @SpringBootApplication(exclude = {GrpcClientMetricAutoConfiguration.class}), then the JVM metrics are returned. For example, the metric system_load_average_1m:

I have Spring Boot 3.4.1, Spring Cloud 2024.0.0 and grpc-client-spring-boot-starter 3.1.0.RELEASE.
It would be nice to have a workaround where I can have the JVM (and other) metrics and the gRPC metrics.


zh-cn translation for usage docs

[x] agit-support
[x] clone-filter
[x] incoming-email
[x] labels
[x] linked-references
[x] merge-message-templates
[x] permissions
[x] profile-readme
[x] protected-tags
[x] push
[x] repo-mirror
[x] secrets
[x] template-repositories
[x] webhooks

suggest backport @lunny @techknowlogick


Promise fulfilled after zone cycle (ES5)

Tried using this.variable.push() in the way described below, and DOM didn't update in the current cycle
function component(){
    var self = this;
    this.thing = [];

    // just an example of a .then statement
    fetch(apiKey.json).then(function(res){
        self.thing.push("anything");
        // do stuff with res, etc.
    }) // finish fetch call (.then().catch())
}

(Didn't finish the code because the rest of it is irrelevant)
this.thing would update, but wouldn't be pushed (also in the annotations changeDetection was set to "ON_PUSH"). The only way it would show up is if I used a work around I figured out which relies on a document.getElementById('textBoxID').focus(); call follow by this: (focus)="contentLoaded()" on the textbox element, which would just call this.contentLoaded in my constructor, which then initiates the cycle again, showing my pushed content.
I don't think Zone.js is waiting to update until the .then call finishes, it seems as if it finishes its cycle, and doesn't care that something was updated after. If I'm just using something wrong please let me know, this is proving to be a huge issue for my app. Also I'm willing to provide more information to be more specific

Hard to say what's going on without a complete example - a Plunker would help here.

Will add momentarily

Here is the plunker:
http://plnkr.co/edit/p3Ipvw4SNut0XLOn76kJ?p=preview

There is no issue with zone.js here. The problem is that you use the OnPush strategy, see https://github.com/angular/angular/issues/4746


.NET Core assembly signing and loc

https://github.com/Microsoft/RTVS/commit/f07ac955d7e51dd82df9ad7db7f532e87a7e0b24


fix: accessibility of buttons

Description
Please read the Contribution Guidelines before opening a pull request. Include a summary of the change and which issue is fixed.

add sr-only class for icon only buttons

Closes #510
Browser checklist
This PR has been tested in the following browsers:

[ ] Chrome
[ ] Firefox
[ ] Safari

Testing checklist

[ ] End-to-end tests have been created if necessary

I was not able to properly test it, as development server, production build was causing TS related errors. But I don't think that this change needed that big of check, no change in functionality.

@all-contributors add @tomasvn for code


Sorted parameters for named constructors

This should close https://github.com/ably/ably-flutter/issues/351. Parameters in named constructors are now sorted alphabetically. I've also done a quick cleanup of imports, mostly by removing cupertino and material imports, and replacing them with meta which is a non-UI package.

LGTM 👌


Prefix all custom Bootstrap functions with bs

I've overridden the native scale-color() function. To avoid any conflicts with native functions and make it clear to others what are custom Bootstrap functions, I've prefixed all functions with bs-.
Fixes #32140

Thinking about this, do we really need to prefix every function? Can we instead change only the custom scale-color() function to something like step-color() or shift-color()?

Until Sass itself removes all of deprecated functions that aren't under namespaces, this could happen with any function that Bootstrap defines, including any of those alternative function names. Since it's a bit early community-adoption-wise and a bit late development-cycle-wise to switch to Sass modules, prefixing seems like that next best way to both fix the current collision and avoid future ones preemptively. I could see this changing again with Bootstrap v6 if the switch to modules is made then, but that's neither here nor there.

Closing this for https://github.com/twbs/bootstrap/pull/32149


Hard Drive Marketing Page Rendering Issues

Example: https://main--shredit--stericycle.aem.live/en-us/marketing/shred-it-hard-drive-destruction
o	Image rendering way too big
o	Should have inline form placeholder (two column)
Should look like:

Closing this as its now resolved


无法运行

我用VS2015打不开Git上的Sample工程
我自建了一个工程，把代码导入后，也运行不了

@slicol Unfortunately, I don't think .NET Core projects work with VS 2015. It should work better with VS 2017.
You could also try to run the project from the command line:
dotnet run -p src\ImGui.NET.SampleProgram\ImGui.NET.SampleProgram.csproj

Thank you very much~


DrushStyle warnings with Drush 11

Don't know if this is something for this project but it seems like it might be able to help. When using DrushStyle with recent versions of Drush 11 you'll run into this problem:
 ------ ---------------------------------------------------------------------
  Line   web/modules/custom/my_custom/src/Commands/DrushCommandBase.php
 ------ ---------------------------------------------------------------------
  20     Instantiated class Drush\Style\DrushStyle not found.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ ---------------------------------------------------------------------

This is caused by a fix they added dynamically load different classes to support Symfony 6 and changed method signatures. 06eb4a45296e409c6af9b592d8bec0f555adedd8 Looking at the commit there are a number of other classes this would affect as well.
The problem seems to be that the class lives outside packagist autoloading so phpstan isn't picking it up. Drush is adding the root dynamically during preflight sort of like drupal module namespaces but based on the detected Symfony version which... could make things complicated.

Ah yeah, the Symfony compatibility folder. I ran into this during a live stream with some other problem but cannot remember how it was worked around.

scanDirectories:
- vendor/drush/drush/src-symfony-compatibility/v4

Thank you @neclimdul ! This saved my 🥓 . For others following this thread, add this under the parameters: section of your phpstan.neon file.


Any games using Acid ?

Hai, I am a c++ programmer (beginner - moderate), I wish to know how rigid is this game engine ?. I tried to build a game engine of my own a 2D engine to precise however due to lack of contributions I have to drop it. I am now planning to focus on games instead of engines. However good works bros - keep it up.
<EMAIL_ADDRESS>https://github.com/ThinkalVB/NearEarth

Hello, currently I am working some of the last kinks out of Acid while implementing new features. Acid compiles and runs on Windows, Linux, and MacOS between different releases and compilers. The only significant factor contributing to if Acid will run is platform Vulkan/Metal support. Developing a game engine is no small task, Acid was just me learning Vulkan and graphics programming. Acid is currently not running any games besides my side project of https://github.com/Equilibrium-Games/Microverse; however, I do have plans to use it in the future. If you have no issues with Acid please refrain from opening issues, if you have questions or comments you can email me at<EMAIL_ADDRESS>

I didn't find the email at first, it was dumb - sorry. Note taken. Yep, making a game is sort of a big pain.... Without a team, I am doomed. So not going behind a game without a team for now.


Suppressed expected errors in resource unit tests

The test "[Resource] Breaking circular references on save" produces errors
ERROR: Resource was not pre cached for the resource section, bug?
   at: _write_resource (scene/resources/resource_format_text.cpp:1882)
WARNING: Couldn't load resource (no cache): local://Resource_agy4p
     at: parse_variant (core/io/resource_format_binary.cpp:412)

The errors are intentional because the test uses uncached internal resources and as a result of the test the circular reference is broken. I tested out the branchpath in ResourceFormatSaverBinaryInstance::_find_resources that mentions circular references and found that it skips over internal resources.
I have only suppressed the parts that produce errors: saving to text and loading from binary.
Fixes: #80616

Changed the comment, should be good to go.

Thanks! And congrats for your first merged Godot contribution :tada:


Add highlevel maven packages and OMAG Server Assembly

Tracked under https://jira.odpi.org/browse/EGERIA-34
Signed-off-by: Mandy Chessell<EMAIL_ADDRESS>

Verified master is clean - was broken but now fixed.
Before pulling master, verifying just this PR
11:32 $ mvn clean install
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.odpi.egeria:subject-area-tools:jar:0.1-SNAPSHOT
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.odpi.egeria:repository-services-implementation:jar -> duplicate declaration of version ${open-metadata.version} @ org.odpi.egeria:subject-area-tools:[unknown-version], /Users/jonesn/IdeaProjects/egeria/open-metadata-implementation/access-services/subject-area/subject-area-tools/pom.xml, line 24, column 21
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[ERROR] [ERROR] Project 'org.odpi.egeria:admin-services-client:0.1-SNAPSHOT' is duplicated in the reactor @
[ERROR] Project 'org.odpi.egeria:admin-services-client:0.1-SNAPSHOT' is duplicated in the reactor -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DuplicateProjectException
✘-1 ~/src/egeria [mandy-chessell-distribution L|⚑ 4]
Pulled in latest master updates - no change, these two issues remain.
The warning is a simple duplication in the pom. That's in master too - but often not noticed until a build fails:
In the subject-area-tools pom:

org.odpi.egeria
repository-services-implementation
${open-metadata.version}

org.odpi.egeria
repository-services-implementation
${open-metadata.version}

We can delete one dependency entry
The second .. looking...

I think the build failure is caused by the same module being included in two places -- firstly as part of the main build tree (root->implementation->governance servers -> admin services -> client
& secondly under distribution- packages - client
Maven doesn't like this as it sees the entries twice. It's possible to build the packages alone (presumably) but the full build will fail.
We need to think through what we need here.. I wonder if we just need a virtual pom that depends on the other poms - that's good enough, so they are not modules (and so don't affect build), but are dependencies so that if another app wants to pull in open-metadata-client-package from maven, they will automatically get all the pieces we list?
This is distinct from the assemblies where we are layng down an archive for someone to run a server and want to pull in other files, scripts etc.. ?

Why is the build problem only picked up by subject area OMAS.  It is one of the last OMASs to build - is this because of the code generator?  It seems to suggest that the code generator is not properly integrated?  Did I understand that it is generating the code into src rather than target/generated-sources?  If so I think we may need to change that as I thought src should be the content of the SCM repository?

I was referring to a build failure of the overall project. Still fails with
[ERROR] [ERROR] Project 'org.odpi.egeria:admin-services-client:0.1-SNAPSHOT' is duplicated in the reactor @
This is due to the  statements in the new poms (they are already used elsewhere in the build>
You could use multiple aggregating poms and split from parent - though I wonder if this is overkill/confusing. Not an expert, but I would hope you could create a new module that simply prereqs the individual modules we need, and point consumers to those. So we will publish all the original poms, but make choosing the right ones slightly easier?


1811 adding missing general node selectors/affinity to core components

Ref #1811
Ref #2168

What does this implement/fix?
Put a x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[ ] Did you add new tests?

Any other comments?

This is ready for review!

I'll review this, this week

@sblair-metrostar Thanks for this PR, and sorry for the delay.  I think this is an good addition, and I'd like to get it into Nebari.  Are you still interested in working on it?

Since I haven't heard back from @sblair-metrostar, I'm going to close this PR in favor of https://github.com/nebari-dev/nebari/pull/2353.  Thanks for your contribution @sblair-metrostar!