New cypress

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.9 out of 10 committers have signed the CLA.:white_check_mark: sjimenez77:white_check_mark: dattuchillal:white_check_mark: lmarniazman:white_check_mark: chdattat:white_check_mark: derochs:white_check_mark: markusschuh:white_check_mark: suvmanda:white_check_mark: vapadwal:white_check_mark: monicalopezgris:x: Miguel Angel Magaña MascuñanaMiguel Angel Magaña Mascuñana seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


error initializing configuration '/etc/envoy.yaml': Protobuf message (type envoy.config.bootstrap.v3.Bootstrap reason INVALID_ARGUMENT:(static_resources.listeners[0].filter_chains) tls_context: Cannot find field.) has unknown fields

Title: filter_chains tls_context: Cannot find field
Description:

Hi, I am following documentation  from AWS on setting up envoy as sidecar.
I built docker image but when running the container, I ran into below error

2022-09-28 20:22:21.662][7][critical][main] [source/server/server.cc:117] error initializing configuration '/etc/envoy.yaml': Protobuf message (type envoy.config.bootstrap.v3.Bootstrap reason INVALID_ARGUMENT:(static_resources.listeners[0].filter_chains) tls_context: Cannot find field.) has unknown fields

I am using latest envoy-dev docker image - FROM envoyproxy/envoy-dev:latest

Here is the envoy.yaml config file

envoy.yaml
static_resources:
  listeners:
  - address:
      socket_address:
        address: <IP_ADDRESS>
        port_value: 443
    filter_chains:
      tls_context:
        common_tls_context:
          tls_certificates:
          - certificate_chain:
              filename: "/etc/ssl/my-aws-public.crt"
            private_key:
              filename: "/etc/ssl/my-aws-private.key"
      filters:
      - name: envoy.http_connection_manager
        config:
          codec_type: auto
          stat_prefix: ingress_http
          route_config:
            name: local_route
            virtual_hosts:
            - name: service
              domains:
              - "*"
              routes:
              - match:
                  prefix: "/"
                route:
                  cluster: local_service
          http_filters:
          - name: envoy.router
            config: {}
  clusters:
  - name: local_service
    connect_timeout: 0.5s
    type: strict_dns
    lb_policy: round_robin
    hosts:
    - socket_address:
        address: <IP_ADDRESS>
        port_value: 8080

admin:
  access_log_path: "/dev/null"
  address:
    socket_address:
      address: <IP_ADDRESS>
      port_value: 8081

[Relevant Links:]

Following envoy setup as sidecar documentation from AWS.
https://aws.amazon.com/blogs/containers/maintaining-transport-layer-security-all-the-way-to-your-container-using-the-application-load-balancer-with-amazon-ecs-and-envoy/#:~:text=cat <<EOF > envoy.yaml

Resolved issue after upgrading envoy.yaml as per version documentation here


update copyright notice

Scope & Purpose
Update copyright notices everywhere.
Accompanying enterprise PR: https://github.com/arangodb/enterprise/pull/539

[ ] :hankey: Bugfix
[ ] :pizza: New feature
[x] :hammer: Refactoring
[ ] :book: CHANGELOG entry made
[ ] :muscle: The behavior in this PR was manually tested
[ ] :computer: The behavior change can be verified via automatic tests

Backports:

[x] No backports required
[ ] Backports required for: (Please specify versions)

Testing & Verification

[x] This change is a trivial rework / code cleanup without any test coverage.

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11686/

Tests blue


When will the next official version of wakaama be released?

When will the next official version of wakaama be released?

@dongfuhai see the reply in roadmap #597


Update tokens.mdx to fix typos

A few typos, a bit of copy editing

Preview is available here:http://soroban-docs-pr555.previews.kube001.services.stellar-ops.com/


Add downloaded wal-g file check and some other adjustments

Description

Add wal-g download checksum check to avoid installing a corrupted or altered version. Moreover, the unarchiving task is adapted to the fact that the files included in the tar.gz of recent versions of wal-g have changed compared to older versions.
Remove wal-g always ansible tags because we don't want ansible to always execute the wal-g role if we are targeting another role of the playbook.
Set files's mode as advised by the ansible documentation.

Tests

Change the wal-g version to upgrade or downgrade it while replacing the corresponding sha256 checksum, then validate that the desired version is correctly downloaded and installed.
Repeat the same test but without updating the checksum and validate that an ansible error is thrown.
Run ansible on a different tag than the one used to include the wal-g role and validate that the wal-g role is no longer executed.

Didn't fit with general style, but idea is pretty clear


Stop passing default args for unsupported args

All default values for all args got passed to the Skaffold command, thus some of the commands fails with some of these arguments..
ex.
diagnose or deploy fails when receives --cache-file argument and exit with code 127 with error "unknown flag: --cache-file"
root@docker-desktop:/Users/myuser/myrepo# ./bin/skaffold deploy --cache-file=/Users/myuser/myrepo/.skaffold/cache --filename=skaffold.yaml --verbosity=warning
unknown flag: --cache-file
See 'skaffold deploy --help' for usage.

A solution would be extracting all available args from --help and match it with passed+default values, something like...
const command_help = await exec(Binaries.SKAFFOLD, command, '--help')
const argsRegex = /(--\S+|-[a-zA-Z]),?\s?(\S+)?: (.+)/gm;

I am also running into this issue with or without the cache: false configured.
      - name: Run Skaffold Production Rendering
        uses<EMAIL_ADDRESS>        with:
          command: render
          profile: production


Explanation in the following link is much better than this page.

https://docs.microsoft.com/en-us/dotnet/framework/network-programming/asynchronous-client-socket-example

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e87c349f-3592-3f62-315d-e85db695041b
Version Independent ID: efce9f39-4ba4-a61d-4330-e60dcfaf99ca
Content: Using an Asynchronous Client Socket
Content Source: docs/framework/network-programming/using-an-asynchronous-client-socket.md
Product: dotnet-framework
Technology: dotnet-networking
GitHub Login: @karelz
Microsoft Alias: ncldev

@storm999 why is it better - it is just code. This page has text.
Are any of the samples incorrect?
Or is it just personal preference to see full code vs. reading text?

full code is easier to understand for me. also easier for copy pasting.
In your page, i didnt understand what "connectDone" is even if you explained it verbally.

@storm999 different people prefer different things - some prefer text explanations over longer code. The full code sample is linked, so all should be good IMO.


The world may have leaked: seen X times!

We encountered this message after we did this with a world.

unload
delete

MapLoader class we use: http://hastebin.com/enulamomub.java
Server logs: http://hastebin.com/sitimadufu
minecraft version: 1.8.9
SpongeAPI: 4.0.0-SNAPSHOT-05b3db
SpongeVanilla: 1.8.9-4.0.0-BETA-249.
However the server doesn't seem to be badly affected. We did a unload and delete for 10 times and let the server run for a night.

This is a design issue with your plugin lol.
You have several Optional refs that you don't nullify when unloading a world. In all actuality, this is a poor way to store a Word. Unless the object in question is temp, Worlds should ALWAYS be stored within WeakReference.


Support --ffmpeg-format

(previously titled Support --output-format (and -O))
Allow specifying an output format when using an external downloader, either through --output-format or -O, in preference to the extractor's default. This is particularly helpful as -O mkv, to allow Matroska
output from ffmpeg in cases where .mp4 isn't a great answer, such as while trying to play during the download.

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections

[x] Searched the bugtracker for similar pull requests

[x] Checked the code with flake8

[x] I am the original author of this code and I am willing to release it under Unlicense

[x] Improvement

[ ] New extractor

[ ] New feature

Description of your pull request and other information
I frequently run start playing downloads while they are running, and .mp4 written by ffmpeg is often problematic. Players (usually VLC) have trouble seeking and even more trouble seeking backwards. Using mkv seems to produce a much better result, presumably because there is no issue with missing moov atoms.

Err, and to clarify, --output-format mkv is different from --merge-output-format mkv because the latter can't start until the downloads are complete, making it essentially useless for playing-while-downloading (aka playing on-the-fly). And also, of course, running ffmpeg just once with the desired container format is faster and cheaper than wirting to an intermediate format and then converting.

Option name should explicitly reflect a dependency on ffmpeg in its name.
Description should explicitly emphasize it will only work with ffmpeg downloader.
-O should be removed.
It should be ignored completely when ffmpeg is not used as external downloader.

4. It should be ignored completely when ffmpeg is not used as external downloader.

I will work to rework this branch to make that change.

2. Description should explicitly emphasize it will only work with ffmpeg downloader.

I had anticipated that it was possible to choose an output format for other downloaders, either now or in the future. Sounds like that's not going to be the case. (Upon review, it looks like rtmpdump can only write .flv files, and youtube-dl's native downloaders are not going to gain support for non-mp4 downloaders in other cases). Of course it would work with avconv.

1. Option name should explicitly reflect a dependency on ffmpeg in its name.
3. -O should be removed.

Given the existing similar options, the set of prior art is something like this:
    --hls-prefer-ffmpeg              Use ffmpeg instead of the native HLS downloader
    --external-downloader COMMAND    Use the specified external downloader. Currently supports aria2c,avconv,axel,curl,ffmpeg,httpie,wget
    --audio-quality QUALITY          Specify ffmpeg/avconv audio quality, insert a value between 0 (better) and 9 (worse) for VBR or a specific bitrate like 128K (default 5)
    --prefer-ffmpeg                  Prefer ffmpeg over avconv for running the postprocessors
    --ffmpeg-location PATH           Location of the ffmpeg/avconv binary; either the path to the binary or its containing directory.
    --external-downloader COMMAND    Use the specified external downloader. Currently supports aria2c,avconv,axel,curl,ffmpeg,httpie,wget
    --external-downloader-args ARGS  Give these arguments to the external downloader

I note that --audio-quality likely falls in the same category (ffmpeg/avconv only) yet doesn't have ffmpeg in the name.
This leaves us with something like --ffmpeg-output-format or maybe --external-downloader-output-format (which doesn't meet your standard), both of which are long. I guess we could shorten to --ffmpeg-format or --external-downloader-format all of which aren't short.
What's the standard for whether an option merits a short alias? Does it have to be, e.g., demonstrated frequent use after it has been in the tree for some period of time?
I tend to want short options for anything I expect would be used interactively, whereas options only used in scripts can be long only. Is that the wrong way to look at it?
Thanks.

With respect to

4. It should be ignored completely when ffmpeg is not used as external downloader.

You're right, as currently implemented this does too much. For instance:
pb3:youtube_dl jhawk$ PYTHONPATH=~/src/youtube-dl python -m youtube_dl -v --no-part -O mkv 'http://media.w3.org/2010/05/sintel/trailer.mp4'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'--no-part', u'-O', u'mkv', u'http://media.w3.org/2010/05/sintel/trailer.mp4']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.11.06
[debug] Git HEAD: a906d47bd
[debug] Python version 2.7.10 - Darwin-14.5.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg git-2017-02-28-7f62368, ffprobe git-2017-02-28-7f62368, rtmpdump 2.4
[debug] Proxy map: {}
[generic] trailer: Requesting header
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on u'http://media.w3.org/2010/05/sintel/trailer.mp4'
[download] Destination: trailer-trailer.mkv
[download] 100% of 4.17MiB in 00:01
pb3:youtube_dl jhawk$ file trailer-trailer.mkv
trailer-trailer.mkv: ISO Media, MPEG v4 system, version 1

There we download an MP4 file and save it with an MKV extension, but the resulting file is not really an MKV file, it just pretends to be one. And that's not good.

It should be ignored completely when ffmpeg is not used as external downloader.

So, @dstftw, I'm not sure the right way to get here. Filename selection occurs in prepare_filename() which substitutes according to the template. Choice of extension seems to need to happen within (or prior to) this function.
But prepare_filename() is called in YoutubeDL.py, out of scope from where the choice of downloader occurs, and (I think) before the downloader has been selected.
What is the right way to do as you suggest and ignore this option, given that sequencing?
Or is it sufficient, with the option now named --ffmpeg_format that if it is specified when ffmpeg is not the downloader, an extension change could happen?
Guidance appreciated.

Any suggestions or advice, please?

I had anticipated that it was possible to choose an output format for other downloaders, either now or in the future. Sounds like that's not going to be the case.

Well, downloader is generally something that simply downloads and not downloads and transfers to some other format on the fly. I doubt there are currently supported downloaders capable of this apart from ffmpeg/avconv. Assuming there may appear another one capable you may omit ffmpeg from option's name but there should be something that will emphasize that the process is happening on the fly, as for me --output-format is too ambiguous.

What's the standard for whether an option merits a short alias? Does it have to be, e.g., demonstrated frequent use after it has been in the tree for some period of time?

Option should be frequently usable by wide range of users. This option is going to be used by very few people since it will only work for ffmpeg downloader that is rarely used. There are also some other options proposed for -O.

@dstftw, when I asked for help, I was really worried about the implementation problems I ran into when trying to follow your direction, i.e. https://github.com/rg3/youtube-dl/pull/14744#issuecomment-344489844
I appreciate your answering the earlier questions, but they were curiosity -type questions. They weren't preventing me from writing code (and, indeed, a4e49f1 was pushed after I asked them).
So, again, I'm still unclear how to avoid doing anything for non-ffmpeg downloaders when the filename selection happens in generic code:

Filename selection occurs in prepare_filename() which substitutes according to the template. Choice of extension seems to need to happen within (or prior to) this function.

But prepare_filename() is called in YoutubeDL.py, out of scope from where the choice of downloader occurs, and (I think) before the downloader has been selected.

What is the right way to do as you suggest and ignore this option, given that sequencing?

Thanks.

In prepare_filename you have an access to self.params.get('external_downloader') so you can check for ffmpeg. You can also check whether it is going to be selected as downloader later (based on get_external_downloader and can_download).


Missing location on Microsoft.sql

We didn't see Microsoft.sql/locations list on supported moving resource side. I did some tests about moving Microsoft.sql/locations resource (Azure SQL DB configured Long-term backup retention), it works fine. Please check if you can add Microsoft.sql/locations on this doc? Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23df5354-6833-a5da-0eb3-d860150c8b78
Version Independent ID: 682ec206-0fda-3e0b-5841-543860a87e34
Content: Move operation support by resource type - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/move-support-resources.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@zqyAmy Thanks for your feedback
@tfitzmac  Can you please review the request and update the document if required?

@zqyAmy - thanks for this feedback. I have added locations to the article. It should get published this afternoon.

#please-close


Free shipping over x-amount in cart not working properly

**Description: **
If I add a product to the cart, with a price of 590,- then the shipping cost is 0,- because the shipping is free over 500,-
If I add a promotion with 20% off, the shipping is still 0,- even though the price of the item is now 470,- and therefore under the 500,-. Then the shipping should be 49,-
[shipping%2Bsetup.png|https://sbp-issuetracker-attachments.s3.eu-west-1.amazonaws.com/1721734406_669f95062f3dd_shipping%2Bsetup.png]  [with%2Bpromotion.png|https://sbp-issuetracker-attachments.s3.eu-west-1.amazonaws.com/1721734406_669f9506a4f97_with%2Bpromotion.png]  [without%2Bpromotion.png|https://sbp-issuetracker-attachments.s3.eu-west-1.amazonaws.com/1721734406_669f9506f0495_without%2Bpromotion.png]

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37388.
[created from NEXT-37388, comment 486756]

[public] Thank you for your report. We have concluded, that the behaviour you describe does not meet the criteria for a bug and instead consider this suggestion to be an improvement. Please note that Github Issues is for bug reports only. Therefore, we have decided to close this issue and ask you to submit your idea to our Shopware Feedback & Ideas portal: https://feedback.shopware.com/forums/942607-shopware-6-product-feedback-ideas
[created from NEXT-37388, comment 495632]


Finagle is going to be dropping finagle-netty3

The Finagle library is finishing up its transition to Netty4, and as such it's going to be dropping Netty3 support in its entirety at some point. However, it looks like finagle-postgres is heavily dependent on the finagle-netty3 package.
There are at least two roads forward.

finagle-postgres can migrate to finagle-netty4.
The finagle-netty3 package could be moved to the finagle org.

These are not mutually exclusive, but either will address the issue at hand. Do you have a preference? There may be enough ecosystem projects to justify the second route regardless but we haven't don't an extensive survey.

Thanks, @bryce-anderson for the heads up. I'll try to take a look on how many changes there will need to happen for us to migrate to finagle-netty3 but of course if we can also do the second route would be nice to give us more time to make the transition.

@bryce-anderson I opened #74 to tackle the upgrade. It'd be great if you could take a look and let me know if I've done anything terribly wrong with respect to the change (I took the shortest path that made sense, so there's still a lot of old code which isn't the best... but hopefully it will get the job done)

Awesome! I'll take a look today. It looks like @vkostyukov is looking as well.

Bumping this up.
@leonmaia @jeremyrsmith I think we're couple of months away from stopping publishing finagle-netty3. I know there is some progress was done in #74 to migrate to finagle-netty4. Let me know if there is anything I can do to help.

Hey! Just wanted you let you all know that we're not going to publish finagle-netty3 in the next release (19.4). This means finagle-postgres would need to stay on 19.3 until it's migrated to finagle-netty4.

I'll go ahead and close this issue since we already migrated to finagle-netty4.


[fix #1038] appActivate behaviour on mac OS and handle shutdown event for mac/linux

need to merge #1041 before

Hello, there are now code conflicts due to the recent develop branch merge from PR #1041 :)


INT-759: Adding initial Dockerfile and script file for windows-proxy

This is the initial Dockerfile and script support installing proxy with server_url and api_token.

@basilisk487 @vikramraman
Could you please review the Dockerfile-win and win-proxy-installer.bat file?


SlidingWindow technique

Given an array of integers calculate sum of k consecutive elements in the array using sliding window technique

Can you assign this to me?


String keyword-based search

@BeauNouvelle
Hi, In this PR contains two suggestions:

To update Swift tools version to 5.9 by following App Store policy since Apr 29, 2024
To add matching(keyword:) which is the new method that filters [ChordPosition] with the search keyword that is type of String. Please refer to the example below.

Chords.guitar.matching(keyword: "Am") // should equal to 'Chords.guitar.matching(key: .a).matching(suffix: .minor)'

I also added the test code for matching(keyword:) by using swift-testing.

This looks really good and a great addition. Thank you! I'll review shortly!


how to train the classifier model

Hello @Gengzigang
I tried using lightweight backbone to train the tokenizer and classifier ,but i get a bad result.Is there something i missed?
The result of tokenizer model:
Average Precision (AP) @[ IoU=0.50:0.95 | area= all | maxDets= 20 ] = 0.965
Average Precision (AP) @[ IoU=0.50 | area= all | maxDets= 20 ] = 0.990
The result of classifier model:
Average Precision (AP) @[ IoU=0.50:0.95 | area= all | maxDets= 20 ] = 0.365
Average Precision (AP) @[ IoU=0.50 | area= all | maxDets= 20 ] = 0.733
I changed the backbone and optimizer for config of classifier model :
optimizer = dict(type='AdamW', lr=8e-4, betas=(0.9, 0.999), weight_decay=0.05)
When i start train the classifier model ,the ap is 0.005 ->0.007. SO how to train the classifier model?
Thank you for taking the time to answer.

have you solved this problem? I have the same question about the training of classifier. I found that the decode in step 2 seems not to be frozen in training progress of classifier, but the results seem not right after i fixed this problem.


⚠ ClamAV has degraded performance

In 79bc3f0, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 84 ms

Resolved: ClamAV performance has improved in 62f3725.


[Build] Many unexpected warnings

Provide a description of the new feature / enhancement
When building the local clone of "UnitConverter plugin" branch which is up to date against master I get many unexpected warnings for KBM, SvgPreviewHandler and runner. The two warning on PowerLauncher are normal as I know.

PR with the branch is #9800 .

@crutkas
Is this fixed after your changes? Then we can close it.


Surface Warning in HTTPRoute Status if Regex Program Size is over 1000

          thanks for digging deeper into this @davidalger

agree with the approach of setting error_level to UINT32_MAX and warn_level to 1000 for now
either in the same PR or different, lets also highlight this in the control plane as a status
using https://pkg.go.dev/regexp/syntax (len(prog.Inst) is a close approximation)
Originally posted by @arkodg in https://github.com/envoyproxy/gateway/issues/2543#issuecomment-1932785022

Doesn't look like this will be feasible since the builtin regexp package has different internals than RE2 does. Syntax wise they're similar, but it compiles differently and len(prog.Inst) does not come close to matching up with RE2 program sizes.
These two programs will cause Envoy to emit a warning:
regex '^/static/[a-zA-Z0-9._-]{0,200}/[a-zA-Z0-9._-]{0,200}$' RE2 program size of 2005 > max program size of 1000 set for the warn level threshold
regex '^/api/v1/object/[^/]{124}/action$' RE2 program size of 1003 > max program size of 1000 set for the warn level threshold

Running these through Go's regexp package produces much lower numbers which don't seem to correlate to the 'size' reported by Envoy's use of the RE2 lib:
regex "^/static/[a-zA-Z0-9._-]{0,200}/[a-zA-Z0-9._-]{0,200}$" has length: 813
regex "^/api/v1/object/[^/]{124}/action$" has length: 150

This is the Go program I used to proof this: https://go.dev/play/p/hnoJcxl0Iwd
package main

import (
	"fmt"
	"regexp/syntax"
)

func main() {
	fmt.Println(validate("^/static/[a-zA-Z0-9._-]{0,200}/[a-zA-Z0-9._-]{0,200}$"))
	fmt.Println(validate("^/api/v1/object/[^\\/]{124}/action$"))
}

func validate(regex string) error {
	if re, err := syntax.Parse(regex, syntax.Perl); err != nil {
		return fmt.Errorf("regex %q is invalid: %w", regex, err)
	} else {
		re = re.Simplify()
		if prog, err := syntax.Compile(re); err != nil {
			return fmt.Errorf("regex %q is invalid: %w", regex, err)
		} else {
			return fmt.Errorf("regex %q has length: %d", regex, len(prog.Inst))
		}
	}
}

thanks for testing this out @davidalger, found another go package based off re2 https://pkg.go.dev/github.com/wasilibs/go-re2#Compile, could this one be closer ?
cc @mathetake

Hello everyone, I believe I understand the problem and would like to work on resolving the issue. If you could assign it to me, I’ll get started.
Thanks!

@arkodg as suggested above I tested using package (https://pkg.go.dev/github.com/wasilibs/go-re2#Compile) and through this we can keep track which regex programs are having lengths more than 1000.
Here's the code and result I got during testing:
package main

import (
	"fmt"
	regexp "github.com/wasilibs/go-re2"
	"regexp/syntax"
)

func main() {
	fmt.Println(validate("^/static/[a-zA-Z0-9._-]{0,200}/[a-zA-Z0-9._-]{0,200}$"))
	fmt.Println(validate("^/api/v1/object/[^/]{124}/action$"))
}
func validate(regex string) error {
	if re, err := syntax.Parse(regex, syntax.Perl); err != nil {
		return fmt.Errorf("regex %q is invalid: %w", regex, err)
	} else {
		re = re.Simplify()
		if prog, err := regexp.Compile(re.String());err != nil {
			return fmt.Errorf("regex %q is invalid: %w", regex, err)
		} else {
			if len(prog.String())>1000 {
				return fmt.Errorf("Regex %q is too complex with length: %d",regex, len(prog.String()))
			}
			return fmt.Errorf("regex %q has length: %d", regex, len(prog.String()))
		}
	}
}

Regex "^/static/[a-zA-Z0-9._-]{0,200}/[a-zA-Z0-9._-]{0,200}$" is too complex with length: 8410
regex "^/api/v1/object/[^/]{124}/action$" has length: 527

thanks for picking this up @JayantDhakajd, can you try and confirm those numbers with the o/p from envoy proxy ?
you could install Envoy Gateway https://gateway.envoyproxy.io/docs/tasks/quickstart/ + edit the routing config (https://gateway.envoyproxy.io/docs/tasks/traffic/http-routing/) to match on Regex instead of exact type
those numbers, shared by David, are from the envoy proxy pod logs

Thanx @arkodg for assigning me, I'll give my best and will try to confirm the numbers.

Good afternoon @arkodg ,
As discussed, I’ve been verifying output numbers from Envoy Proxy. Since I’m relatively new to Kubernetes, could you advise whether EKS, KinD, or Minikube would be the best setup for this task?
Additionally, I encountered an issue where http-routing on KinD is always returning false, and it seems charts.envoyproxy.io is currently down, which is impacting the setup.
If possible can you provide any guidance on this.
Thanks!


Doesn't work!

Hello, i have a little issue.
I did everything to show Sublime in Discord but it didn't want to show.
~Sorry for my english~

What can i do?
I have Discord Rich etc...

Save the project you are working on and it should update.

I did what you said but nothing happened.

Follow the steps in #31 to produce a debug log.

Are you sure that your Discord client is running? Which version of the client do you use? And what OS (though it looks like Windows 10)?

I use Sublime Text 3 - Cracked Activated, Discord last version and OS: Windows 10.

You shouldn't have to run either as administrator, but I'm glad it works anyway.

That was the only way to fix my problem. Have a nice day!


Support multifile when dlv debug, trace and test

This changes make dlv support multifile specifically when dlv debug,
trace and test. Just like dlv debug a.go b.go. Corresponding to
go build a.go b.go.(a.go and b.go are  belong to main package).
Fix #984. (I meet similar problems).

Looks good, thanks for the patch. Please format the commit message as specified here.

Sorry for the commit message. I has rebased  branch and  fix message.

Thank you.


MinGW fails with access violation writing error

Just moving my comment from old PR to a separate issue for the discussion and easier searching for users.
While working on that PR, I found weird bug under MinGW. The same symptoms were described in #1475. When I tried to run all examples by pytest %APPVEYOR_BUILD_FOLDER%\tests instead of pytest %APPVEYOR_BUILD_FOLDER%\tests\python_package_test, two C_API tests were passed succesfully, but all other tests failed with OSError: exception: access violation writing 0xFFFFFFFF93400000. At present this bug is avoided by running only Python tests (without C_API). I suppose, it's somehow connected to that the same lib_lightgbm.dll is loaded twice from different places (from installation directory for C_API tests and from python-package directory for Python tests).
Environment info
Operating System: Windows
Compiler: any MinGW-w64
Error message
E       OSError: exception: access violation writing 0xFFFFFFFF93160000

Full log: https://ci.appveyor.com/project/guolinke/lightgbm/builds/20010549/job/ewn044xw9dja8g9y
Steps to reproduce

Modify .appveyor.yml file:

test_script:
- - pytest %APPVEYOR_BUILD_FOLDER%\tests\python_package_test
+ - pytest %APPVEYOR_BUILD_FOLDER%\tests

@StrikerRUS I am not sure about the root cause, maybe some build flags for mingw are wrong ?

@guolinke To be honest, I'm not familiar with this, I remember only I added static linking to eliminate confusion with conda's libraries:
https://github.com/Microsoft/LightGBM/blob/a0efb07bb8ef9d8a80f246a933c623e253a8a0a3/CMakeLists.txt#L119-L121

All tests are passed when -O3 flag is removed.
diff --git a/.appveyor.yml b/.appveyor.yml
index 6ea6da0..6f8daf2 100644
--- a/.appveyor.yml
+++ b/.appveyor.yml
@@ -42,7 +42,7 @@ build_script:
     python setup.py install)

 test_script:
-  - pytest %APPVEYOR_BUILD_FOLDER%\tests\python_package_test
+  - pytest %APPVEYOR_BUILD_FOLDER%\tests
   - cd %APPVEYOR_BUILD_FOLDER%\examples\python-guide
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 057302b..1540cd4 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -113,7 +113,7 @@ if(USE_HDFS)
 endif(USE_HDFS)

 if(UNIX OR MINGW OR CYGWIN)
-    SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -pthread -O3 -Wextra -Wall -Wno-ignored-attributes -Wno-unknown-pragmas -Wno-return-type")
+    SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -pthread -Wextra -Wall -Wno-ignored-attributes -Wno-unknown-pragmas -Wno-return-type")
 endif()

Log: https://ci.appveyor.com/project/guolinke/lightgbm/builds/20151191/job/5gi6ebjpevehk06n

Linking #1588.

The flag which causes a crash is -fipa-reference-addressable (https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html).

Thanks @StrikerRUS so much. is this problem solved ?

@guolinke Happy to help!
Unfortunately, I can't find any information about the -fipa-reference-addressable flag, except official one-line description. In additional, I'm not sure, but it seems that there is no way to specify O3 except one flag...
My intuition is that we should find error-producing variable(s) and protect them from the optimization.
Maybe you know what can be done further?

@guolinke Yep! And it seems to me that it can be solved only by removing O* flag...
I think that it's not a critical problem which should be in our focus, but who knows, maybe sometime in the future we'll come to the solution.

@guolinke It seems to me that it's more a bug than a feature request, so reopening this and removing from #2302.

@StrikerRUS is this still happening?

The last time we received a report that might be related was December 2021 (#4192), but that person never responded.
I don't remember seeing it in LightGBM's CI in the last year. I think we could probably close this issue, but will let @StrikerRUS decide.

I don't recall seeing this in the last year, and the project still has pretty good CI coverage for Windows + MinGW across CLI, Python, and R jobs.
I'm going to close this.


Stridelonia fails to run when using Avalonia 0.10.7

Due to this commit in Avalonia: https://github.com/AvaloniaUI/Avalonia/commit/a832d639155ea05b84d35fa17a48c32b1e0366b1 IStandardCursorFactory → ICursorFactory

Thx for the report
Should be working now.


.graphqls extension being requested for files

Getting error in console for this plugin:
Warning:(2, 1) Schema definitions should be written in GraphQL Schema files (.graphqls)
Any idea what this is about? Should we keep using the .graphql or .graphqls?
Thank you.

I have run into this problem too. I think .graphql should be supported as its what facebook uses internally (https://github.com/facebook/graphql/issues/203)

When I initially developed this plugin, Facebook didn't have any open source IDE support for GraphQL outside of the browser-based GraphiQL.
The reason why there's separate file extensions has to do with how an IDE like IntelliJ IDEA/WebStorm provides the following features:

Error markers
Completion
Go to definition
Actions such as query execution

Regarding error markers, there are different valid keywords depending on whether you're writing executable GraphQL or the GraphQL Schema IDL. For example, the "type" keyword is neither executable nor does it validate when sent to GraphQL endpoint.
Similar syntactic and semantic differences apply for completion and go to definition. The only way for the IDE to know the difference is based on the file extension. So I basically followed the same logic as was used to define .jsx as a separate extension from .js.
If I had to guess, FB kept things simple and only used .graphql because they've had no reason to do otherwise before IDE support was established.
@asiandrummer Your thoughts on this? And correct me if I'm mistaken on FB internals :)

@jimkyndemeyer whoa sorry! I'm super late to this party ;) let me provide some context hoping to be of some help understanding.
GraphQL schema IDL definition support came a while later the open source of GraphQL (hence GraphiQL) happened, therefore the online parser (which I believe this plugin is using) and the graphql-js parser did not begin with the support for schema IDL at the time. GraphQL treats schema IDL as the part of the GraphQL syntax specification. I think @jimkyndemeyer's schema definition syntax support came earlier than GraphQL's schema IDL support, hence the differences.
Since we can treat type extensions/definitions as parts of queries/GraphQL artifacts, there's really no need to have a different file extensions (although you'd want the schema related definitions in a different file, just like schema.graphql that you have above). Parsing the syntax and validation steps for schema IDL language function as same as a regular GraphQL query (except for the part where you have to extend with your type def/exts to validate the schema).
@jimkyndemeyer would you be interested in supporting GraphQL schema IDL in place for your schema definition syntax?


[SPARK-44989][INFRA] Add a directional message to promote JIRA_ACCESS_TOKEN

What changes were proposed in this pull request?
This PR aims to add a directional message to promote JIRA_ACCESS_TOKEN when JIRA_USERNAME and JIRA_PASSWORD are used.
Why are the changes needed?
Since SPARK-44802, Token feature seems to be stable and provides much secure environments to Apache Spark committer environment by hiding not only JIRA_PASSWORD, but also the static JIRA_USERNAME.
SPARK-44802 Token based ASF JIRA authentication
SPARK-44802 Fix to consider JIRA_ACCESS_TOKEN in precheck conditions
SPARK-44972 Eagerly check if the token is valid to align with the behavior of username/password auth

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No,

cc @yaooqinn , @srowen , @HyukjinKwon

Thank you all! Merged to master.


feat: ui change to show k8s events

What this PR does / why we need it:
This PR is UI change to display k8s events for users as a reference.
This PR also include the service change to get event type(Normal, Warning or Failed...)

@rajarajanpsj pls approve


Add log stream support

There should be an endpoint that sends an updated stream of the latest log file
This can be used for debugging and to see in real time the production files

fixed with original log feature (see #193)


[Proofreading]: Location - Skit title

t and h are misplaced

will be fixed when skit are reinserted


how to start new thread message?

Hi you,
Please help me. I've read all document but not found this case. I want to chat with a user that I've never chat before (maybe we aren't a friend).
Also, I didn't receive a new message from not my friend
I've set     api.setOptions({listenEvents: true})
So now, how can I do that? Thank you so much

sr, my mistake


Repo sync for protected CLA branch

The pull request is created from main637949702792205348sync_temp to main to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add video level and profile + audio max and mean volume attributes to Movie

This adds the video_level and profile attributes to video_stream. It also adds max_volume and mean_volume attributes.
See my comment in https://github.com/streamio/streamio-ffmpeg/pull/78 re: audio levels not being in the metadata

Hi, @streamio
Thank you for letting me use your gem.
I want to use this pull request to make my system more convenient.
I wish to be merged into the release version as soon as possible.
Best regards,


[Global opt] add flag to generalize batch matmul ops

After adding the flag to sdxl scripts, I saw a decent decrease in the number of dispatches.
Initially, I was trying to manually generalize+fuse broadcasts branch here, but quinn saw good results with just this.

@hanhanW Good point, this is definitely more of a preprocessing pass than anything else

Agree with @hanhanW  for now this is a one-off preprocessing. If all the backends can handle these appropriately, then we do this always in the generalize named ops pass.

Ok I will defer to you both then, but if this is the only way to enable fusion of broadcasts, I would not consider this preprocessing, but rather a bug in the backend that is being worked around with an experimental flag we intend to turn on by default later.

Ok I will defer to you both then, but if this is the only way to enable fusion of broadcasts, I would not consider this preprocessing, but rather a bug in the backend that is being worked around with an experimental flag we intend to turn on by default later.

It seems like a pre-mature lowering to me, and the real bug is not having a linalg.contraction op (I wonder who suggested that :P ) that allows such broadcasting semantics. I find this pattern of using isContractionOp... all through the stack kind of strange. Using a named op and doing isa<..> seems like a more robust way. The backends should be able to handle any einsum-like op, but I would rather not drop information very early

oooo if the solution is linalg.contraction, then that sounds good to me


Complete Emmet 2.0 support

Contd. from #21943
Emmet Actions:

[ ] Increment/Decrement by n
[ ] Update Image Size (Pending resolution of https://github.com/emmetio/atom-plugin/issues/21)
[ ] Evaluate Math Expression
[x] Toggle Comment

Port current Emmet customizations to the new model:

[x] 🏃   Emmet expansion in languages that are not supported by emmet explicitly like php #28286
[x] 🏃Port customization of output profile
[x] 🏃 Port customization of variables in emmet snippet. In new emmet, this will be via a new setting emmet.variables
[x] 🏃Port the use of emmet.extensionsPath for custom variables and profiles #28465

Optimize Emmet expansions

[x] Use right language in case of embedded language. For eg:

Just to be sure the follow will be considered.
Currently, users need to assign custom keybinding to Emmet commands to use it in a efficient workflow.
Question 1
I see among the available commands that Emmet has 2 flavors for some of them such as:
emmet.nextEditPoint
editor.emmet.action.nextEditPoint

Do they refer to new vs old emmet implementation? Witch one to use in future?
Question 2
If user set this custom keybinding
// Increment Number by 1
  {
      "key": "ctrl+up",
      "command": "editor.emmet.action.incrementNumberByOne",
      "when": "editorTextFocus && !editorReadonly"
  }

What would be the way to only enable this keybinding according to context (when emmet can effectively use this command)?
This would allow user to use the same keybinding for anything else or keep the default one working when the emmet context if FALSE (typically in this case: not in emmet supported language && caret not around numbers).
// Default VSC keybinding that could keep working even with the custom emmet set by user
{
  "key": "ctrl+up",
  "command": "scrollLineUp",
  "when": "editorTextFocus"
}

@freMea
To your first question:

When emmet.useNewEmmet is set to false, editor.emmet.action.nextEditPoint uses old implementation and emmet.nextEditPoint uses the new one
When emmet.useNewEmmet is set to true, editor.emmet.action.nextEditPoint calls emmet.nextEditPoint internally
Eventually (some time when we deprecate the setting emmet.useNewEmmet and make the new implementation the default), you will have only editor.emmet.action.nextEditPoint which will use the new implementation

This is done so that users who have keybindings to the editor.emmet.action.... don't have to change their key bindings
To your second question:
The when clause can work on file types as well. So you can add resourceLangId == html and restrict few of the emmet commands based on file type. See https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts
I don't think using cursor position is possible in the when clause.
Hope that helps

@ramya-rao-a
Thanks for your answers.
The problem with editorLangId in when clause is that you must duplicate your keybinding as many times as there are languages to restrict.
It could be partially solved if  when clause supported OR operator such as:
"when": "editorTextFocus && ( (editorLangId == html) || (editorLangId == css) || (editorLangId == js) || (editorLangId == xml) )"
But it wouldn't be as powerful and smart as a contextual Boolean state of command at caret position (instead of language used by file). It would allow using same keybinding for different commands in the same file depending on emmet context.

@ramya-rao-a
The new Emmet does not work in php document with embedded html.  Can PHP be added to the supported language??
A test case.

Create standard html document.
Change the extension from html to php
Insert HTML element and child elements using emmet format.

@nanaasumadu Have you tried adding the below setting?
"emmet.syntaxProfiles":{
"php": "html"
}

@ramya-rao-a
No, it doesn't work.

VSCode Version: 1.14.0-insider (1.14.0-insider), 2017-06-22T05:29:25.846Z

OS Version:  MacOS 10.12.5

settings.json file:
"emmet.useNewEmmet": true,
"emmet.syntaxProfiles": {
"php": "html"
},

Steps to Reproduce:

Create a new file with .php as extension.
Try to insert HTML elements using emmet syntax.

@nanaasumadu Can you try reloading VS Code after you added the syntaxProfiles setting?

@ramya-rao-a
Yes, I have reloaded VS Code and still does not work.

@nanaasumadu It works fine for me. Can you check if the language mode of your file?
@jens1o Can you give it a try? i.e Set the below, reload VS Code and see if you get emmet autcompletions in a php file?
"emmet.syntaxProfiles": {
"php": "html"
}

@ramya-rao-a
The language mode is set to PHP.  If I change the language mode to HTML, emmet auto-completion works but there is no syntax highlighting for PHP.

@nanaasumadu To ensure that no other extensions is interfering here, can you run code-insiders --disable-extensions and try again?

@ramya-rao-a
Done that and still doesn't work.
The only option left for me now is to completely re-install code-insiders.
Something definitely is not right.

Sure, I'll try that.
Result:
It works. But...

when I write a php tag, it annoys.
it does not work in nowdoc nor heredoc
... will create a new issue for each one.

created #29318 and #29320

@ramya-rao-a
Thanks the issue has been resolved for me.
The followed the steps below:

Backed up my settings.json file.
Uninstalled Code Insider
Removed "~/Library/Applications Support/Code Insider"
Removed "~/.code-insider/extensions" directory
Re-installed vscode-insider
Restored my settings.json
Created test.php file and testing emmet expansion (that works)
Re-installed extensions (emmet expansion continues to work)

@ramya-rao-a
Good job. Thanks for your hard work for Code 1.14.0.

Thanks @freMea and Happy Coding!


Making EQCSS Work

I'm using Django so all my front-end assets are loaded from a static file folder. First, I try to load the script from EQCSS.js . Then I load my custom custom styles from respond.eqcss which contains element queries.

For whatever reason, this isn't working at all. I have valid element queries, and I believe I've loaded my styles properly, but I can't seem to determine why the styles aren't taking affect. Does anyone have any ideas?

Hi Malik, thanks for checking out EQCSS!
From what I can see, as long as those file paths resolve in your HTML everything looks linked in correctly - the EQCSS.js code just needs to be present in the document somewhere, styles in EQCSS syntax can be loaded into the document inside a

If you load that as an HTML file in the browser and the background is green, EQCSS is running :D

I changed it to .content and it worked beautifully. My apologies I guess I thought it selected via class name.

Oh good! I'm glad you got this working in the end :) Let me know if you have any other support questions in the future :D


The mighty merge

[X] Completed PR - Has all features or fixes that it was meant to and isn't half done
[X] Follows the style guide - Style guide found here
[X] Your code follows the same code style as the rest of the project
[X] Is Walshy

What is added
I'm merging data-restructure what do you think...
What is fixed
I'm merging data-restructure what do you think...

yep we're going to get a flarebot error when doing this one

@weeryan17 No we are not, it was just gradle shitting itself as usual

@binaryoverload i ment form the github channel overflowing because lots of commits

That's because you removed the build file.

[X] Is Walshy

Rejected. :^) <3

xD

@WalshyDev You might as well merge bc there is nothing to review xD

^ I agree.

@binaryoverload well @ArsenArsen is one picky and annoying person when it comes to PRs he didn't see.


CERTIFICATE_VERIFY_FAILED

Fix SSL certificate errors
If you see this error when running the python scripts:
urllib2.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:661)>

Verify that the ca-certificates are installed:
$ sudo aptitude install ca-certificates

Add this configuration to your ~/.gitconfig
[user]
	name = username
	email = user@email
[http]
        sslVerify = true
        sslCAinfo = /etc/ssl/certs/ca-certificates.crt

I had this issue while building electron and it failed only with this submodule.

Hey there,
It's been a long time coming but the libchromiumcontent repository is being archived as it is no longer used in the Electron build system (🎉 this is a good thing).
If your issue is still relevant to Electron in it's current build system (please verify first) then you should probably raise a similar issue on electron/electron.
Thanks 😄


add google-pilot logID

adding Google CT pilot log ID, as found on: http://www.certificate-transparency.org/known-logs. confirmed through the Chrome UI looking at a cert issued with an SCT from that log included. (this is the only log missing the logID)

Great, thanks Carl. I'll deploy that now.

Deployed: http://ctwatch.net/#/logserver/google-pilot


Benchmarks

Do we have a script to run the benchmarks mentioned in the paper? Especially for llama 7B, 13B models. Also, I can not run the llama-bench and I am getting a model loading error. Any lead?

We benchmarked the performance simply via the main binary specifying 8 threads and expected output with the same set of prompts. You can use this command and check the printed performance stats on your end:
./build/bin/main -m "$model" -n "$output_len" -p "$prompt" -t "8" --ignore-eos

However, please be aware that the current open-sourced version of PowerInfer may have some differences from the internal version evaluated in our paper, particularly in terms of performance. For instance, we have simplified certain features, such as fine-grained tensor offloading and comprehensive FFN neuron offloading policy, to facilitate easier use for a broader range of users.

Also, I can not run the llama-bench and I am getting a model loading error. Any lead?

We haven't tested with llama-bench yet, and there can be incompatibilities. Would mind sharing your error log so we can better pinpointing any bug?


invalid requirement syntax

requirements in tosca specification is eg
  requirements:
    - database:
        node: my_database
        capability: Endpoint.Database
        relationship: my.types.CustomDbConnection

in this yaml file it is
    requirements:
      - host: tosca.capabilities.Container
        relationship: tosca.relationships.HostedOn

however this syntax is invalid. It should instead be
    requirements:
      - host:
          capability: tosca.capabilities.Container
          relationship: tosca.relationships.HostedOn

Hi Guillaume,
TOSCA grammar has changed on various aspects in the past years and alien4cloud project started based on some early working draft. We are getting closer to full simple profile support keeping retro-compatibility with previous supported grammars.
The current file grammar version is defined by the tosca_definitions_version with is right now alien_dsl_1_2_0.
Since alien4cloud 1.3.0 we support requirement definitions as mentioned in the tosca simple profile in yaml 1.0.0 so we could change the definitions and the version of the definitions. If we do so and even if the content has not changed we would have to release a new version of the normative types as packaged in alien4cloud and decided not do to so in 1.3.0 version.
We will for sure consider that in next versions a4c hopefully shifting the tosca_definitions_version of this document to tosca_simple_yaml_1_0 which is the official one.
You can read more on our support and grammar differences here:
http://alien4cloud.github.io/#/documentation/1.3.0/devops_guide/tosca_grammar/tosca_grammar.html
We updated the documentation recently to state for every element which key name is supported in which dsl version as parsed in alien4cloud and which are not yet supported.
Luc
Your issue will remain open until we actually perform the switch.

Thank you very much.
Will you support the shorthand_name ? In Tosca I can write a Node extends Compute, this will be resolved as tosca.nodes.Compute  .
I don't know why the shorthand are not present in the tosca normative examples . I am making my own Tosca compiler and I add the corresponding shorthand_name to the definition that have one in the tosca spec.


fix plugin loading to support plugins targeting NPE >= 4

NuGetPackageExplorer.Types target framework is net461
reference #160
(I am also updating https://github.com/NuGetPackageExplorer/Extensions.IlSpy to work with the new NPE version)

This should propably also be updated:
https://github.com/NuGetPackageExplorer/NuGetPackageExplorer/blob/df2c749138f6fcb31f096bd1d0d88bc69e70c208/PackageExplorer/MefServices/PluginManager.cs#L93
Any suggestions?
'lib\\net*'
'lib\\net40', 'lib\\net45', 'lib\\net451', ...

@campersau not specifically, whatever works

Updated.
This was actually all I had to change to load plugins with the updated NuGetPackageExplorer.Types reference.

Nice! Is this ready for review/merge?

Yes, it is.

Thanks!


UI tool 8702 modal header separator line

Proposed Changes
Changed the theme style from the Modal component so that it adds a horizontal line separator between the header and the body. Also, I've created a prompt variant for the Modal component, because we dont want prompt to have that separator.
Potential Breaking Changes

Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Code and demo looks good for the modal, but can you add an example of the prompt?

I purposely did not, since the Prompt is not updated from the design Gustavo made 🙁, but I can add one if we feel like it would be needed

It's just weird to review a component that I cannot see. I think we should still have a demo which would help us and Gustavo when we update the style of the component


Make threads daemon.  Expose method to shutdown pollers.

archaius-pull-requests #243 SUCCESS
This pull request looks good

NetflixOSS » archaius » archaius-pull-requests #74 SUCCESS
This pull request looks good

archaius-pull-requests #244 SUCCESS
This pull request looks good

NetflixOSS » archaius » archaius-pull-requests #75 SUCCESS
This pull request looks good

archaius-pull-requests #245 SUCCESS
This pull request looks good

NetflixOSS » archaius » archaius-pull-requests #76 SUCCESS
This pull request looks good


Fix(Tooltip): The z index was added

add z-index
Summary
The z index was added
Task
not
Affected sections

src/components/Tooltip/Tooltip.tsx

How did you test this change?

Mannualy with storybook 🎨
All tests was passed ✅

@Misael840 @JuanDominguez1 @jasanhdz me ayudaría con sus reviews?


Crash on Constructor Placing Heads

When ever a constructor tries to place a head down, it crashes the game
Once this happens I can't load the world, becuase it tries to place the head, but can't causing the game to instantly crash.

Minecraft: 1.10.2
Forge: 1.10.2 - <IP_ADDRESS>1
Refined Storage: 1.2.20

Crashlog:
http://pastebin.com/Q3mAWuAS

I'll look into this, remove the block with MCedit for now.


Feature/2.1

send max messaging included

2.1 could only go into development post 2.06 & 2.07.
Closing this PR as it would inevitably go stale.


Nothing showing up, cannot download more Xcodes

How do I install more versions?

Click the arrows on the far right tool bar or increase the size of your left nav
macOS likes to move tool bar buttons when it doesn't have enough room to show them

dang, you're right! so weird!
https://github.com/user-attachments/assets/718d1088-7b1b-4710-89fb-1b6cb436c746
thanks a ton!

Xcodes does not support downloading Xcode 16+ runtimes as Apple has changed how they are downloaded and it's not a simple fix and not sure it's even possible.
Your best to use Xcode when downloading the runtimes for 16+

Gotcha, thanks!


PHOENIX-1673 Allow TenantId to be of any integral data type

Hopefully everything here is in order, if there are any questions or requests don't hesitate to ask.

Thanks so much for the contribution, @JeffreyLyonsD2L. Would you mind helping to review and commit this, @elilevine? I think the main thing to check is that there aren't any places in the code that Jeffrey missed updating.

Thanks for the ping, @JamesRTaylor. Haven't seen this PR until now. I'll review and commit today or tomorrow if everything looks good.

Added the changes requested, and removed the redundant padding.

Good stuff, @JeffreyLyonsD2L. Added a few questions and comments to the PR.
There is one more issue that it not tackled here that we need to at least discuss IMHO. Phoenix's metadata tables, such as SYSTEM.CATALOG lead with TENANT_ID VARCHAR column (take a look in QueryConstants.java). This works well in a world where all multi-tenant tables can only have VARCHAR tenant id columns. Your changes introduce the possibility that different multi-tenant tables will have different types of tenant id columns.
What's the right solution here? The right solution is probably changing TENANT_ID column type to BINARY in system tables. But that will make upgrades for existing clusters a pain. Leave them as VARCHAR?

Thanks for all the feedback @elilevine and @samarthjain! I'm east coast, so I'm just heading out of the office now, but I should be able to get the changes up sometime tomorrow.
The above question kind of goes outside my realm of interaction with Phoenix so I'm not sure if my handle on it is correct. Is the point of the TenantId in a table like System.Catalog to tie specific schema to a tenant? If so I would lean toward leaving as VARCHAR since any TenantId has to be at least convertible to a VARCHAR since it comes down the connection as one, though I agree the your 'correct' solution seems like the most complete way forward.

The TENANT_ID column in system tables is used to quickly filter metadata belonging to a tenant. Agree we could probably get away with leaving it VARCHAR because that is how tenant ids are passed to connections anyway.
Now that got me thinking... if we extending that logic further, why then do we need to implement support for other data types for tenant id columns if tenant ids are always passed in as strings to connections? Why not keep them all as VARCHAR/CHAR, like they are now?

This feature would allow the tenant ID to be represented through more types than just a VARCHAR. Some users may have tenants identified by an int or a long instead of a string. The tenant ID would still be passed as the stringified value, but the underlying table could use an int or a long as the column type. As you mentioned, the system tables (SYSTEM.CATALOG and SYSTEM.SEQUENCE) would need to continue to use the string representation. Every type can be converted to a string, so this should be ok (pending testing).

Yeah, I understand that the feature allows TENANT_ID on data tables to be a different type. What I'm not sure about is how useful this feature would be in real life if internally we are treating tenant ids as strings in connections and system tables anyway. Why not just do the same for data tables, as well (which is how it is now implemented)? As you mentioned, every type can be converted to a string and users can do easily do that for data tables.
If we relax type constrains for data tables but not for metadata tables/connections we are making the implementation of multi-tenancy in phoenix internally inconsistent. Should be all or nothing IMHO.

The system tables need to be able to store the tenant ID regardless of its type in the data table, so it wouldn't make sense to type the system tables (i.e. the all approach isn't viable IMHO). If a table already exists with a different typed leading column than CHAR/VARCHAR, then it would not be possible to map a multi-tenant Phoenix table to it. This just provides a little bit more flexibility. I'll ping the original filer of the JIRA and see if he has further comment on his use case.

I can probably provide a little more information about our use case once I meet back with my team on Monday, but I can definitely say that James' point about being able to map existing tables with the concept of a tenantId without having to convert all of the data would be a big plus for us.

Everything looks good in terms of code. Excellent work, @JeffreyLyonsD2L. The only thing to figure out now is whether or not we should add the feature at all. I agree that changing the schema of SYSTEM.* tables is off the table. So do we allow the tenant id column in data tables to be of different type than in metadata tables? It does not sit well with me and makes multi-tenancy seem inconsistent IMHO, as I mentioned above, since tenant id is always passed in as string to connections and is stored as such in system tables.
@JeffreyLyonsD2L, maybe you can shine some light on our use-case. You mentioned that not having to do data conversion is a plus. In what way? Are you starting with existing data and don't want to do data conversion?

Hey @elilevine, thanks and I appreciate the review, I've been learning a lot :)
In terms of our use case, we have a pre-existing schema that we don't want to modify. For one, it would be a significant refactor to some of our other code in order to handle converting our existing TenantIds to strings.
The other issue is that we have a lot of traffic that is interacting with the cluster directly through HBase and not through Phoenix. For this reason we like having the TenantIds as fixed length, so that the rowkeys are easy and logical to parse.
It also seems reasonable to me that if the TenantId is naturally a number instead of a name that it could be represented with one, instead of forcing a conversion to string when we store it.

Thanks for the details, @JeffreyLyonsD2L. I have to say I'm still torn on whether or not this Jira makes much sense. What if I told you that your concern #2 is already addressed? Currently tenant id columns can be either VARCHAR or fixed-length CHAR. Does that make it easier for you to use multi-tenancy in Phoenix?
Regarding your points #1 and 3, you are forced to do the conversion once per Connection when you set the TenantId parameter either way. Not sure what kind of conversion you mean beyond that. Normally when you read/write via a tenant-specific connection you only set TenantId on the Connection and don't need to actually write it or read it. Are you working with this data over non-tenant-specific connections?
I went though your code again. Everything looks good. The only thing missing now is:

Tests that create tenant views with non-string tenant id columns and test data upsertion/retrieval.
Same as above but negative. Test what happens when conversion fails.

For points #1 and #3, I think I really mean converting the data we already have. We have a lot of data in our system with our current schema and would have to upgrade the entire schema and most of our historical data to fit the new standards, which for us would be a non-trivial process.
We are also writing to the underlying tables through our own library, not through Phoenix, and that system is set up to have TenantId as an UNSIGNED_INT. This code is pretty ingrained in our system, and would require a massive refactor and significant restructure of how our cluster works to switch over to using something like fixed-length CHAR arrays.
As for the tests, I'll get them up as soon as possible.

Makes sense, @JeffreyLyonsD2L. The existing data and integrations with other components interacting with the HBase tables do make the feature worth it IMHO. I'll commit after you add those tests. Thanks!

Thanks @elilevine, it has been a very interesting discussion for me to see :)
With regards to the tests you mentioned earlier, I've added them to the TenantIdTypeIT. Although in looking over the review, I saw I missed one of your previous comments regarding testing tenant-specific indexes and sequences, so I'll add some of those this afternoon.
I'm fairly new to committing to open source, so is there anything you need from me organizationally or git-wise once the final code changes are in (something like going through and resolving the conflicts, or rebasing)?

Added the last few tests.

Alright @elilevine, final revisions to the tests are up. As I mentioned in my earlier post, I'm not quite sure where my work ends, but I'll be available to fix/help with anything needed for the next few days.

Good stuff, @JeffreyLyonsD2L! One last thing: can you update this pull request so it merges with Phoenix master cleanly (there are some conflicts now)? Also, would be great to see a PR for one of the 4.x branches if this patch does not merge cleanly there. You don't need to do it for each 4.x branch, one is fine. I'll take care of the rest. Again, thank you for your contributions.

You're very welcome, I've found the process streamlined and would be encouraged to contribute again! I resolved the conflicts on this branch, and created another PR for the 4.x-HBase-0.98 branch (#108 for reference)
I'll be available fore help if there is anything else needed.

This PR is now in master and can be closed.


Variables which are set directly into the style are probably not updating

Eg. in button or in the toolbar, I'm using some variables by directly setting them into the style.
The problem is that when I'm changing the css-variable, the state won't update and the color won't change.
For Buttons I could just change a state flag which will update the variables, for the toolbar I should set a classname which will set the border, because changing the state would cause the flowlayout to re-calculate everytime I change the color

Closing this issue because I've implemented it for the mentioned components, but there could be possibly more where I have to implement this but I don't know it yet


feature: constrained grammars

Is your feature request related to a problem? Please describe.
Output of valid JSON, YAML, or alikes from a model is challenging. Models hallucinates, prompts needs to be fine-tuned, and there is no guarantee it spits valid output format.
Describe the solution you'd like
A way to constrain the output with a grammar. Ideally, would be great to have here as an endpoint this https://twitter.com/GrantSlatton/status/1660348210605596672 - https://github.com/grantslatton/llama.cpp/commit/007e26a99d485007f724957fa8545331ab8d50c3 .
Describe alternatives you've considered
N/A
Additional context

Related existing solution https://github.com/microsoft/guidance/

See also: https://github.com/1rgs/jsonformer
I think there are probably two ways to accomplish this:

At the prompt/output level, generating all of the syntax between values as a prompt, then prompting for only the value, and cutting off the response when a syntactically incorrect token is generated, and so on. Pro: should work with any model / implementation.  Con: while it should never generate invalid json, it probably generates empty json that might need to be thrown away at a higher-level json schema checker.

at the sampler level, with knowledge of the desired syntax, so adjusting the likelihood of generating a particular token. Benefit: should work much more reliably, with true syntax awareness.  Con: is probably limited to one NN architecture/SDK, like pytorch.

Both approaches have pros and cons, and both require significant effort in parsing syntax.
JSONFormer appears to be the latter, better approach, but also refers to other implementations that seem to do the former.

I can share some updates very soon - I got it working with the llama.cpp PR which adds constrained grammars ( I don't have the link now). I could successfully implement OpenAI functions. Will follow up shortly with my experiments

When llama.cpp is going to merge this PR: https://github.com/ggerganov/llama.cpp/pull/1773 constrained grammar output will be unblocked and quite easy to implement. I've hacked my way today something, will cleanup and push in a branch soon.


no error triggered but no result

hello,
when i set this config it works.
clientId: 'firstIdXXX',
clientPassword: 'passphraseXXX',
and when i set this (prod), it doesn't work, and it doesn't fail => no return at all.
clientId: 'prodIdXXX',
clientPassword: 'prodPassphraseXXX',
baseUrl: 'https://api.mangopay.com/'
can you ehelp me ?
this is my sample code :
var mangopay = require('mangopay2-nodejs-sdk');
var api = new mangopay({
clientId: 'xxxx',
clientPassword: 'xxxxx',
});
api.Users.getNatural('11510910021zx', function(result) {
// no return
console.log('result1', result);
})
.catch(function(data) {
// no failure
console.error('err', data.Message);
});

i also tried to edit api.js in node_modules to search the bug... the explaination...
it seems that i get a 401 response code at line 176:
if (response.statusCode === 401) {
but the autorize call nevers returns
self.authorize(function(){

Hello @rafipiccolo. Can you please debug the message and the requested URL for me please? Thanks!

hello, where can i find it ? I dont really understand code in that lib.

You can use debugMode option to true so that you can have the requests and responses logged into the console: https://github.com/Mangopay/mangopay2-nodejs-sdk#supported-options

{ '0': 'users_getnaturals',
'1':
{ headers:
{ 'Content-Type': 'application/json',
'User-Agent': 'MangoPay V2 Nodejs/1.4.3',
Authorization: 'undefined undefined' },
requestConfig: { timeout: 30000 },
responseConfig: { timeout: 80000 },
path:
{ id: '11510910021zx',
clientId: 'rafipiccolo',
apiVersion: 'v2.01' },
dataClass: { [Function] extend: [Function], super: [Object] } } }

There seems to be something wrong with the Authorization header: Authorization: 'undefined undefined' are you sure the client is instantiated correctly?

this si my only code.
var mangopay = require('mangopay2-nodejs-sdk');
var api = new mangopay({
clientId: 'xxxx',
clientPassword: 'xxxxx',
});
api.Users.getNatural('11510910021zx', function(result) {
// no return
console.log('result1', result);
})
.catch(function(data) {
// no failure
console.error('err', data.Message);
});

do you see something inapropriate in my code ?
to install your lib i just did : npm install mangopay2-nodejs-sdk
is this the way u use it ?
maybe the fact is that my passprase is wrong ? my network is failing ? but whatever... can i have an explaination of the fail instead of nothing ? is the nodejs lib used in production by someone ?
help me plz.

The pb seems to be here line 276 in api.js :
}), function(data) {
when i add console.log(data) after this line, it contains an error.
This error is visible nowhere outside of the lib......
To reproduce the error i see you can simply put a wrong passphrase.
Please tell me when there will be a patch.
thank you

Hello @rafipiccolo thanks a lot for your research and interest in solving this issue. We will be working on a fix for this problem, since capturing authentication issues cannot be done, according to the problem you are describing. I will add a test to reproduce this issue and have a fix ASAP.
Thanks!

Added a PR that should fix the issue you addressed, also there's a test for it that's reproducing the issue you described.
Thanks a lot again for addressing this issue!


Airdrop dumpers

When submitting, please include 3 items:

Brief description of your tag (what are you trying to tag)?

Airdrop dumpers

What is the cadence of refresh this needs?

Daily

SQL query
with claims as ( select ORIGIN_FROM_ADDRESS, (RAW_AMOUNT / 1e18) as claimed from ethereum.core.ez_token_transfers where FROM_ADDRESS = '0xb27198a99e3ae693f4dd14cfee89e98eaf413263' and CONTRACT_ADDRESS = '0x55b1e2d8b13e7acad03353fad58fc3fa065c5822' and ORIGIN_FROM_ADDRESS != '0x0fbb8d17027b16810795b12cbeadc65b252530c4' ), sent_received as ( with received as ( select   TO_ADDRESS,   sum(RAW_AMOUNT / 1e18) as received from   ethereum.core.ez_token_transfers where   CONTRACT_ADDRESS = '0x55b1e2d8b13e7acad03353fad58fc3fa065c5822' group by   1 ), sent as ( select   from_ADDRESS,   sum(RAW_AMOUNT / 1e18) as sent from   ethereum.core.ez_token_transfers where   CONTRACT_ADDRESS = '0x55b1e2d8b13e7acad03353fad58fc3fa065c5822' group by   1 ) select TO_ADDRESS as w, received, sent from received inner join sent on TO_ADDRESS = from_ADDRESS ) select ORIGIN_FROM_ADDRESS as wallet, claimed, case when received is null then 0 else received end as received, case when sent is null then 0 else sent end as sent, case when (claimed + received - sent) is null then claimed else (claimed + received - sent) end as held_FRZ, case when ( held_FRZ = claimed and sent != 0 ) then 'Holder_With_activity' when held_FRZ > claimed then 'Holder_Acquired_More' when held_FRZ < claimed then 'Holder_Not_Complete' when held_FRZ = 0 then 'Not_Holder' else 'Holder_With_No_Activity' end as situation from claims left join sent_received on ORIGIN_FROM_ADDRESS = w

This was a test for a screen recording, closing


Upon testrun / testrerun, use direct job manager instead of other job managers.

Might be faster.

Done #144


build: Monthly maintenance (Dec 2022)

Update mypy and other deps to latest versions, as well as use latest checkout action.

Coverage remained the same at 97.185% when pulling 5629a4759bbe7ffdf5d6441db06a6427cf48f7b1 on build/mon-maintenance-2022-12 into 8ea456f50c12e8293c57517b35cd85ab3c639ec3 on main.


makefile: Use a specific branch to generate and validate KubeVirt schema

What this PR does / why we need it:
We need to use a branch on the older release branches to avoid the need for a KubeVirt release to consume API changes.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/lgtm

/retest


Review: Make global dependencies configurable

Global dependencies such as window, document, navigator should be configurable. #173
Checklist
This is a checklist of all the functions of VueUse. It's is useful for review or making changes the go through every function.

shared (17)

[ ] biSyncRef
[ ] controlledComputed
[ ] extendRef
[ ] makeDestructurable
[ ] syncRef
[ ] tryOnMounted
[ ] tryOnUnmounted
[ ] useDebounce
[ ] useDebounceFn
[ ] useInterval
[ ] useIntervalFn
[ ] useThrottle
[ ] useThrottleFn
[ ] useTimeout
[ ] useTimeoutFn
[ ] utils
[ ] when

core (51)

[x] asyncComputed
[x] createGlobalState
[x] onStartTyping
[x] useAsyncState
[x] useBattery
[x] useBrowserLocation
[x] useClipboard
[x] useCounter
[ ] useCssVar
[ ] useDeviceLight
[ ] useDeviceMotion
[ ] useDeviceOrientation
[ ] useDevicePixelRatio
[ ] useDocumentVisibility
[ ] useElementVisibility
[ ] useEventListener
[ ] useEventSource
[ ] useFavicon
[ ] useFullscreen
[ ] useGeolocation
[ ] useIdle
[ ] useIntersectionObserver
[ ] useLocalStorage
[ ] useMediaQuery
[ ] useMouse
[ ] useMouseInElement
[ ] useMutationObserver
[ ] useNetwork
[ ] useNow
[ ] useOnline
[ ] usePageLeave
[ ] useParallax
[ ] usePermission
[ ] usePreferredColorScheme
[ ] usePreferredDark
[ ] usePreferredLanguages
[ ] useRaf
[ ] useRafFn
[ ] useRefHistory
[ ] useResizeObserver
[ ] useSessionStorage
[ ] useShare
[ ] useSpeechRecognition
[ ] useStorage
[ ] useTitle
[ ] useTransition
[ ] useWebSocket
[ ] useWebWorker
[ ] useWebWorkerFn
[ ] useWindowScroll
[ ] useWindowSize

integrations (3)

[ ] useAxios
[ ] useCookies
[ ] useQRCode

rxjs (4)

[ ] from
[ ] toObserver
[ ] useObservable
[ ] useSubscription

firebase (2)

[ ] useFirestore
[ ] useRTDB

I @antfu I can do this

@anteriovieira that would be great! I think I have done most on dev branch (but kinda randomly), so I made this list. You can help go through the functions and review them a bit. You should have permission to update the list.
Thank you!

@antfu , I must send it to dev, right? Considering that we may have changes in the signature of the functions.

Yes, let's do that on dev


Where is the actually info how to create private endpoint by using CLI?

There is no command on how to create a Private Link via CLI?
So how to do that? and why this info is missing on this page.
There is only the command for Approve the Private Endpoint Connection but we need to approve the connection after creating the private endpoint,

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: af87838f-8c5f-2dad-a398-7411319b79f1
Version Independent ID: 300753e1-bfe6-6c30-210b-975587d3ec37
Content: Manage virtual networks with Private Link - CLI - Azure Database for PostgreSQL - Flexible Server
Content Source: articles/postgresql/flexible-server/how-to-manage-virtual-network-private-endpoint-cli.md
Service: postgresql
Sub-service: flexible-server
GitHub Login: @GennadNY
Microsoft Alias: gennadyk

@Marusyk
Thanks for your feedback! We will investigate and update as appropriate.

but doesn't it look strange? creating private endpoint should be between step 2 and 3 because first, you need to create the posgresql server, then create private endpoint where you specify --private-connection-resource-id
So it is not possible to do step 1 without step 2. It's unclear, especially for new developers.

@Marusyk
Thank you for bringing this to our attention.
I've delegated this to content author @GennadNY, who will review it and offer their insightful opinions.

Private Link create CLI command is not our , but  Azure Network CLI. I will link to them

#please-close


Code fixes

fix code issues such as TabError (inconsistent use of tabs and spaces in indentation)
replace iteritems with items for py3 support
create a method to get data without having to deal with args

*** only affected codes were changed
For Testing
from binner.algo_single import AlgoSingle
from binner.collection_bin import BinCollection
from binner.collection_item import ItemCollection
import json

# just add a single bin as we're using the single algorithm
bins = '[{ "title": "bin1", "w": 100, "h": 20, "d": 20, "weight": 20, "id": 1, "max_weight": 1000 }]'
bins = json.loads(bins)
bins = BinCollection(bins)

items = '[{ "title": "item1", "w": 51, "h": 12, "d": 12, "weight": 4, "id":202 }, { "title": "item1", "w": 51, "h": 12, "d": 12, "q": 2, "weight": 4, "id":202 }, { "title": "item2", "w": 20, "h": 10, "d": 10, "weight": 4, "id": 2, "max_weight": 20 }]'
items = json.loads(items)
items = ItemCollection(items)

binner_algo = AlgoSingle(object, bins, items)
binner_algo.run()

results = json.dumps(binner_algo.binner.get_result())
print(results)

If response's lost attribute has values, it means all items cannot fit in the bin

Closing this as we're already using pyshipping


Fix auth context not working for Laravel >=5.3

Because of changes in how the session is loaded in Laravel 5.3 we can no longer rely on getting the user inside the register method of the service provider. But there is an authenticated event introduced making it easy to simply listen for it and we can be sure the user is available.
Fixes #73

@stayallive @dcramer quick question - are these changes also needed for Lumen?

Hey @jconroy,
The SentryLaravelEventHandler we modified here is also used for Lumen (Lumen is basicly a stripped down version of Laravel) so the changes here also affect the Lumen integration.
I am sure you are asking because something is not working, could you open an issue with details if so? Than we can take a look why that is!

ok thanks @stayallive was just going off that the service providers are still different
src/Sentry/SentryLaravel/SentryLaravelServiceProvider.php
src/Sentry/SentryLaravel/SentryLumenServiceProvider.php

I am sure you are asking because something is not working,

We just noticed we've been getting very odd (just straight incorrect) user id tagging in sentry and we can't put our finger on where the issue lies. We can see the events mention the correct user in the stack traces and breadcrumbs etc. but every so often the tag is wrong and it makes debugging very confusing. I'm not sure it could be to do with merging functionality in Sentry trying to be too smart or something else.

@jconroy this sounds like some events might occur before your own user integration can run and you see the default id set by Sentry, but please do make an new issue with what kind of errors this occurs so we can dig in.


Missing Moves in a new Actor Sheet

When you create a new actor sheet, some moves are not added.

Thanks for noticing! The missing moves now have the correct type and will be added upon character creation. The correction will be made in the next version.


Use rejectUnauthorized instead of strictSSL

When running the module with strictSSL set to false (because I set insecureSkipTlsVerify to true and strictSSL is the opposite of insecureSkipTlsVerify) I receive the following error for a self signed certificate:
/Volumes/Work/stat-tracker/node_modules/openshift-rest-client/lib/basic-auth-request.js:7
  const err = new Error(requestError.message);
              ^

Error: self-signed certificate in certificate chain
    at buildError (/Volumes/Work/stat-tracker/node_modules/openshift-rest-client/lib/basic-auth-request.js:7:15)
    at /Volumes/Work/stat-tracker/node_modules/openshift-rest-client/lib/basic-auth-request.js:33:21
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  statusCode: 'SELF_SIGNED_CERT_IN_CHAIN'
}

Upon further investigation I found this answer https://stackoverflow.com/a/76227420 which states you can use rejectUnauthorized to ignore invalid (self signed) certificates.
Looking online, specifically at: https://stackoverflow.com/questions/49320486/nodejs-ssl-options-strictssl-vs-rejectunauthorized, I see that strictSSL and rejectUnauthorized are supposed to be equivalent, so I am unsure if there is an issue with undici, but changing strictSSL to rejectUnauthorized seem to fix the issue for me.

closed via #401    Thanks for the contribution


Update jetbrains-compatible-ides.md by adding Writeside

Adding Jetbrains Writeside on the jetbrains compatible IDE.
Writeside (https://www.jetbrains.com/fr-fr/writerside/) is an IDE to create documentation
Why:
Closes: https://github.com/github/docs/issues/34625
JetBrains Writeside is an IDE for creating documentation, and this update ensures that it is reflected in the list of JetBrains IDEs compatible with GitHub Copilot. This will help users who work in documentation and are looking for Copilot support within their preferred JetBrains IDE.
What's being changed (if available, include any code snippets, screenshots, or gifs):
Before:
......
* RubyMine
* RustRover
* WebStorm

After:
......
* RubyMine
* RustRover
* WebStorm
* Writeside

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@MrArnaudMichel Thanks so much for opening a PR! I'll get this triaged for review ✨

@MrArnaudMichel Thank you very much for the typo fix! ✨ This repo is currently in a code freeze, but we will get this merged as soon as the freeze ends on 10/7! 🍏


add tags support, fix #1

[ ] Tag cloud in page with type:tags

[ ] Tags link in meun

Opps,wrong PR,sorry.


Saving event handler fires to encrypt password, but encrypted password doesn't get saved

I'm spending far too much time here, but I have another very odd behavior. I have a route that allows someone to reset their own password. The POST operation sends a very simple JSON packet:
{ "password": "mynewpassowrd" }

On my User model, there is a saving event handler that encrypts the password and set the model attribute. When a new user is created everything works great. When I update the user I can watch the password get encrypted, but what gets saved to the database is the plain text version. I find myself asking this a lot lately, but I have to ask again...what could I be doing wrong here?
// In routes/users.js. The content of req.body is shown above.
exports.resetPassword = function(req, res) {
    return User.forge(req.user)
        .save(req.body, { patch: true })
        .then(function(user) {
            // Deactivate the now-used token
            user.related('forgotPasswordToken')
                .fetch()
                .then(function(fpToken) {
                    fpToken.save({ active: 0 }, { patch: true });
                });

            return user;
        })
        .then(function(user) {
            // jshint unused:false
            return res.status(204).send(null);
        })
        .catch(function(err) {
            console.trace(err.message);
            return res.status(500).send(err.message);
        });
};

// In models/user.js
initialize: function() {
    this.constructor.__super__.initialize();
    this.on('saving', this.encryptPassword);
},

// Later in models/user.js
encryptPassword: function(model, attrs, options) {
    // jshint unused:false
    if (attrs.password) {
        var encPassword = hashPassword(attrs.password);

        // This log write shows plain text --> encrypted and it's exactly correct
        console.log('Setting %s --> %s', attrs.password, encPassword);

        // Have tried this with and without the return
        // The new password gets saved, but it's the plain text version
        return this.set('password', encPassword);
    }
},

I know I've been asking for an awful lot of support from you all and I appreciate it. I'm trying to get a handle on Bookshelf and I feel like nothing makes any sense in my particular implementation, but I can't figure how how/where I've gone so wrong.

So this isn't exactly right. The encrypted password is getting set on the model itself, but isn't making its way to the database when updating. I'm not sure what that means, exactly, but maybe I'm interfering with the sync process in some way...

When you do save(attrs, {patch}), only attrs, i.e. the explicitly passed data, is updated.

@bendrucker I assume you mean that I can't manipulate that value before updating? I thought/assumed that it would only update any explicitly passed key value, but would set its value to whatever it was last assigned. Sounds like that value is immutable once sent, if I understand you correctly, no?

Sort of, although the details aren't exactly correct.
attrs do get set on the model:
https://github.com/tgriesser/bookshelf/blob/702919b5386b20416c2de25cfd5492fd200ae988/lib/model.js#L193
https://github.com/tgriesser/bookshelf/blob/702919b5386b20416c2de25cfd5492fd200ae988/lib/model.js#L205
But then when you use options.patch:
https://github.com/tgriesser/bookshelf/blob/702919b5386b20416c2de25cfd5492fd200ae988/lib/model.js#L220
You shouldn't actually need options.patch here anyway

Okay. I was treating options.patch as a white list for saving, of sorts, not realizing that it's a bit deeper than that. I'll have to read up on that a little more. It's definitely more complex that I initially thought.
Thanks again.


shell-script for updating autodeploy xars on build time

This adds a shell script that will be copied into the container and executed if the docker --build-arg UPDATE_XARS=true. Submitting the $VERSION it will fetch apps.xml from eXist-db's public repo and fetch the latest XAR-versions for this eXist version.

accidentally closed my tab before submitting a longish comment: wrap up:

make update-xars.sh self sufficient so it can be run standoff in order to prepare a folder that can be added to docker runs auto deploy folder: docker run … -v PATH:/opt/exist/autodeploy
alternatively add a build param $ADD_XARS_DIR that would be added to auto deploy, too if you want to add some custom XARs.
if the definition of which XARs to deploy should be submitted via a list of e.g. XAR-names (and then fetched by script from repo):

what happens if no list is provided; this might give  hint on what to get for auto deploy when running update-xars.sh standoff: https://github.com/eXist-db/exist/blob/5bc6a35fd6d4a91742637aefe4ad53c2324284ee/exist-installer/src/main/izpack/install.xml
shouldn't the exist-public-repo URL be the default? Actually on could rely on the technical expertise of the user in this context, no?

@peterstadler please test the list of XARs is fixed for now; have to checkout how to submit an array as docker ARG for individualised XAR list.
But the main goal of updating the XARs on docker build  should be achieved.

btw closes #2

@peterstadler actually there's one more thing I'd like to change: make the scrip runnable in standalone by:

allow $DIR to be set by $3 in calling update-xars.sh

if [[ -d "$3" ]]
then
   DIR="$3"
   CLEANUP=false
elif [[ "$3" != "" ]]
then
   DIR=`mkdir -p "$3"`
else
   DIR=`mktemp -d`
fi

and
# delete temporary dir
if [[ "$CLEANUP" = "false" ]]
then
    echo "XARs are located at: $DIR"
else
    echo "copy updated XARs to autodeploy folder"
    cp "$DIR"/*.xar ${EXIST_HOME}/autodeploy/
    rm -Rf "$DIR"
fi

Is that ok with you?

Hi @bwbohl, just a reminder what we decided at our last conference call:

provide the list of XARs as a build ARG in the Dockerfile and then iterate over this list in the update-xars script
add more comments in the update-xars script for standalone mode

@peterstadler some more considerations:

should the xar-update be available on build of the image?
should the car-update be available on execution of the image, i.e. on-run?
at the moment the default list (if not submitted) of XARs to update is hard-coded, a more flexible solution could be to:

read package-names from the submitted autodeploy folder
read version-specific package-names from the eXist-db code-repo

currently the script is missing the possibility to fetch from different repos

is that really needed?

read package-names from the submitted autodeploy folder

not possible as XAR-filenames do not necessarily match the package's short name which is used to fetch the XARs

should an error be reported if a submitted package nam cannot be retrieved?

should an error be reported if a submitted package nam cannot be retrieved?

fixed in 72a310e9dc0da04bd722b84bcb445381a1771e7b

Thank you very much for the PR!
Indeed, it's a great idea to fetch the latest XARs on image build and this should be added. In addition to the minor issues I added as comments, a major improvement would be to provide the list of XARs as a build ARG in the Dockerfile and then iterate over this list in the update-xars script. Do you think that might be possible?

done

should the xar-update be available on execution of the image, i.e. on-run?

basically it is as you could run the update-xars.sh standalone and provide your local-autodeploy folder as volume option on docker run, e.g.
docker run --rm -it \
    -p 8080:8080 \
    --name existdb \
    -v /your/path/to/exist-data:/opt/exist/data \
    -v /your/path/to/exist-logs:/opt/exist/logs \
    -v /your/path/to/autodeploy-folder:/opt/exist/autodeploy \
    -e EXIST_ENV=development \
    -e EXIST_CONTEXT_PATH=/exist \
    stadlerpeter/existdb:latest

[ ]   currently the script is missing the possibility to fetch from different repos

probably this could be added later

everything's works fine so far but as the base-image has changed will have to do some update work and obviously with the new default packages for exist v5.3.0 we definitely need to get the default list from the exist repo (or somewhere else e.g. maintain a list here)

btw: only adds functx if it is in the default deploys of the eXist-db version; so it closes #3 but functx might be missing for older db version that did not include in the default deploys

ping

Hi @bwbohl, sorry for the delay …
I was just having a look and trying it out: Seems we need to install libxml2-utils (for xmllint) and some other dependencies. So, trying to keep the image size small, I thought of downloading the xars in an initial downloader step in the Dockerfile. We'd then copy over only the xars, not the tools; or do you need the script update-xars.sh in a running container?
If you're ok, I'd try to refactor this to make it work.

yeah, you're probably right. The way you describe is just the way I use it e.g. in https://git.uni-paderborn.de/baz-ga/docker-website/-/blob/main/Dockerfile
Should I create a docker-xar-download (or similar) Docker image that you could just use as FROM in your Dockerfile?


Script Kubernetes deploy/setup

Automate the manual steps, e.g.  copying kubernetes definition files.

@philwinder this has been addressed by your PR #218, right? can we close this?


Document condition syntax

I could not find a documentation for the --condition parameter: exact syntax and which properties can be used

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9dacfad8-cb2f-2534-3b29-89b0930a2252
Version Independent ID: 17325cd4-44c5-4069-d9f6-940a55f0f7c9
Content: az role assignment
Content Source: latest/docs-ref-autogen/role/assignment.yml
Service: azure-resource-manager
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

add to S178

Let me work with RBAC service team to put more information in the doc.

We have marked --condition, --condition-version and --description as preview for now (https://github.com/Azure/azure-cli/pull/15690). The corresponding document will be updated by RBAC service team later.

@aelij Sample is updated for --condition parameter https://docs.microsoft.com/en-us/cli/azure/role/assignment?view=azure-cli-latest

@RakeshMohanMSFT thanks. It could be helpful to add a link to the syntax documentation in addition to a sample.

@aelij the documentation associated with abac conditions in role assignments will be released soon. We are launching public preview for the feature in the next few weeks. Please expect official docs to be updated with new info under the concepts category. Thank you for your patience


Prometheus metrics hardcoded to start at port 8080

The metrics added in #310 listen separately at each mount, with a starting port of 8080. We should be able to customize the start port, but I think it would need to come from the sidecar annotation (gke-gcsfuse/prometheus-start-port: "9090" for example).
With this, prometheus-port doesn't need to be a disallowed flag. Instead it would skip incrementing from the start port.
(Are there options to disable the metrics if users don't want them at all?)

Sure, that's a workaround, but taking 8080 by default is quite abrasive.

I agree. The metrics collection port should be customizable. Hard coding to 8080 is very strict.

Thank you all for your feedback. We have recently disabled metrics exporting by default in #375 to prevent these types of frictions when using the driver. Regarding the port, I agree that this is rather strict. Marking this issue to track this enhancement to increase flexibility with users.

We have recently disabled metrics exporting by default in https://github.com/GoogleCloudPlatform/gcs-fuse-csi-driver/pull/375

Thank you for the rapid fix. Can you also provide some information to the Kubernetes Engine release notes? Since this is a breaking change, it would be good to know which GKE version includes the fixed driver version.


0.3 debugger - TypeError: Elm.fullscreenDebug is not a function

Still getting this error in the Console, with a blank screen, while using the debugging feature (clicking the wrench next to the elm file) on 0.3:
TypeError: Elm.fullscreenDebug is not a function

Have tested on the examples in elm-examples, and the basic game skeleton.
Sorry if the fix isn't part of 0.3, I just assumed that it was.
Edit: seems the error is also happening with master

Have you upgraded to 0.14.1 such that all of your versions match these? Have you cleared out elm-stuff/ to remove any build artifacts?

I used cabal sandbox to install a 0.14.1 in its own directory. I just double checked the git revisions of each repository inside, and it seemed each version matched.
As for elm-stuff/, I'm not sure which you're referring to, but I removed the one in elm-examples, and then removed one I found in elm-reactor, and retested it, and it still produced the same error.
Possibly unrelated, but the wrench symbol also seems to not be showing up. I'm getting what looks like a checkbox instead.

It sounds like you are missing the static resources needed for elm-reactor, so they may not be bundled correctly in general.
What platform are you on? (always put that in the issue!)

I see. I'm on Arch Linux x86_64.
When you say static resources, do you mean various haskell libraries?

I mean the stuff in here which gets some extra generated files as well. All the files should be listed here though I don't know what that maps to on your computer. If you are missing a favicon, the wrench, and Elm.fullscreeDebug is missing, I'm pretty sure it's about these resources.
My theory is that whatever is on hackage is missing these, but I'm not sure how to confirm or deny that.

I'll get back to you on this, but I suspect that cabal has been broken somehow on my system at this point, the BuildFromSource.hs script doesn't seem to even be generating the bin folder anymore.

OK, that's very odd. I deleted my .cabal folder to refresh my configuration (reinstalling cabal for good measure), and when I ran the build script again it generated the files in assets properly, and the debugger started working.
The only thing I can remember configuring was turning on library profiling in the configuration, but it was possible that messed up the configuration file, since cabal was reporting warnings about the configuration file.
I do know that I also moved the cabal sandbox after it was created, but I doubt that would have deleted files.

Ah, that's it. Moving the cabal sandbox messes stuff up. The binaries that are created point to an absolute location on disk, and when you move the sandbox, it moves the static resources. I've seen this once before, very tricky!
Sounds sorted out, so I am going to close. LMK if you run into anything else.

I am having this problem on Windows, with a fresh install of 0.14.1. I have haskell-platform installed as well but I don't think I've messed with anything cabal-related.

I think it was renamed to Elm.debugFullscreen, but I don't know enough about your case to help. Maybe open an issue with more information?

I have this problem with elm platform 0.15.1 installed from npm on archlinux x86_64. I'm quite new to elm, could you suggest where to look at?

Here's how I workaround the (probably) same problem on my Windows 7 64x:
After I noticed that, in the file list page ("http://localhost:8000/"), the icon before my 'App.elm' is broken, I checked the "src" property of that , which is "/_reactor/wrench.png".
I had seen the file under my elm platform folder. So I simply copy the "_reactor" folder to my project folder and done!
I guess elm-reactor is supposed to silently use that shared folder (whoes path had alreay been set as "ELM_HOME" in my system Environment Variables correctly) for every project. However, it doesn't work.