Party Foul: Fix JsCmd handling of extracted event JS

From the commit:
Before, we were using a global appendJs for these events. However, fixHtmlAndJs
already provides a mechanism for returning additional JS. We now use it.
The previous behavior would result in extracted events being appended to the
response (page or AJAX) even if the JsCmd that invoked fixHtmlAndJs was never
actually sent down to the client. This behavior correctly makes the extracted
event JS part of the JsCmd, so that it can be sent down only with that JsCmd.
Also ran into a bunch of scaladoc warnings that I finally got tired of and :facepunch:ed
them.
Fixes #1782 . Tested on the example in the ML post linked from there.

Considering this was tested on the example and fixed, and the OP on the mailing list also gave it an ok, :+1:
and merging


add integration test ci

Changes are:

Benchmark only run on merge to master, no need to run twice.
Self-hosted machine use a more accurate name
After we built a binary, start it in --dev mode and run some integration tests.

Codecov Report

Merging #159 (0609087) into master (b7447dc) will not change coverage.
 Consider uploading reports for the commit 5bee6e8 to get more accurate results

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   80.07%   80.07%
=======================================
  Files          57       57
  Lines       16003    16003
=======================================
  Hits        12814    12814
  Misses       3189     3189

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7447dc...5bee6e8. Read the comment docs.

@jerry-yu please take a look.


Add smartphone bookmark icons

Issue
Add smartphone bookmark icons

Implemented.
https://github.com/true-runes/eiyuden-shinsho/releases/tag/v0.0.1


correct grammar

Actually the first "are" is correct, as it's referring to something in the plural (system-wide dependencies) ;)
Also if we correct 41, let's do the same in 44.

@thegrammarnazi Please try to fix your engine and submit PR again :)


key set to true results in 'true'

- name: 🏕 Set Environment to production
        uses: fjogeleit/yaml-update-action@main
        with:
          valueFile: 'knotentheme.yaml'
          propertyPath: 'production'
          value: true
          commitChange: false
          updateFile: true

this results in
production: 'true'
is it possible to change it to
production: true
???
i dont need the single quotes.

could something like value: !!bool true work?

hey, currently not because github action convert properties always into a string value. The mapping you mentioned only works from YAML -> JS but it looks like not the other way around.
I could implement some kind of conversions for some basic types. I will have a look on it.

You can try out the new v0.10.0 of this action. It supports the mentioned YAML type casting syntax.
See https://github.com/fjogeleit/yaml-update-action/blob/main/.github/workflows/test.yml#L105 for reference. Please let me know if it works or if you still have any issue.

Thanks for the fast response. We tested the new version in https://github.com/metaknoten/knotentheme/commit/1acf91171b281313e51d21ae6afb0222021c4070 .
For boolean types the action now works as expected.

thanks a lot everybody


fix(binaries): remove introspection & fmt

merge before 4.13.0 (#825)
merge after 4.10.0 (#824)

superseded by #842


refactor(@angular/ssr): add route configs to public API

These interfaces needs to be exported to be included in adev.

The changes were merged into the following branches: main, 19.0.x


[BUG]  System.UnauthorizedAccessException: Access to the path 'C:\Users\lorde\AppData\Local\Bloxstrap\Bloxstrap.exe' is denied.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
System.UnauthorizedAccessException: Access to the path 'C:\Users\lorde\AppData\Local\Bloxstrap\Bloxstrap.exe' is denied.

Did you read the relevant Wiki pages?


clientId is a guid, right?

I'm pretty sure I'm supposed to put the redirect url as msal3f748dfd-91ed-4b50-a41c-6ca5242a2043://auth but since the example doesn't use a guid I'm not 100%.
The doc uses: msal1234abcd://auth.
What about updating the doc page to use a Guid to remove this uncertainty?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11f5b457-d99a-06d4-d203-f9eeaa27e0d9
Version Independent ID: b23b3a5d-b63b-dfe1-bb46-94f57c907be5
Content: Authenticate Users with Azure Active Directory B2C - Xamarin
Content Source: docs/xamarin-forms/data-cloud/authentication/azure-ad-b2c.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @spottedmahn,
I responded to one of your other issues with a bit more detail on why this works the way it does. There are two reasons why I didn't use a Guid in the doc:
First, technically I'm not sure it has to be a guid - I believe "msal123" would work. However, since that is not unique if two different applications registered to handle "msal123" URI scheme, the Android OS would not know where to route the request. So a guid is recommended.
Second, we usually avoid putting real values such as a guid into docs. It is easy to misunderstand if a guid value is the specific value that must be used or just an example!


Code highlighting didn't work

Hello,Thanks for the theme you designed, but after I configured it according to the method given by your README, in my blog, the code highlights and doesn't work, the black background and the black words make people feel bad. In the solar directory, the highlight configuration used in _config.yml is the default. What is the cause of this problem?

My blog link : https://taolaw.github.io/
I have wasted a morning for this highlighted configuration, I hope you can help me.
Thanks!

Hi,  I am happy the hear that you like the theme.
Can you try to define the code blog usingdifferent language attribute as here (key word javascript)
<script type="text/javascript">
function intArraySort(c, a) {
    function d(a, b) { return b - a; }
    "string" == typeof a && a.toLowerCase();
    switch (a) {
        default: return c.sort(function(a, b) { return a - b; });
        case 1:
                case "d":      test1
    }
};
</script>

I hope this will help. Do not forget to git star the repo if you like it  :-)

Sorry, I still can't solve the problem I faced with the above method. Here is my _config.yml configuration about code highlighting. It defaults to lightcode. I see a lot of highlighting styles in the source/_highlight/ directory. What is the relationship between these files and the configuration here? How to make the code highlight like the one given in your demo, I hope you have time to help solve my doubts, thank you!
# eg. generate with http://realfavicongenerator.net/
      desktop:
        url: /images/favicon.jpeg
        gravatar: false
      android:
        url: /images/favicon-192x192.jpeg
        gravator: false
      apple:
        url: /images/apple-touch-icon.jpeg
        gravator: false
    social_links:
        github: https://github.com/tzvetkov75/solar-theme-hexo
        twitter: /
        facebook: /
        linkedin: /
    post_count: 5
    highlight: monokai-sublime

Hi,
see the last attribute
highlight: monokai-sublime
it provides the name of the highlight schema file as  in the directory  source/_highlight/
use highlight: lightcode to get better result


Fix benches

Fixes bench compilation error on M1. Seems like some of cfg directives were conflicting. I copied cfg of the implementation check from lib.rs.
Changed benches from hashing a const value to generating inputs at run-time.

Changed benches from hashing a const value to generating inputs at run-time.

To clarify, the time to create the input is not included in the measured time, correct?

To clarify, the time to create the input is not included in the measured time, correct?

Yes, that's correct.
It seems to me that currently these benches are measuring throughput (because each hash computation is independent). I would like to add benches for latency, is that ok?


Miss match seperater in get_metrics function

I think there is a small mismatch seperater between create_data_in_joint_task_format function and get_metrics function:

In create_data_in_joint_task_format function, data is joined by ','
  df['labels'] = df[aspect_col].apply(lambda x: ','.join([f"{i[key]}:{i[label_key]}" for i in x]))

In get_metrics function, data is splitted by ', ':
   gt_list = gt.split(', ')

Can you help me check if there is a typo?
Many thanks,
Dan

hi， i would like to discuss this issue with you and also ask for my doubts about some of the code
I also want to inquire about these code blocks, and in addition, I would like to know if get_metrics function be more accurate in the following situations, resulting in higher results, for example:
input: They wouldnt even let me finish my glass of wine before offering another.
output: glass of wine:neutral
predict: wine:neutral

In similar situations, we tend to predict the joint task as' wine: net ', but in get_metrics function, it uses "in instead of ==, and I think it ignores the prefix, so the result of the "ATE task" would be better:
for gt_val in gt_list:
    for pred_val in pred_list:
        # if pred_val.lower() == gt_val.lower() or gt_val.lower() == pred_val.lower():
        if pred_val.lower() in gt_val.lower() or gt_val.lower() in pred_val.lower():
            tp+=1
            break

May I ask if you can answer my doubts？ @dannhh @kevinscaria

@Lurkhunter ,
Since this is a generative model, it might produce some tokens that it feels are additionally right.
Upon further analysis of such text inputs, we believe that the text generated should be classified as completely wrong for only those samples that generate outputs that are entirely wrong. But in the example provided by you: glass of wine/ wine is not wrong. The model has extracted the key aspect required.
If the model generates wine/glass of wine and the aspect polarity is also correct, the model is doing its job.  The correct metric for comparing generative models is the ROUGE score. Other approaches that use generative models follow a token classification approach so using P, R, and F1 is intuitive. But since this approach is purely generative, we believe the penalization steps to evaluate our model are sound.
However, for your use case, if you believe it should be equal to instead of the "in" operator, you can go modify it in your forked version of the repository. Hope it helps.
Best,
KJS

@dannhh
I will correct that. Thank you for bringing it to my notice. I added that separator to adjust for a small data sample when I was testing. But it's not generalized, so I will push the updated version of the code by Sunday.
Best,
KJS


Key mapping for colons

There isn't a key mapping for colons yet

Ah nevermind, somehow I forgot that a colon isn't part of the default keys (need to press shift)


displaying/hiding start screen and starting timer

Click event on Start Button, adds hide class to start-screen and images and begins timer. Ready for questions to display next.

Changes reviewed - Merge approved with Team.


Routes?

cheezy's PageObject implementation (https://github.com/cheezy/page-object) has a 'routes' feature that lets you define navigational flows to particular pages. Something like this,
PageObject::PageFactory.routes = {
:default => [[HomePage, :select_puppy],
[DetailsPage, :add_to_cart],
[ShoppingCartPage, :proceed_to_checkout],
[CheckoutPage, :checkout]]
}
And then, in a step definition, you just call
navigate_to(CheckoutPage)
Which avoids repeating all the steps to get to that page. Is there something similar available for SitePrism?

Is there something similar available for SitePrism?

No. Nice feature, but nothing that couldn't be achieved in a simple method.


Add version subcommand/info

I just reinstalled the latest to confirm a bugfix and there doesn't yet seem to be a way to verify which version I'm running.

That's a very good point, thanks for that :)
I've pushed a new version 0.2.3 with a new subcommand version.


issue when istalling from a clean conda

$ conda create --name CIA_pip python ipykernel
$ conda activate CIA_pip
$ pip install cia-python

Error:
Collecting cia-python
Using cached cia_python-1.0a4-py3-none-any.whl.metadata (3.7 kB)
Collecting seaborn (from cia-python)
Using cached seaborn-0.13.2-py3-none-any.whl.metadata (5.4 kB)
Collecting numpy (from cia-python)
Downloading numpy-2.2.1-cp313-cp313-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (62 kB)
Collecting pandas (from cia-python)
Downloading pandas-2.2.3-cp313-cp313-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (89 kB)
Collecting AnnData (from cia-python)
Using cached anndata-0.11.1-py3-none-any.whl.metadata (8.2 kB)
Collecting scanpy (from cia-python)
Using cached scanpy-1.10.4-py3-none-any.whl.metadata (9.3 kB)
Collecting array-api-compat!=1.5,>1.4 (from AnnData->cia-python)
Using cached array_api_compat-1.9.1-py3-none-any.whl.metadata (1.6 kB)
Collecting h5py>=3.6 (from AnnData->cia-python)
Downloading h5py-3.12.1-cp313-cp313-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (2.5 kB)
Collecting natsort (from AnnData->cia-python)
Using cached natsort-8.4.0-py3-none-any.whl.metadata (21 kB)
Requirement already satisfied: packaging>=20.0 in /mnt/home/gobbini/miniconda3/envs/CIA_pip/lib/python3.13/site-packages (from AnnData->cia-python) (24.2)
Collecting scipy>1.8 (from AnnData->cia-python)
Downloading scipy-1.14.1-cp313-cp313-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (60 kB)
Requirement already satisfied: python-dateutil>=2.8.2 in /mnt/home/gobbini/miniconda3/envs/CIA_pip/lib/python3.13/site-packages (from pandas->cia-python) (2.9.0.post0)
Collecting pytz>=2020.1 (from pandas->cia-python)
Using cached pytz-2024.2-py2.py3-none-any.whl.metadata (22 kB)
Collecting tzdata>=2022.7 (from pandas->cia-python)
Using cached tzdata-2024.2-py2.py3-none-any.whl.metadata (1.4 kB)
Collecting joblib (from scanpy->cia-python)
Using cached joblib-1.4.2-py3-none-any.whl.metadata (5.4 kB)
Collecting legacy-api-wrap>=1.4 (from scanpy->cia-python)
Using cached legacy_api_wrap-1.4.1-py3-none-any.whl.metadata (2.1 kB)
Collecting matplotlib>=3.6 (from scanpy->cia-python)
Downloading matplotlib-3.10.0-cp313-cp313-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (11 kB)
Collecting networkx>=2.7 (from scanpy->cia-python)
Using cached networkx-3.4.2-py3-none-any.whl.metadata (6.3 kB)
Collecting numba>=0.56 (from scanpy->cia-python)
Downloading numba-0.60.0.tar.gz (2.7 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.7/2.7 MB 45.8 MB/s eta 0:00:00
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [24 lines of output]
Traceback (most recent call last):
File "/mnt/home/gobbini/miniconda3/envs/CIA_pip/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in
main()
~~~~^^
File "/mnt/home/gobbini/miniconda3/envs/CIA_pip/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
~~~~^^^^^^^^^^^^^^^^^^^^^^^^
File "/mnt/home/gobbini/miniconda3/envs/CIA_pip/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
File "/tmp/pip-build-env-09nm03sf/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 334, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=[])
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-09nm03sf/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 304, in _get_build_requires
self.run_setup()
~~~~~~~~~~~~~~^^
File "/tmp/pip-build-env-09nm03sf/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 522, in run_setup
super().run_setup(setup_script=setup_script)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-09nm03sf/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 320, in run_setup
exec(code, locals())
~~~~^^^^^^^^^^^^^^^^
File "", line 51, in
File "", line 48, in _guard_py_ver
RuntimeError: Cannot install on Python version 3.13.1; only versions >=3.9,<3.13 are supported.
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.

seems an issue with the python version. Downgrade python at v3.12 solve the issue:
> conda install python==3.12

Required check the compatibility with further python versions.


Bugfix/317

uint64 cast to int64 caused lost of data #317

Any plans to merge this? :)
Would be nice to have it in a future release (currently I have to do some pretty nasty workarounds to not run into this). Or is there any way how I can support to get it merged? :)

Hi @Hackfred , as @mattn and @doug-martin did not come for a long time. Maybe you can use my fork before this PR is merged.
add the below line before the require ( line in your go.mod file,
replace github.com/doug-martin/goqu/v9 v9.18.0 => github.com/XIELongDragon/goqu/v9 v9.18.1
you may need to update the goqu version v9.18.0 to the version you used.

@mattn @Frug can you help to take a look at this PR?


Stream is inactive on iPhone but active on laptop's camera

Using my laptop's webcam works just fine, however on my iPhone the camera opens and stops streaming immediately.  Just a still image. When I open the the iPhone in console, it shows the stream is inactive.  Any thoughts on how to activate the stream?

I have the same problem. On the demo site the same problem occurs using ios. It is worth saying that I tested both on safari and chrome

@vinnydeveloper Did you ever get this fixed?

Hello,
you have to modifiy arguments like this

You can use the fork https://github.com/avmaisak/QrCodeHtmlScanner it's working but with a little probleme to use all camera.


v0.2.0

use not deprecated diesel::backend::Backend::RawValue;
updated readme

Hey there @stuffy-idler, sorry about not seeing your PR :(. I've now merged my diesel-2.0 branch into master and published it, but your changes look good! Could you point this PR at master, and then we'll get it merged and published!


[META] Weighted Routing Issue List

Is your feature request related to a problem? Please describe.

Issues listed under this meta issue are related to Weighted Routing.

Describe the solution you'd like

[x]  Feature Proposal [Feature] Support for weighted zonal search request routing policy
[x] [Weighted Shard Routing] Fail open weighed away AZ
[x]   API [RFC] API for decommissioning/recommissioning zone and weighted zonal search request routing policy

Tasks

[x]  https://github.com/opensearch-project/OpenSearch/issues/4525
[x]  https://github.com/opensearch-project/OpenSearch/pull/4241
[x] https://github.com/opensearch-project/OpenSearch/pull/4272
[x]  https://github.com/opensearch-project/OpenSearch/pull/4275
[x] https://github.com/opensearch-project/OpenSearch/pull/4400
[x] https://github.com/opensearch-project/OpenSearch/issues/4747
[x] https://github.com/opensearch-project/OpenSearch/issues/5038
[x] https://github.com/opensearch-project/OpenSearch/issues/5037
[x] https://github.com/opensearch-project/OpenSearch/issues/5304
[ ] https://github.com/opensearch-project/OpenSearch/issues/5754
[x] https://github.com/opensearch-project/OpenSearch/pull/5680
[x] https://github.com/opensearch-project/OpenSearch/issues/5873
[x] https://github.com/opensearch-project/OpenSearch/pull/6198
[ ] https://github.com/opensearch-project/OpenSearch/issues/6297

Bugs

[x] https://github.com/opensearch-project/OpenSearch/issues/4690
[x] https://github.com/opensearch-project/OpenSearch/issues/6056
[x] https://github.com/opensearch-project/OpenSearch/pull/6327

@anshu1106 / @pranikum  can this be closed now?


Creating script element resulting unexpected opening tag.

I found an issue when creating a script element.,
the script element toSting() result '\x3Cscript />' instead of
Kindly need you to review.
Thanks & regards

self closing tags don't exist in HTML


Added try-catch to avoid exception for snippet load

tasks:

[ ] gather feedback for my changes

informations:

q
a

Fixed tickets
fixes #1384

BC breaks
none

Documentation PR
none

Tests missing

@danrot testcase added


Porn sites

porngur.com
maxiporn.com
adultporn.me
hd-porn.video
animalporn.me
sonmompornincestxxx.com
lusthero.com
porn-hub.live
chinaporns.com
iwankwank.com
porm.club

If you leave them as naked domains (as in without the www., etc. bit), it should not hyperlink them, and create linkbacks, trackbacks, refbacks and pingbacks from the sites, reducing traffic and minimising additional 'profiling' the sites and their standing, as well as traffic. If they only work with the www/other prefix, you can manually remove these in this edit tool. Just a suggestion.

@Hyperpolymath that's not how hosts files work.
Hosts files work with the full (sub)domain names.  So example.com and www.example.com are two different hosts, and to block both we need both. Also there is nothing magical or special about the www. prefix.
Anyway it's not about links and back links at all. We need the fully qualified (sub)domain(s) here.
Thank you for these domains @sefinek24 ping @sinfonietta to include these.


Bug: Footnotes look ugly on mobile

resolve to fit screen width or track the scripture view's width.

The specific issue mentioned here appears to have been resolved.  Footnote now tracks to the screen width


Failed to ingest events

Failed to ingest events .catch() Timeout
Machine ID: 787673b8-b809-4435-9458-1be2a82817a8

[!NOTE]
Book a call

key
value

id
phqwjzSd0FUv6hmeXi6ur

url
http://localhost:3000/sign-in

wifi
4g

cpu
8

mem
8

gpu
ANGLE (Intel, Mesa Intel(R) UHD Graphics 620 (KBL GT2), OpenGL 4.6)

time
1722437795730

items
0

bytes
0

Hi @chiefkarim , we've just deployed a fix for you. Can you try running the setup script npx million@latest. Once it's done, please restart your VSCode/Cursor. Let me know if that works for you!


Add environment variable to prevent saving cache.

Problem
On bigger repos, the maximum cache size of 10 GB is easily exceeded with PRs.
Possible Solution
It would be nice if there was a global environment variable one could use to prevent saving cache in PRs.
I'm creating this issue here because if this was implemented at the library level, any action that uses this would automatically benefit from it without having to implement it themselves. I'm going around figuring out which actions are creating caches right now and creating issues for all of them.
References
https://github.com/Swatinem/rust-cache/issues/95

Oh wait, this isn't the library, need to move it to https://github.com/actions/toolkit

Would still be nice for this to have an option instead of requiring a separate action


@signature names aren’t clickable in docs

@hojberg can you check if this is a front-end or a backend thing?

Moved to the codebase-ui repository.

@pchiusano hmmm, I guess since its a "HashQualifier", I don't know if its a link to a term or a type 🤔


backport to 1.15: vrp: allow supervisord to open its log file (#14066)

Commit Message: Allow supervisord to open its log file
Additional Description:
Change the default location of the log file and give supervisord
permissions to write to it.
Risk Level: low
Testing: built image locally
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

LGTM, do we need anything in the release notes?


Add support for Fabric variants

Add support for Legacy Fabric and Babric.

bump? Is any dev aware of this pull request?


Fix hardcoded cluster autoscaler value (#21)

The goal of this PR is to resolve the hardcoded AWS region issue defined in #21.
Issue #, if available: #21
Description of changes:

Added input variable to allow for customization of the target AWS region for cluster autoscaling.
Default to the current provider AWS region, if no region is specified.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing this per the comment here and the changes in the test-eks-tf-demo branch.


eclipse formatting fixes and added import order specs

eclipse formatting fixes according to the current code base:

tabs should not be allowed, only spaces
block braces should be on the same line (consistent with the code base)
braces for array initializers should be on the same line (consistent with the code base)
empty array initializer should be on the same line (consistent with 3))

Also added an import order specifier

👍

:+1:

@jon-wei  / @fjy does this fix https://github.com/druid-io/druid/issues/1951 ?

@drcrallen yes it should

@drcrallen I am not sure how much it fixes, but there were some obvious differences, especially around how tabs are treated etc.


First term definition for the AtSign Glossary!

- What I did
-Set up repo and Hugo for development on my machine.

Created a new single page for the privacy definition

- How I did it
I pulled the template from archetypes and added my definition draft from the google doc.
- How to verify it
Run the changes on a local server to make sure what I added is correct. Should look like this:

- Description for the changelog

Edit encryption.md with weight: 2 for ordering purposes
Do we want alphabetical order? If I leave all weights as 1 then the items will automatically order themselves. However, I do not know if this will be an issue.

Edit encryption.md with weight: 2 for ordering purposes

Do we want alphabetical order? If I leave all weights as 1 then the items will automatically order themselves. However, I do not know if this will be an issue.

Yeah, I guess glossaries are in alphabetical order.
IMO, it will feel out of place having something like PKAM and CRAM on opposite sides of the glossary though.
Probably a problem to worry about later. Thanks Jesse!


No error message for not authorized users trying to bookmark API

When not authorized user trying to bookmark API at public catalogue, there is no error message showing. After click nothing happens.
Maybe we need to remove this column or to show a message to the user, same as we do for rate column.

Already fixed in develop with new catalogue view.


rm: fix issue #6620 (refuse to remove '.' and '..')

Before processing the directory, if it ends with "." or "..", it now immediately returns with the same error message as GNU
Should close #6620

I see this does the same thing as #6621

but tests/rm/r-4  is fixed in the other PR
(your modification is smaller than the other)

Thanks. Do you want me to close this out? Or which PR will get merged?

the other PR code is a bit more complex.

@just-an-engineer what is your plan wrt this PR?

We can merge this one if @AnirbanHalder654322 doesn't have any progress on the other PR, since I already have it working without regex, it already works on Windows, and since I made them a coauthor on the commits. But if they responds and pushes whatever changes, I'll leave it to you or them, but if the other one gets merged, I can just close this one.
So I can go either way. It can be merged right now, or it can be closed if Anirban pushes the necessary changes and you decide to go with that one

@sylvestre, I'm marking this as a draft, and I'll close it out once @AnirbanHalder654322 PR gets merged. His is starting to look a bit cleaner and more fleshed out than mine. Particularly with removing trailing slashes, and more comprehensive tests, in my opinion.

@just-an-engineer it is still marked as draft, are you still working on it? thanks


tailwindcss-bin: init at 3.3.2

Description of changes
https://tailwindcss.com/blog/standalone-cli
Based off #214869 but refactored with update script.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I explored building from source, but standalone-cli uses vercel/pkgs which expects to either downloads nodejs base binaries or build them from the nodejs source. I decided I had better things to do.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2387


[Event Change Request] table 36 "Sales Header" - OnValidateSellToCustomerNoOnAfterCalcShouldSkipConfirmSellToCustomerDialog

Hello, is it possible to change the OnValidateSellToCustomerNoOnAfterCalcShouldSkipConfirmSellToCustomerDialog Event to the follow?
        field(2; "Sell-to Customer No."; Code[20])
        {
            Caption = 'Sell-to Customer No.';
            TableRelation = Customer;

            trigger OnValidate()
            var
                LocationCode: Code[10];
                ShouldSkipConfirmSellToCustomerDialog: Boolean;
                IsHandled: Boolean;
            begin
                CheckCreditLimitIfLineNotInsertedYet();
                if "No." = '' then
                    InitRecord();
                TestStatusOpen();
                if ("Sell-to Customer No." <> xRec."Sell-to Customer No.") and
                   (xRec."Sell-to Customer No." <> '')
                then begin
                    if ("Opportunity No." <> '') and ("Document Type" in ["Document Type"::Quote, "Document Type"::Order]) then
                        Error(
                          Text062,
                          FieldCaption("Sell-to Customer No."),
                          FieldCaption("Opportunity No."),
                          "Opportunity No.",
                          "Document Type");

                    ShouldSkipConfirmSellToCustomerDialog := GetHideValidationDialog() or not GuiAllowed();
                    OnValidateSellToCustomerNoOnAfterCalcShouldSkipConfirmSellToCustomerDialog(Rec, ShouldSkipConfirmSellToCustomerDialog, Confirmed);
                    if not ShouldSkipConfirmSellToCustomerDialog then
                        Confirmed := Confirm(ConfirmChangeQst, false, SellToCustomerTxt);
                    if Confirmed then begin
                        SalesLine.SetRange("Document Type", "Document Type");
                        SalesLine.SetRange("Document No.", "No.");
                        if "Sell-to Customer No." = '' then begin

    [IntegrationEvent(false, false)]
    local procedure OnValidateSellToCustomerNoOnAfterCalcShouldSkipConfirmSellToCustomerDialog(var SalesHeader: Record "Sales Header"; var ShouldSkipConfirmSellToCustomerDialog: Boolean; var Confirmed: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 13270.


Move from Files to Database

TODO

[x] Verify functionality works on PythonAnywhere
[x] Move data from files to db

Use Bruno to make a request

[ ] Update unit tests

Need to mock a MySQL database connection for the tests

I'll try fixing the unit tests in a separate task


Sometimes a browser hangs during functional tests execution.

Example:
https://travis-ci.org/testcafe-build-bot/testcafe/jobs/114795182
Browser hangs with next error in console:
http://screencast.com/t/mCNz3qyWLSmk
At that moment another browser after test run redirecting to the idle page of hanging browser.

Fixed in testcafe-hammerhed issue #484.
Waiting for update of testcafe-hammerhead version in package.json.

Fixed via Type automation refactoring commit - testcafe-hammerhead updated to ^7.0.0


Error in the notification menu

TypeError at /admin/shop/notification/
str returned non-string (type proxy)
Request Method: GET
http://<IP_ADDRESS>:8000/admin/shop/notification/
Error during template rendering
In template /home/leo/.local/share/virtualenvs/ga-JBWdJ7V9/lib/python3.6/site-packages/django/contrib/admin/templates/admin/base.html, error at line 75
str returned non-string (type proxy)
{% block object-tools %}{% endblock %}
`
Traceback (most recent call last):
File "/home/leo/.local/share/virtualenvs/garantum-JBWdJ7V9/lib/python3.6/site-packages/django/contrib/admin/utils.py", line 283, in lookup_field
f = _get_non_gfk_field(opts, name)

File "/home/leo/.local/share/virtualenvs/garantum-JBWdJ7V9/lib/python3.6/site-packages/django/contrib/admin/utils.py", line 317, in _get_non_gfk_field
field = opts.get_field(name)

File "/home/leo/.local/share/virtualenvs/garantum-JBWdJ7V9/lib/python3.6/site-packages/django/db/models/options.py", line 619, in get_field
raise FieldDoesNotExist("%s has no field named '%s'" % (self.object_name, field_name))

django.core.exceptions.FieldDoesNotExist: Notification has no field named 'get_recipient'
`

Thanks for reporting


[FLINK-10637] Use MiniClusterResource for tests in flink-runtime

What is the purpose of the change
Rename MiniClusterResource into MiniClusterWithClientResource and move base functionality
in the form of MiniClusterResource into flink-runtime. The new base class simply starts a
MiniCluster with random ports.
Moreover, this commit lets almost all tests in flink-runtime use the MiniClusterResource
to guarantee that there are no port conflicts between concurrently executed tests.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thanks for the review @zentol. I've addressed all your comments.

hold on, I'm wondering about one thing: Do we really want to change the package? It's not unlikely that there are users out there relying on the MiniClusterResource, we've regularly point users toward that class for testing purposes.

This is a good question @zentol. I guess it would not hurt (apart from looking a bit ugly in flink-runtime) to not change the package name. That way, people should not be affected by moving this class from one module into another.
I would actually propose the following: We create a org.apache.flink.test.util.MiniClusterResource extends org.apache.flink.runtime.util.MiniClusterResource and mark it as deprecated. The same applies to the MiniClusterResourceConfiguration. That we can remove this class with next major release after our users have hopefully migrated to the right class. What do you think?

I've added another commit reintroducing the MiniClusterResource extends MiniClusterWithClientResource and MiniClusterResourceConfiguration in the flink-test-utils package under org.apache.flink.test.

sounds good to me @tillrohrmann .


[Feature]: update useBooleanState return value Array to Object

Package Scope

[x] Add to an existing package
[ ] New package

Package name: @toss/react
Overview

I think is more convenient return value is Object not array
Situations
Array return value is up to user remember what position it is
// In this case developer stop coding, and check docs for
// where is it (such as where is the value, and where is the toggle function)
const [] = useBooleanState()

Array return value is inconvenient for using specific return value
// developer who wants to taking boolean value and toggle function
const [bool, _, _, toggle] = useBooleanState()

Describe the solution you'd like
I Propose change the return value array to Object value
for example (for user interface)
const { value, toggle } = useBooleanState()

reference - @chakra-ui/useDisClosure

I think it's a good direction from array to object.(cuz DX)
Considering the many services that are using this hook, how do we consider sub-compatibility?
Will it be solved if we specify  just "BREAKING CHANGE"?

Thank you for your opinion. @ChanhyukPark-Tech
Thank you for pointing out what I was worried about, too.
I think it could be a fatal issue for someone who is upgrading the version. (Because the return type is different)
However, I suggested this issue because I thought it would be an acceptable change considering the many people who will install this package latest version.

@minsoo-web, You can check other maintainer's opinions in https://github.com/toss/slash/pull/203

Thank you @manudeli !!
I understand about this Hook's history and check other maintainer's options.
This Issue can be closed because new API (useToggleState) is created #273.
So I close this Issue


[InputLabel] Change size prop option from normal to medium

Replaces normal with medium
More in line with size props in the rest of the package(s)
As far as I can tell, this is the only component that uses small/normal as the size options, opposed to small/medium

I didn't leave it "backwards compatible" since the size prop is not used when it's set to default/normal anyway, but I can adjust that if normal should be type supported until the next major version.

[x] I have followed (at least) the PR section of the contributing guide.

Thanks for your PR. Indeed this seems like the only place we use the term "normal" when describing size.
However, even though this is the default value, there may be implementations where developers use it explicitly. We don't want to introduce breaking changes outside of major versions.
I'm happy to assign it to the v6 milestone and include it in that release.

Sounds good to me.


[dv/otp_ctrl] increased spinwait timeout duration for otp_ctrl_parallel_lc_req_vseq

Consistency and integrity checks performed by otp_ctrl_smoke in parallel to LC state transition requests are halted until the LC partition is fully programmed, which might cause the spinwait on OTP_CTRL.STATUS.CHECK_PENDING to raise false negative timeout due to short duration of the default spinwait timeout, as real OTP PROG operations take much longer in reality then the generic memory array in the OS implementation. Hence, this request scales up the default spinwait timeout duration to solves the issue.

Hi @msfschaffner,
Can you please help with the CI failures?


Edit csv button not displayed

What OS?

Mac

Description
"Edit csv" button is not displayed. The filetype is CSV.

Steps to reproduce
Just open this sample.csv.

Have you installed the extension? Or is it disabled?
Does it work with other files?

Do you use the insider version or github.dev or something special? Or do you have the .csv file extension mapped to a different file type (search in settings for associations and look for Files: Associations)?

Ah, I don't know where this came from, but it was there:
    "csv-edit.hideOpenCsvEditorUiActions": false,

Sorry for the trouble, closing the issue.


Jungle log and fences

Have you used a modern version? Or just old versions?
On Thu, Nov 23, 2023, 10:52 AM Enc0dek @.***> wrote:

[image: image]
https://user-images.githubusercontent.com/87038378/285290012-9786a09e-5cf9-4cc2-8ecd-8a72bf08a554.png
[image: image]
https://user-images.githubusercontent.com/87038378/285290176-349005cf-8ed7-4a97-97d6-baa54098a1f3.png
—
Reply to this email directly, view it on GitHub
https://github.com/RavinMaddHatter/Structura/issues/212, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBUC5GMEJDNNXUMPYPFSXTYF6LPZAVCNFSM6AAAAAA7YFD2HOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYDQNRYG42DSNY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Failing to load after install is completed

After running the script. I am unable to see the OS to be able to be booted from. I not seeing the initial boot come through either.

Try again, just commited a fixed earlier today to fix boot issues


pull request for e2e test at 02/05/2017 15:15:06

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ignore autoCreate and autoUpdate fields when using FullSaveAssociations

Your Question

Those are my example models
type Result struct {
	Uk        int     `gorm:"primary_key;not null;autoIncrement"`
	Contents  string
	CreatedDt int64   `gorm:"autoCreateTime"`
	UpdatedDt int64   `gorm:"autoUpdateTime"`

        AnswerList []Answer `gorm:"references:uk;foreignKey:result_uk"`
}
type Answer struct {
	Uk        int       `gorm:"primary_key;not null;autoIncrement"`
	ResultUk  int
	Contents  string
	CreatedDt int64   `gorm:"autoCreateTime"`
	UpdatedDt int64   `gorm:"autoUpdateTime"`
}

and then, I update Result object after set the session with FullSaveAssociations like below
// I never change and never set CreatedDt or UpdateDt fields
db.Session(&gorm.Session{FullSaveAssociations: true}).Save(&result)

I expected that CreatedDt and UpdatedDt should not be in ON DUPLICATED KEY UPDATE clause. But those are in generated SQL
even I didn't setup those values in result object.
if I want to update with totally same Answer object in there, it always updated without any change (gorm only changes updatedDt)
Am I doing wrong with the session or autoCreateTime Tag?
The document you expected this should be explained

FullSaveAssociations
Expected answer

Tell me the right way please!

It doesn't make sense to ignore CreatedAt, UpdatedAt column when doing a FullSaveAssociations , but you could omit the fields with Omit right now.

e.g:
db.Omit("Answer.CreatedAt", "Answer.UpdatedAt").Create(&result)


Can I add Fake news Detection Project?

Not here.. Because we are looking for data analysis.. But you can give your project here in the issue so that we all can have a look @rishabhrathore055


example_dags/cron_replacement.py

I really like the concept of Airflow but I've been stumped trying to get a simple cron replacement example DAG working.
I took the example_bash_operator.py and changed args like so:
 args = {
    'owner': 'airflow',
    'start_date': datetime.now(),
    'schedule_interval': timedelta(minutes = 5)
}

I was expecting this DAG to start now and run every 5 minutes, but instead the scheduler runs the DAG in a loop, back-to-back.
I'd imagine migrating from cron to Airflow would be a pretty common use case - it would be awesome to see an example DAG for replacing e.g. a cron that runs every 6 hours.

There's a little more information here: #7.
I think what might be happening is that the scheduler is kicking off from the date of the 'start_date', ignoring the hours/mins/secs, and then running every 5 minutes to "catch up" until present time.
But that would seem to be contradicted by the documentation:
start_date (datetime.datetime) – The timestamp ...

Note datetime.datetime (not datetime.date), and "timestamp" reference...

schedule_interval currently can only be defined at the DAG level, when creating a DAG instance. If you write dag = DAG(default_args=args, schedule_interval=timedelta(minutes=5)) you'll get a 5 minutes DAG. The schedule_interval at the task level is currently disregarded and the one from the DAG level is forced. In theory you could have a DAG with tasks running at different intervals but that may be slightly confusing so I switched that feature off for now. I could re-enable it easily.
The scheduler will start on start_date, and attempt to run for every schedule_interval from that point. I think the scheduler is set to trigger every minute by default.

Thanks for your speedy answer Maxime! If I pass in datetime.datetime(2015, 6, 15, 7, 28, 48, 163296) as my start_date, then does the scheduler start:

At datetime.datetime(2015, 6, 15, 7, 28, 48, 163296), or
At datetime.datetime(2015, 6, 15, 0, 0, 0, 0)?

The key for a task instance is (dag_id, task_id, execution_date). Your first execution_date is == to your start_date, then your following execution_date will be start_date + schedule_interval (and so on).
So. You should definitely round down your start_date to match your schedule_interval. Meaning if you run an hourly DAG, your start_date should be truncated to a specific hour, otherwise that's just confusing to have trailing minutes/seconds.
Also, if we were to support DAGs with heterogenous schedule_interval, (say a mix of hourly and daily), you'd want them to align on the execution_date, meaning every 24 hours you want for the hourly job to line up with your daily job, since the dependencies are checked based on the execution_date

Many thanks @mistercrunch - your description doesn't exactly match what I saw, but it might well have been pilot error on my part. I'll give it another try and get back to you either way...

I was trying this schedule_interval example and cannot get it to work with the current pypi version (1.0.1) and github version. If I pass in the schedule_interval to DAG it applies it, but as part of the default args it is not used.

Current pypi is 1.3.1 I believe, but schedule_interval is a DAG only param for now, I could add heterogenous schedule_interval support easily but I need to put some safeguards on it first:
Related: https://github.com/airbnb/airflow/issues/221

I can't remember exactly but I think I was providing it to DAG, just that it only works if given explicitly, not as a default args. Or are the default args not for the DAG?

default_args is really just for operators constructor calls. Maybe it should be called task_default_args
It's useful there because people typically create many tasks and tasks share a lot of parameters.
I clarified the docs yesterday around schedule_interval. I'd make schedule_interval a required arg for DAG, but I don't want to break existing DAGs...


New package: TheQucsTeam.Qucs-S version 2.0.0

What's changed

Resolve #118572
Related https://github.com/ra3xdh/qucs_s/issues/306

Checks

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Exception during executable launch operation System.AggregateException: One or more errors occurred. (The specified executable is not a valid application for this OS platform.)  ---


Fix Darwin build for cmigemo and skk-dict

Motivation for this change
Fixes incorrect path to the iconv command.
ZHF: #144627
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

nixpkgs-review happy, macos 10.15

Result of nixpkgs-review pr 146521 run on x86_64-darwin 1

4 packages failed to build:

python38Packages.cmigemo
python38Packages.percol
python39Packages.cmigemo
python39Packages.percol

2 packages built:

cmigemo
skk-dicts

LGTM on macOS 12.0.1


update template to be a const and avoid this dependency when running …

…the service outside of the project repo
I did the go get github.com/google/pullsheet to install the binary in my path and then I run the pullsheet outside of the project repo and got an error:
F0226 16:11:54.215001   26719 pullsheet.go:157] generate failed: parsefiles: open pkg/leaderboard/leaderboard.tmpl: no such file or directory
This PR address this by making a const var to store the template.
Maybe in the future, we can pass it as a flag to a custom template
/assign @tstromberg

Thank you!


Gaps for Windows unable to create properties file.

Describe the bug
Gaps unable to create properties file to save necessary information.
To Reproduce
Steps to reproduce the behavior:

Go to http://localhost:8484/configuration
Input API key or Plex info
Click "Save"
See error
Navigate to another page (missing, libraries, etc.) return to settings and nothing saved

Expected behavior
Expect values for settings to save in properties file.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Gaps Version 0.9.10

Tried running CMD as administrator, made no difference.

If you manually create the directory it will save the file.

Tried running CMD as administrator, made no difference.

Did you try setting the jar as administrator? That's the actual executable.

If you manually create the directory it will save the file.

Sorry, manually create which directory? I am having this same issue and running jar as admin etc has not resolved the problem.

If you manually create the directory it will save the file.

Sorry, manually create which directory? I am having this same issue and running jar as admin etc has not resolved the problem.

c:\usr\data\
I cannot remember if i copied the properties file there or it was created.
but once that directory was created manually it was no issues running.

yea based on the application-windows.yaml its using the wrong directory altogether which by default appears to be set to be 'C:\Program Files (x86)\Gaps\data' which i assumed to be malleable.
had i not found this issue i would have never gotten it running as i was running up against the same issue.  I had assumed based on the ability to schedule it to run that a task would be created or some such but it appears you have to leave the command window open in perpetuity if you want it to work?
useful for sure, just cumbersome at current imo.

not sure if this was the answer but i set this up yesterday and downloaded the latest v 17 java.. 8 was installed anyway but couldn't use it. then downloaded 11 separately and then seemed to work

are you saying you were able to change the location of where it saved its data?  was that using the .yaml if so?  That's supposed to be stored alongside the .jar?
because i have the java SDK 11.x installed (alongside the java 8) and the only way i've been able to get it to work is by manually creating a data folder in c:\usr\data

What I did and not sure what worked was.. Ensure i was using Java 11 (as i had the latest 17)
create the usr etc folders in c:\ and J:\ . I had the program in J: on my server. I created a blank properties file.
the Yaml file didn't seem to make any difference as was pointing to the correct folder on J:
it then worked.
As an added extra I used NSSM to set a service so that it starts if I reboot the server.

Manually creating C:\usr\data\gaps.properties solved this for me.


i can't install with angular 16 i get this error

Run this command: npm install @geometricpanda/angular-tilt --save
i get this error:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/rxjs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>|| ^7.4.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/common
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@geometricpanda/angular-tilt
npm ERR!       @geometricpanda/angular-tilt@"*" from the root project
npm ERR!   1 more (@angular/core)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@geometricpanda/angular-tilt
npm ERR!   @geometricpanda/angular-tilt@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Ah sorry about this, I'll get onto it this weekend

I've updated everything now to have Angular 17 support, hope that works for you :)


SubstreamReader should drain on disposal

SubstreamReader may leaves bytes unread from the underlying stream even after the entire user-content of the substream has been read, leaving the original stream in a state where it will read unexpected bytes.
This should be protected against by ensuring that Substream disposal 'fast forwards' the substream. An async method should allow for this as well.

In the meantime the workaround is simply for caller of the substream to read till the stream is over explicitly.

It just doesn't seem right for Dispose or DisposeAsync to read more from the underlying stream. What if it's being disposed because the client doesn't want any more data at all?


Add derivePathType to CMSIS-SVD schema

I'm a little nervous to be even more different from the official CMSIS-SVD schema, is this necessary to validate some genuine SVD files?

I'm a little nervous to be even more different from the official CMSIS-SVD schema, is this necessary to validate some genuine SVD files?

This blocks us from using full qualified derivedFrom pathes. Like PER.REG.FIELD, etc. It is valid SVD, but not supported by schema. I don't know why. Maybe it was not updated a long time because svdconv is recommended way for check now.


Update goversion

@kubernetes/sig-scalability-pr-reviews - anyone have a second to look at this?

I'm fine with that assuming it works :)


Adding known issue for Load More button issues

Learn Build status updates of commit e0dd65e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/active-directory/reports-monitoring/reports-faq.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 9bf4e58:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/active-directory/reports-monitoring/reports-faq.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@shlipsey3
Thanks for approving the PR. For future PRs, please note that a #sign-off comment is the best way to signal to the review team that a PR is ready to merge.
Merging now.

@court72 - Thanks for the heads up!


ssd inference bug

In SSD inference, the anchor and step-size (width, height) is changed by the original image size, which is Contrary to full convolution idea. In caffe-ssd, the anchor and step-size are fixed, which is the right disign.

This issue was discussed in https://github.com/zhreshold/mxnet-ssd/issues/156
It's "parent" repository to code in examples.

TL;DR; author wanted to leave as it is for backward compatibility

Thank for you reply.
In python vision, I can fix the input size of inference equal to the input size of training by using "self.mod.bind(data_shapes=[('data', (batch_size, 3, data_shape, data_shape))])", which can generate the result close to truth.
But in c++ version,  I only use "simple_bind" function to generate the executor, the shape of executor.data is the shape of input image.
OK, my English is poor, I hope you can understand it, thanks!

In C++ you can provide NDArray with specific shape as part of args parameter. But you need to create this array beforehand.

@sandeep-krishnamurthy label - "Bug", "Example"

Thanks for opening the issue @ElegantGod
As discussed offline with @zhreshold the symbol implementation has been likely deprecated and the team has switched to Gluon CV implementation some time back. We have decided to keep the code as it is to retain the backward compatibility.
@sandeep-krishnamurthy could you close this issue? @ElegantGod please feel free to re-open by commenting for further questions.

@zhreshold, @kalyc can you mark the code deprecated and provide a link to the Gluon CV SSD Implementation to help users.


Return statement gets parsed together with subsequent comments

Input:

Result:

Would the correct syntax be?
@return {Array} an array of container annotations

When I fix the return statement it gets parsed correctly. The ATTENTION block gets hidden which is also quite fine. Will all text that is below the @ statements be ignored?

Regarding syntax: http://usejsdoc.org/tags-returns.html
Regarding parsing: We should not have comments below tags. Tags can have longer content, so it it important to eat more than just a line. Beyond that I don't want to mess with it, as this is implemented in dox.
So: we need to fix our docs.

Make sense. We may want to have comments internally that we don't want to expose.. E.g. TODO:   HACK: etc. How should we approach that?

Either, not putting it into the parsed block.
Or using a custom tag @todo?

Not sure about @hack though ;) Opening a second block with /* */ would work i think...

Second block is not a good idea, as then you loose the context of the first. i.e. the code statement attached to a comment block is the first one after a block.
Depends on what you want to achieve... a custom tag would mean you wanted to show it in the docs potentially.
If you want to just have it in the code, I would rather add a // comment to the implementation body.

No i think we really want to keep that stuff internally and in the code and don't confuse the API user with it. So // in the implementation body it is I would say.. thanks for clearing this up.


Rewrite promise

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
"no"

Deprecations?
no

Related tickets

Documentation

License
MIT

What's in this PR?
Rewrite the Promise class
Why?
Old behavior was never chaining result (see first commit with the test), thus updating the response through decorated or plugin system was never working, neither transforming response to exception (or vice versa)

For me it's on the BC break is only on the Promise which is IMO something internal (i added the flag)

You also made that class final.

Hm right, we can tag 2.0, not really harmless to have directly that, upgrade is easy, but at least we are clear in the contract

If you are confident with these changes, then Im happy to tag 2.0.


Add Devcontainers support

DevContainers support will allow to develop JHipster Lite using GitHub Codespaces, which will allow more contributors to join

Thanks @jdubois !

Already merged? Thanks @pascalgrimaud !


Last PPP update.

Last PPP update. Removed many sections.

Codecov Report

Merging #260 (05b13de) into master (fc347f0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #260   +/-   ##
=========================================
  Coverage     56.33%   56.33%
  Complexity      765      765
=========================================
  Files           161      161
  Lines          3305     3305
  Branches        363      363
=========================================
  Hits           1862     1862
  Misses         1317     1317
  Partials        126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc347f0...05b13de. Read the comment docs.


Identify how to support different deid strategy for each annotation type

Deid strategies common to all annotation types

Replace each character of the annotation by a character defined by the user (current implementation)
Replace annotation content by a tag, e.g. "Thomas Schaffter" => "[ANNOTATION_TYPE]" where ANNOTATION_TYPE is replaced by a different identifier for each type of annotation, for example DATE, PERSON_NAME, etc.

The user of the API should be able to specify the deid strategy for each type of annotation that we support
Task
Propose how we should change the current implementation to meet the above requirements

Using one or more endpoints?
Using query parameter or an object received as payload that contains the parameters?
Format of the input and output

Done in https://github.com/Sage-Bionetworks/nlp-sandbox-schemas/pull/81

This was the proposal that went into the spec


M5StickC Display

Hello,
I have flashed the Stick in your discription with the ESPAltherma SW.
Unfortunately the display shows some strange things..

can anyone help my please?

solved!

Yep, you probably had a M5 C Plus...


Convert to UTC before compare blocktime

Proposal to fix https://github.com/ethersphere/bee/issues/1235.

Checking the tests I realized that time.Unix already return a UTC time. So convert it to UTC again does not make sense and wasn't what solves the problem.
Was only a wrong time setup of the time in my system.

Ok! Thanks anyways for the effort!


Resizing window causes audio pops/crackles

Hello,
I've noticed that when I resize the browser window containing the react-wavesurfer component I hear clicks and crackles during audio playback. I'm guessing it might have to do with how the waveform is trying to redraw itself? Is there a work-around for this?

The playback is being stopped while resizing and the playback state and position is restored afterwards. This is because otherwise the position gets reset to 0 when you resize. I'm afraid this will have to do until resizing is better supported by wavesurfer.js.


Add some form of concurrent Jets.

Should we allow scrambling the order of the results, or not?
How to control the concurrency level?
Perhaps async and stm-chans would be useful to implement this.

Perhaps there could be an unscramble ::  ((a -> IO b) -> Jet a -> Jet b) -> (a -> IO b) -> Jet a -> Jet b function which modified traversals without needing to add more configuration parameters to the traversal itself.

traverseConcurrently has been added, but no unscramble for now.

Leaving unscramble for another issue.


Judge null for key and value in attachment in RpcContextFilter.

Judge null for key and value in attachment in RpcContextFilter.
If not, NullPointerException will be thrown in RpcContextFilter in some case.
issue:
https://github.com/apache/incubator-dubbo/issues/2127#issuecomment-408344327

Hi, do we have a unit test to cover this change?

Sorry to rebase sth wrong into this branch, the new pr with unit test is here:
https://github.com/apache/incubator-dubbo/pull/2171


Electron branch?

I am going to be creating a version of this repo specifically for building Electron apps. Electron is quite heavy so this would be inappropriate for the main branch.
Main changes will be:

Inclusion of Electron dependencies
The addition of a separate build for the Electron main process
Karma tests will run inside Electron
E2E tests will be redone to use Spectron instead of Protractor

The current Angular 2 build process will remain practically unchanged, so it should be easy to maintain those files in sync with this repo.
My question: is AngularClass interested in maintaining this in a separate branch, or should I build it as my own fork? Once it is built, I could definitely use help maintaining it as technology evolves.

We have historically not been very consistent in the maintenance of feature branches and I have always been partial to the approach @mgechev took where major features were maintained in forks with a link to them added to the readme of the base.
Keeps the issues & pull requests focused a bit better imo.

OK, I'll go ahead and make this a complete fork then.

Don't take my opinion as law

https://github.com/katallaxie/angular2-electron-starter

I am also maintaining a starter based on AngularClass's with electron support and at some point NativeScript.
https://github.com/JonnyBGod/angular2-webpack-advance-starter

Thank you very much @JonnyBGod. You've given me some great ideas.
I'm currently working on setting up double watch builds, one for Electron and one for the Renderer. Whenever an Electron dependency is updated it should restart Electron (via electron-connect). And then I will connect the Renderer process to the Hot Module Reloader via a custom server script.
I found a bug in awesome-typescript-loader that causes Webpack to watch every single .ts file in the project, no matter what. So I'm working on getting the main and renderer builds to refresh independently only when their dependencies are updated. (Right now I've resorted to monkey-patching my installation of ATL.)
The other project I am working on is replacing Protractor with Spectron since Protractor doesn't work well with Electron.
Maybe we can work together or at least rip code off each other ;-)

@colinskow Yes I am glad to help with it.
Let me have your repo link and I will keep track of it and help when possible.
You can use my code where you need, no problem at all. Also, if ou would like to implement your improvements in my repo that would be awesome.

I will post it here as soon as I've implemented the basic functionality.

@JonnyBGod it's ready!!!
https://github.com/colinskow/angular-electron-dream-starter

@colinskow Cool that was fast. Will test it soon.
Quick remarks from my very quick look at it:

I think electron.main should be on a dedicated folder in root. This is because you potentially want to extend electron main capabilities and have multiple files for it.

I don't think NGRX fits this starter. That is why I created an advanced starter. NGRX is just too complex for most dev starting with angular.

Would you be willing to implement your electron improvements in my advanced starter?

@JonnyBGod thank you for the feedback.

I created a separate electron folder inside src to place sub-modules for the main process. It felt awkward having them outside of the src tree. Ideally I would use a different folder structure, but I want to keep everything the same so I can easily pull updates from this repo.

Most devs who are just starting with Angular2 should be using Angular-CLI. This repo is really for those of us who aren't satisfied with CLI and are obsessed with customizing the build. Redux/ngrx is the absolute best way to manage state and scaling without it is a headache. I included a very simple implementation (one reducer, one action). It wanted to show how to hook it up to HMR, unit tests, and the Redux DevTools extension since that is tricky.

I just setup several DevTools extensions which will automatically install themselves in development mode.
Feel free to pull what you want from my code. I'm using specialized Electron code, so my fork no longer supports browser builds.


code refactoring

parser.py is still too long.
This entire section of private helper functions would have a better home in confounds.py
https://github.com/SIMEXP/load_confounds/blob/master/load_confounds/parser.py#L21-L97

Fixed, and the compcor code is now in a dedicated section (and more readable).


Implement file path flag for generate-payload

The comments about generate_payload.go apply to the three commands


Was told to report these here by adaway team

I was told by someone on the adaway team that I should report this here.
An app I use called Ifunny has ads that are not being blocked anymore by any adblockers used and someone found a way to block them blocking these links here https://raw.githubusercontent.com/CapedCrusader42/IfunnyAdBlocker/main/IfunnyAdblock
I have tested them and they are confirmed working when adding them in the blocklist in the app blockada.
Can you please add these to the list of blocks so I can again just use privateDNS? Thank you for all you do.

Thank you for this @derpyderpaderp.
Using ghosts to compare, we already carry 40 of the 65 domains in that list.
Therefore we would carry 25 new domains so you can use Ifunny without ads? I don't think so.
Can you narrow that down a little?
For example, no way I'm blocking 2.us.pool.ntp.org. See http://ntp.org/ for more info. This could break the internet for a lot of people.
I'm willing to do something realistic, but not something really dumb 😄
Good?
$ ghosts -c https://raw.githubusercontent.com/CapedCrusader42/IfunnyAdBlocker/main/IfunnyAdblock -unique
----------------------------------------
Base hosts file summary:
----------------------------------------
Location: https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts
Domains: 109,598
Bytes: 3.5 MB
----------------------------------------
Compared hosts file summary:
----------------------------------------
Location: https://raw.githubusercontent.com/CapedCrusader42/IfunnyAdBlocker/main/IfunnyAdblock
Domains: 65
Bytes: 1.4 kB
Intersection: 40 domains
----------------------------------------
Unique in comparison list —  25 domains [
    2.us.pool.ntp.org
    brahe.apptimize.com
    cdn.bidmatrixdsp.com
    crpr.trckswrm.com
    dns.msftncsi.com
    e.reddit.com
    edge-mqtt.facebook.com
    events.ifunny.co
    firebase-settings.crashlytics.com
    firebaselogging-pa.googleapis.com
    in.appcenter.ms
    inapps.appflyer.com
    ipv6.msftconnecttest.com
    logs.ifunny.co
    md-a-c.apptimize.com
    mtalk.google.com
    pagead.googlesyndication.com
    prebid-cache.ifunny.co
    prebid.ifunny.co
    prebids.adnsx.com
    service.cmp.oath.com
    smadex.com
    us-trk.bidmatrixdsp.com
    usnotice.wofdsp.com
    woobids.com
]

I am not the one who made the list and I am not sure how they got these as the host files, I am just taking advice from someone from the adaway github and they told me to report them here to have a broader outreach. I don't even know where to look when it comes to this stuff so I wouldn't know what to narrow down and what could potentially break what.
 Thank you for your time anyways.

@derpyderpaderp it wasn't my intent to make you appear in less than good light. I'm sorry if that's how it came across.
I just need a realistic list of domains to add.  One that doesn't include 2.us.pool.ntp.org for example.
I don't need to include a whole list, just a contracted list of domains that I could add to an existing list.


Implements Magic Wand tool for image segmentation

This pull request implements a Magic Wand, making it possible to click in a region of an image a user is doing segmentation labeling on, drag the mouse to dynamically change flood filling tolerance, then release the mouse button to get a new labeled area. It is particularly effective at labeling broad, diffuse, complex edged objects, such as clouds, cloud shadows, snow, etc. in earth observation applications or organic shapes in biomedical applications.
A short video of the tool in action can be seen here: https://www.youtube.com/watch?v=XxjqBx_0-wk
Detailed notes on its implementation can be seen at the top of src/tools/MagicWand.js.
e2e tests still need to be written, these will be added to this PR once done.

Note that examples/image_magic_wand/annotations/1.json points to a Google Cloud bucket for serving up some example images; before landing this we will want to copy these to your public bucket and change the path. Note that some CORS headers will also have to be set on that bucket in order for the Magic Wand to work from demo images served from it; those changes are documented in the START.md file.

My old code was again label-studio-frontend 1.6.0. I've rebased from ls-release/1.7.0 and updated the magic wand to work against the latest code. I've opened a new PR to clean up history from this git surgery.

Hi @BradNeuberg,
Thank you for your amazing contribution to the project! We're glad to see that you are committed to helping improve and maintain the project.
Please use master branch as a target branch for your PR.

I've created a new PR that cleanly branches from master and has my changes, replacing this one: https://github.com/heartexlabs/label-studio-frontend/pull/1119

Hi @BradNeuberg, Thank you for your amazing contribution to the project! We're glad to see that you are committed to helping improve and maintain the project. Please use master branch as a target branch for your PR.

Thanks; turns out I had to make a new PR to do this cleanly, replacing this one: https://github.com/heartexlabs/label-studio-frontend/pull/1119


:seedling: add ManifestBundle to ManifestBundleStatus as an optional field

Summary
Related issue(s)
Fixes #

/assign @qiujian16


Pause and play on click overlay in mobile

Clicking anywhere on video is not working on mobile. On desktop I can click anywhere on video and it will play and stop no problems. But it is not working in mobile.

Currently experiencing the same behavior. My workaround was to use an overlay on mobile alongside the togglePlay method

In theory should be simple enough to set a  onclick="togglePlay()". I didn't play around with it yet. Wanted to see what developers have to say. Maybe there is an easy fix somewhere in options...


As a user, I want the card image list page updated as soon as I change search terms, filters, or results page so that I can refine my search without losing my place in the form and have results load more quickly.

Notes for testing
If you use the next and previous links or change the pagination drop down, you should see new results without the whole page reloading.

Desktop:

YES, when I click "next" or "previous," the page does a partial reload with that zippy blue bar flashing across to show the updated screen
YES, the zippy blue bar happens again when I use the display dropdown menu to change thru name groupings

Mobile:

YES, I see the zippy blue bar when I press the "next" or "previous" arrows, signifying a partial reload
YES, I see that bar also when I use the display dropdown menu too

Tablet:

YES, the see the blue bar that signals a partial reload when I click the "next" or "previous" buttons, and also when I hit the drop down display


[WIP] Support for controller autoregistration and autowiring

Integrates DunglasActionBundle
Automatically register "actions" as services and enable autowiring

I've updated the Symfony demo application to show the benefits of this new system: symfony/symfony-demo#315
(edited) Features:

In most cases, this is not necessary anymore to declare services (they are automatically constructed by the autowiring system - DX, RAD)
Dependencies are explicit (DX, testability)
The container is not injected in controllers anymore
It's possible (but not mandatory) to create framework agnostic controllers (especially when using the PSR-7 Bridge)
It's possible and recommended (but not mandatory) to use invokable actions (it's not what I've done in my PR on the demo to explicit the upgrade path)
It's 100% BC with the traditional controller system, 0 app will be broken, and people preferring the old way can still use it
It's 100% compatible with @Route and @Template annotations

See symfony/symfony#18193 and symfony/symfony#18193 for the history and the rationale behind this feature.
TODO:

[ ] Merge symfony/symfony#18193
[ ] Merge symfony/symfony#18193
[ ] Merge symfony/symfony#17608
[x] Fix dunglas/DunglasActionBundle#18

/cc @Ener-Getick

I would agree to make Symfony "more friendly" to DunglasActionBundle ... but the following change is a big :-1: from me:

The change may seem "small", but it's a huge change in the way Symfony worked until today. It would require us to make immense changes, such as the documentation and the training materials.

@javiereguiluz the old controller system still works so is it really a problem ?
To satisfy everyone maybe we could include both possibilities in the standard edition: a controller and an action class? WDYT ?

Both changes are optional but: it doesn't prevent controllers wrote "the traditional way" way to work.
You can keep using the Controller directory (but controllers will not be registered as services) and using __invoke (even when controllers are registered as services) is not mandatory (but should be considered a good practice IMO). It's 100% BC.
As the traditional way of writing controllers is still working well, doc can be updated progressively like it has been done for the new directory structure.

I've updated the Symfony demo application to show advantage of this new system: symfony/symfony-demo#315

In most cases, this is not necessary anymore to declare services (they are automatically constructed by the autowiring system - DX, RAD)
Dependencies are explicit (DX, testability)
The container is not injected in controllers anymore
It's possible (but not mandatory) to create framework agnostic controllers (especially when using the PSR-7 Bridge)
It's possible and recommended (but not mandatory) to use invokable actions (it's not what I've done in my PR on the demo to explicit the upgrade path)
It's 100% BC with the traditional controller system, 0 app will be broken, and people preferring the old way can still use it
It's 100% compatible with @Route and @Template annotations

What do you think @javiereguiluz @WouterJ?

Let's say this first: I like the idea behind the action style Symfony way. I think it's a nice way to make decoupling from frameworks and moving to some nicer DDD apps easier (framework agnostic controller will never be possible though imo, but that's another topic).
However, I'm not sure if it should be the default or recommended way. Besides the advantages, it also has some disadvantages. One I can think of now: I have to create one class and one file per controller action. Reducing the amount of files one has to create before having a functional working app was one of the main goals of the best practice guide (which is about the only reason @Route annotations are recommended).
I think while action-style means easier decoupling, using normal controllers is still the RAD-est, easiest way to write your app and I think Symfony Demo and Standard should use it instead. Also, decoupling is needed in about 10% of the apps, for 90% it will only make developers life more difficult. I also believe that controllers shouldn't be unit tested, as controller shouldn't contain logic so there isn't much to test in that unit.
(however, I explicitly voted :confused: instead of :-1: because I'm not very sure about my opinion yet).

Reducing the amount of files one has to create before having a functional working app was one of the main goals of the best practice guide

I'm having trouble to understand here: isn't the best practice guide supposed to give guidelines on best practices? Reducing the amount of files looks like DX for me, it's not about best practices, whereas splitting a controller, at least, promotes SOLID principles (how many principles are we breaking with a single controller?!).
I can perfectly understand the reluctance of making the "Action way" the default in Symfony (although I would love to), but it should at least be promoted as a best practice IMO.

One I can think of now: I have to create one class and one file per controller action.

No, you can use both action-style controllers and have several action methods per class. Take a look at the PR I've opened on the demo: symfony/symfony-demo#315
In term of RAD, not having to declare services in the services.yml file is a big win isn't it?
I'm fully open to discuss the directory structure (the bundle can work both with Controller or Action by default, and both with __invoke and multi-method controllers). I propose the current structure because it (IMO) recommend a clean way to creates controllers/action. But what I really want to get merged is autowired controllers as a services* by default.

In term of RAD, not having to declare services in the services.yml file is a big win isn't it?

The first 17 chapters of the Symfony Book are able to create controllers, forms, entities, tests, ... without even introducing the term "service". There is no need to declare services in Symfony using traditional controllers.

@WouterJ you must introduce a service every time you create business logic. And any small real app has business logic. Services are at the core of the Symfony-way of building apps (and it's basically the main change between Symfony 1 and 2).
A lot of Symfony apps have large controllers with ton of actions and all the business logic in controllers. I hope this proposal will encourage Symfony to keep their controllers as small as possible and to introduce services more frequently (we cannot force people to write good code, but we can encourage them to do it). And btw this PR is vaguely inspired by the ADR pattern but has nothing to do directly with DDD.

According to the Symfony Core Team rules, :-1: votes must be justified by "technical and objective reasons". Here are my reasons to vote :-1::

It deprecates most of the symfony.com documentation and blog posts written about Symfony until today. This will cause confusion in lots of users. It also deprecates most of the existing training materials.
The default controller/action showed to developers imply that you must create 1 file/class per action, which increases "perceived complexity" a lot. (However, you can define several actions per file).
I've always heard that PHP's magic methods (like __invoke()) are slow from a performance point of view (I don't have stats to back this affirmation! Could someone shed light on this?)
For newcomers, the new way to work feels "unnatural". Believe or not, most developers have never used a trait and consider "__invoke()" a PHP "rarity".
It depends on a bundle which hasn't been battle-tested: DunglasActionBundle has 120 stars on GitHub and just 92 installs according to Packagist. I'm sure the code of this bundle is good enough because Kévin is a great developer and knows Symfony well ... but integrating this into Symfony will set a worrying precedent.

And now a subjective reason:

If we adopt such a big change, it must be at least 10 times better than the current situation: the developer must be 10 times more productive or the application 10 times more performant, etc.
But this change just proposes to use "traits" instead of "extends" and "__invoke()" instead of "indexAction()". Where's the benefit in productivity or performance or DX? In the past you made $this->get('slugger') and now you must do use ...\Slugger and create a constructor to get that service. You don't reduce the number of lines to write or the number of concepts to learn.
The main arguments in favor of this change are: 1) you don't have to declare services and 2) controllers are turned into services automatically. However:

In real applications you probably need to create those services after all because they are used in other services, in console commands, etc. not only on controllers.
Most people don't define their controllers as services. I can't see the benefit of it.

We could make 3 things related to this:

Make Symfony capable of using DunglasActionBundle
Integrate DunglasActionBundle in Symfony itself
Integrate DunglasActionBundle and make it the default way to use Symfony

This PR goes for 3)  My vote is for 1).

I'm not a pro in terms of patterns and all these things, I just comment as a regular Symfony user, and I cannot agree more to what @javiereguiluz said:
Making Symfony capable of using Actions system is clearly enough to allow more flexibility and fit to other patterns.
But with my 3-years experience in Symfony 2, I can say that I have never declared controllers as services, and almost always extended Symfony's controller in my own controllers (I can remember only one or two cases, used only for maximal performances).
Refactoring the whole documentation to fit a new design pattern does not sound DX at all to me, because the whole web knows about Symfony's Kernel>Controller>Response system to be a standard and of most common use.
Plus, regarding the recent changes in Symfony's releases schedules, I don't see any benefit to integrate such complex default behavior and make it BC in the next minor releases. The new major releases will come soon enough to avoid having "dirty BC" in most versions, and even if it's personal, I'm afraid that this new design pattern standard would replace Symfony's one, and I don't want to see classic Controllers disappear in a Symfony 5 release for example (ok, it's a bit paranoid, sorry about that).
My "fears" may or may not be reasonable, this is just my comment.
But for all the reasons @javiereguiluz invoked (no ADR pun intended), I'm also :-1: for this :confused:

@javiereguiluz OK got most of your points, I reply below and I've proposed an alternative with emphasis on what I mean is the important part for now: #960

It deprecates most of the symfony.com documentation and blog posts written about Symfony until today. This will cause confusion in lots of users. It also deprecates most of the existing training materials.

It's a very important point. But all examples in doc and training material will still work.
IMO the legacy must not prevent us of moving forward. We need BC, we need an upgrade path (and we have them here), but we need to always improve Symfony.

The default controller/action showed to developers imply that you must create 1 file/class per action, which increases "perceived complexity" a lot. (However, you can define several actions per file).

I don't agree with you on that point. One of the most common problem in Symfony apps is developers putting all the business logic in controllers. On many large projects, controllers are far too big "god objects" and are a nightmare to maintain.
My proposal promote 3 best practices:

extract business logic into services
keep your controllers as small as possible (easier to maintain and to understand for newcomers in the project)
choose carefully your dependency and don't create god objects

But I can understand that some people like you think it's a too big step for now, it's why I opened #960, but IMO it's better to make both "old" controllers and "new" actions cohabit and promote the new one.

I've always heard that PHP's magic methods (like __invoke()) are slow from a performance point of view (I don't have stats to back this affirmation! Could someone shed light on this?)

You got a point, it should be benchmarked. I think it's slower but it's negligible for the number of actions called in a request. Btw, renaming __invoke to invoke or action will still work but I find that less elegant.

For newcomers, the new way to work feels "unnatural". Believe or not, most developers have never used a trait and consider "__invoke()" a PHP "rarity".

Sure, but it's also the mission of Symfony to educate developers to new PHP features and best practices. And the old system still work.

It depends on a bundle which hasn't been battle-tested: DunglasActionBundle has 120 stars on GitHub and just 92 installs according to Packagist. I'm sure the code of this bundle is good enough because Kévin is a great developer and knows Symfony well ... but integrating this into Symfony will set a worrying precedent.

You're 100% right. It's exactly why I want this merged before the feature freeze: to battle-test it. 120 stars in only 2 months is not so bad IMO (it's a sign of interest for this kind of approach by the community). IncenteevParameterHandler has only 260 stars and has been available for years.
But I'm open to any solution to ease the maintenance: add the SF core teams to the maintainers, move it under the symfony namespace, merge it in core...

If we adopt such a big change, it must be at least 10 times better than the current situation: the developer must be 10 times more productive or the application 10 times more performant, etc.

It's not a so big change. Actually, doing that with Symfony worked for years and the bundle is very small. As the old system will still work, even if it's 10% better IMO we should move.

But this change just proposes to use "traits" instead of "extends" and "__invoke()" instead of "indexAction()". Where's the benefit in productivity or performance or DX? In the past you made $this->get('slugger') and now you must do use ...\Slugger and create a constructor to get that service. You don't reduce the number of lines to write or the number of concepts to learn.

Reducing the number of lines is not always the way to go. But here you actually reduce it (no entry in services.yml. It also reduces the number of concept to learn at first (no config file to know with it's own directory structure...). It becomes similar to how Laravel works but with cleaner concepts and extensibility behind.
I've used my bundle on some projects since 2 months and automatic dependency building is very pleasant and time-saver.
Using composition instead of inheritance in such case is also considered universally a best practice.
Easing the migration to framework agnostic controllers is also something that matter in term of code quality and marketing.

In real applications you probably need to create those services after all because they are used in other services, in console commands, etc. not only on controllers.

The bundle supports commands too thanks to @Ener-Getick (see my updated PR on the demo), other services have their their dependency autowired too. It's the main point about this PR. As controllers and  commands are the entrypoint of the service graph, in 70 to 80% of cases (maybe more), you don't need to declare your services explictly anymore!
With my proposal, controllers are indeed services but it's 100% transparent for the end user. The intention is not to promote controllers as services, but to use them to unlock new features and improve code quality.
@Pierstoval

Plus, regarding the recent changes in Symfony's releases schedules, I don't see any benefit to integrate such complex default behavior and make it BC in the next minor releases. The new major releases will come soon enough to avoid having "dirty BC" in most versions, and even if it's personal, I'm afraid that this new design pattern standard would replace Symfony's one, and I don't want to see classic Controllers disappear in a Symfony 5 release for example (ok, it's a bit paranoid, sorry about that).

It's not dirty at all. And I'll be :-1: to remove the traditional controller system in any future Symfony release. It can be useful in a lot of contexts.
Technically both my bundle and the "old" system share the same Symfony internals. I've used the traditional controller system for years and I can't find any argument to remove it. The maintenance will be as complex with or without it.
IMO their is no reason to be afraid of this new proposal replacing the traditional way. Both can cohabit without any problem.

Thanks for your work @dunglas. I definitely dislike this - at least as an initially step. But I am interested in your #960. Whatever we do, it will need to be a way to do things, but not the recommended way to do things initially. We have to give ourselves some time using this stuff to see how it feels before we could roll it out as any type of a recommended practice. Personally, I'm very interested, but not convinced of the whole idea - just because we haven't had enough people coding with it long enough.

Closing in favor of #960


OSClient history contains mixed type messages

Maybe this is an upstream problem, tbd, but call to OSClient following a repair seems to contain a mix of types (strings, dicts, Messages, not sure)

downstream accepts both types


[Content]: iOS Swift and Objective C examples switched

What article on segment.com/docs is affected?
https://segment.com/docs/connections/sources/catalog/libraries/mobile/ios/#disabling-data-collection-for-users-who-opt-out
What part(s) of the article would you like to see updated?
The examples for Swift and Objective C under the 'Disabling Data Collection for Users who opt out' section are switched. See screenshots below.

Additional information
No response

@stayseesong, this should be a relatively quick fix.


Proposal: Replace yaml with toml

as of python 3.11 toml parser is part of standard library.
what does it mean for the project is as follow.

remove third party dependency (PyYAML)
improve readability of configuration reference

current yaml
#########################
# main settings

domain: yourdomain.com
ns1: <IP_ADDRESS>
ns2: <IP_ADDRESS>

#########################
# other configurables

# server address
listen_addr: <IP_ADDRESS>:53

# debug (0 or 1)
debug: 0

# default TTL
ttl: 60

# default latency (in ms)
sleep: 0

# a 3rdparty domain which we don't own
a3rdparty_domain: whatever.com

# known DNS resolvers / clients connecting to us
known_servers:
  <IP_ADDRESS>:      localhost
  <IP_ADDRESS>:        powerdns1
  <IP_ADDRESS>:        powerdns2
  <IP_ADDRESS>:        bind-test1
  <IP_ADDRESS>:        msdns-test1

#########################

will look like with toml
[main]
domain = 'yourdomain.com'
ns1 = '<IP_ADDRESS>'
ns2 = '<IP_ADDRESS>'

# server address
listen_addr = '<IP_ADDRESS>:53'

# debug (0 or 1)
debug = 0

# default TTL
ttl = 60

# default latency (in ms)
sleep = 0

# a 3rdparty domain which we don't own
a3rdparty_domain = 'whatever.com'

known_servers = """
<IP_ADDRESS>   localhost
<IP_ADDRESS>     powerdns1
<IP_ADDRESS>     powerdns2
<IP_ADDRESS>     bind-test1
<IP_ADDRESS>     msdns-test1
"""

just a little caveat this will not work to python 3.10 below. so it will be a good idea to update the readme stating this only works with python 3.11 and above.
PR: https://github.com/oryxlabs/PolarDNS/pull/3

A great idea, thank you @mpdevilleres !


issue #68 - Add Atom Package Manager updates

check if apm is installed + apm upgrade

@stockulus Thanks! I'll merge the PR now.


Use mime-guess to guess mime types for responses

Substitutes #196 dividing it in two commits, one for source and Cargo.toml changes and another for automatic Cargo.lock updates

Thanks!


Auto completion does not work if table name has space Reoccured was fixed in #10858

Description
If the table name contains space, the auto completion does not work.
for example: if the table name is file list then
when we type the query
select * from file list fl where fl.
-- here the autocompletion does not work after the dot
If the table name does not have any spaces, then autocompletion works perfectly.
DBeaver Version
Community Edition 23.0.5
Operating System
Windows 11
Database and driver

Mariadb 10

Steps to reproduce
Create any table in mariadb or mysql with space
Try any query on the table and the autocompletion or suggestion of columns for that table won't work. Please check the gif below.
Autocompletion works perfectly for table tabRole, but doesn't work for table tabHas Role

Additional context
This issue was first reported few years back as #10858 and it was fixed. In the latest build it has reoccurred. Hence copying all the details from previous issue

Hello @NehalDamania
Thanks for the bug report.

This bug has already been fixed here https://github.com/dbeaver/dbeaver/issues/20073
The fix will be available on Monday with release 23.1.0

Thank you so much for the workaround


Remove deprecated functions

Remove deprecated classes and functions marked for removal until May 2017.
This PR doesn't touch deprecated parameters nor deprecations for June 15.

Can one of the admins verify this patch?

Thanks! I really want to accept this, but I cannot (it would save a lot of headache).
I should never have put dates on these, and probably should remove them. We'd be breaking too many people and we won't actually remove these functions, probably until we reorganize contrib as a whole.
I'm sorry about this. I should remove the dates, since they're misleading.


Scheduled jobs not appearing in Resque Web

Scheduled jobs not appearing in Resque Web, and the  URL must be localhost:9292, it can not support to access with computer name or IP address? Can someone help me with this?

Are you using the same host for node resque?  The same database within redis?

Closing due to lack of response


cupy.einsum does not return view

numpy has this feature from 1.10.  This feature is not supported yet, while the name of the internal function calc_single_view contains "view".
To reproduce:
>>> import cupy
>>> a = cupy.arange(6).reshape(2, 3)
>>> cupy.einsum('ij', a)[...] = 1
>>> a
array([[0, 1, 2],
       [3, 4, 5]])
>>> import numpy
>>> a = numpy.arange(6).reshape(2, 3)
>>> numpy.einsum('ij', a)[...] = 1
>>> a
array([[1, 1, 1],
       [1, 1, 1]])

(cupy==5.0.0a1)

I meant a writable view, sorry.