List of Supported Philips Air Purifiers ?

Hi David, would be interested to know if your plug-in supports the Philips Series 1000ai ?  Apologies if you have a list of supported devices somewhere here, I couldn't find it in the code on GitHub or in the Hoobs directory.
Thanks

I don’t believe I’ve heard reports one way or the other of that being tested.

I don’t believe I’ve heard reports one way or the other of that being tested.


Manifest update from V2 to V3 in manifest.json

Hello, recently I noticed that I cannot use the live server chrome extension and upon researching on it I found out that the manifest file is outdated as Manifest V2 was depreciated. I have updated the manifest file with some minor changes(null checks) in the code.

/review

Thank you very much for the pull request! . I have seen the Chrome store's notice, was trying to get some free time to make changes. Anyway, I really appreciate your effort. 🚀
btw did you test your changes?

Keep this PR open as I have some untested commits for storage API. Will test it, make some additional changes(if required) and commit again.

yeah. I'll also test before merging.
few things for your new changes

getConfigFromLocalStorage is now returning promise. So, you've to use .then
storeConfigToLocalStorage should return promise as it's now async
pls don't add unnecessary empty/null check - it's better to crash or throw error than a false function call.  Easy to read, easy to debug later.

Sure. Will make necessary changes and push it. Thanks for your review.

Another feedback. host_permissions needs to be all URLs. The loopback address (localhost) doesn't necessarily need to be localhost...  Another use case is that people can use the network IP (10.0.x.x or 192.168.x.x).

HI @ritwickdey, I have tested the above commits and they are working fine. You check and merge.

Looks good to me 👍🏻

Submitted the changes to Chrome Store. Now "Pending review". Hopefully, it'll be live within a few days.
Thank you so much @karanugale 🚀


Allow clients to send data before headers are received

Is your feature request related to a problem? Please describe.
tonic wraps hyper to provide request/response and bidirectional streaming for GRPC over http/2. When using a bidirectional streaming client, tonic waits until it receives response headers to return control to the client. That means that straight line code like this can hang:
    let mut client = EchoClient::connect("http://<IP_ADDRESS>:50051").await.unwrap();

    let (tx, rx) = tokio::sync::mpsc::channel(10);
    let response = client
        .bidirectional_streaming_echo(tokio_stream::wrappers::ReceiverStream::new(rx))
        .await
        .unwrap();

    for i in 0..10 {
        tx.send(EchoRequest {
            message: format!("msg {:02}", i),
        })
        .await
        .unwrap();
    }

    let mut resp_stream = response.into_inner();
    while let Some(received) = resp_stream.next().await {
        let received = received.unwrap();
        println!("\treceived message: `{}`", received.message);
    }

Internally, the bidirectional_streaming_* call generates a hyper::client::conn::http2::SendRequest and awaits it (see tonic's SendRequest. Waiting on a SendRequest::send_request appears to send headers from the client and block until it has read headers from the server.
In the example above, because the body stream is still pending data, the client sends http/2 headers to the server with no body and waiting for response headers from the server. If the server waits on replying with headers until it receives body data - which GRPC servers in Java, Go, and C++ appear to do - the SendRequest::send_request future will never complete,  control will never return to the caller so no data will be sent, and everything will hang.
Describe alternatives you've considered
h2 exposes an API in SendRequest that returns control as soon as headers have been sent - the second example in the documentation is exactly the behavior that tonic wants to have. In talking with @LucioFranco in Discord it seems like tonic has a few alternative ways to go about getting that kind of behavior:

Expose an h2-style API in hyper, and switch tonic to that API.
Drop down to using h2 directly in tonic clients.
Write code in tonic to get back to this behavior without relying on the transport.

Based on our discussions so far, there's some preference for the first option and we thought we'd start a discussion here.

Thanks for the detailed write-up. I've now been able to read through and understand what you're describing.

Waiting on a SendRequest::send_request appears to send headers from the client and block until it has read headers from the server.

This is actually by design. That is it's purpose. The function returns a Future<Response>. So when you await it, it won't yield the response to the let response = until it has gotten one. Meanwhile, it will be trying to send data from the request body, if the request body yields some data.
What you would need to do here is either join() on that future and a second one sending request data, or spawn the response future and await it later (though you probably still want some sort of join, since you want to know if the server ever says "nope").

Consider a similar problem in a different domain. If you had a std::sync::mpsc channel, and some threads, you could accidentally do the same thing:
let (tx, rx) = std::sync::mpsc::channel(10);

let resp = thread::spawn(move || {
    for msg in rx {
        println!("got: {:?}", msg);
    }

    // return value
    42
}).join();

tx.send(1);
tx.send(2);
// etc

Because of calling join() on the thread, wanting the result, but it won't complete until the channel sends its messages, then it will also hang.

The thread::spawn call doesn't force you to join

It's almost the same in the original example, though. You don't have to await, either. You probably do need the future to be polled, but it can be polled in a separate task, and then awaited later.
Like this:
let (tx, rx) = tokio::sync::mpsc::channel(10);
+ let future = client
- let response = client
    .bidirectional_streaming_echo(tokio_stream::wrappers::ReceiverStream::new(rx));
-   .await
-   .unwrap();
+ let task = tokio::spawn(future);

for i in 0..10 {
    tx.send(EchoRequest {
        message: format!("msg {:02}", i),
    })
    .await
    .unwrap();
}

- let mut resp_stream = response.into_inner();
+ let mut resp_stream = task.await.unwrap().into_inner();
while let Some(received) = resp_stream.next().await {
    let received = received.unwrap();
    println!("\treceived message: `{}`", received.message);
}

You probably do need the future to be polled, but it can be polled in a separate task, and then awaited later.

That definitely works, but it requires a deeper understanding of what's going on. In tonic, that violates expectations to the point that there's a four year old issue full of confused folks looking for HTTP/2 bugs (apologies for not linking that originally!).
Tonic could absolutely do something like that internally for streaming calls. The thought was that h2 already has this API - could we use it directly instead of having to spawn another task?

I just checked, and actually you don't need to spawn the response future. So, really, that API you're mentioning already exists. You can send the request, and then send on some sort of body sender, and then await the response. (One can also spawn it, that's fine too.)

@seanmonstar I think the bigger problem (and I took just a very quick look at poll_response in h2) is that it always waits for headers before returning control to get data frames. How does this work if there are no headers sent by the server and only data frames? Iirc this was one of the core issues with the code in h2 that @blinsay brought up to me.


Add theme customization

Add the option to edit the page to your own touch.
Able to change colors
Able to change background
Able to change font, font-size, icons
Able to add more color and own options.
Example set in config.json as option under-maintenance: yes and it will say under maintenance on the page with a different color

Hi!
First, your issue is just a list of ideas. Each feature should have its own issue.
Colors / Background color
Why not. I've made the design based on CSS custom properties.
For now: fork, edit index.html with your own values, and build your own customized version.
Fonts
Why did you want to change font-family?
I think we can open font used via custom properties too. For now, that's not the case.
Font size
Prefer to use the config zoom option.
Icons
Why did you want to change existing icons? I need more details to understand the need here.
New states
That's not that simple to support "new colors". That's not just colors. It's all about states. So, what's the point of an "under maintenance" state? This is a non-sense to put that in the config.json. If you edit config.json, just add an empty tile as a placeholder... but why just not keep it in red if it's down? Even if you know why it's down: it's down. So the real state of your service is: not working, so that's just red ^^
New options
What are "new options"? Without any detail, it's hard to respond to that.
Maybe you are asking for more tile types, so please be sure to check #253 and #285 and https://github.com/monitoror/monitoror/issues/286#issuecomment-603242364

As you can see, you just drop some lines, but there are a lot of blurry requests in your issue.
When I get more details from you, I will split that into as many issues as the features requested.

Hello,
For colors and background I guess making my own version will work for now.
Same for the font. I didn't know about the font-size with zoom option, sorry for that.
For the icons. IIt is not a important feature, But maybe animated icons. (I just like animated icons.)
New states and new options. I think I didn't read the documentation enough.
There are tiles types that I need already in monitoror. So sorry for my lack on reading the documentation better.
If the customization with colors and background could be implemented in the future would be awesome.
But also it is not a priority if I am able to fork it myself.
The others are not really needed anymore (my lack on reading documentation)
And the icons, mwah. I don't think we would look aat the page 24/7 with our eyes.
Sorry for some misunderstanding, and sorry for my lack on reading the documentation.
Thank youu for your help.

Monitoror is optimized to work on very small CPU/GPU like a Raspberry Pi, without burning it ^^ Adding animated icons is not really a good thing, and it adds noise to a wall which can already be really heavy.
So, I will consider this issue as "Allow theme customization" only :)

To keep thing clean, I've created a more focused issue here: #321


city error functionality done issue no.  #255

@avinash201199 can you review it and merge the pr

Thank you for your contribution :)


Add schema revocations when comparing to spec

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1480
Originally created by @tayloramurphy on 2019-12-17 20:10:43

View 4 previous comments from the original issue on GitLab


Contact

Hey I cannot add you on discord. Please make your friend request by everyone. Need help

sorry for the long wait (personal problem), I opened my dm, if your problem is still present, don't hesitate to dm me :)


a small optimization for sleep

Signed-off-by: xin.li<EMAIL_ADDRESS>Please provide a description of this PR:
A small optimization for sleep

@my-git9: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a741490efc63ccd5adcaa6577ed40383a9945d6c
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio


Working version fro gru and lstm with keras 0.3.2 commit 654404c2ed8d…

Hi, so I just made a minor modification to make it work
with keras 0.3.2 commit 654404c2ed8db47a5361a3bff9126a16507c9c4c

Thank you!!!


Node-to-Node Traffic Unencrypted With Egress Gateway

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Attempting to setup both node-to-node encryption with the egress gateway feature enabled. Idea is to run PodA on Node1 with a CiliumEgressGatewayPolicy CRD that routes all traffic over Node2. The traffic from PodA/Node1 to Node2 should be encrypted. First tried to enable both IPSec & the egress gateway feature with the following:
cilium install --helm-set egressGateway.enabled=true,bpf.masquerade=true,kubeProxyReplacement=strict,l7Proxy=false,ipv4NativeRoutingCIDR=<IP_ADDRESS>/16,encryption.nodeEncryption=true,encryption.type=ipsec,encryption.enabled=true

The installation itself failed with:
msg="unable to initialize Kube proxy replacement options" error="IPSec cannot be used with BPF NodePort."

This appears to be from the bpf.masquerade=true option, but this is required for the egress gateway feature. Then attempted to use Wireguard instead via:
cilium install --helm-set egressGateway.enabled=true,bpf.masquerade=true,kubeProxyReplacement=strict,l7Proxy=false,ipv4NativeRoutingCIDR=<IP_ADDRESS>/16,encryption.nodeEncryption=true,encryption.type=wireguard,encryption.enabled=true

Creates fine and the egress gateway behaves correctly. Using this as the egress policy itself:
kind: CiliumEgressGatewayPolicy
metadata:
  name: egress-test
spec:
  selectors:
    - podSelector:
        matchLabels:
          app: clustershell #Pod restricted to Node1 via label
  destinationCIDRs:
    - <IP_ADDRESS>/0
  egressGateway:
    nodeSelector:
      matchLabels:
        type: egress #Node2 label
    egressIP: "<IP_ADDRESS>" #Node2 private IP

The clustershell app runs on Node1 and a curl http://ip4.me/api/ confirmed that traffic was correctly exiting from Node2. However, the Node1-to-Node2 traffic is not wrapped in Wireguard at all. Running a pcap showed standard UDP traffic with the plaintext HTTP request. Wireguard traffic was present, it just wasn't encapsulating the egress gateway traffic from the clustershell pod. pcap snippet taken via tcpdump running on Node2:

Environment is deployed atop Ubuntu 22.x as AWS EC2 instances. Simple lab environment to prototype this setup.
From everything I've seen & read, I'm guessing that the egress gateway feature just doesn't support node-to-node encryption. However, I'm fairly ignorant to low-level networking and so am struggling to track down the root cause. Thanks in advance for any help.
Cilium Version
$ cilium version
cilium-cli: v0.12.4 compiled with go1.19.1 on linux/amd64
cilium image (default): v1.12.2
cilium image (stable): v1.12.2
cilium image (running): v1.12.2
Kernel Version
$ uname -a
Linux ip-172-31-77-151 5.15.0-1021-aws #25-Ubuntu SMP Fri Sep 23 12:20:42 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Kubernetes Version
$ kubectl version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.3", GitCommit:"434bfd82814af038ad94d62ebe59b133fcb50506", GitTreeState:"clean", BuildDate:"2022-10-12T10:57:26Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.3", GitCommit:"434bfd82814af038ad94d62ebe59b133fcb50506", GitTreeState:"clean", BuildDate:"2022-10-12T10:49:09Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"linux/amd64"}
Sysdump
cilium-sysdump-20221017-170705.zip
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Apologies -- missed this note in the docs:

Traffic between two nodes and traffic between a Cilium-managed pod and a remote node currently won’t be encrypted.

https://docs.cilium.io/en/v1.12/gettingstarted/encryption-wireguard/#limitations
Marking as closed as this isn't a bug, but would appreciate any insights into either enabling both the egress gateway with IPSec or any roadmap plans for node-to-node encryption via Wireguard.


Letsencrypt for Subdomain Multisite

Hi there,
Thanks for EasyEngine it makes me easy to install and running WordPress on Nginx!
There's a question asked by someone about multisite domain
and my problem is however facing the same issue.
Whenever I'm accessing my subdomain, it opens the Nginx Default Page instead of my WordPress subsite.
How to configure Adding LetsEncrypt for Subdomain Multisite with EasyEngine? There is no tutorial or document about it. And why there is no command to install LetsEncrypt on all Multisites?
Thank You

Someone from this thread named Pablo_Wright also asking the same question or having same problem.

same as here: https://github.com/EasyEngine/easyengine/issues/847

This may interest you guys.
http://community.rtcamp.com/t/how-to-add-a-subdomain-or-mapped-domain-to-a-ms-installation-secured-with-lets-encrypt/7082/4


Add honeybadger

done

add honeybadger-js and @honeybadger-io/react dependencies for client-side reporting to honeybadger
add support for HONEYBADGER_API_KEY env var in the necessary places (Config.js, webpack.config.js, Dockerfile, .circleci/config.yml; see https://github.com/LD4P/sinopia_editor#important-docker-image-build-note)
wire honeybadger notifier to Header from redux store, for reporting when logout goes awry
wire honeybadger notifier to a couple of actionCreators (fetchResourceTemplate and fetchLookup)
make RootContainer functional instead of subclassing Component (not strictly necessary, but did it in the course of trying to get things working, so leaving it)
add default honeybadger instance store value, reducer for saving configured HB instance to store, action for invoking said reducer, selector for getting configured honeybadger notifier instance from store

have the store start with a proper, if unconfigured, honeybadger notifier instance

eslint rule for a naming pattern to ignore intentionally unused but declared params (done for RootContainer to preserve consistency with other component declarations, though it doesn't actually use the props param it gets)

WIP/TODO

finish adding honeybadger notify calls in actionCreators and other places that invoke console.error
maybe combine console.error and honeybadger.notify calls into a single function in a logger class?
need to add server-side 'honeybadger' dep for server.js reporting?  see sinopia_exporter and sinopia_indexing_pipeline for example implementations.  see also https://docs.honeybadger.io/lib/node.html
TESTS!

fix old tests.  tests fail and/or hang for me locally.  the seem to hang in circle, and the most recent run as of this comment (https://app.circleci.com/jobs/github/LD4P/sinopia_editor/10614) appears to 500 on circle when you try to display the results.

i think part of the problem is that i'm maybe not initializing the honeybadger notifier value in the redux store that the tests use?

write new tests to show that honeybadger.notify is getting invoked as expected

set honeybadger context info with username when the user logs in, unset when the user logs out.  other info that might provide helpful context?  see https://docs.honeybadger.io/lib/javascript/integration/react.html#sending-additional-context (documentation indicates we can't just send context info along like with the server-side HB notify call?  see the slightly different approach in e.g. https://github.com/LD4P/sinopia_exporter/blob/dfe20987ad42d093177196a50e39e745a13d113f/src/getGroupRDF.js#L45-L51 or https://github.com/LD4P/sinopia_indexing_pipeline/blob/d0d80a823c752eda37263943d18ce67432f6cafc/src/Logger.js#L26-L32)

other tips for continuing work on this
if you go to the sinopia_editor project in our honeybadger account, you can see that errors have been posted from the client from some manual testing that i've done on my laptop.  in particular, there are some uncaught errors that have been reported by the ErrorBoundary element (see first section of https://docs.honeybadger.io/lib/javascript/integration/react.html).  there are also some errors that have been sent via explicit honeybadger.notify calls (some from a contrived button triggered alert i used for proof-of-concept, some from the cognito logout issues we sometimes see, but from within LoginPanel, before i rebased and moved that hb notify call to Header since that's where the logout functionality had moved).
if you want to run for local testing, make sure to include the api key when you start up your editor, e.g. HONEYBADGER_API_KEY=a12bc34d npm run dev-start

fun with heisen-failures:
$ npm run test

><EMAIL_ADDRESS>test /Users/suntzu/software_dev_projects/sinopia_editor
> jest --colors --silent --detectOpenHandles

 PASS  __tests__/GraphBuilder.test.js (6.477s)

...

 FAIL  __tests__/components/load/LoadByRDFForm.test.js (300.535s)
  ● LoadByRDFForm › loads resource from provided N3

    : Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Error:

      66 |   })
      67 |
    > 68 |   it('loads resource from provided N3', async () => {
         |   ^
      69 |     const history = createMemoryHistory()
      70 |     const store = createReduxStore(createInitialState())
      71 |     const { getByText, container, getByLabelText } = renderWithRedux(

      at new Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
      at Suite.it (__tests__/components/load/LoadByRDFForm.test.js:68:3)
      at Object.describe (__tests__/components/load/LoadByRDFForm.test.js:52:1)

  ● LoadByRDFForm › loads resource from provided N3 with base URI

    : Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Error:

      91 |   })
      92 |
    > 93 |   it('loads resource from provided N3 with base URI', async () => {
         |   ^
      94 |     const history = createMemoryHistory()
      95 |     const store = createReduxStore(createInitialState())
      96 |     const { getByText, container, getByLabelText } = renderWithRedux(

      at new Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
      at Suite.it (__tests__/components/load/LoadByRDFForm.test.js:93:3)
      at Object.describe (__tests__/components/load/LoadByRDFForm.test.js:52:1)

  ● LoadByRDFForm › asks user for resource template when not provided

    : Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Error:

      137 |   })
      138 |
    > 139 |   it('asks user for resource template when not provided', async () => {
          |   ^
      140 |     const n3WithRt = `<> <http://id.loc.gov/ontologies/bibframe/mainTitle> "foo"@eng .
      141 |     <> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://id.loc.gov/ontologies/bibframe/Title> .
      142 |     `

      at new Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
      at Suite.it (__tests__/components/load/LoadByRDFForm.test.js:139:3)
      at Object.describe (__tests__/components/load/LoadByRDFForm.test.js:52:1)

after making exactly zero code changes:
$ npm run test __tests__/components/load/LoadByRDFForm.test.js

><EMAIL_ADDRESS>test /Users/suntzu/software_dev_projects/sinopia_editor
> jest --colors --silent --detectOpenHandles "__tests__/components/load/LoadByRDFForm.test.js"

 PASS  __tests__/components/load/LoadByRDFForm.test.js (6.731s)

Test Suites: 1 passed, 1 total
Tests:       4 passed, 4 total
Snapshots:   0 total
Time:        17.364s

😖

superseded by #1953


Daily Update

Hi @nenadzaric @mihailotomic @yousseflahouifi @76creates @mhmdiaa thank you for this workflow, it would be super useful if this repo gets a daily update

@mhmdiaa @nenadzaric

@mhmdiaa @mihailotomic Not getting update from last 2 weeks.


Restrict hotkeys to files using tasks syntax

After installing this plugin, I was unable to use the ctrl+enter hotkey to insert a new line in any editor view. I think this plugin's hotkeys should be limited to files using the tasks syntax if possible.
This would also fix the issue in #10

Had the same issue.
This:
                        {
                                "command": "task.new",
                                "key": "Ctrl+Enter",
                                "mac": "Cmd+Enter",
                                "when": "editorTextFocus"
                        }

essentially the base "Cmd+Enter" shortcut on VSCode as the "when" condition is exactly the same. Please add the language filter to the extensions shortcut.

When I did #21, it fixed the keybindings to restrict  them to only work if the language was set to todo (Tasks in the status bar). I noticed this fix wasn't working anymore - I applied it locally since 21 isn't approved. Removing the language restriction allowed the bindings to work again, and not interfering with other languages. Can anybody confirm? @Sandy081 can you comment if something changed on the backend?

Yep, it broke for me too... i had to disable this extension for now.

So after I posted, something changed because it broke  again! I restarted VSC two times before posing

Broken for me too. VSC 1.17.1 here


Documentation Updated

Issues that this PR fix :
SPARKTA-136 SPARKTA-137 SPARKTA-142

Please put "We" in lower case


Output cutoff at 74 chars per line

OS X
Steps to reproduce
PS /Users/thill/projects/work> Get-Process | Sort-Object -Property CPU -Descending | Select-Object -First 5

Expected behavior
No maximum line length.
Actual behavior
Evidence of lines being cutoff:
Handles  NPM(K)    PM(K)      WS(K)     CPU(s)     Id  SI ProcessName
-------  ------    -----      -----     ------     --  -- -----------
      0       0        0     756156 ...127.183  12881   1 plugin-containe
      0       0        0     738004 ...219.210  12879   1 firefox
      0       0        0     160060 37,618.788  38707   1 Microsoft Remot
      0       0        0      77596  6,914.063  12899   1 iTerm
      0       0        0      19852  2,687.954    313   1 Flux

Environment data
> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.9
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

PowerShell asks the host how wide the display is and does formatting to fit that width.
This is normally what people want when the output is sent to the screen, otherwise tables might look bad.
If your issue is that the truncation happens when writing to a file - then I agree this is something we should fix.

I don't think this is a bug. This is just how Powershell tables work. Similar fields will be truncated on Windows, regardless of the window width. Try Format-Table.
PS> Get-Process | Sort-Object -Property CPU -Descending | Select-Object -First 5 | Format-Table

Handles  NPM(K)    PM(K)      WS(K)     CPU(s)     Id  SI ProcessName
-------  ------    -----      -----     ------     --  -- -----------
      0       0        0    3853192 ...104.693  16063   1 prl_vm_app
      0       0        0     438936 ...179.407    670   1 Google Chrome
      0       0        0      70932 ...150.444    676 676 VTDecoderXPCSer
      0       0        0      92120 ...417.235    675   1 Google Chrome H
      0       0        0      64508 ...452.274   1150   1 Dropbox

PS> Get-Process | Sort-Object -Property CPU -Descending | Select-Object -First 5 | Format-Table -AutoSize

Handles NPM(K) PM(K)   WS(K)        CPU(s)    Id  SI ProcessName
------- ------ -----   -----        ------    --  -- -----------
      0      0     0 3853192 2,445,139.277 16063   1 prl_vm_app
      0      0     0  438936 2,408,189.629   670   1 Google Chrome
      0      0     0   70752 2,233,173.934   676 676 VTDecoderXPCSer
      0      0     0   92120 1,863,433.605   675   1 Google Chrome H
      0      0     0   64508   490,453.083  1150   1 Dropbox

Good point - I didn't look closely at the output.
We've been tweaking the fixed column widths for the Get-Process output.  It might make sense to adjust those some more so there is no truncation in the CPU column.

This is by design. PowerShell like Windows PowerShell uses display XML to guide the formatting ((although the XML is 'inside' the cmdlets rather than a separate XML file as with Windows PowerShell. You can see what PowerShell 7 thinkls:
PSH [C:\Foo]: $f = Get-FormatData -TypeName System.Diagnostics.Process | Select -Expand FormatViewDefinition | Where name -eq 'process' | Select -first 1 | Select -Expand control

PSH [C:\Foo]: $f.headers

Label  Alignment Width
-----  --------- -----
NPM(K)     Right     7
PM(M)      Right     8
WS(M)      Right    10
CPU(s)     Right    10
           Right     7
           Right     3
       Undefined     0

As you can see, the width of the CPU column is 10 characters. And that is what you are seeing - PowerShell attempt to format a BIG number into those 10 characters and fails gracefully. Not what you ideally wanted but it is by design.
The solution would be to update the XML. You can do that in your PowerShell profile (create XML that overrides the system formatting defaults).
I am not sure it's worth changing the default but that is an option worth discussing. The question then is how wide to make it, given that most CPU values are adequately covered by the current implementation.

The question then is how wide to make it, given that most CPU values are adequately covered by the current implementation.

I wonder if that's only the case for Windows though. If large numbers are the norm on Mac (as the OP is running) it's probably worth increasing the size of that column a few.

Changing this default would only help a fairly small number of users. Given that -Autosize works, not sure we'd want to change this default for edge cases.

I don't think we can make this assertion without data to back it up.

Since Format-Table -AutoSize works well I think we can close the issue as Won't fix.
(If even the default format(s) covers 80% of the cases it is a very good result, but I think there is even more positive percentage.)


TODO

Improve namespace (some disaster in name spacing)
Implement third party stuff via interface (write interface for all class)

dropping of as 2.0 will be completely re written


Java is not an acceptable language if host is container app

The container app is written in Java but not an accepted value in azure.yaml.

@weikanglim I assume we can close this issue?

Yes, we have aca template now


swscroll: fix check boxes not behaving

... by more properly rebasing on latest E_showScroller_Q3.js from Espruino.

Yes we talked about that in regards to run+ tracking changes to run. So far we haven't implemented it.

Here is where it was discussed: https://github.com/espruino/BangleApps/commit/625f31c8d44258bd977ce1a757a720e7da5f8ad0

https://github.com/espruino/BangleApps/issues/2847


no-disallowed-properties

This carries on from #554 I've just added a few extra tests and added it to our config as the PR had gone stale/silent.
See #554 for the details.
closes #546
<DCO 1.1 Signed-off-by: Dan Purdy<EMAIL_ADDRESS>

Coverage increased (+0.01%) to 97.182% when pulling fb86cbc4ce7945526f3cc0d94c90ce48a4112c9e on DanPurdy:feature/no-disallowed-properties into 33e8d843546e8e21c187d6085c2fbe16dc226608 on sasstools:develop.

Few small changes and we're good to go :rocket:

Coverage increased (+0.02%) to 97.193% when pulling dc77beaf554c0bcf64b2ad71eadf41f2ed37294c on DanPurdy:feature/no-disallowed-properties into 33e8d843546e8e21c187d6085c2fbe16dc226608 on sasstools:develop.

:shipit:

Coverage increased (+0.01%) to 97.264% when pulling 354ef44ce2285952ff9670c184c4fc35008b4029 on DanPurdy:feature/no-disallowed-properties into b075a34db32eb125f845c3f8a9a111e012a571e7 on sasstools:develop.


update @actions/core to 1.10.0

GitHub is working towards deprecating set-output in favour of a file based approach.  Update the @actions/core dependency to make avail of the new implementation which should hopefully eliminate the deprecation warning.

@seanmiddleditch I've recreated the PR (was originally #16) to rename the branch; I'm unsure if this project is now considered abandoned, but I've renamed the branch to allow others to use that as an alternate source to deal with the deprecation until we can sort out how to get this merged.

There's a few different changes here. I'd somewhat prefer them split out into separate PR, e.g. the verbose flag and any bug fixes.
(Repo isn't fully abandoned; I'm just not a very active maintainer, owning to not being paid to do this and trying to spend more time on non-computer-related hobbies.)

Ah, Thanks @seanmiddleditch! Sorry, I assumed that it was abandoned and starting making more changes. I can certainly split out most of them and send them back here if you are still interested.


Update kernel version on ubuntu 18.04 images

Describe the bug
The kernel in the Ubuntu 18.04 images suffers from a kernel bug that prevents .NET Core from running in a container.
It seems that subsequent updates may have fixed this.
Virtual environments affected

[ ] macOS 10.14
[ ] Ubuntu 16.04 LTS
[X] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
.NET Core containers run correctly
Actual behavior
.NET Core container runs fail with "The FileName property should not be a directory unless UseShellExecute is set"
See https://github.community/t5/GitHub-Actions/Docker-build-failure-on-Ubuntu-18-04-host/m-p/33224#M1423

Also note that another common error for the same bug is
error MSB6004: The specified task executable location "/" is invalid.

depending on the build that is being run. (one is launching the c# compiler, one is launching msbuild worker nodes for parallel builds)

Status from internal thread:
No ETA as of yet, but:

It looks like https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1842382 is the duplicate of the Ubuntu bug that has the most traction
https://bugs.launchpad.net/kernel-sru-workflow/+bug/1846007 is being used as the fix-tracking bug on the Ubuntu side
https://launchpad.net/ubuntu/+source/linux-azure/ tracks the validation/promotion of the kernel. This is supposed to be fixed in 5.0.0-1022, which is currently proposed (still in testing; not recommended for production systems)

@rainersigwald Update with kernel version 5.0.0-1022-azure is rolling out now and should be everywhere by the end of the week.
fyi @kaylangan

This has been deployed for a while now, forgot to update issue


⚠ ClamAV has degraded performance

In d41c5f1, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 450 ms

Resolved: ClamAV performance has improved in 6a930aa.


HHH-11293: Test demonstrating that enhancer dirty tracking doesn't track set collections

https://hibernate.atlassian.net/browse/HHH-11293
Note that this PR is just for failing test demonstrating the problem. It does not contain a fix for the bug.

Superseded by https://github.com/hibernate/hibernate-orm/pull/1665


pull request for e2e test at 02/06/2017 09:45:07

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add wire_explosive_delay

Similar to wire_spawner_delay but for explosives.

Convars aren't discarded after closing the server?

You know what I'd recommend - hook.Run("Explode", player, entity), returns whether the explosive can trigger or not. We make way too many security admin policy decisions in Wiremod that should be left to other addons.

What other addon is going to allow players to control whether or not a player can 'Explode'? This is a simple addition, lets not overcomplicate it.

@AbigailBuccaneer has a point. Let's push this to the security addons

@thegrb93 calling a hook would be fewer lines of code, the entities would have to keep less internal state, and would give greater flexibility to server owners. There's no reason that we should be making server policy decisions in Wiremod, especially when it involves more code for us.

Could you please stop making such useless code reviews? You maybe improve the code's quality, but the rest of 99% wiremod code doesn't have that quality.
And here i can't see any quality improvement. The same thing is already in the prop spawner entity and no server owner complained about flexibility about setting the delay.

I don't think this is an appropriate case for a Prop Protection to control at all... very much feels like a case for a convar which governs the max/min values the tool config's can set. I'm really not sure when a security addon would want conditonally different settings? Admins can explode every 0.25s, but regular users only every 0.75s? Seem's a bit ridiculous to me.
However, I'm not sure what this PR is attempting to limit, as I'd think you'd want to change the ReloadTime of the ent, as that's what affects "time between explosions". I tried making a car that moved via precisely timed explosives the other day, and noticed a math.Max(1, toolsetting) prevented having a reloadtime of < 1 second, which was rather limiting.

Oh yeah I didn't realize normal wire explosives had that. Wire simple explosives don't have it so they can be fired as fast as you want. I'll modify my code accordingly.

Okay, I like that now. :+1:

@suunrider i dont get that argument
You're saying wiremod's code is bad so more bad code doesn't matter?

@thegrb93 @Nebual yeah, limiting an existing slider makes more sense.
However, you're lowering the default limit from 1 to 0.2.
Might wanna rethink that.

unrelated to this PR, but this line looks to me like ignite doesnt work without a delay:
https://github.com/wiremod/wire/pull/1098/files#diff-5892b2d050c5a05abbc4a4738bbe19b6R164

Yeah another pr should be made for that. Also the convar singleplayer issue should be fixed alongside the gmod_wire_spawner since they use the same code. It doesn't really matter though since it's a default anyway.

So should this be merged or not @thegrb93

Yeah it's ready. The issues discussed here also affect wire simple explosive and don't really matter that much imo. This just fixes explosive being fired as frequently as people want (up to max triggers per frame).

One thing I noticed is that you didn't make the convar persist over server restarts. Shouldn't it do that? If you do, you should remove the "game.SinglePlayer()" thing and just set it to 0.2 always.

I just copy pasted from the simple explosive file.

I can change both. Give me a second.


Implement the Get function for aws-backend.

Overall looks good. It would be nice if you limit your changes only in storage/store.go and storage/store_test.go, so I it's not conflicting with some of my changes, thanks.

thanks for reviewing @hanlins could you PTAL? I have changed the PR according to your comments.


parachain-staking draft app

draft in last commit, not finished yet
This is just the first grant app (asking for total $30K usd worth of BTC). After it's done, we can apply for a follow up that includes Nimbus consensus, and hopefully by that time everyone else will be aware of the necessity of such a consensus mechanism on top of aura for mitigating censorship.

I do not have merge permissions for this repo so I think we should merge this and then @crystalin or @dtyoo can make changes before either of them submit (by PRing the base w3f repo). TODO: add BTC address to receive the grant


grafana-deployment.yaml may be has some error

What did you do?
after deployment, i found  in kubernete's pod ,grafana could not share grafana when a container down ,the next container start ,this result cause my grafana data all be emptied. this is terrible.
What did you expect to see?
i want to pod work correctly,so grafana can share grafana.
What did you see instead? Under which circumstances?
Environment

Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.1", GitCommit:"1dc5c66f5dd61da08412a74221ecc79208c2165b", GitTreeState:"clean", BuildDate:"2017-07-14T02:00:46Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.1", GitCommit:"1dc5c66f5dd61da08412a74221ecc79208c2165b", GitTreeState:"clean", BuildDate:"2017-07-14T01:48:01Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

Manifests:

contrib/kube-prometheus/manifests/grafana/grafana-deployment.yaml

Reason:

storage dir miss match:
in your grafana-deployment.yaml  use ` /var/grafana-storage`,but  grafana docker images use `/var/lib/grafana`,

what i do is :

--- a/contrib/kube-prometheus/manifests/grafana/grafana-deployment.yaml
+++ b/contrib/kube-prometheus/manifests/grafana/grafana-deployment.yaml
@@ -29,7 +29,7 @@ spec:
               key: password
         volumeMounts:
         - name: grafana-storage
-          mountPath: /var/grafana-storage
+          mountPath: /var/lib/grafana
         ports:
         - name: web
           containerPort: 3000

which has sloved the problem.

The entire intention here is to run grafana in an ephemeral fashion, if this is not how you want to run grafana, then you are not required to use the manifests provided by this project. We merely share the way we think grafana should be operated. And given that grafana is just a dashboarding solution we felt like it's unnecessary to run a full blown database to run a few dashboards that we could provision on start up.

may be ,you have not understand what i mean,emptyDir
Containers in the pod can all read and write the same files in the emptyDir volume
volumes:
      - name: grafana-storage
        emptyDir: {}

  volumeMounts:
         - name: grafana-storage
-          mountPath: /var/grafana-storage
```

use default config,  if one container down , new one start ,visist  dashboard ,the dashboard data will be emptied.

Maybe I'm missing something, but shouldn't grafana-watcher sync the
dashboards content when you start a new pod?
I have never seen the issue you mention, always using the default manifests
from kube-prometheus.

I'm still not sure I understand your problem @wkjun. Could you try to write up how to reproduce your problem?

As it seems to work for all other users, we'll need a write up of how to reproduce this. I'll close this here, but feel free to re-open if you feel it's necessary :slightly_smiling_face: .


Update README

[ ] Add steps to setup a new ssh key, and copy & paste it into the account's authorised keys.
[ ] Add steps to set up a virtualenv and set environment variables like SECRET_KEY in PA
[ ] Add info about consoles (limit of 2 consoles, how API call does not actually start the process (connecting to it in a browser will do that)

Some important help pages to gather info from:

Integrating a development environment with PythonAnywhere
How to set environment variables for your web apps (for SECRET_KEY etc)
How to use a virtualenv in your web app (to get newer versions of django, flask etc)
Deploying an existing Django project on PythonAnywhere

Closing in favour of #13


Introduce more semantic HTML5 tags

Semantic HTML makes websites a lot more useful, even if it’s not apparent on the first sight.
If no-one beats me to it, I’m very willing to take this one.
More info:

https://www.brucelawson.co.uk/2018/the-practical-value-of-semantic-html/
https://html.spec.whatwg.org/multipage/#toc-microdata

What are you thinking of adding for the microdata? There are a lot of microdata types and subtypes and sub-subtypes. Each of those items take differing sets of properties. Some of required, some of optional, some of required if you want to use Google's Rich Cards, but are marked as optional, some have specific requirements about what you have to show if you use that type and want Google to display it as well (example: if you want to show star reviews, you have to show the rating some place).
Basically, this is not a small thing. It took me a long time just to get some of my posts to show review stars:

Google is very picky about microdata. It also isn't always consistent. I have several articles that I have to go in and manually tell Google certain metadata points because it doesn't detect them - but on another article it will. I haven't found a pattern, and I'd find it really annoying if I was a high volume poster. :)
A Bad Detection

It is a great idea to do this. I'd love to have more microdata on my site and eventually get to real rich cards. But, I wanted to set expectations that this isn't a quick thing. I think it's going to take multiple iterations and is going to involve adding optional elements to posts (ie. for a rich card you have to have an image). It might be a good idea to start by figuring out which of the items/subitems/sub-subitems we want to support and what that will entail for our template(s).
For my reviews, I naively just created a new template type that had the microdata for a review vs. the microdata for a BlogPost or an Article. Adding a template for each type isn't the most sustainable way to handle this in the long run, but it is an option.

I very much agree. If we tackle this, it might make sense to set it up as a longer-term side-project, perhaps even with a separate branch.
As for the scope, I think we can tackle it the following way:

first introduce all obligatory metadata (I think we’re nearly, if not completely, there already)
then add optional metadata that is already collected by default, but isn’t presented (optimally) yet
and finally decide which additional metadata it would make sense to introduce as well

@AWegnerGitHub, I see you’re at least as interested in this as I am and seem to be more up-to-date than I. If we tackle this together, we can probably push it forward at a comfortable pace.
I think this would be a great addition to the theme, as it only adds features without removing or breaking what is already there.

@AWegnerGitHub will you create a PR for this? it would be great to have it implemented in Pelican-Elegant!

This could also be of help: https://github.com/drivet/pelican-indieweb-kit

I have a little bit of free time! I have come back to this and started working on it. However, I have a few things to raise for discussion.
Microdata vs. JSON-LD
In my examples above, I have used microdata to markup my post. The biggest issue I had with this is that it's all in-line. That makes adding data within a post really difficult. As I've investigated this a bit, I found that Google prefers JSON-LD format. Essentially, this adds a <script> tag (or several if you have multiple things to mark up) to your file. I think we should use JSON-LD instead of the microdata due to it's support and since we don't have to worry about inline data tagging this way.
An example that I got to validate looks like this:
{
  "@context": "http://schema.org",
  "@type": "Article",
  "headline": "Articles Count With Every Tag and Category",
  "url": "/articles-count-with-every-tag-and-category",
  "description": "Readers of an article on your site usually look for other articles on the same topic. Categories and tags are a way of showing them related articles. Elegant displays the count of articles that you have written in a category or tag in a non-intrusive manner. Every category and tag …",
  "image": "/images/avatars/talha131.png",
  "mainEntityOfPage": "True",
  "author": {
    "@type": "Person",
    "name": "Talha Mansoor",
    "url": "/images/avatars/talha131.png"
  },
  "publisher":{
    "@type":"Organization",
    "name":"Elegant",
    "url":"",
    "logo":{
        "@type":"ImageObject",
        "url":"https://www.google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png",
        "width":"357",
        "height":"60"
    }
  },
  "datePublished": "2019-06-30 13:26:18+05:00",
  "dateModified": "2019-07-31 15:45:51+05:00"
}
</script>

This is built using a template that looks like this:
{
  "@context": "http://schema.org",
  "@type": "Article",
  "headline": "{{ article.title|striptags }}",
  "url": "{{ SITEURL }}/{{ article.url }}",
  "description": "{{ article.summary|striptags }}",
  "image": "{{ SITEURL }}/images/avatars/talha131.png",
  "mainEntityOfPage": "True",
  "author": {
    "@type": "Person",
    "name": "{{ article.author.name }}",
    "url": "{{ SITEURL }}/images/avatars/talha131.png"
  },
  "publisher":{
    "@type":"Organization",
    "name":"{{ SITENAME|striptags|e }}",
    "url":"{{ SITEURL }}",
    "logo":{
        "@type":"ImageObject",
        "url":"https://www.google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png",
        "width":"357",
        "height":"60"
    }
  },
  "datePublished": "{{ article.date }}",
  "dateModified": "{{ article.modified }}"
}
</script>

Additional Fields
The problem with getting structured data to validate with Google (and I'm assuming we want Google to validate it versus being "technically correct, but not validated"), is that they require some additional pieces of information.
A couple things from the example above:

publisher - This should probably be a setting that users can change. We can default it to the site name though for sanity. Part of a publisher, though, is the requirement of having a logo. Do we have a good default image URL we can use for that?
author - I think I can get everything for the author section to match the blurbs that were implemented last year. In the example above I just have it pointing at the avatar image, but the link to the author's selected URL is probably more appropriate.
A review requires an image.

All of these need to be specified somehow, and I'm thinking they should go in the article metadata.
Templates
I am planning on creating these JSON-LD templates for articles and product reviews, because those are my use cases. However, if someone wants additional ones let me know and I'll get those in the initial release too.
The problem with this, is that we'll need an additional fields in the write up. An example from my existing blog looks like this:
Date: 2016-12-09 22:54
Tags: review, technical, learning
Category: Review
Slug: data-analysis-with-pandas-review
Summary: My review of "Data Analysis with Pandas" on Udemy.
Status: published
Series: Course Reviews
template: review
revieweditem: Data Analysis with Pandas
score: 9.5

The last three items - template, revieweditem and score - are useful for different things. In an item review, you have to explicitly provide the name of what you are reviewing (so I couldn't just use the article title. I also wanted to provide a rating (out of 10), so that I could properly display stars. The template variable is used so that I can determine what to load. It uses the built in Pelican functionality to do this. Then, each template will point to the correct JSON-LD data.

TL;DR:

What types of posts are you writing? I am planning on making structured data templates for an Article (current post type) and a Review (rate a product).
Certain structured data requires different fields. What is the best way to indicate that? Is simply having a documentation page enough with a "We support these types. Each of these requires these fields"?
There are some global defaults that are required to properly validate structured data. These include a site logo, a publisher (do we want this global or per post). Some types require additional fields, such as an image.

My answers
Json is ok and seems easier
About logos, default to pelican-elegant one unless user has specified site
one
About URL default to site URL unless there's author metadata like the used
for articlen undersign
I do usually write posts and sometimes gallery or presentation, listing
what might be required would be ok
Thanks!
Sent from mobile
El jue., 8 ago. 2019 0:52, A Wegner<EMAIL_ADDRESS>escribió:

I have a little bit of free time! I have come back to this and started
working on it. However, I have a few things to raise for discussion.
Microdata vs. JSON-LD
In my examples above, I have used microdata to markup my post. The biggest
issue I had with this is that it's all in-line. That makes adding data
within a post really difficult. As I've investigated this a bit, I
found that Google prefers JSON-LD
https://developers.google.com/search/docs/guides/intro-structured-data#markup-formats-and-placement
format. Essentially, this adds a
This is built using a template that looks like this:
{
"@context": "http://schema.org",
"@type": "Article",
"headline": "{{ article.title|striptags }}",
"url": "{{ SITEURL }}/{{ article.url }}",
"description": "{{ article.summary|striptags }}",
"image": "{{ SITEURL }}/images/avatars/talha131.png",
"mainEntityOfPage": "True",
"author": {
"@type": "Person",

"name": "{{ article.author.name }}",

"url": "{{ SITEURL }}/images/avatars/talha131.png"

},
"publisher":{
"@type":"Organization",

"name":"{{ SITENAME|striptags|e }}",

"url":"{{ SITEURL }}",

"logo":{

    "@type":"ImageObject",

    "url":"https://www.google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png",

    "width":"357",

    "height":"60"

}

},
"datePublished": "{{ article.date }}",
"dateModified": "{{ article.modified }}"
}

Additional Fields
The problem with getting structured data to validate with Google (and I'm
assuming we want Google to validate it versus being "technically correct,
but not validated"), is that they require some additional pieces of
information.
A couple things from the example above:

publisher - This should probably be a setting that users can change.
We can default it to the site name though for sanity. Part of a publisher,
though, is the requirement of having a logo. Do we have a good default
image URL we can use for that?
author - I think I can get everything for the author section to
match the blurbs that were implemented last year. In the example above I
just have it pointing at the avatar image, but the link to the author's
selected URL is probably more appropriate.
A review requires an image.

All of these need to be specified somehow, and I'm thinking they should go
in the article metadata.
Templates
I am planning on creating these JSON-LD templates for articles and product
reviews, because those are my use cases. However, if someone wants
additional ones let me know and I'll get those in the initial release too.
The problem with this, is that we'll need an additional fields in the
write up. An example from my existing blog looks like this:
Date: 2016-12-09 22:54
Tags: review, technical, learning
Category: Review
Slug: data-analysis-with-pandas-review
Summary: My review of "Data Analysis with Pandas" on Udemy.
Status: published
Series: Course Reviews
template: review
revieweditem: Data Analysis with Pandas
score: 9.5
The last three items - template, revieweditem and score - are useful for
different things. In an item review, you have to explicitly provide the
name of what you are reviewing (so I couldn't just use the article title. I
also wanted to provide a rating (out of 10), so that I could properly
display stars. The template variable is used so that I can determine what
to load. It uses the built in Pelican functionality
http://docs.getpelican.com/en/3.6.3/faq.html#how-do-i-assign-custom-templates-on-a-per-page-basis
to do this. Then, each template will point to the correct JSON-LD data.
TL;DR:

What types of posts are you writing? I am planning on making
structured data templates for an Article (current post type) and a Review
(rate a product).
Certain structured data requires different fields. What is the best
way to indicate that? Is simply having a documentation page enough with a
"We support these types. Each of these requires these fields"?
There are some global defaults that are required to properly
validate structured data. These include a site logo, a publisher (do we
want this global or per post). Some types require additional fields, such
as an image.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Pelican-Elegant/elegant/issues/237?email_source=notifications&email_token=AACMJD4F5MNMBTLJPGLBCILQDNGY7A5CNFSM4GLTOGP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3Z5QEI#issuecomment-519297041,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACMJD56HZ2BGXSYMWW426LQDNGY7ANCNFSM4GLTOGPQ
.

Is the logo included in the existing static files anywhere? I'd prefer to point to a local instance of the logo (that way it exists on the same domain as the site) versus pointing at an image on GitHub. I don't know how that impacts SEO, but personally, that's what I'd rather have on my site.

Update:
I've gotten a skeleton built for both a standard post and a review. Both are validating too:

This is how Google sees a product review.

This is how Google sees a standard article. I currently have it classified as a BlogPosting. This is how I've had my microdata classifying posts for about 18 months now. I based that on this webmasters post when trying to determine Article vs. BlogPosting.
I still have plenty to do

[ ] Properly define publisher (probably a config dict). Right now, it's pulling the site name. I'd like this to be configurable because "Ponderings of an Andy" isn't a true organization. You also can't use Person as a valid publisher. It fails validation.
[ ] Properly define author if there is more than 1. We added the ability to have multiple authors. JSON-LD needs to properly respect that. If I can provide a list with a single author, this will be easy. Otherwise, I need to determine if there is a single author or more than one author and adjust the template accordingly.
[ ] Determine what data we want to include for Author. An author is a Person and there is a lot of data we can attach to this. Some of the important ones are probably sameAs with links to provided social media accounts, alternativeName (ie. Andy vs Andrew). It depends on how much a user wants to provide about themselves. This would end up being part of the Authors dictionary, I think.
[ ] Determine how to include featured images. If we want to include images as part of the JSON-LD, which can appear in rich cards, this information would need to be provided as part of the article's metadata, I think. This way you can feature specific images without including all images on the page.
[ ] Add keywords to json-ld. We already have this information in meta tags in the HTML. I just need to add it to the json-ld template (and remove the trailing comma)
[ ] Unify output as much as possible. Right now Publisher is not included in a Review but is in the BlogPosting. I'd love to be able to have a parent json-ld template for posts and specific types add only the information they require.

In short, I still have a way to go.

@AWegnerGitHub great work and thank you for taking up the mantel.
A couple of things

We should keep microdata options. There are people who are against adding it to their site. An example.
Judging from your comments, microdata seems very similar to the open graph. You may want to see this plugin. Perhaps microdata too can be outsourced to a plugin.

Properly define publisher (probably a config dict). Right now, it's pulling the site name. I'd like this to be configurable

Why can't you let the user define in pelicanconf and then pull it from there into your template?

Determine how to include featured images.

Does this help?
https://github.com/Pelican-Elegant/elegant/blob/master/templates/_includes/smo_metadata.html#L16-L17

Microdata is inline in the HTML code. JSON-LD is separate from the HTML, like the plugin you linked. Inlining HTML tags is a pain - and really not something we can do if we want to support a variety of structured data types. JSON-LD will end up being like the smo_metadata template you linked. I was already thinking of adding a metadata flag to enable/disable it. Your article seems to confirm that is a wanted feature.
The smo_metadata template you linked is looking for a featured_image metadata element. Do we have documentation anyway of all of the standard and non-standard article metadata elements we support? That'd be helpful in building this and as a place to document what structured data will require as well.

Do we have documentation anyway of all of the standard and non-standard article metadata elements we support?

https://elegant.oncrashreboot.com/metadata

Inlining HTML tags is a pain - and really not something we can do if we want to support a variety of structured data types.

No doubt. For that, we would need a plugin and set some custom markdown syntax.
JSON-LD is the easiest and straight forward solution.


Prepare 1.8.2

Bump swift version in podspec and version file #167)
Bump fastlane to resolve mini_magic dependency warning #164)
Add simple Sonarqube setup #158)

Decided to do a major bump for Swift 5 after talking to @carol-mohemian.


Errors in webSocketDidDisconnect

Errors on reacability!.when reachable, cannot force unwrap value of non-optional type 'Reachability'.
The line
let reachability = Reachability.reachabilityForInternetConnection()
is giving and error that 'Call can throw, but it is not marked with 'try' and the error is not handled.

Wasn't using latest version


chor: bump dependencies

Signed-off-by: Aman<EMAIL_ADDRESS>Fixes #
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 3 (33.33%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 64.607%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ui/views/ib/builders/ib_webview_builder.dart
0
1
0.0%

lib/ui/views/projects/project_details_view.dart
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.006%

Covered Lines:
4036

Relevant Lines:
6247

💛  - Coveralls

@manjotsidhu please review this. This will fix the current failing CI.

Good work @aman-singh7


Android 5.1.1, {N} 1.7.1, CardView strange

I'm seeing this with the current state of the plugin with those versions?

Yeah, me too, the Material Cards are not elevated and the drop shadow is not seen on v6.0 too. Here's a screenshot:

https://github.com/NativeScript/NativeScript/issues/1899
After 2.0 release I'll look into this. That should resolve the issue unless there are more cases for layering.

Closing this, I created a new app with NS version 2.0 and tns-core-modules @ 2.0.0 and everything looks okay with android 5.1 and 6.0.
If anyone has any issues with the latest platform I'll look into it again but everything should be fine.

Hi @bradmartin, Can I know where to look for the NS 2.0 version of the Card-View plugin. I deployed this app today and it's the same. The card elevation is missing and the buttons are looking different. Thanks for the plugin though.

This was working with 2.0 when I last commented. What runtimes are you using and are you using the latest core-modules in your app? You might need to do a new build and try uninstalling and doing a new install of this plugin npm i nativescript-cardview to make sure the old version isn't cached in your app's node_modules. Also check the package.json dependencies to make sure it's not locked in an older version :) Let me know if you have any other questions. If you do I'll test it again but it should be working fine unless NativeScript changed something with their layouts again in 2.0.1 (the minor patch released last week).

Yes, it's working as a plugin, in fact, I'm a big fan of the FAB and this plugin has just made me like NativeScript even more. A minor comment, can the elevation of the FAB be increased from our side as the shadow effect is barely visible.
What I was referring to here was the Demo app in this Github repo, this is still referring to an older TNS version. I thought this Demo app was also updated to TNS 2.0. No issues, otherwise, Thanks!


Epoch ledger sync in 2.0.0

Changes from #11971, applied to release/2.0.0 branch.
A node built with this code should be able to connect to the extant berkeley network.

!ci-build-me

!ci-build-me

!ci-build-me


Fix for issue #21

This stops the end animation when user scrolls down.

Hi @mamouneyya. Thanks for contribution! It'll be merged in a new release


Add support for cross join

This commit message is misleading, since Presto already supports cross join. How about something like "Optimize execution of cross join"

Addressed most of David's comments. Waiting for @dain to review.

I think we can simplify this dramatically by replacing the design to cross whole pages instead of row by row.  I'm thinking of something like this:
for probePage in probePageStream
   for buildPage in buildPagesList
       outputPages(cross(probePage, buildPage))

crossPage(Page probe, Page build) {
  List<Pages> output;
  for position in probe
     Page probeRow = probe.getSingleValuedPage(position);
     Page probeRun = createRunLengthPage(probeRow, build.positionCount());
     Page outputPage = concatColumns(probeRun, build);
     output(outputPage)

Do you follow?

@joy-yao as part of reviewing this, I did a rebase to current trunk.  Here is the code https://github.com/dain/presto/tree/pr2925

With the new implementation, we don't need the first commit anymore

Thanks Dain! I've modified the commits, please review again.

@dain , Eric has reviewed the predicate pushdown. Please review again. Thank you!

All of my comments were on the first commit.  Can you add the changes as a new commit so it is easier to review, and then we can squash it before merging?

Thanks @dain, I've added two more commits, one to address the refactoring (rename classes and methods), and the other addresses all other comments. Please review.

Looks good.  Remember to squash that final commit.


Added support for use with no_std

This PR does three things:

It makes fn replace_with() & fn replace_with_or_default() available on both stable and nightly Rust with no_std.
It makes fn replace_with_or_abort() available on nightly Rust with no_std via "nightly" feature.
It makes unsafe fn replace_with_or_abort_unchecked() available via "panic_abort" feature.

The latter expects panic = "abort" to be defined in Cargo.toml. Being hidden behind a feature flag it will also be hidden on docs.rs (afaik), which I would consider desirable, actually. It's a "last resort" escape hatch, not an API one would want to get into everybody's hands, without knowing the issues around unwinding.
I chose the unsafe fn …_unchecked() naming pattern, as it's a quite common pattern already.

Thanks for the PR @regexident!
I appreciate your explanation and hiding from the docs of replace_with_or_abort_unchecked. I wouldn't be surprised if replace_with_or_abort optimised equivalently under panic = "abort" in release builds. Have you observed this not to be the case? Or does something else about your use case still require it?
Regardless, the PR looks well thought through so I'm very happy to go ahead and merge and release shortly.

Merged and released.
After my comment I realised you indended replace_with_or_abort_unchecked for stable no_std rather than for performance. That's fine by me. I am looking forward to deprecating and removing it once aborting/trapping is available in stable no_std. Linking relevant issue https://github.com/rust-lang/rfcs/issues/2512 for future reference.


removed encode which creates bytes string

The item.encode(...) call was unnecessarily encoding items and converting them into bytes.
Closes: #142

I'll let @scottdangelo check this


Allow more flexible glob_patterns for images

At the moment (and also after #300) we support globbing images like glob("/some/path/*.png").
Can we also support more flexible patterns like /some/path/*B03*.png?

As a self-reminder, a direct solution may look like the following.
In create_ome_zarr.py, we use glob three times, see slightly-modified code below:
    # ...
    ext_glob_pattern = Path(input_paths[0]).name   # This could be e.g. "*.png"
    # ...
    for in_path in input_paths:
        input_filename_iter = in_path.parent.glob(ext_glob_pattern)
    # ...
    for plate in plates:
        # ...
        plate_image_iter = glob(f"{in_path}/{plate_prefix}_{ext_glob_pattern}")
        # ...
        for well in wells:
            well_image_iter = glob(f"{in_path}/{plate_prefix}_{well}{ext_glob_pattern}")

If we now set, for instance, ext_glob_pattern="*B04*.png", the first glob will still work, but the other two will fail. The most direct solution is to have a double-pattern glob function, that produces two lists of filenames matching pattern1= f"{in_path}/{plate_prefix}_{ext_glob_pattern}" and pattern2="f{str(in_path)/ext_glob_pattern}", and then takes their intersection.
A quick check can tell us the time it takes for this double-globbing on the largest dataset in https://github.com/fractal-analytics-platform/fractal/issues/213, but my first guess is that this would take a negligible amount of time.
Note that we are already using glob.glob, in the second and third calls (namely the ones that would be updated), meaning that we are already returning the full list (and not an generator, like pathlib.Path.glob does in the first call; we would need glob.iglob for that). This means that performance should not be any problem, because we would just call the same function twice and then call set.intersection.

A quick check can tell us the time it takes for this double-globbing on the largest dataset in fractal-analytics-platform/fractal#213, but my first guess is that this would take a negligible amount of time.

TL;DR There are no performance issues for double-globbing, when looking at a folder with 163512 files.

Timings:
Found 163512 images matching "*.png", in 0.403 seconds
Examples:
    20200812-CardiomyocyteDifferentiation14-Cycle1_D05_T0001F070L01A02Z07C03.png
    20200812-CardiomyocyteDifferentiation14-Cycle1_E06_T0001F059L01A01Z28C01.png
    20200812-CardiomyocyteDifferentiation14-Cycle1_B05_T0001F051L01A02Z11C03.png

Found 6264 images matching "*_D09_*", in 0.249 seconds
Examples:
    20200812-CardiomyocyteDifferentiation14-Cycle1_D09_T0001F064L01A01Z20C02.png
    20200812-CardiomyocyteDifferentiation14-Cycle1_D09_T0001F062L01A01Z19C01.png
    20200812-CardiomyocyteDifferentiation14-Cycle1_D09_T0001F018L01A02Z24C03.png

Found 6264 images matching both "*.png" and "*_D09_*", in 0.690 seconds
Examples:
    20200812-CardiomyocyteDifferentiation14-Cycle1_D09_T0001F011L01A02Z13C03.png
    20200812-CardiomyocyteDifferentiation14-Cycle1_D09_T0001F005L01A02Z29C03.png
    20200812-CardiomyocyteDifferentiation14-Cycle1_D09_T0001F012L01A02Z13C03.png

Script
import glob
import os
import time

folder = "/data/active/jluethi/20200810-CardiomyocyteDifferentiation14/Cycle1/images_renamed"
extension = "png"
pattern = "*_D09_*"

t0 = time.perf_counter()
all_images = glob.glob(f"{folder}/*.{extension}")
t1 = time.perf_counter()
print(f"Found {len(all_images)} images matching \"*.{extension}\", in {t1 - t0:.3f} seconds")
print("Examples:")
for ind in [0, 1, 2]:
    fname = os.path.basename(all_images[ind])
    print(f"    {fname}")
print()

t0 = time.perf_counter()
all_images_D09 = glob.glob(f"{folder}/{pattern}")
t1 = time.perf_counter()
print(f"Found {len(all_images_D09)} images matching \"{pattern}\", in {t1 - t0:.3f} seconds")
print("Examples:")
for ind in [0, 1, 2]:
    fname = os.path.basename(all_images_D09[ind])
    print(f"    {fname}")
print()

t0 = time.perf_counter()
all_images = glob.glob(f"{folder}/*.{extension}")
all_images_D09 = glob.glob(f"{folder}/{pattern}")
intersection = tuple(set(all_images).intersection(all_images_D09))
t1 = time.perf_counter()
print(f"Found {len(intersection)} images matching both \"*.{extension}\" and \"{pattern}\", in {t1 - t0:.3f} seconds")
print("Examples:")
for ind in [0, 1, 2]:
    fname = os.path.basename(intersection[ind])
    print(f"    {fname}")
print()

The last comment somehow calls for a straightforward implementation with two arguments:

image file extension (required, defaulting to tif)
glob_pattern (optional, will be used for additional filtering)

Let's check it after #300

As discussed at the call today, this double parameter, double glob approach sounds great! :)


Feature Request / Issue

VSCode Version:Latest
OS Version:win 8.1

This might be issue or feature request
i changed the integrated terminal  from cmd to cmder but when we open it  opens in separate window is it vscode problem (If problem please make it that it should be open within editor ) or cmder problem

cmder is a full-blown terminal emulator application which wraps a shell like cmd. VS Code's integrated terminal is also a terminal emulator so it can't run cmder inside it.

@Tyriar i didnt got what u mean...??

You can't run cmder inside vscode as its just a Windows application like vscode is. Cmd or powershell however are design to be talked to by "terminal emulators".

Since cmder can be intergrated with Atom through the plugin 'platformio-atom-ide-terminal', there is no reason to say that vscode can not run with cmder inside.
Inspired from Atom Editor + Cmder,  we can also be able to use cmder inside vscode.
Create a file name runCmder.cmd in the dictinoary of cmder (or somewhere else, may add it to the PATH environment variable) , and put some commands as below:
@echo off
SET CMDER_ROOT=C:\the\path\to\cmder
"%CMDER_ROOT%\vendor\init.bat"

init.bat may be init.cmd in some versions of cmder.
Then open the integrated terminal in vscode, and run the command runCmder.cmd. We can see cmder is running inside vscode.

The last question is, is there any setting in whcih we can define the command we need to run after the integrated terminal started? It seems that the setting terminal.integrated.shellArgs.windows does not work well for this.

This is not "cmder" technically though, it's the shell that runs within cmder. I am interested in trying this out though and seeing how it compares with the version of bash that ships with Git.

Just got it working and it seems the main issue with git bash is still present; the on screen prompt gets out of sync with the actual prompt input.
One amendment I'd make to your instructions @emengjzs is to not bother adding the PATH and instead pointing to the file directly:
"terminal.integrated.shellArgs.windows": [
  "/k", "C:\\Users\\<your user>\\Documents\\runCmder.cmd"
],


Responsive offcanvas placement

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Allow one offcanvas component to have different placements based on the screen dimensions.
Solution
Introduce a set of offcanvas-placement classes including breakpoints:
.offcanvas-{breakpoint}-{position}, so that one offcanvas would have a different placement based on the current viewport size.
Demo
For example, a <div class="offcanvas offcanvas-bottom offcanvas-md-end"> would be displayed at the bottom on small devices, and to the right as soon as the viewport's size would be medium.
Solution in a smartphone screen:

Same offcanvas in a laptop screen:

Motivation and context
In current Bootstrap 5.3, the available placements of offcanvas are sub-optimal in some screen sizes, in the sense that:

.offcanvas-end covers completely the underneath content in a mobile screen layout, whereas .offcanvas-bottom would leave part of it visible.
.offcanvas-bottom cuts too much vertical content in a laptop's landscape layout - compared to what would be left visible with .offcanvas-end.

Current .offcanvas-end on a smartphone screen:

Current .offcanvas-bottom on a mid-size laptop screen:

if we can blur the background of offcanvas placement then it would be more eyecatching.

The content inside the offcanvas will call for scrolling in it on smaller screens, using overlay with scrolling is poor web design


BUG: to_parquet("s3_url") gives PermissionError: [Errno 13] Permission denied: 's3:'

Modin version checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest released version of Modin.

[X] I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example
import ray
import modin.pandas as pd

ray.init()

df = pd.read_parquet(path="s3://ursa-labs-taxi-data/2018/01/data.parquet")
df.to_parquet("s3://.../test_modin/")

Issue Description
See traceback. This is running in a AWWS Glue for Ray job.
Expected Behavior
No error :-)
Error Logs

2023-03-29 09:20:04,948 - __main__ - INFO -   File "<stdin>", line 24, in <module>
  File "/tmp/ray/session_2023-03-29_09-18-58_953203_1663/runtime_resources/pip/7d468961c1567515ede4b0e6db24f0e9f2cdc489/virtualenv/lib/python3.9/site-packages/modin/logging/logger_decorator.py", line 128, in run_and_log
    return obj(*args, **kwargs)
  File "/tmp/ray/session_2023-03-29_09-18-58_953203_1663/runtime_resources/pip/7d468961c1567515ede4b0e6db24f0e9f2cdc489/virtualenv/lib/python3.9/site-packages/modin/pandas/dataframe.py", line 2351, in to_parquet
    return FactoryDispatcher.to_parquet(
  File "/tmp/ray/session_2023-03-29_09-18-58_953203_1663/runtime_resources/pip/7d468961c1567515ede4b0e6db24f0e9f2cdc489/virtualenv/lib/python3.9/site-packages/modin/core/execution/dispatching/factories/dispatcher.py", line 304, in to_parquet
    return cls.get_factory()._to_parquet(*args, **kwargs)
  File "/tmp/ray/session_2023-03-29_09-18-58_953203_1663/runtime_resources/pip/7d468961c1567515ede4b0e6db24f0e9f2cdc489/virtualenv/lib/python3.9/site-packages/modin/core/execution/dispatching/factories/factories.py", line 423, in _to_parquet
    return cls.io_cls.to_parquet(*args, **kwargs)
  File "/tmp/ray/session_2023-03-29_09-18-58_953203_1663/runtime_resources/pip/7d468961c1567515ede4b0e6db24f0e9f2cdc489/virtualenv/lib/python3.9/site-packages/modin/core/execution/ray/implementations/pandas_on_ray/io/io.py", line 285, in to_parquet
    os.makedirs(output_path, exist_ok=True)
  File "/opt/amazon/python3.9-ray/lib/python3.9/os.py", line 215, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/opt/amazon/python3.9-ray/lib/python3.9/os.py", line 215, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/opt/amazon/python3.9-ray/lib/python3.9/os.py", line 225, in makedirs
    mkdir(name, mode)

Installed Versions
Ray version 2.0.0, Modin version 0.19.0, pyarrow 6.0.1, and s3fs 2023.3.0 installed.
Unfortunately pd.show_versions() doesn't return anything.

@kukushking thank you for reporting this. It looks like Modin tries to create a directory at path regardless of where the URL is, and that's completely wrong for s3 URLs. In this case it seems modin is trying to create a directory s3://ursa-labs-taxi-data/2018/01/data.parquet and it creates a directory s3: that it can't write to. For me, if I change my directory to `/tmp/', I get a similar error with
import modin.pandas as pd

df = pd.DataFrame([ list(range(999)) for _ in range(999)], columns=map(str, list(range(999))))
df.to_parquet('s3://redacted-bucket/mvashishtha/new_dir')

in my case, it's OSError: [Errno 30] Read-only file system: 's3:'.
As a workaround, you can do the write from a directory where you can create whatever paths you want, but we should fix this. I'll start working on a fix.
@anmyachev @gshimansky @devin-petersohn @modin-project/modin-contributors @modin-project/modin-core I would like to add a unit test to our CI that can write to s3 so we can test this fix. I think the best way to do that is to add a secret to the github repo and use it in CI, but so far we've only been reading from s3 and we have not been sharing the s3 credentials with  modin project. How should we test writing to s3?

Looks like pandas is using moto for local S3 testing https://github.com/pandas-dev/pandas/blob/32f789fbc5d5a72d9d1ac14935635289eeac9009/pandas/tests/io/conftest.py#L55.
We could try the same way.


Bump wire version

The changes introduced in https://github.com/knurling-rs/defmt/pull/742 add the field crate_name to the wire format. As far as I understand this requires a bump of the defmt version.
Also, is this a reason to yank version 0.3.5? This problem caused me quite some headache today and I hope this spares others from going through the same pain.

Thank you. You are right, this should have happened before the release and I will yank it.
bors r+


Not working for V4.4 on windows

I tried to make a package & installed the latest version 4.4, its trying to fecth some binaries from this url
https://github.com/zeit/pkg-fetch/releases/download/v2.6/uploaded-v2.6-node-v10.15.3-linux-x86
which is returning 404 and exiting process.

For me too, no error message, just exit.
I created binaries on MacOS Mojave 10.14 for Linux,Windows,Macos and only Windows is crashing...
When i created binaries on WIndows 10 x64 for Linux,Windows,Macos, it was working on every system.
This Macos build issue repeated in earlier OS and PKG versions too, so this is not a new problem...

I had the same issue, try to downgrade to V4.3.7 and it works for me

I also came across this issue. It has to do with pkg's attempt to compile your app into binary into the exe instead of leaving it in source format.
Here are some workarounds I've found:

Find a way to build and supply your own version of node, compiled in 32-bit mode. I have no idea how feasible this is.
Build your pkg targeting a 32-bit machine from a windows machine with the 32-bit version of node
Stop distributing a 32-bit version of your package.

Alternatively, if you're comfortable with shipping your source code instead of having it compiled into a binary format, you can disable that feature by passing the following arguments to pkg:
--no-bytecode --public --public-packages '*'


TimePicker has no Title on Android (Light Theme)

Please check all of the platforms you are having the issue on

[] iOS
[X] Android
[] UWP
[] PCL

Please state the issue to the best of your ability below

Android's Time Picker doesn't display a Title in Light Theme.  When using Theme.AppCompat.Light.NoActionBar, the TimePicker Dialog will not display its title, even when explicitly set in TimePromptConfig.  When using Theme.AppCompat.NoActionBar instead, everything is displayed.  Essentially it looks like the title is styled to be white font regardless of the theme, so in Theme.AppCompat.Light, you won't ever see the Title Text.

Please copy and paste the exception details below.  If you are having a crash and this detail is missing, your issue will be closed without warning.

N/A

I'm also seeing an issue where the text for the numbers on the dialog are also far too light for this theme, making it illegible.  I don't believe the TimePickerDialog is usually styled that way by default...

I don't touch theming at all in the dialog library.

Ah, interesting...that's strange, I find it hard to believe by default the "light" theme TimePicker would have white text on white background hmmm I'll have to do more digging on my own thanks


Modals API broken?

powerCord's modal api doesn't seem to be emulated properly. The powercord.modal prop in the powercord global seems to be exposing fields properly, but requiring powercord/modal seems to return different functions.

Cannot reproduce, both open the modal fine.
Closing for now.


toss a lot of redundant mappings

a follow-up to #629

adding suggestions individually because the file tab is huge. sorry


May build the package without browserify?

Hi:
when I use the  glslify in the frontend, I found we must use browserify to transform; I also found browser.js in the dic. Maybe it will be ok that we put builded file in the browser.js , then the users cannot need to use browserify to transform.

You can now use the API directly from node or electron in 6.0.0 so it should be easier to integrate into non-browserify workflows too.

@substack  Thanks, I'll have a try. Hope it would work fine in the pure frontend environment!


spring-boot-starter -> spring-boot-starter-test

dependency:
spring-boot-starter -> spring-boot-starter-test

ConfigControllerIntegrationTest.testQueryPublicConfigWithDataCenterFoundAndNoOverride:234 » HttpClientError

Codecov Report

Merging #2349 into master will decrease coverage by 7.81%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2349      +/-   ##
============================================
- Coverage     57.69%   49.88%   -7.82%
- Complexity     1130     1991     +861
============================================
  Files           196      407     +211
  Lines          5943    12457    +6514
  Branches        636     1278     +642
============================================
+ Hits           3429     6214    +2785
- Misses         2254     5800    +3546
- Partials        260      443     +183

Impacted Files
Coverage Δ
Complexity Δ

...work/apollo/biz/message/DatabaseMessageSender.java
56.25% <0%> (-10.42%)
6% <0%> (-2%)

.../portal/spi/configuration/LdapGroupProperties.java
0% <0%> (ø)
0% <0%> (?)

...ework/apollo/portal/controller/ItemController.java
6.32% <0%> (ø)
1% <0%> (?)

...o/configservice/wrapper/DeferredResultWrapper.java
100% <0%> (ø)
12% <0%> (?)

...omponent/emailbuilder/GrayPublishEmailBuilder.java
11.53% <0%> (ø)
1% <0%> (?)

...k/apollo/portal/controller/FavoriteController.java
33.33% <0%> (ø)
1% <0%> (?)

...apollo/portal/entity/vo/AppRolesAssignedUsers.java
0% <0%> (ø)
0% <0%> (?)

...ponent/emailbuilder/NormalPublishEmailBuilder.java
20% <0%> (ø)
1% <0%> (?)

.../framework/apollo/portal/entity/vo/SystemInfo.java
0% <0%> (ø)
0% <0%> (?)

...rk/apollo/portal/service/NamespaceLockService.java
36.36% <0%> (ø)
1% <0%> (?)

... and 203 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bfed3c...b0357af. Read the comment docs.


Use multilevel task quick pick for Configure and Build

When running Task: Configure Default Build Task, the user can see a very well-categorized list of tasks to choose from:

recently uses tasks
configured tasks
detected tasks

Here are 3 suggestions:

Can VsCode make TaskQuickPick available to extensions? C/C++ Extention would highly benefit from using this feature in showing tasks to users when running "C/C++: Run and Debug Task".

Can the same UI be shown to the user when running Task: Configure Task and Task: Run Build Task? the current list is a mixed list of all tasks and especially if the user is not in the habit of renaming their tasks, the list will become very confusing.

This feature is used in Task: Run Task, but the list of recently used tasks is very long. One recently used task might be enough to avoid confusion.

Can VsCode make TaskQuickPick available to extensions? C/C++ Extention would highly benefit from using this feature in showing tasks to users when running "C/C++: Run and Debug Task".

Extensions can run the command workbench.action.tasks.runTask (this is the "Tasks: Run Task" command).

This feature is used in Task: Run Task, but the list of recently used tasks is very long. One recently used task might be enough to avoid confusion.

This is user configurable with task.quickOpen.history.

Extensions can run the command workbench.action.tasks.runTask (this is the "Tasks: Run Task" command).

@alexr00  There is a class TaskQuickPick which is showing a list of tasks in two groups of defined tasks and configured tasks (if I am not mistaken), That is what our extension can use for a specific functionality we are providing, (workbench.action.tasks.runTask is not what we need).

@elahehrashedi doesn't your extension already know which tasks it provides though? Since your extension already knows the tasks it provides you should be able to show your own quick pick with just your tasks if that's what you want.

@alexr00 the extension has a list of configured tasks and detected tasks, we can show them using a quickpick, however, the list won't be divided into two groups, as it is in "Tasks: Run Task". Is there another way for the extension to create that UI?

@elahehrashedi I see what you mean. There is not a good way for an extension to distinguish between a task that has been configured, recently used, or neither.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Fix PostBuild Task

Executing xbuild requires that the build host has xbuild available during the build otherwise the entire build will fail. This is easily overcome by using the MSBuild Copy Task.
I already have the fix for this and making the API more intuitive:
services.AddBlogifier(databaseOptions, Configuration);
app.UseBlogifier(env);
// instead of
Configuration.InitServices(services, databaseOptions, Configuration);
Configuration.InitApplication(app, env);

I'm happy to submit a PR, just need to know if you want the PR based on Dev or Master

Not a big difference as they in sync right now, but dev would be better.


More minimalist FVGQ kalman

Get rid of the likely troublemakers.  In particular  γy , γΠ, β, κ, ρg, κ

But can start with just a single value

Verify the means from Jesus's paper
Ensure that the priors for all other parameters are centered at those means

Closed by #56


redesigning footer its greatly scattered.

the footer of the application is scattered. i would like to redesign it. kindly assign me this issue under gssoc-ext and hacktoberfest-accpeted.

Hi @vidhi-github! Thanks for opening this issue on Ratna Supermarket. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.


Implement VALUES syntax and operation

This is the original VALUES implementation extracted from #258.
Note: This needs the fix to the galloping join from #269 to function as it easily triggers the broken case for example when using a single value as in the following example query (which only gave one result instead of >7000):
PREFIX wd: <http://www.wikidata.org/entity/>
PREFIX wdt: <http://www.wikidata.org/prop/direct/>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX schema: <http://schema.org/>
PREFIX wikibase: <http://wikiba.se/ontology#>
SELECT ?city ?cityLabel ?citytype WHERE {
  VALUES ?citytype { wd:Q515}
  ?city wdt:P31 ?citytype .
  ?city rdfs:label ?cityLabel .
  FILTER (lang(?cityLabel) = "en") .
}

@floriankramer since I'm now the author of the PR this needs your review approval. This is a bit crazy since you are the author of all the code but well, that's how it is. So yes this looks great to me and we should merge this. Only thing left to do is for me to verify which of the open parsing bugs this fixes.

Tested and reviewed this LGTM


Any plans to opensource?

Hi, I am very interested to try this technology for building our products. Any public/private link to give it a try?
Please provide support<EMAIL_ADDRESS>

It seems the plan to open source didn't work out:

Microsoft plans to open source the Confidential Consortium Blockchain Framework code in 2018.

https://github.com/Azure/coco-framework/commit/a05fd29fe62cd350a2126bbcad36b400d8be211d#diff-04c6e90faac2675aa89e2176d2eec7d8

Like anything pre-release, they may have decided to go a different direction. It's better to shift to something better than to just keep moving with something that wont work as well. All just speculation though, as I haven't seen anything about the future of Coco either.

Coco has been released as CCF now: https://github.com/Microsoft/CCF


store ipython profile name in RE metadata

Expected Behavior
Wouldn't it be nice if ...
the metadata included the name of the ipython profile
for diagnostic purposes, of course
Current Behavior
doesn't do this
Possible Solution
I've got code
Steps to Reproduce (for bugs)
enhancement
Context
supporting users for when they do not know what went wrong
Your Environment
any

Where to put this single function code?  bluesky.utils?

This code: https://github.com/APS-2BM-MIC/ipython-user2bmb/blob/master/profile_2bmb/startup/60-metadata.py#L8-L27

Yeah, utils seems like the best place for this.

The code below could possibly be a alternative for your request.
from IPython import get_ipython
RE.md['ipython_profile'] = get_ipython().profile  # returns string profile name
The thing is __file__ will make us maintain this for each beamline independently which is not what we want. The method above will be available on document later.
What do you think. @prjemian

+1 attaboy!

Reopening. Will be closed automatically once #1128 is merged.

To re-iterate what @ke-zhang-rd said
from IPython import get_ipython
RE.md['ipython_profile'] = get_ipython().profile

is the solution for how to do this.


FEAT: build static files with npm (sass, concat, minify), remove build step from python, include minified bundle files

this pr removed the build.py and building process of vendored js / css. it is now built statically with npm and the appropriate tools.
minified bundles are now included. also all used library and compiled css are inside /static for enabling debugging without the use of npm.

Codecov Report

Merging #1601 (8eea313) into main (a9bdf24) will decrease coverage by 0.13%.
The diff coverage is 77.77%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1601      +/-   ##
==========================================
- Coverage   46.92%   46.79%   -0.13%
==========================================
  Files          47       47
  Lines        6711     6714       +3
==========================================
- Hits         3149     3142       -7
- Misses       3562     3572      +10

Impacted Files
Coverage Δ

lnbits/helpers.py
55.55% <77.77%> (+2.22%)
:arrow_up:

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat: Migrate from poetry to uv for dependency management and build tooling.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2cf6391) to head (f23ac50).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           71        71
  Branches         7         7
=========================================
  Hits            71        71

Flag
Coverage Δ

unittests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.