Target app doesn't install dependencies from layer

Environment

Operating System: Darwin
Node Version:     v18.18.0
Nuxt Version:     3.8.0
CLI Version:      3.9.1
Nitro Version:    2.7.2
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      extends, build, telemetry, alias, ssr, nitro, ui, routeRules, runtimeConfig, hooks
Runtime Modules:  -
Build Modules:    -

Reproduction
if needed, I can provide access to repo's where this issue occurs
Describe the bug
any (dev)dependencies that are installed in the layer, are not automatically installed in the target app. Result is that you need to manually copy dependencies from the layer's package.json and paste to target app's package.json
if dependencies are not copied, an error is thrown upon running npm i
Additional context
I'm consuming the layer as a npm package from the target app (so not referencing the github repo)
There are some other issues concerning layer dependencies, but I don't think they refer to exactly the same bug:
https://github.com/nuxt/nuxt/issues/23445
https://github.com/nuxt/nuxt/issues/19426
Logs
remihuigen@Remis-MBP voorbereiden % npm i

><EMAIL_ADDRESS>postinstall
> nuxt prepare

 ERROR  Cannot find any nuxt version from /Users/remihuigen/local-projects/clients-onderwijsloket/voorbereiden                                                                                4:46:28 PM

  at loadNuxt (node_modules/@nuxt/kit/dist/index.mjs:2577:11)
  at async Object.run (/Users/remihuigen/.nvm/versions/node/v18.18.0/lib/node_modules/nuxi/dist/chunks/prepare.mjs:58:18)
  at async runCommand$1 (/Users/remihuigen/.nvm/versions/node/v18.18.0/lib/node_modules/nuxi/dist/shared/nuxi.c6444792.mjs:1647:7)
  at async runCommand$1 (/Users/remihuigen/.nvm/versions/node/v18.18.0/lib/node_modules/nuxi/dist/shared/nuxi.c6444792.mjs:1638:11)
  at async runMain$1 (/Users/remihuigen/.nvm/versions/node/v18.18.0/lib/node_modules/nuxi/dist/shared/nuxi.c6444792.mjs:1770:7)

 ERROR  Cannot find any nuxt version from /Users/remihuigen/local-projects/clients-onderwijsloket/voorbereiden                                                                                4:46:28 PM

npm ERR! code 1
npm ERR! path /Users/remihuigen/local-projects/clients-onderwijsloket/voorbereiden
npm ERR! command failed
npm ERR! command sh -c nuxt prepare

npm ERR! A complete log of this run can be found in: /Users/remihuigen/.npm/_logs/2023-11-01T15_46_23_190Z-debug-0.log

Any dependencies you need to be installed should be in the dependencies of the layer rather than devDependencies.

Im using yarn@berry and published my layer to some npm registry. After installing fired postinstall script which throw error:
➤ YN0009: │ @some-package-layer::__archiveUrl=* couldn't be built successfully (exit code 127, logs can be found here: /private/var/folders/y_/zvctb7j10s15_grywfghjttr0000gn/T/xfs-7844c117/build.log)

log file contain:
# Script name: postinstall

command not found: nuxt

package.json of layer has nuxt in dependecies. Whats wrong?

@owl1n we have to duplicate packages from layer in to a target app, otherwise it won't work


feat: kusion support apply CRD and CR at the same time

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.1%) to 74.447%

Files with Coverage Reduction
New Missed Lines
%

pkg/engine/operation/parser/parser.go
3
75.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
4274

Relevant Lines:
5741

💛  - Coveralls


Some .flp files are missing

The Pinkie, Hamiltion, Doxxie, Ankha, FL Chan, Arch, Etc. .flp files are missing

ikr, its really weird.
i think its mainly because bb just isnt in the mood to upload the flps, and saw them as unimportant, but still, its annoying

i really want the doxxie and arch ones

oh and anhka

update: he uploaded the fun flp

Most of the holiday song's are missing.

true

Some of the Holiday songs are missing because they were made by FluffyHairs instead of BBPanzu so he doesn't have access to the project files to upload here.

oh


[POC] Views for OpenSearch

Description
Proof of concept implementation of views feature, persisted in Cluster Metadata, exposing resource information view ResourceRequest for use by downstream authorization systems.
Related Issues

Related https://github.com/opensearch-project/security/issues/3873

This POC is no longer needed, basic implementation has been merged into OpenSearch main

https://github.com/opensearch-project/OpenSearch/pull/11957


Error: Token string should not contain spaces

Describe the bug
When setting the A+ token, a following error may be raised "fi.aalto.cs.apluscourses.model.UnexpectedResponseException: Invalid token header. Token string should not contain spaces.". That is the message sent by A+ server (Django) with non-accepting HTTP response.
To Reproduce
?
Expected behavior
A token without whitespace should be accepted. Leading and trailing whitespace does not cause the error.
Screenshots
?
Environment (please complete the following information):
?
Additional context
This happens consistently with at least one user. It would be helpful if A+ admins could confirm that their token is capable to do API calls.
Additionally, it would be useful if the user facing this issue could report whether or not the following commands prints HTTP/1.1 200 OK as the first line:
curl -I 'https://plus.cs.aalto.fi/api/v2/courses/154/points/me/' -H 'Authorization: Token<PHONE_NUMBER>000000000000000000000000000000'

where<PHONE_NUMBER>000000000000000000000000000000 should be replaced with their token.

could not reproduce

could not reproduce

If the pasted token contains leading/trailing whitespace characters other than space (such as a non-breaking space), they won't be trimmed and this error will occur.

If the pasted token contains leading/trailing whitespace characters other than space (such as a non-breaking space), they won't be trimmed and this error will occur.


alexaApp.pre fail not working as I'd expect

So i want to do a check to see if AccountLinking is setup okay in every pre check and if it's not, return a link card to as the user to setup.
But when I do the following:
res.linkAccount();
       res.say("Looks like you need to link your account. Please open the Alexa app for setup.");
      response.fail("Account not linked");

it fails completely without sending the linkAccount card or saying my message.  If I comment out response.fail it works in that i see my link card and hear my message BUT it goes onto the next step whereas I'd like to return to the user rather than passing them onto the intent.
Is this just something I'm doing wrong?

Without looking at the code I am going to guess it's a bug. We probably clear the response incorrectly in this case. Maybe try to write a test for this first, it should be fairly easy to fix.

@cpup22 Did you have better luck with the latest on HEAD (next 2.4.0 release)? Maybe try to build your scenario is a mocha test here?

I haven't tested again. I switched back from app-server to alexa-app only to try to pass certification.  I changed my code to move back to alexa-app.  I need to rebuilt the server environment again to test.

Am also having the same problem here.
After doing a return response.linkAccount() from pre()
The request still gets passed onto the intent

Please double check that you have the latest version and try to write a test for this, I am pretty sure it works as expected @koyinusa.

hmm.. what i use is
    response.linkAccount();
    throw new Error('Account Not Linked');

then my error handler looks like:
    app.error = (exception, request, response) => {
        const msg = exception.toString();
        if (msg === 'Error: Account Not Linked') {
            response.say('You need to link your account, please open the Alexa app to proceed.');
        } else {
            console.warn('Encountered error: ', msg);
        }
    }

am I doing it wrong?

@dblock I got it working by calling send. So my final working code looks like
response.linkAccount()
return response.say(statement).send()

You can also try this @ericblade. Instead of failing abruptly. You might instead return a statement that tells the user what they need to do, which in this case is to link their account

yeah.. it might make more sense if i threw the error, then responded in the error handler with both actions, instead of doing one of the actions above, then throwing the error, then responding with the other action... when i wrote that, life was insane, and i was barely able to think :-D
OTOH, even calling it an "Error" is kind of misleading, too.  Usually I would treat Errors as more fatal .. but for some reason I decided to use it as a signaling mechanism there...


Rotating Camera rig breaks xy controller teleport

Hello! if i rotate the camerarig then teleport on the controllers / bezier pointer go all of the place. for instance if i rotate it 180 the bezier comes from the bottom of the controller.

This is expected. The camera rig should stay at the right orientation. See this FAQ:
https://youtu.be/WptCSrSBOZo

This would conflict with Touch support, right? Oculus is targeting a forward-facing setup, so the only way a player would be able to work behind them is if the camera rig was turned around (so the player still can face towards cameras but be backwards in the virtual world). SteamVR's goal isn't just Vive support, so I wouldn't want to see fundamentally implemented choices limit what hardware can be supported.

I'm not sure. I only have a Vive so it's really difficult for me to build for anything other than that at the moment.
I'd like to support SteamVR they way they intend for it to work, but without the hardware that may be very difficult.

I don't have Touch either, but I can predict how things will work with them. For my game, 5089, I offer different movement modes. I allow the camera to be turned in some modes because I expect some players (and developers) may target mouse & keyboard or controller support, where they will need to turn with something other than their body. Restricting features to a fixed camera rotation is restricting this toolkit to only 360 degree Vive room scale support, which is a rather limited subset of SteamVR.

I may see if I can compensate for the rotation with the beams. It should be doable I think

Thank you. It should be a case of making everything relative to the camera rig's rotation, and not the absolute rotation of the tracked objects.

Here is a game with a very smart use of grid rotating before teleporting.
At 3:10 -> https://www.kickstarter.com/projects/708582338/dimensional-a-ground-breaking-vr-only-experience/description

@RoccoGD thats a really neat idea I like that a lot!

Fixed with commit 27c07f6da240b4bcec10e1eb7336edbec1ec8d03
Stupidly easy fix! That's what happens when you don't review code you wrote at the start :)
Hopefully this works much better for people now. The camera rig can be rotated to any angle and even in real time it shouldn't affect the beam direction.


Added F for machine filter popup

Resolves feature request #1147

I like it, but please remove the code to close the filter modal. esc already does that.


python310Packages.mailchecker: 5.0.8 -> 5.0.9

Changelog: https://github.com/FGRibreau/mailchecker/blob/v5.0.9/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 228123 run on x86_64-linux 1

4 packages failed to build:

dvc
dvc-with-remotes
dvc-with-remotes.dist
dvc.dist

8 packages built:

python310Packages.mailchecker
python310Packages.mailchecker.dist
python310Packages.python-benedict
python310Packages.python-benedict.dist
python311Packages.mailchecker
python311Packages.mailchecker.dist
python311Packages.python-benedict
python311Packages.python-benedict.dist

dvc is already broken.


Support misaligned card columns/rows in source PDFs through individual offsets

Problem
Some source PDFs have misaligned card columns or rows apparently on some pages.
Solution ideas
Column/row offsets? Kinda ugly, should be advanced settings. However, very low priority as I'd say those are definitely very broken PDFs to begin with. And the question of UX is even more unclear than #6

Don't know if you like this rather to be a separate entry, but this one is close enough:It would also be great to have for separate Backside pdf's to be able to have different cut and stretch settings from the front pdf.


Will all 'editor limitation' issues are closed by 2.4.0?

Will all editor related core/plugin features are 100% compatible with encrypted note if old EncryptedFileContentView.ts is gone?
Please tell me there will be no possible limitation(except bugs), at least for vim keybindings.
Anyway, this is great work. Thank you.

Hi @wirekang ,
2.4.0 uses the same markdown editor as obsidian, except it overrides the load and save methods to do the encryption.
I expect it to work well with all core plugins unless there's some fundamental change to how the load/save flow works in a later obsidian update.
It was a bit of effort getting it to work with the default markdown editor, ideally I'd like to see more people test the 2.4.0 betas and give feedback before I release it.
Thank you for testing.

While trying to find some kind of file IO related bug in 2.4.0, I accidently found a bug that decrypted data is written in disk when "Save current file(Ctrl-S)" is performed multiple times rapidly.
I wrote a simple GO program that reads and prints test.mdenc whenever it changes. Following is the result I bashing Ctrl-S.

package main

import (
	"fmt"
	"log"
	"os"

	"github.com/fsnotify/fsnotify"
)

func onChange() {
	data, err := os.ReadFile("test.mdenc")
	if err != nil {
		panic(err)
	}
	fmt.Println(string(data))
}

func main() {
	w, err := fsnotify.NewWatcher()
	if err != nil {
		panic(err)
	}
	defer w.Close()
	go func() {
		for {
			select {
			case e, ok := <-w.Events:
				if !ok {
					return
				}
				if e.Name == "test.mdenc" {
					onChange()
				}
			case err, ok := <-w.Errors:
				if !ok {
					return
				}
				log.Println("error:", err)
			}
		}
	}()
	err = w.Add(".")
	if err != nil {
		panic(err)
	}
	<-make(chan struct{})
}

2.4.0-beta.2
Windows 11
No extra io related factors (e.g. Google Drive or antivirus)

Awesome find, thanks for testing and reporting @wirekang, I'll look into it.


cell growth mode switching, bipolar to monopolar TPV?

I know we have discussed this many times before, but I can't work out if something has changed
and it is now incorrect, or it was always like this and  I  misremebered
I want to use the term
https://www.ebi.ac.uk/QuickGO/term/GO:0051524
GO:0051524    cell growth mode switching, bipolar to monopolar
(I think this is the term we use for NETO, although it does not have these synonymns.)
I'm also pretty sure that in the past this did not have a parentage to growth (because it isn't to do with  a size increase, its to do with the direction of growth)
Anyway, it now has a parent to "growth" via regulation of cell growth.
@ukemi
@mah11

First, you simply must mean GO:0051523, which does have narrow synonyms for NETO. GO:0051524 is switching in the other direction.
Second, I can't see how these could possibly not be regulation of growth. Neither switch regulates the extent of growth, but both regulate where cell growth happens. Regulation of cell growth itself (GO:0001558) explicitly includes regulation of growth direction as well as extent and rate. The current structure looks correct.
I also don't think it's changed recently - some background in #12645 and #8713.

First, you simply must mean GO:0051523
yes I do

so in GO growth is defined as:
The increase in size or mass of an entire organism, a part of an organism or a cell.
This has nothing to do with an increase in size (it isn't regulating the size increase at all, the growth will happen, but not in the direction usually specified).
So to me, annotating these  to growth just seems really wrong? this is morphology (shape), not size?
Personally I don't think it should include direction. Direction isn't about size. Otherwise we  have no way to  distinguish things which are involved in a size increase?
This always confuses me but I though I understood it at one point....

I still don't get this. I just read the old ticket and I  still think something is odd.
How can this be correct?
GO:0016049    cell growth
Definition (GO:0016049 GONUTS page)
The process in which a cell irreversibly increases in size over time by accretion and biosynthetic production of matter similar to that already present.
regulation of cell growth:
GO:0001558
Any process that modulates the frequency, rate, extent or direction of cell growth.
Surely the regulation definition needs to be the   same as the parent term?
We can't just add direction onto the def can we?

"regulation of cell size" has no relationship to cell growth?
https://www.ebi.ac.uk/QuickGO/term/GO:0008361

I remain satisfied that the reasoning documented in the older tickets is sound, and the current ontology structure in this area is correct.

but the definition of cell growth would need to be updated in this case? to reflect that it includes direction, not only size. It is currently logically inconsistent.

but since directional growth is still growth, I would think there is no inconsistency.....

but since directional growth is still growth, I would think there is no inconsistency.....

No, I still think this is a key issue.
Direction of growth governs cell shape.
Cell shape and cell size are completely separable.
We have 2 choices. I don't know which one is correct.

We either  extend the definition of cell growth to include  "directional growth". To me this seems wrong.

or
2.
We separate "growth" from "direction of growth.
I will try to illustrate with 2 examples.
In S. pombe cell morphology mutants  the cell size (volume) is  not altered.  Fission yeast is usually cylindrical,  but is   directional growth cues are lost, cells can be pear shaped, rounded or spherical (depending on the severity of the phenotype). In these, growth is not affected. The cell size is ~ the same.
In a second example,  normal cells grow from one end (monopolar growth), until New End Take-off (= NETO=bipolar growth). In mutants where NETO   is compromized,  cells grow from only one end. However in these mutants cell size ids NOT affected. Cell size is the same.
These  processes (direction of growth) seem to be more to do with shape (morphology) than size (growth).  This seems to be an issue of semantics. If we define growth as an increase in size (as we currently have, and I should continue, but I could be convinced otherwise), then "direction of growth/growth polarity", despite having "growth" in it's term name is not really "growth" at all.
The reason I think this is that the 2 processes are completely separable (they are controlled by different pathways), although clearly there is  cross talk.
It really is very important because most gene products involved  in cell polarity (shape), have absolutely nothing to do with cell  growth or size). They are independent  (although clearly there is linking between these at some level through  CDK activation).
I don't think I explained that very well ;).
I can ask some experts who work specifically on growth and polarity  who are trying to figure out the connections between the two. It's a pretty active area of research.....

Direction of growth is an attribute of the growth process; it is not separable from growth. Controlling growth direction is therefore a form of regulating growth.
In other words, growth is adding matter. The new matter has to go somewhere. Normal growing cells can control how much new mass they add (regulation of extent of growth), how fast it's added (regulation of growth rate), and where new mass goes (regulation of growth direction).
The text definition of "cell growth" doesn't need to have direction added explicitly, as it correctly says that cell growth is adding matter to get bigger. But it would not be actively incorrect to add a gloss saying that any aspect of the growth process - extent, rate, direction - can be regulated.
The pombe examples show that there should not be any is_a or part_of links between the types of growth regulation (reg of extent, rate, direction are and should remain siblings under regulation of cell growth), but they are all consistent with the logical and biological reality that each type of regulation, well, regulates some aspect of cell growth.
On a tangent: cell morphology can be controlled either by regulating growth direction or without growth (by rearranging existing matter). Yeasts don't really do the latter, but lots of other species do.
tl;dr: I oppose any changes to the current ontology structure in this area.

I agree with @mah11. Changing shape without growth is not growth, but directional growth is still growth.

For me, the key is that growth direction can be regulated independently of regulating growth extent, but both are still ways to regulate growth.

Finally, I get it (again). I think a def gloss would be very, very  useful here (even if I'm the only person on the planet who needs it- it will save you time in the future).
Not to self:
https://www.ebi.ac.uk/QuickGO/term/GO:0061387
regulation of extent of cell growth
is the term I need for "cell growth, size increase"
Phew, that took me a while!

no issue.


Using BERT with custom QA dataset

Hi,
I want to use BERT to train a QA model on a custom SQuAD-like dataset. Ideally, I would like to leverage the learning from the SQuAD dataset, and add fine-tuning on my custom dataset, which has specific vocabulary.
What is the best way to do this?

This might help other dev who want to use BERT for custom QA: https://github.com/cdqa-suite/cdQA


[5.3] Trim white spaces from validation string params

This is useful when by mistake you write (or editor auto formats) validation params like:
'required|unique:users, email, null, id,  business_id,1'
instead of:
'required|unique:users,email,null,id, business_id,1'
Aside that these params will look much clearer with spaces after commas.

I would suggest just writing them the correct way.


Use pre-commit

Add pre-commit hooks
This will ensure that there is standard linting applied to files in
the repository. It assists in avoiding conflicts due to different
contributers' IDEs.

It is recommended that contributers run the following:
`pre-commit install -t pre-push -t pre-commit`

Without this, either I need to disable my IDE's auto-linting/fixing, or keep undoing the fixes it makes before pushing commits. Other contributers will be in a similar situation. Otherwise, their PRs will include syntax changes which distract from reviewing the real behavioural changes.
There are standard formatters for most file formats. Along with stripping trailing whitespace, this cleans up the files without modifying their behaviour in any way.

Codecov Report
Base: 66.13% // Head: 66.13% // No change to project coverage :thumbsup:

Coverage data is based on head (dcf8fbc) compared to base (5af9d01).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   66.13%   66.13%
=======================================
  Files          36       36
  Lines        3800     3800
=======================================
  Hits         2513     2513
  Misses        925      925
  Partials      362      362

Impacted Files
Coverage Δ

auth/auth_sqlite.go
57.21% <ø> (ø)

client/client.go
65.85% <ø> (ø)

client/config.go
73.33% <ø> (ø)

client/options.go
46.87% <ø> (ø)

cmd/access.go
44.03% <ø> (ø)

cmd/app.go
69.56% <ø> (ø)

cmd/config_loader.go
55.17% <ø> (ø)

cmd/publish.go
71.61% <ø> (ø)

cmd/serve.go
59.90% <ø> (ø)

cmd/subscribe.go
29.87% <0.00%> (ø)

... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Soo I'm not a fan of this. Generally yes, but this is a little odd.

I already have linting and gofmt in place for Go.
This formatter changes things that are just a little different, but not necessarily "correct". I believe it would even conflict with gofmt.
The markdown cannot be formatted because it's not standard markdown (which doesn't exist anyway). It's an mkdocs dialect, so if you look closely, you destroyed some of the formatting with this.

Soo I'm not a fan of this. Generally yes, but this is a little odd.

I already have linting and gofmt in place for Go.

pre-commit is the standard way of making sure these things are applied. Being git hooks, they are automatically run each time, helping to ensure what is pushed is good code.

This formatter changes things that are just a little different, but not necessarily "correct". I believe it would even conflict with gofmt.

https://github.com/mvdan/gofumpt is a stricter validator that gofmt, while being backwards-compatible. It auto-fixes any problems, but since you're not a fan, I've removed it.

The markdown cannot be formatted because it's not standard markdown (which doesn't exist anyway). It's an mkdocs dialect, so if you look closely, you destroyed some of the formatting with this.
I've instructed prettier to not modify markdown files.

The other hooks are also valuable. There are many files with trailing whitespace, causing spurious line changes when someone touches a file, for example.

I do recommend reviewing the additional autofixes includes in gofumpt. IMO they improve code readability:
https://github.com/mvdan/gofumpt#added-rules

Thank you for your work. However, I don't think I care much for this, and I'd rather focus my energy elsewhere. I may revisit this later, though.


Issue 160 | Adaptive lint

Summary
When adding a repo, if exists, do not erase the existing .pylintrc by the default one.
Details and comments

[x] Update the python_styles_runner.py configure_repo() call

Closes #160

@IceKhan13 Should do the job :)

@mickahell will this break if repo has no .pylintrc file?

Nop, it gonna have the same behaviour as the .coveragerc, so using the one by default as in the simple_python_repository

Sweet!

Can you merge it for me :) ? I don’t have the right to do it


Miscellaneous

Remove CircleCI configuration
All models inherit from ApplicationRecord
Give the Rubocop dependency a default version

Pull Request Test Coverage Report for Build 83

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
6 unchanged lines in 3 files lost coverage.
Overall coverage increased (+1.3%) to 88.875%

Files with Coverage Reduction
New Missed Lines
%

test/test_password_expired_controller.rb
1
100.0%

lib/devise-security/rails.rb
2
100.0%

test/test_security_question_controller.rb
3
100.0%

Totals

Change from base Build 81:
1.3%

Covered Lines:
695

Relevant Lines:
782

💛  - Coveralls

I removed CircleCI so that check won't finish on this PR.

@natebird any problem with merging this PR?


Create slides and samples for synchronization

Addresses issue #83
https://pr86-dot-gotraining-testing.appspot.com/gocourse-2019-05-melbourne.slide#70

I am planning to close this PR as we've decided to cover channels.

@linuxmonk If this is meant to be closed, could you close it please? It would be nice to get the number of open pull requests down to zero before the course starts today. Thanks.

Closing as per earlier discussions


Clarification on runtime identifiers for OSX Universal binaries

Issue description
This is regarding the documentation page for Runtime Identifiers.
I am building a Nuget package that distributes native libraries for multiple platforms, one of them being MacOS. The libraries are compiled as a universal binary, meaning they support x64 and arm64 simultaneously. How do I best represent this platform using runtime identifiers in Nuget and with dotnet pack? My best guess is to package as /runtimes/osx/native/mylib.dylib, using "osx" without an architecture specifier, since by definition the universal binary should run on all architectures.
If this is true, I would appreciate a specific comment to clarify this in the documentation. Perhaps under "macOS RIDs" could be:

osx-x64 (Minimum OS version is macOS 10.12 Sierra)
osx-arm64
osx (For universal binaries supporting both x64 and arm64)

I have seen one package in the wild (Vosk) which includes a native binary under an "osx-universal" folder, but this seems to be proprietary and not linked to an actual runtime identifier, since osx-universal is not in the RID catalog.
Target framework

[x] .NET Core 8.0

@terrajobst Can you help with this question?

I suppose this documentation page is kind of the wrong area as well, since I'm looking for guidance specifically on Nuget packaging. However, the most relevant page on which paths to use for packaging all refer to runtime identifiers, which in turn leads to the page in question.

@richlander is your guy

I think your reasoning is sound.


More thorough and compact

Nice generator. For acme-commander, some changes were needed. See commit descriptions.

I've read through the changes and they look good. I need to test it with my application next; if that works well then I'll merge this.

This doesn't appear to be quite right yet, at least around the change to the static side of classes / constructors.
Let's take Gtk.Paned as an example. Here's what we have after your changes on the static side of the class:
static name: string
static new (config?: Paned_ConstructProps): Paned
constructor (config?: Paned_ConstructProps)

Here's what used to be there:
export interface Paned_Static {
    name: string
    new (config?: Paned_ConstructProps): Paned
}
export declare class Paned_Static {
    new(orientation: Orientation): Paned
}
export declare var Paned: Paned_Static

Note the difference: the "new(orientation: Orientation)" method. I believe this is correct; see e.g. the docs here: http://devdocs.baznga.org/gtk30~3.22.12/gtk.paned#constructor-new
This seems fixable with your approach, I've just not quite tracked down where this regression was introduced in your changes. As this breaks code, I think this is a blocker for merging this PR.
More generally, do you think moving from interface+var+static => class is worth it? I chose the former carefully; it avoids problems when inheriting (due to explicitly breaking up the instance and static sides of classes; there can be no problems with the static side clashing when inheriting).

Without the move, can't use typings in plain JavaScript, see e859bde description.
Does any actual app depending on ts-for-gjs make use of overloaded new? I can get it back by reverting 582a501 and e476e7b, but that would lose the file size (parsing speed) benefit of inheritance.
Skipping new overloads prevents conflicts that appear because static members are inherited. For example, it allows to extend GObject, which would otherwise have:
static new (config?: Object_ConstructProps): Object

// Breaks idiomatic JS-style inheritance.
static new(object_type: number, names: string[], values: Value[]): Object

Overloading of new is useful in C, less so in JS where construction with object literal props is available:
new Paned({ orientation: Orientation.VERTICAL });

new Paned({
  // ... other props ...
  orientation: Orientation.VERTICAL,
  // ... other props ...
});

Unrelated, fixed non-overloaded constructors in 8f12ae0.

To respond to your earlier question:

Does any actual app depending on ts-for-gjs make use of overloaded new?

The answer to this is "yes." The main user of ts-for-gjs today is an internal app (not yet released, nor open sourced) at my place of work; we open sourced ts-for-gjs as a by product of the development of this. Still, I see that it's largely not needed; using the GJS constructor with props is a nice way of constructing objects.
I think the option makes sense, as I wrote in my earlier comment, so let's go with that. I was about to merge this in, but I think I notice one small thing that isn't quite right.
Picking a random class; I've chosen Gio.Task. Let's look at the constructors/static functions generated both with and without the "-s" option:
With -s:
      static name: string
      static new (config?: Task_ConstructProps): Task
      constructor (config?: Task_ConstructProps)
      static new(source_object: GObject.Object | null, cancellable: Cancellable | null, callback: AsyncReadyCallback | null): Task
      static is_valid(result: AsyncResult, source_object?: GObject.Object | null): boolean
      static report_error(source_object: GObject.Object | null, callback: AsyncReadyCallback | null, source_tag: object, error: GLib.Error): void

Without -s:
      static name: string
      static new (config?: Task_ConstructProps): Task
      constructor (config?: Task_ConstructProps)
      static is_valid(result: AsyncResult, source_object?: GObject.Object | null): boolean
      static report_error(source_object: GObject.Object | null, callback: AsyncReadyCallback | null, source_tag: object, error: GLib.Error): void

And here's what used to happen:
  export interface Task_Static {
      name: string
      new (config?: Task_ConstructProps): Task
  }
  export declare class Task_Static {
      new(source_object: GObject.Object | null, cancellable: Cancellable | null, callback: AsyncReadyCallback | null, callback_data: object): Task
      is_valid(result: AsyncResult, source_object: GObject.Object | null): boolean
      report_error(source_object: GObject.Object | null, callback: AsyncReadyCallback | null, callback_data: object, source_tag: object, error: GLib.Error):   void
  }
  export declare var Task: Task_Static

You're generating the function static new (config?: Task_ConstructProps): Task , which I don't think is correct. Looking with gjs itself:
gjs> let Gio = imports.gi.Gio;
gjs> Gio.Task
function Gio_Task() {
    [native code]
}
gjs> Gio.Task.new
function new(source_object, cancellable, callback) {
        /* proxy for native symbol g_task_new(); */
}
gjs> Gio.Task.new({ })
Error: Too few arguments to function Gio.new expected 3 got 1
gjs> let t = new Gio.Task({})
gjs> let t = new Gio.Task()
gjs> Gio.Task.new()
Error: Too few arguments to function Gio.new expected 3 got 0

This function was generated before in the interface of the static side as the constructor function. Now that we've moved to using the typescript constructor keywork on the class declaration, I don't think we should be generating this anymore.

Okay, -s is gone, files are big again, and Gio.Task now has the following:
    static name: string
    constructor (config?: Task_ConstructProps)
    static new(source_object?: GObject.Object | null, cancellable?: Cancellable | null, callback?: AsyncReadyCallback | null):Task
    static is_valid(result: AsyncResult, source_object?: GObject.Object | null): boolean
    static report_error(source_object: GObject.Object | null, callback: AsyncReadyCallback | null, source_tag: object | null, error: GLib.Error): void

Reducing size of declaration files is not a priority, just thought they could be made compact. If anyone sees how to work around TypeScript inheriting static methods, would be interesting to see.

Thanks. That works and I've merged it.
Yes, Typescript static method inheritance is the cause of our troubles here. It's a shame the definitions end so large due to the repeated code.


ParseAssemblyInfo fails when AssemblyInfo contains duplicate lines

Came across an AssemblyInfo.cs file containing the following:
#if DEBUG
[assembly: AssemblyConfiguration("Debug")]
#else
[assembly: AssemblyConfiguration("Release")]
#endif

This causes ParseAssemblyInfo to fail with 'Error: Sequence contains more than one element'

@IanMercer What would the expected behaviour here be? Parsing assembly info files isn't a compile-time activity but equally it doesn't seem to be a rare use case
@patriksvensson @gep13 I notice the current AssemblyInfoParseResult is a sealed class. I'm thinking we could either:
a) unseal it, then provide an inherited type that used IEnumerable<string> instead of string OR
b) create another type (ConditionalAssemblyInfoParseResult maybe?) that uses IEnumerables and provide an extra alias (ParseConditionalAssemblyInfo for example) to return that type?
The last breaking change to InternalsVisibleTo seems a little less drastic than this one..

@agc93  In the end I moved away from using ParseAssemblyInfo entirely and resorted to using RegEx.
What I really wanted was:

load assembly info
grab certain properties from it
surgically replace properties in it (fix company name, fix copyright, stamp build version number)

On step 2 throwing an exception if they are duplicates or cannot be easily parsed would be fine, but not at step 1. i.e. if I never access the AssemblyConfiguration property, but just want to display the AssemblyVersion in my cake log, that should be no problem.
Step 3 is of course harder as either the entire file (comments and compiler directives too needs to be parsed and then written back out) or it needs to be maintained behind the scenes as a plain string and segments within it need to be replaced using RegEx or similar. Step 3 is also harder as users may want to replace only properties that match some other value (e.g. normalizing all company names from 'Foo Limited', 'Foo Ltd' and just 'Foo' to a consistent 'Foo Ltd.').
So for now I use RegEx instead on a line-by-line basis, e.g.:
string fileVersionPattern = @"AssemblyFileVersion\(""[0-9]+(\.([0-9]+|\*)){1,3}\""\)";
string fileVersionReplacement = "AssemblyFileVersion(\"" + version + "\")";
...
... read the file line by line
line = Regex.Replace(line, fileVersionPattern, fileVersionReplacement);

@IanMercer have you looked at using this alias?  http://cakebuild.net/api/cake.common.solution.project.properties/12081a2d/a89f1f40 We used this approach in Cake before switching to using GitVersion fully.  This would mean that you could create a top level, common, *Info.cs file with the properties that do change from time to time, leaving the other properties in the standard AssemblyInfo.cs file.

@gep13 That link is broken. Also, the website devs should consider not exposing the exceptions to the public.


ACM-3087 not-showing-blocked-subscription

Signed-off-by: John Swanke<EMAIL_ADDRESS>

/cc @fxiang1 @chenz4027
Requested a string change, but Feng and/or Maggie should review the logic.

/lgtm

/unhold


Support Latest Stable Angular version 13

It appears that ngx-monaco-editor expects angular version to be 12.
Please bump up the version.
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/common
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/ngx-monaco-editor
npm ERR!   ngx-monaco-editor@"*" from the root project

+1

It seems to work fine after installed or updated with --force flag

@here I've a new fork with latest angular 14, ngZone upgrade and fixed production missing assets, have a look, works for my company now:
https://www.npmjs.com/package/ngx-monaco-editor-v2


Switching meal screen, submit button below the fold

Usability issue. Just move up the right column into the whitespace above, should fix
Originally created by Jill Dimond at 2016-06-26 14:02, last assigned to Tom Smyth, migrated from redmine-#4695

I'm not sure what this means. Jill, can you clarify?
By Tom Smyth at 2016-09-08 06:08

Status changed from New to Feedback

By Tom Smyth at 2016-09-08 06:08

Priority changed from 2 to 3

By Tom Smyth at 2016-09-08 06:08

Description updated (diff)

Status changed from Feedback to New

By Tom Smyth at 2017-01-26 06:33

Category set to Public Release

By Tom Smyth at 2017-01-26 06:34

Status changed from New to Closed

By Tom Smyth at 2017-01-26 07:56

Version set to 3.0.4

By Tom Smyth at 2017-01-26 19:39


Fix outdated link to buffer article in README.rst

Description

Fix outdated link to buffer article in the README.rst file.
Motivation and Context

The current link is broken and no longer works.
Have you tested this? If so, how?

The slug part of the URL is the same and the article mentions Luigi. So I assume it is the same.

Not sure why some of the ci tests failed. I've triggered them to rerun to see if the issues were transient.


Disabled accordions should not have status

Package name(s)
Core (@salt-ds/core)
Package version(s)
latest
Description
Disabled accordions should not have status, this aligns with the behaviour in Input.
Steps to reproduce
https://codesandbox.io/p/sandbox/disabled-open-accordion-538x9h
Expected behavior
No response
Operating system

[ ] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Browser

[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

Are you a JPMorgan Chase & Co. employee?

[ ] I am an employee of JPMorgan Chase & Co.

Need to document overall approach around readonly, disable and status. Decision seems to be not clear on the design side.


Issue with Smooth Continuum in FastSpecFit

@moustakas @stephjuneau
There are two separate yet related issues that I found with the smooth continuum in FastSpecFit:

Excess continuum subtraction near the Balmer regions "eats" away the broad component. An example spectrum is shown below, where the black is the emission-line spectrum and the grey line indicates the smooth continuum component for the galaxy:

Example TARGETs that are affected in this way:<PHONE_NUMBER>0377403,<PHONE_NUMBER>5725300,<PHONE_NUMBER>7195825. I could only find a handful of such cases.

The smooth continuum subtraction leads to an excess subtraction, leading to an uneven continuum around the emission-lines. There are ~30 sources that I found which are affected by this issue. An example is as follows:

Example TARGETs that are affected in this way:<PHONE_NUMBER>0577649,<PHONE_NUMBER>1109086,<PHONE_NUMBER>6520846,<PHONE_NUMBER>6773787,<PHONE_NUMBER>2741009.

Thanks for the specific examples, @Ragadeepika-Pucha. One quick request for the future: if you could provide not just the targetid, but also the specprod (fuji vs iron vs jura) and the survey, program, and healpix, then I'll much more easily be able to find the exact spectra you're working with.
The long-standing issues with the "smooth continuum" algorithm together with the line-fitting speed-ups facilitated by @jdbuhler, inspired me to build a brand new algorithm:
In essence, I now carry out an emission-line modeling step before continuum-fitting which considers both a narrow and broad+narrow line-model. A small subset of major lines are fit in "patches" (but with line-widths and line-centers still constrained across patches, using reasonable, physical assumptions), and the local continuum is taken to be a simple line. A conservative decision is then made about how much to mask all the lines, but particularly the broad Balmer lines.
Here's one of the optional QA figures from the first object in your list, iron/main/dark/9196/39633010890377403:

You can see that the initial fit of the Halpha+[NII] complex is quite good, which leads to the following line-mask (orange=emisison-line pixels; blue=local continuum pixels):

The final fit looks quite excellent, IMHO:

Comparing our respective fits to the H-alpha region, I find sigma=1558 km/s (FWHM=3670 km/s) for broad H-alpha (vs your FWHM=5475 km/s) and sigma=165 km/s (vs your 189 km/s estimate).

Some quick thoughts:

A velocity width as large as yours seems excluded pretty strongly by the data. Are you taking into account the resolution matrix?
Interestingly, your broad H-alpha line appears to be quite redshifted, centered nearly on [NII] 6584; what velocity shift do you find? By contrast, I find a blueshift of nearly 800 km/s.

Looking forward to hearing your thoughts and, in the meantime, I'll continue testing out the new algorithm.

Hi @moustakas , it seems that the screenshot from Raga's post was for TARGETID=39633105035725300 (and not the first number she listed) as it resembles this iron version from the prospect link.

I note that the other two TARGETIDs<PHONE_NUMBER>0377403,<PHONE_NUMBER>7195825) including the one you fit above have very clear double-peaked narrow lines. Fitting them as a single component might slightly affect the BL fit but probably not too strongly because the BL components are quite prominent.

Here's my updated fit for main/bright/9894/39633105035725300. I get a line-width of 3753 km/s, or FWHM=8838 km/s, a factor of 1.6 larger than what @Ragadeepika-Pucha reports.
Note that fitting multiple components to different lines (e.g., Halpha) is outside the scope of the current code, but functionality that I'm thinking of adding longer-term.

Hi @moustakas @stephjuneau - I am sorry for the delay in getting back to you. I rechecked the fits from both guadalupe and iron, with and without smooth continuum correction from the existing FastSpecFit catalogs. Before running EmFit, I subtract the FastSpecFit continuum from the spectra. I am using v3.1 catalog for Guadalupe and v2.1 catalog for Iron.
TARGETID:<PHONE_NUMBER>0377403
{iron|guadalupe}/main/dark/9196/39633010890377403
This is the first case that you showed with detailed patches and masked pixels.
In this case, the guadalupe and iron results are similar.

Including smooth continuum gives an FWHM (broad Ha) ~ 1930 km/s and sigma (narrow Ha) ~ 170 km/s

Not including smooth continuum gives an FWHM (broad Ha) ~ 3850 km/s and sigma (narrow Ha) ~ 160 km/s

This is similar to the FastSpecFit new estimates!

TARGETID:<PHONE_NUMBER>5725300
{iron|guadalupe}/main/bright/9894/39633105035725300
This is the second target. In this case, the fits including the smooth continuum are different from guadalupe and iron.
The one I posted in the first message is from guadalupe. I repeat that again here for comparison with iron.

guadalupe with smooth continuum: FWHM (broad Ha) ~ 5475 km/s

iron with smooth continuum: FWHM (broad Ha) ~ 6660 km/s

Not including the smooth continuum is definitely better versions for both guadalupe and iron, and looks similar to the new FastSpecFit results.

guadalupe without smooth continuum: FWHM (broad Ha) ~ 8850 km/s

iron without smooth continuum: FWHM (broad Ha) ~ 8830 km/s

It is really convincing that the EmFit results for broad Ha without smooth continuum are close to the estimates from the new code, showing that the new version fixes the smooth continuum issue. Thank you very much for taking the time to fix this issue. Can you please let me know if this new version also fixes the second issue I mentioned?


conditional map <c-n> & <c-p

so I want e.g <c-n> to fallback to normal ctrl_n or something if it is not in a paste/cycle state
I write something like
local function map_c_n()
  if require('yanky').ring.state then
    require('yanky').cycle(1)
  else
    vim.cmd[[execute "normal! \<c-n>"]]
  end
end

to remap <c-n> but it seems ring.state can only back to nil if line content is changed. Will it possible back to nil also if cursor moved out of pasted line ?

Interesting!
I think I can introduce an option to chose between "cursor moved" or "content changed" event (because I prefer "content changed event 😉)
I'll try to add this in the next few days!

Hi @aceforeverd !
I've made something here : https://github.com/gbprod/yanky.nvim/pull/32
Do you want to try before I merge ?

Thanks for feedbacks !
I've introduced require('yanky').can_cycle() method (more meaningful for me than is_in_ring)
I've also updated documentation ;)
I'll make more tests and I'll merge after

awesome :)

You can use keymap-amend plugin for this mapping:
keymap.amend('n', '<C-p>', function(original)
   if yanky.can_cycle() then
      yanky.cycle(-1)
   else
      original()
   end
end)

keymap.amend('n', '<C-n>', function(original)
   if yanky.can_cycle() then
      yanky.cycle(1)
   else
      original()
   end
end)

It plays well with vim-visual-muilti.


docs: Update Security Command Center UpdateNotificationConfig sample, adding filter to mutable field.

Fixes b/155346619

[x] Please merge this PR for me once it is approved and [cl/309855045] are both rolled out to prod.

I think Java 11 failed because of the backend cl was held back due to CSCC code freeze, is there anyway we can re-run all checks before merge?

Java 11 failed.

The presubmit will fail until cl/300638185 and cl/304060221 rolled out to prod. Please put this PR on-hold.

@hannah-tsai I see they've been submitted. Is it ok to merge this?

Yes, but I saw Internal CI build failed, is there any way to resolve this or re-run the presubmit?


chore : add changelog to makefile

Please provide the issue number

Issue number: #217
Summary
Changelog was not being generated because there was no action in Makefile for changelog.
This Makefile is called from the GitHub action Build and publish latest changelog https://github.com/awslabs/aws-lambda-powertools-dotnet/blob/develop/.github/workflows/reusable_publish_changelog.yml
Changes

Changelog in Makefil
.chglog folder

with config and template

User experience
Changelog will be updated on release
Checklist
Please leave checklist items unchecked if they do not apply to your change.

[x] Meets tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report
Patch coverage has no change and project coverage change: -0.06 :warning:

Comparison is base (56d5583) 56.29% compared to head (485b044) 56.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #227      +/-   ##
===========================================
- Coverage    56.29%   56.23%   -0.06%
===========================================
  Files           41       41
  Lines         1796     1796
===========================================
- Hits          1011     1010       -1
- Misses         785      786       +1

Flag
Coverage Δ

unittests
56.23% <ø> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Conflict with deeply nested rec function declarations

Description
When declaring nested rec functions within inner functions with the same name, an Error <Outer function name>.<Nested function name> has already been declared is encountered.
Context
I was trying to encapsulate all my code in one definition, which lead to me deciding to nest a helper function under an already nested inner function which is where i encountered the error.
Steps to Reproduce

def  outerFunction (x : Nat) : Nat :=
let innerFunction (x : Nat) :=
  let rec helper (x : Nat) :=
    helper x
  helper x

let otherInnerFunction (x : Nat) :=
  let rec helper (x : Nat) :=
    x
  helper x

funcA x

Expected behavior: Since the first helper is nested under innerFunction and the second helper is nested under otherInnerFunction, i expected this to compile normally.
Actual behavior: In reality this gave an error under the second helper outerFunction.helper has already been declared even though this is nested under otherInnerFunction and not directly under outerFunction
Versions
Lean 4.7.0
Windows 11 Pro, 23H2
Impact
Add :+1: to issues you consider important. If others are impacted by this issue, please ask them to add :+1: to it.

This behavior is by design. Lean creates a global name for all nested recursive functions. The name is based on the outer function. The global names are important when writing proofs.
Min fix: improve error message.
Workaround: add rec to the auxiliary let declarations. Example:

partial def  outerFunction (x : Nat) : Nat :=
let rec innerFunction (x : Nat) :=
  let rec helper (x : Nat) : Nat :=
    helper x
  helper x

let rec otherInnerFunction (x : Nat) :=
  let rec helper (x : Nat) : Nat :=
    x
  helper x
innerFunction x + otherInnerFunction x

#check outerFunction.innerFunction.helper
#check outerFunction.otherInnerFunction.helper

Remark: improved error message may suggest this solution.
Remark: It is not viable to take every single let-declaration into account when generating the auxiliary global name. Reason: too long names.
Another possible fix: Lean adds the suffix _<idx>  for the user. In the example above, the second helper would be named helper_2. Cons: if there are many nested functions with the same name, the user would have to "guess" the correspondence between helper_<idx> global functions when writing proofs. It seems better for the user to write the let rec using different names. Example:
partial def  outerFunction (x : Nat) : Nat :=
let innerFunction (x : Nat) :=
  let rec helper_1 (x : Nat) : Nat :=
    helper_1 x
  helper_1 x

let otherInnerFunction (x : Nat) :=
  let rec helper_2 (x : Nat) : Nat :=
    x
  helper_2 x
innerFunction x + otherInnerFunction x

#check outerFunction.helper_1
#check outerFunction.helper_2

Remark: improved error message may also suggest this solution.


Add file

This was originally going to be an endpoint for adding a single file but the fields on the File table are:
FileId,
ConsignmentId,
UserId,
DateTime
Only the consignment id isn't either auto-generated or got from the token, there's no information about the actual file here, that's all stored in the ClientFileMetadata table.
So it makes very little sense to have an endpoint that only creates one file and just calling it with the same arguments over and over for each file. So I've changed it to work like this.

Thought which should have occurred to me in the planning meeting: does it even make sense to have separate endpoints for creating a file and adding client-side metadata? If the client-side metadata is the first information we have about a file, should the file and the metadata be created at the same time?
We shouldn't have to structure our API endpoints in exactly the same way as the DB tables, because that implies we can't change the DB structure later without changing the API.

I think it is worth it. The flow in the front end would be like this:

User clicks upload
We call this mutation which populates the database with all of the files we're expecting to receive and get a list of ids back.
We get the client metadata from the library
We can then call the client metadata mutation using the ids returned from the first step. There's no need to match the returned file ids to the individual files because the individual files contain no information about the file itself.

If the upload fails for whatever reason or the user closes their browser, we have a records of how many files we're expecting to get which will help with error handling later.
If we have a joint file and metadata endpoint and only call the mutation when we have the metadata back from the library, we'll have no idea how many files we were expecting to get.

The main reason we need to know how many files we have as soon as possible is for the backend checks. If we only get half the files in S3 because they've closed their browser and we don't know how many files we were expecting, the backend checks will show 100% complete when in fact we're missing a load of files.

Won't we get that from the endpoint we're planning to add later, which just posts the total number of files in the consignment?

Sorry, have I misunderstood, and this is the endpoint which takes the number of files?

Yeah, it also gives us the advantage of having the file ids in the front end which we can then use to post the client metadata.

It would be good to have a chat about this - I've sent you a message on Slack. 🙂

As discussed:

I'll create a card for switching to Postgres, so we can use UUID IDs
We'll stick with this file creation flow for now, but we need to see how it performs in stress-testing, because the API response will include every file ID even if there are thousands of files. Will the API/DB/browser cope?


Support for react-native 0.70.x?

When upgrading my app to react-native I'm getting alot of errors like
CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler (in target 'vision-camera-code-scanner' from project 'Pods')
when trying to build the app for iOS. I havent really debugged that much yet, but I'm suspecting that this library needs to bump certain dependencies to work on newer react-native apps?

This library works fine in RN 0.70.x, at least in android. But not able to try this in ios though.
"react": "18.1.0",
"react-native": "0.70.3",
"react-native-reanimated": "^2.10.0",
"react-native-vision-camera": "^2.15.0",
"vision-camera-code-scanner": "^0.2.0"

:/ Maybe its the upgrade process which made something screw up then. Because the build wont build no matter what I do, and its always failing on some swift stuff with vision-cameracode-scanner. And if I enable hermes, i get this warning that this library does not support that so the vision-camera-code-scanner pod is not included at all.
So.. how do you guys tackle upgrading react-native? :P I use upgrade-helper and most stuff goes well but when I reach the iOS folder and its time to upgrade the xcodeproj file etc there are sooo many conflicts :(

I used upgrade helper too, from RN ^0.60 to 0.70.x.

Have similar issue that i cannot do arch -x86_64 pod install for ios, it says (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e')) for me.
Anyone found an solution?

Try this https://www.youtube.com/watch?v=sE0MEyFA7E4&list=PLQhQEGkwKZUrempLnmxjt7ZCZJu1W3p2i&index=7 & https://www.youtube.com/watch?v=BFkIIIKgjnE&list=PLQhQEGkwKZUrempLnmxjt7ZCZJu1W3p2i&index=80


koodo-reader: Electron ozone flags are not populated on wayland

Describe the bug
Koodo reader is an electron application, and although the build process includes the logic to add the proper ozone flags when the app is launched in a Wayland environment, it seems for some reason, it's not working as expected:
  postFixup = ''
    makeWrapper ${electron}/bin/electron $out/bin/koodo-reader \
      --add-flags $out/share/lib/koodo-reader/resources/app.asar \
      "''${gappsWrapperArgs[@]}" \
      --add-flags "\''${NIXOS_OZONE_WL:+\''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations}}" \
      --inherit-argv0
  '';

❯ koodo-reader
....
❯ hyprctl clients -j | jq '.[] | select(.class == "koodo-reader") | {class: .class, xwayland: .xwayland}  '
{
  "class": "koodo-reader",
  "xwayland": true
}

But launching the app with the required flags, it works:
❯ koodo-reader --ozone-platform-hint=auto --enable-features=WaylandWindowDecorations
...
❯ hyprctl clients -j | jq '.[] | select(.class == "koodo-reader") | {class: .class, xwayland: .xwayland}  '
{
  "class": "koodo-reader",
  "xwayland": false
}

The process arguments seem weird:
❯ pgrep -lfa koo | rg OZO
1369814 /nix/store/3cq9swbfjb53sc92wpksfgmxlbw5w4qj-electron-unwrapped-29.3.0/libexec/electron/electron --enable features=WaylandWindowDecorations}} /nix/store/qw061wrpi9ygkdiw7m7bj8p52wjdhvsr-koodo-reader-1.6.6/share/lib/koodo-reader/resources/app.asar ${NIXOS_OZONE_WL:+${WAYLAND_DISPLAY:+--ozone-platform-hint=auto

Notice that the the add-flags added by the package are truncated after the first space ...platfirm-hint=auto. I tried splitting up the flag into two --add-flags sentences to avoid spaces:
  home.packages = with pkgs; [
    (koodo-reader.overrideAttrs {
      postFixup = ''
        makeWrapper ${electron}/bin/electron $out/bin/koodo-reader \
          --add-flags $out/share/lib/koodo-reader/resources/app.asar \
          "''${gappsWrapperArgs[@]}" \
          --add-flags "\''${NIXOS_OZONE_WL:+\''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto}}" \
          --add-flags "\''${NIXOS_OZONE_WL:+\''${WAYLAND_DISPLAY:+--enable-features=WaylandWindowDecorations}}" \
          --inherit-argv0
      '';
    })
  ];

But now it looks l like the process does not pick up the environment variables:
❮ pgrep -lfa koo | rg OZO
1406606 /nix/store/3cq9swbfjb53sc92wpksfgmxlbw5w4qj-electron-unwrapped-29.3.0/libexec/electron/electron /nix/store/bsfcvl5nd6p8p1cpv2vmx2h6y4ms7qz8-koodo-reader-1.6.6/share/lib/koodo-reader/resources/app.asar ${NIXOS_OZONE_WL:+${WAYLAND_DISPLAY:+--ozone-platform-hint=auto}} ${NIXOS_OZONE_WL:+${WAYLAND_DISPLAY:+--enable-features=WaylandWindowDecorations}}

❯ echo $NIXOS_OZONE_WL
1
❯ echo $WAYLAND_DISPLAY
wayland-1
❯ echo "${NIXOS_OZONE_WL:+${WAYLAND_DISPLAY:+--enable-features=WaylandWindowDecorations}}"
--enable-features=WaylandWindowDecorations

The variables exist, I define them as environment.sessionVariables.
Changing the above override to explicitly set the ozone flags (without the shell expansion conditional) works. Other packages like kuro do the same shell expansion, and they also work in my environment without overriding anything.
Steps To Reproduce
Steps to reproduce the behavior:

Install koodo-reader in a wayland environment (I'm using hyprland)
Check if the application is using xwayland by running

hyprctl clients -j | jq '.[] | select(.class == "koodo-reader") | {class: .class, xwayland: .xwayland}'

It shows "xwayland": true

Expected behavior

Launch the application again but with the ozone flags

❯ koodo-reader --ozone-platform-hint=auto --enable-features=WaylandWindowDecorations

Now the app does not use xwayland: "xwayland": false

Notify maintainers
@TomaSajt
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
❯ nix-shell -p nix-info --run "nix-info -m"
this path will be fetched (0.01 MiB download, 0.05 MiB unpacked):
  /nix/store/9wnvhjyxjykwn5y06xc9a2h8rs5fbfia-stdenv-linux
copying path '/nix/store/9wnvhjyxjykwn5y06xc9a2h8rs5fbfia-stdenv-linux' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.6-zen1, NixOS, 24.05 (Uakari), 24.05.20240423.572af61`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/nix/store/m5i890m2g4pnyflpn48d1dpzzmwp5q4p-source`

Add a :+1: reaction to issues you find important.

I'm not a wayland user, so I usually just copy this line from other electron apps' definitions and hope it works. I think the issue here is that when wrapGAppsHook is present makeWrapper will use the binary implementation, which doesn't expand shell variables, thus not making this work. It looks like I forgot about this behaviour when packaging this.


Icons: Reconsider download link

From @LizNobriga  in Slack:

@adam-little  also mentioned that we don’t need to say “download” over and over in the icon library. It makes it difficult to scan the icon names. What do you think of removing “download” and just linking the icon name itself? For example:
zoom-out.svg
Another option is to list each one like this:

zoom-out.svg
Download

Notes:

If we make "Download" the only text in the link, that's not great for accessibility. As a we learned from CDT Accessibility experts, having a bunch of links with the exact same text is not recommended.
We have a task open to create a text search for the icons. That may make scanning less of an issue.
People can use command-F.
The Noun project and Font Awesome handle individual downloads differently but both make it clear, you're downloading before clicking.
This CSS Tricks article suggests there should be an icon to indicate links that do something other than open a new page.

I def went down the rabbit hole with this ask. Ultimately I think since the files are so small and we have the .svg extension visible,  removing the word Download is the better of the two options. I'll have to put this one on my user test bucket list.

QA link:
https://757-download-links.pr.designsystem.webstandards.ca.gov/pr/757-download-links/components/icons/readme/


[] build failure

Host Environment

OS: [e.g. Windows/Linux etc...]
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
./vcpkg install xxxx
Failure logs

Cut and paste the appropriate build messages from the console output.
Attach every failure log file mentioned in the console output.

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

@ranneytech please provide the repro steps and failure logs. Thanks.

We don't have enough information to solve this issue, unfortunately; if you have any more information to help us solve this, please reopen!


How can I swipe the only needed cell?

Hey!
I need to implement such feature - to swipe only needed cell in my table view. (not every cell)
Please point me - how can I disable and enable swipe for needed cell?
I suggest - it will be possible by set the right or left buttons to nil.
But maybe there is a more clear way to do it?
Best wishes!

- (BOOL)swipeTableCell:(MGSwipeTableCell *)cell canSwipe:(MGSwipeDirection)direction tableView:(UITableView *)tableView;
Just return YES for the cells that you want to swipe, and NO for the ones you don't want to swipe.

Thanks.


xActiveDirectory: Use fully qualified type names

Pull Request (PR) description

Changes to xActiveDirectory

Cleanup of code

Use fully qualified type names for parameters and variables
(issue #374).

Also update the examples a bit, that should be covered by another change log entry.
This Pull Request (PR) fixes the following issues

Fixes #374

Task list

[x] Added an entry under the Unreleased section in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in resource directory README.md.
[ ] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #385 into dev will not change coverage.
The diff coverage is 83%.

@@         Coverage Diff         @@
##            dev   #385   +/-   ##
===================================
  Coverage    92%    92%
===================================
  Files        20     20
  Lines      2529   2529
  Branches     10     10
===================================
  Hits       2333   2333
  Misses      186    186
  Partials     10     10

@PlagueHO Could you review this when you have time. A lot of files, but I think this one will be easy reviewed anyway. 🙂

Of course @johlju - I'm on it.

@PlagueHO Thanks for the review! This one is starting to get closer and closer for a rename.


Cannot build Errorprone plugin with Jigsaw

Description of the problem / feature request:
When I build my Errorprone plugin with module-info.java, I found that Errorprone plugin API has not support Jigsaw yet. To migrate tech stack from old Java 8 to latest LTS Java 11, I want to request to support Jigsaw. Here is detailed description:

I need to add both of requires error.prone.check.api; and requires error.prone.annotation; in module-info.java because Errorprone plugin needs to depend on both of error_prone_check_api and error_prone_annotation. But both of them provides the package com.google.errorprone so my build fails with following error messages:

[ERROR] the unnamed module reads package com.google.errorprone from both error.prone.check.api and error.prone.annotation
[ERROR] module error.prone.check.api reads package com.google.errorprone from both error.prone.check.api and error.prone.annotation
[ERROR] module com.google.common reads package com.google.errorprone from both error.prone.check.api and error.prone.annotation
[ERROR] module auto.service reads package com.google.errorprone from both error.prone.check.api and error.prone.annotation
[ERROR] module error.prone.annotation reads package com.google.errorprone from both error.prone.check.api and error.prone.annotation

Major problem is that, both of check_api and annotation uses com.google.errorprone package to provide API. It may require us to change package of each API, because Jigsaw requests us to make sure that the package is provided by only one module.
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Simply clone my GitHub repo, and switch to e15b478a then mvn clean verify will reproduce this issue. Make sure you have JDK9 on JAVA_HOME.
What version of Error Prone are you using?
2.3.2
Have you found anything relevant by searching the web?
I searched both of ML and Issues, however I found nothing related with this topic. There are several questions from Errorprone users, but no question from Errorprone plugin developers.

@cushon Also this one


Parse built-in functions

Would it be acceptable to add built-in functions as parser statements?

I'm gladly push a PR for this.

These can be shadowed, since they are just identifiers in the grammar, so I don't think it is a good idea to treat them specially.
def plusOne(abs):
  return abs + 1

plusOne(1)

Is there a way for downstream to opt-in or implement these easily? I see the changes in https://github.com/lezer-parser/python/pull/13 go pretty deep into the grammar and patching these would be rather labours. Could it be an opt-in setting?

Here, syntax highlighting serves as a hint that this is a keyword and it should not be shadowed. Without highlighting, it is much easier to shadow it for a newbie.
I teach python to students at a university who happen to be 'fluent' in other programming languages, and it is a common error for them to name variables as 'list', 'str', 'sum', 'min/max' or 'id', which are not built-ins in other languages. Of course they will learn it — later — but bad habits are simpler to form than they are to break. There is no easy way for them to see if these names are built-ins or not unless they are highlighted.
I would strongly vote for keeping them highlighted.

Another potential data point in favor of this request: All major IDEs/editors highlight built-ins, as does command line IPython.


Error processing 'plugin_name' vundle

I put these lines in my .vimrc file
Bundle 'Shougo/unite.vim'
Bundle 'Shougo/vimproc.vim'
Bundle 'm2mdas/phpcomplete-extended'
when I run the installation with :BundleInstall, I get errors Error processing 'plugin_name' for all three bundle. And I don't understand. Help please !!!

@Alioukahere Still having the issue? Do you have git installed? Can you check the permissions of the directory you are trying to install to?
see if #273 helps you

The #273 helped thanks @ryanoasis


If 978 switch is off, status page doesn't update fully

This is for all versions of stratux.

Closed with commit ac6da35e3b033d28814eb6879f4db12c367d1c69.


Added option to disable TLS verification

This PR adds the option to disable TLS verification:
bb = BasicBedrock(session=session, verify=False)

merging

merging


Auto regeneration of FASM test files

Problem statement
Currently, there are test data files which are fixed and, with the developement going on with symbiflow-arch-defs, prjxray, etc., these data files are becoming obsolete (and will become obsolete) and unsuited for testing purposes.
The problem is that there is a circular dependency between fasm2bels and symbiflow-arch-defs, for which a set of features might change both in prjxray-db, and the FASM files in the tests do not reflect the changes in the DB, hence being unsuited for testing anymore.
Possible solutions
[TODO]

One potential solution we discussed adding tarball'd bitstreams generated from Vivado as the source of truth to break the circular dependency.  So fasm2bels would have the "truth" bitstreams, generate FASM from those, and output verilog to be checked.


[cpp-package] Add monitor, optimizers, metrics and bug fixes

Force MSVC to use UTF-8 (Recent doc updates contain UTF-8 characters, MSVC regards source files as system code page by default)
cpp-package

supports MSVC and python 3
Add monitor interface
Add new optimizers (RMSProp, AdaGrad, AdaDelta, Adam)
Add new metrics (MAE, MSE, RMSE, PSNR)
Fix initializer bugs
Fix symbol loading bug

@piiswrong This pr is ready for review. And any idea why cuda compilation failed in windows?

Has progress on this stalled?

ping @piiswrong

@lx75249 Please take a look at recent change to metrics.py and make sure this is compatible

Existing apis in cpp version are compatible. As for new functions like update_dict, I will add them along with the module.


Update display title to match heading

The display title on this page does not match the heading on the page. I was confused looking through my open tabs to find one that started with "Strong and weak" and didn't find one. Turns out, the header doesn't match the metadata that makes the tab title.
This resolves that minor annoyance by making the metadata match the rest of the page.
I chose to bias toward "strong and weak" (instead of changing the heading to "weak" alone) because the heading says that and so does the TOC link. Two out of three votes used both, so I took that one.

Thanks, @miniksa!


Remove deprecated methods StartParameter.isTaskOutputCacheEnabled/setTaskOutputCacheEnabled

Closed as superseded by https://github.com/gradle/gradle/issues/1716


Signed-off-by: sijith<EMAIL_ADDRESS>

coment section

Codecov Report

Merging #157 into master will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #157      +/-   ##
=========================================
+ Coverage   54.77%   54.9%   +0.12%
=========================================
  Files          42      42
  Lines        1581    1581
=========================================
+ Hits          866     868       +2
+ Misses        653     651       -2
  Partials       62      62

Impacted Files
Coverage Δ

cmd/probe/udevprobe.go
62.03% <0%> (+1.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011acfd...e0450be. Read the comment docs.

#158 has the updated fix.


Local Connector Data Source

Regarding chmjs/chameleon-vuetify#50 and chmjs/chameleon-vuetify#45 list / table data source, we have an issue when local connector is selected.
No matter which values we select inside Data Source we are always end up with all data, not just selected ones.
The difference here is that Chameleon connector filters only data from schema.

Correct me if I'm wrong but I don't see that you filter selected values inside getSourceData local.js SDK method, or anywhere after calling this method.

You are right. There is no filtering mock in local connector. It should me added by just using lodash filtering methods.


Is there a query to extract file content on a specific date?

Hi to all,
imagine I have repo in which I update a txt file day by day.
Is there a way to have the version of this file on 2021-12-21?
A query like SELECT * FROM myFile.txt AS OF TIMESTAMP('2021-12-21'); that give me in output that file at that date?
Thank you

@patrickdevivo wow, it seems really fantastic, thank you very much!!!!
Now I must study mergestat and install it. In debian, do I can install it, simply downloading the release files and extract them in the PATH?

the query is a bit verbose - maybe that's an interesting subcommand we could add, mergestat file-as-of or something like that, to show the contents of a file as of a certain date.

I think it would be really precious to have this command

Hi @patrickdevivo, my input file is a csv. I have modified the query in this way:
mergestat --format csv "SELECT
  contents
FROM (
  SELECT * FROM commits
  WHERE author_when < date('2022-01-01')
  ORDER BY author_when DESC LIMIT 1
) AS c, files('', c.hash)
WHERE path LIKE 'input.csv'"

to have only the content.
Then I need to remove the first line of the output (I use tail -n +2), but I need to remove the " that I have at the start & at the end of my cell:
"fieldA,fieldB
a,1
b,7
q,3"

Then I have modified it in
mergestat --format csv "SELECT
  contents
FROM (
  SELECT * FROM commits
  WHERE author_when < date('2022-01-01')
  ORDER BY author_when DESC LIMIT 1
) AS c, files('', c.hash)
WHERE path LIKE 'input.csv'" | tail -n +2 |tail -c +2 | head -c -2

It there a direct way to have only in output my CSV content, without contents heading and without heading and trailing double quotes?
fieldA,fieldB
a,1
b,7
q,3

mergestat seems to me fantastic, thank you

Hi @aborruso - that's an interesting use case! I can't think of an easy way as is to handle it as you say - maybe it's worth adding a csv-noheader output format option to exclude the headers.
As for the double quotes, I'm not sure - I think those are coming from the csv writer we're using, as it seems like it's csv "inside" csv.
Maybe it's worth bringing in a tool like dasel? or possibly switch to json or ndjson output and use jq as well?
I can try to take a closer look as well and see if I can reproduce an example

or possibly switch to json or ndjson output and use jq as well?

In this way it's good for me. Thank you
mergestat --format json "SELECT
  contents
FROM (
  SELECT * FROM commits
  WHERE author_when < date('2021-01-01')
  ORDER BY author_when DESC LIMIT 1
) AS c, files('', c.hash)
WHERE path LIKE 'openregio_immobiliDestinati.csv'" | jq -r '.[0].contents'


Responsiveness in Landing Frame

The main section is not responsive to different screens. Need to be fixed

I'll look into it. Its probably cause I used percentage positioning. Will try again with view porting.


Character Encoding problems

Turkish letters creates render problem like  'ĞÜŞİÖÇ' , It renders empty space for those letters sometimes.
For Example ;
TÜRKİYE --> TÜRK YE
Best Regards.

I have the same for some pdf files in russian

Does anyone know the solution to this problem?

@barteksc Do you have any solution for this?. Can you add function for localization?


Fix: Dark theme working now in contact us page.

Closes #598
The light theme to dark theme toggle button is now working in contact us page.
https://github.com/Anushkabh/krishiconnect/assets/121669832/7382807b-3226-4d87-b531-8c7f0139e7c6
Please check it and let me know if any changes to be made, Thank you!

Hey @nagalakshmi08 !
Please resolve the merge conflicts. Our repo underwent with a series of major changes since last 2 weeks. I request you to please sync the latest changes and resolve the conficts raised.


Surface deck errors as Kubernetes events

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement
Similarly to https://github.com/Kong/kubernetes-ingress-controller/issues/3205, we'd like to make sure that all error/warnings detected by deck when applying configuration in DB-mode are properly propagated by means of Kubernetes events.
Proposed Solution
Refactor deck sync.Solver so it returns errors/warnings it detected.
Additional information
No response
Acceptance Criteria

[ ] When deck rejects an entity a Kubernetes Event is created on the resource that is the reason for rejection.

This is a nice to have, but given our primary topologies of DB-less and non-KIC with Konnect I think this should wait

It may make sense to do #5289 as a prerequisite for this issue.


Docs for working with types

Provide help for things that are possible based on this PR: https://github.com/prisma/photonjs/pull/378

Added via https://github.com/prisma/prisma2/pull/1296 at https://github.com/prisma/prisma2/blob/docs/types/docs/photon/generated-types.md
Note that this PR hasn't been merged yet as the described types will only be exposed upon the next release.


decker: 1.32 -> 1.33

Description of changes
https://github.com/JohnEarnest/Decker/compare/v1.32...v1.33
https://github.com/JohnEarnest/Decker/compare/v1.33...v1.34
https://github.com/JohnEarnest/Decker/compare/v1.34...v1.35
https://github.com/JohnEarnest/Decker/compare/v1.35...v1.36
https://github.com/JohnEarnest/Decker/compare/v1.36...v1.37

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Updated it to 1.37 and rebased it on top of 7370e0226d98bf82e3a9f6d992d5388fdcad7d7c.


Why are we committing the dist/ directory?

No need to track the built files.

Deletes dist/ from the repository

Note: In branch nic/v10, the .gitignore file automatically ignores future revisions of dist/:
https://github.com/ACE-IoT-Solutions/ace-svg-react/blob/9588364793ee7e92226a32057c80c11313bbc538/.gitignore#L24


Redirect MistServer links to /docs

What does this pull request do? Explain your changes. (required)

Specific updates (required)

Redirect MistServer links to /docs

Does this pull request close any open issues?

Fixes Redirect MistServer links to /docs

Screenshots (optional):

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

Adding @Shih-Yu to Review as well... once we get his 👍 let's deploy it.
@Shih-Yu you're welcome to review and or tweak anything in the new section of the docs as you see fit, just have me and Paige review https://livepeer.com/docs/guides/media-server/introduction


add update_mesh method

Description

Adds a new method: layers.vectors._update_mesh which reduces duplicate code and makes the codebase cleaner.
It calls the generate_vector_meshes method and sets the results into variables stored on the class.
This also will be beneficial for the async_slicing work being proposed.
Type of change

[x] New feature (non-breaking change which adds functionality)

References

How has this been tested?

[x] all tests pass with my change

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

I'd be happy to encapsulate into a dataclass if that's what people would prefer. I'll remove the draft in hopes of opening it up for more feedback.

CI is passing and we have three approvals, so I am merging. Thanks again, @kcpevey !


Jobs don't run

Hi,
After upgrading to the Strider's latest, the jobs (manual retest) don't finish the environment phase and don't do nothing else.
Node v4.4.7.
Using DEBUG=* I see this:
2016-08-04T22:09:31.048Z - error: Thu, 04 Aug 2016 22:09:31 GMT strider-github-status initing 57a3bd1a49889a0338b16d4e undefined
2016-08-04T22:09:31.053Z - error: Thu, 04 Aug 2016 22:09:31 GMT strider-github-status No github PR data undefined { __v: 0,...
Thu, 04 Aug 2016 22:09:31 GMT strider-runner-core:job Creating new job "57a3bd1a49889a0338b16d4e" for project "XXXX" using provider "github".
Thu, 04 Aug 2016 22:09:31 GMT strider-runner-core:job Running job "57a3bd1a49889a0338b16d4e"...
Thu, 04 Aug 2016 22:09:31 GMT strider-runner-core:job Job "57a3bd1a49889a0338b16d4e" runs: node { cmd: 'n 0.10',....

Thu, 04 Aug 2016 22:09:31 GMT engine:polling compressing
Thu, 04 Aug 2016 22:09:31 GMT engine:socket executing batch send callback
Thu, 04 Aug 2016 22:09:31 GMT engine intercepting request for path "/socket.io/"
Thu, 04 Aug 2016 22:09:31 GMT engine handling "GET" http request "/socket.io/?EIO=3&transport=polling&t=LPNchCM&sid=5C2Sf3y-DfDTq3NqAAAG"
Thu, 04 Aug 2016 22:09:31 GMT engine setting new request for existing client
Thu, 04 Aug 2016 22:09:31 GMT engine:polling setting request
Thu, 04 Aug 2016 22:09:31 GMT engine:socket executing batch send callback
Thu, 04 Aug 2016 22:09:50 GMT engine intercepting request for path "/socket.io/"
Thu, 04 Aug 2016 22:09:50 GMT engine handling "POST" http request "/socket.io/?EIO=3&transport=polling&t=LPNclta&sid=5C2Sf3y-DfDTq3NqAAAG"
Thu, 04 Aug 2016 22:09:50 GMT engine setting new request for existing client
Thu, 04 Aug 2016 22:09:50 GMT engine:polling received "1:2"
Thu, 04 Aug 2016 22:09:50 GMT engine:socket packet
Thu, 04 Aug 2016 22:09:50 GMT engine:socket got ping
Thu, 04 Aug 2016 22:09:50 GMT engine:socket sending packet "pong" (undefined)
Thu, 04 Aug 2016 22:09:50 GMT engine:socket flushing buffer to transport
Thu, 04 Aug 2016 22:09:50 GMT engine:polling writing "�3"
Thu, 04 Aug 2016 22:09:50 GMT engine intercepting request for path "/socket.io/"
Thu, 04 Aug 2016 22:09:50 GMT engine handling "GET" http request "/socket.io/?EIO=3&transport=polling&t=LPNclvT&sid=5C2Sf3y-DfDTq3NqAAAG"
Thu, 04 Aug 2016 22:09:50 GMT engine setting new request for existing client
Thu, 04 Aug 2016 22:09:50 GMT engine:polling setting request
Thu, 04 Aug 2016 22:09:50 GMT engine:socket executing batch send callback
Thu, 04 Aug 2016 22:10:16 GMT engine intercepting request for path "/socket.io/"
Thu, 04 Aug 2016 22:10:16 GMT engine handling "POST" http request "/socket.io/?EIO=3&transport=polling&t=LPNcsDs&sid=5C2Sf3y-DfDTq3NqAAAG"
Thu, 04 Aug 2016 22:10:16 GMT engine setting new request for existing client
Thu, 04 Aug 2016 22:10:16 GMT engine:polling received "1:2"
Thu, 04 Aug 2016 22:10:16 GMT engine:socket packet
Thu, 04 Aug 2016 22:10:16 GMT engine:socket got ping
Thu, 04 Aug 2016 22:10:16 GMT engine:socket sending packet "pong" (undefined)
Thu, 04 Aug 2016 22:10:16 GMT engine:socket flushing buffer to transport
Thu, 04 Aug 2016 22:10:16 GMT engine:polling writing "�3"
Thu, 04 Aug 2016 22:10:16 GMT engine intercepting request for path "/socket.io/"
Thu, 04 Aug 2016 22:10:16 GMT engine handling "GET" http request "/socket.io/?EIO=3&transport=polling&t=LPNcsFj&sid=5C2Sf3y-DfDTq3NqAAAG"
Thu, 04 Aug 2016 22:10:16 GMT engine setting new request for existing client
Thu, 04 Aug 2016 22:10:16 GMT engine:polling setting request
Thu, 04 Aug 2016 22:10:16 GMT engine:socket executing batch send callback
Thu, 04 Aug 2016 22:10:42 GMT engine intercepting request for path "/socket.io/"
Thu, 04 Aug 2016 22:10:42 GMT engine handling "POST" http request "/socket.io/?EIO=3&transport=polling&t=LPNcya7&sid=5C2Sf3y-DfDTq3NqAAAG"
Thu, 04 Aug 2016 22:10:42 GMT engine setting new request for existing client
Thu, 04 Aug 2016 22:10:42 GMT engine:polling received "1:2"
Thu, 04 Aug 2016 22:10:42 GMT engine:socket packet
Thu, 04 Aug 2016 22:10:42 GMT engine:socket got ping
Thu, 04 Aug 2016 22:10:42 GMT engine:socket sending packet "pong" (undefined)
Thu, 04 Aug 2016 22:10:42 GMT engine:socket flushing buffer to transport
Thu, 04 Aug 2016 22:10:42 GMT engine:polling writing "�3"
Thu, 04 Aug 2016 22:10:42 GMT engine intercepting request for path "/socket.io/"
Thu, 04 Aug 2016 22:10:42 GMT engine handling "GET" http request "/socket.io/?EIO=3&transport=polling&t=LPNcyby&sid=5C2Sf3y-DfDTq3NqAAAG"
Thu, 04 Aug 2016 22:10:42 GMT engine setting new request for existing client
Thu, 04 Aug 2016 22:10:42 GMT engine:polling setting request
Thu, 04 Aug 2016 22:10:42 GMT engine:socket executing batch send callback

And latest lines are repeated after some seconds but the job never ends.
The weird character  "�3" appears sometimes in the log.

This is possibly an issue we recently found with a silent failure in the simple runner, related to caching,. Try clearing the cache for the project. All the debug messages that are not prefixed with strider are usually not relevant to diagnose issues.

How do I clear the project's cache? Do you mean the browser's cache?
Ok (about the debug messages)!

There is an option for that in the project settings.

After clearing the project's cache works worse.
Now I got this errors:
2016-08-05T07:52:33.770Z - error: Fri, 05 Aug 2016 07:52:33 GMT superagent max redirects 5
2016-08-05T07:52:33.770Z - error: Fri, 05 Aug 2016 07:52:33 GMT superagent set User-Agent "StriderCD (http://stridercd.com)"
2016-08-05T07:52:33.771Z - error: Fri, 05 Aug 2016 07:52:33 GMT superagent query ref=master
2016-08-05T07:52:33.771Z - error: Fri, 05 Aug 2016 07:52:33 GMT superagent set Authorization "token 3f40a75fd7a2903c69d0150100b551ef063a6d0f"
2016-08-05T07:52:33.771Z - error: Fri, 05 Aug 2016 07:52:33 GMT superagent GET https://api.github.com/repos/mediasmart/MYREPO/contents/strider.json
2016-08-05T07:52:33.815Z - error: Fri, 05 Aug 2016 07:52:33 GMT superagent GET https://api.github.com/repos/mediasmart/MYREPO/contents/strider.json -> 404
2016-08-05T07:52:33.816Z - error: Fri, 05 Aug 2016 07:52:33 GMT superagent end GET https://api.github.com/repos/mediasmart/MYREPO/contents/strider.json
2016-08-05T07:52:33.817Z - error: Fri, 05 Aug 2016 07:52:33 GMT superagent clear timeout GET https://api.github.com/repos/mediasmart/MYREPO/contents/strider.json
Fri, 05 Aug 2016 07:52:33 GMT strider:backchannel job.prepare - strider.json not found, skipping config merge
2016-08-05T07:52:33.844Z - error: Fri, 05 Aug 2016 07:52:33 GMT superagent clear timeout GET https://api.github.com/repos/mediasmart/MYREPO/contents/strider.json

We do not use strider.json but I see also is looking for into a folder of my repo ¿?.

Yes, it's always looking for that file. Issues like this are really annoying. Strider doesn't log nearly as much as it should to make analyzing these issues possible :P

Finally the environment phase has appeared, like before, but not more.

Sadly, @knownasilya is on vacation and I'm leaving for the weekend soon as well. The only suggestion I have left at this point is to try to run the absolutely latest development snapshots of everything. The clone and link scripts in https://github.com/oliversalzburg/strider-dev can be very helpful for that.
Sorry :(

Enjoy it @knownasilya !!
Ok @oliversalzburg , enjoy your weekend too. I gonna try this, put the feedback and if does not work I will downgrade Strider until it works and continue the next week.

I can only offer a "this works for me" for the time being: We use Docker to run our tests and configure mainly through strider.json. The process is outlined at https://github.com/Strider-CD/strider/wiki/Advanced-Configuration
The Docker runner differs in many ways from the simple runner you're currently using. So it's different code (that has different problems). But maybe that approach works better for you ;)

I bumped the versions of the two mentioned plugins.

Thanks again.

@oliversalzburg when installing strider in a new machine I'm having an error, I think related with this. Running npm install:
npm ERR! notarget No compatible version found<EMAIL_ADDRESS><2.0.0'
npm ERR! notarget Valid install targets:
npm ERR! notarget ["0.10.0","0.11.0","0.11.1","0.11.2","0.11.3","0.12.0","0.12.1","0.13.0","0.13.1","0.14.0","0.15.0","0.15.1","0.15.2","1.0.0"]

The point is before in the strider's package json the simple-runner has ^1.0.0 so it had to install the 1.0.1 but didn't. On the other hand, when I updated through the UI it worked.

The same problem with strider-custom:
npm ERR! notarget No compatible version found<EMAIL_ADDRESS><2.0.0'
npm ERR! notarget Valid install targets:
npm ERR! notarget ["0.1.0","0.1.1","0.1.2","0.1.3","0.2.0","0.2.1","0.3.0","0.3.1","0.4.0","0.4.1","0.5.0","0.5.1","0.5.2","0.5.3","0.5.4","0.5.5","0.6.0","0.6.1"]

The two plugins are currently only published to the "ecosystem index" (making them available as updates through the UI). The release to npm is still pending (I don't have npm publish access). I reverted the commit for now.

I think we can close this. No problems anymore after upgranding Strider and node.


Errors when no access/secret key are provided

Hi, Thanks a lot for this tool, I was going crazy trying to simulate the policy simulator using aws cli when I stumbled on this project.
I think it will help to provide a meaningful message if we run this without providing the access/secret key. Currently we get this.
ERROR:	An error occurred (InvalidClientTokenId) when calling the GetCallerIdentity operation: The security token included in the request is invalid.
Traceback (most recent call last):
  File "/Users/raja/projects/virtualenvs/iam-tester/lib/python3.7/site-packages/aws_iam_tester/cli.py", line 151, in main
    account_id = sts_client.get_caller_identity()["Account"]
  File "/Users/raja/projects/virtualenvs/iam-tester/lib/python3.7/site-packages/botocore/client.py", line 316, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/raja/projects/virtualenvs/iam-tester/lib/python3.7/site-packages/botocore/client.py", line 635, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (InvalidClientTokenId) when calling the GetCallerIdentity operation: The security token included in the request is invalid.

Also, it will help to indicate what is the minimum role required to be able to run this, it looks like if the user doesnt have iam:ListAccountAliases then this tool doesnt work. It will help to provide a help message accordingly to setup (Either in the tool or in the README) so that new users will find it beneficial.
I can try and provide a PR if you are okay with that.

Hi Raja,
Glad you like it :-)
Please go ahead with the PR, both are good suggestions.
Regards,
Gerco
On Fri, 31 Jul 2020 at 21:41, Raja Venkataraman<EMAIL_ADDRESS>wrote:

Hi, Thanks a lot for this tool, I was going crazy trying to simulate the
policy simulator using aws cli when I stumbled on this project.
I think it will help to provide a meaningful message if we run this
without providing the access/secret key. Currently we get this.
ERROR:	An error occurred (InvalidClientTokenId) when calling the GetCallerIdentity operation: The security token included in the request is invalid.
Traceback (most recent call last):
File "/Users/raja/projects/virtualenvs/iam-tester/lib/python3.7/site-packages/aws_iam_tester/cli.py", line 151, in main
account_id = sts_client.get_caller_identity()["Account"]
File "/Users/raja/projects/virtualenvs/iam-tester/lib/python3.7/site-packages/botocore/client.py", line 316, in _api_call
return self._make_api_call(operation_name, kwargs)
File "/Users/raja/projects/virtualenvs/iam-tester/lib/python3.7/site-packages/botocore/client.py", line 635, in _make_api_call
raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (InvalidClientTokenId) when calling the GetCallerIdentity operation: The security token included in the request is invalid.
Also, it will help to indicate what is the minimum role required to be
able to run this, it looks like if the user doesnt have
iam:ListAccountAliases then this tool doesnt work. It will help to provide
a help message accordingly to setup (Either in the tool or in the README)
so that new users will find it beneficial.
I can try and provide a PR if you are okay with that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gercograndia/aws-iam-tester/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADJSNZA6ZMLA7XIIKBBJX3R6MM7XANCNFSM4PQZF3VQ
.

Have incorporated some changes in this regards, have a look whether that helps you. I'll close the case for now.