Idea: a checkData Function [nut.command.add]

When adding commands to Nutscript this bit of code runs
if (!data.onCheckAccess) then
		-- Check if the command is for basic admins only.
		if (data.adminOnly) then
			data.onCheckAccess = function(client)
				return client:IsAdmin()
			end
		-- Or if it is only for super administrators.
		elseif (data.superAdminOnly) then
			data.onCheckAccess = function(client)
				return client:IsSuperAdmin()
			end
		-- Or if we specify a usergroup allowed to use this.
		elseif (data.group) then
			-- The group property can be a table of usergroups.
			if istable(data.group) then
				data.onCheckAccess = function(client)
					-- Check if the client's group is allowed.
					for _, v in ipairs(data.group) do
						if (client:IsUserGroup(v)) then
							return true
						end
					end

					return false
				end
			-- Otherwise it is most likely a string.
			else
				data.onCheckAccess = function(client)
					return client:IsUserGroup(data.group)
				end
			end
		end
	end

but this itself creates a lot of issues
When you wish to make modifications to how the data itself is checked you have to modify how the function itself works, would be wonderful if I could just override a function instead since it seems to return true or false.
I tried doing this but I just straight-up broke Nutscript so I made a issue in hopes someone who is better than me edits the code

This segment of the code acts as a way for you to add custom access checking for clients, such as isAdmin, isSuperAdmin, in case you want to limit commands to flags or factions or classes or whatever. It should only return true or false because code elsewhere uses it to limit or allow access. It shouldn't return anything else. Elaborate what do you want changed?

Because the segment of code is not a function the only way to change how commands access works is to actually change nutscript itself
This makes nutscript inflexible and difficult to use, how nutscript checks command access should be done by a function.
This allows developers to change how command access works while keeping their code base consistent since they would be able to override the function

I'm confused.
NS checks if there is a onCheckAccess function, such as
	onCheckAccess = function(client) 		return client:getChar():hasItem("item") 	end
if this is not present, it checks if there's an adminOnly, superAdminOnly or group is present and automatically creates an access check function.
I don't understand what your complaint is

if you're using OnCheckAccess it's a variable of "data" so if I want to completely override it for every command I make I would need to override it again. this is inconsistent and inflexible. It would be better if there was a global function that can simply be overrode instead of overriding it everytime I make a new NS Command

I don't see the problem, it's really not that much effort to override it again for your new commands...


initial commit of unity sample

unity sample includes:

Primary scene, plus loading scene
Wrapper script for GooglePlayInstant class. Supports setCookie, getCookie, isInstantApp, and install prompt
Script to download asset bundle
Materials, textures, prefabs

I signed it!

I signed it!

I signed it!

I signed it!

I signed it!

I signed it!

I signed it!


[Feature Request]: Add the ability to use a file instead of an embedded image in an ODHApplication

Feature description
Currently images are added to ODH applications by embedding an SVG into CR yaml file for the application.  To be consistent with Quickstarts and documentation we should allow the ability to reference an image in the current build.
Describe alternatives you've considered
N/A
Anything else?
No response

The code here needs to be updated to handle an svg image that's not embedded.


Neato component throwing import exception

Home Assistant release with the issue:

Last working Home Assistant release (if known):
0.95.4
Operating environment (Hass.io/Docker/Windows/etc.):

Component/platform:

Neato
Description of problem:
The Neato class is not part of pybotvac 0.0.13 version, but upgrading to the 0.0.15 version. 0.0.13 is the version that Home Assistant installed on my Docker.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):
Error during setup of component neato
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/setup.py", line 172, in _async_setup_component
    component.setup, hass, processed_config  # type: ignore
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/neato/__init__.py", line 178, in setup
    from pybotvac import Account, Neato, Vorwerk
ImportError: cannot import name 'Neato' from 'pybotvac' (/usr/local/lib/python3.7/site-packages/pybotvac/__init__.py)

Additional information:

You may want to remove the custom component first and try again

Whoops, forgot I put that in the other day when dealing with the locale issue.


RegisterDragDrop is used on windows, it is invalid when "flutter run", double-click exe to run is valid

Steps to Reproduce

Create a new windows application project and use the win32 API RegisterDragDrop in the Win32Window class Win32Window::CreateAndShow()

  OleInitialize(nullptr);
  if (SUCCEEDED(RegisterDragDrop(window, new DropTarget(this)))) {
    bHasDragDrop = true;
  }

Run the app with "flutter run"

Expected results:
DragDrop always works
Actual results:
RegisterDragDrop does not fail, but DragDrop has no effect
However, directly double-clicking the exe to run DragDrop works
Doctor:
[√] Flutter (Channel master, 2.10.0-1.0.pre.423, on Microsoft Windows [Version 10.0.19041.572], locale zh-CN)
    • Flutter version 2.10.0-1.0.pre.423 at E:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fd8d035921 (3 days ago), 2022-02-04 06:00:19 -0500
    • Engine revision 0d39b6dd28
    • Dart version 2.17.0 (build 2.17.0-79.0.dev)
    • DevTools version 2.10.0
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[X] Android toolchain - develop for Android devices
    X Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Professional 2019 16.8.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional
    • Visual Studio Professional 2019 version 16.8.30907.101
    • Windows 10 SDK version 10.0.19041.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[√] IntelliJ IDEA Ultimate Edition (version 2020.2)
    • IntelliJ at F:\Software App\IntelliJ IDEA 2020.2.1
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] VS Code, 64-bit edition (version 1.45.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.34.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19041.572]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 97.0.4692.99
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 97.0.1072.69

same Issue:
https://github.com/MixinNetwork/flutter-plugins/issues/9

Hi @sudongg, Thanks for filing the issue, I have very little knowledge on the windows side could you please share a sample project to investigate this further?
Thanks

Thanks for the sample project @sudongg, when I dopped the file in the flutter window I am getting drop feedback when running the app in debug mode, also works with the exe windows/runner/debug/flutter_application1.exe

flutter doctor -v
[√] Flutter (Channel stable, 2.10.0, on Microsoft Windows [Version
    10.0.19044.1466], locale en-US)
    • Flutter version 2.10.0 at C:\flutter_sdk\stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5f105a6ca7 (7 days ago), 2022-02-01 14:15:42 -0800
    • Engine revision 776efd2034
    • Dart version 2.16.0
    • DevTools version 2.9.2

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\mahesh\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual
      Studio\2019\Community
    • Visual Studio Community 2019 version 16.11.31727.386
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2020.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] VS Code (version 1.63.2)
    • VS Code at C:\Users\mahesh\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.34.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version
      10.0.19044.1466]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 98.0.4758.82
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 97.0.1072.76

[√] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

@maheshmnj
This should be a Windows bug,
My Windows Version is 19041.572, your version is 19044.1466, maybe this problem has been fixed in the new version, I can't upgrade the Windows Version, so I can't test.

@maheshmnj
I tested with CMD just now, and opening the exe in admin mode triggers the issue, the issue has nothing to do with flutter. This issue can be closed.


Making sure hpx::util::hardware::timestamp() is always defined

Fixes #5333
@diehlpk could you please check whether this solves your issue?

@hkaiser Thanks, that fixed the bug.


L.get_hashtag_posts(HASHTAG)  can not work

The obtained status is 404    resp = sess.post('https://{0}/{1}'.format(host, path), data=params, allow_redirects=False)
Error ：JSON Query to explore/tags/nba/: 404 Not Found when accessing https://www.instagram.com/explore/tags/nba/?__a=1&__d=dis [retrying; skip with ^C]

incomplete bug report. no issue template used.
description cannot be reproduced.


Presentation

Make sure you have

[x] Well documented README
[x] Podcast recording
[x] Youtube recording if necessary
[ ] Blogpost article

Blog post article still in progress.
We can do the podcast recording on Monday or Tuesday next week.
Still updating the README file.

Let's do the podcast on Monday
We will probably record the session during Thursday as some of the members said they would like to refer after
Finish up on the readme

Please write the blog post article

Is there a blog post sample I can use to refer to, i.e. of a project done?
Kind Regards,
Yvonne Mureithi.
On Thu, Jun 10, 2021 at 9:23 AM b1ackd0t @.***> wrote:

Please write the blog post article
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JKUATSES/2021-DesignMechanicalSystem/issues/1#issuecomment-858344581,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARVAHUAMYMYD6YWERJGEB6DTSBK6RANCNFSM423X4YHA
.

Will do, thanks.
Kind Regards,
Yvonne Mureithi.
On Thu, Jun 10, 2021 at 5:01 PM b1ackd0t @.***> wrote:

You can check out:

Blog article for Africastalking
https://developers.decoded.africa/index.php/2021/05/09/smart-farm-with-africastalking-iot-platform/
Ses blog http://ses.jkuat.ac.ke/blog/

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JKUATSES/2021-DesignMechanicalSystem/issues/1#issuecomment-858648446,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARVAHUBEMRR3PBO6NE6HGL3TSDAR3ANCNFSM423X4YHA
.


Pass hypercat item-metadata to apps at install time

The app gets passed information about the data sources they have been assigned at install time. This data is passed through an environment variable.
Until now the data passed to the app was a custom JSON object encoded as a string. From now on the data passed will be the hypercat item relating to that data source. The hypercat item is extracted from the datastores /cat endpoint by the container manger.

Good stuff!


chore: make tunnel filenames consistent

Currently the tunnel setup/wait/stop files always have different names like sauce_connect_block or just waitfor_tunnel.

LGTM


Download link for Azure Sphere Developer Tools

Where does one download the Azure Sphere Developer Tools from?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d97065dd-068c-6c33-310f-fd1c722cf04c
Version Independent ID: 2301900c-0c6d-80b4-6fbd-9b0b18f9e640
Content: Azure Sphere installation and device setup quickstart
Content Source: AzureSphere/articles/QuickStart/qs-install.md
Product: azure-sphere
GitHub Login: @pennyo
Microsoft Alias: azurespheredocs

Thank you for your question. The developer tools are currently available to private preview participants only. They are not yet publicly distributed.
If you already have an Azure Sphere development kit, please contact the person who arranged it for you to provide access to the tools via the Microsoft Collaborate tool.
If you don't have a development kit, you can pre-order one through the Azure Sphere website.

Thanks. Consider this as closed.

You can download 'Download the Azure Sphere SDK Preview for Visual Studio' link of here.


Popover for Select immediately closes on Firefox Mobile simulator

🐛 Bug Report
Clicking to open a selector component causes it to open and then close. A long press will open it.
This may be a regression of https://github.com/adobe/react-spectrum/issues/816
💻 Code Sample
https://react-spectrum.adobe.com/react-aria/useSelect.html#useselect
Click "select a option" on firefox and you should be able to replicate this issue.
🌍 Your Environment

Software
Version(s)

react-spectrum
3.22 and whatever is on the website.

Browser
Firefox 111 using mobile simulator from dev tools

Operating System
Windows 11

Reproduced in Firefox 112 on my Android device as well, thanks for catching this!

@jwickens https://github.com/adobe/react-spectrum/blob/1a38c6f7ed998fae8ef5321b832a4d68b7926a5e/packages/%40react-aria/menu/src/useMenuTrigger.ts#L114-L118 would suggest that the select menu should already be opened via onPress rather than onPressStart for touch device, maybe something with Firefox is breaking that detection?

Thanks for digging into this and glad you found a workaround.

it doesn't seem like the intent of this function
You are correct, isVirtualPointerEvent is supposed to detect screen reader virtual clicks. The compatibility mouse clicks are definitely problematic, hopefully we can resume work on https://github.com/adobe/react-spectrum/pull/2942 to try and get this issue squared away.

Cannot reproduce anymore. May have been fixed by #7026.


Intermittant Access to set cookies

Here's an example - Hoping to have some insight into why it may be doing this, whether there is a setting I can change to stop it, but I suspect it is a bug

So I set a few cookies in a login process (sets the cookie fine)
I'm on a URL like /account/settings -> I hit refresh - the cookie doesn't exist
I then navigate to another page -> like /account/XXX/XXX/XXX -> and hit refresh - the cookie re-appears again

I could do a screen cast to show the problem - it is very strange

Hello there,
this looks very much like an implementation problem to me. You should open a StackOverflow question and supply real code there. From what you are describing, I can only take an educated guess... but I think you should double-check your cookie domains.
Good luck with your bug hunt, let us know if (and how) you were able to solve your problem.
Cheers

Hey there, I finally managed to spot what is/was causing this - and i'm not sure if this might be something your aware of, not sure what the core library does.
So here's the scenario that was causing it
In angular i have a router/interceptor that redirects a user to /login if the cookie values aren't present, so the issue was the following
-> I would load url like {a}/{b}/{c} (not logged in)
-> i would be redirected to /login
-> then when i login for some reason the cookie path would be set to {a}/{b}/{c} (but the url in the address bar is most certainly /login)
Basically had 6-7 different path/duplications of the same cookies (and i could be logged in as like 3-4 different id's within different sections - it was causing all sorts of nightmare overrides / and problems logging out)
The solution was setting path in the cookie.set(name,val,exp,'/' .... ) so that when i 'logout' it definitely would destroy the cookie sets that the login check was looking for.
I would have thought path would have by default been '/' ?
So worth making a note (in angular 4+)
That i'm unsure how it was ever picking up the previous url (prior to redirect)
Unless angular 4 has some url masking going on so while i see /login up the top - the cookie service is looking at the previous URL
Posting this reply up here, just incase it's worth looking into your end - but it's more than likely an angular implementation remark.


Add beta rust to CI

Motivation
Add CI for building and testing in rust beta. https://github.com/ZcashFoundation/zebra/issues/1712
Solution
Use toolchain: beta https://github.com/marketplace/actions/rust-toolchain
Please note this will almost double the time needed to run the full CI.
This PR if merged will close https://github.com/ZcashFoundation/zebra/issues/1712
Review
@dconnolly

Yea, thanks @dconnolly i just made a quick test duplicating the build in the first commit but then started to use matrix in the other ones.

I removed the PR from draft state. @dconnolly i think you can take a look now. thanks :)

Please note this will almost double the time needed to run the full CI.

I think using matrix allows all such jobs to be triggered in parallel

I think using matrix allows all such jobs to be triggered in parallel

Cool, i will remove that comment then.

Updated the comment.

@teor2345 @yaahc @oxarbitrage any opinion on whether build-chain-no-features also needs to run on +beta or other platforms besides ubuntu?

@teor2345 @yaahc @oxarbitrage any opinion on whether build-chain-no-features also needs to run on +beta or other platforms besides ubuntu?

I'd say yes

@teor2345 @yaahc @oxarbitrage any opinion on whether build-chain-no-features also needs to run on +beta or other platforms besides ubuntu?

When we do individual crate builds, they should also build on beta/nightly. Not so sure about other platforms.

@teor2345 @yaahc @oxarbitrage any opinion on whether build-chain-no-features also needs to run on +beta or other platforms besides ubuntu?

When we do individual crate builds, they should also build on beta/nightly. Not so sure about other platforms.

Included for the existing zebra-chain one, when we do the rest we should do the same.


tests: Update to new testlib

Since Cockpit version 228 we don't have anymore that 'Reuse my password'
checkbox on the login page. But old testlib (functions like login_and_go())
try to use this checkbox. Therefore we need to use newer library.
Also authorized was replaced by superuser.
See https://github.com/cockpit-project/cockpit/commit/ef97e7e9a28a

TestService.testNonAdminUser does not work as expected. Needs to be looked at.

Thanks a lot Matej!

TestService.testNonAdminUser does not work as expected. Needs to be looked at.

Weird. @jkozol could you have a look?

@marusak I updated how our error state displays in #1110 so this test should pass now

@marusak Can you rebase this on top of master? I believe the tests will now pass.

Can you rebase this on top of master? I believe the tests will now pass.

There are no conflicts and tests automatically rebase, so just retrying should be fine.

tests automatically rebase

Oh awesome! I didn't know that.


review parse:properties

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d77cf12) 95.06% compared to head (b1f656b) 95.06%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   95.06%   95.06%
=======================================
  Files          21       21
  Lines         162      162
  Branches       14       14
=======================================
  Hits          154      154
  Misses          8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BE] update customer data also on customer.source.updated webhook

Coverage increased (+0.02%) to 92.457% when pulling fbbe9e25a45cf6b9816727f15a54ce3774d0fe86 on feature/correct-customer-update into 2f64cb34d21889c104d19b2f04086eb832dca63a on master.


ALB is not created on AWS

Hello,
We are not able to create an ALB in aws and below are steps we followed to create an ALB.
The cluster is created using Kops.
One of the node is attached to the policy. (https://github.com/kubernetes-sigs/aws-alb-ingress-controller/blob/master/docs/examples/iam-policy.json)
Here are my configs:
# Application Load Balancer (ALB) Ingress Controller Deployment Manifest.
# This manifest details sensible defaults for deploying an ALB Ingress Controller.
# GitHub: https://github.com/kubernetes-sigs/aws-alb-ingress-controller
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: alb-ingress-controller
  name: alb-ingress-controller
  # Namespace the ALB Ingress Controller should run in. Does not impact which
  # namespaces it's able to resolve ingress resource for. For limiting ingress
  # namespace scope, see --watch-namespace.
  namespace: kube-system
spec:
  replicas: 1
  selector:
    matchLabels:
      app: alb-ingress-controller
  strategy:
    rollingUpdate:
      maxSurge: 1
      maxUnavailable: 1
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        app: alb-ingress-controller
    spec:
      containers:
        - args:
            # Limit the namespace where this ALB Ingress Controller deployment will
            # resolve ingress resources. If left commented, all namespaces are used.
            # - --watch-namespace=your-k8s-namespace

            # Setting the ingress-class flag below ensures that only ingress resources with the
            # annotation kubernetes.io/ingress.class: "alb" are respected by the controller. You may
            # choose any class you'd like for this controller to respect.
            - --ingress-class=alb

            # Name of your cluster. Used when naming resources created
            # by the ALB Ingress Controller, providing distinction between
            # clusters.
            - --cluster-name=xxxxx

            # AWS VPC ID this ingress controller will use to create AWS resources.
            # If unspecified, it will be discovered from ec2metadata.
            - --aws-vpc-id=vpc-xxxxx

            # AWS region this ingress controller will operate in.
            # If unspecified, it will be discovered from ec2metadata.
            # List of regions: http://docs.aws.amazon.com/general/latest/gr/rande.html#vpc_region
            - --aws-region=xxxxxx

            # Enables logging on all outbound requests sent to the AWS API.
            # If logging is desired, set to true.
            # - ---aws-api-debug
            # Maximum number of times to retry the aws calls.
            # defaults to 10.
            # - --aws-max-retries=10
          env:
            # AWS key id for authenticating with the AWS API.
            # This is only here for examples. It's recommended you instead use
            # a project like kube2iam for granting access.
            #- name: AWS_ACCESS_KEY_ID
           #   value: XXXXX

            # AWS key secret for authenticating with the AWS API.
            # This is only here for examples. It's recommended you instead use
            # a project like kube2iam for granting access.
            #- name: AWS_SECRET_ACCESS_KEY
              #value: XXXXXX
          # Repository location of the ALB Ingress Controller.
          image:<PHONE_NUMBER>97.dkr.ecr.us-west-2.amazonaws.com/aws-alb-ingress-controller:v1.0.0
          imagePullPolicy: Always
          name: server
          resources: {}
          terminationMessagePath: /dev/termination-log
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      securityContext: {}
      terminationGracePeriodSeconds: 30
      serviceAccountName: alb-ingress
      serviceAccount: alb-ingress

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: alb-ingress
  namespace: default
  annotations:
    kubernetes.io/ingress.class: alb
    alb.ingress.kubernetes.io/scheme: internet-facing
  labels:
    app: alb-ingress
spec:
  rules:
    - http:
        paths:
          - path: /*
            backend:
              serviceName: "my-service"
              servicePort: 80

After deploying the controller and ingress getting below error.
"msg"="Reconciler error" "error"="failed to find existing LoadBalancer due to RequestError: send request failed\ncaused by: Post https://elasticloadbalancing.us-east-1a.amazonaws.com/: dial tcp: lookup elasticloadbalancing.us-east-1a.amazonaws.com on <IP_ADDRESS>:53: no such host"  "Controller"="alb-ingress-controller" ”}
Is there any additional permission or setup required for node to talk to aws automatically ?

Hi, the alb pod is not able to talk to elb per error: dial tcp: lookup elasticloadbalancing.us-east-1a.amazonaws.com on <IP_ADDRESS>:53: no such host
Do you have internet gateway or nat gateway for the subnet where you run alb-ingress-controller pod?

Hi,
Yes we have a internet gateway attached to the subnet.!!

is VPC DNS a requirement?


[Question] Async Commands

Is it currently possible to run an async command, e.g. a download?

It is, but you will need to call a appropriate function to launch the appropriate run-loop for what you're using.
I-e, for libdispatch:
dispatch_main()

Or NSRunLoops run method for a Cocoa run loop.

Thanks for the info!


How to make sendDigits play DTMF locally?

Description
I added a button to call call.sendDigits() to a gather verb on the backend. The DTMF tones are not audible on my client. Is there a way to play the DTMF tones locally? I was able to verify this issue in ios 12 and ios 13.
Thanks in advance.
Steps to Reproduce

Press the call button
Wait for a connection then press a custom button to call sendDigits (seen below)
When pressed, the DTMF tones are not audible locally.

Code
@IBAction func sendDigits(_ sender: Any) {
        if let call = self.call {
            call.sendDigits("12345#")
        }
    }

Expected Behavior
I'd like to be able to hear DTMF tones locally.
Actual Behavior
I'm unable to hear DTMF tones locally.
Reproduces How Often
100%
Voice iOS SDK
Twilio SDK 5.0 via cocoapods
Xcode
Xcode 11
iOS Version
12.4 and 13.1.2
iOS Device
iPhone 6 Plus (12.4)
iPhone 7 Plus (13.1.2)

The only somewhat relevant thing I could find was this:
[CLIENT-3611] Added DTMF tone local playback when TVOCall.sendDigits is called.
located here: https://www.twilio.com/docs/voice/voip-sdk/ios/2x-changelog#200-beta9-may-11-2017

Hi @paxtonhare
Thanks for reaching out. The 5.0 SDK currently does not support tone on the local client when calling the .sendDigits() method. We will investigate with the current codebase and evaluate.
Cheers,
-bobie

Same question, just tried on 6.0 iOS SDK to iPhone with iOS14, there's no tone on local client on  .sendDigits("1"). However the callee can hear the tone. Please take a look. Thanks.


Could not load 'burst mode' photos

There is a problem with 'burst mode' photos, if you have those kind of photos in library, app crashes.
It's not a problem for my app currently, I can skip those photos, so I just checking if photo is in burst mode in fetchAssets() method, and don't append them to assets, but that's suggestion if you want to show these. My 'solution':
private func fetchAssets() {
......
let result = PHAsset.fetchAssetsWithMediaType(.Image, options: options)
result.enumerateObjectsUsingBlock { obj, _, _ in
if let asset = obj as> PHAsset {
if(asset.burstIdentifier == nil){
self.assets.append(asset)
}
}
}
}

@markotl88 Thanks for pointing this out. Fixed this in the last tag. It's a bug in PHImageManager that doesn't return an image when the asset represents a burst image. Requesting the image data works though.


Register on ips not work

User cannot register
My error:
Error: Class "IPS\steam\extensions\core\MemberSync\Login" not found (0) #0 /var/www/vhosts/clan-rmg.com/httpdocs/applications/steam/extensions/core/MemberSync/memberSync.php(34): IPS\steam\extensions\core\MemberSync\_memberSync->onValidate() #1 /var/www/vhosts/clan-rmg.com/httpdocs/system/Member/Member.php(4263): IPS\steam\extensions\core\MemberSync\_memberSync->onCreateAccount() #2 /var/www/vhosts/clan-rmg.com/httpdocs/system/Member/Member.php(490): IPS\_Member->memberSync() #3 /var/www/vhosts/clan-rmg.com/httpdocs/applications/core/modules/front/system/register.php(568): IPS\_Member->save() #4 /var/www/vhosts/clan-rmg.com/httpdocs/applications/core/modules/front/system/register.php(242): IPS\core\modules\front\system\_register::_createMember() #5 /var/www/vhosts/clan-rmg.com/httpdocs/applications/core/modules/front/system/register.php(105): IPS\core\modules\front\system\_register->_registrationForm() #6 /var/www/vhosts/clan-rmg.com/httpdocs/init.php(934) : eval()'d code(27): IPS\core\modules\front\system\_register->manage() #7 /var/www/vhosts/clan-rmg.com/httpdocs/system/Dispatcher/Controller.php(118): IPS\core\modules\front\system\nexus_hook_register->manage() #8 /var/www/vhosts/clan-rmg.com/httpdocs/system/Dispatcher/Dispatcher.php(153): IPS\Dispatcher\_Controller->execute() #9 /var/www/vhosts/clan-rmg.com/httpdocs/index.php(13): IPS\_Dispatcher->run() #10 {main}
#0 /var/www/vhosts/clan-rmg.com/httpdocs/init.php(1036): IPS\_Log::log() #1 [internal function]: IPS\IPS::exceptionHandler() #2 {main}

@kacx9c do you have any idea where this comes from?

Duplicate https://github.com/kacx9c/steam/issues/18


[bug]: Model's "default width/height" settings are not applied in Canvas mode

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Windows
GPU vendor
Nvidia (CUDA)
GPU model
RTX 3070
GPU VRAM
8GB
Version number
4.2.1
Browser
Chrome 124.0.6367.158
Python dependencies
{
"accelerate": "0.29.2",
"compel": "2.0.2",
"cuda": "12.1",
"diffusers": "0.27.2",
"numpy": "1.26.4",
"opencv": "<IP_ADDRESS>",
"onnx": "1.15.0",
"pillow": "10.2.0",
"python": "3.10.11",
"torch": "2.2.2+cu121",
"torchvision": "0.17.2+cu121",
"transformers": "4.39.3",
"xformers": "0.0.25.post1"
}
What happened
I set default width/height for a model, and if I use this button in "Generation" tab then it's applied correctly:

But if I do the same thing in "Canvas" tab, then it's not applied:

Other settings are applied correctly, the problem is only with width/height.
What you expected to happen
Default settings should be applied correctly in Canvas mode.
How to reproduce the problem

Start the app.
Open "Models" tab.
Choose any model and apply default width/height.
Open "Canvas" tab.
Choose model you edited in step "3".
Click on "Default settings" button.

Additional context
No response
Discord username
svyaga

Invoke v5 features a full rewrite of the canvas. Please create a new GH issue if the problem still exists in the new canvas UI.


Move the coinbase decryption check to the transaction verifier

Motivation
This slow check should be done in parallel with the other transaction checks:
https://github.com/ZcashFoundation/zebra/blob/1cbc06aa64673e070c791e0205ae07d38514be9d/zebra-consensus/src/block.rs#L193
This change might make Zebra a bit faster, and it improves DoS-resistance.

redistributing issues that can be separately worked from Epic #2311

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @gustavovalverde @jvff @oxarbitrage @teor2345 @upbqdn

This cleanup isn't needed, unless it shows up in performance profiles.


docs: add motivation + first steps to README.md

Proposed changes
@cgardev gave feedback about project (thanks a lot :heart:). Seems motivation / purpose to use this library isn't clear from beginning. To fix it:

Adding motivation to README.md (and docs home)
Add first steps to README.md (so they're also visible from repo / NPM, not only from docs site)

Quick reminders

🤝 I will follow Code of Conduct
✅ No existing pull request already does almost same changes
👁 Contributing docs are something I've taken a look at
📝 Commit messages convention has been followed
💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
⚙ API Report has been updated if API surface is altered.

#408  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


Election functions complete w tests

Added election functions for Limited, Bloc, SNTV, SNTV-STV Hybrid, and Top Two, along with a testing file

@jamesturk @jgibson517 PR is now updated with end of week objectives. Here are some assorted comments:

Added graphs.py file which contains PairwiseComparisonGraph object. This will likely get folded into a file with the ballot graph, or share a subfolder with it. Added tests for all methods in test_graphs.py.
Added metrics.py file which contains only borda_scores, a function that computes a dictionary of borda scores for an election. This belongs in a class of general utility methods to get data about any preference profile we want  (ie first place votes, borda scores, etc). It will probably wind up with a different name under the metrics subfolder. Added tests_metrics.py.
Added election systems for DominatingSets and CondoBorda (using PWC graph) into election_types.py, along with new tests for those in election_tests_2.py
Slightly modified election_state.py code so that it doesn't require results be lists of strings, it now allow lists of, well, anything, but relevantly sets which will track ties in the outcome (we should likely fully transition outcomes to be sets to allow ties and mirror Ballot at some point)

@jamesturk @jgibson517 @realdavemccune Made changes in line with James' comments, the most extensive of which are a merge and rewrite of the remove_cand/remove_cand_sets functions, a rewrite of the PreferenceProfile eq function, along with corresponding tests, and the addition of a Ballot eq function


ci(scanner): stop building single-bundle dev vulns

Description
These are no longer needed for current and future releases, so why bother making them?
User-facing documentation

[x] CHANGELOG update is not needed
[x] documentation PR is not needed

Testing and quality

[x] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
[x] CI results are inspected

Automated testing

[x] modified existing tests

How I validated my change
Added pr-update-scanner-vulns label. Check out the dev vulns job and see this no longer runs

This is no longer needed after https://github.com/stackrox/stackrox/pull/12370


wasm: route matching for http filter

It might be useful if Envoy allows users to specify when to call the Wasm callbacks, just like jwt filter. This would reduce the cost of calling back and forth between Envoy and Wasm VMs when users want to apply custom logics on the specific paths. cc @PiotrSikora @lizan

This is not unique to Wasm, see: https://github.com/envoyproxy/envoy/issues/11690.


Detect Babel reexports with conflict filter for other exports

Fixes https://github.com/guybedford/cjs-module-lexer/issues/36

Thanks so much for this, funny how it came at the same time as a TS and Rollup issue as well.


Add Error Serializers for custom and nested errors

What is it?

[X] Feature / enhancement
[X] Bug
[ ] Docs / tests

Description
This PR enables the serialization and deserialization of Error and Custom Error objects.
It serializes and deserializes primitive values and rebuilds nested Error objects in a targeted fashion.
The serializeError function takes an Error or Custom Error object as input and clones its primitive values using the cloneErrorPrimitives function before returning the resulting object in a JSON string format.
The deserializeError function takes a serialized Error object string as input and converts it back into an Error or Custom Error object with only the necessary primitive values. It accomplishes this by parsing the input string into an object, extracting the needed values and creating a new Error object with those values. If the input string contains nested Error objects, it will rebuild them by calling the deserializeDeepErrors function.
The cloneErrorPrimitives function recursively extracts all primitive values from an object or array, including handling of circular references, pruning the stack trace from Error objects, and returning a new object with only primitive values. This function is called by serializeError to extract the necessary values from the Error object.
Finally, the deserializeDeepErrors function rebuilds any nested Error objects that were serialized. It takes the rebuilt Error objects and inserts them back into the appropriate locations within the parent Error object.
Use cases and why
As-is implemented, a simple string is *NOT* enough.

Complete Error and Custom errors are necessary when working with many backend systems.
Some backend systems such as GraphQL servers even return nested errors arrays which would be lost with the existing serializer, reducing the top level error to a string that is recreated on deserialization.
Other systems use fields like code and status which are not supported.
Other workarounds like simply using JSON.stringify() and JSON.parse() on an error or custom error objects is not natively simple due to issues like: a) circular references, and b) needing to reconstitute the nested errors on deserialization.

Related Conversation in Discord: HERE
Checklist:

[X] My code follows the developer guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[1/2 ] Added new tests to cover the fix / functionality

Validation object provided for custom error testing.

Test File
Here is an `index.tsx` test file that exercises the serializer. I have also used it in a staged system through `server$` boundaries.
import { $, component$ } from<EMAIL_ADDRESS>import { deserializeError, serializeError } from '~/utils/errorSerializer';

class CustomError extends Error {
  custom: any;

  constructor(message: string, custom?: any) {
    super(message);
    this.custom = custom;
  }
}

export default component$(() => {

  const simpleErrorTest = $(() => {
    const xErr = new CustomError("Deep X-Error!", 1234);
    const serErr = serializeError(xErr);
    console.log("serErr:", serErr);
    const desErr = deserializeError(serErr);
    console.log("desErr:", desErr);
    console.log("desErr:", JSON.stringify(desErr));
  });

  const deepErrorTest = $(() => {
    const validate = {
      e1: new Error("Standard Error"),
      c: {},
      o: {
        e2: new CustomError("Custom Error", {
          e3: new Error("Super Deep Standard Error"),
        }),
        c: {},
        stack: "keep me",
        n: null,
        b: true,
        v: 123,
        s: "abc",
        u: undefined,
        f: () => "function!",
      },
      stack: "keep me",
      n: null,
      b: true,
      v: 123,
      s: "abc",
      u: undefined,
      f: () => "function!"
    };
    validate.c = validate;
    validate.o.c = validate;

    const xErr = new CustomError("Deep Error!", validate);
    const serErr = serializeError(xErr);
    console.log("serErr:", serErr);
    const desErr = deserializeError(serErr);
    console.log("desErr:", desErr);
    console.log("desErr:", JSON.stringify(desErr));
  });

  return (

Test Error Serialization

Serialize errors to JSON and back again. Stack and functions are not serialized and prevents circular reference.

    <button onClick$={simpleErrorTest}>Simple Error Test</button>

    <button onClick$={deepErrorTest}>Deep Error Test</button>

);
})

Thanks @zanettin, didn't realize pnpm fmt was a thing. Updated the checkin.
I have Prettier installed, but I can't figure out why it formats some .ts files with two indents and others with four. I have vscode defaults set to Prettier, even. It drives me crazy.

@manucorporat, I have added Dynamic Error Class generation during deserialization so that the constructor.name comes through.

This is amazing work! i am a little concerned about the amount runtime added just to solve this issue, need to run it with the team

OPTIMIZED -- PERF NOW SAME AS OLD OPTIMIZER FOR NATIVE ERRORS!
@manucorporat, thanks for the comment. I've gone back and reviewed the new error serializer, and in several places heavily optimized it to perform as well as the old serializer. The added advantage of this is it now support custom errors and deep object errors. -- Please take a looks. There may be was to further optimize it, and welcome you throughs. Please see the attached screenshot of benchmarks from test page (above).

OPTIMIZED PERFORMANCE
EQUAL TO OLD OPTIMIZER WITH BETTER NATIVE AND CUSTOM ERROR SUPPORT
@manucorporat, I've gone back and reviewed the new error serializer and optimized it to perform as well as the old serializer (maybe a bit better). The added advantage of this is it now supports custom errors and deep error objects (like from GraphQL errors). There may be ways to further optimize it and welcome you throughs.  Classnames were not possible without evaluating a class inline which would be unsafe but prototype.name work well now.
Please see the attached screenshot of benchmarks run with the test page provided. The page also has tests that can be migrated to a unit test.

 New Error Serializer Test on StackBlitz
New Error Serializer Test on StackBlitz

NEW: Deep Error Mitigation
I had an idea to further optimize error serialization. In version 2, the error serializer **always** mitigates what error data is send back. A developer may not realize a custom error could have additional objects and there is no point in transferring them if they are not to be consumed.
To transfer errors with custom fields or deep objects, such as in GraphQL, the developer must add the __qDeep flag to the error object. If this flag is present, only then will the error with custom fields/objects be serialized over the wire. The __qDeep flag is automatically be stripped out during the deserialization process.
I have updated the StackBlitz ( HERE ) with both versions to explore, but think I like Version 2 better to avoid unnecessary data serialization.


"GitHub repo file count" counts not all files

Are you experiencing an issue with...
shields.io
🐞 Description
Repo cn007b/stash has many directories and each directory holds many files,
but GitHub repo file count from https://shields.io/category/size returns only 4, here:
which is definitely incorrect, for example only this directory has 14 files.
🔗 Link to the badge
https://img.shields.io/github/directory-file-count/cn007b/stash
💡 Possible Solution
Probably GitHub repo file count should iterate over all files over all directories recursively,
it might be expensive in terms of processing time,
probably some sort of caching must be introduced,
but it would be nice to have this insights, IMHO.

I think the existing example is a bit misleading in the way it is labelled.
https://img.shields.io/github/directory-file-count/cn007b/stash is a (non-recursive) count of files (and directories) in the root of https://github.com/cn007b/stash which is not totally clear from the docs/example.
At the moment this badge shows non-recursive counts but it looks like we probably could provide recursive counts in a performant way at least at the repo level. For example
https://api.github.com/repos/badges/shields/git/trees/master?recursive=true
https://api.github.com/repos/cn007b/stash/git/trees/master?recursive=true
return a response pretty quickly even given the large number of files, although there are some notes on limitations at https://docs.github.com/en/rest/git/trees?apiVersion=2022-11-28#get-a-tree
The downside of the tree API is that it doesn't allow filtering by directory so we couldn't do recursive counts for a subdir by the looks of it.
@calebcartwright - you reviewed the original PR where this badge was added (albeit some time ago), do you have any thoughts on the design decisions behind this one?


Implement full consensus mechanism

This issue serves as an epic story to keep track of the process to go from 'consensus light' (0.2) to a full consensus mechanism using Aleph BFT.
More tasks will be added here as we learn more on how to accomplish this. Ideally some of these subtasks can already be implemented in intermediate milestones before rolling out full consensus.
Iteration 1:

#1531
#1559
#1560
#1561
#1562
#1563
#1564
#1565
#1566

Exploration issues:

#1258
#1277
#1396

The sequence in iteration 1 looks like this:
sequenceDiagram
actor user
participant NodeX as NodeX
(regular)
participant NodeA as NodeA
(authority)
participant NodeB as NodeB
(authority)
participant NodeC as NodeC
(authority)
participant NodeD as NodeD
(authority)

participant BuildTopic
participant ConsensusTopic
participant BlockTopic

note right of BuildTopic: authority nodes
listen to BuildTopic
messages
note right of ConsensusTopic: authority nodes
listen to ConsensusTopic
messages
note right of BlockTopic: all nodes
listen to BlockTopic
messages

user ->> NodeX: request build
NodeX ->> NodeX: find leading authority node
NodeX ->> NodeA: request build

NodeA ->> NodeA: check if build
request is valid
NodeA ->> NodeA: perform build

NodeA --) BuildTopic: send build message to topic

par Perform Build
NodeB ->> NodeB: perform build
NodeB ->> NodeA: send build finished p2p command
NodeC ->> NodeC: perform build
NodeC ->> NodeA: send build finished p2p command
NodeD ->> NodeD: perform build
NodeD ->> NodeA: send build finished p2p command
end

NodeA ->> NodeA: wait for all builds to finish
NodeA ->> NodeA: create transparency logs
create block
create consensus message

NodeA --) ConsensusTopic: send consensus message
par Verify build
NodeB ->> NodeB: verify build
NodeB ->> NodeA: send consensus reply
NodeC ->> NodeC: verify build
NodeC ->> NodeA: send consensus reply
NodeD ->> NodeD: verify build
NodeD ->> NodeA: send consensus reply
end

NodeA ->> NodeA: verify all signatures
from the consensus messages
add signatures to the block
and commit block

NodeA ->> NodeA: put artifacts in local storage
and provide on p2p network

NodeA --) BlockTopic: distribute new block

par Block distribution
NodeB ->> NodeB: verify and store block
NodeC ->> NodeC: verify and store block
NodeD ->> NodeD: verify and store block
NodeX ->> NodeX: verify and store block
end

https://docs.google.com/document/d/1D00F9Z-GfbnHhH7hdBx6-OJmCfqTjlMUkUMdjTWg1js/edit?usp=sharing


[BUG] Disable rule in file appends the disable comment at the end of the file

FAQ

[X] I have checked troubleshooting and it didn't resolve my problem.

Issues

[X] I have checked existing issues and there are no issues with the same problem.

Neovim Version
0.5.0
Steps to reproduce
Open a javascript file with some error eslint errors in it.
Launch code actions and select disable rule for the entire file.
Expected behavior
The comment disabling the rule should appear at the beginning of the file.
Actual behavior
The comment disabling the rule appears at the end of the file.
Debug log
No response
Help
No
Implementation help
No response

Whoops! Should be fixed by 685f88c069dbdf013960523958cf874c7d39cbdd. Can you update and let me know?

Yes, fixed with that commit.
Thanks for your work!


Add waitForIdle call to fix action bar test flakiness.

CI failure mentions a timeout to "jcenter.bintray.com:443", so I don't think it's related to this change.

We're seeing this across repos.  Might be a jCenter outage.
On Tue, May 29, 2018 at 5:01 PM Revan Sopher<EMAIL_ADDRESS>wrote:

CI failure mentions a timeout to "jcenter.bintray.com:443", so I don't
think it's related to this change.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/firebase/quickstart-android/pull/519#issuecomment-392987199,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIEw6um68AlG3GcpUoc7XXA9ECX6OR8lks5t3eFKgaJpZM4USYzP
.


Refactor tkn pac CLI

this renames following command
tkn pac repo create -> tkn pac create repo
tkn pac repo delete -> tkn pac delete repo
tkn pac repo list -> tkn pac list
tkn pac repo descrie -> tkn pac describe
Changes

Submitter Checklist

[ ] ♽  Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
[ ] 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
[ ] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
[ ] 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

Codecov Report

Merging #711 (2af5201) into main (1d316fd) will decrease coverage by 1.81%.
The diff coverage is 6.45%.

@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   67.93%   66.11%   -1.82%
==========================================
  Files          68       67       -1
  Lines        4011     3952      -59
==========================================
- Hits         2725     2613     -112
- Misses       1019     1083      +64
+ Partials      267      256      -11

Impacted Files
Coverage Δ

pkg/cli/webhook/secret.go
0.00% <0.00%> (ø)

pkg/cmd/tknpac/create/root.go
0.00% <0.00%> (ø)

pkg/cmd/tknpac/describe/describe.go
44.11% <0.00%> (ø)

pkg/cmd/tknpac/list/list.go
33.33% <0.00%> (ø)

pkg/cmd/tknpac/create/repository.go
33.78% <25.00%> (ø)

pkg/git/git.go
68.00% <0.00%> (-6.36%)
:arrow_down:

pkg/adapter/sinker.go
66.66% <0.00%> (-6.07%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d316fd...2af5201. Read the comment docs.

any chance to have the doc update at the same time ?

/retest

updated docs!
CI passed earlier now failed for some other reason
not runnning it again as not a code changes in latest commit

I haven't tested it and we have no test for it :-D
so I guess yolo and go!
(talkign about test maybe we can do a simple shell based test scenario  like we have on tektoncd/cli https://github.com/tektoncd/cli/blob/main/test/e2e-tests.sh#L41 should be easy to setup and it would detect a bunch of error)


[SUGGESTION] Binding a job to a region (WE)

Binding a job to a WorldEdit region
Make it so that the task can be taken and performed only in a certain region of WorldEdit.
For example, the lumberjack job only works in the "sawmill" region (automatically set when you enter, and removed when you leave).
I think this will be very convenient for creating "work zones"

Hello, I think something like a work-zone-implementation would be good. Something like the economy-implementation but for work zones. I will for sure work on things like this.

One year later this is now being worked on. If anyone has any plugin suggestions to be added make sure to let me know. As I'm writing this message the following plugins are supported: WorldGuard, GriefPrevention.

This feature is marked as done but it hasn't been released yet as I am now working on different platform support. You can still download the version you want from GitHub actions and use a experimental build.


Request: Suppress temperature devices

I'd love to be able to suppress the temperature devices from being exposed to Homekit. It messes with my automation that uses climate devices in the Kitchen :)

Sounds like a good idea! I’ll tackle it in the near future.

4 minutes of testing and it seems to be working great!


updated readme for the link of display pattern of date picker and num…

…eric input

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

@rismehta comments are resolved


Fix error when not company found

Fix following error :
λ presskit ..\product-presskit\
Starting directory: ..\product-presskit\

Finding data…
- product: "My Super Game" ..\product-presskit\data.xml

Generating HTML…
C:\Users\Coac\Documents\Projects\presskit\lib\core\generator.js:119
        company: pages.company.presskit,
                              ^

TypeError: Cannot read property 'presskit' of undefined
    at generateHTML (C:\Users\Coac\Documents\Projects\presskit\lib\core\generator.js:119:31)
    at Object.generate (C:\Users\Coac\Documents\Projects\presskit\lib\core\generator.js:36:3)
    at parseEntryPoint (C:\Users\Coac\Documents\Projects\presskit\lib\index.js:30:15)
    at fs.stat (C:\Users\Coac\Documents\Projects\presskit\lib\index.js:48:7)
    at FSReqWrap.oncomplete (fs.js:153:5)

occured when using presskit ..\product-presskit\ on a folder containing only one product and no company.

Hello,
Thanks for your contribution.
However, the problem was more concealed than it appears. This case was already handled, but this condition was too strict and didn't handle trailing slash. That's why you had this error (the generator should have shown "your top level page is not a  page" instead of the error).
A warning though: a presskit should have a company page. The main page is different from the others, and if you use a product as the company, it will have some issues (address, socials, etc.).
You can get the fix in the 0.6.3.
Cheers.


dart:mirrors does not yet work with --preview-dart-2

This code prints false when running with --preview-dart-2.
import 'dart:mirrors';

enum Enum {
  option1, option2
}

void main() {
  final isEnum = reflectClass(Enum).isEnum;
  print("${isEnum}");
}

Support for dart:mirrors is currently unimplemented with --preview-dart-2.  Some things will happen to work, but nothing is guaranteed to work.  The things that happen to work today might randomly break tomorrow.
As far as I know, we have not made any official decision about supporting dart:mirrors on the Dart VM.  It is not supported one the Web in Dart 2.0 (#30538) and it's also not supported in the Flutter mobile development framework (https://github.com/flutter/flutter/issues/1150).

And now I do know: we have made an official announcement that dart:mirrors will continue to be fully supported on the Dart VM in Dart 2.0.  It is here: https://groups.google.com/a/dartlang.org/d/msg/misc/djfFMNCWmkE/F7WE8a0JAwAJ

Thanks very much for the info, will continue to track issue

The root cause of the enum not being report as 'isEnum' might be the same one as in #32365

Phew, I'm glad dart:mirrors will continue to be supported, without it my code generation would be come a bit cumbersome...
Also walked into the isEnum bug, but I see it is already fixed in the other thread (so will have to wait for a new dev release now)

Also running into issues with preview Dart 2. Package unscripted [0] requires dart mirrors fetching method parameters and it fails with a runtime type issue:
type 'List' is not a subtype of type 'List' of 'function result' where
List is from dart:core
List is from dart:core
ParameterMirror is from dart:mirrors
dart:mirrors                                                                _LocalMethodMirror.parameters
[0] https://github.com/seaneagan/unscripted/blob/master/lib/src/util.dart#L38

@vsmenon do you have any needs here?

@jmesserly
Not that we're aware of at this point.  The CFE recently added support for parameter annotations (which we needed for temporary pageloader support).

As far as I know, mirrors has enough support for DDC+Kernel. We have limited test coverage though, outside of the internal use of pageloader. (When I've regressed something in DDC+Analyzer mirrors, I don't find out until we roll the SDK.)

It appears that there are a number of VM mirrors tests that are marked as failing in the status files which indicates we still have a number of issues with dart:mirrors functionality in --preview-dart-2 mode.

I started to try to fix the failing mirrors tests.  At least some of them are incorrect tests.  We could argue about them on a case-by-case basis, because the current VM behavior is "incorrect" by that standard and changing the VM's behavior is a breaking change.
For example, in Dart 2 the classes defined by anonymous mixin applications should always be abstract, otherwise you will get Dart 2 static errors for any abstract members of the mixed-in class.  One of the lib_2/mirrors tests tests that they are not abstract.

Another example: if an object that is not a Function is passed as the first argument to Function.apply, we will tear off the object's call method and pass that.  If it is invoked with an  incorrect number of arguments, that will not invoke the original object's noSuchMethod.  lib_2/mirrors/apply3_test is broken for this reason.
So far, every test I've looked at is a test that was incorrectly ported from Dart 1.  We'll need to fix them eventually but it isn't a high priority right now.

So far, every test I've looked at is a test that was incorrectly ported from Dart 1. We'll need to fix them eventually but it isn't a high priority right now.

yeah, I saw that when I moved these tests to lib_2/mirrors :\ ... a lot of tests in lib_2/corelib_2/language_2 still don't expect correct runtime behavior for Dart 2. I think the function call tearoff thing happened after the Dart 2 test migration, though. My guess is: we didn't update the tests after the call tearoff change, because many Dart 2 impls lack mirrors support, so it was hard to notice the test problem.

If there is any way to contribute here as an outsider, please let me know. The issues with mirrors and --preview-dart-2 flag are blocking many of Aqueduct tests. I am anxious that this issue may get deferred until after Dart 2 release or late enough in the process that will delay us releasing with Dart 2. I recognize that there are many other priorities and y'all are killing it, but I did want to express that concern.

We're definitely aware of this concern. A prioritized list of APIs that you
need would be very helpful.
On Tue, May 22, 2018 at 12:42 PM Joe Conway<EMAIL_ADDRESS>wrote:

If there is any way to contribute here as an outsider, please let me know.
The issues with mirrors and --preview-dart-2 flag are blocking many of
Aqueduct tests. I am anxious that this issue may get deferred until after
Dart 2 release or late enough in the process that will delay us releasing
with Dart 2. I recognize that there are many other priorities and y'all are
killing it, but I did want to express that concern.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/32345#issuecomment-391116170,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACAsW76fx9eLSaMWNJF-EcKG2UwXQwMQks5t1GoPgaJpZM4SV7lE
.

To echo what @dgrove said, we could definitely use help identifying the high priority issues that affect you and your tests.  You can file separate issues for them and just tag me for triage.
Eventually we will fix all those bugs (and probably modernize the API for Dart 2 features), but for now we want to prioritize fixing bugs "on demand" when we know that they are affecting customers.

Very much appreciated. I've added #33207 and will tag you shortly.

@kmillikin - can we close this? I think mirrors are working now in the VM?

all reported issues against dart:mirrors has been fixed after the switch to Dart 2.


[bug] rh-button Devs need to be able to set the role attribute on rh-button

Describe the bug

Description of the issue
Devs need to be able to set the role attribute on pf-button. For example, I am using pf-button as a tab control and I need to set the role=tab directly on pf-button in order to follow the proper design pattern for the carousel slider I am working on.
Please see the following link for more info about the carousel design pattern

https://www.w3.org/WAI/ARIA/apg/patterns/carousel/

Impacted component(s)

rh-button
https://github.com/RedHat-UX/red-hat-design-system/tree/main/elements/rh-button

Steps to reproduce

Open a Codepen in Chrome
Import rh-button into a pen
Try to add role="tab" to the rh-button
Inspect the devtools and observe that the role does not get added

Expected behavior
The role attribute is added to the button in the shadow root with whatever the user needs the role to be, in my case "tab".

This is a sev-2 issue at least because this is causing a very inaccessible experience for cp-slider
Related Issue

https://github.com/patternfly/patternfly-elements/issues/2805

Screenshots
No response
Steps to reproduce
Please see description of the issue.
Expected behaviour
Please see description of the issue.
Element HTML
<rh-button>
  button text
</rh-button>

Operating System (OS)
Windows
Browser
Chrome
Additional browser or assistive technology info
No response

This change in pfe could help here
https://github.com/patternfly/patternfly-elements/pull/2707

@bennypowers I think I am just going to close this issue. I think the ultimate fix for the problem is to get a carousel slider component added into rhds which uses its own tabs buttons rather than having to add custom roles to rh-button.

Also the change to pf-button solves the issue I am dealing with temporarily so I am unblocked.


Handle bottom antecedent in cterm_implies better

Blocked on: https://github.com/runtimeverification/haskell-backend/issues/3484
This is to have better reporting of when branches trivially go to #Bottom when doing all-path reachability proofs. We should have a way of signaling that the antecedent to an implies check is #Bottom to the consumer directly.

Subsumed: https://github.com/runtimeverification/pyk/pull/190


Added the translated (hungarian) version of Guides/HTML index.md

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hello.
Sorry for that. Yesterday was my first time on github. I will do these two than.
Thank you for your reply.
Csongor


Remove extraneous extra byte in Hdlr size.

Causing an issue in meta container parsing.
Added a log message because I ran into this error: decode moov: decode meta: Non-matching children box sizes.
  Logging Patch
// DecodeContainerChildren decodes a container box
func DecodeContainerChildren(hdr *boxHeader, startPos, endPos uint64, r io.Reader) ([]Box, error) {
	l := []Box{}
	pos := startPos
	for {
		fmt.Printf("parent: %v position: %d\n", hdr.name, pos)
		b, err := DecodeBox(pos, r)
		spew.Dump(b)
		if err == io.EOF {
			return l, nil
		}
		if err != nil {
			return l, err
		}
		l = append(l, b)
		pos += b.Size()
		fmt.Printf("pos: %d endPos: %d\n", pos, endPos)
		if pos == endPos {
			return l, nil
		} else if pos > endPos {
			return nil, fmt.Errorf("Non-matching children box sizes")
		}
	}
}

Output
pos: 152 endPos: 959
parent: moov position: 152
parent: meta position: 164
(*mp4.HdlrBox)(0xc0000664b0)({
 Version: (uint8) 0,
 Flags: (uint32) 0,
 PreDefined: (uint32) 0,
 HandlerType: (string) (len=4) "ID32",
 Name: (string) ""
})
pos: 197 endPos: 293
parent: meta position: 197
(*mp4.UnknownBox)(0xc000066510)({
 name: (string) (len=4) "ID32",
 size: (uint64) 97,
 notDecoded: ([]uint8) (len=89 cap=1536) {
  00000000  00 00 00 00 15 c7 49 44  33 04 00 00 00 00 00 49  |......ID3......I|
  00000010  50 52 49 56 00 00 00 3f  00 00 68 74 74 70 73 3a  |PRIV...?..https:|
  00000020  2f 2f 67 69 74 68 75 62  2e 63 6f 6d 2f 67 6f 6f  |//github.com/goo|
  00000030  67 6c 65 2f 73 68 61 6b  61 2d 70 61 63 6b 61 67  |gle/shaka-packag|
  00000040  65 72 00 76 32 2e 34 2e  33 2d 64 64 39 38 37 30  |er.v2.4.3-dd9870|
  00000050  30 2d 72 65 6c 65 61 73  65                       |0-release|
 }
})
pos: 294 endPos: 293
(interface {}) <nil>
decode moov: decode meta: Non-matching children box sizes

After this change, parsing worked as intended. This was with a shaka packager output as indicated in the meta information.

I don't think this patch is correct.
The extra +1 is there because the name string should be zero-terminated  and the trailing zero is not stored as part of it.
ISO/IEC 14496-12 2015 Sec. <IP_ADDRESS>:  name is a null‐terminated string in UTF‐8 characters which gives a human‐readable name for the track type (for debugging and inspection purposes).
The +1 is matching a -1 in  the DecodeHdlr() method line 68 which does not read the last character:
h.Name = string(data[24 : len(data)-1])

Does your input somehow miss the trailing zero byte?

00000020 68646C72 00000000 00000000 49443332 00000000 00000000 00000000 are the bytes for the hdlr box in question.

Interesting. It is strictly not a valid box it has length 32 and the name string has length 0 but should be zero-terminated The minimal length of the box is therefore 33. However, I don't test for it when decoding, so it slips through that step, and is then hit by the size comparison.
How did you get a box like that?

Replaced by #81. That should fix your case so that you cannot only decode, but also encode this "mutant" box. It includes a test with the box you provided.

Thanks for the details. I'm closing this one and merged #81 which has a proper fix.

Thanks :)
https://github.com/google/shaka-packager/blob/6c8ad30217c286d4eecadc9df12420767d389942/packager/media/formats/mp4/box_definitions.cc#L1308
Went and found the place in shaka packager. Looks like it uses a std::vector, and the id32 hdlr doesn't support outputting any name. So it ends up being missed, and left with the 32 size.


mitmweb - unexpected 500 error when doing flow dumps

Steps to reproduce the problem:
I've had some difficulty creating a standalone reproducer for this. In order to trigger it I changed some addon configuration option values, and then attempted to save the flow.
ERROR:tornado.application:Uncaught exception GET /flows/dump (<IP_ADDRESS>)
HTTPServerRequest(protocol='http', host='<IP_ADDRESS>:8081', method='GET', uri='/flows/dump', version='HTTP/1.1', remote_ip='<IP_ADDRESS>')
Traceback (most recent call last):
  File "/Users/grantmurphy/.local/share/virtualenvs/mitmproxy-h3iGBSQq/lib/python3.6/site-packages/tornado/web.py", line 1541, in _execute
    result = method(*self.path_args, **self.path_kwargs)
  File "/Users/grantmurphy/.local/share/virtualenvs/mitmproxy-h3iGBSQq/lib/python3.6/site-packages/mitmproxy/tools/web/app.py", line 229, in get
    fw.add(f)
  File "/Users/grantmurphy/.local/share/virtualenvs/mitmproxy-h3iGBSQq/lib/python3.6/site-packages/mitmproxy/io/io.py", line 26, in add
    d = flow.get_state()
  File "/Users/grantmurphy/.local/share/virtualenvs/mitmproxy-h3iGBSQq/lib/python3.6/site-packages/mitmproxy/flow.py", line 94, in get_state
    d = super().get_state()
  File "/Users/grantmurphy/.local/share/virtualenvs/mitmproxy-h3iGBSQq/lib/python3.6/site-packages/mitmproxy/stateobject.py", line 31, in get_state
    state[attr] = get_state(cls, val)
  File "/Users/grantmurphy/.local/share/virtualenvs/mitmproxy-h3iGBSQq/lib/python3.6/site-packages/mitmproxy/stateobject.py", line 94, in get_state
    return _process(typeinfo, val, False)
  File "/Users/grantmurphy/.local/share/virtualenvs/mitmproxy-h3iGBSQq/lib/python3.6/site-packages/mitmproxy/stateobject.py", line 77, in _process
    for k, v in val.items()
  File "/Users/grantmurphy/.local/share/virtualenvs/mitmproxy-h3iGBSQq/lib/python3.6/site-packages/mitmproxy/stateobject.py", line 77, in <dictcomp>
    for k, v in val.items()
  File "/Users/grantmurphy/.local/share/virtualenvs/mitmproxy-h3iGBSQq/lib/python3.6/site-packages/mitmproxy/stateobject.py", line 81, in _process
    assert isinstance(val, (int, str, bool, bytes))
AssertionError
ERROR:tornado.access:500 GET /flows/dump (<IP_ADDRESS>) 5.16ms

System information
mitmproxy --version
Mitmproxy: 4.0.1
Python:    3.6.5
OpenSSL:   OpenSSL 1.1.0h  27 Mar 2018
Platform:  Darwin-17.5.0-x86_64-i386-64bit

Added a print("INSTANCE OF " + str(type(val))) above this line and it looks related to something being interpreted as a 'float' in my addon code.
INSTANCE OF <class 'float'>
ERROR:tornado.application:Uncaught exception GET /flows/dump (<IP_ADDRESS>)

I think this can be addressed as a part of #3144.


feat: Implement forget password

Once I complete the sign in page,I will add forget password to it
Description:
The application currently lacks the "Forgot Password" feature, which is crucial for user account recovery. This issue is to implement the necessary pages and functionality required for the "Forgot Password" feature.
Tasks:

Create Forgot Password Page: Develop a new page or modal for the "Forgot Password" functionality.

Steps to Implement:

Design the user interface for entering email addresses for password reset requests.
Implement the frontend components for the Forgot Password page/modal.

Expected Behavior: Users should be able to access the Forgot Password page/modal to initiate the password reset process.

Backend Logic for Password Reset: Develop backend logic to handle password reset requests and send reset instructions to the user's email.

Steps to Implement:

Define API endpoints or backend routes to handle password reset requests.
Implement logic to generate and store password reset tokens securely.
Integrate with email services to send password reset instructions to users.

Expected Behavior: Upon submitting a password reset request, users should receive instructions on how to reset their passwords via email.

can i contribute in this under gssoc'24

Good to go @Niharika0104 and raise up the PR ASAP.

can i contribute in this under gssoc'24

Why not ??😂


fix missing property in JsonTypeInfo of SegmentWriteOutMediumFactory

Currently, we need to do like below when specify the SegmentWriteOutMediumFactory, which is terrible.
druid.peon.defaultSegmentWriteOutMediumFactory.@type: offHeapMemory

Besides, this PR also fixes the docs about SegmentWriteOutMediumFactory.

@QiuMM please don't specify milestones for any non-bug PRs. I know that a lot of people do this, but it's a bad practice. See https://groups.google.com/d/msg/druid-development/QPZUIzLtZ2I/eZyw8BoVCgAJ.

@leventov strongly disagree. I think where possible we should try to assign milestones to PRs we want to get in and aim to have the PR reviewed and merged before then. If the PR needs to be pushed back to a future release we can always do that.

LGTM. I'm merging this PR.
Regarding milestone, @leventov started a thread on our dev mailing list (http://mail-archives.apache.org/mod_mbox/druid-dev/201811.mbox/<CAAMLo=Y_d1tXtgWpt_E7uD7zwh6=rDop-B_3O73HnQwBMRo2TQ@mail.gmail.com>), and so we can continue discussion there.


[Multichain] multi-chain address to Rooch address

I think creating a new address in the resolve function is not a good idea because we can not ensure that the address mapping exists via the resolve function.
Originally posted by @jolestar in https://github.com/rooch-network/rooch/pull/348#discussion_r1241023169
We should migrate the new address generating from the resolve function of address_mapping to

Option 1: Provide a new function resolve_or_generate
Option 2: Put the generating logic to ExecutorActor's rust code.

How to generate a new rooch address from a multi-chain address?

Option 1: hash(multi-chain address)
Option 2: Case by case.  such as for eth, we can use the original eth address and padding zero before the address.

@yubing744 @wow-sven @feliciss

I tend to Option 1

We should migrate the new address generating from the resolve function of address_mapping to

I prefer
Option 2: Put the generating logic to ExecutorActor's rust code.
We can add generate_address in Rust code when the mapping record does not exist.

How to generate a new rooch address from a multi-chain address?

I prefer
Option 2: Case by case. such as for eth, we can use the original eth address and padding zero before the address.
Because there's no common universal solution to hash the multi-chain addresses, such as those using RSA, Diffie-Hellman, ECC signatures, I believe?

Solution:

Provide a new function, resolve_or_generate, and keep the address generating logic in Move.
Generate the rooch address via hash(multi-chain address), for simpler. if we want to keep the original address, we can refactor it after we define the Token standard and Token mapping.


Sidebar doesnt shows on small screens

Hello, thank you for using Themesberg products!
It is meant that way, for mobile devices.


Item B-03902: As a curator, I would like to see all the metadata, even for unassociated schemata

The unassociated schemata are being added in the properties as other approaches likely involve changes to the API.
This is the simplest approach to solving the card as closely as possible without API changes.

Looks like I see a problem, I mis-read the logic of the if-conditional and didn't consider properties that may already be added.

Coverage increased (+0.1%) to 50.984% when pulling 2825cd743ba8d12e05b63e396270f2dd92ba91f8 on sprint-tcdl-b03902-unassociated_schemata into 901822966f53a612fdb3414bdcedf642b6b5df64 on sprint-tcdl-staging.


fix: StdoutException: Could not get terminal size, OS Error: Operation not supported on socket, errno = 102

Description
I'm using the very_good test --coverage command in a pipeline in Azure Devops, and it's returning this error when trying to write the message in the terminal:
"Thank you for using Very Good Ventures open source tools!
Don't forget to fill out this form to get information on future updates and releases here:
https://verygood.ventures/open-source/cli/subscribe-latest-tool-updates"
Steps To Reproduce

Install lastest version 1.17.0
Run very_good test --coverage
See error

Expected Behavior
A clear and concise description of what you expected to happen.
Screenshots

Additional Context
Locally works normally

Hi @rodrigopequeno ! Thanks for reporting the issue.
I would suggest adding an environment variable with a "CI" key and any value (I recommend CI=true), this will completely stop the message showing up.
If that doesn't work, a temporary option is to add a directory to your home named .very_good_cli with a file named version and the content of the file being the current version. This will avoid the message showing up since it is only displayed during the first update.
mkdir ~/.very_good_cli && echo -n '0.17.0' > ~/.very_good_cli/version

Hi @alestiago, I chose to drowngrade the version for now. I will check these solutions as soon as possible.

@rodrigopequeno this should now be fixed with Very Good CLI 0.17.1, feel free to reopen if the bug persists.


Explain more - What is "rectangle rule"?

https://google.github.io/styleguide/jsguide.html#formatting-function-arguments
// If the argument list is longer, wrap at 80. Uses less vertical space,
// but violates the rectangle rule and is thus not recommended.
doSomething(veryDescriptiveArgumentNumberOne, veryDescriptiveArgumentTwo,
	tableModelEventHandlerProxy, artichokeDescriptorAdapterIterator) {
  // …
}

Please explain what is "rectangle rule"

I think it is referring to this rule: https://github.com/google/google-java-format/wiki/The-Rectangle-Rule

Thanks @guidimas
It's good to have in the guideline doc itself too.


feat: Add support for off peak window options

Closes https://github.com/cyberlabrs/terraform-aws-opensearch/issues/29
Implement support for off_peak_window_options, this was implemented in the provider in: https://github.com/hashicorp/terraform-provider-aws/pull/30965/files.
Implemented as 2 separate variables as either one is optional, but all the fields in window_start_time are required.
Tested with existing domains created after  February 16, 2023, which means all the domains had off_peak_window_options enabled by default, see the Note in the documentation for more info about this: https://docs.aws.amazon.com/opensearch-service/latest/developerguide/off-peak.html

Thank you for your contribution :)


bayes_snapper.npy outdated and undocumented

The repository contains a bayes_snapper.npy that apparently contains a bayesian model to rate satellite quality. Unfortunately the model seems to have been generated with an outdated scikit version that is not compatible anymore with recent Python. Would you be able to provide the data and method to generate the model? This would benefit reproducibility. Thanks!

I will have a look - give me a few days.
Some preliminary notes:

I have a dataset with SnapperGPS data from different scenarios with all satellites labelled whether they are visible or not (based on an elevation threshold) and whether their pseudorange was useful to estimate a position or is an outlier. In addition, it contains the estimated SNRs of all satellites.
Then - for each GNSS separately - I fit a Bayes classifier that maps SNRs to a binary label good satellite/bad satellite.
I use GaussianNB from sklearn.naive_bayes for fitting.
This assumes that SNRs are Gaussian distributed given the label, which is obviously an approximation.

This is from my thesis:

At first, it derives a prior probability P (vi = 1|SNRi) for each satellite observation
i ∈ 1, . . . N to be reliable, i.e., to be a so-called inlier, given the associated SNR.
The distribution p (SNRi) of the SNRs is modelled as a Gaussian mixture model
with two components, p (SNRi|vi = 1) for the inliers and p (SNRi|vi = 0) for the
outliers. Mean, standard deviation, and prior of each component are fitted to a
training dataset. This is done separately for each GNSS since the GPS L1 signal,
the Galileo E1 signal, and the BeiDou B1C signal have different properties and,
therefore, differently distributed SNRs. Using the resulting probabilistic models and
Bayes’ rule, the priors P (vi = 1|SNRi) = p(SNRi|vi=1)P(vi=1)/p(SNRi) for each satellite to be
an inlier and P (vi = 0|SNRi) = 1 − P (vi = 1|SNRi) to be an outlier are obtained.

Footnote:

Technically, SNRs are strictly positive while a Gaussian distribution’s support includes all
non-positive numbers, too. However, a Gaussian distribution is chosen because the probability
contained in the distribution’s tail that extends into the negative numbers is negligibly small
for the considered problem in practice. In addition, efficient algorithms for interference exist for
Gaussian distributions.

Thanks for the explanation, it makes sense. The table of labeled training data (csv?) and a script to train the model in the repository would be very helpful!

I will have a look - give me a few days.
Some preliminary notes:

I have a dataset with SnapperGPS data from different scenarios with all satellites labelled whether they are visible or not (based on an elevation threshold) and whether their pseudorange was useful to estimate a position or is an outlier. In addition, it contains the estimated SNRs of all satellites.
Then - for each GNSS separately - I fit a Bayes classifier that maps SNRs to a binary label good satellite/bad satellite.
I use GaussianNB from sklearn.naive_bayes for fitting.
This assumes that SNRs are Gaussian distributed given the label, which is obviously an approximation.

This is from my thesis:

At first, it derives a prior probability P (vi = 1|SNRi) for each satellite observation
i ∈ 1, . . . N to be reliable, i.e., to be a so-called inlier, given the associated SNR.
The distribution p (SNRi) of the SNRs is modelled as a Gaussian mixture model
with two components, p (SNRi|vi = 1) for the inliers and p (SNRi|vi = 0) for the
outliers. Mean, standard deviation, and prior of each component are fitted to a
training dataset. This is done separately for each GNSS since the GPS L1 signal,
the Galileo E1 signal, and the BeiDou B1C signal have different properties and,
therefore, differently distributed SNRs. Using the resulting probabilistic models and
Bayes’ rule, the priors P (vi = 1|SNRi) = p(SNRi|vi=1)P(vi=1)/p(SNRi) for each satellite to be
an inlier and P (vi = 0|SNRi) = 1 − P (vi = 1|SNRi) to be an outlier are obtained.

Footnote:

Technically, SNRs are strictly positive while a Gaussian distribution’s support includes all
non-positive numbers, too. However, a Gaussian distribution is chosen because the probability
contained in the distribution’s tail that extends into the negative numbers is negligibly small
for the considered problem in practice. In addition, efficient algorithms for interference exist for
Gaussian distributions.

There is a simple solution. You only need to modify the attributes of the old version model to the attributes of the new version model.


New release possible?

In particular this commit is needed by users of py.test to prevent the deprecation warning:
https://github.com/miracle2k/python-glob2/commit/be6981ec1a3ec089a934dbce3717d9ee6a01584e#diff-f8c62b113ad2e516e1ef8f0e9349800b

Ping?

@miracle2k Any chance you can do a little python setup.py sdist upload for the good people who love your work?

Done.


Include render function on the main report script

New feature required for this "Pipeline_of_functions" project. This feature is the inclusion in the “report.R” script of this line to render automatically the markdown report as HTML file when sourcing “report.R” file. :
We call rmarkdown::render() on the “report R” script to create the HTML output file.
Reference: https://bookdown.org/yihui/rmarkdown-cookbook/rmarkdown-render.html

The idea behind is that when sourcing the “report.R” script, we trigger the creation of the Markdown report called report.Rmd, it uses the previous three R scripts and outputs the final rendered HTML document. #
Run this "report.R" script pressing "source" button
1-2. Source individual R scripts from R folder to create content for markdown report
source(here("R","01_load_data.R"))
dataset
source(here("R","02_model.R"))
fit
source(here("R","03_plot.R"))
hist
2-2. Generate an HTML report as final output of this "report.R" script
Add line below to render this script in markdown
Markdown report combining above scripts
rmarkdown::render("report.Rmd", "html_document")


writing-bots: Use a fenced code block instead of an indented one.

Type annotation for the function is not rendered correctly: -> None is
rendered as -> None.

Merged, thanks @punchagan!


Rename triangle icons

This PR renames the 16px triangle- icons to caret- to follow the same naming convention as the 24px icons to be more descriptive.

I like this naming better too 👍Do we want to make this name change now? Or should we include it as part of the v2 updates?

I like this naming better too 👍Do we want to make this name change now? Or should we include it as part of the v2 updates?

@colebemis I think we can just make the name change now since I already did it in Figma 😂. But it's up to you.

Renaming an icon would be a breaking change to the library. So I think it would be better to batch this breaking change with all the other breaking changes in v2 so we only have to bump the major version number once (9.6.0 → 10.0.0 instead of 9.6.0 → 10.0.0 → 11.0.0).

Oh, I didn't realize this PR was in the octicons-v2 repo (not primer/octicons). Let's go ahead and merge this! :)

We'll have to rename the triangle icons in the v2 branch in the primer/octicons repo as well.
Also, we'll probably want to archive this repo and start working in the primer/octicons repo soon because it's getting a little confusing 😅


xCode 15.3 build for macOS results in invalid binary

Description
With xCode 15.3 builds my app targeting macCatalyst  results in invalid binary after many hours of processing in App Store connect, there is no log detail showing the failure reason but I was contacted by Apple engineering team with the reason of the invalid binary, mentioning a dependency coming from Firebase - GoogleAppMeasurementIdentitySupport.framework:

To resolve this issue, please refer the developer to the following message from engineering:

Please contact the developer and let them know Voxel Max.app/Contents/Frameworks/GoogleAppMeasurementIdentitySupport.framework is not a proper framework bundle.
The following builds will be marked invalid binary:
Version, build, platform
1.5.20, 956, osx
1.5.21, 958, osx
1.5.21, 960, osx
1.5.21, 961, osx
1.5.21, 962, osx
1.5.21, 966, osx
They can be referred to the link below and update their binary
https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html

Reproducing the issue
No response
Firebase SDK Version
10.22.1
Xcode Version
15.3
Installation Method
Swift Package Manager
Firebase Product(s)
All
Targeted Platforms
macCatalyst
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved
{
"originHash" : "26a0c0b404ae08db8282f2c5bc0ad8fd95fe9781b485207956b2df644dabb2d6",
"pins" : [
{
"identity" : "abseil-cpp-binary",
"kind" : "remoteSourceControl",
"location" : "https://github.com/google/abseil-cpp-binary.git",
"state" : {
"revision" : "df308b8b46607675f2b9ec8e569109008f9155ce",
"version" : "1.2022062300.1"
}
},
{
"identity" : "app-check",
"kind" : "remoteSourceControl",
"location" : "https://github.com/google/app-check.git",
"state" : {
"revision" : "3e464dad87dad2d29bb29a97836789bf0f8f67d2",
"version" : "10.18.1"
}
},
{
"identity" : "brightfutures",
"kind" : "remoteSourceControl",
"location" : "https://github.com/Thomvis/BrightFutures.git",
"state" : {
"revision" : "fa66fa183dce7196d431244d0215748cd14c5758",
"version" : "8.2.0"
}
},
{
"identity" : "colorpalettecodable",
"kind" : "remoteSourceControl",
"location" : "https://github.com/ndreca/ColorPaletteCodable",
"state" : {
"revision" : "674f027811eaf2cf90b0a1eda5bbf5ad1fa25b11",
"version" : "2.3.4"
}
},
{
"identity" : "cstb",
"kind" : "remoteSourceControl",
"location" : "https://github.com/troughton/Cstb",
"state" : {
"revision" : "a47f4ecf3a139ac2f53ed27a984853c9f98097f1",
"version" : "1.0.6"
}
},
{
"identity" : "dsfregex",
"kind" : "remoteSourceControl",
"location" : "https://github.com/dagronf/DSFRegex",
"state" : {
"revision" : "f1ce5c208384bb238b07905d140c2e60182e3601",
"version" : "3.3.1"
}
},
{
"identity" : "dynamic",
"kind" : "remoteSourceControl",
"location" : "https://github.com/mhdhejazi/Dynamic.git",
"state" : {
"revision" : "ab9a2570862d54aed2663691bb767f881226a12f",
"version" : "1.2.0"
}
},
{
"identity" : "erik",
"kind" : "remoteSourceControl",
"location" : "https://github.com/phimage/Erik.git",
"state" : {
"revision" : "109a130e9cdb00789a43a7a625293eeb12d22989",
"version" : "5.1.0"
}
},
{
"identity" : "filekit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/nvzqz/FileKit.git",
"state" : {
"revision" : "9006d2888025fbe893c3c396327b2fe45a8c177b",
"version" : "6.1.0"
}
},
{
"identity" : "firebase-ios-sdk",
"kind" : "remoteSourceControl",
"location" : "https://github.com/firebase/firebase-ios-sdk",
"state" : {
"revision" : "be49849dcba96f2b5ee550d4eceb2c0fa27dade4",
"version" : "10.22.1"
}
},
{
"identity" : "googleappmeasurement",
"kind" : "remoteSourceControl",
"location" : "https://github.com/google/GoogleAppMeasurement.git",
"state" : {
"revision" : "482cfa4e5880f0a29f66ecfd60c5a62af28bd1f0",
"version" : "10.22.1"
}
},
{
"identity" : "googledatatransport",
"kind" : "remoteSourceControl",
"location" : "https://github.com/google/GoogleDataTransport.git",
"state" : {
"revision" : "a637d318ae7ae246b02d7305121275bc75ed5565",
"version" : "9.4.0"
}
},
{
"identity" : "googleutilities",
"kind" : "remoteSourceControl",
"location" : "https://github.com/google/GoogleUtilities.git",
"state" : {
"revision" : "26c898aed8bed13b8a63057ee26500abbbcb8d55",
"version" : "7.13.1"
}
},
{
"identity" : "grpc-binary",
"kind" : "remoteSourceControl",
"location" : "https://github.com/google/grpc-binary.git",
"state" : {
"revision" : "ea4cb5cc0c39c732b85386263116d2e2fdbbdc61",
"version" : "1.49.2"
}
},
{
"identity" : "gtm-session-fetcher",
"kind" : "remoteSourceControl",
"location" : "https://github.com/google/gtm-session-fetcher.git",
"state" : {
"revision" : "76135c9f4e1ac85459d5fec61b6f76ac47ab3a4c",
"version" : "3.3.1"
}
},
{
"identity" : "inappsettingskit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/futuretap/InAppSettingsKit.git",
"state" : {
"revision" : "d52dbe42f4714802dedb38ed1b42a70971d1210b",
"version" : "3.7.0"
}
},
{
"identity" : "interop-ios-for-google-sdks",
"kind" : "remoteSourceControl",
"location" : "https://github.com/google/interop-ios-for-google-sdks.git",
"state" : {
"revision" : "2d12673670417654f08f5f90fdd62926dc3a2648",
"version" : "100.0.0"
}
},
{
"identity" : "kanna",
"kind" : "remoteSourceControl",
"location" : "https://github.com/tid-kijyun/Kanna.git",
"state" : {
"revision" : "41c3d28ea0eac07e4551b28def9de1ede702e739",
"version" : "5.3.0"
}
},
{
"identity" : "leveldb",
"kind" : "remoteSourceControl",
"location" : "https://github.com/firebase/leveldb.git",
"state" : {
"revision" : "43aaef65e0c665daadf848761d560e446d350d3d",
"version" : "1.22.4"
}
},
{
"identity" : "nanopb",
"kind" : "remoteSourceControl",
"location" : "https://github.com/firebase/nanopb.git",
"state" : {
"revision" : "b7e1104502eca3a213b46303391ca4d3bc8ddec1",
"version" : "2.30910.0"
}
},
{
"identity" : "oauthswift",
"kind" : "remoteSourceControl",
"location" : "https://github.com/OAuthSwift/OAuthSwift",
"state" : {
"revision" : "d85964b96dbce94df961f28b996187c835089903",
"version" : "2.2.0"
}
},
{
"identity" : "promisekit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/mxcl/PromiseKit",
"state" : {
"revision" : "cb70b070cde06837cd10a1febdf6105c1a3bb348",
"version" : "8.1.1"
}
},
{
"identity" : "promises",
"kind" : "remoteSourceControl",
"location" : "https://github.com/google/promises.git",
"state" : {
"revision" : "540318ecedd63d883069ae7f1ed811a2df00b6ac",
"version" : "2.4.0"
}
},
{
"identity" : "swift-protobuf",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-protobuf.git",
"state" : {
"revision" : "65e8f29b2d63c4e38e736b25c27b83e012159be8",
"version" : "1.25.2"
}
},
{
"identity" : "swifter",
"kind" : "remoteSourceControl",
"location" : "https://github.com/httpswift/swifter.git",
"state" : {
"revision" : "9483a5d459b45c3ffd059f7b55f9638e268632fd",
"version" : "1.5.0"
}
},
{
"identity" : "swiftimagereadwrite",
"kind" : "remoteSourceControl",
"location" : "https://github.com/dagronf/SwiftImageReadWrite",
"state" : {
"revision" : "96361ba7f9dce5184d95aba8ea90d9faa4acabb2",
"version" : "1.6.1"
}
},
{
"identity" : "swiftrichstring",
"kind" : "remoteSourceControl",
"location" : "https://github.com/ndreca/SwiftRichString",
"state" : {
"revision" : "092189737f7084e48dc767106453e86549ceb45d",
"version" : "3.7.4"
}
},
{
"identity" : "zipfoundation",
"kind" : "remoteSourceControl",
"location" : "https://github.com/weichsel/ZIPFoundation.git",
"state" : {
"revision" : "b979e8b52c7ae7f3f39fa0182e738e9e7257eb78",
"version" : "0.9.18"
}
}
],
"version" : 3
}
If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Thanks for the report. We'll investigate.

We have a similar problem where our iOS and AppleTV apps passes, but where our macOS app got stuck in TestFlight processing that could continue for several days, and finally end up in an invalid binary. We have retried multiple times, however by removing the firebase dependency, the macOS app works properly. Our macOS app is not a catalyst app but a regular macOS app.

however by removing the firebase dependency, the macOS app works properly.

@mansbernhardt, by "firebase dependency", are you referring to Firebase as a whole or the GoogleAppMeasurementIdentitySupport.framework mentioned in the OP?

@ncooke3 I've temporarily fixed it in a similar way by removing the FirebaseAnalytics dependency for osx

I have a similar problem with only the macOS app, other platforms works fine. I received the same message as @ndreca.
After adding FirebaseAnalyticsWithoutAdIdSupport I have an additional Frameworks directory in my macOS app.

After removing it the Frameworks directory disappears.

Hope that helps!

Btw, there is a faster way to test for the invalid binary outcome without waiting for app store connect to timeout(takes 12+ hours).
From local archive, notarize fails instantly, though there is also no relevant log information coming back.

however by removing the firebase dependency, the macOS app works properly.

@mansbernhardt, by "firebase dependency", are you referring to Firebase as a whole or the GoogleAppMeasurementIdentitySupport.framework mentioned in the OP?

@ncooke3 We only use the FirebaseAnalytics dependency product(name: "FirebaseAnalytics", package: "firebase-ios-sdk"), and by removing that dependency we got it working. Of course that dependency seems to bring a lot of other dependencies with it, including `GoogleAppMeasurementIdentitySupport.framework``

Thanks everyone for the info! The upcoming Firebase 10.23.0 (tentatively planned for next week) release should resolve this issue.

May I ask which was the last available version? I'm in a hurry to get it on the shelf now, but I'm always stuck at this step, and would like to try to go back first without interfering with the normal process of getting it on the shelf.

You can download Xcode 15.2 from here and use Firebase 10.21. I was able to get my binaries approved for Catalyst this way.

Thank you very much for the suggestion! I tried several versions of FireBase with Xcode 15.3 not long ago and it didn't work, so I removed FireBase for the time being to submit a version. It looks like the problem should be caused by a combination of Xcode and Firebase, so I'll see what happens on my end and decide how to handle it.

I updated to Firebase 10.23.0 and submitted a new binary to App Store Connect, and there is still an issue.  Here is the email I received.
Please correct the following issues and upload a new binary to App Store Connect.
ITMS-90291: Malformed Framework - The framework bundle FirebaseAnalytics (TeacherAide2.app/Contents/Frameworks/FirebaseAnalytics.framework) must contain a symbolic link 'FirebaseAnalytics' -> 'Versions/Current/FirebaseAnalytics'. Refer to the Anatomy of Framework Bundles for more information.
ITMS-90291: Malformed Framework - The framework bundle FirebaseAnalytics (TeacherAide2.app/Contents/Frameworks/FirebaseAnalytics.framework) must contain a symbolic link 'Resources' -> 'Versions/Current/Resources'. Refer to the Anatomy of Framework Bundles for more information.
ITMS-90292: Malformed Framework - The framework bundle FirebaseAnalytics (TeacherAide2.app/Contents/Frameworks/FirebaseAnalytics.framework) 'Versions' directory must contain a symbolic link 'Current' resolving to a specific version directory. Resolved link target: '${linkTarget}'. Refer to the Anatomy of Framework Bundles for more information.
ITMS-90291: Malformed Framework - The framework bundle GoogleAppMeasurement (TeacherAide2.app/Contents/Frameworks/GoogleAppMeasurement.framework) must contain a symbolic link 'GoogleAppMeasurement' -> 'Versions/Current/GoogleAppMeasurement'. Refer to the Anatomy of Framework Bundles for more information.
ITMS-90291: Malformed Framework - The framework bundle GoogleAppMeasurement (TeacherAide2.app/Contents/Frameworks/GoogleAppMeasurement.framework) must contain a symbolic link 'Resources' -> 'Versions/Current/Resources'. Refer to the Anatomy of Framework Bundles for more information.
ITMS-90292: Malformed Framework - The framework bundle GoogleAppMeasurement (TeacherAide2.app/Contents/Frameworks/GoogleAppMeasurement.framework) 'Versions' directory must contain a symbolic link 'Current' resolving to a specific version directory. Resolved link target: '${linkTarget}'. Refer to the Anatomy of Framework Bundles for more information.
Apple Developer Relations

@ghb101 See #12587


DefaultSqlQueryGenerator.VisitCaseExpression is implementation specific because it contains BIT

Make sure the DefaultSqlQueryGenerator class can be overriden so inherited classes can modify implementation of the query (_sql is marked private).

Sql already exposes property, issue closed