test: fix tabs skipped test CE

NandanAnantharamu
NandanAnantharamu commented 1 hour ago •
Skipped test in Tab spec is fixed.
There was change in one of the validation step
/ok-to-test<EMAIL_ADDRESS>

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11497586600
Commit: ac79d1801414e3c065267b099c48251b67644386
Workflow: PR Automation test suite
Tags: @tag.Sanity
Spec: ``
Thu, 24 Oct 2024 10:38:25 UTC

Summary by CodeRabbit

Bug Fixes

Re-enabled test case for verifying colors, borders, and shadows of the Tabs widget.
Updated border color assertion to reflect the new expected value.

Improvements

Enhanced verification of property visibility and functionality for the Tabs widget, including tab renaming, deletion, and binding with text widgets.
Validated behavior when toggling the "Show Tabs" property and ensured appropriate error handling for invalid default tabs.

Chores

Updated the test file reference in the limited-tests configuration to focus on the Tabs widget.

/ci-test-limit-count run_count=25

/ci-test-limit-count run_count=25


v0.13.0 release

Minor change to trigger v0.13.0 release

We need also to update the information in csproj files when triggering the release

Sorry, I didn't notice that you have modified the project files before. The auto-release failed and I'm going to fix it in #780. :)

I did everything in the other PR... but I forgot to attach the release tag 🤦♂


refactor(conductor): replace executor constructor by type state builder

Replace Executor::new() by Executor::builder()....build() because the constructor was getting too lengthy.
This uses the type-state pattern to avoid having to check if all required builder fields are set (with the fields all being Option<T>). This is more verbose in the executor's type signature and field-setters, but avoids the need for error handling.

nice, thanks!


Deploy service account for pod creation on demand

Stateful sets need a service account to create Spilo pods. This PR automates deployment of such an account, thereby reducing manual work required to deploy a database.

Coverage decreased (-0.1%) to 11.355% when pulling 214ae04aa7692d51fbed1a2e10f56bb5b03d4c4d on automatically-deploy-service-account into 5e1d86e31e9bf04d7069c075b10068858c292fdb on master.

@alexeyklyukin updated

👍

:+1:

👍


Migrate primary branch from master to main

See https://github.com/Senzing/stream-loader/issues/283

Pull requests:

https://github.com/Senzing/stream-logger/pull/26


bdb.execute(sql) fails but bdb.sql_execute(sql) succeeds on SELECT

    bdb = bayeslite.bayesdb_open('resources/gapminder.bdb')
    pairwise = query(bdb, 'SELECT name0, name1 FROM dependence;')
    for row in pairwise.values[:1]:
        name0, name1 = row
        sql = '''
            SELECT %s, %s FROM %s
        ''' % (
            sqlite3_quote_name(name0),
            sqlite3_quote_name(name1),
            sqlite3_quote_name('gapminder_t'))
        print sql
        frame = bdb.sql_execute(sql).fetchall()
        print frame

OK, but replacing the line
        frame = bdb.execute(sql).fetchall()

returns
AssertionError: Invalid select table: u'gapminder_t'

Can you share gapminder.bdb, or the results of the initial SELECT, or a SQL trace from this program?

Saving another incarnation of this error using COUNT(*) for future reference, where bdb.execute complains
E           AssertionError: Invalid select table: u't'

but bdb.sql_execute is fine
                    qt = sqlite3_quote_name(table)
                    qc = sqlite3_quote_name(cmd.name)
                    cursor = bdb.execute(
                        'SELECT COUNT(*) FROM %s WHERE %s IS NOT NULL' %
                        (qt, qc))

The data is from test_csv.csv_data and qc is height.

Date: Wed, 18 Jan 2017 03:41:37 -0800
From: F Saad<EMAIL_ADDRESS>Saving another incarnation of this error using COUNT(*) for future reference, where bdb.execute complains
E           AssertionError: Invalid select table: u't'

but bdb.sql_execute is fine
                    qt = sqlite3_quote_name(table)
                    qc = sqlite3_quote_name(cmd.name)
                    cursor = bdb.execute(
                        'SELECT COUNT(*) FROM %s WHERE %s IS NOT NULL' %
                        (qt, qc))

The data is from test_csv.csv_data and qc is height.
Interesting.  Somehow a Unicode string is getting passed through, but
as I recall BQL works exclusively in US-ASCII.  The reason this
assertion fires is that the select table is the Unicode string u't',
not the byte string b't' (a.k.a. just 't' in Python 2).

What is query here?


Evaluate use of Whisper-Jax for more Speed

Hello,
i found your repo, awesome idea, was looking some time for something like this.
this is a little suggestion. i came across this repo Whisper-Jax. The Dev says its fast, 70x faster than normal whisper on tpu. i know normally you have no tpu, but the benchmarks in the repo show also improvements on gpu. you can give it a shot on this hugginface space from the same dev.
Maybe you can look into it.
Would be awesome if you can make it even faster as it is now.
Thanks for your tool and the time you invest in it ;)

semigoro

It appears whisper-jax is still missing feature necessary to do accurate subtitles via stable-ts or whisperX.
See: https://github.com/jianfch/stable-ts/issues/142


RDS-S3 readme improvements to provide purpose for using RDS and S3 and streamline installation steps

Which issue is resolved by this Pull Request:

Adds the purpose and motive for using RDS and S3 to the RDS/S3 setup README
Standardizes the sample setup procedure for setting up RDS, S3, and secrets manager resources

Description of your changes:

Modified README to include the above

Checklist:

[] Tested the automatic setup script with all the parameters

Looks like we are not making changes to 1.3 outside of bug fixes. I have added these README changes in https://github.com/awslabs/kubeflow-manifests/pull/108 for 1.4. Will re-open this PR if we change our minds about adding these changes to 1.3.


[Mura 7] configuration interface is not loading

The configuration interface doesn't work on Mura 7. Only the menu is shown but none of the tabs show their content.

Ditto.. Is there a documented process for updating plugins to work with the new Mura 7 UI?

@Lagaffe @nsollecito sorry guys, we're working on it and hope to have some info posted soon.

:+1:

Hi Steve,  any news on the update to the plugin working on Mura 7.  Thanks.

Is this issue fixed now that Mura7 has been released?

I just downloaded the latest translation from GitHub and installed on a site that we are hoping to deploy in a few weeks.  When I go to the admin it doesn't show the content for the administration.  If I do a view source I see the code for the tabs but the actual content doesn't show up. We are currently running on 7.  Latest version.  I see there has been some recent updates but for some reason the tab content still doesnt' show through so we can manage it.

I did some tests as well last Friday, issue isn't fixed yet.

LaGaffe, Do you have any work around for this?  I am just hoping someone has been able to come up with a fix.

@Lagaffe @Tigerlady @nsollecito i've fixed the interface issue in my latest pull request. However, I've noticed a few other bugs with the plugin itself that we're currently looking in to. Thanks!


[Improve] add unit test

yep. I think so. I am debug in my local. If has new discover, i will push.
I will mark its draft later.
tomsun28 @.***>于2024年8月5日 周一12:37写道：

@.**** commented on this pull request.
In
alerter/src/main/java/org/apache/hertzbeat/alert/controller/AlertDefinesController.java
https://github.com/apache/hertzbeat/pull/2454#discussion_r1703525285:

   return ResponseEntity.ok(Message.success(alertDefinePage));

   return  ResponseEntity.ok(Message.success(

           new PageImpl<>(

                   alertDefinePage.getContent(),

                   PageRequest.of(pageIndex, pageSize, Sort.by(new Sort.Order(Sort.Direction.fromString(order), sort))),

                   alertDefinePage.getTotalElements()))

   );

Hi, it maybe caused by test cases or other reasons. I feel that we cannot
repeat the construction like this.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/hertzbeat/pull/2454#pullrequestreview-2217993592,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASS2GCIP55OT2HPTIBFACADZP36RDAVCNFSM6AAAAABL6OCNHCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJXHE4TGNJZGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

@tomsun28 I find question: pls see: https://github.com/spring-projects/spring-data-commons/issues/2987

@tomsun28 I find question: pls see: spring-projects/spring-data-commons#2987

👍  it seem this can fix it. https://github.com/spring-projects/spring-data-commons/issues/2987#issuecomment-2072480592 add pageModule in jackson

@tomsun28 I find question: pls see: spring-projects/spring-data-commons#2987

👍 it seem this can fix it. spring-projects/spring-data-commons#2987 (comment) add pageModule in jackson

This would be due to additional class configuration, not sure if there are other side effects, I think it's better to use new PageImpl to be safe. 🤔

This would be due to additional class configuration, not sure if there are other side effects, I think it's better to use new PageImpl to be safe. 🤔

hi, the root cause is the serialization problem of the page. It is recommended that we solve the problem instead of circumventing it. we has the custom jackson config here like timemodule https://github.com/apache/hertzbeat/blob/master/manager/src/main/java/org/apache/hertzbeat/manager/config/JacksonConfig.java
builder.modules(new SpringDataJacksonConfiguration.PageModule());

This would be due to additional class configuration, not sure if there are other side effects, I think it's better to use new PageImpl to be safe. 🤔

hi, the root cause is the serialization problem of the page. It is recommended that we solve the problem instead of circumventing it. we has the custom jackson config here like timemodule https://github.com/apache/hertzbeat/blob/master/manager/src/main/java/org/apache/hertzbeat/manager/config/JacksonConfig.java
builder.modules(new SpringDataJacksonConfiguration.PageModule());

got it, let me try

@tomsun28 hi, This e2e error is probably caused by #2486, I think we can run the ci test again after the #2486 merge.
cc @crossoverJie

For this pr, the current state is that it may affect all controllers that use Page as a return value, but it does not affect front-end api calls. It only appears in e2e tests and unit tests, so this pr is in pending status, and will be updated again when there is a better solution for serializing Page objects in spring data jpa.


Indexing property and description values

Hello, I am wondering if it is possible to enable that property names and property values are indexed.
I'd like to use the applications main search bar to find ingested property and description data.
e.g. from the sample data:
If I search for "prop1" or "fakeprop", I want it to find SampleKafkaDataset.

Hello! We have this request captured in our feature request portal here; if this is still something you are interested in, please upvote/subscribe to that post so we can gauge community interest! We'll close out this issue in the meantime.


contribution guideline

For people who want to send PR.

CONTRIBUTING.md file added into the root.


Diagonal shooting

Description
Added the ability to shoot diagonally and changed how shotgun projectiles are spawned to compensate. Also fixed a bug where the player wasn't able to shoot while touching a wall and made the player's IFrames scale with the difficulty of the game.
Fixes / Closes:

#429
#403
#290

Type of change

[ ] Bug fix
[ ] New feature

How Has This Been Tested?
Due to shooting requiring both player input and a timer, this feature is not feasible to write tests for, however manual test has been performed to ensure that the feature works as expected
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] New and existing unit tests pass locally with my changes

I'm still noticing something that might be a bug. Choose easy, default player, go to the wall and shoot parallel to the wall. The bullets appear very briefly then disappear, is this intentional?

Wall shooting still doesn't appear to work, unless it's meant to be how it is.  You still can't shoot parallel to the wall though, which would require changing either how projectiles or the player's collision interacts with the wall

Looks good. Wall shooting and diagonal shooting work as expected. The player is invincible for longer on easy, can be seen by repeatedly trying to take damage. The invincibility flash animation doesn't appear to scale with the iframe time, there is only one flash I can see, that may be intended however.

good point, I'll make the player always flash a constant number of times before becoming vulnerable so they can tell how long the IFrames are


facetsDistribution is missing in SearchResult model

facetsDistribution is missing in this file.

[ ] add in the code
[ ] add search test

This is fixed in the PR #54.


Updated Homebridge UI to the latest version and now all of my Wyze devices are offline.

Describe Your Problem:
Updated Homebridge UI to the latest version (homebridge-config-ui-x v4.51.0) and now all of my Wyze devices are offline. Have confirmed that my Key Id, Api Key are correct as well as my username and password. I have rebooted and power cycled my Pi.
Logs:
Show the Homebridge logs here, remove any sensitive information.
[23/10/2023, 19:42:12] [wyze-smart-home] Request failed: AxiosError: Request failed with status code 400 [23/10/2023, 19:42:12] [wyze-smart-home] Response PerformRequest (Bad Request): {"description":"Invalid credentials, please check username, password, keyid or apikey","requestId":"xxxxxx","errorCode":1000}
Plugin Config:
    {
        "name": "wyze-smart-home",
        "username"<EMAIL_ADDRESS>        "password": "xxxx",
        "keyId": "xxxx",
        "apiKey": "xxxx",
        "refreshInterval": 60000,
        "hms": false,
        "showAdvancedOptions": true,
        "apiLogEnabled": false,
        "logLevel": "none",
        "excludeMacAddress": true,
        "filterByMacAddressList": [
            "7C78B2705140"
        ],
        "excludedeviceType": true,
        "filterDeviceTypeList": [
            "Camera"
        ],
        "platform": "WyzeSmartHome"
    },

Screenshots:

Environment:

Plugin Version: v0.5.37-alpha.4
Homebridge Version: 1.6.1
Node.js Version: v18.16.0
NPM Version: 9.5.1
Operating System: Raspbian GNU/Linux Buster (10)

I mean the error says something different. 🤷♂🤷♂

Sorry to be confusing. Not intentional of course.
The devices are all offline because the plugin cannot log into my account. The only change made was upgrading homebridge UI and a restart. The error below just repeats over and over again. I confirmed that all the information in the config matches What I see on the API Key page from Wyze and does not expire until 3 July 2024.
I considered backing out to v0.5.36 and see if that resolved the issue but thought there might be some interest if I had found an issue in the latest build of 5.37
If there is more information I can supply, let me know. And if there is any action you would like me to try I can do that :)
[23/10/2023, 20:11:32] [wyze-smart-home] Error getting devices: AxiosError: Request failed with status code 400
[23/10/2023, 20:12:32] [wyze-smart-home] Request failed: AxiosError: Request failed with status code 400
[23/10/2023, 20:12:32] [wyze-smart-home] Response PerformRequest (Bad Request): {"description":"Invalid credentials, please check username, password, keyid or apikey","requestId":"fce9430d-590a-4f57-a921-ae7954533cca","errorCode":1000}
[23/10/2023, 20:12:32] [wyze-smart-home] Error getting devices: AxiosError: Request failed with status code 400

On Oct 23, 2023, at 10:19 PM, Farmer @.***> wrote:
I mean the error says something different. 🤷♂🤷♂
—
Reply to this email directly, view it on GitHub https://github.com/jfarmer08/homebridge-wyze-smart-home/issues/184#issuecomment-1776394064, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLAX23CB3YRIHQUPDJ6HYTYA4QSPAVCNFSM6AAAAAA6M3S7SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWGM4TIMBWGQ.
You are receiving this because you authored the thread.

Have you checked this ticket out https://github.com/jfarmer08/homebridge-wyze-smart-home/issues/149?

That worked! I regenerated the key and all is well now. Easy fix.
Thanks for the guidance.

On Oct 23, 2023, at 11:01 PM, Farmer @.***> wrote:
Have you checked this ticket out #149 https://github.com/jfarmer08/homebridge-wyze-smart-home/issues/149?
—
Reply to this email directly, view it on GitHub https://github.com/jfarmer08/homebridge-wyze-smart-home/issues/184#issuecomment-1776423740, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLAX2ZWX4SPSOT6TRK3QIDYA4VRDAVCNFSM6AAAAAA6M3S7SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWGQZDGNZUGA.
You are receiving this because you authored the thread.


v1.0.0 incompatible with Node.js at runtime

The recent v1.0.0 release has made this package incompatible with the Node.js runtime, because of this change from a valid fully specified import path to an invalid non fully specified import path missing the file extension:
https://github.com/slicknode/graphql-query-complexity/pull/91/files#diff-720574529a576948113b0f865801527a139a756ce25203d58f98f714bfd59b76R11
With Node.js v22.3.0, here is the runtime error:
node:internal/modules/run_main:115
    triggerUncaughtException(
    ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '[redacted]/node_modules/graphql/execution/values' imported from [redacted]/node_modules/graphql-query-complexity/dist/esm/QueryComplexity.js
Did you mean to import "graphql/execution/values.js"?
    at finalizeResolution (node:internal/modules/esm/resolve:260:11)
    at moduleResolve (node:internal/modules/esm/resolve:920:10)
    at defaultResolve (node:internal/modules/esm/resolve:1119:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:541:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:510:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
    at ModuleJob._link (node:internal/modules/esm/module_job:126:49) {
  code: 'ERR_MODULE_NOT_FOUND',
  url: 'file://[redacted]/node_modules/graphql/execution/values'
}

We do not have a bundler in our Node.js GraphQL API project, and even if we did, we would be enforcing modern ESM module resolution rules which require fully specified import paths.
We will have to keep our dependency on graphql-query-complexity at ^0.12.0 until this issue is resolved.
Because the ecosystem can't be importing both ESM and CJS versions of graphql modules, so far it has settled on only importing the CJS because that's what came first and took root. The people best positioned to effect a transition to the ESM is the graphql maintainers, who could stop publishing CJS in a new major version and only publish pure ESM and force an ecosystem migration to align to ESM instead. That was actually planned for a major graphql release, but they chickened out on it in the end.
As a package author, you have to pick either importing ESM or CJS from graphql; you can't avoid making a decision.

I see you're publishing both CJS and ESM modules in graphql-query-complexity:
<EMAIL_ADDRESS>Something you could consider, is having a build step when creating those artifacts that inserts .mjs file extensions in the graphql import paths when generating ESM modules, and .js when generating CJS. In the past I published a Babel plugin to help with this sort of thing:
https://github.com/jaydenseric/babel-plugin-transform-require-extensions
Nowadays in my own packages I militantly publish pure ESM and haven't used it for some time.
The catch with the above approach is that people (like me) like to consume your package as ESM, but expect it to pull in the CJS version of graphql. For us to continue using the CJS version of graphql (only to prevent duel package hazards with other ecosystem packages; our codebase is actually pure ESM) we would have to deep import the CJS version of graphql-query-complexity. Your package exports field would need to be updated to allow this, because currently it prevents any deep imports:
https://github.com/slicknode/graphql-query-complexity/blob/455978d4ed2934d7160a457965ab104998a3c515/package.json#L46-L51
For optimal JavaScript module design you should have package exports allowing deep imports of only the things people need anyway, and ideally remove the ability for consumers to import any other way. Force them to fall into the pit of success.

+1 for this

Has anyone found a workaround for using this plugin in an ESM project?

CC @ivome


Feature request - delete all option for delete connectivity

It would be nice to be able to delete all connectivity either for the entire DSM or for a specific row or column.

I ended up adding an "all" option to the delete connections window. So for clearing connections, users will choose all as the row and all as the column. To clear just a row or column's connections users will choose the row or column and then the "all" option.


[WIP] Refactoring components with ES6

Major changes:

use .jsx extension for jsx files
separate flowtable.js into multiple files (FlowTable.jsx, FlowTable/*.jsx)
separate header.js into multiple files (Header.jsx, Header/*.jsx)
refactoring eventlog.js

Bug fixes:

fix focus and updateLocation for MainView
fix shortcut for header fields
fix Prompt view with latest version of lodash (_.pluck was removed)

Looks good so far. I did a preliminary merge so that things don't get out of control here.


README: Add path parameter to echo handler

Without this fix, the example from README does not work.

You are reading the docs for websockets ≥ 10.1 while using websockets < 10.1.

Oh, ok, my bad. Sorry about that!
Von meinem iPhone gesendet

Am 15.03.2022 um 09:16 schrieb Aymeric Augustin @.***>:

Closed #1145.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.


Screen Ruler not working in 2+  screens setup

Microsoft PowerToys version
0.79.0
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
Screen ruler
Steps to reproduce
While using two or more monitors, open the Screen Ruler (it will be open in the primarymonitor), select any measure style then try to measure something in the other monitors.``
✔ Expected Behavior
The cursor with the measure tool activated should be available to any object in the non-primary monitor
❌ Actual Behavior
Most of the times the measure tool doesn't move to other monitors, so you can't take any measure butin the main monitor. Sometime I need to deactivate then activate again a few times (2 or 5 times) until it work properly
Other Software
Windows 11 24H2
All monitors at 100% scale.

Same issue found in :

#31118
#31283
#30530


feat: Add env. variable to control verbosity of the logger

This PR adds an env. variable EVOTORCH_VERBOSE_LEVEL to control the default verbosity of the EvoTorch Logger.
Supported values and their logging levels counterparts are:

0 sets logging.WARNING
1 sets logging.INFO (default)
2 sets logging.DEBUG

TODO

[ ]  Add docs

Codecov Report

Merging #48 (c2b6067) into master (f064bb5) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   78.13%   78.19%   +0.06%
==========================================
  Files          43       43
  Lines        6307     6307
==========================================
+ Hits         4928     4932       +4
+ Misses       1379     1375       -4

Impacted Files
Coverage Δ

src/evotorch/tools/misc.py
86.40% <0.00%> (+0.62%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Adding Node Attributes

Hello,
Thank you for developing this tool. I am looking at using it to create a multiplex graph of PPI, Reactome, and  TF-gene data, with the nodes being genes. My goal is to take gene expression data from each cell in a scRNAseq dataset, map it to the nodes, and create a feature embedding for each cell that I can use to train a GNN.
I have two questions.

Is it possible to use node features (such as gene expression data) with your model?
Is it possible to label edges, such as in the reactome file, the edges are directed, and I want to incorporate the pathway name of each edge.

Thanks for the help!

These are the graph structures I wish to use. Reactome is directed and I would like the edge features to be the pathway names. STRING is not directed and the edge weights are interaction confidence. Gene regulatory network is directed and unweighted.
https://drive.google.com/drive/folders/1Zdm_ZFEOnoAbsMYFDxMzYsQP_FFNUg2Q?usp=sharing

If no direct method for node attributes exist, I was also thinking that I could potentially use a bipartite graph to represent this, such that the graph would be a Monoplex graph with the genes being expressed in the cell, then the edges would connect the expressed genes with the matching genes in each of the layers of the multiplex graph. Then , the edge weights of these connections could be the gene expression values?
Let me know what you think of my first question, and if there isn't a direct way to do what I am looking to do would this indirect method work?

Hello,
Thank you for using MultiXrank!
Regarding your first question, utilizing node features for the initial restart probability is feasible. However, it's essential to note that the random walk (RW) process relies on the transition matrix, which incorporates information solely from the edges. Therefore, while node information can influence the restart process, it doesn't directly impact the walking process. In conclusion, instead of employing a fixed set of seeds, consider using a distribution aligned with your gene expression distribution. This approach aligns naturally with the problem, although your proposed solution could also be effective.
For your second question about labeling edges, it's not possible to integrate the label directly into the RW process. Nevertheless, a post-processing visualisation can be created to combine the outcomes of MultiXrank with the edge labels, providing a comprehensive solution to address this aspect.


fixes #1004 : Build image only when changes merged to master

fixes #1004 : Build image only when changes merged to master
Signed-off-by: Pratik Raj<EMAIL_ADDRESS>

Thanks, but please sign the commit for DCO
https://github.com/apps/dco
(run git commit -a -s --amend, and make sure that the Signed-off-by: NAME <EMAIL> line with your real name is included in the commit message)

Thanks, but please sign the commit for DCO https://github.com/apps/dco
(run git commit -a -s --amend, and make sure that the Signed-off-by: NAME <EMAIL> line with your real name is included in the commit message)

Hi @AkihiroSuda, updated both the commit and PR description with Signoff


recovery from master/slave failure results in co-masters

I have 3 mysql servers mysql-A and mysql-B and mysql-C in topology as follows,
mysql-A -> mysql B and mysql-A -> mysql-C
Now i made mysql-A and mysql-C down. After the recovery mysql-B is becoming master as expected.
After some time i made mysql-A up. Now mysql-A is becoming slave to mysql-B but showing revovery symbol. And topoly is showing mysql-C as slave to mysql-A( but this is okay as orchestrator cannot ping mysql-C as it is still down). After this the topology is as follows,
mysql-B -> mysql-A(with recovery label) -> mysql-C(still down)
Now i made mysql-B down and immediately mysql-A became master.After some time i made mysql-B up. But now mysql-B is becoming co-master to mysql-A instead of becoming slave to mysql-A.
After this i am seeing 2 masters(mysql-A and mysql-B) in topology which are replicating from one another.
Is there any config i am missing here or this is an issue?

Did you set "ApplyMySQLPromotionAfterMasterFailover": true?
See https://github.com/github/orchestrator/blob/master/docs/configuration-recovery.md
This is by far the largest confusion people have with the configuration and I think I should change the default of that flag to true.

related: https://github.com/github/orchestrator/pull/528, where ApplyMySQLPromotionAfterMasterFailover defaults true

Thoughts? Will close if not responded.


reference Swoole promise adapter

Hello!
This PR is related to that discussion: https://github.com/webonyx/graphql-php/discussions/1477
I made a Swoole promise adapter and referenced it in the docs.
If I need to change anything, please let me know.

Thank you


Fix unit tests

Fix and improve GP unit test ASH sequence

Closing (replaced by PR #67) targetting a merge to release branch.


fix: ⚡ Jimmy two times

Fixes  the duplicated sentence in the Swap warning message, IMO we should get rid of it entirely from the swap tab, but until this is decided here is the fixed version

what would be a good place to have the donation address?
should have a good visibility
maybe the footer?


relations are order dependent

Investigate a fix for making flannel call the network relation-changed event if the db relationship is added after networking relationship has been established

This has been closed as of 7c1a862


Optimal number of cycles

What is the optimal number of cycles?
I found these variables were changing during the run: loss, F KLDiv, and NLL.
Which one is the best indicator?

Hi @gyuhyeokcho,
To clarify,

F KLDiv quantifies the agreement of the structure factors with Wilson's prior distribution. Smaller numbers are "closer" to the prior and are probably indicative of the solution capturing less of the possible information in the data.
NLL is the negative log likelihood of the data under the model. This term represents how consistent the structure factors and neural network scale model are with the data. Smaller numbers are again more consistent with the data.
Loss is simply F KLDiv + NLL which is the quantity being optimized by the software.

There is no clear consensus on the optimal number of optimization steps at this time. Typically, we have just run training to convergence with ~30k iterations. However, I can currently give you no guarantee that this strategy is best. I would recommend using crossvalidation as a principled approach to select the number of optimization steps.
You can designate a fraction of your data to be held out during optimization with the --test-fraction flag. For instance, --test-fraction=0.05 will reserve 5% of the reflections to the test set. This procedure is analogous to the "Free" set in structure refinement used to compute Rfree.
If specified, test reflections will be marked in the *_predictions_#.mtz files which careless writes at the end of training. You can use the careless.ccpred on the predictions file to compare the correlation between predictions and observations for the test and training fractions. A principled way to decide the number of optimization steps would be to choose the setting with the smallest gap between correlation coefficients for train and test. The reasoning here is that the model is less over fit with respect to a particular subset of the data as it generalizes better to previously unseen data. This is essentially what we did in Figure 3 of the paper for choosing the degrees of freedom of the loss function.
Additionally, I will note that careless records the values of the F KLDiv, NLL, and Loss in a *_history.csv file. This plain text file may be of interest to you as well. It can be useful to plot the values as a function of the iterations using seaborn. For example:
import seaborn as sns
import pandas as pd

df = pd.read_csv("hewl_history.csv")
sns.lineplot(df.melt('step'), x='step', y='value', hue='variable')
plt.semilogy()

As I mentioned, we have not yet done an exhaustive study of the number of optimization steps. Instead, we have usually optimized until convergence and varied other parameters of the model about which we have more intuition. I make no claim that this is the best strategy. There are a great many ways to train the model. We're very interested in user feedback in order to begin assembling a set of best practices. So, if you discover anything of interest in your experiments. We'd be very happy to hear any insights you uncover through your experiments. Feel free to contact myself or @DHekstra in whatever manner you feel comfortable — either privately or in a public GitHub issue.
Thanks for your excellent question!
Kevin

Thank you for your answer!


Import BBH initial data from SpECTRE

Add support for importing BBH initial data generated by the SXS collaboration's open-source SpECTRE code.
@HengruiPrinceton and I have been evolving this data with AthenaK, with the idea to evolve high-mass-ratio and high-spin BBHs on GPUs. The SpECTRE code can generate non-conformally-flat, high-spin BBH initial data for this. It's excision data, so it is extrapolated into the excisions and then collapses into moving puncture gauge.
I'm working on a tutorial for generating and importing SpECTRE initial data, which I will link here once it's merged upstream in https://github.com/sxs-collaboration/spectre.
This is my first PR to AthenaK, so let me know if I missed something :)

Hi @jmstone, this branch is ready to be merged.


Dataype

Standardized the structure naming as a type (need it for a other PR)
Fixed some debug prints preventing compiling

nvm #20 has got it covered.


west: jlink: flash add progress bar

When flashing with a jlink probe using west flash you don't get feedback on the process.
This PR adds a progress bar and detects if the contents already matches.

There's few potential issues I see with this:

adding a new python dependency to the jlink flasher, going to break few setups, it's understandable for basic functionalities but this is just a fancy UI, bare minimum it should be optional and only kick in if the library is already installed
screen scraping the JLink output does not strike me as a particularly good idea, the command does not really have an output meant to be stable, this is asking for troubles down the road
the UI of this is, in my opinion, not great. On a bigger terminal it wipes the screen and leaves a long gap in he center for the sake of pinning the bar on the bottom, if the execution is quick (as it is on small devices) it just looks a bit broken

Sorry I realize that quite some tedious work went into this, curious to hear what the others think as well.

adding a new python dependency to the jlink flasher, going to break few setups, it's understandable for basic functionalities but this is just a fancy UI, bare minimum it should be optional and only kick in if the library is already installed

Good point, I guess we could put the dependency behind a try import and if that fails just fallback to the old behaviour.

screen scraping the JLink output does not strike me as a particularly good idea, the command does not really have an output meant to be stable, this is asking for troubles down the road

I agree, It's hard to make it stable, but the intend is that using regular expressions the worst case what could happen with an incompatibility is that the bars don't show up.

the UI of this is, in my opinion, not great. On a bigger terminal it wipes the screen and leaves a long gap in he center for the sake of pinning the bar on the bottom, if the execution is quick (as it is on small devices) it just looks a bit broken

Happy to switch to another progress bar library that doesn't put the cursor to the bottom.

I think runners should be as transparent as possible, ie, just print what JLink gives us. It should be JLink that provides a nice UI. Also, as said, adding new dependencies to the base install just for a runner seems too much.

Indeed that could also be an approach right now west flash is quite opaque and you just don't know what's going on. For example when flashing a big target 64MB you don't know how far the progress is or when you get an error you don't know what's going on.
Redirecting stdout by default from west flash wouldn't be bad idea either.

Redirecting stdout by default from west flash wouldn't be bad idea either.

How about a runner option to do that? Then one could enable it for the specific board, I see how it could be useful if your project ends up with a multi-MB image.

@fabiobaltieri Swapped the bar implementation with another one that doesn't wipe the screen.
Also added try import for the dependency I pull in, so it isn't mandatory with a fallback to the old silent output method.

@fabiobaltieri  thanks for the remark progress already being installed, I've modified the code to use that instead.
@gmarull as of now we're not pulling any new dependences beyond the existing base install.

ok couple more concerns:

should there be a runner option to go back to just executing the command? for stuff like batch processing or as quick workaround if something break with screenscraping jlink (I know it should fall back, but just in case)
how does this look if the output is not a tty? (also for batch processing, it should probably not do the progressbar or do something logfile friendly)

should there be a runner option to go back to just executing the command? for stuff like batch processing or as quick workaround if something break with screenscraping jlink (I know it should fall back, but just in case)

A generalized runner option or environment variable wouldn't be a bad idea. I might port the progress as well to pyocd because there typically flash algorithms are quite slow

how does this look if the output is not a tty? (also for batch processing, it should probably not do the progressbar or do something logfile friendly)
progress uses VT100 sequences so you would get every percentage update and the cursor command in plain text. It shouldn't fail though.

bump

@fabiobaltieri @PetervdPerk-NXP what is the state of this PR? can we get it into LTS?

It's all okay from my end.

@carlescufi can you help land this?

This feature should be added as an option, there can be users relying on the standard JLink output.

But there's no standard output there's only the process return code.

This feature should be added as an option, there can be users relying on the standard JLink output.

But there's no standard output there's only the process return code.

Then keep it silent by default, show progress if enabled. What if I prefer non-fancy bars on my terminal?

Then keep it silent by default, show progress if enabled. What if I prefer non-fancy bars on my terminal?

So west build CMake progress should now also be silent?
There's always pipe to /dev/null.

my request: make this an opt-in feature, not default.

How about a west config option?
$ west config runners.jlink-progressbar true

I'm curious what's up with the consensus that a progress bar would screw up your logs. I would say it's opposite you would see more information in your logs i.e. failing partway.
@henrikbrixandersen  would you be able to try this PR on your CI and actually report what would be wrong then?
Also the canopen runner is also running a progress bar without any problems
https://github.com/zephyrproject-rtos/zephyr/blob/65051c8a242e4bb5dd2c0625756d468c716b4616/scripts/west_commands/runners/canopen_program.py#L15

Fine with this being added but as others have said, opt in, not opt out - do not want to see this at all on my machine, do not want to have to deal with this in CI.


Split fn block_hash from revm::Database to new revm::Blockchain trait

https://github.com/bluealloy/revm/issues/298


Add examples

[X] Simple example
[ ] Retries after failure
[ ] Job priority
[ ] Graceful shutdown
[ ] Job checkpoints
[ ] Retry expired jobs

First of all, thanks for a great library! I’ve started to do something similar (much simpler though) and just found your repo. More examples would be very helpful for adoption, I believe a lot of people have similar use cases.


Change internet check to use netcat and not ping

Proposed Changes

Use netcat (nc) instead of ping to check internet connection with port 443 to avoid blocks from firewalls

Related Issues

closes #166

Not sure if this actually closes #166 but I think this is a better solution anyways. Please let me know what you think @elcajon


Sub - viewports still don't handle _unhandled_input or CollisionObject._input_event()

I noticed in PR https://github.com/godotengine/godot/pull/15712 the _input event is forwarded to explicitly created Viewports, but _unhandled_input and CollisionObject._input_event() still don't respond
Godot version:
3.0.stable.official
OS/device including version:
OSX 10.13.2 (17C88)
Issue description:
The only input events that propagate into sub-viewports are _input.
_unhandled_event and _input_event (for Area2D etc) do not get called.
Steps to reproduce:
Open the attached Godot project and run it.
The Red area is in the default Viewport and receives all click events.
The green area is a child of the explicit viewport and only receives _inputevents.
Minimal reproduction project:
ViewportInputBug.zip

CC @Faless
PS. @JPTeasdale, can you try following the issue template for this and future bugs? It is hard to guess your version and OS otherwise :smiley: Also, it would be nice to have a simple project which reproduces the bug, in order to help hunting it.

Ahh, sorry about that. I thought since I included the link to the source
where _unhandled_input etc wasn't implemented it would be enough. I'll
hydrate the bug report when I get home.
On Thu, Mar 8, 2018 at 2:42 AM Bojidar Marinov<EMAIL_ADDRESS>wrote:

CC @Faless https://github.com/faless
PS. @JPTeasdale https://github.com/jpteasdale, can you try following
the issue template for this and future bugs? It is hard to guess your
version and OS otherwise 😃 Also, it would be nice to have a simple
project which reproduces the bug, in order to help hunting it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/17326#issuecomment-371443718,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQzLzYOcPF7fiiaAqdMKTNrnYvTrL2Nks5tcQUGgaJpZM4Sf8tz
.

Was wondering why input wasn't working on subviewports. Has this fallen off the radar? Is the fix for _unhandled_input just a copy/paste of #15712?

Is the fix for _unhandled_input just a copy/paste of #15712?

Sadly no, it needs some more work to get object picking to work properly. I tried a fix at some point, but never got it right.

Has this fallen off the radar?

A bit :(

@Faless Ah I see, keyboard is easy enough to do manually so that's all right. That's all right, was just a bit surprised because the doc said ViewportContainer + Viewport handled input automatically.

As a workaround I've found doing this:
extends ViewportContainer

func _unhandled_input(event):
	$Viewport.unhandled_input(event)

seems to solve the issue (at least for CollisionObject._input_event())
So perhaps the fix can be copy pasted after all?

@Xrayez, unfortunately your workaround didn't work for me, as I'm trying to use Node._unhandled_input() under the Viewport (rather than CollisionObject._input_event() as you mentioned).
I'm just getting into Godot, and after about 3 months of fiddling around, the ViewportContainer and Viewport nodes are the correct solution to the functionality I'm trying to implement, but this flaw (that _unhandled_input() is not propagated correctly) is keeping it from being successful.
I've cloned the repository and I'm willing to try figuring this out and perhaps fixing it. This will be my first attempted contribution to an open source project. However I'm not familiar with any of the Godot Engine source, so we'll see how successful I am.

Yes, I can confirm that the suggested workaround doesn't work for the master branch. I had to move event handling code out of the viewport to mitigate the problem but it'd be nice if we can have a proper fix soon.

I made it works by copying #15712 and changing it to unhandled_input so that setting the viewport container mouse filter to ignore generate physics picking event with the correct position (which forwading event by the way of the script doesn't). I am sad that it is not the proper fix but it can help peoples desperate like me while waiting for the proper fix.

I'm curious what the "proper" fix is. I've looked at the code and understood about 20% of how events propagate through the stack, and unfortunately I'm just not familiar enough with the project. Can anyone explain how the problem is supposed to be solved?

Any news on this or any good way to work around this issue with the Viewports?

Okay, it seems that I made it work with this in my case:
extends ViewportContainer

func _input(event):
	$Viewport.unhandled_input(event)

And then set Disable Input and Object Picking to true on the Viewport itself

@NightGriffin yes, which is partly the reason why this is not trivial.
Only unhandled input over the viewport should be passed down.
Object picking should probably then block any further propagation to other ViewportContainers (eg, if one viewport is partly on top of another).
Input should be properly xformed to match the actual scale/pos of the viewport.

Here's a little improvement to @reyalpsirc's temporary solution to fix the issue @NightGriffin raises, until this is supported by the engine:
func _input(event):
	if event is InputEventMouse:
		event.position -= rect_global_position
	$Viewport.unhandled_input(event)

Looks like the event object is used by other nodes after the _input call returns, so modifying its position messes up other controls. Here's a better workaround for the issue:
extends ViewportContainer

func _input( event ):
	if event is InputEventMouse:
		var mouseEvent = event.duplicate()
		mouseEvent.position -= rect_global_position
		$ClassesViewport.unhandled_input(mouseEvent)
	else:
		$ClassesViewport.unhandled_input(event)

Note that this is a temporary workaround until a proper fix is implemented in the engine. It works for me, but may not for you. I wouldn't leave it in released code. Although I don't know the full design behind input handling in Godot, it seems weird to call unhandled_input from _input, but it does the job for now.

It seems unhandled input was simply not being passed. I will add code so it gets passed, you will have to remove your hacks though.

I"m seeing this issue in 3.1.1 maybe im doing something wrong?

@EstevanBR I opened a new issue here: #31802

@EstevanBR I can confirm it seems to be fixed in 3.2.0a2 available here.

I"m seeing this issue in 3.1.1 maybe im doing something wrong?

The issue is still present in 3.2.1

I tested it and it works for me. I also tried the original minimal reproduction project and it also works.
Did you set the mouse filter on the ViewportContainer control to ignore?

You are right, the events are now passed to viewport. I had a HUD control with mouse filter pass that consumes the events (the leftover of a workaroud that was connected with this issue).
I have slightly more complicated scene: I am viewing viewport as texture in TextureRect (to have filtering while upscaling viewport from lower resolution because Godot only supports the nearest neighbour upscaling which looks really terrible in my project) and I also have HUD control layer which I display on the root viewport (thus in native screen resolution - the similar way as Unreal engine displays controls). Then if I set all the controls nodes that can cover the screen (texturerect, viewportcontainer etc.) to ignore, the unhandled events are passed but with wrong screen position (when viewport size is different than the window size) thus I can not pick objects.
I have to first transform the position of events. Not sure if this is an intended feature or a bug. Until now I have not found better solution than set all the mouse filters of controls that covers the screen (HUD, ViewportContainer, ...) to pass. Simultaneously I sent events with transformed position from _input(event) in TextureRect to _unhandled_input() of the Viewport. The position of event has to be transformed when the viewport size is different from the window size.
Maybe I am missing something since this way seems to me quite complicated and I would expect it much more straightforward.

I still got this issue when using ParallaxBackgrounds. I wanted to use Area2D and mouse enter / exit signals in a Layer in ParallaxBackground and it also won't propagate mouse events correctly

This is still an issue. I had to use the workaround in https://github.com/godotengine/godot/issues/17326#issuecomment-431186323

It's still an issue in 3.2.3, the workaround mentioned in https://github.com/godotengine/godot/issues/17326#issuecomment-425275693 doesn't work in my case.

It's still an issue in 3.2.3, mouse events don't get through, keyboard does. The unhandled_input rerouting workaround mentioned above don't fix this.

Hi everyone, I'm using Godot 3.4.2 on windows and I need to use this solution from @ArdaE to make it work.
Is there any definitive solution ?

When someone attempts a fix, please also address being able to disable input handling for all nodes inside a viewport.
I need/use it in my project, and this bug is actually a way to make it work, as i can decide whether to pass the unhandled event down (atleast it seems to work as expected in my case) from the manual override that currently is the fix.
This is what i currently use and ideally don't want to lose in functionality when this is fixed:
extends ViewportContainer

var world: Viewport

func _ready():
	world = get_child(0)

func set_active(state:bool):
	visible = state
	world.gui_disable_input = not state
	world.set_process_input(state)
	world.set_process_unhandled_input(state)
	world.set_process_unhandled_key_input(state)

func _unhandled_input(event):
	if not visible:
		return
	world.unhandled_input(event)

Can someone help create a C# version of the fix in https://github.com/godotengine/godot/issues/17326#issuecomment-431186323 ?
This issue seems to still be present in Godot today and I can't seem to figure out how to properly convert this into C# for my project.

@ashifolfi then please post your fix, as it could help others like you in the future. Thank you.

I believe there may be a regression for this in at least 4.2.beta5. I'm running into the issue when attempting to drag-and-drop a control into a subviewport. I have downloaded the repro project listed above and several of the tests are broken in the latest beta. I've looked at the code as well, and it seems like at least the code for this fix is either missing or only partially present, and this bug is part of a larger series of bugs that were previously all fixed at once - I didn't have time to check all of those.

@WolfgangSenff yes, this is a known issue, reported in #84258 and there is a PR open to fix this issue: #77926


Add phone number part3

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
#532
✅ Checklist

[ ] Github issue details are up to date for people to QA.
[ ] I have tested all my changes.

🕵♂ Notes for Code Reviewer
I tested it with the invite code I created but getting the following error, any ideas why?
mapEosError: {"code":500,"message":"Internal Service Error","error":{"code":3050003,"name":"eosio_assert_message_exception","what":"eosio_assert_message assertion failure","details":[{"message":"assertion failure with message: invite not found ","file":"wasm_interface.cpp","line_number":1075,"method":"eosio_assert"},{"message":"pending console output: ","file":"apply_context.cpp","line_number":113,"method":"exec_one"}]}}

🙈 Screenshots
There is no UI Changes.
👯♀ Paired with
@github-handle or "nobody" if you did not pair.

Invite not founds means the invite secret wasn't found

I will spend some TLC today on generating and redeeming invites and make sure it all works


Cudatoolkit v10.1

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Addresses #15

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.

Update

Everything seems to be working just fine on my local machine (ubuntu 18.04). However, due an old OS (Centos 6) used by the container, there seems to be issues with old glibc version.

stdout: Running Post installation
downloading https://developer.download.nvidia.com/compute/cuda/10.1/Prod/local_installers/cuda_10.1.243_418.87.00_linux.run to /home/conda/feedstock_root/build_artifacts/cudatoolkit-dev_1566775645864/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/pkgs/cudatoolkit-dev/cuda_10.1.243_418.87.00_linux.run
Extracting on Linux

stderr: ./cuda-installer: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by ./cuda-installer)
./cuda-installer: /usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.14' not found (required by ./cuda-installer)
./cuda-installer: /usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.15' not found (required by ./cuda-installer)
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/cudatoolkit-dev_1566775645864/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/cudatoolkit-dev-post-install.py", line 257, in <module>
    _main()
  File "/home/conda/feedstock_root/build_artifacts/cudatoolkit-dev_1566775645864/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/cudatoolkit-dev-post-install.py", line 253, in _main
    extractor.extract()
  File "/home/conda/feedstock_root/build_artifacts/cudatoolkit-dev_1566775645864/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/cudatoolkit-dev-post-install.py", line 142, in extract
    raise exc
  File "/home/conda/feedstock_root/build_artifacts/cudatoolkit-dev_1566775645864/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/cudatoolkit-dev-post-install.py", line 138, in extract
    subprocess.check_call(cmd, env=dict(DISPLAY=""))
  File "/home/conda/feedstock_root/build_artifacts/cudatoolkit-dev_1566775645864/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.7/subprocess.py", line 347, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '[PosixPath('/home/conda/feedstock_root/build_artifacts/cudatoolkit-dev_1566775645864/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/pkgs/cudatoolkit-dev/cuda_10.1.243_418.87.00_linux.run'), '--extract=/tmp/tmpd4rou7kq']' returned non-zero exit status 1.

return code: 1

With the --override change, the conda-build works in a local Centos machine.

@andersy005 could you give me commit rights to https://github.com/andersy005/cudatoolkit-dev-feedstock/ so that I could continue working on this PR?

Thanks @andersy005 , for the access!
Regarding the remaining GLIBC issue, I found this https://devtalk.nvidia.com/default/topic/1050512/cuda-setup-and-installation/error-during-installation-version-glibc_2-14-not-found/
I'll continue looking at the solution that would not require installing glibc..

OK, it looks like we are in a dead-end with this PR: cuda installer requires glibc 2.14 but azure CI build machine has glibc 2.12.
On the other hand, the built cudatoolkit-dev conda package should be usable from users machines (that have glibc 2.14 or greater). So, one solution would be to disable testing cudatoolkit-dev installation process on azure machines. This also means that cudatoolkit-dev could not be used as a dependency for packages that are built on azure CI (like omniscidb-cuda). Although, locally, in a user machine the cudatoolkit-dev dependency should work out fine.
Another solution is to downgrade cuda to a version where its installer works with glibc 2.12. v10.0 seems to be ok. This solution would hold back upgrading cuda versions until azure CI machines will have some newer glibc version installed.
@andersy005 @scopatz  Thoughts?

Re 1: I don't know, I suspect not soon, otherwise, the CI instances would not be so old..
Re 2: one option is to create glibc conda package or build glibc within the post-installation script. Here are the basic instructions:  https://www.jertype.com/posts/upgrading-glibc/

@isuruf thanks for the rhel6 hint!
@andersy005 please review.

as @andersy005 also approved that, I am merging this PR.


Feature/a is6313

We added three files: .gitignore, .md and file with list files and folders.

ok


monitor keys fail to generate except on first monitor

Bug Report
What happened:
'Error ENOENT: failed to find mgr.localhost in keyring'
What you expected to happen:
How to reproduce it (minimal and precise):
I am setting up a ceph cluster on rocky 9, I have tried stable-7 and stable-8 both with some sort of key errors. For Stable-7 its every monitor except for the first ran cannot find mgr.localhost which I can confirm doesn't exists on any monitor except the first.
Share your group_vars files, inventory and full ceph-ansibe log
Environment:

OS (e.g. from /etc/os-release): Rocky Linux 9.3
Kernel (e.g. uname -a): Linux localhost.localdomain 5.14.0-362.24.1.el9_3.x86_64 #1 SMP PREEMPT_DYNAMIC Wed Mar 13 17:33:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Docker version if applicable (e.g. docker version):
Ansible version (e.g. ansible-playbook --version): 2.15.9
ceph-ansible version (e.g. git head or tag or stable branch): stable-7.0
Ceph version (e.g. ceph -v): ceph version 17.2.7

ansible.log

it looks like ansible_facts['hostname'] for the node <IP_ADDRESS> returns localhost... host is configured the hostname on that node?

from the log you provided:
2024-03-16 18:25:02,742 p=322679 u=john n=ansible | TASK [ceph-facts : set_fact monitor_name ansible_facts['hostname']] ************************************************************************************************************************************************************************
2024-03-16 18:25:02,785 p=322679 u=john n=ansible | ok: [<IP_ADDRESS>] => (item=<IP_ADDRESS>) => changed=false
  ansible_facts:
    monitor_name: localhost
  ansible_loop_var: item
  item: <IP_ADDRESS>
2024-03-16 18:25:02,794 p=322679 u=john n=ansible | ok: [<IP_ADDRESS> -> <IP_ADDRESS>] => (item=<IP_ADDRESS>) => changed=false
  ansible_facts:
    monitor_name: localhost
  ansible_loop_var: item
  item: <IP_ADDRESS>
2024-03-16 18:25:02,804 p=322679 u=john n=ansible | ok: [<IP_ADDRESS> -> <IP_ADDRESS>] => (item=<IP_ADDRESS>) => changed=false
  ansible_facts:
    monitor_name: localhost
  ansible_loop_var: item
  item: <IP_ADDRESS>

this means it's probably a bad configuration with your environment

closing this as per #7518


Disable Navigation Bar not working

Disable Navigation Bar is not working or I did not write correctly? I tried True,true and TRUE with and without quote but none of this worked.

Interesting, it seems I don't have an example for this.
Can you please try:
<wizard [disableNavigationBar]="true">

I can also confirm that, neither disableNavigationBar="true" or [disableNavigationBar]="true" work.

I tried  [disableNavigationBar]="true" @madoar, but it only worked when I put navBarLocation=""

I'm not sure, but it's possible that we have different expectations about what disableNavigationBar should do.
When you use navBarLocation="" you tell ng2-archwizard to not show a navigation bar.
Compared to this, [disableNavigationBar]="" only disables the navigation bar, i.e. prevents the user from being able to click on the labels inside the navigation bar.

Yes I think i don't understand correctly what it does ahahaha. Sorry bro!

i'm using version 2.0 so that onece i use that code it given this error message
AppComponent.html:15 ERROR TypeError: Cannot read property 'navigation' of undefined
at AppComponent

i have the same issue

TypeError: Cannot read property 'goToNextStep' of undefined
at LoginComponent.push../src/app/login/login.component.ts.LoginComponent.updateExperienceService (login.component.ts:452


Gracefully close nvstreamer.exe

Forcefully closing nvstreamer.exe may led to disabling vibration on certain setups with Moonlight on Android devices (see here: https://github.com/moonlight-stream/moonlight-android/issues/933 )
Is it possible to gracefully close nvstreamer.exe or just leave it running?

A way to gracefully close it would be ideal. I'll try some things. Leaving it running would likely cause issues with future connection attempts.

nvstreamer.exe does not listen to graceful close requests it seems. taskkill /im nvstreamer.exe or sending a WMI WM_CLOSE window message both have no effect.
The better option may be to send a termination signal within the gamestream protocol over localhost. An initial view in Wireshark shows that some TCP requests occur when the client makes this request but it's wrapped in TLS so I can't see it. I'll have a look through Moonlight client code and see what the dependencies to generate the termination request look like.

Doesn't look like that would work either without having the UUID of the gamestream session. I'm guessing that's only available in memory and I couldn't easily pull it from somewhere, but someone let me know if there's another way.
https://github.com/moonlight-stream/moonlight-android/blob/3e0bf25acb900b99856047d8ab83861f7bb613cb/app/src/main/java/com/limelight/nvstream/http/NvHTTP.java#L708

I just did some testing and determined the correct way to gracefully close the connection. If Gamestream thinks that your application is a legit gamestream app (like moonlight_hdr_launcher) and your application creates a window it will shut down the stream when that window closes. I tested this by installing moonlight_hdr_launcher then replacing the fake andromeda exe with the sample win32 application from visual studio community 2022 (just creates a window that does nothing.) If I close the window the stream closes gracefully. This would be a relatively major change to this project as just having a window isn't enough the installation mechanism and masquerading as a gamestream supported program that isn't a launcher is also required. I've already put in a pull request that gives the option to just skip killing the streamer so I think the answer is to enable that option and alter moonlight_hdr_launcher to have a window (or an option to have a window.) Of course long term it would be nice to wrap all of this up in one project and to be honest I'm not sure if moonlight_hdr_launcher supports not enabling hdr. I'm not going to bother checking as it doesn't create a window anyway. So long story short I think my added switch to skip killing the stream process is the correct short term solution and the long term solution would be to move to an installer like moonlight_hdr_launcher that pretends to be a supported game along with the creation of a window.


Sealed object properties not checked in conditionals

Is it correct that sealed object properties are not checked in conditional statements?
For example:
// Create a sealed object
const o = {
  Foo: 'Foo',
};

// Reports an Error
const fooz = o.Fooz;

// Reports an Error
const x = o.Fooz === 'Bar';

// Does not report an error
if (o.Fooz === 'Bar') {}

// Does not report an error
const y = (o.Fooz === 'Bar') ? true : false;

Edit: Added some more examples. It looks like intermediate expressions (the if statement and the ternary) do not have the type check applied.

Non-existence is not an error within a conditional expression. See the comment from https://github.com/facebook/flow/blob/c9131da361ab03e64227d870ec113bd030993a3e/src/typing/statement.ml#L4453-L4456

@popham many thanks for clarifying.


respect common system variables

I know this is not a top priority but I need it before I can port the tool for Pentoo.
There are two important variables (at least) PREFIX and DESTDIR.
Could you please update the Makefile?
Edit: I have also fixed typo in the LDFLAGS

can we close this?

Yes, we fixed it. Thank you so much!


BAU Throw 400 if registering with disconnected IDP

See this Zendesk ticket: https://govuk.zendesk.com/agent/tickets/3474574
We had some 500s from users trying to register with IDPs that were no
longer offering registrations, via the /redirect-to-idp-warning page.
They probably used a bookmark, or a direct link after visiting the sign
in page to set one of the invalid suppliers in selected in their
session.

I'm going to close the PR for now. The branch will still be here if it's decided it's the right approach.


chore(deps): :arrow_up: update dependency firebase-admin to v11.10.0

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

firebase-admin (source)
11.9.0 -> 11.10.0

Release Notes

firebase/firebase-admin-node (firebase-admin)
v11.10.0: Firebase Admin Node.js SDK v11.10.0
Compare Source
New Features

feat(functions): Add features to task queue functions (#2216)
feat(auth): Add TotpInfo field to UserRecord (#2197)
feat(storage): Add getDownloadUrl method to the Storage API (#2036)

Bug Fixes

fix: Update TOTP docstrings (#2245)

Miscellaneous

[chore] Release 11.10.0 (#2246)
chore: upgrade databse-compat (#2244)
build(deps): bump semver from 5.7.1 to 5.7.2 (#2242)
build(deps-dev): bump @microsoft/api-extractor from 7.36.0 to 7.36.1 (#2239)
build(deps-dev): bump sinon from 15.0.4 to 15.2.0 (#2240)
Fixed docgen for getDownloadURL (#2241)
Fix Memory Leak in AsyncHttpCall affecting auth.listUsers (#2236)
build(deps): bump @google-cloud/storage from 6.9.5 to 6.11.0 (#2231)
build(deps): bump @google-cloud/firestore from 6.6.0 to 6.6.1 (#2232)
build(deps-dev): bump @firebase/app-compat from 0.2.7 to 0.2.13 (#2233)
Fixes to password policy validation (#2227)
Fix nesting in auth config tests (#2228)
build(deps-dev): bump eslint from 8.41.0 to 8.43.0 (#2218)
build(deps-dev): bump @typescript-eslint/eslint-plugin (#2223)
build(deps-dev): bump @microsoft/api-extractor from 7.34.4 to 7.36.0 (#2219)
build(deps): bump @types/node from 18.16.3 to 20.3.2 (#2224)
Expose MultiDB within Firestore (#2209)
build(deps-dev): bump @typescript-eslint/parser from 5.59.2 to 5.59.9 (#2205)
build(deps-dev): bump @types/lodash from 4.14.194 to 4.14.195 (#2206)
build(deps-dev): bump @firebase/auth-compat from 0.4.1 to 0.4.2 (#2208)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular-devkit/build-angular
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS><17.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/jest-preset-angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!   2 more (@nx/angular, @storybook/angular)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@angular/compiler
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/localize
npm ERR!     peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@angular-devkit/build-angular
npm ERR!       dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-07-15T20_31_13_170Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-07-15T20_31_13_170Z-debug-0.log


Application crash due to ServiceBusClientWebSocket.ConnectAsync

Under high load our app which uses servicebus eventhubs to send telemetry data from background thread crashed with exception stack below. This is .net 4.5.2 desktop version and using 4.1.6 version of WindowsAzure.ServiceBus package.
The crash happens when application is under load. which is about 600 app instances running on a server, one of them will crash with below error
Unhandled Exception: System.AggregateException: One or more errors occurred.
---> System.Net.WebException: The request was canceled    at System.Net.ServicePointManager.FindServicePoint(Uri address, IWebProxy proxy, ProxyChain& chain, HttpAbortDelegate& abortDelegate, Int32& abortState)
at System.Net.HttpWebRequest.FindServicePoint(Boolean forceFind)
at System.Net.HttpWebRequest.Abort(Exception exception, Int32 abortState)
at System.Net.HttpWebRequest.Abort()
at Microsoft.ServiceBus.ServiceBusClientWebSocket.<>c.b__45_0(Object s)
at System.Threading.CancellationCallbackInfo.ExecutionContextCallback(Object obj)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.CancellationCallbackInfo.ExecuteCallback()
at System.Threading.CancellationTokenSource.CancellationCallbackCoreWork(CancellationCallbackCoreWorkArguments args)
at System.Threading.CancellationTokenSource.ExecuteCallbackHandlers(Boolean throwOnFirstException)
--- End of inner exception stack trace ---
at System.Threading.CancellationTokenSource.ExecuteCallbackHandlers(Boolean throwOnFirstException)
at System.Threading.CancellationTokenSource.NotifyCancellation(Boolean throwOnFirstException)
at System.Threading.CancellationTokenSource.TimerCallbackLogic(Object obj)
at System.Threading.TimerQueueTimer.CallCallbackInContext(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.TimerQueueTimer.CallCallback()
at System.Threading.TimerQueueTimer.Fire()
at System.Threading.TimerQueue.FireNextTimers()
at System.Threading.TimerQueue.AppDomainTimerCallback()

Same issue here under high load.

Approximately 100 concurrent C# tasks in a windows service
Pumping order updates to azure service bus
.NET 4.6.2 - I could upgrade if needed
I upgraded to WindowsAzure.ServiceBus 4.1.10 and it did not resolve the issue

I ended up adding a lock to work around this for now.
Removing the lock here reproduces the issue.
    static object _servicebusorderlock = new object();

    public void SendMessageOrderUpdate(string subJson)
    {
        lock (_servicebusorderlock)
        {
            try
            {
                byte[] bytes = Encoding.UTF8.GetBytes(subJson);
                MemoryStream stream = new MemoryStream(bytes, writable: false);
                BrokeredMessage message = new BrokeredMessage(stream) {ContentType = "application/json"};
                var factory = MessagingFactory.CreateFromConnectionString(_serviceBusConnectionString);
                var sender = factory.CreateMessageSender("OrderUpdate");
                sender.Send(message);
            }
            catch (Exception exc)
            {
                ErrorUtil.RecordException(exc);
            }
        }
    }

at System.Threading.CancellationTokenSource.ExecuteCallbackHandlers(Boolean throwOnFirstException)
at System.Threading.CancellationTokenSource.NotifyCancellation(Boolean throwOnFirstException)
at System.Threading.CancellationTokenSource.TimerCallbackLogic(Object obj)
at System.Threading.TimerQueueTimer.CallCallbackInContext(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.TimerQueueTimer.CallCallback()
at System.Threading.TimerQueueTimer.Fire()
at System.Threading.TimerQueue.FireNextTimers()
at System.Threading.TimerQueue.AppDomainTimerCallback()

Thanks for reaching out. We recommend to update your solution to use the current .Net SDK.
We are going to be closing this issue, but if you have additional questions, please create a new issue in https://github.com/Azure/azure-service-bus.


Better support for table headers

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
Table headers often want styling separately to the rest of the table. This styling needs to easily cascade to all the elements within the table header (such as TableSortLabel). Ideally it would be possible to configure the table styling is part of the theme so that tables have a consistent look across the whole site.
The current examples on https://material-ui.com/components/tables/#customized-tables are too limited. If you try and add a TableSortLabel to the current example that has a black header you the label ends up with black text on a black background when it is active.
There is no obvious or simple way to correct the sort label, or any other themed component that is added into the table header. Ideally I should be able to set theme for table headers only, that has a specific background, text colour, primary, secondary, etc and have that theme picked up by all the components within the header.
Examples 🌈
As an example it is very simple to render the entire table on a dark background, such as by setting the palette type to dark.
const theme = createMuiTheme({ palette: { type: 'dark' } })
<ThemeProvider theme={theme}>
  <MaterialTable .../>
</ThemeProvider>

However, is it much more difficult to acheive this with only the header, as you have to individually override the various background and foreground colors of every element that is rendered into the table header.
A worked example showing some of the issues is at https://codesandbox.io/s/material-demo-g42ox
This shows the original enhanced table that has sorting, and then the enhanced table extended with a custom style. Ideally, we would be able to change the theming for the table header without having to modify the enhanced table.

In the example there are two points to take notice of:

The currently sorted header is not visible (black on black)
No good choice from the palette for the background/text colours that components can use to ensure consistency across all table like components.

Motivation 🔦
A very common requirement is to have specific styling on table headers (such as a different background, bold text, etc).
It should be as simple as updating the theme to re-style all table headers on the page, and all elements nested within the header. This shouldn't involve having to pass large collections of classes down the component tree or extend every element with a custom styled one.
Often you do not even have direct access to the underlying header to style it, as its wrapped in other components such as material-table or mui-datatable. This can make it even more challenging to correctly theme the TableSortLabel.
Despite the material design guide not mentioning table headers, every system I use has some sort of alternate style for headers, even when they're following a material like design. Even the main material.io site has a very light grey background for all of its tables.

@chilversc The customization example isn't meant to be comprehensive. It's up to you to apply the colors you see fit.

My main issue here is there's no sensible way to do this with the way tables currently work. I would have expected to just update the background/foreground colours for the header (e.g. by changing the theme) and everything would then cascade to all the components within the header.
Instead you have to create a custom styled component for every possible component you might want to put in the table header. As far as I can tell, this means for components such as material-table or mui-datatable, I have to pretty much rip out the entire existing header implementation and rewrite it so I can fully control things like the labels within the header.
Really all I should need to do is update a single theme property, so that any component inside the header renders with the correct foreground/background/accent.

everything would then cascade to all the components within the header.

@chilversc This is not possible with the text.secondary color palette. You would need to customize it.

I have to pretty much rip out the entire existing header implementation and rewrite it so I can fully control things like the labels within the header.

I wouldn't expect this outcome. You can apply global overrides to the component with one of these 3 options: global classnames, or theme.overrides, or wrapper component (material-table or mui-datable might not accept it but our upcoming DataGrid component will).

Really all I should need to do is update a single theme property, so that any component inside the header renders with the correct foreground/background/accent.

How would that work, at the implementation level?

What I tried at first was wrapping a ThemeProvider around just the TableHead component but that didn't work (I wasn't really expecting it to).
The trouble I have with overrides is they override those components no matter where they are in the table (even if they're in the body). Also I found them very difficult to work with as a lot of the internal details for the styles are not documented and you have to dig them out the source code.
For example I expected this to work to override the sort label, based on the docs at https://material-ui.com/api/table-sort-label/
createMuiTheme({
  overrides: {
    MuiTableSortLabel: {
      root: {
        color: "white"
      },
      active: {
        color: "white"
      },
      icon: {
        color: "white"
      }
    }
  }
});

However, the actual code needed is this
createMuiTheme({
  overrides: {
    MuiTableSortLabel: {
      root: {
        color: "white",
        "&:focus": {
          color: "#ccc"
        },
        "&:hover": {
          color: "#ccc"
        },
        "&$active": {
          color: "white",
          "&& $icon": {
            color: "white"
          }
        }
      }
    }
  }
});

Full example https://codesandbox.io/s/mui-table-override-header-issue-7dr5j?file=/src/App.js
Without digging into the source code for that example I don't know how you would ever find that out, and that is just a single component. Also I feel that is fragile, any small change to the style in the component and the override could stop working.
The part I find most annoying about this is the original style has perfect place holders for all the values I need to change:
    '&$active': {
      color: theme.palette.text.primary,
      '&& $icon': {
        opacity: 1,
        color: theme.palette.text.secondary,
      },
    },

So all I really need is a way to say, in a table header, use this palette for the theme.
Because table headers are so ubiquitous, and often all want to share the same common styling, it just seems like I should be able to configure this alternate palette for table headers as part of the theme, and then any component using <TableHead> would pick it up, and any components inside the header would also be themed correctly.

What I tried at first was wrapping a ThemeProvider around just the TableHead component but that didn't work (I wasn't really expecting it to).

@chilversc It would expect it to work.

I don't know how you would ever find that out

By inspecting the element in the dev tools. You should have all the information you need. It's about overriding these styles:

any small change to the style in the component and the override could stop working.

Do you have an example of a change that you would expect to break this override? I believe it should stable.

So all I really need is a way to say, in a table header, use this palette for the theme.

I agree that they might be an opportunity to do better.

One way could be to accept a theme prop that we deep merge with the theme in the context. Styled components has something similar: https://styled-components.com/docs/advanced#the-theme-prop.

createMuiTheme( {
  overrides: {
    MuiTableCell: {
      head: {
        background: 'black',
        color: 'white',
      },
    },
  },
  props: {
    MuiTableSortLabel: {
      theme: {
        palette: {
          text: {
            secondary: 'white',
          },
        },
      },
    },
  },
});

Another way would be to accept configuration variables. The traditional approach used by Bootstrap, Vuetify, etc.
Any other idea?

That's where I'm not sure at the moment, need to have a good think. I know something is wrong just not sure how best to solve it.
It's just that branded / styled headers on tables are so common it feels like something that should be trivial to achieve. Instead, as someone coming to the library for the first time I'm immediately having to play around with overriding styles, or customising styles in 3rd party components which is quite complex.
In things like bootstrap, I would just change the palette options for table headers, and most components inherit their text colour while in material I was finding many components explicitly set their text colour.
This leaves me with several main concepts that I've been considering:

Should palettes include extra options for table headers?

This needs a way to cascade to components used within the header.

Make more use of cascading styles.

Inherit text, border, background colours from the container.
Fewer elements should explicitly set their text/background/border colours.
This needs to include components such as the table sort icon.
Ideally this would mean any simple component would even render correctly inside an alert.

Some how the palette for text, background, borders, primary, secondary, accent, etc. needs to be linked to the background colour.

This seems a lot like switching theme/palette.
Does this have an parallels with the concept that tables can be dense?

I wouldn't want to restrict this to just table headers if possible, as I could a use in also branding other headers, such as for cards to make them stand out in certain conditions.

Using cascading styles
Within bootstrap, I think the standard approach was mixins that accepted a variable, this would then let you quickly create a new class that applies a theme to all the elements within a container that has that class. In material this seems analogous to a theme or a palette.

NOTE:  I'm not sure how well this will translate to the current material design where the components seem to be attempting their best to isolate themselves from cascading styles.

The end result is you might end up with like:
p { color: black }
.icon { color: #333 }

.danger p { color: red }
.danger .icon { color: #300 }

Thus then in the html you would have:

     ...

  ...

The idea here is the main classes used on the individual elements shouldn't change their name, thus you don't have .icon-danger and need to then use .icon-danger within a danger section. However, I think in Material UI (correct me if this is wrong), when you change the theme, all the class names are going to change? When really the class names should remain the same, and a new set of styles should be generated, scoped to that theme (which selected by apply a class to the container).
As an example, when using multiple themes you end up with:
// inside light theme (main)

// inside dark theme (nested)

These are logically the same component, just with different styles so I'd have been expecting both class names to be the same:
// Same as before since this is the main style

  // Where possible we shouldn't create component specific styles
  // this would allow one common style that defines the secondary colours

// switch to the dark theme within this div

.colorSecondary {
    color: #f50057
    background: ...
    border-color: ...
    // etc
}

.theme-308 .colorSecondary {
    color: #f50057
}

Did someone have a better solution to keep the header label as white only? Can someone share the css to override the header getting black? I tried using above approaches but it's impacting other components.
Any help will be really appreciated.


enabled recommended-strict for es-lint

I've enabled @typescript-eslint/strict-type-checked and fixed all eslint errors

Hi Christian, sounds good. It looks like something went wrong with that PR. Can you create another one?


add loader when the login button is clicked

when the login button is clicked the website do not show any loading while processing the request
i want to add a loader while the website performs user login request

please assign this issue to me @Luson045

when the login button is clicked the website do not show any loading while processing the request
i want to add a loader while the website performs user login request

please assign this issue to me @Luson045

@AyushSharma72  okay you can go for it.

@AyushSharma72 okay you can go for it.

Thanks

@AyushSharma72  I'm closing this issue, as there is already an issue which covers this issue.. please read the pinned issue..


RichCommands: Open settings

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #11481

I'd like to add a shortcut. Which one is better: Ctrl + S, Alt + S or anything else?
Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[x] Did you implement any design changes to an existing feature?

[x] Was this change approved?

[x] Are there any other steps that were used to validate these changes?

Open settings

ctrl + ,

General question: why do you guys never use x:UID to fetch strings?
https://learn.microsoft.com/dotnet/desktop/xaml-services/xuid-directive

General question: why do you guys never use x:UID to fetch strings?

Honestly, I've never heard of it. Isnt' it only supported by UWP and WPF?

Binding to the strings allows us to have more control over the strings, it's also more readable since you can tell which properties are being translated at a glance.

Please don't use the closes tag for these PRs 😃

Please don't use the closes tag for these PRs 😃

I'm sorry I always forget to change that

Can you add this to the documentation?

Yeah sure


Added listing of Hub Facilities in Facility Home

Proposed Changes

Fixes #8719

@ohcnetwork/care-fe-code-reviewers
Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[ ] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

[ ] remove the duplicate facility name in the facility details page

LGTM


ome-types.readthedoc - attribute tiff_data in Pixels

Hi @tlambert03 ,
I noticided that for "Pixels" the attribure name "tiff_data" is not working and lead to the error:

sys:1: UserWarning: Unrecognized fields for type <class 'ome_types._autogenerated.ome_2016_06.pixels.Pixels'>: {'tiff_data'}

However, it seems to work when the attribute name is "tiff_data_blocks".
Readthedocs issue:

[ ] Fix the "readthedocs" for the "pluralized" names in the schema

ah, good catch.  Actually this is going to be true for all of the "pluralized" names in the schema.  So yes, readthedocs need to be fixed, which means that actually the (autogenerated) docstrings themselves need to be fixed... making it a bit more complicated.  Thanks for the heads up.  will fix xoon

No problem, it is nice to contribute to ome-types :)
I will just add a task list to the issue to keep it tracked.

Fixed now, thanks for reporting!


Missing tests

[ ] Add regression tests for parsing @kdheepak #107
[ ] parsestandardfiles() with a time series folder specification
[x] cdm_parser @claytonpbarrows
[ ] json2ps_parser.jl @claytonpbarrows  can you confirm this is still necessary?
[x] @errors in pm2ps_parser.jl
[ ] pm_oi @kdheepak can you take a look a this folder missing tests?  #102
[x] ybus_calculations.jl @jd-lara #80 #79
[x] print.jl @jjstickel

@daniel-thom We had this issue opened about the parsing testing that is relevant to today's conversation. Many of the missing tests are relevant to the parsing.

@jd-lara Regarding the @error messages in pm2ps_parser.jl, is your point that we should have negative tests that trip these errors?  Secondly, if they are fatal errors then I propose we throw an exception instead of just logging it.  Do you agree?

@claytonpbarrows and @daniel-thom what's the status of this issue?


BUG: Text not appearing on testimonial over flip.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Hello,
When the testimonial is flipped on hover, the text doesn't appear, and a blank card shows up.

Please assign me this issue , I will solve this task.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Hello,
When the testimonial is flipped on hover, the text doesn't appear, and a blank card shows up.

Please assign me this issue , I will solve this task.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

fix this!


[Code Improvement]: Add stylecheck to golangci-lint

Implementation ideas
stylecheck is the replacement for golint.
This is a good linter for maintaining a consistent coding style across the repo. I don't think it is catching any bugs at present but could lead to bugs due to varying code standards.
here are some errors that it catches in the rollkit repo at present
rollkit % make lint
--> Running golangci-lint
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner/nolint] Found unknown linters in //nolint directives:
log/logger.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
package log
^
da/da.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
package da
^
conv/abci/block.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
package abci
^
node/full_client.go:68:22: ST1016: methods on the same type should have the same receiver name (seen 1x "rpc", 35x "c") (stylecheck)
func (c *FullClient) ABCIInfo(ctx context.Context) (*ctypes.ResultABCIInfo, error) {
                     ^
types/serialization.go:80:24: ST1016: methods on the same type should have the same receiver name (seen 3x "sH", 5x "h") (stylecheck)
func (h *SignedHeader) FromProto(other *pb.SignedHeader) error {
                       ^
node/block_exchange.go:27:1: ST1021: comment on exported type BlockExchangeService should be of the form "BlockExchangeService ..." (with optional leading article) (stylecheck)
// P2P Exchange Service for block that implements the go-header interface.
^
node/exchange.go:7:1: ST1021: comment on exported type SyncerStatus should be of the form "SyncerStatus ..." (with optional leading article) (stylecheck)
// Used by header and block exchange service for keeping track of
^
node/header_exchange.go:27:1: ST1021: comment on exported type HeaderExchangeService should be of the form "HeaderExchangeService ..." (with optional leading article) (stylecheck)
// P2P Exchange Service for header that implements the go-header interface.
^
block/manager.go:641:10: ST1005: error strings should not be capitalized (stylecheck)
                return fmt.Errorf("Failed to submit block to DA layer after %d attempts", maxSubmitAttempts)
                       ^
libs/shares/share_builder.go:25:1: ST1020: comment on exported function NewBuilder should be of the form "NewBuilder ..." (stylecheck)
// Init() needs to be called right after this method
^
libs/shares/share_builder.go:156:1: ST1020: comment on exported method WriteSequenceLen should be of the form "WriteSequenceLen ..." (stylecheck)
// writeSequenceLen writes the sequence length to the first share.
^
node/block_exchange.go:113:1: ST1020: comment on exported method Start should be of the form "Start ..." (stylecheck)
// OnStart is a part of Service interface.
^
node/block_exchange.go:189:1: ST1020: comment on exported method Stop should be of the form "Stop ..." (stylecheck)
// OnStop is a part of Service interface.
^
node/header_exchange.go:113:1: ST1020: comment on exported method Start should be of the form "Start ..." (stylecheck)
// OnStart is a part of Service interface.
^
node/header_exchange.go:187:1: ST1020: comment on exported method Stop should be of the form "Stop ..." (stylecheck)
// OnStop is a part of Service interface.
^
types/test_utils.go:11:1: ST1020: comment on exported function GetRandomValidatorSet should be of the form "GetRandomValidatorSet ..." (stylecheck)
// TODO: accept argument for number of validators / proposer index
^
make: *** [lint] Error 1

Related: https://github.com/rollkit/rollkit/issues/504

Refer to https://github.com/celestiaorg/celestia-node/blob/main/.golangci.yml for adding relevant golangci-lint


Deprecate Hooks?

They're very Snabbdom specific, it's exposing a lot about the engines internals to allow it.

Hooks have been removed for now.


Vocable Android: Parity - Main Screen Category Selection.

Found on build 1.3.3.
Describe the bug
On the Main screen, in Portrait view, there is only 1 category displayed at a time.  on iOS, when tapping on either the right or left scroll, it not only scrolls to the next Category but it selects it as well.
To Reproduce
1.) Launch the app in Portrait view
2.) Select the category if not already.
3.) Press the Right arrow button to go to the next category
Expected behavior
New category to be displayed and selected.
Actual Behavior
New category is displayed, but it is not selected so it requires an extra click.  Also the new category is displayed
Screenshots
If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):

Device: Pixel 2 API 30 simulator

@cxw320: I believe you fixed this correct?


Allow passing of a glob at the command line

Nice utility -- I'm gonna work on a guard plugin, thought this might be a useful addition.

I appreciate this but I don't think it's necessary.
If I do
spin push test/unit/*.rb

then bash takes care of globbing the files and spin push receives a list of files on ARGV. I know that zsh has similar functionality. Is that not working for you?
And I'd love to see a guard plugin :metal:

looks like someone started a guard-spin gem. But... it doesn't seem to work yet.
https://github.com/jonsgreen/guard-spin

I'm assuming that my comment about bash globbing holds. Closing.


Iptables error with Arch Linux on armhf (Scaleway)

An updated CRL has been created.
CRL file: /etc/openvpn/easy-rsa/pki/crl.pem

Bad argument `eth0'
Try `iptables -h' or 'iptables --help' for more information.
sh: th0: command not found
sh: th0: command not found
2334
Created symlink<EMAIL_ADDRESS>→<EMAIL_ADDRESS>
I'm not sure if it's related to Arch Linux, armfh or Scaleway.

I've tested the 2.4-branch this morning and didn't get such an error on an arch system.

I've tried on a Arch Linux VM too and I didn't get any issue. Well who wants to use Arch on a Scaleway C1 anyway

So this was fixed by https://github.com/Angristan/OpenVPN-install/commit/aca3b4a019c3545331e2f8e39af65ac730501d6a
However, the trafic is still not forwarded by the server. This issue looks a lot like https://github.com/Angristan/OpenVPN-install/issues/125, I wonder if they're related.

There is no Arch Linux available on the C1 anymore.