Cython 3.0.0b1 and its impact on packages in Fedora

Describe your issue
Hello,
I've tried to rebuild all Python packages in Fedora Rawhide (Fedora 39, development version) requiring Cython with new Cython 3.0.0b1. Out of 181 packages, 67 of them succeeded with legacy Cython 0.29.33 but failed with 3.0.0b1. 21 packages failed with both Cythons, those were ignored. I used Python 3.11.2 on x86_64. I went through the logs and I'd like to present the failures I've encountered. I've only kept very small log snippets to save some space. If you are curious about the complete logs, each package name links to COPR build system where you can find it. E.g. scipy, to see a log, click on build ID and then choose builder-live.log.gz (choose the one in the table at the bottom, not the one that says Source build logs). I've grouped the failures that I assumed are similar enough.
The logs might be garbage-collected in few weeks. Feel free to ping me or @hroncok to restart the build.
 NULL' to 'char *(*)(const libscols_column *, char *, void *) noexcept'

- python-tables
tables/utilsextension.pyx:382:47: Cannot assign type 'herr_t (unsigned int, const H5E_error_t *, void *) except? -1 nogil' to 'H5E_walk_t'

- scipy
_biasedurn.pyx:118:39: Cannot assign type 'double (*)(void) except? -1 nogil' to 'double (*)(void) noexcept nogil'

- urh
src/urh/dev/native/lib/airspy.pyx:86:46: Cannot assign type 'int (airspy_transfer *) except? -1 nogil' to 'airspy_sample_block_cb_fn'

(others) Cannot assign type 'XXX' to 'YYY' (7 affected projects)
- libgpuarray
pygpu/collectives.pyx:394:55: Cannot assign type 'double' to 'size_t'

- music
pybuffer.pyx:63:31: Cannot assign type 'double' to 'Py_ssize_t'

- pygame
src_c/cython/pygame/_sdl2/mixer.pyx:45:27: Cannot assign type 'mixcallback' to 'void (*)(void *, Uint8 *, int) noexcept nogil'

- python-jnius
jnius/jnius_conversion.pxi:521:45: Cannot assign type 'double' to 'jsize'

- python-peewee
playhouse/_sqlite_ext.pyx:608:40: Cannot assign type 'double' to 'sqlite3_int64'

- python-pysam
pysam/libcalignedsegment.pyx:1426:37: Cannot assign type 'double' to 'Py_ssize_t'

- python-statmodels
statsmodels/tsa/exponential_smoothing/_ets_smooth.pyx:156:55: Cannot assign type 'npy_float64 complex' to 'float64_t'

 is not a type identifier (5 affected projects)
- libarrow
pyarrow/_compute.pxd:45:42: 'Schema' is not a type identifier

- mlpack
mlpack/image_converter.pyx:91:7: 'Params' is not a type identifier

- python-cysignals
src/cysignals/signals.pyx:39:4: 'cysigs_t' is not a type identifier

- python-giacpy
giacpy/giacpy2qcas.pyx:10:11: 'Pygen' is not a type identifier

- python-pyedflib
pyedflib/_extensions/_pyedflib.pyx:137:9: 'edf_hdr_struct' is not a type identifier
pyedflib/_extensions/_pyedflib.pyx:457:9: 'edf_annotation_struct' is not a type identifier

Various cimports/imports not found (3+2 affected projects)
- mlpack
mlpack/image_converter.pyx:1:8: 'arma.pxd' not found
mlpack/image_converter.pyx:2:8: 'arma_numpy.pxd' not found
mlpack/image_converter.pyx:3:0: 'io.pxd' not found
mlpack/image_converter.pyx:3:0: 'io/IO.pxd' not found
mlpack/image_converter.pyx:4:0: 'params.pxd' not found
mlpack/image_converter.pyx:4:0: 'params/Params.pxd' not found
mlpack/image_converter.pyx:5:0: 'timers.pxd' not found
mlpack/image_converter.pyx:5:0: 'timers/Timers.pxd' not found
mlpack/image_converter.pyx:6:0: 'io/SetParam.pxd' not found
mlpack/image_converter.pyx:6:0: 'io/SetParamPtr.pxd' not found
mlpack/image_converter.pyx:6:0: 'io/SetParamWithInfo.pxd' not found
mlpack/image_converter.pyx:6:0: 'io/GetParamPtr.pxd' not found
mlpack/image_converter.pyx:7:0: 'io/EnableVerbose.pxd' not found
mlpack/image_converter.pyx:7:0: 'io/DisableVerbose.pxd' not found
mlpack/image_converter.pyx:7:0: 'io/DisableBacktrace.pxd' not found
mlpack/image_converter.pyx:7:0: 'io/ResetTimers.pxd' not found
mlpack/image_converter.pyx:7:0: 'io/EnableTimers.pxd' not found
mlpack/image_converter.pyx:10:0: 'serialization.pxd' not found
mlpack/image_converter.pyx:10:0: 'serialization/SerializeIn.pxd' not found
mlpack/image_converter.pyx:10:0: 'serialization/SerializeOut.pxd' not found
mlpack/image_converter.pyx:10:0: 'serialization/SerializeOutJSON.pxd' not found
mlpack/image_converter.pyx:10:0: 'serialization/SerializeInJSON.pxd' not found

- python-giacpy
giacpy/giacpy2qcas.pyx:1:8: 'giacpy2qcas.pxd' not found
giacpy/giacpy2qcas.pyx:6:0: 'giacpy/Pygen.pxd' not found
giacpy/giacpy2qcas.pyx:7:0: 'giacpy/context_ptr.pxd' not found

- python-pyedflib
pyedflib/_extensions/_pyedflib.pyx:25:8: 'c_edf.pxd' not found

- numpy
ModuleNotFoundError: No module named '_pickleable_module_global'

- python-healpy
ModuleNotFoundError: No module named '_pixelfunc'

Cannot convert Python object to '' (4 affected projects)
- libarrow
pyarrow/_compute.pyx:337:55: Cannot convert Python object to 'CMemoryPool *'

- python-cysignals
src/cysignals/signals.pyx:168:21: Cannot convert Python object to 'PyObject *'

- python-gevent
giacpy/giacpy2qcas.pyx:16:36: Cannot convert Python object to 'gen'

- sagemath
sage/ext/stdsage.pxd:22:40: Cannot convert Python object to 'PyObject *'

Compiler crash in AnalyseExpressionsTransform (3 affected projects)
- mlpack
mlpack/image_converter.pyx:131:28: Compiler crash in AnalyseExpressionsTransform

- python-pyedflib
pyedflib/_extensions/_pyedflib.pyx:205:22: Compiler crash in AnalyseExpressionsTransform

- python-pywt
pywt/_extensions/_pywt.pyx:400:37: Compiler crash in AnalyseExpressionsTransform

Pinned Cython < 3 version (3 projects)
- python-neatdend
requirements/requirements.txt:cython~=0.29.4

- python-shapely
requirements-dev.txt:cython>=0.29.24

- python-uvloop
setup.py:CYTHON_DEPENDENCY = 'Cython(>=0.29.32,<0.30.0)'

undefined symbol PyMemoryview_Check (2 affected projects)
- borgbackup
E   ImportError: /builddir/build/BUILDROOT/borgbackup-1.2.3-2.fc39.x86_64/usr/lib64/python3.11/site-packages/borg/compress.cpython-311-x86_64-linux-gnu.so: undefined symbol: PyMemoryview_Check

- netcdf4
ImportError:    /builddir/build/BUILD/netcdf4-python-1.6.2rel/build/lib.linux-x86_64-cpython-311/netCDF4/_netCDF4.cpython-311-x86_64-linux-gnu.so: undefined symbol: PyMemoryview_Check

ambiguous overloaded method (2 affected projects)
- cantera
build/python/cantera/delegator.pyx:253:33: ambiguous overloaded method

- libarrow
pyarrow/_compute.pyx:1541:24: ambiguous overloaded method

no suitable method found (2 affected projects)
- cantera
build/python/cantera/delegator.pyx:254:26: no suitable method found

- libarrow
pyarrow/_compute.pyx:450:32: no suitable method found

The keyword 'nogil' should appear at the end of the function signature line. Placing it before 'except' or 'noexcept' will be disallowed in a future version of Cython. (2 affected projects)
- libarrow
pyarrow/lib.pxd:67:60: The keyword 'nogil' should appear at the end of the function signature line. Placing it before 'except' or 'noexcept' will be disallowed in a future version of Cython.

- python-cysignals
src/cysignals/signals.pxd:57:56: The keyword 'nogil' should appear at the end of the function signature line. Placing it before 'except' or 'noexcept' will be disallowed in a future version of Cython.

cimported module has no attribute 'numpy_to_mat_d' (2 affected projects)
- mlpack
mlpack/image_converter.pyx:131:28: cimported module has no attribute 'numpy_to_mat_d'

- python-pyedflib
pyedflib/_extensions/_pyedflib.pyx:118:16: cimported module has no attribute 'edflib_version'
pyedflib/_extensions/_pyedflib.pyx:171:17: cimported module has no attribute 'edfclose_file'
pyedflib/_extensions/_pyedflib.pyx:205:22: cimported module has no attribute 'edfopen_file_readonly'

TypeError: unsupported operand type(s) for -: 'XXX' and 'YYY' (2 affected projects)
- python-cftime
TypeError: unsupported operand type(s) for -: 'datetime.datetime' and 'cftime._cftime.DatetimeGregorian'

- python-orderedset
TypeError: unsupported operand type(s) for -: 'list' and 'OrderedSet'
TypeError: unsupported operand type(s) for &: 'list' and 'OrderedSet'
TypeError: unsupported operand type(s) for |: 'list' and 'OrderedSet'

Cannot convert '' to Python object (2 affected projects)
- libarrow
pyarrow/_compute.pyx:360:26: Cannot convert 'CDatum' to Python object

- python-cysignals
src/cysignals/signals.pyx:321:27: Cannot convert 'void *' to Python object

undeclared name not builtin: XXX (2 affected project)
- libarrow
pyarrow/_compute.pyx:337:32: undeclared name not builtin: maybe_unbox_memory_pool

- python-cysignals
src/cysignals/signals.pyx:310:4: undeclared name not builtin: sig_check

error: unknown file type '.pyx'/'.pxd' (2 affected project)
- python-compreffor
error: unknown file type '.pyx' (from 'src/cython/_compreffor.pyx')

- python-hidapi
error: unknown file type '.pxd' (from 'chid.pxd')

Rvalue-reference as function argument not supported (1 affected project)
- libarrow
pyarrow/includes/libarrow.pxd:1535:24: Rvalue-reference as function argument not supported

First base of 'ScalarUdfContext' is not an extension type (1 affected project)
- libarrow
pyarrow/_compute.pxd:24:28: First base of 'ScalarUdfContext' is not an extension type

Storing unsafe C derivative of temporary Python reference (1 affected project)
- libarrow
pyarrow/_compute.pyx:337:12: Storing unsafe C derivative of temporary Python reference

Casting temporary Python object to non-numeric non-Python type (1 affected project)
- libarrow
pyarrow/_compute.pyx:661:17: Casting temporary Python object to non-numeric non-Python type

Invalid operand type for '*' (Python object) (1 affected project)
- libarrow
pyarrow/_compute.pyx:2507:8: Invalid operand type for '*' (Python object)

Type is not specialized (1 affected project)
- mlpack
mpi4py/MPI/Datatype.pyx:851:50: Type is not specialized

Invalid types for '!=' (Python object, void *) (1 affected project)
- python-cysignals
src/cysignals/signals.pyx:368:24: Invalid types for '!=' (Python object, void *)

AttributeError: module 'collections' has no attribute 'MutableSequence' (1 affected project)
- python-djvulibre
AttributeError: module 'collections' has no attribute 'MutableSequence'

TypeError: Argument 'x' has incorrect type (expected float, got int) (1 affected project)
- python-ezdxf
TypeError: Argument 'x' has incorrect type (expected float, got int)

TypeError: can only concatenate tuple (not "ezdxf.acc.vector.Vec3") to tuple (1 affected project)
- python-ezdxf
TypeError: can only concatenate tuple (not "ezdxf.acc.vector.Vec3") to tuple

AttributeError: module 'asgi._cythonized' has no attribute 'TestResourceWithHooksNoHintAfter' (1 affected project)
- python-falcon
AttributeError: module 'asgi._cythonized' has no attribute 'TestResourceWithHooksNoHintAfter'

'PyObjectType' object has no attribute 'entry' (1 affected project)
- python-fastavro
AttributeError: 'PyObjectType' object has no attribute 'entry'

conflicting declaration of ‘bool evaluator_callback_call_obj(PyObject*, int, double*)’ with ‘C++’ linkage" (1 affected project)
- python-fpyll
build/src/fpylll/fplll/enumeration.cpp:2788:21: error: conflicting declaration of ‘bool evaluator_callback_call_obj(PyObject*, int, double*)’ with ‘C++’ linkage

Cannot assign None to bint (1 affected project)
- python-giacpy
src/gevent/greenlet.py:150:16: Cannot assign None to bint

'context_ptr' is not a constant, variable or function identifier (1 affected project)
- python-giacpy
giacpy/giacpy2qcas.pyx:16:40: 'context_ptr' is not a constant, variable or function identifier

AttributeError: partially initialized module 'gssapi' has no attribute 'register_value' (1 affected project)
- python-giacpy
AttributeError: partially initialized module 'gssapi' has no attribute 'register_value' (most likely due to a circular import)

AttributeError: module 'os' has no attribute 'XXX' (1 affected project)
- python-indexed_gzip
AttributeError: module 'os' has no attribute 'join'
AttributeError: module 'os' has no attribute 'isfile'
AttributeError: module 'os' has no attribute 'exists'
AttributeError: module 'os' has no attribute 'getsize'

TypeError: 'float' object cannot be interpreted as an integer (1 affected project)
- python-indexed_gzip
TypeError: 'float' object cannot be interpreted as an integer

Syntax error in simple statement list (1 affected project)
- python-pyclipper
pyclipper/pyclipper.pyx:20:14: Syntax error in simple statement list

Invalid index type 'double' (1 affected project)
- python-pysam
pysam/libcalignedsegment.pyx:570:35: Invalid index type 'double'

TypeError: expected str, bytes or os.PathLike object, not numpy_include (1 affected project)
- python-pyspike
TypeError: expected str, bytes or os.PathLike object, not numpy_include

AttributeError: cython_sources (1 affected project)
- PyYAML
AttributeError: cython_sources

error: redefinition of '__Pyx_Enum_ibv_wc_status_to_py' (1 affected project)
- rdma-core
/builddir/build/BUILD/rdma-core-44.0/redhat-linux-build/pyverbs/cq.c:20730:18: error: redefinition of '__Pyx_Enum_ibv_wc_status_to_py'

No such file or directory: 'editdistance-s/bycython.pyx' (1 affected project)
- python-editdistance
+ cythonize --inplace editdistance-s/bycython.pyx
/usr/bin/cythonize: No such file or directory: 'editdistance-s/bycython.pyx'

A few comments on some of the more obvious ones:

Cannot assign type 'XXX (YYY) except * nogil' to 'XXX (YYY) noexcept (20 affected projects)
Cannot assign type 'XXX (YYY) except? -1 nogil' to 'ZZZ *' (14 affected projects)

This is a fairly large deliberately breaking change. They likely need to add noexcept to some cdef function definitions.

Cannot assign type 'XXX' to 'YYY

A good chunk of these are "cannot assign double to " or in one case "complex to ". These are likely to do with the new cpow behaviour. Again, somewhat deliberately breaking, although we might want to look at individual cases. This can be fixed with cython: cpow = False (or @cython.cpow(False) for a more targeted fix).

Pinned Cython < 3 version

That's on them!

undefined symbol PyMemoryview_Check

Fixed in current master

The keyword 'nogil' should appear at the end of the function signature line. Placing it before 'except' or 'noexcept' will be disallowed in a future version of Cython.

Should only be a warning for now

Invalid index type 'double'

Probably to do with cpow (as above)

I guess the one thing to add is: it's legitimate for things to specify a version of Cython as part of their build process which doesn't have to be the system one. So not everyone necessarily needs to have to upgrade right now.
Thanks for the thorough list!

AttributeError: module 'collections' has no attribute 'MutableSequence'

https://github.com/cython/cython/issues/5308

TypeError: expected str, bytes or os.PathLike object, not numpy_include

I've created a PR for PySpike (https://github.com/mariomulansky/PySpike/pull/68) - they're doing something slightly odd with paths and I don't think it's really on us to support it

I think most of the libarrow issues are because they have --warning-errors set. That's escalating a bunch of fairly trivial warnings into errors, and meaning that that a lot of cimports are failing because it's erroring on the pxd file. I doubt it'll be perfect, but it'll almost certainly look a lot better with that off (or with the warnings fixed)

Out of 181 packages, 67 of them succeeded with legacy Cython 0.29.33 but failed with 3.0.0b1. 21 packages failed with both Cythons

So - 93 of 160 packages built out of the box with Cython 3.0? That's great for a new major release with intentional breaking changes, I'd say.

We're tracking this in Gentoo at https://bugs.gentoo.org/897934 as well.

int/int now returns a float. That's on them to fix, but it'll be a case of specifying language_level=2

or using the // integer division operator.

Two months later, with Cython 3.0.0b3 out, and several projects providing updated code bases already, I think it's time to look into this again.
@hroncok and @hrnciar, would you be able to update the build results here?

Yes, however we are focusing on Python 3.12.0b1 at this moment. We can fire up the builds but won't have time to analyze the logs any time soon.

I think that with Cython 3.0 released to prod we don't need to keep this issue opened. If someone disagrees feel free to reopen it.


Frontend Project 'weather-app' Design Improvement

Title and Issue number
Close #2956
Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md

@MohitGupta121


translated the comments inside the code example to Spanish

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Congrats @ortizlu on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Spellcheck doesn't work on any indented content

Describe the bug
Nothing that is indented will get spellchecked, such as mkdocs material admonitions.
mkdocs-spellcheck is assuming all indented content are always codeblocks.
Here are some potential fixes:

Assume code blocks always fenced (using triple ticks  ``` ). Indented code blocks have been fairly uncommon styling for a while now.
Create two separate toggles for ignore_code and ignore_indents. Could alleviate this issue. I personally don't use indents for code blocks anymore, especially due to mkdocs-material's color formatted code blocks.
Create some some heuristic matching to determine "what is a code block".

To Reproduce
Steps to reproduce the behavior:

Install mkdocs-spellcheck
Install mkdocs-material
Create a admonition with a spelling error within the body

Expected behavior
Indented content should be spell checked
Screenshots
N/A
System (please complete the following information):

MkDocs SpellCheck version: 0.2.1
Python version: 3.10
OS: Windows

Additional context
N/A

Hello, thanks for the report!
I don't think the cause is what you describe. This plugin operates on HTML, not Markdown, so indented blocks transformed into admonitions have no reason to be skipped :thinking:
I'll take a look!

One detail I forgot to mention is that ignore_code=no allows admonitions to be spelled checked. But obviously, all my actual code blocks end up spamming the console with warnings.

Wow, there was a huge bug in the HTML stripper hahaha. For some reason I implemented a handle_stoptag method while it's actually called handle_endtag.

Released in version 0.2.2 :slightly_smiling_face:


Program returns opposite of 'best model' [BUG]

In _run_search() -func in search_cv.py as you can see the code determines that the best model is the one which has the largest mean of scores:
mean_val_scores = np.mean(self.results_["val_scores"], axis=0)
best_run_idx = np.argmax(mean_val_scores)

Essentially this returns wrong model, if somekind of loss is used in the calculation of val_scores (because with loss smaller is bettter). This wouldn't be a problem (it would be a feature) if it wasn't stated in the documentation that

The grid search is evaluated by:

The validation loss value, if no metrics are passed to model.compile()
The validation score of the last defined metric in model.compile()

This kind of implies that you can use either score or loss func and you still get the best model which isn't the case.
Best way to fix this would be to add a 'mode' argument to the function/method. This parameter would determine which is desirable; maximizing or minimizing the score.

Should be fixed now


Topics 6 graphics

Those other answers needed to be checked and reallocated to a (or multiple) given answer:
6.1 Human well-being using one of the following indicators:
6.1_otheranswers.xlsx
6.2 Preferences that humans assign to nature and biodiversity:
6.2_otheranswers.xlsx
6.3 The costs to protect nature & biodiversity for its own sake:
6.3_otheranswers.xlsx
6.4 Open answers (no given answer in this question):
6.4_otheranswers.xlsx
6.5 different socio-demographic groups:
6.5_otheranswers.xlsx

Nevertheless the results (so far I count other answers into 'Other' category)
Fig_6.1_25Oct.pdf
Fig_6.2_25Oct.pdf
Fig_6.3_25Oct.pdf
Fig_6.5_25Oct.pdf

Topic6_combine_25Oct.pdf

correction tables from Mette now found here: https://drive.google.com/drive/folders/12zJIp9cXec2V0UpDxYo8aoIvpmG0AeqG


Add How to Contribute to an Open Source Project on GitHub

That looks great @RenataGegaj! :) Could you also add https://opensource.guide as it’s a related good guide?

Second review please @opensourcedesign/website :slightly_smiling_face:


How to use with Parcel + React + Tailwind?

How can we configure this to work with Parcel + React + Tailwind?
I tried a few configurations, but the output files with renamed classes are not used at build time.
The obfuscation would be needed only when building, not during development. I can selectively run the obfuscation process, based on the example in the readme file.
Thank you in advance!

I've created a replit for this, hope it helps<EMAIL_ADDRESS>Tailwind is configured and working properly when the obfuscator is disabled.
However, if the obfuscator is enabled, when running npm run build:

the build/index.[hash].css file has the obfuscated class names
but the build/index.[hash].js has the original class names
there is the "out" dir also, which contains a version of the initial js files, but with the renamed classes. However the css file in this dir doesn't contain any classes (seems to be a copy of the initial css file in src dir)

How can we get this working?
Any help would be appreciated.
Thank you in advance.
cc @n4j1Br4ch1D

I found a solution, it's working for me but let me know if there's a better way of doing this.
Having postcss & tailwind installed and configured:

npm i postcss-cli
create/adjust your postcss.config.js file with the following content:

 module.exports = {
  plugins: [
    require("tailwindcss")({}),
    require("postcss-obfuscator")({
      enable: process.env.NODE_ENV === "obfuscate",
      extensions: [".html", ".js"], // adjust to your needs, ie: .ts, .tsx, .jsx etc
      desPath: 'src-obfuscated', // i'd suggest to add this folder to .gitignore
      keepData: false // this is required since running multiple times seems to mess up the classnames
    }),
  ],
};

if you have .postcssrc config file, remove it. Only postcss.config.js should be used.
Adjust your package.json file scripts. This example uses index.html as the entry point, and index.css as the only css file.

"scripts": {
//...
"obfuscate": "NODE_ENV=obfuscate npx postcss src/index.css -o src-obfuscated/index.css",
"build": parcel build 'src-obfuscated/index.html' --no-cache --dist-dir './build'",
//...
}

npm run obfuscate // this will create the folder src-obfuscated with original source files but with the renamed classes
npm run build // will output the "build" folder with the final result.

Be aware of some issues (unrelated to this configuration).
For example, using the class "container" from tailwind, also replaces the container var name in the code below:
const container = document.getElementById("app");
const root = createRoot(container)
root.render(<App />);

to this:
const k9hs2 = document.getElementById("app");
const root = createRoot(container)
root.render(<App />);

(default from Parcel example in their docs):
As a workaround, you may use a different var name like appContainer
Hope it helps. Let me know your thoughts.


KAFKA-5280: Protect txn metadata map with read-write lock

ping @dguy @hachikuji @apurvam @junrao for reviews.
Two major changes plus one minor change:

change stateLock to a read-write lock.

Put the check of "isCoordinator" and "coordinatorLoading" together with the return of the metadata, under one read lock block, since otherwise we can get incorrect behavior if there is a change in the metadata cache after the check but before the accessing of the metadata.

Grab the read lock right before trying to append to local txn log, and until the local append returns; this is to avoid the scenario that the epoch has actually changed when we are appending to local log (e.g. emigration followed by immigration).

Minor: enable reaper thread in the txn marker purgatory, since we are watching each delayed operation on two keys: txnId and partitionId, we need the reaper to purge these already completed items even though nothing will be expired.

One thing I realized while working on this PR is that, in purgatory's cancelForKey function, we only remove the elements from the watch-list but does not set its completed boolean; so if it is watched on other keys they will not be purged. I think this is a bug, that we should try-set its completed bit upon canceling it from cancelForKey?

@hachikuji @junrao I addressed your comments with a single function, one small drawback is that if there is already an existing txn metadata upon initPid it will waste a pid. But in practice producer fencing should be rare so hopefully it does not have huge impact.

Also, TransactionMarkerChannelManager.txnMarkerPurgatory is only used in TransactionMarkerChannelManager, but is passed to TransactionCoordinator for shutting down. Could we just shut down txnMarkerPurgatory in TransactionMarkerChannelManager and avoid passing txnMarkerPurgatory to TransactionCoordinator?

Also, TransactionMarkerChannelManager.txnMarkerPurgatory is only used in

ack.

@guozhangwang : Thanks for the latest patch. LGTM.

Merged to trunk and 0.10.0.

I think you mean 0.11.0.

I think you mean 0.11.0.

Yup :)


[WIP] Avoid intermediate sorting in groupby ACA

While working on #9302 I discovered that the performance of memory-constrained groupby aggregations (those requiring significant spilling) can be improved by setting sort=False for intermediate aggregations. While this simple change does not improve performance when the aggregation fits comfortably in memory (and may even introduce a slight regression), avoiding the sort seems to change some problematic cases from failures to successes.
Note that this is marked as WIP, because I am still unsure if this particular change is the best way to improve groupby stability.

cc @ian-r-rose

Thanks @rjzamora! I'm doing some testing on #9302, and will work this into it.

@rjzamora do you have a workflow that demonstrates this change in performance? I'm running some of the things I've been doing in #9302 on this PR, and am not really getting a consistent story.

I'm going to close this, and instead recommend that users be explicit about specifying sort=False when they don't actually need sorted groupby keys (since the pandas default is True). After #9302, the global setting should be respected in the chunk, combine, and aggregate functions.
Note that a better follow-up to #9302 may be to treat the shuffle default as True when sort=True and split_out>1. In that PR, I was hoping to avoid automatic "opt-in" to the shuffle-based groupby, but I suppose that specific case may require shuffling to work anyway.


Humble, ros2 launch nav2_bringup navigation_launch.py errors

Missing map and other errors (Invalid frame ID “map” passed to canTransform argument target_frame - frame does not exist at line 93 in ./src/buffer_core.cpp) when running ros2 launch nav2_bringup navigation_launch.py
FIX:
change robot_model_type: "differential" in navigation.yaml to robot_model_type: "nav2_amcl::DifferentialMotionModel"
Best regards
Kim

Hi
Last fix has been working until i did a "sudo apt update && sudo apt upgrade" and disabled the firewall ..
ros2 launch linorobot2_navigation navigation.launch.py rviz:=true output:

[component_container_isolated-1] [INFO] [1695657995.999423102] [amcl]: Message Filter dropping message: frame 'laser' at time<PHONE_NUMBER>.871 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[component_container_isolated-1] [INFO] [1695657996.127430455] [amcl]: Message Filter dropping message: frame 'laser' at time<PHONE_NUMBER>.999 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[rviz2-2] [INFO] [1695657996.143159982] [rviz2]: Message Filter dropping message: frame 'laser' at time<PHONE_NUMBER>.863 for reason 'discarding message because the queue is full'
[rviz2-2] Warning: Invalid frame ID "map" passed to canTransform argument target_frame - frame does not exist
[rviz2-2]          at line 93 in ./src/buffer_core.cpp
[rviz2-2] Warning: Invalid frame ID "map" passed to canTransform argument target_frame - frame does not exist
[rviz2-2]          at line 93 in ./src/buffer_core.cpp
[rviz2-2] Warning: Invalid frame ID "map" passed to canTransform argument target_frame - frame does not exist
[rviz2-2]          at line 93 in ./src/buffer_core.cpp
[rviz2-2] Warning: Invalid frame ID "map" passed to canTransform argument target_frame - frame does not exist
[rviz2-2]          at line 93 in ./src/buffer_core.cpp

errors in rviz:

please use the latest humble branch. the amcl config has been updated


R0.6

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind bug
/kind task
/kind feature

What does this PR do / why do we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewers:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 6 committers have signed the CLA.:x: jonyguo:x: yiren920727:x: yuyicg:x: wang-hua-2019:x: mindspore-bot:x: chenzomi12jonyguo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Save to Github always writes to top-level directory

When I save to Github, I'm presented with a dialogue that enables me to select where in the directory hierarchy I want to save, but ... it always saves to the top-level regardless of what I select. Example: I have 2 directories in the repo, lib and data; I select data, but it writes to the top-level dir instead. Because this is a git commit, it's a pain to rectify, as I have to revert the commit and resubmit; as this is more trouble than it's worth, it makes geojson.io less useful than it might be.

I'm experiencing the same issue


Do not export models on device

If one exports a model on a device and then tries to load it when the device is not available anymore, they will get
cpp_module = torch._C.import_ir_module(cu, os.fspath(f), map_location, _extra_files, _restore_shapes)  # type: ignore[call-arg]
RuntimeError: No CUDA GPUs are available
As a result, we should always save on CPU and then it is the responsibility of whoever loads the model to change the device if needed
Contributor (creator of pull-request) checklist

[ ] Tests updated (for new features and bugfixes)?
[ ] Documentation updated (for new features)?
[ ] Issue referenced (for PRs that solve an issue)?

Reviewer checklist

[ ] CHANGELOG updated with public API or any other important changes?

📚 Download documentation preview for this pull-request

Could you add this fix to the changelog?


AmazonProduct won't parse all SalesRankings

I wanted to validate that my changes in #51 wouldn't break the existing code, I started writing a testcase where I validate the fetchProductList.xml file.
Analysing this piece of that Xml file:
<SalesRankings>
    <SalesRank>
        <ProductCategoryId>book_display_on_website</ProductCategoryId>
        <Rank>53138</Rank>
    </SalesRank>
    <SalesRank>
        <ProductCategoryId>377886011</ProductCategoryId>
        <Rank>56</Rank>
    </SalesRank>
</SalesRankings>

It should be that there are 2 SalesRanking entries in the AmazonProduct object. But the code contains the same error the #51 bug has. The loops overwrite the value:
//SalesRankings
if ($xml->SalesRankings){
    foreach($xml->SalesRankings->children() as $x){
        foreach($x->children() as $y){
            $this->data['SalesRankings'][$x->getName()][$y->getName()] = (string)$y;
        }
    }
}

Running the code gives this output:
[SalesRankings] => Array
(
    [SalesRank] => Array
    (
        [ProductCategoryId] => 377886011
        [Rank] => 56
    )
)

Where it should have been:
[SalesRankings] => Array
(
    [0] => Array
    (
        [ProductCategoryId] => book_display_on_website
        [Rank] => 53138
    )
    [1] => Array
    (
        [ProductCategoryId] => 377886011
        [Rank] => 56
    )
)

Supposed fix
//SalesRankings
if ($xml->SalesRankings){
    foreach($xml->SalesRankings->children() as $child){
        $this->data['SalesRankings'][] = (array) $child;
    }
}

It is strange that this is not working, because I wrote a script for getting this information and didn't notice any problems with it. Once I have the time to work on the library again, this will be the first thing I investigate. Thanks for finding this.

Taken care of


(B) Setting "outputLatency" and/or "getLatency" does not work.

Firing these commands are showing the issue:
"...
06:30:37.227 -> (1) >>
06:30:37.227 -> (2) >> leapMMW:/>sensorStop
06:30:37.227 -> (3) >> sensor stopped already
06:30:37.272 -> (4) >> Error
06:30:37.272 -> (5) >> leapMMW:/>outputLatency -1 100 400
06:30:37.272 -> (6) >> Done
06:30:37.272 -> (7) >> leapMMW:/>saveCfg 0x45670123 0xCDEF89AB 0x956128C6 0xDF54AC89
06:30:37.272 -> (8) >> save cfg complete
06:30:37.272 -> (9) >> Done
06:30:37.272 -> (10) >> leapMMW:/>getLatency
06:30:37.272 -> (11) >> Response 0.025 10.000
06:30:37.272 -> (12) >> Done
..."
Firing "outputLatency -1 100 400" results in the response "Done".
So the command were worked out without any error.
Firing the save command ends also without any error.
So the change should be saved.
Firinng "getLatency" results in the above shown response where the first value is equal to "0.025" and not to "2.500".
Also this command response is "Done".
So also this command were worked out without any error.

No reaction after three weeks?
Lame and shame!

No reaction after two month?
Lame and shame!
两个月后还没有反应？
蹩脚又可耻!

No reaction after three month?
Lame and shame!
三个月后没有反应？
蹩脚又可耻!

Firing "getLatency" results in the above shown response where the first value is equal to "0.025" and not to "2.500".

So, you've stumbled across a different configuration option, setLatency, which is not the same as outputLatency.
The setLatency is used to set a "confirmation delay" and "disappearance delay":

confirmation delay - the amount of time (in seconds, range 0-100, default 0.05) during which presence activity must be continuous before the sensor will assert the presence status
disappearance delay - the amount of time (in seconds, range 0.5-1500, default 15) during which there must be no presence activity before the sensor will de-assert the presence status

So the Response 0.025 10.000 you received are these two values.
The outputLatency command doesn't appear to have a get compliment.

@MaffooClock
Thanks for the explanation.
My post / comment is about the first response value 0.025 (while 2.500 is expected.
My post / command is NOT about the meaning of the two values 0.025 and 10.000
But anyways: Thanks.

My post / comment is about the first response value 0.025 (while 2.500 is expected).

Which I explained is for setLatency -- it has nothing to do with outputLatency.

My post / comment is NOT about the meaning of the two values 0.025 and 10.000

You issued getLatency, expecting to see the values you set for outputLatency, but instead got the values that belong to setLatency.  So yes, your post was exactly about those two values.
hat 2.500 value you were expecting comes from par2 of outputLatency, which is in units of 25ms.  Thus, 100 x 0.025 = 2.5 seconds.  However, there is no way (as far as I can tell) to read the value that was set into outputLatency, so you'll never actually see "2.500" anywhere.
Regardless of what you asked or expected, my comment was meant for anyone else who might run across this, so I wanted to be thorough and clear to prevent confusion.

sen0521.pdf
@UweR70
You'll want to take a look at this. Everything is documented here, you don't know what I had to go through to find this, it's crazy. But all these commands I believe also work for the SEN0395.

Heres the asian version
https://www.leapmmw.com/wp-content/uploads/1609/47/用户手册V1.3：HS2xx3A系列人存在检测模块.pdf


Not able to use Select with where constraint

Here is an example about how to select a person object by its name:
Person person = personList.Where(x => x.Name = "Name").FirstOrDefault(); // you need to import the using System.Linq to use the Where clause.

Closing this as it seems a duplicate of #51. This seems to be less elaborated than #51 that's why I'm closing it even though it was posted before.


If daily backup is chosen, ensure there is always a daily backup

Currently there looks like there might be an issue where if the option "only backup if players online" that even dailies are only created if someone has been online.
Is this the correct approach or should there always be a backup for each day?

Thinking about it more I do not think this is an issue.  They chose only have backups if players had logged in.  So if the users have not logged in for a day, there will not be a backup for that day.


chore: remove acls from docs/ll deploy

We use policies now, not acls

Tested with a staging deploy of docs


unintuitive metadata behaviour

When you have a View object in view and you evaluate 'error' in view.metadata then the result is true, but if you then access the message property you get an error (KeyError: 'message').

I can access the message by a_view.metadata.error.message.

Ah, let me be clearer. The behaviour occurs when you check whether there is an error in a view that has no error so there is no message but  the value of 'error' in view.metadata is True.

Ah, I see. That definitely seems to be a bug. I'll fix in the next release.

closed via #165.


caf: init at 0.15.3

Motivation for this change
Caf is a useful library for writing concurrent and distributed C++ programs.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (none)
[x] Fits CONTRIBUTING.md.

Squashed in 1d948ddc016882b2189bfebcb501ebafee53a6fb


[DOC]: Update required pip installs in Audio Transcription Use-Case

What's wrong?
I love the audio transcription use-case but when going through it I had some trouble because of missing packages.
In more detail, it is because newer versions of datasets don't use torchaudio anymore (see last comment here: https://github.com/huggingface/datasets/issues/3909) but they now use soundlib.
Other missing packages I had to install are librosa and sentencepiece
How could it be better?
Update the !pip install torchaudio in the use-case with !pip install datasets soundlib librosa sentencepiece

@johko either we should pin the pip install datasets to the old working version or install soundlib etc thing.
@blythed WDYT?


ingest other functions

both from local file and from url

works, but corner cases currently include child env not propagating up to parent, and subshell not getting a tty


Improve sidecar documentation

@Bplotka thanks :)

@deejay1  thanks for reviewing, I fixed those issues.
@Bplotka don't worry I've changed a couple of things after review, so probably introduced these issues later ;)


Losing Game progress when quitting safari

Safari iOS 14.5
Lauren reports that when she closes (quits) safari, and then re-opens, the game resets itself and does not save progress.

Can you confirm that cookies are not being deleted and the browser is not in private browsing mode? Cookies must be enabled for progress to be saved across sessions.


react-redux intersection error message

Hello,
I'm using flow v0.36 with flow-typed and react/react-redux, and I'm encountering a strange flow error :
function call Function cannot be called  on any member of intersection type of intersection
This occurs when I connect my component :
export default connect(null, mapDispatchToProps)(MyComponent)

Is a react-redux definition error ? Or maybe something I wrote ?
Thanks.

Your question cannot be answer without more context. There's probably a bug in your mapDispatchToProps definition.
This repository contains the implementation of flow itself. For questions regarding definitions try flowtype/flow-typed or stackoverflow with flowtype tag.

You were right, this error is raised because I didn't annotate the dispatch parameter in mapDispatchToProps definition. Nevermind !
Thanks


Join fetlife

@rakvat @nielsenramon No need to do that for Bulgarian. I can't think of an alternative word, and the current translation is in common use.

@rakvat I also checked for Dutch and I don't see a better translation just yet. I feel it will set us back a bit to show an english term for our most important button on the front page.


Repeat query in syntax error

When there is a syntax error in the query parser, one important context is the query itself.
Since we pass it via an URL, it is not uncommon to mess up with the URL encoding.
If Quickwit repeated the query it was trying to parse  in the error, that could help spot trivial URL encoding errors very fast.

Fixed via https://github.com/quickwit-oss/quickwit/pull/1335


Doesn't work for Home Assistant 2023.5.0

Description
Integration is not working on HomeAssistant 2023.5.0.
Reproduction Steps
Upgrade to 2023.5.0
Expected behavior
Works as expected + https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/issues/322 should work.
If applicable, add error logs.
Logger: homeassistant.setup
Source: setup.py:214
First occurred: 22:27:09 (1 occurrences)
Last logged: 22:27:09
Setup failed for custom integration tapo_control: Unable to import component: cannot import name 'NotificationManager' from 'onvif.client' (/usr/local/lib/python3.10/site-packages/onvif/client.py)
Device Firmware
1.0.35 Build 230307 Rel.6847n(4555)
Using stream component
Yes
Does camera work via official integrations?
Yes
Camera has all attributes filled out in developer tools
Yes
HASS Environment
HA OS on Raspberry Pi 4 B
Search for similar issues
Yes
Additional information
I updated, as I wanted to get motion sensor back (after update to 5.1.3+, as it didn't go back after downgrade to 5.1.2)
https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/issues/322

Upgrade to latest version.

Hi @JurajNyiri - just updated it seems that something went wrong initially and more it's okay, but still motion sensor is not appearing back for cam. How to restore it?

https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/issues/312
https://github.com/home-assistant/core/issues/91661

Okay, seems to be working. Not sure if that would help with original issue, but for me there are 2 motion sensor entities created now. @

Have the same problem. Ended up restoring my system

@jay1972 update to 2023.5.0, then upgrading Tapo to 1.3.7 (for 2023.4.x only 1.3.6 was available) seems to fix issue for me (except duplicated sensor)

Cheers going to remove tapo before updating the HA Core then reinstall tapo

That should prevent the duplicates

You can upgrade and if you see duplicates -- just remove the unavailable one and change the entity_id to the preferred ID to keep all automations working.


Add the Bridgetown static site generator

Much appreciated! 👍

Howdy @jaredcwhite—thanks for the PR!


Support converting between different exec login methods

The behavior of az aks get-credentials changed to return exec format config with devicecode (interactive) mode by default now. Eg,
name: test-cluster
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1beta1
      args:
      - get-token
      - --environment
      - AzurePublicCloud
      - --server-id
      - <redacted>
      - --client-id
      - <redacted>
      - --tenant-id
      - <redacted>
      - --login
      - devicecode
      command: kubelogin
      env: null
      provideClusterInfo: false

This prevents kubelogin to convert it to non interactive mode (eg spn) as it currently only converts azure format configs.
What needs to  be supported?
kubelogin should add an option to convert exec format configs from one login method to another.
new option: -f  --from  Current login method to convert from
For example,
kubelogin convert-kubeconfig -l spn -f devicecode

Looks like this is supported in newer versions of kubelogin. Sorry for the false alarm.


Tab in normal mode inserts a tab

I think I was expecting it to fold (not sure if that's implemented yet), but it just inserted two space characters.

I'm not sure if this is exactly the same issue, but I've noticed that when entering insert mode, then hitting tab, the cursor advances too far if there are trailing tab characters already on the line.

Same here. Seems to be that  is catched by editor:indent. I think it should be disabled by vim-mode on startup, or maybe just in normal mode.

Any ETA on this? I'd argue that this is really a bug, not an enhancement. It's probably the most annoying aspect of working with vim-mode for me.

vim just ignores tab in normal mode, right?  would the desired fix be to make vim-mode ignore tab too?
I can't seem to reproduce moving too far when hitting tab in insert mode...  Does it happen when vim-mode is the only 3rd party package enabled?

So far as I can tell, it doesn't move "too far," what it seems to be doing is matching whatever the current indent level is (based on the lines prior to it, and probably influenced by the indentation rules of the language you're editing).
In any case, I would agree Tab should be ignored. This is just doing shifts, the Vim way to do that is >> and <<, not Tab.

This is a bug because normal mode tab does nothing in real vim. I fixed with this custom key map.
'atom-text-editor.vim-mode.normal-mode':
  'tab': 'noop'

I don't know of noop is an actual atom command, but unset! looked to gave a weird behavior and seemed to tab out of the editor altogether. noop didn't throw any errors and it does nothing. Works for me.

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


Around operator with molname spec does not work correctly

Around operator of molsel syntax with molname specification does not work.

Fixed bug in flex/bison source of AROUND operator, especially the timing of setNumState() call for parsing number modifier. [1a27aec14f6d5b7f1aaa1f798fe05088f9a70bf1]
I changed src so that setNumState() is called in the sel_number node.


Enhance implicit partitioned replica-group assignment behavior for Pinot Upsert

Currently for Upsert tables,
Using implicit partitioned replica-group assignment from low-level consumer won't persist the instance assignment (mapping from partition to servers) to the ZooKeeper, and new added servers will be automatically included without explicit reassigning instances (usually through rebalance).
To provide an example, we create a Upsert table with BalanceNumSegmentAssignmentStrategy (2 replicas), on a 4 nodes tenant. the partitions can be assigned to
Partition0: server0, server1
Partition1: server2, server3
Partition2: server0, server1
Partition3: server2, server3

When adding one extra server without rebalancing the table, we started to see
Partition0: server0, server1, newServer
Partition1: server2, server3
Partition2: server0, server1, newServer
Partition3: server2, server3

The newServer hosting primaryKeys of partition0 but not all the primarykeys are hosted on newServer, and it will failed to lookup the primary keys during ingestion, and duplicates keys and incorrect query results.
The concerns of using implicit partitioned replica-group assignment is, adding new node and rebalancing the table are not atomic operations. After a tenant expansion and before the table get rebalanced, we will see incorrect result for Upsert table.
Is there any reason/scenarios that we need the current behavior of the implicit assignment?
Shall we change the implicit assignment behavior to be the same as the explicit assignment?

cc: @yupeng9 @Jackie-Jiang @rohityadav1993 @MeihanLi

This issue itself is addressed by #11628. But I'm +1 on only allow explicit replica-group assignment for upsert table.


Support arm64 arch for Linux

Since deno version 1.1.41 has been released, ARM64 architecture for Linux is supported.
This PR proposes to support and provide a binary for this architecture.

Nice!


TLSPolicy creation failure blocking dnsrecord creation on creation of dnspolicy

Steps to reproduce
Follow https://docs.kuadrant.io/getting-started/ using aws as the provider
export MGC_SUB_DOMAIN=myapp.$MGC_ZONE_ROOT_DOMAIN
Follow https://github.com/Kuadrant/multicluster-gateway-controller/blob/a4a74009517a92049e24ff738cc0f2246fc6c587/docs/tlspolicy/tls-policy.md#lets-encrypt-issuer-for-route53-hosted-domain
Create gateway
kubectl apply -f - <<EOF
apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
  name: prod-web
  namespace: multi-cluster-gateways
spec:
  gatewayClassName: kuadrant-multi-cluster-gateway-instance-per-cluster
  listeners:
  - allowedRoutes:
      namespaces:
        from: All
    name: api
    hostname: $MGC_SUB_DOMAIN
    port: 443
    protocol: HTTPS
    tls:
      mode: Terminate
      certificateRefs:
        - name: apps-hcpapps-tls
          kind: Secret
EOF

Label Gateway kubectl --context kind-mgc-control-plane label gateway prod-web "cluster.open-cluster-management.io/placement"="http-gateway" -n multi-cluster-gateways
Create tlspolicy using Let's Encryt Issuer
kubectl apply -f - <<EOF
apiVersion: kuadrant.io/v1alpha1
kind: TLSPolicy
metadata:
  name: prod-web
  namespace: multi-cluster-gateways
spec:
  targetRef:
    name: prod-web
    group: gateway.networking.k8s.io
    kind: Gateway
  issuerRef:
    group: cert-manager.io
    kind: Issuer
    name: le-production
EOF

Create a DNSPolicy
kubectl apply -f - <<EOF
apiVersion: kuadrant.io/v1alpha1
kind: DNSPolicy
metadata:
  name: prod-web
  namespace: multi-cluster-gateways
spec:
  targetRef:
    name: prod-web
    group: gateway.networking.k8s.io
    kind: Gateway
EOF

Results
See that the secret generated has the name specified in the gateway and a suffix
kc get secret -n multi-cluster-gateways
NAME                     TYPE     DATA   AGE
apps-hcpapps-tls-lqk9w   Opaque   1      2m55s

See that the certificate has the following status kc get certificate apps-hcpapps-tls -n multi-cluster-gateways -o yaml | yq -r '.status'
    conditions:
    - lastTransitionTime: "2023-09-18T14:53:01Z"
      message: Issuing certificate as Secret does not exist
      observedGeneration: 1
      reason: DoesNotExist
      status: "False"
      type: Ready
    - lastTransitionTime: "2023-09-18T14:53:01Z"
      message: Issuing certificate as Secret does not exist
      observedGeneration: 1
      reason: DoesNotExist
      status: "True"
      type: Issuing

See that no status of the tlspolicy applied is present in the status of the gateway
See that no dnsrecord is created
kc get dnsrecord -A
No resources found

I'm not sure this as it's described is really a bug. If TLS is not setup correctly regardless of how you are doing it (using a TLSPolicy or manually etc..), the DNSPOlicy won't be able to do anything if the gateway is never reporting that it's programmed.
An issue more specific to the issues you are having setting up the TLSPolicy with the Lets Encypt issuer might be better.

I see
issuerRef:
    group: cert-manager.io
    kind: Issuer
    name: le-production

Issuer is a namespaced resource. So the issuer would need to be created in the same ns as the certificate I think
https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/config/crd/bases/kuadrant.io_tlspolicies.yaml#L58

I see
issuerRef:
    group: cert-manager.io
    kind: Issuer
    name: le-production

Issuer is a namespaced resource. So the issuer would need to be created in the same ns as the certificate I think https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/config/crd/bases/kuadrant.io_tlspolicies.yaml#L58

Yes, in the example it's using an "Issuer" which must be created in the same namespace as the policy. I think the doc just need updated to call that out if it's not obvious, and probably add namespace: multi-cluster-gateways to the example Issuer.


chore: Publish Workflow and other Github enhancements

[x] I reviewed linter warnings + errors, resolved formatting, types and other issues related to my work
[x] The PR title follows the convention we established conventional-commit

Publish Workflow

Automatically publish a beta release on updates to main.
Switched standard-version to changeset in order to accomplish this.

Other Github Enhancements

Convert issue templates to forms. I recently did this for trpc, see https://github.com/trpc/trpc/pull/2363.
Add PR labeler, automatically adds the appropriate label to a PR if its regarding the CLI or the outputted T3 App.

@JacobMGEvans please tell me how we do with the licenses regarding files from here https://github.com/cloudflare/wrangler2/tree/main/.github

@JacobMGEvans please tell me how we do with the licenses regarding files from here https://github.com/cloudflare/wrangler2/tree/main/.github

I'm asking internally to be sure 😄


feat request : using uptime kuma it would be great to publish some success message on topic

Hi,
I'm using your software. Great works thanks (merci) !
I'm also using kuma uptime (https://github.com/louislam/uptime-kuma) to track that all my homelab services are alive.
This status solution is able to track a success message under a MQTT topic to gather wether or not the client publishing here is alive.
Having just a boolean refreshed like
teleinfo/up = true
would fit the case. If the message get too old and don't get refreshed it would indicates that the client isn't publishing anymore and that we have to bother about our teleinfo stack.
At the time being kuma isn't able to do more elaborate check thant strict equality (AFAIK) so I'm trying to ask here if you mind accept this feature request.
If so, I believe I could send you a merge request as it seems like a very simple enhancement to implement + test.
Just tell me if I you are willing to accept this kind of PR.

Hi,
Thank you for your support 👍!
wud already exposes its health via http.
So I would say that Kuma Uptime can already monitor it through http... doesn't it?

I don't get the dependency on WUD as I'm not using at the time being.
I just check it seems to be a project to ensure our running docker image are up to date.
In the case of teleinfo2mqtt I don't see how WUD can state that teleinfo data are still getting pushed to MQTT and application is alive (in terms of data and not container still running).
But I have just check quickly maybe I miss something ?

Sorry 😅
I confused 2 projects I'm maintaining 😄.
Yes, providing a health status through mqtt is a great idea 👍.
It won't be very hard to implement.
But if you can help with a PR; even better,  you're welcome 🙂!

Release as 8.2.0

tested and it does the job thanks !!

Great!
Thank you very much for your contribution!


IDA Pro

Hi,
is it possible to adapt your project for Ida Pro ?!
Regards

I think it is possible but at this moment I don't have much time to port it.

also for visual studio debugger


CEVIEW review

@djw8605 This is a WIP but figured I'd get this up sooner rather than later so you can take a look at your convenience. The main question I've got, which perhaps @bbockelm may have a better answer for, is about the use of __import__ in jobmetrics. I didn't really see a reason for it but if there was one, I could easily revert that commit.

The import is done within the functions because we want to avoid loading HTCondor code in the parent and forking.
I had some hard-to-track issues that originally appeared to be caused by the condor code having globals that didn't re-initialize correctly in the child process.

We should drop this then, https://github.com/opensciencegrid/htcondor-ce/blob/master/src/condor_ce_jobmetrics#L15, since the only function that uses it is satisfied with an __import__. Sound good to you?

Also, @edquist brought up a good point that import within the functions should maintain scope just as __import__ does. Any reason in choosing one over the other here?

Just a matter of habit.  As long as it doesn't get done in the parent, either syntax works for me.


WINNF.FT.D.DRG.2 does not finish properly in case one of the CBSDs sends a new Registration Request

Executing test case WINNF.FT.D.DRG.2 with SAS Harness v<IP_ADDRESS>, the following is observed:
The test starts with Domain Proxy UUT sends all messages as array of [2].
If Deregistration Request from Domain Proxy is also sent as array of [2] --- then test finishes properly and reaches the questions phase.
If Deregistration Request from Domain Proxy is sent separately for CBSD #1 and then CBSD #2 (or CBSD #2 and then CBSD #1) and there is NO new Registration Request message --- then test finishes properly and reaches the questions phase.
If the following sequence occurs: Deregistration Request from Domain Proxy is sent separately for CBSD #1 --> NEW Registration Request from Domain Proxy is sent separately for CBSD #1 --> Deregistration Request from Domain Proxy is sent separately for CBSD #2.
Then in this sequence the test is stuck constantly providing Registration Response = 200 for both CBSDs and does not reach the questions phase.
If the following sequence occurs: Deregistration Request from Domain Proxy is sent separately for CBSD #2 --> NEW Registration Request from Domain Proxy is sent separately for CBSD #2 --> Deregistration Request from Domain Proxy is sent separately for CBSD #1.
Then in this sequence the test is stuck constantly providing Registration Response = 200 for both CBSDs and does not reach the questions phase.

Fix in branch predev_<IP_ADDRESS>.


BoundInput value is a string

What's this PR do?
Corrects the type for value on IBoundInput.
It was incorrectly set to (name: keyof T) => string but is simply a string.
Where should the reviewer start?

src/interfaces.ts

Issue
#17

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   72.38%   72.38%
=======================================
  Files           4        4
  Lines         105      105
  Branches       19       19
=======================================
  Hits           76       76
  Misses         20       20
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71a29f...7b43f44. Read the comment docs.

Coverage remained the same at 70.701% when pulling 7b43f44212a8eb8a5644022c5efec1aaccc6d5be on feature/fix-bind-input-type into c71a29f678354ada905b6e355e55d02492af955d on master.


Relation name '"test_3833998b25_eleme__schema_changes__tmp_20231018180218723620"' is longer than 63 characters

Describe the bug
I am using the elementary package and using "elementary.schema_changes" as a test case. However my model name long as between 20 to 30 chars long. After running the test case I am getting the following error in Postgres database
Runtime Error in test elementary_source_schema_changes_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx_
Relation name '"test_3833998b25_eleme__schema_changes__tmp_20231018180218723620"' is longer than 63 characters
To Reproduce
Steps to reproduce the behavior:

GIve the schema name longer than 20 charecters

Expected behavior
Test case should be passed

Running into this issue as well. Is the only solution to shorten model name?

Hi all,
Closing this issue since it had no activity in the past 3 months, but if it's still relevant for anyone please feel free to re-open.
Thanks,
Itamar

Is there any solution to this. We are working through setting up a minimal POC using postgres as a backend db and realizing that even short model names are presenting an issue. For instance this currently does not work for PG
models:

name: example_model
tests:

elementary.freshness_anomalies:
timestamp_column: record_date
time_bucket:
period: day
count: 14


STORM-3061: rocket, jms, and mqtt updates

This updates some dependencies for the jms examples, mqtt examples, rocketmq examples, and updates activemq implementation used for testing jms, rocketmq, and activemq.
I ran some manual tests of the example topologies that I could find. I couldn't make all of them really work, because there was no clear documentation about most of them on how to setup or run the example topologies.
mqtt examples using flink had no documentation at all so I wasn't able to successfully run anything. storm-jms-examples fails with what appears to be a JNI issue, but it fails exactly the same way on 1.2.3-SNAPSHOT too.
If someone with more experience with these could improve the documentation about how to run them that would be great.

@ptgoetz I am trying to run all of the examples/tests I can to be sure that I didn't break anything when I upgraded versions.  One of the issues I am running into is around the spring framework in the storm-jms-examples package.  It looks like you wrote that code initially, or at least brought it in could you explain to me how to run it?  I am having no luck making it work on any version of storm I have tried.
442  [main] INFO  o.s.b.f.x.XmlBeanDefinitionReader - Loading XML bean definitions from class path resource [jms-activemq.xml]
Exception in thread "main" org.springframework.beans.factory.parsing.BeanDefinitionParsingException: Configuration problem: Unable to locate Spring NamespaceHandler for XML schema namespace [http://activemq.apache.org/schema/core]
Offending resource: class path resource [jms-activemq.xml]

@vesense I am trying to get the RocketMQ example topology up and running so I can manually test that it is working, but there is no documentation on how to do it.  I managed to download RocketMQ and set it up so there are no more exceptions in the logs, but I am no data is flowing.  Do you happen to have a tool or instructions on how to publish and read the appropriate messages to/from the corresponding queues?

Hi @revans2 Now I'm on vacation. I will add a usage document for RocketMQ example after I get back next week.

@revans2
Could we move this out of STORM-3061 (I meant filing a new issue)? This looks like not a thing to be reviewed sooner and we merged other PRs for STORM-3061 so may be better to break down and mark STORM-3061 as resolved.

@vesense @ptgoetz
Any updates on this?

I just rebased, and if you want me to file separate JIRA for each of these I can, but 2.x is the time that we have to be able to do customer impacting upgrades like this.
I think I have done enough sanity tests that I feel comfortable with this change going in.  If others want more testing I can pull this out to a separate JIRA.


AAP-8709 Add scheduled workflow and split long-run tests

Add new scheduled workflow to run all tests two times per day
Split new run tests flavors in reusable actions
Add new mark for long running-tests
Incorporates https://github.com/ansible/ansible-rulebook/pull/319
Fix missing mark for e2e test

Resolves AAP-8709

Hi @mkanoor seems that the upload to codecov sometimes fails. Maybe we should avoid this step.
Ref: https://github.com/codecov/codecov-action/issues/598


changed Italy holidays to add all provinces' saints

Pull Request Test Coverage Report for Build 325

29 of 29 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 98.951%

Totals

Change from base Build 321:
0.006%

Covered Lines:
4623

Relevant Lines:
4672

💛  - Coveralls

Hi coffeemaker, thanks a lot for your good work!
Unfortunately, Italy's got a quite huge list of saints, not only the ones you found.
I think that, when working on this task, we should come to, if not to 100%, at least a good point of coverage of them.
Check out this (probably not even totally complete!) list:
https://it.wikipedia.org/wiki/Santi_patroni_cattolici_delle_città_capoluogo_di_provincia_italiane
(some of the dates are not shown directly in the list, but can be found in the relevant details page, eg for L'Aquila, https://it.wikipedia.org/wiki/San_Massimo_d'Aveia )
This is a task I've got in my to-do-list: could you help me out with it?
NOTE: given the length of the list, I'd strongly suggest to avoid using only "if" statements to do it.
Please let me know, thx
dr-p

Hello dr-prodigy,
I'll take another look at the issue and try to complete holidays for Italy for all saints today.
You're right about if statements. Other if statements for already implemented holidays based on province in Italy were just if statement and I wanted to keep the code style consistent, but the fact is, that it's not a good idea.
I let you know about the progress or you'll see changes in the pull request later on.
cm2017

No hurry, when you can :)
Thank you another time!

Hi krolmic,
I realized today that we've lost contact on this work of yours (after I inadvertently closed your PR months ago), which I'd like to get back into the project (in the end, even if not 100% complete, there was some useful data added!).
I know a lot of time is passed (right now I can't see your python_holiday fork anymore), but if you could in some way restore your work, I would be sure glad to merge it.
Thanks a lot, cheers!

Hi dr-prodigy,
first of all, I'm sorry that I didn't finish my work on the PR.
A lot of other things distracted me from finishing it. I cleaned up my github profile recently and I thought my work on python_holiday isn't useful and up-to-date anymore.
I'm going to see what I can do and write you a message.
Best regards
Michael
On 18.10.18 23:50, Maurizio Montel wrote:

Hi krolmic,
I realized today that we've lost contact on this work of yours (after I inadvertently closed your PR months ago), which I'd like to get back into the project (in the end, even if not 100% complete, there was some useful data added!).
I know a lot of time is passed (right now I can't see your python_holiday fork anymore), but if you could in some way restore your work, I would be sure glad to merge it.
Thanks a lot, cheers!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Michael,
well it's been my fault, I'm sorry.. thank you very much for anything
you'll do!
Tchuss
Maurizio
Il giorno ven 19 ott 2018 alle ore 01:30 Michael Krol <
<EMAIL_ADDRESS>ha scritto:

Hi dr-prodigy,
first of all, I'm sorry that I didn't finish my work on the PR.
A lot of other things distracted me from finishing it. I cleaned up my
github profile recently and I thought my work on python_holiday isn't
useful and up-to-date anymore.
I'm going to see what I can do and write you a message.
Best regards
Michael
On 18.10.18 23:50, Maurizio Montel wrote:

Hi krolmic,
I realized today that we've lost contact on this work of yours (after I
inadvertently closed your PR months ago), which I'd like to get back into
the project (in the end, even if not 100% complete, there was some useful
data added!).
I know a lot of time is passed (right now I can't see your
python_holiday fork anymore), but if you could in some way restore your
work, I would be sure glad to merge it.
Thanks a lot, cheers!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub,
or mute the thread.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/dr-prodigy/python-holidays/pull/102#issuecomment-431197502,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aa6Ocd_z3ksTE7P7Hn7rmQQo8LhCpMguks5umQ8pgaJpZM4SBUYq
.

Ciao Maurizio,
I created a pull request containing all provinces in Italy and their holidays, which are partly missing.
I listed which holidays are missing in a comment in holidays.py.
Best regards
Michael
On 19.10.18 10:15, Maurizio Montel wrote:

Hi Michael,
well it's been my fault, I'm sorry.. thank you very much for anything
you'll do!
Tchuss
Maurizio
Il giorno ven 19 ott 2018 alle ore 01:30 Michael Krol <
<EMAIL_ADDRESS>ha scritto:

Hi dr-prodigy,
first of all, I'm sorry that I didn't finish my work on the PR.
A lot of other things distracted me from finishing it. I cleaned up my
github profile recently and I thought my work on python_holiday isn't
useful and up-to-date anymore.
I'm going to see what I can do and write you a message.
Best regards
Michael
On 18.10.18 23:50, Maurizio Montel wrote:

Hi krolmic,
I realized today that we've lost contact on this work of yours (after I
inadvertently closed your PR months ago), which I'd like to get back into
the project (in the end, even if not 100% complete, there was some useful
data added!).
I know a lot of time is passed (right now I can't see your
python_holiday fork anymore), but if you could in some way restore your
work, I would be sure glad to merge it.
Thanks a lot, cheers!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub,
or mute the thread.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/dr-prodigy/python-holidays/pull/102#issuecomment-431197502,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aa6Ocd_z3ksTE7P7Hn7rmQQo8LhCpMguks5umQ8pgaJpZM4SBUYq
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Update Opensearch to 1.2.1 and Update log4j to 2.15

Please update this plugin to opensearch 1.2.1 and update log4j to at least 2.15
see: https://opensearch.org/blog/releases/2021/12/update-to-1-2-1/
Thank you

Is there a planned release date?


[SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

What changes were proposed in this pull request?

Currently, AQE uses a very tricky way to trigger and wait for the subqueries:

submitting stage calls QueryStageExec.materialize
QueryStageExec.materialize calls executeQuery
executeQuery does some preparation works, which goes to QueryStageExec.doPrepare
QueryStageExec.doPrepare calls prepare of shuffle/broadcast, which triggers all the subqueries in this stage
executeQuery then calls waitForSubqueries, which does nothing because QueryStageExec itself has no subqueries
then we submit the shuffle/broadcast job, without waiting for subqueries
for ShuffleExchangeExec.mapOutputStatisticsFuture, it calls child.execute, which calls executeQuery and wait for subqueries in the query tree of child
The only missing case is: ShuffleExchangeExec itself may contain subqueries(repartition expression) and AQE doesn't wait for it.

A simple fix would be overwriting waitForSubqueries in QueryStageExec, and forward the request to shuffle/broadcast, but this PR proposes a different and probably cleaner way: we follow execute/doExecute in SparkPlan, and add similar APIs in the AQE version of "execute", which gets a future from shuffle/broadcast.
Why are the changes needed?

bug fix
Does this PR introduce any user-facing change?

a query fails without the fix and can run now
How was this patch tested?

new test

cc @maryannxue @JkSelf @viirya @yaooqinn

Test build #140263 has started for PR 33058 at commit 1f7e6c1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44792/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44792/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44792/

Test build #140265 has started for PR 33058 at commit c964743.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44795/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44795/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44795/

Test build #140263 has finished for PR 33058 at commit 1f7e6c1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140263/

Test build #140265 has finished for PR 33058 at commit c964743.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140265/

Test build #140503 has started for PR 33058 at commit c964743.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45015/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45015/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45017/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45017/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45017/

Test build #140503 has finished for PR 33058 at commit c964743.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140503/

Test build #140764 has started for PR 33058 at commit 6a7e388.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45276/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45276/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45276/

Test build #140764 has finished for PR 33058 at commit 6a7e388.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140764/

LGTM

thanks for the review, merging to master/3.2!

thanks for the review, merging to master/3.2!

thanks for the review, merging to master/3.2!


feat: Methodology | create the page

Fixes Issue

Changes proposed

Screenshots

Note to reviewers

Code of Conduct

[ ] By submitting this pull request, I confirm I've read and complied with the CoC 🖖

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

You can also join our Discord community.
Feel free to check out other cool repositories of the Thecyberworld.
Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).

Ok I will

@ArkadiK94  sorry i may have overlook it but i have updated the code u check


Backport: Ensure that vx-submariner interface is up (#1284)

Fixes issue: https://github.com/submariner-io/submariner/issues/1275
Signed-Off-by: Sridhar Gaddam<EMAIL_ADDRESS>(cherry picked from commit e57ecd99feb27d4a2e9e014a2db85f588d9abfa0)

@mangelajo @skitt @tpantelis Is this some known issue?
E2e tests are failing for an unrelated error
[cluster3] Error: serviceaccounts "default" already exists
make[1]: *** [/opt/shipyard/Makefile.inc:45: deploy] Error 1
make: *** [/opt/shipyard/Makefile.inc:49: e2e] Error 2

Ok, we need to figure out what's wrong with CI here.

@sridhargaddam can we rebase this one?, github is not showing the button.

Ah wait, this is release-0.8, it's probably up to date.

oh @sridhargaddam you backported on top of release-0.8, it shall be release-0.9


No option to dismiss "Forgot your password?" alert on lock screen

Bug description
When clicking the little "i" at the top right on the lock screen view, it shows an alert with an option to reset the password, but there's no way for the user to cancel the operation other than relaunching the app.
To Reproduce
Steps to reproduce the behavior:

Open the app (or click the lock icon when already in the app)
Click the "i" icon at the top

Expected behavior
There should be an option to dismiss the alert and to not reset the password. I clicked on it because I was curious what it is. Maybe the "Reset password" option should also have the descructive attribute to make it red.
Is there a backup of the data stored when resetting the password? Because currently it's a bit easy to reset it and delete all data which is really bad when you store all logins within the app.
Screenshots

Device

Device: iPad Air 4th generation
OS: iOS 15.0 Beta (19A5337a)
App Version 1.0 Build 8

Fix


Compiling with -flto

Reported as: lp:1333035
Reported by: lp:~dpa-launchpad
Reported at: 2014-06-22T23:50:38Z

Imported from Launchpad using lp2gh.

I have gcc490, libtool  <IP_ADDRESS>4.30-da30-dirty, and libmemcached 1.0.18. I run CFLAGS = "-flto -O3" CXXCFLAGS="-flto -O3" ./configure .  In turn, because of optimizations, client/.libs/libutilities.a does not contain close_stdio and clients/memcapable does not link due to missing close_stdio() .
Please disable -fvisibility=hidden from CPPflags, when creating clients/libutilities , so that close_stdio() is contained there /remains visible when linking to the programs in clients/, or ensure by other means, that passing -flto to GCC can link the clients/ programs.
Compiling with just -O3 and without -flto works fine.

Not an issue anymore. Configure with cmake -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=1.


Injected service and IMessageBus seem to differ in scope

I don't seem to be able to access the same IMessageBus as the handler when instantiating a service in my DI container. I'm trying to do this to create tenant-aware services that don't require passing around a tenant id manually on every method call.
Given this service:
public class Service : IService
{
    public string TenantId {get; set;}
}

Registered like this:
services.AddScoped<IService>(s => {
    var bus = s.GetRequiredService<IMessageBus>();
    return new Service { TenantId = bus.TenantId };
});

Being injected into this:
public Task Handle(Message message, IMessageBus bus, IService service)
{
      // bus.TenantId is populated properly
      // service.TenantId is null
}

This code being run in a background worker, not in an HTTP pipeline. The real code is obviously more complex with more than a string that gets set. Is this roughly the same issue as https://github.com/JasperFx/wolverine/issues/501 or https://github.com/JasperFx/wolverine/issues/360 ? If so, any ideas for a workaround?
Thanks! I'm really like Wolverine thus far.

@BrianVallelunga I'm going to add this to the docs to "don't do that"
I'll look at the exact resolution, but can you get rid of the Lambda usage here? Even if we can fix the code generation, I would very strongly recommend using IMessageBus within a lambda like this (and honestly recommend against doing things like that except in rare exception cases as a 20 year IoC author):
services.AddScoped<IService>(s => {
    var bus = s.GetRequiredService<IMessageBus>();
    return new Service { TenantId = bus.TenantId };
});

Wolverine is trying very hard to not use the IoC container at runtime. Having a lambda registration that's scoped or transient defeats that and forces Wolverine back to using a nested container. Which is fine, except that Wolverine itself creates the actual object of the IMessageContext / IMessageBus that you see used in the handler.
We can beat this by having the current IMessageBus/IMessageContext injected into the nested container to make your scenario work, but I'd still recommend against that.
will never work with

I can inject an IServiceFactory into my handler with a Build(string tenantId) method on it. Due to other architecture choices, I'd only need one of these per tenant-aware handler, so perhaps that is a better choice. The IServiceFactory wouldn't need the lambda registration itself.

I honestly don't even want to try to address this other than as a documentation issue.

All good, thanks! Creating a factory seems to have solved the issue for me.


Log prints should be in single line with limited length

Environment info

NooBaa Version: 5.14
Platform: NA

Actual behavior

Today our logging prints a lot of new lines as it formats js objects to pretty print it.
This makes it very hard to grep from the logs or parse them.
In addition some prints are accidentally huge and print enormous objects.

Expected behavior

Log prints should be single line and limited in length.

Steps to reproduce

Trivial.

More information - Screenshots / Logs / Other output
FYI @nimrod-becker @dannyzaken - can we fix this and consider also backporting to 5.12/5.13 too?

reference - https://getpino.io/#/


Its not working for windows 11?

Rat not working for windows 11? When I send someone he says he's computer restarting.

The document says, it works foe win 10

The document says, it works foe win 10

No I build rat and its working for me but the person I want to hack needs to use windows 10?

yes

yes

Never mind its working for windows 11 but I wanna ask can I take new informations after he open or he have to open the exe again?

Good for you if it works in win11.
if you selected the startup option and their antivirus didn't remove it from there, you can get the info the next time they start their pc.
otherwise they have to open it again

Oh ok thanks for information

👌 If you don't have further questions, you may close the issue.


[UX] Provide a "Delete" button for steps on canvas

Is your feature request related to a problem? Please describe.
Adding new figures / steps to the canvas is really easy and can be done directly on the canvas which is quite convenient. Unfortunately to remove a figure from the canvas you have to click it to open the right side configuration panel and to click the "Delete" button there.
Describe the solution you'd like
Can we add a "-" button to the figure analogue to the "+" one?
Additional context

@miram13 - As we discussed on our call earlier today, this is how I would approach this issue, but feel free to do it differently:
Functionality
We already have a function to delete steps that can be reused (the same one we call when deleting a step from the Step Detail View) here. However, for it to be reused we need to move setIsPanelExpanded(false); out of there (because we don't need to close the panel if we delete the step directly from the canvas).

I suggest that instead of calling handleDeleteStep directly as it does here, you instead convert it to its own function like this:

() => {
  handleDeleteStep();
  setIsPanelExpanded(false);
}

Pass the handleDeleteStep method to the VisualizationStep component by adding a reference to it here, just like we do with step.
Your IDE will complain because IVizStepPropsNode is an interface in TypeScript, almost like a blueprint for what properties it allows, and it doesn't understand what is handleDeleteStep. You will have to edit that interface to also allow a function called handleDeleteStep or whatever you choose to call it. This is done from here. It could look something like this: handleDeleteStep: () => void.
Now you will have access to this function in the VisualizationStep component, like data.handleDeleteStep(). So you should create a function that handles clicking on the trashcan icon once you have it, something like, const handleTrashClick = () => { // open a modal to confirm, or just call data.handleDeleteStep() directly };.

Styling/CSS
You can use a similar approach to how we do for the + button here and there is some CSS to position it around the node, like this.
Bonus
Because this would allow users to delete without opening the Step Detail, it makes it really easy to make a mistake and delete a Step. We should consider adding a confirmation modal like we do for the toolbar here, and call data.handleDeleteStep() from there. We can even use the same ConfirmationModal component.
Of course, you can always ping me and I'll be available for any questions. :)


Generating uncompilable code when response code >= 512

Problem statement
If response code is 512 or higher the generated code is not valid and do not compile.
This is the error;
$ go build cmd/hello-world-app-server/main.go
# test/api/restapi/operations
restapi/operations/hello.go:29:16: unknown field 'Context' in struct literal of type Hello
restapi/operations/hello.go:29:30: unknown field 'Handler' in struct literal of type Hello
restapi/operations/hello_responses.go:21:6: Hello redeclared in this block
	previous declaration at restapi/operations/hello.go:37:6
restapi/operations/hello_responses.go:25:6: NewHello redeclared in this block
	previous declaration at restapi/operations/hello.go:28:63
restapi/operations/hello_world_app_api.go:244:30: cannot use NewHello(o.context, o.HelloHandler) (type *Hello) as type http.Handler in assignment:
	*Hello does not implement http.Handler (missing ServeHTTP method)
restapi/operations/hello_world_app_api.go:244:40: too many arguments in call to NewHello
	have (*middleware.Context, HelloHandler)
	want ()

Swagger specification
swagger: "2.0"
info:
  version: "0.0.1"
  title: Hello World App
paths:
  /hello:
    get:
      operationId: hello
      responses:
        "512":
          description: Success

Steps to reproduce
$ swagger generate server
(...)
$ go build cmd/hello-world-app-server/main.go

Environment
swagger version: dev (github.com/go-swagger/go-swagger/cmd/swagger)
go version: 1.11.5
OS:   OSX

Such value is not a valid http status code which is required by swagger

actually the status codes are not an exhaustive list, the numbers that are not well-known just don't have a default message. I got sidetracked with work, but this is definitely a piece of missing functionality because we should be able to deal with this.

There are some Unofficial Status code that are up to 512; https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#5xx_Server_errors
For instance the ones used by Cloudflare; https://support.cloudflare.com/hc/en-us/sections/200820298-Error-Pages
I would recommend to do not limit that value to strict specifications.

Yeah, @casualjim is right. Bug acknowledged

The HTTP specification just says that it's a 3 digit number that starts with 1, 2, 3, 4, or 5.  Thus, the valid range is 100 to 599.
https://tools.ietf.org/html/rfc7231 section 6


Error: Are you sure that 'metric_logging' is importable from module 'torchtune.utils'?

Hello, when i execute tune run lora_finetune_single_device --config xxx.yaml, with the yaml file is:
# Logging
output_dir: finetune/model-dir/Qwen2.5-0.5B-Instruct-finetune
metric_logger:
  _component_: torchtune.utils.metric_logging.WandBLogger
  project: Qwen2.5-0.5B-Instruct-finetune-torchtune
log_every_n_steps: 1

But error output:
torchtune.config._errors.InstantiationError: Error loading 'torchtune.utils.metric_logging.WandBLogger':
ModuleNotFoundError("No module named 'torchtune.utils.metric_logging'")
Are you sure that 'metric_logging' is importable from module 'torchtune.utils'?

My env list:
Collecting environment information...
PyTorch version: 2.5.1+cu124
Is debug build: False
CUDA used to build PyTorch: 12.4
ROCM used to build PyTorch: N/A

OS: Ubuntu 20.04 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.31

Python version: 3.12.7 | packaged by Anaconda, Inc. | (main, Oct 4 2024, 13:27:36) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.31
Is CUDA available: True
CUDA runtime version: 12.6.68
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA GeForce RTX 3090
GPU 1: NVIDIA GeForce RTX 3090

Nvidia driver version: 565.90
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.9.5.1
/usr/lib/x86_64-linux-gnu/libcudnn_adv.so.9.5.1
/usr/lib/x86_64-linux-gnu/libcudnn_cnn.so.9.5.1
/usr/lib/x86_64-linux-gnu/libcudnn_engines_precompiled.so.9.5.1
/usr/lib/x86_64-linux-gnu/libcudnn_engines_runtime_compiled.so.9.5.1
/usr/lib/x86_64-linux-gnu/libcudnn_graph.so.9.5.1
/usr/lib/x86_64-linux-gnu/libcudnn_heuristic.so.9.5.1
/usr/lib/x86_64-linux-gnu/libcudnn_ops.so.9.5.1
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 36
On-line CPU(s) list: 0-35
Thread(s) per core: 2
Core(s) per socket: 18
Socket(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz
Stepping: 7
CPU MHz: 3000.000
BogoMIPS: 6000.00
Virtualization: VT-x
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 576 KiB
L1i cache: 576 KiB
L2 cache: 18 MiB
L3 cache: 24.8 MiB
Vulnerability Gather data sampling: Unknown: Dependent on hypervisor status
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; Enhanced IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Enhanced / Automatic IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI SW loop, KVM SW loop
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; TSX disabled
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon rep_good nopl xtopology tsc_reliable nonstop_tsc cpuid pni pclmulqdq vmx ssse3 fma cx16 pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid avx512f avx512dq rdseed adx smap clflushopt clwb avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves avx512_vnni md_clear flush_l1d arch_capabilities

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-cublas-cu12==<IP_ADDRESS>
[pip3] nvidia-cuda-cupti-cu12==12.4.127
[pip3] nvidia-cuda-nvrtc-cu12==12.4.127
[pip3] nvidia-cuda-runtime-cu12==12.4.127
[pip3] nvidia-cudnn-cu12==<IP_ADDRESS>
[pip3] nvidia-cufft-cu12==<IP_ADDRESS>
[pip3] nvidia-curand-cu12==<IP_ADDRESS>
[pip3] nvidia-cusolver-cu12==<IP_ADDRESS>
[pip3] nvidia-cusparse-cu12==<IP_ADDRESS>
[pip3] nvidia-nccl-cu12==2.21.5
[pip3] nvidia-nvjitlink-cu12==12.4.127
[pip3] nvidia-nvtx-cu12==12.4.127
[pip3] torch==2.5.1
[pip3] torchao==0.6.1
[pip3] torchtune==0.0.0
[pip3] torchvision==0.20.1
[pip3] triton==3.1.0
[conda] numpy 1.26.4 pypi_0 pypi
[conda] nvidia-cublas-cu12 <IP_ADDRESS> pypi_0 pypi
[conda] nvidia-cuda-cupti-cu12 12.4.127 pypi_0 pypi
[conda] nvidia-cuda-nvrtc-cu12 12.4.127 pypi_0 pypi
[conda] nvidia-cuda-runtime-cu12 12.4.127 pypi_0 pypi
[conda] nvidia-cudnn-cu12 <IP_ADDRESS> pypi_0 pypi
[conda] nvidia-cufft-cu12 <IP_ADDRESS> pypi_0 pypi
[conda] nvidia-curand-cu12 <IP_ADDRESS> pypi_0 pypi
[conda] nvidia-cusolver-cu12 <IP_ADDRESS> pypi_0 pypi
[conda] nvidia-cusparse-cu12 <IP_ADDRESS> pypi_0 pypi
[conda] nvidia-nccl-cu12 2.21.5 pypi_0 pypi
[conda] nvidia-nvjitlink-cu12 12.4.127 pypi_0 pypi
[conda] nvidia-nvtx-cu12 12.4.127 pypi_0 pypi
[conda] torch 2.5.1 pypi_0 pypi
[conda] torchao 0.6.1 pypi_0 pypi
[conda] torchtune 0.0.0 pypi_0 pypi
[conda] torchvision 0.20.1 pypi_0 pypi
[conda] triton 3.1.0 pypi_0 pypi

Thanks a lot for your assistance!

Hi @zhoufy20 thanks for creating the issue. I think your config may be out of date, torchtune.utils.metric_logging was moved to torchtune.training.metric_logging. You can compare your config with the one in main here to see if there are any other fields you'll need to update.

Hi @zhoufy20 thanks for creating the issue. I think your config may be out of date, torchtune.utils.metric_logging was moved to torchtune.training.metric_logging. You can compare your config with the one in main here to see if there are any other fields you'll need to update.

Thanks a lot , @ebsmothers . There is another problem is possible,
How to use _component_: torchtune.training.metric_logging.WandBLogger in Sbatch  system on the supercomputer,
where echos
wandb.errors.errors.CommError: Run initialization has timed out after 90.0 sec. Please try increasing the timeout with the `init_timeout` setting: `wandb.init(settings=wandb.Settings(init_timeout=120))`.

@zhoufy20 , this is not a direct answer to you question about running wandb offline. However, we do support tensorboard, which is similar to wandb and does run offline: https://pytorch.org/torchtune/main/generated/torchtune.training.metric_logging.TensorBoardLogger.html?highlight=tensorboard


How to handle situations where only some frames do not detect faces.

error :
No face detected in the source image!

Wondering about this too.

Handled simply by skipping now.


Append zone default false

Fixes #6 for backwards compatiblity.
Checked the node and functionality seemed to work.

Thanks! Sorry it took a while to get to this.


Single line Kdocs are incorrectly fixed by diktat

    /** Create KotlinCoreEnvironment with specified classpath */
    fun create(libraries: Set<File>): KotlinCoreEnvironment {
        setIdeaIoUseFallback()

newlines are invalid in such case:
/** Create KotlinCoreEnvironment with specified classpath
 *
 * @param libraries
 * @return*/
fun create(libraries: Set<File>): KotlinCoreEnvironment {
    setIdeaIoUseFallback()
}

And need to think about comments...
/* Stores enough information to generate function reference IR */
data class IrFunctionInfo(
    val fqName: String,
    val receiverFqName: String?,
    val isObjectReceiver: Boolean
)

->
/**
 * @property fqName
 * @property receiverFqName
 * @property isObjectReceiver
 */
/* Stores enough information to generate function reference IR */

The first one looks more like a whole new warning, I think. Because we should check that if KDoc has more than one line, starting /** and ending */ should occupy their own lines. If we fix it now for @param and other tags only, similar bugs may occur in other cases.
Regarding comments - I'm not sure that it's worth fixing automatically. We can't be sure, if the comment before class is a piece of documentation or just a comment. And it cases like this it can be merged automatically.

No, @petertrr I am saying that there is incorrect newlines:
/** Create KotlinCoreEnvironment with specified classpath  <---
 *
 * @param libraries
 * @return*/ <------


Comment out baseball example from test_examples

This is to resolve the build failure until #1458 is resolved.

if everything is fixed why is this failure sporadic?

@jpchen - I forgot about the coverage test which fails if any of our examples aren't in test_examples. I am only bypassing the specific model that is sporadically failing. I'm not sure about the source of non determinism in that, because we are setting the random seed.

Ready to merge.


Revert 4028 for 8.1.x branch

This reverts commit 3b5d77ac9a68edae297d6e5177de1f3b002a469e.
4028 is causing crashes.

we're successfully using 4028 in our 8.0.x branch without crashes.. what's the plan to replace this feature?

We'll aim to have this fixed properly for 9.0.x.