[DOC] add config naming policy

What changes were proposed in this pull request?

Add docs to describe the config naming policy.
Why are the changes needed?

To encourage contributors to name configs more consistently.
Does this PR introduce any user-facing change?

no
How was this patch tested?

N/A

cc @dongjoon-hyun @rxin @HyukjinKwon  @HeartSaVioR  @maropu @kiszk

I pick this place over https://spark.apache.org/contributing.html, because this place is more visible to the developers. Ideally all configs should be defined with ConfigEntry so this looks like a logical place to put the naming policy.

Test build #118404 has started for PR 27577 at commit 63e4dc5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23163/
Test PASSed.

I am good with it.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23172/
Test PASSed.

Looks good

Test build #118416 has started for PR 27577 at commit 7464295.

Test build #118404 has finished for PR 27577 at commit 63e4dc5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118404/
Test PASSed.

Test build #118416 has finished for PR 27577 at commit 7464295.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118416/
Test FAILed.

retest this please

Test build #118433 has started for PR 27577 at commit 7464295.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23190/
Test PASSed.

Test build #118433 has finished for PR 27577 at commit 7464295.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118433/
Test FAILed.

Test build #118477 has started for PR 27577 at commit 422730d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23234/
Test PASSed.

Test build #118477 has finished for PR 27577 at commit 422730d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118477/
Test PASSed.

btw, if we want to remind developers to follow the naming rule, how about adding a link to this guildeline in the PR template, too?

Beyond this PR, can we create a sanity checker?

btw, if we want to remind developers to follow the naming rule, how about adding a link to this guideline in the PR template, too?

Yea this is a good idea!

Beyond this PR, can we create a sanity checker?

This is hard. e.g. how to decide if a name is clear or not? We may be able to check if a boolean config is ended with .enabled or a verb, but not sure how to simply check verb.

thanks for the review, merging to master!

btw, if we want to remind developers to follow the naming rule, how about adding a link to this >> guideline in the PR template, too?
Yea this is a good idea!

ok, I'll make a pr for the update now.

+1, late LGTM. Thank you!


Factory girl looking for et.ogg

I have just installed factory_girl_rails into my app (i.e. not Pageflow, but the Rails app) and suddenly I get this error:
17:41 $ bundle exec rake cucumber --trace
** Invoke cucumber (first_time)
** Invoke cucumber:ok (first_time)
** Invoke test:prepare (first_time)
** Invoke db:seed (first_time)
** Execute db:seed
** Invoke db:abort_if_pending_migrations (first_time)
** Invoke environment (first_time)
** Execute environment
rake aborted!
Errno::ENOENT: No such file or directory @ rb_sysopen - /Users/joost/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/pageflow-0.8.1/spec/fixtures/et.ogg
/Users/joost/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/pageflow-0.8.1/spec/factories/audio_files.rb:7:in `initialize'

which makes sense, because that file is not in the engine's fixtures folder, but in the engine's factories folder. Any idea why I would see this error though? I don't run the engine's tests at all but clearly Factory Girl is digging into it and finds the factories.

Hi Joost,
sorry for the late response. I think you are seeing this error because the spec/fixtures folder is not included in the gem. For now you can work around this by using a git source in your Gemfile, but we should definitely add the fixtures to the gem.
Just so you know: the Factory Girl definitions are added via the Pageflow engine at the moment. I've since started collecting other development dependencies for Pageflow plugins inside a separate pageflow-support gem. It would make more sense to move the factory definitions (and fixtures) into that gem. That way, adding Pageflow to an application's Gemfile would not automatically register the factories and prevent namespace collisions in case you already have an entry, page etc. factory.
Cheers

I didn't know that FactoryGirl was being configured in engine.rb. Couldn't you better put it in the engine's config/environments/development.rb?
Anyway, the pageflow-support (or pageflow-devel?) approach sounds good as a long-term solution. For the short term, will adding the fixtures to the pageflow gem fix it? I could make that change quite quickly, but since it's such a small thing there must be a reason you didn't do it? Just making sure we're aligned...

Yes, I simply forgot and didn't notice since we use git sources in our Gemfiles most of the time. If you have the time, I'd be happy to accept a PR, or even better two: one that fixes it on master and another backporting the change to the 0-8-stable branch. Then I can release 0.8.2 tonight. Thanks!

No problem.

See #368 and #369
I was also wondering if we should change https://github.com/codevise/pageflow/blob/master/pageflow.gemspec#L14 into Dir['spec/**/*']?

Thanks for the PRs. I've released 0.8.2. Can you verify that this fixes the problem?
Looking at this SO question I wonder if we should simply delete the test_files line. The way I understand it, test_files are also installed along with the gem, which seems like extra baggage to me.

YES! 0.8.2 fixes the issue! :tada:
test_files is not present in the specification at all anymore. I'd say it can safely be dropped.

That's great to hear!
I'll remove the useless test_files attribute now (#370). Also, I noticed that Readme and Changelog were not included in the gem. Not really sure where this could be helpful, but it feels like those should also be in there (#371).

The only downside of adding the fixtures is that we now include a 4MB fixture video in the gem... I should probably look into moving the factories out of the main gem when I get a chance.

Yes, I didn't fully realise. It's not horrible but it's not a long term solution either. If I can be helpful, I'd love to contribute.

Op 20 jul. 2015 om 21:47 heeft Tim Fischbach<EMAIL_ADDRESS>het volgende geschreven:
The only downside of adding the fixtures is that we now include a 4MB fixture video in the gem... I should probably look into moving the factories out of the main gem when I get a chance.
—
Reply to this email directly or view it on GitHub.

We are always happy to accept contributions! I wonder if we should create more issues for planned or possible features and additions. Maybe even for small stuff like this. It might help coordinate and encourage contributions. On the other hand, I do not want to litter the issue tracker  with vague "wish list" issues nobody is working on actively...

A public Trello board? It might be a little too much procedure. I'm happy to just exchange email for the time being.

Op 21 jul. 2015 om 17:11 heeft Tim Fischbach<EMAIL_ADDRESS>het volgende geschreven:
We are always happy to accept contributions! I wonder if we should create more issues for planned or possible features and additions. Maybe even for small stuff like this. It might help coordinate and encourage contributions. On the other hand, I do not want to litter the issue tracker with vague "wish list" issues nobody is working on actively...
—
Reply to this email directly or view it on GitHub.


luape will not compile a label eg ::help::

When I try to create a label it throws up an error . tried lua 5.3 and 5.1  and the same thing happens . If I take out the goto and label it compiles fine . My little program works fine in the zerobrane IDE . Is there an older version of luape I could try.

I have tried an earlier version or luape.exe and still the same problem . I'm using windows 11 but I don't think that is the problem.
`

luape is compiled with Lua 5.1, but labels and goto were introduced in Lua 5.2. If you want to use those features in luape, you will have to replace Lua 5.1 source with Lua 5.2 source in the deps directory and recompile luape.
The version of Lua 5.1 already included has been slightly modified in order to support luape's options and flags. You will have to add those changes to the Lua 5.2 source before compiling or options like /debug won't work (all builds will be debug builds).

Thankyou very much for the explanation I will try to recompile Luape with 5.2 + and see how I get on . Awesome tool none the less. Thanks. Sent from Mail for Windows From: rosemashSent: 11 April 2022 19:48To: rosemash/luapeCc: pfaber11; AuthorSubject: Re: [rosemash/luape] luape will not compile a label eg ::help:: (Issue #1) luape is compiled with Lua 5.1, but labels and goto were introduced in Lua 5.2. If you want to use those features in luape, you will have to replace Lua 5.1 source with Lua 5.2 source in the deps directory and recompile luape.The version of Lua 5.1 already included has been slightly modified in order to support luape's options and flags. You will have to add those changes to the Lua 5.2 source before compiling or options like /debug won't work (all builds will be debug builds).—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


Corners are inserted in the output mesh even if they are no data values

I tried to transform a DEM from HiRise data which is distributed as GTiff format. The input DEM is available here.
This file includes several no-data value points which include the four corners of the raster DEM and dem2tin seems to add to the output obj the four corners even if these are no-data values.
The following is the output of the program after processing the DEM:

Insertion of vertices in place of nodata pixels at corners is a part of meshing alorithm and can't be fixed withou making significant changes to it. There's no easy way to solve this, simplest way may be just rotating the raster.

Sorry for bothering more on this topic, wouldn't we be able to simply post-process the mesh removing all vertices which correspond to no-data values on the raster?


No Messages in Cabana - Need to view LKAS11 values

Describe the bug
I uploded all logs. But I cannot view cabana/LKAS11 data.
All I get in cabana is "Loading messages..."

Provide a route where the issue occurs
6111bd7df5043394|2023-01-12--19-48-43--0
openpilot version
master
Additional info
No response

web cabana is going to be deprecated soon. try out the new cabana here instead: https://github.com/commaai/openpilot/tree/master/tools/cabana


Validate if we support word documents

Hello, this is related to this issue, I believe this does not support word and powerpoint documents yet.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6317af39-eff1-77b4-8680-9fc06f0d1fdd
Version Independent ID: 60284391-262c-807a-fb8f-9d7422b1926d
Content: Using your data with Azure OpenAI Service - Azure OpenAI
Content Source: articles/ai-services/openai/concepts/use-your-data.md
Service: cognitive-services
Sub-service: openai
GitHub Login: @aahill
Microsoft Alias: aahi

@raffertyuy
Thanks for your feedback! We will investigate and update as appropriate.

@raffertyuy
According to the Azure OpenAI Service documentation, the Read Optical Character Recognition (OCR) model of Form Recognizer can extract text from Microsoft Word documents, along with other file formats such as PDF, TIFF, and HTML.
Please go through this below link for your reference.
https://learn.microsoft.com/en-us/azure/ai-services/document-intelligence/concept-read?view=doc-intel-

@raffertyuy
We are going to close this thread, if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.
#Please-close


android namespace conflict

Information

Apktool Version (apktool -version) - 2.4.0
Operating System (Mac, Linux, Windows) - Linux
APK From? (Playstore, ROM, Other) - none

android.util.TypedValue, android.util.AttributeSet, and android.content.res.XmlResourceParser conflicts with the ones located in AOSP SDK api's
Stacktrace/Logcat
Include stacktrace here

Steps to Reproduce

apktool

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?
If you are trying to install a modified apk, did you resign it?
Are you using the latest apktool version?

This is intentional, but I did notice we wiped the copyright on the AOSP files which is a big no-no. So I'll leave this open to fix that and instruct our copyright script to ignore that namespace.

This is intentional, but I did notice we wiped the copyright on the AOSP files which is a big no-no. So I'll leave this open to fix that and instruct our copyright script to ignore that namespace.

why intentional?

This is intentional, but I did notice we wiped the copyright on the AOSP files which is a big no-no. So I'll leave this open to fix that and instruct our copyright script to ignore that namespace.

why intentional?

Because we did not write that code. It came from AOSP, so match the namespace. Unfortunately as I said - my copyright code wiped the copyright on those.

Fixed the copyright headers on 3rd party files, thanks for the catch!


Collapsing new lines before on elif/else/except blocks?

I've found a whole lot of code in our project written in the style:
if condition == "something":
    do_some_code()

elif condition == "else":
    do_something_else()

else:
    do_fallback()

try:
    do_more_things(condition)

except ValueError:
    respond_to_exception()

Which I've not encountered before, and makes it very hard to visually separate into blocks for reading. I'd expected black to reformat to:
if condition == "something":
    do_some_code()
elif condition == "else":
    do_something_else()
else:
    do_fallback()

try:
    do_more_things(condition)
except ValueError:
    respond_to_exception()

But it isn't handled. Is this within black's scope?
(Colleague: "PEP8 doesn't tell you not to do this", which I guess is an argument, but I think technically PEP8 doesn't tell you to not to wrap one line simple if statements in brackets if (condition): either)

What you're asking for was the original behavior of Black. It met with tremendous amount of criticism so now Black will let you keep your vertical whitespace within functions (up to one empty line at a time). This is unfortunately not actionable.


Can't use iohook on a simple node app

Expected Behavior

Make it run on a simple node app.
Current Behavior

Showing this message and closing porcess:
refresh_locale_list [476]: GetKeyboardLayoutList(0, NULL) found 3 layouts.
refresh_locale_list [493]: Received 3 locales.
load_input_helper [866]: refresh_locale_list() found 3 locale(s).

Steps to Reproduce (for bugs)

Use node 15.x
Run npm install iohook --save
node run index.js
Use node 10.x
Do step 2
Do step 3

index.js:
const ioHook = require('iohook')

ioHook.on('keydown', key => {
  console.log(key)
})

ioHook.start(true);

Context

I'm trying to run a simple node application but it shows that message and closes the process. I changed the node version to 10.9.0 and reinstalled the module, and nothing happens.
[EDIT]: When run as a test script, it shows that the test failed. But you don't see an error message.
Your Environment

Version used: ^0.7.2
Environment name and version (e.g. Chrome 39, node.js 5.4): node 15.4.0, node 10.9.0
Operating System and version (desktop or mobile): Windows 10 pro 2004 x64 - desktop

I'm getting this as well with exactly the same output. It should be noted that all that is required to duplicate this issue is to require('iohook');

Yep having the same problem. Bare in mind the index.js supplied is wrong (has numerous mistakes in it). Heres an example with no mistakes which still doesn't work:
'use strict';

const ioHook = require('iohook');

ioHook.on('mousemove', event => {
  console.log(event);              // { type: 'mousemove', x: 700, y: 400 }
});

// Register and start hook
ioHook.start();

Hey @sancarn , thanks for your message. What about submitting a PR with your suggested changes so everyone can benefits from your findings ? Thanks.

@Djiit Erm I haven't fixed the issue? I only fixed the code example supplied by @denyncrawford

Did some searching. Found that the error occurs on require("iohook") (initial load). The crash appears to occur within the constructor of IOHook class, when this.load() is called, which in turn calls NodeHookAddon.startHook(this._handler.bind(this), this.debug || false);.
Unfortunately, i did look through the C code but can't even find where the following messages are logged:
refresh_locale_list [476]: GetKeyboardLayoutList(0, NULL) found 3 layouts.
refresh_locale_list [493]: Received 3 locales.
load_input_helper [866]: refresh_locale_list() found 3 locale(s).

So can't really help from here. Will need one of the devs who knows what's going on to explain what's going on...

Note: We can't even do the following:
try {
   iohook = require("iohook")
} catch {
   ...
}

And with modern import iohook from "iohook" standards we can't use try like that anyway. Ideally the node app should have no way of crashing on initialisation and I'm not totally sure why the hook starts on startup either...? Shouldn't it only occur when we call start() ?

@sancarn those log messages are from this function https://github.com/wilix-team/iohook/blob/e584b64aa0dcc0e2f9acc5f5dab37fe7241c4c68/libuiohook/src/windows/input_helper.c#L469
And they are not errors in and of themselves rather they are expected log output. While they're not an indication of an error they at least show how far the lib gets before crapping out.
I was able to reproduce this issue on Windows 10 but only on one version of Node that I tried, latest stable Node v14.x (83). In all earlier Node versions I tried iohook worked using the prebuilt binaries (nb: I didn't test every single Node version). So there may be something with changes in latest Node that lead iohook to cause the process to exit silently like that. Needs further investigation, I'm not an expert on this project but I'll try to take a deeper look when I get a chance.
One question, are you using the prebuilt binaries or did you build them yourself?

Update: looks like it's working fine in all Node versions <= 13.x but fails silently in >= 14.x. Appears to be a Windows only issue.

I'm having a similar problem on Linux with Node 14, it simply exits without any errors or messages.
I've tried this script:
const ioHook = require('iohook');

ioHook.on('keydown', (event) => {
  console.log(event);
});

ioHook.start(true);

Any possible fix or update related to this issue, without downgrading node?

Any possible fix or update related to this issue, without downgrading node?

@denyncrawford I was able to get this functional on node v14 by using v0.6.6 of the library. It seems that versions past that (0.7.x) are broken.
gongo@Gonputer MINGW64 ~/workplace/tuya/test
$ npm add<EMAIL_ADDRESS>
[removed adding logging]

+<EMAIL_ADDRESS>
gongo@Gonputer MINGW64 ~/workplace/tuya/test
$ node index.js
refresh_locale_list [476]: GetKeyboardLayoutList(0, NULL) found 3 layouts.
refresh_locale_list [493]: Received 3 locales.
load_input_helper [866]: refresh_locale_list() found 3 locale(s).
[exits with no message]

gongo@Gonputer MINGW64 ~/workplace/tuya/test
$ npm remove iohook

gongo@Gonputer MINGW64 ~/workplace/tuya/test
$ npm remove iohook && npm add<EMAIL_ADDRESS>
[removed removal & adding logging]

removed 148 packages and audited 10 packages in 1.031s
+<EMAIL_ADDRESS>
gongo@Gonputer MINGW64 ~/workplace/tuya/test
$ node index.js
refresh_locale_list [476]: GetKeyboardLayoutList(0, NULL) found 3 layouts.
refresh_locale_list [493]: Received 3 locales.
load_input_helper [866]: refresh_locale_list() found 3 locale(s).
Connected to device!
Data received

@TheMrGong Nice :D I'll check it later, thanks!

@TheMrGong Doesn't work for node v15>=

@TheMrGong Doesn't work for node v15>=

@amoschoomy I had to compile iohook myself for node 15, it worked then

@amoschoomy I had to compile iohook myself for node 15, it worked then

@amoschoomy I had to compile iohook myself for node 15, it worked then

could you give us a run through on how to compile yourself?

could you give us a run through on how to compile yourself?

@bomeers I followed the instructions from the documenation

could you give us a run through on how to compile yourself?

@bomeers I followed the instructions from the documenation

Completely missed that one. Thank you

@TheMrGong I'm looking at the docs and this caught my eye:

Install: msys2 with autotools, pkg-config, libtool, gcc, clang, glib, C++ Build Tools, cmake

Do I have to install all of these or just one of them?

@bomeers I think that info is out of date for Windows since this proj doesn't use cmake anymore. If you installed Node.js with the "install tools for native modules" box checked you should already have all the prereqs needed, if not you can follow the instructions for node-gyp https://github.com/nodejs/node-gyp#on-windows.

@marcelblum I've got that box checked and I started going through the steps to create the iohook.node file. Seems I ran into a common error:
internal/modules/cjs/loader.js:883
  throw err;
  ^

Error: Cannot find module 'fs-extra'
Require stack:
- C:\<file_path>\node_modules\iohook\build.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
    at Function.Module._load (internal/modules/cjs/loader.js:725:27)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (C:\<file_path>\node_modules\iohook\build.js:2:12)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12) {
  code: 'MODULE_NOT_FOUND',

the npm package fs-extra isn't loading in correctly

@bomeers sounds like maybe you didn't do a full npm install from iohook's root before npm run build?

Tried this and had the same result:
cd .\node_modules\iohook\
npm install
npm run build

ok i think i see the problem you are trying to build from the files that come down the pipe when you npm install iohook but that doesn't include the full iohook source. What you need to do is clone the iohook git repo. Then npm install from the root of your local copy of the repo... then npm run build

@marcelblum That worked for me. So the build went through and created a folder called build. Do I just paste that in my node_module in my other project?

@bomeers no - you'd need to copy 2 files that you just built iohook.node and uiohook.dll (created in build) into your other project's node_modules\iohook\builds\node-v[WhateverVersionYouBuiltFor]-win32-x64\build\Release

@marcelblum getting closer... I moved those two files over and tried to re-run my project. ran into this error:

@bomeers sorry to disappoint but I haven't yet been able to get latest iohook 0.7.2 working with Node v.15 (ABI 88) on Windows. I think what @TheMrGong was saying is that in order to get iohook working in Node 15 he used older the iohook v0.6.6 codebase to build for a target of Node 15 and that worked (correct me if I'm wrong @TheMrGong). iohook switched to using node-gyp from cmake after v0.6.6 and while that brought benefits such as latest electron support, it also introduced issues with building for Node 14+ which remain unresolved.

@marcelblum That is correct, the build I made was with version 0.6.6.

@marcelblum @TheMrGong Very unfortunate. So I wouldn't be able to compile 0.6.6 the same way? (with the install tools for native modules)

@bomeers right, you'd need the old prereqs mentioned in those old docs you had linked to earlier to build from iohook v0.6.6 with cmake. Very sorry to lead you down a time wasting path, I thought you were trying to build the latest version.
Honestly this issue with Node 14+/iohook when built with node-gyp has gotta be something stupid simple. Just needs someone with the time & expertise to look into it. I was hoping to try to take a stab when I have some more time but I don't have as much of the expertise.

Any work on this? The documentation/GitHub doesn't mention it anywhere but in its current state the package is unusable for the current version of node

I was using the v0.6.6 that was avoiding this issue, but it seems this version has beedn removed from the latest release which breaks the install of this version :(

I tried to rebuild from the GIT repo with no change to the behavior after simply installing the latest version of the module.

Also, please review this PR https://github.com/wilix-team/iohook/pull/294 - it drop Node 8/9 supporting but previous versions of iohook can still work.

Is this still an issue or should I close?

No idea personally I decided to use gkm, although I think iohook would have been a cleaner solution, tomorrow I will try to test with a newer version of node to see if there is anything to report.

We, at LaunchMenu, too had this issue with iohook, and after messing around with node-gyp we decided to remake the package ourselves. We've created a package named node-global-key-listener. The application uses native low level hooks and pre-compiled binaries instead of relying on node-gyp or any other pre-installed dependencies. Currently the package only supports Windows and Mac operating system, but we'd be happy to get Linux support from someone in the know :) The package has gone through a short testing phase and is showing promise. You can read more about limitations in our readme. Hope it helps you out 👍

@sancarn Your contributions to this project are more than welcome of course. I think your project offers a unique take and would probably have less problems, especially for Mac I imagine.
I would say though there are no fundamental issues with node-gyp other than not wanting to increase your dependencies. It's better than relying on spawning directly. You may want to use a more concrete solution or use node C++ addon for the windows implementation instead of spawning.
Also, you can take a look at libuiohook for linux implementation, it's C so if you don't want to add it as dependency you can use just the x11 implementation in your project. It has its limitations of course but it would make the project usable cross-platform.

I would say though there are no fundamental issues with node-gyp other than not wanting to increase your dependencies.

Over the years I've used numerous packages which have used gyp, and they have always caused a nightmare whether it be in production or in development. Generally I tend to avoid gyp packages wherever I can because of the negative experience I've had with gyp. But you're right, there probably isn't any real problem with gyp especially if you know what you're doing :)
Thanks for libuiohook's implementation :) Will look into it. 👍

Any possible fix or update related to this issue, without downgrading node?

@denyncrawford I was able to get this functional on node v14 by using v0.6.6 of the library. It seems that versions past that (0.7.x) are broken.
gongo@Gonputer MINGW64 ~/workplace/tuya/test
$ npm add<EMAIL_ADDRESS>
[removed adding logging]

+<EMAIL_ADDRESS>
gongo@Gonputer MINGW64 ~/workplace/tuya/test
$ node index.js
refresh_locale_list [476]: GetKeyboardLayoutList(0, NULL) found 3 layouts.
refresh_locale_list [493]: Received 3 locales.
load_input_helper [866]: refresh_locale_list() found 3 locale(s).
[exits with no message]

gongo@Gonputer MINGW64 ~/workplace/tuya/test
$ npm remove iohook

gongo@Gonputer MINGW64 ~/workplace/tuya/test
$ npm remove iohook && npm add<EMAIL_ADDRESS>
[removed removal & adding logging]

removed 148 packages and audited 10 packages in 1.031s
+<EMAIL_ADDRESS>
gongo@Gonputer MINGW64 ~/workplace/tuya/test
$ node index.js
refresh_locale_list [476]: GetKeyboardLayoutList(0, NULL) found 3 layouts.
refresh_locale_list [493]: Received 3 locales.
load_input_helper [866]: refresh_locale_list() found 3 locale(s).
Connected to device!
Data received

gongo@Gonputer MINGW64 ~/workplace/tuya/test
$ node -v
v14.0.0

Can't get it to work with 0.6.6.
I get:  Prebuild for current platform (iohook-v0.6.6-electron-v87-win32-x64) not found!
With Node v14 and electron v12, my package.json looks like this:

  "devDependencies": {
    "electron": "^12.0.11",
    "electron-packager": "^15.2.0"
  },
  "dependencies": {
    "cmake-js": "^6.1.0",
    "iohook": "^0.6.6",
    "node-abi": "^2.30.0"
  },
  "iohook": {
    "targets": [
      "electron-87",
      "node-83"
    ],
    "platforms": [
      "win32"
    ],
    "arches": [
      "x64"
    ]
  }

Any idea what I'm doing wrong?

@miro-ux this thread is about an issue using iohook in just-plain-Node not Electron. Since you're using Electron, latest iohook 0.9.3 works fine in Electron 12 on Windows. iohook 0.6.6 predates Electron 12 so there is no older 0.6.6 prebuild targeting Electron 12.

@marcelblum You're right. Seems to be working great now with 0.9.3 and Electron 12. I was banging my head all day trying to make it work for Electron 13 or 14-beta. Thanks a lot!

@TheMrGong thank you os much! 0.6.6 works with  node 14

Any update on making new versions work with Node 14+?


Update travis badge link

To display the build status of the development branch properly the link has to be updated.

Coverage remained the same at 100.0% when pulling 7cb2f3c1a1c2a2cd224b637b81ee0ef1b10bd161 on travis_badge_link_update into e3e5cb113ae91fe6e27d943b8e97141f3326b338 on dev.


#3214. scroll bars in ambiance theme

looks good for table scrollbars and easyform list scrollbars, but:
this breaks the resize handle on easyform text areas.
instead of the diagonal lines i am just seeing a gray box,
and it becomes detached from the area:

also i forgot to mention it in the issue but can you please also apply this style to the scrollbars in the language manager:

is it possible to style the main scrollbar for the notebook, all the way on the right?
if so, please include it.

replaced with


Meade Command Wiki Parser

Script to parse the .cpp Meade header to wiki format

Absolutely, will fix!
On Sat, 12 Jun 2021 at 09:40, Lutz @.***> wrote:

@ClutchplateDude requested changes on this pull request.
In scripts/MeadeCommandParser.py
https://github.com/OpenAstroTech/OpenAstroTracker-Firmware/pull/116#discussion_r650360635
:

   for l in range(sub_start, sub_end):

       if content[l] == "//":

           continue

       # Command

       if content[l].startswith("// :"):

           command.command = remove_line_prefix(content[l])

       # Description

       if content[l].startswith("//      Description:"):

Can we change all these to be something like .startsWith("//") &&
.contains("Description:") ? We don't want to fail because of whitespace...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenAstroTech/OpenAstroTracker-Firmware/pull/116#pullrequestreview-682305481,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABV2PLQNU2ZEMTHQVOC44LTTSMFOBANCNFSM46R6AQRQ
.

--
Christian Kardach
Mjölnarvägen 24
131 31 Nacka, Sweden
Web: www.christiankardach.com
Cell: +46 (0)7305 29884


Bug 2178682: Add the valid AWS GovCloud regions

@bipuladh , @SanjalKatiyar Please review

/test odf-console-e2e-aws

/test odf-console-e2e-aws

/test odf-console-e2e-aws

/test odf-console-e2e-aws

/test odf-console-e2e-aws

/cherry-pick release-4.13-compatibility

once backport PRs are up (after this master PR is merged), add the BZ number to the title of both PRs and make sure both PRs are added to "Links" section of the BZ... after that we can move BZ to "POST" and need to ask for "qa_ack" on the BZ... once done we can merge the backport PRs and move BZ to MODIFIED...

/test odf-console-e2e-aws

/test odf-console-e2e-aws

/test odf-console-e2e-aws

/test odf-console-e2e-aws


Nuxt 3 caching with ISR/SWR does not work as expected on Netlify

Environment

Operating System: Linux
Node Version:     v18.16.0
Nuxt Version:     3.9.1
CLI Version:      3.10.0
Nitro Version:    2.8.1
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      ssr, routeRules
Runtime Modules:  -
Build Modules:    -

Reproduction
The issues described can be viewed on this deployment: https://extraordinary-zuccutto-58a082.netlify.app. Currently it is deployed without Nitro preset.
Describe the bug
I have a minimal Nuxt 3 app with different pages set up to use different rendering modes:
https://github.com/RisingStack/nuxt3-cashing-with-auth-clone
nuxt.config is as following:
export default defineNuxtConfig({

ssr: true,

routeRules: {

"/isr_ttl": { isr: 60 },

"/isr_no_ttl": { isr: true },

"/swr_ttl": { swr: 60 },

"/swr_no_ttl": { swr: true },

},

});

I use 2 timestamps to check whether caching works as expected: one comes from API response, another one is rendered in browser.
I tried deploying this app to Netlify with different nitro presets or without a preset at all and all of the deploys produce unexpected behaviour with at least some rendering modes. Please see the summary below:
NITRO_PRESET = netlify_builder
SSR: cached for at least 2 mins
SWR without TTL: cached permanently
SWR with TTL of 60 seconds: cached permanently
ISR without TTL: cached permanently
ISR with TTL of 60 seconds: cached permanently
Unexpected behaviour:
SSR (expected no caching),
SWR without TTL (expected to be cached until response changes),
SWR with TTL of 60 seconds (expected to be cached for 60 seconds),
ISR with TTL of 60 seconds (expected to be cached for 60 seconds),
NITRO_PRESET = netlify_edge
SSR: no caching
SWR without TTL: cached until response changes
SWR with TTL of 60 seconds: cached for 60 seconds
ISR without TTL: no caching
ISR with TTL of 60 seconds: no caching
Unexpected behaviour:
ISR without TTL (expected to be cached permanently),
ISR with TTL of 60 seconds (expected to be cached for 60 seconds),
NITRO_PRESET = netlify
SSR: no caching
SWR without TTL: cached permanently
SWR with TTL of 60 seconds: cached permanently
ISR without TTL: cached permanently
ISR with TTL of 60 seconds: cached permanently
Unexpected behaviour:
SWR without TTL (expected to be cached until response changes),
SWR with TTL of 60 seconds (expected to be cached for 60 seconds),
ISR with TTL of 60 seconds (expected to be cached for 60 seconds),
no NITRO_PRESET
SSR: no caching
SWR without TTL: cached permanently
SWR with TTL of 60 seconds: cached permanently
ISR without TTL: cached permanently
ISR with TTL of 60 seconds: cached for at least 2 mins
Unexpected behaviour:
SWR without TTL (expected to be cached until response changes),
SWR with TTL of 60 seconds (expected to be cached for 60 seconds),
ISR with TTL of 60 seconds (expected to be cached for 60 seconds),
I opened a topic in the Netlify forum: topic and they answered that this is a Nuxt issue, specifically "Nuxt would have to make sure that its presets are now following the Netlify’s cache control headers (which should work if they’re following the standard)".
Looking for clarification if there is any nitro preset which is expected to work with all rendering modes on Netlify or some clarification regarding to which preset supports which rendering mode.
Additional context
No response
Logs
No response

Bumping this as it's still an open issue and Netlify claims this is a Nuxt config issue.
Clarifications Team?

same here !

same here..

This is most likely something which has to be resolved in https://github.com/unjs/nitro

same here !

If you're still experiencing this, would you see if you can reproduce this in pure Nitro (reproduction sandbox), and if so, raise there? 🙏
If it only recurs with Nuxt, let me know and I'll reopen it here.

I am using the latest version of nuxt with the netlify_builder preset and isr is caching permanently, I have trigger a deployment to clear it...

@plexus77 see the comment above yours!

Hi ! any updates on this - we are experiencing this problem with all of our Sanity + Netlify  projects and it's terrible as right now we are using ISR and run a deploy task everytime we change content to regenerate the cache.
it's very easy to replicate the issue - just deploy on netlify a nuxt 3 application and the settings are not working.

See my comment above - can you try to reproduce with nitro alone and raise an issue there? 🙏

The sandbox has a minimal amount of code. You can clone it and use it to deploy to netlify yourself. Then add it to a GitHub repository and use that as the repro.

Not working on netlify ( https://nitrocachetest.netlify.app/test_swr_time ) => should refresh every 10 seconds but is not.
opened an issue on nitro github
https://github.com/unjs/nitro/issues/2617

Thank you! 🙏


autocomplete

In ide meeting notes I've noticed that complete feature is marked as completed. In my cases it more often doesn't work, I was under impression that it's in very early stage and there are lot of unsolved issues, thus I haven't been reporting a lot of use cases where it did not work for me. What is the status of this feature and what level of stability and coverage is expected?

There was a preface whcih I've forgot to copy that all rust-analyze features are assumed to be fast, but with incomlete langauge coverage, and all rls features are assumed to be slow, unless specifically marked otherwise.


Testng skips all test classes from suite

If you have two @BeforeClass in a test class and where second @BeforeClass depends on first one like this:
@BeforeClass
public void doLogin() {// Do Login}

@BeforeClass(dependsOnMethods = "doLogin")
public void logout() {// Do logout}

Then it will skip all the test classes from suite, if for any reason first @BeforeClass fails or throws exception.

Does alwaysRun not prevent this problem?

@priyanshus Could you share us a little project that show the issue?

@dbrusilovsky No it does not work with alwaysRun as well.
@juherr There is nothing special in my project, its just a testng suite which contains few test classes. One of test class has two @BeforeClass methods and second @BeforeClass depends on first one as I mentioned in my first comment.
If first @BeforeClass fails due to any reason then it skip all other test classes which are supposed to be run after failing class.

@priyanshus I can't reproduce your issue. Could you check my use case and tell me if I'm missing something?
@cbeust The *Invocation methods of IInvokedMethodListener are notified for "testA" which is never invoked. IMO it shouldn't. What do you think?

@juherr Please check my comment in use case of #739.

@priyanshus I've just updated the use case like your comment but it is working as expected. See 3d7de5c

@juherr
Please check my inline comment in 3d7de5c.

@priyanshus Reproducd and fixed in #742

Hi, i am also getting the same issue while using testng. Following is the structure:
Base Class having:
@BeforeClass
@BeforeMethod
@AfterClass
@AfterMethod
Test Class extends BaseClass having

@Test

can anyone help, Thanks !!!

@piyush-mehta Which TestNG version do you use?
BTW, could share a more complete example we are able to run?

Using testng 6.11, is this still an issue?

@mrunalimohane It should be fixed since 6.9.5

Seems like it worked all fine untill version 6.10. With 6.11 the issue has come back.

@mrunalimohane - Do you have a sample that can be used to recreate the problem ? That would be easier to start debugging.

Hello @krmahadevan @juherr
Using 6.11 Testng and any exception in BeforeClass skips the remaining test cases from other classes too.
Please check and let me know if you need more information regarding the issue.

@nirmitsrivastava - Please help do the following:

Retry the same scenario using the latest released version of TestNG ( 7.0.0-beta1 )
If the problem persists, please create a new issue and add a simple standalone sample that can be used to recreate the problem.


Bug in indentation

I recently added the feature to display the invisible characters (spaces) in my application, but when I create a new line, the indentation is not respected. It's done x5 or more.
In fact, there is an issue only when I make a new line in a script or style tag. The bug occurs even if showInvisibles is disabled.
But not in HTML structure. I let the picture tell you more.

I use the latest version of CodeMirror, 5.39.0

Here's a screenshot of what it looks like:

I think the issue is somewhere in the update.

I recently added the feature to display the invisible characters (spaces) in my application,

Seems like it would be useful to know how you implemented this.

I have loaded the show visible code after codemirror.js. Then I set the option show invisibles by editor.setOption("showInvisibles", true) and keep maxInvisibles: 16 as default.

Can you see that? I restored codemirror.js to version 5.36.0 while keeping the other files on 5.39.0 and oddly, it seems that the problem has disappeared.

There was a cache issue. Sorry and thanks ;-)

Hi,
I don't know why but the issue persists :-/

The issue is solved. I was just getting the tabSize and indentUnit as a string from cookies. It looks like they must be numbers, so I use Number().


Return None when parser Indonesia date string

Problem

Input : 6 Nop 2019
Output: return None

Nop should be added to the indonesiand data, as well as djan, peb, mrt....
Here the full list:
Jan./Djan. | Peb. | Mrt. | Apr. | Mei/Mai | Juni/Djuni | Juli/Djuli | Ag. | Sept. | Okt. | Nop. | Des.
@toixtran would you like to submit a PR?


Update to bento/ubuntu-16.04

This PR proposes to update the VMs from Ubuntu 14.04 (EOL) to the current LTS, Ubuntu 16.04.
In addition it switches to the bento repo because it is the one recommended by Vagrant (see https://www.vagrantup.com/docs/boxes.html). For me the most important part is Ubuntu 16.04, which repo is less important.

Hello?

Hi, @marco-m .  I appreciate the update!  I just merged another PR https://github.com/UtahDave/salt-vagrant-demo/pull/38  that in addition to some other functionality also updated to use the bento box.  Thanks for your PR.


[BUG | FEATURE] Shutting down the Server through "quit" results in a restart

txAdmin/FXServer versions:
v4.12.1
Describe the bug

When running ExecuteCommand("quit") inside a resource to shut down the server, txAdmin thinks the server has crashed.

Expected behavior

Either allow user to turn off the auto restarter, or add a shutdown event, so resources have the ability to shutdown the server - server sided.

This can only be solved through an API.
Please contribute to https://github.com/tabarra/txAdmin/issues/442


info chart loses legend when used with community components

[...]
Normally, we should get the following result (we are using Infochart as we have a requirement regarding the specific 2 Dimensions Category values display):
But, when it is used with Timeout 2.0 or UI5 2.0 component (even when the ‘Visible’ property is set to ‘false’), Category values are not displayed anymore on the Infochart

found, one Number method was overwritten by OS component


hrpsys: 315.7.0-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository hrpsys to 315.7.0-0:

upstream repository: https://github.com/fkanehiro/hrpsys-base.git
release repository: https://github.com/tork-a/hrpsys-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.20
previous version for package: 315.6.0-0

hrpsys

No changes

closing for #9244


recipient () does not refer to any valid address => adding liquidity mining

I got also the same issue! At "DEX" where you  from DFI to BTC for liquidity mining it shows that my valid adress doesn't fit.
Would be nice getting any help!

Can you please provide a full screenshot of the app? Have you selected an address in the process before?

If you can't select any address, create a new one:

Go to Wallets
Click DFI
Click "Receive" on the upper right corner
Click "New Address" on the upper right corner
Give your address a describing name like "Liquidity Mining RCV"
Click "Create" on the lower right corner

Can you please provide a full screenshot of the app? Have you selected an address in the process before?

If you can't select any address, create a new one:

Go to Wallets
Click DFI
Click "Receive" on the upper right corner
Click "New Address" on the upper right corner
Give your address a describing name like "Liquidity Mining RCV"
Click "Create" on the lower right corner

Hi @Zhenja90 , thanks for your feedback, regarding the issue Add LP: recipient () does not refer to any valid address, if what @maaze19 suggested did not work, please proceed to https://github.com/DeFiCh/app/issues/314 which we can further discuss on the problem. We would like to keep same issues in one thread. Thank you.

Hi @Zhenja90 , thanks for your feedback, regarding the issue Add LP: recipient () does not refer to any valid address, if what @maaze19 suggested did not work, please proceed to https://github.com/DeFiCh/app/issues/314 which we can further discuss on the problem. We would like to keep same issues in one thread. Thank you.

Thanks a lot for your Suggestion managing the issue. ASAP I’ll go through the points to solve the problem. Cheers !

Thanks a lot for your Suggestion managing the issue. ASAP I’ll go through the points to solve the problem. Cheers !


refactor(plugin-odap-gateway): refactor implementation including more tests

Refactor first implementation #1275

Rename plugin file from odap-gateway to plugin-odap-gateway.
Refactor SendClientRequest() 600 lines method into different methods according to the ODAP phase and each message type.
Refactor methods that make digital signatures and respective verification.
Added tests and actual verification regarding the state of the objects.
Added fields in the open API file according to the specification in the ODAP draft.
Added checks in every step of the protocol according to the messages exchanged

cc @RafaelAPB
Signed-off-by: André Augusto<EMAIL_ADDRESS>

@AndreAugusto11 It is good for me, but would you add an issue corresponding to this pull-request? (I'm afraid that this is a formal indication.)
I think the content should be based on your following description, so please make it referring to past issues.

Rename plugin file from odap-gateway to plugin-odap-gateway.
Refactor SendClientRequest() 600 lines method into different methods according to the ODAP phase and each message type.
Refactor methods that make digital signatures and respective verification.
Added tests and actual verification regarding the state of the objects.
Added fields in the open API file according to the specification in the ODAP draft.
Added checks in every step of the protocol according to the messages exchanged

@petermetz the ci fails, looks something related to the fabric test ledger? https://github.com/hyperledger/cactus/runs/5470188361?check_suite_focus=true#step:8:22867

It also throws an error when running the odap-api-call.test.ts, and there are no tests found in that file, don't know why.
https://github.com/hyperledger/cactus/runs/5470188361?check_suite_focus=true#step:8:35844

@RafaelAPB @AndreAugusto11
There may be something I did not merge from my evaluation branch
Could you try adding
  public fabricAssetSize?: string;
in the OdapGatewayConstructorOptions
and
if (!options.fabricAssetSize) {     this.fabricAssetSize = "1"; } else {   this.fabricAssetSize = options.fabricAssetSize; }
in the odap gateway constructor
To see if it fix the problem
sorry, I should create a pr recently, but kind of busy doing school coursework and RA

@AndreAugusto11 the test passes locally with JEST. Perhaps the test runner is using TAP. Could you double check that the test runner that runs that test is JEST?

@jscode017 thank you for the suggestion.

@RafaelAPB I think you're right, all the tests using Jest have passed and then in line 35748 it initiates TAP version 13. Afterwards, the test fails. I already removed this test from the jest.config.js file. Any suggestion why it is being ignored by Jest?

@RafaelAPB @AndreAugusto11 There may be something I did not merge from my evaluation branch Could you try adding  public fabricAssetSize?: string; in the OdapGatewayConstructorOptions and if (!options.fabricAssetSize) { this.fabricAssetSize = "1"; } else { this.fabricAssetSize = options.fabricAssetSize; } in the odap gateway constructor and change this from number to string like: https://github.com/jscode017/cactus/blob/552a5b0801896b2894f678fc8c9414496bbd12ca/packages/cactus-plugin-odap-hermes/src/main/json/openapi.json#L433 To see if it fix the problem sorry, I should create a pr recently, but kind of busy doing school coursework and RA

@AndreAugusto11 If you can confirm that these changes were made as well then we are good to go from my side, just let me know explicitly please, I wasn't sure if the thumbs up on Jason's comment was meant to imply that or not. :-)

@AndreAugusto11 If you can confirm that these changes were made as well then we are good to go from my side, just let me know explicitly please, I wasn't sure if the thumbs up on Jason's comment was meant to imply that or not. :-)
Hey @petermetz, my bad, I already made those changes. I've just also updated the docs of the package and rebased, so it is ready to merge into main once the ci is complete.

LGMT too :)

@petermetz Done :)

@AndreAugusto11 I just noticed that the commit message is pretty much empty compared to the PR description. Next time please include the same information in the commit message.

@petermetz you're right, I could've added more information to the commit message as well. I'm sorry for that, I'll take it into account the next time.

@AndreAugusto11 No worries at all, I try not to nit pick on everything every single time (even if that's hard to believe haha). Thanks for your understanding! :-)


[ODS-5370] Support PS 7.2 and Unix - Script group 1

Made some changes in order to support Unix. Other files in the script group were modified only if needed by scripts in the script group.

replaced all paths with forward slashes for unix
add functions for testing for and Installing SqlPackage in ToolsHelper.psm1
use new Test-SqlPackage function for unix systems in create-database-bacpac.psm1
in nuget-helper.psm1

fix adding to path for unix
add double quotes for unix pathing
Use mono on Unix to run nuget.exe

only check for blocked files on Windows in Initialize-PowershellForDevelopment.psm1
add Pester tests for

path-resolver.psm1
plugin-source.psm1
hashtable.psm1 (fixed)

All other files have been imported with no errors at the very least.

fixed part of my tests that were removing the Application directory and probably breaking all the other tests


Update CustomFunction to allow optional parameters

I am away for the weekend.  I may be able to take a look before I leave,
but I will for sure take a look Monday.  But certainly all tests must pass.
Bruce
On Thu, May 13, 2021 at 12:47 PM Alexander Kiryukhin <
@.***> wrote:

@neonxp https://github.com/neonxp requested your review on: #87
https://github.com/neonxp/MathExecutor/pull/87 Update CustomFunction to
allow optional parameters.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/neonxp/MathExecutor/pull/87#event-4742845991, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYW6SZ5B5WCLGJFC3BKDDTTNP7BZANCNFSM442LG7DQ
.

@alfaalex81,
Unfortunately I am going to have to reject this pull request. While I think it would be a good feature to have optional parameters on a function call, there is a bit more work that needs to be done to make this works correctly. And since I don't require this for my work, I am not interested in debugging it, but I will leave you with these comments in hope that you will work out all the issues and resubmit a PR.
First, all unit tests must run with no errors.  Looks like you are new to github, so welcome!  But you need to do a "composer install" followed by a "vendor/bin/phpunit" (reverse slashes for Windows) and that must run with no errors.
Second, additional unit tests (in tests directory) need to be added to insure the change works as expected.  I would create a function that takes multiple default arguments. I would multiply the first parameter by 10, then subtract the second parameter, and then repeat this pattern many times.  This will be a good test as it will insure you get the ordering of parameters correct.  And make sure to use parameters that insure the correct answer is returned without question.  Also add a test that will obviously fail.
And words to the wise: parsing can get complex, but if you have to add a lot of code into the parser to get this to work, you are probably doing it wrong and there should be a simpler solution.  I tried to do this once before in the old parser, but it got messy quickly.
As always, should you or any of your IM Force be caught or killed, the Secretary will disavow any knowledge of your actions.


Image in /Guides/debugging-guide

Submit an issue
Topic
This is an issue regarding:

[x] The guides contained within this repo.

Description of the issue
Given the placement of /images/readme-assets/reload-plugins.png, perhaps it should show a plugin loading error?

Agreed with Ash. @ErinFinnegan could you replace the image with an actual error being logged please?


Scenario Editor Sending Duplicate Values to Reasoner

The scenario editor is taking data from the /onto endpoint for a test, displaying it to the user, allowing the user to specify more facts, and then it is sending both the user facts and the ontology facts back to the server.
This seems to be, in some circumstances, creating additional explanations for answers. I don't understand the mechanism by which that is happening, but removing the ontology facts from the JSON payload eliminates the redundant explanations.
We need to have the scenario editor pre-process the data packet so that it doesn't send information that it received from the code.

This is specifically visible if you use the Rock Paper Scissors example, and recreate the bobjane test, and then grab the JSON payload by using JSON.stringify(fact_data), and run it in the /run endpoint for the who_wins test, with and without the detail about signs in the payload.


Python Syntax error

I'm running an upto date LinuxMint system.  I'm having issues running the following:
staticmem@asrock:~/Builds_64/Greaseweazle-0.7/scripts
$ python gw.py read --ecyl=39 --single-sided mydisk.scp /dev/ttyACM0
File "gw.py", line 20
print("Actions: ", end="")
^
SyntaxError: invalid syntax
I don't have pip3 on this computer but have: pip, pip2 and pip2.7.
sudo apt install python3
python3 is already the newest version (3.6.7-1~18.04)
sudo pip3 install crcmod pyserial
env: ‘pip3’: No such file or directory
From what I read pip3 is only provided in customised versions of python3?
Is this pip3 issue the problem or something else?

The answer in the link solved the pip3 problem:
https://superuser.com/questions/769920/python3-pip-installed-but-pip3-command-not-found
But still having issues:
sudo pip3 install crcmod pyserial
The directory '/home/staticmem/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/home/staticmem/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Requirement already satisfied: crcmod in /usr/local/lib/python3.6/dist-packages
Requirement already satisfied: pyserial in /usr/local/lib/python3.6/dist-packages
I have no idea what the actual problem is.

The original syntax error is because you need to run python3: eg python3 gw.py read ....
The pip3 error is something to do with file/folder ownership checks and it doesn't like root (superuser) trying to write into your home directory. Try pip3 install crcmod pyserial or pip3 install --user crcmod pyserial

I tried both those pip3 install lines and but appear to fail...
pip3 install --user crcmod pyserial
Collecting crcmod
Using cached https://files.pythonhosted.org/packages/6b/b0/e595ce2a2527e169c3bcd6c33d2473c1918e0b7f6826a043ca1245dd4e5b/crcmod-1.7.tar.gz
Collecting pyserial
Using cached https://files.pythonhosted.org/packages/0d/e4/2a744dd9e3be04a0c0907414e2a01a7c88bb3915cbe3c8cc06e209f59c30/pyserial-3.4-py2.py3-none-any.whl
Building wheels for collected packages: crcmod
Running setup.py bdist_wheel for crcmod ... error
Complete output from command /usr/bin/python3 -u -c "import setuptools, tokenize;file='/tmp/pip-build-imoji3re/crcmod/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" bdist_wheel -d /tmp/tmpuqr2hmrepip-wheel- --python-tag cp36:
usage: -c [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: -c --help [cmd1 cmd2 ...]
or: -c --help-commands
or: -c cmd --help
error: invalid command 'bdist_wheel'

Failed building wheel for crcmod
Running setup.py clean for crcmod
Failed to build crcmod
Installing collected packages: crcmod, pyserial
Running setup.py install for crcmod ... done
Successfully installed crcmod-1.7 pyserial-3.4
I also tried running the GW script using python3 instead of python.
python3 gw.py read --ecyl=39 --single-sided mydisk.scp /dev/ttyACM0
Traceback (most recent call last):
File "gw.py", line 24, in
mod = importlib.import_module('greaseweazle.tools.' + argv[1])
File "/usr/lib/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 665, in _load_unlocked
File "", line 678, in exec_module
File "", line 219, in _call_with_frames_removed
File "/home/staticmem/Builds_64/Greaseweazle-0.7/scripts/greaseweazle/tools/read.py", line 12, in
from greaseweazle.tools import util
File "/home/staticmem/Builds_64/Greaseweazle-0.7/scripts/greaseweazle/tools/util.py", line 12, in
from greaseweazle import version
ImportError: cannot import name 'version'
$ ls -l ~/.cache/pip/
total 8
drwx------ 7 staticmem staticmem 4096 Dec 23 18:20 http
drwxrwxr-x 3 staticmem staticmem 4096 Dec 23 18:20 wheels
Do I need a "wheels" group?  I don't see it in /etc/group.

This new pip3 install error is not one I've seen before. A quick Google suggests you need pip3 install wheel or perhaps pip3 install --user wheel.
The python3 error is apparently a missing file version.py. It is distributed with Greaseweazle but I did forget to include it in at least one release! So re-download latest Greaseweazle and try again.

I tried those other pip3 install commands and they report error messages.
The version.py is in the 0.7 release already.
I think my Python installation has become a complete mess.  I recall having issues with it once before.  Asking apt to remove it (so that I could re-installl from fresh) it gave me a severe warning that this may break the system.
I've tried deleting files and reinstalling various packages including the home account area but nothing I do makes it work.  I'm guessing there is some version conflict problem happening.

This seems to work as long as not run with "sudo":
pip3 install crcmod pyserial
Collecting crcmod
Collecting pyserial
Using cached https://files.pythonhosted.org/packages/0d/e4/2a744dd9e3be04a0c0907414e2a01a7c88bb3915cbe3c8cc06e209f59c30/pyserial-3.4-py2.py3-none-any.whl
Installing collected packages: crcmod, pyserial
Successfully installed crcmod-1.7 pyserial-3.4

I read in various sites never to use "sudo" with "pip"
https://itsfoss.com/python-setup-linux/
See: Big Caveat
So as a last ditch effort I wondered if I could reverse the damage so I ran these as "sudo" to uninstall
sudo pip3 uninstall crcmod
sudo pip3 uninstall pyserial
I had to repeat the commands a few times as it deleted files in root area and the home account.  I kept to doing it until it could not find any other installed files.
Then I ran the pip3 install line again but as a normal user.
pip3 install crcmod pyserial
staticmem@asrock:~/Builds_64/Greaseweazle-0.7/Greaseweazle-v0.7/scripts
$ python3 ./gw.py read mydisk.scp /dev/ttyACM0
** Greaseweazle v0.7 [F1], Host Tools v0.7
Reading Track 0.0...Command Failed: Track 0 not found
Bluepill not connected not connected to a drive yet but at least that looks promising now.
@Keirf:  I know very little about Python but maybe you need to remove the "sudo" from the "pip3" install commands?

Ok that looks good! I think you're right, and actually non-root pip install automatically gets converted to pip install --user which is safe and won't mess with your system-wide Python installation. I will look into converting the recommended command lines.

Fixed. Thanks for the feedback.


Replace Mermaid

Most of the issues related to this repository have been related to getting mermaid cli to generate a file. Variables that I've noticed so far are

Operating System

#2
#65
#27

file length

#49

Docker

#28

node module mapping

#29

There are also ideas for extension such as

Large schema(s) not filling space in a smart way
Limited color schemes

This issue is to discuss what we would need out of a replacement. If there is enough interest maybe we could get this started

Also #104

We've seen a considerable amount of disk space occupied bij the installed npm package of Mermaid cli.
Confusing is they expect to have puppeteer installed also (why isn't this in mentioned in their .npmignore)?
[Our project]
└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
ivo@Ivos-MBP vecore-database-schema %

A scan by GrandPerspective:

I did the first try using Graphviz instead of mermaid and this is the result:

The lines don't look as clear as with mermaid but in my opinion, it looks nicer now.
The only thing is that the relationship labels may sometimes look cluttered next to some primary keys like in the User table.
I will continue working on it and submit a PR.

@cjoecker Share a PR. I think it looks way better already. Would be interested to see how it handles the huge schema's in the test cases in the repo.

#129 special character limitation. Overlap with a regex problem but when I fix it it will cause failures at the mermaid mmdc step

Mermiad has a big advantage, generated diagrams could be embedded to markdown files and github, for example, could render them. So I think it worth not to "replace" but maybe add some alternative.
Maybe it could be done by creating some kinda plugins. The main module will be responsible for parsing prisma schema and returning some structure that could be later transform to graph.
And mermaid, graphvis or any other visualization plugin will be responsible for visualizing structure from main module.

@keonik I created a draft PR with the proof of concept for Graphviz. Let me know what you think so that I can start the refactoring, tests fix etc.
@SkeLLLa you have a good point about the embedded diagrams in the markdown files I haven't thought about. Diagrams can also be embedded and rendered as SVG files. So, whenever the schema is generated, the old SVG will be replaced and the markdown files are updated automatically 👏🏻

@keonik did you see the pull request? What do you think?

@keonik did you see the pull request? What do you think?

I gave it a shot running locally and had a few TypeScript errors and missing imports that hung up a successful test. It says its missing generate_old.ts which has some of the DML types. I'm happy to support Graphviz but some people are big fans of mermaid still. Makes me think providing a configuration option to pick between Graphviz and Mermaid is in order. One of the big complaints against mermaid is that we need to run a cli to generate the file if it isn't in markdown format. This is still in need of running a cli command so it doesn't rule out one of the common OS and versioning issues people are currently running into.

@keonik I just pushed the missing file.
It is also ok for me to have mermaid and graphviz together. This PR was just a try to see if it works. I can now do a cleaner for that.
For implementing a final solution, It would be great if we have a function that gives us back the data in the following structure:
export interface TemplateValues {
    tables: Table[];
    relationships: Relationship[];
}

export interface Table {
    name: string;
    fields: {
        name: string;
        primaryKey: string;
    }[];
}

export interface Relationship {
    fromTableName: string;
    fromFieldIndex: number;
    fromRelationshipType: '1' | '*';
    toTableName: string;
    toFieldIndex: number;
    toRelationshipType: '1' | '*';
}

Then it would be easier to use different engines to generate the graphic.
What do you think about joining efforts for that? You can refactor the library to make it more modular and deliver that data structure. Then, I can implement the Graphviz generation.

@cjoecker What are your thoughts on having separate branches for these representations 🤔
I just recently setup the ability to push to alpha and bravo branches that create future implementations for testing ease. I could just as easily add a graphviz branch and you would just change the install to something like this
npm i -D prisma-erd-generator@graphviz

@keonik separate branches are a good alternative. I just ask myself if it wouldn't be better to add it just as a prop in the configuration of the plugin. It is more user-friendly in my opinion. Also, if the objects and logic to produce the diagrams is clean as mentioned here, it would be super easy to use different rendering engines based on the settings props. But I struggled a bit to transform the current logic to graphviz because it was a lot of strings concatenation that was difficult to understand for me.


I need RTSP server for the android (Just Server)

Hello, first of all, congratulations for your project. It is really exciting. I am developing an Android project. I want to redirect the video I play with VLC player to a server on the device with FFMPEG and watch it from the VLC player on another android device. For this, I need an RTSP server on my first device. My goal is to send the video I am watching to rtsp://<IP_ADDRESS>:8554 on my first device and watch this video on my second device by entering the ip address of the first device. I have been trying various servers on Github for a long time. In general, the servers either require a surface or codec information. I copy the codec of the video I watch with FFMPEG and send it. The code I use for this is "-re -i "+url+" -vcodec copy -an -f rtsp rtsp://<IP_ADDRESS>:8554". how can I integrate the server you use into my own project? Thank you.

Thank you for interest in my project. That repository has android version for server/client:. If we talk about this repo, that i should say it can receive only I-frames, without P-frames and B-frames. That's mean your vlc player on android must send only I-frame. In my project i need it for excelent quality of capture, because P and B frames spend some quality. You will may have Problems with lags, if you dont have fasten-fast)))) Wi-Fi or mobile network(5g). My project goal it is work for 5generation of mobile network and i sometimes have lags too(((. Project in progress... Soon i go on udp Protocol.
What i want to advice you: In addition to the server, you nead client on your Server that will receive frame. For instance, one laptop includes one app, one app includes One client for receiving and one server for sending. In repo it is. If you want to use this project like server vlc, you have to think how process p-frames and b-frames. Or, you can off P and B frames on android vlc. As I did in the repository at the link above.^
For you [attach link on the video where you can see operator side.] (https://disk.yandex.ru/i/aHr0bKp68X73ww)  on russian.
Answer your question: you need IntelliJ idea for example. Jdk 1.7, it seems and gradle 7.2. I'll look tomorrow in the project settings and in gradle and write in the readme how to run it.
Hope, you can make it.


remove racey checks on what should be idempotent calls

We're accessing shared state between a Subscriber and a Subscription which indicates if the Subscriber has completed yet; another thread calling cancel() on this Subscription will crash if the StreamRequester thinks it's already in a closed state.
We shouldn't be making this check at all, as we can't assume any ordering guarantees on calls made across Subscriber/Subscription.

... another thread calling cancel() on this Subscription will crash ...

The stream state machines should all be accessed from the same thread.  But I agree that we shouldn't do this check in request(), as for all we know, the EventBase just processed an onComplete() right before scheduling a request().


Annotation on top-level terms and implicit generalization of types

For a long time, we have discussed enforcing a discipline that all top-level terms must be annotated with types. @msprotz et al have argued, and many of us agree, that this will increase readability, maintainability etc.
But, we have yet to bite the bullet and enforce this in the type checker.
Should we do it now?
Aside from the original argument of improving documentation, insisting on top-level annotations will allow us to delete a big, complicated chunk of code related to implicit (ML-style) generalization of types.
At the moment, the only place we do type generalization is on top-level definitions. If all of these are to be annotated, then we can just drop generalization altogether.
Generalization is particularly tricky since it involves temporarily breaking an important invariant of F*, namely that unification variables are only ever unified with closed terms. It also produces terms whose shape after elaboration is unusual, leading to unexpected outcomes in various parts of the compiler, e.g, in the SMT encoding, manifesting itself in issues like #1219.
What do you think?

I am in principle all for enforcing annotating top-level terms. The main drawback I see is that it will further distance F* from OCaml/F# where this is not enforced, and thus it will be harder to tout F* as a lightweight verification-oriented language where you can verify as little or as much as you wish.
The immediate, less concerning, drawback is that adding annotations to all existing code that doesn't have them will be tedious. But I assume we could rig up a script that adds (ugly) inferred annotations using the existing generalization mechanism, and gradually replace them by manual annotations.
There is still some generalization happening for universes, right? I'd be against having to annotate universe variables explicitly.

When writing pure Tot specifications in HACL*, we often like to write definitions without declarations, because:
(a) often, there is not much we have to add in the type declaration
(b) smaller specs are easier to read.
I would not want to declare top-level types in these files.

On 11 Sep 2017, at 11:18, Santiago Zanella-Beguelin<EMAIL_ADDRESS>wrote:
I am in principle all for enforcing annotating top-level terms. The main drawback I see is that it will further distance F* from OCaml/F# where this is not enforced, and thus it will be harder to tout F* as a lightweight verification-oriented language where you can verify as little or as much as you wish.
The immediate, less concerning, drawback is that adding annotations to all existing code that doesn't have them will be tedious. But I assume we could rig up a script that adds (ugly) inferred annotations using the existing generalization mechanism, and gradually replace them by manual annotations.
There is still some generalization happening for universes, right? I'd be against having to annotate universe variables explicitly.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/FStarLang/FStar/issues/1229#issuecomment-328470670, or mute the thread https://github.com/notifications/unsubscribe-auth/AEtKy8YObr2eh-OuTLOvKnTO4OXGyZSJks5shPrYgaJpZM4PR-_S.

I have mixed feelings about this. I'd be curious to see how many definitions we have in the stdlib without annotations, to gauge the usefulness of the current implementation.
I think a good first step would be to require annotations for all but Tot: that is, never allow this:
open FStar.Exn
open FStar.All

type filename = string

let canWrite (f:filename) =
  match f with
    | "demo/tempfile" -> true
    | _ -> false

let canRead (f:filename) =
  canWrite f               (* writeable files are also readable *)
  || f="demo/README"       (* and so is demo/README *)

val read  : f:filename{canRead f}  -> ML string
let read f  = FStar.IO.print_string ("Dummy read of file " ^ f ^ "\n"); f

val write : f:filename{canWrite f} -> string -> ML unit
let write f s = FStar.IO.print_string ("Dummy write of string " ^ s ^ " to file " ^ f ^ "\n")

let passwd : filename = "demo/password"
let readme : filename = "demo/README"
let tmp    : filename = "demo/tempfile"

// *** Commenting this out causes all sort of issues *** val staticChecking : unit -> ML unit
let staticChecking () =
  let v1 = read tmp in
  let v2 = read readme in
  let v3 = read passwd in // invalid read, but this passes type-checking
  write tmp "hello!"

Clarifying what I said above: I mean that the last function there should fail with "this isn't Tot, please annotate". But a pure, Tot function shouldn't need annotations.

We discussed this in today's F* meeting and the proposal is to disable automatic generalization and allow underscores in WP position. Not everybody seemed happy with disabling automatic generalization, so let's discuss that here.
I for one welcome our new generalization free overlords. It's what Coq and other dependently typed systems do already.

This seems reasonable to me...
Can we make sure that the fully-annotated let-style doesn't require a val? E.g.
let f (x: int): Stack unit _ _ =
  ...

@msprotz From what we discussed a let without a val would indeed be fine. It could look something like this:
let f x = STACK _ _ = ...

That is, the type of x doesn't have to be written (it's implicitly x:_) and we only allow WPs to be underscored, not pre- and post- conditions. The latter should make it clearer that for a inferred WP the precondition doesn't have to be satisfiable, while if you write Stack unit _ _ we think people are more likely to be confused when F* infers the precondition fun _ -> False.

thus it will be harder to tout F* as a lightweight verification-oriented language where you can verify as little or as much as you wish.

Annotating top-level terms with types significantly improves readability, and is a very small burden on the user - there's a case to be made that enforcing this in OCaml/F# would be an improvement there as well. When searching for functions in ulib/, top-level type annotations are invaluable. Enforcing this would also open the door to having something similar to  hoogle/ocaml-hoogle/FSDN for F*.

Annotating top-level terms with types significantly improves readability

I'm not too sure about this. Type annotations are often good when they are non-obvious, but often they are pretty obvious and they just make the code more burdensome to read.  It's easy to extend the IDE to print appropriate type info, in any case.
I guess I'm not a fan of systematically mixing human-supplied information (code) with information that could be rebuilt from it (types).  And requiring annotations on everything is a significant burden on the writer for quick experimentation, I feel.
I like the way Haskell does it: annotations are not mandatory, but you get linter warnings when they are missing.  I'd be fine with an F* linter complaining about missing annotations.
I'm all for mandatory effect annotations for non-Tot things, which I think we all agree on.

When searching for functions in ulib/, top-level type annotations are invaluable.

 I'd like to see what we can do on the IDE side to help :)

Enforcing this would also open the door to having something similar to hoogle/ocaml-hoogle/FSDN for F*.

I don't think I understand :/ Don't Hoogle and ocaml-hoogle work without type annotations?

Clément, I think your point is valid but assumes that everyone has a working emacs-mode and the very latest version (i.e., your setup).
For beginners who don't master the Emacs mode, people just skimming the code to get familiar with its structure, signatures still represent very valuable information. For me, annotations help with navigating an unfamiliar codebase, while the Emacs mode and type-under-the-cursor help when actually hacking on an existing codebase. (I use Emacs when hacking on existing proofs, naturally.)
Perhaps there's a difference of scale, between a one-file example, and a super-large project like miTLS where there's 20 modules open in every scope, dozens of files, and where every argument called id is not type-annotated...?

For beginners who don't master the Emacs mode, people just skimming the code to get familiar with its structure, signatures still represent very valuable information.

Beyond even editors, sometimes I just want to look at the ulib/ sources on github.
Beginners probably don't have the emacs mode set up, and may not even have F* installed. I think beginners will want to play around with the online tutorial editor for a while before installing F*, and given the current state of online documentation, having easily searchable source code is important.

 I'd like to see what we can do on the IDE side to help :)
suppose I'm looking for a function like FStar.Classical.forall_intro_squash_gtot_join, defined as

val forall_intro_squash_gtot_join  : #a:Type -> #p:(a -> GTot Type) -> $f:(x:a -> GTot (squash (p x))) -> Tot (forall (x:a). p x)
let forall_intro_squash_gtot_join #a #p $f =
  join_squash
    (bind_squash #(x:a -> GTot (p x)) #(forall (x:a). p x)
	      (squash_double_arrow #a #p (return_squash f))
	      (fun f -> lemma_forall_intro_gtot #a #p f))

The signature is probably all that I'm interested in, the actual implementation is not so helpful.

I don't think I understand :/ Don't Hoogle and ocaml-hoogle work without type annotations?
Yes, although I would guess that enforced top-level type annotations would probably make implementing something similar a little easier.

Beyond even editors, sometimes I just want to look at the ulib/ sources on github.

That one's tricky.

Beginners probably don't have the emacs mode set up, and may not even have F* installed. I think beginners will want to play around with the online tutorial editor for a while before installing F*, and given the current state of online documentation, having easily searchable source code is important.

That one is easy: we can / should generate docs with full signature information.

suppose I'm looking for a function like FStar.Classical.forall_intro_squash_gtot_join, defined as

Fair enough, but don't you look for these in interfaces? In that case, don't you already get annotations (and only those)?

For beginners who don't master the Emacs mode, people just skimming the code to get familiar with its structure, signatures still represent very valuable information. For me, annotations help with navigating an unfamiliar codebase, while the Emacs mode and type-under-the-cursor help when actually hacking on an existing codebase. (I use Emacs when hacking on existing proofs, naturally.)

That's fair too, but I'd expect you to browse the fstis when you jump into a new codebase, right?


ng2-select not working after upgrade to Angular 8

Hi
I have upgraded the angular version from 2 to 8 in my project. The ng2-select has stopped working after the upgrade and it just hangs the page once I access the component where ng2-select is used. I have even tried ng2-select-compat, but I am getting the same issue. Can you please help me on this?
Thanks

Hi,
I am merging two apps Angular 5 and Angular 8.  I added the modules from the Angular 5 app into the Angular 8 app.  The Angular 5 app was using ng2-select.   Those select components still function in Angular 8.1.  I'm having css issues, but the  components are working.
You might want to confirm that you are importing the SelectModule from ng2-select in your relevant module.

ERROR in node_modules/ng2-select/select/select.d.ts.SelectComponent.html(20,129): Property 'removeClick' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(12,11): Property 'matchClick' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(37,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(41,20): Property 'inputValue' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(38,16): Property 'selectActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(39,16): Property 'selectMatch' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(58,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(55,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(60,20): Property 'inputValue' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(56,16): Property 'selectActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(57,16): Property 'selectMatch' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(9,10): Property 'inputMode' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(30,12): Property 'inputMode' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(33,10): Property 'optionsOpened' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(47,11): Property 'optionsOpened' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(4,6): Property 'mainClick' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(82,19): Property 'removeClick' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(104,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(108,20): Property 'inputValue' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(105,16): Property 'selectActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(106,16): Property 'selectMatch' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(125,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(122,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(127,20): Property 'inputValue' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(123,16): Property 'selectActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(124,16): Property 'selectMatch' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(100,10): Property 'optionsOpened' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(114,11): Property 'optionsOpened' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(69,6): Property 'mainClick' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(70,6): Property 'focusToInput' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(90,12): Property 'matchClick' is protected and only accessible within class 'SelectComponent' and its subclasses.

ERROR in node_modules/ng2-select/select/select.d.ts.SelectComponent.html(20,129): Property 'removeClick' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(12,11): Property 'matchClick' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(37,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(41,20): Property 'inputValue' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(38,16): Property 'selectActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(39,16): Property 'selectMatch' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(58,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(55,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(60,20): Property 'inputValue' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(56,16): Property 'selectActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(57,16): Property 'selectMatch' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(9,10): Property 'inputMode' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(30,12): Property 'inputMode' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(33,10): Property 'optionsOpened' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(47,11): Property 'optionsOpened' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(4,6): Property 'mainClick' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(82,19): Property 'removeClick' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(104,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(108,20): Property 'inputValue' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(105,16): Property 'selectActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(106,16): Property 'selectMatch' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(125,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(122,16): Property 'isActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(127,20): Property 'inputValue' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(123,16): Property 'selectActive' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(124,16): Property 'selectMatch' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(100,10): Property 'optionsOpened' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(114,11): Property 'optionsOpened' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(69,6): Property 'mainClick' is protected and only accessible within class 'SelectComponent' and its subclasses. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(70,6): Property 'focusToInput' is private and only accessible within class 'SelectComponent'. node_modules/ng2-select/select/select.d.ts.SelectComponent.html(90,12): Property 'matchClick' is protected and only accessible within class 'SelectComponent' and its subclasses.

same problem here

I would bet this has something to do with fullTemplateTypeCheck being turned on, not so much Angular 8

Setting fullTemplateTypeCheck to false in our app's tsconfig.json file solved this problem for us, while we were upgrading from Angular 7 to Angular 8.  Thank you for the suggestion.

ng2-select is not supported in angular version 12.please provide alternet solution or how to resolve this problem.


Format of parameter objects is fairly unclear

Hey all,
I'm new to Elasticsearch in general, so I've been trying to go over the docs quite a bit in order to figure things out. One particular pain point I've noticed is that some API definitions give very little information on what the requests bodies should look like. In particular, the one I just ran into is here: https://opendistro.github.io/for-elasticsearch-docs/docs/elasticsearch/rest-api-reference/#indicescreate
While this gives me the name of the keys I need to send in my body, there's no explanation on what they should look like. I've tried looking around the docs for somewhere else that mentions this info but haven't found it (but even if it is there, a link or something to it would be appreciated, so that I can easily find out what's going on there).
The other case where I ran into this was on bulk data adding (https://opendistro.github.io/for-elasticsearch-docs/docs/elasticsearch/rest-api-reference/#bulk) but I was able to find an example from the "Popular APIs" page (https://opendistro.github.io/for-elasticsearch-docs/docs/elasticsearch/popular-api/#index-several-documents-at-once) -- again, some sort of link to that to describe what the body should look like would be helpful. As someone new to the service, the description of "action-data pairs" isn't particularly helpful, since I don't know what the format should be.
Hopefully that makes sense and is useful feedback.

Agreed 100%. We're working (slowly) on a full REST API reference over here: https://github.com/opensearch-project/documentation-website/, so I'm going to close this out.