discussion: revisit dom.event.contextmenu.enable

dom.event.contextmenu.enable, currently under 2200 UI Meddling. Issue created because someone else queried it - so lets discuss it.
Personally, I find it annoying that sites remove my right click context, and only a handful of sites I use use it (for enhanced functionality/features), and it is handy - but I just bypass that functionality, or use a secondary browser. While it nicely fits in the section, it really, IMO, has no privacy issues.
The other issue is, how widespread is sites abusing this, if at all. What does setting a nothing right click context achieve (is this the ruse they use to disable selecting text?). I have no idea because its been disabled for me for years.
IF there are no security (and privacy) concerns, then should this be moved to the personal section?

I have already mentioned this one one. Personaly I have set it to true, since it breaks functionality on some context menu richer pages I am using, for example (Outlook Web Access for Email).
If this is set to false, then I can't get the email actions context menu like reply, reply to all, mark as read, etc...
In case I would like to get the standard FF context menu on those pages, I can still right-click anywhere on the page where contextmenu event is not bind on.
But I am still unsure about privacy/security concerns when set to true.

@crssi I know :) I created this issue from that other one - because the other one I want to keep as all 0800s and close it off.

I rarely find sites that use it: I stumbled on a page with an exploit code, which the author didn't want to be copied. Same applies to images. It's not a user security concern.

IF there are no security (and privacy) concerns, then should this be moved to the personal section?

I don't think so. It's under UI Meddling and that's exactly what it does.  I don't mind though if you want to comment it out by default and let the end-users decide. I'm also not aware of any privacy/security issues this has, but UI Meddling is still what this does and where it fits, IMO.

I do believe it could be a security concern (anything that can imitate the UI can be dangerous) - chances, slim to none. Yes it fits the section exactly as described.
Thumbs up = it stays
Thumbs down = it moves

Not sure for tumbs up/down.
Does it mean?
Thumbs up = dom.event.contextmenu.enable = false
Thumbs up = dom.event.contextmenu.enable = true
Or vice versa?

@crssi  the values/description will not change

thumbs up = no changes
thumbs down = we move 2201 to the 3200s personal section and renumber it

I was considering removing it altogether from my prefs.js because it breaks youtube right click.

For what it's worth I have this pref commented out:

It breaks right-click functionality in some web applications (including my tt-rss instance)
There is no known way to abuse this (or do you have any links/research on that?) and I can't think of any (disguise as a normal browser right-click menu, and then do... what?)

 It was first introduced as false https://github.com/pyllyukko/user.js/commit/a366678778b6e19e0b7975ca18fefa3d253a3514, then commented out https://github.com/pyllyukko/user.js/commit/736d36e5f5e4e99667eff9dde3d41309c00880eb. I intend to leave it commented out, in the UI-related section, which is the right section.

only 997 more votes at minimum to go then

@Just-me-ghacks - tons of top sites like google (gmail/docs), dropbox, outlook etc - yup, gonna be breakage. Personally, I don't get affected because I avoid all those sites like the plague - and its not a privacy issue, and it was designed as a feature - and security risk is none to zero really .. just get ya mates to come here and vote then ... 997 to go bro :)

@nodiscc You say that in the PK user.js the pref is in the UI section which is the right section, but here you gave a thumbs down to move it to the personal section. :headspin:

In the case of a tie, I, your dark insect overlord, get a deciding vote :+1:

thumbs down = we move 2201 to the 3200s personal section and renumber it

The ratio pertinence/bother (be it on few but important sites) is too low to change dom.event.contextmenu.enable from default=true to false.

Damn, I think I'll need to create a bunch of new github accounts and "correct-the-record" in my favor ;)

Most commenters seem to want the default changed and don't care which section its under.
IMO we should disregard the votes, keep it in UI Meddling but comment it out.
We can still keep it enabled in our own local versions

^^ was just going to say that. nodiscc actually says the ui is the right section but then thumbs down. zymase's argument is about it's default state (which I kind of agree .. why let a few a-holes ruin some major sites' functionality?).
However, the question was should it move or not. It was never about its state. This is a template. So IDK .. the good thing is, it'll take a while to get 1000 votes.

True, @Roman-Nopantski , I should have pointed out that I was referring to the default value rather than its section. It should be commented out IMO, and it's even surprising it isn't considering that all settings which present a flagrant pro/con are, as far as I know the list and I know it quite well. True also that I don't use sections but rather my own grouping methodology which has at least the advantage of obliging me to understand a setting and its implications before adding it -- commented out or not -- to my own user.js file.

Adding this : if all settings were commented out users would have to think twice, would need to know what they are allowing/forbidding before commenting in or not, and take full responsibility of their decisions. Some just copy the user.js file in their profile, blindly, and then start complaining because they don't get a feature any more....

very interesting! I wouldn't even be totally against it, but I still see why it would problematic even if we would decide to go that route.

if someone who just blindly puts it in his/her profile without even glancing over it (to realize that it does absolutely nothing by default), it would give them a wrong feeling of protection.
the kind of people who just blindly put a user.js in the profile BUT DO glance over it, they would just delete it and go find another user.js to blindly put into their profile.

Not that I give a single shit about those kinds of persons opinions, but I for one also appreciated the pre-selection (active prefs and commented prefs) that Pants put in the file, when I first started using it.

I think there are solutions to this. There are 270+ odd numbers. Of these about 220+ have zero to miniscule effect. So we're only talking a small number - 50 items.
Now picture three branches - super easy, current, uber-hardened
^^ that takes care of 35 of the 50.
Leaving 15 items for personal taste.

Will close this issue:

I will add a [SETUP] tag to the description
It will NOT be moving sections, it belongs exactly in the UI section
The case for whether it is active or not will be revisited in a future issue where we can discuss an OVERALL strategy on relaxing some of these items - eg. There is a very good point about relaxing os + browser cross contamination, most people i guess would like the urlbar to suggest bookmarks, most people would like to restore sessions from a crash, we already allow keeping cookies - so we should be consistent in our approach [Don't forget that the future holds 2 more branches - super-lite and uber-hardened - maybe this version in the middle needs to be a little more relaxed, so it's more appealing]

see #61


[Feature] custom commands for updating/installing

I'm looking to switch to paq, but I've got a bit of an exotic setup. I compile plugins in-place, meaning that the git working tree of the plugin clones is dirty. This is a problem with paq's approach to updating plugins, as git will refuse to overwrite the local changes. If there was a way to customize how paq updates plugins, I could reset the repo first, then pull and then compile the plugin again.

I ran into a similar problem where I ended up with a dirty working directory, too. With packer.nvim I can just add --autostash to the update command to solve it. Perhaps the git commands could be made configurable in paq as well? Alternatively allowing to run multiple shell commands in run could also work, e.g. git config merge.autoStash true && make work tree dirty

put those two commands in a shell script and just call that: run = 'myupdater'. I don't think paq should widen its scope to dealing with git conflicts.

I ran into a similar problem where I ended up with a dirty working directory, too. With packer.nvim I can just add --autostash to the update command to solve it. Perhaps the git commands could be made configurable in paq as well? Alternatively allowing to run multiple shell commands in run could also work, e.g. git config merge.autoStash true && make work tree dirty

Unfortunately, --autostash won't do it for me, because while it fixes the issue once, the merge will always fail, leaving behind a stash which prevents the next pull from working.


Beginning of Kubeflow csi

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing this PR as obsolete


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 12:12:29 on 2023.07.17
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 5, errors out: 0
Original problem ID: 32680
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=32680

Problem has been resolved in 6m 0s at 12:18:29 on 2023.07.17
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 32680


Packaged NuSpec description has trailing quotation

Version: <IP_ADDRESS>
Just noticed when unpacking and verifying a packaged NuPkg that the description element has a trailing quotation mark even though the corresponding AssemblyInfo.cs does not.
<description>[MyAssemblyInfoDescriptionAttribute]"</description>
[assembly: AssemblyDescriptionAttribute("[MyAssemblyInfoDescriptionAttribute]")]

huh? where is this coming from?

?

Well this is frightfully embarrassing. I've just gone back to check if it's still happening, and did another quick check of the template file to make sure it is indeed not in there, and it is.
A thousand apologies, I see me buying the beers in the future! :+1:


AAU, I see that removal of name field is reflected in docs

[ ] I opened a merge request on kili on a branch with the same name than the branch of the current pull request and forced security tests.
[ ] I opened a pull request on the Node playground if the changes are breaking.

This PR clears leftovers of now removed field name, so there's no need to link associated MR on kili repo (work there has already been done and merged, we just missed this place when doing cleaning).

This PR is obsolete, after recent changes for DOC-30 (updating and refreshing getting started section) has been merged.


[SPARK-32567][SQL][FOLLOWUP] Fix CompileException when code generate for FULL OUTER shuffled hash join

What changes were proposed in this pull request?
Add throws IOException to consumeFullOuterJoinRow in ShuffledHashJoinExec
Why are the changes needed?
pr #34444 add code-gen for full outer shuffled hash join. If we don't have this patch,   when the dataframes are fullter outer shuffled hash joined, and then aggregate the results.  the dataframes will throw a CompileException.
For example:
    val df1 = spark.range(5).select($"id".as("k1"))
    val df2 = spark.range(10).select($"id".as("k2"))
    df1.join(df2.hint("SHUFFLE_HASH"), $"k1" === $"k2", "full_outer").count()

The dataframe will throw an Exception which is as follows:
23:28:19.079 ERROR org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator: failed to compile: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 175, Column 1: Thrown exception of type "java.io.IOException" is neither caught by a "try...catch" block nor declared in the "throws" clause of the declaring function
org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 175, Column 1: Thrown exception of type "java.io.IOException" is neither caught by a "try...catch" block nor declared in the "throws" clause of the declaring function
	at org.codehaus.janino.UnitCompiler.compileError(UnitCompiler.java:12021)
	at org.codehaus.janino.UnitCompiler.checkThrownException(UnitCompiler.java:9801)
	at org.codehaus.janino.UnitCompiler.checkThrownExceptions(UnitCompiler.java:9720)
	at org.codehaus.janino.UnitCompiler.findIMethod(UnitCompiler.java:9163)
	at org.codehaus.janino.UnitCompiler.compileGet2(UnitCompiler.java:5055)

Does this PR introduce any user-facing change?
No
How was this patch tested?
Add a new UT

Can one of the admins verify this patch?

cc @c21

ok to test

Test build #145210 has started for PR 34589 at commit 9ab6211.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49679/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49679/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49679/

Test build #145210 has finished for PR 34589 at commit 9ab6211.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145210/

Thanks for fixing this @jerqi and @c21 for reviewing it.

Test build #145215 has started for PR 34589 at commit ed35e3c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49684/

Test build #145218 has started for PR 34589 at commit f6901e5.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49684/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49688/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49684/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49688/

Last commits are test-only and GA was passed. Merging to master.

thanks @viirya @c21

Test build #145218 has finished for PR 34589 at commit f6901e5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145218/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49688/

Test build #145215 has finished for PR 34589 at commit ed35e3c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145215/


Users can join a group and have no name or avatar

see: steam_buddy
Besties is a member of steam_buddy's groups, but steam_buddy is not a member of Besties. He can still post, but has no name or avatar.

But is this a side effect of you manipulating the DB?

It most likely is, but we should probably still check to ensure that a user has a group and the group has the user before sending messages just in case.


Add metrics for ssl keystore certificate expiration time

Why are the changes needed?

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #4306 (7310c5e) into master (a31d449) will decrease coverage by 0.02%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##             master    #4306      +/-   ##
============================================
- Coverage     53.41%   53.40%   -0.02%
  Complexity       13       13
============================================
  Files           560      561       +1
  Lines         30571    30590      +19
  Branches       4139     4140       +1
============================================
+ Hits          16331    16337       +6
- Misses        12704    12717      +13
  Partials       1536     1536

Impacted Files
Coverage Δ

...cala/org/apache/kyuubi/metrics/MetricsSystem.scala
80.76% <16.66%> (-8.37%)
:arrow_down:

...c/main/scala/org/apache/kyuubi/util/SSLUtils.scala
50.00% <50.00%> (ø)

...a/org/apache/kyuubi/metrics/MetricsConstants.scala
100.00% <100.00%> (ø)

...apache/kyuubi/engine/JpsApplicationOperation.scala
77.41% <0.00%> (-3.23%)
:arrow_down:

...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala
59.09% <0.00%> (-1.52%)
:arrow_down:

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
70.96% <0.00%> (-0.47%)
:arrow_down:

.../kyuubi/plugin/spark/authz/ranger/AccessType.scala
16.21% <0.00%> (ø)

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
79.01% <0.00%> (+0.61%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[NFC|ClangImporter] DRY to determine whether or not ext is PCH.

This commit is a trivial one that adopts DRY/OAOO for determining whether or not file extension is PCH.

@swift-ci Please smoke test and merge

@swift-ci Please smoke test macOS platform


Add Robinhood Crypto support

Currently the extension does not support Robinhood Crypto.
Since Robinhood Crypto is not available in Kansas yet, this functionality will not be added unless I can get some assistance from someone that has access to it.

I have crypto and the plugin was already working as-is.  I ran the current version installed from source.


Define rule: Each biomedical concept used in a study must have all of the properties defined in the Library

In order to check that all required properties of a biomedical have been used, it is first necessary to confirm that all the properties of the biomedical concept that are defined in the CDISC Library have been included included biomedical concept definition in the USDM study.

Looking at the BCs to try to figure out which attributes are "required" and "unmodifiable".

BCs are currently being developed at two levels, conceptual (shown in diagram above) and implementation-specific (currently SDTM).  Diagram showing both conceptual and SDTM levels of model in diagram below. Seems there is some need for harmonization between BC model and USDM. USDM includes isRequired attribute of a BiomedicalConceptProperty, but COSMOS BCs have a notion of mandatory only in the SDTM implementation.

This rule requires knowing what properties a BC has in the library. Not all properties are populated for each  BC (e.g., codelist is not applicable for numeric properties), so does the rule run through just properties populated for a BC properties, or check presence of all properties, even if some are null? Does the format of data matter?  E.g., tabular data has a cell, even if it's empty.  Does json include notation of null data elements?


Consortia cleanup

Description
This PR contains the (so far) final development efforts made during the Catena-X consorita phase.
Additional cleanup steps like proper dependency annotations and release guideline compliance have been done.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

HI @Ruskyy,
could you maybe check, why there are test failures for this build?
FYI @ClosedSourcerer

Looking at the error it seems like the Github action was trying to run old code.
I am not able to re run failed jobs but the error referes to the use of 'records', instead of interface but thats not the case on the branch it should be looking at.
ExceptionResponseImpl
Can you force a re run ?

HI @Bailonis and @Ruskyy,
same as mentioned in the comment on the documentation branch: Could you please check the GitGuardian issues raised for this PR.
@Ruskyy, restarting the build did not resolve the issue. If you already have a solution, please fix it in your workflows, or raise an issue with your research on it, so someone else can pick it up

Filled in the issue structure with the findings from the repo of the prettier version running on the action.
https://github.com/eclipse-tractusx/demand-capacity-mgmt/issues/71

Regarding the security checks, they all appear to be from settings from local development aswell. And EDC secrets are on the vault, not plaintext on the yaml.
As for the issue I will open it now.

It is still important, that you provide feedback, since it does not matter, if a secret is leaked somewhere in history or on the current revision. If it can be misused, that's an issue, so providing feedback, if tokens and API keys have been rotated is important


Better error message for dictionary encoding/validation

Currently, xmlschema does not report where an error happens during encoding/validation. For example, consider the following schema:
<?xml version="1.0" encoding="UTF-8"?>
<schema xmlns="http://www.w3.org/2001/XMLSchema" xmlns:tns="http://www.example.org/Rotation/" targetNamespace="http://www.example.org/Rotation/">
    <element name="rotation">
      <complexType>
        <attribute name="roll" type="tns:degree"></attribute>
        <attribute name="pitch" type="tns:degree"></attribute>
        <attribute name="yaw" type="tns:degree"></attribute>
      </complexType>
    </element>

    <simpleType name="degree">
      <restriction base="float">
        <minInclusive value="0"></minInclusive>
        <maxInclusive value="360"></maxInclusive>
      </restriction>
    </simpleType>
</schema>

Now I try to validate a dictionary:
import xmlschema

rotation_schema = xmlschema.XMLSchema("/home/user/Rotation.xsd")
rotation_data = {
    "@roll": 0.0,
    "@pitch": 0.0,
    "@yaw": -1.0   # <----- invalid value, must be between 0 and 360
}

e = None
try:
    rotation_schema.encode(rotation_data)
except Exception as exc:
    e = exc

print(e.args)

Result:
(XsdMinInclusiveFacet(value=0.0, fixed=False),
 -1.0,
 'value has to be greater or equal than 0.0.')

From the stacktrace, we know that a certain value (-1.0) is invalid, but we don't know which property has this value.
Can we somehow identify the elements/attributes that do not validate?

Hi,
This can be improved sacrificing part of the stacktrace, raising the error at higher-level (at element/attribute level). So the error with stacktrace will change from:
Traceback (most recent call last):
  File "xmlschema/tests/test_validators.py", line 1300, in test_error_instance
    schema.encode(rotation_data)
  File ".../xmlschema/xmlschema/validators/xsdbase.py", line 651, in encode
    for result in self.iter_encode(obj, validation=validation, *args, **kwargs):
  File ".../xmlschema/xmlschema/validators/schema.py", line 1112, in iter_encode
    for result in xsd_element.iter_encode(obj, validation, converter=converter, **kwargs):
  File ".../xmlschema/xmlschema/validators/elements.py", line 584, in iter_encode
    for result in attribute_group.iter_encode(element_data.attributes, validation, **kwargs):
  File ".../xmlschema/xmlschema/validators/attributes.py", line 669, in iter_encode
    for result in xsd_attribute.iter_encode(value, validation, **kwargs):
  File ".../xmlschema/xmlschema/validators/attributes.py", line 257, in iter_encode
    for result in self.type.iter_encode(obj, validation):
  File ".../xmlschema/xmlschema/validators/simple_types.py", line 1260, in iter_encode
    raise error
xmlschema.validators.exceptions.XMLSchemaValidationError: failed validating -1.0 with XsdMinInclusiveFacet(value=0.0, fixed=False):

Reason: value has to be greater or equal than 0.0.

Schema:

  <minInclusive xmlns="http://www.w3.org/2001/XMLSchema" value="0" />

to an error with a shorter stacktrace but with an instance reference:
Traceback (most recent call last):
  File "xmlschema/tests/test_validators.py", line 1300, in test_error_instance
    schema.encode(rotation_data)
  File ".../xmlschema/xmlschema/validators/xsdbase.py", line 651, in encode
    for result in self.iter_encode(obj, validation=validation, *args, **kwargs):
  File ".../xmlschema/xmlschema/validators/schema.py", line 1112, in iter_encode
    for result in xsd_element.iter_encode(obj, validation, converter=converter, **kwargs):
  File ".../xmlschema/xmlschema/validators/elements.py", line 637, in iter_encode
    yield self.validation_error(validation, e, elem, **kwargs)
  File ".../xmlschema/xmlschema/validators/xsdbase.py", line 716, in validation_error
    raise error
xmlschema.validators.exceptions.XMLSchemaValidationError: failed validating -1.0 with XsdMinInclusiveFacet(value=0.0, fixed=False):

Reason: value has to be greater or equal than 0.0.

Schema:

  <minInclusive xmlns="http://www.w3.org/2001/XMLSchema" value="0" />

Instance:

  <tns:rotation xmlns:tns="http://www.example.org/Rotation/" pitch="0.0" roll="0.0" yaw="-1.0" />

Actually the affected instance is represented as encoded XML for convenience (is like a decode error, anyway I'm not sure if using the original object is better on encode to identify the instance error ...).
With these changes may be better and sufficient in your opinion?

The more informative error message for encoding is available with new release v1.0.13.


Add function for automatically finding gate cuts to reduce circuit depth

Resolves #272
This PR introduces a function for automatically finding a set of optimized gates which reduce the depth of an input circuit.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

26 of 26 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 90.008%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
2360

Relevant Lines:
2622

💛  - Coveralls


const for for-of doesn't cause an error

TypeScript Version:
1.8.0-beta
Code
for (const v of [1,2,3]);

Expected behavior:
A compiler error: re-assignment of const-variable in loop.
Actual behavior:
Compiled successfully.

This is what's supposed to happen. A new environment is created per iteration with a bound variable named v. See https://tc39.github.io/ecma262/#sec-runtime-semantics-forin-div-ofbodyevaluation-lhs-stmt-iterator-lhskind-labelset.

(By the way, TypeScript 1.8 proper was released, you should totally update!)


Added devDependencies

plugin-transform-react-jsx

Coverage remained the same at 94.8% when pulling 36dd227754722d2b7cff531e0f66602ff29a025f on alvinhui:patch-1 into 6385724d27cfff8761a47b4c950e03f79f4c49ab on jasonslyvia:master.

I believe the babel-preset-react has already included babel-plugin-transform-react-jsx, so the modification should be remove babel-plugin-transform-react-jsx in .babelrc instead of adding it in devDependencies, right?
http://babeljs.io/docs/plugins/preset-react/

I'm gonna close this PR for now, feel free to elaborate 😀


move common cmse definitions from BSP to tee

Signed-off-by: Jacky Yang<EMAIL_ADDRESS>Description
we are porting new devices to mTower, and find tee has some dependency on BSP definitions, so we hope to seperate them apart.
Fixes #41 move common cmse definitions from BSP to tee
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[ ] These are only definitions location change, build get passed for numaker_pfm_m2351

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@tdrozdovsky please help review if it is reasonable to do so

Fine, I'll see how to do it!

workflow needs your approval.

@tdrozdovsky  anything update?

@tdrozdovsky  anything update?

Check if the request is still relevant


doc: add cluster issuer

:white_check_mark: Build TheIdServer 4.6.2-user-ole1-0016 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/6cc1941c92 by @aguacongas)


No error raised when controller stop working

Context
System version: 5.2.1
libfranka version: 0.10.0
franka_ros version: 0.10.2 (unreleased), on commit 2d458abad7390bb73771c91787c361c2b5cfa6ad, one commit behind the state of develop when this issue was made.
controllers used: position_joint_trajectory_controller and a custom controller . We switch from one to another during operation regularly. The "controller" used to interface with the robot state is used.
 When this happens:

No error is raised
Nothing abnormal is logged to the terminal
/franka_state_controller/franka_states/robot_mode is 2
calling controller_manager/list_controllers says the position_joint_trajectory_controller is running

But whenever a new trajectory is sent to move_group (moveit node) for the exectution, the controller is unresponsive and the trajectory execution fails with the following errors:
[ WARN] [1677695839.528682019] [/move_group]: Controller 'position_joint_trajectory_controller' failed with error GOAL_TOLERANCE_VIOLATED: panda_joint2 goal error -0.160081
[ WARN] [1677695839.528764014] [/move_group]: Controller handle position_joint_trajectory_controller reports status ABORTED
[ INFO] [1677695839.528796047] [/move_group]: Completed trajectory execution with status ABORTED ...
[ INFO] [1677695839.528885006] [/move_group]: Execution completed: ABORTED
[ INFO] [1677695839.529366444] [/move_group]: Received event 'stop'

The controller starts working normally again after switching the controllers again. To do this we:

Call the controller_manager/switch_controller service to switch to our custom controller. We do this because we can't make the position_joint_trajectory_controller run since it is "still running".
Call the controller_manager/switch_controller service to switch to the position_joint_trajectory_controller

The problem that we would like to be addressed is not the failure of the controller itself, but the fact that it is not reported as not working since we can't identify why the controller failed or do something about it automatically if it is not reported.
Steps to reproduce
We don't know the exact cause of the controller to fail when it happens to us, so to reproduce the error, I just made a script that moves a little bit back with the position_joint_trajectory_controller, then moves forward a little bit with our custom controller and repeats this 200 times. I made it very rough to provoke the controller failure more easily and I tested it twice and in both cases the error happened after not too long.
@Maverobot, we would prefer to send the script and custom controller privately. Could you tell me how should I share it with you? I can make a workspace with the script in one package and the controller in another one. My mail is<EMAIL_ADDRESS>The only issue is that we also use a custom planner that uses some packages with some modifications and it could be complicated to share. The robot should only plan and move to a specific and given joint configuration. I will leave an empty method in the script move_to_this_position that should do this. Would it be possible for you to plan and move it with the default MoveIt tools or however is easier for you? Thank you in advance for your time.

Thank you. Please let me know here or by e-mail if anything is unclear. I will prepare everything and send it today or tomorrow.

Thank you for the analysis.
If this race condition would happen, it would prevent the first sent trajectory to be overwritten as you explain, but then i think  new trajectories sent after this would have no problem, which is not the case.
Because currently when a trajectory fails, if new trajectories are sent, they all fails too until the controllers are switched again.
In the current test case, if after this failure the script is ran again, first it will try to switch to to the position_joint_trajectory_controller, it will say it is already running, then it will send the trajectory goal to the action server and it will fail again with a message similar to:
Controller 'position_joint_trajectory_controller' failed with error GOAL_TOLERANCE_VIOLATED: panda_joint2 goal error -0.160081

The way you reproduce it looks good.For the execution we currently use the Move Group Python interface as shown in the MoveIt tutorial, but it should be the same  as at the end of the day they also just send a request to the action server with their execute method.
Did you restart the franka control node or switch the controller after the trajectory fails and before executing the move_back_and_forth method?

After getting stuck, I killed the controller switch test script and ran it again. No error was shown and the motions were executed successfully (until the next "stuck").

This is weird because for us it stop working. I will do the experiment again using your script and sending the trajectories directly to the position_joint_trajectory_controller as you did.

It would be very helpful if you can come up with code, with which we can reproduce it.

If the trajectories are still failing for us after using your script, I will see if I can catch the error where I want the controller switch test to stop to make sure it stops for the reason we want and send it to you. As I said now I can't run tests with the robot, but I will as soon as possible and write you back. Maybe tomorrow evening I can already test and send you my feedback. The latest, I will send it on Wednesday.

This issue is no longer a blocker for us. We will use the follow_joint_trajectory action and a sleep after changing the controller as recommended to solve it.
The remaining thing to do would be to evaluate if the reset done by franka_control_node is necessary. If not, taking it out would avoid race conditions and we could take the sleep away, but this is not a blocker and would not result in a fatal error for us anymore.

I noticed that the position_joint_trajectory_controller/follow_joint_trajectory action has the same issue as the execute_trajectory action if goal_tolerances are specified in the sent goal.
Before I said that:

The position_joint_trajectory_controller/follow_joint_trajectory action result is successful even when the robot doesn't move

This is true only if the sent goal has no goal tolerances. I specified them (this is also done in the execute_trajectory action) and tighten the goal_time_tolerance and then the action returns as unsuccessful. When this happens, then any trajectory sent afterwards is also unsuccessful.
The most relevant code added was the following. I will also sent you @Maverobot the script by mail.
goal_tolerances = []
for joint_name in self.joint_names:
    goal_tolerance = JointTolerance()
    goal_tolerance.name = joint_name
    goal_tolerance.position = 0.01
    goal_tolerance.velocity = 0.1
    goal_tolerance.acceleration = 0.1
    goal_tolerances.append(goal_tolerance)

goal = FollowJointTrajectoryGoal()

goal.goal_tolerance = goal_tolerances
goal.goal_time_tolerance = rospy.Duration.from_sec(0.1)

This is not critical for us as we will use the position_joint_trajectory_controller/follow_joint_trajectory action WITHOUT goal tolerances and add our own check to see if it arrives to the desired position, but it might affect if the controller is unsuccessful for other reason.
I am not sure if this is a problem from ros_controllers or the hardware interface between the controller and the robot. I can make an issue in ros_controllers if you think it is the first one.

Doesn't the action return a FollowJointTrajectoryResult.INVALID_GOAL result in your code when the robot doesn't move (due to the race condition)? This is from when trajectories start failing.
The main difference I can see is that you send a 1 point trajectory and I include also the initial point.
I don't get why the different behavior and I can't test much now, but I will as soon as I can.
Thanks for the quick reply

Hello @Maverobot ,
as we agreed before, we were using:

the position_joint_trajectory_controller/follow_joint_trajectory action WITHOUT goal tolerances and add our own check to see if it arrives to the desired position

But the error of the trajectory execution failing once and then getting stuck and failing for any other sent trajectory happened again.
Because of this, in the last test we added goal tolerances, but very high ones:
self.goal_tolerances = []
for joint_name in self.joint_names:
    goal_tolerance = JointTolerance()
    goal_tolerance.name = joint_name
    goal_tolerance.position = 6
    goal_tolerance.velocity = 6
    goal_tolerance.acceleration = 6
    self.goal_tolerances.append(goal_tolerance)

goal = FollowJointTrajectoryGoal()
goal.goal_tolerance = self.goal_tolerances
goal.goal_time_tolerance = rospy.Duration.from_sec(0.5)

This works most of the time, but in the lab we already saw the problem occurring again.
As I said before, I think the problem happens when the controller itself fails, so when the controller itself says the trajectory fails because the tolerances were not met. When this happens, for some reason all further sent trajectories fail too.
What we were doing so far was letting the tolerances very loose or not specified so the controller itself won't think it fails, but this is not a good enough solution since the error can already happen as it happened already to us.
Could you please help us seeing how to make the controller able to don't get stuck after failing once?

Hello @Maverobot,
It's very nice that you found that error. This week I can't test in our physical system, but I will prepare everything to test when I am able to.
One question in regards of exactly what this solves. There were 2 problems:

The controller fails a trajectory. This was caused by a race condition or that was the theory we stated in this conversation and can be avoided by waiting a bit. This wait was ignored on purpose on the minimal example to trigger the error.
Once the controller fails once, all the following sent trajectories fail too. This was the most critical part.

Which part does this fix would solve?
Again thanks for finding this problem

Hello Zheng,
That is very nice. We will test it when we are back from field testing. Thank you.
About the problem 1, the race condition, it would be ideal if it could be fixed (not sure if the last update is necessary for the ROS controller) so investigation would be required as you stated in this comment:

Option 2: More investigation to check if control_manager.update(now, period, true); is necessary.

But the most critical part was the part 2.


Beamline prefix in *_01 beamlines are wrong

For a beamlines with _1 the PV prefixes are BLXXJ rather than BLXXI e.g. i20_1 has PVs of BL20J. However, when the i20_1.py module is used it incorrectly uses BL04I. This can be seen by running dodal connect i20_1 after https://github.com/DiamondLightSource/dodal/pull/519 is merged
Acceptance Criteria

dodal connect i20_1 correctly connects to devices

FYI @stan-dot, you'll probably get round i20_1 before MX get round to any _1 beamlines so you will need to fix this first

i20_1 beamline is on indefinite leave. The prefixes issue for it won't be a problem

Duplicate of https://github.com/DiamondLightSource/dodal/issues/760 but that one is better written


Query cost validation

Create new Modules which validates query cost by

counting number of accessed fields
calculating depth

Target repository: https://github.com/infinityloop-dev/graphpinator-query-cost


[ISSUE #5204] Enable checkstyle for test code (all module)

Make sure set the target branch to develop
What is the purpose of the change
close #5204
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #5297 (0467905) into develop (8d10c96) will increase coverage by 0.03%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5297      +/-   ##
=============================================
+ Coverage      43.20%   43.23%   +0.03%
- Complexity      7807     7816       +9
=============================================
  Files            998      998
  Lines          69451    69451
  Branches        9169     9169
=============================================
+ Hits           30003    30024      +21
+ Misses         35682    35655      -27
- Partials        3766     3772       +6

Impacted Files
Coverage Δ

...ketmq/common/protocol/body/ConsumerConnection.java
95.83% <0.00%> (-4.17%)
:arrow_down:

...ketmq/proxy/grpc/v2/channel/GrpcClientChannel.java
56.04% <0.00%> (-3.30%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
60.43% <0.00%> (-2.20%)
:arrow_down:

...mq/store/ha/autoswitch/AutoSwitchHAConnection.java
70.16% <0.00%> (-1.62%)
:arrow_down:

...cketmq/broker/schedule/ScheduleMessageService.java
55.26% <0.00%> (-1.18%)
:arrow_down:

...he/rocketmq/client/impl/consumer/ProcessQueue.java
61.46% <0.00%> (-0.92%)
:arrow_down:

.../rocketmq/broker/filter/ConsumerFilterManager.java
72.19% <0.00%> (-0.90%)
:arrow_down:

...che/rocketmq/test/lmq/benchmark/BenchLmqStore.java
50.24% <0.00%> (-0.50%)
:arrow_down:

...ent/impl/consumer/DefaultLitePullConsumerImpl.java
69.37% <0.00%> (-0.47%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
34.53% <0.00%> (ø)

... and 14 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


demo-julia example repo: Julia version and notebook failing cell

This issue refers to this repo.
Launching Binder and starting with the repo works correctly (e.g. via the link in the README).
When running the notebook from the top, the cell In[11] fails with the output below.
Binder is using the Julia 1.3.1 kernel with this notebook.  The compat section of Project.toml contains julia = "1.1".
The notebook runs correctly when the original Manifest.toml isn't included (see this fork).

Output from cell 11:
┌ Info: Precompiling Gadfly [c91e804a-d5a3-530f-b6f0-dfbca275c004]
└ @ Base loading.jl:1273
ERROR: LoadError: LoadError: TypeVar in Vararg length must have bounds Union{} and Any
Stacktrace:
 [1] top-level scope at /srv/julia/pkg/packages/AxisAlgorithms/m2HBJ/src/tridiag.jl:21
 [2] include at ./boot.jl:328 [inlined]
 [3] include_relative(::Module, ::String) at ./loading.jl:1105
 [4] include at ./Base.jl:31 [inlined]
 [5] include(::String) at /srv/julia/pkg/packages/AxisAlgorithms/m2HBJ/src/AxisAlgorithms.jl:3
 [6] top-level scope at /srv/julia/pkg/packages/AxisAlgorithms/m2HBJ/src/AxisAlgorithms.jl:46
 [7] include at ./boot.jl:328 [inlined]
 [8] include_relative(::Module, ::String) at ./loading.jl:1105
 [9] include(::Module, ::String) at ./Base.jl:31
 [10] top-level scope at none:2
 [11] eval at ./boot.jl:330 [inlined]
 [12] eval(::Expr) at ./client.jl:425
 [13] top-level scope at ./none:3
in expression starting at /srv/julia/pkg/packages/AxisAlgorithms/m2HBJ/src/tridiag.jl:21
in expression starting at /srv/julia/pkg/packages/AxisAlgorithms/m2HBJ/src/AxisAlgorithms.jl:46
ERROR: LoadError: Failed to precompile AxisAlgorithms [13072b0f-2c55-5437-9ae7-d433b7a33950] to /srv/julia/pkg/compiled/v1.3/AxisAlgorithms/lW7vi_kQr4m.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1283
 [3] _require(::Base.PkgId) at ./loading.jl:1024
 [4] require(::Base.PkgId) at ./loading.jl:922
 [5] require(::Module, ::Symbol) at ./loading.jl:917
 [6] include at ./boot.jl:328 [inlined]
 [7] include_relative(::Module, ::String) at ./loading.jl:1105
 [8] include(::Module, ::String) at ./Base.jl:31
 [9] top-level scope at none:2
 [10] eval at ./boot.jl:330 [inlined]
 [11] eval(::Expr) at ./client.jl:425
 [12] top-level scope at ./none:3
in expression starting at /srv/julia/pkg/packages/Interpolations/0OnYb/src/Interpolations.jl:35
ERROR: LoadError: Failed to precompile Interpolations [a98d9a8b-a2ab-59e6-89dd-64a1c18fca59] to /srv/julia/pkg/compiled/v1.3/Interpolations/VpKVx_kQr4m.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1283
 [3] _require(::Base.PkgId) at ./loading.jl:1024
 [4] require(::Base.PkgId) at ./loading.jl:922
 [5] require(::Module, ::Symbol) at ./loading.jl:917
 [6] include at ./boot.jl:328 [inlined]
 [7] include_relative(::Module, ::String) at ./loading.jl:1105
 [8] include(::Module, ::String) at ./Base.jl:31
 [9] top-level scope at none:2
 [10] eval at ./boot.jl:330 [inlined]
 [11] eval(::Expr) at ./client.jl:425
 [12] top-level scope at ./none:3
in expression starting at /srv/julia/pkg/packages/KernelDensity/FYY3d/src/KernelDensity.jl:6
ERROR: LoadError: LoadError: Failed to precompile KernelDensity [5ab0869b-81aa-558d-bb23-cbf5423bbe9b] to /srv/julia/pkg/compiled/v1.3/KernelDensity/4QyGx_kQr4m.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1283
 [3] _require(::Base.PkgId) at ./loading.jl:1024
 [4] require(::Base.PkgId) at ./loading.jl:922
 [5] require(::Module, ::Symbol) at ./loading.jl:917
 [6] include at ./boot.jl:328 [inlined]
 [7] include_relative(::Module, ::String) at ./loading.jl:1105
 [8] include at ./Base.jl:31 [inlined]
 [9] include(::String) at /srv/julia/pkg/packages/Gadfly/09PWZ/src/Gadfly.jl:1
 [10] top-level scope at /srv/julia/pkg/packages/Gadfly/09PWZ/src/Gadfly.jl:1107
 [11] include at ./boot.jl:328 [inlined]
 [12] include_relative(::Module, ::String) at ./loading.jl:1105
 [13] include(::Module, ::String) at ./Base.jl:31
 [14] top-level scope at none:2
 [15] eval at ./boot.jl:330 [inlined]
 [16] eval(::Expr) at ./client.jl:425
 [17] top-level scope at ./none:3
in expression starting at /srv/julia/pkg/packages/Gadfly/09PWZ/src/statistics.jl:21
in expression starting at /srv/julia/pkg/packages/Gadfly/09PWZ/src/Gadfly.jl:1107

Failed to precompile Gadfly [c91e804a-d5a3-530f-b6f0-dfbca275c004] to /srv/julia/pkg/compiled/v1.3/Gadfly/DvECm_kQr4m.ji.

Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1283
 [3] _require(::Base.PkgId) at ./loading.jl:1024
 [4] require(::Base.PkgId) at ./loading.jl:922
 [5] require(::Module, ::Symbol) at ./loading.jl:917
 [6] top-level scope at In[11]:1

Hi @ots22,
thanks for finding the bug and suggesting a fix. Do you want to make a PR (and @ mention me in it) directly to the example repo with the fix from the turing way repository?

Hi @betatim, yes happy to - one fix would be to bump the version number and make a new Manifest.toml.  Better might be to investigate how to make it work with a pinned version of Julia.


Use alpine base + prune SDK

Updates to help reduce image size:

Use alpine base + lock to gcloud v224
Cut secondary SDK installation
Update AppCfgCmd default to gcloud appengine sdk location

With these changes compressed image size as reported by DockerHub is ~270mb.  I've pushed a copy here for testing: https://hub.docker.com/r/bharanin/drone-gae/ .
I ran test deployments with standard (go1.9, go111) and flex and they worked as expected - however, if folks could try with a few real-world builds that would be ideal.
Based on appengine release notes (https://cloud.google.com/appengine/docs/standard/go/release-notes) go1.6 and go1.8 deployments are now blocked - so this PR will drop support for those as well.

I'll need to try this out with a Go <=1.9 build to see if the appcfg.py in there will play nice. I'll try to find some time in the next few days.
If you have the time, ping me and I can point you to a couple private repos to try.

@bharanin @tonglil Are we good to merge this?

I don't believe it worked for the 1st Gen GAE users. We probably would need to run more tests to make sure it works first.

this won't work until go1.6 and go1.8 are fully phased out...  closing for now


Add CLI project

Add CLI project with command line options matching the C# project, so we can swap them out as needed.

Done, now needs to be removed and moved to intiface. :(


Update for iosas 1.02a

Update this port to use the latest Steam and Itch.io game version, 1.02a. Tested on RG552.

This PR requires the love patcher that is currently on the gui beta branch.


Fix NPE when data is null in Discovery

We are getting this exception in runtime when application starts and discovery is scheduled.
Exception in thread "jgroups-6,aaaaaaaaaaaa-1111" java.lang.NullPointerException: Cannot invoke "java.util.List.stream()" because "data" is null
	at org.jgroups.protocols.Discovery.handle(Discovery.java:364)
	at org.jgroups.protocols.Discovery.up(Discovery.java:299)
	at org.jgroups.protocols.TP.passMessageUp(TP.java:1188)
	at org.jgroups.util.SubmitToThreadPool$SingleLoopbackHandler.run(SubmitToThreadPool.java:77)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

Reason for that might be a regression after refactoring: null-check for data was removed and stream method cannot be called anymore.

I also suggest label=java

Seems that this issue might also break startup synchronisation in the cluster. We've got a clustered lock that never expires and could not be directly released.

Applied and backported to 5.3.x

thx!


fix PictureLossIndication Unmarshal error and test coverage

Thank you, i added some fix and test, is this enough?

Sorry, I don't understand what the bug is here.
Can you tell me more about the issue you're having and how this patch fixes it?
I'm also available in the Slack channel if you want to talk it over there. My name is Max Hawkins there.

@wdouglass might also be able to help. Sorry I haven't looked at this code in a while.

Sorry, i'm writing a sfu demo, i want to send a pli to publisher when i received a pli from subscriber, the code is like this:
go func() {
for {
rtcpPacket := <-videoTrack.RTCPPackets
//right here, i found:  rtcpPacket.Header().Type != rtcp.TypePayloadSpecificFeedback and rtcpPacket.Header().Count != rtcp.FormatPLI
//then i add some fix with rtcp package
if rtcpPacket.Header().Type == rtcp.TypePayloadSpecificFeedback && rtcpPacket.Header().Count == rtcp.FormatPLI {
fmt.Println("Receiver.SendRTCP(rtcpPacket)")
Receiver.SendRTCP(rtcpPacket)
}
}
}()

Ah! I see. That is a bug.
I think the issue is that the Header() method on PictureLossIndication does not compute its header like the other packet types do.
Can you change Header() to return something like this?
func Header() Header {
		return Header{
				Count:  FormatPLI,
				Type:   TypePayloadSpecificFeedback,
				Length: pliLength,
		}
}

Let me know if I am misunderstanding.

Ah! I see. That is a bug.
I think the issue is that the Header() method on PictureLossIndication does not compute its header like the other packet types do.
Can you change Header() to return something like this?
func Header() Header {
		return Header{
				Count:  FormatPLI,
				Type:   TypePayloadSpecificFeedback,
				Length: pliLength,
		}
}

Let me know if I am misunderstanding.

Yes, it worked!  Is  header in PictureLossIndication struct nessary?
type PictureLossIndication struct {
// SSRC of sender
SenderSSRC uint32
// SSRC where the loss was experienced
MediaSSRC uint32

header Header

}

Nope, not necessary. Go ahead and remove it.
Could you also add your name to the README? After that you should be good to merge.


Incorrect borders with .list-group-flush.list-group-horizontal

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
When using .list-group-flush and .list-group-horizontal on the same list group you get:

But was expecting:

Documentation seems to say that this is possible:

Add .list-group-flush to remove some borders and rounded corners to render list group items edge-to-edge in a parent container (e.g., cards).

I have seen another issue about putting a list group IN a list group. But that is not what is being reported here.

Workaround (how I made the second screenshot) is to add .border-0 on each .list-group-item
Reduced test cases

        Featured

        Certificates
        Products
        AHA

        Featured

        Certificates
        Products
        AHA

Edit: CodePen created by @julien-deramond: https://codepen.io/julien-deramond/pen/rNoWJxg
What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Microsoft Edge
What version of Bootstrap are you using?
5.3.1

Thanks for reporting this issue @fulldecent.
I can see that even without integrating the horizontal flush list group into the card, there's an issue with borders:

    The current link item

  A second link item
  A third link item
  A fourth link item
  A disabled link item

Here's a CodePen showing the issue initially reported and the one I saw while testing it: https://codepen.io/julien-deramond/pen/rNoWJxg

Aha! Thank you, good minimizing!

@julien-deramond @fulldecent
Hey, guys.
I think I've found a solution to fix it and created a pull request: https://github.com/twbs/bootstrap/pull/39513.
For me, it works well, I checked separately only with a group list and inside a card component as well.
@julien-deramond Could, you, check, please?
Thanks.

I messed a bit with the commits, so if necessary, I can create a new pull request where I can clean everything up.

@WOLFRIEND I think that's OK, we change the message commit in the end and squash everything. If the final changes in the PR are OK, there's no need to clean it up.


Cannot connect to the crypto provider

Expected behavior
Email should be sent successfully with using crypto provider (encrypted mail).
Actual behavior
When I try to send (encrypted or not encrpyted) a message I got a warning:
"Cannot connect to crypto provider, check your settings or click crypto icon to retry!"
Few weeks ago it was successfully installed and tested. Maybe a system update has broken it.
If encryption switched off on K-9 mail settings, mail sending works.
Steps to reproduce

K-9 installed
OpenKeyChain Easy PGP installed, keys tested

Environment
K-9 Mail version: 5.403
OpenKeyChain:  Easy PGP: 5.0.2
Android version: 7.0
Account type (IMAP, POP3, WebDAV/Exchange): IMAP
mail service provider: gmail

Same problem, have it since I switched to a newer smartphone. Android 7.0, K-9 & openkeychain latest versions each. Received encrypted emails are not shown, without any notice.

Workaround is to manually start the cryptoprovider (OpenKeyChain), then reopen k9 and taphon the lock sign, then sending works for me...
The problem is the operating system preventing openkeychain to start automatically or being startet by k9

This workaround not working for me. Are there any solution to send/read encrypted mails?

cannot use the workaround either.
using latest K9 Version 5.600, OpenKeyChain Version 5.2
regardless of whether OKC is running or not when clicking on the lock I get same error.
Also in in configuration I cannot select a Key - I can configure OpenKeyChain as Crypto-provieder in global settings but when klicking on the select-key in account crypto-setting it just does nothing.
Android Version is 7.1.1
on my other phone (Android 6.0.1, same version of K9 and OKC) all works fine.

I have the same experience as  ntruchsess.
Phone: Meizu M6 Note (model M721H)
Android Version: 7.1.2
Android Security Patch Date: 1 October 2018
Build number: Flyme <IP_ADDRESS>G
I followed the instructions for generating a debug log, but it comes up empty--happy to try again if anyone wants to help me troubleshoot that process (I can get a log file, but no k9 entries appear).

I'm seeing this also. Logs below.

K9 Mail is 5.600 via fDroid
OpenKeychain is 5.2 also via fDroid
Happy to try Google Play versions if you want a cross-check (but I was seeing this issue with them also, and switched to fDroid to see if it helped).

Here's logs of trying and failing to have K9 initiate OpenKeychain service:
--------- beginning of main
06-09 18:50:05.806  6223  6223 E com.fsck.k9: Not starting debugger since process cannot load the jdwp agent.
06-09 18:50:05.852  6223  6243 I com.fsck.k9: The ClassLoaderContext is a special shared library.
06-09 18:50:05.862  6223  6243 I com.fsck.k9: The ClassLoaderContext is a special shared library.
06-09 18:50:05.940  6223  6223 D Embryo  : preload com.fsck.k9, 31ms, hwui=true, layout=true, decor=false
06-09 18:50:05.945  6223  6267 D OpenGLRenderer: Skia GL Pipeline
06-09 18:50:19.303  6223  6223 I Perf    : Connecting to perf service.
06-09 18:50:19.398  6223  6223 W ActivityThread: handleWindowVisibility: no activity for token android.os.BinderProxy@bb688be
06-09 18:50:19.419  6223  7470 D NetworkSecurityConfig: No Network Security Config specified, using platform default
06-09 18:50:19.450  6223  6267 I Adreno  : QUALCOMM build                   : 4c638fb, I557c585805
06-09 18:50:19.450  6223  6267 I Adreno  : Build Date                       : 10/06/18
06-09 18:50:19.450  6223  6267 I Adreno  : OpenGL ES Shader Compiler Version: EV<IP_ADDRESS>
06-09 18:50:19.450  6223  6267 I Adreno  : Local Branch                     :
06-09 18:50:19.450  6223  6267 I Adreno  : Remote Branch                    :
06-09 18:50:19.450  6223  6267 I Adreno  : Remote Branch                    :
06-09 18:50:19.450  6223  6267 I Adreno  : Reconstruct Branch               :
06-09 18:50:19.450  6223  6267 I Adreno  : Build Config                     : S L 6.0.7 AArch64
06-09 18:50:19.453  6223  6267 I Adreno  : PFP: 0x005ff112, ME: 0x005ff066
06-09 18:50:19.456  6223  6267 I ConfigStore: android::hardware::configstore::V1_0::ISurfaceFlingerConfigs::hasWideColorDisplay retrieved: 0
06-09 18:50:19.456  6223  6267 I ConfigStore: android::hardware::configstore::V1_0::ISurfaceFlingerConfigs::hasHDRDisplay retrieved: 0
06-09 18:50:19.456  6223  6267 I OpenGLRenderer: Initialized EGL, version 1.4
06-09 18:50:19.456  6223  6267 D OpenGLRenderer: Swap behavior 2
06-09 18:50:21.081  6223  6223 W ActivityThread: handleWindowVisibility: no activity for token android.os.BinderProxy@5af889
06-09 18:50:24.966  6223  6223 W ActivityThread: handleWindowVisibility: no activity for token android.os.BinderProxy@723542a
06-09 18:50:38.180  6223  6223 I StorageEditor: Committing preference changes
06-09 18:50:38.193  6223  6223 I StorageEditor: Preferences commit took 13 ms
06-09 18:50:42.716  6223  6223 W InputEventReceiver: Attempted to finish an input event but the input event receiver has already been disposed.
06-09 18:50:43.738  6223  6223 I StorageEditor: Committing preference changes
06-09 18:50:43.746  6223  6223 I StorageEditor: Preferences commit took 8 ms
06-09 18:50:45.970  6223  6223 W ActivityThread: handleWindowVisibility: no activity for token android.os.BinderProxy@6fc0533
06-09 18:50:45.993  6223  6223 I WebViewFactory: Loading com.android.chrome version 74.0.3729.157 (code 372915752)
06-09 18:50:46.021  6223  6223 I cr_LibraryLoader: Time to load native libraries: 3 ms (timestamps 2213-2216)
06-09 18:50:46.032  6223  6223 I chromium: [INFO:library_loader_hooks.cc(50)] Chromium logging enabled: level = 0, default verbosity = 0
06-09 18:50:46.032  6223  6223 I cr_LibraryLoader: Expected native library version number "74.0.3729.157", actual native library version number "74.0.3729.157"
06-09 18:50:46.040  6223  7719 W cr_ChildProcLH: Create a new ChildConnectionAllocator with package name = com.android.chrome, sandboxed = true
06-09 18:50:46.046  6223  6223 I cr_BrowserStartup: Initializing chromium process, singleProcess=false
06-09 18:50:46.116  6223  6223 E RecipientPresenter: error connecting to crypto provider!
06-09 18:50:46.116  6223  6223 E RecipientPresenter: java.lang.Exception: bindService() returned false!
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at org.openintents.openpgp.util.OpenPgpServiceConnection.bindToService(OpenPgpServiceConnection.java:105)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at com.fsck.k9.activity.compose.RecipientPresenter.cryptoProviderBindOrCheckPermission(RecipientPresenter.java:761)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at com.fsck.k9.activity.compose.RecipientPresenter.setupCryptoProvider(RecipientPresenter.java:748)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at com.fsck.k9.activity.compose.RecipientPresenter.onSwitchAccount(RecipientPresenter.java:314)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at com.fsck.k9.activity.compose.RecipientPresenter.<init>(RecipientPresenter.java:111)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at com.fsck.k9.activity.MessageCompose.onCreate(MessageCompose.java:288)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.app.Activity.performCreate(Activity.java:7149)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.app.Activity.performCreate(Activity.java:7140)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1288)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3017)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3172)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1906)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.os.Handler.dispatchMessage(Handler.java:106)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.os.Looper.loop(Looper.java:193)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at android.app.ActivityThread.main(ActivityThread.java:6863)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at java.lang.reflect.Method.invoke(Native Method)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:537)
06-09 18:50:46.116  6223  6223 E RecipientPresenter: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
06-09 18:50:46.193  6223  6223 I AssistStructure: Flattened final assist data: 7656 bytes, containing 1 windows, 26 views
--------- beginning of system
06-09 18:50:57.694  6223  7765 E ActivityThread: Failed to find provider info for org.sufficientlysecure.keychain.provider.exported
06-09 18:50:57.696  6223  7765 E ActivityThread: Failed to find provider info for org.sufficientlysecure.keychain.provider.exported
06-09 18:50:57.909  6223  7764 E ActivityThread: Failed to find provider info for org.sufficientlysecure.keychain.provider.exported
06-09 18:50:57.911  6223  7764 E ActivityThread: Failed to find provider info for org.sufficientlysecure.keychain.provider.exported
06-09 18:50:58.092  6223  7478 E ActivityThread: Failed to find provider info for org.sufficientlysecure.keychain.provider.exported
06-09 18:50:58.093  6223  7478 E ActivityThread: Failed to find provider info for org.sufficientlysecure.keychain.provider.exported
06-09 18:50:58.334  6223  7492 E ActivityThread: Failed to find provider info for org.sufficientlysecure.keychain.provider.exported
06-09 18:50:58.335  6223  7492 E ActivityThread: Failed to find provider info for org.sufficientlysecure.keychain.provider.exported
06-09 18:51:00.292  6223  6223 I AssistStructure: Flattened final assist data: 7664 bytes, containing 1 windows, 26 views
06-09 18:51:02.747  6223  6223 I AssistStructure: Flattened final assist data: 7680 bytes, containing 1 windows, 26 views
06-09 18:51:05.281  6223  6223 E RecipientPresenter: error connecting to crypto provider!
06-09 18:51:05.281  6223  6223 E RecipientPresenter: java.lang.Exception: bindService() returned false!
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at org.openintents.openpgp.util.OpenPgpServiceConnection.bindToService(OpenPgpServiceConnection.java:105)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at com.fsck.k9.activity.compose.RecipientPresenter.cryptoProviderBindOrCheckPermission(RecipientPresenter.java:761)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at com.fsck.k9.activity.compose.RecipientPresenter.onClickCryptoStatus(RecipientPresenter.java:662)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at com.fsck.k9.activity.compose.RecipientMvpView.onClick(RecipientMvpView.java:402)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at android.view.View.performClick(View.java:6669)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at android.view.View.performClickInternal(View.java:6638)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at android.view.View.access$3100(View.java:789)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at android.view.View$PerformClick.run(View.java:26145)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at android.os.Handler.handleCallback(Handler.java:873)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at android.os.Handler.dispatchMessage(Handler.java:99)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at android.os.Looper.loop(Looper.java:193)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at android.app.ActivityThread.main(ActivityThread.java:6863)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at java.lang.reflect.Method.invoke(Native Method)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:537)
06-09 18:51:05.281  6223  6223 E RecipientPresenter: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

If I manually open OpenKeychain and select my key before using K9 to compose a message, the crypto provider works (at least for this test).
06-09 19:05:01.648  9308  9308 W ActivityThread: handleWindowVisibility: no activity for token android.os.BinderProxy@6deb931
06-09 19:05:01.721  9308  9308 I AssistStructure: Flattened final assist data: 7440 bytes, containing 1 windows, 25 views
06-09 19:05:06.192  9308  9308 I AssistStructure: Flattened final assist data: 7664 bytes, containing 1 windows, 26 views
06-09 19:05:08.495  9308  9331 I MessagingController: Running command 'getFolderUnread:Chris Burgess:INBOX', seq = 11 (foreground priority)
06-09 19:05:08.498  9308  9331 I MessagingController:  Command 'getFolderUnread:Chris Burgess:INBOX' completed
06-09 19:05:08.529  9308  9502 V LockableDatabase: LockableDatabase: Transaction ended, took 1 ms / com.fsck.k9.mailstore.LocalFolder.appendMessages(LocalFolder.java:1285)
06-09 19:05:08.532  9308  9502 V LockableDatabase: LockableDatabase: Transaction ended, took 0 ms / com.fsck.k9.mailstore.LocalMessage.setFlag(LocalMessage.java:257)
06-09 19:05:08.540  9308  9331 I MessagingController: Running command 'sendPendingMessages', seq = 12 (background priority)
06-09 19:05:08.543  9308  9331 D LocalMessage: No headers available for this message!
06-09 19:05:08.543  9308  9331 D LocalMessage: No headers available for this message!
06-09 19:05:08.545  9308  9331 I MessagingController: Scanning folder 'K9MAIL_INTERNAL_OUTBOX' (11) for messages to send
06-09 19:05:08.545  9308  9331 I MessagingController: Send count for message K9LOCAL:12f0bd36-dc5f-4026-b097-a82e3f3bbf9c is 0
06-09 19:05:08.546  9308  9331 V LockableDatabase: LockableDatabase: Transaction ended, took 0 ms / com.fsck.k9.mailstore.LocalMessage.setFlag(LocalMessage.java:257)
06-09 19:05:08.548  9308  9331 I MessagingController: Sending message with UID K9LOCAL:12f0bd36-dc5f-4026-b097-a82e3f3bbf9c
06-09 19:05:08.548  9308  9331 D SmtpTransport: SMTP >>> QUIT
06-09 19:05:08.795  9308  9331 D SmtpTransport: SMTP <<< 220 cat-porwal-prod-mail1.example.org ESMTP Postfix
06-09 19:05:08.817  9308  9331 D SmtpTransport: SMTP >>> EHLO [IPv6:f00f:f00f:f00f:f00f:f00f:f00f:f00f:f00f]
06-09 19:05:08.847  9308  9331 D SmtpTransport: SMTP <<< 250-cat-porwal-prod-mail1.example.org
06-09 19:05:08.847  9308  9331 D SmtpTransport: SMTP <<< 250-PIPELINING
06-09 19:05:08.848  9308  9331 D SmtpTransport: SMTP <<< 250-SIZE 52428800
06-09 19:05:08.849  9308  9331 D SmtpTransport: SMTP <<< 250-VRFY
06-09 19:05:08.849  9308  9331 D SmtpTransport: SMTP <<< 250-ETRN
06-09 19:05:08.849  9308  9331 D SmtpTransport: SMTP <<< 250-AUTH PLAIN
06-09 19:05:08.849  9308  9331 D SmtpTransport: SMTP <<< 250-AUTH=PLAIN
06-09 19:05:08.850  9308  9331 D SmtpTransport: SMTP <<< 250-ENHANCEDSTATUSCODES
06-09 19:05:08.850  9308  9331 D SmtpTransport: SMTP <<< 250-8BITMIME
06-09 19:05:08.850  9308  9331 D SmtpTransport: SMTP <<< 250-DSN
06-09 19:05:08.850  9308  9331 D SmtpTransport: SMTP <<< 250 SMTPUTF8
06-09 19:05:08.851  9308  9331 D SmtpTransport: SMTP >>> *sensitive*
06-09 19:05:08.890  9308  9331 D SmtpTransport: SMTP <<< 235 2.7.0 Authentication successful
06-09 19:05:08.890  9308  9331 D SmtpTransport: SMTP >>> MAIL<EMAIL_ADDRESS>BODY=8BITMIME
06-09 19:05:08.891  9308  9331 D SmtpTransport: SMTP >>> RCPT<EMAIL_ADDRESS>06-09 19:05:08.892  9308  9331 D SmtpTransport: SMTP >>> DATA
06-09 19:05:08.919  9308  9331 D SmtpTransport: SMTP <<< 250 2.1.0 Ok
06-09 19:05:08.950  9308  9331 D SmtpTransport: SMTP <<< 250 2.1.5 Ok
06-09 19:05:09.014  9308  9331 D SmtpTransport: SMTP <<< 354 End data with <CR><LF>.<CR><LF>
06-09 19:05:09.017  9308  9331 D SmtpTransport: SMTP >>> .
06-09 19:05:09.147  9308  9331 D SmtpTransport: SMTP <<< 250 2.0.0 Ok: queued as D27498105C
06-09 19:05:09.147  9308  9331 D SmtpTransport: SMTP >>> QUIT
06-09 19:05:09.177  9308  9331 D SmtpTransport: SMTP <<< 221 2.0.0 Bye
06-09 19:05:09.178  9308  9331 V LockableDatabase: LockableDatabase: Transaction ended, took 0 ms / com.fsck.k9.mailstore.LocalMessage.setFlag(LocalMessage.java:257)
06-09 19:05:09.181  9308  9331 V LockableDatabase: LockableDatabase: Transaction ended, took 0 ms / com.fsck.k9.mailstore.LocalMessage.setFlag(LocalMessage.java:257)
06-09 19:05:09.183  9308  9331 I MessagingController: Moving sent message to folder 'Sent' (-1)
06-09 19:05:09.186  9308  9331 D LocalFolder: Updating folder_id to 8 for message with UID K9LOCAL:12f0bd36-dc5f-4026-b097-a82e3f3bbf9c, id 896 currently in folder K9MAIL_INTERNAL_OUTBOX
06-09 19:05:09.191  9308  9331 I MessagingController: Moved sent message to folder 'Sent' (8)
06-09 19:05:09.196  9308  9331 V LockableDatabase: LockableDatabase: Transaction ended, took 0 ms / com.fsck.k9.mailstore.LocalFolder.destroyMessage(LocalFolder.java:1874)
06-09 19:05:09.204  9308  9331 V LockableDatabase: LockableDatabase: Transaction ended, took 1 ms / com.fsck.k9.mailstore.LocalFolder.destroyMessage(LocalFolder.java:1874)
06-09 19:05:09.206  9308  9331 I MessagingController:  Command 'sendPendingMessages' completed

Hey,
Same issue on my OnePlus too (both on Android 8 & 9), I have to start OpenKeyChain manually before being able to open/write an encrypted email.
It looks like I have just solved by... turning battery optimisation for OpenKeyChain OFF!

That seems to work for me too!
Settings > Apps & Notifications > Special App Access > Battery Optimisation > OpenKeychain > "Don't Optimize"
Nice find :)

Battery optimization does not do the trick for me on my Lenovo Tab P10.
It could have something to do with the Update to Android 9 recently, but I just can't select a key from K9Mail. Clicking on "My Key" just doesn't forward to OpenKeyChain, even after opening OpenKeyChain in the background and turning battery optimization off.

Battery optimization doesn't work for me, either. (Pixel 3aXL, Android 10.

I changed the battery/energy settings as described above, which didn't do the job. I also set openkeychain to autostart.
Then I started the "Security" App on my Xiaomi Redmi Note 8 Pro (Miui global 11.0.3) and had a look at the "additional" permissions. After enabling "show popups while running in Background" the problem was solved. Now connection to the encryption service is available, and I can choose which key I want to use for my accounts.
Battery settings was not enough on my device, if the autostart is really necessary, I don't know.

I was able to solve this problem in Unihertz Titan phone by going into Settings -> Intelligent Assistance -> App Blocker, and selecting OpenKeychain, and disabling the Start blocker option. This apparently enabled K9 mail to launch OpenKeychain, and I can now encrypt.

Battery optimization doesn't work for me, either. (Pixel 3aXL, Android 10.

Doesn't work for me either on Xiaomi Poco F1 MIU 11.0.4 Android 10 QKQ1

I changed the battery/energy settings as described above, which didn't do the job. I also set openkeychain to autostart.
Then I started the "Security" App on my Xiaomi Redmi Note 8 Pro (Miui global 11.0.3/Android 9) and had a look at the "additional" permissions. After enabling "show popups while running in Background" the problem was solved. Now connection to the encryption service is available, and I can choose which key I want to use for my accounts.
Battery settings was not enough on my device, if the autostart is really necessary, I don't know.

Autostart didnt work for me, but "show popups while running in Background" did. Xiaomi PF1 MIUI 11.0.4

Thanks!

I changed the battery/energy settings as described above, which didn't do the job. I also set openkeychain to autostart.
Then I started the "Security" App on my Xiaomi Redmi Note 8 Pro (Miui global 11.0.3/Android 9) and had a look at the "additional" permissions. After enabling "show popups while running in Background" the problem was solved. Now connection to the encryption service is available, and I can choose which key I want to use for my accounts.
Battery settings was not enough on my device, if the autostart is really necessary, I don't know.

Autostart didnt work for me, but "show popups while running in Background" did. Xiaomi PF1 MIUI 11.0.4

it seems that the request for accessing the crypto-excange-part from within k9mail to open easy-key-chain is handled via a pop-up that needs to start in backround and then switches to foreground.
tested with redmi note4 , note 7 and note 9s. k9 mail works now on everyone of them.

This seems to be similar to #2601. Closing this one as duplicate.

I have the same problem on my smartphone. Manually starting OpenKeyChain does solve the problem, at least for that time.
On this Android I found a settings called DuraSpeed, which should preserve battery. If I add an exceptionto for this setting, i.e. selectively disable DuraSpeed for OpenKeyChain, the problem is solved.

Phone: Oukitel WP12
O.S.: Android 11
K-9 Mail 5.804 from F-Droid
OpenKeyChain 5.7.5 from F-Droid

@cketti This is happening now when I try to reply to an email, when I hit the send button.

@cketti This is still happening on v. 5.904 and it's been getting annoying. I hit reply all on an email, write what I need to say to the person and remove a few things from my signature that I haven't changed yet in the settings and then I can't send the email, not even save it. I have to copy the text that I've entered, discard the new email, then hit reply all again and then paste in my text. Remove a few things from my signature and send it again.

@life777eternal: Not being able to connect to OpenKeychain is not a bug in K-9 Mail. Your Android version is preventing K-9 Mail from talking to OpenKeychain. Often there's a way to prevent the OS from sending an app into a standby mode when it wasn't used for a while (see other comments in this thread).
We could change K-9 Mail to simply not use the configured crypto provider when the app can't connect to it. But that could lead to messages that usually would be encrypted to be sent unencrypted. So I'd rather not make this change.
Since the crypto provider isn't working for you anyway, you might as well disable OpenPGP support. That way you will avoid the error message and can reply to messages.
Our long-term goal is to integrate at least Autocrypt functionality in K-9 Mail. That will avoid this whole "not allowed to talk to other app" scenario.

@cketti Thanks for your reply, I've been having that issue again recently, although it didn't appear after I opened OpenKeyChain manually. Also what is "Autocrypt" ?  I hadn't heard of that one before. Thank you.

I have the same problem, and like @life777eternal  I don''t have any 'crypto icon' .
Notice that I have several accounts with exactly the same crypto config (inc. same key)  and switching to a different account usually solves the problem.

What is the update on this issue?

I'm having the same issue. Curiously, Fairmail (by M66B) doesn't show this behaviour, although it uses OpenKeychain (if installed) for encryption as well.

Same issue here, I don't even have OpenKeyChain installed. Encryption is turned off in the K-9 Mail settings. I currently have no way to send email through the app.

quick update: the problem still occurs to me every once in a while (but much more rarely than before).
As I mentioned above, changing the 'sender' to a different account solves the problem. But what I discovered is that even selecting the current sender in the sender drop-down list does the trick! (but I don't know how that works if you have only one account set up)

same for me

Same for me.
Happens about once a month. (Android 12).
Workaround that always works is disabling encryption in Account Settings, the enabling and selecting my key again.
Caveat with this workaround is that you can't save the message you're composing as draft without the active encryption, means you have to copy it beforehand if you don't wan't to type it again.

Please re open, this issue remain active with current versions of all formentioned apps.  Have a nice day

Please re open, this issue remain active with current versions of all formentioned apps. Have a nice day

Fix released in pre-release: https://github.com/thundernest/k-9/releases/tag/6.704

I still have this issue, version 8.0


Fix typos and possible mistakes.

Hi, I found two things you might want to confirm:
First:
Having a smaller word_margin creates **smaller** words.
Did you mean "smaller number of words" or "fewer words"?
Second:
Note that the word_margin should at least be **smaller** than the char_margin otherwise none of the characters will be separated by a space.
Did you mean "larger"?
The PR also includes some typo fixes not mentioned here, for your consideration.

Can you rebase this branch on development? This will fix the cicd failure.

Sorry for the belated response. I changed the base branch to develop. Hope it works!


LinkedIn posting issues

The v0.1 announcement post failed in a couple of interesting ways on LinkedIn:

The link was not included in the post
The text cut off in the 3rd stanza, after 🧵 This post and before (and thread

I've added some tests to rule out the fomatter (it's working fine).
Next step: Test some variants of the release announcement to figure out if there's an issue in the text.
To investigate: Does commentary text need to be encoded?
Here's the code for posting from LinkedInNetwork:
imagesContent = PrepareContent(imagesData);
var postRequestContent = new
{
    author = author,
    commentary = text,
    visibility = "PUBLIC",
    distribution = new
    {
        feedDistribution = "MAIN_FEED",
        targetEntities = new object[] { },
        thirdPartyDistributionChannels = new object[] { }
    },
    content = imagesContent,
    contentLandingPage = message.Link?.ToStringFor(NetworkType) ?? "",
    lifecycleState = "PUBLISHED",
    isReshareDisabledByAuthor = false
};
postRequest.AddJsonBody(postRequestContent);
var postResponse = await client!.ExecuteAsync(postRequest);

This looks a lot like the same issue - text is cut off at brackets (ie. ( and )).

Resolved in release v0.2


Can't restore from backup with EOF error

Hi Team,
I am using Rancher 2.5.5 and rancher-backup operator from rancher/backup-restore-operator:v1.0.3 image.
I have no issues with creating backup, but getting EOF error when restoring from it. All the steps are from the official documentation. Tried encypted/nonencrypted backups, enabling/disabling tls - same error. S3 configuration is set on operator level, so just choosing "default storage location" for both backup and restore.
I see the backup file created in S3 bucket and can access it with same credentials when using s3 cmd.
Please help, and let me know if I can provide more details.
Backup log:
INFO[2021/04/17 18:25:39] Starting resources.cattle.io/v1, Kind=Backup controller
INFO[2021/04/17 18:25:39] Starting resources.cattle.io/v1, Kind=Restore controller
INFO[2021/04/17 18:25:57] Processing backup bk
INFO[2021/04/17 18:25:57] For backup CR bk, filename: bk-a0588334-6eee-4b5d-9440-bcd8d475f1ae-2021-04-17T18-25-57Z
INFO[2021/04/17 18:25:57] Temporary backup path for storing all contents for backup CR bk is /tmp/bk-a0588334-6eee-4b5d-9440-bcd8d475f1ae-2021-04-17T18-25-57Z356083965
INFO[2021/04/17 18:25:57] Processing encryption config encryptionconfig for backup CR bk
INFO[2021/04/17 18:25:57] Get encryption config from namespace cattle-resources-system
INFO[2021/04/17 18:25:57] Using resourceSet rancher-resource-set for gathering resources for backup CR bk
INFO[2021/04/17 18:25:57] Gathering resources for backup CR bk
INFO[2021/04/17 18:25:57] Gathering resources for groupVersion: v1
INFO[2021/04/17 18:25:57] resource kind namespaces, matched regex ^namespaces$
INFO[2021/04/17 18:25:57] Gathering resources for groupVersion: v1
INFO[2021/04/17 18:25:57] resource kind secrets, matched regex ^secrets$
INFO[2021/04/17 18:25:57] Listing objects using label selector owner notin (helm)
INFO[2021/04/17 18:25:57] Gathering resources for groupVersion: v1
INFO[2021/04/17 18:25:57] resource kind serviceaccounts, matched regex ^serviceaccounts$
INFO[2021/04/17 18:25:57] Gathering resources for groupVersion: v1
INFO[2021/04/17 18:25:57] resource kind configmaps, matched regex ^configmaps$
INFO[2021/04/17 18:25:57] Gathering resources for groupVersion: rbac.authorization.k8s.io/v1
INFO[2021/04/17 18:25:57] resource kind rolebindings, matched regex ^roles$|^rolebindings$
INFO[2021/04/17 18:25:57] resource kind roles, matched regex ^roles$|^rolebindings$
INFO[2021/04/17 18:25:57] Gathering resources for groupVersion: rbac.authorization.k8s.io/v1
INFO[2021/04/17 18:25:57] resource kind clusterrolebindings, matched regex ^clusterrolebindings$
INFO[2021/04/17 18:25:57] Gathering resources for groupVersion: rbac.authorization.k8s.io/v1
INFO[2021/04/17 18:25:57] resource kind clusterroles, matched regex ^clusterroles$
INFO[2021/04/17 18:25:57] Gathering resources for groupVersion: apiextensions.k8s.io/v1beta1
INFO[2021/04/17 18:25:58] Gathering resources for groupVersion: management.cattle.io/v3
INFO[2021/04/17 18:25:58] Gathering resources for groupVersion: project.cattle.io/v3
INFO[2021/04/17 18:25:58] Gathering resources for groupVersion: catalog.cattle.io/v1
INFO[2021/04/17 18:25:58] resource kind clusterrepos, matched regex ^clusterrepos$
INFO[2021/04/17 18:25:58] Gathering resources for groupVersion: resources.cattle.io/v1
INFO[2021/04/17 18:25:58] resource kind resourcesets, matched regex ^ResourceSet$
INFO[2021/04/17 18:25:58] resource kind resourcesets/status, matched regex ^ResourceSet$
INFO[2021/04/17 18:25:58] Gathering resources for groupVersion: eks.cattle.io/v1
WARN[2021/04/17 18:25:58] No resources found for groupVersion eks.cattle.io/v1, skipping it
INFO[2021/04/17 18:25:58] Gathering resources for groupVersion: apps/v1
INFO[2021/04/17 18:25:58] resource kind deployments, matched regex ^deployments$
INFO[2021/04/17 18:25:58] Finished gathering resources for backup CR bk, writing to temp location
INFO[2021/04/17 18:25:59] Saving resourceSet used for backup CR bk
INFO[2021/04/17 18:25:59] Saving information about resources with status subresource that are part of backup CR bk
INFO[2021/04/17 18:25:59] No storage location specified, checking for default PVC and S3
INFO[2021/04/17 18:25:59] Compressing backup CR bk
INFO[2021/04/17 18:25:59] invoking set s3 service client               s3-accessKey=<my_key> s3-bucketName=RancherBackup s3-endpoint=<my_s3_endpoint> s3-endpoint-ca= s3-folder= s3-region=<my_s3_region>
INFO[2021/04/17 18:26:04] invoking uploading backup file [bk-a0588334-6eee-4b5d-9440-bcd8d475f1ae-2021-04-17T18-25-57Z.tar.gz.enc] to s3
INFO[2021/04/17 18:26:04] Successfully uploaded [bk-a0588334-6eee-4b5d-9440-bcd8d475f1ae-2021-04-17T18-25-57Z.tar.gz.enc] of size [284823]
INFO[2021/04/17 18:26:04] Done with backup
INFO[2021/04/17 18:26:04] Processing backup bk
INFO[2021/04/17 18:26:04] Backup CR bk has been processed for one-time backup, returning

Restore log:
INFO[2021/04/17 18:26:25] Processing Restore CR restore-6bkbf
INFO[2021/04/17 18:26:25] Restoring from backup bk-a0588334-6eee-4b5d-9440-bcd8d475f1ae-2021-04-17T18-25-57Z.tar.gz.enc
INFO[2021/04/17 18:26:25] Processing encryption config encryptionconfig for restore CR restore-6bkbf
INFO[2021/04/17 18:26:25] Get encryption config from namespace cattle-resources-system
INFO[2021/04/17 18:26:25] invoking set s3 service client                s3-accessKey=<my_key> s3-bucketName=RancherBackup s3-endpoint=<my_s3_endpoint> s3-endpoint-ca= s3-folder= s3-region=<my_s3_region>
ERRO[2021/04/17 18:26:27] failed to list objects in backup buckets [RancherBackup]: EOF
ERRO[2021/04/17 18:26:27] error syncing 'restore-6bkbf': handler restore: EOF, requeuing

(I edited out your registry since I doubt your employer would appreciate publishing it...)


[Feedback] IIS Express launch profile not used

Created from https://vsfeedback/comment/803555
In some cases when I create a new ASP.NET Core project and open it in VS the IIS Express launch profile doesn't get used when I hit F5.
Repro steps:

mkdir iisexpresslaunchprofilerepro
cd iisexpresslaunchprofilerepro
dotnet new sln
mkdir testproject
cd testproject
dotnet new web
cd ..
dotnet sln add testproject/testproject.csproj
Open iisexpresslaunchprofilerepro in VS
F5
Expected result:

Runs using IIS Express
Actual result:
The launch button shows the IIS Express launch profile, but the project runs as a console project instead
Workarounds:
Switching the selected launch profile between the project launch profile and the IIS Express launch profile seems to resolve the issue

This is a consequence of the 2nd item in issue https://github.com/dotnet/roslyn-project-system/issues/495. Updates tot he profiles need to be serialized.

@BillHiebert @srivatsn This is in 15.1 milestone, do we want to move this to 15.2 or 15.3?

This has been fixed by @BillHiebert


addPlottingFactor with NanoStringGeoMxSet version

This issue occurs when any samples in the overlay are not in the geomx set object, within the addPlottingFactor w/ NanoStringGeoMxSet type input. I don't know whether it occurs in other circumstances.
Start of this "if" block:
https://github.com/Nanostring-Biostats/SpatialOmicsOverlay/blob/a78d1bb386ff16daa3f83de907e6e7868c4bb9f0/R/addPlottingFactor.R#L89
Expected behavior: the code subsets the gxtSamples object to only include those present in the samples object.
Observed behavior: Not sure exactly what is happening, but we're subsetting gxtSamples to just one sample, and not one that's relevant for the slide at hand. The addPlottingFactor function overall fails to add a plotting factor, and sampNames(overlay) becomes character(0).
Maddy did some investigating and determined this is due to how the code is handling the presence of two columns in the sData(annots) object that have Sample IDs in them. We suspect this may be due to changes in R syntax. This behavior was observed using Rv4.3.0 x86_64-pc-linux-gnu.

I'm seeing a similar phenotype with data.frame as the input annots object.

@mgrout81 I have fixed this in both data.frames and geomxset objects. Just to be safe, I took the column with the highest match rate between the annotations and the overlay object. This change went into the v1.1 branch.


[Docs]: Update - Local DB and APIs

Is there an existing issue for this?

[X] I have searched the existing issues

Documentation Link
https://docs.appsmith.com/advanced-concepts/more/how-to-work-with-local-apis-on-appsmith
Discord/slack/intercom Link
https://theappsmith.slack.com/archives/C0341RERY4R/p1663575620132859
Describe the problem
The user was trying to connect to the DB server hosted on the same machine as Appsmith. Hence they initially used localhost as the IP address, but when that didn't work they tried to use their server name as the IP address which was not correct.
Describe the improvement

Make the doc comprehensive to add more details and a summary for the embedded videos.
Use search terms that users are looking for so that the doc can be bumped up the search results. (At present the doc is not available in the top 3)

Why do you think this change is needed?

The doc is not available in the top 3/5 search results, so discoverability is a problem.
Though the embedded video is helpful and will help users resolve the issue, adding a summary of the video and steps to the doc will be helpful for users.

@sumitsum - Please add more details, if I've missed anything.

Adding to what is mentioned in the description:

The main heading for the page that contains the info is Local DB and APIs - Can we change this to include the following two phrases / words: connect to local DB , localhost ?
Can we change the order of the solution mentioned on the page i.e shift the ngrok solution down and pull up the other solution since that one is easier to implement vs the ngrok solution.

@sumitsum - These changes are done as part of quick fix.

The localhost term is added to the page and sub section.
The restructuring of the content is done and raised a GitBook CR for your review.
Do you mean to change the heading of the page from Local DB and APIs to Connect to localhost

@sumitsum - The quick fix doc is published:
Following are the quick fixes:

Discoverability issue is resolved (doc is listed in top 3):
- Title changed
- localhost keyword added to title
- doc content
Restructing of the content
- Subheadings added
- host.docker.internal
- ngrok
- host.docker.internal section moved up for helping users quickly resolve issues

The PR is ready for review


Can't decode starfish xtf data

Currently obtain segmentation fault when trying to decode starfish xtf data.
Probably need to add data structs to XtfParser.

I can confirm that this is not a missing datagram issue, it clearly contains the ID 0 datagrams for sidescan data. It does not contain position or attitude datagrams though. Just like the plane example
glm@Omega:~/src/MBES-lib$ ./build/bin/datagram-list test/data/xtf/plane-sidescan2d.xtf |sort|uniq -c
Decoding test/data/xtf/plane-sidescan2d.xtf
   2009 0
glm@Omega:~/src/MBES-lib$ ./build/bin/datagram-list test/data/xtfStarFish/22_07_2020_C1.xtf |sort|uniq -c
Decoding test/data/xtfStarFish/22_07_2020_C1.xtf
   3617 0

I can decode them perfectly using the latest version of opensidescan updated to the latest MBES-lib dependency.

Closing this as a non-issue until it can be reproduced. Also, I'm going to leave a single XTF file as a starfish example only.

Nice!
I just realised I used georeference executable and that is why I got segfault.


Underscore and dot should be removed from the variables references labels

Expected Behavior
Long story short: https://github.com/Kong/insomnia/issues/2942 - this ticked was closed and wasn't re-opened. There are certain observations related. Since the issue remains I believe a new ticked should be created.
Here some points:

Combination of underscore and dot is a part of internal implementation and should not be printed out on labels by default
There are no obstacles to use reference without this ugly prefix, simply typing {{VarName}} and this should be default behaviour
Underscore and dot was introduced to resolve very specific issue which is not commonly used and because of that it should be optional
Everybody agree that this is simply looks "dirty" and "ugly" inside such a beautiful product as Insomnia is.

Actual Behavior
All variables are prefixed with "_." by default
Reproduction Steps
No response
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
2023.2.0
What operating system are you using?
macOS
Operating System Version
macos
Installation method
download from official website
Last Known Working Insomnia version
No response

What should happen here IMHO, is:

A setting added: use '_.' prefix for every variable, default to off
Auto-complete should offer '_,' prefix only for variables that need it with the setting above set to off


Reorganize how files are saved

Looking at the data, we need to improve our strategy to store files.

We need another naming scheme for the dependency files. And a the same time, potentially fix the issue which is storing undefined.json currently.
I don't see why the dependencies files are stored as a stringified JSON object. It should just be the original file.
Would be great if the dependencies.json would be pretty formatted.
The permissions on S3 needs to be double checked.

We need another naming scheme for the dependency files. And a the same time, potentially fix the issue which is storing undefined.json currently.

Our current naming scheme is using the project name within package files but I think it is not consistent now with other languages package files, this is undefined because the composer.json does not have project name in it's content unlike npm package.json.  Another option is to use actual repository name but there might be cases where a repository has more than 1 package files and we don't want them overwriting each other. To fix the undefined.json will be to use a uuid when package name is unavailable.

I don't see why the dependencies files are stored as a stringified JSON object. It should just be the original file.

In my attempt to save it directly I got error below from s3
(node:30192) UnhandledPromiseRejectionWarning: Error: Unsupported body payload object
but dependencies.json can be saved directly.

Would be great if the dependencies.json would be pretty formatted.

Definitely can better, currently we have
{
   "profile":true,
   "files":{
      "AbiHome-test":{
             "private":false
           },
         },
   "objectKeys":[ "flickz/abihometest.json" ],
   "excludedRepos": [ ],
    "selectedDependencies": [ ],
}

Maybe we can this instead:
{
"profile":true,
   "object": [
           {
             "name":  "AbiHome-test",
              "private": false,
               "key": ["flickz/abihometest.json" ]
           },
     ],
   "excludedRepos": [ ],
    "selectedDependencies": [ ],
}

For me, the clearer naming scheme should be `{githubProfile}/{githubRepository}/{pathToFile}/{filename.extension}. You need to figure the error while saving, the file should be saved "as it is".
When I mentioned pretty printing, I saw no indention whatsoever in the saved file currently. You should just pass an indentation of 2 spaces to Stringify and we should be good to go.

{githubProfile}/{githubRepository}/{pathToFile}/{filename.extension}

What is the pathToFile to file here?

@flickz The same path than in the GitHub repository. If I'm not mistaken, in most cases, empty or / depending on how you see it.


test crash

Crashlytics.sharedInstance.crash();
it says Crashlytics does not contain any definition for 'crash'
Does anyone know what we can use instead of this?

throw new NullReferenceException("test firebase");


Sign the agreement (multiple times) but project says it still is not signed

https://github.com/alibaba/freeline/pull/985
I sign multiple times, but the second still not work

@wyy912 you can ignore the second comment. Since the status of the PR is green, everything is ok.
Actually there should be only one comment from CLA assistant. I'll take into consideration that there is probably a bug on our side.

thank you so much