Automatically send verification email upon account creation

Hi!
I'm new to GitHub, but would really love to contribute my two cents.
I want to add a new boolean parameter to FlowParameters.java called sendVerificationEmail which could be implemented in the registerUser method of RegisterEmailActivity.java . My plan is to add
     //Send verification email
      if (mActivityHelper.getFlowParams().sendVerificationEmail) {            firebaseUser.sendEmailVerification();       }
in  .addOnSuccessListener .
Then I could just code
startActivityForResult(
AuthUI.getInstance()
.createSignInIntentBuilder()
.setIsSmartLockEnabled(true)
.sendVerificationEmail(true)
.setProviders(AuthUI.EMAIL_PROVIDER)
.build(),
RC_SIGN_IN);
in my activity.
I've found that it is really clunky to try to catch a result showing that the user created a new account, because I am only using the AuthUI.EMAIL_PROVIDER.
Also, what do you think would be the best way to notify the user to check their email account and verify? I thought about changing
<string name="progress_dialog_signing_up">Signing up…</string>
to
<string name="progress_dialog_signing_up">Sending verification email to</string>
and change line 255
mActivityHelper.showLoadingDialog(R.string.progress_dialog_signing_up);
to
mActivityHelper.showLoadingDialog(getResources().getString(R.string.progress_dialog_signing_up) +                 " " + email);
Thank You,
Winston

Thanks for the idea(s) @forneverafter .
I think what you're saying is a totally valid feature request, but I think it exposes a larger need.  In general, I think FirebaseUI could do a better job returning more information to the app at the end of the flow (did the user sign up?  Was it a new account?  What provider was used?  etc).  Rather than add boolean parameters for each option a developer might want, if we return more information at the end of the flow you could then do things like send verification email yourself.
Would getting more information about new vs existing account as a result of the sign-in flow solve your use case?

 I think it makes way more sense to pass this back as a key/value in an Intent to onActivityResult. That will work perfect for me, but I do think sending a verification email is par for the course in email authentication. Thanks and I can help in whatever way necessary.

I think this could be part of v2:

#309 (anonymous authentication)
#357 which breaks the public api but makes things much faster and prettier and #374
As part of the #357 public api rewrite, we could directly return IdpConfig and include methods such as getPrevUid() for #309, isNewUser() for this issue and so on.

Marking this as a duplication of #312 that's the earliest issue to track email verification requests.


Remove GRPC_CLOSURE_LIST_SCHED and remove scheduler field from grpc_closure

This PR makes two changes -

GRPC_CLOSURE_LIST_SCHED() and is replaced with grpc_core::ExecCtx::RunList().
scheduler field is removed from grpc_closure. No more scheduler!!

Note that currently grpc_schedule_on_exec_ctx still exists, but it is unused and undefined. It is just marco'ed out from GRPC_CLOSURE_INIT and GRPC_CLOSURE_CREATE. In a subsequent PR, I'll be able to remove the last scheduler field from GRPC_CLOSURE_INIT and GRPC_CLOSURE_CREATE.
IMPORTANT : THIS PR NEEDS INTERNAL CHANGES

This change is

issue : #21198
Thanks for reviewing!


Recommendation: Training failed when choosing "timestamp" column as "Label" for SQL Server data.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-21H2
ML.Net Model Builder 2022: <IP_ADDRESS>2001 (Main Build)
Microsoft Visual Studio Enterprise: 2022(17.4.5)
.Net: 6.0
Describe the bug

On which step of the process did you run into an issue:
Training failed when choosing "timestamp" column as "Label" for SQL Server data.

Data Source
https://testpass.blob.core.windows.net/test-pass-data/iris.mdf
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio 2022 start window.
Choose the C# Console App (.NET Core6.0) project template.
Add model builder by right click on the project.
Select Recommendation scenario.
On Data page, select the SQL Server data source, then choose "timestamp" column to predict(Label), choose "userId" as User column, choose "movieId" as Item column.
On the Train page, you will see that training fail with error "Splitter/consolidator worker encountered exception while consuming source data".

Expected behavior
Training successful.
Screenshot

Additional context:

The bug has been fixed on the latest main build <IP_ADDRESS>0602.


StopInfo incorporation improvements

Hi all,
I've been meaning to get to this for awhile, but unfortunately with starting a new internship and moving to the Bay Area I got a bit distracted. Anyway, I wanted to make sure I documented some of the feedback I've gotten about StopInfo's incorporation into the iOS app before I forget. Unfortunately I don't think I'll have time (at least for awhile) to work on these myself, but I'm glad to provide high-level assistance where I can.
Here are some ways I think we can improve integration with OneBusAway:

A better button icon and/or placement of button in app. This has been the most common request from general users as well as users with disabilities. The current icon (without high contrast mode enabled) is difficult to see due to its thin weighting and contrast with the map behind it. It is also difficult to tap for persons with motor impairments or people with smaller screens. The feedback about it being an info button has been mixed - some say that having it be the standard Apple info button was straightforward enough -- others said it was confusing because they thought they were already on the bus info page (bus arrivals). As it is currently, it does not have any indication that it leads to information about the physical bus stop. Perhaps an icon showing a bus sign and shelter could be more intuitive? Open to suggestions here.
We've also discussed taking out the redundant "About this Stop" table cell (#386), but I only recommend this if we improve the button design first (see this comment).
As noted in #384, the logic for displaying the info and 'About this Stop' button should be matched so that neither are displayed for regions that don't (yet) support StopInfo.

Better navigation/routing within the web view controller. Currently we only have a single 'Back' button in the StopInfo web view, which worked decently well when StopInfo was small, but has become more complicated now that StopInfo has grown to include more pages. (This was discussed initially in #280.) It gets messy when a user logs in or goes to edit a form and then has to go through several pages (I think sometimes including a form resubmission or an error after they've already signed in) to get back to the bus arrival times view. I am not sure if it would be useful to separate the Web back button and app back button again or to do some fiddling with the routing (probably web-side). Anyway, listing this here for reference/opinions.

Pull applicable fields into OBAGenericStopViewController. This will probably have to come in to play if/when StopInfo produces an API, but wanted to throw it out there in case anyone is especially interested in taking this on. We've had requests for displaying reported stop closures on the arrival times page, as well as other fields from StopInfo that perhaps people could specify, or possibly notifications for information needs or requests (a feature currently being built into StopInfo where people can request information for particular stops) for that particular stop. From the survey, people indicated they would be more likely to contribute if they saw a request for information on the arrival times page while they were waiting for their bus.

Those are the main things I can think of for now. If anyone can think of things to add, let me know and I'll update the list accordingly. I would probably open a new issue (if one is not open already -- I tried to link relevant issues to each point) if you'd like to work on one of these items in particular.

I had a nice reply typed up that Chrome/GitHub decided to lose so the short version:

I'd like to see an API for native integration. Web view could still be used for editing (FourSquare does this).
I'd like to see suPport for crowdsourcing dats for not yet supported regions.
Before an API is added https://github.com/TransitApp/SVWebViewController or something like the Facebook link popup may work better than the current web view.

re @bbodenmiller's comments: :+1:

Thanks @bbodenmiller. Copying @alanborning and @meganca here to see if they have anything to add.

ping @alanborning and @meganca — is there a native API for StopInfo?

No native API for StopInfo.  It would be a good thing to have, but no
immediate plans to add it.  (Currently nobody is working on StopInfo -
Caitlin and Meg have both graduated.)

StopInfo is dead, sadly.


Force-wrap words that are wider than the provided width

I need to be able to force-wrap words that are wider than the provided width.

Like this algorithm does: https://codepen.io/peterhry/pen/AGIEa

This is a good idea.  Would you like to send a PR?  I think you just need to modify the wrap function:
https://github.com/sffc/word-wrappr/blob/master/lib/wrappr.js#L85


using certutil over powershell

Description
Converted to using certutil over powershell
Issues Resolved
The powershell functions used in this resource do not work on windows 2012R2. This solves that problem, and also gives us the ability to converge better for create 'add', and delete

Hmm. Our integration tests in https://github.com/chef-cookbooks/windows/blob/master/test/cookbooks/test/recipes/certificate.rb runs on 2012R2. Can you include changes to those tests to capture the incompatibility?

I think I might have had an old cookbook cached that was causing the .ctor error. As when I tried to recreate it for a long explanation, I can't know.
The interesting thing here is I had written this code over a year ago (https://github.com/chef-cookbooks/windows/pull/167) and it didn't take off. I eventually closed the PR.
Eitherway, this allow us to now converge properly instead of forcing it like we are now as it addresses some of the comments in the code.


Sinus Zero offset

Thanks for sharing this tool.
When i meas. a sinus of 1V on A0, it cut off 1/3 of the curves buttom
If i then changes to 50mV i shows right.
if i increase to 100mV it shows right, but start cutting buttom again within 5 sec.
I have also tried with a capasitor in series and an completely seperate generator.
Squrewave with ref. to Zero shows right, though the V scale is wrong if you
input 10Khz 4V - and choose 500mV/div and 101uS/div, it shows only 2.5V
I have a normal scope, it show everything right.

Hi! Yes the adc of the lgt328p has some limitations when used at high speeds. I should have made those more clear in the UI.
Also you can't measure voltages below gnd (you can put a cap in series and add a 2.5 v reference between A0 and the cap. For that, you can use a voltage divider, just pick high values like 100k to avoid attenuating the signal


Why zombie does not work with localstorage?

I see that Zombie has functions to work with local storage, but i can not set, or get, or remove items, like in plain browser (Chrome or Firefox). How does it works?
When i wrote browser.localStorage.setItem('token', '123');  i see TypeError: browser.localStorage.setItem is not a function

Thanks!

Just went through this problem as well. Any reason why it's not in the docs ?


Add BC shim for template lookup in former directories.

Follow https://github.com/propelorm/Propel2/pull/1848
Just to make sure we ease the upgrade issues here for folks that use behaviors or other custom repositories with extension and templates.

Codecov Report

Merging #1855 (86da93a) into master (d4c4392) will decrease coverage by 0.03%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##             master    #1855      +/-   ##
============================================
- Coverage     87.84%   87.81%   -0.04%
- Complexity     7766     7769       +3
============================================
  Files           226      226
  Lines         21043    21053      +10
============================================
+ Hits          18486    18488       +2
- Misses         2557     2565       +8

Flag
Coverage Δ

5-max
87.81% <25.00%> (-0.04%)
:arrow_down:

7.4
87.81% <25.00%> (-0.04%)
:arrow_down:

agnostic
67.09% <25.00%> (-0.03%)
:arrow_down:

mysql
69.08% <25.00%> (-0.03%)
:arrow_down:

pgsql
69.10% <25.00%> (-0.03%)
:arrow_down:

sqlite
66.92% <25.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Propel/Common/Util/PathTrait.php
67.85% <25.00%> (-26.59%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c4392...86da93a. Read the comment docs.

Could someone dev-qa and approve this please?
@mringler @oojacoboo etc

Logic seems okay, but I don't fully know what input and output to expect here, so it's hard to give it much scrutiny.

You can see the linked pr for previous template paths


Assignments only updating on certain policy types

Hey!
I am having issues with getting assignments to be properly updated through IntuneCD.
I have 10 tenants connected to one baseline tenant, and assignments either only work on some settings categories, or not at all.
Backup is running through an Azure DevOps Pipeline, but we do updates through IntuneCD Monitor. The tenants are set up in IntuneCD Monitor with the update argument "-u". Assignments work fine on policies with the "Settings Catalog" policy type, as well as Security Baselines and some of the other categories under the security blade in Intune.
However i cannot seem to get it to update assignments for any of the other policy types under "Device Configuration", such as "Endpoint Protection", "Device Restriction", or "Custom".
On one of the tenants, no assignments at all were imported.
I can see in the backup files that the assignments are exported. I have also tried updating through an Azure Devops pipe, but the results are the same.
Do you have any idea why this is, and any steps we can take to remediate the issue?
På förhand, tack!

Hi, does the groups you are targeting exist in the tenant you are running the update towards? if the groups does not exist (checked by name) assignment will simply be skipped. If you want to create non-existing groups you can use the -g parameter.

Yes, the groups exist with identical names in all tenants.

Can you see more information when running with -v to get some verbose output?

Here is an example of the error i get on the policies failing to update assignments:
Mon May  6 13:32:08 2024 [ERROR] Error updating Device Configuration Mandatory - MacOS_BackgroundServices: Request failed with 400 - {"error":{"code":"BadRequest","message":"{\r\n  "_version": 3,\r\n  "Message": "The assignment and its target should not be null. - Operation ID (for customer support): 00000000-0000-0000-0000-000000000000 - Activity ID: b6e47704-b1a0-4f1a-a9e3-b0dd216ed0a8 - Url: https://fef.msub06.manage.microsoft.com/DeviceConfiguration_2404/StatelessDeviceConfigurationFEService/deviceManagement/deviceConfigurations('81dfaa63-1805-465d-a0bf-d5694c132557')/assignments?api-version=5023-12-15",\r\n  "CustomApiErrorPhrase": "",\r\n  "RetryAfter": null,\r\n  "ErrorSourceService": "",\r\n  "HttpHeaders": "{}"\r\n}","innerError":{"date":"2024-05-06T13:32:08","request-id":"b6e47704-b1a0-4f1a-a9e3-b0dd216ed0a8","client-request-id":"b6e47704-b1a0-4f1a-a9e3-b0dd216ed0a8"}}}

Thank you, is this for a custom macOS policy?

Yes, correct. The same error ("The assignment and its target should not be null") also occur on policies with the policy type Device Restrictions, Wi-Fi, Delivery Optimization, and Custom, all of which are Windows policies.

I was able to replicate and it seems like the assignment endpoint has changed for device configurations. I was able to successfully update assignments using IntuneCD 2.2.3-beta1, try this version and report back: pip3 install IntuneCD==2.3.3b1. Note that you cannot test this in IntuneCD Monitor but instead it must be tested in a pipeline or running locally.

Just tested, and assignments updated as expected. Great!


"Build a team!" button, but I already have teams

How do I remove this nag? I have several teams functioning already.

Can you include more of the screenshot?

@maxtaco Sure, here's an example where I have at least 1 team active, including 3 members.

The bug is still here. I have 2 teams, but after new update it still occupies screen estate and invites me to create a team. Why do UI designers make interface cluttered?


Add example of setting a response header

As far as I can tell, there are no examples of how to set a response header for the new 2.0 version. It would be helpful if the "Hello World" example showed how to set a header, or in the Request Response Strategy page too.

This is a difficult one as league/route isn't responsible for that, whichever PSR-7 implementation is. So if I were to start showing examples of dealing with the HTTP layer I would have to give an example of everything.
The answer for this particular question can be found here https://github.com/zendframework/zend-diactoros/blob/master/doc/book/usage.md#manipulating-the-response


WIP - DO NOT MERGE Install Chocolatey

[x] Dependency on powershell / stdlib
[x] Need installer template
[x] Manifest details
[x] Add templated values
[x] refresh path changes - dependency on windows_env
[x] Delay suitability check - https://docs.puppetlabs.com/guides/provider_development.html#suitability
[x] add ability to specify custom install location
[ ] specs
[x] Look at #62

This is related to #61. This supersedes #24.

Any reason there isn't an init.pp file? It's very Puppet-paradigm aligned to want to include chocolatey.

Any reason there isn't an init.pp file?
@reidmv What would you see in that? :)

I will mod this too.

What does that mean @rismoney ?

@ferventcoder what the current chocolatey::install class does is effectively what I would expect a chocolatey class to do. Whatever the implementation, an init.pp defining a chocolatey class gives me a declarative user experience where I describe a thing I want, without getting into a mindset where I'm thinking about procedure or action necessary to create or implement the described state.

Not change functionality, just refactoring a little.  Add rspec, not use erb, and some tweaks.

@reidmv the install of a thing I've seen in install.pp files as a puppet convention, whereas the init.pp I've seen typically manages execution of the thing. Since choco is a custom type/provider, execution is relegated to the provider. Am I off on this?

this is what i was thinking for the erb-
https://github.com/rismoney/puppet-chocolatey/commit/f95f5e35b03c5e73075a0a2e0f6b3b2c241920f8

@ferventcoder using an install.pp is part of a module internals pattern most formally described by R.I. Pienaar in 2009 and redux'd in 2012. It's typically used to break apart an overall configuration into sub-classes for ease of implementation.
When the pattern is used, the *::install, *::configure and *::service classes are typically considered private internals, and not classes users should apply directly. See this example from the puppet/mcollective module of that private status being enforced. In newer code classes can use the assert_private() function from puppetlabs/stdlib instead to more elegantly enforce the same thing.
If you wanted to use that pattern, an init.pp might be created that looked like the following, and the existing chocolatey::install class modified to reference the parameters set here rather than take parameters itself (that and the assert_private() function added):
class chocolatey (
  $chocolatey_download_url = $chocolatey::params::download_url,
  $use_7zip                = $chocolatey::params::use_7zip,
  $choco_install_location  = $chocolatey::params::install_location,
  $choco_install_timeout   = $chocolatey::params::install_timeout,
) {
  contain chocolatey::install
}

Given that this is not an overly complex module yet, that pattern make sense yet. It might be clearer and more straightforward just to have a single chocolatey class right now. At this point it's all internals. The user still only interacts with a class named after the thing they want to configure, whether it's a single class or broken into contained subclasses is implementation detail.
The issue description in PUP-4638 talks a little bit about class names too and is loosely analogous.

@reidmv thanks! I read those articles, and TIL. I will add in an init.pp - it all makes perfect sense in the way that it was written. :)

@rismoney I left comments, but overall, I like that approach.

@reidmv added the init class.

@ferventcoder awesome! One further note:
Unless things changed in Puppet 4, in the init.pp it actually is important to use contain chocolatey::install stanza rather than just class { 'chocolately::install': }. This has to do with transitive dependency behavior. With contain, things will work as expected when resources elsewhere in the catalog specify a before or require dependency against Class[chocolatey]. At least in Puppet 3, if you did it the other way I don't think it would actually contain the child class.

Unless things changed in Puppet 4, in the init.pp it actually is important to use contain chocolatey::install stanza rather than just class { 'chocolately::install': }.

@reidmv I noticed this pattern - https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/master/manifests/init.pp#L41-L47
I'm looking for the greatest compatibility (Puppet 2.7.0+), so I think I need to be careful around using contain.

I'll probably bump that to v3+, but the same applies.

If you need compatibility with Puppet pre-contain() the only other fully functional alternative is the anchor pattern. The semantics of contain are:

A contains B means that any resource C that requires A will only be executed after B is executed as well as any resource D that is required by A will be executed before B is executed.

Check out https://www.youtube.com/watch?v=jvDLXykcxiA for a visual look at the semantics in graph form. Watch up until about 6:40, the rest is meh.
The following are equivalent options that accomplish containment semantics:
The most elegant both in terms of code and resulting graph:
contain chocolatey::install

The example you linked to does class declaration separately from containment in order to also establish relative ordering of multiple classes. You don't need to do that since you only have one class, but this is what it would look like. See also PUP-4946, which talks about why this is done (and suggests adding a feature to the contain function to make it unnecessary):
class { 'chocolately::install': }

contain chocolately::install

This was pretty much the only way to establish containment semantics prior to contain():
anchor { 'chocolatey::begin': } ->
class { 'chocolately::install': } ->
anchor { 'chocolately::end': }

I would recommend just using contain, or alternatively putting the resources directly in the init.pp so as to avoid having to deal with containment. contain() is supported in Puppet 3.4.0 and higher. If there's a compelling reason to support Puppet versions less than 3.4.0, you could do a first cut with the anchor pattern, then major version bump to start using contain. Given that this is a Windows-specific module it seems likely to me that there aren't going to be many users actually running Puppet < 3.4.0.
(P.S. there's a Puppet Labs internal doc here that includes a graph picture of what the anchor pattern looks like in the comments section.)

@reidmv look again, there are now two classes, so anchor/contain apply

@ferventcoder ah, yep, so it is! Sorry for the superfluousness of my last comment; I read your note but didn't read the updated code. Everything makes sense now. :blush:

It's looking good. Install of Chocolatey and install of packages in the same run -

well done-woot!!!

Release train is rolling right now :)

It's live - https://forge.puppetlabs.com/chocolatey/chocolatey/1.1.0/readme


Pagination phase 2

Paginates content-items by utilising the pagination functionality from the publishing-api. Uses the Kaminari gem for pagination related styling.

Basic pagination functionality works well. However, when I tried using per_page = 10 I only saw 4 documents (same with other numbers). It may be some sort of filtering at publishing-api level.
cc @dougdroper

@christophwong sure, let's look at this together.

Hi,
Looked at this with @dougdroper on Friday to see if there could have been anything implemented on publishing-api that could have caused extra filtering on some finders. When testing on Doug's environment he was receiving the correct number of paginated content items. We deployed the branch to integration to try and figure out if the mis-match in number of results on @christophwong's local environment was due to a data mismatch and it worked fine on there so I think all is ok.
I have only implemented pagination for finders, not manuals. I will do that now on a separate branch and PR.

This seems good, now I've understood why we're doing page.to_i.to_s. 👍


new to CVAT. drawing polygon

I have loaded a picture.
kept--> Annotation-->Polygon.
pressed N (Captial N)
I am not able to get the option to mark.
I tried left click as mentioned in https://www.youtube.com/watch?v=XTwfXDh4clI
and saw this also...
https://github.com/opencv/cvat/blob/master/cvat/apps/documentation/user_guide.md#annotation-with-polygons
am I missing anything please ..when I press left the image is also moving

@newmluser , please in chrome browser click F12 and see "console". Let's know if you see any errors.

Resolved on gitter


Request authentication not call when user attemps to npm update

install works call 1st authenticate route and then acess route

npm update only calls access route

@Yvtq8K3n ... images barelly can be displayed. Please fill the following
**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Docker || Kubernetes (please complete the following information):**
 - Docker verdaccio tag: [e.g. verdaccio:beta]
 - Docker commands [e.g. docker pull ...]
 - Docker Version [e.g. v18.05.0-ce-rc1]

**Configuration File (cat ~/.config/verdaccio/config.yaml)**

**Debugging output**
 - `$ NODE_DEBUG=request verdaccio` display request calls (verdaccio <--> uplinks)
 - `$ DEBUG=express:* verdaccio` enable extreme verdaccio debug mode (verdaccio api)
 - `$ npm -ddd` prints:
 - `$ npm config get registry` prints:

**Additional context**
Add any other context about the problem here.

I was still updating;_;

For some reason im not getting this error anymore...


Fix margins for header, profile and display

Description
The margins of the header elements and margins between buttons below have been fixed. It doesn't look cluttered in the mobile view now.
Fixes #88
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Resultant Change

Conflicting files
src/components/Profile.js
Can u resolve these?

Done


Add test to verify correct distribution of CartoCSS

Just a simple check to make sure we (I) don't add an outdated version.

There has been no activity on this issue for several months and that's why are closing it (automatically). If you think this still needs to be addressed please reopen it. The good news is that we are now working on the next version of CARTO.js, stay tuned.


GET Error Deep Nested Entities with only column Names

I have 3 tables (programme,kras,kpis)
Relationships are as follows
programme -> kras.programme -> kpis.kra
The following get request works (deep nest with foreign table names):
http://localhost:3000/kpis?select=*,kras{*,programmes{*}}
and this get works (single nest with column name)
http://localhost:3000/kpis?select=*,kra{*}
this however does not (deep nest with column names)
http://localhost:3000/kpis?select=*,kra{*,programme{*}}

Please provide the full table definitions, the requests you are making (that is already present), the generated query (turn on query logging in postgresql) and the error you get for the request that is failing then we can build on that...

@coach1001 have you figured out this problem, or still having trouble?

No reply for a long time, since then, however, a few bugs were fixed since then.
PS: try to avoid * always specify the full list of columns and try to always include the id of rows because of #411 bug


TradeStatistics - Replace IEnumerable for List

Description

Replace IEnumerable for List

Related Issue

Closes https://github.com/QuantConnect/Lean/issues/5622
Motivation and Context

Python can access trade statistics
Requires Documentation Change

N/A
How Has This Been Tested?

Running reported algorithm
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Closing in favor of https://github.com/QuantConnect/Lean/pull/5640


Config section for which locus timepoints group with which regional timepoints

This could be an additional filter for some faulty data points

The config section of this is done, this is now to be used by things like #237


Will scenario one work without NAT on the NVA / Firewall?

Reading through the examples on how to route to private endpoints through Azure firewall or a third party NVA, how does the service endpoint know to send the return traffic through the Azure Firewall or NVA in scenario one. Is this actually possible without some form or source NAT on the Azure FW or NVA?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4038a691-c584-2c36-24c5-fa91a5be474a
Version Independent ID: c6bd0573-22ef-f1d5-5553-000bd8f8c1bd
Content: Use Azure Firewall to inspect traffic destined to a private endpoint - Azure Private Link
Content Source: articles/private-link/inspect-traffic-with-azure-firewall.md
Service: private-link
GitHub Login: @jocortems
Microsoft Alias: allensu

@bhicks329 Thanks for the question. We're investigating this and will get back to you shortly.

@bhicks329, Apologies for the delay in response. Azure Firewall was deployed here to inspect the traffic between the spokes. If your requirement is to mediate the traffic to Azure Private Endpoints using a security appliance, then you can deploy a Firewall to perform packet inspection.
Note: If you're using a private endpoint in a hub-and-spoke model from a different subscription, reuse the same private DNS zone on the hub.
Ref: https://docs.microsoft.com/en-us/azure/private-link/private-endpoint-dns#virtual-network-workloads-without-custom-dns-server
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

Apologies, I misunderstood your question. From the scenario 3, We must do SNAT even everything is under single virtual network. It would be listed on a special note and documented if the SNAT is required in the scenario 1. But, for further confirmation & insights on this I will tag the respective PG here.

Thanks for coming back to me. The bit was missing here was the largely undocumented InterfaceEndpoint feature that appears in all the route tables as documented here - https://journeyofthegeek.com/2020/09/10/interesting-behaviors-with-private-endpoints-new.
From a pure networking perspective the diagram doesn't make much sense ..

However, when you factor in that the InterfaceEndpoint adds a /32 to all subnets and subnets in peered vNets it makes a lot more sense. It does however raise some interesting usability questions - for example if I have a hub vnet with two subnets - one for an ER Gateway and one for an Azure Firewall and a route table pushing all traffic from the ER GW to the FW, any Endpoints in a peered spoke vnet would override that route in my ER Gateway subnet and send traffic direct to the Endpoint, bypassing the firewall. Only way around this would be to override the routes with a /32 for every endpoint created.

Sending to PM for review
#assign:@ivapplyr

Thanks for your dedication to our documentation. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Retry syscall for PID retrieval in bpf recorder

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
There is a possible race between the event processor and the profile
retrieval RPC, especially when multiple short living processes being
analyzed. It is possible, that we unlock the pidlock while we still have
to wait for a bunch of processes to be analyzed. We overcome this race
by retrying and therefore minimizing the time-gap between the locks.
Which issue(s) this PR fixes:

None
Does this PR have test?
None

Special notes for your reviewer:
Follow-up on https://github.com/kubernetes-sigs/security-profiles-operator/pull/702
Does this PR introduce a user-facing change?

None

Codecov Report

Merging #704 (570068e) into master (ada3026) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
+ Coverage   39.64%   40.04%   +0.39%
==========================================
  Files          37       37
  Lines        2850     2869      +19
==========================================
+ Hits         1130     1149      +19
  Misses       1667     1667
  Partials       53       53

/retest

/override pull-security-profiles-operator-verify


flv.js websocket 报错!Non-FLV, Unsupported media type!

Non-FLV, Unsupported media type!
Uncaught (in promise) Error: Uncaught, unspecified "error" event. (MediaError)
Uncaught TypeError: Cannot read property 'currentURL' of null

@MasterChenJiaWang
Are you sure your url is right?
ws://<IP_ADDRESS>/xxxx

this url means localhost ip

thinks  Problem has been solved

thinks Problem has been solved

how to solve?

How to solve this problem? I've met it now. I haven't found a solution. Please give me some advice


No symbol to close tab in sidebar

When I hover on a sidebar icon, the sidebar slides out, as expected. However, there is no X symbol to close that tab. How would I add that?

I removed it because it just takes up too much horizontal space for no good
reason, IMO. I just middle-click to close tabs anyway.
You can re-enable it in the Sidebery settings if you want. Click the little
gear icon at the bottom left of the sidebar, go to the Styles Editor
section near the bottom, and in the right-hand bar where it lets you edit
the sidebar .css, delete this line:
/* Hide the close button */
.Tab .close {
display:none;
}
On Wed, Sep 8, 2021 at 5:13 PM babychef @.***> wrote:

When I hover on a sidebar icon, the sidebar slides out, as expected.
However, there is no X symbol to close that tab. How would I add that?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Graklinghunter/Hovertext-Css/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AULTC66RJ4IXK5P5IX64MQLUA7UZ7ANCNFSM5DV3UQPA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Thank you.
Adrian Gresores
On Sep 8, 2021, 18:54, at 18:54, Graklinghunter @.***> wrote:

I removed it because it just takes up too much horizontal space for no
good
reason, IMO. I just middle-click to close tabs anyway.
You can re-enable it in the Sidebery settings if you want. Click the
little
gear icon at the bottom left of the sidebar, go to the Styles Editor
section near the bottom, and in the right-hand bar where it lets you
edit
the sidebar .css, delete this line:
/* Hide the close button */
.Tab .close {
display:none;
}
On Wed, Sep 8, 2021 at 5:13 PM babychef @.***> wrote:

When I hover on a sidebar icon, the sidebar slides out, as expected.
However, there is no X symbol to close that tab. How would I add
that?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Graklinghunter/Hovertext-Css/issues/1, or
unsubscribe

https://github.com/notifications/unsubscribe-auth/AULTC66RJ4IXK5P5IX64MQLUA7UZ7ANCNFSM5DV3UQPA

.
Triage notifications on the go with GitHub Mobile for iOS

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/Graklinghunter/Hovertext-Css/issues/1#issuecomment-915649454


Render through OpenPeripherals with pretty icons

OpenPeripherals glasses allowing to render items at overlay, so, it possible to make pretty UI. How about it?

I think we need to decide how to beautify beealyzer: discussion https://github.com/ProgramCrafter/lua-utils/discussions/3


Proposal: Trigger a new build with build parameters

Abstract
A proposal for implementing a new API endpoint for triggering new builds with custom build parameters, that is required for more flexible pipelines.
Related existing issues:

#1614 Pass build environment via the webhook
#894 Allow environment variables to be set on build basis + ondemand builds

Motivation
Currently, drone jobs work around a single git repository. Builds are triggered by different Github, gitlab, etc events via webhooks. This functionality probably covers the majority of use cases. However, there is no simple way to chain jobs, i.e. jobA ---> triggers ---> jobB ---> triggers ---> jobC.
Use Cases
Use case 1
Ability to trigger a downstream job to do a deployment after a successful code build
There two git repositories:

repoA - contains application code and tests
repoB - contains kubernetes deployment files

A developer pushes a new commit or a tag to repoA, github triggers a drone build which runs a configured pipeline, builds a docker image, pushes it to a docker registry. The image is tagged with git sha and is ready for deployment.
There next logical step is to trigger a repoB master branch (or specific git tag/sha) and pass a custom build parameter APP_IMAGE_TAG: 579e3ea. Drone kicks off a new build of repoB:master, which deploys repoA docker image with ${APP_IMAGE_TAG} to kubernetes.
Then, we also need an ability to trigger a job to do a deployment of a service. Application code does not necessarily have to be changed to trigger a deployment. Each application has environment-aware configuration, for example kubernetes manifests which describe how a particular application needs to be deployed and what configuration it requires.
An application can consists of multiple containers, i.e. kubernetes pods. A change to each of those components need to trigger a deployment, if we decouple application code from the deployment code, then a change to configuration or individual component code is able to trigger repoB to kick of a deployment.
High Level Design
Add a new API endpoint /api/repos/:owner/:name. This endpoint accepts POST with Content-Type: application/json. A new post handler function will have to be added to handle the request.
POST data example:
{
  "build_parameters": {
    "DOCKER_IMAGE_TAG": "v0.0.1",
    "ENVIRONMENT": "production",
  },
  "tag": "v1",
  "branch": "master",
  "revision": "579e3eabb9b40709051f1da87e8f5e787e71aada"
}

All above parameters are optional and can be omitted. By default HEAD of default branch will be checked out. build_parameters will then be injected in to a build as environment variables.
Additional work
Originally, @bradrydzewski suggested to add custom build parameters support to an existing API endpoint /api/repos/:owner/:name/builds/:number for restarting old jobs with added custom build parameters. The scope of this proposal covers that too.
Drone git plugin (https://github.com/drone-plugins/drone-git) will have to slightly changed. The plugin needs to default to HEAD of a default branch if revision is unspecified.
Unknowns
Potentially, add a new event type?

Ability to trigger a downstream job to do a deployment after a successful code build

this can be done today with the existing endpoint. You can see an example in the downstream plugin

There next logical step is to trigger a repoB master branch (or specific git tag/sha) and pass a custom build parameter APP_IMAGE_TAG: 579e3ea. Drone kicks off a new build of repoB:master, which deploys repoA docker image with ${APP_IMAGE_TAG} to kubernetes.

This can already be done with the drone build fork. If drone is enabled for repository B then drone will already have an existing entry for the commit sha in the drone database. Therefore we can use the drone build fork command to, for example, to re-build the existing entry with a new build number.
In the event that hooks are disabled for these repositories, and there is no entry in the database, the /hook endpoint should be used instead. The hook endpoint gives individuals broad flexibility to trigger a build with full control over the data in the hook payload.

Then, we also need an ability to trigger a job to do a deployment of a service. Application code does not necessarily have to be changed to trigger a deployment. Each application has environment-aware configuration, for example kubernetes manifests which describe how a particular application needs to be deployed and what configuration it requires.

This already exists using the drone deploy command. You can use drone deploy 55 production to, for example, deploy build number 55 to production. This is similar to the fork command, in that it creates a new build entry in the database, but also sets the event type to deployment. This allows you to conditionally execute steps based on the the deployment type and target environment:
pipeline:
  ...
  deploy:
    ...
    when:
      event: deployment
      environment: production

I believe these existing capabilities satisfy the use cases mentioned above. In the event we still need to pass additional parameters at runtime (such as environment variables) I recommend augmenting the existing capabilities https://github.com/drone/drone/issues/894#issuecomment-233707244

@bradrydzewski downstream plugin allows to kick off an existing build. I don't think that developers should have a mental map between drone build numbers and say git tags.
drone build fork again, works around an existing build.
drone deploy works with existing builds.
In case of drone database corruption or data loss, above solutions will fail, because build numbers will no longer represent git tags or branches I want to deploy.

This proposal has come up at least 3 times in the past and has not been accepted because upon further discussion we've found the existing capabilities work for the majority of real world situations, with /hook as a fallback.
Have you used these existing capabilities yet? Perhaps it instead makes sense to use them in a production setting and providing feedback based on real world usage pain points that you and your team have experienced.

downstream plugin allows to kick off an existing build. I don't think that developers should have a mental map between drone build numbers and say git tags.

drone build fork again, works around an existing build.

why won't be the build be in the database?

drone deploy works with existing builds.

why won't the build be in the database?

In case of drone database corruption or data loss, above solutions will fail, because build numbers will no longer represent git tags or branches I want to deploy.

This should be solved at the database level. We recommend running your database with regular backups and possibly configured with replication. In the event of data loss a GitHub post-commit hook could be re-triggered to re-sync the database.

Hi, this looks useful. I'm not sure i follow the ins and outs of how it is possible by you @bradrydzewski
The concerns are separate for most people, building and testing vs deploying. Deployments could be anywhere via anything i.e. heroku vs kubernetes vs whatever else. Knowing what versions of things you are deploying is necessary but to know that you need to know what was built. We wouldn't want the deployment files to live with code, because the code doesn't care about the deployment but you need that data of the version you want to deploy.
The workable scenario would be:
[code] -> [tests] -> [integrations] -> [build image] -> [push image]
at this point, the artifact is produced, maybe also you push to artifactory or nexus or whatever else, maybe you also push up some code coverage information to something else or reports on some tests to s3 to be consume by something else etc.
[docker repo webhook] -> [drone] -> [github checkout for deployment] -> [deploy]
or maybe you decide that someone wants to deploy a specific version into a specific environment, maybe preview or demo or whatever else. We might want to say, actually version 0.1.0-alpha1+64baec2  is the version with the latest changes i want to preview, so i will trigger that build with that version to deploy it to then review or whatever else. This could be done via slack, or chatops, or however you wanted to do it.

We wouldn't want the deployment files to live with code, because the code doesn't care about the deployment but you need that data of the version you want to deploy.

there is no requirement that you have to deploy live code. You can use the drone deploy function to re-trigger a pipeline execution (maybe that is a better term than build) that deploys existing code that is already compiled, or an existing image.
for example:
pipeline:
  # build the code
  # skip this step if event type is deployment
  build:
    image: golang
    commands:
      - go build
      - go test
    when:
      event:
        exclude: [ deployment ]

  # publish the image to docker registry
  # skip this step if event type is deployment
  publish:
    repo: foo/bar
    tags: [ latest, ${DRONE_COMMIT} ]
    when:
      event:
        exclude: [ deployment ]

  # deploy the image to production
  # only execute during deployment
  deploy:
    image: python
    commands:
     # run some python deploy script that deploys the existing image
     - ./deploy.py
    when:
      event: deployment
      environment: production

I believe everything you are requesting is possible with drone as-is today. Much of this functionality is new, including the drone deploy functionality which was added at the tail end of the 0.4 and not well documented.

@bradrydzewski that's great. Is it possible then for me to trigger a build using build deploy of a specific version using drone? I might not want to deploy what was just built, but a specific version of something that was built at some point in time to some environment. This could be programmatic but also maybe manual i.e. deploy version 5 into QA for some manual QA analysis on that product?

@jon-shanks yes, you can use drone deploy {environment} {build number} where {build number} represents a build in drone mapping to an individual commit sha and ref. You can use the latest build or any historical build.
The catch is that you have to know the build number that corresponds to the commit or tag or whatever that you want to deploy, but the Drone API has all of this data to make a lookup possible. We could certainly discuss making this more user friendly without adding major new functionality to drone.
This is a somewhat messy example to demonstrate that it is possible to trigger a deployment for a specific commit by commit sha:
drone build list drone/drone --format="{{ .Number }} {{ .Commit }}" \
    | grep "b675867967586e34e86b387434e0d5aac8c2bdf1" \
    | cut -d' ' -f1 \
    | xargs -I{} drone deploy drone/drone production {}

or by tag:
drone build list drone/drone --format="{{ .Number }} {{ .Ref }}" \
    | grep "refs/tags/v1.3.4" \
    | cut -d' ' -f1 \
    | xargs -I{} drone deploy production drone/drone {}

@bradrydzewski i'm still confused here , sorry. This looks like it is deploying from the same repo, but i dont want to, i want to trigger a build on another repo? are you saying that i can do it like this?

@bradrydzewski I think to achieve what we're proposing here without adding a lot of new functionality to drone, we need to add custom build parameters support to /hook endpoint. Would you be up for that?

I think to achieve what we're proposing here without adding a lot of new functionality to drone, we need to add custom build parameters support to /hook endpoint. Would you be up for that?

I'm open to adding parameters to both the /hook endpoint similar to what was discussed in https://github.com/drone/drone/issues/894#issuecomment-233707244. I think we first need a documented use case describing how it will be used and why this is necessary. Specifically why is the fork / re-build endpoint inadequate? If the sole reason is a possible database failure, I'm probably not open to the PR

@bradrydzewski cool, no worries. As promised I am going to do a PR to implement suggested feature in https://github.com/drone/drone/issues/894#issuecomment-233707244
I will try to achieve what we described in the proposal using current drone features. Thanks!

@bradrydzewski . I feel we have given our use case. We want to define our own ways of working, what you have provided is a very specific solution to do what we want and it still doesn't meet our needs. We would like the flexibility of having an API to achieve our own workflow around drone product, we don't really want to be pulling data from one api call and then pushing data to another api call in some adhoc way to retrigger another job as that isn't particularly clean.
The example is, we want to leverage https://docs.docker.com/docker-hub/webhooks/ which we have no control over. When the payload gets sent we want to send specific data to drone. We could in theory extrapolate data from drone and then prepare the webhook, then change the webhook to then post data to the api to trigger the build? but not sure if that would work or not? But also seems quite convoluted and not particularly flexible. I think the most sense here is to allow people to work in a way they want to by allowing some flexibility on how jobs build. Right now that isn't there.

I feel we have given our use case

this is the first time dockerhub has come up. I feel like it is very fair to ask for a specific use case so I understand the exact problem we are solving before proposing solutions.

We want to define our own ways of working, what you have provided is a very specific solution to do what we want and it still doesn't meet our needs.

we want to work within the boundaries of drone when possible

The example is, we want to leverage https://docs.docker.com/docker-hub/webhooks/ which we have no control over.

If this is the intended use case then I don't understand how this proposal solves the problem. The json format proposed in the abstract does not match what is sent by DockerHub.

We could in theory extrapolate data from drone and then prepare the webhook, then change the webhook to then post data to the api to trigger the build

Per the abstract and json format defined above this would still be required.

I think the most sense here is to allow people to work in a way they want to by allowing some flexibility on how jobs build. Right now that isn't there.

Having a small service that sits between the source webhook and target drone seems to achieve this goal.
In conclusion I do not believe this proposal is going to meet the defined DockerHub use case. It is also unlikely that drone will build support for individual payload types (ie DockerHub) directly into the Drone server. Drone has always promoted external plugins and services for such things and will continue to do so.
I believe there are still alternative approaches that can be explored, such as a custom plugin, although "we want to define our own ways of working" seems to indicate a lack of appetite for such suggestions. If you change your mind and are open to exploring native-Drone solutions please let me know.

@jon-shanks @vaijab  http://concourse.ci will do exactly what you want and more... unfortunately, it just doesn't have a gui like drone does.


Add GroupName property to IAM Group resource

GroupName property is missing from IAM Group resource: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-iam-group.html

Thanks @ampedandwired.


OKIT-GitHub Connection

I need to connect OKIT to GitHub. I followed the instructions in the Install Guide and finally figured out how to make it work. However, it won't save files? I can load files from the repo but I have to save them as okit (n).json where n is some number, then check out the file, open the downloaded file, paste in the contents, save and push.
Have I got something wrong?
Also a Save As would be a nice feature.
Please advise.

@henremurr with the git integration the save should just do a git add/push. I'll take a look see if I can reproduce the  issue

thanks

On Feb 28, 2021, at 07:06, Andrew Hopkinson<EMAIL_ADDRESS>wrote:

@henremurr with the git integration the save should just do a git add/push. I'll take a look see if I can reproduce the issue
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Ambiguity around which certificate is the customer's responsibility

This phrase is confusing:
Certificates mentioned above are maintained by Microsoft, except the cluster certificate, which you have to maintain.
Is the "cluster certificate" in the list above? If so which one is it? If it isn't part of that list...perhaps it could be stated more clearly.
In addition, in the rest of the article it shows how to enable automatic rotation and perform manual rotation. But it isn't clear if one or both are how a customer maintains that certificate. I think that is correct, but it is not clear.
I think this is what the article is trying to say, but in summary this format would be easier to follow:

Microsoft manages the following CAs and Certificates
The customer is responsible for this certificate
2.a You can enable automatic certificate rotation
2.b You can manually rotate the certificate

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9b78509d-73eb-6c32-aee1-9b34685a64ff
Version Independent ID: 6f87cf70-1f5a-0f9e-862d-ae1436595f3b
Content: Certificate Rotation in Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/certificate-rotation.md
Service: azure-kubernetes-service
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@marlobello
Thank you for bringing this to our attention.
I've delegated this to content author @MGoedtel, who will review it and offer their insightful opinions.

@marlobello - I've reviewed the article and your right, it isn't clear what is the "cluster certificate". The wrong term is being used here, as it's really meant to state "cluster CA". With how it is worded here in that list, it is like it is an array of certificates, but it is the singular certificate that runs the cluster itself.
I'm going to bug this article because this isn't well described in general, and I see other details that can be improved.
Let me know if this properly addresses your concern / question.

Thanks for providing feedback that helps improve our documentation. This issue has been resolved and we are closing the issue. #please-close


Cirrus: Groom rust cache before updating

Depends on https://github.com/containers/netavark/pull/559
Port of https://github.com/containers/netavark/pull/553

/lgtm
/approve


Delete .travis.yml

Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
We are not using travis CI anymore so this configuration is no longer needed.
Sorry for the brevity of creating PR from GitHub UI.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR:

[ ] CHANGELOG entry for user-facing changes
[ ] Updated the relevant documentation

Seems like we have more flakes in e2e tests.
cc @antekresic


Internal NOAA review

Send draft assessment to Owen on Wednesday 26th for internal review.  We don't need a complete assessment document, but if the executive summary is basically done and the figures and tables are basically done, I think we are good.

Sent so closing... I'll open a new one to address comments depending on how extensive.


Hotfix :url-encode filepaths when get presigned posts for filepath

Context in issue: https://github.com/cleanlab/cleanlab-studio-integration/issues/704

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Might be unnecessary with a proper fix to https://github.com/cleanlab/cleanlab-studio-integration/issues/710

No longer needed, switching strategies


Suggestion: Make fullScreenDialog page in iOS swipeable.

Hi there,
when using normal page routes, either a MaterialPageRoute or a CupertionPageRoute, you can swipe them away in reverse direction how they flew in on iOS. But when using the fullScreenDialog property, you can't do it. Neither from left to right nor from top to bottom.
It would be way easier to navigate if you could drag it down.
With kind regards
Daniel

Is there a pattern from standard Xcode iOS you're referencing here? Making it non-swipable is the main intent of fullScreenDialog.

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


commander: fix 'commander arm' not working in HIL mode

This got introduced with 61b0a81bf9. Due to the removed startup_in_hil flag,
this check does not work anymore, so remove it completely.
Fixes #8176

Just tested the V1.7.0 beta in HIL mode and still unable to arm - "Mag 0 Tout!" error.

The last known version in which HIL works is v1.5.

@1MSG1 could you open a new issue and describe what you're doing in detail? With your help there's still time to fix this for v1.7.0.

Will do later in the day.
On Sun, Nov 19, 2017 at 2:09 PM Daniel Agar<EMAIL_ADDRESS>wrote:

@1MSG1 https://github.com/1msg1 could you open a new issue and describe
what you're doing in detail? With your help there's still time to fix this
for v1.7.0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PX4/Firmware/pull/8208#issuecomment-345541310, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AeB3wFKqaQwkYlaQrcGeh-8wAlzo8CiPks5s4HzbgaJpZM4QK2_Y
.

--
Sent from my iPhone. Please excuse any typos or brevity.


fix(context2d): do not add empty pages before html section

prevent getPagesByPath() call from modifying section start page number. This number used to determine if sufficient number of blank pages to hold the intended html block is present.

To check the fix, create sitemap-only report - with the fix applied, no empty pages should be present in the document before actual sitemap tree.

@pmstss please, review when you have time.


Drive mounted, but don't see list of games

Tried all mirrors, any fix for this?

Same problem,
Could not found the mount drive.
In my case it is under windows 10.

Can you start application by console and give me a log?

Same for me, "Mount status connected" but when click "Click to browse mount" nothing happens...and no error in Console...how I can fix?

I read:
JUNE 18 2021 : NOTICE: OFFICIAL SIDENODER DISCONTINUED
There is no log file on my site:
Only  Trying to fetch device storage info
So it is trying to connect to a storage somewhere.

ONLOAD
index.twig:317 setup ask device listener
index.twig:344 ONLOAD INDEX
index.twig:345 sending check_deps
index.twig:237 get_device msg came FROM BE to fe:
index.twig:238 Object
index.twig:210 check_mount
...
Not this console log. If you use windows, then start app by cmd.exe

Catched the problem. Need of killing rclone
Will add fix at next release. At this time you can kill rclone manualy

I still have this issue with latest release. Sidenoder mounts C:/Users/julien/AppData/Local/Temp/mnt which is empty


Enhanced diagnostic logging for ANCM is missing

Looks like this link might have been broken in a document refactor? xref:host-and-deploy/aspnet-core-module#enhanced-diagnostic-logs
Referenced from:

https://github.com/dotnet/AspNetCore.Docs/blame/main/aspnetcore/test/troubleshoot-azure-iis.md#L313
https://github.com/dotnet/AspNetCore.Docs/blame/main/aspnetcore/test/troubleshoot-azure-iis.md#L314
https://github.com/dotnet/AspNetCore.Docs/blame/main/aspnetcore/test/troubleshoot-azure-iis.md#L317

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4a2a7104-1d14-2e8a-0984-d92aa311c108
Version Independent ID: 5e3c0546-c579-afb9-5289-b14532c127eb
Content: Troubleshoot ASP.NET Core on Azure App Service and IIS
Content Source: aspnetcore/test/troubleshoot-azure-iis.md
Product: aspnet-core
Technology: aspnetcore-test
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@Rick-Anderson The PR didn't fix it. There's some actual content that's been lost in the process. The content is available on the 3.1 version of docs- https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/aspnet-core-module?view=aspnetcore-3.1#enhanced-diagnostic-logs

I'm happy to PR then content if need be. @Rick-Anderson let me where this content should be included. This is a really important scenario

Looks like it's at https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/iis/logging-and-diagnostics?view=aspnetcore-6.0#enhanced-diagnostic-logs


Compare Namespaces for Overlapping IP Addresses

@bryanculver Can you elaborate a bit more on what's being asked for here?


Update Cargo.toml

Fixes #2393
If this doesn't get pulled then build instructions over at https://github.com/jwilm/alacritty/blob/master/INSTALL.md#cargo with fail with
cargo-deb: unable to read license file: ../LICENSE-APACHE
  because: No such file or directory (os error 2)

@chrisduerr apparently not since I just installed the resulting deb package and I get the following files
dpkg-query -L alacritty
/usr
/usr/share
/usr/share/doc
/usr/share/doc/alacritty
/usr/share/doc/alacritty/copyright
/usr/bin
/usr/bin/alacritty
/usr/share/applications
/usr/share/applications/alacritty.desktop
/usr/share/pixmaps
/usr/share/pixmaps/Alacritty.svg
/usr/share/bash-completion
/usr/share/bash-completion/completions
/usr/share/bash-completion/completions/alacritty
/usr/share/fish
/usr/share/fish/completions
/usr/share/fish/completions/alacritty.fish
/usr/share/zsh
/usr/share/zsh/vendor-completions
/usr/share/zsh/vendor-completions/_alacritty
/usr/share/terminfo
/usr/share/terminfo/a
/usr/share/terminfo/a/alacritty

The relative path for license-file was added in #2379 and fixes the simple build case of running cargo deb inside the alacritty workspace directory under the alacritty repository. This change reverts that and once again breaks the simple case:
# cd alacritty
# cargo deb --install
cargo-deb: unable to read license file: LICENSE-APACHE
  because: No such file or directory (os error 2)

It does rectify building with cargo-deb by specifying a manifest file, as per the install instructions (cargo deb --install --manifest-path alacritty/Cargo.toml). which is broken in the simple case.
There appears to be an upstream issue in cargo-deb regarding workspace support and this situation at mmstick/cargo-deb#49 that hasn't gotten much traction, until it does - it will only work one way or the other out of the box, and in neither case will running 'cargo deb' in the repository root will work at all.

The relative path for license-file was added in #2379 and fixes the simple build case of running cargo deb inside the alacritty workspace directory under the alacritty repository. This change reverts that and once again breaks the simple case:

Yes and I was fully aware of that.
While obviously it would be great to support both, that's not an Alacritty issue and should be handled in cargo-deb.

mmstick/cargo-deb#94 (included in cargo-deb v1.18.0) modifies the behavior so that a relative license-path file is required even in the documented case (cargo deb --install --manifest-path alacritty/Cargo.toml), which makes it consistent with the simple case.
PR #2459 reverts back to a relative path.


Wings stop working after teleport/dimension change

On multiple occasions the wings have stopped working, usually after a dimension change. Regardless of how I go to the End, I would have to relog to get them working again. However they also will stop working after a teleport to another player in the same dimension. It occurs randomly, not due to a specific command/item/dimension (End is usually every time though). In most cases, relogging would fix the issue, however if it doesn't work, the only way to get them working again is to die.
No crash logs or information in logs with reference to the Winged mod.

+1

This is a FallFlyingLib bug, which (hopefully) be superseded by an official Fabric API module: https://github.com/FabricMC/fabric/pull/1815
Once the module is merged, I'll work on a version that uses the Fabric API module and this will (hopefully²) be fixed.

Just an FYI that this issue is still happening occasionally.


Extending support for rate limit headers

Description
Follow up of https://github.com/projectdiscovery/chaos-client/issues/111. The client should interpret the Retry-After header. If present (429 status code) the client should wait for the specified amount of time (in seconds) before issuing a new request.
...
Retry-After: 60
...

Depends on https://github.com/projectdiscovery/chaos-cache/issues/152

Suppressed by new API.


Automated Package Upgrade

:tada: This PR is included in version 5.3.48 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


New data cannot be reported.

Login to the crisis check in web app as a volunteer
Report new data by choosing a disaster, description, quantity, type, start date,  end date and location.
Click on check-in
Report new data is not added and fetched to be displayed.
This behavior is noticed first time on 5th May, earlier this was found to be working (report new data could be added and fetched).
P2
Milestone - Features backlog

Once you report new data you can verify that it had actually been added to the db by going to view checkins and selecting the disaster you reported data on (leave the date blank), click go and then you should be able to see your entry at the bottom.


Mod doesn't seem to like either of the lanterns. Not sure why.

[13:24:21] [Render thread/INFO]: Skipping non-result value minecraft:lantern=UNASSIGNED
[13:24:21] [Render thread/INFO]: Skipping non-result value minecraft:soul_lantern=UNASSIGNED

This is all the info I have. Not even a crash log. I don't get this in the debug log if I remove Stitched Snow. I also have no idea what could be conflicting - if anything - but I have a list of mods here:

Mod was disabled and it still happened, so idk what to do. Not an issue with this mod.


question: How to connect target-clickhouse with SSL certificate?

I am not sure about settings for clickhouse and have pretty the following settings:
loaders:

name: target-clickhouse
variant: shaped-ai
pip_url: git+https://github.com/shaped-ai/target-clickhouse.git
config:
database: holding_test
default_target_schema: holding_test
host: rc1a-hqgn203ff9jog6cr.mdb.yandexcloud.net
load_method: upsert
port: 8443
table_name: test
username: user1
verify: true
cert: "/home/andrew_petrukhin_vlad/.dbt/RootCA.pem"

trying to upload data into Clickhouse db and get the following error:
File "/home/andrew_petrukhin_vlad/meltano-projects/dbt-gbq-clickhouse/.meltano/loaders/target-clickhouse/venv/lib/python3.9/site-packages/requests/sessions.py", line 637, in post
return self.request("POST", url, data=data, json=json, **kwargs)
File "/home/andrew_petrukhin_vlad/meltano-projects/dbt-gbq-clickhouse/.meltano/loaders/target-clickhouse/venv/lib/python3.9/site-packages/requests/sessions.py", line 589, in request
resp = self.send(prep, **send_kwargs)
File "/home/andrew_petrukhin_vlad/meltano-projects/dbt-gbq-clickhouse/.meltano/loaders/target-clickhouse/venv/lib/python3.9/site-packages/requests/sessions.py", line 703, in send
r = adapter.send(request, **kwargs)
File "/home/andrew_petrukhin_vlad/meltano-projects/dbt-gbq-clickhouse/.meltano/loaders/target-clickhouse/venv/lib/python3.9/site-packages/requests/adapters.py", line 501, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

I think you might be missing secure: true.
For me it works when it's included, but I'm not using a custom cert (maybe remove verify to ignore that?).
Also I'm using just this config line, not broken:
sqlalchemy_url: clickhouse+native://default:<yourpassword>@aeopdsaday.us-east-1.aws.clickhouse.cloud?secure=true
Notice I use clickhouse+native. you can set that with driver option.
https is not a valid driver, only http is, but won't connect over SSL.
(sqlalchemy.exc.NoSuchModuleError: Can't load plugin: sqlalchemy.dialects:clickhouse.https )


JAMES-1902 reorganizes blob modules

This PR also removes a couple duplicate dependencies that were present in the POM files.

Looking to make sure I had the proper sort order in the POM files I stumbled upon sortpom, wich led me to site/src/xdoc/contribute which helpfully provides:
mvn com.github.ekryd.sortpom:sortpom-maven-plugin:sort -Dsort.keepBlankLines -Dsort.sortDependencies=groupId,artifactId -Dsort.nrOfIndentSpace=4 -Dsort.createBackupFile=false -Dsort.sortModules=true -Dsort.expandEmptyElements=false  -Dsort.predefinedSortOrder="recommended_2008_06"

I'm not sure if this recommandation is still applicable because running it returned over 150 incorrectly sorted pom, I applied the fixes to pom files from :

server/container/guice/queue/*
server/container/guice/blob/*
server/container/guice/pom.xml

hopefully that's ok

We did not run that for ages, but the rules still applies, and we should do a run... (conflicts likely expected!) You are very right...

We did not run that for ages, but the rules still applies, and we should do a run... (conflicts likely expected!) You are very right...

Should it be configured to run automatically on every compile ?
something like
mvn compile -Psort

to make it easier to sort the modules ? then each new PR can commit the fixed poms it has modified

Should it be configured to run automatically on every compile ?

And abort the build if needed? => :+1:

I just merged this work. Can we close the PR?


Report option

Would be a nice feature if you could display or report the file savings per file.

You can, just pass the verbose flag to grunt: $ grunt imagemin --verbose


[MNT] Add a script to generate changelog in rst format

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions

[ ] I've added myself to the list of contributors.
[ ] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[ ] I've added unit tests and made sure they pass locally.
[ ] The PR title starts with either [ENH], [DOC] or [BUG] indicating whether the PR topic is related to enhancement, documentation or bug

For new estimators

[ ] I've added the estimator to the online documentation.
[ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Thank you! THANK YOU!
This was getting really tedious!

linting is failing, would be great to have this for next release

@fkiraly linting is passing but my local pre-commit is broken because of shellcheck-py so I sprinkled # noqa around the script instead of fixing the issues


Send in AgentLink

Implements https://github.com/yewstack/yew/issues/1209

IssueHunt Summary

Referenced issues
This pull request has been submitted to:

#1209: Add send method to AgentLink so that agents can easily update themselves

Tests are a somewhat orthogonal concern, removed them for now, we might want to create an issue to add a testing scaffold to Agents. Ready for review.

closing in favor of https://github.com/yewstack/yew/pull/1215


Support configuration of HTML page layout

header, menu and footer should be configurable to support use of jskos-web instance at http://uri.gbv.de/terminology/ with another layout. Maybe move <main> of App.vue to its own component to be included.

Not needed so far as http://uri.gbv.de/terminology/ is being implemented via https://github.com/gbv/jskos-proxy instead.


Migrated sample BND project "bnd/blade.corejsphook" to sample Maven p…

Hello Ray et. al,
I am aware you have published a sample BND project to demonstrate over-riding of core JSP files in the portal ROOT web app from an OSGi module in PR#267 at
https://github.com/rotty3000/blade/pull/267
I have migrated that sample BND project "bnd/blade.corejsphook" to a sample Maven project "maven/blade.corejsphook".
The changes are in forked blade repos at
https://github.com/timtelcik/blade
on branch
blade.corejsphook.tt
Please review and merge, if possible.
Regards,
Tim

hey @timtelcik thanks for the feedback, we have moved everything to new repo and also I've already replicated the corejsphook to other 3 types as well here: https://github.com/gamerson/liferay-blade-samples/pull/10
So once that is merged if you have more suggested improvements we are happy to entertain them again on the new repo.  Sorry for the extra work but now that the samples have moved to their final home, this shouldn't happen again :)


expose alias names which can be 'require'd

Added global Alias for browserified JS files.
Added vendorBundle option for external files

add vendorBundle into your browserify config object within component.config.js
...
  browserify: {
        vendorBundle: [
            { file: './bower_components/d3/d3.js', expose: 'd3'}
        ]
    },
...

Match this wil the browser object within your package.json
...
  "browser": {
    "d3": "./bower_components/d3/d3.js"
  },
...

after the component build command has finished you will have a vendor.js and vendor.min.js which contains all the files in the vendorBundle array.
The upside is that you can get across all the commits, but let me know if you need it rolled back to the actual PR again!


Find communication method that works for everyone

Description
We use Slack in the lab and will almost certainly be continuing that. However, I need to figure out if we're going to be using the old Agrobots Slack channel or creating a new one.
Tasks

[x] Figure out if we'll keep the old Slack channel or if we'll create a new one.
[x] Add everyone to the channel.

Regardless, I think documenting milestones and tasks via the GitHub team is superior to the old method of using Notion.

Using Slack seems to be working fine. Notion is a bit annoying with not being able to add members to a workspace but I can deal with adding team members as guests, at least for now.


feat: update forge-std and rm ds-test dependency

On hold until a new forge-std version is released.


fix(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/common-utilities/ibm (source)
module
minor
1.0.0 -> 1.1.0

terraform-ibm-modules/landing-zone-vpc/ibm (source)
module
patch
7.19.0 -> 7.19.1

terraform-ibm-modules/landing-zone/ibm (source)
module
minor
6.2.2 -> 6.6.1

terraform-ibm-modules/secrets-manager-private-cert-engine/ibm (source)
module
patch
1.3.2 -> 1.3.4

terraform-ibm-modules/secrets-manager-private-cert/ibm (source)
module
patch
1.3.1 -> 1.3.2

terraform-ibm-modules/secrets-manager/ibm (source)
module
minor
1.18.3 -> 1.19.6

Release Notes

terraform-ibm-modules/terraform-ibm-common-utilities (terraform-ibm-modules/common-utilities/ibm)
v1.1.0
Compare Source
Features

add parsed account ID field of the CRN (#18) (841cbbd)

terraform-ibm-modules/terraform-ibm-landing-zone-vpc (terraform-ibm-modules/landing-zone-vpc/ibm)
v7.19.1
Compare Source
Bug Fixes

Support to allow VPC to access classic infrastructure network is removed as classic_access feature has been deprecated by provider (#885) (cf582ac)

terraform-ibm-modules/terraform-ibm-landing-zone (terraform-ibm-modules/landing-zone/ibm)
v6.6.1
Compare Source
Bug Fixes

fixed invalid index bug for resource group output values when override set to true (#933) (9fa72a1)

v6.6.0
Compare Source
Features

added new outputs: management_rg_id, management_rg_name, workload_rg_id and workload_rg_name (#931) (ade1dd9)

v6.5.1
Compare Source
Bug Fixes

reverted the ability to set the provider_visibility in DA due to known provider bug (#930) (e2d5345)

v6.5.0
Compare Source
Features

exposed the ability to set the provider_visibility in the DA Learn more (#921) (a6c87a4)

:warning: NOTE: This was reverted in https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/releases/tag/v6.5.1
v6.4.4
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the landing zone das (#917) (7bb2f0d)

v6.4.3
Compare Source
Bug Fixes

updated the "Existing VPC" variation of the VSI DA to claim controls from the IBM Cloud Framework for Financial Services version 1.7.0 profile (#926) (85fd586)

v6.4.2
Compare Source
Bug Fixes

revert "dependency_version_2": true until full migration path supported (#925) (f416462)

v6.4.1
Compare Source
Bug Fixes

update the VSI extension DA to opt into "dependency_version_2" features in catalog (#924) (ce86a21)

v6.4.0
Compare Source
Features

update OCP default version to to 4.16 (#922) (a93f177)

v6.3.1
Compare Source
Bug Fixes

a fix was added to the VSI extension variation so that VSI only get created in the subnets that are meant for VSIs. If upgrading from a previous version, you may see VSI's being destroyed in some subnets where they were not supposed to be provisioned. (#661) (4b3d100)

v6.3.0
Compare Source
Features

add support for Virtual Network Interface in all VSI patterns.- The VSI patterns will now creates VSIs using the next gen virtual network interface by default, these VNIs are created independent of the VSIs.

UPGRADE NOTES:  When upgrading from a previous version, VSIs may be destroyed and recreated. To prevent re-creation or to use the legacy network interface, set var.use_legacy_network_interface to true. (#915) (99ad28e)

terraform-ibm-modules/terraform-ibm-secrets-manager-private-cert-engine (terraform-ibm-modules/secrets-manager-private-cert-engine/ibm)
v1.3.4
Compare Source
Bug Fixes

deps: updated required IBM provider to >= 1.70.0, < 2.0.0 as its required by dependant CBR module (#259) (79c9d57)

v1.3.3
Compare Source
Bug Fixes

added validation to ensure the values for 'root_ca_common_name' and 'intermediate_ca_common_name' are different (#209) (88b5b4f)

terraform-ibm-modules/terraform-ibm-secrets-manager-private-cert (terraform-ibm-modules/secrets-manager-private-cert/ibm)
v1.3.2
Compare Source
Bug Fixes

deps: updated required provider to >=1.70.0, <2.0.0 which is required by dependant CBR module (#258) (7023eac)

terraform-ibm-modules/terraform-ibm-secrets-manager (terraform-ibm-modules/secrets-manager/ibm)
v1.19.6
Compare Source
Bug Fixes

deps: DA updates:- locked ibm provider version to 1.73.08 updated KMS module version to 4.18.1 (#257) (51b861f)

v1.19.5
Compare Source
Bug Fixes

updated the region selector in the DA to only show Secrets Manager supported regions (#251) (b43e33b)

v1.19.4
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#227) (ab80143)

v1.19.3
Compare Source
Bug Fixes

deps: update terraform-module (#245) (f62c111)

v1.19.2
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.17.1 (#243) (590b9b3)

v1.19.1
Compare Source
Bug Fixes

deps: update terraform-module (#232) (7895b6f)

v1.19.0
Compare Source
Features

exposed the ability to set the provider_visibility in the DA. Learn more. (#233) (9b76e2f)

v1.18.15
Compare Source
Bug Fixes

mark existing_kms_instance_crn as required  in the DA (#236) (b60bfd8)

v1.18.14
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/event-notifications/ibm to v1.14.4 (#230) (b300e61)

v1.18.13
Compare Source
Bug Fixes

deps: update terraform-module (#211) (ee5d8e8)

v1.18.12
Compare Source
Bug Fixes

deps: bump CBR and IBM provider (#220) (54a3274)

v1.18.11
Compare Source
Bug Fixes

deps: update KMS module to 4.16.4 in the DA (#218) (5555c40)

v1.18.10
Compare Source
Bug Fixes

update to SCC profile IBM Cloud Framework for Financial Services 1.7.0 (#217) (69b8bf9)

v1.18.9
Compare Source
Bug Fixes

fixed the value of the resource_group_id output in the DA solution (#216) (fe3a95c)

v1.18.8
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#212) (8d2e521)

v1.18.7
Compare Source
Bug Fixes

deps: upgraded version of secrets-manager-iam-engine to 1.2.3 to fix issue (#213) (28996ce)

v1.18.6
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/event-notifications/ibm to v1.10.17 (#209) (e71a27f)

v1.18.5
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/event-notifications/ibm to v1.10.16 (#208) (bceafdb)

v1.18.4
Compare Source
Bug Fixes

deps: update terraform-module (#206) (55183f4)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline


Gapless playback?

Any interest in implementing gapless playback? Here's a proof of concept that works fairly well, but is a bit messy and comes with a prebuilt UI: https://github.com/regosen/Gapless-5
Edit: I suppose this is outside of the scope of this library. Maybe a wrapper around this would be doable though.

@switz Interesting idea on doing gapless playback.  I would agree that it's out of scope of this little audio tag wrapper.  Maybe what you want is a React interface similar to this one but on top of the Gapless-5 library...  It might be doable to wrap Gapless-5 just like this library wraps the audio tag.


minimap plugin: add touch events

The minimap should be draggable on a phone

Coverage remained the same at 82.337% when pulling bfa9c76040058ac59bab19e7bd9d347521c6e425 on jnorris441:patch-2 into 19afccbe8cde790986989105d99f5935c8088f03 on katspaugh:master.

@jnorris441 can you take a look at this PR this week, I'd like to release a new wavesurfer.js with this fix included if possible.

no feedback in a year, closing.


Adding an example for bulk update operation

Description
Updating the Bulk example to also showcase bulk update operations. Moved duplicate code into re-usable methods.
Issues Resolved
Closes 590
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The backport to 2.x failed:
The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-690-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 25bd4cf19dc2bd7e31596865cf75f031104d6dfa
# Push it to GitHub
git push --set-upstream origin backport/backport-690-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-690-to-2.x.

Might be failing since #687 first needs to be backported to 2.x. Will re-trigger this once that is done.


Fix compile error ('transform' is not a member of 'std')

I ran into an error during compilation (Debian Sid, GCC 14.2) where the compiler could not make sense of the "transform" function. Adding the algorithm header fixes this.

Hey! Thank you for finding the bug and contributing!
I usually like to keep the standard library includes in the precompiled header. Can you just move the include to pch.h? I'll then run the CI and, if everything passes, I'll happily merge.

Yep will do that in about an hour

Done.


[ALS-7760] Replicate Old Search in new Data-Dictionary

Improvements

Implemented /search in the new dictionary to support legacy search functionality as a temporary solution for the API adapters.
Added @ActiveProfile("test") to all unit tests that do not use a PostgreSQL Testcontainer, and @Profile("!test") to the DataSourceVerifier. This reduces unnecessary log spam from unit tests that do not provide valuable information.
Included a README.md file in the dictionaryweights project with basic instructions for running the application using Docker.
Added bdc-dev application.properties files for running a local development environment.

Regressions

The new implementation does not support OR functionality using |. Previously, the search prototype split input based on punctuation, spaces, and invisible space separators using the regex [\s\p{Punct}]+.

approved, but the build is failing.


Rarity Weight

❤❤❤❤❤❤❤
Hi, I was trying to generate arts with the exact weights, finally, I found this module and tried.
But I was a bit surprised because I didn't see the result that I wanted.
Layer Structure
    00-Background
        |- 1.blue.png
        |- 2.white.png
        |- 3.green.png
    01-Body
        |- 1-maroon.png
        |- 2-nut.png
        |- 3-standard.png
        |- 4-yellow.png
    02-Expressions
        |- 1-dot.png
        |- 2-std_lord.png
        |- 3-standard.png

config.yaml
name: 'My Collection #{id}'
description: An awesome collection
external_link: https://myexternallink.com
image: ipfs://myHash/{id}
traits:
- trait_type: Background
  variants:
  - value: blue
    weight: 1
  - value: white
    weight: 2
  - value: green
    weight: 3
  is_optional: false
  optional_weight: 1
- trait_type: Body
  variants:
  - value: maroon
    weight: 1
  - value: nut
    weight: 2
  - value: standard
    weight: 3
  - value: yellow
    weight: 4
  is_optional: false
  optional_weight: 1
- trait_type: Expressions
  variants:
  - value: dot
    weight: 1
  - value: std_lord
    weight: 2
  - value: standard
    weight: 3
  is_optional: false
  optional_weight: 1
path_map:
  Background/blue: ./layers/00-Background/1-blue.png
  Background/green: ./layers/00-Background/3-green.png
  Background/white: ./layers/00-Background/2-white.png
  Body/maroon: ./layers/01-Body/1-maroon.png
  Body/nut: ./layers/01-Body/2-nut.png
  Body/standard: ./layers/01-Body/3-standard.png
  Body/yellow: ./layers/01-Body/4-yellow.png
  Expressions/dot: ./layers/02-Expressions/1-dot.png
  Expressions/standard: ./layers/02-Expressions/3-standard.png
  Expressions/std_lord: ./layers/02-Expressions/2-std_lord.png

traits_rarity.json
  {
    "total": 30,
    "traits": {
      "Background": {
        "blue": { "Total": 9, "Percentage": 0.3 },  //  Origin: 5
        "green": { "Total": 10, "Percentage": 0.3333333333333333 }, // Origin: 10
        "white": { "Total": 11, "Percentage": 0.36666666666666664 } // Origin: 15
      },
      "Body": {
        "maroon": { "Total": 4, "Percentage": 0.13333333333333333 },  //  Origin: 3
        "nut": { "Total": 9, "Percentage": 0.3 }, //  Origin: 6
        "standard": { "Total": 8, "Percentage": 0.26666666666666666 },  //  Origin: 9
        "yellow": { "Total": 9, "Percentage": 0.3 } //  Origin: 12
      },
      "Expressions": {
        "dot": { "Total": 10, "Percentage": 0.3333333333333333 }, //  Origin: 5
        "standard": { "Total": 11, "Percentage": 0.36666666666666664 }, //  Origin: 10
        "std_lord": { "Total": 9, "Percentage": 0.3 } //  Origin: 15
      }
    }
  }

🙋♂ Please let me know what I made a mistake, and how I can solve this problem perfectly.
🙏 Thanks.

Hello @CaCaBlocker you made nothing wrong! The weight doesn't guarantee 100% precision, but I see you got some weird results, especially on "Body", so I'll have a look on that.
In the meanwhile, try playing with other weights. For example, since you want a 5, 10, 15 distribution on Background, try using those numbers as weights, like in the example below:
traits:
- trait_type: Background
  variants:
  - value: blue
    weight: 5
  - value: white
    weight: 10
  - value: green
    weight: 15
  is_optional: false

I'll have a better look into this later today

Hi, @alephao
Thanks for your kindly response. I followed the way what you recommended, and it looks better. But anyway, it's not the exact result. The condition is complex, so I need to try and find the more way. Hope your progressive project. Thanks again.


add group email address to top Contact Us section

In response to suggestion from
https://groups.google.com/g/hgvs-nomenclature/c/toGJA-HsPvE/m/SrDheuHoAAAJ

Should we let people know that the answer may actually only be found in the Google group? Because, when replying online, the message is only sent to the group and not sent to the poster. It's unclear to me whether the poster is notified of a reply to their question. We've had one person reminding us of a question that was already answered.

@ifokkema I added a comment about sending messages and reading replies. Does this address your request?


Improve the isolate commands detailed help to let people know how to reset

Right now it isn't very clear to people how to go back to the patch stack after starting an isolation. We need to improve the detailed help messaging for the isolate command so that people can more easily discover it.

This has been integrated into mainline. Therefore, I am closing this issue.


Error when running ng build

🐞 Bug report
Description
I get the following output when running ng build:
$ ng build --prod

ERROR in node_modules/@types/jsdom/index.d.ts:12:10 - error TS2305: Module '"../../parse5/lib"' has no exported member 'ElementLocation'.

12 import { ElementLocation } from 'parse5';

🔬 Minimal Reproduction
Run ng build
💻Your Environment
Angular Version:

Angular CLI: 9.0.5
Node: 10.16.3
OS: darwin x64

Angular: 9.0.5
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.5
@angular-devkit/build-angular     0.900.5
@angular-devkit/build-optimizer   0.900.5
@angular-devkit/build-webpack     0.900.5
@angular-devkit/core              9.0.5
@angular-devkit/schematics        9.0.5
@angular/cdk                      9.1.1
@angular/fire                     5.4.2
@angular/material                 9.1.1
@ngtools/webpack                  9.0.5
@schematics/angular               9.0.5
@schematics/update                0.900.5
rxjs                              6.5.4
typescript                        3.7.5
webpack                           4.41.2

Scully Version:

{
  "name": "msp-navigator",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build --aot",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e",
    "postinstall": "ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points",
    "scully": "scully",
    "scully:serve": "scully serve"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "^9.0.5",
    "@angular/cdk": "^9.1.1",
    "@angular/common": "^9.0.5",
    "@angular/compiler": "^9.0.5",
    "@angular/core": "^9.0.5",
    "@angular/fire": "^5.4.2",
    "@angular/forms": "^9.0.5",
    "@angular/material": "^9.1.1",
    "@angular/platform-browser": "^9.0.5",
    "@angular/platform-browser-dynamic": "^9.0.5",
    "@angular/router": "^9.0.5",
    "@ckeditor/ckeditor5-angular": "^1.2.2",
    "@ckeditor/ckeditor5-build-classic": "^17.0.0",
    "@fortawesome/angular-fontawesome": "^0.6.0",
    "@fortawesome/fontawesome-svg-core": "^1.2.27",
    "@fortawesome/free-brands-svg-icons": "^5.12.1",
    "@fortawesome/free-regular-svg-icons": "^5.12.1",
    "@fortawesome/free-solid-svg-icons": "^5.12.1",
    "@ncstate/sat-popover": "^4.0.0",
    "@scullyio/init": "0.0.23",
    "@scullyio/ng-lib": "latest",
    "@scullyio/scully": "latest",
    "angular-google-tag-manager": "^1.1.1",
    "core-js": "^3.6.4",
    "country-data-list": "^1.1.9",
    "firebase": "^7.10.0",
    "firebase-tools": "^7.14.0",
    "firebaseui": "^4.4.0",
    "firebaseui-angular": "^4.0.1",
    "ng-click-outside": "^6.0.0",
    "ngx-virtual-scroller": "^4.0.2",
    "ngx-webstorage-service": "^4.1.0",
    "rxjs": "^6.5.4",
    "tslib": "^1.11.1",
    "zone.js": "~0.10.2"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "^0.900.5",
    "@angular/cli": "^9.0.5",
    "@angular/compiler-cli": "^9.0.5",
    "@angular/language-service": "^9.0.5",
    "@types/jasmine": "^3.5.8",
    "@types/jasminewd2": "~2.0.8",
    "@types/node": "^13.9.0",
    "@types/segment-analytics": "0.0.32",
    "codelyzer": "^5.1.2",
    "jasmine-core": "~3.5.0",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "^4.4.1",
    "karma-chrome-launcher": "~3.1.0",
    "karma-coverage-istanbul-reporter": "^2.1.1",
    "karma-jasmine": "^3.1.1",
    "karma-jasmine-html-reporter": "^1.5.2",
    "protractor": "^5.4.3",
    "ts-node": "^8.6.2",
    "tslint": "^6.0.0",
    "typescript": "~3.7.0"
  }
}

🔥 Exception or Error

ERROR in node_modules/@types/jsdom/index.d.ts:12:10 - error TS2305: Module '"../../parse5/lib"' has no exported member 'ElementLocation'.

12 import { ElementLocation } from 'parse5';

@Burgov Do you have en reproduction repo? We can not reproduce. We have it working on Linux, Mac, Windows,  ChromeOS and GitHub actions.
Parse5 seems to be a dependency of the Angular CLI, we are not using it anywhere inside Scully.
I'm willing to investigate deeper, but I do need a way to reproduce the error.

@SanderElias I've sent you a message on LinkedIn regarding this

@Burgov I had the same issue and in order to solve it I removed the node_modules folder and npm install agin. I am using node 12.16.1, but it should also weork with v10.16.3

@GuzmanPI thanks for the suggestion but unfortunately that's not working for me.

@Burgov there maybe an underlying issue with "@types/jsdom" https://github.com/DefinitelyTyped/DefinitelyTyped/issues/26338?
You may want to try and do a npm i @types/jsdom@@16.1.0 does that work out of curiosity?

Got the same issue.
Quick fixed it by updating parse5 package.
try to run npm i -D parse5@latest
I then deleted the parse5 line from my package.json to keep it clean for further corrections.

@Silvac34 that did the trick, thanks!

@Burgov Thanks for the confirmation.
To summarize, This bug is caused by an outdated 3rth party npm module `parse5, and solved by updating that module to its latest version by running:
npm i -D parse5@latest

I'm going to close this issue as Scully can not do anything to prevent  NPM package clashes.