Limitations on this library vs lowpowerlab

I am currently building an FCC certified module with HopeRF and wanted to know if using the DIO0 pin for interrupt vs what you recommend matters or not. The lowerpowerlab version only uses that pin. Would you recommend anything else connected to the Atmega328P for proper functions? If you would like to discuss on skype, message me: brolly759.

I am currently building an FCC certified module with HopeRF and

To maximize usability of your module I would breakout all the DIO pins.

wanted to know if using the DIO0 pin for interrupt vs what you recommend matters or not. The lowerpowerlab version only uses that pin. Would you recommend anything else connected to the Atmega328P for proper functions?

Yes, it matters, as you hopefully have read in the readme this library uses a different mechanism to determine whether transmissions are finished or messages have come in. Using the automode system to let the radio control the RF frontend, instead of switching it manually.
You may be able to get away with just DIO0, please see #3 for discussion on this. If you happen to test this, please chime in on that issue.
As said, I would breakout all the DIO pins as that guarantees all flexibility of the original radio module is retained. Remember that DIO2 is used as the data pin in the continuous mode and no other DIO pin can be used for the data in continuous mode. If DIO2 isn't broken out you can never use continuous mode, not a problem for most people, but you do limit the functionality.

So you basically recommend I disconnect DIO0 from INT and let the user decide. The issue I am finding is the module dimensions are fairly large doing it that way, right now with a U.FL connector I am 18x20mm.
Continuous mode would have issues with FCC as I was told by HopeRF that my max TX time (FSK) is 30ms every 100ms. So far continuous mode is just good for RF testing / antenna tuning / Impedance matching.
The module right now has everything broken out, including a separate VCC rail for RF and MCU.  W25X40 Flash chip for ID number and extra storage for OTA and other stuff. RF Reset Pin connected to IO pin on mcu and Radio CS pin exposed to use ISP on MCU.

So you basically recommend I disconnect DIO0 from INT and let the user decide.

That's what I would do yes, but I can see your argumentation for not doing this. It's a shame the DIO0 pin doesn't have a - connection in the Rx mode, if that existed and the pin would be high impedance in that state you could've connected DIO0 and DIO2 together.
Hmm, I have to admit I don't remember this exact details of #3 when it came up. If the solution proposed there works well it's a non issue. Perhaps you can test that to confirm this library works for DIO0?
Alternatively, a small SMD soldering jumper / cuttable trace doesn't have to take a lot of real estate, that way users who really want to can switch between them. Ah well, just a suggestion. I think this library has significantly less users than the LowPowerLabs or Radiohead ones, because it's younger and doesn't deal with protocol stuff (on purpose), I guess a soldering jumper may be good enough for those who dive down the rabbit hole and want to squeeze performance to a max by using this library?

Continuous mode would have issues with FCC as I was told by HopeRF that my max TX time (FSK) is 30ms every 100ms.

Oh yes, continuous mode can easily violate any RF regulation. But so can packet mode, either way I think you're right in the statement that packet mode will cover most use cases.

The module right now has everything broken out, including a separate VCC rail for RF and MCU. W25X40 Flash chip for ID number and extra storage for OTA and other stuff. RF Reset Pin connected to IO pin on mcu and Radio CS pin exposed to use ISP on MCU.

Cool, including the RFM's reset pin is indeed paramount, that was one of the issues we encountered in #1. I would suggest placing a large capacitor near the radio module's VCC by the way. I've found that the transmissions are much more reliable if an electrolytic capacitor is placed close to the radio module, especially when powered over USB. But you probably already figured that out.

I use the lowerpowerlab currently in prototypes and it works for what I want it to do but I was hoping to build from the ground up using your RF stack, including custom ways to do OTA.
From my recollection I did try your DIO0 example and it worked. Though according to the datasheet, automode looks to be only available on DIO2? Unsure
Page 48
http://www.orcam.eu/res/Datablad/rf69v12.pdf
Why would others do things manually and not use automode? Would there be a time when automode was not efficient?
RFM Reset is connected directly to a GPIO and not available through external pin.
FCC Module has a metal can on top, a user wouldnt be able to do a solder jump switch sadly.
I am going to try and possibly get working a polling RX sensor, where the sensor can have RX in nanoseconds listening and go back to sleep in case I want to send the radio a message while sleeping... Have you had any experience in this?

From my recollection I did try your DIO0 example and it worked. Though according to the datasheet, automode looks to be only available on DIO2?

Yeah, automode is only available on DIO2, the DIO0 example works by still using the automode system, but relying on the CrcOk and PacketSent events. This should work just as well.
For the CrcOk the manual states:

if the CRC check fails then the FIFO is automatically cleared and no interrupt is generated

So that means we should be good even if the CRC fails. And for sending the interrupt goes high when the packet is sent completely, which should also be good enough. But given that it hasn't seen a lot of testing I'm a bit reluctant to state in the readme that it works with DIO0.

Why would others do things manually and not use automode? Would there be a time when automode was not efficient?

Good question... I don't remember the exact details, but if I remember correctly the transmit and receive modes were described in reasonable detail in chapter 4 of the datasheet. So the standard way is to load data, and then manually switching to Tx mode, switching back to Idle after the transmission has been completed. This requires more SPI transmissions and will result in the PLL / RF synthesiser being enabled for (slightly) longer than strictly required, same on receive if I remember correctly. I think the main reason comes from the fact that the automode stuff is only described with one paragraph in the datasheet. To get to a working automode system you'll naturally first develop manual state switching, at which point you basically already have what you want; communication.
Using the automodes to modify the states on the radio requires setting up RegAutoModes 0x3B with the appropriate flags, and for transmission you have to set RegFifoTresh 0x3C correctly as well to start the transmission at the right FIFO size. It's not that hard, but it does require a bit more work to figure out than manually switching the radio's mode. The benefits are likely small, unless you are pedantic about power usage or data rates.

RFM Reset is connected directly to a GPIO and not available through external pin.

As long as you can send a hard reset through software, that's good enough.

FCC Module has a metal can on top, a user wouldnt be able to do a solder jump switch sadly.

I see, well, maybe not a problem given that you tested DIO0 and it works.

I am going to try and possibly get working a polling RX sensor, where the sensor can have RX in nanoseconds listening and go back to sleep in case I want to send the radio a message while sleeping... Have you had any experience in this?

Don't have a lot of experience with it, but do remember trying it once. You can probably put one of the DIO pins into a mode where you can see / measure how long the Rx mode is enabled. I remember I implemented the list mode methods to modify the registers associated to it. Those methods and the description in 4.3 of the datasheet should get you started, goodluck! :)

Thanks for all the input. I use the Atmega328p for this and it does what I need but I was thinking of porting over to the SAMD21 or the SAML21. Have any recommendations?

I would definitely switch away from an Atmega328p, going towards a 32 bits microcontroller with a lot more RAM than the Atmega328p helps a lot when you want to do more complex computation (oh, and interrupts on ALL pins, not just two). I don't have any recommendations in particular, I've developed this library with the Teensy 3. But the SAMD21 you mention appears very similary to the Teensy LC, which is more then enough for most projects.

I just submitted a pull request that adds direct support for DIO0-only and high-power modules. I tested it using a SAMD21-based module: https://www.adafruit.com/product/3176

I am using this library with esp12f, used minimal interrupt method, communication distance between two modules is very low only 5-10 cm. How to increase this distance?

I am using this library with esp12f, used minimal interrupt method, communication distance between two modules is very low only 5-10 cm. How to increase this distance?

@ramanc51 , this question is completely irrelevant to this thread. You should have made a new issue. Sounds like an hardware problem, check that power supply and capacitance is adequate, antenna's are the correct size and the configuration is identical on both. Please don't reply to this issue any further, if you have more questions make a new issue.


Fixed import error that occurs when using the library in next.js 14

The error that occurs when using the AwokeRef in a next.js component is:  Module not found: Default condition should be last one
The root cause is an out-of-order declaration in the package.json file. Silly I know, but just swapping the order of the declarations in the file fixes the problem.
Great library by the way. Thanks for doing all the heavy lifting.

@the-jack-cox  Many thanks for taking the time to debug this and submit a fix - I've merged and published the updated package on npm


Second Contribution by Emile-Daisy

Name: Emile-Daisy
Project Analyzed: https://docs.djangoproject.com/en/4.1/#the-django-open-source-project | https://openjsf.org/
Link to the The Django open-source project Governance Model: https://www.djangoproject.com/weblog/2020/mar/12/governance/
Link to the OpenJS Governance Model: https://openjsf.org/about/governance/
I will analyze Django open-source project and OpenJS open source projects to draw a comparative analysis between their governance models.
Django
Django is an open-source web framework written in Python that allows developers to build web applications quickly and efficiently. It provides a set of tools and libraries that enable developers to create scalable, secure, and maintainable web applications.
Being an open-source framework, Django is freely available and can be used, modified, and distributed by anyone. The source code of Django is openly available for anyone to view, study, and contribute to, which has led to a vibrant community of developers who continue to improve and enhance the framework. Django is used by many well-known companies, including Instagram, Pinterest, and Mozilla, to build their web applications. Its popularity is due to its ease of use, robustness, and flexibility, making it an ideal choice for building complex web applications.
OpenJS
OpenJS is a community-driven open-source organization that supports the development and maintenance of JavaScript projects and related technologies. It was created in 2019 when the Node.js Foundation merged with the JS Foundation. OpenJS provides a home for projects such as Node.js, jQuery, Dojo, and many others. The goal of OpenJS is to foster collaboration and growth within the JavaScript ecosystem by providing resources and support for developers, contributors, and users. The organization offers various services, including project governance, legal and financial support, and community events, to ensure that projects remain sustainable and vibrant over time.
Project Overview
It is clear from the foregoing that both communities are well-established in the open source world. Although both Django open-source project and OpenJS are open-source projects, their governance models differ significantly.
Differences
OpenJS and Django are two popular open-source projects with different governance models.
OpenJS is a project under the umbrella of the OpenJS Foundation, a non-profit organization that aims to support the growth and sustainability of JavaScript and web technologies. OpenJS has a collaborative governance model that involves a Technical Steering Committee (TSC) responsible for the technical direction of the project and a Board of Directors responsible for the strategic direction of the project. The TSC oversees the project's working groups, which are responsible for specific areas of the project, such as testing, documentation, and security. OpenJS also has a Code of Conduct that sets expectations for behavior and outlines consequences for violations.
On the other hand, Django is an independent open-source project with a more centralized governance model. Django's leadership is provided by a small group of core developers who make decisions about the direction of the project. The community contributes to the project through GitHub pull requests, but the core developers ultimately decide which changes are accepted. Django also has a Code of Conduct that sets expectations for behavior and outlines consequences for violations.
In summary, while both OpenJS and Django have codes of conduct, OpenJS has a more collaborative governance model with a larger technical committee and several working groups, while Django has a more centralized governance model led by a small group of core developers.
Similarities
OpenJS and Django are both popular open-source software projects that are managed and governed by their respective communities. However, there are some key differences in their governance models.
In terms of similarities, both projects have a strong focus on community involvement and collaboration. They both have open development processes that allow anyone to contribute code, report issues, and participate in discussions about the future direction of the project. They also both use a similar pull request workflow for reviewing and merging code changes.
Both projects also have a core team of maintainers who are responsible for overseeing the project and ensuring that it stays on track. These maintainers are typically experienced developers who have a deep understanding of the project's codebase and architecture. They are responsible for reviewing and merging code changes, managing releases, and setting the overall direction for the project.
MY OPINION
After presenting the comparative study, I believe that Djamgo's governance model is superior to OpenJS's since governance model of Django allows for faster decision-making and more efficient management of the project unlike that of openJS.

cc @arliss-NF

cc @arliss-NF

cc @arliss-NF

@12Daisy - again, this is amazing.  Your analysis is very good, and the consolidation of information is well done.  My only suggestion is to use bolding and bulleting to make the reading easier and to help folks who skim content find the information they are looking for.    Please move forward with submitting the final application.

Okay ma’am let me complete my final application Sent from my iPhoneOn Apr 3, 2023, at 4:07 PM, arliss-NF @.***> wrote:
@12Daisy - again, this is amazing.  Your analysis is very good, and the consolidation of information is well done.  My only suggestion is to use bolding and bulleting to make the reading easier and to help folks who skim content find the information they are looking for.    Please move forward with submitting the final application.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


styles.css is not exported from package

Versions

gatsby-source-prismic: 5.0.0
gatsby-plugin-prismic-previews: 5.0.0
node:14.17.3

Steps to reproduce
Update to Gatsby v4 and Prismic  5.0.0 (fantastic work on getting that out so quickly) and running any application as normal gatsby develop
What is expected?
The build to complete successfully and Prismic CSS files to resolve.
What is actually happening?
 ModuleNotFoundError: Module not found: Error: Package path ./dist/styles.css is not exported from package /node_modules/gatsby-plugin-prismic-previews )
I am including import 'gatsby-plugin-prismic-previews/dist/styles.css' in both gatsby-browser and gatsby-ssr
(will try and make a minimal repo asap and add to this bug report)

An empty CSS file has been added in v5.0.1. It will be removed in v6.0.0.


Add links for Tooling WG

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-11-19/17570/1


Record Breaker Code+Screenshot

Have you checked the guidelines it's clearly mentioned to go to issues & comment on what you want to solve. Don't PR without following guidelines.


Remove not used regex argument from Wait For Navigation keyword

Describe the bug
Remove not used regex argument from Wait For Navigation keyword

Fixed in https://github.com/MarketSquare/robotframework-browser/pull/1226/commits/f2a8c11ba1823857411d9fcaf3f557cac630dc60


jest installed has not been tested with ts-jest warning

Wondering how I can disable this warning on tests:

typescript: 3.3.3
ts-jest: 23.10.5
jest: 24.1.0
jest.config.js
  globals: {
    __PATH_PREFIX__: "",
    'ts-jest': {
      diagnostics: false
    }
  },

Ts-jest does not yet support Jest 24. There are a few other issues tracking this progress.

any workaround for these warning?

@GeeWee it is over a year later and I am still getting
ts-jest[versions] (WARN) Version 24.9.0 of babel-jest installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=25.0.0 <26.0.0). Please do not report issues in ts-jest if you are using unsupported versions.

in my tests.  After updated to jest 26 I am now getting an issue where I get Cannot find module './App.vue'.. And I am not sure if this is related

@vegerot please use 25.5.1-alpha.0 by installing ts-jest@next :)
Every major version of ts-jest, we limit compatibility like ts-jest 25 is compatible with jest 25, ts-jest 24 is compatible with jest 24.

@ahnpnl Thank you so much!  But wouldn't 25.5.1-alpha.0 actually be the alpha for 26?
But I did try installing that and on first glance it worked!  I know jest-26 just came out, so I shouldn't expect compatibility right away, but do you have estimates for when jest-26 support will come out?

no actually 25.5.1-alpha.0 doesn't contain jest 26 support. First ts-jest wants to solve all the issues related to 25.5.0 first before releasing v26. If everything is smooth, somewhere next week v26 will be released

Alguém desabilitou a mensagem "ts-jest[versions] (WARN) Version 26.0.1 of jest installed has not been tested with ts-jes"  ?

@davijalmeida83 you only can disable it by using the right compatible version. jest 25 ts-jest 25, jest 26 ts-jest 26

Same for jest  27.5.1

Same here, using jest 27.5.1.
Anyone had an update about it?

ts-jest major version follow Jest major version. Please read our https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md

This did the trick for me, maybe it helps:
export TS_JEST_DISABLE_VER_CHECKER=true

Source:
https://github.com/kulshekhar/ts-jest/issues/958#issuecomment-780919904


original basic code

Hello, can you share the original basic code?

I only implemented the final model of the paper. So I'm afraid that I can't provide baseline code and you could, alternatively, implement that on the basis of  this code.


Operator Coalescing

During Function->FunctionStage1 transformation, members of an object are coalesced to optimize code generation. We want to do the same for operators.

@atzannes you did this in 72370c6, right?

Yes!


crashbug thermal dynamics

after I put a flux plated fluiduct next to a stirling generator, game & server crash with:
http://pastebin.com/GkwsiN4t
have installed:
EnderIO-1.7.10-<IP_ADDRESS>9
CoFHCore-[1.7.10]3.0.0RC2-201
ThermalDynamics-[1.7.10]1.0.0RC2-89
ThermalExpansion-[1.7.10]4.0.0RC2-131
ThermalFoundation-[1.7.10]1.0.0RC3-57

It seems that it has something to do with the new dual ducts (Flux plated fluiduct is RF and Fluids), because this does work:
http://imgur.com/tdK44Kk

This is due to a mod in your environment having an outdated RF API, not EIO's fault.


unable to do local debugging for ALC related features because login does not work

When using VisCode Debug Runcfg Pythzon:Qaurt and Runcfg Frontend:Watch and trying to login via the login button i get below error
Sorry, but we’re having trouble signing you in.

AADSTS650056: Misconfigured application. This could be due to one of the following: the client has not listed any permissions for 'Microsoft Graph' in the requested permissions in the client's application registration. Or, the admin has not consented in the tenant. Or, check the application identifier in the request to ensure it matches the configured client application identifier. Or, check the certificate in the request to ensure it's valid. Please contact your admin to fix the configuration or consent on behalf of the tenant. Client app ID: XXXXXXXXXXXXXXXXXXXXXXXXX.

I am using
AZURE_USE_AUTHENTICATION="true"
AZURE_ENABLE_GLOBAL_DOCUMENT_ACCESS="true"
AZURE_ENABLE_UNAUTHENTICATED_ACCESS="false"
AZURE_ENFORCE_ACCESS_CONTROL="true"
Testing without login  raises the below
"Error: Request failed with status 403"

The stack trace is ...
INFO:root:get_token_auth_header.authNone
ERROR:root:Exception getting authorization information - "Authorization header is expected"
Traceback (most recent call last):
  File "/../app/backend/core/authentication.py", line 217, in get_auth_claims_if_enabled
    auth_token = AuthenticationHelper.get_token_auth_header(headers)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/mnt/c/git/openai/mic-docbot/app/backend/core/authentication.py", line 139, in get_token_auth_header
    raise AuthError(error="Authorization header is expected", status_code=401)
core.authentication.AuthError: Authorization header is expected
[2024-11-02 11:01:03 +0100] [1325733] [INFO] <IP_ADDRESS>:34410 POST /chat/stream 1.1<PHONE_NUMBER>9

Reason: The function get_auth_claims_if_enabled()->get_token_auth_header() is called an mandatory requires  x-ms-token-aad-access-token
When i set below...

AZURE_USE_AUTHENTICATION="false"
USE_USER_UPLOAD="false"

..i can run queries but then i am unable to debug authorization context features like ACL switched on by AZURE_ENFORCE_ACCESS_CONTROL.
But How to make the login works on local development?
Even if if use the same same PRINCIPAL for the execution of the debugged app on vscode as i do for the cloud successfully i get above error message,
Btw i spotted a bug : Overriding the env vars in then vscode launch.,json ""env": .." section does not work because of load_azd_env.py
always gives the dot env presence. Therefore i changed
load_dotenv(env_file_path, override=True)
to
load_dotenv(env_file_path, override=False)

I am able to use local debugging using either the frontend server (and configuration):
http://localhost:5173/
Or the backend server (and configuration)
http://localhost:50505/
Are you getting this error with http://localhost:50505/ ?

yes, the the latter on 50505

Setup look good for me. Client app has API permission on server app as requested and it work when running from azure

Setup look good for me ..and works on azure

Here are screenshots from my Application configuration, from various pages in the portal. Can you cross-check with these?

This is in the CLient App Registration, right
Why did you add Ms Grapgh User.Read? This is missing in the documentation, isn' it?
I have set http://localhost:50505/redirect but neither http://localhost:5173 or the backend uri. Both was not mentioned in the docs at all, was it?

I am updating the docs now to add the missing redirect and permission


Make ingest V2 the default ingest

We will ship the ingest V2 for 0.9. It should be activated by default. I suggest making it the default now on the main branch.

Should we add https://github.com/quickwit-oss/quickwit/issues/4438 to the 0.9 milestone if ingest V2 becomes the default?

@fmassot just to be sure, in 0.9 we would activate it but leave it as a separate endpoint? any idea what the endpoint semantics would be? do we want to stay with {index_id}/ingest-v2?


WIP: Bug fix for saving dependency modules in version range format

PR Summary
Bug fix for finding a module with version specified as a version range (eg. "[1.2.2, 1.2.2]").
PR Context
Resolves #1313
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Documentation needed

[ ] Issue filed:

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

@alerickson please look at CI failure

@adityapatwardhan just fixed it, the 'MinVersion' should have been 'MaxVersion'


Update CSI external-snapshotter version to v6.2.1

Update CSI external-snapshotter version to v6.2.1
ref: 6283
After upgrade CSI external-snapshotter version,  use snapshot.storage.k8s.io/v1beta1 to create VolumesnapshotClass, VolumeSnapshotContent, VolumeSnapshot despertched.
Change snapshot.storage.k8s.io/v1beta1 to snapshot.storage.k8s.io/v1 in test script.

LGTM.
I think we only need to backport to 1.5.x, right?

Yes v1.4.2 documentation specified use CSI external-snapshotter v5.0.1 which is the current value on v1.4.x.

@Mergify backport v1.5.x


Latest Update from the submitted PRs

There have been THREE PRs recently

https://github.com/godotengine/godot-csharp-visualstudio/pull/31
https://github.com/godotengine/godot-csharp-visualstudio/pull/32
https://github.com/godotengine/godot-csharp-visualstudio/pull/35

Please provide the following information

Are these PRs work for VS2022 or Just VS2019.  Suggestion: please include VS2022
What environment have people tested these PRs.   Godot3 or Godot4 and what version. What is your experience?

I am interested to know if these PRs work with Godot4 with dotnet6 merged

I compiled the plugin xd

I saw under extension...GoDot and configure...but it crashes..
Share screenshots..please

i can send u the compiled plugin? and i fixed the GoDot bug replaced with Godot

Yes..please share ..do u use Google drive to share

The extension: https://www.mediafire.com/file/24ch2tz6u6embbq/GodotAddinVS.vsix/file

Btw u should help me by telling the owner of the PR to make some changes i mention in the PR of his/her

If this works, i will promote through godot discord

who are you

If this works, i will promote through godot discord

Dont promote me, promote the guy who make these changes

@GeorgeS2019 does it work?

@PandoCyclone
I installed the extension to VS2022.
I see the Godot submenu under the Extension Top menu
I provide the Godot exe path to the the Godot Configure submenu
Then I launch Godot (Click)
The Godot exe specified during configure started and run the scene file (chosen)
====> However, the editor did not stop at the BREAKPOINT!!

My VS2022 17.4 preview

So it worked or not xd?

btw check this out to be 100% sure
https://github.com/jiiks/godot-csharp-visualstudio

Just so we are on the same page.
There is no more Play in Editor button
There is no more extra steps we need to do a few months back
Now, we define the godot exe path and Luanch Godot.

Just so we are on the same page.
There is no more Play in Editor button There is no more extra steps we need to do a few months back
Now, we define the godot exe path and Luanch Godot.

Yes but there is some problem as i mentioned here https://github.com/godotengine/godot-csharp-visualstudio/pull/32#issuecomment-1232433130 which should make it even better

By making icon for the button and make the button replaced with the Debug one or at least in the tool bar

I suggest U do a gif animated showing that it debug and stop at BreakPoints

I suggest U do a gif animated showing that it debug and stop at BreakPoints

The breakpoints bug is from the plugin itself not because this PR

Is the breakpoints bug VS2022 version dependence?
If yes, showing that it works now with other version of VS2022 will also help a lot.
We need the breakpoints <=== to work

I will be away.  Thanks for the effort of sharing.
I compile  https://github.com/jiiks/godot-csharp-visualstudio
Godot run from VS2022 but NOT breakpoint
This version is GoDot and not Godot

For me I don't even know what breakpoints are but you can ask everyone or just watch youtube videos they show that breakpoints bug not work and some workaround for that too. Here is a video for example: https://www.youtube.com/watch?v=lOjOb4Lv_ww&list=WL&index=2&t=992s&ab_channel=FinePointCGI

I will be away. Thanks for the effort of sharing. I compile https://github.com/jiiks/godot-csharp-visualstudio
Godot run from VS2022 but NOT breakpoint This version is GoDot and not Godot

Try my fix i sent upthere which fix the bug showing GoDot replaced with Godot and other enhance please check this https://github.com/godotengine/godot-csharp-visualstudio/pull/32#issuecomment-1232433130 comment and support for better PR

The old version, a few months back, the breakpoint WORKs BUT extra steps just to make it works

I assume this is Jiiks's plan

Step1: Allow use of Visual Studio command line arguments - to launch Godot in realiable way not possible through the StudProj

Step2: Add a menu for launching GoDot from visual studio - to trigger the step1

Step3: Change GoDot to Godot

Step4 + follows;  Look into Neikeq code how to trigger the debugging!  As Jiiks's steps has addressed the main issues of the StudProj, unreliable way to launch Godot

Step5: implement thse debug targets or sub menu After Step1 supports reliable launching of Godot

Summary
Debug targets

Play in Editor
Launches the game in the Godot editor for debugging in Visual Studio.
For this option to work, a running Godot instance must be editing the project.
Launch
Launches the game with a Godot executable for debugging in Visual Studio.
Before using this option, the value of the "executable" property must be changed
to a path that points to the Godot executable that will be launched.
Attach
Attaches to a running Godot instance that was configured to listen for a debugger connection.

Information provided by Neikeq how to get the extension to work with Godot4

Side note, think I've asked this before maybe, do you know of any way to attach a C# debugger to the C# module code in godot on Linux? To be able to set breakpoints in the modules/mono .cs files, run the editor and step through things? I feel like the answer is no, it seems to be possible on Windows with VS but no Linux tool I've tried is capable of the same "mixed mode" debugging magic that MS have.

I don't know about mixed mode, but for C# only I can do this in Rider:

Add New Cofiguration: .NET Executable

Exe path: Path to Godot executable
Program arguments: --path /path/to/godot/project/
Runtime: .NET / .NET Core

I tried this with VSCode, but I don't remember if it worked:
{
    "name": ".NET Core Launch (console)",
    "type": "coreclr",
    "request": "launch",
    "program": "Path to Godot executable",
    "args": ["--path", "/path/to/godot/project/"],
    "stopAtEntry": false,
    "console": "internalConsole"
}

As for Windows and Visual Studio, you must add the following to your csproj (or a Directory.Build.props):
  <PropertyGroup>
    <StartAction>Program</StartAction>
    <StartProgram>C:\Path\To\Godot.exe</StartProgram>
    <StartArguments>--path C:\Path\To\Godot\Project\</StartArguments>
  </PropertyGroup>

From neikeq: The root of the issue applies to Godot 4 as well. However, there are other challenges as well, like how to implement Play in Editor with the CoreCLR debugger.

Debugging CoreCLR
"To debug this project, configure it to use the 'Managed (CoreCLR)' debugger." when trying to debug multi target framework in .NET Core

case ExecutionType.Launch:
var processStartInfo = new ProcessStartInfo(GetGodotExecutablePath())
{
    string workingDir = startInfo.WorkingDirectory;

    Arguments = $"--path {workingDir} --remote-debug {host}:{remoteDebugPort} {godotStartInfo.StartArguments}", // TODO: Doesn't work with 4.0dev. Should be tcp://host:port which doesn't work in 3.2...
    WorkingDirectory = workingDir,
    RedirectStandardOutput = true,
    RedirectStandardError = true,
    UseShellExecute = false,
    CreateNoWindow = true
};

Running a specific Scene

case ExecutionType.PlayInEditor:
var godotMessagingClient = GodotPackage.Instance.GodotSolutionEventsListener?.GodotMessagingClient;

// TODO: Read the editor player stdout and stderr somehow

case ExecutionType.Attach:
_attached = true;
StartConnecting(godotStartInfo);

Running a specific Scene :
Feature Request: 'Play Scene' from Visual Studio
Debugging a specific Scene
Running/Debugging a specific script

Umm, so there is a way to change GoDot to Godot

I have some suggestions

This Launch make it Godot cuz it is Godot not GoDot :)
And you can add the Godot icon for the Godot menu and its Launch button
And make the launch button save the current scene before launch?

You can replace the debug button(the one that have C# text thingy) with your launch button with the Godot Engine icon
Edit: I found a workaround for have launch with Godot in tool bar but there is no icon there so adding Godot Engine icon might look great

Or place a Godot button next to the live share button cuz it is more efficient
And btw what is the use of the configure button

I have some suggestions

This Launch make it Godot cuz it is Godot not GoDot :) And you can add the Godot icon for the Godot menu and its Launch button And make the launch button save the current scene before launch?

You can replace the debug button(the one that have C# text thingy) with your launch button with the Godot Engine icon Edit: I found a workaround for have launch with Godot in tool bar but there is no icon there so adding Godot Engine icon might look great

Or place a Godot button next to the live share button cuz it is more efficient
And btw what is the use of the configure button

Btw this is the suggestions so anyone like it could help

@GeorgeS2019 I think you could close this Issue because it is not necessary anymore.


Table validator controllers are not discoverable

Discussed in https://github.com/orgs/tablelandnetwork/discussions/228

Originally posted by sanderpick August 19, 2022
There's currently no way to list the EOA address that have been granted write permission to a table. This is an issue for a couple reasons:

After using GRANT, it's natural to wonder if it worked.

The txn could succeed, but you may have had an error in the SQL statement.
Even if the SQL statement was validated, you might just want to sanity check by listing the current controllers.

It would be nice if dapps (or even the SDK) did some checking to ensure you have access to a table and don't waste funds.

Stepping back, we have two avenues to access control:

Validator based access control with GRANT and REVOKE
Smart contract based access control with Policys

If we had an API for getting validator based access control info, the SDK could combine that with a view of the current on-chain controller in a unified data model that could be presented to the user.

Converted from discussion. @brunocalza assigning to you even though this may not be doable / more complicated than it sounds... we can discuss here.

@brunocalza iirc, there's an undocumented endpoint for this, right? thinking of a way to show access info for a table in the admin dash. cc @awmuncy

@brunocalza iirc, there's an undocumented endpoint for this, right? thinking of a way to show access info for a table in the admin dash. cc @awmuncy

There's no endpoint for this. As a workaround, you can query the system_acl table.

@sanderpick This should be a straightforward add. As soon as I finish what I'm working on now, I'll scope how this endpoint will look like and work on it

Thanks, @brunocalza. It would be a quite useful addition.
A related issue (https://github.com/tablelandnetwork/evm-tableland/issues/135) discusses moving GRANT / REVOKE to a contract based solution, but if/when we do that, we'll still need a validator endpoint that can provide a legacy mapping, ie, if validator-side rules exist, return those, if not, read rules from contract. Or maybe there's a migration path that would avoid needing a validator-side endpoint at all (we can discuss that on the linked issue), we could explore that and for now use the system_table to show table permissions in the admin UI.

I propose adding the REST call GET /chain/{chainID}/tables/{id}/acl returning the list of controllers with its privileges:
[
   {
      "controller":"0x713687B93CB07ff99212b3B87F701b3A9ae5c184",
      "privileges":"a,w,d"
   }
]

wdyt? @sanderpick

I think this makes sense to me.  Is the goal that the SDK will have a method that calls this ../{tableid}/acl endpoint, then calls the getPolicy function on the controller contract and returns a combination of that data to the sdk caller?

There is the additional (current) problem of having the "controller" endpoint, which doesn't actually do what it sounds like it does. This might be confusing... that one should probably be renamed to owner. But I'd also like to point out the discussion that @sanderpick links to, which might mean we don't need this new endpoint at all if we decided to go that route?

cool. I like the look of that, but i think "controller" here is misleading / confusing alongside the notion of controller in the registry. ideally we can differential between the table owner (the address that controls access) and granted addresses, e.g.,
{
    "owner": "0xowner_address_of_table_token",
    "rules": {
        "0xowner_address_of_table_token": {
            "insert": true,
            "update": true,
            "delete": true
        },
        "0xsome_other_address_granted_access_by_owner": {
            "insert": false,
            "update": true,
            "delete": false
        }
    }
}

that's a rough stab, but the nice thing here is that we can back this into https://github.com/tablelandnetwork/evm-tableland/issues/135, and more complex rules. i've had a todo for a while to scope out a notion of more complex rules that we could bake into GRANT statements, reducing the need for people to deploy custom controller contracts. let me get to that before we jump in here as there is some overlap.

that schema is awesome. it has the owner and the ACL rules in the same payload. well thought!
marking this issue as on-hold while we wait for that doc

We're moving grant/revoke to contract based solution. Closing this


Accept null value for filters, group_cols

R is able to pass these as a null value or empty object.  Current JS version only accepts empty array.
Per @jwildfire, it is favorable to pass/accept a null value in this case.

Nevermind, passing a null value from R works fine.


Add support for recursive text splitter

This will be very useful to include:
https://python.langchain.com/docs/modules/data_connection/document_transformers/text_splitters/recursive_text_splitter

Thanks! Great resource


Topic recognition - MRI Super Resolution Network (Elijah Nelson 46991553)

MRI Super Resolution Network (Elijah Nelson 46991553)
Abstract
This project implements a brain MRI super-resolution network by training on the ADNI brain dataset. The network is trained to up-scale from 4x down-sampled input images and produce reasonably clear output images.
As proposed by Shi, 2016, the model utilises efficient sub-pixel convolution by extracting feature maps in the low-resolution space. This reduces computational complexity by waiting until the end of the model to reconstruct to higher dimensions.
An example of the model upsampling a low-resolution image to a higher resolution image:

Added files
doc/        # Folder for images used in the README
imgs/       # Folder that generated images are saved to
config.py   # Hyperparameters and other constants
dataset.py  # Data transformation, preprocessing and loading
generate.py # Model output generation
modules.py  # Model architecture definition
predict.py  # Example model usage
train.py    # Model training and validation

Dependencies
This project requires the following packages:

pytorch: v2.0.1
matplotlib: v3.7.1

This is an initial inspection - no action is required yet
Difficulty: Normal
General Comments: Solves the problem overall. Improves image quality compared to low-rez images. However, no validation set was used during training. Simply stores the last version of the network at the end of training.
[Recognition Problem]
"modules.py":

Correct implementation of the network, though seems they're using 3 channels rather than 1 grayscale one.
Model architecture mostly the same as PixelCNN, just a few more convolutional layers.
Allows for variable upscaling factor.

"dataset.py":

Uses ImageFolder to load images, though, it requires the user to insert another folder into the file structure (at least this is documented in the README)
Otherwise seems ok, nice check for dimensionality.

"train.py":

Correctly tracks losses during training.
No validation set (though it is claimed in the readme).
Final network is saved.

"predict.py":

Generates some images from the test dataset, though no metrics are performed.

"README.MD":

Provides a brief description of the network architecture.
Demonstrates some input and output images.
Provides training loss but no validation loss or evaluation of metrics on the test set.
Reconstructions seem of higher quality than the low rez versions.
Details expected directory structure.
Has dependencies list.

[Commit Log]
Commit log looks ok.

Marking
Good Practice (Design/Commenting, TF/Torch Usage)
Adequate design and implementation
Good spacing and comments
Header blocks
Recognition Problem
Solves problem
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage, no validation set -1
Difficulty: Normal -5
Commit Log
Meaningful commit messages
Progressive commits used
Documentation
ReadMe acceptable but no usage -1
Model/technical explanation
Good Description and Comments
Markdown used and PDF submitted
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required
Request Description good


Add :CMakeToggle command

This PR adds the :CMakeToggle command. I haven't tested it yet as I am quite new to the neovim scene and am unsure on how to temporarily install a local package. Any guidance on this would be very much appreciated!
Related issue: #82

@cdelledonne Have you had the time to look at This yet?

Not yet, sorry :P It's been a very busy period, but I'll try my best to give it some time this week. Thank you for your patience.

Sorry for the very long delay with this PR. I've left a couple of comments. Could you also update the CHANGELOG please?

I've updated the changelog and version in 8a1699f4c48796bfb9f55813036998c94bb0d533


styles: allow pre code blocks

Related to https://github.com/bpmn-io/form-js/pull/316
This allows using code blocks inside descriptions.
Example

/cc @christian-konrad @RomanKostka


country based fallback

if country based fallback is not available, it returns null instead of the default fallback.

I got what I want by modifying line 68 of Translatable.php, thanks!
i.e. it falls back from zh-hk to zh, and then en
        } elseif ($withFallback
            && $this->isLocaleCountryBased($locale)
            && $this->getTranslationByLocaleKey($this->getFallbackLocale($fallbackLocale))
        ) {
            $translation = $this->getTranslationByLocaleKey($this->getFallbackLocale($fallbackLocale));
        } else{

Hi mate, I ran some tests and it seems that there is no issue with the code. Can you please share the code reproducing the issue?


Add custom tags to AWS resources

Hi!
This is an improvement idea I'd like to share. I'd find it very interesting to be able to add custom tags (other than the cost allocation one) to the AWS resources created.
This is needed to manage the infrastructure due to security reasons. Do you think it's feasible? If you guide me where to start I'll be happy to send you a PR with my proposal.
Thanks!

I believe you can specify custom tags at a cloudformation level to be applied stack wide!

All stack-level tags, including automatically created tags, are propagated to resources that AWS CloudFormation supports. Currently, tags are not propagated to Amazon EBS volumes that are created from block device mappings.
— https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-resource-tags.html

Thanks for answering,
I'd specifically like to add custom tags to the infrastructure (that then will eventually be propagated as you've mentioned).
@lox How can I do so? I've only seen that I can edit the cost allocation one, but I want to add custom ones too.
Thank you!

If you're launching via the AWS web console, then you add tags during the Setting AWS CloudFormation stack options phase of Creating a stack, or you can update an existing stack to add/change any tags you want.
If you're using the aws CLI, it's the --tags option described here.

Thank you for your help! That works flawlessly.


[CARBONDATA-3295] Fix that MV datamap throw exception because its rewrite algorithm when multiply subquery

[Problem]
Error:
java.lang.UnsupportedOperationException was thrown. java.lang.UnsupportedOperationException 	at org.apache.carbondata.mv.plans.util.SQLBuildDSL$Fragment.productArity(SQLBuildDSL.scala:36) 	at scala.runtime.ScalaRunTime$$anon$1.<init>(ScalaRunTime.scala:174) 	at scala.runtime.ScalaRunTime$.typedProductIterator(ScalaRunTime.scala:172)
MV sql:
create datamap data_table_mv using 'mv' as  SELECT STARTTIME,LAYER4ID,  COALESCE (SUM(seq),0) AS seq_c,  COALESCE (SUM(succ),0)  AS succ_c  FROM data_table  GROUP BY STARTTIME,LAYER4ID
Query sql:
SELECT  MT.3600AS3600,  MT.2250410101AS2250410101,  (CASE WHEN (SUM(COALESCE(seq_c, 0))) = 0 THEN NULL    ELSE    (CASE WHEN (CAST((SUM(COALESCE(seq_c, 0))) AS int)) = 0 THEN 0      ELSE ((CAST((SUM(COALESCE(succ_c, 0))) AS double))      / (CAST((SUM(COALESCE(seq_c, 0))) AS double)))      END) * 100    END) AS rate  FROM (    SELECT sum_result.*, H_REGION.2250410101FROM    (SELECT cast(floor((starttime + 28800) / 3600) * 3600 - 28800 as int) AS3600,      LAYER4ID,      COALESCE(SUM(seq), 0) AS seq_c,      COALESCE(SUM(succ), 0) AS succ_c        FROM data_table        WHERE STARTTIME >=<PHONE_NUMBER> AND STARTTIME <<PHONE_NUMBER>        GROUP BY cast(floor((STARTTIME + 28800) / 3600) * 3600 - 28800 as int),LAYER4ID    )sum_result    LEFT JOIN    (SELECT l4id AS 225040101,      l4name AS<PHONE_NUMBER>,      l4name AS NAME_2250410101        FROM region        GROUP BY l4id, l4name) H_REGION    ON sum_result.LAYER4ID = H_REGION.225040101  WHERE H_REGION.NAME_2250410101 IS NOT NULL  ) MT  GROUP BY MT.3600, MT.2250410101 ORDER BY3600 ASC LIMIT 5000
[Solution]
Fix the mv rewrite algorithm to fix this
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2578/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2808/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10837/

@qiuchenjian can you please add the proper description in PR like the problem, root cause and solution proposed ? Just seeing the exception trace and query it is difficult to understand the issue. These details can be added in JIRA.

@akashrn5   done

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2898/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3129/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3170/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11435/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3367/

LGTM


Doesn't say how to create a new theme

It's a glaring omission. The article says, "Once you have found or created a new theme..." but conspicuously fails to state how you create one.  It's a reasonable expectation that any modern editor is going to have a UI for setting up colors, but this is nowhere to be found.
Compounding this problem is the perplexing selection of TextMate themes as the standard, when even TextMate lacks any way to edit its own themes.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 584ac5ab-9547-f2d8-6186-783520b9e1ef
Version Independent ID: 1f76cf76-b4b8-4cbb-c4ed-1c6a6f2130bd
Content: Editor Themes - Visual Studio for Mac
Content Source: mac/editor-themes.md
Product: visual-studio-mac
GitHub Login: @conceptdev
Microsoft Alias: crdun

Visual Studio for Mac does not have a built-in theme editor, however this online tool https://tmtheme-editor.herokuapp.com/ has a wide variety available and the ability to edit and save.
Visual Studio on Windows requires an extension to edit themes - https://marketplace.visualstudio.com/items?itemName=VisualStudioPlatformTeam.VisualStudio2017ColorThemeEditor - so if have you have a Windows computer handy you could also use that, and transfer the theme to your Mac.
I hope this helps liven up your IDE experience.

Thank you for the information, but the document still hasn't been fixed. This is a bug report on the documentation, not the product. Why isn't the information you just provided in the document?


importing hashlib in session.py

Description
GitHub Issues
https://github.com/refindlyllc/python-rets/issues/27

Coverage increased (+0.2%) to 67.647% when pulling 80596bcf32b909ae998fc970ce16c5f41ed6b547 on frozenjava:local-dev into 3a4745a4f9f422712ee9ac04d823a8295c918d16 on refindlyllc:development.

Coverage increased (+0.4%) to 67.848% when pulling 6f6f638ad9c44d74e6fe2aa737a1da7bfdb41644 on frozenjava:local-dev into 3a4745a4f9f422712ee9ac04d823a8295c918d16 on refindlyllc:development.

Coverage increased (+0.4%) to 67.848% when pulling 6f6f638ad9c44d74e6fe2aa737a1da7bfdb41644 on frozenjava:local-dev into 3a4745a4f9f422712ee9ac04d823a8295c918d16 on refindlyllc:development.

Coverage increased (+0.4%) to 67.848% when pulling 6f6f638ad9c44d74e6fe2aa737a1da7bfdb41644 on frozenjava:local-dev into 3a4745a4f9f422712ee9ac04d823a8295c918d16 on refindlyllc:development.

Coverage increased (+0.4%) to 67.848% when pulling 6f6f638ad9c44d74e6fe2aa737a1da7bfdb41644 on frozenjava:local-dev into 3a4745a4f9f422712ee9ac04d823a8295c918d16 on refindlyllc:development.

Coverage increased (+0.3%) to 67.77% when pulling d7008117e320b60dc87bb3bbb8df158ca6f9319c on frozenjava:local-dev into 3a4745a4f9f422712ee9ac04d823a8295c918d16 on refindlyllc:development.

Coverage increased (+0.3%) to 67.77% when pulling d7008117e320b60dc87bb3bbb8df158ca6f9319c on frozenjava:local-dev into 3a4745a4f9f422712ee9ac04d823a8295c918d16 on refindlyllc:development.


Automatically figure out how much a separate GCP project spends in a month

[Yuvi] The only real way to automatically figure out how much a GCP Project cost is to export data to BigQuery. There is pretty much no other automatic way.
Output
This issue will track the things we would need to do to write a script that when run, can produce a table that lists all the projects we have, as well as how much they cost, plus  whom to invoice. So the output should look a bit like this:

Month
Billing Account
Project
Invoicing Entity
Cost (in appropriate currency)

Nov 2022
link-to-billing-acct
name-of-gcp-project
name and email of entity to send invoice to
cost

Nov 2022
link-to-billing-acct
name-of-gcp-project
name and email of entity to send invoice to
cost

Stages to complete
Determine canonical sources of truth for billing information
The entities we have to track are:

GCP Projects
Billing accounts attached to them
Entities that should be billed to these projects

We must make sure that each GCP project is mapped to an entity that should be billed for that project. It could be just us, but it needs to be someone.
Enable BigQuery export for each billing account
Every time we create a billing account, we must enable BigQuery export for that account. Unfortunately this must exist in a project inside the billing account, so we have to choose that. I think this will actually be difficult to automate, so at least for this quarter's goal, we should not try to do that.
Write BigQuery queries to sum monthly total cost for a project
We don't usually care about breakdowns in the project, we just need a total cost. Need a bigquery script that will just output sum of cost for a given billing period (month?). Stackoverflow should have examples
Action items
BigQuery billing enabling

[ ] Add documentation to our 'create new GCP billing account' docs to also enable BigQuery Billing export
[ ] Enable bigquery billing export for all our existing billing accounts

Source of truth recording

[ ] Create a new repository (private) that can contain this source of truth
[ ] Add (as YAML) information about the various billing accounts we have

I wrote up the description on the issue, got distracted halfway through, and ended up implementing most of it instead :( https://github.com/2i2c-org/infrastructure/pull/1947

I was part of the motivating conversations on how this data will be used in our billing/invoicing with CS&S.  @pnasrat if there is anything unclear on requirements please let me know.

@jmunroe thanks I'll pick this up early next week as I'm spending some of my time shadowing support

Reference of sample BigQuery queries for billing https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables/detailed-usage#detailed_usage_cost_query_examples

Updating to reflect @yuvipanda working on dedicated GCP cluster case


[Footer]: Navigation links

Add navigation links to footer and change text
Tasks from #92

Merging this PR will add navigation to the footer
Tasks

[x] Nav links from site config

Screenshot

@rufuspollock @olayway changed the color for footer divider. Please suggest if we keep or not.

@khalilcodes can you update as per discussion

[ ]  Remove divider
[ ] Links same size and color as bottom text (remove underline)
[ ] Tweak spacing in "Made with Flowershow" - reduce space in middle (?)

@rufuspollock updated


Update create-partition-scheme-transact-sql.md

Fix list of "next steps"

@markingmyname
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

This article needs a refresh, so I'll incorporate your change into that. Thanks for your feedback!


Optimize test image

Appveyor build does not start, but the commit is simple enough to merge anyway.


Verify if weighted back-end pod selection is working properly

Ref #467
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

后面可以对.o文件做一个说明记录

后面可以对.o文件做一个说明记录

好，那我下次在readme里介绍工程文件含义的时候加上


Error writing to log while building in windows

I'm running python 2.6 on Windows 7, when I try to build I get the following error:

[1;31mBUILD FAILED - [Errno 22] invalid mode ('w') or filename: u'C:\Users\Josh\PycharmProjects\pybuildtest\target/reports\dependency_unittest-xml-reporting<2.0_install.log'
[0;0m------------------------------------------------------------
It looks like while building the file path for the unit tes logs, the wrong slash was used between target and reports (target/reports instead of target\reports).  When I run the program on a Linux machine running the same version of python I do not get the error.

That's weird, which version of PyBuilder are you on?
Also could you run the whole thing with -X (debug) and post the output in a gist here?
From what I can see we do use os.path.sep and path.join so this should not produce forward slashes on windows.

Never mind, I think I found the issue.

@jphelton would you care to try it with pip install pybuilder --pre --upgrade? Should be fixed now.

@mriehl: It seems there are still places that have the "/" hard coded:
$ git grep /reports src/main/
src/main/python/pybuilder/plugins/python/sphinx_plugin.py:        "$dir_target/reports/{0}".format(task_name))
src/main/python/pybuilder/plugins/python/stdeb_plugin.py:        "$dir_target/reports/{0}".format(task_name))
src/main/python/pybuilder/plugins/python/unittest_plugin.py:        lambda stream: __import__("xmlrunner").XMLTestRunner(output=project.expand_path("$dir_target/reports"),


mm39 reference genome?

Is it possible to use SigProfilerExtractor with the mm39 reference genome?

Hi @conormcguinness9016,
Yes, you can download the reference genome using SigProfilerMatrixGenerator and the list of supported genomes are under the section "SUPPORTED GENOMES". Please reach out if you have any more questions.
Thanks!


Image Updater not able to connect to Gitlab Repo

Describe the bug
A clear and concise description of what the bug is.
I recently upgraded ArgoCD image updater to the latest version v0.13.1. I checked the docs and set the value of applicationsAPIKind: kubernetes as both ArgoCd and the image updater run in the same cluster.
After the update the image updater cannot connect to the gitlab repo. Here is the error:
level=error msg="`git fetch origin --tags --force` failed exit status 128: error: cannot run argocd: No such file or directory\nfatal: could not read Username for 'http://<IP_ADDRESS>:10002': terminal prompts disabled" execID=bbbb3

I cannot figure out where it is looking for the credentials.
Additional context
In the docs the image updater is reading the token from a secret named argocd-image-updater-secret. I do not have any secret created and its not clear from the docs whether it needs to be created if using Method 1 in the Install guide.
Version
ArgoCD image updater: v0.13.1
ArgoCD: 2.11.2

The errors are the same in the other issue #728 . Can you check if this is the same issue?


Deploy to Heroku?

Hi Team,
I was trying to deploy MeiliSearch to heroku using the docker image.
I was not able to. The app continued to crash w/o emitting any useful logs.
I also stumbled across the diff where the heroku artifacts were removed from README and elsewhere.
Is there any prior history of MeiliSearch working/not working on heroku?

@eskombro maybe?

Hey @baskin,
Can you show us the log? When we were using Heroku we didnt use the Docker image, but we used the Rust buildpack.
We removed the one-click button deploy to Heroku, because Heroku does not have a persistent file system so when the heroku dyno is shutted down for any reason, you are losing all of your MeiliSearch data written on disk.

This was from the last run

2020-05-18T11:00:44.158263+00:00 app[web.1]: [2020-05-18T11:00:44Z INFO  meilisearch] Environment: "development"
2020-05-18T11:00:44.158283+00:00 app[web.1]: [2020-05-18T11:00:44Z INFO  meilisearch] Commit SHA: "UNKNOWN"
2020-05-18T11:00:44.158286+00:00 app[web.1]: [2020-05-18T11:00:44Z INFO  meilisearch] Build date: "2020-04-11T09:28:20.281549100+00:00"
2020-05-18T11:00:44.158308+00:00 app[web.1]: [2020-05-18T11:00:44Z INFO  meilisearch] Package version: "0.10.0"
2020-05-18T11:00:44.158357+00:00 app[web.1]: [2020-05-18T11:00:44Z INFO  meilisearch] No master key found; The server will have no securities.If you need some protection in development mode, please export a key. export MEILI_MASTER_KEY=xxx
2020-05-18T11:00:44.158358+00:00 app[web.1]: [2020-05-18T11:00:44Z INFO  meilisearch] If you need extra information; Please refer to the documentation: http://docs.meilisearch.com
2020-05-18T11:00:44.158362+00:00 app[web.1]: [2020-05-18T11:00:44Z INFO  meilisearch] If you want to support us or help us; Please consult our Github repo: http://github.com/meilisearch/meilisearch
2020-05-18T11:00:44.158362+00:00 app[web.1]: [2020-05-18T11:00:44Z INFO  meilisearch] If you want to contact us; Please chat with us on http://meilisearch.com or by email to<EMAIL_ADDRESS>2020-05-18T11:00:44.159048+00:00 app[web.1]: [2020-05-18T11:00:44Z INFO  tide::server] Server is listening on: http://<IP_ADDRESS>:7700
2020-05-18T11:01:42.515883+00:00 heroku[web.1]: State changed from starting to crashed

Hello @baskin,
Can you please tell me how are you running the docker image to be able to reproduce this behaviour exactly?
Also, as @tpayet suggests, you can deploy MeiliSearch with Heroku without the Docker container. And mind the fact that persistence can't be guaranteed
Thanks

I followed the steps listed here
First pulled the meilisearch image from docker hub. The exec'ed the following:

docker tag getmeili/meilisearch:v0.10 registry.heroku.com//web
docker push registry.heroku.com//web
heroku container:release web -a

The problem here might be that the Docker image is built for a specific architecture when Heroku might be running another one.
Maybe should we try to build a multi-arch image for Docker image following the docker documentation

2020-05-18T11:00:44.159048+00:00 app[web.1]: [2020-05-18T11:00:44Z INFO tide::server] Server is listening on: http://<IP_ADDRESS>:7700

It is strange that the binary even started to listen, I thought that a binary compiled for another architecture wouldn't even start at all, but maybe I'm wrong.

Hello @baskin,
Sorry I will close this issue, we already answer this question here.
Thanks,


http_helper.HttpGetWithRetry Passes test when host is not found.

Hello, as the title says, http_helper.HttpGetWithRetry is passing the test even though it is expected to fail.
Logs below.
I've even tried to capture the error and fail the test but with no luck. Assuming this is a bug, or maybe I'm not implementing this function properly.
 Sleeping for 5s and will try again.
TestDeployContainerImage 2021-01-22T13:31:03-05:00 retry.go:103: HTTP GET to URL https://REDACTED.crystald.com/api/health returned an error: Get "https://REDACTED.crystald.com/api/health": dial tcp: lookup REDACTED.crystald.com: no such host. Sleeping for 5s and will try again.
TestDeployContainerImage 2021-01-22T13:31:08-05:00 logger.go:66: release "REDACTED-test-cfzxgl" uninstalled
--- PASS: TestDeployContainerImage (162.81s)
PASS
ok      command-line-arguments  163.169s

Could you share your code?

Could you share your code?

Thanks for getting back to me @brikis98.
I attempted to catch the error with the HttpGetWithRetryE function, but the test still allows dns not found to slip through.
Hope this code block helps. Let me know if you need any more information.
func verifyREDACTEDFeContainer(t *testing.T, tlsConfig *tls.Config) {
	log.Print("Testing REDACTED Frontend")
	maxRetries := 10
	sleep := 5 * time.Second
	expectedServerText := `ALIVE`
	endpoint := "https://REDACTED.crystald.com"
	err := http_helper.HttpGetWithRetryE(t, endpoint, tlsConfig, 200, expectedServerText, maxRetries, sleep)
	if err != nil {
		log.Printf("Failure: %t", err)
		t.Fail()
	}
}

func verifyREDACTEDBeContainer(t *testing.T, tlsConfig *tls.Config) {
	log.Print("Testing REDACTED API")
	maxRetries := 10
	sleep := 5 * time.Second
	expectedServerText := `OK`
	endpoint := "https://REDACTED.crystald.com/api/health"
	err := http_helper.HttpGetWithRetryE(t, endpoint, tlsConfig, 200, expectedServerText, maxRetries, sleep)
	if err != nil {
		log.Printf("Failure: %t", err)
		t.Fail()
	}
}

Thanks for getting back to me @brikis98.
I attempted to catch the error with the HttpGetWithRetryE function, but the test still allows dns not found to slip through.
Hope this code block helps. Let me know if you need any more information.
func verifyREDACTEDFeContainer(t *testing.T, tlsConfig *tls.Config) {
	log.Print("Testing REDACTED Frontend")
	maxRetries := 10
	sleep := 5 * time.Second
	expectedServerText := `ALIVE`
	endpoint := "https://REDACTED.crystald.com"
	err := http_helper.HttpGetWithRetryE(t, endpoint, tlsConfig, 200, expectedServerText, maxRetries, sleep)
	if err != nil {
		log.Printf("Failure: %t", err)
		t.Fail()
	}
}

func verifyREDACTEDBeContainer(t *testing.T, tlsConfig *tls.Config) {
	log.Print("Testing REDACTED API")
	maxRetries := 10
	sleep := 5 * time.Second
	expectedServerText := `OK`
	endpoint := "https://REDACTED.crystald.com/api/health"
	err := http_helper.HttpGetWithRetryE(t, endpoint, tlsConfig, 200, expectedServerText, maxRetries, sleep)
	if err != nil {
		log.Printf("Failure: %t", err)
		t.Fail()
	}
}

Hm, your code looks OK, and the log output clearly shows the error is being detected... That said, your log output is only showing one retry, and your code example only shows the helper functions. Could you share the full code and log output?
Also, are you by any chance using goroutines in your test code? Calling t.Fail in a goroutine does not work.

Hm, your code looks OK, and the log output clearly shows the error is being detected... That said, your log output is only showing one retry, and your code example only shows the helper functions. Could you share the full code and log output?
Also, are you by any chance using goroutines in your test code? Calling t.Fail in a goroutine does not work.

@brikis98 Thank you for the assistance.. The issue was calling the functions in a go routine. Was unaware I could not fail in a goroutine.. Thank you for the clarification. Closing the issue!

@brikis98 Thank you for the assistance.. The issue was calling the functions in a go routine. Was unaware I could not fail in a goroutine.. Thank you for the clarification. Closing the issue!

Good to know, thanks for closing the loop 👍

Good to know, thanks for closing the loop 👍


Tagging for versions since 1.3.270

Could you please add tags to the codebase when a new release of vulkan is handled? The last tag is 1.3.270 but the repo has updates for 272 and 273. Tagging makes it more straightforward to package the correct checkout version for distributions.
Thank you!

I'm not sure I like this idea. The update flow for volk is currently fully automated and is relying on PRs that are auto-merged. This works well because it runs action checks, restricts the permissions in a reasonable way and provides email notifications for repository watchers. My understanding is that to update tags automatically I'd need to completely bypass the PR process for the updates. Additionally, currently regular 1.3.x tags correspond to releases that have release summaries; it requires manual effort to summarize the updates so it's not something that happens frequently.
I would probably recommend using vulkan-sdk-1.3.x tags for distribution; these correspond to Vulkan SDK releases and should be generally speaking consistent across ecosystem (e.g. if you're packaging glslang, you can package from https://github.com/KhronosGroup/glslang/tree/vulkan-sdk-1.3.268.0 tag as well - it will not have any tagging or commits for versions like 272/273). I think the cadence of Vulkan SDK releases is a few months, to get a sense of the number of tags you'll see change with this process.
The only alternative would be to somehow change automatic flow to incorporate tag updates, and come up with some other way of handling GitHub releases. Not sure that's worthwhile.


signing MsgExecuteContract failing

Hi!
I detected an error while signing transaction. Here is sample code to ilustrate the issue:
  const wallet = terra.wallet(mk);
  const singInKYCVault = new MsgExecuteContract(
    wallet.key.accAddress,
    config.terra.kycVaultContract,
    {
      "register_address":
        {
            "address": "terra1x46rqay4d3cssq8gxxvqz8xt6nwlz4td20k38v"
        }
    }
  )

  const signedTxs2 = await wallet
    .createAndSignTx({
      msgs: [singInKYCVault],
    });

While running wallet.createAndSignTx i get this error: 'json: cannot unmarshal object into Go value of type string'.
Testing on version 2.0.5
For exapmle the same code is working properly on version 1.8.5

Which network are you using now?? If you want to use Mainnet or Tequila network, please use v1.x.x terra.js
v2.x.x is for bombay and Columbus-5 upgrade

I am using columbus-4 both mainnet and testnet. Thank you for clarification :)


[sap.m.SplitContainer] masterButtonTooltip

Hi devs,
i would like to set more expressive tooltip for the "MasterButton" within the SplitContainer control.
you already provide the property "masterButtonText", thanks for that.
i suggest additional property "masterButtonTooltip" passed to the masterButton control.
OpenUI5 version: 1.x
What is the expected result?
set up a custom tooltip.
What happens instead?
tooltip "menu2" appears.
Any other information? (attach screenshot if possible)

Hello Danilo,
thanks for this useful feature request. I just contacted the control developer so that he can take a look and decide. He will get back to you soon here and let you know.
Kind Regards,
Michael

Internal Incident<PHONE_NUMBER> is created asking for clarification.

"masterButtonTooltip" property is added:
https://openui5nightly.hana.ondemand.com/api/sap.m.SplitContainer#controlProperties

Available as of UI5 version 1.48.

👍


feat: Use argocd image for sidecar

Description
This allows us to avoid having to manage the versions for helm & kustomize
alongside AVP and argocd, as these binaries are included in the argocd image.
We can add a kustomize images entry to specify / modify the image version from
the kustomization.yaml file.
Fixes: #368
Checklist
Please make sure that your PR fulfills the following requirements:

[x] Reviewed the guidelines for contributing to this repository
[x] The commit message follows the Conventional Commits Guidelines.
[ ] Tests for the changes have been updated
[ ] Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
[ ] Docs have been added / updated
[ ] Optional. My organization is added to USERS.md.

Type of Change

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

Other information
This is intended to be a draft PR just to illustrate my thought in #368. If the maintainers like it I can make it into an actual PR.

Nits fixed!

Codecov Report

Merging #371 (ba3612f) into main (9c7288a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #371   +/-   ##
=======================================
  Coverage   77.64%   77.64%
=======================================
  Files          22       22
  Lines        1011     1011
=======================================
  Hits          785      785
  Misses        142      142
  Partials       84       84

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


[Fix][DAS] Specify the catalog and schema when check table or column …

Purpose of the pull request
Specify the catalog and schema when check table and column exsits
Brief change log
Modify MysqlUpgradeDao and PostgresqlUpgradeDao .
Although PostgresqlUpgradeDao has not  this bug, i specify catalog too.
Verify this pull request
Pass local test.

Codecov Report

Merging #6646 (26e9fc2) into dev (06e8e24) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #6646      +/-   ##
============================================
+ Coverage     38.50%   38.54%   +0.03%
- Complexity     3221     3223       +2
============================================
  Files           646      646
  Lines         25844    25844
  Branches       2799     2799
============================================
+ Hits           9952     9961       +9
+ Misses        14978    14968      -10
- Partials        914      915       +1

Impacted Files
Coverage Δ

.../dolphinscheduler/dao/upgrade/MysqlUpgradeDao.java
0.00% <0.00%> (ø)

...hinscheduler/dao/upgrade/PostgresqlUpgradeDao.java
34.28% <0.00%> (ø)

...dolphinscheduler/remote/future/ResponseFuture.java
83.05% <0.00%> (+1.69%)
:arrow_up:

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
44.68% <0.00%> (+5.67%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e8e24...26e9fc2. Read the comment docs.


add --max-task-threads to digdag run

This PR adds digdag run --max-task-threads N as the same feature in ~/.config/digdag/config's agent.max-task-threads=N, which allows setting max-task-threads per execution.
Can you review it please?
(related to #567, not the best solution though)

(edit)
I found -X agent.max-task-threads=N has the same effect as this PR, so this PR is redundant. However, it is somewhat useful because digdag server and digdag scheduler have --max-task-threads.

This is nice.

Added a document at 274369dc3cea97eaafe928c58cd756aa95db219c.
Thank you

Thank you ;)


Improve the documentation about environment variables

We configure the simulator through environment variables.
But, we don't have any documentation for that.
/kind documentation

@sanposhiho I can work on creating the document as I'm currently revealing multifolds while working on e2e cases :)

@pravarag
Thanks.
I think it would be a good idea to create a document in new file under /docs and add a link to it in the README.

Hi @pravarag
Could you add a description of ALPHA_TABLE_VIEWS environment variable?
It is implemented in #119.
If the ALPHA_TABLE_VIEWS be set to 1, the DataTable view (web UI) will be enabled (This is an alpha feature. )

/assign

/remove-lifecycle rotten

/area simulator

/priority next-release


WIP: Rename API group "networking" to "controlplane"

Closes #1122

/test-all

Should this close #1122? The issue was about revisiting all API groups, not just networking?

So far we just concluded on this change only. But if you like to keep the issue open, I am fine too.

Do you know if this affects upgrade? IIRC, renaming the API group used in an APIService may create issues, if we stop serving the original API in the Antrea Controller apiserver. As much as possible we should try to concentrate API changes that may affect upgrade within the same release.

There can be period that controller and agent are not at the same version, and then agent cannot watch the computed networkpolicy objects from controller (so networkpolicy changes will not take effect). I feel this is acceptable, but like to hear your thoughts and suggestions.
@tnqn : any thoughts?

@jianjuns that's true, but I consider this acceptable given that we haven't released Antrea v1.0 yet. In this case I was more referring to an issue like this one: https://github.com/vmware-tanzu/antrea/issues/494

Yes I forgot this one! Does it require API group versions not changed too? If not we can keep an empty networking group. But I guess version must be the same too.

The problem is applying the new yaml won't delete the stale "v1beta1.networking.antrea.tanzu.vmware.com" APIService, but antrea-controller is no longer serving it so we would meet the same issue as #494 as the upgrade test failure shows:
##[error]    upgrade_test.go:96: Deleting namespace 'test-namespace-cyw88041'
##[error]    upgrade_test.go:98: Namespace deletion failed: timed out waiting for the condition
##[error]    basic_test.go:83: The Antrea Pod for Node 'kind-control-plane' is 'antrea-agent-z9rx7'

@antoninbas and I discussed how to deal with it before, we got two options:

Grant antrea-controller serviceaccount the permission of deleting specific APIServices and do it in antrea-controller.
Ask users to use kubectl apply --prune --prune-whitelist=apiregistration.k8s.io/v1/APIService when applying new yaml.

Along with the evolution of APIs, like v1alpha1 -> v1beta1 -> v1, we may need to handle this case anyway.

Grant antrea-controller serviceaccount the permission of deleting specific APIServices and do it in antrea-controller.
I guess let us go this approach. What you think a separate initContainer which can be activated when we need to handle API service in upgrade, and can be removed when not needed? For example, we execute an antctl command or run controller in special mode to do the cleanup.

I like the idea of doing it in the Antrea Controller even if it does require additional permissions.
I see that the Controller already has the following permissions:
- apiGroups:
  - apiregistration.k8s.io
  resourceNames:
  - v1beta1.system.antrea.tanzu.vmware.com
  - v1beta1.networking.antrea.tanzu.vmware.com
  resources:
  - apiservices
  verbs:
  - get
  - update

It seems that wildcards are not supported in resourceNames, so we would need to either give the Controller "delete" access to all APIServices, or make sure that we always include all deprecated APIs in resourceNames.

I like the idea of doing it in the Antrea Controller even if it does require additional permissions.
I see that the Controller already has the following permissions:
- apiGroups:
  - apiregistration.k8s.io
  resourceNames:
  - v1beta1.system.antrea.tanzu.vmware.com
  - v1beta1.networking.antrea.tanzu.vmware.com
  resources:
  - apiservices
  verbs:
  - get
  - update

It seems that wildcards are not supported in resourceNames, so we would need to either give the Controller "delete" access to all APIServices, or make sure that we always include all deprecated APIs in resourceNames.

+1 seems okay to grant this to Antrea controller with specific resource names

Thanks @abhiraut for the review. Let me do a thorough check of all changes.
For APIService cleanup, I am still thinking about an initContainer. Will do some tests first.

After looking at the code, I also agree let controller delete the APIService is much simpler, as controller now already updates APIServices. Made the change. Please check. @antoninbas @abhiraut @tnqn

/test-all

/test-all

@abhiraut I think we should keep including all deprecated APIServices until we make a v1.0 release

@abhiraut I think we should keep including all deprecated APIServices until we make a v1.0 release

thanks for the answer!

Codecov Report

Merging #1147 into master will decrease coverage by 3.94%.
The diff coverage is 90.24%.

@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
- Coverage   43.79%   39.84%   -3.95%
==========================================
  Files         140       75      -65
  Lines       15146    10919    -4227
==========================================
- Hits         6633     4351    -2282
+ Misses       7928     6212    -1716
+ Partials      585      356     -229

Flag
Coverage Δ

#integration-tests
?

#unit-tests
39.84% <90.24%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/cniserver/server.go
51.69% <ø> (ø)

pkg/agent/controller/networkpolicy/cache.go
79.57% <ø> (ø)

pkg/agent/controller/networkpolicy/reconciler.go
67.92% <ø> (ø)

pkg/agent/openflow/network_policy.go
63.55% <ø> (-10.91%)
:arrow_down:

pkg/antctl/antctl.go
100.00% <ø> (ø)

pkg/antctl/command_definition.go
45.43% <ø> (ø)

pkg/apis/controlplane/register.go
0.00% <ø> (ø)

pkg/apis/controlplane/sets.go
0.00% <ø> (ø)

pkg/apis/controlplane/zz_generated.deepcopy.go
0.00% <ø> (ø)

pkg/apiserver/certificate/cacert_controller.go
17.58% <ø> (ø)

... and 84 more

/test-all


Another achievement diary typo

Morytania elite...
client says 61 slayer required to kill abyssal demons but they require 85 slayer

This is already fixed in #4523 and will be updated with this week's release.


Preferred quote character for autocomplete/quick fixes

You guys are doing so great!
Can there please be a setting for the preferred quote character to use in autocomplete scenarios?  To be used for auto-import statements, or auto-quoting of completed member names with spaces (the new feature that uses string indexing to access members that are not valid javascript identifiers).
Right now it's always using double-quote character whereas I happen to prefer a single-quote character for js/ts as a habit (perhaps to reduce the need for escape characters for UI literal double-quotes and quoted html attributes?) - this would be nice for consistency.

Thanks! Opened https://github.com/Microsoft/vscode/issues/43225 to track this upstream


Add more specific check for constructors than simply checking if it's a function when registering components in the registry

This PR adds an isConstructor function to the utils, which takes an object, and an optional class and checks if the passed object is an constructor, and if the optional class is provided, if it's a constructor for that particular class (or subclass).
I then use this new function in registry to make the registerCommands, registerGroups and registerTypes works correctly, since it now discards functions that are not constructors for the relevant class as invalid if ignoreInvalid is set.
It also gives us the ability to provide more contextual error messages if desired. I did not redo any error messages being thrown in this PR as I am unsure if that's desired. Feel free to request that as well and I'll add it to the PR.
I'm breaking one eslint rule (Using new for side-effects), but that's required to check if a function is actually a constructor. I'm never calling the constructor though, as I'm using a proxy to capture the construction before it gets executed.

it is bug, if u export class in esm mudules show some message error, @Gawdl3y

@Gawdl3y @BlackMix is correct, please merge this.

Decided to resolve merge conflicts since this PR got new comments. Been a while, don't remember my initial purpose of this, I think I just ported over something I used for my plugin library as a "take it if you want it" thing back in the days.

Sidenote, my code is untested after any changes. I simply used the github merge resolution interface to sort things out since I'm about to head to bed and don't have the time/energy to deep dive into this project again right now.


Move import of resilience4j-bom up to spring-cloud-dependencies

Currently spring-cloud-circuitbreaker-dependencies imports resilience4j-bom and manages its version. However, Resilience4J provides support for more than just circuit breakers and people might also want to be able to add a module like resilience4j-bulkhead or resilience4j-ratelimiter as managed in resilience4j-bom, but without using Spring Cloud Circuit Breaker. Wouldn't it therefor make sense to move the resilience4j-bom import and management of its version up to spring-cloud-dependencies?

If you are not using Spring Cloud Circuitbreaker, then why not just manage the dependency yourself?

Because it's one less version number to keep up to date, and managed dependencies are a big part of the benefits of the Spring Boot ecosystem. And since Spring Cloud Circuit Breaker is already managing this, why not provide it to non-circuit breaker users as well?

It is not something Spring Cloud normally does.  I will discuss it with the team.

Maybe Spring Cloud Circuit Breaker should be expanded and rebranded to Spring Cloud Resilience and add support for more of the resilience patterns that Resilience4J supports, as suggested in https://github.com/spring-cloud/spring-cloud-circuitbreaker/issues/59.

so I just did a quick experiment. The spring-cloud-dependencies bom imports the circuitbreaker dependencies bom https://github.com/spring-cloud/spring-cloud-release/blob/master/spring-cloud-dependencies/pom.xml#L72
I created a simple project that imported spring-cloud-dependencies
<dependencyManagement>
	<dependencies>
		<dependency>
			<groupId>org.springframework.cloud</groupId>
			<artifactId>spring-cloud-dependencies</artifactId>
			<version>${spring-cloud.version}</version>
			<type>pom</type>
			<scope>import</scope>
		</dependency>
	</dependencies>
</dependencyManagement>

and was able to add
<dependency>
	<groupId>io.github.resilience4j</groupId>
	<artifactId>resilience4j-bulkhead</artifactId>
</dependency>

without a version and without error and use SemaphoreBulkhead in a project.
SemaphoreBulkhead semaphoreBulkhead = new SemaphoreBulkhead("mybulkhead");

So I think it already works

Thanks @spencergibb!  I will close this or now since it seems doable.

Ah great, I missed that, thanks!


More flexible file system API

Hi there, first of all thanks for a great job so far!
The library works fine with a one directory that have only one directory with joi schemas
But it is not really comfortable otherwise, especially if you have dozen of joi schemas and complex structure  in your project
What about breaking major changes in API? why not to use glob in search joi schema files?
const defaultOutputFile = (srcPath: string, fileName: string) =>  path.join(
     srcPath,
    `${path.basename(fileName, '.ts')}.type.ts`
)

export function convertFromDirectory({
    schemaFile,
    outputFile = defaultOutputFile,
    // ...
}{
    schemaFile: string | string[];
    outputFile?: (scrPath: string, fileName: string) => string
    // ...
}) {
    // ... implementation
}

Benefits
The usage is more flexible and fits more use cases.
Below old options can be dropped from API because it could be done by this new realisation

schemaFileSuffix

 convertFromDirectory({
    schemaFile: './src/**/*.schema.ts',
    outputFile: (srcPath: string, fileName: string) => path.join(srcPath, fileName.replace('.schema', '')),
}})

flattenTree

convertFromDirectory({
    schemaFile: './src/**/*.schema.ts',
    outputFile: (srcPath: string, fileName: string) => path.join('./src/types', fileName),
}})

rootDirectoryOnly

convertFromDirectory({
    schemaFile: './src/*.schema.ts',
}})

ignoreFiles can be be done by glob in a variety of ways out of box

Caveats
I am not sure about  indexAllToRoot — it could be hard to implement
What do you think? Will you accept such PR?

Searching a project to find schemas would be great.
I actually use a crude implementation of what you propose to search for Schema folders instead of a file suffix, using glob is also probably faster than using fs.

I'm not sure how many people use indexAllToRoot. It might not be a popular opinion

Hey @mo4islona I'm curious if you had a chance to look at your suggestion?

Sure.
Dont had much time for work but  enough to implement  basic features
https://github.com/mo4islona/joi-to-typescript/pull/1
the progress of tests

none ✅
primitives types ✅
multiple file - I ve stacked here 😩

I have a problem if schemas names will have a collisions (that i have in my own project) of external schemas names and physical file paths
To resolve it we must known from what source file path is schema imported (which seems to be a very complicated)
Looking for a solution.

Thankyou I'll see if i can help

Stale


Code refactor for CRS check in onboarding process

This PR contains the refactored code for CRS check in onboarding process to extract the authority and code.

Build finished.

Build finished.

Build finished.

Build finished.


Hot res failure

I got an unable to equip outfit error because there wasn't a metal meteoroid drop to create a meteorite guard.

Resolved!


Use the new Domain.join() constructor of SymPDE

See SymPDE PR #130

Looks good!
I have just a couple of comments. One of them is repeated many times: I would like to rename the domains list as patches, which is much clearer for the reader.

It's fixed in d66a68e


Reduce CUDA kernel launch in BN (updated)

This PR is based on #276 by @okuta .
Since the PR failed in Travis CI test due to a problem in .travis.yml code, I created an updated PR based on #276.

Thanks!

CI passed on our in-house servers. LGTM


[SPARK-23644][CORE][UI][BACKPORT-2.3] Use absolute path for REST call in SHS

What changes were proposed in this pull request?
SHS is using a relative path for the REST API call to get the list of the application is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue if the path doesn't end with a "/".
Therefore, we should use an absolute path for the REST call as it is done for all the other resources.
How was this patch tested?
manual tests
Before the change:

After the change:

cc @jerryshao

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1563/
Test PASSed.

Test build #88308 has started for PR 20847 at commit f130a36.

Test build #88308 has finished for PR 20847 at commit f130a36.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88308/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test build #88315 has started for PR 20847 at commit f130a36.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1568/
Test PASSed.

Test build #88315 has finished for PR 20847 at commit f130a36.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88315/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1570/
Test PASSed.

Test build #88322 has started for PR 20847 at commit f130a36.

Test build #88322 has finished for PR 20847 at commit f130a36.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88322/
Test FAILed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1577/
Test PASSed.

Test build #88335 has started for PR 20847 at commit f130a36.

Test build #88335 has finished for PR 20847 at commit f130a36.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88335/
Test FAILed.

most of the UTs are failing consistently and of course UTs failures are unrelated. Since this is on branch 2.3, shall we open a JIRA for tracking this?

Jenkins, retest this please.

@mgaido91 would you please create a JIRA to track all the UT failures. Hopes someone familiar with that part could fix them.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1599/
Test PASSed.

Test build #88364 has started for PR 20847 at commit f130a36.

Test build #88364 has finished for PR 20847 at commit f130a36.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88364/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Test build #88371 has started for PR 20847 at commit f130a36.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1606/
Test PASSed.

Merged build finished. Test PASSed.

Test build #88371 has finished for PR 20847 at commit f130a36.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88371/
Test FAILed.

The ML bug is fixed. I'll retrigger this.

Retest this please.

Test build #88382 has started for PR 20847 at commit f130a36.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1616/
Test PASSed.

Test build #88382 has finished for PR 20847 at commit f130a36.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88382/
Test FAILed.

Merged build finished. Test FAILed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1617/
Test PASSed.

Test build #88387 has started for PR 20847 at commit f130a36.

Test build #88387 has finished for PR 20847 at commit f130a36.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88387/
Test PASSed.

Thanks, merging to branch 2.3.

@mgaido91 this is already merged to branch 2.3. Please close this PR if it is not closed automatically.


Mesh builder

Closes #77

Work done

[x] complete rework of mesh procedural generation
[x] MeshInfo struct can be merged with other meshes (@alice-i-cecile )
[x] Added a ColumnMeshBuilder for column meshes
[x]  Added a PlaneMeshBuilder for plane meshes
[x] Add a mesh_builder example showcasing builder options

Builder API is nice, although I'd probably make the fields pub. I'd actually keep the cheap hex mesh around: it's useful for creating bounding columns for picking.

@alice-i-cecile all done, could you check that this PR doesn't break anything in emergence ? Also you might be able to remove the bottom face now and save a few triangles

Yeah, lemme try out a migration :)

Experiments:

[x] using deprecated methods still works
[x] using new mesh builder works
[ ] using mesh merging works

Mesh merging with its current API is not very useful at all:

it's very easy to hit the u16::MAX limit
there's no way to specify the translation offsets of the meshes in advance, so they end up collapsed into am overlapping pile
I really want to be able to call .reduce with merge_mesh but the type signature is wrong

IMO cut mesh merging from this PR and release.

The mesh merging method was mostly created for inner usage, it is used by the build method of the new builders and allow to compute different parts of meshes separately.
For your use case, merging all your map together would indeed require a lot of offsets.
I'll investigate looking at the emergence MR to see if I can bring a quick win but otherwise I'll make that method private for now until I start working on chunking

I added comments to your test attempt, I think you are missing a single param for merging to work as expected.
About the u16 limit, I could consider indices to be u32 but I don't think merging such large meshes make sense, as they should be merged as chunks anyway, otherwise the AABB optimizations in rendering wouldn't apply

Agreed on the chunking point: I wanted to test it out quick and see how it works :)


Comment and docstrings

Please add comments and docstrings to your code.

Done but waiting for the maintainer to accept the merge request


Read unspecified develop versions like 0.9.0.dev

For executables that one maintains, one might execute simulations
of a not released development version like 0.9.0.dev.
While probably one should not do this, sumatra should infer the
version number properly in any case. So far it read 0.9.0.. With
this change it reads the whole version string.

Coverage decreased (-0.02%) to 73.2% when pulling f85600882b1df6aa244f811b806042fb47e3a073 on timtroendle:feature/read-unspecified-develop-versions into 75aeac0b2a4eed702b5f53a93f6d4877bac1b397 on open-research:master.

LGTM