"gatsby-source-craft" threw an error while running the sourceNodes lifecycle

Description
I'm frequently encountering the following error on Gatsby Cloud when making changes in CraftCMS:
"gatsby-source-craft" threw an error while running the sourceNodes lifecycle:

Cannot read property 'map' of null

488 |         // Create the sourcing node events
  489 |         const nodeEvents = [
> 490 |             ...updatedNodes.map(entry => {
      |                             ^
  491 |                 return {
  492 |                     eventName: 'UPDATE',
  493 |                     remoteTypeName: entry.nodeType,

The only difference from a normal setup is that I have registered a custom source node type to support Craft Commerce Products by doing the following:
Event::on(
    SourceNodes::class,
    SourceNodes::EVENT_REGISTER_SOURCE_NODE_TYPES,
    function (RegisterSourceNodeTypesEvent $event) {
        $event->types[] = [
            'node' => 'product',
            'list' => 'products',
            'filterArgument' => 'type',
            'filterTypeExpression' => '(.+)_Product',
            'targetInterface' => ProductInterface::getName(),
        ];
    }
);

The build succeeds if I clear the cache and perform a fresh build from Gatsby Cloud (which is not an ideal solution for my client!).
I'll have a good dig through over the weekend and see if I can nail down what's actually causing this error.
Steps to reproduce
Not sure at the moment, it seems to happen after making a few changes to entries after a fresh build.
Additional info

Craft version: 3.6.15
PHP version: 7.4.10
Database driver & version: MySQL 8.0.21
Plugins & versions:

Amazon SES - 1.3.3
Craft Commerce - 3.3.2
Gatsby Helper - 1.0.3
Mailchimp Subscribe - 3.0.3
MatrixMate 1.2.7
Redactor - 2.8.7
SEOmatic - 3.3.42
Stripe for Craft Commerce - <IP_ADDRESS>
Super Table - 2.6.8

Gatsby Helper always returns an array there (https://github.com/craftcms/gatsby-helper/blob/main/src/gql/resolvers/UpdatedNode.php#L29).
When you next hit this issue, can you check the Craft logs for anything suspicious? Maybe there's a Craft error that causes it to bail out without a proper response.

Thanks @andris-sevcenko, I'll check it out and post my findings here.

Update—Found these errors repeated quite a bit in my log file:
2021-07-05 02:35:42 [-][-][-][error][yii\base\UnknownPropertyException] yii\base\UnknownPropertyException: Getting unknown property: craft\commerce\elements\Product::productTypeId in /vendor/yiisoft/yii2/base/Component.php:155
2021-07-05 02:35:42 [-][-][-][error][GraphQL\Error\Error] String cannot represent value: instance of nystudio107\seomatic\models\MetaBundle

Is there a stack trace for either of those errors? If not, can you enable devMode and re-create those errors to get a stack trace?

Stack trace for the first error is:
Stack trace:
#0 /opt/bitnami/apache/htdocs/vendor/craftcms/cms/src/base/Element.php(1533): yii\base\Component->__get()
#1 /opt/bitnami/apache/htdocs/vendor/craftcms/cms/src/gql/base/ObjectType.php(73): craft\base\Element->__get()
#2 /opt/bitnami/apache/htdocs/vendor/craftcms/cms/src/gql/types/elements/Element.php(54): craft\gql\base\ObjectType->resolve()
#3 /opt/bitnami/apache/htdocs/vendor/craftcms/commerce/src/gql/types/elements/Product.php(48): craft\gql\types\elements\Element->resolve()
#4 /opt/bitnami/apache/htdocs/vendor/craftcms/cms/src/gql/base/ObjectType.php(47): craft\commerce\gql\types\elements\Product->resolve()
#5 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(624): craft\gql\base\ObjectType->resolveWithDirectives()
#6 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(550): GraphQL\Executor\ReferenceExecutor->resolveFieldValueOrError()
#7 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(1196): GraphQL\Executor\ReferenceExecutor->resolveField()
#8 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(1146): GraphQL\Executor\ReferenceExecutor->executeFields()
#9 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(1107): GraphQL\Executor\ReferenceExecutor->collectAndExecuteSubfields()
#10 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(975): GraphQL\Executor\ReferenceExecutor->completeObjectValue()
#11 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(790): GraphQL\Executor\ReferenceExecutor->completeAbstractValue()
#12 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(655): GraphQL\Executor\ReferenceExecutor->completeValue()
#13 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(888): GraphQL\Executor\ReferenceExecutor->completeValueCatchingError()
#14 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(762): GraphQL\Executor\ReferenceExecutor->completeListValue()
#15 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(655): GraphQL\Executor\ReferenceExecutor->completeValue()
#16 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(557): GraphQL\Executor\ReferenceExecutor->completeValueCatchingError()
#17 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(1196): GraphQL\Executor\ReferenceExecutor->resolveField()
#18 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(264): GraphQL\Executor\ReferenceExecutor->executeFields()
#19 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php(215): GraphQL\Executor\ReferenceExecutor->executeOperation()
#20 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/Executor/Executor.php(156): GraphQL\Executor\ReferenceExecutor->doExecute()
#21 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/GraphQL.php(162): GraphQL\Executor\Executor::promiseToExecute()
#22 /opt/bitnami/apache/htdocs/vendor/webonyx/graphql-php/src/GraphQL.php(94): GraphQL\GraphQL::promiseToExecute()
#23 /opt/bitnami/apache/htdocs/vendor/craftcms/cms/src/services/Gql.php(545): GraphQL\GraphQL::executeQuery()
#24 /opt/bitnami/apache/htdocs/vendor/craftcms/cms/src/controllers/GraphqlController.php(172): craft\services\Gql->executeQuery()
#25 [internal function]: craft\controllers\GraphqlController->actionApi()
#26 /opt/bitnami/apache/htdocs/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array()
#27 /opt/bitnami/apache/htdocs/vendor/yiisoft/yii2/base/Controller.php(181): yii\base\InlineAction->runWithParams()
#28 /opt/bitnami/apache/htdocs/vendor/craftcms/cms/src/web/Controller.php(190): yii\base\Controller->runAction()
#29 /opt/bitnami/apache/htdocs/vendor/yiisoft/yii2/base/Module.php(534): craft\web\Controller->runAction()
#30 /opt/bitnami/apache/htdocs/vendor/craftcms/cms/src/web/Application.php(278): yii\base\Module->runAction()
#31 /opt/bitnami/apache/htdocs/vendor/yiisoft/yii2/web/Application.php(104): craft\web\Application->runAction()
#32 /opt/bitnami/apache/htdocs/vendor/craftcms/cms/src/web/Application.php(263): yii\web\Application->handleRequest()
#33 /opt/bitnami/apache/htdocs/vendor/yiisoft/yii2/base/Application.php(392): craft\web\Application->handleRequest()
#34 /opt/bitnami/apache/htdocs/web/index.php(22): yii\base\Application->run()
#35 {main}

PR here: https://github.com/craftcms/commerce/pull/2248

No stack trace for the second error. Have now enabled devMode so will see what comes through.

If you add the changes to the Product, does that resolve the issue?
If you're still hitting the SEOMatic issue, you might need to use custom fragments to resolve that. We're working on a more prominent guide of when and why to use custom fragments guide.

Hey @andris-sevcenko, just an update on this. I did a lot of digging on my local setup and I think I've found the cause of this issue!
Basically, whenever an order is created or updated, the following error will occur when the site next tries to build:
"gatsby-source-craft" threw an error while running the sourceNodes lifecycle:

Missing Gatsby node definition for remote type Element

  510 |         }
  511 |         // And source, if needed
> 512 |         await sourceNodeChanges(config, { nodeEvents });
      |         ^
  513 |     }
  514 |     await cache.set(`CRAFT_CONFIG_VERSION`, remoteConfigVersion);
  515 |     await cache.set(`CRAFT_LAST_CONTENT_UPDATE`, remoteContentUpdateTime);

File: node_modules/gatsby-source-craft/gatsby-node.js:512:9

  Error: Missing Gatsby node definition for remote type Element

  - node-definition-helpers.ts:46 Object.getGatsbyNodeDefinition
    [website]/[gatsby-graphql-source-toolkit]/src/source-nodes/utils/node-definition-helpers.ts:46:11

  - fetch-nodes.ts:37 fetchNodesById
    [website]/[gatsby-graphql-source-toolkit]/src/source-nodes/fetch-nodes/fetch-nodes.ts:37:26

  - fetchNodesById.next

  - fetch-nodes.ts:19 Object.fetchNonNullishNodesById
    [website]/[gatsby-graphql-source-toolkit]/src/source-nodes/fetch-nodes/fetch-nodes.ts:19:20

  - fetchNonNullishNodesById.next

  - create-nodes.ts:13 Object.createNodes
    [website]/[gatsby-graphql-source-toolkit]/src/source-nodes/node-actions/create-nodes.ts:13:20

  - source-node-changes.ts:31 sourceNodeChanges
    [website]/[gatsby-graphql-source-toolkit]/src/source-nodes/source-node-changes.ts:31:21

  - task_queues.js:93 processTicksAndRejections
    internal/process/task_queues.js:93:5

  - gatsby-node.js:512 Object.exports.sourceNodes
    [website]/[gatsby-source-craft]/gatsby-node.js:512:9

  - api-runner-node.js:429 runAPI
    [website]/[gatsby]/src/utils/api-runner-node.js:429:16

not finished source and transform nodes - 2.492s

If I clear the Gatsby cache and rebuild then it's fine.
I've uploaded a copy of the web.log file that was generated during the build. There's a few order queries at the end (presumably just before the build fails).
web.log.zip
Any pointers on how to resolve this would be great. If you need any more info from me just let me know 😄

Ah, so the orders are the culprit.
I'm guessing you don't want to expose Order information for the Gatsby sites, so you should add them to the ignored types: https://github.com/craftcms/gatsby-helper/blob/main/src/services/Deltas.php#L49
In essence, if you have a custom element type (or, rather, one that is not covered by the helper plugin by default), you should either register the custom source node type for it or tell the helper plugin to stop triggering updates on that type of element save.
I think that should cover it. Can you, please, try this out and let me know how it goes?

Yep, that's done the trick. Fantastic, thanks so much for your assistance @andris-sevcenko 🎉

I'm guessing you don't want to expose Order information for the Gatsby sites, so you should add them to the ignored types: https://github.com/craftcms/gatsby-helper/blob/main/src/services/Deltas.php#L49

Yeah that's right, no order information (at this stage anyway). I don't think Commerce exposes Orders via GraphQL at the moment so it may have to be through a custom API/ element API.
Closing now 😄


Overload conflicts make implementation impossible

I created type definitions for Aurelia Event Aggregator as below. It compiles fine.
interface Constructor<T> {
    new (...args: any[]): T;
}

declare class EventAggregator
{
    subscribe(event: string, callback: (message: any) => void): void;
    subscribe<T>(event: Constructor<T>, callback: (message: T) => void): void;

	publish(event: string, data?: any): void;
	publish<T>(event: T): void;
}

class SomeMessage {
    constructor(public data: string) {}
}

var ea = new EventAggregator();

// event is string, message is any
ea.subscribe("myEvent", message => {
    console.log(message.anything);
});

// event is class constructor, message is instance of class
ea.subscribe(SomeMessage, message => {
    console.log(message.data);
});

// event is string, message is any
ea.publish("myEvent", { anything: 1 });

// event is class instance
ea.publish(new SomeMessage(""));

Even though it is possible to define declarations for this class, it is impossible to implement it in TypeScript. The following produces errors, and I can't figure how to fix it.
interface Constructor<T> {
    new (...args: any[]): T;
}

class EventAggregator
{
    subscribe(event: string, callback: (message: any) => void): void;
    subscribe<T>(event: Constructor<T>, callback: (message: T) => void): void {
	}

	publish(event: string, data?: any): void;
	publish<T>(event: T): void {
	}
}

class SomeMessage {
    constructor(public data: string) {}
}

var ea = new EventAggregator();

// event is string, message is any
ea.subscribe("myEvent", message => {
    console.log(message.anything);
});

// event is class constructor, message is instance of class
ea.subscribe(SomeMessage, message => {
    console.log(message.data);
});

// event is string, message is any
ea.publish("myEvent", { anything: 1 });

// event is class instance
ea.publish(new SomeMessage(""));

Is this a bug?
Here's the original JS source (ES6) for reference: aurelia/event-aggregator

method definition is not counted as part of the overload set. you need to 1. define an overload signature of each overload, and 2. have an implementation signature that is compatible with all the overloads.
class EventAggregator {
    subscribe(event: string, callback: (message: any) => void): void;
    subscribe<T>(event: Constructor<T>, callback: (message: T) => void): void;
    subscribe(event: string|Constructor<any>, callback: (message: any) => void): void {

    }

    publish(event: string, data?: any): void;
    publish<T>(event: T): void;
    publish(event:any): void {
    }
}

This is a common source of confusion. Can we improve the error here? If the assignability check fails could we then check assignability against the implementation signature to include more helpful error text (or have we already thrown away that context by then)? That might help people solve the issue without having to go from the IDE to StackOverflow/GitHub/etc.

@mhegazy that worked. Thanks.
Is there any way to say that a parameter can take only object instances and not class constructors, so that for example ea.publish(SomeMessage) is not allowed?

A hacky option:
interface NotFunction {
	length?: void;
}

class EventAggregator {
    publish(event: string, data?: any): void;
    publish<T extends NotFunction>(event: T): void;
    publish(event:any): void { }
}

var e: EventAggregator;
e.publish(EventAggregator); // error
e.publish(1); // ok
e.publish(''); // ok
e.publish(new EventAggregator()); // ok

Thank you very much. I'm closing this question. You may want to open a separate issue for improving the error message for this case.


Incorrect border color on drag-n-drop of Secondary Side Bar tabs

https://github.com/BeardedBear/bearded-theme/assets/21295738/d8f6b445-18f7-4a91-a025-4f447b9f85df
In light themes, a light gray color is used, which is generally legible although lighter than in other light themes.
Dark themes use black which is almost completely invisible.

Thanks ! Fixed in v8.3.1 !


Searchbar on_change and on_submit event don't trigger

Description

Code example to reproduce the issue:
Taken directly from the docs: https://flet.dev/docs/controls/searchbar/#on_change
import flet as ft

def main(page):

    def close_anchor(e):
        text = f"Color {e.control.data}"
        print(f"closing view from {text}")
        anchor.close_view(text)

    def handle_change(e):
        print(f"handle_change e.data: {e.data}")

    def handle_submit(e):
        print(f"handle_submit e.data: {e.data}")

    def handle_tap(e):
        print(f"handle_tap")

    anchor = ft.SearchBar(
        view_elevation=4,
        divider_color=ft.colors.AMBER,
        bar_hint_text="Search colors...",
        view_hint_text="Choose a color from the suggestions...",
        on_change=handle_change,
        on_submit=handle_submit,
        on_tap=handle_tap,
        controls=[
            ft.ListTile(title=ft.Text(f"Color {i}"), on_click=close_anchor, data=i)
            for i in range(10)
        ],
    )

    page.add(
        ft.Row(
            alignment=ft.MainAxisAlignment.CENTER,
            controls=[
                ft.OutlinedButton(
                    "Open Search View",
                    on_click=lambda _: anchor.open_view(),
                ),
            ],
        ),
        anchor,
    )

ft.app(target=main)

Describe the results you received:
Program never prints handle_change or handle_submit
Describe the results you expected:
...
Additional information you deem important (e.g. issue happens only occasionally):
Flet version (pip show flet):
 name         : flet
 version      : 0.17.0
 description  : Flet for Python - easily build interactive multi-platform apps in Python

dependencies
 - cookiecutter >=2.4.0,<3.0.0
 - flet-runtime 0.17.0
 - packaging >=23.1,<24.0
 - qrcode >=7.4.2,<8.0.0
 - watchdog >=3.0.0,<4.0.0
 - websocket-client >=1.5.2,<2.0.0
 - websockets >=11.0.3,<12.0.0

Operating system:
linux
Additional environment details:
Run using python-poetry, wayland, kde.

Using the examples in the docs the on_change and on_submit also do not run on windows.
flet version 0.17 & flet version 0.18.0.dev2028


Added profile context

Added profile context and profile creation when registering.

Just a couple of minor changes requested

These are done. Thank you.


Enable pre-commit.ci for style checking

This PR removes the current style checking from GitHub Actions and moves it to pre-commit.ci, this will allow for additional checking.
Closes #195

📚 Documentation preview 📚: https://jaxsim--197.org.readthedocs.build//197/

Before reviewing this PR, a curiosity. Is there any way to perform this check without relying on external services? And I mean, can we do it using a regular GitHub workflow?

Before reviewing this PR, a curiosity. Is there any way to perform this check without relying on external services? And I mean, can we do it using a regular GitHub workflow?

Yes, there is the lite version of the CI, you can find more details at https://pre-commit.ci/lite.html

Btw I temporarily disabled the pre-commit.ci integration from the repo as it got super annoying with the automatic commit fixes

If there is an option providing all the features we need that doesn't use any external service, I'd rather go towards that way. Many years ago, we were interfacing with similar external services (like CirleCI, TravisCI, etc), and they are definitely more prone to get broken, be down, or have some sort of problems.
Would it require a big effort enabling the lite version as GitHub Workflow?

Would it require a big effort enabling the lite version as GitHub Workflow?

Totally not, I'll add that

After discussing with @diegoferigo, we decided to use the pre-commit.ci instead of the GitHub Actions integration as it is faster and it is actively maintained.
I pushed a dummy commit to verify that the CI actually fails when the formatting is wrong. This can be fixed in three ways:

use pre-commit hook (suggested)
trigger the bot commenting with pre-commit.ci autofix
adding a pre-commit.ci autofix label (to avoid)

pre-commit.ci autofix

pre-commit.ci autofix

I dropped the last commit, for some reason the bot doesn't work. It may be due to some issue upstream, but I'll verify that. Ready for review @diegoferigo, thanks a lot!

Can you please also cherry pick the updates of #200 here?

Can you please also cherry pick the updates of #200 here?

Done in https://github.com/ami-iit/jaxsim/pull/197/commits/b79406c2f8805a8585039387d07e754e1333bafa.
Would you like to add anything? Otherwise I'll merge this

FYI @Giulero


fix Endpoint ID 'service-registry' contains invalid characters, please migrate to a valid format

fix https://github.com/spring-cloud/spring-cloud-commons/issues/458

@spencergibb done


Add Hoover Tumble Dryer - HLE C10DCE-80

Hi, please can we look to get this model added to the integration. I installed it, rebooted etc and see a bunch of sensors but very few show any updates, More than happy to provide whatever details are needed. Here's what I see when I look at the hOn integration.

Is there any error in the logs ?
Can you update first (just did a fix)

Should work now. Please reopen another issue if there are still an error


Refactor flood prevention

Dropping arbitrary average frame size in favor of nginx-inspired flood protection based on the number of payload (header or data) frames received vs. the overall number of bytes received, including frame headers. This protects against both control frame floods and tiny data frame floods.

Rebased on master.


text is too high in lists < PRO > relative-clauses.tex

This is another example. SUBJ < NP > is doen with the langsci-avm.sty package macros and PHON < the bucket > with my own command. "the bucket" is at the line of PHON, while NP is higher than SUBJ. Also my brackets are smaller and there is more space before the closing bracket, which is good because of italics.


Regularly check for missing otherwise messed up content

Given our recent problem with missing content, and also this might help when an upload fails, but have a cron job or something like that that audits the content to check that it is there.
@awead  already wrote a script that does most if not all of this. Also, since it is based on the SHA hash, it would also detect corrupted files?

@olendorf it could, but Fedora already has the capacity to do this. I believe we already run a job to check for corrupted files, but I'll verify that.

@awead  I thought Fedora could too. Part of the question is we are considering the possibility, at some point taking fedora out of the stack. So it might be something useful when that happens too. That being said, its a "discussion" at this point, and don't know if and when it will happen.


Removed update log

That thing doesn't appear to have been updated in a year. Soooo, if you want it gone, this does that.

I think we should get in the habit of updating this and probably pull it into the repo instead of unmanaged on the server.


Future documentation improvments

Adding more documentation to various parts of MC/DC t

[ ] Doc-strings to all internal functions as well as the user API functions
[ ] Chapters on the documentation website that work through each one of the examples
[ ] Theory guide explaining the physics of our methods and algorithms better

This is planned work for the April 2024 hackathon. Future PR's should also include additions to docstrings and documentation when adding functions and features

#174


support for YAML training data: GET /conversations/<conversation_id>/story

The endpoint GET /conversations/<conversation_id>/story should support providing stories in the new YAML format.

Fixed by @tmbo in https://github.com/RasaHQ/rasa/pull/6457


asn1: properly clean up on failed BIO creation

Fixes Coverity 1486070 through 1486077 and 1486079.  These nine defects all related to not checking for a NULL return from BIO_new().

[ ] documentation is added or updated
[ ] tests are added or updated

Merged, thanks.


Add programmatically selected snippet

See this Stack Overflow question for more details.

VSCode Version: 1.15.1
OS Version: Win 10 Pro (64 bit)

I am able to invoke editor.action.insertSnippet programmatically; however, I would like to not require the user to select a snippet. Instead, I want to add a button that will invoke a predefined snippet on behalf of the user. Something along the lines of editor.action.insertSelectedSnippet.

The insertSnippet-command accepts an argument which is either the name of a snippet or a snippet itself. So, either { snippet: "console.log($1)$0"} for an inline snippet or { langId: "csharp", name: "myFavSnippet" } referencing an existing snippet.

This seems to be exactly what I need. Thank you.

@jrieken Having had a few moments to review the docs (insertSnippet, SnippetString and full snippet syntax), I am not seeing this referenced (at least not as clearly as you did in reply). Would it be possible to update the documentation to be more explicit about this?

Yeah, it is well-hidden in the snippets sections: https://code.visualstudio.com/docs/editor/userdefinedsnippets#_assign-keybindings-to-snippets


Network implementation

Exit node:

[x] Define how the node gets its public IP configured
[ ] Define what the exit node container will looks like

Network module:

[x] Logic to apply network resources

FPA (farmer prefix allocator):

[x] Implement prefix allocator
[ ] Define network object of farmer prefix allocator

Most basic functionality have been merged to master.

https://github.com/threefoldtech/zosv2/pull/74
https://github.com/threefoldtech/zosv2/pull/86
https://github.com/threefoldtech/zosv2/pull/96


Remove the second argument to WidgetError.

This makes WidgetError more like RenderingError, which will aid with https://github.com/flutter/flutter/issues/2356.
Fixes https://github.com/flutter/flutter/issues/2443
Also, clean up and clarify several of the places where we use WidgetError.

lgtm


Is there any way to use this library with react native

This library looks great and the zoom is brush functionality which was the feature i wanted. But i wanted it to extend this for react native as well. Please let me know if there is any possible way to do this.

Not currently. Sorry :/

It's a pity.

I wonder if its possible to use this with a webview in react native

Is this still the case? Any hopes of getting it to work on RN in the near future? Thanks!


Actiontest into parent repo

null
Summary
This pull request refactors and improves the PR description generation workflow by updating the GitHub Actions, simplifying the process, and updating the SKonsole tool. It includes changes to the workflow file, switching to different actions for updating PRs, and minor adjustments to the workflow steps.
Changes

Combine branch checkout commands into a single step
Remove unnecessary 'Verify repo' and 'Setup .NET CLI' steps
Fix syntax error in 'Generate PR description' step
Update actions/checkout from v3.5.2 to v4
Add ref to actions/checkout with value: github.event.pull_request.head.sha
Replace echo command with GITHUB_OUTPUT for setting pr_description
Update targetBranch parameter in skonsole pr description command
Replace peter-evans/create-or-update-comment with<EMAIL_ADDRESS>Remove unnecessary newline in the workflow file
Add a new output.txt file to the repository
Update .NET CLI version from 6.0.x to 7.0.x in generate-pr-description.yml
Replace 'Generate PR description' step with 'Update PR Description' step in generate-pr-description.yml
Use peter-evans/create-or-update-comment@v1 action to update PR description
Remove unnecessary environment variables in generate-pr-description.yml
Update .NET CLI version from 8.0.0 to 6.0.x in generate-pr-description.yml
Specify SKonsole version 1.0.1 during installation
Minor changes to README.md, including a TODO for GitHub Action usage
Added a new line mentioning Semantic Kernel in README.md

Powered by Microsoft Semantic Kernel

/generate_pr_description

/generate_pr_description


after changing file upload, old uploads remain in sent request

Originally reported on Google Code with ID 246
What steps will reproduce the problem?
1. make a PUT request that includes a file with name field set to "fileUpload"
2. change the name of the field to "SomethingElse"
3. make a PUT request to the same endpoint

What is the expected output? What do you see instead?

expect request to only include "SomethingElse", However, both "SomethingElse" and "fileUpload"
are sent in the request.

On what operating system, browser and browser version?
MacOS 10.9.2 Chrome Version 33.0.1750.152

Please provide any additional information below.

Reported by<EMAIL_ADDRESS>on 2014-04-07 16:02:59

I can't do the same. Maybe it was fixed in some other issue. However the way how you described to me is working perfectly.


Update for German Localizable.strings

The original German (machine?) translation wasn’t very good and only just intelligible. I tried to enhance it as good as I could in a first attempt. (I am a German native speaker.) I sticked with "Loading" as a) it is well known as a term for the process of downloading data in German and "Laden" does not convey that it is something that is going on right now and b) the "LOADING" string obviously is used as name of the app in the Options > About menu. (The actual fix would be to differentiate here between strings for the process of loading and the name Loading. Once these strings are differentiated, another way to translate "loading" and "loaded" more elegantly might be "Aktiv" and "Zuvor aktiv".) I haven’t checked where "DOWNLOAD" is used, but I guess it is for the download of an update, so "Laden" is okay, I guess, at least in contemporary colloquial German.
(Finally, may I add that the German app description on the app’s homepage is quite horrible as well?)

Hm, I just merged a German translation. And yeah I mostly just used Google Translate while attempting to avoid the obvious pitfalls by choosing unambiguous words. :P

I recommend not using Google Translate for this kind of task. Dedicated translation websites pften have much better results, because the are managed by native speakers knowing the slight differences between the words. For English-German translation, dict.cc ist my favorite tool.


Integration (test_loss_of_liveness_*) breaking

The nightly tests run our integration tests, currently ignored in the main code base:
huitseeker@dapple.localdomain➜~/tmp/narwhal(main)» rg -A5  '#\[ignore\]'                                                                                [21:59:34]
primary/tests/nodes_bootstrapping_tests.rs
47:#[ignore]
48-#[tokio::test]
49-async fn test_node_staggered_starts() {
50-    // Enabled debug tracing so we can easily observe the
51-    // nodes logs.
52-    let _guard = setup_tracing();
--
96:#[ignore]
97-#[tokio::test]
98-async fn test_second_node_restart() {
99-    // Enabled debug tracing so we can easily observe the
100-    // nodes logs.
101-    let _guard = setup_tracing();
--
134:#[ignore]
135-#[tokio::test]
136-/// We are testing the loss of liveness of a healthy cluster. While 3f+1 nodes run
137-/// we are shutting down f+1 nodes. Then we are bringing the f+1 nodes back again
138-/// but we are not expecting now the cluster to be able to make progress. We expect
139-/// the restarted nodes to not be able to make new proposals and effectively make
--
189:#[ignore]
190-#[tokio::test]
191-/// We are testing the loss of liveness of a healthy cluster. While 3f+1 nodes run
192-/// we are shutting down f+1 nodes one by one with some delay between them.
193-/// Then we are bringing the f+1 nodes back again. We expect the cluster to
194-/// recover and effectively make progress.

primary/tests/causal_completion_tests.rs
12:#[ignore]
13-#[tokio::test]
14-async fn test_restore_from_disk() {
15-    // Enabled debug tracing so we can easily observe the
16-    // nodes logs.
17-    let _guard = setup_tracing();
--
100:#[ignore]
101-#[tokio::test]
102-async fn test_read_causal_signed_certificates() {
103-    const CURRENT_ROUND_METRIC: &str = "narwhal_primary_current_round";
104-
105-    // Enabled debug tracing so we can easily observe the

Those tests have been failing on nightly for a while: https://github.com/MystenLabs/narwhal/actions/workflows/nightly.yml
(though some of those failures have been hidden transiently by the failure which https://github.com/MystenLabs/narwhal/pull/812 corrects)
A (long) bisection points to https://github.com/mystenlabs/narwhal/pull/821 as the PR that broke the tests. I've tested this specifically with the following command:
cargo nextest run --run-ignored ignored-only -E 'test(=test_loss_of_liveness_without_recovery)'

(some tests go into a live lock, which makes the bisection hard to perform)
More interestingly, reverting this change does not fix the tests:
https://github.com/MystenLabs/narwhal/compare/main...huitseeker:reversion_821?expand=1
And the log in fastcrypto is really innocuous:
huitseeker@sleipnir➜huitseeker/tmp/fastcrypto(main)» git lg ded6f91c9c19594a3eaeaa9a487d42a39965569e..a9e58305dc463c40b9d357730203406214909f04                                                                        [22:09:11]
*   a9e5830 - Merge pull request #6 from MystenLabs/signature-feature (3 days ago)<Joy Wang>
|\
| * 40f47cb - fix: add rand-preview feature to signature (3 days ago)<Joy Wang>
* | ed48616 - Update CODEOWNERS (3 days ago)<Joy Wang>
|/
* 9ee4494 - Update CODEOWNERS (3 days ago)<Joy Wang>
* 0d0d120 - add more info in cargo.toml and readme (4 days ago)<Joy Wang>
* 9b92653 - Merge pull request #4 from MystenLabs/punwai-patch-1 (4 days ago)<Kostas Chalkias>
* 80779f4 - (origin/punwai-patch-1) Update README.md (5 days ago)<punwai>

=> so this is probably not what's causing the issue.
/cc @joyqvq

none of the changes in fastcrypto and removing ed25519-dalek seems suspicious to me as well
what exactly was the error on the test?

Here is the failure output:
https://gist.github.com/7fb756ae350c7a1edcc0ac33a610efe8

AFAIK the tests are still flaky.


use typescript for main action file; add option to use local filepaths

hi! I'm happy to change anything here
my team had a need to use a predownloaded, local filepath (instead of one that was hosted in the same repo).
while I was at it I changed this to use TypeScript.
I just wanted to offer up this PR as a starting point for conversation; let me know if you're super opposed to this

This is great! Typescript also seems to package the action really well. When you say local filepath, was this present in the same repo that the action's code is in? This will be useful if this repo is forked, a config is added into that fork, and any repo could then use that action (from the fork) with the pre-defined config in it, correct?

@thehanimo
At my company we use an action in a previous step to pull a file from a private repo shared across the organization, so that we can reuse the same config file for the PR Title Checker action across all of our team's repos.
But the config file could also be local to the repo running the action, correct!

name: Enforce PR Titles

on:
  workflow_call:

jobs:
  enforce-pr-title:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout repo with config file
        uses: actions/checkout@v3
        with:
          repository: ...
          ref: v4
          ssh-key: ${{ secrets.... }}
          path: .github/actions
      - name: Enforce PR Title
        uses<EMAIL_ADDRESS>        with:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          pass_on_octokit_error: false
          configuration_path: ".github/actions/enforce-pr-titles/config.json"
          use_local_configuration_file: true

I do not want to make changes to your main branch since you may be using it in your repos. I will merge this into dev and add support for external links (#28) and make a few changes.


Document DDL propagation

Fixes #159
Note that create index is not listed as DDL in the PostgreSQL manual. Should I include create index along with my other additions in this section or in a new subsection of Querying Distributed Tables (SQL)?

Includes renaming a column in the list so fixes #285

Just recapping our notes here:

Separate them into 3 larger sections: Adding/Modifying columns, Adding/Removing Constraints, Adding/Removing Indices.
Add examples for each: Especially valuable for highlighting special cases like needing to alter before table creation.
Add links to the relevant Postgres commands, so users can see full syntax.

Another note: If we don't intend to backpatch this immediately, we can also include content for CREATE INDEX CONCURRENTLY, since that has been checked-in, and will be part of the 6.2 release. Else, we should open up a separate issue, and fix it in a different PR.


MRTG should return average values over last five minutes

After implementation, realized how frustrating it can be if the thermometer hasn't been recorded in the last five minutes.

-a (--average) option added and working.


Cannot execute recordStubGenerator every second in output

Just got the newest bits (3.24.0). In the ouptut i get loads of this
[01:02:28 ERROR] Cannot execute recordStubGenerator, File '/extension-output-#6.fsx' not parsed
Ionide works, but it seems like something that shouldn't happen.

Thank you so much for a great product!

cc: @MangelMaxime

This is "normal"
recordStubGenerator is triggered by cursor move. Each time you move your cursor we are trying to see if you can generate a record at the new position.
One solution, could be to add a debouncer. Because, we want to check if we can generate a record at the cursor position, we only want to check the final cursor position.

@Krzysztof-Cieslak Something feel strange to me here.
The debouncer thing is probably something needed to send less request and also send only request that make sense.
But what I don't understand is where the file '/home/maxime/extension-output-#2.fsx' is coming from ?
When testing it locally several time, I had:

'/home/maxime/extension-output-#2.fsx'
'/home/maxime/extension-output-#1.fsx'

My opened file is SimpleType.fs and my working directory is /home/maxime/Workspace/ionide/ionide-fsgrammar so nothing to do with '/home/maxime/extension-output-#1.fsx'

Fixed in 3.24.1 - issue was caused by the fact that 1. there was no any throttling 2. record stub handler was not checking if the document was F# which caused infinite loop (i.e handler was executed when something was written to output channel, and handler itself was writing to output cha


Aave v2 / Compound 2.0.1 position implementation issues

Creating an issue to formally track the issues we are seeing with positional entites in aave v2 / compound forks. Not all issues are seen in every subgraph, but they all relate to the positional fields introduced in 2.0.1.
Issues:

Negative openPositionCount / seen in compound forks
Position entity failing to load often. This causes Transactions entities that rely on position to not be created and we miss valid transactions. / seen in aave v2 and compound
Seeing UniqueDepositorCount higher than UniqueUserCount  seen in compound
Liquidate entities don't have an actual position entity tied to them. / seen in compound (example query here)

Note: just because we haven't labeled it as an aave or compound issue doesn't mean it may not exist.

Separated this issue into their own individual issues


Use nmstate to replace nmcli commands

Using nmstate policy to create brcnv instead of using nmcli commands.

Closing as main branch not used any more.


Log4j Security Vulnerability CVE-2021-44832

Apache have recommended that the Log4j version be updated to at least 2.17.1 (https://logging.apache.org/log4j/2.x/). The latest plugin version 1.0.5 only updates to 2.17.0. Can the plugin be updated to fix the vulnerability?

PR merged with the fix.
Thanks @Stift


Bugfix - Netrw Tree Style Listing moves the cursor to a different position

This pull request fixes a bug in Netrw.
Netrw Tree Style Listing moves the cursor to a different position when the user presses the Enter key to perform a directory listing; in a Netrw buffer that the user has reloaded with ':edit' or ':buffer'.
The "Perform Directory Listing" part of the function 's:NetrwBrowse()' should only call 'winrestview()' when the listing style of Netrw is not Tree Style Listing.
Steps to reproduce the bug

Create the directory hierarchy:

$ mkdir -p ~/vim_bug/{dir1,dir2,dir3}
$ touch ~/vim_bug/{dir1,dir2,dir3}/{file1,file2,file3}
$ cd ~/vim_bug

Execute Vim:

$ vim -u NONE -c 'set nocompatible' -c 'let g:netrw_liststyle = 3' -c "source /usr/share/vim/vim82/plugin/netrwPlugin.vim"

Edit the current directory with Netrw:
:edit .
Move the cursor to "dir1" and press the Enter key.
Move the cursor to "file1" and press the Enter key.
Reopen netrw:
:edit .
Move the cursor to "dir3" and press the Enter key.

Netrw will move the cursor to a different position ("file1" under "dir1").

Cc @cecamp

I couldn't reproduce the issue anymore. I am going to close this pull request.

I can still reproduce the issue. I am going to reopen the pull request.


Import V8 Module Cache? Refresh?

I have been looking at the V8 Import capabilities and managed to get it working as below
Top Level File level1.js

import HelloWorld  from 'modules/level2.js'
HelloWorld()

Module file level2.js

export default function HelloWorld() {
    console.log("Hello World How Are you today!!")
}

My program is an automation tool that uses ClearScript at the backend. Therefore the scripts get executed multiple times at user discretion. During coding of the scripts if I make changes to the Module level2.js whilst the parent program is still running (but the scripts have finished) the original level2.js is executed instead of the updated code. If I stop and restart the parent program then the correct level2.js is executed.
This sounds like some sort of engine cache? Is this the case? Can I flush this somehow or tell engine not to cache the imported modules?

I just found this in some of your Test Code which seems to have resolved this.

                DocumentLoader.Default.DiscardCachedDocuments();
                GC.Collect();
                GC.WaitForPendingFinalizers();

Hi @egooner,
The DiscardCachedDocuments call should be sufficient.
Please reopen this issue if you have additional questions or concerns.
Thanks!

Thanks - been working through this and found the same. :)


Enforce Send bounds on KernelDense and KernelSparse traits

This allows loading an SVM model on one thread, move it to another thread and then use it there.

Thanks!


Promote envoy.extensions.filters.http.rbac.v3.RBAC.matcher from work_in_progress to stable

Title: Promote envoy.extensions.filters.http.rbac.v3.RBAC.matcher from work_in_progress to stable
Description:
The envoy.extensions.filters.http.rbac.v3.RBAC.matcher was introduced to the RBAC filter in PR #20877 over two and half years ago. It has also been utilized in the Envoy Gateway SecurityPolicy since 1.2.0 to support jwt-claim based authorization, with no reported issues. Given its extensive usage and proven stability, it's reasonable to consider promoting this field from work_in_progress to a stabe API. Doing so would eliminate the assoicated warnings from the Envoy log, which can be annoying for the EG users.
[optional Relevant Links:]
Related discussion on Envoy Gateway slack channel. https://envoyproxy.slack.com/archives/C03E6NHLESV/p1732212195317929
cc @arkodg

cc @yangminzhu @yanavlasov as HTTP RBAC filter codeowners

looks good!
@adisuissa is there anything needed by me for this? thanks.

looks good! @adisuissa is there anything needed by me for this? thanks.

Just your LGTM as code-owner :)
@yanavlasov for a chance to say something before I merge this.


IOT Hub Device commands fail in Azure Government

Description
Commands such as az iot device create --hub-name milopeiot -d testDevice fail when using the AzureUSGovernment environment. It appears to find the hub fine, but when creating the device, it fails as it is trying to connect to milopeiot.azure-devices.net instead of milopeiot.azure-devices.us. I'm not sure if I'm right on the next part, but this appears to be traced to a function named _get_device_client as it appears to use azure-devices.net directly in line 330 (link below):
https://github.com/Azure/azure-cli/blob/master/src/command_modules/azure-cli-iot/azure/cli/command_modules/iot/custom.py#L330

Environment summary
Install Method: How did you install the CLI? (e.g. pip, interactive script, apt-get, Docker, MSI, nightly)
Answer here: Used the latest MSI.
CLI Version: What version of the CLI and modules are installed? (Use az --version)
Answer here:
azure-cli (2.0.18)
acr (2.0.12)
acs (2.0.16)
appservice (0.1.17)
backup (1.0.1)
batch (3.1.4)
billing (0.1.5)
cdn (0.0.9)
cloud (2.0.8)
cognitiveservices (0.1.8)
command-modules-nspkg (2.0.1)
component (2.0.7)
configure (2.0.11)
consumption (0.1.5)
container (0.1.11)
core (2.0.17)
cosmosdb (0.1.13)
dla (0.0.12)
dls (0.0.14)
eventgrid (0.1.4)
extension (0.0.3)
feedback (2.0.6)
find (0.2.7)
interactive (0.3.10)
iot (0.1.12)
keyvault (2.0.11)
lab (0.0.11)
monitor (0.0.10)
network (2.0.15)
nspkg (3.0.1)
profile (2.0.13)
rdbms (0.0.7)
redis (0.2.9)
resource (2.0.15)
role (2.0.12)
servicefabric (0.0.4)
sql (2.0.12)
storage (2.0.16)
vm (2.0.15)
Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users[username].azure\cliextensions'
Python (Windows) 3.6.1 (v3.6.1:69c0db5, Mar 21 2017, 17:54:52) [MSC v.1900 32 bit (Intel)]
Legal docs and information: aka.ms/AzureCliLegal
OS Version: What OS and version are you using?
Answer here: Windows 10 Creators Update.
Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
Answer here: cmd.exe

Bug.

Created item to fix for Oct this year https://msazure.visualstudio.com/One/_workitems/edit/4979240


Add new test to Gigasecond problem

exercism/xjavascript PR#125 adds a new test to the problem. It would be nice to add a similar one to this repository.

@rchavarria I was looking at this and there's another important difference between the JS track and the ES track: the JS track expects an answer rounded down to midnight of the resulting giga-birthday, and the ES track does not round down.
I prepared a new test in the current style of the ES track for the ES track, but I'm wondering if the tracks should agree better.  Does it matter?

Check out the shared metadata for gigasecond: https://github.com/exercism/x-common/blob/master/gigasecond.json

@kytrinyx if I understand that metadata spec correctly, then the JS track test is not correct bc it drops the minutes and seconds from the expectedDate.  It uses midnight as the starting point rather than some arbitrary time of day, but 1GS later can (so should) include the minutes and seconds.
So, the ES track is right and the JS track needs fixing.
Do I have it right?

Agreed, the JS track should handle arbitrary times of day.

OK submitted a fix as exercism/xjavascript PR#129

Cool, I'll close this issue, then.


Fix deprecated method name in latest versions of THREE

I’m using the latest version of THREE in my branch (pr coming soon to expo-three) and this was required to get the orbit controls working since Quaternion.invert() was changed to Quaternion.inverse() in version 0.142.0.
If anyone else needs it, here's the patch:
expo-three-orbit-controls+2.0.0.patch:
diff --git a/node_modules/expo-three-orbit-controls/build/OrbitControls.js b/node_modules/expo-three-orbit-controls/build/OrbitControls.js
index 5540eb2..7bd2d6d 100644
--- a/node_modules/expo-three-orbit-controls/build/OrbitControls.js
+++ b/node_modules/expo-three-orbit-controls/build/OrbitControls.js
@@ -631,7 +631,8 @@ export class OrbitControls extends EventDispatcher {
             const offset = new Vector3();
             // so camera.up is the orbit axis
             const quat = new Quaternion().setFromUnitVectors(this.object.up, new Vector3(0, 1, 0));
-            const quatInverse = quat.clone().inverse();
+            // This patch fixes a deprecated method name in the latest version of THREE
+            const quatInverse = quat.clone().invert();
             const lastPosition = new Vector3();
             const lastQuaternion = new Quaternion();
             return () => {

@EvanBacon The threejs upgrade to expo-three has landed so anyone upgrading past<EMAIL_ADDRESS>will need this patch to use this library now.

I used these code to Temporary repair this
Quaternion.prototype.inverse = function () {     return this.invert() }


WARN Editor ID Mismatch: default !== imagePreview.previewEditor. This will cause bugs

Happened when I compared 2 PNGs without having extensions installed:

To verify:
Ensure you don't get this message anymore


Web reference shows wrong regexp which was already fixed in code

Report
I noticed that the web reference https://danger.systems/reference.html shows a wrong regexp ^+ instead of ^\+, even though https://github.com/danger/danger/pull/1167 fixed this problem.
Screenshot:

Possibly this page isn't updated, or a static page generator un-escapes \+.
Would you please update this regexp?
(Feel free to close this issue if this issue should be opened at https://gitlab.com/danger-systems/danger.systems.)

This should be fixed


Sauce Labs: Mobile Safari on iPhone emulator of El Capitan.

This is an attempt to stop the grief on Sauce Labs testing caused by flaky Mobile Safari on iPhone simulator. I don't know the right fix, so let's speculatively update it to running on OS X 10.11 (El Capitan) instead of OS X 10.10 (Yosemite).

Current coverage is 100.00%

Merging #1369 into master will not affect coverage as of fbd1c37

@@            master   #1369   diff @@
======================================
  Files            1       1
  Stmts         3088    3088
  Branches       585     585
  Methods          0       0
======================================
  Hit           3088    3088
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of fbd1c37

Powered by Codecov. Updated on successful CI builds.

Success! :sunglasses:


Rename project

It's high time we did this.

Once we fix on this, we'll have to

rename the pdpjudge folder to autojudge
rename the judge folder to aj_core (or something)

The reason I'm bugging about this is you don't want your kid to be great and have a weird name right? :-P


Remove unneeded dependency between unit tests and build/deploy jobs

What does this PR do?
It removes dependecies between our unit tests jobs and build / deploy jobs.

Motivation
These dependecies are not really required, they were used to enforce an order between execution of jobs. However it conflicts with https://github.com/DataDog/datadog-agent/pull/23239 that introduces a new variable to be able to disable unit tests (it can be useful for pipelines triggered from integrations-core)
No impact is expected, it could even slightly increase the speed of the CI with more parallelisation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Different versions not saved in google storage

Hi, thanks for the great gem!
I am having an issue, though, with saving thumbnails of my files in storage. It all works well in development, where I use file system but when I try to save page thumbnails through gcloud, it does not seem to be working.
Here's my uploader code:
class PageUploader < CarrierWave::Uploader::Base
  # Include RMagick or MiniMagick support:
  # include CarrierWave::RMagick
  include CarrierWave::MiniMagick

  def store_dir
    if Rails.env.production?
      "uploads/pages/#{model.parent_file_id}"
    elsif Rails.env.demo?
      "demo/uploads/pages/#{model.parent_file_id}"
    elsif Rails.env.test?
      "tmp/uploads/pages/#{model.parent_file_id}"
    else
      "development/uploads/pages/#{model.parent_file_id}"
    end
  end

  def extension_white_list
    ['pdf']
  end

  version :thumb do
    begin
      unless Rails.env.test?
        process convert: 'jpg'
        process resize_to_fit: [595, 842]
        process :set_content_type
      end
      def full_filename(for_file = model.attachment.file)
        "#{model.id}-thumb.jpg"
      end
    rescue Exception => e
      puts e.inspect
      true
    end
  end

  def set_content_type(*args)
    self.file.instance_variable_set(:@content_type, 'image/jepg')
  end

  def thumb_url
    thumb.try(:authenticated_url) || thumb.url
  end
end

Any help would be appreciated :)

The problem seemed to be overriden store method. It did not correctly use filename and content_type that was set inside the uploader.
This is a solution that worked for me (overwriting store once again):
CarrierWave::Storage::GcloudFile.class_eval do
  def store(new_file)
    bucket.create_file new_file.path, path, content_type: new_file.content_type
    self
  end

Thank you for reporting this, I'll take a look at this today.

any news about this ?

!!!
still not working and a fix/hack isn't so obvious

@LeKristapino  thank your for your fix!

sorry guys for making you wait on this. I've released 0.7.0 with this fix. please update your Gemfile


Update aws-java-sdk-core to 1.12.719

About this PR
📦 Updates com.amazonaws:aws-java-sdk-core from 1.12.459 to 1.12.719
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #756.


Update osv-scanner to v1.9.1

Can you please release a new version that uses osv-scanner v1.9.1?
I want to use new vulnerabilities.ignore feature  in package overrides

Ah my bad, turns out I merged the PR https://github.com/google/osv-scanner-action/pull/49 a months ago, but never made the actual release tag. 🤦
Release is made now!


Main into big bang

Sync up

I have submitted a follow up sync PR https://github.com/wildfly/wildfly/pull/15826 but nothing to stop this going in first as soon as CI is clean - I just wanted to get concurrency onto CI for big-bang without waiting.

Thanks, @darranl -- I went ahead and merged so I could work with it


iOS Simulator can not terminate app

What happened?
Added Detox to an existing react native project.  It failed to complete the detox test command due
child-process:EXEC_FAIL "/usr/bin/xcrun simctl terminate B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 org.reactjs.native.example.AwesomeProject" failed with error = ChildProcessError: Command failed: /usr/bin/xcrun simctl terminate B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 org.reactjs.native.example.AwesomeProject
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=3):
After reading about others who had similar issues, I assumed it was my project configuration.
So I then used the sample in React Native and confirmed the AwesomeProject successfully deployed on the simulator.  Then followed the instructions from the Detox site and successfully ran detox build;  However, it fails in the same way as my original project.
MacBook Pro - M1 2020
macOS Ventura 13.4.1
Xcode 14.3.1
detox test -l verbose --cleanup  --configuration ios.sim.debug
What was the expected behaviour?
The iOS simulator would terminate the app
Was it tested on latest Detox?

[X] I have tested this issue on the latest Detox release and it still reproduces.

Did your test throw out a timeout?

[ ] I have followed the instructions under Identifying which synchronization mechanism causes us to wait too much.

Help us reproduce this issue!
No response
In what environment did this happen?
Detox version: 20.11.1
React Native version: 0.72.3
Has Fabric (React Native's new rendering system) enabled: (yes/no) No
Node version: v20.5.0
Device model: iPhone 14
iOS version:
macOS version:  Ventura 13.4.1. (M1 2020)
Xcode version:   14.3.1
Test-runner (select one): jest / other. Jest
Detox logs
Detox logs
(base) thechrisoneil@Chriss-MacBook-Pro AwesomeProject % detox test -l verbose --cleanup  --configuration ios.sim.debug
15:27:01.491 detox[13335] i ws-server Detox server listening on localhost:50627...
15:27:01.495 detox[13335] B lifecycle jest --config e2e/jest.config.js
watchman warning:  Recrawled this watch 3 times, most recently because:
MustScanSubDirs UserDroppedTo resolve, please review the information on
https://facebook.github.io/watchman/docs/troubleshooting.html#recrawl
To clear this warning, run:
`watchman watch-del '/Users/thechrisoneil/software/react-native/AwesomeProject' ; watchman watch-project '/Users/thechrisoneil/software/react-native/AwesomeProject'`

Determining test suites to run...
15:27:02.348 detox[13336] i child-process:EXEC_CMD applesimutils --list --byType "iPhone 14"
15:27:02.585 detox[13336] i child-process:EXEC_CMD applesimutils --list --byId B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 --maxResults 1
15:27:02.806 detox[13336] i child-process:EXEC_CMD /usr/bin/xcrun simctl boot B9AD5297-A76B-41D8-9C0F-435F87BBE3B3
15:27:02.806 detox[13336] i child-process:EXEC_TRY Booting device B9AD5297-A76B-41D8-9C0F-435F87BBE3B3...
15:27:03.259 detox[13336] i child-process:EXEC_CMD /usr/bin/xcrun simctl bootstatus B9AD5297-A76B-41D8-9C0F-435F87BBE3B3
15:27:06.770 detox[13336] i child-process:EXEC_CMD open -a Simulator --args -CurrentDeviceUDID B9AD5297-A76B-41D8-9C0F-435F87BBE3B3
15:27:06.838 detox[13336] i child-process:EXEC_CMD /usr/bin/xcrun simctl io B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 screenshot "/dev/null"
15:27:07.412 detox[13336] i child-process:EXEC_CMD /usr/bin/xcrun simctl uninstall B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 org.reactjs.native.example.AwesomeProject
15:27:07.412 detox[13336] i child-process:EXEC_TRY Uninstalling org.reactjs.native.example.AwesomeProject...
15:27:08.154 detox[13336] i child-process:EXEC_SUCCESS org.reactjs.native.example.AwesomeProject uninstalled
15:27:08.156 detox[13336] i child-process:EXEC_CMD /usr/bin/xcrun simctl terminate B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 org.reactjs.native.example.AwesomeProject
15:27:08.156 detox[13336] i child-process:EXEC_TRY Terminating org.reactjs.native.example.AwesomeProject...
15:27:09.600 detox[13336] i child-process:EXEC_TRY Terminating org.reactjs.native.example.AwesomeProject...
15:27:09.878 detox[13336] i child-process:EXEC_FAIL "/usr/bin/xcrun simctl terminate B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 org.reactjs.native.example.AwesomeProject" failed with error = ChildProcessError: Command failed: /usr/bin/xcrun simctl terminate B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 org.reactjs.native.example.AwesomeProject
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=3):
Simulator device returned an error for the requested operation.
found nothing to terminate
Underlying error (domain=NSPOSIXErrorDomain, code=3):
	The request to terminate "org.reactjs.native.example.AwesomeProject" failed. found nothing to terminate
	found nothing to terminate
 `/usr/bin/xcrun simctl terminate B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 org.reactjs.native.example.AwesomeProject` (exited with error code 3) (code=3), stdout and stderr:

15:27:09.878 detox[13336] i child-process:EXEC_FAIL
15:27:09.878 detox[13336] i child-process:EXEC_FAIL An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=3):
Simulator device returned an error for the requested operation.
found nothing to terminate
Underlying error (domain=NSPOSIXErrorDomain, code=3):
	The request to terminate "org.reactjs.native.example.AwesomeProject" failed. found nothing to terminate
	found nothing to terminate

15:27:09.883 detox[13335] E ws-server connection :50627<->:50628
15:27:09.883 detox[13336] i child-process:EXEC_CMD /usr/bin/xcrun simctl shutdown B9AD5297-A76B-41D8-9C0F-435F87BBE3B3
15:27:09.883 detox[13336] i child-process:EXEC_TRY Shutting down B9AD5297-A76B-41D8-9C0F-435F87BBE3B3...
15:27:13.266 detox[13336] i child-process:EXEC_SUCCESS B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 shut down
 FAIL  e2e/starter.test.js
  ● Test suite failed to run

    ChildProcessError: Command failed: /usr/bin/xcrun simctl terminate B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 org.reactjs.native.example.AwesomeProject
    An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=3):
    Simulator device returned an error for the requested operation.
    found nothing to terminate
    Underlying error (domain=NSPOSIXErrorDomain, code=3):
    	The request to terminate "org.reactjs.native.example.AwesomeProject" failed. found nothing to terminate
    	found nothing to terminate
     `/usr/bin/xcrun simctl terminate B9AD5297-A76B-41D8-9C0F-435F87BBE3B3 org.reactjs.native.example.AwesomeProject` (exited with error code 3)

      at callback (node_modules/child-process-promise/lib/index.js:33:27)

15:27:13.385 detox[13335] E lifecycle Command failed with exit code = 1:
jest --config e2e/jest.config.js
15:27:13.386 detox[13335] i ws-server Detox server has been closed gracefully

Device logs
Device logs
paste your device.log here!

More data, please!
No response

I am also experiencing this issue after upgrading react native to 0.72.3

The same issue for RN 0.72.x

Old architecture
JSC engine
"detox": "^20.11.2"

2023-08-08T22:24:50.8522480Z $ /Users/runner/work/node_modules/.bin/detox test -c ios.sim.release --cleanup --noStackTrace --detectOpenHandles --forceExit -l verbose --maxWorkers 1 --retries 1 2023-08-08T22:24:51.8858840Z 22:24:51.876 detox[31494] i ws-server Detox server listening on localhost:49302... 2023-08-08T22:24:51.9092590Z 22:24:51.908 detox[31494] B lifecycle jest --config detox.config.js --noStackTrace --detectOpenHandles --forceExit --maxWorkers 1 2023-08-08T22:24:55.4135880Z 22:24:55.413 detox[31494] B ws-server connection :49302<->:49303 2023-08-08T22:24:55.9851270Z 22:24:55.983 detox[31496] i child-process:EXEC_CMD applesimutils --list --byOS 16.4 --byType "iPhone 14" 2023-08-08T22:24:58.4659620Z 22:24:58.465 detox[31496] i child-process:EXEC_CMD applesimutils --list --byId E7678A35-F784-403F-ABF5-827436E79FCD --maxResults 1 2023-08-08T22:24:59.2978250Z 22:24:59.297 detox[31496] i child-process:EXEC_CMD /usr/bin/xcrun simctl boot E7678A35-F784-403F-ABF5-827436E79FCD  2023-08-08T22:24:59.2987550Z 22:24:59.298 detox[31496] i child-process:EXEC_TRY Booting device E7678A35-F784-403F-ABF5-827436E79FCD... 2023-08-08T22:25:01.8854810Z 22:25:01.885 detox[31496] i child-process:EXEC_CMD /usr/bin/xcrun simctl bootstatus E7678A35-F784-403F-ABF5-827436E79FCD 2023-08-08T22:27:44.1819790Z 22:27:44.109 detox[31496] i child-process:EXEC_CMD open -a Simulator --args -CurrentDeviceUDID E7678A35-F784-403F-ABF5-827436E79FCD 2023-08-08T22:27:50.8327370Z 22:27:50.785 detox[31496] i child-process:EXEC_CMD /usr/bin/xcrun simctl io E7678A35-F784-403F-ABF5-827436E79FCD screenshot "/dev/null" 2023-08-08T22:28:01.7893540Z 22:28:01.788 detox[31496] i child-process:EXEC_CMD /usr/bin/xcrun simctl uninstall E7678A35-F784-403F-ABF5-827436E79FCD com.preply 2023-08-08T22:28:01.7921330Z 22:28:01.790 detox[31496] i child-process:EXEC_TRY Uninstalling com.preply... 2023-08-08T22:28:03.2143730Z 22:28:03.213 detox[31496] i child-process:EXEC_SUCCESS com.preply uninstalled 2023-08-08T22:28:03.2184800Z 22:28:03.217 detox[31496] i child-process:EXEC_CMD /usr/bin/xcrun simctl terminate E7678A35-F784-403F-ABF5-827436E79FCD com.preply 2023-08-08T22:28:03.2209710Z 22:28:03.218 detox[31496] i child-process:EXEC_TRY Terminating com.preply... 2023-08-08T22:28:05.1978220Z 22:28:05.197 detox[31496] i child-process:EXEC_TRY Terminating com.preply... 2023-08-08T22:28:05.9494000Z 22:28:05.948 detox[31496] i child-process:EXEC_FAIL "/usr/bin/xcrun simctl terminate E7678A35-F784-403F-ABF5-827436E79FCD com.preply" failed with error = ChildProcessError: Command failed: /usr/bin/xcrun simctl terminate E7678A35-F784-403F-ABF5-827436E79FCD com.preply 2023-08-08T22:28:05.9510770Z An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=3): 2023-08-08T22:28:05.9512080Z Simulator device returned an error for the requested operation. 2023-08-08T22:28:05.9513350Z found nothing to terminate 2023-08-08T22:28:05.9514290Z Underlying error (domain=NSPOSIXErrorDomain, code=3): 2023-08-08T22:28:05.9878790Z 	The operation couldn’t be completed. found nothing to terminate 2023-08-08T22:28:05.9880360Z 	found nothing to terminate 2023-08-08T22:28:05.9907910Z  /usr/bin/xcrun simctl terminate E7678A35-F784-403F-ABF5-827436E79FCD com.preply(exited with error code 3) (code=3), stdout and stderr: 2023-08-08T22:28:05.9909060Z  2023-08-08T22:28:05.9911800Z 22:28:05.949 detox[31496] i child-process:EXEC_FAIL  2023-08-08T22:28:05.9914320Z 22:28:05.950 detox[31496] i child-process:EXEC_FAIL An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=3): 2023-08-08T22:28:05.9915430Z Simulator device returned an error for the requested operation. 2023-08-08T22:28:05.9916260Z found nothing to terminate 2023-08-08T22:28:05.9918260Z Underlying error (domain=NSPOSIXErrorDomain, code=3): 2023-08-08T22:28:05.9944200Z 	The operation couldn’t be completed. found nothing to terminate 2023-08-08T22:28:05.9945840Z 	found nothing to terminate 2023-08-08T22:28:05.9946640Z  2023-08-08T22:28:05.9952250Z 22:28:05.951 detox[31496] i child-process:EXEC_CMD /usr/bin/xcrun simctl install E7678A35-F784-403F-ABF5-827436E79FCD "/Users/runner/work/os/build/Build/Products/Release-iphonesimulator/Preply.app" 2023-08-08T22:28:05.9961900Z 22:28:05.952 detox[31496] i child-process:EXEC_TRY Installing /Users/runner/work/apollo-mobile/apollo-mobile/ios/build/Build/Products/Release-iphonesimulator/Preply.app... 2023-08-08T22:28:13.3428700Z 22:28:13.251 detox[31496] i child-process:EXEC_SUCCESS /Users/runner/work/ios/build/Build/Products/Release-iphonesimulator/Preply.app installed 2023-08-08T22:28:13.4556110Z 22:28:13.261 detox[31496] i child-process:EXEC_CMD /usr/bin/xcrun simctl terminate E7678A35-F784-403F-ABF5-827436E79FCD com.preply 2023-08-08T22:28:13.4999280Z 22:28:13.262 detox[31496] i child-process:EXEC_TRY Terminating com.preply... 2023-08-08T22:28:16.0312440Z 22:28:16.030 detox[31496] i child-process:EXEC_TRY Terminating com.preply... 2023-08-08T22:28:17.1719280Z 22:28:17.169 detox[31496] i child-process:EXEC_FAIL "/usr/bin/xcrun simctl terminate E7678A35-F784-403F-ABF5-827436E79FCD com.preply" failed with error = ChildProcessError: Command failed: /usr/bin/xcrun simctl terminate E7678A35-F784-403F-ABF5-827436E79FCD com.preply 2023-08-08T22:28:17.1723720Z An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=3): 2023-08-08T22:28:17.1725710Z Simulator device returned an error for the requested operation. 2023-08-08T22:28:17.1728070Z found nothing to terminate 2023-08-08T22:28:17.1731520Z Underlying error (domain=NSPOSIXErrorDomain, code=3): 2023-08-08T22:28:17.1734380Z 	The operation couldn’t be completed. found nothing to terminate 2023-08-08T22:28:17.1737050Z 	found nothing to terminate 2023-08-08T22:28:17.1740040Z /usr/bin/xcrun simctl terminate E7678A35-F784-403F-ABF5-827436E79FCD com.preply (exited with error code 3) (code=3), stdout and stderr: 2023-08-08T22:28:17.1741040Z  2023-08-08T22:28:17.1747480Z 22:28:17.172 detox[31496] i child-process:EXEC_FAIL  2023-08-08T22:28:17.1754980Z 22:28:17.173 detox[31496] i child-process:EXEC_FAIL An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=3): 2023-08-08T22:28:17.1761510Z Simulator device returned an error for the requested operation. 2023-08-08T22:28:17.1763140Z found nothing to terminate 2023-08-08T22:28:17.1765540Z Underlying error (domain=NSPOSIXErrorDomain, code=3): 2023-08-08T22:28:17.1767520Z 	The operation couldn’t be completed. found nothing to terminate 2023-08-08T22:28:17.1769240Z 	found nothing to terminate

@TheMakerOleguch I faced the same issue in CI, but I somehow managed to workaround it by doubling the timeout time(in .detoxrc and jest.config).
as I think Detox keeps trying to install the app in Simulator until it succeeds.
Hope this will help someone

@Yassir4 tried with 24000ms setup timeout with no luck

It sounds like there's an issue with RN 72 and Detox. We don't officially support this version yet, but we will soon. We will take this issue into consideration when upgrading Detox to comply with RN 72.

A simple solution for CircleCI would be to add a timeout parameter to the step that runs yarn detox test. Not sure about GH actions but there must be an equivalent.
In our case, we added timeout=300 which gracefully exits the job with exit code zero if no output was generated within 5 minutes.
Of course this is a temporary solution until the final fix comes with RN 0.72 support

I'm seeing the same issue with RN 0.71.11 and Detox 19.5.7

Some of my colleagues are seeing this on "react-native": "0.72.4", "detox": "20.9.1",

Hi all.
With same codebase I'm able to reproduce this bug on machine with XCode 15. But it works well with previous XCode version. I've applied patch to<EMAIL_ADDRESS>As a temporary solution to disable termination.
diff --git a/node_modules/detox/src/devices/runtime/drivers/ios/SimulatorDriver.js b/node_modules/detox/src/devices/runtime/drivers/ios/SimulatorDriver.js
index 878d483..1eacf07 100644
--- a/node_modules/detox/src/devices/runtime/drivers/ios/SimulatorDriver.js
+++ b/node_modules/detox/src/devices/runtime/drivers/ios/SimulatorDriver.js
@@ -107,9 +107,10 @@ class SimulatorDriver extends IosDriver {

   async terminate(bundleId) {
     const { udid } = this;
-    await this.emitter.emit('beforeTerminateApp', { deviceId: udid, bundleId });
-    await this._applesimutils.terminate(udid, bundleId);
-    await this.emitter.emit('terminateApp', { deviceId: udid, bundleId });
+    // await this.emitter.emit('beforeTerminateApp', { deviceId: udid, bundleId });
+    // await this._applesimutils.terminate(udid, bundleId);
+    // await this.emitter.emit('terminateApp', { deviceId: udid, bundleId });
   }

   async setBiometricEnrollment(yesOrNo) {

hi @kvramyasri7,
we use
"react-native": "0.72.5"
"detox": "^19.13.0",

BTW in our version we added NO_FLIPPER config in react-native.config.js and installed pods without flipper.
Otherwisedetox build is failing. Also IOS 17 version on simulator is 3 times slower in our CI machine. So we switched to IOS 16.4.
p.s. this version of react-native has support of XCode 15.

Any official solutions to this issue? I'm using the RN 0.74.2 and Detox 20.9.1, after upgraded to Xcode15, this issue emerged, is there any avaliable version I can upgrade to?

We'll try to check soon if there are indeed some issues with Xcode 15.

Guys, we will only advance here if you create some exact reproduction repo. I understand you have an issue, but the conditions to reproduce this issue seem much more specific than originally described. There has to be something else in the equation.

Hate to be a "me too" without anything substantive to add, but adding anyway just to reflect another user with the same problem. I can reproduce this reliably on my M1 Mac, v19.12.6 on 0.72.6.  If/when I find anything interesting I'll be sure to update.

Maybe M* platform issue then, hm?

after updating XCode to latest 15.0.1/15A507. it works well without patch. I think it was xcode issue

@PetroPavlenko, thanks for the new info. Indeed, I started my investigation straight from the latest Xcode version. Maybe 15.0.0 indeed had an issue. 🤷
Can anyone else confirm?

At the moment, the best I can share is I was already on 15.0.1 but I updated the detox library to 20.13.5. I now have to update all my configurations (was previously on v19), but just running it as a one-off with legacy configurations I did see deprecation warnings, which looks better than what was happening before... will add more after validating with correct configuration.

Code Of Conduct. Please follow community guidelines.

Hi @noomorph At the moment, the best I can share is I was already on 15.0.1 but I updated the detox library to 20.13.5. I now have to update all my configurations (was previously on v19), but just running it as a one-off with legacy configurations I did see deprecation warnings, which looks better than what was happening before... will add more after validating with correct configuration.
EDIT - I also have success after updating to latest detox package and applying correct new configurations. I was already on 15.0.1 before I updated. Whether it is an M series issue is still not clear to me. I have other colleagues using the older 19.13.x version of detox with 15.0.1 and it works, but they are on Ventura while I am on Sonoma, so I am curious if there is an OS component involved here too.

Similar here. A colleague is on Xcode 14 + Ventura (works), and I'm on Xcode 15 + Sonoma (doesn't work). Detox on 20.x

Also worked for me after upgrading to RN 0.72.7 and detox 20.13.5

react-native "0.71.14", encountered the same issue. Then upgraded detox from "^20.5.0" to "^20.13.5", the issue resolved. By the way, my xcode version is "15.0.1/15A507"

i think this was due to https://forums.developer.apple.com/forums/thread/699615 and was fixed here already, so updating detox should do the trick.

detox: 20.11.1 - has issue, unable to run
detox: 20.19.3 - no issue, works correctly

The issue reported by @TheChrisOneil has been already addressed, it was resolved in version 20.11.4. We highly recommend upgrading to the latest version of Detox.
If any of the commenters continue to encounter errors after upgrading, please open a new issue. We are more than willing to assist further 🙏🏼

i'm running into the issue still with detox 20.19.1 when using xcode 15.2.0 in circleci.

i'm running into the issue still with detox 20.19.1 when using xcode 15.2.0 RN 0.70.13 in circleci.

Adding this before the yarn detox call worked for me:
NODE_OPTIONS='--dns-result-order=ipv4first'.
Context: Node 18 prefers IPv6 over IPv4 and I had just bumped from Node 16 to 18.
Tested: detox 20.19.3 using Xcode 15.2 with RN 0.73.7

You can probably solve this by doing this https://www.youtube.com/watch?v=9bDDWNoibIk


Clip reranking

I try to use CLIP for ranking the image that produce by DALLE model
I must install !pip install git+https://github.com/openai/CLIP.git  but it require torch = 1.7.1
and this version of torch haven't torchtext = 0.9.1
when I use torch = 1.7.1 I have this error :

when I use torch = 1.8.1 I have this error :
'CLIP' object has no attribute 'load'
what should I do ,Please?

It's likely from a version discrepancy where torchtext was compiled with a newer version of pytorch but installing CLIP downgraded pytorch to 1.7.1. Until we fix the dependency issue, try this trick to ignore CLIP's dependencies.


Lag issue when Scrolling

On my PC its not really a Problem but a laptop for example struggles real bad on scrolling.
On Taskmanager it says high gpu usage 10% with rtx 3060ti
Using Vscodium, Windows10
Installed Version:
Apc Customize UI++ v0.3.9
VSCode Animations v2.0.3
The Exported Profile if you want to test:
VSAnimations_LagProfile.zip

Sorry for the delay, should be fixed in the new version, 2.0.4. Let me know if it works please!


ModuleNotFoundError: No module named 'shap.utils'

After !pip install git+https://github.com/slundberg/shap.git with today's version, I get:
/usr/local/lib/python3.6/dist-packages/statsmodels/tools/_testing.py:19: FutureWarning: pandas.util.testing is deprecated. Use the functions in the public API at pandas.testing instead.
  import pandas.util.testing as tm
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-7-d1d468588b4d> in <module>()
     23 from xgboost import plot_importance
     24 from sklearn.metrics import explained_variance_score, mean_squared_error, r2_score
---> 25 import shap
     26
     27 # set plot preferences

2 frames
/usr/local/lib/python3.6/dist-packages/shap/explainers/_permutation.py in <module>()
----> 1 from ..utils import partition_tree_shuffle, MaskedModel
      2 from .._explanation import Explanation
      3 from ._explainer import Explainer
      4 import numpy as np
      5 import pandas as pd

ModuleNotFoundError: No module named 'shap.utils'

I'm on Google Colab Pro.

I'm getting the same error

This  commit worked for me: f3369c7
Although it comes before the latest API change, but what I wanted was the categorical variables support of issue 373, so it's good for me.
Thanks for this awesome package!
python -m pip install https://github.com/slundberg/shap/archive/f3369c7.zip

I can recreate the error as well. It is with the latest commit v0.36.0.

I edited the shap/setup.py this line
       packages=[             'shap', 'shap.explainers', 'shap.explainers.other', 'shap.explainers._deep',             'shap.plots.colors', 'shap.plots', 'shap.benchmark', 'shap.maskers', 'shap.utils'         ],

I edited the shap/setup.py this line
 packages=[ 'shap', 'shap.explainers', 'shap.explainers.other', 'shap.explainers._deep', 'shap.plots.colors', 'shap.plots', 'shap.benchmark', 'shap.maskers', 'shap.utils' ],

This works for me.

The fix has been merged to master in commit fea1918c008b248d88f77d66b951504a374badcd. The latest pip install version works fine now.


Performance best practices

according to miskow presentation on Angularjs MTV meetup Best Practices at 49:44
he say that performance depend on 2 thing :

How many binding you have.
How expensive you getter. (should fast)

And i think that means simple and fast. In my comprehension getter mean a method in a service. But in my case a little bit complex.
So how make it simple? i guest it's not possible to change the algorithm? or just calling internal (private) function in a service? does it take effect?
So here is my question :

Best practice to make getter on a method in service so will not cause memory leak.

I hope you can make an clear axample like in the style guide, and update to add this section to the style guide

How IIFE work ? Can you explain it to me?
How IIFE work on a function inside factory (method in service)? is it remove the global variable too? even if i use var, like when we return a factory?

Sorry to brother you daddy :smiley: (papa means daddy in my country)

Good questions, but also pretty long answers :)
Your best bet is to take questions to StackOverflow. This repo is for the guide.


CEWK-2840 ColorSelect2 redesign

Closes: https://vimean.atlassian.net/browse/CEWK-2840?focusedCommentId=786710&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-786710
What this PR does

Style ColorSelect2 according to updated design
Add disabled prop to ColorSelect2
Move Presets internally into the ColorSelect2 popover according to design and add presets prop
Update storybook
Update & add tests

Screenshots & Recordings

Testing

Run tests
Storybook: https://vimeo.github.io/iris/sb/CEWK-2840-colorselect2-design-update/?path=/story/components-colorselect2--controls

Since there's an update to what the ColorSelect2 looks like with presets, could you also include a story for ColorSelect2 input? (the display of this can just live alongside the preset button, for visual regression snapshot purposes)

It would also be beneficial to show the disabled state of this component as well

Since there's an update to what the ColorSelect2 looks like with presets, could you also include a story for ColorSelect2 input? (the display of this can just live alongside the preset button, for visual regression snapshot purposes)

@juliewongbandue not sure I follow what you mean? Isn't that the same as the ColorSelect2 story?

Since there's an update to what the ColorSelect2 looks like with presets, could you also include a story for ColorSelect2 input? (the display of this can just live alongside the preset button, for visual regression snapshot purposes)

@juliewongbandue not sure I follow what you mean? Isn't that the same as the ColorSelect2 story?

@alonmeiri sorry for the confusion. Yes, the ColorSelect and ColorSelect2 stories are the same, but since the ColorSelect2 has modified the props with the presets being on the inside of the component, I was thinking of just presenting the content of the popover in the ColorSelect2 in a story:

So this: https://github.com/vimeo/iris/blob/CEWK-2840-colorselect2-design-update/src/components/inputs/ColorSelect2/ColorSelect2.tsx#L86-L115 with its' different possible states, so we can just keep track of it with our visual regression tool. Does that make sense?


[XPU] add lora optimization (#8527)

PR types
Performance optimization

PR changes

Models
Description

Cherry-pick https://github.com/PaddlePaddle/PaddleNLP/pull/8527 , optimize LoRA performance on XPU.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Staging to Main (Small changes)

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Build Failed.  Found errors in the project; aborting build.

Environment

Dev OS: WIN10
@rnmapbox/maps version: 10.1.3
React Native version: 0.73.1

Steps to reproduce
After all the setup that i made before build the app to release for testing. I encountered a build issue.
Here's the message.
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\styles\RNMBXStyleValue.kt:43: Warning: Implicitly using the default locale is a common source of bugs: Use toUpperCase(Locale) instead. For strings meant to be internal use Locale.ROOT, otherwise Locale.getDefault(). [DefaultLocale]
return mPayload!!.getString("value")!!.toUpperCase().replace("-", "_")
~~~~~~~~~~~
Explanation for issues of type "DefaultLocale":
Calling String#toLowerCase() or #toUpperCase() without specifying an
explicit locale is a common source of bugs. The reason for that is that
those methods will use the current locale on the user's device, and even
though the code appears to work correctly when you are developing the app,
it will fail in some locales. For example, in the Turkish locale, the
uppercase replacement for i is not I.
If you want the methods to just perform ASCII replacement, for example to
convert an enum name, call String#toUpperCase(Locale.US) instead. If you
really want to use the current locale, call
String#toUpperCase(Locale.getDefault()) instead.
https://developer.android.com/reference/java/util/Locale.html#default_locale
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\modules\CustomHttpHeaders.kt:13: Error: HttpServiceFactory.getInstance can only be called from within the same library group prefix (referenced groupId=com.mapbox.common with prefix com.mapbox from groupId=SafeKidTracker) [RestrictedApi]
HttpServiceFactory.getInstance().setInterceptor(
~~~~~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\modules\CustomHttpHeaders.kt:13: Error: HttpServiceInterface.setInterceptor can only be called from within the same library group prefix (referenced groupId=com.mapbox.common with prefix com.mapbox from groupId=SafeKidTracker) [RestrictedApi]
HttpServiceFactory.getInstance().setInterceptor(
~~~~~~~~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\modules\CustomHttpHeaders.kt:14: Error: HttpServiceInterface.setInterceptor can only be called from within the same library group prefix (referenced groupId=com.mapbox.common with prefix com.mapbox from groupId=SafeKidTracker) [RestrictedApi]
this
~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\modules\CustomHttpHeaders.kt:32: Error: DownloadOptions.getRequest can only be called from within the same library group prefix (referenced groupId=com.mapbox.common with prefix com.mapbox from groupId=SafeKidTracker) [RestrictedApi]
download.request.headers[entry.key] = entry.value
~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\modules\CustomHttpHeaders.kt:32: Error: DownloadOptions.getRequest can only be called from within the same library group prefix (referenced groupId=com.mapbox.common with prefix com.mapbox from groupId=SafeKidTracker) [RestrictedApi]
download.request.headers[entry.key] = entry.value
~~~~~~~
Explanation for issues of type "RestrictedApi":
This API has been flagged with a restriction that has not been met.
Examples of API restrictions:

Method can only be invoked by a subclass
Method can only be accessed from within the same library (defined by the
Gradle library group id)
Method can only be accessed from tests.

You can add your own API restrictions with the @RestrictTo annotation.
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\events\EventEmitter.java:25: Warning: This method should only be accessed from tests or within private scope [VisibleForTests]
.getCurrentReactContext();
~~~~~~~~~~~~~~~~~~~~~~
Explanation for issues of type "VisibleForTests":
With the @VisibleForTesting annotation you can specify an otherwise=
attribute which specifies the intended visibility if the method had not
been made more widely visible for the tests.
This check looks for accesses from production code (e.g. not tests) where
the access would not have been allowed with the intended production
visibility.
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\utils\ResourceUtils.java:19: Warning: Use of this function is discouraged because resource reflection makes it harder to perform build optimizations and compile-time verification of code. It is much more efficient to retrieve resources by identifier (e.g. R.foo.bar) than by name (e.g. getIdentifier("bar", "foo", null)). [DiscouragedApi]
final int resID = resources.getIdentifier(resourceName, "drawable", context.getPackageName());
~~~~~~~~~~~~~
Explanation for issues of type "DiscouragedApi":
Discouraged APIs are allowed and are not deprecated, but they may be unfit
for common use (e.g. due to slow performance or subtle behavior).
D:\Projects\Mobile App\ReactNative<EMAIL_ADDRESS>Warning: Found bitmap drawable res/drawable/empty_drawable.png in densityless folder [IconLocation]
Explanation for issues of type "IconLocation":
The res/drawable folder is intended for density-independent graphics such
as shapes defined in XML. For bitmaps, move it to drawable-mdpi and
consider providing higher and lower resolution versions in drawable-ldpi,
drawable-hdpi and drawable-xhdpi. If the icon really is density independent
(for example a solid color) you can place it in drawable-nodpi.
https://developer.android.com/guide/practices/screens_support.html
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\res: Warning: Missing density variation folders in src\main\res: drawable-hdpi, drawable-mdpi, drawable-xhdpi [IconMissingDensityFolder]
Explanation for issues of type "IconMissingDensityFolder":
Icons will look best if a custom version is provided for each of the major
screen density classes (low, medium, high, extra-high, extra-extra-high).
This lint check identifies folders which are missing, such as
drawable-hdpi.
Low density is not really used much anymore, so this check ignores the ldpi
density. To force lint to include it, set the environment variable
ANDROID_LINT_INCLUDE_LDPI=true. For more information on current density
usage, see https://developer.android.com/about/dashboards
https://developer.android.com/guide/practices/screens_support.html
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\camera\RNMBXCamera.kt:39: Warning: Custom view RNMBXCamera is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int) [ViewConstructor]
class RNMBXCamera(private val mContext: Context, private val mManager: RNMBXCameraManager) :
~~~~~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\images\RNMBXImage.kt:15: Warning: Custom view RNMBXImage is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int) [ViewConstructor]
class RNMBXImage(private val mContext: ReactApplicationContext, private val mManager: RNMBXImageManager): ReactViewGroup(mContext), View.OnLayoutChangeListener {
~~~~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\images\RNMBXImages.kt:70: Warning: Custom view RNMBXImages is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int) [ViewConstructor]
class RNMBXImages(context: Context, private val mManager: RNMBXImagesManager) : AbstractMapFeature(context), NativeImageUpdater {
~~~~~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\mapview\RNMBXMapView.kt:214: Warning: Custom view RNMBXMapView is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int) [ViewConstructor]
open class RNMBXMapView(private val mContext: Context, var mManager: RNMBXMapViewManager, options: MapInitOptions?) : FrameLayout(mContext), OnMapClickListener, OnMapLongClickListener, OnLayoutChangeListener {
~~~~~~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\annotation\RNMBXMarkerView.kt:23: Warning: Custom view RNMBXMarkerView is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int) [ViewConstructor]
class RNMBXMarkerView(context: Context?, private val mManager: RNMBXMarkerViewManager):
~~~~~~~~~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\annotation\RNMBXPointAnnotation.kt:27: Warning: Custom view RNMBXPointAnnotation is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int) [ViewConstructor]
class RNMBXPointAnnotation(private val mContext: Context, private val mManager: RNMBXPointAnnotationManager) : AbstractMapFeature(mContext), View.OnLayoutChangeListener {
~~~~~~~~~~~~~~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\styles\sources\RNMBXRasterDemSource.kt:22: Warning: Custom view RNMBXRasterDemSource is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int) [ViewConstructor]
class RNMBXRasterDemSource(context: Context?, private val mManager: RNMBXRasterDemSourceManager) :
~~~~~~~~~~~~~~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\styles\sources\RNMBXShapeSource.kt:31: Warning: Custom view RNMBXShapeSource is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int) [ViewConstructor]
class RNMBXShapeSource(context: Context, private val mManager: RNMBXShapeSourceManager) :
~~~~~~~~~~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\styles\sources\RNMBXVectorSource.kt:19: Warning: Custom view RNMBXVectorSource is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int) [ViewConstructor]
class RNMBXVectorSource(context: Context?, private val mManager: RNMBXVectorSourceManager) :
~~~~~~~~~~~~~~~~~
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\camera\RNMBXViewport.kt:62: Warning: Custom view RNMBXViewport is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int) [ViewConstructor]
class RNMBXViewport(private val mContext: Context, private val mManager: RNMBXViewportManager) :
~~~~~~~~~~~~~
Explanation for issues of type "ViewConstructor":
Some layout tools (such as the Android layout editor) need to find a
constructor with one of the following signatures:

View(Context context)
View(Context context, AttributeSet attrs)
View(Context context, AttributeSet attrs, int defStyle)

If your custom view needs to perform initialization which does not apply
when used in a layout editor, you can surround the given code with a check
to see if View#isInEditMode() is false, since that method will return false
at runtime but true within a user interface editor.
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\mapview\RNMBXMapView.kt:1524: Warning: Custom view MapView has setOnTouchListener called on it but does not override performClick [ClickableViewAccessibility]
mapView.setOnTouchListener { view, event ->
^
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\mapview\RNMBXMapView.kt:1524: Warning: onTouch lambda should call View#performClick when a click is detected [ClickableViewAccessibility]
mapView.setOnTouchListener { view, event ->
^
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\mapview\RNMBXMapView.kt:1530: Warning: Custom view MapView has setOnTouchListener called on it but does not override performClick [ClickableViewAccessibility]
mapView.setOnTouchListener { view, event ->
^
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\java\com\rnmapbox\rnmbx\components\mapview\RNMBXMapView.kt:1530: Warning: onTouch lambda should call View#performClick when a click is detected [ClickableViewAccessibility]
mapView.setOnTouchListener { view, event ->
^
Explanation for issues of type "ClickableViewAccessibility":
If a View that overrides onTouchEvent or uses an OnTouchListener does not
also implement performClick and call it when clicks are detected, the View
may not handle accessibility actions properly. Logic handling the click
actions should ideally be placed in View#performClick as some accessibility
services invoke performClick when a click action should occur.
D:\Projects\Mobile App\ReactNative Cli\SafeKidTracker\node_modules@rnmapbox\maps\android\src\main\res\layout\annotation.xml:7: Warning: Missing contentDescription attribute on image [ContentDescription]
<ImageView
~~~~~~~~~
Explanation for issues of type "ContentDescription":
Non-textual widgets like ImageViews and ImageButtons should use the
contentDescription attribute to specify a textual description of the widget
such that screen readers and other accessibility tools can adequately
describe the user interface.
Note that elements in application screens that are purely decorative and do
not provide any content or enable a user action should not have
accessibility content descriptions. In this case, set their descriptions to
@null. If your app's minSdkVersion is 16 or higher, you can instead set
these graphical elements' android:importantForAccessibility attributes to
no.
Note that for text fields, you should not set both the hint and the
contentDescription attributes since the hint will never be shown. Just set
the hint.
https://developer.android.com/guide/topics/ui/accessibility/apps#special-cases
5 errors, 20 warnings

After all the setup that i made before build the app to release for testing. I encountered a build issue.
Here's the message.

Please post the steps from react-native init
Are you unsing version 11 of mapbox libs?

Hi @mfazekas, I found a solution for this issue. Instead using the command given in the react-native documentation for building release apk.
I directly build it using gradlew command.
This the command i used.
./gradlew clean && ./gradlew app:build


How to allow text to be copied in a ui-sortable table?

I'm sorry if this has been addressed before, I couldn't find it.
I want to allow users to copy the text inside the rows of a ui-sortable table. In specific in this case, the pn-custom directive only contains a span with text. That is the text I want to allow to be copied.

             Column 1
             Column 2
             Column 3

             <pn-custom id="{{prwd.article_id}}"></pn-custom>
             {{prwd.label}}
             {{prwd.attribute}}

Of what I've read in the README file, I should use a cancel? Is this wrong? Is there any simple way to achieve this that I'm ignoring?
$scope.sortableOptions = {
  update: function(e, ui) {
    if (ui.item.sortable.span) {
      ui.item.sortable.cancel();
    }
  }
};

The reason why I post this here and not in SO is because if I think this is a simple use case, and if I can fix I would like to document it in the README.md file.

Does the directive handle the coping part or you just need to select the text?
I think that you might need to use a handle.
If you actually need to check the DOM element that was clicked, you can do something like  if ($(e.originalEvent.target).is('span')) { /*...*/ }.
But, since cancel() only reverts the sorting after the dragging, you might want to take a look at the cancel option as well.

Any feedback on this?

So sorry! I forgot to tell you, it was solved like this:

  $scope.sortableOptions = {
    cancel: 'pn-custom id, .input-sm'
  };

To me, it looks very clean and works very well:

The cursor changes when hovering on the text
The rest of the row executes the sortable function

WDYT?

Yea, that's exactly what I was thinking of.
👍 for making it work and 👍 for sharing back your findings.


fix: let useCurrentColor access token colors

Currently when working with icons inside components and using the getThemedIcon, you are unable to pass color tokens from tokens.color which have not been declared explicitly in createTheme({ ... }).
This PR adds a fallback to the useCurrentColor hook to also look for the color in tokens.color when returning the current color.

I also noticed we're not using color in useGetThemedIcon. Is that intended @natew ?

Great find!