[Feature Request] Month view

Hey,
First of all, thank you for the cool package!
For some of my documents I like to typeset calendars to give an overview over deadlines within a month or some weeks.
For my LaTeX documents I use the PGF/TikZ calendar library https://tikz.dev/library-calender.
Here is an example of what it looks like:

And the code I use for it:
\begin{tikzpicture}
    \calendar (mycal) [dates=2024-03-01 to 2024-03-30,week list,month label above centered,every month/.append style={yshift=-2mm}];
    \draw[green] (mycal-2024-03-01) circle (8pt);
    \draw[green] (mycal-2024-03-02) circle (8pt);
    \draw[green] (mycal-2024-03-08) circle (8pt);
    \draw[green] (mycal-2024-03-09) circle (8pt);
    \draw[black] (mycal-2024-03-15) circle (8pt);
    \draw[black] (mycal-2024-03-16) circle (8pt);
    \draw[red] (mycal-2024-03-22) circle (8pt);
\end{tikzpicture}

Would it be possible to add this view or add a command to create this overview?

I will consider this feature.
As for this specific requirement, I can just paste some code here to achieve this case a bit later.

Hi, the demo code is here.
#let get-month-range-by-date(date: datetime.today()) = {
  let year = date.year();
  let month = date.month();
  let last-day = 30
  if month in (1,3,5,7,8,10,12) {
    last-day = 31
  } else if month == 2 {
    last-day = 28
    if calc.round(calc.fraction(year / 4)) = 0.0 and calc.round(calc.fraction(year / 400)) != 0.0 {
      last-day = 29
    }
  }
  return (
    datetime(year: year, month: month, day: 1),
    datetime(year: year, month: month, day: last-day)
  )
}

#let calendar-month(
  event: (),
  date-range: ()
) = {
  let (date-from, date-to) = date-range
  let dates = range(date-from.day(), date-to.day() + 1).map(it => datetime(
    year: date-from.year(),
    month: date-from.month(),
    day: it
  ))
  let nweek = dates.map(it => it.weekday()).filter(it => it == 1).len()
  if date-from.weekday() > 1 {
    nweek = nweek + 1
  }
  let week-day-map = ()
  for (i, item) in dates.enumerate() {
    if i == 0 or item.weekday() == 1 {
      week-day-map.push(())
    }
    week-day-map.last().push(item)
  }
  stack(
    dir: ttb,
    grid(
      columns: (2em,) * 7,
      rows: (2em,) * (nweek + 1),
      // stroke: 1pt,
      align: center + horizon,
      grid.cell(colspan: 7)[March],
      [M], [T], [W], [T], [F], [S], [S],
      ..week-day-map.map(week => {
        (
          range(1, week.first().weekday()).map(it => []),
          week.map(day => {
            let day-str = day.display("[year]-[month]-[day]")
            if day-str in event.keys() {
              let params = event.at(day-str)
              let (shape, args) = params
              show: circle.with(..args)
              day.display("[day padding:none]")
            } else {
              day.display("[day padding:none]")
            }
          })
        ).join()
      }).flatten()
    )
  )
}

#calendar-month(
  event: (
    "2024-03-01": (circle, (stroke: green, inset: 2pt)),
    "2024-03-02": (circle, (stroke: green, inset: 2pt)),
    "2024-03-08": (circle, (stroke: green, inset: 2pt)),
    "2024-03-09": (circle, (stroke: green, inset: 2pt)),
    "2024-03-15": (circle, (stroke: black, inset: 2pt)),
    "2024-03-16": (circle, (stroke: black, inset: 2pt)),
    "2024-03-22": (circle, (stroke: red, inset: 2pt)),
  ),
  date-range: get-month-range-by-date(date: datetime(year: 2024, month: 3, day: 1))
)

And the output


block property with punctuation not work well

Block properties with punctuation do not move correctly

fixed in 1.3.0.


now() returns UTC, but if a variable is initialized with now(), it is set to local time.

Home Assistant release (hass --version): 0.35.3
Python release (python3 --version): 3.4.2
Component/platform: Rasberry Pi 2
Description of problem:
Value from now() gives UTC despite local time when compared
But if a variable is initialized from now(), conversion to local time takes place, and the correct local time is stored in that variable. Comparing that variable to another time then works as expected.
Expected:
Shouldn't local time should be returned directly from now()?
Problem-relevant configuration.yaml entries and steps to reproduce:
- platform: template
   sensors:
     car_heat_time:
       friendly_name: Time carheater
       value_template: '{{ "%0.02d:%0.02d" | format(states("input_slider.hours") | int, states("input_slider.minutes") | int) }}'
 - platform: template
   sensors:
     current_time:
       friendly_name: Current time
       value_template: '{{ "%0.02d:%0.02d" | format(now().strftime("%-H") | int, now().strftime("%-M") | int) }}'

#First method, bug?
#Trigger is triggered 1 hour too early, hence now() returns UTC time.
trigger:
  - platform: template
    value_template: '{{ (now().strftime("%s") | int | timestamp_custom("%H:%M")) == states.car_heat_time.state }}'

#Second method, works. Note that the value given to current_time has the same statement as the comparsion above
#Trigger is triggered correctly
trigger:
  - platform: template
    value_template: '{{ states.current_time.state == states.car_heat_time.state }}'

To be clear;
now() returns local time, utcnow() returns utc time.
timestamp_custom by default returns local time based on the timestamp passed in.
Could you write a test case for this that can be evaluated on the dev-template page built in to HASS?

'{{ (now().strftime("%s") | int | timestamp_custom("%H:%M %z%Z")) }}'
'{{ (now().strftime("%s") | int | timestamp_local()) }}'
'{{ (now().strftime("%Z") ) }}'

The above arguments did show respectively (current correct local time when testing this was about 13:25):
'14:25 +0100CET'
'2017-01-08 14:25:58'
'CET'
SSH into the server and typing the command:
date +'%T %z %Z'
did show:
12:26:02 +0000 UTC
A good reference of origin of my problem is at the end of this thread:
https://community.home-assistant.io/t/creating-a-alarm-clock/410/131
I've added some yaml configurations to look at in this thread.
Still I've not sat down and fully tried troubleshooting the problem, but it seems there is some problem with my setup, as the kind fellow 'daenny' seems not to have the same problem as I.

Just to be more detailed. It partially solved the problem with this post:
https://community.home-assistant.io/t/creating-a-alarm-clock/410/127
Where I'm stating that the value now() directly returns UTC time. But if I initialize a variable with now(), it will be initialized with the local time
I.e. this initializes the local variable current_time with local time correctly.
sensors:
     current_time:
       friendly_name: Current time
       value_template: '{{ "%0.02d:%0.02d" | format(now().strftime("%-H") | int, now().strftime("%-M") | int) }}'

But if I do this:
automation:
- alias: 'Bilvärme timer'
 trigger:
 platform: template
     value_template: '{{ (now().strftime("%s") | int | timestamp_custom("%H:%M")) == states.sensor.car_heat_time.state }}'

now() at the comparison line will return UTC time.

My state's last.changed give me times in UTC even if i have configured a timezone Europe/Oslo.
Is there a way to change this?

@roflmao state machine runs on UTC dates, if you want to convert it then you should use timestamp_local in your template.


Completing the examples

Examples are not exhaustives.
In README we see the configuration:
refresh_rate: 30 seconds
appenders:
  stdout:
    kind: console
  requests:
    kind: file
    path: "log/requests.log"
    encoder:
      pattern: "{d} - {m}{n}"
root:
  level: warn
  appenders:
    - stdout
loggers:
  app::backend::db:
    level: info
  app::requests:
    level: info
    appenders:
      - requests
    additive: false

But, how to use all loggers in a same application ? (here: app::backend::db and app::requests)

@corebreaker apologies for the delay. Could you restate the question? In the given configuration app::backend::db and app::requests are "being used" but only on those modules. For instance:
// app.rs
mod backend {
  mod db {
    fn foobar() {
      log::info("im logged to the root log since there is no appender listed under the app::backend::db logger");
    }
  }
}
mod requests {
  fn foobar() {
    log::info("im logged to the requests appender");
  }
}

If i understood, in the config file, the loggers section (the list of loggers) with the app:: prefix, define the scope where log macros log::* are used.
What are the rule of this scoping, does it work for sub modules: mod requests { mod dummy { log::info("yeah"); } }, or only for the exact module (requests, not requests::dummy) ?
II admit that it's not intuitive. Yes, i'd be appriciable if you'd be more explicit in the doc. Indeed, details are missing.

Hi @estk , thank you for the answer.
If i understood, in the config file, the loggers section (the list of loggers) with the app:: prefix, define the scope where log macros log::* are used.
What are the rule of this scoping, does it work for sub modules: mod requests { mod dummy { log::info("yeah"); } }, or only for the exact module (requests, not requests::dummy) ?
II admit that it's not intuitive. Yes, i'd be appriciable if you'd be more explicit in the doc. Indeed, details are missing.

@corebreaker your dummy example would match, ie it does not need to be exact. That is implied here and for sure could be stated more plainly.
Would you mind updating the doc with a more explicit explanation?

Ok, acter i analysed the code to extract the rules.

What about using just app:: like... the top level app?


Can't Archive Xcode project with Swift-NIO 2.20.0 dependency

Hi !
Since the release of the version 2.20.0 yesterday, I'm experiencing issues building one of my project that includes the Swift-NIO project as an SPM dependency.
When archiving I have this issue:
Integer literal '3735928559' overflows when stored into 'Int'

The Archiving task worked before with the 2.19.0 Swift-NIO version.
I'm having an issue with a project importing grpc-swift and Swift-NIO is a dependency of it so I can't explicitly tell SPM to fetch the 2.19.0 version.
Thank you in advance for those of you investigating this issue.
Expected behavior
The project is archived properly
Actual behavior
The project archiving task failed
Steps to reproduce
With Xcode 11.6

Create a single view iOS Application
Import Swift-NIO 2.20.0 through SPM

Product > Archive
You will have the Integer literal '3735928559' overflows when stored into 'Int' build error

SwiftNIO version/commit hash
2.20.0
Swift & OS version (output of swift --version && uname -a)
Apple Swift version 5.2.4 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>) Target: x86_64-apple-darwin19.5.0 Darwin mbp-de-franck 19.5.0 Darwin Kernel Version 19.5.0: Tue May 26 20:41:44 PDT 2020; root:xnu-6153.121.2~2/RELEASE_X86_64 x86_64

Thanks for reporting this, it should be fixed by #1604.

I'm having an issue with a project importing grpc-swift and Swift-NIO is a dependency of it so I can't explicitly tell SPM to fetch the 2.19.0 version.

Just a note on this: you can add SwiftNIO as a dependency directly to your package and require that the version is less than 2.20.0. As long as SwiftPM can find a version of SwiftNIO which satisfies your direct requirement and gRPC Swift's version requirement on SwiftNIO then it should be fine. Of course that's not the correct solution to this problem but it's worth noting as a temporary workaround.

@glbrntt Thanks you for the fix information.
And I'll definitely try you suggestion to workaround and explicitly set the version to 2.19.0 until fixed

I have just published swift-nio 2.20.1 which should solve this issue for you.


no-unused-variable rule should not be deprecated

Bug Report

TSLint version: 5.11.0
TypeScript version: 2.9.2
Running TSLint via: CLI

Actual behavior
"no-unused-variable is deprecated. Since TypeScript 2.9. Please use the built-in compiler checks instead."
Expected behavior
This rule should not be deprecated.
The TypeScript compiler check is not a replacement for a linter. The lint rule has benefits that cannot be provided by the compiler option:

Linter supports "fix" behavior.
Linter supports enabling/disabling the rule with file, block, or line granularity, while the compiler option applies to the entire project.

Here's a comment from a TypeScript developer that is applicable: https://github.com/Microsoft/TypeScript/issues/11051#issuecomment-248971532

Just for discoverability here the link to the pull request where this was deprecated: https://github.com/palantir/tslint/pull/3919

Linter supports "fix" behavior.

I think TypeScript should support this now as well in the form of "suggestions", but I tried to use them and failed (https://github.com/Microsoft/TypeScript/issues/13408#issuecomment-412438318). It would be nice to see a migration guide from the TSLint team which covers this, if they still want to deprecate this rule. (cc @JKillian )

Linter supports enabling/disabling the rule with file, block, or line granularity, while the compiler option applies to the entire project.

Valid point 👍

Another use-case for un-deprecating this..
I have a function that is called with 3 arguments, I need to declare the second one to get access to the third:
const fn = (first, unusedSecond, third) => {
  return `${first} ${third}`;
};

This occurs often in the React ecosystem, where side-effect middleware like redux-thunk and redux-observable can be configured with extra arguments:
const actionCreator = (dispatch, unusedGetState, extraArg) => { ... };

With the lint rule, we can specify a pattern matcher for ignoring unused variables:
"no-unused-variable": [
  true,
  { "ignore-pattern": "^unused" }
]

I am not aware of an approach that allows this using just the Typescript compiler.

Aside from the specific use case examples of how the compiler option cannot fully replace the linter rule, I really want to make sure that the opinion of the TypeScript team on matters like this is considered. Here's the relevant comment link again: https://github.com/Microsoft/TypeScript/issues/11051#issuecomment-248971532
Basically, some of the compiler options are things they made available just because it was so easy to do; not because it's really the compiler's job to check these things. They will never expand functionality of any of these compiler checks to support things like conditionally enabling/disabling a rule based on comments, configuration of patterns, etc.

The "fix" behaviour has become fundamental in our workflow. Enabling TS "noUnusedLocals" means we have to manually fix everything.
Please consider un-deprecating this rule

Another aspect is that the compiler option noUnusedLocals can be disabled in tsconfig.json that is used for running tslint. So maybe there is a way to check for this flag and only log a deprecation warning when it is enabled? (Which will of course not be true for older versions of typescript that tslint still supports looking at it's peer dependencies.)

Came across this today as well.  Would like to see this un-deprecated.  I prefer to catch these issues before I compile.

@iensu

If it's doable in eslint, shouldn't it be doable for tslint as well?

It is. I did this a while back: https://github.com/ajafff/tslint-consistent-codestyle/blob/master/docs/no-unused.md
Note that it won't check private properties and methods.
In older versions of TypeScript (<2.9) it was really difficult to correctly detect unused imports as they may be implicitly required by TypeScript's declaration emitter. That's why the rule has an option to ignore imports completely. This is no longer necessary in more recent versions of TypeScript.

@ajafff that worked like a charm, I'm going to addyour package to our dev deps. Thanks a lot!

I have similar but one more usecase, I'm linting my project on pre-commit hook, and testing and building on pre-push hook, I'd like to catch this one and fix it even before I commit, I don't want to see any additional commit, (unless user does a soft reset), but still, it's a waste of time, I can't do typescript build on commit hook because project is relatively large and it'll take time to compile :)

Another fun, contentious issue 😊.
The no-unused-variable rule as it is now is very difficult to maintain and can wreak havoc on other tools, as already noted in this thread. If TSLint core is to have a version of it, it should either...

...be something like ajafff's tslint-consistent-codestyle that does its own checking (what about privates?)
...still mirror TypeScript's diagnostics but not wreak havoc on other tools (how?)

If we would have access to the language service we could just use TypeScripts diagnostics instead of mirroring them, if I'm not mistaken? I don't know why, but it seems like access to the language service was removed in v5 (I once created an issue for this: https://github.com/palantir/tslint/issues/4232).

@DannyDelott,
You can use an underscore, and TypeScript will not complain:
const fn = (first, _second, third) => {
  return `${first} ${third}`;
};

@dolanmiu, (in reply to https://github.com/palantir/tslint/pull/3919#issuecomment-425995016)
You can use @ts-ignore:
// @ts-ignore
@HostBinding('class') private classes = 'my-theme';

Note: This will suppress all TypeScript errors on that line. See TypeScript issue: Support @ts-ignore for specific errors.

+1 me too
Example: I'm developing some feature. Comment line, watchers recompile and I see warnings.
I prefer this in the lint process.

Also the fix functionality is CLUTCH! Your guys have an awesome library, BTW!

tslint-etc handles this use case admirably.

tslint-etc handles this use case admirably for us.
The author is also very responsive to issues.

In my opinion no-unused-variable should be included in tslint recommended rules too, the fact that it is deprecated, then undeprecated, then now in v5.17 it says again it is deprecated, it is one of the reasons why I am considering take a look to another linter for TS.
At every developer out there: think twice about retrocompatibility, please do not remove things!

May The Slack be with you

Note: per #4534, this issue will be closed in less than a month if no PR is sent to add the rule. If you really need the rule, custom rules are always an option and can be maintained outside this repo!

Other than my pleaseCareAboutRetroCompatibilityRant tslint is a great piece of software and a must have in all my TypeScript projects.
For those who want a similar feature you can add this to your tsconfig.json
"noUnusedLocals": true,
"noUnusedParameters": true,

See, for instance, this tsconfig I am using: https://github.com/go-seven/go-seven.com/blob/master/tsconfig.json
I think it should be enabled in every TypeScript project even from the beginning prototyping phase.

@JoshuaKGoldberg thanks for reminder, sent a PR hopefully it's enough.
@fibo
I feel like you didn't read the whole thing, we want this because we want to test before we do a build, most of the people use precommit hooks for linting and prepush for build and test, if you can detect a problem before you commit, it's always better, you can still have your build detect that if that works better for you. On your project, wouldn't you be more glad if you could detect that before commit?

@cyberhck to be clear, what we're accepting are PRs to resolve the technical limitations that originally caused the rule to be deprecated in the first place.
tl;dr:

Everybody wants the rule to not be deprecated, maintainers included
There are technical blockers that need to be overcome to un-deprecate the rule
You can always fork TSLint and remove the deprecation warning in your fork

It's a little heartbreaking seeing everyone post how nice it would be to be able to use the rule. There's very little that can be done until the above blockers are either fixed or found to no longer be relevant. Per #4534 you should divert your energy towards the typescript-eslint project.
I'm going to mark supporting comments as off topic so folks are more likely to read this one.

@JoshuaKGoldberg Thanks for the tl;dr! Would it be possible to summarize/link to the technical blockers, and add them to your explanation?

💀 It's time! 💀
TSLint is being deprecated and no longer accepting pull requests for new rules. See #4534. 😱
If you'd like to see this rule implemented, you have two choices:

Recommended: Use typescript-eslint to lint your TypeScript code with ESLint ✅
Legacy: Write it as a custom TSLint rule 🤷♂

👋 It was a pleasure open sourcing with you!
If you believe this message was posted here in error, please comment so we can re-open the issue!

Linking here: https://github.com/palantir/tslint/issues/3671 looks like good supporting docs for why it was deprecated.

You could use tslint-consistent-codestyle no-unused rule instead

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


Move plugin settings from Other Settings to Version Controle section

Hi,
I think it makes more sense to have the .ignore settings in the "Version Controle" section - with others VCS settings - than in the "Other Settings" section. This would provide all parameters of the same type in the same place.
Sincerely,

Fix has ben released just right now with v1.1.2


Custom Google Drive App

G'day,
First, thanks for this amazing tool. It's really neat and intuitive.
My organization has very high confidentiality needs (notably for source protection) so we would like to use Draw.io with our own Google app ID. It a quick & dirty solution but I tried to change values in the minfied code:
sed -i 's/this.appId="420247213240"/this.appId="{{ google_app_id }}"/g' js/app.min.js
sed -i 's/this.clientId="420247213240-hnbju1pt13seqrc1hhd5htpotk4g9q7u.apps.googleusercontent.com"/this.clientId="{{ google_client_id }}"/g' js/app.min.js
sed -i 's/DriveClient.prototype.newAppHostname="www.draw.io"/DriveClient.prototype.newAppHostname="{{ google_app_hostname }}"/g' js/app.min.js

So now, when I click on the "Google Drive" connect button, it's simply redirect me to the hostname I set in ǹewAppHostname (it was previously "www.draw.io"). Any idea how I can do that correctly?
Best,
Pierre

BTW, I'm happy to suggest this as a pull request if you think it's a good solution:
https://github.com/ICIJ/drawio/commit/aad484d34015c56fd9d9508aba9bcfa497c21ee2#diff-49fc01f0eabbb4555eda11422824daacR294-R308

We're actually planning to create docker images with the various variables as environment variables. But pending that:
We'll add global vars to set the app and client ID. We had a PR to add a config.js file with global var overrides, I think that makes sense.
https://github.com/jgraph/drawio/blob/master/src/main/webapp/js/diagramly/DriveClient.js#L26
420... isn't actually the app you want to replace. 420 is the legacy app and when that mime is used, we do various things to translate the old format into the new and redirect the app, you don't want this.
I need to recreate the steps from scratch, if you can help me fill in https://gist.github.com/davidjgraph/9587fdcc44f5a9bc8cd4824d1ea68e3b I'll need to test a custom project to get you the exact process.
The Google UI has changed at the point I've gotten to:

Is it an OAuthClientID you picked?

A config file would be just perfect. Are you suggesting that I have to replace the appId<PHONE_NUMBER>32 instead?
I picked the OAuth client ID indeed. I didn't know what to choose as redirect URL on this screen:

Thanks for your precious help!

671, yes, but we need other changes, too. You don't need an authorized redirect.
What scopes did you enter for the OAuth constent screen? Was it held for manual approval or agreed straight-away?

I didn't change any of the default values:

You'll need auth/drive.file and auth/drive.install in the scopes, otherwise it won't work. Add those and see if it goes for manual review.

I got auth/drive/file but not auth/drive.install. Could it lives under another name?
Thanks!

You might have to manually enter it:
https://www.googleapis.com/auth/drive.file
https://www.googleapis.com/auth/drive.install

I added the scopes:

Yet it's still redirecting me to the site homepage when clicking on the Google Drive logo. No manual approval appears.

It won't work yet, this will not be a trivial process. Back to the OAuth Constent Screen, is "submit for verification" button active at the bottom of it? I'm not sure how you have this verified when the drive.file is present without a submission.

What does the verification status at the top of the page show?

Another question here is how are you adding security by creating another project ID? Is it that you think we have some kind of access to files stored with our app IDs? We cannot access them unless we could login as the actual user.

This button doesn't show since I'm not using one of the conditions (the application type is now "internal"):

To protect you and your users, your consent screen and application may need to be verified by Google. Verification is required if your app is marked as Public and at least one of the following is true:
Your app uses a sensitive and/or restricted scope
Your app displays an icon on its OAuth consent screen
Your app has a large number of authorized domains

You have made changes to a previously-verified OAuth consent screen

To answer your question, the documents we host on Google Drive are under a special protection due to the sensitivity of our work. This is mostly intended to protect our sources and therefore, press freedom. Unfortunately this extra-protection is not applied to documents shared with third parties (people or applications).

ok, how did you define it as internal?

At the top of the " OAuth consent screen" page:

OK, I didn't create the project using my GSuite account so I never got that option, good to know.

You understand that drive.file means the draw.io application can only access Google Drive files created by the app (with that app ID), or files a user specifically opens from drive.google.com using draw.io? So, your concern is about sensitive data in the diagrams?

To answer your question, the documents we host on Google Drive are under a special protection due to the sensitivity of our work. This is mostly intended to protect our sources and therefore, press freedom. Unfortunately this extra-protection is not applied to documents shared with third parties (people or applications).

Yes, I understand Draw.io won't be able to access our files except the one created with by the app. But if we do so those documents won't be protected as mentioned.

Yes, I think the issue here is one of the logistics of actually getting a custom hosted version to access files with our project ID, rather than the use of the draw.io project ID increasing the possible attack surface. I don't think creating a custom project actually makes it more secure, it's just you'd need to add your domain to our project and neither of us want to do that :).
I just wanted to work through the exact security implications.

Actually, it's not that bad. Replace:
	else if (this.ui.isDriveDomain())
	{
		this.appId = '98980727437';
		this.clientId = '98980727437-lr6plj68m1bgk3qhar12is01rumcohsb.apps.googleusercontent.com';
	}
	else
	{
		// Uses a different mime-type and realtime model than the drive domain
		// because realtime models for different app IDs are not compatible
		this.appId = '420247213240';
		this.clientId = '420247213240-hnbju1pt13seqrc1hhd5htpotk4g9q7u.apps.googleusercontent.com';
		this.mimeType = 'application/vnd.jgraph.mxfile.rtlegacy';
	}

with
	else
	{
		this.appId = 'YourAppId';
		this.clientId = 'YourClientId';
	}

And it works. Or override
App.prototype.isDriveDomain = function()
{
	return true;
//	return urlParams['drive'] != '0' &&
//		(window.location.hostname == 'test.draw.io' ||
//		window.location.hostname == 'cdn.draw.io' ||
//		window.location.hostname == 'www.draw.io' ||
//		window.location.hostname == 'drive.draw.io' ||
//		window.location.hostname == 'jgraph.github.io');
};

We'll add the config.js file for overrides, changing isDriveDomain is probably easier.

Fantastic, it worked!

We've added pre and post config files to 11.2.9, https://github.com/jgraph/drawio/tree/master/src/main/webapp/js
You can set:
window.DRAWIO_GOOGLE_VIEWER_APP_ID and
window.DRAWIO_GOOGLE_VIEWER_CLIENT_ID
in the pre config and get the same result now.

Brilliant! Will test soon, thanks!


[Backport 2.8 ] Update go to the latest version in system agent

Backport # https://github.com/rancher/rancher/issues/46526

PR is merged, now waiting for  new rancher image


feat(keys): support secp256r1

Motivation
This PR is to support secp256r1 curve for keys package
Solution
Add ImportPrivateKey, GenerateKeypair, Sign and Verify functions for secp256r1 by using golang ecdsa package

Thanks for putting this up, @LanfordCai! You'll need to sign your commits before I can merge this 😢

Hi, @patrick-ogrady , I have signed my commit :-)

Waiting for a review internally from some of our cryptography folks, then will merge (if no concerns)!

@LanfordCai we are hoping to approve this soon! Sorry for the delay here.

It requires all commits are signed, should I rebase and resign commits and force push to this branch?  @patrick-ogrady

@LanfordCai yes you should do that. I hope it doesn't wipe out the review history, I don't think it will. But let's see.

@itstehkman I have resigned commits and the review history is still there

🚀

🚀


Use semicolons ; instead of commas , as separator in simulation data files 🗄

Context for changes
Use semicolons as separators instead of commas when writing files. This prevents confusion between dictionary entries and actual column separators which started happening after #111.

Improvements:

Use semicolon as separator instead of comma to prevent confusion between column separators and dictionary item separators.

Example usage and tests

[x] Not Applicable

Performance results justifying changes

[x] Not Applicable

Workflow actions and tests

[x] Tests adjusted accordingly

Expected benefits and drawbacks
Expected benefits:

Data can easily be read from data files using e.g. Pandas

Possible drawbacks:

User should beware of change in data file structure and use sep=";"

Related Github issues

The current data storage format was introduced in #111

Checklist and integration statements

[ ] My Python and C++ codes follow this project's coding and commenting styles as indicated by existing files. Precisely, the changes conform to given black, docformatter and pylint configurations.
[ ] I have performed a self-review of these changes, checked my code (including for codefactor compliance), and corrected misspellings to the best of my capacity. I have synced this branch with others as required.
[ ] I have added context for corresponding changes in documentation and README.md as needed.
[ ] I have added new workflow CI tests for corresponding changes, ensuring codecoverage is 95% or better, and these pass locally for me.
[ ] I have updated CHANGELOG.md following the template. I recognize that the developers may revisit CHANGELOG.md and the versioning, and create a Special Release including my changes.

Thanks, @soosub and @ilan-tz.
The problem with the above proposal is Windows applications/users in certain regions will not be able to read such CSV files if we use semicolons. See for example here.
@soosub, what is the real inconvenience caused by using commas everywhere? maybe I can help to address or automate that. Alternatively, if we insist on using semicolons we must add sep=; on top of all CSV files.

Alternatively, if we insist on using semicolons we must add sep=; on top of all CSV files.

@nariman87 That sounds like the way to go! The problem is when you try to load data and the commas inside the dictionaries are recognized as column separators. If we use semicolons for column separators, data loading would be very easy, just pd.read_csv(...) plus possibly a l_eval transformation would suffice.

Alternatively, if we insist on using semicolons we must add sep=; on top of all CSV files.

@nariman87 That sounds like the way to go! The problem is when you try to load data and the commas inside the dictionaries are recognized as column separators. If we use semicolons for column separators, data loading would be very easy, just pd.read_csv(...) plus possibly a l_eval transformation would suffice.

Thanks Joost, before we go ahead this way, let's investigate this a bit more.
As you saw, I've added quotes around dics just to avoid this. Are we sure panda wouldn't read them properly even with double quotes around? Can you please add a minimal example here on how to reproduce panda problem?

While we wait for @soosub to give us an example of how to reproduce the panda read problem he was facing (and hopefully we can directly resolve it), these were two good suggestions from Ilan and Seb to avoid facing such problems entirely:

Writing dictionaries in a single field but in a new format not using commas as separators
Using JSON data types for which panda works much nicer.

@nariman87, problem resolved. I noticed the issue when working with data produced with FT#116 and wrongfully assumed it was an issue from #111. I just checked and wrapping dictionaries with "double quotes" works perfectly fine, I'll make a comment on FT#116 👍🏼


Ensure correct systemd dependency is used

@fraenki since the systemd module is being maintained by camptocamp we have to update the dependency to avoid throwing errors / warnings during module installation / uprades through puppet module [...] due to the non existing puppet-systemd module.

@mat1010 Thanks! I could have sworn that the systemd module is maintained by voxpupuli – but I was wrong :D

I also thought that it had been migrated to voxpupuli at some point, like it was done with many other modules, but it seems like it was always maintained by camptocamp :-D thanks for the fast response.


Allow deletion of an Album

This will not delete an Artist if this is the only Album or contains the only Song(s) an Artist is associated with.

Fixed with 8ac0ef0


Error code -2: What does it mean?

Here is my console log in its entirety: [17:28:37.819] Assembly Generation Needed!
[17:28:37.819] Downloading Il2CppDumper
[17:28:37.822] C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\MelonLoader\Dependencies\AssemblyGenerator\Il2CppDumper already contains required version, skipping download
[17:28:37.829] Downloading Il2CppAssemblyUnhollower
[17:28:37.830] C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\MelonLoader\Dependencies\AssemblyGenerator\Il2CppAssemblyUnhollower already contains required version, skipping download
[17:28:37.830] Downloading Unity Dependencies
[17:28:37.831] C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\MelonLoader\Dependencies\AssemblyGenerator\UnityDependencies already contains required version, skipping download
[17:28:37.837] Executing Il2CppDumper...
[17:28:37.840] "C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\MelonLoader\Dependencies\AssemblyGenerator\Il2CppDumper\Il2CppDumper.exe" "C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\GameAssembly.dll" "C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\BloonsTD6_Data\il2cpp_data\Metadata\global-metadata.dat"
[17:28:38.351] Initializing metadata...
[17:28:40.261] Metadata Version: 24.2
[17:28:40.261] Initializing il2cpp file...
[17:28:40.290] Il2Cpp Version: 24.2
[17:28:40.291] Searching...
[17:28:40.677] CodeRegistration : 181bcb288
[17:28:40.678] MetadataRegistration : 181bceda0
[17:28:40.732] System.OverflowException: Array dimensions exceeded supported range.
[17:28:40.733]    at Il2CppDumper.BinaryStream.ReadClassArray[T](Int64 count) in C:\projects\il2cppdumper\Il2CppDumper\IO\BinaryStream.cs:line 198
[17:28:40.733]    at Il2CppDumper.Il2Cpp.Init(UInt64 codeRegistration, UInt64 metadataRegistration) in C:\projects\il2cppdumper\Il2CppDumper\Il2Cpp\Il2Cpp.cs:line 100
[17:28:40.734]    at Il2CppDumper.Il2Cpp.AutoPlusInit(UInt64 codeRegistration, UInt64 metadataRegistration) in C:\projects\il2cppdumper\Il2CppDumper\Il2Cpp\Il2Cpp.cs:line 67
[17:28:40.734]    at Il2CppDumper.Program.Init(String il2cppPath, String metadataPath, Metadata& metadata, Il2Cpp& il2Cpp) in C:\projects\il2cppdumper\Il2CppDumper\Program.cs:line 190
[17:28:40.735] ERROR: An error occurred while processing.
[17:28:40.741] Executing Il2CppAssemblyUnhollower...
[17:28:40.742] "C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\MelonLoader\Dependencies\AssemblyGenerator\Il2CppAssemblyUnhollower\AssemblyUnhollower.exe" "--input=C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\MelonLoader\Dependencies\AssemblyGenerator\Il2CppDumper\DummyDll" "--output=C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\MelonLoader\Dependencies\AssemblyGenerator\Il2CppAssemblyUnhollower\Output" "--mscorlib=C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\MelonLoader\Managed\mscorlib.dll" "--unity=C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\MelonLoader\Dependencies\AssemblyGenerator\UnityDependencies" "--gameassembly=C:\Program Files (x86)\Steam\steamapps\common\BloonsTD6\GameAssembly.dll" "--blacklist-assembly=Mono.Security" "--blacklist-assembly=Newtonsoft.Json" "--blacklist-assembly=Valve.Newtonsoft.Json"
[17:28:40.966] Reading assemblies...
[17:28:41.147] Done in 00:00:00.1808469
[17:28:41.148] Computing renames...
[17:28:41.173] Done in 00:00:00.0259965
[17:28:41.173] Creating typedefs...
[17:28:41.174] Done in 00:00:00.0003356
[17:28:41.174] Computing struct blittability...
[17:28:41.174] Done in 00:00:00.0003754
[17:28:41.175] Filling typedefs...
[17:28:41.175] Done in 00:00:00.0008318
[17:28:41.176] Filling generic constraints...
[17:28:41.176] Done in 00:00:00.0008470
[17:28:41.177] Creating members...
[17:28:41.177] Done in 00:00:00.0002418
[17:28:41.178] Scanning method cross-references...
[17:28:41.228] Done in 00:00:00.0526549
[17:28:41.229] Finalizing method declarations...
[17:28:41.230] Done in 00:00:00.0022000
[17:28:41.231] 0 total potentially dead methods
[17:28:41.231] Filling method parameters...
[17:28:41.232] Done in 00:00:00.0009204
[17:28:41.233] Creating static constructors...
[17:28:41.235] Done in 00:00:00.0002998
[17:28:41.236] Creating value type fields...
[17:28:41.237] Done in 00:00:00.0021072
[17:28:41.238] Creating enums...
[17:28:41.239] Done in 00:00:00.0012893
[17:28:41.241] Creating IntPtr constructors...
[17:28:41.242] Done in 00:00:00.0056477
[17:28:41.246] Creating type getters...
[17:28:41.248] Done in 00:00:00.0012695
[17:28:41.250] Creating non-blittable struct constructors...
[17:28:41.251] Done in 00:00:00.0010999
[17:28:41.252] Creating generic method static constructors...
[17:28:41.253] Done in 00:00:00.0023235
[17:28:41.254] Creating field accessors...
[17:28:41.255] Done in 00:00:00.0010022
[17:28:41.256] Filling methods...
[17:28:41.257] Done in 00:00:00.0042209
[17:28:41.258] Generating implicit conversions...
[17:28:44.210] Done in 00:00:02.9589878
[17:28:44.215] Failed to Execute Il2CppAssemblyUnhollower!
[17:28:44.229] [Error] Assembly Generator exited with code -2

Hello
Please keep the MelonWiki issues related to the MelonWiki itself.
To get some help about BTD6 modding, please either use the MelonLoader Discord, or the BTD6 Modding Discord.


FCS_CKM.5 app note edit

The first paragraph of the app note in the catalog is really intended for people using the catalog, not for inclusion in the cPP.

@woodbe, there has been a notion that we would provide commentary/guidance on how to use the catalog.  The is a long-time goal especially of @jdonndelinger.  I think some of the commentary/guidance wound up as app notes.  I would defer to @jdonndelinger on how to best separate legitimate app notes from commentary/guidance.

I agree, we need to do a check on things that should be removed, I noticed this particular one as obvious.
Maybe in the catalog you move those things out of app notes and into something above the requirements (or below but noted as "PP/ST author notes"

Yes, some were moved to introductions.  There are also sections labeled "Guidance" under FCS_CKM.2 and FCS_COP.1/Hash.  It seems inconsistent to provide some guidance in the introductions, and then more under these labels.  Feel free to remove "guidance" from the app notes.  We will clean up the catalog later.


Fix to retrieving settings for record data

Merged, but please remember to update readme.md in the future. Thanks @BrianFarnhill


Better support for Go modules

GOPATH has no meaning with Go modules, but the code looks for a bunch of things there. Instead use current directory to find the root of the Istio repo (which we can assuming the code is run with go test).
Remove some unused vars, since it wasn't obvious what they were supposed to mean with modules
Fail hard on non-existent directories, debugging failures like <" " does not exist> is not a good use of someone's time
When running outside GOPATH, use bin and out dirs within the repo so that multiple checkouts of Istio don't collide with each other
Do not silence unexpected errors in CheckFileExists, a failure to stat a file does not mean it exists..

This does not make things just work (TM) yet, a module based checkout has to run make init and then symlink bin and out directories for new integration tests to succeed. We need to fix Makefile(s) separately for that, if nothing else.
In particular, when running integration tests (go test ./tests/integration/...), code looks for YAML files under $GOPATH/src/istio.io/istio (which may not exist, be broken or out of sync) and some binaries under $GOPATH/out (which seems to be Istio invention so shouldn't be there, and either way it's not per-module so chances of conflict arise if one has multiple Istio checkouts). This PR fixes the former, and partially the latter: it looks in local module directory for bin and out directories, but out needs to be initialized with Makefile (because Envoy binary and maybe something else), and the Makefile change is not here (Go code will read <module_root>/out/ but Makefile will write to $GOPATH/out/, symlinking can make the two kinda work together for now).

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: qfel
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @qfel. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I've heard claims Go modules work with Istio. Last time I checked they did not - integration tests merrily failed. Do we care about that?

More details would be helpful. What are the failures you're seeing?

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: qfel
To complete the pull request process, please assign geeknoid
You can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

More details would be helpful. What are the failures you're seeing?

Updated the description

/ok-to-test

Pointer to https://github.com/istio/istio/issues/15093 as well. In that testing, I simply set GO111MODULE=on on the build image so we didn't need to move the code off the GOPATH.

@qfel: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-racetest-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-racetest-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/istio-lint.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-racetest-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/istio-lint.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-lint-master

prow/istio-unit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-racetest-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/istio-lint.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-lint-master

prow/istio-unit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-unit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-racetest-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/istio-lint.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-lint-master

prow/istio-unit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-unit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-racetest-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/istio-lint.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-lint-master

prow/istio-unit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-unit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-istioctl-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I've heard claims Go modules work with Istio. Last time I checked they did not - integration tests merrily failed. Do we care about that?

Ok, I misinterpreted your comment I think. It looks like you're asking whether we should go on with this PR, is that correct? if so, yes, I think we should do want this change. It changes things for the better.

/retest

The way it is certainly works for me, but there needs to be some higher-level decision on what to do with bin and out directories in the long term. Current behavior makes little sense for Go modules, but it's not like previous one did much either - we essentially assumed Isito is the most important package around and none other will get the idea to write under GOPATH, possibly messing with what Istio wrote there.
Limiting FS access to only the module directory feels more natural, but I don't understand all the dependencies and there's certainly a lot of scripts that fixate on GOPATH-based access. Going with this PR as is is one way, we can symlink $GOPATH/out to /out and have both new code and old scripts cooperate - but that makes sense only if we want to converge on local bin and out directories.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-racetest-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/integ-new-installer-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-racetest-master

prow/integ-new-installer-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/integ-security-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-telemetry-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/integ-security-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: qfel
To complete the pull request process, please assign costinm, ozevren
You can assign the PR to them by writing /assign @costinm @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS
pkg/OWNERS
pkg/bootstrap/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-telemetry-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/integ-security-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-new-install-k8s-presubmit-tests-master

e2e-bookInfoTests-trustdomain-master
8be1dfd5de3f6b736df75c384c97470ace421a8e
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-telemetry-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/integ-security-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-new-install-k8s-presubmit-tests-master

e2e-bookInfoTests-trustdomain-master
8be1dfd5de3f6b736df75c384c97470ace421a8e
link
/test e2e-bookInfoTests-trustdomain-master

integ-mixer-k8s-presubmit-tests-master
8be1dfd5de3f6b736df75c384c97470ace421a8e
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign @costinm @ozevren

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: qfel
To complete the pull request process, please assign costinm, ozevren
You can assign the PR to them by writing /assign @costinm @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/OWNERS
pkg/bootstrap/OWNERS
tests/integration/security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-telemetry-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/integ-security-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-new-install-k8s-presubmit-tests-master

integ-mixer-k8s-presubmit-tests-master
af824906f32a29283516b5f7461bc3ff594c0d92
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qfel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-telemetry-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/codecov.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test istio-codecov-master

prow/integ-security-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
69edc7248d6ae207a633931a196ceba20745e426
link
/test integ-new-install-k8s-presubmit-tests-master

integ-mixer-k8s-presubmit-tests-master
af824906f32a29283516b5f7461bc3ff594c0d92
link
/test integ-mixer-k8s-presubmit-tests-master

integ-security-k8s-presubmit-tests-master
af824906f32a29283516b5f7461bc3ff594c0d92
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This looks reasonable to me, although I agree with Costin that we should avoid writing to the source directory.

/retest

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn, qfel
To complete the pull request process, please assign costinm, ozevren
You can assign the PR to them by writing /assign @costinm @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/OWNERS
pkg/bootstrap/OWNERS
tests/integration/security/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Are you able to update the go:generate directives too? e.g. https://github.com/istio/istio/blob/master/mixer/adapter/bypass/bypass.go#L16

@istio/wg-security-maintainers ptal
/test e2e-simpleTestMinProfile-master

/test e2e-simpleTestsMinProfile-master

@istio/wg-security-maintainers ptal


[Node.js]When client connect to server,but server not yet ready,client will crash.

I use Node.js
When client connect to server,but server not yet ready,client will crash.
[My Enviroment]
OS : Linux Ubuntu 14.04
uname -r : 3.19.0-73-generic
uname -m : x86_64
node version : v4.6.1
uws version : 0.14.1
[Test code]
var WebSocket = require('uws');
var ws = new WebSocket('ws://<IP_ADDRESS>:3000');
ws.on('open', function () {
console.log('Connected!');
});
ws.on('error', function (err) {
console.log(err);
});
[Result]
$ node client.js
{ message: 'uWs client connection error',
stack: 'uWs client connection error' }
node: ../deps/uv/src/unix/core.c:168: uv_close: Assertion `0' failed.
(core dumped)

The same on node v7.8.0, but sometimes it segfaults:
segmentation fault  node test.js

and sometimes it produces:
error { message: 'uWs client connection error',
  stack: 'uWs client connection error' }
node: /tmp/portage/dev-libs/libuv-1.11.0/work/libuv-1.11.0/src/unix/core.c:101: uv_close: Assertion `!uv__is_closing(handle)' failed.

I am having the same issue with Node.js, segmentation fault is thrown while connection fails on error (e.g. server not ready).
var WebSocket = require('uws');

function connect () {
    let promise = new Promise(function (resolve, reject) {
        var ws = new WebSocket('wss://<IP_ADDRESS>:9002');
        ws.on('error', function error() {
            console.log('Error connecting!');
            setTimeout(function () {
                reject(false);
            }, 1000);
        });
    });
    return promise;
}

async function start() {
    try {
        await connect();
    } catch(error) {
        console.log(error);
    }
}

start();

Process will crash within 10 seconds, there can be multiple retries before the crash but eventually the client will segfault, causing process to crash, catching by different methods would show

Assertion !(((handle)->flags & (UV_CLOSING | UV_CLOSED)) != 0)' failed node: ../deps/uv/src/unix/core.c:166: uv_close: Assertion 0' failed. Aborted (core dumped)
Segmentation fault (core dumped)

Seems to be a libuv problem, https://github.com/joyent/libuv/issues/949.

UPDATE: Reverted back to<EMAIL_ADDRESS>since I had a local compiled package at this version (npm does not have old versions anymore, only 0.14.1 is available). The same piece of code would not segfault and exit as soon as error is printed, while in 0.14.1 the code would hang until segfault.
I have written test code that has a simple retry logic, in 0.14.1 this would segfault after a few retries, while in 0.13.0 will keep retrying.
var WebSocket = require('uws');

function connect () {
    let promise = new Promise(function (resolve, reject) {
        var ws = new WebSocket('wss://<IP_ADDRESS>:9002');
        ws.on('error', function error() {
            console.log('Error connecting!');
            setTimeout(function () {
                reject(false);
            }, 1000);
        });
    });
    return promise;
}

async function start() {
setInterval(async function(){
try {
await connect();
} catch(error) {
console.log(error);
}
}, 1000);
}
start();

Very nice report, I can trigger it and I can also trigger it without Node.js. It seems like a major flaw for connection errors, it seems sockets are not really closed at all in that case leaving them still in the loop while having no memory which is very broken. Will fix in next patch release.


this.add.curve generates following error: Uncaught TypeError: this.getPoint is not a function

Version

Phaser Version:
Phaser v3.24.1

Operating system:
windows 10 pro 10.0.19041 Build 19041

Browser:
Microsoft edge Version 84.0.522.52 (Official build) (64-bit)

Description

I don't think this issue is device specific, this issue seems like it's something internal to the library.
of course it could also be a problem with my own code.
When I run the following line:
this.add.curve(1400, 1400, new Phaser.Curves.Curve("some curve type"), 0xff0000);

I receive the following error:

Example Test Code
GameScene.js file:
import Phaser from 'phaser';
import OutlineEffectLayer from 'phaser3-rex-plugins/plugins/outlineeffectlayer.js';
import BuildArcadeObject from 'phaser3-rex-plugins/plugins/buildarcadeobject.js';
import CircleMaskImage from 'phaser3-rex-plugins/plugins/circlemaskimage.js';

export default class GameScene extends Phaser.Scene {
  constructor() {
    super('main');

    this.player = undefined;
    this.cursors = undefined;

    this.gameWidth = process.env.gameWidth + process.env.displayWidth;
    this.gameHeight = process.env.gameHeight + process.env.displayHeight;
  }

  preload() {
    this.load.image('pfp', 'some external image url that has a size of (160 x 160) pixels');
  }

  create() {
    this.add.curve(1400, 1400, new Phaser.Curves.Curve("some curve type"), 0xff0000); // It's here where the error appears!
    this.createCamera();
    this.createWorld();
    this.player = this.createPlayer();
  }

  createCamera() {
    // Apply camera view boundaries
    this.cameras.main.setBounds(0, 0, this.gameWidth, this.gameHeight);

    // Have to follow game objects like this, because following game objects with an applied outline effect like this:
    // this.cameras.main.startFollow(this.player); will not work. But it will work without the applied outline effect.
    // For reference: https://github.com/rexrainbow/phaser3-rex-notes/issues/116
    this.game.events.on('prerender', function () {
      if (this.player) this.cameras.main.centerOn(this.player.x, this.player.y);
    }, this);
  }

  createWorld() {
    // Create gradient background
    const graphics = this.add.graphics();
    graphics.fillGradientStyle(0x0479c3, 0x0479c3, 0x00e0ff, 0x00e0ff);
    graphics.fillRect(0, 0, this.gameWidth, this.gameHeight);

    // Create grid background
    const grid = this.add.grid(0, 0, this.gameWidth, this.gameHeight, 64, 64, null, null, 0xA0A0A0);
    grid.setOrigin(0);

    // Apply physics boundaries
    this.physics.world.setBounds(process.env.displayWidth / 2, process.env.displayHeight / 2, process.env.gameWidth, process.env.gameHeight);
  }

  createPlayer() {
    // Create a circle mask over the image, and center the image/player on the game baord
    const image = new CircleMaskImage(this, this.gameWidth / 2, this.gameHeight / 2, 'pfp');
    this.add.existing(image);
    // Make it half the size so it's the same size as the profile picture (80 px)
    image.setScale(0.5);

    // Create an outline effect around the circle image
    const effectLayer = new OutlineEffectLayer(this, {thickness: 8, outlineColor: 0x33FF48});
    this.add.existing(effectLayer);
    effectLayer.add(image);

    // Make the circle image physical xD
    const player = BuildArcadeObject(image);
    player.setCircle(96, -16, -16);
    player.setCollideWorldBounds(true);

    // Create the cursor keys which the player will use
    this.cursors = this.input.keyboard.createCursorKeys();

    return player;
  }

  update() {
    if (this.cursors.left.isDown) this.player.setVelocityX(-500);
    else if (this.cursors.right.isDown) this.player.setVelocityX(500);
    else this.player.setVelocityX(0);

    if (this.cursors.down.isDown) this.player.setVelocityY(500);
    else if (this.cursors.up.isDown) this.player.setVelocityY(-500);
    else this.player.setVelocityY(0);
  }

}

This is my initialization code:
import Phaser from 'phaser';
import GameScene from './scenes/GameScene';

const initializeGameInstance = (initialWidth, initialHeight) => (
  new Phaser.Game({
    type: Phaser.AUTO,
    width: initialWidth,
    height: initialHeight,
    parent: 'phaser-container',
    scale: {
      // Could've used FIT but this seems to work better, because it takes the following user action into account:
      // Resize very fast
      mode: Phaser.Scale.WIDTH_CONTROLS_HEIGHT
    },
    physics: {
      default: 'arcade',
      arcade: {
        debug: true
      }
    },
    scene: [GameScene]
  })
);

export const prepareFullscreen = game => {
  // This is to make sure that phaser doesn't scale the canvas automatically
  game.scale.scaleMode = Phaser.Scale.NONE;

  // Remove all the applied inline styling on the canvas element
  game.canvas.removeAttribute("style");

  // Refresh so the disabled scaling takes affect
  game.scale.refresh();
};

export const cleanUpFullscreen = game => {
  // This is to make sure phaser falls back to the first setting to automatically scale the canvas
  game.scale.scaleMode = Phaser.Scale.WIDTH_CONTROLS_HEIGHT;

  // Refresh so the enabled scaling takes affect
  game.scale.refresh();
};

export default initializeGameInstance;

I think I'm just dumb, had to use a more specific instance of type Phaser.Curves.Curve. I'm now using Phaser.Curves.CubicBezier instead and that works!


allow adding docker Private registry details while deploying cluster

Addresses the following:

Allows users to add private registry - if experimental features flag is enabled
Sets min number of master nodes to 2 if HA is enabled

Added the Private registry flag:

For HA, made the default value of number of master nodes to 2:
Default initial value:

Setting it to a value lesser than 2 (which ideally isn't HA), will prompt the user:

Fixes https://github.com/apache/cloudstack-primate/issues/801

@blueorangutan package

@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/802 (JID-3580)

@blueorangutan package

@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/802 (JID-3582)

@blueorangutan package

@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/802 (JID-3587)


Make AutoScheduler handling of errors during measure consistent with AutoTvm

While running scripts using both AutoScheduler and AutoTvm to consecutively search for schedules for a number of operators/shapes, I observed different behaviors during measurement following the output “Too many errors happened during tuning.”
After looking into the code I determined that the difference in behavior was due to AutoScheduler and AutoTvm handling the case of, the number of accumulated errors during measurement exceeding some threshold, differently.
I observed that while using AutoTvm, the program would switch to debug level logging and continue search.
Too many errors happen in the tuning. Now is in debug mode
No: 217	GFLOPS: 0.00/0.00	result: MeasureResult(costs=(RuntimeError('Traceback (most recent call last):\n  [bt] (5) /home/tanvir/tvm/build/libtvm.so(TVMFuncCall+0x63) [0x7fd9b685ee13]\n  [bt] (4) /home/tanvir/tvm/build/libtvm.so(+0x1309037) [0x7fd9b68c8037]\n  [bt] (3) /home/tanvir/tvm/build/libtvm.so(tvm::runtime::RPCWrappedFunc::operator()(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*) const+0x3fa) [0x7fd9b68cc86a]\n  [bt] (2) /home/tanvir/tvm/build/libtvm.so(tvm::runtime::RPCClientSession::CallFunc(void*, TVMValue const*, int const*, int, std::function<void (tvm::runtime::TVMArgs)> const&)+0x57) [0x7fd9b68c0217]\n  [bt] (1) /home/tanvir/tvm/build/libtvm.so(tvm::runtime::RPCEndpoint::CallFunc(void*, TVMValue const*, int const*, int, std::function<void (tvm::runtime::TVMArgs)>)+0x6bd) [0x7fd9b68b546d]\n  [bt] (0) /home/tanvir/tvm/build/libtvm.so(+0x12f3668) [0x7fd9b68b2668]\n  File "/home/tanvir/tvm/src/runtime/rpc/rpc_endpoint.cc", line 807\nTVMError: Check failed: code == RPCCode: :kReturn: code=1'),), error_no=4, all_cost=10.765872716903687, timestamp=1604092331.4940712)	[('tile_f', [-1, 16]), ('tile_y', [-1, 2]), ('tile_x', [-1, 2]), ('tile_z', [-1, 16])],None,1719
…
<continues>

While using AutoScheduler, the program would crash after throwing an uncaught error.
Traceback (most recent call last):
  …
  File "runner.py", line 124, in fig_6
    m = run_operator(
  File "runner.py", line 58, in run_operator
    sch, args = auto_scheduler.auto_schedule(task, tuning_options=tune_option)
  File "/home/taylor/tvm/python/tvm/auto_scheduler/auto_schedule.py", line 213, in auto_schedule
    sch, tensors = _ffi_api.AutoSchedule(search_policy, tuning_options)
  File "/home/taylor/tvm/python/tvm/_ffi/_ctypes/packed_func.py", line 237, in __call__
    raise get_last_ffi_error()
tvm._ffi.base.TVMError: Traceback (most recent call last):
  [bt] (5) /home/taylor/tvm/build/libtvm.so(TVMFuncCall+0x63) [0x7f11e187d7b3]
  [bt] (4) /home/taylor/tvm/build/libtvm.so(+0x6965ab) [0x7f11e0c755ab]
  [bt] (3) /home/taylor/tvm/build/libtvm.so(tvm::auto_scheduler::AutoSchedule(tvm::auto_scheduler::SearchPolicy, tvm::auto_scheduler::TuningOptions)+0x11a) [0x7f11e0c74cca]
  [bt] (2) /home/taylor/tvm/build/libtvm.so(tvm::auto_scheduler::SketchPolicyNode::Search(int, int, int, tvm::auto_scheduler::ProgramMeasurer)+0x760) [0x7f11e0cfb3d0]
  [bt] (1) /home/taylor/tvm/build/libtvm.so(tvm::auto_scheduler::ProgramMeasurerNode::Measure(tvm::auto_scheduler::SearchTask const&, tvm::auto_scheduler::SearchPolicy const&, tvm::runtime::Array<tvm::auto_scheduler::MeasureInput, void> const&, tvm::runtime::Array<tvm::auto_scheduler::MeasureResult, void>*, int)+0x11ed) [0x7f11e0cd7b2d]
  [bt] (0) /home/taylor/tvm/build/libtvm.so(+0x6f4af8) [0x7f11e0cd3af8]
  File "/home/taylor/tvm/src/auto_scheduler/measure.cc", line 268
TVMError: Too many errors happened during tuning

In my particular case, AutoScheduler crashing rather than continuing to attempt searching meant that my script would terminate prematurely when it may have recovered from whatever was causing errors during search.
In addition, I was unclear why this behavior was only occurring in AutoScheduler and not AutoTvm. This discrepancy in behavior can be confusing to new users who may want to explore both methods of schedule searching. This PR proposes bringing the AutoScheduler handling of errors in measurement in line with AutoTvm.
By removing the LOG(FATAL) and changing verbosity for AutoScheduler in the same way we change logging level in AutoTvm the programs will behave the same. In addition, I changed the default verbosity of AutoScheduler to 0 (silent) in order to match the default logging level of AutoTvm.

@tqchen @merrymercy Thoughts and review please?

cc @jcf94 @merrymercy

Also, please rebase.

How do you hit this part of the code? Generally, it means you have some fatal errors in the code.
It is very rare to recover from a case where you have so many continuous errors.

I'm not entirely certain what causes us to hit this condition. In our case, we observed from the AutoTvm debug prints that it was due to error_no=4 which is a RUNTIME_DEVICE error (as you can see from the except of AutoTvm log I included previously). I think the main issue is that by terminating the program as soon as we meet this condition we dont allow for the chance to recover and additionally, we wont be getting this useful precise feedback about what error we are hitting while using the auto_scheduler.
Ill do the rebasing and try to fix the CI issue.

Thanks, @TaylorZowtuk. It is merged.


crypto/aes: expandKeyGo inconsistent with expandKeyAsm in endiannes

$ go version
go version go1.12 linux/amd64

What did you do?
0, given key:
var key = [32]byte{0x12, 0x34, 0x56, 0x78}

1, cpu does not support AES, select expandKey with BigEndian, enc[0] is 0x12345678
func expandKeyGo(key []byte, enc, dec []uint32) {
	// Encryption key setup.
	var i int
	nk := len(key) / 4
	for i = 0; i < nk; i++ {
		enc[i] = binary.BigEndian.Uint32(key[4*i:])
	}
...

2, cpu supports AES, use expandKeyAsm and movups, enc[0] is 0x78563412 on x86
// func expandKeyAsm(nr int, key *byte, enc, dec *uint32) {
// Note that round keys are stored in uint128 format, not uint32
TEXT ·expandKeyAsm(SB),NOSPLIT,$0
	MOVQ nr+0(FP), CX
	MOVQ key+8(FP), AX
	MOVQ enc+16(FP), BX
	MOVQ dec+24(FP), DX
	MOVUPS (AX), X0
	// enc
	MOVUPS X0, (BX)
	ADDQ $16, BX
	PXOR X4, X4 // _expand_key_* expect X4 to be zero
	CMPL CX, $12
	JE Lexp_enc196
	JB Lexp_enc128
Lexp_enc256:
...

What did you expect to see?
consistency
What did you see instead?
not consistency

Is this a user-visible problem or a code quality issue? If it's the former can you provide a repro that shows code breaking due to this behavior?
@FiloSottile

Sorry, i'm wrong.
All the operation is bitwise opration, shift or xor. So endian makes no sense here.
Please close.

Thanks for following up.


[Enhancement](partial update) Support including delete sign column in partial update stream load

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.04 seconds
stream load tsv:          516 seconds loaded<PHONE_NUMBER>9 Bytes, about 138 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size:<PHONE_NUMBER>4 Bytes


A single activity is instantiated multiple times - Back Stack

I couldn't find a relevant issue, so created new one. If you switch between home and nearby multiple times, you can see all instances of activities by pressing back button. We shouldn't let multiple instances of same activity.

This is because the finish() method is not being called upon the current activity which is leading to have it running in the background when we switch to a new activity. Fixed this is this PR https://github.com/commons-app/apps-android-commons/pull/949.
Please review and share any feedback.

@misaochan Can this issue be closed?

Yup, thanks all!


About rendering_with_merl.py

Hello,
When I run "python rendering_with_merl.py",the error occured as follow.

Traceback (most recent call last):
File "rendering_with_merl.py", line 163, in
for n_path in n_png_paths[[1, 7]]:  # This means blob02 and blob08
IndexError: index 1 is out of bounds for axis 1 with size 0

Can you solve it?Thank you.

Are you sure that Blobby dataset is extracted at the correct directory path?
n_png_paths is from glob.glob(params.BLOBS_PATH).
(params.BLOBS_PATH = "./blobs/blobs/data/blob*_n.png")

Hi,
When I run "python rendering_with_merl.py",the error occured as follow.
Traceback (most recent call last):
File "rendering_with_merl.py", line 18, in
from merl_brdf_database import merl_brdf
File "/home/jo/deep-photometric-stereo-network/merl_brdf_database/merl_brdf.py", line 9, in
import BRDFRead
ImportError: /home/jo/deep-photometric-stereo-network/merl_brdf_database/BRDFRead.so: undefined symbol: _ZN5boost5numpy5zerosERKNS_6python5tupleERKNS0_5dtypeE

Did you run make in ./merl_brdf_database?
My code uses BRDFRead.cpp via Boost Numpy to read BRDF data, and so you need to compile.

hi，i do not understand the training data‘s size；
if the number of light source is 96 and the number of training data is 3.9e7，
so does the size of training data is [96*3,3.9e7]?
and the size of training data is [3,3.9e7]?
could you please help me to understand this paper better？
Thank you.

Hello,
When I run "python rendering_with_merl.py",the error occured as follow.

Traceback (most recent call last):
File "rendering_with_merl.py", line 163, in
for n_path in n_png_paths[[1, 7]]:  # This means blob02 and blob08
IndexError: index 1 is out of bounds for axis 1 with size 0

Can you solve it?Thank you.

同学也是在研究光度立体吗？可以交流一下吗

Thank you for your reply！！
But maybe I do not explain my question clearly which makes you misunderstand....
My question is not about the number of training data  rather than  the Dimension of  training data.
I think the dimension of training data is [96x3,3.9e7]（96: #light sources，3：#RGB,  3.9e7=8 x 100 x 256 x 192.）
and output data is [3,3.9e7],(3:#nx,ny,nz);
Do I think about right？

I see. Sorry for my misunderstanding.
In teams of the dimensions of training data, you're right.

thanks very much！ best wishes  for you！！

        Thanks a lot！

        On 01/27/2019 01:23, Hiroaki Santo wrote: I guess your error is related to Boost::Python. I'm not sure but Linker can not find the libraries?

I think you need to correct the Cmakefile to suit your environment.
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/hiroaki-santo/deep-photometric-stereo-network","title":"hiroaki-santo/deep-photometric-stereo-network","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/hiroaki-santo/deep-photometric-stereo-network"}},"updates":{"snippets":[{"icon":"PERSON","message":"@hiroaki-santo in #2: I guess your error is related to Boost::Python. I'm not sure but Linker can not find the libraries?\r\nI think you need to correct the Cmakefile to suit your environment. "}],"action":{"name":"View Issue","url":"https://github.com/hiroaki-santo/deep-photometric-stereo-network/issues/2#issuecomment-457848774"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/hiroaki-santo/deep-photometric-stereo-network/issues/2#issuecomment-457848774",
"url": "https://github.com/hiroaki-santo/deep-photometric-stereo-network/issues/2#issuecomment-457848774",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]


{AKS} Remove snapshot name trimming in 'az aks snapshot create' command

Remove snapshot name trimming in 'az aks snapshot create' command
This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

AKS


Added "Hover light radius" to StandardShaderGUI.cs

This is for the editor to reflect the addition of the _HoverLightRadius-propertyI added to the Standard.shader.
[edit] Sorry for screwing up and doing two file commits for something that belongs together. This version control thing isn't as straight forward and forgiving as I had hoped...
Overview
This is a slider field from 0.01 to 10 based on float for the radius of the hover light here: #2914
Changes

Added slider field to fluent-part of the menu.

re-targeted this change to htk_development (code does not go directly into master)… thx

Blocked, awaiting https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/2914

@Cameron-Micka @quakeulf please reopen this pull request if there is still interest in integrating this change into the MRTK.


Improve a vp-tree pivot-selection procedure (for low-dimensional spaces).

While in higher-dimensional spaces (e.g., SIFT) with narrow histograms of distances (between random pairs of points), random pivots may be almost as good as any other pivots, this is not the case of lower dimensional spaces, or high-dimensional spaces with very low intrinsic dimensionality. A user should be able to specify an option for a better pivot-selection. In particular, trying several pivots and choosing one with the highest distance spread should help in many cases.

Sometimes, we can get up to 1.5x reduction in retrieval time.


Define a run command on simulation / models

In GitLab by @Huite on Nov 5, 2021, 13:53
def run(mf6path=None):
    # if None, assume it's e.g. available in conda

In GitLab by @Huite on Dec 20, 2021, 15:41
02331ce7df16753fc458a4436366d29a05661687


Issue: 3519 Edit text in Inventory transfer screen to Items in this transfer

Resolves #001
Description
Completed text edit in the Inventory transfer page. Edited text to display "Items in this transfer"
List any dependencies that are required for this change. (gems, js libraries, etc.)
Include anything else we should know about. -->
Type of change
Text edit
How Has This Been Tested?

Nice, thanks!

@jadekstewart3  Just to let you know -- this has been released.  Thank you!


Add Plug to Portuguese(Brazil)

cc @psantos10  @brunoasantos  If you guys have time, please review :D

Fixed @psantos10 can I merge?

ping @psantos10

Fixed @philss

Fixed @philss can I merge?

:shipit:

Thanks @philss o/

@pragmaticivan you're welcome! o/


Removed the problem causing png module

Removed the module which was causing problem, should be compiling now.


Adding support for correctly timed audio based on distance to listener.

This PR attempts to add functionality, to determine the time a sound needs from the origin to the listener and delay the playback based on this delta.
Features

[ ] Scale setting
[ ] Update thread
[ ] Delaying playback

I'm closing this due to inactivity, feel free to reopen if you're still interested.


Protocol & Architecture Specifications

Description
Complete FPC protocol and high-level overall architecture specification for MVP / RFC

[ ] Determine what diagrams are necessary (see also issue #356)
[ ] Finish registration flow (PR #333)
[x] Finish lifecycle flow (PR #353 PR #374 )
[ ] cleanup/validate key-dist flows (see, e.g., issue #303)
[ ] cleanup/validate execution flows (see, e.g., issue #303 and #361)

Protocol must cover everything from MVP milestone but should also cover what we already have discussed as limitations and way to go forward at least as comments so prior discussions/insights is not lost)
See for more long-term work-items Protocol & Architecture Specifications Milestone

Regarding the step Determine what diagrams are necessary
Jeb's recent update on the RFC added diagrams to the RFC.
In contains a component diagram and a series of diagrams to the describe the transaction flow. I think we should keep the component diagram and reduce the number of flow diagrams where we can.
See https://github.com/mbrandenburger/fabric-rfcs/blob/31e9afa647271dd31fdc216c4a9340fb37759629/text/0000-fabric-private-chaincode.md
Additionally, we should add a simplified version of the creation/registration and how FPC chaincode interacts with the Ledger enclave to validate input (similar to Figure 4 in the paper https://arxiv.org/pdf/1805.08541.pdf).
WDYT? @bvavala @g2flyer @jrlinton

I think there are two separate questions:

what do we need for the high-level description for the RFC
what do we need for the detail design/protocol (i.e. UML diagrams)

For 2. i guess it is essentially what we already have

fpc-lifecycle-v2.puml
fpc-registration.puml
fpc-key-dist.puml
fpc-cc-invocation.puml
fpc-cc-execution.puml
fpc-validation.puml
fpc-components.puml
(and potentially fpc-integration-touchpoints.puml as overview, maybe with cross references to the other diagrams?)

For 1., afaict, the anoted diagrams are exactly the ones we used in some talks. Given that we had some reason to highlight these steps then, it seems like a reasonable approach just to inline them the way Jeb has done. I have no strong opinion. I certainly do not see a real problem having all of them, in particular given that we do have them already and don't have to generate them first.
That said, we definitely should make sure that we also keep the source of the png version controlled and not only the png so we can easily apply any changes later (e.g., if we want to reconcile naming conventions with what we discussed this morning ...)

I think

the diagrams add clarity, particularly for first-time readers;
also we should not inline the UML diagrams, and rather provide them on request (or at most have a reference to them)
also, and most importantly, we need more input

the diagrams add clarity, particularly for first-time readers;
also we should not inline the UML diagrams, and rather provide them on request (or at most have a reference to them)
also, and most importantly, we need more input

Just to make sure: with "more input" i guess you mean external input from RFC reviewers/fabric maintainers? If so i definitely agree (as i do with your first two points which seem consistent with my comments above?)


Add init attributes in constructor and sync tracing to work with new …

Which problem is this PR solving?
This PR fixes issue #4188 in which the span processor on start method lacks attributes since they are set after with an accessor method (setAttributes) and not on the constructor itself.
Short description of the changes
The PR adds constructor attributes to the span which are optional and if they are added from this layer the spanProcessor.onStart method will have context of attributes whenever it is called, this doest not break compatibility since setAttributes is still a valid public method and also the changes needed on wrappers like the Tracer are done.
Spans have added tests on all constructor tests I could find, the current tests should validate tracer functionality correctly.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] United tested over the build

Checklist:

[x] Followed the style guidelines of this project
[x] Unit tests have been added
[ ] Documentation has been updated

This bug fix should not be noticable since the wrapper tracer call for starting a span should not change functionality (it is only the internal span constructor changing), would like input if I have to change the documentation for the Span constructor itself considering it is @deprecated.

Pinging @dyladan and @mayurkale22 in an attempt to make this PR gain some traction.
The current implementation makes it impossible to make transformations in onStart of processors that need to access the initial attributes of a span. This pull-request makes it possible.

Your tests seem to verify only the Span constructor but not that you really see the attributes in SpanProcessor#onStart() which is the main intend here to my understanding.
Maybe add such a test or convert one of the new test?

I took the liberty to follow up on this PR at https://github.com/open-telemetry/opentelemetry-js/pull/4277 since I have urgency to have this fixed upstream.
@Flarna could you take a look at it?


Refactor feed back3.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

337 of 348 (96.84%)  changed or added relevant lines in 20 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+11.6%) to 98.571%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repository/IngSoft2-Model/CardApplicator.class.st
99
103
96.12%

repository/IngSoft2-Model/Sequence.class.st
23
30
76.67%

Files with Coverage Reduction
New Missed Lines
%

repository/IngSoft2-Model/Sequence.class.st
1
76.47%

Totals

Change from base Build<PHONE_NUMBER>:
11.6%

Covered Lines:
828

Relevant Lines:
840

💛  - Coveralls


Receipt design section

This is an effort to merge the changes from PR: #11048
Changes related to receipt. I'm intentionally not deleting old receipt files to keep them around until we make sure we have all the design parts, so I had to make changes to ExtractedReceipt so the build wouldn't break.
I also disabled the related tests as currently receipt is broken. I am not fixing it yet because we need to update swagger first which deletes/adds functionality we need to make this all work again.
Update swagger is part of the work in issue https://github.com/Azure/azure-sdk-for-net/issues/11231

Caio may know of a way to disable tests without commenting them out.

@annelo-msft  They don't build as they are calling functions that don't exist anymore or the parameters changed. If you want, I could make changes to the tests so that they build and then I can set an Ignore property on them so the tests don't run.


Document APEL accounting for HTCondor-CE

Summary

This PR adds a new section into "Providers" / "High Throughput Compute" on "APEL Accounting for HTCondor-CE".

Related issue :
Closes #545.

Thanks for the the first look and fixing the link. I've checked the preview, everything looks as intended; ready for review.


Added reserve logic to Dependency Table and combine all dependency into one file

Change Summary
Overview

added reserve logics and combined all dependency into one file
add IMAP-Hi dependency
update sds-data-access version

I am still not following why inter-instrument dependencies would be different and not reversed?
@greglucas yeah, you may be right. I may be thinking about case of HARD and SOFT relationship. Because some instrument doesn't required some instrument data to kickoff their processing. It's nice to have. In that case, we could still have upstream and downstream relationship reversed but the relationship will determine if something should be kicked off or not.


Make dart2js unit tests work with package spec

We are getting rid of the package root, and replacing it with .packages (a "package spec") at the root of the checkout, not passed explicitly.
So a lot of unit tests failed when I ran commit https://github.com/dart-lang/sdk/commit/5d3e356ca75be8aeff3efde5df946d746b9f8352
on the buildbot.

This is fixed now


Parallelization

Using joblib.

Thank you for your contribution! I'll check this PR later.
(This PR is related to #5 )

thank you.
please try pull the master to refresh the CI.


Switch arsenic to an openff namespace package

Description
This PR changes arsenic to a package within the openff namespace. Effectively, this means imports of the package occur as from openff.arsenic import ....
Status

[ ] Ready to go

@mikemhenry, can you review and merge when satisfied?