Join Allow header values with comma and space (according with RFC 7231)

In most web-servers and http-clients implementations header values joined with comma and space.
I am fix it for Allow header in 2 places.

Just for reference: Actual grammar: Allow = [ ( "," / method ) *( OWS "," [ OWS method ] ) ] in https://tools.ietf.org/html/rfc7231#appendix-D
From https://tools.ietf.org/html/rfc7230#section-3.2.3:

The OWS rule is used where zero or more linear whitespace octets
might appear.  For protocol elements where optional whitespace is
preferred to improve readability, a sender SHOULD generate the
optional whitespace as a single SP; otherwise, a sender SHOULD NOT
generate optional whitespace except as needed to white out invalid or
unwanted protocol elements during in-place message filtering.

Thanks!


Start adding a "tag" package.

This PR starts adding tagging as a separate feature.  There are two commits:
Move StringUtil to an "internal" package.
This will allow the class to be used by multiple packages.
Start adding a "tag" package.
This commit adds TagKey, TagValue, and TagSet to the new package. It does not
modify any classes in "stats", for backwards compatibility.  TagKey and TagValue
are the same as the corresponding classes in "stats", except that they use the
toString() methods generated by AutoValue.  TagSet is like StatsContext, except
that it uses AutoValue and doesn't contain any methods for recording stats or
serializing/deserializing.
/cc @songy23 @dinooliva @a-veitch

Codecov Report

Merging #219 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #219      +/-   ##
===========================================
+ Coverage     94.82%   94.9%   +0.08%
- Complexity      421     433      +12
===========================================
  Files            57      60       +3
  Lines          1294    1315      +21
  Branches         91      91
===========================================
+ Hits           1227    1248      +21
  Misses           41      41
  Partials         26      26

Impacted Files
Coverage Δ
Complexity Δ

...om/google/instrumentation/internal/StringUtil.java
93.75% <ø> (ø)
11 <0> (?)

...e/instrumentation/stats/MeasurementDescriptor.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

.../java/com/google/instrumentation/stats/TagKey.java
100% <ø> (ø)
3 <0> (ø)
:arrow_down:

...ava/com/google/instrumentation/stats/TagValue.java
100% <ø> (ø)
3 <0> (ø)
:arrow_down:

...in/java/com/google/instrumentation/tag/TagSet.java
100% <100%> (ø)
8 <8> (?)

...in/java/com/google/instrumentation/tag/TagKey.java
100% <100%> (ø)
2 <2> (?)

.../java/com/google/instrumentation/tag/TagValue.java
100% <100%> (ø)
2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1c4fc...6a7fcbe. Read the comment docs.


Application Became Active event on RN should have been Application Opened with from_background=true property

Description

Code
Docs

RN has a specific event called Application Became Active when the app is active which means the app is back in the foreground.
On the other Mobile SDKs, we just capture the Application Opened event with the from_background=true property instead.
Ideally, we'd align this behavior in one way or the other.
When mobile dashboard templates are shipped, templates should have a single source of truth for events and properties.

I think at the time there was a back and forth with customers and we agreed having a dedicated name was better (with a view to eventually moving the iOS and Android over with a breaking major version change). But that was a long time ago so my memory may be hazy

Yeah, I imagine filtering events/creating insights would be easier with its active event.
Can consider it for the next major though.

We'll address that on the Android/iOS version instead in the next major.


Various fixes + upgrade to d-m-p 0.17.1

tuned logging of icon-enricher, removed unnecessary field state

[merge]


Add KS-statistic example

Closes #4, #29.
This PR contributes a new example that does what the above issues requested. It also allows the possibility of using nothing as indicators, in which case the indicator analysis is completely skipped and the change metric is estimated directly from input timeseries.
Still todo:

[ ] Test that nothing works with surrogate analysis
[ ] add some tests.

@JanJereczek I need your help. I do not understand why my newest test fails. See my @testset "nothing indicator" begin in the full_analysis.jl test file. When I compute the significant flags, every single timepoint gets significance. I don't understand why. Only one timepoint, that where c > 1 should be significant. at all other timepoints the change metric value should not be significant.
This is the plot of the change metric:

I don't understand what's going on.

tests fail here because our p-value counting code is wrong. It become wrong when we changed it to the current code, which admittedly is incredibly complex and overengineered. The performance of pvalues is miniscule so we should simplify the code so that bugs are transparent and easy to find.
In any case the PR here is fine.
I also added some plotting code that I will finish in a different PR. I'll go ahead and merge this in and we can work on the individual issues later.


fix bias in if, ambiguous

Bool value of Tensor with more than one value is ambiguous.

@hliuca Thanks for the PR and updating it!


Follow naming convention from Iceberg's Java and Python implementations

Issues: https://github.com/apache/iceberg-rust/issues/145
Description: Rename ManifestListEntry as ManifestFile to follow Iceberg Spec and naming convention of Iceberg's Java and Python implementations.

@liurenjie1024, I have refactored the code. Please take a look when you get a chance. Thanks!

Thanks @liurenjie1024! I think I would also need Fokko's review to get these merged, right?
@Fokko, can you please review these changes? Thanks in advance!

I think I would also need Fokko's review to get these merged, right?

Yes.


Alignment with our latest baselines

These recommendations are not aligned with our latest baselines.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8ba42209-cc0a-d257-5566-a101d91b89ea
Version Independent ID: 7973c0ca-3afd-619f-a08e-43873f2e8dbf
Content: Audit Policy Recommendations
Content Source: WindowsServerDocs/identity/ad-ds/plan/security-best-practices/Audit-Policy-Recommendations.md
Product: windows-server
Technology: identity-adds
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

Any update on this?

@bekirdur What baselines? Just saying its not aligned to something doesn't help.

Alright.


endpoint: remove controller which synchronizes PolicyMap state

This controller runs every minute, and has to dump all the contents of the map
to userspace to do introspection as to whether there is a mismatch between the
desired state, and the state in the datapath. For an endpoint with a lot of
PolicyMap entries, this is a large number of syscalls. We also already have
functionality to keep an in-memory cache of all maps already in pkg/maps,
so this specialized controller is duplicating existing functionality. We also
have not seen a mismatch between the desired policy / realized policy in the
datapath which has caused drops, so this should be safe to remove.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>

This change is

test-me-please

test-me-please

Coverage increased (+0.04%) to 42.608% when pulling 8b7249125691f6767594dd04b406979d5e26308c on pr/ianvernon/remove-policymap-controller into 971f40d43d234362ebcecd0d1a6338e5bc7ff721 on master.


Changes required for json and multiserver testing support

To compile in MAC OSX:
make MACOSX_DEPLOYMENT_TARGET=10.14

To Run test:
./wrk -t2 -d2s -c10 -R10 -s scripts/multiple-endpoints_in_json.lua https://gmail.com:443 https://google.com:443 https://youtube.com:443

Output:
{
"TotalRequests": "2",
"DurationInMicroseconds": "113640.00",
"Bytes": "650",
"RequestsPerSec": "17.60",
"BytesTransferPerSec": "5719.82",
"MinLatency": "0.00",
"AvgLatency": "nan",
"MaxLatency": "0.00",
"StdDev": "nan",
"Url_0": "https://gmail.com:443",
"UrlRequestCount_0": 0
"Url_1": "https://google.com:443",
"UrlRequestCount_1": 0
"Url_2": "https://youtube.com:443",
"UrlRequestCount_2": 2
"Percentiles": [
                {
"Percent": "50",
"Value": "0.000000"
                },
                {
"Percent": "75",
"Value": "0.000000"
                },
                {
"Percent": "90",
"Value": "0.000000"
                },
                {
"Percent": "99",
"Value": "0.000000"
                },
                {
"Percent": "99.9",
"Value": "0.000000"
                },
                {
"Percent": "99.99",
"Value": "0.000000"
                },
                {
"Percent": "99.999",
"Value": "0.000000"
                },
                {
"Percent": "100",
"Value": "0.000000"
                }
        ]
}

can you maybe explain what this PR is all about?
taken out of context the one line description is cryptic...


Clearfog GT 8K device compatibility

Hi,
I am pleased to find resources like yours since I have been messing with GPON ONU sticks for a while. Thank you for your work.
I currently have a Clearfog GT 8K and CarlitoxxPro v2.0 device (actually VSOL V2801F) and I struggle to make it work in the SFP port of the device.
I found couple of linux patches to support it:
<EMAIL_ADDRESS>but I can not get a robust "Link Up" at every boot.. So I fixed it with a TP-Link MC220L but his is not the best, I am looking for a GPON ONU stick that would work on linux.
It looks like many problems were caused by a poort implementation of EEPROM in the device.
It seems that you managed to plug DFP-34X-2C2 in a macchiatoBIN which is very similar to Clearfog GT 8K (same chip) and that chip might solve my issues. Is the stick SFP+ ? Did you get link up on your device when you first plugged it ?
Thanks for your kind advice..

Hi @jblankfeld
RTL9601CI have very janky EEPROM emulator, every Stick use RTL9601CI SoC have issue reading it.
doesn't mean broken EEPROM making host cannot link with Stick, like RB3011 just work fine
have you tried changing LAN_SDS_MODE? RTL960x has 3 mode for 1Gb and 2.5Gb.
https://github.com/Anime4000/RTL960x/issues/27
need bring @stich86 from issue #17 he has same hardware as you

Hi @jblankfeld,
i've talked with Russel King (the owner of that patch), here is the full discussion:
<EMAIL_ADDRESS>At the moment the only way to make the stick recognized is to bring up ethernet port before insert it.
It's a problem of the adv from the stick, that the SFP driver of the board doesn't recognize and doesn't bring up the SFP port.
It needs a full rewrite of the driver to avoid this behaviour, but for me was just a test to obtain 2.5GB (HiSGMII) link. At the moment my stick is moved into a Broadcom BC57810s card and there is not issue

@tdmadam
V2801F firmware has sfpapp, while other stick dont have including TWCGPON657 firmware...
so I think sfpapp cause it...
try delete sfpapp line in etc ?

@stich86
Have any of you tried changing the default BitRate Nominal from 1200MBd to 2500MBd. I have some Alcatel modules that support 2.5Gbps. In their EEPROM at offset 0x0C there is a value=19
I tried to change it on my V2801F. Reading at 0x0C returns the value 0C. After writing at 0x0C a new value=19 and a new checksum=3D at 0x3F the new BR reading shows correctly 19.

Everything goes back to the old values when I power down the module. The V2801F uses an emulated EEPROM which is probably written to Flash somewhere. It would be good to trace at which address it is located.

It is different with DFP-34X-2C2. The EEPROM can be read almost instantly at power-on. It can also be written without a problem and remembers the values after shutdown.

Can you share the command for DFP32? Thx

@Anime4000
Thanks, I will take a closer look at sfpapp.
@stich86
I'm not sure what I2C-enabled programmer you have. Basically read 0x50 at offsets 0xC and 0x3F. Write back 19 to 0x0C and a new checksum to 0x3F.
#READ
i2cget -y 0 0x50 0x0C
i2cget -y 0 0x50 0x3F
#WRITE
i2cset -y 0 0x50 0x0C 0x19
i2cset -y 0 0x50 0x3F 0x??
Obviously it will easier if you have programmer that can read SFP module and fix the checksum.
But there is also a way to do it. The pictures I posted here are from SFP Total wizard. Their SFP adaptors are expensive but you can download the software and load your own dump and then fix the cheksum in it.
https://sfptotal.io/
If everything goes well ethtool should show 2500MB.

This is a quick test I did. Ubuntu Live 22.04, DFP-34X-2C2 plugged into BCM57810 card without any bnx2x drivers

root@ubuntu:/home/ubuntu# ethtool -m enp1s0f0

 Identifier                                : 0x03 (SFP)
 Extended identifier                       : 0x04 (GBIC/SFP defined by 2-wire interface ID)
 Connector                                 : 0x01 (SC)
 Transceiver codes                         : 0x00 0x00 0x00 0x02 0x22 0x00 0x01 0x00 0x00
 Transceiver type                          : Ethernet: 1000BASE-LX
 Transceiver type                          : FC: intermediate distance (I)
 Transceiver type                          : FC: Longwave laser (LC)
 Transceiver type                          : FC: Single Mode (SM)
 Encoding                                  : 0x01 (8B/10B)
!BR, Nominal                               : 2500MBd
 Rate identifier                           : 0x00 (unspecified)
 Length (SMF,km)                           : 20km
 Length (SMF)                              : 20000m
 Length (50um)                             : 0m
 Length (62.5um)                           : 0m
 Length (Copper)                           : 0m
 Length (OM3)                              : 0m
 Laser wavelength                          : 1310nm
 Vendor name                               : OEM
 Vendor OUI                                : 00:00:00
 Vendor PN                                 : STICK
 Vendor rev                                :
 Option values                             : 0x00 0x1a
 Option                                    : RX_LOS implemented
 Option                                    : TX_FAULT implemented
 Option                                    : TX_DISABLE implemented
 BR margin, max                            : 0%
 BR margin, min                            : 0%
 Vendor SN                                 : GPON22010163
 Date code                                 : 220117

I wonder what LAN_SDS_MODE will be needed when DFP-34X-2C2 EEPROM indicates that it supports 2500MB. When I find a spare hard drive and clean up my desk I might install the bnx2 drivers.

@Anime4000
Thanks, I will take a closer look at sfpapp.
@stich86
I'm not sure what I2C-enabled programmer you have.

#READ

i2cget -y 0 0x50 0x0C

i2cget -y 0 0x50 0x3F

#WRITE

i2cset -y 0 0x50 0x0C 0x19

i2cset -y 0 0x50 0x3F 0x??

Obviously it will easier if you have programmer that can read SFP module and fix the checksum.
But there is also a way to do it. The pictures I posted here are from SFP Total wizard. Their SFP adaptors are expensive but you can download the software and load your own dump and then fix the cheksum in it.
https://sfptotal.io/
If everything goes well ethtool should show 2500MB.
edit:
I found this command very helpful in Ubuntu. It converts hexadecimal numbers in the text file to an actual binary file.
xxd -p -r sfpdump.ascii sfpdump.bin

No I don't have any i2c program. But we can write the i2c parameters using diag app form the stick itself
This change should be good for ClearFog/MacchiatoBIN that use sfp native driver and doesn't need the quirk to force 2500BaseX
Is their SFP app free to use?

Yes, I have seen i2c under diag, but could not find any information about its syntax. This would be a great solution for the V2801F if it could be made to work.
SFP Total Wizard's most functions won't work because it requires their programmer, but some, like viewing binary files and manipulating them, do. Here's my binary file to try
DFP32A0.zip

Yes, I have seen i2c under diag, but could not find any information about its syntax. This would be a great solution for the V2801F if it could be made to work. SFP Total Wizard's most functions won't work because it requires their programmer, but some, like viewing binary files and manipulating them, do. Here's my binary file to try
DFP32A0.zip

there is another user from Unifi community that has managed to create some script to fix i2c broken EEPROM on CarlitoXX.
He is also on our Discord channel (gaz), we can discuss there. I'll try in the next week to recovery my V2801F (need to desolder NAND and flash it again)

@stich86
Awesome! I have found what I need. I will test it later on V2801F.

@stich86 Awesome! I have found what I need. I will test it later on V2801F.

let me know, we are on Discord if you want to discuss live ;)

@stich86 Awesome! I have found what I need. I will test it later on V2801F.

let me know, we are on Discord if you want to discuss live ;)

Family time now but later I will join the channel :)

I tried to register on Discord, I was asked for my email address. I verified it, then some cryptic "Something is going on here" message popped up asking for my phone number. I'm sorry but they will not get it.
Anyway, here's a modified Gazor script that does the job. I tried to write my own script but I was getting too many errors in the ash shell and I gave up.
# Author @gazor
# Small modifications by @tdmadam May2022
# This script will change BitRate value to 2500MBd
# cc_code at 0x3F is also corrected.

cd /tmp
cat << EOF > BRchg.sh
#!/bin/sh

patched=0
cc_base=0
i=0

# Direct cli commands used for BR
# RTK.0> i2c get port 1 dev 0x50 reg 0xc
# RTK.0> i2c set port 1 dev 0x50 reg 0xc data 0x19

while [[ \$i -lt 64 ]]; do
  line=\`diag i2c get port 1 dev 0x50 reg \$i | grep dev:\`
  index=\`echo \$line | sed -n 's/dev: 0x50, reg: 0x\([0-9a-f]*\), data: 0x\([0-9a-f]*\)/0x\1/p'\`
  value=\`echo \$line | sed -n 's/dev: 0x50, reg: 0x\([0-9a-f]*\), data: 0x\([0-9a-f]*\)/0x\2/p'\`
  let index=index
  let value=value

  if [[ "\$index" -ne "\$i" ]]; then
    echo "I2C response reported incorrect index \$index, expected \$i"
    exit 1
  fi

  printf "EEPROM[0x%02X] = 0x%02X;\n" \$index \$value
  let newvalue=value

  # patch BR
  if [ "\$i" -eq "12" ] ; then
    printf "The current BitRate value is 0x%02X %4d00Mb\n"  \$value \$value
    let newvalue=0x19
    # To change it back newvalue=0x0C

  fi

  # CC_BASE at index 63 covers ranges [0, 62]
  if [ \$i -lt 63 ]; then
    let cc_base=cc_base+newvalue # in case we patched
    let cc_base=cc_base%256
  elif [ \$i -eq 63 ]; then
    if [ \$value -eq \$cc_base ]; then
      printf "CC_BASE already correct 0x%X\n" \$cc_base
    else
      printf "Fixing CC_BASE from 0x%X to 0x%X\n" \$value \$cc_base
      let newvalue=cc_base
    fi
  fi

  # make change
  if [[ "\$newvalue" -ne "\$value" ]]; then
    command=\`printf "diag i2c set port 1 dev 0x50 reg 0x%02X data 0x%02X" \$index \$newvalue \`
    eval "\$command" > /dev/null 2>&1
    patched=1
  fi

    let i=i+1

done

line=\`diag i2c get port 1 dev 0x50 reg 0xc | grep dev:\`
value=\`echo \$line | sed -n 's/dev: 0x50, reg: 0x\([0-9a-f]*\), data: 0x\([0-9a-f]*\)/0x\2/p'\`
let index=index
let value=value
 printf "The new BitRate value is 0x%02X %4d00Mb\n"  \$value \$value

EOF

chmod +x BRchg.sh
./BRchg.sh

Has anyone maybe tested this on Macchiatobin or Mikrotik to see if setting the BitRate ons SFP Stick from 1500Mb to 2500Mb makes any difference?
I don't own a Mikrotik to try this, they are hard to buy now.
Small Form-factor Pluggable (SFP) Transceiver MultiSource Agreement (MSA) page. 35
https://members.snia.org/document/dl/26184

BR, nominal
The nominal bit rate (BR, nominal) is specified in units of 100 Megabits per second, rounded
off to the nearest 100 Megabits per second. The bit rate includes those bits necessary to
encode and delimit the signal as well as those bits carrying data information. A value of 0
indicates that the bit rate is not specified and must be determined from the transceiver
technology. The actual information transfer rate will depend on the encoding of the data, as
defined by the encoding value.

@stich86 thanks for this discussion I tried the same hack as you did with los = 0, I also added the phylink set quirk and this worked for a while until one day I had no link again :( I guess I'm a bad kernel hacker.
Have you managed to solve the link issue setting LAN_SDS_MODE=4 on the stick itself ?

Has anyone maybe tested this on Macchiatobin or Mikrotik to see if setting the BitRate ons SFP Stick from 1500Mb to 2500Mb makes any difference? I don't own a Mikrotik to try this, they are hard to buy now.
Small Form-factor Pluggable (SFP) Transceiver MultiSource Agreement (MSA) page. 35 https://members.snia.org/document/dl/26184

BR, nominal
The nominal bit rate (BR, nominal) is specified in units of 100 Megabits per second, rounded
off to the nearest 100 Megabits per second. The bit rate includes those bits necessary to
encode and delimit the signal as well as those bits carrying data information. A value of 0
indicates that the bit rate is not specified and must be determined from the transceiver
technology. The actual information transfer rate will depend on the encoding of the data, as
defined by the encoding value.

No, you shouldn't set that to 2500 if you use 2500basex. you should set that to 3100 or 3200 : https://github.com/torvalds/linux/blob/cf1182944c7cc9f1c21a8a44e0d29abe12527412/drivers/net/phy/sfp-bus.c#L231

More information here: https://github.com/Anime4000/RTL960x/discussions/250


Glulxercise test failures when Glulxe 0.6.0 built with Visual C++

In the doubleconv tests:
dtonumz +NaN=$80000000 (should be $7FFFFFFF FAIL), dtonumz -NaN=$7FFFFFFF (should be $80000000 FAIL)
dtonumn +NaN=$80000000 (should be $7FFFFFFF FAIL), dtonumn -NaN=$7FFFFFFF (should be $80000000 FAIL)

It looks like Visual C++'s signbit() returns 0 for +NaN, which is in contradiction of the C11 spec.


chiron: Incorporating kubernetes csr v1 api

Add ability for chiron module of Istiod to use Kubernetes v1 CSR api  to sign Istiod DNS certificates and optionally sign workload certificates when Istiod functions as an RA. Refer to RFC for context
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@shankgan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-notes_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-notes_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-notes_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-notes_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-notes_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-notes_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-notes_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-notes_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-notes_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-notes_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-notes_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-notes_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-notes_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-notes_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-notes_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-k8s-tests_istio

lint_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test lint_istio

integ-ipv6-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-notes_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-notes_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-k8s-tests_istio

lint_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test lint_istio

integ-ipv6-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-notes_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-notes_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-k8s-tests_istio

lint_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test lint_istio

integ-ipv6-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-security-k8s-tests_istio

gencheck_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test gencheck_istio

integ-pilot-multicluster-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-security-multicluster-tests_istio

integ-multicluster-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-notes_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-notes_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-k8s-tests_istio

lint_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test lint_istio

integ-ipv6-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-security-k8s-tests_istio

gencheck_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test gencheck_istio

integ-pilot-multicluster-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-security-multicluster-tests_istio

integ-multicluster-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-k8s-tests_istio

lint_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test lint_istio

integ-ipv6-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-security-k8s-tests_istio

gencheck_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test gencheck_istio

integ-pilot-multicluster-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-security-multicluster-tests_istio

integ-multicluster-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test unit-tests_istio

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-security-k8s-tests_istio

gencheck_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test gencheck_istio

integ-pilot-multicluster-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-security-multicluster-tests_istio

integ-multicluster-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test release-notes_istio

lint_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test release-test_istio

integ-helm-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-security-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test release-notes_istio

lint_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test lint_istio

unit-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-cni-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-cni-k8s-tests_istio

integ-security-k8s-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
3ed7500c7f906a0fa6b6d750184daa160e01e363
link
/test integ-pilot-multicluster-tests_istio

release-notes_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test release-notes_istio

lint_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test lint_istio

unit-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test release-notes_istio

lint_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test lint_istio

unit-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test lint_istio

unit-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test integ-security-k8s-tests_istio

release-notes_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test integ-security-k8s-tests_istio

release-notes_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test release-notes_istio

unit-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
956aa508e4dc4f0896dcf837dea7bc2f1672ff7c
link
/test integ-security-k8s-tests_istio

release-notes_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test release-notes_istio

unit-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test release-notes_istio

unit-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

release-notes_istio
1241e98a9d43ca0247b207114c04afae1c88b0aa
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

release-notes_istio
1241e98a9d43ca0247b207114c04afae1c88b0aa
link
/test release-notes_istio

lint_istio
1241e98a9d43ca0247b207114c04afae1c88b0aa
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

release-notes_istio
1241e98a9d43ca0247b207114c04afae1c88b0aa
link
/test release-notes_istio

lint_istio
1241e98a9d43ca0247b207114c04afae1c88b0aa
link
/test lint_istio

unit-tests_istio
1241e98a9d43ca0247b207114c04afae1c88b0aa
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

lint_istio
1241e98a9d43ca0247b207114c04afae1c88b0aa
link
/test lint_istio

unit-tests_istio
1241e98a9d43ca0247b207114c04afae1c88b0aa
link
/test unit-tests_istio

release-notes_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

release-notes_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test release-notes_istio

unit-tests_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

release-notes_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test release-notes_istio

unit-tests_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

unit-tests_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test integ-security-multicluster-tests_istio

release-notes_istio
59dea7b2672f09d2d42260a3b582913744ed1707
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

unit-tests_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test integ-security-multicluster-tests_istio

release-notes_istio
59dea7b2672f09d2d42260a3b582913744ed1707
link
/test release-notes_istio

gencheck_istio
59dea7b2672f09d2d42260a3b582913744ed1707
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

unit-tests_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
31e483308f07734901a8e6c5ce4c85f9136aef9c
link
/test integ-security-multicluster-tests_istio

release-notes_istio
59dea7b2672f09d2d42260a3b582913744ed1707
link
/test release-notes_istio

gencheck_istio
59dea7b2672f09d2d42260a3b582913744ed1707
link
/test gencheck_istio

lint_istio
59dea7b2672f09d2d42260a3b582913744ed1707
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

gencheck_istio
59dea7b2672f09d2d42260a3b582913744ed1707
link
/test gencheck_istio

lint_istio
59dea7b2672f09d2d42260a3b582913744ed1707
link
/test lint_istio

release-notes_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

gencheck_istio
59dea7b2672f09d2d42260a3b582913744ed1707
link
/test gencheck_istio

release-notes_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test release-notes_istio

lint_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

release-notes_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test release-notes_istio

lint_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test lint_istio

gencheck_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

release-notes_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test release-notes_istio

lint_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test lint_istio

gencheck_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test gencheck_istio

unit-tests_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a5750ef4fdbb7f3ce59475a8fe612dd8a2167786
link
/test integ-security-k8s-tests_istio

release-notes_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test release-notes_istio

lint_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test lint_istio

gencheck_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test gencheck_istio

unit-tests_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test release-notes_istio

lint_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test lint_istio

gencheck_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test gencheck_istio

unit-tests_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test lint_istio

gencheck_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test gencheck_istio

unit-tests_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test integ-security-k8s-tests_istio

release-notes_istio
ad803464457b5391dfec7b0dac4ff49cf914f6fe
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
762334a4a35792438522445957fcf35c0dbb6fe4
link
/test integ-security-k8s-tests_istio

release-notes_istio
ad803464457b5391dfec7b0dac4ff49cf914f6fe
link
/test release-notes_istio

integ-security-multicluster-tests_istio
ad803464457b5391dfec7b0dac4ff49cf914f6fe
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ad803464457b5391dfec7b0dac4ff49cf914f6fe
link
/test release-notes_istio

integ-security-multicluster-tests_istio
ad803464457b5391dfec7b0dac4ff49cf914f6fe
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
ad803464457b5391dfec7b0dac4ff49cf914f6fe
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

One question: kubernetes.io/legacy-unknown is not allowed in v1 API, what will replace it

@shankgan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
ad803464457b5391dfec7b0dac4ff49cf914f6fe
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
ad803464457b5391dfec7b0dac4ff49cf914f6fe
link
/test integ-security-k8s-tests_istio

release-notes_istio
6ab34ef02288d777904a36641f180abbee1b7be7
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

One question: kubernetes.io/legacy-unknown is not allowed in v1 API, what will replace it

There is nothing that can replace it as is. Therefore this configuration :- "PILOT_CERT_PROVIDER = Kubernetes" will be obsoleted soon since there is no default signer. Users will have to configure a custom signer.

I completely agree we cannot drop support. My understanding is this is
detecting the supported API version and falling back to the old one if
needed?
If not then I definitely agree
On Wed, Jul 14, 2021 at 2:37 AM Zhonghu Xu @.***> wrote:

@.**** requested changes on this pull request.
Wait, i donot think we can stop supporting for k8s < 1.21 so quickly.
@howardjohn https://github.com/howardjohn This has big compatibility
influence.
I would recommend detecting k8s version and automatically choose what to
do first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/33983#pullrequestreview-706062065,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXPUMNFCBTIB6UDCZSLTXVLFZANCNFSM5AHMJ6WA
.

We aren't dropping support. The v1 API is first invoked. If we get an API not detected error, then we switch to the v1beta1 api. note that all the integration tests that have passed have done so with the v1beta1 api.

@shankgan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
31315825ef134ba995771f9e49ceaaadd7df96a0
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

/retest


[builder] Making more (or all) fontmake arguments available? (Needing --masters-as-instances)

Past issues such as https://github.com/googlefonts/gftools/issues/660 and those listed at https://github.com/googlefonts/gftools/pull/617 have expressed needs for more fontmake args. Well, here’s another!
I have a Glyphs source that has several Masters that are incompatible (they are different versions of a basic design), and each has a corresponding Export / instance.
This builds with fontmake -g familyname.glyphs -o otf --masters-as-instances. However, I can’t get it to build from the gftools builder, even if I set interpolate: false in the config.yaml.
So, I think that perhaps I need --masters-as-instances as an option in the builder. Or, is there another solution that I might be missing?
Thanks for any help!

I don't think you need that option, it's a remnant of the old noto build toolchain. You just need to have the instances defined in your glyphs source at the same locations as the masters, and use the -i option so that the instances get built (and not the masters). No interpolation takes place if the instance is exactly on top of a master

Hey Cosimo, thanks so much for the quick answer!
I thought I had tested your recommendation before I asked this, but I’ve just found that the instances also need Axis Location custom parameters in order for it to work. When they have that, the basic -i option (just interpolate: true in the builder config.yaml) does indeed work to export the individual instances.
I’ll close the issue because it wasn’t actually an issue in the end. I really appreciate your help and insight here!

FWIW, builder2 has extraFontmakeArgs:, extraVariableFontmakeArgs: and extraStaticFontmakeArgs: config keys.


Pass in heightScale of the preview Mesh GameObject

After Sebastian changes the TerrainChunks from a primitive to a regular GameObject, he stops setting the scale; meaning it goes from (10, 1, 10) to (1, 1, 1). This is correct, but causes the user to instinctively tone-down the heightMultiplier (from 125 to 25 in my case), but the scale of the Mesh GameObject is sitll (10, 1, 10).
These changes will allow the scale of the preview GameObject to be adaptive and still be representative of what will be generated at runtime.
Note: This all assumes that the plane is a square (x and z are the same), which is why only the localScale.x is used.

I should mention that the preview GameObject is only going to show the first chunk, but that now it can be scaled. This is mainly so the changes made to the height multiplier are consistant no matter what the scale of the editor preview gameobject are.
While I'm on the subject, the materials for the Mesh map preview should have its tiling & offsets set to the following
Tiling: X: -1 Y: 1
Offset: X: 1 Y: 0
This will make it so the flat map and the preview mesh are of the correct orientation
The tiling for the flat Map preview should be kept to defaults (Tiling: (1, 1) Offset (0, 0).
Finally set the scale of the Mesh preview GameObject to 1, 1, 1.
Re-generate the colormap and mesh.
Now if you enter play mode, the runtime chunk, flat map, and mesh preview should all line up perfectly and be in the correct orientation


CON-1232: Build and run Gramine enclaves inside Docker

Allow Gramine enclaves to be built and run inside a Docker container.

@shamsasari can you give me an early feedback on this? This makes Gramine running in the conclave-build container

@shamsasari Would you mind to take another look, while we decide when to link our PRs?

This is looking good now. Let's get https://github.com/R3Conclave/conclave-core-sdk/pull/132 approved and merged first.

Can you enable PytorchEnclaveTest that was disabled in https://github.com/R3Conclave/conclave-core-sdk/pull/134. Your changes here should be enough to fix it.


test: don't put output of mkfs.ext4 in the test result

It's hard to see which test has passed/failed in this way.
+ flake8 .
+ py.test -v . -x -s -k test_node --enable-node-test
============================= test session starts ==============================
platform linux2 -- Python 2.7.14, pytest-2.9.2, py-1.5.4, pluggy-0.3.1 -- /usr/local/bin/python
cachedir: .cache
rootdir: /integration/tests, inifile:
collecting ... collected 33 items

mke2fs 1.43.4 (31-Jan-2017)
test_node.py::test_node Creating filesystem with 16384 1k blocks and 4096 inodes
Filesystem UUID: a40e9c6b-cad5-4512-8973-0b6b7071341f
Superblock backups stored on blocks:
	8193

Allocating group tables: done
Writing inode tables: done
Creating journal (1024 blocks): done
Writing superblocks and filesystem accounting information: done

mke2fs 1.43.4 (31-Jan-2017)
Creating filesystem with 16384 1k blocks and 4096 inodes
Filesystem UUID: ca8a9c0c-b865-4b32-abe1-f33c8e332745
Superblock backups stored on blocks:
	8193

Allocating group tables: done
Writing inode tables: done
Creating journal (1024 blocks): done
Writing superblocks and filesystem accounting information: done

PASSED
mke2fs 1.43.4 (31-Jan-2017)
test_node.py::test_replica_scheduler Creating filesystem with 16384 1k blocks and 4096 inodes
Filesystem UUID: 46edfee1-13ab-4f55-8078-5b2b541f6fa4
Superblock backups stored on blocks:
	8193

Allocating group tables: done
Writing inode tables: done
Creating journal (1024 blocks): done
Writing superblocks and filesystem accounting information: done

This is my mistake. I've specified -s in the command line... The issue is invalid.


Route action as effect (react-router-redux)

Hi, I'm struggling with making effects work with react-router-redux. I've setup react-router-redux routerMiddleware and trying to change history as effect.
Example:
import { push } from 'react-router-redux';

function reducer(state, action) {
  switch(action.type) {
  case 'FIRST_ACTION':
    return loop(
      state.set('firstRun', true),
      Effects.constant(push('/delivery'))
    );
}

In redux DevTools I see that action @@router/CALL_HISTORY_METHOD is triggered, but history (url) is not changed. Trying to figure out, what I'm doing wrong here.

Example repo: https://github.com/mauron85/redux-loop-react-router-redux

@mauron85 so I'm not sure why this is the case, but this is entirely dependent on the order the enhancers are applied in. If you apply them in this order:
const createPersistentStore = compose(
  install(),
  applyMiddleware(
    reduxRouterMiddleware
  ),
  DevTools.instrument()
)(createStore);

then everything works. Any other configuration either seems to break react-router-redux or otherwise actions returned by a loop are somehow not being handed to the middleware. I'm not sure why that's the case but I'll look into it more.

@lukewestby thank you very much, changing order did the trick for me.

So it looks like because the redux-loop enhancer calls dispatch on the store that was created in the enhancers that follow it it effectively skips any dispatch enhancement that was applied by enhancers before it in the chain. In this case, applyMiddleware applied before redux-loop's enhancer doesn't allow redux-loop's dispatch to "know" about the custom dispatching that happens in order to enact middleware. This is why the first action makes it into the middleware but any actions that come from loops are ignored. This seems to be a concern with the way store enhancers work at a more fundamental level than a bug with redux-loop as it were.
@gaearon, if you have some time would you be able to weigh in?

@lukewestby from what I can see the actual issue is that the dispatch in redux-loop will actually trigger the effect. Combine will call the enhancers in reverse orders, so when dispatch is getting the state the effect was not actually created yet, as it will be in the applyMiddleware.
In the current implementation solution is to always have redux-loop at the beginning. A possible fix is to schedule the reading in dispatch so it will run the effects after the current event loop finishes.

@lukewestby I've just upgraded to redux-loop 2.0.0 from 1.1.0 and it seems to store state very differently.
In version 1.1.0 state atom is object with structure:
state: {
model: {}
effect: {}
}

in 2.0.0 state is array
state: [
 0: {}
 1: {}
]

You can still use my example to reproduce.
Is this intended?

@mauron85 it is! It's intended to assist with destructuring when you call a reducer directly. Instead of doing
{ model: m, effect: e } = reducer(state, action);

you can just do
[m, e] = reducer(state, action);

This was the reason for the major version bump.

This thread of discussion saves me hours.
I am combining react-router-redux and redux-loop. It always fails with below message.

Uncaught Error: Expected the routing state to be available either as state.routing or as the custom expression you can specify as selectLocationState in the syncHistoryWithStore() options. Ensure you have added the routerReducer to your store's reducers via combineReducers or whatever method you use to isolate your reducers

It looks that redux-loop changes the behavior of store.getState to return a array instead of object.
Putting install(() ahead of applyMiddleware solves the problem.
  var storeEnhancers = compose(
    install(),
    applyMiddleware(promiseMiddleware, thunk)
  );

 const store = createStore(
    loopCombineReducers(allReducers),
    initialState,
    storeEnhancers
 )


Incorrect determination that private is useless

Here's a simple example.
module Foo
  extend ActiveSupport::Concern

  class_methods do
    private
    def some_private_class_method
      # ..
    end
  end

  private # Rubocop complains that this one is useless

  def some_private_instance_method
  end
end

Expected behavior
The second private is fine because it's for instance methods, whereas the first private is for class methods.
Actual behavior
The second private is determined to be useless.
Steps to reproduce the problem
Run Rubocop on the example Ruby I just posted above.
RuboCop version
$ rubocop -V
0.42.0 (using Parser <IP_ADDRESS>, running on ruby 2.2.2 x86_64-darwin15)

Hey @ClayShentrup,
I had a similar issue and made a change to this cop to support your use-case, which shipped in 0.42.0
Try adding this config to your .rubocop.yml:
Lint/UselessAccessModifier:
  ContextCreatingMethods:
    - class_methods

Does that help?

@maxjacobson's solution takes care of this particular problem, so I'm closing. Further enhancement of the Lint/UselessAccessModifier cop is discussed in #3483.


Drop ".dev0" prefix from Spark SNASHOT distro builds

Fixes #8588
Alternative to #8589
Drop PEP 440 suffix for Python-based version extraction
Local testing with 3.3.0 downloaded from Apache and 3.3.0-SNAPSHOT built locally
JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk-amd64 SPARK_HOME=~/gits/apache/spark/dist  TEST_PARALLEL=0 ./integration_tests/run_pyspark_from_build.sh -k 'array_exists'

Signed-off-by: Gera Shegalov<EMAIL_ADDRESS>

build

build


[10.x] Allow passing an array with values to the filled() helper

This PR will allow you to pass an array of values to the filled() helper method.
The same principle is already applied to the filled() helper method in Illuminate/Http/Concerns/InteractsWithInput.
Instead of this:
@if (filled($var1) && filled($var2) && filled($var3))
@endif

You would be able to do this:
@if (filled([$var1, $var2, $var3]))
@endif

I know there are other ways to accomplish the same thing, but this seems like a nice little papercut and an opportunity to streamline both methods.
This might however cause a new confusion with the inverse method of filled(), namely blank(), where currently one value is allowed.
Thanks for taking the time to review this PR.
I'd appreciate any feedback.

Yeah, feeling less confident about this PR as it progresses.
Don't want to be responsible for introducing a BC.
I'll leave it up to you and the rest of the team.
No hard feelings if you decide to close without merging!

Breaking change. For example [' '] would have previously been considered filled and now it isn't.


Build external webserver for cnf-app-mac-operator

Just doing the same we've been doing for the other operators: build the webserver in the multi-stage build, then run it as binary

Job is working and lifecycle probe tests frm tnf are still passing, so this is ready for review

@tonyskapunk , I finally removed the local copies of webserver.go and updated the Makefiles accordingly, I think it's now fine


Handling existing card dirs

Resolves #10

Codecov Report

Merging #11 (d2afdb5) into main (d3302b3) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   52.83%   52.43%   -0.41%
==========================================
  Files          11       11
  Lines         653      658       +5
==========================================
  Hits          345      345
- Misses        268      273       +5
  Partials       40       40

Impacted Files
Coverage Δ

pkg/crawler/downloader.go
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


12428 repeat limit bug

I manually tested this and it works! Given the two test cases, and that the other specs are passing, Im feeling pretty confident. But we can talk more if more testing is needed.


usb: use bincode for conversions between message header struct and raw bytes

Changes

Added an ADBUsbMessageHeader struct without the payload and implement Serialize and Deserialize on it.
Replaced to_bytes method body to use bincode::serialize
Made the try_from method use bincode::deserialize. Note: We're using unwraps so far, we need to add an error variant for invalid bytes.
The USBCommand enum variants equal their respective values.

The enum has a #[repr(u32)] for the underlying type.
The to_u32 method has been removed in favor of the as u32 since the enum is a primitive now.

I rebased usb branch on this one as there were merge conflicts due to previous PR merge.
I cannot make it work, get stuck with logs:
written 24
writing payload...
written 18
written 24
writing payload...
written 0
Error: Operation timed out

Can you have a look at it please ? Thanks !

Yes, I'll look into it.

The C like enum USBCommand with its non-sequential variants was being encoded as a zero indexed enum. Fixed it with serde_repr

Hi, there are a lot of conflicts with the changes I've made and upstream usb. Would you like me to rebase and one-shot this and force-push? It would be easier for me since I'd have an lsp for sanity checks.

Yes, please !
I had a look into it and did not manage to make it work, maybe it'll work with the new version of usb branch

Okay, I have made the necessary changes and have tested them on my device. Let me know if you want me to implement the adb pull command. I have a local branch with that already implemented!

Thanks for the rebase ! I'll check it tomorrow :)
You can of course create a new PR with pull support, I'd like to merge the usb branch in master as soon as possible and this is a feature I'm yet missing


created not presented on some functions

When a functions is created with the PUT verb the created, metadata is missing from the function

Add field created when create function via PUT  #15

Problem solved


There is a problem for touchEvent when I set startAngle to M_PI

When I set startAngle to M_PI, the direction of the chart's animation is wrong

Ok, I see. I had a solution for it in another project.
Maybe will find it later.


YouTube video missing sound

If I start a YouTube video from the first click in my app, I usually get no sound.  It seem to be a problem with starting the video too quickly after the first click enables audio -- if I wait 100ms before starting the video.  The problem does not occur.  This is happening in Chrome on Windows 10,
Here are the errors I'm seeing in the log file.

I'm using the player and it works correctly across all platforms, make sure you set up it correctly.
First thing, if you try to use auto-play make sure you override Youtube configuration.
 <ReactPlayer .. config={{                         youtube: {                             playerVars: {                                 autoplay: true,                             }                         },                     }} .. />
Second, make sure you initialize the player with muted value false.
 const [muted, setMuted] = useState(false); .. <ReactPlayer ..           muted={muted} .. />
I wish that will help you.

Ideally you need to wait for onReady before making any changes that will call unMute or setVolume internally. The youtube player instance doesn't exist at the point you are currently doing it.


typeof obj.section_id !== undefined does not work as intended

There are several of these type of checks in the code and they do not work in the property is not actually defined. typeof obj.suite when it is undefined is the string 'undefined' so either the check should be
if (typeof obj.section_id !== 'undefined') path += "&section_id=" + obj.section_id;

or more conveniently since undefined is falsey
if (obj.section_id) path += "&section_id=" + obj.section_id;

of course there are better ways to verify the values but this should be good enough.

Thank you for the feedback. Since you already changed them in your own fork if you do a pull request I will check it and accept it. Otherwise it will wait till I have the time, probably next week.

Thank you, I merged your code but changed a bit to pass my jslint linter.
Here is the commit. Let me know if you find anything else


[BUG]: Unable to compile with Typescript.

I have been attempting to integrate Openblox into a project of mine, but on compile I run into this error:
RangeError: Maximum call stack size exceeded
    at resolveNameHelper (C:\Users\Colt\Desktop\test-proj\node_modules\.pnpm\typescript@5.5.4\node_modules\typescript\lib\tsc.js:18946:29)
    at resolveEntityName (C:\Users\Colt\Desktop\test-proj\node_modules\.pnpm\typescript@5.5.4\node_modules\typescript\lib\tsc.js:47862:32)
    at getSymbolOfNameOrPropertyAccessExpression (C:\Users\Colt\Desktop\test-proj\node_modules\.pnpm\typescript@5.5.4\node_modules\typescript\lib\tsc.js:84521:22)
    at getSymbolAtLocation (C:\Users\Colt\Desktop\test-proj\node_modules\.pnpm\typescript@5.5.4\node_modules\typescript\lib\tsc.js:84631:18)
    at getTypeFromTypeNodeWorker (C:\Users\Colt\Desktop\test-proj\node_modules\.pnpm\typescript@5.5.4\node_modules\typescript\lib\tsc.js:61238:24)
    at containsReference (C:\Users\Colt\Desktop\test-proj\node_modules\.pnpm\typescript@5.5.4\node_modules\typescript\lib\tsc.js:61481:101)
    at visitNode2 (C:\Users\Colt\Desktop\test-proj\node_modules\.pnpm\typescript@5.5.4\node_modules\typescript\lib\tsc.js:27329:18)
    at forEachChildInTypeReference (C:\Users\Colt\Desktop\test-proj\node_modules\.pnpm\typescript@5.5.4\node_modules\typescript\lib\tsc.js:27435:12)
    at forEachChild (C:\Users\Colt\Desktop\test-proj\node_modules\.pnpm\typescript@5.5.4\node_modules\typescript\lib\tsc.js:27850:35)
    at containsReference (C:\Users\Colt\Desktop\test-proj\node_modules\.pnpm\typescript@5.5.4\node_modules\typescript\lib\tsc.js:61504:16)

To make sure that this was not something happening on my end, I set up a very bare-bones Typescript project to test and make sure that it was a consistent issue. Adding on, it only seems to run into this error when something is being imported with Openblox; removing any imports relating to it, it runs into no issue.
You can find the test code I used here.

Hey, sorry I didn't this issue until now, my apologies. I can indeed reproduce this issue and will try and resolve it. As an alternative until then you can see if adding skipLibCheck to your compiler options helps.

Adding skipLibCheck does indeed work from what I've tested. Thanks for the response, excited to integrate this into things 🤞

I think i'm going to close this issue for now then 😅.
From an initial look it seems that without having skipLibCheck causes more issues than the one you described above, specifically with Bun types colliding with Nodes. So I think this may be an issue with Bun but i'm unsure at this point in time. 😅

I pray that this can be resolved sometime soon 🙏🏼 I'm running into an issue with skibLibCheck, types will not work as intended in .d.ts files, which makes it a bit harder for me to properly typeset things.

What about the .d.ts files is not working as intended?

I did some searching and I believe the culprit is some circular dependency in one of the .d.ts files

I was going to try debugging the issue and open a PR, though I couldn't figure out how to properly build source 😅

It honestly might be the fact that type files are named .types.ts rather than .d.ts

Actually not sure, since the build code (from npmjs) seems fine

@sqikerz  .d.ts files are created during a build step and our only present in the dist folder.
the .types.ts` naming scheme is arbitrary and is used to denote that said typescript file is used for declaring types only. It should not interfere with .d.ts files.

I was going to try debugging the issue and open a PR, though I couldn't figure out how to properly build source 😅

That seems interesting. From my testing it seems that the issue is with the apis folder.
Also to build the code run npm run build:code.

What about the .d.ts files is not working as intended?

In specific, it won't properly resolve types. Anything for the package that is defined gets resolved as "any".

Which version is this happening in?

What about the .d.ts files is not working as intended?

In specific, it won't properly resolve types. Anything for the package that is defined gets resolved as "any".

Which version is this happening in?

Version for what in specific?

Made some modifications (mainly verbose, and not using bun/ts at all in the build process), and I got this:

Seems like a known issue - https://github.com/oven-sh/bun/issues/8761

I was going to try debugging the issue and open a PR, though I couldn't figure out how to properly build source 😅

That seems interesting. From my testing it seems that the issue is with the apis folder.
Also to build the code run npm run build:code.

Yea I did try this, but I get this error:
><EMAIL_ADDRESS>build:code
> delete dist && bun run ./build.ts && tsc --emitDeclarationOnly

'delete' is not recognized as an internal or external command,
operable program or batch file.

It seems you are missing the delete-cli dependency.
bun i delete-cli

Thanks! Though, running into this issue now for some reason? I ran the install script so I have all of the modules installed.
src/http/httpHandler/httpHandler.ts:3:27 - error TS2307: Cannot find module 'roblox-bat' or its corresponding type declarations.

3 import { HBAClient } from "roblox-bat"
                            ~~~~~~~~~~~~

src/queries/cloud/usersQuery.ts:16:35 - error TS2344: Type 'readonly ["createTime", "id", "name", "displayName", "about", "locale", "premium", "idVerified", "socialNetworkProfiles"]' does not satisfy the constraint 'any[]'.
  The type 'readonly ["createTime", "id", "name", "displayName", "about", "locale", "premium", "idVerified", "socialNetworkProfiles"]' is 'readonly' and cannot be assigned to the mutable type 'any[]'.

16 type UserInfoField = ArrayToUnion<typeof userInfoFields>
                                     ~~~~~~~~~~~~~~~~~~~~~

Found 2 errors in 2 files.

Errors  Files
     1  src/http/httpHandler/httpHandler.ts:3
     1  src/queries/cloud/usersQuery.ts:16

You can remove that line, not sure why its there - I thought i removed it 😅.

@LuckFire You should now be able to compile your typescript project without skipLibCheck in openblox 1.0.29.
(Make sure you have the devDependencies installed) .

Sorry for the late reply, it does compile somewhat now, but on the latest version it seems like there's still some issues.
I can't import UserRestrictionsApi anymore and when I do compile, I run into this error:
node_modules/.pnpm/openblox@1.0.38_typescript@5.4.5/node_modules/openblox/dist/apis/cloud/index.d.ts:1:28 - error TS2307: Cannot find module './assets' or its corresponding type declarations.

1 export * as AssetsApi from "./assets";

If you need me to, I will make a separate issue

It looks like some exports were missing from ./apis/cloud/index.ts - no idea how that happened 😅. Anyways should be fixed now, let me know if you are still running into issues.

Only issue I'm running into now is the failing import for AssetsApi when the project is built

Ok should be fixed now. It turns out the .npmignore file was ignoring any folder called assets instead of just the assets folder at the root of the project. 😅
My apologies for the bother. 😅

No worries, I appreciate you resolving all of these issues (especially so quickly)! Everything seems to build flawlessly now, any future issues I have I'll create a separate issue for instead of commenting under this one again.
Again, I really appreciate the help 🙏🏼 super excited to use this package


MRG: better ICA docs

Closes #6588

[x] combine and overhaul ICA tutorials
[x] update ICA docstrings
[x] fix ica.plot_overlay titles (currently showing "average across all channels (Magnetometers, Gradiometers, EEG)" as the subplot title even when picks='eeg' or picks='mag')
[x] fix ica.plot_sources ("title" param is window title, not figure title, which conflicts with docs)

rendered tutorial: https://14431-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/preprocessing/plot_40_artifact_correction_ica.html
The graphviz diagram has the wrong fonts when building on the CircleCI server. I could have the server install the fonts before building, or I could pre-make the graph as PNG. Any opinions?

Here's the rendering of the revised ICA tutorial after incorporating @sappelhoff's comments:
https://14439-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/preprocessing/plot_40_artifact_correction_ica.html
I was successful in getting CircleCI to use the right fonts so (IMO) the diagram looks a lot better now!  Assuming I've fixed all the problems with Travis, this should be ready for review/merge.
@cbrnr @dengemann @jasmainak @jona-sassenhagen, care to weigh in?

Disclaimer: I have not looked closely at the wording/consensus on what everything means. But just looking immediately at the diagram, at first I was confused by the n_pca_components-n_components arrow, for two reasons:

I didn't realize that this left-to-right arrow and the right-to-left arrow both went to the ICA.apply() box. If it's easy to make the arrow heads bigger it will be more obvious.
I didn't realize what this component/data/whatever actually was. I wonder if we should call it something like:  PCA residual:
n_pca_components
 - n_components

It makes it clearer that the result of ICA.apply() is whatever the ICA found, minus exclude, plus whatever didn't go into the ICA.

Also when saying:

If you want to reduce the number of retained PCs used at the reconstruction stage, it is controlled by the n_pca_components parameter

maybe a parethetical that "... n_pca_components parameter, which will in turn reduce the rank of your data. However, this can be set to (and defaults to) max_pca_components, which ..." would help.
Again this might be way off, in which case just tell me and I'll look more closely on Monday :)

Can you add the refs to corrmap and ctps papers? Ctps is used in eog scoring
Thx

@SophieHerbst you may be interested in reading this

@jasmainak Can you look at the revised tutorial (section "ICA in MNE-Python") and diagram, and see if it clears up your questions?  And if not, LMK what is still unclear?
https://14566-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/preprocessing/plot_40_artifact_correction_ica.html#ica-in-mne-python

Something's wrong with the layout here (Chrome on macOS):

Furthermore, I don't like that most figures have a gray background - I think white looks much cleaner (and should be the default anyway).

When looking at this again, I am wondering whether we could also sneak in a short discussion on doing ICA on raw or epochs 🤔
What do you think? Can somebody point to a discussion of the pros/cons/caveats?
In the autoreject FAQ, there is a brief part where ICA is fit on epochs instead of raw: http://autoreject.github.io/faq.html#should-i-apply-ica-first-or-autoreject-first cc @jasmainak

Re raw vs. epochs, I think it depends on the use case. I typically exclude segments outside of specific events even though I work with raw data. Whether or not you transform the remaining data into epochs is a technicality IMO, the main question is if you use the complete data or just a subset.

@sappelhoff the rendering bug probably needs to be fixed in sphinx-gallery. Can you see if an issue exists yet, and if not, create it (with the screenshot)?  I've pushed a commit already that simply moves the sidebar up so it doesn't collide with the code box:

https://14567-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/preprocessing/plot_40_artifact_correction_ica.html
regarding ICA on epochs vs raw, I'm planning a tutorial in the Epoching section that covers all the various preprocessing steps (including ICA) that you might do either on Raw or Epochs and what the pros and cons are.
@cbrnr re: gray backgrounds see #6634
At this point I'd say ready for merge unless @jasmainak wants to chime in again

FYI the box overlap problem is a Sphinx->JQuery bug. I'm looking to see if it's easy to fix but the answer is probably no.

@drammock it's still not fully clear to me. These two sentences are very cryptic for me:

Then, when reconstructing the signal after excluding the Independent Components (ICs) that capture unwanted artifacts, the signal will be reconstructed from the retained ICs plus the retained PCs that were not included in the ICA step (the “PCA residual”). If you want to reduce the number of retained PCs used at the reconstruction stage, it is controlled by the n_pca_components parameter (which will in turn reduce the rank of your data).

The retained PCs that were not included in the ICA step -> that is max_pca_components - n_components but because we specify n_pca_components, it becomes n_pca_components - n_components ? How do you go from max_pca_components to n_pca_components ?
anyway, we can move on ... this is a complex concept.

this can be set to (and defaults to) max_pca_components, which ..." would help.

taking this quote from @larsoner 's comment above. I think this is important to mention, otherwise it's hard to realize this fact immediately

Also it's not clear to me --> do you use the PCA components from the fit in the apply or do you recompute the PCA components for the data during this stage?

The retained PCs that were not included in the ICA step -> that is max_pca_components - n_components but because we specify n_pca_components, it becomes n_pca_components - n_components ? How do you go from max_pca_components to n_pca_components ?

Say you have 300 channels and you set max_pca_components=200 and n_components=50 and n_pca_components=None. Then the PCA step yields 200 PCs, the first 50 PCs are sent to the ICA algorithm, yielding 50 ICs, and during reconstruction you use the 50 ICs and PCs number 51-200 (the full PCA residual).  If instead you specify n_pca_components=120 then you reconstruct using the 50 ICs plus the first 70 PCs in the PCA residual (numbers 51-120).

this can be set to (and defaults to) max_pca_components, which ..." would help.

taking this quote from @larsoner 's comment above. I think this is important to mention, otherwise it's hard to realize this fact immediately

OK cool, I can add that.

Also it's not clear to me --> do you use the PCA components from the fit in the apply or do you recompute the PCA components for the data during this stage?

The PCA from the fit stage is stored in ICA.pca_components_ after fitting. That is what gets used by apply during reconstruction.

@drammock adding a note (sidebar?) with the example you just gave with actual numbers is informative, too, if you want to add that while you're in there. @jasmainak :+1: 'ed your post so I'll go ahead and merge if you make the changes you mention there.

Looks good, will merge once CIs come back happy (restarted an errant Travis build)
https://14612-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/preprocessing/plot_40_artifact_correction_ica.html

Thanks @drammock !

Thanks a bunch @drammock I love your improvements to the docs!


Fix behaviour of locations for comments

Fixes https://github.com/ruby/yarp/issues/1443
This is a breaking change: Comments will no longer include the line break.
Co-authored with @kddnewton and @vinistock.

Looking into the failing CI jobs.