Getting TypeError in the log on each request

Even when just trying the first example ("simple usage"), I get the following exception on each request:
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/gevent/greenlet.py", line 534, in run
    result = self._run(*self.args, **self.kwargs)
  File "/usr/lib/python3.5/site-packages/gevent/baseserver.py", line 25, in _handle_and_close_when_done
    return handle(*args_tuple)
  File "/usr/lib/python3.5/site-packages/gevent/pywsgi.py", line 1253, in handle
    handler.handle()
  File "/usr/lib/python3.5/site-packages/gevent/pywsgi.py", line 443, in handle
    result = self.handle_one_request()
  File "/usr/lib/python3.5/site-packages/gevent/pywsgi.py", line 658, in handle_one_request
    self.handle_one_response()
  File "/usr/lib/python3.5/site-packages/gevent/pywsgi.py", line 916, in handle_one_response
    self.log_request()
  File "/home/admin/.local/lib/python3.5/site-packages/geventwebsocket/handler.py", line 236, in log_request
    if '101' not in self.status:
TypeError: a bytes-like object is required, not 'str'
<Greenlet at 0x7fda8555e048: _handle_and_close_when_done(<bound method WSGIServer.handle of <WSGIServer at , <bound method StreamServer.do_close of <WSGIServer, (<gevent._socket3.socket [closed]  object, fd=-1, )> failed with TypeError

the strange thing is, the http requests work fine. I did not try the websocket route yet, as I first wanted to know if I'm doing something wrong or is this a bug?

I also have same error. Is this because of we using python3?

I also have this error, I am also using python3.

I also confirm this with Python 3. Runs good with Python 2. I'll take a look.

Any update? I'm getting it on python3 also.

Maybe this would be a solution: https://www.mkyong.com/python/python-3-typeerror-str-does-not-support-the-buffer-interface/

the example seems to be incorrect, should be
       something = {'data':'test'}
       ws.send(message=json.dumps(something))

Still having this issue. It's 2020 and it breaks in python 3 -_-


unable to "Import resources from support files"

AS instructed in Step 3.1 in the document "Tutorial for ML pipeline.docx" here, unable to see the command option for the "+" --> Import resources from support files". Hence cannot proceed, please guide to resolve this issue.

Thanks for raising this issue. Import resources from support files is not an option in Synapse pipeline import at this time so we have updated the assets and docs to reflect this. Import from pipeline template will be the best option to use going forward.


Cannot use reflex-dom-contrib package

Hi, thanks for the cool project!
I'm trying to use reflex-dom-contrib library in the frontend, but after adding dependencies to frontend/frontend.cabal and ob run, buiding of reflex-dom-contrib fails. Looking at the errors, it seems like a dependencies error, but my nix knowledge is not good enough to figure out whats wrong. Is it not enable to use reflex-dom-contrib library?
frontend/frontend.cabal
library
  hs-source-dirs: src
  build-depends: base
               , common
               , reflex-dom
               , reflex-dom-contrib
               , static
               , text

Compile error log.
unpacking source archive /nix/store/1i0nd6sc8i3db52mgmjbi6gp6g8r3mid-reflex-dom-contrib-0.4.1.tar.gz
source root is reflex-dom-contrib-0.4.1
/nix/store/j1ly0zzpnzb8y8ry6k4vi4prk8vwq233-set-source-date-epoch-to-latest.sh: line 7: warning: command substitution: ignored null byte in input
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file reflex-dom-contrib-0.4.1/src/Reflex/Dom/Contrib/Xhr.hs
patching sources
compileBuildDriverPhase
setupCompileFlags: -package-db=/tmp/nix-build-reflex-dom-contrib-0.4.1.drv-0/package.conf.d -j4 -threaded
[1 of 1] Compiling Main             ( Setup.hs, /tmp/nix-build-reflex-dom-contrib-0.4.1.drv-0/Main.o )
Linking Setup ...
configuring
configureFlags: --verbose --prefix=/nix/store/17i361rvpxck5livxbq86il9a0ljjb97-reflex-dom-contrib-0.4.1 --libdir=$prefix/lib/$compiler --libsubdir=$pkgid --docdir=/nix/store/h1yh1nxqf0qksy7934hgr4x5w0lyhl9i-reflex-dom-contrib-0.4.1-doc/share/doc --with-gcc=gcc --package-db=/tmp/nix-build-reflex-dom-contrib-0.4.1.drv-0/package.conf.d --ghc-option=-optl=-Wl,-rpath=/nix/store/17i361rvpxck5livxbq86il9a0ljjb97-reflex-dom-contrib-0.4.1/lib/ghc-8.0.2/reflex-dom-contrib-0.4.1 --ghc-option=-j4 --disable-split-objs --disable-library-profiling --disable-profiling --enable-shared --disable-coverage --enable-library-vanilla --enable-executable-dynamic --enable-tests --ghc-option=-split-sections --ghc-options=-fexpose-all-unfoldings --extra-lib-dirs=/nix/store/sldddw66nndddmjf6knlla50ls5dkkxf-ncurses-6.0-20170902/lib --extra-lib-dirs=/nix/store/h9g62cvpviyhfp3v5k6qwb7k2pafg23a-gmp-6.1.2/lib --extra-include-dirs=/nix/store/hfz0613rjr8xi7pjh4p726rc2hqxf063-gobject-introspection-1.52.1-dev/include --extra-lib-dirs=/nix/store/hfz0613rjr8xi7pjh4p726rc2hqxf063-gobject-introspection-1.52.1-dev/lib --extra-include-dirs=/nix/store/pkizaxn4gf1syfcxnvwrhgadavyw44i8-libffi-3.2.1-dev/include --extra-lib-dirs=/nix/store/pkizaxn4gf1syfcxnvwrhgadavyw44i8-libffi-3.2.1-dev/lib --extra-lib-dirs=/nix/store/8wrrm4r593y99wbdzfjzn7jq1xwc28gl-libffi-3.2.1/lib --extra-include-dirs=/nix/store/4n65jqwiq1gfvwv722pqc2iki3hch7if-glib-2.52.3-dev/include --extra-lib-dirs=/nix/store/4n65jqwiq1gfvwv722pqc2iki3hch7if-glib-2.52.3-dev/lib --extra-include-dirs=/nix/store/h28hdpi9gib4v6f456f5s4281pw22glf-zlib-1.2.11-dev/include --extra-lib-dirs=/nix/store/h28hdpi9gib4v6f456f5s4281pw22glf-zlib-1.2.11-dev/lib --extra-lib-dirs=/nix/store/qjsk4rzv57c3jpdqw5dz36rv2bmxmm4x-zlib-1.2.11/lib --extra-include-dirs=/nix/store/bjhzi3g63ykjlf2zsxm978jkkj5hz0i3-glibc-iconv-2.25-49/include --extra-lib-dirs=/nix/store/swfsmkyb5ls0r8z05q5akq18aafjynw5-glib-2.52.3/lib --extra-lib-dirs=/nix/store/krivj6rixcs7kadxjlyh566kmvh5q0xg-gobject-introspection-1.52.1/lib
Configuring reflex-dom-contrib-0.4.1...
Setup: Encountered missing dependencies:
aeson >=0.8 && <0.11,
base >=4.6 && <4.9,
bifunctors >=4.0 && <5.3,
data-default ==0.5.*,
ghcjs-dom ==0.2.*,
lens >=4.9 && <4.14,
reflex >=0.2 && <0.5,
reflex-dom >=0.2 && <0.4
builder for '/nix/store/7kc29n45hgzrr7zin86cmg0bzl1969lv-reflex-dom-contrib-0.4.1.drv' failed with exit code 1
cannot build derivation '/nix/store/cyp5ndy4r6kj5vscsfkdadzilhnw8m2q-ghc-8.0.2-with-packages.drv': 1 dependencies couldn't be built
error: build of '/nix/store/cyp5ndy4r6kj5vscsfkdadzilhnw8m2q-ghc-8.0.2-with-packages.drv' failed

If a package is not available, you can specify an override for it in your project's default.nix. Here's an example for specifying the beam package.
We just need to document how to do this so users can discover it easily.

As for getting reflex-dom-contrib working in particular you might be interesting in these overrides.

Thank you! Now able to compile.

Resolved and documented via #62


Several questions when running codes

Hello, i have a few  questions when i try to run the project.
question1 : After I run controller.py in ryu, I stuck to this step for 8 hours:

what does the last sentence mean?and the ryu manager output nothing after i launched ICMP flood in mininet.
Question2 : How can i get "PredictFlowStatsfile.csv" to predict flow?
Question3 : How can I change learning methods in controller.py and how can i use ml.py?
I would greatly appreciate it if you could provide some guidance on how to resolve these issue. Thank you for your time and for sharing your code with the community.

And i ran topology.py then tried "pingall" in mininet , the hosts can not reach each othe. Then  I used command"sudo mn -c" but it didn't work, do you have any suggestions for it?.( I used Ubuntu18.04 ,python 3.6)

Hello @Marvelous-coco ,
Answer 1:
The last sentence in your message refers to the script importing the package. It's not stuck; rather, it's running in the background. You can now proceed to perform attacks and observe the detected and mitigated traffic. As for the Ryu manager, if it's not outputting anything after you launched the ICMP flood in Mininet, you might want to check the configuration or logs to troubleshoot the issue. Keep an eye on the Ryu manager's logs or console output for any relevant information.
Check if mininet is connected properly.
Answer 2: You can get predictflow.csv here->
https://drive.google.com/file/d/1N2QLDPb90XOdxcuQ_Fb7ZSVOG4J3w_zY/view
Answer 3:
There separate script for different methods ex: knn.py, rf.py, you can also check dump folder

And i ran topology.py then tried "pingall" in mininet , the hosts can not reach each othe. Then I used command"sudo mn -c" but it didn't work, do you have any suggestions for it?.( I used Ubuntu18.04 ,python 3.6)

Have you changed mininet ip with your mininet ip?

And i ran topology.py then tried "pingall" in mininet , the hosts can not reach each othe. Then I used command"sudo mn -c" but it didn't work, do you have any suggestions for it?.( I used Ubuntu18.04 ,python 3.6)

Have you changed mininet ip with your mininet ip?

Yes, I replaced the controller ip with my own ryu controller ip, while keep the hosts and switches ip the same as your settings.

And i ran topology.py then tried "pingall" in mininet , the hosts can not reach each othe. Then I used command"sudo mn -c" but it didn't work, do you have any suggestions for it?.( I used Ubuntu18.04 ,python 3.6)

Have you changed mininet ip with your mininet ip?

Yes, I replaced the controller ip with my own ryu controller ip, while keep the hosts and switches ip the same as your settings.

Can you share your machine details: OS, whether your are using VM, etc

And i ran topology.py then tried "pingall" in mininet , the hosts can not reach each othe. Then I used command"sudo mn -c" but it didn't work, do you have any suggestions for it?.( I used Ubuntu18.04 ,python 3.6)

Have you changed mininet ip with your mininet ip?

Yes, I replaced the controller ip with my own ryu controller ip, while keep the hosts and switches ip the same as your settings.

Can you share your machine details: OS, whether your are using VM, et

Thank you for your kindly response!!!!
I re-installed mininet and the nodes are reachable now. Then I lauched DDos attack using hping, and the ryu manager successfully detected the attack, but it seemed that the minigation module not working, I waited 15 minutes and there was no log"Mitigation process in progress!" , is that normal?

Hello！Thank you for your kindly reply! But I still can't see the attack be mitigated after I run KNN_controller.py and minigation_module.py.


Add support for MSS570x dimmer switch

Would it be possible to add support for Meross MSS570x 3 way smart dimmer switch? The current version works for my light switch but does not support the dimming function. Really appreciate your work on this and happy to contribute how I can!

Also, it looks like this was done for a mss560 switch already, is it possible for me to just classify the switch as a 560 to get the brightness controls?

See #151

Also, it looks like this was done for a mss560 switch already, is it possible for me to just classify the switch as a 560 to get the brightness controls?

FYI, I set my 570 as a 560, and the dimmer functionality works in the Home app.

Also, it looks like this was done for a mss560 switch already, is it possible for me to just classify the switch as a 560 to get the brightness controls?

FYI, I set my 570 as a 560, and the dimmer functionality works in the Home app.

How did you set it as a 560?

Also, it looks like this was done for a mss560 switch already, is it possible for me to just classify the switch as a 560 to get the brightness controls?

FYI, I set my 570 as a 560, and the dimmer functionality works in the Home app.

How did you set it as a 560?

I just chose the 560 in the homebridge Meross plug-in config, instead of the 570.

@zpeters90 I have added the mss570x as an option in the latest beta, if you could try it and let me know how it works. it will show up as a light bulb.
Beta: 4.0.1-beta.12


In Service-Count, check up front that files produced by Service-Parse are present

Currently will die at line 208 of count_day_tasks.py, since outputs_path / f'{circle_prefix}Single.xlsx' not present.

[main c5a795e]

[main c5a795e]


feat(OCPADVISOR-135): workload detail page header

OCPADVISOR-135

Header for Workload detail page

:tada: This PR is included in version 1.24.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[librealsense]Update the README.md file

To align the format of README.md with other modules' README.

@kenny-y PTAL, thanks!


[LOC] Invalid links in an article

There is an invalid link in an article
Repro steps:

Go to https://docs.microsoft.com/en-us/microsoftteams/create-a-phone-system-auto-attendant?bc=/skypeforbusiness/breadcrumb/toc.json&toc=/skypeforbusiness/sfbotoc/toc.json
Search for "New-CsOnlineTimeRange", "Export-CsAutoAttendantHolidays", "Get-CsAutoAttendant"
Click on the link

Actual results:
Link does not work
Expected results:
Link should either work or be removed
GH article:
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/blob/live/Teams/create-a-phone-system-auto-attendant.md

@OfficeGlobal @ Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@officedocsbot assign @scanum

@OfficeGlobal Done.

@OfficeGlobal Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

@OfficeGlobal Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


"static)" at startup column at Ubuntu - should remove bracket and get rid of static services

fixed @ 0.0.34


Locale Dropdown is empty on first login

Link to reproduction
No response
Payload Version
3.62
Node Version
18.17.2
Next.js Version
latest
Describe the Bug
I'm logging into payload cms. I click around, all is fine. Trying to change the locale, that field is empty. Only upon "full" fresh the locales is populated.
image
Reproduction Steps
Login to a fresh session. Dont refresh. Click the locale dropdown.
Adapters and Plugins
No response

Hey @nexflo - could you please send me how you are defining your locales in your payload config?
Thank you!

Hey @PatrikKozak certainly:
We created a locales.ts with the following the content:
export const locales = [
  {
    label: "Default (English)",
    code: "en",
  },
  {
    label: "Austria",
    code: "de-AT",
  },
  {
    label: "Belgium (Dutch)",
    code: "nl-BE",
  },
  {
    label: "Belgium (French)",
    code: "fr-BE",
  },
  {
    label: "Croatia",
    code: "hr-HR",
  },
  {
    label: "Czech Republic",
    code: "cs-CZ",
  },
  {
    label: "Denmark",
    code: "da-DK",
  },
  {
    label: "Estonia",
    code: "et-EE",
  },
  {
    label: "Finland",
    code: "fi-FI",
  },
  {
    label: "France",
    code: "fr-FR",
  },
  {
    label: "Germany",
    code: "de-DE",
  },
  {
    label: "Greece",
    code: "el-GR",
  },
  {
    label: "Hungary",
    code: "hu-HU",
  },
  {
    label: "Italy",
    code: "it-IT",
  },
  {
    label: "Latvia",
    code: "lv-LV",
  },
  {
    label: "Lithuania",
    code: "lt-LT",
  },
  {
    label: "Netherlands",
    code: "nl-NL",
  },
  {
    label: "Norway",
    code: "no-NO",
  },
  {
    label: "Poland",
    code: "pl-PL",
  },
  {
    label: "Portugal",
    code: "pt-PT",
  },
  {
    label: "Romania",
    code: "ro-RO",
  },
  {
    label: "Slovakia",
    code: "sk-SK",
  },
  {
    label: "Slovenia",
    code: "sl-SI",
  },
  {
    label: "Spain",
    code: "es-ES",
  },
  {
    label: "Switzerland (German)",
    code: "de-CH",
  },
  {
    label: "Switzerland (French)",
    code: "fr-CH",
  },
  {
    label: "Ukraine",
    code: "uk-UA",
  },
  {
    label: "United Kingdom",
    code: "en-GB",
  },
];

this gets imported in the payload config:
import { locales } from "@/locales";
and added as such:
  localization: {
    locales,
    defaultLocale: "en",
    fallback: true,
  },

@nexflo thank you! I'll be taking a look into this!

@nexflo Can you do me a favor and update your project to the latest beta version (v3.0.0-beta.81) and give this another go?
On a fresh new project on latest, I'm unable to reproduce the behavior - we've made some updates to localization since v3.0.0-beta.62 so the issue may have already been fixed.
Let me know how that goes!

@PatrikKozak thanks for looking into this! @nexflo forgot to mention an important part to this, we are customizing the options based on the current user. It seems that directly after login useAuth doesn’t work in our custom component.
I’ve created a repro for it with auto login disabled. https://github.com/carlcs/payload/tree/repro/no-user-after-login

It’s fixed https://github.com/payloadcms/payload/pull/7727

As mentioned by @carlcs - #7727 fixes this issue - closing this issue for now.


Added 'id_token' property to TokenResponse

As it's only one property at the json response it works just fine. I've testested it one API in production and it worked like a charm.

I signed it!

Thanks for the PR :) If no-one else picks this up first, I expect I'll be able to look at it next week.

Please can you include in the comment something like:
"Gets or sets the id_token, which is a JSON Web Token (JWT) as specified in http://tools.ietf.org/html/draft-ietf-oauth-json-web-token"
Thanks.

I've commitd with the comment :)


Using Get.create() leads to an error when trying to call Get.find()

On version get 4.0.0-nullsafety.2 when I'm trying to use Get.find I'm getting the following error:
The following _CastError was thrown building Obx(dirty, state: _ObxState#d32ed):
type '_InternalFinalCallback<void>' is not a subtype of type 'Function' in type cast

The relevant error-causing widget was:
  Obx file:///Users/olegpryshlyak/getx_cast_test/lib/main.dart:50:13
When the exception was thrown, this was the stack:
#0      GetInstance._startController (package:get/get_instance/src/get_instance.dart:292:56)
#1      GetInstance._initDependencies (package:get/get_instance/src/get_instance.dart:239:11)
#2      GetInstance.find (package:get/get_instance/src/get_instance.dart:327:17)
#3      GetView.controller (package:get/get_state_manager/src/simple/get_view.dart:38:37)
#4      MyHomePage.build.<anonymous closure> (package:getx_cast_test/main.dart:52:20)
...

But the same code works fine when I'm using get 3.26.0 version.
Sample project:
import 'package:flutter/material.dart';
import 'package:get/get.dart';

void main() {
  runApp(MyApp());
}

class AppBindings extends Bindings {
  @override
  void dependencies() {
    Get.create(() => Controller());
  }
}

class Controller extends GetxController {
  final RxInt counter = 0.obs;
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return GetMaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      getPages: [
        GetPage(name: 'home', page: () => MyHomePage(), binding: AppBindings()),
      ],
      initialRoute: 'home',
    );
  }
}

class MyHomePage extends StatelessWidget {
  final Controller controller = Get.find();
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("test"),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              'You have pushed the button this many times:',
            ),
            Obx(
              () => Text(
                '${controller.counter.value}',
                style: Theme.of(context).textTheme.headline4,
              ),
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () {
          controller.counter.value += 1;
          print(controller.counter.value);
        },
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

I got same issue here.
/// Internal callback that starts the cycle of this controller.   **final onDelete = _InternalFinalCallback<void>();**
   /// Initializes the controller   S? _startController<S>({String? tag}) {     final key = _getKey(S, tag);     final i = _singl[key]!.getDependency() as S?;     if (i is GetLifeCycleBase) {       i.onStart();       if (tag == null) {         Get.log('Instance "$S" has been initialized');       } else {         Get.log('Instance "$S" with tag "$tag" has been initialized');       }       if (!_singl[key]!.isSingleton!) {         _routesByCreate[Get.reference] ??= HashSet<Function>();         _routesByCreate[Get.reference]!.add(**i.onDelete as Function**);       }     }     return i;   }
onDelete is a  _InternalFinalCallback type  and it cannot cast to Function

any updates for this issue? or I have to back to version 3.26.0 and run with no-sound-null-safety :(

Change
class MyHomePage extends StatelessWidget {
  final Controller controller = Get.find();

to
class MyHomePage extends GetWidget<Controller> {
 // final Controller controller = Get.find(); take it out

You also could use Get.put instead of Get.create

I was having the same issue as originally reported by @ProfesorUA. I have just upgrade from 4.0.0-nullsafety.2 to 4.1.1.
I am now getting the following error:
`══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following TypeErrorImpl was thrown building PlatformsTable(dirty):
Expected a value of type 'DynamicTableController', but got one of type 'Null'
The relevant error-causing widget was:
PlatformsTable
file:///Users/x/Projects/widget/widget_ui/lib/common/app/widget_app.dart:30:51
When the exception was thrown, this was the stack:
dart-sdk/lib/internal/js_dev_runtime/private/ddc_runtime/errors.dart 236:49      throw
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 84:3        castError
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 442:10  cast
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/classes.dart 635:14     as_C
packages/get/get_state_manager/src/simple/get_view.dart 56:46                     get controller
packages/widget_ui/controls/dynamic_table/views/dynamic_table.dart 19:16          new
packages/widget_ui/pages/platforms/views/platforms_table.dart 35:12               build
packages/get/get_state_manager/src/simple/get_view.dart 103:12                    build
packages/get/get_state_manager/src/simple/get_widget_cache.dart 29:27             build
packages/flutter/src/widgets/framework.dart 4495:15                               performRebuild
packages/get/get_state_manager/src/simple/get_widget_cache.dart 35:11             performRebuild
packages/flutter/src/widgets/framework.dart 4189:5                                rebuild
packages/flutter/src/widgets/framework.dart 4474:5                                [_firstBuild]
packages/flutter/src/widgets/framework.dart 4469:5                                mount
packages/get/get_state_manager/src/simple/get_widget_cache.dart 25:11             mount
packages/flutter/src/widgets/framework.dart 3541:13                               inflateWidget
packages/flutter/src/widgets/framework.dart 3306:18                               updateChild
packages/flutter/src/widgets/framework.dart 4520:16                               performRebuild
`
My code:
`
class DynamicTableBinding implements Bindings {
@override
void dependencies() {
Get.put(DynamicTableService());
Get.create(()=>DynamicTableController());

}
}
`
class DynamicTable extends GetWidget<DynamicTableController> {
I need to use Get.create for my specific use case.

Change
class MyHomePage extends StatelessWidget {
  final Controller controller = Get.find();

to
class MyHomePage extends GetWidget<Controller> {
 // final Controller controller = Get.find(); take it out

That's exactly what I implemented, but the issue was about cast '_InternalFinalCallback' to 'Function' property

I just updated to Getx v4.0.0, as I can see you fixed this issues,
I think we can close this issue now.


Item Level scaling innacurate with WOD & legion gear - possible fix for DE info

With the introduction of item upgrades late in MoP carrying through Wod and into Legion and beyond, getItemInfo(0 no longer offers accurate item level scaling information. This means that the disenchant information, which relies on item level or armor and weapons to calculate what mats are DE'd, will no be accurate from MoP gear onward.
A library has been created to handle the complexities of item level scaling.
http://www.wowace.com/addons/libitemupgradeinfo-1-0/
This has been talk around different forums for a while and the consensus seems to be to use this library. It does not rely on ace libraries outside of libstub.
To accomplish accurate scanning of gear and displaying proper disenchanting information, here is what I am testing:
Download libitemupgradeinfo
Make a folder in the root of Auctionator called Libs
Put the extracted folder LibItemUpgradeInfo-1.0 into it (containing the folder and files for LibStub and the library files)
In Auctionator.toc, add the following before Locales
Libs\LibItemUpgradeInfo-1.0\LibItemUpgradeInfo-1.0.xml
In AuctionatorHints.lua after line 6 add
local ItemUpgradeInfo = LibStub("LibItemUpgradeInfo-1.0")
after line 1007 )1008 after you add the library link)
(after this local itemName, itemLink, itemRarity, itemLevel, itemMinLevel, itemType, _, _, _, _, itemVendorPrice, classID = GetItemInfo (link);)
add
itemLevel = ItemUpgradeInfo:GetUpgradedItemLevel(itemLink)
Why do this? Because in AuctionatorHinst.lua there is a database table created using item levels of gear to calculate what mats they DE into. After somewhere above item level 500ish (around SOO), these start to become wildly inaccurate and can report he level wrong if near the cusp of an item level range for an expansion. Meaning item level 750 gear can report as say 715 thus being under the range for WoD gear and reporting the wrong mats.
Using this library means you get a better estimate of items and thus more accurate disenchanting information.
Some reference posts:
http://www.wowinterface.com/forums/showthread.php?t=52889
http://www.wowinterface.com/forums/showthread.php?t=46543
http://www.wowinterface.com/forums/showthread.php?t=45388
http://us.battle.net/wow/en/forum/topic/7199032730#9

Thanks for all the great research and work on this issue!  Most recent build has this included, and appears to be working for me.  😄


[backport] cawbird: 1.1.0 -> 1.2.1

regular version bump to 1.2.0, then bugfix release on top
changes: see

https://github.com/IBBoard/cawbird/releases/tag/v1.2.0
https://github.com/IBBoard/cawbird/releases/tag/v1.2.1

backport of #97230
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build cawbird

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/304

@schmittlauch FYI your git email is not connected to your GitHub account, that's why your commits have no links to your user name: https://github.com/NixOS/nixpkgs/pull/98326/commits/6f77ca14058e60c3c6e27db73e6daad86a837c17 .

@doronbehar thx, fixed the e-mail issue.


AzureCloudDeploy: Azure Deployment not found, but then cannot be created

Required Information
Type: Bug
Enter Task Name: Azure Cloud Deploy
https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/AzureCloudPowerShellDeploymentV1
Environment

Server - Azure Pipelines

account name: macydrive
team project name: arttoremember_services
build definition: arttoremember-service-test cloud service
build numbers: 20190904.6

Agent - Hosted

agent spec: vs2017-win2016
agent pool: Azure Pipelines

Issue Description
When running the Azure Cloud Deploy task in Azure DevOps, there seems to be an issue with retrieving an existing deployment slot in a classic Azure Cloud Service. Thus, the task is only runnable the first time, when deploying a new slot. Subsequent executions throw the error:
ConflictError: The specified deployment slot Production is occupied.
I believe the issue to be with line #104 in the powershell file:
https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/AzureCloudPowerShellDeploymentV1/Publish-AzureCloudDeployment.ps1
Based on the logs, it appears that $azureDeployment is coming back as null and always attempting to call New-AzureDeployment as opposed to Set-AzureDeployment.
Is it possible that there's something wrong with my config?
If it matters, the task did successfully create the deployment the first time, as you can see from the following screenshot:

Task logs
log_12_2089.zip
Error logs
[error]ConflictError: The specified deployment slot Production is occupied.
OperationID : '7ee752c0806c09e280f7fe3d7222f334'

As error mentioned that a deployment already exists then Get-AzureDeployment cmdlet shouldn't have returned null.
Can you please try the following steps :

Run Get-AzureDeployment cmdlet with verbose and debug arguments

Get-AzureDeployment -ServiceName arttoremember-service-test -Slot Production -verbose -debug

Delete the service once and retry the deployment multiple time.

@christineLDavis Have you tried the comment mentioned above ?

Feel free to reopen the issue, if you face any.


Nested label not working with view component

Steps to reproduce
Create view component
    <%= render Shared::Inputs::ToggleComponent.new(object_name: f, method: :debit_enabled,
                                                   value: advertiser.wallet.debit_enabled,
                                                   label_text: t('.debit_enabled')) %>

class Shared::Inputs::ToggleComponent < ViewComponent::Base
  attr_reader :object_name, :method, :value, :label_text
  def initialize(object_name:, method:, value:, label_text:)
    @object_name = object_name
    @method = method
    @value = value
    @label_text = label_text
  end

end

<%= object_name.label method.to_sym, class: 'relative inline-flex items-center cursor-pointer' do %>
  <%= object_name.check_box method.to_sym, class: 'sr-only peer', checked: value %>

  <%= content_tag :span, label_text, class: 'ml-3 text-sm font-medium text-gray_dark' %>
<% end %>

Input, div and span should be nested but it does not.

Expected behavior

It should be nested like this:

Actual behavior
Input, div and span should be nested inside label.

Backtrace:
System configuration
Rails version:
Rails 7.0.4
Ruby version:
ruby '3.1.0'
Gem version:
view_component (2.74.1)

Hi! Please try enabling the capture_compatibility_patch_enabled option, it should fix this issue.

First I created new file for configuration:
# config/initializers/view_components.rb
Rails.application.configure do
  config.view_component.capture_compatibility_patch_enabledasd = true
end

I didn't resolved the problem.
Then I added
  config.view_component.capture_compatibility_patch_enabledasd = true

into
config/environments/development.rb
But it also didn't fix the problem.
I also updated view component to
view_component (2.82.0)
I restarted the app and still have the problem with rendering nested label.

@mateuszbialowas there seem to be a typo in your code:
-  config.view_component.capture_compatibility_patch_enabledasd = true
+  config.view_component.capture_compatibility_patch_enabled = true

@mateuszbialowas  do you know if the change  @Spone recommended has fixed your issue.

I created file
config/initializers/view_component.rb
Rails.application.configure do
  config.view_component.capture_compatibility_patch_enabledasd = true
end

And now it is working. Thank you.

Sorry, the problem still occurs with the form helpers.
https://github.com/mateuszbialowas/ogloradar/pull/20/files
I created PR with my implementation. Maybe it will be easier to debug.

The related PR having been closed, I'm closing this.


How to get value from the Editor?

I want to know how to get value from editor and pass it to somewhere (to console for example)?
here's my Editor looks like
     <Editor
        onUpdate={() => {
          setSaveStatus('Unsaved')
        }}
        defaultValue=""
        onDebouncedUpdate={() => {
          setSaveStatus('Saving...')
          setTimeout(() => {
            setSaveStatus('Saved')
          }, 500)
        }}
        disableLocalStorage
      />

After doing some trials, I found the answer. I just need to do a little modification
 onUpdate={(e: any) => {
     setSaveStatus('Unsaved')
     console.log(e.getJSON())
     console.log(e.getHTML())
 }}


Misc test cleanup

What
Fix some test cleanup/ignore issues.
How
The CouchClientWrapperTest.accessAndUpdateRemoteDbWithSlashInName() test set a new value to the remoteDb field during the test. This meant the DB that test created was cleaned up by the teardown() method, but the DB created by the setup and initially assigned to the remoteDb field was never removed.
Update the .gitignore naming for the copied test fixtures so that they don't show up as changes. This rename was missed as part of #193.
Testing
No new tests needed.
reviewer @rhyshort

+1


Change created virt-v2v conversion output to -o kubeVirt

Currently, the output produced by virt-v2v is in libvirt XML format. However, since we are working with KubeVirt VMs and in light of recent changes by the virt-v2v team to add missing fields to the YAML output, we are switching the output format to -o kubevirt. This change will allow us to use this information to create the VM in OpenShift and capture some missing fields about the VMs. As part of this update, if a VM name is not valid, we will generate a new name and pass it to the conversion pod, where it will be updated as part of the virt-v2v command, as well as within the migration controller.

@mnecas @yaacov There was a conflicts with some of the recent changes. Can you please verify that nothing is missing with the switch to the YAML file? Thanks!

Can you please verify that nothing is missing with the switch to the YAML file? Thanks!

The xml to yaml converion in entrypoint file, looks good to me :+1:

Continuing the PR in the https://github.com/kubev2v/forklift/pull/1020
I have rebased it with the latest virt-v2v wrapper changes and made some additional changes
Closing


i forgot about gemoji

Fix RM-XYZ

🧰 Changes
Updates Gemoji for new Font Awesome classes
No good:
.fa.fa-house
Now good:
.fa-regular.fa-house
🧬 QA & Testing

Broken on production.
Working in this PR app.

This PR was released!
🚀 Changes included in v7.6.0


It seems 'tags' doesn't work properly for 'path.Both([predicatePath], [tags])'

It seems 'tags' doesn't work properly for path.Both([predicatePath], [tags]), refer the test case here path.Both([predicatePath], [tags]): line 493, which the res will be:
{ result: [ { id: '</user/shortid/23TplPdS>' } ] }

no tag there.

@lnshi Thanks for your report!


Is editing the plugin the only way to customize the scanner UI?

Is editing the plugin the only way to customize the scanner UI?
What is the recommended way to modify the UI?

Would love a way to customize the UI overlay. Thanks!

It seems there is no way to customize anything. I would be nice to really embed the preview mask into an existing view. So far I have only successfully done that in Windows apps.
All the mask and strings come from the zxing library used here.

@danielnbarros currently yes it is. There are enhancement issues open to add customization.


Prevents System.InvalidOperationException.

This PR forces PipeServer.Enqueue to wait until PipeServer.Start is called. This prevents  System.InvalidOperationException from occurring.
(Note, this is a replacement for https://github.com/rickbutton/workspacer/pull/180)

Thanks for another patch!


sql server backplane for signalr core

When will signalR sql server backplane be released for dotnet core?
Is there a roadmap of signalR core?

@SebaVDPInfra - why do you need SqlServer (as opposed to e.g. Redis)?

We're not planning to implement this for 1.0, so backlogging.
cc @DamianEdwards

Any thoughts around cost of entry? Our current topology includes Azure SQL but to also include Redis with data persistence is a massive initial outlay so that we can have SignalR.

it wouldn't be that much work. We'd start by porting the old scale out back end. It's just a very very bad way to do real time notifications as that's not what sql was meant for.

Thanks @davidfowl. Completely agree with SqlServer being the wrong fit when at scale. For smaller user counts it still does the job. Once I reach a point where SQL no longer supports my scale, I can justify the Redis costs for the entire platform - it was just a thought that might be shared by others as SignalR gains more visibility approaching its release.

You can add my name to the list of users that would be interested in a SQL Server option.

Will this feature come soon?? :see_no_evil:

We still have no current plans to build a SQL Server backplane.
It would help us prioritize if we could understand why a SQL Server backplane would help you. SQL isn't really designed for this purpose (real-time pub/sub). A SQL Server backplane would require that your server support the Service Broker (to provide notifications of changes to the database) which requires the much significantly more expensive Azure SQL Database/Managed Instances tier, or a local on-premises Enterprise edition of SQL Server.
Is this about fitting in to existing infrastructure or is there some value that you feel SQL Server will add over Redis or the Azure SignalR Service?

Does ASP.NET Core SignalR supports Redis Cluster?
In scaleout-with-redis there is a note says SignalR scaleout with Redis does not support Redis clusters., which is for ASP.NET SignalR.
But for ASP.NET Core SignalR, there is no document for that.

For our part, we need a backplane that works on-premise, in a Windows environment in order to support on-premise Service Fabric clusters. We don't want to manage any form of Linux installation, so Redis is out (we don't trust the archived Windows port). Our customers are not ready to move to the cloud, so Azure Service Bus is out (Azure Stack is also cost-prohibitive for us). Windows Service Bus is dead. The possibility of a Service Fabric backplane was rejected.
Given these constraints, a SQL Server backplane seems like our only option at the moment.  If SQL is not the right tool for the job, so be it, but it would be nice to have something that works on a local Windows install. It's weird to me that a technology which started on Windows wouldn't have this support in its core.

Are you also opposed to an in-container implementation of Redis due to your desire to avoid Linux? SQL isn't as good a backplane as is Redis, frankly, due to the nature and performance of the two architectures Redis is definitely preferred.
So is the Redis-in-container also not acceptable?

We don't have experience with containers but I'll concede that would be one way to work around the issue. It would be a wart in our architecture as we are using containers nowhere else. Overall we're not thrilled as a Microsoft shop to use a technology that has Windows nowhere on its radar. Honestly, I think if this was our only choice we would sooner roll our own backplane.

I think you make a good point.
The use of a container just to act as a backplane is a workaround.  Yes, it
would work.  But no one would architect a solution in a manner that only
uses a container for this one specific purpose.  I know there is the
obvious answers of just standing up Linux.  But there again, I fail to see
that supporting a heterogeneous environment for the sake of a backplane
would be at the top of the list for those designing their solutions.  In
all of these scenarios I am just left with the argument around performance
and the idea that Redis is the better or proper tool for this job.  I have
no arguments on that statement at all.  But, you know sometimes I can use
a rock to hammer a tent post into the ground even though it’s not a
hammer.  In the same way, some applications may need multiple
servers/instances of their application running because of availability
requirements and not because the load is so great that a single
server/instance would not do the job.  And in those cases a SQL server
backend will get the job done.
Rick
On Thu, Oct 25, 2018 at 3:57 PM abarger-bss<EMAIL_ADDRESS>wrote:

We don't have experience with containers but I'll concede that would be
one way to work around the issue. It would be a wart in our architecture as
we are using containers nowhere else. Overall we're not thrilled as a
Microsoft shop to use a technology that has Windows nowhere on its radar.
Honestly, I think if this was our only choice we would sooner roll our own
backplane.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/SignalR/issues/357#issuecomment-433202977, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AWdGtkbu4RlLh-6fZUrfyZqw_Z-kWdWjks5uoiW5gaJpZM4MvZ6W
.

The content of this email is limited to the matters specifically addressed herein and is not intended to address other potential tax consequences or the potential application of tax penalties to this or any other matter.

The information transmitted, including any attachments, is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited, and all liability arising therefrom is disclaimed. If you received this in error, please contact the sender and delete the material from any computer. PricewaterhouseCoopers LLP is a Delaware limited liability partnership.  This communication may come from PricewaterhouseCoopers LLP or one of its subsidiaries.

So let me pose this question: If we gave you an exe you could run that wasn't highly available but worked well enough to support signalr on multiple nodes that you had to run in your local on-premise environment, would that be sufficient?

Maybe. In this scenario, is the exe managing the storage for the backplane? Would a package for integrating with the exe be provided (Similiar to Microsoft.AspNet.SignalR.Redis)? Keep in mind that we're looking for something we can deploy to production on-premise clusters - our use case is more than dev/test. I suppose the lack of high availability could be mitigated by deploying this exe as a guest executable in the cluster.
What is the benefit to this product of providing an exe instead of code to integrate with an existing Windows product?
I don't mean to belabor this point, but we're not stuck on the idea of SQL Server as a backplane. We are committed to any backplane which supports production, on-premise Windows deployments. Maybe this needs a separate issue - I mostly presented our scenario in response to @anurse  's request.

The backplane’s job isn’t storage, it’s to get messages to the subscribers. It’s volatile and transient storage, just to push the messages to other nodes.
It would be lighter weight, faster, it would avoid polling and persistent storage that requires clean up (as sql would).

I see your point. Yes, this would work for us assuming the exe is Windows compatible and the ability to scale out is somewhere on the horizon as an enhancement. I wonder if what you're describing here ties into #968, which I'm just now seeing. I see the value in a product custom-built to be a backplane for SignalR.
The only consideration left for me then is timeline - If porting the old SQL backplane could be released ~6 months sooner than a new product, I think we'd still rather have it and live with the consequences in the interim. Bird in the hand etc.

A SQL Server backplane would require that your server support the Service Broker (to provide notifications of changes to the database) which requires the significantly more expensive Azure SQL Database/Managed Instances tier, or a local on-premises Enterprise edition of SQL Server.

Service Broker is supported in SQL Server Standard Edition.
https://docs.microsoft.com/en-us/sql/sql-server/editions-and-components-of-sql-server-2017?view=sql-server-2017
The reason would be in the very common scenario where an application is already using a Microsoft SQL server plus an arbitrary number of load balanced API servers, it would be nice to use the existing SQL server and not have to set up an additional box just for Redis.

Service Broker is supported in SQL Server Standard Edition.

Good to know! It still remains true that SQL Server was always a most costly and less efficient way to run a backplane. It's not yet clear to me if people want a SQL Server backplane or just a Windows On-Premise backplane. The APIs are also very simple and extensible (the Redis implementation is a single core class with a couple small helpers and quite readable IMO). As @davidfowl said, releasing something is one thing, maintaining it is bigger concern. The SQL Server backplane for ASP.NET SignalR has a history of consuming significant resources on the SQL server, so we need to be careful about how to move forward with it.

@anurse I don't disagree SQL server isn't necessarily the best backplane in the abstract (indeed, I've had a lot of trouble with it in SignalR in ASP.NET-not-core - and debugging on localhost with it is next to impossible - but it is functional). But again it's just a matter of not wanting to force my customers to deploy a dedicated Linux box on top of an already complex (all Windows) infrastructure. So it's not a matter of preferring or disliking Linux, it's that we have customers who have invested heavily in MS proprietary tech like SQL Server and Windows and want to continue exploiting those investments before moving to Linux and/or the cloud.
Would it not be possible to handle the issue in a peer-to-peer fashion? All the load-balanced servers could broadcast all SignalR messages to each other for routing to their respective connected clients? In principle that wouldn't be all that different from backplaning, which as I understand it means that each server sending an outgoing message hits common database and the database in turn notifies all the other connected servers of the message so they can also send it to their own connected clients. Why not just skip the middle man? The database could just be utilized so the servers could be aware of each others' existence (registering their IP address, etc.) with the rest handled P2P.

But again it's just a matter of not wanting to force my customers to deploy a dedicated Linux box on top of an already complex (all Windows) infrastructure.

Yeah, as I said, I definitely buy the scenario that a Windows-based On-Premise backplane makes sense. I just wanted to reframe the discussion in terms of that instead of SQL Server since it's been problematic :).

Would it not be possible to handle the issue in a peer-to-peer fashion?

Yep, this is something we've been tracking in https://github.com/aspnet/SignalR/issues/968 for a while :). It's a good idea, we just haven't got a good design for it yet (other priorities at the time ;)). It'd also require something like a gossip protocol (#2263) or manually registering the IP addresses of the other servers (which isn't possible in Azure App Service, but this backplane would be designed for on-prem anyway).
The big consideration right now is building and maintaining such a backplane for production-quality deployment is quite a bit of work and we need to prioritize it among other things on our queue.

Adding to the 3.0.0 milestone to consider a solution for Windows on-premise deployments. SQL may not be the answer when we're all done, but we're considering this for our next release milestone.


use proper data types

we want actual data types, not [[String]]. Closer to PowerShell or even Nu.
The data package has what we need. This is pretty much the values an interpreter could produce (after all, our commands are CPS-ish coroutines...).
We need:

string
int
list of X
records of list of X=>Y
need to consider tables (headers shared)

671ad2d6f6fae823654905a58945bdfeea84c3dc arrays

0492c7ca77542e6359ff11da56d8e9e3fa0bb44b numbers


[Improvement] Null pointer exception could result in HTTPClient.java

What would you like to be improved?
In this code:
      if (responseBody == null) {
        throw new RESTException(
            "Invalid (null) response body for request (expected %s): method=%s, path=%s, status=%d",
            responseType.getSimpleName(), method.name(), path, response.getCode());
      }

and this:
if (responseBody == null) {
throw new RESTException(
"Invalid (null) response body for request (expected %s): method=%s, path=%s, status=%d",
responseType.getSimpleName(), method.name(), path, response.getCode());
}
responseType coudl be null
How should we improve?
Check that responseType is null and pass a suitable default value.

@justinmclean , Could you please provide more context or specify which default value you're referring to?

@justinmclean , Could you please provide more context or specify which default value you're referring to?

This means ResponseType may be null, and if so, a call to responseType.getSimpleName()  will results in NullPointerException. To avoid this, you should add an empty check before using responseType.

If ResponseType is null, you might want to default to using "unknown" or similar for expected.

@surajbora59 @YxAc do either of you want to work on this?


docs: Indicated Guardrails for Amazon Bedrock preview status

Added notification about limited preview status of Guardrails for Amazon Bedrock feature to code example.

Added a notification regarding the limited preview status of the Guardrails for Amazon Bedrock feature to the documentation’s code example, aiming to minimize confusion.


Bad Angular associations

Describe the bug
The angular component icon assotiate with all files that contains .component. , it is also the case with the services and i imagine every angular association.
To Reproduce

create a file named test.service.dart
There it is, the angular icon pop up

Expected Behavior
the dart icon should show
Environment
IntelliJ IDEA 2022.2.3 (Ultimate Edition)
Build #IU-222.4345.14, built on October 5, 2022
Runtime version: <IP_ADDRESS>+7-b469.62 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Plugin version: 73.0.0
Screenshots

It's part of the package. If you don't want it you need to override it in the custom associations.


DSD-777: TemplateAppContainer header element fix

Fixes JIRA ticket DSD-777
This PR does the following:

Adds a renderHeaderElement prop to the TemplateAppContainer and TemplateHeader components to allow it to not render a <header> HTML element as its wrapper. This is needed for consuming applications that pass in their own custom component that itself renders a <header> element. This fixes and nested header elements.

How has this been tested?
Locally in Storybook.
Accessibility concerns or updates

Fixes any nested header HTML element issues as well as custom components that need to render an <aside> and a <header>. Such use-case came up in the DS Test App where passing a Notification component (which renders an aside element) causes an accessibility issue because the TemplateAppContainer component renders the Notification inside a <header> element. This causes a "cannot render a landmark element inside another landmark element" accessibility error.

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] View the example in Storybook

Tugboat has finished building the preview for this pull request!
Link:

https://pr865-pdmnxfhbald079rwv8wkbqiszp9izxdk.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/62058c9c00c7e8a75815033d

Tugboat has finished building the preview for this pull request!
Link:

https://pr865-pdmnxfhbald079rwv8wkbqiszp9izxdk.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/62058c9c00c7e8a75815033d


Custom Object Detection Model Failed

I want to make a object detection(signA detection) model using the "DetectNet".
1. Prepare train data and val data.
image(size: 1920 * 1080 )
label (for example:
signA 0 0 0 1136 351 1264 351 1136 479 1264 479 0 0 0 0 0 0 0
signB 0 0 0 1327 235 1455 235 1327 363 1455 363 0 0 0 0 0 0 0)
the size of bbox is : 128 * 128
2. Create new object Detection Dataset with

Pad image: 1920 , 1080
Custom classe:  dontcare,signA

the others are left by default.
And the dataset created successfully.
3. Create new object detection model with the "DetectNet"
I changed some parameters because the size of image is different withe images in the tutorial.
mine: 1920 * 1080
tutorial: 1248 * 384
so I changed these values in the "DetectNet" definition.

1248 -> 1920
384 -> 1080
352 -> 1048

Finally I got some error like these when training the model.

ERROR: Check failed: bottom[i]->shape() == bottom[0]->shape()
Creating layer coverage/sig
Creating Layer coverage/sig
coverage/sig <- cvg/classifier
coverage/sig -> coverage
Setting up coverage/sig
Top shape: 1 1 67 120 (8040)
Memory required for data:<PHONE_NUMBER>
Creating layer bbox/regressor
Creating Layer bbox/regressor
bbox/regressor <- pool5/drop_s1_pool5/drop_s1_0_split_1
bbox/regressor -> bboxes
Setting up bbox/regressor
Top shape: 1 4 67 120 (32160)
Memory required for data:<PHONE_NUMBER>
Creating layer bbox_mask
Creating Layer bbox_mask
bbox_mask <- bboxes
bbox_mask <- coverage-block
bbox_mask -> bboxes-masked
Check failed: bottom[i]->shape() == bottom[0]->shape()

What is wrong ? Or How can I create a custom object detection model?
thank you.

@lukeyeager thank you

Please contribute to that thread if you have further questions.

@skyzhao3q   Did you find out how to solve this issue? I am currently having the same issue, having the same train of thoughs, and seem not be able to solve it. The comments of #980 where not able to help me so far

@skyzhao3q , I just checked your data set format , I think you should to change the Bounding box representation in annotation files ( 4 points) . to be (X_min Y_min X_max Y_max ) 2 points only . you can refer to this figure:

@fdesmedt I haven't solve this issue so far. In other  words I can't make a custom class model successfully.However I actually made a pedestrian model using kitti-data.You can see details here
https://github.com/skyzhao3q/NvidiaDigitsObjDetect

@Ali-Maher Thank you for your advice. I found this mistake later and corrected it. But it seems that the problem is more than this.

@skyzhao3q have you solved the problem? I'm trying the same thing

I'm in the same boat, having issues with 1920x1080 images


Other Models

I planned to integrate more models (feature extractors) apart from vgg16 into your library and then saw in some of your code comments some artifacts about resnet. Are you planning to integrate those other models in the future and if you have already done so privately are there any insights about the effects of others models that you could share?

Yes, I have tried to use ResNet with NetVLAD but unfortunately, I achieved poor results. So I did not release this model in the library. I am also wondering if other architectures could achieve better results than VGG when using the NetVLAD layer. When testing ResNet, I found that 1) a deeper one does not necessarily lead to better results, and 2) a larger resolution of feature maps fed into NetVLAD leads to better results.


New component: Toolbar

See https://github.com/radix-ui/primitives/discussions/375

Closed by #451?

Yep thanks!


Compile error for Postgres

Hello.
Excellent library. Thank you.
I tried to build tests through GNU make.
I've got a lot compile time errors.

g++ -g -D_DEBUG -O2 -I/usr/include -I/usr/local/include -I/usr/include/postgresql -I/usr/include/postgresql/12/server -I../include -std=c++11 -x c++-header -o stdafx.h.gch stdafx.h
g++ -c -g -D_DEBUG -O2 -I/usr/include -I/usr/local/include -I/usr/include/postgresql -I/usr/include/postgresql/12/server -I../include -std=c++11 -o TestPostgres.o TestPostgres.cpp
In file included from /usr/include/postgresql/12/server/nodes/parsenodes.h:27,
from /usr/include/postgresql/12/server/utils/acl.h:36,
from /usr/include/postgresql/12/server/catalog/objectaddress.h:18,
from /usr/include/postgresql/12/server/catalog/pg_type.h:24,
from ../include/qtl_postgres.hpp:31,
from TestPostgres.cpp:8:
/usr/include/postgresql/12/server/nodes/primnodes.h:200:2: error: ‘Datum’ does not name a type; did you mean ‘outDatum’?
200 |  Datum  constvalue;  /* the constant's value */
|  ^~~~~
|  outDatum
In file included from /usr/include/postgresql/12/server/utils/acl.h:37,
from /usr/include/postgresql/12/server/catalog/objectaddress.h:18,
from /usr/include/postgresql/12/server/catalog/pg_type.h:24,
from ../include/qtl_postgres.hpp:31,
from TestPostgres.cpp:8:
/usr/include/postgresql/12/server/parser/parse_node.h:263:2: error: ‘ErrorContextCallback’ does not name a type
263 |  ErrorContextCallback errcallback;
|  ^~~~~~~~~~~~~~~~~~~~
....

Software versions:
Ubuntu 20.04
GNU Make 4.2.1
g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
postgresql-client-12 (12.12-0ubuntu<IP_ADDRESS>)
postgresql-client-common (214ubuntu0.1)
postgresql-server-dev-12:amd64 (12.12-0ubuntu<IP_ADDRESS>)
libpgtypes3:amd64 (12.12-0ubuntu<IP_ADDRESS>)
libecpg6:amd64 (12.12-0ubuntu<IP_ADDRESS>)
libecpg-compat3:amd64 (12.12-0ubuntu<IP_ADDRESS>)
libecpg-dev (12.12-0ubuntu<IP_ADDRESS>) …
Seems missing #include in <qtl/qtl_postgres.hpp>
//...
extern "C"
{
#include <postgres.h> // NEED THIS FOR COMPILE //
#include <c.h>
#include <catalog/pg_type.h>
}
//...
Building was finished OK after this addition.

This problem seems to be related to the PostgreSQL version.

At that time, I used PostgreSQL 10.6 and debugged these header files for a long time.


Federate include timestamp of metrics

Proposal
Currently when using /federate on a prometheus endpoint, I get the granularity of data equal to that of the scrape interval of the prometheus scraping that endpoint. In the prometheus (prometheus1) being scraped, it could be scraping two endpoints (1 at a 15s interval and another at 30s).  If the prometheus (prometheus2) scraping prometheus1 is at an interval greater than 15s data is lost.

Example configs:
global:
  scrape_interval: 15s

scrape_configs:
  - job_name: "prometheus2"
    static_configs:
      - targets: ["localhost:9090"]

  - job_name: "federate"
    scrape_interval: 30s
    honor_labels: true
    params:
      "match[]":
        - '{__name__="example_metric"}'
    metrics_path: "/federate"
    static_configs:
      - targets: ["prometheus1:9090"]

global:
  scrape_interval: 5s

scrape_configs:
  - job_name: "prometheus1"
    static_configs:
      - targets: ["localhost:9090"]
  - job_name: "gateway"
    static_configs:
      - targets: ["sample_target:9091"]

in this example the data of example metric in prometheus2 is a granularity of 30s instead of 5s

thanks for your issue
I do not see a bug here. You would need to lower the scrape interval if you want to get all the data points.


feat: disable animation

Refactors the window animator to run the loop one window at a time rather than batching the operations for all windows at once, allowing more flexibility in controlling per window animations
See #140

Works perfectly!!
Much better now in combination with Noice :)
Will push my updates once this gets merged.
Thanks again!


Remove the error stack trace from the 400 validation response

End users should not see stack traces in the response.

swagger-tools does not provide a stack trace.  What you are seeing is that your default error handler is printing the error as text/html as described here: http://www.senchalabs.org/connect/errorHandler.html  There is nothing to do here.

All errors in swagger-tools send the error downstream based on middleware best practices.  It is your responsibility to handle the error.  The default error handler is not something you want to run in production so create an error handler as described in the link above and do with the error how you deem fit.  Not only is your PR destructive but it doesn't solve the problem globally as that would require the same fix that I'm proposing, an error handler.

Ah, thanks for pointing me in the right direction. Swagger-tools is great BTW.

Thanks man.  Hopefully my information came as instructional and not derogatory.

Indeed. Here is a project I have developed using your tooling. Feel free to contribute!
https://github.com/niahmiah/rest-service-boilerplate


rustup

I don't know what happened here: https://github.com/rust-lang/rust/commit/efb9c30ed2bef28812f47914dea3ae4f703e6870#r115119947 that commit broke our tests I think. I don't know why it didn't break on the rustc side.

In rustc our tests run with "-A unused" so that it breaks less often.
I guess now with the subtree we don't need that any more.

@bors r+

:pushpin: Commit abff16887345ad05049e55df68c68775800742f7 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit abff16887345ad05049e55df68c68775800742f7 with merge 6a80d8094427df8d2d5ef199686a09ac1aead188...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 6a80d8094427df8d2d5ef199686a09ac1aead188 to master...


Prevent flapping of external DNS configuration

A flapping DNSEndpoint affects external DNS configuration, which introduces unwanted behavior during e2e tests.
How the controller uses externalDNS to configure zone delegation
K8GB uses a DNSEndpoint to configure zone delegation on the upstream DNS servers. This DNSEndpoint is picked up by ExternalDNS and looks as follows:
apiVersion: externaldns.k8s.io/v1alpha1
kind: DNSEndpoint
metadata:
  annotations:
    k8gb.absa.oss/dnstype: extdns
  creationTimestamp: "2024-10-27T11:03:38Z"
  generation: 1
  name: k8gb-ns-extdns
  namespace: k8gb
  resourceVersion: "1608"
  uid: 2ff4476f-0efd-4de7-96e7-605ca2a8fc78
spec:
  endpoints:
  - dnsName: cloud.example.com recordTTL: 5 recordType: NS targets:
    - gslb-ns-eu-cloud.example.com
    - gslb-ns-us-cloud.example.com
  - dnsName: gslb-ns-eu-cloud.example.com recordTTL: 5 recordType: A targets:
    - <IP_ADDRESS>
    - <IP_ADDRESS>

This resource is independent of GSLB resources, but it is still updated on every reconciliation loop, since that is the only chance the controller has to update resources. In the end to end tests we do not know the IP address on which coreDNS is exposed, therefore we abuse the GSLB resource to fetch the IP addresses of the nodes in the cluster (see the update in controllers/providers/dns/external.go). However, this is quite some negative consequences if values are different for different GSLB resources, which happens quite often.
Flapping affects e2e tests
While trying out chainsaw I tried to increase the parallelism of tests, since I would like to have all e2e tests running simultaneously. This would prevent testing time to grow linearly with the number of strategies or ingress integration.
Frequent DNSEndpoint updates
Unfortunately, having all GSLB resources trying to modify the DNSEndpoint with different values resulted in flaky tests. This DNSEndpoint is important for the tests since it contains the records necessary for cross-cluster communication, if it is not available then K8GB instances on different clusters cannot discover their peers which leads to the following error:
2024-10-27T10:27:36Z WRN github.com/k8gb-io/k8gb/controllers/providers/assistant/gslb.go:255 > can't resolve FQDN using nameservers error="exchange error: all dns servers were tried and none of them were able to resolve, err: dial udp: lookup gslb-ns-us-cloud.example.com on <IP_ADDRESS>:53: no such host" fqdn=localtargets-roundrobin-istio.cloud.example.com. nameservers=[{"Host":"gslb-ns-us-cloud.example.com","Port":1053},{"Host":"gslb-ns-us-cloud.example.com","Port":1053},{"Host":"gslb-ns-us-cloud.example.com","Port":53}]

Example

A GSLB using Kubernetes Ingress is created. The IP address is still not assigned by the cluster -> A DNSEndpoint is created with empty targets, so discovery of other clusters is not yet possible
The same GSLB has now an IP address assigned -> The DNSEndpoint is updated with target, so discovery is now possible
A new GSLB using Kubernetes Ingress is created. The IP address is still not assigned by the cluster -> The DNSEndpoint is updated, since there are no targets the discovery of other clusters is no longer possible

If the timings are unfortunate enough it would be possible that cluster discovery is always unavailable when we reconcile a particular GSLB resource, thus resulting in the advertisement of incorrect targets.
Solution
This PR proposed to fix this issue by not updating the DNSEndpoint if the list of targets that comes from the gslb resource and is empty. This should be only relevant for testing since all production usecases should use a coreDNS exposed via a load balancing service.
DNSEndpoint deletion
Additionally, the deletion of a GSLB resource was also leading to the deletion of the ExternalDNS resource, even if there were additional GSLB resources still in use. This also led disruption of the cross-cluster communication until the next GSLB resource is reconciled. This problem is fixed on the finalizer, by deleting the ExternalDNS resource only when the last GSLB resource is deleted.
TTL flapping
Lastly, even though this didn't affect the e2e tests I noticed that the TTL also flaps, since different GSLB resources may have different TTLs. To stabilize it we can create a new configuration option to set the TTL for the NS and glue record.

This should be only relevant for testing since all production usecases should use a coreDNS exposed via a load balancing service.

Just in case there can be production use cases in on-prem scenario where coreDNS is exposed directly with host network.

This should be only relevant for testing since all production usecases should use a coreDNS exposed via a load balancing service.

Just in case there can be production use cases in on-prem scenario where coreDNS is exposed directly with host network.

The current implementation assumes that the GSLB and the coreDNS share the same exposed IPs. Is this true only if coreDNS and the ingress controller be scheduled on the same node?


Implicit functions cannot be drawn with type: 'line' or sampler: 'builtIn'

Attempting to plot the following gives me an error:
    var vv = {
        target: target,
        data: [{
            fn: 'x * x + y * y - 1',
            implicit: true,
            graphOptions: {
                sampler: 'builtIn',
                type: 'line'
            }
        }]
    };

The error is Undefined symbol y. Removing BOTH graphOptions works, but I need to use math.js so that's not an option for me.

The problem is that implicit equations need evaluation for all the points that belong to the viewport, using interval arithmetic (the default option) uses a quadtree to selectively analyze certain parts of the viewport
This cannot be done with math.js yet


Finalize 0.4.0 release notes

The built docs look good to me: https://openff-docs--471.org.readthedocs.build/projects/evaluator/en/471/releasehistory.html


Authenticate Users With User/Pass [FE]

Feature Description
Block access to the system with user authentication based on username-password combo and distinct USD permissions
Notes
USD = Upload/Search/Download
Subtasks
Frontend
[ ] Prompt all users for user/pass combo prior to access
[ ] Call for a database query upon receipt of user info
[ ] Block or allow access based on authentication results

I was thinking that this issue included enabling users to log in with credentials stored in the db.
If that is NOT the case, a new feature will need to be added to the PB to care for this.  I will assign it to @j-leidy.
If that IS correct, then there is an bug, and this issue should remain open until it is resolved.
(2 known username/password combos do not allow successful logging in)

this is for a user logging in.
Adding, deleting, updating users is something else

completed


ReSharper 2016.3 Support

@smad2005 new version has been uploaded. Could you please tell me if everything works as expected? The API didn't change that much.

Thx for updating, but your package is absent for wave 7

I love your plugin very much, i think it's one of the best thing for tests (super time saver)

Build from github also doesn't work

Now the package should be there. Forgot to update the nuspec file :)
If you have any idea on how to improve the plugin, let me know.


[resolves #2401] editorconfig exclusions not horored without -Dts.all

@jamesnetherton I have found a way for the plugin to exclude also the module directories of inactive profiles. This just unreverts the plugin removal and upgrades the plugin to the new version that I have just released.

ok to test


WFCORE-3742 management operation to generate provisioning feature spe…

…cs for managed resources (read-feature)
removed system.out.println
renamed PM_UNDEFINED to GLN_UNDEFINED
addressed PR comments
renamed read-feature to read-feature-handler, made it hidden, other adjustments

retest this please


Add ring buffer map.

This PR does the following:

Implements libbpf APIs  ring_buffer__new and ring_buffer__free.
Removes internal API     ebpf_map_wait_for_update for which there is no Linux equivalent and was introduced only to testr async module.
Implements BPF_MAP_TYPE_RINGBUF using the ebpf_ring_buffer module.
Implements  bpf_ringbuf_output global helper function.
Makes bugfixes and other minor changes to ebopf_async and ebpf_ring_buffer modules.
Adds sample eBPF program, unit tests and API tests for the above features.
Some other minor cleanups at a few places.

CI/CD kernel tests are intermittently hanging. Abandoning PR.


Support PrintSCU

Hi, thanks for your library.
In my work, I always need to send DICOM files to the DICOM Printer for printing.Could you please support PrintSCU in the future?

Hello! Thank you for your interest in DICOM-rs.
There are no plans for it, but it would very likely have a place in the project if someone takes initiative. If you are able, I can provide some guidance.

Hello! Thank you for your interest in DICOM-rs.
There are no plans for it, but it would very likely have a place in the project if someone takes initiative. If you are able, I can provide some guidance.

@Enet4 I also hope to do somethings, but I am not very good with Rust programming, I don't have much experience with Rust.

It should hopefully not be too overwhelming if you have the DICOM part covered. I would advise taking dicom-storescu as a baseline and change the DIMSE interactions from there.


Issue #539: Sample manually build AES/Rijdael constants

Test samples are all uploaded to VTs:

8333822ed41d9f2b302cf8e21b126efc:0x40646a: Actual sample where the sbox and inverted box is built manually
5553bbc23dea546192d07f268c4764a9:0x1149: ELF64 PoC without optimization
316aad44bb75e0c7676e173bcb56413e:0x11CD: ELF32 PoC without optimization
142300d78d9fb083122332235d93d3ae:0x1210: ELF64 PoC with -O2
e735a3df2b9ac89ca35ae643d3e73cf9:0x1240: ELF32 PoC with -O2
fbddca0225a3b806d4b4c933c1c4a636:0x140001000: x64 PE without optimization
84b777dc2d7083fd983d946f9fe2bf00:0x401000: x86 PE without optimization

Nhan, hey hey hey! Good to hear from you and thanks for the new rule! Looks great and I've added the first example to test-files in https://github.com/mandiant/capa-testfiles/pull/125. Can you move the rule from the nursery? Then I'm happy to merge!

Hi Moritz,
Thanks for the quick update. I have moved the rule from nursery into data-manipulation/encryption/aes. Once this is merge, we can also close #539

@mr-tz, I found a typo in the PR. Let me close this one and reopen another one.


stop alarm using gesture sensor.

I'm using GroveGesture Sensor(PAJ7620u2) MMM-GroveGestures
how to stop alarm using that sensor?

Hi @8acoustic , the module listens for the notification STOP_ALARM https://github.com/fewieden/MMM-AlarmClock/blob/e4638b655960c411b44d1244cd1a06551dffc1ef/MMM-AlarmClock.js#L184-L188
In your grove gesture config you would need to specify something like
"ANTICLOCKWISE": {
  notificationExec: {
    notification: "STOP_ALARM",
    payload: null,
  }
},

accordingto the docs https://github.com/eouia/MMM-GroveGestures#details-and-default

Tysm for the help, The alarm now stop using the gesture but the widget on the screen doesn't disappear when its stopped...
it disappear after 1 min.

@8acoustic sry for the late reply. Are you using the latest version of the module? I had made a lot of changes.


CONTRIBUTING asks for impossible things

Just looked at the CONTRIBUTING file for the first time in a while and was curious to see that it asks contributors of pull requests to:

"Assign yourself so we know you're working on it"
"If you're still working on it, add the under development label"

Unless I'm much mistaken, neither of these are things that the wider community are permitted to do.

Are you missing the rights to self-assign an issue or adding a label?

Both.
Thanks,
Rob

On 12 Dec 2017, at 09:22, Maxim<EMAIL_ADDRESS>wrote:
Are you missing the rights to self-assign an issue or adding a label?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


feat: add build number tag to abe2e vmss models for tracking

What type of PR is this?
/kind feature

What this PR does / why we need it:
adds build numbers to abe2e vmss models for easier tracking/debugging
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.095%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2255

Relevant Lines:
2851

💛  - Coveralls


Implement code actions for extract method, extract variable and sort imports

Extract method, extract variable, sort imports should be source code actions - so they appear after a lightbulb, not context menu actions which clutter the context menu.
fyi @jrieken @luabud

And then extension would address this: https://github.com/microsoft/vscode-python/issues/10337


Miscellaneous changes in readme

While reading the current readme file I encountered few spelling errors, few repeated words, etc.
For example:

“basis or scoring”
“website will have have a leaderboard”

@kroy96 If mentioned changes are to be applied, can I help with it?

Hi @evanessa234 sure you make the changes. Appreciate it.


Foxcoder508 fix

I have changed the logo to a nicer-looking one.

Hey @Brainiac-M can you make it a little bit small

Alright. I will do that

Done. I think it looks nicer now. I like the dark mode too. Nice work

Done. I think it looks nicer now. I like the dark mode too. Nice work

Don't you think it's too wide ??

Done. Is it cool this way?


Standardize formatting/Linting

It looks like the project has inconsistent style and trips PEP8 ide rules in more than a few places. It would be good to :

set a standard for the project
Perform some kind of automation to make that easier

Added in #85


[Frontend] Add option for LLMEngine to return model hidden states.

Add return_hidden_states option in ModelConfig and allow hidden states to be passed up from SamplerOutput to RequestOutput for use by the client.
FIX #4435

Thanks a lot for your contribution. Would you like to provide snippet samples for using this feature?

Just figured it out - so the hidden states output vector is a concatenation of all the hidden states at the last layer. In the functional aspect I would strongly vote for merging this PR asap.

Just figured it out - so the hidden states output vector is a concatenation of all the hidden states at the last layer. From the functional aspect I would strongly vote for merging this PR asap.

Yes, exactly. Though, you made me realise a mistake in how I was concatenating the hidden state. I have now fixed this and made the tests a bit more exacting.
Admittedly, I am not very happy with having to piggyback on an unrelated helper function for some of this logic. My goal was to modify as little core code as is necessary.

Thanks for the fix. I also find that return_hidden_states=True makes the GPU usages keeps going up when using your patch and do llm.generate. I guess it can be solved by transforming the tensors to CPU?

Ah yes, I can see accumulating the tensors on the GPU being a bit of a problem for memory handling. Just pushed a fix.

Confirming that this fix solves the problem.

/ready

@BiEchi Do you know if there is anything I need to do to be assigned a reviewer? I would love to get this merged.

@jdvin I think maybe you should @ one of the authors of this repo. I used your patch and it works nicely overall.
One issue is that the output representations does not exactly match those extracted directly from the transformers lib, but they're close enough so I didn't encounter any major concerns. I think it would be nice if you can look into this issue and well explain the reason to the authors. My conjecture is that the optimizations in vllm somewhat tweaks the inner representations for a little bit.

@jdvin thanks for your patch!
+1 this would be a great feature to merge!
perhaps @liangfu could help review these?

Sorry, I have no idea why merging main resulted in requesting review from everyone.

I appreciate this feature. I conducted some tests on your fork and noticed that the return_hidden_state does not seem to function with a sampling parameter n>1. Although I haven't gone over your code, and not a reviewer. But I still would like to ask whether it could it be possible to implement it within SamplingParams rather than the llm class?


Move 'init' to separate executable

Resolves #6

@ivan-podorozhnyi

@extsoft 'git-elegant init' test fails. Please fix it to make sure that everything works properly.

Done.

@extsoft Thank you!

@rultor please merge

@rultor please merge

@extsoft OK, I'll try to merge now. You can check the progress of the merge here

@rultor please merge

@extsoft Done! FYI, the full log is here (took me 2min)


Enable sequenced cluster naming in test setup

As the title suggests. This is needed in tests for scheduling preferences, where preferences are specified against the cluster names.

This was raised to be useful for tests in https://github.com/kubernetes-sigs/federation-v2/pull/46 and any other similar controller.
@maru @font @pmorie @shashidharatd PTAL.

@maru @font @pmorie, I would ideally want atleast one of you to have a look and/or ok this, as this effects the common test code.

Hard-coding cluster naming for testing is an anti-pattern, and will complicate reuse of tests across managed and unamanged test fixture.  Please revise the test additions for #46 to use the names of member clusters such that this PR is no longer necessary.

Acknowledge, and closing this one. Additionally updated the tests in #46.
/close


Suggestion to contribute and improve my knowledge and learn!

Hi!!
I was checking your code and I would like to contribute with some suggestions that maybe are not good, but maybe makes you think about and found more improvements.
I'm looking for the best Architecture for SwiftUI. In that case (for example) one think that doesn't like to me is the fact that, to use LocationManager, you should assign inside the onAppear, fighting a little with the framework purpose. If Apple decided to put the Environment Objects only accessible from the View, I think it was for one reason, not to capture from the view and pass through the .onAppear or through the .task to a ViewModel
I've move some logic inside the BikeStationsListViewModel in order to be able to test it:
    // you can assign the LocationManager inside the .onAppear
    var locationManager: LocationManager?

    // The Fetch Request can be moved inside the ViewModel
    @FetchRequest(
        sortDescriptors: [
            NSSortDescriptor(keyPath: \StationEntity.name, ascending: true)
        ], animation: .default) var stationEntities:
        FetchedResults<StationEntity>

    // Can be useful to have the logic to show the Loading and the Error Message inside the VM
    var showldShowErrorLabel: Bool {
        state == .unsuccessful
    }

    var showldShowLoadingIndicator: Bool {
        state == .loading && sortedStationEntities.isEmpty
    }

    // If you move the computed var into the VM you can test it.
    // Of course, we know that CLLocationDistance is already tested by Apple (god, please) but if you put here,
    // you can write some test to be sure the expected result and, in future implementations or changes,
    // you are going to be safe
    var sortedStationEntities: [StationEntity] {
        if let locationManager, let userLocation = locationManager.userLocation
        {
            return stationEntities.sorted {
                locationManager.distance(from: userLocation, to: $0)
                    < locationManager.distance(from: userLocation, to: $1)
            }
        } else {
            return Array(stationEntities)
        }
    }
    ```

Hey, thanks for your suggestions!
In my opinion, there’s no universal "best" architecture for SwiftUI that suits all iOS apps. Architecture is subjective and often sparks debates, so I think it is best to adapt our approach to the specific needs and context of the app we’re working on.
Regarding your suggestions:

The use of var locationManager: LocationManager? in the ViewModel and assigning it in .onAppear in the View is in my opinion, not the most scalable approach. As the app grows, this method could require creating multiple instances of LocationManager for different views and also dealing with unwrapping the optional every time it’s used adds extra overhead. By contrast, using a single instance of LocationManager as an EnvironmentObject allows it to be shared across the app and we can use it where needed.

Moving the @FetchRequest in the ViewModel would require the import SwiftUI, which is by default related to the View layer, and I try to avoid that in the ViewModels. Also, I don't see it as a problem to have a small amount of logic inside a View that is related specifically to the data displayed in that View, but this is something subjective, and everyone can have different opinions.

Thanks for reviewing the code and suggesting improvements! It’s always great to see different perspectives, and discussions like this can lead to better solutions. :)


fix: 'new()' method for format Config Builder

We'll merge this after the release and include it in the next.


Failed to deploy

I follow the nodejs application tutorial and received this error message when i try deploy
Deploying services on project dwoond in wedeploy.com...
! Deployment failed in 1s.kage...
! Upload failed app-dwoond.wedeploy.io.
! Something went wrong with your "we deploy" operation.
! Deployment push failed.
I'm useing cli in windows 10
Edit, in wedeploy.json I use 'id': 'app' and in the cli i call we deploy -p nameproject (name the project in the site wedeploy)
If i try in the cly we deploy -p app i got this error
Something went wrong with your "we deploy" operation.
! Access is restricted to collaborators.

Hi @DWoonD,
can you please do the following?

run we update
try `we deploy -p app-

It might be the case that the project app is owned by someone else and you are not a collaborator. I am going to improve the error message for this case.

If that doesn't help, can you please try provide the following details:

Output of we version
Run command with we deploy -p app-<random number> --verbose --defer-verbose-output

C:\Projetos\wedeploy\tutorial-nodejs>we deploy update
! Something went wrong with your "we deploy" operation.
! Invalid number of arguments: too many.
C:\Projetos\wedeploy\tutorial-nodejs>we version
WeDeploy CLI version 1.0.7 windows/amd64
Build commit: f39e3f0ccc0b3e104dd35de5750cd90006a424be
Build time: Thu Aug 10 17:23:50 UTC 2017
C:\Projetos\wedeploy\tutorial-nodejs>we deploy -p app-9998990877678323
! Something went wrong with your "we deploy" operation.
! Invalid parameter "projectId" for "app-9998990877678323".
C:\Projetos\wedeploy\tutorial-nodejs>we deploy -p app-9998990877678323 --verbose --defer-verbose-output
Defering verbose output (might lose messages on failures)
! Something went wrong with your "we deploy" operation.
! Invalid parameter "projectId" for "app-9998990877678323".
If you can wait, I'm in the corporate network and I think then this can be a problem. I will try again in my home

I think the first command was wrong: we deploy update is actually we update

Oops. Our projects doesn't work with "-". Try something like app27725
instead. Sorry about that.
Henrique Vicente
https://henvic.github.io/
https://github.com/henvic
http://flickr.com/photos/henriquev/

I receive this error message too:
λ  we deploy -p kvfirstapp -s app --verbose --defer-verbose-output
Defering verbose output (might lose messages on failures)
Deploying services on project kvfirstapp in wedeploy.com...
⠦ Uploading deployment package...
⠂ app-kvfirstapp.wedeploy.io
fatal: unable to access 'https://git.wedeploy.com/kvfirstapp.git/': error setting certificate verify locations:
Deploying services on project kvfirstapp in wedeploy.com...-bundle.crt
! Deployment failed in 1s.kage...
! Upload failed app-kvfirstapp.wedeploy.io.app.git
! Something went wrong with your "we deploy" operation.
! Deployment push failed.

@khaueviana,
Have you copied the entire message here? It appears not...
Can you please update the app with we update and try again with we deploy -p kvfirstapp -s app -V?
I added the more friendly "--defer-verbose" flag)or -V shortcut) today to make it simpler.

Also, what operating version and version are you using? I am afraid this seems to be an operating system misconfiguration.

We version:

WeDeploy CLI version 1.0.9 windows/amd64
Build commit: cb900e9e2b3f74e2a6b644b6d852326690218aae
Build time: Fri Aug 11 05:40:05 UTC 2017

Error message like you said:

Deploying services on project kvfirstapp in wedeploy.com...
⠙ Uploading deployment package...
⠂ app-kvfirstapp.wedeploy.io
fatal: unable to access 'https://git.wedeploy.com/kvfirstapp.git/': error setting certificate verify locations:
Deploying services on project kvfirstapp in wedeploy.com...-bundle.crt
! Deployment failed in 1s.
! Upload failed app-kvfirstapp.wedeploy.io.app.git
! Something went wrong with your "we deploy" operation.
! Deployment push failed.

WeDeploy CLI version 1.0.9 windows/amd64
Build commit: cb900e9e2b3f74e2a6b644b6d852326690218aae
Build time: Fri Aug 11 05:40:05 UTC 2017

we deploy -p projectName -s serviceName -V
Deploying services on project projectName in wedeploy.com...
⠙ Uploading deployment package...
⠂ serviceName-projectName.wedeploy.io
fatal: unable to access 'https://git.wedeploy.com/projectName.git/': error setting certificate verify locations:
Deploying services on project projectName in wedeploy.com...
! Deployment failed in 1s.
! Upload failed serviceName-projectName.wedeploy.io.
! Something went wrong with your "we deploy" operation.
! Deployment push failed.

 Deferred verbose messages below
> GET https://api.wedeploy.com/projects/projectName HTTP/1.1
User-Agent: WeDeploy/master (+https://wedeploy.com)
Content-Type: application/json
Authorization:  1 hidden value

< HTTP/1.1 200 OK
Etag: W/"131-5TAqqg/t7RK5sfD4Aw8GP+vggzs"
Date: Fri, 11 Aug 2017 20:32:34 GMT
X-Content-Type-Options: nosniff
X-Ratelimit-Limit: 100000
Content-Type: application/json; charset=utf-8
Strict-Transport-Security: max-age=15552000; includeSubDomains
X-Frame-Options: SAMEORIGIN
X-Download-Options: noopen
X-Xss-Protection: 1; mode=block
Access-Control-Allow-Origin: *
X-Ratelimit-Remaining: 99977
Content-Length: 305
Vary: Accept-Encoding
X-Dns-Prefetch-Control: off

{
    "createdAt":<PHONE_NUMBER>299,
    "github": {},
    "invitations": {},
    "collaborators": [
        "238816412022598170"
    ],
    "health": "up",
    "healthUid": "21ed7b57-84bd-4f7c-891f-ceff5bf88f96",
    "planId": "free",
    "id": "239035348546762183",
    "masterToken": "56be6639-4a59-4790-a7bd-b3143a7fa5b9",
    "ownerId": "238816412022598170",
    "projectId": "projectName"
}

Running git init
Running git config user.name WeDeploy user --local
Running git config user.email user@deployment --local
Running git add C:\****\****\****\projectName-server
Service not found. Creating service package on git repo only.
Running git hash-object -w --stdin
Using hash-object:
{
    "id": "serviceName"
}
Running git update-index --add --cacheinfo<PHONE_NUMBER>b2404a188c6c15477be78b344006fdc00f9b
 wedeploy.json
Running git commit --allow-empty --message Deployment at Fri Aug 11 17:33:09 -0300 2017
Running git rev-parse HEAD
commit 364969ddd4dd44fd334751dff8079c322597f5f0
Running git remote add wedeploy https://git.wedeploy.com/projectName.git
Resetting credential helpers
Running git config --add credential.helper
Running git config --add credential.helper C:\\****\\****\\AppData\\Local\\Programs\\we\\bin\\we.exe git-credential-helper
Running git push wedeploy master --force --verbose

Hi guys,
I am sorry for the trouble you have been through.
I am able to reproduce your errors now. Working on a solution. Hang tight.

Can you please provide me the output of git config --system http.sslCAInfo?

@henvic C:/Program Files/Git/mingw64/ssl/certs/ca-bundle.crt

I think I solved this. @lucasfontesgaspareto, @khaueviana, @DWoonD can you please test?
If you want an explanation of my findings, keep reading on:
However, the way I did it is very, very, very strange though and may cause other problems for other users (of Windows)... Basically I add a GIT_CONFIG_NOSYSTEM=true environment variable on non-Windows systems, but stopped doing so on Windows.
switch runtime.GOOS {
	case "windows":
		verbose.Debug("Microsoft Windows detected: using git system config")
	default:
		envs["GIT_CONFIG_NOSYSTEM"] = "true"
	}

Two days ago I made a change to add it on all systems, however some people started to complain they had broken git system configs (and I bet most of them are people who pushes from a GUI such as GitHub for Desktop or Sourcetree, though I know for fact that at least some uses the terminal for that as well).
So, I have tried to use the GIT_SSL_CAINFO environment variable (see https://github.com/git/git/blob/8b2efe2a0fd93b8721879f796d848a9ce785647f/Documentation/config.txt#L1941) to fix this on Windows, but somehow it seemed to ignore... And actually I found nothing so relevant on the Windows' system git config found on the system git config... So it might even be an issue on git itself (the second one I find, if this the case).

I test in my home now and i just update and use the command -p nameproject -s nameservice and it build and work.
thanks guys

Working fine bro!
WeDeploy CLI version 1.0.10 windows/amd64
Build commit: 8656e89d3b6d6ae4c578d9738f87674babf28b31
Build time: Sat Aug 12 03:39:06 UTC 2017

Thanks @henvic and others!

Thank you, guys.

Now I got this error:

Deploying services on project kvfirstapp in wedeploy.com...
⠦ Uploading deployment package...
⠂ app-kvfirstapp.wedeploy.io
Deploying services on project kvfirstapp in wedeploy.com...we.exe git-credential-helper get: C:\Users\Khaue: No such file or directory
! Deployment failed in 2s.name for 'https://git.wedeploy.com': terminal prompts disabled
! Upload failed app-kvfirstapp.wedeploy.io.app.git
! Something went wrong with your "we deploy" operation.
! Invalid credentials.

(Anyone who needs help with the CLI tool), it always help if you provide the following:
# It is important for me to know what version you are running
$ we version

# result of the command with verbose output (please include the command called as well)
$ we <cmd> [flags] -v

# for commands that update things in-line, use deferred verbose:
$ we <cmd> [flags] -V

# for example
$ we deploy --service bar -V

@khaueviana, can you please try to provide that? Thanks.

Do you think is something in my machine?

⚡ Khaue Viana@CS  C......\tutorial-hosting   master ≣ +1 ~0 -0 !   we version
WeDeploy CLI version 1.0.10 windows/amd64
Build commit: 8656e89d3b6d6ae4c578d9738f87674babf28b31
Build time: Sat Aug 12 03:39:06 UTC 2017
⚡ Khaue Viana@CS  C......\tutorial-hosting   master ≣ +1 ~0 -0 !  we update
! Channel "stable" is now selected.
! Current installed version is 1.0.10
! No updates available.
⚡ Khaue Viana@CS  C......\tutorial-hosting   master ≣ +1 ~0 -0 !  we deploy -p kvfirstapp -s app1 -V
Deploying services on project kvfirstapp in wedeploy.com...
⠧ Uploading deployment package...
⠂ app1-kvfirstapp.wedeploy.io
Deploying services on project kvfirstapp in wedeploy.com...we.exe git-credential-helper get: C:\Users\Khaue: No such file or directory
! Deployment failed in 2s.kage...r 'https://git.wedeploy.com': terminal prompts disabled
! Upload failed app1-kvfirstapp.wedeploy.io.pp.git
! Something went wrong with your "we deploy" operation.
! Invalid credentials.
 If so, @henvic would love to continue trouble shooting with you. If not, we will close this issue.

I have the same problem. I'm using git bash but i tried windows 10 command prompt too.

$ we version
WeDeploy CLI version 1.0.17 windows/amd64
Build commit: 826672e733d58a8b871e798aacb26b2af635c666
Build time: Wed Aug 30 00:31:56 UTC 2017

$ we deploy -p randomproject -V
Deploying services on project randomproject in wedeploy.com...
⠧ Uploading deployment package...
⠂ appwedeploy-randomproject.wedeploy.io
C:\Users\Phillipe Queiroz\AppData\Local\Programs\we\bin\we.exe git-credential-helper get: C:Deploying services on project randomproject in wedeploy.com...
! Deployment failed in 3s.
! Upload failed appwedeploy-randomproject.wedeploy.io.
! Something went wrong with your "we deploy" operation.
! Invalid credentials.
 Channel "unstable" is now selected.
! Current installed version is 1.0.17
! No updates available.

For now I'm not using. You can close :)

I got the same problem. Windows 10 here too.
`C:\Users\Pedro Sereno\AppData\Local\Programs\we\bin\we.exe git-credential-helper get: C:UsersPedro: command not found
fatal: could not read Username for 'https://git.wedeploy.com': terminal prompts disabled
Pushing to https://git.wedeploy.com/chatbot.git
! Something went wrong with your "we deploy" operation.
! Invalid credentials.
 Also, i noted the highlighted comment below "Running git config --add credential.helper" in the log file below has invalid windows path
I wonder if this post from MSDN is related to our problem
https://social.msdn.microsoft.com/Forums/en-US/accf32eb-9471-4026-a679-96175080a78a/folder-or-file-location-slash-or-?forum=netfxcompact
we version
WeDeploy CLI version 1.1.1 windows/386
Build commit: 982ab780781d8220f9d2cb35d42ae7ad50f91990
Build time: Wed Sep 20 00:05:19 UTC 2017
we deploy -p testweb --verbose --defer-verbose-output
Deploying services on project testweb in wedeploy.com...
? Uploading deployment package...
? app-testweb.wedeploy.io
C:\Users\Chennaiwallpainting\AppData\Local\Programs\we\bin\we.exe git-credential
-helper get:##  C:UsersChennaiwallpaintingAppDataLocalProgramswebinwe.exe: command
not found
Deploying services on project testweb in wedeploy.com....com': terminal prompts
! Deployment failed in 3s.kage...
! Upload failed app-testweb.wedeploy.io.web.git
! Something went wrong with your "we deploy" operation.
! Invalid credentials.

If you have the "! Invalid credentials." error, please update your git installation and it should work.
I am working on patching the CLI to make it work with really old versions of git (this issue seems to have affected only Windows users, by the way; though I was able to reproduce on Linux by using a 3-year old machine).
If it doesn't, please let me know the error.

Hello all! I am closing this issue since we have addressed all the bugs in recent releases. Please don't hesitate to reach out to our customer service team from the WeDeploy landing page if you need further assistance.


Remove-PnPListItem: fix parametersets

Type

[x] Bug Fix

Related Issues?
Fixes #1959
(Get-Command Remove-PnPListItem).ParameterSets |
  Select-Object -Property @{n='ParameterSetName';e={$_.name}},
    @{n='Parameters';e={$_.ToString()}}

Before: (no output, presumably meaning invalid!)
After:
Delete all items in list    [-List] <ListPipeBind> [-Force] [-Web <WebPipeBind>] [-Connection <PnPConnection>] [<CommonParameters>]
Recycle all items in list   [-List] <ListPipeBind> -Recycle [-Force] [-Web <WebPipeBind>] [-Connection <PnPConnection>] [<CommonParameters>]
Batched                     [-List] <ListPipeBind> -Identity <ListItemPipeBind> -Batch <PnPBatch> [-Recycle] [-Web <WebPipeBind>] [-Connection <PnPConnection>] [<CommonParameters>]
Delete single item in list  [-List] <ListPipeBind> -Identity <ListItemPipeBind> [-Force] [-Web <WebPipeBind>] [-Connection <PnPConnection>] [<CommonParameters>]
Recycle single item in list [-List] <ListPipeBind> -Identity <ListItemPipeBind> -Recycle [-Force] [-Web <WebPipeBind>] [-Connection <PnPConnection>] [<CommonParameters>]
Delete single item          -Identity <ListItemPipeBind> [-Force] [-Web <WebPipeBind>] [-Connection <PnPConnection>] [<CommonParameters>]
Recycle single item         -Identity <ListItemPipeBind> -Recycle [-Force] [-Web <WebPipeBind>] [-Connection <PnPConnection>] [<CommonParameters>]

At least it appears that this is the only cmdlet that was so broken that PowerShell gave up:
> Get-Command -Module PnP.PowerShell |? { -not $_.Parameters }

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Cmdlet          Remove-PnPListItem                                 1.10.42    PnP.Powershell

Looks good, thanks @fowl2! Nice trick with the ParamSets option, didn't know that one.