Carbon X: finalize color tokens

Duo uses color different than original Carbon color themes, we need to re-evaluate color usages and roles and add any additional color tokens.

[x] Audit color usage in Duo components
[x] Identify outliers and if its worthy of new token
[x] Determine final token set
[ ] Determine final token names. Are we keeping brand?
[ ] Finalized assigned values for white theme
[ ] Write migration guidelines

Steps:

Audited existing color application

https://ibm.box.com/s/q52kj1mluw3ofpj83ipllqn9zsa5v3cm

Categorized colors by value

https://ibm.box.com/s/bohbpwhqfsy1wczklphva2fyfwttw1g9

Grouped usage within each value

https://ibm.box.com/s/914o0p79ojipsw3m17xswummzvhiendi

Identified and resolved outliers (red text = outliers, green text=outlier resolved)
Assigned usage grouping to existing tokens or created new tokens to fit usage

https://ibm.box.com/s/gsn9ig73ajzep4bdtaht4mcipqwtw3lp

Final Tokens

https://ibm.box.com/s/8kouiwn37f8ijx2ql58t6hko1t8m8574

Core Color Tokens

Token
White Theme Value
Usage

$brand-01  $interactive-01
Blue 60
interaction colors  buttons  selected elements  feature elements  highlight hover for ui colors  accent?? icons

$brand-02
Deprecate ??
??

$brand-03  $interactive-02
Blue 60
Loading

$ui-01
Gray 10 / #f3f3f3
primary container background  secondary page background

$ui-02
White
Default page background  secondary container background

$ui-03
Gray 30
Subtle border

$ui-04
Gray 50
3:1 AA element contrast  medium contrast border

$ui-05
Gray 100
4.5:1 AA  element contrast  Emphasis border  Emphasis elements

$text-01
Gray 100
Primary text color  Text hover color for text-02 (Gray 70)  Labels as headers

$text-02
Gray 70
Label  Secondary text

$text-03
Gray 50
Hint text  placeholder text

$icon-01
Gray 100
primary icons

$icon-02
Gray 70
secondary icon color  decorative icons

$field-01
Gray 10
primary input field color  fields on White background

$field-02
White
Secondary input field color  fields on Gray 10 backgrounds

$inverse-01
White
Inverse text inverse icon

$inverse-02
Gray 80
High contrast backgrounds  High contrast elements

$support-01
Red 60
Error  Danger

$support-02
Green 60
Success

$support-03
Yellow
Warning

$support-04
Blue 70
Informational

$overlay-01
White @ 60%
Light background overlay

$overlay-02
Gray 100 @ 70%
Dark background overlay

Interaction State Tokens

Token
White Theme Value
Usage

$focus
Blue 60
Focus border  Focus underline

$hover-primary
Blue 60 Hover
Hover color for brand-01

$active-primary
Blue 80
Active color for brand-01

$hover-primary-text
Blue 70
Text + icon hover color for brand-01

$hover-secondary
Gray 100 hover
Hover for ui-05

$active-secondary
Gray 80
Active-background for ui-05

$hover-ui
Gray 10 Hover #e5e5e5e
hover white elements  hover Gray elements  hover transparent elements

$active-ui
Gray 30
Active background color for ui-01

$hover-danger
Red 60 Hover / #ba1b23
Support-01 hover

$active-danger
Red 80
Active color for support-01

$hover-row
TBD
Row hover

$visted-link
Purple 60
Visited state for link

$disabled-01
Gray 10
disabled fields background  disabled backgrounds disabled border

$disabled-02
Gray 30
disabled elements on $disabled-01 (Gray 10)  disabled label on $disabled-01 (Gray 10)  disabled text on $disabled-01 (Gray 10)  disabled icons on $disabled-01 (Gray 10)  disabled border  disabled background

$disabled-03
Gray 50
disabled text on $disabled-02 (Gray 30)  disabled icon on $disabled-02 (Gray 30)

so with this are we going to have 5 different default IBM themes?

I guess I'm just confused because you have $field-02 for G10 background, but nothing else is optimized for that -- ex. $ui-04, $text-03
wouldn't that just be calling the G10 theme (or subtheme, whatever we decide to call it)

$ui-04/ Gray 50 passes at 3:1 on both gray 10 (3.03:1) and white (3.36:1)
$text-03 is hint/placeholder text and we're still in a debate wether it needs to pass accessibility for not. Its current value is Gray 50 which doesn't pass even on white. We'd have to bump the value up to Gray 60 to work on white and it passes on Gray 10 (5.02:1) as well (4.53:1)

okay, that's good to hear, does it pass for the gray 100, 90 and 80 situation though?
Also, do we have a concrete scenario of when do you call the G10 theme versus when do you use $field-02 etc.

okay, that's good to hear, does it pass for the gray 100, 90 and 80 situation though?

We'd haven't evaluated those themes yet but if that the rule so if the color application in those themes aren't meeting the correct criteria for those token then we'll adjust the value not the token.
I can see Gray 80 have contrast issue which might be a good reason to rule it out as a theme.

Also, do we have a concrete scenario of when do you call the G10 theme versus when do you use $field-02 etc.

You'd target full pages for themes. I believe we're not advising people to target "zones" anymore within a page. Field-02 is in there for those moments where you'll need that other background like modal or form etc.

Unrelated, but would it be possible for us to create a table of rules for when colors can be used in foreground/background? Would love to automate the contrast checks so you all don't have to do it manually!

You'd target full pages for themes. I believe we're not advising people to target "zones" anymore
within a page. Field-02 is in there for those moments where you'll need that other background like modal or form etc.

Is it possible though to still target zones, especially for marketing page -- many times there are "bands" of color (we're narrowing down this practice and refining it but the band practice is still going to be used)

@tw15egan is the concept of targeting zones still possible? ^^ Is that something that a team would have to figure out themselves?

need to look into potentially changing ui-03 to Gray 20 instead of Gray 30. It works better with data table.

Just let me know @aagonzales! Will update in code 😄

New changes to color tokens
Changes have been added to the above table as well
Changing to make components work more closely to original Duo specs.

Change value of $ui-03 to Gray 20 (originally was Gray 30)
Add new token $selected-ui to interaction token set. Value for the Duo white them is$selected-ui: Gray 20

cc: @joshblack

Sprint 25: need migration docs from v9 to v10 - @aagonzales

Defined Production (Legacy) Theme values for V10 Tokens here: https://ibm.box.com/s/ohag7bv9m4s8llbevsrd4hm8druq8poz

Updated Color Tokens
V10 Color tokens

Token
White Theme
G10 Theme
G100 Theme
G90 Theme
Usage

$interactive-01
Blue 60 / #0062ff
same as White
same as G90
Blue 60 / #0062ff
interaction colorsbuttonsselected elementsfeature elementshighlight hover for ui colorsaccent?? icons

$interactive-02
G100 / #171717
same as wWhite
same as G90
G60 / #6F6F6F
Secondary button

$interactive-03
Blue 60 / #0062ff
same as White
same as G90
White / #FFFFFF
Tertiary button

$ui-background
White / #FFFFFF
G10 / #F3F3F3
G100 / #171717
G90 / #282828
Default page background

$ui-01
Gray 10 / #F3F3F3
White / #FFFFFF
G90 / #282828
G80 / #3D3D3D
primary container backgroundssecondary page background

$ui-02
White / #FFFFFF
G10 / #F3F3F3
G80 / #3D3D3D
G70 / #565656
secondary container background (eg. form)

$ui-03
Gray 20 / #dcdcdc
same as White
G80 / #3D3D3D
G70 / #565656
Subtle border

$ui-04
Gray 50 / #8c8c8c
same as White
G60 / #6F6F6F
G50 / #8c8c8c
3:1 AA element contrast medium contrast border

$ui-05
Gray 100 / #171717
same as White
same as G90
G10 / #f3f3f3
4.5:1 AA  element contrast Emphasis border Emphasis elements

$text-01
Gray 100 / #171717
same as white
same as G90
G10 / #f3f3f3
Primary text colorText hover color for text-02 (Gray 70)Labels as headers

$text-02
Gray 70 / #565656
same as white
same as G90
G30 / #BEBEBE
LabelSecondary text

$text-03
Gray 50 / #8c8c8c
same as white
G60 / #6F6F6F
G50 / #8C8C8C
Hint textplaceholder text

$text-04
White / #FFFFFF
White / #FFFFFF
White / #FFFFFF
White / #FFFFFF
Primary, secondary, and danger button text

$icon-01
Gray 100 / #171717
same as white
same as G90
G10 / #f3f3f3
primary icons

$icon-02
Gray 70 / #565656
same as white
same as G90
G30 / #BEBEBE
secondary icon colordecorative icons

$field-01
Gray 10 / #F3F3F3
White / #FFFFFF
G90 / #282828
G80 / #3D3D3D
primary input field colorfields on secondary background

$field-02
White / #FFFFFF
Gray 10 / #F3F3F3
G80 / #3D3D3D
G70 / #565656
Secondary input field color fields on secondary backgrounds

$inverse-01
White / #FFFFFF
same as white
G100 / #171717
G100 / #171717
Inverse text inverse icon

$inverse-02
Gray 80 / # 3d3d3d
same as white
G10 / #f3f3f3
G10 / #f3f3f3
High contrast backgroundsHigh contrast elements

$support-01
Red 60 / #da1e28
same as white
Red 50 / #FB4B53
Red 50 / #FB4B53
ErrorDanger

$support-02
Green 60 / #198038
same as white
Green 50 / #24A148
Green 50 / #24A148
Success

$support-03
Yellow / #FDD13A
same as white
Yellow / #FDD13A
Yellow / #FDD13A
Warning

$support-04
Blue 70 / #054ada
same as white
Blue 50 / #408BFC
Blue 50 / #408BFC
Informationalloading

$overlay-01
Gray 100 (#171717) @ 50%
same as white
same as G90
Gray 100 (#171717) @ 70%
Dark background overlay

$overlay-02

Interactive States Tokens

Token
White Theme
G10 Theme
G100 Theme
G90 Theme
Usage

$focus
Blue 60 / #0062ff
same as white
same as G90
White / #FFFFFF
Focus borderFocus underline

$hover-primary
Blue 60 Hover / #0353E9
same as white
same as white
same as white
Hover color for interactive-01

$active-primary
Blue 80 / #0530ad
same as white
same as white
same as white
Active color for interactive-01

$hover-primary-text
Blue 70 / #054ada
same as white
same as white
same as white
Text + icon hover color for brand-01

$hover-secondary
Gray 80 hover /#4c4c4c
same as white
same as G90
Gray 60 hover /#606060
Hover for interactive-02Secondary button hover

$active-secondary
Gray 60 / #6f6f6f
same as white
same as G90
Gray 80 / #3D3D3D
active color of $interactive-02Secondary button active

$hover-tertiary
Blue 60 Hover / #0353E9
same as white
same as G90
G10 / F3F3F3
Hover state of tertiary button

$active-tertiary
Blue 80 / #0530AD
same as white
same as G90
G30 / BEBEBE
active state of tertiary button

$hover-ui
Gray 10 Hover / #e5e5e5e
same as white
Gray 90 Hover / #353535
Gray 80 Hover / #4C4C4C
hover white elementshover Gray elementshover transparent elements

$active-ui
Gray 30 / #bebebe
same as white
Gray 70 / #565656
Gray 60 / #6F6F6F
Active background color for ui-01

$selected-ui
Gray 20 / #dcdcdc
same as white
Gray 80 / #3D3D3D
Gray 70 / #565656
selected state

$hover-selected-ui
Gray 20 Hover / #CACACA
same as white
Gray 80 Hover / #4C4C4C
Gray 70 Hover / #656565
data table selected row hover

$hover-danger
Red 60 Hover / #ba1b23
same as white
same as white
same as white
Support-01 hover

$active-danger
Red 80 / #750e13
same as white
same as white
same as white
Active color for support-01

$hover-row
Gray 10 hover / #e5e5e5
same as white
Gray 90 Hover / #353535
Gray 80 Hover / #4C4C4C
Row hover

$visted-link
Purple 60 / #8a3ffc
same as white
same as G90
Purple 40 / #BB8EFF
Visited state for link

$disabled-01
Gray 10 / #f3f3f3
White / #ffffff
G90 / #282828
G80 / #3D3D3D
disabled fields backgrounddisabled backgroundsdisabled border

$disabled-02
Gray 30 / #bebebe
same as white
G80 / #3D3D3D
G70 / #565656
disabled elements on $disabled-01 (Gray 10)disabled label on $disabled-01 (Gray 10)disabled text on $disabled-01 (Gray 10)disabled icons on $disabled-01 (Gray 10)disabled borderdisabled background

$disabled-03
Gray 50 / #8c8c8c
same as white
G60 / #6F6F6F
G50 / #8C8C8C
disabled text on $disabled-02 (Gray 30)disabled icon on $disabled-02 (Gray 30)


Update dependencies. Prefer defer. Bug fix for queue and exchange destroy.

Bug fix - calling destroy on a queue or exchange should defer until they are in ready state
Update machine and monologue versions
Remove when.promise and event handles in favor of deferred promises and transitions

:hand: <-- that's a high-five for Alex


Used SQS in Production "** Too many db tables **"

After 22h of production use of your SQS solution i got an error:
** (SystemLimitError) a system limit has been reached
    (stdlib) :ets.new(:rules, [:set, :public])
    (xmerl) xmerl_scan.erl:418: :xmerl_scan.initial_state/2
    (xmerl) xmerl_scan.erl:300: :xmerl_scan.int_string/4
    (xmerl) xmerl_scan.erl:291: :xmerl_scan.string/2
    (sweet_xml) lib/sweet_xml.ex:233: SweetXml.parse/2
    (sweet_xml) lib/sweet_xml.ex:421: SweetXml.xpath/2
    (sweet_xml) lib/sweet_xml.ex:454: SweetXml.xpath/3
    (ex_aws) lib/ex_aws/sqs/parsers.ex:99: ExAws.SQS.Parsers.parse/2
10:22:19.693 [error] ** Too many db tables **

See: https://github.com/awetzel/sweet_xml/issues/41

Can you talk about your SQS usage a bit? Are you communicating with SQS in a highly concurrent way? Apparently xmerl creates :ets tables for scanning and either you're more concurrent SQS parse requests than there are allowable :ets tables (which we can fix just by upping the max table limit) or somehow xmerl is leaking tables.

I'm using it for a customer project and it is used inside one app of a bigger umbrella project.
In general i do a SQS.receive_message and until the processing is done i start a new receive.
AWS-SQS
The queue is configured like this:

So it should use the longpolling feature.
Here's a cloudwatch view of the outage for this queue:

CODE
Here's an extract of the relevant code fragments, that communicate with SQS:
datasync.ex (main):
defmodule Datasync do

	alias Datasync.Worker

# ...

	def start_link( ) do

		# ...

		import Supervisor.Spec

		children = [
			# Start the endpoint when the application starts
			worker( Worker, [ { qeue_name( ), queue_url( ) } ] )
		]

		opts = [ strategy: :one_for_one, name: Datasync.Supervisor ]
		Supervisor.start_link( children, opts )
	end

# ...

end

datasync/worker.ex:
defmodule Datasync.Worker do

	use GenServer
	require Logger

	alias Datasync.Messages

	def receive do
		GenServer.cast( __MODULE__, { :receive } )
	end

	def process( msg ) do
		# here messages will be processed  ...
	end

# ...

	# GENSERVER API
	def start_link( { queue, queue_url } ) do
		GenServer.start_link( __MODULE__, { queue, queue_url }, name: __MODULE__ )
	end

	def init( { queue, queue_url } ) do
		# start receiving messages
		receive( )

		{ :ok, { queue, queue_url } }
	end

	def handle_cast( { :receive }, { queue, queue_url } ) do

		process_receive(
			Messages.receive( [
				max_number_of_messages: 10,
				visibility_timeout: @visibility_timeout,
				wait_time_seconds: @wait_time_seconds,
				attribute_names: [
					:ApproximateReceiveCount,
					:ApproximateFirstReceiveTimestamp,
					:SentTimestamp
					]
			], queue )
		)

		# rerun receive to keep the worker running
		receive( )

		{ :noreply, { queue, queue_url } }
	end

	defp process_receive( { :ok, [ ] } ), do: Logger.debug "Datasync.Worker: got empty reply"

	defp process_receive( { :ok, messages } ) do
		Logger.debug "Datasync.Worker: got `#{ Enum.count( messages ) }` messages"
		for msg <- messages do
			process( msg )
		end
	end

	defp process_receive( { :error, error } ) do
		Logger.error( "Datasync.Worker: Error receive messeages - #{ error }" )
	end

	defp process_receive( _ ) do
		Logger.error( "Datasync.Worker: Unkown return" )
	end

# ...

end

datasync/messages.ex:
defmodule Datasync.Worker do

	alias ExAws.SQS, as: SQS
	alias Datasync.Handler
# ...

	def receive( opts \\ [ ], qname \\ @queuename ) do
		SQS.receive_message( qname, opts )
			|> ExAws.request
			|> Handler.handle( :receive_message )
	end

# ...

end

datasync/handler.ex:
defmodule Datasync.Handler do

# ...

	def handle( { :ok, %{ body: %{ messages: messages } } }, :receive_message ) do
		{ :ok, messages }
	end

# ...

end

Interesting. I will look into why it's holding onto tables. In the mean time you should be able to do a work around by doing:
task = Task.async(fn ->
			Messages.receive( [
				max_number_of_messages: 10,
				visibility_timeout: @visibility_timeout,
				wait_time_seconds: @wait_time_seconds,
				attribute_names: [
					:ApproximateReceiveCount,
					:ApproximateFirstReceiveTimestamp,
					:SentTimestamp
					]
			], queue )
end)
Task.await(task, some_reasonable_timeout)

This will run each sweet_xml parse in its own process. :ets tables are tied to the process that creates them. Thus when the process quits, it will kill any attached :ets tables that are still alive.

Someone suggested another possibility: If you're creating:ets tables anywhere else and leaking them, eventually :xmerl will ask for a table and there won't be any more.
Basically even if this is an :xmerl issue, it definitely isn't an ExAws issue, so I'm gonna close this for now.

same error here :
  (xmerl) xmerl_scan.erl:291: :xmerl_scan.string/2
  (sweet_xml) lib/sweet_xml.ex:233: SweetXml.parse/2
  (sweet_xml) lib/sweet_xml.ex:421: SweetXml.xpath/2
  (sweet_xml) lib/sweet_xml.ex:454: SweetXml.xpath/3
  (ex_aws_sqs) lib/ex_aws/sqs/parsers.ex:99: ExAws.SQS.Parsers.parse/2

Hey @safwanolaimat this isn't actually the same error, I'd consider looking for help on the forums, slack or IRC.


Bad performance in 1.5.2 vs 1.3.0

After upgrading to 1.5.2 we have worse performance of real time streaming (basically it is unusable).
This is probably due to some defaults that  have changed on the producer side between versions that we are not setting and have negative impact.
Is there a way to print all the settings of the producer after it is created?
We would like to compare all settings of 1.5.2 vs 1.3.0 to find what tare the changes.
Is it possible?

It's not possible to get the merged user/default config after startup with the .net client.
We've changed some defaults as per https://github.com/edenhill/librdkafka/issues/2853, which were optimized for extremely high throughput use cases. The downside was a lot of latent network usage and excessive pre-caching for most users (causing problems for users paying for usage based on bandwidth).
The new defaults are still high, and should be suitable for the majority of use cases (even high throughput).

we have exactly  the opposite effect of this.  We tested it few time by having the same code running with 1.3.0 and with 1.5.2 side by side...
we will investigate this more...

You might also like to enable debug logging (may be very verbose if throughput is high). Perhaps Debug = broker will help, or broker,protocol or all if you can.

Thanks. I'll also check this


Update github/codeql-action digest to f779452

This PR contains the following updates:

Package
Type
Update
Change

github/codeql-action
action
digest
c36620d -> f779452

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Branch automerge failure
This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.

Branch has one or more failed status checks


erikre-docs-9315145

Adding video to tutorial content. @tdykstra - Please review.

I have an updated video link. I'll add it.

@tdykstra - Fixed and ready to go. If you see any issues, let me know. Thanks

The video is well done but it's just a 34 second reading of the intro -- it doesn't go through the steps of the tutorial. I'm afraid most of those who would play the video would be disappointed, as the expectation would be the video would guide you through the tutorial.

@tdykstra - Yes, I see your point. I can look into adding video steps using Camtasia and then integrating it into the video. If I am able to do this, I can then review it with you to see if it seems right for this content when it is complete. I'll go ahead and close this PR now.


Synchronise with Ruuvi Network automatically after minimised (not killed) app is opened again

Currently auto sync requires killing the app first.

I set threshold of 1 minute -  so keep it in mind. At least 1 minute should pass between sync

Auto sync works. QA passed for this card.


Graceful shutdown for log_parser and ingestor_* jobs in Logstash 1.6

There is some ongoing work for Logstash 1.6 concerning graceful shutdown - https://github.com/elastic/logstash/issues/3451
When upgrading, we should also ensure that we send the TERM signal on shutdown (followed by KILL) to give Logstash the opportunity to shut down gracefully.
See the .deb package for an example - https://github.com/elastic/logstash/blob/master/pkg/logstash.sysv.debian#L119-L142

@dpb587 - Currently we shutdown the log_parsers with a call to kill_and_wait; which I assume sends a KILL signal.
However, I note that we appear to have "graceful shutdown` messages in the logs.
{:timestamp=>"2015-07-16T23:50:25.752000+0000", :message=>"SIGTERM received. Shutting down the pipeline.", :level=>:warn}

Is kill_and_wait polite already?  (Ie, does it send a TERM and only later a KILL)

So.. the default kill is a TERM, so we're already doinging a graceful shutdown - see https://github.com/logsearch/logsearch-boshrelease/blob/develop/jobs/log_parser/templates/helpers/ctl_utils.sh#L73
Nothing to see here.  Move along


$ make test

** READ THIS FIRST! **
Are you looking for help?
Reminder: The issue tracker is not a support forum.
Issues should only be filed in this project once they are able to be reproduced
and confirmed as a flaw in the software or incorrect information in associated
documention.
If you are encountering problems integrating this module into your application,
please post a question on the discussion forum
rather than filing an issue.
Is this a security issue?
Do not open issues that might have security implications.  Potential security
vulnerabilities should be reported privately to<EMAIL_ADDRESS> Once any
vulerabilities have been repaired, the details will be disclosed publicly in a
responsible manner.  This also allows time for coordinating with affected parties
in order to mitigate negative consequences.
If neither of the above two scenarios apply to your situation, you should open
an issue.  Delete this paragraph and the text above, and fill in the information
requested below.

Expected behavior

Actual behavior

Steps to reproduce

// Format code using Markdown code blocks

Environment

Operating System:
Node version:
passport version:

No details have been provided. Closing. If there's an issue to report, please reopen with details.


Fix testarina after init change

Purpose
This PR will fix module loading during ballerina tests. Also this will fix starting services and data driven tests.
Fixes #17866 #17865 #12553
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #17970 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #17970   +/-   ##
=======================================
  Coverage   15.23%   15.23%
=======================================
  Files          46       46
  Lines        1208     1208
  Branches      188      188
=======================================
  Hits          184      184
  Misses       1010     1010
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daff974...5541060. Read the comment docs.


Where to find the latest version number?

As in the title.
I found in an other issue discussion that we are already at 2.1.2
How can I now the current version?
Thanks,
Giacomo

Just found on the Jitpack badge on the top of the page. As of today, the version is 2.1.3
https://jitpack.io/#chrisbanes/PhotoView


Uppercase URL in Search box is not correctly processed

Search "ETHPAYS.ME" and "ethpays.me" did show a different result.
Further more, input character case handling and others have to be carefully examined in the process pipeline upon variation of search string such like with or without "http://", trailing slach char etc. ,  in order to avoid false negative/positive result  for users manually accessing it.

cc: @hahnmichaelf

Hi Seki, this is now fixed and on production


Update for showing red color to error messages.

Coverage remained the same at 50.702% when pulling 85d38830bf9ecc0ea8f01be2800d87817ee3d44d on wknet123:dev-fix-message-colors into 05759cf0adcf289825ba07f844744215f8594e2e on vmware:dev.


Setting select by mouse to true for consistency across samples.

@ldanzinger @JamesMBallard Ready for review. Thanks!
Updated all the samples containing a TextField to enable, selectByMouse after making the change to the sample viewer. I am not expecting any issues as none of them are contained in a flickable but in any case, I tested all of the changed samples on Android and didn't find any issues.

@jared-esri this one is good to merge whenever you're ready now that the codebase is open.


Extend type in class

I'm trying to build models that accept subtypes of themselves* as constructor arguments. Basically as a base class (which doesn't work as this can only occur covariantly):
class BaseClass<T> {
  constructor(obj?: this) {  }
}

Another idea was to specify that a class inherits all properties of a type. The obvious
class BaseClass<T> extends Class<T> {
  constructor(obj?: T) {  }
}

does not work, as Class<T> can't be resolved (as it isn't an actual JS value).
Is there a nice way to implement this, or do I need to resort to declarations or duplicated types?

* or $Shapes of the subtypes, but that isn't the issue here

Something like this?
class Base {
  constructor<T: Base>(obj?: T): this {
    return this;
  }
}
class Ext extends Base {
}
const ext = new Ext();
const foo = new Base(ext);

Oh, if you mean you want this generically for each classes in an inheritance chain, I don't think there's a way to do that currently.
You might be able to put together a solution with some combination of class expressions and intersections but I suspect it'd be too much trouble. You'd probably end up losing whatever advantage there was to using classes to begin with.
I think a mostly structural approach (using interfaces and intersections) will end up being a lot easier to work with here than a nominal approach (using classes).

Thanks a lot @freebroccolo!


Fix typos in uri-spec.xml

@deadtrickster that's a bit too concise. I'm not sure what the typos are exactly. You seem to be re-arranging table cells: can you please elaborate?

@michaelklishin sure, I'm implementing connection string support now and therefor writing parser tests (https://github.com/cl-rabbit/cl-bunny/blob/master/t/unit/connection-spec.lisp). I'm using uri-spec as a reference. And Appendix A tables says ""amqp://host/" should be parsed with port="host" as well as "amqp://host/%2f". Maybe I'm mistaking here but looks like a typo to me

Thank you.


Update runner version to v2.169.0

relates to https://github.com/actions/runner/pull/435

Thank you for the PR!
I think this has been fixed in #36.


Revert "update: using downloadablefont instead of local file"

Issue

close #802

Overview (Required)

Two lines may not be displayed due to downloadable font
Reverted to use local files instead of downloadable fonts

Links

Screenshot

Before
After

Please run spotlessApply 🙏
And there are preview changes. This is because downloadable fonts are not applied when previewing, right?

run & push deone.
About the preview
I'm not sure downloadable fonts are applied in the preview.
I think it was probably applied because I made it use a local font.

Thanks for addressing the problem!


How do i start WebApp

How do i start WebApp

to start the web app you have different option if you want to host it on your tomcat server here's the steps

First create a webapp
To create war file, you need to use jar tool of JDK. You need to use -c switch of jar, to create the war file. Go inside the project directory of your project (outside the WEB-INF), then write the following command

 jar -cvf application.war *
``
( Here, -c is used to create file, -v to generate the verbose output and -f to specify the archive file name. )

after creating the war file you can run it on any web server that supports java some recommendations are ( tomcat, glashfish )

---

Also if you like to run it on like a ide so that you can play with more things as a example you can change things and so and so, to run with a ide i can recommend you ide like intelj, netbeans.

you can just import the project and execute it then the ide will do all the magic for you :)

hope this helps! let me know if you have any issues running the web application


Create query generator for CBS OData v3 API

Objective
The CBS OData v3 API follows the star-schema design pattern. The TypedDataSet contains dimension tables, which are described in DataProperties.  We want an SQL generator that is able to generate the flattened datamart tables (see examples below)
Scope

[ ] SQL code generator for automatic generation of CREATE OR REPLACE ...  up to JOIN clauses. Idea is to use f-strings for parameterizing quearies FROM dataverbinders.mlz.... with f"FROM {project}.{schema}. ...
[ ] SQL code generator for automatic generation of WHERE clause to excluded sub-totals and aggregations from the TypedDataSet
[ ] Integrate code generator in Prefect BigQueryTask om dit soort queries via Prefect in een flow te stoppen

Note that as a first MVP, a function that can be used by ETL developers to generate a first, rough SQL query is already useful. This query would then be completed by hand, and then committed in the .sql files in the codebase.

DROP TABLE IF EXISTS `dataverbinders.dso.gebruik_wmo_pgb_gemeente`;

CREATE TABLE `dataverbinders.dso.gebruik_wmo_pgb_gemeente`
PARTITION BY RANGE_BUCKET(jaar, GENERATE_ARRAY(2015, 2020, 1)) AS (

  SELECT
    CAST(Perioden.Title AS INT64) as jaar
    , RegioS.Title as gemeente
    , Geslacht.Title as geslacht
    , Leeftijd.Title as leefijd
    , Huishouden.Title as huishouden
    , Type.Title as soort
    , LeveringsvormZorg.Title as leveringsvorm
    , fct.PersonenMetGebruikInJaar_1 as gebruik_aantal_personen
    , fct.PersonenMetGebruikInJaar_2 as gebruik_percentage
  FROM `dataverbinders.mlz.40060NED_TypedDataSet` AS fct
  INNER JOIN `dataverbinders.mlz.40060NED_Perioden` AS Perioden ON Perioden.key = fct.Perioden
  INNER JOIN `dataverbinders.mlz.40060NED_Geslacht` AS Geslacht ON Geslacht.key = fct.Geslacht
  INNER JOIN `dataverbinders.mlz.40060NED_Leeftijd` AS Leeftijd ON Leeftijd.key = fct.Leeftijd
  INNER JOIN `dataverbinders.mlz.40060NED_Huishouden` AS Huishouden on Huishouden.key = fct.Huishouden
  INNER JOIN `dataverbinders.mlz.40060NED_TypeMaatwerkvoorziening`  AS Type on Type.key = fct.TypeMaatwerkvoorziening
  INNER JOIN `dataverbinders.mlz.40060NED_LeveringsvormZorg` AS LeveringsvormZorg on LeveringsvormZorg.key = fct.LeveringsvormZorg
  INNER JOIN `dataverbinders.mlz.40060NED_RegioS` AS RegioS on RegioS.key = fct.RegioS
  WHERE
    fct.Perioden LIKE '%JJ%'
    AND fct.RegioS LIKE 'GM%'
    AND fct.Geslacht != 'T001038'
    AND fct.Leeftijd NOT IN ('20300', '90120', '90200')
    AND fct.Huishouden != 'T001139'
    AND fct.TypeMaatwerkvoorziening != 'T001024'
    AND fct.LeveringsvormZorg != 'T001306'
)

Het schema dataverbinders.mlz heb ik ingeladen en is best wel groot. Ik ga nog een kopie maken naar dataverbinders-dev. Daarvoor moet mijn account van dataverbinders nog eerst geupgraded worden.

tweede tabel
CREATE OR REPLACE TABLE `dataverbinders.dso.inkomen_huishouden_gemeente`
PARTITION BY RANGE_BUCKET(jaar, GENERATE_ARRAY(2011, 2020, 1))
AS (
  SELECT
    CAST(substr(fct.Perioden, 1, 4) AS INT64) AS jaar
    , regio.Key as gemeente_code
    , regio.Title as gemeente_naam
    , kvh.Key as huishouden_code
    , SUBSTR(kvh.Title, 7) as huishouden_omschrijving
    , fct.ParticuliereHuishoudens_1 as particuliere_huishoudens_aantal
    , fct.ParticuliereHuishoudensRelatief_2 as particuliere_huishoudens_relatief
    , fct.GemiddeldGestandaardiseerdInkomen_3 as inkomen_gestandaardiseerd_gemiddeld
    , fct.MediaanGestandaardiseerdInkomen_4 as inkomen_gestandaardiseerd_mediaan
    , fct.GemiddeldBesteedbaarInkomen_5 as inkomen_besteedbaar_gemiddeld
    , fct.MediaanBesteedbaarInkomen_6 as inkomen_besteedbaar_mediaan
    , fct.GestandaardiseerdInkomen1e10Groep_7 as inkomensgroep_deciel_1
    , fct.GestandaardiseerdInkomen2e10Groep_8 as inkomensgroep_deciel_2
    , fct.GestandaardiseerdInkomen3e10Groep_9 as inkomensgroep_deciel_3
    , fct.GestandaardiseerdInkomen4e10Groep_10 as inkomensgroep_deciel_4
    , fct.GestandaardiseerdInkomen5e10Groep_11 as inkomensgroep_deciel_5
    , fct.GestandaardiseerdInkomen6e10Groep_12 as inkomensgroep_deciel_6
    , fct.GestandaardiseerdInkomen7e10Groep_13 as inkomensgroep_deciel_7
    , fct.GestandaardiseerdInkomen8e10Groep_14 as inkomensgroep_deciel_8
    , fct.GestandaardiseerdInkomen9e10Groep_15 as inkomensgroep_deciel_9
    , fct.GestandaardiseerdInkomen10e10Groep_16 as inkomensgroep_deciel_10
  FROM `dataverbinders.cbs.84639NED_TypedDataSet` AS fct
  INNER JOIN `dataverbinders.cbs.84639NED_Regio` AS regio on regio.key = fct.Regio
  INNER JOIN `dataverbinders.cbs.84639NED_Populatie` AS pop ON pop.key = fct.Populatie
  INNER JOIN `dataverbinders.cbs.84639NED_KenmerkenVanHuishoudens` AS kvh ON kvh.key = fct.KenmerkenVanHuishoudens
  WHERE
    fct.Regio LIKE 'GM%'
    AND fct.Populatie = '1050010'                 -- incl. studenten
    AND kvh.Title LIKE 'Type:%'                   -- uitsplitsing naar type huishouden
    AND fct.KenmerkenVanHuishoudens != '1050055'  -- geen subtotaal Type: Paar, totaal
)

@dkapitan Heb een query generator geschreven, denk alleen wel dat het efficiënter kan dan mijn manier. Weet alleen niet hoe, geen gebruik gemaakt van libraries (i.e. Jinja) zag het nut daar namelijk voor deze queries niet van in.

@TxEddy waar kan ik de code zien?

@dkapitan Onder deze branch en dan flows/dso/dso.py

@TxEddy 'deze branch' is mij niet duidelijk, want issues zijn niet gekoppeld aan een branch :-)

@dkapitan ooh sorry, hij staat in de branch "issue-9-Datamart_dso_is_gemaakt" en dan het mapje dso onder flows.

@dkapitan Heb een nieuwe versie van de query generator net gepushed, zou je deze weer kunnen checken 😬
Script is weer hier te vinden in de branch "issue-9-Datamart_dso_is_gemaakt".

Thanks,
A few questions to get started:

It seems I still do not have the right access on BigQuery to actually
query the data (see screenshot) - can you check it out?
I see that there was actually already an issue, and a branch that Eddie
worked on, with a script inside. Any preference/advice on whether I should
work off of it, or start from scratch? Have you looked at it before?
I haven't installed the nl_open_data as a library. So when attempting to
locally run a script that includes import from it (i.e.  "from
nl_open_data.config import get_config") I get a ModuleNotFoundError. Which
makes sense. I'm wondering if it's better to install the library from
github, or is there a better way to approach this - since I'm working on
the library I'm importing from. I guess this is a basic/general question,
but I haven't had much experience working in development mode, especially
collaborating with others.

Best,
Amit
On Mon, Nov 2, 2020 at 12:13 PM Daniel Kapitan<EMAIL_ADDRESS>wrote:

Assigned #9 https://github.com/dkapitan/nl-open-data/issues/9 to
@galamit86 https://github.com/galamit86.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/dkapitan/nl-open-data/issues/9#event-3947576127, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AICEW6DUY7DA6WMP6YWRMFTSN2H7DANCNFSM4PLWXXUA
.

@galamit86

Screenshot? :-)
I think you're better of starting from scratch
My workflow is to clone locally and do pip install -e . which installs from the current directory in edit mode.

Oops :) -

@galamit86 should be fixed now, have given you full admin rights for GBQ on both projects

Yes, it works, thanks.
However, installing in edit mode doesn't...

Any quick thoughts?

Of course, that makes sense...
Not quite there yet, though.
The -e flag seems to create a strange issue. When I run pip install ., it installs without issues. However, running pip install -e . results in ModuleNotFoundError for 'setuptools'

The 'setuptools' is initially installed when setting up the conda env (shown in conda list). Uninstalling and reinstalling 'setuptools' using pip does not help either.
I saw online that setuptools 50.0 had some issues, but since this is a later version (50.3.2)

Any leads?
Do you know whether setuptools is used also when installing without the -e flag? I think it is, but I'm not certain.
If I don't figure it out, I can just use the regular installation for now, and rerun pip install . every time I make changes to the package, right?

@galamit86
Hard to say without being at your terminal. Seems like you're in Python dep-hell.
My best lead: bite the bullet, Dutch Anaconda and start from scratch on your MacBook with

brew install pyenv
poetry for your package mgnt
http://blog.jayway.com/2019/12/28/pyenv-poetry-saviours-in-the-python-chaos/

Btw running pip update every time will probably work, too

Yes, I had the similar feeling. Thanks for the link, I'll be in touch

I got the initial workings of the generator, you can see it here: https://github.com/galamit86/nl-open-data/tree/query_generator/nl_open_data/datamarts/query_generator.py
Currently, it just does the join on the Topic and simple Dimension types, and outputs a string (I just copy and paste it into the BQ interface to check it).
Next few steps:

Determining where to get the title of the created table from
Handling of other 3 dimension types (TimeDimension, GeoDimension and TimeDimension).
Handling partitioning

And regarding these points:

The most logical place I found for to get the title is is from the 'TableInfos' under 'Title' (or 'ShortTitle'). But I am pretty sure this is not uploaded to BQ or GCS, right?
NA
In the examples you use years to partition. Is that something we should always do?

Anyway - I can go on working, but you can already see the logic and handling I'm using, so if you have any comments, I'm happy to hear.

@galamit86 Sweet! Good to see you managed to tackle this issue so quickly.
I think this is enough on this issue for now. Have quite a few other issues I'd like you to work on, so let's discuss those first.

Sure, that's no problem - at 15:00 I have another meeting, bit any other
time can work
On Wed, 4 Nov 2020, 21:37 Daniel Kapitan<EMAIL_ADDRESS>wrote:

@galamit86 https://github.com/galamit86 Sweet! Good to see you managed
to tackle this issue so quickly.
I think this is enough on this issue for now. Have quite a few other
issues I'd like you to work on, so let's discuss those first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dkapitan/nl-open-data/issues/9#issuecomment-721961935,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AICEW6DRD4ROYERVIRJIAK3SOG3QFANCNFSM4PLWXXUA
.

@dkapitan
My first issue!
Currently working, we'll reopen if/when relevant.


[Event Parameter Request] Table 39 - "Purchase Line"- OnBeforeCheckPrepmtAmtInvEmpty

Please add the following parameter for the event OnBeforeCheckPrepmtAmtInvEmpty in Table 39:
xPurchaseLine: Record "Purchase Line"
local procedure CheckPrepmtAmtInvEmpty()
var
    IsHandled: Boolean;
begin
    IsHandled := false;
+   OnBeforeCheckPrepmtAmtInvEmpty(Rec, IsHandled, xRec);
    if IsHandled then
        exit;

    if "Prepmt. Amt. Inv." <> 0 then
        Error(CannotChangeVATGroupWithPrepmInvErr);
end;

New event signature:
[IntegrationEvent(false, false)]
local procedure OnBeforeCheckPrepmtAmtInvEmpty(var PurchaseLine: Record "Purchase Line"; var IsHandled: Boolean; xPurchaseLine: Record "Purchase Line")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Proposing adding max members in a priv channel

Source https://docs.microsoft.com/en-us/MicrosoftTeams/private-channels

Each team can have a maximum of 30 private channels and each private channel can have a maximum of 250 members.

@LolaJacobsen @LanaChin Please review.
Related issue: https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/4998

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Refine values of constants

We should use the correct values of defined constants, in particular the constant of conversion of H0 from km.s-1.Mpsc-1 to Gyr-1 should not be exactly 1/978!
Definition of parsec: 96,939,420,213,600,000 / pi m
Seconds in a year:

Mean tropical year?<PHONE_NUMBER> x 86,400
Siderial year?<PHONE_NUMBER>02 x 86,400

I think it should be tropical year so that it is Earth time.
I get 1/977,813130685292
Jorrie


Group leader aware reader factory

this is to allow reading content from group leader (as in IO.gets).  We can actually do this, but this is very low priority.


Adding additional user to a Folder Permissions. Selection not activated with OK, need double click.

Adding an existing user to an existing Folder that they no access to.
Set Folder Permissions dialog box, click “+” below “?”.  Highlight name and then select OK. NOT added.
Needed to double click new user in "Choose User To Add" to get selection to be added

Still occurring on v7.0-b155. Seen HS SBX 09/11/21

Still occurring on v7.0-b155. HS SBX on 09/Nov

Still works for me in 157


WIP: Create inteface for updating account key with another key

Requires @hashgraph/sdk to be updated to include AccountUpdateTransaction
Tracking PR:  https://github.com/hashgraph/hedera-sdk-js/pull/83

This is blocked on the Create Account changes as we want to introduce this with the new key editor.
Please re-open as Draft and against master


futures screener missing from list.

In symbol search, type HDFCBANK and select futures. It shows symbol HDFCBANK1!
Currently it is missing from your tradingview list.

Hello @cerebro1,
It's missing from the list because HDFCBANK1! does not have a Technicals tab (see this issue). The scanner API is only accessible when Technicals are available. Unfortunately, this has nothing to do with my project but is a limitation from tradingview itself. However, you can still use the non-futures HDFCBANK.
I'm going to close this issue as it is currently unfixable. If you still have questions don't hesitate to reply. Have a good one.


Remarks?

The Definition section says (emphasis added),

The font weight expressed as a numeric value. See Remarks.

But there isn't any Remarks section.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e1616ba4-6cd2-5eb5-05f7-f72e8ba48af8
Version Independent ID: a57b8e29-dc76-8a97-aa81-1b34d9dd5128
Content: FontWeight.Weight Field (Windows.UI.Text) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.UI.Text/FontWeight.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @Karl-Bridge-Microsoft
Microsoft Alias: kbridge

@PeterCon - thanks for pointing this out. I've revised the topic. It should be live in a few days.


TypeError: Labels() got an unexpected keyword argument 'complete'

When running populate.py, get an error

"TypeError: Labels() got an unexpected keyword argument 'complete'".

I think the problem is in line 37 of populate.py:
labels_model = lt_models.Labels(
                    labels_json_str = json.dumps(labels),
                    complete = complete,
                    creation_date = datetime.date.today())

In image_labelling_tool.models, the Labels() class does not have a positional arg "complete". I suspect you are trying to refer to "completed_tasks".
When I changed the problematic line in populate.py to try and fix the issue:
labels_model = lt_models.Labels(
                    labels_json_str = json.dumps(labels),
                    completed_tasks = complete,
                    creation_date = datetime.date.today())

I get another Django error

TypeError: Direct assignment to the forward side of a many-to-many set is prohibited.

I'm not familiar with Django so was not able to fix that problem and got stuck here.

Hi, sorry about that.
It should be fixed now; both on the GitHub repo and on the PyPI package.


Switch from net5.0 to more compatible netstandard2.0

As of now, I see no need for doing this. I try to focus on my personal use case in this fork.


[Master][Bug] use workerNodeInfoWriteLock to update workerNodeInfo

Purpose of the pull request
Fix #15460 use workerNodeInfoWriteLock to update workerNodeInfo

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (309c8c9) 38.11% compared to head (6502707) 38.11%.

:exclamation: Current head 6502707 differs from pull request most recent head 4eda754. Consider uploading reports for the commit 4eda754 to get more accurate results

Files
Patch %
Lines

...uler/server/master/registry/ServerNodeManager.java
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15461   +/-   ##
=========================================
  Coverage     38.11%   38.11%
  Complexity     4697     4697
=========================================
  Files          1299     1299
  Lines         44774    44774
  Branches       4797     4797
=========================================
  Hits          17066    17066
  Misses        25861    25861
  Partials       1847     1847

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Version 4.3.5

Version 4.3.5

[x] Replace get_proxies method with proxies attribute
[x] Update proto to include WebcastSubNotifyMessage message
[x] Replace old subscribe event logic with new protobuf event
[x] Add sign_api_key parameter for clients requiring bulk access to TikTokLive

Documentation

[x] Clean up old, out-of-date README documentation
[x] Update documentation page
[x] Remove TikTokPrinter advertisement

client.get_proxies() becomes client.proxies. There are no other breaking changes at this time.
Upgrade with pip install TikTokLive --upgrade

Released in https://github.com/isaackogan/TikTokLive/releases/tag/v4.3.5


Add Logout button

"Once people are logged in, you also need to give them a way to log out, disconnect their account, or delete it all together. In addition to being a courtesy, this is also a requirement of our Facebook Platform Policy."
https://developers.facebook.com/docs/facebook-login/userexperience/

https://developers.facebook.com/docs/facebook-login/web


screenshot plugin doesn't capture full game area on new launcher with gpu plugin on

Describe the bug
Taking a screenshot with windows dpi scaling set to 125% doesn't capture the full game area unless GPU plugin is turned off
To Reproduce

Set windows 10 dpi scaling to be 125%
Turn on GPU plugin
Launch runelite with launcher 2.0.0
Take a screenshot with the screenshot plugin

Expected behavior
The screenshot plugin should capture the full game regardless of GPU being turned on or off
Screenshots
With GPU turned on

With GPU turned off

Environment (please complete the following information):

OS: Windows 10
RuneLite version: <IP_ADDRESS>
Launcher version: 2.0.0

Additional context
Launcher logs: https://pastebin.com/M2244Hvu
Client logs: https://pastebin.com/xWx8BJWU

I am having the same issue myself!!
https://i.gyazo.com/16dd2772094440ac190dc61304501347.png

Can you try with the launcher listed here, it has a fix in it that helps with another dpi issue that might solve this aswell.

Can you try with the launcher listed here, it has a fix in it that helps with another dpi issue that might solve this aswell.

Just tried this and it hasn't worked :(

Can someone double check this isn't fixed with launcher 2.0.2?

launcher 2.0.2 works for me
GPU on, 64 bit if that matters


Fix build issue : TerminalApp.h missing

Summary of the Pull Request
Compile/Build issue:
[Build Error] Cannot open include file: 'winrt/TerminalApp.h': No such file or directory

References
Related to #659 and #489, #565

PR Checklist

[ ] Closes #xxx
[x] CLA signed. If not, go over here and sign the CLA
[x] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

After adding the reference -
Yes! VS2019 can build it successfully.
Not so great, building process in VS2017  will fail, with the errors like

Duplicate type Microsoft.Terminal.Settings.**********.

So that's the problem with this fix. The bug exists for 50% of people, and the build fix works for them... but for the other 50%, the build fix actually breaks them. It's completely incomprehensible.

You know, this might be something to summon @kennykerr and @Scottj1s for.
For whatever reason, some people have a problem if the TerminalApp project (many dependencies) doesn't directly reference the TerminalSettings project (no dependencies). However, if we were to change this, then the people who didn't originally have the build error will now have a new error, concerning having duplicate types from TerminalSettings.
Any ideas what we might be doing wrong here?
The linked threads have a lot more info.

It seems like Visual Studio 2019 helps this out a bit, so we might just want to wait until the toolset change lands. I'm going to close this in the meantime.
Thanks for contributing!

I am using Visual Studio 2019 Preview 16.2.0 Preview 2 and it compiles without issues.


Fix decoder with zero-length buffer

Not seen in practice as Node filters them out but fix in case someone wants to
use the decoder algorithm directly.

This was a really obvious bug - cont must always be called after processing chunk.

Good find! Thanks

+1 :+1:  for adding tests!


[Bug]:  Trait "Filament\Forms\Components\Concerns\HasUploadingMessage" not found

What happened?
When I tried to install the plugins to existing filament project using composer
composer require joshembling/image-optimizer
I've got error below
PHP Fatal error:  Trait "Filament\Forms\Components\Concerns\HasUploadingMessage" not found in /pathToProject/vendor/joshembling/image-optimizer/src/Components/BaseFileUpload.php on line 22

   Symfony\Component\ErrorHandler\Error\FatalError

  Trait "Filament\Forms\Components\Concerns\HasUploadingMessage" not found

  at vendor/joshembling/image-optimizer/src/Components/BaseFileUpload.php:22
     18▕ use League\Flysystem\UnableToCheckFileExistence;
     19▕ use Livewire\Features\SupportFileUploads\TemporaryUploadedFile;
     20▕ use Throwable;
     21▕
  ➜  22▕ class BaseFileUpload extends Field
     23▕ {
     24▕     use Concerns\HasUploadingMessage;
     25▕
     26▕     /**

   Whoops\Exception\ErrorException

  Trait "Filament\Forms\Components\Concerns\HasUploadingMessage" not found

  at vendor/joshembling/image-optimizer/src/Components/BaseFileUpload.php:22
     18▕ use League\Flysystem\UnableToCheckFileExistence;
     19▕ use Livewire\Features\SupportFileUploads\TemporaryUploadedFile;
     20▕ use Throwable;
     21▕
  ➜  22▕ class BaseFileUpload extends Field
     23▕ {
     24▕     use Concerns\HasUploadingMessage;
     25▕
     26▕     /**

      +1 vendor frames

  2   [internal]:0
      Whoops\Run::handleShutdown()

Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 255

How to reproduce the bug
install the package from terminal to existing filament project
composer require joshembling/image-optimizer
Package Version
1.3.0
PHP Version
8.2.2
Laravel Version
10.43.0
Which operating systems does with happen with?
macOS
Notes
my composer.json
"require": {
        "php": "^8.1",
        "awcodes/filament-table-repeater": "^2.0",
        "awcodes/filament-tiptap-editor": "^3.0",
        "aymanalhattami/filament-page-with-sidebar": "^2.4",
        "bezhansalleh/filament-shield": "^3.1",
        "codewithdennis/filament-select-tree": "^3.1",
        "darryldecode/cart": "^4.2",
        "dasundev/livewire-dropzone": "^1.0",
        "eightynine/filament-excel-import": "^3.0",
        "erlandmuchasaj/laravel-gzip": "^1.0",
        "filament/filament": "^3.0-stable",
        "filament/spatie-laravel-media-library-plugin": "^3.0",
        "filament/spatie-laravel-settings-plugin": "^3.0",
        "filament/spatie-laravel-tags-plugin": "^3.0",
        "filament/spatie-laravel-translatable-plugin": "^3.0",
        "flowframe/laravel-trend": "^0.1.1",
        "guzzlehttp/guzzle": "^7.2",
        "jenssegers/agent": "^2.6",
        "joshembling/image-optimizer": "*",
        "laravel/framework": "^10.10",
        "laravel/horizon": "^5.21",
        "laravel/sanctum": "^3.2",
        "laravel/tinker": "^2.8",
        "laraveldaily/laravel-invoices": "^3.3",
        "league/flysystem-aws-s3-v3": "^3.21",
        "predis/predis": "^2.2",
        "pxlrbt/filament-excel": "^2.1",
        "ralphjsmit/livewire-urls": "^1.3",
        "saade/filament-adjacency-list": "^3.1",
        "sebastiansulinski/laravel-currency": "^3.2",
        "spatie/image": "^2.2",
        "squirephp/countries-en": "^3.3",
        "squirephp/currencies-en": "^3.3",
        "z3d0x/filament-fabricator": "^2.0",
        "z3d0x/filament-logger": "^0.6.1"
    },

is it meant to be HasLoadingMessage ?

same error here

Hi @koyanyaroo @mateusgalasso
For the latest version of Image Optimizer to work, you need to update your Filament version in your composer.json to "filament/filament": "^3.2".
If you do not want to update and are running an earlier version of Filament, please install "joshembling/image-optimizer": "1.2" and this should work with your Filament 3.0 & 3.1 versions.
I have updated the documentation here to help you further.

it works like a charm thank you @joshembling

Thanks @koyanyaroo


Empty buttons remain visible when they should not

When I open the spellbook or talents all empty buttons on the interface are visible even when the option "always show buttons" in edit mode is not enabled.
When closing the spellbook or talents all empty buttons are supposed to hide again. But often they remain visible.
The only way to solve this is to reload the UI or log out and back in.
I tested on a toon without masque and yours and didnt get this problem. I checked with StormFX first on his page before realizing it might be your addition to his mod that causes the problem.

I'm not able to reproduce this issue and have not seen it before, even though I play with the configuration you described.  A few questions and requests:

Are you running other addons?
What Masque skin are you using?
Does this happen on every character?
Does this happen every time you open and close spell book or talents, or is there something else you have to do?
If you can export and share your edit mode layout string I can try to see if that has any bearing on the issue.

I haven't had a chance to test it yet, but also make sure you don't have "Show Empty Buttons" enabled for your action bar(s).

"I haven't had a chance to test it yet, but also make sure you don't have "Show Empty Buttons" enabled for your action bar(s)."
Im very sure I dont have "show empty button" enabled. At least on all bars except #1 which doesnt have that option. I mean, I would see the empty buttons all the time if it were enabled.
"Are you running other addons that might affect action bars? Feel free to list everything you have installed if you like."
No bar addons, just the default bars. I ruled out sneekee mods and advanced interface options by reproducing the bug without them. No other addons affect the bars.
Right now Im testing my whole list. I disabled everything, log out, enable one, log back in and see if the bug occurs. Will report final findings once Im done.
"What Masque skin(s) are you using?"
Just masque, masque blizzard bars and masque caith.
Im using caith for my (default) action bars, buffs, debuffs and weakaura.
"Does this happen to every action bar or just some of them?"
All action bars that are enabled. First bar has empty buttons always visible by design. Cant change that. But its all other bars from two to six that have the problem.
"Does this happen on every character?"
It seems limited to every max level character with masque enabled. Its the only pattern I found so far. My lvl10 bank characters dont really seem to have the issue.
"Does this happen every time you open and close spell book or talents, or is there something else you have to do?"
When I encounter the bug it happens at the first time of the session when opening either. Because those two windows are the only ones that force the action bars to display the empty buttons.
When the bug occurs I usually reload my interface and then it takes abit for the bug to occur again.
Thats also how how I reproduced the bug multiple times.
Just now when I took the screenshots the first opening caused the bug to occur. I disabled one specific addon to test, reloaded my interface and now I can open the spell book and talent windows as much as I want and it doesnt cause the bug. I logged out, logged back in, still with that one addon disabled, first thing I do is open the spell book and the bug occurs.
My layout:
0 39 0 0 0 7 7 UIParent -9.0 4.0 -1 ##$'%,&('&)$+$ 0 1 0 7 7 UIParent -233.0 3.0 -1 ##$%%/&('&(#,# 0 2 0 7 7 UIParent 215.0 4.0 -1 ##$%%/&('&(#,# 0 3 1 5 5 UIParent -5.0 -77.0 -1 #$$$%/&('&(#,# 0 4 1 2 0 MultiBarRight -5.0 0.0 -1 #$$$%/&('&(#,# 0 5 0 8 8 UIParent -315.0 3.0 -1 ##$%%/&('&(#,# 0 6 0 8 8 UIParent -240.0 108.0 -1 ##$%%/&('%(#,# 0 7 1 1 7 MultiBar6 0.0 0.0 -1 ##$$%/&('%(#,$ 0 10 0 7 7 UIParent -174.0 113.0 -1 ##$$&('% 0 11 0 7 7 UIParent -248.5 128.0 -1 ##$$&('%,# 0 12 1 6 0 MainMenuBar 0.0 5.0 -1 ##$$&('% 1 -1 0 2 2 UIParent -1.0 -25.0 -1 ##$#%# 2 -1 1 2 2 UIParent 0.0 0.0 -1 ##$#%( 3 0 1 8 7 UIParent -300.0 250.0 -1 $#3# 3 1 1 6 7 UIParent 300.0 250.0 -1 %#3# 3 2 1 3 5 TargetFrame -10.0 0.0 -1 %#&#3# 3 3 1 0 2 CompactRaidFrameManager 0.0 -7.0 -1 '#(#)#-#.#/#1$3# 3 4 1 0 2 CompactRaidFrameManager 0.0 -5.0 -1 ,#-#.#/#0#1#2( 3 5 1 5 5 UIParent 0.0 0.0 -1 &#*$3# 3 6 1 5 5 UIParent 0.0 0.0 -1 -#.#/#4& 3 7 1 4 4 UIParent 0.0 0.0 -1 3# 4 -1 0 7 7 UIParent -0.0 167.0 -1 # 5 -1 0 3 3 UIParent 1062.0 -345.0 -1 # 6 0 1 2 0 MinimapCluster -10.0 -10.0 -1 ##$#%#&.(()( 6 1 1 2 8 BuffFrame -13.0 -15.0 -1 ##$#%#'+(()( 7 -1 0 3 3 UIParent -0.0 -210.5 -1 # 8 -1 0 7 7 UIParent -741.0 34.0 -1 #'$A%$&7 9 -1 0 8 8 UIParent -437.5 142.0 -1 # 10 -1 1 0 0 UIParent 16.0 -116.0 -1 # 11 -1 1 8 8 UIParent -9.0 85.0 -1 # 12 -1 1 2 2 UIParent -110.0 -275.0 -1 #K$# 13 -1 1 8 8 MicroButtonAndBagsBar 0.0 0.0 -1 ##$#%#&) 14 -1 0 8 8 UIParent -9.0 43.9 -1 ##$#%0 15 0 0 3 3 UIParent 2.0 506.5 -1 # 15 1 1 7 1 MainStatusTrackingBarContainer 0.0 0.0 -1 # 16 -1 1 5 5 UIParent 0.0 0.0 -1 #( 17 -1 1 1 1 UIParent 0.0 -100.0 -1 ## 18 -1 1 5 5 UIParent 0.0 0.0 -1 #- 19 -1 1 7 7 UIParent 0.0 0.0 -1 ##
It should look like this:
https://up.picr.de/46041842ly.jpg
Normal layout on all my characters:
https://up.picr.de/46041810pa.jpg
Same character with spellbook open and empty buttons visible:
https://up.picr.de/46041813cf.jpg
Same character after closing the spellbook:
https://up.picr.de/46041811am.jpg
Im very grateful for both your time. I totally love the brainstorming over this. Big thanks :)

I was able to reproduce this issue when I include that little addon in my game.
There's not really a huge difference between reloading and initial login for most things, but it's interesting because notifications on login are an exception to this, which explains why this doesn't come back after a reload.  I looked over the built-in interface code around MainMenuMicroButton_AreAlertsEnabled and I don't see an immediate problem, but the code uses the shared HelpTip system, so my theory is that the game wants to show you another notification using the same popup frame and it gets other parts of the UI into a weird state because it never moves on from trying to show the profession notification, or something else on the micro button bar.
Generally it's not a good practice to override built-in functions.  The better practice is to use hooksecurefunc and then when your function runs, undo whatever the game did.  For example, this would immediately hide any popup created by the main menu micro buttons, but it wouldn't acknowledge them so the buttons would still flash.  Like your original code, it would also catch all popups for any micro button, not just profession ones.
hooksecurefunc("MainMenuMicroButton_ShowAlert", function() HelpTip:HideAllSystem("MicroButtons") end)

Let me know if you find any ways to reproduce without this addon loaded, otherwise I think we have your answer.

Thanks. That really helps. The spell book button still blinks and Im sure I find a way around that too. Those small things really iritate me.
Big thanks for the help.


Update To Go 1.15.0

As part of the k8s 1.19 release cycle the Go version is being bumped to
1.15.0. Updating the descheduler to use Go 1.15 prior to the descheduler
v0.19.0 release.
See below issues for reference:

https://github.com/kubernetes/release/issues/1421
https://github.com/kubernetes/kubernetes/issues/93484

/hold
We should wait until the k/k repo is successfully updated to use Go 1.15.0. Also, the descheduler test-infra jobs for the master branch should be updated to use Go 1.15.0.

The k/k repo has been updated with Go 1.15.0: https://github.com/kubernetes/kubernetes/pull/93939. I believe this plan for the k8s 1.19 release is still to use Go 1.15.0.
I believe all that needs to be done now for the descheduler is to update test-infra jobs to use Go 1.15. Then this PR can be retested and merged.

Created PR https://github.com/kubernetes/test-infra/pull/18836 to update the descheduler test-intra jobs to use Go 1.15.

@seanmalloy is the code currently vendored in the descheduler buildable with go1.15?

@seanmalloy is the code currently vendored in the descheduler buildable with go1.15?

Yes, I was able to compile with go 1.15 and run "go mod vendor" and "go mod tidy". No changes to the vendor directory were made when updating from go 1.14 to go 1.15.

I got a little bit closer. I had to update golangci-lint to 1.30.0 to make it work with Go 1.15. But now the new version of golangci-lint is failing with the below errors:
./_output/bin/golangci-lint run
pkg/descheduler/strategies/lownodeutilization_test.go:817:27: copylocks: literal copies lock value from *fakePtr: k8s.io/client-go/testing.Fake (govet)
				&fake.Clientset{Fake: *fakePtr},
				                      ^
pkg/descheduler/strategies/lownodeutilization_test.go:825:50: copylocks: literal copies lock value from *fakePtr: k8s.io/client-go/testing.Fake (govet)
			LowNodeUtilization(ctx, &fake.Clientset{Fake: *fakePtr}, strategy, item.nodes, podEvictor)
			                                              ^
make: *** [Makefile:89: lint] Error 1

@ingvagabund @lixiang233 @damemi any ideas what I need to change to make the new version of golangci-lint happy?

pkg/descheduler/strategies/lownodeutilization_test.go:817:27: copylocks: literal copies lock value from *fakePtr: k8s.io/client-go/testing.Fake (govet)

@seanmalloy  This error haapens because Fake contains sync.RWMutex and we are passing a copy of Fake which may cause dead lock(it should be referred to through a pointer).
I think we can refactor newFake to create a fake.Clientset just like NewSimpleClientset. E.g.
func newFakeClient(objects ...runtime.Object) *fake.Clientset {
	...

	fakeClient := &fake.Clientset{}
	fakeClient.AddReactor("list", "pods", func(action core.Action) (bool, runtime.Object, error) {
		...
	})
	fakeClient.AddReactor("*", "*", core.ObjectReaction(o))
	fakeClient.AddWatchReactor("*", core.DefaultWatchReactor(watch.NewFake(), nil))

	return fakeClient
}

@lixiang233 @seanmalloy let's drop the fake completely: https://github.com/kubernetes-sigs/descheduler/pull/385

I will rebase this PR after #385 is merged. Then I think it might work.

/retest

/retest

/hold cancel
/assign @damemi @ingvagabund

/lgtm

https://github.com/kubernetes/test-infra/pull/19066/files for Prow for master branch


🐛 [BUGS] - Search engine

Description

With words spliced by spaces, the search engine is less precise
It's impossible to exit the search engine

Reproduction steps
Launch, use the search engine

Screenshots
![DESCRIPTION](LINK.png)

Logs
No response
shell
Window command line
OS
Windows

Thanks :D


Converter USD to EUR

Student, group: Руднев Александр, 3530901/90203
URL: https://github.com/Ralex2105/Converter-USD-to-EUR
Git approach: git-flow

`+


update make dmg to use pkgbuild

As packagemaker is no longer used or available, is it possible to update to pkgutil?

Yeah, this is worthwhile.  pkgbuild support was added to a similar project (Simian) here: https://github.com/google/simian/pull/5    If you have some scripting chops, you could use that as a model to implement this, otherwise we'll try to get to it soon.

I shall take a stab at it.

Notice also the added file in https://github.com/google/simian/commit/a8b03c654cfe81d0a191f23eae36f429ea816814 (postinstall, which was essentially a copy/branch of postflight, with some pkgbuild-specific changes; to see the differences, clone simian then do "diff postflight postinstall").  I think we need a postinstall script here too?  I'm not very familiar with pkgbuild OR packagemaker, unfortunately...


TOMEE-3893 - Upgrade to jackson <IP_ADDRESS>

Thanks for the heads up, @cesarhernandezgt - I updated the jira :)


Warnings + EOL FIX

lines #8 and #9 are going to address an issue that causes warnings to be displayed in hexchat each time anyone posts a https link in chat
line #47 will strip End Of Line out of website titles so that they will be shown in a single line. Can be useful because some websites (i.e. imgur.com albums) put some End Of Line characters at the beginning of page title, resulting in a ugly and confusing ECHO.

Thank you. As per @TingPing, requests.packages.urllib3.disable_warnings() could be used in lieu of the import. I'll add this later unless you want to add it yourself.


add missing performance event type and arrange alphabetically

PERFORMANCE_EVENT was missing, so is added
Arrange values alphabetically

LGTM


Issue creating new Scumblr task search

Hi,
I have an issue where after tying my API keys for Google, Facebook, eBay, etc... I continue to get access denied or error messages when attempting to create new tasks that search these services. I checked the permissions for scumblr.rb and they don't appear to be different from the other files. I'm not sure how to troubleshoot further. Any suggestions?
Thanks in advance

Hi, can you be more specific on the error messages your receiving and from where? If you could post screenshots of the errors your getting it might be useful.

Yep, screenshots are attached. In Scumblr WebUI, under TASKS, New Task, essentially all the API keys I defined in /home//Scumblr/environments/initializer/scumblr.rb are not working.

A few things,

I'm assuming you've restarted your server?
The path you posted for the scumblr.rb file is not correctly. The location should be /home/Scumblr/config/initializers/scumblr.rb Please make sure it's in the right place.
If fixing the above doesn't work can you please post a (redacted) screenshot of your scumblr.rb file?

Thanks

Ahoernecke,

Yes. No luck.
So I would need a user named Scumblr or ensure the Scumblr folder is in the /home system directory itself and not inside a specific user folder?

Thanks

Based on your original comment it appeared the scumblr root directory was /home/Scumblr... It doesn't really matter what this is, but where have you have the scumblr code there should be a /config/initializer folder. This is where the scumblr.rb file need to be. In other words:
<scumblr folder>/config/initializers/scumblr.rb

ahoernecke,
apologies for misclarification. original path was /home//Scumblr, but when I move to /home/Scumblr, I now see several new sections where I didn't before. That definitely helped! I don't understand the API error part. It's in the correct location: /home/Scumblr/config/initializers/scumblr.rb and the scumblr.rb.example file was taken out. File permissions are set to 0664.

Can you post a redacted version of your scumblr file and a directory listing for the initializers folder?

I did. Please see original thread: https://github.com/Netflix/Scumblr/issues/135

Oh thanks, I missed it. I think I see what's happening here... The ENV["..."] syntax will load the value from an environment variable. So for example you have the google application set to ENV["Scumblr"]. This is going to check for an environment variable named "Scumblr" and set the value to that variable's value.
From looking at your config, I think what you've done is put the actual secret value in the quotes (i.e. ENV["secret here"]. This won't work because it will be looking for a environment variable with the secret's name.
If this is right you have two options:

Either change the config back to the same and then set the appropriate environment variables to the secret values

or

If you'd rather put the secrets inline just change the config to be like this:

config.google_developer_key = "secret_here"

(In other works get rid of the ENV[] part)

Np. Ah, I see I see. That makes sense. I completely overlooked something. Okay, I'll give that a try.

I confirmed it works! Thank you. :)


🎯 Summer 2024 Planning meetings

We'll try a slightly different format for our meeting notes this summer, and keep them all in a single thread. This is it!

Monday June 2, 2024

[ ] Office space, desks, keys, etc.
[ ] Setting up computers
[ ] Using github

[ ] How to write a good issue
[ ] How to use issues to track work process
[ ] Github branching, pull requests, etc.

monday June 10
mark
Structuring the week

[ ] Items from last week that remain open
[ ] Introducing new tasks
[ ] Plan for timings

Week 2 wrapup, Friday June 14

what did you work on with each other this week?
what was the hardest thing you had to do this week?
what is still open?
what did we finish?

Week 3 planning meeting, Monday June 17
Getting started

What is the best class you've taken so far, and why?

Open issues
Deliberation

https://github.com/Watts-Lab/researcher-portal/issues/30 @JamesPHoughton
https://github.com/Watts-Lab/researcher-portal/issues/48
https://github.com/Watts-Lab/researcher-portal/issues/44

New issues
Shared

https://github.com/Watts-Lab/surveys/issues/183

Week 3 wrapup:
How did you help each other this week?
What did you learn this week?
What did we finish?
What is still open?

Week 4 Kickoff, June 24, 2024
Open issues

https://github.com/Watts-Lab/surveys/issues/183
looking at cypress testing for code coverage

Deliberation

https://github.com/Watts-Lab/researcher-portal/issues/44
https://github.com/Watts-Lab/researcher-portal/issues/48
https://github.com/Watts-Lab/researcher-portal/issues/54
https://github.com/Watts-Lab/researcher-portal/issues/15

Common sense

https://github.com/Watts-Lab/commonsense-platform/issues/111
https://github.com/Watts-Lab/commonsense-platform/issues/146
https://github.com/Watts-Lab/commonsense-platform/issues/128

New Issues
Deliberation

https://github.com/Watts-Lab/researcher-portal/issues/64

Common sense

Week 4 Wrapup: June 28, 2:00pm
How did someone help you this week?
What isn't working for you at the moment? (e.g. prettier autoformatting for @christabusho!)
What did we finish?
Deliberation
Common sense
What is still open?
Deliberation
Common sense

Week 5 Planning meeting, July 1
Getting Started

What personal projects/hobbies are you working on this summer?

Open Issues
Deliberation

https://github.com/Watts-Lab/researcher-portal/issues/66
https://github.com/Watts-Lab/researcher-portal/issues/54
https://github.com/Watts-Lab/researcher-portal/issues/48
https://github.com/Watts-Lab/researcher-portal/issues/44

Common Sense
New Issues
Common Sense
Deliberation

no new issues this week

Just adding here because editing was not working (perhaps @JamesPHoughton is editing at the same time):
Common Sense

https://github.com/Watts-Lab/commonsense-platform/issues/150
almost done https://github.com/Watts-Lab/commonsense-platform/pull/157
almost done https://github.com/Watts-Lab/commonsense-platform/pull/152

New Issues
Common Sense

https://github.com/Watts-Lab/commonsense-platform/issues/158

Week 6 review meeting
Getting started

What tool did you learn about or learn how to use better this week?

Week 7 (!!) planning meeting
Getting started:
Open Issues
New Issues
Discussion: Strategizing the home stretch

Week 8 Planning meeting
Getting Started: What are you hoping to learn in the next 6 months?
Stuck/Blocked issues:
Other Open issues:

Getting started:
What was the most difficult thing you did this week

@shapeseas: Got poison ivy, had to deal with the consequences! What to do now with the rest of the yard?
@dankim444: Time management, helping some high school data science projects and also doing a bunch of other stuff
@acao22: Moving stuff to new apartment
@markwhiting: Carried a really heavy bag of groceries and a baby. Got a bruise.
@christabusho: Time management too! Semester abroad starts this fall, there was a pre-orientation meeting, visa interview.
@JamesPHoughton: getting rid of wasps
@evanping: preparing for recruiting season.

What did we finish

https://github.com/Watts-Lab/commonsense-statements/issues/18
https://github.com/Watts-Lab/commonsense-platform/pull/167
https://github.com/Watts-Lab/commonsense-statements/pull/19

What is almost done

https://github.com/Watts-Lab/commonsense-platform/issues/146

What is still open

https://github.com/Watts-Lab/researcher-portal/issues/63

What is stuck

https://github.com/Watts-Lab/commonsense-platform/issues/147

Monday July 29

https://github.com/Watts-Lab/deliberation-empirica/issues/869

August 5 Planning meeting
Getting started: What have you learned this summer?
Tasks we are finishing up this week
Deliberation
Common Sense
Tasks we are packaging for the fall
Deliberation
Common Sense
New goals for the fall


Add various tools

Added yash in 939fe5e588f78bde2a5135d2a275afbdbaccd529. The other tools still do not yet meet the notability requirements for this repository, so I will refrain from adding them at this time. I'll leave the PR here open, though, in case that situation changes.

esh received 50th star today. :star:

Added esh in https://github.com/alebcay/awesome-shell/commit/5dfbc73176784bb950ee9ab345e60350f2dd69fc.


[BUG] LCMV beamformer does not inform about channel discrepancies

According to :ref:ex-source-loc-methods, the DICS beamformer at least only accepts a single channel type at a time. Since the covariance can be computed for both meg and eeg, that can be passed to apply_lcmv but then the filter channel names only include the meg channels so I assume the eeg channels are tossed. It seems that there should at least be a warning but probably more appropriately a NotImplementedError when eeg channels are passed that they will not have corresponding filters returned. cc @britta-wstnr

Can you clarify/tell me if I understand correctly that it is the latter case:
did make_lcmv just drop EEG channels, or did apply_lcmv drop them because your filter was done on MEG only?
If it is the latter case, then this behavior is expected and logical, but maybe we could still inform the user, by adding something like Warning: dropping any channels that are not present in the filter.

The first case where you pass in a covariance matrix with eeg also and you get out filters with only meg and no warning.

Ah you're right, the covariances actually were restricted before the beamformer, sorry!

Okay I would make this restriction a logger.info message rather than a warning

It was actually the forward model my bad! I think we could still log in beamformer that there was a channel mismatch.

@britta-wstnr @larsoner I was wondering whether I could take care of this issue (found it through a link to easy ones from the contribution guide).
I briefly looked at the code, and if I understood correctly, the function mne.utils.check._check_info_inv is taking care of the consistency between channels in the info, forward model, and the covariance matrices (both data and noise). Currently, the function mne.utils.check._compare_ch_names is called three times to remove channels that are not in fwd['info']['ch_names'], data_cov.ch_names, and noise_cov.ch_names. In between, MEG reference channels are also removed through a list comprehension. Should I log all removals separately including the number of channels removed, or just mention once that some channels were removed?

Hi @ctrltz!
As far as I can see, this is indeed not implemented yet, so it would be great if you could take it on.
I think we should log this once, not each time channels get dropped.


feat: add sandbox environment support

What is the purpose of this pull request?
This PR introduces support for a sandbox environment in the Subi Connect library. It adds a new environment variable for the sandbox base URL and implements logic to switch the connection service's base URL when the sandbox environment is specified.
What problem is this solving?
This change allows developers to test their integrations in a sandbox environment without affecting production data. It provides a safer way to develop and test features before deploying to production.
Types of changes

[x] Feat: (new functionality)
[ ] Bug fix: ([#ref number] non-breaking change which fixes an issue)
[ ] Chore: (improvements that will not reflect in production behaviour)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Requires change to documentation, which has been updated accordingly.

#184  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @keeganpotgieter and the rest of your teammates on  Graphite


Passing displayName configuration to the filters

There are certain filters that can benefit from high level configurations.
A use case:
prefix some inner node's properties with the file name to prevent collisions like in the case of masks and clip paths

@jhamlet can you please look into this?


dex-oidc: 2.38.0 -> 2.39.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dexidp/dex/releases.
meta.description for dex-oidc is: OpenID Connect and OAuth2 identity provider with pluggable connectors
meta.homepage for dex-oidc is: https://github.com/dexidp/dex
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2.39.0 with grep in /nix/store/sg0m7qbswms3ijqvw716wn13nqdfp8w2-dex-2.39.0
found 2.39.0 in filename of file in /nix/store/sg0m7qbswms3ijqvw716wn13nqdfp8w2-dex-2.39.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
dex-oidc
nixos-install-tools
tests.nixos-functions.nixos-test

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/sg0m7qbswms3ijqvw716wn13nqdfp8w2-dex-2.39.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dex-oidc https://github.com/r-ryantm/nixpkgs/archive/b9e09e83a31f65c040fc5820222f7200b5865adb.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b9e09e83a31f65c040fc5820222f7200b5865adb#dex-oidc

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/sg0m7qbswms3ijqvw716wn13nqdfp8w2-dex-2.39.0
ls -la /nix/store/sg0m7qbswms3ijqvw716wn13nqdfp8w2-dex-2.39.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

1 package built:

dex-oidc

Maintainer pings
cc @benley @techknowlogick for testing.

(finished: waiting for unit dex.service, in 14.01 seconds)
machine: waiting for success: curl -fs 'localhost:8080/dex/auth/mock?client_id=oidcclient&response_type=code&redirect_uri=https://example.com/callback&scope=openid'
(finished: waiting for success: curl -fs 'localhost:8080/dex/auth/mock?client_id=oidcclient&response_type=code&redirect_uri=https://example.com/callback&scope=openid', in 0.07 seconds)
(finished: subtest: Web server gets ready, in 14.08 seconds)
subtest: Login
machine: must succeed: curl -fs 'localhost:8080/dex/auth/mock?client_id=oidcclient&response_type=code&redirect_uri=https://example.com/callback&scope=openid' | sed -n 's/.*state=\(.*\)">.*/\1/p'
(finished: must succeed: curl -fs 'localhost:8080/dex/auth/mock?client_id=oidcclient&response_type=code&redirect_uri=https://example.com/callback&scope=openid' | sed -n 's/.*state=\(.*\)">.*/\1/p', in 0.04 seconds)
Got state sbuxrjy6rwtusnxmpj4gpqgzl
machine: must succeed: curl -fs 'localhost:8080/dex/auth/mock/login?back=&state=sbuxrjy6rwtusnxmpj4gpqgzl' -d 'login=admin&password=password'
machine # [   13.337965] dex[966]: time="2024-03-23T01:28:37Z" level=info msg="login successful: connector \"mock\", username=\"Kilgore Trout\", preferred_username=\"\"<EMAIL_ADDRESS>groups=[]"
(finished: must succeed: curl -fs 'localhost:8080/dex/auth/mock/login?back=&state=sbuxrjy6rwtusnxmpj4gpqgzl' -d 'login=admin&password=password', in 0.05 seconds)
machine: must succeed: curl -fs localhost:8080/dex/approval?req=sbuxrjy6rwtusnxmpj4gpqgzl | sed -n 's/.*code=\(.*\)&.*/\1/p'
machine: output:
Test "Login" failed with error: "command `curl -fs localhost:8080/dex/approval?req=sbuxrjy6rwtusnxmpj4gpqgzl | sed -n 's/.*code=\(.*\)&.*/\1/p'` failed (exit code 22)"

Tests are already failing on master. @Flakebi maybe?

Weird, this test has apparently been failing since October 2022: https://hydra.nixos.org/build/193878086
This point release doesn't make it worse so we might as well merge the PR and fix the test separately.


294 - Add Loader to Download Modal for showing before API has responded

Issue Number
#294
Purpose/Implementation Notes
Created the placeholder componentModalLoader
(minor revision)

Edited css rule for Loader to adjust the centering
Updated the spacing in ProjectSamplesTable

Types of changes
What types of changes does your code introduce?

Bugfix (non-breaking change which fixes an issue)

Functional tests
List out the functional tests you've completed to verify your changes work locally.
Checklist

[x] Lint and unit tests pass locally with my changes

Screenshots
N/A

Resolved the conflict and now ready for marge. Thank you!


Garbled view when using FZF with additional qf formatter plugin

Neovim version (nvim -v | head -n1)
NVIM v0.7.0-dev+1109-gfaeff49cb
Operating system/version
Ubuntu 21.04 on WSL2
How to reproduce the issue

Install https://gitlab.com/yorickpeterse/nvim-pqf
Put items in quick fix list

Now open fzf using zf keybinding

Expected behavior
Text in FZF list should be same as what we see in quick fix list
Actual behavior
Garbled text is being seen (notice many {m, [m and numbers across the list)

This, as you previously mentioned, could be related to concealing.

The reason is nvim-pqf using conceal to hide {}<> chars. The items as a source for fzf is not supported conceal for now, I will try to fix if I have times.

Please try dev branch.

I can still see those messy characters.

Make sure you have changed the dev branch and updated the code. I have tested under clean ENV with docker is fine, only load nvim-bqf, fzf and nvim-pqf.git.

What docker image did you use?

anatolelucet/neovim:0.6.0

Waiting for your solution, maybe some potential bugs I haven't thought about.

@kevinhwang91 so I removed all other plugins, even removed the whole config, updated fzf, updated neovim — but I still couldn't reproduce the right behavaior on my machine, I'll have to adjust with it I guess 🤷♂

I also can't reproduce the screenshot you provided. main branch only with the issue for extra {, I think you should check out the fzf and your terminal ansi escape code.

FYI: you can debug bqf by yourself if you want.

tail -f ~/.cache/nvim/bqf.log
Add log.debug(processed_line) under */nvim-bqf/lua/bqf/filter/fzf.lua:172
BQF_LOG=warn nvim and reproduce the issue and get the log.

So the culprit was my default shell, Fish. I did chsh and switched to bash and now it works fine.

Oddly, when I switched to fish from bash, it worked just fine too. I have dozens of stuff configured in Fish, it could be one of the those things

Thanks for your feedback, I have merged the patch.

@ajitid I found that should be a bug of fzf, and I fix it in https://github.com/junegunn/fzf/pull/2828

Oh, thank you so much @wodesuck!


Validation

Please prefix your issue with one of the following: [BUG] [PROPOSAL] [QUESTION].
Package version, Laravel version
Expected behaviour
Actual behaviour
Exception stack trace
Screenshot of Excel file
Steps to reproduce the behaviour

Closing because of lack of information


Playframework 2.9 runtime error: The application secret is too short

Some folks that deploy MapRoulette locally for dev, use GH actions in some way, or have their own instances will need to update their play application secret. The application service will NOT START without updating to a secret key of at least 32 bytes.
See https://playframework.com/documentation/latest/ApplicationSecret for more information.
This is not an optional change -- it is required to use a key of sufficient length.
What do I need to do?
To avoid runtime errors, you need to update the application secret which is used by the Play framework to encrypt sessions. The secret should be distinct to the server -- do not share the same key between staging, prod, GH actions, local dev, etc.

Get yourself a random key which has sufficient length, one way is to use openssl rand -base64 32 (or head -c 32 /dev/urandom | base64).
Update your setup by using one of two methods in the sub-bullets.

Set secret via conf: Set play.http.secret.key to your secret key.
Set secret via environment variable: The conf will use env variable APPLICATION_SECRET as the secret if it's set. If you have a k8s setup or GH actions, you may set the env in that variable. See this diff for an example

Run the service, it should work

This is the runtime error that is thrown when the application secret is too short:
20:52:28.444 ERROR [][application-akka.actor.default-dispatcher-6][akka.actor.OneForOneStrategy] - Unable to provision, see the following errors:

1) [Guice/ErrorInCustomProvider]: Configuration error: Configuration error[
The application secret is too short and does not have the recommended amount of entropy for algorithm HS256 defined at play.http.session.jwt.signatureAlgorithm.
Current application secret bits: 160, minimal required bits for algorithm HS256: 256.
To set the application secret, please read https://playframework.com/documentation/latest/ApplicationSecret
]
  while locating HttpConfiguration$HttpConfigurationProvider
  at HttpConfiguration$CookiesConfigurationProvider.<init>(HttpConfiguration.scala:331)
      \_ for 1st parameter conf
  at HttpConfiguration$CookiesConfigurationProvider.class(HttpConfiguration.scala:331)
  while locating HttpConfiguration$CookiesConfigurationProvider
  at DefaultCookieHeaderEncoding.<init>(Cookie.scala:387)
      \_ for 1st parameter config
  while locating DefaultCookieHeaderEncoding
  at DefaultRequestFactory.<init>(RequestFactory.scala:94)
      \_ for 1st parameter cookieHeaderEncoding
  while locating DefaultRequestFactory
  at DefaultApplication.<init>(Application.scala:178)
      \_ for 5th parameter requestFactory
  at DefaultApplication.class(Application.scala:177)
  while locating DefaultApplication
  at SchedulerActor.<init>(SchedulerActor.scala:45)
      \_ for 2nd parameter application
  at SchedulerActor.class(SchedulerActor.scala:44)
  while locating SchedulerActor

Learn more:
  https://github.com/google/guice/wiki/ERROR_IN_CUSTOM_PROVIDER

Resolved. Closing.


palindrome checker problem in freecodercamp

Closing Issue/Referencing Issue
issue reference (#)
Changes Made In Pull Request

Thank you so much❤
On Fri, 2 Oct, 2020, 5:29 pm welcome[bot]<EMAIL_ADDRESS>wrote:

I can tell this is your first pull request! Thank you I'm so honored. 🎉🎉
🎉
I'll take a look at it ASAP!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ows-ali/Hacktoberfest/pull/763#issuecomment-702693930,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQQSGH4SXLEDKEEGFRVTU3SIW6BVANCNFSM4SBTNVEA
.

Added roman numerical convertor


Is this library support MSI / Plessey barcodes ..?Thanks in advance

Description of the problem:
Which library version are you using? E.g. 3.2.0.
Which phone/tablet are you using, and which Android version does it run? (e.g. Samsung Galaxy S5,
Android 5.0)
Does the same happen on other devices or an emulator?
Can you reproduce the issue in the sample project included with the library? If not, can you
provide your own sample project or sample code that produces this error?
In the case of an error do you have a stack trace or adb logs?

The full supported list is here: https://github.com/zxing/zxing#supported-formats


Feat/ga/infinite scroll

Issue
https://github.com/SAP/guided-answers-extension/issues/270
Description
Add infinite scroll to the results list
Checklist for Pull Requests

[ ] Supplied as many details as possible on this change
[ ] Included the link to the associated issue in the Issue section above
[ ] The code conforms to the general development guidelines.
[ ] The code has unit tests where applicable and is easily unit-testable
[ ] This branch is appropriately named for the associated issue

Somehow we lost the alternating row background color.
Before
Now

That is fixed now, thanks 👍

Thanks! 👍


kubectl crud tables should use push, not polling

the get -w tables use push, but the crud tables (apply/create/delete) still use polling.

From Kubectl version 1.16, kubectl get -w now takes an --output-watch-events flag to indicate the event type (ADDED, MODIFIED, DELETED) (https://v1-16.docs.kubernetes.io/docs/setup/release/notes/#cli-improvements). This could let Kui watcher know the resource has been deleted without polling.
▶ kubectl get pods --output-watch-events -w
EVENT      NAME                                READY   STATUS             RESTARTS   AGE
ADDED      eventgen                            0/1     CrashLoopBackOff   176        24h
ADDED      myapp-6446557848-d8qvz              1/1     Running            0          68m
ADDED      nginx-deployment-574b87c764-b5xtl   1/1     Running            1          16d
ADDED      nginx-deployment-574b87c764-qkd2w   1/1     Running            1          16d
ADDED      nginx-deployment-574b87c764-rwld7   1/1     Running            1          16d
MODIFIED   myapp-6446557848-d8qvz              1/1     Terminating        0          69m
DELETED    myapp-6446557848-d8qvz              1/1     Terminating        0          69m
ADDED      myapp-6446557848-rnv55              0/1     Pending            0          0s
MODIFIED   myapp-6446557848-rnv55              0/1     Pending            0          0s
MODIFIED   myapp-6446557848-rnv55              0/1     ContainerCreating   0          0s
MODIFIED   myapp-6446557848-rnv55              1/1     Running             0          2s
MODIFIED   eventgen                            0/1     Terminating         176        24h
MODIFIED   eventgen                            0/1     Terminating         176        24h
MODIFIED   eventgen                            0/1     Terminating         176        24h
DELETED    eventgen

we should be good here, now that we're using client/direct to implement watching.

we should be good here, now that we're using client/direct to implement watching.


The Mailchimp box cannot be closed after the JS is activated.

Seems that there is some issue with the JS loading on multiple places on the site. https://kb.mailchimp.com/lists/signup-forms/troubleshoot-the-opt-in-confirmation-email


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 298

Questions ?
Please refer to the Backport tool documentation


Benchmark Datasets (too) Flawed

https://www.reddit.com/r/MachineLearning/comments/j2cqa2/r_current_time_series_anomaly_detection/
Above is a link to a discussion around a paper highlighting issues in NASA, NAB, and Yahoo datasets.
The paper itself has some distracting framing issues but raises excellent points in the benchmark datasets.
Highly recommend effort is made towards resolving the ground truth errors.

Thanks @jaymefosa.
We can move the discussions about datasets into their separate issues #117 and #116.
Closing this for now.


how to use templates with immutable.js ???

I know , I just need to rewrite the lodash map function .like this 👍
_.map = function(m,i){
if(isImmutable){
.....
}
}

I was just writing it :) ... also there is a PR in queue for having custom helpers (_.map)...

to clarify: the PR is #176 and the feature is discussed in #184. It allows to replace the default map function used by react-templates with a custom one. (So for example in your case you don't have to hack _.map() in lodash).


Normal map shading issues

Explorer Alpha build versions:
v0.23
Issue Description:
Many bugs appear in the shading when applying normal maps to a scene.
STR:

The scene is deployed at meshroom.dcl.eth, you can observe the shading issues there.
I think the same issue is happening to the robot's back side in genesis plaza.

Expected behaviour:
Proper shading

Current behaviour:
Bad shading

Additional Notes:
Normal maps work fine in current desktop client but are bad in web.
Windows laptop.

https://decentralandteam.slack.com/archives/C052EKZT2G7/p1725266471063389

More insights here: https://www.notion.so/decentraland/Art-Technical-Things-to-Fix-e288eb138f774b2c9690ce4a27f74f6d @davidejensen @GBirch33


[C++] Bundled OpenTelemetry build is broken

Describe the bug, including details regarding any error messages, version, and platform.
OpenTelemetry and Protobuf have conflicting versions of Abseil, which is causing build errors

https://github.com/apache/arrow/actions/runs/5222129024/jobs/9427236062?pr=35628#step:9:984
https://github.com/apache/arrow/actions/runs/5201352712/jobs/9381376686#step:9:984

These issues have been encountered and addressed in the conda-forge feedstock for opentelemetry, see

https://github.com/conda-forge/cpp-opentelemetry-sdk-feedstock/issues/29
https://github.com/conda-forge/cpp-opentelemetry-sdk-feedstock/pull/48

Unfortunately, the fix requires a patch to OpenTelemetry so it's not as simple as building -D WITH_STL=ON.
For now it should be sufficient to disable bundled OpenTelemetry and rely on conda-forge's patch.
@kou @lidavidm
Component(s)
C++

https://github.com/open-telemetry/opentelemetry-cpp/pull/2163 may fix this.
This may not be happen when we use Protobuf < 3.22?


Categories issue

Hi,
thanks for the great plugin first of all!
I have used several charts so far, but the bar chart surprisingly is giving me a ton of headache.
Managed to implement heatmaps and pie charts on Vue 3, but the bar...
Whenever I try to update the Options to update the categories I get a duplicate of the chart, like so:

Tried using this method, as described here:
        updateBarChartOptions() {

            let cats = this.loadDurationCategories();

            console.log('Categories updating to: ' + cats)

                this.chartOptions4 = {

                    ...this.chartOptions4,
                    ...{
                    xaxis: {
                        categories: cats
                    }
                }
            }
        },

Tried to update them, by just using a computed property, like so:
        durationCategories() {
            let categories = this.loadDurationCategories()
            return categories
        },

Where the loadDurationategories() method just returns a new Array, like: [1, 2, 3.... etc]
The computed property seems to not work at all, as I am getting an error from the slice, indicating that the array never makes it to the chart.
Any help is greatly appreciated!
Thanks!

Forgot to mention one more issue, if you look at the chart, the number of series and the number of categories is exactly the same: 11, but the width doesn't match.

So they all look completely off.

If I bunch all my data into a single Series, then the columns match the categories perfectly, but then then I still have the issue with the duplicate charts, every time I update the Options. However I would prefer to have the separate series for each entry, so I can have different colors.

Check #25 I was having similar issues and it was a matter of the watch not looking deep enough so I updated the entire chartOptions object.