Instance stuck in starting state when invalid ip is provided for "Requested Ip"

Rancher Version: v1.0.0-rc2
When creating a service , provided an invalid value for "Requested Ip" like y.com.
Containers of the service are stuck in "starting" state and following error seen in logs:
INFO: Running /var/lib/cattle/download/host-iptables/host-iptables-66-efd3092449e6559f60c503e80d245b1f97886052c44f8d4e4f51305246678587/apply.sh
iptables-restore v1.4.21: Bad IP address "y.com"

Error occurred at line: 10
Try `iptables-restore -h' or 'iptables-restore --help' for more information.
[[scripts.sh:184] script_env
[[scripts.sh:109] '[' -n http://<IP_ADDRESS>:8080/v1 ']'
[[scripts.sh:110] return
[[scripts.sh:186] export CATTLE_HOME=/var/lib/cattle
[[scripts.sh:186] CATTLE_HOME=/var/lib/cattle
[[scripts.sh:187] export CATTLE_CONFIG_URL=http://<IP_ADDRESS>:8080/v1
[[scripts.sh:187] CATTLE_CONFIG_URL=http://<IP_ADDRESS>:8080/v1
[[scripts.sh:188] export CATTLE_STORAGE_URL=http://<IP_ADDRESS>:8080/v1
[[scripts.sh:188] CATTLE_STORAGE_URL=http://<IP_ADDRESS>:8080/v1
[apply.sh:5] BRIDGE=docker0
[apply.sh:6] docker-1.9 version
[[apply.sh:7] jq -r '.[0].Options["com.docker.network.bridge.name"]'
[[apply.sh:7] docker-1.9 network inspect bridge
[apply.sh:7] BRIDGE=docker0
[apply.sh:8] ip link show dev docker0
[[apply.sh:13] sed 's/-A POSTROUTING //'
[[apply.sh:13] grep -E -- '-A POSTROUTING.* -o docker0 -j MASQUERADE'
[[apply.sh:13] iptables-save
[apply.sh:13] MASQ='-s <IP_ADDRESS>/16 ! -o docker0 -j MASQUERADE'
[apply.sh:15] '[' -n '-s <IP_ADDRESS>/16 ! -o docker0 -j MASQUERADE' ']'
[apply.sh:16] cat
[apply.sh:20] sed -i '/#POSTRULES/r masq-rules' content-home/etc/cattle/host-iptables
[apply.sh:23] sed -i 's/%BRIDGE%/! -i docker0/g' content-home/etc/cattle/host-iptables
[apply.sh:25] apply_config iptables-restore -n etc/cattle/host-iptables
[scripts.sh:147] local file=etc/cattle/host-iptables
[scripts.sh:148] local 'cmd=iptables-restore -n'
[scripts.sh:150] iptables-restore -n content-home/etc/cattle/host-iptables
iptables-restore v1.4.21: Bad IP address "y.com"

Error occurred at line: 10
Try `iptables-restore -h' or 'iptables-restore --help' for more information.
[scripts.sh:151] '[' -e /var/lib/cattle/etc/cattle/host-iptables ']'
[scripts.sh:152] iptables-restore -n /var/lib/cattle/etc/cattle/host-iptables
[scripts.sh:154] return 1

Expected Behavior:
Should do Ip format Validation  for "Requested Ip" field.
Also , we will need ip format validation for "vip" field. If a service is created with invalid ip address format.

Would have to add validation for ip address fields (requestedIP, vip, may be more)

Closing due to inactivity, please reopen if you think this is still relevant to current releases & important.


Added files from build for #4410

Missing files from last commit. #4410

Thanks for adding them, but I did this already in 548dda7a1 😄


Mix to after N mixes ignored if UTXO already mixed more times

If "Mix to" feature is selected during mixing, it apparently not applies to UTXOs which was mixed more times then the threshold. For example, if selected Mix to... after 4 mixes, UTXO with 5 mixes at the time continues to mix for 6th, 7th and so on...

To prevent deanonymisation, there's only a 25% chance of mixing out with each mix over the threshold.


Fix for connectivity to match WriteVTK output

Simple fix for connectivity to align data to match that of WriteVTK. Also fixes manual test of connectivity by incrementing by one.

Auto formatting messed this up. Fixing with another PR.


Put channel in alphabetic order when adding new channels

When using !addclasschans the new channel should be inserted via alphabetic order
Might have to do some sorting, or something like that because the options take just a number for the position

Finding the index is one pass of insertion sort


More docs 1.12.1 cherry picks

@thaJeztah

LGTM

don't merge yet, @tiborvass is working on a cherry-pick for code

don't merge yet, @tiborvass is working on a cherry-pick for code

@SvenDowideit @thaJeztah  can i merge ?

yes, thanks!


Made authorization error window

if empty input or there are no user with this login and password
deleted all spaces in user's input

resolved #34

Что значит deleted all spaces @IlyaM1


DB Referencing

DB wasn't referencing properly users to meals, so we were having issues with IDs, Deleting, Updating meals we also can delete a user now!

God's great


Squoosh Integration

Is your feature request related to a problem? Please describe.
The image widget, and media library currently does not support compressing images and working with a proper srcset with multiple formats.
Describe the solution you'd like
Google has created a web app that resizes, compress and encode images in various formats for the web, it has now landed a CLI and API making possible to embed into any web app.
I'd love to see it implemented on the Image widget, it could be used to create from a single uploaded  image  multiple sizes, quality and formats, like Avif and webp. It would make using srcset a breeze!
Describe alternatives you've considered
I've not found any alternatives to Squoosh yet, and Squoosh is very well maintened by google.

Squoosh also can strip some metadata that people may want to keep private (such as location information). It'd be good to do that before a file is saved to git. I currently do this manually.


ES6: support class extends

Given
class Base {
   say() { .. }
}

class User extends Base { }
Polymer(User)

It's not working. tested on v1.1.4
possible related to https://github.com/Polymer/polymer/pull/2365#discussion_r37827984

Confirmed this doesn't work. Repo: http://jsbin.com/wahepakeri/edit?html,output
Note, vanilla custom elements can extend from a base class that's extending HTMLElement:
http://jsbin.com/neyijafoqo/edit?html,output

Polymer doesn't currently support chained-prototypes as arguments to Polymer() in any context. This is a Roadmap Feature.

If we get element inheritance back, does it unlock this feature?
On Mon, Oct 5, 2015, 9:51 AM Scott J. Miles<EMAIL_ADDRESS>wrote:

Polymer doesn't currently support chained-prototypes as arguments to
Polymer() in any context. This is a Roadmap Feature.
—
Reply to this email directly or view it on GitHub
https://github.com/Polymer/polymer/issues/2520#issuecomment-145596567.

It's more complicated than that.

@sjmiles  I tried to solve this issue.
https://github.com/Polymer/polymer/pull/2604
Please review this!

We're currently working on inheritance support, and we will have a better opportunity to support this use case, #3345.
There are 4 cases we will support for inheritance

MyPolymerElement extends OtherPolymerElement
MyPolymerElement extends HTMLElement
MyPolymerElement extends HTMLOtherNativeElement
MyPolymerElement extends RandomJSClass

For case 1, the answer is simple: do nothing.
For case 2 and 3, we will need to replace the native html element prototype with one that includes Polymer.base.
For case 4, we will find the lowest prototype, Object, and replace that with Polymer.Base on HTMLElement.

@azakus multi-staged inheritance will be supported?
class MyBaseElement extends SomeClass

class MyElement extends MyBaseElement

@laco0416 That should work, but my original statement in https://github.com/Polymer/polymer/issues/2520#issuecomment-176497918 appears to be too hard.
With a few helper functions we can support these use cases:

class MyElement
class MyElement extends Polymer.Element where Polymer.Element is HTMLElement plus the Polymer base class
class MyElement extends Polymer.Extend('input') where Polymer.Extend creates HTMLInputElement chained with Polymer base class
class MyElement extends Polymer.Extend('other-polymer-element'), which can be equivalent to class MyElement extends OtherPolymerElement

I suppose with Polymer 2 class-based syntax this issue has been resolved?

Closing this per above comment.


What is the Different of Api type wadouri and wadors ?

What is the Different of Api type wadouri and wadors ?
The OHIF/Viewers default config use wadors type api.
And will call http url as "https://xxxxxxx/api/studies/1.2.276.0.7230<IP_ADDRESS>.3673727219.2696.1679101870.793/series/1.2.276.0.7230<IP_ADDRESS>.3673727219.2696.1679101871.794/instances/1.2.276.0.7230<IP_ADDRESS>.3673727219.2696.1679101924.799/frames/1".
When config use wadouri  type api.
And will call http url as "https://dicomcloud.azurewebsites.net/wadouri?RequestType=wado&studyUID=xxx&seriesUID=ccc&objectUID=vvv&contentType=application/dicom&transferSyntax=1.2.840.10<IP_ADDRESS>.91".
But i dont know What is the Different of Api type wadouri and wadors ?
Why has two way call DICOMcloud API?

wado-uri is nothing but a URL to a DICOM image with query parameters to specify the UID's, transfer syntax (compression) and other properties. This was the first protocol supported by OHIF viewer. https://dicom.nema.org/medical/dicom/current/output/chtml/part18/chapter_9.html
wad-rs is a service to get the image data in a more flexible way. You can get the frame pixel data separately from the metadata and it is what's used now by ohif viewer.
https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_10.4.html


OAK-10377: Checked-out state of non-versionable nodes is not handled …

…correctly
Added versionability check, test cases.

@mreutegg, I hope this addresses your change requests. I messed up the old PR#1051 by merging trunk with rebase.


Is there any config to add prefix or suffix to  jaeger-span index?

Want to add cluster name or application name to the jager-span index. This will help in rollover of index which is specific to application or cluster.

You can configure it by setting --es.index-prefix and a similar flag for archive storage. Refer to docs for more information


macos: Regenerate

Perhaps it something particular to my machine but I get this delta when I re-run make generate locally.

Hmm, this dropped NewWindowWithContentRectStyleMaskBackingDefer which is causing the CI failure.

I had an outdated symbols.zip file, closing.


fix: build floating

@xalteropsx thank you share me discord vue channel. Example fix code

thank you @xalteropsx :heart:

@xalteropsx you are a great person, happy birthday. I couldn't spend about 4 hours today and solve it.

no worry >.<


Bundle so huge

After connecting over 100 components, the weight of my bundle is large (around 10 Mb). All components connected with next-dynamic. But somehow my bundle is really large. How possible to resolve my problem? I want to use differents components in one page with dependence of http request.

Hi, this sounds like a question for our Spectrum community. If you could post it there and if possible include a link to a repo with the problem you are encountering myself or someone from the community would be happy to take a look.


Problem of API missing. get_intraday_extend

Optional: month
By default, this parameter is not set and the API will return intraday data for the most recent days of trading. You can use the month parameter (in YYYY-MM format) to query a specific month in history. For example, month=2009-01. Any month in the last 20+ years since 2000-01 (January 2000) is supported.
Why can the 'ts.get_intraday_extend 'api only obtain data from the last two years of a specified month, while the official support is for 20 years?

@av._output_format
@av._call_api_on_func
def get_intraday_extended(self, symbol, interval='15min', slice='year1month1'):
""" Return extended intraday time series in one csv_reader object.
It raises ValueError when problems arise
    Keyword Arguments:
        symbol:  the symbol for the equity we want to get its data
        interval:  time interval between two conscutive values,
            supported values are '1min', '5min', '15min', '30min', '60min'
            (default '15min')
        slice: the trailing 2 years of intraday data is evenly divided into
            24 "slices" - year1month1, year1month2, ..., year2month12
    """
    _FUNCTION_KEY = "TIME_SERIES_INTRADAY_EXTENDED"
    return _FUNCTION_KEY, "Time Series ({})".format(interval), 'Meta Data'

Temporarily closing this due to lack of activities. Will reopen as needed.


User can pay in desktop

Popup a QR code to scan.

try https://github.com/zpao/qrcode.react

https://github.com/baizhiheizi/prsdigg/commit/592860e8d87c199dad944d6b9548c0bc22d8af9a


Changing Theme is broken in FluentAvaloniaTheme.cs

Hi,
Using your sample application, changing the application theme doesn't work anymore.
In your code, the old theme and new theme are always the same.
A simple fix would be:
    public string RequestedTheme
      {
          get => _requestedTheme;
          set
          {
              if (_hasLoaded)
                  Refresh(value);
              else
                  _requestedTheme = value;
          }
      }

instead of:
      public string RequestedTheme
       {
           get => _requestedTheme;
           set
           {
               _requestedTheme = value;
               if (_hasLoaded)
                   Refresh(value);
           }
       }

Regards
François

Apologies, just pushed a fix out for this. Changing theme should work again


As a developer, I want to make sure I have access to all our Python PyPi package repos.

For more information on how to populate this new feature request, see the PDS Wiki on User Story Development:
https://github.com/NASA-PDS/nasa-pds.github.io/wiki/Issue-Tracking#user-story-development
Motivation
...so that I can update any of our PyPi packages.
Additional Details
See https://github.com/NASA-PDS/pds-api-client/issues/2#issuecomment-809833156
Acceptance Criteria
Given a completed update to a PDS Python repo
When I perform a deplyoment to PyPi
Then I expect to be able to successfully update the PyPi package with my PyPi account.
Engineering Details
This should just be something simple we can add to a "Create a New Python Repo" guide. maybe we just add this to the Python template README?

Done per documentation for creating new repo: https://github.com/NASA-PDS/nasa-pds.github.io/wiki/Git-and-Github-Guide#python-repos

Well that's one way to do it. Thanks @jordanpadams 🙏


don't use container

trying to fix github actions build

@robkooper looks like tests are failing. Should we force merge this PR and have @tezansahu address the issues with the tests in his open PR, or do you want to try and fix the tests here?

need to add default account and xml package for tests.

Looks like the problem is that GH Actions is running this with --workdir /github/workspace, which is messing with the BETY image entrypoint (which uses a relative file path). Not sure the best way to fix it. BETY should probably use absolute paths in its entrypoint.sh, but I feel like there must be a way to change the working directory of GH Actions docker runs.
https://github.com/PecanProject/rpecanapi/runs/1350179239#step:7:9


Landing page for FeaturePeek Indie

https://app.clubhouse.io/featurepeek/story/3696/create-landing-page-for-featurepeek-indie

Superceded by https://github.com/featurepeek/marketing-website/pull/165


Support SOCI Snapshotter

SOCI Snapshotter is an interesting project which could reduce Pod startup time. At a glance it seems like Spegel should be able to support SOCI ontop of running a normal registry. The main question is if there are users who want this.
https://github.com/awslabs/soci-snapshotter

@phillebaba This would be an AMAZING value add, SOCI seems aws specific, however Stargz should work cross clouds as long as containerd is good right?
https://github.com/containerd/stargz-snapshotter
Either way, if spegel can do lazy pulling of images, this would be a game changer for any workloads.

Acutally after reading more through SOCI spec, it does seem like that'll be better, so if you can add support for that, that'd be brilliant

I have read through both specs and SOCI is the better option currently as it requires little input from the user. This will be implemented in the future I just need to fix some critical features before I do, just so that I do not create more work than required. The important part is setting up a good testing environment to validate the implementation.

@ChrisBr estargz-snapshotter. works differenetly from SOCI so i cannot say off the top of my head if it it would or not. There are a lot of small details that come into play. Either way it is best to create a separate issue to track estargz-snapshotter support.

Awesome, thanks @phillebaba ❤  Is there any ETA for SOCI support or anything I can help out to make it happen?

Like estargz we need to figure out what is required to get mirroring working properly. A design limitation of Containerd is that that each snapshotter needs to define their own mirror configuration as they are responsible for their own image pulling. First step would be to figure out what this configuration is, document it and then test that it actually works with Spegel. Longterm is to add a SOCI node to the e2e tests.
Don't have an ETA on this as currently Spegel is something I do on my free time because I think it is fun.


Add Support for tintColor

it would be nice if the toolbar would be a accessible property to change the tintColor

whoops. you use the navigationControllers toolbar. sorry for that

Actually that could be done, at least for the modal version of it. Not a bad idea either.

Added to main branch, but only for<EMAIL_ADDRESS>Thanks!


RemoteUserStoreManagerService.updateRoleListOfUser allows to update "Internal" roles of non existing users

Steps to reproduce.

Create a new "Internal" role from Management console (ex: Internal/test)
Now use RemoteUserStoreManagerService.updateRoleListOfUser with non existing user to update its roles to newly created Internal role.
A sample request is as below.

<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:ser="http://service.ws.um.carbon.wso2.org">
   <soapenv:Header/>
   <soapenv:Body>
      <ser:updateRoleListOfUser>
         <ser:userName>non-existing-user</ser:userName>
         <ser:newRoles>Internal/test</ser:newRoles>
      </ser:updateRoleListOfUser>
   </soapenv:Body>
</soapenv:Envelope>

Above request returns 202 Accepted response. Instead, this request should fail and respond with a proper error message.
Additionally, in the database UM_HYBRID_USER_ROLE table, there is an entry with a non-existing username. Another concern here is storing the username instead of a user-id.

UM_ID
UM_USER_NAME
UM_ROLE_ID
UM_TENANT_ID
UM_DOMAIN_ID

12
non-existing-user
2
-1234
6

When browsing from management console under User List of Role : Internal/test, this non-existing user is listed.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


ENH: Use NiWorkflows' EPI-reference workflow

Replaces our workflows under dmriprep.workflows.dwi.util.

Thanks for this @oesteban! It looks like it should also fix the issues I had with some oblique datasets. Is the old init_enhance_and_skullstrip_dwi_wf also meant to be replaced with the epi_mask function from sdcflows?

Is the old init_enhance_and_skullstrip_dwi_wf also meant to be replaced with init_brainextraction_wf from sdcflows?

I think we should give it a try, at the very least.

This looks good to me! It's going to fail because the eddy nodes are no longer corrected properly.

I'll fix the connections tomorrow (my time). No need to break master for this.

I'll fix the connections tomorrow (my time). No need to break master for this.

Thanks @oesteban. I checked out the reference epi and I don't think it looks like its supposed to.

ugh - I had fixed that already. I'll double-check that the pinned versions of sdcflows and niworkflows are being used.

This is looking better. The JHU1 epiref still looks a little weird but I tested it locally and it was fine there. For the masking reportlet, we are currently showing the unwarped epiref and mask. But should we instead show the epiref and mask before unwarping? The warped mask would be the input to head motion correction.

Hello @oesteban, Thank you for updating!

In the file dmriprep/workflows/dwi/base.py:

Line 373:52: E999 SyntaxError: invalid syntax
Line 373:83: E226 missing whitespace around arithmetic operator

To test for issues locally, pip install flake8 and then run flake8 dmriprep.


Added Borderfree / Flow / Salesfloor in eCommerce category and some updates for tag managers

https://github.com/AliasIO/wappalyzer/issues/3229

Thanks!


Incorrect time format resolve in some locales

In some locales where 24 hours format should be used DateTimePicker still uses 12 hour format. For example, in Lithuanian locale long date format LLL is YYYY [m.] MMMM D [d.], HH:mm [val.]. In this case the format itself contains symbol 'a' and code decides to use 12 hour format. I believe problem is with this line:
 use24Hours = (actualFormat.toLowerCase().indexOf('a') < 1 && actualFormat.replace(/\[.*?\]/g, '').indexOf('h') < 1);

https://jsfiddle.net/myq50a5g/4/
version : 4.17.37

+1 I just got the case in french mode.
My problem is I want to use following format to get this format "20h30" (for 8:30pm).
I set format option to "HH\hmm" but the
indexOf('h')

breaks the use24hours detection.
A cool thing would be to be allowed to override this detection with a "use24hours" option right ?


@jonjomckay is fritter abandoned?

Discussed in https://github.com/jonjomckay/fritter/discussions/773

Originally posted by mrhcjones November 25, 2023
@jonjomckay

asking the same. App doesn't load very well the feed. It's full of 404's

asking the same. App doesn't load very well the feed. It's full of 404's
You should use Squawker until we get an answer

@TheHCJ is squawker the reason why you archived the quacker repository? In my opinion your fork works much better than squawker.

@TheHCJ is squawker the reason why you archived the quacker repository? In my opinion your fork works much better than squawker.

I stopped working on Quacker because I didn't want to continue the cat and mouse game with elon


feat: report & update basic status condition

This adds conditions to the MonitorinStackStatus type and
updates the controller logic so that the conditions are updated
during the reconciliation.

Hmm so I am wondering why this https://github.com/rhobs/observability-operator/blob/main/Makefile#L83 is needed. I mean I think it's OK to generate the role, but why it's missing the get permissions? I am not able to read the Prometheus status then :-(

I updated the PR based on the reviews. The OBO is reconciled faster than Prometheus containers (init-config-reloader) are ready (at least in my case) so the "MonitoringStackAvailable" condition is False....I guess we should wait for the containers to be ready or reconcile again? Or is that about the controller settings (should we own the P-O or the Prometheus StatefulSet?)

I updated the PR based on the reviews. The OBO is reconciled faster than Prometheus containers (init-config-reloader) are ready (at least in my case) so the "MonitoringStackAvailable" condition is False....I guess we should wait for the containers to be ready or reconcile again? Or is that about the controller settings (should we own the P-O or the Prometheus StatefulSet?)

So IIUC what's happening is that the condition MonitoringStackAvailable never moves from False to Available correct? Now if my understanding of operators is correct, we shouldn't need to own anything else apart from the Prometheus CR. This CR should be updated with the correct status and inherently our operator should be notified of those updates and update the MonitoringStack CR accordingly.

I'll give it a once over later today.
@sthaha  I'd like to hold off the on the release for a little bit. I have 0.0.13 sort of ear marked to test our CPaaS pipeline, but I'm still waiting on reviews there. We can go ahead if that ends up taking too long, maybe we can hold off till next week?

lgtm too :tada:
not officially approving it based on the latest @jan--f comment :)

:1st_place_medal: congratulations @tremes, it wasn't an easy one :)


when downloading with pivnet with non existing version creates empty scaffold

when i try to run the following
`tile-config-generator generate --token xxxxxxxxxx --product-slug=elastic-runtime --product-version=2.5 --product-glob='srt*.pivotal' --base-directory tmp/
it will generate a empty scaffold.
no error is raised

The functionality of this tool has been moved into the officially supported om tooling.  https://github.com/pivotalservices/tile-config-generator/blob/master/README.md#deprecation-notice Please re-open this issue in that repository as that will get prioritize by team focusing on the future development.


Gap in the top header

There is a gap in the top header on the 15-inch screen. See pic:

No gap on the 14-inch screen if Firefox is in the full-screen mode. But it appears if you reduce the width of the window.
Please help to workaround this.

The theme isn't really fit for such large logo images (more than 60px height), I guess I should mention that in the theme settings. or enforce it with CSS, or both.

Reducing of the image size to 60px doesn't solve the issue:

Is it possible to somehow fill this rectangle?

Oh actually, this is a better solution:
.top-section::before {
  content: "";
  position: absolute;
  top: 0;
  left: 0;
  right: 0;
  height: 60px;
  background: var(--top-section-background);
  z-index: -1;
}


Fix l7 redirects for host / world flows with AllowsLocalhost=always, HostAllowsWorld options

If the daemon options AllowsLocalhost=always (default with k8s) and/or
LegacyHostAllowsWorld are set, and any L7 rules are created that might
match traffic from host / world, then these L3 sources should be wildcarded
at L7 to ensure that proxies will not restrict the traffic from these sources.
This was previously not done, but instead the l4 redirects were removed
later during policymap entry generation. This prevented such traffic from
even reaching the proxy, which is counter to how the API for such a rule
combination is described.
This PR teaches the policy logic about these options so that L7 can be
appropriately wildcarded depending on the mode, and reinstates the
redirects when L7 policy is applied.
Fixes: #4401

This change is

Hit this timeout while contacting a service post-upgrade:
Stacktrace

/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:373
Cannot curl app1-service
Expected command: kubectl exec -n default app2-3691078314-77l9v -- curl -s -D /dev/stderr --fail --connect-timeout 5 --max-time 5 http://app1-service.default.svc.cluster.local/public
To succeed, but it failed:
Exitcode: 28
Stdout:

Stderr:

/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Updates.go:112

Seems very similar to https://github.com/cilium/cilium/issues/4384, will retry the build.

test-me-please

LGTM! Great work. Let's wait until the CI is stabilized before we get this merged.

Merged via #4435


No speaker detected

Problem/Motivation
It doesn't see my speakers
Expected behavior
Something about my speakers to show up in the logs
Actual behavior
Nothings shows
Steps to reproduce
I installed it, specified the network adapter to bind to, and expected it to show something, but nothing.
Speakers are 2 Play:5, 1 playbar and a sub at
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] 00-banner.sh: executing...
-----------------------------------------------------------
 Hass.io Add-on: AirSonos
 AirPlay capabilities for your Sonos (and UPnP) devices.
-----------------------------------------------------------
 Add-on version: 2.3.2
 You are running the latest version of this add-on.
 System: Debian GNU/Linux 10 (buster)  (amd64 / qemux86-64)
 Home Assistant Core: 0.116.4
 Home Assistant Supervisor: 247
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums or the Discord chat.
-----------------------------------------------------------
[cont-init.d] 00-banner.sh: exited 0.
[cont-init.d] 01-log-level.sh: executing...

Not much I guess. This relies on mDNS, so it might be good to check if that is working and reaches the host running this add-on.

How can I check that?

Sorry, it is your network, not mine. That is out of scope for the add-on.

if you don't tell me what your addon is looking for, I can't check: sonos app is working, spotify is working, so it's your addon that I need to fix

OK


Add MeSH data

This is the documentation for the Medical Subject Headings (MeSH) import.

This is now taken care of as part of https://github.com/datacommonsorg/data/pull/1000


NCD - Logic - Hypertension Stage One Complications [8h]

Issue
When a patient comes into an NCD encounter, we know that they have been referred for an existing issue. In the NCD encounter, we determine how bad their diagnosis is and distribute medication to help alleviate the issue.
Hypertension is one of the major issues tackled by the NCD encounter. There are several stages of Hypertension. For the purposes of these issues, I have broken them into one stage type per issue.
The logic for NCD's can be found here.
Stage One Hypertension can also be presented with renal complications or with diabetes which changes things.
The goal of giving a patient this medication is to get their numbers to systolic of <140 and diastolic of <90. If a patient has a systolic <100 we can bump them down a stage level.

Renal Complications
Diabetes
Referral

NOTE: there should NOT be a blue underling in the diabetes image. I can't get it to go away though.
To Do:

implement logic
style screens per design

https://nutrition-ihangane.pantheonsite.io/
QA Review
Found issues and questions:

When patient has Renal complications, the wording of the Methyldopa medication is missing the '1 tablet' part. Is this a problem?

The 'Have you administered the medication to the patient?' question doesn't display, but this might not be needed. See image above.

Checked and approved:
Referral
-|-
|

update methyldopa per design @Diama1
have you administered to the patient question should appear per design @Diama1
progress report not populating is a known issue
Seems like this patient should have stage 1 with diabetes - needs the proper next steps to appear and proper diagnosis to appear on progress report @anvmn

@anvmn assigning all aspect to you because of point 4.

@adamhstewart @jeanette-pelizzon

1, When patient has Renal complications, the wording of the Methyldopa medication is missing the '1 tablet' part. Is this a problem?

Methyldopa recommended treatement dosage helper is the same one we use at Prenatal.
There we have:

I don't see why we need to say 1 tablet at NCD and not say it at Prenatal.
So, we need a common presentation, since it's exactly same medication.

The 'Have you administered the medication to the patient?' question doesn't display, but this might not be needed.

This is not required, since we have No Treatment Administered option:

Diagnosis is not displayed on progress report.

Known issue, will be treated separately.

Patient is not diagnosed as Stage One with diabetes (only with Diabetes, but even that is not displayed on progress report).

When we distribute medication, we state the reason for that medication.
Diabetes medication does not depend on hypertension in any way.
Therefore, the reason to give that medication is Daibetes and nothing else.
Had there been Hypertension diagnosed, it would have been treated with different set of medication, and we'd show the diagnosis there.
Note: When we have Hypertension, at medication distribution, we do mention Renal complications if there are any. though it does not affect medication.

Methyldopa - @anvmn we are trying to clean up the medication wording across the entire app as we move forward. The convention that I have given the team more recently is "Name of Medicine (XX mg): take X tablet by mouth X times a day for X many days." Tablet can be switched out with other form i.e: drops, sachet, etc. We haven't been able to go back through all medication distro's in the app to make them the same so some of the newer modules or work will be different than past work. If it is easy to switch all methyldopa medication instances to read in the same format we should do it, otherwise we will have to hold off until we can properly audit the app.

I cannot remember when we decided to add a no treatment administered option. I also do not know why we ask the have you administered the treatment to the patient (that is a holdover from before I was here). @adamhstewart do you know the reasoning? If we don't need the question we should take it away. It seems that the feedback we've gotten is that there are a lot of questions/modules feel long so if we can take it away we should, right?

Anatoly's explanation makes sense here. It should be good to go. If we get feedback that it needs to be presented in a different way we can adjust.

@jeanette-pelizzon @adamhstewart

I cannot remember when we decided to add a no treatment administered option.

This option exists on any medication distribution input where we show several options for recommended treatment. It's there to allow nurse to report that there was no treatment.
Note that this behavior is different from regular medication distribution, where we give direct instruction on medication and dosage, and then ask if it was administered, and if not, we ask for a reason.

@adamhstewart Depoyed to Nutrition env for retesting

@jeanette-pelizzon can you confirm this woks according to logic

NEW Problem:
-Patient diagnosed with stage 3 hypertension but I marked everything as normal EXCEPT that she had a previous history of hypertension.

// @anvmn @adamhstewart

I ran it again on Mpano Chantal and it worked. When I put in the lanb results it bumped her from stage one hypertension to stage one hypertension with renal complications @adamhstewart
I can't get it to replicate the issue in my previous comment. Tried on Irumva Clarisse as well. Leaving comment there just in case something wonky is actually wrong.


Can't install .NET Core Windows Server Hosting bundle

I tried to install the .NET Core Windows Server Hosting bundle on one of our windows server 2008 r2 servers. The install failed; I suspect it is because the server does not have access to the internet.
I found a closed issue here that led me to believe it could be because it needs to install the VC++ 2015 redistributable which I downloaded and attempted to install. However it fails too because it can't authenicate the package. I haven't been able to find an offline installer for the VC++ redistributable.
I'm attaching both log files.
I'd really appreciate some suggestions on how to proceed.
Thanks!
Heidi Housten
dd_DotNetCoreWinSvrHosting__20160616085155.zip
dd_vcredist_amd64_20160616140927.zip

@joeloff?

Related: https://github.com/aspnet/IISIntegration/issues/179#issuecomment-220170056

@housten Let me clarify regarding your attempt to install the redist ... you were unable to install from the download from https://www.microsoft.com/en-us/download/details.aspx?id=48145 ?

Yes, @GuardRex, I was unable to install using the package at that link.
@Tratcher #179 is the closed case I refered to that gave me the idea that the VC++ redistributable could be the issue. I followed the advice and links there in my attempts to get the install working.

The server hosting bundle will install the .NET runtime which in turn will attempt to download and install the VC++ redists.
Have you tried this link
The logs seem to indicate that it failed to validate the authenticode signatures, but it might be a result of not being able to reach the server to download the files.

Yes, I did.use that link too @joeloff.
For now this isn't slowing me down as I got help from Ops to install. They have the permissions needed to temporarily open up as necessary.

I have the same problem installing the DotNetCore.1.0.0-WindowsHosting.exe as my AWS server does not have internet access and I am told by my server admins that it won't be able to get internet access.
Microsoft_.NET_Core_1.0.0_-Runtime(x64)_20160729105956.log.txt
Looking at the error file I see this line:
[0964:0750][2016-07-29T10:59:56]i052: Condition '(VCRedist_KeyExists AND VCRedist_KeyValue >= "v14.0.23506.00")' evaluates to false.
The installer file from the link in the documentation is an older version than it is looking for:
Microsoft Visual C++ 2015 Redistributable (x64) - 14.0.23026
Where can we download the newer version of this redistributable? Google points me to the same file as the documentation.
(I posted this on a closed bug thread)

Take a look at https://www.microsoft.com/en-us/download/details.aspx?id=48145. You should be able to download it from there

That is the one I have been downloading and installing. It is version 14.23026 and The Core install is looking for something >= 14.23506
After it can't find the newer version it tries to install that.

I could be wrong but this is what I am following in the log files. I will try the installer file from the link it is trying to download from but that is 14.0.24212:
[0964:0750][2016-07-29T10:59:56]i000: Setting numeric variable 'VCRedist_KeyExists' to value 1
[0964:0750][2016-07-29T10:59:56]i000: Setting string variable 'VCRedist_KeyValue' to value 'v14.0.23026.00'
[0964:0750][2016-07-29T10:59:56]i052: Condition '(VCRedist_KeyExists AND VCRedist_KeyValue >= "v14.0.23506.00")' evaluates to false.
[0964:0750][2016-07-29T10:59:56]i101: Detected package: VC_redist.x64.exe, state: Absent, cached: None
[0964:0750][2016-07-29T10:59:56]i101: Detected package: dotnet_sharedframework_win_x<IP_ADDRESS>.msi, state: Absent, cached: None
[0964:0750][2016-07-29T10:59:56]i101: Detected package: dotnet_hostfxr_win_x<IP_ADDRESS>.msi, state: Absent, cached: None
[0964:0750][2016-07-29T10:59:56]i101: Detected package: dotnet_host_win_x<IP_ADDRESS>.msi, state: Absent, cached: None
[0964:0750][2016-07-29T10:59:56]i199: Detect complete, result: 0x0
[0964:0750][2016-07-29T10:59:56]i200: Plan begin, 4 packages, action: Install
[0964:0750][2016-07-29T10:59:56]w321: Skipping dependency registration on package with no dependency providers: VC_redist.x64.exe
[0964:0750][2016-07-29T10:59:56]i000: Setting string variable 'WixBundleLog_VC_redist.x64.exe' to value 'C:\Users\axflor1\AppData\Local\Temp\Microsoft_.NET_Core_1.0.0_-Runtime(x64)20160729105956_000_VC_redist.x64.exe.log'
[0964:0750][2016-07-29T10:59:56]i000: Setting string variable 'WixBundleRollbackLog_dotnet_sharedframework_win_x<IP_ADDRESS>.msi' to value 'C:\Users\axflor1\AppData\Local\Temp\Microsoft.NET_Core_1.0.0_-Runtime(x64)20160729105956_001_dotnet_sharedframework_win_x<IP_ADDRESS>.msi_rollback.log'
[0964:0750][2016-07-29T10:59:56]i000: Setting string variable 'WixBundleLog_dotnet_sharedframework_win_x<IP_ADDRESS>.msi' to value 'C:\Users\axflor1\AppData\Local\Temp\Microsoft.NET_Core_1.0.0_-Runtime(x64)20160729105956_001_dotnet_sharedframework_win_x<IP_ADDRESS>.msi.log'
[0964:0750][2016-07-29T10:59:56]i000: Setting string variable 'WixBundleRollbackLog_dotnet_hostfxr_win_x<IP_ADDRESS>.msi' to value 'C:\Users\axflor1\AppData\Local\Temp\Microsoft.NET_Core_1.0.0_-Runtime(x64)20160729105956_002_dotnet_hostfxr_win_x<IP_ADDRESS>.msi_rollback.log'
[0964:0750][2016-07-29T10:59:56]i000: Setting string variable 'WixBundleLog_dotnet_hostfxr_win_x<IP_ADDRESS>.msi' to value 'C:\Users\axflor1\AppData\Local\Temp\Microsoft.NET_Core_1.0.0_-Runtime(x64)20160729105956_002_dotnet_hostfxr_win_x<IP_ADDRESS>.msi.log'
[0964:0750][2016-07-29T10:59:56]i000: Setting string variable 'WixBundleRollbackLog_dotnet_host_win_x<IP_ADDRESS>.msi' to value 'C:\Users\axflor1\AppData\Local\Temp\Microsoft.NET_Core_1.0.0_-Runtime(x64)20160729105956_003_dotnet_host_win_x<IP_ADDRESS>.msi_rollback.log'
[0964:0750][2016-07-29T10:59:56]i000: Setting string variable 'WixBundleLog_dotnet_host_win_x<IP_ADDRESS>.msi' to value 'C:\Users\axflor1\AppData\Local\Temp\Microsoft.NET_Core_1.0.0_-Runtime(x64)_20160729105956_003_dotnet_host_win_x<IP_ADDRESS>.msi.log'
[0964:0750][2016-07-29T10:59:56]i201: Planned package: VC_redist.x64.exe, state: Absent, default requested: Present, ba requested: Present, execute: Install, rollback: None, cache: Yes, uncache: No, dependency: None
[0964:0750][2016-07-29T10:59:56]i201: Planned package: dotnet_sharedframework_win_x<IP_ADDRESS>.msi, state: Absent, default requested: Present, ba requested: Present, execute: Install, rollback: Uninstall, cache: Yes, uncache: No, dependency: Register
[0964:0750][2016-07-29T10:59:56]i201: Planned package: dotnet_hostfxr_win_x<IP_ADDRESS>.msi, state: Absent, default requested: Present, ba requested: Present, execute: Install, rollback: Uninstall, cache: Yes, uncache: No, dependency: Register
[0964:0750][2016-07-29T10:59:56]i201: Planned package: dotnet_host_win_x<IP_ADDRESS>.msi, state: Absent, default requested: Present, ba requested: Present, execute: Install, rollback: Uninstall, cache: Yes, uncache: No, dependency: Register
[0964:0750][2016-07-29T10:59:56]i299: Plan complete, result: 0x0
[0964:0750][2016-07-29T10:59:56]i300: Apply begin
[0964:0750][2016-07-29T10:59:56]i010: Launching elevated engine process.
[0964:0750][2016-07-29T10:59:57]i011: Launched elevated engine process.
[0964:0750][2016-07-29T10:59:57]i012: Connected to elevated engine.
[09F8:0690][2016-07-29T10:59:57]i358: Pausing automatic updates.
[09F8:0690][2016-07-29T10:59:57]w308: Automatic updates could not be paused due to error: 0x80240025. Continuing...
[09F8:0690][2016-07-29T10:59:57]i370: Session begin, registration key: SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall{ee91e173-7e9c-4066-b2cd-4b943f21f811}, options: 0x7, disable resume: No
[09F8:0690][2016-07-29T10:59:57]i000: Caching bundle from: 'C:\Users\axflor1\AppData\Local\Temp{63974507-DDC1-4B50-9FE4-3B133E388D12}.be\dotnet-win-x<IP_ADDRESS>.exe' to: 'C:\ProgramData\Package Cache{ee91e173-7e9c-4066-b2cd-4b943f21f811}\dotnet-win-x<IP_ADDRESS>.exe'
[09F8:0690][2016-07-29T10:59:57]i320: Registering bundle dependency provider: {ee91e173-7e9c-4066-b2cd-4b943f21f811}, version: <IP_ADDRESS>00
[09F8:0690][2016-07-29T10:59:57]i371: Updating session, registration key: SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall{ee91e173-7e9c-4066-b2cd-4b943f21f811}, resume: Active, restart initiated: No, disable resume: No
[0964:0440][2016-07-29T10:59:57]w343: Prompt for source of package: VC_redist.x64.exe, payload: VC_redist.x64.exe, path: C:\ProgramData\Package Cache\0953E863F28809901663BD86B0150EAE977A31F4\packages\VC_redist.x64.exe
[0964:0440][2016-07-29T10:59:57]i338: Acquiring package: VC_redist.x64.exe, payload: VC_redist.x64.exe, download from: http://go.microsoft.com/fwlink/?LinkID=615460&clcid=0x409
[0964:0440][2016-07-29T11:00:18]e000: Error 0x80072efd: Failed to send request to URL: http://go.microsoft.com/fwlink/?LinkID=615460&clcid=0x409, trying to process HTTP status code anyway.
[0964:0440][2016-07-29T11:00:18]e000: Error 0x80072efd: Unknown HTTP status code 0, returned from URL: http://go.microsoft.com/fwlink/?LinkID=615460&clcid=0x409
[0964:0440][2016-07-29T11:00:18]e000: Error 0x80072efd: Failed attempt to download URL: 'http://go.microsoft.com/fwlink/?LinkID=615460&clcid=0x409' to: 'C:\Users\axflor1\AppData\Local\Temp{63974507-DDC1-4B50-9FE4-3B133E388D12}\VC_redist.x64.exe'
[0964:0440][2016-07-29T11:00:18]w343: Prompt for source of package: VC_redist.x64.exe, payload: VC_redist.x64.exe, path: C:\ProgramData\Package Cache\0953E863F28809901663BD86B0150EAE977A31F4\packages\VC_redist.x64.exe

Yep ... there's a prob here. That official installer is "old," but it was only published a little over two weeks ago.

@joeloff I have the version (.23506) on my system from somewhere. Do you think they made a boo-boo in the download center.

http://go.microsoft.com/fwlink/?LinkID=615460&clcid=0x409
downloads .24212

Everything installed. Thanks for the help. Now to get my app working!

@joeloff Let me know what you want to do about the installer link. I have the "old" one in the Publish to IIS doc (.23026).

@GuardRex
It works for me, Thank you.
PS: 2016-12-14
downloaded package is Microsoft Visual C++ 2015 Redistributable (x64) - 14.0.24215 witch follow your link.

Awesome!! Thanks @GuardRex

We are closing this issue because no further action is planned for this issue. If you still have any issues or questions, please log a new issue with any additional details that you have.


SyntaxError: Use of const in strict mode.

Hi, we're still running some legacy code on node 0.10, a recent change has caused our services to fail with:
.../node_modules/redis/node_modules/redis-parser/lib/parser.js:230 const err = new ReplyError('Protocol error, got ' + JSON.stringify(Strin
     ^^^^^
SyntaxError: Use of const in strict mode.
 at Module._compile (module.js:439:25)
 at Object.Module._extensions..js (module.js:474:10)

using const with "use strict"; fails in node 0.10 / 0.12, yet node-parser's package.json still lists the minimum engine as node 0.10.
the crashing line was introduced in:
https://github.com/NodeRedis/node-redis-parser/commit/6c149eafebd945ba66047ea771b265139386ce16#diff-3fab227e34d65fe9bb2d6ea53eec41cfR226
Could const either be removed, or the minimum engine requirements updated?

Whoops, this is a dupe of #16, closing.


Kineticist feats are not imported correctly

Describe the bug
Created a Lvl9 Kineticist build and import into FoundryVTT. Although most things are right, there are many feats that are either wrong or missing, such as:

Class Feat Lvl1 is blank after Import but should be Tremor
Tremor is applied as Lvl9 Feat

To Reproduce
Steps to reproduce the behavior:

In Pathbuilder, select Menu > Export JSON -> Copy the id
Create a new Character in Foundry
Click to import and paste the ID
Wait for it to finish

kineticist import.webm
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Environment:

Browser = Edge Version 120.0.2210.121 (Official build) (64-bit)
Foundry Version = 11.315
Pathfinder System Version = 5.12.7
Module Version = 1.0.8
Does this behaviour occur with other modules disabled: n/a

Additional context
n/a

In Pathbuilder please got to Export -> "Share Copy of Character" and provide the link.
_https://pathbuilder2e.com/launch.html?build=643090_

Details of any errors in the browser console (press F12):

pf2e.mjs:1645  PF2e System | Roll Option rules element on item Second Gate's Threshold (Expand the Portal) (Earth) (Actor.NSmn8VdLxDGaCBXe.Item.bL3wZd8VTFlmZstu) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.NSmn8VdLxDGaCBXe.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Second Gate's Threshold (Expand the Portal) (Earth) (Actor.NSmn8VdLxDGaCBXe.Item.bL3wZd8VTFlmZstu) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.NSmn8VdLxDGaCBXe.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Second Gate's Threshold (Expand the Portal) (Earth) (Actor.NSmn8VdLxDGaCBXe.Item.bL3wZd8VTFlmZstu) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.NSmn8VdLxDGaCBXe.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Second Gate's Threshold (Expand the Portal) (Earth) (Actor.NSmn8VdLxDGaCBXe.Item.bL3wZd8VTFlmZstu) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.NSmn8VdLxDGaCBXe.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Second Gate's Threshold (Expand the Portal) (Earth) (Actor.NSmn8VdLxDGaCBXe.Item.bL3wZd8VTFlmZstu) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.NSmn8VdLxDGaCBXe.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Second Gate's Threshold (Expand the Portal) (Earth) (Actor.NSmn8VdLxDGaCBXe.Item.bL3wZd8VTFlmZstu) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.NSmn8VdLxDGaCBXe.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Second Gate's Threshold (Expand the Portal) (Earth) (Actor.NSmn8VdLxDGaCBXe.Item.bL3wZd8VTFlmZstu) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.NSmn8VdLxDGaCBXe.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Second Gate's Threshold (Expand the Portal) (Earth) (Actor.NSmn8VdLxDGaCBXe.Item.bL3wZd8VTFlmZstu) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.NSmn8VdLxDGaCBXe.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Second Gate's Threshold (Expand the Portal) (Earth) (Actor.NSmn8VdLxDGaCBXe.Item.bL3wZd8VTFlmZstu) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.NSmn8VdLxDGaCBXe.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Second Gate's Threshold (Expand the Portal) (Earth) (Actor.NSmn8VdLxDGaCBXe.Item.bL3wZd8VTFlmZstu) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.NSmn8VdLxDGaCBXe.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
pf2e.mjs:1645  PF2e System | Roll Option rules element on item Second Gate's Threshold (Expand the Portal) (Earth) (Actor.NSmn8VdLxDGaCBXe.Item.bL3wZd8VTFlmZstu) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
24pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.id2MQRCFXPaW9dlG.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
24pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.3pwuV1c8xpQ6ax1C.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
24pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.m3sts1qP1xwY9Tgb.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
25pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.d6Zuyc7VnByW7JQQ.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
25pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.PRLUJXciB10cVKyc.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
25pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.GhSRh4Qr9EyvsgO4.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"
(anonymous) @ pf2e.mjs:1645
logger.js:53  pathmuncher | WARN > Unable to determine granted rule feature, needs better parser Object
log @ logger.js:53
32pf2e.mjs:1645  PF2e System | Roll Option rules element on item Gate's Threshold (Fork the Path) (Fire) (Actor.c4P9DSefmwIuCYGk.Item.DaCfmzWkOKDB03jO) failed to validate: Failed to resolve injected property "junction:{item|flags.pf2e.rulesSelections.elementExpand}:{item|flags.pf2e.rulesSelections.junction}"

Thank you for this report, this is fixed in v1.0.9


Payments

Send Invoice method (https://core.telegram.org/bots/api#sendinvoice)
Create Invoice link method (https://core.telegram.org/bots/api#createinvoicelink)
Invoice DTO (https://core.telegram.org/bots/api#invoice)

分支

分支

Hi @DDijj English please


Use a single UA code for Buyer App analytics

Missed out of this story (which only changed the Supplier App):
https://www.pivotaltracker.com/story/show/106115458

:+1:


Support for pip-compile-multi workflows?

I see from https://github.com/astral-sh/uv/issues/815 that you're aware of pip-compile-multi, just wondering if you have plans to add support for that too?

I don't think we plan to support it. The usage is small and there are simple workarounds e.g. a requirements file that includes the others. Sorry I know that's not a great answer to hear but I'd rather focus on building new workflows that solve this problem rather than adding another compatibility interface.

@zanieb Could you provide more details on the specific plans and features you’re considering? Additionally, how do you see uv evolving in terms of unique workflows and integration with Dependabot? Enhancing these areas and good dependabot integration could significantly popularize uv and streamline dependency management.
For reference, Dependabot is open to contributing new ecosystems, which you can find more about here.
I was too embarrassed to open a new issue, so I asked here. Moreover this ticket can probably be closed.

Hi!
Dependabot support is being tracked in https://github.com/astral-sh/uv/issues/2512 — of course we'd love an integration once what we're stable.
You can see all the work in progress with the preview label. We don't have a full roadmap written out at this time, the readme has a blurb though.

Thanks for the clarification!

We don't have a full roadmap

It would be great to have one. Anyway thank you for you work on py-cargo 😃

If I tried to work on a PR to implement this, would you be interested or do you feel it's not worth supporting? We're finding the sequential import workflow to be a pain.


CI fails for a month

The last successful CI run that updates the images seems to be a month old. I guess as a result the images on docker get outdated?
Failing since then: https://github.com/Menci/docker-archlinuxarm/actions/runs/8167679102
Last sucessfull build: https://github.com/Menci/docker-archlinuxarm/actions/runs/8151787635

The truth is that I have also tried to get it to work (here) but I don't know what happens to the GitHub runners that fail when using PGP. In the end I opted to take the repository to GitLab which works like a charm. If you are interested it is here.

Fixed.
@ogarcia For the error if you're interested, that's because of pacman uses faccessat() while qemu-user doesn't implement faccessat2 (until this commit). Switching to glibc-based Debian works around this.

@Menci Thank you! The truth is that I would not have discovered the error in life. But the really curious thing is that in the GitLab runners it doesn't fail.

No need to switch to debian, just specify the version of qemu in the GitHub action

@yxing-xyz I just don't know there's such an option and there IS pre-built newer version of qemu binfmt package... XD


bump depdendencies

Description
Dependency update
Type of change
Update out of date dependencies
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

[X] make e2e

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.921%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1862

Relevant Lines:
2094

💛  - Coveralls


Update CARTO API description #17

Added 2 so far missing, but important API integration docs to Mobile API
@csobier please review, and can you push it to a staging?

@jaakla and @Nikituh , looks good. I just applied some minor text updates. Can you answer the questions above? Then I can push and create a Docs staging to publish the live version.

Looks good to me. @csobier will you merge it, right?

Great! Yes, will merge now and just need to run a script in a Docs PR to publish the changes. Doing it now. thanks!


chore: Update production script to latest setup

Resolves #93.

Needs a further commit detailing the difference between production and development .env files

OK, I logged onto the production server, and carefully checked for all differences with development settings. I checked in a small doc commit that captures everything I found. In particular, there is no SECRET_KEY in production, and as I could not find any code reading SECRET_KEY I have eliminated all mention of it from the docs. Reopening this for review.


meta-lxatac-bsp: linux-lxatac: upgrade to 6.12

umpf tag is now: 6.11/customers/lxa/lxatac/20240917-1
The tag includes the following topic branches:

v6.11/topic/reproducible-build
v6.8/customers/lxa/lxatac

TODO before merging:

[x] Test on hardware
[x] Wait for 6.12 to be released
[x] Wait for https://github.com/linux-automation/meta-lxatac/pull/173 to be merged first

Since 6.12 is released now I have updated the PR to use the released version and marked it as ready for review.


no polynomials!

We will fit continuum with sums of sines and cosines, not polynomials, for very important reasons!

subsumed in another issue


Recommended for AIR development?

Hi,
it is not clear to me after eading documentation if this is aimed mostly at FlexJS or also developing coupled with Animate CC for AIR/SWF export. Would you recommend NextGenAS/VisualStudio for AIR development?
cheers

Yes, absolutely! It's worth adding that I use VSCode every single day to develop Feathers UI, the popular UI component library for Starling Framework.
You can see here that I have documentation written specifically for AIR development:
https://github.com/BowlerHatLLC/vscode-nextgenas/wiki/Create-a-new-ActionScript-project-in-Visual-Studio-Code-that-targets-Adobe-AIR
https://github.com/BowlerHatLLC/vscode-nextgenas/wiki/Debug-an-Adobe-AIR-mobile-application-with-Visual-Studio-Code

Fantastic Josh, thank you!

I tried to update some of the documentation to make it more clear that AIR and Flash Player are supported with the extension. Hopefully, that will answer the questions of others who might be wondering in the future!


No response from API using node.js 7.7.2

Hi, just following up from the previous issue I logged, for whenever you have a chance.
I created an instance of the API server in a Docker container, using the Dockerfile attached: Dockerfile.txt
This installs mongodb, node.js 7.7.2 and the API server, configures mongodb, and creates a small launch script. When I run the API server using it, nothing gets output to the /var/log/xBrowserSync_api.log log file, and any attempts to connect to https://localhost:8080/ just time out.
Unfortunately I'm not able at the moment to investigate further, but let me know if there's any other information that would be useful in resolving the issue.
EDIT: Ah - I didn't realize that by default, the API runs over plain HTTP, rather than TLS.  I can report that I now have the server running. It'd be great if the README could include any info on configuring it to use TLS - do you want me to open a separate issue for that?

Ah - from a quick look at the code, it seems like what's necessary is to edit api.js, and replace
         server = restify.createServer({
             log: log,
            name: global.apiName
         });

with
         server = restify.createServer({
             log: log,
            name: global.apiName,
            certificate: fs.readFileSync('../path/to/server-cert.pem'),
            key: fs.readFileSync('../path/to/server-key.pem')
         });

or similar. Seems to be working fine.

Hi @phlummox, apologies for the lateness of this response. I'm currently working on v1.1.0 of the API and will add support for enabling the service to run directly over TLS.

No worries, thanks for that. I quite understand being busy, I've had to put the work I was doing with the server on hold for a bit anyway.

Fixed in 62f4dc6868a9ac9623464b4eb97115977df5351d.


added support for { and }

Added support for \{ and \} in addition to the existing \lbrace and \rbrace. These commands are in standard latex, but was missing here, making it incompatible.

Could you please fix the minor issue I've found? I'll merge this afterwards.
Thanks for your help!

 Fixed it now.


Timeout for get_masking_view_connection()

Hi,
We have couple of dedicated arrays where masking views contains hundreds of lines, as example:
`

mv=a.connection.provisioning.get_masking_view_connections('MVNAME')
len(mv)
119808
`

As result during collection job we get timeout for get_masking_view_connections() function - it returns:
exception.VolumeBackendAPIException('PyU4V.utils.exception.VolumeBackendAPIException: Bad or unexpected response from the storage volume backend API: Error GET symmetrix. The status code received is None and the message is None').
I've tried to increase timeout to 150 seconds with a help of set_requests_timeout(150) function but it didn't really help.
Sometimes it works and sometimes not.
Is there any way to make get_masking_view_connections()function faster, may be by using some specific filters?
The reason why we use get_masking_view_connections() is we need to get list of devices with their scsi by host and looks like get_masking_view_connections() is the only one way to get list of volumes with their scsi id's. Or there is another way?
p.s.
We use PyU4V 9.2 as we have plenty of PMAX 2k/8k still.

Hi Roman,
This message is coming from Unisphere API and not PyU4V the only thing you can do in these cases is to do a lookup after the call mate put in a wait and then look to the view to see if it has actually been created. It's worth opening a ticket to look at the Unisphere server to make sure its not overloaded with too many api calls at the time this is happening also.
Sent from Outlook for Androidhttps://aka.ms/AAb9ysg
Internal Use - Confidential

From: Roman @.>
Sent: Tuesday, October 15, 2024 9:10:40 AM
To: dell/PyU4V @.>
Cc: Subscribed @.***>
Subject: [dell/PyU4V] Timeout for get_masking_view_connection() (Issue #204)
[EXTERNAL EMAIL]
Hi,
We have couple of dedicated arrays where masking views contains hundreds of lines, as example:
`
mv=a.connection.provisioning.get_masking_view_connections('MVNAME')
len(mv)
119808
`
As result during collection job we get timeout for get_masking_view_connections() function.
it returns exception.VolumeBackendAPIException('PyU4V.utils.exception.VolumeBackendAPIException: Bad or unexpected response from the storage volume backend API: Error GET symmetrix. The status code received is None and the message is None').
I've tried to increase timeout to 150 seconds with a help of set_requests_timeout(150) function but it didn't really help.
Sometimes it works and sometimes not.
Is there any way to make get_masking_view_connections()function faster, may be by using some specific filters?
The reason why we use get_masking_view_connections() is we need to get list of devices with their scsi by host and looks like get_masking_view_connections() is the only one way to get list of volumes with their scsi id's. Or there is another way?
p.s.
We use PyU4V 9.2 as we have plenty of PMAX 2k/8k still.
—
Reply to this email directly, view it on GitHub [github.com]https://urldefense.com/v3/__https://github.com/dell/PyU4V/issues/204__;!!LpKI!ip40djyHoRyUZeijOoNMC7rZmRMJFpW5V2JXNJqI2v2VtTShF2ksQsRSIT7nL_OtojqV0hrUMF7ntlAQ0sJydfhK$, or unsubscribe [github.com]https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AF7FWPKXS6B3TMI66KRV3FDZ3TEYBAVCNFSM6AAAAABP6RKPOCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4DOOJYHEYDAMA__;!!LpKI!ip40djyHoRyUZeijOoNMC7rZmRMJFpW5V2JXNJqI2v2VtTShF2ksQsRSIT7nL_OtojqV0hrUMF7ntlAQ0uKK4_uR$.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Paul, can you please give me example of code snippet which can wait and do lookup after?

job = (conn.provisioning.create_masking_view_existing_components(
storage_group_name=SG_NAME, port_group_name=PG_NAME,
host_group_name=HG_NAME, _async=True)
conn.common.wait_for_job_to_complete(job)
print(conn.common.get_job_by_id(job)
The above code should work, using Async job queue to execute the job and looking up with the inbuilt functions should help.
Paul Martin
Senior Principal Engineering Technologist
Dell | ISG - PowerMax and VMAX
Cell +35387 696 0621
Timezone GMT
Please note that my working days are Tuesday – Friday.
Follow me on Twitter @rawstorage
Blog https://rawstorage.wordpress.com/
WhitePapers - https://infohub.delltechnologies.com/t/storage/
Internal Use - Confidential
From: Roman @.>
Sent: Tuesday, October 15, 2024 9:29 AM
To: dell/PyU4V @.>
Cc: Martin, Paul @.>; Comment @.>
Subject: Re: [dell/PyU4V] Timeout for get_masking_view_connection() (Issue #204)
[EXTERNAL EMAIL]
Paul, can you please give me example of code snippet which can wait and do lookup after?
—
Reply to this email directly, view it on GitHub [github.com]https://urldefense.com/v3/__https:/github.com/dell/PyU4V/issues/204*issuecomment-2413226995__;Iw!!LpKI!ghpTgMbjfC5sRG1EFhDXoOOB_k4FjIDbMZ47y9wydeIqPHePnIpWmRz7H9bgRdmUrfG6alM36X3ZNVRuwMYyJtuq$, or unsubscribe [github.com]https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AF7FWPLSDCCITYJVYWGURO3Z3TG3PAVCNFSM6AAAAABP6RKPOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTGIZDMOJZGU__;!!LpKI!ghpTgMbjfC5sRG1EFhDXoOOB_k4FjIDbMZ47y9wydeIqPHePnIpWmRz7H9bgRdmUrfG6alM36X3ZNVRuwNC-pLax$.
You are receiving this because you commented.Message ID<EMAIL_ADDRESS>

Thanks for suggestion, but looks like connection.provisioning.get_masking_view_connections can't be run as async job, it does not have _async option.
TypeError:  get_masking_view_connections() got an unexpected keyword argument '_async'

Sorry I misunderstood I thought you wanted to create a masking view.  Not review the masking view connections,   Presumably you are looking up the host lun address if you are using this call.    I believe there were fixes in later versions of Unisphere for PowerMax to make this more efficient but you would need to check with Dell support.
Paul Martin
Senior Principal Engineering Technologist
Dell | ISG - PowerMax and VMAX
Cell +35387 696 0621
Timezone GMT
Please note that my working days are Tuesday – Friday.
Follow me on Twitter @rawstorage
Blog https://rawstorage.wordpress.com/
WhitePapers - https://infohub.delltechnologies.com/t/storage/
Internal Use - Confidential
From: Martin, Paul
Sent: Tuesday, October 15, 2024 3:57 PM
To: dell/PyU4V @.>; dell/PyU4V @.>
Cc: Comment @.***>
Subject: RE: [dell/PyU4V] Timeout for get_masking_view_connection() (Issue #204)
job = (conn.provisioning.create_masking_view_existing_components(
storage_group_name=SG_NAME, port_group_name=PG_NAME,
host_group_name=HG_NAME, _async=True)
conn.common.wait_for_job_to_complete(job)
print(conn.common.get_job_by_id(job)
The above code should work, using Async job queue to execute the job and looking up with the inbuilt functions should help.
Paul Martin
Senior Principal Engineering Technologist
Dell | ISG - PowerMax and VMAX
Cell +35387 696 0621
Timezone GMT
Please note that my working days are Tuesday – Friday.
Follow me on Twitter @rawstorage
Blog https://rawstorage.wordpress.com/
WhitePapers - https://infohub.delltechnologies.com/t/storage/
From: Roman<EMAIL_ADDRESS>Sent: Tuesday, October 15, 2024 9:29 AM
To: dell/PyU4V<EMAIL_ADDRESS>Cc: Martin, Paul<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [dell/PyU4V] Timeout for get_masking_view_connection() (Issue #204)
[EXTERNAL EMAIL]
Paul, can you please give me example of code snippet which can wait and do lookup after?
—
Reply to this email directly, view it on GitHub [github.com]https://urldefense.com/v3/__https:/github.com/dell/PyU4V/issues/204*issuecomment-2413226995__;Iw!!LpKI!ghpTgMbjfC5sRG1EFhDXoOOB_k4FjIDbMZ47y9wydeIqPHePnIpWmRz7H9bgRdmUrfG6alM36X3ZNVRuwMYyJtuq$, or unsubscribe [github.com]https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AF7FWPLSDCCITYJVYWGURO3Z3TG3PAVCNFSM6AAAAABP6RKPOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTGIZDMOJZGU__;!!LpKI!ghpTgMbjfC5sRG1EFhDXoOOB_k4FjIDbMZ47y9wydeIqPHePnIpWmRz7H9bgRdmUrfG6alM36X3ZNVRuwNC-pLax$.
You are receiving this because you commented.Message ID<EMAIL_ADDRESS>

Closing as this is not directly an issue for PyU4V and needs to be worked with support


Update disks-find-unattached-portal.yml

Added the following information , the same has been verified in LAB environment :
    NOTE

    The following view will only list the unmanaged disks which are part of the CLASSIC Storage accounts in Azure.
    This will not show unmanaged disks which belong to non-classic storage accounts.
    Hence there may be other unmanaged disks present.

@roygara
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


EDU-166 Add Import indexes

Closes: https://educandu.atlassian.net/browse/EDU-166
I've added only this index since this is the only query we have so far that takes a long time. Other indexes I considered:
task.processed (no query so far)
task.taskType (no use case)
batches.batchType (we only have one type of batch so far)

You've missed to add the index to the collection spec inside the application

Did you miss my comment above?

Thanks, added. I had no idea about them, I'll remember from now on.


[docs] Non-ssr languages dillute search results

google.com: "material-ui.com icons" includes english, frensh and german in the top 3 results
duckduckgo.com "material-ui.com icons" does not list any other languages

Since those languages are only not-ssr for a couple of days (as a result of #17249) duckduckgo might not have caught up already.
I have some ideas that should improve the build times. In the end the it might make more sense to just throw some more CPUs at the build.

I thought that #17311 was taking care of the issue, but we might have another problem.

That PR does not explain anything so I can't know what issue it was trying to solve.
Let's observe this for a few days and see if the issue persists.

The real fix in here: https://github.com/mui-org/material-ui/pull/17311/files#diff-91b13573960dbcd4bca6832a4bdc9593R67. We have been linking, for a week, invalid alternate language URL.

Let's observe this for a few days and see if the issue persists.

Agree! Changes in the Google index takes weeks to manifest. We might need another a week or two to see the stable state.

It took some time, but Google indexes are finally up-to-date :). I have tested the "material-ui.com icons" from FR and US, no more duplication.

It took some time, but Google indexes are finally up-to-date :). I have tested the "material-ui.com icons" from FR and US, no more duplication.

It's a bit weird though how they are grouped:

material-icons is listed within components/icons and next to the other languages

Yeah, I agree, it's strange! I hope it will resolve itself too.

It took some time 🙃


[FEATURE REQUEST] Enable the plugin to "unhide" gitignore'ed object(s)

The Current Issue I'm Facing
A current project I'm working on has a couple of files/folders gitignore'ed since they're only supposed to be worked on locally & not on production. Unfortunately for me, the following configurations hides that specific file I need to work on locally as well:
  filesystem = {
    filtered_items = {
      hide_gitignored = true,
    },
  },

Having to constantly toggle hiding/unhiding files & folders gets monotonous & annoying, so I was wondering if it was possible to add a configuration value which forcibly "unhides" said files/folders?
A Possible Solution to Fix the Issue
I imagine the functionality could be on similar lines of how hide_by_name works but the caveat is, instead of hiding files it would unhide the list of provided files/folder names. The configuration could even be named as unhide_by_name or something similar.

This seems like a good idea. Assuming you still want the file to be marked in a hidden file font, and/or gitgnored symbol, I think the option name should refer to being visible instead of hidden, maybe always_visible?

Yup, it makes sense to mark that specific file as "gitignored" & has been made "always visible". Also yeah the option name always_visible sounds more explicit than a simple visible.

maybe always_visible?

There's already a never_show, so why not always_show?

There's already a never_show, so why not always_show?

Yeah, I think that makes sense.

This is in main now and will be released tonight. The new config option is called always_show. Here is the updated section of the help file:
>
    require("neo-tree").setup({
      filesystem = {
        filtered_items = {
          visible = false, -- when true, they will just be displayed differently than normal items
          hide_dotfiles = true,
          hide_gitignored = true,
          hide_hidden = true, -- only works on Windows for hidden files/directories
          hide_by_name = {
            ".DS_Store",
            "thumbs.db",
            --"node_modules",
          },
          hide_by_pattern = {
            --"*.meta",
          },
          always_show = { -- remains visible even if other settings would normally hide it
            --".gitignored",
          },
          never_show = { -- remains hidden even if visible is toggled to true, this overrides always_show
            --".DS_Store",
            --"thumbs.db",
          },
        },
      }
    })
<

The `visible` option just defines the default value. This value is toggled by
the "toggle_hidden" command, which is mapped to H by default.

The `hide_dotfiles` option just hides anything that starts with `. `(period).

The `hide_gitignored` option will query git for the files and folders being
shown, and hide those that are marked as ignored.

The `hide_hidden` option only will work on Windows using the Windows logic
that determines if a file or directory is hidden.

The `hide_by_name` option is a list of file/folder names that should be
hidden. This is an exact match.

The `hide_by_pattern` option uses glob syntax, which is converted to lua
patterns. No gaurantees on how it handles advanced patterns.

The `always_show` option is a list of file/folder names that will always be
visible, even if other settings would normally hide it. This section takes
precedence over all other options except for `never_show`.

The `never_show` option is the same as `hide_by_name`, except that those items
will remain hidden even if you toggle `visible` to true. This section takes
precedence over the others.

@cseickel is there an option to just show hidden files visible by default?
If I set
      hide_dotfiles = false,
      hide_gitignored = false,
      hide_hidden = false,

I won't be able to toggle hidden files.

@cseickel is there an option to just show hidden files visible by default?

Yeah, visible = true
https://github.com/nvim-neo-tree/neo-tree.nvim/blob/9acf8ac8396cde6286b8c7b02dbca86a46944d3d/lua/neo-tree/defaults.lua#L334

Yeah, visible = true

Oh, sorry, I was confused by the option description. Just what I need, thank you!


Build script for gRPC C# core-library for Apple M1

I created a script for macOS by referring to the script for iOS.
src/csharp/experimental/build_native_ext_for_macos.sh
#!/bin/sh
# Copyright 2018 The gRPC Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# Helper script to crosscompile grpc_csharp_ext native extension for macOS.

set -ex

export SDKROOT="$(xcrun --sdk macosx --show-sdk-path)"
#export SDKROOT="/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk"
export MACOSX_DEPLOYMENT_TARGET="10.15.0"
export EMBED_ZLIB=true

cd "$(dirname "$0")/../../.."

# Usage: build <iphoneos|iphonesimulator> <arm64|x86_64|...>
function build {
    SDK="$1"
    ARCH="$2"

    PATH_AR="$(xcrun --sdk $SDK --find ar)"
    PATH_CC="$(xcrun --sdk $SDK --find clang)"
    PATH_CXX="$(xcrun --sdk $SDK --find clang++)"
    PATH_LIPO="$(xcrun --sdk $SDK --find lipo)"
    SDKROOT="$(xcrun --sdk macosx --show-sdk-path)"

    CPPFLAGS="-O2 -Wframe-larger-than=16384 -arch $ARCH -isysroot $(xcrun --sdk $SDK --show-sdk-path) -mmacosx-version-min=10.15.0 -DPB_NO_PACKED_STRUCTS=1 -DBORINGSSL_PREFIX=GRPC -Isrc/boringssl"
    #LDFLAGS="-arch $ARCH -isysroot $(xcrun --sdk $SDK --show-sdk-path) -Wl,macos_version_min=10.15.0"
    #LDFLAGS="-arch $ARCH -isysroot $(xcrun --sdk $SDK --show-sdk-path) -Wl -platform_version macos 10.15.0 12.3.0"
    #LDFLAGS="-arch $ARCH -isysroot $(xcrun --sdk $SDK --show-sdk-path) -Wl -macos_version_min 10.15.0"
    LDFLAGS="-arch $ARCH -isysroot $(xcrun --sdk $SDK --show-sdk-path) -Wl"

    # TODO(jtattermusch): Ideally we'd be setting build defines that correspond to using cmake's
    # gRPC_XDS_USER_AGENT_IS_CSHARP option here, but since using XDS with C# on iOS is unlikely
    # and gRPC C#'s support of iOS is only experimental, it's fair to skip that for now
    # (which will result in XDS user agent language being "not specified" and that's ok
    # since there are other circumstances in which it isn't set).

Since this is not a bug, I'm going to close.
Also note that grpc C# is now in maintenance mode and grpc-dotnet is now the recommended implementation to use
(and since it doesn't have native components, it would work on M1 out of the box).

can you provide the built file


"Publication" Submission enters an endless loop, when depositing with errors and no unsaved changes

Describe the bug
When depositing a submission a second time (e.g. after the first one failed validation) without any changes.
the submission form enters an endless loop, requesting, re-requesting, and re-requesting the workspace item.
Version: DSpace 7.4
To Reproduce
Steps to reproduce the behavior:

Start a submission (Most easily reproducible when submitting a "Publication" Entity, using the "Publication" submission form configuration.  It does NOT occur for a normal Item.)
Do not fill out all required forms
Click the Deposit button
Wait for the validation errors to appear
Click the Deposit button again, without making any changes

Expected behavior
The submission should fail validation again

@tdonohue I've managed to reproduce it with vanilla dspace-angular, so it looks to be related to either our submission process (we have a fairly large submission form, using type-binds, scopes, and entity relations) or our backend process. I'll need to look further into it!

@hutattedonmyarm : I was able to reproduce it now on both the demo site, and locally.  It seems to only be reproducible if you use Entities, specifically the Publication Entity submission form.   It doesn't occur if you submit a normal Item (non-Entity)
I'll pull this ticket over to our 7.5 board and see if I can find a volunteer to look at it.

Needs retesting in 7.6, as several improvements / bug fixes to submission form occurred in that release.

@tdonohue I just checked on the demo site, I'm still able to reproduce it there


Upgrade from Material 1.5 to Material 3 when the build pipeline allows it

@Redeem-Grimm-Satoshi is this issue still relevant?

@maprehensive Yes, it's still relevant, the build pipeline isn't completed yet


Don't cause MSBuild warnings 'expected' failures

It's expected that git won't be in %PATH% so in this scenario we should
not generate an MSB3073 warning, nor write stderr as high importance.
This removes these lines from every build on windows for me:
1>'git' is not recognized as an internal or external command,
1>operable program or batch file.
1>C:\Users\almcgo\.nuget\packages\gitinfo\2.0.11\build\GitInfo.targets(897,3): warning MSB3073: The command "git --version" exited with code 9009.

Nah, it is fine!

@kzu any chance we can get this, or a variant of it, into a release? It'd be good to not emit warnings for expected things.

Thanks for that! It's good to be able to knock out these warnings without disabling them :)


Citation File to the repository

I was thinking that's it's worth to add citation oil etc this repo or link it to Zenodo to make citation easier for it - help amplify the work better.

I only just saw this! Yes, please feel free :D


Typescript examples

Please add Typescript examples in the repo.
Or, drop code samples in Discord.

We have some example here: https://github.com/run-llama/LlamaIndexTS/tree/main/examples/readers/src
We will add more in the near future.


Pytrec scores are not consistent in colab

the same file and the same code, on my laptop gives different results than on google colab (metrics are P_1, P_3, recip_rank, map and ndcg) I did check the precision (running everything on np.float64), yet not the issue.
any suggestion?

@seanmacavaney  this issue consisted randomly -Also I couldn't reproduce it-, in the same notebook that has the problem, trec_eval was giving the expected results, so my suggestion is that the problem is in the interaction between the colab notebook and pytrec_eval,


[Echo3D] feature/echo 3d viewer

Description
added echo 3d viewer
Completes: AB#FILL_IN_YOUR_ISSUE_ID
Checklist:

[x] I have performed a self-review of my own code.
[ ] I have linked my DevOps task using the AB# tag.
[x] My code is easy to read, and comments are added where needed.
[ ] My code is covered by tests.

merger den inn når vi har fåt ut test release


merge package template from Kronos-Tools/npm-package-template

package.json

chore(devDependencies): update<EMAIL_ADDRESS>from template
chore(devDependencies): update<EMAIL_ADDRESS>from template

Coverage remained the same at 57.143% when pulling 67e1571db752a8b528537ab530adb81396fdb6ea on template-sync-1 into 0ea50104d508ff7aaf7223f4267aa8f475adc4cc on master.


sql_database source | error with pyarrow BE, if some of the types were not identified correctly

dlt version
0.4.12
Source name
sql_database
Describe the problem
When you're using pyarrow backend if some of the data types were not identified correctly, dlt outputs an error:
ValueError: array split does not result in an equal division

Expected behavior
No response
Steps to reproduce
import dlt
from sqlalchemy.dialects import registry

from sql_database import sql_table

registry.register('snowflake', 'snowflake.sqlalchemy', 'dialect')
pipeline = dlt.pipeline(
        pipeline_name="snowflake_pipeline",
        destination="duckdb",
        dataset_name="my_data",
    )

sql_alchemy_source = sql_table(
    table="PULL_REQUEST_EVENT",
    schema="DEMO_TEST_DLTHUB_REACTIONS"
)

info = pipeline.run([sql_alchemy_source])
print(info)

How you are using the source?
I'm considering using this source in my work, but bug is preventing this.
Operating system
macOS
Runtime environment
Local
Python version
3.10
dlt destination
No response
Additional information
No response

fixed by #487


Update precommit versions

Is there a way of using the pre-commit.ci bot to do this inside the template?

Versions bumped in https://github.com/neuroinformatics-unit/python-cookiecutter/pull/109

ARC python cookiecutter seems to be using Renovate for this (see example here).
An alternative is Dependabot, which is built into Github.
The main advantage they mention of renovate over dependabot is that it is a bit more flexible in terms of configuring which files to look into and what (regex) pattern to use to detect versions.

Renovate looks like a good idea. We could in principle use it to keep some other parts of the template up to date.


fix flaky handshake integration test

Codecov Report

Merging #1819 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1819   +/-   ##
=======================================
  Coverage   86.98%   86.98%
=======================================
  Files          95       95
  Lines        6492     6492
=======================================
  Hits         5647     5647
  Misses        602      602
  Partials      243      243

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c7c0f...e3e6f6b. Read the comment docs.

Codecov Report

Merging #1819 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1819   +/-   ##
=======================================
  Coverage   86.98%   86.98%
=======================================
  Files          95       95
  Lines        6492     6492
=======================================
  Hits         5647     5647
  Misses        602      602
  Partials      243      243

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c7c0f...e3e6f6b. Read the comment docs.


Editing the git switch quiz answers and Readme.

Git allows switching branches with either the experimental 'switch' command or the 'checkout' command. Changing the quiz answers to reflect this as it's confusing when the user chooses checkout and is told the answer is incorrect.

There are other quiz translations that would need to be edited if my PR is accepted. I am happy to use Google translate or open issues for others to fix.

@microsoft-github-policy-service agree


Use only non-send futures

Async Rust is a mess.
💻 Examples

🚨 Test instructions

✔ PR Todo

[ ] Included links to related issues/PRs

I think input from a rust expert would be nice here...


Undefined symbols for architecture x86_64:

After i yarn install the library , and pod install , when I run my project i have build error
Undefined symbols for architecture x86_64:
  "_RCTRegisterModule", referenced from:
      +[CustomCropManager load] in CustomCropManager.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Any idea how to solve this ?

@daarkfish Were you able to manage this issue?

I found the solution. Please remove use_frameworks! in your pod file


Lightwaverf Gen 2

Adam, are you looking to get the Generation 2 switches and integrating with smart things?

If you want to buy it for me


JS-based toggleable auto-page-refreshing

This PR improves Hoff's web-interface by adding a button to toggle whether the page refreshes automatically every few (every 5) seconds.
The implementation uses a tiny piece of JavaScript to accomplish this task, and remembers whether the toggle is on by using local storage.
Fixes #71

Pull request approved for merge by @Qqwy, rebasing now.

Rebased as 24d618730c94b2470b6dab5161d295527d96c33f, waiting for CI …

CI job :yellow_circle: started.


Proto files with the same name but different directory are overwritten

By convention, our gRPC services are structured like this:
├── service 1
│   ├── message.proto
│   └── service.proto
├── service 2
│   ├── message.proto
│   └── service.proto
├── service 3
│   ├── message.proto
│   └── service.proto
├── service 4
│   ├── messages.proto
│   └── tensor.proto

Unfortunately, this library generates Rust files in a single directory and use the same name as the proto file. This ultimately means the services clobber each other's files.
I can see there's an old issue regarding adding hierarchal support to the code generation. This would solve our problem. Though based on its age I don't expect it to be added any time soon. Are there other solutions or work arounds to this?

No there's no workaround. Sorry.
If someone wants to help, please do.


[feature request] map elevation base

it would be great if one could generate also map elevation model.
this can be done in several options :
-integrated - map underneath route profile merged with route profile. they would get different exxageration rates though
-interlocking - map underneath route profile as separate file, with a groove in place where route profile can be fitted (this way one can print  route profile in different colour)
route profile would go all the way to the bottom of the map (+small adjustable base like 0.2mm)
-on-top - map underneath route profile without any groove, but route profile 'offseted' to map top .
this needs to be printed with support, but allows using single map for several route profiles.

Agreed! This is actually the goal I had in mind when I began making GPXtruder.
Due to a variety of projects competing for my attention, I do not plan to work on this anytime soon. Integration with a suitable source of elevation data is a key challenge.
However, it can be done manually!
You can model a region in the fashion of Shapespeare's landscapes and produce a matching scale route model through careful use of GPXtruder's settings (especially the projection, region, and max dimensions). The landscape and the route can then be combined in the ways you suggest using Blender or other 3D software.
It is on my to-do list to print an example and write a tutorial, which I will post here on GPXtruder's github page.

Spent this afternoon working through a sample by hand using QGIS. Started with a GPX file of a route; retrieved SRTM 1-arc sec digital elevation tile of containing region from USGS Earth Explorer, and fiddled around with getting them into matching projections, extents, etc. The purple path in the image below is the route generated with GPXtruder and the matching green landscape is derived from the elevation data.

Definitely not going to build this in to GPXtruder, but now that I've proven the process I know I can document and probably make a few small tweaks that make it easier.

Here is a photo of a printed version of the model shown in the screenshot above.

Example of an interlocking route and landscape (Whiteface Vertical K):

Example of an on-top (draped) route and landscape (Forest Frolic 7k):

The route models in these examples were made with GPXtruder. The landscapes were made with phstl from clipped GeoTIFF SRTM heightmap images prepared with QGIS. They were combined (via various boolean operations) via Meshmixer and/or Blender.
This process is far from automatic but is definitely doable.


added Electric Transient to SetupNames

changed 2nd  "ElectroDCConduction" into "ElectricTransient"

Closing. Tackled in #4123.


[Experiment] Asset hot reloading

Background
This is going to be nasty
Design

Create a worker thread with a channel
Inside of engine.update(), check if there's any messages from the worker
In the worker's main loop, use notify
If the asset file has changed, send the AssetUpdated event
When AssetUpdated is received, reload the asset using the regular asset importer workflow

That seemed to work well! Let's take it up a notch and let the server work remotely!

This has been completed!


Feature/1008 - Email subject mangled for non-latin chars

Resolves issue w Subject mangling for non latin characters.. fixed provided by  @shivakumarc9_twitter on Gitter.
Example population of the subject...
emailParams.put(ContactUsUtils.SUBJECT, contactUsModel.getButtonTitle()+ " - "+ contactUsModel.getQuestionCategory());

@upasanac this look OK to you?

Coverage decreased (-0.003%) to 25.602% when pulling 40799527b1279ce1f67a9b22acd8d9e88618622b on davidjgonzalez:feature/1008 into 01761aec59bf75470217e7a075e68d97c203804e on Adobe-Consulting-Services:master.


DW1000.cpp: SPI data not written correctly for extended adresses

readBytes and writeBytes are not setting the extended address bit correctly:
This is the corrected code:
     static const byte EXT_ADDR = 0x80; // extended address
      .......

		} else {
			header[1] = EXT_ADDR | (byte)offset;
			header[2] = (byte)(offset >> 7);
			headerLen+=2;
		}

I found it out by verifying the sent data (in writeBytes) by reading back the written data.
wr@23:4=> 70,88,
wr@23:C=> 7,A9,2,25,
wr@23:12=> 35,0,
wr@27:2=> 1,0,
wr@27:4=> 87,0,
wr@27:6=> 20,0,
wr@27:8=> 2D,0,1A,31,
wr@27:26=> 28,0,
wr@2E:806=> D,
  ERROR: 0,
wr@2E:1806=> 7,16,
  ERROR: 0,AD,
wr@2E:2804=> 8E,42,
  ERROR: 0,0,

BTW:  accuracy seem to incease by this fix because otherwise the tuning parameters are not written correctly to the chip  :)

Hi there,
sorry for delay and thanks for your help in debugging!
Although I did not yet have time to verify this extended address issue, your "corrected" code seems to be equal to the one in already in place. Your EXT_ADDR is equal to the currently used WRITE constant.
Did I miss something? ;-)
Please clarify and many thanks!
Cheers,
Thomas

For extended addresses, regardless of read/write, bit 7 of Octet 2 must be set (page 12 in user manual). In the current code, it's not set for read operations, and so the read fails (PS: try to write and read back an extended address).

Uh, oh! Thx! Will fix it.


Fatal error when running Microtonality playground

First of, let me thank you all for an amazing project. I hope I can contribute somehow in the future... Anyway, I just cloned the Audiokit repo and ran the playgrounds. I got an error in the Microtonality playground:
Fatal error: Only BidirectionalCollections can be advanced by a negative amount
at let tuningTable = AKPolyphonicNode.tuningTable (that's line 47 in the playground)
As a starting point, I did find this which may provide a way to solve it (ie. using very latest swift build)... https://bugs.swift.org/browse/SR-7529
I'm on High Sierra, using Xcode 9.4.1.
Happy to provide any other info if necessary. Thanks.

This is fixed on the develop branch, and will be official with AudioKit 4.4.1