Source branch not build at all case

OPS Build status updates of commit 9c87dac:
:clock10: Preparing: average preparing time is not available, there is no data for this repository.

OPS Build status updates of commit 9c87dac:
:clock10: Full build: average full build time is not available, there is no data for this repository.

Note: A full build takes more time than an incremental build. This is the expected behavior of the build system.

OPS Build status updates of commit 9c87dac:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

buildstrategytester/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 9c87dac:
:clock10: Preparing: average preparing time is 34 sec(s)

OPS Build status updates of commit 9c87dac:
:clock10: Full build: average full build time is 13 sec(s) [calculated from last 1 build(s)]

Note: This is a FULL build due to the 'master-pr' branch being a new branch in Open Publishing service and is still building. No action is required on your part. For more detailed info, please click here.

OPS Build status updates of commit 9c87dac:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

buildstrategytester/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Health Check port mismatch

Info
This is a Dockerfile that is referencing a parent Dockerfile that has an exposed port of 3000
Steps

deis create
git push deis
deis config:set HEALTHCHECK_URL=/

Creating config... done

=== uchiwa Config
HEALTHCHECK_FAILURE_THRESHOLD      3
HEALTHCHECK_INITIAL_DELAY          50
HEALTHCHECK_PERIOD_SECONDS         10
HEALTHCHECK_PORT                   5000
HEALTHCHECK_SUCCESS_THRESHOLD      1
HEALTHCHECK_TIMEOUT                50
HEALTHCHECK_URL                    /

The expectation was for the HEALTHCHECK_PORT to be 3000.
A kubectl get pods -o yaml --namespace=app shows the port is actually correct.
    livenessProbe:
      failureThreshold: 3
      httpGet:
        path: /
        port: 3000
        scheme: HTTP

A subsequent deployment still has the correct liveness probe of 3000 while the HEALTHCHECK_PORT is still listed as 5000.

This issue was moved to deis/controller#707


Stuck while downloading Youtube Playlist

Hello,
I've tried looking around, but I could not figure out what is causing this. I'm trying to download the Playlist "IntelliJ IDEA Video Tutorials" from https://www.youtube.com/playlist?list=PLPZy-hmwOdEXdOtXdFzyx_XCnrF_oD2Ft using youtube-dl version 2015.10.24, but the download just appears stuck without any error message or progress. I cannot even stop the process using Ctrl+C.
Microsoft Windows [Version 10.0.10240]
(c) 2015 Microsoft Corporation. All rights reserved.
C:IntelliJ Videos>youtube-dl.exe -citv "https://www.youtube.com/playlist?list=PLPZy-hmwOdEXdOtXdFzyx_XCnrF_oD2Ft" > E:\you.txt
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-citv', u'https://www.youtube.com/playlist?list=PLPZy-hmwOdEXdOtXdFzyx_XCnrF_oD2Ft']
[debug] Encodings: locale cp1252, fs mbcs, out None, pref cp1252
[debug] youtube-dl version 2015.10.24
[debug] Python version 2.7.10 - Windows-8-6.2.9200
[debug] exe versions: none
[debug] Proxy map: {}
Any idea?
Thanks

What if you also pass -4?

Moved forward but unfortunately got stuck again. The new log is pasted below-
C:\IntelliJ Videos>youtube-dl.exe -citv4 "https://www.youtube.com/playlist?list=PLPZy-hmwOdEXdOtXdFzyx_XCnrF_oD2Ft"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-citv4', u'https://www.youtube.com/playlist?list=PLPZy-hmwOdEXdOtXdFzyx_XCnrF_oD2Ft']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2015.10.24
[debug] Python version 2.7.10 - Windows-8-6.2.9200
[debug] exe versions: none
[debug] Proxy map: {}
[youtube:playlist] PLPZy-hmwOdEXdOtXdFzyx_XCnrF_oD2Ft: Downloading webpage
[download] Downloading playlist: IntelliJ IDEA Video Tutorials
[youtube:playlist] playlist IntelliJ IDEA Video Tutorials: Downloading 56 videos
[download] Downloading video 1 of 56
[youtube] L_jXj0XTwSg: Downloading webpage
[youtube] L_jXj0XTwSg: Downloading video info webpage
[youtube] L_jXj0XTwSg: Extracting video information
[youtube] L_jXj0XTwSg: Downloading DASH manifest
[youtube] L_jXj0XTwSg: Downloading DASH manifest
[debug] Invoking downloader on u'https://r19---sn-cvh7zne7.googlevideo.com/videoplayback?upn=JqeNjsMqEmE&itag=22&fexp=9407059%2C9408710%2C9414764%2C9416126%2C9417707&signature=4EDDCDDAF870C3A8A11973855112CE309FBC0986.1F7F8E94F8CA409881A742E60CC7E972E9E60540&sparams=dur%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cupn%2Cexpire&sver=3&mn=sn-cvh7zne7&initcwndbps=67500&requiressl=yes&key=yt6&mime=video%2Fmp4&source=youtube&lmt=1419335284956271&dur=403.678&ratebypass=yes&ip=<IP_ADDRESS>&mv=m&pl=20&ipbits=0&ms=au&expire=1445988162&mm=31&id=o-AH5rhpkLsb_6pCYU0DxbDysLNzuJ6gLVM70qXuTNdh58&mt=1445966440'
[download] Destination: Running IntelliJ IDEA for the First Time-L_jXj0XTwSg.mp4
[download]  58.4% of 31.39MiB at 130.52KiB/s ETA 01:42

What do you mean by stuck?  What is you connection? Ping something in parallel when you download.

Well by being stuck, I meant that the download did not progress any further, neither was I able to stop the download using Ctrl + C. I'd waited almost for couple of minutes before posting the output above. The download indicator remained at 58.4% and did not complete. I have a stable internet connection - did not lose any packets when I pinged <IP_ADDRESS> during the download process.

Do you have some AV/personal firewall installed? If you have try adding youtube-dl to the whitelist or disabling them.

Yes I have and I've already tried both options that you have suggested, but nothing seems to work. I use "Kaspersky Internet Security 2015"

Mine is stuck too, I'm downloading a Brightcove video:
"frame=16409 fps= 18 q=-1.0 size=  158305kB time=00:10:56.40 bitrate=1975.7kbits/"
Been like that for some minutes.. I managed to download it two times correctly, other videos form Brightcove. It happened before, but I just restarted it again (wanting to resume, but it just started from scratch again..)
Now it happened twice already with the same video. But I'll try again. Hopefully will work.


Typeahead: ng-change not trigger when value is selected

Angular 1.3.3
UI-Bootstrap: 0.12.0
Plunker

Static arrays

Model: {{selected | json}}

Value: {{copied | json}}

  <input type="text" data-ng-change="copied=selected" data-ng-model="selected" data-typeahead="state for state in states | filter:$viewValue | limitTo:8" class="form-control">

ng-change is correctly triggered when user type a value in the input field.
ng-change is NOT triggered when user type several chars and press select a value

Confirmed here with up to date UI Bootstrap (as of this comment).

Possibly related to PR #3376

Workaround : use 'ng-change' AND 'ng-selected'

@wattazoum Plunker?

here is the Plunker .

Note that this is still current behavior.
Investigating how ng-change works, the Angular documentation notes that it is for when the input value changes. This implies that ng-change is meant to run when the user modifies the input and the change listeners run in the process of converting the view value to the model value. In light of this, I do not believe that we should work around this, and @wattazoum's workaround is sufficient and preferred.

In case it helps someone looking for a solution, I found ng-selected fired far too many times for my liking but typeahead-on-select worked as expected (invoked once upon selection).

@bernhard-hofmann it helped, thanks.

better use:-
typeahead-on-select="functionName(arguement)"

@akshaysinghi
typeahead-on-select="functionName(argument)"
it will trigger only if the item is selected but not the model it self. Like  when them match not found.

Here is a Plunker to show the behavior @jbmyid describes: http://plnkr.co/edit/FcZDMksqFhkVjNo7ZpIC?p=preview
My solution is to call the same function with ng-change and typeahead-on-select like so:
    <input  type="text"
      ng-model="vm.model"
      ng-model-options="{ debounce: { default: 500, blur: 100 } }"
      ng-change="vm.functionName()"
      typeahead-on-select="vm.functionName()"
      uib-typeahead="state for state in vm.states | filter:$viewValue | limitTo:8">

great..thanks

Hi I am using bootsrap  jquery typeahead with angular and I am facing issue on Internet explorer while changing typeahead value second time. typeahead list is not getting hided. It is getting hided only when I click outside or click on the typeahead list.  This issue is because change event is not getting fired. Can anybody suggest me the solution?

thanks @bernhard-hofmann


Added UI for Committee Members section-GeeksforGeeks student chapter committee member details

GOSW4
ISSUE # 4
Describe the changes you've made
I have made the UI for the committee Member Section
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.(added committee folder inside component folder)
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

Please review it


Providing reference for ANSI SQL standards

Providing reference for ANSI SQL standards

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/eba53b1d745a9f14af14eb74ee9d1343c94dc0d5/
Edited pages:

v19.1/architecture/sql-layer.md


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3567

Questions ?
Please refer to the Backport tool documentation


'module' typo in Set-AzureRmRoleDefinition link

Fixes: https://github.com/Azure/azure-docs-powershell/issues/728

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azurermps-6.8.1/authenticate-azureps.md
:white_check_mark:Succeeded
View (azurermps-6.8.1)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: add issue templates with fields and links to support on discord

This introduces some better UX in structuring input for issues and feat requests and most critically pushes support questions and issues to discrord (rather than redirect issues like #2011 )
:eyes:  Taken in large part from https://github.com/paritytech/polkadot-sdk/issues/new/choose that you can see what it looks like with the separated input fields and items.
It's something we can tweak over time, and improve how we ingest these - I am happy to help refine the DevRel side and help declutter the core eng side as much as possible here.

No objections on my end, though this may be another one that's best to wait on until Frank gets back.

as a followup I suggest we also review, clean up / migrate and then disable github discussions on all our user facing repos https://github.com/risc0/devrel/issues/106 - adding a similar PR to update templates to point to discord

updated all instances of .yaml -> .yml (found a stray in 58ddea2)

might I get an assist on CI?  CI / main-status-check (pull_request) Failing after 4s - not clear what https://github.com/risc0/risc0/blob/main/.github/workflows/main.yml#L103-L127 is failing on exactly... an auto-skipped job that is required maybe?


Fix conversion of quint foldr

We were constructing an unneeded lambda wrapper, that was also
triggering a type err on the secondary type-checking pass.
    <unknown>: internal error in type checking: Bug in ToEtcExpr. Expected an operator name, found: LET __QUINT_LAMBDA1(x, y) ≜ x + y IN __QUINT_LAMBDA1 E@15:46:23.130
    at.forsyte.apalache.infra.AdaptedException: <unknown>: internal error in type checking: Bug in ToEtcExpr. Expected an operator name, found: LET __QUINT_LAMBDA1(x, y) ≜ x + y IN __QUINT_LAMBDA1
        at at.forsyte.apalache.infra.passes.PassChainExecutor$.run(PassChainExecutor.scala:39)
        at at.forsyte.apalache.tla.tooling.opt.CheckCmd.run(CheckCmd.scala:132)
        at at.forsyte.apalache.tla.Tool$.runCommand(Tool.scala:138)
        at at.forsyte.apalache.tla.Tool$.run(Tool.scala:118)
        at at.forsyte.apalache.tla.Tool$.main(Tool.scala:40)
        at at.forsyte.apalache.tla.Tool.main(Tool.scala)

This didn't show up until writing integration tests for quint.
Followup to #2488

[x] Tests added for any new code
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)
[x] Documentation added for any new functionality
[x] Entries added to ./unreleased/ for any new functionality

Ah, I missed that! It is working in the integration tests, but because i'm only testing with commutative ops. I better fix that :)
I'll follow up with a fix of this fix :D

So we cannot define a flip operation by name, and then pass that to fold, because for some reason scoped builder requires the operator given to a fold to be a LET/IN
https://github.com/informalsystems/apalache/blob/e7fe0107a2720aa492e46252a00a5eba81b8a4cc/tlair/src/main/scala/at/forsyte/apalache/tla/typecomp/unsafe/UnsafeApalacheBuilder.scala#L131-L139
But when we construct the nested LET/INs required to flip the args inline, we hit the error above due to this rule in the type checker:
https://github.com/informalsystems/apalache/blob/e7fe0107a2720aa492e46252a00a5eba81b8a4cc/tla-typechecker/src/main/scala/at/forsyte/apalache/tla/typecheck/etc/ToEtcExpr.scala#L216-L231
Why can we only apply a name and not an expression (which evaluates to an operator)? Not sure. It's not documented there.
I've not yet traced thru why exactly we hit this, but thought @Kukovec or @konnov might have some idea how we should proceed here.
For reference, here is the TLA we are producing that is triggering the type error:
    ApaFoldSeqLeft(LET (*
      @type: ((Set(Int), Int) => Set(Int));
    *)
    __QUINT_LAMBDA5(__quint_var3, __quint_var2) ==
      (LET (*
        @type: ((Int, Set(Int)) => Set(Int));
      *)
      __QUINT_LAMBDA1(x, acc) == acc \union {x}
      IN
      __QUINT_LAMBDA1)(__quint_var2, __quint_var3)
    IN
    __QUINT_LAMBDA5, {}, (__QUINT_LAMBDA4(l))))
      = n + 1
    /\ n = l[(n + 1)]

Writing that out may have helped. If I assign the operator we need to flip to an intermediate name, perhaps we can pass the typecheck. Like:
    LET opToFlip = LET __QUINT_LAMBDA1(x, acc) == acc \union {x} IN __QUINT_LAMBDA1 IN
    ApaFoldSeqLeft(
    LET
      (* @type: ((Set(Int), Int) => Set(Int)); *)
      __QUINT_LAMBDA5(__quint_var3, __quint_var2) == opToFlip(__quint_var2, __quint_var3)
    IN
      __QUINT_LAMBDA5
    , {}
    , (__QUINT_LAMBDA4(l))
    ))
      = n + 1
    /\ n = l[(n + 1)]

That binding seems silly, but if it'll unblock for now :)

Nah, that doesn't seem to be possible either since opToFlip gets typed as () => (Int, Set(Int)) => Set(Int).

@shonfeder This came up in synchronous discussion w/ @konnov and @Kukovec this morning.

Either we can get the type-checker to consume lambda'd applications (LET X(a, b) == _ IN X)(y, z)

Or, do a contextual translation of the quint lambda to unmangle it into a LET-IN preceeding the ApaFoldSeqLeft

(1) is not legal TLA+.
It seems there's better options for translating (have foldr in a future Quint stdlib, support as an Apalache-builtin), our conclusion was to postpone foldr and hide it from the Quint docs for now: https://github.com/informalsystems/quint/issues/752

Thanks for looping me in the sync discussion. This was gonna be my suggestion today as well, so I'm on board. The "fix" here will then become just removal :)

A point on (2): I created a version of this rewrite to hoist the operation flip into a let above the fold, but it still requires application of a let/in:
    (LET (* @type: ((Int, Set(Int)) => Set(Int)); *)
    __quint_var4(__quint_var2, __quint_var3) ==
      (LET (*
        @type: ((Int, Set(Int)) => Set(Int));
      *)
      __QUINT_LAMBDA0(x, acc) == acc \union {x}
      IN
      __QUINT_LAMBDA0)(__quint_var2, __quint_var3)
    IN

So IIUC, so long as we have this constraint in our type system, and so long as we can only represent lambdas as let/ins, there is no way to write a flip operation on a "lambda".
However, what we could probably do is a rewrite, where we flip the params of the operator, rather than effecting that thru TLA's limited powers of functional abstraction. I'll propose that course at the standup.

We could do a post-processing (proposed by @Kukovec this morning) of the form
(LET X(f1, ..., fn) == body IN X)(p1, ..., pn)  ~~>  LET X(f1, ..., fn) == body IN X(p1, ..., pn)

Simpler fix as per our discussions: now we just remove the operator. Thanks for helping think thru the options and tradeoffs!

Codecov Report

Merging #2500 (3b6a62a) into main (33d30a0) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2500      +/-   ##
==========================================
+ Coverage   78.47%   78.48%   +0.01%
==========================================
  Files         441      441
  Lines       15486    15484       -2
  Branches     2459     2498      +39
==========================================
  Hits        12152    12152
+ Misses       3334     3332       -2

Impacted Files
Coverage Δ

...ain/scala/at/forsyte/apalache/io/quint/Quint.scala
87.33% <ø> (-0.11%)
:arrow_down:

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Use Polymer to make mod Client optional

This is an awesome change!! Just wanted to check before I merge anything, does this make Polymer a required dependency for the mod?

This is an awesome change!! Just wanted to check before I merge anything, does this make Polymer a required dependency for the mod?
It is bundled.

YAY


Record SPO error facet information for summary upload API.

Implement recording info from error facet for summary upload API.
Server tracks implementing actual error facets as https://onedrive.visualstudio.com/SPIN/_workitems/edit/1138128
This is work item triggered from investigation in issue https://github.com/microsoft/FluidFramework/issues/5503
The actual call is in writeSummaryTreeCore(), but ideally implementation should to any ODSP rest calls, and errors automatically get into telemetry.
This will likely be part of https://github.com/microsoft/FluidFramework/pull/6362, but tracking as distinct item coming out of above mentioned investigation

@vladsud Should we close this after @chensixx PR: https://github.com/microsoft/FluidFramework/pull/6362 because that will record the facet code for all odsp errors supplying response?

I think so

Closing as task already achieved with #6362.


Dark mode is no longer persistent

Describe the bug
I set dark mode in the settings, when I log out the theme is back again to light mode.
Steps to reproduce
I set dark mode in the settings / preferences, when I log out the theme is back again to light mode. So the dark mode is not persistent if you click sign-out and you are not logged in.
Screenshots or additional context
No response

Fixed with https://github.com/usememos/memos/commit/3ff4d197821b9c7932e4ede0c85ef943049fb9b4

Dark Mode still switches back to "Follow System" when you open your timeline.
Version 0.18.2


what not to do page

new page in Troubleshooting section

schema don'ts
query don'ts
user don'ts
install don'ts
admin don'ts

Closing -- no plans for this content.


fix: typo and more descriptive info

Summary
just fixed a typo that I've found in an older PR
Test Plan
not needed, this is just docs

Thanks for catching!


Update qt-creator to 4.4.0

[x] brew cask audit --download {{cask_file}} is error-free.

[x] brew cask style --fix {{cask_file}} reports no offenses.

[x] The commit message includes the cask’s name and version.

[ ] sha256 changed but version stayed the same ([what is this?][version-checksum]).
I’m providing public confirmation below.

Thanks for the PR!


Upgrade firmware module

Will help with https://github.com/Vaskivskyi/ha-asusrouter/issues/826, https://github.com/Vaskivskyi/ha-asusrouter/issues/732
Maybe https://github.com/Vaskivskyi/ha-asusrouter/issues/820

This fixes already

the original 826 and the comment
the original 813 and the comment


Dynamically create list dividers

http://forum.ionicframework.com/t/generating-list-with-dividers-dynamically/341/2

I have the feeling this is still not completely solved. Maybe it's just an edge case when using ion-list, ion-item and collection-repeat? I made a codepen to illustrate my problem: http://codepen.io/anon/pen/bdBWMG
The problem is that dividers are not style properly and their content is being wrapped by 'a' tags.

+1 would love to see this resolve and/or at least opened again as it isn't 100% fixed

This is a solution I think might solve the problem.... http://codepen.io/anon/pen/wMdMqv


added rtl support

It might be better to refactor the '$uiTreeHelper' factory as a provider, so it could be configured on the fly. Maybe I'll do it soon.

Added dynamic support to change direction on the fly, as well as a way to set the default to 'rtl' or 'ltr'

It would be good to add unit tests for this behaviour. I've fixed the build in an upcoming PR #341.

The build failed because of a JSHint issue, can you please fix this?

Fixed.
I've tested it live along with some of my customers and teammates. Works good.
I don't have time to add unit tests at the moment.
Have you gone over the code?
and questions / comments?

@Adam-Goldman7 great work, thanks! +1 for adding documentation as well :+1:

Sure!
What's code without documentation ;)

@Adam-Goldman7 I'm trying to use the rtl feature but it doesn't work. I tried to alter the tree config as shown in your commit, also, I tried to change the tree direction dynamically using the attributes. both didn't work.
I checked the source code and I didn't find your commit there!

yes I know
The latest update broke it :(
ᐧ
On Thu, Mar 5, 2015 at 10:24 PM, ashraffayad<EMAIL_ADDRESS>wrote:

@Adam-Goldman7 https://github.com/Adam-Goldman7 I'm trying to use the
rtl feature but it doesn't work. I tried to alter the tree config as shown
in your commit, also, I tried to change the tree direction dynamically
using the attributes. both didn't work.
I checked the source code and I didn't find your commit there!
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui-tree/angular-ui-tree/pull/338#issuecomment-77444232
.

@Adam-Goldman7 any update for rtl support?
as @ashraffayad said, your committed changes aren't in source code any more.
thanks.

After I added rtl support, there was a version update that broke it, and I
haven't modified
the rtl support for the new update, so it's gone.
PS.
I thought I posted this info already (my bad!)
On Sun, Aug 2, 2015 at 3:19 PM, pashaie<EMAIL_ADDRESS>wrote:

@Adam-Goldman7 https://github.com/Adam-Goldman7 any update for rtl
support?
as @ashraffayad https://github.com/ashraffayad said, your committed
changes aren't in source code any more.
thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui-tree/angular-ui-tree/pull/338#issuecomment-127020555
.

@Adam-Goldman7, @pashaie sorry for the inconvenience with the version update. The revert took place here.
We have a trusted release flow by now, so if any of you would create a new PR with rtl-support, we can add it to an upcoming release. The source code with changes needed should all be within this PR I believe (is that correct, @Adam-Goldman7?).

too many changes there for me to follow :/
It's not hard tho if I remember correctly i just inverted the x axis if
either:

an rtl flag was passed in the configuration through the provider in
.config
an attribute with dir="rtl" was added to the directive in the html

I got too much on me hands right now,
maybe will do it someday :)
On Sun, Aug 2, 2015 at 8:25 PM, Niels Dequeker<EMAIL_ADDRESS>wrote:

@Adam-Goldman7 https://github.com/Adam-Goldman7, @pashaie
https://github.com/pashaie sorry for the inconvenience with the version
update. The revert took place here
https://github.com/angular-ui-tree/angular-ui-tree/commit/800dd0a43ce105d6301cd42038c1a28dbe3cd21e
.
We have a trusted release flow by now, so if any of you would create a new
PR with rtl-support, we can add it to an upcoming release. The source code
with changes needed should all be within this PR I believe (is that
correct, @Adam-Goldman7 https://github.com/Adam-Goldman7?).
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui-tree/angular-ui-tree/pull/338#issuecomment-127047965
.


Thief antag

still in development, PR only for Fix Merging and tracking progression
To Do Checklist

[x] Appearance

[x] Thief Game Rule as addition to another game modes
[x] Admin panel make palyer Thief

[x] Pacifism
[ ] Objectives

[x] Steal Item Condition Refactor
[x] Steal Item objectives
[x] Steal item Collection objectives
[ ] Steal structure objectives
[ ] Steal alive animal objectives
[ ] Return to Centcomm Alive objective
[ ] Specific Steal Objective by race (light bulbs for moths)
[ ] Balancing

[ ] Equipment

[ ] Adding Starting Items
[ ] New Bluespace coupon

[ ] Manifest

About the PR

The new small antagonist "Thief", which is an addition to other modes such as Traitors and Revolution (and other in future)
more details in the design document below
Design doc
Why / Balance

ss13 content
more antags!
Technical details

to come
Media
There will be less objective in the game, lol, it's only for previews

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

add: Added new minor antagonist: Thief. He has a chance of appearing as a roundstart among players in some game modes

The objectives seem very difficult. Like, stealing 4 stamps meaning hacking into 4 command rooms OR stealing the bags of 4 heads like omg

It's possible, but I haven't done much balancing.

Very excited to see this get added. Could I ask why Ian is excluded from the animal objectives? Is it because of the prime corgi meat syndicate objective? I think that'd make him the most exciting steal objective.

i think forcing pacifism is bad:

can be metagamed, why arent you fighting back?!?!?!? you must be thief!!!!!!
shoving and self defense if you get caught should be possible
you can still kill people by throwing spears / spacing them / flushing into space / opening a plasma canister / etc

should be in briefing or something to not use violence

no, forced pacifism is good and based

i think forcing pacifism is bad:

can be metagamed, why arent you fighting back?!?!?!? you must be thief!!!!!!
shoving and self defense if you get caught should be possible
you can still kill people by throwing spears / spacing them / flushing into space / opening a plasma canister / etc

should be in briefing or something to not use violence

Pacifism is a trait that people can select, so it's not really a issue re metagaming
I don't mind if thieves can commit indirect violence, it encourages them to be more thoughtful and sneaky in their takedown. Being able to cause damage with thrown items seems like an oversight for pacifists in general though

Forcing pacifism seems like a really poor way to attempt to stop them from killing people- if you're that concerned about a minor antag killing people then moderators should be handling it or the objectives should be changed. You're putting people at a significant disadvantage while they're supposed to be an antag, and outright disallowing some items / strategies from being used (ie, fireaxes).

Forcing pacifism seems like a really poor way to attempt to stop them from killing people- if you're that concerned about a minor antag killing people then moderators should be handling it or the objectives should be changed.

I feel like forced pacifism shouldn't be a thing for antags at all, just make it specifically tell you not to kill people if you don't need to and then admins can deal with thieves murdering people.

no, forced pacifism is good and based

if pacifism is forced then the thief can't mug people for their shit which is infinitely more based than pacifism

What if you could remove this pacifism implant with an implant remover? Wouldn't that make more sense lore-wise?

I think an pacific implanter would be an interesting solution, but the ability to get rid of it quickly if you're playing as a medic... I don't know yet, I need to hear what the maintainers think.

the pacifism seems mildly metagameable to me, especially if it's an implant

maybe add clumsiness instead of pacifism?

Clumsy could be metagamed even harder, is the issue.
From the standpoint of an RP player forcing any trait seems really awkward for gameplay, not to mention having to explain to people who know your character well why you just stood there and got beat to death by a spider since you're a thief and therefore literally incapable of attacking it.

I agree that adding perks can affect the metagame, but we need to stop the thief from killing people.  Even in the absence of moderation

and given the experience of playing traitors, a confrontation with witnesses in most cases will automatically lead to the desire to get rid of them.  Kill them.
on thief this should be unacceptable

That's understandable, but syndies are probably worse with this because of their uplinks whereas thieves could only use whatever they managed to steal (which feels somewhat fitting). I think giving thief's any trait is bound to lead to people metagaming it in one way or another, whether it's "this person normally fights but now they aren't", "this salvage hasn't been attacking any mobs," or "hit me or you're going in perma". Not to mention how weird it is to have a major part of your moveset taken because you're an antagonist. Maybe some "do less than X damage to living beings" objective could work as a better solution than outright forcing pacifism, though I know that's just more work which isn't ideal.

yes literally any mob event will result in your death
spider? die
slime? die
rats? die hard

The problem is that damage can be caused in many indirect ways, such as throwing a sleeping person into space.  Goals tracking your violence are very difficult to achieve.

The problem is that damage can be caused in many indirect ways, such as throwing a sleeping person into space.  Goals tracking your violence are very difficult to achieve.

The current method of forcing the pacifist trait doesn't account for these either, so I don't see how that's a huge problem.

I will look for solutions to the problem.  I don't like pacifism either

It seems like the game had a system for calculating the player’s danger, counting how many weapons he has?  if yes, then it can be used and give the thief some bonuses if his danger level is very low

drop all your guns just before evac docks :trollface:

Not certainly in that way.  don't make the goal of being unarmed, but rather, give bonuses during gameplay while you're unarmed.  For example, you can only use some tools while you have little equipment

With the addition of homemade bombs, the thief can still become a "suicide bomber" or give the clown a "confetti bomb".    As an option, you can, of course, make a crutch with a white list of weapons used - but again, stupidity

And now to this pool request. @deltanedas  I'm still hoping for a confetti bomb for the clown ;)

I will look for solutions to the problem. I don't like pacifism either

I think there can't be a proper solution to pacifism that wont end up causing more problems, because at this rate a good fourth if not more of all content  will have to be somehow locked to pacifists and then that causes gargantuan metagaming and maintenance problems.
A silly example would be space in general, how do you prevent the thief from slip+cuffing someone and then dragging them into space to indirectly kill them and then opt in for a permakill by throwing their body away? Do note that we're also trying to avoid "easy" metagaming and keep the system fun, the answer as I see it is "you can't"

From what it seems like, i don’t think pacifism is an option and people will always find a way to attack others no matter what. However, it would probably be fine to simply discourage it in some way. For example, dealing less damage on hit/shoot/bomb activation or having very low stamina. Something along those lines.

the thief's thieving gloves should also probably be special ones with chameleon so they don't get metagamed since black gloves on non-sec sus

I... don't entirely understand how this isnt just a thing syndicates already do? I mean Im all for more objectives but...

The Syndicate executes more dangerous targets and has the option of assassination available to them. Therefore, items hunted by the syndicate often result in the killing of their bearers.
The thief is a minor antagonist, he has to steal many different not particularly important items, and he does not kill the owners in doing so.
Plus, thieves will be able to appear even in other game modes that don't have traitors.

The job is almost done!

The job is almost done!

Hypopen, not hippo pen.

Okay. I've basically done most of the work. I just need to fix the interface a little bit, and also revise the tasks. But the whole part of the work related to code and logic is ready to be checked.

In Server.Roles.RoleSystem.cs you will need to SubscribeAntagEvents(); for it to show up on admin panel

thx, Emisse. fixed

its illusion :trollface:

Suggestions:
Stealing resources (ie gold/silver)
Stealing Alcohol (Dwarves, difficulty 0)
Stealing Scarves/Winter Coats (Lizards, difficulty 0)
Singulo Containment Emitters? Station usually gets spares
Something that can be used to facilitate transport of heavy items (TEG is very slow and conspicuous to move)
Invisible Bag (Like the crate but smaller for high value items)
Non recharging emag
Voice Changer mask that has a fixed name / one time changeable name, ie your thief persona

stackable items are not yet supported
I'll add alcohol for the dwarfs.)
the rest of it doesn't seem to fit as well as I think it does.

Actually, no, you can't steal beer. I could target beer bottles, but that wouldn't make sense. Because they could have any kind of reagent in them. So other bottles filled with beer won't count.

I'm done correcting the thief's bugs and UI. There's one left about dublicating objectives in end round text, but it's minor and, to me, outside the scope of the PR.

fixed

How many steal objectives will the thief have, 4/5 like the images you sent show? If so, i believe it would be more balanced to put more effort on one or two by lowering the obj count since its quite a lot.

check design doc

depends on the complexity of the goals. The number of objectives can vary from 2 to 6. One of them is always escape

I have a suggestion to add the seals of department heads to the communication kit. I've just looked at all the sets and the communication kit seems to be the weakest, and the seals of the heads of departments can help in some cases. What do you think?

I think we should make a special chameleon seal. But it should probably be a separate PR. It might be a good option for now.

oh damn, that turned out to be a bad idea.  This completely kills the task of stealing the seals of department heads

I thought about your idea of the chameleon seal and realized that it could work as a door controller for heads. Like switching and putting a seal, but there is a catch in how it will look like? I thought either I should make a new black model or a clown or mime seal replica. What do you think about this?

this clearly must look like something illegal.  black colors, yeah.  but it is possible to change the shape and make it like an electronic device.  If you make a PR like this, this one will be great!

I can make the models without any problems, but the code will be a little difficult. I'll try to do something, but I can't guarantee that I'll make the code.

Some steal objective items do not spawn at shift start (eg Bible) on some maps (ie Saltern)
I got an objective to steal a bible as the only player (passenger)

@TheShuEd One question has arisen, why do you give him crystals in the syndicate kit, but do not give him an uplink?

for trading with agents through PAI


Scripting with neogit?

Amazing plugin, only touched the surface what it can do and it seems like you have amazing plans for it! I think I will be able to replace fugitive if I could automate some workflows that I have, namely saving changes to the file, committing those changes and pushing to remote. Is it possible with current state of neogit? I guess neogit would need to expose some functions?
Thanks!

Just to leave my thoughts on the matter: While I do think we'll expose a stable api at some point to use for scripting, it would most likely involve the use of async, so I think we should wait for nvim-lua/plenary.nvim#83 to get merged, transition our code to that and expose an api that way, just so users can have reasonable expectations about the async/await api.
(Also, that way users would need to have plenary, and by extension the async/await set of functions, already installed, so we don't have to worry about that too; and we'd have a place to point to for documentation on the matter :grin:)

@cloggier for now you could look through neogit.lib.
Things that might interest you:

cli.lua
git/*.lua


Remove superfluous links.

They just point to DEVGUIDE and TESTGUIDE in the text.

Hi @kurtschelfthout, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thank you @kurtschelfthout for taking care of this.


segmentation_fault

Hi!
By trying to run both easy_pbr and permuto_sdf I encounter the problem Segmentation fault (core dumped).

I have tried on multiple aws ec2 instances, running ubuntu 20.04 or ubuntu 22.04. I've run it inside the docker containers running on top of nvcr.io/nvidia/pytorch:22.08-py3 (and also the experimental version), as well as installed it natively on the ec2 instance.
I've tried with vnc on gdm as a remote desktop access as well as on NICE DCV.

When I'm trying to run permuto:
python permuto_sdf_py/train_permuto_sdf.py --dataset dtu \
> --scene dtu_scan24 \
> --comp_name comp_3 \
> --exp_info default
args.with_mask False
args.low_res False
checkpoint_path /workspace/permuto_sdf/checkpoints
with_viewer True
has_apex True
[    EE1F9740]DataLoaderDTU.cxx:173      1| loaded nr of scenes 1 for mode train
[    EE1F9740]DataLoaderDTU.cxx:432      1| reading poses and intrinsics for scene "dtu_scan24"
[    EE1F9740]DataLoaderDTU.cxx:173      1| loaded nr of scenes 1 for mode test
[    EE1F9740]DataLoaderDTU.cxx:432      1| reading poses and intrinsics for scene "dtu_scan24"
[    EE1F9740]    Mesh.cxx:3417     1| read obj with path /workspace/easy_pbr/data/sphere.obj
Segmentation fault (core dumped)

When I'm trying to run examples/pbr.py I get:
(many more warnings)...
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name enable_ssao is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name get_ao_from_precomputation is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name render_uv_to_gbuffer is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name MV is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name colors_are_precomputed_ao is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name enable_ssao is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name get_ao_from_precomputation is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name render_uv_to_gbuffer is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name MV is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name colors_are_precomputed_ao is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name enable_ssao is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name get_ao_from_precomputation is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name render_uv_to_gbuffer is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name MV is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name colors_are_precomputed_ao is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name enable_ssao is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name get_ao_from_precomputation is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name render_uv_to_gbuffer is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name MV is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name colors_are_precomputed_ao is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name enable_ssao is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name get_ao_from_precomputation is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name render_uv_to_gbuffer is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name MV is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name colors_are_precomputed_ao is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name enable_ssao is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
[    55060740]  Shader.cxx:409   WARN| draw_mesh: Uniform location for name get_ao_from_precomputation is invalid. Are you sure you are using the uniform in the shader? Maybe you are also binding too many stuff.
Segmentation fault (core dumped)

How can I solve this? I'm out of options.

Hi @cduguet,
In general easypbr is not meant to run on a headless machine. To disable it, you can run the training script with the "--no_viewer" flag.
Please let me know if that solves the issue for you.

Hello,
I have already tried running with --no_viewer in the past, but my results so far are just gibberish, so I wanted to use the viewer to debug camera positions and maybe other factors.
In what platforms/OS is the software tested to work?


Rate limiting / checking links mulitple times because they appear on multiple pages

The server, that I am using to run broken_link_finder is quite limited in resources as it only has 1 CPU. I have noticed  that the 1 minute and 5 minute CPU load averages will go above 2 while broken_link_finder is running.
I know that I can use nice to slow processes down but I am also concerned that sites maybe dropping or refusing request because of too many in too short a time span.
In my most recent test in the footer of one site there is a link to the site's Facebook page and to their Youtube channel. Both of these have been reported once in a reports on only one page that they were broken links. I used a web browser and curl -I example.com to check them and I was getting a HTTP response code of 200 for both.
Does broken_link_finder just go through found links on a page even if they exactly match ones that it has found on other pages on that site? If it is not passing over exact matching links that means for this site it would hit Youtube and Facebook on every page to test the same links.

Yes, currently broken_link_finder simply crawls whatever links it finds and reports their status. I've been wanting to add some link recording logic for some time. Doing so will reduce the overall crawl times and required bandwidth. This will also aid the possibility of sites dropping requests because they believe they're being hit with a DOS attack.
However, if a webpage has 50 links to Facebook, for example, all of them with different paths (making them unique from each other) then Facebook will likely continue to drop requests, so this isn't a full-proof solution to that problem. But given the small likely hood of such a scenario occurring, a full solution to this is way down the road map, if at all; especially when third party solutions to this exist i.e. nice as you suggested.
Since the efficiency of broken_link_finder is and always will be a priority, the next release will contain a form of link recording logic meaning each link on a page/site will only be crawled once. This will speed up the crawl for large sites (especially those with repeated links) and should help somewhat prevent dropped requests resulting in reported links. I will update this issue when the release is out.

OK, broken_link_finder 0.8.1 should resolve the issues raised above. Here are the details for this version from the CHANGELOG:
v0.8.1
Added

Logic to prevent re-crawling links for more efficiency. Users should see a substantial speed boost when crawling large sites with repeated links.

Changed/Removed

Updated the wgit gem which fixes a bug in crawl_site and adds support for IRI's (including umlauts).

Fixed

Bug where an error from the executable wasn't being rescued. Now all errors are presenting to the user in a clean manner (without the stack trace).

@frederickjh can you please retest your scenarios and update this issue? Thanks.

Version 0.9.0 has been released and contains the following changes:
v0.9.0
Added

The version command to the executable.
The --threads aka -t option to the executable's crawl command to control crawl speed vs. resource usage.

Changed/Removed

Changed the default number of maximum threads for a recursive crawl from 30 to 100. Users will see a speed boost with increased resource usage as a result. This is configurable using the new crawl command option e.g. --threads 30.

Fixed

Several bugs by updating the wgit dependancy including the 'Invalid URL' error.
A bug in the report logic causing an incorrect link count.

@frederickjh This should address the issues in the last release, can you retest and confirm the status of this issue please?


Introduce cluster template with Passt binding

What this PR does / why we need it:
This PR adds template with VMs using Passt binding to pod network.
Passt featureGate is enabled in kubevirtci script and Passt recommended node configuration is performed on cluster-up.
NOTE: There is a commit bumping kubevirt to 0.59.0-alpha, because while https://github.com/kubevirt/kubevirt/pull/8578 is merged in kubevirt release-0.58 branch, the change hasn't made it to v0.58.0 tag.
Lastly, an e2e test is added to exercise cluster creation with Passt binding.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release notes:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.459%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
952

Relevant Lines:
1850

💛  - Coveralls

/ok-to-test

/ok-to-test

/lgtm


Bracketed "diceNumber" resolving problem.

Last update it was working just fine but a rule element like this no longer works on the current update (5.1.1)
"brackets": [
{
"start": 11,
"value": {
"diceNumber"<EMAIL_ADDRESS>* 2"
"dieSize": "d8"
},
"end": 16
}

Is this found on a compendium item?


Simnode for integration tests

Simnode is an integration testing environment for substrate runtimes that allows you to create extrinsics from any account and full control over block production.
Consider integrating to Madara for integration tests
https://simnode.polytope.technology

Can I take this one @abdelhamidbakhta ? It will my first issue on Madara

Can I take this one @abdelhamidbakhta ? It will be my first issue on Madara

Sure, I assigned it to you. Thank you

@abdelhamidbakhta, I would like to take on this task. Would you kindly assign it to me?

can you open a draft pr plz

@LucasLvy, I have opened a draft pull request with intermediate changes. There is a build integrity break, but I will fix it and achieve the demo state by the end of tomorrow.


Use cruft and Ouranosinc/cookiecutter-pypackage

Changes

Regenerated the project template using https://github.com/Ouranosinc/cookiecutter-pypackage so that changes can be tracked.
Renamed /doc to /docs.
Added a pre-commit configuration with flake8 and pydocstyle checks disabled for now.
Added Anaconda environment files for documentation and development.
Cleaned up dependencies and commented out all broken cells in getting-started.ipynb.
Updated pre-commit hook versions.

@sebastienlanglois
I've cleaned this up and will be making a squash merge to not pollute the git history.
It looks like there's an issue with one of the notebook cells, but otherwise the package is in a more maintainable condition, IMO. Feel free to add changes to the notebook here. Let me know if there's anything you'd like changed.
Best,

@sebastienlanglois
This PR is good to merge. Care to give it a final review? Let me know!

@Zeitsperre
Thanks for all the work and sorry for the delay. I'm ready to merge this branch but noticed you were still adding some commits recently. Should I wait for more changes or can I merge it now ? Thanks!

@sebastienlanglois
Good to hear from you! This PR is good. For the documentation, I'm going to open a new issue about it and do the final touches there. There's enough going on in here.
Feel free to merge!


⚠ Bofrost.es has degraded performance

In 566fb3d, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1696 ms

Resolved: Bofrost.es performance has improved in 3e86e0a after 28 minutes.


Update console tests to account for changes in util.format

The behavior of util.format() changed when formatting errors being node v4 and v6. The new version includes the full stack trace, when node v4 only included the message.
This version of the tests can run in either node v4 or v6.

The CI build failed because PR #1072 hasn't been merged yet.


"Type incompatible" error may return incomprehensible position

Consider the following setup:
/* file1.js   @flow */
class Foo {
  foo: number;
}
module.exports = Foo;

/* file999.js   @flow */
function something(): Foo {
  return new Foo();
}
function otherthing(): Date {
  return something();
}

The error reported will be
js/test1.js:3:11,35: Foo
This type is incompatible with
[LIB] core.js:222:1,277:1: Date

In other words, Flow reports an error in a totally innocent line module.exports = Foo;, and at the same time says nothing about the unrelated and possibly hard to find file file999.js which actually causes the error...

I just tested this with master and Flow blamed the import (which I had to add to your example here). Hopefully this will be fixed in the next release.

This has been fixed. Please let us know if you are still having this issue 😊


how to popup another form

I need help in popping up a form based on selecting a value from the drop down list.
For example the drop down will have three values like

Active
-Closed
-Moved

I need to open a separate form for "Closed" for example and another for "Moved" value. Each form will have different properties that need to be filled.
I am familiar with inplace editor but I am not sure how to configure it and I also found a good wiki here  by @minhhungit but It is working on the same form.
Thanks for any help

Hi @ms4hafiz ,
I don't understand your use case. Can you elaborate more? Are these 3 stati (closed, moved, Active) values of a field within the grid? If yes - What is the reason you cannot use one form which includes all fields needed for all 3 stati and then selectively hide those which are not needed for a specific status (e.g. if you want to show the form for a "closed" status, hide those fields which are not desired for the "closed" status).
With kind regards,
John

@JohnRanger
Thanks. One way could be as you suggested but the forms requirements for each status is much different. Anyway I have now figure it through database modeling.


my gentx to join testing

Please make sure your node is up and running now. Join #validators on Discord for help: https://discord.gg/QeJWCrE.


Allow any number of decimal places for seconds

Same as onelogin/python-saml#251

Coverage decreased (-0.006%) to 95.822% when pulling e8ef7d15d2c4c65dd0d998661cc64c677d728417 on jalan:master into ae90bac7c94c82c4a5625aff57163aab2a8098d4 on onelogin:master.

Coverage decreased (-0.006%) to 95.822% when pulling e8ef7d15d2c4c65dd0d998661cc64c677d728417 on jalan:master into ae90bac7c94c82c4a5625aff57163aab2a8098d4 on onelogin:master.

Coverage decreased (-0.006%) to 95.822% when pulling e8ef7d15d2c4c65dd0d998661cc64c677d728417 on jalan:master into ae90bac7c94c82c4a5625aff57163aab2a8098d4 on onelogin:master.

Calm down there, coveralls bot! Coverage percentage changed because the number of lines of code went down.

Fixed here: 5f162dc9947bb34cd7502177f35e4edbf9a477dd


Sigma cleanup

#219  Code changes brief
Removed unneeded code for Sigma transaction generation.

@levonpetrosyan93 perhaps squash both commits for one atomic commit?

@levonpetrosyan93 please fix a conflict

@levonpetrosyan93 I have tried to reindex and sync from scratch and they works as expected. It should safe to merge now.


Add Contributor License Agreement and its hooks

What are people's opinions on adding a CLA to both the cookiecutter repo and the output project?

It could be an option, but they can get really tricky to setup. Do you have a suggested way of building these?

Not off the top of my head. I have also not looked into setting one up myself, but I wanted to at least pose the question to see if others had ideas.

What are people's opinions on adding a CLA to both the cookiecutter repo and the output project?

It's worth a try! Ideally, we'd have both (1) a CLA for contributions to the repo, and (2) the option to choose a CLA for contributions to the project being set up.

Several current options:

https://cla-assistant.io
https://github.com/apps/cla-bot

@j-wags


fix: docker-compose DB config

Setting custom values for Postgres user credentials did not work if the application running inside the container because by default the Postgres container creates only a default user with default credentials. Previously these custom credentials specified in the env variables were passed to the Postgres image and it led to an error, because this user didn't exist in the default configuration, so, containers crashed in this case.
Now if the app runs in containers, user credentials specified in the env variables are ignored and the default user credentials are used.
We already have similar adjustments in other reops and folks like the idea
https://github.com/lidofinance/node-operators-widget-backend-ts/pull/80
https://github.com/lidofinance/ethereum-validators-monitoring/pull/242

As the database is correctly created with the name and credentials specified in the .env file in the existing version of the docker-compose file if the app's containers are created from scratch, it has been decided to keep the existing version of the docker-compose file and not to hardcode pre-defined DB name and credentials there.
Closing this Pull Request.


Check resource action authorization

For every resource in the routing, check that there is a method defined for every action in the policy.
E.g. resource :alerts, :only => %i[show update] => AlertPolicy#show?, AlertPolicy#update?

https://trello.com/c/23GMx3TO/316-check-resource-action-authorization


Use Dockerfile.template as root source of truth.

This commit takes the lead from
docker-node, separating
supported versions into their own folders, using Dockerfiles generated
from template. This commit closes #92 by backporting Clang 3.8 into 3.1.
I have also removed two soon to expire PGP keys from the file and added the new automation key.

@swizzlr i wanted to do this forever!!!! redis, ruby, and a bunch of other docker images are doing the same thing! I think i mentioned this in some discussion earlier Thank you!

I've smoke tested both 3 and 4 with two separate Swift 3 and 4 codebases respectively.


Fix case of GitHub.

Changed Github to GitHub.

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

https://github.com/github/opensource.guide/pull/2853#pullrequestreview-996847529

Changed Github to GitHub.

[x] Have you followed the contributing guidelines?

[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Question answering example throws an exception even if sanity check is skipped

🐛 Bug
Running the squad example python train.py task=nlp/question_answering dataset=nlp/question_answering/squad trainer.gpus=[1] training.batch_size=8 trainer.num_sanity_val_steps=0 throws an exception while finalizing training. This is not a replication of #218
To Reproduce
Steps to reproduce the behavior:

Run python train.py task=nlp/question_answering dataset=nlp/question_answering/squad trainer.gpus=[1] training.batch_size=8 trainer.num_sanity_val_steps=0
See error

Epoch 0: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████▉| 12442/12445 [44:35<00:00,  4.65it/s, loss=0.957
Error executing job with overrides: ['task=nlp/question_answering', 'dataset=nlp/question_answering/squad', 'trainer.gpus=[1]', 'training.batch_size=8', 'trainer.num_sanity_val_steps=0']3 [01:39<00:00, 13.59it/s]
Traceback (most recent call last):
  File "/home/vrt/lightning-transformers/train.py", line 10, in hydra_entry
    main(cfg)
  File "/home/vrt/lightning-transformers/lightning_transformers/cli/train.py", line 69, in main
    run(
  File "/home/vrt/lightning-transformers/lightning_transformers/cli/train.py", line 60, in run
    trainer.fit(model, datamodule=data_module)
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 740, in fit
    self._call_and_handle_interrupt(
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 685, in _call_and_handle_interrupt
    return trainer_fn(*args, **kwargs)
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 777, in _fit_impl
    self._run(model, ckpt_path=ckpt_path)
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 1199, in _run
    self._dispatch()
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 1279, in _dispatch
    self.training_type_plugin.start_training(self)
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 202, in start_training
    self._results = trainer.run_stage()
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 1289, in run_stage
    return self._run_train()
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 1319, in _run_train
    self.fit_loop.run()
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/loops/base.py", line 145, in run
    self.advance(*args, **kwargs)
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/loops/fit_loop.py", line 234, in advance
    self.epoch_loop.run(data_fetcher)
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/loops/base.py", line 146, in run
    self.on_advance_end()
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 242, in on_advance_end
    self._run_validation()
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 337, in _run_validation
    self.val_loop.run()
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/loops/base.py", line 151, in run
    output = self.on_run_end()
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 134, in on_run_end
    self._on_evaluation_epoch_end()
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 241, in _on_evaluation_epoch_end
    self.trainer.call_hook(hook_name)
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 1501, in call_hook
    output = model_fx(*args, **kwargs)
  File "/home/vrt/lightning-transformers/lightning_transformers/task/nlp/question_answering/model.py", line 59, in on_validation_epoch_end
    metric_dict = self.metric.compute()
  File "/home/vrt/miniconda3/lib/python3.9/site-packages/torchmetrics/metric.py", line 380, in wrapped_func
    value = compute(*args, **kwargs)
  File "/home/vrt/lightning-transformers/lightning_transformers/task/nlp/question_answering/datasets/squad/metric.py", line 23, in compute
    example_ids = [reverse_lookup[i.item()] for i in self.example_ids]
  File "/home/vrt/lightning-transformers/lightning_transformers/task/nlp/question_answering/datasets/squad/metric.py", line 23, in <listcomp>
    example_ids = [reverse_lookup[i.item()] for i in self.example_ids]
KeyError: 0

Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.

Environment

PyTorch Version: 1.6.0
OS: Ubuntu 18.04.6 LTS
How you installed PyTorch: conda
Python version: 3.9.7
CUDA/cuDNN version: 11.4
GPU models and configuration: 2x NVIDIA GeForce RTX 2080 Ti (First device not used)
Any other relevant information: The same error occurs during sanity check if trainer.num_sanity_val_steps=-1 is used, as in #184

Strangely, I got the KeyError: 0 at some point earlier today without using trainer.num_sanity_val_steps=0, but I haven't been able to reproduce it, nor do I get it when adding trainer.num_sanity_val_steps=0 as you say. Could caching be involved?

Ah, nevermind, this happens at the evaluation step, so we got to let it finish training the epoch first. I confirm I see this error too.

Clearly, self.example_id_strings is empty (never updated) but we use it to create reverse_lookup, which will also be empty.

I attempt to fix this issue with PR #235.

@SeanNaren ^^ :rabbit:

Bad bot.
Strangely I cant close this issue myself?

The QA task is really broken... I don't have time to debug it but if anyone can help would appreciate it!

@mariomeissner, would you be interested in diving in and debugging this issue? :rabbit:

I've been away for a while and don't know the current situation. Was PR #235 not enough? I'd be happy to dig into this again if you point me in some direction 😄

I've been away for a while and don't know the current situation. Was PR #235 not enough? I'd be happy to dig into this again if you point me in some direction smile

I may say that the best would be just to check it out :)


Update smithay-client-toolkit; fixes crash on Hyprland

Fixes #7 , result from running cargo update smithay-client-toolkit, there was apparently a fix (from here: https://github.com/Smithay/client-toolkit/compare/v0.16.0...v0.16.1).

smithay-client-toolkit isn't imported directly, some other imported crate depends on it, probably eframe/winit since it's a windowing toolkit error

Unneeded as updating eframe fixed the issue


Option to rebuild checkpointed sleep model in predict.py

After merging in the new predict code on #218, the test for predict.py fails because it is trying to load a checkpoint of the model.
https://github.com/prob-ml/bliss/blob/24c2a8bbf3dadbec4d96b2f74a5aab0f013930cd/bliss/predict.py#L16
This fails since I have changed some of the attributes of the decoder. Is there a way to rebuild this checkpoint?
@ismael-mendoza

Hi @dereklhansen, thanks for the question! Yes I actually did not add an option to predict.py to do this because you can use train.py to recreate the checkpoint. Here is the command:
poetry run bliss mode="train" model="sleep_galaxy_measure_stars1" dataset="default" paths.output="path/to/output/directory" gpus=[2] optimizer.params.lr=1e-4 training.n_epochs=201 training.trainer.checkpoint_callback=True

Thanks Ismael - this is very helpful


[now-next] Update to pass dynamic page values in the query

As discussed this updates to leverage the new named regexes and route keys output in the routes-manifest.json to pass the dyname page values in the query to ensure we're handling edge cases with the new custom routes support
Note: the yarnPreferOffline change is unrelated and was added to make debugging easier as the build can fail when using this option and the cache is invalid for some packages.
x-ref: https://github.com/zeit/next.js/pull/12250

I suspect that this would resolve the issue I've repo'd here: https://github.com/zephraph/next-now-ssr-issue

@zephraph it sounds like you need to change this line to "routes": [{ "src": "/next(.*)", "dest": "/apps/$1", "continue": true }]


Wrong declaration file generated for JS + subclass

TypeScript Version:  3.7.x-dev.201xxxxx

Search Terms:
Code

src/tsconfig.json

{
  "compilerOptions": {
    "allowJs": true,
    "declaration": true,
    "emitDeclarationOnly": true,
    "declarationDir": "../dts/"
  }
}

src/index.js (Important, this only happens in .js file)

export class A {
  /** @returns {this} */
  method() {}
}
export default class Base extends A {
  // This method is required to reproduce this bug
  verify() {}
}

Expected behavior:
Generated .d.ts:
export declare class A {
    /** @returns {this} */
    method(): void;
}
export default class Base extends A {
    verify(): void;
}

Actual behavior:
export class A {
    /** @returns {this} */
    method(): A;
}
export default class Base extends A {
    verify(): void;
    /** @returns {this} */
    method(): Base;
}

The wrong behavior:

Methods from the parent class is copied to the subclass
The return type of copied class is wrong (should be this, actually the class name.)

This behavior cause the error following:
(The parent class is import('events').EventEmitter)

Looks like I have same issue:
https://github.com/chriswoodle/typescript-allowjs-eventemitter-bug

Hmm do you sure it get fixed? When I doing code gen in 4.0.0-dev-20200505 it still exists

Is there a second issue? we have your repro, almost verbatim, in our test suite now

Oh strange I can't reproduce it by a POC

> const m = require('ts-morph')
> m.ts.version
'3.8.3'
> const ts = require('typescript')
> ts.version
'4.0.0-dev.20200505'
>

It's a dependency problem, sorry! 🤣


Suggestion: add a button to see the actual fabric.mod.json content

A button to see the actual fabric.mod.json content in the right pane

Why do you think this would be useful?

To easily check the values in the file, without having to unzip the jar. Making it easier to see and report problems.
This is an example: https://github.com/modmuss50/OptiFabric/issues/16

I think this is a bit out of scope. Mod Menu's not a debug tool


Parsers need more verification and tests

There are still places where duplicate dimensions, metrics and other schema problems can slip through. We need to make sure that these things are caught and report correct error messages.

can you provide more specifics?

The work done recently has made this a lot better. CLosing for now


Add support for Azure CDN

This is WIP, but wanted to invite some feedback on the commands. I'll add tests tomorrow.

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[x] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

[x] Each command and parameter has a meaningful description.
[x] Each new command has a test.

(see Authoring Command Modules)
$ az cdn -h

Group
    az cdn: Manage Azure Content Delivery Networks (CDN).

Subgroups:
    custom-domain
    edge-node
    endpoint
    origin
    profile

Commands:
    name-exists  : Check the availability of a resource name.
    usage        : Check the quota and actual usage of the CDN profiles under the given
                   subscription.

$ az cdn profile -h

Group
    az cdn profile

Commands:
    create: Creates a new CDN profile with a profile name under the specified resource group.
    delete: Deletes an existing CDN profile with the specified parameters.
    list  : List your Azure Content Delivery Network (CDN) profiles.
    show  : Gets a CDN profile with the specified profile name under the specified subscription and
            resource group.
    update: Updates a CDN profile with a profile name under the specified resource group.
    usage : Checks the quota and actual usage of endpoints under the given CDN profile.

$ az cdn profile create -h

Command
    az cdn profile create: Creates a new CDN profile with a profile name under the specified
    resource group.

Arguments
    --name -n           [Required]: The name of the CDN profile.
    --resource-group -g [Required]: Name of resource group. You can configure the default group
                                    using `az configure --defaults group=<name>`.
    --location -l                 : Location. You can configure the default location using `az
                                    configure --defaults location=<location>`.
    --sku                         : The pricing tier (defines a CDN provider, feature list and rate)
                                    of the CDN profile. Defaults to Standard_Akamai.  Allowed
                                    values: Custom_Verizon, Premium_Verizon, Standard_Akamai,
                                    Standard_ChinaCdn, Standard_Verizon.  Default: Standard_Akamai.
    --tags                        : Space separated tags in 'key[=value]' format. Use '' to clear
                                    existing tags.

Global Arguments
    --debug                       : Increase logging verbosity to show all debug logs.
    --help -h                     : Show this help message and exit.
    --output -o                   : Output format.  Allowed values: json, jsonc, table, tsv.
                                    Default: json.
    --query                       : JMESPath query string. See http://jmespath.org/ for more
                                    information and examples.
    --verbose                     : Increase logging verbosity. Use --debug for full debug logs.

Examples
    Create a CDN profile using Verizon premium CDN
        az cdn profile create -g group -n profile --sku Premium_Verizon

$ az cdn endpoint -h

Group
    az cdn endpoint

Commands:
    create                : CDN endpoint is the entity within a CDN profile containing configuration
                            information such as origin, protocol, content caching and delivery
                            behavior.
    delete                : Deletes an existing CDN endpoint with the specified endpoint name under
                            the specified subscription, resource group and profile.
    list                  : Lists existing CDN endpoints.
    load                  : Pre-loads a content to CDN.
    purge                 : Removes a content from CDN.
    show                  : Gets an existing CDN endpoint with the specified endpoint name under the
                            specified subscription, resource group and profile.
    start                 : Starts an existing CDN endpoint that is on a stopped state.
    stop                  : Stops an existing running CDN endpoint.
    update                : Updates a CDN endpoint within a profile and resource group.
    validate-custom-domain: Validates the custom domain mapping to ensure it maps to the correct CDN
                            endpoint in DNS.

$ az cdn endpoint create -h

Command
    az cdn endpoint create: CDN endpoint is the entity within a CDN profile containing configuration
    information such as origin, protocol, content caching and delivery behavior.

Arguments
    --name -n           [Required]
    --origin            [Required]: Endpoint origin specified by the following space delimited 3
                                    tuple: `www.example.com http_port https_port`. The HTTP and
                                    HTTPs ports are optional and will default to 80 and 443
                                    respectively.
    --profile-name      [Required]
    --resource-group -g [Required]: Name of resource group. You can configure the default group
                                    using `az configure --defaults group=<name>`.
    --content-types-to-compress   : List of content types on which compression applies. The value
                                    should be a valid MIME type.
    --enable-compression          : If compression is enabled, content will be served as compressed
                                    if user requests for a compressed version. Content won't be
                                    compressed on CDN when requested content is smaller than 1 byte
                                    or larger than 1 MB.  Allowed values: false, true.
    --location -l                 : Location. You can configure the default location using `az
                                    configure --defaults location=<location>`.
    --no-http                     : Indicates whether HTTP traffic is not allowed on the endpoint.
                                    Default is to allow HTTP traffic.  Allowed values: false, true.
    --no-https                    : Indicates whether HTTPS traffic is not allowed on the endpoint.
                                    Default is to allow HTTPS traffic.  Allowed values: false, true.
    --origin-host-header          : The host header CDN sends along with content requests to origin.
                                    The default value is the host name of the origin.
    --origin-path                 : The path used when CDN sends request to origin.
    --query-string-caching        : Defines the query string caching behavior.  Allowed values:
                                    BypassCaching, IgnoreQueryString, NotSet, UseQueryString.
                                    Default: IgnoreQueryString.
    --tags                        : Space separated tags in 'key[=value]' format. Use '' to clear
                                    existing tags.

Global Arguments
    --debug                       : Increase logging verbosity to show all debug logs.
    --help -h                     : Show this help message and exit.
    --output -o                   : Output format.  Allowed values: json, jsonc, table, tsv.
                                    Default: json.
    --query                       : JMESPath query string. See http://jmespath.org/ for more
                                    information and examples.
    --verbose                     : Increase logging verbosity. Use --debug for full debug logs.

Examples
    Create an endpoint with a custom domain origin
        az cdn endpoint create -g group -n endpoint --profile-name profile \
            --origin www.example.com

    Create an endpoint with a custom domain origin with HTTP and HTTPS ports
        az cdn endpoint create -g group -n endpoint --profile-name profile \
            --origin www.example.com 88 4444

    Create an endpoint with a custom domain with compression and only HTTPS
        az cdn endpoint create -g group -n endpoint --profile-name profile \
            --origin www.example.com --no-http --enable-compression

$ az cdn origin -h

Group
    az cdn origin

Commands:
    list: Lists all of the existing origins within an endpoint.
    show: Gets an existing origin within an endpoint.

$ az cdn custom-domain -h

Group
    az cdn custom-domain

Commands:
    create: Creates a new custom domain within an endpoint.
    delete: Deletes an existing custom domain within an endpoint.
    list  : Lists all of the existing custom domains within an endpoint.
    show  : Gets an exisitng custom domain within an endpoint.

Also, consider adding some unit tests to cover the different cases for the origin tuple.

Also, please show the -h output for the groups and interesting commands (create/update usually)

Codecov Report

Merging #3147 into master will increase coverage by 0.01%.
The diff coverage is 97%.

@@            Coverage Diff             @@
##           master    #3147      +/-   ##
==========================================
+ Coverage   70.97%   70.98%   +0.01%
==========================================
  Files         362      372      +10
  Lines       23910    24108     +198
  Branches     3652     3652
==========================================
+ Hits        16970    17113     +143
- Misses       5856     5908      +52
- Partials     1084     1087       +3

Impacted Files
Coverage Δ

...-cli-cdn/azure/cli/command_modules/cdn/__init__.py
100% <100%> (ø)

...-cli-cdn/azure/cli/command_modules/cdn/commands.py
100% <100%> (ø)

...ommand_modules/azure-cli-cdn/azure/cli/__init__.py
100% <100%> (ø)

...n/azure/cli/command_modules/cdn/_client_factory.py
100% <100%> (ø)

...rc/command_modules/azure-cli-cdn/azure/__init__.py
100% <100%> (ø)

...ure-cli-core/azure/cli/core/commands/parameters.py
72.47% <100%> (+1.04%)
:arrow_up:

...e-cli-cdn/azure/cli/command_modules/cdn/_params.py
100% <100%> (ø)

...zure-cli-cdn/azure/cli/command_modules/__init__.py
100% <100%> (ø)

...ure-cli-cdn/azure/cli/command_modules/cdn/_help.py
100% <100%> (ø)

...re-cli-cdn/azure/cli/command_modules/cdn/custom.py
87.8% <87.8%> (ø)

... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80a9d5...e26026c. Read the comment docs.

@tjprescott I've addressed 2 and 3.
I'm not keen on addressing 1 as it will greatly increase the number of strings used to define the commands. I wrote them in a less repetitive way.
Compare the two below. Side by side, I definitely choose the first.
for c in ['start', 'stop', 'delete']:
    endpoint_command(c)
endpoint_command('list', 'list_by_profile')
endpoint_command('load', 'load_content')
endpoint_command('purge', 'purge_content')
endpoint_command('validate-custom-domain', 'validate_custom_domain')
endpoint_command('create', 'create_endpoint', use_custom=True)
generic_endpoint_command('update', 'update_endpoint')

cli_storage_data_plane_command('storage queue list', queue_path + 'list_queues', factory, transform=transform_storage_list_output)
cli_storage_data_plane_command('storage queue create', queue_path + 'create_queue', factory, transform=create_boolean_result_output_transformer('created'), table_transformer=transform_boolean_for_table)
cli_storage_data_plane_command('storage queue delete', queue_path + 'delete_queue', factory, transform=create_boolean_result_output_transformer('deleted'), table_transformer=transform_boolean_for_table)
cli_storage_data_plane_command('storage queue metadata show', queue_path + 'get_queue_metadata', factory, exception_handler=_dont_fail_not_exist)
cli_storage_data_plane_command('storage queue metadata update', queue_path + 'set_queue_metadata', factory)
cli_storage_data_plane_command('storage queue exists', queue_path + 'exists', factory, transform=create_boolean_result_output_transformer('exists'))
cli_storage_data_plane_command('storage queue policy create', custom_path + 'create_acl_policy', factory)
cli_storage_data_plane_command('storage queue policy delete', custom_path + 'delete_acl_policy', factory)
cli_storage_data_plane_command('storage queue policy show', custom_path + 'get_acl_policy', factory, exception_handler=_dont_fail_not_exist)
cli_storage_data_plane_command('storage queue policy list', custom_path + 'list_acl_policies', factory, table_transformer=transform_acl_list_output)
cli_storage_data_plane_command('storage queue policy update', custom_path + 'set_acl_policy', factory)

@tjprescott ahhh... I saw the light regarding your guidance on refactoring the commands. They are now consistent with existing formats.


Add prerenderTimeout config.

Dependencies: https://github.com/digitalbazaar/bedrock-angular/pull/10

Approved, but should add a comment as seen above.


allow web worker resource to be relative

Description
This PR allows a web worker resource (the .js and _bg.wasm files) to be specified relative to the loading path. Prior to this PR, the resource is specified with an absolute path. In this case - with an absolute path - if the resource is specified at "location.js", the path "/location.js" will be used.
As discussed in #2056, this adds a new method name_of_resource_is_relative to the trait yew_agent::Agent. The default implementation returns false and the current behavior - to specify an absolute path - remains unchanged. What is new here is that if an implementation implements this method and returns true, the location of a web worker script is interpreted as relative to the current path.
Fixes #2056.
Checklist

[x] I have run cargo make pr-flow
[x] I have reviewed my own code

I didn't notice the MSRV of 1.49. I'll fix this.

Hi @astraw, could you please review the suggested changes to make this PR mergeable?

I think this should be good to merge. However, Github shows me "Changes requested" although I thought I have now implemented all requested changes as far as I can see. Probably it is something with the Github PR UI that I do not understand, as I am not very familiar with it. Anyhow, it would be great if you would check this again and merge if you find appropriate.
(Apologies for the delay, the last weeks have been busy.)

Github shows me "Changes requested" although I thought I have now implemented all requested changes as far as I can see.

It doesn't change until the person who made the request for changes approves of those changes :)
Thank you for changes 🎉 LGTM.
@voidpumpkin second pair of eyes please 👀


Add check for migration table in reset command

Proposed here: #8564
This simply checks if the migration table exists when migrate:reset is called. If not it will skip the rest and show a note instead of throwing an error.

:+1:


hidden files not show on network storage with show hidden files enable

Description
hidden files not show on network storage with show hidden files enable
view on explorer

view on Files

Steps To Reproduce
No response
Expected behavior
hidden files not show on network storage with show hidden files enable
Files Version
Version : <IP_ADDRESS> OS Version: 10.0.19044.1415
Windows Version
21H2  19044.1415
Relevant Assets/Logs
debug_fulltrust.log
debug.log

Merging with #2436 (same cause)


Weird Variable Glitch

Hello, when I try to run my code that uses showdown.js, I get these errors:
Uncaught ReferenceError: showdown is not defined
It claims that this code line is wrong: const converter = new showdown.Converter();
Uncaught ReferenceError: getDefaultOpts is not defined
Inside the file "showdown.js" it states this line of code is wrong: globalOptions = getDefaultOpts(true),
I am not using node for my project. I am using static website files.
Please help. Thanks in advance for any assistance.

Can you provide a little bit more context? Maybe create a https://codepen.io/pen/ to reproduce the issue.

Can you provide a little bit more context? Maybe create a https://codepen.io/pen/ to reproduce the issue.

HI, I actually just got busy with another project that is more important so it might be another day or two before I get to creating the codepen. Thanks!


fix: some subview didn't enable yoga, and crash with NaN frame

they haven't merge yet?

they haven't merge yet?


Update sample data evokeds names

It seems the sample data evokeds currently have as names: "Left Auditory", "Right Auditory", "Left visual", "Right visual"
Any chance of changing that to "Left/Auditory", "Right/Auditory", "Left/Visual", "Right/Visual"?

People's scripts likely make use of existing names in this (long time)
publicly available dataset so we probably should not change them

Ok!