Auto corrected by following Lint Ruby Performance/RegexpMatch

Auto corrected by following Lint Ruby Performance/RegexpMatch
Click here to configure it on awesomecode.io

Coverage remained the same at 80.877% when pulling 8683a8cebcc838cd5affcb0ec0e5018f2787be9e on awesomecode-lint-ruby-performance-regexpmatch-48236 into ed40b1d9634eccd994a408834183ce70271b7d5b on master.


Ignore unreachable iOS devices in IOSDevice.getAttachedDevices

Fixes #23341
Related:

https://github.com/libimobiledevice/libimobiledevice/issues/152
https://github.com/libimobiledevice/libusbmuxd/pull/53#issuecomment-425673643

The usbmuxd ("USB multiplexer daemon") daemon manages the list of devices and facilitates communication with them. When Apple added support for WiFi backups and syncing, they did so by extending usbmuxd, so it is very much an intended behavior. I would like to see your proposed patch to usbmuxd_get_device_list as a configuration option, though. It would also be useful if the APIs in libimobiledevice allowed restricting connects to USB so it could selected per-connection.

In practice this means that idevice_id -l also lists udid's that are not actually attached via usb and have no debugging capabilities. When flutter tries to get device meta information using ideviceinfo -u UDID it returns an exit code 255 causing fluttor doctor and other flutter devices related API's to produce errors even though there are other attached devices / simulators that work fine.
This PR basically ignores devices for which ideviceinfo fails to receive meta information but still allow devices that do provide meta information to be included.

I signed it!

This is still not a solution to this problem ?

We should write a test for this. I believe the flutter_tools tests have the technology to mock processes which would help here.

We should write a test for this. I believe the flutter_tools tests have the technology to mock processes which would help here.

Yep.  There's also some tests in https://github.com/flutter/flutter/blob/949cfcf172cce8a714719765b2e79039c5eb8200/packages/flutter_tools/test/ios/devices_test.dart#L32 that make sue of these mocks too.

Thanks! I'll have a look. I'm somewhat new to Dart but it shouldn't be a problem to write some tests for this. I'll also have a look to catch the specific ideviceinfo's No device found with udid error instead of all error.

I added tests and specific exception handling. I chose to add a new IOSDeviceNotFoundError to keep the detection of this specific error closest to the invocation of the ideviceinfo command. Let me know if this is undesired as I could also catch the original ToolExit and put the logic inside getAttachedDevices() without a new Exception type.

LGTM.  Will merge on green.

This PR finally saved me! 🍻


Can't import Bestiary 3 - Awakened Demilich

Can't import statblock:
Awakened Demilich      CR 16
XP 76,800
Male human awakened demilich necromancer 11 (Pathfinder RPG Bestiary 3 67)
NE Tiny undead (augmented humanoid, human)
Init +5; Senses darkvision 60 ft., life sight (10 feet, 11 rounds/day), true seeing; Perception +13
Defense
AC 30, touch 26, flat-footed 25 (+5 Dex, +4 natural, +5 profane, +2 size, +4 untyped bonus)
hp 122 (11d6+66)
Fort +13, Ref +13, Will +17
Defensive Abilities channel resistance +5, rejuvenation, unholy grace; DR 20/—; Immune acid, cold, electricity, magic, polymorph, undead traits
Weaknesses vorpal susceptibility
Offense
Speed fly 30 ft. (perfect)
Space 2½ ft.; Reach 0 ft.
Special Attacks command undead (DC 20, 8/day), devour soul (DC 20), telekinetic storm
Spell-Like Abilities (CL 11th; concentration +16)
Constant—true seeing
At will—greater bestow curse (DC 21), telekinesis (DC 20), wail of the banshee (20-ft.-rad spread centered on self) (DC 24)
Arcane School Spell-Like Abilities (CL 11th; concentration +16)
8/day—grave touch (5 rounds)
Necromancer Spells Prepared (CL 11th; concentration +16)
6th—globe of invulnerability
5th—cloudkill (DC 20), cloudkill (DC 20), cone of cold (DC 20), waves of fatigue
4th—dimension door, enervation, fire shield, wall of ice (DC 19), wall of ice (DC 19)
3rd—dispel magic, dispel magic, fireball (DC 18), suggestion (DC 18), vampiric touch, vampiric touch
2nd—false life, extended mage armor, scorching ray, see invisibility, spectral hand
1st—magic missile, magic missile, magic missile, ray of enfeeblement (DC 16), ray of enfeeblement (DC 16), shield, shield
0 (at will)—bleed (DC 15), detect magic, ray of frost, read magic
Opposition Schools Illusion, Transmutation
Statistics
Str 6, Dex 21, Con —, Int 21, Wis 20, Cha 21
Base Atk +5; CMB +8; CMD 25
Feats Command Undead, Craft Wondrous Item, Eschew Materials, Extend Spell, Scribe Scroll, Still Spell
Skills Fly +17, Intimidate +19, Perception +13, Sense Motive +13, Stealth +21; Racial Modifiers +8 Perception, +8 Sense Motive, +8 Stealth
Languages Abyssal, Abyssal, Aklo, Aklo, Aquan, Auran, Celestial, Common, Draconic, Draconic, Dwarven, Elven, Giant, Giant, Gnome, Goblin, Ignan, Infernal, Infernal, Orc, Terran, Undercommon
SQ arcane bond (object)
Ecology
Environment any
Organization solitary
Special Abilities
Arcane Bond Use object to cast any spell in your spellbook. Without it, Concentration required to cast spells (DC20 + spell level).
Channel Resistance +5 +5 bonus to save vs. Channel Energy.
Command Undead (8/day, DC 20) Stnd act, 1 channel energy, undead in 30 ft. obey your commands as per control undead (Will neg).
Damage Reduction (20/-) You have Damage Reduction against all attacks.
Darkvision (60 feet) You can see in the dark (black and white only).
Devour Soul (DC 20) (Su) Draw soul within 300 ft. into gem, destroy body (Fort part., 2 permanent neg. levels with save). Consume soul to heal 1d6 hp/soul's HD.
Eschew Materials Cast spells without materials, if component cost is 1 gp or less.
Extend Spell Spell duration lasts twice as normal. +1 Level.
Fly (30 feet, Perfect) You can fly!
Grave Touch (5 rounds, 8/day) (Sp) As a standard action, touch shakes living foe 5 rds (frighten 1 rd if already shaken).
Illusion You must spend 2 slots to cast spells from the Illusion school.
Immunity to Ability Drain Immunity to ability drain
Immunity to Acid You are immune to acid damage.
Immunity to Bleed You are immune to bleed.
Immunity to Cold You are immune to cold damage.

Immunity to Disease You are immune to diseases.
Immunity to Electricity You are immune to electricity damage.
Immunity to Energy Drain Immune to energy drain
Immunity to Exhausted You are immune to the exhausted condition.
Immunity to Fatigue You are immune to the fatigued condition.
Immunity to Magic Immune except vs. dispel evil, holy smite, shatter, or power word kill.
Immunity to Mind-Affecting effects You are immune to Mind-Affecting effects.

Immunity to Physical Ability Damage Immune to ability damage to your physical abilities.
Immunity to Poison You are immune to poison.
Immunity to Polymorph You are immune to Polymorph effects.

Immunity to Stunning You are immune to being stunned.
Life Sight (10 feet, 11 rounds/day) (Su) Gain special blindsight which only sees living and undead.
Necromancy The dread and feared necromancer commands undead and uses the foul power of unlife against his enemies.
Rejuvenation (Su) Reform 2d6 days after destruction, unless special ritual is performed.
Still Spell You can cast a spell with no somatic components. +1 Level.
Telekinetic Storm (DC 15) (Su) Obscure vision as fog cloud and deal 12d6 dam in 20 ft radius (Ref half).
Transmutation You must spend 2 slots to cast spells from the Transmutation school.
Undead Traits Undead have many immunities.
Unholy Grace (Su) A demilich gains a bonus on saves and a profane bonus to AC equal to its Charisma modifier.
Vorpal Susceptibility (Ex) Vorpal weapons of any kind ignore a demilich's damage reduction.

Used your latest module that was available as of this afternoon at about 2:30pm.  I used Hero Lab to produce this statblock. For greater accuracy, you might want to use one of the online resources. Hero Lab can truncate some of the text. All the other statblocks from Bestiary 3 imported -- a total of more than 86% imported!


(PUP-4044) Curl repo config directly to SUT

Previously, we copied the puppetlabs-release package from
{yum,apt}.puppetlabs.com, the per-commit repo_config from
builds.puppetlabs.lan or nightlies.puppetlabs.com, and the actual repos
from either PC1, main or devel to the coordinator node, which then
scp'ed the files to each SUT.
This commit modifies the install_repos_on method to curl the
repo_config for the specified SHA to the SUT's system location e.g.
/etc/yum.repos.d. Once installed the repo_config specifies the URL from
which to install the package for the specified SHA, e.g
baseurl=http://builds.puppetlabs.lan/puppet-agent/<SHA>/repos/el/7/PC1/x86_64/

This commit also skips installing the puppetlabs-release package.
In puppet 3.x, the package is required, because it provides dependencies
for puppet, e.g. facter, hiera. In the AIO world, this is no longer
necessary.

Supercedes PR #3845

Tested with redhat-7-x86_64, debian-7-x86_64, ubuntu-1404-x86_64, fedora-21-x86_64.

CLA signed by all contributors.

I've talked this over with @er0ck and @johnduarte, and paired with @justinstoller on this, merging now because I can't stand the 5 minute delay running acceptance tests over the VPN.


Allow a custom timestamp to be set on S3 files

When saving a file in S3 write the timestamp into a custom metadata field so that it can be overridden with a custom timestamp.
This is required for moving G7 documents between buckets but retaining the original upload timestamp.

:+1: Looks good.  Keys from S3 are weird.


Use os.sep for path separators

Supports a fix for #117

A perhaps even more cross-platform alternative would be to use os.path.split() which accounts for not just the correct path separator, but all of them (as Windows does support / too) including erroneous ones.
>>> import os
>>> os.path.split("mypath/")
('mypath', '')
>>> os.path.split("mypath\\")
('mypath', '')
>>> os.path.split(r"mypath\/")
('mypath', '')
>>> os.path.split(r"mypath///")
('mypath', '')
>>> os.path.split("mypath")
('', 'mypath')

Out of curiosity, why is the latter part of,
if osp.isdir(logdir) and logdir[-1]=='/':
there at all?


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1473

Questions ?
Please refer to the Backport tool documentation


Update dependency pdm to v2.17.1

This PR contains the following updates:

Package
Update
Change

pdm (changelog)
minor
==2.16.0 -> ==2.17.1

Release Notes

pdm-project/pdm (pdm)
v2.17.1
Compare Source
Bug Fixes

Raise dep-logic lower bound to 0.4.2 to fix issues with pdm lock after upgrading from older pdm versions (#3033)
Correct the current platform and architecture for win32 and macos systems. (#3035)

Miscellany

Fix zsh completions (#3031)

v2.17.0
Compare Source
Breaking Changes

LockedRepository.all_candidates now returns a dict[str, list[Candidate]] instead of dict[str, Candidate]. (#2995)
post_lock hook now receives a resolution result of type dict[str, list[Candidate]], instead of dict[str, Candidate]. (#2995)

Features & Improvements

Support reading requirement constraints from pip-style requirement files for "overriding" via --override option. (#2896)

Add a --non-interactive option for automation scenarios, also interactive prompts will not show up when not running in an interactive terminal. (#2934)

Refactored pdm python install --list to reuse the same implementation as other cli commands that work with Python interpreters from pbs_installer. (#2977)

Add --license and --project-version as CLI options to control and streamline them during pdm init - especially in automated scenarios with --non-interactive (#2978)

Run pdm sync in "post-rewrite" stage of pre-commit (#2994)

Project.get_dependencies() now returns a list of Requirement instead of a mapping.
The first argument of Project.add_dependencies() now accepts a list of Requirement instead of a mapping.
The old usage will be kept working for a short period of time and will be removed in the future. (#2995)

Support locking for specific target, which is a combination of (python, platform, implementation) triple. Bump lock file version to 4.5.0.
Example usage: pdm lock --platform=linux --python="==3.8.*" --implementation=cpython. See the docs for more details. (#2995)

Rename --reuse-env to --recreate for run command, and reverse the behavior. (#2999)

PDM is now published with optional pinned dependencies using the pdm plugin pdm-build-locked.
To install pdm with its dependencies pinned to the versions it was tested with, run:

    pipx install pdm[locked]

To install optional dependency group copier:

    pipx install pdm[locked,copier-locked]

This feature is entirely optional. Installing pdm without the extra will work the same way as before this change. (#3001)

Added --clean-unselected alias for --only-keep (#3007)

Group options for update strategy and save strategy. (#3016)

Bug Fixes

When locking dependencies that references the self project, the referenced groups should also be recorded in the lockfile. (#2976)
Retry failed installation jobs if they are run sequentially, such as for editable dependencies. (#3005)
Fix the local path issue when -p is passed to change the project root. (#3009)
Fix a bug that PDM can't install editable self package with non-isolated build in one go. (#3018)
Add context when parsing version failed. (#3020)
Fix a mistake in build env setup that will cause the PATH env var length to grow. (#3022)

Removals and Deprecations

Remove the deprecation warning of BaseCommand.__init__() method. Now it doesn't take any arguments. (#2995)
Provider.get_reuse_candidate() method is deprecated in favor of Provider.iter_reuse_candidates(), to return an iterable of reuse candidates. (#2995)
--no-markers option in pdm export command becomes a no-op and is marked as deprecated, because it doesn't make sense anymore. (#2995)
ignore_compatibility parameter of Project.get_provider()/Project.get_repository()/Environment.get_finder() is deprecated. Pass in a EnvSpec via env_spec parameter instead.
requires_python parameter of pdm.resolver.core.resolve() function is deprecated and has no effect.
cross_platform parameter of pdm.cli.actions.resolve_candidates_from_lockfile() function is deprecated and has no effect. (#2995)

v2.16.1
Compare Source
Bug Fixes

Fix new interface from pbs_installer regarding build_dir and best match auto-install strategy for pdm use
(same as for pdm python install --list) (#2943)
Fix crash when pdm is used with importlib-metadata version 8.0. (#2974)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

cf https://github.com/robert-koch-institut/mex-drop/pull/125


[ClangImporter] Hardcode NSString being bridged to String

...so that we don't have to depend on the ObjectiveC module having API notes for a class it doesn't actually define.
Support for rdar://problem/40278479 / apple/swift-clang#199.

@swift-ci Please test

apple/swift-clang#199
@swift-ci Please test source compatibility

Passed normal testing, now what happens if we actually make the Clang change?
apple/swift-clang#199
@swift-ci Please test

Looks like this approach works. Time to cherry-pick it everywhere.


Consider changing Titles to be more friendly

The names of the configuration options don't make that much sense or have little relationship to what the option actually does. They are also in a terrible order & not grouped together by function which makes the options harder to use.
Attached is a version of a custom json schema for use in Jamf Pro with changed titles for options. Thanks.
schema.json.zip

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 40801de8-cfb0-7f2d-ac91-c7b4b3b8c1f4
Version Independent ID: 8d2445aa-5934-16fb-6b29-81d5b4d4c59e
Content: Deploy and configure the new OneDrive sync app for Mac - OneDrive
Content Source: OneDrive/deploy-and-configure-on-macos.md
Service: one-drive
GitHub Login: @adeejoseph
Microsoft Alias: adjoseph

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hello @brockwaltersstarz
how are you? Hope you are doing well
Here, we are limited to documentation changes and improvements.
The feedback you are providing is more suitable for the product group, currently, the uservoice pages for SPO/ODB were deprecated but you can check here for the status of the replacements.
Hope this helps you,


BM25 time complexity

What would be the time complexity of sparse search using BM25?

Honestly, I have no idea.
The current implementation is based on what I found to work most efficiently with numba.


Error finding references on Go package names

Reproducable on sourcegraph.com: https://sourcegraph.com/github.com/kubernetes/apiserver/-/blob/pkg/server/serve.go#L17:9$references

Similar behavior occurs with external references, but the failure occurs on the xdef request, before it even gets to the xref request.
The API response (from the Chrome dev tools network tab) is:
[
    {
        "id": 0,
        "result": {
            "capabilities": {
                "hoverProvider": true,
                "definitionProvider": true,
                "referencesProvider": true,
                "documentSymbolProvider": true,
                "workspaceSymbolProvider": true,
                "implementationProvider": true,
                "xworkspaceReferencesProvider": true,
                "xdefinitionProvider": true,
                "xworkspaceSymbolByProperties": true
            }
        },
        "jsonrpc": "2.0"
    },
    {
        "id": 1,
        "error": {
            "code": 0,
            "message": "references object not found",
            "data": null
        },
        "jsonrpc": "2.0"
    },
    {
        "id": 2,
        "result": null,
        "jsonrpc": "2.0"
    }
]

So the reason this doesn't work is that clicking on a package doesn't resolve to a specific location (so j2d doesn't work either). I don't think our implementation of references could necessarily work with it, but some special casing for package identifiers may make sense.
I'm unsure what you would want though? Imports? Our references code already uses a reverse import graph which would mean it would be easy to find the packages which reference a package.

ok, then I would assume our implementation does work since it is a fork of go guru which vscode-go uses. Maybe go guru doesn't do an initial definition, while we do for some reason.

I got halfway into investigating this, will continue soon (probably next week).
I encountered another issue that also blocks this: https://github.com/sourcegraph/sourcegraph/issues/11189.


Trimming or customizing word lists

While playing, we occasionally see some spectrum cards which are synonyms or gibberish. I've played the physical Wavelength board game 5-10 times but never seen any spectrums like these. Frankly, we just don't have much fun when they show up online.
Tick ... Tock
The dictionary defines these as 'sound made by a clock'. Am I missing something? What's the intended spectrum? What's a good clue that would be, say, 75% Tock? "Tooioooiock"?
Weird ... Strange
These are both synonymous with 'unusual', 'foreign', 'alien'. Is a UFO "weird" or "strange"? Is a haunted house "weird" or "strange"? The dictionary defines weird as "suggesting something supernatural; uncanny" so presumably a haunted house should be on the 'weird' side but I can't imagine anybody would find this spectrum intriguing or fun.
Illegal ... Prohibited, Small ... Tiny, Etiquette ... Manners
More of the same. Is littering "Illegal" or "Prohibited"? Is a thimble "Small" or "Tiny"? Is sitting up straight "Etiquette" or "Manners"? They're all both. Maybe a group could decide collectively, "For this card 'etiquette' is going to mean things that you might do around your friends but not to your boss, but 'manners' is going to mean things that you wouldn't do around anybody at all," and then the cards might be fun. But I feel like any fun discussions for these spectrums would center around how bizarre the card is, and how we can fix the card so that it actually works.
Is it possible to trim the spectrum cards to only include things that are different? Or perhaps to let us paste in a giant .txt or .ts file defining our own spectrum cards, so that we can edit out the ones we don't find fun? In the meantime we've just house ruled to make up our own spectrum if the provided spectrum is nonsensical or provides two synonyms.

All the spectrums in Longwave are ones from the original Wavelength box.
The Wavelength box contains two sets of cards, the "standard" ones and the
"advanced" ones. Some of these advanced ones that you've noticed require
some creative interpretation! Tick ... Tock is a particularly tough one; I
once pulled it and used "Grandfather clock" to indicate somewhere closer to
the "Tock" sound of the spectrum (since it's a bigger clock, you'd think of
it making a deeper sound". A big part of the fun of this game is hoping
your friends interpret the spectrum the same way you do! Some of
the spectrums contain two words that are nearly synonymous, so the
challenge is in figuring out what clue could really demonstrate the nuance
between two nearly-synonymous words. Consider taking another read through
the rule book.
Anyways, if you really hate a card that you've drawn, there's a big button
labelled "Draw a different card".
[image: PXL_20201204_211857979.jpg]
--
Evan Bailey http://www.linkedin.com/in/evangbailey
On Fri, Dec 4, 2020 at 7:44 AM Poobslag<EMAIL_ADDRESS>wrote:

While playing, we occasionally see some spectrum cards which are synonyms
or gibberish. I've played the physical Wavelength board game 5-10 times but
never seen any spectrums like these. Frankly, we just don't have much fun
when they show up online.
Tick ... Tock
The dictionary defines these as 'sound made by a clock'. Am I missing
something? What's the intended spectrum? What's a good clue that would be,
say, 75% Tock? "Tooioooiock"?
Weird ... Strange
These are both synonymous with 'unusual', 'foreign', 'alien'. Is a UFO
"weird" or "strange"? Is a haunted house "weird" or "strange"? The
dictionary defines weird as "suggesting something supernatural; uncanny" so
presumably a haunted house should be on the 'weird' side but I can't
imagine anybody would find this spectrum intriguing or fun.
Illegal ... Prohibited, Small ... Tiny, Etiquette ... Manners
More of the same. Is littering "Illegal" or "Prohibited"? Is a thimble
"Small" or "Tiny"? Is sitting up straight "Etiquette" or "Manners"? They're
all both. Maybe a group could decide collectively, "For this card
'etiquette' is going to mean things that you might do around your friends,
but not to your boss, but 'manners' is going to mean things that you
wouldn't do around everybody," and then the cards might be fun. But I feel
like any fun discussions for these spectrums would center around how
bizarre the card is, and how we can fix the card so that it actually works.
Is it possible to trim the spectrum cards to only include things that are
different? Or perhaps to let us paste in a giant .txt or .ts file
defining our own spectrum cards, so that we can edit out the ones we don't
find fun? In the meantime we've just house ruled to make up our own
spectrum if the provided spectrum is nonsensical or provides two synonyms.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cynicaloptimist/longwave/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYY46N7JK5Z6RWUURNWCCLSTD7UNANCNFSM4UNTKKRA
.

My mistake -- if those are all from the original game then I can't fault you from including them!
The "Draw a different card" option is unavailable in some modes, such as in the cooperative mode. Otherwise yeah, we just drew a different card.
Thanks so much for developing the app!

Right on, good point about disabling it in co-op mode, which was intentional. I might add a toggle to turn the advanced cards on/off but this isn't my main project right now. Thanks!


feat: add multiple doc projects support when generating JsDocs

Description
This PR facilitates JSDoc updates for different SDK versions.
Screenshot

Merging as we have been using to publish v6 docs


Bump guzzlehttp/guzzle from 7.4.4 to 7.4.5

Bumps guzzlehttp/guzzle from 7.4.4 to 7.4.5.

Release notes
Changelog
Commits

Bump guzzlehttp/psr7 from 2.2.1 to 2.4.0
Bumps guzzlehttp/psr7 from 2.2.1 to 2.4.0.

Release notes
Changelog
Commits

updated-dependencies:

dependency-name: guzzlehttp/guzzle
dependency-type: direct:production
dependency-name: guzzlehttp/psr7
dependency-type: direct:production
...

Thanks man!


Added UBlock ad block

Description
I have included the ad block extension where the user could block the Ad in the youtube and other stuffs
Fixes:  #992
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[X] I have taken help from some online resourses
[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@Sulagna-Dutta-Roy  I request you to add the GSSOC Label so that my contribution will be validated.
Thanks in advance


Fix nil casting in proof.Verify

fixes #99
proof.Verify should handle the case of a nil proof, and thus must be a pointer receiver, otherwise sending an empty proof will cause the verifier to panic.

This looks good to me. Thanks for submitting the PR.


Use ObjectiveSharpie to keep P/Invoke in sync with libsass

Haven't looked at this seriously, the idea seems interesting http://tirania.org/blog/archive/2017/Jan-18.html
This would probably depend on #53 landing too

Interesting. Auto bindings works with simple getter/setter properties and methods. LibSass use cases get trickier with custom imports, custom headers and custom functions implementation where we map anonymous and concrete methods to C function pointers via delegates. I wonder how it would handle those?
I suppose, just like node-sass (static compile) and perl-sass (FFI), each feature of C-API needs hand-rolled implementation with .NET P/Invoke (FFI). Besides, we have already implemented most (if not all) of them, only couple of new / tiny features might be missing.


[#517] Issues running RC check against R15 branch - Pipeline Trigger 4.14

Addresses # 517
Description
This PR adds a pipeline trigger to concatenate the execution of the 02.A. Deploy skill bots and 02.B. Run skill test scenarios pipelines in main and releases branches.
Detailed Changes

Updated the runTestScenarios yaml adding configuration for a pipeline trigger.
Updated the default value for the DEPLOYBOTRESOURCESGUID variable to match the current pipeline name.

Testing
These images show the 02.B pipeline successfully triggered after the 02.A finishes its execution, both in main and in one of the releases branches.

Promoted to MS in PR# 540


chore(rootfs): bump platform version to 2.1.0

[Current coverage][cc-pull] is 86.85%

Merging [#841][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.07%

@@             master       #841   diff @@
==========================================
  Files            30         30
  Lines          2723       2723
  Methods           0          0
  Messages          0          0
  Branches        448        448
==========================================
- Hits           2367       2365     -2
- Misses          235        236     +1
- Partials        121        122     +1

Powered by Codecov. Last updated by [cae4bf9...b10b741][cc-compare]
[cc-base-branch]: https://codecov.io/gh/deis/controller/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/deis/controller/compare/cae4bf9ce906ec223ce6bbf760492d0eefed5c05...b10b7413e9e5645caca6f962e9124d6dfaa5037a
[cc-pull]: https://codecov.io/gh/deis/controller/pull/841?src=pr


Content Provider issue

Hi guys, noticed since the 2.4.6 update you cannot have different flavors of the same app installed one device due to conflicting com.reactlibrary.provider settings from your module.
Would be great if you supported applicationIdSuffix or something of the kind to prevent this issue.
To reproduce the issue:

install app with id com.yourapp.dev
try install app with id com.yourapp.prod and it will fail

https://github.com/philipphecht/react-native-doc-viewer/blob/f01534cce207acfc94fe32e3c1f146bd094bb5f3/android/src/main/AndroidManifest.xml#L5
and
https://github.com/philipphecht/react-native-doc-viewer/blob/f01534cce207acfc94fe32e3c1f146bd094bb5f3/android/src/main/AndroidManifest.xml#L5
"com.reactlibrary.provider" <- this should be settable as an option somehow. @philipphecht


v5.3.0 failed to load when updated to the latest version

          This integration stopped working completely, failed to load when I updated to the latest version of the integration today. Don't think it has anything to do with the meross device firmware, I'm on hardware 8.0.0, firmware 8.3.5, but restarting HA throws the following early errors while trying to load the new version during restart:

> 2024-07-10 18:31:07.163 WARNING (SyncWorker_4) [homeassistant.loader] We found a custom integration meross_lan which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
> 2024-07-10 18:31:48.599 ERROR (MainThread) [homeassistant.loader] Unexpected exception importing component custom_components.meross_lan
> File "/config/custom_components/meross_lan/__init__.py", line 24, in <module>
> File "/config/custom_components/meross_lan/helpers/manager.py", line 395
> 2024-07-10 18:31:48.616 ERROR (MainThread) [homeassistant.setup] Setup failed for custom integration meross_lan: Unable to import component: Exception importing custom_components.meross_lan
> File "/config/custom_components/meross_lan/__init__.py", line 24, in <module>
> File "/config/custom_components/meross_lan/helpers/manager.py", line 395
> ImportError: Exception importing custom_components.meross_lan

Home Assistant 2023.10.0, was running integration version Moonlight.2.2 (5.2.2) upgraded to  Moonlight.3 and restarted HA
Probably a different issue from yours though, if your integration loads but then fails on one device type.
Originally posted by @pbrooks29 in https://github.com/krahabb/meross_lan/issues/472#issuecomment-2219929913

@pbrooks29:
yep, totally different issue so I'll open a new one.
I guess you've encountered a problem while downloading the update and your files are 'corrupted'. It happens some times and various users had this kind of 'failed loading' right after an update. I don't know why and where this happens but it's usually fixed by redownloading the component.
Ar at least I hope so ;)

Same problem, return to version 5.2.2.

I guess I've found the issue, likely related to your HA still running on python 3.11 (see #477)
This 'backward compatibility issure' has been fixed a few days ago and the current pre-release (v5.3.1-alpha.1) already has it patched. To enable download of pre-releases in HACS there's an option to enable beta repositories...else it will take a week or so before finally publishing the next 'official' 5.3.1.
Else, in any recent HA release (those with python 3.12) 5.3.0 should work.


Feat: Use source list component to display list of models

Looks like format in model details was missing columns and Max has since updated and fixed.
Verified catalog in sqlmesh, CLL, model search.
Looks good to me.


handshake succeeds on mbedtls server, fails on gnutls client with bad server cert.

Description

Type: Bug
Priority: Minor

Bug
OS
linux, debian buster/sid
mbed TLS build:
$ dpkg -s libmbedtls-dev | grep Version:
Version: 2.16.0-1
Peer device TLS stack and version
GnuTls in in ldapsearch provided by ldap-utils;
Version:
$ dpkg -s ldap-utils | grep Version:
Version: 2.4.47+dfsg-3
$ dpkg -s libgnutls30 | grep Version:
Version: 3.6.6-2
The server is using a self-signed cert that is not trusted by the client. In this case the client is ldapsearch which is configured in /etc/ldap/ldap.conf using TLS_CACERT set to a file that does not include the self-signed cert.
Expected behavior
When the client fails the handshake because of the untrusted server cert, the handshake should fail on the server.
Actual behavior
The handshake fails on the client, but mbedtls_ssl_handshake() returns zero and succeeds on the server. This then results in the server failing the next mbedtls_ssl_read() with a status indicating "SSL - An invalid SSL record was received." when the ldapsearch client sends a followup unencrypted "unbind" ldap message before disconnecting.
On the server side I have the following simple debug output, where "handshake complete" is output when mbedtls_ssl_handshake() returns zero;
...
lightldapd: handshake_cb()
lightldapd: handshake complete
lightldapd: mbedtls_ssl_read: SSL - An invalid SSL record was received
On the client side I see the following debug output;
...
tls_read: want=32, got=32
0000:  74 14 2a a3 4f 05 06 81  d5 e5 0b 9d 2d eb f6 5e   t.*.O.......-..^
0010:  e4 a7 3c 63 47 8b 80 c8  d2 b2 79 53 3a 95 47 a8   ..<cG.....yS:.G.
TLS: peer cert untrusted or revoked (0x442)
TLS: can't connect: (unknown error code).
ldap_err2string
ldap_start_tls: Connect error (-11)
additional info: (unknown error code)
ldap_free_connection 1 1
ldap_send_unbind
ber_flush2: 7 bytes to sd 3
0000:  30 05 02 01 02 42 00                               0....B.
ldap_write: want=7, written=7
0000:  30 05 02 01 02 42 00                               0....B.
ldap_free_connection: actually freed
Steps to reproduce
I can send/share more info as required.
I'm not entirely sure if this is a bug in mbedtls, or more likely a bug in gnutls and/or ldapsearch. It looks to me like ldapsearch is completing the handshake and then deciding the cert is bad without any sort of tls notification to let mbedtls know about it. I'm not sure who to blame, or even if this is normal tls protocol handshake behavior. However I did a bit of a search and couldn't find any other reports of this so I figured it's worth filing a bug here so at least others know about it.

@dbaarda Thank you for your information!
I don't consider this a bug, at least not in Mbed TLS.
Does the client send a fatal alert to the server?
Since the server certificate is not trusted, then the client should fail the handshake. If the server does not know that client terminated connection, how does it know to terminate the tls session?
Could you share full logs of Mbed TLS? (you could start after the certificate message was sent )
However, is it possibkle that after tls session was terminated, the ldap still sends a non tls message to the server? This probably causes the tls server to read an invalid ssl message. The TLS stack should not get ldap message, as it doesn't know how to read them ( unless they are wncrypted \ wrapped with the TLS application data headers )
Maybe I am a bit off here, but if you are using an ldap client, should you use an ldap server? Do you have ldap support on your server?

I'm writing my own LDAP server using mbedtls for the TLS support. See
https://github.com/dbaarda/LightLdapd
I'm using the openldap ldapsearch tool as a client for debugging. The ldapsearch tool uses GnuTLS for its TLS client support.
The client's debugging does seem to indicate that it fails the handshake because it doesn't trust the server's cert. However, it also doesn't seem to show it sending anything to the server after the handshake failure message, and instead seems to assume that the TLS session was terminated and sends a non-tls ldap unbind message to terminate the ldap connection.
On the mbedtls server side the handshake appears to have succeeded, but as soon as the non-tls unbind message is received it sees it as an invalid ssl message.
So yes, it does kind of smell like either a GnuTLS bug in that it fails to indicate to the server that the handshake failed. Or perhaps it's something wrong in how the ldapsearch client uses GnuTLS?
Interestingly other types of invalid cert do correctly fail the handshake on the server side, like miss-matched hostnames or expired certs. So far I've only seen this strange failure mode when the client doesn't trust the self-signed cert.

Oh yeah, I'll see if I can figure out how to get mbedtls to give me full server-side logs... I think I need to add code to set the debug hook.
I've already got what appears to be pretty detailed client-side logs.

@dbaarda Thanks for the information.
The client should send a fatal alert with bad_certificate although I couldn't find it explicitely in the standard.
How would the server know that the handshake failed on the client side otherwise?
The error is because the ldap message sent by the client is accepted first in the TLS stack, before your ldap layer handles it.

FTR, I was sure I saw examples of miss-matched hostnames or expired certs correctly failing the handshake, but I don't seem to be able to reproduce it now.

I think the cases where I saw the handshake fail on the mbedtls server were when the handshake failed early on the gnutls client side because of things like the key signature not matching, leaving the handshake incomplete on the server side. The client then proceeded to assume the handshake failed and sent the unencrypted ldap unbind request, which the mbedtls server couldn't understand and decided the handshake was broken.
In any case it appears that the GnuTLS client, or possibly ldapsearch's way of using GnuTLS, never sends any kind of alert to indicate the handshake has failed.

We believe this issue is resolved, therefore closing.
If you think this was wrongfully closed, please reopen


test pr trigger

test pr trigger flow

ok to test

ok to test

ok to test

retest

retest

retest

ok to test

ok to test

ok to test

retest


Packages on the old site with external package URLs aren't working

Title says it all. It's both a data transfer issues and a code issue. I'm working on a fix.

Fixed in changeset 35dae17c6f61098d7537949015b78ee474fe0501

I don't think you meant to associate with this issue, @pranavkm!?

They work now. Tested by installing elmah.


Revert "Make IoContext checking stricter for streams."

Reverts cloudflare/workerd#367
breaks customer scripts

Went with a different approach


nodePackages binaries fail because of DOS line endings

Describe the bug
When building nodePackages.meshcommander the resulting binary contains ^M in the shebang line. This causes the binary to fail to execute.
$ nix shell nixpkgs#nodePackages.meshcommander
$ meshcommander
/usr/bin/env: ‘node\r’: No such file or directory
/usr/bin/env: use -[v]S to pass options in shebang lines

$ hexdump -C $(which meshcommander)
00000000  23 21 20 2f 75 73 72 2f  62 69 6e 2f 65 6e 76 20  |#! /usr/bin/env |
00000010  6e 6f 64 65 0d 0a 72 65  71 75 69 72 65 28 22 2e  |node..require(".|
                      ^^

The bug was introduced between 22.05 and 22.11:
$ nix run nixpkgs#nodePackages.meshcommander
/usr/bin/env: ‘node\r’: No such file or directory
/usr/bin/env: use -[v]S to pass options in shebang lines

$ nix run nixpkgs/nixos-22.11#nodePackages.meshcommander
/usr/bin/env: ‘node\r’: No such file or directory
/usr/bin/env: use -[v]S to pass options in shebang lines

$ nix run nixpkgs/nixos-22.05#nodePackages.meshcommander
MeshCommander running on http://<IP_ADDRESS>:3000.

Steps To Reproduce

Build pkgs.nodePackages.meshcommander
Execute meshcommander

Expected behavior
The binary runs and doesn't die on a broken shebang.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
$ nix run nixpkgs#nix-info -- -m
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.10, NixOS, 22.11 (Raccoon), 22.11.20230209.49efda9`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.11.1`
 - channels(root): `""`
 - channels(julian): `""`
 - nixpkgs: `not found`

@lilyinstarlight This looks fun 😰

I wonder if this was a regression from me making node2nix manually handle bin stuff instead of letting npm (not) handle it
I can maybe make a quick patch to node2nix's node-env to dos2unix all bin scripts with shebangs in a line right after this one:
https://github.com/svanderburg/node2nix/blob/315e1b85a6761152f57a41ccea5e2570981ec670/nix/node-env.nix#L537

I've opened #216728 with a fix


Problem report: extracted bad aspect results

Please provide the REQUIRED information. Otherwise, It is almost impossible to locate the problem. DO NOT CHANGE THE FORM.
PyABSA Version (Required)
Python Version: 3.10.6
PyABSA Version: 2.0.27
Torch Version: 1.13.1
Transformers Version: 4.26.0

Code To Reproduce (Required)
from pyabsa import AspectTermExtraction as ATEPC

atepc_examples = "  * * * HITS BLUNT * * * What a great time I had discovering a live band and tasty food in this place . Went for momo ’ s , ended with not only momo ’ s but a great variety that was delightful . Great friendly service was appreciated . The Himalayan black salt drink ( maybe needs a little side note to let people what to expect ) . Will be back !"

aspect_extractor = ATEPC.AspectExtractor(
    checkpoint="fast_lcf_atepc_custom_dataset_fusion_apcacc_90.15_apcf1_79.29_atef1_82.32",
    auto_device=True,
    cal_perplexity=True,
)

aspect_extractor.predict(
    text=atepc_examples,
    #save_result=True,
    save_result=False,
    print_result=True,
    pred_sentiment=True,
)

Full Console Output (Required)
Example 0:   * * * HITS BLUNT * * * What a <great:Positive Confidence:0.9958400726318359> time I had discovering a <live:Positive Confidence:0.9953206181526184> band and <tasty:Positive Confidence:0.9955742359161377> food in this place . Went <for:Positive Confidence:0.9764904975891113> momo ’ s , ended with not only momo ’ s but a great variety that was delightful . Great <friendly:Positive Confidence:0.950766921043396> service was appreciated . The Himalayan black <salt:Negative Confidence:0.6763073801994324> drink ( maybe needs a little side note to let people what to expect ) . Will be back !

Describe the bug
The program extracted 6 aspects but seems wrong, looks like it should more likely return the tokens on the right of the current results. Seems a bug.
Current results: great, live, tasty, for, friendly, salt.

Expected behavior
Expected results: time, band, food, momo, service, drink.

It seems the position shifts and causes this problem. However, I have had a tight schedule recently, so before I fix this issue, please try to do it yourself and PR.

I don't think I have the ability to fix this problem, so anyone who can fix this problem is a big thanks.

Is this an instance-level or dataset-level error? @combokang

Instance-level.


B19765 main fe change text auth receipt total

Agility ticket
B19765
Int PR
12625
Summary
In "Review Documents" page in the "Summary", “Authorized Receipt Total” was changed to “Accepted Receipt Totals”.
How to test

Customer:  create a PPM move.
SC: login and approve it.
Customer: Upload PPM documents.  Upload expense receipts.
SC: Review Documents.  Get to the summary screen.  Will see “Accepted Receipt Totals”.

Screenshots

Fails

:no_entry_sign:
Yarn Audit Issues Found:
high - PDF.js vulnerable to arbitrary JavaScript execution upon opening a malicious PDF
Package pdfjs-dist
Patched in >=4.2.67
Dependency of @trussworks/react-file-viewer
Path @trussworks/react-file-viewer > pdfjs-dist
More info https://github.com/advisories/GHSA-wgrm-67xf-hhpq
1 high vulnerabilities and 0 critical vulnerabilities found

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against 23b5327541703efbf277b4bfc292c59ad543761c


Updates README to remove reference to emmet plugin

Sorry about the earlier PR, didn't intend my changes to make it into it. Fixes #89.

👍


Feat: Adds DiscountBadge component

What's the purpose of this pull request?

Creates DiscountBadge component on @faststore/components
Creates DiscountBadge styles on @faststore/ui
Adds DiscountBadge documentation page on Docusaurus

How it works?
A custom Badge  that display product's discounts.
How to test it?
run yarn start in app/docs folder and checks the Icon component or test it using the doc preview link.
Starters Deploy Preview
Feat: Replaces DiscountBadge FSUI #313

closed in favor of https://github.com/vtex/faststore/pull/1546


Simulation Data Storage Refactor

Description
A PR to refactor the cached simulation storage so that workflows and calculation layers will simply create temporary directories filled with all of the data which is to be stored permanently, and it is up to the storage backend how that directory is converted into its final format (e.g. compressed into a database, or simply move the temp directory into a permanent location).
Todos
Notable points that this PR has either accomplished or will accomplish.

[x] Refactor the workflow to collate all data to store into a single directory
[ ] Refactor the base calculation layer await_results method to pass the directory to the storage backend.
[ ] Refactor the storage backend to deal now with directory paths when storing / retrieving simulation data.

Status

[ ] Ready to go

This pull request introduces 4 alerts when merging 17f594b3a8d90c2dcbc55e6c4ef87063213eeb59 into 6329bcee5ed6afe0ce17e8f98319e90688c33637 - view on LGTM.com
new alerts:

4 for Unused import

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 4df0e6532041ec50f6f49cd1fec18a9f0b38179d into 6329bcee5ed6afe0ce17e8f98319e90688c33637 - view on LGTM.com
new alerts:

1 for Suspicious unused loop iteration variable

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 4a5a2951a91451776c27afa5fe955721fb7979b6 into 6329bcee5ed6afe0ce17e8f98319e90688c33637 - view on LGTM.com
new alerts:

1 for Suspicious unused loop iteration variable

Comment posted by LGTM.com


Latest build (2.2) TypeError: list indices must be integers, not str.

Happens running the latest build, i had to rollback to v2.1.4
2017-01-20 17:07:17	list indices must be integers, not str
Traceback (most recent call last):
  File "TndrAssistant.py", line 118, in <module>
    users = [result["user"] for result in api_res["results"]]
TypeError: list indices must be integers, not str
2017-01-20 17:07:18	list indices must be integers, not str
Traceback (most recent call last):
  File "TndrAssistant.py", line 118, in <module>
    users = [result["user"] for result in api_res["results"]]
TypeError: list indices must be integers, not str
2017-01-20 17:07:18	list indices must be integers, not str
Traceback (most recent call last):
  File "TndrAssistant.py", line 118, in <module>
    users = [result["user"] for result in api_res["results"]]
TypeError: list indices must be integers, not str
Traceback (most recent call last):
  File "TndrAssistant.py", line 126, in <module>
    console_logger.debug("# users: %s", len(users))
NameError: name 'users' is not defined

This happens when recs are exhausted, made more clear in last version.


Overflow error with generator range ending at 9_223_372_036_854_775_807

SUMMARY
The following Samizdat program fails with an error:
for (x in (0..9_223_372_036_854_775_807)) {
    note("\(x)")
};

STEPS TO REPRODUCE

Put the code in the previous section in a file called overflow.sam
Run: samex --runtime=tot overflow.sam

EXPECTED RESULT
0
1
2
[...]
9223372036854775804
9223372036854775805
9223372036854775806
9223372036854775807

ACTUAL RESULT
Overflow / error onadd(9223372036854775807, 1).
    at Int.add on<PHONE_NUMBER>854775807
    at meta_ClosedRange.newInclusive on @<user class ClosedRange>
    at anonymous instance of Closure
    at anonymous instance of Closure
    at anonymous instance of Closure
    at meta_If.maybeValue on If
    at runProgram (instance of Closure)
    at runTextFile (instance of Closure)
    at anonymous instance of Closure
    at meta_If.maybeValue on If
    at anonymous instance of Closure
    at meta_If.is on If
    at runFile (instance of Closure)
    at anonymous instance of Closure
    at meta_If.maybeValue on If
    at anonymous instance of Closure
    at meta_If.cases on If
    at anonymous instance of Closure
    at runCommandLine (instance of Closure)

CONTEXT

Version: branch master as of change b9614f74cecd66a5cab3e2c57243d3a104654705
OS: Linux Mint 17
Compiler: gcc (Ubuntu 4.8.2-19ubuntu1) 4.8.2

ADDITIONAL INFORMATION
Ints are meant to be BigInts, so 9_223_372_036_854_775_807 should be valid, no? Even with a limit of 64 bits signed, I would expect that 263 - 1 would still be valid.

Ints are meant to be BigInts, so 9_223_372_036_854_775_807 should be valid, no? Even with a limit of 64 bits signed, I would expect that 263 - 1 would still be valid.

Yes, but… ClosedRange's underlying implementation calculates the size of the range, which in this case is out of the range of a 64-bit signed int. Here's the code in question:
def size = limitInt.sub(firstInt).div(increment).add(1);

where firstInt == 0 and increment == 1 in this case.
The intent is that the "real" runtime will have bigints, in which case this code would work just fine. In the mean time, there are going to be a few edge cases such as this one.
I'm closing this as not-a-bug. It's a known limitation, and already documented as such in the language guide's appendix.
Nonetheless, thanks for continuing to explore Samizdat and filing this issue!

I should add:

EXPECTED RESULT
0
1
2
[...]
9223372036854775804
9223372036854775805
9223372036854775806
9223372036854775807

If the runtime managed to do one iteration per nanosecond, this would still take about 292 years to complete.

Hey, I'm in it for the long haul.

:smile_cat: :truck:

Oh, and I should add that I don't quite get your explanation about the range given that the following program has the same problem:
for (x in (9_223_372_036_854_775_806..9_223_372_036_854_775_807)) {
    note("\(x)")
};

Not 100% sure, but I'll bet that's because when it's generating, it adds 1 at the end just before it would have detected that it hit the end of the range.


[FX-5856] Delete Maybe export from picasso/utils package

FX-5856
Description
Since the Maybe type along with other GQL types has been extracted into a separate package in Topkit, it should not be exported further from picasso/utils. Because Maybe is not used anywhere inside Picasso, this PR only removes the export.
How to test

Temploy
check that there are no references to Maybe type in Picasso.

Development checks

[x] Add changeset according to guidelines (if needed)
[x] Double check if picasso-tailwind-merge requires major update (check its README.md)
~Read CONTRIBUTING.md and Component API principles~
~Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core~
~Annotate all props in component with documentation~
~Create examples for component~
~Ensure that deployed demo has expected results and good examples~
~Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.~
[x] Self reviewed
~Covered with tests (visual tests included)~

Breaking change

~codemod is created and showcased in the changeset~
~test alpha package of Picasso in StaffPortal~

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers


Generate storage info for pallet babe

Fixes part of #8629
Adding storage_info to pallet babe. Adding a few MaxEncodedLen to facilitate this, and converting Vec to WeakBoundedVec and BoundedVec
Polkadot companion paritytech/polkadot#3831
@shawntabrizi @KiChjang @thiolliere

All companion errors should be fixed now, but not sure how to retrigger the checks without committing a dummy commit.

bot merge

bot merge

/tip small

/tip small

@georgesdib if you want to receive a tip, please add to your PR body something like:
polkadot address:

@georgesdib if you want to receive a tip, please add to your PR body something like:
polkadot address:

Added, thank you very much for that!

/tip small


Big changes: number representation, etc

bc.. I'm planning several extensive changes, motivated by a combination of
feature requests, realization of design mistakes, changed focus (today I'm
less interested in emulation of certain aspects of IEEE 754 arithmetic, for
example), changes in available tools (such as the availability of GMPY),
and the need to serve better as a library for SymPy and Sage (I'm by the
way being funded this summer to work on special functions for Sage via mpmath).
Here are my present plans. I'm of course very much interested in comments
and suggestions.
The mpf and mpc types will be removed. Instead there will be a single type
for representing both real and complex floats. In Python-mode, the value
will be represented by a tuple (real, imag) where a Python 0 in place of
either part represents a zero. This will eliminate much of the present
type-checking cruft (and also allow for a correct way to work with strictly
imaginary numbers without adding any additional complexity).
There will also be a type for representing rationals (both real and complex).
There will be a separate type for representing infinities and NaN.
The mpf value representation will be changed to just (man, exp) where man
can be signed; this should improve performance by reducing the amount of
data being shuffled around, given the new bit_length method in Python 2.7
(and 3.1) that will make recalculation of bc much less of a bottleneck in
Python mode. Avoiding redundant checks for inf/nan will also improve
performance.
The mpf_ and mpc_ layers will be slimmed down and used much less in favor
of more high-level code. This leads to a roughly 20-50% slowdown in
pure-Python mode in some places. However, this slowdown will be offset by
doing some things in C. The new floating-point type will easily be able to
optionally inherit from a C-defined base class (probably via GMPY, as Mario
has already done work on) that defines addition and multiplication and
other speed-critical methods.
SymPy should be able to implement a fast type for real and complex numbers
by inheriting directly from the floating-point type and overriding
appropriate fallback methods.
Special functions will use a combination of 1) high-level code, written so
as to support any number type (provided that a compatibility interface is
implemented -- in particular, such an interface will be implemented for
Python floats and complexes), and 2) low-level code for evaluating
generalized power series and the like.
Series evaluation will be implemented using a simple subset of Python that
can be compiled to Python. The compiler can just return generic code
(suitable for use with e.g. float/complex), or automatically create
fixed-point code (including replacing operations on a single complex
variable by fixed-point operations on two real variables).
I'm now fairly confident about this approach: with the current version of
the compiler (on my hard drive) I am essentially able to generate all the
200 lines of code in _jacobi_theta_2 from a 50-line specification, and in
addition the same specification can generate fast code that evaluates
jtheta(2,z,q) for float/complex z,q.
The series compiler should also be able to insert code that checks for
cancellation and slow convergence (this is very important for
hypergeometric functions), without the need to write a lot of boilerplate
manually for each series. An intriguing possibility for the future is to go
a step further and compile series code directly to a sequence of GMP/MPIR
mpz_ operations.
Some particularly speed-critical special functions (e.g. exp, log, atan,
cos, sin) will of course retain implementations in entirely hand-written
low-level code for performance reasons.
Finally, I want to get rid of global state (mp.dps) to make mpmath easier
to use as a library and to avoid potential parallelization issues. On the
other hand, I still don't want numbers to store a prec attribute. A
possibility is to give floating-point numbers an attribute pointing to a
Context object that in turn defines precision. Then there can still be a
default global Context, but it also becomes easy to create local contexts.
Another possibility, which really is quite similar in practice, is to use
multiple classes or instances of the number type itself for varying
precisions (like Sage's variable-precision rings).
p. Original issue for "#178":https://github.com/fredrik-johansson/mpmath/issues/178: "http://code.google.com/p/mpmath/issues/detail?id=138":http://code.google.com/p/mpmath/issues/detail?id=138
p. Original author: "https://code.google.com/u/111502149103757882156/":https://code.google.com/u/111502149103757882156/
p. Original owner: "https://code.google.com/u/111502149103757882156/":https://code.google.com/u/111502149103757882156/

@fredrik-johansson is there any reason to keep this issue open?
Many of the ideas suggested above seem to have been implemented e.g. making functions be methods of contexts and making a bunch of mixin classes for the contexts, dynamically created classes etc.
Merging mpf and mpc and making use of bit_length did not happen and there is a lot of discussion above of various operations becoming a bit faster from such changes.
There is also discussion about implementing things in C or code generation for series etc. I imagine that this along with the considerations of micro-optimisations in mpmath's Python code are probably superseded by Flint/Arb (or MegaFlint) by now.
If I was to approach some of the ideas above at this stage then I think my perspective would be a bit different from the discussion above:

I would forget about micro-optimising the Python code. If there are simple overheads that can be eliminated through basic benchmarking and simplification then great but the codebase should not be over-complicated for micro-optimisation.
Otherwise if things need to be faster because of the overheads then just write the code in C and make a Cython wrapper (i.e. python_flint).
It is most important for the Python code to present a clean interface and for it to be easy to understand and maintain as well as easy to use.
It is of course important to consider exactly what the base representation of numbers should be because of the implications it has on accuracy, usecases etc (rather than interpreter overhead).

Yeah this is not really relevant anymore.


Make sure the repo url contains the correct arch

We can end up with an arm only repo unless we are specific about the
architecture we require. Brings the deb code in line with the rpm
equivalent.
Signed-off-by: Brad Hubbard<EMAIL_ADDRESS>

An example, arm repo listed first so gets consumed.
https://shaman.ceph.com/api/repos/ceph/octopus/23148618fcb587daa6bac0ac170c39ee83f3175d/ubuntu/bionic/

@guits I think that one need to be backported into stable branches

backports need to be created manually i think

backports need to be created manually i think

I've had a go at doing this since we definitely need this in stable-4.0 for nautilus. Let me know if they need work as I'm not familiar with the process for ca.


Added 'Clarity' as a core principle

Added 'Clarity' as a core principle
Removed all references to 'three core principles' and replaced with 'core principles'

LGTM


[Release][Python] Verify python 3.8 macOS arm64 wheel [WIP]

@github-actions crossbow submit --param release=5.0.0 --param rc=1 verify-rc-wheels-macos-*


Pattern:  Content block - with cards:  include an optional CTA

This epic will contain a description of the overall scope, development instructions and links to all of the issues required to complete the work.
Additional Information

This work is currently scheduled as 'post MVP', but the development can begin as soon as the designs are available.
Target end dates:

Functional specs -
Development -
Prod QA -

Acceptance criteria

[ ] Functional specs are documented.  Summary and links are posted to this epic
[ ] Designs and functional specs are reviewed with the DDS developers for sizing and issue refinement
[ ] Additional stories are created, if needed, for any work to be done in future sprints.

Updated functional specs with optional CTA.
https://ibm.ent.box.com/file/681042575001


suspend keyword in DAO class cause compiler errors

During my first app build, several complier errors were displayed.
-> Solution was: removing the "suspend" keyword before the insert and deleteAll method.
Maybe this is not the best practice and maybe there will be a better solution, but I think it's good enough for beginners like me.

I had the same problem. Removing 'suspend' the app worked!


feat: create claimDelegationRewardsPopup

Summary

Closes #8196

...
Changelog
- Please write a list of changes

Testing
Platforms

Please select any platforms where your changes have been tested.

Desktop

[ ] MacOS
[ ] Linux
[ ] Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...
Checklist

Please tick the following boxes that are relevant to your changes.

[ ] I have followed the contribution guidelines for this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or modified tests that prove my changes work as intended
[ ] I have verified that new and existing unit tests pass locally with my changes
[ ] I have verified that my latest changes pass CI workflows for testing and linting
[ ] I have made corresponding changes to the documentation

looks good but can't be tested well. Let's see if tomorrow there is more luck and we can create and claim delegation outputs 🤞🏼

it can be tested now :pray:


assesibility improvement

Project needed better organisation of code so I created 2 separate files for styles and logic.

[ ]

Remember to keep ur code clean


Create quote block

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #27
Test URLs:

Original: https://www.esri.com/en-us/capabilities/imagery-remote-sensing/capabilities/management
Before: https://main--esri--aemsites.hlx.live/drafts/vciocoiu/quote
After: https://add-quote-block--esri--aemsites.hlx.live/drafts/vciocoiu/quote

I observe some differences in the fonts in mobile, some might be font weights, but there might be also font aliasing differences pottentially.
Original:

New:

There were some minor differences in margins in desktop, so you might want to give that a quick review, but nothing major, so if you see it getting complex we can polish down the line based on customer feedback.

I observe some differences in the fonts in mobile, some might be font weights, but there might be also font aliasing differences pottentially.

I know fonts look a bit different, but I made sure weights / families / sizes are the same. No idea why they are like that.


滑动时出现EasyRefreshPhysics.applyBoundaryConditions returned invalid overscroll value.

使用嵌套

extended.NestedScrollView

tabbar

tabbarview

easyrefresh

SliverStaggeredGrid

滑动列表的时候会出现问题
════════ Exception caught by animation library ═════════════════════════════════════════════════════
The following assertion was thrown while notifying listeners for AnimationController:
EasyRefreshPhysics.applyBoundaryConditions returned invalid overscroll value.
The method was called to consider a change from<PHONE_NUMBER>059727 to<PHONE_NUMBER>747206, which is a delta of -2.3 units. However, it returned an overscroll of 26.7 units, which has a greater magnitude than the delta. The applyBoundaryConditions method is only supposed to reduce the possible range of movement, not increase it.
The scroll extents are 0.0 ..<PHONE_NUMBER>059727, and the viewport dimension is<PHONE_NUMBER>940273.
When the exception was thrown, this was the stack:
#0      ScrollPosition.applyBoundaryConditions. (package:flutter/src/widgets/scroll_position.dart:477:9)
#1      ScrollPosition.applyBoundaryConditions (package:flutter/src/widgets/scroll_position.dart:489:6)
#2      ScrollPosition.setPixels (package:flutter/src/widgets/scroll_position.dart:259:33)
#3      BallisticScrollActivity.applyMoveTo (package:flutter/src/widgets/scroll_activity.dart:552:21)
#4      BallisticScrollActivity._tick (package:flutter/src/widgets/scroll_activity.dart:539:10)
...
The AnimationController notifying listeners was: AnimationController#94c27(▶ 655.789; for BallisticScrollActivity)

v3已发布，也许问题得到解决。如果问题依然存在，请重新打开


Can't clone the project?

Hey guys! I am a newbie in Spring and I am looking for experience in using this framework. When I tried cloning this project however, I get this error from GitBash: Please make sure you have the correct access rights and the repository exists. Can someone help me out please?

I don't really know how to help here, the error message doesn't give enough information.
Did you try with the wiki instructions?

What are you using for clone it https or ssh? Try to use HTTPS instead SSH while taking clone from GIT

I don't really know how to help here, the error message doesn't give enough information.
Did you try with the wiki instructions?

Hey, I did read the instructions. As a matter of fact, that is how I ended up with the error. I simply forked the project and I was able to clone that instead.


Updated supported server versions

Ref: https://github.com/owncloud/owncloud.org/issues/1116
No idea about the desktop client.

:+1:
cc @guruz for desktop clients, please adjust in a separate PR


Difference in note/melody behaviour between DAL and CODAL

In DAL notes of the same pitch and length had some definition or slight pause between the notes played, so you could distinguish by ear that the same pitch was being played twice. In CODAL this is no longer the case.
Using a pre-built melody such as Ode To Joy demonstrates this.

Flash this program from https://makecode.microbit.org/#editor
Flash this program from https://makecode.microbit.org/v2/#editor

You will hear the audible difference.
This also reproduces in MicroPython 2.0.0-beta.1 vs MicroPython 1.0.1

Samples: old makecode (v1 only), current makecode, current python... ode_hex.zip
In current MakeCode, V1 sounds much like V2 to me - the separation between notes is missing compared to a hex compiled with the older makecode version. V1 maybe has a slight something between some notes, but it sounds more like a glitch than the previous pause.
In current MicroPython (tested with beta), there is a pause between notes, but it sounds exaggerated between same-pitch notes.
The MakeCode function analogPitch(int frequency, int ms) used to have a wait_ms(5), then fiber_sleep(5).
The pause was commented out last November:
https://github.com/microsoft/pxt-microbit/blob/d80514bda223f729d452c1e51047f3272a2317fb/libs/core/pins.cpp#L384
in this commit:
https://github.com/microsoft/pxt-microbit/commit/249873ed474aef27f489fff7897297c8e5906806
That commit mentions "joe" (@finneyj ?), and the code comment says "causes issues with v2 DMA"

The issue here is that v1 had an "instantaneous" audio implementation. It could only do raw, unmodulated square wave outputs. So if you stopped playing, paused the CPU and started playing, that pause would defined the "quiet" time between notes.
v2 however, is a buffered, DMA based PCM approach (much more like the soundcard on a PC). Slowing the CPU here only controls the gap between buffers being queued. Which can have a much worse effect on playout quality.
This could be addressed simply enough by actively injecting silence into the audio stream. However, we are hampered by the constraint that the purpose of this API is to be backward compatible with v1. So the currently behaviour was chosen as the best that was achievable under those constraints.

The fiber_sleep(5) pauses become possible with "CONFIG_SOUND_OUTPUT_PIN_PERIOD": 5 in codal.json. Also a passable sonic screwdriver, as in https://github.com/microbit-foundation/micropython-microbit-v2/issues/67. I guess this isn't a good idea for the default.
Press A or B to try: test-melody.zip

I added a global count of the number of buffers and bytes returned by SoundEmojiSynthesizer::pull().
10 x 300ms notes and 5ms pauses typically take 3080-3093ms for 533-535 buffers containing<PHONE_NUMBER>20 bytes.
Here are the values I recorded:
5ms
3082 533 272896
3089 534 273408
3082 534 273408
3089 534 273408
3089 535 273920
3093 535 273920
3089 534 273408
avg 3,087.6

50ms
3082 533 272896
3086 534 273408
3093 535 273920
3093 535 273920
3090 535 273920

reset
3081 533 272896
3092 534 273408
3088 534 273408
3088 534 273408
3085 534 273408
3089 535 273920
3088 534 273408
avg 3,087.3

reset
3080 533 272896
3092 535 273920
3092 535 273920
3089 535 273920

@finneyj is there any downside to setting CONFIG_SOUND_OUTPUT_PIN_PERIOD to 5 (ms)?  Will this affect sound emoji output/rendering?

Hi @dpgeorge
It wouldn't affect any sound emoji behaviour I don't think. Sound emojis are synthesized through a different API to this.
I don't think there would be any implications from doing that, apart from the fact that 5ms is very short period for a note... so could cause a bit more CPU churn, but probably not a huge amount more.
Generally though, approaches to injecting silence based on delaying the CPU will always be inaccurate when we're using DMA. I guess the question is whether increasing the update frequency here by a factor of ten makes it "good enough" to warrant the additional CPU overhead?

It wouldn't affect any sound emoji behaviour I don't think. Sound emojis are synthesized through a different API to this

Great!

I don't think there would be any implications from doing that, apart from the fact that 5ms is very short period for a note... so could cause a bit more CPU churn, but probably not a huge amount more.

It's not the length of the note but rather the granularity/quanta of lengths of notes and lengths of gaps.
I think 50ms is too long compared to what human ears notice.  In MicroPython's music module there is a 10ms break between notes, and it's noticeable if this is increased to a 50ms break.

Generally though, approaches to injecting silence based on delaying the CPU will always be inaccurate when we're using DMA. I guess the question is whether increasing the update frequency here by a factor of ten makes it "good enough" to warrant the additional CPU overhead?

It's not really injecting silence, it's playing a note for a given period of time.  And when the note is turned off it's quite unexpected that it should take between 0ms and 50ms to actually turn off.  Even if silence was injected into the DMA stream to make it accurate, durations are still quantised to 50ms.
Consider the following example:
int main() {
    uBit.audio.virtualOutputPin.setAnalogPeriodUs(2000);
    for (int i = 0; i < 20; ++i) {
        uBit.audio.virtualOutputPin.setAnalogValue(128);
        uBit.sleep(40);
        uBit.audio.virtualOutputPin.setAnalogValue(0);
        uBit.sleep(40);
    }
}

This definitely does not make 20 even spaced beeps!  Each beep and each gap goes for 0, 50 or 100ms.
I guess the alternative to the above is to generate a full waveform with 20 beeps and feed that waveform into the mixer.  But that's pretty expensive in RAM usage or difficult to implement.  It's also not possible to take this approach if the user wants to make some fancy sound effect by turning on/off the virtualOutputPin quickly (eg the sonic screw driver example).
Setting CONFIG_SOUND_OUTPUT_PIN_PERIOD to 5 does solve most of these problems and I think is definitely worth the increased CPU consumption.

Hi @dpgeorge
Yes - exactly right. I'm in total agreement. Apologies - what I was trying to say above is precisely what you describe here - that we're controlling time quantisation. Hence, we it can never be "perfect". All we can do through this API is an approximation...
If 5ms gives us a sufficiently improved resolution that it enable more use cases/better backward compatibility, I agree it is worth the additional COU cost.

Applied in https://github.com/lancaster-university/codal-microbit-v2/commit/6e880bc3d10df1a585bb9046ee4ab02bdcab1f34

Great, thank you!

@JohnVidler could you give this a quick test before we close it? Thanks!

Tested on a v2, and it works :) Closing.


No-Cors Error on ItemLookup

After calling client.execute('ItemLookup', ...) with all the credentials and options, there is a successfull status 200 request (from console network) but for some reason it prints Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://<IP_ADDRESS>:8888' is therefore not allowed access. The response had HTTP status code 403. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
What is the best way around this? @dmcquay
Best,
David

It sounds like you are trying to call this from the browser. You should not do that.


Read-only mode

Requires https://github.com/inveniosoftware/invenio-records-permissions/pull/86

https://github.com/inveniosoftware/invenio-users-resources/pull/57

closed, because of not more necessary


Emphasize auto-generated pages

Tell the reader when they're viewing an autogenerated page, in case they want to report an issue - it should help make reports about autogenerated content stand out.
Example

From a content perspective, binding LGTM. But probably needs a second more experienced with the website perspective?

/lgtm
/approve


Fix: Avatar uploading failed

GetAccount API has been rewritten, so avatar uploading crashed. Fixed this bug.

Thanks for the quick fix!

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


I18n.l('time.formats.short', undefined) behavior (raise an error)

I18n.l('time.formats.short', undefined) raise and error
on the other hands
I18n.l('time.formats.short', '') returns 'Invalid Date'
I check it for version 3.2.0
As for me it's good to have same or similar behavior for unknown data.
real world example:
I'm trying to render view for rail model and it does not have create_at and updated_at field.
view crashing for
I18n.l('time.formats.short', createdAt)
I can prepare patch if it's acceptable.
Possible scenario: undefined can return 'Incorrect Date' or empty string or maybe current date

I guess the error is due to this line
https://github.com/fnando/i18n-js/blob/master/app/assets/javascripts/i18n.js#L923
PR is welcome
I think the line should be something like
// `date` can be any value, null, undefined, non Date objects
// We check `typeof getTime` to ensure no error
if (date == null || (! (typeof date.getTime === "function")) || isNaN(date.getTime())) {

If you are talking about other function please let me know (I don't know the JS part well enough

@PikachuEXE Looks like you propose more detailed check to raise an error.
I want to achieve opposite thing and avoid error for undefined and maybe null value
undefined and null can be returned as is. what do you think?

something like that
it("don't localizes empty values", function(){
   I18n.locale = "pt-BR";
   expect(I18n.l("date.formats.default", "")).toEqual("Invalid Date");
   expect(I18n.l("date.formats.default", undefined)).toEqual(undefined);
   expect(I18n.l("date.formats.default", null)).toEqual(null);
});

^ specs example

I think we should

Return "Invalid Date" for all invalid values
Add option to return input value as is for invalid values

it("don't localizes empty values", function(){
   I18n.locale = "pt-BR";
   expect(I18n.l("date.formats.default", "")).toEqual("Invalid Date");
   expect(I18n.l("date.formats.default", undefined)).toEqual("Invalid Date");
   expect(I18n.l("date.formats.default", null)).toEqual("Invalid Date");

   // Option name and value to be decided later
   expect(I18n.l("date.formats.default", "", on_invalid_datetime: "return_input")).toEqual("");
   expect(I18n.l("date.formats.default", undefined, on_invalid_datetime: "return_input")).toEqual(undefined);
   expect(I18n.l("date.formats.default", null, on_invalid_datetime: "return_input")).toEqual(null);
});

Invalid Date belongs to vanila js and result of operation like
(new Date('')).toString()
"Invalid Date"

Simulating this behavior questionable to me.
as a result on_invalid_datetime: for this scenario
looks like simulate Invalid Date or return as is
'Invalid Date' vs undefined
'Invalid Date' vs null
looks like almost identical
additional flag just increase complexity and it's hard to imagine real use case for 'Invalid Date' vs null
I'm trying to convince you that same value for special values much simpler and should not brake anything.
currently we just have silly error like toString can't be called

Just fixed in https://github.com/fnando/i18n-js/commit/869d1689ed788ff50121de492db354652971c23d
See whether that's what you want

@PikachuEXE Yep. Looks similar to my changes on local machine.

Thank you

Released as 3.2.2
Please close this if it's fixed :)


[Info] I've Added Your Work to the Arch User Repository

Hey there, I like your work and I found it while searching for a replacement for obs-cli. I've added it to the AUR and it can be found here:
https://aur.archlinux.org/packages/obs-cmd
I'll watch here for major version updates and update the AUR accordingly. Thanks for your efforts!

As a Archlinux user I appreciate :+1:
If you want, you add a PR in the readme on how to install it in Archlinux, I installed it with yay -Sy obs-cmd and it works fine

https://github.com/grigio/obs-cmd/pull/13/commits


How to recalculate the height?

I set an option autoHeight: true in settings. The swiper sets his height to the height of the first slide and does not update while swiping.
On original swiper we have a method mySwiper.updateAutoHeight(speed); but I don't see how to run it. Neither swiper directive nor anything else has this method.
My ts code is
import {ChangeDetectionStrategy, Component, Input, OnInit, TemplateRef, ViewChild, ViewChildren} from '@angular/core';
import {SwiperConfigInterface, SwiperComponent, SwiperDirective} from 'ngx-swiper-wrapper';

@Component({
  selector: 'app-slider',
  templateUrl: './slider.component.html',
  styleUrls: ['./slider.component.scss'],
  changeDetection: ChangeDetectionStrategy.OnPush
})
export class SliderComponent<T> implements OnInit {
  @Input() public template: Array<TemplateRef<T>>;
  @Input() public slides: Array<T>;
  @ViewChild('swiper') public swiper: SwiperComponent;

  public swiperDirective: SwiperDirective;
  public index: number = 0;
  public config: SwiperConfigInterface = {
    slidesPerView: 'auto',
    direction: 'horizontal',
    spaceBetween: 1,
    autoHeight: true
  };

  constructor() {
  }

  public slideNext() {
    this.swiperDirective.nextSlide();
  }

  public slidePrev() {
    this.swiperDirective.prevSlide();
  }

  ngOnInit() {
    this.swiperDirective = this.swiper.directiveRef;
  }

  onIndexChange(e) {
    // here I tried to modify DOM directly but without any success

    // const height = this.swiper.swiperSlides.nativeElement.children[e].getBoundingClientRect().height;
    // this.swiper.swiperSlides.nativeElement.parentElement.style.height = height + 'px';
    // console.log(height);
    // this.swiperDirective['updateAutoHeight']();
  }
}

My template is

      {{index + 1}}
      /
      {{slides.length}}

  <swiper [config]="config" [(index)]="index" (indexChange)="onIndexChange($event)" #swiper>
    <ng-container *ngFor="let slide of slides">
      <ng-container *ngTemplateOutlet="template; context: {slide: slide}"></ng-container>
    </ng-container>
  </swiper>

repro on v 6xx and 7.1.1

You do everything just like with the normal Swiper. You can get the Swiper instance through the directive reference (see the readme for api to get the swiper instance). From that Swiper instance reference you can call all the Swiper functions.

You do everything just like with the normal Swiper. You can get the Swiper instance through the directive reference (see the readme for api to get the swiper instance). From that Swiper instance reference you can call all the Swiper functions.

Does this code is setting swiper directive?
ngOnInit() {
    this.swiperDirective = this.swiper.directiveRef;
  }

...

<swiper [config]="config" [(index)]="index" (indexChange)="onIndexChange($event)" #swiper>

If yes then I suggest this line should do the business
// this.swiperDirective['updateAutoHeight']();

But it doesn't. There is no updateAutoHeight method in directive

Yes that gets you the directive reference, but as I said you need to get the Swiper instance reference through the directive reference by calling swiper().

Great! It kinda works from your side. Now I am going to ask the producer of original swiper why it doesn't work as expected. Thank you anyway.

I have same issue.
Did you find solution?

Was a long time ago, don't remember exactly.
If I remember correctly, than no, I just redesigned the app


include a common interface to read/write from/to ADK

Create an IMessage interface for the AdkMessage class that exposes:

getString()
getFloat()
getByte()
getBytes()
getInt()
...

In this way a developer can simply use mAdkManager.read().getInt() to read an Int value from the ADK.
Pros:

better abstraction
avoid developers to parse returned value

Cons:

lesser control and flexibility for returned result

It's just a first draft and may be improved according to common usages. Let me know if anyone needs something better.


Enable e2e test against universal operator

Fix some test failures for new operator
Update test workflow for universal training operators.
Change RunPolicy crd validation to Optional
Clean up manifests

/cc @kubeflow/wg-training-leads
Please help review this change. This PR makes sure new operator pass e2e tests.  It's not far from alpha RC release of universal operators.

/approve


[Bug]: Changing the field a changing sequence depends on crashes the app.

Apache Hop version?
2.8-GA
Java version?
11
Operating system
Windows
What happened?
I expected when there is not perfect alignment to what field should be used to receive an error and not crash the application.
You can reproduce this error by configuring your pipeline to use a "Changing Sequence" transform and designate an existing column to change the output sequence based upon changes to that field.
Then change that field to something that does not exist in the stream and click run.  Hop will hang indefinitely.  It just should throw an error, stop the transform and let the user continue working.
ms.fieldschangesequence.FieldsChangeSequenceField@ab5f359] in the input stream!
org.apache.hop.core.exception.HopException:
Can not find field [org.apache.hop.pipeline.transforms.fieldschangesequence.FieldsChangeSequenceField@ab5f359] in the input stream!
    at org.apache.hop.pipeline.transforms.fieldschangesequence.FieldsChangeSequence.processRow(FieldsChangeSequence.java:75)
    at org.apache.hop.pipeline.transform.RunThread.run(RunThread.java:55)
    at java.base/java.lang.Thread.run(Thread.java:840)

2024/04/16 11:54:02 - Add value fields changing sequence.0 - ERROR: Unexpected error
2024/04/16 11:54:02 - Add value fields changing sequence.0 - ERROR: org.apache.hop.core.exception.HopException:
2024/04/16 11:54:02 - Add value fields changing sequence.0 - Can not find field [org.apache.hop.pipeline.transforms.fieldschangesequence.FieldsChangeSequenceField@ab5f359] in the input stream!
2024/04/16 11:54:02 - Add value fields changing sequence.0 -
2024/04/16 11:54:02 - Add value fields changing sequence.0 -    at org.apache.hop.pipeline.transforms.fieldschangesequence.FieldsChangeSequence.processRow(FieldsChangeSequence.java:75)
2024/04/16 11:54:02 - Add value fields changing sequence.0 -    at org.apache.hop.pipeline.transform.RunThread.run(RunThread.java:55)
Issue Priority
Priority: 2
Issue Component
Component: Hop Gui

I wholeheartedly support this.
Probably related to ticket 3655

tried to reproduce this on Linux and Mac, but Hop Gui keeps working correctly after the error. I'll see if I can test this on Windows one of these days too.

Works on Windows too, but the error message should be improved with the field name:
AS IS: Can not find field [org.apache.hop.pipeline.transforms.fieldschangesequence.FieldsChangeSequenceField@337aaa] in the input stream!
TO BE: Can not find field 'fieldname' in the input stream!


Offset jumps are no longer working correctly

Fix the offset jumps.  This will also facilitate scrolling to the items found during a search.

This has been fixed.


fix: change pouch version to 0.2.0

Signed-off-by: Zhanchun Zhang<EMAIL_ADDRESS>Ⅰ. Describe what this PR did
change pouch version to 0.2.0
Ⅱ. Does this pull request fix one issue?
fixes #789
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

LGTM, potential issue will be fixed later.


Failed to cache the new benchmark returns

Dear Zipline Maintainers,
Before I tell you about my issue, let me describe my environment:
Environment

Operating System: macOS Sierra 10.12.4
Python Version: 3.5.1
Python Bitness: 64
How did you install Zipline: Other - using Pycharm Interpreter to virtualenv
Python packages:
alembic==0.9.3
appnope==0.1.0
bcolz==0.12.1
Bottleneck==1.2.1
cachetools==1.1.6
certifi==2017.4.17
chardet==3.0.4
click==6.7
contextlib2==0.5.5
cycler==0.10.0
cyordereddict==1.0.0
Cython==0.25.2
decorator==4.0.11
empyrical==0.3.0
entrypoints==0.2.2
idna==2.5
intervaltree==2.1.0
ipykernel==4.5.0
ipython==5.1.0
ipython-genutils==0.1.0
ipywidgets==5.2.2
Jinja2==2.8
jsonschema==2.5.1
jupyter==1.0.0
jupyter-client==4.4.0
jupyter-console==5.0.0
jupyter-core==4.2.0
Logbook==1.1.0
lru-dict==1.1.6
Mako==1.0.7
MarkupSafe==1.0
matplotlib==2.0.2
mistune==0.7.3
multipledispatch==0.4.9
multitasking==0.0.4
nbconvert==4.2.0
nbformat==4.1.0
networkx==1.11
notebook==4.2.3
numexpr==2.6.2
numpy==1.13.1
pandas==0.18.1
pandas-datareader==0.4.0
patsy==0.4.1
pexpect==4.2.1
pickleshare==0.7.4
prompt-toolkit==1.0.7
ptyprocess==0.5.1
Pygments==2.1.3
pyparsing==2.2.0
python-dateutil==2.6.1
python-editor==1.0.3
pytz==2017.2
pyzmq==15.4.0
qtconsole==4.2.1
requests==2.18.1
requests-file==1.4.2
requests-ftp==0.3.1
scipy==0.19.1
simplegeneric==0.8.1
six==1.10.0
sortedcontainers==1.5.7
SQLAlchemy==1.1.11
statsmodels==0.8.0
tables==3.4.2
terminado==0.6
toolz==0.8.2
tornado==4.4.1
traitlets==4.3.0
urllib3==1.21.1
wcwidth==0.1.7
widgetsnbextension==1.2.6
zipline==1.1.1

Now that you know a little about me, let me tell you about the issue I am
having:
When I try to execute the example script it's generating an error

What did you expect to happen?
something like this:
AAPL
[2015-11-04 22:45:32.820166] INFO: Performance: Simulated 3521 trading days out of 3521.
[2015-11-04 22:45:32.820314] INFO: Performance: first open: 2000-01-03 14:31:00+00:00
[2015-11-04 22:45:32.820401] INFO: Performance: last close: 2013-12-31 21:00:00+00:00

What happened instead?
2017-09-15 02:02:50.333834] INFO: Loader: Downloading benchmark data for 'SPY' from 1989-12-29 00:00:00+00:00 to 2017-09-13 00:00:00+00:00
[2017-09-15 02:02:50.724867] ERROR: Loader: Failed to cache the new benchmark returns
urllib.error.URLError: <urlopen error [Errno 8] nodename nor servname provided, or not known>

Here is how you can reproduce this issue on your machine:
Reproduction Steps

Install Zipline with Pycharm project interpreter to virtualenv
zipline ingest
copy buyapple.py to project folder
zipline run -f buyapple.py --start 2000-1-1 --end 2014-1-1 -o buyapple_out.pickle
...

What steps have you taken to resolve this already?
looked on stackoverflow and here for similar issues
...
Anything else?
Tried using different dates
...

Hello,
It's fun because I also have an issue with the zipline examples approximately in the same place in the code. The fun part is that the loader worked perfectly well a couple of weeks ago and does not work any more now.
My guess is that it has to do either with Google finance or with the pandas_datareader module. Indeed, it looks like your run fails here.
What happens if you try to run the following piece of script?
import pandas_datareader.data as pd_reader
import datetime

start = datetime.datetime(2010, 1, 1)
end = datetime.datetime(2013, 1, 27)
f = pd_reader.DataReader("SPY", 'google', start, end)
f.ix['2010-01-04']

As far as I am concerned, it does not fail but downloads data from totally different time range (between 2016-09-19 and now).

OK, it looks like this is a known and new issue

I am not 100% sure that this is the root cause of your issue, but I am pretty sure that even if your run would have passed this step it would have failed at the next step because of this. Obviously Google recently stopped providing historical data older than one year.

Thanks for replying. Using the code you provided worked with the first date downloaded.
f.ix['2016-09-19'] Out[8]:  Open           214.13 High           214.88 Low            213.03 Close          213.41 Volume    80250490.00 Name: 2016-09-19 00:00:00, dtype: float64
I did a bit of research and the data is still there on Google. They've probably added a cookie like yahoo. If you visit this link and change the dates it loads the data.
http://www.google.com/finance/historical?q=NASDAQ:GOOGL

The reason for this is because Google has now limited us to about 251 days worth of data, so you can't run backtests over a year. There is a fix currently being worked on.
There are duplicates of this issue so I'm just going to direct everyone to this issue: https://github.com/quantopian/zipline/issues/1965. I'll comment there when there is a fix on master