Can't get karate.edg to work

pecanpy --input demo/karate.edg --output demo/karate.emb --mode SparseOTF

Gives me the following error.
_Traceback (most recent call last):
  File "/usr/local/bin/pecanpy", line 5, in <module>
    from pecanpy.cli import main
  File "/usr/local/lib/python3.8/dist-packages/pecanpy/__init__.py", line 3, in <module>
    from . import pecanpy
  File "/usr/local/lib/python3.8/dist-packages/pecanpy/pecanpy.py", line 3, in <module>
    from gensim.models import Word2Vec
  File "/usr/local/lib/python3.8/dist-packages/gensim/__init__.py", line 11, in <module>
    from gensim import parsing, corpora, matutils, interfaces, models, similarities, utils  # noqa:F401
  File "/usr/local/lib/python3.8/dist-packages/gensim/corpora/__init__.py", line 6, in <module>
    from .indexedcorpus import IndexedCorpus  # noqa:F401 must appear before the other classes
  File "/usr/local/lib/python3.8/dist-packages/gensim/corpora/indexedcorpus.py", line 14, in <module>
    from gensim import interfaces, utils
  File "/usr/local/lib/python3.8/dist-packages/gensim/interfaces.py", line 19, in <module>
    from gensim import utils, matutils
  File "/usr/local/lib/python3.8/dist-packages/gensim/matutils.py", line 1030, in <module>
    from gensim._matutils import logsumexp, mean_absolute_difference, dirichlet_expectation
  File "gensim/_matutils.pyx", line 1, in init gensim._matutils
ValueError: numpy.ndarray size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject_

Hi @RichardShea, thanks for using pecanpy and reporting the bug! This looks like an error caused by gensim due to numpy. Could you share some information about the versions of these libraries you have? You could do so by running
pip show numpy gensim

I'm using numpy==1.23.2 and gensim==4.3.0 (Python 3.9 on Mac M1) and did not get the above error. I suspect the error would disappear if you upgrade your numpy and gensim. Here are some links that seem to be related to your issue (they all seem to indicate that a newer version of numpy should fix the error)

https://stackoverflow.com/questions/66060487/valueerror-numpy-ndarray-size-changed-may-indicate-binary-incompatibility-exp
https://github.com/numpy/numpy/issues/18709

Hi @RemyLau, I'm on gensim==4.3.0 and installed numpy==1.23.2.  I now get the following error:
Traceback (most recent call last):
File "/usr/local/bin/pecanpy", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.9/dist-packages/pecanpy/cli.py", line 342, in main
g = read_graph(args)
File "/usr/local/lib/python3.9/dist-packages/pecanpy/wrappers.py", line 18, in wrapper
result = func(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/pecanpy/cli.py", line 294, in read_graph
g.read_edg(path, weighted, directed, delimiter)
File "/usr/local/lib/python3.9/dist-packages/pecanpy/graph.py", line 443, in read_edg
g.read(path, weighted, directed, delimiter)
File "/usr/local/lib/python3.9/dist-packages/pecanpy/graph.py", line 301, in read
with open(path, "r") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'demo/karate.edg'

Hi @RichardShea, to run the example command for demo/karate.edg, you should be at the root level of the pecanpy repo directory. Let me know if this work!

@RemyLau
Oh, I thought the file would be in the pip install....
I did a the $ pip install pecanpy in Google Colab.  I assumed the karate.edg file was in the library.  So now I cloned your repo after the pip install, cd to the pecanpy directory, and now it appears to run fine.   Here is my Notebook if you are curious.
One Note:
On https://github.com/krishnanlab/PecanPy, I think the pecanpy --input demo/karate.edge --output demo/karate_n2vplus.emb --mode SparseOTF --extend command should be pecanpy --input demo/karate.edg --output demo/karate_n2vplus.emb --mode SparseOTF --extend
Thank you for your help!

No problem @RichardShea! I'm glad that it worked out for you! I'm marking this as resolved not. Feel free to open other issues if you've encountered any trouble running pecanpy, and I'm happy to help resolve them!


Incomplete blob on Firefox

We're using the useReactMediaRecorder hook in our app. We haven't encountered any issue on Chrome but on Firefox the blobs returned by the hook only contain the first few seconds of the recordings. No errors are thrown.
Here's a Codesandbox that reproduces the behaviour.
Let me know if you need more information!

Which version are you on? I'm on 88.0b9 (64-bit) and was able record (~22 secs) and play without any errors.
Or should I increase the recording time more?

I'm on 87.0 (64-bit) which I believe is the latest version, at the time of writing.
See: https://www.mozilla.org/en-US/firefox/releases/

I've just stumbled upon this issue on bugzilla. I'm guessing we'll have to wait for FF88 to roll out.


Autofocus password field in login flow

It would be convenient if the password field was automatically focused when it is displayed, since it's the only form control on the screen.  This would remove the need to manually click or tab into the field when logging in.
The password field is displayed in the AuthenticationForm component

Fixed by #1988


Using ruff and flake8 together?

In your test-build-publish.yml action you are linting with flake8 and then with ruff:
# Line 64
      - name: Linting
        run: |
          uv run flake8 src/PROJECT_NAME tests --max-line-length=88
          uv run ruff check --no-fix src/PROJECT_NAME tests
          uv run ruff format --check src/PROJECT_NAME tests

# …

Just asking why it is like that. To my knowledge, ruff has integrated most (if not all) flake8 rules. Why would you bother with two different tools, two different configurations which might conflict each other? Are there any shortcomings from ruff you see which you think you need to compensate by using flake8 directly?
Thanks for helping!

You are right, MOST of the flake8 plugins are now integrated into ruff directly - and many of them can be autofixed.
There are some outliers though like cognitive complexity or annotation complexity that are still only available via flake8.
This is just a personal preference.
For flake8 you can disable all the checks, that ruff provides, so they don't step on each other's feet, but this is hardly ever needed because ruff will already have taken care of it.

Thanks for your answer!


Water effect "pops" when origin rebasing

Every time the origin is rebased, the water effect snaps slightly to a new location.

The water texture uses an Absolute World Position node in the material (instead of the regular uv coords) to sample the noise, this lets adjacent tiles have seamless waves without the boundary artifacts that would appear if typical uv coords were used. Although the node is called "Absolute" World Position, I'm pretty sure it does not take origin rebasing into account.
It may be worth a try to add an ApplyWorldOffset override in CesiumGltfComponent that can update some world origin parameter on the materials. It doesn't appear that there exists an Unreal-provided way to get the world origin in the shader. If we can put together the world origin and world position in the shader, we can perhaps get a consistent noise sampling for the waves across origin rebasing. It still won't be consistent across changes to the georeference origin of course, but that may be stating the obvious.

Not an issue in UE5 because there's no more rebasing, and we're unlikely to address it just for UE4. Closing.


Clicking login link in checkout editor causes error

Our use case requires customers to login before being able to interact with the extension.
Clicking the login link from the checkout editor causes an error.

@smile-christian Thanks for the report. I've added the issue to our backlog for review.

Currently, the native login link is a no-op when clicked from the editor. Is that what we expect when an extension links to login as well?

Not sure how much control we would have over that.

Hi @smile-christian, we've recently rolled out a change to how external links work on the editor - when clicked, they will now prompt a confirmation pop up, which when confirmed by the user will open the link on a new tab.
Thank you again for reporting the issue!


Please show me how to do it!

The code does not compile.

I'll write some build instructions for you. Otherwise, your pull request does not work, why would I merge it?

The reason to was to show you my code, not to get it merged.

Autoconf is unnecessary, as dpp is a header-only library.

There are .cpp files there, those are not header files.

Certainly, but those are just example/test/demonstration files, not the library itself, which is contained inside dpp.hpp exclusively.

Autoconf is necessary to build those.

No, you can just use the command line, just like I show in the updated README.md.

I prefer to use the commands as provided by the build action, hence I adapted the source to the build rather than the other way round.  I believe going this way is more standard and more flexible.

That's fine, but there's such a variety of these tools. Sometimes Windows users have problems using autoconf-generated scripts. Anyway, not having to use tools like these was one of my design goals (e.g. you need an assembler to compile DEC64 assembly code).

If you prefer cmake which reportedly works better on systems I love to hate, I can do that too, of course.  That still will not solve the problem I have and that you promised me you know how to resolve, namely, installing gcc 11 on ubuntu-latest.

Nah, copy & paste of a command-line is probably the easiest recipe :) I did post a link for you. But please also take a look at this:
https://linuxize.com/post/how-to-install-gcc-compiler-on-ubuntu-18-04/
to summarize, try writing sudo apt install g++-11. and then play with update-alternatives as detailed on that page.


How do I set color_is when the two region_requirements submitted by IndexLauncher are different in partition dimensions?

When I need to implement a matrix transposition, my input area needs to be partitioned by row, so my output area needs to be partitioned by column, my Rect<3> color_bounds(Point<3>(0, 0, 0), Point<3>(0, num_slice-1, 0)) . No error is reported when the input area is partitioned, but a problem occurs when the output area is partitioned. When I submit the launcher and use the color_is generated by the color_bounds, my color_bounds is divided into the first dimension. I don't report errors in the output area, and I report errors in the input area.

When I comment out part of the code in the output area, this error does not occur.

In this case, how do I start the IndexLauncher?

You need to use projection functors to map between the points of your index task launch space and points in your logical partitions. Right now your region requirements are using the identity projection functor (id 0). When your partition color space doesn't match up directly with your index task launch space, register a projection functor that performs the correct mapping, and use that as the projection id on your region requirements.

Thank you for your help. Is there a document or a simple example of ProjectionFunctor? I searched in Legion and found that vitrual_map.cc is used, but I still don't understand its usage.

I can't find an example in the legion repository, but I'll try and give you some pointers here.
You'll want to implement a class that inherits from https://gitlab.com/StanfordLegion/legion/-/blob/master/runtime/legion.h?ref_type=heads#L4403, and implement an overload of this method: https://gitlab.com/StanfordLegion/legion/-/blob/master/runtime/legion.h?ref_type=heads#L4464, while also overloading the is_functional method to return true.
What project is supposed to do, is given the partition you are launching over, the point of the launch space being considered, and the launch space itself, return the desired subregion.
Most simple projection functors look like:
Legion::LogicalRegion project(Legion::LogicalPartition upper_bound,
                                                    const DomainPoint& point,
                                                    const Domain& launch_domain) {
  auto new_point = compute_user_defined_point_transformation(point, launch_domain);
  return runtime->get_logical_subregion_by_color(upper_bound, new_point);
}

I can't find an example in the legion repository, but I'll try and give you some pointers here.
You'll want to implement a class that inherits from https://gitlab.com/StanfordLegion/legion/-/blob/master/runtime/legion.h?ref_type=heads#L4403, and implement an overload of this method: https://gitlab.com/StanfordLegion/legion/-/blob/master/runtime/legion.h?ref_type=heads#L4464, while also overloading the is_functional method to return true.
What project is supposed to do, is given the partition you are launching over, the point of the launch space being considered, and the launch space itself, return the desired subregion.
Most simple projection functors look like:
Legion::LogicalRegion project(Legion::LogicalPartition upper_bound,
                                                    const DomainPoint& point,
                                                    const Domain& launch_domain) {
  auto new_point = compute_user_defined_point_transformation(point, launch_domain);
  return runtime->get_logical_subregion_by_color(upper_bound, new_point);
}

Use this function (https://gitlab.com/StanfordLegion/legion/-/blob/master/runtime/legion.h?ref_type=heads#L8652) to register your projection functor with the runtime to give it an ID.

Thank you, I'll try it first.

The virtual mapping example uses a non-identity projection functor:
https://gitlab.com/StanfordLegion/legion/-/blob/master/examples/virtual_map/virtual_map.cc?ref_type=heads#L315-363

@rohany  #1604

First, you do an index launch of 4 tasks (one for each node). Then, in each of those tasks, you create (or reference from the parent task) a partition of the data assigned the task. Then, you would do another index launch of size 8, one for each dore on your machine.

Hello, I'd like to ask about this parent task.I started the parent task, started the IndexLauncher in the child task, and then partitioned it. But I want the parent task to be independent, because the parent task does not do memory operations, and the child tasks are EXCLUSICVE. Therefore, I set the permission of the parent task to RELAXED, but the second parent task can be mapped only after all the subtasks of the first parent task are calculated. Can I let the second parent task start the subtasks of the second parent task earlier? Thank you.


Update not possible? [-> HACS 2.0 will provide updates now in your HASS-Settings section!]

With which version of the integration you have an issue?
SENEC.Home V3 hybrid/SENEC.Home V3 hybrid duo/SENEC.Home V2.1 (or older)
Multiple Systems Environment?

[ ] I have multiple SENEC Systems (master/slave configuration)

Checklist

[X] I have installed the latest release (or BETA) version of the integration and home assistant.
[X] I have prepared DEBUG log output (for technical issues) | In most of the cases of a technical error/issue I would have the need to ask for DEBUG log output of the integration. There is a short tutorial/guide 'How to provide DEBUG log' here
[X] I understand the SHIT-IN - SHIT-OUT principle (in case of implausible data) | It will happen, that the data that is displayed by this integration does not make much sense (to you) - Of course this could be always the case, that something in this integration has been messed up - but so far - in all reported issues the root cause of implausible data was/is, that the SENEC.Home device itself already provided this data
[X] I confirm it's really an issue | In the case that you want to understand the functionality of a certain feature/sensor Please be so kind and make use if the discussion feature of this repo (and do not create an issue) - TIA

Add a description
Since the new version (2.0) of HACS I can´t update this intergration anymore.

Add your DEBUG log output
No response

well

this is HACS 3.0... updates should now pop up in the HASS settings ?!

you have obviously NOT installed the latest version of the integration - so why checking then the checkbox?

I´m just a little bit confused .... I refered to this:

But right now, I´ve found the solution. From now the HACS downloaded Repo updates will be shown here:

Marc, I would Like to apologize in advance, but could you please explain, whether your Senec Plugin is compatible with HACS 2.0?
Reading the changelog I do not dare to try the Update without asking...

Marc, I would Like to apologize in advance, but could you please explain, whether your Senec Plugin is compatible with HACS 2.0? Reading the changelog I do not dare to try the Update without asking...

of course it is... don't get confused - it's just that HACS report you updates different than before...

Marc, I would Like to apologize in advance, but could you please explain, whether your Senec Plugin is compatible with HACS 2.0? Reading the changelog I do not dare to try the Update without asking...

of course it is... don't get confused - it's just that HACS report you updates different than before...

Thank you very much for the clarification!


How to generate Cue from go-control-plane AST

Hello Friends!! 👋
This is a really cool project! I'm trying to find the tooling you used to generate the Cue from the go-control-plane AST so that I can better understand how this all works together.
Thanks, Colton!

Did you do something like https://cuelang.org/docs/integrations/go/#download-cue-definitions-from-go-packages ?
Thanks!

Hey there @mccurdyc! Thanks for checking out the project. We actually have not open sourced the generator yet. We ended up having to write our own custom logic due to CUEs tooling not being up to par with the scope of what we needed.

@alecholmez that's awesome! I'm excited to try out the generator when you do open source it! I'd love to be an early adopter because generating Cue for the Envoy config schema has been painful!


CloudEvents clarity

What content needs to be created or modified?
Things that are missing

What is the relationship between using Cloud Events and how de-dupe is enabled? It is not clear. Dapr suggests that CloudEvents are required to enable "deduplication by messageId" but doesn't state how this is actually achieved? Many brokers have their own native deduplication feature. Does dapr provide its own de-dupe capability, or does dapr rely on the underlying broker? or both?
It is not clear that if a developer publishes a manually crafted Cloud Event envelope (dapr does not create the envelope) then Dapr will actually augment that envelope with any missing properties. More detail about this behaviour is needed.

Also, the below screenshot is ambiguous, for the following reasons

This sentence doesn't make sense - "Dapr implements the following CloudEvents fields when creating a message topic."
"The following example demonstrates an orders topic message sent by Dapr" - what is mean't by sent by dapr? Whats the scenario here?
the data object in the json should be correctly indented.

Where should the new material be placed?

cc @berndverst

Opened this docs issue forever ago, and its still tripping up my Teams to this day.
Really need docs to be specific on what the actual behaviours are.


Build and run JVM tests on GitHub Actions

Currently the app has JVM and UI tests run on Circle CI, but visibility into Circle is a pain and in the name of consistency across our internal projects, let's move this pipeline into GitHub Actions.
Given: I am developing code
When: a PR is opened against develop
Then: the app should be built and the JVM tests should be run
And: the results should be reported within the PR
On-device tests are a future story.

I was too quick to judge Circle CI's efficacy here. It looks like with the Android machine and orb that building and running tests, even UI tests, is very effective. Sure the consistency of GHA would be nice, but we're not here to pre-optimize. Closing issue until this is an actual problem.


Make the Marketing Web Site Part of AP repositories

The source code for the Marketing Site https://accordproject.org is not public. I recall somewhat that there are questions of copyright or property for some of the assets (logo? or maybe web site code and style?).
Discussion 🗣
It would be good if the marketing site could be put in the Accord Project GitHub, with or without an Apache-2.0 license. I'm unclear on the ramifications.
Context
A third party vendor was contracted by Clause Inc. to redesign the Accord Project marketing Web Site. I'm unclear on the terms of the contracts and ownership.
Related Issues

#6

We may need more context and details from @Michael-Grover and/or @peterhunn

From TSC Meeting 25-March 2021
- Michael provided context.
- WordPress site developed by design agency a number of years ago.
- Issue is that site is difficult to change. Only Clause have edit permission.
- Edits can only be made via WordPress CMS Login.
- Jerome - specific issue is that the web site is only AP asset not managed under AP GitHub. (NB: Code is on GitHub but in private Clause repo.)
- There is also a question on whether AP own IP assets in web site.
- **ACTION**
	- Michael to check on who owns assets.
- Once ownership is confirmed the relatively easy process to migrate code to AP GitHub repo.

From TSC Meeting 29-April 2021.

Peter mentioned there are a couple of minor issues to be cleared up on Clause side.
Specifically, items like copyright for fonts and some design elements of the site.
Should be fine but will get an answer back within next week to 10 days.
Once cleared, then transfer from Clause GitHub repo to AP GitHub repo relatively straight-forward.
Jerome has created a target repo in AP GitHub and is ready to receive source code.
Dan highlighted that the Accord Project web site does use a commercial WordPress plug-in at a cost of, circa, $30 per year to use.
Therefore, AP web site won't be 100% open source but not a technical issue.
ACTION

Peter to chase legal clarifications and report accordingly.

Once ownership is confirmed then relatively easy process to migrate code to AP GitHub repo.

From TSC Meeting, 24 June 2021.

No change since last meeting.
On hold while Peter on leave.
ACTION

Peter to chase legal clarifications and report accordingly.

Once ownership is confirmed then relatively easy process to migrate code to AP GitHub repo.

From TSC Meeting, 26 Aug 2021.

Have received clarification regarding ownership and now have all clear to migrate code to AP GitHub.
ACTION

Jerome to migrate code to AP GitHub repo.

Pending.

New PR raised on new (private) accordproject.org repo - code for marketing site. Wordpress.
Not all code inside template is open source therefore private repo. Can use proprietary code but cannot distribute it.
PR to be merged and access rights to be setup - including Michael.

Done.


Incorrect Transformation options can be selected in UI for some mappings

Please review some of those might be actually correct:

List of (Strings,numbers) -> String :

Concatenate (Source transformation shouldn't be enabled)

**String -> String **
List of Strings  ->Integer

Add
Average
Divide
Length
Maximum
Minimum
Multiply
Subtract

String -> Number (Integer,Double, Float, Long)

Add
Average
Divide
IndexOf
LastIndexOf
Maximum
Minimum
Multiply
Subtract

Number types -> Number types

IndexOf
LastIndexOf

Char -> Char

looks like there are string transformations that don't make sense (concat,append, fileExtension etc..)

@mmelko There is definitely a problem with List<?> -> String and ? -> Char.
The actions you questioned about Number -> Number are valid; you can find the index of digits within a number. These actions 'stringify' the data, so will work on any type.
However, I'm not seeing any of the numeric functions you listed show up for the List -> Number or String -> List. Can you verify how you are seeing these?

I'm seeing those for: List of Strings -> Number types. Just create mapping, click on "Edit mapping" and you can Add transformation.  I haven't mentioned any String -> List mapping. And I'm not sure what I meant by **String -> String **, it is some typo :)


Getting wrong message when clicking on my own order in the outcome Table

On the market trading pg....
Add open orders....on the outcome table, click on your own open order, order tackit filters in and shows Multiple Txs needed (this is the wrong message) should be getting "Consume own order" message

Does work correctly if clicking the same order on the order book....issue is just through the outcome table

fixed - closing


M> Get new logo production-ready for launch

This is a MoSCoW breakdown of preparation in order to launch the new logo on the 15th of February during the Gov conf. This post is not complete and can be edited as we fine tune the lists.
Some items require sub-lists that can posted, and edited, as messages in this issue.
MoSCoW categories: Must have, Should have, Could have, Won't have.
Must

Create logo files in key resolutions (need a list), for print and web (including favicon ico file), stored in Github (ref: https://github.com/rchain/style_guide_and_files)
Create presentations for the conf with the new logo. All RChain presentations (new or old) must use the new logo. We need: a placeholder screen, a blank presentation with logo and RChain look&feel...
The new website will be launched bearing the new logo. On other sites the logo needs to be updated. These include: http://rholang.rchain.coop, dev.rchain.coop?
Create t-shirts for all participants. Need a design, digital files, locate a printer in Seattle, order size breakdown (XXL, XL, L, M, S).
RHOC distribution cards (in progress).
The scarlet and charcoal colors of the logo must be defined in RGB, Hex, CMYK, and PMS.

Should

Update social media platforms with new logo: Twitter, Telegram groups, Facebook, YouTube, Reddit, Bitcointalk, Medium, QQ, Discord (need to collect a list of resolutions, e.g. Telegram 512x512px). Named asset files can be stored in Github.
Create a basic RChain Logo Style Guide (ref: https://github.com/rchain/style_guide_and_files/blob/master/rchain_style_guide_r1v2.pdf)
So far the best idea for SWAG for the conf is webcam covers, very appropriate and practical.
Banner ups

Could

Business cards
RChain ether.cards (bearing RHOCs, not Ether). See #150

Won't

Letterhead
Booth design
Handbills, handouts, flyers (need content and context)
Note that the RHOC logo is not changing, so the token keeps the double R cattle brand on exchange and index sites.

Ref: #232
Measure of Completion:  new logo visible on all 'Must' items
Suggested budget: 9000 for 'Must' items, plus 5000 for 'Should items'

@AyAyRon-P please send your email address to<EMAIL_ADDRESS>and join
https://groups.google.com/forum/#!managemembers/rchain/join

@lapin7 Email sent

Group joined!

@pmoorman Closing.


Split CLI into tslint-cli and a Runner class

Fixes #1675.
tslint-cli.ts takes in arguments using optimist and converts them to a friendlier object to pass to a CliRunner. The rest of the logic that used to be in tslint-cli.ts is now in the CliRunner.
Notes:

I really wanted to make CliRunner::run return a Promise<number>, but didn't want to add new dependencies or change the output target.
I tried to stick to the existing code style for the cut-and-pasted code. If you'd like it changed I'm up for that too.
I'm not confident in CliRunner as a name. Alternate suggestions, anyone?

👐 merge conflicts! I'll wait to resolve for if/until a design review passes.

@nchen63 thanks for the ping, updated and renamed cliRunner.ts/CliRunner to runner.ts/Runner.

lgtm

@JoshuaKGoldberg thanks!


Fix setup

Moves db services from pyopencdms to this project
Creates CLI commands that starts databases
Edits the setup script to use the cli script as the entry point
Edits Dockerfile

This is looking really great! Thank you @chinedu117
Could you fix the conflicts and then I'll merge?


Change 'source activate' to 'conda activate'

We should change all occurrences of source activate to conda activate in the docs. See the  StackOverflow report .
Docs to fix: See search for 'source activate' in our docs.
Thanks to @Tabrizian for originally pointing out this problem in PR https://github.com/kubeflow/website/pull/828.

@Tabrizian will take this issue on.


MSVC can't install channels

I downloaded the 64-bit MSVC built of multirust and ran multirust update and was then met with:
error: binary packages are not yet provided for this host

Currently this happens if the most recent nightly build of x86_64-pc-windows-msvc rust failed, because it is then missing from the channel-rustc-nightly file.
This also happens with the original multirust/rustup combo. However, it should at least have a better error message, and should fall back to the most recent successful build for the given target.

Ah ok I see what's going on. The builds actually all succeeded but perhaps seemed to be ordered incorrectly, I'll see if I can figure out what's going on from our end.

We're  now gating on MSVC nightly builds, so this is probably a moot issue at this point. Plus it's working today!

\o/ I'd still like to improve it slightly, so I've opened a new issue here: #10


Ensure fact cache is cleared before running frr molecule

This change ensures fact_cache is cleared prior to converging the FRR molecule job. This ensures we are testing our role in conditions that we can expect to represent a real deployment.
Jira: https://issues.redhat.com/browse/OSPRH-10353
Depends-On: https://github.com/openstack-k8s-operators/edpm-ansible/pull/764

/hold

retest

recheck


Bug - Errors during application

We got a few different errors over the weekend from people who were attempting to build/submit their applications.
Person 1:
"In the middle of my application process I was presented with an error.  Not sure how to proceed as the deadline is in 4 1/2 hours!  Please advise."
We know this person did eventually submit their application because we can see them in the list of people who applied, but we don't have any more information. This job is now closed.
Person 2:
First was trying to access talent.canada.ca/en/jobs/118/application/step-01 and was getting 403 Forbidden | nginx.
Afterwards can access talent.canada.ca and log in. Can see the job, but if they click Apply it "will go broken". This person tried 3 different browsers. Eventually this person submitted their application, though we're not sure how (we are following up to try and find out). Job is now closed.
Person 3:
Tried to use the "Cloud Platform website" but received several errors then contacted the manager directly. This was the link that was shared: https://talent.canada.ca/en/jobs/121. We are following up to see if we can get more details. Job poster is not yet closed.

First discovery: 403 errors are leading to a blank 403 Forbidden | nginx instead of a more expressive (or at least prettier) custom Talent Cloud error page. Not the root cause, but we should fix that.
Second discovery: Most jobs cause a 403 error if you try to view them after they've closed. That's definitely unintended. Mysteriously, job #2 doesn't suffer this issue.

@tristan More info from Person #3:

Was able to create account and log in
Completed fist page (I assume of Application) and clicked "Next"
They were returned to the same page with no error displayed and there were no missing fields.
They were not able to advance further

@tristan-orourke how long did you spend on this?

@tristan-orourke how long did you spend on this?

About 2 days, I think.

Investigated but no clear bugs to discern.


Camera's Projection Matrix shows nothing when coming to a particular position

Hey folks,
We were implementing CameraManipulator / OrbitControls, we came across this bug when we put the camera at a certain position, around the back of the model (x -> 0, z = back) / (spherical.theta -> (2n + 1) * PI), the camera projection rather than showing the model, goes blank.
Sharing across a video for the same below.
https://user-images.githubusercontent.com/20043762/155079662-6e110931-cd9b-41bb-b221-1867ed08067f.mp4
In our CameraManipulator, we are using spherical angles to map user input, the converting it to vectors, and using the center of the model, we map the Quaternion of it.
The spherical class:
class Spherical(var radius: Float = 1f, var phi: Float = 0f, var theta: Float = 0f) {
    fun set(radius: Float, phi: Float, theta: Float): Spherical {
        this.radius = radius
        this.phi = phi
        this.theta = theta
        return this
    }

    fun copy(sph: Spherical): Spherical {
        radius = sph.radius
        phi = sph.phi
        theta = sph.theta
        return this
    }

    fun makeSafe() {
        // Avoid theta tends to a (2n + 1) * PI
    }

    override fun toString(): String {
        val sb = StringBuilder()
        /** **/
        return sb.toString()
    }
}

Spherical to vector conversion:
fun setFromSphericalCoords(theta: Float, phi: Float, radius: Float): Vector3 {
    val sinPhiRadius = sin( phi ) * radius
    return Vector3(sinPhiRadius * sin(theta), cos(phi) * radius, sinPhiRadius * cos(theta))
}

Camera's values when this particular bug happens
Projection Matrix: [7.055431842803955, 0.0, 0.0, 0.0, 0.0, 3.7985377311706543, 0.0, 0.0, 0.0, 0.0, -1.000666856765747, -1.0, 0.0, 0.0, -0.02000666782259941, 0.0]
Quaternion: [x=0.1418157, y=0.005567789, z=0.019819506, w=0.989679]
Spherical Values: {theta=-3.143966,phi=1.2223562,radius=1.6650295}
Camera Position: [x=0.0037141538, y=0.5684945, z=-1.5649675]
The Z component of the camera is well beyond the radius / extent of the model

Hi,
Thanks for the complete feedback.
My fist guess is that Filament considers that your model shouldn't be rendered at this specific rotation because some parts of the model became beyond the Camera near clip plane.
Can you try lowering the default one a little bit to see if the issue comes from here?
https://github.com/SceneView/sceneform-android/blob/88a7a671c638ec8c11e81a712c294d6746c2765f/core/src/main/java/com/google/ar/sceneform/Camera.java#L89

Lowering that to 0.001f didn't help too @ThomasGorisse

Ok. It makes me remember some model disappearing when some part of it is not on the camera view.
Could you please try this model https://sceneview.github.io/assets/models/Halloween.glb ?
And screen record if it also disappear when rotating/moving.

Very interesting bug. Watching again your screen record, I'm also asking my self if this couldn't be related to the lights.
Something like your camera angle matching the main light opposite direction so nothing becomes visible.
Just like if you were watching something in front of the sun.
The main light is made like this in Scenform:
new LightManager.Builder(LightManager.Type.SUN)
    .intensity(LightKt.defaultMainLightIntensity)
    .castShadows(true));

@romainguy, Do you think this issue could be related to the lights or something else?
What is the default LightManager.Builder direction if not provided?
BTW, it has been renew in SceneView to match the Filament ModelViewer default light type and temperature and to give it a direction by default;
val defaultMainLight: Light by lazy {
    LightManager.Builder(LightManager.Type.DIRECTIONAL).apply {
        val (r, g, b) = Colors.cct(6_500.0f)
        color(r, g, b)
        intensity(100_000.0f)
        direction(0.28f, -0.6f, -0.76f)
        castShadows(true)
    }.build()
}

https://user-images.githubusercontent.com/20043762/155122172-f9f46a8d-6857-4266-b7e5-1063bfa9a9d2.mp4
There you go! Is there something wrong with the model?
The renderableInstance.filamentAsset.boundingBox shows size and extents are very lower compared to the actual size of the model.
@ThomasGorisse

@ThomasGorisse
We have an IBL environment which lights up the scene and default mainLight which exists on SceneView

There you go! Is there something wrong with the model?
The renderableInstance.filamentAsset.boundingBox shows size and extents are very lower compared to the actual size of the model.

Actually that's why I asked you to test this one. Because I had issues with the bounding box on it that could be related.
This model is interesting cause it is animated all the ways and the trident generates a big bounding box.
It has always been a personal suspended question I have around the bounding box returned by Filament in such a case.

Is there no deterministic way to determine the extents of the animations as well? @ThomasGorisse @romainguy

Untitled.1.mp4
There you go! Is there something wrong with the model? The renderableInstance.filamentAsset.boundingBox shows size and extents are very lower compared to the actual size of the model.

I also noticed your model loading toast while the app is inactive.
Just to let you, you wouldn't have this behavior with the introduced SceneView lifecycleScope parameter on lodModel() :wink:

@ThomasGorisse anyway I could fix this?

There was a contribution made to filament recently to compute more exact bounding boxes for models with animations. I don't remember if it's on by default because it requires looking at all transformed vertices at all key frames, and it's not necessarily cheap.

See https://github.com/google/filament/pull/4973 for more details. The default behavior is to properly compute the bounding box.

There was a contribution made to filament recently to compute more exact bounding boxes for models with animations. I don't remember if it's on by default because it requires looking at all transformed vertices at all key frames, and it's not necessarily cheap.

Ummmhuumnn, makes sense.
Could you help us with this specific issue @romainguy ?

Make sure to use the latest version of Filament.

Make sure to use the latest version of Filament.

noted, will try bumping the filament version to see if it causes any effect

@romainguy can reproduce the same issue with 1.19.0 as well !

Could be an issue with the asset maybe.

We can see this happening on more than 30+ assets, this object becomes invisible at a certain angle on all of them

To check whether the issue is a culling issue, try disabling culling on the Renderables in the scene. If the issue still occurs, the problem is somewhere else.

@romainguy
The frustum culling didn't help too.
IMO, the camera is projecting forward at the specified angle, because if I make shadow plane red, I see that but not the model in view.
Screenshots below:
![Uploading Screenshot_20220224-113039.png…](Front angle)
![Screenshot_20220224-113802](2n + 1 * PI angle)

@romainguy
The frustum culling didn't help too.
IMO, the camera is projecting forward at the specified angle, because if I make shadow plane red, I see that but not the model in view.
Screenshots below:
Front angle

2n + 1 * PI angle

I checked your camera transformation matrix and it seems to be ok:

Could you extract a little more camera and object matrices around your disappearing point?
Could you also try to change the camera FOV? Maybe try 45° instead of default AR used one (90) and also try to change the far clip plane just to exclude some potential side effects.

Changed the camera FOV -> 45 deg
far clip plane -> 1000
View Matrix -> [0.99879766, 0.030591767, -0.038306728, 0.0, -0.04782875, 0.7795239, -0.6245438, 0.0, 0.010755112, 0.6256251, 0.78004974, 0.0, 0.035747252, -0.0937209, 1.629953, 1.0000001]
The object is at origin with 0 rotation, it has this matrix data [1.0, 0.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 0.0, 1.0]
@ThomasGorisse

Just to be sure that it's not a culling issue, can you disable the object culling for your renderable instance?
We added the setter here bdc7ea9c0403e689ad5e915895c0ae6391f7303a.
@romainguy We have a lot of reported issues concerning animated models disappearing when the origin of the entity is not within the camera view. It seems to be a wrong bounding box calculation when the gltf is animated.
For now, we advice to disable culling for animated models but do you think that a bounding box refresh on each animation frame would be to consuming?

@ThomasGorisse tried it for no avail :(
our light has a direction of (0.0, -1.0, 0.0), could it be that?


Fixed SAM plugin (403 code for workers in organizations)

Motivation and context
Resolved #6221
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[x] I have added a description of my changes into the CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Hi, you just broke develop, could you please fix it?

@Keramblock
Could you please clarify what exactly was broken?


run demo.py and have a error

Traceback (most recent call last):
File "../../tools/demo.py", line 56, in
state = siamese_track(state, im, mask_enable=True, refine_enable=True)  # track
File "/home/zhouwenzhang/SiamMask-master/tools/test.py", line 254, in siamese_track
mask = net.track_refine((delta_y, delta_x)).cuda().sigmoid().squeeze().view(
File "/home/zhouwenzhang/SiamMask-master/experiments/siammask/custom.py", line 157, in track_refine
pred_mask = self.refine_model(self.feature, self.corr_feature, pos=pos)
File "/opt/conda/envs/pytorch-py3.6/lib/python3.6/site-packages/torch/nn/modules/module.py", line 468, in call
result = self.forward(*input, **kwargs)
File "/home/zhouwenzhang/SiamMask-master/experiments/siammask/custom.py", line 123, in forward
out = self.post0(F.upsample(self.h2(out) + self.v2(p2), size=(31, 31)))
File "/opt/conda/envs/pytorch-py3.6/lib/python3.6/site-packages/torch/nn/functional.py", line 1797, in upsample
return torch._C._nn.upsample_nearest2d(input, _scale_factor(2))
File "/opt/conda/envs/pytorch-py3.6/lib/python3.6/site-packages/torch/nn/functional.py", line 1769, in _scale_factor
'x'.join(map(str, input.size()))))
RuntimeError: output size specified in UpsamplingNearest (31x31) has to be divisible by the input size, but got: 1x32x15x15

I have encountered the same problem with you. Have you solved it?

I  meet the same problem with you.How can I solve it?

i meet the same problem, but someone said it may be the mismatch between the cuda version, but i dont known how to solve it

i meet the same problem, but someone said it may be the mismatch between the cuda version, but i dont known how to solve it


PR: Replace deprecated function in inline CollectionsEditor tests and add recently supported data types

In the inline tests for CollectionsEditor, np.random.random_integers is called, which has been deprecated for quite some time. To avoid problems when/if it is finally removed, I replaced it with np.random.randint. Also, added a number of additional datatypes which we now support in the years since the test was written, for full coverage, and did some minor cleanup/refinements to the docstrings.

@ccordoba12 Looks like increasing the #6714 didn't help much, since the AppVeyor Py3.6 build failed due to a timeout on the same test, test_set_elapsed_time, requiring a restart to get it to pass...


FindVulkanHeaders.cmake might not set VulkanRegistry_DIR (macOS)

I provide VULKAN_HEADERS_INSTALL_DIR and VULKAN_LOADER_INSTALL_DIR paths. I want to use those dependencies in the repositories I cloned/built instead of duplicating them with update_deps.py. In this case problem appears in this call (cmake/FindVulkanHeaders.cmake):
find_path(VulkanHeaders_INCLUDE_DIR
NAMES vulkan/vulkan.h
HINTS
${VULKAN_HEADERS_INSTALL_DIR}/include
"$ENV{VULKAN_HEADERS_INSTALL_DIR}/include"
"$ENV{VULKAN_SDK}/include")
This function uses global VULKAN_LOADER_INSTALL_DIR to set VulkanHeaders_INCLUDE_DIR value. It is possible because VulcanLoader has vulkan.framework package, so find_path ignores hints and VulkanHeaders_INCLUDE_DIR will point to "..../loader/vulkan.framework/Headers".
Obviously, there is no "share/vulkan/registry" folder in the vulkan.framework, so VulkanRegistry_DIR will be not defined.
In order to make find_path use hints (it should search VULKAN_HEADERS_INSTALL_DIR for VulkanHeaders), I added NO_DEFAULT_PATH parameter, like this:
find_path(VulkanHeaders_INCLUDE_DIR
NAMES vulkan/vulkan.h
HINTS
${VULKAN_HEADERS_INSTALL_DIR}/include
"$ENV{VULKAN_HEADERS_INSTALL_DIR}/include"
"$ENV{VULKAN_SDK}/include"
NO_DEFAULT_PATH)
After that cmake worked fine with all the provided parameters (VULKAN_HEADERS_INSTALL_DIR, VULKAN_LOADER_INSTALL_DIR, MOLTENVK_REPO_ROOT etc).
Would it be an appropriate fix?

After testing it would seem this problem has been resolved.
Feel free to reopen the issue if you still see the problem occurring.


sentry_sdk.tracing.Span backward incompatibility

Description
Upgraded from0.14.2 to the latest release 0.19.0 and lost access to sentry_sdk.tracing.Span.transaction, as transaction is no longer part of the class attributes.
I see that transactions are handled through  tracing.Transaction, and backward compatibility is maintained in the constructor of Span when transaction is passed as a keyword argument. Also there are workarounds to handle exceptions arising from this issue.
However, the fact remains: If a user tries to set the Span.transaction directly, which is permitted as part of the public API in 0.14.2, will see exceptions raised instead in 0.19.0.
So I would like to raise the following concerns:

If the project follow semantic versioning, the deprecation of class attributes in minor versions is inconsistent.
Are there other similar deprecation in the public API that could be somehow emphasized?

Hey @kodemartin, please refer to https://github.com/getsentry/sentry-python/blob/master/CHANGES.md#versioning-policy for our versioning policy. The tldr is that 0.x can contain breaking changes, and 0.x.x not. Because the major version is 0, semver allows for this. This is consistent with how most other packages handle version 0.
Generally we try not to break things without deprecation period/warning. As for span.transaction, I think this was an oversight on our end, so thanks for bringing this to our attention. Generally anything span/tracing related is still very fresh. At this point we can add a compatibility shim but we'd recommend setting the transaction on scope, which will forward properly.
Hope that makes sense.

Hi @untitaker! Thanks for the prompt reply. I stand indeed corrected with respect to the rules of semver, my apologies. I wasn't aware of the special rules for 0.x.x versions, nor for the sentry-specific overrides provided in your versioning policy. Thanks for pointing this out to me.
As for the rest, it makes perfect sense. Please feel free to close the issue.

ok thanks. We are open to adding a compat shim if more people are annoyed by this but I think there are not a lot of users who access span directly like that.


chore: Increment version

The workflow files are incorrect, so we will close this pull request and reopen when they are fixed.


Allow MarkdownString.isTrusted for chat participants

Currently, there is no way to return a markdown with the chat participant response that calls extension commands on click.
The markdown(value: string | MarkdownString): void accepts the MarkdownString as arguments, but doesn't allow to set isTrusted to enable links that execute commands, e.g. [Run it](command:myCommandId):
Err: The boolean form of MarkdownString.isTrusted is NOT supported for chat participants.

cc @isidorn

Good issue - thanks Alena.
@roblourens I thought you mentioned we supported trusted Markdown for chat participants. I might have misunderstood you.

The boolean form is not supported. The non-boolean type (enabledCommands) works :)


Improve container-based Instance controller tests

Description
This PR aims to improve the tests on the container-based Instance controller, in order to provide a guideline when further developing the operator for the container-based Instance.

/rebase

/rebase

/merge


Network generators

here, really separating out the generator refactoring.

Hello @RiesBen! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/konnektor/network_planners/concatenators/_abstract_network_concatenator.py:

Line 66:9: E125 continuation line with same indent as next logical line

In the file src/konnektor/network_planners/concatenators/cyclic_concatenator.py:

Line 41:80: E501 line too long (80 > 79 characters)
Line 51:9: E125 continuation line with same indent as next logical line

In the file src/konnektor/network_planners/concatenators/max_concatenator.py:

Line 43:9: E125 continuation line with same indent as next logical line

In the file src/konnektor/network_planners/concatenators/mst_concatenator.py:

Line 45:9: E125 continuation line with same indent as next logical line

In the file src/konnektor/network_planners/generators/_abstract_network_generator.py:

Line 54:80: E501 line too long (88 > 79 characters)

In the file src/konnektor/network_planners/generators/n_node_edges_network_planner.py:

Line 61:80: E501 line too long (88 > 79 characters)
Line 80:80: E501 line too long (106 > 79 characters)

In the file src/konnektor/network_planners/generators/two_dimensional_network_planners.py:

Line 19:80: E501 line too long (106 > 79 characters)
Line 30:80: E501 line too long (88 > 79 characters)
Line 46:80: E501 line too long (144 > 79 characters)
Line 48:80: E501 line too long (148 > 79 characters)
Line 143:80: E501 line too long (83 > 79 characters)
Line 150:80: E501 line too long (88 > 79 characters)
Line 166:80: E501 line too long (144 > 79 characters)
Line 168:80: E501 line too long (148 > 79 characters)
Line 178:38: E251 unexpected spaces around keyword / parameter equals
Line 178:40: E251 unexpected spaces around keyword / parameter equals

In the file src/konnektor/network_tools/clustering/_abstract_clusterer.py:

Line 12:5: E122 continuation line missing indentation or outdented

In the file src/konnektor/network_tools/clustering/charge_clustering.py:

Line 16:5: E122 continuation line missing indentation or outdented

In the file src/konnektor/network_tools/misc.py:

Line 29:5: E731 do not assign a lambda expression, use a def
Line 55:5: E731 do not assign a lambda expression, use a def

In the file src/konnektor/tests/network_planners/concatenators/test_bipartite_MST_connector.py:

Line 30:32: W292 no newline at end of file

In the file src/konnektor/tests/network_planners/concatenators/test_bipartite_max_concatenator.py:

Line 7:80: E501 line too long (85 > 79 characters)
Line 9:80: E501 line too long (100 > 79 characters)
Line 12:1: E265 block comment should start with '# '

In the file src/konnektor/tests/network_planners/generators/test_explicit_network_planner.py:

Line 5:80: E501 line too long (91 > 79 characters)
Line 7:1: E302 expected 2 blank lines, found 1
Line 10:5: E303 too many blank lines (2)

In the file src/konnektor/tests/network_planners/generators/test_maximal_network_planner.py:

Line 8:80: E501 line too long (100 > 79 characters)
Line 10:80: E501 line too long (89 > 79 characters)

In the file src/konnektor/tests/network_planners/generators/test_mst_netwok_planner.py:

Line 12:80: E501 line too long (128 > 79 characters)
Line 13:80: E501 line too long (89 > 79 characters)

In the file src/konnektor/tests/network_planners/generators/test_radial_network_planner.py:

Line 9:80: E501 line too long (100 > 79 characters)
Line 11:80: E501 line too long (89 > 79 characters)

In the file src/konnektor/tests/network_planners/generators/test_rmst_netwok_planner.py:

Line 12:80: E501 line too long (128 > 79 characters)
Line 13:80: E501 line too long (89 > 79 characters)

In the file src/konnektor/tests/network_tools/test_clustering.py:

Line 5:80: E501 line too long (80 > 79 characters)

In the file src/konnektor/tests/network_tools/test_misc.py:

Line 2:80: E501 line too long (80 > 79 characters)

In the file src/konnektor/tests/test_toy_data.py:

Line 6:80: E501 line too long (82 > 79 characters)
Line 112:80: E501 line too long (104 > 79 characters)
Line 114:80: E501 line too long (80 > 79 characters)

In the file src/konnektor/utils/toy_data.py:

Line 102:80: E501 line too long (80 > 79 characters)
Line 149:5: E125 continuation line with same indent as next logical line
Line 192:80: E501 line too long (83 > 79 characters)


Fix for missing cert lookup

requires d-m-p 0.16.5 which just has been released.
Fixes #333

lgtm

[merge]


error in running u2pl wth AEL

HI When running U2PL with AEL. I am getting this error:
Traceback (most recent call last):
File "../../train.py", line 967, in
main()
File "../../train.py", line 74, in main
model = ModelBuilder(cfg["net"])
File "/mnt/data10/shared/ironman/final_aaai23/aaai22/U2PL/u2pl/models/model_helper.py", line 15, in init
self.encoder = self._build_encoder(net_cfg["encoder"])
File "/mnt/data10/shared/ironman/final_aaai23/aaai22/U2PL/u2pl/models/model_helper.py", line 29, in _build_encoder
encoder = self._build_module(enc_cfg["type"], enc_cfg["kwargs"])
File "/mnt/data10/shared/ironman/final_aaai23/aaai22/U2PL/u2pl/models/model_helper.py", line 47, in _build_module
return cls(**kwargs)
File "/mnt/data10/shared/ironman/final_aaai23/aaai22/U2PL/u2pl/models/resnet.py", line 370, in resnet101
state_dict = torch.load(model_url)
File "/home/phowlader/anaconda3/envs/pytorch/lib/python3.6/site-packages/torch/serialization.py", line 608, in load
return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File "/home/phowlader/anaconda3/envs/pytorch/lib/python3.6/site-packages/torch/serialization.py", line 777, in _legacy_load
magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: could not find MARK
/home/phowlader/anaconda3/envs/pytorch/lib/python3.6/site-packages/torch/distributed/launch.py:186: FutureWarning: The module torch.distributed.launch is deprecated
I am using the same resnet 101 weights that you have provided as pickle file

Can you please tell me what is the issue so I can run it.

Did you change the model_url for ResNet-101?
https://github.com/Haochen-Wang409/U2PL/blob/main/u2pl/models/resnet.py#L20

Yes I have changed the model url. But I still get this error. Can you please help

It seems that something wrong with the pre-trained ResNet-101. Please re-download the checkpoint and try again.


Version 2.0.0 unable to create database connection

Describe the bug
I have incident-bot set up in AWS EKS and using Postgres RDS. Everything worked in version 1.12.2 (with some minor bug - status change was not recorded in postmortems), but with the newest 2.0.0 version getting the following error and kubernetes pod is crashlooping:
2024-09-20 12:16:56 [info     ] Starting task scheduler...
2024-09-20 12:16:57 [info     ] Testing the database connection...
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/engine/base.py", line 1967, in _exec_single_context
    self.dialect.do_execute(
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/engine/default.py", line 941, in do_execute
    cursor.execute(statement, parameters)
psycopg2.errors.UndefinedTable: relation "user" does not exist
LINE 2: FROM "user"
             ^

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/app/main.py", line 183, in <module>
    startup_tasks()
  File "/app/main.py", line 68, in startup_tasks
    create_default_admin_user()
  File "/app/incidentbot/models/database.py", line 353, in create_default_admin_user
    user = session.exec(
           ^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sqlmodel/orm/session.py", line 66, in exec
    results = super().execute(
              ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/orm/session.py", line 2362, in execute
    return self._execute_internal(
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/orm/session.py", line 2247, in _execute_internal
    result: Result[Any] = compile_state_cls.orm_execute_statement(
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/orm/context.py", line 305, in orm_execute_statement
    result = conn.execute(
             ^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/engine/base.py", line 1418, in execute
    return meth(
           ^^^^^
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/sql/elements.py", line 515, in _execute_on_connection
    return connection._execute_clauseelement(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/engine/base.py", line 1640, in _execute_clauseelement
    ret = self._execute_context(
          ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/engine/base.py", line 1846, in _execute_context
    return self._exec_single_context(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/engine/base.py", line 1986, in _exec_single_context
    self._handle_dbapi_exception(
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/engine/base.py", line 2355, in _handle_dbapi_exception
    raise sqlalchemy_exception.with_traceback(exc_info[2]) from e
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/engine/base.py", line 1967, in _exec_single_context
    self.dialect.do_execute(
  File "/usr/local/lib/python3.12/site-packages/sqlalchemy/engine/default.py", line 941, in do_execute
    cursor.execute(statement, parameters)
sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedTable) relation "user" does not exist

Version
2.0.0 via helm chart
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
Database connection working.
Environment (please complete the following information):

Platform: AWS EKS via helm chart

Additional context
Was there some new helm values option introduced that i might have missed? I did even drop the postgres database before installing the newest version. Even did a test where i recreated the database structure with 1.12.2 and installed 2.0.0 after that, but still getting the same error.
My helm chart setup (simplified):
configMap:
  create: true
  data:
    platform: slack
    digest_channel: incidents

    roles:
      incident_commander:
        description: "The Incident Commander is the decision maker during an incident."
        is_lead: true

    severities:
      P1_blocker: 'Blocker incident.'
      P2_critical: 'Critical.'
      P3_major: 'Important.'
      P4_minor: 'Minor issue.'
      P5_trivial: 'Trivial issue.'

    options:
      timezone: UTC
      meeting_link: 'https://meet.google.com/'
      skip_logs_for_user_agent:
        - kube-probe
        - ELB-HealthChecker/2.0

    integrations:
      atlassian:
        confluence:
          enabled: true
          auto_create_postmortem: true
          space: XX
          parent: Postmortems
          template_id: 123456
        jira:
          enabled: true
          auto_create_issue: false
          project: XXX
          issue_types: ['Support', 'Bug', 'Service Request']
          priorities: ['Blocker', 'Critical', 'Major', 'Minor', 'Trivial']
          labels:
            - incident-management
            - incident-bot
          status_mapping:
            - incident_status: Investigating
              jira_status: Open
            - incident_status: Identified
              jira_status: Open
            - incident_status: Monitoring
              jira_status: Open
            - incident_status: Resolved
              jira_status: Completed

    links:
      - title: Incident Guide
        url: https://myatlassian.atlassian.net/Incidents
      - title: Postmortems
        url: https://myatlassian.atlassian.net/Postmortems

envFromSecret:
  enabled: true
  secretName: ib-secrets
ingress:
  enabled: true
  annotations:
    kubernetes.io/ingress.class: alb
    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP": 80}, {"HTTPS":443}]'
    alb.ingress.kubernetes.io/scheme: internal
    alb.ingress.kubernetes.io/group.name: internal-ingress-group
    alb.ingress.kubernetes.io/ssl-redirect: "443"
    alb.ingress.kubernetes.io/target-type: ip
    cert-manager.io/cluster-issuer: null
  hosts:
    - host: incident-bot.mywebpage.com
      paths:
        - path: /
          pathType: Prefix
  tls: null

@kurawes thanks for reporting - this is related to the migrations that take place prior to starting the bot up. It would probably be best if an init job was added to handle this in the chart, so I'll look into adding that right now.
That being said, this is likely also a weakness in the docs which I will fix. In the meantime, if you're able to run the migrations against your database you should be able to get past this.

Could you give me a bit of direction (a link) about the migrations? It's kinda hard to find the proper info. :)

Hey, I ran into the same issue today while updating to v2. I am managing the app through Helm. To resolve this I just changed the command of the Deployment/Pod to something like sleep 1d, and then ran alembic upgrade head - got that from Makefile. The schema was created then.

Thanks for the quick response @Kostavro - that's exactly what I was getting at. I'm going to push up a change shortly that will handle the migrations via the chart. Apologies for the omission.

Ok, so there's a lot going on here.

The last error indicates the bot isn't even in the incident channel when it tries to send that message, which is odd because the bot should also be the first member. Can you confirm this is the case?
I will look into the optional field issue.
Can you share the content of your values.yaml file for Helm with anything sensitive stripped?

There was an issue with how the app sources the config.yaml file built from the Helm install. I'm going to push up a fix for this.

@kurawes just released v2.0.4, if you have time please try bumping to that chart version and seeing if your issues are resolved. Thanks.


MG - 7.2.X - "... module(MX)"

Minor typo: you just need to add an extra space between "module" and "(M" in the section titles :smile:

Fixed :) Thank you!


Delete package_config.json

Should not be committed in a Dart project
Description
package_config.json has per-machine information. It should not be committed.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Is this in the .gitignore? Should it be added?

Is this in the .gitignore? Should it be added?

that file shouldn't BE THERE. It should be in .dart_tool/


Events should linger around for a bit after they're over

If an old event disappears from the ical feed, it's immediately removed from the site. This usually happens when events are over, but they should hang around for at least a few hours after they're over.

As of right now the site shows two events from yesterday, so progress has been made on this bug.
Two Observations:
1. No github activity tied to said progress
2. Only two events show from previous date

See ss:

I know for a fact that JSLou meetup happened last night. This made me think there was an issue.


wsl-networking-problem-0x80041002

Windows Version
Microsoft Windows [Version 10.0.22631.4460]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[x] WSL 2
[ ] WSL 1

Kernel Version
0
Distro Version
0
Other Software
No response
Repro Steps
when I try to start ubuntu using terminal I get this error:
Expected Behavior
I expect the linux to launch normaly as it was before
Actual Behavior
I get this error log

Diagnostic Logs
WslNetworkingLogs-2024-11-21_09-55-10.zip
WslLogs-2024-11-21_09-51-19.zip

One developer in my company had this exactly issue this week. My hypothesis is that a faulty Windows update could trigger the issue (KB5045935)
The only way to get a somehow working status was updating to prerelease and rebooting laptop. Perhaps it fixed internally certain status.
wsl --update --pre-release

However, he gets a different message now, even if he can at least get back to work:

We tried a bunch of things:

Reinstall Virtual Machine Platform feature (disable, reboot, enable, reboot)
Reinstall Windows Subsystem for Linux feature
Run:

wsl --install --no-distribution
wsl --uninstall


Istiod enables SDS by default, breaking clusters without support

Currently on master the default install will not work on many clusters. This issue just tracks making sure we do not ship 1.5 without reconciling this. There are a variety of options to solve this which I think have issues created - disable by default, allow untrustworthy, etc

https://github.com/istio/istio/issues/19950

that only solved half, there is still the jwt issue

for JWT issue: https://github.com/istio/istio/issues/20178


Pluto support

PR Checklist
If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

[x] Did I update CHANGELOG.md with whatever changes/features I added with this PR?
[x] Did I make sure to only change the part of the file where I introduced a new change/feature?
[x] Did I cover all corner cases to be close to 100% test coverage (if applicable)?
[x] Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
[x] Did I properly add test dependencies to the test directory (if applicable)?
[x] Did I check relevant tutorials that may be affected by changes in this PR?
[x] Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #208
How did you address these issues with this PR? What methods did you use?
For the interactive feature, I have used a _pluto_viewer method which computes and stores the frames in-memory. Another alternative was using the internal methods in Javis as specified here. But that isn't very user friendly.
When liveviewer = false I have created a small wrapper and an overload over the Base.show method to fetch and view the rendered gif.

Thanks @Sov-trotter
I'm a bit confused this includes #288 , right? Would love to merge that one first. Is that okay?

Yeah!

Hey @Sov-trotter - I finished reviewing your PR for Pluto. I cannot seem to get the slider to show up. Here is my notebook file:
### A Pluto.jl notebook ###
# v0.14.2

using Markdown
using InteractiveUtils

# This Pluto notebook uses @bind for interactivity. When running this notebook outside of Pluto, the following 'mock version' of @bind gives bound variables a default value (instead of an error).
macro bind(def, element)
    quote
        local el = $(esc(element))
        global $(esc(def)) = Core.applicable(Base.get, el) ? Base.get(el) : missing
        el
    end
end

# ╔═╡ 78269506-c35d-4613-97e8-c4968ad03e16
using PlutoUI

# ╔═╡ adf80b4c-befe-4f6d-b411-a1350a4c391b
using Javis

# ╔═╡ e882ff6f-d24f-4757-b52b-9c732491c0e4
function ground(args...)
    background("white") # canvas background
    sethue("black") # pen color
end

# ╔═╡ af3705d3-e0a4-4b29-9c45-35c8cba9362d
function object(p=O, color="black")
    sethue(color)
    circle(p, 25, :fill)
    return p
end

# ╔═╡ 6fedb208-b82f-4ee0-ab78-c31b28278545
function path!(points, pos, color)
    sethue(color)
    push!(points, pos) # add pos to points
    circle.(points, 2, :fill) # draws a circle for each point using broadcasting
end

# ╔═╡ a76ae8a0-bdce-4006-9012-35e7667f1d9f
function connector(p1, p2, color)
    sethue(color)
    line(p1,p2, :stroke)
end

# ╔═╡ ad9fa5e7-35bd-4861-a361-61e061923249
begin
	myvideo = Video(500, 500)

	path_of_red = Point[]
	path_of_blue = Point[]

	Background(1:70, ground)
	red_ball = Object(1:70, (args...)->object(O, "red"), Point(100,0))
	act!(red_ball, Action(anim_rotate_around(2π, O)))
	blue_ball = Object(1:70, (args...)->object(O, "blue"), Point(200,80))
	act!(blue_ball, Action(anim_rotate_around(2π, 0.0, red_ball)))
	Object(1:70, (args...)->connector(pos(red_ball), pos(blue_ball), "black"))
	Object(1:70, (args...)->path!(path_of_red, pos(red_ball), "red"))
	Object(1:70, (args...)->path!(path_of_blue, pos(blue_ball), "blue"))

	mygif = render(myvideo; liveview = true)

	@bind x Slider(1:1:70)

	mygif[x]

end

# ╔═╡ Cell order:
# ╠═78269506-c35d-4613-97e8-c4968ad03e16
# ╠═adf80b4c-befe-4f6d-b411-a1350a4c391b
# ╠═e882ff6f-d24f-4757-b52b-9c732491c0e4
# ╠═af3705d3-e0a4-4b29-9c45-35c8cba9362d
# ╠═6fedb208-b82f-4ee0-ab78-c31b28278545
# ╠═a76ae8a0-bdce-4006-9012-35e7667f1d9f
# ╠═ad9fa5e7-35bd-4861-a361-61e061923249

Anything I am missing?

Thanks for looking in it.
I'd suggest you take the render function and the slider out of the begin end block.
And put them in two different cells.

Ah perfect @Sov-trotter - I think the only thing I have to suggest would be in the documentation workflow area, could you add some explanation on the requirement of putting @bind and anim[x] in different cells for the slider to show up? After that, I think this PR is good to go!

I am trying to understand this in the above code
# This Pluto notebook uses @bind for interactivity. When running this notebook outside of Pluto, the following 'mock version' of @bind gives bound variables a default value (instead of an error).
macro bind(def, element)
    quote
        local el = $(esc(element))
        global $(esc(def)) = Core.applicable(Base.get, el) ? Base.get(el) : missing
        el
    end
end

Could you share where would this notebook run outside of Pluto. Since internally @bind is only useful if PlutoRunner is defined. https://github.com/Wikunia/Javis.jl/pull/324/files#diff-763ffddd0fe1ffb533564007035f5947812905676655f155ce1ee4357eb53c5eR205

Sorry for the long wait @Sov-trotter
I think that looks fantastic. Kind of the first time I enjoyed using Pluto :smile:
Two things I would like to check before we merge this:
Do you mind providing a julia file that can simply be opened as an example in Pluto? Similar to the one provided by @TheCedarPrince  above but with the last two things in different cells. And then link to that example from the workflow inside the documentation.
The other point is: I don't have any experience with Pluto so maybe you can check this out.
When I added
using LaTeXStrings

and later
Object(1:70, (args...)->latex(L"x^2"))

I got an error that latex is undefined. Is that an issue for you as well? For me it seems like it's a Pluto issue somewhere. If you can reproduce that and maybe @TheCedarPrince as well, we can open an issue there and make make a remark in the workflow section to prevent other people from getting that issue and being confused :smile:

Sure @Wikunia. The LaTeX declaration worked for me

LGTM. Make sure to resolve the changelog. Anything else from your side @TheCedarPrince ?

This is weird. Formatter returns true at my end but the test fails. :(

See: https://github.com/Sov-trotter/Javis.jl/pull/16 @Sov-trotter

I made some changes here @Wikunia and @Sov-trotter to clarify and clean up the formatting. Otherwise, this has my full hearted approval! Merge when ready @Wikunia @Sov-trotter !


[POAE7-1213] update APE doc for Spark in disaggregated mode

What changes were proposed in this pull request?
update APE doc for Spark in disaggregated mode
How was this patch tested?
N/A

@jikunshang Please help merge this PR.


todo: implement lightweight full text/fuzzy search

both typesense and algolia require api key signup, which is bleh, so let's try to handroll it like chumps: https://github.com/sw-yx/netlify-plugin-search-index

How would be this fuse.js? It works fine in my app and is super fast.

yeah i use fusejs under the hood in that thing - welcome to help implement it!

so if i'm reading this right, we can rework the search with fuse.js?

can i take it up if so?

#122 added fuse.js
and is this what's expected?

yup!

see also the ideas and comments in https://github.com/sw-yx/swyxkit/issues/80


Ag package term suggestion annual_season_precpt NEW

New term details
"```
Term name - mean annual and seasonal precipitation
Term ID -
Structured comment name - annual_season_precpt
Definition - mean annual and seasonal precipitation
Expected value - measurement value
Value syntax - {float} {unit}
Example -
Package(s) - Agriculture

**Additional context**
Suggested as part of the Ag package

## Points for discussion
we have terms for "annual_precpt" MIXS:0000644 and "season_precpt" MIXS:0000645, not sure which this is meant to be? but we can probably just re-use those terms.

CIG call (23/aug/2021)- reuse 2 separate terms instead of creating a new one here


Fix freeze when container is started/stopped multiple times

I checked and this PR fixes #190
Also it fixes a bug when after stop the name of container becomes -.
@bcicen please take a look

We probably also must set running = false for other connectors:
Index: connector/collector/runc.go
===================================================================
--- a/connector/collector/runc.go	(revision 8cd357ed5881f166cc7acecec622a9f6affa4c5e)
+++ b/connector/collector/runc.go	(date<PHONE_NUMBER>325)
@@ -49,6 +49,7 @@
 }

 func (c *Runc) Stop() {
+	c.running = false
 	c.done = true
 }

Index: connector/collector/mock.go
<+>UTF-8
===================================================================
--- a/connector/collector/mock.go	(revision 8cd357ed5881f166cc7acecec622a9f6affa4c5e)
+++ b/connector/collector/mock.go	(date<PHONE_NUMBER>321)
@@ -38,6 +38,7 @@
 }

 func (c *Mock) Stop() {
+	c.running = false
 	c.done = true
 }

thanks @vcmkrtchyan !
@stokito updated the collector stop function for other connectors in https://github.com/bcicen/ctop/commit/99d9aeec9894c4bc80121d2d3687e60758cd3386


Random cellection?

Are subjects randomly cellected right now? It seems like I always get the subjects in the same order...

They should be.

Okay, I'll be more systematic to see if it's random or not and report back. (Hard to really know if it's random with just 5 subjects...)

The default page size is 10 set here, you can override the param to be less than your subject set size to test the randomness of the selection.

Seems like this ended up working?

Seems random. Although, the subjects are always presented in the same order, I think. So if I have 20 subjects and the first draw is A, B, D, E, ... and the second draw is A, B, C, G, ..., I'll always see A first, then B. So with 10 or fewer subjects (and the default page size) you always get the same subjects in the same order. I don't think there's anything wrong with this -- especially when subject sets are expected to be in the hundreds or thousands or more.

Ah I think this is an issue of RestPack sorting by id. This actually will be a problem

Does RPS really sort by ID by default? https://github.com/RestPack/restpack_serializer#sorting
I think this is the find by ID here doesn't preserve the order of records in the ids array.


Daily updates from ghcnd

I have uploaded the code for the update of the daily files. The code downloads the daily diff file from ghcnd and then converts the insert.csv (new daily values) to the CDM formatted tables and saves in level 2 [/gws/nopw/j04/c3s311a_lot2/data/level2/land/daily_updates/]. The second peice of code deletes the unwanted processed .gz file once processed. I have tested the code on JASMIN and it runs fine [/gws/nopw/j04/c3s311a_lot2/data/level0/land/daily_data_processing/ghcnd_diff_updates/code/]. I want to set up the CRON job to run these jobs daily and stop using AK conversin codes. So before I do that can you please check over the code and make sure I have'nt missed an error?

Note - currently not using approach in updated daily CDM conversion scripts (#37).  Include these dictionaries when refactoring.
(code in PYTHON_CDM_Conversion_code/daily_updates_processing)

The bit of code which identifies the most recent daily diff file - that currently spins through all files on the FTP server, so takes a while.  Is it just wanting the most recent file (so we could take that as the end one in a sorted list, and ignore the time aspect), or is it wanting the files which have appeared on the server since the most recent run of the script?

It searches for the most recent daily_diff file on the ftp server and then checks to see if it exists using last_file.txt if it is new it convrets if not it ends. Sometimes it doesnt produce a new file every day and ometime sgroups sevreal days together to catch up.

Cool, so just wanting the most recent.  Could use the naming convention which has a YYYYMMDD in it to pick up the most recent (presuming that there's no strange out of sequence infilling).
Would there ever been the reason to get a few daily diff files at once?

No , always only one diff file

the delete.csv removes the processed insert.csv file so we dont have issues with overwriting etc.
Thanks for doing these edits.

The delete......py file does the delete - that makes sense.  I just wanted to make sure that the delete.csv which is in the superghcnd...tar.gz file doesn't need processing - as I presumed it removes observations that had been included but are no longer part of the record, and by extension the update.csv would update values in the record.

Ah ok i understand what you mean, no the delete.csv and update.csv are not processed . The delete.py removed the processed .csv files.

Will leave in current directory and close issue via PR.  Any errors to be raised as new issues in due course.


How to configure onEnterRules for language config?

I'm trying to add functionality to Dart Code that automatically inserts ///  for you if you're typing a comment; eg.:
/// this is a comment[<enter here>]

Should result in:
/// this is a comment
/// [cursor here]

There are some properties on the LanguageConfiguration interface that look like they're to support this (onEnterRules), but I've been playing around and been unable to make them work. I can't find any existing code that uses these, so I'm not entirely sure they're supposed to be used like this. If not, is there another way to achieve this?
I've noticed TypeScript automatically inserts * when I'm typing a multiline comment; but I can't find the code/config that's causing that.
An example of what I've tried in my language config:
"onEnterRules": [
	{
		"beforeText": "/\/\/\/ /g",
		"action": {
			"indentAction": "None",
			"appendText": "/// "
		}
	}
]

@DanTup
example: https://github.com/Microsoft/vscode/blob/master/extensions/typescript/src/typescriptMain.ts#L163
for your use-case:
languages.setLanguageConfiguration(modeId, {
...
	onEnterRules: [
		{
			beforeText: /^\/\/\//,
			action: { indentAction: IndentAction.None, appendText: '/// ' }
		}
	]
...
});

The onEnterRules are not at this point read from the language configuration file. We need to figure out how to serialize/deserialize a regex without ambiguity yet from JSON.

@alexandrudima Excellent, thank you! I did search GH for onEnterRules trying to find it in code (suspecting a regex json issue) and didn't find it; hwoever I can see loads now, so maybe I pasted it badly! :(
Closing this as I think it's answered then :+1:


[Snyk] Upgrade @testing-library/jest-dom from 5.16.2 to 5.16.5

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.2 to 5.16.5.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 3 versions ahead of your current version.
The recommended version was released 2 months ago, on 2022-08-04.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

outdated


FreeRDP issue on Windows Server 2016 with latest patch update

I am using freerdp to connect to a Windows Server 2016 machine. It was working fine before, but after certain security patch updates on the machine, I am no longer able to take remote connection. The connection works through mstsc but not through freerdp.
Free RDP version used : 2.2.0
Environment : Windows Server 2016
Patches applied : kb4593226, kb4535680, kb4598243, kb4593226, kb4535680, kb4598243, kb4593226, kb4535680, kb4593226, kb4535680, kb4598243, kb4535680, kb4598243, kb4593226, kb4535680, kb4598243, kb4593226, kb4535680, kb4598243, kb4593226, kb4535680, kb4598243
Does any of these patches have any breaking changes related to FreeRDP?
Kindly help.

@AKN1988 well, could you add some log output from freerdp and also check if it works with nightly/master ?
We don´t have seen any such issue until now, but who knows ^^

Just verified, connection to a server 2016 machine (not in a domain) works on our end (latest patch level)

Hi, I can't connect to Windows 2016 either, tried the following form on Ubuntu 20.10, with a server that works using Windows rdp:
xfreerdp /u:CONTOSO\JohnDoe /p:Pwd123! /v:rdp.contoso.com
and it fails, saying "failed to connect to rdp.contoso.com"
Can you give a typical command line for a Windows 2016 connection that works? Thanks

@surrocat you just have one. the error sounds more like your DNS can not resolve your host? but without a log that is hard to tell.

I just tried with the actual IP address of the Windows server instead of 'rdp.contoso.com' and got exactly the same error.

PS the Windows server has DTLS enabled. On Windows I had to install KB2574819 and KB259268 in 2018 to get rdp to connect.

@surrocat I´m still tapping in the dark, could you add some log (as requested by the issue template and, just above myself)? Your description is too generic to give you specific answers.

I just tried with the actual IP address of the Windows server instead of 'rdp.contoso.com' and got exactly the same error.

Is there a way to add logs? If yes can you share some sample and that will be helpfull

This was the output:
ben@ben-desktop:~$ xfreerdp /u:CONTOSO\JohnDoe /p:Pwd123! /v:xxx.xx.xxx.xx
[12:42:12:003] [2633:2634] [INFO][com.freerdp.core] - freerdp_connect:freerdp_set_last_error_ex resetting error state
[12:42:12:004] [2633:2634] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpdr
[12:42:12:007] [2633:2634] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpsnd
[12:42:12:007] [2633:2634] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[12:42:13:275] [2633:2634] [INFO][com.freerdp.primitives] - primitives autodetect, using generic
[12:42:13:286] [2633:2634] [INFO][com.freerdp.core] - freerdp_tcp_is_hostname_resolvable:freerdp_set_last_error_ex resetting error state
[12:42:13:287] [2633:2634] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[12:42:28:302] [2633:2634] [ERROR][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex ERRCONNECT_CONNECT_FAILED [0x00020006]
[12:42:28:302] [2633:2634] [ERROR][com.freerdp.core] - failed to connect to xxx.xx.xxx.xx
ben@ben-desktop:~$
It reminds me of the error Windows 7 gave in 2018 (see jpg) which is why I suspect problems with DTSL (does FreeRDP support it?

@surrocat DTLS you mean? That is only for extensions (UDP transport for certain RDP channels) which we do not support. But what you see here happens way earlier.
This is, as suspected, an issue that the server is not listening on 3389.
btw, which jpeg do you mean?

DTLS yes, Windows 7 also said it can't connect but it was solved by installing the KB's mentioned.

@surrocat this is a server configuration issue then, sorry.

@surrocat simple test, check if TCP port 3389 is open on the server

The solution in 2018 did not involve changes in the server, only updating the Windows 7 client by KB2574819 and KB259268. Will try to ask about ports...

https://support.microsoft.com/en-us/topic/an-update-is-available-that-adds-support-for-dtls-in-windows-7-sp1-and-windows-server-2008-r2-sp1-2c0e25cd-e8ff-968b-4aff-3729a3a5f7db
explains it a bit. If the clients support UDP then this is required for windows 7, yes.
But disabling TCP will break lots of stuff (think frewalls/NAT/... that do not like to forward UDP traffic for random applications)
From the log I infer that exactly that is the case for your server.

Ok thanks. Unfortunately, as a user/client I have no influence on the server side, so I am stuck...
It means that FreeRDP and Windows RDP have diverged in 2018 and are not compatible.

@surrocat your conclusion is a bit misleading.
FreeRDP and windows RDP are perfectly compatible, but your server is configured in a non compatible way.
(it uses an extension that clients may support and deactivates the common case most clients use or need to fall back on when the connection does not support UDP)

I understand that introducing udp may not be optimal from our point of view. But Microsoft have decided to implement it and most IT departments probably just follow their changes in setting up the server. I had no luck in convincing them to go back to the previous way of doing things.

@surrocat no, that is not the point. not seen any server configured as strangely as yours to be honest, because that feature is optional and can be enabled without shutting out all other clients. You need to walk the extra mile disabling the traditional way to achieve that ;)

@akallabeth The server has been set up like this since 2018 following a Windows update, and on my side the updates made Windows 7 connect immediately (no changes to Firewall required). It has been running smoothly ever since. I don't think it is an exceptional configuration.
Can you explain what is the crucial setting on the server side that changed in 2018?
There must be many more FreeRDP users having that problem (maybe without knowing the reason), and it seems to have been requested before https://github.com/FreeRDP/FreeRDP/issues/4978, so I'm asking if we can please have a "Windows Compatibility" option?
Certainly it would help in order to make FreeRDP/Ubuntu more versatile and widely adopted. Many thanks for looking into this!

@surrocat you seem to misunderstand.
The transport is either TCP Only or TCP or UDP.
So, if UDP is successful that is used, otherwise TCP is used.
There is no crucial setting as all our test VM with server 2016, 2019, ... run quite fine (even with TCP or UDP  enabled)
UDP uses different ports though, so maybe that is the problem with your server. (in fact, I´ve never heard nor seen a problem such as yours)
The fact that you needed to update your windows 7 clients confirms my suspicion, as that should not have been necessary. (only the NLA hotfix a few years back did break authentication on strict configured servers)
The updates for windows 7 are only required to enhance speed and support more modern drawing, not to allow connection at all
So, in short, this has nothing to do with FreeRDP not being compatible but some configuration on your server. (all the docs say that TCP 3389 is still the main transport for RDP)
Of course, UDP transport (as in #4978 ) would be a nice to have thing, but we´re currently busy with more important stuff than some optional enhancement. (but we´ll always accept pull requests ;))
Only setting I know of is this one: https://admx.help/?Category=Windows_10_2016&Policy=Microsoft.Policies.TerminalServer::TS_SELECT_TRANSPORT


Different hex code than in Sketch color panel

Hi, and thank you for this nice plugin!
I noticed that hexadecimal values are sometimes different between Sketch color palette, and the palette artwork generated by Prism.
For example:

rgb(72, 119, 143) is hex coded as #48778F by Sketch, and coded as #48768F on the palette artwork generated by Prism.
rgb(184, 214, 230) is hex coded as #B8D7E6 by Sketch, and coded as #B7D6E5 on the palette artwork generated by Prism.

Is it possible to ensure that all codes are the same between Sketch and Prism?
Thanks a lot!

Wow, that one was hard to spot, @giuseppebergman!
The hex values are actually calculated by Sketch, so we don't really know whats going on there. 👎
I think the best way to solve this is to calculate the hex values ourselves based on the rgba values. We'll try to fix it a soon as possible!

Well, I have to align my client's development color palette with my design palette. As we usually share hex values, the bug was spotted pretty quickly…
Anyway, thanks for looking into it even if it's Sketch's mess!

Any progress on the issue?
It's bothering our designer :) and the export to Android xml is incorrect because it's using those hex values.
Thanks.

Hello, guys!
The hex color export is now fixed. Please make sure to test the latest release and reach out if you find something else. 😃


[Proposal] Introduce a notion of verifiable objects

💥 Proposal
It is currently not easy to immediately tell if an object has been verified or not (examples: https://github.com/AleoHQ/snarkVM/pull/990, https://github.com/AleoHQ/snarkVM/pull/1011). This could be solved with types, which would provide a zero-cost way to enforce the verification of objects where necessary, and do so in a very clear way.
The simplest way of achieving it would be with a wrapper type:
pub struct Verified<T>(T);

impl<T> AsRef<T> for Verified<T> {
    fn as_ref(&self) -> &T {
        &self.0
    }
}

impl<T> Verified<T> {
    pub fn into_inner(self) -> T {
        self.0
    }
}

pub trait Verifiable where Self: Sized {
    type Error;

    fn verify(self) -> Result<Verified<Self>, Self::Error>;
}

however, this approach would be limited, as the applicable types would need to have extra variants to ensure that their members have been verified as well (e.g. enforcing verified transactions within a verified block). The right way:tm: to do this is using marker types (playground link):
use anyhow::Result; // for API compatibility with snarkVM
use std::marker::PhantomData;

// The trait allowing objects to be marked as either unverified or verified.
pub trait MaybeVerified {}

// A marker type indicating that an object had been verified.
pub struct Verified;
// A marker type indicating that an object had been unverified.
pub struct Unverified;

impl MaybeVerified for Verified {}
impl MaybeVerified for Unverified {}

// A simplified Transaction object; the _verified marker would be added to the
// regular Transaction object (and all of its members that require verification,
// if lower-level granularity is desired).
struct Transaction<V: MaybeVerified> {
    _verified: PhantomData<V>,
}

// This impl (and the one for the Block), could be derived automatically with
// a proc macro.
impl Transaction<Unverified> {
    pub fn into_verified(self) -> Transaction<Verified> {
        Transaction {
            _verified: Default::default(),
        }
    }
}

// This definition forces all the members of Block to be either Unverified
// or Verified, making the entire object consistent in terms of verification.
struct Block<V: MaybeVerified> {
    transactions: Vec<Transaction<V>>,
}

// This assumes that the Block is marked as verified all at once, but if it were
// to be destructured upon verification, it could be done in a more fine-grained
// fashion.
impl Block<Unverified> {
    pub fn into_verified(self) -> Block<Verified> {
        Block {
            transactions: self.transactions.into_iter().map(|tx| tx.into_verified()).collect(),
        }
    }
}

// A simplified Ledger object to simulate the current snarkVM API.
struct Ledger;

impl Ledger {
    // Any method returning verifiable objects from the Ledger would return
    // either a reference or the value of Object<Verified>, as them being a
    // part of the Ledger means they had already been validated upon insertion.

    // Any method validating an object with the Ledger would expect an
    // Object<Unverified> (taken by value) and return an Object<Verified>.

    // Any method introducing a new object to the Ledger would expect an
    // Object<Verified>.

    // Any method where the verification state of a verifiable object is
    // irrelevant can just be generic over MaybeVerified.

    // An obvious candidate for this change: checking an unverified block and
    // marking it as verified if it passes all the checks.
    pub fn check_next_block(&self, block: Block<Unverified>) -> Result<Block<Verified>> {
        // Perform block checks.

        // Mark the block as verified.
        let verified_block = block.into_verified();

        Ok(verified_block)
    }

    // Another obvious candidate: note that the transaction is expected to have
    // been verified at this point.
    pub fn add_to_memory_pool(&mut self, transaction: Transaction<Verified>) -> Result<()> {
        // This method can safely assume that all the transaction-specific
        // checks have already been performed.

        // Perform any memory-pool-specific checks and insert the transaction.

        Ok(())
    }
}

At the little extra cost of complexity (an extra trait and marker types) we'd gain:

safety (as it would no longer be ambiguous if an object has been verified or not)
greater performance (duplicate checks could easily be found and removed)
potential for even greater performance in the future (e.g. if verified objects could keep components like proofs in their serialized form when retrieved from own database, reducing deserialization-related penalties)

I'd be happy to lead this change if this proposal is accepted.

This is no longer applicable to snarkVM, and the current logic in snarkOS doesn't leave much room for accidental double verification, so the issue can be closed for now.


Unable to sign into the app

I am not able to get past the login screen ,getting this -
"com.google.android.gms.common.api.ApiException: 10"
I searched this and found that @plazzy99 you need to update the SHA1 in the firebase console of this app.

join our discord channel


"The specified engine (ID stable-inpainting-512-v2-0) was not found."

I'm trying to render something using the 2D animation mode
as soon as I use a zoom setting I get this error on rendering.
It's as if the internal render is delegating to another model to handle inpainting when the 2D camera zooms in or out, to fill the scene
[pid 35202] [jobid j-0109-015750]:   2%|█▎                                                              | 1/50 [00:04<03:48,  4.65s/it]Received RpcError: <_MultiThreadedRendezvous of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "The specified engine (ID stable-inpainting-512-v2-0) was not found."
	debug_error_string = "UNKNOWN:Error received from peer ipv4:<IP_ADDRESS>:443 {created_time:"2024-01-09T01:57:56.417588-05:00", grpc_status:5, grpc_message:"The specified engine (ID stable-inpainting-512-v2-0) was not found."}"

full configs
using model: stable-diffusion-512-v2-1
img resize for JPG ./revel-images/fusion/sabet/sabet-yellow-girl.jpg
skip resize
inpath contains "mp4" skip resize ./outputs/temp.mp4
completed downloading files
image: ./revel-images/fusion/sabet/sabet-yellow-girl.jpg
video: ./outputs/temp.mp4
using video_init_path: ./outputs/temp.mp4
using init_image: ./revel-images/fusion/sabet/sabet-yellow-girl.jpg
safe_image: ./revel-images/fusion/sabet/sabet-yellow-girl.jpg
animation_settings:
{
  width: 512
  height: 512
  cfg_scale: 12
  sampler: 'DDIM'
  model: 'stable-diffusion-512-v2-1'
  seed: -1
  clip_guidance: 'None'
  init_image: './revel-images/fusion/sabet/sabet-yellow-girl.jpg'
  init_sizing: 'cover'
  mask_path: ''
  mask_invert: false
  animation_mode: '2D'
  max_frames: 50
  border: 'replicate'
  noise_add_curve: '0:(0.02)'
  noise_scale_curve: '0:(1.1)'
  strength_curve: '0:(1), 10:(0.4), 40:(0.4), 49:(0.2)'
  steps_curve: '0:(20)'
  steps_strength_adj: true
  interpolate_prompts: true
  inpaint_border: true
  locked_seed: false
  angle: '0:(0)'
  zoom: '0:(1),50:(0.5)'
  translation_x: '0:(0)'
  translation_y: '0:(0)'
  translation_z: '0:(-0.2)'
  rotation_x: '0:(0)'
  rotation_y: '0:(0)'
  rotation_z: '0:(0)'
  diffusion_cadence_curve: '0:(2)'
  cadence_interp: 'rife'
  cadence_spans: false
  color_coherence: 'LAB'
  brightness_curve: '0:(1.0)'
  contrast_curve: '0:(1.0)'
  hue_curve: '0:(0.0)'
  saturation_curve: '0:(1.0)'
  lightness_curve: '0:(0.0)'
  depth_model_weight: 0.3
  near_plane: 200
  far_plane: 10000
  fov_curve: '0:(25)'
  save_depth_maps: false
  depth_blur_curve: '0:(0.0)'
  depth_warp_curve: '0:(1.0)'
  video_init_path: './outputs/temp.mp4'
  extract_nth_frame: 1
  video_mix_in_curve: '0:(0.2), 10:(0.3), 40:(0.3), 49:(1)'
  video_flow_warp: false
  vr_mode: false
  vr_eye_angle: 0.5
  vr_eye_dist: 5.0
  vr_projection: -0.4
  resume_timestring: ''
  override_settings_path: ''
  non_inpainting_model_for_diffusion_frames: false
  do_mask_fixup: false
  save_inpaint_masks: false
  mask_min_value: '0:(0.0)'
  fps: 10
  camera_type: 'perspective'
  image_render_method: 'mesh'
  image_render_points_per_pixel: 8
  image_render_point_radius: 0.006
  image_max_mesh_edge: 0.1
  mask_render_points_per_pixel: 4
  mask_render_point_radius: 0.0045
  mask_max_mesh_edge: 0.04
  use_inpainting_model: true
  mask_binarization_thr: 0.5
  verbose: true
  accumulate_xforms: false
  midas_weight: 0.3
  negative_prompt: 'blurry, bad hands, ugly, wrinkles'
  negative_prompt_weight: -1
  preset: ''
  color_match_animate: ''
}


docs: Add additional way to signoff commits

Adds an additional way to signoff commits within CONTRIBUTING.md

Closing this loop: https://github.com/project-copacetic/copacetic/pull/750#issuecomment-2305338762

Also, I leveraged git rebase -i HEAD~4 --signoff to get a signoff on all of my commits as I did not know about the DCO. Perhaps this would be a good addition for https://github.com/project-copacetic/copacetic/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what?

yes! I think it would be good to document this