Proposal: add produce, which is an ALIAS of create.

The basic syntax is the same, so when changing from immer to mutative, it is only necessary to replace the import statement.
I haven't looked at the source code, but I think it would be as simple as adding the following one sentence.
export const produce = create;

import statement of immer in v9
import produce from "immer";

import statement of immer in v10
import { produce } from "immer";

If produce can be used instead of create, it will work for most patterns for v10 immer that do not use immer's special features.

I read the documentation and learned that there is a wrapper called mutative-compat. Sorry for creating the issue without reading the documentation.
However, I also feel that my project does not want to include the wrapper as a dependency.

How do you feel about adding such an API for quickly migrating from Immer to Mutative?
- import { produce } from "immer";
+ import { produce } from "mutative/migrate-immer";

It is important to note that Immer and Mutative have significant differences in their configurations, and therefore they cannot be considered completely equivalent.

I think it is an excellent proposal.
If implemented, it would make the transition easier.
I think a lot of people, myself included, are using just "produce". I think it would be great if just changing the library would increase the processing speed.

hi @exuanbo , it might be possible to implement a migration API similar to mutative-compat in Mutative. What are your thoughts on this?

@exuanbo I'll probably be working on the proposal using mutative-compat over the next few days. If you've got any thoughts or feedback, don't hesitate to reach out anytime.


Account Details DataConnect - Large Amounts of 304s

Hello,
After an Ellucian conference, the Account Details card was advertised to some of our management as a production ready card.
I have since implemented it into our experience portal, along with the associated data connect API. The card and data connect API appear are working. We tested them quite thoroughly in our test environment
However, after releasing it to production, we are getting an overwhelming amount of 304 errors on our Ethos Integration Reports page.
First I tried to contact Ellucian Support, but they're not able to reproduce the issue and have asked me to try to contact you as to where the 304 errors are coming from, as well as how we could address them.
The case number for our support case is CSC03432766
Here is an example of the errors we are getting in our report page:

we are receiving an overwhelming amount of these, and it's making it a challenge to find errors from other parts of our domain.

Not sure who told you it was "production ready". That term might mean different things to different people. It is in a repo named experience-ethos-examples. We expect them to work, but they are not officially supported.
A few of our managers went to an Ellucian conference in the spring, and there apparently were demonstrations of these cards and they were telling our managers they were production ready.
it looks like the har only includes successful calls to the API. Have you been able to duplicate it with a browser? Or are you just seeing it in the Ethos logs?
We are only seeing it in the Ethos logs. Whenever we try to test the functionality of the card myself it works, we have also not seen reports from any of our students or staff having problems.

Has this case CSC03432766 been resolved?

@ellucianBret
No, we're still receiving lots of errors, and we really do not know if the errors come from the BPAPI, or from the data-connect resource.
It doesn't seem to affect the results of the response from the query either, as like I said we have received no reports of the card not working for users. We just get an overwhelming amount of errors in our logs.

@ellucianBret
I dove into the source code on github this week a bit. Specifically ellucian-developer/experience-extension-extras since the Account Details card uses the UserDataConnectQuery.
Since this repository uses react-query to make queries, I found this. React Query - query is not using cache? - Stack Overflow
I confirmed the repo project doesn't appear to be setting a staletime, so requests are always being made even though by default caching is enabled.
This, combined with Data Connect throwing 304s every time the same request is made from the same user, means that every time a page refreshes that the Report log gets extremely cluttered.
I don't believe this is intended behavior, and if it is I think it should be reconsidered. It doesn't make sense to me to allow caching, but making the request anyways, and it doesn't really make sense that 304 Not Modifed errors should be showing up in our Report Errors tab due to this functionality. At the very least, it should be togglable.


gevent UnicodeError

Hello,
I'm developing a pyramid app, using gevent 1.1rc3 and gevent-socketio 0.3.6 .
I get the following error:
  File "........../python2.7/site-packages/gevent-1.1rc3-py2.7-linux-x86_64.egg/gevent/pywsgi.py", line 748, in start_response
    raise UnicodeError("The value must be a native string", header, value)
UnicodeError: ('The value must be a native string', 'Access-Control-Max-Age', 3600)
<Greenlet at 0x7f23bf614b90: _close_when_done(<socket at 0x7f23be97bd90 fileno=[Errno 9] Bad fil, ('<IP_ADDRESS>', 60882))> failed with UnicodeError

This may be resolved by changing the line
("Access-Control-Max-Age", 3600), to ("Access-Control-Max-Age", '3600'), in the two files,
..../site-packages/gevent_socketio-0.3.6-py2.7.egg/socketio/handler.py and
..../site-packages/gevent_socketio-0.3.6-py2.7.egg/socketio/transports.py.
Can this UnicodeError be prevented to begin with?
Thank you,
Iftach.

I am also having this problem, and additionally had to change ('Content-Length', 0) to ('Content-Length', '0') in handler.py

+1
Temporarily solved downgrading to gevent==1.0.2

Hey again.
Will this be fixed in a future version?
Testing gevent 1.3.3 (specifically, gevent-1.3.3-py2.7-macosx-10.13-intel.egg), this problem still exists.


chore(ci): fixing automated releases

Hoping this pushes a version bump

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update README.md

Seems like a mistake here since all the other keybinds are the correct equivalent

Thanks!


Global Retailers Analysis

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Global Retailers Analysis
:red_circle: Aim : Analyse the global retailers using different aspects.
:red_circle: Dataset : https://www.kaggle.com/datasets/dhimananubhav/global-top-250-retailers
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' and 'JWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID (If not, then put NA) :
Approach for this Project :
What is your participant role? (Mention the Open Source Program name. Eg. HRSoC, GSSoC, GSOC etc.)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Hello I would like to work on this project. Please assign it to me
Full name : Yevale Snehal Dilip
GitHub Profile Link : https://github.com/snehal1024
Participant ID (If not, then put NA) : NA
Approach for this Project : I would first try 3-4 algorithms to find out the best fitted algorithm for the model by checking the accuracy scores.
What is your participant role? - Contributor

Issue assigned to you @snehal1024

Full name : Chandana sri
GitHub Profile Link : https://github.com/chandana62
Participant ID (If not, then put NA) : NA
Approach for this Project : I would first try 3-4 algorithms to find out the best fitted algorithm for the model by checking the accuracy scores.
What is your participant role? - Contributor
Please assign me this issue

I would like to give a try on this project. Please assign it to me

Issue assigned to you @chandana62

Unassigned. ML-Crate is going to be part of DWOC from Jan, 15, all the unfinished issues will be taken by the contributors of DWOC.

Hi !! @abhisheks008
I would like to take this issue.
Full name : Mariam
GitHub Profile Link : https://github.com/mariam7084
Participant ID (If not, then put NA) : NA
Approach for this Project : perform EDA and visualization to find insights in data
What is your participant role? JWoC 2024

Assigned @mariam7084


Implement validator list screen

Renamed AppRoutes.Validator to AppRoutes.Validators
Scaffolded ValidatorScreen
Added dummy data to the screen
Refactored Table and Sectioned Table component
Adjusted PageController layout

Aligned the height of the page numbers
Prevent overflow when the window size is too small

Screenshots

Desktop
Mobile

refs #302

on mobile a bit hard to notice that the table is scrollable, might want to some indicator 🤔

@hochiw the page switcher overflows on mobile?

& currently the sort state is not stored in query param?

& currently the sort state is not stored in query param?

handled this in the api integration pr

@mitchellchou @koskosm
Need some advice 🙏  I have adjusted the page controller and make it so that it only display at most 1 adjustment page number (library constraint, can't show less, which I think makes sense), but it still won't fit in the mobile view

What about remove "Previous" & "Next" text

What about remove "Previous" & "Next" text

can 🚀

@chihimng Updated 🙏 also retook the mobile screenshot with the suggested adjustment

@hochiw can we fix the position of the arrow buttons? flex justify space-between?
https://user-images.githubusercontent.com/11769136/180755077-63d4003a-9bfd-4c72-8e62-a99e052e80ae.mov

@hochiw can we fix the position of the arrow buttons? flex justify space-between?
Screen.Recording.2022-07-25.at.6.21.21.PM.mov

Updated, although it might look wider

@hochiw will we also update for other pagination widgets (e.g. proposal list), I think they all have the same issue

@hochiw will we also update for other pagination widgets (e.g. proposal list), I think they all have the same issue?

It's a shared component so I think so

on page switcher:

can we show more pages if there is space left? (can ignore if time consuming)
usually on click ... it brings user to the middle of the range, not 1 page before/after?

spacing between nav bar to "validators" heading, and between heading to tab bar is too large?

@chihimng

can we show more pages if there is space left? (can ignore if time consuming)

It seems if we make the pageRangeDisplayed and marginPagesDisplayed props dynamic it would go seizure when we resize the window :sosad:

usually on click ... it brings user to the middle of the range, not 1 page before/after?

added a commit to handle this

spacing between nav bar to "validators" heading, and between heading to tab bar is too large?

miscalculated the margin, adjusted


Allow opening rust-analyzer on a single file

Currently, code x.rs (where x.rs is any self-contained source file) gives the error Cannot activate rust-analyzer: no folder is opened. It would be nice to have this work if x.rs doesn't require any external dependencies. That would allow running rust-analyzer even on projects not using cargo.

Note that there is a way to run rust-analyzer on projects not using cargo, but it's probably not easier than making a Cargo.toml: https://rust-analyzer.github.io/manual.html#non-cargo-based-projects.

Those docs are intended for using some build system other than cargo, like x.py or bazel or something. I'm asking for support for very small projects that have no dependencies, only a single rust file.

Another use case would be for org-babel the emacs + org-mode literate programming environment that creates files in temp and enables users to write short snippets. Adding rust-analyzer support for individual files would be great for this as well.

Can rust-analyzer not just default to the directory containing Cargo.toml as cargo would?

@jomala this is for projects not using cargo, where there is no Cargo.toml file.

The error I was receiving was: [rust-analyzer unlinked-file] [E] file not included in module tree, and due to this linting was not working while trying to edit a single main.rs file in my home directory.
I resolved the issue by creating a file named rust-project.json alongside my main.rs file with the contents:
{
    "sysroot_src": "/home/<YOUR-USER>/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library",
    "crates": [
        {
            "root_module": "main.rs",
            "edition": "2018",
            "deps": []
        }
    ]
}

@zzzachzzz this works for me with the exception of editing new files.


Debug drawer widgets should be updated onResume to keep in sync with SharedPreferences

If you go to a second activity (ensuring that the previous activity is not destroyed), and change a setting in the debug drawer (such as latency), then go back to the first activity, the UI widgets in the debug drawer get out of sync with the preferences that back them since the widgets are only initialized in onCreate().
I've worked around this in my application by removing the @Singleton annotations from the DebugAppContainer class and the module that provides it, and adding a second method bind() so the interface for AppContainer looks like this:
ViewGroup get(Activity activity);
void bind(Activity activity);

Then I call bind() in onResume of my activity.
This adds a fair amount of complexity but is kind of necessary.
Please let me know if you're interested in a PR.

We're adding observable preferences. Started in #116 and see also https://github.com/JakeWharton/NotRxAndroid/issues/8.


PackageInvite: activation and confirmation.

#1759

I slightly prefer this one over #1848. I feared that it will be more complex, but it ended up not too bad.


get some error about SUBSCRIBE renewal

events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: SUBSCRIBE renewal error
    at ClientRequest.<anonymous> (upnp-mediarenderer-client/node_modules/upnp-device-client/index.js:234:25)

Got some error at those, but hasn't idea to fix this, need some help ,thanks

 var req = http.request(options, function(res) {
            if (res.statusCode !== 200) {
                console.log(err)
                var err = new Error('SUBSCRIBE renewal error');
                err.statusCode = res.statusCode;
                // XXX: should we clear the subscription and release the server here ?
                //self.emit('error', err);
            }

Hi. Please post minimal code to reproduce your issue and use github code formatting. Thanks !

Update issue already, Thank you.

I deal also with this error and do not know how do handle it properly. Maybe someone can help.
My case:

subscribe to an event (renewTimeout is 30 minutes)
set the PC to sleap
wake up the PC after 35 minutes
the following error is thrown (statusCode: 412)

My question is, what do I have to do, to have a working event subscription back? How to re-initiate the subscription after I get this error?
{"level":"warn","message":"[UpnpPlaybackDevice] upnpDevice error { Error: SUBSCRIBE renewal error\n    at ClientRequest.<anonymous> (C:\\Apps\\Styrit Music\\prod-libs\\node-upnp-device-client\\index.js:234:25)\n    at Object.onceWrapper (events.js:315:30)\n    at emitOne (events.js:116:13)\n    at ClientRequest.emit (events.js:211:7)\n    at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:551:21)\n    at HTTPParser.parserOnHeadersComplete (_http_common.js:115:23)\n    at Socket.socketOnData (_http_client.js:440:20)\n    at emitOne (events.js:116:13)\n    at Socket.emit (events.js:211:7)\n    at addChunk (_stream_readable.js:263:12) statusCode: 412 } StatusCode: 412","timestamp":"2018-03-28T06:48:29.459Z"}
Thanks, George


Correction for raw affiliation Ethical approval: The human subjects research described in this Perspective was approved by American Institutes for Research's Institutional Review Board IRB00000436 on August 11, 2015, project EX00356.; L.A. Cooperis professor of medicine and director, Johns Hopkins Center to Eliminate Cardiovascular Health Disparities, Johns Hopkins University School of Medicine and Johns Hopkins University Bloomberg School of Public Health, and vice president for health care equity, Johns Hopkins Medicine, Baltimore, Maryland.; Other disclosures: None reported.

Correction needed for raw affiliation Ethical approval: The human subjects research described in this Perspective was approved by American Institutes for Research's Institutional Review Board IRB00000436 on August 11, 2015, project EX00356.; L.A. Cooperis professor of medicine and director, Johns Hopkins Center to Eliminate Cardiovascular Health Disparities, Johns Hopkins University School of Medicine and Johns Hopkins University Bloomberg School of Public Health, and vice president for health care equity, Johns Hopkins Medicine, Baltimore, Maryland.; Other disclosures: None reported.
raw_affiliation_name: Ethical approval: The human subjects research described in this Perspective was approved by American Institutes for Research's Institutional Review Board IRB00000436 on August 11, 2015, project EX00356.; L.A. Cooperis professor of medicine and director, Johns Hopkins Center to Eliminate Cardiovascular Health Disparities, Johns Hopkins University School of Medicine and Johns Hopkins University Bloomberg School of Public Health, and vice president for health care equity, Johns Hopkins Medicine, Baltimore, Maryland.; Other disclosures: None reported.
new_rors: 037zgn354;00za53h95
previous_rors: 037zgn354;00za53h95;00490n048
works_examples: W2604575419
contact: 044553cc8d592f09b34028482e88272e:0415f5d8ab2085 @ air.org

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Set z-order for individual data points / markers

Is your feature request related to a problem? Please describe.
I have a Plot (Scatter/Line) with many DataPoints. I use fillcolor to modify the color of each point individually. As the points are close to each other, it is likely, that they cover each other.  Some DataPoints are more important, so I want to stress them. I managed to set the size and the opacity for each DataPoint / Marker, but I was not able to put the more important DataPoints in the foreground.
Describe the solution you'd like
Setting the z order of markers / DataPoints by giving a number, which is automatically ordered. Maybe another setting in discrete markers.
Describe alternatives you've considered
Setting the z order of markers / DataPoints by setting a bool, comparable to the position option (https://apexcharts.com/docs/options/yaxis/) but for individual / discrete marker.
Additional context
Add any other context or screenshots about the feature request here.

same issue :(


Non-standard behavior of Promise.prototype.finally

[x] I have reviewed the documentation
[x] I have searched existing issues
[x] I am using the latest React Native version

Environment

Environment:
  OS: macOS High Sierra 10.13.4
  Node: 9.11.1
  Yarn: 1.7.0
  npm: 6.1.0
  Watchman: 4.9.0
  Xcode: Xcode 9.3.1 Build version 9E501
  Android Studio: 3.1 AI-173.4670197

Packages: (wanted => installed)
  react: 16.3.1 => 16.3.1
  react-native: ~0.55.2 => 0.55.4

Steps to Reproduce

https://snack.expo.io/r1wCcj5JQ
Expected Behavior

console: 42
Actual Behavior

console: undefined

I did some digging around, finding that the polyfilled Promise imported from fbjs is not implemented right:
https://github.com/facebook/fbjs/blob/v0.8.16/src/__forks__/Promise.native.js#L18-L23
There is already an issue about this years ago: https://github.com/facebook/fbjs/issues/132
Another related issue: https://github.com/facebook/react-native/issues/17972

I'm currently landing a fix for this.

@cpojer What is the appropriate issue to track to follow this fix?

There is no issue, this was already landed on master last week.

For those looking for the commit like me:
https://github.com/facebook/react-native/commit/d5ae59ab2a09cda5109303abb9c269318a1e6686


Reorganize for CI

In the interest of enabling more granular changes, I think we should merge this now, then make new issues for all the other enhancements so they're easier to track.

In the interest of enabling more granular changes, I think we should merge this now, then make new issues for all the other enhancements so they're easier to track.

I agree. I'd rather go for fast iteration than spend forever making this single PR perfect.


Huawei p8 lite 2017

Minecraft <IP_ADDRESS>, freezing

Welp. There's some Android Driver bugs. Natural Mystic shaders 1.5.0 work tho.

Added Mali-T830MP2 to the list of affected GPUs in #50.
A lot of Android users have reported that the shader pack stopped working when they updated it to 1.6.0. It's likely that some changes I made in 1.6.0 made a driver bug rise up to the surface, but I have no idea what change was problematic.


Unable to create custom GCE cluster with public IP defined

Rancher versions:
v2.0.1.-rc3
Steps to Reproduce:
Create a new custom cluster with GCE hosts.
When adding nodes to rancher on GCE hosts, add external and internal IP address of host.
Results:
Unable to provision cluster.
Failed to apply the ServiceAccount needed for job execution: Post https://<IP_ADDRESS>:6443/apis/rbac.authorization.k8s.io/v1/clusterrolebindings: net/http: TLS handshake timeout

@adingilloRancher how are you adding the external/internal IP address in your docker command?

Sample command used
sudo docker run -d --privileged --restart=unless-stopped --net=host -v /etc/kubernetes:/etc/kubernetes -v /var/run:/var/run rancher/rancher-agent:v2.0.1-rc5 --server https://<IP_ADDRESS> --token kvw47zccc4jqjmkc5dtgz7j7fh2tdq9d5hn4z5zdfdhnh7nj2sw845 --ca-checksum a8e31d874da3cc1e0191a1d48d800edaaeb9696010758cec23c5a6a08692ec17 --address <IP_ADDRESS> --internal-address <IP_ADDRESS> --worker

@adingilloRancher i was managed to get this working. The steps i took:

create a gce instance. Create a custom cluster in rancher.
Specify the public ip and private ip, paste the command to gce instance and execute.
Cluster was created successfully.

Are you testing with the same step? can you please re-verify the bug in the latest release?

Master 6/15/18
Not able to reproduce in latest release.


debug/elf: don't check section size

What version of Go are you using (go version)?
go1.12.7
also reproducible on tip
Does this issue reproduce with the latest release?
yes
What did you do?
https://play.golang.org/p/_5bUxWBh14g
package main

import (
	"debug/elf"
	"fmt"
	"strings"
)

func main() {
	data := "\u007fELF\x02\x01\x010000000000000" +
		"\x010000000000000000000" +
		"\x02\x00\x00\x00\x00\x00\x00\x0000000000\x00\x00\x00\x00" +
		"000\x0000"

	_, err := elf.NewFile(strings.NewReader(data))
	if err != nil {
		fmt.Println(err)
	}
}

What did you expect to see?
no panic
What did you see instead?
panic: runtime error: makeslice: len out of range

goroutine 1 [running]:
debug/elf.(*Section).Data(0x44b2c0, 0x43e300, 0x7f6900, 0x206590, 0x109440, 0x7fb880, 0x0, 0x0)
	/usr/local/go/src/debug/elf/file.go:105 +0x40
debug/elf.NewFile(0x15d640, 0x43e2e0, 0x43e2e0, 0x1293, 0x432070, 0x11)
	/usr/local/go/src/debug/elf/file.go:448 +0x1660
main.main()
	/tmp/sandbox898898450/prog.go:15 +0xa0

Fund with https://github.com/dvyukov/go-fuzz

Thank you for this report @gregory-m!
Kindly paging @tklauser @heschik @aclements.

I'm not really sure how hard debug/elf should work to handle invalid input files.

I have same question as @ianlancetaylor, because I have 2 more panics in different places.

I'm not really sure how hard debug/elf should work to handle invalid input files.

Here is at least one reason why NewFile() should not crash because of invalidated input.
We have a service that extracts BuildIDs from ELF files provided from different sources (distro packages or arbitrary upload from user).
For this we use NewFile() to load the ELF headers and then extract the BuildID from ".note.gnu.build-id" (or for kernel object we use ".notes").
We already saw some crashes of the service (luckily, it automatically recovers =)).
Now I ran into this again while experimenting with the Go fuzzer.
Here are some details, let me know if you prefer a separate issue.
Go built from commit 7e72d384d66f48a78289edc6a7d1dc6ab878f990.
"fatal error: runtime: out of memory" happens at
        /home/tim/src/go/src/debug/elf/file.go:470 +0x1351 fp=0xc0002b76f8 sp=0xc0002b7448 pc=0x5da291

The input file is
e088d7f758b82c73.gz
In line 470 (f.Sections = make([]*Section, shnum), shnum is<PHONE_NUMBER>752.
This crash prevents the fuzzer from going on and finding more/other issues.

The issue reported on the first comment has been fixed on tip. Now it returns an error invalid ELF shentsize '0' in record at byte 0x0 instead of panics.
As for the issue reported by @rockdaboot, maybe we can fix it like this:
diff --git a/src/debug/elf/file.go b/src/debug/elf/file.go
index 708980bc1c..f4592f2cf2 100644
--- a/src/debug/elf/file.go
+++ b/src/debug/elf/file.go
@@ -467,8 +467,12 @@ func NewFile(r io.ReaderAt) (*File, error) {
    }

    // Read section headers
-   f.Sections = make([]*Section, shnum)
-   names := make([]uint32, shnum)
+   safeShnum := 0xfffff
+   if safeShnum > shnum {
+       safeShnum = shnum
+   }
+   f.Sections = make([]*Section, 0, safeShnum)
+   names := make([]uint32, 0, safeShnum)
    for i := 0; i < shnum; i++ {
        off := shoff + int64(i)*int64(shentsize)
        sr.Seek(off, seekStart)
@@ -479,7 +483,7 @@ func NewFile(r io.ReaderAt) (*File, error) {
            if err := binary.Read(sr, f.ByteOrder, sh); err != nil {
                return nil, err
            }
-           names[i] = sh.Name
+           names = append(names, sh.Name)
            s.SectionHeader = SectionHeader{
                Type:      SectionType(sh.Type),
                Flags:     SectionFlag(sh.Flags),
@@ -496,7 +500,7 @@ func NewFile(r io.ReaderAt) (*File, error) {
            if err := binary.Read(sr, f.ByteOrder, sh); err != nil {
                return nil, err
            }
-           names[i] = sh.Name
+           names = append(names, sh.Name)
            s.SectionHeader = SectionHeader{
                Type:      SectionType(sh.Type),
                Flags:     SectionFlag(sh.Flags),
@@ -544,7 +548,7 @@ func NewFile(r io.ReaderAt) (*File, error) {
            }
        }

-       f.Sections[i] = s
+       f.Sections = append(f.Sections, s)
    }

    if len(f.Sections) == 0 {

@ianlancetaylor I will send a CL if you're okay with this solution.

@ZekeLu Thanks, your suggestion looks much better than the hack that I applied here to continue with fuzzing 😄 :
diff --git a/src/debug/elf/file.go b/src/debug/elf/file.go
index 708980bc1c..2b1aaa3938 100644
--- a/src/debug/elf/file.go
+++ b/src/debug/elf/file.go
@@ -466,6 +466,13 @@ func NewFile(r io.ReaderAt) (*File, error) {
                return nil, &FormatError{0, "invalid ELF shentsize", shentsize}
        }

+       // Plausibility check to avoid an unbounded memory allocation.
+       var test [1]byte
+       sr.Seek(int64(shnum) * 40, seekStart)
+       if err := binary.Read(sr, f.ByteOrder, test); err != nil {
+               return nil, err
+       }
+
        // Read section headers
        f.Sections = make([]*Section, shnum)
        names := make([]uint32, shnum)

We've more or less decided that debug/elf should do at least minimal work to avoid panicking on invalid files.  See #47653 and several recent commits to the debug/elf package.
@ZekeLu Since ELF files can have enormous numbers of sections, we should probably use internal/saferio.SliceCap.  In any case, fixing that code is fine.  Thanks.

Ah, I totally forgot that we already have internal/saferio.SliceCap. I will send a CL utilized it soon. Thank you!

The listed issues have been fixed.

I have 2 more panics in different places.

@gregory-m Can you confirm whether the 2 more panics can still be reproduced on go tip?
@gopherbot Please add label WaitingForInfo.

With CL445076 I can't reproduce it.
Thanks for fixing it.


Updated reviewtools.py

Added a skip option to preserve the first skip number of lines. This is needed to make sure we don't change original docstrings. Blank lines now appear between text and codeblocks. Indentation is all automatic based on indentation of first non-blank line. Removed commented out code that is no longer needed.

This contributes towards #77.


Quick menu improvements

Edited marks quick menu to use 'number' option instead of prefixing lines by indexes (which were no longer valid when reordering marks), in the same way as cmd quick menu.
Added 'q' and '' keymaps to cmd quick menu to close the window as in the marks quick menu.
And added  keymap to execute the command under the user's cursor (with a prompt to type the terminal index).
Closes #113

awesome.
Let me read


bAN appeal

the night i was banned was over exaggerated because the staff that told me to change the subject got me banned without even giving me a warning and i think thats unfair, we were all talking about the same subject and i may took it too far without realizing. so if i can talk to someone to explain this more thoroughly that will be cool

Firstly, you were warned this time around before you were banned. However should be of note, although this instance wasn't as severe as your previous instances, you were banned here because you had 3 chances and this was the 3rd. There are only so many chances we can give, and if you haven't learned when to control the things you say by now, there isn't much else we can do here. Appeal has been denied.


[docs] Clarify toggle component labeling options

Summary
Improve the guidance for the large and small toggle options by:

clarifying the labeling options that are available, and
including the reasoning behind the design decision to help users make the right choice.

Page to update:
https://www.carbondesignsystem.com/components/toggle/usage
Per Slack conversation:
https://ibm-studios.slack.com/archives/C0M053VPT/p1563300070300200

Closing, because this has been resolved in our docs


Add nil checks to resource cache

ApplSecret is a caching client so sometimes will return a nil from a GET, which causes
the embedded ObjectMeta to be nil.

/assign @deads2k

golang will make an old man out of me.
/lgtm

/retest-required

/test unit

/test unit


scaleway-sdk-go: http error 400 Bad Request: invalid argument: ttl is required

Hi,
I have some issues with the add-on for scaleway dns challenge. Something with TTL if I understand correctly. Do you have any idea ?
INF ts=1679183349.1156023 logger=tls.obtain msg=obtaining certificate identifier=my.domain.com

INF ts=1679183349.6434329 logger=http.acme_client msg=trying to solve challenge identifier=my.domain.com challenge_type=dns-01 ca=https://acme-staging-v02.api.letsencrypt.org/directory

ERR ts=1679183349.735868 logger=http.acme_client msg=cleaning up solver identifier=my.domain.com challenge_type=dns-01 error=no memory of presenting a DNS record for "_acme-challenge.my.domain.com" (usually OK if presenting also failed)

ERR ts=1679183349.9066288 logger=tls.obtain msg=could not get certificate from issuer identifier=my.domain.com issuer=acme-v02.api.letsencrypt.org-directory error=[my.domain.com] solving challenges: presenting for challenge: adding temporary record for zone "domain.com.": scaleway-sdk-go: http error 400 Bad Request: invalid argument: ttl is required (order=https://acme-staging-v02.api.letsencrypt.org/acme/order/XXX) (ca=https://acme-staging-v02.api.letsencrypt.org/directory)

INF ts=1679183350.806533 logger=http.acme_client msg=trying to solve challenge identifier=my.domain.com challenge_type=dns-01 ca=https://acme.zerossl.com/v2/DV90

ERR ts=1679183350.8876045 logger=http.acme_client msg=cleaning up solver identifier=my.domain.com challenge_type=dns-01 error=no memory of presenting a DNS record for "_acme-challenge.my.domain.com" (usually OK if presenting also failed)

ERR ts=1679183351.042416 logger=tls.obtain msg=could not get certificate from issuer identifier=my.domain.com issuer=acme.zerossl.com-v2-DV90 error=[my.domain.com] solving challenges: presenting for challenge: adding temporary record for zone "domain.com.": scaleway-sdk-go: http error 400 Bad Request: invalid argument: ttl is required (order=https://acme.zerossl.com/v2/DV90/order/XXX) (ca=https://acme.zerossl.com/v2/DV90)

ERR ts=1679183351.0424821 logger=tls.obtain msg=will retry error=[my.domain.com] Obtain: [my.domain.com] solving challenges: presenting for challenge: adding temporary record for zone "domain.com.": scaleway-sdk-go: http error 400 Bad Request: invalid argument: ttl is required (order=https://acme.zerossl.com/v2/DV90/order/XXX) (ca=https://acme.zerossl.com/v2/DV90) attempt=4 retrying_in=300 elapsed=314.517170304 max_duration=2592000

My config :
my.domain.com{
  tls {
    dns scaleway {
      secret_key XXX
      organization_id XXXX
    }
  }
  reverse_proxy {
  	to http://<IP_ADDRESS>:9000
    header_up Host {http.reverse_proxy.upstream.host}
  }
}

Problem solved. Can I suggest adding the dns_ttl in the README. Something like that :
tls {
        dns_ttl 30m
	dns scaleway {
		secret_key {env.SCW_ACCESS_KEY}
		organization_id {env.SCW_ORGANIZATION_ID}
	}
}

I ran into this issue as well. While I am sure that the workaround would work, this prevents me from globally configuring a working ACME provider using Scaleway's DNS. Please reconsider supporting the dns_ttl parameter in the acme_dns block for Scaleway.


Installing On Ubuntu 16.04 lts

Im trying to install polybar but Im getting this message
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
polybar : Depends: libstdc++6 (>= 6) but 5.4.0-6ubuntu1~16.04.4 is to be installed
E: Unable to correct problems, you have held broken packages.

Since you are installing polybar from a repository, someone has already successfully compiled polybar. This is an issue with either your system (see the note about broken packages) or an issue with the packager not listing dependencies properly.


Minor additions to README.md

I changed some of the wording in README.md, also added some additional bullet points in the Note on Patches/Pull Requests secition. I hope this makes it clearer for every one.
PS: This is my first OSF pull request 😃

Thanks for the PR! Would love to get https://github.com/ossfriday/ossfriday/pull/115 landed first and then rebase on top of that.

Thanks @moeabdol, you rock!


Setup ghc api

Description
Hey good folks, this does all the necessary set up to use GHC in the back and front end.
Reviewer Notes
Should the API be false in environments outside of local?
Setup
Make sure http://officelocal:8080/ghc/v1/swagger.yaml and http://officelocal:3000/ghc/v1/swagger.yaml show the yaml files.
make server_run
make office_client_run

I won't be able to see this today but definitely look at https://github.com/transcom/mymove/pull/2788 for hints on stuff I changed (especially the documentation) for the TSP stuff. But at first glance this looks great.


Oracle parameters for tweedle curves, a few bugfixes

This PR includes the oracle parameters for the tweedle curves, a trait QnrField to parameterize the implementation over a choice of quadratic non-residue, a few bug fixes, and a few performance improvements.

Approved


mempool: MPU fault

Describe the bug
There seems to be a bug in mempools bfree_recombine. Commit 1b193e9ece638c0c6f144ce2bee96f1ff268a160 changed partner_alloc_bits(p, level, bn) != 0xf to partner_alloc_bits(p, level, bn) != 0 which results in the following MPU faults in our application:
To Reproduce
Unfortunately I cannot pinpoint the error source in our app to provide a minimal sample.
Expected behavior
No MPU fault.
Impact
showstopper
Screenshots or console output
E: ***** MPU FAULT *****
E:   Data Access Violation
E:   MMFAR Address: 0x0
E: r0/a1:  0x2000160c  r1/a2:  0x00000200  r2/a3:  0x00000000
E: r3/a4:  0x00000000 r12/ip:  0x00000000 r14/lr:  0x00004ec1
E:  xpsr:  0x01000000
E: Faulting instruction address (r15/pc): 0x0000e6f4
E: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
E: Current thread: 0x20000f38 (gMasterTxThreadId)
E: Halting system

Environment (please complete the following information):

OS: Kubuntu 18.04
Toolchain: Zephyr SDK 0.10.13
Commit SHA 57c635587f718078705be763f1aa7e9a1ed328e7

Additional context

@paulgavrikov please add as much info as you can about how you are defining and using the mempool.

If the mempool struct is, for whatever reason, not located in bss, the following change will likely cause a failure: https://github.com/zephyrproject-rtos/zephyr/commit/1b193e9ece638c0c6f144ce2bee96f1ff268a160#diff-e1987e8f6f4f53b4771db2f818b192f4L97.
Try adding clear_alloc_bit(p, 0, i); there and see if doing so resolves the issue; if it does, your mempool struct probably is not located in bss.

If that's true, then we have a bug somewhere underneath sys_mem_pool_init().  Obviously it shouldn't be leaving the heap in an inconsistent state.

On Mon, 25 Nov 2019, Stephanos Ioannidis wrote:

Try adding clear_alloc_bit(p, 0, i); there and see if doing so resolves the issue; if it does, your mempool struct probably is not located in bss.

That's not sufficient for that conclusion.  Adding clear_alloc_bit(p,  0, i) is no longer an equivalent replacement of the former
set_free_bit(p, 0, i) here.
Instead, the following should be attempted:
diff --git a/lib/os/mempool.c b/lib/os/mempool.c
index efca11a203..b8f1b697f0 100644
--- a/lib/os/mempool.c
+++ b/lib/os/mempool.c
@@ -85,6 +85,7 @@ void z_sys_mem_pool_base_init(struct sys_mem_pool_base *p)

 	for (i = 0; i < p->n_levels; i++) {
 		int nblocks = buflen / sz;
+		int j;

 		sys_dlist_init(&p->levels[i].free_list);

@@ -95,6 +96,10 @@ void z_sys_mem_pool_base_init(struct sys_mem_pool_base *p)
 			bits += (nblocks + 31)/32;
 		}

+		for (j = 0; j < nblocks; j++) {
+			clear_alloc_bit(p, i, j);
+		}
+
 		sz = WB_DN(sz / 4);
 	}

@npitre Applying the diff does not fix the issue.
@stephanosio I did a git bisect and it is definitely that commit and particularly the partner_alloc_bits(p, level, bn) != 0 check that causes the issue.
@carlescufi We are not defining our own mempools but we are using the heap through k_malloc and define threads, FIFOs.

On Tue, 26 Nov 2019, Paul Gavrikov wrote:

@npitre Applying the diff does not fix the issue.

OK.

@stephanosio I did a git bisect and it is definitely that commit and particularly the partner_alloc_bits(p, level, bn) != 0 check that causes the issue.

Could you elaborate on that partner_alloc_bits() issue?
Where exactly is the code faulting? If you could convert the fault
address into a code line number, or better yet a gdb backtrace, that
would be very helpful.

@npitre Don't have access to gdb now but here is the code line: https://github.com/zephyrproject-rtos/zephyr/blob/master/include/sys/dlist.h#L497
I haven't bothered to understand mempools bfree_recombine() but there is an if clause there that was changed with above mentioned commit (https://github.com/zephyrproject-rtos/zephyr/blob/master/lib/os/mempool.c#L17)4. It used to check !=0xf but was changed to !=0. All I can say is that if I change the check back to !=0xf the issue disappears. So I am wondering if checking !=0 is the correct way.

On Tue, 26 Nov 2019, Paul Gavrikov wrote:

@npitre Don't have access to gdb now but here is the code line: https://github.com/zephyrproject-rtos/zephyr/blob/master/include/sys/dlist.h#L497

My guess would be corruption of the free list caused by some buffer
overflow somewhere.

I haven't bothered to understand mempools bfree_recombine() but
there is an if clause there that was changed with above mentioned
commit

I do understand that commit and code pretty well.

It used to check !=0xf but was changed to !=0. All I can say is
that if I change the check back to !=0xf the issue disappears. So I
am wondering if checking !=0 is the correct way.

Yes it is. The commit in question simply flipped 0-bits to 1 and 1-bits
to 0, essentially inverting those bit values and keeping the code logic
unchanged. If the actual bit value matters in your case then this might
indicate some corruption of the mempool bitmap by something exterior to
it.
By switching the condition back to !=0xf you're essentially preventing
recombination of small free adjacent blocks into a larger one.
Let me suggest another patch to help find possible overflows:
diff --git a/lib/os/mempool.c b/lib/os/mempool.c
index efca11a203..fdfbf389be 100644
--- a/lib/os/mempool.c
+++ b/lib/os/mempool.c
@@ -229,6 +229,8 @@ int z_sys_mem_pool_block_alloc(struct sys_mem_pool_base *p, size_t size,
 	void *data = NULL;
 	size_t lsizes[LVL_ARRAY_SZ(p->n_levels)];

+	size += 2 * sizeof(uintptr_t);
+
 	/* Walk down through levels, finding the one from which we
 	 * want to allocate and the smallest one with a free entry
 	 * from which we can split an allocation if needed.  Along the
@@ -290,6 +292,15 @@ int z_sys_mem_pool_block_alloc(struct sys_mem_pool_base *p, size_t size,
 		return -ENOMEM;
 	}

+	{
+		uintptr_t *sentinel = data;
+		int end = (lsizes[alloc_l] / sizeof(uintptr_t)) - 1;
+		sentinel[0] = 0xdeadbeef;
+		sentinel[end] = 0xbadbea7;
+		data = sentinel + 1;
+		*data_p = data;
+	}
+
 	*level_p = alloc_l;
 	*block_p = block_num(p, data, lsizes[alloc_l]);

@@ -313,6 +324,16 @@ void z_sys_mem_pool_block_free(struct sys_mem_pool_base *p, u32_t level,
 		lsizes[i] = WB_DN(lsizes[i-1] / 4);
 	}

+	{
+		uintptr_t *sentinel = block_ptr(p, lsizes[level], block);
+		int end = (lsizes[level] / sizeof(uintptr_t)) - 1;
+		if (sentinel[0] != 0xdeadbeef || sentinel[end] != 0xbadbea7) {
+			__ASSERT(false, "memory corruption");
+			printk("memory corruption\n");
+			k_panic();
+		}
+	}
+
 	block_free(p, level, lsizes, block);
 }

--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/zephyrproject-rtos/zephyr/issues/20981#issuecomment-558697110

@npitre I applied the diff and do not run into your assert.

On Thu, 28 Nov 2019, Paul Gavrikov wrote:

@npitre I applied the diff and do not run into your assert.

OK. Then here's another one for you to test:
diff --git a/include/sys/mempool_base.h b/include/sys/mempool_base.h
index 714e6cbd51..dd4d749780 100644
--- a/include/sys/mempool_base.h
+++ b/include/sys/mempool_base.h
@@ -20,6 +20,7 @@ struct sys_mem_pool_lvl {
 		u32_t *bits_p;
 		u32_t bits[sizeof(u32_t *)/4];
 	};
+	uintptr_t sentinel;
 	sys_dlist_t free_list;
 };

@@ -34,9 +35,10 @@ struct sys_mem_pool_base {
 	s8_t max_inline_level;
 	struct sys_mem_pool_lvl *levels;
 	u8_t flags;
+	u32_t bmap_csum;
 };

-#define _MPOOL_MINBLK sizeof(sys_dnode_t)
+#define _MPOOL_MINBLK (sizeof(uintptr_t) + sizeof(sys_dnode_t))

 #define Z_MPOOL_HAVE_LVL(maxsz, minsz, l) \
 	(((maxsz) >> (2*(l))) >= MAX((minsz), _MPOOL_MINBLK) ? 1 : 0)
diff --git a/lib/os/mempool.c b/lib/os/mempool.c
index efca11a203..60470a3642 100644
--- a/lib/os/mempool.c
+++ b/lib/os/mempool.c
@@ -75,6 +75,61 @@ static int partner_alloc_bits(struct sys_mem_pool_base *p, int level, int bn)
 	return (*word >> (4*(bit / 4))) & 0xf;
 }

+static void *set_sentinel(void *ptr)
+{
+	uintptr_t *sentinel = ptr;
+	*sentinel = (uintptr_t)sentinel ^ 0xDEADBEA7;
+	return sentinel + 1;
+}
+
+static void *check_sentinel(void *ptr)
+{
+	uintptr_t *sentinel = ptr;
+	if (*sentinel != ((uintptr_t)sentinel ^ 0xDEADBEA7)) {
+		__ASSERT(false, "memory corruption");
+		printk("memory corruption\n");
+		k_panic();
+	}
+	return sentinel + 1;
+}
+
+static void *predec_check_sentinel(void *ptr)
+{
+	uintptr_t *sentinel = ptr;
+	check_sentinel(--sentinel);
+	return sentinel;
+}
+
+#include <sys/crc.h>
+
+static uint32_t calc_bmap_csum(struct sys_mem_pool_base *p)
+{
+	u32_t csum = 0;
+	int l;
+
+	for (l = 0; l < p->n_levels; l++) {
+		int nblocks = p->n_max * (1 << (l * 2));
+		u32_t *bits;
+		get_bit_ptr(p, l, 0, &bits);
+		csum = crc32_ieee_update(csum, (u8_t *)bits, 4 * ((nblocks + 31)/32));
+	}
+	return csum;
+}
+
+static void set_bmap_csum(struct sys_mem_pool_base *p)
+{
+	p->bmap_csum = calc_bmap_csum(p);
+}
+
+static void check_bmap_csum(struct sys_mem_pool_base *p)
+{
+	if (p->bmap_csum != calc_bmap_csum(p)) {
+		__ASSERT(false, "memory corruption");
+		printk("memory corruption\n");
+		k_panic();
+	}
+}
+
 void z_sys_mem_pool_base_init(struct sys_mem_pool_base *p)
 {
 	int i;
@@ -86,6 +141,7 @@ void z_sys_mem_pool_base_init(struct sys_mem_pool_base *p)
 	for (i = 0; i < p->n_levels; i++) {
 		int nblocks = buflen / sz;

+		set_sentinel(&p->levels[i].sentinel);
 		sys_dlist_init(&p->levels[i].free_list);

 		if (nblocks <= sizeof(p->levels[i].bits)*8) {
@@ -97,11 +153,12 @@ void z_sys_mem_pool_base_init(struct sys_mem_pool_base *p)

 		sz = WB_DN(sz / 4);
 	}
+	set_bmap_csum(p);

 	for (i = 0; i < p->n_max; i++) {
 		void *block = block_ptr(p, p->max_sz, i);

-		sys_dlist_append(&p->levels[0].free_list, block);
+		sys_dlist_append(&p->levels[0].free_list, set_sentinel(block));
 	}
 }

@@ -143,9 +200,13 @@ static void *block_alloc(struct sys_mem_pool_base *p, int l, size_t lsz)
 {
 	sys_dnode_t *block;

+	check_bmap_csum(p);
+	check_sentinel(&p->levels[l].sentinel);
 	block = sys_dlist_get(&p->levels[l].free_list);
 	if (block != NULL) {
+		block = predec_check_sentinel(block);
 		set_alloc_bit(p, l, block_num(p, block, lsz));
+		set_bmap_csum(p);
 	}
 	return block;
 }
@@ -158,13 +219,17 @@ static unsigned int bfree_recombine(struct sys_mem_pool_base *p, int level,
 		int i, lsz = lsizes[level];
 		void *block = block_ptr(p, lsz, bn);

+		check_bmap_csum(p);
+		check_sentinel(&p->levels[level].sentinel);
+
 		/* Detect common double-free occurrences */
 		__ASSERT(alloc_bit_is_set(p, level, bn),
 			 "mempool double-free detected at %p", block);

 		/* Put it back */
 		clear_alloc_bit(p, level, bn);
-		sys_dlist_append(&p->levels[level].free_list, block);
+		set_bmap_csum(p);
+		sys_dlist_append(&p->levels[level].free_list, set_sentinel(block));

 		/* Relax the lock (might result in it being taken, which is OK!) */
 		pool_irq_unlock(p, key);
@@ -178,7 +243,7 @@ static unsigned int bfree_recombine(struct sys_mem_pool_base *p, int level,
 		for (i = 0; i < 4; i++) {
 			int b = (bn & ~3) + i;

-			sys_dlist_remove(block_ptr(p, lsz, b));
+			sys_dlist_remove(check_sentinel(block_ptr(p, lsz, b)));
 		}

 		/* Free the larger block */
@@ -208,14 +273,17 @@ static void *block_break(struct sys_mem_pool_base *p, void *block, int l,
 {
 	int i, bn;

+	check_bmap_csum(p);
 	bn = block_num(p, block, lsizes[l]);
 	set_alloc_bit(p, l + 1, 4*bn);
+	set_bmap_csum(p);

 	for (i = 1; i < 4; i++) {
 		int lsz = lsizes[l + 1];
 		void *block2 = (lsz * i) + (char *)block;

-		sys_dlist_append(&p->levels[l + 1].free_list, block2);
+		check_sentinel(&p->levels[l + 1].sentinel);
+		sys_dlist_append(&p->levels[l + 1].free_list, set_sentinel(block2));
 	}

 	return block;

@npitre I run into the issue in sys_dlist_remove earlier now but do not see any additional logs.
[13:12:20:858] E: ***** MPU FAULT *****␍␊
[13:12:20:858] E:   Data Access Violation␍␊
[13:12:20:858] E:   MMFAR Address: 0x0␍␊
[13:12:20:867] E: r0/a1:  0x2000082c  r1/a2:  0x00000000  r2/a3:  0x00000000␍␊
[13:12:20:867] E: r3/a4:  0xfeadb68f r12/ip:  0xee636261 r14/lr:  0x0000328f␍␊
[13:12:20:875] E:  xpsr:  0x81000000␍␊
[13:12:20:875] E: Faulting instruction address (r15/pc): 0x0000329a␍␊
[13:12:20:885] E: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0␍␊
[13:12:20:885] E: Current thread: 0x20000224 (gMasterTxThreadId)␍␊
[13:12:20:897] E: Halting system␍␊

On Fri, 29 Nov 2019, Paul Gavrikov wrote:

@npitre I run into the issue in sys_dlist_remove earlier now but do not see any additional logs.

Do you mean that none of the checks from my latest patch triggered?
If so I'm afraid I'd have to be able to reproduce it locally to help you further.
Is it reproducible in a deterministic manner?
How long before the crash occurs?
Please apply the following patch and send me the output log leading to
the crash. Maybe that will tell us something.
diff --git a/lib/os/mempool.c b/lib/os/mempool.c
index efca11a203..660458a013 100644
--- a/lib/os/mempool.c
+++ b/lib/os/mempool.c
@@ -293,6 +293,9 @@ int z_sys_mem_pool_block_alloc(struct sys_mem_pool_base *p, size_t size,
 	*level_p = alloc_l;
 	*block_p = block_num(p, data, lsizes[alloc_l]);

+	printk("mempool_alloc: buf=%p max_sz=%zd n_max=%d n_levels=%d lvl=%d blk=%d\n",
+	       p->buf, p->max_sz, p->n_max, p->n_levels, *level_p, *block_p);
+
 	return 0;
 }

@@ -302,6 +305,9 @@ void z_sys_mem_pool_block_free(struct sys_mem_pool_base *p, u32_t level,
 	size_t lsizes[LVL_ARRAY_SZ(p->n_levels)];
 	int i;

+	printk("mempool_free:  buf=%p max_sz=%zd n_max=%d n_levels=%d lvl=%d blk=%d\n",
+	       p->buf, p->max_sz, p->n_max, p->n_levels, level, block);
+
 	/* As in z_sys_mem_pool_block_alloc(), we build a table of level sizes
 	 * to avoid having to store it in precious RAM bytes.
 	 * Overhead here is somewhat higher because block_free()

@npitre
Yes, none of the checks triggered. I tested the patches separately. Should I try all together?
It happens deterministically. Some more background: basically our app is a ZTests over a custom stack we wrote on top of SPI. There's quite a lot of code and I do not have clearance to share it unfortunately. The issue happens rather quickly as you can see in the log:
[14:35:45:918] mempool_free:  buf=0x20000628 max_sz=32768 n_max=1 n_levels=5 lvl=4 blk=0␍␊
[14:35:45:918] mempool_alloc: buf=0x20000628 max_sz=32768 n_max=1 n_levels=5 lvl=4 blk=1␍␊
[14:35:45:918] mempool_free:  buf=0x20000628 max_sz=32768 n_max=1 n_levels=5 lvl=4 blk=1␍␊
[14:35:45:932] E: ***** MPU FAULT *****␍␊
[14:35:45:932] E:   Data Access Violation␍␊
[14:35:45:932] E:   MMFAR Address: 0x0␍␊
[14:35:45:932] E: r0/a1:  0x00000002  r1/a2:  0x200006a8  r2/a3:  0x20000628␍␊
[14:35:45:939] E: r3/a4:  0x00000080 r12/ip:  0x00000000 r14/lr:  0x00000000␍␊
[14:35:45:952] E:  xpsr:  0x81000000␍␊
[14:35:45:952] E: Faulting instruction address (r15/pc): 0x000030b2␍␊
[14:35:45:952] E: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0␍␊
[14:35:45:964] E: Current thread: 0x20000224 (gMasterTxThreadId)␍␊
[14:35:45:964] E: Halting system␍␊

Actually, after applying the latest patch I get the MPU fault in the very first test while it used to be a later on before.  Normally, the block being freed should be
available and reallocated right away by the following alloc call. Here,
in one case, block 0 is allocated and freed, then block 64 is allocated.
In the other case, block 0 is allocated and freed, then block 1 is
allocated. In both cases, block 0 should have been allocated again, not
some other random block.
I tried to reproduce your allocation pattern and got the following log
instead:
mempool_alloc: buf=0x00113120 max_sz=32768 n_max=1 n_levels=5 lvl=4 blk=0
mempool_free:  buf=0x00113120 max_sz=32768 n_max=1 n_levels=5 lvl=4 blk=0
mempool_alloc: buf=0x00113120 max_sz=32768 n_max=1 n_levels=5 lvl=4 blk=0
mempool_free:  buf=0x00113120 max_sz=32768 n_max=1 n_levels=5 lvl=4 blk=0
mempool_alloc: buf=0x00113120 max_sz=32768 n_max=1 n_levels=5 lvl=4 blk=0
mempool_free:  buf=0x00113120 max_sz=32768 n_max=1 n_levels=5 lvl=4 blk=0

You'll have to figure out why your allocation pattern is going erratic.
Without reproducing it myself I'm afraid that my ability to help you is
rather limited at this point.


Update of conda recipe for openmoltools to install v0.6.6

OK, so based on the exact string you used in the git tag, I think you should have 0.6.6 instead of v0.6.6.  For example:
kyleb@kyleb-DX4870:~/src/choderalab/openmoltools$ git checkout v0.6.6
error: pathspec 'v0.6.6' did not match any file(s) known to git.
kyleb@kyleb-DX4870:~/src/choderalab/openmoltools$ git checkout 0.6.6
Note: checking out '0.6.6'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 60e46fc... Merge pull request #110 from MobleyLab/master
kyleb@kyleb-DX4870:~/src/choderalab/openmoltools$

Ah, I see. I updated the tag in the release. I think now it will work.

Conda builds are up: https://binstar.org/omnia/openmoltools/files


track API usage

see https://github.com/gbif/gbif-api/issues/46 and https://github.com/Sp2000/colplus/issues/16

duplicate 0f #209


Added K8 Deployment Specs

Codecov Report

Merging #16 (daedc91) into master (70ec1ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   42.50%   42.50%
=======================================
  Files          40       40
  Lines        1188     1188
=======================================
  Hits          505      505
  Misses        680      680
  Partials        3        3

Flag
Coverage Δ

unittests
42.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ec1ef...daedc91. Read the comment docs.


Program starts in wrong display (Ubuntu)

Describe the bug
I'm having this problem where insomnia always starts in the display at the right, not the primary display o secondary display, it starts on the display on the right regardless if it is primary or secondary display.
My setup is a PC monitor set to primary default and a TV on the right for presentations.
To Reproduce
Steps to reproduce the behavior:

First of all I'm using Ubuntu 20.04 LTS
My setup includes 2 displays the left one is set as primary and the right one is secondary.
Installed Insomnia from .deb file downloaded from https://insomnia.rest/
When launching the program it starts in the right display (set as secondary)

Expected behavior
I would expect the program to open in the primary display, but it opens in the display set at the right side, regardless if it is primary or secondary.

Desktop (please complete the following information):

OS: Ubuntu 20.04 LTS
Installation Method: from .deb file downloaded from https://insomnia.rest/
App Version 2020.2.2

Hi @davidnavas-ashkalabs, thanks for reporting this! I'm not entirely certain this is specific to Insomnia, are you by any chance still able to reproduce this using latest Ubuntu and latest Insomnia versions?

Hi @davidnavas-ashkalabs
As we have not heard back from you we are closing this issue out. If you require any further/future assistance please let us know and we will proceed accordingly. Have a nice day.


Improve response filtering

I think it's safe to ignore 2xx responses and response's whose content-length are greater than twice the expected size.
We can't ignore 2xx in the case of Sucuri WAF but for Cloudflare it would be a great performance gain.
If the content-length is greater than, lets say, 24 KiB, it's obviously not Cloudflare's interstitial or reCAPTCHA response. I think we should avoid needlessly processing such large responses. We're already filtering on whether or not the content-type is text/html but for completeness sake, let's consider this as well. It should also be noted that the challenge responses don't specify a content-length.
The content-length is unreliable due to custom Cloudflare pages. I found a JS challenge page that was 15 times the default length. We still could set some sort of high watermark, just has to be really* high.

The current approach is the most robust. I've had it in mind to add support for streaming responses for a while now and is why I'm revisiting this now. I'll reference this issue when I get around to sending a PR for that. I'm closing this for now.


Feature/fix java doc

fixed an issue related to javadoc creation

/azp run

/azp run

/azp run

all good !


Improvement for command 'antctl set flow-aggregator'

Add e2e test
Add parameter recordContents.podLabels
Signed-off-by: Yun-Tang Hsu<EMAIL_ADDRESS>

Codecov Report

Merging #3959 (091906b) into main (79b6480) will decrease coverage by 0.06%.
The diff coverage is 18.91%.

@@            Coverage Diff             @@
##             main    #3959      +/-   ##
==========================================
- Coverage   64.39%   64.33%   -0.07%
==========================================
  Files         294      294
  Lines       43627    43728     +101
==========================================
+ Hits        28095    28133      +38
- Misses      13258    13317      +59
- Partials     2274     2278       +4

Flag
Coverage Δ

*Carryforward flag

kind-e2e-tests
50.79% <28.57%> (ø)

Carriedforward from 79b6480

unit-tests
44.36% <8.10%> (-0.03%)
:arrow_down:

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

pkg/antctl/command_list.go
48.35% <0.00%> (-0.54%)
:arrow_down:

pkg/flowaggregator/flowaggregator.go
55.41% <21.87%> (-2.77%)
:arrow_down:

pkg/agent/controller/trafficcontrol/controller.go
82.78% <0.00%> (-0.43%)
:arrow_down:

pkg/agent/openflow/pipeline.go
73.31% <0.00%> (+0.04%)
:arrow_up:

pkg/apiserver/storage/ram/store.go
80.19% <0.00%> (+1.48%)
:arrow_up:


[Feature]  Support more options in bug template

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
I found the options/categories only has ray-operator in bug templates today. This is not enough. It's better to list apiserver, CI, there for us to easily manage those bugs.

Let's update https://github.com/ray-project/kuberay/blob/master/.github/ISSUE_TEMPLATE/bug-report.yml and add more options.
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

/cc @wilsonwang371


CreateCopyJobs Endpoint don't work in SPFx

Category

[x] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
Currently working on a new PnP sample that shows how to move/copy files cross-site collection using the Microsoft Graph and the new /_api/site/CreateCopyJobs Endpoint. The data submitted to this endpoint was correct but no valid result was returned to identify the Job ID and not data were moved.
The desired behaviour is to be able to use this endpoint in custom code because with the cross-site collection move I can accomplish a lot of business scenarios.
Observed Behavior
From a custom web part that uses a target and source path parameter to identify files, the cross-site collection move gets triggered.

The click on the button sends a regular POST request with proper data and the service all returns status code 200:
this._context.spHttpClient
    .fetch(restEndPoint, SPHttpClient.configurations.v1, request)
    .then((response) => {
        console.log(response);
     }).then((result: any) => {
        console.log(result);
     })

The returned status in is the following:

The response by this endpoint only contains the following information:
{
<EMAIL_ADDRESS>: "https://tennantname.sharepoint.com/sites/SalesTeam/_api/$metadata#Collection(SP.CopyMigrationInfo)",
    "value":[]
}

The response give back by SharePoint using the UI is:

Steps to Reproduce
Send a POST request in the following format to the endpoint:
https://tenant.sharepoint.com/sites/SalesTeam/_api/site/CreateCopyJobs

The post request should contain the following format:
{
  "destinationUri": "https://tenant.sharepoint.com/sites/SalesTeamInfo/Shared%20Documents",
  "exportObjectUris": [
      "https://tenant.sharepoint.com/sites/SalesTeam/Shared%2520Documents/CopyCopyCopy.png",
      "https://tenant.sharepoint.com/sites/SalesTeam/Shared%2520Documents/CopyCopyCopy.jpg"],
  "options": {
    "IgnoreVersionHistory": true,
    "IsMoveMode": false
  }
}

If needed I can share the beta code in a repo.

Hi Vesa,
The createcopyjobs now sends response which also includes SourceListItemUniqueIds
{
"copyJobInfo": {
"EncryptionKey": "epqb0MWTFkHKm1XDjmv56ISK7aeflkCfn4NGZcc927Q=",
"JobId": "4916f9f5-af72-4286-aa3a-7f8ee5e8b489",
"JobQueueUri": "https://spobl1sn1m021pr.queue.core.windows.net:443/1201pq20180808-8b8d3be279b14bb593a34a26508fcbad?sv=2017-07-29&sig=ri4rc%2FHzITZGNdeYJPtzZ7Hn6XUOo%2BgVLTIHGSY6idM%3D&st=2018-08-07T07%3A00%3A00Z&se=2018-08-29T07%3A00%3A00Z&sp=rap",
"SourceListItemUniqueIds": ["41047376-6b16-4fc0-a483-86752e2a1e23"]
}
}
When I try and query getcopyjobprogess using the above job info it erros when i pass SourceListItemUniqueIds in the request body
But when i exclude SourceListItemUniqueIds it works as expected
I'm using this at a production tenant and although its working now after i have removed SourceListItemUniqueIds but I am getting worried about the constant changes

There are multiple APIs to copy/move documents between site collections in SPO. Example:
a. Microsoft Graph
b. SPO REST API
c. SPO REST AP v2.0
d. SPO Create Copy Jobs API
I know Microsoft Graph is the preferred option. I understand SPO rest api and the v2.0 endpoints too, as one exists for legacy support and the other is the backend for Graph. What is the context/story around the last (d) option: the SPO Create Copy Jobs API. The lack of documentation and usage samples on this API, makes me suspect if this is a supported endpoint. Can anyone shed some light on this?
Customer is seeing some issues using Microsoft Graph copy/move api, so considering the Create Copy Jobs API. I want to make sure they are heading in the right direction.
PS: I am working internally to escalate the MS Graph issues.

Just leaving a note here to mention that PnPjs now has new methods (CopyByPath and MoveByPath) to copy/move files and folders that also work cross-site collection in case this helps someone

@svarukala did you get any information regarding the story about the api? I'm been trying it out from spfx using sphttpclient and working really good, both CreateCopyJobs and getting progress from GetCopyJobProgress. Only documentation I've found is from using it with CSOM https://docs.microsoft.com/en-us/sharepoint/dev/apis/spod-copy-move-api

@kimrohdin I didn't get any additional information on that API. Since there is some official documentation I think you should be fine using that endpoint.

This issues should be fully solved and fixed, given the work we have done in engineering in this area. To ensure that we clean up the backlog of the issues, we will be closing this one. If you still have issues on this particular area, please open up a new issue so that we can get updated issue description and reproduce steps. We do apologize the non-optimal handling of these old issues and are looking into improving this in future.


changing the password is not working

Rancher Version: v1.1.0-dev1
Docker Version: 1.11.1
OS and where are the hosts located? (cloud, bare metal, etc): bare metal
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB) 12 node rancher, internal db
Environment Type: (Cattle/Kubernetes/Swarm/Mesos) Cattle
Access Control Local Authentication
Steps to Reproduce:
try to change the password by clicking in the upper right
Results:
404 https://foo.bar/v1/projects/xxx/accounts/xxx?include=credentials
Expected:
overlay

Version - master 5/19
Verified fixed
@qulo - this is fixed in the next release.


REST APIs Check User Existence Always Returns Empty Body

The REST API that Checks user existence in a group always returns an empty body.
This issue occurs in both of the Check user existence in a group REST APIs:

https://.service.signalr.net/api/v1/hubs//users//groups/
https://.service.signalr.net/api/v1/hubs//groups//users/

Request sent:

GET /api/v1/hubs/REMOVED/users/REMOVED/groups/REMOVED HTTP/1.1
Host: REMOVED.service.signalr.net
User-Agent: Paw/3.1.9 (Macintosh; OS X/10.14.6) URLSession/1575.19
Content-Type: application/json
Authorization: Bearer REMOVED

For the sake of clarity, the text "Removed" was added for privacy and not actually sent with request
Response received:

HTTP/1.1 200 OK
Content-Length: 0
Server: nginx
Date: Tue, 07 Jan 2020 18:19:18 GMT
Connection: keep-alive

I confirmed the user is a member of the group by successfully sending and receiving  a message through the broadcast message to group endpoint.

This API is for serverless.
For in default mode:

a group contains connections, i.e.: 0..n--0..n.
a connection can belong to a user, i.e: 0..n--0..1.
no relationship between user and group.

@Tharindu-Diluksha , Hi, I cannot find your contact so ping you here. I'm the Product Manager of Azure SignalR Service, and we have a new internal preview for supporting raw WebSocket in serverless scenarios, thinking you might be interested to try it out and offer us some feedback. If you are interested please ping me at zhshang at microsoft dot com.  Thanks. -Zhidi

If a user in the group, it will return 200, otherwise, it will return 404.
Both are empty body.

@sffamily Hi, I would really love to test that. I have sent an email. I look forward for your reply. Thanks

Closing the issue as Empty body is expected


VPackString

I would like to add a data type that owns the velocypack it contains. Similar to what a std::string is for a std::string_view, a VPackString is for a VPackSlice. There have been multiple occasions where people want to store some velocypack.
Currently you have the option of using a VPackBuilder or a VPackBuffer. Both is not very handy to use and preallocates a lot of memory. Afaik a builder reserves 969 bytes of memory on the stack. Similar the VPackBuffer. Thus you often see something like std::shared_ptr<VPackBuilder>.
Also, there is SharedSlice which uses aliasing shared_ptrs. This can work, but you have to keep in mind the the whole blob is kept in memory, even if your SharedSlice points to a small potion of it.
A VPackString is just a std::string but provides the same interface as a VPackSlice does. Its content is immutable. So you have small string optimization for small vpack values and normal allocations for bigger values.
Also a VPackString is allocator aware which makes it useful in combination with pmrs (which are used for memory accounting).
To make sure that the API is indeed identical, I extracted it in a common base class using templates.
Initially I planned to also use this for the SharedSlice, but for now this is too complicated.
Here are some examples where a VPackString could be useful in ArangoDB:
OperationResult::buffer is currently a std::shared_ptr<VPackBuffer<uint8_t>>.
arangodb::consensus::Node uses a
  std::unique_ptr<std::vector<SmallBuffer>> _value;  ///< @brief my value

Those small buffers contain velocypack. One could simple use a VPackString here.
Everything in the network stack uses a VPackBuffer to handle velocypack data.

coverage: 96.274% (-0.07%) from 96.341% when pulling 758c7b85fcbe95d176e4bb9a5107de425a0d3898 on feature/vpack-string into 3e3e9416c478e2f12282d6dc4a619fd5d5f39918 on main.

But it already was possible.
Just store string/string_view, and then construct Slice from it in some place.
It was difficult? I don't think so
Also I think such changes should be measured before merge.
I understand that it's crtp -- static polymorphism, but it doesn't matter it couldn't affect current code if something couldn't inline.


EC2 idle shutdown best practices

Users are often scared to leave cloud instances running which can hamper cloud adoption. Froster has an experimental idle detection which lets ec2 instances self-terminate after a few days (72 hours by default). It has a monitoring cron job in systemd that is run hourly and if this cron job has detected an idle state 72 consecutive times the machine will be terminated.
Is this a reasonable approach for Amazon Linux 2003?
function AWSBoto._monitor_is_idle:
https://github.com/dirkpetersen/froster/blob/main/froster.py#L3915

For future development


UI and Content for Login Help

ITS-Pro time category: https://its-pro.ucsd.edu/browse/MA-59
This is complete when:

[x] The user has an intuitive way to resolve AD login issues (e.g. forgot password)

Prototype for the UI and Content for Login Help:
https://xd.adobe.com/view/4dbbd6ff-1cbb-486c-a273-4397314e4881-18e8/

As of campus mobile 7.2.14 the Need help logging in? button on the Onboarding and Profile login screens are linked to Service Desk's Service Now page shown in XD mockup screen 4 (Service Desk -> Accounts & Passwords -> Student Accounts).


[DO NOT MERGE] @Next

Migrate code onto native javascript environment.
Advantage

better experience
better code base
better test code

Tech In Stuck

zero configuration
codePush, CI, CD integration
auto fix code [eslint]
e2e automation (in progress)

will force update onto master when it ready for production


Add READMEs for all examples, fix a bug w/ react-router example

I like how the Chatbot example has its own readme with comments and instructions. I think it makes it easier to interact with the example. I added readmes for the rest of the examples (super sparse for now, but we can enhance them in the future).
There was also a small bug with the react-router example, where it was loading a blank routes.js file instead of the actual routes file, routes.jsx.

😍

Huge 👍


move ngAnnotate to contact task

mainly to be able to use this file in apps with ng-strict-di (https://docs.angularjs.org/api/ng/directive/ngApp) without uglify.
For example with webpack.

Coverage remained the same at 100.0% when pulling 77a2b1107342ce3c0f0892892c81b2c69f7d3b90 on adam187:feature/ng-strict-di into 541a9df8aab2942e853cc21bd2568cf9187bf092 on ismarslomic:master.


[SECURITY] Plain-text credentials

Hello!
Thank you for using my app in your project. I noticed that you're storing credentials for the app account in plain text within your GitHub repository. This is a security risk.
Instead of storing plain-text credentials in public code, please use environment variables. This practice enhances security and follows best practices for handling sensitive information.
To reset credentials, you can either clear the app data on the device or reinstall the app.
For reference, I found the credentials here:
https://github.com/AJEETX/risk.control.system/blob/145027f1e2b484314f778615dec9390858f57143/risk.control.system/Services/SmsService.cs#L21
Please update your code to address this security concern. If you need any assistance with implementing environment variables, feel free to ask.

removed and closed


updated ocp-install-preparation.yml for 3.10 and 3.11

added some logic to not run localhost plays on tower or non-RHEL machines.
updated to work with 3.11
added default variables
added documentation to the README.md to reflect usage for ocp-install-preparation.yml

@pekramp what testing have you done for these changes?

This was tested in our project VMC environment and Eric Crosby validated the work as well in our environment.

@pekramp thanks for the PR


fuzz: Add a bitset fuzz-harness

Refer to #24502 for more details.
Add a simple fuzz test for the bitset API.

[x] I've read the contributing section of the project README.
[x] Signed CLA (if not already signed).

Thanks for contributing, but I don't think we need to take this at this time. I'd rather hold off on adding an entirely new crate just to fuzz test a crate that I'm not sure how we'll use in the near future.


bug: Wrongly generated CSS selector upon build, while dev works fine

Describe the bug
Hello!
In a React TS + Vite project using CSS modules, I stumbled upon an issue
where all written css selectors are correctly applied to the elements in dev mode,
but in the production build, one selector is missing, and - upon further inspection - the generated CSS
differs slightly.
It happens roughly like this:
The following [here simplified] CSS is what I've written in the CSS module, and is used as-is in dev mode and works fine:
.inputContainer {
	.input { ... }

	&:after { ... }

	&:after,
	& .input { ... }
}

However, in production, the last css selector ( &:after, & .input ) is wrongly compiled into the following:
.inputContainer .input, .inputContainer .input {}

The .inputContainer:after selector is removed, and instead it compiles to two times the same selector.
Reproduction
https://stackblitz.com/edit/vitejs-vite-k6n2wy?file=src%2FApp.module.css
Steps to reproduce
I've attached a reproduction url using the stock React+Vite template (skipping TS here, it doesnt matter).
If you run that one in stackblitz as is, both .input and the :after Element will be laid on top of each other, which is correct.
However, if you stop that server in the terminal, run npm run build and then npx serve dist, you will see that they are not on top of another anymore, since the :after Element is missing a css rule, due to the css being wrongly compiled.
System Info
System:
    OS: macOS 14.3.1
    CPU: (11) arm64 Apple M3 Pro
    Memory: 159.33 MB / 18.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.6.0 - ~/.nvm/versions/node/v21.6.0/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v21.6.0/bin/npm
    pnpm: 8.14.1 - ~/.nvm/versions/node/v21.6.0/bin/pnpm
  Browsers:
    Chrome: 121.0.6167.184
    Edge: 121.0.2277.112
    Safari: 17.3.1
  npmPackages:
    @vitejs/plugin-react: ^4.2.1 => 4.2.1
    vite: ^5.0.8 => 5.0.12

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Note that this won't be included in Vite 5.1.x because Vite 5.1.x uses esbuild 0.19.x and the fix would be included in esbuild 0.20.x.


Add Curve/Convex TriCRV vault.

API: https://github.com/beefyfinance/beefy-api/pull/1457
mooConvexTriCRV
Vault 0x6F962B98803C7977d1cD8c3eeC29dBb7Dc1A7f6A
Strategy 0x4C011DAe81078542CE6c34D01AC8B2D041309F1d
Tested with VAULT=0x6F962B98803C7977d1cD8c3eeC29dBb7Dc1A7f6A forge test --fork-url http://localhost:8545 --match-contract StrategyCurveConvexTest, and limited manual testing after deployment(very expensive deposits / withdrawals).
yarn validate passes.

@roman-monk, gentle ping.

@defymcdefiface you need to verify strategy contract.
ideally it should be deployed as minimal proxy to existing implementation, but if you used correct source code its ok.
please use flattening for verification (single file).

Thanks, missed this in the instructions, the strategy contract is now verified. Will use a minimal proxy deployment next time, seems like a much better route from cost and testing standpoint.

we cant accept this deployment.
i would expect the flat contract from the beefy-contracts repo to match your deployment.
but you modified the strategy code and even Base strategy code which is quite unusual.
please redeploy using minimal proxy as you did for the vault, you can use this address as impl 0xeB3616a2Ea38e21C59Cd8Eded6d2A8bC937a0A87

Yep I did something dumb, verified with my debugging remnants in the repo. Re-deployed as proxies and updated.

Hey @roman-monk, PTAL when you get a chance.

Hey @roman-monk, is there anything else I need to do here?


Convert Physical Plan to Finch's Logical AST

Finch is adopting a logical language in this PR (https://github.com/willow-ahrens/Finch.jl/tree/wma/finchlogic) which they intend to be their means of describing a PyData/Sparse lazy evaluation graph. It would be convenient if we could have Galley act as a Logical AST in-Logical AST out component in this pipeline.
Some basics here:

Queries are roughly equivalent to kernels
Plans are collections of queries + a list of outputs
Loop ordering within queries is determined by the index ordering of the inputs
Reformat commands must be the topmost node within a query body, and they can be used to demand particular materialization formats

This was closed by #25


CSV exports rounds to 2 digits

Basic information

My operating system and version: Windows 10 Enterprise
My MZmine version: 3.2.8

What happened
This is what I did:

Finished data processing and came up with a nice aligned feature list.
Exported the aligned feature list as CSV (either using to CSV item or the GNPS item from the 'Export Feature Liste' menue). When using the GNPS menu item, I selected either COMPREHENSIVE or ALL as export format.

All columns which are exported in exponential number format (e.g. 1.1E3) have an accuracy of exactly 2 digits.
This applies to the following columns: area, height, intensity_range:min, intensity_range:max

Exported the aligned feature list as CSV (legacy MZmine 2) or GNPS (SIMPLE format, which also calls the legacy CSV export).

All columns are exported to full accuracy.

It would be great if all columns could be exported at full accuracy also using the new CSV export function.
The attached file shows the output of the new CSV export function (first 8 rows only):
Test_GNPS_export_quant_full.csv

Yeah thats a real issue actually.
You can change the number format in the preferences. That controls both the export and visuals in mzmine.
I think w should add a default option there to extend all values by 2 digits. Or maybe have separate formats for export

In the past we did not reformat the values for export, is that a new feature/bug?
Why not use the default Double.toString() method?

Some modules format the values others not.
I think it's bad practice to export just the Double or Float value and it bloats the exported files massively.
But it is an issue to just use the visualization formats.

@PhilippTernes fixed in the latest development build. https://github.com/mzmine/mzmine3/releases/tag/Development-release
the digits are not modifiable for now, we chose a resonable number for each type.
thanks for the report.


Bugfix/home page typo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: TomD0wning sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Kanban board setup

We are a group of two students
below is our project's link 👇🏾👇🏾👇🏾
https://github.com/Gh-Reza/RecipeApp/projects/1

Status: Required Changes :recycle:
Hi @team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights

Implemented some project requirements. :heavy_check_mark:
No linter errors. :heavy_check_mark:
Good README file. :heavy_check_mark:
Correct Gitflow. :heavy_check_mark:

Required Changes ♻
Check the comments under the review.

[ ] Great job setting up your kanban board. However, there're fwo missing cards yet to be included in your board from the project requirements. Kindly checkout the screenshot from the requirements and add them.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Status: Required Changes :recycle:
Hi @team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights

Implemented some project requirements. :heavy_check_mark:
No linter errors. :heavy_check_mark:
Good README file. :heavy_check_mark:
Correct Gitflow. :heavy_check_mark:

Required Changes ♻
Check the comments under the review.

[ ] Great job setting up your kanban board. However, there're fwo missing cards yet to be included in your board from the project requirements. Kindly checkout the screenshot from the requirements and add them.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sorry but we do have them

Hi team😃,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights

Well done on completing the Kanban project for the Rails app

Cheers, and Happy coding!👏👏👏
Feel free to mention @MahmoudBakr23 to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


CI: failure for "Oldest GCC ..." Linux CI job (related to pre-release NumPy)

I noticed the CI failure while reviewing Ralf's PR at gh-21943. It is reproducible locally on Linux with gcc 9.5 and the new NumPy pre-release, 2.2.0rc1. This CI job builds with the latest NumPy pre-release and then switches to 1.23.5 at test time after building.
Reproduced locally via a build command similar to the CI job in question: python -m build --wheel --no-isolation -Ccompile-args=-j32
Failure can be reproduced on main, so not related to Ralf's branch:
<snip>
Program pythran found: YES 0.17.0 0.17.0 (/home/treddy/python_venvs/py_310_scipy/bin/pythran)
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency xsimd found: NO (tried pkgconfig and cmake)
Run-time dependency threads found: YES

../scipy/meson.build:50:17: ERROR: Command `/home/treddy/python_venvs/py_310_scipy/bin/python -c 'import os
os.chdir(os.path.join("..", "tools"))
import numpy as np
try:
  incdir = os.path.relpath(np.get_include())
except Exception:
  incdir = np.get_include()
print(incdir)
  '` failed with status 1.

A full log can be found at /home/treddy/github_projects/scipy/.mesonpy-dl97fuyc/meson-logs/meson-log.txt

ERROR Backend subprocess exited when trying to invoke build_wheel

The version of the GNU compiler/toolchain is irrelevant to reproduction of the issue.

Reported upstream for clarification.

Looks like the explanation is incredibly simple after all, import numpy as np fails when PYTHONOPTIMIZE=2 for the latest NumPy pre-release... I thought I was just getting tired or something...

the failing SciPy job needs a local fix though, since it currently pulls in numpy 2.2.0rc1

what is the fix needed here @rgommers ?


Implement Codesplitting

This should produce the following:

Main bundle
Vendor dep bundle
Per route bundles
Per web worker bundles

Blocked by #401

Plan:

use react-loadable https://github.com/thejameskyle/react-loadable to handle the lifecycle of loading async components
use ErrorBoundary component to display any failed async loading of bundles
start at the Route level
investigate if other components can be code split


Outreach to other provincial governments

Provincial governments doing similar work to us may have a lot of valuable insight to share! This ticket follows #80 which documents the creation of an outreach email.
Acceptance Criteria:

[ ] Send email to the following contacts as outlined in this Teams document:
Ontario Government
Quebec Government
PEI Government

Looks good @jaimiebutton ! Perhaps this will be captured as part of #80, but what will be the intent/outcome that you hope to achieve through this outreach? Ie;, a follow up discovery session? sharing of material? etc. I'm assuming Chris has contacts as well for these governments?

I'll add that to the ticket, thanks :)

Thank you @jaimiebutton - I look forward to learning more about what other province's are doing in this realm.


Linking profilepanel <-> profile <-> insurance <-> insurancepanel

Done. This PR includes both the save/load pdf for contract as well as the link

Currently the switching of middle panel is done by raised event which is picked up by MainWindow who unbind the current rightPanelPlaceholder with the requested one. To prevent memory leak, InsuranceProfile constructor is overloaded so empty insurance could be created in the background but still listen the relevant event. This way, you don't have to destruct and reconstruct it over and over.
New method inside UniqueLifeInsuranceMap class is created (asObservableList()) since the AddressBook.java only has the map version. To prevent any more coupling against Ui components, the accessor needs to go through logic -> model -> addressbook  to retrieve the observablelist.
To display all insurance related to a person in their profile page, a ListView consisting of InsuranceIdLabel class is implemented. As of now, we have no identifier for insurance other than the key and Signed Date is being used as placeholder at the moment. This can easily be changed by replacing the binding property inside InsuranceIdLabel.java
Regarding the pdf, it works in such a way that if there is no file in the project folder, the link will be to add file, then update itself to open file. Note that the filename selected via filechooser is irrelevant, the stored file will follow the name provided in the insurance. Also, the currently storage location is data/ (same as xml file)

Known Issue / To-do

Settle the naming for each insurance inside profile
Fix the style for middle panel, especially for the displaying of insurance details
Somehow the hover highlights for insurance profile is not working properly when it's in the middle panel (the side panel on the right works fine)
Very few test cases are up, going to add it in when have time unless someone is willing to help
Docs are not up too, will do it by tomorrow

P.S. Will appreciate greatly if someone can guide me in doing collate with @@author thinggy

Changes Unknown when pulling 0aea4a9aecf11ce0421e46cc6b37354c2e0e461e on RSJunior37:link-everything into ** on CS2103AUG2017-T13-B1:master**.


Fix resource widget

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/retest


[webstore-demo] HOPE to have support for arm chip

I have an k8s cluster running in an arm environment.

we already support arm arch, https://github.com/openinsight-proj/opentelemetry-demo/pkgs/container/demo can you give some more details?

perhaps our pipeline need more test

please try the latest chart again.


Re work test fixtures iter one

Current coverage is 96.14% (diff: 100%)

Merging #954 into master will decrease coverage by 0.27%

@@             master       #954   diff @@
==========================================
  Files            34         34
  Lines          1817       1817
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1752       1747     -5
- Misses           65         70     +5
  Partials          0          0

Powered by Codecov. Last update 588d6eb...3b28e05


[Develop] Changed head/tail code is not updated in challenge

Describe the bug
During development adding or modifying the head or tail code (--before-user-code-- and --after-user-code--) don't seem to be updated in the challenge.
Tested locally and on gitpod.
To Reproduce
Steps to reproduce the behavior:

pnpm run develop:server
pnpm run develop:client
Add/modify the ## --before-user-code-- or ## --after-user-code-- in challenge. For example one of the steps in the JS curriculum. I was adding function and variables to it, and then was attempting to use them in tests.
Save and wait for challenge to be updated.
Reload (F5) the challenge page, or visit it for the first time.
When running tests, referencing the function/variables from head/tail code, there will be reference errors.

Expected behavior
Changing head or tail code, should update the challenge to use it.
Additional context

Login status don't seem to affect issue.
During changing the code, thinking I might do something incorrectly, there were handful times when challenge was updated with the head/tail code. Not sure what was the exact reason.
What makes it stranger is stopping client develop and starting again, is not necessarily solving the problem. At some point I thought that's working to get challenge fully updated, but right now that doesn't seem to work.

I might have seen this as well. I remember trying to save a regex in --after-user-code-- to use in multiple tests, and it didn't seem to work. Kind of just thought I was using it incorrectly, but maybe this was the issue.

Thanks for the detailed investigation of another tricky bug.
It was another example where saved code messes things up. They're always a pain to debug because everyone sees something different, depending on whether or not they have something saved.
Hopefully this is the last of them!

It was another example where saved code messes things up. They're always a pain to debug because everyone sees something different, depending on whether or not they have something saved.

What's the most throwing off, that wasn't even code saved manually!

Weird. Is there nothing in your local storage?

Weird. Is there nothing in your local storage?

Hmm, well there is after running tests. That must have been the point when saving mishap happened.

Hmm, well there is after running tests.

Oh, that's right. No mystery beyond "how did I forget this?" :face_exhaling:


scripts: Add ATD_QGS to acon-startvm to configure QGS location

This PR adds a new env var ATD_QGS to allow specifying the location of QGS when starting a TD.

Yes, ATD_TCPFWD supports multiple forwarding rules, but separated by commas (',') instead of spaces (' '). So in your case it should written as ATD_TCPFWD=8080:8085,10020:1025.


Fix calculation of rate, from second .shp onwards.

Was still using count in this function when it should have been total_count.
A couple of improvements too.

Codecov Report

Merging #12 into master will decrease coverage by 0.19%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master      #12     +/-   ##
=========================================
- Coverage   30.96%   30.76%   -0.2%
=========================================
  Files          12       12
  Lines         155      156      +1
=========================================
  Hits           48       48
- Misses        107      108      +1

Impacted Files
Coverage Δ

...ndavailability/lr/management/commands/importers.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e24911...4a874f6. Read the comment docs.


16 time of day test

Solve #16
I added test proves threads dataizes slow in parallel.
It's not possible to use $less-than here becase of this
Note "gettimeofday" returns nanos

@yegor256 please take a look

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 7min)


Scalable UI for full screen

Is it possible to make the UI elements scaleable, so it remains its same size as in the default viewport (not full screen), when scaled up? the options menu, and hotbar are pretty unusable at full screen.
I'm new to Godot and not sure how to achieve this with the UI system - or if an issue here is an appropriate place to ask about this - but wondering what should the approach be for this project? Thanks!!

Would love to help or learn as you work, when you are working on this. let me know if there are any resources you find?

Hey I'm trying to implement this feature here, please take a look!
https://github.com/Phazorknight/Cogito/pull/90

Basic UI scaling is implemented, so I'm going to close this.


ENH: Enable resampling morphometrics to fsLR CIFTI-2 files

Currently inaccessible to smriprep itself because I don't want to add and test a CLI option. Could probably go into a bug-fix release if someone cares about it before the next minor release.

Codecov Report
Patch coverage: 38.54% and project coverage change: -2.14 :warning:

Comparison is base (e271d75) 67.69% compared to head (a954f67) 65.56%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   67.69%   65.56%   -2.14%
==========================================
  Files          19       20       +1
  Lines        1232     1327      +95
  Branches      206      221      +15
==========================================
+ Hits          834      870      +36
- Misses        340      396      +56
- Partials       58       61       +3

Flag
Coverage Δ

ds005
54.55% <5.20%> (-3.89%)
:arrow_down:

ds054
45.59% <5.20%> (-3.20%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

smriprep/workflows/base.py
80.00% <ø> (ø)

smriprep/workflows/surfaces.py
68.45% <11.53%> (-12.04%)
:arrow_down:

smriprep/workflows/outputs.py
61.90% <14.28%> (-2.08%)
:arrow_down:

smriprep/workflows/anatomical.py
50.29% <20.00%> (-1.24%)
:arrow_down:

smriprep/interfaces/cifti.py
55.17% <55.17%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@mgxd I would appreciate a review here. I'll fix the flake8 failure (unused import) just before merging. No need to cycle the CI for it.

@mgxd @madisoth Just sneaking the recon-all fix in here, rather than making a new PR.


Moving EC2(1) resource to v1beta1 version

Moving v1beta1 1 resource to the ec2 group:

[ ] aws_ami_from_instance - Bug (https://github.com/upbound/provider-aws/issues/218)

Closing as duplicate #218