Error after running githook

Describe the issue
When processing the githook, I am getting the following error.
Jan 14 16:14:28 nycaddy caddy[192921]: {"level":"warn","ts":1642194868.222069,"logger":"http.handlers.git","msg":"failed updating repo","repo_name":"aspecthq.com","error":"object not found"}

Configuration
Paste full Caddyfile below:
{
    git {
        repo aspecthq.com {
            base_dir /var/www
            url https://gitlab.com/joeworkman/aspecthq.com.git
            branch master
            depth 1
            # auth ssh /var/www/ssh/id_rsa.pub
            webhook name X-Gitlab-Token go-caddy-git-go
            # post pull exec {
            #     name Pager
            #     command /usr/local/bin/pager
            #     args "pulled authp.github.io repo"
            # }
        }
    }
}
aspecthq.com {
    redir https://www.aspecthq.com{uri}
}
www.aspecthq.com {
    log {
        output file /var/log/caddy/aspecthq.com/access.log {
            roll_size 3MiB
            roll_keep 5
            roll_keep_for 48h
        }
    }
    handle_errors {
        respond "{http.error.status_code} {http.error.status_text}"
        # rewrite * /{http.error.status_code}.html
        # file_server
    }
    route /update {
        git update repo aspecthq.com
    }
    encode gzip zstd
    php_fastcgi unix//run/php/php8.1-fpm.sock
    file_server
    root * /var/www/aspecthq.com
    push
}

Version Information
Provide output of caddy list-modules -versions | grep git below:
git v1.0.4
http.handlers.git v1.0.4

Expected behavior
I would expect a pull request to be made
Additional context
https://github.com/greenpau/caddy-git/issues/1#issuecomment-1013469973

What is in .git/config?

[core]
	bare = false
[remote "origin"]
	url = https://gitlab.com/joeworkman/aspecthq.com.git
	fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
	remote = origin
	merge = refs/heads/master

@joeworkman , does the same happen with github repos?

@joeworkman , also, what is the OS running caddy?

The server is Ubuntu 20. I can test a Github repo. Maybe not tonight though.

Here is the config from Github.
[core]
	bare = false
[remote "origin"]
	url = https://github.com/joeworkman/aspecthq.com.git
	fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
	remote = origin
	merge = refs/heads/master

Looks pretty much the same minus the URL.

I am also getting the object not found with Github where the repo has already been cloned. However, if I delete the repo from the server and restart caddy, it does get created and Caddy does start.

Does this work for you locally on your computer? Do you have an example that works?

Yes, it does. Do you have anything special in you .gitconfig?

@joeworkman , all the examples in config directory work for me, e.g. https://github.com/greenpau/caddy-git/blob/main/assets/config/Caddyfile
also, as part of the test harness, I do git clone and then git pull.

I have simplified my config down to....
{
    git {
        repo aspecthq.com {
            base_dir /var/www/aspecthq.com
            url https://github.com/joeworkman/aspecthq.com.git
            branch master
            depth 1
        }
    }
}
aspecthq.com {
    redir https://www.aspecthq.com{uri}
}
www.aspecthq.com {
    route /update {
        git update repo aspecthq.com
    }
    encode gzip zstd
    php_fastcgi unix//run/php/php8.1-fpm.sock
    root * /var/www/aspecthq.com/aspecthq.com
    file_server
    push
}

I enabled debugging and got the following errors in the logs. Does this help?
Jan 17 23:57:15 nycaddy caddy[50249]: {"level":"debug","ts":1642481835.4307551,"logger":"tls.handshake","msg":"matched certificate in cache","subjects":["www.aspecthq.com"],"managed":true,"expiration":1649141617,"hash":"29a9c211883cb7b204d520dc16d7b79a4fc273a96f1d7fd4505c3ad3b93c9d32"}
Jan 17 23:57:15 nycaddy caddy[50249]: {"level":"debug","ts":1642481835.4329338,"logger":"http.handlers.git","msg":"received update git repo request","repo_name":"aspecthq.com"}
Jan 17 23:57:15 nycaddy caddy[50249]: {"level":"warn","ts":1642481835.476297,"logger":"http.handlers.git","msg":"failed updating repo","repo_name":"aspecthq.com","error":"object not found"}
Jan 17 23:58:15 nycaddy caddy[50249]: {"level":"debug","ts":1642481895.211445,"logger":"tls.handshake","msg":"no matching certificates and no custom selection logic","identifier":"<IP_ADDRESS>"}
Jan 17 23:58:15 nycaddy caddy[50249]: {"level":"debug","ts":1642481895.2115004,"logger":"tls.handshake","msg":"no certificate matching TLS ClientHello","server_name":"","remote":"<IP_ADDRESS>:11520","identifier":"<IP_ADDRESS>","cipher_suites":[49200,49196,49192,49188,49172,49162,165,163,161,159,107,106,105,104,57,56,55,54,49202,49198,49194,49190,49167,49157,157,61,53,136,135,134,133,132,49199,49195,49191,49187,49171,49161,164,162,160,158,103,64,63,62,51,50,49,48,49201,49197,49193,49189,49166,49156,156,60,47,154,153,152,151,69,68,67,66,150,65,7,49169,49159,49164,49154,5,4,49170,49160,22,19,16,13,49165,49155,10,255],"cert_cache_fill":0.0004,"load_if_necessary":true,"obtain_if_necessary":true,"on_demand":false}
Jan 17 23:58:15 nycaddy caddy[50249]: {"level":"debug","ts":1642481895.211616,"logger":"http.stdlib","msg":"http: TLS handshake error from <IP_ADDRESS>:11520: no certificate available for '<IP_ADDRESS>'"}

I order to get the site up and working, I always need to delete the git repo from the server. Then start Caddy. If the repo exists before Caddy starts, the object not found error happens and addy will not start.

@joeworkman , will try finding time later in the week to figure it out.

Thanks. I'm open to hoping on zoom if that works for you. https://joeworkman.net/bookme

@joeworkman , replied on linkedin

Any updates? I'm also having this problem

@love4taylor , please enable trace and paste logs from the transaction.

@greenpau
love4taylor@EGOIST:/data/docker/web$ docker exec -it caddy caddy list-modules -versions | grep git
git v1.0.4
http.handlers.git v1.0.4

Reproduction steps.

Use the following Caddyfile with an empty /tmp directory for the first clone by caddy-git.

{
  debug
  local_certs
  http_port 8081
  https_port 8082
  git {
    repo love4taylor-ruleset {
      base_dir /tmp
      url git@github.com:love4taylor/ruleset.git
      auth key /data/caddy/ssh/love4taylor-ruleset-at-github no_strict_host_key_check
      branch master
      depth 1
    }
  }
}

<IP_ADDRESS>, localhost {
  route /update/love4taylor-ruleset {
    git update repo love4taylor-ruleset
  }
  route {
    file_server {
      root /tmp/love4taylor-ruleset
    }
  }
}

love4taylor@EGOIST:/data/docker/web$ docker exec -it caddy ls /tmp
love4taylor-ruleset
love4taylor@EGOIST:/data/docker/web$ docker exec -it caddy cat /tmp/love4taylor-ruleset/.git/config
[core]
	bare = false
[remote "origin"]
	url = git@github.com:love4taylor/ruleset.git
	fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
	remote = origin
	merge = refs/heads/master

Visit the update link and get a result with 200.

love4taylor@EGOIST:/data/docker/web$ curl -k https://localhost:8082/update/love4taylor-ruleset
{"status_code":200}

Edit a random file on the GitHub page to update the repository.

If you visit the update link again, you will get a 500 error.

love4taylor@EGOIST:/data/docker/web$ curl -k https://localhost:8082/update/love4taylor-ruleset
{"status_code":500}

Caddy log:
{"level":"info","ts":1645317281.9945788,"msg":"using provided configuration","config_file":"/etc/caddy/Caddyfile","config_adapter":"caddyfile"}
{"level":"warn","ts":1645317281.9958227,"msg":"input is not formatted with 'caddy fmt'","adapter":"caddyfile","file":"/etc/caddy/Caddyfile","line":2}
{"level":"info","ts":1645317282.00131,"logger":"admin","msg":"admin endpoint started","address":"tcp/localhost:2019","enforce_origin":false,"origins":["localhost:2019","[::1]:2019","<IP_ADDRESS>:2019"]}
{"level":"info","ts":1645317282.001372,"logger":"git","msg":"provisioning app instance","app":"git"}
{"level":"debug","ts":1645317285.2619414,"logger":"git","msg":"repo is already up to date","repo_name":"love4taylor-ruleset"}
{"level":"debug","ts":1645317285.2619793,"logger":"git","msg":"registered and synced repo","repo_name":"love4taylor-ruleset"}
{"level":"info","ts":1645317285.2619848,"logger":"git","msg":"provisioned app instance","app":"git"}
{"level":"info","ts":1645317285.262361,"logger":"tls.cache.maintenance","msg":"started background certificate maintenance","cache":"0xc000444380"}
{"level":"info","ts":1645317285.3132598,"logger":"http","msg":"server is listening only on the HTTPS port but has no TLS connection policies; adding one to enable TLS","server_name":"srv0","https_port":8082}
{"level":"info","ts":1645317285.3132977,"logger":"http","msg":"enabling automatic HTTP->HTTPS redirects","server_name":"srv0"}
{"level":"info","ts":1645317285.3135202,"logger":"http.handlers.git","msg":"provisioned plugin instance","instance_name":"git-love4taylor-ruleset","started_at":1645317285.3135188}
{"level":"info","ts":1645317285.3135424,"logger":"http.handlers.git","msg":"validated plugin instance","instance_name":"git-love4taylor-ruleset"}
{"level":"warn","ts":1645317285.3289602,"logger":"pki.ca.local","msg":"installing root certificate (you might be prompted for password)","path":"storage:pki/authorities/local/root.crt"}
2022/02/20 00:34:45 Warning: "certutil" is not available, install "certutil" with "apt install libnss3-tools" or "yum install nss-tools" and try again
2022/02/20 00:34:45 define JAVA_HOME environment variable to use the Java trust
{"level":"error","ts":1645317285.345407,"logger":"pki.ca.local","msg":"failed to install root certificate","error":"failed to execute tee: exit status 1","certificate_file":"storage:pki/authorities/local/root.crt"}
{"level":"info","ts":1645317285.3455324,"logger":"tls","msg":"cleaning storage unit","description":"FileStorage:/data/caddy"}
{"level":"debug","ts":1645317285.3456984,"logger":"http","msg":"starting server loop","address":"[::]:8082","http3":false,"tls":true}
{"level":"debug","ts":1645317285.3457665,"logger":"http","msg":"starting server loop","address":"[::]:8081","http3":false,"tls":false}
{"level":"info","ts":1645317285.3457866,"logger":"http","msg":"enabling automatic TLS certificate management","domains":["<IP_ADDRESS>","localhost"]}
{"level":"debug","ts":1645317285.346434,"logger":"git","msg":"starting git repo manager","app":"git"}
{"level":"debug","ts":1645317285.3464844,"logger":"git","msg":"started git repo manager","app":"git"}
{"level":"info","ts":1645317285.346653,"msg":"autosaved config (load with --resume flag)","file":"/config/caddy/autosave.json"}
{"level":"info","ts":1645317285.3467133,"msg":"serving initial configuration"}
{"level":"info","ts":1645317285.3469188,"logger":"tls.obtain","msg":"acquiring lock","identifier":"<IP_ADDRESS>"}
{"level":"info","ts":1645317285.34709,"logger":"tls.obtain","msg":"acquiring lock","identifier":"localhost"}
{"level":"info","ts":1645317285.3486009,"logger":"tls","msg":"finished cleaning storage units"}
{"level":"info","ts":1645317285.3653588,"logger":"tls.obtain","msg":"lock acquired","identifier":"<IP_ADDRESS>"}
{"level":"info","ts":1645317285.3653681,"logger":"tls.obtain","msg":"lock acquired","identifier":"localhost"}
{"level":"debug","ts":1645317285.3658006,"logger":"tls.obtain","msg":"trying issuer 1/1","issuer":"local"}
{"level":"debug","ts":1645317285.3659308,"logger":"tls.obtain","msg":"trying issuer 1/1","issuer":"local"}
{"level":"info","ts":1645317285.3667057,"logger":"tls.obtain","msg":"certificate obtained successfully","identifier":"<IP_ADDRESS>"}
{"level":"info","ts":1645317285.3667252,"logger":"tls.obtain","msg":"releasing lock","identifier":"<IP_ADDRESS>"}
{"level":"info","ts":1645317285.3668232,"logger":"tls.obtain","msg":"certificate obtained successfully","identifier":"localhost"}
{"level":"info","ts":1645317285.3668592,"logger":"tls.obtain","msg":"releasing lock","identifier":"localhost"}
{"level":"warn","ts":1645317285.3670905,"logger":"tls","msg":"stapling OCSP","error":"no OCSP stapling for [<IP_ADDRESS>]: no OCSP server specified in certificate"}
{"level":"debug","ts":1645317285.3671472,"logger":"tls.cache","msg":"added certificate to cache","subjects":["<IP_ADDRESS>"],"expiration":1645360485,"managed":true,"issuer_key":"local","hash":"ee0587353a6020ec79a0c9a158ae579572433c131373fe69c1cf659dee39f82f","cache_size":1,"cache_capacity":10000}
{"level":"warn","ts":1645317285.3673387,"logger":"tls","msg":"stapling OCSP","error":"no OCSP stapling for [localhost]: no OCSP server specified in certificate"}
{"level":"debug","ts":1645317285.367362,"logger":"tls.cache","msg":"added certificate to cache","subjects":["localhost"],"expiration":1645360485,"managed":true,"issuer_key":"local","hash":"dfd3b798e2ca76f36ee588eb77233bb9948662607614da1ce7c286072c3ad85a","cache_size":2,"cache_capacity":10000}
{"level":"debug","ts":1645317488.2705314,"logger":"tls.handshake","msg":"no matching certificates and no custom selection logic","identifier":"<IP_ADDRESS>"}
{"level":"debug","ts":1645317488.270603,"logger":"tls.handshake","msg":"no certificate matching TLS ClientHello","server_name":"","remote":"<IP_ADDRESS>:38272","identifier":"<IP_ADDRESS>","cipher_suites":[4866,4867,4865,49196,49200,159,52393,52392,52394,49195,49199,158,49188,49192,107,49187,49191,103,49162,49172,57,49161,49171,51,157,156,61,60,53,47,255],"cert_cache_fill":0.0002,"load_if_necessary":true,"obtain_if_necessary":true,"on_demand":false}
{"level":"debug","ts":1645317488.2706978,"logger":"http.stdlib","msg":"http: TLS handshake error from <IP_ADDRESS>:38272: no certificate available for '<IP_ADDRESS>'"}
{"level":"debug","ts":1645317495.3779979,"logger":"tls.handshake","msg":"no matching certificates and no custom selection logic","identifier":"<IP_ADDRESS>"}
{"level":"debug","ts":1645317495.3780327,"logger":"tls.handshake","msg":"no certificate matching TLS ClientHello","server_name":"","remote":"<IP_ADDRESS>:38294","identifier":"<IP_ADDRESS>","cipher_suites":[4866,4867,4865,49196,49200,159,52393,52392,52394,49195,49199,158,49188,49192,107,49187,49191,103,49162,49172,57,49161,49171,51,157,156,61,60,53,47,255],"cert_cache_fill":0.0002,"load_if_necessary":true,"obtain_if_necessary":true,"on_demand":false}
{"level":"debug","ts":1645317495.378101,"logger":"http.stdlib","msg":"http: TLS handshake error from <IP_ADDRESS>:38294: no certificate available for '<IP_ADDRESS>'"}
{"level":"debug","ts":1645317503.8497517,"logger":"tls.handshake","msg":"choosing certificate","identifier":"localhost","num_choices":1}
{"level":"debug","ts":1645317503.8498013,"logger":"tls.handshake","msg":"default certificate selection results","identifier":"localhost","subjects":["localhost"],"managed":true,"issuer_key":"local","hash":"dfd3b798e2ca76f36ee588eb77233bb9948662607614da1ce7c286072c3ad85a"}
{"level":"debug","ts":1645317503.8498123,"logger":"tls.handshake","msg":"matched certificate in cache","subjects":["localhost"],"managed":true,"expiration":1645360485,"hash":"dfd3b798e2ca76f36ee588eb77233bb9948662607614da1ce7c286072c3ad85a"}
{"level":"debug","ts":1645317503.851655,"logger":"http.handlers.git","msg":"received update git repo request","repo_name":"love4taylor-ruleset"}
{"level":"debug","ts":1645317505.2986476,"logger":"git","msg":"repo is already up to date","repo_name":"love4taylor-ruleset"}
{"level":"info","ts":1645317534.7956712,"msg":"shutting down apps, then terminating","signal":"SIGTERM"}
{"level":"warn","ts":1645317534.7957308,"msg":"exiting; byeee!! 👋","signal":"SIGTERM"}
{"level":"debug","ts":1645317534.7957864,"logger":"git","msg":"stopping git repo manager","app":"git"}
{"level":"debug","ts":1645317534.7958012,"logger":"git","msg":"stopped git repo manager","app":"git"}
{"level":"info","ts":1645317534.7986774,"logger":"tls.cache.maintenance","msg":"stopped background certificate maintenance","cache":"0xc000444380"}
{"level":"info","ts":1645317534.799908,"logger":"admin","msg":"stopped previous server","address":"tcp/localhost:2019"}
{"level":"info","ts":1645317534.7999356,"msg":"shutdown complete","signal":"SIGTERM","exit_code":0}
{"level":"info","ts":1645317535.7761204,"msg":"using provided configuration","config_file":"/etc/caddy/Caddyfile","config_adapter":"caddyfile"}
{"level":"warn","ts":1645317535.7772198,"msg":"input is not formatted with 'caddy fmt'","adapter":"caddyfile","file":"/etc/caddy/Caddyfile","line":2}
{"level":"info","ts":1645317535.7782493,"logger":"admin","msg":"admin endpoint started","address":"tcp/localhost:2019","enforce_origin":false,"origins":["localhost:2019","[::1]:2019","<IP_ADDRESS>:2019"]}
{"level":"info","ts":1645317535.7784822,"logger":"tls.cache.maintenance","msg":"started background certificate maintenance","cache":"0xc000290af0"}
{"level":"info","ts":1645317535.7802722,"logger":"git","msg":"provisioning app instance","app":"git"}
{"level":"debug","ts":1645317537.222351,"logger":"git","msg":"repo is already up to date","repo_name":"love4taylor-ruleset"}
{"level":"debug","ts":1645317537.2223997,"logger":"git","msg":"registered and synced repo","repo_name":"love4taylor-ruleset"}
{"level":"info","ts":1645317537.2224054,"logger":"git","msg":"provisioned app instance","app":"git"}
{"level":"info","ts":1645317537.2225065,"logger":"http","msg":"server is listening only on the HTTPS port but has no TLS connection policies; adding one to enable TLS","server_name":"srv0","https_port":8082}
{"level":"info","ts":1645317537.2225287,"logger":"http","msg":"enabling automatic HTTP->HTTPS redirects","server_name":"srv0"}
{"level":"info","ts":1645317537.2227457,"logger":"http.handlers.git","msg":"provisioned plugin instance","instance_name":"git-love4taylor-ruleset","started_at":1645317537.2227442}
{"level":"info","ts":1645317537.2227683,"logger":"http.handlers.git","msg":"validated plugin instance","instance_name":"git-love4taylor-ruleset"}
{"level":"warn","ts":1645317537.2388208,"logger":"pki.ca.local","msg":"installing root certificate (you might be prompted for password)","path":"storage:pki/authorities/local/root.crt"}
2022/02/20 00:38:57 define JAVA_HOME environment variable to use the Java trust
2022/02/20 00:38:57 Warning: "certutil" is not available, install "certutil" with "apt install libnss3-tools" or "yum install nss-tools" and try again
{"level":"error","ts":1645317537.2409725,"logger":"pki.ca.local","msg":"failed to install root certificate","error":"failed to execute tee: exit status 1","certificate_file":"storage:pki/authorities/local/root.crt"}
{"level":"debug","ts":1645317537.2410312,"logger":"git","msg":"starting git repo manager","app":"git"}
{"level":"debug","ts":1645317537.2410405,"logger":"git","msg":"started git repo manager","app":"git"}
{"level":"info","ts":1645317537.2411504,"logger":"tls","msg":"cleaning storage unit","description":"FileStorage:/data/caddy"}
{"level":"debug","ts":1645317537.2412264,"logger":"http","msg":"starting server loop","address":"[::]:8082","http3":false,"tls":true}
{"level":"debug","ts":1645317537.2412918,"logger":"http","msg":"starting server loop","address":"[::]:8081","http3":false,"tls":false}
{"level":"info","ts":1645317537.2413104,"logger":"http","msg":"enabling automatic TLS certificate management","domains":["<IP_ADDRESS>","localhost"]}
{"level":"warn","ts":1645317537.2423644,"logger":"tls","msg":"stapling OCSP","error":"no OCSP stapling for [<IP_ADDRESS>]: no OCSP server specified in certificate"}
{"level":"debug","ts":1645317537.2423923,"logger":"tls.cache","msg":"added certificate to cache","subjects":["<IP_ADDRESS>"],"expiration":1645360485,"managed":true,"issuer_key":"local","hash":"ee0587353a6020ec79a0c9a158ae579572433c131373fe69c1cf659dee39f82f","cache_size":1,"cache_capacity":10000}
{"level":"warn","ts":1645317537.2432933,"logger":"tls","msg":"stapling OCSP","error":"no OCSP stapling for [localhost]: no OCSP server specified in certificate"}
{"level":"debug","ts":1645317537.243319,"logger":"tls.cache","msg":"added certificate to cache","subjects":["localhost"],"expiration":1645360485,"managed":true,"issuer_key":"local","hash":"dfd3b798e2ca76f36ee588eb77233bb9948662607614da1ce7c286072c3ad85a","cache_size":2,"cache_capacity":10000}
{"level":"info","ts":1645317537.243426,"msg":"autosaved config (load with --resume flag)","file":"/config/caddy/autosave.json"}
{"level":"info","ts":1645317537.2434363,"msg":"serving initial configuration"}
{"level":"info","ts":1645317537.2550898,"logger":"tls","msg":"finished cleaning storage units"}
{"level":"debug","ts":1645317565.6120722,"logger":"tls.handshake","msg":"choosing certificate","identifier":"localhost","num_choices":1}
{"level":"debug","ts":1645317565.6121302,"logger":"tls.handshake","msg":"default certificate selection results","identifier":"localhost","subjects":["localhost"],"managed":true,"issuer_key":"local","hash":"dfd3b798e2ca76f36ee588eb77233bb9948662607614da1ce7c286072c3ad85a"}
{"level":"debug","ts":1645317565.612141,"logger":"tls.handshake","msg":"matched certificate in cache","subjects":["localhost"],"managed":true,"expiration":1645360485,"hash":"dfd3b798e2ca76f36ee588eb77233bb9948662607614da1ce7c286072c3ad85a"}
{"level":"debug","ts":1645317565.613072,"logger":"http.stdlib","msg":"http: TLS handshake error from <IP_ADDRESS>:38402: local error: tls: bad record MAC"}
{"level":"debug","ts":1645317575.300677,"logger":"tls.handshake","msg":"choosing certificate","identifier":"localhost","num_choices":1}
{"level":"debug","ts":1645317575.3007228,"logger":"tls.handshake","msg":"default certificate selection results","identifier":"localhost","subjects":["localhost"],"managed":true,"issuer_key":"local","hash":"dfd3b798e2ca76f36ee588eb77233bb9948662607614da1ce7c286072c3ad85a"}
{"level":"debug","ts":1645317575.3007333,"logger":"tls.handshake","msg":"matched certificate in cache","subjects":["localhost"],"managed":true,"expiration":1645360485,"hash":"dfd3b798e2ca76f36ee588eb77233bb9948662607614da1ce7c286072c3ad85a"}
{"level":"debug","ts":1645317575.3027444,"logger":"http.handlers.git","msg":"received update git repo request","repo_name":"love4taylor-ruleset"}
{"level":"debug","ts":1645317576.882386,"logger":"git","msg":"repo is already up to date","repo_name":"love4taylor-ruleset"}
{"level":"debug","ts":1645317649.3147297,"logger":"tls.handshake","msg":"choosing certificate","identifier":"localhost","num_choices":1}
{"level":"debug","ts":1645317649.3147724,"logger":"tls.handshake","msg":"default certificate selection results","identifier":"localhost","subjects":["localhost"],"managed":true,"issuer_key":"local","hash":"dfd3b798e2ca76f36ee588eb77233bb9948662607614da1ce7c286072c3ad85a"}
{"level":"debug","ts":1645317649.3147976,"logger":"tls.handshake","msg":"matched certificate in cache","subjects":["localhost"],"managed":true,"expiration":1645360485,"hash":"dfd3b798e2ca76f36ee588eb77233bb9948662607614da1ce7c286072c3ad85a"}
{"level":"debug","ts":1645317649.3167217,"logger":"http.handlers.git","msg":"received update git repo request","repo_name":"love4taylor-ruleset"}
{"level":"warn","ts":1645317650.73021,"logger":"http.handlers.git","msg":"failed updating repo","repo_name":"love4taylor-ruleset","error":"object not found"}

hmmmm, I just tried by removing depth 1 which solved my problem, It will no longer prompt object not found, and will not report error 500.

@love4taylor , there is a bug in the upstream repo related to the depth. I opened an issue about it. Will follow up on it.
once you removed depth, you got it working fine, correct?

Yes, it works fine after removing the depth. I've pushed a few commits on GitHub, and the webhook is returning 200 and caddy-git is pulling the latest commits correctly.

So sadly I removed the depth config setting and am still getting the the object not found error.
Here is my config...
{
    debug
    email<EMAIL_ADDRESS>    acme_dns cloudflare JQCVL2k9w2ysylB-_pNmRMTuInVYEg9QBOoAmixG
    git {
        repo aspecthq.com {
            base_dir /var/www/aspecthq.com
            url https://github.com/joeworkman/aspecthq.com.git
            branch master
        }
    }

}
aspecthq.com {
    redir https://www.aspecthq.com{uri}
}
www.aspecthq.com {
    route /update {
        git update repo aspecthq.com
    }
    encode gzip zstd
    php_fastcgi unix//run/php/php8.1-fpm.sock
    root * /var/www/aspecthq.com/aspecthq.com
    file_server
    push
}

Everything seems to be working now that I removed the repo from the server and let the plugin clone it. I can restart caddy and things are working. Hooks are doing there thing.
Now time to see if I can get it working on a private repo again.


update metadata

OPS Build status updates of commit fc6f123:
:clock10: Preparing: average preparing time is 1 min(s) 32 sec(s)

OPS Build status updates of commit fc6f123:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 108: [Error] Restore nuget package W:\qzjx-s.optemp\dependentPackages\Microsoft.OpenPublishing.CommonPlugins\packages.config in folder:W:\qzjx-s.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in http://SiteHelp. Detailed error:  Errors in packages.config projects     Unable to find version '1.0.141' of package 'Microsoft.OpenPublishing.CommonPlugins'.       D:\Windows\system32\config\systemprofile.nuget\packages: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.141' is not found on source 'D:\Windows\system32\config\systemprofile.nuget\packages'.       https://www.myget.org/F/op/api/v2: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.141' is not found on source 'https://www.myget.org/F/op/api/v2'.
Line 290: [Error] Restore dependent packages failed

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Every admin token param but uid can be null

Hi @krizzu
I saw every admin token param can be null but uid.
#6
Thanks!

Can you point me to your sources? Seems like just email could be null

Yes, I saw that too, but here I can see other params can be null. CreateRequest is also a class with builder pattern, so permits to create a user with no attributes.
I got getName() NullPointerException error and that makes me search about this.
Thanks!

I think it'd be safe to assume that at least UID is non-nullable. Looking at source code for the class, does not tell much either, unfortunately.
From the other hand, looking at constructor of the class, it seems that claims is also required property, so we could un-null this one too. WDYT?

@krizzu Yes, you are right, claims would be an empty list but non-null.
FIXED at #6

Thanks, fixed in #6


for the crypto/tls library, I used the Funciton tls.X509KeyPair() to generate the Cert. the error msg is "x509: unsupported elliptic curve".

hi,
my go version is 1.16.3 in linux. (docker container environment)
for the crypto/tls library, I used the Funciton tls.X509KeyPair() to generate the Cert. the error msg is "x509: unsupported elliptic curve".
background: the .crt & .key (means Certificates and Private Keys) is generated by openssl, which algorithm is sm2 and sm3.
the sm2 & sm3 are algorithms from a OpenSSL after modification.
the cert and key file can parse by our openssl command, but cannot parse by the crypto/tls library , so I want to know the golang, Does it depend on The Openssl (maybe .so lib file)  in the container?
thanks very much
good health

no
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


onCancel should return error

Currently onCancel is very opaque and doesnt return the error that caused the cancel

hi @revofusion, has this issue been resolved in the latest version of sats-connect?
thanks! 🙏


Open in Terminal for folder does not work with Ubuntu

VSCode Version: Code - Insiders 1.15.0-insider (2c3e2c291c515619f64e7c9cddf14c565b7f3d92, 2017-08-08T21:31:44.273Z)
OS Version: Windows_NT x64 10.0.16251
Extensions:

Extension
Author (truncated)
Version

vscode-eslint
dba
1.2.11

coldfusion
ili
0.0.10

wordcount
ms-
0.1.0

htmlescape-vscode-extension
ray
0.0.4

spellchecker
swy
1.2.13

Steps to Reproduce:

Right click on a folder and select open in terminal
Opens in /home/ray

I would expect it to be /mnt/c/projects/foo (or some such, the location of my folder)

Duplicate of https://github.com/Microsoft/vscode/issues/32717


[WIP] Refactor ACS1.

:x: Build AElf <IP_ADDRESS>73 failed (commit https://github.com/AElfProject/AElf/commit/e42f6d92c0 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>27 failed (commit https://github.com/AElfProject/AElf/commit/b0c24fc62b by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>31 failed (commit https://github.com/AElfProject/AElf/commit/d5d3240671 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>44 failed (commit https://github.com/AElfProject/AElf/commit/574f5d1660 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>52 failed (commit https://github.com/AElfProject/AElf/commit/550133fb4a by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>56 failed (commit https://github.com/AElfProject/AElf/commit/b4f4f288bb by @jason-hoopox)

:white_check_mark: Build AElf <IP_ADDRESS>61 completed (commit https://github.com/AElfProject/AElf/commit/a8482b0ca5 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>75 failed (commit https://github.com/AElfProject/AElf/commit/7bebb2ad51 by @EricBlack)

:x: Build AElf <IP_ADDRESS>20 failed (commit https://github.com/AElfProject/AElf/commit/7e4c13210c by @)

:x: Build AElf <IP_ADDRESS>44 failed (commit https://github.com/AElfProject/AElf/commit/2100391c8b by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>46 failed (commit https://github.com/AElfProject/AElf/commit/633ad01777 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>48 failed (commit https://github.com/AElfProject/AElf/commit/bc7da4349b by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>50 failed (commit https://github.com/AElfProject/AElf/commit/afb525304e by @EricBlack)

:x: Build AElf <IP_ADDRESS>66 failed (commit https://github.com/AElfProject/AElf/commit/6c4b4d3da4 by @EanCuznaivy)

Codecov Report

Merging #2065 into dev will decrease coverage by 84.16%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev   #2065       +/-   ##
==========================================
- Coverage   84.16%      0%   -84.17%
==========================================
  Files         618     427      -191
  Lines       22752   16470     -6282
==========================================
- Hits        19149       0    -19149
- Misses       3603   16470    +12867

Impacted Files
Coverage Δ

src/AElf.Kernel.Consensus/ConsensusAElfModule.cs
0% <ø> (-100%)
:arrow_down:

...el.SmartContract/HostSmartContractBridgeContext.cs
0% <ø> (-96.88%)
:arrow_down:

...cts.Consensus.AEDPoS/AEDPoSContract_HelpMethods.cs
0% <ø> (-82.83%)
:arrow_down:

...eneration/Strategies/NormalBlockCommandStrategy.cs
0% <0%> (ø)
:arrow_up:

...f.Contracts.Election/ElectionContract_Candidate.cs
0% <0%> (-96.7%)
:arrow_down:

...DPoS/AEDPoSContract_ProcessConsensusInformation.cs
0% <0%> (-83.59%)
:arrow_down:

...ct/AElf.Contracts.MultiToken/TokenContractState.cs
0% <0%> (-100%)
:arrow_down:

...Elf.Contracts.Election/ElectionContract_Elector.cs
0% <0%> (-100%)
:arrow_down:

...lf.Contracts.ParliamentAuth/ParliamentAuthState.cs
0% <0%> (-100%)
:arrow_down:

...ultiToken/TokenContract_ACS2_StatePathsProvider.cs
0% <0%> (-56.53%)
:arrow_down:

... and 620 more

:x: Build AElf <IP_ADDRESS>93 failed (commit https://github.com/AElfProject/AElf/commit/fa02b6a978 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>11 failed (commit https://github.com/AElfProject/AElf/commit/3cc31ff2a3 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>15 failed (commit https://github.com/AElfProject/AElf/commit/67bb14bd6a by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>25 failed (commit https://github.com/AElfProject/AElf/commit/0fa194f0da by @jason-hoopox)

:x: Build AElf <IP_ADDRESS>32 failed (commit https://github.com/AElfProject/AElf/commit/d235b22e0d by @shiwk)

:x: Build AElf <IP_ADDRESS>36 failed (commit https://github.com/AElfProject/AElf/commit/944f3bb79c by @EanCuznaivy)

:white_check_mark: Build AElf <IP_ADDRESS>39 completed (commit https://github.com/AElfProject/AElf/commit/9f7b851249 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>62 failed (commit https://github.com/AElfProject/AElf/commit/60f39f5173 by @EanCuznaivy)


fisher: cannot connect to server -- looking in ~/.cache/fisher/github.com/jorgebucaran/fish-bax

I've installed bax through fisher and noticed that this message is issued whenever i run fisher to update all installed fish packages.  I'm pretty sure this message has started popping up rather recently.  What's the meaning of that message?
I'm running fish 3.1.2 and bax 1.0.0.

@tsdh Fisher 3.1.2 tries to install plugins from the master branch, but I recently changed Bax default branch to main, so  fisher can't find it and tries to install it from the cache. The latest fisher uses the repository's HEAD, so it works for whatever the default branch is. Please upgrade with fisher self-update.

That's it, thanks!


Support order by?

I tried plugging in your cache, but I get this when i do an order by:
Unable to cast object of type 'EFSecondLevelCache.Core.EFCachedQueryable`1[MontagePortal.DTO.Base.CrmRefDTO]' to type 'System.Linq.IOrderedQueryable

Yes, It does. Follow these samples.

So Cacheable has to come after OrderBy? In my case I don't want that. I want the client to be able to sort the cached results as they see fit.

No. It's a LINQ to Entities cache only, not LINQ to Objects.


Worker API should provide safe defaults that increase performance in most cases

When enabling worker APIs in third party plugins, such as kapt with kapt.use.worker.api=true, We have noticed slower build speeds due to workers consuming extra memory. Our builds seen an increase in time spent garbage collecting due to the extra workers and end up being slower.
It would be nice if Gradle would have safe defaults for the number of workers that would increase performance in most scenarios. Many teams do not have dedicated build engineers or resources to dedicate to this so it would be nice if the default would improve performance in most projects. Teams with additional resources would then be free to further optimize these values.
Let me know what additional information I can/should provide here.
My understanding is that the current default is # of CPUs. Perhaps a safer default would be # of CPUs / 2? Just tossing ideas out there.

This could be handled automatically by Gradle, or plugin authors can provide CPU/memory hints for the worker actions. Using those resource usage hints, scheduling can be more efficient.

It's still an important issue, now it requires multiple manual measurements and still not dynamic enough

It still looks like an important feature. It's hard now to measure such things and detect issues with memory and parallelism.


Are you accepting contributions?

Hey,
I love the app and really appreciate you creating it. Are you willing to open source the code? That would allow others to contribute as well. I came here looking to see how this was built and to determine if I could figure out how to build a feature I was looking for, syncing multiple players' which you seem to have on the backlog already.

Hi,
the code is now in this repository. If you still would like to work on the app you are welcome.
Regards

Thanks. I'll take a look and see how I can be of value.


[Performance Tuning] The performance improvement of Apache pulsar has encountered a bottleneck. No matter how to modify the configuration parameters, the performance can not be effectively improved

Deployment environment
Apache pulsar is deployed in a standalone manner. The three components of zookeeper, bookkeeper and broker are deployed on the same server (8-core CPU, 16g memory and a 7200 RPM HDD). At the same time, this server is basically only used to run pulsar services
In addition, there are two other servers in the same LAN (the specificationof these two servers is consistent with that of the server running pulsar), which run pulsar perf producer and pulsar perf consumer clients respectively, and publish and consume msg to pulsar server respectively

The default size of MSG sent by pulsar perf producer is 1KB

Throughput
At present, no matter how to adjust the JVM size of the component, the publish pending queue size of the broker, the managedledgercache size, the write / read cache size of bookie, the number of related worker threads, the sending queue size of pulsar perf producer and other parameters, the throughput of pulsar perf producer is always about 8W MSG / S ~ 9W MSG / s

The amount of data sent by pulsar-perf is almost 600 MIB / S ~ 700 MIB / s.
The write pressure of the hard disk on the pulsar server is almost always about 160 MIB / S ~ 190 MIB / s.
The total utilization rate of the CPU is almost below 50%, but the iowait of some cores can reach 95%,
there is basically no read pressure on the disk, It should be because the consumer directly takes the data from the managedledgercache
the server running pulsar still has a lot of space in memory that has not been used

My question
Finally, my question is: in this case, is it because the write capacity of the hard disk of the pulsar server has reached the bottleneck that can not improve the throughput of the producer?
Thx a lot :)

test result via pulsar-perf producer
08:13:19.198 [main] INFO  org.apache.pulsar.testclient.PerformanceProducer - Throughput produced:  875381 msg ---  87516.3 msg/s ---    683.7 Mbit/s --- failure      0.0 msg/s --- Latency: mean:  52.876 ms - med:  20.207 - 95pct: 249.615 - 99pct: 455.123 - 99.9pct: 502.465 - 99.99pct: 508.589 - Max: 508.685
08:13:29.746 [main] INFO  org.apache.pulsar.testclient.PerformanceProducer - Throughput produced: 1849891 msg ---  91580.3 msg/s ---    715.5 Mbit/s --- failure      0.0 msg/s --- Latency: mean: 498.103 ms - med: 515.241 - 95pct: 960.091 - 99pct: 1093.815 - 99.9pct: 1122.831 - 99.99pct: 1131.015 - Max: 1131.223
08:13:40.364 [main] INFO  org.apache.pulsar.testclient.PerformanceProducer - Throughput produced: 2905938 msg ---  99398.3 msg/s ---    776.5 Mbit/s --- failure      0.0 msg/s --- Latency: mean: 1088.251 ms - med: 1089.967 - 95pct: 1561.623 - 99pct: 1677.375 - 99.9pct: 1733.335 - 99.99pct: 1741.903 - Max: 1742.007
08:13:50.596 [main] INFO  org.apache.pulsar.testclient.PerformanceProducer - Throughput produced: 3810687 msg ---  88421.4 msg/s ---    690.8 Mbit/s --- failure      0.0 msg/s --- Latency: mean: 1611.106 ms - med: 1502.415 - 95pct: 2161.119 - 99pct: 2506.303 - 99.9pct: 2525.871 - 99.99pct: 2527.695 - Max: 2528.335
08:14:00.684 [main] INFO  org.apache.pulsar.testclient.PerformanceProducer - Throughput produced: 4716034 msg ---  89742.4 msg/s ---    701.1 Mbit/s --- failure      0.0 msg/s --- Latency: mean: 1594.227 ms - med: 1489.903 - 95pct: 2224.655 - 99pct: 2335.935 - 99.9pct: 2482.719 - 99.99pct: 2484.191 - Max: 2484.927
08:14:10.774 [main] INFO  org.apache.pulsar.testclient.PerformanceProducer - Throughput produced: 5615882 msg ---  89195.6 msg/s ---    696.8 Mbit/s --- failure      0.0 msg/s --- Latency: mean: 1631.398 ms - med: 1521.023 - 95pct: 2285.535 - 99pct: 2413.855 - 99.9pct: 2445.103 - 99.99pct: 2446.287 - Max: 2446.655
08:14:20.863 [main] INFO  org.apache.pulsar.testclient.PerformanceProducer - Throughput produced: 6507666 msg ---  88378.4 msg/s ---    690.5 Mbit/s --- failure      0.0 msg/s --- Latency: mean: 1669.414 ms - med: 1560.631 - 95pct: 2295.327 - 99pct: 2558.671 - 99.9pct: 2576.607 - 99.99pct: 2577.631 - Max: 2577.887
08:14:30.950 [main] INFO  org.apache.pulsar.testclient.PerformanceProducer - Throughput produced: 7425263 msg ---  90974.2 msg/s ---    710.7 Mbit/s --- failure      0.0 msg/s --- Latency: mean: 1730.611 ms - med: 1649.391 - 95pct: 2397.487 - 99pct: 2599.951 - 99.9pct: 2652.735 - 99.99pct: 2654.143 - Max: 2654.431
08:14:41.055 [main] INFO  org.apache.pulsar.testclient.PerformanceProducer - Throughput produced: 8299595 msg ---  86562.4 msg/s ---    676.3 Mbit/s --- failure      0.0 msg/s --- Latency: mean: 1657.870 ms - med: 1572.207 - 95pct: 2387.599 - 99pct: 2430.863 - 99.9pct: 2444.319 - 99.99pct: 2446.687 - Max: 2447.167
08:14:51.154 [main] INFO  org.apache.pulsar.testclient.PerformanceProducer - Throughput produced: 9235450 msg ---  92741.4 msg/s ---    724.5 Mbit/s --- failure      0.0 msg/s --- Latency: mean: 1615.089 ms - med: 1512.783 - 95pct: 2243.711 - 99pct: 2356.495 - 99.9pct: 2366.927 - 99.99pct: 2367.519 - Max: 2367.887
08:15:01.242 [main] INFO  org.apache.pulsar.testclient.PerformanceProducer - Throughput produced: 10089040 msg ---  84536.6 msg/s ---    660.4 Mbit/s --- failure      0.0 msg/s --- Latency: mean: 1664.701 ms - med: 1563.031 - 95pct: 2200.735 - 99pct: 2847.119 - 99.9pct: 2861.167 - 99.99pct: 2862.719 - Max: 2863.071
08:15:10.114 [pulsar-perf-producer-exec-1-1] INFO  org.apache.pulsar.testclient.PerformanceProducer - ------------------- DONE -----------------------
08:15:10.208 [pulsar-perf-producer-exec-1-1] INFO  org.apache.pulsar.testclient.PerformanceProducer - Aggregated latency stats --- Latency: mean: 1384.224 ms - med: 1488.583 - 95pct: 2223.519 - 99pct: 2526.335 - 99.9pct: 2876.991 - 99.99pct: 2959.215 - 99.999pct: 3059.823 - Max: 3060.239
08:15:15.211 [Thread-1] INFO  org.apache.pulsar.testclient.PerformanceProducer - Aggregated throughput stats --- 10951697 records sent --- 86800.055 msg/s --- 678.125 Mbit/s
08:15:15.272 [Thread-1] INFO  org.apache.pulsar.testclient.PerformanceProducer - Aggregated latency stats --- Latency: mean: 1925.447 ms - med: 1855.311 - 95pct: 2669.967 - 99pct: 2677.551 - 99.9pct: 2679.759 - 99.99pct: 2679.919 - 99.999pct: 2679.951 - Max: 2679.951

hello, if you want to do performance testing I suggest you to:

install the component on separate machines
for write workloads the bottleneck is usually the disk of the Journal on the bookie, ensure to have a good disk
usually it is better to enlarge the writeCache on the Bookie in conf/bookkeeper.conf:

  dbStorage_rocksDB_blockCacheSize: '4294967296'
  dbStorage_writeCacheMaxSizeMb: '2048'

you can use partitioned topics in order to spread the load among several brokers, and also even with a single broker with partitioned topics you can use better the resources of the broker

The three components of zookeeper, bookkeeper and broker are deployed on the same server (8-core CPU, 16g memory and a 7200 RPM HDD)

Finally, my question is: in this case, is it because the write capacity of the hard disk of the pulsar server has reached the bottleneck that can not improve the throughput of the producer?

It is crucial for performance to use fast SSD disks for Zookeeper and Bookkeeper. Using spinning HDD disks with Pulsar is not recommended since performance can suffer.
If you cannot afford SSDs for all data, it's possible to use HDD disks for Bookkeeper ledger disks. Bookkeeper can use separate journal and ledger disks. When using HDD disks on bare metal, a battery backed write cache (BBWC) setup improves write throughput performance and reduces write latency drastically.
Besides bottlenecks in Disk IO, there might be multiple reasons why you have performance problems. Jack Vanlightly has also blog posts about this in https://medium.com/splunk-maas/the-importance-of-mental-models-for-incident-response-da1bfcfdcacd . Having Prometheus/Grafana dashboards will help understand the bottlenecks and what is needed to resolve the issues.


[Enquiry]Will there be any plan to release the code?

Hi authors,
Congratulations on your very insightful and solid work.
I would appreciate it if you could publicize your timeline for the code release.
I am looking forward to giving it a try once the code is released.

Dear Qian, apologies for the late reply - I was participating in South Korea's mandatory military training, which prevented me from responding sooner. We are planning to release the code next week.

Hi Jinwoo,
I am glad to hear back from you.
I will wait for the release and then may ask for more details.
Thanks again for your reply!
Best,
Qian

Hi Jinwoo, @jw9730
I hope this message finds you well.
Is there any update on the timeline?
Best,
Qian

Hi Qian, sorry for keeping you waiting. I've just uploaded the code for random walk records and DeBERTa experiments. This should be sufficient for you to try out our random walk and understand how it is recorded into text. I'll update the rest of the code and instructions for DeBERTa and llama 3 experiments soon.

Hi Jinwoo,
Thanks for your reply.
The guideline released with your code is very detailed, and I really appreciate it!
Best,
Qian


Support button action

Platforms Impacted

[ ] iOS
[X] macOS

Description of changes
In the current button implementation, we override the mouse events to customize the mouse down behavior. Since we are not calling the super class, we need to manually trigger the target action.
Verification
In the test app, ensured the button action is executed (mouse & keyboard), and the mouse events are fired.
Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[X] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)

Microsoft Reviewers: Open in CodeFlow

Has this just always been broken? Or was this broken recently?

It has always been broken.


ImportError: cannot import name 'is_authenticated' with Django REST Framework 3.7.x

Issue type
[ ] Feature request
[x] Bug report
[ ] Documentation
Environment

Python version:  3.4.3
NetBox version:  2.1.5

Description
Django REST Framework 3.7.0 was released today. This release removes compatibility code  (originally added to support out-of-date Django versions) which we are using in one of the utility classes.
Workaround
Install a DRF release prior to 3.7.0:
pip3 install djangorestframework==3.6.4

posted an hour before i could. This workaround does not apply to the beta 2.2 release. Installing and then reverting the framework is fine on 2.1.5. Causes a "reported to administrator error on beta2"

@DirtyCajunRice I have no issue running v2.2-beta2 with DRF 3.6.4. What is the error being reported?

@jeremystretch
Error:

Fixed it by forcing requirements.txt to djangorestframework==3.6.4
Seems that once the error occurs with 3.7.0 it does not run migrations.


[RFC] Introduce create_as_skip_indices

Category (leave one):

New Feature

Short description (up to few sentences):
Useful to create Distributed/Buffer table using CREATE TABLE ... AS ...
for MergeTree family tables.

The problem is clear.
The proposed solution with setting has downside: the user should know about this settings and should enable it.
Wouldn't it be better to add IStorage::supportSecondaryIndices method and ignore indices if storage is created AS and indices are not supported?

the user should know about this setting and should enable it.

Indeed, plus it is hard to keep all this settings in mind

Wouldn't it be better to add IStorage::supportSecondaryIndices method and ignore indices if storage is created AS and indices are not supported?

Agree, will update the patch

Wouldn't it be better to add IStorage::supportSecondaryIndices method and ignore indices if storage is created AS and indices are not supported?

Hm, we do not have Storage yet during parsing the query (and filling indexes), and during creating Storage we do not have AS flag (for now), so I'm thinking about just check against "MergeTree" in InterpreterCreateQuery::setProperties, or do you have strong feelings against this?

It's Ok. Added a comment.


fix($compile): throw an exception when an attribute is unassigned

Documentation states that NON_ASSIGNABLE_MODEL_EXPRESSION exception should be thrown if
a two-way attribute doesn't exist. This commit adds a simple test and throws an error
if the property is missing. Note that the documentation should probably be updated
and a different exception should be thrown using minErr.
This commit refers to issue #6060

Better PR here: https://github.com/angular/angular.js/pull/16129


[Feature] Forward & Back Buttons

Before Requesting

[X] I found no existing issue matching my feature request

Describe the feature!
The Space Theme seems to be missing the Forward and Back buttons. Is this intentional? Can they be added? Thanks!

I tried this - it doesn't seem to be working. I had to manually change the value of navigateButton.css

@An3kii so the option works, but currently Millennium has a bug where the options are not saved correctly (or the current status of the option is not recognized correctly) so you have to turn the option off, on, off, on, off (you can also just do off, on, off) (off stands for showing the buttons) and then close the settings window and then click on the button with restart and then you can see them


Completion in pubspec.yaml is not completing top-level properties

At least for me, the top-level completers in the pubspec don't work. eg.
name: foo
dep # Completion doesn't give me anything here, I would expect "dependencies"

I'm using VS-code.
I do get completion for individual package names, and for the version constraint:
environment:
  sdk: ^3.2.0

dependencies:
  analyzer: ^6.2.0
  ya # suggests yaml, yaml_edit etc...

One thing though, if I try to insert a new dependency at the top of the list, I don't get completion:
name: pub

environment:
  sdk: ^3.2.0

dependencies:
  ya # No completion here
  analyzer: ^6.2.0

Confirming that it is indeed the case where the YAML parser fails to recover from the errors, and so is unable to parse the incomplete yaml. Hence no suggestions.
@bwilkerson , is there anything we can do here?

We could try adding an issue on the yaml parser. I opened https://github.com/dart-lang/yaml/issues/102 and Danny made one fix, perhaps having another concrete use case would get more recovery work done.


Add support for -pushimage to azure registries

This PR aims to add functionality for pushing a given image to an Azure Docker Registry.
Related: https://github.com/trimble-oss/tierceron/issues/1088

This PR is obsolete, please refer to https://github.com/trimble-oss/tierceron/pull/1171


Improve health check hotfix

Reason for hotfix:
Realized that I was using a random port number previously to check if the health check will fail, but forgot to revert it back to the correct port number of the postgres database.
Changes made:
Reverting to the correct port number of the postgres database
Actions required:

Add secret POSTGRES_PORT with value 5432 to OrcaAL repository secrets
Add secret LIGHTSAIL_IP with value <IP_ADDRESS> to OrcaAL repository secrets (if not already done so)

Thanks! There was a curl error earlier on the main branch, so let's see if that resolves it.

@Benjamintdk The scheduled check is still failing on the main branch, while it is working on your branch. Fail is after updating libc-bin  and before/during running nmap check. Any idea why

?

Hi @valentina-s could I trouble you to try re-running the action again with the enable debugging option selected? It looks something like that when you re-run the action:

Somehow, I'm unable to re-run the action on my end, but selecting the option will allow us to see what code is running.
I suspect the action still fails because it is using the old code with port 777, so we'll need to wait for the next check to be certain, I had the same issue on my end as well, where I tried to re-run the failed job several times only to realize this:

You are right: it is looking for 777. So it is rerunning the old job? Would an option to trigger manually the action will use the latest version and help in these situations?

Yes, it should, because manually running a workflow automatically creates a new one which should update the code. Do you want me to add that option into the GH Action?


Support background jobs

Celery-ready tasks so we can queue jobs

superseded by https://github.com/mxabierto/shogun


Entry theme selection

Coverage increased (+0.0004%) to 99.059% when pulling 3bf1f01571ce6fe6708ab3cd3e947f403242eece on aviav:entry-theme-selection-3 into da119adb1e2873bb6a942c5df9e43582f325cf38 on codevise:master.

Coverage increased (+0.0004%) to 99.059% when pulling faf92366fb0dd66baa63ba105dfbe4f3d4924722 on aviav:entry-theme-selection-3 into da119adb1e2873bb6a942c5df9e43582f325cf38 on codevise:master.

Coverage increased (+0.0004%) to 99.059% when pulling 28098f34ac01e729f17baaf0a50c44c10c952220 on aviav:entry-theme-selection-3 into da119adb1e2873bb6a942c5df9e43582f325cf38 on codevise:master.

Coverage increased (+0.0004%) to 99.059% when pulling 28098f34ac01e729f17baaf0a50c44c10c952220 on aviav:entry-theme-selection-3 into da119adb1e2873bb6a942c5df9e43582f325cf38 on codevise:master.

Coverage increased (+0.0004%) to 99.059% when pulling 28098f34ac01e729f17baaf0a50c44c10c952220 on aviav:entry-theme-selection-3 into da119adb1e2873bb6a942c5df9e43582f325cf38 on codevise:master.

Coverage increased (+0.0004%) to 99.059% when pulling 28098f34ac01e729f17baaf0a50c44c10c952220 on aviav:entry-theme-selection-3 into da119adb1e2873bb6a942c5df9e43582f325cf38 on codevise:master.

Coverage increased (+0.0004%) to 99.059% when pulling 7badb0469f9257023cdd9ec29a17b64104f31e00 on aviav:entry-theme-selection-3 into da119adb1e2873bb6a942c5df9e43582f325cf38 on codevise:master.

Coverage increased (+0.0004%) to 99.059% when pulling 7badb0469f9257023cdd9ec29a17b64104f31e00 on aviav:entry-theme-selection-3 into da119adb1e2873bb6a942c5df9e43582f325cf38 on codevise:master.

Coverage increased (+0.0004%) to 99.059% when pulling 321692327c70dfd1f15a6148840afa0825206ad8 on aviav:entry-theme-selection-3 into da119adb1e2873bb6a942c5df9e43582f325cf38 on codevise:master.

Coverage increased (+0.0004%) to 99.059% when pulling 00bd2e463782f798d0445acae65e7b564f768749 on aviav:entry-theme-selection-3 into da119adb1e2873bb6a942c5df9e43582f325cf38 on codevise:master.

Coverage increased (+0.0004%) to 99.059% when pulling 00bd2e463782f798d0445acae65e7b564f768749 on aviav:entry-theme-selection-3 into da119adb1e2873bb6a942c5df9e43582f325cf38 on codevise:master.


[fix][chorg] some refinements

Coverage: 82.981% (-0.006%) from 82.987% when pulling 4ca773a3d5eaf847cf8112927e205f4925a00222 on pr-chorg into f65a9a206fd507b74c89970557dbd228126f8433 on master.


Circular board functionality and IndexOfCellWith refactor

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

39 of 39 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
197

Relevant Lines:
197

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

39 of 39 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
197

Relevant Lines:
197

💛  - Coveralls


feat: update framework packages to 2.2.x

Description
This PR updates the lightningtv solid and core dependencies to their latest versions
Changes

updates solid and core packages
replaces IntrinsicProps usages with Node/TextProps
updates the TextStyleSet to work correctly, removes a bunch of unnecessary types from types.ts
removes a handful of no-longer-necessary ts-expect-error statements 🥳
fixes broken fonts when navigating between stories(renderer update)
convert numbers to strings in FPSCounter

Testing
ensure storybook renderers components as expected
ensure storybook static site builds
ensure library builds
(last two are technically covered by smoke tests)

So weird I can't see this branch locally... Not sure if it's because it's a draft?

So weird I can't see this branch locally... Not sure if it's because it's a draft?

that's so strange, the branch should still appear either way 🤔

So weird I can't see this branch locally... Not sure if it's because it's a draft?

that's so strange, the branch should still appear either way 🤔

I was able to access it! Maybe need to re-fetch?


Design feedback on Give causes v2

Not complete, but this PR won't have a Fleek build I'd like one.


Sort the installed extension list

According to #12910. This PR will sort the installed extensions by its name in ascending order.

Hi @spywhere, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Thanks!


feat: export auth and GoogleAuth

Trying to reduce the # of diamond dependencies in our own modules.

Codecov Report

Merging #167 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   97.73%   97.74%   +<.01%
==========================================
  Files          15       15
  Lines        2873     2877       +4
  Branches      177      177
==========================================
+ Hits         2808     2812       +4
  Misses         39       39
  Partials       26       26

Impacted Files
Coverage Δ

test/index.ts
100% <100%> (ø)
:arrow_up:

src/index.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e8b40...1c2988f. Read the comment docs.

Great feedback.  To be entirely honest, I haven't dug that deep quite yet.  What I'm observing right now is that we import and use varying versions of google-auth-library across multiple libraries, and then pass objects back and forth.  I'm trying to create a choke point of sorts where one base library takes the dependency, and then it comes in with common.  Let's use nodejs-spanner as an example.

google-auto-auth is brought in directly to the module.
nodejs-common takes a dependency here.
google-gax brings it in as well

All of these modules are brought in as top level dependencies in nodejs-spanner, and auth objects and config are passed in and out of them.
As a result - right now I need to update google-gax, nodejs-common, and google-auth-library all at the same time.  This feels hyper risky, and I was hoping to detangle things just a bit :)
Now onto your original question 🤣 Google auto auth is used in nodejs-spanner like this:
https://github.com/googleapis/nodejs-spanner/blob/master/src/index.js#L195
Today the top level Spanner class is responsible for creating the GoogleAuth object, and then setting that on the base Service class object.  I'm not really sure today how I could make this work without at least exporting the GoogleAuth class :(

google-auto-auth is brought in directly to the [nodejs-spanner] module.

We should be able to get rid of that. Every common.Service instance provides an auth client instance, which we can use from Spanner.

nodejs-common takes a dependency [on GoogleAuthLibrary] here.
google-gax brings it in as well

I don't think flattening these will work, as they're kind of in competition with each other. An old plan was to transition entirely from CommonGrpc to GAX. But for now, both the common modules and GAX need to do their own auth, and neither depend on each other.

@JustinBeckwith  The code you pointed to in nodejs-spanner is actually a good example making my point.
Ideally this code should be lifted into the Service constructor instead of each Service subclass duplicating the work (and duplicating the dependency):
  this.options = extend(
    {
      libName: 'gccl',
      libVersion: require('../package.json').version,
      scopes: scopes,
    },
    options
  );

  this.auth = googleAuth(this.options);

This code is generic. It has nothing to do do with spanner specifically.
I still don't see a valid reason for child libraries to directly need access to the auth client. Superclass facilities in either common or gax should handle auth construction for everyone. Expose auth directly (as this PR proposes) – while eliminating the dependency from child libraries – does not do enough to get rid of the code duplication and the technical debt.

I still don't see a valid reason for child libraries to directly need access to the auth client.

In Storage, we need to use the "sign blob" endpoints for signed policies and URLs.
In any gapic client, we need to get a project ID before we send a request to gapic.

In any gapic client, we need to get a project ID before we send a request to gapic.

This should be done via something like await this.getProjectId();. This can already be done in subclasses of Service.

In Storage, we need to use the "sign blob" endpoints for signed policies and URLs.

It would be better to expose an auth instance rather than the ability to construct auth clients.

This should be done via something like await this.getProjectId();. This can already be done in subclasses of Service.

Yep, and that's fine. I'd say it's just as useful, if not better, to have the entirety of the auth instance, though.
Note that I was giving those examples as a response to your comment: "I still don't see a valid reason for child libraries to directly need access to the auth client." Judging from the comment I quote below, maybe you meant "auth module". And foreshadowing my response, I agree.

It would be better to expose an auth instance rather than the ability to construct auth clients.

Agree (told you I would agree), and we do. Spanner was just not doing it right, it seems. I haven't gone in to fix it yet, so there's a chance it's required for some reason, but as far as I can tell, that was just a mistake.

@stephenplusplus :+1:


⚠ ClamAV has degraded performance

In 2797a77, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 79 ms

Resolved: ClamAV performance has improved in bb38235.


Prettier peer dependency causes install errors

Describe the bug
Appreciate your work on this. Ran into a weird issue, tho: The framework I'm using requires Prettier 3 for its internal eslint formatter but for some reason your package requires Prettier 2 as a peer dependency and therefore requires me to install packages with --legacy-peer-deps enabled. If you're not providing a language server to provide live code formatting in this package, could you not require that as a peer dep?
Thanks
❯ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/prettier
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   peer prettier@">= 3.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@electron-toolkit/eslint-config-prettier
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!   3 more (eslint-plugin-prettier, prettier-plugin-svelte, prettier-plugin-tailwindcss)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/tinybase
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/prettier
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/tinybase
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/daniel/.npm/_logs/2023-08-31T21_11_14_966Z-eresolve-report.txt

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Create an Electron project using Svelte as your UI framework and add Tinybase.
Expected behavior
To not be forced to choose a linter version by my reactive store?
Screenshots or Videos
No response
Platform

OS: MacOS 13.5.1
Browser: n/a
Version: 4.1.1

Additional context
No response

We do actually use Prettier at "runtime" - or more precisely it is referenced in packaged code: the API generation tools prettify their output.
I can't roll to Prettier 3.0.0 because in turn I am waiting on https://github.com/mjeanroy/rollup-plugin-prettier/issues/1343
One good thing is that the tools will fail elegantly if Prettier is not present, BUT I think what might work here is that I keep my own devDependency version at ^2.8.8 and update the peerDependency to >2.8.8 (i.e. > rather than ^). Then you can have 3.0.3 locally no problem and yet TinyBase will still use 2.8.8 for itself.
New release 4.1.4 looks like it works!

I'm going to close this out, assuming it's good.

working now, thanks


GUACAMOLE-341: Make SSO Authentication work and pass through username…

… to RDP session
To make tokenfilter work with auth-header and noauth module. (needed e.g. for Kerberos authentication through an Apache/Nginx Reverse Proxy, that passes REMOTE_USER header), username must be set in the credentials object, because it is added to the Tokenfilter only if username is not null in the credentials object.
basically make $
{GUAC_USERNAME}
be replaced with the credentials passed though the REMOTE_USER variable.
See also:
https://github.com/glyptodon/guacamole-client/blob/b26a664d66fd14a22eb7300d29aa20390cf408ec/guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java#L118
https://github.com/glyptodon/guacamole-client/blob/0.9.12-incubating/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleAuthenticationProvider.java#L170

Good call!  I suspect this also needs to be done in the guacamole-auth-cas module, as well, as I probably failed to put it there, too :-).
Any reason not to place it inside the if (username != null) block?  It should be safe to set the username to null in the credentials object, but I don't know that there's much point, and since the check is already there for the authenticatedUser initialization, seems like a good place for it.

Hi @necouchman, yes no reason why not to put it in the if block. I have moved it there.

Looks good to me.

Please remember that each commit needs to tag the corresponding issue in JIRA, and that each commit message should describe at a high-level the change being made. The recently-added pair of commits are both missing the JIRA issue and have the same low-level message:

If two commits are so close to identical that they need the same message, they should probably be combined into one commit. Regardless of whether it makes sense to combine the commits, the message really needs to describe the nature of the change itself; something like "Update NameOfSomeFile.java" does not add any information beyond what git already records automatically. Commit messages should be aimed at describing the aspects which the various automated systems can't determine for you.

@dotmaster Any progress on this - opening a JIRA issue and tagging the commits correctly?

@dotmaster Ping...

@dotmaster: Any progress on fixing your commit messages?

@dotmaster: Can you please update the commits with the JIRA issue, and also see Mike's previous comment about potentially combining the last two commits?

@dotmaster: Please update...

@dotmaster Ping.

This PR seems to have died, but I think I may have a general solution to this problem, automatically pulling the GUAC_USERNAME token from the AuthenticatedUser.


Default settings contains warnings for Integrated terminal configuration options

VSCode Version:
OS Version:

Steps to Reproduce:

Open User settings
Open the problems view
Warnings are generated for integrated terminal configuration options

Expected: There should not be any warnings generated from the settings file

As a result on clicking these warnings an error is shown

First of all no warnings/errors are expected from default settings file.
Second, If there are, its correct that Problems view is showing them
Third, I am not sure if it is expected to show the above error on opening the above file, especially if these default settings files are generated and not-editable - @bpasero your input would be helpful here

@sandy081 I would not expect the problems view to show me problems for anything but markers for file:// and untitled:// resources.
Please debug this and see where the "then" failure happens (I do not get this warning and cannot reproduce).

@bpasero Problems view and Status bar is completely relying on the underlying markers model to show errors/warnings. This would cause inconsistencies in the views.
Showing them in the view helps because for eg, in this case these problems have to be fixed in the files we generated.
I think the right solution would be either to allow opening these files or show a nice message that user cannot open these files.

@sandy081 I am fine pushing this knowledge into the markers layer, but I am never interested in errors or warnings from files I cannot edit :)

@sandy081 seeing the warnings now and I think I was able to fix the NPE when clicking on the error.
The editor does not show the warning btw so I think we already do some filtering of warnings that are from non file editors:

Closing in favor of https://github.com/Microsoft/vscode/issues/7420


Do not ship with config.php

The shared host I tested on has a strong opcache, and since config.php is a php file, it caches it.
Maybe check if it exists, if not, create. And add "create a file named config.php" to the instructions.
Also, at this moment, @dissolve committed some test-values (by accident?), so when it knows how to handle a non-existing config.php, you can .gitignore it.
https://github.com/Inklings-io/selfauth/commit/b9e4008fc490c08f3739a29370e08e955d41322d#diff-9e5e2527d69c009a81b8ecd730f3957e

closing this issue, as we no longer include config.php in the repo


SwierJS now autoplaying in mobile view ReactJS

Check that this is really a bug

[X] I confirm

Reproduction link

Bug description
Swiper is working properly on desktop view, switching images automatically (autoplay).
As soon as I switch to mobile view it gets stuck in one the first image and doesn't switch no matter what.
import { Swiper, SwiperSlide } from 'swiper/react';
import 'swiper/css';
import 'swiper/css/pagination';
import { Autoplay, Pagination } from 'swiper/modules';
import { images } from './images';
<Swiper
direction={'vertical'}
pagination={{
clickable: true,
}}
autoplay={{
delay: 2500,
disableOnInteraction: false,
}}
modules={[Autoplay, Pagination]}
>
{images.map((image, index) => (

<img
src={image}
alt={Slide ${index + 1}}
className="h-96 w-auto object-cover md:h-full md:w-full"
/>

))}

Expected Behavior
Autoplay on mobile view.
Actual Behavior
Get's stuck in the first image.
Swiper version
11.1.1
Platform/Target and Browser Versions
Xubuntu 22.04.4 Google Chrome 124.0.6367.60
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[X] I'm willing to open a PR

Your issue is closed because it is not filled correctly. Before you open an issue please review the contributing guideline.
Please fill the issue template correctly and:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with isssue

It will save a lot of time for other contributors to check your issue and fix it.


Request for example pygmy cowsay integration

Background
This configuration example serves no practical application, however provides a POC example for showing the stdout of a container on-start to achieve a specific outcome. In this case we would be running an arbitrary image, passing arguments onto the container in typical docker run ... fashion.
Implementation
Docker
docker run -it --rm mbentley/cowsay holy ship!

Variables
n/a
Volumes
n/a

Services
  example-cowsay:
    name: example-cowsay
    discrete: true
    output: true
    weight: 99
    Config:
      Image: mbentley/cowsay
      Cmd:
        - holy
        - ship
    HostConfig:
      AutoRemove: true


non_webpack_require -> require in SystemJS

When running browser tests, e.g. via gulp unittest, the test files are not processed by babel, and neither by the "unittestcli" gulp target.
This commit copies the babelPluginReplaceNonWebPackRequire plugin from the unittestcli target to the SystemJS config so that __non_webpack_require__ is replaced with require for all build targets, and adds a unit test to ensure that this indeed works as expected.

/botio unittest

Looks good. Thank you for the patch!


Problem with page-editor.js and hallo.js

Hi man, how are you?
I try to adapt my site to your site and i try use your custom hallobuttons with my custom hallo plugin, but, i have a error about placeCaretAtEnd, so, i change page-editor.js and hallo.js but still i have this issue, can you halp me?
hallo.js:47 Uncaught TypeError: jQuery(...)[plugin] is not a function
I only register my custom plugin, not your other js files.

If you just register the Hallo plugins you need in core/wagtail_hooks.py then you can probably delete the file in core/static/wagtailadmin/js/page-editor.js as it's just an override from the original Wagtail one.

I've updated the according to the new Wagtail 1.0 https://github.com/torchbox/wagtail/releases/tag/v1.0 Plenty of stuff has changed in the editor and we've removed some JS. You shouldn't run into any issues, re-open and provide details in case you do.


i3c: add sedi i3c driver

This gives initial support to the design ware i3c controller used in intel ish.

Theres many many issues here with this PR... I'm not sure where to begin
If this really is the snps designware i3c as the description implies, then this is a duplicate of #64528

The zephyr driver has two modes. One is native driver mode, the other is the HAL mode, the two mode drivers could co-exist. The ISH drivers use HAL mode, for example, the previous upstreamed i2c driver uses sedi HAL to perform low level operation and config while there is another native i2c driver for the same designware  i2c IP. The ISH i3c driver follows the same way with other upstreamed ISH drivers such as i2c driver. So this PR could co-exist with PR #64528, they fulfill different job.

Theres many many issues here with this PR... I'm not sure where to begin
If this really is the snps designware i3c as the description implies, then this is a duplicate of #64528

The zephyr driver has two modes. One is native driver mode, the other is the HAL mode, the two mode drivers could co-exist. The ISH drivers use HAL mode, for example, the previous upstreamed i2c driver uses sedi HAL to perform low level operation and config while there is another native i2c driver for the same designware i2c IP. The ISH i3c driver follows the same way with other upstreamed ISH drivers such as i2c driver. So this PR could co-exist with PR #64528, they fulfill different job.

-1 on using HALs for generic IPs like Synopsys DW I3C. Vendor-specific code should only exist for any wrapper/vendor quirks.

Theres many many issues here with this PR... I'm not sure where to begin
If this really is the snps designware i3c as the description implies, then this is a duplicate of #64528

The zephyr driver has two modes. One is native driver mode, the other is the HAL mode, the two mode drivers could co-exist. The ISH drivers use HAL mode, for example, the previous upstreamed i2c driver uses sedi HAL to perform low level operation and config while there is another native i2c driver for the same designware i2c IP. The ISH i3c driver follows the same way with other upstreamed ISH drivers such as i2c driver. So this PR could co-exist with PR #64528, they fulfill different job.

-1 on using HALs for generic IPs like Synopsys DW I3C. Vendor-specific code should only exist for any wrapper/vendor quirks.

The HAL code used is not stay in zephyr repo, rather it resides in another opensource repo, the code submitted here for upstreaming only only contains API calls to HAL.

Theres many many issues here with this PR... I'm not sure where to begin
If this really is the snps designware i3c as the description implies, then this is a duplicate of #64528

The zephyr driver has two modes. One is native driver mode, the other is the HAL mode, the two mode drivers could co-exist. The ISH drivers use HAL mode, for example, the previous upstreamed i2c driver uses sedi HAL to perform low level operation and config while there is another native i2c driver for the same designware i2c IP. The ISH i3c driver follows the same way with other upstreamed ISH drivers such as i2c driver. So this PR could co-exist with PR #64528, they fulfill different job.

-1 on using HALs for generic IPs like Synopsys DW I3C. Vendor-specific code should only exist for any wrapper/vendor quirks.

The HAL code used is not stay in zephyr repo, rather it resides in another opensource repo, the code submitted here for upstreaming only only contains API calls to HAL.

This approach doesn't make sense for vendor-agnostic IP.


Wrapper crash on player disconnect

Joining works fine, but whenever a player leaves, the server crashes with the following message
[ERROR] FATAL UNHANDLED EXCEPTION: System.Collections.Generic.KeyNotFoundException: The given key '0' was not present in the dictionary.
at System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) [0x0001e] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0
at Chireiden.Stellaria.Stellaria.ServerLoop (System.Object state) [0x00187] in <3b2237ba6d1a47eb9bce8a92fc5553bd>:0
at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context (System.Object state) [0x00007] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0
at System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00071] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0
at System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00000] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem () [0x00021] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0
at System.Threading.ThreadPoolWorkQueue.Dispatch () [0x00074] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0
at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback () [0x00000] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0

crash.json
{
  "os": {
    "x64": "yes",
    "x64Process": "yes",
    "Platform": "Unix",
    "Version": "Unix <IP_ADDRESS>"
  },
  "hardware": {
    "CPUs": 64,
    "CPUID": null
  },
  "server": {
    "Players": 0,
    "MaxPlayers": 255,
    "WorldName": "wrapper",
    "WorldFile": "world.wld",
    "Time": 39281.0
  },
  "process": {
    "curRelease": 194,
    "TSAPIVersion": "<IP_ADDRESS>",
    "Uptime": "00:00:36.0343000",
    "WorkingDirectory": "",
    "Arguments": ""
  },
  "memory": [],
  "plugins": [
    {
      "Name": "TShock",
      "Author": "The TShock Team",
      "Version": "<IP_ADDRESS>"
    },
    {
      "Name": "Stellaria",
      "Author": "SGKoishi",
      "Version": "<IP_ADDRESS>"
    }
  ],
  "exception": {
    "message": "The given key '0' was not present in the dictionary.",
    "type": "KeyNotFoundException",
    "trace": "  at System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) [0x0001e] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0 \n  at Chireiden.Stellaria.Stellaria.ServerLoop (System.Object state) [0x00187] in <3b2237ba6d1a47eb9bce8a92fc5553bd>:0 \n  at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context (System.Object state) [0x00007] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0 \n  at System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00071] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0 \n  at System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00000] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0 \n  at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem () [0x00021] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0 \n  at System.Threading.ThreadPoolWorkQueue.Dispatch () [0x00074] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0 \n  at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback () [0x00000] in <de0ee687c1ad4ea99fca2db5d4839ca1>:0 ",
    "inner": null
  }
}

You may add a try-catch block for this line:
https://github.com/sgkoishi/Stellaria/blob/68209ede15a3a94fed0e10a611a56c0b512a2a9a/Stellaria.cs#L427
Or checkout Dimensions, The load-balancing and routing service for Terraria Servers

Not had a chance to really look into this, due to players losing their mini-map when changing world, This became unusable for our purpose.
Gonna close the issue, unless other people start having the same issues as before and want to investigate or i return to this project.

@HotaruBlaze reopen it
Unhandled Exception: System.Collections.Generic.KeyNotFoundException: The given
key was not present in the dictionary.
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at Chireiden.Stellaria.Stellaria.ServerLoop(Object state)
at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(Object sta
te)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionCo
ntext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, C
ontextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWor
kItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()


Remove async methods?

Hello all!
I have been experimenting with our async API methods over on gitbom-rs-cli.
Most recent experiment: https://github.com/nellshamrell/gitbom-rs-cli/pull/21
Previous experiment: https://github.com/nellshamrell/gitbom-rs-cli/pull/18
As noted in the comments on the previous experiment, I'm not seeing a performance gain when using the async methods (in fact, there appears to be a performance penalty, though it is of course possible I'm blocking on something unintentionally). GitBOM is heavily dependent on many file reads and file writes and, as the tokio documentation states:
"Although it seems like Tokio would be useful for projects that simply need to read a lot of files, Tokio provides no advantage here compared to an ordinary threadpool. This is because operating systems generally do not provide asynchronous file APIs."
It's possible we could make use of io_uring, there has been some experimental work done on this (including with tokio) but support for it is still not wide-spread. This would also only benefit us on Linux, not on Windows. It is possible there is some sort of library that would support async file operations on Windows, but then we would need to maintain two separate sets of functionality - one for Linux and one for Windows. This is not impossible, but it adds to complexity and increases the maintainership burden more than it needs to at this time (imo).
The work that was done to add the async methods was tremendously valuable - I know I learned a lot and I believe other maintainers did as well. However, I propose removing the async API calls at least for now, and leaving it the project which uses the library to decide how to implement performant use of it through threads, etc. We can always add this functionality back in should it become necessary.

@yoshuawuyts, as one of the reviewers on the PR which added this async functionality, I'm curious what you think too :)

I can say for my own part that removing async would certainly simplify the changes I’m interested in making, namely to make it optional to pass the length of the hashed material for a GitOid up-front. Expressing the equivalent Seek bound in an async context isn’t something I’ve figured out. That said, if there’s a way to do it for async I'm happy to learn.

@yoshuawuyts, as one of the reviewers on https://github.com/git-bom/gitbom-rs/pull/17, I'm curious what you think too :)

I recently authored a post on the benefits I see of using async Rust: the ability to apply ad-hoc concurrency, use ad-hoc cancellation, and being able to combine the two to apply things like timeouts on arbitrary operations.    To me these properties generally seem like the clearest benefits for adopting async Rust, as implementing their counterparts in non-async Rust will generally require going through the OS to achieve similar results.
Being able to do those things does come with a meaningful tradeoff which is: complexity. Async Rust is harder to author, has fewer stdlib facilities, and is harder to debug. I'm on the Async Rust WG where we're trying to improve these things - but our progress is measured in years, meaning improvements will take a while longer.
Looking at the codebase here, it seems that the workload here is mostly batch-oriented. Files are read from disk, and then processed using hashing algorithms. Most async OS facilities are not (yet) optimized for disk IO, which makes sense that the non-async version would often run faster than the non-async variant. But this is indeed likely to change in the near(ish) future as io_uring becomes more commonplace. Because we're in this in-between state, I usually only check whether performance of a project is "good enough", and then leave it there.
To get back to the main question though; I think the question to ask here should be: "Is having features such as ad-hoc concurrency and cancellation worth the added complexity of using async?" The answer to this will depend on your current maintainer's capacity and future plans for the project, which are not things I have insight into.
I hope this helps you evaluate whether async Rust is the right choice for this project!

Thank you so much for the input, @yoshuawuyts! I personally do not think having the ad-hoc concurrency and cancellation is worth the added complexity at this time. This may change with wider adoption of io_uring (and an equivalent on Windows), but I would personally prefer to remove the async methods at this time. Again, this is not meant to diminish the quality or importance of that work - we learned a ton and I really appreciate @dpp's work in particular - but I believe it would be better for forward development of this library to remove it for now.

Checked on this with @dpp and I'm proceeding forward with removing the async methods - pull request coming soon!


IsarError: Link has been moved! It is not allowed to move a link to a differenct collection. (attempting to update isar collection.

Steps to Reproduce
Attempting to uni test my update function where I am attempting to change my collection property hence the error is shown when attempting to update.
Code sample
if (data is Order) {
      final order = data;
      await isar.writeTxn((isar) async {
        return await isar.orders.put(order, saveLinks: true);
      });
    }

Version

Platform: unit testing
Flutter version: 3.0.1
Isar version:^3.0.0-dev.0
Isar Generator version: ^3.0.0-dev.0

Did you move the link object? That is not allowed

Do you have a sample reproducing the issue?

Going to close this for now. Please reopen if you have more information.


Hash change causes page refreshes in some special cases in IE

This is a bug that is caused by a bug in some IE versions. Since Backbone router supports most of the IE versions affected, i feel like this bug should be covered under the backbone library itself.
See https://groups.google.com/forum/#!topic/google-web-toolkit/sAWcorYhhWw
and http://stackoverflow.com/questions/2602260/javascript-location-hash-refreshing-in-ie/3804661#3804661
The fix for this turns out to be very simple however, I haven't had the time to test its effects across all browsers.
window.location.hash = window.location.hash;

I might consider addressing this if somebody confirms that the issue persisted all the way to IE11 and there is someone who actually cares about this.


generate root_dir docs from source code

Problem
https://github.com/neovim/nvim-lspconfig/issues/1742 reported that the generated docs for root_dir are sometimes invalid.
The response was https://github.com/neovim/nvim-lspconfig/commit/9dc02492c4a457479f8a0ec7a65aac1852ff59c0
which just removed the generation:
https://github.com/neovim/nvim-lspconfig/commit/733fe92baafb23cb413300571e31cb1fec962b1a
Besides being cumbersome, the manual documentation leads to problems like: https://github.com/neovim/nvim-lspconfig/pull/2006
Solution

Restore the generation the code removed in https://github.com/neovim/nvim-lspconfig/commit/9dc02492c4a457479f8a0ec7a65aac1852ff59c0 and...

make it link to the source instead of trying to parse it (e.g. [path/to/foo.lua](https://github.com/neovim/nvim-lspconfig/blob/…/foo.lua#L132-L149))
or just fix the parsing.

Use treesitter to parse the file?

this would also fix e.g. rnix's docs saying that root_dir defaults to "vim's starting directory" when in fact it's util.find_git_ancestor(fname) or vim.loop.os_homedir(), which is very much not the same thing


Debugging a cell leads to a loop of Invalid message: Session is already initialized pop-up notifications

Type: Bug
When connected to a server via SSH, debugging a cell in a Jupyter notebook leads to pop-up window that keeps appearing, even if closed. The only remedy is to kill VS Code with the Activity Monitor.
Invalid message:
Session is already initialized

Difficult to reproduce without the underlying (proprietary) data used by the python packages.

VS Code version: Code 1.72.2 (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:15:55.763Z)
OS version: Darwin arm64 22.1.0
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Apple M1 Max (10 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
6, 5, 4

Memory (System)
32.00GB (4.51GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (32)

Extension
Author (truncated)
Version

preview-pdf
ana
1.0.0

github-markdown-preview
bie
0.3.0

markdown-checkbox
bie
0.3.3

markdown-emoji
bie
0.3.0

markdown-footnotes
bie
0.0.7

markdown-mermaid
bie
1.15.2

markdown-preview-github-styles
bie
1.0.1

markdown-yaml-preamble
bie
0.1.0

gitignore
cod
0.9.0

gitlens
eam
13.0.3

gc-excelviewer
Gra
4.2.56

l13-diff
L13
1.0.3

restructuredtext-pack
lex
1.0.1

markwhen
Mar
0.2.0

python
ms-
2022.16.1

vscode-pylance
ms-
2022.10.30

jupyter
ms-
2022.9.1202862440

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.10

vscode-jupyter-cell-tags
ms-
0.1.6

vscode-jupyter-powertoys
ms-
0.0.6

vscode-jupyter-slideshow
ms-
0.1.5

remote-ssh
ms-
0.90.1

remote-ssh-edit
ms-
0.84.0

live-server
ms-
0.4.3

vscode-sanddance
msr
4.0.1

vscode-json-editor
nic
0.3.0

autodocstring
njp
0.6.1

vscode-inline-bookmarks
tin
0.1.0

intellicode-api-usage-examples
Vis
0.2.6

vscodeintellicode
Vis
1.2.29

markdown-all-in-one
yzh
3.4.3

(1 theme extensions excluded)

launch.json has not been changed from the default value:
{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python: Current File",
            "type": "python",
            "request": "launch",
            "program": "${file}",
            "console": "integratedTerminal",
            "justMyCode": true
        }
    ]
}x

Compare also this related question on StackOverflow.

Made some changes to cell debugging this month- could you try with the latest VS Code Insiders build + Jupyter pre-release extension, (or try again after the release next week)?

The latest insider build + Jupyter pre-release gives another error (with a series of pop-up notifications that keep reappearing until VS Code is killed with Activity Monitor):
Couldn't find a debug adapter descriptor
for debug type 'Python Kernel Debug Adapter'
(extension might have failed to activate)

Could you set "jupyter.logging.level": "verbose", try again, and share the log from the Jupyter output channel?

Since the entire app freezes upon this error, I would need to copy the debugging logs from a file rather than from the output console. I could not find the Jupytter logs among at location given by Developer: Open Logs Folder. Could you let me know where the Jupyter logs are stored (when connected to a server via SSH)?

There is a command, "Open extension logs folder"

I can't find a log file for the Jupyter output in the extension logs folder. After checking all other filed, I found none of the files contains the relevant log information.

Could you share the code that you're trying to debug? I notice the "child process" error message which maybe indicates that you're trying to debug code that spawns subprocesses which isn't supported in jupyter debugging currently (but shouldn't break this badly)
Also, please try debugging a cell like print('hello') if you haven't already.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


fetchEnsAvatar Implementation

Replaced existing fetchEnsAvatar implementation with a slightly modified and more lightweight version of https://github.com/ensdomains/ens-avatar .

native fetch instead of axios
stripped a bunch of dependencies needed for svg uri sanitization (basically just removed support for <svg>, URLs still work fine)

Thanks for kicking this off! Will look to add in following the 0.3.0 release.
In the meantime, could be good to write some test cases that cover these new branches.

@benisgold just merged next into main. can you update the base branch to main to reopen?


Quicksilver 1.5.2

I am unable to use 1.5.2 on a Mac mini running the latest OS, 10.12.3. The app will not run at all.

Does it crash (stop running) immediately, or start, but then freeze?
If it’s crashing, are there any reports in ~/Library/Logs/DiagnosticReports?

It freezes after running for a bit. No crash logs were available but I attached a resource dialog if that helps. By the way, the problem is also available in 1.5.1. I went back to that to see if it would work and it did not.
Nice app - keep up the good work.
Bob

On Mar 1, 2017, at 10:14 AM, Rob McBroom<EMAIL_ADDRESS>wrote:
Does it crash (stop running) immediately, or start, but then freeze?
If it’s crashing, are there any reports in ~/Library/Logs/DiagnosticReports?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/quicksilver/Quicksilver/issues/2324#issuecomment-283367691, or mute the thread https://github.com/notifications/unsubscribe-auth/AY58Q8MDbetSyuFVr7jjf3UjXACzEL90ks5rhYtrgaJpZM4MPoiv.

Robert J. Rossana     E-Mail<EMAIL_ADDRESS>Address: Dept. of Economics, 2074 F/AB
Wayne State Univ., Detroit MI 48202
Home Page: clasweb.clas.wayne.edu/rossana

Rob:
Unchecking the Safari History preset seems to be doing the job so far. It has been running fine for a while. Thanks.
Bob

On Mar 1, 2017, at 10:25 AM, Rob McBroom<EMAIL_ADDRESS>wrote:
My guess is that the most recent release of the Safari plug-in, which finally got history working again, added thousands of things to your catalog all of a sudden. There’s a general issue with slowness that we’re looking into and hope to fix in the next release.
It will eventually start working, but can get bogged down on launch. Clearing the caches should allow it to start faster. (Delete ~/Library/Caches/Quicksilver before launching QS.)
Until then, you might try going to Preferences → Catalog → PlugIns → Safari and unchecking the “Safari History” preset.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/quicksilver/Quicksilver/issues/2324#issuecomment-283371073, or mute the thread https://github.com/notifications/unsubscribe-auth/AY58QxLOAGZfu6KyQRJS0dJBpBKY06A2ks5rhY4CgaJpZM4MPoiv.

Robert J. Rossana     E-Mail<EMAIL_ADDRESS>Address: Dept. of Economics, 2074 F/AB
Wayne State Univ., Detroit MI 48202
Home Page: clasweb.clas.wayne.edu/rossana


could not load extension icon

Just received this error trying to install 0.2.1:

Hmm installing from require-navigator.crx works.

Fixing this...

Should appear in chrome store in a bit.


openbsd add lsearch/lfind fn.

Some changes occurred in OpenBSD module
cc @semarie

r? @Amanieu
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+

:pushpin: Commit 13eda020dc9420a8408f10e441d5f7d733aaaf00 has been approved by Amanieu

:hourglass: Testing commit 13eda020dc9420a8408f10e441d5f7d733aaaf00 with merge 2cf4c1453ff98431dfb4e186af33cc46deb2e716...

:broken_heart: Test failed - checks-actions

@bors retry

:hourglass: Testing commit 13eda020dc9420a8408f10e441d5f7d733aaaf00 with merge 7650116c3005a64120b3f08e072ac87d4a839de4...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 7650116c3005a64120b3f08e072ac87d4a839de4 to master...


Subfolder not working

Im having problems in putting my code with routing in a sub folder of wamp, www/urls
does any one have the same problem? I add $ROOT = $_SERVER['DOCUMENT_ROOT']."/urls"; and it loads the index but i try to access -> href="product/shoes/color/blue">Products</a and the url just increments the params like http://localhost/urls/product/shoes/color/product/shoes/color/blue and so on..

I have the same problem

I dont know if it is the best solution but making test in router.php i made this change
if( @$route_parts[1] == '' && count($request_url_parts) == 1 )
and in routes i added get($FOLDER.'/producto/$type/color/$color', 'producto.php');

The project must be placed and created under the root directory of the Apache server. In some computers this is the "htdocs" folder, or "www" folder.