WIP: Basin hopping improvements

Based on https://github.com/scipy/scipy/issues/7799

[ ] Improve documentation
[x] Keep local minima even if step is rejected?

This will never happen with the default Metropolis, but could happen with a custom accept_test
Not sure, save for another PR

[x] Don't keep local minima if minimization fails result is invalid

[ ] But the step location should still be kept in that case?

If it's just out of bounds it's ok to keep, but maybe a bad idea.
If it's numerically wrong then it shouldn't be kept.  Not sure if this is possible.

[ ] Should be possible to specify stepsize of same shape as starting guess (when variables have different units/scales)
[x] Support Monotonic Basin-Hopping (T=0)

Fixed in https://github.com/scipy/scipy/pull/7954 and https://github.com/scipy/scipy/pull/8050

[x] Support Multistart?  (or just explain how to configure it (reject all steps and make stepsize wide enough to cover area of interest))

Should just be a different function, with a more clear interface and parallelization: https://github.com/scipy/scipy/issues/6381

[x] First minimization should behave identically to subsequent ones? (reject InvalidResult, etc.)

This requires initializing with a dummy result with function value +infinity so that subsequent results replace it.

[ ] Write tests for new stuff
Add InvalidResult test to brute() (separate PR)

Ok so here's a nice graphic of how the algorithm works from doi:10.1155/2012/674832:

SciPy's behaves the same way, always accepting hops to lower energies (C2) and sometimes (randomly) accepting hops to higher energies (C3), in the hope that there will be another better minimum further along in that direction.  Otherwise it rejects the step (C4) and goes back to previous location (C3) to make the next step.
This is unrelated to the failed minimization issue:
It's conceivable that someone could change accept_test to sometimes reject lower minima, too, in which case the lower minimum won't be stored as a global minimum candidate.  But accept_test is about rejecting the step, not the result, so I think it should always store a minimum even if it doesn't step further in that direction.
So
        if accept:
            self.energy = minres.fun
            self.x = np.copy(minres.x)
            new_global_min = self.storage.update(minres)

should become
        if accept:
            self.x = np.copy(minres.x)
        self.energy = minres.fun
        new_global_min = self.storage.update(minres)

?

That graphic is quite nice for understanding. C3 should be colored differently I think, because it's not always accepted. But other than that I'd be +1 on adding an illustration like that to the docstring.

If one of the customized accept_test functions returns None, should that raise an Exception?  Currently it's treated as False, but it probably means "the accept test is broken" rather than "the accept test rejected the step".  (I did this by accident using the test to plot points.)

In Python bool(None) is False
On 3 September 2017 at 09:44, endolith<EMAIL_ADDRESS>wrote:

If one of the customized accept_test functions returns None, should that
raise an Exception? Currently it's treated as False, but it probably means
"the accept test is broken" rather than "the accept test rejected the
step". (I did this by accident using the test to plot points.)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/pull/7819#issuecomment-326775298, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAq51njOOtRXID_aCyzUalsszvIqVwqiks5seehUgaJpZM4PKyZC
.

--

Dr. Andrew Nelson

@andyfaff Yes, and that's why it's happening, but I think if accept_tests returns None, then something is wrong with accept_tests and it should be caught.

  Basically:

Don't update the global minimum if minimization failed
Do update global minimum even if step was rejected (in case of a custom random accept_test, for instance)

There are several variables with similar names and it's kind of confusing which is which, so I made a list:

self.x

starting point for next step (last minimum accepted)
then fed to accept_test and step-taking report as x_old
if step (last minimum vs current minimum) is acceptable, this gets updated to current minimum

self.energy

energy of starting point (last minimum accepted)
printed in step summary
fed to accept_test and step_taking report as f_old
updated to last minimum but only if step is accepted
~also used to print global minimum~ replaced with storage.minres.fun
also used to print current local minimized value (f)

x_after_step

position after taking a random step
used as starting point for local minimization

x_after_quench

position after taking a random step and then local minimization
fed to accept_test and step_taking report as x_new

energy_after_quench

function value after taking a random step and then local min
fed to accept test and report as f_new

storage.minres.x and storage.minres.fun

best global minimum candidate found
only updated if minimization succeeds

Please check if I'm getting this right.
Originally I thought that the initial minimization should be part of the main loop and identical to the others, but I guess that's not right.  If we think of the "step" as the random jump in starting point, the algorithm works like this:

starting guess -> local minimum (0 steps)
randomized step from local minimum to new starting guess
starting guess -> local minimum (1 steps)
randomized step from local minimum to new starting guess
starting guess -> local minimum (2 steps)

So niter is the number of steps, and the number of minimizations is always niter+1.
So I changed i so that if you say niter=0, it does 1 minimization and 0 steps and then returns result.nit=0. (Previously it said nit=1 for both niter=0 and niter=1.)  But is that right?  nit is described as "Number of iterations performed by the optimizer."  Iterations of the hopping, or iterations of the local minimization?
Anyway, it seems to work ok with constraints now:

(eggholder function, blue is starting guess, green are random jump locations, yellow are local minima, and red is global minima, red regions are out of bounds)

Originally I thought that the initial minimization should be part of the main loop and identical to the others

Originally I thought this could be easily adapted to Multistart by rejecting all steps and setting the stepsize wide enough to cover the desired area (like to uniformly sample -5 to +15, set starting guess at +5 and stepsize to 10: basinhopping(func, 5, stepsize=10, accept_test=lambda x: False)
But because it does a local minimization even before the first step, this won't work because it moves the starting point to that minimum first.

Also, it seems that having both bounds and constraints enabled leads to bizarre behavior that violates both?
Neither:

Bounds only (red):

Constraints only (blue):

Bounds (red) and constraints (blue):

So we need to:

keep the result of local minimization if "minimization failed" but the result is still within bounds and constraints and the result is a valid function value
reject the result of local minimization if "minimization failed" due to going out of bounds or constraints

Any ideas how to do this?

@endolith I don't know how consistent the status flag is in the OptimizeResult that results from minimize, but one method would be to use these flags if one of the contraints/bounds methods are being used, ala
if res.method in [' L-BFGS-B', 'TNC', ...] and res.status < 2

Yes I thought of using that, but not sure if it's reliable enough, and doesn't each solver have different sets of values? and those could change? especially if new solvers are implemented?
Maybe the real solution is to change success to non-binary:

True = valid local minimization
False = valid function value, but not the local minimum
None = invalid result

Or it could return something more explicit, like FailedMinimization of FailedMinimizationType, the way NotImplemented is returned by comparison methods.

mode
message
success
proposed

SLSQP

-1
Gradient evaluation required (g & a)
N/A
N/A

0
Optimization terminated successfully.
True
True

1
Function evaluation required (f & c)
N/A
N/A

2
More equality constraints than independent variables
False
???

3
More than 3*n iterations in LSQ subproblem
False
False

4
Inequality constraints incompatible
False
Invalid

5
Singular matrix E in LSQ subproblem
False
False

6
Singular matrix C in LSQ subproblem
False
False

7
Rank-deficient equality constraint subproblem HFTI
False
False

8
Positive directional derivative for linesearch
False
Invalid

9
Iteration limit exceeded
False
False

COBYLA

1
Optimization terminated successfully.
True
True

2
Maximum number of function evaluations has been exceeded.
False
False

3
Rounding errors are becoming damaging in COBYLA subroutine.
False
???

4
Did not converge to a solution satisfying the constraints.
False
Invalid

TNC

-1
Infeasible (lower bound > upper bound)
False
Invalid

0
Local minimum reached (
pg
~= 0)

1
Converged (
f_n-f_(n-1)
~= 0)

2
Converged (
x_n-x_(n-1)
~= 0)

3
Max. number of function evaluations reached
False
False

4
Linear search failed
False
???

5
All lower bounds are equal to the upper bounds
False
Invalid?

6
Unable to progress
False
???

7
User requested end of minimization
False
False

L-BFGS-B

0
converged
True
True

1
too many function evaluations or too many iterations
False
False

2
if stopped for another reason, given in d['task']
False
???

@endolith I personally like this approach of changing minimize. It's very nice that only algorithms that can return non-sensical values have to be changed. Nelder-Mead, for instance, can simply keep returning True and False...
None seems a bit arbitrary, perhaps I agree that FailedMinimization would be more clear. However, I think it's good if bool(FailedMinimization) == bool(False), since that would help with backwards compatibility...

@juliusbierk Do you have an opinion on the question marks in my table?

I think it's good if bool(FailedMinimization) == bool(False), since that would help with backwards compatibility...

Good point.

@endolith Sorry, I definitely don't know off-hand. I had a quick look at the TNC code. There are also -3 and -2: https://github.com/scipy/scipy/blob/master/scipy/optimize/tnc/tnc.h#L68, which are FailedMinimization.
4: TNC_LSFAIL looks like it's just not finding a minimum: https://github.com/scipy/scipy/blob/master/scipy/optimize/tnc/tnc.c#L1628, so this, I think, should be False.
6: NOPROGRESS looks like it's stuck somewhere: https://github.com/scipy/scipy/blob/master/scipy/optimize/tnc/tnc.c#L791 so this suggests False, but I'm not sure if all constraints/bounds are guaranteed to be satisfied.
I don't use these constrained minimizers much, so I'm really no expert. Hopefully someone else can pitch in.

@juliusbierk

I see other use-cases, however, where the former behaviour is preferred (for my use cases, that's typically the case).

Do you have any simple examples of your use case, where the local minimizer fails to converge but the result is still useful?

Ok I started over, implementing the InvalidResult flag.  Please comment on whether I should keep going with this.

It works now, bounds and constraints are both respected, fixing https://github.com/scipy/scipy/issues/7842:

@chernals I'm waiting for comments by others on whether this is a good idea.

The PR here really helped bring my optimization a lot closer to the result. However, I ended up checking only for minres.success == True instead of InvalidResult, but this could just mean that InvalidResult needs additional cases triggered.
Doing this lead my basinhopping optimization to much more reasonable results compared to what the current 1.4.x branch generates.

Following up on this, because I'm sick of my docker instances taking forever to build scipy instead of using a wheel 😂
Anyways, I guess I fail to see why we store the energy, x, and update the "global_min" on an optimization trial that did not result in minres.success?
This line in particular https://github.com/scipy/scipy/blob/maintenance/1.5.x/scipy/optimize/_basinhopping.py#L154
Thanks in advance.

So it's been 3 years since I was working on this, and I barely remember what I was doing.  It needs rebasing, since changes have been made since.
Has anyone read through it lately and can comment on whether this is a good approach or not?  Such as the InvalidResult object, etc.
Can anyone help fill in missing values in the table of return values?

basinhopping did not perform very well in a recent run of the global optimization benchmarks. It sounds like there is support for this PR, though - might it improve the performance?
If you're interested in finishing this up @endolith, I can review it. Please let me know.
If not, I'll go ahead and close, and it can be re-opened if someone is interested in reviving it.

basinhopping did not perform very well in a recent run of the global optimization benchmarks. It sounds like there is support for this PR, though - might it improve the performance?

"Performance" = "likelihood of finding the correct answer", right?  Or "computational speed"?
I don't know if it would improve it.  It's been 5 years since I made this, but if I remember correctly, it would only improve the likelihood of finding the solution when there are bounds or constraints.  If there aren't any, it should have no effect.  Do the benchmarks use those?

Performance = % of successes and number of objective function evaluations. All four other global optimizers tested did better in both categories. I remember adding some problems for global optimizers with constraints... But those may have been tests, not benchmarks. I think that few, if any, of the benchmarks have constraints.

Reading through all this, the original problem could be solved simply by adding something like
            elif not minres.success:
                accept = False
                break

to the for test in self.accept_tests.  Then steps would not be "accepted" if the went out of bounds.  It seems that the original authors wanted those kept, though, since they explicitly added a warning for them but didn't reject them?  (Which was the motivation for me creating the InvalidResult thing, to keep them as intermediate steps but not return them as solutions.)
But seeing how the global optimizers add different keys to their output, I think adding more keys to OptimizeResult might be a better solution than creating an InvalidResult class.  Currently OptimizeResult says whether the minimization failed or succeeded, and includes the specific numeric error codes for failure, but those mean nothing to basinhopping.  The number codes could be interpreted as another key for whether the result is out of bounds or not?
This algorithm is similar to Dual Annealing, which seems to reject out of bounds values after the local minimization step:
https://github.com/scipy/scipy/blob/v1.9.1/scipy/optimize/_dual_annealing.py#L425

The minres.success check was the exact approach I had used when we were utilizing a basinhopping minimization with constraints. Before that modification, the procedure would take drastically longer and would fail to find a solution that would satisfy the constraints.

@endolith looks like that link to the "original problem" in your post is broken.
It sounds like you want to go a different direction here, and merging main here is not necessary?

It sounds like you want to go a different direction here, and merging main here is not necessary?

Yeah, there was no consensus, so I broke off https://github.com/scipy/scipy/pull/7954 from this, for example, and other things can be broken off into smaller PRs, too.

Reject out of bounds with a heavy-handed elif not minres.success to quickly fix the actual issue.  Not sure if this is the right place to put this, but probably.  It can't be in the list of accept_tests since those are based only on Before and After values and don't see the OptimizeResult.success.
Enhance it by adding some kind of key to the OptimizeResult from local minimizers that means "this is a valid function value, but out of bounds, which you can use as a step if you want"
Add the key to each local minimizer (maybe one PR for each), after decoding what their return code numbers actually mean

OK @endolith but please note that #1 of https://github.com/scipy/scipy/issues/7799#issuecomment-1286053309 is distinct from #1 of this list https://github.com/scipy/scipy/pull/7819#issuecomment-1286121057. I would recommend #1 of https://github.com/scipy/scipy/issues/7799#issuecomment-1286053309; #1 here is somewhat contentious and I would not be interested in reviewing that, personally.

OK, based on https://github.com/scipy/scipy/pull/7819#issuecomment-1286121057 I'll close this.


Pie chart performance

Nodes keep appending, rather than update (for pies).

After hovering over pie chart and then back:

redundant with #97 ?

Well yes, now that #97 exists it appears to be redundant :) Although the particular issue mentioned above about appending new nodes rather than updating was fixed between Alison and I yesterday and will come through the next time I merge my branch. See https://github.com/lindsaycarr/water-use-15/tree/piechart-performance

Oh, rats, sorry, I looked for existing issues but somehow didn't spot this one.


docs: fix bug 8174

Resolved issue 8174 by adding CSS rules for lists in docs

We're gonna have to groom the changelog entry 👀

We're gonna have to groom the changelog entry 👀

@edgarrmondragon True. My bad 😅


A simple help wouldn't be bad at all friends 💥

Please, I can't find how to set a username and password for the ftp server, can someone tell me how I can do it, this is my current code:
static async Task Main(string[] args)
{
var services = new ServiceCollection();
services.Configure(opt => opt.RootPath = "TestFtpServer");
services.Configure(opt => opt.ServerAddress = "<IP_ADDRESS>");
services.AddFtpServer(builder => builder.UseDotNetFileSystem());
using (var serviceProvider = services.BuildServiceProvider())
{
var ftpServerHost = serviceProvider.GetRequiredService();
await ftpServerHost.StartAsync();
Console.WriteLine("Press ENTER/RETURN to close the test application.");
Console.ReadLine();
await ftpServerHost.StopAsync();
}
}

You need to provide your own IMembershipProvider service.
There is also a small article about the authentication methods supported out of the box: Authentication
You can also find a sample implementation in this comment: https://github.com/FubarDevelopment/FtpServer/issues/19#issuecomment-333029170


do.sh: Gracefully deal with grep pipefail when processing stats.

The 'head -3' command might close the pipe while grep is still
writing to it, causing a SIGPIPE, which in turn causes the script to
fail because we run 'do.sh' with 'pipefail' set.

CC: @igsilya


[DRAFT] Add docs on load_result macro

Description & motivation
We don't do a great job of documenting this, and it comes up enough in Slack / dbt Learn that I think we should have something better.
I think this needs a bit of refinement:

I want to change the docs to be "how to operate on the data object" and "how to operate on the table object". That way, we can also use the same docs for the results of run_query (since that just returns the table object, not the other two parts).
The examples feel clunky at the moment, trying to figure out a good way to render these. I kind of want "raw" / "compiled" side by side, yanno? Or like a python notebook interface.

ANYWAY, this will do for now
To-do before merge

Pre-release docs
Is this change related to an unreleased version of dbt?

[ ] Yes: please update the base branch to next
[ ] No: please ensure the base branch is current
[ ] Unsure: we'll let you know!

Checklist
If you added new pages (delete if not applicable):

[ ] The page has been added to website/sidebars.js
[ ] The new page has a unique filename

If you removed existing pages (delete if not applicable):

[ ] The page has been removed from website/sidebars.js
[ ] An entry has been added to _redirects

@jtcohen6 — I'm keen to get your initial feedback on these docs. I know they aren't quite right yet (see above), but figuring out how we can do this in a better way!

I would love to see this merged in -- it looks like a lot of effort went into this one!
@jtcohen6 is this still relevant/useful?
If yes, thoughts on making this into sub-pages? It's a loooong scroll even without this addition and might make things easier to parse.

Closing this PR so we can plan the page appropriately while addressing the challenges stated above. Capturing this in an issue to be addressed when possible. https://github.com/dbt-labs/docs.getdbt.com/issues/2001
All comments should be captured in the issue going forward. Thank you for your work on this, @clrcrl!


Performance Issue

how to use large data like I am using 7000 users for the suggestions it is lagging, also how we can fetch suggestions from API with pagination.

Please, try to play with new alpha v3 version of this library with redesigned flow for rendering suggestions. Maybe it will help you.
You can find examples of using new v3 release here: https://github.com/dabakovich/react-native-controlled-mentions/blob/3.0/example/mentions-functional-component.tsx
To test alpha pre-release please, install the library using next command:
yarn add react-native-controlled-mentions@alpha
// or
npm install --save react-native-controlled-mentions@alpha

for 7000+ data, please use RecyclerListView + v3


:seedling: refactor constants in operator

Summary
Related issue(s)
Fixes #

lgtm

/approve
/lgtm

/lgtm


Teams integration

What would you like to be added:
Support notifications in Microsoft Teams.
Why is this needed:
We don't use Slack :)

@Nick-Kobishev I'm sure we can easily integrate it into the notifiers?
BTW @oocx thanks for the feedback, if you'd like and have the time you are more than welcome creating a PR to support that, it's a great first feature!

I'm not using it yet, I just installed it for the first time 2 hours ago and am evaluating if it would be a useful tool for us. I'll leave it running in our cluster for now, and see if it is useful for us. It looks promising so far :).

@Nick-Kobishev I'm sure we can easily integrate it into the notifiers?
BTW @oocx thanks for the feedback, have yo started using StatusBay?
Also if you'd like and have the time you are more than welcome creating a PR to support that, it's a great first feature!

should be a simple addition and indeed a great first feature for anyone looking to start contributing


⚠ Bofrost.de has degraded performance

In 0148d53, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1165 ms

Resolved: Bofrost.de performance has improved in 1a62a8c.


Hide/show ports when unlocked/locked

On my nodes which have a variable number of inputs, I have an "empty" port ready to receive a new connection.
I'd like to hide these ports when they aren't used - i.e. when the diagram is locked.
I tried something like<div hidden="@(port.HideIfLocked && Node.Locked)"> around the PortRenderer in my node component, but it doesn't respond to Locked change states.
I appreciate that this may be a lack of understanding of Blazor rather than your library, but I can't see what the difference is between the Locked property and any other?

Hello, which version are you using?

I'm using v2.1.6

Amd how do you set the Locked property?

I lock/unlock the entire diagram:
    private void SetLocked(bool locked)
    {
        foreach (var node in diagram.Nodes)
        {
            node.Locked = locked;

            foreach (var port in node.Ports)
                port.Locked = locked;
        }

        foreach (var link in diagram.Nodes)
            link.Locked = locked;
    }

Please add a call to Node.Refresh() at the end in order to refresh the UI

Aha! Yes, that fixed it. Many thanks!


Change Grafana URL (the old one is deprecated)

I've created this PR by comparing the deprecated URL and the full URL.
I wasn't able to test it, will be glad if you can instruct me how.

nm, I was able to test it. Ready for review


Awaiting Void conforming to Equatable and/or Hashable.

Can then replace the use of _Void (will be added in v3.3.0 or v4.0.0).

https://github.com/apple/swift-evolution/blob/main/proposals/0283-tuples-are-equatable-comparable-hashable.md


ContextMenu.PlacementTarget is always null

Describe the bug
In my entire project, wherever I define a ContextMenu, its PlacementTarget property is always null. I encountered this issue, as was trying to bind to the DataContext of the control, for which the ContextMenu is defined (which should be referenced by PlacementTarget), for the Command property of a MenuItem. But I noticed that the PlacementTarget is null. Now, I thought this might have something to do that this target is defined as an ItemTemplate of an ItemsControl, but trying it on a simple Panel inside the main window shows the same result.
To Reproduce
I couldn't find any exceptions, where PlacementTarget was actually not null, so really any ContextMenu defined on any control.
<Control.ContextMenu>
        <ContextMenu>
                <MenuItem Header="Something"/>
        </ContextMenu>
</Panel.ContextMenu>

Expected behavior
The PlacementTarget of a ContextMenu should not be null. As we're talking about the ContextMenu and not a Flyout, it is not directly possible to control the opening of a ContextMenu, meaning I shouldn't be responsible for setting this property.
Avalonia version
11.0.11
OS
Linux
Additional context
No response

I couldn't find any exceptions, where PlacementTarget was actually not null

It's not null, when you set an actual value to it. Otherwise, it will fallback to the control that requests context menu.


Cross-Env for windows commands

Title: enhancement : Cross-Env for windows commands
Description:
Closes #1976
This PR will solve the issue of certain scripts not working on Windows. Cross-env allows for a single command line assigned to scripts to work seamlessly between operating systems. Previously, windows users would have to manually adjust an individual script due to windows setting environment variables differently.
Taking yarn test as an example:
Windows users would have to change the test script in their local machines from TZ=UTC jest --coverage --runInBand  to set TZ='UTC' & jest --coverage --runInBand.
With cross-env, we just need to set it to the following for all users, and Windows/Mac/Linux users should all have their environment variables set properly:
cross-env TZ=UTC jest --coverage --runInBand

cross-env should be a dev dependency, not dependency.


CHORE Add getOptionLabel,getOptionValue to SingleSelect

Small chore to add two pass-through props to SingleSelect: getOptionLabel and getOptionValue

@davidmferris assigning to you to merge and release as you need it.


Fix RDNA Assembly

fixed hand_coded_optimizations() call from when it got moved out of the linearizer
fixed LoadOps/Const that got refactored
fixed MemOps that got refactored
fixed imports from when assembly got moved to extra
new env "ROCM_LLVM_PATH" to enable "ROCM_LLVM_PATH" to be used. The default now is to use the systems  llvm and ld.lld

Tested with the following env set in the command RDNA=1 DEBUGCL=5 DEBUG=5 GPU=1 OPTLOCAL=1 PRINT_KERNEL=1

A note for building LLVM on Ubuntu 20.04
Basic Stuff
sudo apt update
sudo apt install python3-pip build-essential libssl-dev ninja-build
Tinygrad
git clone git@github.com:tinygrad/tinygrad.git
cd tinygrad
python3 -m pip install -e .
pip install cloudpickle
pip install pyopencl[oclgrind]
cd ../
CMake
wget https://github.com/Kitware/CMake/releases/download/v3.27.0/cmake-3.27.0-linux-x86_64.tar.gz
tar -zxvf cmake-3.27.0-linux-x86_64.tar.gz
cd ./cmake-3.27.0-linux-x86_64/bin
echo "export PATH=$(pwd):${PATH}" >> ~/.bashrc
cd ../../
LLVM
git clone --depth 1 git@github.com:llvm/llvm-project.git
cd llvm-project
cmake -S llvm -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="llvm;clang;lld" -DLLVM_TARGETS_TO_BUILD="AMDGPU;X86"
ninja -C build

Note: if you get c++: fatal error: Killed signal terminated program cc1plus increase avaible ram/swp memory

cd ./build/bin
echo "export PATH=$(pwd):${PATH}" >> ~/.bashrc
cd ../../../

What we really need is the RDNA assembly backend tested in CI.

Changes made in tinygrad/:
------------------------------------------------------------
files                             insertions       deletions
------------------------------------------------------------
tinygrad/runtime/ops_gpu.py                1               1
------------------------------------------------------------
lines added in the tinygrad folder: 0

Yeah I don't know if it's possible. I was looking into it and the only simulator for RDNA was Navisim which seems to be a research project but is available on gitlab. However it was archived 7 months ago, doesn't have much documentation, and I'm not sure how up to date it is since I think it's mostly for the original RDNA spec.
One thing I could do is test that the RDNA asm code is properly generated by LLVM which would catch stuff like this but wouldn't actually run the code on the GPU or be able to pass the other tests. I haven't looked at the CI super closely but I think this would have to have it's own section to generate a setup like I have in the building LLVM on Ubuntu 20.04 notes which would make the CI take longer.

Getting through LLVM is a great first step for CI. It'll catch a lot of the regressions, I'd merge it with that

Just following up. I've started writing the unit tests for making sure the asm code is properly generated by LLVM. I'm currently porting the tests from test_ops.py to generate the asm code for each op and have 8 passing test.
I should have all the tests done in the next day or two depending on how much free time I have.

Added tests for most the ops. Now just need to add them to CI.
However when I was looking into the CI I came accross self hosted runners. If you have an extra machine available we could use it run the RDNA code on the GPU which would be more ideal. Doing this would make these tests redundant though.

test_rdna_asm.py with all that binary is not the way. That's way too fragile.

Still no, test_rdna_asm is tons of specific lines!


Redirect bootcamp to Kubernetes.io

As discussed at https://github.com/kubernetes/website/issues/7506
The approach uses a HTML meta tag to redirect users. Given the site is based on GH-Pages, this was the quickest way as we couldn't configure routing rules.
I also add a notice to the README so users know where to go for content/changes/suggestions.

/cc @steveperry-53
/cc @zacharysarah

/assign
/approve
/lgtm

@steveperry-53 Thanks for the merge but it looks like this didn't rebuild/update the site :(
How are the gh-pages configured in the Github settings?

@BenHall, In Github settings, we have this:
Your site is published at https://kubernetes.github.io/kubernetes-bootcamp/.
And if I go to Your site is published at https://kubernetes.github.io/kubernetes-bootcamp/, I get redirected to https://kubernetes.io/docs/tutorials/kubernetes-basics/.
But there is this other URL that has bootcamp content. And it is not getting redirected.
https://kubernetesbootcamp.github.io/kubernetes-bootcamp/
I don't understand why we have bootcamp content at both of these URLs. Any ideas?

Well here's this other repository:
https://github.com/kubernetesbootcamp/kubernetes-bootcamp


Fix typo in image alt text

Description
Fixes the typo Screnshot in an image alt text on https://adaptivecards.io/blog/2019/Community-Call-October/, which should be Screenshot instead.
Microsoft Reviewers: Open in CodeFlow

once the JS build succeeds, please go to the test site to test out your website/designer changes.

👍

@golddove you may need to shepherd this in and merge it after diagnosing the Android-CI build issues here.

/azp run

/azp run

Good catch, and thanks for the fix @vintagesucks. We were having some issues with our CI earlier, but this should be merged shortly.


Consider limiting line lengths to around 80 characters

I'm running 1920x1080 and have to scroll to see the end of commands and comment in GitHub.  Especially for tutorial intended work that is undesirable.

Hi! Yes, could be useful...will keep it on mind and adjust the source accordingly when doing some content changes. Btw, are there any tools to do such re-formatting automatically?


Questions about sementickitti dataset visualization

Hi, thank you very much for the code. I found that the visualization code only provides visualization of three datasets, there is no visualization method for the sementickitti dataset, but I found the sentence "elif config.dataset_task in ['cloud_segmentation', 'slam_segmentation']" in the visualization code, in line 186 of the visualize code, it feels like there is a Slam Segmentation. :", in line 186 of the code, it feels like there is a Slam Segmentation method but it is not in the code. Do you have a visualization method for the sementickitti dataset?

I am not sure that I ever tried the visualization code on SemanticKitti.
Visualization is an advanced feature so I did not spend time making sure it works in every case. If you want to visualize kernel deformations on SemanticKitti, and you understood how the code work on S3DIS, then it should not be very complicated to adapt the code for SemanticKitti.


Subscribe without polling

This registers the file descriptor we write subscription events to only with the event loop if there is data to be written. Without this fix, the plasma store will invoke send_notifications whenever the socket is writable, which will lead to 100% cpu utilization.

see https://github.com/ray-project/ray-ng/pull/6


Gantt Chart Components

Feature Description
query will be like
select name as Task_id,
creation as created_date,
exp_start_date ,
completed_on,
parent_task
from task
where project  like '${inputs.name}'

Attached example of Gantt chart in x axis i want date/week/month and Y axis task

If anyone is interested in contributing this, some info:
ECharts is starting work on a gantt series:
https://github.com/apache/echarts/issues/19579
There's an existing ECharts example here which may be helpful, though would require quite a bit of work to customize + generalize:
https://echarts.apache.org/examples/en/editor.html?c=custom-gantt-flight
Our histogram uses a custom ECharts series, which may be helpful to understand how it functions:
https://github.com/evidence-dev/evidence/blob/next/packages/core-components/src/lib/unsorted/viz/histogram/Hist.svelte

You could perhaps use a Mermaid gantt diagram for this in a custom component  (somewhat at least, I guess you would have to iterate the data and writeout the element).
Here is a custom component where you can specify the diagram within the tag, but you could modify it to generate the gantt part from data instead.
components/Mermaid.svelte
<!-- Mermaid.svelte -->
<script context="module">
    import mermaid from "mermaid";
</script>

<script>
    import { onMount, createEventDispatcher } from "svelte";
    export let id;

    let config = {
        startOnLoad: true
    }

    const dispatch = createEventDispatcher();

    onMount(() => {
        if (!id) {
            throw new Error("The 'id' prop is required for the Mermaid component.");
        }

        mermaid.init(
            config,
            document.getElementById(`mermaid-container-${id}`)
        );

        // Dispatch an event to let the parent component know that the diagram is rendered
        dispatch("mermaidRendered");
    });
</script>

<div id={`mermaid-container-${id}`} class={`mermaid-container-${id} pb-4`} style="display: block; margin: auto; width: 50%;">
    <slot />
</div>


Feature update REq - Squid Logging Scheme

Access.logs are Essential for finding user / ip / mac based reports .
Why Feature update is Needed for default squid access log :
1> logs generated are in UNIX time stamp format, Which are difficult for humans (normal user) to understand while creating a report.
2>  IP based  - ip can b changed , user & macc address are not basically (until not spoofed).
Bellow is a image better then default log format... user detail on 1 side. & other details on the right

in order to achieve this i did a bit manipulation in :
/usr/local/opnsense/service/templates/OPNsense/Proxy/squid.conf
added line 329
modified line 330

these changes remain persistent even after reboot, but not after update/upgrade i believe, therefore i jst made a request
future Suggestion :
1> One more thing i would like to suggest but since i dont know the working of php & falcon i cannot do it now, the Access.logs of one day in only shown, after 12:00am a new access.log file is generated completely empty. the old access.log of previous day containing logs get converted to .gz format. and in order to view old logs other than today i have to unzip the .gz files & find logs in them. and then search manually.
2> If we can export logs in PDF , html, .csv it will b much better.

I've added an option to enable "Extended" file logging.
https://github.com/opnsense/core/commit/abad6f9952589d390348927a78ab06dee77b52df contains the "combined" squid logging format, extended with the mac address.

Thanks,
Currently i am creating a Reporting module(Plugin) for squid (proxy) which add up the following feature --
1> check logs according to date.
2> Export in PDF , CSV & TXT
I hope that u will live my work.

@gaurovsoni that sounds great. if you can create a PR in the plugins.git we can review and give input if you want :)


SimpleText[Float|Byte]VectorValues::scorer should return null when the vector values is empty

This commit ensures that SimpleText[Float|Byte]VectorValues::scorer returns null when the vector values is empty, as per the scorer javadoc.  Other KnnVectorsReader implementations have specialised empty implementations that do similar, e.g. OffHeapFloatVectorValues.EmptyOffHeapVectorValues. The VectorScorer interface in new in Lucene 9.11, see #13181
An existing test randomly hits this, but a new test has been added that exercises this code path consistently. It's also useful to verify other KnnVectorsReader implementations.
closes #13443

This commit ensures that SimpleText[Float|Byte]VectorValues::scorer returns null when the vector values is empty, as per the scorer javadoc. Other KnnVectorsReader implementations have specialised empty implementations that do similar, e.g. OffHeapFloatVectorValues.EmptyOffHeapVectorValues. The VectorScorer interface in new in Lucene 9.11, see https://github.com/apache/lucene/pull/13181
An existing test randomly hits this, but a new test has been added that exercises this code path consistently. It's also useful to verify other KnnVectorsReader implementations.


Typo fix on chocolatey.org/courses/

Hello there! I wanted to submit a typo fix, but I realized the course pages are not part of the actual docs. Is it possible to do so for that part of the webpage, or is it only developed internally?
FYI, the typo in question is in here https://chocolatey.org/courses/getting-started/requirements

┆Issue is synchronized with this GitLab issue by Unito

@funkyfisch thanks for bringing this to our attention.  You are correct, the source code for the core portion of the Chocolatey website is contained within a private repository, so you will not be able to submit a PR to address the problem.  All pages under docs.chocolatey.org can be submitted to.
I have moved your issue into the chocolatey/home repository, as this is the correct place for any closed source portions of Chocolatey.

@funkyfisch I have just pushed out a new version of the site that corrects this typo.  Thanks again for reporting this.  Let us know if you find anything else that isn't quite right.


Connection Agent to one specific twitter account

Hello, like I understand you can create more than one agent. But how can I connect it to a specific twitter account? Happens the magic in ZerePy? Or do I need for every twitter account an own dev account?
Thanks

You can connect to any twitter account. You just need an api key and api secret for the account you want to connect.


Example 6 is incorrect.

Example 6 is incorrect.
If the URL parameter is "http://linkless.header", it becomes a link. To make it a label, "http://linkless.header/" is correct.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88eb5100-4508-3d09-7e6e-41aa3ce25b26
Version Independent ID: 3e7b7949-0d2a-3569-ad41-72406a9e1ad8
Content: Add-PnPNavigationNode (PnP.Powershell)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPNavigationNode.md
Product: sharepoint-server-itpro
GitHub Login: @Techwriter40
Microsoft Alias: pamgreen

Hello @iyoshim
how are you?
Even though the PnP documentation articles are on this repository, I need to kindly redirect you to open PnP cmdlets issues/pull requests here, in that repository, where a member of the PnP community will be able to correct the article/review your PR with your feedback.
The documentation for PnP cmdlets is then synced from that repo into this one.
Thank you!

@get-itips Thank you very much for the contribution and sharing this explanation. @iyoshim Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Depup

@all-contributors
please add @Rossb0b  for Code, test, doc, review
please add @fraxken  for Code, test, doc, review
please @PierreDemailly for review

@all-contributors
please add @fraxken  for Code, test, doc, review.
please add @PierreDemailly  for review.


Release 1.0.13

Pull Request Test Coverage Report for Build 606445825

45 of 47 (95.74%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 86.099%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

openapi_client_generator/transformers/init.py
10
12
83.33%

Totals

Change from base Build 579368506:
0.1%

Covered Lines:
576

Relevant Lines:
669

💛  - Coveralls


[Reflection] Fix premature deallocation of string memory in readMangledName.

This function creates a demangled tree from a std::string, but the demangle tree can include pointers into the interior of the passed-in string, which become invalid on return. Copy the string into the demangler's own memory first, so that the lifetimes are correct.
rdar://101438017

@swift-ci please test

We'd need a vector of them since we might do this more than once on the same demangler. Certainly feasible, but I don't think it's sufficiently performance sensitive to be worth the added complication.


Support empty array

Is your feature request related to a problem or challenge?
Follow on to https://github.com/apache/arrow-datafusion/pull/6384
The basic idea is to create an empty array using the function array_make when it takes empty arguments. Also, all array functions must accept an empty array and work with it.
Describe the solution you'd like
Examples:
select make_array();
----
[]

select array_concat(trim_array(make_array(1, 2, 3), 3), make_array(4, 5), make_array())
----
[4, 5]

Describe alternatives you've considered
If in the course of conversations it turns out that the feature is useless.
Additional context
Simillar Issues:
https://github.com/apache/arrow-datafusion/issues/6119
https://github.com/apache/arrow-datafusion/issues/6075.

I think this is a good first issue for someone to help with

I'd like to work on this . Is anyone already preparing a PR?


Reverse sentence TextExtractor Feature.

Microsoft PowerToys version
0.76.2
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
TextExtractor
Steps to reproduce
Press

text extractor Keys
Select 6.2 section
✔ Expected Behavior
6.2 The software shall maintain an RA state upon detection of a condition that is capable of resulting in
a risk as identified in Section 3, Risk Analysis.
❌ Actual Behavior
in resulting of capable is that condition a of detection upon state RA an maintain shall software The 6.2
.nalysis. Risk ,3 Section in identified as risk a
Other Software
No response

Hello and thanks for your message. MY first thought is that either the OCR engine -or- the text area where it's pasted, is handling Right-to-Left text direction. Does it happen with all kinds of western LTR text, and does it happen when you paste the same text in several different text editors? /needinfo


fix: allowReplace param for datasource in modify-data-object task

What this PR does / why we need it:
fix: allowReplace param for datasource in modify-data-object task
when datasource does not exists and allowReplace param is set to true, the task fails, because it could not find the object. This commit adds check if the error returned is notFound and if yes, do not return the error
Release note:
fix: allowReplace param for datasource in modify-data-object task

/retest

/retest

/cherrypick release-v0.17


Document spintainer

Added a DO NOT MERGE tag as we should wait until spintainer is cut in a release to add this to the docs.


Update the new API to allow some suites to be sequential and others to be shuffle

Describe the bug
Chainable API  like describe.shuffle() is deprecated.
There is no property shuffle in TestOptions to do that on a single suite so you have to use the new config introduced by #5281.
But now if you want to run some suite sequentially and use describe('my suite', { sequential: true }), it is ignored and the suite run shuffled.
Relates to https://github.com/vitest-dev/vitest/issues/3922
Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-c97uiy?file=test%2Fsequential.test.ts
System Info
Stackblitz

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Nvm I went too fast. The chainable API is not deprecated, only the options are last arg


yarn dev throwing fatal error

Describe the bug
ERROR: "build:watch" exited with 1
4:59:25 pm - File change detected. Starting incremental compilation...
@react-page/plugins-background: 4:59:27 pm - Found 0 errors. Watching for file changes.
@react-page/react-admin: 4:59:30 pm - Found 0 errors. Watching for file changes.
@react-page/editor: 4:59:39 pm - Found 0 errors. Watching for file changes.
@react-page/plugins-slate: src/index.tsx(152,5): error TS2322: Type '{ Renderer: (props: PropsWithChildren<CellPluginComponentProps<SlateState> & { children?: ReactNode; }>) => Element; ... 23 more ...; migrations: Migration<...>[]; }' is not assignable to type 'SlateCellPlugin<TPlugins>'.
@react-page/plugins-slate:   Object literal may only specify known properties, and 'disableProviderInReadOnly' does not exist in type 'SlateCellPlugin<TPlugins>'.
@react-page/plugins-slate: error Command failed with exit code 2.
@react-page/plugins-slate: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@react-page/plugins-slate: error Command failed with exit code 2.
@react-page/plugins-slate: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@react-page/plugins-slate: ERROR: "build:lib:watch" exited with 2.
@react-page/plugins-slate: error Command failed with exit code 1.
@react-page/plugins-slate: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run build:watch exited 1 in '@react-page/plugins-slate'
lerna ERR! yarn run build:watch stdout:
$ npm-run-all --parallel build:lib:watch build:css:watch
$ npm-run-all build:css -- -w
$ yarn build:lib -- --watch
$ tsc -p ./tsconfig.json && tsc -p ./tsconfig-es.json --watch
$ postcss --config ../../../../config/postcss.config.js --dir lib/ src/index.css
src/index.tsx(152,5): error TS2322: Type '{ Renderer: (props: PropsWithChildren<CellPluginComponentProps<SlateState> & { children?: ReactNode; }>) => Element; ... 23 more ...; migrations: Migration<...>[]; }' is not assignable to type 'SlateCellPlugin<TPlugins>'.
  Object literal may only specify known properties, and 'disableProviderInReadOnly' does not exist in type 'SlateCellPlugin<TPlugins>'.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

lerna ERR! yarn run build:watch stderr:
warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.
error Command failed with exit code 2.
error Command failed with exit code 2.
ERROR: "build:lib:watch" exited with 2.
error Command failed with exit code 1.

lerna ERR! yarn run build:watch exited 1 in '@react-page/plugins-slate'
lerna WARN complete Waiting for 8 child processes to exit. CTRL-C to exit immediately.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "build:watch" exited with 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

To Reproduce
Steps to reproduce the behavior:

Updated to latest
Run yarn, yarn bootstrap and yarn dev

Additional context
My dev environment was working earlier on v2.14. I just updated to v3.2.1 and hit this.
Anything to do with #1028?

can you run yarn build first and then yarn dev?  i think there is something that is not cleaned up properly

Perfect, thank you. Working like a charm.


[React Package] - Configuring Package.json and build commands

Configuring Package.json and build commands for publishing the package to npm.
Addition of GitHub workflow for semantic versioning
Setting up semantic versioning according to the conventions used in EOS.

I have added semantic versioning but it won't work until NPM_TOKEN is added as a secret in this repo. Upon addition of NPM_TOKEN, The package will be ready to be published for further testing.
This change requires to run npm i

@en3sis can you configure the env variables please?

@kbhutani0001 @vinayaksh42 NPM_TOKEN is added under my profile, I'll have it move to the org later.
Is there any extra configuration needed?

Thats all i guess. @vinayaksh42 ?

@kbhutani0001 @vinayaksh42 NPM_TOKEN is added under my profile, I'll have it move to the org later.
Is there any extra configuration needed?

No, that's everything that will be required for publishing it to npm for testing. The github token gets picked up automatically so it won't be required.

can we merge this @kbhutani0001 ?

Yes @en3sis sure. I thought we had to configure the tokens first


Not compiling

The code with the example is not compiling.
It is complaining about restore_mode in the yaml file.
Without restore_mode I get an error:
src/mhi_ac_ctrl.h:98:36: error: 'class MhiActiveModeSwitch' has no member named 'get_initial_state_with_restore_mode'
bool initial_state = this->get_initial_state_with_restore_mode().value_or(true);

Which version of esphome are you using?
On 17 February 2023 15:47:52 CET, glsf91 @.***> wrote:

The code with the example is not compiling.
It is complaining about restore_mode in the yaml file.
Without restore_mode I get an error:
src/mhi_ac_ctrl.h:98:36: error: 'class MhiActiveModeSwitch' has no member named 'get_initial_state_with_restore_mode'
bool initial_state = this->get_initial_state_with_restore_mode().value_or(true);
--
Reply to this email directly or view it on GitHub:
https://github.com/hberntsen/mhi-ac-ctrl-esp32-c3/issues/1
You are receiving this because you are subscribed to this thread.
Message ID: @.***>

That was indeed the problem. I thought I updated esphome but because an older python version the version was much lower.
Now updated everything and compiling fine.
My apologies.


Restricted subnet for docker0 via "fixed-cidr" option does not work

Hi all, I can't get the docker daemon to work with the options "--bip=<IP_ADDRESS>/16 --fixed-cidr=<IP_ADDRESS>/24". Routing doesn't work in any of my containers. I can ping the docker0 bridge from inside the containers, but nothing beyond that. I tried that with Archlinux/Docker 1.4 and CentOS 7/Docker 1.3.2. I made sure that the docker0 device didn't exist before starting the docker service. The complete docker command was: /usr/bin/docker -d -H fd:// --bip=<IP_ADDRESS>/16 --fixed-cidr=<IP_ADDRESS>/24
Am I doing something wrong or is this a bug? Thx

looks like this was resolved, lmk if otherwise how to reproduce


[#18] Account spoofing fix

Pass irods username to pam stack so that pam can use it to set PAM_USER
Pass irods username to pam stack

After some discussion, we've decided that we can go ahead and get this in as it has been confirmed working. I will rebase the changes and confirm that the plugin builds before merging. Sorry for the delay, and thanks, @ll4strw, for your contributions.


python3Packages.trio-asyncio: ignore DeprecationWarning

Motivation for this change
Ignore DeprecationWarning.
Fix build (https://hydra.nixos.org/build/166269932)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 158571 run on x86_64-linux 1

4 packages built:

python310Packages.pytest-aio
python310Packages.trio-asyncio
python39Packages.pytest-aio
python39Packages.trio-asyncio

Why did you move postPatch? Let's keep the diff small.

postPatch move reverted.

Result of nixpkgs-review pr 158571 run on x86_64-linux 1

4 packages built:

python310Packages.pytest-aio
python310Packages.trio-asyncio
python39Packages.pytest-aio
python39Packages.trio-asyncio


ISPN-5298 HotRod millisecond precision for lifespan/maxidle

Preview, don't integrate yet.
https://issues.jboss.org/browse/ISPN-5298
New protocol version 2.2 with new flags in the request header indicating if lifespan/maxidle values should be interpreted as nanosecond durations.

Needs rebase

Please see https://github.com/infinispan/infinispan/pull/3452


Unpin mypy requirements

Typing of the stdlib is being updated all the time. Ensure this project
uses an up to date version of mypy for more accurate results.

Codecov Report

Merging #984 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #984   +/-   ##
========================================
  Coverage    89.69%   89.69%
========================================
  Files           10       10
  Lines         2631     2631
  Branches       453      453
========================================
  Hits          2360     2360
  Misses         184      184
  Partials        87       87


Missing denoiser files in DirectX implementation

If ENABLE_DENOISER is true in CMake generating the DirectX solution is not possible:
CMake Error at Libraries/Aurora/CMakeLists.txt:231 (add_library):
Cannot find source file:
Source/DirectX/Denoiser.cpp

This file is not in the repository.
Kind regards,
Patrik

That option is not supported yet... work in progress. 🛠

Thanks for the info. Let's wait.


Any way to set a hint?

@jaredsburrows I have a branch for this, but @BertrandBev I need write permissions to push my branch to the origin and create a PR

@mack-at-pieces have you tried to create a fork, push to your fork and then open up a PR? That should work just fine

@BertrandBev wasn't sure how that would play out since I already had a fork with updates on it's master branch, but seems to have worked out just fine 👍🏼 #80

Great, thanks @mack-at-pieces !

@BertrandBev When will this be released?

Not sure, do you need it soon?

No rush just nice to have. "Type your code here".
Jared Burrows
@.***
LinkedIn: https://www.linkedin.com/in/jaredsburrows
On Wed, Jul 12, 2023, 12:56 PM Bertrand @.***> wrote:

Not sure, do you need it soon?
—
Reply to this email directly, view it on GitHub
https://github.com/BertrandBev/code_field/issues/79#issuecomment-1632889975,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANIYSCQSRMWXYYTPQXMNDDXP3JLVANCNFSM6AAAAAAZ7Q2OKU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@jaredsburrows just add this to your pubspec.yaml as the code_field dependency until it's updated on pub.dev
code_field:
  git:
    url: https://github.com/BertrandBev/code_field
    ref: 59ae52ab3e6f8de0db4b00cfe637e89d6dd2decb

Thank you @mack-at-pieces.
I got it working with:
dependencies:
#  code_text_field: ^1.1.0 # https://pub.dev/packages/code_text_field
  code_text_field:
    git:
      url: https://github.com/BertrandBev/code_field
      ref: 59ae52ab3e6f8de0db4b00cfe637e89d6dd2decb

I'll revert it back hen it is officially released.

@mack-at-pieces @BertrandBev Thanks! Works great.


No module named 'utils'

how to run voc-fcn?
i got this error
'No module named 'utils''

anyone solved it?

Just put the code train.py in the directory pytorch-semantic-segmentation


Run json format test in parallel

What is the purpose of this change? What does it change?

To reduce test time both locally and on CI too.
Was the change discussed in an issue?
fixes - part of #1473

How to test changes?

make test-json-format-output

Wait till #1759 goes in first
/hold

/test integration

/refresh

Wait till #1759 goes in first
/hold

#1759 is merged, does this still need to be on hold?

Wait till #1759 goes in first
/hold

#1759 is merged, does this still need to be on hold?

/hold cancel


[BioDrop] Images refer to LinkFree instead of BioDrop

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?
production
Version of BioDrop (for example "v1.2.3")
v2.84.0
Description
On Biodrop Homepage, Features section, Few images still refer to LinkFree instead of BioDrop. Those need to be u
pdate
Screenshots

Do you want to work on this issue?
Yes
If you want to work on this issue...
No response

Thank you for raising. I can see you want to work on this issue, but you did not fill in the If you want to work on this issue section explaining your proposed solution - please do this in future.

Yes, I will add this section moving forward.

On this occasion I will assign this to you. Please upload the image to this issue and use the generated URL to update the code.

This is proper image for replacement?

Here is another image on Homepage referring to LinkFree, should replace this as well?

Here is another image on Homepage referring to LinkFree, should replace this as well?

I can add this image for replacement.

you can raise a new issue and mention you want to work on this. maintainers will assign you if needed


Expand retry() API and improve exec() retry-logging

[x] This is a small change
[ ] This change has been discussed in issue #<?> and the solution has been agreed upon with maintainers.

Description:
Associated with the ongoing work on Genymotion-Cloud integration (#2429), where logging of command failures, and better-retry control, are required.

will reopen soon


💡 [Feature]: Add/Remove app catalog

🎯 Aim of the feature
The idea is to allow to:

add a tenant app catalog if it is not already present on tenant - in this case we should show a button in the full view if there is no tenant app catalog and when clicked prompt for confirmation and site name and create it. I would rather not add an option to remove tenant app catalog
add a site level app catalog - as a '+' icons next to the 'Site App Catalogs' node that when clicked would prompt for the site Url to which the app catalog should be created
add a remove site level app catalog button next to every site level app catalog. When clicked should prompt for confirmation.

Under the hood w should use:

m365 spo site appcatalog add
m365 spo site appcatalog remove
m365 spo tenant appcatalog add

📷 Images (if possible) with expected result
The idea is to add a '+' icon in the site app catalogs list that will show a prompt to specify the site to which the app catalog should be added and a trash icon next to every app catalog that will prompt for confirmation to remove an app catalog

🤔 Additional remarks or comments
No response

I’ll take this @Adam-it

All yours. Let me know if you will need any help to go about it 👍


Talk about closing issues as completed

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/issues/tracking-your-work-with-issues
What part(s) of the article would you like to see updated?
A page to talk about closing issues in general (and probably about reopening them)
Additional information
I've looked through the docs and can't find anything that talks about closed state: https://cs.github.com/?q=reason+closed+repo%3Agithub%2Fdocs
https://github.com/search/advanced#search_state_reason

It'd be nice to have some sense of what not planned is and how to move something into this state, or similarly completed.
It turns out that this is available via a drop down in issues:

But, I should be able to read documentation about this.
Searching the docs differently:
https://docs.github.com/en?query="close+as+not+planned"

I can see a way to use a bot to close issues:
https://docs.github.com/en/actions/managing-issues-and-pull-requests/closing-inactive-issues
But, that's pretty advanced and skips the basics.
Note that there is a page for closing pull requests: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/closing-a-pull-request

@jsoref Thanks for opening an issue! I'll triage this for the team to take a look 💖

@jsoref - clearly great minds think alike. I've just reviewed a content design plan for a writer at GitHub who is working on adding a new article on closing issues to the docs ✨
I'll add a comment to our internal notes so that they can take a look at the context you've added here 😄


Reproducibility of the paper results with pretrained model

Hi there!
I've read your paper and was amazed by your outcomes and your idea for the model architecture. I tried running the pretrained model on several EMPIAR classes:

EMPIAR-10671 (from the train data you provided)
EMPIAR-10345 (from the test data you provided)
EMPIAR-10146 (from EMPIAR website, this class has 20 micrographs in .mrc format)

However, visually, the results' precision didn't correspond to the paper's results. I double-checked that I used pretrained weights, but maybe I missed something else. I ran the prediction on Colab environment, and you can see/copy&run it by following this link.
Below, I will attach input, code and output for some cases.
EMPIAR-10671
This one belong to train data, so it should be downloaded, as well as model checkpoints for U-Net and SAM.
!python CryoSegNet/predict_new_data_jpg.py \
                                --my_dataset_path '/content/train_dataset/10671/train/images' \
                                --cryosegnet_checkpoint '/content/pretrained_models/cryosegnet.pth' \
                                --sam_checkpoint '/content/pretrained_models/sam_vit_h_4b8939.pth' \
                                --output_path '/content/CryoSegNet/output'

A couple of the outputs that indicate a lot of overlapping between the circles and false positives:

PS0114 RAMP1-CGRP_110-5_0001_Jan16_12 35 00
PS0114 RAMP1-CGRP_110-5_0003_Jan16_12 35 15

EMPIAR-10345
This one belong to test data, so it should be downloaded.
I was especially interested in this one, as the paper claims to achieve 1.58 A for resolution. However, the results still contains a lot of non-particles picked up, I am attaching two examples below:
!python CryoSegNet/predict_new_data_jpg.py \
                                --my_dataset_path '/content/test_dataset/10345/images' \
                                --output_path '/content/CryoSegNet/output' \
                                --cryosegnet_checkpoint '/content/pretrained_models/cryosegnet.pth' \
                                --sam_checkpoint '/content/pretrained_models/sam_vit_h_4b8939.pth' \

18jam15a_0155_ali_DW
18jam15a_0236_ali_DW

EMPIAR-10146
I have a few motion-corrected apoferritin images in .mrc format, and one of them can be downloaded via this link from Google Drive. You can see it in the first column.
I tried to use pretrained CryoSegNet to detect the proteins, but didn't succeed, even though the picture contains very little noise.
!python CryoSegNet/predict_new_data_mrc.py \
                    --my_dataset_path '/content/mydata/' \
                    --output_path '/content/CryoSegNet/output' \
                    --cryosegnet_checkpoint '/content/pretrained_models/cryosegnet.pth' \
                    --sam_checkpoint '/content/pretrained_models/sam_vit_h_4b8939.pth' \

The picture seemed to undergo some sort of denoising, almost blurring, and was flipped.
Question: Could it be that the mask was predicted for the non-flipped image? I tried to put the final mask on top of the original image, and it still isn't precise.

original
predicted

Final part

With these screenshots and my Colab notebook, could you please let me know if you noticed a mistake in my steps that led to the incorrect results? Otherwise, what else could be a possible reason for such imprecise results that I obtained?
Why is the resulting image with the predicted mask is flipped?

I appreciate that you took time to read it and hoping for a reply/chat!

Hi,

Regarding 10671, yes we can see some overlapping between false positives and the predicted circles. We can eliminate these using 2D classification job and Select 2D job in the CryoSPARC. The star file predicted by CryoSegNet can be imported in CryoSPARC for further post processing.
Regarding 10345, we may feel like some of the non-particles being picked up because we have used denoised version of the micrographs  which may have enhanced the contrast of some background noise. The deEven if the non-particles are picked up, we can use the CryoSPARC to eliminate such particles as mentioned in 1.
Regarding 10146, I will try with the images you have provided and let you know once it is fixed.

Thank you so much for your interest in this model. We are working to address all the issues that have been raised to make this tool more robust. Researchers and users like you will always help to drive the research in positive direction, We appreciate a lot for your time in trying our model.

Thanks for a quick reply!
As for the 1st point, the Table 2 from the paper provides the same resolution of 3D density maps for EMPIAR-10028 protein with and without Select2D. It led me to an assumption that the model would perform very well on this protein even without Select2D due to low false positives count, so I ran the model on some images from EMPIAR-10028, but the resulting images still contain a lot of false positives and very little true positives. I am attaching a few below.

What could be the reason for such poor results in my case?

Hi,
Thank you for helping us to make our code more robust.
These results  were because we applied denoising on images which were already denoised. Could you please try again with just python predict.py (make sure to pull the recent code).
For Example: python predict.py --empiar_id 10028
The results should look like this:

Thanks! Indeed, that's right :) I also ran it for EMPIAR-10345 the same way and got much better results than before.
As you might remember, I opened one more issue about lack of denoising in predict.py script, and that issue is closed by now. The resolution of that issue led to adding denoising step in predict.py, and then this issue led to removing this step again. Also, it remains confusing that predict.py and scripts for predicting for new data have different pipelines. I'd suggest to maybe add it in the README, so that no one gets confused :)
I wanna take a chance to ask you about denoising as well. In the paper, you describe a complex denoising process that involves Gaussian filter, then FastNLMeans, then Weiner, and then CLAHE technique. However, in the scripts I've noticed that you mostly use denoise_jpg_image in prediction for new data. Why so? Does this function incorporate all the approaches listed in the paper? It's important for me to know this step to also get very good results :)


[RFC] Integration Tests

The problem
Recently we started recommending to use HTTPS for the installer. Sadly, the server infrastructure is not completely ready and this doesn't work. To make things worse, I didn't test the HTTPS feature properly before recommending it.
The solution
The Symfony Installer is an essential tool for Symfony project and it must always work as expected. That's why, besides unit tests, we need integration tests to run them for each commit/pull request submitted to this repository.
Specifically, we need to do the following for any new code added to this project:

Build the PHAR file with Box project.
Install Symfony using HTTP and any of the available options (branch, specific version, lts special version, etc.)
Install Symfony using HTTPS and any of the available options (branch, specific version, lts special version, etc.)
Verify all the previous installations executing at least php app/console --version command in the installed Symfony application.

How can we implement these integration tests?

What would help in this situation is a smoke test. This could even be a simple bash script that builds the phar and verifies it can be executed with few variations.
We should make it clear that only communication with the outside world should be tested here. This kind of tests are slow and we should have as little of them as possible.

I think that you can use symfony/proccess + phpunit to do this.
<?php
use Symfony\Component\Process\Process;

class InstallerTest extends \PHPUnit_Framework_TestCase
{
    public function setUp()
    {
        // set permissions
    }

    public function tearDown()
    {
        // remove files
    }

    public function testBuildPhar()
    {
        $process = new Process('build-phar-file-here');
        $process->run();
        $this->assertTrue($process->isSuccessful());

        // verify checksum ?
    }

    /**
     * @dataProvider branchesDataProvider
     *
     * @param string $branch
     */
    public function testNewProjectWithBranch($branch)
    {
        $process = new Process(sprintf('symfony new my_project %s', $branch));
        $process->run();
        $this->assertTrue($process->isSuccessful());

        // other verifications
    }
}

Need to ensure it doesn't create too many connections to the symfony.com website I guess

Can we not get a master.zip of the installer from github website instead?
In a simple bash script: unzip it, install deps, build phar, and check difference commands for expected outputs (and version/branch/self-update)

@94noni I don't understand your comment

Implemented in #183. Thank you all for the discussion.


Extension issue

Issue Type: Bug
Extension Name: python
Extension Version: 0.2.3
OS Version: Windows_NT x64 10.0.19042
VS Code version: 1.57.1

:warning: We have written the needed data into your clipboard. Please paste! :warning:

@yejoonCho please close this yourself - this issue is not useful at all as it has no content about an actual issue, just the version numbers


Improve Core Tools install experience in Linux

This is primarily feedback from running in a Codespace but might apply to Linux in general.
Currently customers are sent to the GitHub readme which has a list of commands:

Some ideas for improvement:

In the prompt, can we tell the customer what distro and version they're running?
Can we detect the distro and version, and send them to a dedicated page/location with very specific instructions? (Functions team can maintain this)
If npm is available, as is the case of the Codespaces kitchen sink container, can we provide a new default option, which is to install via npm? If the install fails, then send them to the docs (or tell them to try rerunning the command using sudo).

Just ran into this while doing some testing, and yeah I agree the experience for installing func core tools on Linux is not great and the suggestions Anthony has made would be great.

In the prompt, can we tell the customer what distro and version they're running?

If npm is available, as is the case of the Codespaces kitchen sink container, can we provide a new default option, which is to install via npm? If the install fails, then send them to the docs (or tell them to try rerunning the command using sudo).

Seems like cheap, reasonable enhancements.


[ci] Add support for sdktype "utility" from the JS repo

In JS we use sdk-type: "utility" in our package manifests for things in the @azure-tools namespace, but this isn't one of the supported values in ADO work items for releases.
This can cause problems in CI like shown here:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3751191&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=00913ed3-6224-599f-5780-70386e2dd22d

This PR works around the problem by substituting the invalid string "utility" for the permitted work item value of "tool"

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

@xirzec we could also add utility as a valid value in the Package work item if that is a type we want to support.

I would prefer to add the type utility as an option in work item instead of overriding it in one place to keep it consistent in repo and work item. I can add the type in work item template if you are okay with that approach.  Otherwise, we should update it as tool in repo.

I would prefer to add the type utility as an option in work item instead of overriding it in one place to keep it consistent in repo and work item. I can add the type in work item template if you are okay with that approach. Otherwise, we should update it as tool in repo.

Yeah, I'm fine with updating the template, I just didn't know how difficult it would be to do that. I'll go ahead and close this PR.


Regarding Border - start and end, not working!

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue

the docs of bootstrap v5 needs to get updated regarding border as the classed mentioned for border-start and border-end doesn't get applied, instead border-left and border-right works
Reduced test cases

fix is:

What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
v5

Thanks for reporting an issue @RohanPawar1TR
However, border are well applied, even in your screenshot. They are light gray, but they are displayed.
Zoomed screenshot from https://getbootstrap.com/docs/5.3/utilities/borders/:

.border-left and .border-right don't exist anymore in Bootstrap v5 (they were there in v4); see https://getbootstrap.com/docs/5.3/migration/#utilities-3


Add subscriptSizing support for Material FormField

Is your feature request related to a problem? Please describe.
Material v15 has a subscriptSizing input on FormField which can be 'fixed' or 'dynamic'.  As Formly provides a default form-field wrapper, it would be good to be able to set this input to dynamic for my project.
Describe the solution you'd like
Add a property to the form-field wrapper.

+1
As a workaround, if you always want fixed or dynamic, you can use the MAT_FORM_FIELD_DEFAULT_OPTIONS injection token to set the default value of subscriptSizing

This issue has been fixed and released as part of v6.1.1 release.
Please let us know, in case you are still encountering a similar issue/problem.
Thank you!


feat: disable prepare nested transaction

[x] Do only one thing
[x] Non breaking API changes
[x] Tested

What did this pull request do?
close #6006
We still need to set it to true in the mysql driver.
config.DisablePrepareNestedTransaction = true

https://github.com/go-gorm/mysql/blob/master/mysql.go#L94

User Case Description

Save point doesn't make sense for prepare statement, maybe we can just disable it...

Save point doesn't make sense for prepare statement, maybe we can just disable it...

In other databases we can still use savepoint in prepare, it may be a breaking change if it is just disabled it.

Save point doesn't make sense for prepare statement, maybe we can just disable it...

In other databases we can still use savepoint in prepare, it may be a breaking change if it is just disabled it.

yes, but caching savepoint statements don't really make sense, it would even cause leaks...

Save point doesn't make sense for prepare statement, maybe we can just disable it...

In other databases we can still use savepoint in prepare, it may be a breaking change if it is just disabled it.

yes, but caching savepoint statements don't really make sense, it would even cause leaks...

You are right, but the user may set PreparedStmt in gorm.Open, they don't know that savepoint is not allowed (actually the database supports it), they may even use tx.SavePoint directly.
maybe better to raise an error?


Clang 19 Breakage

Inclusion of reflect.h generally fails on clang 19.1.0 https://godbolt.org/z/PcEoK4j5M

At the same time running into the same issue as https://github.com/actions/runner-images/issues/10018 on my local

The latter issue is an environment issue not a code issue (the code still works on older clang versions, just not with newer MSVC STL releases), I chose to update my LLVM version locally (which for me meant taking a newer download from https://github.com/llvm/llvm-project/releases/ ), but there are other approaches that may be more appropriate in other peoples cases. Now back to working on the OP.

Seems to accept the very simple fix: https://godbolt.org/z/vvohhdfWb
https://github.com/TheNitesWhoSay/RareCpp/commit/86b141af3ed6b8dcc34dbf44271dc8dff2ce9c1c
Couldn't find any breakages with newer compiler version nor newer C++ standards so going ahead with a release.


Equality operators for an enum type are not supported well

I tried the below code where an equality operator is used for an enum type.
use vstd::prelude::*;

verus! {

#[derive(PartialEq)]
pub enum Fruits {
    APPLE,
    BANANA,
}

pub struct Meal {
    pub fruit: Fruits,
}

impl Meal {
    fn does_not_work(&self) {
        if self.fruit == Fruits::BANANA {
        }
    }
}

fn main() {
}

}

It failed with the following error.
error: The verifier does not yet support the following Rust feature: ==/!= for non smt equality types
  --> rust_verify/example/guide/enum.rs:17:12
   |
17 |         if self.fruit == Fruits::BANANA {
   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 1 previous error

I've confirmed that using match or if let (the same semantic) works well.
use vstd::prelude::*;

verus! {

pub enum Fruits {
    APPLE,
    BANANA,
}

pub struct Meal {
    pub fruit: Fruits,
}

impl Meal {
    fn work(&self) {
        match self.fruit {
            Fruits::BANANA => {},
            _ => {},
        }
    }

    fn work2(&self) {
        if let Fruits::BANANA = self.fruit {
        }
    }
}

fn main() {
}

}

There is a feature called Structural that can be used to make this work:
#[derive(Structural, PartialEq, Clone, Copy)]
pub enum Fruits {
    APPLE,
    BANANA,
}

pub struct Meal {
    pub fruit: Fruits,
}

impl Meal {
    fn test(&self) {
        if self.fruit == Fruits::BANANA {
        }
    }
}

I guess we need to add documentation on this, and perhaps also update the error message to hint at using Structural.

Thank you for the suggestion of using Structural! I've also confirmed that the test code works with Structural.


fix: import api with life cycle state

Description
Updates related to this pull request https://github.com/gravitee-io/gravitee-api-management/pull/2602
Here we remove the update of the api state as it's managed in the import now

:tada: This PR is included in version 0.1.0-alpha.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove "/" from E2E cypress.json baseUrl

Having baseUrl as "http://dev-com-17.accdemo.b2c.ydev.hybris.com:4200/" causes random failures when running regression tests.
Ending "/" should be removed automatically in case of user error (which is fairly common in this case).
End to end tests must work with either:
"http://dev-com-17.accdemo.b2c.ydev.hybris.com:4200/"
"http://dev-com-17.accdemo.b2c.ydev.hybris.com:4200"
file: /spartacus-installation/source/projects/storefrontapp-e2e-cypress/cypress.json

Already in place


Validate that the defaults are used after first time flashing

We had a case where the defaults were not used and all was set to  or 0.

Thanks. I don't understand why that happens at the moment but will fix it this weekend.

Should work now.


10.0.22621.3672 not supported

Hello, Is there any solution for that?
I'm here from youtube
https://www.youtube.com/watch?v=WQYW1vxv6nI
and stuck on 3:43.

My Windows version.

Duplicate of #2833


Declare license using SPDX identifier

That's the recommended way to work with licenses in the Maven POM, see https://maven.apache.org/pom.html#Licenses

Good catch. Thanks, @Bananeweizen!


Cosmos app crashing

I've been trying to sign a transaction (delegation/send ATOMs) with different web wallets/browsers/PCs. In every case, when pressing 'Sign transaction', Windows Security first shows an error, and when pressing again the Ledger simply crashes. (Ledger on 1.5.5, Cosmos 1.5.3)

Very likely related to https://github.com/luniehq/lunie/issues/2754


Occlusion-collection occasionally doesn't render enough items initially.

If the collection is given an array that's shorter than it's visible area, it won't display them all.  This may have been fixed by removing the "cap to bottom" on the edges check, but I'd like to leave this here until that's certain.

Removing the "cap to bottom" check appears to have entirely eliminated this issue.


With the silk touch enchantment, I can mine tapped blocks

With the silk touch enchantment, I can mine tapped blocks

Latest version fixed that


500 errors due to "cannot read properties of undefined (reading 'owner')"

Hi there,
We recently added preview deployments for Novu NPM packages. However, we often get these 500 errors due to a "cannot read properties of undefined (reading 'owner')" error. For example, you can see this workflow run.
Our setup
The packages folder in our NX-powered mono repo contains 14 packages. On every PR, we use nx affected to see which packages changed between our trunk (next) branch and the current PR HEAD. The affected packages are then deployed as preview packages.
The packages depend on each other. Every package depends on the @novu/shared package. As you can see, in the failed run, some packages fail due to the undefined 'owner' error and others due to a 404 no workflow error. The PR that triggered the failed run only touches the @novu/shared package.
Stacktrace
Packages: +53
+++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 53, reused 53, downloaded 0, added 53, done
shasum for @novu/framework(novu-framework-2.1.0.tgz): e4ca8513eb3401b73584af3dae474c1164db8850
[error] publishing failed: {"url":"/publish","statusCode":500,"statusMessage":"","message":"Cannot read properties of undefined (reading 'owner')"}
  at Object.run (/home/runner/.cache/pnpm/dlx/t6c2gbxqvfjjki5ut3q3wgvbcu/19229b4f4f8-1418/node_modules/.pnpm/pkg-pr-new@0.0.27/node_modules/pkg-pr-new/dist/index.js:3414:18)
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async runCommand (/home/runner/.cache/pnpm/dlx/t6c2gbxqvfjjki5ut3q3wgvbcu/19229b4f4f8-1418/node_modules/.pnpm/pkg-pr-new@0.0.27/node_modules/pkg-pr-new/dist/index.js:2196:16)
  at async runCommand (/home/runner/.cache/pnpm/dlx/t6c2gbxqvfjjki5ut3q3wgvbcu/19229b4f4f8-1418/node_modules/.pnpm/pkg-pr-new@0.0.27/node_modules/pkg-pr-new/dist/index.js:2187:11)
  at async runMain (/home/runner/.cache/pnpm/dlx/t6c2gbxqvfjjki5ut3q3wgvbcu/19229b4f4f8-1418/node_modules/.pnpm/pkg-pr-new@0.0.27/node_modules/pkg-pr-new/dist/index.js:2323:7)

[error] publishing failed: {"url":"/publish","statusCode":500,"statusMessage":"","message":"Cannot read properties of undefined (reading 'owner')"}```

Can you please help us identify the issue of this failure?

Thank you in advance.

Hey! I'll check it soon and resolve it for you!

Interesting, the error is pretty vague, so hopefully #248 would fix it.
Regarding the cause of the error, I see this:

In a github workflow run, you cannot run a pkg.pr.new command multiple times since there's a hash created in our server that would be consumed after the first run. That's why it gives cannot read from undefined, since the workflow gets removed after the first run (to avoid spam and clean up space).
Here's the right approach:
pnpm pkg-pr-new publish './packages/changed-A' './packages/changed-B'
You should put all the changed packages in the same command, rather than running pkg.pr.new for each changed package.
Let me know if it makes sense to you.

Thanks @Aslemammad. This is helpful. Is it possible to specify package names instead of folders?

I now get a 400 No package error. See here.
The command that is executed is the following: pnpx pkg-pr-new publish './packages/cli' './packages/client' './packages/framework' './packages/headless' './packages/js' './packages/nest' './packages/node' './packages/notification-center' './packages/providers' './packages/react' './packages/shared' './packages/stateless'

Hmm, interesting!
The escaping looks weird, can't we have something like the command you sent?

The original command is pnpx pkg-pr-new publish './packages/cli' './packages/client' './packages/framework' './packages/headless' './packages/js' './packages/nest' './packages/node' './packages/notification-center' './packages/providers' './packages/react' './packages/shared' './packages/stateless'. The scripts that generates it is here.
Maybe it's an execa glitch. Execa escapes quotes on console.error

I see, is it possible that the cwd the execa running in might not be the right place?
because if those items are right, then the only way they might not resolve is that they might not be there.
I guess the cwd or the path the command runs in might not be the right place!

It was an escaping issue after all. Thanks for the help. The project rocks!

Amazing to see it works, thank you so much.
On Sat, 28 Sept 2024, 20:08 Sokratis Vidros, @.***>
wrote:

It was an escaping issue after all. Thanks for the help. The project rocks!
—
Reply to this email directly, view it on GitHub
https://github.com/stackblitz-labs/pkg.pr.new/issues/247#issuecomment-2380773422,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJBMICA2MG2TUNIYESRYTP3ZY3LPTAVCNFSM6AAAAABO23SMA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBQG43TGNBSGI
.
You are receiving this because you were mentioned.Message ID:
@.***>


Collapse per-package test pipelines to per-service pipelines

The following services have pipelines per-package

Event Hubs
Key Vault
Storage

These should be collapsed down to a single tests.yml file at the level of the service and the tests.yml should use a ServiceDirectory to keep with the way we're doing this in our ci.yml files.

@danieljurek Am guessing this is related to the integration tests? Can you provide a few more details on the motivation behind this change?

This is related to the live tests. We want to standardize the layout of pipelines to the approach we're taking for all other languages. This will make it easier to scale automation for creating pipelines (and pushing out changes across all pipelines like we saw in the conversation last week about triggering conditions).
Live test pipelines for all other languages are per-service instead of per-package. For example, other languages use <language> - keyvault - tests which includes certs, keys, and secrets instead of separate pipelines per-package in JS like js - keyvault-keys - tests. JS is the only place where we have per-package pipelines and it's a holdover from when we were trying both approaches.
Are there concerns around making this change?

For the nightly runs, this doesnt make much of a difference.
But they do make a difference when we trigger the live tests in PR via the azp command
Take the case of a PR made to keyvault keys. Today, we sometimes trigger the live tests for the same via the azp command in the PR. The PR is now blocked until the test run is done. With the changes in this PR, we will now be running the live tests for secrets & certs. Now, am not sure if secrets, certs & keys tests will be run in parallel or sequentially, but this will definitely increase the waiting time for the PR.
Same goes for storage.
cc @sadasant, @jonathandturner for Keyvault and @jeremymeng for Storage

The main reasons we want to do this collapse is for consistency (the other language live tests have already been collapsed) and efficiency (having them all in one pipeline will allow us to more easily pivot how often and how parallel the pipeline runs).  If there's a strong reasons for there to be multiple live test pipelines we can explore options there, but right now we're working on tooling to automate pipeline generation which requires consistency in the pipelines across the entire engineering system.

It would be nice to be able to trigger live tests per package.

@mitchdenny you have thought about this from the unified pipeline prospective have you done any further digging that would enable us to run a pipeline with some sort of configuration option that would enable us to filter it to a package?

I haven't done any thinking here beyond some top-level spit balling. What I was thinking was some kind of script that runs in every pipeline that determines whether the pipeline is running as a PR and then goes and reads the tags on the PR and inserts their presence into a variable.
This variable could then be used to conditionalize certain steps in the pipeline. That would be a base change that would enable a bunch of scenarios, including this one.
Then to enable this particular scenario we would have multiple jobs, one for each artifact. They would all run by default, but someone working on the PR could add a tag that disables one of the artifact test runs.
I'd love to know how much of a time difference there is between running a full test suite for certs, secrets and keys vs. just one of them?

three keyvault live tests pipeline usually take 40, 30, and 30 minutes respectively.
storage-blob and storage-file-share can each runs close to 1 hour and passing. One hour is the timeout for the pipelines. storage-queue queue takes 20~30 minutes.

@mitchdenny, @weshaggard and I chatted yesterday about a pipeline architecture that would keep per-package live test pipelines. We're planning to start prototyping this with JS soon.
We can close this issue as collapsing the per-package pipelines is no longer particularly relevant given these requirements.


Add crate-level documentation

Add crate-level documentation and API explanations for the evm crate.
Should address #1376

I guess @pgebheim is the best to answer this question!


Re-export WithSyntax from glimmer-runtime.

What is this for?

https://github.com/thefrontside/ember-let/issues/21#issuecomment-257612614

Closing. I should have read my own comment better. An AST transform is much better for this (and is how I prototyped it in the linked comments JSBin)....


Make consumer directory configurable

Make the realtime off heap dictionary storage directory configurable, so
that it can be placed onto a different filesystem than the segment data.

Codecov Report

Merging #1969 into master will increase coverage by 20.26%.
The diff coverage is 63.63%.

@@             Coverage Diff             @@
##           master    #1969       +/-   ##
===========================================
+ Coverage   49.39%   69.66%   +20.26%
===========================================
  Files         824      824
  Lines       40288    40293        +5
  Branches     5421     5423        +2
===========================================
+ Hits        19902    28070     +8168
+ Misses      18657    10349     -8308
- Partials     1729     1874      +145

Impacted Files
Coverage Δ

...m/linkedin/pinot/common/utils/CommonConstants.java
36.66% <ø> (+1.66%)
:arrow_up:

.../starter/helix/HelixInstanceDataManagerConfig.java
91.89% <100%> (+0.22%)
:arrow_up:

...re/data/manager/config/TableDataManagerConfig.java
79.16% <100%> (+1.89%)
:arrow_up:

...ata/manager/realtime/RealtimeTableDataManager.java
47.05% <50%> (-0.81%)
:arrow_down:

...t/common/exception/PermanentDownloadException.java
0% <0%> (-100%)
:arrow_down:

...not/common/segment/fetcher/HttpSegmentFetcher.java
68.42% <0%> (-15.79%)
:arrow_down:

...kedin/pinot/core/query/reduce/EqualComparison.java
55.55% <0%> (-11.12%)
:arrow_down:

...not/core/query/pruner/DataSchemaSegmentPruner.java
53.65% <0%> (-4.88%)
:arrow_down:

...afkaHighLevelConsumerBasedRoutingTableBuilder.java
89.28% <0%> (-3.58%)
:arrow_down:

.../server/starter/helix/SegmentFetcherAndLoader.java
56.46% <0%> (-2.73%)
:arrow_down:

... and 420 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d18dd11...f3949c2. Read the comment docs.

I'll address the review comments in a different PR, due to the time constraint on this. Created internal ticket PINOT-5394 to track it.


feat: add GraphQL to fetch notifications

Description:
This PR adds graphql and to fetch all the notifications
Related changes:
Implement graphql for application root
Add a function to fetch all the notifications
Add Notification Resolver
Register Returning Models by modifying notification entity.
Curl:

curl 'http://localhost:3000/graphql' -H 'Accept-Encoding: gzip, deflate, br' -H 'Content-Type: application/json' -H 'Accept: application/json' -H 'Connection: keep-alive' -H 'DNT: 1' -H 'Origin: http://localhost:3000' --data-binary '{"query":"query {\n  notifications {\n    channelType\n    createdBy\n    createdOn\n    data\n    deliveryStatus\n    id\n    result\n    status\n    updatedBy\n  }\n}"}' --compressed

Sample Response:
{
  "data": {
    "notifications": [
      {
        "channelType": 2,
        "createdBy": "osmo_notify",
        "createdOn": "2023-11-28T04:59:32.000Z",
        "data": {
          "from"<EMAIL_ADDRESS>          "to"<EMAIL_ADDRESS>          "subject": "Test subject",
          "text": "This is a test notification",
          "html": "This is a test notification"
        },
        "deliveryStatus": 3,
        "id": 1,
        "result": {
          "result": {
            "status": 200,
            "id"<EMAIL_ADDRESS>            "message": "Queued. Thank you."
          }
        },
        "status": 1,
        "updatedBy": "osmo_notify"
      },
      {
        "channelType": 1,
        "createdBy": "osmo_notify",
        "createdOn": "2023-11-28T05:04:30.000Z",
        "data": {
          "from"<EMAIL_ADDRESS>          "to"<EMAIL_ADDRESS>          "subject": "Test subject",
          "text": "This is a test notification",
          "html": "This is a test notification"
        },
        "deliveryStatus": 4,
        "id": 2,
        "result": {
          "result": {
            "errno": -3008,
            "code": "EDNS",
            "syscall": "getaddrinfo",
            "hostname": "smtp.gmail.com",
            "command": "CONN"
          }
        },
        "status": 1,
        "updatedBy": "osmo_notify"
      }
    ]
  }
}

Snapshot:
Success:

Fail:

@PrinceYadav2
We have recently also added API key guard.
Add this for graphQL too
https://github.com/OsmosysSoftware/osmo-notify/blob/7778edb226a7fa83e0bf0fa360a4760278fc8bde/src/modules/notifications/notifications.controller.ts#L26

@PrinceYadav2 We have recently also added API key guard. Add this for graphQL too
https://github.com/OsmosysSoftware/osmo-notify/blob/7778edb226a7fa83e0bf0fa360a4760278fc8bde/src/modules/notifications/notifications.controller.ts#L26

Added API key guard for the same, attached a screenshot of failing case in description.


Add specificity ordering to glob matching

Sort globs to favor those with more non-wildcard characters.
Also quote non-wildcard characters during Pattern construction.
Targets #27.

Who are the right people to review this PR?


Develop unit/self test framework using ippeveprinter

Currently there is no automated way of testing the self-certification tools. Goals:

Use ippeveprinter to simulate a variety of printers, both conforming and non-conforming.
Develop self-test scripts for Windows and macOS/Linux (that can be bundled with the tools) that runs them against ippeveprinter.
Make this self-test script part of the release process, such that a clean install should be able to pass the self-test on any of our supported platforms.

[master a366dd4] Add "make test" target and "buildtest.sh" script (Issue #56, Issue #62)


ZPM does not work with DelimitedIdentifiers SQL parameter set to 0

USER>d $SYSTEM.SQL.Util.SetOption("DelimitedIdentifiers",0)
USER>zpm "install zpmhub"
ERROR! SQLCODE: -25 Message:  Input (?) encountered after end of query^ SELECT DISTINCT %EXACT Dependencies_VersionString ?

Closing issues fixed in v1 branch for cleaner bookkeeping.