Nightly Branch reports all collections as duplicate

Version Number
1.19.1-nightly50
What branch are you on?
nightly
Describe the Bug
I switched to the nightly branch some time ago as it resolved some issues I was having at that point but from some time yesterday each scheduled run has failed:
|========================================= Warning Summary ==========================================|
|                                                                                |
| Count | Message                                                                                |
|=======|============================================================================================|
|     2 | Config Warning: Skipping duplicate collection: "Trending Now"                              |
|     2 | Config Warning: Skipping duplicate collection: "Most Watched This Week"                    |
|     2 | Config Warning: Skipping duplicate collection: "Most Watched This Year"                    |
|     1 | Config Warning: Skipping duplicate collection: "Netflix"                                   |
|     1 | Config Warning: Skipping duplicate collection: "Marvel Cinematic Universe"                 |
|     1 | Config Warning: Skipping duplicate collection: "DC Extended Universe"                      |
|                                                                                |
|========================================== Error Summary ===========================================|
|                                                                                |
| Count | Message                                                                                |
|=======|============================================================================================|
|     2 | YAML Error: metadata attribute is required                                                 |
|                                                                                |
|====================================================================================================|
|                                         Finished 11:25 Run                                         |
|                                     Version: 1.19.1-nightly50                                      |
|                          Finished: 11:25:33 2023-12-13 Run Time: 0:00:03                           |
|====================================================================================================|
Every collection reports as a duplicate. I am certain I do not have duplicate collections configured.
The same setup running the develop branch works correctly.
Relevant Collection/Overlay/Playlist Definition
No response
Logs
No response

Reporting the exact same behaviour. Rolling back to the main branch with the same configuration files yields no error so does seem to be something in the new nightly.

Can we have a log of this behaviour please?

Can we have a log of this behaviour please?
As a side-note I would suggest using develop as we are reworking some things in nightly, but I would really appreciate those logs.

I can get a log later this evening. The standard meta.log?
I’ve already switched to the develop branch and it is working as expected but will switch back to nightly to get the log file for you. Thanks.

Can we have a log of this behaviour please?
As a side-note I would suggest using develop as we are reworking some things in nightly, but I would really appreciate those logs.

I can get a log later this evening. The standard meta.log? I’ve already switched to the develop branch and it is working as expected but will switch back to nightly to get the log file for you. Thanks.

If you've only done one run, then meta.log.1 would be the "n-1" log, you can check the log header which will tell you what branch was running.

Can we have a log of this behaviour please?
As a side-note I would suggest using develop as we are reworking some things in nightly, but I would really appreciate those logs.

I can get a log later this evening. The standard meta.log? I’ve already switched to the develop branch and it is working as expected but will switch back to nightly to get the log file for you. Thanks.

If you've only done one run, then meta.log.1/meta.1.log would be the "n-1" log, you can check the log header which will tell you what branch was running.

Meta log attached using nightly build
meta.log

Can we have a log of this behaviour please?
As a side-note I would suggest using develop as we are reworking some things in nightly, but I would really appreciate those logs.

I can get a log later this evening. The standard meta.log? I’ve already switched to the develop branch and it is working as expected but will switch back to nightly to get the log file for you. Thanks.

If you've only done one run, then meta.log.1/meta.1.log would be the "n-1" log, you can check the log header which will tell you what branch was running.

Meta log attached using nightly build
meta.log

Thanks
Can you send me the contents of /config/TV Shows.yml

Can we have a log of this behaviour please?
As a side-note I would suggest using develop as we are reworking some things in nightly, but I would really appreciate those logs.

I can get a log later this evening. The standard meta.log? I’ve already switched to the develop branch and it is working as expected but will switch back to nightly to get the log file for you. Thanks.

If you've only done one run, then meta.log.1/meta.1.log would be the "n-1" log, you can check the log header which will tell you what branch was running.

Meta log attached using nightly build
meta.log

Thanks
Can you send me the contents of /config/TV Shows.yml

TV Shows and Movies config attached.
pmm.zip
If you spot any other obvious improvements I can make, hints would be appreciated ;)

Thanks - we know why this is happening, just trying to break it down.
Are you on the Discord? Can chat easier there if you want.

This should be fixed in nightly54

This should be fixed in nightly54

Really appreciate the efforts to get this fixed so quickly. You definitely deserve the sponsorship money for this kind of response. Off topic, I read that FlixPatrol has gone subscription based which has broke the integration. Have you considered (is it even possible) to charge PMM users a small fee to cover the costs of that?

The subscription is insanely expensive, and chances are the sort of use PMM would put it to would not be allowed, anyways.

This should be fixed in nightly54

Really appreciate the efforts to get this fixed so quickly. You definitely deserve the sponsorship money for this kind of response. Off topic, I read that FlixPatrol has gone subscription based which has broke the integration. Have you considered (is it even possible) to charge PMM users a small fee to cover the costs of that?

its like 50k a month for api access. Flixpatrol is in nightly and develop versions of pmm anyway


Refactor password prompt to internal package

Description
Currently, the password prompt is buried in the bee\cmd\bee package, is not testable, and is not available to other commands.
This PR reimplements the password prompt functionality in an internal package to bee\cmd, with unit tests. It exposes the following interfaces:

PasswordReader - for reading passwords securely from stdin or reading from a (plaintext) file
PasswordPrompter - for generating a prompt and reading from a PasswordReaded
PasswordConfirmer - for confirming a password with two prompts (which must match)

Note that this PR does replace terminal functionality (I will do it separately).
Related to #1037

@paxthemax , what is the status of this PR?

Closing this PR until I come up with a better solution.


ValueError: negative row index found

<<Please describe the issue in detail here, and for bug reports fill in the fields below.>>
ValueError: negative row index found
File "D:\Anaconda3-5\lib\site-packages\scipy\sparse\coo.py", line 234, in _check
raise ValueError('negative row index found')
Reproducing code example:
<<A short code example that reproduces the problem. It should be self-contained, i.e., possible to run as-is via 'python myproblem.py'>>

Error message:
<<Full error message, if any (starting from line Traceback: ...)>>

Scipy/Numpy/Python version information:
<<Output from 'import sys, scipy, numpy; print(scipy.__version__, numpy.__version__, sys.version_info)'>>

@superrui0810 without further details, there is not much we can do about this.

Here is the code：
data['user'] = data['user'].astype("category")
data['artist'] = data['artist'].astype("category")
# create a sparse matrix of all the users/plays
plays = coo_matrix((data['plays'].astype(numpy.float32),
                   (data['artist'].cat.codes.copy(),
                    data['user'].cat.codes.copy())))

the len（data['artist']）=17,559,530  the len（data['user']）=17,559,530
Is the data too large？？？？

my scipy version is 0.19.1

@ilayn
Here is the code：
data['user'] = data['user'].astype("category")
data['artist'] = data['artist'].astype("category")
create a sparse matrix of all the users/plays
plays = coo_matrix((data['plays'].astype(numpy.float32),
(data['artist'].cat.codes.copy(),
data['user'].cat.codes.copy())))
the len（data['artist']）=17,559,530 the len（data['user']）=17,559,530
Is the data too large？？？？
my scipy version is 0.19.1

The error tells you that you have negative numbers in your row indices which in your case the array data['artist'].cat.codes.

but   array  data['artist'].cat.codes have no negative numbers ，how to deal with it

Without any data, I can't see what the problem is but if you are also downcasting the artist cat code, there might be an integer overflow problem. Please try to narrow your problem to a manageable size provide a reproducible standalone example. Otherwise we will just keep on guessing which is not efficient.

I wil try ，Thanks

It's unlikely that the data size is too large, unless you're using a very memory-constrained computer.
As a quick test, try:
assert np.all(data['artist'].cat.codes >= 0)

It might also be useful to check the dtype of each array. Make sure the rows and columns are either np.int32 or np.int64 to avoid surprises.

Just want to share for people with this same problem (on the same data/tutorial) in the future. The user most likely read the same code as what I came across https://github.com/ihongChen/PlayRecommendSystem/blob/master/lastfm_calculate_similar.py
It's nothing to do with too large data. The artist categorical codes has negative value since some rows on data contains Null value. To fix this:
# create a sparse matrix of all the users/plays
data.dropna(inplace=True)
plays = coo_matrix((data['plays'].astype(numpy.float32),
               (data['artist'].cat.codes.copy(),
                data['user'].cat.codes.copy())))

Closing old issue without followup and plausible explanation as a user problem


Registry access for billing viewers

As a Product Owner, I want the ability to add team members as billing viewer in the registry, so that they can track the list of existing projects and identify licence plates at any time.
Context: CITZ IMB (Craig Shutko / Justin Hewitt) - need their Finance teams to see all projects so that they know what to look for in Azure Cost analysis, and identify licence plates. They also need to be able to track all projects, right now they can’t know for sure what projects exist under their Expense Authority unless someone manually tells them. The idea is to let them use the registry as a source of truth.
Acceptance Criteria:

Create a "Viewer" role in the registry.
That role allows a user to see a project they are assigned to, in the project list, and be able to browse project details.
That role doesn't allow any modifications by their user.
That role can be assigned to the same person (IDIR) on one or several projects.
On an existing project, under the "Team contacts" section, below/after the Technical Lead and After Hourse support contact, add a "+ Add viewer" button (similar to the Technical lead yellow button) - to allow adding a viewer user to that project.
Explanation text under "Viewer" title: "This role enables a team member to see this project in the registry, and browse information without being able to edit it. It is typically useful for billing or administrative purposes."
Allow the same mechanism to add and remover users (same as secondary technical lead).
Several viewers can be added (limit 20 users).
Add the same logic to the "+ Request a new product" page, when first creating the project request.

While this addition might currently be helpful for public cloud, I anticipate it might solve the same problem to public cloud clients when the cost recovery is enabled and finance teams will need to reconcile their bills.

@ThibaultBC do they able to download complete eMOU PDF as well?

Hi @junminahn , If that doesn't add to much work, yes, that's a good option. We anticipate this feature to be used by admin/finance staff so proving access to the eMoU might be valuable and save some manual steps and requests.
Thanks for the suggestion

@ThibaultBC Do we want to restrict access to specific projects only, or should admin and finance staff have access to all public cloud projects?

@junminahn They currently don't see any projects, so the goal for this feature is to allow PO or TL to give them viewer access on a per project basis.
Are you saying some users (other than us as admin) see the entire list?

@ThibaultBC Currently, we have a global-level billing reader role that provides read-only access to all public cloud projects, including the ability to download eMOU documents. But, I see that your requirement is slightly different, as it allows the PO to grant access to a specific person for a particular project only.

@junminahn There is a billing viewer role exclusively for AWS, and that allows access to the AWS Quicksight Dashboards. However this doesn't exist for Azure, and the viewer role as described in this story doesn't give access to anything beyond the registry, it's just allowing users to view projects in the registry as their source of truth.
Please let me know if I missed something

I think the billing reader you may be referring to could be for our team admin/finance, in order for them to prepare the cost recovery, but I'm not sure if it could apply to customer's team members

@ThibaultBC as your requirement is to grant the ability to give the viewer role to a specific person defined by the project PO, it will be a new requirement for our team for sure. thanks.


--rpath -> -rpath

-Wl,--rpath works, but it seems to be an unofficial API.
See https://linux.die.net/man/1/ld for reference.

Closing all existing pull requests that have been in this state for over 6 months. In case this pull request is still valid, please rebase your changes against develop branch and resubmit.


Unknown option --threads when run vitest with --no-threads option

Describe the bug
Hello,
I run test with disabled multi-threading (it works fine on 0.34.6):
vitest run --no-threads

After switch on 1.0.0-beta.5 and then 1.0.0-beta.6, the same command leads to the error:
file:///Users/my-username/my-repo-name/node_modules/cac/dist/index.mjs:400
          throw new CACError(`Unknown option \`${name.length > 1 ? `--${name}` : `-${name}`}\``);
                ^

CACError: Unknown option `--threads`
    at Command.checkUnknownOptions (file:///Users/my-username/my-repo-name/node_modules/cac/dist/index.mjs:400:17)
    at CAC.runMatchedCommand (file:///Users/my-username/my-repo-name/node_modules/cac/dist/index.mjs:598:13)
    at CAC.parse (file:///Users/my-username/my-repo-name/node_modules/cac/dist/index.mjs:537:12)
    at file:///Users/my-username/my-repo-name/node_modules/vitest/dist/cli.js:71:7
    at ModuleJob.run (node:internal/modules/esm/module_job:218:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:329:24)
    at async main (file:///Users/my-username/my-repo-name/node_modules/vitest/dist/cli-wrapper.js:45:5)

Node.js v21.2.0

Reinstalling packages don't help. Rollback to 0.34.6 fix the problem ⇒ I'm making an assumption that something is wrong with beta version.
Reproduction
Node.js 21.2.0
TypeScript: 5.2.2

https://github.com/adequatica/api-vitesting
Change "vitest": "1.0.0-beta.6"
npm install
Run npm test

System Info
System:
  OS: macOS 13.6.1
  CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Memory: 7.51 GB / 32.00 GB
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 21.2.0 - ~/.nvm/versions/node/v21.2.0/bin/node
  npm: 10.2.3 - ~/.nvm/versions/node/v21.2.0/bin/npm
Browsers:
  Safari: 17.1
npmPackages:
  vitest: 1.0.0-beta.6 => 1.0.0-beta.6

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

--threads was removed in beta 0 and replaced with --pool=threads: https://github.com/vitest-dev/vitest/releases/tag/v1.0.0-beta.0

Ah, thanks a lot, look forward for 1.0 release and documentation updates.


Click bar chart bar or legend

Is it possible to handle the click in the bar chart when clicking a bar or it's legend?
Trying this plunker from the demo page and clicking on a bar, browser console shows:
Uncaught TypeError: a.target.className.indexOf is not a function

The error has be caused by a Chrome extension.


Compilation error when conditionally returning an input or a function of it (Linux, MacOS)

I'm getting a compilation error on this:
The error seems to indicate that the input variable W is understood to be a list, but I'm not sure why that would be...
import numpy as np

#pythran export test(float[][])
def test(W):
    S = func1()
    if S == 0:
        return W            # <- Fails to compile.
        #return np.array(W)  # <- Compiles
    return 2*W

def func1():
    return 1

I confirm that it's now fixed! Thanks!


add a test for dimensionless input of delta_nu

Addresses Issue #572

This PR will be ready for review when the tests pass.


Ignore 404 errors when deleting non-searchable models

Closes #88
Ignores 404 errors when deleting non-searchable models. This enables usage of shouldBeSearchable without causing exceptions, and without the need for extra queries.
I wasn't able to test thouroughly, but according to Elasticsearch docs it should work.

Thank you for easy and eloquent solution!
I changed the code a bit, cause payload should be slightly different, you can check it here https://github.com/babenkoivan/scout-elasticsearch-driver/commit/2f3f7f5aa3bd2dc6369e5d22319db1d7a81f8066

@babenkoivan Great, thanks!


Disable unsafe code with a forbid_unsafe feature

See Issue: #398
As discussed in the linked issue, this PR adds an allow_unsafe feature and gates all unsafe code on it.
This does not include that feature in the default features, so the effect of this PR would be to effectively remove unsafe code from logos unless it is opted-in.
There should be a discussion (on the issue) of the right strategy to roll this out. Removing unsafe code immediately might not be the best option.
There is an additional issue with the Source trait which this PR does not currently resolve.
Benchmarks
Throughput of the benches for this PR and the original code (in GiB/s). Method: bench was run on release build four times, alternating between toggling allow_unsafe on and off. No extra effort was made to quiesce the machine other than just close other desktop apps.
It'd be very beneficial to get benchmarks on other CPUs, given the surprising result for the i7.
Mac M3 Air

Benchmark
Safe (this PR)
Unsafe (original)
Delta

iterate/identifiers
1.6214
1.6862
-3.84%

iterate/strings
1.2354
1.2479
-1.00%

iterate/keywords_operators_and_punctators
2.0598
2.0721
-0.59%

count_ok/identifiers
1.6191
1.6742
-3.29%

count_ok/keywords_operators_and_punctators
1.2391
1.2423
-0.25%

count_ok/strings
2.0746
2.0782
-0.17%

Disabling unsafe code does slow down throughput by a small amount, though not as much as I anticipated.
i7-7700HQ (Alienware 13 R3)

Benchmark
Safe (this PR)
Unsafe (original)
Delta

iterate/identifiers
1.0751
0.9426
+14.06%

iterate/strings
0.9987
0.9204
+8.51%

iterate/keywords_operators_and_punctators
1.3997
1.2977
+7.86%

count_ok/identifiers
1.0430
0.9526
+9.49%

count_ok/keywords_operators_and_punctators
0.9497
0.9088
+4.50%

count_ok/strings
1.3772
1.2962
+6.25%

I did not expect this result, at all. I suspect the compiler is able to take an optimization it otherwise couldn't, but I've not investigated why yet.
Next steps

Some more benchmarks
Decision on default state of feature flag or just remove unsafe
Documentation
Mark Source unsafe if unsafe code is enabled - I think I have to duplicate the entire trait under a cfg because you can't conditionally compile an effect (unsafe) afaik
read_byte_unchecked use is emitted by the code generator, will need to bring it back and also introduce a safe alternative

Thanks for your detailed PR and comment!
This work looks good and legit to me, but I think three important things are missing:

allow_unsafe should be opt-out, so maybe to set allow_unsafe as a default feature, or switch it to disallow_unsafe. This is to limit potential changes in performances that users may not expect when bumping between two versions. People that care about safety will be able to opt out of unsafe code. Maybe in the future safe code will be the default, but I think this need further investigation.
Automatic tests in workflows should include a version with and a version without allow_unsafe.
What you wrote should be documented in a page of Logos' book, probably talking about safety, where unsafe code is used (as you already did the job of investigating), and how to opt-out (and potential performance costs / gains).

Thanks for your work on this :-)

PS: note that the tests are currently failing, so fixing them is the priority :-)

Oops, I had run tests only against the logos crate itself and not the workspace. I'll work on fixing those now, looks like it is failing because I entirely removed read_byte_unchecked thinking it was unused.

I'll rename the feature to disallow_unsafe so that it is opt-in. I think that will be more ergonomic since adding allow_unsafe to defaults would mean having to use default-features = false and then explicitly listing the other default features just to get safe-only .
Thanks for enabling checks on the PR. I'll add tests against disallow_unsafe and also add it to the benchmark run.
Handbook page - will do.

I'll additionally do something about the unsafety of the Source trait so safe code can't cause UB in unsafe code.
This will take a few commits to accomplish so I've changed this over to a draft until its ready for review.

Will name it forbid_unsafe for parity with Rust's allow/forbid terminology around unsafe_code.

This now runs tests and benchmarks against both the default feature set and the new forbid_unsafe feature.
The remaining work is to split the unsafe code into new UnsafeSource and UnsafeChunk traits. That will remove the conditional compilation from the existing Source and Chunk traits, which will expose only a safe interface. Implementers of a custom source may then additionally opt-in to implementing the two new unsafe traits to enable the faster code paths (taking responsibility for any UB caused by incorrect implementation).
Splitting the traits out will remove several conditional compilation attributes and will also work better with the rustdoc generator. As I have it right now, rustdoc can't document that some trait functions depend on features. Also, changing the API based on a feature is a little weird, so this approach will avoid that too.
So some refactors and some documentation and then this will be ready for review.

Thanks for your work @davidkern! Please ping me back when it's ready for a review :-)

Will do! I've also been busy, but will have some more time to finish this up toward the end of the week.

@jeertmans Sorry for the delay getting back to this.
I think this just needed some documentation, which I've now added. I did try to split up the Source trait - but this was causing more issues than it seemed to be solving, so I've instead added a safety note to that trait's documentation.
In terms of merge order, the other PR fixing the benchmark testing should go in first - that will make sure this one gets a good benchmarking run after merge, which should test out both the original unsafe code as well as the new safe-only code paths.
Please let me know if you'd like to see any changes or adjustments to the documentation!

@davidkern thanks so much for this work! The design you arrived at does meet my needs: by requiring the forbid_unsafe feature in my crate I can make sure, even if other transitive dependencies just use the default features, that there is no unsafe code in the dependency tree. (If safety was the default and unsafe was feature-driven, I would not be able to make that guarantee.)

The PR looks great @davidkern! Please reformat the code so linting and formatting checks both pass. Then, I think we can merge this :-)

I really should add cargo fmt to my git pre-checks!
That should do it...

Looks great @davidkern, thank you for your contribution :-)


"msbot update generic" adding raw CLI commands to Structure

Tool
Name: Msbot
Version: 4.3.4
OS: Windows 10
Describe the bug
When running the command msbot update generic to a generic type object in the .bot file, it seems to pipe in the Command itself into a 'Options' Key alongside other values related to the command run.
This is similar to the issue found in: https://github.com/Microsoft/botbuilder-tools/issues/943
To Reproduce
Steps to reproduce the behavior:

Create 'Generic' Type Object in Bot File. In this case it comes from an msbot clone. and it is a 'BotTranslate' object.
Update Object using msbot update generic with --keys value. In this case the command is:
msbot update generic --url "BotTranslate" --keys "{""subscriptionKey"":""999999999999999""}" --secret "BOTSECRET=" --bot "BOTFILE.bot"

Expected behavior
New Value in the 'subscriptionKey' field of the configuration.
Screenshots

Additional context
Seems to be very similar, if not the same as: https://github.com/Microsoft/botbuilder-tools/issues/943 . I also experienced this issue when updating my endpoint. My use case is similar to that user's (Attempting to deploy via CI/CD).
The Value DOES actually get updated, but it also comes with the baggage of the keys.
[bug]

As a workaround, i am running msbot disconnect "SERVICENAME" and then msbot connect generic --url "SERVICENAME" in my CI/CD to 'update' this value.

We are moving away from .bot files as a mechanism to store bot configuration data.  We are instead using existing platform mechanisms, appsettings.json and .env


missing pybind11 dependencies when trying to use model="cnn"

face_recognition version: 0.1.0
Python version: 2.7.13
Operating System: OSX 10.12.5

Description
Traceback when trying to use face detection with model="cnn":
File "brains.py", line 104, in detect_face
    face_locations = face_recognition.face_locations(frame, number_of_times_to_upsample="0", model="cnn")
  File "/Users/cjoseph/anaconda/lib/python2.7/site-packages/face_recognition/api.py", line 114, in face_locations
    return [_trim_css_to_bounds(_rect_to_css(face.rect), img.shape) for face in _raw_face_locations(img, number_of_times_to_upsample, "cnn")]
  File "/Users/cjoseph/anaconda/lib/python2.7/site-packages/face_recognition/api.py", line 98, in _raw_face_locations
    return cnn_face_detector(img, number_of_times_to_upsample)
TypeError: __call__(): incompatible function arguments. The following argument types are supported:
    1. (self: dlib.cnn_face_detection_model_v1, img: object, upsample_num_times: int=0) -> std::__1::vector<dlib::mmod_rect, std::__1::allocator<dlib::mmod_rect> >
    2. (self: dlib.cnn_face_detection_model_v1, imgs: list, upsample_num_times: int=0, batch_size: int=128) -> std::__1::vector<std::__1::vector<dlib::mmod_rect, std::__1::allocator<dlib::mmod_rect> >, std::__1::allocator<std::__1::vector<dlib::mmod_rect, std::__1::allocator<dlib::mmod_rect> > > >

Invoked with: <dlib.cnn_face_detection_model_v1 object at 0x11b6ef8f0>, array([[[  4,   4,   4],
        [150, 150, 150],
        [148, 148, 148],
        ...,
        [ 44,  44,  44],
        [  0,   0,   0],
        [  0,   0,   0]],

       [[150, 150, 150],
        [151, 151, 151],
        [148, 148, 148],
        ...,
        [ 44,  44,  44],
        [  0,   0,   0],
        [  0,   0,   0]],

       [[149, 149, 149],
        [147, 147, 147],
        [146, 146, 146],
        ...,
        [ 44,  44,  44],
        [  0,   0,   0],
        [  0,   0,   0]],

       ...,
       [[ 99,  99,  99],
        [ 94,  94,  94],
        [ 92,  92,  92],
        ...,
        [ 42,  42,  42],
        [  0,   0,   0],
        [  0,   0,   0]],

       [[ 98,  98,  98],
        [ 93,  93,  93],
        [ 94,  94,  94],
        ...,
        [ 40,  40,  40],
        [  0,   0,   0],
        [  0,   0,   0]],

       [[ 93,  93,  93],
        [ 91,  91,  91],
        [ 97,  97,  97],
        ...,
        [ 40,  40,  40],
        [  0,   0,   0],
        [  0,   0,   0]]], dtype=uint8), '0'

Did you forget to `#include <pybind11/stl.h>`? Or <pybind11/complex.h>,
<pybind11/functional.h>, <pybind11/chrono.h>, etc. Some automatic
conversions are optional and require extra headers to be included
when compiling your pybind11 module.

The parameter number_of_times_to_upsample needs to be an integer value. It looks like you are passing it in as a string.
Just change:
    face_locations = face_recognition.face_locations(frame, number_of_times_to_upsample="0", model="cnn")

To:
    face_locations = face_recognition.face_locations(frame, number_of_times_to_upsample=0, model="cnn")

(I.e. Remove the quotes around 0. That's making the value a string instead of an integer)
Hopefully that's all it is :)

Yup, derp!

Help me, I ran into a similar error but this this I do pass a 0 not "0"
Traceback (most recent call last):
File "/Users/huynhphuminh/PycharmProjects/GenderDetection_Facenet_MS_1M/test_face_modules.py", line 30, in
batch_of_face_locations = face.batch_face_locations(curbatch, number_of_times_to_upsample=0)
File "/anaconda3/lib/python3.6/site-packages/face_recognition/api.py", line 146, in batch_face_locations
raw_detections_batched = _raw_face_locations_batched(images, number_of_times_to_upsample, batch_size)
File "/anaconda3/lib/python3.6/site-packages/face_recognition/api.py", line 129, in _raw_face_locations_batched
return cnn_face_detector(images, number_of_times_to_upsample, batch_size=batch_size)
TypeError: call(): incompatible function arguments. The following argument types are supported:
1. (self: dlib.cnn_face_detection_model_v1, imgs: list, upsample_num_times: int=0, batch_size: int=128) -> std::__1::vector<std::__1::vector<dlib::mmod_rect, std::__1::allocatordlib::mmod_rect >, std::__1::allocator<std::__1::vector<dlib::mmod_rect, std::__1::allocatordlib::mmod_rect > > >
2. (self: dlib.cnn_face_detection_model_v1, img: array, upsample_num_times: int=0) -> std::__1::vector<dlib::mmod_rect, std::__1::allocatordlib::mmod_rect >
Invoked with: <dlib.cnn_face_detection_model_v1 object at 0x109771768>, array([[[[ 15.,  12.,   3.],
[ 18.,  15.,   6.],
[ 23.,  16.,   6.],
...,
[ 12.,   8.,   9.],
[ 12.,   7.,  11.],
[  9.,   7.,  10.]],
    [[ 15.,  12.,   3.],
     [ 18.,  14.,   5.],
     [ 23.,  16.,   6.],
     ...,

    [[ 24.,  12.,  12.],
     [ 24.,  12.,  12.],
     [ 24.,  12.,  12.],
     ...,
     [201., 174., 157.],
     [207., 181., 164.],
     [211., 185., 168.]],

    [[ 24.,  12.,  12.],
     [ 24.,  12.,  12.],
     [ 24.,  12.,  12.],
     ...,
     [206., 179., 162.],
     [213., 187., 172.],
     [217., 191., 176.]]]]), 0; kwargs: batch_size=128

Did you forget to #include <pybind11/stl.h>? Or <pybind11/complex.h>,
<pybind11/functional.h>, <pybind11/chrono.h>, etc. Some automatic
conversions are optional and require extra headers to be included
when compiling your pybind11 module.

I managed to fix this by opening the image with cv2 instead of PIL.

I am opening the image with cv2 and still get the same error.

I think the main problem isn't the pybind11 dependencies, but instead it's a problem of what it's passed as arguments to the cnn_face_detection_model_v1.
If you use Python and run the command help(dlib.cnn_face_detection_model_v1) you'll get the following information about the __call__ method
 |  __call__(...)
 |      __call__(*args, **kwargs)
 |      Overloaded function.
 |
 |      1. __call__(self: _dlib_pybind11.cnn_face_detection_model_v1, imgs: list, upsample_num_times: int=0, batch_size: int=128) -> std::vector<std::vector<dlib::mmod_rect, std::allocator<dlib::mmod_rect> >, std::allocator<std::vector<dlib::mmod_rect, std::allocator<dlib::mmod_rect> > > >
 |
 |      takes a list of images as input returning a 2d list of mmod rectangles
 |
 |      2. __call__(self: _dlib_pybind11.cnn_face_detection_model_v1, img: array, upsample_num_times: int=0) -> std::vector<dlib::mmod_rect, std::allocator<dlib::mmod_rect> >

In summary if you pass only the image and number of upsample the image is taken as an array object while if you pass also the batch size the image is taken as a list.
I tested it by reading an image using the OpenCV-Python module and if I specify the image and the number of upsample the call to the detector will work absolutely fine.


Follow-up with ICL community

[ ] Process the information collected
[ ] Ask for a list of interlocutors for each of them
[ ] Send the survey


Using package instead of source codes

I am not sure why copy&pasted code from swift collections was used, but maybe it would make sense to use package instead. Main reason for that is that if you would like to use this package and other (eg. Composable Architecture ) you may get error with conflicting names of the dependencies/libraries. With this change the SPM is able to handle multiple dependencies to the same packages.

Collections were copied because Apple doesn't want to provide the CocoaPods package.

Oh. They published it to CocoaPods. Nice. Will check PR


Create a model and load checkpoints - error FileNotFoundError

each time i try to run the "create a model and load checkpoints code cell" i get this error:
FileNotFoundError                         Traceback (most recent call last)
 in ()
1 from demo import load_checkpoints
2 generator, kp_detector = load_checkpoints(config_path='config/vox-256.yaml',
----> 3                             checkpoint_path='/content/gdrive/My Drive/first-order-motion-model/vox-adv-cpk.pth.tar')
3 frames
/usr/local/lib/python3.6/dist-packages/torch/serialization.py in init(self, name, mode)
208 class _open_file(_opener):
209     def init(self, name, mode):
--> 210         super(_open_file, self).init(open(name, mode))
211
212     def exit(self, *args):
FileNotFoundError: [Errno 2] No such file or directory: '/content/gdrive/My Drive/first-order-motion-model/vox-adv-cpk.pth.tar'
this is my code:
from demo import load_checkpoints generator, kp_detector = load_checkpoints(config_path='config/vox-256.yaml',                              checkpoint_path='/content/gdrive/My Drive/first-order-motion-model/vox-cpk.pth.tar')

You did not run all cells. You should mount google-drive.

I mounted google drive and I'm still getting this error

You did not copy model to your drive or copy it to a wrong folder

I checked the folders. It's correct


Request to expose the Targeter interface in feign client

I have a requirement where i have to wire in a custom targeted. Exposing this interface would be great

Can you tell me why you think you need a custom Targeter?

I have a requirement where in we have to resolve the url based of a String passed in the interface method. Feign only allows URI as the parameter. So I wrote a custom target to do so. By using spring cloud i have to implement the targeted to wire in my custom target. I can provide an example if you like

Examples always help.

This is the use case:
We are generating feign client using swagger code gen to communicate with a thrid party apis.
We want to to use spring-cloud to register these as bean with spring . At this point we are not using hystrix nor ribbon, so i have excluded those dependencies for the autoconfiguration to not kick in.
But we need dynamic resolution of the url based on the product we passed to the interface methods.
For each product we have map to different baseurl likewise
foo -> http://foo.com
bar -> https://bar.com
.
.
Ex:
@FeignClient("foo") public interface FooApi {     @RequestLine("POST /foo/dosomething")     @Headers({"Content-type: application/json", "Accept: application/json"})     Foo doSomething(@Product product ,Bar var1); }
For this i have created  a contract which takes the product string and treats it like a url and appends it to the request.
I also created a custom Target, which see the product and consults a map to replace it with the acutal URL in the apply method.
At this point , i would copy the encoder , decoder, feign registar code to my codespace and implement this logic.
But i want to leverage the work done in spring-cloud but i need to wire in this custom Target via the targeter interface

The way to use feign without ribbon or eureka is as follows:
@FeignClient(name="foo", url="${foo.url}")
public interface FooApi {
//...
}

You can set foo.url at runtime with normal boot properties.


remove character counter

Details

Fixed Issues
Removed character limit counter

$ https://github.com/Expensify/App/issues/8044
Tests

Go to workspace >  Connect bank account > Connect manually
Go to company information page
Check the fields with max character limit (ex:- SSN, zip code, phone number field)  don't have any kind of character counter below when you type something.

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I verified the PR has a small number of commits behind main
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I clearly indicated the environment tests should be run in (Staging vs Production)

[ ] I wrote testing steps that cover success & fail scenarios (if applicable)
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors related to changes in this PR
[x] I followed proper code patterns (see Reviewing the code)

[x] I added comments when the code was not self explanatory
[ ] I put all copy / text shown in the product in all src/languages/* files (if applicable)
[x] I followed proper naming convention for platform-specific files (if applicable)
[x] I followed style guidelines (in Styling.md) for all style edits I made
[x] I followed the JSDocs style guidelines (in STYLE.md)

[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I corroborated the UI performance was not affected (the performance is the same than main branch)
[x] If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

[ ] I verified the PR has a small number of commits behind main
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the testing environment is mentioned in the test steps

[ ] I verified testing steps cover success & fail scenarios (if applicable)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors related to changes in this PR
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified comments were added when the code was not self explanatory
[ ] I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
[ ] I verified proper naming convention for platform-specific files was followed (if applicable)
[ ] I verified style guidelines were followed
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified the UI performance was not affected (the performance is the same than main branch)
[ ] If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

Go to workspace >  Connect bank account > Connect manually
Go to company information page
Check the fields with max character limit (ex:- SSN, zip code, phone number field)  don't have any kind of character counter below when you type something.

[x] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@Tushu17 please add tests, and elaborate them. It's best to overexplain the steps without making any assumptions
Thanks so much!

Can you please confirm, that if user inputs too many characters OR they hit the limit (not sure now if they will be able to input more than max, probably not), is there some indication of this? This is not a problem now, just wanted to ask (ie does it inform the user max length has been used)

When the user hits the limit we don't allow adding more characters, so the user will know that they have reached the max character limit.

When the user hits the limit we don't allow adding more characters, so the user will know that they have reached the max character limit.

Yeah, maybe it might be better for UX to indicate to the user somehow this is the case, but we will see in future if this will be a problem actually.
Thanks!

yeah, it can be frustrating if you don't realize that only last 4 digits of SSN is being asked. Typing more than that does nothing

The placeholder at least says it so I would not worry about that one so much, but if there are some other fields, where the limit is not completely intuitive, it could be problematic, but I would not worry about it now and time will tell if it is actual problem and we can fix it later!

@Tushu17 we also need to remove the default error message. It was originally added for testing purposes ig.

Removed it.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @mountiny in version: 1.1.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Restrict allowed clippy warnings and errors

Current behavior
After this PR is merged, we will be ignoring some clippy warnings in our codes, warnings include

#![allow(unexpected_cfgs)]
#![allow(clippy::unconditional_recursion)]

Desired behavior
We should check across all Rust codebase and fix all clippy warnings/errors that are being bypassed

Hi! I was looking at this issue.
I remove both compiler attributes to get the warnings and see what needs to be fixed, but make lint_cargo_clippy didn't result to any warning.
How could I reproduce these warnings?


Fixed re-authentication error on on-prem key expiry/revoke

Purpose

Handle unrecoverable exceptions
Fixed https://github.com/wso2/product-apim/issues/11618

Codecov Report

Merging #65 (4babd77) into main (e742fd8) will decrease coverage by 0.37%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main      #65      +/-   ##
============================================
- Coverage     45.22%   44.84%   -0.38%
  Complexity      106      106
============================================
  Files            35       35
  Lines           712      718       +6
  Branches         71       72       +1
============================================
  Hits            322      322
- Misses          345      351       +6
  Partials         45       45

Flag
Coverage Δ

unit_tests
44.84% <0.00%> (-0.38%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../am/analytics/publisher/client/EventHubClient.java
26.01% <0.00%> (-0.94%)
:arrow_down:

...nalytics/publisher/client/WSO2TokenCredential.java
16.66% <0.00%> (ø)


[question] How to set variable from module relation in view ?

Hey,
I'm making a profile ( like in you'r examples ) and i would like to extract/get it from currentUser in my views.
I'v tryed:
{% set profile = currentUser.profile() %}, {% set profile = currentUser.profile().fetch() %} and witch yield ( but twig doesn't recorgnizes it and throws an error ).
So, how do i get related table inside the view ? ( I know that i can do it in controller, but i don't want )
or there's no way of doing these ? if not - how can i change currentUser so that it has ['profile'] fetched to use it in views ?
May be i can somehow fetch it on every user select? like in you'r exaples .with( 'profile' ), but where should i put it ?
Maybe if i change model constructor to something like these:
this.fetchedProfile = yield this.profile().fetch();

will solve the problem ?

You can do {% yield profile = currentUser.profile().fetch() %} and make sure to case the return value to json using toJSON method.
{% yield profile = currentUser.profile().fetch() %}
{% set profileJSON = profile.toJSON() %}

Above should work. Reference to docs http://adonisjs.com/docs/3.1/templating#_yield

Thanks.


dnf fails  - write main() failed to reload written solv file

Suddenly dnf started to fail. At first it was working ok but after a few operations it fails.
'''
[root@moximo ~]# dnf group install "Development Tools" -y
write_main() failed to re-load written solv file
'''

Following advise from this link , I issued yum remove libsolv and noticed that cockpit-package-kit is marked as dependency.
'''
[root@moximo ~]# yum remove libsolv
Dependencies resolved.
Package                                        Arch                                Version                                        Repository                           Size
Removing:
libsolv                                        armv7hl                             0.7.2-1.fc28                                   @System                             704 k
Removing dependent packages:
PackageKit                                     armv7hl                             1.1.10-1.fc28                                  @System                             2.5 M
cockpit-packagekit                             noarch                              183-1.fc28                                     @System                             628 k
libdnf                                         armv7hl                             0.11.1-6.fc28.1                                @System                             286 k
Transaction Summary
Remove  4 Packages
'''
Still researching

Fixed in: https://github.com/SotolitoLabs/moximo-setup/commit/d5ce1cff73db8259becbd897c4b0ab73e14e761e

VERSION_ID was already set to 28 before the issue started to appear. Reopening case

Boot in rescue mode
Reformat / and /var hard drive partitiions
Untar image in hard drive partitions
Boot in normal mode
Reinstall dnf # dnf install -y dnf --releasever 28

Update system # dnf update -y

Check if problem persist


Replace docker/libtrust with go-jose/go-jose

This PR replaces all the docker/libtrust JWT machinery with go-jose/go-jose module. Some of the code has been adopted from the libtrust and adjusted for some of the use cases covered by the token authorization code, especially in the unit tests.
NOTE: docker/libtrust module has been archived for several years now.
Closes https://github.com/distribution/distribution/issues/1820

So from the discussion on slack; did we actually still need it at all? /cc @dmcgowan

Oh! Should've looked; it somehow found it's way into auth as well, not just for signing v1 images

It is indeed. This PR is in a draft because its a ghetto code that needs cleaning up.

Ok, I've cleaned up my last night's horrible code and I think we can proceed to getting this reviewed and iterated on.
PTAL @thaJeztah @dmcgowan @corhere @Jamstah

FYI, the export regulation disclaimer worried me too, so I raised this: https://github.com/go-jose/go-jose/issues/61

I'd like to remove the libtrust kid format if we can. I know we're no longer depending on the package, but consumers would either need to depend on the libtrust package to make the kid, or also have their own code. It doesn't seem to be a standards thing.

What are your thoughts @dmcgowan? I kinda agree but we need some replacement for that if we do rip that out.

I'd like to remove the libtrust kid format if we can. I know we're no longer depending on the package, but consumers would either need to depend on the libtrust package to make the kid, or also have their own code. It doesn't seem to be a standards thing.

What are your thoughts @dmcgowan? I kinda agree but we need some replacement for that if we do rip that out.

Do we need a replacement?
The kid is really for picking a key from a JWKS that is provided by an issuer. I don't think that inventing one from the key material itself is valuable unless someone is coding an issuer implementation specifically for us that also matches (like what libtrust did and expected).
I guess one option would be to ask the user to specify the kid for each public cert. Another option would be to accept a JWKS url and pick up the kid/cert pairs from that. A final slightly less secure option would be to ignore the kid and test all the roots.

Do we need a replacement?

Well accesscontroller maintains a map of trusted publick keys https://github.com/distribution/distribution/blob/f7b3869062dbbfdf0260d223bac90a69418c3028/registry/auth/token/accesscontroller.go#L135
Those are optionally supplied by config https://github.com/distribution/distribution/blob/f7b3869062dbbfdf0260d223bac90a69418c3028/registry/auth/token/accesscontroller.go#L184

The key of the map is what we're talking about though, its the libtrust format. Its only valuable if the token issuer uses the same mapping for the keys in its JWKS. Considering that no one should be using libtrust any more, that's a big ask.
We really need the user to specify kid/root pairs so they can match them to their issuer. Even better would be to accept a JWKS and use that instead.

The key of the map is what we're talking about though

Yes very much so - too many overloaded terms!

I think this might be the right option:

If the user specifies roots, then we only verify tokens that are x5c.
If the user specifies a file that contains a JWKS, then we give it to go-jose and let it do the work.

I think this might be the right option:
* If the user specifies roots, then we only verify tokens that are x5c.

* If the user specifies a file that contains a JWKS, then we give it to go-jose and let it do the work.

So, auth.rootCertBundle and auth.jwks in the configuration.

Correct me if I'm wrong but there should be an option to specify both, right 🤔 It should be your choice what tokens your registry trusts. I may be overthinking this though...

Yes, I don't see why not. If there are both roots and a JWKS configured, use them both.
Or, if there is an x5c in the token, we could verify that with any roots found in the JWKS (which is like our behaviour now). Then we would only have the JWKS option in the config.

Alright, so I got a first step in the direction we agreed on - unless I misunderstood 🙃
PTAL @Jamstah Mind you, it's a bit of a ghetto code that will need cleaning up, but would like your take on this 😬
Also, if @corhere has some spare cycles, that'd be dope  (I'm still expecting him to open that context cleanup PR he keeps promising me 😏)
(yes we will still need to update docs with the jwks option, but I postponed it until we've agreed on the code 😄 )

(I'm still expecting him to open that context cleanup PR he keeps promising me 😏)

Hey now, I only promised to review the context cleanup PR you were going to open @milosgajdos

Hey now, I only promised to review the context cleanup PR you were going to open @milosgajdos

Saw right through my innocuous gaslighting 🙃

Should we be looking at something like this?
https://pkg.go.dev/github.com/s12v/go-jwks

Should we be looking at something like this?
https://pkg.go.dev/github.com/s12v/go-jwks

You mean for rotation? Yeah, seems reasonable. Let's rip libtrust out first though 😄

We can rip out a load of the libtrust crypto from the test files too.
We don't have to, but it reduces the complexity.
Jamstah@f485172

I was going to look into ripping that crypto_test.go file out in the followup. There is more cleanup to be done beyond that, I feel 😅 Nice! I'll [shamelessly] adopt these changes 😄

I'll try to find some time to review, but with a big disclaimer that this area is not really my expertise. I did ping @jcarter3 and @technicallyjosh on our Slack, as they are more familiar with this, and they were definitely in favor of removing libtrust (but don't know to what extent they reviewed the change in-depth).

@thaJeztah we need @dmcgowan here primarly. He was the OG creator so he likely understands ins and outs of this code.

Agreed that removing the KID definition here makes sense to match the spec, since it is "unspecified".  It should be up to the token service and jwk creator to ensure it matches using whatever format or criteria they determine to be the most secure.
The key sets from an endpoint seem interesting as well as a future change and align nicely with the distribution architecture of horizontally scaled registry instances using a token service which owns the token private key and could potentially serve that as an endpoint. This would make key rotation much simpler. Going along with that, supporting multiple signing keys could aid in that rotation.

@Jamstah anything we're missing here that's preventing you from ✅ ? Other than the [inevitable] squash 😄

Squash (or cleanup of some of the commits at least) would be nice 😅

Squash (or cleanup of some of the commits at least) would be nice 😅

Yes, just wanna make sure we're done updating before I squash and merge. Otherwise all the discussion in this terrible GH Review UI will be lost in the darkness of our memories

Sorry, had forgotten I had a request changes open!
Lgtm.


Task 151043572

This is the code for extracting comparisons - pathways and gene profiles.
Here you can find if the tests passed
http://bar.ebi.ac.uk:8085/browse/ATLAS-GXACIDEVTASKS0

@alfonsomunozpomer do approve / merge

[Delivers #151043572]


HTML

Where can i edit the HTML file so i can edit the web ui with different colors?

I just want to know where i can edit the html file so i can edit the colors of the web ui.


extra space next to the month selector

In chrome, there is extra space on the left side of the right arrow, next to the month selector.

I'm not seeing this on our demo page.  Can you post a screenshot along with your code snippet?

I'm just looking at your demo page, not my own code.

Oh.  On the left side of the right arrow button.  Thanks.

@wesleycho, I think this is a browser bug.  Chrome is allocating an extra 2px to the <th> cell.  We have no styling here and there's nothing I can see that we can do.

It's the pull-right class on the template here  Year, Month, and Day templates all have the pull-right class on the right button.

I think the fix for this should be
.uib-datepicker .uib-right {
  width: 100%;
}

Would need to test across browsers though.

That removes all the space entirely.  Is that what we want?

table.uib-daypicker button.uib-right {
    width: 100%;
}

seems to fix it for all of the ocurrences

It needs to be
.uib-datepicker .uib-right, .uib-datepicker .uib-left {
  width: 100%;
}

or the spacing on the left won't match.

in that case, why not
.uib-left, .uib-right {
  width: 100%
}

Both CSS classes are only used in the template, I see no reason to complicate it

I think the concern is if we ever use those classes for another component. I'm not hugely opinionated on which in this case.


chore: add more unittest for MsgIssue of x/token

Description

modify the input validate unittest of x/token MsgIssue
Add test case of MsgIssue to check conditions and actions

Motivation and context

How has this been tested?

Screenshots (if appropriate):
Checklist:

[ ] I followed the contributing guidelines and code of conduct.
[x] I have added a relevant changelog to CHANGELOG.md
[ ] I have added tests to cover my changes.
[ ] I have updated the documentation accordingly.
[ ] I have updated API documentation client/docs/swagger-ui/swagger.yaml

How about this indentation for events?

That's great. But don't you think is it too long to understand total codes?

How about this indentation for events?

That's great. But don't you think is it too long to understand total codes?

I think so, it is vertically too long. But the events in the original one are horizontally too long.
Let's keep it as is.


White screen when pressing connect

When people register and press login, they cannot connect, they only receive a white screen in the new guac tab.
Event: | Date | Approx time | Team ID | Type | fix kode | virkede det? | System og browser
Aars HHX | 21/11/2018 | 9:39 | 2d49f2a4 | Guac connect virker ikke | Not avialable | Nej | Macbook air - chrome
Aars HHX | 21/11/2018 | 9:40 | 6c5797ab | Guac connect virker ikke | Not avialable | Nej | Macbook air - chrome
Aars HHX | 21/11/2018 | 9:46 | unkown | Guac connect virker ikke | Not avialable | Nej | Macbook - chrome
Aars HHX | 21/11/2018 | 9:45 | bed5a209 | Guac connect virker ikke | Not avialable | Nej | Macbook - safari
Aars HHX | 21/11/2018 | 9:45 | 5f32a235 | Guac connect virker ikke | Not avialable | Nej | Macbook - chrome
Aars HHX | 21/11/2018 | 9:50 | ef89a5e6 | Guac connect virker ikke | Not avialable | Nej | Macbook - chrome
Aars HTX | 21/11/2018 | 12:30 | -- | Guac connect virker ikke |   |   | acer- windows chrome
Aars HTX | 21/11/2018 | 12:30 | teamscm | Guac connect virker ikke |   |   | Asus - windows - chrome

Hi,
This might me delayed observation regarding to white screen, nevertheless I wanted to share what I found regarding to "white screen " issue.
When a user connected to Haaukins platform over Google Chrome browser and click "Connect" button, they face "White screen" as you described. However, it does not happen in other browsers such as Safari & Firefox.  SS of the logs given below when an user tried to connect platform over Chrome.

So, I think, the issue (if it does not happen in other browsers (Firefox, Safari) ) is related with the dependent library *(Guacamole), which enables users to connect Kali over browser by creating RDP.  All in all, there might be some misconfiguration within Go files or another bug, it will be discovered and solved. This is just an observation from log files and tests on other browsers, other inspections might take place regarding to white screen issue.
Regards.

Without having time to prove it, I have strong suspicion that it is linked to the interception module. I suffer from the same issues when trying from Firefox 67.

I may be wrong but i think it has something to with users not getting a guac account on registration.
When a users registers on ctfd the registration hook function exist early if no labs are available at the moment.
Therefore their account will never be assigned to a guac account, and guacLoginIntercept will return without writing anything resulting in white screen.
This can also be seen with the debug prints added below.

Here team ac96a011 registers and gets an lab and RDP connection.
However team 2b3cb84a hits the intercept but doesn't get an guac account.
Later when a new vm is added team 2868f4e9 is able to connect.

So, basically if there is no VM ready to assign, it creates whitescreen error, hence some queuing of VMs and some information while VMs are initialised might be shown on CTFd side as I explained  in here white-screen-fix at line 150.

@jbjjbjjbj development on white screen issue fixed, users will not face white screen, they will face waiting screen until they assigned to a lab.


[Continue-Scaling-Plan] Testing jSnapLoader

Testing:

[ ] Evaluation for memory leaks.
[x] Re-evaluation of the library on the Android and non-common platforms (Linux-arm).

Linux-arm testing progress:

The new v0.4.1 release of the jolt-jni library includes native libraries for arm-linux (32-bit) and aarch64-linux (64-bit) platforms.
The snap-jolt project builds on aarch64-linux. Each build runs the "HelloWorld.java" app, which extracts and loads a jolt-jni native library using jSnapLoader v1.0.0-delta. So I am confident jSnapLoader works on aarch64-linux.

Testing on arm-linux is proving difficult because my Raspberry Pi 400's "libstdc++.so" is a bit too old for jolt-jni.

Linux-arm testing progress:

The new v0.4.1 release of the jolt-jni library includes native libraries for arm-linux (32-bit) and aarch64-linux (64-bit) platforms.
The snap-jolt project builds on aarch64-linux. Each build runs the "HelloWorld.java" app, which extracts and loads a jolt-jni native library using jSnapLoader v1.0.0-delta. So I am confident jSnapLoader works on aarch64-linux.

Thanks for your comprehensive testing. I believe we can proceed for a stable release.

I first need to prepare an Android test example at an android module snaploader-android, that will not take much time hopefully.

First round for evaluation for memory leaks has been completed using jconsole, GNOME System Monitor, and JUL (Java Util Logger) API. The new PR concludes some maneuvers to handle potential memory leaks resulting from the unclosure of resource streams especially when failure events are dispatched, namely file localization failures, and file extraction failures.


Fix documentation pipeline

Change documentation pipeline to no longer use ammaraskar/sphinx-action@master or make api after sphinx version 4.0.0 release causes deprecation issues.

Codecov Report

Merging #92 (5fd9af5) into master (8dce9b4) will decrease coverage by 0.70%.
The diff coverage is n/a.

:exclamation: Current head 5fd9af5 differs from pull request most recent head f7f9f0a. Consider uploading reports for the commit f7f9f0a to get more accurate results

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   62.88%   62.18%   -0.71%
==========================================
  Files          31       31
  Lines        2417     2417
  Branches      358      358
==========================================
- Hits         1520     1503      -17
- Misses        824      842      +18
+ Partials       73       72       -1

Impacted Files
Coverage Δ

adaptdl/adaptdl/torch/_metrics.py
80.80% <0.00%> (-11.21%)
:arrow_down:

adaptdl/adaptdl/sched_hints.py
50.00% <0.00%> (-8.34%)
:arrow_down:

adaptdl/adaptdl/env.py
87.50% <0.00%> (-4.17%)
:arrow_down:

adaptdl/adaptdl/goodput.py
97.54% <0.00%> (-1.64%)
:arrow_down:

adaptdl/adaptdl/reducer.py
90.00% <0.00%> (+2.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dce9b4...f7f9f0a. Read the comment docs.


closePreviewMouse Leave does not work

I have enabled this setting but it does not work, I have to close the Preview manually.
I am on macOS 13.6 Ventura, Logseq 0.9.20.

When the cursor is a ➖ mark, if move it outside the preview window, the window will disappear. There wasn't enough explanation.

My cursor is never like that, it is always like this:


Upgrade to Ember v4.12

Basically, this PR will,

[x] Handle this lookup fallback (Basically #209 )
[x] Upgrade dependencies and devDependencies to support v4.x
[x] Update ember-try targets to currently supported LTS (and additionally 3.28.x)
[x] Update supported node version to 12 and above.

You should be able to add a file to change the node version on netlify see https://docs.netlify.com/configure-builds/manage-dependencies/#node-js-and-javascript


Add "minimum supported axoupdater version" checks

While many installer changes can be done in a forward/backward-compatible way with axoupdater, some changes, like #1355, strictly require the installed version of axoupdater to be new enough to be aware of the new behaviour. As such they are dangerous to land without some way to tell cargo-dist users "hey you must update axoupdater".
Given we already use guppy/cargo-metadata, we have dependency info at our fingertips and can in fact complain that you're using an older version of axoupdater.
So this feature amounts to:

add some constant in cargo-dist that records the minimum supported axoupdater version
for each distable package, if we see it depends on axoupdater as a library, complain if the axoupdater version is < the constant

We don't currently process dependency information so someone will need to write that logic. I'm reasonably familiar with the relevant APIs.

Note that we'll need to remove this line to actually calculate the deps: https://github.com/axodotdev/cargo-dist/blob/9415ad8c44d5859ec515746fea63371f4432a150/axoproject/src/rust.rs#L56


Lstm

Please consider to merge the master again (if you did already). I fixed the C++-style comments.

OK, thanks.
On Tue 28 Aug, 2018, 6:00 PM Hans Pabst<EMAIL_ADDRESS>wrote:

Please consider to merge the master again (if you did already). I fixed
the C++-style comments.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hfp/libxsmm/pull/244#issuecomment-416565684, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC-d3uaBMXSzg0H726Y8JpAnMOXtqQJsks5uVTfHgaJpZM4WPZyS
.


Scoping target network functionality within AOTF

We have started brainstorming on how we could enable access to target networks info within AOTF.
This ticket will record the final scoping and tasks (not for 23.09).
Options were discussed:

[ ] new column in AOTF with molecular interactions (drawer opens with molecular interactions tabs for each target)
[ ] building functionality to expand the associations table down with top interactions when a box "show interactions" is ticked
[ ] Other

Discussed preliminary requirements for:
Build a UI feature to display interactors of disease-associated targets in AotF

Data: Target/Sections/Molecular interactions widgets
Use all data sources (IntAct, Signor, Reactome, String)
Interaction Score cut-off (minimum score) eg 0.7

AotF view
Show a button on each target row as “Show Interactors” (icon)
Visual element containing networks sub-view (modal/drawer)
AotF loaded with the target interactors
Order by Association score
Display interaction Score
Able to export/download (default, no custom)

4/12/23: we have carried on with the discussion on how to visualise target networks in Associations on the Fly.
Please see this document for specific requirements covered so far.

Moving to done since UI development will be done under this issue https://github.com/opentargets/issues/issues/3406


Rake dependency

At this moment the latest version of rake is 13.0.1 but current dependency is still linked with 12.x.
Could it be increased to i.e. < 14 for runtime dependency?

The commit closing this issue misses the development dependency: https://github.com/jondot/sneakers/commit/415f283f7e634601528105323d0dac9663c5786d
gem.add_development_dependency 'rake', '~> 12.3'
why is it a development and runtime dependency?

@michaelklishin we recently installed sneakers but 2.11.0 where this wasn't a requirement, now with 2.12.0 our rake dependency was downgraded. There hasn't been a release in many years. Further there seems to be some commits for Ruby 3+ support since then. Any chance all that could get released?

@javierjulio as I have explained in another issue, I do not have the permissions to produce releases, neither on GitHub nor on RubyGems.

@michaelklishin ah sorry about that. I hadn't seen it. Thank you for letting me know!

I will try to find a way to reach @jondot in hope that I'd be given the permissions to produce releases. I'm a RabbitMQ core team member and quite used to helping maintain RabbitMQ-related projects.

@michaelklishin thanks! Yes, I know you are which is I reached. Also due to your merges in this repo. We've been using RabbitMQ (Bunny) for the past year and are testing sneakers just recently for a possible use case. Thank you for your help and contributions! I was concerned about using sneakers due to the many years without releases, also primarily because we upgraded to Ruby 3.0 recently and saw that those changes don't appear to be in a public release.


Visual expression of the relationship between master and origin/master

In the image https://coderefinery.org/git-collaborative/centralized/#id3, the interpretation of the arrow between master and origin/master is unclear or undetermined. Is a pointer to a pointer, for example?
Possibly master and origin/master could point to c1 side-to-side, like in    https://coderefinery.org/git-collaborative/centralized/#id5 of §5.
The same uncertainty interpreting similar arrows arises in step D regarding the forked workflow: https://coderefinery.org/git-collaborative/distributed/#id13

Good point. This can be clarified. I am working on it.


[Question]How do I modify these two (or more) as a whole?

Here's a snippet of code I found
if (pos.getY() >= world.getSeaLevel()) {
            // .........
        }

How do I use @ModifyExpressionValue to make it look like this
if (myboolean() && (pos.getY() >= world.getSeaLevel()) ) {
            // .........
        }

ModifyExpressionValue the getSeaLevel call, and if you want to force the comparison to false then return Integer.MAX_VALUE

thank

Although you could also use Float.NaN

Although you could also use Float.NaN

That is not the case. NaN cannot be represented as an integer and ModifyExpressionValue does not allow changing the datatype of a value (as instructions after the expression expect the datatype to be an integer still).

Although you could also use Float.NaN

That is not the case. NaN cannot be represented as an integer and ModifyExpressionValue does not allow changing the datatype of a value (as instructions after the expression expect the datatype to be an integer still).

I just checked and you are right both are values of type int, I assumed that the "getY()" method was of type float or double

Note that once MixinExtras gets its expression injection point, you will be able to simply target the whole expression directly, which should make situations like this easier


I have successfully removed the contact us form from blog section

Related Issue

Mention issue for which this pull request is a part of (please mention issue number # )
Removing the contact us  section from  blog (issue number #76 )

Proposed Changes

Changed App.js route section
Tried to change Ui a little.

Additional Info

Any additional information or context
No

Checklist

[x] ✅ My code follows the code style of this project.
[ ] 📝 My change requires a change to the documentation.
[ ] 🎀 I have updated the documentation accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] 🌟 ed the repo

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

     My code just adds the contact us form in all the section except the blog.

     The issue is #76

     Nothing much detail it is a simple change that was required for, removing the contact us section. Added the Tag <ContactSection> in eact element in route except the blog.

     Since it is a blog it will not require the contact us section.

     It doe not affect anything in other section of code.

Output Screenshots

Hello @mohityadav0903 , I have removed the contact us  section as per instructed, sorry for the delay, learned some new stuff, I enjoyed. please close the issue and merge the PR.
Thanks.


QUESTION: How to use both gptq and vllm in qwen-14b model?

The vllm version already supports gptq quantization of qwen 14b-4bit (in the quantization branch), so how do I use them in xinference?

We need to test it, some adaptation work may be required.

It seems vllm's support for gptq is in progress(https://github.com/vllm-project/vllm/pull/1580), how did you use vllm with GPTQ

@aresnow1  The branch code of vllm can be found at https://github.com/chu-tianxiang/vllm-gptq/. It is a branch from vllm. All questions can be asked on the main branch of vllm, so it is the correct official one. The code, but due to many conflicts in the code, was not merged into the main branch. After testing, its code is usable.

It needs some changes to support passing quantization method, I'll create a PR to support this later.


Configurable number of retries for batch operations

Allow for setting the number of retries to be performed for batch operations

LGTM


Update repository topics

Your repository is listed on the Taskwarrior tools list, thanks for contributing! :heart:
We want to inform you about some changes to the crawler script collecting the tool information from GitHub:
Your tool is listed because it has the keyword taskwarrior among its topics.
With the release of Taskwarrior 3 and its changes to task synchronization, we want to improve the tool listings by showing whether it is intended for Taskwarrior 2, Taskwarrior 3, and/or Taskserver.
Your tools with topic taskwarrior will be listed on the tools page as intended for both, Taskwarrior 2 and Taskwarrior 3.
If this is correct, then there is nothing else to do – just close the issue. :slightly_smiling_face:
However, if your tool is only working with Taskwarrior 2, we would ask you to update your topic to taskwarrior2 instead.
For further questions and details, you can go to this GitHub discussion.
Thank you very much for your support!

OK, since the changes are only in the synchronization part of TW, the hooks in this repo should still be applicable to both TW2 and TW3


Introduction for MOFH support

This is introduction for MyOwnFreeHosting (MOFH) API support with MOFH Client (https://github.com/InfinityFreeHosting/mofh-client). This alpha release, my PHP is not good.

https://github.com/sdorpl/hopebilling

https://github.com/sdorpl/hopebilling


Make TESTS= work with "nmake -f ms/ntdll.mak tests"

This works on Linux with Make already, and allows running only specified tests.

+1

+1

Thanks @benlaurie.  Merging it in.

Aaaand merged.


dep init: panic: runtime error: slice bounds out of range

checkout github.com/kubernetes/kubernetes @ db2dc78e6398ba673e68e94bd17d28a97dd4a902
run godep restore to make GOPATH == what's in vendor
inside kubernetes rm -rf vendor Godeps
inside $GOPATH/src/github.com/chai2010/gettext-go make sure that https://github.com/chai2010/gettext-go/pull/7 has been applied
dep init from version 21f357a
$ dep init
panic: runtime error: slice bounds out of range

goroutine 1 [running]:
panic(0x7a3fc0, 0xc420012120)
	/usr/local/go/src/runtime/panic.go:500 +0x1a1
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).unselectLast(0xc420ac4a50, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/storage/gopath/src/github.com/golang/dep/vendor/github.com/sdboyer/gps/solver.go:1130 +0x68e
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).backtrack(0xc420ac4a50, 0xc4204ab2a0)
	/storage/gopath/src/github.com/golang/dep/vendor/github.com/sdboyer/gps/solver.go:881 +0x13e
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).solve(0xc420ac4a50, 0x0, 0x0, 0xc421378ff0)
	/storage/gopath/src/github.com/golang/dep/vendor/github.com/sdboyer/gps/solver.go:371 +0x791
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).Solve(0xc420ac4a50, 0x25, 0xc4200100a8, 0x11, 0xc420154ff0)
	/storage/gopath/src/github.com/golang/dep/vendor/github.com/sdboyer/gps/solver.go:317 +0x8e
main.(*initCommand).Run(0x9f41c8, 0xc42000c380, 0x0, 0x0, 0x0, 0x0)
	/storage/gopath/src/github.com/golang/dep/init.go:153 +0x102f
main.main()
	/storage/gopath/src/github.com/golang/dep/main.go:101 +0x68b

iiiiinteresting.
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).unselectLast(0xc420ac4a50, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)

This means an internal bookkeeping bug in the solver. ...except that there doesn't appear to be a slice access on that line.

Almost certain that
https://github.com/golang/dep/blob/master/vendor/github.com/sdboyer/gps/selection.go#L58
was inlined into unselectLast.
On Fri, Jan 27, 2017 at 4:24 PM, sam boyer<EMAIL_ADDRESS>wrote:

iiiiinteresting.
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).unselectLast(0xc420ac4a50, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
This means an internal bookkeeping bug in the solver. ...except that there
doesn't appear to be a slice access on that line.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/dep/issues/171#issuecomment-275591649, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA9v5MvZsj5oU2_eHeo01DIpRqZgCks5rWX-FgaJpZM4Lu9I_
.

derp. totally. thanks :)

roll on the dev.inline branch, which will solve this (we all hope)
On Fri, Jan 27, 2017 at 4:38 PM, sam boyer<EMAIL_ADDRESS>wrote:

derp. totally. thanks :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/golang/dep/issues/171#issuecomment-275592973, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA361xh7inogKxXz5wJ49DGS2-G4iks5rWYLBgaJpZM4Lu9I_
.

I put some printf's to dig around a bit. In fact it is popDep not pushDep that was panicing.
 func (s *selection) popDep(id ProjectIdentifier) (dep dependency) {
-       deps := s.deps[id.ProjectRoot]
+       deps, ok := s.deps[id.ProjectRoot]
+       if !ok {
+               fmt.Printf("unable to find s.deps[%v]\n", id)
+               return dependency{}
+       }

Gave me:
unable to find s.deps[{k8s.io/kubernetes }]

That also makes more sense than a slice bounds error on an append :) Doesn't change anything about the inlining observation, of course.
I'm pretty sure I see the problem here. likely related to the fix for #116, which allowed project-level cyclic dependencies involving the root project. I'm pretty sure I didn't encounter this because the additional test case I wrote didn't cause the solver to backtrack through such cycles.
k8s @ db2dc78e6398ba673e68e94bd17d28a97dd4a902 does have such a project-level cycle, right? (a k8s package imports a package from a dep, which itself transitively imports some package back in k8s)
If so, this is a relief, because it points away from a "bookkeeping bug" in normal operation of the solving algorithm. That would be a much more concerning correctness issue. Instead, I think the cause here is a basic choice to push the root project into the selected list, but not the deps map, when preparing the algorithm. That's a more basic structural question with an easier fix.

This should now be fixed upstream - we'll get it in to dep with the next gps update.


delete this repo?

elegantobjects.org is wrong actually. It only talks about "design principles" but that's not what this is really about. This is more like a set of principles...
Support principles, design principles, license principles, "asking questions" principles, "bugs" principles, contribution principles. We need something like: elegantsoftware.org
As a consumer, I don't want to manually search through millions of repositories, trying to find good quality projects. I just want projects that use the "elegant standard" which is all these principles...
As a producer, I don't want to wing it, I wanna know and be guided on the best principles so that I can just focus on code and not worry about all that other stuff and if I'm doing it properly or not

@yegor256/z please, pay attention to this issue

@ashtonhogan elegant objects is only about object-oriented programming. What you are talking about has nothing to do with OOP. You should check XDSD.org or Zerocracy.com, they are about management.


Add egress rules to istioctl

Add egress-rule to istioctl, without taking egress-rules into effect yet. Part of https://github.com/istio/istio/issues/496
Format:
type: egress-rule
spec:
    name: cnn
    domain:  "*cnn.com"
    ports:
      - port: 80
         protocol: http
      - port: 8080
         protocol: http
   use_egress_proxy: true

I see commits but no PR ?

I am still working on it. Please note my convention - I add a string istio/istio#<issue number> to every commit, so every commit is linked to the issue even before a PR is submitted, and if not squashed, continues to point to an issue. So every commit always points to some issue - either not squashed, or squashed as part of a PR, in the PR's comment.

Thanks for the explanation - I think that may be a bit floody/verbose but it's ok if it's your strong preference (and for an issue where only you is subscribed )

@ldemailly It is not my strong preference, so if this practice is discouraged by the Istio developers community, I am OK to stop using it.
Please note that with an issue you create it first and then start working on it. With a PR, you start working and then submit it after the work is done. So with an issue, you announce to others that there is an issue, you work on it, some details on the issue, references to design doc etc. The others can see it and your work in progress and comment before you compete your work. Somebody can comment that this work is not needed or covered by some other issue, etc. And you can create a hierarchy of issues - epics, set milestones, again - before you complete the work.

I actually like this, I was not aware this is possible.

It is not discouraged, we just did not encounter it in Istio. I agree with Laurent that it gets a bit verbose, but it is nice to know there is progress made on it.

I think having the issue first is great (and everybody should do that), and saying you're working on it when you start (too), but I don't think there should be a bunch of invisible commits/updates - do your PR when it starts being in shape (possibly marking it as "wip"/not requesting a review yet) and update that rather than the issue ?

This will be better indeed, as long as the PR links to the issue, and we can easily track if the issue is worked on.

@ldemailly @andraxylia OK, I see, next time I will do it with a WIP PR, linked to the issue. Thank you!

solved..


feat(improvements): improve features

:tada: This PR is included in version 1.2.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Tabs don't reflow well with small widths

In this case there is actually space to fit in "Transactions", but it's reluctant too. Maybe too much padding around the gist controls?

For the record, the layout's also a bit funny if you're logged in:

This is really a question of mobile support. It was looking a lot worse on tablet/mobile-sized displays, because we're not supporting them. But I put in some quick changes just before the summit so it looked okay.
Which is to say, yes, there more work to do here and I'll improve this, but maybe now's a good time to check how much effort we want to put into smaller display support?

In this case it was actually because I was zooming in to make it visible for presentations, but I guess it's the same for mobile layouts.

Maybe that's reason enough for us to say we actively support tablet(-sized-screen)s.


Please add Texas

We are currently handling a lot of requests - please include the following information with your request:

A subject message for the email
A list of emails (at least one) for the government officials you’d like to receive the message
A detailed message concerning the budgeting decisions that are at stake in your community

See our current links for examples at https://defund12.org.
Thank you!!

Hey, can you please provide these items from the template? Thanks!

I'll handle Texas cities as they come through as well. You can assign this one to me as well.

Unfortunately this request does not meet our base criteria so we will have to close it. Please submit a new request with the following information and we will process it:

A subject message for the email
A list of emails (at least one) for the government officials you’d like to receive the message
A detailed message concerning the budgeting decisions that are at stake in your community
See our current links for examples at https://defund12.org.

Thank you!!


Git status plugin

Add some enhancements to Git Status. It's structure fairly well I think so further enhancements should be pretty easy hopefully.


Relative paths

Hi,
Do relative paths work with sources other than storage accounts? I'm working with a customer and they're using a template where the customer used to store a CSE script in a storage account (container/scripts/script.ps1) and then used commandToExecute pointed at the relative path of the script (scripts/script.ps1) - this worked correctly. You can see in the logs that it downloads correctly to the relative path:
'DownloadFiles: asynchronously downloading file to fileDownloadLocation = Downloads\0\scripts/script.ps1'
However, their template changed and now their CSE script is located in an Azure CDN (azureedge.net). Now they try to use the same commandToExecute pointed at the relative path of the script (scripts/script.ps1), but it doesn't work. You can see in the logs that it downloads to the 'root' download directory instead of the relative path:
'DownloadFileAsync: Downloading file to fileDownloadLocation = Downloads\0\script.ps1'
Do relative paths work with Azure CDN (azureedge.net) or do they only work with Azure storage accounts?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 40aaccb8-19ba-168f-f5bf-65f1f5331541
Version Independent ID: 6cdfd166-633a-50a3-2b45-cde0e991e540
Content: Azure Custom Script Extension for Windows
Content Source: articles/virtual-machines/extensions/custom-script-windows.md
Service: virtual-machines-windows
GitHub Login: @bobbytreed
Microsoft Alias: robreed

@kegregoi This will no work with CDN. In the doc we state

Scripts can be downloaded from Azure storage or GitHub, or provided to the Azure portal at extension run time

So pulling it from a CDN endpoint will no work. The user will need to store the file in an Azure Storage Account or a GitHub account.

Hi @MicahMcKittrick-MSFT thanks for the quick response. It looks like the script is downloading though. Just not to the relative path. Specifically, are relative paths not supported from CDN?

With my knowledge of CDN, I don't believe relative paths are supported. However, I don't work directly with CDN. For CDN specific questions I would suggest you reach out to our engineering team on MSDN
https://social.msdn.microsoft.com/Forums/en-US/home?forum=azurecdn
Also, doing some research offline, it seems a user asked a similar question on Stack Overflow
https://stackoverflow.com/questions/36628004/how-do-i-set-origin-path-in-azure-cdn-using-resouce-manager-api
You might find that useful as well. So it might be possible but im guessing the reason we don't suggest it is it would require additional configuration on the CDN part to download files


Mainnet restore bench running out of disk space

Context

https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/674#c1933993-5335-4d21-82c6-782cc64f5d92
Test Case

mainnet restore bench
Failure / Counter-example

In logs
ApiMisuse (ClosedDBError (Just (FsError {fsErrorType = FsDeviceFull, fsErrorPath = /tmp/cw-node-c0e02cc881daa38b/db/volatile/blocks-2607.dat, fsErrorString = "No space left on device", fsErrorNo = Just (Errno 28), fsErrorStack = CallStack (from HasCallStack):

Resolution

QA

Interesting. That machine has 175G free on /.
From that error message, it says that the node data is being stored in /tmp. Has that changed recently?
/tmp is a ramfs on this buildkite container (it often is for many distros), so probably doesn't have much space.
So we need to change the storage path or set the TMPDIR environment variable to somewhere that's not a ramdisk.

https://github.com/input-output-hk/cardano-wallet/blob/7b19a2f0f10dff07be66327108ed239214c7917a/.buildkite/bench-restore.sh#L17 @rvl shouldn't this have a export somehow?
It seems that the haskell bench sees the env var as unset.
https://github.com/input-output-hk/cardano-wallet/blob/7b19a2f0f10dff07be66327108ed239214c7917a/lib/core-integration/src/Cardano/Wallet/BenchShared.hs#L136-L140
But also, shouldn't the socket file and node dir exist in /tmp, but the db in /cache, since we previously had problems with the socket file not being cleaned up?

(Tried this in https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/677#c008f406-d0da-44b1-a977-0df56e35c485 )

Didn't seem to work (this should be the non-trivial failure: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/678#e7e62ef1-e56d-4b47-a784-6272fd859680)
🤷♂

Old ticket, must have been solved some time.


Allow user to supply a config file as an alternative to environment variables

The specific case I am thinking of is in cbook.py, where the script searches for the environment variable TEST_DATA_DIR or a folder relative to the script location to find the location of the given filename.
Some users may have limited administrator rights and could potentially be prevented from modifying or creating environment variables like TEST_DATA_DIR that point to their data.
Is there any way to include the option to read from a config file (or similar)? This file could be the home for other user configuration options as well.  Examples of this sort of thing probably exist, but I'm not entirely sure of the best practice for this situation.

Well, we'd have to set of some sort standard location across all 3 platforms, sort of like USERHOME/.config or something. I'd probably knock off what the Jupyter guys do.
Taking a step back, though, are you saying you can't do:
TEST_DATA_DIR="/path/to/data" python myexample.py

?

Ahh good point on the command line.  I was running an example in a notebook on Windows when I had this idea.  I think you can do something similar like:
> TEST_DATA_DIR="/path/to/data" jupyter notebook
This issue can probably be closed.

To confirm on Windows
> SET TEST_DATA_DIR=C:/path/to/test/data
> jupyter notebook

Works as expected.

Ok, we'll close for now. We can revisit if we find that we need a config file, but I'd rather not bite off that can of worms unless we need to.


Configuration: Check-in localisation sheet into dristi-solutions repo

Describe the bug

Check-in the localisation sheet into the dristi-solutions repository under a "localisation" folder.
I've created a "Recommended format" sheet in this localisation doc. There can be more columns but as long as these same column names are adhered to, we can write scripts to read from the localisation sheet and push into the DB for any new language.
Script to automate localisation to be checked into the utilities folder of the repository. Script to push localisation should do the following:

Accept username/password for the Localisation Admin user (with the LOC_ADMIN role), hostname and path to Excel sheet.
Log into the server with the given user
Read specific sheets (either all sheets or from a list that's input) from the Excel, compose the JSON payload and push it into the DB.

CC: @atulgupta2024 @Taherabharmal @suresh12 @devarajd94
Additional context
Once installation is completed, localisation will become a one click script execution activity.

@anirudh-0 I've updated the localisation format as agreed upon in the call. This should be a simple check-in to the repo and we can close out this showstopper. Please let me know if you need help with this. We should also socialize to the collective to always pull the sheet from here and then update.

@TusharKatiyar2002 Can you please check in the localisation sheet into the configs repo inside the configs folder.

Hi @subhashini-egov, I have checked in localization sheets and script

Hi @subhashini-egov  @atulgupta2024  Can you please review and close this ticket

@Ramu-kandimalla @TusharKatiyar2002 can you share the path of where to find the localization sheet?

Localization script: https://github.com/pucardotorg/dristi-solutions/tree/main/utilities/localization-scripts
Localization sheets: https://github.com/pucardotorg/kerala-configs/tree/develop/localization
@atulgupta2024

Hi @atulgupta2024  is this can be closed can you please confirm

@Ramu-kandimalla @TusharKatiyar2002 reviewing. Will revert before EOD today

All sheets should follow a simple template - Code | English | Malayalam | followed by any additional columns as required. the first three are where the main content for location is and rest of the columns are not required to be loaded in TABLEs in the system.
Localization data

Need to ensure data is placed in the right sheet - service/functionality specific data in one sheet
What is the data in "Sheet1". Give it a better name, or delete if not required
Is the sheet "Judge feedback localization" required? keep it separate from the deployment data.
Column title to be based on locale. So English is "en_IN" and Malayalam is "ml_IN" (across sheets)
The code "REG_SIGNIN_PROVIDE_MOBILE_NUMBER" has text "Sign in to your account". This has no mention of mobile number. The code ideally should be "REG_SIGNIN"
orders sheet should contain items related to orders only with ORDER prefix. DOCUMENT_TYPE or DOCUMENT_NAME OR or COMMENTS etc are generic items and should be in common sheet.
Orders sheet, third column has numeric values. No column title. What are these values for? Remove if not required
common sheet, missing titles for first two columns
Common sheet. Can we do a "find-replaceall" for "CORE_COMMON_" prefix to "COMMON_". "CORE" seems unnecessary add to the prefix.
Case sheet. Codes don't have "CASE" prefix. Data across sheets needs to be consistently named. Column titles missing.
Why do we have a 'join' sheet and a 'copy of join' sheet
Advocate sheet - no localization data. Why is this sheet present?
"New" Sheet - what does this mean? Give it a proper name. Seems to have a mix of codes from services
Summary sheet seems to be some statistics. Name it appropriately and ideally should in the localization data sheet. Should be kept separate
There many sheets "detailXX-XYZ-unclear". Remove all unwanted sheets

Localization Script
It is not clear from the script, how the various sheets from the XLS are being loaded or is the location data first saved in another intermediate sheet before loading?


[2.4] New Race Item and migration for Player characters

I would suggest a migration script to at least add the current data held in actor.system.details.race to a newly created Race Item actor.system.details.type.custom.
If that is not preferable, at least when adding a New Race Item to already created player actors, do not default the field's type.value to New Race as the user will inevitably lose whatever was in that field.

Sounds logical to take the old "custom" field in the sheet and move it to a new race item's type.custom value, but only when created through the sheet, not if one drops an existing Race item onto the sheet.

Not sure about what's the best solution here, but as it is, I think it will lead to some unneeded grief... 🤷
Especially since an older player's actor will have the Creature Type populated as Humanoid without the config cog to change it, if no Race Item is added

I would suggest a migration script to at least add the current data held in actor.system.details.race to a newly created Race Item actor.system.details.type.custom.

The current value is not lost when loading into 2.4 for the first time, so there is no need for a migration. Users can opt-into the new race item at their convenience, and can continue to use the plain text field otherwise. This is consistent with how we handled backgrounds.

If that is not preferable, at least when adding a New Race Item to already created player actors, do not default the field's type.value to New Race as the user will inevitably lose whatever was in that field.

Presumably they can remember their character's race and adjust the name of the newly-created race item accordingly. I do not think this is too much to ask.

Especially since an older player's actor will have the Creature Type populated as Humanoid without the config cog to change it, if no Race Item is added

Characters did not have a creature type on their sheet previously so there is nothing lost here. Humanoid is a sensible default for the vast majority of player characters and races available in the game. Only very few races have non-humanoid creature types.

Sounds logical to take the old "custom" field in the sheet and move it to a new race item's type.custom value, but only when created through the sheet, not if one drops an existing Race item onto the sheet.

I think it would make a little more sense to put the old "custom" field as the new Race Item's name, if creating the Race on the sheet. It would be a minor thing for some users, but I think would be a better experience overall.

I remember asking for the same thing when Backgrounds were introduced and it wasn't done. If it was, could have avoid having the background on the sheet being either a text box you can type in or just showing the background item's name. Always thought it was odd there was still a legacy background String field with the new Background item


[BUG] Security vulnerability on minimist 1.2.5 which is dependent on exceljs/4.3.0

🐛 Bug Report

Lib version: minimist 1.2.5
Steps To Reproduce
minimist 1.2.5 is transitive dependent on excel js 4.3.0.
excel js 4.3.0 is on the latest version and hence we are unable to resolve the security vulnerability on minimist 1.2.5 even though minimist 1.2.6 is available with no vulnerabilities in the blackduck.
The expected behaviour:
minimist which is dependent on excel js should not have any security vulnerabilities.
Possible solution (optional, but very helpful):

It looks like this project isn't getting updates. You can fix this vulnerability by adding this line to the resolutions object in packages.json:
    "exceljs/unzipper/fstream/mkdirp/minimist": "^1.2.6"

This will force exceljs to use the updated minimist version.