$http .success/.error return original promise, dissimilar from how .then works. Clarify in docs?

Hello. $http returns a normal promise for a server response object (with data, status, headers etc.). As a normal promise, returning values from a handler in .then results in a new exported promise for the value (or assimilation, if the return value is a promise, or rejection in case of error, etc.). That is all well and good.
For convenience/abstraction, AngularJS provides two custom methods on promises returned by $http: .success and .error. Each takes a single handler with the data, status etc. as parameters.
The problem is that people familiar with promises will likely try to chain off of .success, perhaps by transforming and returning new values or new promises. However, .success does not return a new promise; rather, it returns the original promise:
angular.module('promisesApp')
  .controller('MainCtrl', function ($http, $log) {

    $http.get('/api/things')
      .success(function (data) {
        $log.debug('in success:', data); // these are the things from the API
        return 'a new value';
      })
      .then(function (data) {
        $log.debug('in chained .then:', data);
        // data is the original server response object, NOT 'a new value'
        // data.data are the things from the API
      });

  });

If you were trying to make .success chainable in the same way .then is, it would be easy to change in the AngularJS source, and indeed I had started work on a pull request:
// in theory, could change this:
promise.success = function(fn) {
  promise.then(function(response) {
    fn(response.data, response.status, response.headers, config);
  });
  return promise;
};
// to this:
promise.success = function(fn) {
  return promise.then(function(response) {
    return fn(response.data, response.status, response.headers, config);
  });
};

However, I then realized that this would mean you could not attach both .success and .error to a single promise. The reason you can write this code:
$http.get('api/things')
  .success( successHandler )
  .error( errorHandler )

…is because .success and .error return the original promise, not a new promise representing the result of the previous method.
This leaves me in a bit of a quandary. The recommendation must therefore be that .success and .error are only suitable as "end of the road" promise consumers, when you do not intend to do any more post-processing / chaining. If that is the case, I think the AngularJS docs should reflect this, and make it explicitly clear that chaining off of .success/.error does not work in the normal promises fashion, since the original promise is returned.
What do you think?

Impressive!

@glebec Long time ago, I'm confused with success invocation too. It breaks the specification promise must be resolved exactly once.


Return value section says "none" when the macro actually returns BOOL

[Enter feedback here]
Return value section says "none" when the macro actually returns BOOL. While the Remarks section describes the return value, it would be better if the Return value section is updated appropriately.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d66bcef4-c694-d12e-b535-90f2aec47748
Version Independent ID: 3e6a4e85-ee54-baa4-fd08-7b04fe0bb6e2
Content: RtlEqualMemory macro (wdm.h) - Windows drivers
Content Source: wdk-ddi-src/content/wdm/nf-wdm-rtlequalmemory.md
Product: windows-hardware
Technology: wdk-api-reference
GitHub Login: @barrygolden
Microsoft Alias: bagold

Good find @hwisungi thanks for letting us know.
Due to the constraints of our publishing system, the best we can do in this case is to remove the Returns section entirely from the page in question.  I have done this -- see https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/wdm/nf-wdm-rtlequalmemory.
Thanks again for caring about the docs :)


Protection for create/PUT with persistent volumes and for user-specified residency/upgradeOptions

I encountered an issue in DCOS 1.8.1/Marathon 1.3.0-RC4 where apps with persistent volumes could not be created via
PUT /v2/apps/:appId
but they could be created via
POST /v2/apps
In debugging the issue, I tracked it down to .container attributes not being persisted on AppUpdate.empty, resulting in an intermediate AppDefinition for creation that wouldn't pass validation.
Similarly, payload .residency or .upgradeStrategy were not persisted, so that user-specific entries were overwritten by defaults on a Create via PUT.
After creating documenting/protecting tests and resolving the issues, I discovered that the container issue was handled in #4185 (since merged and released in 1.3.0-RC5/DCOS 1.8.2, thanks much!), though .upgradeStrategy and .residency are still not addressed.
This PR contains tests to help protect the behavior in the future and to persist .residency and .upgradeStrategy.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

@cgbaker thanks for this fix! looks good. Please rebase in order to merge.

should this be part of the 1.3 milestone?

rebased

retest this please

@cgbaker  Could you rebase on the latest master please? There's been a good amount of changes (particularly in linting).

rebased

merged into 1.3 as well (as it is a bug fix - will be in a future 1.3.1 should we release an update)


Spam

Marketplace

Tested on xenia-canary/xenia-canary@0000000
Issues:
(state of the game)
Log:
Compress your logfile into a compressed folder named xenia.zip and then click and drag it here (replacing this text).
Screenshot(s):
![](Screenshot URL)
Labels:
(recommended labels)

I'd like to open this with spam issue, it won't be the only one knowing users who refuse to read the rules. enjoy spam

test

test ?

Best compatibility thread should add playable to this one

I will test this game eventually

Looks like we got our first spam: #33

Yay! Also this game has regressed into menus. I tested this game #1

due to the latest batch of commits, it goes in-game with some severe graphics issues.


Get-DbaServerInstallDate | ogv - attempting to sort SqlInstallDate or WindowsInstallDate columns via header click closes grid view

Bug Report

General Troubleshooting steps

[x] Verified running the latest release of dbatools? (0.9.325)
[x] Verified errors are not related to permissions?
[x] Can duplicate in new/clean PowerShell session (clean = powershell -NoProfile)?

Version Information

Operating System (Name|Version): Windows Server 2012 R2 Standard
PowerShell Version: 5.1.14409.1005
SQL Server (Edition|Version): Enterprise 2005-2017

Steps to Reproduce

Call Get-DbaServerInstallDate, pass in the names of at least two servers, and output to grid:
'SqlInstance1','SqlInstance2' | Get-DbaServerInstallDate | ogv
or
'SqlInstance1','SqlInstance2' | Get-DbaServerInstallDate -IncludeWindows | ogv
or
Get-DbaServerInstallDate -SqlInstance SqlInstance1, SqlInstance2 | ogv
or
Get-DbaServerInstallDate -SqlInstance SqlInstance1, SqlInstance2 -IncludeWindows | ogv
or
$MySqlInstanceList | Get-DbaServerInstallDate | ogv
or
$MySqlInstanceList | Get-DbaServerInstallDate -IncludeWindows | ogv

In the resulting grid, click the header for the SqlInstallDate (or WindowsInstallDate, if requested) column.

The grid will immediately close rather than sorting the content by that column.

[ ] Attach any screenshots (if possible/allowed)
[ ] Attach logs generated by dbatools (Get-DbatoolsLog)
[ ] Attach output from PowerShell console (if possible/allowed)

Feature Request

When Get-DbaServerInstallDate results are output to grid view, allow results to be sorted by SqlInstallDate or WindowsInstallDate columns by clicking the header for either column in the grid, rather than immediately closing grid view.
Problem to solve
See "Feature Request".
Additional information

Now realizing this may not be an issue with this function, but perhaps a general PowerShell issue?  Seeing similar behavior with other functions like "Get-DbaUptime".

This is a PowerShell + Out-GridView issue that multiple commands have the problem...it is unknown to the main contributors right now what is causing it. It is not believed to be something we can fix with the module itself.


Fix next in users followers

I ran into a problem with Next function on followers endpoint. When next_max_id isn't present we don't attach user results.

Thanks for the PR!


Fix styles lost when hosting application set to ViewEncapsulation.None

In our application we default the view encapsulation to none to be able to more easily support customer skins in CSS.
platformBrowserDynamic().bootstrapModule(AppModule, [
  {
      defaultEncapsulation: ViewEncapsulation.None
  }
])

This causes angular-split to loose it's style.
The included fix overrides any inherited view encapsulation at the component level.
    encapsulation: ViewEncapsulation.Emulated

It looks like the build from master is currently failing.
  1) Gutter click example page tests Mix gutter click and dragging:      CypressError: Timed out retrying: Expected to find element: '.transitionEnd', but never found it. Queried from element: [ <li.dragStart>, 3 more... ]

@bertrandg would it help if I fix the master build?

Yes it would help! I didn't investigate but last time npm run cypress_prod succeded but cypress_ci seems not..

Hi @greggbjensen , thanks for your contribution. It has been merged through #244!


resolved issue #273

Awesome @nkalichynskyi, thanks so much! :fire: :fire:
I haven't tried it, is the styling/UX still the exact same?

@mxstbr I know this component by heart. Just styling changes. Good job @nkalichynskyi 🙌🎉


Fix a link in 'Building Java Modules with Blackbox Tests' sample

Fixes https://github.com/gradle/gradle/issues/23614

@bot-gradle test BD

I've triggered the following builds for you:

BuildDistributions build

I've triggered a build for you.


Port to GTK3 and Python 3

I cloned https://github.com/sugarlabs/turtleart-activity/ to local and cherry-picked those three commits:
fbc466be30368b8e2ebd15445a5a5612acfcf231
8fbb3c7b686d607e441fb1084fe96f0a3209168d
acfeb4b519b796f51cb8986ae76bcd92217780b1

from the mexico branch (https://github.com/sugarlabs/turtleart-activity/tree/mexico) and resolved a few merge conflicts, then I ran ./pygi-convert.sh in the directory.
And finally, I pushed to the fork of TortugadeMexico.

Thanks, I will review what you did tomorrow, my time.

@Kiy4h, you have committed turtleblocks.py. turtleblocks.py, turtleblocks and turtleblocks.desktop are currently not working and hadn't been ported to Python3 because of telepathy deprecation. To compat this all references of telepathy had to be refactored to TelepathyGLib as mentioned in the Python 3 Porting Guide. Some files have not been ported to TelepathyGLib. This includes the files in TurtleArt/ta*.py. There are 17 instances of telepathy in this port.
Tested logs contain Errors:

(sugar-activity3:14622): Gtk-WARNING **: 18:14:17.513: Theme parsing error: gtk-widgets.css:16:32: The style property GtkExpander:expander-size is deprecated and shouldn't be used anymore. It will be removed in a future version

(sugar-activity3:14622): Gtk-WARNING **: 18:14:17.514: Theme parsing error: gtk-widgets.css:17:35: The style property GtkExpander:expander-spacing is deprecated and shouldn't be used anymore. It will be removed in a future version
1576682058.647784 WARNING root: No icon with the name save-macro was found in the theme.
1576682058.649044 WARNING root: No icon with the name save-macro was found in the theme.
reskin already in palette extras, skipping...
Traceback (most recent call last):
  File "/home/srevinsaju/Totru/TortugadeMexico/TurtleArtActivity.py", line 547, in do_eraser_cb
    self.restore_challenge()
  File "/home/srevinsaju/Totru/TortugadeMexico/TurtleArtActivity.py", line 553, in restore_challenge
    self._load_level()
  File "/home/srevinsaju/Totru/TortugadeMexico/TurtleArtActivity.py", line 1831, in _load_level
    self.tw.canvas.setxy(int(-Gdk.Screen.width() / 2), 0,
AttributeError: 'TurtleGraphics' object has no attribute 'setxy'
Traceback (most recent call last):
  File "/home/srevinsaju/Totru/TortugadeMexico/TurtleArtActivity.py", line 547, in do_eraser_cb
    self.restore_challenge()
  File "/home/srevinsaju/Totru/TortugadeMexico/TurtleArtActivity.py", line 553, in restore_challenge
    self._load_level()
  File "/home/srevinsaju/Totru/TortugadeMexico/TurtleArtActivity.py", line 1831, in _load_level
    self.tw.canvas.setxy(int(-Gdk.Screen.width() / 2), 0,
AttributeError: 'TurtleGraphics' object has no attribute 'setxy'
Traceback (most recent call last):
  File "/home/srevinsaju/Totru/TortugadeMexico/TurtleArtActivity.py", line 581, in do_stop_cb
    self.stop_turtle_button.set_icon('hideshowoff')
AttributeError: 'ToolButton' object has no attribute 'set_icon'

Traceback (most recent call last):
  File "/home/srevinsaju/Totru/TortugadeMexico/TurtleArtActivity.py", line 547, in do_eraser_cb
    self.restore_challenge()
  File "/home/srevinsaju/Totru/TortugadeMexico/TurtleArtActivity.py", line 553, in restore_challenge
    self._load_level()
  File "/home/srevinsaju/Totru/TortugadeMexico/TurtleArtActivity.py", line 1831, in _load_level
    self.tw.canvas.setxy(int(-Gdk.Screen.width() / 2), 0,
AttributeError: 'TurtleGraphics' object has no attribute 'setxy'

I agree with everything up to https://github.com/sugarlabs/TortugadeMexico/pull/4/commits/d4e6b9f68e98a63b1a85a0ad1a9219539c1fc49b and have merged that.  I'm now working on the next few commits.

@Kiy4h, https://github.com/sugarlabs/TortugadeMexico/pull/4/commits/5a128895c070ff6b6c91c0eaa01147891f44640a adds conflict markers, which means you hadn't finished it before making the commit, instead you removed the conflict markers in further commits.
Is suboptimal because we can't use git bisect in future, and can't easily cherry-pick again next time we have to synchronise the two source repositories.
Better is to get to the same place but by better series of commits.
Please start a new branch as at the new master d4e6b9f68e98a63b1a85a0ad1a9219539c1fc49b and try cherry-pick fbc466be30368b8e2ebd15445a5a5612acfcf231 again, but this time review the conflicts and fix them.  Use an IDE that lets you see the change about to be committed, and lets you select specific lines to be included in a commit.  I use emacs with magit for this, but there's gotta be other tools out there, I just don't know what they are yet.
Also, in comparing git diff  d4e6b9f..c3de7d5 there are some important changes you've made that should be separated out and applied to both repositories.  Because these aren't really part of the change set from TurtleBlocks to Tortuga de Mexico, and to have them here only makes the latter depart from the former.
@srevinsaju, thanks for testing.  Your work on https://github.com/sugarlabs/turtleart-activity/pull/73 to fix the activity for use in GNOME is yet to be merged, but when it is then I'd expect it to be also added to this activity.

Sorry, that was due to my habit of autosaving a modified file.
I'm used to using VSCode as my code editor, I'll try to fix this mess by creating a new branch and change the PR's base branch. Thanks for the detailed instruction!

Sorry, that was due to my habit of autosaving a modified file.
I'm used to using VSCode as my code editor, I'll try to fix this mess by creating a new branch and change the PR's base branch. Thanks for the detailed instruction!

Thanks.  I've taken your late porting changes that were in c2de7d5 and not in 0d0c724 and added them to the TurtleBlocks master branch as https://github.com/sugarlabs/turtleart-activity/commit/9335bcdc64e379da54d051920aaf5319796be9dd ("Late changes for porting to GTK 3").
Next I'll review and test just the two patches you've added here.

That was quick! Should I also apply the changes to this repository (in this PR)?

@Kiy4h, if you like, doesn't matter, we can do it later.  Now to review your two new patches against the previous patches; I set them side by side and scrolled down each pair;

https://github.com/sugarlabs/TortugadeMexico/pull/4/commits/0d0c724a206927803d950a23c1b29def1e060f9d as compared with https://github.com/sugarlabs/turtleart-activity/commit/8fbb3c7b686d607e441fb1084fe96f0a3209168d, is fine

nothing as compared with https://github.com/sugarlabs/turtleart-activity/commit/acfeb4b519b796f51cb8986ae76bcd92217780b1, is fine, as it is included in https://github.com/sugarlabs/TortugadeMexico/pull/4/commits/ccbcfdb87719dc70c3e928df9fa46fce5e45d1b9,

https://github.com/sugarlabs/TortugadeMexico/pull/4/commits/ccbcfdb87719dc70c3e928df9fa46fce5e45d1b9 as compared with https://github.com/sugarlabs/turtleart-activity/commit/fbc466be30368b8e2ebd15445a5a5612acfcf231

[ ] self._level and self._custom_filepath are not initialised,
[ ] help_animation is missing,
[ ] _help_next is missing,

At this point I stopped looking; whatever method you used to cherry-pick and resolve conflicts didn't work, or there has been a huge redesign of the change.
So please check you have properly integrated each change from https://github.com/sugarlabs/turtleart-activity/commit/fbc466be30368b8e2ebd15445a5a5612acfcf231 adjusted as necessary for changes since that patch.
The way I would do this is start a new branch as of 0d0c724, use git rebase -i to reverse the order of the last two patches, make changes by hand while reading them from https://github.com/sugarlabs/turtleart-activity/commit/fbc466be30368b8e2ebd15445a5a5612acfcf231, and make commits for each major change.  You would end up with a series of patches to show your work, which could be later collapsed into one.

File "/home/walter/Activities/TortugadeMexico/TurtleArt/talogo.py", line 26, in
import urllib.request, urllib.error, urllib.parse
ImportError: No module named request

Thanks.  Reviewed https://github.com/sugarlabs/TortugadeMexico/pull/4/commits/ae927f2464363a8b40b608c1a13f77446730fa3d against https://github.com/sugarlabs/turtleart-activity/commit/fbc466be30368b8e2ebd15445a5a5612acfcf231;

there's at least one call to gobject that hasn't been ported; remember than in applying this old patch, any new lines have to be ported to GTK 3 and ported to Python 3, because those two portings also happened along the mainline of descent since the patch was originally written,
the code fragment that creates the help button and connects to _do_help_cb is present in the old patch but missing in your patch,
the next two patch bands are missing, including the only call to _make_confusion_combo.

Please make sure you check your work; set the two patches side by side and work through every change.  Don't rely on automation (e.g. git) to achieve this.  You have to understand the reason for every change, and if you don't yet then work on that until you do.  If you have questions on specific changes in the original patch, point them out and ask.

@quozl excuse me, why does this error appear when I ran sugar-activity3 and clicked on the snail button in both TortugadeMexico and turtleart-activity?
Traceback (most recent call last):
  File "/home/kiyah/Activities/TortugadeMexico/TurtleArt/talogo.py", line 627, in doevalstep
    next(self.step)
  File "/home/kiyah/Activities/TortugadeMexico/TurtleArt/talogo.py", line 596, in _evalsym
    result = self.cfun.fcn(self, *self.arglist)
  File "/home/kiyah/Activities/TortugadeMexico/TurtleArt/taprimitive.py", line 327, in __call__
    new_prim.call_afterwards(*new_args, **new_kwargs)
  File "/home/kiyah/Activities/TortugadeMexico/TurtleArt/tabasics.py", line 1312, in after_move
    self.tw.coord_scale)
  File "/home/kiyah/Activities/TortugadeMexico/TurtleArt/talogo.py", line 1090, in update_label_value
    for block in self.value_blocks_to_update[name]:
AttributeError: 'LogoCode' object has no attribute 'value_blocks_to_update'

Is this a known issue, or did I miss installing something?

can you reproduce the same error on the regular turtle-blocks activity?

@walterbender Yes, happens on both turtle activities.

I pushed a fix to turtle-activity that can also be applied here.

During testing, I've encountered many errors and exceptions.
I'm guessing this one was caused by the ToolButton module itself, not related to the turtle activity:
Traceback (most recent call last):
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArtActivity.py", line 485, in do_palette_buttons_cb
    self._help_button.set_current_palette(palette_names[i])
AttributeError: 'ToolButton' object has no attribute 'set_current_palette'

This one was caused by using the "setxy" block, but it doesn't happen in turtleart-activity:
Traceback (most recent call last):
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArtActivity.py", line 1769, in _levels_cb
    self._load_level()
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArtActivity.py", line 1780, in _load_level
    self.tw.canvas.setxy(int(-Gdk.Screen.width() / 2), 0,
AttributeError: 'TurtleGraphics' object has no attribute 'setxy'

Should I grab (necessary changes from) the tacanvas.py from turtleart-activity's mexico branch to solve this?
And this one, using the "clear" block:
Traceback (most recent call last):
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/talogo.py", line 629, in doevalstep
    next(self.step)
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/talogo.py", line 598, in _evalsym
    result = self.cfun.fcn(self, *self.arglist)
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/taprimitive.py", line 322, in __call__
    return_value = new_prim.func(*new_args, **new_kwargs)
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/taprimitive.py", line 709, in group
    return_val = prim()
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/taprimitive.py", line 322, in __call__
    return_value = new_prim.func(*new_args, **new_kwargs)
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/talogo.py", line 1054, in clear_value_blocks
    self.update_label_value(name)
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/talogo.py", line 1072, in update_label_value
    for block in self.value_blocks_to_update[name]:
KeyError: 'xcor'

I'm still trying to find out what caused this one, since it doesn't happen in turtleart-activity.

During testing, I've encountered many errors and exceptions.
I'm guessing this one was caused by the ToolButton module itself, not related to the turtle activity:
Traceback (most recent call last):
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArtActivity.py", line 485, in do_palette_buttons_cb
    self._help_button.set_current_palette(palette_names[i])
AttributeError: 'ToolButton' object has no attribute 'set_current_palette'

This one was caused by using the "setxy" block, but it doesn't happen in turtleart-activity:
Traceback (most recent call last):
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArtActivity.py", line 1769, in _levels_cb
    self._load_level()
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArtActivity.py", line 1780, in _load_level
    self.tw.canvas.setxy(int(-Gdk.Screen.width() / 2), 0,
AttributeError: 'TurtleGraphics' object has no attribute 'setxy'

Should I grab (necessary changes from) the tacanvas.py from turtleart-activity's mexico branch to solve this?
And this one, using the "clear" block:
Traceback (most recent call last):
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/talogo.py", line 629, in doevalstep
    next(self.step)
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/talogo.py", line 598, in _evalsym
    result = self.cfun.fcn(self, *self.arglist)
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/taprimitive.py", line 322, in __call__
    return_value = new_prim.func(*new_args, **new_kwargs)
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/taprimitive.py", line 709, in group
    return_val = prim()
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/taprimitive.py", line 322, in __call__
    return_value = new_prim.func(*new_args, **new_kwargs)
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/talogo.py", line 1054, in clear_value_blocks
    self.update_label_value(name)
  File "/home/kiy4h/Activities/TortugadeMexico/TurtleArt/talogo.py", line 1072, in update_label_value
    for block in self.value_blocks_to_update[name]:
KeyError: 'xcor'

I'm still trying to find out what caused this one, since it doesn't happen in turtleart-activity.

Thanks.  Sorry for the delay.  I've reviewed your changes since my last review.  I think you're missing the point; so I'll try to explain again and suggest something new.
Long reply.
Back a few years ago, TurtleArt was copied and changed, adding a new feature, which was named TortugadeMexico.  The change was entirely described within the three commits, of which the largest is https://github.com/sugarlabs/turtleart-activity/commit/fbc466be30368b8e2ebd15445a5a5612acfcf231.  This commit is to 36 files, with 6471 deletions and 416 insertions.
Since then, TurtleArt has undergone significant change; especially a Port to GTK 3 and a Port to Python 3.  A series of 880 commits, to 454 files, 174351 insertions, and 117192 deletions.
TortugadeMexico has not undergone this change.
To port the TortugadeMexico activity to GTK 3 and Python 3, it is necessary to bring the two chains of history back together.
This can't be done mechanically using "git merge", because too much has changed.  The Port to GTK 3 means that some of the 416 insertions are now wrong.
There's three different ways this kind of merge can be completed;

try a "git merge" and then figure out what needs fixing; a barely possible task, as it requires certainty about what every one of the 883 commits intended to do,
apply each of the 880 commits one by one to TortugadeMexico; an insanely long task that none of us would try first, but might eventually be worth trying,
rewrite the original change for the latest TurtleArt, (this is what I was guiding you through), which should be working out how those 416 insertions can be rewritten for GTK 3 and Python 3, while only guided by understanding the largest of the other 880 commits.

There's an additional way I hadn't mentioned.  Take the original https://github.com/sugarlabs/turtleart-activity/commit/fbc466be30368b8e2ebd15445a5a5612acfcf231 commit, explain every single change, and then break it into lots of smaller commits.  Firstly, commits that won't have any bugs, like the removal of plugins.  Then, commits that change defaults, like whether blocks are hidden.  Finally, commits that add the new feature, and a separate commit that enables the feature.
Then each commit can be viewed in order to make changes with the same effect to the latest TurtleArt.
Don't be deceived though; there's no short cut.  It is a really hard task, because TurtleArt is really big, and has been changed a lot.

Thanks, I can understand better now. I'll retake this later after a few tasks or so, I have to get more experiences with porting and GTK3 before getting back to doing this again.

Tested https://github.com/sugarlabs/TortugadeMexico/pull/4/commits/a18881a28ddde231d12616f24b50764dba4457c7. No errors and warnings.

@Hrishi1999 Sorry about that, and thanks for finding it out. I have fixed it on 2c43226.

@quozl @Hrishi1999 I've decided to take the 3rd way. (from https://github.com/sugarlabs/TortugadeMexico/pull/4#issuecomment-569187200)
What I did was:

cherry-pick the ta/mexico commits (from turtleart-activity) and fix merge conflicts very carefully, (724567d, 7a5f024)
run pygi-convert.sh, (77d7eb2)
run 2to3, (8243401)
debug and fix multiple times (f4b2594,  1faac3b, 9182927, 2c43226)

I cloned https://github.com/sugarlabs/turtleart-activity/ to local and cherry-picked those three commits:
fbc466be30368b8e2ebd15445a5a5612acfcf231 8fbb3c7b686d607e441fb1084fe96f0a3209168d acfeb4b519b796f51cb8986ae76bcd92217780b1
from the mexico branch (https://github.com/sugarlabs/turtleart-activity/tree/mexico) and resolved a few merge conflicts, then I ran ./pygi-convert.sh in the directory. And finally, I pushed to the fork of TortugadeMexico.


Collaboration?

Hi!
What do you think about collaborating? Perhaps have some joint efforts to merge https://github.com/wallymathieu/with/ with your library?
Best regards from Oskar

Hi,
Why not ! But what would be the point to merge our libraries ?
Do you have any issue to address ? Any new idea/improvement you would like to add ?
Regards,
Emmanuel

Copy update of readonly collections (if you target .net45 and above)
Be able to do something like prepare statement in order to be able to use more complex expressions (and only incur the cost of expression compilation once)
Perhaps remove expression based copy update using == (unless you are using prepare statement)

Perhaps attract more contributors for this type of solution. I've mostly done with on my own, having more people involved could help keep it sane.

Perhaps look at what can be removed from with? Perhaps remove var vipCustomer = customer.As<VipCustomer>(m => m.Since == DateTime.Now)?

if you want I can add you as a collaborator on with @ehorrent

For instance, what do you think of https://github.com/wallymathieu/with/pull/39 ?

Really sorry for this really late response, but I was really busy recently and was not using github at all... I will take a look at your refactoring.
If you didn't know, I also discovered this really interesting library : language-ext.

I've looked at it. It's interesting.


refactor: improve test coverage

What does this PR do?

refactor code to improve performance

Description of Task to be completed?

refactor code to improve performance based on peer reviews

How should this be manually tested?

none

Any background context you want to provide?

refactors and wrote more test cases to increase test coverage result

What are the relevant pivotal tracker stories?

none

Screenshots (if appropriate)

none

Questions:

none

Coverage increased (+1.6%) to 88.188% when pulling 4694053b8e36e4f315ab69c9b34b97d902963efa on refactor/refactor-code into ae4a91980672c815a3a723e46c640d247308bcac on develop.


Bug(interface): do not allow negative votes

Description
You can add negative votes to the ballot now.

close by #291


fix README: go install github.com/rajveermalviya/tsukuru/cmd/tsukuru@latest

fixes https://github.com/rajveermalviya/go-webgpu-examples/issues/4

Thanks!

am working on tsukuru to add darwin and wasm.
saw the issues about tsukuru file approach..
I have a few questions.... will raise issues there.
If you on telegram you can grab me too


keep stardust count updated

Short Description:
display stardust gained when capturing a pokemon
keep the stardust count updated
Fixes/Resolves/Closes (please use correct syntax):

👍


update ci/cd workflow

https://github.com/hashicorp/terraform/pull/31908 - The CVE doesn't affect terraform, however go is being updated to pipe down scanners like the one implemented here.


Handle EOP

The end of partition information should be somehow forwarded to the subscriber to let it know that all data have been consumed. This would be helpful when using a (maybe compacted) topic to replicate a set of data.
The consumer could also automatically disconnect when the entire topic has been read.
Note that a a topic might have multiple partitions, so we have to deal with an EOP for each (assigned) partition.

Available in v3.2.0-beta.1


New Porter Plugin/Mixin versions break the system

Describe the bug
The Porter Azure plugin has recently been updated with a breaking change - they removed support in Azure Tables for state storage.
This breaks the Resource Processor if its image is being rebuilt from scratch.

Running:
/app# porter plugins uninstall  azure
Uninstalled azure plugin

/app# porter plugins install azure --version v0.11.2
installed azure plugin v0.11.2 (894e361)

in the docker container running the resource processor resolves, also had to open firewalls rules for the RP subnet.
cdn.porter.sh
*.githubusercontent.com

A release will be created to fix this.


Fix #1221: double height in retina display.

Short description of changes:
fix doubled canvas height in retina display.
Related Issues and other PRs:
#1221  Spectrogram doubled canvas size

Thanks!

Build breaking because of #1233 – Either wait until that is merged or cherry-pick the commit.


Misaligned pre-footer (Create an issue, Edit this page, commit history section)

This is a...

[ ] Feature Request
[X] Bug Report

Problem:
The pre footer is not aligned correctly, it should be in the centre or at least have some spacing from left and bottom.

Proposed Solution:
To have some proper CSS which is missing?
Page to Affected:
Almost all the sections,
example:
https://kubernetes.io/docs/concepts/

Some pages like this have proper alignment on left for pre-footer section. I think we can apply same change to other pages where pre-footer is not aligned. I would like to be work on this.

Seems like this got fixed. @akshay196 any idea which commit fixed this issue?

This issue is resolved by #10496

Fixed by #10496


Shall we support Powered by AI and feedback loop feature in Python SDK?

Use this query to search for the most popular feature requests.
Is your feature request related to a problem? Please describe.
As Teams channel support a 'AI generated' tag as new feature Powered by AI, it is better for Python SDK to support it, along with citations and feedback loop.
I think the problem is that entities are missing when constructing the post body in this file. https://github.com/microsoft/botbuilder-python/blob/01449b5a9f33f55297e420c1c0cc2403c63ad67c/libraries/botframework-connector/botframework/connector/aio/operations_async/_conversations_operations_async.py#L517
teams-ai Python library already support these new features, need your support to accomplish them.
Cc. @tracyboehrer @aacebo

@frankqianms When citations are added to BF SDK, it will be across all languages.  This work just hasn't happened yet.


🍒 Cherry pick PR #15761 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/15761 to staging 🍒

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 1.2.80-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/roryabraham in version: 1.2.80-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Import js file with same name folder in same folder.

<EMAIL_ADDRESS>There are symbol.js and symbol/ exist in src/, but no index.js in symbol/.
When I request<EMAIL_ADDRESS>returns 404.
I think it should return file symbol.js when symbol/index.js not exists.

Use the distribution dist  folder, not the src

This works now.


border opacity is missing from the docs

I was a bout to write a feature request for a borderOpacity property, when I find out the feature does exist by finding the issue / pr that added it.
However, it is missing from the api documentation.

@hschwane documentation has been updated. Thank you !
https://github.com/felixmariotto/three-mesh-ui/wiki/API-documentation#borderopacity


[AutoDiff] Assertion failed: (linearMapStructTy && "must have linear map struct type for predecessor BB")

Description
The code below will cause the compiler to crash when compiled with certain toolchains. The error message provided is:
Assertion failed: (linearMapStructTy && "must have linear map struct type for predecessor BB"), function populateBranchingTraceDecl, file LinearMapInfo.cpp, line 146.
The error occurs in both Debug and Release mode.
Reproduction
Compile the following code in Debug or Release mode:
import Foundation; import _Differentiation
struct A: Differentiable {}
struct B: Differentiable {@differentiable(reverse) func c(b: B) -> A {while true {if true {break}}; return A()}}

Expected behavior
The compilation should succeed.
Environment
This fails with:
Swift Development Snapshot 2024-01-15(a)
Swift Development Snapshot 2024-01-22(a)
but not with:
Swift Development Snapshot 2024-01-08(a)
Swift 5.10 Development Snapshot 2024-01-24(a)
This failure can be seen on both an M1 and x86 Mac.
Additional information
Here is a stack trace:
1.	Apple Swift version 5.11-dev (LLVM e2b71339d3295a4, Swift 8ae3ee998f408c4)
2.	Compiling with the current language version
3.	While evaluating request ExecuteSILPipelineRequest(Run pipelines { Mandatory Diagnostic Passes + Enabling Optimization Passes } on SIL for linearMapReproducer)
4.	While running pass #388 SILModuleTransform "Differentiation".
5.	While processing // differentiability witness for B.c(b:)
sil_differentiability_witness [serialized] [reverse] [parameters 0 1] [results 0] @$s19linearMapReproducer1BV1c1bAA1AVAC_tF : $@convention(method) (B, B) -> A {
}

 on SIL function "@$s19linearMapReproducer1BV1c1bAA1AVAC_tF".
 for 'c(b:)' (at /Users/user/linearMapReproducer/linearMapReproducer/main.swift:3:52)
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  swift-frontend           0x0000000107ed82c8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
1  swift-frontend           0x0000000107ed6a94 llvm::sys::RunSignalHandlers() + 112
2  swift-frontend           0x0000000107ed8910 SignalHandler(int) + 304
3  libsystem_platform.dylib 0x000000018b12aa24 _sigtramp + 56
4  libsystem_pthread.dylib  0x000000018b0fbc28 pthread_kill + 288
5  libsystem_c.dylib        0x000000018b009ae8 abort + 180
6  libsystem_c.dylib        0x000000018b008e44 err + 0
7  swift-frontend           0x000000010803de88 swift::autodiff::LinearMapInfo::populateBranchingTraceDecl(swift::SILBasicBlock*, swift::SILLoopInfo*) (.cold.4) + 0
8  swift-frontend           0x0000000103258d18 swift::autodiff::LinearMapInfo::populateBranchingTraceDecl(swift::SILBasicBlock*, swift::SILLoopInfo*) + 1196
9  swift-frontend           0x000000010325799c swift::autodiff::LinearMapInfo::generateDifferentiationDataStructures(swift::autodiff::ADContext&, swift::SILFunction*) + 452
10 swift-frontend           0x0000000103258160 swift::autodiff::LinearMapInfo::LinearMapInfo(swift::autodiff::ADContext&, swift::AutoDiffLinearMapKind, swift::SILFunction*, swift::SILFunction*, swift::AutoDiffConfig const&, swift::DifferentiableActivityInfo const&, swift::SILLoopInfo*) + 148
11 swift-frontend           0x0000000103277f68 swift::autodiff::VJPCloner::Implementation::Implementation(swift::autodiff::VJPCloner&, swift::autodiff::ADContext&, swift::SILDifferentiabilityWitness*, swift::SILFunction*, swift::autodiff::DifferentiationInvoker) + 656
12 swift-frontend           0x0000000103278e2c swift::autodiff::VJPCloner::VJPCloner(swift::autodiff::ADContext&, swift::SILDifferentiabilityWitness*, swift::SILFunction*, swift::autodiff::DifferentiationInvoker) + 92
13 swift-frontend           0x00000001033d4bec (anonymous namespace)::DifferentiationTransformer::canonicalizeDifferentiabilityWitness(swift::SILDifferentiabilityWitness*, swift::autodiff::DifferentiationInvoker, swift::IsSerialized_t) + 6032
14 swift-frontend           0x00000001033d2a64 (anonymous namespace)::Differentiation::run() + 1060
15 swift-frontend           0x0000000103470f64 swift::SILPassManager::runModulePass(unsigned int) + 848
16 swift-frontend           0x0000000103473198 swift::SILPassManager::execute() + 624
17 swift-frontend           0x000000010346dbcc swift::SILPassManager::executePassPipelinePlan(swift::SILPassPipelinePlan const&) + 72
18 swift-frontend           0x000000010346db50 swift::ExecuteSILPipelineRequest::evaluate(swift::Evaluator&, swift::SILPipelineExecutionDescriptor) const + 68
19 swift-frontend           0x00000001034a7cf0 swift::SimpleRequest<swift::ExecuteSILPipelineRequest, std::__1::tuple<> (swift::SILPipelineExecutionDescriptor), (swift::RequestFlags)1>::evaluateRequest(swift::ExecuteSILPipelineRequest const&, swift::Evaluator&) + 28
20 swift-frontend           0x0000000103488cf4 llvm::Expected<swift::ExecuteSILPipelineRequest::OutputType> swift::Evaluator::getResultUncached<swift::ExecuteSILPipelineRequest>(swift::ExecuteSILPipelineRequest const&) + 268
21 swift-frontend           0x000000010346ddb8 swift::executePassPipelinePlan(swift::SILModule*, swift::SILPassPipelinePlan const&, bool, swift::irgen::IRGenModule*) + 84
22 swift-frontend           0x000000010348b318 swift::runSILDiagnosticPasses(swift::SILModule&) + 192
23 swift-frontend           0x0000000102d0560c swift::CompilerInstance::performSILProcessing(swift::SILModule*) + 80
24 swift-frontend           0x0000000102ad5e44 performCompileStepsPostSILGen(swift::CompilerInstance&, std::__1::unique_ptr<swift::SILModule, std::__1::default_delete<swift::SILModule>>, llvm::PointerUnion<swift::ModuleDecl*, swift::SourceFile*>, swift::PrimarySpecificPaths const&, int&, swift::FrontendObserver*) + 796
25 swift-frontend           0x0000000102ad5538 swift::performCompileStepsPostSema(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 624
26 swift-frontend           0x0000000102ae5ff8 withSemanticAnalysis(swift::CompilerInstance&, swift::FrontendObserver*, llvm::function_ref<bool (swift::CompilerInstance&)>, bool) + 160
27 swift-frontend           0x0000000102ad7a48 performCompile(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 708
28 swift-frontend           0x0000000102ad6a7c swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2280
29 swift-frontend           0x000000010295944c swift::mainEntry(int, char const**) + 3064
30 dyld                     0x000000018ada3f28 start + 2236

@asl

@fibrechannelscsi I cannot reproduce this on main. Will it be possible for you to check it again?

I've checked this with the most recent 01-30 nightlies:
https://download.swift.org/development/xcode/swift-DEVELOPMENT-SNAPSHOT-2024-01-30-a/swift-DEVELOPMENT-SNAPSHOT-2024-01-30-a-osx.pkg
and
https://download.swift.org/development/ubuntu1804/swift-DEVELOPMENT-SNAPSHOT-2024-01-30-a/swift-DEVELOPMENT-SNAPSHOT-2024-01-30-a-ubuntu18.04.tar.gz
in the case of an x86 Ubuntu 18 machine.
This is still occurring both on x86 and on my M1 Mac with the 01-30a toolchains.
If I copy the three lines above into a main.swift file and simply run:
/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2024-01-30-a.xctoolchain/usr/bin/swift main.swift
then it will segfault as before. Given that I also have the 01-08a toolchain installed:
/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2024-01-08-a.xctoolchain/usr/bin/swift main.swift
will exit without any output as expected.

Interesting, thanks!

Ok, I was able to reproduce in bootstrapped build (not the build with bootstrapping turned off)!

Here is SIL generated for function B:
// B.c(b:)
sil hidden [ossa] @$s4main1BV1c1bAA1AVAC_tF : $@convention(method) (B, B) -> A {
// %0 "b"                                         // user: %2
// %1 "self"                                      // user: %3
bb0(%0 : $B, %1 : $B):
  debug_value %0 : $B, let, name "b", argno 1     // id: %2
  debug_value %1 : $B, let, name "self", argno 2, implicit // id: %3
  br bb1                                          // id: %4

bb1:                                              // Preds: bb4 bb0
  %5 = integer_literal $Builtin.Int1, -1          // user: %8
  %6 = metatype $@thin Bool.Type                  // user: %8
  // function_ref Bool.init(_builtinBooleanLiteral:)
  %7 = function_ref @$sSb22_builtinBooleanLiteralSbBi1__tcfC : $@convention(method) (Builtin.Int1, @thin Bool.Type) -> Bool // user: %8
  %8 = apply %7(%5, %6) : $@convention(method) (Builtin.Int1, @thin Bool.Type) -> Bool // user: %9
  %9 = struct_extract %8 : $Bool, #Bool._value
  br bb2                                          // id: %10

bb2:                                              // Preds: bb1
  %11 = integer_literal $Builtin.Int1, -1         // user: %14
  %12 = metatype $@thin Bool.Type                 // user: %14
  // function_ref Bool.init(_builtinBooleanLiteral:)
  %13 = function_ref @$sSb22_builtinBooleanLiteralSbBi1__tcfC : $@convention(method) (Builtin.Int1, @thin Bool.Type) -> Bool // user: %14
  %14 = apply %13(%11, %12) : $@convention(method) (Builtin.Int1, @thin Bool.Type) -> Bool // user: %15
  %15 = struct_extract %14 : $Bool, #Bool._value
  br bb3                                          // id: %16

bb3:                                              // Preds: bb2
  br bb6                                          // id: %17

bb4:
  br bb1                                          // id: %18

bb5:
  br bb6                                          // id: %19

bb6:                                              // Preds: bb3 bb5
  %20 = metatype $@thin A.Type                    // user: %22
  // function_ref A.init()
  %21 = function_ref @$s4main1AVACycfC : $@convention(method) (@thin A.Type) -> A // user: %22
  %22 = apply %21(%20) : $@convention(method) (@thin A.Type) -> A // user: %23
  return %22 : $A                                 // id: %23
} // end sil function '$s4main1BV1c1bAA1AVAC_tF'

bb4 here is unreachable and therefore excluded from RPOT. Here is the input SIL without bootstrap (so with all swift code in compiler disabled):
sil hidden [ossa] @$s4main1BV1c1bAA1AVAC_tF : $@convention(method) (B, B) -> A {
// %0 "b"                                         // user: %2
// %1 "self"                                      // user: %3
bb0(%0 : $B, %1 : $B):
  debug_value %0 : $B, let, name "b", argno 1     // id: %2
  debug_value %1 : $B, let, name "self", argno 2, implicit // id: %3
  br bb1                                          // id: %4

bb1:                                              // Preds: bb4 bb0
  %5 = integer_literal $Builtin.Int1, -1          // user: %8
  %6 = metatype $@thin Bool.Type                  // user: %8
  // function_ref Bool.init(_builtinBooleanLiteral:)
  %7 = function_ref @$sSb22_builtinBooleanLiteralSbBi1__tcfC : $@convention(method) (Builtin.Int1, @thin Bool.Type) -> Bool // user: %8
  %8 = apply %7(%5, %6) : $@convention(method) (Builtin.Int1, @thin Bool.Type) -> Bool // user: %9
  %9 = struct_extract %8 : $Bool, #Bool._value    // user: %10
  cond_br %9, bb2, bb5                            // id: %10

bb2:                                              // Preds: bb1
  %11 = integer_literal $Builtin.Int1, -1         // user: %14
  %12 = metatype $@thin Bool.Type                 // user: %14
  // function_ref Bool.init(_builtinBooleanLiteral:)
  %13 = function_ref @$sSb22_builtinBooleanLiteralSbBi1__tcfC : $@convention(method) (Builtin.Int1, @thin Bool.Type) -> Bool // user: %14
  %14 = apply %13(%11, %12) : $@convention(method) (Builtin.Int1, @thin Bool.Type) -> Bool // user: %15
  %15 = struct_extract %14 : $Bool, #Bool._value  // user: %16
  cond_br %15, bb3, bb4                           // id: %16

bb3:                                              // Preds: bb2
  br bb6                                          // id: %17

bb4:                                              // Preds: bb2
  br bb1                                          // id: %18

bb5:                                              // Preds: bb1
  br bb6                                          // id: %19

bb6:                                              // Preds: bb3 bb5
  %20 = metatype $@thin A.Type                    // user: %22
  // function_ref A.init()
  %21 = function_ref @$s4main1AVACycfC : $@convention(method) (@thin A.Type) -> A // user: %22
  %22 = apply %21(%20) : $@convention(method) (@thin A.Type) -> A // user: %23
  return %22 : $A                                 // id: %23
} // end sil function '$s4main1BV1c1bAA1AVAC_tF'

Clearly, some pass replaced cond_br %15, bb3, bb4 to direct branch making bb4 unreachable.

It looks like it should be https://github.com/apple/swift/pull/70787
Tagging @eeckstein

Some further information: for autodiff we'd essentially need to execute code in reverse from result to entry basic block.
So I guess we'd need to detect such cases consistently and ignore blocks that are not reachable from the input block.

@asl Is this something you can fix in the autodiff code? (I have no idea how that works)

@asl Is this something you can fix in the autodiff code? (I have no idea how that works)

I have fix for autodiff, albeit do not know if it's comple. I guess here is the question about assumptions: so far there were no unreachable BBs created during mandatory transformations. Will it make sense to remove them instead?

Will it make sense to remove them instead?

Yes, we can do that easily in the BooleanLiteralFolding pass

https://github.com/apple/swift/pull/71339

@eeckstein Thanks! And #71356 complements it trying to make autodiff more robust.


Small bug when tag bump with no initial tag

$ kimono tag bump m
cmds/vars/0.1.0

@rwxrob you can close this issue.


PQS metrics -  https://issues.apache.org/jira/browse/PHOENIX-3655

Phoenix Query Server metrics
https://issues.apache.org/jira/browse/PHOENIX-3655
The following properties is added along with the defaults

"phoenix.query.server.metrics" - default is true ( means pqs will collect metrics by default )
"phoenix.query.server.metrics.report.interval.ms" - default is 30 sec ( every 30 sec, the global metrics will be output to sink )
"phoenix.query.server.metrics.type.of.sink" - default is file  ( other option is slf4j)
"phoenix.query.server.filesink.filename" - Filename if using fileSink (default is  /tmp/pqsSinkFile)

if user setup "phoenix.query.server.metrics"  in hbase-site.xml to true, we add the following properties to JDBC connection (QueryServices.COLLECT_REQUEST_LEVEL_METRICS=  true). The starts the metrics collect at request level.
There are two types of metrics

Global - This metrics is collect every interval and pushed to sink ( File or Slf4j). Apart from this, it is also exposed in JMX via Mbeans.
Request - These metrics is collected at statement and connection close level. Once collected, it is pushed to the sink. These metrics are not exposed via JMX as metrics are for specific table requests.  For requests level metrics, we have file and Slf4j ( LOG) as types of sink. So, the metrics will be pushed to a specified file or log file .

For details on Phoenix Metrics - refer - https://phoenix.apache.org/metrics.html

Metrics Snippet
Statement Level -
{"Statement-OverAllReadRequestMetrics":{"RESULT_SET_TIME_MS":22,"QUERY_FAILED_COUNTER":0,"QUERY_TIMEOUT_COUNTER":0,"WALL_CLOCK_TIME_MS":52,"CACHE_REFRESH_SPLITS_COUNTER":0,"NUM_PARALLEL_SCANS":1}}
{"Statement-RequestReadMetrics":{"QUERYSERVERBASICSIT1494892379503":{"TASK_QUEUE_WAIT_TIME":0,"SCAN_BYTES":208,"TASK_END_TO_END_TIME":10,"TASK_EXECUTED_COUNTER":1,"TASK_EXECUTION_TIME":10,"TASK_REJECTED_COUNTER":0}}}
Global Metrics -
{"global":[{"numberOfSamples":0,"description":"Batch sizes of mutations","currentMetricState":"MUTATION_BATCH_SIZE: 0, Number of samples: 0","totalSum":0,"name":"MUTATION_BATCH_SIZE","value":0},{"numberOfSamples":0,"description":"Size of mutations in bytes","currentMetricState":"MUTATION_BYTES: 0, Number of samples: 0","totalSum":0,"name":"MUTATION_BYTES","value":0},{"numberOfSamples":0,"description":"Time it took to commit mutations","currentMetricState":"MUTATION_COMMIT_TIME: 0, Number of samples: 0","totalSum":0,"name":"MUTATION_COMMIT_TIME","value":0},{"numberOfSamples":7,"description":"Query times","currentMetricState":"QUERY_TIME: 52, Number of samples: 7","totalSum":52,"name":"QUERY_TIME","value":52},{"numberOfSamples":11,"description":"Number of scans that were executed in parallel","currentMetricState":"NUM_PARALLEL_SCANS: 11, Number of samples: 11","totalSum":11,"name":"NUM_PARALLEL_SCANS","value":11},{"numberOfSamples":2,"description":"Number of bytes read by scans","currentMetricState":"SCAN_BYTES: 192, Number of samples: 2","totalSum":192,"name":"SCAN_BYTES","value":192},{"numberOfSamples":0,"description":"Size of spool files created in bytes","currentMetricState":"SPOOL_FILE_SIZE: 0, Number of samples: 0","totalSum":0,"name":"SPOOL_FILE_SIZE","value":0},{"numberOfSamples":0,"description":"Number of bytes allocated by the memory manager","currentMetricState":"MEMORY_CHUNK_BYTES: 0, Number of samples: 0","totalSum":0,"name":"MEMORY_CHUNK_BYTES","value":0},{"numberOfSamples":0,"description":"Number of milliseconds threads needed to wait for memory to be allocated through memory manager","currentMetricState":"MEMORY_WAIT_TIME: 0, Number of samples: 0","totalSum":0,"name":"MEMORY_WAIT_TIME","value":0},{"numberOfSamples":11,"description":"Time in milliseconds tasks had to wait in the queue of the thread pool executor","currentMetricState":"TASK_QUEUE_WAIT_TIME: 5, Number of samples: 11","totalSum":5,"name":"TASK_QUEUE_WAIT_TIME","value":5},{"numberOfSamples":11,"description":"Time in milliseconds spent by tasks from creation to completion","currentMetricState":"TASK_END_TO_END_TIME: 139, Number of samples: 11","totalSum":139,"name":"TASK_END_TO_END_TIME","value":139},{"numberOfSamples":11,"description":"Time in milliseconds tasks took to execute","currentMetricState":"TASK_EXECUTION_TIME: 134, Number of samples: 11","totalSum":134,"name":"TASK_EXECUTION_TIME","value":134},{"numberOfSamples":99,"description":"Counter for number of mutation sql statements","currentMetricState":"MUTATION_SQL_COUNTER: 99, Number of samples: 99","totalSum":99,"name":"MUTATION_SQL_COUNTER","value":99},{"numberOfSamples":7,"description":"Counter for number of sql queries","currentMetricState":"SELECT_SQL_COUNTER: 7, Number of samples: 7","totalSum":7,"name":"SELECT_SQL_COUNTER","value":7},{"numberOfSamples":11,"description":"Counter for number of tasks submitted to the thread pool executor","currentMetricState":"TASK_EXECUTED_COUNTER: 11, Number of samples: 11","totalSum":11,"name":"TASK_EXECUTED_COUNTER","value":11},{"numberOfSamples":0,"description":"Counter for number of tasks that were rejected by the thread pool executor","currentMetricState":"TASK_REJECTED_COUNTER: 0, Number of samples: 0","totalSum":0,"name":"TASK_REJECTED_COUNTER","value":0},{"numberOfSamples":0,"description":"Number of times query timed out","currentMetricState":"QUERY_TIMEOUT_COUNTER: 0, Number of samples: 0","totalSum":0,"name":"QUERY_TIMEOUT_COUNTER","value":0},{"numberOfSamples":0,"description":"Number of times query failed","currentMetricState":"QUERY_FAILED_COUNTER: 0, Number of samples: 0","totalSum":0,"name":"QUERY_FAILED_COUNTER","value":0},{"numberOfSamples":0,"description":"Number of spool files created","currentMetricState":"SPOOL_FILE_COUNTER: 0, Number of samples: 0","totalSum":0,"name":"SPOOL_FILE_COUNTER","value":0},{"numberOfSamples":14,"description":"Number of open phoenix connections","currentMetricState":"OPEN_PHOENIX_CONNECTIONS_COUNTER: 0, Number of samples: 14","totalSum":0,"name":"OPEN_PHOENIX_CONNECTIONS_COUNTER","value":0},{"numberOfSamples":1,"description":"Number of ConnectionQueryServicesImpl instantiated","currentMetricState":"QUERY_SERVICES_COUNTER: 1, Number of samples: 1","totalSum":1,"name":"QUERY_SERVICES_COUNTER","value":1},{"numberOfSamples":1,"description":"Number of HConnections created by phoenix driver","currentMetricState":"HCONNECTIONS_COUNTER: 1, Number of samples: 1","totalSum":1,"name":"HCONNECTIONS_COUNTER","value":1}]}
Global Metrics is also exposed via JMX. ( screen shot attached)

We decided not to follow this approach, Hence will be removing the reference to this PR from JIRA.


Remove more clustering bits

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/400/

FreeBSD11 build failed! https://ci.trafficserver.apache.org/job/freebsd-github/2094/

RAT check failed! https://ci.trafficserver.apache.org/job/RAT-github/411/

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/396/

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/401/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/412/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1988/

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/397/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/524/

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/2095/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1989/

[approve ci]

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/403/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/414/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/526/

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/399/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/657/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1991/

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/2097/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/659/

[approve ci]

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/407/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/418/

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/403/

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/2101/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1995/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/530/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/663/

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/410/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/421/

AU check successful! https://ci.trafficserver.apache.org/job/autest-github/406/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1998/

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/2104/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/534/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/666/


Quoting is insufficient

The quoting added by #69 is insufficient. You quote space characters, but one should also quote strings that contain special characters as specified by POSIX given https://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_02 .
However, this can vary from shell to shell, so to be safe you should quote all strings. As it stands now, this library incorrectly quotes strings, for example arguments that do not contain spaces but have a $WORD would be interpreted as a variable substitution instead of the string '$WORD'. Correct quoting should quote all strings.

fixed by #135, so this can be closed


Replace FAQs with FAQ

Plural is implicit in the acronym FAQ. The heading as well as the links would need to be changed.

Done.
PR: https://github.com/covid19india/covid19india-react/pull/134

Patched by #85


SAK-33684 Handle SMTP FROM that isn’t email better

Have better handling of a client attempting to send an email where the FROM address isn’t an email address that we can parse. This may be because it’s empty or it’s not an email address.

Unnecessary stubbings detected in test class: SakaiMessageHandlerTest
Clean & maintainable test code requires zero unnecessary code.
Following stubbings are unnecessary (click to navigate to relevant line of code):

-> at org.sakaiproject.mailarchive.SakaiMessageHandlerTest.testEmptyReturnPath(SakaiMessageHandlerTest.java:304)
-> at org.sakaiproject.mailarchive.SakaiMessageHandlerTest.testEmptyReturnPath(SakaiMessageHandlerTest.java:305)
-> at org.sakaiproject.mailarchive.SakaiMessageHandlerTest.testNoReturnPath(SakaiMessageHandlerTest.java:294)
-> at org.sakaiproject.mailarchive.SakaiMessageHandlerTest.testNoReturnPath(SakaiMessageHandlerTest.java:295)
Please remove unnecessary stubbings or use 'silent' option. More info: javadoc for UnnecessaryStubbingException class.
Results :
Tests in error:
SakaiMessageHandlerTest.unnecessary Mockito stubbings » UnnecessaryStubbing

Fixed, sorry about that, I was just running the new tests and not the whole class and so it wasn't running the stubbing checks.

Ready to merge?

Thanks @ottenhoff. Yep, it was ready.


Changes to support README.md to passing super-linter

what

Small changes for README.md to be linted

why

To conform with MD standards

references

https://github.com/cloudposse/.github/pull/1 - gh actions are passing for README.md

@osterman I made additional changes as linter still didn't like no # at the beginning of md file.
https://github.com/cloudposse/build-harness/pull/230/files/d94c7d2773930108a082e18042a8bd826a48537f..28702fe1da5b78ee8a4f3a0232b24ff9a594aded
Now .github repo pass linting

Please reapprove


feat(storage): support soft-deleted objects

Part of the changes for #13575

This change is

/gcbrun


Lua error when opening a file

Getting this error when I open any file
Error executing vim. schedule lua callback: ..ount_nvim.@AXjk2a/usr/share/nvim/runtime/lua/vim/lsp.lua:1308:RPC[Error]code_name=InvalidPara stack traceback:
[c]: in function 'assert'
...ount_nvim.aAXjk2a/usr/share/nvim/runtime/lua/vim/lsp.lua:1308:infunction'
vim/_editor. lua: in function <vim/_editor. lua:0>

after that, several messages get injected to the actual file I opened, in this case a .tsx

Steps to Reproduce
installed using LazyVim using default config except path to Trunk which is custom in my case
formatOnSave = false  and  lazy = false
When opening neovim everything is slow (unusable)
Then open a file, in my case .tsx file
Error shown above start to show up
Environment
Ubuntu
Neovim 0.9.2

Thanks for reporting this! Can you send the contents of .trunk/trunk.yaml and .trunk/logs/neovim.log?

log file has this like 10 times:
[INFO  Fri Oct 20 19:18:25 2023] .../.local/share/nvim/lazy/neovim-trunk/lua/trunk.lua:27: Starting
[INFO  Fri Oct 20 19:18:25 2023] .../.local/share/nvim/lazy/neovim-trunk/lua/trunk.lua:229: Setting up autocmds


what if we just asynced all the model calls

when making requests spin up the thread to request and return immediately
give all the cohere response objects a mutex, when a request is running a thread should hold onto that mutex
if accessed, block <-- this is the spooky part

Closed by #74


chore: bump CI to use latest version

Closes #117

#118  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on  Graphite


Crashing when creating partial realms on write_subscription

Goals
App not crashing when opening partial realms
Expected Results
Opening partial realms successfuly
Actual Results
Crashed: Thread
0  libsystem_kernel.dylib         0x1ad062d88 __pthread_kill + 8
1  libsystem_pthread.dylib        0x1acf7b1e8 pthread_kill$VARIANT$mp + 136
2  libsystem_c.dylib              0x1acece934 abort + 100
3  Realm                          0x104fe7a34 realm::util::terminate(char const*, char const*, long) + 10
4  Realm                          0x104fe7d40 realm::util::terminate_internal(std::__1::basic_stringstream<char, std::__1::char_traits, std::__1::allocator >&) + 780
5  Realm                          0x104fe7eb8 realm::util::terminate(char const*, char const*, long, std::initializer_listrealm::util::Printable&&) + 328
6  Realm                          0x104fb3280 realm::Table::allocate_object_id_squeezed() + 394
7  Realm                          0x104ce0de0 realm::partial_sync::(anonymous namespace)::write_subscription(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, realm::util::Optional, bool, realm::Group&) + 387 (partial_sync.cpp:387)
8  Realm                          0x104ce3ad0 std::__1::__function::__func<realm::partial_sync::(anonymous namespace)::enqueue_registration(realm::Realm&, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, realm::util::Optional, bool, std::__1::function<void (std::exception_ptr)>)::$_8, std::__1::allocator<realm::partial_sync::(anonymous namespace)::enqueue_registration(realm::Realm&, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, realm::util::Optional, bool, std::__1::function<void (std::exception_ptr)>)::$_8>, void ()>::operator()() + 423 (partial_sync.cpp:423)
9  Realm                          0x104de6374 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_deletestd::__1::__thread_struct >, realm::_impl::partial_sync::WorkQueue::create_thread()::$_0> >(void*) + 1396 (iterator:1396)
10 libsystem_pthread.dylib        0x1acf83d98 _pthread_start + 156
11 libsystem_pthread.dylib        0x1acf8774c thread_start + 8
Steps for others to Reproduce
Very difficult to reproduce. Only some clients are affected
Code Sample
It happens when a subscription is going to be created:
let subscription = checkInsInThisEvent.subscribe(named: name, update: true, timeToLive: .timeToLive)
Version of Realm and Tooling
Realm framework version: 5.3.6
Realm Object Server version: 3.28.2
Xcode version: 11.7
iOS/OSX version: 13.6.1
Dependency manager + version: Cocoapods 1.9.3

Hi @juanjo72 ,
This version of Realm Cloud is now referred to as legacy Realm Cloud. It is recommended that for sync, you upgrade to v10.

Hi, Pavel,
I have see this version is a beta one and I am afraid I am using RxRealm 3.1, released last July which is incompatible with v10.
What you mention as Realm Cloud I am assuming you are referring to the RealmSwift sdk.

@juanjo72 I believe what Pavel refers to is that "Realm Object Server" is now legacy, and we encourage to upgrade to MongoDB Realm (which is the successor). It's out of beta now, so I would suggest upgrading if you can.


add AMI in AWS marketplace for v5.7.4

a new ami needs to be published on the marketplace for version v5.7.4
chageset: https://github.com/Shippable/support/wiki/5.7.4

Submitting for review today.

Closing in favour of https://github.com/Shippable/admiral/issues/1093


Companion url in config

It's really cool how easy it is to add a new provider to uppy-angular, but without your own companion instance you won't be able to use google drive or facebook. This fix will make it possible :)

@prezesp Can you add https://companion.uppy.io as default if the user doesn't pass companionUrl.

I already added default url in line 61 of uppy-angular.component.ts.  Do you have another suggestion?

@prezesp Can you add https://companion.uppy.io as default if the user doesn't pass companionUrl.

I already added default url in line 61 of uppy-angular.component.ts.  Do you have another suggestion?

Nope, thanks. Sorry I missed it during review
On Wed, 27 Jan 2021 at 3:05 AM, Piotr Walkiewicz<EMAIL_ADDRESS>wrote:

@prezesp https://github.com/prezesp Can you add
https://companion.uppy.io as default if the user doesn't pass
companionUrl.
I already added default url in line 61 of uppy-angular.component.ts. Do
you have another suggestion?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/adritasharma/uppy-angular-library/pull/13#issuecomment-767842755,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7KMU67DXMEC6JDT7EDIWLS34YRTANCNFSM4VKF7LJA
.

Nope, thanks. Sorry I missed it during review
On Wed, 27 Jan 2021 at 3:05 AM, Piotr Walkiewicz<EMAIL_ADDRESS>wrote:

@prezesp https://github.com/prezesp Can you add
https://companion.uppy.io as default if the user doesn't pass
companionUrl.
I already added default url in line 61 of uppy-angular.component.ts. Do
you have another suggestion?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/adritasharma/uppy-angular-library/pull/13#issuecomment-767842755,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7KMU67DXMEC6JDT7EDIWLS34YRTANCNFSM4VKF7LJA
.


Flat map serializes output when using observable<>::create

Hi all! We encountered this issue when using flat_map operator, as defined in documentation flat_map internally merges emisions of the CollectionSelector function. When using range in said function the output is as expected:
TEST(RxcppThreading, FlatMap){
    auto values = rxcpp::observable<>::range(1, 3)
        .flat_map(
            [](int v){
                return observable<>::range(1, 4);
            },
            [](int v_main, int v_sub){
                return std::make_tuple(v_main, v_sub);
            });

    values.subscribe(
            [](std::tuple<int, int> v){printf("OnNext: %d - %ld\n", std::get<0>(v), std::get<1>(v));},
            [](){printf("OnCompleted\n");});
}

Output:
OnNext: 1 - 1
OnNext: 1 - 2
OnNext: 2 - 1
OnNext: 1 - 3
OnNext: 2 - 2
OnNext: 3 - 1
OnNext: 1 - 4
OnNext: 2 - 3
OnNext: 3 - 2
OnNext: 2 - 4
OnNext: 3 - 3
OnNext: 3 - 4

But when using the create function all outputs are seralized for each source observable:
TEST(RxcppThreading, FlatMapCreate){
        auto values = rxcpp::observable<>::range(1, 3)
        .flat_map(
            [](int v){
                return observable<>::create<int>([](subscriber<int> s){
                    for (auto i = 0; i < 4; ++i){
                        if (!s.is_subscribed())
                            break;
                        s.on_next(i);
                    }
                    s.on_completed();
                });
            },
            [](int v_main, int v_sub){
                return std::make_tuple(v_main, v_sub);
            });

    values.subscribe(
            [](std::tuple<int, long> v){printf("OnNext: %d - %ld\n", std::get<0>(v), std::get<1>(v));},
            [](){printf("OnCompleted\n");});
}

Output:
OnNext: 1 - 0
OnNext: 1 - 1
OnNext: 1 - 2
OnNext: 1 - 3
OnNext: 2 - 0
OnNext: 2 - 1
OnNext: 2 - 2
OnNext: 2 - 3
OnNext: 3 - 0
OnNext: 3 - 1
OnNext: 3 - 2
OnNext: 3 - 3

Is this the expected behavior? Or there is somenthing we are missing?
We need to perform the flat_map operation using create with the emissions not serialized. If someone could give us a hand to workaround this, we will be very grateful.
Thanks in advance! :smiley:

current_thread is used so that multiple ranges interleave values even on a single thread. Not interleaving values can create infinite allocations inside some operators (zip is one culprit).
The create usage here is blocking in the subscribe function until the for loop completes. To get interleaving a loop cannot be used in create. Instead there must be some state and a function scheduled that sends one value and updates the state and reschedules itself.


Radio Inputs do not bind properly

I've attempted numerous Radio Input binding methods, and none of them work properly.
I have attempted the following:

 Male
 Female
 Other

Expected: None to be selected
Result: Male was selected, even though false was assigned to the attribute

 Male
 Female
 Other

Expected: Male to be selected, but only on 'true'
Result: Male was selected, and is selected regardless of what value is set to 'checked'.

constructor(){
this.checked_value = true;
}

 Male
 Female
 Other

Expected: Male to be selected
Result: Nothing is selected
Is there an explanation for this behavior? The checkbox element works fine, but the radio button defies logic. I am on the Release Candidate version of Aurelia.

There seems to be missing information in this post about how you are trying to bind.
Make sure to check the Cheat Sheet for documentation on various ways to bind radios and checkboxes.
http://aurelia.io/hub.html#/doc/article/aurelia/framework/latest/cheat-sheet/5
Scroll down to the section on radios from there.


Cleanup of nested imports

Bump flytekit to https://github.com/lyft/flytekit/pull/355 - this allows us to mostly get rid of the nested imports which will break when we change the folder name.

work on this isn’t done unf... the context_manager bit is still in there for one of the examples.  The issue is that that really is an internal piece of flytekit, but it's necessary in order to extend flytekit.  I think we need to split up the namespace between things that are user facing and things that are plugin-writer facing.

work on this isn’t done unf... the context_manager bit is still in there for one of the examples.  The issue is that that really is an internal piece of flytekit, but it's necessary in order to extend flytekit.  I think we need to split up the namespace between things that are user facing and things that are plugin-writer facing.

work on this isn’t done unf... the context_manager bit is still in there for one of the examples.  The issue is that that really is an internal piece of flytekit, but it's necessary in order to extend flytekit.  I think we need to split up the namespace between things that are user facing and things that are plugin-writer facing.

That would be great. Thank you so much

work on this isn’t done unf... the context_manager bit is still in there for one of the examples.  The issue is that that really is an internal piece of flytekit, but it's necessary in order to extend flytekit.  I think we need to split up the namespace between things that are user facing and things that are plugin-writer facing.

That would be great. Thank you so much


Open the Resource Initialisation Parameters as fully expanded.

Description
When opening a resource in the Resource Inspector the Resource
Initialisation Parameter window is fully collapsed by default, but
RenderDoc will remember how you expanded or collapsed the tree
if you switch between resources.  This change keeps that behavior
but starts the Resource Initialisation Parameter tree as fully
expanded. This saves developers from having to 'drill down' to the
parameter they are interested in every time they open a resource.

I don't want to make this change. Depending on the API this might mean an awful lot of noise to dig through as the number of functions and parameters in the resource initialisation section can vary a lot. There's also no particular guarantee that what the user wants is buried very deeply, it may only be one level deep meaning there's no particular benefit to doing this but a high degree of annoyance.
In general I err on the side of having programs not do something automatically on the hope that it's the right thing for the user, because I find that it's vastly more annoying to have a program do something automatically which I don't want than the mild benefit if the program does something automatically which I do want. In this case it's better to be conservative and let the user choose what they want to be visible rather than expanding everything.


influx_tsm bugfixes in 0.10.0

These changes were already made to the 0.10 branch, and should be included

:+1:

@joelegasse I disagree that the changes were a mess from a git perspective. I am willing to explain why not, if you like. However, thank you.

I misread your comment, then. I thought you were suggesting they weren't
cleanly integrated in to master, and that's why you submitted a separate
pull request. But looking at the timing, I just missed your PR when I
created mine...
On Feb 17, 2016 7:20 AM, "Jon Seymour"<EMAIL_ADDRESS>wrote:

@joelegasse https://github.com/joelegasse I disagree that the changes
were a mess from a git perspective. I am willing to explain why not, if you
like. However, thank you.
—
Reply to this email directly or view it on GitHub
https://github.com/influxdata/influxdb/pull/5704#issuecomment-185175984.

No problem. The original change that was there before #5704 was intended to resolve the conflict in 0.10.0 based on my misunderstanding that 0.10.0 would eventually be merged into master. Jason explained that this isn't what normally happens. I created #5709 which merged the changes back into master without knowing that you had rebased/cherry-picked the changes onto another branch and merged them that way.
All good - thanks for getting them in there.


Test lists

This plug doesn't seem to work friendly with test lists as described in the docs here - https://playwright.dev/docs/next/test-parallel#use-a-test-list-file
I'll got the run icons

but clicking them does this

and in the list file weirdly i'm only able to run the first one

Update looks like if you add a name you can run them both from the root

but you can't run individual tests even tho it indicates you can


Update samples to remove deprecated /master/ CDN

Fixes #2104
Changelog Entry

Fix #2104. Remove deprecated `/master/webchat**.js links from samples, by @corinagum in PR #2105

Description
Samples were previously using the /master/webchat**.js CDN. That package is no longer updated and needed to be changed to /latest/webchat**.js

Tests pass locally... investigating...

@compulim does the new scrollbar PR force scrollbars to show always?


CompileIoT.partValence can't rely on the cut-edges graph after optimisation

It's triggered by the optimiser running on the sub-graph(s), in particular it seems something odd is happening to the third partition. Before
Overlay (Overlay (Vertex (StreamVertex {vertexId = 4, operator = streamMap, parameters = ["(\\st->\"Incoming Message at Server: \" ++ st)","s"], intype = "String", outtype = "String"})) (Overlay (Vertex (StreamVertex {vertexId = 5, operator = streamWindow, parameters = ["(chop 2)","s"], intype = "String", outtype = "[String]"})) (Vertex (StreamVertex {vertexId = 6, operator = streamSink, parameters = ["mapM_
print"], intype = "[String]", outtype = "IO ()"})))) (Overlay (Connect (Vertex (StreamVertex {vertexId = 4, operator = streamMap, parameters = ["(\\st->\"Incoming Message at Server: \" ++ st)","s"], intype
= "String", outtype = "String"})) (Vertex (StreamVertex {vertexId = 5, operator = streamWindow, parameters = ["(chop 2)","s"], intype = "String", outtype = "[String]"}))) (Connect (Vertex (StreamVertex {vertexId = 5, operator = streamWindow, parameters = ["(chop 2)","s"], intype = "String", outtype = "[String]"})) (Vertex (StreamVertex {vertexId = 6, operator = streamSink, parameters = ["mapM_ print"], intype = "[String]", outtype = "IO ()"}))))

After
Overlay (Connect (Vertex (StreamVertex {vertexId = 4, operator = streamWindow, parameters = ["(chop 2)","s"], intype = "String", outtype = "[String]"})) (Vertex (StreamVertex {vertexId = 5, operator = streamMap, parameters = ["map ((\\st->\"Incoming Message at Server: \" ++ st))","s"], intype = "[String]", outtype = "[String]"}))) (Connect (Vertex (StreamVertex {vertexId = 5, operator = streamMap, parameters
= ["map ((\\st->\"Incoming Message at Server: \" ++ st))","s"], intype = "[String]", outtype = "[String]"})) (Vertex (StreamVertex {vertexId = 6, operator = streamSink, parameters = ["mapM_ print"], intype
= "[String]", outtype = "IO ()"})))

PR #86 should get the lights green again but I'll keep looking at the root issue.
Originally posted by @jmtd in https://github.com/striot/striot/issues/85#issuecomment-589018404

partValence is a helper function in CompileIoT to figure out the valence for a partition. It works by referencing a graph "cuts" of cut edges between vertices. However, if the optimiser runs, then those vertices may be out-of-date: they might have been replaced by others.
We could fix this by re-writing partValence but the goal is to move partitioning after optimisation which will also address it.

also connectNodeId and probably others

partValence has gone; connectNodeId remains.


Userstamp trying to set stamper when connecting to dB if not called

This is a weird one.  We have a simple monitoring routine in a controller called HealthController
Here is the method:
 def db
    sql = "SELECT true;"
    ActiveRecord::Base.establish_connection
    result = ActiveRecord::Base.connection.execute(sql)
    resp = result.first["bool"] == 't'

    respond_to do |wants|
      wants.json do
        if resp
          render json: {status: :ok}
        else
          render json: {status: :unprocessable_entity}
        end
      end
    end
end

In our controller spec when we try to do a simple GET from the health controller, we get an error.  Here is the spec:
RSpec.describe HealthController, :type => :controller do

  describe "GET db" do
    it "returns http success" do
      get :db, format: 'json'
      expect(response).to have_http_status(:success)
    end
  end

end

And here is what we see:
1) HealthController GET db returns http success
     Failure/Error: get :db, format: 'json'

     NameError:
       undefined local variable or method `current_user' for #<HealthController:0x007fb202cae480>
       Did you mean?  current_ability
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activerecord-userstamp-3.0.4/lib/active_record/userstamp/controller_additions.rb:34:in `set_stamper'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activerecord-userstamp-3.0.4/lib/active_record/userstamp/controller_additions.rb:21:in `with_stamper'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:432:in `block in make_lambda'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:312:in `block in halting'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:497:in `block in around'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:505:in `call'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:92:in `__run_callbacks__'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:778:in `_run_process_action_callbacks'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:81:in `run_callbacks'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/actionpack-4.2.9/lib/abstract_controller/callbacks.rb:19:in `process_action'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/actionpack-4.2.9/lib/action_controller/metal/rescue.rb:29:in `process_action'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/actionpack-4.2.9/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activesupport-4.2.9/lib/active_support/notifications.rb:164:in `block in instrument'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activesupport-4.2.9/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activesupport-4.2.9/lib/active_support/notifications.rb:164:in `instrument'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/actionpack-4.2.9/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/actionpack-4.2.9/lib/action_controller/metal/params_wrapper.rb:250:in `process_action'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/activerecord-4.2.9/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/actionpack-4.2.9/lib/abstract_controller/base.rb:137:in `process'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/actionview-4.2.9/lib/action_view/rendering.rb:30:in `process'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/actionpack-4.2.9/lib/action_controller/test_case.rb:639:in `process'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/actionpack-4.2.9/lib/action_controller/test_case.rb:67:in `process'
     # /Users/jlippiner/.rvm/gems/ruby-2.4.1@dmvcs/gems/actionpack-4.2.9/lib/action_controller/test_case.rb:514:in `get'
     # ./spec/controllers/health_controller_spec.rb:7:in `block (3 levels) in <top (required)>'

Finished in 0.7188 seconds (files took 7.26 seconds to load)
1 example, 1 failure

Why would userstamp be involved at all in this?

Update - apparently it has NOTHING to do with the method being called as it crashes well before:
Here are the routes:
Rails.application.routes.draw do

  get "health/db"
  get "health/app"

And we can have an empty method in the health controller:
def app
end

and it will still crash with the same error.

Another update:
Adding a current user method to the HealthController fixed the issue:
  def current_user
    nil
  end

BUT this still doesnt explain why it was called in the first place.

This is because ActiveRecord Userstamp sets the stamper for the lifetime of the request when flow of control is given to the controller. This is so that users do not have to explicitly set the stamper at the entry of every request.
I would imagine most controllers would have the current_user method; AFAIK Devise would just return nil for controllers which do not require authentication. Is that not the case for you?

The behaviour is included in controller_additions.rb


here maps api is not working in amenities.

@pjflux2001 check this.

which browser is this?

@pjflux2001 check this.
https://care-quest.herokuapp.com/amenities

fixed


Add an option to strictly respect the external value

Currently, if you use :modelValue without @update:modelValue actually changing the external value of Multiselect, upon selecting an option in the dropdown, Multiselect value will be changed because of internal values. This may be desired behavior sometimes, but sometimes not.
For example, let's say that some request is made upon changing the value (on @update:modelValue event), if the request fails, external value won't change, but Multiselect will internally change the value creating an inconsistency between the states.
Maybe an option like strictlyExternal or similar should be added?

Also, when external value is set to something that is not present in the options, the value is not respected and won't be shown as selected. To me, external value should always be respected;
Anyway, when building input components I find the pattern in vueuse/usevmodel to be the best. Notice the passive option. Similarly the multiselect component should be able to work in both statefull ( with internalValue ) and stateless ( internalValue should be nothing more than computed based on external value ) mode.


BUG Fix regressions in asset resize behaviour change

Fixes regressions from https://github.com/silverstripe/silverstripe-assets/pull/101

Green :D


[docs] Update date-fns example

Description
I would like to expand date-fns example in the docs with some approaches to customise formatting when date-fns locale object defaults are not appropriate. Since date-fns is very often used for localisation, I believe this is a natural place for more customisation examples. I have also added a link to format customisation guide to this page.
My friend and I were recently bitten by this. She was implementing a picker in tandem with date-fns, and the months were declined incorrectly for that case. Since the issue concerned a particular locale, googling around didn't really help. I then decided to review the docs again and managed to stumble upon Global format customisation guide after quite a bit of digging.
I have also added grammar and style fixes to some of the pages that I had time to  review.
Thank you very much!

Something like this? I've added a new section to the date-fns page and moved customised example to a separate file.

I am sorry but I cannot push to your fork. Please commit the suggestion

No problem! I don't think particular formatting is a big deal here for me, since I'd rather concentrate on showcasing various custmomisation options for the pickers. I wouldn't want people hacking on date-fns before trying these out.
Made both suggested changes.


Is this package still maintained?

Hi,
I'm just wondering if this package is still alive. In general it still works with Angular 11 but there where a lot of missing peer dependencies during compilation. It would be so great if the package.json could be updated.
Best regards
Lars

Angular 12 support in 6.0.0

From my point of view there is a gap for Angular 11 in the dependencies between 5.4 and 6.0. When you are on Angular 11, angular/common: 11.2.113 needs at least cdk > 10.
This library requires cdk < 10 in 5.4.0 and cdk 12 in 6.0.0. However you can't update to cdk 12 because it requires Angular 12.


[WIP] use project_name defined as a variable in role defaults

I believe this has conflicts with master now.

This may not actually work. Ansible 2.x seems to have a difficult time doing double variable expansion, and I don't know of a way forward on it. So I'd say abandon this for now.

Closing, don't think this works. Re-open if you can make it work.


Client-side ad stuck when VAST response is empty or response fails

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
3.0.7
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from master?
Yes
Are you using the demo app or your own custom app?
Custom app. Example: https://jsfiddle.net/byxa1Lqs/
If custom app, can you reproduce the issue using our demo app?
No
What browser and OS are you using?
Chrome 87 on MacOS 10.15.7
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
Any content, e.g. http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4
What did you do?
Get the ad manager, load the content, call initClientSide(), then call requestClientSideAds() with an ad tag URL where the VAST response does not contain valid ads, e.g. https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/124319096/external/single_ad_samples&ciu_szs=300x250&impl=s&gdfp_req=1&env=vp&output=vast&unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ct%3Dredirecterror&nofb=1&correlator=
This is the Single Redirect Error example from the IMA sample tags page. I can also reproduce similar behavior by using Charles Proxy to block the ad request.
What did you expect to happen?
The ad manager fires an AD_STOPPED event and resumes the main content.
What actually happened?
The ad manager does not fire any events. There is no indication that there was an IMA SDK error, so our application is stuck without playback.
It looks like the issue is here: https://github.com/google/shaka-player/blob/master/lib/ads/client_side_ad_manager.js#L73. Based on the IMA SDK docs, the event type should be google.ima.AdErrorEvent.Type.AD_ERROR instead of google.ima.AdEvent.Type.AD_ERROR. The same applies to line 198. With the current code, google.ima.AdEvent.Type.AD_ERROR evaluates to undefined so the error isn't being caught.

I mentioned "The same applies to line 198", but this line is actually fine. So the issue is just on line 73, and #3105 should fix the problem.

I mentioned "The same applies to line 198", but this line is actually fine. So the issue is just on line 73, and #3105 should fix the problem.


Use lock_guard instead of bare lock and unlock

It is recommendedto use std::lock_guard or std::unique_lock to lock the mutex instead of manually lock and unlock it.

https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-raii

And it is said that manual unlock may fail when the code throws an exception before the unlock, and indeed this could happen in RealtimeFeedbackTcpInterface of the previous implementation.
This pull request replace the bare lock and unlock with std::lock_guard.

OK. I'll check it.


'event' parameter missing on handleHorizontalTrackMouseDown

I noticed that clicking on the horizontal track in Firefox didn't cause the thumb to move, while the vertical scrollbar seems to be working correctly. Both scrollbars work fine in Chrome.
The problem is with a missing event parameter in handleHorizontalTrackMouseDown().

Thx for reporting. I'll put it on the roadmap