Cannot rename Node in a scene

Godot version:
3.1 Official
Issue description:
In one of my project, I have a scene (just one scene) where I cannot rename any of the children Node by double clicking the name of the Node or by right clicking and select Rename menu item. Selecting Rename menu item gives me the ability to edit the name but the change won't take effect (after pressing Enter, the name remains unchanged)
What is expected (obviously) is that I can rename all the node that are not packed in a subscene in the current scene.
Steps to reproduce:
Unfortunately, I've no idea of what provoked this issue and how to reproduce it. To see this bug in action, just grab the project linked below.
Please note that this problem also occurs  when I try to open the 3.0 version of this project
Minimal reproduction project:
It's worth noting that the only scene where the problem occurs is the main scene (Level.Tscn)
FurryBirds.zip
EDIT: Okay, I figured out what the problem comes from : One of the child is in tool mode and draws a trajectory by adding children to the scene. This somehow has to do something with this renaming issue. Deactivating trajectory drawing solves the problem. But still I would not say there is no issue here.

The problem is not that it is a tool script, but probably because the tool script is adding and removing nodes to the tree every frame. This is also causing high cpu usage and scene tree editor is slow to respond to input. I'd say it's still a bug though.
You should probably find a way to draw the trajectory without adding/removing nodes, and/or only do it when there is a change in trajectory.

Thanks for the answer. All the options you propose are correct and I managed to solve my problem. I do agree with you, there is actually a bug here and it is probably linked with removing adding children (intensive cpu usage cannot explain this behaviour since the editor is still responding quite fast to anything else).

Yea the issue is definitely the constant adding/removing of nodes, the cpu usage is just a reason not to do it.

This is not a bug. Adding and removing nodes will refresh the scene tree, which makes the double-click impossible (because refresh happens between clicks) and cancels the renaming. You can see what happens if you add spot.owner = self under $Trajectory.add_child(spot).
Maybe engine could handle it better, e.g. by not refreshing scene tree on nodes that the scene doesn't own (and thus they are invisible in the tree), but IMO it's not worth it. It's incorrect tool script usage. Even if the "bug" was fixed, removing and adding many nodes each frame is still a bad idea.


Create 2017-08-01

Description of the change: adding Email Protection to release notes

Hello @missybreck,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX

I am closing this because I combined it with the other one! you should still get the hacktoberfest points though!


Light issues in first person

There are some lighting bugs on skin in first person (see picture). It happens even when bEnableShadows is disabled.

bEnableShadows is placebo currently as it's not implemented.
However the lighting issues is possibly due to fNearDistance activating to allow seeing the body fully.

Changing fNearDistance to high or low values still does not seem to alleviate the issue. This problem was not present in improved camera 1 if that helps.

If it is still doing it with:
fNearDistanceFirstPerson=15.000000
I have no idea as there are too many mods that affect lighting and we don't touch lighting at all. We are aware of NearDistance screwing things up in outdoor areas which is mainly shadows going haywire. However if above is set to 15 and your still seeing it, another mod has to be the issue (might be multiple) regardless of IC version, even the very old beta1.

I have found out that this is caused by bloom effects from ENB, when bloom is turned off this issue disappears. Not sure why this was not present in IC 1.

Could be due to an enb update


DETR: Why the AP is still zero?

I use DETR to be my model. However, by the time consumed, the mAP is still zero! How can I fix it? Thanks for your time!
@env Google Colab Pro, Tesla P100 x 1
2022-01-23 09:34:04,450 - mmdet - INFO - Epoch [30][1700/1914]	lr: 1.000e-04, eta: 1 day, 0:53:57, time: 0.310, data_time: 0.007, memory: 2682, loss_cls: 0.6340, loss_bbox: 0.7269, loss_iou: 0.9467, d0.loss_cls: 0.6340, d0.loss_bbox: 0.7455, d0.loss_iou: 0.9307, d1.loss_cls: 0.6149, d1.loss_bbox: 0.7628, d1.loss_iou: 0.9419, d2.loss_cls: 0.6299, d2.loss_bbox: 0.7469, d2.loss_iou: 0.9007, d3.loss_cls: 0.6271, d3.loss_bbox: 0.7629, d3.loss_iou: 0.9817, d4.loss_cls: 0.6057, d4.loss_bbox: 0.7296, d4.loss_iou: 0.9133, loss: 13.8352, grad_norm: 122.4885
2022-01-23 09:34:19,980 - mmdet - INFO - Epoch [30][1750/1914]	lr: 1.000e-04, eta: 1 day, 0:53:21, time: 0.311, data_time: 0.007, memory: 2682, loss_cls: 0.8577, loss_bbox: 0.9509, loss_iou: 1.0904, d0.loss_cls: 0.8779, d0.loss_bbox: 0.9118, d0.loss_iou: 1.0630, d1.loss_cls: 0.8663, d1.loss_bbox: 0.9445, d1.loss_iou: 1.0946, d2.loss_cls: 0.8329, d2.loss_bbox: 0.9296, d2.loss_iou: 1.0548, d3.loss_cls: 0.8339, d3.loss_bbox: 0.8931, d3.loss_iou: 1.0901, d4.loss_cls: 0.8285, d4.loss_bbox: 0.9316, d4.loss_iou: 1.1168, loss: 17.1683, grad_norm: 111.5039
2022-01-23 09:34:35,550 - mmdet - INFO - Epoch [30][1800/1914]	lr: 1.000e-04, eta: 1 day, 0:52:48, time: 0.311, data_time: 0.007, memory: 2682, loss_cls: 0.6407, loss_bbox: 0.7397, loss_iou: 0.8846, d0.loss_cls: 0.6558, d0.loss_bbox: 0.7460, d0.loss_iou: 0.8977, d1.loss_cls: 0.6353, d1.loss_bbox: 0.7861, d1.loss_iou: 0.9433, d2.loss_cls: 0.6239, d2.loss_bbox: 0.7578, d2.loss_iou: 0.9046, d3.loss_cls: 0.6196, d3.loss_bbox: 0.7555, d3.loss_iou: 0.9204, d4.loss_cls: 0.6080, d4.loss_bbox: 0.8734, d4.loss_iou: 0.9794, loss: 13.9719, grad_norm: 111.2883
2022-01-23 09:34:51,085 - mmdet - INFO - Epoch [30][1850/1914]	lr: 1.000e-04, eta: 1 day, 0:52:14, time: 0.311, data_time: 0.007, memory: 2682, loss_cls: 0.6424, loss_bbox: 0.7029, loss_iou: 0.8696, d0.loss_cls: 0.6646, d0.loss_bbox: 0.7212, d0.loss_iou: 0.9079, d1.loss_cls: 0.6477, d1.loss_bbox: 0.7490, d1.loss_iou: 0.9256, d2.loss_cls: 0.6392, d2.loss_bbox: 0.6808, d2.loss_iou: 0.8410, d3.loss_cls: 0.6441, d3.loss_bbox: 0.7481, d3.loss_iou: 0.9541, d4.loss_cls: 0.6445, d4.loss_bbox: 0.7538, d4.loss_iou: 0.8992, loss: 13.6358, grad_norm: 104.3842
2022-01-23 09:35:06,607 - mmdet - INFO - Epoch [30][1900/1914]	lr: 1.000e-04, eta: 1 day, 0:51:39, time: 0.310, data_time: 0.006, memory: 2682, loss_cls: 0.6657, loss_bbox: 0.8133, loss_iou: 0.9617, d0.loss_cls: 0.6715, d0.loss_bbox: 0.6973, d0.loss_iou: 0.9084, d1.loss_cls: 0.6466, d1.loss_bbox: 0.6913, d1.loss_iou: 0.9413, d2.loss_cls: 0.6491, d2.loss_bbox: 0.6960, d2.loss_iou: 0.9029, d3.loss_cls: 0.6462, d3.loss_bbox: 0.8051, d3.loss_iou: 0.9619, d4.loss_cls: 0.6788, d4.loss_bbox: 0.7287, d4.loss_iou: 0.9151, loss: 13.9811, grad_norm: 110.2449
2022-01-23 09:35:10,988 - mmdet - INFO - Saving checkpoint at 3 epochs
[>>] 425/425, 15.0 task/s, elapsed: 28s, ETA:     0s2022-01-23 09:35:52,119 - mmdet - INFO - Evaluating bbox...
Loading and preparing results...
DONE (t=0.16s)
creating index...
index created!
Running per image evaluation...
Evaluate annotation type *bbox*
DONE (t=1.02s).
Accumulating evaluation results...
DONE (t=1.00s).
2022-01-23 09:35:54,548 - mmdet - INFO -
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.000
 Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=1000 ] = 0.000
 Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=1000 ] = 0.000
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= small | maxDets=1000 ] = 0.000
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=medium | maxDets=1000 ] = 0.000
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= large | maxDets=1000 ] = 0.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=300 ] = 0.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=1000 ] = 0.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= small | maxDets=1000 ] = 0.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=medium | maxDets=1000 ] = 0.002
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= large | maxDets=1000 ] = 0.000

DETR takes a very long time to converge.
Longer training might improve AP, considering Average Recall     (AR) @[ IoU=0.50:0.95 | area=medium | maxDets=1000 ] = 0.002.
Practically, it is better to use other methods (e.g., Deformable DETR) or pre-trained weights by load_from = 'https://download.openmmlab.com/mmdetection/v2.0/detr/detr_r50_8x2_150e_coco/detr_r50_8x2_150e_coco_20201130_194835-2c4b8974.pth'

@shinya7y Thanks for your time! I will take your useful advice. By the way, there maybe something wrong with Deformable DETR when using. I have tried mmcv 1.4.3 and mmcv 1.4.2, resulting the same error below, called RuntimeError: cuDNN error: CUDNN_STATUS_NOT_INITIALIZED. How can I fix it now?
2022-01-23 09:34:39,343 - mmdet - INFO - workflow: [('train', 1)], max: 50 epochs
2022-01-23 09:34:39,344 - mmdet - INFO - Checkpoints will be saved to /content/gdrive/MyDrive/mmdetection/work_dirs/deformable_detr_r50_16x2_50e by HardDiskBackend.
/usr/local/lib/python3.7/dist-packages/mmdet/models/utils/positional_encoding.py:81: UserWarning: __floordiv__ is deprecated, and its behavior will change in a future version of pytorch. It currently rounds toward 0 (like the 'trunc' function NOT 'floor'). This results in incorrect rounding for negative values. To keep the current behavior, use torch.div(a, b, rounding_mode='trunc'), or for actual floor division, use torch.div(a, b, rounding_mode='floor').
  dim_t = self.temperature**(2 * (dim_t // 2) / self.num_feats)
/usr/local/lib/python3.7/dist-packages/torch/functional.py:445: UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at  ../aten/src/ATen/native/TensorShape.cpp:2157.)
  return _VF.meshgrid(tensors, **kwargs)  # type: ignore[attr-defined]
Traceback (most recent call last):
  File "tools/train.py", line 196, in <module>
    main()
  File "tools/train.py", line 192, in main
    meta=meta)
  File "/usr/local/lib/python3.7/dist-packages/mmdet/apis/train.py", line 209, in train_detector
    runner.run(data_loaders, cfg.workflow)
  File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/epoch_based_runner.py", line 127, in run
    epoch_runner(data_loaders[i], **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/epoch_based_runner.py", line 51, in train
    self.call_hook('after_train_iter')
  File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/base_runner.py", line 309, in call_hook
    getattr(hook, fn_name)(self)
  File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/hooks/optimizer.py", line 56, in after_train_iter
    runner.outputs['loss'].backward()
  File "/usr/local/lib/python3.7/dist-packages/torch/_tensor.py", line 307, in backward
    torch.autograd.backward(self, gradient, retain_graph, create_graph, inputs=inputs)
  File "/usr/local/lib/python3.7/dist-packages/torch/autograd/__init__.py", line 156, in backward
    allow_unreachable=True, accumulate_grad=True)  # allow_unreachable flag
RuntimeError: cuDNN error: CUDNN_STATUS_NOT_INITIALIZED

Please discuss in # 7017.

Ok, thanks!

What is the meaning of "8x2" in the config name? This naming is different from other models' config naming but there is no explanation, which makes me confused. I look forward to your reply!

What is the meaning of "8x2" in the config name? This naming is different from other models' config naming but there is no explanation, which makes me confused. I look forward to your reply!

@sibet-lb Hello, I guess that the 8 means num_heads=8 and the 2 means worker_per_gpu=2, samples_per_gpu=2. Do you think so?

[gpu x batch_per_gpu]: GPUs and samples per GPU, 8x2 is used by default.

https://github.com/open-mmlab/mmdetection/blob/master/docs/en/tutorials/config.md#config-name-style


Search IRC filter by Ingame and Rating Bracket

Search IRC filter by Ingame and Rating Bracket. This would be a great feature to see the pool of users available you are trying to pull with a single game.

#127


has two values when inference?Can you explain what the second value is

Hello, I found that the output is two values when inference. Can you explain what the second value is?

Hi xingjunhong
The first value is the normalized feature vector and the second value is the feature norm.

thank


Use "destroy()" to close connection on missing heartbeat

Mandatory heartbeat was added in: https://github.com/cargomedia/socket-redis/pull/72
Unfortunately it doesn't seem to work reliably. We still have connections open on socket-redis, that don't receive any data. See investigation here.
I think we should destroy() the SockJSConnection, instead of close()ing it.
@vogdb could you do the change?

@njam please review

lgtm


Is jQuery necessary?

Related with issue #53 @themsaid said that Wink was longer using Bootstrap. So the bootstrap dependency was removed as well as popper.js. Shouldn't we also remove the jQuery dependency?

I think we can remove it yes
Sent from my iPhone

On Nov 19, 2018, at 12:47 AM, João Santos<EMAIL_ADDRESS>wrote:
Related with issue #53 @themsaid said that Wink was longer using Bootstrap. So the bootstrap dependency was removed as well as popper.js. Shouldn't we also remove the jQuery dependency?
If so, I can provide a PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

removed


Connectors

Hello, first of all I'd like to thank you for plugin, great job, and also have question do you maybe planning to create text with images on background or more complikated shapes than rectangle, and do you planing maybe to create connectors from one text/shape to another?
Thank you :)

Hi @Szymon-dziewonski ,
Thanks for the feedback!

no plans for connectors as of yet
I've actually never seen a text shape with a background image before, but I'll investigate o get an LOE
there is definitely more than rectangles - hundreds of other shapes are in the pptxgen.shapes.js file

Thank you for quick respond :)
That's great news, and great to know that there are more shapes (there's no
info in documentation unfortunately :( )
Thanks once again
2017-03-09 6:38 GMT+01:00 Brent Ely<EMAIL_ADDRESS>
Hi @Szymon-dziewonski https://github.com/Szymon-dziewonski ,
Thanks for the feedback!

no plans for connectors as of yet
I've actually never seen a text shape with a background image
before, but I'll investigate o get an LOE
there is definitely more than rectangles - hundreds of other shapes
are in the pptxgen.shapes.js file

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitbrent/PptxGenJS/pull/50#issuecomment-285259573,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACcoCCjq4r9eVwAofmulWWBb_Qc7uxMnks5rj5BCgaJpZM4MWgKZ
.

--
Pozdrawiam,
Szymon Dziewoński
www.szymondziewonski.com


XLA LuDecomposition support for CPU/GPU

System information

TensorFlow version (you are using): 2.8
Are you willing to contribute it (Yes/No): No

Describe the feature and the current behavior/state.
xla::LuDecomposition in tensorflow/compiler/xla/client/lib/lu_decomposition.h is currently only implemented for TPU. I'd like to be able to use it on CPU and/or GPU.
Will this change the current api? How?
Yes, but in a backwards compatible way.
Who will benefit with this feature?
Anyone wanting to build on XLA and do LU decomposition for e.g. calculating determinants. I want this as I'm building an API for XLA in Idris.

I realise I don't need this any more, but I'll leave it open since it's a TODO in XLA already. Feel free to close if you think that's best

Hi @tilakrayal how would you like me to elaborate?
This would be helpful for calculating the inverse of matrices


ttnn bert

[x]  Re-write tt_lib implementation of BERT using ttnn to figure out missing functionality of ttnn needed to run sharded models: https://github.com/tenstorrent-metal/tt-metal/blob/main/models/experimental/functional_bert/tt/ttnn_optimized_functional_bert.py
[ ] Use sharded tensors to run ttnn BERT

Bert was delivered by @arakhmati


Quality Badges for Non-Standard Bitrates

Not sure whether this is intended or not but Swing does not show the quality badge (displaying the file type and bit rate) when playing an OPUS audio file with a non-standard bitrate...
Here is a few others for comparison. Even the bitrate for FLAC files is shown properly...

@sortedcord
That's interesting! Drop the specific file for reproduction on Telegram. I'll check on it later.


Static Class Prototype

Not ready for merge
This can't be merged and tested until the event loop driver interface is merged.
For those not in the know, this follows on from the discussion in #14 and attempts to solve the problem of being able to access the event loop without injecting it as a dependency anywhere.
The solution that I favour discussed in #14 is represented in this PR. I believe it represents a happy medium between injecting the event loop everywhere and global god classes. The life time of an event loop is easily defined by the scope within which it is invoked.
Example usage:
use Interop\Async\EventLoop;
use AsyncProject\LibEvDriver;

// ...

EventLoop::execute(function () {
    // This callback will be run within the scope of the specified event loop driver

    // ...

    EventLoop::onReadable($inputStream, $inputStreamHandler);
    EventLoop::onWritable($outputStream, $outputStreamHandler);
}, new LibEvDriver());

There is also an argument that this should live in a separate repository. Unlike the interface for the event loop driver (which we cannot change after publishing) - this is a code file which needs unit tests and could require maintenance. Also, if you are implementing the event loop driver you likely don't need to use this class - as it's intended for consumers.

I think we can keep both in one repository, I don't really care. Any application requires both anyway. Just loop drivers might not need it, but even they might want to use the global accessor in unit tests.

Even further, a number of packages that provide loop drivers also provide a lot more core functionality as well. Just look at the Icicle and Amp core packages. It makes sense I think to keep them together.

@WyriHaximus @trowski @assertchris
Can I have your thoughts on this approach? It's quite a significant deviation from our initial ideas and has some significant implications (requiring a test suite [phpunit?], static state, etc...) that I'd like as many thoughts on as possible.
If anyone has any alternative suggestions then a separate pull request (such as @coderstephen 's) would make it easy to compare all of our options more objectively.

I have a few reservations about this implementation:

inScope() should be part of get(), then always use get() to access the loop instance.
I would still like to see set() and drop() methods in addition to execute()/with()
Methods should have return type declarations (though we may want to settle the watcher ID vs. object issue)
Perhaps execute() should throw if there is an event loop set that is running? Running an event loop within another loop seems like a bad idea.
Should there be a method to check if the loop is running? isRunning()? Maybe another to check if a loop instance is set?

Whether inscope() is part of get() or not doesn't really matter...?
What would you need set() and drop() for?
Return type decls are nice, but are we targeting 7.0+ only?
The point is pretty much to allow nesting of event loops. To block everything else from running, but still dispatch a separate loop. (e.g. in a register_shutdown_function where state may be inconsistent, but we still can run a new event loop on top of the current one to guarantee some task to be run)
No, we don't need such a method, we can suppose to always be inside an event loop (everything else would error then). If you aren't in an event loop and accessing it (apart form execute()) that's a programmer mistake.

inScope() is a "side-effect" style function that just bothers me. Technically it doesn't matter, but I think return self::get()->method(...) is more elegant than calling a method to check if a variable is not null before using it.
I was thinking of using set() and drop()for testing, but since execute() automatically "drops" the loop instance after running, maybe the methods aren't needed.
Generally I was considering a nested event loop to be an error, but if this is something we want to allow, then this works.

I don't mind this approach, but I'm starting to think that a separate repo would be better. If we make a breaking change to the impl, the interfaces get a major version bump? :(

If you still are considering the set()/drop() approach as an alternative, I updated #13 so that we can compare and discuss.

Here are my thoughts on the discussion:

I like the idea of an isRunning() method. 'nuff said for that.
The execute() closure-style isn't particularly bad, but the design seems optimized for the use-case of multiple event loops in one program, which I thought isn't something we were trying to encourage (not that it should necessarily be forbidden).
Using a closure makes scope clear in the file in which execute() is called, but I don't think it helps much anywhere else in a program.
There are technical issues with closures and multithreading; absolutely requiring a closure in order to set up the event loop initially may or may not be an issue. I don't have a solid answer to that. Similarly, how will this affect forking inside an event loop scope? There needs to be a way to simply discard all event loops from the parent process cleanly, which I'm not sure the strict execute() approach allows. Forking doesn't treat previous scoping nicely in that regard.

@assertchris I'm not against putting this in a separate repo, but any package using the interface is almost for sure going to use the static class too.

For the sake of have the discussions in one place we can keep it in this repo for now and move it later on when things matured more.

@AndrewCarterUK Typo in your commit message maknig. Otherwise I'm fine with merging it for now, so I can base my work for #16 on it.

Merged so you can continue with the PR discussed in #16


[MWPW-140190] - Blog Visual Fixes

Resolves: MWPW-140190
Description:
Issue#1

Removed the default section paddings in styles.css due to it creating a lot of extra whitespace when a section has only one block (due to it being wrapped). Since the goal is to slowly move into how Milo does section-metadata section spacing, we could potentially start introducing the Milo way when ready, however, temporarily, padding has been added in the utils.js to fix the current pages and not make it break.

Issue#2

Added an if condition to check if it's in blogs, as the rest still needs the 'free use forever' widget and it gets added on each first column.

Test URLs:
Issue#1 (white space padding, particularly on mobile ver)

Before: https://main--express--adobecom.hlx.page/express/learn/blog?martech=off
After: https://mwpw-140190--express--adobecom.hlx.page/express/learn/blog?martech=off

Issue#2 (remove 'free use forever')

Before: https://main--express--adobecom.hlx.page/express/learn/blog/tags/featured?martech=off
After: https://mwpw-140190--express--adobecom.hlx.page/express/learn/blog/tags/featured?martech=off

Codecov Report
Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (932fdd2) 31.94% compared to head (ec4fb73) 31.80%.
Report is 2 commits behind head on stage.

Files
Patch %
Lines

express/scripts/utils.js
0.00%
9 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #533      +/-   ##
==========================================
- Coverage   31.94%   31.80%   -0.15%
==========================================
  Files         126      126
  Lines       24116    24128      +12
==========================================
- Hits         7705     7674      -31
- Misses      16411    16454      +43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

why is there a do not merge label? should this not be reviewed and merged?

As I've understood it this PR should only be adjusting the padding for the blog. I shouldn't therefore be seeing changes to the padding in the third section of this page for example - https://mwpw-140190--express--adobecom.hlx.page/express/feature/image/resize?martech=off

Hey Victor! Sorry I didn't see your comment. Yes, it's for the extra space for the blog page (especially on mobile) for example:
https://main--express--adobecom.hlx.page/express/learn/blog?martech=off
However, those extra spaces are from the general styles.css section margin. So it will affect the other pages' sections.

This also is related to this issue: https://jira.corp.adobe.com/browse/MWPW-139409

so I thought it would be hitting two birds with one stone.
I added fixed paddings manually to the ones that will be affected by removing the .section margin throughout the whole express site so that it would still look good. Because the white spacing is caused by the blocks' own margin/padding on top of the .section margins. And since we're moving to Milo and adding the section metadata, those would have to be erased anyway to create a new value.
I think this is also the ongoing discussion between the devs and the pms about the white spacing that I've stumbled upon on slack?

@redvelvet511 no worries! I only wrote the message yesterday.
I do really like the initiative. The issue currently is that I've quickly found an example where the paddings do not look good. Please compare the padding of the third section of this page with main - https://main--express--adobecom.hlx.page/express/feature/image/resize?martech=off
Since I found this pretty quickly it wouldn't surprise me if there are other examples where the padding is now off. In my opinion it would therefore be better to simply focus on solving the initial task, since the current solution is not "stable".


Enviroment crash when map is created

More info here:
https://www.kaggle.com/code/agenlu/enviroment-error

seems to be fixed in new version


Feature suggestion: BulkInsertOrUpdateOrDelete expression filter

The "BulkInsertOrUpdateOrDelete" method would be even more powerful if you could use it to synchronize just part of a table:
public static void BulkInsertOrUpdateOrDelete<T>(
   this DbContext context, IList<T> entities, Expression<Func<T, bool>> mergePredicate = null/*, ...*/)

The mergePredicate could then be used to build a CTE for the merge target.
(The discussion at https://github.com/linq2db/linq2db/issues/1166 has bearing on this.)

this too helpful to check removed data from source in specific parameter (sources that have limitation)
i use this way but there some data from another sources will lost
GetQuerable().Where(x => x.commonProperty == commonProperty).BatchDeleteAsync();
BulkInsertOrUpdate(hugeData, b => b.PropertiesToExclude = new List<string> { "anotherSourceData" });

hugeData => can't check one by one if its removed from source

Could you leave some pseudocode as to how you'd map my proposed syntax (i.e. db.BulkInsertOrUpdateOrDelete<Widget>(items, x => x.Code == "C")? The new feature seems to solve a different problem.

You are right, new feature can filter columns, not rows.
I'm not sure how to implement expression filter.
You could get needed result the following way:
Load into memory (ToList or ToDictionary) all required q = ItemsSet.Where(a => a.Code == "C")
and then split it into 2 Lists for calls to BulkInsertOrUpdate followed by BulkDelete.

I was thinking you could use the expression filter to build a CTE and filter on that CTE.
As an aside, this library is awesome. Thank you ❤

I'll take a lot when I find the time, meanwhile if you think you could make a PR send one.
Glad it's useful.


opensearchVersion of tag 2.1.0 should be 2.1.0

gradle.properties:
opensearchVersion = 2.0.1

#9 had been opened by @maglore to address a while ago but went unanswered so far 😢


streamalert - carbonblack schema changes - round 1

to: @ryandeivert
cc: @airbnb/streamalert-maintainers
What

Fixed Carbonblack schemas that were denoting timestamp as a string, when in fact it's a float.

Example:
{
  "cb_server": "...",
  "cb_version": "...",
  "computer_name": "...",
  "feed_id": 123,
  "feed_name": "...",
  "from_feed_search": false,
  "group": "...",
  "hostname": "...",
  "ioc_attr": {},
  "ioc_type": "...",
  "ioc_value": "...",
  "md5": "...",
  "os_type": "...",
  "report_id": "...",
  "report_score": 123,
  "sensor_id": 123,
  "server_name": "...",
  "timestamp":<PHONE_NUMBER>.021,
  "type": "feed.ingress.hit.binary"
}

Fixed carbonblack:ingress.event.netconn, which occasionally does not have the local_ip and local_port keys

Added the feed.ingress.hit.binary schema

Testing
python stream_alert_cli.py lambda test --processor all
(14/14)	Rule Tests Passed
(50/50)	Alert Tests Passed

Coverage remained the same at 79.307% when pulling b52cdc1bfcabcc3c267d83e9e5ed6abbf6f20060 on mf-carbonblack-schema-modifications into 68ace7f6b30dc60a851e0e95f3117740c5ec0093 on master.


Multi-thread push/pull

When I tried to push a lot of small files (size~1M), it cost more time to finish than a whole file at same size.
If drive push/pull multiple files at the same time, it will reach a higher speed.

Oh, the 1000th issue!

Yeah, it would be about time to have a multithreaded approach (especially as languages have the capability of seeing how cores are available on a machine).


evaluation result is inconsistent with Table1 of  the paper on the ppm100

I evaluate using mam_vitl.pth on the ppm100, and the following picture is result.

It is inconsistent with Table1 of  the paper.

The result you got is the SAD / MAD / MSE result on PPM-100 and Table 1 is a summary table for all benchmarks (e.g. 17.30 is for AM2K, 15.4 is for PM-10K and 4.6 is for PPM-100). The full results for PPM-100 are in Table 3.

All results we reported in the Table are based on mam_vitb.pth and mam_vitl.pth should give you better results.

MSE and MAD should be scaled by 10^3 to match the numbers in the Table.


VSCode Workspace settings to meet DSC coding guidelines

Details of the scenario you try and problem that is occurring:
When using VSCode with the current settings the DSC coding guidelines will not be met. e.g.

Curly braces are on the same line
A new line at the end of a file is not enforced
Tailing whitespaces are not removed

In the DSCResource repo issue is a long discussion about this topic and I really think that SharePointDSC should have these settings included.
(Currently) the complete list of seetings is here

I agree with this issue. @BrianFarnhill, what do you think?

Will be added in my next PR

Fixed in PR #680


[ UNIVERSAL PIPELINE UPDATE] Alabama, Maryland, Massachusetts, Missouri, Minnesota, Montana, South Dakota

Background
The following states (below) are now live on the universal pipeline:

Alabama
Maryland
Massachusetts
Missouri
Minnesota
Montana
South Dakota

The UP config list needs to be updated on simplereport.gov and
an announcement email needs to go out to senders in that state.
Action requested
Updates are needed in the following areas:

[ ] Update the list of UP states on the static site config. Refer to this PR for an example.
[ ] Generate the list of admin emails senders in that state for product to make an announcement using the sendOrgAdminEmailCSV mutation. You can refer to this doc for help on how to perform the mutation. Notify product once this list is generated so they can continue with the email campaign.

@jayna-SkylightDigital has confirmed that she has received all the emails


Catching Runtime Panic

Hi Team,
Just curious, is there anyway to catch runtime panic or adding middleware that kind of capability?
In tower, I can use ServiceBuilder to catch panic.
 let service = ServiceBuilder::new()
        .catch_panic();

Any example would be useful!
Thank you

Pingora support sentry for catching runtime panic.
pub fn run_forever(&mut self) {
....
/* only init sentry in release builds */
        #[cfg(not(debug_assertions))]
        let _guard = match self.sentry.as_ref() {
            Some(uri) => Some(sentry::init(uri.as_str())),
            None => None,
        };

If throws a panic:

@vicanso hmm... should I use sentry to catch a panic?

I haven't found any other way yet. user_guide/panic

Yes, right now there's no other way to do this (if this = seeing panics for observability) except via Sentry. I don't think we're opposed to allowing alternative middleware layers however.
Note that tower's catch_panic middleware looks like it works by wrapping its handlers in catch_unwind, and the docs indicate this is definitely not the preferred method for general error handling. In our view panics are reserved for unrecoverable issues and logic errors that should never occur, e.g. to indicate inappropriate usage of APIs.

Yes, right now there's no other way to do this (if this = seeing panics for observability) except via Sentry. I don't think we're opposed to allowing alternative middleware layers however.
How would I approach (implement) it, if I want to implement Tower layers with Pingora?

Note that tower's catch_panic middleware looks like it works by wrapping its handlers in catch_unwind, and the docs indicate this is definitely not the preferred method for general error handling. In our view panics are reserved for unrecoverable issues and logic errors that should never occur, e.g. to indicate inappropriate usage of APIs.

Yes, I meant for any unintended panic that occurred during runtime. I am curious, if Pingora is used in production. How would you recover for unintended panic? In such scenario, this could make our resources (cpu/mem/tcp connections) saturated,, cmiiw.

Not an expert on this, so others can feel free to weigh in. Looking briefly at what the sentry crate does, it seems to define a panic hook and that is probably the right way to go.
See the docs that @vicanso linked - panics fail/drop the request but otherwise shouldn't cause issues. Additionally, in production, we very rarely see any panics, and it should stay that way. If we see panics start to occur during deployments, that's an indicator we've made an incorrect logical assumption in our code and we need to fix it.


build(ejs): bump ejs v to 3.1.9

Bump ejs from v3.1.8 to 3.1.9 as BlackDuck scan reports security vulnerabilities for the v3.1.8 and recommends using 3.1.9

CLA should be fixed


fix: image rendering issue when passed in initialData

What?
When passing files in initialData to the @excalidraw/excalidraw package, the images do not render the first time unless the screen is resized or a scene update is triggered by other actions.
Linked issue:
Fixes #8419
Reproduction steps
Clone the repo and run the following command:
cd examples/excalidraw/with-script-in-browser && yarn start

Observe the rocket image not being rendered unless the window is resized or some other action is done on the image.
How?
By creating a clearImageShapeCache function and calling it in 2 places: addFiles and initializeScene fixes this issue. The problem with the original code was that the image cache was not being cleared in the addFiles function because this.scene.getNonDeletedElements() was returning an empty list. Referenced code:
https://github.com/excalidraw/excalidraw/blob/51ea184938d57637faa345de85028aa8a0930ed2/packages/excalidraw/components/App.tsx#L3668-L3690

Thanks! ❤


David/bugfix

@Davidqian123 most changes are format change, are you using black formater in VS code?
https://marketplace.visualstudio.com/items?itemName=ms-python.black-formatter

Have you updated dependencies/llama.cpp? @Davidqian123


Headers are getting polluted by using namespace std

The ghidra source code is riddled with using namespace std in various header files. This is bad practice and it would be nice if this could be patched away. It causes all kinds of confusing issues (one notable one being with std::byte and byte from some Windows COM headers).
Ideally these occurrences would be patched out, but obviously the cost is high because you'd have to maintain an extensive test set...

Thanks for reporting @mrexodia.
Yeah, that's a bit of a pain...
Just off the top of my head, maybe we can have a test file that includes the "super" header libsleigh.hh and then has some code that we expect to fail compilation (perhaps it can refer to a container type without the std:: namespace). And then if it compiles without an error, we can assume that one of the Sleigh headers has a using namespace std; and we can fail the test.
I think I could also just submit a Ghidra PR to fix this as it's pretty uncontroversial that these don't belong in headers.
Any thoughts on this @ekilmer?

I think I could also just submit a Ghidra PR to fix this as it's pretty uncontroversial that these don't belong in headers.

This would be ideal. Depending on how big the diff of the patch is, we can try maintaining it in this repo for a while until it makes it upstream 🤞.
I opened #140 and set up some branches on our Ghidra fork to maybe make the patching process less painful (https://github.com/trail-of-forks/ghidra/wiki#sleigh).

It looks like there’s maybe 15 occurrences of using namespace. Unfortunately patching it manually is a lot of work. I gave up after 5 files.
My current idea is to use clangd or maybe write a clang-tidy pass. In this case it’s enough to do it for a few tokens, but in general it’s not so easy…

@mrexodia can you try #143 to see if it fixes the issues you've been seeing?

Thanks a lot! I'll try it on Monday ❤

Unfortunately I didn't have time to try it yet, but I didn't forget about this...


Cleanup

Fixes some issues found by Sonarcloud

Codecov Report

Merging #552 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   99.52%   99.52%
=======================================
  Files          37       37
  Lines        2513     2513
  Branches      408      408
=======================================
  Hits         2501     2501
  Misses          5        5
  Partials        7        7

Flag
Coverage Δ

#unittests
99.52% <100.00%> (ø)

Impacted Files
Coverage Δ

src/schemathesis/hooks.py
100.00% <ø> (ø)

src/schemathesis/cli/options.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc3873...d7fcba3. Read the comment docs.


Remove "conflict" section from composer.json

This line is not required because the conflicting package is already in the "require" section.
Moreover, this line creates issue #346
In practice, this line makes this package conflict with jean85/pretty-package-versions v1.3.*, which means it's not possible to generate a composer.lock file that is compatible with both composer 1 and composer 2.
:bomb: :boom:

Oh, note that this targets master which is aliased to v4, but the patch should be released as v3.5.3 really.
Thanks!

See also https://github.com/composer/package-versions-deprecated/pull/3
This line effectively prevents using version 1.3 with sentry-symfony v3.5.
I don't get how you can be against the change, the deps are just broken right now.

Since 6c3f323, you've added ocramius/package-versions in the require section, which makes the conflict line a duplicate as far as declarations are concerned. Unless you want to explicitly forbid installing composer/package-versions-deprecated, this line has to be removed.

I don't get how you can be against the change, the deps are just broken right now.

They are not, it's a combination of Composer inconsistency + composer/package-versions-deprecated#3
$ composer why-not jean85/pretty-package-versions:1.3
There is no installed package depending on "jean85/pretty-package-versions" in versions not matching 1.3

But I understand what you want to fix. As I said before, the only roadblock for this change is the direct usage of the root package constant from Ocramius' package. I would need to add some kind of getter in my package to mask the differences between Ocramius', Composer's fork and Composer 2 behavior, which I already had in mind  (see https://github.com/Jean85/pretty-package-versions/issues/19).

Let me put it another way:
{
    "require": {
        "sentry/sentry-symfony": "^3.5",
        "jean85/pretty-package-versions": "~1.3.0"
    }
}

This composer.json is not installable, although its the only potential way to generate a composer.lock file that works on Composer 1&2 while using sentry-symfony 3.5.
This is just plain broken, I hope you get it better now.

This

means the conflict is a leftover, with a nasty side-effect I just described.

The problem at hand seems to have been fixed in https://github.com/composer/package-versions-deprecated/pull/3 with the 1.8.1 release.
As for moving forward, I think I'll leverage https://github.com/Jean85/pretty-package-versions/pull/22 + https://github.com/Jean85/pretty-package-versions/issues/19 to bump to jean85/pretty-package-versions": "^1.5 || ^2.0" and be fine with it.

Closing in favor of tracking the issue in #349


fix(pricing-table): enable video CTA in pricing table header cell

Related Ticket(s)
Fixes #9050
Description
Adds an internal property of ctaType to the pricing-table-header-cell. When this value is set to 'video' by a slotchange event, the slot is wrapped in a <dds-video-cta-container> element to allow the popup video player.
Changelog
Changed

fixes an issue where video CTAs didn't open popup player

@andy-blum @proeung I am wondering what the use case is for including a video in the pricing table header.
My understanding is that the CTA would direct the user to purchase a product or to a trial, and I don't see why we would allow a video. I spoke briefly with Jen, and she and Aaron don't know of any need to include a video in this instance either. I worry this will not be a good experience for our users. Would you be able to provide any additional context?

@andy-blum @proeung I am wondering what the use case is for including a video in the pricing table header.
My understanding is that the CTA would direct the user to purchase. I worry this will not be a good experience for our users. Would you be able to provide any additional context?

I would argue this is a content guidance issue and that the video cat ought to still work, even if it's against recommendation

I would argue this is a content guidance issue and that the video cta ought to still work, even if it's against recommendation

I have to counter that argument, we have to strike the right balance of good design/UX within components and relying on content guidance.

There is no use case for this feature. The AEM designers and content strategists have confirmed this.
We shouldn’t be adding unnecessary features to components
We shouldn’t be adding features that are against recommendation, especially ones we would actively tell an author/designer/dev not to do.
The UX of launching a video from the Pricing table is a bad user experience, and we shouldn’t be adding features that aren’t going to be good for the user or for other teams to consume.

I would argue this is a content guidance issue and that the video cta ought to still work, even if it's against recommendation

I have to counter that argument, we have to strike the right balance of good design/UX within components and relying on content guidance.

There is no use case for this feature. The AEM designers and content strategists have confirmed this.
We shouldn’t be adding unnecessary features to components
We shouldn’t be adding features that are against recommendation, especially ones we would actively tell an author/designer/dev not to do.
The UX of launching a video from the Pricing table is a bad user experience, and we shouldn’t be adding features that aren’t going to be good for the user or for other teams to consume.

Hi, @oliviaflory! I can see both sides here. From the dev perspective, this isn't exactly implementing a feature but rather maintaining consistent behaviors for CTAs wherever they appear in the code base. Looking at this from a UX perspective, though, it's sensible to disable the video CTA option if it never makes sense to use it here.
@druckerk Is it possible to disable the video CTA type option for this component in the AEM content editing interface? If so, we can go ahead with technically supporting video CTAs (in the event this component is ever used for something other than pricing tables, despite the name) while making sure they can't actually be used on IBM.com.
What do folks think of this potential compromise? cc @andy-blum @proeung

Hi! So just making a note the @oliviaflory and I did discuss this and we brought it back to the AEM content strategy team where Aaron Apple noted that we'd never want to offer the option of a video for a CTA type within the pricing table. I'd hate for this to show up as an option, even if we write content guidance around it because it creates a bad user experience. I think we'd want to avoid adding any functionality that's against recommendation because if it's there, authors will try to use it regardless. From a code perspective, if we have to include the video functionality for consistency, I guess the second best thing would be to disable it in AEM.

@jwitkowski79 - We currently have the "video" cta type option disabled in the pricing table; the only cta type options available are "link", "PDF", and "Blog". One of the reasons we were trying to implement this option was to provide consistency with all our cta components already being utilized in AEM. However, If there are no plans to utilize the <dds-pricing-table-header-cell-cta> tag in any future components where it will require the "video" cta type, then we can just leave this option disabled.
CC: @proeung, @jkaeser , @andy-blum

@druckerk Thanks for providing some context from the AEM field content model side. Yes, let's move forward with disabling the "video" CTA type for the field group that's managing the display of the Pricing Table Header Cell CTA.
@andy-blum As for this PR, I think we can still move forward with addressing the functionality side. Let's go ahead and remove the <dds-video-cta-container> (see link) in the render slot so that we're keeping consistent with the usage of this component within the existing documentation. Also, please fix the merge conflict.

@proeung if we're removing the usage of <dds-video-cta-container> in the component's shadowDOM, then this entire PR is no longer needed. Should we just close the PR & issue instead?

@andy-blum I see that the <dds-video-cta-container> needed to be in the component’s shadowDOM in order for the Video Lightbox to initialize correctly. The suggested markup outlined here (https://codesandbox.io/s/lucid-satoshi-sqvbri?file=/index.html:4221-4265) wouldn’t work. Let's just proceed with resolving the merge conflict in the PR then.

Hey all, I apologize for the delay in getting back on this PR.
I agree with @andy-blum with removing the usage of the video player this PR is no longer needed.
I discussed with the AEM designers, Carbon, and Carbon for IBM.com designers and there is no need for a video in the Pricing table in AEM or in Carbon for IBM.com codebase.


Docs for Integration Framework, External Call and External Signature

Create documentation for the following:

[x] ExternalCall
[x] ExternalSignature
[x] Integration Framework

Just pushed some minor cleanup. Looks good to me. Is the plan to publish this immediately or wait until the prod release is out?

So, lets wait a bit until we release that to the main app, then we merge this.

Thanks for reviewing it and pushing the changes

New app release is done and sample agreements added to app.openlaw.io:

Coin Market Cap - External Call Example
DocuSign eSignature - External Signature Example


Refactor solution organisation into component-based approach

Describe the feature you'd like
Refactor the current solution organisation to adopt a component-based approach:

Core
(Core) API + Server
Gateway + Server
Broker + Server

Motivation
The motivation of the refactor is to isolate the Core/Resource APIs into a single (Core) API domain, allowing for different access-rules for the API endpoints and the Gateway/Broker endpoints, which should have their (useless) APIs stripped away and which should be  turned into Console apps.

Closed by #42


UMAP fit_transform terminates program with no output

I'm running UMAP on a larger dataset, but for some reason, the fit_transform method runs for some time and then terminates the rest of my program. I think it has something to do with the size of the input, because this works with only 10K points.
Environment dependencies generated using conda list -e > requirements.txt
platform: win-64
ca-certificates=2021.5.30=h5b45459_0
certifi=2021.5.30=py37h03978a9_0
intel-openmp=2021.2.0=h57928b3_616
joblib=1.0.1=pyhd8ed1ab_0
libblas=3.9.0=8_mkl
libcblas=3.9.0=8_mkl
liblapack=3.9.0=8_mkl
llvmlite=0.36.0=py37habb0c8c_0
m2w64-gcc-libgfortran=5.3.0=6
m2w64-gcc-libs=5.3.0=7
m2w64-gcc-libs-core=5.3.0=7
m2w64-gmp=6.1.0=2
m2w64-libwinpthread-git=<IP_ADDRESS>34.697f757=2
mkl=2020.4=hb70f87d_311
msys2-conda-epoch=20160418=1
numba=0.53.1=py37h9690626_1
numpy=1.20.3=py37hcbcd69c_1
openssl=1.1.1k=h8ffe710_0
pip=21.1.2=py37haa95532_0
pynndescent=0.5.2=pyh44b312d_0
python=3.7.10=h6244533_0
python_abi=3.7=1_cp37m
scikit-learn=0.24.2=py37h8ded0a9_0
scipy=1.6.3=py37h924764e_0
setuptools=52.0.0=py37haa95532_0
sqlite=3.35.4=h2bbff1b_0
tbb=2020.2=h2d74725_4
threadpoolctl=2.1.0=pyh5ca1d4c_0
umap-learn=0.5.1=py37h03978a9_1
vc=14.2=h21ff451_1
vs2015_runtime=14.27.29016=h5e58377_2
wheel=0.36.2=pyhd3eb1b0_0
wincertstore=0.2=py37_0
zlib=1.2.11=h62dcd97_1010
Reproducible code
import numpy as np
from umap import UMAP

a = np.random.randint(0,256,size=(100000,64*64), dtype=np.uint8)
map = UMAP(random_state=0)
print("Fitting UMAP")
points = map.fit_transform(a)
print("Complete!")

Expecting Output
Fitting UMAP
Complete!

Actual Output
Fitting UMAP

My best guess is that you are running our of RAM and the OOM Killer (or equivalent depending on OS) is just killing the process. The current version of UMAP is optimized more for compute time than memory so it is a little memory hungry.

Hi @lmcinnes
Thanks for the heads up. My build has 16GB of RAM. I started the program at around 12GB of free RAM. I ran task manager and watched my RAM slowly climb to max capacity. The program continued to run at that capacity for about 20 seconds. Eventually, the allocated RAM python was using dropped steadily until it flattened out around 11GB (which is still way higher than when not running it). At this capacity, the program continued to run for about a minute and then suddenly terminated freeing around 8GB of RAM. I'm not sure if the OS is killing the program. Is there a way to check?

I'm not really sure. The fact that memory use levelled off is promising. It may have been trying to make a large allocation , however, and failed at that point. You can, at the least, set verbose=True and get some output along the way and have a better idea of where it is failing.

Hi, it's been awhile, but I running into the same issue in a similar scenario. This time my RAM did not exceed 80%, but UMAP still terminated unexpectedly. See the output.
UMAP(n_neighbors=50, random_state=0, verbose=True)
Construct fuzzy simplicial set
Wed Aug 25 10:05:13 2021 Finding Nearest Neighbors
Wed Aug 25 10:05:13 2021 Building RP forest with 24 trees
Wed Aug 25 10:05:17 2021 NN descent for 17 iterations
0  /  17
1  /  17
Also, here is the windows event log for the crash in xml format.

1000
0
2
100
0
0x80000000000000

16420

Application
DESKTOP-S6N8RF4

python.exe
3.7.10150.1013
60394710
msvcrt.dll
7.0.19041.546
564f9f39
c0000005
00000000000746f8
6284
01d799ba36a10985
D:\Users\Alex\Anaconda3\envs\tcnn\python.exe
C:\WINDOWS\System32\msvcrt.dll
f15f294b-b343-4093-accf-a9610e54337e


Remove .rb suffix from grpc-tools scripts, to be consistent with other gems

This also makes the scripts easier to run on Windows.

Isn't there some doc to change as well in the repo ?

Otherwise, LGTM.

As far as I can tell, I don't actually have any documentation referring to those files. The quickstart guide I'm writing will be the first


Code analysis attribute polyfills should be internal, not public

Describe the bug and how to reproduce
When polyfilling code analysis attributes from modern .NET to a library, they should be internal and not public. Leaving them public will cause build errors for any consumers that may have their own polyfills.
More importantly, if two different libraries being consumed, i.e. Vanara and some other library, both add public polyfills then it will cause build errors. To avoid this, all NuGet packages should keep the polyfills internal.
In the example below, Polyfill is being used to add these code analysis attributes and a wide variety of other polyfills, but it is conflicting with Vanara once we upgrade Vanara to 4.x.
error CS0433: The type 'NotNullWhenAttribute' exists in both 'AdvantagePolyfill, Version=<IP_ADDRESS>68, Culture=neutral, PublicKeyToken=null' and 'Vanara.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=c37e4080322237fa'

What code is involved
The method, file path and library causing the issue. If you have code that will reproduce the bug, please include it here.
Expected behavior
The presence of polyfills in Vanara should not affect external builds.

These are backported classes that have to remain public since they are used in multiple Vanara libraries.

These are backported classes that have to remain public since they are used in multiple Vanara libraries.

I realize this may be a hot take, but I do feel like this is the incorrect approach, as this makes your library incompatible with other libraries. Primarily this incompatibility is with other "poor citizen" libraries that also make their members public, though it does include other cases such as Polyfill mentioned above.
The .NET runtime itself has the same issue with their down-level libraries. Their solution is to use shared files and include them in every down-level package as internals. This is a bit of bloat, as every package gets a copy of the attributes, but it ensures compatibility and the bloat isn't that significant. https://github.com/dotnet/runtime/blob/ad0c47c42e8901b9300701b237c42345b83c2bd9/src/libraries/Directory.Build.targets#L170-L177
Another option would be the use of the InternalsVisibleTo attribute, though admittedly that can get a bit tricky when dealing with signed assemblies. In the inverse direction, there is also the IgnoresAccessChecksToAttribute which can be added to the consuming assembly rather than the defining assembly. But this attribute isn't included in the framework, it's a "hidden" runtime feature typically used for things like dynamic assembly generation, so it would also need to be polyfilled in every assembly.
Of course, since 4.0 has already been released, changing this now could cause backward compatibility issues for consumers, so I do understand the change may require waiting until you're ready for a 5.0 release. But I do think it's worth considering. In at least my case it will require me to either remain on 3.0 (which has trimming problems) or not use the library at all until I've gotten this project moved from .NET 4 to .NET 8 (which we're doing but it's a long, slow slog).

I like the shared code approach. Let me see if I can make that work.


Add Sentry integration, version 2

The previous attempt used the raven-provided middleware. Unfortunately,
we have to run code in the wsgi handler context as well and it gets
application state from the application so things got rather complex when
the application was wrapped in a middleware. This is a less invasive but
more manual way of adding raven into the mix.

Agreed that while this is a bit more manual it definitely seems cleaner. :nail_care: for small question about None-ness of error_reporter

:haircut_man:

:fish:

8acd0f483b8c61be7b31c37c626d6b558fd6d8e0


Janus-1.3B-ONNX - Can't create a session. Failed to allocate a buffer

System Info
Transfomer.js version: "@huggingface/transformers": "^3.1.0"
Environment/Platform

[X] Website/web-app
[ ] Browser extension
[ ] Server-side (e.g., Node.js, Deno, Bun)
[ ] Desktop app (e.g., Electron)
[ ] Other (e.g., VSCode extension)

Description
I was trying the code provided in the onnx-community/Janus-1.3B-ONNX repository, but I encountered the following error:
ort.webgpu.bundle.min.mjs:2603 Uncaught Error: Can't create a session. Failed to allocate a buffer of
size<PHONE_NUMBER>.
    at jt (ort.webgpu.bundle.min.mjs:2603:25061)
    at Pr (ort.webgpu.bundle.min.mjs:2603:25240)
    at Kl (ort.webgpu.bundle.min.mjs:2603:34605)
    at mn.loadModel (ort.webgpu.bundle.min.mjs:2603:36389)
    at fn.createInferenceSessionHandler (ort.webgpu.bundle.min.mjs:2603:38145)
    at e.create (ort.webgpu.bundle.min.mjs:6:19471)
    at async createInferenceSession (onnx.js:163:1)
    at async models.js:301:1
    at async Promise.all (:5173/index 0)
    at async constructSessions (models.js:298:1)

I believe that<PHONE_NUMBER> bytes (approximately 1.94 GB) is less than 2 GB, so it shouldn't be causing this issue. Additionally, I noticed that the file preprocessor_config.json is being downloaded or loaded twice.
Reproduction
import { AutoProcessor, MultiModalityCausalLM } from "@huggingface/transformers";

const model_id = "onnx-community/Janus-1.3B-ONNX";
const processor = await AutoProcessor.from_pretrained(model_id);
const model = await MultiModalityCausalLM.from_pretrained(model_id);

Can you try using WebGPU? Also, I recommend the following dtypes, depending on whether fp16 is supported or not.
const model_id = "onnx-community/Janus-1.3B-ONNX";
const fp16_supported = true; // do feature check
const model = await MultiModalityCausalLM.from_pretrained(model_id, {
      dtype: fp16_supported
        ? {
            prepare_inputs_embeds: "q4",
            language_model: "q4f16",
            lm_head: "fp16",
            gen_head: "fp16",
            gen_img_embeds: "fp16",
            image_decode: "fp32",
          }
        : {
            prepare_inputs_embeds: "fp32",
            language_model: "q4",
            lm_head: "fp32",
            gen_head: "fp32",
            gen_img_embeds: "fp32",
            image_decode: "fp32",
          },
      device: {
        prepare_inputs_embeds: "wasm", // TODO use "webgpu" when bug is fixed
        language_model: "webgpu",
        lm_head: "webgpu",
        gen_head: "webgpu",
        gen_img_embeds: "webgpu",
        image_decode: "webgpu",
      },
    })

It's working now, thanks, @xenova! Much appreciated.
I will wait for the bug to be fixed.

Do you have an example for how to do this in the python library? My understanding is that the model generates exactly 576 tokens, so unless the image decoder can produce higher quality images, it can currently only generate 384x384 images.

My bad, you're right—it's 384x384 after checking their docs. But what about guidance and parallel_size?

You should be able to pass guidance_scale: 4 to the generate_images function. Batched generation technically works, but needs a bit more experimentation.


Formatting doesn't work for me

I've followed the instructions here:
https://github.com/pantharshit00/coc-prisma/blob/fc64aaa7fb0f0cdf51a84eeadee53e99fe1d3b90/README.md#formatting
However, when using the command :Format I get the following: E492: Not an editor command: Format
Also, here is what I have in my coc-settings:
...
  "coc.preferences.formatOnSaveFiletypes": [
    "css",
    "html",
    "javascript",
    "javascriptreact",
    "json",
    "jsonc",
    "markdown",
    "prisma",
    "ruby",
    "scss",
    "typescript",
    "typescriptreact",
    "yaml"
  ],
...

But it does not work for prisma. All other filetypes do format properly.
Any ideas?

Yeah I'm not sure either..it almost looks like that's defined from the prettier plugin and not COC directly? I tried the prettier plugin, but it doesn't support prisma lol

Thanks @lukevers that works great. Any ideas how to get it to work with syntax highlighting? I normally use coc-prettier. The gif in the readme has highlighting, so someone got it to work..

@SOLID-arity Yeah I'm using https://github.com/pantharshit00/vim-prisma
Here's my vimrc if it helps https://github.com/lukevers/vimrc/blob/main/vimrc#L17


shellsort.cpp

implementation in c++

Hey can u please suggest do I need to modify the name of the file as it is really confusing for me because when I add / it adds to new file please help.


Feature Request: Return Last-Modified header with HTTP responses.

Hi there. I work in the Contain Data Platform Team over in NHS Digital, and we consume PHE's data for a few of our public-facing dashboards.
We've got some special cases in our pipeline code which use the COVID-19 Python SDK to get the update timestamps from the V1 API, but we've been a bit concerned about using the timestamp from one version of the API to decide whether to fetch a file from another version. It would be great if we were able to do a HEAD request on the API to see if the files have been updated, but the Last-Modified header is missing from the response.
Is this something that you'd be able to add? Alternatively, if the team are busy working on other improvements, would a pull request to add this functionality be welcome?

Thank you for getting in touch. I have added this request to our backlog for consideration.


Update slack dependency

Changes
We randomly see some duplicate events in slack:

I wasn't able to reproduce this locally, so for now Im updating slack and also adding debug log messages to see in which area of the code this can potentially happen.

@ashkan18 does this work with the current version of Elixir?

Yes, but lets wait actually on this one, my PR to fix elixir 1.4 issue in elixir-slack has been merged, we'll get a new version soon.


Update MangaDemon.kt

Checklist:

[ ] Updated extVersionCode value in build.gradle for individual extensions
[ ] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[ ] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[ ] Added the isNsfw = true flag in build.gradle when appropriate
[ ] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[ ] Have tested the modifications by compiling and running the extension through Android Studio
[ ] Have removed web_hi_res_512.png when adding a new extension

No trailing slash in the baseURL
Bump the extVersionCode
Test your changes/check if extension actually works
Reference the existing issue request in your PR description
Fill out the relevant checklist in the PR

Did you test this? In my case, the 404 error persists. I think they changed the route names.


Git workflow: extend title

In order to make a better distinction with the 'Git(hub) introduction' tutorial, I propose to make the title more specific. This will cause less confusion when looking at the list of git-tutorials at https://inbo.github.io/tutorials/tags/git/

good point, thanks for the adaptation!


Plan to upgrade to django 1.10? and use channels?

Hi @mineta
Any chance to upgrade to 1.10 and also make use of django channels?

Hi @dariushazimi
I'm waiting for the next LTS release, which will be 2.11 :-)

@mineta Also, do you have a demo on line somewhere that we can look. I am just going through the install and it would be great to see the final product before the start.  Many thanks.


Automate dependabot merges

I think the vast majority, if not all, dependabot PRs are merged once tests pass. This is manual, and while it's not that much of a burden, I think we can automate this. See https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#enable-auto-merge-on-a-pull-request for instructions on how to set this up.
When there's a major Go version update, I think we have to do something manually too, so maybe we don't merge those automatically.
I'm also not sure if we would need to update tests that are required for each repo, or if branch protection should limit merging if any test, required or not, fails.
I'd suggest this be enabled for the larger repos (Rekor, Fulcio, Cosign), and for others, maintainers can decide if they want to enable it or not.
cc @cpanato - Thoughts?

This only enables the automerge feature; it does not merge it.
I agree to enable that for dependabot PRs.
Let me do that for the main repos

lets try in the timestamp first and then replicate to others


URLs with underscores in the host portion are rejected as invalid

An ACS URL such as https://foo_bar.example.com is currently rejected as invalid due to the underscore. Underscores are valid characters in the host RFC 3986 so this URL should be accepted.

Thanks for collaborate!


Two smart banners are shown on iPhone 5 safari

Title says everything about itself.
Did anyone had a same issue? And how to fix that thing?

Dear Friends, I have the same issue, can someone found the solution?

We have encountered this on safari on iphone4 and iphone5 - is there any fix for this yet?

Dear Friend,
You can solve this if you don't use FORCE in a settings! :)

(I don't actually use the force smartbanner option - thanks, though!)

@fahad86  As you said, there should be a option to pass the app id as a param instead of using the meta tag which makes the native smart banner to appear.

I fixed the issue by checking the iOS version from the user agent. If 6 or above is detected, I do not show the smart banner.
This is a result of the banner being automatically generated in Safari for iOS 6 and above: Promoting Apps with App Banners
else if (UA.match(/iPhone|iPod/i) !== null || (UA.match(/iPad/) && this.options.iOSUniversalApp)) {
    if ((UA.match(/Safari/i) !== null) && (parseFloat(UA.substr(UA.indexOf('OS') + 3, 3).replace( '_', '.' )) <= 6)) {
        this.type = 'ios';
    }
}


Sabre picks incorrect compiler version

When pragma is set to a fixed version, Sabre attempts to compile with a later release which fails. E.g.:
suicide.sol:
pragma solidity 0.4.24;

contract Suicide {

  function kill(address addr) public {
    if (addr == address(0x0)) {
      selfdestruct(addr);
    }
  }

}

Output:
$ sabre solidity_examples/suicide.sol
✔ Compiled with solc v0.4.25 successfully
inputfile:1:1: SyntaxError: Source file requires different compiler version (current compiler is 0.4.25+commit.59dbf8f1.Emscripten.clang - note that nightly builds are considered to be strictly less than the released version
pragma solidity 0.4.24;
^---------------------^

I will have a look.

OK, I have fixed it, please wait for a moment.

I have tested

0.4.23
^0.4.23

=0.4.23

=0.4.23<=0.5.0

=0.4.23<0.5.0

<=0.5.0
<0.5.0
<=0.6.0
<0.6.0
without specific version

Fixed by #48.


Type definition error

Hi, I was doing some tests with the library and it was doing great, however for some reason when using tsc to transpile my project this error about the type definition is raised:
node_modules/@kmamal/sdl/src/types/index.d.ts:1190:1 - error TS2309: An export assignment cannot be used in a module with other exported elements.

1190 export = sdl
     ~~~~~~~~~~~~

Found 1 error in node_modules/@kmamal/sdl/src/types/index.d.ts:1190

It doesn't seem to affect in the transpiling tho, is still working without any issues AFAIK, is more of an annoyance than anything else.
I'm just starting with TS so I really don't understand what is happening

Thanks for reporting. I have noticed the error before. There was some reason I ended up using export = sdl but I don't remember exactly why. I'll try to investigate.

Hi, I am facing the same problem.
There are types at<EMAIL_ADDRESS>but this result could not be resolved when respecting package.json "exports". The '@kmamal/sdl' library may need to update its package.json or typings.
After removing "exports": "./src/javascript/index.js",, all the errors are gone

@C0deBr3ak3r Try with the latest version.
@kienhg96 That looks like a different error. Try with the latest version. If that doesn't help share your tsconfig.json and typescript version.

@kmamal, I upgraded to 0.9.3, but the error's still there.
This is my tsconfig.json:
{   "compilerOptions": {     "target": "ESNext",     "module": "NodeNext",     "moduleResolution": "NodeNext",     "allowJs": true,     "checkJs": true,     "outDir": "./dist",     "esModuleInterop": true,     "forceConsistentCasingInFileNames": true,     "strict": true,     "skipLibCheck": true   },   "exclude": ["node_modules"],   "include": ["lib", "demo"] }

@kmamal the new version fixed it, thanks

@kienhg96 Try version 0.9.4

@kmamal It works


🚀 Feature request: Quick command parameter presets

Describe the solution you'd like
It would be cool if both user and administrator could define parameter presets, which could be launched with single click from main page.
Additional context
In previous version of Lazy Admin, there was each command with parameters, which were to be filled by user. To reuse same parameters, user had to search in history to reopen command window with previous parameters and go through the whole process.

Command row could be expanded to show subrows, where is each preset shown with parameters.
Two buttons on each row

Edit (Where we can change and run once, save permanently, delete)
Quick Launch


Fix install-docker-ce.ps1: On PS >=5, use Invoke-WebRequest instead of non-existing function 'wget'

Guess the person who wrote this had aliased wget to Invoke-WebRequest? These are the arguments to Invoke-WebRequest, so something was a bit weird here.
Simple fix anyway.

Whoops, good catch :D Thanks for the fix!


Vertical screen space

Tries to fix #57

Is it possible to do this in CSS instead of using inline styling?

Not sure, but can look into it :+1:


Scala 2.13.0 support

A long way from working, but we can start tracking what we need.  Many of these are blocked on their own dependencies:

[x] better-monadic-for
[x] cats
[x] cats-effect
[x] discipline
[x] fs2
[x] kind-projector
[x] log4s
[x] parboiled (our fork)
[x] scalacheck
[x] specs2
[x] vault

log4s should soon be unblocked by https://github.com/Log4s/log4s/pull/32.
parboiled2 is merged and just needs a release when I get home.

The listed dependencies are just core.  There are definitely more to come.

There's an RC2 now, which would reset all our progress, but I don't know that the stragglers will target RC1 now that RC2 is here.
I'm not totally persuaded we'll get this done before 2.13.0-final.  I tried. :weary:

Libraries are dropping RC1 in favor of RC2.  I guess we'll retarget that.

I need cats-effect before I can update vault.

parboiled2 is blocked on release of https://github.com/lihaoyi/utest/pull/199
vault and fs2 are unblocked, I think.

Vault: https://github.com/ChristopherDavenport/vault/pull/57

fs2: https://github.com/functional-streams-for-scala/fs2/pulls

Scala 2.13.0-RC3 is here.  [Unchecks all the boxes]

better-monadic-for: https://github.com/oleg-py/better-monadic-for/pull/26
log4s: https://github.com/Log4s/log4s/pull/36
parboiled2: blocked on utest, which isn't publishing. We can make that a source dependency.
vault: blocked on unique blocked on better-monadic-for

fs2: blocked on scodec-bits blocked on https://github.com/scodec/scodec-build/pull/22

2.13 is out, time to start over again :)

Tracking issues:

https://github.com/typelevel/cats/issues/2883
https://github.com/etorreborre/specs2/pull/746 (just a release missing)
https://github.com/Log4s/log4s/pull/38

I just released parboiled2-2.0.1, but I won't be awake for it to sync. 😴

The last couple dependencies

https://github.com/ChristopherDavenport/vault

https://github.com/ChristopherDavenport/unique

https://github.com/functional-streams-for-scala/fs2

One that I'm pretty sure is going to bite us quickly is JdkConverters vs. JavaConverters.  CollectionCompat is going to be our friend there: call it scala.collection.JdkConverters in 2.13 and scala.collection.JavaConverters in 2.11-2.12.
I'm working on blaze.

Currently missing:

[ ] fs2 (2.13 support has been merged, not released yet)
[ ] scalatags (2.13 support has been merged, not released yet, but version 0.7.0 is mentioned in the repo)
[ ] boopickle (2.13 support has been merged, not released yet)
[ ] jawn-fs2 (depends on fs2)
[ ] blaze

https://github.com/http4s/blaze/pull/280
https://github.com/http4s/jawn-fs2/pull/47

@aeons mentioned he was working on the fs2 upgrade already so I'm not proceeding further until we hear from him.

I hardcoded some options for the CirceSupportParser, that I think match the options in the current version.

I updated sbt-doctest, but that doesn't seem to work. mimedb-generator doesn't work with 2.13, and I'm not 100% on how to force that to 2.12.
Still waiting for boopickle and scalatags to publish for 2.13, they both have merged the necesarry code.

All dependencies are here, except treehugger (for mimedb-generator).
I updated the examples to take Blocker from the end of the world to where it's used.
I updated one cats laws test (EntityEncoderSpec) so that it works after https://github.com/typelevel/cats/pull/2577, but I don't really know how to fix the one in EntityDecoderSpec.
mimedb-generator and doctests are still not working.

mimedb-generator is made more challenging since the default Scala version changed to 2.13 (which is good), but has to be excluded from 2.13.  We could set its default Scala version to 2.12, but that's quirky given that it depends on other http4s modules.  I think it might be better if that project were converted to an sbt plugin that didn't depend on http4s.  I'll poke at that.

scalatags 0.7.0 is not published for scala 2.11.

What is the motivation for basing the Blockers on global?  This gets people off on the wrong foot.  Is this a Travis CI concession?

I was tired and just wanted it to work without thinking. I've improved it now, to the point that it does basically the same as before.
I've mentioned the Resource approach, but not sure if it's stressed enough that that is the preferred way of creating one.

I opened the PR so I can't approve it, but :+1:


Crisp Web Client not compatible with Ruby on Rails Turbo (and possibly other frameworks)

I'm migrating to Crisp and have been implementing the Chat bot on our website. I thought this would be a quick but I ran into a pretty big incompatibility issue with the popular web frame Ruby on Rails and it's Turbo functionality. The issue I observed was that when clicking around on my website, the Chatbot would disappear for a second and then re-appear..  This occurred when the chatbot was open or closed and didn't look great. The behavior I expected was that the chatbot would stay consistently in view like it does on crisp's main website. I did notice that on Crisps documentation page the same bug exists. Below video shows the expected vs the unexpected behavior. Notice on the documentation each click results in the widget disappearing and re-rendering. On the main crisp site this doesn't happen. The documentation site likely doesn't use any sort of fast loading so this is expected, but it demonstrates the behavior all the same. (video below)

Problem Summary:

Turbo Drive (a feature of Hotwire in Rails) that improves the speed of websites by rendering the page inteligently, only updating parts that have changed. This prevents flickering and reloading entire pages when it's not necessary. It does so by replaces elements in the body that have changed, but keeping the others in place.
Crisp automatically appends its widget to the  and uses an internal MutationObserver to monitor DOM changes, re-rendering itself whenever it detects changes.
Because Turbo replaces the , Crisp's MutationObserver detects this as a change, which causes the Crisp widget to reload or reinitialize each time Turbo navigates to a new page. This leads to the widget "resetting" or duplicating, impacting user experience.
Turbo allows you to put attributes on elements you don't want to be replaced. Crisp js on the other hand does not allow setting a container element, class, or id for the widget to use. As a result, we can't tell Turbo to not manipulate the crisps chat.

Desired long term solution
This should be a simple fix. All we need to be able to do is be able to configure the element that the Crisp chatbot will be placed into. I imagine this will look something like this
Crisp.configure('secret key', { container: '#my-crisp-wrapper' })

We would then add the special ovrride option on that wrapper so that Turbo does not update the element.

My Hacky Solution

Persistent Container (data-turbo-permanent):
Wrapping Crisp in a data-turbo-permanent container prevents Turbo from replacing it.
However, this doesn’t work directly because Crisp appends itself to , outside of any data-turbo-permanent wrapper.
Disabling Crisp’s MutationObserver:

We intercept Crisp's MutationObserver to prevent it from triggering a reload.
By temporarily disconnecting the observer, we can move the Crisp widget to our container without triggering a re-render.

When Crisp reloads, move it to a data-turbo-permanent positon
Listening for Crisp's session:loaded event allows us to detect when Crisp reloads itself.
Each time Crisp reloads, we move it to a data-turbo-permanent container to persist through Turbo navigations.

I will attach the actual source of this solution soon. It works however I'd like to clean it up before sharing.

Hello, and thank you for the suggestion.
So the Crisp docs are not really affected with this because it's not a SPA, but regular HTML pages.
Do you have any link to your site so we can check this with turbolinks?

Thanks for the quick response. Yes that's totally fair - I was sort of just using it as an example of the behavior. Totally makes sense the doc page is just reloading so of course it's going to behave this way. I haven't deployed the chat widget to my site because of this problem. And since I have a fix I was going to deploy it with it working. Would you like me to temporarily deploy the chat widget with the flashing or would a video suffice? Alternatively I can make a feature toggle that lets you enable the problem on my domain.

Alternately just create a dummy rails project with turbo so we can fully reproduce

Sure. Feel free to send to it<EMAIL_ADDRESS>

Just emailed you the sample project with instructions. Also below is my fix for this issue. As mentioned it's a bit hacky and not something I really want to leave in long term. It messes with the MutationObserver instructor core js constructor.
const { Crisp } = require('crisp-sdk-web')

let originalMutationObserver = window.MutationObserver
let listOfObservers = []

// Override Mutation Observer such that whenever a new one is created it checks to see if it's a Crisp one.
window.MutationObserver = (aFunction) => {
  let observer = new originalMutationObserver(aFunction)
  const stack = new Error().stack
  // Only add Crisp observers to the list we care about.
  if (stack?.includes('crisp')) {
    //console.log('Tracking this crisp observer')
    listOfObservers.push(observer)
  } else {
    //console.log('Not tracking this observer')
  }
  return observer
}

window.overrideCrispObserver = () => {
  const originalMO = window.MutationObserver

  // Backup the MutationObserver constructor
  window.MutationObserver = function (callback) {
    // Create an observer but do not attach it
    const observer = new originalMO(callback)

    // Save the observer to disable later
    originalMutationObserver = observer

    return observer
  }
}

const disconnectAllObservers = () => {
  listOfObservers.forEach((observer) => {
    observer.disconnect()
  })
}

const reconnectAllObservers = () => {
  listOfObservers.forEach((observer) => {
    observer.disconnect()
  })
}

const onCrispReady = () => {
  console.log('Crisp chat widget is rendered and ready!')
  // You can add other actions here
  moveCrispToPermanentContainer()
  preserveScrollOnChatBot()
}
window.CRISP_READY_TRIGGER = onCrispReady

// // This method is fired by crisp
// window.CRISP_READY_TRIGGER = function () {
//   // console.log('Crisp chat widget is rendered and ready!')
//   // You can add other actions here
//   moveCrispToPermanentContainer()
//   preserveScrollOnChatBot()
// }

const moveCrispToPermanentContainer = () => {
  const crispWidget = document.querySelector('.crisp-client')
  const crispWrapper = document.getElementById('crisp-wrapper')

  if (crispWidget && crispWrapper && !crispWrapper.contains(crispWidget)) {
    // Temporarily disable the MutationObserver
    disconnectAllObservers()

    // Move the widget to a persistent container
    crispWrapper.appendChild(crispWidget)

    // Re-enable the MutationObserver
    reconnectAllObservers()

    // console.log('Crisp widget moved to permanent container and observers reconnected)
  }
}

Crisp.configure('...TODO: Add your token... ')


Implement assert() messages behind a flag on dart2js

This is the dart2js-specific issue for #24213. That issue has the details.

https://codereview.chromium.org/1325843003/

Thanks!

Done: https://codereview.chromium.org/1342213003/

Thanks @rakudrama !

The DEP met today, and decided that the type annotation on the optional param should be String. Does the CL reflect that?

The dart2js CL makes no restriction on the optional 'message' parameter.
(This is consistent with the VM implementation)
This means that it will compile and run, but not issue the static type
warning.
I do still think String is the wrong choice for the reasons I explained at
https://codereview.chromium.org/1324933002/diff/20001/docs/language/dartLangSpec.tex
On Wed, Sep 30, 2015 at 3:54 PM, Seth Ladd<EMAIL_ADDRESS>wrote:

The DEP met today, and decided that the type annotation on the optional
param should be String. Does the CL reflect that?
—
Reply to this email directly or view it on GitHub
https://github.com/dart-lang/sdk/issues/24216#issuecomment-144568607.

On Thu, Oct 1, 2015 at 12:54 AM, Seth Ladd<EMAIL_ADDRESS>wrote:

The DEP met today, and decided that the type annotation on the optional
param should be String. Does the CL reflect that?

Syntax does not have type annotations - assert is not a function.
I assume the intent is that the static analysis should give a warning if
the second operand is present and its static type is not assignable to
String - and in checked mode, a TypeError should be thrown if the actual
value is not runtime-assignable to String.
No, the CL does not reflect that.
The runtime part is easy, because we can add a String type annotation to
the helper function this is being compiled into calling, but the static
analysis needs to be written to check the types of the assert statement.
We do not warn if the first operand is not a bool or a nullary function.
Should we do that too?
/L
Lasse R.H. Nielsen -<EMAIL_ADDRESS>'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K

Denmark - CVR nr. 28 86 69 84

Syntax does not have type annotations - assert is not a function.
I assume the intent is that the static analysis should give a warning if
the second operand is present and its static type is not assignable to
String - and in checked mode, a TypeError should be thrown if the actual
value is not runtime-assignable to String.

Yes.  Quoting from the proposed spec text in https://codereview.chromium.org/1324933002:

It is a static type warning if the type of $s$ may not be assigned to \cd{String}.

As to the other question:

We do not warn if the first operand is not a bool or a nullary function.
Should we do that too?

According to the spec, yes.  It says:

It is a static type warning if the type of $e$ may not be assigned to either  \code{bool} or $()
\rightarrow$ \code{bool}.

However, I believe I have heard that Dart2js is no longer attempting to produce a correct set of warnings,, on the grounds that this functionality is already provided by the analyzer.  So this may be moot.

The quoted text differs from what Bob was asking for - the text only asks for a static type check, where Bob asked for a "type assertion" which is both a static type check and a runtime subtype check in checked mode.
The former, while not optimal, is still vastly better than the latter.
(In either case, the answer is the same, the CL doesn't do it).

my 2 cents: this seems rather inconsistent with print, which allows you to pass anything. I was hoping we would get the same flexibility with the second argument in assert.

this seems rather inconsistent with print, which allows you to pass anything.

Good point!

Also, I'm unable to come up with a situation where a user wants a runtime error because the type of the expression in their assert is incorrect. They already had a failing assertion, which is a much more important error to report, but that willl be lost to the TypeAssertion of the message.
If anything, we should capture any error in the message and suppress it, making the (safe) toString of the error be the message. The failing assertion is the only thing that actually matters.
Also, Java doesn't require its assert message to be a string.
I'm afraid we may be fooling ourselves, and users, by making assert look like a function call when it is actually a special control flow syntax (like a combined if and throw).

Thanks for the feedback! I'll see if I can channel this up to the DEP.

Hi,
I updated dart sdk to 1.22.0 but the assert message is not working.
Error:
Uncaught 'package:raoni_global/src/modeler.dart': error: line 59 pos 35: ')' expected
assert(propagations.length == 1, 'There can not be more than one '
^
Version:
dart --version
Dart VM version: 1.22.0 (Mon Feb 13 17:33:58 2017) on "macos_x64"
Restarted all services, killed all dart pids.
Am I doing something wrong?

assert(propagations.length == 1, 'There can not be more than one '

Looks like you're missing the ); after the message.

it was just cropped by the debugger.
assert(somebool == true, 'something'); also threw an error.
I will restart the machine.
Feel newbie doing it, but there is no other option coming to mind.

Sorry, but the problem is within chromium and not dart2js.
Internal error: 'http://localhost:8081/main_reflectable_original_main.dart': error: line 22 pos 36: ')' expected
assert(Intl.defaultLocale != null, 'hello');
It is working ok within the VM and chrome js, but not at chromium.

Sorry, but the problem is within chromium and not dart2js.

Ah, by Chromium, do you mean Dartium? It may be that you're inadvertently running a slightly older version of it. If you open chrome://version, it should show the version of Dart in there. Is it 1.22?

Oh, indeed it is older:
Dart 1.19.1
I will find how to update dartium and fix this.
Thank you very much =]
2017-02-15 21:01 GMT-02:00 Bob Nystrom<EMAIL_ADDRESS>
Sorry, but the problem is within chromium and not dart2js.
Ah, by Chromium, do you mean Dartium? It may be that you're inadvertently
running a slightly older version of it. If you open chrome://version, it
should show the version of Dart in there. Is it 1.22?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/24216#issuecomment-280169249,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF6Y3hUPIf8VtOUkDjcYoLIxURLARDUuks5rc4O0gaJpZM4Fy4t5
.

--
Jonathan Rezende

👍


[sw, dif] Add expectation macros for DIF unit tests

This vastly simplifies common idioms in DIF unit tests by using only one argument for checking that something returned Ok or BadArg, the two most common expectations in the tests. In turn, this means clang-format cam produce tighter formatting with fewer unreadable overhangs, allowing readers to focus on "interesting" expectations.
This has been on my backlock for ~ a year.

This will fix #9971.

In turn, this means clang-format cam produce tighter formatting with fewer unreadable overhangs, allowing readers to focus on "interesting" expectations.

It saves only 4 characters, though. But I suppose every little bit helps ;)

Apparently, it helps quite a bit:

It doesn't just save four characters; it saves a comma, which in turn makes clang-tidy use a different heuristic for formatting.


AWS_Lambda auth type not supported in headless [amplify add api --headless]

How did you install the Amplify CLI?
No response
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
12.10.3
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No
Describe the bug
Unable to add/modify GraphQL API with Lambda authorisation using headless.
Expected behavior
We should be able to add/modify GraphQL API with Lambda authorisation using headless.
Reproduction steps

amplify init
amplify add function (Give function name as "hello")
Create a JSON which will have configuration for the GraphQL API. You may refer the below example

myAddApiRequest.json
{
    "version": 1,
    "serviceConfiguration": {
        "serviceName": "AppSync",
        "apiName": "newHeadlessApi",
        "transformSchema": "type Salary @model @auth(rules: [{ allow: custom }]) {\r\n  id: ID!\r\n  wage: Int\r\n  currency: String\r\n}",
        "defaultAuthType": {
            "mode": "AWS_LAMBDA",
            "lambdaFunction": "hello"
        }
    }
}

Perform command cat myAddApiRequest.json | jq -c | amplify add api --headless

===Error
{"errorName":"UnknownFault","errorMessage":"Data did not validate against the supplied schema. Underlying errors were [{\"keyword\":\"enum\",\"dataPath\":\".serviceConfiguration.defaultAuthType.mode\",\"schemaPath\":\"#/definitions/AppSyncAPIKeyAuthType/properties/mode/enum\",\"params\":{\"allowedValues\":[\"API_KEY\"]},\"message\":\"should be equal to one of the allowed values\"},{\"keyword\":\"enum\",\"dataPath\":\".serviceConfiguration.defaultAuthType.mode\",\"schemaPath\":\"#/definitions/AppSyncAWSIAMAuthType/properties/mode/enum\",\"params\":{\"allowedValues\":[\"AWS_IAM\"]},\"message\":\"should be equal to one of the allowed values\"},{\"keyword\":\"enum\",\"dataPath\":\".serviceConfiguration.defaultAuthType.mode\",\"schemaPath\":\"#/definitions/AppSyncCognitoUserPoolsAuthType/properties/mode/enum\",\"params\":{\"allowedValues\":[\"AMAZON_COGNITO_USER_POOLS\"]},\"message\":\"should be equal to one of the allowed values\"},{\"keyword\":\"enum\",\"dataPath\":\".serviceConfiguration.defaultAuthType.mode\",\"schemaPath\":\"#/definitions/AppSyncOpenIDConnectAuthType/properties/mode/enum\",\"params\":{\"allowedValues\":[\"OPENID_CONNECT\"]},\"message\":\"should be equal to one of the allowed values\"},{\"keyword\":\"anyOf\",\"dataPath\":\".serviceConfiguration.defaultAuthType\",\"schemaPath\":\"#/properties/defaultAuthType/anyOf\",\"params\":{},\"message\":\"should match some schema in anyOf\"}]","resolution":"Please report this issue at https://github.com/aws-amplify/amplify-cli/issues and include the project identifier from: 'amplify diagnose --send-report'","link":"https://docs.amplify.aws/cli/project/troubleshooting/"}

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

PR #13729 is merged and hence this issue can be closed.


Debugging python code run by startup

I am trying to debug some python code which is run in a customised startup.py that I am using. I would like to use a debugger such as pdb to do this but have so far been unable to make it work.
I have tried adding
import pdb
pdb.set_trace()

To the startup  script, but while I see some output from pdb I am unable to type any commands. I think this is likely caused by stdin/stdout not being linked to the terminal because of the way that the python file is executed.
Usually I would attach to a python process directly but again because of how PythonQt runs the python code, it is all contained within the single director process.
Is there any way I can get a debugger to attach to the python code?

Hi,
If the main window is open and responsive then you can use the built in Python console (press F8 to open it) to enter text to interact with pdb.  If you have set the trace before the application has finished initializing then you will have to use the terminal.  You can restore the stdin with this code before calling set_trace:
import sys
sys.stdin = sys.__stdin__

Thanks, that was what I needed.


A11y_JAWS is reading Incorrect role as image for the tooltips present beside labels "Conversion name" and "Scripting compatability level"

GitHub Tags:
#A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Benchmark; #BM_Database Schema Conversion Toolkit_Win 32_May2023; #Database Schema Conversion Toolkit; #DSCT1.0.0; #Element:tooltip; #FTP; #JAWS; #WCAG1.3.1; #ScreenReader; #Win10; #Win32; #NVDA:
"Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility or the Divisional Driver."
Actual Result:
JAWS is reading Incorrect role as image for the tooltips present beside labels "Conversion name" and "Scripting compatibility level"
Similar issue is observed with NVDA
Expected Result:
JAWS should read the correct role as tooltip for the tooltips present beside labels "Conversion name" and "Scripting compatability level"
Environment Details:
Application Name: Database Schema Conversion Toolkit Azure data studio
Version: 1.43.0 (System user)
Windows Version: Windows 10
OS Build: 19045.2846
ScreenReader: JAWS 2023.2303.144 /NVDA 2023.1
Repro Steps:

Login to vm with appropriate credentials
Launch Azure data studio.
Tab to 'Manage Connection' and press enter
Tab to the dash board for Oracle extension
Perform 'Convert Objects'
"Provide a name for the conversion" blade should open
Tab till the tooltip present beside label "Conversion name"
Turn on JAWS
Check whether JAWS is reading correct role as tooltip for the tooltip icons present.

User Impact:
ScreenReader Users will be confused if correct role is not defined for the control.
Attachment

2395677_NVDA.webm
2395677_A11y_Database Schema Conversion Toolkit_JAWS.webm

Primary bug: https://msdata.visualstudio.com/Migration Assistant/_workitems/edit/2395677

@ShaileshChudawkar this has now been fixed. Please try the latest insiders build and verify and close this bug.

@ShaileshChudawkar , did you retest this issue? we have a s360 item linked this.

Verified the issue at
Version: 1.46.1 (user setup)
Commit: ba29842b81dec01177415e53948ca2168e69c3f8
Date: 2023-10-02T18:14:22.887Z
VS Code: 1.79.2
Electron: 22.3.25
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
issue is still repro.

@ShaileshChudawkar please test using the latest insiders build, which is version 1.48.0-insider. Version 1.46.1 does not have the fix.

Verified  the issue at
Version: 1.48.0-insider (user setup)
Commit: 943a1ad98e1bd8e3054df539d88cd3174c6b273a
Date: 2023-11-01T22:48:29.430Z
VS Code: 1.82.0
Electron: 25.8.4
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
issue is not fixed. NVDA and JAWS announcing graphic to tooltip. NVDA and JAWS should announce tooltip for icon.

JAWS.webm
NVDA..webm

@ShaileshChudawkar The fix is now available, please try again with the latest insiders build.
The info icon is now announced as a tooltip (this is a different extension being shown as an example):

#closed; #Regressed:11-10-23;
Verified the issue at
Version: 1.48.0-insider (user setup)
Commit: 6357c042001a66b3e3d8fdb6bc8c8d89018a0e64
Date: 2023-11-08T06:36:15.048Z
VS Code: 1.82.0
Electron: 25.8.4
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631
issue is fixed. Closing the bug.

NVDA. (2).webm
JAWS (2).webm


marking spaces in *.h files but not in *.c

Hello! Thanks for this package!
I got this package working for all the files in the folder except *.c files.
I did not change default settings. Just installed.

please check the image.
Thanks!

Works fine for me, mind sharing some more details?

Your Sublime Text version
This plugin version (use the command palette, list packages, should say under the name of each package)
List of your packages (e.g. the whole User/Package Control.sublime-settings file)

@p3lim sure.

Package Control.sublime-settings:
{ 	"bootstrapped": true, 	"in_process_packages": 	[ 	], 	"installed_packages": 	[ 		"ClangAutoComplete", 		"Highlight Trailing Whitespace", 		"Package Control" 	] }
it's basically just a clean build. I just installed sublime 2 days ago and installed ClangAutoComplete.
Thanks for looking into it!

I am unable to reproduce this on my system with the same version of Sublime Text. I shall try on a different machine or a VM.
Quick question, did you already have the C file open when you installed the package? Have you tried closing all the tabs and restarting ST?

@p3lim, yes I already had C files opened when installed the package.
I also tried to restart Sublime multiple times with no success.
After some time i needed to restart the whole computer and now the package is working well with all type of filesl!
IDK what was that.
But anyway thanks for looking into it!


Thread and async problems...

Do you have any problems with threads or async tasks during the mapping process? I get a request and map the json via
let json = JSON(responseObject)
var array: Array<AF_Poi> = Array()
for (index: String, subJson: JSON) in json {
let data = Mapper<AF_Poi>().map(subJson.dictionaryObject!)
array.append(data)
}
During the mapping process, the ui on the main thread is blocked. Do you have any ideas what to do about that?

It is entirely possible that mapping is blocking the UI thread. ObjectMapper executes on the thread that it is called from so it is up to the developer make sure that it does not block the UI when executing.
You could do you mapping using Grand Central dispatch like this:
// Do Object mapping on a background queue
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0)){

	let parsedObject = Mapper<T>().map(JSONResponse)

	dispatch_async(dispatch_get_main_queue()){
		// use parsedObject on main thread
	}
}