HardwareKeyboard.instance.isControlPressed not working for right control key on macOS

Steps to reproduce
I'm using a MacBook Air with an external keyboard attached. The MacBook only has a left control key, the external keyboard has both a left and a right control key.
When trying to refactor my source code from using the old RawKeyEvent to the new KeyEvent, I noticed that the right control key doesn't work with the new HardwareKeyboard class. There's no onKeyEvent for the right control key and HardwareKeyboard.instance.isControlPressed also returns false when the right control key is pressed.
Expected results
onKeyEvent and onKey both should react the same way, when the control modifier is pressed
Actual results
onKey correctly recognizes the left and the right control key. onKeyEvent only recognizes the left control key. The onKeyEvent isn't fired when the right control key is pressed.
Code sample
Code sample
TextField(
  focusNode: FocusNode(
    onKeyEvent: (node, event) { log("isControlPressedNew: ${HardwareKeyboard.instance.isControlPressed}"); return KeyEventResult.ignored; },
    onKey: (node, event) { log("isControlPressed: ${event.isControlPressed}"); return KeyEventResult.ignored; },
  ),
)

Screenshots or Video
No response
Logs
Logs (for pressing Ctrl+a in the TextField)
[log] isControlPressed: true // When ctrl was pressed
[log] isControlPressedNew: false // When "a" was pressed
[log] isControlPressed: true // When "a" was pressed

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.22.0, on macOS 14.4.1 23E224 darwin-arm64, locale
    de-DE)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.1)
[✓] VS Code (version 1.89.1)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

Thanks for the report. I was able to replicate this using external keyboard which has left and right control keys with which I get below log:
keyboard right control key press:

flutter: isControlPressed: true
flutter: isControlPressed: false
flutter: isControlPressed: true
flutter: isControlPressed: false

keyboard left control key press:

flutter: isControlPressedNew: true
flutter: isControlPressed: true
flutter: isControlPressedNew: false
flutter: isControlPressed: false
flutter: isControlPressedNew: true
flutter: isControlPressed: true
flutter: isControlPressedNew: false
flutter: isControlPressed: false

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.22.0, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.22.0 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5dcb86f68f (5 days ago), 2024-05-09 07:39:20 -0500
    • Engine revision f6344b75dc
    • Dart version 3.4.0
    • DevTools version 2.34.3
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.22.0-45.0.pre.3, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.22.0-45.0.pre.3 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fe0932f2c0 (4 hours ago), 2024-05-22 22:19:25 -0400
    • Engine revision b8b82454e3
    • Dart version 3.5.0 (build 3.5.0-178.0.dev)
    • DevTools version 2.36.0-dev.10
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

@dkwingsmt Do you have any thoughts on this?


pcli: implement stake show

Closes #340 (last outstanding component)
~/c/p/penumbra (impl-show|…) $ cargo run --release --bin pcli -- -w local_wallet.json -n <IP_ADDRESS> stake show
    Finished release [optimized] target(s) in 0.14s
     Running `target/release/pcli -w local_wallet.json -n <IP_ADDRESS> stake show`
 Name                                        Value  Exch. Rate  Tokens
 Henry's Testnet Validator<PHONE_NUMBER>92penumbra  1.3540<PHONE_NUMBER>7delegation_penumbravalid1f2zfhqe8ctc3vx4qgs37a4j9x2vytk7sejew3dkh53qxjeu0lcgq3etsdt
 Unbonded Stake<PHONE_NUMBER>55penumbra  1.0000<PHONE_NUMBER>55penumbra
 Total                      1035351.407347penumbra

Closes #340 (last outstanding component)
~/c/p/penumbra (impl-show|…) $ cargo run --release --bin pcli -- -w local_wallet.json -n <IP_ADDRESS> stake show
    Finished release [optimized] target(s) in 0.14s
     Running `target/release/pcli -w local_wallet.json -n <IP_ADDRESS> stake show`
 Name                                        Value  Exch. Rate  Tokens
 Henry's Testnet Validator<PHONE_NUMBER>92penumbra  1.3540<PHONE_NUMBER>7delegation_penumbravalid1f2zfhqe8ctc3vx4qgs37a4j9x2vytk7sejew3dkh53qxjeu0lcgq3etsdt
 Unbonded Stake<PHONE_NUMBER>55penumbra  1.0000<PHONE_NUMBER>55penumbra
 Total                      1035351.407347penumbra

the columns look nice, very readable output


Set/obtain code_challenge value

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
3.7.0
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
3.0.10
Public or Confidential Client?
Public
Description
I'm using MSAL 3.0.10 in an Angular application and can successfully obtain an authorisation code.
However, when trying to obtain a access token using the code + secret on my server, I get the following error
AADSTS501481: The Code_Verifier does not match the code_challenge supplied in the authorization request
Looking at the documentation, I need to pass code_verifier parameter in the request, which was used to generate the code_challenge in the authorisation code required in the front-end.
I can see the code_challenge value in the request the MSAL creates, but I can't seem to be able to access that value or set it myself, so I can then use it the back-end.
Thanks for any help/advise!
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
Internal (Microsoft)

@snisar thanks for submitting the question. Obtaining an auth code on the client-side and trading it on the server side is not supported by MSAL Browser. Could you tell us more about why you need to split the flow between the client and server?
Thanks.

Thanks for responding.
We're moving over from MSAL 2 and this was how our login functionality was implemented previously.
We need to verify the user exists in our own application security system, so can't rely on a ID token or email address being provided from the front end, the exchange of the Auth code plus client secret for an access/ID token provides us an extra layer of security we need. Hope this makes sense!

@snisar I'm surprised to hear this works with MSAL Browser v2, it's shouldn't be since the PKCE verifier and challenge are also required there. What are you using in the backend to trade the auth code? Can you not do the entire authentication flow from the server side?


Enable full DNS names

Description: The limit for DNS hostnames being sent to the reducer increased from 80 characters to the full 256, as according to RFC 1035.

Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-network/issues/256
Testing: automatic tests
Documentation: none

Hi @kubakukis14 , awesome you're tackling this! I see the PR is still in draft but thought I'd see if I can help out.
You probably noticed this, but just to document here, that the bpf code copies a fixed amount of bytes from the DNS packets into perf rings, and then the userspace collector parses those bytes. So this change does not need to modify eBPF code.
I don't remember whether this change would require percolating through to and within the reducer. If running this patch locally doesn't seem to output the full length from the reducer, that might be where to look.

I also triggered a build run, if helpful to your efforts

Hey @yonch, I ran into some more problems trying to test the patch out, I was hoping you could help. Assume I use the build from the unchanged public repo for the following (other than the updated java and gradle versions for building).
First is running kernel collector tests. I have build the vagrant box for ubuntu jammy64 and the necessary test targets, and ran the header tests. Those had no problem running. However running the the kernel collector test (./run-test.sh --kernel-collector-test ubuntu jammy64 according to https://github.com/open-telemetry/opentelemetry-network/blob/main/test/kernel/README.md#kernel_collector_test), I experienced timeouts. I am attaching the log for reference.
kernel-log.txt
The other problem relates to manual testing. I was hoping to run the ebpf collector pipeline in the ubuntu vagrant devbox, and get some deployments with long names to generate tcp traffic, yet I can't seem to run the ~/k8s/deploy.sh script to set up the pipeline (according to https://github.com/open-telemetry/opentelemetry-network/blob/main/dev/devbox/README.md#deploying-the-opentelemetry-ebpf-pipeline-and-optional-workloads-in-a-kubernetes-cluster-in-a-devbox-vm). I am guessing it is because the helm chart has been updated, but it was not reflected in the setup script. Are there any steps I am missing, or is there any other chart I can use?
+ microk8s helm install ebpf-net -f ebpf-net.yaml -f ebpf-net-logging-exporter.yaml --set=splunkObservability.realm=REALM --set=splunkObservability.accessToken=TOKEN splunk-otel-collector-chart/splunk-otel-collector
Error: INSTALLATION FAILED: values don't meet the specifications of the schema(s) in the following chart(s):
splunk-otel-collector:
- (root): Additional property networkExplorer is not allowed

I am not sure if I have the right approach for this, could you please give me some pointers? What is the usual scenario for developing and testing new patches for the kernel collector? Sorry for dumping this here and thank you in advance, setting it all up has been a little frustrating.

@yonch After enabling extraction of full dns names in previous commits for the kernel collector, they had now been cut off from the right. After walking through the reducer pipeline I've managed to find the spot where the truncation is happening. The place is https://github.com/open-telemetry/opentelemetry-network/blob/d7441104b8739785466b46f3d9f777c1d39917a2/reducer/matching/flow_span.cc#L266, during the creation of agg_root. Since agg_root::role2_t (short_string<80>) is defined in generated code, I'm not quite sure how to change it, and what changing it would imply, so I'm going to need some help with this. How do you think I should proceed?
Here's some debug prints I put around the suspected code:
role_a: nc, role_b: tcp-server-service-abcdefghijklmnopqrstuvwxyzabcdef0123456789.ebpf-net-ns.svc.cluster.local, az_a: (null), az_b: (null)
role1: nc, role2: tcp-server-service-abcdefghijklmnopqrstuvwxyzabcdef0123456789.ebpf-net-ns.svc.cl, az1: , az2:

I believe enlarging the role field should solve the issue.
On another note, this account will likely not get CLA authorised, so once we figure out this issue I'd like to move to a different account and PR and archive this convo.

Thank you for persevering, sorry for missing your comment.
The specification for generated code is in the render directory. This might be the line:
https://github.com/open-telemetry/opentelemetry-network/blob/d7441104b8739785466b46f3d9f777c1d39917a2/render/ebpf_net.render#L1328
The render language generated both messages, and the code and data structures to handle them (serialization/deserialization). Changing render on the aggregation core would change only components internal to the aggregation core so is safe, go ahead see if it increases the length throughout (iirc it should).
Hope that’s what you were looking for.. please lmk if I didn’t get it right.

Thanks @yonch, that was exactly what I was looking for. I managed to get it working and tested and moved it under my CLA authorized account, here: https://github.com/open-telemetry/opentelemetry-network/pull/266

superseded by #266, closing


Smeared imagery on some mobile devices

Originally reported here:
https://groups.google.com/d/topic/cesium-dev/ouQyJY0LiRs/discussion
The immediate cause is that the webMercatorT vertex attribute is receiving incorrect values in the imagery reprojection shader.  The attribute is set with the following code (in ImageryLayer):
reproject.vertexArray.getAttribute(1).vertexBuffer.copyFromArrayView(webMercatorT);

I've confirmed that the webMerctorT Float32Array is correct.  On the problematic mobile devices (HTC One M7 in my case), this line actually corrupts the attribute - values that were provided when the vertex array was originally created are actually replaced with garbage.
The best part is that this problem goes away if we don't use OES_vertex_array_object.  Comment out this._vertexArrayObject = getExtension(gl, ['OES_vertex_array_object']); in Context and everything is fine.
I tried to demonstrate this problem with a simpler test, but apparently my test is too simple because it passed even on my M7.  Here's what I tried:
    it('can update vertex buffer', function() {
        var vs = '\
            attribute vec4 position;\
            attribute float test;\
            varying float v_test;\
            void main()\
            {\
                v_test = test;\
                gl_PointSize = 1.0;\
                gl_Position = position;\
            }';
        var fs = '\
            varying float v_test;\
            void main()\
            {\
                gl_FragColor = vec4(v_test == 0.5);\
            }';

        var context = createContext();
        var sp = context.createShaderProgram(vs, fs);

        var va = context.createVertexArray([
            {
                index : sp.vertexAttributes.position.index,
                vertexBuffer : context.createVertexBuffer(new Float32Array([0, 0, 0, 1, 0, 0, 0, 1]), BufferUsage.STATIC_DRAW),
                componentsPerAttribute : 4
            },
            {
                index : sp.vertexAttributes.test.index,
                vertexBuffer : context.createVertexBuffer(new Float32Array([0.0, 0.0]), BufferUsage.STATIC_DRAW),
                componentsPerAttribute : 1
            }
        ]);

        ClearCommand.ALL.execute(context);
        expect(context.readPixels()).toEqual([0, 0, 0, 0]);

        var command = new DrawCommand({
            primitiveType : PrimitiveType.POINTS,
            shaderProgram : sp,
            vertexArray : va
        });

        va.getAttribute(1).vertexBuffer.copyFromArrayView(new Float32Array([0.5, 0.5]));

        command.execute(context);
        expect(context.readPixels()).toEqual([255, 255, 255, 255]);

        sp = sp.destroy();
        va = va.destroy();
    });

Maybe @pjcozzi or @bagnell could take a quick look at the reprojection code in ImageryLayer to see if I'm doing something stupid, maybe along the lines of that impossible-to-debug Firefox-on-Mac-only problem from awhile back that turned out to be my failure to explicitly specify vertex attribute indices.
If not, I guess we'll need to try harder to turn this into a test case to report it as a bug to the browser vendors.  Since it happens in both Chrome and Firefox on this device, though, it's probably a GPU/driver bug and we'll need a workaround instead (such as not using VAOs on these devices).

Try storing the vertex buffer in a separate variable for accessing it, which is commonly done through the primitives.
Perhaps there is a bug in VertexArray where _attributes is mis-ordered when VAOs are present.
Perhaps there is a state issue since that test didn't fail...I wouldn't think so though.

I'm still a long way from an answer, but here are some interesting new facts:

Creating a new vertex array for every reprojection fixes the problem.
Saving off the vertex buffer immediately after creating that array and using that in later frames doesn't have any effect (still broken).
Combining the two vertex buffers into a single vertex buffer, so the one and only vertex buffer is updated on each reprojection, does NOT fix the problem.

I wasn't able to identify a Sandcastle example (or any other example) that causes Primitive to invoke this problematic copyFromArrayView.  BillboardCollection uses it via VertexArrayFacade, but code that exercises that (such as simple.czml) works fine on this device.
So I'll keep looking at it when I get a chance, but ideas are welcome!

Creating a new vertex array for every reprojection fixes the problem.

The vertex buffers are being created with BufferUsage.STATIC_DRAW, which is just a hint to the driver, but it is wrong in this case.  We want BufferUsage.STREAM_DRAW since we rewrite the buffer each draw call (like streaming video).
In my experience, some drivers ignore this hint; on others, it has a significant performance impact.  I have ran into cases where I said something was STATIC, and then wrote to it and it was either really slow or didn't work (I can't remember) so I could expect a bug here.
Also, have you tested Chrome and Firefox?  Stable and Canary?

The vertex buffers are being created with BufferUsage.STATIC_DRAW

No, there are two vertex buffers, one for positions and one for the texture coordinates.  The positions never change and are created STATIC_DRAW.  The texture coordinate are updated every time and are created STREAM_DRAW.
https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Scene/ImageryLayer.js#L835
Chrome and Firefox both fail.  I haven't tried beta versions, but I will next time Kristen isn't using her phone. :)

Ah, I was only looking at the example above.  Maybe try changing them both to STREAM or DYNAMIC and also updating the positions each frame.  It is possible the driver has a coalescing bug.
Are you running the latest OS?  How prominent is this bug?  It would be a shame to have to put a hacky workaround in.

It's the latest OS available on this phone currently (though apparently it's supposed to get an update to 5.0 tomorrow).  I might hold off on updating, though, for fear of losing the ability to reproduce the problem.  Even if 5.0 fixes it, very few devices have Lollipop yet.  Someone on the forum reported a whole long list of devices it happens on, and when it happens Cesium is totally unusable.  So I think it's worth a workaround.
Will play with it more when I get a chance, but that probably won't be until Friday (I'm going to a conference starting tomorrow morning).

Any update or a workaround for this issue?
Thanks, Ian

No, update, but I mentioned a workaround in my original comments in this issue:

Comment out this._vertexArrayObject = getExtension(gl, ['OES_vertex_array_object']); in Context and everything is fine.

By Context I meant Source/Renderer/Context.js.  The Contributor's Guide has information on building your own version of Cesium including this change (it's not too hard).

Kevin,
Thanks we will try the work around this week.
Regards
Ian
From: Kevin Ring<EMAIL_ADDRESS>Sent: Sunday, March 29, 2015 4:59 AM
To: AnalyticalGraphicsInc/cesium
Cc: Ian Walberg
Subject: Re: [cesium] Smeared imagery on some mobile devices (#2541)
No, update, but I mentioned a workaround in my original comments in this issue:
Comment out this._vertexArrayObject = getExtension(gl, ['OES_vertex_array_object']); in Context and everything is fine.
By Context I meant Source/Renderer/Context.js. The Contributor's Guidehttps://github.com/AnalyticalGraphicsInc/cesium/wiki/Contributor's-Guide has information on building your own version of Cesium including this change (it's not too hard).
—
Reply to this email directly or view it on GitHubhttps://github.com/AnalyticalGraphicsInc/cesium/issues/2541#issuecomment-87403514.

Also reported here: https://groups.google.com/forum/?hl=en#!topic/cesium-dev/4b1COszHwCE

I don't have a device I can test this on anymore, but it's very likely that #4339 will fix it.

Actually sorry #4339 won't fix it completely, because it still does reprojection for images in terrain tiles that cross 85 degrees latitude.  But it should make the rest of the globe work at least.


Add support Windows

Hello,
Are you planning to add support for Windows?
Thank you!

Currently ffmpeg_kit_flutter doesn't support Windows platform.


Alter CostCentre model code field length. In settings, change ALLOWED_DOMAIN -> ALLOWED_DOMAINS.

This change is

Changes Unknown when pulling 4a804bf8a4043ae86a8b5ae46eee6e00129197ab on ropable:prod-oldui into ** on parksandwildlife:prod-oldui**.


dnscrypt-proxy: error while loading shared libraries: libsodium.so.13: cannot open shared object file: No such file or directory

got this problem on ubuntu14.04

If you compiled it manually, did you run ldconfig after having installed libsodium?

thx resolved.  good work!


Fix delete index error message

DELETE api/v1/indexes/gh-archive-009
 {"error": String("Metastore error `Index `gh-archive-009` already exists.`.")}

I can't reproduce it, can you give more details about it?

@guilload

The client I'm using displays JSON bodies in Debug fmt...


Using different sized images?

Is there any easy way load images of a different size? I've noticed that if I specify a 'height' on the HTML img elements, it does increase the height. However, specifying 'width' on the images has no affect. It appears that in order to make the images wider, you have to make the coverflow component wider

@devinholloway I'll take a look at this

Fixed with most recent push https://github.com/andyyou/react-coverflow/commit/81626974e293712cf6eed429ad1e7be5189dacf2


10/18/2018 18:00 : Create Pull Request for branch master -> prTesting1_2018101817

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: LOPS-384: Add synchronizable flag to storages

PR fulfills these requirements

[X] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[X] Tests for the changes have been added/updated (for bug fixes/features)
[X] Docs have been added/updated (for bug fixes/features)
[X] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[X] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[ ] Backend (Database)
[X] Backend (API)
[ ] Frontend

Describe the reason for change
(link to issue, supportive screenshots etc.)
Add synchronizable flag to storages in case user wants to freeze sync
What does this fix?
(if this is a bug fix)
Add synchronizable flag to storages
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
No
Does this change affect security?
(if so describe the impacts positive or negative)
No
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[X] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[X] integration
[ ] unit

Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Storages

/git merge develop


Transactions are not invoked in network with 4 validation peers (pbft consensus plugin)

Description
I am trying to setup environment with 4 validation peers ( pbft consensus plugin ) in plain virtual machines (without any Docker) and follow the descriptions described here.
But when I do 'query' (after deploy and invoke operations of course) I have got an error 'Error: Error querying chaincode: rpc error: code = 2 desc = "Error:Failed to launch chaincode spec(Could not get deployment transaction for mycc - LedgerError - ResourceNotFound: ledger: resource not found)"'.
I have just the following log messages from chaincode_example02:
10:58:22.549 [shim] DEBU : Peer address: <IP_ADDRESS>:30303 10:58:22.550 [shim] DEBU : os.Args returns: [./chaincode_example02]   10:58:22.550 [shim] DEBU : Registering.. sending REGISTER   10:58:22.552 [shim] DEBU : []Received message REGISTERED from shim   10:58:22.552 [shim] DEBU : []Handling ChaincodeMessage of type: REGISTERED(state:created)   10:58:22.552 [shim] DEBU : Received REGISTERED, ready for invocations
Logs from peer:
11:03:40.713 [devops] Deploy -> DEBU 27f Creating deployment transaction (mycc) 11:03:40.713 [devops] Deploy -> DEBU 280 Sending deploy transaction (mycc) to validator 11:03:40.713 [peer] sendTransactionsToLocalEngine -> DEBU 281 Marshalling transaction CHAINCODE_DEPLOY to send to local engine 11:03:40.714 [peer] sendTransactionsToLocalEngine -> DEBU 282 Sending message CHAIN_TRANSACTION with timestamp seconds:1465470220 nanos:714045682  to local engine 11:03:40.714 [consensus/obcpbft] RecvMsg -> INFO 283 New consensus request received 11:03:40.714 [peer] SendMessage -> DEBU 284 Sending message to stream of type: CONSENSUS  11:03:40.714 [peer] func1 -> DEBU 285 Sending 72 bytes to <IP_ADDRESS>:30303 took 133.771µs 11:03:40.714 [peer] Broadcast -> DEBU 286 Broadcast took 185.31µs 11:03:40.714 [consensus/obcpbft] ProcessEvent -> DEBU 287 Replica 0 processing event 11:03:40.714 [consensus/obcpbft] ProcessEvent -> DEBU 288 Replica 0 received incoming message from 0 11:03:40.714 [consensus/obcpbft] ProcessEvent -> DEBU 289 Replica 0 processing event 11:03:40.714 [consensus/obcpbft] recvRequest -> DEBU 28a Replica 0 received request: KSh6+6VJvSzr+olDe8LZ1vK8KieVtU1jcqUAP67Jr/Th1Zpg7omBBdn2jKdRx1OFUYMhgRBox31E9sEAO7Guqw== 11:03:40.714 [consensus/obcpbft] softStartTimer -> DEBU 28b Replica 0 soft starting new view timer for 2s: new request KSh6+6VJvSzr+olDe8LZ1vK8KieVtU1jcqUAP67Jr/Th1Zpg7omBBdn2jKdRx1OFUYMhgRBox31E9sEAO7Guqw== 11:03:40.714 [consensus/obcpbft] sendPrePrepare -> DEBU 28c Replica 0 is primary, issuing pre-prepare for request KSh6+6VJvSzr+olDe8LZ1vK8KieVtU1jcqUAP67Jr/Th1Zpg7omBBdn2jKdRx1OFUYMhgRBox31E9sEAO7Guqw== 11:03:40.714 [consensus/obcpbft] sendPrePrepare -> DEBU 28d Primary 0 broadcasting pre-prepare for view=0/seqNo=1 and digest KSh6+6VJvSzr+olDe8LZ1vK8KieVtU1jcqUAP67Jr/Th1Zpg7omBBdn2jKdRx1OFUYMhgRBox31E9sEAO7Guqw== 11:03:40.715 [peer] SendMessage -> DEBU 28e Sending message to stream of type: CONSENSUS  11:03:40.715 [peer] func1 -> DEBU 28f Sending 167 bytes to <IP_ADDRESS>:30303 took 128.206µs 11:03:40.715 [peer] Broadcast -> DEBU 290 Broadcast took 174.276µs 11:03:40.715 [consensus/obcpbft] prepared -> DEBU 291 Replica 0 prepare count for view=0/seqNo=1: 0 11:03:40.715 [consensus/obcpbft/events] loop -> DEBU 292 Starting timer 11:03:40.715 [consensus/obcpbft/events] loop -> WARN 293 Attempting to stop an unfired idle timer 11:03:40.716 [consensus/obcpbft/events] loop -> DEBU 294 Stopping timer for 11:03:40.719 [consensus/obcpbft] ProcessEvent -> DEBU 295 Replica 0 processing event 11:03:40.719 [consensus/obcpbft] ProcessEvent -> DEBU 296 Replica 0 received incoming message from 1 11:03:40.719 [consensus/obcpbft] ProcessEvent -> DEBU 297 Replica 0 processing event 11:03:40.719 [consensus/obcpbft] recvPrepare -> DEBU 298 Replica 0 received prepare from replica 1 for view=0/seqNo=1 11:03:40.719 [consensus/obcpbft] prepared -> DEBU 299 Replica 0 prepare count for view=0/seqNo=1: 1 11:03:40.719 [consensus/obcpbft] prepared -> DEBU 29a Replica 0 prepare count for view=0/seqNo=1: 1 11:03:42.715 [consensus/obcpbft/events] loop -> DEBU 29b Event timer fired 11:03:42.715 [consensus/obcpbft/events] loop -> DEBU 29c Timer event delivered 11:03:42.715 [consensus/obcpbft] ProcessEvent -> DEBU 29d Replica 0 processing event 11:03:42.715 [consensus/obcpbft] ProcessEvent -> INFO 29e Replica 0 view change timer expired, sending view change: new request KSh6+6VJvSzr+olDe8LZ1vK8KieVtU1jcqUAP67Jr/Th1Zpg7omBBdn2jKdRx1OFUYMhgRBox31E9sEAO7Guqw== 11:03:42.715 [consensus/obcpbft] stopTimer -> DEBU 29f Replica 0 stopping a running new view timer 11:03:42.715 [consensus/obcpbft] prepared -> DEBU 2a0 Replica 0 prepare count for view=0/seqNo=1: 1 11:03:42.716 [consensus/handler] Sign -> DEBU 2a1 Security is disabled 11:03:42.716 [consensus/obcpbft] sendViewChange -> INFO 2a2 Replica 0 sending view-change, v:1, h:0, |C|:1, |P|:0, |Q|:1 11:03:42.716 [peer] SendMessage -> DEBU 2a3 Sending message to stream of type: CONSENSUS  11:03:42.716 [peer] func1 -> DEBU 2a4 Sending 227 bytes to <IP_ADDRESS>:30303 took 182.973µs 11:03:42.716 [peer] Broadcast -> DEBU 2a5 Broadcast took 253.413µs 11:03:42.716 [consensus/obcpbft] recvViewChange -> INFO 2a6 Replica 0 received view-change from replica 0, v:1, h:0, |C|:1, |P|:0, |Q|:1 11:03:42.716 [consensus/handler] Verify -> DEBU 2a7 Security is disabled 11:03:42.716 [consensus/obcpbft] recvViewChange -> DEBU 2a8 Replica 0 now has 1 view change requests for view 1 11:03:42.716 [consensus/obcpbft/events] loop -> WARN 2a9 Attempting to stop an unfired idle timer 11:03:42.716 [consensus/obcpbft/events] loop -> DEBU 2aa Stopping timer for 11:03:42.723 [consensus/obcpbft] ProcessEvent -> DEBU 2ab Replica 0 processing event 11:03:42.723 [consensus/obcpbft] ProcessEvent -> DEBU 2ac Replica 0 received incoming message from 1 11:03:42.723 [consensus/obcpbft] ProcessEvent -> DEBU 2ad Replica 0 processing event 11:03:42.723 [consensus/obcpbft] recvViewChange -> INFO 2ae Replica 0 received view-change from replica 1, v:1, h:0, |C|:1, |P|:0, |Q|:3 11:03:42.723 [consensus/handler] Verify -> DEBU 2af Security is disabled 11:03:42.723 [consensus/obcpbft] recvViewChange -> DEBU 2b0 Replica 0 now has 2 view change requests for view 1 11:03:43.805 [devops] createExecTx -> DEBU 2b1 Creating invocation transaction (fd8d9db9-d6dd-4f2a-9793-818add210936) 11:03:43.805 [devops] invokeOrQuery -> DEBU 2b2 Sending invocation transaction (fd8d9db9-d6dd-4f2a-9793-818add210936) to validator 11:03:43.806 [peer] sendTransactionsToLocalEngine -> DEBU 2b3 Marshalling transaction CHAINCODE_INVOKE to send to local engine 11:03:43.806 [peer] sendTransactionsToLocalEngine -> DEBU 2b4 Sending message CHAIN_TRANSACTION with timestamp seconds:1465470223 nanos:806155453  to local engine 11:03:43.806 [consensus/obcpbft] RecvMsg -> INFO 2b5 New consensus request received 11:03:43.806 [peer] SendMessage -> DEBU 2b6 Sending message to stream of type: CONSENSUS  11:03:43.806 [peer] func1 -> DEBU 2b7 Sending 100 bytes to <IP_ADDRESS>:30303 took 408.96µs 11:03:43.807 [peer] Broadcast -> DEBU 2b8 Broadcast took 541.243µs 11:03:43.807 [consensus/obcpbft] ProcessEvent -> DEBU 2b9 Replica 0 processing event 11:03:43.807 [consensus/obcpbft] ProcessEvent -> DEBU 2ba Replica 0 received incoming message from 0 11:03:43.808 [consensus/obcpbft] ProcessEvent -> DEBU 2bb Replica 0 processing event 11:03:43.808 [consensus/obcpbft] recvRequest -> DEBU 2bc Replica 0 received request: fb9DXPg3u3DSCGdU4WWm8dgKeCNYWq9V0/gmQxYjapM/1kCRytMR2OQaVu68hYytwPkKvfMuUXM6ggh/aIQ+Lw== 11:03:43.808 [consensus/obcpbft] recvRequest -> DEBU 2bd Replica 0 is backup, not sending pre-prepare for request fb9DXPg3u3DSCGdU4WWm8dgKeCNYWq9V0/gmQxYjapM/1kCRytMR2OQaVu68hYytwPkKvfMuUXM6ggh/aIQ+Lw== 11:03:43.866 [peer] SendMessage -> DEBU 2be Sending message to stream of type: DISC_GET_PEERS  11:03:43.869 [consensus/handler] HandleMessage -> DEBU 2bf Did not handle message of type DISC_GET_PEERS, passing on to next MessageHandler 11:03:43.869 [peer] HandleMessage -> DEBU 2c0 Handling Message of type: DISC_GET_PEERS  11:03:43.869 [peer] beforeGetPeers -> DEBU 2c1 Sending back DISC_PEERS 11:03:43.869 [peer] SendMessage -> DEBU 2c2 Sending message to stream of type: DISC_PEERS  11:03:43.870 [consensus/handler] HandleMessage -> DEBU 2c3 Did not handle message of type DISC_PEERS, passing on to next MessageHandler 11:03:43.870 [peer] HandleMessage -> DEBU 2c4 Handling Message of type: DISC_PEERS  11:03:43.870 [peer] beforePeers -> DEBU 2c5 Received DISC_PEERS, grabbing peers message 11:03:43.870 [peer] beforePeers -> DEBU 2c6 Received PeersMessage with Peers: peers:<ID:<name:"vp0" > address:"<IP_ADDRESS>:30303" type:VALIDATOR > peers:<ID:<name:"vp2" > address:"<IP_ADDRESS>:30303" type:VALIDATOR >  11:03:43.870 [peer] chatWithSomePeers -> DEBU 2c7 Skipping my own address(<IP_ADDRESS>:30303)
Everething is ok when noops is activated (I have a lot of logs in chaincode terminal and height and currentBlockHash values are changed
Describe How to Reproduce
I have changed only peer.validator.consensus.plugin from noops to pbft and chaincode.mode from net to dev.

I think you need to pass the chaincode id as returned from the deploy transaction.

@grbulat : I'm assuming you are following (and modifying) the SandboxSetup instructions so you can eliminate docker for running in VMs ? (Basically run peer and chaincode in the VMs without any docker dependencies so you don't run into VM issues doced in https://github.com/hyperledger/fabric/blob/master/docs/dev-setup/devenv.md.)
I'll note that those instructions were meant for dev mode/noops/single peer only ... however the fact you made it work for noops does beg the question why it does not run for pbft.
The error ""Error:Failed to launch chaincode spec(Could not get deployment transaction for mycc - LedgerError - ResourceNotFound: ledger: resource not found)"' says the original deploy transaction was not found in the ledger for some reason.
By the way, before you switched to PBFT, I assume you cleared the old database with
rm -rf /path/to/hyperledger/*

In vagrant this would be
rm -rf /var/hyperledger/*

few questions

what level of code are you on ?
what is the command line for peers and chaincode in the VMs ?
can you attach logs from all 4 peers you are sending the query and invokes to ?
can you attach logs from all 4 chaincodes ?

Zip/tar of the logs work as well.

@corecode : didn't see your comment when I added mine. Does mine make sense ?

@muralisrini Yes, I don't use docker. Is it wrong?

I assume you cleared the old database with

Yes, of course I clear it before switching.

what level of code are you on ?

hmm..what do you mean?

what is the command line for peers and chaincode in the VMs ?

for the base peer: CORE_PEER_ID=vp0 ./peer node start --logging-level=debug.
for the other peers (vp value change of course): CORE_PEER_ID=vp1 CORE_PEER_DISCOVERY_ROOTNODE=<IP_ADDRESS>:30303 ./peer node start --logging-level=debug
for the chaincode: CORE_CHAINCODE_ID_NAME=mycc CORE_PEER_ADDRESS=<IP_ADDRESS>:30303 ./chaincode_example02

can you attach logs from all 4 peers you are sending the query and invokes to ?

My issue description contains logs for vp0 and chaincode. I attach log file from another vp now.
vp_logs.txt

can you attach logs from all 4 chaincodes ?

hmm...I installed only 1 chaincode and it is running with vp0. Log from this chaincode is in my issue description. Nothing else.
I used following set of commands then:
./peer chaincode deploy -n mycc -c '{"Function":"init", "Args": ["a","100", "b", "200"]}'
./peer chaincode invoke -l golang -n mycc -c '{"Function": "invoke", "Args": ["a", "b", "10"]}'
./peer chaincode query -l golang -n mycc -c '{"Function": "query", "Args": ["b"]}'

@grbulat

hmm...I installed only 1 chaincode and it is running with vp0. Log from this chaincode is in my issue description. Nothing else.

If you are running 4 peers, each of them should be running the chaincode. In non-dev mode this is done automatically for you by the peer by starting the chaincode in docker.
However that still does not explain why you are getting the error only in PBFT classic (although stricter, I'd expect the executions to succeed on vp0 at least).  BTW, I'm assuming the requests were directed to vp0 that's running the chaincode and the error is from that peer.
The attached vp_logs.txt has only the tail of the logs. Would need the entire log to debug.

@muralisrini

BTW, I'm assuming the requests were directed to vp0 that's running the chaincode and the error is from that peer.

yes, that is right.
I'v attached new log files:
chaincode_vp0.txt
vp0.txt
vp1.txt

@muralisrini
Unfortunately, I still have the same errors with 'no docker' environment. There are no any added data.
But I installed 4 validation peers in docker container as you suggest here. currentBlockHash and height are changed, but query command still raise an error 'Error: Error querying chaincode: rpc error: code = 2 desc = "Error:Failed to launch chaincode spec(Error starting container: cannot connect to Docker endpoint)"'. And the second problem is when I terminate one peer and launch another peer container with empty database, the sync process is not started and height value equal to 1 (another peers height > 1).
However, I am wondering to install environment without docker. Is there any reason to not do so? I can provide new logs from peers if it helps. Thank you!

Eventually, I have done it with 'partial' docker environment (peers in theirs own virtual machines, but chaincode run in docker container).
Commands to start peers:
CORE_VM_ENDPOINT=http://<IP_ADDRESS>:2375 CORE_PEER_ADDRESSAUTODETECT=true CORE_PEER_ID=vp0 ./peer node start --logging-level=debug
CORE_VM_ENDPOINT=http://<IP_ADDRESS>:2375 CORE_PEER_ADDRESSAUTODETECT=true CORE_PEER_ID=vp1 CORE_PEER_DISCOVERY_ROOTNODE=<IP_ADDRESS>:30303 ./peer node start --logging-level=debug
and so forth.
For the chaincode:
CORE_PEER_ADDRESS=<IP_ADDRESS>:30303 ./peer chaincode deploy -p github.com/hyperledger/fabric/examples/chaincode/go/chaincode_example02 -c '{"Function":"init", "Args": ["a","100", "b", "200"]}'
CORE_PEER_ADDRESS=<IP_ADDRESS>:30303 ./peer chaincode invoke -l golang -n bb54ee9752ee3742b52f4a204a4eb0693c364cf10540127c75b0ca119fb8db1e2130a73287469ed2341d19f146f58d0572d1a00a79e6f5834946b0e04e53920b -c '{"Function": "invoke", "Args": ["a", "b", "10"]}'

This still doesnt work on pbft on different machines (different vms on different cloud) but works on noops


Table and columns comments to descriptions

Would be nice to have table and columns comments stored as description metadata.
Will be necessary to update storage console and table preview dialog in UI

solved in 3.0.1


Debugging through readonly internal module has weird reveal behaviour

Steps to Reproduce:

debug into a node module (e.g. process.send)
step over the implementation in that file

=> each step results in the current line to be centerd vertically which makes it hard to follow the code flow
=> I would only expect the scrolling to reveal the current line if the line is out of view

Dup of https://github.com/Microsoft/vscode/issues/12438


Implement advanced tabular backbone

🚀 Feature
Use some of the recent research paper for implementing new tabular backbone
Motivation
Tabular data is used in industry very often. There has been some model being developed to treat it.
Pitch
Two papers with code that could be interesting:
https://paperswithcode.com/paper/revisiting-deep-learning-models-for-tabular
https://paperswithcode.com/paper/saint-improved-neural-networks-for-tabular

closing this issue as I opened a similar one here https://github.com/manujosephv/pytorch_tabular/issues/30.


Driver IRQL Not Less or Equal BSOD Error

Greetings, I have a Windows Web Server 2008 R2 on a KVM Ubuntu system which was crashing with the Driver_IRQL_Not_Less_Or_Equal BSOD Error. It happened again twice recently when extracting a large zip file with 7-zip. It's happened when restoring a backup of files, and other times as well.
The Virtio drivers are the only ones I've installed, for the network, storage and some kind of 'balloon' driver. Also I thought that I might need updated Virtio Drivers so I found an Updated ISO for the Virtio Drivers and downloaded it to the VPS Control system, though the 64 bit exe setup file doesn't work on Windows Web Server 2008 R2, and when I tried to manually update the drivers from that ISO, I got the message that the most current or best drivers were already installed.

Thank you.
Here's the Dump file: https://dropbox.com/sh/dz417bgsf3soj87/AABjQEAXwXMCaf82C-11ofZta?dl=0

This crash happened again recently when 7Zip was almost finished extracting a large OAR file. So I can't use 7Zip for that again. WinRAR works better for the larger files.

Then one of the task bar icons disappeared after the next startup, so I scheduled a Disk Check, and the icon reappeared after the disk check.

@life777eternal
Can you please zip the crash dump file and share it through dropbox or google drive ?
Thanks,
Vadim.

Might be able to later today, after work, and I already restarted my server after the crash. Not sure where to find it now though. I have a Dropbox account, aye.

Thanks a lot,
Normally, after the system reboot , it should be stored as  C:\WINDOWS\MEMORY.DMP
And, yes, the installer includes Win8/Win10 drivers only. It will not work on Web Server 2008 R2

Are you able to make an installer for Windows 7 / Windows Web Server 2008 R2? Or at least release drivers for Windows Web Server 2008 R2, for manual installation?   The dump file is 268 MB, do you have WinRAR or 7Zip? (for a RAR or 7Z file extraction). The compressed RAR file is 53 MB and the 7Z file is 46 MB. (& I actually made a ZIP file, just for comparison, and it's 68.9 MB)  ... (I'll edit the post above and add in the link, once I have it, so it doesn't get emailed through insecure email.)  Thank you.

It looks as the viostor driver is extremely old (built on Jul 31st 2012). Where did you get it from?
I suggest switching to the more recent one available from
https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/archive-virtio/virtio-win-0.1.196-1/virtio-win.iso
There is no installer for pre-Win8 platforms, but the driver updating procedure is quite straightforward when using "Device Manager"
Best, Vadim.

Oh alright, thanks. The Network Administrator at the company hosting my server gave me this https://linux-kvm.org/page/WindowsGuestDrivers/Download_Drivers in a ticket. That might be the drivers I have had.

It looks as the viostor driver is extremely old (built on Jul 31st 2012). Where did you get it from?
I suggest switching to the more recent one available from
https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/archive-virtio/virtio-win-0.1.196-1/virtio-win.iso
There is no installer for pre-Win8 platforms, but the driver updating procedure is quite straightforward when using "Device Manager"
Best, Vadim.

Which device is supposed to use the Viostor driver? Windows thinks that all the device drivers are already up to date. That viostor.sys has always been on the BSOD Errors.

Start "Device Manager" go to "Storage Controllers" right click on "Red Hat VirtIO SCSI controller" -> "Update Driver" -> "Browse My Computer.."
and navigate to virtio-win.iso_mount_point\viostor\2k8R2\amd64\

Thanks, I tried that and Windows still thinks that the best driver software is already installed and skipping the new driver.

It looks as the viostor driver is extremely old (built on Jul 31st 2012). Where did you get it from? I suggest switching to the more recent one available from https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/archive-virtio/virtio-win-0.1.196-1/virtio-win.iso
There is no installer for pre-Win8 platforms, but the driver updating procedure is quite straightforward when using "Device Manager"
Best, Vadim.

Greetings Vadim, I've noticed that there's a newer one available as of this year. Should I try to use that one? https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/archive-virtio/virtio-win-0.1.248-1/virtio-win.iso
Thank you, Shalom.

Hi @life777eternal  ,
It is always a good decision to update the drivers with the latest ones, when it is possible. Just please note that we discontinued building Win8/8.1 and WS2012/2012R2 virtio-win drivers recently and removed these drivers from virtio-win installer (while they are still can be found on ISO and installed manually via the Device Manager).
All the best and Shalom :)
Vadim.


[BUG] Additional software required on Linux

🐛 Bug
I had to install additional software before nle would build on Linux
Some requirements were obvious to me, some were not.
Here's what worked
conda create -n minihack python=3.8
conda activate minihack
sudo apt install cmake
sudo apt install build-essential
sudo apt install python3-dev
sudo apt install libbz2-dev
pip install minihack
# NB> I had previously run sudo apt install libpcre3-dev
# in order to install gym

To Reproduce
run (without the additional dependencies)
conda create -n minihack python=3.8
conda activate minihack
pip install minihack

result;
Failed to build nle
ERROR: Could not build wheels for nle which use PEP 517 and cannot be installed directly
Environment
Linux Mint 20.2
Python 3.8.12
conda 4.10.3

Hi @romilly. Thanks for your contribution. In our instructions on how to install MiniHack, there is a Note regarding installing NLE on Ubuntu. We refer the users to NLE installation instructions for this. I see that the dependencies you added yourself are already included in there. Perhaps this wasn't well highlighted in the README, apologies for that.
Feel free to reopen in case you have any further issues.


error after last update

I update HA to 0.89.1 from 0.88. SmartIR update too. After that i have error and component not working.
I don't change configuration, only update
2019-03-11 14:34:01 ERROR (MainThread) [homeassistant.loader] Error loading custom_components.smartir.climate. Make sure all dependencies are installed
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/homeassistant/loader.py", line 166, in _load_file
module = importlib.import_module(path)
File "/usr/lib/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 665, in _load_unlocked
File "", line 678, in exec_module
File "", line 219, in _call_with_frames_removed
File "/home/acidquest/.homeassistant/custom_components/smartir/climate.py", line 17, in
from homeassistant.components.climate import (
ImportError: cannot import name 'STATE_HEAT'
2019-03-11 14:34:01 ERROR (MainThread) [homeassistant.loader] Unable to find platform smartir. Search path was limited to path of component: custom_components
2019-03-11 14:43:03 ERROR (SyncWorker_3) [homeassistant.loader] Error loading custom_components.smartir.climate. Make sure all dependencies are installed
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/homeassistant/loader.py", line 166, in _load_file
module = importlib.import_module(path)
File "/usr/lib/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 665, in _load_unlocked
File "", line 678, in exec_module
File "", line 219, in _call_with_frames_removed
File "/home/acidquest/.homeassistant/custom_components/smartir/climate.py", line 20, in
from . import COMPONENT_ABS_DIR, Helper
ImportError: cannot import name 'COMPONENT_ABS_DIR'
2019-03-11 14:43:03 ERROR (SyncWorker_3) [homeassistant.loader] Unable to find platform smartir. Search path was limited to path of component: custom_components

Please close issue.
I updated the component again, this time manually. after that, everything worked. The first time I updated using the update service.


Intelligent Code Completion in Docker

Hi,
how to get working Intelligent Code Completion with Docker (cypress/included:3.6.1)?
I have spec with triple dash directive:
/// <reference types="Cypress" />

I suppose it is necessary to have mounted node_modules from Dockert container, but I cant make it work.
Thx

Well, since your editor is local, and the Cypress Test Runner (with TS types) is installed in an image that is not running, I don't think this is possible. I recommend installing Cypress locally as a normal NPM dependency and then using one of the standard Docker images like cypress/base or cypress/browsers to run tests on CI, see https://on.cypress.io/ci

Hi,
thank you for reply. Installation of another Cypress out of container make no sense for me.
Here is my quick and dirty workaround... :)
My project structure (NodeJS app in app/, E2E in cypress/)
.
├── cypress
│   ├── fixtures
│   ├── integration
│   ├── node_modules
│   ├── screenshots
│   ├── support
│   ├── utils
│   └── videos
├── app
│   ├── docker
│   ├── jest.config.js
│   ├── node_modules
│   ├── package.json
│   ├── src
│   ├── webpack.config.js
│   └── yarn.lock
├── cypress.json
├── docker-compose.override.yml
├── docker-compose.yml
├── Makefile
└── README.md

Folder cypress/node_modules must be empty (dont forget .gitignore it).
My docker-compose.yml, simplified.
version: '3.7'

volumes:
  dbvol: {}

services:
  app:
    build: ...
    volumes:
      - './app:/app:rw,cached'
    ports:
      - '80:80/tcp'

  db:
    image: some.registry/mariadb:v123
    ports:
      - '3306:3306/tcp'
    volumes:
      - dbvol:/var/lib/mysql

  cypress:
    image: 'cypress/included:3.6.1'
    volumes:
      - './cypress.json:/e2e/cypress.json'
      - './cypress:/e2e/cypress'
      - '/dev/shm:/dev/shm'
    environment:
      - DISPLAY
    entrypoint: >
      /bin/sh -c 'rm -Rf /e2e/cypress/node_modules/*; cp -R "$$(npm root -g)" /e2e/cypress; chmod -R 777 /e2e/cypress/node_modules; cypress open --project .'
    working_dir: /e2e

Important is here rewritten `entrypoint` in combination with `volumes` definition. Globally installed node modules are just copied to mounted location.

```bash
ls -al cypress/node_modules/   # on host in project root
celkem 20
drwxrwxrwx  5 mhs1 mhs1 4096 lis 19 17:53 .
drwxr-xr-x 10 mhs1 mhs1 4096 lis 19 17:09 ..
drwxrwxrwx  6 root root 4096 lis 19 17:53 cypress
drwxrwxrwx 10 root root 4096 lis 19 17:53 npm
drwxrwxrwx  4 root root 4096 lis 19 17:53 yarn

With this workaround code completion works as is described in documentation. Tested with VScode editor.


push -> pushImages

Looks like the Upload Digest step was getting incorrectly skipped (not sure why this didn't show up in my linked tests) -- this should resolve the digest upload to fix the merge task

Relevant Action:
https://github.com/onedr0p/containers/actions/runs/5283552493/jobs/9560005834


[WIP] Custom JS injection

Description

Downstream client is looking for a way to inject custom JS actions to act on the map through Maperture. This PR experiments with one way to handle this. This would be an advanced feature that we would likely discourage for typical use.
Functions are passed separately in the config as we handle the map objects (presets, etc) in a way that needs to go between strings and objects which removes functions.
The function passed should be a factory function that takes a map argument and spits out a function that acts on that map to be run on clicking the option. These changes do not persist if the map style is changed or closed. They do not persist across styles.
[
  {
    type: 'dropdown',
    label: 'Backgrounds',
    mapIds: ['my-cool-map'],
    options: [
      {
        label: 'Blue',
        script: map => {
          return () => {
            map.setPaintProperty('background', 'background-color', 'blue');
          };
        },
      },
      {
        label: 'Red',
        script: map => {
          return () => {
            map.setPaintProperty('background', 'background-color', 'red');
          };
        },
      },
    ],
  }
]

TODO

[ ] Document syntax
[ ] Add other types than dropdown (maybe button)
[ ] Add non-mapbox/maplibre maps to the map object store
[ ] Make sure map id changes are fully propagated through and don't cause bugs

Closes #
QA steps

[ ] ...

Author checklist
Create the PR

[ ] Fill out PR template
[ ] Make sure you've added a CHANGELOG entry under "Unreleased"
[ ] Request a review
[ ] Make any requested changes and get approval

After approval

[ ] Merge any changes from main into your branch, resolve any conflicts
[ ] Squash & merge changes into main
[ ] Delete branch

@ebrelsford I have a few todo's in here, but am already using this downstream off this branch and it meets our needs. If this seems like an acceptable advanced feature, I can go ahead and finish those up before putting up for review. Do you see any issues with this as a feature or with the implementation?

@aparlato This approach generally looks good to me!
Maybe this is for future consideration, but I do wonder if there's a case to be made for completely transforming a style? For example if you want to change all instances of a given field name or color in paint properties or something simpler like changing glyphs.

Maybe this is for future consideration, but I do wonder if there's a case to be made for completely transforming a style? For example if you want to change all instances of a given field name or color in paint properties or something simpler like changing glyphs.

If I'm understanding the ask/suggestion here correctly, I'd rather put the onus of that on the user to write their custom script. Partially because it's more flexible and partially because it's an advanced feature I wouldn't want to encourage by making too user friendly. I'll send you an implementation of this in Slack that does this as I don't want to post publicly on this PR.

Yeah maybe at some point we just document that as a possibility for when it comes up.

Looks like the customJs property accidentally became required in the code: See CustomJsUi.svelte:17
Can be worked around by using an empty array.


Godot texture masking (mask channels)

Tested versions
4.3
System information
Godot v4.3.stable (77dcf97d8) - Freedesktop SDK 23.08 (Flatpak runtime) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 SUPER (nvidia) - Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz (6 Threads)
Issue description
GLTF model can have one material (surface) and multiple texture on this. It displays as some pseudosurfaces what are green, red, blue or black.
So question: how i can set all these textures? i tried use all texture variants and not found variant for me.

Steps to reproduce
Have this strange model (change first .txt to .gltf and next .txt to .bin)
lSM_NeighborsHouse_part15.txt
SM_NeighborsHouse_part15.txt
Minimal reproduction project (MRP)
Create empty project and then add this model and try add some textures or materials

What is the bug here? It sounds like you are asking a question, not reporting a bug?

What is the bug here? It sounds like you are asking a question, not reporting a bug?

Its a bug too, because standart gltf supports it, godot no

Or i do something wrong?

It isn't necessarily a bug, it sounds more like a missing feature
But this needs far more details and examples, please add more information

If you use a web gltf viewer it should showvthe same thing. Texture paths are not in the file.

It isn't necessarily a bug, it sounds more like a missing feature
But this needs far more details and examples, please add more information

In editor i see only one material, but original model contains multiple materials via mask (or something like this)

https://gltf-viewer.donmccurdy.com/

I suggest contacting your exporter UE Viewer (umodel) build 1590 and make sure their output is readable in https://gltf-viewer.donmccurdy.com/

I suggest contacting your exporter UE Viewer (umodel) build 1590 and make sure their output is readable in https://gltf-viewer.donmccurdy.com/

Can you show error description?

And output is readable

I open it in editor normally

Please edit your previous comments instead of making several comments in a row

I suggest contacting your exporter UE Viewer (umodel) build 1590 and make sure their output is readable in https://gltf-viewer.donmccurdy.com/
Ok i see multiple colors like in godot, but question still open: how i can set this colors with textures?

How i can create multiple materials on every vertex by color?

Either you model needs to come with separate surfaces, or you need a shader to do it. Please refer to our community platform for further question/support (https://forum.godotengine.org/c/help/shaders/10), since this doesn't seem to be an engine bug, based on your latest comments.

Either you model needs to come with separate surfaces, or you need a shader to do it. Please refer to our community platform for further question/support (https://forum.godotengine.org/c/help/shaders/10), since this doesn't seem to be an engine bug, based on your latest comments.

I think engine bug too, because i can do nothing with vertex colors, only use as albedo.
I can use shaders, but i have 300+ that materials, soo... I need 300+ shaders??? its not lag???


Add Platform Name to config.schema.json

Hey @ronniepettersson, I had found a minor bug/issue while using your plug-in (otherwise works perfectly!). I found unlike other plug-ins I have installed that in my homebridge logs it would show the platform name as the full plug-in name homebridge-remootio instead of something like Remootio; I found this was the same for the name when creating a Child Bridge.
Before:
Shows an example of Remootio vs Roborock plug-in:
[04/02/2022, 2:33:06 pm] [homebridge-remootio] Remootio platform finished initializing!
[04/02/2022, 2:33:06 pm] [homebridge-remootio] Configuring accessory Garage Door
[04/02/2022, 2:33:06 pm] [homebridge-remootio] Remotio platform didFinishLaunching()
[04/02/2022, 2:33:06 pm] [homebridge-remootio] [Garage Door] Finished initializing!
[04/02/2022, 2:33:06 pm] Homebridge v1.4.0 (HAP v0.10.0) (homebridge-remootio) is running on port 34390.
[04/02/2022, 2:33:06 pm] [homebridge-remootio] [Garage Door] Connected
[04/02/2022, 2:33:06 pm] [homebridge-remootio] [Garage Door] Setting current state to CLOSED
[04/02/2022, 2:33:06 pm] [homebridge-remootio] [Garage Door] Authenticated
[04/02/2022, 2:33:06 pm] Registering accessory 'homebridge-xiaomi-roborock-vacuum.XiaomiRoborockVacuum'
[04/02/2022, 2:33:06 pm] [Roborock] Loaded homebridge-xiaomi-roborock-vacuum v0.20.1 child bridge successfully

Shows an example of Child Bridges:

Proposed Change:
The "name" parameter needs to be added to the platform directives of the config.json (which can already be added without this PR):
"platforms": [
    {
        "platform": "Remootio",
        "name": "Remootio",
        "devices": [
            {
                "name": "<name of the device you want to appear in HomeKit>",
                "ipAddress": "<the ip address of your Remootio device>",
                "apiSecretKey": "<API Secret Key>",
                "apiAuthKey": "<API Auth Key>"
            },
                {
                "name": "<name of the device you want to appear in HomeKit>",
                "ipAddress": "<the ip address of your Remootio device>",
                "apiSecretKey": "<API Secret Key>",
                "apiAuthKey": "<API Auth Key>"
            },
        ]
    }
]

However, what I have changed in this PR is to add this field to the config.schema.json (it has been left as not 'required' so as not break existing setups) so that users are prompted to add it. It has also been modified in your README for users who still just copy/paste a config sample.
After:
Shows a example of plug-in name in Homebridge logs after change:
[04/02/2022, 3:08:11 pm] [Remootio] [Garage Door] Setting current state to CLOSED
[04/02/2022, 3:08:11 pm] [Remootio] [Garage Door] Authenticated
[04/02/2022, 3:08:11 pm] [Wiz] Loading accessory from cache: Wiz Tunable White Bulb XXXXXXX

Shows an example of Child Bridges after change:

Shows an example of how the config.schema.json looks after change:

What's Left:
I have left bumping the version number for the plug-in for you if you accept this PR. This has been tested and is all working on my setup; let me know if you have any questions :)

Also just added the 'npm downloads' badge to the README; feel free to remove that if you are not a fan of it. I like it as it shows users how 'popular' your plug-in is.

Ok, last change I promise :p the links on your README for 'Remootio 1' and 'Remootio 2' are broken links. I have removed these links as the first Remootio link on the page takes you directly to their newest model, the 'Remootio 3'. I have also added 'Remootio 3' as being supported; as that is what I have installed at home and it works perfectly.

Happy to help @ronniepettersson! Thanks for merging it :)

@ronniepettersson just happened to notice you had forgot to update your version number in your package-lock.json (on line 3); when you had changed it in your package.json. Not sure how that affects things, but thought I would give you a heads up.

Thanks. Its taken care of now.


chown: /output: Operation not permitted

I have recurring problems to get my files written to a NAS (TrueNAS in my case).
The folder on the storage is exported, I set up a dedicated user called "makemkv" on the host and the NAS (identical UID/GID), mounted the NAS folder via /etc/fstab (as I did for other containers like TVheadend) but on the startup of the makemkv container, I always get "chown: /output: Operation not permitted" - no matter, what I do.
The folder on the NAS is a subdirectory of my standard video share (which works flawless with all other docker containers), it is mounted as a separate mount (tvheadend is using /mnt/pvr, makemkv on the same host uses /mnt/recorder). The folder /mnt/recorder is passend as -v /mnt/recorder:/output and I use -e USER_ID=1005 and -e GROUP_ID=1005 (which is my dedicated makemkv user). But no look, I always get the error at the start of the container.
Desperately reaching out for help.

On the NAS, which kind of mount it is ?  Is it a SMB/NFS share ?

Also, please provide the full log of the container: docker logs <container name>.


430 number dragger should work outside editor

Current Behavior: Allows the user to drag the number outside the code editor tab. Displays a preview of the number value above the number being dragged.
Changed: No longer updates the value of the number being dragged in real time and now updates the value when user stops dragging number.

Ah no worries. I understand the importance of keeping the updating in real time feature for the number dragger. Since it's currently able to be dragged off screen, I'll try and work on the issue more and get it to update while off screen as the next step.
Thanks for the feedback.


Update files endpoint to return text json

Takes in the pdf and parses it to return its in the JSON
PDF:

The text JSON:

conflicts in server/requirements.txt need to be resolved

A package-lock.json file somehow made its way into server on main, would you mind fixing that in this branch?


feat: upgrade esbuild to 0.24

This bumps esbuild to version 0.24.0.
I wanted this since I'm affected by https://github.com/evanw/esbuild/issues/3887, which prints a lot of warnings when I build with 0.23.0. I also want to use the exact same version of esbuild when running locally, and building for deployment.
Thanks for an amazing tool! 🙏

Thank you for the PR, but I typically don't accept esbuild upgrade requests unless they address a specific bug or issue. In this case, esbuild was released with a breaking change label, which poses unnecessary risk to tsx users without clear benefit.
If your main motivation is to standardize on a single version of esbuild, I recommend using a package manager override to achieve that in your project.
Since tsx is designed to be user-friendly, the average user won't be concerned with dependency de-duplication, and we want to avoid causing potential disruptions unless absolutely necessary.

Makes sense 👍
I'll look into using overrides instead!
It would be neat if tsx used peer-dependencies to let users bring their own version of esbuild while at the same time indicating which versions are compatible. But as you explained, that probably doesn't vibe with the intention of this project either 😅

@privatenumber So is that issue #647 possible to be resolved with the goals of tsx (user-friendly)?
There should be a way to avoid duplication of dependencies versions.
Would you accept a PR which change the semver to esbuild from:
"esbuild": "~0.23.0",
to
"esbuild": "~0.23.0 || ~0.24.0",
or like there: https://github.com/antfu-collective/importx/blob/08d68f31b4c4e927d59c99e0adb488aa7be9df54/package.json#L55
"esbuild": "^0.20.2 || ^0.21.0 || ^0.22.0 || ^0.23.0",


video ad is stalled on safari sometime

Hi,
video ad is stalled at the beginning on safari sometime
it continue to play when refocus on browser or pauseAd then resumeAd
any idea or callback to handle this problem?
Version:
videojs 6.7.3
videojs-contrib-ads 5.1.6
videojs-ima 1.0.4

the problem also occur in example
https://googleads.github.io/videojs-ima/examples/autoplay/

I find that safari will pause the muted video ad when user is not focus on current tag, and continue to play when refocus

Safari Version 11.0.3

I'm not seeing this in the autoplay page. Are there any other requirements to reproducing this?

it doesn't happen very often,  just keep refresh the page for testing

Hi all,
Safari 11 blocks the video with autoplay and with sound.
doc: https://www.howtogeek.com/326532/safari-now-disables-auto-playing-videos.-heres-how-to-allow-them-for-certain-sites/


create playbackReteManager on load too

This make sure the playbackReteManager is created even if the program component is never updated.
Also deletes extra console.log

I did see a case where loading a document with a recorded program caused some weird behavior. I wasn't able to reproduce it though. I figured this change was better since there is no guarantee that the component will be updated after the first load so if we have a recorded program we should handle that immediately.


Wiring Diagram

Hi!
I would like to first of all thank you for making the software available. Could you explain how the servo could be wired to a raspberry pi? A diagram would help.
Thank you very much!

Hi!
You can use the official guide  to connect in a way that is convenient for you

We use  method


Bugfix/comments for runner package

Fixed warnings about comments for exported types and functions

[x] CHANGELOG.md updated
[x] Rebased/mergable
[x] Tests pass
[x] Sign CLA (if not already signed)

Confirmed CLA signed, comments only, merging now.
Thanks @mre


Clarify fencing agent configuration

This has lead to confusion for colleagues and customers, and should be a bit more clear this way.

@tiefpunkt : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@cynthn: I'm sorry - only the author of this article, @rdeltcheva, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


[BEAM-4331] Disable integrationTest task caching

(as described in the issue)

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.

[x] Run ./gradlew build to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

LGTM
Passing off to a committer to merge. @pabloem ?

SGTM.


Create dependabot.yml

What changed?
Create dependabot.yml
Why?
Security updates
How did you test it?
When dependabot runs, it will create a new PR if any dependencies are out of date
Potential risks
None
Is patch release candidate?
Nope
Link to relevant docs PRs
N/A

Thanks @nitrocode, we have dependabot configured for this project via the Github settings so for now I will close this PR


[PE-D] MacOS cmd+Q screen

Maximise in macOS, then use cmd+Q (for quitting application), the following screen shows (subsequent cmd+Q will render the screen black, but the app still runs and you can't quit it anymore):

Labels: severity.Low type.FunctionalityBug
original: zhenghanlee/ped#7

As a mac user, I have not encountered such a problem. @eeliana have you had this prob before?

As a mac user, I have not encountered such a problem. @eeliana have you had this prob before?

I also have not encountered this problem, both when running in the IDE or using the JAR file.


the ANSWER contains unwanted text

It seems that when I just want to complete a just a part of the sentence, the ANSWER contains the whole sentence.
I tried to fix this problem with the following System Message but in vain:
Your job is to predict the most logical text that should be written at the location of the <mask/>.
Your answer can be either code, a single word, or multiple sentences. The ANSWER should be exactly the answer itself that can be placed at <mask/> and should not include the text directly surrounding the <mask/>, especially when you found that you do not need to write a whole sentence at <mask/>.
Your answer must be in the same language as the text directly surrounding the <mask/> .
Your response must have the following format:
THOUGHT: here you explain your reasoning of what could be at the location of <mask/>
ANSWER: here you write the text that should be at the location of <mask/>

Does it has something to do with the code that parses the ANSWER? Such as some problems when processing characters beyond ASCII.

This is a known issue. GPT-3.5 finds it very hard to perform this task, whereas GPT-4 can do it perfectly. To make it work for GPT-3.5, I added this post-processor that removes overlap. However, I did assume an English-like language when implementing this. Therefore, it might be worth examining the post-processor's code. If you find something there that causes the issue, please let me know.


Hydra Spec and Azure-sdk-for-net repo not in sync

Some change in the hydra specs is causing some peering stats related files to be not generated. These files are still referenced by azure-powershell repo. Needs fixing by Express Route team

@vinayada1, @dihan0604, could you please check if this still up to date?

https://github.com/Azure/azure-sdk-for-net/issues/3407

These were legacy issues that we found with our Hydra SDK. However, since that is frozen for any further development, I think these can be closed.

Thanks @vinayada1


Validation: Submiting a form auto-completed (autofill) by browser, the inputs are empty

It never could be reproduced


[Guide EKS public/private request]: How to configure Gefyra with EKS node group in private network

My goal
I would to like setup gefyra to connect my frontend application deployed on my laptop on minikube to my database deployed on remote EKS cluster.
My Kubernetes development setup
The EKS cluster is up and running, and had the node instances running on private network. (not EXTERNAL_IP)
Instead the API endpoint is public.
My laptop is a Windows 10 with minikube + docker desktop.
My test
Find AWS EKS cluster SG:
aws eks describe-cluster --name crazy-eks --query "cluster.resourcesVpcConfig.clusterSecurityGroupId" --region eu-central-1 --profile default "sg-9999999a999e9cb99"
Add to sg-9999999a999e9cb99 on ingress the UDP 31820
Find the IP address of the EKS API server Endpoint
nslookup C0xxxxxxxxxxxxxxxxxxxxxxxxx3.gr7.eu-central-1.eks.amazonaws.com
Server:  my.server.local
Address:  <IP_ADDRESS>.

Risposta da un server non autorevole:
Nome:    C0xxxxxxxxxxxxxxxxxxxxxxxxx3.gr7.eu-central-1.eks.amazonaws.com
Addresses:  A.B.C.D , E.F.G.H

Try gefyra up
gefyra up --host A.B.C.D --kubeconfig c:\Users\my.user\.kube\config
[INFO] Installing Gefyra Operator
[INFO] Created network 'gefyra' (e1d9a9ad7ab9)
[INFO] Container image "quay.io/gefyra/operator:1.0.2" already present on machine
[INFO] Pulling image "quay.io/gefyra/stowaway:1.0.2"
[INFO] Successfully pulled image "quay.io/gefyra/stowaway:1.0.2" in 467.883545ms
[INFO] Operator became ready in 7.0376 seconds
[INFO] Deploying Cargo (network sidecar) with IP <IP_ADDRESS>
[ERROR] Gefyra could not successfully confirm the Wireguard connection working. Please make sure you are using the --endpoint argument for remote clusters and that the Kubernetes NodePort A.B.C.D:31820 can be reached from this machine. Please check your firewall settings, too. If you are running a local Minikube cluster, please use the 'gefyra up --minikube' flag.
[INFO] Removing running bridges
[INFO] Uninstalling Operator
[INFO] Removing Cargo
[INFO] Removing Docker network gefyra
[CRITICAL] There was an error running Gefyra: Failed to start Gefyra

Can you help me to make this configuration ?
Best Regards
M.M.

Hello @maxmonterumisi - thank your very much for your feedback! From what I see you're basically asking for something similar to this: https://github.com/gefyrahq/gefyra/issues/292 - Note --endpoint is now --host + ' --port`.
I'm afraid Gefyra is not able to connect to Nodes which aren't exposed publicly, currently.
We're working on a solution that does not involve the NodePort - but it's not done yet.
Moreover - just to make sure I understood you correctly:
You're trying to connect a container from within your local Minikube cluster to a remote cluster? If that's the case - I'm also sorry to say that Gefyra is for connecting local containers with remote clusters. Meaning the local containers actually need to run through the docker client on your local machine.

Hi @SteinRobert thank you so much for your reply.
I'm sorry I can't use your excellent product, ...right now our EKS Worker Nodes are private only. The only thing public is EKS API endpoint. We hope in the future that Gefyra can support this type of configuration. Thanks also for the clarification regarding the local cluster which can only be Docker...I didn't get it.

@maxmonterumisi stay tuned. We are working on an "installation procedure" that will add a loadbalancer to your AWS EKS setup. With that, you can prepare any private EKS cluster to work with Gefyra from your local host. =)

@maxmonterumisi thank you so much for letting us know about your use case! It does help us to prioritise feature development and you pushed this one a bit further up our roadmap! 😉

I have created a new issue to discuss our final solution to these types of challenges: #353
If you @maxmonterumisi do have some thoughts about this, I would be very happy to hear them. =)


iOS Card.io needs NSPhotoLibraryUsageDescription key in info.plist

The Card.IO Framework has a UIImagePickerController call. Apple needs an NSPhotoLibraryUsageDescription in info.plist otherwise the app is rejected.

Hi,
how enable card.IO function on this plugin?
Thanks,
Luca

Theres a separate branch which includes card.io https://github.com/Taracque/cordova-plugin-braintree/tree/ios-cardio

Out of curiousity @Taracque, is there any reason why the ios-cardio branch can't be merged in with master?

Card.io branch wasn't tested. If you find it working, please let me know and I'll merge.

Seems to work for us. Perhaps worth merging back now?


Update to use webpack 4 .hooks API

Webpack 4 uses a different plugin API than previous versions (https://github.com/webpack/webpack/issues/6568)
This PR updates the plugin to remove the deprecation warning and use the new API (https://github.com/webpack/tapable)

Could this be possibly merged or is there any problem with that?


Github source-path

I would like to use your web deploy for my simply webapp, but I don't know what my source path is. Here is a screenshot of my github repo

Hey @Ozan0062, it really depends how you build/publish your application.
I need to see your build/publish workflow to help you. In this example you can see that I publish and the default source folder for that is \publish\.


vulnerabilities in unmaintained chrono dependency

chrono is unmaintained and not willing to fix discovered vulns in its dependencies. this results in cargo audit findings for projects using rusqlite. other crates have been swapping to using time directly. can the same be done here to avoid findings and security issues?
https://rustsec.org/advisories/RUSTSEC-2020-0159.html
https://rustsec.org/advisories/RUSTSEC-2020-0071.html

chrono is unmaintained

https://github.com/chronotope/chrono/commits/main
https://github.com/chronotope/chrono/issues/650
Are you sure ?

https://github.com/chronotope/chrono/pull/639#issuecomment-1024924037 seems as though the owner is mia and blocking things. being on rust 2015 doesnt help either. either way, there is a medium, almost high, vuln in the version used by rusqlite.

Quoting @thomcc:

we don't do anything with the vulnerable code

...

I'll look into it and see if there's anything we can do here, but ultimately a lot of code uses chrono and rusqlite in order to access to time information which is stored in the database. That code is largely stuck without a migration path in this situation, which is... unfortunate.
It is also true that rusqlite's usage is not impacted and does not call vulnerable APIs are not used. Sadly, the existing tools can't verify this as far as I know[^1].
[^1]: Even though the advisory database contain a list of vulnerable functions and such, no tool exists that uses that information. This is because doing this requires performing trait resolution and call graph analysis, and in practice this requires either writing a non-trivial part of a Rust compiler, or direct access to rustc's internals.
However, if your rusqlite dependency does not have features = ["chrono"], then we will not depend on chrono at all, and so it will not be present in your dependency graph. The tools I'm aware of (both cargo audit and cargo deny) will not report an issue with rusqlite in this case. Please let me know if this is not the case, as it would change my feelings about how important this is to address.
Anyway, I've been in favor of removing this for a while, but this is the sort of thing that @gwenn and I need to agree on. At the very least, they feel more strongly about it than I do.
(My reason for wanting it gone is so that if a new vulnerability is found that impacts an API we do use, we don't accidentally miss this fact, and also I'd like to add cargo audit into our CI)

chronotope/chrono#639 (comment) seems as though the owner is mia and blocking things. being on rust 2015 doesnt help either. either way, there is a medium, almost high, vuln in the version used by rusqlite.

Worth noting that (as of https://github.com/rusqlite/rusqlite/pull/1031) we avoid the vulnerability addressed by that PR, although I believe there's other issues inside chrono.
It is worth noting that largely speaking the origin of this vulnerability is in the Rust standard library rather than chrono. std::env::set_var should not be a safe function, as it is an API which becomes unsound in the presence of non-rust code that accesses the environment.
Quite a bit has been written about this in https://internals.rust-lang.org/t/synchronized-ffi-access-to-posix-environment-variable-functions/15475, and the outcome is likely that set_var will be deprecated and the replacement will be unsafe.

https://www.reddit.com/r/rust/comments/tqzeek/comment/i2ku631/?utm_source=share&utm_medium=web2x&context=3

https://www.reddit.com/r/rust/comments/w8m8lx/chrono_0420rc1_has_just_been_released/

https://www.reddit.com/r/rust/comments/wg3fks/chrono_0420_has_been_released_fixing_the/


3392 hydroshare.org should not auto redirect to /landingPage

#3392 has detailed description of the problem. It doesn't affect user operation.

Pull Request Checklist:

[x] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

Have a incorrect branch. Closing it.


Avalonia does not respect dark theme preference on Linux

Describe the bug
Avalonia does not respect dark theme preference, unlike other apps
To Reproduce
dotnet new avalonia.app
dotnet run
Expected behavior
See "Welcome to Avalonia!" in dark theme
Screenshots
I am unable to upload files to GitHub's CDN, so files below are hosted outside of GitHub:
Avalonia app ignoring dark theme preference, displayed on top of Nemo (file browser): https://conduit.rory.gay/_matrix/media/v3/download/conduit.rory.gay/8i3yuutccQY5Zs4dhIBVuGSpLFhQtqxE
Environment

OS: NixOS (Configuration: https://cgit.rory.gay/Rory-Open-Architecture.git, see Rory-desktop output)
Avalonia-Version: 11.0.6 (can reproduce on nightly)

Additional context
NixOS configuration can be reproduced, if desired.

@TheArcaneBrony

What DBus debugging tools are reporting for org.freedesktop.appearance settings? For example, you can check with D-feet.
Have you tested with nightly builds?

@maxkatz6 nightly was tested in telegram chat already. It didn't help either acc. to feedback. Looks like it's a custom Linux build so don't know how to debug it properly. But we can get that Linux build on request if I understood correctly

@timunie if org.freedesktop.appearance doesn't return correct values on a custom Linux build, then this issue should be closed.

@TheArcaneBrony can you help us and post what org.freedesktop.appearance returns on your system?

[!NOTE]
As we think it may be related to your custom system I'll make this a discussion for now. If we later find the root cause we can still decide to make it a feature request or a bug report again. (Depends on the input we can get here)


feat: add --fields-include to unstructured-ingest

Currently, unstructured-ingest writes all top-level fields in an element with the exception of “coordinates.” This is a reasonable default. Update the command to accept a “--fields-include” in main.py so that the default is “element_id,text,type,metadata”.

it's a little hard to review with the changes from the --metadata_include/exclude branch mixed in...but it doesn't look like there are any tests added to cover the new fields_include functionality, right? worth some coverage?


Use explicit concurrency using channels

Remove all occurrences of Streamly.Prelude and Data.IsStream. Currently it is being used for parallel and async (doctest).


adding induction document

A document for staff managers to use as a guide for the induction of new software engineers at ONS.

This is the first version of the induction document and it is ready for review. Thanks, Ella

Thanks

Hi All, thanks for the comments so far; I've amended the typo and added a link to the readme. I think it is ready to be merged now unless anyone else needs to review it? I'm not very familiar with pull requests so I'm not sure how this works? Ella

Thanks for the approval. I am now seeing a "Changes approved" check mark but unfortunately
the "Merge pull request" button is greyed out and there is a red "Merging is blocked" mark, which adds "The base branch restricts merging to authorised users".

Ah. The repo may have extra restrictions. I'll hit the button 😄

Many thanks John


Massive update (or simply multiple changes) - IPv6, TTL, Go1.18 and so on

Added support for resolving AAAA records (IPv6-only not supported yet)
Added support for specifying TTL directly (i.e. just for this plugin)
Disabled RA flag in DNS response (we're not doing any recursion here)
Removed flood of resolve messages from the output of plugin
Updated plugin dependencies
Updated Go from 1.16 to 1.18
Updated CoreDNS from 1.8.4 to 1.10.1
Updated .dockerignore to improve build cache efficiency
Set CGO_ENABLED to 1 as now we're using the same image for build/exec
Switched multistage Docker build phase from Debian to Alpine 3.17
Switched building of plugin to the local sources instead of repo
Enabled stripping of CoreDNS executable to reduce image size

Sure, I can split this PR into multiple by subjects, but this would take an unknown amount of time so I decided it will be better to share what I have and let maintainers decide what's next.

@brase @sashaaro @kevinjqiu

Thank you @Vlad1mir-D


Deploy to packagecloud

CircleCI has environment variable set up

Do we want to publish all snapshots? This is what this does, isn't it?

I think it will publish anything. So if we make a version commit it should deploy that, and then we can commit back to whatever snapshot version we want. Not sure of what's the proper way of doing releases here yet.

I'm going to redo this one with maven central instead of packagecloud. Should be easier to use as well. Including being able to mirror stuff from the local artifactory. Waiting for the JIRA ticket to do through.


[PRODUCTION] - Reverse Proxy

Description:
Create an Nginx reverse proxy server on the host machine, since we need to coordinate the containers and their connections we will need a way to centralize the requests and address them to the correct places
Acceptance:

Have Nginx configured to work as a reverse proxy
Allow access only to our React Server through ports 80 and 443

The reverse proxy was implemented and is working. closing issue