C++21

C++17 has stuff we need, but I have no faith that VC++ will get to them before 2021. Here's a list of things we'd need from C++17 that do not exist in either clang++, VC++, or both:

[ ] constexpr-if
[ ] fold expressions
[x] noexcept function types
[ ] template <auto X> (for c_call and static_trampoline)
[ ] feature-test macros
[ ] static reflection (still not in C++17: hopefully by C++21 it will be there and implemented in all compile- hahahaha no it's not)

These will allow us to get pretty great compiler and performance savings out of our code by adding specializations for no-exception function types (already there), fold-expressions to reduce the sheer compiler bloat that comes from unraveling argument packs, and constexpr-if to get rid of tons of redundant functions whose sole purpose is to check a single typedef or a single property of a type.
Gating them behind feature-test macros will allow us to check in a standards-compliant way for when a compiler FINALLY gets it together. I was not able to confirm if VC++ has feature-test macros, but I know it's also missing all of the above. clang++ and g++ might have back-ported the feature to older compilers, but I am still unsure.

Not suggesting to switch to CMake, but this cmake library works well to do exactly what you want here. Perhaps it could be done via some python scripts?

https://github.com/ThePhD/sol2/commit/b811e73b902ff151bc4c7fe8d19c67e530fbf277
noexcept-proofs a very large chunk of sol2's code. In C++17 mode on later compilers, this will be triggered automatically and sol2 will turn off exception handling trampolines exclusively around functions that are marked as noexcept, potentially providing slight speedups to that class of users.

I'm not sure if this issue is the right place to discuss, but I guess it's at least related.
You mention in the release notes that v2.17.5 will be the final release supporting a whole bunch of compilers that are still supported by their manufacturers and that are still being widely used, because they are the default toolset on many distributions.
I can understand that you want to make use of more modern C++ features, but if you want to drop support for so many compilers, it would be weird to do this while just incrementing the minor or patch number - such a version should definitely be called sol3, possibly allowing sol2 to be developed in parallel. And by "develop" I do not necessarily mean active development of new features, but at least backporting bugfixes from sol3, if applicable.
It seems a bit asymmetric that there is still support for Lua 5.2 and older but only the very latest compilers are supported. If a project has the chance to use the latest available compiler for your platform, I doubt that it would have a reason to be stuck with an old, unsupported version of Lua.

The latest still works in VS 2015, Clang 3.4, etc: all of the travis tests are still there and still showing as passing. You can always flip through travis tests to know specifically when compiler X is going out the window.
Not even clang supports half of what I listed there, so you literally don't have anything to worry about until -- at the earliest -- 2019. The reason this issue is listed and the reason I want to focus on moving on quickly is because there have been over a dozen users who have complained about things like Binary Size and Compile Times, all things that C++17 can help alleviate. It's in my best interests to have a new version of Sol up and running the minute C++17 support kicks in for a good chunk of the compilers. That will likely mean waiting until 2019 for the next version of Visual Studio.
As a side note, Visual Studio 2017's support for many things is improved, but they're not going to be shipping new compiler features until the next Big Version of Visual Studio. That being said, Visual Studio 2017 support is essentially identical to Visual Studio 2015 support as far as needed-features is concerned, meaning what you want/need out of sol2 won't be going anywhere anytime soon.
When we start making serious changes, it will be sol3. I will likely updated the compatibility page to continue pointing to higher and higher versions sol v2.1x.x that continue to prove that they pass the compilation and runtime tests on older compilers.

Finally, regarding Lua support: that's completely orthogonal to compiler features. Lua 5.1+ support is because people like LuaJIT and LuaJIT is feature-locked to 5.1, despite meager compatibility patches they keep adding to their headers that break my own compatibility wrapper and have people filing issues against me for LuaJIT 2.1.0-beta3.
Barely anyone uses 5.2 because there's no pressing reason to: there's no special JIT tied to its version like LuaJIT and it's strictly inferior to 5.3: we test it as a formality and because somebody's not going to update their debian/ubuntu machine and will be using 5.1 / 5.2 because "that's what on their machine" and running a Yet Another Helpdesk/Debug session is not high on my list of things to do.
Anyone who cares / updates gets themselves a freshly built, ANSI-C compatible slice of Lua right off the website, which is 5.3 (or whatever the latest version ends up being when someone reads this) and cannot have an easier build + installation path.
If LuaJIT migrated to 5.3, I'd seriously consider throwing 5.1 out the window because there's a host of optimizations I do not make strictly because the Lua 5.1 C API is lossy/bad in many regards. Obviously, it would once again be considered part of sol3, so nothing for you to worry about.

Thanks for the clarifications. It's just that those latest release notes read in a rather alarming way. :)

Added more clear wording in the docs about this, and edited the release page: http://sol2.readthedocs.io/en/latest/compilation.html#supported-compilers

Yes, that clears up things a lot, thanks for that. Oh, and as I haven't said it yet, thanks a lot for maintaining sol2! Over the years I have tried to use pure Lua as well as other bindings but always got demotivated very quickly again (particularly because this was mostly pre-C++11). Now with sol2, I'm getting things done much more quickly and syntactically more easily, which motivates me a lot to incorporate scripting into my application again!

@Nava2 Sorry about not saying anything earlier! As a side note about using that library, I don't think I quite need it here. I'm not looking to "mock up" or "fake" compiler support for stuff: if the compiler doesn't support it, I want to drop it completely from sol2 and have it not exist at all. It's a bit of a rough decision but unlike with the compat headers with Lua, C++ is a much bigger monster and there's no 1 definitive source of "patching it over" (see: boost, various stdlib re-implementations, various optional and variant and ... types implemented by the community).
I'd much rather the user consciously create extension points for the things their missing. Besides, the compiler-specific stuff I need (fold expression, constexpr-if, template <auto X>) unfortunately can't be faked by Macros and patching functions :(

@ThePhD no worries. 👍
Thought I'd mention it, it's a pretty useful library!

https://github.com/ThePhD/sol2/commit/16fc7d87ff0b9c2fc18268a420e0b058a67060a1
This commit adds support for std::variant, std::string_view and its friends. We do not make a specialization for std::any, because it is essentially an opaque userdata and should simply be transported as such.
As a side note, it would probably be a good idea if we found out any other C++14/17 types people would want to be vocabulary-serialized. I can't think of any more types that need to be put in or routines that need core getters/pushers asides from the ones I just added.

Important side note: places in the API that take a std::string should be changed to take a std::string_view under the new defines for C++17. One problem, however, is that do_string, I believe, requires that the input string is a c_str? This might inhibit our ability to use string_view because it's not guaranteed to be a c-style null-terminated string (just a pointer and a count).
A quick glance at the manual and the core of luaL_dostring seems that it (and everything else) is based off lua_load, which takes a reader-type structure. We'd have to write a string_view reader type to get it to work: https://www.lua.org/manual/5.3/manual.html#lua_load

The whole framework has been vetted to use string_view where appropriate: https://github.com/ThePhD/sol2/commit/ca685e01c97191d2f5f40d2eae8b7402c4697808

Clang 3.5 has a critical bug that's absolutely blocking not C++Latest or C++17 code, but C++11 and 14 code. It's going to be removed from the tests and removed from support. Thankfully, 3.5 is way out of control.

Latest release heavily proofs all of sol2's code for C++17, and also adapts all necessary functions to use std::string_view: https://github.com/ThePhD/sol2/releases/tag/v2.18.0

@ThePhD does this break support for older compilers, or will the likes of msvc140 still work?

@OrfeasZ I thought I replied to this already, oops. No, no it shouldn't break VS 2015.

There is nothing left to do here, until C++20/C++19 comes out.
The issue will be closed and re-opened in the fuuutuuuuuure.


Add Voronoi Diagram

It's in the GEOS C API: https://github.com/libgeos/geos/blob/master/capi/geos_ts_c.cpp#L3223.

This was added in https://github.com/Toblerity/Shapely/pull/881 by @tomplex, so closing.

This was added in https://github.com/Toblerity/Shapely/pull/881 by @tomplex, so closing.


Handle alternative response text for known transaction errors

Signed-off-by: Matthew Whitehead<EMAIL_ADDRESS>

Codecov Report

Merging #37 (e0d5d30) into main (4767448) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##              main      #37      +/-   ##
===========================================
- Coverage   100.00%   99.84%   -0.16%
===========================================
  Files           22       22
  Lines         1293     1295       +2
===========================================
  Hits          1293     1293
- Misses           0        2       +2

Impacted Files
Coverage Δ

internal/ethereum/error_mapping.go
92.00% <0.00%> (-8.00%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

On further inspection I think his PR is incorrect and the alternative text was being rendered from a different part of FF


Tiktok xlog?

Anyone any idea where to find it and how to hook it?

i have xlog's enc&dec related code

Anyone any idea where to find it and how to hook it?

i have xlog's enc&dec related code, contact me if you need it

Hello @stackWang , could you please share the xlog algorithm of TikTok? Thank you.
If posible, could you email me<EMAIL_ADDRESS>


Peer-peer code review

Kindly drop your comments

[ ] Great work
[ ] No issues found

Hi @fmanimashaun ,
Your project is complete! You have done it exceptionally well. it's time to merge it 💯
Congratulations! 🎉
To Highlight 👍
✔ No linter error.
✔ Descriptive readme file.
✔ Well-implemented requirements.
Optional suggestions 🔽

You have submitted a project, with a ReadMe that does not conform to the new standardized ReadMe template. Kindly ensure to update your ReadMe to this standardized template,

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
The commit message should be written in the imperative tense and the first letter should also be capitalized. Ex: "Fix bug" instead of "fixed bug". For more details...
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification. You can also connect with me on slack


improve documentation for integrating with GitLab CI

When implementing pronto in our GitLab CI we ran into an issue when having more than 50 commits in an MR. In this case, pronto simply showed all issues, not only the ones in our changes.
The cause of this was GitLabs git depth (50 by default for us, 20 on newer installations). Unfortunately, it is not enough to separately fetch the target branch (which was already present in the docs), but also to refetch the history of HEAD beyond the initial fetch depth.
You could also do this explicitely, by I found it cleaner to simply disable the git depth for this one job.
In case others stumble upon the same problem, I want to update the docs a bit to reflect this need of disabling git depth.

Thanks for the contribution, @webit-richardkramer!


Cloud integration

@jakolehm improved websocket client so that config/seed.yml reads socket uri from env variable and initializer script use that to configure client. Any better that way?


#1139 - Add code coverage

This should generate code coverage and send report to scrutinizer-ci for issue #1139 .
After an admin activate project in scrutinizer-ci it will provide code analysis  and code coverage report for project.

Thanks!

:+1: Happy to contribute with something. :)


Failed donwloading Stardew Valley

Describe the issue
I tried to install a the Stardew Valley mod on the GX mods store and it didn't work it said failed donwload
To Reproduce
Steps to reproduce the behavior:

Go to GX mods
Search for Stardew Valley and pick the first one
Try to donwload, it failes, try again and again same thing. Dosen't hapen whit other mods for some reason.

Expected behavior
Well that I could donwload the mods... on my newer version of Linux Mint.
System Information

OS: Linux Mint 22
Browser : Firefox
Version : 130

this should be fixed in 6.4.0, which is out now! sorry for the long wait :smiling_face_with_tear:

Dont worry, I have some busy weeks to. I know it's hard.


Excel input format error format bug

Sean ran into the following error:

the reason for this is that the metadata at the top of doc changed, and it appears that this change might happen often so we will need to make the function more flexible when parsing the top of file metadata


Suggestion list is removed when more than one dropdown is available

Hi,
I have noticed issue with multiple dropdown when at least one of have onChangeText implemented and it changes parent's state.

Add at least two dropdowns within the same component.
Implement onChangeText that will set state e.g.

onChangeText={(text) => {
setState(text);
}}

Setting the state will cause re-render of component with dropdowns.
This useEffect will be called for each dropdown:

    useEffect(() => {
      if (isOpened && Array.isArray(dataSet)) {
        if (activeInputRef) {
          activeInputRef.current = containerRef.current
        }

        setContent(
          <Dropdown
            {...{
              ...props,
              direction,
              inputHeight,
              dataSet,
              suggestionsListMaxHeight,
              renderItem,
              ListEmptyComponent
            }}
          />
        )
      } else {
        setContent(undefined)
      }
    }, [
      isOpened,
      dataSet,
      props,
      direction,
      inputHeight,
      suggestionsListMaxHeight,
      renderItem,
      ListEmptyComponent,
      activeInputRef,
      setContent
    ])

As other dropdowns will not be openend the setContent(undefined) will be called and suggestion list will be hidden from the view.

The easiest fix I have found was to add check to mentioned useEffect :

    const close = () => {
      setIsOpened(false)
      setDirection(props.direction)
      setContent(undefined)
      activeInputRef.current = null <-- reset active ref
    }

    useEffect(() => {
      // check if active ref is the correct one
      if (activeInputRef.current && activeInputRef.current !== containerRef.current) {
        return;
      }

      if (isOpened && Array.isArray(dataSet)) {
        if (activeInputRef) {
          activeInputRef.current = containerRef.current
        }

with this check useEffect will not be called for not active input.
Can you please look into this, please?

all previous changes, change on node_modules/react-native-autocomplete-dropdown then run command  "yarn patch-package react-native-autocomplete-dropdown" it can be work for me

Hi, I have noticed issue with multiple dropdown when at least one of have onChangeText implemented and it changes parent's state.

Add at least two dropdowns within the same component.
Implement onChangeText that will set state e.g.

onChangeText={(text) => {
setState(text);
}}

Setting the state will cause re-render of component with dropdowns.
This useEffect will be called for each dropdown:

    useEffect(() => {
      if (isOpened && Array.isArray(dataSet)) {
        if (activeInputRef) {
          activeInputRef.current = containerRef.current
        }

        setContent(
          <Dropdown
            {...{
              ...props,
              direction,
              inputHeight,
              dataSet,
              suggestionsListMaxHeight,
              renderItem,
              ListEmptyComponent
            }}
          />
        )
      } else {
        setContent(undefined)
      }
    }, [
      isOpened,
      dataSet,
      props,
      direction,
      inputHeight,
      suggestionsListMaxHeight,
      renderItem,
      ListEmptyComponent,
      activeInputRef,
      setContent
    ])

As other dropdowns will not be openend the setContent(undefined) will be called and suggestion list will be hidden from the view.
The easiest fix I have found was to add check to mentioned useEffect :

    const close = () => {
      setIsOpened(false)
      setDirection(props.direction)
      setContent(undefined)
      activeInputRef.current = null <-- reset active ref
    }

    useEffect(() => {
      // check if active ref is the correct one
      if (activeInputRef.current && activeInputRef.current !== containerRef.current) {
        return;
      }

      if (isOpened && Array.isArray(dataSet)) {
        if (activeInputRef) {
          activeInputRef.current = containerRef.current
        }

with this check useEffect will not be called for not active input.
Can you please look into this, please?
all previous changes, change on node_modules/react-native-autocomplete-dropdown then run command  "yarn patch-package react-native-autocomplete-dropdown" it can be work for me

I have the same problem and need to use 5 Dropdowns in the same view. When searching in autocomplete the application becomes extremely slow and the list appears for a few seconds and then disappears. @lorenc-tomasz able to find any solution?

You can refer to the following method -> Add props:
closeOnBlur={true}
flatListProps={{
  keyboardDismissMode: undefined,
  onScrollBeginDrag: undefined,
}}

worked for me

@onmotion Any updates or work around for this bug?

@vijayanandof I'll try to reproduce


Test recording includes sp details

when running test live, client_id and secret is included in the recording.
this must be fixed in the test framework.

Hey @zikalino could we discuss that by email? To there is a ocntradiction in your text, when you put live and recording together in the same sentence :)
Curious to know more, since I would be surprised there is any trouble about that in the test framework.


Add Content-Length header for every responses

Motivation:
Currently armeria does not set Content-Length header for last request
of connection, Using 5th rule of RFC 4.4 to indicate transfer-length of the body.
But, RFC 14.13 mentions that application should use Content-Length to indicate
transfer-length, even though 4.4 seems to allow this. also, 14.13
prohibits to send content-length when response should not have entity
body, which armeria did not followed.
Also some clients depend on Content-Length only, which works
incorrectly if no header is provided.
Modifications:

Set Content-Length header if response have entity body, regardless
of connection status.

Result:
More standard-compliant, and it works better with other clients.

This PR is duplicated with #141, will close when it's merged.


Fix capitalization of "datetime" in wd_access_log/jsonschema/1-0-3

It should be camel case here: https://github.com/snowplow/iglu-central/blob/master/schemas/com.amazon.aws.cloudfront/wd_access_log/jsonschema/1-0-3#L80
The other three versions of the schema look fine.

Good point, thanks Fred.


Upon updating an existing post publish date doesn't display

Upon updating an existing post the publish date doesn't display again - the console logs the following error from this line...
field = undefined, path = "createdAt"
...from the following line...
console.warn('Invalid Column specified:', i);
...within item.js
The error is thrown whilst looking for "createdAt" within the fields array.
var field = _this.fields[path];
This is whilst updating an existing post on this webpage http://demo.keystonejs.com/keystone/posts/

Not reproducible in latest demo code.

I agree with the above comment, all seems fine to me. I'm trying to sort through all the current issues, so am going to close this.
If you're still having problems, please reopen and give more details. Thanks!


Delaying validation

I noticed that @egamma added code to delay validation in the onDidChangeContent handler for the TSLint extension. I have two questions about this:

Is this a general recommendation for all linters?
Have you considered building this functionality into VS Code somehow, so that linting extensions don't all have to include the same Delayer class?

Thanks.

@glen-84 yes. See https://github.com/Microsoft/vscode-languageserver-node/issues/42 which is the right repository for this feature request.

Oops! Sorry.


While re-compiling the Apex class

Describe the bug
We have installed Org Check app in our Organization We see the Apex classes and Batch classes to Compile while installing the app.
When we re-compiling the apex classes and Batch classes we see the error attached below.

To Reproduce
After installing the Org check app from App exchange we need to click on the Apex class component.

How many classes that need recompilation do you have in this org?

Hi Vince,
Here i have attached the error which we faced and the classes details in the screenshot.

Attached one more Screenshot please check

dear @akonduri77
How many classes do you have (before this error message) that needed recompilation in this org?
There is an open issue about this so i just wanted to make sure this is the same or something else?

the issue i am referring to is #256

Solved in Beryllium


clientv3: go get fails

I used, as described in the documentation, the following command to install the clientv3 package:
go get github.com/coreos/etcd/clientv3

And I go the error:
# github.com/grpc-ecosystem/grpc-gateway/runtime/internal
grpc-ecosystem/grpc-gateway/runtime/internal/stream_chunk.pb.go:29: undefined: proto.ProtoPackageIsVersion2
grpc-ecosystem/grpc-gateway/runtime/internal/stream_chunk.pb.go:49: undefined: proto.RegisterFile

I found the closed issue #5671 but this does not seem to solve the issue.
My go version:
go version go1.6.1 linux/amd64

Can you update github.com/golang/protobuf in your $GOPATH? etcd clientv3 doesn't enforce vendoring so it will still depend on your workspace to build it.
Or you can godep restore in etcd's cmd directory, if you want the same dependency as etcd releases.

rm -rf $GOPATH/github.com/golang/protobuf
go get github.com/coreos/etcd/clientv3

solved the issue. Thx.


Create System Fuel Flow

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context (wireframes, business rules, etc.)?
[x] Is this traceable to a feature, epic, or PI?

As a user, I want the ability to create Fuel Flow data so that I can add new Fuel Flow information
Acceptance Criteria:
Given the user has selected Create New Fuel Flow on the systems modal
And is on the Create Fuel Flow modal
When the user enters data for all required fields
And selects Create Fuel Flow
Then the system creates a new Fuel Flow
Max Fuel Flow Rate: Text, required
Units of Measure Code: drop down, required
Max Fuel Flow Rate Source: drop down, required
Start Date: date picker, required, format mm/dd/yyyy
Start Time: Text, required, format hh
End Date: date picker, format mm/dd/yyyy
End Time: Text, format hh
Refer to page 58 for values
Given the user has added information for a new fuel flow
When the user chooses not to create one (Cancel)
Then the user is navigated back to the main System Editor modal
Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[x] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
Design Wiki
Testing
Test Case: TC361
Tester: @mosesdeeCVP
Definition of Done

[x] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[ ] Has the code been unit tested and peer reviewed?
[ ] Have the functional tests been executed?
[ ] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Has the user story been accepted by the Product Owner?
[ ] Is the user story ready to be deployed to the test/staging environments?


https://boot2docker.io/

in the docs:

you will need boot2docker.

not sure where that link used to go but now it's a site about boots you wear on your feet. i guess someone bought the domain.

According https://github.com/boot2docker/boot2docker#:~:text=Boot2Docker is used via Docker,right from the command line boot2docker is deprecated.
Do finally someone manage to use portia via docker?


Conversations list after first context update via await conversation.wait()

Versions
grammy: 1.21.1
@grammyjs/conversations: 1.2.0
To reproduce: Start the bot. Enter /start command and then any text.
import { Bot, session } from 'grammy'
import { conversations, createConversation } from '@grammyjs/conversations'

const bot = new Bot('<YOUR_BOT_TOKEN>')

function one (conversation, ctx) {
  // Some function data
}

async function two (conversation, ctx) {
  console.log(ctx.conversation, 'Conversations list immidiately after enter')
  const newContext = await conversation.wait()
  console.log(newContext.conversation, 'Conversations list after context wait')
}

function three (conversation, ctx) {
  // Some function data
}

function four (conversation, ctx) {
  // Some function data
}

// Install the session plugin.
bot.use(session({
  initial () {
    // return empty object for now
    return {}
  }
}))

// Install the conversations plugin.
bot.use(conversations())

bot.use(createConversation(one))
bot.use(createConversation(two))
bot.use(createConversation(three))
bot.use(createConversation(four))

bot.command('start', (ctx) => ctx.conversation.enter('two'))

bot.start()

Behavior: four conversations before context update, and only two after (depends of order of processing on creation createConversation function in code):
ConversationControls {
  enter: [AsyncFunction (anonymous)],
  [Symbol(conversations)]: {
    ids: Set(4) { 'one', 'two', 'three', 'four' },
    session: [AsyncFunction (anonymous)]
  }
} Conversations list immidiately after enter

.... (Sending any to bot)

ConversationControls {
  enter: [AsyncFunction (anonymous)],
  [Symbol(conversations)]: {
    ids: Set(2) { 'one', 'two' },
    session: [AsyncFunction (anonymous)]
  }
} Conversations list after context wait

Expected behavior: list of all conversations:
Is it an issue, or i'm doing something wrong ?

What is your question?

How to get all installed conversations inside active conversation after  update ?

There's no way to list installed conversations. You're logging internal data that is only accessible to the plugin. Why do you need that?

Sometimes, needs an ability to enter other conversation from current. It there another way ?

Docs: https://grammy.dev/plugins/conversations#functions-and-recursion

Thank you so much. Can be closed. Went to read it.


Can't get expected result.

My TLS-Attacker version is 5.1.6. I use TLS-Attacker as a client to connect to an openssl server whose version is openssl1.0.1f. I modify the WorkflowTrace according to https://web-in-security.blogspot.com/2019/03/playing-with-tls-attacker.html and the concrete xml file (trace.xml)  is shown below.

<Send>
    <messages>
        <ServerHello/>
    </messages>
</Send>
<Receive>
    <expectedMessages>
        <ServerHello/>
        <Certificate/>
        <ServerHelloDone/>
    </expectedMessages>
</Receive>

I use openssl to set up TLS service, and then I run TLS-Attacker as a client. The expected result shown in the blog is like this

But I haven't got the same consequence.
The server:

The client:

So I want to ask for help about the reason and what I should yo do .Thank you!

You are sending a ServerHello message not a ClientHello message, this is why the server is (rightfully) complaining. ClientHello and ServerHello are two different messages in TLS.


Show last commit message in Git: Checkout to... dialog

Type: Feature Request
Currently the Git Checkout dialog shows the branch names and last commit ID, but it would be better to show the last commit message instead of the ID. It's very rare that you need to look for a branch with a specific commit ID.

VS Code version: Code 1.80.0 (660393deaaa6d1996740ff4880f1bad43768c814, 2023-07-04T15:06:02.407Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.80.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

@VSCodeTriageBot duly noted


fix msys/mingw portability

I noticed a compile warning (%a not supported for printf) when trying to build tinn on windows/msys2/mingw64
Also the resulting tinn.exe do not seem to compute correctly (scores are funky)
By searching a bit about the %a issue, I stumbled on this :
<EMAIL_ADDRESS>And adding -posix to CFLAGS on msys systems seems to do the trick

Now that's interesting. Thanks for this.

I may opt for not using %a and going with %f to keep things a little more portable

Well ; hmm I fear you might loose floating-point precision
%a seems rather standard anyway, it would be sad not to use it
plus, mingw64 seem to actually support it; it just has to be coerced to feature it ;-)

closing as obsoleted by #9


SFX-96 Setup TypeDoc for View Layer

Added Typedoc, @strictsoftware/typedoc-plugin-monorepo, and typedoc-plugin-nojekyll to Packages
Added doc generate script to package.json yarn docs
Added typedoc.js with some typedoc config
Added test comment to index.ts
Ran doc generate script and am committing those generated files
Added note to readme
Note this will not work until the related devtools PR is merged as well.

Please also update the submodule reference to the devtools repo.


Strings to localize

Please check screenshot. Those strings could/should be adde to source files?

Will do. Thanks.

Commit bfa19c823fa83808d76e343cfcba583f6024c0da makes those strings localizable.


sonic-visualiser: 4.2 -> 4.5.1

Description of changes
This package update was mainly done because 4.2 doesn't compile with GCC 12 which was fixed upstream in 5a7b517.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Thank you!


Switch from compiler.ast to ast

We should stop using the deprecated compiler module.  It also blocks Python 3 support.
See https://github.com/pyflakes/pyflakes/commit/f7626ea644ab0374e05e27dd152e916f25012a71 for an example of such migration.

Some work towards this was done in the wip/py3 branch.  Tests somehow pass, but I'm sure the code can't possibly be correct.
Caution: expect it to be rebased before it's merged.

Fixed in 0ef99a5de95897ac65eb99957e98d79dc0c80561.


Audio Issue

Whenever using the program the video compiles correctly and uploads to youtube , but has no audio.
Is there a fix that im not seeing?

Fixed the Issue I did not have the updated version of moviepy


Can't get java to compile when calling clojure code

Adding clojure to an already existing gradle java project
I have a java project that I want to start trying to add some clojure to, but I'm hitting a few issues. I'm not sure this is the right place to post this, but was hoping you would be able to help. I'm using the intellij IDE with the Cursive for clojure intellij plugin. I am also using this gradle plugin for clojure. My java classes recognize and can call my clojure code, but my java code will no longer compile because at compile time it can no longer see my clojure code. Do I need to add an extra step in my build.gradle? Do I need to compile them separately manually before trying to compile java? Any help would be appreciated. Also if this is not the correct place to post, can you point me in the right direction?
Environment

Component
Version

gradle-clojure
0.3.1

Gradle
4.4.1

Java
1.8

OS
Mac OS High Sierra

Logs

Switches used: e.g. --info --stacktrace
<> Task :compileJava FAILED
java:8: error: cannot find symbol
import com.example.clojure;
>

Feel free to reopen if this hasn't solved your issue.


Fix nextProps false positive in no-unused-prop-types

Fixes #1079
I did the same comparisons as the prop-types rules (https://github.com/yannickcr/eslint-plugin-react/blob/b64648521f9a7949eef4cd1a210768e906b4f3d1/lib/rules/prop-types.js#L130) for the no-unused-prop-types rule.
This way they both handle nextProps identically.
I also borrowed the test case from #1105.

+1


Substitutions in quotes

This allows for substitutions within single quoted strings.  Am very open to other ways of doing this.  Basically what I had to do was modify the "next token" logic to conditionally generate more than one token, and then queueing up any extras to be used before parsing any more.

How do you have $ or { in a single quoted string now? Can you add a docs update for this change like the lists+includes ones?


Incorrect time in the upcoming.ics calendar

Describe the issue
The time at https://datatracker.ietf.org/meeting/upcoming does not match the time imported in the calendar from https://datatracker.ietf.org/meeting/upcoming.ics
It assumed that it might be an issue from the data tracker migration and thus deleted the calendar and added it again on Google Calendar. I am still getting an incorrect time.

You can compare it with the time at https://datatracker.ietf.org/meeting/upcoming
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

@mcr has made several observations about google calendar on tools-discuss. I think we have an interop problem specific to that system. Speculation is that it remembers older things it has seen even if you think you've removed them.
The ics file does have the right timestamps in it (you can verify this with curl).
We are looking into using a different library to generate the ics files (right now we generate them with a django template). The result might irritate google calendar differently.

CELLAR, btw, looks wrong too.  It was at 1500 Eastern, which I think (based upon timeandate.com) would be 12:30am Bengaluru time, not 7:30am!
@rjsparks , I don't think that changing libraries is useful use of our limited resources.
I mean, you could look at the different output, and do some experiments against google calendar using static files.  I continue to suspect something about the ETag processing.
Without a google calendar internal person, I'd say we are lost.   (I'd pay them for a service with an SLA, but they won't take my money unless I give them everything, including DNS)
Maybe there are some @google.com people in the calendaring MLs that we could unicast.

Changing libraries is actually needed. And I should have said "Use a maintained library instead of rolling our own ics".
The 7 hour difference you point to says to me that this is leftover, at google, of the period where the timestamps in the datatracker were wrong.
Again, you can use curl to verify that what's in the ics now is correct. (Please do so - if you get a different answer from curl than me, we have a different problem to pursue).
rjsparks@undex tmp % curl --no-progress-meter https://datatracker.ietf.org/meeting/upcoming.ics | grep -A5 cellar
UID:ietf-interim-2023-cellar-05-14974
SUMMARY:cellar - Codec Encoding for LossLess Archiving and Realtime transmission
LOCATION:Amsterdam,NL
STATUS:CONFIRMED
CLASS:PUBLIC
DTSTART;TZID=Europe/Amsterdam:20230523T210000
DTEND;TZID=Europe/Amsterdam:20230523T220000
--
UID:ietf-interim-2023-cellar-06-14975
SUMMARY:cellar - Codec Encoding for LossLess Archiving and Realtime transmission
LOCATION:Amsterdam,NL
STATUS:CONFIRMED
CLASS:PUBLIC
DTSTART;TZID=Europe/Amsterdam:20230627T210000
DTEND;TZID=Europe/Amsterdam:20230627T220000
--
UID:ietf-interim-2023-cellar-07-14976
SUMMARY:cellar - Codec Encoding for LossLess Archiving and Realtime transmission
LOCATION:Amsterdam,NL
STATUS:CONFIRMED
CLASS:PUBLIC
DTSTART;TZID=Europe/Amsterdam:20230822T210000
DTEND;TZID=Europe/Amsterdam:20230822T220000
--
UID:ietf-interim-2023-cellar-08-14977
SUMMARY:cellar - Codec Encoding for LossLess Archiving and Realtime transmission
LOCATION:Amsterdam,NL
STATUS:CONFIRMED
CLASS:PUBLIC
DTSTART;TZID=Europe/Amsterdam:20230926T210000
DTEND;TZID=Europe/Amsterdam:20230926T220000
--
UID:ietf-interim-2023-cellar-09-14978
SUMMARY:cellar - Codec Encoding for LossLess Archiving and Realtime transmission
LOCATION:Amsterdam,NL
STATUS:CONFIRMED
CLASS:PUBLIC
DTSTART;TZID=Europe/Amsterdam:20231024T210000
DTEND;TZID=Europe/Amsterdam:20231024T220000
--
UID:ietf-interim-2023-cellar-10-14979
SUMMARY:cellar - Codec Encoding for LossLess Archiving and Realtime transmission
LOCATION:Amsterdam,NL
STATUS:CONFIRMED
CLASS:PUBLIC
DTSTART;TZID=Europe/Amsterdam:20231205T210000
DTEND;TZID=Europe/Amsterdam:20231205T220000

Ah! For the time being I removed the subscription from Google Calendar and moved it to the iCloud calendar. The time there is correct!

I'm going to close this as not-a-datatracker-bug (though it could well be that we could produce better ics, which we'll track at #5393 ).


[FLINK-22358][connector base] Add stability annotations to connector base and iterator sources.

What is the purpose of the change
Adds missing stability annotations to the Iterator Sources and Split Reader API:

The iterator sources classes are all @PublicEvolving: They are simple and stable across the 1.13 release.
The top-level Split Reader API classes are @PublicEvolving: SourceReaderBase, SplitReader, RecordEmitter, ...
The remaining classes used by the SourceReaderBase are @Internal: FutureCompletingBlockingQueue, SplitFetcher, SplitFetcherManager.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@becketqin - FYI - would be interested whether you share a similar understanding about stability and public-ness of the Split Reader API classes.

@flinkbot run azure

Manually merged


abnormal cardiac cell glucose uptake subterms

Split "abnormal cardiac cell glucose uptake" MP:0004039 into enhanced (increased) and impaired (decreased) child terms.
Anna

Added:
increased cardiac cell glucose uptake MP:0030018
decreased cardiac cell glucose uptake MP:0030020


can't detected Collecting your own Classification Datasets

can't detected everything (background and ..... ) in Jetson AI Fundamentals - S3E3 - Training Image Classification Models (youtube)

@dusty-nv  only background everytime


Question : using Parallelwavgan on slurm using multiple nodes with multiple GPUs

I am running ParallelWavgan on slurm using nodes = 2 , gpus per node =4 , total gpus = 8
It failed so the big question is " Does ParallelWavgan support multi nodes  "?
I'm sure It's working on single node with 4 gpus perfectly.

Multi node training is not supported.


Istio chart 100.0.2+up1.10.4 is shown as an installation option on kubertenes 1.23 clusters kube-version should prevent this

Rancher Server Setup

Rancher version: v2.6.5-rc11
Installation option: Chart

If Helm Chart, Kubernetes Cluster and version: RKE1 k8s 1.23

Proxy/Cert Details: valid certificates no proxy

Information about the Cluster

Kubernetes version: 1.23.6
Cluster Type: local or downstream

If downstream, what type of cluster?: RKE2
Infrastructure Provider: AWS

User Information

What is the role of the user logged in? Admin

Describe the bug
The Istio chart version 1.10.4 is displayed as an installation option on clusters with kubernetes 1.23.x
This chart version doesn't support k8s 1.23 and shouldn't be available as an install option
To Reproduce

Provision a k8s 1.23 cluster RKE1 or RKE2
Go to Apps -> Charts -> Istio

Result
The chart is available to install

Expected Result
The chart version 1.10 shouldn't be available on clusters 1.23 or newer
** Additional Context **
This is probably missing the catalog.cattle.io/kube-version annotation

Validated on rancher version v2.6.5
Validation steps followed.

Installed rancher server v2.6.5, KDM pointing to release-v2.6.
Provisioned a k8s cluster v1.23.6-rancher1-1
Navigated to the App ---> Charts.

Result:
Istio chart 100.0.2+up1.10.4 is not shown on k8s version v1.23.
Also validated if the Istio charts installs correctly on  k8s version v1.22, v1.21, v1.20.
All the istio versions installs correctly on the above mentioned k8s versions.
Hence, closing the issue.

That's is fine, but when is Istio going to be available for K8s 1.23.x? There is K8s 1.24.x available so 1.23 is not even the latest.
Regards,
Luiz


Updating branch for OpenSearch Dashboards 1.2

Updating the manifest for Dashboards 1.2 release.
Signed-off-by: Neumann<EMAIL_ADDRESS>Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #869 (4eadbef) into main (aa4cafa) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   91.18%   91.01%   -0.17%
==========================================
  Files          87       88       +1
  Lines        2370     2382      +12
==========================================
+ Hits         2161     2168       +7
- Misses        209      214       +5

Impacted Files
Coverage Δ

src/system/temporary_directory.py
82.75% <0.00%> (-13.80%)
:arrow_down:

src/system/os.py
92.30% <0.00%> (-7.70%)
:arrow_down:

src/run_perf_test.py
0.00% <0.00%> (ø)

src/run_integ_test.py
95.65% <0.00%> (ø)

src/manifests/test_manifest.py
100.00% <0.00%> (ø)

src/manifests/build_manifest.py
100.00% <0.00%> (ø)

src/manifests/bundle_manifest.py
100.00% <0.00%> (ø)

src/manifests/component_manifest.py
90.62% <0.00%> (ø)

src/manifests/manifest.py
98.27% <0.00%> (+0.03%)
:arrow_up:

src/manifests/bundle/bundle_manifest_1_0.py
89.65% <0.00%> (+0.76%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4cafa...4eadbef. Read the comment docs.

I think we need to make a change to our package.json?

Rebase this on top of #876, I think this is an unrelated failure.

Rebase this on top of #876, I think this is an unrelated failure.

✅ rebased


DOC: rename add_geom to patch_stats

should address #1383

Other than deprecation this LGTM

how do I deprecate a variable? (example would be sufficient).

Basically we need to avoid breaking people's code whether they used add_geom in a set of either args or kwargs, so this should do it:
read_bem_surfaces(fname, patch_stats=False, s_id=None, verbose=None, add_geom=None):
...
    if add_geom is not None:
        warnings.warn('"add_geom" is deprecated and will be removed in "
                      "0.10, use "patch_stats" instead", DeprecationWarning)
        patch_stats = add_geom

@Eric89GXL any other comments? Not sure what is up with Travis (it ran had one error: unrelated) and restarted. Does it always run twice?

Not usually, no. And FYI you can restart individual builds, which is better than restarting them all if only one fails.

LGTM, I'll merge once Travis is happy, feel free to ping me if you notice before I do

Minor style issues again. FYI you can run make flake locally to test it instead of waiting for Travis

how about now @Eric89GXL ?

Great thanks @dgwakeman!


What does "Daily maintenance at midnight PST will not allow reconnection to state otherwise." mean?

Do I have to be connected to the internet to use h2ogpt? I'm confused because when using the software and adding PDFs to the database when I restarted the app all that work dissapeared and there was no database. Does it mean I have to create an account to upload the database to the internet, but do it before midnight?

I should show that only for public instances case, will fix.
You should login via login tab to persist your state of collections and chats.
No, it doesn't use internet to do that.

Ah gotcha, thank you so much for this program, it's awesome!


codesign doesn't have an access to match imported keys

I've created a new certs/profile with match.
After first import on machin - codesign shows a GUI window, asking for access to the key.
If I press "Always allow" it will not ask again.
![screenshot]
(https://www.evernote.com/l/ADn6XG_rjHJDmYjgvDNoCfdiRBrVXk1WZD0B/image.png)

After pressing "Always allow" nothing changes on "Access Control" tab.


fix: style of the projectName so that it is visible completely

Fixes #3387
Describe the changes you have made in this PR -
Made Username and project name fully visible. And Solved these two small bugs through refactoring.
Screenshots of the changes (If any) -
Bug1

Before
After

Bug2

Before
After

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Not able to reproduce on MacOs

I did not test on macOS, am the issue was only reproducible on Windows and Linux in my experience.


[SIP-20] Proposal for Improving Examples Interface, Organization and Storage

[SIP] Proposal for Improving Examples Interface, Organization and Storage
The goal of the changes in this proposal is to improve the examples capabilities of Superset so as to foster an ecosystem of examples which will sustain and grow as the platform continues to develop. First I will characterize the existing system of examples and then propose changes to improve the number and quality of examples.
Current Examples
Examples are currently programmatically defined in the superset.data module. An abstract interface summarizing these examples looks like the following:
from abc import ABC

class AbstractSupersetExample(ABC):
    """Defines interface through which superset examples load themselves."""

    def __init__(self, description):
        self.description = description

    def load_data(self):
        # Task 1: Load file and create pandas.DataFrame
        # Task 2: Load data into SQL with pandas.DataFrame.to_sql()
        # Task 3: Process through ORM to get back workable Table object from whichever data source the table is in
        pass

    def create_metrics(self):
        # Task 1: Build any TableColumns
        # Task 2: Build Metrics - SQLMetrics
        # Task 3: Store metrics in DB via ORM
        pass

    def create_charts(self, chart):
        # Task 1: Build chart from config/JSON
        # Task 2: Store to DB via - misc_dash_slices.add(slc.slice_name) / merge_slice(slc)
        pass

    def create_dashboards(self, name, config):
        # Task 1: Instantiate Dash via ORM
        # Task 2: Configure Dash via JSON
        # Task 3: Store to DB via ORM
        pass

While this mechanism jump started the collection of Superset examples, defining examples as code will not appeal to most Superset users of growing a community that contributes examples.
Current Dashboard Import/Export
Dashboard example creation could utilize the export feature by adding example oriented fields to the export. Dashboards can be exported via the Dashboard List interface at /dashboard/list/ via its Export action or at the command line via  superset export_dashboards. Dashboard and chart export JSON includes everything needed to reproduce a dashboard save the actual data table: dashboard, chart and datasource information.
The datasources. __SqlaTable__.database element will need to be removed when examples are created and recreated when they are loaded to match SQLALCHEMY_EXAMPLES_URI or a —database-uri the user specifies. Each Slice’s datasource_id and datasource_name must be changed.
{
  "dashboards": [
    {
      "__Dashboard__": {
        "created_on": {
          "__datetime__": "2019-04-19T10:29:21"
        },
        "changed_by_fk": null,
        "slug": "world_health",
        "json_metadata": "{\"remote_id\": 1}",
        "description": null,
        "dashboard_title": "World's Bank Data",
        "changed_on": {
          "__datetime__": "2019-05-02T17:55:47"
        },
        "created_by_fk": null,
        "css": null,
        "position_json": {...},
  "id": 1,
  "slices": [
    {
      "__Slice__": {
        "created_by_fk": null,
        "cache_timeout": null,
        "params": "{\"compare_lag\": \"10\", \"compare_suffix\": \"o10Y\", \"country_fieldtype\": \"cca3\", \"date_filter\": false, \"entity\": \"country_code\", \"filter_configs\": [{\"asc\": false, \"clearable\": true, \"column\": \"region\", \"key\": \"2s98dfu\", \"metric\": \"sum__SP_POP_TOTL\", \"multiple\": true}, {\"asc\": false, \"clearable\": true, \"column\": \"country_name\", \"key\": \"li3j2lk\", \"metric\": \"sum__SP_POP_TOTL\", \"multiple\": true}], \"granularity_sqla\": \"year\", \"groupby\": [], \"limit\": \"25\", \"markup_type\": \"markdown\", \"metric\": \"sum__SP_POP_TOTL\", \"metrics\": [\"sum__SP_POP_TOTL\"], \"row_limit\": 50000, \"secondary_metric\": \"sum__SP_POP_TOTL\", \"show_bubbles\": true, \"since\": \"2014-01-01\", \"time_range\": \"2014-01-01 : 2014-01-02\", \"until\": \"2014-01-02\", \"viz_type\": \"filter_box\", \"where\": \"\", \"remote_id\": 371, \"datasource_name\": \"wb_health_population\", \"schema\": \"wb_health_population\", \"database_name\": \"main\"}",
        "datasource_name": null,
        "datasource_type": "table",
        "slice_name": "Region Filter",
        "changed_on": {
          "__datetime__": "2019-05-02T18:00:39"
        },
        "changed_by_fk": 1,
        "perm": "[main].[wb_health_population](id:2)",
        "description": null,
        "viz_type": "filter_box",
        "datasource_id": 2,
        "id": 371,
        "created_on": {
          "__datetime__": "2019-05-02T17:55:47"
        },
        "owners": []
      }
    }
  ],
  "datasources": [
    {
      "__SqlaTable__": {
        "created_on": {
          "__datetime__": "2019-04-19T10:29:20"
        },
        "sql": null,
        "cache_timeout": null,
        "changed_on": {
          "__datetime__": "2019-05-02T17:55:47"
        },
        "is_sqllab_view": false,
        "params": "{\"remote_id\": 2, \"database_name\": \"main\"}",
        "id": 2,
        "template_params": null,
        "perm": "[main].[wb_health_population](id:2)",
        "description": "<!--\nLicensed to the Apache Software Foundation...",
		  "created_by_fk": null,
        "table_name": "wb_health_population",
        "default_endpoint": null,
        "changed_by_fk": null,
        "main_dttm_col": "year",
        "is_featured": false,
        "database_id": 1,
        "filter_select_enabled": true,
        "fetch_values_predicate": null,
        "offset": 0,
        "schema": null,
        "columns": [
          {
            "__TableColumn__": {
              "created_by_fk": null,
              "python_date_format": null,
              "is_dttm": false,
              "description": null,
              "groupby": false,
              "type": "FLOAT",
              "verbose_name": null,
              "id": 4,
              "changed_by_fk": null,
              "created_on": {
                "__datetime__": "2019-04-19T10:29:20"
              },
              "table_id": 2,
              "filterable": false,
              "expression": "",
              "database_expression": null,
              "is_active": true,
              "column_name": "NY_GNP_PCAP_CD",
              "changed_on": {
                "__datetime__": "2019-04-19T10:29:20"
              }
            }
          },
			...
		  ],
        "metrics": [
          {
            "__SqlMetric__": {
              "created_by_fk": null,
              "table_id": 2,
              "d3format": null,
              "description": null,
              "metric_name": "sum__SP_POP_TOTL",
              "changed_on": {
                "__datetime__": "2019-04-19T10:29:20"
              },
              "metric_type": null,
              "changed_by_fk": null,
              "expression": "sum(SP_POP_TOTL)",
              "warning_text": null,
              "is_restricted": false,
              "verbose_name": null,
              "id": 3,
              "created_on": {
                "__datetime__": "2019-04-19T10:29:20"
              }
            }
          },
			...
		  ],
		  "database": {
          "__Database__": {
            "allow_csv_upload": true,
            "verbose_name": null,
            "created_by_fk": null,
            "allow_ctas": false,
            "database_name": "main",
            "changed_by_fk": null,
            "allow_dml": false,
            "sqlalchemy_uri": "sqlite:////Users/rjurney/.superset/superset.db",
            "force_ctas_schema": null,
            "password": null,
            "allow_multi_schema_metadata_fetch": false,
            "cache_timeout": null,
            "created_on": {
              "__datetime__": "2019-04-19T10:28:59"
            },
            "extra": "{\n    \"metadata_params\": {},\n    \"engine_params\": {},\n    \"metadata_cache_timeout\": {},\n    \"schemas_allowed_for_csv_upload\": []\n}\n",
            "select_as_create_table_as": false,
            "perm": "[main].(id:1)",
            "changed_on": {
              "__datetime__": "2019-04-19T10:28:59"
            },
            "expose_in_sqllab": true,
            "impersonate_user": false,
            "id": 1,
            "allow_run_async": false
          }
        }
      }
    },

A Slice object has a params_dict which contains the following. Note that this includes references to the datasource_name wb_health_population.
 {'compare_lag': '10',
  'compare_suffix': 'o10Y',
  'country_fieldtype': 'cca3',
  'entity': 'country_code',
  'granularity_sqla': 'year',
  'groupby': ['region', 'country_code'],
  'limit': '25',
  'markup_type': 'markdown',
  'metric': 'sum__SP_POP_TOTL',
  'metrics': ['sum__SP_POP_TOTL'],
  'row_limit': 50000,
  'secondary_metric': 'sum__SP_POP_TOTL',
  'show_bubbles': True,
  'since': '1960-01-01',
  'time_range': '2014-01-01 : 2014-01-02',
  'until': 'now',
  'viz_type': 'treemap',
  'where': '',
  'remote_id': 708,
  'datasource_name': 'wb_health_population',
  'schema': 'wb_health_population',
  'database_name': 'main'}]

Example Components
A Superset example is a SQL oriented dashboard and is composed of the following:
* Physical database with tables loaded with a dataset
* Superset Datasource object
* Table object
	* Column objects
	* Metric objects
* Dashboard object
* One or more chart objects

All of the above with the exception of the Datasource.Database entry will need to be serialized, stored, contributed, approved, listed, deserialized and loaded by the example system. The Datasource.Database entry will need to be removed on exporting and replaced on importing of examples.
Scope of Improvement
This proposal improves the superset example process in three areas: example creation, data storage and discoverability.
In order to improve the range and quality of Superset examples we need to first improve the process for creating and loading examples. While examples can be created programmatically, the more natural process is to use Superset to create them. This requires that we automate the process to persist and restore the combined state of the Superset Dashboard, Database and related objects as well as the contents of the datasource itself.
We also need a directory to which examples can be uploaded and a corresponding user interface and process of governance over that repository. This directory should be independent of the Superset project release process and code repository. Current processes for management of Superset’s code assets would transition directly to the management of its examples: changes would be created by creating Github issues and pull requests, data assets would be versioned and managed in a central repository.
Finally we need a user interface for finding, listing and loading examples from the repository. It should be simple and can exist as an examples command as part of the superset CLI which will have export, list , import and remove sub-commands.
Example Repository Requirements
The requirement for example storage are that it have the following properties:

Any user can view a list of all examples that have been published
Any user can upload an example and publish it - pending approval
Examples can be approved by committers by some mechanism
Approved examples can be published/released by committers by some mechanism
Management process/interface should match as closely as possible existing tools and practices.
The project is separate from Superset to enable more rapid and independent release cycles

Git and Github are a desirable mechanism for publishing and approval but an undesirable mechanism for storage. Git LFS (Large File System) offers scalable storage while still using Github for project management. With a 2GB file limit and support on Github for 250 of these files, it scales well and is the proposed storage system. Other options are explored in the addendum.
Example File Format
Examples should be defined and packaged in a standard manner and each example should be self contained in its own file system directory. The existing Dashboard export format adequately describes a dashboard, it’s charts and the associated datasources but is missing human readable fields describing the contents of the dataset and dashboard as well as the physical location of the contents of the tables the datasource metadata describes. These fields will be added to the Superset dashboard export format.
Data location information will be stored in a top level files key next to the existing dashboards, slices and datasources keys. A top level description field will fill out the fields of a description of the dataset in the examples directory. The existing World’s Bank Data example is extended below:
{
    “dashboards”: [ ... ],
    “datasources”: [ ... ],
    “description”: {
        "created_at": "2019-05-20T16:20:24.883125",
        "description": "World Bank Data example about world health populations from 1960-2010.",
        "file_count": 1,
        "license": "Apache 2.0"
        "title": "World Bank Health Information",
        "total_rows": 11770,
        "total_size": 22561353,
        "total_size_mb": 21.52,
    },
    “files”: [
        {
            "file_name": "wb_health_population.csv.gz",
            "rows": 11770,
            "size": 22561353,
            "table_name": "wb_health_population"
        }
    ],
    “slices”: [ ... ]
}

The file layout for this example appears as follows, with the dashboard slug used as the directory name in the exported tarball and examples directory:
/
/world_health
/world_health/dashboard.json
/world_health/wb_health_population.csv.gz

Example Data Table Format
In order to manage tables, to create and drop them, it is helpful to assume that an Integer id  primary column is present. This is the case for all current example dashboard tables. In the future we may want to support tables with uuid or other types of primary column.
New or Changed Public Interfaces
Changes include the addition of a SQLALCHEMY_EXAMPLES_URI  and EXAMPLES_GIT_TAG configuration keys and changes to the model classes as well as the CLI.
The examples-data Repository
Currently the example data is on Github at apache-superset/examples-data. This will continue to be the case, but this repository will now house both Dashboard metadata files as well as data files via Git LFS. Each example will have its own directory with its own dashboard.json and data files.
The README.md for this repository in new new form can be accessed here: GitHub - rjurney/examples-data at lfs.
SQLALCHEMY_EXAMPLES_URI Configuration Key
A SQLALCHEMY_EXAMPLES_URI configuration key in superset/config.py controls the default location to load examples into. This defaults to ~/.superset/examples.db and can be over-ridden on a per-import basis using the --database-uri/-d option.
EXAMPLE_REPOS_TAGS Configuration Key
A EXAMPLE_REPOS_TAGS  configuration key in superset/config.py controls the locations of the examples from which to list and load. This can be set manually using the --examples-repo/-r option. The format of the items are a tuple containing the full repository name (ex. apache-superset/examples-data) and the git tag/branch of the repository to use (ex. master).
In config.py the default entry will look like:
# Tuple format: Gitub repo full name, tag/branch
EXAMPLE_REPOS_TAGS = [
    ('rjurney/examples-data', 'v0.0.3')
]

GITHUB_AUTH_TOKEN Configuration Key
Github rate limits the contents API to 50 anonymous requests per hour. While this is unlikely to affect many users, the limit is by IP address which means users behind proxies or developers may sometimes encounter this. I have added the optional configuration key GITHUB_AUTH_TOKEN  which provides a way to add a personal access token to requests from the examples sub-commands. This increases the API limit.
UUIDs via sqlalchemy.types.uuid.UUIDType
In order to export or import assets in a way that doesn’t result in integer primary key chaos, we require that each serialized asset have a unique identifier. The superset.models.helpers.ImportMixin class has been used to provide a uuid field to the following classes:

Dashboard
Datasource
Database
DruidCluster
DruidMetric
Slice
SqlMetric
SqlaTable
TableColumn

This required patching FlaskAppBuilder to support UUIDType as a String field type. This will be released with FlaskAppBuilder 2.1.4.
ImportMixin —> ImportExportMixin
I was confused by the role of ImportMixin in model class export, so accordingly I have renamed it to ImportExportMixin.
Command Line Interface
Example capabilities will be accessed via the command line (CLI) interface. The CLI will be changed, removing the load_examples command and replacing it with an examples subcommand with export,  list, import and remove commands beneath it.
Top Level CLI Menu
superset —help
Usage: superset [OPTIONS] COMMAND [ARGS]...

  This is a management script for the Superset application.

Options:
  --version  Show the flask version
  --help     Show this message and exit.

Commands:
  db                        Perform database migrations.
  examples                  Manages example chart/dashboards/datasets
  ...

Dashboard Exports Menu
The dashboard exports menu will be extended to add the —dashboard-titles/-t, —export-data/-x and —export-data-dir/-d options which facilitate example export.
superset export_dashboards --help
Usage: superset export_dashboards [OPTIONS]

  Export dashboards to JSON

Options:
  -f, --dashboard-file TEXT    Specify the the file to export to
  -p, --print_stdout           Print JSON to stdout
  -i, --dashboard-ids INTEGER  Specify dashboard id to export
  -t, --dashboard-titles TEXT  Specify dashboard title to export
  -x, --export-data            Export the dashboard's data tables as CSV
                               files.
  -d, --export-data-dir TEXT   Specify export directory path. Defaults to
                               '/tmp'.
  --help                       Show this message and exit.

Examples Top Level Menu
superset examples —-help
Usage: superset examples [OPTIONS] COMMAND [ARGS]...

  Manages example dashboards/datasets

Options:
  --help  Show this message and exit.

Commands:
  export  Export example dashboard/datasets
  list    List example dashboards/datasets
  import  Import an example dashboard/dataset
  remove  Remove an example dashboard/dataset

Example Creation Menu
The examples creation command can be used to export a Dashboard JSON file along with its underlying data tables into a gzipped tarball file. These assets can then be uncompressed in the examples-data project, committed, pushed and then submitted by pull request.
superset examples export --help
Usage: superset examples export [OPTIONS]

  Export example dashboard/datasets

Options:
  -i, --dashboard-id INTEGER  Specify dashboard id to export
  -t, --dashboard-title TEXT  Specify dashboard title to export
  -d, --description TEXT      Description of new example  [required]
  -e, --example-title TEXT    Title for new example  [required]
  -f, --file-name TEXT        Specify export file name. Defaults to
                              dashboard.tar.gz
  -l, --license TEXT          License of the example dashboard
  --help                      Show this message and exit.

Examples List Menu
The examples list command will query the examples-data repository and return a list of available examples along with their metadata. Examples can then be loaded from this list.
superset examples list —-help
Usage: superset examples list [OPTIONS]

  List example dashboards/datasets

Options:
  -r, --examples-repo TEXT  Full name of Github repository containing
                            examples, ex: 'apache-superset/examples-data'
  -r, --examples-tag TEXT   Tag or branch of Github repository containing
                            examples. Defaults to 'master'
  --help                    Show this message and exit.

The output looks table uses prettytable and looks like this:
+-------------------------------+-------------------------------------------------------+-----------+-------+-------+------------------+-----------------------+--------+
|             Title             |                      Description                      | Size (MB) |  Rows | Files |   Created Date   |       Repository      |  Tag   |
+-------------------------------+-------------------------------------------------------+-----------+-------+-------+------------------+-----------------------+--------+
| World Bank Health Information | World Bank Data example about world health populat... |   21.52   | 11770 |   1   | 2019-05-20T16:20 | rjurney/examples-data | v0.0.3 |
+-------------------------------+-------------------------------------------------------+-----------+-------+-------+------------------+-----------------------+--------+

Examples Import Menu
The examples import command will download example metadata and data files from the examples-data repository and will load them into the examples database configured via the SQLALCHEMY_EXAMPLES_URI configuration key or using the value supplied by the —database-uri/-d option.
superset examples load --help
Usage: superset examples load [OPTIONS]

  Load an example dashboard/dataset

Options:
  -d, --database-uri TEXT       Database URI to load example to
  -r, --examples-revision TEXT  Revision of examples to list
  -e, --example-title TEXT      Title of example to load  [required]
  --help                        Show this message and exit.

Examples Remove Menu
The examples remove command will remove the installed example specified from the metadata tables as well as the examples database configured via the SQLALCHEMY_EXAMPLES_URI configuration key or using the value supplied by the —database-uri/-d option.
superset examples remove --help
Usage: superset examples remove [OPTIONS]

  Remove an example dashboard/dataset

Options:
  -e, --example-title TEXT  Title of example to remove  [required]
  -d, --database-uri TEXT   Database URI to load example to
  --help                    Show this message and exit.

New Dependencies
Creating, removing, listing and loading examples can be handled without Git LFS but adding examples to the examples-data Github repository will require it. This is a developer only requirement of the examples-data project and not Superset itself.
Git LFS can be installed via:
# OS X
brew install git-lfs
# port install git-lfs
git lfs install

# Ubuntu
curl -s https://packagecloud.io/install/repositories/github/git-lfs/script.deb.sh | sudo bash
sudo apt-get install git-lfs
git lfs install

Migration Plan and Compatibility
Backwards compatibility will be maintained. Existing dashboard export JSON files will continue to work and all existing dashboard examples and their data files will be ported to the new system and stored in the Superset examples repository.
Cross-Repository Management
As both the examples and Superset evolve, some will work with newer versions of Superset than others. We must strive to keep all of them up to date, but should also try to make them backwards compatible. It will thus be inevitable that incubator-superset releases will have to point to a branch/tag of superset-examples.
A given release of superset must reference a certain version of the examples-data repository. This is achieved via the EXAMPLES_GIT_TAG configuration key. Alternatively, this could be a branch rather than a tag to facilitate the ongoing update of examples.

NIT:

let's rename to superset examples load to superset examples import
let's rename to superset examples create to superset examples export

Table name collisions is not addressed in the PR or this SIP.
--nodata is not implemented in the PR or SIP

The other parts are addressed in the PR and SIP.

I'm closing this for a few reasons:
• Some of it (import/export, UUIDs) has already been tackled.
• It's been open for a long time, without being brought to a DISCUSS thread
• It's pretty broad in scope, and may need to be broken down into smaller pieces if we want to carry it through.
@rjurney if you'd like to reopen this, update a little of the context, and perhaps break down the into smaller chunks for discussion/voting/implementation, just say the word, and I/we can re-open it! Thank you for all the hard work and thought that has gone into this, it'll definitely serve as a useful reference for work going forward in this area either way!


[Event Request] Codeunit 6520 - Item Tracing Mgt. - OnBeforeNextLevel

Hello,
Can we add an event to Codeunit 6520 "Item Tracing Mgt." called OnBeforeNextLevel.
local procedure NextLevel(var TempTrackEntry: Record "Item Tracing Buffer"; TempTrackEntry2: Record "Item Tracing Buffer"; Direction: Option Forward,Backward; ShowComponents: Option No,"Item-tracked only",All; ParentID: Integer)
var
    ItemLedgEntry: Record "Item Ledger Entry";
    ItemApplnEntry: Record "Item Application Entry";
    TrackNo: Integer;
    IsHandled: Boolean;   // NEW
begin
    with TempTrackEntry2 do begin
        if ExitLevel(TempTrackEntry) then
            exit;
        CurrentLevel += 1;

        // >> NEW
        IsHandled := False;
        OnBeforeNextLevel(TempTrackEntry, TempTrackEntry2, Direction, ShowComponents, ParentID, CurrentLevel, TempLineNo, IsHandled);
        if IsHandled then
            exit;
        // << NEW

// >> NEW
[IntegrationEvent(false, false)]
local procedure OnBeforeNextLevel(var TempTrackEntry: Record "Item Tracing Buffer" temporary; var TempTrackEntry2: Record "Item Tracing Buffer" temporary; Direction: Option Forward,Backward; ShowComponents: Option No,"Item-tracked only",All; ParentID: Integer; var CurrentLevel: Integer;var TempLineNo: Integer; var IsHandled: Boolean)
begin
end;
// << NEW

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


React::NativeLibrary for re-using JS based react components

Not so much an issue as a feature request, but I am looking for a clean natural way of re-using JS based React components alongside ruby based JS components.
In trying to get this to work, I have been using React::NativeLibrary as a base class then importing the JS component but this does not work as React::NativeLibrary expects a JS library not a react component.
The code I would like to write is something along these lines:
class TimeAgo < React::NativeLibrary
     # something to import a JS based react component (*react timeago in this example)
end
And then to use this something like:
TimeAgo(date: "Jan 1, 1990") {}
Many thanks!

https://www.npmjs.com/package/react-timeago

PS: I have written up the issue on StackOverflow and also added a workaround here: http://stackoverflow.com/questions/36466338/how-do-i-import-a-javascript-or-jsx-based-component-into-react-rb-so-it-is-acces/36499842#36499842

This issue was moved to reactrb/reactrb#139


[WIP] Add transformer base class and adapt preprocessor / converter to fit + apply

add transformer base class and make converter / preprocessor its direct subclasses
adapt CPreprocessor::init(CFeatures *) to fit, possibly call cleanup in fit if already fitted to support re-fit
cleanup type check in init of preprocessors, use CFeatures::as instead in apply phase
add parameter 'inplace' (default true) to preprocessor / converter :: apply, in which case transform in place if possible
drop CDimensionReductionPreprocessor since it is only a wrapper of converters and provides irrelevant things (kernel, distance, ..) for subtypes.
subclasses of CDimensionReductionPreprocessor inherit directly from `CDensePreprocessor<float64_t>
Make KernelPCA inherit from CPreprocessor since it can work with other types of features

This is a cool push!

have u seen these @vinx13
The following tests FAILED:
	 84 - python_legacy-distance_canberraword (SEGFAULT)
	 86 - python_legacy-distance_hammingword (SEGFAULT)
	 87 - python_legacy-distance_manhattenword (OTHER_FAULT)
	137 - python_legacy-kernel_comm_ulong_string (SEGFAULT)
	138 - python_legacy-kernel_comm_word_string (SEGFAULT)
	180 - python_legacy-kernel_weighted_comm_word_string (Failed)
	207 - python_legacy-preprocessor_sortulongstring (SEGFAULT)
	208 - python_legacy-preprocessor_sortwordstring (SEGFAULT)
	214 - python_legacy-serialization_string_kernels (SEGFAULT)
	227 - python_legacy-tests_check_commwordkernel_memleak (SEGFAULT)
Errors while running CTest


Feature/pricing update 2

Pull Request
Are you a current Fivetran customer?

Internal
What change(s) does this PR introduce?

Updates package to reflect to new pricing update and corresponding new usage_cost table existing in users on the new pricing model. See https://github.com/fivetran/dbt_fivetran_log/pull/44 for more.
Did you update the CHANGELOG?

[x] Yes

Does this PR introduce a breaking change?

[ ] Yes (please provide breaking change details below.)
[x] No  (please provide an explanation as to how the change is non-breaking below.)
Shouldn't impact users on older pricing model and for users on new pricing model this should be net new. But I updated the version by +0.1.0 since it's pretty big

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

[x] Yes

Is this PR in response to a previously created Bug or Feature Request

[ ] Yes, Issue/Feature [link bug/feature number here]
[x] No

How did you test the PR changes?

[x] CircleCi
[ ] Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

[x] BigQuery
[x] Redshift
[x] Snowflake
[x] Postgres
[x] Databricks
[ ] Other (provide details below)

Provide an emoji that best describes your current mood

:dancer:
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

An update we will want to make with this before release is adopt a new methodology to incorporate BOTH amount and credits used in the final model instead of just doing either or.


Issues loading the npm version on latest Pi4 with latest OS version

I would really like to use this software on a pair of Pylontech US3000 batteries to gain an insight into the readings and status.
Another pi 3 is monitoring the RS485 port on my Sofar Hybrid 3600 inverter with no issues taking readings into Emoncms and an InfluDb for Grafana reporting which works really well.
I propose to use a USB to serial/RS485 into the first battery but so far cannot load the software.
Any advice welcomed and medium level skills.
Errors from the install fills several pages even with latest NPM and Node versions.
Look forward to hearing from you on this matter.
Alan

Looks like i'm having issues with the crc16 module .

<EMAIL_ADDRESS>install /home/pi/solar-sis/example/US3000+US2000/node_modules/crc16
node-gyp rebuild

gyp ERR! clean error
gyp ERR! stack Error: EACCES: permission denied, rmdir 'build'
gyp ERR! System Linux 5.4.72-v7l+
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/pi/solar-sis/example/US3000+US2000/node_modules/crc16
gyp ERR! node -v v12.19.0
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>No license field.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!


Zend\Db Initial Refactor For Beta3: Adapters, Driver, TableGateway, Metadata

This is the initial refactor for Zend\Db.  It includes database support for:

MySQL through ext/mysqli extension
Sqlite through ext/Pdo_Sqlite extension
SQL Server through ext/sqlsrv extension
[more to follow in later beta releases]

The feature set includes:

Zend\Db\Adapter component: composed of a Driver and Platform
Zend\Db\TableGateway component: for the table gateway pattern
Zend\Db\Sql component: initial query abstraction component
Zend\Db\Metadata component: metadata abstraction
Zend\Db\ResultSet component: for prototype based result set object containers

Examples can be found at:
https://github.com/ralphschindler/Zend_Db-Examples

It's impossible to figure out how operational this is - there are no unit tests included in the PR?

@padraic Yep, no unit tests. I think I explained that part in the email to the mailing list.  Basically, I don't want to produce a unit testing suite similar to what we had in ZF1.  In order to do it correctly, I feel we need proper DDL abstraction, which is not complete. Each test should reset the database to a clean state without having to break down and build up the schema.  There should also be an API for allowing unit tests to test fringe schema use cases.
That said, unit tests will be a focus of a later beta release.  In the mean time, use https://github.com/ralphschindler/Zend_Db-Examples/ as a working use case scenario.

@ralphschindler TDD would be my preferred approach because test last mostly aims for coverage.


H.264 answer no longer works

Your environment.
Chrome 73.0.3683.75
pions/webrtc: 3426d00e2cda
What did you do?
Chrome generates the offer, and my program generates the answer only with h.264 support. It then creates a H.264 track and sends it to the browser.
What did you expect?
Chrome to play back correctly.
What happened?
Chrome receives the packets but is unable to decode them. webrtc-internals shows that the SSRC is a VP9 stream, not H.264 like expected. This was working as of last night but there was probably a Chrome update. It does not work for the rest of my team either.
I tried a number of things to fix the issue, but what ultimately worked was having my application generate the offer instead. This implies that there is some SDP nonsense going on.

Fixed with 40f5b9459b25de413bae4af6bc5ccbfd5861a013


envoy-1.27: unable to build envoy as root (was: bazel build -c opt envoy not working on release branch)

found similar issue #23065 back in 2022 was fixed, here the failing due to following code: https://github.com/envoyproxy/envoy/blob/3c0b60a5bb6394c237fb26e299298787b62b8097/bazel/repositories_extra.bzl#L17C10-L17C10
ps. obviously the same issue in main branch

cc @phlax

found similar issue https://github.com/envoyproxy/envoy/issues/23065 back in 2022 was fixed

it wasnt fixed, we added a workaround temporarily to allow any downstreams to fix their builds
the workaround is still there (ignore_root_user_error) but is no longer the default
you can continue using the workaround by editing the WORKSPACE file, but the much better solution is to fix your build so as not to run as root inside the build container

it wasnt fixed, we added a workaround temporarily to allow any downstreams to fix their builds

Would it be somehow possible to control that flag in a downstream build without modifying core Envoy?

Would it be somehow possible to control that flag in a downstream build without modifying core Envoy?

as discussed offline - i dont think its possible to flip this switch without editing the WORKSPACE file, as it is a "repository" level settting, not a build flag. I may be wrong about this, but this is my understanding

this is (some of) the bazel docs related to repositories https://bazel.build/extending/repo
its possible that you could define rules_python using a custom rule, altho im not entirely clear how to do it
tbh tho this feels like a red herring when the source of the problem is obvious

certainly help wanted

@pgeler what further help do you require?
i think this ticket should close - the real solution is not running as root but the workaround is described otherwise

I don't see a solution, my understanding, enforcement of root, in the envoy build script exactly preventing overriding it from custom rules. So for now we just patching the root enforcement, but it would be better if envoy can provide a custom flag which we can pass to bazel at envoy build time.

I don't see a solution, my understanding, enforcement of root, in the envoy build script exactly preventing overriding it from custom

this is not enforced by envoy - its enforced by rules_python

So for now we just patching the root enforcement, but it would be better if envoy can provide a custom flag which we can pass to bazel at envoy build time.

there is not a simple flag that can be passed at build time afaiaa - but happy to be proven wrong (i posted links above for anyone interested in figuring that out)
enabling this - ie working around the enforcement by rules_python is not a priority - as much as it may not be the responsibility of rules_python to enforce this, running as root is a bad idea

my understanding of ignore_root_user_error = False is exact enforcement. Unfortunately I'm not a bazel expert either, but it should be a better way of doing such configs, could be something like this https://github.com/bazelbuild/rules_python/releases and one of the recent patches https://github.com/bazelbuild/rules_python/pull/1114/files 🤔

my understanding of ignore_root_user_error = False is exact enforcement.

that is the default - and one we are ~happy to go with
changing this in your WORKSPACE is trivial

it should be a better way of doing such configs, could be something like this https://github.com/bazelbuild/rules_python/releases and one of the recent patches https://github.com/bazelbuild/rules_python/pull/1114/files 🤔

its not immediately clear what this does
checking here tho - nothing is jumping out that suggests configurability
https://github.com/search?q=repo%3Abazelbuild%2Frules_python ignore_root_user_error&type=code
at the end of the day, i wonder why so much energy is put into trying to workaround this - why not just fix your build so you dont need to use root - this is also generally pretty trivial

enabling this - ie working around the enforcement by rules_python is not a priority - as much as it may not be the responsibility of rules_python to enforce this, running as root is a bad idea

there are multiple reasons why it's simpler for us to do this, and from security perspective we are using multistage builds, so I guess the vote here to give flexibility... and I appreciate everybody time, that is why I would keep it open with help wanted, so that I believe solution for the people with good bazel knowledge should be simpler than the discussion here ;)

how about raising an  issue upstream - to either ask if/how to configure this as a build option, or if not currently possible then whether it could be added
i dont see anything actionable from an Envoy pov
i made my thoughts clear upstream when this change was introduced, but at the end of the day - its not something i want to fight against or even workaround

i would definitely be happy to review a PR if you want to raise on that would make this configurable

ok, as a workaround it's possible for us to use custom WORKFLOW and pass an argument registration of the extensions:
...
load("@envoy//bazel:repositories_extra.bzl", "envoy_dependencies_extra")

envoy_dependencies_extra(ignore_root_user_error = True)
...

this solution is working for our use case where custom WORKFLOW is defined.
however, to make it beneficial for original WORKFLOW use-cases it would be interesting to see if it's possible to define args on the main WORKFLOW and pass it as something like(seem more question for bazel capabilities and if envoy want such flag exposed):
...
load("@envoy//bazel:repositories_extra.bzl", "envoy_dependencies_extra")

envoy_dependencies_extra(ignore_root_user_error = args.ignore_root_user_error)
...

This works, it seems like it's also added by default under mobile/WORKSPACE.


add easyinference

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.87%.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   68.87%   68.87%
=======================================
  Files          35       35
  Lines        2503     2503
=======================================
  Hits         1724     1724
  Misses        779      779

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bible API

Cool API, thanks!
Any way to "reference" the books by index number or position in an array - rather than by name?

Not currently, but that should be possible to add. I'll see what I can do.

My work-around:  I made an array of books with "name:value-pairs"  of {"1:Genesis", "2:Exodus", ..."n:name"}  .
Now I am thinking of a "for loop" to pull down whole chapters at a time.
Just learning my javascript here :-)
John

@pinckneyjjp if your goal is just to fetch the entire bible from the API, you might be more interested in our bible_parser project.
Then you could do this in Ruby:
require 'bible_parser'

bible = BibleParser.new(File.open('web.usfx.xml'))
bible.books.each do |book|
  book.chapters.each do |chapter|
    chapter.verses.each do |verse|
      p verse.to_h
      # yields:
      # {
      #   num: 1,
      #   book_id: "GEN",
      #   book_num: 1,
      #   book_title: "Genesis",
      #   chapter_num: 1,
      #   text: "In the beginning, God created the heavens and the earth.\n"
      # }
    end
  end
end

You could even convert an entire book to JSON with something like this:
require 'json'
require 'bible_parser'

bible = BibleParser.new(File.open('web.usfx.xml'))
book = bible.books.first # genesis

book.chapters.map { |c| c.verses.map { |v| v.to_h } }.to_json

Hitting the API for every chapter, one-at-a-time, will be slow.
(Also, if you degrade the service for others, I'll probably end up blocking your IP 😬)

No need to block me: I'll take your hint.   I will practice my javascript by other means and get back to your site after learning a bit more rails.  Thanks!


Incorrect remote on webdav uri from Reva

Reva sends incorrect remote URI on addReceivedShare API.
https://github.com/pondersource/nc-sciencemesh/blob/25aa1650124525c438ebb44d0db0a8c73fd7ffd4/lib/Controller/RevaController.php#LL945C6-L945C6
Received: remote.php/dav/ocm/acBFP5sqWXdd6jyeEnijDeMbFie9lYfL
Instead of: https://oc1.docker

Found the problem and fixed it on my local:

Reva needs to know WebDavEndpoint to create the URL.
https://github.com/cs3org/reva/blob/f81247e9b27f1a90ab00200f2a6c6e233ee34cae/internal/grpc/services/ocmshareprovider/ocmshareprovider.go#L64
We do have not this in our config.

Yes sorry, see https://github.com/cs3org/ocm-test-suite/commit/db40b01854e452c4c771b685bc0be8c325e20279

And https://github.com/pondersource/dev-stock/commit/e3cecf9ff1fc37937c83f5f42c3061341dafae79
I'm building the Docker image now, will update here when pushed to Docker hub

pondersource/dev-stock-revad-network-beta docker image pushed

Sorry I forgot to build and push this yesterday after I fixed it in my own env!


README Improvements, and Ease of Use

[+] Improve Starting + Stopping via QoL (npm start & npm stop when running the project in a terminal)
[+} Talk about editing conifg.js
[+] Add an example .env file
[+] Clean up README
haven't tested the stop script, however, npm start works on my local machine on Win10 21H1.

Cheers mate.

💀


INTENG-3915 Update Unity SDK to support latest iOS SDK

Update the iOS SDK to Version 0.21.14 - replaced the Branch-SDK folder and the Fabric folder with the latest folders from iOS Branch repo
Updated the BranchiOSWrapper.mm - Renamed the ContextMode enums as they were modified in the latest iOS version. Commit here: https://github.com/BranchMetrics/unity-branch-deep-linking/commit/c7e09134b90695afbe90fb1e2b61640263a991ec#diff-9e1e1506bec6d13a3ab9fb013c6dcb1e
Update the Unity Package with latest files and the version to 0.3.28.

👍


Refactor TransactionBody to include a TransactionParameters

Is your feature request related to a problem? Please describe.
Conceptually, a Penumbra transaction is just a bundle of actions that have effects on the chain state.
Currently, these fields are all put into the transaction body without any organization. Instead, it would be cleaner to bundle them together. Other than the encrypted memo, all of the existing fields in the transaction body specify parameters about when the transaction should be accepted to a chain — for instance, the chain id the transaction is for, the expiry height after which it is no longer valid, etc.
This suggests a way to conceptually clarify the definition of the transaction data, as three items:

a list of actions that have effects on the chain state;
an encrypted memo describing information about the purpose of the transaction;
a set of transaction parameters controlling when the transaction should be accepted.

Describe the solution you'd like
Refactor the transaction data modeling to introduce a TransactionParamaters proto and domain type.
Additional Context
This will also allow us to refactor the effect hash computation so that a signer can consider each of the parts of the transaction in turn, without having to load an entire transaction plan all at once. The effect hash could be computed by, for instance, hashing the memo packet, the parameters packet, and each of the actions.

I guess we should also figure out where the FMD clues fit into this taxonomy.


more robust table extraction

Refine table extraction and add more test cases.

@unsleepy22 Thanks for the PR, everything looks OK to me but the code could be improved using the suggestions above.

@unsleepy22 Thanks for the PR, everything looks OK to me but the code could be improved using the suggestions above.

Thanks for your comments, updated accordingly, would you take a look again?


Boxes missing from form fields on Ontario rent Increase form

Attach (recommended) or Link to PDF file here:
N1.pdf
Configuration:

Firefox Nightly

What is the expected behavior?
The "On" box and "your rent will increase to" boxes should have a box for each character. They do in Preview, Adobe Reader, and Chrome
What went wrong?
No boxes. The font used also seems different in Chrome/Adobe Reader vs Firefox. (There's no line through the '0' character in Chrome or Firefox)

Those fields are comb fields (text widget annotations) and I don't think we do anything with the appearance stream in the display layer. More importantly, we also don't seem to keep it around when printing. I would expect at least printing to keep the original appearance stream, but preferably the display layer should also take it into account.

Yep, the only information we extract from the appearance are the font size, fg color and the font size:
https://github.com/mozilla/pdf.js/blob/7c8a92da77aa658ff72ef2591d59f1d47971ef41/src/core/default_appearance.js#L28
and a new appearance is created when printing/saving for a comb:
https://github.com/mozilla/pdf.js/blob/7c8a92da77aa658ff72ef2591d59f1d47971ef41/src/core/annotation.js#L1852
So if we want to display something from the appearance, we must be able to extract those drawing instructions but without getting ones used to display the text (field value).


Playlists not showing up

I have an issue, that when i do python spotdl.py -u myusername it does only show 2 playlists that i had before installing your code. I have since installing added many more playlists but the wont show up.
I also tried doing "Scripts/pip.exe" install -U -r requirements.txt since i'm on windows to reinstall but it didnt help either.
Btw i dont understand anything bout coding so if u have any fix suggestions it would be nice of u if you could try to explain it to me as detailed as possible :)

Are your playlists public? Playlists must be set to public for the script to see them. Can you confirm?

Thank you very much!! Didnt know that they would need to be public and also i didnt know that when u follow a playlist (i didnt create them myself) it was automatically set to private now. (Because the old playlists i followed years ago and they showed up)
Again tyvm!

Yep, the script can only access publicly available data of the users.


fix main file

The main file is ngrx-undo.umd.js instead of store-undo.umd.js.
Care to do a release after this fix?

released to 1.0.1 Thanks for the fix

Thanks @brechtbilliet !


Support passing generators to insert_many()

@usrlocalben this PR is lacking a unit test to test this change. Is there any chance you can add one?

Thanks for contributing!


[WIP][macOS] Fix caret position handling

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

You can test this PR using the following package version. 11.0.999-cibuild0031966-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0032098-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0032111-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]