kivy-mode keeps indenting

I open an empty file in emacs with kivy mode set. I type
Label:

and press Enter. It indents label 4 spaces to the right.
I find this annoying. Is this known/expected behavior?

I'm fairly sure this is expected and generally desirable - usually when a line ends with a colon, the next line will be a child widget or property of what you just wrote.

I'm sorry, I think I didn't express myself well. The line that gets indented is the one with Label: itself. The following line (the one in which the cursor ends up) ends up indented by 8 spaces.

Oh, I see. That sounds like a bug to me, but is not happening for me. I think I might have installed kivy-mode via package-install (probably from MELPA), does that version work for you?

I'm trying to investigate. Learning how to use emacs's debugger and how to read elisp. I'm using spacemacs. kivy-mode installed in a folder called elpa so that's probably where it came from.

I'm confused. Maybe someone more experienced can help me. I have evaluated (debug-on-entry 'kivy-indent-line). Then I create a file foo.kv and type Foo: and press Enter. The debugger starts. I eventually get to this call-stack.txt
I press d until the function syntax-ppss-flush-cache returns. Then Foo: gets indented 4 spaces. The strange thing is if I call myself the function (by evaluating (syntax-ppss-flush-cache 1 1)) it doesn't indent Foo:.


[Request]Quaternion from between vectors

Could we have a function that creates a quaternion from two in-between vectors? Essentially the same function as
Quaternion.fromBetweenVectors(u, v) in Quaternion.js.
The operation could also be optimized.

I was not planning on adding that API, but I would not say no to a pull request…


Cluster deletion stuck while deleting with --destroy-cloud-resources param

Below is the observation after the debugging.
Hosted cluster config operator is waiting for ingresscontroller cluster operator to get deleted
Where I am seeing below finalizer added by hosted-cluster-config-operator.
  Finalizers:
  ingresscontroller.operator.openshift.io/finalizer-ingresscontroller

But ingresscontroller is throwing below error
2022-08-22T12:19:50.235Z	ERROR	operator.ingress_controller	controller/controller.go:121got retryable error; requeueing	{"after": "15s", "error": "not all router pods have been deleted for openshift-ingress-operator/default"}
It seems router-default pod got stuck in terminating state
dharaneesh@Dharaneeshwarans-MacBook-Pro-2 commit-2 % kubectl get po -n openshift-ingress -o wide
NAME                              READY   STATUS        RESTARTS   AGE    IP            NODE             NOMINATED NODE   READINESS GATES
router-default-6b5f875bb7-8blzp   1/1     Terminating   0          122m   <IP_ADDRESS>   dhar-tor-f7kbk   <none>           <none>

Tried to collect logs from kubelet service but nodes were also getting deleted concurrently. So could not collect it.

/cc @csrwng @mkumatag


New version: RoyQu.RedPanda-C++ version 2.10

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.4 schema?

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Scaling feature

This is related to the recent discussion on discord on how some things on this playground is not ideal for video presentation.
One such thing that this PR addresses is preserving visual space when scaling up the page, and only scaling the important UI that users only care about during video presentation, which is the code (Monaco editor) , and the page result (Result iframe/panel).

Here's a screenshot of current website when zoomed in 150%. As you can see the Header takes up a lot of valuable space. Other smaller UI elements when all added together take up space as well.

Here's the alternative zoomed in elements when artificially zoomed in "150%"

What's Added
Zoom button in Header

How is scaling done?
It updates Monaco's editor font-size editor.updateOptions({ fontSize });.
For the Result panel, it's done via transform property and width/height.
.container {
  transform: scale(1.2);
  transform-origin: 0 0;
  width: 88.33%;
  height: 88.33%;
}

There is a CSS property zoom, but it's experimental, is not supported by Firefox, and I couldn't get it to work on an iframe.
Dropdown Behavior
The button when selected, opens a dropdown with the zoom settings. The dropdown has a "focusout" behavior where pressing Escape key or clicking/focusing outside of the container will close the dropdown.

When pressing Ctrl+ or Ctrl-, the dropdown opens temporarily (1200ms) for immediate feedback.
The dropdown becomes the active element and is focus(). Previous focused element will regain focus() when user presses Escape key or dropdown closes after timeout( as long as dropdown hasn't been interacted with, such as Tabbing or selecting inside it or mouse cursor moves within it)
Settings

There's zoom buttons such as increase, decrease, and reset.
If users are not happy how the default page scaling shortcuts were overriden, there's an option to disable that.
If the user is only interested in scaling Monaco's text, you can disable scaling the Result iframe.
Result iframe is scaled

Result iframe is not scaled

Something I've been debating. Have an option to disable the alternative zoom altogether and when selected will reset to default scale of "100%" and the zoom inputs will be disabled.

Hey sorry, that took me a little bit of time to get back to you but man that looks awesome! This surely will be of a lot of help for Ryan when he does his demo and anyone using the playground for showcase on a screen share.
Browser zoom is totally fine as a naming to me. The way you setup the option as is is also completely fine to me.
Overriding by default might not be the best in term of accessibility, but it's probably not the worst either.
Would you consider this feature finished on your end?
PS: Awesome PR description!

So you're okay with the first option, "Override browser zoom keyboard shortcut".
I agree that override by default is not the best in terms of accessibility, but users wouldn't know about this useful "optimal" zoom. That's why I made sure when you zoom, the dropdown includes the disable option, in case they don't want that. Originally I was going to hide it under  "Advance Settings" for design minimalism, but I wanted users to see right away they can disable it.
This feature complete on my end.

Wonderful, I'll merge that as is. This is a really clean implementation.
Thank you very much!


Always pull subctl

Always get subctl since we're using "moving versions" and putting it in
the image has the layer cached (and stale)
Signed-off-by: Mike Kolesnik<EMAIL_ADDRESS>

Looks good, helm is just missing https://github.com/submariner-io/submariner-charts/pull/117 which was merged 2 minutes ago.


Remove JSON_PRETTY_PRINT

Pretty print is a PHP 5.4 "feature"

So this raises the question, what is the minimal requirements for deploynaut, 5.3 or 5.4?

closed in favor of #306


updated documentation to remove MySQL and create a TO README.md

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1240/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1243/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1244/
Test PASSed.


Fix for WFCORE-3672, Extend CLI security command with support for Authentication

EAP Feature: EAP7-943
WF-CORE: WFCORE-3672
Management and http-server auth commands.
Tests of feature and completion.

WARNING: Once this one is merged, a PR will have to be open in Full to merge tests specific to http-server. Branch is: https://github.com/jfdenise/wildfly/tree/auth-command
A running experimental job showing that the http-server tests are passing: https://ci.wildfly.org/viewLog.html?buildId=98335&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperiments

Dev analysis is at https://github.com/wildfly/wildfly-proposals/pull/32

retest this please

@mchoma could you review it please?

@jfdenise This feature is missing some community documentation (maybe in http://docs.wildfly.org/Admin_Guide.html#Command_Line_Interface) before it can be merged

Core - Full Integration Build 7141 outcome was UNKNOWN using a merge of e762a75869acc877463ae23977b2c8b6ac93fb24
Summary: Canceled (Error while applying patch; cannot find commit ee5480342b45e1db9bf25c2e3756c540c22a9d53 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/3212/merge branch was updated and the commit selected for the ... Build time: 00:00:08

Core - Full Integration Build 7147 outcome was UNKNOWN using a merge of 8bc17ce07e7f019667ecb0d2481d5bc4912b9378
Summary: Canceled (Error while applying patch; cannot find commit 7a9efd7640bd0dfbd750fef5d67a7fa9fc1d8074 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/3212/merge branch was updated and the commit selected for the ... Build time: 00:00:18

Core - Full Integration Build 7156 outcome was UNKNOWN using a merge of 5f75429d4ee91c9347231861e72a13faff9171d5
Summary: Canceled (Error while applying patch; cannot find commit f1d13b3bea76f805353bde05871541e94b0d0592 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/3212/merge branch was updated and the commit selected for the ... Build time: 00:00:12

retest this please!

@jfdenise I have noticed security enable-ssl-management removes security-realm=ManagementRealm. That is probably not necessary ManagementRealm by default does not provide ssl-context. If it do Elytron ssl-context should be preffered.

@jmesnil , community doc is written, PR will be open with the tests dedicated to undertow commands: https://github.com/jfdenise/wildfly/tree/auth-command

@mchoma are you approving the PR as it stands now that @jfdenise has addressed your comments?

@jmesnil l everything is cleared now. I approve.


Move to pypdf

because of #22 #25 #16
suggestion:

Drop md2pdf and use this insead
https://github.com/py-pdf/pypdf

Hi, did you try running it with this library? While examining some options I have tried, but it wasn't so stable as well.
anyway I'll dig into that, thank you!

Thank you @rotemweiss57 sorry I have not been able to test it!


evaluation code for real dataset

Hi, @YANG-H @msftgits @dnfclas @zhangmozhe @msftdata,
Table4 in the main paper shows a quantitative comparison on KITTI dataset in terms of consistency,  fidelity, and minimum matching distance(MMD).   Could you please share the code for the evaluation of the real dataset?
What's more, is the MMD * 10000 or *1000 or just not multiply value?
Best,
YIngjie

Thank you for the question!
For the KITTI dataset, we follow the evaluation in GRNet repo (https://github.com/hzxie/GRNet)
We used MMD*1000.


Configure chip actions

I found it confusing that some chips directly navigate when tapping/clicking while others will perform an action. This has caused me to turn off all my lights/switches multiple times, causing some problems.
I've added an option to swap the tap and hold actions where applicable.
If I'm the only one with this problem feel free to close this PR, I can keep my own private version.

It's probably all ok, but let me check also tomorrow.
It seems odd to have no default options configured, but always creating the same property in the constructor.

Review comments for FanChip.js, also apply to the other chip classes.

The switch chip is, in my case, a dangerous chip..
When clicking on it, it triggers all the switches so that the fuses blow!

The switch chip is, in my case, a dangerous chip.. When clicking on it, it triggers all the switches so that the fuses blow!

This PR is pretty much stale... What do you suggest for improving the chips?
Please discuss it in the discussions section or create an issue.

Closed for being stale.


Auto create topics producer

Thank you for the great library.
As it was mentioned in this issue it would be nice to be able to set topic creation option to be in line with auto.create.topics.enable broker option. According to docs the default option is true, so I added this to Kafka\Config.
Thank you in advance.

@lcobucci, I don't think functional tests needed, because my code doesn't manage actual Kafka settings (or saves the user from setting the wrong option). It simply ensures that you can acknowledge producer about auto topics creation, so that this check can pass (Kafka\Producer\RecordValidator):
if (! isset($topicList[$record['topic']])) {
      throw Exception\InvalidRecordInSet::nonExististingTopic($record['topic']);
}

Now it doesn't respects kafka broker option auto.create.topics.enable.

@lcobucci, I agree that tests needed. If I understand correctly, configuring the Kafka itself is out of scope this library. So the only thing we can test in functional tests is the behavior: auto.create.topics.enable is disabled in Kafka, but the producer think it is enabled. To test such thing multiple Kafka containers need to be running (this option is set during process start). Such test will ensure that we handle this exceptional situation appropriately. I am not a docker nor Kafka aficionado (yet) so from the top of my head it is hard to create such test infrastructure:)

I am not a docker nor Kafka aficionado (yet) (...) Does this looks ok to you? I would appretiate a direction, because as I said I am not a docker expert.

@Sevavietl no worries, you're not alone 👍
I think that using a .env file would help us achieve this more easily (instead of creating many definitions of Kafka servers), these might be helpful: https://docs.docker.com/compose/env-file/ and https://docs.docker.com/compose/compose-file/#env_file. This file could also be used in the test runner execution, which would allow to know which scenario we're covering.


Limit privilege escalation to var.username

This rule allows all users to have privilege escalation when using sudo for all commands. This is not a good practice.
Suggested solution is to user TF variable username which is already a requirement for the module:
         sudo: ${var.username}=(ALL) NOPASSWD:ALL

This behavior is intentional by design, specifically concerning the sudoers configuration. What the current configuration does is that any user added to the sudo group will have privilege escalation without requiring a password.
As stated in the sudoers configuration man page (sudoers(5)):
The % notation is used to include all members of the sudo group in this role. Users from other groups will not have privilege escalation by default unless they are added to the sudo group.


Jobs in generated piplines not executed

Minimal .gitlab-ci.yml illustrating the issue
clone https://gitlab.com/gitlab-org/project-templates/jsonnet
run gitlab-ci-local
Expected behavior
jobs in triggered pipeline should run
job/blue, job/cats, job/foxes, job/goats, job/green, job/red
Host information
Ubuntu 24.10
gitlabci-local 4.52.2
Containerd binary
docker

I believe this is a duplicate of https://github.com/firecow/gitlab-ci-local/issues/94


Is this approximating elephant by fitting a curve to some sample data points?

Could you elaborate on the high level steps in your elephant.py? To me, it seems like you are feeding it a sample elephant curve's points and then defining the parameters in shape (num_points, 4). You randomly initialize the parameters array and use the parameters to compute the approximated points. You then take the loss of the computed points with the actual elephant points and minimize this.
My questions are:
How did you decide the shape of K? From what I understand, the paper has K from 0 to infinity in the series. Did you just arbitrarily decide to truncate the summation?
Why did you choose t to be a linear range between 0 and 2 pi?
I am just a university student with basic math skills (linear alg, calculus, stats) so please forgive these easy questions!

Also, I see you load in your sample points from a serialized numpy array. How did you determine these points? Did you just plot 8 points in the rough shape of an elephant?

Your description of how the algorithm works sounds correct to me.
The trick is that with a fourier series we can approximate any curve:

Did you just arbitrarily decide to truncate the summation?

Yes, mostly. Higher values of k correspond to more parameters which correspond to more precise approximations of the given contour points.

From what I understand, the paper has K from 0 to infinity in the series.

In the paper, they stop at k = 5. You can tell from the table where the largest index of A_k^x, A_k^y, B_k^x, B_k^y is 5. Or you could also say that k goes to infinity and all coefficients with k > 5 are zero.

Why did you choose t to be a linear range between 0 and 2 pi?

If t does not cover a multiple of 2 pi, the contour curve does not end where it started, so it would look weird.

Also, I see you load in your sample points from a serialized numpy array. How did you determine these points? Did you just plot 8 points in the rough shape of an elephant?

For the elephant from the paper, I used the coefficients from the paper to calculate 128 points along the curve (stored in points_elephant.npy). Those are enough points to get almost the same exact coefficients back when minimizing the least square loss. Less points would probably work, too.
For the fancy elephant, I downloaded a photo of an elephant, sketched a binary mask of it and extracted the contour points with OpenCV's findContour function.

I am just a university student with basic math skills (linear alg, calculus, stats) so please forgive these easy questions!

No problem. Feel free to ask more questions :)


ci: force usage of npm version 9 with tests

node 14.x with windows-latest builds are failing as they can't install tedious https://github.com/GoogleCloudPlatform/cloud-sql-nodejs-connector/actions/runs/5204041695/jobs/9406565728

Seems issue is a windows/npm issue and not tied to version of npm


CVE-2024-0406 Archiver Path Traversal vulnerability

https://pkg.go.dev/vuln/GO-2024-2698 was published today and makes https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck fail.

But 3.5.2 is not released yet, it is only available in a fork

@mholt Any chance to publish a v3.5.2 as fix?

@mholt I am also looking for the fix of this CVE. Any chance we are going to publish v3.5.2 this week?

I'd also like to see a release of this. Our build is failing with govulncheck because of this.

@mholt Just checking in again to know if you plan to release the CVE-free version soon.

@mholt Just rechecking if we will get CVE-free version any time soon?


jailbreak failing at 36/38 ip6 11.4.1

Describe the bug
A clear and concise description of what the bug is and what you expected to happen.
I jailbreak with unc0ver on b38, and then when I run it a few times, becaude i have to extract bootstrap and create system snapchat etc. then on the final time i click jailbreak it goes to 36/38 but then on the log it says now running uicache in the log and after that it restarts. i have tried turning on and off refresh icon cache but then it doesnt work and still restarts i went on r/jailbreak discord and they say reboot and try again tried this same result im on 11.4.1 on iphone 6
To Reproduce
Steps to reproduce the behavior: Not Reproduceable as its when I click on it, note i did run restore rootfs then upgraded to b38 then this issue came out of noware

Go to ,,,'
Click on '....'
Scroll down to '....'
See error

Screenshots
If applicable, add screenshots to help explain your problem.
Device (please complete the following information):

iOS Version: 11.4.1
iOS Device: iPhone 6
unc0ver Version: b38

Place an "x" between the brackets if true:

[ ] this is a bug others will be able to reproduce
[x] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[x] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver

Logs
If applicable, add logs or error messages here.
https://www.dropbox.com/s/73dcxzq7oi81e4w/diagnostics.plist?dl=0
Note: im not sure if this is duplicate of another issue since, all of them that may be similar are either on 12.12 or provide no soultion

oops relize im on b36

fixed the issue by upgrading sorry


Building multiple solutions

Hello, me again with more naive questions.
Building with gradlew dotnetBuild now produces an output for one of the solutions, but only one of them. There are four in the project, the code, some data, the unit tests, and a sample app that I'm just using for testing.
The code builds, but not the data. I was pleased that I was able to load the .nupkg file in another project, but it can't finish the import because of the dependency on the data assembly.

hi @ndw
depending on the structure, you might have two different approach

having a .sln including multiple csproj, so building one solution builds multiple projects at once, and you could have proper project references as well
use sub-project feature in gradle as mentioned in https://docs.gradle.org/current/userguide/intro_multi_project_builds.html

I'd just as soon avoid sub-projects. Ultimately, these all go together and don't need to stand alone.
Before I posted the question, I looked in the .sln file to see if I could work out how to tell it to build more than one .csproj, but the different projects all appear to be referenced the same way:

Microsoft Visual Studio Solution File, Format Version 12.00
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "XmlResolver", "XmlResolver\XmlResolver.csproj", "{B347954F-8FC1-49A1-AF2E-1C46F030B8AC}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "UnitTests", "UnitTests\UnitTests.csproj", "{EB15F220-858B-4661-B5E1-25BAE467B77D}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SampleApp", "SampleApp\SampleApp.csproj", "{44D45D23-B2A1-4EF2-B838-6B019FE1C7FF}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "XmlResolverData", "XmlResolverData\XmlResolverData.csproj", "{F3EDFC12-6E8B-46BC-A56B-DA7EA373D4D8}"
EndProject
Global
	GlobalSection(SolutionConfigurationPlatforms) = preSolution
		Debug|Any CPU = Debug|Any CPU
		Release|Any CPU = Release|Any CPU
	EndGlobalSection
	GlobalSection(ProjectConfigurationPlatforms) = postSolution
		{B347954F-8FC1-49A1-AF2E-1C46F030B8AC}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
		{B347954F-8FC1-49A1-AF2E-1C46F030B8AC}.Debug|Any CPU.Build.0 = Debug|Any CPU
		{B347954F-8FC1-49A1-AF2E-1C46F030B8AC}.Release|Any CPU.ActiveCfg = Release|Any CPU
		{B347954F-8FC1-49A1-AF2E-1C46F030B8AC}.Release|Any CPU.Build.0 = Release|Any CPU
		{EB15F220-858B-4661-B5E1-25BAE467B77D}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
		{EB15F220-858B-4661-B5E1-25BAE467B77D}.Debug|Any CPU.Build.0 = Debug|Any CPU
		{EB15F220-858B-4661-B5E1-25BAE467B77D}.Release|Any CPU.ActiveCfg = Release|Any CPU
		{EB15F220-858B-4661-B5E1-25BAE467B77D}.Release|Any CPU.Build.0 = Release|Any CPU
		{44D45D23-B2A1-4EF2-B838-6B019FE1C7FF}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
		{44D45D23-B2A1-4EF2-B838-6B019FE1C7FF}.Debug|Any CPU.Build.0 = Debug|Any CPU
		{44D45D23-B2A1-4EF2-B838-6B019FE1C7FF}.Release|Any CPU.ActiveCfg = Release|Any CPU
		{44D45D23-B2A1-4EF2-B838-6B019FE1C7FF}.Release|Any CPU.Build.0 = Release|Any CPU
		{F3EDFC12-6E8B-46BC-A56B-DA7EA373D4D8}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
		{F3EDFC12-6E8B-46BC-A56B-DA7EA373D4D8}.Debug|Any CPU.Build.0 = Debug|Any CPU
		{F3EDFC12-6E8B-46BC-A56B-DA7EA373D4D8}.Release|Any CPU.ActiveCfg = Release|Any CPU
		{F3EDFC12-6E8B-46BC-A56B-DA7EA373D4D8}.Release|Any CPU.Build.0 = Release|Any CPU
	EndGlobalSection
EndGlobal

I don't see anything in there that looks like it says "build XmlResolver" but not the others.
If it's obvious to you what I need to do to make this build all four projects, please do tell. Otherwise, I guess this isn't really a plugin bug and thank you for taking the time to reply!

Sorry I misunderstood your original question, to build only one csproj you might set solution to the csproj , and you might use project properties to control which csproj to build
dotnet {
    solution = "src/${project.property('csproj')}"
}```

Then build using ./gradlew dotnetBuild -Pcsproj=(path to csproj to build)

No, I think you understood, I just confused you with a poorly written comment. Sorry about that. I'm not sure I really understand the C# terminology exactly.
I have a directory containing build.gradle and under it is a "solution" (XmlResolver/XmlResolver.sln, that's the file I showed above) that consists of four "projects", (XmlResolver/XmlResolver/XmlResolver.csproj, XmlResolver/XmlResolverData/XmlResolverData.csproj, XmlResolver/UnitTests/UnitTests.csproj, and XmlResolver/SampleApp/SampleApp.csproj).
I want gradle dotNetBuild to make all of them, but today it only builds XmlResolver/XmlResolver/XmlResolver.csproj

I take that back. I removed all the bin and obj directories and ran the build again. It does repopulate the build outputs for each project, but it only makes one .nupkg file. The XmlResolver-0.0.1.nupkg file requires the data assembly, so (I think) I need XmlResolverData-0.0.1.nupkg as well. (I don't actually need a NuGet package for SampleApp because that's just a playground for debugging and trying to learn about the C# APIs and obviously I don't need to package the unit tests.)
I would like the resolver and its data to be separate assemblies, but I can probably live with making them a single assembly if it's not possible to make both NuGet packages.

you need to have <GeneratePackageOnBuild>True</GeneratePackageOnBuild> in csproj in order to generate nupkg on build
I think it is missing in your data project now

That was it. Thank you. And thank you very much for your patience!


Is there a tool to translate arm assenmbly code to llvm-ir?

Hi,
I  want to translate arm assembly code such as cortex-m3 or cortex-m0 to llvm-ir, and this project smilarly don't support it? Do you try it? And Is there good reference to do the translation?
best regards.

Correct. Remill does not yet support lifting "classic ARM" instructions like those used in ARMv6-M (Coretex-M0) or ARMv7-M (Coretex-M3).
Remill currently only supports the ARM 64-bit instruction set (AArch64) used by ARMv8-A.
The list of ARM AArch64 instructions currently lifted by Remill is listed here.


Use correct channel when pushing link prefetch messages

Fixes #781 by using the same code flow as the channel messages themselves, instead of assuming the wrong target.

Prefetching is still partially broken:

Only the first and last link embed/prefetch, the rest do nothing (the toggle button doesn't work)

Sounds like an unrelated bug, but I'll take a look.

I'm thinking, should we move link.js out of irc-events to avoid confusion in the future?

Most likely when we refactor the link fetcher, yeah.

Great job!


Merge type_registry into the catalog...

... so that the catalog takes over the type_registry's responsibilities.

[sc-39810]


streams should never stop silently

In response to #53 and #48

@zachguo @wiertz thoughts on this approach to handle stream disconnects?
In the case that an error occurs (eg: network weather) an error will be thrown from the async iterator. Meanwhile if a stream is disconnected healthily from Twitter's end it will simply end the stream. Practically this means if you want a 24/7 stream you would:
async function listenForever(streamFactory, dataConsumer) {
  try {
    for await (const { data } of streamFactory()) {
      dataConsumer(data)
    }
    // The stream has been closed by Twitter. This may occur for many reasons and it is
    // usually safe to reconnect.
    listenForever(streamFactory, dataConsumer);
  } catch (error) {
    // An error occurred so we reconnect to the stream. Note that we should probably have
    // retry logic here to prevent reconnection after a number of closely timed failures (may
    // indicate a problem that is not downstream).
    listenForever(streamFactory, dataConsumer);
  }
}

listenForever(
  () => client.stream('tweets/search/stream'),
  (data) => console.log(data),
);

Looks good as far as I can tell and in contrast to my hack means that data is not croweded with signals and reconnect logic could be integrated into the package at some point. Do you know under what conditions a network disconnect will trigger the error event of the stream?

Looks good as far as I can tell and in contrast to my hack means that data is not crowded with signals and reconnect logic could be integrated into the package at some point. Do you know under what conditions a network disconnect will trigger the error event of the stream?

My understanding is that if the TCP body is malformed, an error will be thrown. If the stream is disconnected because of network inactivity, the timeout code should kick in and raise a "Stream unresponsive" error. And in the case of a healthy disconnect, no error will be thrown.


add QDM as bias correction option

This PR updates the core bias correction code to include the QDM method (Cannon et al., 2015) by specifying the bias correction method at the CLI interface.
Specifically, it adds:

CLI interface: dodola biascorrect <method> <methodstring> <inputURL> <modeltrainingURL> <obstrainingURL> <outputURL>
updates bias_correct_bcsd to apply_bias_correction to support both BCSD and QDM by including a method argument
updates apply_bias_correction to include QDM code
xclim is now a dependency
testing is still with BCSD since we don't have a way to test both methods currently

closes #18

Thanks @brews. I just added testing capability for QDM with the "less fast option" that you outlined above, testing exactly the same way that we are for BCSD currently (and now we're testing for both methods). So this is ready for a review.

Ah, something else for us to think about is changing the CLI arguments into options so CLI inputs need to be passed in with flags rather than based purely on position. Should make it easier to parse because we're getting so many parameters.
I think this is something we can hash out in another PR, though.
I'll put this into an issue.

Yo @dgergel, are we good to merge this?

@brews yup we're good! Thanks!


Appending completion date when completing tasks would break the original block link

What happened?
When can set the following for completing tasks, then the completion date would be appended to the end of the task description (after the block link). This would break the original block link of the task.

Therefore, it would be great if the completion date would be appended to the end of the task description but before the block link, if any.
The following issue for another task manager plugin may be related:
Support appending date/text before block ID · Issue #10 · ebullient/obsidian-task-collector
DQL
No response
JS
No response
Dataview Version
0.4.21
Obsidian Version
0.13.6
OS
MacOS

Good catch.

Also running into this issue. Noticing something else happening as well: when the task is unchecked, and the completion date inline field removed, the space between the block link and the (now removed) completion field is still there. This actually breaks parsing of the originally included block id:

Starting condition

Task is marked complete. Note that the block link is rendered as normal text, showing it is not parsed

Task now marked incomplete. Note location of cursor: one space to right of end of block link. Note block link still rendered as normal text, showing it is not parsed.
Which means, if I now try to link to the task, a whole new block ID is created:

Above fix would solve this as well!

This would be the function that needs amending, in case anyone wants to attempt it: https://github.com/blacksmithgu/obsidian-dataview/blob/ae6e4507d0bb8cf9a1bd82cd9b5071768d901901/src/ui/views/task-view.tsx#L311


Add coordinates for the generic airfoils

Closes #73 by adding coordinates for the 3 airfoils which did not have them defined.

Thanks Matt! :D


[Latitude] Update check to match error

As given in the error, latitude must be between -90 and 90 but the code is checking -180 and 180 like longitude

Silly mistake on my part, thanks for the input. Good job !


time is not labeled correctly

Hi there,
When I try to plot my data in time, the x-axis show some not understandable float rather than a date. Is this a correct behavior?
Simplified version of my code is shown below
function App() {
    let currentTime = new Date();
    let currentTime2 = new Date().setHours(new Date().getHours() + 1);
    let currentTime3 = new Date().setHours(new Date().getHours() + 2);
    let workerCount = {
        label: 'Worker Count',
        data: [{x: currentTime, y: 1},
               {x: currentTime2, y: 2},
               {x: currentTime3, y: 3}],
        color: "#00ff00"
    };
    let [plotData, handlePlotDataChange] = useState([workerCount]);
    let [axes, handleAxesChange] = useState([
        { type: 'linear', position: 'left' },
        { primary: true, type: 'time', position: 'bottom' }
    ]);

    return (
            <div style={{ width: '800px', height: '600px', 'marginTop': '10px' }}>
                <Chart data={plotData}
                    axes={axes}
                    primaryCursor
                    secondaryCursor
                    tooltip />
            </div>
        </div>
    );
}

Output:

Same problem I'm facing.

This is because you need to round minutes and milliseconds too. Even if you have equally spaced hourly items, d3-scale is finding the least common denominator for the time and if it includes smaller time units than an hour, then the specificity will show down the hour. Unfortunately, the default time formatter doesn't show the full time when doing millisecond display, so you end up just seeing the milliseconds.

is this behavior expected to always remain?


Commented out info about the Jobs CLI

Note: I can't do a local build of the /1.8 directory, so I can't test if the text I commented out actually disappears.

@sascala did you test the output of this locally? looks a bit off for me: https://cl.ly/1U121b1u2w0q

I can't. /1.8/ isn't "latest," so I can't do a local build

I removed the mentions of the CLI commands entirely. I can't view the local build ATM, but I can double check everything when the page is live.

@sascala please fix the merge conflicts

there's some kind of unresolvable merge conflict here. Closing to redo.


Format error decoding Hdr

Dark Crystal 1.2.vpx
Failed to read image dimensions for JPS_Env TT6.1.hdr: Format error decoding Hdr: Radiance HDR signature not found

moved to https://github.com/image-rs/image/issues/2375


Dummy change ignore me

Dummy PR testing primate as git submodule
Related testing primate PR - https://github.com/apache/cloudstack-primate/pull/366

doh

later - we need to figure out how CloudStack PRs can depend or related with Primate PRs; some strategy to test them together... will start a thread on dev@ soon.


Day120

Resolves #248.

Pull Request Test Coverage Report for Build 476

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 474:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


[backport v2.9.next1] Add vGPU allocatable warning banner

This is a backport for https://github.com/rancher/dashboard/pull/11017
Fixes https://github.com/rancher/dashboard/issues/11517

@a110605 let us know if there's anything else for you to look at here since with Francesco out, we'll need someone else to merge. If you feel everything's OK based on your own concerns, then you can approve & merge. Code freeze is tomorrow for 2.8.next1 & 2.9.next1 so time is tight.

@gaktive I spoke with @a110605 and this is awaiting backend changes- moving to 2.9.next1

cc @rebeccazzzz
@a110605 @nwmac just so it's written down somewhere, what backend changes are needed for the updates to the banner wording?


[IOTDB-1172] Remove unexpected exception thrown when all CreateTimeseries opeartions are successful for CreateMultiTimeseries

Hi, @LebronAl this bug has been fixed together in this pr
https://github.com/apache/iotdb/pull/2698

Hi, @LebronAl this bug has been fixed together in this pr
#2698

Hi, I think it's unnecessary to record every status to multiPlan.results even all opeartions are successful, which means multiPlan.getResults().put(i, RpcUtils.getStatus(TSStatusCode.SUCCESS_STATUS)); can be deleted.
What's your opinion?

Hi, @LebronAl this bug has been fixed together in this pr
#2698

Hi, I think it's unnecessary to record every status to multiPlan.results even all opeartions are successful, which means multiPlan.getResults().put(i, RpcUtils.getStatus(TSStatusCode.SUCCESS_STATUS)); can be deleted.
What's your opinion?

Indeed, if all operations are successful, it is relatively friendly to delete the above codes, after this pr is merged, I'll merge these codes to #2698


Reorganize index.js to allow for a couple optimizations

remove _.template, replace with while loop for string-escape safety
handle default language by using empty catalog instead of explicit kickout
kick out of translating non-translatable extentions immediately in i18n/fast exports

:sparkles: No lint errors found. :sparkles:

Good work :+1: and give this thing a 0.0.2 tag.

:sparkles: No lint errors found. :sparkles:


feat: have a way to differentiate dev/prod config

Have a flag to load different .env configurations

closed by #39


[Editor] Animations stop playing when dropping a model with animations for the 2nd time

Description
When dropping an animated GLB into modelviewer.dev/editor, the animation plays in a loop. However, dropping that model for the 2nd time (or, as in my case, a new file with some fixes) seems to break animation playback with no way to recover (only page reload).
Live Demo
AR-Teapot.zip
Drop this into modelviewer.dev/editor, note anim plays
Drop it again, note anim does not play
Toggle "play animation" or "autoplay", anim does not play

Thanks, I have a repro. If your model has multiple animations, then selecting a different one fixes it.

Just wanted to report a bug and fortunately found my old bug about this 🗡
Still happens, no workaround when model only has a single animation. Only page refresh, then drop model again helps


Add button to call graph in MSAL Node silent sample

Adds a button to call MS graph with the token acquired silently.

We've adapted most of this into #1888 with some minor changes, thanks!


Routes custom

Hello,
I'm trying to use custom routes to mock an existing REST API :
{   "/api/public/drafts": "/api",   "/api/:draftId": "/api?draftId=:draftId" }
and the db.json
{   "api": {     "public": {       "drafts": [         {           "draftId": "aez112"        }     }   } }
but if I call the server with /api/12315, it return the object ...
How can I fix this issue ?
Regards
Gilles

This also does not work for me. :id  always works, but other property names do not, much like draftId from GillesBodart.


Best/recommended way to retrieve data from views in requery

Hi,
I'm currently using data.raw("select [columns] from [view] where [column] = ?", [args]) (where data is of type KotlinEntityDataStore<Persistable>)  to select data from views into tuples that I then use to populate data classes.
Suffice it to say that even small changes to the DB model results in considerable annoyance.
Maybe there is a better way to do this --I'm using SQLite and Kotlin for an Android app.
One view is the equivalent of (simplified):
CREATE VIEW union_view AS
  SELECT
    table1_code as code,
    0 AS type
  FROM table1
  UNION
  SELECT
    table2_code as code,
    1 AS type
  FROM table2

CREATE VIEW last_added AS
  SELECT *
  FROM table3 a
    JOIN (SELECT
            table1_id,
            max(date_column) AS max_date
          FROM table3 b
          GROUP BY table1_id) b ON a.table1_id = b.table1_id AND a.date_column = b.max_date;

from the following simplified tables
CREATE TABLE table1
(
    table1_code TEXT PRIMARY KEY NOT NULL,
    description TEXT
);

CREATE TABLE table2
(
    table2_code TEXT PRIMARY KEY NOT NULL,
    description TEXT
);

CREATE TABLE table3
(
    id INTEGER PRIMARY KEY NOT NULL,
    table1_code TEXT,
    date_column TEXT  -- actually contains a date
);

Would you like to be able define an entity and map it to a view (instead of a table) ?

Yes, that would be great.

Something like:
@View(name = "view_name")
interface MyView

maybe?

Wow, there is no moss growing on you! Phenomenal response.

Requery creates a table when the view does not yet exist in the DB. This results in an error when I'm creating the view.
e.g.
java.lang.RuntimeException: Unable to start activity ComponentInfo{ActivityName}: android.database.sqlite.SQLiteException: use DROP TABLE to delete table MyViewe  (code 1): , while compiling: DROP VIEW IF EXISTS MyView
It seems to work fine when the view is created first. I create the DB from code, so it causes issues for me.


Til Death evaluation incorrectly recalcs cb stuff when picking scores

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
Darkmans39#1440
Version Info
Latest available release
What operating system are you seeing the problem on?
Windows
Bug Behavior
In the evaluation screen, selecting a different score on the right side of the screen and changing your judgment causes the left/right cbs to update incorrectly, using the first score instead of the currently selected one.
The first score is the score you entered the evaluation screen with.
Expected Behavior
The left/right cbs should update using the currently selected score, not the score you entered the evaluation screen with.
Reproduction Steps

Enter the evaluation screen of a score
Select a different score on the right side of the screen
Change judgment

Anything else?
No response

fixed by #1249 and c8d84797ae0bc88c139b0d8493a19f19a4529bf8


UC Browser Mobile application_Broken Authentication & Session management

Open UC Browser Mobile application
Open Facebook or other site & login into the website
Access some Authenticated page
log out from the application
Click on back option
Previously accessed authenticated pages is accessible (with out login)

I don't think this has anything to do with HTML5test. Please report with UC Browser directly.


[explore] fix malformed string error

i get this error in explore v1 and v2 when using filters. if i remove the filter, it works as expected.

this is fixed now. can no longer repro.


Project Manager forgets all projects between runs.

Godot version:

3.1.alpha.calinou.af290f7
OS/device including version:

OS X Sierra 10.13.6
MacBook (Retina, 12-inch, 2017)
Issue description:

In the latest builds of 3.1, the project manager loads with an empty project list, even though I have previously scanned or manually added projects to it.
Steps to reproduce:

Run Godot.
Project manager opens with empty project list.
Scan a directory with Godot projects in it.
Projects appear in Project Manager
Load a project.
From the project, select, Quit To Project List
You are returned to the Project List, which is completely empty again.

Minimal reproduction project:

Issue is not project-dependent.

Duplicate of https://github.com/godotengine/godot/issues/21823


Client start error

Issue Description
I experience an issue when I start the client and the results I expected are startup of client
Reproduction Steps

Start King Phisher
Error below presented

Environment Details

Host OS: 4.17.0-kali1-amd64 #1 SMP Debian 4.17.8-1kali1 (2018-07-24) x86_64 GNU/Linux
King Phisher Version:1.11.0
Error Details / Stack Trace
~# /opt/king-phisher/KingPhisher
Traceback (most recent call last):
File "/opt/king-phisher/KingPhisher", line 48, in
from king_phisher.client import application
File "/opt/king-phisher/king_phisher/client/application.py", line 56, in
from king_phisher.client import dialogs
File "/opt/king-phisher/king_phisher/client/dialogs/init.py", line 35, in
from .clone_page import *
File "/opt/king-phisher/king_phisher/client/dialogs/clone_page.py", line 37, in
from king_phisher.client.widget import extras
File "/opt/king-phisher/king_phisher/client/widget/extras.py", line 46, in
import mdx_partial_gfm
File "/usr/local/lib/python3.6/dist-packages/mdx_partial_gfm/init.py", line 33, in
import gfm
File "/usr/local/lib/python3.6/dist-packages/gfm/init.py", line 15, in
from gfm import spaced_link
File "/usr/local/lib/python3.6/dist-packages/gfm/spaced_link.py", line 38, in
BRK = markdown.inlinepatterns.BRK
AttributeError: module 'markdown.inlinepatterns' has no attribute 'BRK'

This looks like a duplicate of #324 and has already been fixed in master and dev. Go ahead and update your version of King Phisher.
When you run ./KingPhisher --version it should say KingPhisher Version: 1.12.0-beta ....
There's instructions in the wiki on how to upgrade. 1.12.0 isn't out yet so follow the instructions for 1.11 and below.

Since this is a duplicate, I'm going to close this out. If you're still experiencing issues after updating just let us know.

Upgrade fixed the issue.  Thanks!!!!


[Do Not Merge] [BEAM-6138] Add the Sampled Byte Count counters to the Java SDK

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run JavaPortabilityApi PreCommit

Run Java PreCommit

@pabloem @lukecwik

Run Python_PVR_Flink PreCommit

Run Python_PVR_Flink PreCommit

These tests have at some point been broken in the last few hours. So it may be that they're failing for that reason.

Run Python_PVR_Flink PreCommit

Run JavaPortabilityApi PreCommit

Run JavaPortabilityApi PreCommit

it looks like javaportabilityapi may be broken

unfortunately, it runs without --scan.

Run JavaPortabilityApi PreCommit

Run JavaPortabilityApi PreCommit

@ajamato it may be that this test is actually broken : /


Provide actual math to the context

Feature request
I have className on root app element with page name:
<div className={`app page_${getPageName.call(this)}`}>

function getPageName () {
  return this.context.router.route.location.pathname.replace(/^\//, '').replace(/\//g, '-') || 'index';
}

But does not working correctly with parametrized routes (e.g. path mask /entry/:id gives className .page_entry-42 through the URL /entry/42)
props.match.path of route (Entry in my case) component contains original mask path what I want to use in the root element.
total example:
<BrowserRouter>
  <div className={`app page_${getPageName.call(this)}`}>
    <Route path="/entry/:id" component={Entry}/>

</BrowserRouter>

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux. Thanks!

It's not bug and not support request. It's feature request.
In Route's first child I can read match with all wanted information.
But context does not provide it for all childs.


Confusing and undocumented cpu* parameters

Moving to this repo as suggested in https://github.com/docker/compose/issues/5509
According to the doc, the following parameters were added in v2.2. The corresponding PR appears to be https://github.com/docker/compose/pull/4835
However, I couldn't find any explanation whatsoever of what these parameters do. Doc says:

analogous to its docker run counterpart

But, docker run doesn't have these parameters. Neither does this.
So I'm looking at cpu_count: 2 and wondering how in the world is it different from cpus: 2. What does the word cpu_count mean to anyone who speaks English? Two counts of cpu. Well, that's exactly what cpus is supposed to be.
Can we stop this guessing game and clearly document the parameters?

OS specific parameters look like a bad idea, because by that line of thinking, we may soon have 32-bit vs 64-bit, and AMD vs Intel parameters. As a user, I'd like to have Docker deal with the underlying idiosyncrasies, and not require me to read from a manual every time I have to work with Docker. We should be past this point.

@shin- can you point to which parameters should be used?

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


Issue/integrate remote executor

Description

integrate remote agent
make it use log-shipper
cleanup typing of agent config
include closing in the generic interface

closes https://github.com/inmanta/inmanta-core/issues/7524
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches master in 625bcb95d21921395d9fc3f3ca33cf71450bf343


Make AudioBuffer more compliant

There is some differences between Rust AudioBuffer API and Web audio specs AudioBuffer API. (see specs for more details)
Possible solution:

Replace current implementation with the following interface AudioBuffer::sample_rate(&self) -> f32
Rename sample_len() function as length()
Rename channel_data function as get_channel_data
Rename channel_data_mut function as get_channel_data_mut
Make from_channels function private and add a public copy_to_channel function
Add a public copy_from_channel function

There is this concept of "acquire the content" in the spec (see specs for more details). I think it could be emulate by using systematically move semantics with AudioBuffer. What do you think ?
If yes, it should be documented

buffer::ChannelData should be pub(crate), but is currently used in examples/bench.rs
would also allow to move buffer::AudioBuffer::from<DataChannel> to pub(crate) once done

Fixed with #67


Rework the profitability calculation/test

On each timestep (of the duration), the lead Sequencer tests:
1) The gas required for the L1 transaction (taken from DEFAULT_DETERMINISTIC_GAS_ESTIMATOR = L1GasEstimators )
2) The current gas price (taken from GAS_FEE_L1_TIME_SERIES_LIST )
3) Multiplies these costs with a safety buffer (currently 2) (need rework on functional form)
4) Computes their expected rewards (taken from expected_rewards = state['cumm_block_rewards'] - history[-1][0]['cumm_block_rewards'] )
5) From the rewards, subtracts a constant "op_cost" param, the fee, and the safety buffer (2fee)
6) aka Rewards (our assumption) - op_cost (our assumption) - 3*fee (multiplier our assumption, fee our choice of shock)
7) If the result is positive, they will be able to make the transaction

Tasks:

Rework functional form to be more realistic
Potentially rework op_cost to vary depending on agent

#160

@jackhack00 Is the constant gas assumption normal, or is there any variance in the gas?

@jackhack00
Should I be investigating validity for GAS_FEE_L1_TIME_SERIES_LIST or do we feel good on it

@jackhack00 What is the safety buffer meant to capture? And is there empirical data to support it?

@SeanMcOwen
Gas should be constant for DEFAULT_DETERMINISTIC_GAS_ESTIMATOR = L1GasEstimators
Gas Price (in Gwei) should fluctuate: Steady state gives basis, shock adds on top. Both SS and Shock are pulled from timeseries.
Checking validity of GAS_FEE_L1_TIME_SERIES_LIST
Yes please, that sounds great.

I have pulled a couple years of daily average values.
Might swap those out for block by block values for more realizm
GAS_FEE_L1_TIME_SERIES_LIST was tuned by hand, needs validation to fit with actual values
Want to also tune shock better, currently goes up by ~100, which brings total ~135 Gwei.
Past two years, max daily average was 474, so got some room to tune

Safety Buffer
Since rewards and costs are kinda unknown, we have to find reasonable guesses.

Reward: we can somewhat guesstimate.
Costs: Reflected through op_costs param. Meant to capture the fact that aside from gas fees, the rewards also need to keep the lights on. Idea was to get more insights into computational work / costs of operations, and plug that in.
Safety Buffer: Originally intended to capture part of what is now in op_costs. Agent needs some profit to come away with. Arbitrarily set at 2x gas costs at time when op_cost did not exist.
Empirical Evidence:
We do know that these operations cost money in most cases
We do not have data on real costs, real profit margins, etc.
We can either deviate from profitability test, due to too many unknowns, but then need a different conditional on why someone would not be willing to make an l1 transaction (re-focussing on the gas thresholds for example)
Or we define better op_costs and safety buffer, with reasonable estimates and knowledge that this needs iteration

An additional fix to this might include testing more realistic costs and rewards.
Currently, an agent tests total rewards for the block (instead of their share of the rewards) against costs of the current transaction.
Realistically, an agent would check their own reward share vs. the remaining transactions at current gas price (since a singular transaction is likely under the total block rewards)
gas: Gas = params["gas_estimators"].commitment_bond(state) #Note: checking against only the current transaction might be simplifying a little too much
fee = gas * state["gas_fee_l1"]
SAFETY_BUFFER = 2 * fee  # HACK:

expected_rewards = params["reward_per_block"] #NOTE: reward per block is total reward
expected_costs: float = params["op_costs"] + fee + SAFETY_BUFFER

# Translate to ETH
expected_costs = expected_costs * 1e-9
payoff_reveal = expected_rewards - expected_costs


Support for Postgres arrays.

Hey everyone, love the design of this library, it might be the reason I switch from FastAPI to rust. I ran into a problem with using current tables, I have a table with a column that is []uuid in postgres, the generator correctly generates the type:
Vec however when compiling I have the following error:
the trait From<Vec<sea_orm::prelude::Uuid>> is not implemented for sea_orm::Value
I'll dig a bit to figure if I can patch this on my own, but just in case I can't, I'll leave a record.
Also of note: when the column is nullable as well, a different error is thrown:
"the trait Nullable is not implemented for Vec<sea_orm::prelude::Uuid>"
But that's probably related.
Motivation
Supporting UUID arrays from Postgres is useful for tables containing aggregations.
Proposed Solutions
From<Vec<sea_orm::prelude::Uuid>> should be implemented for sea_orm::Value
Current Workarounds
Remove the column from the generated files, and use custom expressions when I do need to access it.

Never mind, reading the code, I saw I was missing a feature named "postgres-array" adding that fixed the issue, maybe should be documented somewhere.

Hey @ilyail3, in the coming releasing postgres-array will be enabled when postgres backend is turned on. That should ease the confusion.

https://github.com/SeaQL/sea-orm/pull/1565


NEXT-8436 - [storefront] Whitespaces are incorrectly trimmed out from Product Number in cart's add-by-number form

Description
When trying to add product to the checkout cart by its number (which has a whitespace in its value), all whitespaces are trimmed from input (/checkout/product/add-by-number action). This results in an error message that product number could not be found:

Possible Solution
Trim whitespaces only at the beginning and the end of the input
Additional context
Shopware version:  6.1.4

Hello,
thank you for creating this issue.
I have opened a ticket on our Issue Tracker for you. See the ticket link: https://issues.shopware.com/issues/NEXT-8436
Please use this ticket to track the state of your issue.

There is already a PR, but just the tests are missing: https://github.com/shopware/platform/pull/458

intrested

Interested

FYI: There has already been a fix for this which just lacked some tests :) https://github.com/shopware/platform/pull/458

@pantrtxp Could you please unassign me from this task. I'm working on another task.


OnTradeOfferReceived doesn't work

Hi there.
I was using SteamTradeOffersBot (which is based on this) from Joel (waylaidwanderer) and i noticed OnTradeOfferReceived doesn't react if there is a trade available from another user. As I saw OnTradeOfferReceived is trying to get called in CheckPendingTradeOffers, its going through some ifs, but it still doesn't call it.
Could somebody help me with that?

Wrong repo.
https://github.com/waylaidwanderer/SteamTradeOffersBot/

Thanks for the info.


azd up is slow because of azd init

I observed azd init taking 6 seconds to run when running azd up with no parameters. We should investigate why this is taking so long.

Hopefully with the current separation of azd init and azd up. We shouldn't be seeing this.


Change state.crosslinks to state.latest_crosslinks

Change state.crosslinks to state.latest_crosslinks to match the BeaconState definition.
I'm assuming this is a typo and is non-contentious.

Oh I just found a few more instances. I'll fix these and push them up. Should take a few minutes.

Ok, ready now.


added confirmation mail sent page

Related Issue or bug
-added confirmation mail sent page
Fixes: #324 ]
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
A clear and concise description of it.
Checklist:

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots

Original
Updated

original screenshot
updated screenshot

@coding-geek21 When clicking on the activation link through Gmail does it redirect to the login page or we have to manually go to the login page to get into the account?

@coding-geek21 When clicking on the activation link through Gmail does it redirect to the login page or we have to manually go to the login page to get into the account?

it automatically redirects to the login page

@coding-geek21 When clicking on the activation link through Gmail does it redirect to the login page or we have to manually go to the login page to get into the account?

It automatically redirect to the login page @swapnilsparsh

Add an option if the user wants to redirect to Gmail then it can happen through the same page.

Made changes @swapnilsparsh


Update HL courseManagement because of new API

The file HyperledgerCourseManagement.ts was mistakenly pushed to dev with an old API version, s.t. error were thrown during compilation. This PR fixes it.
No need to update the changelog or version.

indeed :)


[FLINK-30491][hive] Hive table partition supports deserializing later during runtime

What is the purpose of the change
Hive table partition supports deserializing later during runtime, the JobManager needs to deserialize it for the enumerator, but the partition info isn't required for TaskManager, so we don't need to deserialize it, so we can reduce the cost of the task initializing phase.
Brief change log

Hive table partition supports deserializing later during runtime

Verifying this change
This change is already covered by existing hive tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: ( no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

cc @luoyuxia

@luoyuxia Thanks for review, I have addressed your comments.

@godfreyhe Thanks for reviewing, I've address the comments.


Updates readme to point to latest @apollo client npm package

Description
Readme update to point toward the latest @apollo client package
Performance impact
None
Security impact
Unknown

Does this work with that version?

So far so good on my end! FWIW, I was unable to get persisted operations working w/ apollo-link-persisted-queries and Apollo client v3.4.x, which led me to this change.

I'm glad you asked though! I found a working package, but not the correct package.
https://github.com/apollographql/apollo-link-persisted-queries has a deprecation notice at the top of the readme pointing to these updated docs. The correct import now appears to be import { createPersistedQueryLink } from "@apollo/client/link/persisted-queries"; - I'll update the MR!


Doesn't work in case of type reference instead of inner struct

At the moment when you use some custom type you have to enclose it within the struct e.g.
type BirthDay  struct {
time.Time
}
but it's better in this case to use just type reference:
type BirthDay  time.Time
Same for string based types like
ABCFlag string
I would like to have custom unmarshallers for such type references.
Any plans to add it?? Thanks.

Hello there! The library already supports custom unmarshalling on type aliases!
Unit test
// ABCCustom accepts ABC strings, any other value will be ignored
// and the value will be set to an empty string.
type ABCCustom string

var _ Unmarshaler = (*ABCCustom)(nil)

func (ac *ABCCustom) Unmarshal(data []byte) error {
	if string(data) == "ABC" {
		*ac = ABCCustom(data)
	}

	return nil
}


fix(youtube): unthemed text and icons

🔧 What does this fix? 🔧
as said in the title

also this is probably going to be my last PR before i stop contributing lol
🗒 Checklist 🗒

[X] I have read and followed Catppuccin's contributing guidelines.
[X] I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

btw @uncenter, can i contact you on discord?
(its not going to end like last time)

About what?

About what?

the pronouns.cc PR

About what?

the pronouns.cc PR

What about it can't be discussed on the PR itself?

What about it can't be discussed on the PR itself?
i mean i was just going to ask what should we do about the placeholder situation

There is literally a thread for that exact topic. As I said in that thread, I will look more closely when I have a chance to review.


Remove NamedEntityRecognition parameter

NamedEntityRecognition (NER) has been deprecated in favor of improved Smart Formatting, so it no longer makes sense to get/set this parameter.
(Note that as of June 2023, NER is still bundled within Smart Formatting for Basic and Enhanced tiers.)

We've only just added it back in to the node sdk, for compatability reasons. Some customers are still using it, and we should add a deprecated notice way before we remove it. Can I suggest we update your PR to add in the deprecation notice instead?

rolled into #84


W-12521538-changeReqToRespHTTPcomponent-duke

The description of HTTP component seemed to call the request to the HTTP listener a response.
Writer's Quality Checklist
Before merging your PR, did you:

[ ] Run spell checker
[ ] Run link checker to check for broken xrefs
[ ] Check for orphan files
[ ] Perform a local build and do a final visual check of your content, including checking for:

Broken images
Dead links
Correct rendering of partials if they are used in your content
Formatting issues, such as:

Misnumbered ordered lists (steps) or incorrectly nested unordered lists
Messed up tables
Proper indentation
Correct header levels

[ ] Receive final review and signoff from:

Technical SME
Product Manager
Editor or peer reviewer
Reporter, if this content is in response to a reported issue (internal or external feedback)

[ ] If applicable, verify that the software actually got released

Hey @IvanAndresFritzler Can someone on the team check this one before the 14th?


How can I retrieve the user who executed an action inside that action?

So I have an action with runner_type: ‘python-script’.
from st2actions.runners.pythonrunner import Action

class DeleteVm(Action):
    def run(self, name):

    # Get the username of the user who executed this action
    # ....what code here?

I don't believe this is possible, if you look at #2912 you can see some ways of dealing with not being able to access the actions context in an action as part of requesting this feature.

In this case I don't want to add a parameter to use {{action_context.user}}, because that can be overridden. So it would be very nice if I can retrieve the actual user who executed the action.

You could possibility mark it as immutable to prevent anyone changing it. I may have talked to @Kami or @emedvedev about this on Slack before raising the issue for the feature request, but it was last year.

I'm not aware that StackStorm parameter could be marked immutable, but that would also be sufficient indeed.

Cool, that seems possible https://docs.stackstorm.com/actions.html, immutable: true. I'm going to try it out.

Yes, this works very nice. Thanks!
---
name: 'delete_vm'
runner_type: 'python-script'
description: "Deletes a VM in VMWare vSphere."
enabled: true
entry_point: "delete_vm.py"
parameters:
  name:
    description: VM name
    required: true
    position: 0
  initiator:
    description: The user who executed this action
    required: true
    immutable: true
    default: '{{ action_context.user }}'

It also works when this action is used in a workflow:
---
chain:
  - name: 'delete_vm'
    ref: 'crv_vm.delete_vm'
    parameters:
      name: "{{ hostname }}"

That's what we do internally for this purpose as well. Glad it's working for you!
Closing the issue.


Unzip issue

TASK [amritsingh.ec2_monitor : Unarchive zip] **********************************
Thursday 16 February 2017  14:14:54 +1300 (0:00:00.927)       0:00:41.288 *****
fatal: [grability]: FAILED! => {"changed": true, "cmd": ["unzip", "/opt/CloudWatchMonitoringScripts-1.2.1.zip"], "delta": "0:00:00.003543", "end": "2017-02-16 00:58:57.372765", "failed": true, "rc": 1, "start": "2017-02-16 00:58:57.369222", "stderr": "replace aws-scripts-mon/awscreds.template? [y]es, [n]o, [A]ll, [N]one, [r]ename:  NULL\n(EOF or read error, treating as \"[N]one\" ...)", "stdout": "Archive:  /opt/CloudWatchMonitoringScripts-1.2.1.zip", "stdout_lines": ["Archive:  /opt/CloudWatchMonitoringScripts-1.2.1.zip"], "warnings": ["Consider using unarchive module rather than running unzip"]}

ansible <IP_ADDRESS>

Are you using ubuntu?

I have fixed this issue. Please update the role from ansible-galaxy.

Using unarchive now


How will archived rules work on github?

Hi @SebastienBoissiere @christianmorfordwaitessw
We have several "archived" rules (content that is outdated or irrelevant, but @adamcogan doesn't want to delete them)
E.g.: https://rules.ssw.com.au/mention-when-you-make-a-pull-request-or-comment-on-github
We need to find a way to also show these + a way to set/unset rules as archived or not (including reason).
Currently, we do it in the SSW ribbon tab:

AB#58627

Cc: @adamcogan
Hi @tiagov8,

We need to find a way to also show these + a way to set/unset rules as archived or not (including reason).

Done - See https://www.ssw.com.au/rules/do-you-know-to-mention-someone-with-a-mention-when-you-make-a-pull-request-or-comment-on-github
When an achivedReason is added to the frontmatter of the rule it is then archived.
To unarchive the rule, blank the archivedReason field.

Figure: When an archivedReason has been added to the frontmatter, the rule is then archived

Figure: This is how an Archived rule is shown

Figure: Link to the archived rules page

Figure: Archived rules page - https://www.ssw.com.au/rules/archived/

Cc: @adamcogan
Hi @tiagov8,

We need to find a way to also show these + a way to set/unset rules as archived or not (including reason).

Done - See https://www.ssw.com.au/rules/do-you-know-to-mention-someone-with-a-mention-when-you-make-a-pull-request-or-comment-on-github
When an achivedReason is added to the frontmatter of the rule it is then archived.
To unarchive the rule, blank the archivedReason field.

Figure: When an archivedReason has been added to the frontmatter, the rule is then archived

Figure: This is how an Archived rule is shown

Figure: Link to the archived rules page

Figure: Archived rules page - https://www.ssw.com.au/rules/archived/


DRAFT - [ENH] Naive C removal

Draft PR which attempts a naive removal of C sources, to test a GitHub actions CI/CD without C sources. FYI @lmmentel.
FYI @TonyBagnall, @chrisholder, @MatthewMiddlehurst, since you're also working on this.
What I did is very hacky, kill MrSEQL and replace distances imports by those that sound like they should work.
Where feature parity wasn't there with twe_distance, I've imported another distance under its name as a placeholder.
Note: MrSEQL is scattered throughout the notebooks, I did not touch those (except removing the one called MrSEQL).

@lmmentel, this is failing on linting and input format expectation for distances, but it no longer uses C, and the issues are localized to individual classifiers.
Using xfail on a small number failures, this should allow to test the GitHub actions workflow on windows.
The assumption would be that @tonybagnall & TSC team will change the failing classes until before the 0.10.0 release.

do you want to close this PR? The work is ongoing and wont be on this branch.

I know, @TonyBagnall - I do not intend the "proper" work to be here. This is just a hacky patch to allow conditional development, with the intent to switch this to the "real" thing once done.

The original issue we discussed in solved so I don't believe we need this anymore. If the work to remove C is ongoing somewhere else maybe we can clean this up.


Show download icon in place of lens icon when paper fulltext isn't downloaded

Addresses #25 and fixes so that download icon is shown instead.

Beautiful work, thanks @40thieves! Love that it updates in-place when the download finishes :)
Screenshot:

We are flying today!

wow this is looking great!


This video suggests there might be a bug in implementation due to coverage dropping for ICP

https://www.youtube.com/watch?v=k6k_bUYyUNg&ab_channel=MLBoost

Thank you for sharing the video link which suggests a bug in the coverage validity. I have initiated a new issue that explains the reason for the bug as well as additional material that allows users to reproduce the bug.


No Content Shown After Putting in the code for IterationTrackingBoard

Hi All,
I just started working on Rally Apps, and found this repository with almost all the things I will need for the apps I want to develop/customize.
I took in the code for iterationtrackingboard and ran it using rally-app-builder.
at first it threw some errors saying some files were not found,
which i corrected later on by removing Rally.apps from namespaces in require properties.
once all the file not found errors were gone i thought it will start showing the iteration tracking board.
but instead it just shows a blank page and no errors.
Any idea why?
Can you help me with the steps to perform do set it up properly?

I have been able to get the output, but could not get the iteration banner.
found out that the iteration banner has not been made available.
On Tue, Jul 10, 2018 at 3:24 AM, Gaurav9106<EMAIL_ADDRESS>wrote:

Facing similar issue , post running script nothing is displayed.. Any
suggestions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RallyApps/app-catalog/issues/17#issuecomment-403726847,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG8vedX7XtRV3RpoeV4CAs-ry0a1firmks5uFFaugaJpZM4TNgRj
.


Update send_message.js

I was randomly using this package , it worked just fine on catalina, but i got a new machine and tried too use my script again on sonoma, It presented a bug where it worked but it input the number and message into the number input. This was my fix for it! Hope it helps someone out there...

@kadolis Thank you so much. I'll go ahead and merge.


feat: Allow users to specify a metric display name prefix

Allow users to specify a metric display name prefix, separately from the metric name prefix

this is the implementation for https://github.com/census-instrumentation/opencensus-java/issues/2040

Thanks @OmerLitov, could you please trigger the build again, looks like one of the tests failed due to connectivity issue with Maven Central.
e.g.
git commit --amend --no-edit
git push origin --force

Codecov Report

Merging #2050 into master will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #2050      +/-   ##
============================================
- Coverage     83.06%   83.06%   -0.01%
  Complexity     2251     2251
============================================
  Files           319      319
  Lines         10529    10532       +3
  Branches       1048     1049       +1
============================================
+ Hits           8746     8748       +2
  Misses         1446     1446
- Partials        337      338       +1

Impacted Files
Coverage Δ
Complexity Δ

...ats/stackdriver/StackdriverStatsConfiguration.java
100.00% <ø> (ø)
3.00 <0.00> (ø)

...ts/stackdriver/CreateMetricDescriptorExporter.java
75.32% <66.66%> (-0.68%)
12.00 <0.00> (ø)

...er/stats/stackdriver/StackdriverStatsExporter.java
70.73% <100.00%> (+0.36%)
11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be7044...523c845. Read the comment docs.


helper for multiplying font-sizes with units

Feature Request: (want to contribute)
i am converting my sass codebase to styled components and i use these sass helpers to multiply pixel font sizes

round($number) Rounds a number to the nearest whole number.
ceil($number) Rounds a number up to the next whole number.
floor($number) Rounds a number down to the previous whole number.

currently to achieve this, i did
import { stripUnit } from 'polished';

const fontSizeBase = '14px';
const fontSizeLarge = `${Math.ceil(stripUnit(fontSizeBase) * 1.25))}px`;

a generic helper can be something like this
// polished helpers
const multiplyFontSize = (multiplier, fontSize) => {
  const value = stripUnit(fontSize);
  const unit = fontSize.split(value)[1];

  return `${value * multiplier}${unit}`;
};

const roundFontSize = (criteria, fontSize) => {
  const value = stripUnit(fontSize);
  const unit = fontSize.split(value)[1];

  return `${Math[criteria](value)}${unit}`;
};

// helper usage
import { roundFontSize, multiplyFontSize  } from 'polished';

const fontSizeBase = '14px';
const fontSizeLarge = roundFontSize('ceil', multiplyFontSize(1.25, fontSizeBase));

any thoughts on this?

@bhough any decision or future course of action. I am new to OSS can you guide me?

@sagiavinash sorry for the delayed response. So it seems like the helper that would be useful is a general one that allows us to do math with CSS values generally as you've described for the specific font use case. Other issues like #234 are also trying to get at this problem.
So I think a good first step would be to talk through a proposed api for a more general set of helpers for doing math on CSS units. It may take a few attempts as I think I have a firm grasp on the problem, but less firm idea of how we should solve it.

Is there no progress with this? I recently switched from SCSS where this was core functionality and fundamental to achieving theming, styling consistency and DRY code throughout a web app. I was very surprised to see Polished doesn't already do this.
As a temporary measure, I've implemented a calculate.js util in my project to multiply and divide values with units, but this is far from ideal because I have to import this into so many files where I already have polished.
// @flow

export const stripUnit = (value: string): ?number => {
  const match = /[0-9]+\.?[0-9]*/.exec(value);
  return match ? Number(match[0]) : match;
};

export const getUnit = (value: string): string => {
  const match = /[a-z]+|%/i.exec(value);
  return match ? match[0] : '';
};

export const multiply = (multiple: number, value: string): ?string => {
  const number = stripUnit(value) || 0;
  const unit = getUnit(value) || '';
  return `${number * multiple}${unit}`;
};

export const divide = (denominator: number, value: string): ?string => {
  const number = stripUnit(value) || 0;
  const unit = getUnit(value) || '';
  return `${number / denominator}${unit}`;
};

Usage looks like:
import { multiply } from '../util/calculate';

export default styled.div`
  font-size: ${({ theme }) => multiply(2, theme.fontSize)}
`;

@caribou-code There has not. We've had other modules that have garnered more traction that we are about to release in 2.0 We look to upvotes on the module request issues as an indicator of interest, and this has not garnered much. Especially as support for calc has gotten better.
That being said we are always open to PRs and seems like you've done some of the work towards a helper, and we'd be glad to look at it if you submitted something.
I'm not sure I understand some of your comments about it being an impact on DRY code or your concern about the extra imports. Is there a fundamental difference between importing your helper or ours? If you are importing all of polished into your modules you may be bringing more code on then you need. Otherwise, if you are just importing parts of it into the module, there isn't much difference between importing them from polished, or your own module. You could actually cut some duplicate code out though by using our stripUnit helper (and soon one for getting units as well) into your calculation helper.
re:DRY while I see some value in these helpers with this, a DRYer version would be to do the math once in your theme file and setup different variables for commonly used sizes and use those, instead of calculating it in the styling like in your example.
I'm open to more discussion, but I'm not sold yet that the specific problems you've laid out for this not being included are greatly solved by this one helper. In general we aren't always looking to cover every single use case, but in those cases provide building blocks to create your own that suite your needs.

@bhough It looks like someone already did a PR a while ago but it didn't get further: #227
To clarify what I meant by DRY, I'm talking about an alternative technique that allows JS to do the maths by storing theme variables as numbers without units. But with this method you have to then apply the unit on every usage, which is not DRY and can cause trouble down the line.
With that in mind, I can only see 2 good ways to do calculations. Either using CSS calc, or doing this in the JS. My problem with using CSS calc is the calculations can get fairly complicated and long, which feels a little weird creating these calculations in a string. I also wonder about performance implications if there are many of these in a component.
As for pre-calculating the maths in theme files, I don't feel this is flexible enough for large scale apps.

i consider it an elementary feature as well. i've taken the code from my PR and implemented it in our internal tooling library. if there is interest to get this merged in polished, i can reopen the PR?

Perhaps worth noting another experience I've had today. I needed to use pythagoras theorem to calculate part of a CSS layout. When using CSS calc you can only use basic operators (+, -, *, /) which means square root is not possible. When working with a number with a unit, this means Polished has no way to handle this, and I can't use CSS calc. Leaves me a bit stuck if I want to write DRY and scalable code, unless I implement my own method for handling this.

Added to V3 Roadmap (#354).

@bhough i've reopened my PR ( https://github.com/styled-components/polished/pull/277 ) and will update it either today or over the weekend )


LibWeb: Fix table overflow issues

Fix several table-related overflow issues.
Changes

Include vertical border spacing in row groups offset calculation so that it's axis-aligned with child row/cell elements:

This makes it so there isn't horizontal and vertical overflow caused by child row/cell elements.

Include horizontal border spacing in tr width calculations:

This makes it so tr elements don't have overflow anymore when there are multiple columns.

Apply vertical caption offset to row group top offset:

Don't double-count top padding when calculating vertical offset:

Fixes https://github.com/LadybirdBrowser/ladybird/issues/1525
Failing tests

[x] css-pseudo-element-should-not-be-affected-by-presentational-hints.html
[x] zero_percent_width_nested_table.html
[x] table-fixup-with-rowspan.html
[x] table/basic.html
[x] table/width-distribution-and-constrained-columns-size-on-col.html
[x] table/row-outer-size-with-computed-size.html
[x] table/border-attribute.html
[x] table/inline-table-width.html
[x] table/cell-with-max-width.html
[x] table/propagate-style-update-to-wrapper.html
[x] table/borders.html
[x] table/width-distribution-and-constrained-columns-increased-size-on-col.html
[x] table/width-distribution-and-constrained-columns.html
[x] table/table-width.html
[x] table/border-spacing-with-percentage-width.html
[x] table/stretch-to-fixed-height.html
[x] table/multi-line-cell.html
[x] table/columns-width-distribution-1.html
[x] table/border-spacing-and-borders-table-width.html
[x] table/style-invalidation-propagation-to-table-wrapper.html
[x] table/border-spacing-colspan.html
[x] table/bottom-caption.html
[x] table/internal-alignment.html
[x] table/table-cellpadding.html
[ ] table/nested-table-box-width.html

[ ] table/colgroup-with-two-cols.html
[ ] table/percentage-width-for-nested-table-is-like-auto.html
[ ] table/long-caption-increases-width.html
[ ] table/rowspan.html
[ ] table/border-attribute-overridden-by-css.html
[ ] table/top-caption-with-padding.html
[ ] table/nested-table-alignment.html
[ ] table/table-align-center-with-margin.html
[ ] table/tr-valign.html
[ ] table/avoid-div-by-zero-in-table-measures.html
[ ] table/cell-relative-to-specified-table-width.html
[ ] table/td-valign.html
[ ] table/cell-auto-max-width-table-percentage-width.html
[ ] table/row-span-and-nested-tables.html
[ ] table/border-spacing.html
[ ] table/table-max-content-width.html
[ ] table/border-spacing-rowspan.html
[ ] table/table-align-center.html
[ ] table/abspos-pseudo-element-inside-table.html
[ ] table/keyword-value-does-not-constrain-column.html
[ ] table/sum-of-percentage-column-widths-less-than-100.html
[ ] blockify-layout-internal-box-without-crashing.html
[ ] grid/floating-table-wrapper-width.html

@AtkinsSJ I'm going through and modifying the failing tests. Before I get too far, I was wondering if you could take a look at the changes

The results are a big improvement and the code looks fine to me (though I'm not a layout person :sweat_smile: ) but of course a lot of tests still need rebaselining. You should be able to mass-update them with ./Meta/ladybird.sh run headless-browser --run-tests "./Tests/LibWeb" --rebaseline.

I just noticed that you've described in each of the LibWeb: Fix test commits how the test was modified. You don't need to do that. :sweat_smile: Please just squash all the test-fixes into the commit that makes the change, so that all tests pass before and after that commit. Basically, I think this should all be one commit.

Yeah, I am planning on squashing them into a single commit - I just wanted to keep a running log where I verify and gut-check for myself that the test is legitimately failing or erroneously failing.
Just so I understand though - there will probably still be some tests that are legitimately failing (e.g. table/nested-table-box-width.html). Not because of this change, but because they are incorrect (?) tests. Are you saying I should change them to make them pass anyway just to get all the tests to pass?

Just so I understand though - there will probably still be some tests that are legitimately failing (e.g. table/nested-table-box-width.html) in the end (not because of this change, but because they are incorrect (?) tests). Are you saying I should change them to make them pass anyway just to get all the tests to pass?

All tests should pass always. If a test starts failing because its expectation is wrong, rebaseline it. If it starts failing otherwise, then that's a bug that should be fixed. I don't quite understand what you mean about a test being incorrect. :sweat_smile:

Sounds good 👍

If a test['s]... expectation is wrong

That's what I meant by a test being incorrect.

I haven't checked but I believe this will also fix #1510.

Yeah, specifically point number 2 in the list should fix that.

Ok ready for review!

Thanks for checking! All the cases you mentioned the overflow is either legitimate or there's a bug (in the case of the colspan example).

Great! Thanks for the explanations. :^)

Actually, I was totally wrong with those rowspan examples! The TD elements actually shouldn't produce overflow on the TR elements since TR isn't the containing block for them (the table is).
https://github.com/LadybirdBrowser/ladybird/pull/1268 should fix those.


About using prebuilt .aar from the samples

Given an aar, say, framework-debug.aar, this is what it takes to modify a sample to use it:

copy the .aar to ./app/libs/
remove the references to "framework" from settings.gradle
modify ./app/build.gradle like this:

apply plugin: 'com.android.application'

allprojects {
   repositories {
      jcenter()
      flatDir {
        dirs 'libs'
      }
   }
}

android {
   ...
}

dependencies {
    compile(name:'framework-debug', ext:'aar')
}

--

verified that ./gradlew assemble works
verified that importing the sample in AS and building works

@NolaDonato I believe this does what you've asked for.

You could also share the .aar across all the samples. For example it could be copied to the root of the Demos repo. Then the dirs in ./app/build.gradle should be changed to ../../.

Using the prebuilt .aar will greatly speed up the automated build for the demos which currently takes about 8 hours.. Mostly because of building the framework again and again. @NolaDonato I am all for the switch to a prebuilt aar for the demos.

I will start modifying the samples as soon as you merge. I will test first myself with a few and then I will enlist helpers so we can get this done soon.

./app/build.gradle should be more like this:

your comment said, "should be more like this:", but then nothing afterwards.

:smile: ... fixed it ... hit enter too soon.

Well, we need some generic name otherwise we will have to modify the samples after each release. There might be a way to just pick all the .aar's from a certain directory.

Also you might need to correct the android studio instructions on the releases page:
libvrapi.so needs to go into
app/src/main/jniLibs/armeabi-v7a/

Not finding a way to pick .aar-s by using a wildcard. Seems to be intentionally not supported. .jar-s work but .aar-s are rejected. Settle on a name without version numbers if you ask me. We might have the build produce generically named artifacts too..

Regarding extension libraries: if we have the 3DCursorLibrary refer to the framework's aar then the framework classes and resources are not included in the 3DCursorLibrary's aar.

Also the automated build will have to produce the .aars for the 3dcursor and the widgetplugin extensions.

The demos use the prebuilt aar now. Will track additional work in new tickets.


How to use it in C++?

How to use it in C++?

Just like using any other plugin:
put it into your plugins folder,
enable it by editing the .uproject file.

I  mean   apis，not   put it into  plugins folder。

I also want to use in c++, there seems to be no API doc...


[Task]: Cleanup DirtiesContext annotation in pg branch

SubTasks

clean up

As we are using dirtiesContext in pg as well, closing this ticket


Fix bug when a token is given public only

I was unable to create a backport for 1.22. @lunny, please send one manually. :tea:
go run ./contrib/backport 32204
...  // fix git conflicts if any
go run ./contrib/backport --continue


Get opentelemetry trace id from request headers instead of creating a new trace

Feature request
Currently a new trace is created per each HTTP request. It would be useful if trace is get (if available) from the request using traceparent header as defined in https://opentelemetry.io/docs/specs/otel/context/api-propagators/#propagators-distribution https://www.w3.org/TR/trace-context/
In this way you will be able to trace the request through microservice invocations.
Motivation
I want to track the request using opentelemetry starting from frontend, backend and then TEI
Your contribution
I don't have enough understanding of TEI code

Created similar issue for TGI here: https://github.com/huggingface/text-generation-inference/issues/2376

Hello,
I tested this PR and I can confirm that it works in my case - opentelemetry trace is propagated from request to TGI.
Thanks @kozistr !


[Bug]: Remove io.ballerina.runtime.internal imports from io.ballerina.runtime.api package.

Description
This will provide restricted java classes to outside.
Steps to Reproduce
No response
Affected Version(s)
No response
OS, DB, other environment details and versions
No response
Related area
-> Runtime
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

We need to replace those with proper io.ballerina.runtime.api classes.


IntelliJ link is broken 404

IntelliJ link is broken 404 under:
https://docs.microsoft.com/en-us/azure/devops/user-guide/devops-alm-overview?view=azure-devops#git
The link it points to is:
https://docs.microsoft.com/java/download-intellij-plug-in.md
I believe the correct link should be:
https://plugins.jetbrains.com/plugin/7981-visual-studio-team-services

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f412c4c-d759-6260-e59b-80923d6372df
Version Independent ID: 94be3497-80cf-25ee-1741-bd9f49ca560e
Content: DevOps tools overview for Azure DevOps - Azure DevOps
Content Source: docs/user-guide/devops-alm-overview.md
Product: devops
GitHub Login: @steved0x
Microsoft Alias: kaelli

Thanks for the heads up, @daniel-farina! I've updated the link, which should be live by tomorrow morning. Thanks again!


Surfaces are too dark

Left: v0.0.5 / Right: v2+

@sritchie I dunno if this is a consequence of changes we've made in Mathbox, or a consequence of the ThreeJS upgrades. Do you have any idea? I think you've looked at more versions of ThreeJS than I have. Otherwise... I'll try to learn something about ThreeJS :)

Interesting, I only remember the second one through all my testing. I will look!

It looks like it was dark at 98c37401f337cc61460e9b9d9e6f32bf0fdf78b7, my first big merge (check out and run npm install && gulp build). So I must have introduced some problem during the migration from Coffeescript...

If it helps to debug, it also happens in:
file:///Users/sritchie/code/js/mathbox/examples/test/vertexcolor.html
file:///Users/sritchie/code/js/mathbox/examples/test/transition.html
file:///Users/sritchie/code/js/mathbox/examples/test/surface.html
file:///Users/sritchie/code/js/mathbox/examples/test/subdivide.html
file:///Users/sritchie/code/js/mathbox/examples/test/repeat.html
file:///Users/sritchie/code/js/mathbox/examples/math/procedural.html
file:///Users/sritchie/code/js/mathbox/examples/math/hopf.html
file:///Users/sritchie/code/js/mathbox/examples/demo/shapes.html
file:///Users/sritchie/code/js/mathbox/examples/demo/cylindrical-stream.html
It does NOT seem to happen in
file:///Users/sritchie/code/js/mathbox/examples/test/fragmentcolor.html
file:///Users/sritchie/code/js/mathbox/examples/demo/cylindrical.html
which seemed surprising.

Left: Steven's original at eaeb8e15ef2d0252740a74505a12d7a1051a61b6 using ThreeJS v71
Middle: Znah https://github.com/znah/mathbox/commit/593bdab1d4a482fe7d496e72ff1ccec691c597ff using ThreeJS v84
Right: This current repo, with ThreeJS v137

Whatever happened, I'm fairly certain it is not related to Shadergraph. I dropped an old version of Shadergraph into the current repo and stuff was still dark. I also plugged in an old v0.05 version of shaders.js (recall it used to get built to build/shaders.js) and things were still dark.
Znah's is not as dark as modern, but it does have dark lines. Steven's original looks best :/ Hope we can get back to that.

@ChristopherChudzicki I agree. here are some clues:

change "shaded" to false on current master and you'll get the nice luminous colors again, BUT with dark lines and no shading:

On 0.0.5, setting lineX or lineY to true vs false has no effect. the lines are missing in both cases. THAT feels like a bug to me in 0.0.5.

So that makes me suspect something in https://github.com/unconed/mathbox/blob/0.0.5/src/render/meshes/base.coffee#L120-L186... but they really read the same.

On 0.0.5, setting lineX or lineY to true vs false has no effect. the lines are missing in both cases. THAT feels like a bug to me in 0.0.5

I'm pretty sure this does have an effect in 0.0.5, although the effect is not visible unless you're using a shaded surface. If not using shaded surface, the gridlines and surface are exact same color and you can't differentiate between the two.  (I don't understand why the gridlines turned black, but changing the x/y/z in this code to r/g/b fixes the lineX lineY issue https://github.com/unconed/mathbox/blob/4fd08d6cfdd41446685b53190be833055c10086f/src/primitives/types/draw/surface.js#L278-L288, making them a slightly darker shade of the surface color, which seems to be the original intent).
As for the why the shaded surface itself is darker... I spent a while investiating that this weekend. I still do not fully understand. The shading is done by the two GLSL shader snippts surface.position.normal and mesh.fragment.shaded. . I'm a GLSL noob, but my understanding is that the "inputs" to these shader snippets are the "uniforms", and the current master shaders vs 0.0.5 appear to be getting the same inputs.
As best I can tell, there's an issue with gl_FrontFacing, though I really don't understand why it was working in ThreeJS r71 but not ThreeJS r137. Sigh. See #26 for more.
I'll open a PR for the lineX, lineY thing soon, and hopefully get back to the mathbox-react bug you opened. (Thanks for opening that!)

Fixed by #27.


Creates flag in K2 for adding and removing nodepools

EDITED TO ADD: This addresses #576 and forces the user to explicitly pass any nodepools they wish to add or remove to the update action.
ToReview (and this should probably be passed into CI job if I’m not mistaken):
Bring up a cluster.
Run ./update.sh in the following ways and check for appropriate message/behavior:
no arguments
--addnodepools master
--rmnodepools master
--addnodepools <nodepool that already exists>
--rmnodepools <bogus nodepool that doesn’t exist>
--rmnodepools <nodepool that exists>, but don’t remove from config file
Remove a nodepool from config file but don’t pass it to --rmnodepool flag (give it a nodepool that doesn’t exist to satisfy the command line field)
--addnodepools <new nodepool> but don’t add it in config file
Add a nodepool to your config but don’t specify in --addnodepools flag (give it a nodepool that already exists, just to satisfy the flag field)
All of the above should fail and do nothing to your cluster.
To actually affect your cluster, run ./update.sh in these 2 ways:
Add a new nodepool to your config file and then run --addnodepools <new nodepool>.
Remove a nodepool from your config file and then run --rmnodepools <removed nodepool>.
You should always have to specify which nodepool you are adding or removing.
You should also be able to pass multiple flags and add or remove multiple node pools.
One thing this doesn’t address is the fact that one can still change the configurations of a nodepool (like counts of nodes) in the config file, and K2 will still quietly do it.

@joejulian since @guineveresaenger is on holiday for three weeks, if any changes are needed here I will do them.  just ping me.

LGTM after the remaining code is removed.