Enhanced error reporting and a fix for #35

Based on this thread: https://forum.uavcan.org/t/nestedrootnamespaceerror-in-basic-usage-demo/794
Fixes #35
Updated the development dependencies.
No review needed.

Pull Request Test Coverage Report for Build 313

7 of 7 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 308:
0.0%

Covered Lines:
2965

Relevant Lines:
2965

💛  - Coveralls


Expose shouldNotify

Please expose shouldNotify function to have the condition to insert the error handler as the event hook affects the performance.
if (!Bugsnag.shouldNotify())
  server.on("uncaughtException", bugsnag.restifyHandler);

Thanks @dtaniwaki!


DOC: Document how checksum is made

Solve fundamental part of #487, however much more discussion to be had on this topic.

While inserting this text, I notice that the documentation is in dire need of updates. Lots of outdated text, and manual documentation of data model is still present. Not solving any of that in this PR, but should go on some ToDo-list.


Support em and strong as well as i and b

The documentation suggests that <i> and <b> tags are allowed. Instead, shouldn't we prefer the usage of <em> and <strong>? Or if there's some reason that i and b need to be supported, it would be good to document that em and strong are allowed, with an equivalent semantic interpretation.

i and b are valid elements in the current HTML Recommendation/standard (HTML5), with documented meanings that are appropriate to use in RASH. They are not deprecated in any way in current HTML (HTML5), or considered bad practice. But I think it would be ok to document that people can use  em and strong instead if they prefer to use them.

Thanks, Mike, I definitely didn't or shouldn't have implied that i and b are deprecated. (I think since the documentation describes them as different levels of general emphasis that there are reasons to prefer em and strong, but I'd happily change my request to support them as equivalent.)

Yeah I don’t think any docs anywhere should say that there absolute reasons to prefer use of i and b over em and strong (since all are legitimately part of the HTML language, with meanings/uses well-defined in the HTML spec).

The new version of RASH, we decided to keep only "i" and "b". The idea is that we would like to avoid two elements for expressing the same semantics.


New MSTest runner doesn' t integrate with coverlet

Previously I used dotnet test /p:CollectCoverage=true with coverlet.msbuild to produce an coverage output on the command line like that:
+--------+------+--------+--------+
| Module | Line | Branch | Method |
+--------+------+--------+--------+
| Maui   | 0%   | 100%   | 0%     |
+--------+------+--------+--------+
| Shared | 0%   | 0%     | 0%     |
+--------+------+--------+--------+
| Client | 0%   | 100%   | 0%     |
+--------+------+--------+--------+
| Test   | 0%   | 0%     | 0%     |
+--------+------+--------+--------+

+---------+------+--------+--------+
|         | Line | Branch | Method |
+---------+------+--------+--------+
| Total   | 0%   | 0%     | 0%     |
+---------+------+--------+--------+
| Average | 0%   | 50%    | 0%     |
+---------+------+--------+--------+

But with the new MS Test runner this isn't possible anymore. It would be nice that this feature is restored. Or if someone has an alternative that shows the coverage for each module.

The new testing platform upon which the MSTest runner is build has got different extensibility point and MSBuild integration.
You can open an issue on coverlet repo for it https://github.com/coverlet-coverage/coverlet/issues
You can use the coverlet tool for it https://github.com/coverlet-coverage/coverlet?tab=readme-ov-file#net-global-tool-guide-suffers-from-possible-known-issue or move to the MS coverage version that's already integrated https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-platform-extensions-code-coverage#microsoft-code-coverage
With the MSTest.Sdk trx and codecoverage are already opted in by default https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-mstest-sdk#mstest-runner-profile

Thanks for the reply!

You can use the coverlet tool for now https://github.com/coverlet-coverage/coverlet?tab=readme-ov-file#net-global-tool-guide-suffers-from-possible-known-issue

That works

or move to the MS coverage version that's already integrated https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-platform-extensions-code-coverage#microsoft-code-coverage

That works but does not give the coverage output on the command line.

With the MSTest.Sdk trx and codecoverage are already opted in by default https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-mstest-sdk#mstest-runner-profile

I think TRX is not useful for this scenario.

That works but does not give the coverage output on the command line.

Only the msbuild integration scenario of Coverlet shows information in console, usually ppl that are not using it are generating a report with tools like report generator https://github.com/danielpalme/ReportGenerator

I find the coverage output on the command line very useful. It works with the coverlet tool but as far as I understand you have to first run the tests with dotnet run to generate a dll. And then you can run the coverlet tool with that dll. This means that I can't run the tool with dotnet watch to always run the tests and output the current coverage. Even not if I make a msbuild task for that because msbuild doesn't work with dotnet watch.

Console output is useful but doesn't scale for big projects, usually IDEs offers contextual report like Visual Studio as explained here https://devblogs.microsoft.com/visualstudio/code-coverage-features-in-visual-studio-enterprise/

This means that I can't run the tool with dotnet watch to always run the tests and output the current coverage.

Are you using the hot reload extension https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-platform-extensions-hosting#hot-reload?

Yes that doesn't scale for big projects but we use microservices and that fits better.

Are you using the hot reload extension https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-platform-extensions-hosting#hot-reload?

Not yet

With the MSTest.Sdk trx and codecoverage are already opted in by default https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-mstest-sdk#mstest-runner-profile
Here the documentation https://github.com/microsoft/codecoverage/blob/main/samples/Algorithms/scenarios/scenario07/README.md

How does this work with running multiple test projects in a solution? Before using the MSTest Runner, which I'm trying with MSTest.Sdk, I would use dotnet test with a run settings file or command line arguments.
I have struggled to find the "solution wide coverage" approach. I'd be happy with multiple files, one per project, in a central directory. Merging is trivial with tools like report generator (which ADO pipelines use).

I have struggled to find the "solution wide coverage" approach.

If you've a solution with all MSTest runner configuration(MStest.Sdk) there's no automatic way to merge at solution level with dotnet test. We've planned to support it.
So the solution is to merge at the end in a custom step using the dotnet-coverage tool (dotnet-coverage merge), here you can find some sample https://github.com/microsoft/codecoverage/blob/main/samples/Calculator/scenarios/scenario18/README.md


Modernize distro support and remove deprecated stdlib functions

This removes the deprecated stdlib validate_ functions and adds Centos/RHEL/Rocky 8 support. Lightly tested on Ubuntu 20 as well and worked as-is with puppet 6 prior to this change so this should work there as well.
As the spec tests were relatively normal, I also took the chance to convert this to puppet pdk style module for easier unit testing. I can split these two changes off into separate PRs if you prefer.

I am seeing the deprecations below @jonmosco
It would be great if we could have a new release with this pull request please.
Warning: This method is deprecated, please use the stdlib validate_legacy function,                     with Stdlib::Compat::String. There is further documentation for validate_legacy function in the README. at ["/etc/puppet/code/modules/logwatch/manifests/init.pp", 28]:["/tmp/mnc/puppet/manifests/site.pp", 0]    (location: /etc/puppet/code/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in deprecation')
Warning: This method is deprecated, please use the stdlib validate_legacy function,
with Stdlib::Compat::Array. There is further documentation for validate_legacy function in the README. at ["/etc/puppet/code/modules/logwatch/manifests/init.pp", 30]:["/tmp/mnc/puppet/manifests/site.pp", 0]
(location: /etc/puppet/code/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in deprecation') Warning: This method is deprecated, please use the stdlib validate_legacy function,                     with Pattern[]. There is further documentation for validate_legacy function in the README. at ["/etc/puppet/code/modules/logwatch/manifests/init.pp", 32]:["/tmp/mnc/puppet/manifests/site.pp", 0]    (location: /etc/puppet/code/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in deprecation')
`


Add cdn.liftoff-creatives.io to Ads

Domain(s) to add
cdn.liftoff-creatives.io
Reason
It serves ads for multiple apps, including but not limited to terabox. This domain belongs to "Liftoff" (according to Netify) which is a "mobile app marketing and retargeting platform"
Add to list
Ads/Adware
Other info
This service seems to be very new, not that many lists have this domain according to Blocklist tools. Blocking this domain does not seem to have any significant effects besides the removal of ads (yet).

As an addition: product-cdn.liftoff-creatives.io

I also found these domains after liftoff was blocked
biddingmax.apse.trk.rixserv.com
et-l.w.inmobi.com
i.l-new.inmobicdn.net

Thank you gentlemen @SodaWithoutSparkles @hagezi these domains are added in commit  3a51262 and will appear in the next release.
Closing.

 Thess low life hacker losers. Waste lf free air


tooltipster.destroy() throws error

In my functionAfter of the tooltipster config, I queue the "origin" or the tooltipster object and destroy after the queue has reached a certain length, lets say 50.
In my custom destroy method, I check if the state is "closed" or not. If "closed",  then tooltipster.destroy(). But I get an error related to some position.
What is the best way to completely destroy a tooltip (to release memory) such that when hover over the element again, the functionInit is called again and the tooltip is built from scratch.

Hello, not sure what your error is, it would be worth investigating. Could you please create a simple jsFiddle or CodePen to demonstrate the issue? Thank you.


insufficient logging: TOTP codes don't work; emergency codes do

uname -a
root@bastion:~ # uname -rms
FreeBSD 12.0-CURRENT amd64

pam.d/sshd:
auth            sufficient      pam_opie.so no_warn no_fake_prompts
auth            requisite       pam_opieaccess.so no_warn allow_local
auth            required        pam_google_authenticator.so secret=/opt/bastion/totp/${USER}/config debug echo_verification_code noskewadj

account         required        pam_nologin.so
account         required        pam_login_access.so
account         required        pam_unix.so

session         required        pam_permit.so

password        required        pam_unix.so no_warn try_first_pass

OTP config:
LONG_SEKRET
" WINDOW_SIZE 17
" DISALLOW_REUSE
" TOTP_AUTH
#####01
#####02
#####03
#####04
#####05

ssh config:
Port 2222
ListenAddress <IP_ADDRESS>
ListenAddress ::
AllowAgentForwarding yes
AllowTcpForwarding remote
AllowUsers bastion
AuthenticationMethods publickey,keyboard-interactive
AuthorizedKeysFile /opt/bastion/authorized_keys/%u
ChallengeResponseAuthentication yes
ChrootDirectory /opt/bastion/ssh_chroot
Compression delayed
ForceCommand echo 'This account can only used to forward'
IgnoreUserKnownHosts yes
LogLevel VERBOSE
PasswordAuthentication no
PermitRootLogin no
PermitTTY no
PermitTunnel yes
UseDNS no
UsePAM yes
X11Forwarding no

Trying to authenticate with user bastion
If I use one of the emergency tokens I am able to auth. If I use the TOTP code it fails to auth with the following error:
Feb 25 11:02:58 bastion sshd(pam_google_authenticator)[29348]: debug: start of google_authenticator for "bastion"
Feb 25 11:02:58 bastion sshd(pam_google_authenticator)[29348]: debug: Secret file permissions are 0600. Allowed permissions are 0600
Feb 25 11:02:58 bastion sshd(pam_google_authenticator)[29348]: debug: "/opt/bastion/totp/bastion/config" read
Feb 25 11:02:58 bastion sshd(pam_google_authenticator)[29348]: debug: shared secret in "/opt/bastion/totp/bastion/config" processed
Feb 25 11:03:01 bastion sshd(pam_google_authenticator)[29348]: debug: no scratch code used from "/opt/bastion/totp/bastion/config"
Feb 25 11:03:01 bastion sshd(pam_google_authenticator)[29348]: Invalid verification code for bastion

I'd appreciate some help figuring out what went wrong. Even if this is user-error it seems indicative of insufficient logging somewhere.

Is the time set correctly on the device (phone) and the server?

yes. The phone is certainly correct as I use it for every other TOTP operation out there (including for this website).
The server's time as of now is Sun Feb 25 11:48:50 UTC 2018 which is correct

… it's Monday today

...  Repeatedly. I just forgot to check the date.

:-D
https://www.youtube.com/watch?v=5EABrdJOt0s


[Bug] UnawareBucketAppendOnlyTableITCase.testCompactionInStreamingMode is not stable

Search before asking

[X] I searched in the issues and found nothing similar.

Paimon version
https://github.com/apache/incubator-paimon/actions/runs/5596335088/job/15158436649?pr=1603
Compute Engine
flink
Minimal reproduce step
Run ci
What doesn't meet your expectations?
CI fails
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

I'm willing to take a look at this, can you assign the issue to me please?

I'm trying to reproduce this error but fails
Looks like we need to reduce the compaction.min.file-num or increase the waiting time of compaction. However it seems like a trivial work
Could u please provide any other better ideas? @FangYongs


⚠ Bofrost.lu has degraded performance

In 457195d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 852 ms

Resolved: Bofrost.lu performance has improved in 6d96d61 after 8 minutes.


segmentation fault when running sniffnet

Is there an existing issue for this?

[X] I have searched the existing issues.

There, you will also find the solution.
Let me know if it helps.

That worked thanks. It would be nice if I could sort the columns so they didn't jump around, because by the time I click, it might click on what I didn't want, but that would have to be a feature request.

That worked thanks. It would be nice if I could sort the columns so they didn't jump around, because by the time I click, it might click on what I didn't want, but that would have to be a feature request.

Glad it worked.
Do you mean the rows?
Are you referring to the host table or to the connection table?

No! I means the columns, not rows, in the tables. Sort by doesn't have Dest or Src address or port, would be nice to sort by source and destination address and port.

Got it.
To have more stability in the sort order (to click a row in an easier way without the order changing) I can suggest you to order by packets or bytes instead of recent.
I’ve never considered sorting by IP address since it’s less useful generally speaking.


Open Folder on gallery tab is always disabled

It's meant to be enabled if you're coming from the same machine as the application is running on.

Partially fixed. Will be enabled if change the selected subdirectory. Still disabled on initial launch.

I think the current state is sufficient at least for now, since it only effects the root folder in practice.


Create data products that conform to CDF

Get more details from Bryan

Is this required for SIT-2 or can we remove it from that milestone?

Sorry somehow didn't see this, I don't think this is more of a SIT 3/4 task


Migrate provider to upjet v1.0.0

Description of your changes

Upgrade the provider to use the now stable released Upjet v1.0.0 generator. This allows us to use the new Beta Management Policies and initProvider settings.
Change all CRDs apiGroups from upbound.io to crossplane.io, as we are a community provider and have no affilitations with Upbound.

Fixes #57
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make submodules; make reviewable test to ensure this PR is ready for review.

How has this code been tested

TODO: Compare all version numbers used in the build process and toolings with the official upbound providers, as the template is very outdated.

@schlakob Please have a look


POD Install error

when i install PDFReader pod i got error
"[!] Unable to find a specification for PDFReader
"

Is this after running a pod repo update?

Closing due to inactivity, feel free to reopen if this did not solve the issue


[1.13] Remove newline from ZK log lines.

High-level description
Back-port of #7295
Remove newline from ZK log lines. Log lines with stack traces will still have newlines, but this change
allows all other log lines to be forwarded to syslog.
Additional fixes are included:

double a backslash escape
fix the GCE format, even though it is not used
use the same format for AWS and Azure to be more consistent

Corresponding DC/OS tickets (required)

D2IQ-68394 COPS-6128: Zookeeper log messages not being forwarded to syslog

Related tickets (optional)

D2IQ-ID JIRA title / short description.

@mesosphere-mergebot request-review @wavesoft @jkoelker


code problem

I noticed that you used the generation of 3d molecular conformations in conformer.py in the data folder in mol_tools, but it seems that 1 is generated for each molecular conformation, but in the uni-mol paper you mentioned that each molecule is generated 11 conformations. Where is the relevant code? If there is any, please point it out to me. Thank you.

you can refer to this.

Another question, when I use unimol_tools to fine tune the tox21 dataset, my code looks like this：
clf = MolTrain(task='multilabel_classification',
data_type='molecule',
batch_size=16,
metrics='auc',
split='random',
epochs=20,
learning_rate=2e-5,
)
pred = clf.fit(data = './train_data.csv')
clf = MolPredict(load_model='/home/zhuyifeng/gitcode/Uni-Mol-main/unimol_tools/unimol_tools/exp')
res = clf.predict(data = './test_data.csv')
After data processing my training set is as follows：
SMILES,TARGET1,TARGET2,TARGET3,TARGET4,TARGET5,TARGET6,TARGET7,TARGET8,TARGET9,TARGET10,TARGET11,TARGET12
O=C([O-])COc1ccc(Cl)cc1Cl,0,0,0,0,0,0,0,0,0,0,0,0
ClCC(Cl)CCl,0,0,0,0,1,0,0,0,0,0,0,0
Nc1ccn([C@@H]2OC@HC@@HC2(F)F)c(=O)n1,0,0,0,0,0,0,,0,0,0,0,1
CO,0,0,0,0,0,0,0,0,0,0,0,0
FC1(F)C(F)(F)C(F)(F)C2(F)C(F)(C1(F)F)C(F)(F)C(F)(F)C1(F)C(F)(F)C(F)(F)C(F)(F)C(F)(F)C12F,0,0,0,0,,0,0,0,0,0,0,0
CC1(C)S[C@@H]2C@HC(=O)N2[C@H]1C(=O)OCOC(=O)[C@@H]1N2C(=O)C[C@H]2S(=O)(=O)C1(C)C,0,,0,0,0,0,,,0,,0,
CC@@HC@@Hc1ccccc1,0,0,0,0,0,0,0,0,0,0,0,0
...
My test set is as follows:
SMILES,TARGET1,TARGET2,TARGET3,TARGET4,TARGET5,TARGET6,TARGET7,TARGET8,TARGET9,TARGET10,TARGET11,TARGET12
O=C(O)CNC(=O)c1ccc(N+[O-])cc1,0,0,0,0,1,0,0,0,0,0,0,0
COC(=O)c1ccccc1C(=O)OC,0,0,0,0,0,0,0,0,0,0,0,0
COc1cc2nc(N3CCN(C(=O)c4ccco4)CC3)nc(N)c2cc1OC,0,,,,0,0,0,0,,0,0,
Cc1cccc(N(C)C(=S)Oc2ccc3c(c2)C2CCC3C2)c1,,,,,,,,,,0,,
CCN(CC)C(=O)[C@]1(c2ccccc2)C[C@@H]1CN,0,0,0,0,0,0,0,,0,,0,0
SCCSCCS,0,0,0,0,0,0,0,0,0,0,0,0
NC@@HC(=O)O,0,0,0,,0,0,1,0,0,0,0,0
CCOC(=O)CC#N,0,0,0,0,0,0,0,0,0,0,0,0
Cc1ccc(Nc2nccc(N(C)c3ccc4c(C)n(C)nc4c3)n2)cc1S(N)(=O)=O,0,0,,,,0,,,,0,,1
c1cc(C(c2ccc(OCC3CO3)cc2)c2ccc(OCC3CO3)cc2)ccc1OCC1CO1,0,,0,,,0,,1,,1,,0
1.But in the process of fine-tuning the training there is a loss value of a very small negative number, and there is an error reported: ValueError: multi_class must be in ('ovo', 'ovr'), please ask how to solve it!
2.Before this I fine-tuned BBBP, BACE, ClinTox, according to the code result 'auroc' is 0.737, 0.85, 0.868 is a little different from the result 0.729, 0.857, 0.919 in the uni-mol paper, the first two classification tasks are almost the same as the paper result, but the latter one has a big difference, is it because of the hyperparameters?
3.Generating molecular conformations during training when using the SIDER dataset is very slow and feels stuck。


tensorflow and theano outputs differently on LSTM

problem:
when I use LSTM on tensorflow and theano, tensorflow outputs normally, while theano throws error.
repo code:
import keras
from keras import layers
import numpy as np

model = keras.models.Sequential()
model.add(layers.LSTM(1))
model.build((None, 49, 1))
x = np.random.rand(10, 49, 1)
pred = model.predict(x)

output:
on theano:
TypeError: ('The following error happened while compiling the node', for{cpu,scan_fn}(Subtensor{int64}.0, Subtensor{:int64:}.0, IncSubtensor{Set;:int64:}.0, IncSubtensor{Set;:int64:}.0, Subtensor{int64}.0, lstm_1/kernel, lstm_1/recurrent_kernel, lstm_1/bias), '\n', "Inconsistency in the inner graph of scan 'scan_fn' : an input and an output are associated with the same recurrent state and should have the same type but have type 'TensorType(float32, col)' and 'TensorType(float32, matrix)' respectively.")

on tensorflow:
model predict normally

The Theano backend was deprecated in 2019. I recommend switching to Keras 3 on top of either JAX, TensorFlow, or PyTorch.


Warnings and error on r2254

Thanks for great repo!
Describe the bug
Warnings and error while stay on station and charging. Vacuum added today on fresh install, it still working, but warnings and error exist.
To Reproduce
Nothing to do, it just stay on station.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional Information (please complete the following information)

Model Name [e.g. dreame.vacuum.p2028]: dreame.vacuum.r2254
Firmware Version [e.g. 1156]:  4.3.3_1709
Home Assistant Version: 2023.10.4
Configuration Type [With or without map support]: with map suport (latest beta)
Errors or warnings shown in the HA logs (if applicable):

2023-10-24 10:35:02.394 WARNING (Thread-336) [custom_components.dreame_vacuum.dreame.protocol] Error while executing request: https://api.io.mi.com/app/user/get_user_device_data HTTPSConnectionPool(host='api.io.mi.com', port=443): Read timed out. (read timeout=3)
2023-10-24 10:35:09.574 WARNING (Thread-336) [custom_components.dreame_vacuum.dreame.protocol] Error while executing request: https://api.io.mi.com/app/user/get_user_device_data HTTPSConnectionPool(host='api.io.mi.com', port=443): Read timed out. (read timeout=3)
2023-10-24 10:35:14.520 WARNING (Thread-336) [custom_components.dreame_vacuum.dreame.protocol] Error while executing request: https://api.io.mi.com/app/user/get_user_device_data HTTPSConnectionPool(host='api.io.mi.com', port=443): Read timed out. (read timeout=3)
2023-10-24 10:35:14.520 WARNING (Thread-336) [custom_components.dreame_vacuum.dreame.map] Getting object_name from cloud failed
2023-10-24 10:48:32.082 WARNING (Thread-442) [custom_components.dreame_vacuum.dreame.protocol] Error while executing request: https://api.io.mi.com/app/user/get_user_device_data HTTPSConnectionPool(host='api.io.mi.com', port=443): Read timed out. (read timeout=3)
2023-10-24 11:39:48.698 ERROR (Thread-430) [miio.miioprotocol] Got error when receiving: timed out
2023-10-24 16:11:04.334 ERROR (Thread-1572) [miio.miioprotocol] Got error when receiving: timed out

I suggest you use another server than CN if you can.

Impossible, it can't be connected to another server.
Is it safe to use with this kind of errors?

Google Public DNS

I'am already using DNS <IP_ADDRESS>
May be should be option to increase timeout or retrying times?

It is not about the timeout duration because I have tried increasing it. Even if I set timeout duration to 30 seconds it still not gets response from the server, that is why I choose to set it to 5 seconds. Also there is a retry mechanism too that is why you are mostly seeing warnings in the log and not errors. Device does not become unavailable while integration retries the request. I have tried almost everything to solve this but it also happens in the app and miot auto too so I decided that this not something I can fix from the integration. Interesting enough it does not happen over 4G from my Android phone, I can only reproduce it over my fiber connection to the CN servers.

I can try to reroute mi.com API via VPN in another country, is it enough to reroute "api.io.mi.com" ? Or I need some other addresses?


Fix scan iterator

It seems previously scan iterator throw exception if continuously read without end.
@Override
  public boolean hasNext() {
    ....
    if (cacheDrain()) {
      if (!loadCache()) {
        endOfRegion = true;
      }
    }
    ....
    return true;
  }

If cached drained and cache loading fail, hasNext will return wrongly true.
This PR also slightly refactored the ScanIterator since some parameters never used.

This change is

/run-all-tests

/run-all-tests tikv=release-2.0 tidb=release-2.0 pd=release-2.0

Tested against current version of TiDB and seems working.


Feature/force parse

Force OCR

@meglynkau Looks good. Going to propagate the option to the gc_ingest tools in this PR or separate?


ROS 2 Python only packages are not discovered by ros_discovery_plugin

https://index.ros.org/doc/ros2/Tutorials/Creating-Your-First-ROS2-Package/
ROS 2 python only packages do not have/need CMakeLists.txt files. This means they don't satisfy the requirements in the ros_discovery_plugin to be a ros package.

The initial fix I will try is to look for the following in the ROS discovery plugin:

Same as now, and keep this check first. If there is a package.xml file and CMakeLists.txt file then we can say it is a ROS package. We will use ROS_VERSION to determine if it is ROS1 or ROS2.

Add this if only package.xml is in a Statick package. If package.xml has the following tag then it is a ROS2 package:
<build_type>ament_python</build_type>

Fixed in #288.

Need to re-open. The changes to address this broke statick_ws for some users. See #291. We will have to come up with a way to do this while fixing the bugs.

Previous bugs were fixed and this is now available in v0.4.10. See #297 for updated method of discovery. See #291 where bugs were verified fixed.


RenderParagraph.debugDescribeChildren broken

03-08 10:35:01.964 E/flutter (18114): NoSuchMethodError: incorrect number of arguments passed to method named 'toString'
03-08 10:35:01.964 E/flutter (18114): Receiver: null
03-08 10:35:01.964 E/flutter (18114): Tried calling: toString("             │                 │       ║     ")
03-08 10:35:01.964 E/flutter (18114): Found: toString()
03-08 10:35:01.964 E/flutter (18114): #0      Object._noSuchMethod (dart:core-patch/object_patch.dart:42)
03-08 10:35:01.964 E/flutter (18114): #1      Object.noSuchMethod (dart:core-patch/object_patch.dart:45)
03-08 10:35:01.964 E/flutter (18114): #2      TextSpan.toString (packages/flutter/src/painting/text_painter.dart:116)
03-08 10:35:01.964 E/flutter (18114): #3      TextSpan.toString (packages/flutter/src/painting/text_painter.dart:121)
03-08 10:35:01.964 E/flutter (18114): #4      RenderParagraph.debugDescribeChildren (packages/flutter/src/rendering/paragraph.dart:121)
03-08 10:35:01.964 E/flutter (18114): #5      RenderObject.toStringDeep (packages/flutter/src/rendering/object.dart:1703)

I don't really care about this other than debugDumpRenderTree was broken.

I think this is actually a bug on your side, in that the only way I could find for this to happen is if you have a TextSpan whose children include a null value, which isn't valid. I'm going to assert the heck out of that particular case to try to catch it early. And then make the toString resilient against it.

Oh, never mind. I see the problem.

Looks like this fix was merged already.


Improve GitHub Actions for pull requests

See https://github.com/Senzing/community-roadmap/issues/71

Pull requests:

https://github.com/Senzing/aws-lambda-cognito-authorizer/pull/23


Allow null values via annotation to operators overloads able to handle null

While investigating enabling nullable annotations in ClosedXml I came across some problems with code like so (simplified and manually created to demonstrate):
var properties = new SheetFormatProperties();
DoubleValue? openXmlComparableSimpleValue = properties.DefaultRowHeight;
if (openXmlComparableSimpleValue != null)
{
    return;
}

Gives: Possible null reference argument for parameter 'left' in 'DocumentFormat.OpenXml.OpenXmlComparableSimpleValue<T>.operator !='
I went through operator overloads and annotated ones allowing null values with ? when input as null is handled properly.

/azp run


why I can't get a 302 statusCode ,but reviced a 200 instead?

I send a url ,that can work on webBroswer, sd_WebImage is not work, how can I get the 302 code

please share the image url


Add Ruby 3.0 to versions in CI workflow

Ruby 3.0 is now available and I have made a PR to update reline (https://github.com/ruby/reline/pull/238). However, in doing so I was seeing seg faults in the CI for reline. Things point towards this gem as being involved and so I thought it to be a good idea to also get this gem running on 3.0 for its workflow actions.

Thank you!


Align depth stream to external camera stream

I have a D410 on a Jetson and an external 4K camera (MIPI interface). I can capture depth frames from the D410 and RGB frames from the 4K camera concurrent and in real time.
I would like to align the depth frame to the color frame of the external camera, similr to the rs-align sample.
Is it possible to create a synthetic stream and pass the intrinsics and  extrinsics of the external camera to it ? If so how to do it?
Thanks

@abuzaina hello, this scenario is handled with the software-device class that the SDK provides.
Using this construct allows to bind and handle otherwise non-related sensors with a mockup "device", like in your case. Other cases include synchronizing depth streams of multiple depth cameras to generate a panoramic point cloud.
The software-device demo shows how to use this class, including building up the virtual sensors, generate the "software sensor" options, intrinsic  and inter-stream extrinsic and then sending "user-defined" frames to Librealsense pipe - the core blocks to implement your use-case :
https://github.com/IntelRealSense/librealsense/tree/master/examples/software-device
This class is extensively utilized internally for unit-testing, see usages here and here

@abuzaina hello.
One thing that I didn't mention which is, imo the real challenge in this scenario is obtaining the intrinsic matrix for the external sensor, and the extrinsic matrix between D410 and the external sensor.

The camera intrinsic matrix could probably be provided by the external sensor/OEM API or spec.
It should include the focal and principal points, the distortion model and its coefficients. You'll have to check that Librealsense  supports the distortion model exhibited by the 3rd-party sensor.
The extrinsic matrix between D400 and the external sensor is the one that you'll have to generate on your own.

hi @ev-mp ,
Thank you for your reply, the second usage link in your first reply does not go anywhere. I would appreciate if you send it again.
I am still not sure how to inject the depth frames from the D410 and the RGB frames from the camera to the software device, are there any examples of it ?

@abuzaina Are you asking about the links in "This class is extensively utilized internally for unit-testing, see usages here and here"?
Please find them as blow.
https://github.com/IntelRealSense/librealsense/blob/master/unit-tests/unit-tests-post-processing.cpp#L220-L265
https://github.com/IntelRealSense/librealsense/issues/4202

@abuzaina Any other questions about this? Thanks!

I'm not OP but I have a related question. I had a similar thing to this (using software device to align depth stream with other camera) working with an older version of the SDK (2.14) and I have recently updated to the latest SDK (2.24) and now when I align, the depth stream is blank (all zeroes). Has there been a regression or is there something else I now need to do to get it working? Attached is modified Window.xaml.cs from cs-tutorial-4-software-dev to reproduce the issue.
Window.xaml.cs.txt

@jb455 , please open a separate ticket for the C# issue

@abuzaina Any other questions about this ticket? Looking forward to your reply. Thanks!

@abuzaina Sorry that we didn't get feedback from you for weeks. Will close this issue accordingly. Please feel free to create new ticket if you still have issues/questions. Thanks!


Fix fork-source-link-same-view on tags/releases

Closes #5770
As far as I tested, the releases and tags pages work Ok. I only updated the link for a single tag. I assume we want to fallback to the defaultUrl in this case.
Test URLs
https://github.com/GehDoc/textile-js/releases/tag/v2.0.114
Screenshot

Thank you  for the bugfix, Prat!

👍
Thanks for having small tickets for new contributors 🙂


feat(ISV-5129): create product-level SBOMs

Added a Task that creates a product-level SBOM from release notes.
TODO:

[ ]  Bump version of populate-release-notes-images task (Waiting for #548)

/test

/ok-to-test

@johnbieren

1. The new task creates an sbom json file. Shouldn't something else be using that json?

The result will be used in https://issues.redhat.com/browse/ISV-5127.

2. The purl values we create look a bit different than the test ones https://github.com/konflux-ci/release-service-catalog/blob/development/tasks/populate-release-notes-images/populate-release-notes-images.yaml#L80 Is this okay? We have just been bitten in the past because things contained sha256 refs (or did not) and our tests weren't using realistic values, so I just wanted to bring it up

Since this task purely transforms data and doesn't adjust the purls in any way, I think it isn't a big deal that the values aren't realistic. When the purls are created, they are tested with realistic values.

/retest

@johnbieren @mmalina Squashed and rebased.


Create a CAR file to Manage Event Publishing - Android Device Type

In the current implementation, we ask the users to create a stream and receiver to manage the event publishing [1]. But as mentioned by Ayyoob all the other device types have CAR files that do this task.
Therefore, can we implement the same for the Android device type too?
[1] https://docs.wso2.com/display/IoTS310/Managing+Event+Publishing+with+WSO2+Data+Analytics+Server - 3rd step

@sameerawickramasekara will check on this.

This document is mainly focusing on how to configure with external IoT Analytics Server, and hence let's change the title to address that. And we don't need the step3 at all in the doc. We have only the location based geo analytics with an android agent, and the relavant car file is already deployed in the IoT analtyics server.

Thank you! Updated docs as discussed.


'NSLocationWhenInUseUsageDescription' is needed even no location is in use

Question
While I try to submit app to App Store and I got a message from them :

ITMS-90683: Missing Purpose String in Info.plist - Your app's code references one or more APIs that access sensitive user data. The app's Info.plist file should contain a NSLocationWhenInUseUsageDescription key with a user-facing purpose string explaining clearly and completely why your app needs the data. Starting Spring 2019, all apps submitted to the App Store that access user data are required to include a purpose string. If you're using external libraries or SDKs, they may reference APIs that require a purpose string. While your app might not use these APIs, a purpose string is still required. You can contact the developer of the library or SDK and request they release a version of their code that doesn't contain the APIs. Learn more (https://developer.apple.com/documentation/uikit/core_app/protecting_the_user_s_privacy).

I understand I need to declare NSLocationWhenInUseUsageDescription  in info.plist while using the location. However, I did not use any location, but still Apple is detecting this.
Any workaround?
Current code on map:
      <MapView         ref={(ref) => {           mapRef = ref;         }}         initialRegion={{           latitude: 0,           longitude: 0,           latitudeDelta: 80,           longitudeDelta: 80,         }}         style={{ flex: 1 }}         customMapStyle={mapJson}         provider={PROVIDER_GOOGLE}         onRegionChangeComplete={onRegionChangeComplete}
OS: iOS
Map: Google Map
Version:
react-native-maps v0.26.1
react-native v0.61.5
react 16.9.0

@FlashLim are you using expo?

I am not using expo.

@FlashLim are you using expo?

In your Info.plist file you need to add the NSLocationWhenInUseUsageDescription key with a description

In your Info.plist file you need to add the NSLocationWhenInUseUsageDescription key with a description

I know the Apple is requesting, but why do we need to add this key in the info.plist?
If the underlying reason is because of react native is doing multiple layer of parsing data, end up it is very hard to hide the permission.
Then, I understand. But what should I write in the description?

A message that tells the user why the app is requesting access to the user’s location information.
See:
https://developer.apple.com/documentation/bundleresources/information_property_list/nslocationusagedescription

@diegorodriguesvieira I use react-native-maps in my project too, and I usually get NSLocationWhenInUseUsageDescription warning from Apple.
For the map component, I always provide the map center with coordinates fetched from the server, and I NEVER request/use the user's location.
For me, it is difficult to put this NSLocationWhenInUseUsageDescription in the Info.plist file because I never use this information.
In this situation, what do I have to do, any work around?

@enocholumide are you using google maps or apple maps in iOs?

@diegorodriguesvieira I use the Apple Maps for iOS.

I don't know the rules to use the apple maps bro, but my suggestion is to add this description to avoid issues with apple store process

Hello @diegorodriguesvieira and @enocholumide : I am using the Google Map and face the same issue.
I use Map just for some marker, there is no user location access. Can you please give me some example for purpose string in this case? I am really appreciated.

Is there any update on this? I can confirm it is still an issue. It's not ideal to just add the 'NSLocationWhenInUseUsageDescription' when the user location isn't even required, because it means the user gets a big permissions popup come up as they start up the app, telling them they need to give away their location, when that isn't the case at all. In our app, we simply want to show a map of a point of interest, not  a marker for the user location. I've looked into the code but can't seem to find out what the issue is.

I've just managed to temporarily resolve this. Not a proper solution but I don't know C programming, but in AIRMap.m, on line 348, I took out the block that requests user location access from the api and replaced with.
- (void)setShowsUserLocation:(BOOL)showsUserLocation
{
    showsUserLocation = showsUserLocation;
}

Created a fork and used this. I've just submitted to app store and didn't receive the usual plist warning. Map still functions ok.
There must be something dodgy with the original logic as it's returning true even when the prop is set to false in the app. Sorry for the hacky comment / solution but just thought i'd share in case this is helpful to someone else, or perhaps someone can fix the logic and create a PR.

For what it's worth, I was having this same issue, my app asked the user for location permission while I did not really need it. When submitting, I got the same ITMS-90683 message that told me I need to set a NSLocationWhenInUseUsageDescription.
I was able to avoid the "Allow app to use location data" window after explicitly setting the <MapView showsUserLocation={false} />

Still facing the same issue.
@brtdv your solution is not working for me.

I'm facing the same issue, any solution to that other then forking and fixing this ourselves?


Add TIL: Use DISKPART to wipe an SSD or HDD

Add to the windows section.  Using the command diskpart to enter the disk partition command line utility.

list disk
select disk
verify with a list disk checking for asterisk
using the clean command

discovered here: https://graspingtech.com/how-to-delete-all-partitions-from-a-disk-in-windows/

59af2cb89d6b52848941c7e528f5a89921530007 closes this issue


osx install error

osx el capitan install.
Following readme instructions:
  > brew install --devel fltk
  > fltk-config --version
  1.3.4
   > git clone http://github.com/deech/fltkhs-hello-world
   > cd fltkhs-hello-world
   > stack --version
   Version 1.3.2 x86_64 hpack-0.15.0
   > stack install

stack install errors with:
ltkhs-<IP_ADDRESS>: configure
Progress: 3/4
--  While building package fltkhs-<IP_ADDRESS> using:
      /private/var/folders/h1/yhtz6g614_g999nh_tb4gj600000gn/T/stack18814/fltkhs-<IP_ADDRESS>/.stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS>/setup/setup --builddir=.stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS> configure --with-ghc=/Users/tonyday/.stack/programs/x86_64-osx/ghc-8.0.1/bin/ghc --with-ghc-pkg=/Users/tonyday/.stack/programs/x86_64-osx/ghc-8.0.1/bin/ghc-pkg --user --package-db=clear --package-db=global --package-db=/Users/tonyday/.stack/snapshots/x86_64-osx/lts-7.16/8.0.1/pkgdb --package-db=/Users/tonyday/git/fltkhs-hello-world/.stack-work/install/x86_64-osx/lts-7.16/8.0.1/pkgdb --libdir=/Users/tonyday/git/fltkhs-hello-world/.stack-work/install/x86_64-osx/lts-7.16/8.0.1/lib --bindir=/Users/tonyday/git/fltkhs-hello-world/.stack-work/install/x86_64-osx/lts-7.16/8.0.1/bin --datadir=/Users/tonyday/git/fltkhs-hello-world/.stack-work/install/x86_64-osx/lts-7.16/8.0.1/share --libexecdir=/Users/tonyday/git/fltkhs-hello-world/.stack-work/install/x86_64-osx/lts-7.16/8.0.1/libexec --sysconfdir=/Users/tonyday/git/fltkhs-hello-world/.stack-work/install/x86_64-osx/lts-7.16/8.0.1/etc --docdir=/Users/tonyday/git/fltkhs-hello-world/.stack-work/install/x86_64-osx/lts-7.16/8.0.1/doc/fltkhs-<IP_ADDRESS> --htmldir=/Users/tonyday/git/fltkhs-hello-world/.stack-work/install/x86_64-osx/lts-7.16/8.0.1/doc/fltkhs-<IP_ADDRESS> --haddockdir=/Users/tonyday/git/fltkhs-hello-world/.stack-work/install/x86_64-osx/lts-7.16/8.0.1/doc/fltkhs-<IP_ADDRESS> --dependency=base=base-<IP_ADDRESS> --dependency=bytestring=bytestring-<IP_ADDRESS> --dependency=directory=directory-<IP_ADDRESS> --dependency=filepath=filepath-<IP_ADDRESS> --dependency=mtl=mtl-2.2.1-6qsR1PHUy5lL47Hpoa4jCM --dependency=parsec=parsec-3.1.11-LpfwwmNNJ2sE9xLSsn0mIx --dependency=text=text-<IP_ADDRESS>-3a9dYmy0lx7FK5kPXUTTi5
    Process exited with code: ExitFailure 77
    Logs have been written to: /Users/tonyday/git/fltkhs-hello-world/.stack-work/logs/fltkhs-<IP_ADDRESS>.log

    [1 of 2] Compiling Main             ( /private/var/folders/h1/yhtz6g614_g999nh_tb4gj600000gn/T/stack18814/fltkhs-<IP_ADDRESS>/Setup.hs, /private/var/folders/h1/yhtz6g614_g999nh_tb4gj600000gn/T/stack18814/fltkhs-<IP_ADDRESS>/.stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS>/setup/Main.o )
    [2 of 2] Compiling StackSetupShim   ( /Users/tonyday/.stack/setup-exe-src/setup-shim-mPHDZzAJ.hs, /private/var/folders/h1/yhtz6g614_g999nh_tb4gj600000gn/T/stack18814/fltkhs-<IP_ADDRESS>/.stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS>/setup/StackSetupShim.o )
    Linking /private/var/folders/h1/yhtz6g614_g999nh_tb4gj600000gn/T/stack18814/fltkhs-<IP_ADDRESS>/.stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS>/setup/setup ...
    Running autoconf ...
    Configuring fltkhs-<IP_ADDRESS>...
    configure: WARNING: unrecognized options: --with-compiler
    checking whether the C++ compiler works... no
    configure: error: in `/private/var/folders/h1/yhtz6g614_g999nh_tb4gj600000gn/T/stack18814/fltkhs-<IP_ADDRESS>':
    configure: error: C++ compiler cannot create executables
    See `config.log' for more details

Any ideas on debugging?

The problem is that the configure script cannot find g++. I must have installed g++ at some point and forgotten about it when testing. I fixed that issue in the repo but haven't cut a release yet.
Additionally while testing with clang and clang++ I discovered that the brew FLTK package is broken. It omits some headers which are available in the stable source release of FLTK that fltkhs depends on. clang flags them as uninitialized variables, g++ ignores them.
To sum up, the fix for this issue is:

Compile and install FLTK from source.

wget --no-check-certificate http://fltk.org/pub/fltk/1.3.4/fltk-1.3.4-1-source.tar.gz
tar -zxf fltk-1.3.4-1-source.tar.gz
cd fltk-1.3.4-1
./configure --enable-gl --enable-shared --enable-localjpeg --enable-localzlib --enable-localpng
make
sudo make install

Clone the HEAD of this repo and fltkhs-hello-world into some temp folder, and build both, for example:

mkdir /tmp/fltkhs-tmp
cd /tmp/fltkhs-tmp
git clone http://github.com/deech/fltkhs
git clone http://github.com/deech/fltkhs-hello-world
stack init
stack build
stack exec fltkhs-hello-world

Sorry for the trouble and thanks for reporting!

I've released a fixed version to Hackage. While you'll still need to do step 1 from above (compiling and installing FLTK from source) instead of step 2 you should just be able to git pull inside the fltkhs-hello-world directory followed by stack build and stack exec fltkhs-hello-world. Thanks again for your patience.

Thanks deech,
Good news first - I got the hello-world example running as per your last comment. I am very happy and thanks for your help.
Bad news - I got it running using brew install fltk. In following the direct source install method, I crashed and burnt deep into the fltk make stage:
~/fltk-1.3.4-1
# make
=== making jpeg ===
=== making zlib ===
=== making png ===
=== making src ===
=== making fluid ===
=== making test ===
Compiling blocks.cxx...
In file included from blocks.cxx:47:0:
/System/Library/Frameworks/CoreAudio.framework/Headers/AudioHardware.h:162:2: error: expected unqualified-id before '^' token
 (^AudioObjectPropertyListenerBlock)(    UInt32                              inNumberAddresses,
  ^
/System/Library/Frameworks/CoreAudio.framework/Headers/AudioHardware.h:162:2: error: expected ')' before '^' token
In file included from blocks.cxx:47:0:
/System/Library/Frameworks/CoreAudio.framework/Headers/AudioHardware.h:400:41: error: 'AudioObjectPropertyListenerBlock' has not been declared
                                         AudioObjectPropertyListenerBlock    inListener)             __OSX_AVAILABLE_STARTING(__MAC_10_7, __IPHONE_7_0);
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/System/Library/Frameworks/CoreAudio.framework/Headers/AudioHardware.h:421:41: error: 'AudioObjectPropertyListenerBlock' has not been declared
                                         AudioObjectPropertyListenerBlock    inListener)             __OSX_AVAILABLE_STARTING(__MAC_10_7, __IPHONE_7_0);
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/System/Library/Frameworks/CoreAudio.framework/Headers/AudioHardware.h:792:2: error: expected unqualified-id before '^' token
 (^AudioDeviceIOBlock)(  const AudioTimeStamp*   inNow,
  ^
/System/Library/Frameworks/CoreAudio.framework/Headers/AudioHardware.h:792:2: error: expected ')' before '^' token
/System/Library/Frameworks/CoreAudio.framework/Headers/AudioHardware.h:1326:37:error: 'AudioDeviceIOBlock' has not been declared
                                     AudioDeviceIOBlock                          inIOBlock)                              __OSX_AVAILABLE_STARTING(__MAC_10_7, __IPHONE_7_0);
                                     ^~~~~~~~~~~~~~~~~~
make[1]: *** [blocks.o] Error 1
make: *** [all] Error 1

A quick search, but nothing remotely like this error has ever reached the ear of google, it seems.  I had a quick peek upstream to see about reporting, but it had that scary, olden-days, subversionesque look.

Wow, I've never seen anything like it. However, there is good news, since that happened with the demos that means the rest of it compiled fine and you should still be able to do sudo make installto copy the libraries and headers to the standard prefix ( I think it's /usr/local unless you changed it).

I upgraded xcode to 8.2.1 in the course of debugging, and I'm guessing that some of macOS Sierra snuck in. Siri making her big entrance to the mac, and something called CoreAudio.h falling over in a stable library may not be a coincidence ...
Regardless, I uninstalled the brew version and sudo make install gave me a working example as you suggest.
Thanks again


fix nix build

I included these changes and made some more nix fixes in #104

I have rebased and squashed - thanks for the fixes @hamishmack @disassembler.
Unfortunately I had to give up on cabal.project.freeze - but index-state should achieve the same thing more or less.


Shell refactor

Refactor handlers part so that twitter internal heron-shell can use most of the codes from the OSS side.

@objmagic could you please provide a description explaining the motivation for the refactor?

shipit after ci pass


Required behaviour changed for time.Time

[X] I have looked at the documentation here first?
[X] I have looked at the examples provided that may showcase my question here?

Package version eg. v9, v10:
v10.15.2
Issue, Question or Enhancement:
A zero time.Time passes the required validation in v10.15.2 but not in v10.15.1. Adding in WithRequiredStructEnabled to the New() func does enable the test to pass but I'm not sure if I should make this code change in our codebase; should the default behaviour have changed between these minor releases?
I've provided a sample test that passes in v10.15.1 but fails in v10.15.2.
Code sample, to showcase or reproduce:
func TestTimeRequired(t *testing.T) {
	validate := New()
	validate.RegisterTagNameFunc(func(fld reflect.StructField) string {
		name := strings.SplitN(fld.Tag.Get("json"), ",", 2)[0]

		if name == "-" {
			return ""
		}

		return name
	})

	type TestTime struct {
		Time time.Time `validate:"required"`
	}

	var testTime TestTime

	err := validate.Struct(&testTime)
	NotEqual(t, err, nil)
	AssertError(t, err.(ValidationErrors), "TestTime.Time", "TestTime.Time", "Time", "Time", "required")
}

+1

Thanks for the report, I’ll be looking into it as soon as I can find some time.

@daveoxley this should all be resolved in Release https://github.com/go-playground/validator/releases/tag/v10.15.4


Retrieve & Sync Patient Registration Questionnaire  from HAPI and not assets folder

As a subtask of #414
Load the patient-registration.json from the server-side and not the assets folder as Referenced here: https://github.com/opensrp/fhircore/blob/5ebff99e5072907b9c7e27cc8ead7357b32f8e29/android/app/src/main/java/org/smartregister/fhircore/activity/PatientListActivity.kt#L103
Acceptance criteria
Option 1 :

[ ] Create two registers one for Covax and one for CHW/ANC
[ ] If one selects the Covax Clients register and clicks on Register new patient, load the Covax registration questionnaire sample
[ ] If one selects the CHW/ANC Register and clicks on Register new patient, load the CHW/ANC questionnaire sample   - Needs SW translation

Mocks
NB. Replace RDT with CHW/ANC

Option 2:
TBD

Context

With the R&D to edit patient data on going for OpenSRP web, we need a way to Identify which Questionaire Resource to load for each patient we try to edit.
For this to happen we need to fetch the registration Questionaire Resources from the server.
We also need a way to Identify which questionnaire resource was used to create the patient.

Changes that affect the Android client

As mentioned above the clients currently read the Questionaire resource from the app assets. We would like to be able to fetch this from the server.
Then figure out a way to map each registration questionnaire resource to its correct module.
Figure out how to identify which questionnaire resource a patient was created from, this will help the web instance know what questionnaire to use when trying to edit the patients.

Although not related however, now we need to start thinking in terms of what actually we are building..

Is it a different implementation which we are providing and that would provide base for other implementations (means that We have an IG (Implementation Guide which would allow people to import all metadata),
Would this IG depend on other IGs as well,
What are details for our IG i.e. url, name, etc, how we would register it with FHIR and registry portal
Is it one single IG or multiple IGs

We would also want to add a workflows i.e. add these to specific PlanDefinition and try automating the register/app specific metadata as well.
Aside from above for current issue we would need to

add questionnaires to server
sync questionnaires and keep them updated (For now sync like we do for patient when launching FHIRApplication, and later with proper syncing setup)
Load the questionnaire from FhirEngine as Resource instead of assets , and pass the key of form from register click method to questionnnaire activity which would be later on derived by workflow

@maimoonak on the following points

add questionnaires to server - Updated the links to the test questionnaires for this implementation on the HAPI FHIR Server
sync questionnaires and keep them updated (For now sync like we do for patient when launching FHIRApplication, and later with proper syncing setup) - TODO
Load the questionnaire from FhirEngine as Resource instead of assets , and pass the key of form from register click method to questionnnaire activity which would be later on derived by workflow - TODO

We will also need to tag which patient belongs to which register @maimoonak @dubdabasoduba

I think we should just call it "ANC" not "CHW/ANC" because "CHW" isn't a health vertical it's a type of user so it would not make sense as a register (neither would "RDT" but that's fine, since we're removing it :)

@f-odhiambo @dubdabasoduba We also need the questionnaire record-vaccine.json in questionnaires and load in same way. Plz add the link to vaccine questionnaire as well

Here is the link to the Record Vaccine questionnaire - https://fhir.labs.smartregister.org/fhir/Questionnaire/800


Version setting changes

This PR contains:

Version update of shipkit-auto-version.
Version setting removal (it is unnecessary because it is done automatically by shipkit-auto-version plugin).

After the update and setting removal, changes were tested by running the build and inspecting generated files - all of them have the same correct version.

Codecov Report

Merging #1552 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1552      +/-   ##
============================================
+ Coverage     73.64%   73.66%   +0.01%
- Complexity     8141     8143       +2
============================================
  Files           573      573
  Lines         44709    44709
  Branches       5643     5642       -1
============================================
+ Hits          32925    32933       +8
+ Misses        10126    10119       -7
+ Partials       1658     1657       -1

Impacted Files
Coverage Δ
Complexity Δ

.../com/github/ambry/network/BlockingChannelInfo.java
80.95% <0.00%> (-3.18%)
16.00% <0.00%> (ø%)

...b/ambry/network/BlockingChannelConnectionPool.java
72.91% <0.00%> (-3.13%)
11.00% <0.00%> (-1.00%)

...java/com/github/ambry/network/SSLTransmission.java
70.15% <0.00%> (-0.93%)
75.00% <0.00%> (ø%)

...java/com/github/ambry/store/CompactionManager.java
92.26% <0.00%> (-0.60%)
25.00% <0.00%> (ø%)

...a/com/github/ambry/clustermap/ClusterMapUtils.java
92.57% <0.00%> (-0.50%)
48.00% <0.00%> (ø%)

...src/main/java/com/github/ambry/commons/BlobId.java
93.03% <0.00%> (-0.35%)
72.00% <0.00%> (-1.00%)

...ain/java/com/github/ambry/router/PutOperation.java
92.81% <0.00%> (ø)
124.00% <0.00%> (ø%)

...in/java/com/github/ambry/store/StorageManager.java
89.26% <0.00%> (ø)
61.00% <0.00%> (-1.00%)

.../main/java/com/github/ambry/store/HardDeleter.java
77.49% <0.00%> (+0.28%)
49.00% <0.00%> (+1.00%)

...in/java/com/github/ambry/store/BlobStoreStats.java
70.86% <0.00%> (+0.41%)
104.00% <0.00%> (ø%)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9901f4...4ce61fd. Read the comment docs.

Nice clean-up, thanks!
+1 to merging

Thank you @shestee!


Any plan of Android support ?

I actually dig around Android world to find the equivalent function of Method Swizzling, but I couldn't find any useful.
It seems that Kotlin doesn't support it, and Java have Reflection, but it doesn't seem what I'm looking for.
Do you have any suggestion or code example 🤔 @jkyeo

Very curious about this as well (just in general, for all my Android colleagues).
From some quick searching, these seem to be the current solutions:

Android Studio has a built-in Network Profiler
There are libraries for in-app network debugging such as Chuck, but they require the user making all calls via specially configured OkHttp clients (by adding an interceptor).
Then there are Android tools such as HttpCanary which just do the VPN (or proxy) dance to intercept all traffic (like Charles does).

For something like Atlantis or Bagel to work, the libraries need to be able to monitor all calls made by the system (in the app), either by using some built-in mechanism, or by swizzling (replacing the system implementations).

Thanks for the detailed hint @djbe. I will continue researching and soon support Atlantis on Android 👍

in Android, they have what they call dynamic instrumentation where you can set up hooks on methods.
not sure if this is what it's needed or the equivalent for Method Swizzling in android but there are many libraries abstracting this concept such as AndHook

Right, so a colleague of mine made an Android implementation for Bagel, credits to @dieter115!
Right now the code is embedded in an internal library we use in our Android projects. It consists of:

Interceptor and listener autodiscovery, code can be found here. It's very similar to the iOS code.
The interceptor is added to the client(s) the developer wants to monitor: interceptor creation and registration
The service discovery is started on app onCreate() using BagelNetworkDiscoveryManager.registerService(context), the equivalent of Atlantis.start()

Now we'd love to switch to Proxyman for our Android devs (using Atlantis). We can probably tweak our implementation to match the Atlantis protocol, or would you rather do this yourself?

@djbe It sounds good. I'm not familiar with Android development, so it might take more time to do it by myself 😸
If you don't mind, you can do and open the PR. I'm happy to help you with the integration 😄

Is there a high level documentation on how Atlantis works, and maybe where it differs from Bagel? I noticed Atlantis for example compresses all sent data using gzip

@djbe Unfortunately, there is no high-level documentation, but I can quickly describe here:

As soon as you launch Atlantis, Atlantis will do "Method Swizzling" for all NSURLSession methods: It's the same logic with Bagel, but in Swift. Code: https://github.com/ProxymanApp/atlantis/blob/main/Sources/NetworkInjector.swift
When Atlantis receives the request/response. It will construct the message (https://github.com/ProxymanApp/atlantis/blob/89702b9586fcbed2e99a5e896821461bc700272c/Sources/Atlantis.swift#L298)
Then, sending it to macOS via Bonjour Service (https://github.com/ProxymanApp/atlantis/blob/89702b9586fcbed2e99a5e896821461bc700272c/Sources/Transporter.swift#L104)
gzip is optioned, but recommend. Proxyman for macOS will check if it's a gzip or not.

If you're going to implement the Android, you can implement your own "Method Swizzling" in Android, then construct a message with the given Request/Response and pass it to Atlantis with this func (https://github.com/ProxymanApp/atlantis#1-my-app-uses-c-network-library-and-doesnt-use-urlsession-nsurlsession-or-any-ios-networking-library)
In this way, Atlantis will handle the rest (Construct the message and send it to Proxyman for macOS) 👍

Hey Guys I have been working on a POC for Android. And I made it possible to connect my application (Android phone) to a Proxyman socket on my macbook. I wrote your message ,device , project , ... objects in kotlin and I am trying to send this data gzipped json or normal json over this socket. I used Wireshark to check  the packages and connection and they were all sent to the right socket. They don't seem to appear in the Proxyman app ... Is there a format the message and / or it's field need to have to be recognized by Proxyman.

Hey @dieter115, If you connect to Proxyman Socket at localhost:9090, and send the Atlantis data, it won't work.
You might have someway to consume Bonjour Service from Proxyman app. From what I googled, there is Network Service Discovery from Android, which is allowed you to discover Proxyman and send the data to. Ref: https://jaanus.com/implementing-bonjour-across-ios-and-android/
Here is the Bonjour Service from Proxyman app
        static let netServiceDomain = ""
        static let netServiceType = "_Proxyman._tcp"
        static let netServiceName = "Proxyman"
        static let netServicePort: Int32 = 10909

let uniqueServiceName = "\(netServiceName)-\(UUID().uuidString)"
let netService = NetService(domain: netServiceDomain, type: netServiceType, name: uniqueServiceName, port: netServicePort)

From your JSON, the second one (without escape) looks correct. Basically, it's a JSON, we don't need to escape it.
However, in order to send the message to Proxyman, you might construct the message like Atlantis does.
Code: https://github.com/ProxymanApp/atlantis/blob/87107de8c2881dd86b6b53da6519a93048f40ed3/Sources/Transporter.swift#L115-L118
The message will contain two parts:

Reserve xx bytes (Int(MemoryLayout<UInt64>.stride)) and fill it will the length of the JSON message
The actual JSON message in byte.

The reason is that Proxyman doesn't know when the message is completed (The message can be spliced into small chunks when sending in TCP layer). Thus, the first part is important to know where the JSON Message is done.

hey @NghiaTranUIT I'm indeed connected with the service with port 10909 and I found it through Network Service Discovery. I already used this part in my Bagel POC. I create a socket with its IP and port and send packages through it.  I'm already sending the length of the json data and then the json itself each as its own package/message. But what you mean is that you send 1 message with length of data and the date itself combined as 1 package?

@dieter115 you can see the code how the message is constructed https://github.com/ProxymanApp/atlantis/blob/87107de8c2881dd86b6b53da6519a93048f40ed3/Sources/Transporter.swift#L115-L118
Yes, it’s one message that consists of two parts.

I think that you can roughly translate to Kotlin. Please let me know if you need some help 😊

Hey @NghiaTranUIT I reworked my code so it sends 1 message instead of 2 different messages.
I used this code :

Sending size of message as a byte array

 val outPutStream = socket.getOutputStream()
                        val messageByteArray =Gson().toJson(proxymanRequestMessage).toByteArray()

                        val output = ByteArrayOutputStream()
                        output.write(messageByteArray.size.toLong().toByteArray())
                        output.write(messageByteArray)
                        outPutStream.write(output.toByteArray())

This sends a message that looks like this

I think this is also how Atlantis does it ? But I also tried other formats for the size to see if they would work.

Sending size of message as a string or int

...
output.write(messageByteArray.size.toString().toByteArray())
...

or
...
output.write(messageByteArray.size.toString().toByteArray())
...

These seem to make Proxyman stop.

buffer.append(&lengthPackage, length: Int(MemoryLayout<UInt64>.stride))

@dieter115 It means the buffer will reserve 8 bytes to store the lengthPackage, which is in bytes too.
Here is how Proxyman app get the Atlantis message

First of all, Proxyman will read 8 bytes on the stream and parse it to UInt64 to know the message length

        let byLength = Int(MemoryLayout<UInt64>.stride)
        connection.receive(minimumIncompleteLength: byLength, maximumLength: byLength) {[weak self] (data, _, _, error) in
            guard let strongSelf = self else { return }

            if let data = data {
                // Cast byte to UInt64
                var length: UInt64 = 0
                _ = withUnsafeMutablePointer(to: &length) { (length) -> Int in
                    data.copyBytes(to: UnsafeMutableBufferPointer(start: length, count: MemoryLayout<UInt64>.stride))
                }
...

After getting the length, Proxyman tries to read the message

connection.receive(minimumIncompleteLength: length, maximumLength: length)

From what I see in your code
output.write(messageByteArray.size.toString().toByteArray())
output.write(messageByteArray.size)

It looks like your write a length without reserving 8 bytes. and it must be an Integer or UInt64

It's similar to how Bagel works
https://github.com/yagiz/Bagel/blob/763aadbf6a099681a66e69522f902e33094f6a55/iOS/Source/BagelBrowser.m#L124-L126
So if you code is already working with Bagel, it should work with Proxyman app

@NghiaTranUIT The first approach I tried was using the same code as with Bagel. But here I send 2 messages over the socket 1 with length of message and 1 with the message data. It works with Bagel but Proxyman doesn't seem to show my sent data.. Like you can see in the picture of the message I sent.. The length of the message reservers / takes 8 bytes.
So like Bagel
val outPutStream = socket.getOutputStream()
                        val messageByteArray =Gson().toJson(proxymanRequestMessage).toByteArray()

                        //first sent length of message to bagel
                         outPutStream.write(messageByteArray.size.toLong().toByteArray())
                        //sent actual message as a bytearray
                        outPutStream.write(messageByteArray)

                        outPutStream.flush()

Force it as  1 message like Atlantis
https://github.com/ProxymanApp/atlantis/issues/28#issuecomment-822344148
Is there a way to debug if Proxyman is receiving anything?

Quick update: @dieter115 and I were able to get a PoC working with Proxyman today, the issue had nothing to do with the message size / byte reservation.
After using Wireshark and temporarily disabling gzip compression in Atlantis, we found the issue: as a side effect of using Codable, it'll automatically base64 encode any Data property. This is something that Proxyman does that's quite different from Bagel. Besides that, we found some other small differences, but that was the main one (it applies to content, requestBody, responseBody, etc...).
We found another difference, where I have no idea why Proxyman changed this from Bagel:

Bagel sends a message at the start of a request (with only the request content), and a second message at the end of a request with the full info (request, response, etc...)
Proxyman only expects a message at the end of a request.
If we send traffic messages with the same ID to Proxyman like we did with Bagel, it'll appear twice in Proxyman: one "active" incomplete call, and one "completed" call with all the data (see attachment). Proxyman should check the ID of the traffic and update existing items, instead of creating new items. This would enhance Proxyman by having requests appear directly (at the start), and then be updated when more information is available (on finish).

Thanks for your input @djbe

as a side effect of using Codable, it'll automatically base64 encode any Data property.

Yes, it's. Codable automatically encoded the raw data to base64. I intentionally use it for easier implementation.

Bagel sends a message at the start of a request (with only the request content), and a second message at the end of a request with the full info (request, response, etc...)

You're right. It's the main difference between Bagel and Proxyman.
Instead of sending two parts (Request and Response) of the 1 request, Atlantis accumulates it. and send ONCE when it's done. It increases the performance of your app has a large number of traffic that sending to Proxyman.
Here is the function that you can manually send a request and response to Proxyman: https://github.com/ProxymanApp/atlantis/blob/5ca79443ec6d68b6fa5b6b76b8ddf3070e69b45a/Sources/Atlantis%2BManual.swift#L18-L30

@NghiaTranUIT Me and my colleague David made it possible to send packages to Proxyman. But I still have a question.. I was making the feature where you can limit the Mac's you connect with. I copied this from my Bagel implementation but then I saw a difference. When I find bagel in the network discovery code it gives me a name like "macbook Dieter" but when i discover Proxyman services I get names like  Proxyman-DA9E3C12-74DC-4865-9690-AA55FD351690 did you guys ever encounter something similar ?

Right so the difference with Bagel is that Bagel sets the service name to the hostname, whereas Proxyman sets the service name to some random identifier (like @dieter115 posted).
We've tried switching to using InetAddress' getHostName() and getCanonicalHostName(), but neither work well. It usually just returns the host's IP address instead of a nice network name. I'm not sure there's any solution to this, Android's reverse DNS lookup seems to be quite buggy.

Glad to know you finally send a request to Proxyman 🥇 @djbe @djbe 👍
You're right about the Proxyman Service Name, which is Proxyman-uuid. I intentionally added the suffix to prevent NSNetServicesCollisionError if we have multiple Proxyman apps in the same network.
Please try this beta build, I improve the Service Name to Proxyman-<host_name> as Bagel does. (I believe that hostname is unique for each machines in the same network, so there is no Collision Error anymore)
https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.26.0_Better_Bonjour_Service_Name.dmg

Quick update: tried that beta build, and got this as a service name:

Proxyman-ptr-4xa9d8d5k2butaudew8.18120a2.ip6.access.telenet.be

Whereas the laptop's name is MacBook-Pro-van-dieter-2, so no idea where it's getting that name. At first glance seems like a combination of ipv6 address and ISP (telenet).

@djbe can you clarify how you get this name? 🤔 It'd be great if we have a sample code that I can test out
I tested with Discovery app, which lists all available Bonjour services.

In the latest build, the hostname has a UUID as a suffix

In the beta build, it has a nicer name

hey @NghiaTranUIT it depends on the network it seems !  So you were right !!
On the network in the office I get right hostname

at home I get this

What @dieter115 forgot to mention was that the device name / hostname / ... when going to "Certificates > iOS > Atlantis" is correct. Is Proxyman using different code to set that service name (in the beta build) compared to that view?

In the beta build, I use Host().current.name, which returns a Host/Computer name in the network.
It's the same result when executing the following code on the Terminal app
$ hostname
Nghias-Mac-mini.local

Ref: https://developer.apple.com/documentation/foundation/host/1416949-name

I suppose that the hostname might be changed when you're using a corporate network? 🤔

I am excited to read that @dieter115 and @djbe found a way to bring Atlantis to Android. What's the progress on this work? Is there any plan to make this official? And if not, is there any way to profit of that work and get some code snippets? :)

We're also interested in Android support. What's really confusing is that the Proxyman repo README advertises Android, yet it is absent in Atlantis?

@sjmueller Atlants is written by Swift, so it only supports iOS, macOS, tvOS, watchOS.
Regarding the readme, it means Proxyman can capture from Android Devices (Without using the Atlantis Framework). Please check out this doc: https://docs.proxyman.io/debug-devices/android-device
For the Android Emulator, Proxyman also provides the automatic script to do the boring part for you (Override HTTP Proxy and install the certificate), ref: https://docs.proxyman.io/debug-devices/android-device/automatic-script-for-android-emulator

@messi Sorry for the late reply but we made it work and are using it in our Android projects. At the moment I haven't found a way to catch all the network traffic but I made something that works with Retrofit and Okhttp and sends the requests/responses to Proxyman. If you want I can put in on a seperate repo? If thats ok for @NghiaTranUIT .

Yes, please @dieter115 🥇 I will test again and link to your repo, so Atlantis-Android can work with Proxyman 🙌

@gtmn Atlantis is Open source, you can reimplement it in Android if it's possible.
I don't have plan to port to Android by myself, but I'm happy to accept the new PR or Repo.

yes, it's possible. Please share with me the Repo URL 👍

Hey Guys , sorry for the late response. Have been busy for the last year... I would like to make it public ... At the moment it only works with Retrofit.

It's awesome new @dieter115 👍 You can publish it on your own Repo, then we can refer it 👍

@NghiaTranUIT I did the initial commit on this repo https://github.com/dieter115/proxyman-atlantis-android/tree/main/app/src/main/java/be/flashapps/proxyman_atlantis_android. .


Initial/foundational code Pulling foundational files into master branch

The app will be built atop this initial commit to the master branch. This includes the elementary project structure and all dependencies for building the Electron app.

Initial commit so I hope self merge can be forgiven.


Download formatted tables as html, png, pdf, and docx

!! Package webshot2 needed to download as html, png, and pdf

@catalamarti  readyy


BUG: SparseSeries fastpath constructor buggy

Fastpath construction fails quite often. Although it's usually caught, the type is changed.
>>> type(SparseSeries([1,2,3]).iloc[1:2])
<class 'pandas.sparse.array.SparseArray'>
>>> type(SparseSeries([1,2,3]).ix[1:2])
<class 'pandas.sparse.array.SparseArray'>

Seems to be the reason for #10560.

not sure why this is an issue
can u show an example?

For Series we get back the same type:
>>> type(Series([1, 2, 3]).iloc[1:2])
<class 'pandas.core.series.Series'>
>>> type(Series([1, 2, 3]).ix[1:2])
<class 'pandas.core.series.Series'>

>>> concat([Series([1, 2, 3]).iloc[0:1], Series([1, 2, 3]).iloc[2:3]])
0    1
2    3
dtype: int64
>>> concat([SparseSeries([1, 2, 3]).iloc[0:1], SparseSeries([1, 2, 3]).iloc[2:3]])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/kawoc/pandas-kawochen/pandas/tools/merge.py", line 755, in concat
    copy=copy)
  File "/home/kawoc/pandas-kawochen/pandas/tools/merge.py", line 806, in __init__
    raise TypeError("cannot concatenate a non-NDFrame object")
TypeError: cannot concatenate a non-NDFrame object

well are the same issue then

hmm I suppose so, since that was the issue I was looking at.  I checked the history and the difference between SparseSeries's fastpath  and Series's fastpath seems deliberate (and tests do fail if I just make them the same), so I just wanted to point out SparseSeries hits paths that are not covered in tests, and we see things like SparseSeries([1,2,3]).iloc[0:3] and SparseSeries([1,2,3]).iloc[:] being different.

#10079 is also the same issue (construction doesn't error, .__repr__ does, but not for smaller frames)

@gfyoung hole host of issues w.r.t. sparse, note @sinhrks has recently fixed some of these

@jreback : Maybe I join the party here once I "finish" with fromnumeric.py.  Btw, I think scipy.sparse might be a useful resource in terms of getting ideas about functions, as they do a lot of their implementation in pure Python as well.

I don't think I made an issue for this, but we are open to taking sparse/array.py (and limited iinfrastructure), and making a pandas-sparse package to (that pandas would then depend). This would simplify the interface/API.

#12794 has been closed for some time now.

#667, #12794, #13001, and #13110 have all been closed for some time now.  Should all be checked off.


Footer link

Thank you for the Gatsby blog theme.
Looks like the link in the footer ©[sohee28](https://github.com/sohee28) is connecting to page 404.
The href link in 'src/components/footer/index.js' seems to be the problem.

@nueeng Thank you so much for finding it!! The link has been fixed. 😄


Update docs to new APIs

Description

The API of the data objects have been subtely changed for 0.3.  For example, the prefix SnS has been changed to sns in the sns method names.  These also need changing in the docs.

From a quick search, I can't find any reference to "SnS" by case anymore.


[1.11.2] Crash after placing Cake from storage system

Issue description:
After the ingame crash the server won't start anymore.
What happens:
The server crashed after a Constructor attempted to place a cake from the storage system.
What you expected to happen:
Constructor placing the cake into the game world.
Steps to reproduce:

Place a constructor downwards into the ground and correct its position ( to face towards the player) with the interaction wheel
https://minecraft.curseforge.com/projects/interaction-wheel?gameCategorySlug=mc-mods&projectID=256287

Set the item to be constructed by the constructor to a cake
3.
Place a cake into your storage system.
Version:

Minecraft: 1.11.2
Forge: 1.11.2 - <IP_ADDRESS>5
Refined Storage: Refined Storage 1.4.2

Does this issue occur on a server? -- Yes
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]
latest.log
https://pastebin.com/q5F8xyef
fml-server-latest.log
https://gist.github.com/Deylendor/66ebff1742ee2acc33463de6ae4b7500

This is a problem with com.minecolonies, please report the bug to them. You could also try updating Forge if you're not on the latest version yet, as I heard this bug is prevented with newer Forge versions.

I am running the latest forge.
I made the server playable by temporary setting
B:removeErroringTileEntities=false to true in the forge.cfg file.
I'll report this error to the Minecolonies team as well.
Thank you very much for looking into this for me. Was worth it to make a github account.


Change amount sent title

What it solves
Resolves #3254
How this PR fixes it
All instances of "Send 0 {{symbol}} to:" have been changed to "Interact with:" and "Send {{amount}} {{symbol}} to:" changed to "Interact with (and send {{amount}} {{symbol}} to):"
How to test it

Create/execute a contract interaction of 0 cost and observe the new title.
Create/execute a transaction of >0 cost and observe the new title.

Screenshots

Just saw the failing tests. Working on fixing them now.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 6 (83.33%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 32.477%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/routes/safe/components/Transactions/TxList/MultiSendDetails.tsx
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
3117

Relevant Lines:
8556

💛  - Coveralls

It looks good. I tested by checking safes with tons of tx.
Took a while but I found the "(and send X token)" message. Is very rare


Register TestParticleMakie

@TCLiuu, would you like to try registering TestParticleMakie v0.1? See the instructions here.

@JuliaRegistrator register subdir=TestParticleMakie/

Registration pull request created: JuliaRegistries/General/71170
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a -v0.1.0 -m "<description of version>" acdfd8560a640893c00f547853315f0d4898312d
git push origin -v0.1.0

There are some issues to be fixed. See the link above.

@JuliaRegistrator register subdir=TestParticleMakie

Registration pull request updated: JuliaRegistries/General/71170
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a TestParticleMakie-v0.1.0 -m "<description of version>" acdfd8560a640893c00f547853315f0d4898312d
git push origin TestParticleMakie-v0.1.0

@JuliaRegistrator register subdir=TestParticleMakie

Registration pull request updated: JuliaRegistries/General/71170
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a TestParticleMakie-v0.1.0 -m "<description of version>" c3e6b9ce50dfa9693f760a94bb22214e5f0dd49c
git push origin TestParticleMakie-v0.1.0

There are some issues to be fixed. See the link above.

There should be no slash at the end of the "subdir" keyword. : (


Remove dependency on mock from install requirements since it enforces…

Remove dependency on mock. It's not required to run the client in production and enforces a version that might conflict with client project

Reviewers:

[ ] @mention

What's the purpose of the PR?

Description of changes

Notes to reviewers

Keep in mind while reviewing code:

Is relevant code tested?
Are added functions/methods documented?
Separation of concerns (SOC)
Don't repeat yourself (DRY)
Limit the number of positional arguments
Is function/method length reasonable?
Can code be broken down into smaller components?
Where do added functions/methods belong?
Are variable names descriptive?
Are errors handled appropriately?
Can logic be simplified?
Does the code make sense in context? (expand the diff)

Resolved by recent merge that moved mock to tests_require dependency.


Automated cherry pick of #947: support add pid file

Cherry pick of #947 on release/2.8.0.
#947: support add pid file

/lgtm
/approve


Added small display on mouseover to check pokemon ID

Added a small display on mouseover to check pokemon ID to clear up confusion on some pokemon which are hard to distinguish like Kadabra or Alkazam. A name would be too long for the div.

How would it work with mobile?

I'm pretty sure it doesn't work on mobile, as :hover needs a pointing device. However, I don't think it's too bad not to have this on mobile, as it could put too much stuff on the UI.

Thanks for the input, as another person pointed out, we aim to provide the same experience for both Desktop and Mobile users.
Keep in mind 87% of the user base (about 1M+ users) are mobile users only, so if you can find a way to make this change also benefit the mobile users, it would be great.

Thanks for the feedback, I might be able to work out a solution for mobile. However, I'm not sure if I can debug it, as Leaflet seems to be unresponsive when running the website in device mode in chrome.

Yea the dragging doesn't work on Developper mode, most of the developpment is done in theory and just tested on a device.

Would it be possible to implement that feature with an onclick event for a sprite with the class "pokeimg"? That way I believe it should work on both desktop and mobile.

I thought about that too, but I'm not sure if it would interfere with placing the marker

It would work but you need to stop propagation of the event. If you make a working code i'll push it to repo then apply to live.

This should work on both mobile and desktop. I don't quite have the tools to test it, but it seemed valid when trying in developer console device mode.
If I find some time, I might tend to work on a bigger scale solution, effectively displaying a tooltip on click which would be scalable to allow display of details like lat, lng, name and ID without being restricted by the width.

Looks good, i'll review code then apply it to test in staging by tomorrow, thanks!


PrePassRenderer sometimes does not render geometry with alpha blending

Repro

Bug repro on playground:
Expected result: Correct SSR reflections
Current result: Not correct reflections

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Geometry of the reflective plane is not rendered at all in PrePassRenderer when it has an alpha value < 1.

Closing as it will be taken care of with #13003


Jwilaby/debugging doc

Related to #1443 - This PR provides:

A general purpose Markdown Renderer page
A new help menu item for getting started with debugging your bot via channels
A link on the Welcome page (when in sidecar debug mode) to the same help document

To test:
Checkout the branch and change this line to use https://raw.githubusercontent.com/Microsoft/BotFramework-Emulator/jwilaby/debugging-doc/content/CHANNELS.md
note The images in the current document do not render (non-standard MD). This document is a placeholder and will change once we engage with the documents team.

Coverage decreased (-0.08%) to 56.856% when pulling 43ab511073b0b5346abb8c25535fdb7582b762b3 on jwilaby/debugging-doc into cf9f0e8bc7881c39d7fa79da05403e7cb55a5609 on master.

It looks like the Bot Inspector heading got bumped to the right a bit. It was flush with the other headings.
@mewa1024 and I discussed adding the link in the area where the My Bots box lives in Emulator mode. Though right next to the (BETA) label it seems a more discoverable.

So we’re not displaying the sidecar doc as it’s own tab, similarly to VS Code’s Release Notes (Help > Release notes)?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Chris Whitten<EMAIL_ADDRESS>Sent: Thursday, April 25, 2019 12:07:38 PM
To: Microsoft/BotFramework-Emulator
Cc: Melanie Wang; Mention
Subject: Re: [Microsoft/BotFramework-Emulator] Jwilaby/debugging doc (#1463)
It looks like the Bot Inspector heading got bumped to the right a bit. It was flush with the other headings.
@mewa1024https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmewa1024&data=01|01|mewa%40microsoft.com|f9528e4907d24a18c14e08d6c9b1496d|72f988bf86f141af91ab2d7cd011db47|1&sdata=07i2EAZYwG7JyDdKsg7C%2BLYIxtLNkykexZd2F3Mr8NY%3D&reserved=0 and I discussed adding the link in the area where the My Bots box lives in Emulator mode. Though right next to the (BETA) label it seems a more discoverable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FBotFramework-Emulator%2Fpull%2F1463%23issuecomment-486800422&data=01|01|mewa%40microsoft.com|f9528e4907d24a18c14e08d6c9b1496d|72f988bf86f141af91ab2d7cd011db47|1&sdata=FkyC8gi0u8DGIyYSSWLteEHtinZsJ0aYHqPyQxIicOs%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJL7AJWOFPGSAIHODEOFYUTPSH6PVANCNFSM4HIPYPBQ&data=01|01|mewa%40microsoft.com|f9528e4907d24a18c14e08d6c9b1496d|72f988bf86f141af91ab2d7cd011db47|1&sdata=d0EtIhNWr5f9kvIOSrRiyQVWGXX4mCNib52U%2FOlE%2B%2Bg%3D&reserved=0.

@mewa1024 From the first screenshot it appears to belong to its own tab:

@justinwilaby I just noticed, you probably want to go to this function, get iconClass() inside of tab.tsx and add the document id for your docs page as a case right above welcome-page so that the icon for that doc tab defaults to the BF icon.

So we’re not displaying the sidecar doc as it’s own tab, similarly to VS Code’s Release Notes (Help > Release notes)? Get Outlook for iOShttps://aka.ms/o0ukef
…
________________________________ From: Chris Whitten<EMAIL_ADDRESS>Sent: Thursday, April 25, 2019 12:07:38 PM To: Microsoft/BotFramework-Emulator Cc: Melanie Wang; Mention Subject: Re: [Microsoft/BotFramework-Emulator] Jwilaby/debugging doc (#1463) It looks like the Bot Inspector heading got bumped to the right a bit. It was flush with the other headings. @mewa1024https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmewa1024&data=01|01|mewa%40microsoft.com|f9528e4907d24a18c14e08d6c9b1496d|72f988bf86f141af91ab2d7cd011db47|1&sdata=07i2EAZYwG7JyDdKsg7C%2BLYIxtLNkykexZd2F3Mr8NY%3D&reserved=0 and I discussed adding the link in the area where the My Bots box lives in Emulator mode. Though right next to the (BETA) label it seems a more discoverable. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FBotFramework-Emulator%2Fpull%2F1463%23issuecomment-486800422&data=01|01|mewa%40microsoft.com|f9528e4907d24a18c14e08d6c9b1496d|72f988bf86f141af91ab2d7cd011db47|1&sdata=FkyC8gi0u8DGIyYSSWLteEHtinZsJ0aYHqPyQxIicOs%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJL7AJWOFPGSAIHODEOFYUTPSH6PVANCNFSM4HIPYPBQ&data=01|01|mewa%40microsoft.com|f9528e4907d24a18c14e08d6c9b1496d|72f988bf86f141af91ab2d7cd011db47|1&sdata=d0EtIhNWr5f9kvIOSrRiyQVWGXX4mCNib52U%2FOlE%2B%2Bg%3D&reserved=0.

Yes we are, take a look at the first screenshot. Chris was commenting about the placement of the link to that tabbed document next to the (BETA) text

@cwhitten I was thinking the sidecar doc would be more like this and that we could leave the Welcome page as is:

@mewa1024 Recall our discussion that much of the Welcome Page interactions are specific to both .bot files and Emulator mode. We decided that hiding these elements was the right thing to do and replacing it with a link that would open up documentation in a new tab (like VSCode) on how to get started in the debug mode. I don't think we should mix product functionality (Open bot) with reference material in this sense. This is living, editable documentation that is markdown. This is how VSCode does their release notes & their tabbed material via their help menu. We can start doing the same.


Save Points

As a player, I want to save my progress and continue from certain locations after I die or quit.

Will not implement for now


doc: translate 'YouWillLearn' component title

Translate the titles for YouWillLearn component

@galnir can you please review?

I've taken a look at other languages repos and they don't seem to translate MDX components
Also the React team hasn't said anything about these components so we'll stick to the pages


results is not expected

Sorry to disturb.
I've downloaded the code and it runs well. But after 100 epochs even 200 epochs, the accuracy seems always around 50%. So I increase the batch size to 16 or try different optimizer but the best accuracy is 80%.
Could you give me some advice? Really Thanks for you code.

@BlankAix I got you. Maybe you can clear the former model and run it again.  I'm too busy these days for my final year project. I will see whether I can do something if I have some spare time.

发现你也是中国人，2333。你先忙你自己的事，我这边自己努力调下参数，但如果你不介意的话可以将你跑完的权重上传到项目吗？谢谢回复~祝你顺利毕业。

@BlankAix GitHub 上传下载比较慢，我传个百度云链接给你吧一会，不过好长时间没碰了，我也不知道结果啥样。

@BlankAix 留个邮箱吧，我把 checkpoint 百度云链接发给你

@GeneralLi95<EMAIL_ADDRESS>。十分感谢~

笑死了在这里hhh


feat: Cortex supports Vulkan?

Problem
I couldn't run Cortex on AMD GPUs yet
Success Criteria
Cortex pulls the corresponding engine, which is optimized for AMD GPUs.
Additional context
Add any other context or screenshots about the feature request here.

Updated: ROCM is already being tracked on another issue.


Update scalafmt-core to 2.1.1

Updates org.scalameta:scalafmt-core from 2.1.0 to 2.1.1.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: semver-patch

Codecov Report

Merging #1295 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1295      +/-   ##
==========================================
+ Coverage   85.91%   85.99%   +0.07%
==========================================
  Files          74       74
  Lines        2535     2535
  Branches      108      108
==========================================
+ Hits         2178     2180       +2
+ Misses        357      355       -2

Impacted Files
Coverage Δ

...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala
91.66% <0%> (-8.34%)
:arrow_down:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
91.56% <0%> (-1.21%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Encoder.scala
85.93% <0%> (+0.78%)
:arrow_up:

...les/core/shared/src/main/scala/io/circe/Json.scala
79.39% <0%> (+1.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76326b...407db81. Read the comment docs.


batch mark/unmark file as viewed silently fails for large file sets

Extension version: 0.58.1
VSCode Version: 1.75.1
OS: macOS Ventura 13.1

Steps to Reproduce:

Open a pull request containing 300+ file changes in a single folder
Click the checkbox on the folder to mark all 300+ files as viewed

There will be error logs in the console and if you reload the editor or view the PR on github.com you'll see that not all files were marked as read

I suggest adding support for marking/unmarking a set of files as viewed so that's its a single API call instead of what I think is being done through lots of tiny calls.

This one looks fun. Mind if I take a look @alexr00?

Sure, thanks @joshuaobrien. Here's where we respond to the checkbox state change and mark the file as viewed. It's exactly as @mfulton26 suggested: if you mark 300 files as viewed we're calling the GitHub API 300 times.
https://github.com/microsoft/vscode-pull-request-github/blob/a42163688c6f82bf5fb3aa5781a25cbe62dbbb30/src/view/treeNodes/fileChangeNode.ts#L188


Standalone app example terminates immediately

I start examples/standalone_app.py but it terminates right after the start. The only print out I have in terminal is
remi.server      INFO     Started httpserver http://<IP_ADDRESS>:7769/

So, I had a little debug session and found out these lines:
Server.start(self)
webview.create_window(self.title, self.address, **self._application_conf)
Server.stop(self)

As you can see, Server class starts, then webview window is created and right after that Server stops. I think a line webview.start() was missed, so it should be like this:
Server.start(self)
webview.create_window(self.title, self.address, **self._application_conf)
webview.start()
Server.stop(self)

Am I right?

@mrdimfox Thank you a lot, you are right! I will fix this rapidly.

Fixed ;-)
The fix is only available on github master branch. I will make a release in a near future.

@dddomodossola, awesome! Thanks!


fix bug on pre for mail icon

Correct pre for mail should be "mailto:" without ending with "//"
mail:
  pre: "mailto:"

Ah, this looks good! Glad you noticed the change, since if you click that, it would redirect you to an URL, not to your email client of choice.

Can you try clicking the Gitpod SVG and check if the build works successfully?
PS: Log in with GitHub.

Thanks for the PR, I'll take a look 😄

Nice thanks 👍

Can you try clicking the Gitpod SVG and check if the build works successfully? PS: Log in with GitHub.

I went for a sleep after putting up the PR and a night later it was merged already. You guys are fast :D
I’m not familiar with how the GitPod shall end up. I got the last part shown in the terminal as below
….
Using type-on-strap 2.3.8 from source at `.`
Bundle complete! 1 Gemfile dependency, 32 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
Configuration file: /workspace/SiewLinYap.github.io/_config.yml
            Source: /workspace/SiewLinYap.github.io
       Destination: /workspace/SiewLinYap.github.io/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
       Jekyll Feed: Generating feed for posts
                    done in 0.788 seconds.
 Auto-regeneration: enabled for '/workspace/SiewLinYap.github.io'
    Server address: http://<IP_ADDRESS>:4000/Type-on-Strap/
  Server running... press ctrl-c to stop.
[2021-11-08 23:20:06] ERROR `/robots.txt' not found.

That means it worked. Gitpod is a quick IDE and I thought of using that for checks till the CIs were sanctioned. But anyway, thanks!


Ethan: Watch themakerpoint.com

Ethan requests the watch of the watch_keyword themakerpoint\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

themakerpoint\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Cody Gray in Charcoal HQ