Are JavaScript modules compiled or run natively?

When creating a new playground with JavaScript modules, it's creating a .js files. This usually suggests that the module syntax is bundled or compiled away (e.g. to CommonJS). I tried to rename to .mjs but that seems to have broken execution. Is there are way to use uncompiled modules / .mjs files?

Hey! We’re not doing any bundling in order to support modules. We’re simply setting the script’s type attribute to “module”. So if you import other modules, they’d need to either be 1) a relative URL to another file in the same gist, or 2) an absolute URL that points at a JS module (e.g. using a CDN like Unpkg).
Right now, a playground determines if it should use modules based on the scriptType property in its way playground.json file. That said, I can also add supoort for .mjs files as well. Do you think that the JS-only module template should generate an .mjs file? Would that be the more accurate solution?

Do you think that the JS-only module template should generate an .mjs file? Would that be the more accurate solution?

I'd personally find that more clear / easier to tell apart at first glance. But I think my primary concern would be that I  can safely rename it to .mjs without breaking the playground. If that is supposed to work, it could also be that I messed up at some point while trying out this plugin (which is great, btw!).

Sounds good. I’ll make this change so that when you create a new playground for a JS module, that it creates a “.mjs” file by default. Look out for that change later today 👍

Just shipped an extension update that includes this fix. Let me know if you run into any other problems. Thanks for the feedback!


CARDS-1879: Add a 'Last modified' column to CSV export

CARDS-1879
To test:

Create some forms

go to http: localhost:8080//Questionnaires/<Questionnaire name>.csv (or: in the Administration > Questionnaires, click on a questionnaire name, then remove from that url /content.html/admin and add .csv at the end)

Expected:
A CSV file will be offered to download with a new 'Last modified' column after 'Created' in ISO datetime format without timezone yyyy-MM-ddTHH:mm:ss.

I just realized that "Created" is exported with timezone, contrary to the original specs. For consistency, I've removed the requirement to drop the timezone from the description of CARDS-1879.


Add LinearResistance equation test

Fixes part of https://github.com/Deltares/Ribasim/issues/206. I'm giving the feature branch a try.

I'm giving the feature branch a try.

How should this be used, is this part of a series of PRs you want to do on the linear_resistance branch? This looks good to merge onto main, but how do we get it there?

How should this be used, is this part of a series of PRs you want to do on the linear_resistance branch? This looks good to merge onto main, but how do we get it there?

The idea was to make a PR to the [Test-node-equations-feature](https://github.com/Deltares/Ribasim/tree/Test-node-equations-feature) branch for every node type / equation, and then merge to main once all equations are done. I see that that is not necessary in this case (it would have been nice for the PID control branch I think).

This looks good to merge onto main, but how do we get it there?

@SouthEndMusic For the future, the target branch of a PR can still be changed after the PR has been opened :)


Use total "applied" and "failed" user commands from summary endpoint for middle metadata number on table

Blocked by https://github.com/Granola-Team/mina-indexer/issues/1204


Rename F-beta score

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2360b4d) to head (c842ae0).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #309   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          100       100
  Lines         2411      2411
  Branches       214       214
=========================================
  Hits          2411      2411

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


IAR: Fix spurious newline after time in JUnit output.

Remove the newline character after the date and time in the JUnit output on IAR platform.

Coverage remained the same at 99.874% when pulling 75b33e9396cf65512d56313e80f291077bebbeb3 on CFlix:iarTimeNewlineFix into 2b45d38c5c3dd71447bfe0ae993786a6da898658 on cpputest:master.


Use Show to provide Exception message for DecodingFailure

Overview
I'm proposing that getMessage in DecodingFailure be changed to use the showDecodingFailure implementation so as to improve the readability of stacktraces generated by decoding failures.
If this change is welcome I am happy to submit a PR.
Current situation
DecodingFailure provides showDecodingFailure, which provides a compact, human-readable representation of a decoding failure. In particular, it makes it relatively easy to identify where in a document the cursor has failed.
By contrast, the overridden getMessage method returns a much less descriptive message, using the bare toString for CursorOp. Because this message is included in the stacktrace for DecodingFailure, in my experience it is much more likely to end up in logs.
For example, compare the following (from a project I'm working on):
DecodingFailure at [3].stateBranches[3].prominentPartyId: [A]Option[A]

versus
DecodingFailure([A]Option[A], List(DownField(prominentPartyId), MoveRight, MoveRight, MoveRight, DownArray, DownField(stateBranches), MoveRight, MoveRight, MoveRight, DownArray))

Oh it looks like there's already a PR for this #1316.


support extracting filesystem from kyocera printer firmware

Hi,
I am trying to extract a kyocera printer firmware.
Running binwalk -e on the firmware file returns the following results:
DECIMAL       HEXADECIMAL     DESCRIPTION
--------------------------------------------------------------------------------
15917         0x3E2D          Zlib compressed data, default compression
13812163      0xD2C1C3        mcrypt 2.5 encrypted data, algorithm: "", keysize: 27369 bytes, mode: "M",
26231768      0x19043D8       LZMA compressed data, properties: 0x63, dictionary size: 16777216 bytes, uncompressed size: 2883884 bytes
26632662      0x19661D6       MySQL ISAM compressed data file Version 1
28384990      0x1B11EDE       YAFFS file system, big endian

binwalk extracts the a file 3E2D.zlib from 0x3E2D to the end of the file and uncompresses it to a file 3E2D. strings 3E2D shows many familiar strings belonging to ELFs and other files (static assets for the webinterface).
binwalk -e 3E2D results in > 10GB of .7z files
output:
30629505      0x1D35E81       LZMA compressed data, properties: 0x76, dictionary size: 16777216 bytes, uncompressed size: 803209216 bytes
30629825      0x1D35FC1       LZMA compressed data, properties: 0xB6, dictionary size: 16777216 bytes, uncompressed size: 266403840 bytes
30631305      0x1D36589       LZMA compressed data, properties: 0x7E, dictionary size: 16777216 bytes, uncompressed size: 467992576 bytes
....

the uncompressed size is unrealistic so these must be false positives.
To exclude these I run binwalk -e -x 'lzma compressed data' 3E2D.
This shows a VxWorks WIND kernel version "2.9", various ELFs, Unix Paths and other files, including a
31559244      0x1E18E4C       Linux EXT filesystem, rev 0.0, ext2 filesystem data (mounted or unclean), UUID=00000000-0000-0003-cce2-000234bb34bb

entry quite in the beginning. The extracted file 1E18E4C.ext contains many interesting strings belonging to cgi ELFs and static web assets.
Any ideas on how to properly extract this filesystem / what kind of filesystem this is?
The firmware zip can be downloaded here:
https://mega.nz/#!bxg1QLrC!SnEZm4xUHeGmpRVP9CuzYWtXYVHS3PH7FPFv4K7A9d0
Edit: This probably isn't an ext2fs but something in the direction of Fat16.
Maybe this helps:
^@^@^@^A`Aÿ^@^@<94>\¾wÀF¼wÿÿÿÿ^@^@^@^@^@^@^@^@^@^@^@^V^@^@^A`^@ÐîÄ^A^A.^@^@ÐÇø^A^B..^@ÐðH¶^Kversion.htm^@^@^@^@ÐóL¶^Gtop.htm^@^@^@^@ÐúÔ¶        index.htm^@^@Ñ^H<8c>¶^Kfavicon.ico^@^@^@^@Ñ^L0ÿ^Cadv^@^@^@^@ØØ¬ÿ^Ebasic^@^@Û|(ÿ^Ccss^@^@^@^@ÛÍ<9c>ÿ^Cdeu^@^@^@^@ÛÒ ÿ^Cdut^@^@^@^@Û×¤ÿ^Ceng^@^@^@^@ÛÜ¨ÿ^Eerror^@^@Ûátÿ^Cesp^@^@^@^@Ûæxÿ^Heventlog^@^@^@Ü^F<98>ÿ^Cfra^@^@^@^@Ü^K<9c>ÿ^Fimages^@Ü¤Äÿ^Cita^@^@^@^@Ü©Èÿ^Cjob^@^@^@^@ÝF8ÿ^Cjpn^@^@^@^@ÝK<ÿ^Bjs^@ßH¸ÿ^Dmail^@^@^@ßm´ÿ^Dopt1^@^@^@ßr¼ÿ^Gprinter^@^@^@^@à^G^\ÿ^Crus^@^@^@^@à^L ÿ^Estart^@^@ã6 ÿ^Gstrings^@^@^@^@^@^@^@^@^@^BÞ<81>¶^@^@<94>\¾wÀF¼wÿÿÿÿ^@^@^@^@^@^@^@^@^@^@^@^V^@^@^Bà^M
^M
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">^M
<meta http-equiv="Content-Style-Type" content="text/css">^M
<title></title>^M
<link rel="stylesheet" href="css/main.css">^M
^M
^M

Kyocera Command Center
^M

^M

^M
Target : 2GR^M

^M
Template Version : 006053001^M

^M
Specification Version : Not Modified^M

^M

^M
ä¸»ã<81>ªæ<9b>´æ<96>°å<86><85>å®¹^M

^M

Local Navigationã<81><8c>IE5.5ã<81>§æ£å¸¸ã<81>«å<8b><95>ä½<9c>ã<81><97>ã<81>ªã<81><84>ã<81>®ã<82><92>ä¿®æ£
^M

^M
å<88>¶é<99><90>äº<8b>é <85>^M

^M

ã<81>ªã<81><97>
^M

^M
^M
^M
^@^@^@^@^Gb<81>¶^@^@<94>\¾wÀF¼wÿÿÿÿ^@^@^@^@^@^@^@^@^@^@^@^V^@^@^Gd^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
^M
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">^M
<meta http-equiv="Content-Style-Type" content="text/css">^M
<meta http-equiv="Content-Script-Type" content="text/javascript">^M
<title></title>^M
^M
^M
<form>^M
^M
<input type="hidden" name="FileName" value="">^M
</form>^M
^M
^M
^@^@^@^@^M<94><81>¶^@^@<94>\¾wÀF¼wÿÿÿÿ^@^@^@^@^@^@^@^@^@^@^@^V^@^@^M<94>^M
^M
^M
^M
^M
^M
^M

First there is a listing of files and directories
(I found this list of directories in the http server config file:
/start/
/basic/
/printer/
/scanner/
/job/
/box/
/adv/
/deu/index.htm
/dut/index.htm
/eng/index.htm
/esp/index.htm
/fra/index.htm
/ita/index.htm
/jpn/index.htm
/rus/index.htm
/opt1/index.htm
/fax/
/mail/
/top.htm
/index.htm
/eventlog

After that index table, the file data of the listed files (version.htm, top.htm, index.htm) seem to follow.

I don't get the LZMA false positives that you do; your system probably doesn't have the python-lzma module installed which binwalk uses to further validate LZMA signatures.
All the file system results are almost certainly false positives. As binwalk suggests, this firmware is VxWorks based, not Linux. Although VxWorks supports some file systems, my experience with it is that there are typically no file systems (your suggestion of FAT16 is possible), at least not as most people would think of them. There are often just some basic data structures with file names, pointers to the file data, and a size field to specify the file size. These are usually used for storing HTML data for the web interface, as the file paths and names that you posted suggest.
I did notice an unusual number of ELF files for a VxWorks image, but they are valid ELFs complete with symbol tables, and looking at the strings and function names they are VxWorks specific. AFAICT, these are VxWorks executables, probably intended to be executed by a user from some command line interface (UART, telnet, ssh, etc).
The main code though is the VxWorks kernel, which appears to be the decompressed 3E2D file. Both 3E2D and the main firmware image contain big endian PowerPC code (according to binwalk -A), and may or may not contain symbol tables or other helpful information to aid in disassembly  / reverse engineering. These are typically blobs of code and data mashed together, so you'll need to identify where code ends and data starts (binwalk -A can help point you in the right direction), as well as the code load address in order to get a readable disassembly.

I don't get the LZMA false positives that you do; your system probably doesn't have the python-lzma module installed which binwalk uses to further validate LZMA signatures.

I just installed python-backports-lzma and was able to from backports import lzma. However, binwalk still shows the false positive lzma matches. Using python3 it doesn't. Maybe this is a bug that should be fixed.
As the device supports a huge number of protocols (SNMPv3, Netware, AppleTalk, NetBEUI, Raw Printing, IPP, IPPS, HTTP/HTTPS, FTP, SNMP, POP3, SMTP, LPD, WSD, IPSec, 802.1x), a larger count of ELFs seems reasonable to me. I will maybe investigate into the processor model to find information about the load address later on, the symbol tables being intact is a positive find. Regularly, there is no cli access to users.
Is it quite certain that everything is baked into the kernel? It would be a bit easier to investigate separated files/modules if it was possible to extract a usable filesystem.

I just installed python-backports-lzma...binwalk still shows the false positive lzma matches. Using python3 it doesn't. Maybe this is a bug that should be fixed.

Binwalk expects the module to be named lzma, not backports.lzma. Most Linux distros have a python-lzma package for Python2; it is a standard module in Python3, which is why you don't get the LZMA false positives in Python3. I've updated the master branch to check for backports.lzma, so that should be fixed now.

a larger count of ELFs seems reasonable to me.

Well, bear in mind when I say "larger" I mean there are 5 or 6 ELF files. Usually with VxWorks I've only seen one ELF file, which was for the decompression stub, so it was not part of the main VxWorks OS.

the symbol tables being intact is a positive find

The symbol tables for the ELF files are intact, but I didn't immediately see a symbol table for the main OS.

Regularly, there is no cli access to users.

I did a very brief disassembly of some of the ELF files, and some have command line usage strings and getopt style strings in them, so they do take command line options. Could just be for developer debug access via a serial port or something though.

Is it quite certain that everything is baked into the kernel? It would be a bit easier to investigate separated files/modules if it was possible to extract a usable filesystem.

It would be a lot easier, but unfortunately that's usually how Real Time Operating Systems (like VxWorks) work: the OS is typically one big kernel running in a flat memory space (there is no user space or user applications). With that said, some RTOS's support user space protected code execution, but I'm not sure how that would work in VxWorks.

Thanks for your input! I will close this for now.

It's backports.lzma on Fedora, probably on other Red Hat systems as well.


The Default template is not accessible enough for Screen Reader users

From @Flameborn on April 4, 2017 10:17
Currently, Caddy-FileManager's default template does not provide enough information to screen readers.
For example, in the file list, folders or files are not marked up properly as a link or a clickable element. Items are presented as DIV elements. Without proper ARIA markup, screen readers see this as standard text and are unable to click on any item to navigate to the selected folder, or download a file. Keyboard users are also unable to focus these items via the tab key.
The easiest solution is to use standard links, or if this is not possible due to styling, ARIA roles. See this article: https://www.marcozehe.de/2013/04/24/easy-aria-tip-6-making-clickables-accessible/
Screen reader support can be tested via VoiceOver under MAcOS and iOS, (cmd+f5, settings/general/accessibility/VoiceOver) or with the open source NVDA https://www.nvaccess.org under Windows.
Copied from original issue: hacdias/filemanager-old#80

Hello @Flameborn! You're right. Unfortunately, I can't to this right now because I'll be some time away from home. But if you have got some spare time, you could make a Pull Request if you want 😄

Just reviewed the whole HTML code and added the roles and ARIA markup wherever I thought it was needed. I'll close this. If you find something that should be improved, just file an issue or make a PR 😄

Thank you very much!

On 2017. Aug 4., at 17:37, Henrique Dias<EMAIL_ADDRESS>wrote:
Just reviewed the whole HTML code and added the roles and ARIA markup wherever I thought it was needed. I'll close this. If you find something that should be improved, just file an issue or make a PR 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/hacdias/filemanager/issues/131#issuecomment-320280863, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6x8FgQjat2zLIR75FAy_DJD4M-XJI5ks5sUzqugaJpZM4Obak_.


A few environment vars are undocumented

I've noticed that many of the environment variables listed when doing a buildkite-agent start --help are not documented here: https://buildkite.com/docs/guides/environment-variables, although the ones I've tried can be queried in the build step.
A useful one is BUILDKITE_BUILD_PATH
BUILDKITE_AGENT_CONFIG
BUILDKITE_AGENT_DEBUG
BUILDKITE_AGENT_DEBUG_HTTP
BUILDKITE_AGENT_ENDPOINT
BUILDKITE_AGENT_META_DATA
BUILDKITE_AGENT_NO_COLOR
BUILDKITE_AGENT_PRIORITY
BUILDKITE_AGENT_TOKEN
BUILDKITE_BOOTSTRAP_SCRIPT_PATH
BUILDKITE_BUILD_PATH
BUILDKITE_HOOKS_PATH
BUILDKITE_NO_AUTOMATIC_SSH_FINGERPRINT_VERIFICATION
BUILDKITE_NO_COMMAND_EVAL
BUILDKITE_NO_PTY

Hey, thanks for the heads up. Some of these are designed to help the agent communicate with the bootstrap.sh script, but we should probably document them in a different section of the doc (as long as they're not internal / expected to change).

Yes, you could do a review of what buildkite-agent start --help puts out and decide on what you want to have public. I personally had a need to figure out the relative path from $BUILDKITE_BUILD_PATH where the repo src code is located. I ended up using this
SRC=`pwd | sed 's|'$BUILDKITE_BUILD_PATH'/'$BUILDKITE_AGENT_NAME'/||'`

Hey @gittycat! 👋🏻It took us a while, but we've finally done a big update to the env vars doc 😄There was also a recent agent update that cleaned up a bunch of the vars it was displaying too, so everything should be covered now.


darwin: binaries produced by writeHaskell are killed on startup

$ nix-build -A tests.writers.simple.haskell
$ ./result
Killed: 9

log stream shows:
2021-08-04 15:26:27.237786+0200 0x431a     Default     0x0                  746    taskgated: (Security) [com.apple.securityd:security_exception] UNIX error exception: 3
2021-08-04 15:26:27.238090+0200 0x431a     Default     0x0                  746    taskgated: no signature for pid=97538 (cannot make code: UNIX[No such process])

I suspected code signing at first, but this is x86_64-darwin and thus shouldn't be an issue. In the Nix on macOS channel on Matrix, someone suggested it may be a malformed Mach-O binary, Is there maybe something happening in fixupPhase by default we are missing here in the writer derivation?
I'd appreciate help from @NixOS/darwin-maintainers here since I can't figure this out.
 - system: `"x86_64-darwin"`
 - host os: `Darwin 17.7.0, macOS 10.13.6`
 - multi-user?: `no`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.3.10`

Can confirm.
 - system: `"aarch64-darwin"`
 - host os: `Darwin 20.5.0, macOS 11.4`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.4pre20210707_02dd6bb`

Note: used --argstr system x86_64-darwin for that.

I'm getting the following error message when running tests.writers.simple.haskell
taskgated	MacOS error: -67062
taskgated	cannot open file at line 44595 of [02c344acea]
taskgated	os_unix.c:44595: (2) open(/var/db/DetachedSignatures) - No such file or directory

Which means
❯ security error -67062
Error: 0xFFFEFA0A -67062 code object is not signed at all

What architecture and macOS version is that?

The problem is that writers use runCommand, which uses buildCommand, which doesn't use the phases so signing doesn't happen.

The problem is unrelated to signing, but I do get the impression that we are missing some darwin specific fixupPhase hook.


Minor revision management

Discuss at Feb 2021 meeting
Provided an incremental change is published, one that does not change anything critical (judgement), is there a need to revise any part of the version? Is there a need to manage an archive of previous?
What kind of a change does require a visual version indication? What kind of a change requires a archive tracking?

Wrote a wiki article explaining the revision management concept we discussed in committee.
https://github.com/IHE/publications/wiki/Revision-Management


1.4.7 Log In to the new Instance

you should explain that the IP@ used to connect the new instance comes from the return of command  "nova show instance"

fixed with commit b4ae87e


☂ Improve Accessibility Features

Improve Accessibility Features
Description
We need to enhance the accessibility features of our React Native Multi-TV App to ensure it's usable by people with various disabilities. This will involve adding proper aria labels, ensuring correct tab order, and implementing high-contrast mode.
Tasks

[ ] Add appropriate labels to all interactive elements . Assigned to @Neha
[ ] Implement a high-contrast mode theme. Assigned to @Neha
[ ] Ensure proper focus management and tab order across all platforms
[ ] Test the app with screen readers on different platforms (Android TV, Fire TV, tvOS, Web) @Neha
[ ] Document accessibility features and usage in the README

Expected Outcome
The app should be fully navigable and usable with a screen reader and keyboard/remote control only. All important elements should have clear, descriptive labels.
Resources

React Native Accessibility
WCAG Guidelines

Hello @giolaq , I would like to pick the following tasks:

Add appropriate labels to all interactive elements
Implement a high-contrast mode theme
Document accessibility features and usage in the README : I will update for theme

thanks

Great!

@giolaq for high-contrast mode theme would there be a UI element to switch between light and dark or it would be based on the device settings?
What is expectation for Document accessibility features and usage? Is it document like :

Screen reader support, and how to enable?
Themes, etc.

IMHO the simplest way is to add a "Settings" screen accessible from the left side drawer where the user can access these features and enable/disable. Best option will be associate these to the device settings, but this it's much more complex as different TV OSs will have different way to enable it.
For the documentation, you can add an ACCESSIBILITY.md and link it to the README, what do you think?

I will add the "change theme" in settings.
Any reason for creating ACCESSIBILITY.md? Can't we reuse README?
We can add a section ACCESSIBILITY section and add all accessibility information under that.

Ok, if it becomes too big we can move it to another file

While working on this issue, I found that the d-pad is not working on Android emulator (the config I am using). I will investigate it more with this issue. I have did a test on Web and app is working fine.
@giolaq you can assign me this too (as I am already testing all 2-3 platforms) "Test the app with screen readers on different platforms (Android TV, Fire TV, tvOS, Web)"

Hi @Neha any updates on these tasks? Hacktoberfest is finishing on 31st, maybe we can release some task for other people to pickup

Hey @giolaq , I am not able to run the app's navigation on android emulator. I will work on this issue. Meanwhile, if someone wants to pick it up, you can can remove the task from my name

@giolaq for theme switcher, what is your thought on adding the theme switcher in the left navigation? The reason is to have the theme switcher in just one click away. It is a good UX experience.

Usually the TV apps have only options related to content, profile or navigation in the main screen. While the theme switcher is a good UX in the front page of a website, for TV apps such a switcher will add more noise to to UI.
Best option is to automatically get the theme setting value from the OS ( when is possibile ) and provide a switcher in the Settings menu or screen.

@giolaq , My suggestion is to break the tasks into separate issues.
These could be separate issues:

Implement a high-contrast mode theme
Ensure proper focus management and tab order across all platforms
Add appropriate labels to all interactive elements

Document accessibility features and usage in the README (this should be the subtask of all the above issues).
What is the end goal of this task? Test the app with screen readers on different platforms (Android TV, Fire TV, tvOS, Web)
lmk wyt

That's why it's an Umbrella Issue with task associated and you have 3 assigned.
You can create the PR related to a task and when is merged we link it to that.
"Test the app with screen readers on different platforms (Android TV, Fire TV, tvOS, Web)" This is about testing the screen readers on the majority of tv OSs out there, making sure we can support them or open other activities to support them


AsyncValidator not setting Form to invalid

Hello,
I am using asyncValidators against some Control components as well as some sync validation on the Form. The Form validation is working correctly and the async function is called and is registering against the control as valid = false, which is right. However, when submitting the form, it is always set as valid, so if the async function is invalid, the form is still submitted. Am i missing something? I expect the onSubmitFailed to be called, not onSubmit, if the sync or async validations fail?
I have made an example below:
http://codepen.io/anon/pen/KWdOmM?editors=0011

Here's the problem:
function nameAvailable(value, done) {
    checkNameAsync(value)
        .then(response => {
-           done({ nameAvailable: response });
+           done(response);
        });
}

Before, it was setting user.firstName.validity to { nameAvailable: { nameAvailable: false } } (accidentally nested objects), and an object is truthy. The specific validator's validity is what's expected to be returned from the promise: done(response) to give us { nameAvailable: false }.

Brilliant, thanks for your help.


Allow webex roomID from template

I my environment I'd like to be able to define different webex roomIDs for different namespaces.
This PR adds the possibility to use templates in the webex roomID field, which allow to get the roomID from GroupVariables.

I took a look at some of the other integrations supported in Alertmanager (Discord, Slack, Microsoft Teams, Telegram, VictorOps) and it seems like templates are not supported for the channel/room. I think the general advice is to have a separate receiver for each Room ID, and then route to the correct receiver using label matchers. What do you think @gotjosh?

We have a setup of prometheus and alertmanager using the kube-prometheus-stack.
We have several Team wit n namespaces, where each team has n namespaces.
Each Team has 1 - n Rooms for their notifications.
The main issue with webex is not the roomID, but the Token used for the Bot to authenticate.
Teams could create their own AlertmanagerConfig custom resource in each namespace. But then they would always need to know the Bot's auth token for this config.
Managing all this recievers on the default config is not dynamic enough as teams can dynamically create and destroy namespaces via self service.
If the roomId could be fetched from GroupVariables provided by Prometheus Rules (Each namespace has already their own set of rules), one central receiver config could be used and teams would not have to bother about the auth token.
We would like to use the same Webex Bot for all notifications, but the token should not be spread over several namespaces.

Teams could create their own AlertmanagerConfig custom resource in each namespace. But then they would always need to know the Bot's auth token for this config.

Would credentials_file work for that use case? You would mount a volume with the credentials file in it.

Would credentials_file work for that use case? You would mount a volume with the credentials file in it.

Mabe with the token, but not with the main issue I'm trying to address here. Which is the boilerplate configuration of n notifiers where only the roomId changes.

@grobinson-grafana Is this going to be merged soon?

Hi! 👋 I don't have merge permissions, but I'll ping one of the maintainers.


Vulnerable to CVE-2022-23639?

I'm wondering if moka is vulnerable to https://github.com/advisories/GHSA-qc84-gqf4-9926 (https://github.com/crossbeam-rs/crossbeam/pull/781)
Dependency tree:
moka v0.8.6
├── crossbeam-epoch v0.8.2
│   ├── crossbeam-utils v0.7.2

I could also see that staying with the v0.8.2 is a conscious decision: https://github.com/moka-rs/moka/blob/master/Cargo.toml#L68-L71
In that case, we would need a fix for https://github.com/moka-rs/moka/issues/34 first.

Hi. Thank you for creating the issue. I noticed that GitHub Dependabot has started to alert about CVE-2022-23639 to everyone who have the affected crossbeam-utils versions in the Cargo.toml in their GitHub repository.
Let me check whether moka is really affected by it or not.
Maybe I will have to talk to the crossbeam team. I will do it in tomorrow morning if necessary. (It is ~2 AM now in my time zone. UTC+0800)
Also, I would suggest you to check if your users are likely using the affected platforms below:
(Copied from https://github.com/advisories/GHSA-qc84-gqf4-9926)

The following is a complete list of the builtin targets that may be affected. (last update: nightly-2022-02-11)

armv7-apple-ios (tier 3)
armv7s-apple-ios (tier 3)
i386-apple-ios (tier 3)
i586-unknown-linux-gnu
i586-unknown-linux-musl
i686-apple-darwin (tier 3)
i686-linux-android
i686-unknown-freebsd
i686-unknown-haiku (tier 3)
i686-unknown-linux-gnu
i686-unknown-linux-musl
i686-unknown-netbsd (tier 3)
i686-unknown-openbsd (tier 3)
i686-wrs-vxworks (tier 3)

I could also see that staying with the v0.8.2 is a conscious decision: https://github.com/moka-rs/moka/blob/master/Cargo.toml#L68-L71
In that case, we would need a fix for https://github.com/moka-rs/moka/issues/34 first.

Right. I opened this PR last week. I started to run tests and I hoped it will not make #34 worse.

#157

Unfortunately, my initial tests on Linux x86_64 showed that it will make worse; moka with crossbeam-epoch v0.9.9 had 15% more chance to reproduce the issue than moka with crossbeam-epoch v0.8.2.
I am planning to repeat the test in this weekend just for sure.

I'm wondering if moka is vulnerable to GHSA-qc84-gqf4-9926 (crossbeam-rs/crossbeam#781)

Apparently not.
GHSA-qc84-gqf4-9926 says the followings:

Crates using fetch_* methods with AtomicCell<{i,u}64> are affected by this issue.

I got the source code of crossbeam-utils v0.7.2 and removed AtomicCell from it. I verified that crossbeam-epoch v0.8.2 still compiles, so it does not use AtomicCell.
Here is what I did:
Create a test package and expand crate sources
## Create a test package (project).
$ cargo new hello-epoch082
$ cd $_

## Add crossbeam-epoch v0.8.2 as a dependency.
## Make sure you use Rust 1.62 or newer, whose Cargo has `add` subcommand.
$ cargo add<EMAIL_ADDRESS>
$ cargo tree
hello-epoch-v082 v0.1.0
└── crossbeam-epoch v0.8.2
    ├── cfg-if v0.1.10
    ├── crossbeam-utils v0.7.2
    │   ├── cfg-if v0.1.10
    │   └── lazy_static v1.4.0
    │   [build-dependencies]
    │   └── autocfg v1.1.0
    ├── lazy_static v1.4.0
    ├── maybe-uninit v2.0.0
    ├── memoffset v0.5.6
    │   [build-dependencies]
    │   └── autocfg v1.1.0
    └── scopeguard v1.1.0
    [build-dependencies]
    └── autocfg v1.1.0

## Vendor the source files of the dependencies.

$ cargo vendor

$ exa -l vendor/
drwxr-xr-x - tatsuya  8 Jul 06:00 autocfg
drwxr-xr-x - tatsuya  8 Jul 06:00 cfg-if
drwxr-xr-x - tatsuya  8 Jul 06:00 crossbeam-epoch
drwxr-xr-x - tatsuya  8 Jul 06:00 crossbeam-utils
drwxr-xr-x - tatsuya  8 Jul 06:00 lazy_static
drwxr-xr-x - tatsuya  8 Jul 06:00 maybe-uninit
drwxr-xr-x - tatsuya  8 Jul 06:00 memoffset
drwxr-xr-x - tatsuya  8 Jul 06:00 scopeguard

## Move the vendored source files to the package root directory
## so that we can modify them.

$ mv vendor/crossbeam-epoch .
$ mv vendor/crossbeam-utils .

$ rm -rf vendor

Edit ./src/main.rs and add the following line:
use crossbeam_epoch::{Atomic, CompareAndSetError, Guard, Owned, Shared};

Edit ./Cargo.toml and modify the following line:
[dependencies]
crossbeam-epoch = { path = "./crossbeam-epoch" }  # Modify this line.

Edit ./crossbeam-epoch/Cargo.toml and modify the following line:
[dependencies.crossbeam-utils]
path = "../crossbeam-utils"     # Modify this line.
default-features = false

Remove crossbeam_util::AtomicCell
$ rm crossbeam-utils/src/atomic/atomic_cell.rs

Edit crossbeam-utils/src/atomic/mod.rs and remove the following lines:
mod atomic_cell; // Remove this line.

pub use self::atomic_cell::AtomicCell; // Remove this line.

Run cargo check and verify it compiles
$ cargo tree
hello-epoch-v082 v0.1.0
└── crossbeam-epoch v0.8.2 (... /crossbeam-epoch)
    ├── cfg-if v0.1.10
    ├── crossbeam-utils v0.7.2 (... /crossbeam-utils)

$ cargo check; echo $?
...
    Finished dev [unoptimized + debuginfo] target(s) in 3.63s
0

$ rg crossbeam_utils crossbeam-epoch/src
crossbeam-epoch/src/default.rs
49:    use crossbeam_utils::thread;

crossbeam-epoch/src/sync/list.rs
301:    use crossbeam_utils::thread;

crossbeam-epoch/src/atomic.rs
11:use crossbeam_utils::atomic::AtomicConsume;

crossbeam-epoch/src/sync/queue.rs
13:use crossbeam_utils::CachePadded;
209:    use crossbeam_utils::thread;

crossbeam-epoch/src/lib.rs
80:        extern crate crossbeam_utils;

crossbeam-epoch/src/collector.rs
111:    use crossbeam_utils::thread;

crossbeam-epoch/src/internal.rs
45:use crossbeam_utils::CachePadded;

To make GitHub Dependabot happy, I am going to talk to the crossbeam team if they could create a new version of crossbeam-epoch v0.8.x that depends on a fixed version of crossbeam-utils (>= v0.8.7).

Thanks for the check, good to know that moka is not vulnerable! 💯

@tatsuya6502 In fact the issue can be closed in the v0.9.2, can you publish the version to crates.io? I see that the version in repo is already bumped. Thank you so much for the fix!

@TennyZhuang — Yes. I will publish v0.9.2 to crates.io soon. I am currently running a pre-release test. It will be finished in four hours from now.

Closing this issue as moka v0.9.2 has been published to crates.io. It has the crossbeam-epoch dependency upgraded from v0.8.2 to the latest v0.9.9.
If you got a security alert about CVE-2022-23639 for crossbeam-utils when using an earlier version of moka, you can do one of the followings:

Upgrade your dependency to moka v0.9.2.
Or, run cargo tree -i crossbeam-utils:v0.7.2 and check if crossbeam-epoch is the only crate depending on. If so, you can safely ignore the alert.

moka v0.9.1 or earlier is not vulnerable to CVE-2022-23639, because crossbeam-epoch v0.8.2 does not use the affected functions of crossbeam-utils v0.7.x. This was confirmed with a maintainer of crossbeam crates.


Job name validation

Problem
The job name is not validated; any value, including no value, is accepted for all environments. Sometimes, an environment does not accept certain characters in a job name, causing job runs to fail.
Proposed Solution
Allow environments to provide validation rules, such as a regular expression (regex) for job names or a list of acceptable characters in job names. Block form submission if a name fails environment validation. Validate the job name upon environment selection or change.
Note that some regex grammars are Turing-complete, introducing a security vulnerability.

Consider a general regex permitting alphanumerics, periods, hyphens, and underscores, with a maximum total length of 63:^[a-zA-Z0-9.][a-zA-Z0-9.-_]{0,62}$
Because we use the filename as the default job name, we will have to sanitize the filename upon job creation.

@jweill-aws While this is OK for now, we should look into using a validator library (e.g. yup, zod) that allows us to return specific error messages on a case-by-case basis. For example, it should return "name is too long" when it validation failing because the name is too long. Right now, the regex approach can't do much better than saying "something is wrong" rather than telling them exactly what is wrong.

Also, I just noticed that we allow the job name to be empty. If you provide an empty job name, the link to the job detail view is broken in the list view (there is no name to attach the link to). Should we require a job name?

In the past, we fell back to displaying a placeholder like ''(no name)'' when users haven't provided a name. We could reinstate that.

Per discussion, blank names will no longer be accepted as a result of this issue's being fixed.


Narrowed Segment

(quoted from domtronn/all-the-icons.el#34)

EDIT: also, you might want to add a segment which indicates when a buffer is narrowed:
   (spaceline-define-segment narrow
     "Display Narrowed when buffer is narrowed."
     (when (buffer-narrowed-p)
       "narrow"))

Add a segment to show when a buffer has been Narrowed

Can't think of any other icons, other than the filter one - So this is effectively done.


Linking error for nvhpc on Daint

nvhpc on Daint fails to find two key libaries.
A workaround on level package was introduced to COSMO.
For Icon this fix should move to the level of sysconfigs, because machine/compiler specific
fixes should not be in packages.py.
Proposed solution by CSCS
I talked with my colleagues and we have two suggestions. If you really want to use modules, you probably need to ask for help in the official spack channel. Our impression is that spack does not support external modules, everything is done via RPATH. Alternatively, you can introduce a package in spack for your own needs, for example "c2sm-nvidia-icon" that will explicitely descirbe the linking flags and libraries. You can get some inspiration from the binary packages, for examle "nvhpc", "intel-oneapi-mkl" or Harmen's package for Cray MPI (https://github.com/bcumming/spack-stack/blob/sph-hohgant/mpich-package.py).
Ticket pending
https://jira.cscs.ch/plugins/servlet/desk/portal/1/SD-56965

One option is to globally add:
- compiler:
    spec<EMAIL_ADDRESS>    environment: {}
    extra_rpaths: []
    flags:
      fflags: -lnvcpumath -lnvhpcatm


Datasets: Add JuDo1000 dataset

Description
This PR adds the public JuDo1000 dataset to our package.
This way it is very easy to download, extract, read and process this and hopefully upcoming datasets.
Fixes issue #83
Implemented changes

[x] Add datasets.Dataset
[x] Add datasets.PublicDataset
[x] Add datasets.JuDo1000
[x] Add datasets.Dataset.read()
[x] Add datasets.Dataset.compute_dva()
[x] Add docstrings to all methods.

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change is or requires a documentation update

How Has This Been Tested?
I have written a basic test which downloads the dataset with a plan to do some more testing but switched to a jupyter notebook midway.
The main reasons for this is that the test directory should be reserved for unit tests only.
Downloading a dataset and then checking for stuff is actually more like an integration test / functional tests.
We will have to dig deeper how we implement our functional tests, which are tests that span acomplete use case / user story.
There's an overlap to the tutorials section, where we will present the main use cases and how to get stuff done with pymovements.
Maybe there will be a way to integrate this too? I don't know and we will have to see.
We further need to evaluate if it's really a sensible approach to download the whole dataset for each call of the test suite.
We will generate a lot of traffic this way which is somehow wasteful. I don't now about a good alternative approach though. The same issue will actually also arise for adding example code.
I'm not quite sure but I think pytorch is using some internal magic to mitigate this issue:
https://github.com/pytorch/vision/blob/5dd95944c609ac399743fa843ddb7b83780512b3/torchvision/_internally_replaced_utils.py
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Finally ready for review.
Support for monocular datasets will be added with the upcoming GazeBase PR.


Added references to pre-commit installation

Closes #67
Changes to docs. I thought it made sense to explain the pre-commit process in one place in the docs and reference it elsewhere.

Added a line in docs/developer/how-to/lint.rst suggesting automatically enabling pre-commit on newly cloned repos for the user.
Added a note in docs/user/how-to/existing.rst linking back to docs/developer/how-to/lint.rst.
Added a section in docs/user/tutorials/new.rst linking back to docs/developer/how-to/lint.rst.

Looks good, but please can you put the developer/how-to/lint.rst in python3-pip-skeleton rather than python3-pip-skeleton-cli as it needs to appear in all skeleton based projects.

Looks good, but please can you put the developer/how-to/lint.rst in python3-pip-skeleton rather than python3-pip-skeleton-cli as it needs to appear in all skeleton based projects.

https://github.com/DiamondLightSource/python3-pip-skeleton/pull/120


Missing method error when trying to use cancelBuildsOnUpdate DSL

I have unit tests running against our DSL jobs and for the life of me I could not figure out why I was getting MissingMethodErrors.
Caused by: groovy.lang.MissingMethodException: No signature of method: javaposse.jobdsl.dsl.helpers.triggers.TriggerContext.cancelBuildsOnUpdate() is applicable for argument types: (ReactNativeJobs$_buildAndTestWebPR_closure6$_closure75$_closure80$_closure81$_closure82) values: [ReactNativeJobs$_buildAndTestWebPR_closure6$_closure75$_closure80$_closure81$_closure82@69ec89f8] 	at javaposse.jobdsl.dsl.AbstractExtensibleContext.methodMissing(AbstractExtensibleContext.groovy:19) 	at groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:46) 	at groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:46)
cancelBuildsOnUpdate() exists in master:
https://github.com/jenkinsci/ghprb-plugin/blob/master/src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbExtensionContext.java#L58-L63
But not in the tagged releases for 1.41.0 or 1.42.0
https://github.com/jenkinsci/ghprb-plugin/blob/ghprb-1.42.0/src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbExtensionContext.java
I have confirmed that the class file in the jar, in the hpi, on maven central does NOT have the new method.
I think this is related: https://github.com/jenkinsci/ghprb-plugin/pull/709#issuecomment-435418460
So for some reason the changes on the jobdsl haven't made it.  The extension classes themselves have made it.
This was the PR with the change, https://github.com/jenkinsci/ghprb-plugin/pull/664 and it was referenced in the 1.41.0 release

When fixing this, it would also be great if this could be added to the documentation (= code listing) on README.md. It's not too obvious how to use it without any documentation.


Document herokuapp.com, which supports TLS

Fixes gh-33

Sorry, meant to respond to https://github.com/afeld/mustachio/pull/34... mustachify.me is now served through CloudFlare, which gives HTTPS support for free. https://mustachify.me! Updated in fb7423c4e0e69cb4c872c017f45530f03536e27b. Thanks for the push!


Module CR reconciler

Description
Changes proposed in this pull request:

Module CR reconciler
Fix for AWS IpRange to check if IpRange ranges overlap with some existing subnet that's not recognised as cloud-resources subnet

Related issue(s)

/retest


Python: Adding Vector Search to the In Memory collection

Motivation and Context

Adds vectorized search and text search to the In Memory connector.
Description

Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

Python Unit Test Overview

Tests
Skipped
Failures
Errors
Time

2804
4 :zzz:
0 :x:
0 :fire:
1m 24s :stopwatch:


Make downloading the wine.flatimage and version of wine.layer optional?

Would it be possible to make the download of wine.flatimage and wine version.layer optional?
It randomly downloads new ones
Sometimes the download is very slow
It seems to take a while to validate the checksums too?
Can it not just go straight to the next screen?

Hi @Blad3forc3 . The way that it works will change in v1.5.0 and should match what you want.


🐛 ci: set the good argument name on notify-schema-draft

Sorry for this mistake 😅

size-limit report 📦

Path
Size

target/wasm32-unknown-unknown/release/okp4_objectarium.wasm
427.68 KB (0%)

target/wasm32-unknown-unknown/release/okp4_law_stone.wasm
636.59 KB (0%)

target/wasm32-unknown-unknown/release/okp4_cognitarium.wasm
765.97 KB (0%)


AKSv2: convert static info to dynamic api proxy calls

This includes:

Resource groups (cluster list)
VM list
location list

There is no RG list. Its a txt field
Cluster list for imports is dynamic
@cbron what is VM list? Do you mean VNET list?
Location list is dynamic

I got confirmation that its only Cluster List not RG. Closing this now.


Can't run on freebsd

OS/Platform
Gentoo
Installed
https://ungoogled-software.github.io/ungoogled-chromium-binaries/
Version
107.0.5304.122-1
Have you tested that this is not an upstream issue or an issue with your configuration?

[ ] I have tried reproducing this issue in Chrome and it could not be reproduced there
[ ] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
[ ] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile and it could not be reproduced there

Description
Maybe package conflict?
How to Reproduce?
start chrome
Actual behaviour
ld-elf.so.1: Shared object "libicui18n.so.71" not found, required by "chrome"
found https://github.com/helloSystem/ISO/issues/396 but ungoogled-chromium didnt install or tried to install mozjpeg, but there are conflicts with jpeg-turbo.
Expected behaviour
start chrome
Relevant log output
No response
Additional context
I use freebsd but there isnt an option to choose it. I already made an issue here, but i havent got an answer.

FreeBSD builds get uploaded voluntarily, if they weren't linked against the libraries on your system you will have to build it manually.

Okay i fixed it with help from archlinux forum
# ln -s /usr/local/lib/libicui18n.so.72.1 /usr/local/lib/libicui18n.so.71
# ln -s /usr/local/lib/libicuuc.so.72.1 /usr/local/lib/libicuuc.so.71
# ln -s /usr/local/lib/libicudata.so.72.1 /usr/local/lib/libicudata.so.71


update vertex to use tool call attribute on AIMessage

Does this also fix some of the streaming issues?

not that I know of...


 Please see other components build by people. @avezqureshi14

ok @Rajdip019


v3.0.0

react-markdown v3.0.0
Summary
Full rewrite based on a new parser. I'd love it if you would try it out and let me know if it works or doesn't work for you. It can be installed with npm install --save react-markdown@next. Please see list of breaking changes below.
Added

Table support!

New types: table, tableHead, tableBody, tableRow, tableCell

New type: delete (~~foo~~)
New type: imageReference
New type: linkReference
New type: definition
Hacky, but basic support for React-native rendering of attributeless HTML nodes (<kbd>, <sub>
etc)

BREAKING

Container props removed (containerTagName, containerProps), override root renderer instead
softBreak option removed. New solution will be added at some point in the future.
escapeHtml is now TRUE by default
HtmlInline/HtmlBlock are now named html (use isBlock prop to check if inline or block)
Renderer names are camelcased and in certain cases, renamed. For instance:

Emph => emphasis
Item => listItem
Code => inlineCode
CodeBlock => code
linebreak/hardbreak => break

All renderers: literal prop is now called value* List renderer: type prop is now a boolean
named ordered (Bullet => false, Ordered => true)
walker prop removed. Code depending on this will have to be rewritten to use the astPlugins
prop, which functions differently.
allowNode has new arguments (node, index, parent) - node has different props, see renderer props
childBefore and childAfter props removed. Use root renderer instead.
parserOptions removed (new parser, so the old options doesn't make sense anymore)

Nice! How does v3 compare to remark-react? Asking because remark, the new base library, explicitly endorses it, and I'm sure others will want to know this too.

They are fairly similar. My main motivation with react-markdown is to provide a "drop-in" component. One dependency that "just works" out of the box, while (in the future) being extendable. I hope (and think) that it fits in the React ecosystem and feels familiar and easy to use.
react-markdown mainly uses the markdown parser from remark and translates to React components directly from the AST (remark-react uses HAST-nodes). In the future, I hope to be able to utilize the full power of the remark ecosystem while hopefully being easy to use.
Another goal is to try and keep the bundle size down as much as possible. I have a couple of ideas in mind for how to achieve smaller builds, but we'll have to wait and see if that works out.
remark-react embraces and follows the remark/hast set of tools very closely, which makes it really extendable and powerful. In my personal opinion, I find it can be a bit hard to navigate the very large set of plugins and closely related projects within the unified/remark/hast/mdast/vfile sphere.
Thankfully, both projects are free and open-source, so use whichever one works for you! :)

Thanks for the breakdown! And thanks for your work on this.

Thanks. I'll give it a try. Did you consider marked as the parser? Its very fast, understands GFM by default and also gives you an AST.

I did consider marked, but it has not been updated for nearly a year with no feedback from the maintainer. There was also a bunch of issues I ran across when attempting to use it that made me look for an alternative.

Just wondering, with this version, would we be able to add arbitrary remark plugins by using the astPlugins property, or is that not what that's for? Eg. I'd like to be able to add math rendering via https://github.com/rokt33r/remark-math, would that work?
Thanks!

@ibrahima At some point. Not at the moment,unfortunately.

Just released v3.


add the licence column to the sys.cluster table

Codecov Report

Merging #4900 into crate-enterprise will decrease coverage by -0.14%.
The diff coverage is 93.33%.

@@                  Coverage Diff                  @@
##             crate-enterprise   #4900      +/-   ##
=====================================================
- Coverage               82.23%   82.1%   -0.14%
+ Complexity              10696   10666      -30
=====================================================
  Files                    1294    1294
  Lines                   44520   44531      +11
  Branches                 5629    5629
=====================================================
- Hits                    36611   36562      -49
- Misses                   5278    5320      +42
- Partials                 2631    2649      +18

Impacted Files
Coverage Δ
Complexity Δ

...ava/io/crate/metadata/sys/SysClusterTableInfo.java
100% <100%> (ø)
4 <ø> (ø)
:x:

...ference/sys/cluster/ClusterSettingsExpression.java
100% <100%> (ø)
4 <ø> (ø)
:x:

...java/io/crate/metadata/settings/CrateSettings.java
90.1% <87.5%> (-0.09%)
16 <ø> (ø)

...n/java/io/crate/exceptions/JobKilledException.java
0% <ø> (-66.67%)
0% <ø> (-1%)

...arch/indices/recovery/BlobStartPrefixResponse.java
66.66% <ø> (-33.34%)
3% <ø> (-2%)

...o/crate/analyze/SafeExpressionToStringVisitor.java
83.33% <ø> (-16.67%)
7% <ø> (-1%)

...o/crate/operation/projectors/SortingProjector.java
81.57% <ø> (-13.16%)
10% <ø> (-2%)

...crate/executor/transport/TransportShardAction.java
77.5% <ø> (-12.5%)
8% <ø> (-1%)

...io/crate/protocols/postgres/types/VarCharType.java
87.5% <ø> (-12.5%)
9% <ø> (-2%)

...eration/projectors/ColumnIndexWriterProjector.java
73.33% <ø> (-8.89%)
7% <ø> (-1%)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6b62f...efe84c0. Read the comment docs.


apps wc: Allow user to list and run top cluster wide

What this PR does / why we need it:
Increases the privileges for user admins to be able to list pods cluster wide, which is needed to be able to see the allocated resources when running the k describe pod command.
Also gives access to metrics cluster wide to be able to run k top nodes.
Which issue this PR fixes:
fixes #850
Public facing documentation PR (if applicable)

Special notes for reviewer:
Added<EMAIL_ADDRESS>as an admin user:
❯ k auth can-i<EMAIL_ADDRESS>list pods --all-namespaces
yes

❯ k describe nodes<EMAIL_ADDRESS>...
Non-terminated Pods:          (22 in total)
  Namespace                   Name                                                          CPU Requests  CPU Limits   Memory Requests   Memory Limits    Age
  ---------                   ----                                                          ------------  ----------   ---------------   -------------    ---
  cert-manager                cert-manager-webhook-86587486bd-gvdf5                         25m (0%)      250m (6%)    25Mi (0%)         250Mi (3%)       34d
  falco                       falco-exporter-qfkdf                                          30m (0%)      30m (0%)     20Mi (0%)         20Mi (0%)        34d
  falco                       falco-hpnm8                                                   100m (2%)     200m (5%)    512Mi (6%)        1Gi (13%)        34d
  fluentd                     fluentd-fluentd-elasticsearch-fdlrn                           200m (5%)     500m (12%)   300Mi (3%)        572Mi (7%)       34d
  gatekeeper-system           gatekeeper-controller-manager-795447c446-lbdpg                100m (2%)     1 (25%)      256Mi (3%)        512Mi (6%)       28d
  gatekeeper-system           gatekeeper-controller-manager-795447c446-rp6vn                100m (2%)     1 (25%)      256Mi (3%)        512Mi (6%)       28d
  ingress-nginx               ingress-nginx-controller-jgg48                                100m (2%)     200m (5%)    263Mi (3%)        512Mi (6%)       18d
  kube-system                 calico-node-f9tbf                                             150m (3%)     300m (7%)    64M (0%)          500M (6%)        80d
  kube-system                 coredns-8474476ff8-p5q7m                                      100m (2%)     0 (0%)       70Mi (0%)         170Mi (2%)       80d
  kube-system                 kube-proxy-dk9gp                                              0 (0%)        0 (0%)       0 (0%)            0 (0%)           80d
  kube-system                 nginx-proxy-olle-wc-worker-2                                  25m (0%)      0 (0%)       32M (0%)          0 (0%)           80d
  kube-system                 node-local-dns-rcqwr                                          25m (0%)      0 (0%)       40Mi (0%)         0 (0%)           34d
  monitoring                  kube-prometheus-stack-prometheus-node-exporter-nnwqq          25m (0%)      50m (1%)     50Mi (0%)         100Mi (1%)       34d
  monitoring                  starboard-operator-6b9956968d-8z6kd                           10m (0%)      20m (0%)     128Mi (1%)        172Mi (2%)       34d
  monitoring                  vulnerability-exporter-65bc4c6dcf-rjnw2                       40m (1%)      80m (2%)     79Mi (1%)         158Mi (2%)       34d
  postgres-system             iam-main-0                                                    1050m (26%)   1500m (38%)<PHONE_NUMBER> (14%)  1298576Ki (16%)  4d22h
  rook-ceph                   csi-rbdplugin-ftscs                                           15m (0%)      0 (0%)       35Mi (0%)         0 (0%)           80d
  rook-ceph                   csi-rbdplugin-provisioner-747b4fcbd4-tpmp6                    30m (0%)      0 (0%)       140Mi (1%)        0 (0%)           80d
  rook-ceph                   rook-ceph-crashcollector-olle-wc-worker-2-65cc9bc6bb-8vgwt    1m (0%)       0 (0%)       15Mi (0%)         0 (0%)           80d
  rook-ceph                   rook-ceph-mgr-a-765d9b9688-6wmnh                              100m (2%)     0 (0%)       500Mi (6%)        0 (0%)           80d
  rook-ceph                   rook-ceph-mon-a-86cd9d746f-dvbmx                              100m (2%)     0 (0%)       1Gi (13%)         0 (0%)           80d
  rook-ceph                   rook-ceph-osd-2-7bb5fd4f46-874hw                              500m (12%)    0 (0%)       1Gi (13%)         0 (0%)           80d
Allocated resources:
  (Total limits may be over 100 percent, i.e., overcommitted.)
  Resource           Requests          Limits
  --------           --------          ------
  cpu                2826m (72%)       5130m (131%)
  memory<PHONE_NUMBER> (78%)<PHONE_NUMBER> (75%)
  ephemeral-storage  0 (0%)            0 (0%)
  hugepages-1Gi      0 (0%)            0 (0%)
  hugepages-2Mi      0 (0%)            0 (0%)

❯ k top nodes<EMAIL_ADDRESS>--use-protocol-buffers
NAME               CPU(cores)   CPU%   MEMORY(bytes)   MEMORY%
olle-wc-master-0   326m         18%    2795Mi          84%
olle-wc-worker-0   484m         12%    4024Mi          52%
olle-wc-worker-1   598m         15%    4967Mi          65%
olle-wc-worker-2   333m         8%     5158Mi          67%

Checklist:

[x] Added relevant notes to WIP-CHANGELOG.md
[x] Proper commit message prefix on all commits
[ ] Updated the public facing documentation
Is this changeset backwards compatible for existing clusters? Applying:

[x] is completely transparent, will not impact the workload in any way.
[ ] requires running a migration script.
[ ] will create noticeable cluster degradation.
E.g. logs or metrics are not being collected or Kubernetes API server
will not be responding while upgrading.
[ ] requires draining and/or replacing nodes.
[ ] will change any APIs.
E.g. removes or changes any CK8S config options or Kubernetes APIs.
[ ] will break the cluster.
I.e. full cluster migration is required.

Chart checklist (pick exactly one):

[ ] I upgraded no Chart.
[ ] I upgraded a Chart and determined that no migration steps are needed.
[ ] I upgraded a Chart and added migration steps.

Pipeline config (if applicable)
If you change some config options (e.g. add/rename variable or change the default value) you may need to update the config used by the pipeline in pipeline/config.

LGTM!!


feat: add ICU MessageFormat support

Please describe the changes this PR makes and why it should be merged
This PR adds support for ICU MessageFormat and replaces all string variables to the format.
Language plural rules: https://unicode-org.github.io/cldr-staging/charts/37/supplemental/language_plural_rules.html
In this PR:

Code changes were not tested
Strings were edited (text changed while the key stayed the same)
Strings were added/removed (new/deleted string keys)
An open issue was fixed/addressed: #696

Also I think you missed some places where we could be using ICU like in the cooldown system (for second/seconds), could you take another look?

The cooldown system uses Discord timestamp. Should I replace it?

Also I think you missed some places where we could be using ICU like in the cooldown system (for second/seconds), could you take another look?

The cooldown system uses a Discord timestamp. Should I replace it?

No it doesn’t. It says X second(s)/minutes


feat: add share component fallback

Description:
This PR adds a fallback component if navigator.share not supported.
Using chakra-ui popover
Social media URL API (i found on internet) https://gist.github.com/HoldOffHunger/1998b92acb80bc83547baeaff68aaaf4
Issue Reference
https://github.com/mazipan/ksana.in/issues/21
Screenshoot

Minimum Support

[x] Click 🌟 button to this repo
[x] Follow the Author

Consider to Support

👉 🇮🇩 Trakteer
👉 🌍 BuyMeACoffe
👉 🌍 Paypal
👉 🌍 Ko-Fi

About lazy, i think you're right mas, but i couldn't find any documentation about this. should I add this anyway?

https://chakra-ui.com/docs/overlay/popover#lazily-mounting-popover

https://chakra-ui.com/docs/overlay/popover#lazily-mounting-popover

walah, my bad

Do we use Portal @svspicious https://chakra-ui.com/docs/overlay/popover#rendering-the-popover-in-a-portal?

No, do we need it?

No for now I think, just curious.

I think, this ready to be merge.


Dotnet framework deleted from repository

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/112710&drop=dogfoodAlpha

@wingetbot waivers Add Validation-Installation-Error

/azp run

/azp run


gnugrep: disable tests on riscv64

Description of changes

disable tests on riscv64, fixes #300618
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

fixed

as per https://github.com/NixOS/nixpkgs/issues/300550#issuecomment-2032136788 this is only on qemu

as per #300550 (comment) this is only on qemu

But this still applies, as in most cases the "riscv build platform" is emulated.
(Accidentally edited your reply, sorry


Can't parse CURRENT_TIMESTAMP(6)

I have a mysql scheme like this:
`LAST_MODIFY_TIME` timestamp(6) NULL DEFAULT CURRENT_TIMESTAMP(6) ON UPDATE CURRENT_TIMESTAMP(6),

and it seems couldn't parse correctly.

https://dev.mysql.com/doc/refman/8.0/en/timestamp-initialization.html
remove '6' from the CURRENT_TIMESTAMP() function call. Better yet,
remove the '()' as well.
DEFAULT CURRENT_TIMESTAMP() is an internal function not an attribute.
On Mon, Dec 23, 2019 at 7:43 PM Sean Chen<EMAIL_ADDRESS>wrote:

I have a mysql scheme like this:
LAST_MODIFY_TIME timestamp(6) NULL DEFAULT CURRENT_TIMESTAMP(6) ON UPDATE CURRENT_TIMESTAMP(6),
and it seems couldn't parse correctly.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/schemalex/schemalex/issues/91?email_source=notifications&email_token=AABTJH2QINCP2GFYEQNAPRDQ2GANNA5CNFSM4J62IUV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICN5PEQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABTJH7T2Q2FA5PBDEQXXTTQ2GANNANCNFSM4J62IUVQ
.

Thanks for reply, but the article you sended says that:

If a TIMESTAMP or DATETIME column definition includes an explicit fractional seconds precision value anywhere, the same value must be used throughout the column definition.

I need to set the default within function call, because I use the timestamp(6) type.


TypeTable in WordDelimiterTokenFilter should be List or Dictionary<string,string>

https://github.com/elastic/elasticsearch-net/blob/develop/src/Nest/Domain/Analysis/TokenFilter/WordDelimiterTokenFilter.cs#L51
For example:
{
  "type_table": {
    "#": "ALPHA",
    "@": "ALPHA",
    " .": "ALPHA"
  },
  "type": "word_delimiter"
}

OR
{
  "preserve_original": true,
  "type_table": [
    "# => ALPHA",
    "@ => ALPHA",
    ". => ALPHA"
  ],
  "type": "word_delimiter"
}

Right?

Totally correct! will move discussion over to your PR :+1:


Tile-combine

Thank you for the work.
My question is for the tile-combine option, I assume there is a step where the tiled images predicted JSON file labels need to be combined into one JSON file label corresponding to the original image size.  Where is that script located?
I am not able to find it.
The soonest response is highly appreciated.
Thank you!

Or is it like, once the model is trained on the tiled image, during inference we use the original size image without tiling?

@Abeni18
Your last guess was right, here in config you may see resolutions. Sorry for the long response.

Got it thanks


Service Bus  :MaxAutoLockRenewalDuration not renewing lock getting MessageLockLost Exception

Library name and version
Azure.Messaging.ServiceBus 7.8.0
Describe the bug
var proc = client.CreateProcessor("managedQueue", options: new ServiceBusProcessorOptions
{
            AutoCompleteMessages = false,
            PrefetchCount = 1,
            MaxAutoLockRenewalDuration = TimeSpan.FromSeconds(180)
        });

using the following ServiceBusProcessorOptions, message lock duration is set to 30 seconds. Still facing MessageLockLost exception if the message is processed in one minute.
Exception Details : Azure.Messaging.ServiceBus.ServiceBusException: The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue. For more information please see https://aka.ms/ServiceBusExceptions . Reference:a233b7a0-9a19-4bea-b5c7-ced7b07fa271, TrackingId:56aed59f-3658-4a04-b5ee-4a30529b8fcd_B14, SystemTracker:fps-sbrefactor:Queue:managedqueue, Timestamp:2022-05-11T15:54:30 (MessageLockLost)
at Azure.Messaging.ServiceBus.Amqp.AmqpReceiver.RenewMessageLockInternalAsync(Guid lockToken, TimeSpan timeout)
at Azure.Messaging.ServiceBus.Amqp.AmqpReceiver.<>c.<b__55_0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy.RunOperation[T1,TResult](Func4 operation, T1 t1, TransportConnectionScope scope, CancellationToken cancellationToken, Boolean logRetriesAsVerbose)    at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy.RunOperation[T1,TResult](Func4 operation, T1 t1, TransportConnectionScope scope, CancellationToken cancellationToken, Boolean logRetriesAsVerbose)
at Azure.Messaging.ServiceBus.Amqp.AmqpReceiver.RenewMessageLockAsync(Guid lockToken, CancellationToken cancellationToken)
at Azure.Messaging.ServiceBus.ServiceBusReceiver.RenewMessageLockAsync(Guid lockToken, CancellationToken cancellationToken)
at Azure.Messaging.ServiceBus.ServiceBusReceiver.RenewMessageLockAsync(ServiceBusReceivedMessage message, CancellationToken cancellationToken)
at Azure.Messaging.ServiceBus.ReceiverManager.RenewMessageLockAsync(ServiceBusReceivedMessage message, CancellationTokenSource cancellationTokenSource)
Expected behavior
Since the MaxAutoLockRenewalDuration is set to three minutes , the lock should get renewed till 3 minutes and no error should be observed even if the message handler runs upto 3 minutes.
Actual behavior
MaxAutoLockRenewalDuration is not renewing the lock and the lock lost exception is thrown.
Reproduction Steps
Created a service bus queue with lock duration of 30 seconds and trying to post a message to the service bus queue. Attaching the git hub url of the sample application.
https://github.com/annupriya-shell/ServiceBusReceiverIssue.git
The setting of the service bus queue is attached

Environment
OS : Windows 10
IDE : Visual Studio 2019
Dotnet Core Version : 3.1
Azure.Messaging.ServiceBus Version="7.8.0"

@Sandeep7OnShell created the issue regarding the service bus locklost exception

@annupriya-shell, I tried going to the provided repo link and it didn't work. Can you make sure that the repo name is correct and that it is publicly accessible? Can you clarify how you are observing these exceptions? Is your error handler being invoked?

@annupriya-shell, please make sure there are no secrets in your repo.

@JoshLove-msft  Yes the prefetch count was 1 in the scenario, but I have narrowed down the issue to my system clock time. My system clock time was apparently 40 sec back, so whenever the message was going for lock renewal the lock had expired and was getting this error. Post resetting it back not getting this issue.

@JoshLove-msft Yes the prefetch count was 1 in the scenario, but I have narrowed down the issue to my system clock time. My system clock time was apparently 40 sec back, so whenever the message was going for lock renewal the lock had expired and was getting this error. Post resetting the clock not getting this issue.

Ah, thanks for letting us know. This is something that we will need to document in our upcoming troubleshooting guide.


Add LoongArch clang-17 builds

LLVM 17 has support for building these configurations in the same manner
as LLVM 18. Now that tuxmake supports it, enable it here.
Link: https://gitlab.com/Linaro/tuxmake/-/commit/0c5d02c99fe86445d16425ea080b1e197a37c194

Whoops, forgot to do that!
diff --git a/tmp/estimate-builds.txt b/tmp/.psub.i9meTqgkIr
index 48df8dc..d6aa3e4 100644
--- a/tmp/estimate-builds.txt+++ b/tmp/.psub.i9meTqgkIr
@@ -1,10 +1,10 @@-Total builds per week: 9271
+Total builds per week: 9339

   - tree: mainline-    total: 3285
+    total: 3325
     breakdown:
     - clang-18: 690
-    - clang-17: 650
+    - clang-17: 690
     - clang-16: 325
     - clang-15: 300
     - clang-14: 275
@@ -13,10 +13,10 @@ Total builds per week: 9271
     - clang-11: 510

   - tree: next
-    total: 2505
+    total: 2525
     breakdown:
     - clang-18: 350
-    - clang-17: 330
+    - clang-17: 350
     - clang-16: 330
     - clang-15: 305
     - clang-14: 280
@@ -26,10 +26,10 @@ Total builds per week: 9271
     - clang-android: 115

   - tree: stable
-    total: 606
+    total: 614
     breakdown:
     - clang-18: 138
-    - clang-17: 130
+    - clang-17: 138
     - clang-16: 65
     - clang-15: 60
     - clang-14: 55


fix color to Uint32

Hmm. Maybe I don't understand something, but shouldn't it be for RGBA format? 0_o"

Hmm according to 9c86fb40, it should be the correct format since it was a fix but we also don't seem to use it anywhere?
If you find a case where it's wrong, let me know!

I found the wrong behavior when working with textures. Maybe everything worked fine on the surfaces, but I'm not sure. (I immediately refused them)

package main

import (
	"github.com/veandco/go-sdl2/sdl"
)

func castomUint32(c sdl.Color) uint32 {
	var v uint32
	v |= uint32(c.R) << 24
	v |= uint32(c.G) << 16
	v |= uint32(c.B) << 8
	v |= uint32(c.A)
	return v
}

func drawPixels(tx *sdl.Texture, r sdl.Rect, color uint32) {
	data := make([]uint32, 100)
	for i := 0; i < 100; i++ {
		data[i] = color
	}
	tx.UpdateRGBA(&r, data, 10)
}

func main() {
	sdl.Init(sdl.INIT_EVERYTHING)
	win, _ := sdl.CreateWindow("test", sdl.WINDOWPOS_UNDEFINED, sdl.WINDOWPOS_UNDEFINED, 200, 100, sdl.WINDOW_SHOWN)
	rd, _ := sdl.CreateRenderer(win, -1, sdl.RENDERER_ACCELERATED)

	winTx := rd.GetRenderTarget()

	tx, _ := rd.CreateTexture(sdl.PIXELFORMAT_RGBA8888, sdl.TEXTUREACCESS_TARGET, 100, 100)
	rd.SetRenderTarget(tx)

	redColor := sdl.Color{R: 255, G: 0, B: 0, A: 255}

	drawPixels(tx, sdl.Rect{W: 10, H: 10, X: 0}, redColor.Uint32())       // expect red, see yellow
	drawPixels(tx, sdl.Rect{W: 10, H: 10, X: 10}, castomUint32(redColor)) // expect and see red

	rd.SetRenderTarget(winTx)
	rd.Copy(tx, &sdl.Rect{W: 20, H: 10}, &sdl.Rect{W: 20, H: 10})
	rd.Present()

	for {
		event := sdl.WaitEvent()
		switch event.(type) {
		case *sdl.QuitEvent:
			return
		}
	}
}

I'd say it makes sense to make this function return RGBA. But there are several issues.
I'm not sure why this function even exists in the first place. Currently it returns ARGB, proposed one is RGBA. The issue is that if we really want a function that returns uint32 representation of a color then the functions should be named accordingly, Color.Unit32RGBA for example.
Then we get another question to answer. Why do we need those if there already SDL functions for it? Efficiency-wise they might be useful, but do we really want to make those for each format?
// MapRGB maps an RGB triple to an opaque pixel value for a given pixel format.
// (https://wiki.libsdl.org/SDL_MapRGB)
func MapRGB(format *PixelFormat, r, g, b uint8) uint32 {
	return uint32(C.SDL_MapRGB((*C.SDL_PixelFormat)(unsafe.Pointer(format)),
		C.Uint8(r), C.Uint8(g), C.Uint8(b)))
}

// MapRGBA maps an RGBA quadruple to a pixel value for a given pixel format.
// (https://wiki.libsdl.org/SDL_MapRGBA)
func MapRGBA(format *PixelFormat, r, g, b, a uint8) uint32 {
	return uint32(C.SDL_MapRGBA((*C.SDL_PixelFormat)(unsafe.Pointer(format)),
		C.Uint8(r), C.Uint8(g), C.Uint8(b), C.Uint8(a)))
}

I'd rather get rid of it to be honest.

I probably agree with you. But with one exception. I believe that such simple functions as color conversion are better implemented in GO, since the CGO calls are relatively heavy and in this case we get a big drawdown in performance.
I think it's better to write five lines and implement mapRGBA in GO because it's a very simble operation.

Ye, I'd rather update those functions to use Go.
This is the C code. Do you want to do it yourself?
/* Find the opaque pixel value corresponding to an RGB triple */
Uint32
SDL_MapRGB(const SDL_PixelFormat * format, Uint8 r, Uint8 g, Uint8 b)
{
    if (format->palette == NULL) {
        return (r >> format->Rloss) << format->Rshift
            | (g >> format->Gloss) << format->Gshift
            | (b >> format->Bloss) << format->Bshift | format->Amask;
    } else {
        return SDL_FindColor(format->palette, r, g, b, SDL_ALPHA_OPAQUE);
    }
}

/* Find the pixel value corresponding to an RGBA quadruple */
Uint32
SDL_MapRGBA(const SDL_PixelFormat * format, Uint8 r, Uint8 g, Uint8 b,
            Uint8 a)
{
    if (format->palette == NULL) {
        return (r >> format->Rloss) << format->Rshift
            | (g >> format->Gloss) << format->Gshift
            | (b >> format->Bloss) << format->Bshift
            | ((a >> format->Aloss) << format->Ashift & format->Amask);
    } else {
        return SDL_FindColor(format->palette, r, g, b, a);
    }
}

I would prefer to use this in my project:
func castomUint32(c sdl.Color) uint32 {
	var v uint32
	v |= uint32(c.R) << 24
	v |= uint32(c.G) << 16
	v |= uint32(c.B) << 8
	v |= uint32(c.A)
	return v
}

Since this is quite enough, since I work with only one color format.

Thanks @dedalqq for the example! It clearly proves that the current code is not working as expected and looking further the current code really does not make sense so I'll be merging this.
I guess this can be used as a fast alternative to MapRGBA since the color struct is already structured in RGBA at field-level. I'll leave it there if people find it to be handy. We could also re-implement MapRGBA in Go like @malashin said as an additional thing.


Remove Implicit Ordering

Problem
The sortBy relied on Ord class that was restricting ordering based on scala.math.Ordering, but it is not used anywhere else.
Solution
Remove it
Notes
Checklist

[X] Unit test all changes
[X] Update README.md if applicable
[X] Add [WIP] to the pull request title if it's work in progress
[X] Squash commits that aren't meaningful changes
[X] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

👍

👍


django-categories 1.3b8 downgrades django-mptt, breaking Django 1.8

When django-categories 1.3b8 is installed, it downgrades django-mptt to the 0.6 release. This breaks Django 1.8 with a AppRegistryNotReady error. When upgrading django-mptt, everything works smooth.

This will be tricky as the latest version of django-mptt doesn't work well with Django 1.7 and lower. What I might have to do is make the 1.3 release for Django < 1.8 and have a 1.4 release that is for Django >= 1.8.
Thoughts?

Ah, I see.
Releasing two versions is possible, though it will be a bit strange that the only difference is a dependency version in setup.py
In this rare case, perhaps keeping the mptt version "open" is better, e.g. >= 0.4, so installing django-categories doesn't enforce a downgrade. At a project level, the version could be limited in the requirements.txt file after all.
To protect the users, it would be possible to raise a warning from __init__.py when bad combinations of mptt and django are used.
Ideally, django-mptt should get fixed, but I noticed that 1.6 support is the minimum base line for them now. :-(

as @vdboor said: pip install django-mptt --upgrade fixed the issue.
django-mptt site says it works with django-1.4.2+.
By default the app shouldn't break (as it is doing), so by default it should install the latest django-mptt version. I agree with the warning idea. The support for django 1.4 will end soon...updating it to work with the next LTS release should take priority.

Any update on this issue? Right now forward compatibility is broken due to backwards compatibility.
I'd prefer to see the requirements being "open", all with ">=" instead of "==".
This would allow users to fix the bad combinations in their own projects.
Right now I simple can't have a project on 1.8 because of this.
My project template is even forced to 1.7 because of this issue.

@vdboor, can you test and see if this is still and issue. I've merged in some changes to master that should take care of this issue.

yes, this fixed the installation issues. I can install v1.4 without any issues.
@epicserve: is there any reason why unicode-slugify is still pinned to a specific version?

@vdboor, no idea.


feat(BRepBlocksTopology): adding boundary surface inspection test

:tada: This PR is included in version 6.3.0-rc.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 6.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Hosting container in Azure App Service with startup parameters

I have a container which requires command line parameters on startup.  Is it possible to set them in the app service?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 705f9cf9-9bdd-c0e6-8170-062c62b6e12b
Version Independent ID: 8de37e15-ccfb-e619-69b1-d8918dcb0b3e
Content: Run custom Windows container (Preview) - Azure App Service
Content Source: articles/app-service/app-service-web-get-started-windows-container.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: cephalin

@nspiteri Thanks for the feedback! We are currently investigating and will update you shortly.

@nspiteri We typically try to keep the Azure-Docs channel scoped to feedback directly about the docs. Since your question goes beyond what is discussed in the doc, we kindly invite you to share your question MSDN forum. Thank you for your understanding


Add IP Location Info

Note on the state of this issue - it's been reverted, see here for why:

I’ve changed my mind on this, it doesn’t add that much value, and adds
an external hit for that minimal value. There’s the option to pull down
the GeoIP DB to do this locally, but there are issues with the license
and keeping it up to date. May consider adding this again if there’s a
good option, but for now, no.


"open file" does not work on OSX

Description
At the end of a processing, the following command display is issued for users to open a browser and glance at QC results:
open file "/Users/julien/qc_batch_processing/index.html"

However, this command fails on OSX and needs to be replaced with:
open "/Users/julien/qc_batch_processing/index.html"

State of spinalcordtoolbox
Spinal Cord Toolbox (jca_batchProc/dea98c961553315202c90086fddedf923e99a768)

On Linux, xdg-open.

@jcohenadad I see the command is already "open", is there somewhere else I should've looked? is the condition to check the OS wrong? (seems fine to me)
`if uname -a | grep -i  darwin > /dev/null 2>&1; then
OSX
open_command="open"
elif uname -a | grep -i  linux > /dev/null 2>&1; then
Linux
open_command="xdg-open"
fi`

@abtahizadeh the displayed command is "open file": https://github.com/neuropoly/spinalcordtoolbox/blob/master/spinalcordtoolbox/reports/qc.py#L416


Expose a nom-compatible version of parse

Having a function that parses json mid-stream would be quite handy.

For context, I've been using this branch off and on for a month or so, I haven't noticed any serious drawbacks. Being able to slot this into a larger parser to contextually parse JSON has been great.


params.yaml duplex_seq

Hi!
In the params.yaml where you can specify if duplex_seq: true is this referring to whether the data is paired-end or is it referring to whether the UMI scheme is single-stranded or not?
For example I have paired-end data from the Agilent SureSelect XT HS library prep kit but the UMI is single-stranded in I2. In the params.yaml would I specify duplex_seq: false?
Many thanks!

Duplex sequencing is where you have a UMI on each original strand of the molecule, and you require to have sequenced reads from both strands of the original DNA and them to have the same UMIs. This decreases the error rate (but also decreases the sequencing depth, as you have to have captured sufficient copies of each strands).
Nothing to do with paired-end sequencing, although paired-end sequencing is required to be able to perform duplex sequencing.


Consider replacing single CURL handles with a resource pool?

I was really glad to see that curlhs seems to take care to be thread-safe and all that as we'd like, by using MVar locks.
But in my client I'll need a resource pool of CURL handles. I could of course do this with the existing interface, making several handles and sticking them in a resource-pool, that might mean some redundant locking (doing mutual exclusion in both the CURL handle and the resource pool.
Would you be open to an API that replaces use of handles with an internal pool, if I were to make those changes?
To be safe I think this would mean changing functions like:
foo :: CURL -> a -> b -> IO c

to:
foo :: a -> b -> CURL c

where CURL is opaque, but instance MonadIO, and we provide something like:
newCurlPool :: Int -> IO Pool
runCURL :: Pool -> CURL a -> IO a

I'm going to do some experiments and see if the locking is even affecting performance in my application, and will report back. But let me know what you think, or fee free to close if you're not interested in this sort of change.

After testing, I can't measure the performance impact of getting rid of MVar operations, so this could probably be closed.


[Bug Report] File upload using xhrRequestAdapter() doesn't handle multipart form data

Reproduction Link
https://codesandbox.io/p/sandbox/alova-test-upload-w46x26?file=%2Fsrc%2Fapi.ts%3A9%2C22-9%2C41
alova Version
2.8.0
Describe the Bug
Using the xhrRequestAdapter() to upload a file, via FormData, as shown in the example on https://alova.js.org/extension/alova-adapter-xhr#upload sets the Request Headers Content-Type to application/json; charset=UTF-8 instead of multipart/form-data which means my server cannot process the uploaded file.
I tested with the axiosRequestAdapter() and it correctly adds the multipart/form-data; boundary=---- Content Type including the boundary.
But I don't want to use Axios!
Is this by design?
(Note this is also related to a discussion I added earlier https://github.com/alovajs/alova/discussions/132)
Reproduce Steps
Using the example code from the documentation, upload a file and look at the request headers. Or use the codesandbox.io example.
Device / Browser / Browser Version
No response

Thanks for your issue.❤
i will reproduce this bug by your demo, and try to resolve it as soon as possible.

@proddy Now it is fixed. please upgrade @alova/adapter-xhr to v1.0,1.

Confirmed it's fixed and works beautifully. Thanks for the quick fix!

You happy I happy.😁

another probably issue I found is that during a file upload, calling the method's abort() doesn't cancel the upload, as it does in axios. Shall I open a new issue for this @JOU-amjs ?

@proddy I will try to reproduce it later. If it cannot be reproduced, I will tell you to open a new issue

@proddy I didn't find this problem. codesandbox link is here.
you can check follow steps below.

is alova's version v2.6.2+
is the method that to be aborted same reference as the method that send request
is the request currently in progress when aborting the request
has method.abort been called

if still has problem, you can open a new issue and reproduce it base on my codesandbox link.

Thanks for responding, and very cool of you to create a codesandbox for this. What I'm trying to do give the user the ability to cancel an upload by clicking on a 'cancel' button. With axios I was using AbortController() and with my port to Alova now trying to find something similar. I first thought of using the abort function in the useRequest as per the example in https://alova.js.org/learning/use-request/#abort-request-manually but this didn't seem to work and I don't want to add it to the createAlova instance via method.abort is this is specific to one use case.
I'm not sure it's a bug - shall I create an issue, create a discussion or leave it here?
https://codesandbox.io/p/sandbox/alova-test-upload-w46x26
thanks again for this great library!

@proddy 😂I think you can leave here to open a new issue.
I will check it later.


WandbLogger does not seem to support model and parameter tracking

I am unsure whether this issue can be fixed from PyTorch Lightning's side or whether the issue lies with Wandb.  The problem is that the WandbLogger.watch() function
https://github.com/PyTorchLightning/pytorch-lightning/blob/c46de8a3d4a18e5030dc9f07e96bb6abc7643945/pytorch_lightning/loggers/wandb.py#L136-L137
calls the watch() function in wandb/sdk/watch_run.py (on Wandb's side), which is basically commented out.
def watch(self, models, criterion=None, log="gradients", log_freq=100, idx=None):
    logger.info("Watching")
    # wandb.run.watch(watch)

If the last line of that function is changed to wandb.watch( models, criterion, log, log_freq, idx) (this function is in wandb/sdk/watch_watch.py) then everything seems to work like it should. Alternatively, I think it should be possible for WandbLogger.watch() to call  wandb.watch( models, criterion, log, log_freq, idx) directly.
It seems @borisdayma previously worked a lot on Wandblogger, so I'll mention him.

Hi, it should have been fixed.
Can you confirm what version of wandb you are using?

@borisdayma sorry, and thanks. I was using version 0.10.0 (from a week ago), but the issue was indeed fixed with 0.10.1 from 2 days ago.


Migrating links from the old/current ClinicalTrials.gov website to the new version

The ClinicalTrials.gov are deprecating the old links that we use and forwarding them to a classic view. It might be good to start migrating to the URLs
Background
To reproduce:

Go to a drug profile page
Scroll to the Clinical Precedence section.
Click on the ClinicalTrials.gov entry in the "Source" column
You will be redirected to the classic ClinicalTrials.gov website with a warning banner informing about the migration.

[Old] https://clinicaltrials.gov/ct2/show/NCT02967965
[New] https://www.clinicaltrials.gov/study/NCT02967965
Tasks

[ ] Ensure the links are redirecting to the new ClinicalTrials.gov website in all the relevant sections (see comment below)
[ ] If we are using identifiers.org for this, the task is to update identifiers.org registry instead of our website: https://identifiers.org/resolve?query=clinicaltrials:NCT02967965
[ ] Secondary task - Can we make better use of the ClinincalTrials.gov data from the new site/API?

ClinicalTrials links are visualised in the following sections (please add if I am missing any):

[ ] ChEMBL evidence widgets - from the API ChemblQuery

[ ] Known Drugs target/disease profile widget - from the API KnownDrugsQuery

[ ] Clinical Precedence drug widget - from the API KnownDrugsQuery

[ ] Indications drug widgets - hardcoded in FE

[Old] https://clinicaltrials.gov/ct2/show/NCT02967965
[New] https://www.clinicaltrials.gov/study/NCT02967965
It does not seem like we use the identifiers.org registry but will double check again.

Discussed in the FE meeting on 4/10/23: Luca will work on this ticket with me when he's back from his holidays

Will discuss this in the devs meeting on Monday; it seems all queries would need updating at data/API level.
Will check the query for the Indications drug widget with backend team - should it not be possible to have that updated at API level, we can just fix the hardcoded link.
From the Indications query:
indications {
      rows {
        references {
          ids
          source
        }
      }
    }

returns something like:
"references": [
              {
                "ids": [
                  "NCT01037660"
                ],
                "source": "ClinicalTrials"
              }
            ]

It seems that the indications references is intended in a different way than the urls field in the other queries, and probably for this reason was not returning a url for ClinicalTrials?
I guess it might stay in this format, so for now I've simply updated the url for clinicaltrials in the platform config files.
It might also be no longer fully relevant as ClinicalTrials.gov are now redirecting correctly to the new URL without any warning message.

PR ready for review for changes to the **Indications widget (**updated hardcoded url): if the info will then come from the API, then these changes will need to be updated.
Front-end wise that is the only change, as for all other widgets the required changes are API only.

Since now clinicaltrials.gov is now automatically redirecting the old links to the new page, it has solved this issue.
However this leads to the links being displayed in our platform being different that where you land up on the clinicaltrials.gov page which will be fixed after changes in the backend.
FYI @buniello


Add a Script to a node not working sometimes

Godot version:
Godot 3.0.3-rc2 win64
Issue description:
When the project get more and more complicated ... when i add a new script to a new node .. it add fine .. i run to test it .. it's not working .. the Editor says that node have that script .. but it's not saved in resource file of that node or scene
when i close Godot and reopen it again .. the node will have no script
and how to fix that is i need to remove .import folder and open the project again .. let Godot load everything again .. add the same script to that node again .. it works fine
Edit : sometimes it's not fixed like that
sometimes i need to Open the node scene in Text editor and add the script path manually
like this for exampled adding this line
[ext_resource path="res://Scripts/GUI/mybutton.gd" type="Script" id=1]

How big is "huge amount", again? 20? 30? 50?

What happens if you add the script, hit ctrl+s, then close and reopen godot?

@eon-s nothing .. it does not save the script path at all ... it show save progress bar popup .. but don't save the node / scene and the script
i need to do it manually : open the target scene in a text editor and add the script path like this
[ext_resource path="res://Scripts/GUI/mybutton.gd" type="Script" id=1]
save and close ... remove .import folder , open Godot and let it load the project again ... this way work
in Godot 3.0.2 Stable everything work Great

And no error output on the console window on add script or close?

@eon-s Nothing ... everything is fine until i run the scene to test it - and when i test it .. it's like a scene without a script
Close and open Godot again .. the scene or the node does not contain the Script that i added

This issue is old (and the author has deleted their account from GitHub), so I'll close this. Please create a new issue if you can still experience a similar bug.

I am having a similar problem with 3.2.3.stable. Right-clicking a scene and adding a script does not correctly link the script. I have to manually edit the scene outside of Godot.

@mtedmist Please create a new issue if you can still experience a similar bug.


Lower required version of symfony/*

LGTM

Should go to 1.0.x

Guys thanks a lot for this PR! Could you please tag the commit as v1.0.1 so it could be picked by composer in all circumstances?

@tmatsuo?

@kachkaev on it

@kachkaev I have just tagged 1.0.1. Please let me know if all goes well :)

Travis built works for Symfony 2.3 now, thanks!

Great to hear :)


issue: omada access-point incompatible with EAP245 ?

just an FYI, that there is an error when trying to execute omada access-point against an older access point EAP245(US) v3.0:
it works find with EAP773(US) v1.0
notes:

there are no VLAN configured in this case,
the eap245 uses the same site-wide-default configuration as the other access points.
other commands seem to work fine with the EAP245...

ff@hal:~/naxdev/logs$ omada access-point wee_wifi
Name: wee_wifi
Address: AA-BB-CC-DD-EE-FF (<IP_ADDRESS>)
Status: CONNECTED (CONNECTED)
LAN Ports: 1
Traceback (most recent call last):
  File "/home/ff/.local/bin/omada", line 8, in <module>
    sys.exit(main())
  File "/home/ff/.local/lib/python3.10/site-packages/tplink_omada_client/cli/__init__.py", line 74, in main
    return asyncio.run(args.func(vars(args)))
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "/home/ff/.local/lib/python3.10/site-packages/tplink_omada_client/cli/command_access_point.py", line 22, in command_access_point
    print(f"   Port {p.port_name}  PoE Supported: {get_checkbox_char(p.supports_poe)} {get_power_char(p.poe_enable)}  Vlan: {get_checkbox_char(p.supports_vlan and p.local_vlan_enable)} {p.local_vlan_id}")
  File "/home/ff/.local/lib/python3.10/site-packages/tplink_omada_client/devices.py", line 371, in local_vlan_id
    return self._data["localVlanId"]
KeyError: 'localVlanId'

This should be fixed in the version 1.4.1. Please give it a try and let me know.


Stop translations with unknown types

Describe the bug
The data are not transmitted after the translation of data of an unknown type.
To Reproduce
Steps to reproduce the behavior:

Initial state I have: [RTU HNZ] running <=> [FLEDGEPOWER] running <=> [CENTER 104] running
A status point of type TS must be configured on the RTU, and south service on fledge.
A status point of type M_ST_TB must be configured on the north service and center.
Sending the status point from the RTU.
The data is not translated and no more data is transmitted

Expected behavior
If the translation plugin consumes an unknown data type, the plugin does not produce data.

Erroneous state with no transmission is no longer reproduced with M_BO_TB.


Hotfix: Always set pretrained_model_name_or_path as string

Hello!
Argilla Community Growers
Ever since #3751, model can also be an already initialized model. This edge case was being missed before. This should help with the test failures on #3911.
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (change restructuring the codebase without changing functionality)
[ ] Improvement (change adding some improvement to an existing functionality)
[ ] Documentation update

How Has This Been Tested
pytest .\tests\integration\client\feedback\training\test_trainer.py::test_argilla_trainer_text_classification_with_model_tokenizer
Checklist

[ ] I added relevant documentation
[ ] follows the style guidelines of this project
[x] I did a self-review of my code
[ ] I made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I filled out the contributor form (see text above)
[ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Tom Aarsen

More unrelated test failures :(


Clarify that Zkr depends on Zicsr

As this extension defines its own CSR seed, it's more natural to have this sentence.
Resolves #350.

Hi, we will add this note to the main documentation (not here.) Thanks for the note.


Low prio - Run commands from chat

Add hooks to call any commands implemented by the Rcon class  and/or in the API from the ingame chat.
Check against the steam ids of the moderators (need to check against the Django DB though, so it's adding a weird co-dependancy and will break the separation of concerns a bit, or find another way)

See : https://github.com/MarechJ/hll_rcon_tool/pull/678


Bug in xhr done (typo)

Hi, found a bug on next branch in xhr done @line 19430
translatedResponse = ( $.isFunction(settings.onResponse) )
                  ? module.is.expectingJSON()
                    ? settings.onResponse.call(context, $.extend(true, {}, response))
                    : settings.onResponse.call(>>>conetxt<<<, response)
                  : false

Thanks

You could always submit a PR... If you've identified an issue and a fix, and the fix only involves swapping two characters around, a PR is much more helpful than an issue. If you don't want to submit a PR, I can do it for you.

This seems to be resolved, couldn't find any typo conetxt


Add some acceptance tests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Stefan Pingel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.