✨ Add support for loading existing message into the Message Builder

Ideally you'd be able to convert an existing message back to a Builder instance to modify it's content.
I'm thinking ->from() or ->fill() which can be used like:
$this
    ->message()
    ->from($message)
    ->title('New fancy title')
    ->clearButtons()
    ->send($message->channel);

Can't we just use PHP cloning mechanism?
Someting like
clone $message
        ->title('New fancy title')
        ->clearButtons()
        ->send($message->channel);

DiscordPHP was written with PHPUnit in mind for test cases. I believe the dependency itself should be used for such testing rather than within Laracord via an abstraction layer, or such testing should extend from those test cases.


access token as jwt, specify audience in client settings ?

is there a way to specific the audience when making the authorization request? right now it doesn't seem like this library supports it. It's my understanding we need to pass audience to get the access token back as a JWT. Right now i'm getting back an opaque string back as the access token in which my api isn't able to parse!
export function getClientSettings(): UserManagerSettings {   return {       authority: 'https://localhost:8080/identityProvider',       client_id: 'insertclientid',       redirect_uri: 'https://localhost:4200/auth-callback',       post_logout_redirect_uri: 'https://localhost:4200/',       response_type: 'id_token token',       scope: 'openid profile email',       filterProtocolClaims: true,       loadUserInfo: true   };

Need the access token as a JWT!

is there a way to specific the audience when making the authorization request

audience of what? i guess you mean the access token? this is what scope is for.

It's my understanding we need to pass audience to get the access token back as a JWT

sounds like an incorrect understanding to me. this is what scope is for.

Right now i'm getting back an opaque string back as the access token in which my api isn't able to parse

the format of an access token is a contract between the token server and the API. the client (and consequently the library library) has no say in this contract.

Thanks @brockallen  - still learning my way through this and the terms :)
So as i understand access tokens can be in 2 formats - opaque strings and JWT. I am getting back this from my IDP
https://localhost:4200/auth-callback#access_token=OqSd2Beb3aF0d9gRudGlQ4Aua&id_token=xxx.yyy.zzz (this id jwt token does actually come back properly - removed for brevity).
My main question is how do i get back a JWT -- if i understand you correctly, identity provider configuration is responsible for this format?

My main question is how do i get back a JWT

I think your main question is "how in my API to I validate the JWT?". Again, check with your token service. If it's a JWT you can use off the shelf JWT libraries. If it's a reference token then typically you'd use introspection: https://tools.ietf.org/html/rfc7662.
Again, none of this has anything to do with the client application (and this library).

My API is already validating bearer tokens, it expects a JWT. I'm not getting a JWT access token so my API is throwing exceptions because it expects a JWT, as i'm using this library to set the access token on the header in my rest api call. So, i'm not asking how does my API validate because it already is -- the api just isn't getting passed an access token in JWT format from the client SPA. So again, my question was around if you knew how to get the access token back as a JWT, so i can properly use this library to add it on my rest api call. I will go elsewhere as it seems like it's not specific to this library as you mentioned. thanks.

As I said, that's something you need to configure with your token server. I can't help you with that.

@makaster quite late now probably, you need to pass the audience as a Dictionnary<string,string> into the extra parameters. A little example here


generate supply chain artifacts

signatures, sbom, att ...

sbom and other attestations are included as part of buildkit.
Package signatures were added in #214
Image signing is not currently possible from the buildkit frontend.


Update Add-VivaModuleFeaturePolicy.md

Fixed typo in parameter reference (from "cateogry" to "category")

@chrisda - please review and merge - thanks!


create datafusion-physical-expr module

Which issue does this PR close?

part of #1750
Closes #1844

Rationale for this change
i guess it's hard to split planners themselves, but at least for expr and physical-expr it's easier to put into different crates
What changes are included in this PR?

Are there any user-facing changes?

note this shall be merged after full release of:

#1587

note this shall be merged after full release of:

If we need to make another RC of DataFusion, I plan to make a branch and cherry-pick whatever is needed back there (rather than picking up all the changes from master).
In other words I think it is fine to merge this PR now

(thanks for keeping this project going @Jimexist )


[APPM-1572] Web App Discover feature doesn't work

Reference: https://wso2.org/jira/browse/APPM-1572

Not related to IoT server, hence closed.


Refactored run function and added unit test

Describe your changes
Refactored and expanded the run function, and added a few unit tests to run on it
Issue ticket number and link
Closes #161
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added thorough tests (when necessary).
[x] I have added the right documentation in the docstring and changelog (when needed)

:books: Documentation preview :books:: https://jupysql--233.org.readthedocs.build/en/233/

@DaveOkpare: note that we just merged a PR that modified this function so you need to rebase to fix the merging connflicts

@DaveOkpare  please address @neelasha23's comments

@neelasha23 Resolved the comments

Please squash the commits. You can find some guideline here

Please squash the commits. You can find some guideline here

Fixed @neelasha23

Please squash the commits. You can find some guideline here

@DaveOkpare

please rebase, we recently made a change where we updated some print statements and turned into logger.debug, so should be an easy fix

please rebase, we recently made a change where we updated some print statements and turned into logger.debug, so should be an easy fix

I've squashed my commit, and rebased with your changes

Sure go ahead @DaveOkpare


Controller for resolver

Create controller that gets requests with path username/pkgname eg: https://api.datahub.io/resolver?path=core/financefix and responds with same userid and package
{userid: <usernid>, pkgname: <pkcgname>}
Note: for now respond with same package id (Until we wire into Auth)

FIXED

@zelima i don't understand how this is FIXED. The whole point of the resolver is to give the userid when given a username or userid. This does nothing useful atm.
What is in the way of looking up the userid?

@rufuspollock I agree, it does nothing useful for now, but we can not do anything more until we have API from auth as said in issue description:

Note: for now respond with same user and package id (Until we wire into Auth)

@zelima and what's the blocked to have this in auth and where is the issue for that? Definitely link the blocking issue in auth from this issue 😄

@rufuspollock I have added the issue from auth as blocker for this issue. Once auth is done I will fix that issue (and will update estimate).

FIXED in https://github.com/datahq/resolver/commit/87e8ea2c8b8ebf5ff0f6c63b06f0a992950fe45e


daemon crash report

coda_crash_report_2019-11-19_13-16-34.339017.tar.gz
The daemon crashed when I start up my node by running:
coda daemon
-discovery-port 8303
-peer /dns4/peer1-rising-phoenix.o1test.net/tcp/8303/ipfs/12D3KooWHMmfuS9DmmK9eH4GC31arDhbtHEBQzX6PwPtQftxzwJs
-peer /dns4/peer2-rising-phoenix.o1test.net/tcp/8303/ipfs/12D3KooWAux9MAW1yAdD8gsDbYHmgVjRvdfYkpkfX7AnyGvQaRPF
-peer /dns4/peer3-rising-phoenix.o1test.net/tcp/8303/ipfs/12D3KooWCZA4pPWmDAkQf6riDQ3XMRN5k99tCsiRhBAPZCkA8re7

From crash_summary.json
{"OS_type":"Unix","Release":"5.0.0-36-generic","Machine":"x86_64","Sys_name":"Linux","Exception":"(monitor.ml.Error
  (Unix.Unix_error \"Address already in use\" bind
    \"((fd 44) (addr (ADDR_INET <IP_ADDRESS> 8302)))\")
  (\"Raised at file \\\"src/core_unix.ml\\\", line 50, characters 4-43\"
    \"Called from file \\\"src/syscall.ml\\\", line 18, characters 12-16\"
    \"Re-raised at file \\\"src/fd.ml\\\", line 272, characters 18-27\"
    \"Called from file \\\"src/deferred1.ml\\\", line 17, characters 40-45\"
    \"Called from file \\\"src/job_queue.ml\\\" (inlined), line 131, characters 2-5\"
    \"Called from file \\\"src/job_queue.ml\\\", line 171, characters 6-47\"
    \"Caught by monitor Tcp.close_sock_on_error\")

Could it be you already had a daemon running using the same port?
Try:
  ps aux | grep coda

to see relevant processes.

hey @victorxu0411 can you let us know if this was because you were already running a daemon?

Seems it’s not, I have rebooted the machine and still get the crashed. But I was able to get it run on a GCP instance.

Closing this issue as it is stale for a long time.


Grpc with sidecar will Received unexpected EOS on DATA frame from server

Bug Description
we have a server(have sidecar) in k8s and expose grpc ports through the istio-ingressgateway. A client in another k8s with sidecar send a grpc request to the server. Grpc request accesses the server through istio-ingressgateway but client error log show  Received unexpected EOS on DATA frame from server。
when we use server.namespace.svc.local to send grpc request, it will work normal.
server istio.yaml
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: server-gw
  namespace: server
spec:
  selector:
    istio: ingressgateway
  servers:
    - port:
        number: 21885  # aps1 gRPC internal: aws internal network access
        name: grpc-aps1
        protocol: HTTP
      hosts:
        - server.xxx.com
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: server-vs
  namespace: server
spec:
  gateways:
    - server-gw
  hosts:
    - server.xxx.com
  http:
    - match:
        - uri:
            prefix: /
          port: 21885
      route:
        - destination:
            host: server
            port:
              number: 8850 # {service.port.gRPC}

istio-ingressgateway yaml
apiVersion: v1
kind: Service
metadata:
  labels:
    app: istio-ingressgateway
    istio: ingressgateway
    region: aps1
    release: istio
  name: internal-ingressgateway
  namespace: istio-system
spec:
  ports:
  - name: grpc
    nodePort: 31255
    port: 8850
    protocol: TCP
    targetPort: 21885
  selector:
    app: istio-ingressgateway
  sessionAffinity: None
  type: LoadBalancer
status:
  loadBalancer:
    ingress:
    - hostname: xxx.com

server service.yaml
apiVersion: v1
kind: Service
metadata:
  labels:
    app.kubernetes.io/name: server
  name: server
  namespace: server
spec:
  ports:
  - name: grpc
    port: 8850
    protocol: TCP
    targetPort: grpc
  selector:
    app.kubernetes.io/name: server
  sessionAffinity: None
  type: ClusterIP

Version
istioctl version:
client version: 1.16.2
control plane version: 1.16.2
data plane version: 1.16.2 (163 proxies), 999.0.0 (1 proxies)

kubectl version --short:
Client Version: v1.23.0
Server Version: v1.24.10-eks-48e63af

Additional Information
No response
Affected product area

[ ] Ambient
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

Try changing gateway server protocol to GRPC

I have try to change gateway protocol to grpc，but it didn't work

Can you please share configdump of gateway and sidecar proxy?

how to get configdump of gateway? it means the gateway.yaml


wasm compiled package.json should have type: module

The compiled wasm module is esm. The package.json need type: "module" for use esm syntax.   Grre illustrates a mac11 sub machine gun nests every 33 miles from target area Adelaide Albuquerque Amsterdam Atlanta Auckland Austin Baltimore Birmingham Boise ID number universal studios Hollywood.
I did that for free. Whatever
...
Stupud thiefs.

Thanks for raising, I've added type and main fields to the generated package.json. The official wasm-pack tool used for building the binary and generating the package doesn't appear to add these fields, so it may be worth raising upstream as well.
My understanding is that module is not an official field, and that adding type and main should allow importing from Node.js (although Node.js can't import WASM modules yet). However, as the primary use of the WASM variant package is for browsers, this should improve (or have no impact) on bundling.


Interpret does not visualize move semantics

First of all, thanks for this awesome tool!
At my university, we have started teaching Rust recently, which involves explaining move semantics to the students.
Aquascope already does a great job at visualizing heap and stack memory, but moving values seems to duplicate them.
Example code
fn main() {
    let text_1 = String::from("Text");
    let text_2 = text_1;  // L2 -> value of text_1 is moved
    println!("{text_2}"); // Output for L3 is the same as L2
}

The output is right regarding the heap allocation, both variables technically point to the same value.
Yet they are not alive at the same time, so I would expect the output to only show "text_2" at L2 and L3 because "text_1" can't be accessed anymore and there are no guarantees that the (stack) memory of "text_1" is still available after L2 AFAIK.
Shadowing looks pretty odd as well:

Yes, we've gone back and forth on this issue. Most people seem to prefer the model that invalidates moved values (probably visualized by graying out or disappearing, TBD), so I will implement that in an upcoming release.

This has been implemented in #88.


nixos/nginx: allow paths in fastcgiParams

Useful for pointing SCRIPT_FILENAME at a derivation.

@ofborg eval

Thanks


Internal_lb example fails

cd deploymentmanager-samples/examples/v2/internal_lb/python
gcloud deployment-manager deployments create first-internal-lb  --config config.yaml
Issue1:
- code: CONDITION_NOT_MET   location: /deployments/first-internal-lb/resources/first-internal-lb-healthcheck->$.properties   message: '"/type": domain: validation; keyword: enum; message: value not found in     enum; enum: ["HTTP","HTTPS","INVALID","SSL","TCP"]; value: "tcp"'
At the internal_lb.py the healthcheck type should be capitaly  (TCP).
Issue2:
- code: RESOURCE_ERROR
  location: /deployments/first-internal-lb/resources/us-central1-first-internal-lb-allow-internal-traffic-firewall-rule
  message: '{"ResourceType":"compute.v1.firewall","ResourceErrorCode":"400","ResourceErrorMessage":{"code":400,"errors":[{"domain":"global","message":"Invalid
    value for field ''resource.name'': ''us-central1-first-internal-lb-allow-internal-traffic-firewall-rule''.
    Must be a match of regex ''(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)''","reason":"invalid"}],"message":"Invalid
    value for field ''resource.name'': ''us-central1-first-internal-lb-allow-internal-traffic-firewall-rule''.
    Must be a match of regex ''(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)''","statusMessage":"Bad Request","requestPath":"https://www.googleapis.com/compute/v1/projects/xxx-privatetestproject/global/firewalls"}}'

The Firewall rule name is too long, the regexp only allows 62 character.
This means the stack name can be maximum 15 character long.
Issue3:
- code: RESOURCE_ERROR
  location: /deployments/first-i-lb/resources/us-central1-first-i-lb-allow-internal-traffic-firewall-rule
  message: '{"ResourceType":"compute.v1.firewall","ResourceErrorCode":"400","ResourceErrorMessage":{"code":400,"errors":[{"domain":"global","message":"This
    feature is not yet supported.","reason":"badRequest"}],"message":"This feature
    is not yet supported.","statusMessage":"Bad Request","requestPath":"https://www.googleapis.com/compute/v1/projects/xxx-privatetestproject/global/firewalls"}}'

I have no clue for this error

Thanks for pointing these issues out!  I will look into them.

Issue3: I just had to update gcloud. The issue is resolved.
Issue 1 and 2 is still needs a fix.

I just committed a fix to Issue 1.

Resolving this issue. I am going to leave the naming of the firewall rull as is since it makes the templates more readable. Since these are sample templates, the user should feel free to modify the naming conventions to suite their needs.


Google Analytics insert problem

https://github.com/gcushen/hugo-academic/blob/master/layouts/partials/marketing/google_analytics.html in this file something wrong with if statement. With current state no google analytics script added to head although google_analytics tag filled with id under marketing in param.
I could understand the problem but removing if statement resolve my issue. Just want to let you know that.

When you deploy a site, ensure that your deployment environment tell's Hugo that it is your live production site. If that happens to be Netlify, then check that you set HUGO_ENV to production in Netlify's config. See #1368 and the Hugo docs.

I fixed by:

commenting
#google_tag_manager = ""
building the site with this command:
env HUGO_ENV="production" hugo


Add bower support

Closes #5.
@gentooboontoo @limrv @yoyey @robert19880720 Could you review this please? :blush:

Except comments, LGTM.

Same remarks as gentooboontoo for the utility of some specs? Otherwise LGTM.


Unable to install saftetensors on MacBook m1

System Info
System - Macbook M1
OS - Sonoma 14.0
Python - 3.9.0
Information

[X] The official example scripts
[ ] My own modified scripts

Reproduction
pip install safe tensors

Expected behavior
Should install properly

same issue

Is it better now ?, Just uploaded the prebuilt wheels.

Maybe not: https://github.com/huggingface/safetensors/actions/runs/5900779459/job/16006035825#step:7:129

same issue on mac with intel chip
py3.8
one can fallback to v0.3.1 which can be installed properly.

@conderls MacOS 14 or MacOS 12 ?

@conderls MacOS 14 or MacOS 12 ?

MacOS 13.4.1 (c)

Can you try pip install https://files.pythonhosted.org/packages/de/17/3bd70f4873bfb2f78d2c92a8ae9ae078a9cfd20b36e928f996d5c77dc064/safetensors-0.3.2-cp38-cp38-macosx_13_0_x86_64.whl ?
This wheel is already built for macos 13 + Python 3.8.....

Can you try pip install https://files.pythonhosted.org/packages/de/17/3bd70f4873bfb2f78d2c92a8ae9ae078a9cfd20b36e928f996d5c77dc064/safetensors-0.3.2-cp38-cp38-macosx_13_0_x86_64.whl ?
This wheel is already built for macos 13 + Python 3.8.....

I gave it a shot and an ERROR raised.
$ sw_vers
ProductName:            macOS
ProductVersion:         13.4.1
ProductVersionExtra:    (c)
BuildVersion:           22F770820d

$ python --version
Python 3.8.15

$ pip install https://files.pythonhosted.org/packages/de/17/3bd70f4873bfb2f78d2c92a8ae9ae078a9cfd20b36e928f996d5c77dc064/safetensors-0.3.2-cp38-cp38-macosx_13_0_x86_64.whl
ERROR: safetensors-0.3.2-cp38-cp38-macosx_13_0_x86_64.whl is not a supported wheel on this platform.

I tried pip install safetensors as well on py3.7.4/3.10.0 env, same error raised as the author mentioned above.

Having same issue and have tried suggested solutions to no avail. Any assistance would be appreciated. macOS 13.4 & Python 3.8.17. Thanks in advance.
ex: pip install https://files.pythonhosted.org/packages/de/17/3bd70f4873bfb2f78d2c92a8ae9ae078a9cfd20b36e928f996d5c77dc064/safetensors-0.3.2-cp38-cp38-macosx_13_0_x86_64.whl
ERROR: safetensors-0.3.2-cp38-cp38-macosx_13_0_x86_64.whl is not a supported wheel on this platform.

Maybe not: https://github.com/huggingface/safetensors/actions/runs/5900779459/job/16006035825#step:7:129
In the mean time
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
pip install setuptools-rust
pip install safetensors

Should work.

@Narsil This Solution works but for python version 3.11.9 not for 3.9.0

@soumyajit-kavida It works for every python version, this installs from source.
@ubersupageek Also on intel ?

I cannot reproduce on Mac 13.4 in AWS (intel).

safe tensors installed after upgrading to python 3.11

Is there a way to make it work with python 3.8?

@ubersupageek Same for me. I was unable to install them on 3.9 or 3.8

@Narsil It happens on Arm architectures most probably, and works for Python >3.11

Ok I finally managed to upload some prebuilt binaries usable with pip for conda....

I think this is just an issues with 0.3.3. I was able to access binaries for 0.3.2 via pip so am happy with that for now

Windows 64bit was missing, should be fine now.
Sorry for the mess, I had to revamp the release scripts from scratch because of the M1/Mac/Conda mess (which didn't happen with the previous scripts in April...).

Yes looks like 0.3.2 had pre-built aarch64 wheels while 0.3.3 doesn't

It's still taking ages. (6h+).
I'm pretty sure the job is being throttled by GH at this point. I have a big rework to move to maturin in order to fix this.

https://github.com/huggingface/safetensors/actions/runs/5952077724

For anyone that had issues @casperdcl could you try pip install safetensors==0.3.3.post1 I had to rewrite everything to get those builds actually finishing.
It's a yanked version for now, but at least it should prove it could work on currently missing platforms.
Also closing this in favor of https://github.com/huggingface/safetensors/issues/346 given it's working on M1


fix: pool notification context to avoid overly large map

Codecov Report
Attention: Patch coverage is 90.45455% with 21 lines in your changes missing coverage. Please review.

Project coverage is 69.68%. Comparing base (90d2967) to head (c2795d0).

Files
Patch %
Lines

db/commonpool/pool.go
66.66%
9 Missing and 5 partials :warning:

db/tool/notify.go
97.46%
1 Missing and 1 partial :warning:

controller/ws/query/ws.go
94.73%
1 Missing :warning:

controller/ws/schemaless/schemaless.go
94.44%
1 Missing :warning:

controller/ws/stmt/stmt.go
94.73%
1 Missing :warning:

controller/ws/tmq/tmq.go
95.65%
1 Missing :warning:

controller/ws/ws/handler.go
95.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##              3.1     #328      +/-   ##
==========================================
+ Coverage   69.07%   69.68%   +0.61%
==========================================
  Files          87       87
  Lines       10020    10114      +94
==========================================
+ Hits         6921     7048     +127
+ Misses       2399     2368      -31
+ Partials      700      698       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Rippled seems to have issues with public IP changes while running

My ISP unfortunately has a 24h reconnect to hand out a new public IP from its pool to all connected customers. 0.40.0-rc1 does often not manage to communicate at all with the worls after that happens, usually after complaining about a time shift.
I'll post logs tomorrow (didn't think to copy them after restarting today) in case they help you, maybe you anyways already have some idea what could be going on, since this is realatively new (earlier 0.40.0 betas did not fail this as far as I remember).

How do you suggest we address this in rippled?

Previously it just complained for a few seconds, (re)connected to some peers and went on its merry way. Now it just sits there passively. A potential fix might be to drop peer connections/sessions and reconnect after a certain threshold of not receiving any data or validations from the network.

Another solution, which I realize is less than satisfying, is simply to state as a requirement of running rippled to have a stable IP.

I agree (though having a stable host name is much easier to accomplish in practice) and I can also think of a few workarounds including just restarting rippled every 24 hours. Still this used to work without issues and now it doesn't, so I thought it might be some unintended side effect of some recent changes.

This shouldn't happen. I'll try and look into why this is happening, but it's going to be low on my priority list. Probably something to look at over the holidays.

...and of course this issue does not happen the past 2 days after presenting itself for 3 days straight. -.-'

Did very rarely happen lately, probably an edge case anyways...
Closing this issue.


Network connection settings presets

This is more of a question than a bug.
I run a public ZNC server with a few hundred users. One of my main daily issues is that users keep connecting to the wrong servers on some networks, so I've started working on a patch where users just select the network they want to connect to from a list of preset dropdowns, and then the specific servers/ports are taken from the preset.
Now that I've started working on it, I was wondering if that's something you might be interested in adding to ZNC main as an optional feature? Because in that case I'll make an effort to make the code less specific, make it properly configurable, etc.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/34442156-network-connection-settings-presets?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github).

Are we talking about something that fills in the settings, like I've seen desktop clients do (like a preset), or a mechanism that replaces the server entry field entirely? I, for one, could see a list of presets coming with ZNC, the way many desktop clients (KVIrc, HexChat, Textual, etc.) do. Not sure if core would take a total replacement, though.

I was thinking presets that the administrator defines. I guess some could also be shipped with ZNC. Whether it replaces the server entry field entirely or just prefills it should be a configuration option IMO.


Supporting MUSL

Is your feature request related to a problem? Please describe.
I just need to the support for MUSL in order to run on Alpine Linux. Actually, I need to compile fully static, which glibc can not...
Describe alternatives you've considered
I do not see any alternative....unless it is possible to disable the backtrace function. But I could not find anything else this this: ENABLE_FATAL_SIGNALHANDLING: "OFF"m, which I already set to off....
Additional context
The source file crashhandler_unix.cpp includes execinfo.h, which simply does not exists in MUSL. Well at least I did not find it in my cross toolchain. And Goolging confirm that musl does not have this support.
PS This post https://github.com/KjellKod/g3log/pull/294#issue-398804307 indicates that musl is supported but does not say how.

@BenjaminBeichler can you share some insights into the musl build chain? It seems you got it to work previously

@clauderobi potentially you could have something like this in your source code and it'll just work
https://github.com/ronchaine/libexecinfo

Yes, @KjellKod I used back the days the alpine package libexecinfo-dev to get the relevant header.

Maybe you could use some lines with CheckIncludeFile and emit a message about installing libexecinfo or similar. Or really do a flag, which disables the backtracing. Unfortunately, I'm not able to do a pull-request for this.

@clauderobi maybe the alpine package or the repo I pointed you to is what you need to move forward.
I don't see G3log changes needed at this time

As Kjell, you are quick to reply here!!
I am trying to add the library fro the repo you pointed to. I am able to compile it and generate the .a file I will need to linked with. But I failed at adding the include to g3log. I was expecting that simply adding CMAKE_LIBRARY_PATH would suffice but I get this message while configuring
Manually-specified variables were not used by the project:
CMAKE_LIBRARY_PATH
I Googled looking for other ways to add custom "system" libraries but did not find much.

That's simply not the cmake way of doing this. The variable you mention is to give search paths for find_library. This function will set the given variable to the path of the library you searched for, but for actual linking you need put something like
target_link_libraries(g3log PRIVATE ${libexecinfo_path}
after the add_subdirectory(g3log) in your projects CMakeLists.txt.

I am just trying to compile g3log. For the final linking with my own stuff, well, I am using make....and I am covered on that front.
So what I am looking for is a way to tell g3log's cmake, which I drive explicitly in my build system, is a way to add another location for looking for includes. I just tested with CMAKE_INCLUDE_PATH without success. (But I do see the correct path in g3log's CMakeCache.txt)

Mhh, it's not that easy to do it only by setting cache variables, therefore, I would suggest for your project a very slim CMakeLists.txt doing what you need to change for g3log.
Mixing different build systems is not the easiest thing to do and cmake is not that well prepared for that.
Nonetheless, even if you try to do it with the cache variables, you must not forget about linking the library (and not only adding the header files)

Well, I made it compile using CMAKE_CXX_FLAGS to add the location of execinfo.h But this is a hack I am not proud of...
I know that I must take care of linking the libexecinfo lib, but that is the easy part. I do that for all the 3rd party libraries I use (and precompile before into .a files).

Just to confirm that I was able to use libexecinfo, musl and produce a fully static linked binary. Now, does it ALWAYS work remains to be seen. But that is definitely outside g3log's realm.

Specifically for linexecinfo, the main things are

look at the Makeifle it provides; as it is, the native platform compiler is used. Since I was cross-compiling and already setting CC (and AR) all I add to do is comment out the same in its Makefile
Hopefully the crosstool-ng guys will be able to pullin this libexecinfo.

Beside this, my main take away has nothing to do with g3log, musl or even cross compiling. Behind the scene, cmake builds executables (lots of them) and even though you setup cmake for generating static libraries it still needs the dynamic libraries (for the libraries that a project or a library depends on) in order for the small test executable to be produced.


Game In Progress Footer

https://github.com/rightoneducation/righton-app/issues/263 per https://docs.google.com/document/d/1m6cThnNOGvm_fJJn1LHGxghtkq4Cv4U5mgAJEqvovTw/edit
To do:

get states updating on button click  - x
tie states into @righton/networking instead of dictionary - x
update button styling with states
get timer working with button
do check for final question

hey @lucahendicott, I think this is ready for review. There is some monkey business on some of the files that I needed to do to get it to run on my end. Here's a list:

[debug-panel/package.json] - added && to get it to run on my end
'[networking/package.json]' - added && to get it to run on my end, some other dependencies added that can probably be rejected
[web/src/host/containers/GameSessionContainer.tsx] - this is the main one. I had to comment out the subscription here to get it to run. I also had to comment out "endpoint;" on line 15 of networking/lib/src/ApiClient.js This is related to the same issue. I think Mani fixed this, but I needed to npm run build again after adding in the new API call, so the issue returned. I'm guessing we can probably uncomment these lines in our main file.

I'll post a full description and demo videos in dev chat.


Tweaks to scripts

@lisaong,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


The default system namespace should be prefixed with kube-

As per the kube api convention on system namespaces, the default federation system namespace should have the kube- prefix reserved for system namespaces to avoid collision with user namespaces.  Suggested options:

kube-fed
kube-fed-system
kube-federation
kube-federation-system

+1 for kube-federation-system


Failed to arm not showing up as a notification anymore

I'm using the latest 1.1.2, just wondering if there was any change on notifications (on purpose or not) as I haven't been able to see the failed to arm notifications anymore, other notifications look ok ie: If I try to arm the alarm with a sensor open, it doesn't work and it also doesn't show me anything even though I have a notification set.

I will take a look. This is not intentional.

I saw that a bug that causes no notification to be sent if:

You have a leave delay > 0, and
There is a sensor open, which is configured to trigger immediate

This is a special case since such sensors are evaluated at the start of the arming process, where others are evaluated at the end of the arming process (so when leave delay has expired).
I also added some logging for these scenario's.
I'm assuming that this scenario is what you were encountering.
For other scenario's I was not able to reproduce the issue.
The bug is patched and will be included in the upcoming release.

This is fixed in release v1.2.0.
Please update and test if the issue is resolved.
Close the issue if this is the case, otherwise let me know!

I tested with different scenarios and they are now all working as expected now, @nielsfaber , thanks!


add support for fibers in tracy

Fibers tracing works fine unless mixed with threads. Might not be a big deal anyway as tracking wires is enough.

@guusw this adds the correct on stop event. Merge if good 👍

@guusw Can you check again?
As discussed on discord indeed even if they state in docs it should be ok to nest coros it wasn't...
I solved with thread local as you suggested but works only because we never move coroutines between threads yet (as they run).

Merged in bc5e1c3


Merge changes from v1.35.x branch into master

Among other changes, this also upports upgrading third_party/protobuf to 3.14.0: #25131

Known failures: https://github.com/grpc/grpc-java/issues/7820

Known failures: https://github.com/grpc/grpc-java/issues/7820


stages/greenboot: use disable-next to ignore f-string suggestion

When ignoring a pylint check on the next line, disable-next is required instead of disable.

See https://github.com/osbuild/osbuild/actions/runs/3046450631/jobs/4909274592

I am majorly confused. With pylint 2.14 it is all fine, but with 2.13 it complains about bad-option-value. But when you change disable to disable-next, it suddenly no longer is a bad-option-value? disable operates on the block, so it should be fine, shouldn't it?
I am really confused what exactly is going wrong. I creates #1114 to drop the entire directive and use f-strings. I am fine either way, though I really have no clue what exactly pylint is complaining about.


Minor changes

I have to say that everything works perfectly! Great job! :D
I just made some small changes, such as replacing the LScene::viewAt() call with Pointer::focus() and adding a new Surface::closestToplevelParent() method to find the parent toplevel if the surface has another role.
There was another option as well. Each time a pointer move event is handled by LScene, it updates the LScene::pointerFocus() vector. Usually, it only contains a single view or none, but views can enable pass-through when LView::blockPointerEnabled () is set to false.
Also, finishing interactive toplevel sessions (which can be accessed from LSeat) by releasing any pointer button works fine. This could later be improved by checking if their triggeringEvent() matches the released button. I didn't implement that yet because some clients sometimes request starting sessions by providing a keyboardEnter event, which would require additional validations in the request handlers.

Thank you for looking into it!
I kinda liked the fact that I can drag a window without focusing it / bringing it to top (I can do that in KDE, for example). Surprisingly, this still works on your branch (I don't understand why). However, I noticed that on resizing (META+right click) it brings the window to top and gives it keyboard focus. Then I switched back to my branch and it has the exact same behavior and I now don't understand anything anymore 😂
In my mind, looking up the surface at cursor position is cleaner than messing with the focus.
I merged it, of course. :)

Glad you noticed that! Indeed, I forgot to raise and activate the toplevel. The reason it doesn't work is that I removed the flags from the pointer button event handler in LScene when your method returns true, so the default implementation is not handled. I did this to avoid sending events to the surface, as right-click opens context menus in almost all windows.

I'm sorry, I realize (a bit late) that my previous message is confusing.  My bad!  I meant to say that I would prefer it not to focus/raise the window. :)
But I can live with it, and at least it's now consistent (in that both move and resize will raise the window). Maybe I'll add later some option to not update focus.
Thank you for merging it!

Alright, it felt a bit weird to me anyway. Disabling it is as simple as removing the three lines I added at the end of your method.

Thank you for merging it!

Thanks to you!


Logged in and kicked after 2 seconds, DecoderException

All newest versions of everything :D
http://hastebin.com/futihehava.avrasm

Plugins?

This should be fixed in a later version. Try the latest


Reproject extent if not mercator

Per https://github.com/mapbox/mapbox-studio/issues/1390#issuecomment-113629326
cc @springmeyer

Currently battling with mbtiles file created by the tests. It apparently doesn't contain any tiles except for [0,0,0]. But the mbtiles file produced by a manual Export in Studio uploads fine.
Running the MBTiles file produced by the test through a ZXYStream returns a single Buffer, but examining my manually created MBTiles file in sqlite show there are definitely many tiles...
zoom_level|tile_column|tile_row|tile_data
0|0|0|?
1|1|0|?
2|3|1|?
3|7|2|?
3|7|3|?
4|15|5|?
4|15|6|?
5|30|11|?
5|31|11|?
5|31|12|?
6|61|22|?
6|61|23|?
6|62|22|?
6|62|23|?
6|62|24|?
6|62|25|?
6|63|23|?
6|63|24|?
6|63|25|?

Hmm, not sure why that would be @GretaCB... let me know if you get stuck.


Generate equals, hashCode and toString Methods

I generate equals methods, which are required to compare ModifiedVariables in a generic way.

I removed the equals Method in ModifiableVariable.

Oh wait my application is broken now ...

Everything should be fine now. There was a equality check of the superclass in every equals Method.

I am still unsure if this is what you want.

With my implementation both is possible, but you are right, its more logical to use getValue.


feat: implement form actions handlers

🔗 Linked issue
https://github.com/nuxt/nuxt/issues/20649
https://github.com/nuxt/nuxt/pull/20852
https://github.com/Hebilicious/form-actions-nuxt
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds an experimental features that allows Nitro to supports fallback routes.
This is useful to register a post handler alongside the nuxt renderer.
nitro.config.handlers.push({ route: "/hello-world", handler: "~/actions/hello-world.ts", formAction: true })
Nitro will send an error if there's a form action handler but no renderer has been specified.
When hitting /hello-world with a post request, the registered handler will be used.
But when hitting /hello-world with a get request, the renderer will be used.
Something to potentially do in the future would be to add the action directory to the nitro scanners.
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

@pi0 Despite the conflicts this is ready for review, I followed the approach that you suggested with a separated router for form actions

With the upstream fix in h3 (https://github.com/unjs/h3/pull/461), we can actually register form action routes with their method and no additional configuration and they are expected to work nicely with default renderer catch all route.

Thanks @pi0, everything is working smoothly.
I've upgraded https://github.com/Hebilicious/form-actions-nuxt/releases/tag/v0.2.0-beta.0 to use the latest nitro and h3 🎉


Telemetry Tracking Plug-in

With this feature, a user would be able to wrap certain components in a withTelemetryTracking component to track button clicks of that component when the application is running.
On top of this, there could be extensibility in this feature for tracking more telemetry data type metrics.

I am working on this for my university senior design project with sponsorship from Microsoft for quality control and following implementation standards.

Hi, who are your contacts at Microsoft in relation to this as we also have several (currently) internal streams of work already going or about to start that sound awfully similar to this.

@MSNev Hi! My current contact within Microsoft is Chris Dietsch<EMAIL_ADDRESS>After today, I am handing off my work to him so please be in contact about where to proceed with this. Thank you!

Thanks, I've reached out to Chris to get more context and to understand how this might fit into the overall plans.
Cheers

I reached out to Chris and he is going to send me the info you created and we will see how we can incorporate that into the project.


Add files via upload

this is not a good way to include the project proposal.
Please look at the dev branch README. I have linked to our Google Docs file there.


Is it possible to avoid line break collapse?

Hello,
I'm trying to use a value that's a literal string with some line breaks in it. Currently the line breaks gets collapsed and the string no longer looks the way I expect it to.
docx.PlaceholderMap{
   "PLACEHOLDER_KEY":    `here is my string
with different
items on
multiple lines
`,
}

turns into
here is my string with different items on multiple lines
Is it possible to preserve line breaks in placeholder values?

Hey,
at the moment this is not possible. The reason this happens is because go-docx will put the value inside the first text-run (<w:t>) of the found placeholder.
Given the following fragments which define the {key_with_underscore} placeholder:
<w:r>
  <w:rPr>
    <w:b/>
    <w:highlight w:val="yellow"/>
    <w:bCs/>
  </w:rPr>
  <w:t>{key_</w:t>
</w:r>
<w:r>
  <w:rPr>
    <w:b/>
    <w:highlight w:val="yellow"/>
    <w:bCs/>
    <w:sz w:val="32"/>
    <w:szCs w:val="32"/>
  </w:rPr>
  <w:t>with</w:t>
</w:r>
<w:r>
  <w:rPr>
    <w:b/>
    <w:highlight w:val="yellow"/>
    <w:bCs/>
  </w:rPr>
  <w:t>_underscore}</w:t>
</w:r>

All but the first fragment (<w:r>) is stripped and the text inside the first fragment is replaced with your value.
The resulting xml looks like that:
<w:r>
  <w:rPr>
    <w:b/>
    <w:highlight w:val="yellow"/>
    <w:bCs/>
  </w:rPr>
  <w:t>here is my string with different items on multiple lines
</w:t>
</w:r>

In order to add a line-break, according to the spec, one would have to insert new XML text elements. The resulting xml might need to look something like this
<w:r>
  <w:rPr>
    <w:b/>
    <w:bCs/>
  </w:rPr>
  <w:t>here is my string</w:t>
  <w:br/>
  <w:t xml:space="preserve">with different</w:t>
  <w:br/>
  <w:t xml:space="preserve">items on</w:t>
  <w:br/>
  <w:t xml:space="preserve">multiple lines</w:t>
</w:r>

As mentioned in #3, adding XML is out of scope for this project, especially since I do not have much time to work on it at the moment. So if you need to have line-breaks, your best option currently is to use multiple placeholders for the separate lines.
If you want to give an implementation a try, PRs are welcome 😃


Enable different identifiers in YAML-File than hosts

@ubaumann raised a good issue in his PR #34 : Currently, the host is the identifier in each test case of a YAML file. This is unpractical and rigid, it would be better to allow other data entries as identifier, such as tags in VRF tests as demonstrated by @ubaumann .
However, this requires a larger refactoring of the code base. PR #34 suggests a solution, but it has several drawbacks, one of which is that the context has to be loaded twice just so that the data fro the YAML can be unpacked, i.e. enhanced with data.
Several solutions have to be assessed before the code is refactored:

Enable some sort of preprocessing that enhances the YAML test data with inventory data that are required for the tests. Idea: Pre-Load YAML, correlate it with inventory, write new YAML with updated test_data that is finally used for the whole testing process with nuts.
Introduce a new class that is an interface between the YAML file and the inventory

Please add further ideas in comments.
Related: #27

Idea: build CLI, do preprocessing of yaml file, then invoke pytest internally: https://docs.pytest.org/en/latest/how-to/usage.html#calling-pytest-from-python-code

In my opinion we would lose a lot of pytest features and nuts would not need to be a plugin anymore

it's an idea worth trying


Category URL rewrites are generated only for one store only in multi store application on 2.3

Running below command only gives category rewrite URL's for all stores.
php bin/magento ok:urlrewrites:regenerate --entity-type=category
Below command generate URL rewrite for single store only
php bin/magento ok:urlrewrites:regenerate


no red color

Challenge http://freecodecamp.com/challenges/waypoint-use-a-css-class-to-style-an-element has an issue.
-No red color
-using mozilla 39

Hey @robooo Can you try rgb and hex for me? Just a curiosity in case that'd fix it. It's rgb(255,0,0) and #FF0000

Hi tried but still doesn't work for me

okay sorry about this! I'm not sure how to proceed unless by some miracle a refresh works.

What happens if all Firefox addons are disabled? I wonder if it's a Firefox issue or maybe an addon is interfering some how?

Tried on chrome but same problem... on next waypoint it works.
my system is ubuntu 14.04

Hey @robooo is this still an issue for you?
Have you tried hitting the reset button on the page?  The challenge starts off with that text being blue, is that true for you after hitting reset?

@benschenker Sorry didn't try reset, I just started clicking on run like crazy :) and after 5 sec window with submit shows up. I know it's not good way but worked for me.

Awesome!


First pass at APIs for final stream metrics

This pass only sends up metrics onComplete.  TODO onError and onCancel
Description:
Risk Level:
Testing:
Part of #1520

Happy to be more explicit but do you have a suggestion of where we document
it? I'm not super familar with what goes where yet :-)
On Tue, Nov 16, 2021 at 7:32 PM Jose Ulises Nino Rivera <
@.***> wrote:

@.**** commented on this pull request.
At a high level this looks good, and in line with what would be useful to
do some pretty comprehensive perf testing.
My main concern is about documenting the three different terms at play
here:
stream info, stream intel, and stream metrics. I am afraid that future
developers will be confused where to stick new information.
As I see it, stream info is generally used in the context of Envoy's
StreamInfo, StreamIntel is where we put information that is going to be
useful on every callback, and stream metrics is where we put information
that is only passed on stream termination.
I know this is documented in the c_types and elsewhere but I wonder if we
should be more explicit about it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy-mobile/pull/1937#pullrequestreview-808000332,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AELALPMBD6WY2GF4JDV3H4LUMLZ2VANCNFSM5H3JSMKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

First of all, I think it's great to finally be exposing more of this via the API.
I had originally envisioned all of this simply going on StreamIntel. Totaled metrics would simply be in their final state on the last callback. Is a separate callback really necessary?

ok, per discussion with @goaway I'm going to make this FinalStreamIntel and pass up onError / onComplete / onCancel

Thanks @alyssawilk this overall looks good. Thinking about it more though, final stream intel definitely will need the fields from the original stream intel one way or another - or we'll need to pass both structs on the terminal callbacks. This is because the final intel may be the only callback received for a stream (e.g. immediate cancellation or error).
Sorry to just now be thinking of this. :(

ok, @goaway I think this is ready for another pass.
@carloseltuerto I'm going to ask your help debugging the early return I added.  I think it's a lifetime issue, where I made the upstreamInfo a shared pointer, so we didn't have to copy all the data all the time, but by the last up call to onComplete, the stats store is gone (which  IMO shouldn't go away until the envoy engine does?) so it gets cranky if you reference any stats.
Worst case we can copy all the time but I think it's a test bug that the store is going away before the final completion call, I just don't understand lifetime issues in that test to be sure.

@alyssawilk feel free to copy/merge this in to fix kotlin formatting:
https://github.com/envoyproxy/envoy-mobile/pull/1952
There's a bazel target (build kotlin_format_fix) that should work to fix kotlin formatting as well; unsure if it requires additional setup, but it runs locally just fine for me.


Release/0.4.1

Coverage remained the same at 100.0% when pulling d424d9dfd8bb21631811fbf1b9189a02ebeece42 on release/0.4.1 into 44be0ea63d044c49e8b4e2d5751d77d3112180fe on master.


[FLINK-28825] Add K8S pod scheduler into Kubernetes options [FLINK-28829] Support prepreparing K8S resources before JM creation [FLINK-28831][k8s]Support pluginable decorators mechanism - part 1st

commit  [FLINK-28825]
We introduce 3 options for supporting specify the K8S pod scheduler
name.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
This change is introduced by FLIP-250 for supporting specify pod scheduler name by users. This PR introduces 3 options for it.
Brief change log
New options are:
kubernetes.jobmanager.scheduler-name
kubernetes.taskmanager.scheduler-name
kubernetes.scheduler-name
The first two of them can be specified by users to control the k8s pod
scheduler they used for jobmanager and taskmanager. The last one is the
fallback one, the first two options will overwrite it.
Verifying this change
Kubernetes deployment support 3 new options now. Can check the backend pods scheduler name whether is the same with the specified one.
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
The S3 file system connector: (no)
Documentation
Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (not applicable)
commit [FLINK-28829]
In this PR, we introduces several things for supporting create another k8s resources before JM deploy creation
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
For supporting customized k8s scheduler, we need to extend the ability of current code tree to support the cases of all customized k8s scheduler during they schedule the real pods. So we'd better to extend all cases during k8s scheduling, such as before/during/after our target resources creation. In this PR, we add the before case. And current code tree had covered during/after cases.
Brief change log
We introduce a new interface func for all decorators to support
create pre-prepared k8s resources.
We extend a attribute for JM spec for storing the resources list.
Extending the ability for supporting refresh the preprepared
resource's ownerreference based on original code logic.
Add the ability for creating K8S resource before JM deployment
creation in Fabric client.
Verifying this change
We can not verify this change at this moment, as this is a internal process in flink-kubernetes now. It doesn't affect the user interface now. The only way we can test it is mocking a JM spec with another k8s resources which is not contained by Flink. And check whether the resources can be created before the JM and refresh the correct ower reference(Flink cluster id-- deployment id).
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
The S3 file system connector: (no)
Documentation
Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)
commit  [FLINK-28831]
We introduce a pluginable decoarators mechanism into Flink JobManager and TaskManager.
For 1st part, we relies on the existing flink plugin mechanism and make the KubernetesStepDecorator
as the SPI. And load the extended plugins from plugins directory.
And notice the 1st part only introduces the basic mechanism and doesn't affect the major process login.
There will be another follow up PRs for introduce this mechanism one by one.
What is the purpose of the change
We introduce the basic plugin mechanism for supporting add more pluginable K8S step decorators in Flink Kubernetes. So in PR introduce the its 1st part.
Brief change log
Relied on the Flink existing plugin mechanism to load the plugins from flink-dist/plugins/ directory.
Introduce a new Interface class ExtPluginDecorator  which is extended from KubernetesStepDecorator, and introduce a new interface function for initialize the upcoming StepDecorators if necessary.

Verifying this change
Run the UTs, or package a sample jar which implement the interface class ExtPluginDecorator , then verify the said implement class is loaded in Flink by LOG. Notice that this is the first part of plugin mechanism, and it doen't affect the major Flink Kubernetes process yet. So we can only verify the said functionality via LOG now. Once the following PRs are ready and merged, we will introduce a full insight e2e tests.
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
The S3 file system connector: (no)
Documentation
Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

We are still using flink1.12, what should I do for this pr I want to use in 1.12, I try to merge this pr in 1.12, and find that the difference is too big and it is difficult to merge, if you can, I hope you can guide me.

We are still using flink1.12. What should I do to use this pr in 1.12 or 1.15? I tried to merge this pr in 1.12 and found that the difference is too big and it is difficult to merge. If you can, I hope you can guide me. Thanks

ok. and I think it is also simple to  use this PR with flink 1.12.

We are still using flink1.12. What should I do to use this pr in 1.12 or 1.15? I tried to merge this pr in 1.12 and found that the difference is too big and it is difficult to merge. If you can, I hope you can guide me. Thanks

ok. and I think it is also simple to use this PR with flink 1.12. I will give my answer as soon as I can 。

I merged this pr into the release-1.12.7 branch, and it ran successfully in flink on k8s native session mode, but I don't quite understand this place. When decorateFlinkPod is executed, this method will set the annotation of deployment to scheduling.k8s.io/group-name:
    @Override
    public FlinkPod decorateFlinkPod(FlinkPod flinkPod) {
        String configuredSchedulerName = kubernetesComponentConf.getPodSchedulerName();
        if (configuredSchedulerName == null
                || configuredSchedulerName.equals(DEFAULT_SCHEDULER_NAME)) {
            return flinkPod;
        }
        final PodBuilder basicPodBuilder = new PodBuilder(flinkPod.getPodWithoutMainContainer());
        String fakename = this.kubernetesComponentConf.getClusterId();
        basicPodBuilder
                .editOrNewMetadata()
                .withAnnotations(
                        Collections.singletonMap("scheduling.k8s.io/group-name", "pg-" + fakename))
                .endMetadata();
        return new FlinkPod.Builder(flinkPod).withPod(basicPodBuilder.build()).build();
    }

, which is different from the one automatically created when jobmanager starts, which causes taskmanager to fail to start. This is because the scheduling.k8s.io/group-name of taskmanager and jobmanager are different. , I tried to debug the startup process of flinksession, and found that flinksession has been created before podgroup is created. I don't quite understand where the logic of this creation starts. But when I modify this code, I can start taskmanager normally
    @Override
    public FlinkPod decorateFlinkPod(FlinkPod flinkPod) {
        String configuredSchedulerName = kubernetesComponentConf.getPodSchedulerName();
        if (configuredSchedulerName == null
                || configuredSchedulerName.equals(DEFAULT_SCHEDULER_NAME)) {
            return flinkPod;
        }
        final PodBuilder basicPodBuilder = new PodBuilder(flinkPod.getPodWithoutMainContainer());
        String fakename = this.kubernetesComponentConf.getClusterId();
        PodGroupBuilder podGroupBuilder = new PodGroupBuilder();
        podGroupBuilder.editOrNewMetadata().withName("pg-" + fakename).endMetadata();
        Map<String, String> podGroupConfig = kubernetesComponentConf.getPodGroupConfig();
        for (Map.Entry<String, String> stringStringEntry : podGroupConfig.entrySet()) {
            switch (stringStringEntry.getKey()) {
                case priorityClassName:
                    podGroupBuilder
                            .editOrNewSpec()
                            .withPriorityClassName(stringStringEntry.getValue())
                            .endSpec();
                    break;
                case minMember:
                    podGroupBuilder
                            .editOrNewSpec()
                            .withMinMember(Integer.parseInt(stringStringEntry.getValue()))
                            .endSpec();
                    break;
                case queue:
                    podGroupBuilder
                            .editOrNewSpec()
                            .withQueue(stringStringEntry.getValue())
                            .endSpec();
                    break;
            }
        }
        return new FlinkPod.Builder(flinkPod).withPod(basicPodBuilder.build()).build();
    }


tests: fix ambient/TestWasmPluginConfigurations in IPv6 cluster

/test integ-ambient-ipv6

@jewertow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
0b921738c6a50faae1998da62f95db458055c88a
link
unknown
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

/retest


Add python script and readme

This change introduces a python script that applies a lifecycle rule to a s3 bucket to delete data older than 30 days.
closing #7

thanks for the PR @selamanse can you rename the directory to aws/apply_lifecycle_policy_s3
I am looking for something different for which I think I have to update the issue but this code looks good but I just want to accept it in another directory.
Is that fine by you?

thanks for the quick feedback @DiptoChakrabarty. sure thing I renamed / relocated the script as you desired. can you check please if this version ok?

thanks a lot


Please, clarify Isolate.pause() specification

The description for method Isolate.pause() reads:
( https://api.dartlang.org/stable/1.16.1/dart-isolate/Isolate/pause.html )

Requests the isolate to pause.
The isolate should stop handling events by pausing its event queue. The request will eventually make the isolate stop doing anything. It will be handled before any other messages that are later sent to the isolate from the current isolate, but no other guarantees are provided.
The event loop may be paused before previously sent, but not yet exeuted, messages have been reached.
If resumeCapability is provided, it is used to identity the pause, and must be used again to end the pause using resume. Otherwise a new resume capability is created and returned.
If an isolate is paused more than once using the same capability, only one resume with that capability is needed to end the pause.
If an isolate is paused using more than one capability, they must all be individully ended before the isolate resumes.
Returns the capability that must be used to resume end the pause.

It is not clear:

What happens with the events, that are already in the queue after pause request? Are they preserved till the isolate is resumed and handled after the isolate is resumed? Or they just disposed without any handling?

What happens with the events, that arrive after the isolate is paused? Are they added to the event queue for later handling or just ignored?

I think it's not even true that the message is handled before other messages sent to the same isolate - only before other messages sent on the same port. Port messages are completely unsynchronized except when sent on the same SendPort, in that case they are eventually delivered in order. No ordering between ports is guaranteed.
About the paused isolate: Its already queued events are retained and will be handled if and when the isolate resumes. New events will be enqueued as well, pausing only prevents the events in the queue from being processed, adding to the queue still works fine.


BoxNovel problem

There is a problem with BoxNovel see the attached picture, the website work fine.

Fixed, same issue as #18

There is no search results for BoxNovel in search tab or explore.
Also some novels links not working, as "Super Gene".


HTML5 audio doesn't work in safari (on latest MacOS)

For example http://labs.phaser.io/view.html?src=src\audio\HTML5%20Audio\AudioSprite.js

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

With the update merged in I'd love to know what errors you now get @alexandernst

NotAllowedError (DOM Exception 35): The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.  — HTML5AudioSound.js:346
playCatchPromise — HTML5AudioSound.js:340
pickAndPlayAudioTag — HTML5AudioSound.js:256
play — HTML5AudioSound.js:113
playAudioSprite — BaseSoundManager.js:258
(función anónima) — AudioSprite.js:67
emit — index.js:182
processDownEvents — InputPlugin.js:506
update — InputPlugin.js:1510
emit — index.js:203
step — Systems.js:278
update — SceneManager.js:478
step — Game.js:363
step
step — TimeStep.js:519
step
step — RequestAnimationFrame.js:102

Note that I was never asked about allowing (or denying) anything.

It seems like the same is happening on iOS when switching scenes and trying to play audio. The first audio you play works, but the next one will fail (silently) with this error.

@photonstorm any progress looking into this?

Alright, just removed
audio: {
    disableWebAudio: true
  },

from the game config and now audio works just fine on iOS/ Safari on macOS.
Not sure why I thought HTML5 audio would be the way to go but this might happen to others as well. Perhaps tell in the examples it's advised to use Web Audio.
Cheers!

I’ll keep this open because old school Audio should still work on Safari, but you absolutely don’t want to use it unless forced to.

@photonstorm I have a fix for this but can't test it since all HTML5 Audio examples are broken with following error:
Uncaught RangeError: Maximum call stack size exceeded
    at HTML5AudioSound.set [as mute] (HTML5AudioSound.js:627)
    at HTML5AudioSound.setMute (HTML5AudioSound.js:655)
    at HTML5AudioSound.set [as mute] (HTML5AudioSound.js:636)
    at HTML5AudioSound.setMute (HTML5AudioSound.js:655)
    at HTML5AudioSound.set [as mute] (HTML5AudioSound.js:636)
    at HTML5AudioSound.setMute (HTML5AudioSound.js:655)
    at HTML5AudioSound.set [as mute] (HTML5AudioSound.js:636)
    at HTML5AudioSound.setMute (HTML5AudioSound.js:655)
    at HTML5AudioSound.set [as mute] (HTML5AudioSound.js:636)
    at HTML5AudioSound.setMute (HTML5AudioSound.js:655)

Yeah :( I fixed it earlier today though, master is safe now.

This is now fixed and can be tested with this example: http://labs.phaser.io/view.html?src=src\audio\HTML5%20Audio\play%20audio%20from%20child%20scene.js


Optimise User Competence Query Performance

Issue
The query for retrieving user competences is experiencing high latency, often taking between 300-400ms to execute. When the user visits the /record/entries page in the frontend, we also query user_competences. There are only around 200k records in this table.
Query
SELECT "user_competence"."id", "user_competence"."level",
"user_competence"."user_id", "user_competence"."entry_id", "user_competence"."competence_id",
"user_competence"."organisation_id", "user_competence"."created_by", "user_competence"."created_at",
"user_competence"."deleted_at"
FROM "user_competences" AS "user_competence"
WHERE (entry_id = 'nanoid') AND "user_competence"."deleted_at" IS NULL
--- 392.274ms

Possible Solutions

Investigation of existing indexes on the user_competences table, particularly concerning the entry_id and deleted_at columns.
Consider adding composite indexes if necessary.
Review the EXPLAIN plan for the query to spot any potential bottlenecks.
Also add the organisation_id to the where clause to filter out possible results.

Request
Analyze and implement the necessary optimizations to reduce the execution time of this heavily used query.

Hi @tomhaerter, would it be possible to run the query with EXPLAIN (ANALYZE, COSTS, VERBOSE, BUFFERS, FORMAT JSON) on production? I don't have enough test data on my local system to really see which decision postgres makes.
You could also, given that the query output does not contain sensitive data, share a https://explain.dalibo.com/ link.

@felixhromadko
EXPLAIN (ANALYZE, COSTS, VERBOSE, BUFFERS, FORMAT JSON) SELECT "user_competence"."id", "user_competence"."level",
"user_competence"."user_id", "user_competence"."entry_id", "user_competence"."competence_id",
"user_competence"."organisation_id", "user_competence"."created_by", "user_competence"."created_at",
"user_competence"."deleted_at"
FROM "user_competences" AS "user_competence"
WHERE (entry_id = 'sb4UmLH8XnS63a_9dVBOz') AND "user_competence"."deleted_at" IS NULL

[
  {
    "Plan": {
      "Node Type": "Gather",
      "Parallel Aware": false,
      "Async Capable": false,
      "Startup Cost": 1000.00,
      "Total Cost": 5920.13,
      "Plan Rows": 16,
      "Plan Width": 141,
      "Actual Startup Time": 11.483,
      "Actual Total Time": 16.747,
      "Actual Rows": 8,
      "Actual Loops": 1,
      "Output": ["id", "level", "user_id", "entry_id", "competence_id", "organisation_id", "created_by", "created_at", "deleted_at"],
      "Workers Planned": 2,
      "Workers Launched": 2,
      "Single Copy": false,
      "Shared Hit Blocks": 4038,
      "Shared Read Blocks": 0,
      "Shared Dirtied Blocks": 0,
      "Shared Written Blocks": 0,
      "Local Hit Blocks": 0,
      "Local Read Blocks": 0,
      "Local Dirtied Blocks": 0,
      "Local Written Blocks": 0,
      "Temp Read Blocks": 0,
      "Temp Written Blocks": 0,
      "Plans": [
        {
          "Node Type": "Seq Scan",
          "Parent Relationship": "Outer",
          "Parallel Aware": true,
          "Async Capable": false,
          "Relation Name": "user_competences",
          "Schema": "public",
          "Alias": "user_competence",
          "Startup Cost": 0.00,
          "Total Cost": 4918.53,
          "Plan Rows": 7,
          "Plan Width": 141,
          "Actual Startup Time": 9.356,
          "Actual Total Time": 10.699,
          "Actual Rows": 3,
          "Actual Loops": 3,
          "Output": ["id", "level", "user_id", "entry_id", "competence_id", "organisation_id", "created_by", "created_at", "deleted_at"],
          "Filter": "((user_competence.deleted_at IS NULL) AND (user_competence.entry_id = 'sb4UmLH8XnS63a_9dVBOz'::text))",
          "Rows Removed by Filter": 56460,
          "Shared Hit Blocks": 4038,
          "Shared Read Blocks": 0,
          "Shared Dirtied Blocks": 0,
          "Shared Written Blocks": 0,
          "Local Hit Blocks": 0,
          "Local Read Blocks": 0,
          "Local Dirtied Blocks": 0,
          "Local Written Blocks": 0,
          "Temp Read Blocks": 0,
          "Temp Written Blocks": 0,
          "Workers": [
            {
              "Worker Number": 0,
              "Actual Startup Time": 6.974,
              "Actual Total Time": 8.973,
              "Actual Rows": 2,
              "Actual Loops": 1,
              "Shared Hit Blocks": 1115,
              "Shared Read Blocks": 0,
              "Shared Dirtied Blocks": 0,
              "Shared Written Blocks": 0,
              "Local Hit Blocks": 0,
              "Local Read Blocks": 0,
              "Local Dirtied Blocks": 0,
              "Local Written Blocks": 0,
              "Temp Read Blocks": 0,
              "Temp Written Blocks": 0
            },
            {
              "Worker Number": 1,
              "Actual Startup Time": 9.899,
              "Actual Total Time": 9.900,
              "Actual Rows": 0,
              "Actual Loops": 1,
              "Shared Hit Blocks": 1272,
              "Shared Read Blocks": 0,
              "Shared Dirtied Blocks": 0,
              "Shared Written Blocks": 0,
              "Local Hit Blocks": 0,
              "Local Read Blocks": 0,
              "Local Dirtied Blocks": 0,
              "Local Written Blocks": 0,
              "Temp Read Blocks": 0,
              "Temp Written Blocks": 0
            }
          ]
        }
      ]
    },
    "Planning": {
      "Shared Hit Blocks": 152,
      "Shared Read Blocks": 0,
      "Shared Dirtied Blocks": 0,
      "Shared Written Blocks": 0,
      "Local Hit Blocks": 0,
      "Local Read Blocks": 0,
      "Local Dirtied Blocks": 0,
      "Local Written Blocks": 0,
      "Temp Read Blocks": 0,
      "Temp Written Blocks": 0
    },
    "Planning Time": 0.477,
    "Triggers": [
    ],
    "Execution Time": 16.785
  }
]

I do not have the ID of the queries that are taking extremely long at the moment. However, the query plan above shows the potential problem already


Monoid instance for CSS

could there be a monoid instance for CSS?
To me it looks like an empty style is something possible and it would be useful if you pass styles to a function and they should be optional. Because then you'd not have to wrap it in a Maybe.
But - maybe - there are good reasons for not having this.

monoid, and Eq instances would both be very handy.
use case:   I have an array of CSS in a state monad, I want to union over them with some new styles, then fold them down into a single rule to be used by a style tag.


Introduce Query abstraction

This cleans up the hard fork code a bit, and makes it possible to provide a clean interface for caching, which we can take advantage of in the BlockchainTime API.

Thanks @erikd .
bors merge

bors r-

bors r+


Make MaxTCPQueries configurable

Codecov Report

Merging #673 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   58.05%   58.05%
=======================================
  Files          37       37
  Lines        9999     9999
=======================================
  Hits         5805     5805
  Misses       3144     3144
  Partials     1050     1050

Impacted Files
Coverage Δ

server.go
60% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c76f98...59733b5. Read the comment docs.

Re: 128, ugly but I agree
On Thu, 10 May 2018, 14:52 Tom Thorogood<EMAIL_ADDRESS>wrote:

@tmthrgd commented on this pull request.
In server.go https://github.com/miekg/dns/pull/673#discussion_r187334077
:

@@ -593,8 +592,13 @@ func (srv *Server) serve(w *response) {

timeout := srv.getReadTimeout()

// TODO(miek): make maxTCPQueries configurable?
for q := 0; q < maxTCPQueries; q++ {

q := 0
for {

I think this would come out cleaner written as:
for q := 0; q < srv.MaxTCPQueries || srv.MaxTCPQueries == 0; q++ {

In server.go https://github.com/miekg/dns/pull/673#discussion_r187335377
:

@@ -303,6 +300,8 @@ type Server struct {
DecorateReader DecorateReader
// DecorateWriter is optional, allows customization of the process that writes raw DNS messages.
DecorateWriter DecorateWriter

// Maximum number of TCP queries before we close the socket (unlimited if 0).
MaxTCPQueries int

I question whether having the default value mean unlimited is best,
because it amounts to a behaviour change that could be unexpected. Perhaps
it would be best to have 0 mean the current max of 128 and -1 explicitly
mean unlimited (maybe even with a const UnlimitedMaxQueries = -1 for
clarity). @miekg https://github.com/miekg thougts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/miekg/dns/pull/673#pullrequestreview-119091907, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVkW3NNnwCVzMJz5_mL3WAv0L8tkCjDks5txEY0gaJpZM4T0ocN
.


Update Tools.GetAbsoluteUrl to work in web workers

See https://forum.babylonjs.com/t/cannot-import-draco-compressed-mesh-in-a-web-worker/25125

@bghgary - can you check why the doc check fails?


Add validation for OAuth Server Name

[Add validation for OAuth Server Name. if you add a name of a server which already exist you are able to save that changes. Although the server is not created you are receiving a popup with a success message ]
Reproduction Steps:

[Log in > Navigate to OAuth Servers]
[Create a new OAuth Servers]
[Fill OAuth Server Name input field which already exist ]

User should not be able to save changes. Error message should appear in a popup that this Server Name already exist:
[Describe expected behavior here]
When clicking on Create a OAuth Server popup appears with the successful message. Although the actual server is not created we should not show popup with successful message.

Thank you, @JuricDavor !

@rafaeljesus , Senior, por favor, can you check this out? Seems like when we are creating the new item with the same name - it's merging to elements into one...

@ivanzusko the issue you mentioned has been fixed 🙂

Awesome! 🎉


Pass opts to token_headers

This fixes the bug mentioned here: https://github.com/chriswarren/doorkeeper-jwt/commit/ac6f1c50628e4c1d9e5b4a51d6fbca3c5e1030db#commitcomment-22429204
The token_headers accepts opts like the other procs, but wasn't being called with them. This adds the arg and updates the test to reflect the fix.

Coverage remained the same at 96.863% when pulling 83c6de57ebe0f702e1991fb1d60fa9ee548ec90c on travisofthenorth:fix/header-opts into c000ee22640deb0057926a15f3a46be17bc1dc73 on chriswarren:master.

Coverage remained the same at 96.863% when pulling 83c6de57ebe0f702e1991fb1d60fa9ee548ec90c on travisofthenorth:fix/header-opts into c000ee22640deb0057926a15f3a46be17bc1dc73 on chriswarren:master.

@chriswarren Looks like we're ready to release v0.2.1 👍

@MarkMurphy I think I added you to publish on RubyGems now, if you want to give it a shot. If it doesn't work I'll figure out what's missing so you can.

@MarkMurphy I think I added you to publish on RubyGems now, if you want to give it a shot. If it doesn't work I'll figure out what's missing so you can.

Thanks Chris, all good.


README with some useful info

Authored by copilot GPT 4o with some minor edits by myself.
I have not done any checking for correctness or anything. I'm lazy.

 I blame python.


Remove Change in selection animation on tabs

Description
Previously tabs had animations in highlighting when changing tab selection. This behavior is now removed
Related Issues
#1073
Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] The issues this PR addresses are related to each other
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] My changes are all related to the related issue above
[x] I documented my code

Screenshots
https://user-images.githubusercontent.com/46418077/224548710-dcd35e85-94b0-4676-859d-576f0bf5f601.mov
The top version is with animations and the bottom version is the new updates version without the animation

Thanks for catching this regression!

I had a closer look at the current build and can't reproduce the issue. In the latest alpha release, the tabs are animation out properly for me. Is this still an issue in the latest build? @maxkel

They animate out in the most recent build and should not.

They animate out in the most recent build and should not.

The PR seems to do it the other way around?

This is the behavior in the most recent alpha build:
https://user-images.githubusercontent.com/46418077/224809016-53f8c7e3-a641-4764-a341-bf4abd3b1117.mov
Notice that the tabs fade out when closed and also the highlight color of the newly selected tab fades in. This is a behavior not seen in Xcode:
https://user-images.githubusercontent.com/46418077/224809539-2f9ad83f-9b14-4a19-8847-7c70f7096272.mov
I first fixed this issue (except the fade in of the highlight color) in an earlier PR but the addition of SplitView brought the issue back. Now with my new changes it looks like in Xcode:
https://user-images.githubusercontent.com/46418077/224810950-ef03f31c-86dc-4f89-8054-b7f8fc3455e7.mov

This is the behavior in the most recent alpha build:
Notice that the tabs fade out when closed and also the highlight color of the newly selected tab fades in. This is a behavior not seen in Xcode:
I first fixed this issue (except the fade in of the highlight color) in an earlier PR but the addition of SplitView brought the issue back. Now with my new changes it looks like in Xcode:

I see, my mistake. However, I removed that code (I should've removed the commented out code) as it wasn't very robust and started causing issues in some edge cases. Instead, I switched to the native SwiftUI way to apply such transitions with the following code in TabBarView.swift:
.transition(
    .asymmetric(
        insertion: .offset(x: -14).combined(with: .opacity),
        removal: .opacity
    )
)

Does changing removal: .opacity to removal: .identity solve your issue? This way, we don't have to use the onAppear which isn't always reliable.

Yes, it does. Should I remove the code that you commented out then?

Yes, it does. Should I remove the code that you commented out then?

I'd appreciate that, thanks!

OK, I removed that and also the swiftlint:disable type_body_length because it is no longer needed


grpc: add message count filter

Description: add a message counter HTTP filter. This filter detects gRPC calls, counts messages without incurring the cost of parsing, and updates a filter state with the observed counts.
Adding @lizan as a co-owner since the code is derived from the JSON transcoder.
Risk Level: low
Testing: unit tests
Docs Changes: none
Release Notes:
Issue: #3920

Drive by: if this is going to be upstreamed, it needs:

Full documentation
To be generally useful without further code (i.e., putting messages into a filter state that only Istio will read is not generally useful). Generally useful IMO would take the form of Envoy stats, etc.

If there isn't interest in (1) and (2) above I would keep this in Istio for now. Thank you!

Sure, I can add basic stats and docs. There isn't really that much to document for this one.

There isn't really that much to document for this one.

Documenting its existence would be a good start. ;)
re: stats, please take a look at the stats that the bridge filter already offers and potentially reconcile? Would this filter produce similar stats in a more general case?

From my initial glance, I think we want to collect he total number of request/response messages per method. So adding two more metrics, e.g. cluster.grpc.service.method.request_message_count and incrementing them via gRPC context sounds like the approach to take.

Updated with stats and docs 👍

Hi @kyessenov how does another http filter use these stats?  I have a filter is doing the same counter, like to use this data.   Since the counter is global, the name is only with "service.method", how do we handle two con-current gRPC streams with same service/method?   My filter likes to know number of messages for the stream at the end of request.

@kyessenov Ping...   Could you help with my questions in my previous comment.

@qiwzhang I'd have to bring back the filter state functionality, unless you have a better idea how to integrate through the gRPC context. That means we'll need to add a filter config API as well.

/retest
(AZ is flaking)

/azp run


[base][Input] inputProps onKeyDown is not working

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: https://codesandbox.io/s/broken-cookies-k6px3x?file=/demo.tsx:1459-1539
Steps:

Enter text to the input
"onKeyDown" is not output to the console log

Current behavior 😯
onKeyDown is not triggered
Expected behavior 🤔
onKeyDown is triggered
Context 🔦
I forget the specific version, but onKeyDown used to work before, but does not seem to work now. Is this an expected specification?
Your environment 🌎

npx @mui/envinfo
  Please see the codesandbox dependencies

@ysds Thanks for reporting this 🙂
onKeyDown as a normal prop (not through slotProps) will work
<CustomInput
  aria-label="Demo input"
  placeholder="Type something…"
  onKeyDown={() => console.log('props onKeyDown')}
/>

Here is a working sandbox: https://codesandbox.io/s/https-github-com-mui-material-ui-issues-37134-vxjbpy?file=/demo.tsx

Should we allow both to work 🤔 ? CC @michaldudak @mui/core

since onChange when set from slotProps is working, i think other even handlers should also work. or else developers will have hard time figuring out which are working and which aren't

Should we allow both to work 🤔 ?

Yes, definitely.

@sai6855 are you working on this? If not, could you please assign this to me?

@nicolas-ot ah yes I'm planning to work on this


errors after installing pydot-ng  ImportError: DLL load failed: The specified module could not be found. and SyntaxError: invalid syntax

I followed the instructions given in the link.
http://www.codesofinterest.com/2017/02/visualizing-model-structures-in-keras.html
then I did:
conda install pydot-ng
Then i installed graphviz from here http://www.graphviz.org/download/ and added C:\Program Files (x86)\Graphviz2.38\bin to PATH
after that it gives me errors if i made any " conda" instruction in command window or anaconda prompt
and also give the same error when writing "  activate tensorflow  " in command window
Error:
(base) C:\Users\BioHelwan>activate tensorflow
Traceback (most recent call last):
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\cli\main.py", line 98, in main
return activator_main()
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\activate.py", line 632, in main
print(activator.execute(), end='')
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\activate.py", line 166, in execute
return getattr(self, self.command)()
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\activate.py", line 152, in activate
return self._finalize(self._yield_commands(self.build_activate(self.env_name_or_prefix)),
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\activate.py", line 231, in build_activate
prefix = locate_prefix_by_name(env_name_or_prefix)
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\base\context.py", line 951, in locate_prefix_by_name
envs_dirs = context.envs_dirs
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\base\context.py", line 381, in envs_dirs
join(self._user_data_dir, 'envs'),
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\base\context.py", line 416, in _user_data_dir
return user_data_dir(APP_NAME, APP_NAME)
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda_vendor\appdirs.py", line 67, in user_data_dir
path = os.path.join(_get_win_folder(const), appauthor, appname)
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda_vendor\appdirs.py", line 284, in _get_win_folder_with_pywin32
from win32com.shell import shellcon, shell
ImportError: DLL load failed: The specified module could not be found.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\BioHelwan\Anaconda3\Scripts\conda-script.py", line 10, in
sys.exit(main())
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\cli\main.py", line 108, in main
init_loggers()
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\cli\main.py", line 55, in init_loggers
from ..gateways.logging import initialize_logging, set_verbosity
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\gateways\logging.py", line 12, in
from ..common.io import attach_stderr_handler
File "C:\Users\BioHelwan\Anaconda3\lib\site-packages\conda\common\io.py", line 5, in
from concurrent.futures import ThreadPoolExecutor, base, as_completed
File "C:\Users\BioHelwan\Anaconda3\envs\tensorflow\Lib\site-packages\concurrent\futures_init.py", line 8, in
from concurrent.futures._base import (FIRST_COMPLETED,
File "C:\Users\BioHelwan\Anaconda3\envs\tensorflow\Lib\site-packages\concurrent\futures_base.py", line 414
raise exception_type, self._exception, self._traceback
^
SyntaxError: invalid syntax
Note: any instruction related to anaconda gives me an  error also i can't remove anaconda to start setup from beginning to get rid of from this problem
i'm using
windows10 (64)  - Anaconda 4.2 and python 3.5.2
i installed tensor flow gpu version from instructions in this link https://www.tensorflow.org/install/install_windows
tensorflow version=1.9.0
cuda versions installed 8.0 /9.0
GPU : NVIDIA GeForce GTX 960M   specs link: https://www.geforce.com/hardware/notebook-gpus/geforce-gtx-960m/specifications
Exact command to reproduce : activate tensorflow (also any code related to anaconda i can't use "conda" or "pip" instructions in my command prompt because they give errors too)

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce
Mobile device

i solved the problem by uninstall anaconda then reinstall the tensor flow
for visualization keras models
this link solved my problem
https://www.experts-exchange.com/questions/29106033/Pydot-having-problems-with-GraphViz.html

if you use Anaconda, you can use  conda install -c hesi_m tensorflow  to install tensorflow 1.9.0 for CPU
if you specifically use Keras also, you can use  conda install -c hesi_m keras which installs Keras 2.2.2 in accompany with everything including tensorflow 1.9.0
It is better to make a fresh anaconda environment for your experiments


css modules not working in production (heroku)

I read all possible question about this topic but not found anything that help me.
I build react app using create-react-app and want to use css modules. So I change the weback files found in node_modules/react-scripts/config because I don't want to 'eject' the config files.
On dev everything works well and it's recognize the modules , but on production it's not working. ( in dev not exist 'ExtractTextPlugin' plugin anyway)
So, laster I try to 'eject' the configuration files and then do change the web pack prod file that found in the src/config and it's work, but I really don't want to eject all configuration files for this.
I try also to copy exactly the same web pack.config.prod.js file that work after eject but for some reason it's doesn't help
this is the code from my web pack.config.prod.js:
        test: /\.css$/,
        loader: ExtractTextPlugin.extract(
          Object.assign(
            {
              fallback: {
                loader: require.resolve('style-loader'),
                options: {
                  hmr: false,
                },
              },
              use: [
                {
                  loader: require.resolve('css-loader'),
                  options: {
                    importLoaders: 1,
                    modules: true,
                    localIdentName: '[name]__[local]__[hash:64:5]',
                    //   minimize: true,
                    //   sourceMap: shouldUseSourceMap,
                  },
                },
                {
                  loader: require.resolve('postcss-loader'),
                  options: {
                    // Necessary for external CSS imports to work
                    // https://github.com/facebookincubator/create-react-app/issues/2677
                    ident: 'postcss',
                    plugins: () => [
                      require('postcss-flexbugs-fixes'),
                      autoprefixer({
                        browsers: [
                          '>1%',
                          'last 4 versions',
                          'Firefox ESR',
                          'not ie < 9', // React doesn't support IE8 anyway
                        ],
                        flexbox: 'no-2009',
                      }),
                    ],
                  },
                },
              ],
            },
            extractTextPluginOptions
          )
        ),
        // Note: this won't work without `new ExtractTextPlugin()` in `plugins`.

I try many other configuration for this in the prod file  but nothing effect on prod

Would you like to try out the latest alpha version which comes with css modules support?
https://github.com/facebook/create-react-app/issues/3815

@bugzpodder
hi i try to update project to version 2 , but now what?
I get error when i try to run project:
We're unable to detect target browsers.
i need to change something?
until now i just create css and import it's as style to my component .
no workaround for v1?
thanks

The alpha version supports css modules out of the box.  You should be able to import a css module directly from a js file.  You'll need provide more info such as package.json as well as the code you wrote to figure out what went wrong

@bugzpodder Is it safe to use this alpha version ? what is mean for the future? there is a lot of changes all the time? and how can I be updated all the time with the last version of this?
tnx!

you should change "node_modules\react-scripts\config\webpack.config.dev.js"  and not "webpack.config.prod.js".

@keerkeerhi I change this file and it's work on dev but not on production.
how file node_modules\react-scripts\config\webpack.config.dev.js relative to prod version?

@OriAmir did you end up giving the alpha build a try?  That's the easiest solution, or you have to use something like https://github.com/codebandits/react-app-rewire-css-modules

@bugzpodder I try the alpha build and it's works , I just worry a little bit because it's alfha version.
one more question : what about fonts and images? is it also build in the new version? because until now I use like this in my webpack:
`
{
test: /.(eot|woff2?|ttf|otf)(?.*)?$/i,
loader: 'url-loader?limit=5120&name=[path][name].[hash].[ext]'
},
  {
    test: /\.(jpe?g|png|gif|svg)(\?.*)?$/i,
    loader: 'url-loader?limit=5120&name=[path][name].[hash].[ext]!img-loader'
  }`

tnx again !

It should be fine: https://github.com/facebook/create-react-app/blob/next/packages/react-scripts/config/webpack.config.prod.js#L376
https://github.com/facebook/create-react-app/blob/next/packages/react-scripts/config/webpack.config.prod.js#L249

@bugzpodder
Hey , I heard that version 2 of create-react-app is released . If I will update my beta version something will break or what ?
thanks !

@OriAmir give it a try, it should be stable.


Intl: resolvedOptions().locale does not correctly represent the collation value

new Intl.Collator("de-DE-u-co-phonebk").resolvedOptions()

Expected result (as in Chrome and Firefox)
{
    locale: "de-u-co-phonebk",
    collation: "phonebk"
    ...
}

Actual result (Edge and IE11)
{
    locale: "de-DE",
    collation: "phonebk"
    ...
}

This is caused by some very special/intricate/poor handling of locales that we do for collation options, since the system API that we use on Windows for comparing strings based on locale expects the language tag in a different format than the Intl spec works in. @bterlson is the locale value that we report here actually incorrect?

IMO it's probably not "incorrect" per se, because the spec at present is pretty much all "best effort" -- as long as the behavior is correct (which again by spec is best-effort but in practice for us means if we support that collator, we should use that collator as requested).
In terms of conformance, other engines are still reporting the collator extension (in this case -u-co-phonebk) if it is supported, so we should probably do this too.
However, also IMO, it is misleading to report the resolved locale in a way that shows we do not support the collation option that we did in fact select to use (region part of the locale (-DE) aside).

For what its worth, we do this for all supported unicode tags in the collator:
new Intl.Collator("de-u-co-phonebk-kn-true-kf-upper").resolvedOptions()

Firefox and Chrome return { locale: "de-u-co-phonebk-kn-true-kf-upper", ... } while Chakra returns { locale: "de" ... }

Thats a lie -- Firefox returns that, chrome will only ever keep -co- on the locale string, and they will always strip off everything else.

@jackhorton Chrome's behavior makes more sense to me, since the value of the options object input to the ctor overrides. Since those are also on the resolved options, removing ambiguity by de-duping them (removing from the locale string) seems to make sense.

@jackhorton is this fixed?

Closed in #4083, but this is being improved in an upcoming pull that standardizes everything around the spec version of ResolveLocale


Feat: Copy Icon.

Is your feature request related to a problem? Please describe.
Currently, users may find it inconvenient to manually copy shortened URLs after they are generated.
Describe the solution you'd like
I would like to see a copy icon placed next to the "Shorten" button, allowing users to easily copy the shortened URL with a single click.
Describe alternatives you've considered
An alternative solution could be to provide a "Copy" button next to the shortened URL, but having a copy icon directly next to the "Shorten" button may offer a more intuitive and streamlined user experience.
Additional context
Implementing this feature would enhance user convenience and efficiency when using the URL shortening service.

I would like to work on this issue.

Already solved. merged in #87


Minor cleanup for test_fsdp_checkpoint

What does this PR do?
Minor cleanup for test_fsdp_checkpoint

oh whoops left a print statement!


Separate BlockHash assignments for scroll and non-scroll

Description

Enable BlockHashGadget.

Separate BlockHash assignments to function block_hash_assignments. It is guarded with feature for scroll and non-scroll. Reference this upstream code for non-scroll.

Restrict test case test_simple_pi with feature scroll.

Issue Link
Close https://github.com/scroll-tech/zkevm-circuits/issues/415
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

We must include the scroll feature into the default.

We must include the scroll feature into the default.

May be no scroll as default only for develop branch? @lispc

i don't like this implmentation. As i commented in https://github.com/scroll-tech/zkevm-circuits/pull/336 even though current scroll testnet we can only access blockhash of only 1 prev block, we should not reply on this too much. Maybe in the future we allow access of past 32 blocks.    So even for scroll testnet, we should reply on "self.history_hashes", if that is empty, the find a correct way to fill that.   The only difference between feature scroll or not is the self.history_hashes.len() be 1 or 256.   Avoid use feature scroll as much as possible, no need for
#[cfg(not(feature = "scroll"))]
fn block_hash_assignments<F: Field>(&self, randomness: Value) -> Vec<[Value; 3]>
and
#[cfg(feature = "scroll")]
fn block_hash_assignments<F: Field>(&self, randomness: Value) -> Vec<[Value; 3]>    @silathdiir

done.   I will test whether super circuit tests will fail