Styled-jsx import issue when running test with Jest

I'm not sure where to file an issue for this. I have 3 potential places in mind: jest, styled-jsx and next.js
Since the project that I'm working on is a next.js app, I'll start here.
I have .babelrc file like this
{
  "presets": [
    "next/babel"
  ],
  "plugins": [
    "inline-react-svg"
  ],
  "env": {
    "test": {
      "presets": [
        "latest",
        "react"
      ]
    }
  }
}

next.js version: 2.0.0-beta-19
When I run test with Jest, it throws a syntax error:
/home/khoa/web/thichdoc/src/components/BuildBlocks/Button.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){/* istanbul ignore next */"use strict";Object.defineProperty(exports, "__esModule", { value: true });var _defineProperty2 = require("/home/khoa/web/thichdoc/node_modules/babel-runtime/helpers/defineProperty");var _defineProperty3 = _interopRequireDefault(_defineProperty2);import _JSXStyle from "styled-jsx/style";var _style = require("styled-jsx/style");var _style2 = _interopRequireDefault(_style);var /* istanbul ignore next */_react = require("/home/khoa/web/thichdoc/node_modules/react/react.js"); /* istanbul ignore next */var _react2 = _interopRequireDefault(_react);

    SyntaxError: Unexpected token import

The highlighted part is this line import _JSXStyle from "styled-jsx/style
If I remove next/babel preset, jest runs tests just fine.
Since I can't find a way to disable babelrc inheritance, I have to do some weird tricks with my .babelrc file like this:
{
  "plugins": [
    "inline-react-svg"
  ],
  "env": {
    "dev": {
      "presets": [
        "next/babel"
      ]
    },
    "production": {
      "presets": [
        "next/babel"
      ]
    },
    "test": {
      "presets": [
        "react",
        "latest"
      ]
    }
  }
}

Use babel-plugin-transform-es2015-modules-commonjs babel plugin as well. We don't transpile import/export statements in our preset. (That's to support webpack's tree shaking)
But it'll have issues in the Node.js. So, you need to use the ^^^ plugin.

@thangngoc89 actually, we need to use the es2015 preset. I've updated the Jest example.
See: https://github.com/zeit/next.js/tree/master/examples/with-jest

Reopen, if the issue still exists.

@arunoda as you can see in my config, I'm using babel-preset-latest, it covers es2015 as well as es2016.
If you looks closely to the error dump, you can see that only the styled-jsx import statement wasn't transpiled by babel, others statements are transpiled properly.
If I remove next/babel, the problem goes away. It's probably because of style-jsx tags aren't transpiled at all I guess.

By the way, I can't reopen this issue.

@thangngoc89 I'll try with styled-jsx.

@thangngoc89 I've updated the with-jest example to styled-jsx and it works pretty well.

@arunoda You updated the with-jest example with next/babel in each environment just like my workaround so there shouldn't be a problem for me right now. But it looks weird to me.


Custom table: AuditTo works but WriteTo doesn't.

serilog.aspnetcore 4.1
Serilog.mssqlserver 5.6.0
.net core 5 on windows
Configuration code:
var columnOpts = new ColumnOptions();
columnOpts.Store.Remove(StandardColumn.Id);
columnOpts.Store.Remove(StandardColumn.LogEvent);
columnOpts.Level.ColumnName = "EventLevel";
columnOpts.Level.StoreAsEnum = true;
Log.Logger = new LoggerConfiguration()
.MinimumLevel.Information()
.MinimumLevel.Override("System", LogEventLevel.Warning)
.WriteTo
//.AuditTo
.MSSqlServer(
connectionString: "",
sinkOptions: new MSSqlServerSinkOptions { TableName = "EventLogs", AutoCreateSqlTable = false },
columnOptions: columnOpts
)
.Enrich.WithProcessName()
.CreateLogger();
Problem:
If I use AuditTo, it works great and everything gets written to sql. If I use WriteTo, I get:
Unable to write 1 log events to the database due to following error: The given ColumnMapping does not match up with any column in the source or destination."
Why is WriteTo not happy with my log table, but AuditTo is?

How does your table definition look like?

Since AuditTo is able to write to the db, why would the table definition matter with WriteTo?  What does WriteTo do differently?
CREATE TABLE [dbo].[EventLogs](
[RowId] [UNIQUEIDENTIFIER] ROWGUIDCOL  NOT NULL,
[Timestamp] DATETIMEOFFSET NOT NULL,
[EventLevel] [TINYINT] NOT NULL,
[Message] NVARCHAR NULL,
[MessageTemplate] NVARCHAR NULL,
[Exception] NVARCHAR NULL,
[Properties] NVARCHAR NULL
) ON [PRIMARY] TEXTIMAGE_ON [PRIMARY]

You omit the size parameter in you NVARCHAR columns which on my tests resulted in a table with NVARCHAR columns with size 1. Which means that every log call creating an event with >1 character leads to an exception or error even with the audit sink.

After fixing this, I still got an exception when initializing the logger with your code shown above and then creating the following log event.
Log.Information("Getting started");

The exception that was thrown from the audit sink was this.
System.AggregateException: 'Failed to emit a log event. (Cannot insert the value NULL into column 'RowId', table 'LogTest.dbo.EventLogs'; column does not allow nulls. INSERT fails.
The statement has been terminated.)'

Which code did you use to successfully write log events to your table using the audit sink?
In general the audit sink and the batched (standard) sink use different APIs. The batched sink uses the bulk insert API while the audit sink just sends insert statements using the SqlClient API. Therefore it can happen that they react differently to problems but in general they should both show errors if the table definition does not match the logger configuration.

I'm having the same issue with the following table structure:
CREATE TABLE [dbo].[Log](
	[LogId] [int] IDENTITY(1,1) NOT NULL,
	[Message] [nvarchar](max) NULL,
	[MessageTemplate] [nvarchar](max) NULL,
	[Level] [nvarchar](128) NULL,
	[TimeStamp] [datetime2](7) NOT NULL,
	[Exception] [nvarchar](max) NULL,
	[Properties] [nvarchar](max) NULL,
 CONSTRAINT [PK_Logs] PRIMARY KEY CLUSTERED
(
	[LogId] ASC
)WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [PRIMARY]
) ON [PRIMARY] TEXTIMAGE_ON [PRIMARY]

Using the following config:
"WriteTo": [
			{
				"Name": "MSSqlServer",
				"Args": {
					"connectionString": "...",
					"sinkOptionsSection": {
						"tableName": "Log"
					},
					"restrictedToMinimumLevel": "Debug",
					"columnOptionsSection": {
						"primaryKeyColumnName": "LogId"
					}
				}
			},
			{
				"Name": "Console",
				"Args": {
					"restrictedToMinimumLevel": "Debug"
				}
			}
		]

Console logs fine, moving the SQl part to "AppendTo" works fine as well

@arnederuwe in your case the problem is, that you defined the Id column as identity which means a value for it must not be supplied when inserting rows. But MSSQL sink by default does exactly that. It writes the id of the log event to the column named Id.
A similar case was reported recently by a user.
#340 (comment)

Adding "removeStandardColumns": [ "Id" ] did the trick, thanks for pointing me in the right direction

You're welcome! Good to hear that your problem could be fixed. And thanks for  confirming the solution. 👍


Review and IDentify Columns for QA/Cert Maintenance Data Endpoints

As an ECMPS user, I need to have the columns for the QA/Cert Maintenance Data endpoints identified so we know what needs to be returned and validated.

[ ] Need to review the QA tables

QA Cert Data Maintenance
ENDPOINT: GET /camd-services/admin/qa-maintenance
Parameters:
facilityId (required)
LocationId
type (required) – Need to validate
Responses
Type: QA Test
{
"testSumId": string
"locationId": string
"unitStack": string (show)
"systemIdentifier": string (show combined with component – SysId/CompId if both)
"componentIdentifier": string (show combined with system – SysId/CompId if both)
"testNumber": string (show)
"gracePeriodIndicator": number
"testTypeCode": string (show)
"testResultCode": string
"yearQuarter": string (show)
"testDescription": string
"beginDateTime": string (show)
"endDateTime": string (show)
"testComment": string
"spanScaleCode": string
"submissionAvailabilityCode": string
"submissionAvailabilityDescription": string (show)
"severityCode": string
"severityDescription": string (show)
}
Notes:
• “Identifying Data” will be separated into two columns, Test Number and Test Type
• There is a one to one relationship between test_summary record and qa_supp_data record
• Might want to consider not showing facility in the table since it needs to be selected in the dropdown
Query:
SELECT
ts.test_sum_id AS "testSumId",
ts.mon_loc_id AS "locationId",
COALESCE(u.unitid, sp.stack_name) AS "unitStack",
ms.system_identifier AS "systemIdentifier",
c.component_identifier AS "componentIdentifier",
ts.test_num AS "testNumber",
ts.gp_ind AS "gracePeriodIndicator",
ts.test_type_cd AS "testTypeCode"
ts.test_reason_cd AS "testReasonCode",
ts.test_result_cd AS "testResultCode",
rp.period_abbreviation AS "yearQuarter",
ts.test_description AS "testDescription",
camdecmps.format_date_hour(ts.begin_date, ts.begin_hour, ts.begin_min) AS "beginDateTime",
camdecmps.format_date_hour(ts.end_date, ts.end_hour, ts.end_min) AS "endDateTime",
ts.test_comment AS "testComment",
ts.span_scale_cd AS "spanScaleCode",
ts.injection_protocol_cd AS "injectionProtocolCode",
sac.submission_availability_cd AS "submissionAvailabilityCode",
sac.sub_avail_cd_description AS "submissionAvailabilityDescription",
sc.severity_cd AS "severityCode",
sc.severity_cd_description AS "severityDescription"
FROM camdecmps.test_summary ts
JOIN camdecmps.qa_supp_data sd USING (test_sum_id)
JOIN camdecmps.monitor_location ml ON ml.mon_loc_id = ts.mon_loc_id
JOIN camdecmpsmd.submission_availability_code sac USING(submission_availability_cd)
JOIN camdecmpsmd.reporting_period rp ON rp.rpt_period_id = ts.rpt_period_id
LEFT JOIN camdecmpsaux.check_session cs ON cs.chk_session_id = ts.chk_session_id
LEFT JOIN camdecmpsmd.severity_code sc USING (severity_cd)
LEFT JOIN camdecmps.monitor_system ms ON ms.mon_sys_id = ts.mon_sys_id
LEFT JOIN camdecmps.component c ON c.component_id = ts.component_id
LEFT JOIN camdecmps.stack_pipe sp USING (stack_pipe_id)
LEFT JOIN camd.unit u USING (unit_id);
Type: QA Cert Events
{
"certEventId": string
"locationId": string
"unitStack": string (show)
"systemIdentifier": string (show combined with component – SysId/CompId if both)
"componentIdentifier": string (show combined with system – SysId/CompId if both)
"certEventCode": string (show)
"certEventDescription": string
"eventDateTime": string (show)
"requiredTestCode": string (show)
"requiredTestDescription": string
"conditionalDateTime": string (show)
"lastCompletedDateTime": string (show)
"submissionAvailabilityCode": string
"submissionAvailabilityDescription": string (show)
"severityCode": string
"severityDescription": string (show)
}
Query:
SELECT
qce.qa_cert_event_id AS "certEventId",
qce.mon_loc_id AS "locationId",
COALESCE(u.unitid, sp.stack_name) AS "unitStack"
ms.system_identifier AS "systemIdentifier",
c.component_identifier AS "componentIdentifier",
cec.qa_cert_event_cd AS "certEventCode",
cec.qa_cert_event_cd_description AS "certEventDescription",
camdecmps.format_date_hour(qce.qa_cert_event_date, qce.qa_cert_event_hour, 0) AS "eventDateTime",
rtc.required_test_cd AS "requiredTestCode",
rtc.required_test_cd_description AS "requiredTestDescription",
camdecmps.format_date_hour(qce.conditional_data_begin_date, qce.conditional_data_begin_hour, 0) AS "conditionalDateTime",
camdecmps.format_date_hour(qce.last_test_completed_date, qce.last_test_completed_hour, 0) AS "lastCompletedDateTime",
sac.submission_availability_cd AS "submissionAvailabilityCode",
sac.sub_avail_cd_description AS "submissionAvailabilityDescription",
sc.severity_cd AS "severityCode",
sc.severity_cd_description AS "severityDescription"
FROM camdecmps.qa_cert_event qce
JOIN camdecmps.monitor_location ml ON ml.mon_loc_id = qce.mon_loc_id
JOIN camdecmpsmd.submission_availability_code sac USING(submission_availability_cd)
JOIN camdecmpsmd.qa_cert_event_code cec USING(qa_cert_event_cd)
JOIN camdecmpsmd.required_test_code rtc USING(required_test_cd)
LEFT JOIN camdecmpsaux.check_session cs ON cs.chk_session_id = qce.chk_session_id
LEFT JOIN camdecmpsmd.severity_code sc USING (severity_cd)
LEFT JOIN camdecmps.monitor_system ms ON ms.mon_sys_id = qce.mon_sys_id
LEFT JOIN camdecmps.component c ON c.component_id = qce.component_id
LEFT JOIN camdecmps.stack_pipe sp USING (stack_pipe_id)
LEFT JOIN camd.unit u USING (unit_id);
Type: Test Extension Exemption
{
"testExtensionExemptionId": string
"locationId": string
"unitStack": string (show)
"systemIdentifier": string (show combined with component – SysId/CompId if both)
"componentIdentifier": string (show combined with system – SysId/CompId if both)
"fuelCode": string (show)
"fuelDescription": string
"extensionExemptionCode": string (show)
"extensionExemptionDescription": string
"hoursUsed": number (show)
"spanScaleCode": string (show)
"submissionAvailabilityCode": string
"submissionAvailabilityDescription": string (show)
"severityCode": string
"severityDescription": string (show)
}
Query:
SELECT
tee.test_extension_exemption_id AS "testExtensionExemptionId",
tee.mon_loc_id AS "locationId",
COALESCE(u.unitid, sp.stack_name) AS "unitStack",--SHOW
ms.system_identifier AS "systemIdentifier",--SHOW combined with component SysId/CompId if both
c.component_identifier AS "componentIdentifier",--SHOW combined with system SysId/CompId if both
fc.fuel_cd AS "fuelCode",--SHOW
fc.fuel_cd_description AS "fuelDescription",
eec.extens_exempt_cd AS "extensionExemptionCode",--SHOW
eec.extens_exemp_cd_description AS "extensionExemptionDescription",
tee.hours_used AS "hoursUsed",--SHOW
tee.span_scale_cd AS "spanScaleCode",--SHOW
sac.submission_availability_cd AS "submissionAvailabilityCode",
sac.sub_avail_cd_description AS "submissionAvailabilityDescription",--SHOW
sc.severity_cd AS "severityCode",
sc.severity_cd_description AS "severityDescription"--SHOW
FROM camdecmps.test_extension_exemption tee
JOIN camdecmps.monitor_location ml ON ml.mon_loc_id = tee.mon_loc_id
JOIN camdecmpsmd.submission_availability_code sac USING(submission_availability_cd)
JOIN camdecmpsmd.fuel_code fc USING(fuel_cd)
JOIN camdecmpsmd.extension_exemption_code eec USING(extens_exempt_cd)
LEFT JOIN camdecmpsaux.check_session cs ON cs.chk_session_id = tee.chk_session_id
LEFT JOIN camdecmpsmd.severity_code sc USING (severity_cd)
LEFT JOIN camdecmps.monitor_system ms ON ms.mon_sys_id = tee.mon_sys_id
LEFT JOIN camdecmps.component c ON c.component_id = tee.component_id
LEFT JOIN camdecmps.stack_pipe sp USING (stack_pipe_id)
LEFT JOIN camd.unit u USING (unit_id);

All data types will have a corresponding view from which we will pull data.
The fields marked as (show) will be shown in the UI

ENDPOINT: DELETE /camd-services/admin/qa-maintenance
Parameters:
certEventId: string
testExtensionExemptionId: string
testSumId: string
Notes
• Return status 200 on success
• Delete QA test records from camdecmps.test_summary, camdecmps.qa_supp_data, camdecmpswks.qa_supp_data
• Delete QA Cert Event records from camdecmps.qa_cert_event
• Delete Test Extentions and Exemptions records from camdecmps.test_extention_exemption
• The deletes will be a stored procedure and will be called by a raw query in the code
ENDPOINT: PUT /camd-services/admin/qa-maintenance
certEventId: string
testExtensionExemptionId: string
testSumId: string
Notes:
• Change the submission_availability_cd to “Required” in both global and workspace for cert event, or test extension exemption, or qa supp data
• Return status 200 on success

@fanwari1 the following changes are needed...
Test Summary view
JOIN camdecmpsmd.reporting_period rp ON rp.rpt_period_id = ts.rpt_period_id
this should be a LEFT JOIN becasue test summary data either has begin/end date or a reporting period
Test Ext/Exempt view
rp.period_abbreviation AS "year_quarter",--SHOW in UI
JOIN camdecmpsmd.reporting_period rp ON rp.rpt_period_id = tee.rpt_period_id
missing from SELECT and JOINS and should be there since TEE has reporting period


TagGroup: fix action being hidden

Fixes the case where

maxRows and an action were provided
there was enough room to show all tags within maxRows, but not enough for the action button to fit on the last line

Since we detected that all tags were shown, we wrongly assumed we could stop removing tags. We still need to remove some tags in order to show the action button on the last line.
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:
Test 'with action and maxRows' story. Resize container and make sure action button never gets hidden.
Test other maxRows stories.
🧢 Your Project:

maybe a little too far in the other direction? I can do this now with maxRows=2

maybe a little too far in the other direction? I can do this now with maxRows=2

@snowystinger I'm not able to get into that state. What is the browser and repro steps?

Ah, ok, I see what is happening. I got a little confused. I went to that story, then clicked "Show All" which should rightfully extend beyond the maxRows. However, where it gets weird is that if I expand the container, then eventually everything shows on two rows and the "Show less" button gets hidden. So I was seeing that button appear and disappear even though I hadn't altered the props or interacted with the button again. I'm not sure if it's right or wrong. If it was shown when everything fits, then clicking that button wouldn't do anything anyways.

not sure if this is an issue but with the action + maxRows story, if i don't have it fully expanded with all the tags displayed, there is a specific width where the action button gets hidden

@yihuiliao Good catch! Looks like in the buttons width calculation, I forgot to multiply the margin values we're adding by the number of buttons.
I also noticed that since buttons have the same margin as tags in our css, I can use the static values we have instead of calling window.getComputedStyle.

The math now seems too generous/strict. The first image shows all the items and no buttons, but I decrease the width by just a little and the show/hide button shows up when the last tag would still fit, see second image. They are from "maxRows + onRemove".


⚠ Secret Website 3 has degraded performance

In f0d3963, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2131 ms

Resolved: Secret Website 3 performance has improved in df27b42.


actions that cause errors do not log next state

Bear with me :)
If you dispatch an action that has a side effect which causes an error to thrown, the next state for the action is not logged, even though the state may have changed.
I suspect this is not logged because the assumption is that the reducer failed and therefore did not change the state, but you see this happen a lot when an action is dispatched that, for example, causes a React component to render which itself is throwing an error. In this case, the state actually has been changed: you can see this by inspecting previous state of the next dispatched action.
I would suggest that next state still be logged if an error is triggered. I am happy to create a PR with a unit test and this change, if it is a welcome change.

Yeah, PR is welcome :clap:

Closing, fixed by #115


Uses visual style for long closure arguments

rustfmt seems to use visual style rather than block style when reformatting long closure argument lists:
    let write_status = |status: &mut Vec<ansi_term::ANSIString>,
                        diff: &Diff,
                        heading: &str,
                        color: &Style,
                        show_hints: bool,
                        hints: &[&str]|
     -> Result<bool> {

One possible block-style alternative rustfmt could use:
    let write_status = |
        status: &mut Vec<ansi_term::ANSIString>,
        diff: &Diff,
        heading: &str,
        color: &Style,
        show_hints: bool,
        hints: &[&str]
    | -> Result<bool> {

Yeah even though block indent style is the default for everything else, closures seem to be the exception that are always formatted with visual style.
I'll open a PR today with an update (version gated) to leverage the indent_style config option when formating the closure to offer consistency with function declarations.

cc https://github.com/rust-dev-tools/fmt-rfcs/issues/138.

Reopening as this was closed as part of a change applied to a now-defunct and abandoned branch


Added Query #2 - List of IPs and Domains file communicated with

Shows you a list of distinct IP addresses and DNS names the endpoint had network communication with through a specific file.

Do I close this pull request to complete this process  ?

No, I will.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Jing Nghik<EMAIL_ADDRESS>Sent: Thursday, August 16, 2018 12:42:38 AM
To: Microsoft/WindowsDefenderATP-Hunting-Queries
Cc: Tomer Alpert; Comment
Subject: Re: [Microsoft/WindowsDefenderATP-Hunting-Queries] Added Query #2 - List of IPs and Domains file communicated with (#53)
Do I close this pull request to complete this process ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FWindowsDefenderATP-Hunting-Queries%2Fpull%2F53%23issuecomment-413347418&data=02|01|talpert%40microsoft.com|db82c73593d8423e92b508d602f805c7|72f988bf86f141af91ab2d7cd011db47|1|0|636699661606342816&sdata=F1aVq0LUAZUkCAXGLvcmvaJs8hj92GJervKAbQYGiAE%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAgXopLL-YsC1tfkqSCcVq4wo3bcY_ewIks5uRJXOgaJpZM4V9m41&data=02|01|talpert%40microsoft.com|db82c73593d8423e92b508d602f805c7|72f988bf86f141af91ab2d7cd011db47|1|0|636699661606342816&sdata=FF%2Ff0nW0bQhQOKBNQRQR2c31JggnO1otr%2FlAD8fh3AE%3D&reserved=0.

Oh yeah that's right.


Create Code of Conduct.md

Making Pull Request to Task Manager
Thank you for your contribution to our project! We greatly appreciate your effort and time. Rest assured, if all checks pass and the changes align with our project goals, your pull request will be reviewed promptly and merged.
Table of Contents

Type of Changes
Related Issues
Checklist
Additional Notes
Thank You

Type of Changes
Please check the type of change your PR introduces:

Feature Addition
Bugfix
Documentation Update
Refactoring
Hotfix
UI/UX Improvement
Other(please describe)

Feature Addition

Feature Description:Provide a clear and concise description of the new feature.
Motivation:Explain why this feature is necessary or beneficial.
Implementation Details:Briefly describe how the feature is implemented.
Testing Instructions:Provide steps to test the new feature.

Bugfix

Bug Description:Describe the bug that is being fixed.
Steps to Reproduce:

Step 1
Step 2
...

Expected Behavior:Describe what should happen.
Actual Behavior:Describe what actually happens.
Fix Description:Explain how the bug is fixed.

Documentation Update

Documentation Changes:Describe the documentation changes made.
Sections Affected:List the sections of documentation affected.
Additional Information:Provide any additional context for the documentation changes.

Refactoring

Refactoring Description:Describe the code structure improvements made.
Motivation:Explain why this refactoring is necessary.
Before/After:Provide a brief comparison of the code structure before and after         refactoring.
Performance Impact(if any):Describe any performance improvements or impacts.

Hotfix

Issue Description:Describe the urgent issue being fixed.
Impact:Explain the impact of this issue on production.
Fix Description:Provide details of the fix implemented.
Rollback Plan:Describe the plan to rollback this change if necessary.

UI/UX Improvement

UI/UX Change Description:Describe the UI/UX enhancements made.
Motivation:Explain the reasoning behind these UI/UX changes.
User Impact:Describe how these changes will impact the user experience.
Before/After Screenshots:Provide screenshots showing the UI before and after the changes.

Other

Description:Provide a clear and concise description of the changes you've made.
Motivation:Explain why these changes are necessary or beneficial. What problem does it solve or what improvement does it bring?
Implementation Details:Briefly describe how you implemented these changes. Include any important technical details or design decisions.
Impact:Describe the impact of these changes on the project. Consider aspects such as:
-Performance
-User experience
-Code maintainability
-Dependencies
Testing:Explain how you've tested these changes. Include:
-Types of tests performed
-Test scenarios covered
-Any edge cases considered

Related Issues
If this PR addresses an existing issue, please link to it here:
-**Closes** #[issue number]
-**Screenshots** (if applicable)

If your changes include visual updates, please add screenshots to help explain your changes.
Checklist
-Before submitting your pull request, please review and check off the following items:
 ✅ I have performed a self-review of my own code
 ✅ I have commented my code, particularly in hard-to-understand areas
 ✅ I have made corresponding changes to the documentation
 ✅ My changes generate no new warnings
 ✅ I have added tests that prove my fix is effective or that my feature works
 ✅ New and existing unit tests pass locally with my changes
 ✅ Any dependent changes have been merged and published in downstream modules
 ✅ I have checked my code and corrected any misspellings
 ✅ I have updated the README.md (if applicable)

Additional Notes

Add any other context about the pull request here. This might include:

Challenges you faced and how you overcame them
Areas you'd like reviewers to focus on
Future improvements or follow-up work related to this PR

Thank You
Thank you for taking the time to contribute to the Task Manager! Your efforts help make this project better and more useful for everyone. If you have any questions or need assistance, feel free to reach out by opening an issue or contacting the maintainers.
Happy coding! 🚀

pls review and merge


FetchEvent is not assignable to parameter of type Evt

We have a simple API setup from the TS worker template with itty-router, and up until now it's been working great.
I went to update some packages/dependencies today, and am now unable to complete a build due a type error with getAssetFromKV:
Argument of type 'FetchEvent' is not assignable to parameter of type 'Evt'.
  Property 'waitUntil' is missing in type 'FetchEvent' but required in type 'Evt'.ts(2345)
index.d.ts(32, 5): 'waitUntil' is declared here.

The documentation in this repository shows the exact same format we're using for handling the event.
https://github.com/citycoins/api/blob/fed3fa78d583e290a09306631c82664eca61e339/src/index.ts#L4-L12
If the URL matches an allowed file extension in the root path, then it tries to return that file instead of sending requests to the router. One example from the working deployment before changes is openapi.yml used to generate the documentation page.
https://github.com/citycoins/api/blob/fed3fa78d583e290a09306631c82664eca61e339/src/index.ts#L29-L43
Since addEventListener produces a FetchEvent by default, what is the best approach to pass the correct values to getAssetFromKV? I saw an approach in cloudflare/workers-sdk#4973 that may work, but couldn't find a spot in the docs that made me confident this was the best way to move forward.

Adding to this I reverted the commit locally and tested to be sure - can confirm it compiles with no errors and works as expected.
The packages that were updated as part of the breaking change were:
 itty-router                        ^2.4.10  →   ^2.6.1
 micro-stacks                        ^0.2.2  →   ^0.3.0
 @cloudflare/workers-types           ^3.0.0  →   ^3.9.0
 @types/jest                       ^26.0.23  →  ^27.5.0
 @typescript-eslint/eslint-plugin   ^4.16.1  →  ^5.23.0
 @typescript-eslint/parser          ^4.16.1  →  ^5.23.0
 eslint                             ^7.21.0  →  ^8.15.0
 eslint-config-prettier              ^8.1.0  →   ^8.5.0
 jest                               ^27.0.1  →  ^28.1.0
 prettier                            ^2.3.0  →   ^2.6.2
 ts-jest                            ^27.0.1  →  ^28.0.2
 ts-loader                           ^9.2.2  →   ^9.3.0
 typescript                          ^4.3.2  →   ^4.6.4
 webpack                            ^5.38.1  →  ^5.72.0
 webpack-cli                         ^4.7.0  →   ^4.9.2

I’m going to close this issue for now. Going forward, we’ll revisit the assets system as part of Pages/Workers convergence, and will inherit the benefits of the Pages assets system.
In the meantime, Pages is the best choice for deploying sites with static assets. If you're still running into problems feel free to comment with a reproduction and we can investigate further.


Can you support Chinese ?

Is it possible to support forced alignment of Chinese audio text? Thank you very much!

Hi, I don't have plans on adding Chinese at the moment.  I am open to contributions though


Remove source mapping from async methods

If we remove the source map information from the outer function of the generated code below it would potentially avoid showing the redundant stack frames when debugging with Dart DevTools.
Dart:
foo() async => bar();

Generated JavaScript:
  module.foo = function foo() { // (1)
    return async.async(dart.dynamic, function* foo() { // (2)
      return yield bar.bar();
    });
  };

We need to be careful that we don't drastically regress debugging in chrome devtools in the process.

@nshahan @sigmundch - do we have an owner on this?  It's currently marked Jan.

@nshahan @sigmundch - do we have an owner on this?  It's currently marked Jan.

@mariamhas @grouma Can you help us gauge the priority of this issue? Should this be considered a blocker for the next release?

@mariamhas @grouma Can you help us gauge the priority of this issue? Should this be considered a blocker for the next release?

I don't see this as being a blocker but it's certainly a nice to have fix.

I don't see this as being a blocker but it's certainly a nice to have fix.

@nshahan I'm assigning you as the owner for now.  Feel free to reassign if needed.

@nshahan I'm assigning you as the owner for now.  Feel free to reassign if needed.

After investigating I found the situation is a little different than described. Given:
  module.foo = function foo() { // (1)
    return async.async(dart.dynamic, function* foo() { // (2)
      return yield bar.bar(); // (3)
    });
  };

There are actually no source mapped locations for line (1) so nothing to remove there.
When paused at the line (3) two stack frames appear labeled "foo". The frames correspond to the source mapped locations on lines (2) and (3).
With the current implementation in webdev, I can't find a way to avoid two stack frames appearing when paused on line (3) unless I remove all source mappings from line (2). With those removed the stack traces from errors and the debugging experience in chrome devtools with source maps enabled will regress.
@grouma Let's do some brainstorming to come up with a more targeted way we can detect async methods and hide the unwanted stack frame. Add a list of source maps to ignore in the metadata? Other ideas?

After investigating I found the situation is a little different than described. Given:
  module.foo = function foo() { // (1)
    return async.async(dart.dynamic, function* foo() { // (2)
      return yield bar.bar(); // (3)
    });
  };

There are actually no source mapped locations for line (1) so nothing to remove there.
When paused at the line (3) two stack frames appear labeled "foo". The frames correspond to the source mapped locations on lines (2) and (3).
With the current implementation in webdev, I can't find a way to avoid two stack frames appearing when paused on line (3) unless I remove all source mappings from line (2). With those removed the stack traces from errors and the debugging experience in chrome devtools with source maps enabled will regress.
@grouma Let's do some brainstorming to come up with a more targeted way we can detect async methods and hide the unwanted stack frame. Add a list of source maps to ignore in the metadata? Other ideas?

When collecting async frames we do actually remove duplicate async markers. We could potentially add some similar logic in that class. What would be the signal though? Is it enough to remove back to back frames with the exact same location?

When collecting async frames we do actually remove duplicate async markers. We could potentially add some similar logic in that class. What would be the signal though? Is it enough to remove back to back frames with the exact same location?

When collecting async frames we do actually remove duplicate async markers. We could potentially add some similar logic in that class. What would be the signal though?

I'm not sure, maybe we should hack on this and brainstorm.

Is it enough to remove back to back frames with the exact same location?

I don't think that's the answer because the duplicated frames are not identical because they actually map to different lines.

When collecting async frames we do actually remove duplicate async markers. We could potentially add some similar logic in that class. What would be the signal though?

I'm not sure, maybe we should hack on this and brainstorm.

Is it enough to remove back to back frames with the exact same location?

I don't think that's the answer because the duplicated frames are not identical because they actually map to different lines.

Any update?

Any update?

To properly resolve this issue we likely need to make use of the DDC metadata files. This issue is very similar to https://github.com/dart-lang/webdev/issues/1179. We won't get to it in this quarter but we intend to have an OKR around  enhanced inspection next quarter. This enhanced inspection will leverage additional metadata within the DDC metadata files instead of relying on various heuristics.

To properly resolve this issue we likely need to make use of the DDC metadata files. This issue is very similar to https://github.com/dart-lang/webdev/issues/1179. We won't get to it in this quarter but we intend to have an OKR around  enhanced inspection next quarter. This enhanced inspection will leverage additional metadata within the DDC metadata files instead of relying on various heuristics.


Desktop-Version's pull request

In this branch, I have added the flexibility to the personal portfolio project, it is has now desktop and mobile version

Thank you for reviewing my project!
On Fri, Jun 10, 2022 at 9:50 AM Kanu Mike Chibundu @.***>
wrote:

@.**** requested changes on this pull request.
Hi @TuyishimireEric https://github.com/TuyishimireEric ,
Good job so far!
There are some issues that you still need to work on to go to the next
project but you are almost there!
[image: you-are-near]
https://camo.githubusercontent.com/34482800e1b92cb79ddca06edb4051edc407cb190f896e1e949e596aa9073851/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f556461535559436c723932636a57706556782f67697068792e676966
Highlights

No linters error 💯
Good Summary of PR 👍
Good commit messages 👍

Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you to take them
into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.html
https://github.com/TuyishimireEric/Portfolio-mobile-version-2/pull/3#discussion_r894235137
:

Contact me

           If you have an application you are interested in developing,

           a feature that you need built or a project that needs coding.

           i'd love to help with it.

       <form action="https://formspree.io/f/{form_id}" methop="post" class="text-me">

           <input type="text" class="simple" placeholder="User name" maxlength="30" required>

           <input type="email" class="simple" placeholder="Email" required>

           <textarea class="text-area" placeholder="comment" required></textarea>

           <button type="submit" class="project">Get in touch</button>

       </form>

Please I recommend, you try fixing the background image for the contact
me section as it is missing some of the background images from the
Figma design.
Please try to increase the width of the contact form fields as it is
looking too narrow on desktop view. so it has a good UI and looks like that
of the Figma design.

Figma design
[image: Screenshot from 2022-06-10 08-26-48]
https://user-images.githubusercontent.com/58771507/173013910-7ebd6fd6-5450-40cc-9d9b-dff7af6eeee2.png
Your design
[image: Screenshot from 2022-06-10 08-26-19]
https://user-images.githubusercontent.com/58771507/173013943-1e380be9-be2e-45ad-af6f-5272b8458d6b.png
In index.html
https://github.com/TuyishimireEric/Portfolio-mobile-version-2/pull/3#discussion_r894244095
:

About Myself

Please work on the margin-top of the about section to the project
section, so that it looks like that of the Figma design with a good UI
Please work on the left and right margin on the project section as
it is too large on your design

Your design (with directions on areas to work on)
[image: Screenshot from 2022-06-10 08-38-17]
https://user-images.githubusercontent.com/58771507/173015790-48335e6e-67fd-4950-963c-aa199644aba8.png
Figma design
[image: Screenshot from 2022-06-10 08-41-59]
https://user-images.githubusercontent.com/58771507/173015995-bbb5ab29-079e-4559-8c9e-58dd5dca0a69.png
In index.html
https://github.com/TuyishimireEric/Portfolio-mobile-version-2/pull/3#discussion_r894248154
:

Languages

JavaScript

HTML

Please work on the text color used for the image below, so it
corresponds to that of the Figma design. Make it black #000

Your design
[image: Screenshot from 2022-06-10 08-43-43]
https://user-images.githubusercontent.com/58771507/173016945-9fcbed55-025b-4007-ace6-4d89f69eef53.png
Figma design
[image: Screenshot from 2022-06-10 08-47-13]
https://user-images.githubusercontent.com/58771507/173017046-20355563-18bb-42e4-81e7-c438e4dfe1ab.png
Reach out to me on slack @kanu mike chibundu if you find this feedback
confusing
—
Reply to this email directly, view it on GitHub
https://github.com/TuyishimireEric/Portfolio-mobile-version-2/pull/3#pullrequestreview-1002361612,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYP7GBURRAMBPS6HAYOGDJTVOLXSRANCNFSM5YKUGLDQ
.
You are receiving this because you were mentioned.Message ID:
<TuyishimireEric/Portfolio-mobile-version-2/pull/3/review/1002361612@
github.com>


Add standard-version for automatic changelog and version bump

I find https://github.com/conventional-changelog/standard-version to be an amazing tool to create releases. This adds a yarn release command which automatically bumps your version (can be displayed inside the plugin), adds a git tag, creates/ appends a changelog.md .
All you need to do is to add feat: my awesome feature or fix: fixes the world or breaking: integrated non-backward compatibe feature as your commit message (only the ones that are supposed to show up inside the changelog) and upon yarn release you get the complete changelog
Example:

I have setup the release-drafter and create proper GH releases. do you think that is enough, or should we additionally have a changelog.md ?
we probably can use the same content.

release drafter looks to do the same as standard-version so it's rather a preference of what you prefer on a workflow level


Write installation howtos

To be uploaded on the website, with screenshots for each step.

Installation of ThermoCycle + ExternalMedia on Windows (+ VS 2010)
Installation of ThermoCycle + ExternalMedia on Linux (+ GCC)
Use of ThermoCycle Viewer
Use of ThermoCycle Viewer on linux

hi Dr. Quoilin, when can we expect the installation guide with the screenshots?

I have Dymola 2015 for the last 6 months now and yet I have not been able to simulate the Thermocycle for some reason (!). I am desperately looking forward for this installation guide. Please make it fast.

Maybe git submodules could be a solution to deliver the correct version of ExternalMedia to the user!?


wasmer tests hanging in CI

The WInterJS/wasmer tests are mostly hanging in CI, causing the support updates to fail. For this reason I've disabled the tests for now. It can be intermittently reproduced locally when running pnpm generate in the root. It doesn't seem to happen so much when running the tests on their own in the generator/runtimes/wasmer directory, and just seems to manifest when run in the group. Setting concurrency to 1 doesn't help.
Cc @Arshia001  @syrusakbary

Hey @ascorbic! It's been a while, and we fixed a number of stability issues on WinterJS in the meantime. I can't reproduce this issue right now. I do have a number of fixes for WinterJS, for which I'll be opening a PR shortly, once version 1.2.0 is out. Hopefully, everything will be working at that point and we can re-enable the tests.

@ascorbic please have a look at #138, and let me know if I missed anything that should have been updated.


New package: SimpleStringScanners v0.2.1

Registering package: SimpleStringScanners
Repository: https://github.com/hsugawa8651/SimpleStringScanners.jl
Created by: @hsugawa8651
Version: v0.2.1
Commit: 4397c7f5fc9f736c2914c4458d6d3949a3e90b2e
Reviewed by: @hsugawa8651
Reference: https://github.com/hsugawa8651/SimpleStringScanners.jl/issues/1#issuecomment-2005575678
Description: Julia package for lexical scanning operations on a string

See https://github.com/JuliaRegistries/General/pull/103034#issuecomment-2002493557.
You cannot make new releases while the original registration is pending. Please be more careful in the future!

You also can't skip releases. So you have to release 0.2.0 first, but only after 0.1.0 is merged.


Meshery failed on minikube provider, error: ImagePullBackOff

[ ] Description

pods status=ImagePullBackOff.
Expected Behavior

pods status=Running
Screenshots

Logs from Lens

Environment:

OS: [macOS]
Browser: [Brave]
Version: [0.4.6]
Device: [Laptop]

[Optional] To Reproduce
Steps to reproduce the behavior:

git clone https://github.com/layer5io/meshery.git; cd meshery
kubectl create ns meshery
kubectl -n meshery apply -f install/deployment_yamls/k8s
kubectl -n meshery get pods

[Optional] Additional Context

Image pulling was successful with the mesheryctl tools.

@IkeChukwuanu thank you for filing this. Excellent detail. I went ahead and executed the repro steps below:
➜  ~ minikube start
🔄  Starting existing hyperkit VM for "minikube" ...
⌛  Waiting for the host to be provisioned ...
🐳  Preparing Kubernetes v1.17.0 on Docker '19.03.5' ...
🚀  Launching Kubernetes ...
🏄  Done! kubectl is now configured to use "minikube"

➜  ~ minikube status
host: Running
kubelet: Running
apiserver: Running
kubeconfig: Configured

➜  ~ k get pods -A
NAMESPACE     NAME                               READY   STATUS    RESTARTS   AGE
kube-system   coredns-6955765f44-8q95g           1/1     Running   3          147d
kube-system   coredns-6955765f44-cbd5b           1/1     Running   3          147d
kube-system   etcd-minikube                      1/1     Running   3          147d
kube-system   kube-addon-manager-minikube        1/1     Running   3          147d
kube-system   kube-apiserver-minikube            1/1     Running   3          147d
kube-system   kube-controller-manager-minikube   1/1     Running   5          147d
kube-system   kube-proxy-vnnn6                   1/1     Running   3          147d
kube-system   kube-scheduler-minikube            1/1     Running   5          147d
kube-system   storage-provisioner                1/1     Running   4          147d

➜  ~ git clone https://github.com/layer5io/meshery.git
Cloning into 'meshery'...
remote: Enumerating objects: 100, done.
remote: Counting objects: 100% (100/100), done.
remote: Compressing objects: 100% (76/76), done.
remote: Total 15874 (delta 55), reused 48 (delta 24), pack-reused 15774
Receiving objects: 100% (15874/15874), 86.90 MiB | 8.17 MiB/s, done.
Resolving deltas: 100% (10965/10965), done.

➜  ~ cd meshery

➜  meshery git:(master) kubectl create ns meshery
namespace/meshery created

➜  meshery git:(master) kubectl -n meshery apply -f install/deployment_yamls/k8s
deployment.apps/meshery-consul created
service/meshery-consul created
deployment.apps/meshery-cpx created
service/meshery-cpx created
deployment.apps/meshery created
deployment.apps/meshery-istio created
service/meshery-istio created
deployment.apps/meshery-kuma created
service/meshery-kuma created
deployment.apps/meshery-linkerd created
service/meshery-linkerd created
deployment.apps/meshery-nsm created
service/meshery-nsm created
deployment.apps/meshery-octarine created
service/meshery-octarine created
deployment.apps/meshery-osm created
service/meshery-osm created
service/meshery created
serviceaccount/meshery created
clusterrole.rbac.authorization.k8s.io/meshery-cr created
clusterrolebinding.rbac.authorization.k8s.io/meshery-crb created

➜  meshery git:(master) kubectl -n meshery get pods

NAME                                READY   STATUS    RESTARTS   AGE
meshery-7d57bc7756-8z25j            1/1     Running   0          110s
meshery-consul-649f9785f-lvwbb      1/1     Running   0          109s
meshery-cpx-7c88b9f756-7zklp        1/1     Running   0          109s
meshery-istio-5d88b99f89-2j8sh      1/1     Running   0          109s
meshery-kuma-8bcb67cfb-b8bhw        1/1     Running   0          109s
meshery-linkerd-67c5d4c4f-k2g8m     1/1     Running   0          108s
meshery-nsm-59c4bf9bdc-wk7pw        1/1     Running   0          110s
meshery-octarine-54b75f87fc-899fq   1/1     Running   0          109s
meshery-osm-5674df7587-6whqz        1/1     Running   0          109s

I wonder if there is a network connection issue from the minikube cluster out to the Internet in your environment.
Successfully pulling the images with mesheryctl is a good sign. mesheryctl system start, however, will pull and run the Meshery images in docker, not kubernetes/minikube. So, that is a different test.
What do you think? Verify network connectivity from minikube to the Internet/Docker Hub? Deploy another sample application to verify?


Codeunit 101 - Add parameter in the event OnBeforeUpdateCustLedgerEntry

Request to add one parameter "CustEntryApplID" in the event "OnBeforeUpdateCustLedgerEntry" inside procedure "UpdateCustLedgerEntry".
// OLD
OnBeforeUpdateCustLedgerEntry(TempCustLedgerEntry, ApplyingCustLedgerEntry, AppliesToID, IsHandled);
// NEW
OnBeforeUpdateCustLedgerEntry(TempCustLedgerEntry, ApplyingCustLedgerEntry, AppliesToID, CustEntryApplID, IsHandled);

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


problems with skin segmentation

I tried to use the task for skin segmentation with the line:
TotalSegmentator -i ct.nii.gz -o seg -ta body
but it doesn't work. In gives me the following error:
FileNotFoundError: [Errno 2] No such file or directory: 'C:\Users\Martina\.totalsegmentator\nnunet\results\nnUNet\3d_fullres\Task273_Body_extrem_1259subj\nnUNetTrainerV2__nnUNetPlansv2.1\plans.pkl'
Exception ignored in: <totalsegmentator.libs.DummyFile object at 0x000002308DDE8110>
AttributeError: 'DummyFile' object has no attribute 'flush'
However, if I do not specify the body task, the segmentation works but it does not present the skin segmentation, that is actually the only thing I need.
Is there something I can do to fix it?

Which version of totalsegmentator are you using?

It is version 1.5.6

Can you try again with the newest totalsegmentator?
pip install --upgrade totalsegmentator

Now it worked, thank you!

Hello, I am using the same command only getting segmentations of body trunk and body extremities, but no skin. Is there a way to pull out just the skin segmentation? I have tried --roi_subset skin and -ta body --roi_subset skin, but get the errors seen in the images.

just use -ta body without setting roi_subset.

the skin segmentation does not work with --ml. Can you try without?


Bug fixes and Stats watchdog

Based on PR #94.

Fix bugs that prevented kyco tests from passing
Begin Stats watchdog with switch description

Please fix the conflicts. Sorry for this.

I solved, but everything is in develop now because of another PR.


Crash : createParser  reason: Material version mismatch. Expected 12 but received 11.

Describe the bug
A clear and concise description of what the bug is.
I'm running the samples.sample-multi-view on Android.
A Crash appeared when the app started.
To Reproduce
Steps to reproduce the behavior:

run the sample on Android.

Expected behavior
Crash!!!
Screenshots
Logs
E/Filament: Panic
in filament::MaterialParser *filament::createParser(filament::backend::Backend, const void *, size_t):69
reason: Material version mismatch. Expected 12 but received 11.
A/libc: Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 22910 (ament.multiview), pid 22910 (ament.multiview)
Smartphone (please complete the following information):

Device: [e.g. MI 8 ]
OS: [e.g. Android Pie 9.0]

Additional context
I noticed that the method MaterialParser::createParser was called twice.Once is called when filament engine creating, the version it got was 12 , correct ! Another time is when I load the gltf model by the AssetLoader , it got the Material version is 11 and it crashed. Why  it was called twice and where the  Material version it got from?

The problem occured when I update the version to v1.11.1

It looks like you have a stale material file somewhere that you need to recompile. Try a clean build.


Autosave is called more than once for single change

The autosave directive in (/public/modules/forms/directives/autosave.client.directive.js) ends up doing double or more saves for a single change detected.
I think this may be because of debouncing wrt $watch function or also due to the fact that the form itself changes after it saves (triggerring yet another save). Debouncing/checking should be done on client side to maintain code cleanliness.
PS.
Look here http://adamalbrecht.com/2013/10/30/auto-save-your-model-in-angular-js-with-watch-and-debounce/ for inspiration on debouncing

This has been fixed with a counter.


Ensure publishing of dependent libs upon major bump

We have occasional problems where we publish a new major version e.g. of ms-rest-js but don't publish a new major version of a dependent lib like ms-rest-azure-js or ms-rest-nodeauth.
As long as the versions on npm are in this state, proper usage of these related libraries impossible, so let's come up with an automation of some kind to publish new versions of the dependent libraries upon publish of a new major of a core library.
Let's have this issue be concerned with the libraries with common dependencies:

ms-rest-js
ms-rest-azure-js
ms-rest-nodeauth
ms-rest-browserauth (pending)

azure-env should not be affected.
This will probably be solved in the azure-sdk-for-js itself using lerna. Over there we can monolithically update a dependency, update the package versions and publish fairly easily.

@azure/ms-rest-js is currently in maintenance mode with no new features being added and taking only bug fixes. We are moving active development efforts in the azure-sdk-for-js repo on @azure/core-http that will power the next generation of the Azure packages. Therefore, closing this issue.


Scroll issue

Hi @nrlnishan, I have an issue with the library.
I have 4 tabs. After customizing the ViewPager, I made the ViewPager select the 4th tab with:  viewPager.displayViewController(atIndex: 3). Now the 4th tab is selected. But when I scroll left it goes to the 1st tab instead of 3rd. Could you please check.

Hey @yashinls , Issue #6 has been fixed and code is available in master branch. Sorry for the hassle, i will provide with cocoapod support soon.
Regarding this issue #21, I cannot recreate this issue. Are you sure you are not doing anything extra which is causing the problem? Can you provide me the exact step to recreate this issue?
Thanks

Hi @nrlnishan, I ain't doing anything extra. Please see the attached zip file. Try swiping, once the app has loaded. If we swipe to left it goes to 1st tab and if I swipe to right it goes to the last tab.
Btw, I'm testing it in on iOS 8.1. Does it support iOS 8?
test.zip

Hey @yashinls ,
Above mentioned issue has been fixed.

Thanks @nrlnishan


import and compile error

- error:
hello, when i run demo, i get the error: ImportError: cannot import name 'ball_query_ext' from 'mmdet3d.ops.ball_query' (/opt/sdatmp/lq/project/gitproject/mmdetection3d/mmdet3d/ops/ball_query/init.py).
It seems come from these error when i run pip install -v -e . to install MMDetection3D:
warning: no files found matching 'mmdet3d/ops//.cpp'
warning: no files found matching 'mmdet3d/ops//.cu'
warning: no files found matching 'mmdet3d/ops//.h'
warning: no files found matching 'mmdet3d/ops//.cc'
FAILED: /opt/sdatmp/lq/project/gitproject/mmdetection3d/build/temp.linux-x86_64-3.7/mmdet3d/ops/spconv/src/indice_cuda.o
error: cannot call member function ‘void std::basic_string<_CharT, _Traits, _Alloc>::_Rep::_M_set_sharable()
Traceback (most recent call last):
File "setup.py", line 253, in zip_safe=False)
File "/opt/sdatmp/lq/anaconda/envs/open_mmlab/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1140, in _write_ninja_file_and_compile_objects
error_prefix='Error compiling objects for extension')
File "/opt/sdatmp/lq/anaconda/envs/open_mmlab/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1413, in _run_ninja_build
raise RuntimeError(message)
RuntimeError: Error compiling objects for extension
- My environment:
ubuntu 18.04
cuda 10.1
pytorch 1.5.0
mmcv-full 1.3.1
mmdet 2.11.0
mmdet3d 0.12.0
numpy 1.20.2
pycocotools 2.0.2
cuDNN 7.6.03
gcc 7.5.0
besides, i have tested torch.cuda.is_available() and got True
I ran mmdet3d.utils.collect_env.py, and got the following print message:

Have you encounter these errors before? I need your help, thankyou

Please refer to #420 . If there is any further question, please follow the template for reimplementation issue to redescribe your problem.

Can you successfully import mmcv and mmdet? Please strictly follow the way given in the documentation to install these two packages. For your compilation error, it maybe related to your gcc or cuda version. Please search for some information about the error message like this


Don't show widget if useragent matches bot/crawler

Uses regex used by Agent_Orange to detect bots and stop any potential SEO degradation
mitigates #65
(Side note, this is my first pull request/commit to an external project so sorry if I've messed something up)

@decoy31 How does this look to you?
@Sgtpanda I'm hesitant to merge right now without trying to sample UAs from our current submissions, but the general approach here looks promising!

Needs lot of testing

Closing this as wontfix due to lack of capacity for thoroughly testing this change, see https://github.com/fightforthefuture/battleforthenet-widget/issues/65#issuecomment-337065821


Buildings Panel

Need a way to close it besides double click it on ground. Escape does not work.

Fixed.
Pressing escape now closes the new building list.


Display Exception Notification in game

The game captures all exceptions for logging, but often continues as if nothing happened even after catastrophic failures.  Display notifications of an exception in game to better alert plugin developers that something broke and roughly what gameplay caused it.  Instead of showing the full exception, show an ID that can be used to search the logs for the exact event.

This got added as temporary notifications in game.


[1.10] Fixed date string parsing.

With this commit we fix the date string parsing in the dcos-core-cli
plugin to parse more combinations of the ISO 8601 standard. This issue
was seen in when the datestring had a different format than
2017-03-30T15:50:16.187+0000.
https://jira.mesosphere.com/browse/DCOS-45992

@mesosphere-ci run all integration-tests

@mesosphere-ci run all integration tests


node-open breaks on Linux - switch to opn?

You mentioned in https://github.com/stevelacy/gulp-open/issues/18 that you were considering opn over node-open.
Presently, node-open is broken on Linux - I get Error: spawn open ENOENT because the open command doesn't exist on Linux. A workaround for my use case has been to symlink xdg-open to open, but that's super inelegant, and might well break for other use cases.
Since node-open is deprecated anyway, do you anticipate making a switch anytime soon? I'm happy to submit a PR.

I'll be glad to take a PR, thanks.


⚠ Bofrost.be has degraded performance

In d0e639b, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2738 ms

Resolved: Bofrost.be performance has improved in 61fa915.


stat/distuv: provide complete test coverage for Poisson

Also uses mathext.GammaIncReg to implement Poisson Survival.
Please take a look.

PTAL.

ping

@vladimir-ch Is that OK now?


MisCommited

Commit #469 on old python2 branch.
commit bbcf6f6
PR to revert #589

This can be closed now.


Remove extension from received audio packets

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes Issue: NaN
Description
With the new update (v5.1.0) that uses the new voice encryption modes, when the bot receives audio from regular users (not bots) it throws opus decoder errors in the debug logs.
The issue is that the header extension (present in user's audio packets) is not being stripped from the encoded (but decrypted) audio packet.
This PR fixes that by offseting the decrypted audio ByteBuffer by 4 * extension length in the RTP header .

Please also adjust the test with these changes


Request for a new release post 0.3

Hi Nicolas,
It would be good to get the recent bug fixes published - from #24  etc.
Also, could you provide a Scala 2.12 build for this?
I'm happy to help with setting up and testing the 2.12 build if you want me to do this as a PR from my side.

Scala 2.12 is a good idea. If you can help me setting up the build I would greatly appreciate it.

Great - let me get something together for 2.12, then I'll raise a PR.
Sent from my iPhone

On 1 Dec 2016, at 15:03, Nicolas Stucki<EMAIL_ADDRESS>wrote:
Scala 2.12 is a good idea. If you can help me setting up the build I would greatly appreciate it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

PR #26 is in the works....

Nice

Any idea when a 2.12 build will be published on Maven or what is left to be done? This is the last dependency I need so that I can bump one of my projects to 2.12. Thanks!

I just published version 0.4 with 2.12. It should be up in a short time.

Thanks, Nicolas.


Add minSize to circle.ts and rect.ts to prevent drawing unintentionally tiny shapes

I found it might be more reasonable to limit the circle and the rectangle to their minimal size by the width of stroke width.
Without the limitation, I have been occasionally added some "very tiny" circles or rectangles on the canvas and didn't aware it.
I have intermediate Python experience but nothing about web apps nor typescript (very beginner understanding about JS).
Therefore I tried to modify the code by guessing the rules from the original code base, and there are probably some bad programming styles or practices.
Also this is my first PR. I've tried to get rid of the unwanted files (i.e., the folder named test_app/) but got no luck.
In short, only circle.ts and rect.ts are relevant in this PR.
If there are anything I can study from please also let me know.

Hi, thank you for the workflow guidance, which has been what I need. I think I have fixed the PR (as it now shows only the two changed files). Please take a look and let me know whether I did it right or not.

Hello @hiankun
Finally had a look at your changes locally and it looks good!
I'm ready to merge, but for this we need 2 last things:

Could you format your code with Prettier? I usually have VSCode do it on Save as you write, but if you're using another IDE then doing npx prettier --write src\lib\rect.ts and npx prettier --write src\lib\circle.ts at streamlit_drawable_canvas\frontend level should do
Your PR is still in draft mode so I can't merge it :upside_down_face:

Have a nice day,
Fanilo :balloon:

Hi @andfanilo ,
Thanks again for all the suggestions and instructions from which I've learned a lot. :-D


Clone local map when cloning agents

The local map also needs to be copied if an agent is cloned, since otherwise the driving corridor in the clone still references the original, which could lead to unwanted side effects.

As the agents are always copied into the ObservedWorld this would slow BARK too much down.


Improve fakes2av2 test suite

Instead of starting up / stopping the service per unit test, set it up once before the for loop, and use it for all the tests.

In the last push of the branch, committed after running git rebase main, to pick up the other changes that have already merged.


'request' event data contains duplicated inbound http request

We have an application monitored by appmetrics 2.0.1, the test request is as following:
User use: /rest/api/getAllPets to request data, application send a http://localhost:4001/api/pets request to query and return the result to user.
As the request event data cannot be stringified. I write logs to print its content iterate.
********** request event data ********** is the event data itself.
data.request is included in ********** request event data ********** section, so we don't print it separately.
********** children of request event data ********** is each child in children and iterate.
we can see, request id=4 and request id=5 both have type=HTTP. But they are all means to /rest/api/getAllPets. They are duplicated. And actually, request id=5 don't have much meaningful context like request id=4.
request id=6 is correct, because it is the HTTP Outbound request, which call http://localhost:4001/api/pets.
[2017-02-14 01:21:06.939] [ERROR] knj_log - ********** request event data **********
[2017-02-14 01:21:06.940] [ERROR] knj_log - { time:<PHONE_NUMBER>913,
  type: 'HTTP',
  name: '/rest/api/getAllPets',
  duration: 24.483617,
  request:
   Request {
     children: [ [Object] ],
     name: '/rest/api/getAllPets',
     type: 'HTTP',
     parent: undefined,
     id: 4,
     top: [Circular],
     timer:
      Timer {
        startTime: [Object],
        startTimeMillis:<PHONE_NUMBER>913,
        timeDelta: 24.483617,
        cpuTimeDelta: -1 },
     active: false,
     tracedStart: true,
     context: { url: '/rest/api/getAllPets' },
     traceStopped: true,
     stack: 'Error\nat ServerResponse.res.end(/root/JanDemo/http_app/node_modules/connect/lib/middleware/logger.js:149)\nat ServerResponse.module.exports [as send](/root/JanDemo/http_app/node_modules/response-send/lib/response-send.js:108)\nat IncomingMessage.<anonymous>(/root/JanDemo/http_app/index.js:74)\nat <module>.emitOne(events.js:96)\nat IncomingMessage.emit(events.js:188)\nat IncomingMessage.Readable.read(_stream_readable.js:381)\nat <module>.flow(_stream_readable.js:761)\nat <module>.resume_(_stream_readable.js:743)\nat <module>._combinedTickCallback(internal/process/next_tick.js:74)' } }

[2017-02-14 01:21:06.948] [ERROR] knj_log - ********** children of request event data **********
[2017-02-14 01:21:06.948] [ERROR] knj_log - name: request
[2017-02-14 01:21:06.949] [ERROR] knj_log - type: HTTP
[2017-02-14 01:21:06.949] [ERROR] knj_log - id: 5
[2017-02-14 01:21:06.949] [ERROR] knj_log - Error
at <module>.callbacks(/root/JanDemo/http_app/node_modules/express/lib/router/index.js:165)
at <module>.param(/root/JanDemo/http_app/node_modules/express/lib/router/index.js:139)
at <module>.pass(/root/JanDemo/http_app/node_modules/express/lib/router/index.js:146)
at Router._dispatch(/root/JanDemo/http_app/node_modules/express/lib/router/index.js:173)
at Object.router(/root/JanDemo/http_app/node_modules/express/lib/router/index.js:33)
at <module>.next(/root/JanDemo/http_app/node_modules/connect/lib/proto.js:190)
at Object.cookieParser [as handle](/root/JanDemo/http_app/node_modules/connect/lib/middleware/cookieParser.js:60)
at <module>.next(/root/JanDemo/http_app/node_modules/connect/lib/proto.js:190)
at Object.methodOverride [as handle](/root/JanDemo/http_app/node_modules/connect/lib/middleware/methodOverride.js:37)
[2017-02-14 01:21:06.950] [ERROR] knj_log - Timer {
  startTime: [ 9787573, 526364099 ],
  startTimeMillis:<PHONE_NUMBER>919,
  timeDelta: 2.760739,
  cpuTimeDelta: -1 }

[2017-02-14 01:21:06.951] [ERROR] knj_log - ********** children of request event data **********
[2017-02-14 01:21:06.951] [ERROR] knj_log - http://localhost:4001/api/pets
[2017-02-14 01:21:06.951] [ERROR] knj_log - HTTP Outbound
[2017-02-14 01:21:06.952] [ERROR] knj_log - 6
[2017-02-14 01:21:06.952] [ERROR] knj_log - Error
    at Array.forEach (native)
at <module>.callbacks(/root/JanDemo/http_app/node_modules/express/lib/router/index.js:165)
at <module>.param(/root/JanDemo/http_app/node_modules/express/lib/router/index.js:139)
at <module>.pass(/root/JanDemo/http_app/node_modules/express/lib/router/index.js:146)
at Router._dispatch(/root/JanDemo/http_app/node_modules/express/lib/router/index.js:173)
at Object.router(/root/JanDemo/http_app/node_modules/express/lib/router/index.js:33)
at <module>.next(/root/JanDemo/http_app/node_modules/connect/lib/proto.js:190)
[2017-02-14 01:21:06.952] [ERROR] knj_log - Timer {
  startTime: [ 9787573, 527096606 ],
  startTimeMillis:<PHONE_NUMBER>920,
  timeDelta: 2.265243,
  cpuTimeDelta: -1 }

To add to what xiaoshimimi mentioned, the issue here is that there are two top level HTTP request events within one Top level Http Request (id:4 and id:5). id:4 request type is HTTP but id:5 request which appears as a nested request also has a type HTTP and and not Http Outbound. How can we have have two HTTP inbound requests as part of one request? So we think id:5 should not be part of the request event. If it's an outbound http call, then it's request type must be HTTP Outbound. We want to better understand is this (id:5)  an issue with data or by design?

The embedded child request is not a duplicate of the parent request.

it has a different id value (5 vs 4)
it has a different name (request vs /rest/api/getAllPets)
the contents of 5's Error do not match the contents of 4's stack.

In fact the only thing they have in common is that they are of type HTTP.
5 is not a top-level HTTP request as it's name is not in the form of a path. It looks like a method name.
Given the test code you're running has many many errors, my theory is that something in the request method of 4 caused an error to occur and 5 has been created by our metrics as the error propagates back up the stack.
@xiaoshimimi , @ravigadekarla Can you please fix your test application so that it doesn't emit errors and retest.

@xiaoshimimi , @ravigadekarla, please respond.

yes, all three point means 5, 4 are different, but they are all marked as "HTTP" type. actually only 4 is "HTTP" type, 5 should not be.

@xiaoshimimi could you post your test application or a small test case so we can reproduce please?

outbound-http.zip, please also reference issue 365 for basic usage.

@xiaoshimimi it took us quite a while to reproduce this, e.g. your test case package.json was requiring appmetrics 1.0.11 and we had to change port and hostname in the sample-rest-api project.  We also didn't see the same debug printed out as you and we had to add in the children. I don't think you can have sent us the test case you were actually running?  We have now reproduced it though after those changes

Thanks very much to @sjanuary for sorting out the problems with the sent test application! We've narrowed the culprit down to the Express probe. I'll put up a PR changing the type it emits to 'Express' but we're not sure if that's the right value - will get @seabaylea to review.

Lets remove the express probe as it doesn't provide any value right now


[cryptolib] Add an RSA raw-modexp function.

Description
Ti50 firmware have to support a use case where padding for RSA encrypt is done externally. Current RSA implementation doesn't support this.
For this NULL padding RSA encrypt implementation shall:

Pad input to RSA length as needed with zeroes
Check that input value is within valid range (less than N), remove leading zeroes to fit into RSA size

@moidx , @jadephilipoom , @cfrantz

This is a pretty dangerous thing to support. RSA padding is security-critical. Is there any way you can support this use-case without a direct option in the cryptolib? And do you need to support any padding other than OAEP?
I'd be okay with supporting a "pre-padded" option, where you assert that the input is already (for example) OAEP-padded, and cryptolib checks that this is true using the same method as we'd use to check padding in decryption. That would allow the use-case you describe, but it would also avoid exposing an option that completely skips the padding step.

This is a legacy stuff, which is unfortunately used on the very critical path used now. The existing authentication method use CKM_MD5_RSA_PKCS mechanism, which beyond using legacy hash,  seems to differ from TPM_ALG_RSAES (PKCS1) supported by TPM directly, so it is done outside to limit changes in TPM2 and crypto and not to bring MD5.  From https://groups.oasis-open.org/higherlogic/ws/public/download/50264/CKM_RSA_PKCS_FIPS_186_4_v02.pdf/latest:
It differs from the standard PKCS#1 OAEP RSA encryption mechanism in that the plaintext is wrapped in a TPM_BOUND_DATA structure before being submitted to the encryption process and that all of the values of the parameters that are passed to a standard CKM_RSA_PKCS_OAEP operation are fixed. On encryption, the version field of the TPM_BOUND_DATA structure must contain 0x01, 0x01, 0x00, 0x00. On decryption, any structure of the
form 0x01, 0x01, 0xXX, 0xYY may be accepted.

https://chromium.googlesource.com/chromiumos/third_party/tpm2/+/569c3c58dc69d5c8628f3c329937c136be38df3f
Besides OAEP,  RSAES-PKCS1-v1_5 from https://datatracker.ietf.org/doc/html/rfc3447  is needed for the similar kind of legacy stuff.

This is a legacy stuff, which is unfortunately used on the very critical path used now. The existing authentication method use CKM_MD5_RSA_PKCS mechanism, which beyond using legacy hash, seems to differ from TPM_ALG_RSAES (PKCS1) supported by TPM directly, so it is done outside to limit changes in TPM2 and crypto and not to bring MD5. From https://groups.oasis-open.org/higherlogic/ws/public/download/50264/CKM_RSA_PKCS_FIPS_186_4_v02.pdf/latest

The link goes to a "working draft" from more than 10 years ago that mentions the name but doesn't say what the algorithm actually does. Can you provide a little more context for what it is and where it is needed, if possible? The link also references TPM 1.1, but my understanding was that you needed TPM2, no? Using MD5 in 2024 seems like a surprising choice in any context, although I appreciate the need to support legacy setups.
Do I understand correctly that:

there is some legacy system you cannot change but need to support
it is separate from TPM and has its own requirements
it uses RSA encryption with MD5 and PKCS#1 v1.5 padding and doesn't support any other option, and
it uses this RSA encryption as an authentication mechanism?

The last point is additionally surprising to me, because I wouldn't normally think of RSA encryption as a method for authentication.

It differs from the standard PKCS#1 OAEP RSA encryption mechanism in that the plaintext is wrapped in a TPM_BOUND_DATA structure before being submitted to the encryption process and that all of the values of the parameters that are passed to a standard CKM_RSA_PKCS_OAEP operation are fixed. On encryption, the version field of the TPM_BOUND_DATA structure must contain 0x01, 0x01, 0x00, 0x00. On decryption, any structure of the
form 0x01, 0x01, 0xXX, 0xYY may be accepted.

This description of a specific OAEP mechanism seems like it's outside the scope for this issue; it reads to me like the plaintext is just formatted a certain way and then passed directly to OAEP with certain fixed parameters. Then you have to do some extra checks after decryption on the data structure, but if I understand correctly the internal OAEP primitive is not modified and this should be quite possible on top of OT cryptolib's implementation.

https://chromium.googlesource.com/chromiumos/third_party/tpm2/+/569c3c58dc69d5c8628f3c329937c136be38df3f
Besides OAEP, RSAES-PKCS1-v1_5 from https://datatracker.ietf.org/doc/html/rfc3447 is needed for the similar kind of legacy stuff.

The link appears to be about RSA signing; we do already support PKCS#1 v1.5 padding for signatures, just not encryption. There are no known attacks against the PKCS#1 v1.5 padding for signatures, but the PKCS#1 v1.5 padding method for encryption has been known-vulerable since Bleichenbacher's attack in 1998. I feel strongly that we should not add direct support for it.

Can you provide a little more context for what it is and where it is needed, if possible?

It took some time to find what specifically was used and it happened to be PKCS1.5 padding (not OAEP) with MD5  for the message done by the caller.
Yes, reference to TPM2 & OAEP was misleading - it is an implementation detail that we repurposed TPM2 command instead of using custom vendor command which wouldn't mix in TPM2 specific fields.

Do I understand correctly that: ...

Correct for all points. The legacy system which use this method is not part of ChromeOS, but we have to support interoperability with it. The purpose to is to actually use RSA Decrypt in TPM with padding done in software to support required RSA signing with MD5/PKCS1.5.  Support for NULL padding enables this use of RSA Decrypt - we can sign with any unsupported algorithms like MD5 or SHA1 if this is the only thing that can work with the other party.

Okay, thanks, I think I understand the concern better now. How about this: we add a new, separate API call to the cryptolib  that runs a bignum modular exponentiation and assumes the exponent is secret. Under the hood this will call the internal RSA modexp routine from sw/device/lib/crypto/rsa/modexp.h just like RSA decrypt does. It will not be efficient for encryption/sigverify because it won't take advantage of the non-secret exponent, although it will still be functionally correct for those cases.
I like this solution because it's not the kind of thing someone would call by accident -- I'd worry that simply adding a NULL padding option would lead callers to think that's simply another reasonable padding option they can use. But, for special or legacy use-cases like this, the new function acts as an "escape hatch" that lets you do custom RSA if you know why you're doing it, with appropriate warnings in the docstring. Does that suit your needs @vsukhoml ?

Yes, having this modexp sounds good. I would appreciate if that solution would accept same format ( otcrypto_blinded_key_t ,  otcrypto_ubblinded_key_t)  of RSA key to avoid unnecessary changes in storage format as RSA keys are pretty large.

@vogelpi / @johannheyszl please note @jadephilipoom analysis above. From cert perspective will this cause an issue? Should this be considered in M3 - otherwise in the schedule it could cause an issue if added in late in the day.

@johngt this is a cryptolib issue and does not require any HW changes. IMO it is not M3, and labeled well, thanks


Feature/planrepoadmin

Add PlanRepository.active boolean field (defaults to True, since we've been deleting inactive planrepos) to determine if a planrepository should be ...active
Only evaluate webhooks for active planrepos
Only display active planrepos for the run plan screen (and new org please)
Display the active status on planrepo list views (on the plan and repo details pages)
Add a PlanRepositoryInline to both the plan and repository admin configs, making it less tedious to wire up a new repo.
remove the deprecated PlanSchedule model and table, lest we try and do something like add a row to that model and it crash and burn

okay, I don't actually like this because you can't .filter() on alive, you have to know the private member. so...not totally done.

@davisagli - okay, the default manager for PlanRepository now automatically adds a calculated alive based on both plan and planrepo.  I display this on the Repository plan list. I also use this when filtering on plan repo now.
buuut...it doesn't work on the related filter in the webhook, so...not quite there yet.
even then, I did something hackish to make the pointwise version "work", see the property on the model. I'm...not sure this is a good idea? there are definitely going to be a bunch of ways that it could get stale...
going to take a bit more iteration... probably should have tests, probably should have tests around everything around it.... but bare minimum i need to fix the related filter on the webhook.

Note that the migration failed in HerokuCI

@davisagli - got rid of that wacky computed field, and used a queryset method as discussed. also resolved the CI issue, and added some more validations that the planrepo is indeed active.

ready for rereview :)


Reset password does not work

What I'm trying to achieve
Have my password reset in storefront.
Steps to reproduce the problem

Go to storefront
click in Have you forgotten your password section
enter your email and click Reset password
reset password screen disappears
in browser console you can see the error that is not being handled in any way

Frontend sends hardcoded "" as redirectUrl so that's probably why it breaks as it is validated on backend

What I expected to happen
Password reset email should be sent and I get confirmation message to check my inbox or something similar.
System information
Operating system: MacOS Catalina
Browser: Chrome

This seems to be resolved already.


Merge 6-3 updates to live

Docs Build status updates of commit 17ef11e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Access.ComboBox.md
:white_check_mark:Succeeded
View

api/Access.CurrentProject.md
:white_check_mark:Succeeded
View

api/Access.Form.md
:white_check_mark:Succeeded
View

api/Access.ListBox.md
:white_check_mark:Succeeded
View

api/Access.Printer.md
:white_check_mark:Succeeded
View

api/Access.Printers.md
:white_check_mark:Succeeded
View

api/Access.Report.md
:white_check_mark:Succeeded
View

api/Access.Screen.md
:white_check_mark:Succeeded
View

api/Access.WebServices.md
:white_check_mark:Succeeded
View

api/Excel.Worksheet.md
:white_check_mark:Succeeded
View

api/Office.COMAddIn.Description.md
:white_check_mark:Succeeded
View

api/Office.COMAddIn.Guid.md
:white_check_mark:Succeeded
View

api/Office.COMAddIn.ProgId.md
:white_check_mark:Succeeded
View

api/Office.COMAddIn.md
:white_check_mark:Succeeded
View

api/Office.CommandBar.BuiltIn.md
:white_check_mark:Succeeded
View

api/Office.CommandBar.Delete.md
:white_check_mark:Succeeded
View

api/Office.CommandBar.NameLocal.md
:white_check_mark:Succeeded
View

api/Office.CommandBarButton.Tag.md
:white_check_mark:Succeeded
View

api/Office.CommandBarComboBox.Change.md
:white_check_mark:Succeeded
View

api/Office.CommandBarComboBox.List.md
:white_check_mark:Succeeded
View

api/Office.CommandBarComboBox.ListCount.md
:white_check_mark:Succeeded
View

api/Office.CommandBarControl.Tag.md
:white_check_mark:Succeeded
View

api/Office.CommandBarControl.md
:white_check_mark:Succeeded
View

api/Office.CommandBars.FindControls.md
:white_check_mark:Succeeded
View

api/Office.CustomXMLPart.NodeAfterDelete.md
:white_check_mark:Succeeded
View

api/Office.CustomXMLPart.NodeAfterInsert.md
:white_check_mark:Succeeded
View

api/Office.CustomXMLPart.NodeAfterReplace.md
:white_check_mark:Succeeded
View

api/Office.CustomXMLPart.SelectSingleNode.md
:white_check_mark:Succeeded
View

api/Office.CustomXMLParts.PartAfterAdd.md
:white_check_mark:Succeeded
View

api/Office.CustomXMLParts.PartBeforeDelete.md
:white_check_mark:Succeeded
View

api/Office.CustomXMLValidationError.md
:white_check_mark:Succeeded
View

api/Office.CustomXMLValidationErrors.md
:white_check_mark:Succeeded
View

api/Office.DocumentInspector.Fix.md
:white_check_mark:Succeeded
View

api/Office.DocumentInspector.Inspect.md
:white_check_mark:Succeeded
View

api/Office.DocumentInspector.md
:white_check_mark:Succeeded
View

api/Office.DocumentInspectors.md
:white_check_mark:Succeeded
View

api/Office.DocumentLibraryVersion.Comments.md
:white_check_mark:Succeeded
View

api/Office.DocumentLibraryVersion.Modified.md
:white_check_mark:Succeeded
View

api/Office.DocumentLibraryVersion.md
:white_check_mark:Succeeded
View

api/Office.DocumentLibraryVersions.IsVersioningEnabled.md
:white_check_mark:Succeeded
View

api/Office.DocumentLibraryVersions.md
:white_check_mark:Succeeded
View

api/Office.DocumentProperties.Count.md
:white_check_mark:Succeeded
View

api/Office.DocumentProperty.LinkSource.md
:white_check_mark:Succeeded
View

api/Office.DocumentProperty.LinkToContent.md
:white_check_mark:Succeeded
View

api/Office.DocumentProperty.Name.md
:white_check_mark:Succeeded
View

api/Office.FileDialog.AllowMultiSelect.md
:white_check_mark:Succeeded
View

api/Office.FileDialog.ButtonName.md
:white_check_mark:Succeeded
View

api/Office.FileDialog.FilterIndex.md
:white_check_mark:Succeeded
View

api/Office.FileDialog.Filters.md
:white_check_mark:Succeeded
View

api/Office.FileDialog.InitialFileName.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


vertex/workbench-instance-stuck-in-provisioning doesn't work correctly

After trying to debug why a Vertex AI workbench isn't working the GCP docs pointed me to this tool. Unfortunately this particular runback doesn't seem to work with the following command, I have tried in both Cloud Console and Locally.
./gcpdiag runbook vertex/workbench-instance-stuck-in-provisioning \
    --project="***" \
    --parameter "instance_name=***" \
    --parameter "zone=europe-west2-a"

When running I get the following error
gcpdiag 🩺 0.72

Starting runbook inspection [Alpha Release]
project: ***, parameters: {instance_name=***,project_id=***,zone=europe-west2-a}

[ERROR] vertex/workbench-instance-stuck-in-provisioning: Diagnostic Tree has not been registered or does not exist. Please verify the product and class name, and ensure the file containing the class does not have any syntax error

Am I doing something wrong? The GCP docs have exactly the same command (which actually has a missing slash on the end of the first line).

Hi Adam, thanks for reporting this. We had to do a rollback of the most recent version (0.73) because of problems with the docker image, and I think that that's the reason why it is not working now. We will work on soon publishing a new fixed version.

Hello, thanks for reaching out with this error. I'm happy to share that we have rolled out a fix to the docker image issue with version 0.74 which is now live and available on the cloud shell as referenced in the GCP docs.
If you are still seeing this error, please let me know and I can follow up right away.

Thank you both for jumping on this quickly!
I can confirm that 0.74 fixes the issue!


Some of your vocabs are not ok; skos:broader VS skos:topConceptOf

Same error as described here: https://github.com/iqb-vocabs/Bildungstandard2023-erste-Fremdsprache-MSA/issues/1#issue-2099972131
Some of your top concepts are linking to the concept scheme with skos:broader instead of skos:topConceptOf

Thank you Steffen. We'll check our vocabularies.


[BUG]: Install ColossalAI with docker

🐛 Describe the bug
Install ColossalAI with docker,
cd ColossalAI
docker build -t colossalai ./docker
error:
Successfully installed apex-0.1
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
Removing intermediate container c93930dca032
---> 7f233c85eaa7
Step 6/8 : RUN git clone https://github.com/hpcaitech/ColossalAI.git     && cd ./ColossalAI     && CUDA_EXT=1 pip install -v --no-cache-dir .
---> Running in ce069f1f38ef
Cloning into 'ColossalAI'...
Using pip 21.2.4 from /opt/conda/lib/python3.9/site-packages/pip (python 3.9)
Processing /workspace/ColossalAI
DEPRECATION: A future pip version will change local packages to be built in-place without first copying to a temporary directory. We recommend you use --use-feature=in-tree-build to test your packages with this new behavior before it becomes the default.
pip 21.3 will remove support for this functionality. You can find discussion regarding this at https://github.com/pypa/pip/issues/7555.
Installing build dependencies: started
Running command /opt/conda/bin/python /tmp/pip-standalone-pip-ha6cq51m/env_pip.zip/pip install --ignore-installed --no-user --prefix /tmp/pip-build-env-ppkw8hq3/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple -- 'setuptools>=40.8.0' wheel
Collecting setuptools>=40.8.0
Downloading setuptools-67.5.1-py3-none-any.whl (1.1 MB)
Collecting wheel
Downloading wheel-0.38.4-py3-none-any.whl (36 kB)
Installing collected packages: wheel, setuptools
Successfully installed setuptools-67.5.1 wheel-0.38.4
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Running command /opt/conda/bin/python /opt/conda/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py get_requires_for_build_wheel /tmp/tmp1m9hq8hs
Traceback (most recent call last):
File "/opt/conda/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 349, in
main()
File "/opt/conda/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 331, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "/opt/conda/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 117, in get_requires_for_build_wheel
return hook(config_settings)
File "/tmp/pip-build-env-ppkw8hq3/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 338, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
File "/tmp/pip-build-env-ppkw8hq3/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 320, in _get_build_requires
self.run_setup()
File "/tmp/pip-build-env-ppkw8hq3/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 484, in run_setup
super(_BuildMetaLegacyBackend,
File "/tmp/pip-build-env-ppkw8hq3/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 335, in run_setup
exec(code, locals())
File "", line 121, in
File "", line 38, in environment_check_for_cuda_extension_build
ModuleNotFoundError: [extension] PyTorch is not found while CUDA_EXT=1. You need to install PyTorch first in order to build CUDA extensions
Getting requirements to build wheel: finished with status 'error'
WARNING: Discarding file:///workspace/ColossalAI. Command errored out with exit status 1: /opt/conda/bin/python /opt/conda/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py get_requires_for_build_wheel /tmp/tmp1m9hq8hs Check the logs for full command output.
ERROR: Command errored out with exit status 1: /opt/conda/bin/python /opt/conda/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py get_requires_for_build_wheel /tmp/tmp1m9hq8hs Check the logs for full command output.
The command '/bin/sh -c git clone https://github.com/hpcaitech/ColossalAI.git     && cd ./ColossalAI     && CUDA_EXT=1 pip install -v --no-cache-dir .' returned a non-zero code: 1
Environment
ycwang@ycwang-ThinkPad-P50:~/colossalai/ColossalAI$ nvidia-smi
Mon Mar  6 22:02:19 2023
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 525.78.01    Driver Version: 525.78.01    CUDA Version: 12.0     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  Quadro M2000M       Off  | 00000000:01:00.0 Off |                  N/A |
| N/A   35C    P8    N/A /  N/A |      6MiB /  4096MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      1322      G   /usr/lib/xorg/Xorg                  2MiB |
+-----------------------------------------------------------------------------+

Hi @YuchengWang , could you please try directly pull our image from docker hub by docker pull hpcaitech/colossalai?

Hi @kurisusnowdeng , What's the correct command to pull image from docker hub?
ycwang@ycwang-ThinkPad-P50:~$ docker image pull hpcaitech/colossalai
Using default tag: latest
Error response from daemon: manifest for hpcaitech/colossalai:latest not found: manifest unknown: manifest unknown
ycwang@ycwang-ThinkPad-P50:~$ docker pull hpcaitech/colossalai
Using default tag: latest
Error response from daemon: manifest for hpcaitech/colossalai:latest not found: manifest unknown: manifest unknown

i met the some case.

@YuchengWang @colynhn Maybe try a specific tag would help (e.g. docker pull hpcaitech/colossalai:0.2.7).

Thanks, Finished pull docker.

Glad to hear it was resolved. Thanks.


Warning for wrongly-imported addons

Motivation
I wasted 2 days pulling my hair figuring out why the addons' panels weren't showing up. Turns out I wasn't importing them from addons.js.
Here was my config.js:
import { configure } from '@storybook/react';
import '@storybook/addon-actions/register';
import '@storybook/addon-links/register';
import '@storybook/addon-notes/register'

function loadStories() {
  require('./story-1.js');
  // You can require as many stories as you need.
}

configure(loadStories, module);

I missed addon.js entirely in the docs as I was just skimming through. My bad!
Solution
Add a warning in the console if the addons were imported before addons.js was loaded. Or anything similar.

I haven't taken a look on the codebase if if my idea is feasible, but I'd like to work on this if it sounds good.

Thanks for adding tags, @danielduan . Hopefully I could check out the Storybook codebase soon this week :D


Possible concurrency issue

Yo guys, was just looking into sources and found pretty suspicious usage of non-thread-safe collection.
Please consider using ConcurrentHashMap there because it may be accessed from different threads with subscribeOn and unsubscribeOn.
Library looks nice! (extra points for Spock!)

Yes, this may be true, we will take a look. However ConcurrentHashMap may not be enough. We should synchronize whole read/create operation.

Issue will be fixed by https://github.com/Polidea/RxAndroidBle/pull/6.


How to create TileLayer with custom source which needs authorization

Hi,
Can the react-vector-tile-layer component be used to create a TileLayer using tileloadfunction which sets authorization as is done with OpenLayers like below
new TileWMS({

        url: mapLayer.url,
        params: {
            'LAYERS': mapLayer.layer,
            'VERSION': '1.1.1',
            'TILED': true,
            'FORMAT': 'image/png',
            'WIDTH': 256,
            'HEIGHT': 256
        },
        serverType: 'geoserver',
        tileLoadFunction: function(tile, src) {

            var xhr = new XMLHttpRequest();
            xhr.open("GET", src);
            xhr.responseType = "arraybuffer";
            xhr.setRequestHeader("Authorization", mapLayer.apiKey );
            xhr.onload = function () {
                var arrayBufferView = new Uint8Array(this.response);
                var blob = new Blob([arrayBufferView], { type: 'image/png' });
                var urlCreator = window.URL ;
                var imageUrl = urlCreator.createObjectURL(blob);
                tile.getImage().src = imageUrl;
            };
            xhr.send();

          }
    });

I do not think so. Maplibre GL JS is used to render the vector tiles and the React props are passed onto the Maplibre GL JS constructor so please refer to the Maplibre GL JS documentation to see if what you are trying to achieve is possible.


Categorize Agents / Use superagent for different projects

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
It would be helpful to be able to categorize agents by projects. I can see two scenarios where it makes managing agents simpler if they are categorized.
Developers
Using superagent to build an app means that a lot of agents get created. Often times at least one agent per user. Now you maybe wanna have not only your user-created agents but also agents that are created by yourself. To be able to find them in the UI or get the right agent easily through an API call it would be nice to have each agent associated to a project.
So a developer could fetch all agents from project xyz to display only those.
NoCode users & Business use cases
Users who are using mostly the frontend to interact with superagent might use it in different teams, for different use cases or projects. But you mostly do not wanna create a new account for each project or use case. There a differentiation of agents by projects in the UI would make sense.
It would also be helpful for future improvements of superagent for teams. Having projects allows to build a feature where you can invite other superagent users to a project to be able to update agens, documents and prompts.
What changes are required

[ ] New DB Table for projects (Name, id, members etc.)
[ ] New field for projectId on the agents, documents, prompts, tools tables
[ ] Update API calls to fetch by projectId
[ ] Updated UI to show projects

📝 Additional Context
Example of projects from vercel
This is an example of how the UI for projects could look like. The user would select a project > Inside the project are all related agents, tools, documents and prompts.

Acknowledgements

[X] My issue title is concise and descriptive.
[X] I have searched the existing issues to make sure this feature has not been requested yet.
[X] I have provided enough information for the maintainers to understand and evaluate this request.

@simonweniger 100% agree. How would you Adapt the UI for this?

@simonweniger what do you think about adding tags instead of categories?

That sounds good! Do you think about adding a tags field with an array of tags to the agent?

@homanp It would be extremely helpful if I could add tags through an API call. With this feature, I could attach a userId from a user to the agent and then easily fetch information by tag userid. This would eliminate the need for me to store which user has which agent on my end. I believe many developers who create agents for their users would greatly benefit from this functionality.