Failed to download cover 3D (or any other graphic), 404 Not Found

I get this error in the Log when I try to download covers.  I'm not seeing any INI or other file/setting to check on where these are downloaded from, since its 404 Not Found.
EDIT: Searched the code. Looks like GameID for the link to https://art.gametdb.com/wii/disc/  is "0x00", since that is what shows in the field of Game ID in the DETAILS part on the main form on the right side.  It doesn't update, at least on my install, of the ID Game Code, such as https://art.gametdb.com/wii/disc/US/PZLE01.png for Zelda gamecube.
So I think the program tries to download from https://art.gametdb.com/wii/disc/US/0x00.png, which doesn't exist.

[2022-10-27 14:49:48] [ERROR] The remote server returned an error: (404) Not Found.
at System.Net.HttpWebRequest.GetResponse()
at GCBM.frmMain.DownloadOnlyDisc3DCoverSelectedGame(DataGridView dgv)[2022-10-27 14:49:48] [ERROR] Failed to download cover (3D)!
[2022-10-27 14:49:48] [ERROR] The remote server returned an error: (404) Not Found.
at System.Net.HttpWebRequest.GetResponse()
at GCBM.frmMain.DownloadOnlyDisc3DCoverSelectedGame(DataGridView dgv)

Having the same problem. The game ID is correct but disc ID is not.
2022-11-22 09:38:26] [ERROR] Failed to Download covers (Disc)
[ERROR] The remote server returned an error: (404) Not Found.
at System.Net.HttpWebRequest.GetResponse()
at GCBM.frmMain.DownloadOnlyDisc3DCover(DataGridView dgv)[2022-11-22 09:38:26] [ERROR] Failed to download cover (3D)!
[ERROR] The remote server returned an error: (404) Not Found.
at System.Net.HttpWebRequest.GetResponse()
at GCBM.frmMain.DownloadOnlyDisc3DCover(DataGridView dgv)[2022-11-22 09:38:26] [ERROR] Failed to Download covers (Disc)

Its been awhile since I've installed Visual Studio, but going to look more into it in the next few weeks.  I'm sure its something easily resolved, I just need to see how the code flow with grabbing the Game/Disc ID.
frmMain.cs line 1296 is the code for the function DownloadOnlyDisc3DCoverSelectedGame.  This is where the error happens and is shown in the log.
I haven't figured out how to run the code yet, and step into each variable.  But something is causing it, possibly the _IDMakerCode string.

I get this error in the Log when I try to download covers. I'm not seeing any INI or other file/setting to check on where these are downloaded from, since its 404 Not Found.
EDIT: Searched the code. Looks like GameID for the link to https://art.gametdb.com/wii/disc/ is "0x00", since that is what shows in the field of Game ID in the DETAILS part on the main form on the right side. It doesn't update, at least on my install, of the ID Game Code, such as https://art.gametdb.com/wii/disc/US/PZLE01.png for Zelda gamecube.
So I think the program tries to download from https://art.gametdb.com/wii/disc/US/0x00.png, which doesn't exist.

[2022-10-27 14:49:48] [ERROR] The remote server returned an error: (404) Not Found.
at System.Net.HttpWebRequest.GetResponse()
at GCBM.frmMain.DownloadOnlyDisc3DCoverSelectedGame(DataGridView dgv)[2022-10-27 14:49:48] [ERROR] Failed to download cover (3D)!
[2022-10-27 14:49:48] [ERROR] The remote server returned an error: (404) Not Found.
at System.Net.HttpWebRequest.GetResponse()
at GCBM.frmMain.DownloadOnlyDisc3DCoverSelectedGame(DataGridView dgv)

Terribly sorry, yeah you were right there, _IDMakerCode was/is a remnant of how game information used to be stored (one at a time, in global variables). This should've been, and has been corrected to game.ID.
Thank you for your patience and for pointing this out. kudos for debugging and going the extra mile. If I had cleaned up the code properly and gotten rid of old remnants fully instead of unhooking them, and slowly taking them out, you probably would've had a much easier time. As it is.. the code is messy even for me to come back to ..

I haven't programmed for a long time, so was fun to parse through the code and do some sleuthing.  Though I'm sure you'd be able to figure this out in a few moments without any assistance.
Thanks for updating this.  My son will be thrilled.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Sean Johnson @.>
Sent: Thursday, February 23, 2023 6:52:58 PM
To: AxionDrak/GameCube-Backup-Manager @.>
Cc: dogchainx @.>; Author @.>
Subject: Re: [AxionDrak/GameCube-Backup-Manager] Failed to download cover 3D (or any other graphic), 404 Not Found (Issue #106)
I get this error in the Log when I try to download covers. I'm not seeing any INI or other file/setting to check on where these are downloaded from, since its 404 Not Found.
EDIT: Searched the code. Looks like GameID for the link to https://art.gametdb.com/wii/disc/https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fart.gametdb.com%2Fwii%2Fdisc%2F&data=05|01||40fc994e593541718c3108db1609dbb4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638128003819081376|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Q7XkATedxp%2B8e4yLXm5jefGIRwfmlGCkSyUX%2BhV69wo%3D&reserved=0 is "0x00", since that is what shows in the field of Game ID in the DETAILS part on the main form on the right side. It doesn't update, at least on my install, of the ID Game Code, such as https://art.gametdb.com/wii/disc/US/PZLE01.pnghttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fart.gametdb.com%2Fwii%2Fdisc%2FUS%2FPZLE01.png&data=05|01||40fc994e593541718c3108db1609dbb4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638128003819081376|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=%2BrkkJCyW1EV%2BxZpsnGJZDoBpFhtVjutvqjK6CDn0B48%3D&reserved=0 for Zelda gamecube.
So I think the program tries to download from https://art.gametdb.com/wii/disc/US/0x00.pnghttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fart.gametdb.com%2Fwii%2Fdisc%2FUS%2F0x00.png&data=05|01||40fc994e593541718c3108db1609dbb4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638128003819081376|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=0%2B9g9zbmYIoXGgOg4lQ4QRILA5FRRKvS7oM8ddewjos%3D&reserved=0, which doesn't exist.
[2022-10-27 14:49:48] [ERROR] The remote server returned an error: (404) Not Found.
at System.Net.HttpWebRequest.GetResponse()
at GCBM.frmMain.DownloadOnlyDisc3DCoverSelectedGame(DataGridView dgv)[2022-10-27 14:49:48] [ERROR] Failed to download cover (3D)!
[2022-10-27 14:49:48] [ERROR] The remote server returned an error: (404) Not Found.
at System.Net.HttpWebRequest.GetResponse()
at GCBM.frmMain.DownloadOnlyDisc3DCoverSelectedGame(DataGridView dgv)
[Gamecube program]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F7515795%2F198507439-79a3113d-76d1-4a35-bcee-da96a7ef2204.png&data=05|01||40fc994e593541718c3108db1609dbb4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638128003819081376|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Xr9fHlJvLcUfFvYAJsFN9Bm2NyEY3mrFT7Yk%2BR3Klw4%3D&reserved=0
Terribly sorry, yeah you were right there, _IDMakerCode was/is a remnant of how game information used to be stored (one at a time, in global variables). This should've been, and has been corrected to game.ID.
Thank you for your patience and for pointing this out. kudos for debugging and going the extra mile. If I had cleaned up the code properly and gotten rid of old remnants fully instead of unhooking them, and slowly taking them out, you probably would've had a much easier time. As it is.. the code is messy even for me to come back to ..
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAxionDrak%2FGameCube-Backup-Manager%2Fissues%2F106%23issuecomment-1442682589&data=05|01||40fc994e593541718c3108db1609dbb4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638128003819081376|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=TJzZmoNKTloIgN7uMn0r3Osoi0SMmVXl8uYtcqwuVTY%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABZK5E3M4C4GLG3MUFC4Z7TWZAH7VANCNFSM6AAAAAARQOOJYA&data=05|01||40fc994e593541718c3108db1609dbb4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638128003819081376|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=LgwSArNGIHdy1V6wawJk2LXTuKLSK%2ByW%2BYztVBCkZH4%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


XIOS Integration (MVP)

Nextsim XIOS Integration
Closes #218
This is a master pull request tracking the integration of XIOS for File I/O into Nextsim DG. Some of the sub-components are being tracked by separate PRs. See the design document on the Wiki for more information on XIOS Integration.
The core functionality of XIOS is included as part of this PR as the other two components will require it.
Core XIOS functionality
Closes #293
XIOS uses a client-server model. To use XIOS we must first initialize the clients on each process (cxios_init_client) and subsequently initialize the server (cxios_context_initialize). Here are the necessary steps to be able to setup the XIOS client & server processes.

[x] add XIOS to the cmake build process i.e., CMakeLists.txt
[x] initialize client and server process from inside nextsimdg
[x] verify correct setup and exit
[x] add unit tests
[x] merge in Kacper's latest MPI branch (mpi_local) (I am dependent on doctest with MPI support)
[ ] rewrite XIOS tests to use mpi-aware doctest

NOTE currently addressing bug in Xios class that affects the getCalendarTimestep method. For now I have implemented a work around (I have now fixed this with #424 but I want to find a better solution for mpi-aware doctests).
Once the essentials have been created to begin using XIOS my intention is for the development branches to be structured as follows:
Merge instructions
When development of all XIOS features is ready (#422, #421 and this PR). The plan is to merge them (in reverse order) into this branch, finally merging this branch back into feat_mar3

feat_mar3

feature218_xios_io - #265

xios-nextsim-data-io - #422
xios-nextsim-sync-data - #421

Notes on XIOS

XIOS is a third party library which was designed to handle file I/O asynchronously
Documentation is possibly out-dated (last update 2018) and some of the interface methods are undocumented which adds complexity.
You can read more in the UserGuide and the ReferenceGuide
There is a more recent training session (2020).
XIOS requires a configuration .xml file defining a calendar system to run
Most settings can be either set in the .xml or at runtime (see UserGuide for more info)

CMake progress is good but needs some tidying. E.g. Proof of concept build is working.

this PR has got stale due to significant changes since the beginning of XIOS project. This PR will be superseded by #496 .


Implement the navbar component

assign me this

@manthanmk66 This issue is already implemented. Can you assign another issue?

@manthanmk66 can you assign to ( #25 #24  #23 #22 ) any of these.


Where is cache['attention_mask']?

When using the sparsegpt pruning method, the following code is used, but kwargs['attention_mask'] appears to be None, resulting in a subsequent error.
class Catcher(nn.Module):
def init(self, module):
super().init()
self.module = module
def forward(self, inp, **kwargs):
inps[cache['i']] = inp
cache['i'] += 1
cache['attention_mask'] = kwargs['attention_mask']
cache['position_ids'] = kwargs['position_ids']
raise ValueError

This is the argument that the LLaMA2 model expect https://github.com/huggingface/transformers/blob/v4.39.0/src/transformers/models/llama/modeling_llama.py#L704


Add php 8.1 support

Currently experience this error:
PHP Fatal error:  During inheritance of ArrayAccess: Uncaught ErrorException: Return type of Illuminate\Http\Request::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Http/Request.php:637
Stack trace:
#0 /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Http/Request.php(20): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError()
#1 /home/runner/work/baum/baum/vendor/composer/ClassLoader.php(578): include('...')
#2 /home/runner/work/baum/baum/vendor/composer/ClassLoader.php(432): Composer\Autoload\ClassLoader::Composer\Autoload{closure}()
#3 /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/SetRequestForConsole.php(31): Composer\Autoload\ClassLoader->loadClass()
#4 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php(332): Illuminate\Foundation\Bootstrap\SetRequestForConsole->bootstrap()
#5 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php(223): Orchestra\Testbench\TestCase->resolveApplicationBootstrappers()
#6 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/TestCase.php(73): Orchestra\Testbench\TestCase->createApplication()
#7 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns/Testing.php(79): Orchestra\Testbench\TestCase->refreshApplication()
#8 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/TestCase.php(41): Orchestra\Testbench\TestCase->setUpTheTestEnvironment()
#9 /home/runner/work/baum/baum/tests/Baseline/UnitAbstract.php(14): Orchestra\Testbench\TestCase->setUp()
#10 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestCase.php(1147): Baum\Tests\Baseline\UnitAbstract->setUp()
#11 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestResult.php(728): PHPUnit\Framework\TestCase->runBare()
#12 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestCase.php(904): PHPUnit\Framework\TestResult->run()
#13 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSuite.php(675): PHPUnit\Framework\TestCase->run()
#14 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSuite.php(675): PHPUnit\Framework\TestSuite->run()
#15 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSuite.php(675): PHPUnit\Framework\TestSuite->run()
#16 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(653): PHPUnit\Framework\TestSuite->run()
#17 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/Command.php(144): PHPUnit\TextUI\TestRunner->run()
#18 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/Command.php(97): PHPUnit\TextUI\Command->run()
#19 /home/runner/work/baum/baum/vendor/phpunit/phpunit/phpunit(98): PHPUnit\TextUI\Command::main()
#20 /home/runner/work/baum/baum/vendor/bin/phpunit(123): include('...')
#21 {main} in /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Http/Request.php on line 20
..
In Request.php line 20:
During inheritance of ArrayAccess: Uncaught ErrorException: Return type of
Illuminate\Http\Request::offsetExists($offset) should either be compatible
with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWi
llChange] attribute should be used to temporarily suppress the notice in /h
ome/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Http/Requ
est.php:637
Stack trace:
#0 /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Http
/Request.php(20): Illuminate\Foundation\Bootstrap\HandleExceptions->handleE
rror()
#1 /home/runner/work/baum/baum/vendor/composer/ClassLoader.php(578): includ
e('...')
#2 /home/runner/work/baum/baum/vendor/composer/ClassLoader.php(432): Compos
er\Autoload\ClassLoader::Composer\Autoload{closure}()
#3 /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Foun
dation/Bootstrap/SetRequestForConsole.php(31): Composer\Autoload\ClassLoade
r->loadClass()
#4 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns
/CreatesApplication.php(332): Illuminate\Foundation\Bootstrap\SetRequestFor
Console->bootstrap()
#5 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns
/CreatesApplication.php(223): Orchestra\Testbench\TestCase->resolveApplicat
ionBootstrappers()
#6 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/TestCase
.php(73): Orchestra\Testbench\TestCase->createApplication()
#7 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns
/Testing.php(79): Orchestra\Testbench\TestCase->refreshApplication()
#8 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/TestCase
.php(41): Orchestra\Testbench\TestCase->setUpTheTestEnvironment()
#9 /home/runner/work/baum/baum/tests/Baseline/UnitAbstract.php(14): Orchest
ra\Testbench\TestCase->setUp()
#10 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestCa
se.php(1147): Baum\Tests\Baseline\UnitAbstract->setUp()
#11 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestRe
sult.php(728): PHPUnit\Framework\TestCase->runBare()
#12 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestCa
se.php(904): PHPUnit\Framework\TestResult->run()
#13 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSu
ite.php(675): PHPUnit\Framework\TestCase->run()
#14 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSu
ite.php(675): PHPUnit\Framework\TestSuite->run()
#15 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSu
ite.php(675): PHPUnit\Framework\TestSuite->run()
#16 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/TestRunne
r.php(653): PHPUnit\Framework\TestSuite->run()
#17 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/Command.p
hp(144): PHPUnit\TextUI\TestRunner->run()
#18 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/Command.p
hp(97): PHPUnit\TextUI\Command->run()
#19 /home/runner/work/baum/baum/vendor/phpunit/phpunit/phpunit(98): PHPUnit
\TextUI\Command::main()
#20 /home/runner/work/baum/baum/vendor/bin/phpunit(123): include('...')
#21 {main}

@bkintanar our development team is currently working on some internal projects and will allocate time to this prior to php 8's support being fully dropped later this year.
That being said we would appreciate any work put towards this in the mean time.

@bkintanar I just approved and ran the github actions checks and they have failed, let me know if you need any help with that and I'll see if we can get some development time allocated internally.

@foresight-developers I've tested it locally with 7.4, 8.0, and 8.1 and I've updated my PR. Can you approve again please?

@bkintanar we can update the github actions test to ignore that warning I think, we will look into that shortly


Preserve Project.toml formatting and/or format long authors lists in Project.toml nicer

Our package has several authors, and for various reasons I prefer to format them in the Project.toml so that each person is on their own line (e.g. it increases visibility of the names when people look at it).
Unfortunately, CompatHelper destroys this. Example from https://github.com/oscar-system/Oscar.jl/pull/133:
authors = [
  "Claus Fieker<EMAIL_ADDRESS>  "Giovanni De Franceschi<EMAIL_ADDRESS>  "Johannes Schmitt<EMAIL_ADDRESS>  "Max Horn<EMAIL_ADDRESS>  "William Hart<EMAIL_ADDRESS>  ]

is changed to
authors = ["Claus Fieker<EMAIL_ADDRESS>"Giovanni De Franceschi<EMAIL_ADDRESS>"Johannes Schmitt<EMAIL_ADDRESS>"Max Horn<EMAIL_ADDRESS>"William Hart<EMAIL_ADDRESS>
Usually preserving existing formatting is fiddly (it means one can't use a standard TOML parser), but perhaps at least a way to serialize this field nicer, i.e. if the number of authors exceeds a fixed threshold (say 1 or 2) then the author names are listed each on a separate line?

Note that @KristofferC is working on a rewritten TOML parser/writer and this could perhaps be improved.

I think this needs to be fixed upstream in the TOML stdlib.


[Feat. request] Gamepad input C# script for player movement

Could you guys please add bluetooth gamepad input handling script to player controller (left thumb stick would move player with constant speed forward/back and strafe left/right; with speed multiplier) ?
I tried messing with it but there are no training materials on the subject online :(
I am using http://www.amazon.com/BEBONCOOL-Wireless-Bluetooth-Controller-Gamepad/dp/B00UJC2KW0/ref=sr_1_4?ie=UTF8&qid=1443372009 and I got it working with Gear VR on desktop (Editor) and on mobile. Although Oculus provides gamepad input script. All I had to do was figuring out the axes and variable(?) to teak in the Unity's input manager.
Thanks beforehand.

It's a bit out of scope for the Cardboard SDK right now, so I don't have any idea when this would happen.  I found a nice rundown here:
https://forums.oculus.com/viewtopic.php?t=18509#p234874
That talks about how to get your Bluetooth controller working with Unity and Android, using the Oculus code as a starting point.  If you want to get going on this soon, this is the way to go.

Also consider just looking at bluetooth implementations in Unity for gamepads.

Closing as out of scope for Cardboard SDK.


Fixed deprecated import of SafeConfigParser to ConfigParser

SafeConfigParser was deprecated and eventually removed in Python 3. It’s now called ConfigParser in Python 3.

awesome!

I don't know if this project is too old to continue working on, but if there is let me know.


Migrated Prometheus metrics for Kafka

What changed, and why it matters
Migrated Article "Kafka metrics through Prometheus integration"
https://help.aiven.io/en/articles/3298562-kafka-metrics-through-prometheus-integration
Fix #569

I noticed the help label, what help do you need? or how can others help this PR?

I believe the HELP is to get someone with hands on prometheus experience to validate

Exactly what @ftisiot said, I'm not familiar with the integration so it would be nice if someone who had used it could comment

The metrics kafka_consumer_group_* are made available from us but have not been updated to the doc

Hi @minh-hoang-aiven are you still planning to work on this?

Hi @minh-hoang-aiven are you still planning to work on this?

I made a commit last week. Just waiting for a review now

Hi @minh-hoang-aiven, are you done with the editing? I still see some comments open.
Thanks!

Hi @minh-hoang-aiven, are you done with the editing? I still see some comments open.
Thanks!

Let me close this PR and make another PR with the complete doc to clean it up a bit.


weigth

Can you public the weight of your training？

Can you public the weight of your training？

We have updated the weight in ReadMe, Thank you!

3q

Can you public the weight of your training？

We have updated the weight in ReadMe, Thank you!

3q~


Make dir listings order stable

The order of result of Dit.glob/Dir.[] varies depending on the FS. In general, it shouldn't matter, however, in practice it may lead to random-looking crashes across different environments (like macos vs linux etc).

this makes sense


I2S/TDM SLAVE not sync on WS  (IDFGH-8003)

Environment

Development Kit: ESP32-S3-DevKitC-1
Kit version : v1
IDF version : v5.0-dev-4001-g495d35949d & 4.4.1
Build System:   idf.py
Compiler version : (crosstool-NG esp-2022r1-RC1) 11.2.0
Operating System:     Linux and macOS
Using an IDE?: NO
Power Supply:         USB

Problem Description
If I2S/TDM is configured as Slave in full-duplex data played out is not correctly aligned on WS.
Sometimes first channel appear when WS is High, some times when WS is LOW.
Expected Behavior
I2S/TDM slave should recognize channel order and should output data accordingly WS Polarity.
Actual Behavior

1 esp32s3 is Master Clock and transmit data
1 esp32s3 is Slave Clock and receive data and transmit it back.

Both ESP send the same pattern that identify channels.
Frame 1

CH1 : 0x1AAAAA{sample-id}
CH2 : 0x1BBBBB{sample-id}
CH3 : 0x1CCCCC{sample-id}
CH4 : 0x1DDDDD{sample-id}
Frame 2
CH1 : 0x2AAAAA{sample-id}
CH2 : 0x2BBBBB{sample-id}
CH3 : 0x2CCCCC{sample-id}
CH4 : 0x2DDDDD{sample-id}

ES:
0x1AAAAA01
0x1BBBBB01
0x1CCCCC01
0x1DDDDD01
0x2AAAAA00
0x2BBBBB00
0x2CCCCC00
0x2DDDDD00
Master and Slave esp are both configured in the same standard  I2S_TDM_PHILIP.

As you can se from the image below,  data is correctly placed on low WS and respect the configuration

As you can se from the image below,  data placed on high WS and not respect the configuration.

This happen only rebooting the slave.
No overflow are in evidence ( we monitor and print it )
We also monitor interrupt from DMA sent and DMA rec.
These interrupt seem to be not synchronized and the distance between these interrupt differ from different power cycle.
We notice that when this distance is less then X is when the system work properly.
We wait for updated esp32-s3_technical_reference_manual_en for a while.
Now finally v0.8 is released and we have full documentation for I2S.
On page 742 you mention that peripheral can work simultaneously and independently but seem that there is no way to start tx and rx exactly at the same time that could be the root cause of the problem.
Tried also to start peripheral manually to reduce this latency but no way.
I2S0.rx_conf.rx_start = 1;
I2S0.tx_conf.tx_start = 1;

Also resetting hw fifo, restarting gdma channel. No way.
It seem that Slave a full duplex slave mode is not supported.
We have also a lot of doubt about I2S clocking.
In esp32s3 and esp32c3 you provide a MCLK in but common and standard audio clock like 24.576 MHz are not supported because I2S_RX/TX_CLOK in slave mode must be 8 >= bit clock and this kind of master clock never exist in audio application.
I also would like to put in evidence that driver only support 160 MHz clock and that i2s_struct.h mention APLL that is not supported.
uint32_t rx_clk_sel                    :    2;  /*Select I2S Rx module source clock. 0: no clock. 1: APLL. 2: CLK160. 3: I2S_MCLK_in.*/
We Also tried to use PLL_D2_CLOCK ( 240 MHz ) as source with this clock division coeff :
a : 64
b : 61
N : 1
out freq 122880000.000000
tx_clkm_div_x : 0014
tx_clkm_div_y : 0001
tx_clkm_div_z : 0003
tx_clkm_div_yn1 : 0001

and a MI/MO equal to 10 for bit clock division but without good result.
What we are doing wrong ?
How to allow this peripheral to work properly in a low latency ( 1 ms ) full-duplex i2s slave application ?
Thank you in advance.
Steps to reproduce

Download the attached project
Connect master and slave following pinout described in project README
Monitor data output from slave esp32s3

Code to reproduce this issue
tdm_test_idf5.zip

Thank you so much for providing such a detailed investigation! And sorry for the asynchronization in the slave duplex TDM mode.
According to your discription, I suspect that the issue could be caused by the different clock domains of TX and RX channels, because unlike the former chips, the I2S on ESP32-C3 and ESP32-S3 has separate clock domain for the TX and RX channels, which can support TX and RX working at different clock but can also lead to the  asynchronization.
In master duplex mode, we select the 160m PLL clock for TX channel and share the clock to RX channel by setting the bit sig_loopback, actually in the master case, only TX channel is a really master channel who generates the clocks, but the RX channel is forced to act as slave role to sync the clock to the TX channel.
But in slave duplex mode, both TX and RX channel will not generate the clocks, I don't know if the sig_loopback field still take effect. Or, maybe we have to disable the sig_loopback in this case. Currently I can hard to tell if it is a hardware issue or a bug in the driver, I'll look into it.
If you want to try by yourself, here are two suggestions:

Try to disable sig_loopback for slave duplex mode
Try to select mclk_in as the clock source for both TX and RX channel, then input the mclk for the synchronization. But since the driver doesn't support inputting the mclk signal, you may have to calculate the clock divisions by yourself to get the correct BCLK and WS signal.

And as for the clock source, ESP32-C3 and ESP32-S3 do not support APLL, it's a mistake while generating the i2s_struct.h , please take the Technical Reference Manual for the final reference. And it's indeed a hardware limitation that the master clock has to be at least 8 times to the bclk on ESP32, but not sure if it still exists on C3/S3, if the limitation has gone, I'll fix it.

Further investigation shows that the asynchronization is related to the high sample rate. When the sample rate is high(like 96KHz), we must guarantee the internal mclk frequency of slave should be more than 8 times to the bclk. But currently it is fixed to 8 in the driver, will make it changeable in the next bugfix.


Silence dynamo_backend

Silences the warning if dynamo_backend uses the default value when launching a script

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Please fix a conflict in your bundle JS file

In 3.5.x branch you have next file that has conflict.
https://github.com/divio/django-cms/blob/release/3.5.x/cms/static/cms/js/dist/3.5.3/bundle.admin.base.min.js
I use this version for my local development, and found this problem that in Django admin Django CMS Page show no content at all.
Please fix this conflict, even if this version old and not supportable anymore.
Thank you.

OK, I've found a workaround for Django 1.11.x version yo clone the latest release version using git checkout tags/3.5.2. But anyway, it's not god that in your repo you have files with merge conflicts, and they are committed.

@1st this has been fixed in the latest releases of django CMS 3.4-3.7. Thank you for pointing this out!


Proposal: add synonym 'intrauterine fetal demise (IUFD); intrauterine fetal death; stillbirth' for pregnancy disorder with abortive outcome

Hey ontobot! apply:

create exact synonym 'intrauterine fetal demise (IUFD); intrauterine fetal death; stillbirth' for MONDO:0041526

Comment: Demoing auto-generated ontology change requests from the BioPortal application
This request comes from BioPortal user: vendetti

is this an actual request? Or can this be closed?


fix: issue on console params

No that's not quite right, it's just converting BigNumber to Number here. UZyn's suggestion was to first check if the BigNumber is an integer only then convert it to Number

No that's not quite right, it's just converting BigNumber to Number here. UZyn's suggestion was to first check if the BigNumber is an integer only then convert it to Number

gNumber to Number here. UZyn's suggestion was to first check if the BigNumber is an integer only then convert it to Number

It's already handled. The condition is to check if the BN isNaN. If yes, it will return the original params. Otherwise, it will convert it to Number

gNumber to Number here. UZyn's suggestion was to first check if the BigNumber is an integer only then convert it to Number

It's already handled. The condition is to check if the BN isNaN. If yes, it will return the original params. Otherwise, it will convert it to Number

We still want to pass in BigNumber if it's a number, this is for accuracy reasons for commands like sendtoaddress. isNAN still still return false if the BigNumber was something like 1000000.00000123 in which case converting to Number would result in precision loss, we only want to convert if the BigNumber has no decimal places

We still want to pass in BigNumber if it's a number, this is for accuracy reasons for commands like sendtoaddress. isNAN still still return false if the BigNumber was something like 1000000.00000123 in which case converting to Number would result in precision loss, we only want to convert if the BigNumber has no decimal places

We still want to pass in BigNumber if it's a number, this is for accuracy reasons for commands like sendtoaddress. isNAN still still return false if the BigNumber was something like 1000000.00000123 in which case converting to Number would result in precision loss, we only want to convert if the BigNumber has no decimal places

ahhh ok ok my bad. Let me update it

We still want to pass in BigNumber if it's a number, this is for accuracy reasons for commands like sendtoaddress. isNAN still still return false if the BigNumber was something like 1000000.00000123 in which case converting to Number would result in precision loss, we only want to convert if the BigNumber has no decimal places

ahhh ok ok my bad. Let me update it

Updated @monstrobishi

Updated @monstrobishi

Can we use toFixed(8) instead of toString just incase

Can we use toFixed(8) instead of toString just incase

Can we use toFixed(8) instead of toString just incase

Sure give me a sec

Can we use toFixed(8) instead of toString just incase

Sure give me a sec

Updated @monstrobishi. I tested it as well with more than 8 decimal places. It doesn't work with RPC. It should be only 8 decimal places I think

Updated @monstrobishi. I tested it as well with more than 8 decimal places. It doesn't work with RPC. It should be only 8 decimal places I think

Yep that's fine

Yep that's fine

Merging

Merging


[otbn] Specify writes to external CSRs during LOCKED state

(At least) for testing purposes we need to specify what happens when OTBN is in LOCKED state (after it has seen a fatal error) and we see reads from the bus to the CSR nodes.
We have at least two registers which should remain accessible and return useful values even if OTBN is LOCKED: the STATUS register (which indicates that OTBN is locked), and the FATAL_ALERT_CAUSE register, which can be read to determine why OTBN is locked.
What should do we for all other registers?

Read 0, ignore writes
Return a bus error
Hang the bus (return nothing)

I'd go for option (1) to make life easier for software to debug a fatal alert.

@tjaychen @cdgori Any preference from your side?
CC @GregAC @rswarbrick

(1) sounds fine to me, but the implementation might be a bit gnarly for any non-ext registers. Are you imagining a single cycle where we assert de for all the registers to clear and pass them zeros?

(1) seems preferable.  (3) is bad.  If (1) is unworkable / too gnarly for some reason, I'd go for (2).  Though, I think (2) gets into that dynamic error modeling situation we discussed in another issue (?), so best to avoid if we can.

i think as long as the system doesn't respond in a meaningful way, i'm not sure we absolutely have to zero the read path. I am not sure what anyone would gain from it, especially since all the secrets will have been wiped.  The most interesting bit is probably the FATAL_CAUSE (to see what triggered), and that we have to allow anyways.
If we are okay with that as a compromise, we could accomplish what Philipp is suggesting by adding a hardware modulated regwen, which under certain circumstances just blocks off writes.
  Although if we feel strongly about that, we can also add enhance regwen to regwen/regren

I think (I hope?) we are agreed about blocking writes, and it's more "should reads (other than STATUS and FATAL_ALERT_CAUSE) behave consistently with any other memory spaces"
But you are right @tjaychen from a quick look at all the registers I can't see where anyone gains anything from reading them, so maybe not needed except for consistency.

I'd note we already force returning 0s for dmem/imem reads after we've seen an illegal bus access (where Ibex tries to access them when OTBN is running). Though oddly seems the RTL still allows writes after this!
I think we should definitely return 0s on reads to imem/dmem after OTBN is locked and this is trivial to implement.
Perhaps you could argue INSN_CNT gives you something interesting (maybe you're aiming to inject a fault at some particular OTBN instruction and this helps you focus on it?) and is also easy to give 0 on reads when OTBN is locked as the value is provided by OTBN.
For other registers still allowing reads seems fine and avoids some slight trickyness with implementation (as @rswarbrick it's a pain for non-ext registers).
Spec wise we could give a table of registers that return 0 when OTBN is locked and others that still allow reads and state all writes are ignored.

That sounds good to me.


Add animated backgrounds

For example the ribbon ui on retroarch: https://github.com/libretro/RetroArch

Closing without resolution. This issue either affects too few users or there are too many issues with higher impact to be working on. It is possible to re-open or re-visit this issue at a later time. If you feel this issue is important, please give a thumbs-up reaction to the first post. You may track this issue from the pinned meta-tracker at the top of the issues home page.


[arm build CppCodeGen] Fixed GetCodeForReadyToRunHeader for 32-bits

@sergign60,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@jkotas @Dmitri-Botcharnikov

https://github.com/dotnet/corert/issues/2780


python27Packages.dash-renderer: 1.5.0 -> 1.5.1

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python2.7-dash_renderer/versions.
meta.description for python27Packages.dash-renderer is: "Renderer for the Dash framework"
meta.homepage for python27Packages.dash-renderer is: "https://dash.plot.ly/"
meta.changelog for python27Packages.dash-renderer is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.5.1 with grep in /nix/store/jk4590pgiccag4cz39kym0m5q67nw7dw-python2.7-dash_renderer-1.5.1

directory tree listing: https://gist.github.com/0347ec2bbc727f78e1d70d833afba223

du listing: https://gist.github.com/121c167cc9085d97896c67de7b34868d

Rebuild report (if merged into master) (click to expand)

24 total rebuild path(s)

6 package rebuild(s)

6 x86_64-linux rebuild(s)
6 i686-linux rebuild(s)
6 x86_64-darwin rebuild(s)
6 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python27Packages.dash
python27Packages.dash-renderer
python37Packages.dash
python37Packages.dash-renderer
python38Packages.dash
python38Packages.dash-renderer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jk4590pgiccag4cz39kym0m5q67nw7dw-python2.7-dash_renderer-1.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python27Packages.dash-renderer https://github.com/r-ryantm/nixpkgs/archive/34fd21ef00e4a1952112012e7ec455c88fdf614f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jk4590pgiccag4cz39kym0m5q67nw7dw-python2.7-dash_renderer-1.5.1
ls -la /nix/store/jk4590pgiccag4cz39kym0m5q67nw7dw-python2.7-dash_renderer-1.5.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

3 packages failed to build:

python27Packages.dash
python37Packages.dash
python38Packages.dash

3 packages built:

python27Packages.dash-renderer
python37Packages.dash-renderer
python38Packages.dash-renderer

Maintainer pings
cc @antoinerg for testing.

dash packages should be updated as a set


Can't get new certificates

I was running two separate web containers for a couple of weeks now, each with its own cert and am adding a third, but LE won't issue a new cert, saying that I have been issued too many. Looking at their rate limits, this shouldn't be happening. Is it possible one of my certs was getting created anew each time? I realize I'm going to have to wait a week before I try to get new certs, but I'd appreciate some insight.
Domains redacted out, but I was running two containers (one for xxx.net and one for library.xxx.net). When I try to load the new site (listed as handfuls.xxx.net), it is trying to use the base domain cert, probably because it is erroring when trying to register the new cert?
2017/07/19 16:45:35 Generated '/app/letsencrypt_service_data' from 15 containers
2017/07/19 16:45:35 Running '/app/update_certs'
2017/07/19 16:45:35 Watching docker events
2017/07/19 16:45:36 Contents of /app/letsencrypt_service_data did not change. Skipping notification '/app/update_certs'
2017-07-19 16:45:37,022:INFO:simp_le:1384: Certificates already exist and renewal is not necessary, exiting with status code 1.
2017-07-19 16:45:37,843:INFO:simp_le:1213: Generating new account key
2017-07-19 16:45:41,628:INFO:simp_le:1306: library.xxx.net was successfully self-verified
2017-07-19 16:45:42,327:INFO:simp_le:1314: Generating new certificate private key
ACME server returned an error: urn:acme:error:rateLimited :: There were too many requests of a given type :: Error creating new cert :: too many certificates already issued for exact set of domains: library.xxx.net

Debugging tips: -v improves output verbosity. Help is available under --help.
2017-07-19 16:45:45,635:INFO:simp_le:1384: Certificates already exist and renewal is not necessary, exiting with status code 1.
2017/07/19 16:46:49 Received signal: terminated
2017/07/19 16:46:49 Received signal: terminated
2017/07/19 16:47:10 Contents of /app/letsencrypt_service_data did not change. Skipping notification '/app/update_certs'
2017/07/19 16:47:10 Watching docker events
2017/07/19 16:47:10 Contents of /app/letsencrypt_service_data did not change. Skipping notification '/app/update_certs'
2017-07-19 16:47:11,497:INFO:simp_le:1384: Certificates already exist and renewal is not necessary, exiting with status code 1.
2017-07-19 16:47:12,299:INFO:simp_le:1213: Generating new account key
ACME server returned an error: urn:acme:error:rateLimited :: There were too many requests of a given type :: Error creating new registration :: too many registrations for this IP

Debugging tips: -v improves output verbosity. Help is available under --help.
2017-07-19 16:47:14,930:INFO:simp_le:1384: Certificates already exist and renewal is not necessary, exiting with status code 1.
2017/07/19 16:52:02 Received event die for container 5ce6e400e9c2
2017/07/19 16:52:02 Received event die for container 10fc5a6f0403
2017/07/19 16:52:02 Received event stop for container 5ce6e400e9c2
2017/07/19 16:52:02 Received event stop for container 10fc5a6f0403
2017/07/19 16:52:03 Received event start for container 967bdce68a05
2017/07/19 16:52:03 Received event start for container 180d307c4b5f
2017/07/19 16:52:12 Received event die for container 174f993bdaf8
2017/07/19 16:52:12 Received event stop for container 174f993bdaf8
2017/07/19 16:52:13 Received event start for container 74aaa2d5281c
2017/07/19 16:52:28 Debounce minTimer fired
2017/07/19 16:52:28 Generated '/app/letsencrypt_service_data' from 15 containers
2017/07/19 16:52:28 Running '/app/update_certs'
2017-07-19 16:52:32,635:ERROR:urllib3.connection:360: Certificate did not match expected hostname: handfuls.xxx.net. Certificate: {'subjectAltName': [('DNS', 'xxx.net')], 'subject': ((('commonName', u'xxx.net'),),)}
2017-07-19 16:52:32,639:ERROR:acme.challenges:311: Unable to reach http://handfuls.xxx.net/.well-known/acme-challenge/DKG3qeOtQWpOpmQK94q_82tgKlBbSxjM-Ujozbqab4Y: hostname 'handfuls.xxx.net' doesn't match 'xxx.net'
2017-07-19 16:52:32,640:WARNING:simp_le:1304: handfuls.xxx.net was not successfully self-verified. CA is likely to fail as well!
2017-07-19 16:52:33,691:INFO:simp_le:1306: xxx.net was successfully self-verified
2017-07-19 16:52:34,927:ERROR:urllib3.connection:360: Certificate did not match expected hostname: library.xxx.net. Certificate: {'subjectAltName': [('DNS', 'xxx.net')], 'subject': ((('commonName', u'xxx.net'),),)}
2017-07-19 16:52:34,931:ERROR:acme.challenges:311: Unable to reach http://library.xxx.net/.well-known/acme-challenge/1nnWT7TrGfD8xMQu5NkIPX7UiR31NKr8fu_BLlYhLK0: hostname 'library.xxx.net' doesn't match 'xxx.net'
2017-07-19 16:52:34,931:WARNING:simp_le:1304: library.xxx.net was not successfully self-verified. CA is likely to fail as well!
2017-07-19 16:52:35,892:INFO:simp_le:1314: Generating new certificate private key
2017-07-19 16:52:38,313:INFO:simp_le:393: Saving key.pem
2017-07-19 16:52:38,314:INFO:simp_le:393: Saving fullchain.pem
2017-07-19 16:52:38,315:INFO:simp_le:393: Saving cert.pem
2017-07-19 16:52:39,154:INFO:simp_le:1384: Certificates already exist and renewal is not necessary, exiting with status code 1.
2017-07-19 16:52:39,973:INFO:simp_le:1384: Certificates already exist and renewal is not necessary, exiting with status code 1.
2017/07/19 16:53:50 Received event die for container 967bdce68a05
2017/07/19 16:53:50 Received event die for container 180d307c4b5f
2017/07/19 16:53:51 Received event stop for container 967bdce68a05
2017/07/19 16:53:51 Received event stop for container 180d307c4b5f
2017/07/19 16:53:51 Received event start for container c6ffdb269c0b
2017/07/19 16:53:52 Received event start for container 8e914c706a30
2017/07/19 16:54:00 Received event die for container 74aaa2d5281c
2017/07/19 16:54:01 Received event stop for container 74aaa2d5281c
2017/07/19 16:54:02 Received event start for container 17f145ae360d
2017/07/19 16:54:17 Debounce minTimer fired
2017/07/19 16:54:17 Generated '/app/letsencrypt_service_data' from 15 containers
2017/07/19 16:54:17 Running '/app/update_certs'
2017-07-19 16:54:18,164:INFO:simp_le:1213: Generating new account key
ACME server returned an error: urn:acme:error:rateLimited :: There were too many requests of a given type :: Error creating new registration :: too many registrations for this IP

Debugging tips: -v improves output verbosity. Help is available under --help.
2017-07-19 16:54:21,114:INFO:simp_le:1213: Generating new account key
ACME server returned an error: urn:acme:error:rateLimited :: There were too many requests of a given type :: Error creating new registration :: too many registrations for this IP

Debugging tips: -v improves output verbosity. Help is available under --help.
2017-07-19 16:54:24,686:INFO:simp_le:1306: xxx.net was successfully self-verified
2017-07-19 16:54:25,176:INFO:simp_le:1314: Generating new certificate private key
2017-07-19 16:54:26,759:INFO:simp_le:393: Saving key.pem
2017-07-19 16:54:26,759:INFO:simp_le:393: Saving fullchain.pem
2017-07-19 16:54:26,760:INFO:simp_le:393: Saving cert.pem

Oh and I have tried removing and restarting everything, no luck

I checked and all three certs are coming back as issued, Right now I can get to the main page and the library page fine, but handfuls gives me a NET::ERR_CERT_COMMON_NAME_INVALID, with the cert saying it id for xxx.net instead of handfuls.xxx.net. Just ried it on a completely different machine and browser and it does the same.
I checked and the nginx conf is setup for the correct cert.

Can you post the commands / docker-compose file you are using ?
Does crt.sh shows that some certificates were issued multiple times per week ? (There is a delay before a newly issued certificate shows up there, can't say how much for sure, a few days at most)

Yes, crt.sh is showing certs are getting issued multiple times per week/day, showing the following:

Compose below:
version: '3'
services:
  calibre-web:
    image: technosoft2000/calibre-web
    container_name: calibre-web
    volumes:
      - "/media/Storage/Calibre:/books:rw"
      - "/var/calibre/metadata.db:/books/metadata.db:rw"
    ports:
      - "8083:8083"
    environment:
      - SET_CONTAINER_TIMEZONE=true
      - CONTAINER_TIMEZONE=America/New_York
      - PGID=1000
      - PUID=1000
      - VIRTUAL_HOST=library.xxx.net
      - VIRTUAL_PORT=8083
      - LETSENCRYPT_HOST=library.xxx.net
      -<EMAIL_ADDRESS>    depends_on:
      - proxy
      - letsencrypt
    networks:
      - proxynet

  proxy:
    image: jwilder/nginx-proxy
    container_name: proxy
    networks:
      - proxynet
    ports:
      - "<IP_ADDRESS>:80:80"
      - "<IP_ADDRESS>:443:443"
    labels:
      - "com.github.jrcs.letsencrypt_nginx_proxy_companion.nginx_proxy=true"
    volumes:
      - /var/nginx/certs:/etc/nginx/certs:ro
      - /var/run/docker.sock:/tmp/docker.sock:ro
      - /var/nginx/vhost.d:/etc/nginx/vhost.d
      - /var/nginx/html:/usr/share/nginx/html
    environment:
      - DEFAULT_HOST=xxx.net

  letsencrypt:
    image: jrcs/letsencrypt-nginx-proxy-companion
    container_name: letsencrypt
    networks:
      - proxynet
    volumes:
      - /var/nginx/certs:/etc/nginx/certs:rw
      - /var/run/docker.sock:/var/run/docker.sock:ro
      - /var/run/docker.sock:/tmp/docker.sock:ro
      - /var/nginx/vhost.d:/etc/nginx/vhost.d
      - /var/nginx/html:/usr/share/nginx/html
    depends_on:
      - proxy
    # environment:
    #   - DEBUG=true

  www_main:
    image: nginx:alpine
    container_name: www_main
    networks:
      - proxynet
    volumes:
      - ../www:/usr/share/nginx/html
    environment:
      - VIRTUAL_HOST=xxx.net
      - LETSENCRYPT_HOST=xxx.net
      -<EMAIL_ADDRESS>    depends_on:
      - proxy
      - letsencrypt

  handfuls:
    image: drupal:7
    container_name: handfuls
    networks:
      - proxynet
    volumes:
      - /var/handfuls/modules:/var/www/html/modules
      - /var/handfuls/profiles:/var/www/html/profiles
      - /var/handfuls/themes:/var/www/html/themes
      - /var/handfuls/sites:/var/www/html/sites
    environment:
      - VIRTUAL_HOST=handfuls.xxx.net
      - LETSENCRYPT_HOST=handfuls.xxx.net
      -<EMAIL_ADDRESS>    depends_on:
      - proxy
    links:
      - mariadb

networks:
  proxynet:
    external:
      name: nginx-proxy

I see a bunch of strange stuff / probable misconfiguration:

ports 8083:8083 on the calibre-web service. That bind the container's port to a public port, potentially bypassing the proxy. Any specific reason of doing this ?
the le companion require exposed ports on proxyed containers : https://github.com/JrCs/docker-letsencrypt-nginx-proxy-companion#usage (last paragraph right before separate containers)
the local docker socket bound to two different places on the letsencrypt container. It should only be bound to /var/run/docker.sock

Still no clue why your certs got generated multiple times a day. Did you wipe the /var/nginx/certs between tests ?

The port exposure was for testing purposes, to allow me to access it on my local network and make sure the service was running. It wasn't affecting the proxy when I was running with it, external traffic all went through the proxy. The Drupal7 container is based on the official PHP7 Apache container and exposes Port 80.
I did wipe the certs once when I was setting up the initial two containers, since I had them setup as a SAN, but that was not working across multiple containers, so I wiped and went to one cert per container. I haven't wiped them for this round of testing and spinning up this latest container.

New development: Library has stopped working now

You really need to expose port 80 in your docker-compose file for each docker container you're running. Should do like this:
`version: '3'
services:
calibre-web:
image: technosoft2000/calibre-web
container_name: calibre-web
volumes:
- "/media/Storage/Calibre:/books:rw"
- "/var/calibre/metadata.db:/books/metadata.db:rw"
ports:
- "8083:8083"
expose:
- "80"
environment:
- SET_CONTAINER_TIMEZONE=true
- CONTAINER_TIMEZONE=America/New_York
- PGID=1000
- PUID=1000
- VIRTUAL_HOST=library.xxx.net
- VIRTUAL_PORT=8083
- LETSENCRYPT_HOST=library.xxx.net
-<EMAIL_ADDRESS>depends_on:
- proxy
- letsencrypt
networks:
- proxynet
proxy:
image: jwilder/nginx-proxy
container_name: proxy
networks:
- proxynet
ports:
- "<IP_ADDRESS>:80:80"
- "<IP_ADDRESS>:443:443"
labels:
- "com.github.jrcs.letsencrypt_nginx_proxy_companion.nginx_proxy=true"
volumes:
- /var/nginx/certs:/etc/nginx/certs:ro
- /var/run/docker.sock:/tmp/docker.sock:ro
- /var/nginx/vhost.d:/etc/nginx/vhost.d
- /var/nginx/html:/usr/share/nginx/html
environment:
- DEFAULT_HOST=xxx.net
letsencrypt:
image: jrcs/letsencrypt-nginx-proxy-companion
container_name: letsencrypt
networks:
- proxynet
volumes:
- /var/nginx/certs:/etc/nginx/certs:rw
- /var/run/docker.sock:/var/run/docker.sock:ro
- /var/run/docker.sock:/tmp/docker.sock:ro
- /var/nginx/vhost.d:/etc/nginx/vhost.d
- /var/nginx/html:/usr/share/nginx/html
depends_on:
- proxy
# environment:
#   - DEBUG=true
www_main:
image: nginx:alpine
container_name: www_main
networks:
- proxynet
volumes:
- ../www:/usr/share/nginx/html
expose:
- "80"
environment:
- VIRTUAL_HOST=xxx.net
- LETSENCRYPT_HOST=xxx.net
-<EMAIL_ADDRESS>depends_on:
- proxy
- letsencrypt
handfuls:
image: drupal:7
container_name: handfuls
networks:
- proxynet
volumes:
- /var/handfuls/modules:/var/www/html/modules
- /var/handfuls/profiles:/var/www/html/profiles
- /var/handfuls/themes:/var/www/html/themes
- /var/handfuls/sites:/var/www/html/sites
expose:
- "80"
environment:
- VIRTUAL_HOST=handfuls.xxx.net
- LETSENCRYPT_HOST=handfuls.xxx.net
-<EMAIL_ADDRESS>depends_on:
- proxy
links:
- mariadb
networks:
proxynet:
external:
name: nginx-proxy`

The ports actually had no bearing on this issue. Turned out to be a misconfiguration in the nginx files that was killing the linkup. I have updated the containers since then and it seems to have resolved the issues I was having.
Also, what would be the point of exposing port 80 on a container that has no services running on that port? Calibre-web doesn't have anything on port 80; it is a python script and only uses port 8083. Opening port 80 seems to me to have more potential to cause issues than resolve them, since if nginx-proxy looks on that port it will return an http:500 error.

@ErroneousBosch
Can you share how you changed the Nginx misconfiguration issue? I am having a similar problem. :)

@ErroneousBosch you're right, if there is no application on that port exposing the port is useless.
I've had a very similar issue a few weeks ago. It looks like the certbot does only retrieve certificates if there is an application on port 80. A few containers that I'm running do not have applications on port 80 but I still needed the certificates. So I created a simple httpd-container that has the VIRTUAL_HOST-variable set to all the hosts that do not export port 80 by their own. @dasmedium maybe this might help you?

@githtz Thanks for the fix. This wasn't needed in older versions. I suppose this way auto-renewing doesn't work and you'd have to start the httpd-container once in a while to auto renew. Correct?

I don't know how @githtz came to the conclusion that letsencrypt-nginx-proxy-companion only retrieves certificates if there is an application on port 80, I never had any issue proxying lots of apps that don't expose and/or listen on port 80 at all (chronograf, gitlab, gogs, grafana, kibana, portainer to name a few) and more importantly there is nothing in the code that could make the container behave this way.

@buchdag me neither. Also used gitlab, graphana etc. But in the most recent version it doesn't seem to work anymore for apps on different ports.

I'm running the latest version on several hosts with non port 80 containers and zero issues.
I Just forced a certificate renew on two of them without issue either.

@buchdag I came to the conclusion since I didn't get any certs if port 80 was not exposed in either the docker-compose file or the run command of the container, but my conclusion might be faulty of course. I'll keep it a try without exposal and report my results.

Closing due to age and no new comment for more than 90 days.


Issues template change

Description
Proposing that we use github labels for categorizing issues. It is an inbuilt filter on the site. For eg - just clicking on the documentation label pulls up all the documentation issues. We can even add custom labels - like droidlet hack session to file away issues for the hack session.

Fixes # (issue)
Type of change
Please check the options that are relevant.

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] Proposes a change (non-breaking change that isn't necessarily a bug)
[ ] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[x] Documentation only change

Type of requested review

[ ] I want a thorough review of the implementation.
[x] I want a high level review.
[ ] I want a deep design review.

fyi, labels can only be tagged by people who have write or triage permissions -- so any one among us on the team

fyi, labels can only be tagged by people who have write or triage permissions -- so any one among us on the team

Didn't know that. Won't land this PR then since the text change I made on the issues template here won't make sense for external users. We can just get in the habit of triaging with labels.

Nice! Request: let's add a high pri label? Can be used in conjunction with other ones.

Yes. Feel free to add labels. Each issue can also have multiple labels.


Add declarations for Node's http.Agent

Summary:
Add the Agent class to the http module.
https://nodejs.org/api/http.html#http_class_http_agent

Closes #3124
Closes #1815

Ping. Anything else I need to do to get this through? First time contributor - not sure what the process is beyond signing the CLA.

hey, would be great to get this merged!!


Manage per-project keychain?

Currently this plugin requires that everybody on the team has all the necessary keys on their personal keychain.
I wonder if it would be a good decision to support a dedicated, per-project keychain (in vendor/composer?) that would be managed by the plugin.
So, maybe the root project could configure via extra sections in composer.json a vendor/* or vendor/package-to-KeyID(s) mapping?
At startup, this plugin would have to make sure all necessary keys are available or try to fetch them.
Then, when downloading, make sure we verify against the configured key(s) only.
That way,

I don’t clutter my personal keychain with keys necessary for projects and don’t have to juggle with different keychains either.
Everybody on the team will have the necessary keys without further ado
The decision to trust a particular key would be traceable to the commit adding it

Cons:
Not everybody might agree which keys are trustworthy.

The idea here would be to use extra.keybase-trusted-usernames to create a
local keychain
On Sun, Dec 29, 2019, 22:17 Matthias Pigulla<EMAIL_ADDRESS>wrote:

Currently this plugin requires that everybody on the team has all the
necessary keys on their personal keychain.
I wonder if it would be a good decision to support a dedicated,
per-project keychain (in vendor/composer?) that would be managed by the
plugin.
So, maybe the root project could configure via extra sections in
composer.json a vendor/* or vendor/package-to-KeyID(s) mapping?
At startup, this plugin would have to make sure all necessary keys are
available or try to fetch them.
Then, when downloading, make sure we verify against the configured key(s)
only.
That way,

I don’t clutter my personal keychain with keys necessary for
projects and don’t have to juggle with different keychains either.
Everybody on the team will have the necessary keys without further
ado
The decision to trust a particular key would be traceable to the
commit adding it

Cons:
Not everybody might agree which keys are trustworthy.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Roave/composer-gpg-verify/issues/10?email_source=notifications&email_token=AABFVEGIBVL53MZBMDCTLCDQ3EHX5A5CNFSM4KBCUOD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDGIX5A,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABFVEAKOWDYRPSU2NV5R2TQ3EHX5ANCNFSM4KBCUODQ
.


🎉 Add blackfire extenstion

This PR adds blackfire to all operating systems with php 5.6+

[ ] Readme updated
[x] Linux install tested
[ ] Windows install tested
[x] Osx install tested

In case this PR introduced TypeScript/JavaScript code changes:

[x] I have written test cases for the changes in this pull request
[x] I have run npm run format before the commit.
[x] I have run npm run lint before the commit.
[x] I have run npm run release before the commit.
[x] npm test returns with no unit test errors.

Fixes #191

@shivammathur could you please have a look at the windows support of the installation? I'm not familiar with the powershell scripting and I don't have a windows machine available to test the installation. So it would require a lot of trial and error for me to get this working. I think the script should work as is now.

@jaapio Great work 🎉. Please squash the commits into a single commit or one commit per OS. I will merge this and refactor/fix if required.

I think it is ready now. Windows support is still failing. That would require some attention. But this is all I can do right now. Please let me know if I need to fix/update something before you can merge this.

Please remove blackfire from the workflow, so that builds pass. I will merge this now and later fix the windows script.

I dropped the commit.


TypeError: decode() got an unexpected keyword argument 'min_p'

Hi, I am running this repo, but I get the following error. Does anyone know how to fix this? And what is the meaning of 'min_p'? Thanks!:
(base) seelur@seelur-B560M-HDV-A-R2-0:~/git/mamba$ python benchmarks/benchmark_generation_mamba_simple.py --model-name "state-spaces/mamba-790m" --prompt "My cat wrote all this CUDA code for a new language model and" --topp 0.9 --temperature 0.7 --repetition-penalty 1.2
Loading model state-spaces/mamba-790m
Number of parameters: 793204224
Traceback (most recent call last):
File "/home/seelur/git/mamba/benchmarks/benchmark_generation_mamba_simple.py", line 85, in
out = fn()
^^^^
File "/home/seelur/git/mamba/benchmarks/benchmark_generation_mamba_simple.py", line 59, in
fn = lambda: model.generate(
^^^^^^^^^^^^^^^
File "/home/seelur/anaconda3/lib/python3.11/site-packages/mamba_ssm/utils/generation.py", line 244, in generate
output = decode(
^^^^^^^
File "/home/seelur/anaconda3/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
TypeError: decode() got an unexpected keyword argument 'min_p'
My environment:
nvcc V12.2.140
torch 2.1.0
Transformers 4.32.1

I'm getting the same problem.  I went straight from pip install mamba-ssm and in generate I've added min_p as an argument.  I'm getting the same error.  This was in a brand new colab env.

It works now.  Thanks for the fix.


[enhancement] support for dynamically set "desired capabilities" and "cookies"

@lucianopuccio I don't see any option to set an enhancement label for this issue via the regular issue input from github, so that is why I used [enhancement] in the title.
Looking at the great Zalenium grid container (https://zalando.github.io/zalenium/) and some other remote browser environments,  it would be great if Golem would support the following features:

Setting up a browser instance with dynamically set "desired capabilities" per test case, enabling:
-- Custom browser versions / platforms for remote browser tests.
-- Naming of recorded test video's within Zalenium in case the testcase name is set via 'desired capabilities'(see referenced website -test name- section).

Set dynamic cookies during tests.
-- In case of Zalenium this would enable referenced test steps in the recorded Video's (see referenced website -Referencing test steps in the recorded video- section-)

@lucianopuccio I have tried the existing functionality as available in version 0.4.5 available via pypi.
There seems to be a bug causing golem to not start tests when processing using custom browser settings.
I managed to isolate the bug to source file (golem/core/settings_manager.py function get_remote_browsers line 168)
This function should return a dictionary with custom remote browsers and its related settings. Changing the code to return a dictionary will fix the issue for running test cases with custom settings, however breaks the browser input suggestions in the run suites GUI (which actually requires the list)
def get_remote_browsers(settings):
#    remote_browsers = list(settings['remote_browsers'].keys())
    remote_browsers = dict(settings['remote_browsers'])
    return remote_browsers

I see in the current github source you reworked some of this code, I do however suspect the same bug still exists though.

Sorry for the delay. Indeed there was an issue with get_remote_browsers. It should be fixed now, the fix is not yet in pypi though.
Back to the original issue, I added an action to add capabilities from inside a test, check: https://github.com/lucianopuccio/golem/commit/88ac74a35de87cff7aa726fa1f1ef802e18eff22
The implementation would be something like this:
def setup(data):
    set_browser_capability('name', 'Testcase 01 - Label for the zalenium video')

def test(data):
    # ...

Cookie management remains to be seen but it could also be implemented by actions.

Thanks for the update and code changes! I will give this a try later today and provide feedback.
To double check: The "def setup" is invoked before the browser session is started ?

@lucianopuccio I have tested the new set_browser_capability action and it seems to work like a charm with custom browsers, many thanks for implementing this feature

Question, are you aware on some odd behaviour regarding threading ? (if not I will open a new issue)
Examples:

Setting up multiple browsers in a test suite will crash the python process with the following message: may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug
The same error message is observed when: Having tests with multiple data rows like:

@lucianopuccio In the previous post I report forking issues with the current source implementation. It seems these errors are related to the use of macos high sierra and not a bug within golem. Running the latest code on my linux test environment does not show any problems
On macos high sierra the following work around can be used before starting golem
Using the following workaround on page solves the issue.

@r-roos I'm glad that it worked ok. I created an action to add cookies (https://golem-framework.readthedocs.io/en/latest/golem-actions.html#add-cookie-cookie-dict). It uses the selenium API which has some drawbacks. It is available in 0.4.6. Let me know if it solves the original issue.
In regards to the macOS issue, I created #96

@lucianopuccio I ran some tests with the new cookie implementation, looking good! I think we can consider this topic closed and implemented. Many thanks for creating these new actions.
Regarding the macOS issue we can further discuss this in the bug you created.
One last item: You released 0.4.6 today which does not include some fixes which are in the pull request list, which causes breaking issues (at least breaking in my view):

Test data from csv files are always single quoted strings (including special types like dict / strings) caused by a missing import
Pages which are located in subfolders cannot be imported when running test cases.

both issues are fixed with PR: https://github.com/lucianopuccio/golem/pull/95

Closing this topic as it is implemented


Some tweaks aren't working / minor issues

I followed all the steps to the best of my ability, but it still just doesn't look right.
Full screen:

And the hovered tab bar just cuts off at the top and is transparent:

And some tweaks and design elements like the rounded corners aren't working either, nor can I actually add the Userchrome toggle to the toolbar, clicking on the extensions button brings me straight to settings in a new tab.
Anyone here know what's going on?

Hello! I was experiencing the same issues (aside from the userchrome toggle and extensions button issues you had- mine were fine), but thought maybe it was because I was on 126 and not 123.
However, I did a complete reinstall of everything after downgrading to 123, and all of the issues I had still persisted. (No rounded corners, side bar being cut off weird, etc) so I don't believe that is the issue. Hopefully that info helps the author

Update: I figured it out, this is what the author was talking about when they said "ArcWTF will clash with the default Firefox system theme, dark themes that have light toolbar/light URL bar, and light themes with dark toolbar/dark URL bar."
The default theme my firefox is on is "system auto", switching to dark directly fixed everything. Now to play around with choosing my own colors!


Support for Scatter Plots

After #1373 is merged, we should add support for ScatterPlots as they can be commonly used in any learning task.

Depends on #1544.


Manage merge keys of top-level lists in a more consistent way

In the current model, all types of commands are expected to have an id that is mainly the key of the command in the command list.
It is defined this way:
commands:
  - exec:
      id: "commandId"  <------ the key of the given command in the list of commands

Since finally the id field is common to all types of command and is the key that will be used to identify a command, especially when merging commands between a parent and the current devfile, it seems it might make sense to bring it one level up, like this:
commands:
  - id: "commandId"
    exec:
      ....

The same stands for components: until now all types of components have a name field that is used as a key for identifying a component, especially during parent or plugin overriding. It is mandatory for most component types, and optional for plugins, in which case it is calculated from the definition of the plugin itself (based on id, registry url, etc ...).
Instead of:
components:
  - container:
      name: "tooling"

we would have
components:
  - name: "tooling"
    container:
      ....

In this case, though, the name field can only be made either required or optional for all the component types, and not per-component-type. We should then probably make it mandatory for the Kubernetes CR, and optional for devfiles (but for all components). This would lead to loosing some schema validation.
Of course, deciding that in any case we require a name for a component (even a plugin) would make the whole more consistent and schema-validated, but less user-friendly I admit.
So this proposal surely requires further discussion. But it could be interesting to decide upon this before the Devfile 2.0.0 release.
Related content: https://github.com/devfile/kubernetes-api/pull/98#user-content-keys

In this case, though, the name field can only be made either required or optional for all the component types, and not per-component-type. We should then probably make it mandatory for the Kubernetes CR, and optional for devfiles (but for all components). This would lead to loosing some schema validation.

Of course, deciding that in any case we require a name for a component (even a plugin) would make the whole more consistent and schema-validated, but less user-friendly I admit.

I think that might make it confusing. If there any other disadvantage in making it required for devfiles?
I would say that consistency would make it more user-friendly.

One downside that I can see in this is that it would make it syntactically possible to define multiple components or command under one name :-( I'm not sure if we can check for this on JSON Schema level

It is not possible, in fact, since exec / apply are part of a union. In each case a K8S unions is used, the json schema generation process adds a oneOf schema constraint in the json schema, that validates that only one of the various union members (here apply or exec) is provided.
It's already working like that in other places where unions are used: project source (git, zip), which is besides the project name and the clonePath for example.

Is there any other disadvantage in making it required for devfiles?
I would say that consistency would make it more user-friendly.

The question is mainly that, until now, we had said that plugins should not require the use of a name, since the plugin component name (sort of "key") can be deduced from the plugin id or  uri.
So that's more question for @l0rd

One issue I have with the proposed change is that separating name or id in this way looks cleaner when we type it out, but often yaml keys will be reorganized at some point in the serialization-deserialization-format chain. The example below is harder to read, in my opinion (though the same problem exists regardless of where we put name)

devfile.yaml
schemaVersion: 2.0.0
metadata:
  name: java-quarkus
  version: 1.0.0
  website: https://quarkus.io
projects:
  - name: quarkus-ex
    git:
      location: https://github.com/odo-devfiles/quarkus-ex
components:
  - container:
      image: quay.io/eclipse/che-quarkus:nightly
      memoryLimit: 1512Mi
      mountSources: true
      volumeMounts:
        - name: m2
          path: /home/user/.m2
      endpoints:
        - name: '8080/http'
          targetPort: 8080
    name: tools
  - volume:
      size: 3Gi
    name: m2
commands:
  - exec:
      component: tools
      commandLine: "mvn compile"
      workingDir: $PROJECTS_ROOT/quarkus-ex
    id: init-compile
  - exec:
      component: tools
      commandLine: "mvn quarkus:dev"
      attributes:
          restart: "false"
      group:
        kind: run
        isDefault: true
      workingDir: $PROJECTS_ROOT/quarkus-ex
    id: dev-run
events:
  postStart:
    - init-compile

I pretty consistently have this reorganzation problem when looking at devfiles in current Eclipse Che, for example:

Snippet of one of my devfiles (1.0 spec)
  - mountSources: true
    endpoints:
      - name: che-docs-livereload-server
        port: 35729
      - name: che-docs-web-server
        port: 4000
        attributes:
          path: /che-7/introduction-to-eclipse-che/
    args:
      - sleep
      - infinity
    memoryLimit: 1Gi
    type: dockerimage
    image: 'docker.io/amisevsk/che-docs-dev:latest'
    alias: che-docs-dev

(though here all keys are at the same level

Following recent discussions, this issue is blocked by https://github.com/devfile/api/issues/111


design review

Several things wanted to check with you on:

[ ] result list - including need better distinguishing between title/content
[ ] highlighting
[ ] more button at bottom
[ ] any other issues with layout/style/positioning

Will probably be back with a couple more once we have autocomplete implemented.

Can we close this, or remove me from assigned? =D


Rollup failed to resolve import "broadcast-channel"

Describe the bug
Rollup failed to resolve import "broadcast-channel"
Reproduction
https://github.com/moreadgroup/moread-dapp-ebmaster/runs/4343503475?check_suite_focus=true
Logs
✓ 70 modules transformed.
[vite]: Rollup failed to resolve import "broadcast-channel" from<EMAIL_ADDRESS>> [vite]: Rollup failed to resolve import "broadcast-channel" from<EMAIL_ADDRESS>This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
Error: [vite]: Rollup failed to resolve import "broadcast-channel" from<EMAIL_ADDRESS>This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
    at onRollupWarning (/home/runner/work/xyzapp/xyzapp/node_modules/vite/dist/node/chunks/dep-e0fe87f8.js:43253:19)
    at onwarn (/home/runner/work/xyzapp/xyzapp/node_modules/vite/dist/node/chunks/dep-e0fe87f8.js:43037:13)
    at Object.onwarn (/home/runner/work/xyzapp/xyzapp/node_modules/rollup/dist/shared/rollup.js:23003:13)
    at ModuleLoader.handleResolveId (/home/runner/work/xyzapp/xyzapp/node_modules/rollup/dist/shared/rollup.js:22347:26)
    at ModuleLoader.resolveDynamicImport (/home/runner/work/xyzapp/xyzapp/node_modules/rollup/dist/shared/rollup.js:22401:26)
    at async /home/runner/work/xyzapp/xyzapp/node_modules/rollup/dist/shared/rollup.js:22305:32
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: failed to run `yarn svelte-kit build` with `sh -c`

Caused by:
    command failed

 app:spawn Command "/home/runner/work/xyzapp/xyzapp/node_modules/@tauri-apps/cli/bin/tauri-cli" failed with exit code: 1 +0ms
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

System Info
yarn global add envinfo && envinfo --system --npmPackages svelte,rollup,webpack --binaries --browsers
  shell: /bin/bash -e {0}
yarn global v1.22.15
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Installed<EMAIL_ADDRESS>with binaries:
      - envinfo
Done in 1.81s.

  System:
    OS: macOS 10.15.7
    CPU: (3) x64 Intel(R) Xeon(R) CPU E5-1650 v2 @ 3.50GHz
    Memory: 10.24 GB / 14.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 14.18.1 - ~/hostedtoolcache/node/14.18.1/x64/bin/node
    Yarn: 1.22.15 - ~/.yarn/bin/yarn
    npm: 6.14.15 - ~/hostedtoolcache/node/14.18.1/x64/bin/npm
  Browsers:
    Chrome: 96.0.4664.55
    Edge: 95.0.1020.53
    Firefox: 94.0.1
    Safari: 15.1

Severity
blocking an upgrade
Additional Information
No response

https://github.com/moreadgroup/moread-dapp-ebmaster doesn't exist, so I can't see how you've setup your code
broadcast-channel should be an optional dependency if you're using the latest svelte-query (1.5.0)


Increase the wait to update allowed_cdrs

It is observed that in 17.1 more than 10 seconds in updating the allowed_cdrs in the openstack loadbalancer listener.
This change is increasing the wait time to 60 seconds. As this is an active wait, the faster clouds will not be affected.

/assign @eurijon

/cherry-pick release-4.14


[Feature] Navbar sections buttons added hover effect.

#431
In Navbar section there was no hover effect. I add hover effect in existing html file. @CSEdgeOfficial
Please merge this little update in your main project under gssoc'24 and level  this PR.
Before Video -
https://github.com/CSEdgeOfficial/learn.csedge.courses/assets/136844498/b674e5dd-1105-4d5e-9937-1327cbfddcd8
After hover effect -
https://github.com/CSEdgeOfficial/learn.csedge.courses/assets/136844498/1a5a1095-5e5a-427f-9132-e16994cc2679
#431
Description -
In Navbar section there is no hover effect.
Please assign me this task I'll add this effect with attractive color effect.
#437
Footer section CSS style -
Before -
https://github.com/CSEdgeOfficial/learn.csedge.courses/assets/136844498/f668721e-02cd-4088-bff1-c507fbbe59c4
After adding Social media -
https://github.com/CSEdgeOfficial/learn.csedge.courses/assets/136844498/3b0c9537-e60e-407a-ac06-b5886acebff7
#437
I added CSS style in footer section as well as I add social media section with hover effect.
Type of PR

[x] Bug fix
[x] Feature enhancement
[x] Documentation update
[x] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

Sorry didn't understand
Please PR #436 merge in your code that the changes will reflect in the
design
Please merge this PR not to add in your main.
On Mon, 10 Jun 2024, 9:49 pm CSEdge, @.***> wrote:

Merged #436
https://github.com/CSEdgeOfficial/learn.csedge.courses/pull/436 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/CSEdgeOfficial/learn.csedge.courses/pull/436#event-13104331574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAUBJUX3WKS3A4TGQ7477F3ZGXGXNAVCNFSM6AAAAABJBTH2ZCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGEYDIMZTGE2TONA
.
You are receiving this because you were assigned.Message ID:
<CSEdgeOfficial/learn.csedge.courses/pull/436/issue_event/13104331574@
github.com>

My PR #436, you added to the main. Please remove it from there and merge
the pull request
On Tue, 11 Jun 2024, 9:40 am Md Sakeel Ansari, <
@.***> wrote:

Sorry didn't understand
Please PR #436 merge in your code that the changes will reflect in the
design
Please merge this PR not to add in your main.
On Mon, 10 Jun 2024, 9:49 pm CSEdge, @.***> wrote:

Merged #436
https://github.com/CSEdgeOfficial/learn.csedge.courses/pull/436 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/CSEdgeOfficial/learn.csedge.courses/pull/436#event-13104331574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAUBJUX3WKS3A4TGQ7477F3ZGXGXNAVCNFSM6AAAAABJBTH2ZCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGEYDIMZTGE2TONA
.
You are receiving this because you were assigned.Message ID:
<CSEdgeOfficial/learn.csedge.courses/pull/436/issue_event/13104331574@
github.com>


Fix issue with case inside if statement inside shell expansion

Fixes #108
There is some weird issue when trying to have a case statement inside and if block, inside a shell expression $(). This keeps the same logic, just moves the if statements outside the expansion to allow the case to work as intended.

@falcon-pioupiou can you review this, as you introduced these changes, and I have no idea how they worked for you. I definitely want to keep the functionality, but this seems to be a safer way to accomplish what you intended.


handle is already closing

Description
I'm sometimes (twice today) getting that issue when committing to git. I'm not sure what's going on... Possibly some sort of race condition?
Neovim version
NVIM v0.9.1
Build type: Release
LuaJIT 2.1.0-beta3
system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/__w/neovim/neovim/build/nvim.AppDir/usr/share/nvim"
Run :checkhealth for more info
Operating system and version
fedora 38
Steps to reproduce
unfortunately i cannot reproduce at will. it's related to committing...
Expected behavior
No response
Actual behavior
".git/COMMIT_EDITMSG" 10L, 299B written
Error executing vim.schedule lua callback: ...vim/site/pack/packer/start/neogit/lua/neogit/process.lua:173: handle 0x557154dcf960 is already closing
stack traceback:
	[C]: in function 'close'
	...vim/site/pack/packer/start/neogit/lua/neogit/process.lua:173: in function ''
	vim/_editor.lua: in function <vim/_editor.lua:0>
Error executing vim.schedule lua callback: ...vim/site/pack/packer/start/neogit/lua/neogit/process.lua:173: handle 0x557154d679c0 is already closing
stack traceback:
	[C]: in function 'close'
	...vim/site/pack/packer/start/neogit/lua/neogit/process.lua:173: in function ''
	vim/_editor.lua: in function <vim/_editor.lua:0>

Minimal config
vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvim/site]])
local package_root = "/tmp/nvim/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup({
    {
      "wbthomason/packer.nvim",
      {
        "NeogitOrg/neogit",
        requires = {
          { "nvim-lua/plenary.nvim" },
          { "sindrets/diffview.nvim" },
        },
        config = function()
          print("loaded neogit")
          require("neogit").setup()
        end,
      },
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  })
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing neogit and dependencies.")
  vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()

Oh, we need to check if it's already closing. We're calling timer:close() where it is entirely possible it is already closing:
https://github.com/NeogitOrg/neogit/blob/29aaebd5fd2a6ce95537852d45dca1c036ebc49a/lua/neogit/process.lua#L173
This is because we do a schedule_wrap on it and then assign the timer to the instance. It's possible that something else also calls self.timer:close() before that scheduled function is ran. When it goes to call close something else has already called it.
What's not clear to me is the logic within this function:
https://github.com/NeogitOrg/neogit/blob/29aaebd5fd2a6ce95537852d45dca1c036ebc49a/lua/neogit/process.lua#L161
Checks if the current instance timer exists and if it doesn't only then does it start a timer. Surely that's not right? This may be the source of some issues with commits not working (maybe?).
I'll take a look and see what I turn up.

thanks a lot for the superfast response!

Yeah, really glad you spotted that - I didn't know the nuance of calling that API. Thanks @treatybreaker


Seizure-inducing flashight

Flashlight seems to flicker between both eyes. Make it stop!

Might also be fixed by #8 ? Need to check!

Appears to be fixed on AMD at least! Working on a HTC Vive/SteamVR/Vega 56.

@Foohy thanks for confirming, closed.


Observer tests improvements

Basically all tests are rewritten here. Implementation details should
not be checked because tests are becoming fragile when it comes to any
refactoring.
What instead should be tested is the actual public behavior of the
library when using its public interfaces.
While doing all these changes the following assumptions about this codebase
have been made:

class fields which are prefixed with underscore (like observer._onNext)
are intended to be private and thus should only be accessed by members of
the same class or its subclasses
observer.stopped is a public readonly field and should never be
modified by the outside world, because its role is considered to be
purely informational

If the above assumptions are not correct, this will need to be discussed
further. These improvements of the tests are necessary to introduce any
changes which include refactoring of the Observer in order to fix some
bugs.

@bjornbytes do you have some ideas why build fails on LuaJIT2? What are the differences between these runtimes that make this one test fail?

Well it looks like a bug in the test framework so I made a quick fix and sent PR for that too: https://github.com/bjornbytes/lust/pull/3
When / if this patch for lust is merged, updating lust version embedded in RxLua repo will resolve problem with that one grumpy test failing on LuaJIT

Yeah, there's an annoying difference between the different Lua flavors:
print(#{1, nil, 3}) --> 1 in LuaJIT, 3 in Lua

Even though nils are generally fine in observables, it might be better to just avoid them here and use something like false instead, to make testing easier.
Though, it seems like the strict_eq function would work fine without the length or tableSize tests.  For the lust PR I'd kinda prefer just removing the length tests altogether to keep things simpler.
Also, this is a minor thing, but could you remove trailing whitespace in this changeset?  Usually it's possible to configure text editors to do this automatically.
Thanks!!

I was actually suspecting the problem was deeper when comparing the extra hash table { key = 6 } I've added as last argument, but yeah you're right - it's that nil's fault. So it seems like this test must have been failing anyway on LuaJIT even before my changes.
I feel like the proper solution here is to fix the test framework instead of adjusting the input data in specs to satisfy the runner. This way tests will be more robust and may actually catch some accidental errors introduced during further refactoring. I've updated the PR on lust project to remove the table size check.
Can you point out where are the trailing whitespaces you're mentioning? I don't see any signs of them... usually they are noticeable and clutter local diff and / or diff view here on github but I don't see anything strange now.

Here's what I'm seeing:

Whitespaces are fixed I think. It would be best now to first merge #48 and I can then rebase this branch to see if cheks are passing. If you prefer to merge without any particular order I'm fine with that too :)