chat-with-rendezvous: No way found to remove host from kad-dht

The default rendezvousString did not work well for me.
Instead, I use a UUID as rendezvousString and it did work better. But, after a restart, I get errors concerning the old peers:

dial attempt failed: <peer.ID Qm*QscaEK> --> <peer.ID Qm*dFxmP9> dial attempt failed: connection refused
dial backoff

Using a new UUID, there are no errors.
How can I remove peers from kadDht? I tried it with contexts and methods, but without success. How can it be done?

@stefanhans So everyone trying this code by default are using meet me here as the rendezvousString.
So every time you run this code a new peer is started and it will announce itself (using Provide) to the bootstrap node with rendezvous point meet me here. But what happens once you disconnect?
Your address is still registered in the bootstrap node at that rendezvous point (till the time it expires and dht is forced to remove it) and anyone looking for new peers to connect (using FindProviders) will get your address. Now bootstrap peers don't know if these address or peers are still alive. Now, when you try to connect to them you get dial attempt failed: error.
Now, this is not your peers fault instead it's the bootstrap peer giving you dead peers. I don't think libp2p has any method which lets you remove peers from the bootstrap peer's list. It should be the bootstrap peer who should ping a remote node just to check if it is alive or dead and act accordingly. RFC: rendezvous is a more sophisticated rendezvous protocol which is better than the existing dht hack.
You might also notice that if you run a peer (let's say A) and announce yourself to the dht and now start another peer (say B) which queries the bootstrap peer for new addresses. All peers received by peer B are dead and none of the address corresponds to peer A. This happens because bootstrap peer returns a random subset of the peers registered with it.
So, it would be better to not use meet me here instead use something unique and start two peers with the same rendezvousString. For meet me here to work you need more number of alive peers than the dead ones.

Hi @upperwal,
sounds reasonable 😀 thx
I ended up with using a UUID as rendezvous string. Still not always getting all peers connected in the prototype of mine.
Maybe SWIM(++) protocol from Hashicorp is worth a try.
Cheers, Stefan


[Bug] Can't save new, empty text file

I realize that this isn't a typical use case, but sometimes with "regular" Notepad I've saved empty text files before typing anything at all because I already know where I want to keep the file and what I want to call it although it doesn't contain any text yet.
In Notepads, saving is disabled when the file has no content - except if you write some text, save it and then remove the text again. In that case, you're able to save the empty file. In my opinion, saving should be enabled at all times, regardless of the contents of the file.

You can use "save as" when there is no text in the new document. This is the recommended way.

@JasonStein Thanks for commenting on this so soon.
It's good to know that there is an alternative. For me personally it feels wrong since I almost exclusively use keyboard shortcuts. So Ctrl+Shift+S works with an empty text document, but in my mind Ctrl+Shift+S is meant for saving something that's already saved in a new file. So I'd have to mentally rearrange things for this particular software.
Even semantically speaking, it makes more sense to me to simply "save" a newly created document rather than to "save [it] as" something when it is still unsaved. Lastly, this is pretty much standardized behaviour for any kind of (text/image/audio/video) editing software.
With that in mind, consider this a suggestion. I understand if it's not a priority for now but would appreciate if you consider taking a closer look. Otherwise - if I find the time - I might create a pull request for it in the future.
In any case, thanks for creating and sharing this awesome piece of software! :) Been waiting for something like this to come along.

Thanks for the advice. If you use Windows Notepad, you will notice that when you hit "ctrl+s" for empty document, the popup window actually is calling "Save As":

As well for notepad++, the "Save" button is also disabled when document is empty:

I think this is well established "behavior", so I just implement as the same.

 Actually learned something new today, then. I guess Save as makes sense since Save typically refers to saving modifications, whereas Save as refers to saving something hitherto unsaved. After some testing I found that both VS Code and Windows Notepad will bring up the Save as dialog if you press Ctrl+S in an unsaved document - regardless of its content (or lack thereof). Only Notepad++ among these behaves like Notepads, where the Save option becomes available only after adding some content (and optionally, removing it again).
So I apparantly misspoke earlier. Sorry about that. The convention in the scenario described isn't to bring up the Save dialog, but the Save as dialog as you stated. Is that something you'd consider? To clarify - I'm suggesting enabling the Ctrl+S shortcut immediately but having it open the Save as dialog if the document hasn't been saved yet.
Finally, in asking you to "consider" this I don't mean to come across as demanding. If that's how it comes across, it would be because I have failed to translate my meaning into English (being foreign). Like I mentioned earlier, I'd be happy to submit a pull request if I figure out how to implement the changes requested. However, I'd still be interested in knowing if you'd be willing to accept such a pull request before even making an attempt.


#load command

Is there a reason why the #load command in the csx source  leads to 'source code references are not allowed'  error.
Would it be possible to add that functionality as it is baiscally available in roslyn scripting ?

I'll look into it. I'm not sure how completion would behave in such cases.
Making #load work should be simple enough - just need to specify a SourceReferenceResolver.

Thanks:
Just look here: There is one which allows local and remote (http) sources.
https://github.com/filipw/Roslyn.Resolvers.Demo

There's a built-in resolver in Roslyn. Do you think it would be useful to allow HTTP sources as well?

I use csx-scripts to process inputdata from the globaldata object which i can access in a csx-script, when i host it myself. This actually works in a rest webservice, where i can post data to the service and call the script. I could use the #load command to simulate the input data in the editor, because there i have no configurable global object, which i can access. if the editor could load the file from my service (via http), i could dynamically create this data and the editor could really test my script with original input data. Of course i could edit another file and specify the input data by hand, this would be good enough, but i think it would be no big effort to make the #load command more universal...

pressed the wrong button.... so i reopen it....

I've added the default resolver, so local references should work now. I'll consider the remote one for a future version.


Added functions Mkdirs and Setwd.

Hi, I added some useful functions. I can add test for them later.

Setwd is not safe because of the pooled design of goftp. You might have multiple connections to different servers, so changing the working directory on one connection wouldn't have any effect on other connections.
Mkdirs can be useful, but I don't think it belongs in the core API since it doesn't correspond to an FTP command. The implementation also might have problems if you have connections to multiple servers.
It seems like the pooled connection design is good for read operations, but doesn't make sense for write operations. If the pooled client was just for downloading, and there was a single connection for write commands, then Setwd and MkdirAll could be added to the write client. Going to have to think about that some more.


insert replaced code for first arg of [

This fixes Issue 320.

This was accidentally closed without merging.


MediaStream extends EventTarget, PeerJs.Peer.off

MediaStream does not extend EventTarget interface probrem so I fixed.
PeerJs Peer has off method like removeEventListener.

see also Media Capture and Streams W3C Editor's Draft 29 June 2015

I`ll separate two chenge.

https://github.com/borisyankov/DefinitelyTyped/pull/4829
https://github.com/borisyankov/DefinitelyTyped/pull/4830


Json unmarshaler

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report

Merging #222 (d6703e6) into master (95fadff) will increase coverage by 0.07%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   56.60%   56.68%   +0.07%
==========================================
  Files         140      140
  Lines       15428    15458      +30
==========================================
+ Hits         8733     8762      +29
  Misses       6134     6134
- Partials      561      562       +1

Flag
Coverage Δ

1.14.x
26.95% <50.00%> (+0.14%)
:arrow_up:

1.15.x
26.95% <50.00%> (+0.14%)
:arrow_up:

1.16.x
26.95% <50.00%> (+0.14%)
:arrow_up:

1.17.x
56.68% <50.00%> (+0.07%)
:arrow_up:

1.18.x
26.95% <50.00%> (+0.14%)
:arrow_up:

connection
14.88% <0.00%> (-0.03%)
:arrow_down:

discovery
14.34% <0.00%> (-0.03%)
:arrow_down:

e2e
46.71% <0.00%> (-0.06%)
:arrow_down:

integration
46.71% <0.00%> (-0.06%)
:arrow_down:

macOS-latest
26.95% <50.00%> (+0.14%)
:arrow_up:

ratelimiter
16.79% <0.00%> (-0.04%)
:arrow_down:

scripting
17.27% <0.00%> (-0.04%)
:arrow_down:

table
40.85% <0.00%> (-0.05%)
:arrow_down:

ubuntu-latest
56.68% <50.00%> (+0.07%)
:arrow_up:

unit
26.95% <50.00%> (+0.14%)
:arrow_up:

windows-latest
26.95% <50.00%> (+0.14%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/table/scanner/scanner.go
38.27% <50.00%> (+0.70%)
:arrow_up:

log/table.go
69.67% <0.00%> (+0.77%)
:arrow_up:

internal/table/scanner/scan_raw.go
1.03% <0.00%> (+1.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95fadff...d6703e6. Read the comment docs.


Improve lighthouse score

Added PWA plugins and lang attribute.

Oh yes I'll add the logo and I'll change those versions, thanks!

I also changed both the theme and background colors to the purple in the logo.


Added conditional dependancy downloading in CI

Progresses #1310
This will skip downloading the cargo dependencies if the cache is present. The cache gets refreshed based on the hash of the Cargo.toml file, so when that file doesn't change, this could save 2 - 3 minutes per run.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.34%. Comparing base (8151bdb) to head (15c00d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1471   +/-   ##
=======================================
  Coverage   87.34%   87.34%
=======================================
  Files          15       15
  Lines        5303     5303
=======================================
  Hits         4632     4632
  Misses        671      671

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@joshlf If some of these commands need to be run regardless of the cache filling, I can split them up.
I have a feeling we still may want to run

cargo check --workspace --tests
cargo kani setup

https://github.com/google/zerocopy/blob/8151bdbe5eae92b119d64c8f60d00279d75eae0b/.github/workflows/ci.yml#L507-L512

Hmm my thinking (and I should probably add this as a comment somewhere) was that, if there's a cache hit, then the "populate cache" step should be quick because all of the cargo tools we run won't need to actually download. But there might be steps that are unconditionally re-run.
Can you see if it's possible to coax GitHub into running this in such a way that one of the runs has a cache hit so we can see what the timing looks like w/ and w/o this PR?

@joshlf yes of course, and thanks for the catch as I think you are right. I don't think this will save nearly as much time as I thought. It might save 20s since it won't run that download step at all.
With PR

cache hit 7s view
cache not hitting 3m 9s view

Without PR

cache hit 26s view
cache not hitting 3m 10s view

Ah, bummer. Thanks for running the numbers, though! I don't think 20s justifies the complexity, so I'm gonna close this, but thanks for your work on it, and keep the PRs coming!


rename r directory to 2BWJFTXKJ

What is this PR for?
Rename "R" directory to "2BWJFTXKJ" under notebook directory to make it look like all other notebooks.
What type of PR is it?
[Refactoring]
Todos

[x] - Rename

What is the Jira issue?

N/A

How should this be tested?
goto  $ZEPPELIN_HOME/notebook directory, under this there should be no "R" directory.
On starting zeppelin-server, the existing notebook should be listed.
Screenshots (if appropriate)
N/A
Questions:

Does the licenses files need update? N/A
Is there breaking changes for older versions? N/A
Does this needs documentation? N/A

@echarles I'm assuming there was no specific reason to keep name of this directory as "R" and hence, renaming this to look like any other notebook.

@prabhjyotsingh yes, assumption is correct. At the time of the R interpreter dev, I was used to manually rename the note folder and edit the json to set the id the same value.
This PR takes it back to the default layout (didn't test it, but checked that the id value in the json was also correct).
LGTM

Sure, Thank you. Will merge this if no more discussion.

Shell we update https://github.com/apache/zeppelin/blob/master/notebook/r/note.json#L1011, too?

Yes, I did both, rename the directory and https://github.com/prabhjyotsingh/zeppelin/blob/5993506b77be84d71ab730c2965572edd73e870e/notebook/2BWJFTXKJ/note.json#L1041

Ah I missed the change. LGTM


New endpoints for codes and concepts paths

New endpoints:
/codes/{code_id}/terms
/concepts/paths/subgraph/sequential
/concepts/{concept_id}/paths/subgraph/sequential

@AlanSimmons just a heads-up. We'll likely have to wait on this PR until after releasing the recent /assayclasses and assayclasses/<name-or-code> updates.

I agree.

@AlanSimmons can you merge the current main branch into your branch so we have the latest updates.

@yuanzhou I did the following. Let me know if this is what you needed:

Checked out my local main and updated the project.
Checked out my local jas_code_term and updated the project.

Did you want me to re-commit or PR?


8

go to
where am i
where can i go
Square location

Unrelated to this specific code review, but still needs to be fixed:

Please remove the using System; in Weapons.cs;
Please fix the typo in the Description property of the IWeapon interface. It is currently called Descriprion with an r instead of a t.


Fix #28 and #46 error list item text

The only caveat here is with result messages that contain hyperlinks: we can't render hyperlinks in the expando area, which means we can't limit the item's text to the first sentence in case there are links beyond that. We COULD add code to handle this case (truncate as early as possible so all links are included) but I elected not to do that in this change.

Do you have any suggestions for test files that help illustrate this change? If you had any generated test content that you used even to manually verify your work, that would be helpful to check in.

LGTM


Allow ignoring explicit interface implementation using casting

Resolves #3790

:shipit:

Thanks to @natemcmaster for GetRuntimeInterfaceMap.
Changed implementation fully to handle this in propertyAccess. If the expression passed gives the propertyinfo defined on interface type, we try to find the associated propertyInfo defined on the concrete class. This gives us interface implementation in the concrete class, (explicit one if present).
So, if you pass expression without any cast then it will use the propertyInfo on type. If you use interface cast then it will use the explicit interface implementation if present otherwise implementing propertyInfo. Considering the changes are in processing of propertyAccess it should take care of Ignore/property/query all.

@divega you are SME of EF Project ?

This requires another review because implementation changed totally.

:shipit:


New package: Survey v0.1.0

Registering package: Survey
Repository: https://github.com/samplics-org/survey-jl
Created by: @MamadouSDiallo
Version: v0.1.0
Commit: 29e8c409ba6f93718bf91ed6ad4890f53c6521b6
Git reference: main

Hi @MamadouSDiallo!  The package looks empty at the moment

Hi. I updated the repository to .jl. I will add code soon. thanks

package still empty, and the name is too generic to know what it does. (is it a survey service? survey analysis? some survey website API wrapper?)
Please don't name squatting


Can't update issue on redmine 4.1.0.stable

Hi, i cannot update the issue using either fluent API or via transport. The error is "Entity may not be null". There is no entity since this response from Redmine returns a 204 no content (no body) but Apache still throws this error.
Any way to resolve this? issue.update() and t.updateObject(issue) both throw the same thing.
Error happens here:
return handler.processContent(httpResponse);
because final String charset = HttpUtil.getCharset(entity); is called on null entity.
Originally posted by @marepop in https://github.com/taskadapter/redmine-java-api/issues/342#issuecomment-613851037

let's clarify - so this works with older Redmine versions, but does not work with Redmine 4.1.0.stable.  is that correct?

let's clarify - so this works with older Redmine versions, but does not work with Redmine 4.1.0.stable. is that correct?

Yes. That's correct. Our implementation worked with an older version of Redmine. After migrating to a new version 4.1.0.stable (no additional plugins) i came upon this problem.

alright, can you please run all tests in this project against your own Redmine instance and see what else fails? (see redmine server URL in config files).
you are welcome to explore what API changes are required to support Redmine 4.1.0.stable and submit a proposal along with a PR.

I've created a PR: https://github.com/taskadapter/redmine-java-api/pull/355
I don't know how to run the test. But I got it works with Gerrit its-redmine plugin with Redmine 4.1.1. Please have a try.

you can change the test config to point to your local Redmine instance and then run "gradle test".
please ensure that the change works with the non-modded Redmine installation (no extra plugins). you may need to write some additional tests to cover this specific use-case


git-pw: init at 2.5.0

Description of changes
This is very useful to work with Patchwork (mass-applying patches, etc.).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I believe it makes sense as this is a cheap way to test even a Python
application. Here, I agree with you, I don't feel like it's a module. I am
away from laptop but I think other such examples in nixpkgs exist.
Le dim. 4 juin 2023 à 17:06, Alyssa Ross @.***> a
écrit :

@.**** commented on this pull request.
In pkgs/applications/version-management/git-pw/default.nix
https://github.com/NixOS/nixpkgs/pull/235918#discussion_r1216789806:

propagatedBuildInputs = with python3.pkgs; [

pyyaml
arrow
click
requests
tabulate
pbr
];

nativeCheckInputs = with python3.pkgs; [
pytest
pytest-cov
git
];

pythonImportsCheck = [ "git_pw" ];

Does it make sense to do an imports check for an application? If this is
also usable as a library, then it should live in python-modules and use
toPythonApplication in all-packages as documented in the Nixpkgs manual.
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/235918#pullrequestreview-1461234648,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACMZRFYGAC4M5Y6CUURD6DXJSQA7ANCNFSM6AAAAAAYZ435Y4
.
You are receiving this because you authored the thread.Message ID:
@.***>

I believe it makes sense as this is a cheap way to test even a Python application.

But it's not a useful test, because it's not testing something any end user is going to care about.  If you're looking for a cheap test, what about something like testers.testVersion?

PTAL @fabaff @alyssais.


Unable to login with OIDC when using uwsgi

I'm experiencing a strange problem with OIDC and a uwsgi deployment:
After /oidc/login, the redirekt to the provider and the following redirect back to PowerDNS-Admin, I get a 404 for /oidc/authorized.
This does happen with uwsgi.
This does not happen when starting with the debug Flask server or Gunicorn.
I'm still debugging what's happening but I assume it is related to the way how uwsgi starts the app.
It must be related to https://github.com/ngoduykhanh/PowerDNS-Admin/blob/master/powerdnsadmin/services/oidc.py#L30 in some way. It seems the route doesn't get registered properly or in another thread/process or not soon enough. Still not sure what's happening.
This most probably affects also most of the other auth providers which work similarly.

I don't know if this is related, but when creating the Microsoft SAML support for pdnsa I found that the system had to be running on an https URL for it to work.  However since this was done via an nginx proxy, the pdnsa was generating URLs that were http.  I needed to modify the service code to explicitly have _scheme="https" for things to work.

Unlikely, when using the builtin Flask debug server locally, pdnsa is running on http, redirects to the OIDC provider (KeyCloak in my case) and redirects back properly.
Only when using uwsgi or gunicorn with multiple workers and threads, it breaks.
I'm pretty much sure the OIDC (and probably similar for the other auth modules) code isn't properly initialized in all workers or some state is not shared as expected.

After more debugging, it's getting slowly a picture:
with Gunicorn and the Flask debug server, you will get a 404 if the requested URL is "/oidc/authorized". Beginning with the second request, the route is found and everything is fine.
This must be related to the initialization in powerdnsadmin.index.register_modules().
With uwsgi, each request to "/oidc/authorized" ends in a 404 and the initialization code in powerdnsadmin.index.register_modules() is called everytime.
I see two problems here:
a) no matter which server you use, the very first call to "/oidc/authorized" everytime ends in a 404.
b) in uwsgi the module registration doesn't work as expected

Please scratch the whole uwsgi part, I just started uwsgi the wrong way. Sorry for the spam.
Still, issue a) should still be true: the first request doesn't seem to work right.
I'll continue debugging.

@eht16,
Regarding your issue a), do you see it happens on other OAuth methods when running via uwsgi ?

Yes, it is the same for the other methods.
I opened #678 with a clean and more detailed description of the issue.
This one I spammed with my previous setup problems :).


manage network/hostnames

fixed

using all localhost as default
when doing docker compose, passing variables
for the front end, if running on cloud, use aws_run.sh to update the server IP


Host Google Fonts Locally Instead of Using Google Services

Hi, I propose modifying the SQLPage shell component to host Google Fonts locally rather than relying on Google’s servers. This change is crucial for ensuring adherence to the General Data Protection Regulation (GDPR), especially in light of recent legal developments.
Context and Justification:
In January 2022, a significant legal decision in Germany highlighted the importance of this issue. A German court fined a website owner for using Google Fonts hosted on Google's servers without proper user consent, which was deemed a violation of GDPR. The case, reported by The Register, concluded that transmitting user IP addresses to Google without consent breaches GDPR requirements, resulting in a fine of €100.
To avoid similar legal risks and enhance the privacy of our users, hosting Google Fonts locally is a necessary step. This approach will prevent user data from being sent to third-party servers, thereby ensuring better compliance with GDPR and safeguarding user privacy.
It's worth noting that WordPress has also started hosting Google Fonts locally to address these GDPR concerns.
By hosting Google Fonts locally, we not only comply with GDPR but also improve the loading speed of the web application by reducing external requests. This enhancement demonstrates SQLPage dedication to privacy and user data protection.
References:

The Register - Website fined for using Google Fonts in violation of GDPR
WordPress - Google Fonts are Included Locally in Bundled Themes

Thank you.

Hello! I don't think it's realistic to include all of Google fonts inside the SQLPage binary by default. But we should definitely allow referencing a local font file on the server. We can detect if the font name starts with a / and reference it locally. Can you make a PR?

Sure. In case of a font not found should we gracefully fallback to using Google Fonts?

No, just test whether font starts with /, and if so create a style tag with a font declaration.
https://github.com/lovasoa/SQLpage/blob/c0efd148d12f144fe953dead4de1572e359a6e33/sqlpage/templates/shell.handlebars#L19-L20
And we should document this logic in the shell component documentation.

Ok. Have you considered having multiple fonts registered? This might be useful for example in the hero component where a user might use different font to display a nice looking quote along with a picture.

No, that's not something I had considered so far. May be interesting indeed.

Fixed by https://github.com/lovasoa/SQLpage/pull/439

What would you say of having multiple fonts like this and then use the name of a font as a property in the hero component?
{{#each (to_array font) as |fontEntry|}}
    {{#if fontEntry}}
        {{#if (starts_with fontEntry "/")}}
            <style>
                @font-face {
                    font-family: 'LocalFont';
                    src: url('{{fontEntry}}') format('woff2');
                    font-weight: normal;
                    font-style: normal;
                }
                :root {
                    --tblr-font-sans-serif: 'LocalFont', Arial, sans-serif;
                }
            </style>
        {{else}}
            <link rel="preconnect" href="https://fonts.googleapis.com">
            <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
            <link rel="stylesheet" href="https://fonts.googleapis.com/css2?family={{fontEntry}}&display=fallback">
            <style>:root { --tblr-font-sans-serif: '{{fontEntry}}', Arial, sans-serif;}</style>
        {{/if}}
    {{/if}}
{{/each}}

That would just repeatedly re-define the same --tblr-font-sans-serif variable. Probably not what you want.
I think it's fine to ask users to write 5 lines of CSS themselves if they want multiple fonts on the same page, which I think is rare among SQLPage users.


service example?

sorry, i use you lib in ros2, i find subscribe a topic is ok , but when i want to call a service , it stuck without any return . so are you support ros2 service?

Just made one that works for me in #22


Beta v3/master

Ready for review.  Most of the internals have been rewritten so reviewing file changes will only work in a few cases, like help providers, AppRunner and CommandParser.
The public interface for basic scenarios has not changed.  Some classes and members have been marked obsolete with messages for what to use instead.   See how pre-existing Example apps didn't need to change other than some namespace cleanup.
Most advanced use cases will have breaking changes.  I reached a point where it just wasn't worth the time to and effort to complicate design to maintain backward compatibility.    With the new design and public interface, maintaining backward compatibility should be easier to achieve.
Overview of significant changes:

the app is designed with a middleware pipeline.  All components run through the pipeline.

each step in the middleware reads and augments the CommandContext object where state is stored for the current command execution
middleware is broken into distinct stages.  intermediary stages were added as the most likely target for extension and to provide a guide to the order of the stages.

argument is broken down into Option and Operand
ICommand and IArgument are the public interface.

CommandInfo and ArgumentInfo are gone and the classes that convert from classes to commands are all internal

CommandInvoker is replaced by the middleware pipeline and IInvocation.  See CommandInvokerTests to see how this will be used going forward.
add IDependencyResolver.TryResolve so we'll need to update the other repo's that implement IDependencyResolver

Remaining work:

[ ] update documentation

[ ] fix invalidated documents
[ ] update with new architecture

[ ] release notes

[ ] breaking changes
[ ] recommended updates
[ ] bug fixes

[x] review namespace and class names again.  There may be better names than CommandContext, ExecutionConfig, etc.

Wow this is a big one!
Will review this hopefully by next week.

It is a big one.  I put a lot of time and thought into it.
It would be great to get feedback from you and others.  Is it possible to deploy a beta nuget package from this branch so people can update their local projects and give feedback before we merge?

Yes it's possible to deploy from a branch. The process to deploy is the same. Just need to create a new tag and push to Github. Let's do an alpha release.
Since we are introducing some breaking changes in this version, I might also do some re-thinking about our attributes. Currently we have ApplicationMetadata for app level meta and also command level meta, SubCommand for defining nested commands. I am looking for an opportunity to make attributes more intuitive and obvious. I am not sure when I will do it ... may be before stable v3 or if it takes too long, v4. What do you think about these attributes? Do you think there is scope to improve? Or I am overthinking it?
Anyways, you can push the alpha tag now if you want.

I was also thinking about these two attributes and renaming them before the release.
For ApplicationMetadataAttribute, I think CommandAttribute and makes more sense.
For SubCommandAttribute, it's only needed if we can't determine the Type of hte is a command.  If we required subcommand classes to be marked with CommandAttribute then we wouldn't need the SubCommandAttribute.

Do you use AnsiConsole, and if so, how?  I'm wondering if it makes more sense to extract into its own library.

I didnt understand

AnsiConsole isn't referenced and seems like a different concern than what the rest of the project is addressing.  It seems similar to http://colorfulconsole.com/ and I wonder if it should be extracted to another project or nuget or if it should be documented and tested.

@bilal-fazlani  I think this is basically code-complete now.  The public API is xml documented and fairly stable now.  What's left is to update all the docs as mentioned in the tasks above and fill in a few unit tests.  I don't think I'll be able to make much progress this week on that, but hopefully next week.
ps. this doesn't include any work for decoupling external dependencies as discussed in #154

I feel so bad I haven’t been able to help you out with this. You probably
have spent more effort on this library than I did. I really appreciate your
efforts.
On Tue, 13 Aug 2019 at 6:37 am, Drew Burlingame<EMAIL_ADDRESS>wrote:

@bilal-fazlani https://github.com/bilal-fazlani I think this is
basically code-complete now. The public API is xml documented and fairly
stable now. What's left is to update all the docs as mentioned in the tasks
above and fill in a few unit tests. I don't think I'll be able to make much
progress this week on that, but hopefully next week.
ps. this doesn't include any work for decoupling external dependencies as
discussed in #154
https://github.com/bilal-fazlani/commanddotnet/issues/154
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bilal-fazlani/commanddotnet/pull/150?email_source=notifications&email_token=AAZ5FLZB4DEIBPJHBYKBMCDQEICMJA5CNFSM4IEDFUK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4EHYJQ#issuecomment-520649766,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZ5FL34I23OB5UWYVQCYATQEICMJANCNFSM4IEDFUKQ
.

--
Thanks & regards
Bilal Fazlani

No worries.  It's something I'm interested in.  I had another project once (MultiCommandConsole) where commands were defined by classes and arguments by properties including something like IArgumentModel.  There were things I liked about it but I had wanted to shift to using methods instead and just didn't have the time.  This has been a good chance to revisit.  And it feels good to have a framework that I can use in the future that will be as extensible as I've needed in my past few gigs while also being the simplest way to spin up simple apps.

Hi @bilal-fazlani.  I created tags  3.0.0-alpha and CommandDotNet_3.0.0-alpha and it doesn't look like either resulted in a build of the tag:  https://travis-ci.com/bilal-fazlani/commanddotnet/branches
Any idea why it's not working?  I'm a bit stumped.

No worries, it must be something with my deployment script. I will take a
look.
On Thu, 22 Aug 2019 at 4:52 PM, Drew Burlingame<EMAIL_ADDRESS>wrote:

Hi @bilal-fazlani https://github.com/bilal-fazlani. I created tags
3.0.0-alpha and CommandDotNet_3.0.0-alpha and it doesn't look like either
resulted in a build of the tag:
https://travis-ci.com/bilal-fazlani/commanddotnet/branches
Any idea why it's not working? I'm a bit stumped.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bilal-fazlani/commanddotnet/pull/150?email_source=notifications&email_token=AAZ5FL35LCZI3V4PRCDDHETQFZZGTA5CNFSM4IEDFUK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44YK5Y#issuecomment-523863415,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZ5FL7UEJ3TGO7Q3VOG5W3QFZZGTANCNFSM4IEDFUKQ
.

--
Thanks & regards
Bilal Fazlani

This seems very strange. It does not look like it is related to the deploy.sh. It was not triggered at all. Weird. .travis.yml has not changed since a long time and it has been working fine. I will continue to search for cause.

I deleted the old tag. added some more commits on master. and the added the tag back on the latest master sha. Then pushed. Things worked this time. You will need to get a pull.
I don't know the reason it did not trigger deployment last time. Did you add the tag on master directly or on a separate branch and then merged that branch to master? If it was a separate branch then that's the only difference I can imagine..  but I am not sure. I think if we add tags to master branch then deployments should work as usual.

umm question.. did I make a mistake by tagging current master as 3.0.0- alpha? or that's what you intended..

it's not what i intended.  i thought i tagged it on the beta-v3/master branch.

ohh god :( Let me fix my mistake quickly

🤦♂ lolol.   No worries.  On another note, I've been using this on a couple of little projects and it's working really well.  RSP files and the debug directive have come in really handy during development.  And the middleware method is great.
This has made developing console apps a dream.  Just write a method, run it, debug into it when necessary.
I had to add cancellation logic in one of the projects and I'd like to make that another core option.
And I have a case where I'd could have a large list of piped inputs and would like to add support for streaming them in so the second app can process while the first one is working.

Cool 👍
so the 3.0.0-alpha nuget version was already consumed and I unlisted that package.
I added a new version 3.0.0-preview1 (inspired by dotnet). I really liked this way versioning. So much simpler and flexible. We can have some more preview versions I guess before the final 3.0.0
current git tag is CommandDotNet_3.0.0-preview1 on branch beta-v3/master
I want to automate the process of deploying documentation. It's manual right now. This is my next task.

That's great!  Thanks for hopping on this.  When the documentation auto-deploys, will we be able to have a link to documentation for each branch?

Not for each branch. But some project have documentation for each version. Let me see whats possible in our setup.

@bilal-fazlani I've got the external dependencies extracted and all combined into the single repo.  NameCasing (for humanizer), FluentValidation, Microsoft DI, Autofac and SimpleInjector.  The tagging strategy is working great for creating releases of the other projects with the correct version reference to CommandDotNet.
Since there are a lot of changes here, let me know if you'd like to schedule a hangout to go through this and field questions and such.
I've still got some documentation to do and few other items on my todo list.  I think another week and this will be stable.

I have looked at the branch and everything looks cool. Now that name casing is extracted out as a separate package, I am assuming it is an optional feature people will have to opt-in by installing that nuget package.. is this correct? I was kinda hoping that we can make kebab-casing as default. Would it still be possible?

I must say though, with all the separate nuget packages & mono repo with individual release cycles things are looking pretty neat!

Yeah, I'm happy with how it turned out.  I'm a bit bummed that GitHub won't trigger it's tags webhook when there are more than 3 new tags, but otherwise, I think this is a pretty simple solution to use and removes version handling from the code.  Just remember to never push more than 3 new tags at once.
Re: name-casing.  Yes, it's optional now to decouple the external dependency.  I'd like that default too but I think it's too much complexity, especially if devs use words from other languages.  I think we'd end up with more issues to address that than the rest of the app.  Pulling the extra package is simple enough.  The issue becomes making the feature obvious which I think we can do through the documentation.
As a side note, the package also allows overriding the names from the attributes which means it will be possible to apply consistent naming with libraries that define commands and options.

And something else about naming.  As shown in these tests, only Camel and Pascal case can be converted to any other case.  Kebab-case cannot be converted to other cases.  I assume it's a bug in Humanizer.  Due to this, I think guidance for any naming for middleware libraries should be to use Pascal and Camel case.

Just remember to never push more than 3 new tags at once.

Ohh didn't know about that. Good to know 👍

This branch deprecated by #194


date Picker under the signpost  ,when i open the datepicker inside the signpost and once selected date signpost also closing issue

Describe the bug
A clear and concise description of what the bug is, and the conditions when it occurs.
In the signpost under add the datepicker  input box ,when i try to selected the date  ,once selected the date immediately closing the signpost also ,issue seen on latest version clarity 4.0 issue.
If this is an accessibility related report, please use the correct template at https://github.com/vmware/clarity/issues/new?template=accessibility-report.md
How to reproduce
Inside the signpost add the date picker , and open the signpost ,once open the signpost  in the input datepicker select select the date ,once you select the date immediately it close the signpost also .
Please provide a link to a reproduction scenario using one of the Clarity Stackblitz templates. Reports without a clear reproduction may not be prioritized until one is provided.
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
inside the signpost once selected the date using datepicker ,it will not close the signpost
A clear and concise description of what you expected to happen.
Versions
App

Angular: [e.g. 10]
Node: [e.g. 12.0.0]
Clarity: [e.g. 4.0.1]

Device:

Type: [e.g. MacBook]
OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional notes
Add any other notes about the problem here.

Please, follow our issue submission template and provide all requested information, especially a Stackblitz representation of the problem.
Also, based on the signpost description from our website

The signpost is a convenient, lightweight way to show contextual help of information without taking the user out of the current context.
It is not intended to have heavy actionable elements inside it.

in clarity 2.0 and 3.0 have the support for signpost under date picker able to use ,why 4.0 onwards the restriction?, we already release the signpost under  date picker feature  on customer. Is there any work  around. for the solution?.

If you would like us to investigate more into this, file a new issue, following the template, with a stackblitz reproduction, please.
Not sure if we will decide to support it, but at least we can research exactly what happens and offer workaround if one exists.


Visualisation popup not activated with touch screen

The Visualisation popup is a great new feature, offering huge possibilities.
However, on touch screen, the popup is not activated when the user press on the map marker.

I do not have a touch screen to test on. I will gladly accept a PR.

Sorry it's out of my skills.
I was thinking that someone could link the default click on a marker to open the popup as well.
In that way the touch event that acts as a clic would also open it.
We have a nice 4x24p touch wallscreen dedicated to Kibana, all other features works perfectly, it's very nice.


reachableBy and reachableByflows not working for PHP code with Joern2.0

Here's a sample output. On the left is Joern2.0 and on the right is the previous version (cpg version 1.4.24).

I can confirm that the dataflow in PHP is broken.
Given this simple PHP code
<?php
function Foo() {
    $input = input();
    sink($input);
}

no flow from input to sink is found:
joern> cpg.call("sink").reachableByFlows(cpg.call("input")).size
val res1: Int = 0

Whereas using JavaScript, the expected dataflow is found:
function Foo() {
    var input = input();
    sink(input);
}

joern> cpg.call("sink").reachableByFlows(cpg.call("input")).size
val res1: Int = 1

Comparing all the graphs of both snippets, I found that the AST and CFG look pretty much the same. But the DDG is quite different.
DDG for PHP example:

DDG for JavaScript example:

Shouldn't be there a connection from the assignment of input to the call of sink, as in the JS graph?

Thanks for solving the issue for function calls data dependencies @itsspike. However, the PDG graph is still broken for regular statements, just like the example in the screenshot on the original issue:
<?php $source=0; $tmp = $source +1; $sink=$source; ?>

@elirizk This time, I'm afraid I cannot confirm 😕
Please have a look at the statements below and give me feedback if I missed something. But it looks great so far:
joern> importCode.php.fromString("""<?php
     | $source = 0;
     | $tmp = $source;
     | $sink = $tmp + 1;
     | ?>""")

joern> cpg.identifier("source").l
val res1: List[io.shiftleft.codepropertygraph.generated.nodes.Identifier] = List(
  Identifier(
    id = 8L,
    argumentIndex = 1,
    argumentName = None,
    code = "$source",
    columnNumber = None,
    dynamicTypeHintFullName = ArraySeq(),
    lineNumber = Some(value = 2),
    name = "source",
    order = 1,
    possibleTypes = ArraySeq(),
    typeFullName = "int"
  ),
  Identifier(
    id = 12L,
    argumentIndex = 2,
    argumentName = None,
    code = "$source",
    columnNumber = None,
    dynamicTypeHintFullName = ArraySeq(),
    lineNumber = Some(value = 3),
    name = "source",
    order = 2,
    possibleTypes = ArraySeq(),
    typeFullName = "int"
  )
)

joern> cpg.identifier("sink").l
val res2: List[io.shiftleft.codepropertygraph.generated.nodes.Identifier] = List(
  Identifier(
    id = 14L,
    argumentIndex = 1,
    argumentName = None,
    code = "$sink",
    columnNumber = None,
    dynamicTypeHintFullName = ArraySeq(),
    lineNumber = Some(value = 4),
    name = "sink",
    order = 1,
    possibleTypes = ArraySeq(),
    typeFullName = "ANY"
  )
)

joern> cpg.identifier("sink").reachableByFlows(cpg.identifier("source")).p
val res3: List[String] = List(
  """_________________________________________________________________
| nodeType   | tracked          | lineNumber| method   | file    |
|================================================================|
| Identifier | $source = 0      | 2         | <global> | tmp.php |
| Identifier | $tmp = $source   | 3         | <global> | tmp.php |
| Identifier | $tmp = $source   | 3         | <global> | tmp.php |
| Identifier | $tmp + 1         | 4         | <global> | tmp.php |
| Call       | $tmp + 1         | 4         | <global> | tmp.php |
| Identifier | $sink = $tmp + 1 | 4         | <global> | tmp.php |
""",
  """_________________________________________________________________
| nodeType   | tracked          | lineNumber| method   | file    |
|================================================================|
| Identifier | $tmp = $source   | 3         | <global> | tmp.php |
| Identifier | $tmp = $source   | 3         | <global> | tmp.php |
| Identifier | $tmp + 1         | 4         | <global> | tmp.php |
| Call       | $tmp + 1         | 4         | <global> | tmp.php |
| Identifier | $sink = $tmp + 1 | 4         | <global> | tmp.php |
"""
)


Query errors when authenticated using "AWS SDK Default" connection method

Hi,
I've set my Grafana to use a role that contains all required IAM resources to access Timestream.
As a result : in the config panel, simply setting "AWS SDK Default" and region => connection works, databases and tables are discovered, that's great.
BUT whenever I try a query, I get
ValidationException: Invalid pagination token.

Setting up a user with the exact same policies (same role attached), defining Access Key / Secret key method in the plugin connection : it works fine.

You should contact AWS Support and tell them your request id and pagination token using Query Inspector: https://community.grafana.com/t/using-grafanas-query-inspector-to-troubleshoot-issues/2630

You should contact AWS Support and tell them your request id and pagination token using Query Inspector: https://community.grafana.com/t/using-grafanas-query-inspector-to-troubleshoot-issues/2630

Unable to reproduce today.
I don't get it ... anyway  closing, and if it ever happens again I'll do as you suggest.
Thanks for the advice !

Unable to reproduce today.
I don't get it ... anyway  closing, and if it ever happens again I'll do as you suggest.
Thanks for the advice !


Align create card behaviour from PxPay to PxPost

Adds support for:

changing the amount authorized when creating a card
changing the action used when creating a card (i.e. can be a Purchase)

Also adds some additional unit tests to increase the coverage a bit, and updates the master branch alias since we're now over v3.1.

@barryvdh you OK to review?


Some vectors wont plot?

Great package! I have three coefficients i am trying to make a corner plot for. For some reason, nothing gets plotted for one of the coefficients. Also the range shown on the plot is incorrect for that coefficient. the other coefficients will plot fine. It seems to be related to the amplitude of the coefficient? Here is some code that recreates the bug (i have checked in jupyter and REPL).
using Plots, PairPlot

stda=0.00041
a=0.073 .+ stda*randn(2000)
stdb=0.0404
b=0.116 .+ stdb*randn(2000);

table1=(;a,b)
corner(table1)

stdc=stda*100
c=0.073 .+ stdc*randn(2000);

table2=(;b,c)
corner(table2)

****THIS PLOT WORKS****

It seems like if the variance is too small stda then it doesn't get plotted. Maybe this is intentional? Is there a better way to plot small values?

Thanks so much for the bug report! This seems to have been an error on my part when setting the limits on the subplots.
I've pushed a fix that appears to fix your example. You're welcome to test it out on the main branch, if you like (] add PairPlots#main).
I'll register a new version later today.

thanks for the quick fix on this! one more question. the significant figures seem to be limited to 3? so if a number is 0.004 it shows up as 0. the error estimates also work this way. is there a way to increase that to more digits or maybe switch to scientific notation?

Sure no problem, I just pushed a new option titlefmt you could use to control that. Here's an example:
corner(table, titlefmt="\$%s = %.2f^{+%.5f}_{-%.5f}\$")

If you need more control I could maybe swap this out for a user-provided callback that does the formatting.
Let me know if that works for you and I will tag a new release.
Thanks for the suggestions! These sort of reports will really help me add polish to the package.

that is great! thanks! this is everything I need so I think you can tag a new release if you'd like


[Flaky] test_numpy_op.test_np_einsum

Description
======================================================================

FAIL: test_numpy_op.test_np_einsum

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/usr/local/lib/python3.5/dist-packages/nose/case.py", line 198, in runTest

    self.test(*self.arg)

  File "/work/mxnet/tests/python/unittest/common.py", line 177, in test_new

    orig_test(*args, **kwargs)

  File "/work/mxnet/python/mxnet/util.py", line 315, in _with_np_shape

    return func(*args, **kwargs)

  File "/work/mxnet/python/mxnet/util.py", line 499, in _with_np_array

    return func(*args, **kwargs)

  File "/work/mxnet/tests/python/unittest/test_numpy_op.py", line 3524, in test_np_einsum

    assert_almost_equal(out_mx.asnumpy(), expected_np, rtol=rtol, atol=atol)

  File "/work/mxnet/python/mxnet/test_utils.py", line 627, in assert_almost_equal

    raise AssertionError(msg)

AssertionError:

Items are not equal:

Error 1.669922 exceeds tolerance rtol=1.000000e+00, atol=1.000000e-01 (mismatch 25.000000%).

Location of maximum error: (0, 1), a=0.24609375, b=0.02963257

 ACTUAL: array([[156.    ,   0.2461],

       [433.2   , -30.8   ]], dtype=float16)

 DESIRED: array([[156.     ,   0.02963],

       [433.2    , -30.72   ]], dtype=float16)

-------------------- >> begin captured stdout << ---------------------

*** Maximum errors for vector of size 4:  rtol=1.0, atol=0.1

  1: Error 1.669922  Location of error: (0, 1), a=0.24609375, b=0.02963257

--------------------- >> end captured stdout << ----------------------

-------------------- >> begin captured logging << --------------------

root: INFO: NumPy-shape semantics has been activated in your code. This is required for creating and manipulating scalar and zero-size tensors, which were not supported in MXNet before, as in the official NumPy library. Please DO NOT manually deactivate this semantics while using `mxnet.numpy` and `mxnet.numpy_extension` modules.

common: INFO: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1120100586 to reproduce.

--------------------- >> end captured logging << ---------------------

Occurrences
Unrelated PR - #16599
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-16599/5/pipeline
What have you tried to solve it?
Nothing

Introduced in #15911

Also happened here: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fcentos-gpu/detail/PR-16639/1/pipeline
and here: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-16639/1/pipeline

Temporarily disable the flaky tests in #16643 .

@mxnet-label-bot update [Bug, Numpy]

It's still flaky in #16555: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-16555/18/pipeline

FAIL: test_numpy_op.test_np_einsum

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/usr/local/lib/python3.5/dist-packages/nose/case.py", line 198, in runTest

    self.test(*self.arg)

  File "/work/mxnet/tests/python/unittest/common.py", line 177, in test_new

    orig_test(*args, **kwargs)

  File "/work/mxnet/python/mxnet/util.py", line 315, in _with_np_shape

    return func(*args, **kwargs)

  File "/work/mxnet/python/mxnet/util.py", line 499, in _with_np_array

    return func(*args, **kwargs)

  File "/work/mxnet/tests/python/unittest/test_numpy_op.py", line 3585, in test_np_einsum

    assert_almost_equal(grad[0][iop], grad[1][iop], rtol=rtol, atol=atol)

  File "/work/mxnet/python/mxnet/test_utils.py", line 627, in assert_almost_equal

    raise AssertionError(msg)

AssertionError:

Items are not equal:

Error 1.018927 exceeds tolerance rtol=1.000000e-03, atol=1.000000e-05 (mismatch 20.000000%).

Location of maximum error: (0, 1), a=-0.03388485, b=-0.03384018

 ACTUAL: array([[  97.04612   ,   -0.03388485, -148.55832   ,  -86.593506  ,

         -22.488245  ],

       [  97.04612   ,   -0.03388485, -148.55832   ,  -86.593506  ,...

 DESIRED: array([[  97.04615   ,   -0.03384018, -148.5583    ,  -86.5935    ,

         -22.48825   ],

       [  97.04615   ,   -0.03384018, -148.5583    ,  -86.5935    ,...

-------------------- >> begin captured stdout << ---------------------

*** Maximum errors for vector of size 25:  rtol=0.001, atol=1e-05

  1: Error 1.018927  Location of error: (0, 1), a=-0.03388485, b=-0.03384018

  2: Error 1.018927  Location of error: (1, 1), a=-0.03388485, b=-0.03384018

  3: Error 1.018927  Location of error: (2, 1), a=-0.03388485, b=-0.03384018

  4: Error 1.018927  Location of error: (3, 1), a=-0.03388485, b=-0.03384018

  5: Error 1.018927  Location of error: (4, 1), a=-0.03388485, b=-0.03384018


Wrap NuGet Pack Release Notes in CDATA

Wrap the release notes in NuGet Pack with <![CDATA[]]>. This will allow for rich release notes.

Good point! :+1:

@RichiCoder1 what exactly did you mean by this?  Was looking to clean this one up just now.
Are you referring to here:
https://github.com/cake-build/cake/blob/5426a07c672ac2c81534d4cc2883ee7e59e7277f/src/Cake.Common/Tools/NuGet/NuGetAliases.cs#L43

https://github.com/cake-build/cake/blob/5426a07c672ac2c81534d4cc2883ee7e59e7277f/src/Cake.Common/Tools/NuGet/Pack/NuspecTransformer.cs

Specifically make it so the transformer detects if the context needs to be wrapped in CData, and do so. Especially for CData which often contains arbitrary markup.

Ah, I see what you are getting add with regard to adding the CDATA attribute.
What would the criteria be for detecting whether this was required though?

Not sure about how NuGet works, but wouldn't it be OK to always wrap this in a CDATA attribute? Will it break something if it doesn't need to have a CDATA attribute?

Not that I am aware of no.  There is nothing to stop you having a CDATA attribute, but then just having standard XML contained within it, so I agree, just always put CDATA around the release notes section.
Agreed?

I'd be fine with that. Just thought it might be overkill :P

Well it's less complex doing it just one way. Also less write prone.

PR #465 fixed this.


Enable help text for child fields

Small change that will allow child fields of a JsonWrapper field to show correctly.

Hi there!  Firstly, great package - has helped us immensely, so really appreciate the work.
We noticed whilst using JsonWrapper that any help text added to a child field using the ->help() method doesn't show correctly.  Thankfully, it's a small one-line change to enable them - if you're open to accepting pull requests, we'd love it if you could merge in.
Thanks in advance,
Nathan.


brew deps fails with --formula and emits a warning without it

brew config output
HOMEBREW_VERSION: 3.5.6
ORIGIN: https://github.com/Homebrew/brew
HEAD: 0b030b74e2ac518bd0bc4158f96c449198f9957f
Last commit: 17 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 2b5709c32989ba0d1187b64a9cba039c4426cae0
Core tap last commit: 70 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_ARTIFACT_DOMAIN: http://brew.mirror
HOMEBREW_BOOTSNAP: set
HOMEBREW_CASK_OPTS: ["--no-quarantine"]
HOMEBREW_EDITOR: vi
HOMEBREW_MAKE_JOBS: 6
HOMEBREW_NO_ANALYTICS: set
HOMEBREW_NO_AUTO_UPDATE: set
HOMEBREW_NO_ENV_HINTS: set
HOMEBREW_NO_INSTALL_CLEANUP: set
Homebrew Ruby: 2.6.8 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: hexa-core 64-bit kabylake
Clang: 13.1.6 build 1316
Git: 2.37.1 => /usr/local/bin/git
Curl: 7.79.1 => /usr/bin/curl
macOS: 12.5-x86_64
CLT: <IP_ADDRESS>.1.1651278267
Xcode: 13.4.1

brew doctor output
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
<EMAIL_ADDRESS>
Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  bash-completion@2
  bash-completion

Warning: Some installed formulae are missing dependencies.
You should `brew install` the missing dependencies:
  brew install openssl@3

Run `brew missing` for more details.

Verification

[X] I ran brew update and am still able to reproduce my issue.
[X] I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?
Run brew deps --union --full-name --formula <formula-names> to generate a definitive list of dependencies for all of the formulae installed, or being installed, by a provisioning script.
Why? To identify orphaned packages. Some formulae may not be installed yet (e.g. if formulae have recently been added to the script), so brew deps --installed won't work; and some formulae installed explicitly on a previous run may have been removed from the script, so I can't rely on brew autoremove or brew leaves to identify orphans -- unless there's a mechanism to mark installed packages "installed as dependency", and no such mechanism seems to exist.
What happened (include all command output)?
I received the following output when using the command above:
Usage: brew deps [options] [formula|cask ...]

Show dependencies for formula. Additional options specific to formula may be
appended to the command. When given multiple formula arguments, show the
intersection of dependencies for each formula.

  -n                               Sort dependencies in topological order.
      --1                          Only show dependencies one level down,
                                   instead of recursing.
      --union                      Show the union of dependencies for multiple
                                   formula, instead of the intersection.
      --full-name                  List dependencies by their full name.
      --include-build              Include :build dependencies for formula.
      --include-optional           Include :optional dependencies for
                                   formula.
      --include-test               Include :test dependencies for formula
                                   (non-recursive).
      --skip-recommended           Skip :recommended dependencies for
                                   formula.
      --include-requirements       Include requirements in addition to
                                   dependencies for formula.
      --tree                       Show dependencies as a tree. When given
                                   multiple formula arguments, show individual
                                   trees for each formula.
      --graph                      Show dependencies as a directed graph.
      --dot                        Show text-based graph description in DOT
                                   format.
      --annotate                   Mark any build, test, optional, or
                                   recommended dependencies as such in the
                                   output.
      --installed                  List dependencies for formulae that are
                                   currently installed. If formula is
                                   specified, list only its dependencies that
                                   are currently installed.
      --all                        List dependencies for all available formulae.
      --for-each                   Switch into the mode used by the --all
                                   option, but only list dependencies for each
                                   provided formula, one formula per line.
                                   This is used for debugging the
                                   --installed/--all display mode.
      --formula, --formulae        Treat all named arguments as formulae.
      --cask, --casks              Treat all named arguments as casks.
  -d, --debug                      Display any debugging information.
  -q, --quiet                      Make some output more quiet.
  -v, --verbose                    Make some output more verbose.
  -h, --help                       Show this message.

Error: Invalid usage: `--formula` cannot be passed without `--installed`.

After removing the --formula option (because --installed would generate incomplete output, as explained above), I got the following (truncated for brevity; the formula list isn't a concern):
Warning: Treating flock as a formula. For the cask, use homebrew/cask/flock
Warning: Treating unison as a formula. For the cask, use homebrew/cask/unison
Warning: Treating cmake as a formula. For the cask, use homebrew/cask/cmake
adwaita-icon-theme
aom
apr
apr-util
argon2
aspell
atk
augeas
autoconf
bdw-gc
brotli
c-ares
ca-certificates
cairo
cjson
cmocka
coreutils
cpio
cunit
...

Given formula and cask names are both volatile, running the command without --formula is problematic regardless, but the fact that it generates a warning for any conflicts is irreconcilable with its refusal to run with --formula.
What did you expect to happen?
A list of formulae should have been output, with no warnings.
My current workaround (for this long-standing issue) is to recursively process JSON output from brew info with jq, but this is slow and (very) inefficient. A reliable brew deps command would be far better.

Are you interested in this list of orphans for informational purposes only, or is there something specific you wish to do with orphaned formulae?

By orphans, do you mean formulae installed as dependencies but no longer needed (because all their dependents are no longer installed)?

 For the purposes of my provisioning script, orphans include formulae installed explicitly in a previous run (or directly via brew install) but not currently appearing in a list of required formulae, along with any dependencies that would be orphaned after their removal. Unfortunately it's not possible (as best I can tell) for Homebrew's state to be updated to reflect the formulae I'm keeping / not keeping (i.e. something equivalent to pacman -D --asexplicit/pacman -D --asdeps on Arch Linux, or apt-mark auto/apt-mark manual on Debian/Ubuntu), so I'm left with manually enumerating the required formulae and their dependencies and comparing it with installed formulae to determine which formulae will be orphaned after installing any new formulae. (Part of the objective is to make provisioning a one-step process--i.e. decide what's being installed and removed before actioning anything).

Are you interested in this list of orphans for informational purposes only, or is there something specific you wish to do with orphaned formulae?

My provisioning script offers to remove them.

Does your provisioning script use brew bundle?

I looked into moving to brew bundle recently, but it's more prescriptive than what I'm currently using and is better suited to CI environments (rather than system-wide provisioning with platform- and configuration-specific variations). TL;DR: no, I'm not using brew bundle.
Anyway, interesting as all of this may be, my particular use case has limited relevance to making brew deps reliable, effective and consistent for all users 😉

Just checking in on this. Setting my particular use case aside, is there any consensus that it should be possible to run brew deps --union --full-name --formula <formula-names> to recurse into the given formulae--irrespective of what is or isn't currently installed--and produce a fully resolved list of every dependency of the given formulae? (As I understand it, the same calculation would already be performed if I were to pass the same list to brew install --formula on a clean system -- it's a pretty fundamental question for a package manager to be able to answer.)
I can only assume from the way brew deps requires --installed if --formula is used, despite apparently working as expected without --formula -- aside from the cask warnings -- that I'm missing something about the way Homebrew dependency resolution accommodates both formulae and casks, because these constraints don't make immediate sense (albeit without code diving).

We'll review PRs to improve this behaviour but we're not considering this a bug for maintainers to address at this time because it's unclear that it is something people other than you care about just now. Sorry!

No worries, thanks for the response :)

One workaround is to adjust your provisioning script to prepend the tap name to each formula name, which would obviate the need for --formula, e.g.:
$ brew deps --union --full-name homebrew/core/flock homebrew/core/icdiff homebrew/core/jc homebrew/core/jq homebrew/core/newt homebrew/core/pv homebrew/core/python-yq homebrew/core/rsync homebrew/core/trash
ca-certificates
gdbm
gettext
jq
libffi
libpng
lz4
mpdecimal
oniguruma
<EMAIL_ADDRESS>popt
<EMAIL_ADDRESS>readline
s-lang
sqlite
xxhash
xz
zstd


Attention please,EnumProcessModules fail may cause infinite loop

when i use tcmalloc,I found a fatal bug in function PatchAllModules,in my own project,link libtcmalloc,encountered a  dead loop problem, so I generated a full dmp file,after my analyzing,then i located here:
once EnumProcessModules fail,when next  time to execute PatchAllModules,if this api call successfully,will lead to double patching,then lead to dead loop finally！（perftools_free<1> jmp to perftools_free<0>,but perftools_free<0> jmp back to perftools_free<1>）
this bug often appears!!!   and you can reappear it by making the EnumProcessModules call fail manually
if not,you can get the dmp file here: http://pan.baidu.com/s/1kTAhEjd
i have made a pull request,attention please
sorry,my english is not good,can you get it? thanks

Hi. Sorry for delay. I don't quite understand the problem. Why would EnumProcessModules fail?
Also why PatchAllModules is invoked several times?

@alk ,i have modified #ifndef WIN32, please merge.  EnumProcessModules fail,because api hook or system  module is corrupted
PatchAllModules  is invoked when new dll is loaded into process

@alk tcmalloc's patch is not thread safe,attention please! such as patch to malloc,free,etc.

I still don't quite understand the problem. Can you please post little test program where problem can be clearly seen?

hi,@alk
EnumProcessModules is a windows api. if this api is patched by some application,and return false. then, when a new module load next time, PatchAllModules will be invoked again, and it call EnumProcessModules , if
EnumProcessModules return true this time, this problem reappears!
i can't write a demo,beacuse this happens only when  EnumProcessModules fails first time  and succ next time. i have a dmp file, can  you download it?

I am not eager to do defensive coding against someone breaking windows api. If that is "bug", then sorry but no, I won't take this patch.

also,if the system dll file is damaged, can result in this problem
the dmp file i uploaded, is  this case

Closing the ticket as "won't fix". I see no reason to try to defensive-code around broken api. There are billions of various ways how someone can break some api(s) and there is no way we can guard against that.
So "broken api" -> "all bets are off".

another problem:
@alk tcmalloc's patch is not thread safe,attention please! such as patch to malloc,free,etc.
which version will fix this bug?

Locking looks semi-plausible in this code. Can you elaborate where it is not thread safe ? Separate ticket and example program would be most helpful.

i have a crash dmp file.
when a thread is  execute free function,  another thread is patching free function,the head of this function is changed to be a  jmp instruction. when the first byte of the function is modified to be 0xe9,but the remaining operand is still unchanged, if thread switchs at this moment, then another thread will jmp to a invalid address, then crash..

I'll need test program that hits this issue. Is it possible that you might be loading .dll that is linked to tcmalloc at runtime? That could explain why tcmalloc might be patching something when there is another thread running. If so, try linking tcmalloc to your main program, as supporting a case when tcmalloc suddenly needs to patch malloc/free in running process is impossible.


Fix a missing markdown syntax to enable external link

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address.  Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at<EMAIL_ADDRESS>

CLA signed.

/assign @pjhwa

@gurrpi 컨트리뷰션 감사합니다!
타겟 브랜치를 master 가 아닌 dev-1.18-ko.8 로 변경해주시기 바랍니다.
dev-1.18-ko.8에서 fix하고 금주안에 master로 merge 하면 될 것 같습니다.

@pjhwa 타겟 브랜치 변경하였습니다.
소스 브랜치 리베이스 하는 도중에 붙은 엉뚱한 label들이 몇개있네요..:)

/remove-language de
/remove-language en
/remove-language es
/remove-language id
/remove-language ja
/remove-language pt
/remove-language ru
/remove-language zh

감사합니다!
/lgtm

/approve


CI against Ruby 2.6.0

Summary
CI against Ruby 2.6.0.
Details
Ruby 2.6.0 has been released and this Ruby version is available on CircleCI.

https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released/
https://hub.docker.com/r/circleci/ruby/tags/

Checklist:

[ ] I've added tests for my code
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Oops! I updated this PR.

Are these failing because of the other PR around BigDecimal.new? Or something else?
Have you had time to triage @koic ?

This build error:
An error occurred while loading ./spec/cucumber/cli/configuration_spec.rb.
Failure/Error: require 'gherkin/gherkin'

LoadError:
  cannot load such file -- google/protobuf_c

Seems like all of them are about that.

In order to move forward, I made an experimental addition to this PR: run the gem install as described in the Description of https://github.com/protocolbuffers/protobuf/issues/5161
That did not work, yet. I'm sorry about moving too quickly,

@koic If you add a new gem requirement of: gem 'google-protobuf', '~> 3.7.0.rc.2' this should in theory start passing.
If you've got time do you want to give that a go?

Yep! I will try it.

Unfortunately the following error occurred when running bundle update.
% bundle update cucumber-messages
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Bundler could not find compatible versions for gem "google-protobuf":
  In Gemfile:
    google-protobuf (~> 3.7.0.rc.2)

    cucumber was resolved to 4.0.0.rc.1, which depends on
      gherkin (~> 6.0) was resolved to 6.0.15, which depends on
        cucumber-messages (~> 2.0.0) was resolved to 2.0.0, which depends on
          google-protobuf (= 3.6.1)

First of all, the dependency needs to be resolved.
cucumber-formatter-dots 1.1.2 (latest) requires cucumber-messages ~> 2.0.0.
https://rubygems.org/gems/cucumber-formatter-dots/versions/1.1.2
cucumber-messages 2.0.0 requires google-protobuf = 3.6.1.
https://rubygems.org/gems/cucumber-messages/versions/2.0.0
Each version needs to be bumped. I will open PR to cucumber-messages repo and cucumber-formatter-dots repo for resolving dependencies.

The cucumber-messages gem release is required to resolve dependencies of cucumber-messages to google-protobuf. It has already been fixed in the cucumber-messages repo code base.
https://github.com/cucumber/cucumber/issues/571#issuecomment-470520483

Also cucumber-formatter-dots gem will wait for release as well.

The messages fix has been applied. This should automatically pull through

Superseded by #1346


Implement macro-hygiene and general improvements

@daxpedda I did the name:Ident I think that improves readability a bit, as the to_string actually happens where it is used.

Let's merge this!


runtime: reenable bad pointer check in GC

runtime/mbitmap.go says:
	// The following ensures that we are rigorous about what data
	// structures hold valid pointers.
	// TODO(rsc): Check if this still happens.
	if false {
		// Still happens sometimes.
We broke a lot of programs in Go 1.4 by insisting on this
(for good reasons), and we don't want relapses during Go 1.5.

Duplicate of #9880.


the network filter in examples/golang-network/simple/filter.go have circular reference

Golang finalizers don't work with circular references, so it should be addressed.
Originally posted by @spacewander in https://github.com/envoyproxy/envoy/pull/30209#pullrequestreview-1678115356

/assign @antJack

@antJack Do you have time to fix it?

I was trying examples/golang-network/ today and did a tcpdump, looks after envoy git response from upstream (tcp echo service), it didn't send any data to nc client and client just hang there. Not sure if it's related to this?
Thanks!

@antJack Do you have time to fix it?

ok, let me fix it

I was trying examples/golang-network/ today and did a tcpdump, looks after envoy got response from upstream (tcp echo service), it didn't send any data to nc client and client just hang there. Not sure if it's related to this? Thanks!

It should be unrelated to this issue. Can you provide a reproducible way for your problem? it should be ok for nc since the example's verify.sh just use nc and run normally.

Yeah, I was following exactly examples/golang-network/verify.sh and it did passed.
But the issue is a missing test case in verify.sh: the upstream echo service did get "hello world" from envoy side, but the nc client didn't get any response from envoy..
To reproduce:
cd examples/golang-network
docker compose -f docker-compose-go.yaml run --rm go_plugin_compile
docker compose up --build -d

nc localhost 10000
type "world"   <=== hanging there and tcp dump shows no response sent from enoy to nc client, expect "hello world" shows up I guess?

in verify.sh
run_log "Send tcp data handled by the Go plugin"
echo -n "world" | nc -w1 <IP_ADDRESS> "${PORT_PROXY}"

run_log "Check echo server log"
"${DOCKER_COMPOSE[@]}" logs echo_service | grep "hello, world"   <=== it only checks upstream server get the appened "hello" from envoy, but not the nc client..

Thanks @antJack, will this also fix the above issue?

Thanks @antJack, will this also fix the above issue?

Yes, I also try to fix it.


Majestic IRCUT: Push-pull mode required

My IPCAM requires that the IRCUT lines be the inverse of each other.  The current behavior is that they are only the inverse of each other for a small amount of time, before they are both set to 0:
majestic[817]: Change mode to DAY
majestic[817]: set_gpio(54, 0)
majestic[817]: set_gpio(53, 1)
majestic[817]: set_gpio(54, 0)
majestic[817]: set_gpio(53, 0)

majestic[817]: Change mode to NIGHT
majestic[817]: set_gpio(54, 1)
majestic[817]: set_gpio(53, 0)
majestic[817]: set_gpio(54, 0)
majestic[817]: set_gpio(53, 0)

I can stop the noise by manually setting the appropriate GPIO:
echo 1 >/sys/class/gpio/gpio54/value

Could we please have a way to suppress the clearing of the IRCUT GPIOs?

In the meantime, here is a patch that users can apply to the binary to disable clearing the IRCUT lines.
It NOPs out the call to schedule that clears the IRCUT lines after a delay.
To create it, I opened the binary in Ghidra, and searched for GPIO. Once I found the variables that I believed held the GPIO numbers (those were used in a printf to /sys/class/gpio), I renamed them to IRCUT1 & IRCUT2, then searched for references to them. I found a call that wrote an argument to them, which I renamed write_gpio, and then looked for references to that. From there, I found a function that set both IRCUTs to 0. I renamed that to clear_ircut, and looked for references to it. There was only one, so I replaced that with a NOP and confirmed it works.
majestic[817]: Change mode to NIGHT
majestic[817]: set_gpio(54, 1)
majestic[817]: set_gpio(53, 0)
majestic[817]: Change mode to DAY
majestic[817]: set_gpio(54, 0)
majestic[817]: set_gpio(53, 1)
majestic[817]: Change mode to NIGHT
majestic[817]: set_gpio(54, 1)
majestic[817]: set_gpio(53, 0)
majestic[817]: Change mode to DAY
majestic[817]: set_gpio(54, 0)
majestic[817]: set_gpio(53, 1)

majestic-master+11648f1-dont_clear_ircut.bspatch.gz

Monitoring the power usage of the camera shows that with one side high all the time, there is a significant increase in power consumption, and the lens gets pretty warm, so this request is incorrect and should be ignored.
I'll have to figure out why there is audible sound from the camera when both IRCUT lines are at 0.


[HIVEMALL-19] Support DIMSUM for approx all-pairs similarity

What changes were proposed in this pull request?
myui/hivemall#362
Support DIMSUM, Dimension Independent Matrix Square using MapReduce, for approximated all-pairs similarity computation. It makes item-based CF more efficient.

Article in Twitter's blog
DIMSUM paper (see Alg. 5)

slides and video

Spark DIMSUM implementation

What type of PR is it?
Feature
What is the Jira issue?

https://issues.apache.org/jira/browse/HIVEMALL-19

How was this patch tested?

Unit tests
Manual tests on EMR

TODO

[x] Documentation
[x] Evaluate on larger data e.g. MovieLens

Coverage increased (+0.4%) to 39.057% when pulling b42b65b1cb358a89cd402f90b5ec3d6c79ff465c on takuti:DIMSUM into 10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master.

Coverage increased (+0.4%) to 39.105% when pulling e96d860de3f11f31dae9cb8171658e4d0be7482b on takuti:DIMSUM into 10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master.

Coverage increased (+0.4%) to 39.105% when pulling e96d860de3f11f31dae9cb8171658e4d0be7482b on takuti:DIMSUM into 10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master.

Coverage increased (+0.4%) to 39.107% when pulling c4c4e8c67b93a572f4ee00fd80b5265079f803a9 on takuti:DIMSUM into 10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master.

Coverage increased (+0.4%) to 39.114% when pulling c4c4e8c67b93a572f4ee00fd80b5265079f803a9 on takuti:DIMSUM into 10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master.

Coverage increased (+0.4%) to 39.114% when pulling c4c4e8c67b93a572f4ee00fd80b5265079f803a9 on takuti:DIMSUM into 10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master.

Coverage increased (+0.4%) to 39.114% when pulling c4c4e8c67b93a572f4ee00fd80b5265079f803a9 on takuti:DIMSUM into 10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master.

@myui I've created a new utility method doubleValue(Double v, double defaultValue in hivemall.utils.lang.Primitives. If here is not an appropriate class, plz let me know.

Coverage increased (+0.4%) to 39.519% when pulling 02b1290702cd94487c53ac8a14c5d5a985f8f17f on takuti:DIMSUM into 1dac1a62fbf35848deca8f0a8aa96f01dc1c0f2d on apache:master.

LGTM. merged!
It's better to have a tutorial that uses Movielens dataset for dimsum.

@myui Thanks. Created a new issue: https://issues.apache.org/jira/browse/HIVEMALL-113


Change Mime to MediaType

This is a WIP: will only be merged after other semver-major changes, and will likely have conflicts then.
This PR renames the mime module to media_type, the Mime struct to MediaType, any associated functions with "mime" in their name to "media_type", any mime fields to media_type, and all related docs have also changed.
Fixes #251.
This is my first PR for http-types. Let me know if anything else is needed of me.

@brightly-salty thanks so much for this PR. We'll indeed have to wait to merge this until we're ready for a 3.0 (which may be soon-ish actually). But it appears some of the comments have been caught in the diff too: "Mime type" in docs should probably be rename to "media type". Currently some examples appear to be "MediaType type" and "media_type type". If you could do another pass to update the comments, that'd be :100:

Converted to draft so we don't actually merge it. But there already appear to be merge conflicts. These don't need to be resolved straight away, but it's probably worth pointing out regardless.
In terms of timing for an http-types 3.0 release; we're having a meeting early next year with the core team to determine the schedule for that. Having all this work already ready to be merged is a huge boon and gives us confidence we'll be able to make this release happen sooner rather than later. Thank you!


URL encode the  query parameter in the itms-services: URLs

URL encode the  query parameter in the itms-services: URLs, in case they contain any special characters.

@fhickman Looks like this also has the changes from #12 in it?

Thanks for this!

@joshdholtz Doh, you're right about that... sorry, bad branch management on my part.
Thanks for the merge!


Set CHUID is much harder with .NET SDK than with yubico-piv-tool

With yubico-piv-tool, changing CHID was a matter of running:
yubico-piv-tool --key= -a set-chuid
NOTE: one does not need to supply chuid, yubico-piv-tool just creates random data for us.
with .NET SDK, I don't see high level API to achieve the same result. I need construct encoded CHUID data to feed it to
PutDataCommand(PivDataTag.Chuid, ...)
Issue 2:
When I set CHUID with yubico-piv-tool and then retrieve it with GetDataCommand(PivDataTag.Chuid), I get back 59 bytes of data that starts with { 0x30, 0x19, ... }
However, when I set CHUID with
PutDataCommand(PivDataTag.Chuid, ...)
and then retrieve it with
GetDataCommand(PivDataTag.Chuid)
I get back 61 bytes that start with
{ 0x53, 0x3B, 0x30, 0x19, ... }
basically, it returns me the data along with the data prefix ( PivPutDataTag and length of the payload). Am I doing something wrong or is there a bug in one of them?

@gnida-rada @nadcraker I just wanted to circle back and make you both aware that we added APIs for creating/managing common PIV objects in 1.3.0. Thanks for your feedback, and I hope this new feature works well for you.
https://docs.yubico.com/yesdk/yubikey-api/Yubico.YubiKey.Piv.Objects.CardholderUniqueId.html
https://docs.yubico.com/yesdk/yubikey-api/Yubico.YubiKey.Piv.Objects.CardCapabilityContainer.html

@GregDomzalski Yes! I saw the 1.3.0 update and have already been playing with the code. Thanks a lot for this. It makes my job easier. Do you have a roadmap yet for the toolkit? I would be interested to see what plans you have for it in the future.


Setting ScrollViewer Offset stops ability of ScrollViewer to scroll.

Added code to make sure ScrollViewer always scrolled to the bottom when the content of its child TextBlock changed. Invoking the event handler seems to stop the user from being able to scroll the ScrollViewer via the UI.
MainWindow.xaml.cs:
            var tbRaw = this.Get<TextBlock>("tbRawOutput");
            tbRaw.PropertyChanged += (s,e) => {
                var svRaw = this.Get<ScrollViewer>("svRawOutput");
                svRaw.Offset = new Vector(svRaw.Offset.X, svRaw.Extent.Height -svRaw.Viewport.Height);
            };

MainWindow.xaml:
<ScrollViewer Width="880" Name="svRawOutput" VerticalContentAlignment="Bottom">
	<TextBlock Classes="Code" Name="tbRawOutput" Text="{Binding RawOutput}" HorizontalAlignment="Left" VerticalAlignment="Bottom" />
</ScrollViewer>

code.

This is because you're setting the offset of the ScrollViewer whenever any property on the TextBlock changes. This causes the offset to be set when the TextBlock is repositioned by the ScrollViewer by setting Bounds, effectively undoing the scroll.
You need to fix the PropertyChanged handler to only listen for changes in the TextBlock.Text property.
Closing this as it appears not to be an Avalonia problem.


Update landscape.yml - Missing Wasm items

Added missing WebAssembly items
The Wasm Landscape was missing some important Wasm items, this PR updates them.
Pre-submission checklist:
Please check each of these after submitting your pull request:

[x]  Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x]  Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x]  Have you picked the single best (existing) category for your project?
[x]  Does it follow the other guidelines from the new entries section?
[x]  Have you added your SVG to hosted_logos and referenced it there?
[x]  Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x]  Does your project/product name match the text on the logo?
[x]  Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x]  ~30 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

LGTM

Thanks @syrusakbary


Installing outdated version

When i run deno install -A -f --unstable https://deno.land/x/vno/install/vno.tsalways install the version 1.3.1 instead of the latest version.

It seems that info.ts contains a hard coded version.
You likely are using the latest version but since that file isn't updated you'd still see it as 1.3.1.
I tried with running deno install -A -f --unstable<EMAIL_ADDRESS>that specifically loads the 1.4.5 version and it shows 1.3.1 due to its non-changing nature.

Updated the cli in #128. Thanks!


New Feature: Button To Toggle Button OR Filter To Button

Hello,
First of all, what a wonderful, easy-to-use program! I'm really surprised this has been overlooked. I'm trying to find a way to make a toggle action for some of my buttons. (Using the JoyCon control stick button to toggle Sneak in Minecraft)
I've considered several ways to program this in. Like if there was a Toggle action in the Button to Button Modifier (or any modifier with a Button Input). Or, since there already is a Toggle in the Button to Filter mapping, just make a Filter to Button Modifier.
In the meantime, I will have to use a shoulder button that I can press with a second finger to enable the action. I tried mapping the JoyCon button to Caps Lock then Caps Lock to Left Shift, but that didn't work, likely because emulated input can't map to emulated output OR the game only senses when the Caps Lock key is pressed but not when Caps Lock is active. Two other features to potentially look at.

This should be implemented as a plugin, I do not think it is possible at the moment

I need this as well.
Seems like mapping an axis to arrow keys does not work. When I move the axis a new event is sent, but keeping it stable, it seems like the key is no longer pressed.
Tried to emulate arrow keys, then just shift key. I need to move the axis (rudders) to make the keyboard think the key is still down. So I want it to think they key is down until it moves out of the zone. Or some other ways to hold a virtual key down that  can hold down a keyboard key.


In KHR_materials_pbrSpecularGlossiness, problem with vertex color

If vertex color with KHR_materials_pbrSpecularGlossiness, problem with nodetree.
principled is not defined

Merge with blender 2.8 repo


Add support for using g_autoptr with graphene types

Proposed changes:

add g_autoptr(graphene_$TYPE_t) support

This is handy when writing an application.

To be honest, if you're writing a C application I'd recommend to use Graphene types on the stack instead of using the heap; using g_autoptr works only if you're copying data from out of properties or signals.

Yes.
In my use-case I have a GList of points so I wanted to use a g_autolist(graphene_point_t) my_list

I'm sorry to say, but a linked list of points is probably the most inefficient way you could find. I'd recommend a GArray, if you wanted to have the equivalent of a resizing C array of graphene_point_t.
Having said that, I don't have any particular objections to this pull request.


Can I get player profile picture?

I have a need in getting player pictures. Can i get those via DemoParser?
I can use Steam API and SteamID from parser but would be easier if they are already parsed.
I realy like the library. Great work

You can get the players 64-bit Steam ID with CCSPlayerController.PlayerInfo.Steamid. Once you have that, you can pull the avatar URL with Steam's web APIs: https://developer.valvesoftware.com/wiki/Steam_Web_API#GetPlayerSummaries_.28v0002.29
Hope that helps


Look into using the VIN for fingerprint caching

Quicker fingerprinting times will become more important as more queries are added to support FW fingerprinting for all cars and as startup times go down. Right now, we fingerprint on the first drive after booting, then cache that for subsequent drives but discard the cache on boot. Instead, we'd like to keep the cache around until the VIN changes.

An alternative is send tester present to all ecus and the list of addrs that respond should tell you the vehicle manufacturer (then only run fingerprinting for a single manufacturer).  Detecting VIN change is simpler, but firmware changes will no longer be detected (ensuring the interface to the car had not changed).

Think this came up in the meeting as well, but we have to be careful to not cache these results forever. Any changes/breakage in the fingerprinting code wouldn't be discovered for quite a while.

Closing as this doesn't need to be an issue. This is already the obvious thing to look into once fingerprinting is enough of a concern for startup time.


Updated MAINTAINERS.md

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

We haven't heard from @Rexford74 in a couple or more weeks. Removing maintainer nomination for now.

@nebula-aac a reference to / the availability of eslint... https://github.com/layer5io/sistent/actions/runs/6923026359/job/18830433928?pr=339#step:5:12


Update: LIST orders: /admin/orders

@chaitanya005 let me know once you have done with the changes let's merge this asap

Yes @iMagesh pushed the code please review it

@chaitanya005 have you made all the changes that we discussed yesterday?

Yes @iMagesh I pushed the code. I have changed adminLayout thing in only categories and orders screens other screens need to be changed. If required I will change in others screens as well

Yes @iMagesh I pushed the code. I have changed adminLayout thing in only categories and orders screens other screens need to be changed. If required I will change in others screens as well

Looks good, we will ask others to make changes in their component so they also learn