Added support for max session time

Summary
Fixed session max time parameter that was not passed to the server properly.
Details and comments
See https://github.com/Qiskit/qiskit-ibm-runtime/issues/1198.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 4 (50.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.008%) to 51.705%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_provider/api/rest/runtime.py
0
1
0.0%

qiskit_ibm_provider/ibm_backend.py
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.008%

Covered Lines:
3411

Relevant Lines:
6597

💛  - Coveralls


Check - Validate availability of artifact referred in TKr BOM

Currently we don't have any validation for availability of artifacts referred in TKr BOM files. This validation is simply to check the availability of all the different kinds of artifacts in the TKr BOM files in respective locations, ideally publicly, so that users can use TCE with no issues like

Container image not found
Not able to obtain OVA image from VMware Customer Connect (Related - #2598 , #2575 )
AWS / Azure VM image not found

Generally such issues are noticed only during the process of creating the cluster - midway, say, as part of E2E tests, and when users use TCE, they also see such errors very late in the process
The goal is to shift left and do checks earlier, so this could be a standalone check, decoupled from the E2E tests, which can check and validate the TKr BOM
Thanks to @navidshaikh for this great idea!
I think we could have sub tasks for this

[ ] #2598

so this could be a standalone check, decoupled from the E2E tests, which can check and validate the TKr BOM

I think this is a great idea! Would make releasing much smoother with the confidence images and other artifacts are available and ready to go

This is still relevent.


Internet Explorer: Wrong offsetParent with containers styled as tables using CSS

Hi,
with Internet Explorer 11 I ran into a problem of a wrong positioning due to wrong calculated reference positions.
I found the cause for this in the special handling of TD and TABLE-tags in getOffsetParent - the special handling wont' work on other HTML-tags styled as table-cells or tables using css.
`function getOffsetParent(element) {
...
// .offsetParent will return the closest TD or TABLE in case
// no offsetParent is present, I hate this job...
if (['TD', 'TABLE'].indexOf(offsetParent.nodeName) !== -1 && getStyleComputedProperty(offsetParent, 'position') === 'static') {
return getOffsetParent(offsetParent);
}
return offsetParent;
}
`
I solved the issue by removing the first part of the condition  - so it always goes up in the dom if position === 'static'. jQuery does the same in their implementation of offsetParent.

Thank you for your issue.
Unfortunately I can't answer to all the reported issues without a little help from you.
Please, make sure to follow the issues template when you submit a new issue, in this way I will already have all the informations needed to understand the problem and help you with it.
I'm closing this issue for now, but feel free to open a new one making sure to follow all the instructions!
Thank you for your understanding.


Kernels 2021-06-03

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test kernel-latest kernel-lts latestKernel.login latestKernel.hardened

Waiting for hardened patch updates.

Also, I'm wondering if we should remove 5.11 now that it's EOL.

Also, I'm wondering if we should remove 5.11 now that it's EOL.

Yes, please.

@Ma27 @mweinelt https://github.com/NixOS/nixpkgs/pull/125469/commits/95ae54fed869a2d4c2ba4e4412c15ff43febb328 removes 5.11 (not sure if I did it right though, so please check this out)

@GrahamcOfBorg test kernel-latest kernel-lts latestKernel.login latestKernel.hardened

@GrahamcOfBorg eval

while evaluating the attribute 'src' of the derivation 'linux-config-5.12.9' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/pkgs/stdenv/generic/make-derivation.nix:201:11:
hash '' has wrong length for hash type 'sha256'

@GrahamcOfBorg test kernel-latest kernel-lts latestKernel.login latestKernel.hardened

FYI I fixed the evaluation of the kernel-generic test in 10eab5b6b3d1d38ffd3594fa6e4be13924dafd15.


Fix close error dispatching on incorrect queue

self.event.error was being dispatched on the websocket's queue, when it should be dispatched on the queue specified by the library user.


Convert recon specs from json to yaml

The JSON format is an unending source of headaches. wdyt about switching to yaml?

:+1: from me. YAML allows comments, while JSON doesn't.


[$1000] Web - Profile - Tooltip isn’t shown while hovering over the profile picture on the Profile page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to web
Go to settings -> Profile
Hover over the Profile Picture shown

Expected Result:
Profile image should also show “ Edit Photo” in tooltip
Actual Result:
Only the cursor is changed, no tooltip is shown while hovering display picture in profile page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/227989754-12a23b0c-cd1d-4ecd-ab64-27b953791b4f.mov
https://user-images.githubusercontent.com/93399543/227989927-8588a948-dd69-493c-a896-244cdfcbd904.mp4
Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679837019643279
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01443cd71b95b39236
Upwork Job ID:<PHONE_NUMBER>401936896
Last Price Increase: 2023-04-03

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

Can confirm reported behavior. I agree that for consistency the Profile image should show an “Edit Photo” tooltip

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Profile - Tooltip isn’t shown while hovering over the profile picture on the Profile page.
What is the root cause of that problem?
Profile picture rendered via src/components/AvatarWithImagePicker.js component. At line 263 <Avatar> component not wrapped with tooltip. This is the root cause of the problem.
https://github.com/Expensify/App/blob/752ac61af9752666877bc193a3a9abee2d96adcf/src/components/AvatarWithImagePicker.js#L263-L270
What changes do you think we should make in order to solve the problem?
Within src/components/AvatarWithImagePicker.js  we have to wrap Avatar with tooltip as shown below. It will solve the problem i.e.  Shows tooltip on profile picture also.
    <Tooltip text={this.props.translate('avatarWithImagePicker.editImage')}>
        <Avatar
            containerStyles={styles.avatarLarge}
            imageStyles={[styles.avatarLarge, styles.alignSelfCenter]}
            source={this.props.source}
            fallbackIcon={this.props.fallbackIcon}
            size={this.props.size}
            type={this.props.type}
        />
    </Tooltip>

Note:  AvatarWithImagePicker also used for workspace image, so this will also solve same problem for workspace image as shown in result.
What alternative solutions did you explore? (Optional)
None
Result
https://user-images.githubusercontent.com/7823358/228321564-9f63b5a4-5e42-48ca-9bd8-a341c3996a4b.mov

Triggered auto assignment to @Beamanator (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Profile - Tooltip isn’t shown while hovering over the profile picture on the Profile page.
What is the root cause of that problem?
Profile picture rendered via src/components/AvatarWithImagePicker.js component. At line 263 <Avatar> component not wrapped with tooltip. This is the root cause of the problem.
https://github.com/Expensify/App/blob/752ac61af9752666877bc193a3a9abee2d96adcf/src/components/AvatarWithImagePicker.js#L263-L270
What changes do you think we should make in order to solve the problem?
Within src/components/AvatarWithImagePicker.js  we have to wrap Avatar with tooltip as shown below. It will solve the problem i.e.  Shows tooltip on profile picture also.
    <Tooltip text={this.props.translate('avatarWithImagePicker.editImage')}>
        <Avatar
            containerStyles={styles.avatarLarge}
            imageStyles={[styles.avatarLarge, styles.alignSelfCenter]}
            source={this.props.source}
            fallbackIcon={this.props.fallbackIcon}
            size={this.props.size}
            type={this.props.type}
        />
    </Tooltip>

Note:  AvatarWithImagePicker also used for workspace image, so this will also solve same problem for workspace image as shown in result.
What alternative solutions did you explore? (Optional)
None
Result
https://user-images.githubusercontent.com/7823358/228321564-9f63b5a4-5e42-48ca-9bd8-a341c3996a4b.mov

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Profile - Tooltip isn’t shown while hovering over the profile picture on the Profile page.
What is the root cause of that problem?
Profile picture rendered via src/components/AvatarWithImagePicker.js component. At line 263 <Avatar> component not wrapped with tooltip. This is the root cause of the problem.
https://github.com/Expensify/App/blob/752ac61af9752666877bc193a3a9abee2d96adcf/src/components/AvatarWithImagePicker.js#L263-L270
What changes do you think we should make in order to solve the problem?
Within src/components/AvatarWithImagePicker.js  we have to wrap Avatar with tooltip as shown below. It will solve the problem i.e.  Shows tooltip on profile picture also.
    <Tooltip text={this.props.translate('avatarWithImagePicker.editImage')}>
        <Avatar
            containerStyles={styles.avatarLarge}
            imageStyles={[styles.avatarLarge, styles.alignSelfCenter]}
            source={this.props.source}
            fallbackIcon={this.props.fallbackIcon}
            size={this.props.size}
            type={this.props.type}
        />
    </Tooltip>

Note:  AvatarWithImagePicker also used for workspace image, so this will also solve same problem for workspace image as shown in result.
What alternative solutions did you explore? (Optional)
None
Result
https://user-images.githubusercontent.com/7823358/228321564-9f63b5a4-5e42-48ca-9bd8-a341c3996a4b.mov

Proposal.
Issue:
Web - Profile - Tooltip isn’t shown while hovering over the profile picture on the Profile page
Solution
On src/components/AvatarWithImagePicker.js#L263. The following code should be wrapped in a Tooltip component.
<Avatar     containerStyles={styles.avatarLarge}     imageStyles={[styles.avatarLarge, styles.alignSelfCenter]}     source={this.props.source}     fallbackIcon={this.props.fallbackIcon}     size={this.props.size}     type={this.props.type} />
Similar to this:
<Tooltip absolute text={this.props.translate('avatarWithImagePicker.editImage')}>
      <Avatar
          containerStyles={styles.avatarLarge}
          imageStyles={[styles.avatarLarge, styles.alignSelfCenter]}
          source={this.props.source}
          fallbackIcon={this.props.fallbackIcon}
          size={this.props.size}
          type={this.props.type}
      />
</Tooltip>

This will fix this Issue.

📣 @Arslaan0124! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01d80e9dbf2781f98e

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@rushatgabhane dooooo you mind reviewing the proposal we've got so far? :D

heyy @Beamanator  sorry I got too distracted on finding how we placed a small circle on a big circle.

@PrashantMangukiya let's add the tooltip for default avatar as well.
@Beamanator we can work with @PrashantMangukiya's proposal
C+ reviewed 🎀 👀 🎀

📣 @PrashantMangukiya You have been assigned to this job by @Beamanator!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Applied to Job in Upwork. I will prepare and submit PR within two hours asap. Thank you everyone.

@rushatgabhane PR is ready for review. Thank you.

Reviewing label has been removed, please complete the "BugZero Checklist".

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@rushatgabhane / @Beamanator] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@rushatgabhane / @Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@rushatgabhane / @Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@sonialiap] Determine if we should create a regression test for this bug.
[ ] [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Ping for Upwork

Ping for Upwork

Ping for upwork on this

Ping for Upwork.

Bump @sonialiap mind finishing payment for this? 👍 🙏

Sorry guys, I was OOO and just got back. Processing the payments now

@sonialiap Offer accepted on Upwork. Just reminder also eligible for timeline bonus.

@PrashantMangukiya payment sent with 50% bonus for quick merge

@sonialiap Received thank you.

@rushatgabhane offer sent, waiting on you to accept

@sonialiap I'm the external reporter and haven't got paid.

Thanks for pointing that out @ashimsharma10! Could you share a screenshot of your upwork name and profile icon so that I can find you and send an offer?

@sonialiap This is my upwork :
https://www.upwork.com/freelancers/~018a92cf13e1e88eed

@sonialiap Eagerly waiting for your offer at upwork. 😩

Thanks Ashim, offer sent!

Prashant and Ashim have been paid.
Upwork, the bane of my existence. I'm not finding the offer I sent to @rushatgabhane for this one so I just sent another one https://www.upwork.com/jobs/~015ce5091a36a7566e

Let's try to get this wrapped up today? 😅 cc @sonialiap

Rushat had some bank issues so still working on getting him paid

bump :D has payment been taken care of?

@rushatgabhane payment sent with 50% bonus for quick merge 💸


Add support for spell variants of spells with a variable cast time

This enables the creation of spell variants based on cast time (like Heal) and adds a prompt to select which variant to cast.
https://user-images.githubusercontent.com/41452412/173586017-499d679d-8195-4f75-88c7-70bd819c9553.mp4
Example setup for the Heal spell with variants:

The description of the base spell can stay the same:

Add a new variant in the details tab:

Variants have their own spell sheet and can be edited independently of the base spell:

Add additional variants as needed:

The variants can be sorted via drag and drop on the spell sheet and the prompt buttons are displayed in the same order.

Is this done? I can take a look at it soonish and see how it is. Any final things you wanna look at before I start deep diving?

Is this done? I can take a look at it soonish and see how it is. Any final things you wanna look at before I start deep diving?

I still need to add a way for migrations in foundry and the packs to handle the partial variant data.
I'm also planning to add an easier way to cast a specific variant, probably by making the dialog buttons draggable to the macro bar.
Also the UI in the spell sheet could be better.
But I was waiting to see if this gets approved at all.

For the variants source data, is it possible to add a variant type in there? I'm thinking for a complete solution, we'll need to allow more than one variant type, so not locking ourselves down to only spell source data might be ideal.
So maybe something like
interface SpellOverlayOverride {
    type: "override";
    // anything else you need (like img? name?)
    data: Partial<SpellSystemData>;
}

interface SpellOverlayDamage {
    type: "damage";
    choices: DamageType[];
}

type SpellOverlay = SpellVariantOverride | SpellVariantDamage;

and then later on:
interface SpellSystemSource {
    ...
    variants: Record<string, SpellVariant>;
}

I also don't know if it'll help, but what I did when I was working on this was keep a distinction between "overlay" and "variant". A variant is the spell you are casting. Overlay is data you are using to create it, and a spell variant can be composed of one or more overlays.

I've added support for different types of spell overlay data and made it possible to merge multiple overlays in loadVariants.
The override overlay is the only one that is implemented for now, but I've added a type stub for a damage overlay.
While working on this I also realized that embedding the prepared variants is not necessary so I've removed that.
Updating the spell with with data.update() and re-rendering the sheet works fine.

So here's something that really came in handy for me when I was implementing it, which might come in handy for you.
You can try to create a new Collection subclass called SpellOverlayCollection. In the same vein that ActorInventory and ActorSpellcasting work, you can add special behavior and methods to it, which you can access via spell.overlays.create() or what-have-you.
This will allow you to reduce the number of overlay specific methods in the spell that are more "internal" to the implementation, and also allow you to create special overlay methods.


administration: notes on administration & deployment

@maciejmrowiec @mendersoftware/rndity @eysteins

This differs a little from the docs architecture plan: https://docs.google.com/document/d/1cFFiusOP8aErgcjnPgJG_0W4w2G0y7dIoZEDqBRl0nw/edit
However I find this split more intuitive than the one from google doc.

There's a plan ;) ok, i'll check it out and update the PR.

I favour your structure. @eysteins perhaps we can adjust the google doc plan?

A few minor notes:

Administration/Overview section is really good! Could have been merged immediately if it was a separate commit.

Do you use https://github.com/mendersoftware/mender-docs-site? Several places have formatting issues with warning notes (e.g. "Make sure that the certificate matches the domain name..." is split so half of sentence only is warning-formatted).

Regarding the main task (currently Administration/Deployments), it is currently too "bottom up" for the use case at hand (generate and use secure certificates everywhere). I do need to generate certs for all the services (which is in separate locations). I don't quite understand the current split. Do we need 3 different certificates (API Gateway, Minio, Token signing)? How do I generate them (only noted in Token signing)? Where do I put them on the machine that runs docker-compose (can be inferred by looking closely at the mount points)? Should I change the perms on them to make them strict? How do I make the client use the certs (it won't work otherwise)?
What I suggest for now:

Remove Administration/Deployments for now, instead:
Merge all the certificate generation and include everything (see notes above) into a tutorial-style separate section Administration/Certificates.
Split out storage into it's own section Administration/Storage (currently two headers "Storage location" and "S3 storage backend"). Also include any storage limits here (max size per artifact? max artifacts?).
Split out "Bandwidth and connection limiting" header into its own section Administration/Bandwidth.

I've updated the plan to include Storage as well, otherwise please try to follow that going forward to make sure everything is consistent: https://docs.google.com/a/cfengine.com/document/d/1cFFiusOP8aErgcjnPgJG_0W4w2G0y7dIoZEDqBRl0nw/edit?usp=sharing

Ok, i"ll update the PR to be in line with documentation plan.
I'm not convinced about Administration/Bandwidth though. It gives the impression that this applies to the whole system while it's only storage download/connection limiting. We have no means of policing device/management requests.

With current documentation plan, where do I put generating keys for token signing?

I've updated the PR to be mostly in line with the documentation plan. The only divergence is 'Token sinign section', I did not have any idea where to put it, so it's become a seprate chapter.

Thanks, I merged it and polished it a bit now.
It's available at https://docs.mender.io/Administration
I will continue to polish it - also see https://github.com/mendersoftware/integration/pull/113 and https://github.com/mendersoftware/mender-docs/pull/89.

By the way, how come the deviceauth and useradm only have private keys? How are these shared between other services for verification? Or are the resulting signatures only verified by the services themselves?

deviceauth and useradm need private keys to sign the tokens. Verification happens at the gateway, before forwarding the request to the upstream service nginx does an auth_request to either deviceauth or useradm (depending on the endpoint being accessed). Basically, the whole incoming request (sans the data obviously) gets forwarded to auth endpoint. Original headers are preserved (Authorization which carries token in our case) and 2 extra are added - X-Original-URI and X-Original-Method. When the request hits the upstream service eventually, it's already after auth verification.

OK, thanks, I will include this in the docs.
So we could have used a MAC, such as HMAC-SHA256 instead of public key crypto for these services as well? Not that important now, but this will probably be quite a lot more efficient.

Yes, we could have used HMAC but that requires you to use a shared secret. So for instance if a 3rd party wants to verify if token was issued by mender (not that there's a valid case for this atm), we'd need to have a public token verification service (we could not share the secret obviously). With RSA, we can just give them the public key.


[Multi] Auto pack downloading for missing packs

Add an autodownload feature for downloading packs when someone in multi selects charts in packs you don't have.
Currently, an message is displayed in the multi chat for players that don't have the chart, and the chartwill not be selected. The message can be instead be a prompt to download the pack by clicking on it.

Iirc the plan we (Or at least I) had wa to first add "hyperlinks" to the multi chat (Clickable bits of the text which coudl do arbitrary things). And then just have a [Download] hyperlink in the "Missing pack" msg from the server.
Autodownloading sounds fairly disruptive imo, it's not something I'd personally want. A button to easily tell the game to do it strikes me as a better solution. I'll leave this open for discussion in case people in general disagree with me.

This could partially be integrated with future single downloading. And clicking things in chat should be added before this, because obstructive prompts should not show up.


Relocate the City Range Strike button?

City Range Strike button can get hidden sometimes and it's easy enough to relocate dynamically
Before:

After:

Code to do this:
Basegame
BASE_CQUI_CityBanner_UpdateRangeStrike = CityBanner.UpdateRangeStrike;
function CityBanner.UpdateRangeStrike(self)
    -- Move the CityStrike icon and button to the top of the City bar; similar to the Sukritact Simple UI Mod (which puts it on the right)
    BASE_CQUI_CityBanner_UpdateRangeStrike(self);

    local cityBanner = self.m_Instance;
    if (cityBanner == nil) then
        return;
    end

    if (self.m_Type == BANNERTYPE_CITY_CENTER) then
        -- The standard icon has an "attachment" piece that looks like it hangs down from the City Banner
        -- Rotating it makes it look like it's attached to the part above
        -- TODO: Make this configurable?  (Where if not set, it just uses the standard location)
        cityBanner.CityAttackContainer:Rotate(180);
        cityBanner.CityAttackContainer:SetSizeVal(36,45);
        cityBanner.CityAttackContainer:SetAnchor("C,T");
        cityBanner.CityAttackContainer:SetOffsetVal(0,10);
    end
end

Expansions
BASE_CQUI_CityBanner_UpdateRangeStrike = CityBanner.UpdateRangeStrike;
function CityBanner.UpdateRangeStrike(self)
    -- Move the CityStrike icon and button to the top of the City bar; similar to the Sukritact Simple UI Mod (which puts it on the right)
    BASE_CQUI_CityBanner_UpdateRangeStrike(self);

    local cityBanner = self.m_Instance;
    if (cityBanner == nil) then
        return;
    end

    if (self.m_Type == BANNERTYPE_CITY_CENTER) then
        -- The standard icon has an "attachment" piece that looks like it hangs down from the City Banner
        -- Rotating it makes it look like it's attached to the part above
        cityBanner.CityStrike:Rotate(180);
        cityBanner.CityStrike:SetSizeVal(36,45);
        cityBanner.CityStrike:SetAnchor("C,T");
        cityBanner.CityStrike:SetOffsetVal(0,10);

        cityBanner.CityStrikeButton:SetAnchor("C,C");
        cityBanner.CityStrikeButton:SetOffsetVal(0,0);
    end
end

Why do you even wanna code this functionality in Lua? This is a control defined in .xml, so you can place it wherever you want just by changing .xml.  Maybe with some Lua adjustment, because there is an extra bar for walls. But probably can be self-adjusting by using . Tricky, but possible.
Sukritact is using Lua because he doesn't want to change .xml as it cannot be done in any other way but by copying entire file and changing what you want. CQUI has its own copy and overwrites the base file anyway, so it should be easier to do it via .xml and (maybe) a bit of Lua.

I am not married to making the change in Lua, just saw what Sukritact did and saw that the changes were easy enough to make in Lua that it is a possibility.  When I was cleaning up the code for the Seastead / CityBannerManager changes last night, I needed to stash this somewhere and creating this issue was that somewhere.
I'm happy to do the changes either way - the XML is probably the better way as it's the generally accepted method for repositioning objects around.  Doing it in Lua could mean not replacing the XML, however, I think that XML is replaced in the mod already, so...

I am fine with the XML approach. another thing that I find inconvenient with the city range attacks is that the red circle is pretty small and it takes extra time to select it. maybe increase its size? and also support r hotkey for the currently selected city to perform its range attack / bombardment.


new release to support Goland?

Just saw that you've added Goland support. Any chance of a release?

New release is coming soon. Meantime, you can use build instructions from readme and install plugin from a file if you need it ASAP.

I just uploaded v3.0.0 to JetBrains plugin registry. It may take up to 2 business day for update to be processed. Meantime you can download plugin archive from the release page v3.0.0 and install it from disk.

@Ashald 3.0.0 still excludes GoLand as a supported product. Is this intentional?

Huh, that looks like a bug for me. I test the plugin by installing it manually from disk but not from the registry. I'll look into it - thanks. Meantime, you can download zip file from releases tab and install it manually.

@Ashald any news? I can ask plugin's repository admins to mark the plugin as compatible with GoLand if you have no time for this right now. Is this ok for you?

Should be fixed now.

GoLand build 131.0+

This leads to ClassNotFoundExceptions and other problems on the runtime. Extensions your plugin uses were added in 181.4203+ builds.

Good to know - thanks.


Editor UI scales poorly on a bigger monitor (blurred UI elements, including gizmos and fonts, flickering)

Godot version
v4.2.stable.mono.official [46dc27791]
System information
Godot v4.2.stable.mono - Windows 11 23H2 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3050 Laptop GPU (NVIDIA; <IP_ADDRESS>42) - AMD Ryzen 5 5600H with Radeon Graphics (12 Threads)
Issue description
I'm using my laptop for work and connected a separate monitor for better colors and convenience. Both displays have a resolution of 1920x1080 px, but the laptop's main display is upscaled to 125%, and the second one is 100%.
On the main display, Godot's editor's GUI and all its assets are sharp, crisp, and pretty, with no complaints.
But when I move any window to the second monitor, its assets look blurry and hard to read/look at, including icons, fonts, and gizmos, with some occasional flickering once in a few seconds. Also, when maximizing a window, it would sometimes have gaps on the edges.
I was trying to set the rendering settings of the editor's font and in general, it had no helpful effect.
When I set the scale of the second monitor to 125%, all the bad effects went away, but it's not a working option for me.
Unfortunately, the video does not capture the flickering, though it seems to capture the blurriness.
https://github.com/godotengine/godot/assets/25585136/34ed5b65-bc8d-47e7-8925-67aa21d0ad3c
https://github.com/godotengine/godot/assets/25585136/0874891e-5a76-415b-a50c-1a1948b29cea
Steps to reproduce
Move a Godot window from the monitor with a 125% scale to the monitor with a 100% scale.
Minimal reproduction project
N/A

The issue disappears if I make the second monitor with 100% scaling to be my main in Windows settings.

Thanks for the report! Consolidating in https://github.com/godotengine/godot/issues/56341.


Fix the connect modal getting covered by the bottom bar

Description

On mobile devices, the Connect wallet modal shows up at the bottom of the page. It works fine when the bottom bar (address bar or control bar) is not visible. However, when the bottom bar is visible, the Connect wallet modal gets covered by the bottom bar (The bottom bar will appear on top of the modal which will make it impossible to press on any available wallets). The issue is caused by the modal overlay having a height of 100vh. Changing the height to the new dvh unit will fix the problem.
dvh unit is supported across major browsers but I still keep the height:100vh as the fallback for the old browsers

Changes

Add height: 100dvh
Remove .mobile-safari class because adding height: 100dvh will also fix the same problem on Safari.

Before:

After:

Affected browsers

Safari and Chrome on iOS, as well as other browsers that have a bottom bar.

Checklist

[x] Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
[x] Check the box that allows repo maintainers to update this PR
[x] Test locally to make sure this feature/fix works
[x] Run yarn check-all to confirm there are not any associated errors
[x] Confirm this PR passes Circle CI checks
[x] Add or update relevant information in the documentation

@mhughdo thank you for the contribution! For this update to work across frameworks all modules within the mono-repo that have @web3-onboard/core as a dep will need the core version bumped and their version bumped as well.
Can you please add this to your changes when you get a moment? Thank you!

@Adamj1232
Thank you for your reply. I've updated the description to include some screenshots.
I'm not sure about which packages use the @web3-onboard/core package so It'd be very helpful if you could tell me or help me bump the version of those packages.

@Adamj1232
Thank you for your reply. I've updated the description to include some screenshots. I'm not sure about which packages use the @web3-onboard/core package so It'd be very helpful if you could tell me or help me bump the version of those packages.

Thanks for that!
The packages that utilize and import core are the demo, react, solid & vue packages. If you could bump the core version and those package versions within those package's package.json that would be great and I can pull down and perform a thorough test.
Thanks again!

@Adamj1232
Thank you and sorry for the late response. I've bumped the version of the demo, react, solid, and vue packages. You can pull the changes and perform the test now.


Can't run tic-tac-toc

When I try to run cmd/tictactoe/main.go, I get a panic:
go: downloading github.com/golang/freetype v0.0.0-20170609003504-e2365dfdc4a0
go: downloading golang.org/x/image v0.0.0-20201208152932-35266b937fa6
go: downloading gorgonia.org/gorgonia v0.9.17-0.20210124090702-531c6df2c434
go: downloading gorgonia.org/tensor v0.9.18
go: downloading github.com/chewxy/math32 v1.0.6
go: downloading gorgonia.org/vecf32 v0.9.0
go: downloading github.com/awalterschulze/gographviz v2.0.3+incompatible
go: downloading github.com/apache/arrow/go/arrow v0.0.0-20210105145422-88aaea5262db
go: downloading github.com/chewxy/hm v1.0.0
go: downloading go4.org/unsafe/assume-no-moving-gc v0.0.0-20201222180813-1025295fd063
go: downloading github.com/google/flatbuffers v1.12.0
go: downloading gonum.org/v1/gonum v0.8.2
go: downloading gorgonia.org/vecf64 v0.9.0
go: downloading github.com/leesper/go_rng v0.0.0-20190531154944-a612b043e353
go: downloading github.com/xtgo/set v1.0.0
go: downloading gorgonia.org/dawson v1.2.0
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/golang/protobuf v1.4.3
go: downloading golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: downloading google.golang.org/protobuf v1.25.0
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.18 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.18 set. Notably, if go1.18 adds a moving garbage collector, this program is unsafe to use.
goroutine 1 [running]:
go4.org/unsafe/assume-no-moving-gc.init.0()
/home/haze/go/pkg/mod/go4.org/unsafe/assume-no-moving-gc@v0.0.0-20201222180813-1025295fd063/untested.go:24 +0x1f4
exit status 2

The same problem. Solution is update:
go get -u go4.org/unsafe/assume-no-moving-gc


Mafia (2002)

Reported by @Xaero#6686 in LGD.
Game_d3d9.log
d3d8.log empty. Gonna need to get an apitrace or something.

steam-40990.log

Game doesn't want to launch with apitrace 😢
Also not on windows

Reported working by esdras.


[INFINITY-2085] Update Docs: Default Executor does not support Absolute Path for Secrets

After switching to Default Executor, Absolute Path support for Secrets (supported only if there is a docker image) is dropped. All Secret files are relative to the SANDBOX.

Ping @sascala


Fix notes in trap counts below zero

Fixes #37
Update the 'Notes in Trap' field to restrict its value between 0 and 3.

Modify config/2024/config.json to set the min property of the 'Notes in Trap' field to 0 and add a max property with a value of 3.

Sorry we didn't get this in.  We're getting ready for 2025 and will close this.


Using WAT in Godot 3.3.3

Hello,
I was using - successfully - WAT on Godot 3.3.3, and after adding a new unit test to my tests folder, I am getting this error when I try to run the tests:
D:\Sandboxes\Godot_v3.3.3-stable_win64.exe .\addons\WAT\cli.tscn run=all
ERROR: Could not create directory: res://logs
   At: core/os/dir_access.cpp:184
Godot Engine v3.3.3.stable.official.b973f997f - https://godotengine.org
OpenGL ES 3.0 Renderer: NVIDIA GeForce GTX 1080/PCIe/SSE2
OpenGL ES Batching: ON

ERROR: call: Invalid Argument
   At: modules/gdscript/gdscript_functions.cpp:803

Process finished with exit code 0

How can I diagnose the causes for this? The User Interface is unresponsive (e.g. I click on the "run tests" buttons and nothing happens). The main scene of the project, using the classes in the tests, is being run by the editor without issues.

What version of WAT are you using (newest release?)
Go to addons/WAT, click gui, run that as a scene with F6, then the debugger will trigger for more info.

Cheers @AlexDarigan for the quick response. Here's the version as reported by the editor user interface (5)

Go to addons/WAT, click gui, run that as a scene with F6, then the debugger will trigger for more info.

Interesting - if I run the gui scene directly WAT runs my test without (unexpected) problems.

Tests refer to Scripts in the command line. Not the total test methods. I should probably add that clarification.

Your currently installed version is 6 right?

Hi there,

Your currently installed version is 6 right?

Yep.
I did a clean reinstall - turn off plugin, delete local files under addons, shut down editor, re-download, re-install. reboot editor - just in case. And now it works.

Tests refer to Scripts in the command line. Not the total test methods. I should probably add that clarification.

Cool, that was a bit confusing :) Now I realise that the tab that opens when the GUI runs the tests reads "( 2 / 2 ) res://tests".
Thanks very much for your help.

It seems the old files weren't overwritten properly. This was an issue with the root directory where if it was root it would only run all tests in subdirectories but not its own top level tests due to a bad if statement on my part.
Seems like a clean install is the only way to really fix this issue.

Cheers @AlexDarigan, I appreciate the further comments. And thank you very much for coming up with WAT, an essential tool!


UI splitpanes sizes are no longer persisted to local storage

Describe the bug
It seems that there was a regression of https://github.com/vitest-dev/vitest/pull/5166

vitest --ui
Resize splitpanes on the left
reload page
the left pane resets to the default size

I think that the initOnMounted option no longer takes effect since they were moved outside of a component. Maybe they should be exposed as functions instead of variables const useDetailsSizes = () => useLocalStorage(...)
Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-enxjhj?file=README.md&initialPath=__vitest__/
(default repro, might have outdated deps but I tested locally too)
System Info
na

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I guess we need to split logic for ui and browser ui: right now using mainSizes on UI when we should use detailsSizes (in the new UI there is no details, the middle panel has been removed)

Check the video, it is working again: https://streamable.com/8tzfxh


cmd/webui: add a button to support JSON -> ACH conversions

Codecov Report

Merging #896 (48c3e7f) into master (69cba21) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   91.75%   91.75%
=======================================
  Files          66       66
  Lines        5169     5169
=======================================
  Hits         4743     4743
  Misses        259      259
  Partials      167      167


Implements Scanner type for tokenizing nginx configs

Proposed changes
Implemented crossplane.Scanner that follows the example of other "scanner" types implemented in the Go stdlib. The existing Lex uses concurrency to make tokens available to the caller while managing "state". I think this design queue was taken from Rob Pike's 2011 talk on Lexical Scanning in Go. If you look at examples from the Go stdlib-- such as bufio.Scanner that Lex depends on-- you'd find that this isn't the strategy being employed and instead there is a struct that manages the state of the scanner and a method that used by the caller to advance the scanner to obtain tokens.
After a bit of Internet archeology, I found this post on golang-nuts from Rob Pike himself:

That talk was about a lexer, but the deeper purpose was to demonstrate how concurrency can make programs nice even without obvious parallelism in the problem. And like many such uses of concurrency, the code is pretty but not necessarily fast.
I think it's a fine approach to a lexer if you don't care about performance. It is significantly slower than some other approaches but is very easy to adapt. I used it in ivy, for example, but just so you know, I'm probably going to replace the one in ivy with a more traditional model to avoid some issues with the lexer accessing global state. You don't care about that for your application, I'm sure.
So: It's pretty and nice to work on, but you'd probably not choose that approach for a production compiler.

An implementation of a "scanner" using the more "traditional" model-- much of the logic is the same or very close to Lex-- seems to support the above statement.
$ go test -benchmem -run=^$ -bench "^BenchmarkScan|BenchmarkLex$" github.com/nginxinc/nginx-go-crossplane -count=1 -v
goos: darwin
goarch: arm64
pkg: github.com/nginxinc/nginx-go-crossplane
BenchmarkLex
BenchmarkLex/simple
BenchmarkLex/simple-10             70982             16581 ns/op          102857 B/op         37 allocs/op
BenchmarkLex/with-comments
BenchmarkLex/with-comments-10      64125             18366 ns/op          102921 B/op         43 allocs/op
BenchmarkLex/messy
BenchmarkLex/messy-10              28171             42697 ns/op          104208 B/op        166 allocs/op
BenchmarkLex/quote-behavior
BenchmarkLex/quote-behavior-10     83667             14154 ns/op          102768 B/op         24 allocs/op
BenchmarkLex/quoted-right-brace
BenchmarkLex/quoted-right-brace-10                 48022             24799 ns/op          103369 B/op         52 allocs/op
BenchmarkScan
BenchmarkScan/simple
BenchmarkScan/simple-10                           179712              6660 ns/op            4544 B/op         34 allocs/op
BenchmarkScan/with-comments
BenchmarkScan/with-comments-10                    133178              7628 ns/op            4608 B/op         40 allocs/op
BenchmarkScan/messy
BenchmarkScan/messy-10                             49251             24106 ns/op            5896 B/op        163 allocs/op
BenchmarkScan/quote-behavior
BenchmarkScan/quote-behavior-10                   240026              4854 ns/op            4456 B/op         21 allocs/op
BenchmarkScan/quoted-right-brace
BenchmarkScan/quoted-right-brace-10                87468             13534 ns/op            5056 B/op         49 allocs/op
PASS
ok      github.com/nginxinc/nginx-go-crossplane 13.676s

This alternative to Lex is probably a micro-optimization for many use cases. As the size and number of NGINX configurations that need to be analyzed grows, optimization can be a good thing as well as an API that feels familiar to Go developers who might use this tool for their own purposes.
Next steps:

Use Scanner to "parse" NGINX configurations. I think this should be done in place so that the existing API works as is, but we should also expose a way to allow the caller to provide the scanner.
Deprecate Lex in favor of Scanner. If we leave Lex in place then I don't think we would need a v2 of the crossplane package (yet).

Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING document
[x] If applicable, I have added tests that prove my fix is effective or that my feature works
[x] If applicable, I have checked that any relevant tests pass after adding my changes
[ ] I have updated any relevant documentation (README.md)

Now supports @xynicole's changes to enable tokenizing Lua.


fix np.load encoding issue

My environment needs this change for loading model.npz without errors.

Agree with @kdmcdrm, I am not sure about this for general cases. So I will leave this here for other's reference.


add a dir copy method that preserves filesystem attributes/permissions

I ended up writing this for a build script, so I thought I'd contribute it to JkUtilsFiles.
Java's File API can't copy filesystem attributes/permissions, but the newer NIO API can, so here's a quick utility function to copy a whole directory and keep the filesystem attributes/permissions. It's useful if you need to copy directories with executable files.
I think the NIO library might have been introduced in Java 7, so maybe you don't want to merge this right away. I think Jerkar still requiring Java 6?

Indeed, The API you use is for JDK7+
For now, Jerkar is still JDK6. I plan to jump to JDK8 soon. When done, we could replace the current JKUtilsFile.copyDir content implementation by the one you provide in order to not bloat the api.


I can't make buy order since 3 days ago...

I tried to buy SOL/USDC or RAY/USDC, HNT/USDC and everytimes I got this error message:
Error placing order
Timed out awaiting confirmation on transaction
I tried on https://dex.projectserum.com/ and I tried on different dex websites as well

This is an rpc problem. Closing.


How to add extra data in google signIn in user_metadata or even If we can add it or not

Improve documentation
Link
https://supabase.com/docs/reference/javascript/auth-signin#examples
Describe the problem
Here I can see you have described multiple options and I am using redirectTo and it is working fine but now I want to send extra data
just like in email signUp how can we do this there I can see "queryParams"  but cannot verify the use of it
Describe the improvement
detailed description of what is and use of each option and how to use it
Additional context

Might be wrong but it seems resolved  so going to close for now -- feel free to re-open if there are further issues.
Thanks!

Hey @devops-versai ! You can provide user data like this: #318
Is that what you're looking for?

Hi Kiwi is it possible to send user_metadata with Google oAuth Sign up? If so, how would you do it?. Also, I have tried to sign in and then update but I dont have the session returned yet from the first call so no avail. Any ideas ??! Thanks!

When I try to sign in as an updated Google user (with updated metadata of course) I get a 502 Bad Gateway error, is there a fix to this?


Feature/hocs 3869 noisy audit on workstack view

I'm not a huge fan of an optional audit trail in the method signature but not sure what else we can do without unpicking why somu items have their own endpoint and also need to be served as part of the stage data. Do we audit when we include a Correspondent as part of the stage data? What makes Somu special in this regard or are we just handling the two inconsistently?

I'm not a huge fan of an optional audit trail in the method signature but not sure what else we can do without unpicking why somu items have their own endpoint and also need to be served as part of the stage data. Do we audit when we include a Correspondent as part of the stage data? What makes Somu special in this regard or are we just handling the two inconsistently?

The purpose of the somu endpoints are that they are their own 'thing'. The reason it's now linked to the stage is due to being shown in some workspaces as a column. I don't actually feel like we need this audit event as the user isn't actually viewing somu items. I don't believe we audit the correspondents. We should really go back and audit our own audit logs... 🙂


Deny rewards for subgraph deployments using the new subgraph composition feature

Until the feature is ratified for indexing rewards support the subgraph-oracle should deny rewards for any deployment using it.
DataSources using this feature will have kind = subgraph.
Example
Datasource exert from manifest:
  - kind: subgraph
    name: Factory
    network: scroll
    source:
      address: 'QmdXu8byAFCGSDWsB5gMQjWr6GUvEVB7S1hemfxNuomerz'
      startBlock: 82522```

Looks like there is nothing to be done here since its based on an allowlist of data source kinds. Since we dont have the subgraph kind in the allow list of datasource kinds we will deny rewards automatically for them
https://github.com/graphprotocol/subgraph-oracle/blob/28312fd0a4895827aaa95c0f0ba151c488080e8b/availability-oracle/src/main.rs#L545-L548


does not work on Kensington SD4000 / Ubuntu 16.04 (linux 4.4 kernel)

when I installed the vendor binary it said my kernel version was not supported.
but it seemed to install the firmware and load the module OK anyways.
blacklab% lsusb
Bus 002 Device 003: ID 17e9:4344 DisplayLink
...
everything accessible throught the usb is working, but no second monitor shows up in the ubuntu prefs.
I git cloned, and built the kernel driver from source, it gave no errors, installed that .ko, and that worked fine, but no better result.  just does not show up in the display settings dialog.

I hacked it.  it´s all the distro detection stuff that is busted.  Applied the install on other distro instructions to unpacked the run thing, which gave me access to
read this: http://nothen.com.ar/en/support-for-displaylink-adapters-on-linux/
and http://support.displaylink.com/users/122401782-torsten-gilles
to notice two things:
-- there is some sort of service that is supposed to be started to enumerate virtual displays.
the provided installation script does not detect systemd, and does not install the service.
blacklab% vi displaylink-installer.sh
blacklab% sh displaylink-installer.sh
DisplayLink Linux Software 1.0.335 install script called:
displaylink-installer.sh: 367: local: (development: bad variable name
-- this is because it expects a ´lsb-release´ to be a command.  there is no such command in any repo.  so I commented out,

blacklab% vi displaylink-installer.sh
blacklab% vi displaylink-installer.sh
blacklab% lsb-release
bash: lsb-release: command not found
blacklab
blacklab% sh displaylink-installer.sh
DisplayLink Linux Software 1.0.335 install script called:
displaylink-installer.sh: 330: local: 4.4: bad variable name
blacklab% vi displaylink-installer.sh
blacklab% sh displaylink-installer.sh
DisplayLink Linux Software 1.0.335 install script called:
displaylink-installer.sh: 420: [: default: unexpected operator
displaylink-installer.sh: 423: [: default: unexpected operator
blacklab% vi displaylink-installer.sh
blacklab% bash displaylink-installer.sh
DisplayLink Linux Software 1.0.335 install script called:
blacklab% bash displaylink-installer.sh install
DisplayLink Linux Software 1.0.335 install script called: install
WARNING: Version 1.0.68 of EVDI kernel module is already running.
Please uninstall all other versions of DisplayLink Linux Software before attempting to install.
Installation terminated.
blacklab% bash displaylink-installer.sh uninstall
DisplayLink Linux Software 1.0.335 install script called: uninstall
Uninstalling
Removing EVDI from kernel tree, DKMS, and removing sources.
Stopping DLM systemd service
Failed to stop displaylink.service: Unit displaylink.service not loaded.
Failed to execute operation: No such file or directory
Removing suspend-resume hooks
Removing udev rule
Removing Core folder
Uninstallation steps complete.
Please note that the evdi kernel module is still in the memory.
A reboot is required to fully complete the uninstallation process.
blacklab% rmmod evdi
blacklab% bash displaylink-installer.sh install
DisplayLink Linux Software 1.0.335 install script called: install
Installing
Configuring EVDI DKMS module
Registering EVDI kernel module with DKMS
Building EVDI kernel module with DKMS
Installing EVDI kernel module to kernel tree
EVDI kernel module built successfully
Installing x64/DisplayLinkManager
Installing libraries
Installing firmware packages
Installing license file
Adding udev rule for DisplayLink DL-3xxx/5xxx devices
Starting DLM systemd service
Created symlink from /etc/systemd/system/graphical.target.wants/displaylink.service to /lib/systemd/system/displaylink.service.
blacklab%
as soon as the service was installed, it lit up immediately.   dunno how to modify the installer yet.
changes:
changed line 10:
SYSTEMINITDAEMON=systemd
commented out calls to detect_distro, and check_requirements, because don't need them.  (around line 400) insert # to deactivate cause of errors.
#detect_distro
#check_requirements
obviously not clean enough for a path.

OK clean enough patch, should not affect others.  Changed the default from doing nothing to assuming systemd.  since all distros derived from debian, redhat, or arch are all systemd based, it makes more sense to assume it is there than not.  Since it is the last thing to be done, if it bombs, it's no biggier anyways.
Could not find this script in the repo. don't know where it  comes from, but here is a fix.
*** displaylink-driver-1.0.335/displaylink-installer.sh	2015-11-29 07:46:29.000000000 -0500
--- displaylink-driver-1.0.335.fixed/displaylink-installer.sh	2016-04-08 19:30:13.772797814 -0400

*** 372,378 ****
SYSTEMINITDAEMON=systemd
fi
else
!     echo "WARNING: Unknown distribution, assuming defaults - this may fail." >&2
fi
}
--- 372,379 ----
SYSTEMINITDAEMON=systemd
fi
else
!     echo "WARNING: Unknown distribution, assuming systemd - this may fail." >&2
!     SYSTEMINITDAEMON=systemd
fi
}


hotrod: CI Updates

Changes
Replaced the deprecated defaultService and defaultServicePort in the upsert call with endpoints.
- We'll now pass deployment fork endpoints for the services that have changed (eg. customer, driver, route, frontend). The reason we're going with deployment fork is because we show baseline preview endpoints on the UI only for the deployment forks. Also, the UX for service fork under additional preview endpoints section is yet to be streamlined.
- Additionally, we'll be creating a new static endpoint for frontend irrespective of whether there were any changes to it or not. Made it static instead of fork (of service/deployment) because the latter won't work when there are no forked deployment/service (which aren only created when there is change to frontend).
Screenshots
New call with endpoints

Note:
The new integration test (using workspaces client) has only been setup in staging environment. Prod will continue to run the old integration test setup.

The "fork" endpoint type doesn't need the port to be specified, afaik.

The "fork" endpoint type doesn't need the port to be specified, afaik.

Right, the port is not needed for the fork endpoint. But I think one could still override it optionally. Isn't that right, @enisoc?

The "fork" endpoint type doesn't need the port to be specified, afaik.

Right, the port is not needed for the fork endpoint. But I think one could still override it optionally. Isn't that right, @enisoc?

Since this GHA is shared in our docs, I would like it to be aligned with the public API (where we don't mention port as an available field).


how to set PROXY when use sentry dio

In my App, I use Dio to make network requests, but when I integrate Sentry_dio to monitor, I cannot set the network proxy.
Error display:
_dio.httpClientAdapter is SentryDioClientAdapter , not sub type of DefaultHttpClientAdapter.
The code is like: https://github.com/getsentry/sentry-dart/issues/1015
as written.
String proxy = "PROXY ${ipController.text}:${portController.text}";
(dio?.httpClientAdapter as DefaultHttpClientAdapter).onHttpClientCreate =
(client) {
client.findProxy = (url) {
return proxy;
};
//Trust certificate for https proxy
client.badCertificateCallback = (cert, host, port){
return true;
};
return client;
};

When I was looking for the answer, I didn't find anything useful. SentryDioClientAdapter is not exposed to the outside world and cannot be used.
https://github.com/getsentry/sentry-dart/issues/1015 also said that there is no solution.
Later I found a way to replace it myself:

When you initialize Dio(), it will create a DefaultHttpClientAdapter instance for you by default and assign it to dio.httpClientAdapter.

We can create a field to save dio.httpClientAdapter in the tool class, such as:

late HttpClientAdapter httpClientAdapter;
httpClientAdapter = dio.httpClientAdapter;
Note: This step needs to be placed before dio.addSentry(), because addSentry will wrap httpClientAdapter as SentryDioClientAdapter.

In the place where the agent is set, you can first judge whether the dio.httpClientAdapter is the DefaultHttpClientAdapter type. If not, you can reassign the saved httpClientAdapter. After the agent is set, set dio.addSentry()
if(!(dio?.httpClientAdapter is DefaultHttpClientAdapter)){
dio?.httpClientAdapter = HttpRequest().httpClientAdapter;
}

String proxy = "PROXY ${ipController.text}:${portController.text}";

if(!(dio?.httpClientAdapter is DefaultHttpClientAdapter)){
  dio?.httpClientAdapter = HttpRequest().httpClientAdapter;
}

(dio?.httpClientAdapter as DefaultHttpClientAdapter).onHttpClientCreate =
    (client) {
  client.findProxy = (url) {
    return proxy;
  };

  //Trust certificate for https proxy
  client.badCertificateCallback = (cert, host, port){
    return true;
  };
  return client;
};

if(Channel.currentChannel == APPChannel.DEV){
  dio?.addSentry(
    captureFailedRequests: true,
    maxRequestBodySize: MaxRequestBodySize.always,
    maxResponseBodySize: MaxResponseBodySize.always,
  );
}

Here is how to dynamically add network proxy for Dio

@haozi5460 as mentioned here https://github.com/getsentry/sentry-dart/issues/1015
Proxy settings should be directly set on Dio if possible,SentryDioClientAdapter is just s wrapper on top of Dio.

wrapper

I know this, but after addSentry adds extensions, DefaultHttpClientAdapter becomes SentryDioClientAdapter, and SentryDioClientAdapter is not open to the outside world and cannot be called externally.

bump, this is still a problem


Update version number

Codecov Report

Merging #183 (ea8e579) into master (7200b07) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master     #183   +/-   ##
=========================================
  Coverage     70.28%   70.28%
  Complexity      901      901
=========================================
  Files           129      129
  Lines          2749     2749
  Branches        360      360
=========================================
  Hits           1932     1932
  Misses          612      612
  Partials        205      205

Impacted Files
Coverage Δ

src/main/java/taskbook/MainApp.java
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Refactoring Pages component

Hi! Thanks for the PR! I took a look, and it seems to me that this kind of refactoring is unnecessary. It doesn't add much clarity, but it does take more time to understand what's going on. I agree that using a Record is a good practice, but in this case, I see more harm than good from it. For example, it's unclear why some tabs are considered tabs in the variable, while others are not. Are the others no longer considered tabs? What's the semantic distinction between them? Right now, I don't see any semantic distinction, I only see a separation at the code level.


OutputContainer.add_stream  raise error when float on windows but not on linux.

IMPORTANT: Be sure to replace all template sections {{ like this }} or your issue may be discarded.
Overview
rate = 30.00003000003
OutputContainer.add_stream(.., rate=rate)

raise
  File "c:\users\samuel\documents\pyacq\pyacq\rec\avirecorder.py", line 78, in _initialize
    av_stream = av_container.add_stream('libx264', rate=float(sr))
  File "av\container\output.pyx", line 105, in av.container.output.OutputContainer.add_stream
OverflowError: Python int too large to convert to C long

on windows with conda but not on linux (with pip on unbuntu)
Expected behavior
It would except it also would work on window.
Actual behavior
Traceback:
  File "c:\users\samuel\documents\pyacq\pyacq\rec\avirecorder.py", line 78, in _initialize
    av_stream = av_container.add_stream('libx264', rate=float(sr))
  File "av\container\output.pyx", line 105, in av.container.output.OutputContainer.add_stream
OverflowError: Python int too large to convert to C long

Investigation
My guess is it is because of internal use of Fraction(rate) that for same special case have an overflow.
Reproduction
{{ Steps to reproduce the behavior. If the problem is media specific, include a link to it. Only send media that you have the rights to. }}
Versions

OS: {{ e.g. macOS 10.13.6 }}
PyAV runtime:

PyAV v6.2.0
git origin: git@github.com:mikeboers/PyAV
git commit: unknown-commit
library configuration: --disable-static --enable-shared --enable-gpl --enable-version3 --enable-sdl2 --enable-fontconfig --enable-gnutls --enable-iconv --enable-libass --enable-libbluray --enable-libfreetype --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-libopus --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libtheora --enable-libtwolame --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libzimg --enable-lzma --enable-zlib --enable-gmp --enable-libvidstab --enable-libvorbis --enable-libvo-amrwbenc --enable-libmysofa --enable-libspeex --enable-libxvid --enable-libaom --enable-libmfx --enable-amf --enable-ffnvcodec --enable-cuvid --enable-d3d11va --enable-nvenc --enable-nvdec --enable-dxva2 --enable-avisynth
library license: GPL version 3 or later
libavcodec     58. 35.100
libavdevice    58.  5.100
libavfilter     7. 40.101
libavformat    58. 20.100
libavutil      56. 22.100
libswresample   3.  3.100
libswscale      5.  3.100

PyAV build:

FFmpeg:

built with gcc 8.3.1 (GCC) 20190414
configuration: --disable-static --enable-shared --enable-gpl --enable-version3 --enable-sdl2 --enable-fontconfig --enable-gnutls --enable-iconv --enable-libass --enable-libbluray --enable-libfreetype --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-libopus --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libtheora --enable-libtwolame --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libzimg --enable-lzma --enable-zlib --enable-gmp --enable-libvidstab --enable-libvorbis --enable-libvo-amrwbenc --enable-libmysofa --enable-libspeex --enable-libxvid --enable-libaom --enable-libmfx --enable-amf --enable-ffnvcodec --enable-cuvid --enable-d3d11va --enable-nvenc --enable-nvdec --enable-dxva2 --enable-avisynth
libavutil      56. 22.100 / 56. 22.100
libavcodec     58. 35.100 / 58. 35.100
libavformat    58. 20.100 / 58. 20.100
libavdevice    58.  5.100 / 58.  5.100
libavfilter     7. 40.101 /  7. 40.101
libswscale      5.  3.100 /  5.  3.100
libswresample   3.  3.100 /  3.  3.100
libpostproc    55.  3.100 / 55.  3.100

Research
I have done the following:

[X] Checked the PyAV documentation
[X] Searched on Google
[] Searched on Stack Overflow
[ ] Looked through old GitHub issues
[ ] Asked on PyAV Gitter
[ ] ... and waited 72 hours for a response.

Additional context
Sorry for this dirty report.
I haven't make deep investigation
Close it, if you knwon the bug already.
Thank you for pyav, it is totally amazing.

An easy fix to to do
Fraction(rate).limit_denominator()
and itt works always.
I guess that python fraction have several precission representation. Not investigate on that.

AVRational has an integer numerator and denominator, while Python Fraction has no limitation. Your float turns into a 47-bit denominator on my machine.
If we were to auto-limit the denominator, I'd want to do it to 2**31-1 or something. But that makes your float resolve to Fraction(59946999997,<PHONE_NUMBER>) instead of the Fraction(10000000, 333333) which I think is what you are intending.
That makes me hesitant to do this at all. Perhaps something else to consider is raising an error if the auto-converted denominator is beyond an arbitrary threshold (perhaps the same 1e6). So you'd have to pass a Fraction (or a string with / would also be acceptable) to get to more precision.

I resolved the problem outside pyav wby providing a Fraction.
Maybe you could just make a test on the denominator and raise an error whan overflow.
The error message would indicate limit_denominator() as a workaround which is a reasonable solution.
Deal the problem explicitly and externaly.
Thanks a lots.
Feel free to close.


Use hmget command in RMapCache.getAllWithTTLOnly()

Redis version
any
Redisson version
any
Redisson configuration
any
What is the Expected behavior?
No response
What is the Actual behavior?
number of GetTypeCmds is very high using this method
Additional information
No response

Done


Page OnValidate is not triggered in Chrome

Describe the bug
The OnValidate of the page is not triggered when changing the value in fhe field and then clicking to the empty space (not a control or button/link).
It seems to only be an issue with chrome and certian page configurations.
To Reproduce
Use attached examples.
PageValidateTrigger.zip
Steps:

Open Page ExampleNoRecord in Chrome (tested with latest version - 75.0.3770.100)
Enter 1 into the MyInteger field. Do not press enter or tab.
Click into the empty space below (on the page) -> Validate is NOT triggered
Click on Show Attached -> Validate is triggered

Step 3 will trigger in IE Version: 11.2848.14393.0
Step 3 will not trigger in RTC but the control will not lose focus.
page 70004 ExampleNoRecord
{
    PageType = Card;
    ApplicationArea = All;
    UsageCategory = Administration;

    layout
    {
        area(Content)
        {
            group(TestGroup)
            {
                field(MyInteger; myInt)
                {
                    ApplicationArea = All;

                    trigger OnValidate()
                    begin
                        Message('Page OnValidate triggered!');
                    end;
                }
            }
        }
    }

    var
        myInt: Integer;
}

The Isssue seems to be related to the group element.
If there is no group element on the page it works as expected but if there is one if fails to call OnValidate. Also if PageType is List and it contains group elements the issue is not present.
There are 3 additional Example pages in the example app.

Page ExampleRecordCardWithoutGroup - OnValidate is triggered
Page ExampleRecordCardWithGroup - OnValidate is NOT triggered
Page ExampleRecordTypeList - OnValidate is triggered

Expected behavior
Step 3 should trigger OnValidate. As I understand it field con
trol losing focus should trigger OnValidate if the contents were edited.
Versions:

AL Language: 3.0.106655
Business Central: Platform 14.0.29530.0 Application 29537 (W1 14.0)

Hi @lukacetko ! Does this issue still reproduce on the latest D365 Business Central preview? You can find more information here https://freddysblog.com/2019/07/31/preview-of-dynamics-365-business-central-2019-release-wave-2/ .

This issue has been closed because it needs more information and has not had recent activity. Please open a new issue if you believe this has not been resolved and reference the current issue.


Any support for resuming a spot-instance workload

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Not enough information provided.


Add API endpoint

Description
In this project, we add some API endpoints to our Blog app. This will allow our app to be used in different ways, rather than just through your site - for example, a mobile app or a CLI application.
Project requirements

Create an API endpoint to list all posts for a user.
Create an API endpoint to list all comments for a user's post.
Create an API endpoint to add a comment to a post. Remember that the owner of the comment is the user that makes it; it should not be set by passing a parameter.
Your API endpoints should receive JSON and respond JSON as well.

Thank you very much.


DrugLogEdit has an uncontrolled field (null)

react-dom.development.js:67 Warning: A component is changing an uncontrolled input to be controlled. This is likely caused by the value changing from undefined to a defined value, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components
    at input
    at http://localhost:3000/static/js/bundle.js:33853:23
    at div
    at http://localhost:3000/static/js/bundle.js:32702:23
    at div
    at http://localhost:3000/static/js/bundle.js:35635:23
    at http://localhost:3000/static/js/bundle.js:34164:23
    at form
    at http://localhost:3000/static/js/bundle.js:33548:23
    at div
    at http://localhost:3000/static/js/bundle.js:36808:27
    at div
    at div
    at http://localhost:3000/static/js/bundle.js:34928:23
    at div
    at Transition (http://localhost:3000/static/js/bundle.js:66861:30)
    at http://localhost:3000/static/js/bundle.js:33421:24
    at DialogTransition
    at http://localhost:3000/static/js/bundle.js:64507:24
    at http://localhost:3000/static/js/bundle.js:34620:23
    at DrugLogEdit (http://localhost:3000/static/js/bundle.js:11547:5)
    at RxMedicine (http://localhost:3000/static/js/bundle.js:14976:80)
    at div
    at Transition (http://localhost:3000/static/js/bundle.js:66861:30)
    at http://localhost:3000/static/js/bundle.js:33421:24
    at http://localhost:3000/static/js/bundle.js:36088:24
    at div
    at http://localhost:3000/static/js/bundle.js:36000:23
    at TabContainer (http://localhost:3000/static/js/bundle.js:35933:89)
    at Tabs (http://localhost:3000/static/js/bundle.js:36275:89)
    at div
    at RxPage (http://localhost:3000/static/js/bundle.js:13481:75)
    at div
    at http://localhost:3000/static/js/bundle.js:36000:23
    at div
    at Transition (http://localhost:3000/static/js/bundle.js:66861:30)
    at http://localhost:3000/static/js/bundle.js:33421:24
    at http://localhost:3000/static/js/bundle.js:36088:24
    at div
    at http://localhost:3000/static/js/bundle.js:36000:23
    at TabContainer (http://localhost:3000/static/js/bundle.js:35933:89)
    at Tabs (http://localhost:3000/static/js/bundle.js:36275:89)
    at LandingPage (http://localhost:3000/static/js/bundle.js:6275:75)
    at Main (http://localhost:3000/static/js/bundle.js:727:5)
    at App (http://localhost:3000/static/js/bundle.js:235:90)
printWarning @ react-dom.development.js:67

I've tried to duplicate this issue a few times but haven't found the circumstances that trigger the warning yet.


[Refactor] Build failure due to breaking changes introduced in core

What is the issue?

We need to adapt the breaking change in core OpenSearch: https://github.com/opensearch-project/OpenSearch/pull/7508

Core OpenSearch has split the imports of org.opensearch.common.Strings and org.opensearch.core.common.Stringsinto two.

Tracking on the original toString() function, since it is not defined in org.opensearch.core.common.Strings. The current fix is:
...
return org.opensearch.common.Strings.toString(JsonXContent.contentBuilder().map(getAsMap()));
...

LoggerMessageFormat.java location change causing SecurityFilter.java to not compile

Fixes

[x] Fix the Strings and LoggerMessageFormat package: https://github.com/opensearch-project/security/pull/2781
[ ] ...wip

[Triage] There is a fix for this pending in core. No further action is required.

@scrawfor99 Can you please share core issue that tracks that fix you've mentioned? I've opened another issue in core, do you think it may be related to the fix https://github.com/opensearch-project/OpenSearch/issues/7714?

Hi @martin-gaievski, sorry, I did not see your comment before. The original fix should be up in the body of the issue I believe. Let me know if that is not what you were looking for.

[Triage] Keeping open for now for tracking purposes (and if eventually any further work is needed)

We need to backport this to 2.x.
Changes in core were backported to 2.x.
https://github.com/opensearch-project/OpenSearch/pull/8460

Hi @parasjain1, ty for the notification~ I think we did the backport here: https://github.com/opensearch-project/security/pull/2953

@RyanL1997 You have another item 'wip...' which I suspect was 'work in progress'.  Doesn't look like there was anything else needed and the pull requests associated were merged and backported to 2.x -- assuming this is complete and closing this issue.


Remove spell check for devanagari in proofing

Spell check is not useful and also hides some parts of the characters:

Looks like the fix is spellcheck="false" in the form. Would love a PR!


Multi-dataset support issue.

Hello, if I want to use multiple dataset classes during the alignment stage or fine-tuning stage, how should I configure it?

I think the easiest thing to do would be to hack this function.
Right now, it'll instantiate just a single AlignDataset or FinetuneDataset class, but as both inherit from standard PyTorch Dataset, you can just initialize multiple different dataset instances in a for loop. Then, you can use ConcatDataset for example to stitch them together!


Update mock-fS to 5.1.2

Checklist

[x] I ran npm test locally and it passed without errors.
[x] I acknowledge that all my contributions will be made under the project's license.

Description
Updated the version of mock-fs being used to the latest 5.1.2
Several people in the TwilioQuest discord have hit issues running the tests locally getting output such as
><EMAIL_ADDRESS>test
> jest

 FAIL  __tests__/scripts/mergePixels.test.js
  ● getSortedPixelsFromFile › returns already sorted
    EBADF: bad file descriptor, read

  ● getSortedPixelsFromFile › sorts file if necessary
    EBADF: bad file descriptor, read

  ● run › handles conflict with same coordinates by shifting branch contribution
    EBADF: bad file descriptor, read

  ● run › handles conflict with different pixels by merging
    EBADF: bad file descriptor, read

  ● run › handles conflict with reordering changes
    EBADF: bad file descriptor, read

They have likely installed the latest LTS of NodeJS v16
With the older version of Mock-FS this was working on NodeJS 14 (now maintenance LTS)
I've tested this change locally on the latest LTS v14 and LTS v16 release and tests pass successfully on both.
Related issues
https://discord.com/channels/570292611215130634/804374967714054144/929850582527774771
https://discord.com/channels/570292611215130634/804374967714054144/930562234562797668
https://discord.com/channels/570292611215130634/804374967714054144/930681677628452885

It looks like the automated builds will also need to be updated. They are currently running Node.JS v10.

@dkundel the mergify config also needs updating so you weren't automatically pinged for this PR

Made what I think was the required change to Mergify (but it uses the config from master to prevent people from being able to force-merge code) and updated the version of Node used for Github Actions which ran successfully

Dominik is moving off of maintaining this project. I can merge this PR if it's ready though! Is it ready for merging?

It should be ready for merging. Tests pass, Mergify config is valid, build failed as expected because files other than _data/pixels.json were modified.
With Dominik moving off this project it might be good to remove him from the Mergify config so he doesn't get pinged on Github automatically
see:
https://github.com/twilio-labs/open-pixel-art/blob/master/.mergify.yml#L26
https://github.com/twilio-labs/open-pixel-art/blob/master/.mergify.yml#L35


Remove sensors from component category and represent the separately

This update introduces a dedicated RPC method for listing sensors in the microgrid, separating them from the "component" category. This new method allows for optional sensor filtering by ID or category. The change clarifies the term "component" to exclusively refer to electrical equipment like inverters and batteries, while sensors are now treated as a distinct entity.

We should however, clarify that when we say components we mean electrical components!

@thomas-nicolai-frequenz I added another commit to re-inforce components as electrical components. Ready for another look.


Move single-segment same ns to same.core

Uses of same-ish in clojurescript repeatedly causes warnings at the start of tests about the single segment namespace (see a similar issue in datascript) -- which seems like something to avoid in a testing aid.
This PR moves everything into a same.core namespace, but then aliases it all back into same to avoid breakage, with a note in the same namespace that it's deprecated for the future.

Codecov Report

Merging #11 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   99.59%   99.60%   +0.01%
==========================================
  Files           5        6       +1
  Lines         248      255       +7
==========================================
+ Hits          247      254       +7
  Misses          1        1

Impacted Files
Coverage Δ

src/same.cljc
100.00% <100.00%> (ø)

src/same/core.cljc
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac49e1...16e4cbf. Read the comment docs.

I had been meaning to do something about it at some point, so thanks for doing it for me!


docs(openapi): add readme of OpenAPI section

What this PR does / why we need it:
Add your description
Which issue(s) this PR fixes (optional, close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
/cc @ddysher
Release note:

NONE

@liubog2008 can u update mail address?

@ddysher updated

/lgtm


A suggestion for maintaining very private notes

This is a trick I have started to use since my notes many times contain client passwords etc. The idea of putting them on simplenotes servers does not appeal to me. I use resilio sync (previously bitttorent sync) to sync my nvNotes folder. I then use the Resilio client on the iphone or android to see my notes. I can't search the content but I can search the text file names and see the notes. No adding new one but I find that on my phone I don't need to add all that often. When I do it's usually images I want to add and we all know that not an option anyways. Worse case I put the new context in ios notes and them move it over later. I always have one machine running (server) where Resilio can connect to.

@vamp07: Storing passwords in plain text is just not a good idea, but it is also an unnecessary 'convenience' when you consider that developers like AgileBits, et al. have turned out some very flexible, easy-to-use, and most of all secure password-management options. In fact, AgileBits' product, 1Password, even has the baked-in ability for storing sensitive non-password information, whether plain-text notes, passports, etc.
I highly suggest giving them a try. Though I am partial to 1Password because it has been a lifesaver for me and because its developers are literally coding the future of consumer-oriented cybersecurity and need to be compensated for that, options abound.

Similarly, I use codebook. Being a developer myself, I cannot trust systems without exact specifications on security. Codebook uses an open source encryption library, which they develop. The core is AES, so it's pretty secure. It can sync over many options.
Also, for syncing computers over internet, syncthing is the best option IMHO. Open, Free, can talk even over TOR automatically. Pretty convenient.


SCS Wallaby Update Experience

Signed-off-by: Mathias Fechner<EMAIL_ADDRESS>some little post for the  Rabbitmq User Story

Hi  @itrich here is  my post

Hi @itrich, i hope now  it is looking better  https://github.com/SovereignCloudStack/website/pull/233/commits/545894ae837d05bd179f1a1174df5a2db87a41ca


Incorrect Error "Selecting DTOs without services is forbidden"

Overview of the issue
The following JDL throws an error on import due to service being required for the dto option, but it shouldn't because service is applied to *.  It works if you specify service C with serviceClass instead of using a wildcard.
entity C
service * with serviceClass
dto C with mapstruct

The JDL is being parsed.
Error: Selecting DTOs without services is forbidden, for entities C.
ERROR! ERROR! Error while parsing applications and entities from the JDL Error: Selecting DTOs without services is forbidden, for entities C.
Error: ERROR! Error while parsing applications and entities from the JDL Error: Selecting DTOs without services is forbidden, for entities C.
    at Environment.error (/Users/ruddell/Contrib/generator-jhipster/node_modules/yeoman-environment/lib/environment.js:157:40)
    at module.exports.error (/Users/ruddell/Contrib/generator-jhipster/generators/generator-base.js:2058:18)
    at module.exports.importJDL (/Users/ruddell/Contrib/generator-jhipster/generators/import-jdl/index.js:116:14)
    at new ImporterGenerator (/Users/ruddell/Contrib/generator-jhipster/generators/import-jdl/index.js:81:38)
    at new module.exports (/Users/ruddell/Contrib/generator-jhipster/generators/import-jdl/index.js:123:9)
    at Environment.instantiate (/Users/ruddell/Contrib/generator-jhipster/node_modules/yeoman-environment/lib/environment.js:408:12)
    at Environment.create (/Users/ruddell/Contrib/generator-jhipster/node_modules/yeoman-environment/lib/environment.js:386:17)
    at Environment.run (/Users/ruddell/Contrib/generator-jhipster/node_modules/yeoman-environment/lib/environment.js:443:28)
    at runYoCommand (/Users/ruddell/Contrib/generator-jhipster/cli/cli.js:63:13)
    at Command.command.allowUnknownOption.description.action (/Users/ruddell/Contrib/generator-jhipster/cli/cli.js:83:13)

Motivation for or Use Case
This should be valid JDL
Reproduce the error
Use the JDL from above
Suggest a Fix
Not sure.
JHipster Version(s)
generator-jhipster: master, v5.2.1
jhipster-core: v3.1.0

[X] Checking this box is mandatory (this is just to show you read everything)

Nice catch @ruddell ! I'll find time this week-end to fix it.

@kannery That's unrelated to this issue and not a bug.  If you choose DTOs, you need to enable services https://www.jhipster.tech/using-dtos/

I was trying to import old jdl with the new jhipster version. I have corrected my jdl with the service option. Now it works. Thanks


New translation (v10.13) - ru-ru (russian)

Hot reload is enabled. The app should refresh automated.


Add support for Quasar auto dark mode

This change will allow for Quasar auto-detection of dark mode based on client browser
Currently it is possible to set dark=True for a QuasarPage which will enable dark mode. Moreover one can set dark=False to disable dark mode (default). With this small change in quasar.html one can also set dark="auto" to use the auto-detection for dark mode of Quasar (see Quasar dark mode documentation).
Minimal working example for Quasar auto-detection of dark mode:
import justpy as jp

def my_click(self, msg):
    self.text = 'I was clicked!'

def hello_world():
    wp = jp.QuasarPage(dark="auto")
    d = jp.Div(text='Hello world!')
    d.on('click', my_click)
    wp.add(d)
    return wp

jp.justpy(hello_world)

I just noticed this PR and that it is already merged...
In our JustPy fork we did something very similar, but used dark=None for the auto-detection. Then dark is of type Optional[bool] and avoids a string "auto" which might be mistyped and which is difficult to type-check.
What do you think about changing "auto" to None? Since it is not used anywhere in the codebase and not yet release, it doesn't break anything.


Missing step in "From peaks to genes" tutorial

reported via Twitter
In "From peaks to genes" tutorial, in the sophisticated approach I think there is a step lacking in tutorial  which is step 12 in my analysis (https://t.co/aYFze52yWk), without it , intersect would not work with me , please check if I am correct.
Best regards

By looking at the history, the person is importing the file directly from GEO instead of "the edited peak file (after the replace steps)" as advised in Part2 - Preparation, so they need the replace step which is done in Part 1.


Perform Actor Scale/Reliability tests

In what area(s)?
/area runtime/actor
Describe the feature
This is the plan to execute Dapr actor scalability and reliability tests. Based on the test result data, we will decide how we can improve actors for dapr 1.0 stable.
The detailed test plans will be attached later.

@yaron2 @amanbha JFYI - start working on it, but writing up the test plan first.


Issue installing

Please describe your issue clearly and also include all details below.
Details

avn 0.2.4
node v13.3.0
nvm 1.1.7
n n/a
zsh n/a
bash n/a
Using PowerShell

When trying to install:
PS C:\WINDOWS\system32> npm install -g avn avn-nvm avn-n
C:\Program Files\nodejs\avn -> C:\Program Files\nodejs\node_modules\avn\bin-public\avn
+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>added 299 packages from 549 contributors in 14.97s
PS C:\WINDOWS\system32> avn setup
avn: profile already set up (~/.bash_profile)
events.js:196
      throw er; // Unhandled 'error' event
      ^

Error: spawn /bin/cp ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:266:19)
    at onErrorNT (internal/child_process.js:468:16)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
Emitted 'error' event on ChildProcess instance at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
    at onErrorNT (internal/child_process.js:468:16)
    at processTicksAndRejections (internal/process/task_queues.js:84:21) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'spawn /bin/cp',
  path: '/bin/cp',
  spawnargs: [
    '-RL',
    'C:\\AppsNoSpace\\nvm\\v13.3.0\\node_modules\\avn/',
    'C:\\Users\\Robert Bram\\.avn'
  ]
}
PS C:\WINDOWS\system32>

[ ] As an nvm user I am confirming that I did not install with Homebrew

Windows isn't supposed. Feel free to try to get things working and open a PR, though.


Sentry not using the $dontReport property

Hello,
I've setup sentry in Laravel 5.1.
I have a few exceptions setup in the $dontReport property, like 404, so that sentry doesn't log those errors and thus it doesn't get logged on slack.
However, the package doesn't seem to be paying attention to this property.
Do I have to do this manually ? Or can/should the package do this ?
For example, on bugsnag, it was the bugsnag package that handled the $dontReport property.
Thank you,

Actually, it was fairly easy to implement using the following code:
if (in_array(get_class($e), $this->dontReport, true)) {
    parent::report($e);
    return;
}

For for the trouble :)

You have to do this yourself, this is also done in the example applications.
    /**
     * Report or log an exception.
     *
     * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
     *
     * @param  \Exception $exception
     *
     * @return void
     */
    public function report(Exception $exception)
    {
        if ($this->shouldReport($exception)) {
            app('sentry')->captureException($exception);
        }

        parent::report($exception);
    }

Ah nice, that's nicer! Thanks! 😄

Is there a nice way to do the same thing in Laravel 4.x?  Right now, I just have the following in app/start/global.php:
App::error(function (Exception $exception, $code) {

	// Add some extra context to Sentry
	app('sentry')->user_context(array(
		'ip_address' => Request::ip()
	));

	Log::error($exception);
});

@cviebrock in L5 it's just an array of exception with a helper method so you could do this:
You should check if that are the correct classes and namespaces and add some more maybe :) I cannot remember which there all are in L4.
/**
 * Determine if the exception is in the "do not report" list.
 *
 * @param  \Exception  $e
 * @return bool
 */
function shouldntReportException(Exception $e)
{
    $dontReport = array(
        'Illuminate\Http\Exception\HttpResponseException',
        'Illuminate\Database\Eloquent\ModelNotFoundException',
        'Symfony\Component\HttpKernel\Exception\HttpException',
        'Symfony\Component\HttpKernel\Exception\NotFoundHttpException',
    );

    foreach ($dontReport as $type) {
        if ($e instanceof $type) {
            return true;
        }
    }

    return false;
}

App::error(function (Exception $exception, $code) {
    // Ignore all errors we don't care about
    if (shouldntReportException($exception)) {
        return;
    }

    // Add some extra context to Sentry
    app('sentry')->user_context(array(
        'ip_address' => Request::ip()
    ));

    Log::error($exception);
});

That's what I figured I'd need to do.  Thanks!


Incorrect recognition of the device

Description
I am trying to add a device of the same type psmart_t436_thermostat (Request #2373 and #2375) but unfortunately it is not properly recognized below logs:
HA Log message:
Device matches rumba_bathroom_heater with quality of 43%. DPS: {"updated_at":<PHONE_NUMBER>.9009466, "1": true, "2": "manual", "16": 201, "19": 400, "24": 210, "26": 100, "27": 0, "39": true, "40": false, "45": 0, "101": 600, "102": "out", "103": 1, "104": "low"}
Device matches rumba_bathroom_heater with quality of 43%. DPS: {"updated_at":<PHONE_NUMBER>.0754168, "1": true, "2": "manual", "16": 201, "19": 400, "24": 210, "26": 100, "27": 0, "39": true, "40": false, "45": 0, "101": 600, "102": "out", "103": 1, "104": "low"}
Device matches rumba_bathroom_heater with quality of 43%. DPS: {"updated_at":<PHONE_NUMBER>.2141335, "1": true, "2": "manual", "16": 170, "19": 400, "24": 205, "26": 100, "27": 0, "39": true, "40": false, "45": 0, "101": 600, "102": "out", "103": 1, "104": "low"}
Device matches rumba_bathroom_heater with quality of 43%. DPS: {"updated_at":<PHONE_NUMBER>.830626, "1": true, "2": "manual", "16": 170, "19": 400, "24": 210, "26": 100, "27": 0, "39": true, "40": false, "45": 0, "101": 600, "102": "out", "103": 1, "104": "low"}
DPS information
{
"result": {
"model": "{"modelId":"e1emvk","services":[{"actions":[],"code":"","description":"","events":[],"name":"默认服务","properties":[{"abilityId":1,"accessMode":"rw","code":"switch","description":"","extensions":{"iconName":"icon-dp_power3","attribute":"1024"},"name":"开关","typeSpec":{"type":"bool"}},{"abilityId":2,"accessMode":"rw","code":"mode","description":"","extensions":{"iconName":"icon-dp_mode","attribute":"1152","trigger":"direct","passive":true},"name":"工作模式","typeSpec":{"type":"enum","range":["auto","manual"]}},{"abilityId":16,"accessMode":"rw","code":"temp_set","description":"","extensions":{"iconName":"icon-dp_temp","attribute":"1024","trigger":"direct","passive":true},"name":"目标温度","typeSpec":{"type":"value","max":700,"min":50,"scale":1,"step":5,"unit":"℃"}},{"abilityId":19,"accessMode":"rw","code":"upper_temp","description":"","extensions":{"iconName":"icon-dp_c","attribute":"1024"},"name":"设置温度上限","typeSpec":{"type":"value","max":700,"min":200,"scale":1,"step":10,"unit":"℃"}},{"abilityId":24,"accessMode":"ro","code":"temp_current","description":"","extensions":{"iconName":"icon-wendu","attribute":"1024","trigger":"direct","passive":true},"name":"当前温度","typeSpec":{"type":"value","max":900,"min":0,"scale":1,"step":5,"unit":"℃"}},{"abilityId":26,"accessMode":"rw","code":"lower_temp","description":"","extensions":{"iconName":"icon-dp_c","attribute":"1024"},"name":"设置温度下限","typeSpec":{"type":"value","max":200,"min":50,"scale":1,"step":10,"unit":"℃"}},{"abilityId":27,"accessMode":"rw","code":"temp_correction","description":"","extensions":{"iconName":"icon-wendu1","attribute":"1024"},"name":"温度校准","typeSpec":{"type":"value","max":4,"min":-4,"scale":0,"step":1,"unit":""}},{"abilityId":36,"accessMode":"ro","code":"valve_state","description":"","extensions":{"iconName":"icon-tcl_function_vs2","attribute":"1024"},"name":"阀门状态","typeSpec":{"type":"enum","range":["open","close"]}},{"abilityId":39,"accessMode":"rw","code":"factory_reset","description":"","extensions":{"iconName":"icon-icon-test12","attribute":"1024"},"name":"恢复出厂设置","typeSpec":{"type":"bool"}},{"abilityId":40,"accessMode":"rw","code":"child_lock","description":"","extensions":{"iconName":"icon-dp_lock","attribute":"1024"},"name":"童锁开关","typeSpec":{"type":"bool"}},{"abilityId":45,"accessMode":"ro","code":"fault","description":"","extensions":{"iconName":"icon-dp_notice","attribute":"1024","trigger":"direct","passive":true},"name":"故障告警","typeSpec":{"type":"bitmap","label":["e1","e2","e3"],"maxlen":3}},{"abilityId":71,"accessMode":"rw","code":"week_program_4","description":"周程序4","name":"周程序4","typeSpec":{"type":"raw","maxlen":128}},{"abilityId":101,"accessMode":"rw","code":"lower_floor_temp","description":"","name":"地板温度上限","typeSpec":{"type":"value","max":700,"min":200,"scale":1,"step":10,"unit":""}},{"abilityId":102,"accessMode":"rw","code":"sensor_choose","description":"","extensions":{"iconName":"icon-dp_mode","attribute":"4096"},"name":"传感器选择","typeSpec":{"type":"enum","range":["in","out","all"]}},{"abilityId":103,"accessMode":"rw","code":"diff_temp","description":"","name":"启动条件","typeSpec":{"type":"value","max":3,"min":1,"scale":0,"step":1,"unit":""}},{"abilityId":104,"accessMode":"rw","code":"load_selection","description":"","name":"负载选择","typeSpec":{"type":"enum","range":["low","mid","high"]}}]}]}"
},
"success": true,
"t":<PHONE_NUMBER>725,
"tid": "94f53dc7979b11efad5172ecb0bd0dcf"
}
Steps to reproduce
No response
Expected behaviour
Add/recognize the device by HA correctly as 'psmart_t436_thermostat'
Additional context
No response
Confirmation

[X] I am sure this is a bug, or improvement that is well enough described that it can be implemented

[X] If this is for a specific device, the device config is mentioned above, or diagnostics are included.

[X] This is not requesting addition of a new device

It works! Thanks!


Using this image this Hubic

Hi! Thanks for great work! But for me it`s not clever, how to use backends mentioned in Duplicity manual, but not described in backend tutorials in this repo. For example: Hubic.
Thanks for help!

Hello, everybody is free to add tutorials for backends!
Personally, I do not know and/or use Hubic.

I updated to the latest Duplicity version, you can now consult this for Hubic support: http://duplicity.nongnu.org/vers7/duplicity.1.html#toc16

Closed due to inactivity