Add support for ClickHouse dialect

Describe the bug
sqlfmt doesn't support the ClickHouse dialect which is case sensitive.
To Reproduce
input code:
SELECT toString(1) AS Test_string, toDateTime64('2022-05-25', 3) AS Test_dateTime64, ifNull(null, 'TestNull') as testIf, JSONExtractString('{"abc": "hello"}', 'abc') as testJSON
Expected behavior
select  	toString(1) as Test_string,  	toDateTime64('2022-05-25', 3) as Test_dateTime64,  	ifNull(null, 'TestNull') as testIf,  	JSONExtractString('{"abc": "hello"}', 'abc') as testJSON
Actual behavior
select     tostring(1) as test_string,     todatetime64('2022-05-25', 3) as test_datetime64,     ifnull(NULL, 'TestNull') as testif,     jsonextractstring('{"abc": "hello"}', 'abc') as testjson
this output is not a valid ClickHouse code
Additional context
What is the output of sqlfmt --version?
sqlfmt, version 0.9.0

Thanks for the report, @Shlomixg !
I had no idea ClickHouse was case sensitive. (Why would they do that to us?!)
Should be easy enough to not lowercase the output, but...
Are SQL keywords (like select) also case sensitive, or is it just some/all function names?
I designed this with multiple dialects in mind, so it shouldn't be too bad to change the parsing logic to be case-sensitive. I'm just a little sad because we've gotten away with only one "polyglot" dialect so far.

Awesome, thank you for the extra info. That should make this pretty straightforward. We don't have to touch parsing and can still lowercase lots of tokens- we'll just leave identifiers (incl. function names) alone

Implementation notes (this is bigger than I thought, to get the Dialect or Mode into the Node.capitalize() method):

Add Dialect as a property of Analyzer
Create a NodeManager (NodeBuilder?) class with Dialect as a property
instantiate a NodeManager where needed in actions.py
move Node.from_token() to NodeManager.create_node_from_token(); also move Node.capitalize() and Node.whitespace()
update NodeManager.capitalize() to check for the Clickhouse dialect
update Line.append_newline() so it doesn't use Node.from_token()

@Shlomixg I'm cutting the release for 0.10.0 right now -- if you upgrade, you can run that version with sqlfmt . --dialect clickhouse and we won't lowercase so many things. Would love to get any more feedback from you!

Bravo :)
I'll test it soon and leave feedback.
Thanks!


How to bypass authentication for anonymous API

Hello,
After we configure "Authentication" for one service, it will check token or apply "authentication" for all API of that service. However, in many case, there is anonymous API in this service. So, how can configure to ignore or allow "anonymous" for specific API.
Thanks,

Thanks @TomPallister I know it, but my situation that in one controller, almost API need to be authorize, just some APIs allow anonymous. So, if we follow doc, we need to configure "reroute" for those APIs without authentication? It means that there is many reroute on one service.
Can we have any way to add APIs into reroute to skip authentication?

@tungphuong unfortunately this is not possible. You need to have multiple ReRoutes. I hope that this is OK.

Ok thanks @TomPallister but I suggest that we can configure some specific API to ignore. It will help to have a clear configuration.

@tungphuong how do you think the model could be changed to represent this use case?

Sorry to step in the conversation. I was asked yesterday if ocelot was able to handle this. I know it can with prioroties but i think it would be useful to have something like:
"DownstreamPathTemplate": "/actions/{all}",
"AuthenticationOptions": {
"AuthenticationProviderKey": "Bearer",
"AllowedScopes": [],
"ExcludedActions": ["anonymous1", "anonymous2"
}
where all actions that are not included in "ExcludedActions" are validated

@margaale no worries jump in, I wouldn't add an exclusion list like that, I'm really not a fan of exclusion style designs. I prefer to just model what I want..the cognitive load to go back and see what has been excluded doesnt make sense to me!

@TomPallister I know your point but for this situation, I also prefer approach of @margaale. Because from API gateway side, we dont know which downstream API is anonymous. Besides, just few anonymous API need to configure for one "authorize" controller.
In case, there are many anonymous API in one controller, I suggest that we move them to one separated controller and set up "reroute" for it.

Sorry to step in in the conversation. I was asked yesterday if ocelot was able to handle this. I know it can with priorities but i think it would be useful to have something like:
"DownstreamPathTemplate": "/actions/{all}",
"AuthenticationOptions": {
"AuthenticationProviderKey": "Bearer",
"AllowedScopes": [],
"ExcludedActions": ["anonymous1", "anonymous2"]
}
where all actions that are not included in "ExcludedActions" are validated
what do you mean for anonymous1 ?

@margaale
what do you mean by anonymous1 ?

A real bummer that this feature is missing.

A real bummer that this feature is missing.

Agree, this feature is handy.

+1


HSEARCH-3510 Change the syntax of predicates/sorts on raw fields from onRawField(...).matching() to onField(...).matching(DslConverter option)

https://hibernate.atlassian.net/browse/HSEARCH-3510
Still a preview. Since the change impacts only match/matching predicate so far.

Pull Request Test Coverage Report for Build 1

98 of 100 (98.0%)  changed or added relevant lines in 31 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.03%) to 88.668%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/impl/ElasticsearchSearchScopeModel.java
9
10
90.0%

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/impl/LuceneSearchScopeModel.java
9
10
90.0%

Files with Coverage Reduction
New Missed Lines
%

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/AbstractLuceneStandardFieldPredicateBuilderFactory.java
1
94.12%

backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchStandardFieldPredicateBuilderFactory.java
1
93.75%

Totals

Change from base Build 173:
0.03%

Covered Lines:
16260

Relevant Lines:
18338

💛  - Coveralls

@yrodiere thanks for the pre-review.
I didn't like the solution neither, for that I asked for a pre-review.
Since fast fail is better than fail later in the time.
In the last two commits you would find the change we discussed.
If they would be OK, I'll close temporary this PR in order to reopen it later, when I've finished it.

Thank you @yrodiere. I'm closing this request. I'll reopen it when it is completed.


Web interface for cloudprober.

Start building web interface for cloudprober. It only provides a "/config" handler for now. We'll add more handlers over time.
ORIGINAL_AUTHOR=Manu Garg<EMAIL_ADDRESS>PiperOrigin-RevId: 186660970

Fixes #74.


Fix for epoll backend: use duplicated fd

Description
While playing with cancellation on an old machine not supporting io_uring, I noticed that it was using the original fd, thus causing a error.FileDescriptorNotRegistered to appear.
Solution
Use the duplicated fd if the completion.flags.dup boolean is set, otherwise fallback to the completion.fd function.

Thanks!


Incorrect example in Semi-automatic Derivation

The example shown in Semi-automatic Derivation page when using forProductN helper methods is incorrect (https://circe.github.io/circe/codecs/semiauto-derivation.html#forproductn-helper-methods). The name of the object must be the same of the case class. I think that this might be obvious for experienced scala users, but as a newbie I spent some time before understanding why it wasn't working.

Ah, good catch! This version will work, if you import UserCodec._ explicitly, and it has some uses (e.g. if you don't have a circe dependency in the module where you define your case class), but I definitely agree that in this context it's just confusing.
Want to open a PR to change the object name, @se7entyse7en?

@travisbrown yup, I've just opened the PR. :)


Wait time for first load

Hi all,
I have a small question regarding the 'isauthorizedrace_timeout_in_seconds' config parameter.
We use this component (latest version) for our Angular application, and no matter how high I set the 'isauthorizedrace_timeout_in_seconds' parameter it always waits for this timeout before it continues.
This only happens when you enter the application with a new browser window. It seems like the component is waiting for something that never happens. When you refresh the page it seems to authenticate right away.
If we set this parameter to 1 second, older browsers go into a loop of trying to authenticate.
If there something we're missing here? Do we need to set some additional settings or call some method?
At this point we've tried almost everything (looking at all the samples povided).
Can someone help us with this?
Thnx!

Sorry guys, wrong repository. Component names look very much alike.
Please ignore this issue.


Improve Picturelife Smartloader

Change app to 'Picturelife.app' since that is what is in the dmg and the install is
currently failing because 'Smartloader.app' does not exist.

Change download URL to site hosted by new owner StreamNation
Add proper license
Add uninstall stanza
Add zap stanza

This has to be changed to picturelife, then. The token reference must be followed, to avoid duplicates.

I agree. The name was changed to smartloader in commit 98573b35fae25c84805374790cf74a4d3e1864ed so I didn't want to undo that change without further discussion.
Picturelife is under new ownership, hence the turmoil around it. Their help documentation calls it the "Mac desktop Smartloader", but the app bundle is Picturelife.app. If and when the app bundle changes, the name should change to match, but now it's just causing confusion.


It's seems like there is trouble with the builder

While building the libs and importing in other project it's seems like the generated components are not generated in the same way as in development mode,
In the attached image the hilighted section does not interact or disapear

Provide a codesanbox reproduction, the referenced package can be from lib


Add --version switch

While tinkering with building both master and keycode-refactor branches in #295, I've missed some kind of --version switch to check the binary version, ideally with the build commit short hash.
No idea on how easy this could be, just dropping the idea.

On Tue, Jun 29 2021 08:10, Alfonso Montero wrote:

While tinkering with building both master and keycode-refactor
branches in #295, I've missed some kind of --version switch to check
the binary version, ideally with the build commit short hash.
No idea on how easy this could be, just dropping the idea.

I like this idea :+1:
The version itself would be trivial, as cabal knows this and we can
query it through the generated Paths_kmonad module.
The git hash would be a little bit more complicated.  We'd probably need
to query that from git at compile via TemplateHaskell.  I can see that
TemplateHaskell is already in our default-extensions (although I do
not know where it is used), so perhaps that approach isn't even so
far-fetched.

@slotThe : If you have handy the info to easily do this, I would love to add it to #295, if it can be done at build time. Also, any other feedback on the issue is welcome :grin: .

@slotThe : If you have handy the info to easily do this, I would love to add it to #295, if it can be done at build time.

This solution would be entirely Haskell-based, so the docker image woudn't have to change at all!


System Crash on Insider Preview<PHONE_NUMBER>)

Description
System occasionally crashes when HyperPlatform is loaded on an Insider preview version of Windows due to kInvalidGuestState (0n33). This case, Guest's RIP points to the very first instruction in a guest (ie, asmResumeVm), indicating that guest setup is not done correctly and the guest did not run at all.
Some times HyperPlatform loads successfully, but subsequent execution of some applications fails doe to access violation. This might indicate that an issue is related to memory management settings (CR4, descriptor tables, EPT etc).
Confirmed on Built by: 15025.1000.amd64fre.rs_prerelease.170127-1750
Expected behavior
HyperPlatform installs and run without breaking system behaviour.
Actual behavior
System crashes, or some applications stop running properly after installation.
Steps to reproduce the problem
Compile HyperPlatform for Debug x64
Loads the driver onto the insider preview version
System crashes, or DrvLoader.exe etc starts showing access violation errors.

log.txt
Specifications

Commit (eg, 2099af7): fd224aa

OS version (ie, outout of the "ver" command, or N/A): Microsoft Windows [Version 10.0.15025]

Architecture: x64

Hardware (eg, Physical, VMware 11, Bochs, or N/A): Physical, VMware 12

Details:

Neither disabling enable_ept nor descriptor_table_exiting in VmxProcessorBasedControls helped.

Recently i had same vmexit reason due to the TSS busy bit is not set, not sure is it same problem.

@Kelvinhack Interesting, could you provide an example of fix to try?

@tandasat you can just have a check Guest TR Ar Bytes bit2 is it set. Ensure it is set before vmlaunch or vmresume.

Edited: Bit 1 , supposed 64bit BUSY TSS is 1011B, so which should be 0x8B  in VMM AR bytes format.

Thanks. It seems guest's TR had an expected value. See the last line in the attached log. The last column is the AR value.
06:29:55.451	DBG	#0	    4	 3980	System         	tr 0040 FFFFF801E6A50000 00000067 0000008b

Oh. Then may be it caused by other problem in Guest Field before Vmlaunch or resume

I would print all of Guest field .. before Vmresume then compared to intel sdm vm entry check

This issue happens even if cr3_load_exiting, mov_dr_exiting, use_io_bitmaps, use_msr_bitmaps, enable_ept, descriptor_table_exiting, and enable_vpid are set to false.
The first core that is visualized often successes to enter VM, and the second core more often gets Invalid Guest State at the very first guest instruction.
Even VM started to run successfully, applications start crashing randomly.
Guest register base VMCS fields do not seem to be broken (values taken right before VMLAUNCH)
diff.htm.txt

According to your second HTM file, I realized that FS Ar byte bit : 7 (0x4073 vs 0x40f3) has been modified by some one else? Intel seem require it always be 1 if the register is used.
Moreover , according to your providing document , GDTR Limit seem always are 0x57 since every-time system crashs,  may be we should find out the reason?
btw, have you used IDA+GDB+VMWare for single stepping a VMM , it think it is good for tracing this problem ? As least it can single-stepping into VMLAUNCH/VMRESUME.

I think GDTR limit is ok, as it is also 0x57 on the system before entering to a VM. FS Ar byte is a weird one, which I was not able to see how come it changed sometime, but even if AR was 0x40f3 (sometimes it is), a system still ran under unstable state I mentioned. Unconditionally setting 1 on the bit does not seem to affect to the bug either.
Debugging VMware is an interesting approach I never thought of :) A challenge in this scenario is that Invalid Guest State vm-exit often does not happen immediately. It sounds challenging to me to catch the moment of the failure.

https://kelvinhack127.blogspot.com/2017/02/through-idavmware-for-debugging-any.html
you can try it , and sometime it is useful for develop and debugging a VMM i think..... we can be able to single stepping VMRESUME and VMLAUNCH

Very interesting, thank you for sharing the technique! Hopefully, I can avoid doing it for this bug (as debugging can be time consuming) but this technique seems quite useful under some circumstances.


[Improve][API] Add IGNORE savemode type

Fix #7430

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

[x] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[x] If you are contributing the connector code, please check that the following files are updated:

Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist
Add ci label in label-scope-conf
Add e2e testcase in seatunnel-e2e
Update connector plugin_config

[x] Update the release-note.

Please update doc.

ok, thanks.


Debugger: Show value of :debug-value if present

When using the debugger, results from :ConjureCljDebugInput eval were not being displayed in the log buffer. It looks like these results are returned in the :debug-value field, so Conjure just needs to check if that field is available and print it if so.
For comparison, here is where the result is read in cider-nrepl, confirming that this is indeed the right field.

This looks good, thank you! I'll give it a go on develop tomorrow.


Setup authentication for Grafana

We've two grafanas - grafana.cloudbank.2i2c.cloud, and grafana.pilot.2i2c.cloud.
Ideally, we'd only have one grafana - but then we'd have to do some network-foo to expose the other prometheus. We don't actually want do that.
Instead, we should just setup GitHub authentication for both the grafanas.

We now have authentication for all of our grafanas, so closing this


我还要

Hi mkkellogg,
I found on Iphone13 with 4G GPU memory，the demo fails to load (but it happens to be successful!).
If i change the ply model to smaller size, the demo works well.
My question is, why the memory usage will increase sharply in loading? It may be the block reason to open bigger size models.
I've also tried upgrading to v0.4.5, but there hasn't been much improvement compared with v0.4.2
Here is my config to open *.ply file in release v0.4.5:
'gpuAcceleratedSort': true,
'antialiased': false,
'sharedMemoryForWorkers':false,
'sceneRevealMode': GaussianSplats3D.SceneRevealMode.Instant,
'freeIntermediateSplatData': true,
'plyInMemoryCompressionLevel': 0,
'optimizeSplatData': false,
'sphericalHarmonicsDegree': 2
'progressiveLoad': false
Is there any thing I'm missing?
Thanks very much in advance~

The problem is relevant to me, for some reason there is a failure at the "Optimizing Data structure" stage

Thanks @Vision70s
I will close this issue because the title was incorrect. I have repeated it as a new issues/364


Cannot import CreateSagaMiddleware

Steps to reproduce

create-react-app myapp
Add   "resolutions": {  "**/**/fsevents": "1.2.9"  } to package.json to solve this issue.
yarn add redux-saga

Here is my repository
Description of the bug/issue
Cannot create middleware because function createSagaMiddleware cannot be imported.
Steps to reproduce the bug/issue
import { applyMiddleware, createStore } from 'redux'
import { composeWithDevTools } from 'redux-devtools-extension'
import { rootReducer } from './reducers/rootReducer'
import rootSaga from './sagas/rootSaga';
import createSagaMiddleware from 'redux-saga'

export default function configureStore(preloadedState) {

    const sagaMiddleware = createSagaMiddleware();
    const middlewareEnhancer = applyMiddleware(sagaMiddleware);

    const enhancers = [middlewareEnhancer];
    const composedEnhancers = composeWithDevTools(...enhancers);

    const store = createStore(rootReducer, preloadedState, composedEnhancers);

    store.sagaTask = sagaMiddleware.run(rootSaga);

    return store
}

Actual results
SagaMiddleware is null because function createSagaMiddleware doesn't exist;
My IDE alerts me that imported module doesn't have a default export declared.
Environment information
macOS 10.15.1
node v12.8.0
yarn 1.17.3
create-react-app 3.1.1
redux-saga 1.1.1

After installing your repository and adding:
import createSagaMiddleware from 'redux-saga'
console.log({ createSagaMiddleware })

I can see:

UPDATE
I've managed to make the program work on my machine with the following configuration.
nvm 0.35.0
node v12.13.0
yarn 1.19.1
Closing the issue


want to add the new script that detect language

Script Title - Detect the Language
Brief - in the script i use the python to get the detection , that is given text is in which language .
i use the the python lib to do this
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md (using this template) in your folder for program Instructions
add requirements.txt if needed

Programming Language

[x] Python

Happy Coding

.take

kindly assign me i love to work on this

Hello @tusharmishra069  may i work on this issue with a bit of your guidance


Generate model name with UpperCamelCase

Close #5
WHY
Multi-words table name is converted to snake_case table name. This is incorrect as Golang struct name.
WHAT
Convert multi-words table name to UpperCamelCase table name.

LGTM!!!


Explicit read/write mode & transitions for azure-client

This work captures the local connectivity state of a given client and letting the developer control transitions between different states specifically for azure-client.
Concerns/Thoughts

This space is not well encapsulated and may make achieving some of these key results impossible without extensive refactoring.

Key Results

[ ] Developer can set the state of the user connection when loading a container
[ ] Developer can understand and transition between states.
[ ] Developer can understand how and when to use this functionality

Note: Currently the developer can choose if the customer is in read/write mode based on the setting in the Token. This work would allow the developer to more explicitly set the connection state of the client when loading a container.

Moved to ADO


hsm: add possibility to update HSM firmware from middleware

This commit:

Adds the AvailableHSMVersion Redis key: hsm:firmware:version
Adds the HSMUpdateAvailable() method to the middleware which
compares the version of the running HSM firmware and the
AvailableHSMVersion Redis key
If a new version is available, the main() function executes the
update via the hsm immediately after the middleware is started
The signed firmware file is assumed to be in
/opt/shift/hsm/firmware-bitboxbase.signed.bin which is the default
value of the hsmFirmwareFile flag
Together with the updateHSMFirmware, this can be used to force flash
firmware from a custom location
If an update is successful, reboot back into the firmware via the
middleware so that the middleware has access to the new hsmFirmware

@Stadicus We will also need to set the AvailableHSMVersion Redis key on build. I'll leave that to you?

@benma Could you please take another quick look over my changes which address your review?


Add formatted logging

Addresses https://github.com/ivahaev/go-logger/issues/1
In essence, I implemented the Infof et. al. functions similar to how the std lib does so https://golang.org/src/log/log.go?s=8723:8767#L280. I then copy the string onto an interface and return the logMessage.
Let me know your thoughts 😄

Thank you and enjoy :)


Only enable pooling for top level allocs

This patch limits the memory pool creation to top level allocs where most of the space should be used. Loop invariant allocs that can be hoisted to the top level will still participate in pooling. Loop-local allocs will not be considered to avoid interference with loop optimizations.

LGTM. Did you evaluate if the total usage of memory increased significantly?
No increase as far as I could tell.

Jenkins Linux s390x Build #1081 [push] Only enable pooling for ... started at 13:25

Jenkins Linux amd64 Build #1083 [push] Only enable pooling for ... started at 12:25

Jenkins Linux s390x Build #1081 [push] Only enable pooling for ... passed after 33 min

Jenkins Linux amd64 Build #1083 [push] Only enable pooling for ... passed after 46 min

Jenkins Linux ppc64le Build #229 [push] Only enable pooling for ... passed after 54 min


remove dead code

Special-casing deletions does not make sense because deletions are not
possible, due to the fact that they are excluded during the generation
of the promotion edges in the first place.

/approve
/lgtm


Switching subreddits in offline mode causes crash

https://www.reddit.com/r/slide_ios/comments/9nh5oa/bug_slide_crash_upon_selecting_subreddit_on/

Merging with #596


(PUP-4394) Improve erroring for WEBrick server when Puppet user doesn't exist

The puppet-agent package does not create the puppet user or group
by default, meaning that attempting to run the webrick server without
manually creating the user results in Puppet failing hard.
This commit updates Puppet's webrick code to first check it the
puppet user exists, and only attempt to switch to it if it does.
Otherwise, we emit an error and exit. Previously, Puppet would
actually try to switch to the non-existent user and throw several
errors. We now only throw one.

CLA signed by all contributors.


Toogle name request: Boost

In Hive, we want to implement "boost" as a toggle for UK thermostats.

In Hive, we want to implement "boost" as a toggle for UK thermostats.

Just for clarity, then name will be boost and will have these name_synonyms:

boost heating
heating boost
boost mode
boost heating mode
heating boost mode

I believe heating won't be necessary as part of any synonym as the action should cover and match that to the devices for us.


vaughnlive.tv plugin broken (503 Service Error..)

Looks like vaughnlive.tv has added some sort of ddos protection from cloudflare on their site. When visiting the home page it will check your browser for 5 seconds before redirecting to the site. This breaks the plugin and throws a "error: Unable to open URL: ........... (503 Service Error: Service Temporarily Unavailable).
This ddos browser check occurs just once and adds a cookie cf_clearance. Using --http-cookie to add that doesn't seem to get past the 503 error. Any ideas?

It's doing it again now :(


OneDrive still get installed when excluded

Even if we exclude everything OneDrive related, it get's installed:
<ExcludeApp ID="Groove" />
<ExcludeApp ID="OneDrive" />
Can this be fixed?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 95a0b1ff-0498-505a-6024-b813980d310f
Version Independent ID: b8057930-b4bd-1304-17ce-5561f837e901
Content: Configuration options for the Office Deployment Tool
Content Source: DeployOffice/office-deployment-tool-configuration-options.md
Service: o365-proplus-itpro
GitHub Login: @jwhit-MSFT
Microsoft Alias: jwhit

Please note that OneDrive is already embedded in Windows 10, so maybe the OneDrive instance you see isn't coming through Microsoft 365 Apps. Is the icon shown on the splash screen during install?

The OneDrive icon is not shown on the splash screen during install. I observe Apps & Features during the installation, and see that OneDrive does get installed. On the image I deploy Windows 10 from, I can confirm that OneDrive is not present in Apps & Features and under AppData for any user, so OneDrive do get installed from Office Deployment-tool even if it is Excluded.

As this issue is not related to the documentation itself, I would recommend to post to https://techcommunity.microsoft.com/t5/microsoft-365-apps-for/bd-p/Microsoft365Apps w/ the config.xml used and the actual build of Microsoft 365 Apps.


Fixes issue with hset return value; also fixes some Redis4 discrepancies

Fixes issue https://github.com/brigade/mock_redis/issues/136.
I also threw in some other fixes as tested against Redis 4.

Thanks a ton for this, @polpak! Merged your changes with a few select commits squashed.


weight prediction experiments

experiment settings

testing set size: 20%
metric: MSE (mean squared error)

experiment results

data set
WSBM (weighted stochastic block model)
Model R

airport
0.0486
0.0136

collaboration
0.0407
0.0352

congress
0.0571
0.0560

forum
0.0726
0.0326

The experiment needs to include multiple trials for each data set with low variance in accuracy in order to make a strong claim that Model R is better than WSBM and its variants.

use t-test to compare the models to make a stronger claim

found the scipy implementation of t-test scipy.stats.ttest_ind_from_stats
confirmed this is Student's t-test from the docs' reference to the wiki page of Student's t-test
decided to choose equal_var=False (i.e., does not assume equal population variance)

To be specific, this is a one-tailed, paired t-test. One-tailed, because we want to know if method 1 is better than method 2. A two-tailed would be used if we just want to know if the methods are different. Paired means that the data used for each trial is the same for method 1 and method 2. When you compute t-statistic, make sure you use the correct formula (paired), and compare to the right threshold (one-tailed).

Got it. I noticed the difference. I'll keep working on the paired one; but meanwhile, let me also do the unpaired one, because it's very cost-efficient as I've got all the data it needs already. I think it still can help me make a stronger claim if pvalue is small enough, even if it's not as strong as the paired one.


[Bug]: to_milvus unstream is unnecessary and causes OOM

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
to_milvus unstreams, causing a memory bottleneck. If inserting 100,000 images into milvus, the pipeline should be streamed.
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- Towhee version(e.g. v0.1.3 or 8b23a93):
- OS(Ubuntu or CentOS):
- CPU/Memory:
- GPU:
- Others:

Anything else?
No response

to_milvus is unstream by default, in order to support inserting different data into different collections:
(
	towhee.glob['path']('./train/*/*.JPEG')
		.image_decode['path', 'img']()
		.image_embedding.timm['img', 'vec'](model_name='resnet50')
                 .image_embedding.timm['img', 'vec'](model_name='resnet101')
		.runas_op['path', 'label'](func = lambda path: path.split('/')[-2])
		.runas_op['path', 'path'](func=lambda path: abs(hash(path)) % (10 ** 8))
		.to_milvus['path', 'vec'](collection=collection_res50, batch=100)
                .to_milvus['path', 'vec'](collection=collection_res101, batch=100)
)

And anyone can add unstream=False to change the mode when using to_milvus, like .to_milvus['id', 'vec'](collection=collection, batch=100, unstream=False).

The default unstream mode may work for demos, how do you think? @filip-halt @reiase

The default unstream mode may work for demos, how do you think? @filip-halt @reiase

can we fix that by returning another DC in to_milvus


Not scrobbling, after resume playback

Most of my tracks are longer DJ-mixes with playtimes more than 1hour. If i pause the playback for a while and resume playback after some time (1 - 3hours later), the track isn't recognized again and not scrobbled. However the now-playing was working, when the track started. Also, when i skip the track and play the next title in the playlist, this new song appears in the now-playing category.

Sorry for the delay,
Can yous hare the app name and some information about your settings in Simple Last.fm Scrobbler.
Did you optimize battery and did you enable OnGoing?


[Bug?] [Question] Append command to heading

Okay so i'm kind of at my wits end.
Resources

(Plugin) Advanced URI v1.38.1
(Plugin) Tasks v4.8.1
(Plugin) Buttons v0.4.19
(Plugin) Periodic Notes v0.0.17

Scenario / What i want
I'd like to add a button/shortcut inside of obsidian to quickly add tasks to my daily note under a certain heading.
To add a task I'd like to execute the Task Command that opens a Modal and inserts the created task at the current line.
Preferably directly under the heading but it's also fine if it appends to the end of that heading section.
URI Versions
According to Command URI documentation
obsidian://advanced-uri?vault=Regular%20planning&commandid=obsidian-tasks-plugin%253Aedit-task&daily=true&heading=ToDo&mode=append

Other attempts
obsidian://advanced-uri?vault=Regular%20planning&commandid=obsidian-tasks-plugin%253Aedit-task&mode=append&daily=true&heading=ToDo

obsidian://advanced-uri?vault=Regular%20planning&daily=true&heading=ToDo&commandid=obsidian-tasks-plugin%253Aedit-task&mode=append

I have tried several other combinations but don't plan on posting them all.
Expected behaviour

Open the current daily note
Move the cursor to a new  line under the header or at the end of the header section
Execute Create Task command
Create and add task to file (But Advanced URI has no role in this step)

Current behaviour
If a heading is specified AND a mode is specified (append/prepend) the heading parametee gets ignored and the cursor moved to the end/beginning of the file
But everything else works as expected/intended
Other notes
I'm most likely just doing something wrong, but I can't for the life of me figure out what.
So sorry for that.

So when you omit the mode, but keep the heading parameter, the task gets inserted at the beginning of the heading, right?

Okay, seems like i got my notes fumbled, sorry!
Also sorry for the late reply, the week suddenly got very busy.
With further testing, this is the current behaviour of different parts of the URI.
1)Remove mode
URI
obsidian://advanced-uri?vault=Regular%20planning&commandid=obsidian-tasks-plugin%253Aedit-task&daily=true&heading=ToDo

Expectation

Open the current daily note
Move directly under the "ToDo"-Heading
Execute the command

Result ❌
Doesn't work as expected

Opens the current daily note
Moves the cursor to the first line in the note (or rather doesn't move the cursor at all, as such it's on the first line) not sure if to the beginning or end of the line
Executes the command

2)Move Note and Heading parameters
URI
Variant 1
obsidian://advanced-uri?vault=Regular%20planning&daily=true&heading=ToDo&commandid=obsidian-tasks-plugin%253Aedit-task

Variant 2 (with mode=append)
obsidian://advanced-uri?vault=Regular%20planning&daily=true&heading=ToDo&mode=append&commandid=obsidian-tasks-plugin%253Aedit-task

Expectation

Open the current daily note
Move the cursor directly under the "ToDo"-Heading or with variant 2 at the end of the section
Execute the command

Result ❌
Doesn't work as expected

Opens the current daily note
[Variant 1] Moves the cursor to the first line in the note (or rather doesn't move the cursor at all, as such it's on the first line) not sure if to the beginning or end of the line
[Variant 2] Moves the cursor to the end of the note
Executes the command

3)Remove command parameter
URI
obsidian://advanced-uri?vault=Regular%20planning&daily=true&heading=ToDo

Expectation

Open the current daily note
Move the cursor to the "ToDo"-Heading

Result✅
Works as expected
4)Use a different command
URI
obsidian://advanced-uri?vault=Regular%20planning&daily=true&heading=ToDo&commandid=editor%253Aset-heading-2

Expectation

Open the current daily note
Move the cursor directly under the heading
Execute the command

Result
Works as expected✅
5)Use a different command that also opens a modal/dialog
URI
obsidian://advanced-uri?vault=Regular%20planning&commandid=buttons%253Abutton-maker&daily=true&heading=ToDo

Expectation

Open the current daily note
Move the cursor directly under the heading
Execute the command

Result ❌
Doesn't work as expected

Opens the current daily note
Moves the cursor to the first line in the note (or rather doesn't move the cursor at all, as such it's on the first line) not sure if to the beginning or end of the line
Using mode results in the cursor being placed at the end of the note


Random empty PDF with html convert endpoint

Hi,
thanks for this great service!
I am currently using v6.3.0 and it worked fine for years. But now I am getting strange results as random requests return empty PDF files.
We use the service on our local staging cluster, and are converting html to pdf files. I do not see any error message, the service returns status code 200 and the empty file. The html input is fine.
The strange thing is that the same html input can lead to a successful or a unsuccessful request.
Can this be a resource issue? I am only triggering one request at time.
edit: resources of the services:

edit2: the source of such a broken file looks like that or totally empty:

Hello @spointecker,
I'd suggest switching to a newer version of Gotenberg 😄 I do not maintain versions 6.x anymore.

Did that already but didn't made a difference. 🤔


framework: add a missing return statement

@roshanch @apjagdale This has to be the problem.
gcc usually does what you want here, which can be very confusing. clang crashes, so much easier to catch this way.

Good catch :+1:


False positives with no discernible signal

Since approximately the last Microsoft hackathon in October there has been a degradation in performance of the inference system. Over this period (Nov through Feb) it feels like the model has been generating more false positives that don't seem to have any sort of signal reminiscent of a killer whale call. I have been wondering if the model has become more sensitive to low-frequencies, possibly due to being re-trained with data that included humpback non-song vocalizations.
However, there are cases where I can't hear (or see in the spectrogram) any tonal, whale-like signals at either high or low frequencies. These false positives are disconcerting and are difficult for moderators to process in large numbers (because they are pretty boring to review! ;). Most often, these candidates have pretty low average confidence (just above the 50% threshold), but here are a couple of recent examples where the average confidence was above 70%!

70.5% confidence example candidate
72.5% confidence example candidate

My impression is that this issue is by far most prevalent for the Orcasound Lab node. In fact, there have been remarkably few candidates for review from Port Townsend and Bush Point in comparison over the last few months. I'm not sure if the differences are related to this performance issue, but here are the tallies for Jan 01 - Feb 28, 2022:

343 Orcasound Lab (97%)
003 Port Townsend (01%)
008 Bush Point (02%)

It took a while to settle in on this apparent change in performance of the inference system, in part because after the hackathon we migrated to a new Azure subscription and experimented with different modes of deploying the code. Additionally, the winter storms caused a suite of physical changes in the hydrophones and deployment conditions at the Orcasound node during this period. A confounding factor is that SRKW transits of the Orcasound hydrophones are decreasing during the same period (which is the normal wintertime pattern), so we have few opportunities to observe the model performance when SRKW calls are present. Nevertheless, these false positives associated only with typical background noise are a significant issue and may indicate a bug and/or a step backwards in model performance, at least for the Orcasound Lab node.
For the last week or so, I've added the fail tag to candidates which only seem to contain "typical" noise for a particular hydrophone location. These can be explored via the OrcaHello Dashboard by searching the tag cloud for fail...

Per Teams conversation today, confirmation from Prakruti and Dave that:

The last model re-training was in 2020 (not 2021)
The model that is currently deployed is the same as what was deployed before migration between Azure subscriptions.

Dave: "PowerPoint refers to retraining on 11-16-20 that reduced false positives by 70%"

Prakruti: "No updates made since 11/15/20 as michelle_mit mentioned that is the latest one. Nothing retrained in 2021. This is the same model used with the old subscription also.
This regression is because the samples are out of domain for our model for whatever reason not because there was any retraining done. If we retrain with these neg samples - performance will improve."
... "As the date suggests that retraining was performed in 2020 not in 2021. Both subscriptions have the same model which is why I think we can eliminate redeployment in 2021 as the cause of the regression."

Example today of a candidate with high average confidence (>75%) and many false positives, but no SRKW or other obvious biological signals, just prominent "gurgling" water sounds with low frequency modulations that sometimes mimic humpback non-song vocalizations --

I wonder if it would be useful to train a general model then fine tune for individual hydrophones.


Work-in-Progress Constantly Saving in Background

As a collection curator,
I would like any work-in-progress to be saved in the background, even if as a draft,
So that I don't have to constantly re-save my work and so that I don't accidentally loose any work.

Related: #97

Merged with #97


Preperation for 2.0.0 alpha

Proposed changes
Changes which are relevant for the next release. 2.0.0 alpha.
The major changes include:

Using Typescript
Using Webpack for building
Removing jQuery / Cash
Themes / DarkMode
Newer M3 Guidlines for Cards, Buttons and Inputs
Using CSS Grid

Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[x] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My commit messages follows the conventional commit format
[x] My change requires a change to the documentation, and updated it accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Please review if you want (many changes!) or tell your concerns, wishes and hopes here. Thank you!

@materializecss/members the feedback of everyone is very welcome.

I merge today, the release will follow in the next days. Have a good day my friends!


[QOL] When requesting a certificate, it'd be great to have feedback for UX.

After pressing enter, nothing happens for a few dozen seconds. I wondered if it was bugged or needed more input.
Suggestion: after pressing enter, return something along the lines of
Please wait while requesting the certificate....this process can take a few minutes

If you request a certificate for a domain managed by Ymir, the certificate gets issued right away. If it isn't, there's actually a warning below the DNS records. You truncated it out of your screenshot, but it says:

The SSL certificate won't be issued until these DNS record(s) are added


Decide on and implement a metadata convention for weather symbols

As an IMPROVER developer, I want to be able to store weather symbols within a netCDF file in a consistent way so that they can be read in and interpreted correctly.
Related issues: #292
This issue should :

Document the existing metadata convention using the existing weather symbol relationships, for example, 0 = Clear night, 1 = Sunny day, 2 = Partly cloudy night.
Create a utility that applies this convention. This utility will be used for creating a cube containing weather symbol information, such that the values that have been attributed to a particular site or grid point, can be cross-referenced to the meaning of the weather symbol easily.

Acceptance criteria:

Document the existing metadata convention for weather symbol codes and their description in Confluence.
Create a utility that can be used for creating a cube and applying the metadata convention.
New criteria: Generate sample data for verification, over several cycles.

There were two PRs for this change: #302  & #306

PR merged and closed on Jira


Add icon to home screen on iPhone 11 Max Pro

remove empty space on iPhone 11 Max Pro
fix ios add to home explanation tooltip on iphone5.should fit inside screen

@AlexeyKosinski is this on ios 13.1? didnt happen to me on 13.2.
i'm unable to find where to download ios 13.1, do you hvae in xcode 13,13.1,13.2?
i have only 12.4 and then 13.2

@AlexeyKosinski I tried to reproduce this issue without success.
Here the screens:

Also, I tested on iPhone 5 - working well.
As I remember you and @StanislavShevchenko recently worked with popup sizes. Maybe your changes fix this issue.
I will move this card to QA. Lets @AnastasiiaOdnoshevna try to reproduce.

@yaroslav-fedyshyn-nordwhale @AlexeyKosinski
I don't have physical iPhone 11 Pro, so I used AWS emulator with 13.1 and check this pop-up with iPhone XS // 13.1.3 and iPhone X // 13.2 beta
The pop-up looks fine, it's aligned to the center


Exchange_time and received_time are the same

Hi! I am running this example:
https://github.com/barter-rs/barter-data-rs/blob/develop/examples/public_trades_streams.rs
Unfortunately I have rather doubtful results
MarketEvent<OrderBookL1>: MarketEvent { exchange_time: 2023-02-06T17:52:17.056798Z, received_time: 2023-02-06T17:52:17.056798Z, exchange: binance_futures_usd, instrument: Instrument { base: btc, quote: usdt, kind: FuturePerpetual }, kind: OrderBookL1 { last_update_time: 2023-02-06T17:52:17.056798Z, best_bid: Level { price: 23041.9, amount: 0.205 }, best_ask: Level { price: 23042.0, amount: 17.663 } } }
Exchange and receive time are the same, I doubt that it is due to hyper fast benefits of this lib, any suggestions? Is this a bug?

Could it be in the nano-seconds @just-a-stream

Hello :)
Thanks for bringing this to my attention. I've improved the situation in barter-data-rs release 0.6.9!
BinanceFuturesUsd now uses the correct timestamp.
However, since the BinanceSpot server does not provide a timestamp for the payload I've had to use the same as received timestamp.
Hope this seems reasonable for you!
Thanks, JustAStream


Add created datetime to node

Instead of the implementation in #697, I'd like to propose this instead.
The problem with #697 is that when you want to find a list of old nodes when you have a list of Node objects, you'd need to write:
old_nodes = [n for n in nodes if n.driver.ex_creation_time(n) > too_old]

Yuk, why is that driver in there? Better would be to write:
old_nodes = [n for n in nodes if n.created > too_old]

I have implemented this code for OpenStack, Digital Ocean and EC2. Other drivers, I have no access to. In those cases, the behaviour is to have created be NoneType.

@tonybaloney, @vdloo

this is a good addition to the base class. I agree with you @allardhoeve it is a good design. :+1:

It's also worth noting that this is a backward incompatible change for any place which doesn't use keyword arguments so we need to make sure it doesn't break any of the existing drivers and document it in the upgrade notes.

I could put the new keyword after the extra=None, that way it breaks nothing. But yes, it should be in the Changelog

I agree, this is better than using the driver and passing the node object in  :+1:

Okey, I changed the field name to created_at and the order of the named arguments. If everyone is on board, I'd like to commit this and revert #697.

:+1: from me


CallerData not showing up using LoggingEventCompositeJsonEncoder

I'm trying to get the caller data in my console logs but it doesn't work. Here's my actual configuration.
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
    <includeCallerData>true</includeCallerData>
    <encoder class="net.logstash.logback.encoder.LoggingEventCompositeJsonEncoder">
        <includeCallerData>true</includeCallerData>
        <providers>
            <timestamp>
                <timeZone>UTC</timeZone>
            </timestamp>
            <message/>
            <callerData>
<EMAIL_ADDRESS>            </callerData>
        </providers>
    </encoder>
</appender>

What am I doing wrong or missing?
Also, at the same time, your readme shows we should be able to set the timeZone only once at the encoder level. But in my case, it doesn't work and I have to specify it under each timestamp element.
And lastly, one more thing I would like to point out, I tried to use the following example
<encoder class="net.logstash.logback.encoder.LogstashAccessEncoder">
    <fieldNames>
<EMAIL_ADDRESS><EMAIL_ADDRESS>    </fieldNames>
</encoder>

but again it didn't work. I had to use the pattern element (which is, in the end, a better fit for my needs anyway).
I'm using the 4.9 version with Logback {core, classic, access} 1.1.7 since I'm building a REST API using Play Framework 2.5.13 which is built with 1.1.7 and has compatibility issues with 1.2.x version of Logback.
Thank you for your help.

Hi @jeep87c ,
I tried your appender example with logstash-logback-encoder 4.9 and logback-core/classic 1.1.7, and I  see the caller data being logged.  Note that I did not use the play framework for this test.  I just had a simple class with a main method that logs a message.  Here's the output that I saw:
{"@timestamp":"2017-04-05T05:02:49.984+00:00","message":"Test","@fields.caller_data":{"caller_class_name":"CallerDataTest","caller_method_name":"main","caller_file_name":"CallerDataTest.java","caller_line_number":88}}

What output do you see?
Setting the timezone at the encoder level only works for LogstashEncoder.  For LoggingEventCompositeJsonEncoder, you must set it at the timestamp provider level, as you have done in your example.  Behind the scenes, the LogstashEncoder just sets the timezone on its built-in timestamp provider.  Keep in mind that LogstashEncoder is just a special case of LoggingEventCompositeJsonEncoder with some built-in providers already configured, and some convenience settings to hide the underlying providers.  LoggingEventCompositeJsonEncoder basically just starts with nothing, and you have to configure it with providers exactly how you want.
I also tried your logback access configuration with jetty, logstash-logback-encoder 4.9, and logback-core/access 1.1.7, and saw the request headers logged.  Here is the output that I saw:
{"@timestamp":"2017-04-04T22:23:23.439-07:00","@version":1,"@message":"<IP_ADDRESS> - - [2017-04-04T22:23:23.439-07:00] \"GET /index.html HTTP/1.1\" 304 0","@fields.method":"GET","@fields.protocol":"HTTP/1.1","@fields.status_code":304,"@fields.requested_url":"GET /index.html HTTP/1.1","@fields.requested_uri":"/index.html","@fields.remote_host":"<IP_ADDRESS>","@fields.HOSTNAME":"<IP_ADDRESS>","@fields.content_length":0,"@fields.elapsed_time":14,"@fields.request_headers":{"Accept":"text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8","Accept-Encoding":"gzip, deflate","Accept-Language":"en-US,en;q=0.5","Connection":"keep-alive","Cookie":"visited=yes","Host":"localhost:8080","If-Modified-Since":"Tue, 10 Mar 2015 13:54:35 GMT","Upgrade-Insecure-Requests":"1","User-Agent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0"},"HOSTNAME":"mint"}

What output do you see?

Thanks for your explanation about LogstashEncoder vs LoggingEventCompositeJsonEncoder. It makes more sense now.
I tried again to log a simple debug/info message "test" from one of my controller using the exact same config then above and here's the output:
{"@timestamp":"2017-04-09T18:02:48.300+00:00","message":"test"}

So unfortunately, no CallerData infos...

Hmm.  I still can't reproduce this.

Are you using any asynchronous appenders? (e.g. LoggingEventAsyncDisruptorAppender, LogstashTcpSocketAppender, AsyncAppender, etc)

Alternatively, Can you create a unit test that reproduces the behavior?

Closing due to inactivity.  If you're still able to reproduce this, please provide the info I have requested.  Thanks!


snapshot testing for component testing

Is it possible to get snapshot testing working for component testing? on the install documents, it is mentioned that where {scheme} defaults to e2e
// cypress/support/index.js for Cypress versions below 10
// cypress/support/{scheme}.js for Cypress versions 10 and above, where {scheme} defaults to e2e
require('./commands')
is it possible to overwrite this {scheme} so it looks into component.js file for component testing as well?
When I configure the framework with component testing this is the error I am getting.

I tried to add compareSnapshotCommand() as a
Cypress.Commands.add('compareSnapshotCommand', compareSnapshotCommand());
but that did not work either.

I have this plugin working with component testing and Cypress version 10. Which version are you using? I don't think I had to deal with this 'scheme' you talk about at all. I just added the relevant setup to the component property of the config. So my cypress.config.js:
const { defineConfig } = require('cypress');
const getCompareSnapshotsPlugin = require('cypress-image-diff-js/dist/plugin');

module.exports = defineConfig({
  component: {
    devServer: {
      framework: 'next',
      bundler: 'webpack',
    },
    setupNodeEvents(on, config) {
      getCompareSnapshotsPlugin(on, config);
    },
  },
});

Then these lines in a cypress/support/component.js just work:
const compareSnapshotCommand = require('cypress-image-diff-js/dist/command');

compareSnapshotCommand();

after(() => {
  cy.task('generateReport');
});

If you do both E2E and component testing in the same repo, then I imagine setup is slightly different, but probably not much more then just having an 'e2e' property in the config alongside the component one.

@JasonFairchild your config seems to be working. Thanks


chore: simplify issue template

R: @kara @robertmesserle
Our current issue template is somewhat noisy, and I think this discourages people from actually following it. I want to try this simpler template and see if it has an affect on people using it.

Platform / Browser / Material2 version?

@hansl it's in there- did you have something specific in mind for how to change it?


Updates to the Hornbill SSO Configuration

Updated the Hornbill Azure AD SSO instructions to include configuration for the Hornbill Mobile Catalog, and the required Replu URL(s)

@jeevansd

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Add pod and service CIDR variables in CAPM3 cluster-templates

This issue is reserved for the KubeCon EU 2024 contrib-fest. Please do not work on it before 2024-03-20.
Service and Pod CIDR blocks in the cluster-template should be overridable with variables in the same was as the CAPD template.
Add variables and keep the default values the same as they are.

/triage accepted
/good-first-issue

@lentzi90 Thanks, I'd like to work on it.
What would be the good starting point to look at ?


Need to add a space between names in chat/prompt panels

It's regression issue. Now:

Expected and how it 's in 0.2.6 version:

Please re-check folders, prompts

Verified on staging successfully.

Note: concerning folder highlight there is separate ticket #326 and #91


How to pass a variable from HomeAction.php to layout/default.phtml and not to app::home-page template

I try this  and work fine  on app:home-page template, but I cant use this on layout/default.php.
$this->template->addDefaultParam(Template\TemplateRendererInterface::TEMPLATE_ALL,'whoisI','Rafael');         return new HtmlResponse($this->template->render('app::home-page', $data));

In ZF3 I got all variable on layout.phtml from Any ControllerAction.

For questions we have slack and forums.
Besides that, I think you are asking a question meant for zend-expressive-zendviewrenderer.
I know that for the twig and plates renderer it works exactly as your example code. As I don't use zend-view myself, I can't help you with that. I suggest to try slack or our forums or report a bug at zendframework/zend-expressive-zendviewrenderer if it isn't working as expected.


404 status code is returned twice

First of all thanks for the plugin, works great so far!
There is one little thing I noticed when monitoring the network traffic:

The status code 404 is returned twice. Once for the document, and another time for what seems to be the same document. Not a real issue, just curious if that is normal.

@gerhard-boden it's not something I've experienced, just checked a couple of sites using the package.. it's likely related to an AJAX request from some Javascript on your page..

Sorry, you're right. Can't really tell where this is coming from at the moment,  but it's definitely site related.


The class name should be updated as "IP_Spider" in Line 79

Line 79:
foo = IP_spider()

should be
foo = IP_Spider()

Thanks DerekTso, I've fixed it.


Add HBase storage system

Hi,
I like to work on this enhancement, could you please guide.

Thanks for offering. I'm planning to do some work soon on the storage parts of Envelope that will probably break an HBase enhancement that is based on the current storage API. I'll reply again when things look more stable.

Thanks for the reply. Shall I take any other issues which may not break after your enhancement to storage API.

Hi ,
Can you please tell me if I can contribute.


Updated demo which wasn't working

The demo was not working primarily because the lambda was attempting to communicate with LocalStack using the localstack network.  The current convention is that LocalStack creates a local network using the service name, in this case, localstack-profile.  The cURL POST command also extra specifications that caused it to hang.  The command has been shortened by creating a data file.   The rest-api id is now accessed from LocalStack so tests don't need to be modified.
In addition to the above, the handler has been changed to support invoking the lambda from the aws cli.  The readme has been modified to explain more of the functioning, and a client-test script was added to run the entire build-deploy-test cycle.

Hi @eisnerw , thank you for your contribution, merging your PR


Create step_1

Summary

Changes

Closes:
Task list

[ ] For workflow changes, I have verified the Actions workflows function as expected.
[ ] For content changes, I have reviewed the style guide.

step

step_1

srepp_1


how long to run speech_recognition/datasets/prepare-librispeech.sh

Dear speech team,
I am trying to prepare the data for speech recognition. I can successfully run the code
https://github.com/pytorch/fairseq/blob/master/examples/speech_recognition/datasets/prepare-librispeech.sh#L71
I have reduced the data into the following (remove train-clean-360 train-other-500)
dev-clean test-clean dev-other test-other train-clean-100
It has been running for almost three days (see following)
PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
267860 XXXX    20   0 1709316 645168   5276 R 100.0   2.0   1142:20 spm_train
I am not sure how long this code will finish. It would be great if you have any experience and give some hint on the acceleration.
Thank you very much
Best,
Shirley

Hi @xwuShirley , LibriSpeech has ~200k utterances and sentencepiece training should be pretty quick (say within 10min). Can you share the full script (your modified version)?

Thanks! see the attached line 35
prepare-librispeech.log

trainer_interface.cc(320) LOG(INFO) SentenceIterator is not specified. Using MultiFileSentenceIterator.
trainer_interface.cc(175) LOG(INFO) Loading corpus: data/lang_char/input.txt
trainer_interface.cc(376) LOG(INFO) Loaded all 171234 sentences
trainer_interface.cc(391) LOG(INFO) Adding meta_piece:
trainer_interface.cc(391) LOG(INFO) Adding meta_piece:
trainer_interface.cc(391) LOG(INFO) Adding meta_piece:
trainer_interface.cc(396) LOG(INFO) Normalizing sentences...
trainer_interface.cc(457) LOG(INFO) all chars count=31790142
trainer_interface.cc(478) LOG(INFO) Alphabet size=28
trainer_interface.cc(479) LOG(INFO) Final character coverage=1
trainer_interface.cc(511) LOG(INFO) Done! preprocessed 171234 sentences.
unigram_model_trainer.cc(138) LOG(INFO) Making suffix array...
unigram_model_trainer.cc(142) LOG(INFO) Extracting frequent sub strings...

It stuck like above

I found the error. It's the path  https://github.com/pytorch/fairseq/blob/master/examples/speech_recognition/datasets/prepare-librispeech.sh#L21

@xwuShirley Good catch, thanks! We will update the script. Not sure how it's related to SentencePiece though.

I found the error. It's the path https://github.com/pytorch/fairseq/blob/master/examples/speech_recognition/datasets/prepare-librispeech.sh#L21

Hi, I faced the same problem. How'd you figure it out? Thanks~


Gather and preprocess data as used in the paper

IMDB corpus
Sentiment corpus
Tense corpus

Only use SST dataset.


Have a complete set of bike facility icons (differentiate bike lockers from bike parking racks)

@nebulon42 good artwork!
bike-rental unfortunately looks a lot like a common symbol for a bike locker like these:
a) http://home.bikestation.com/  (secured bike parking, with security cameras and a gate)
b) http://www.bikelink.org/  (on demand electronic bike lockers, each holding one bike)
c) http://trimet.org/howtoride/bikes/lockersavailable.htm  (reserved bike lockers at given locations: see the icon.  one locker per person)
Bike rental also comes in two very different flavors
a) Bike rental (as at tourist spots for round trip travel)
b) Bike share  (https://www.citibikenyc.com/ primarily for one way short term travel)

There also exist some signs for bike air such as:
http://www.bikefixtation.com/images/products/signage/PA012374.jpg

The bike rental icon is derived from car rental where the key is an essential element to power on the car. Of course, this is not needed for bikes.
But maybe this is not much of a problem as for a bike locker there could be the casing around the bike as in one of your examples or we could use something like a padlock or similar.
As you mention in the title a "complete set of bike facility icons" could you please clearly mention each icon you would like to have in some sort of list with some short explanation and maybe an example? Thanks.
From what I read of your description this might be bike locker, bike sharing and bike air?
I may not able to give it top priority though, as my main goal is now the transition of icons in osm-carto to SVG.

Transition of icons into osm-carto will go smoother if the issues are worked out first, avoiding objection at the changeset merge time.  Here's a view of what a complete set for bikes could look like:

Physical bicycle shop, similar in appearance to other shop icons.

Physical tool stand with bicycle repair tools

Physical bike share location (generally one way trips permitted, part of a network=).

Service offering: bicycle repair

Service offering: bicycle parts

Service offering: bicycle sales

Service offering: bicycle rental (generally staffed.  generally round trips. tourist oriented).

Air fill: Presta valve (bikes)

Air fill: Schrader valve (cars and bikes)

Bike specific traffic regulatory feature (e.g. bike only traffic light or regulatory sign).

Bike specific traffic warning sign (e.g. "warning streetcar tracks ahead").

Parking: bike rack

Parking: public access secured bike cage or on-demand locker (http://www.bikelink.org/)

Parking: reserve in advance cage/locker  (could use symbol for "pre-registration required").

Parking: attended major bicycle parking facility.

Bicycle dedicated symbol (applied to foot prohibited lanes)

The main thing when considering a symbol that will be rendered on a flat map is "will it be useful to a map reader".  The key determinant is often "can I use it without pre-registering"?
I don't want to go to a place marked "bike parking" on the map, and discover I can't actually park my bike without a monthly contract.
Perhaps a standard mini-symbol for "pre-registering required", which could be applied to sewage pumpouts, some toilet schemes, bike lockers, bike share, and more?


Make intermittently failing concurrencyTests more stable.

The test Action concurrency limits should execute activations sequentially when concurrency = 1 fails intermittently. The reason is, that 4 activations are started in parallel.
If there is a delay to one of these activations, the last activation will reuse an existing container, which has already an incremented counter.
This PR changes the action to decrement the counter before leaving the action.
This will also enhance local debugging, as the warm container can be reused.
Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[x] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[x] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #4281 into master will increase coverage by 21.16%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4281       +/-   ##
===========================================
+ Coverage   59.35%   80.51%   +21.16%
===========================================
  Files         162      162
  Lines        7585     7585
  Branches      500      500
===========================================
+ Hits         4502     6107     +1605
+ Misses       3083     1478     -1605

Impacted Files
Coverage Δ

.../org/apache/openwhisk/core/entity/EntityPath.scala
100% <0%> (+1.88%)
:arrow_up:

...a/org/apache/openwhisk/core/entity/Parameter.scala
95.45% <0%> (+2.27%)
:arrow_up:

.../org/apache/openwhisk/http/PoolingRestClient.scala
90% <0%> (+3.33%)
:arrow_up:

...hisk/core/controller/actions/SequenceActions.scala
92.1% <0%> (+3.5%)
:arrow_up:

...pache/openwhisk/core/containerpool/Container.scala
88.6% <0%> (+3.79%)
:arrow_up:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
4% <0%> (+4%)
:arrow_up:

...tainerpool/docker/DockerClientWithFileAccess.scala
96% <0%> (+4%)
:arrow_up:

...rg/apache/openwhisk/core/entity/ExecManifest.scala
97.87% <0%> (+4.25%)
:arrow_up:

...he/openwhisk/core/database/CouchDbRestClient.scala
87.23% <0%> (+4.25%)
:arrow_up:

...a/org/apache/openwhisk/core/entity/TimeLimit.scala
95.45% <0%> (+4.54%)
:arrow_up:

... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a205f8b...b3273f2. Read the comment docs.

I guess this is OK, but I'm not sure what the test failure looks like?

The reason is, that 4 activations are started in parallel.
If there is a delay to one of these activations, the last activation will reuse an existing container, which has already an incremented counter.

But the test is for explicitly reusing the container - are you saying a different test is unexpectedly using the same container? If so, there is still a risk I think in case that other test uses the container before the interval is up that resets the counter. I don't see other tests sharing the same action that uses concurrent.js
Or is this a case where of the 4 activations - one (or more) take > 30s to arrive, which results in rejection? If one arrives after another is rejected, I expect the container to be destroyed and not reused.

@tysonnorris
The test execute activations sequentially when concurrency = 1 creates the concurrent.js action with a concurrency of 1.
Afterwards, 4 activations are started in parallel.
As the concurrency is set to one, there should be 4 user-containers. In each container, the counter will be set to one.
But there could be the issue, that one of the 4 actions arrives with a delay at the invoker. If the delay is high enough, that one of the other 3 actions is already finished, the warm container will be reused, instead of a new one. As the counter is not set to 0 in a warm container, the condition counter == requestCount will never be true (conter is already set to 2, but requestCount is 1).
If an action decrements the counter on leaving again, the counter will always return the amount of actions that are currently inside this container.

@tysonnorris
The test execute activations sequentially when concurrency = 1 creates the concurrent.js action with a concurrency of 1.

ahhhh. sorry I misunderstood. I see the issue now, just have a question about the impl.

@cbickel
I marked this PR as stale to close soon due to long inactivity.
Please feel free to let me know if you would work on it again.


use gopkg.in to make buildable with go modules and dep

Currently when trying to use this package with either Go modules in 1.11 or in a dep environment, the package doesn't build. This change uses the gopkg.in version of the russross/blackfriday project to ensure that the correct version of blackfriday is used.

Thanks for reporting this and sending the PR. I'd like to investigate and understand the issue better.
Can you post the commands for building this with modules in Go 1.11 and the output you get? Is it just go build, or are there some environment variables involved? The build succeeds for me with Go 1.11 Beta 3:
$ go1.11beta3 version
go version go1.11beta3 darwin/amd64
$ go1.11beta3 build github.com/shurcooL/github_flavored_markdown
$

I'm still trying to get a simple reproducible test case for modules. They don't quite work in what I could predictable way yet. :)
When working on getting Buffalo to use Go modules I do occasionally get this:
github.com/shurcooL/github_flavored_markdown
# github.com/shurcooL/github_flavored_markdown
../../../../../development/gocode/pkg/mod/github.com/shurcoo!l/github_flavored_markdown@v0.0.0-20180602233135-8913699a52e3/main.go:71:7: const initializer blackfriday.EXTENSION_NO_INTRA_EMPHASIS | blackfriday.EXTENSION_TABLES | blackfriday.EXTENSION_FENCED_CODE | blackfriday.EXTENSION_AUTOLINK | blackfriday.EXTENSION_STRIKETHROUGH | blackfriday.EXTENSION_SPACE_HEADERS | blackfriday.EXTENSION_NO_EMPTY_LINE_BEFORE_BLOCK is not a constant
../../../../../development/gocode/pkg/mod/github.com/shurcoo!l/github_flavored_markdown@v0.0.0-20180602233135-8913699a52e3/main.go:71:20: undefined: blackfriday.EXTENSION_NO_INTRA_EMPHASIS
../../../../../development/gocode/pkg/mod/github.com/shurcoo!l/github_flavored_markdown@v0.0.0-20180602233135-8913699a52e3/main.go:72:2: undefined: blackfriday.EXTENSION_TABLES
../../../../../development/gocode/pkg/mod/github.com/shurcoo!l/github_flavored_markdown@v0.0.0-20180602233135-8913699a52e3/main.go:73:2: undefined: blackfriday.EXTENSION_FENCED_CODE
../../../../../development/gocode/pkg/mod/github.com/shurcoo!l/github_flavored_markdown@v0.0.0-20180602233135-8913699a52e3/main.go:74:2: undefined: blackfriday.EXTENSION_AUTOLINK
../../../../../development/gocode/pkg/mod/github.com/shurcoo!l/github_flavored_markdown@v0.0.0-20180602233135-8913699a52e3/main.go:75:2: undefined: blackfriday.EXTENSION_STRIKETHROUGH
../../../../../development/gocode/pkg/mod/github.com/shurcoo!l/github_flavored_markdown@v0.0.0-20180602233135-8913699a52e3/main.go:76:2: undefined: blackfriday.EXTENSION_SPACE_HEADERS
../../../../../development/gocode/pkg/mod/github.com/shurcoo!l/github_flavored_markdown@v0.0.0-20180602233135-8913699a52e3/main.go:77:2: undefined: blackfriday.EXTENSION_NO_EMPTY_LINE_BEFORE_BLOCK
../../../../../development/gocode/pkg/mod/github.com/shurcoo!l/github_flavored_markdown@v0.0.0-20180602233135-8913699a52e3/main.go:93:2: undefined: blackfriday.Html

Again, still working on a small repo test case.
As for dep, its very easy to reproduce:
package main

import _ "github.com/shurcooL/github_flavored_markdown"

func main() {}

$ dep init

$ go build
# github.com/gobuffalo/gfmd/vendor/github.com/shurcooL/github_flavored_markdown
vendor/github.com/shurcooL/github_flavored_markdown/main.go:71:7: const initializer blackfriday.EXTENSION_NO_INTRA_EMPHASIS | blackfriday.EXTENSION_TABLES | blackfriday.EXTENSION_FENCED_CODE | blackfriday.EXTENSION_AUTOLINK | blackfriday.EXTENSION_STRIKETHROUGH | blackfriday.EXTENSION_SPACE_HEADERS | blackfriday.EXTENSION_NO_EMPTY_LINE_BEFORE_BLOCK is not a constant
vendor/github.com/shurcooL/github_flavored_markdown/main.go:71:20: undefined: blackfriday.EXTENSION_NO_INTRA_EMPHASIS
vendor/github.com/shurcooL/github_flavored_markdown/main.go:72:2: undefined: blackfriday.EXTENSION_TABLES
vendor/github.com/shurcooL/github_flavored_markdown/main.go:73:2: undefined: blackfriday.EXTENSION_FENCED_CODE
vendor/github.com/shurcooL/github_flavored_markdown/main.go:74:2: undefined: blackfriday.EXTENSION_AUTOLINK
vendor/github.com/shurcooL/github_flavored_markdown/main.go:75:2: undefined: blackfriday.EXTENSION_STRIKETHROUGH
vendor/github.com/shurcooL/github_flavored_markdown/main.go:76:2: undefined: blackfriday.EXTENSION_SPACE_HEADERS
vendor/github.com/shurcooL/github_flavored_markdown/main.go:77:2: undefined: blackfriday.EXTENSION_NO_EMPTY_LINE_BEFORE_BLOCK
vendor/github.com/shurcooL/github_flavored_markdown/main.go:93:2: undefined: blackfriday.Html

Okay, I can reproduce with modules. I have an alternate fix in mind, please take a look at #22 and let me know what you think.

Wouldn't a Gopkg.toml with a constraint solve this for dep?
[[constraint]]
  name = "github.com/russross/blackfriday"
  version = "<2.0.0"


nativeAppChecker: WebLoginOnly() - crashes

Hi, I found this  line of code "nativeAppChecker: WebLoginOnly()", but then I try to add in my app and launch on device, it crashes.

@eugenCodreanu did you try the demo app yet?

Yes. I launch the Example project. Insert all my linked in details. On press login it swith to webpage, but nothing appear, only Cancel button on top left corner. After 1 sec it crash,
WebThread (11): EXC_BAD_ACCESS (code=1, address=0x2ffffff6b)

@eugenCodreanu I updated profile request to version 2, I cannot reproduce the crash, can you try?

@tonyli508
I also facing the same issue. I run the demo code with my Iphone.
Device Specification:
Model: Iphone 6
OS: 10.0
But If I run this demo code with Iphone 7+ with 12.x.x OS.
And it works fine.
Please help me.


Refactored mandatory ptr parameter to reference.

Refactored a mandatory (nullptr is not allowed) pointer parameter to a reference.
See:

https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f17-for-in-out-parameters-pass-by-reference-to-non-const
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f60-prefer-t-over-t-when-no-argument-is-a-valid-option

Google style guide (and cpplint) used to recommend output parameters to be pointer so that you can see an argument is modified:
foo(x, y);     // x and y won't be mutated
bar(x, &y);    // y may be mutated

But I can't find it in the style guide anymore, is this rule outdated?
https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs

But I can't find it in the style guide anymore, is this rule outdated?

I hope so. ;-D


Rename EV to consolidated EV

Change includes:

Reuse COMMUNICATION_SAMPLES_CONNECTION_STRING EV defined in the common KV for samples.
Rename dynamic resource connection string to COMMUNICATION_LIVETEST_DYNAMIC_CONNECTION_STRING

/azp run java - communication - tests


The '??' operator needs updating

The '??' operator does not have documentation and is giving the opposite argument from the expected. Eg. echo undef ?? 'default' prints undef

This will be fixed in version 0.3.4

fixed in v0.3.4


Initial Contact Compression on Thin Walls with Single Element through the Thickness

I have a block impacting a thin walled cylinder with a single element through the thickness. At time t=0, there are nonzero contact forces with clear marking of the domain boundaries. I believe this is because the opposite faces of the thin elements are being detected as 'in contact'. The auto contact penetration scale should catch this and avoid marking those faces as candidates, but this does not appear to be happening.

The above issue appears when using redecomp. The auto contact penetration factor is actually not set in the redecomp code path. This needs to be fixed.

This may not be an issue in redecomp, but an issue with proper auto contact integration into a host code. The element thickness calculation still needs to be studied as it applies to the auto contact penetration factor.

Testing confirmed an integration issue and not an immediately apparent issue with redecomp or the element thickness calculation used for the auto contact length scale.


Vulnerabilities

🐛 Bug Report
NPM reports vulnerabilities upon installing Docusaurus, on Node v10.6.0 MacOS High Sierra
Have you read the Contributing Guidelines on issues?
Yes
To Reproduce

npm install docusaurus -D

Expected behavior
Install Docusaurus without issues
Actual Behavior
NPM reports there are 7 new vulnerabilities
as well as the following
npm WARN deprecated<EMAIL_ADDRESS>Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools. npm WARN deprecated<EMAIL_ADDRESS>gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5 npm WARN deprecated<EMAIL_ADDRESS>CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
Upon running 'npm audit'

Reproducible Demo
None, just install Docusaurus

This is caused due to imagemin dependency on Docusaurus. I think the right place to file the issue is at https://github.com/imagemin


Accessibility fixes

Fixes:
https://github.com/dotnet/aspnetcore/issues/42345
https://github.com/dotnet/aspnetcore/issues/42341
https://github.com/dotnet/aspnetcore/issues/42366
https://github.com/dotnet/aspnetcore/issues/42367
https://github.com/dotnet/aspnetcore/issues/42368

Since it's important that these issues are resolved on a particular timeframe, I'm going to merge this now even though we might later change some aspects of the .btn:focus, .btn:active:focus styling depending on what we decide about IdentityUI.


chore: fix some comments

[ ] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[ ] Added entry in .changelog/

Superseded by #1460


Add z clamp in Jacobian of projection

As done in project() function, clamping z values avoids zero division. That is the cause (at least one of them) of the NaN values that appeared in some issue threads.

Nice catch, thanks!


Removed/fixed duplicated code

name: removed duplicated method html_safe_last_name
name_sn: fixed duplicated case
company_se: fixed duplicated case

Thanks


Documentation

Validate documentation for all extensions:

Rates:

[x] preinstall
[x] postinstall
[x] extensions.yaml
[x] generate readme

Track Label:

[ ] preinstall
[ ] postinstall
[ ] extensions.yaml
[ ] generate readme

Validate Address:

[ ] preinstall
[ ] postinstall
[ ] extensions.yaml
[ ] generate readme

@forksofpower how close is this to being done?


constant OpenSSL::Cipher::Cipher is deprecated

OpenSSL::Cipher::Cipher has been deprecated in favor of OpenSSL::Cipher per this doc.

I just fixed it in my fork: https://github.com/jalerson/aes
You just need to refer to my repository in your Gemfile:
gem 'aes', git: 'https://github.com/jalerson/aes'

Just as a heads up, this may break you implementation if you used a key or iv longer than 16 bytes https://github.com/ruby/ruby/commit/ce635262f53b760284d56bb1027baebaaec175d1

Is this the solution?
Is there any official fix?
I'm having this problem after upgrading ruby to 2.5.3

@dotanlang actually that repo no longer exists.

The problem is fixed on the master branch: gem 'aes', git: 'https://github.com/chicks/aes'

Sorry folks, I'd gotten maintainership last year intending to take care of this but then let it fall through the cracks. Now, 0.5.1 is finally released resolving this deprecation warning.


Added regression_MWI_score function

Description
This is an efficient implementation for calculating the mean Winkler interval score, based on the code written by Kaggle user AmbrosM and published in the topic "Accelerating the scoring function".
Fixes #407
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?
Private testing was performed in the Kaglge competition Prediction interval competition I: Birth weight by comparing correspondence with the results to those output by the competition metric code published in Winkler Interval score metric.
Update (2024-02-27)
A test routine for the function regression_MWI_score has been written and added to the end of mapie/tests/test_metrics.py (b101cb0).
Checklist

[x] I have read the contributing guidelines
[x] I have updated the HISTORY.rst and AUTHORS.rst files
[x] Linting passes successfully : make lint
[x] Typing passes successfully : make type-check
[x] Unit tests pass successfully : make tests
[x] Coverage is 100% : make coverage
[ ] Documentation builds successfully : make doc

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (614293e) to head (5ebeee1).
Report is 267 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #408    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           39        39
  Lines         4616      4896   +280
  Branches       487       801   +314
==========================================
+ Hits          4616      4896   +280

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

We should definitely add some documentation, but we can do this in a separate PR, so this is pushed through as quickly as possible!


Indent multi-line return value descriptions in docstrings

I guess you did this with an automatic tool and this is why it is also affecting Args:, Raises: and some body function, right? It might be a good idea to mention this in the commit too, but it is just a nitpick so I'm fine with leaving it as it is too.

I've updated the commit message.

did you somehow tested it

no,  do you have the documentation generation code in your fork?  maybe that can be rebased on this to test?

@sahas-subramanian-frequenz I created a (draft) PR for the channels repo: https://github.com/frequenz-floss/frequenz-channels-python/pull/25, it should be fairly easy to just apply the same patch to this repo and try it out if you are very eager to do so, otherwise we can just wait a bit longer to merge this :)

Rebased on to latest 0.x.x


Cargo.toml example for embassy_i2c.rs

Does anyone have a Cargo.toml file using the ESP32 C6 (or C3) for the embassy_i2c.rs example.  I am stuck trying to update dependency esp_hal to version 0.19.0 which appears to have the embassy feature removed.
If I add the esp-hal-embassy crate I get this build error:
#[esp_hal_embassy::main]
|                    ^^^^ could not find main in esp_hal_embassy
Also, it looks like the let timg0 = TimerGroup::new(  ...  statement is missing an 'isr' argument.  I wonder how that is created.

Generally, the main branch is the "next"/WIP version - when looking into examples for a released version it's better to look at the corresponding tag: https://github.com/esp-rs/esp-hal/tree/v0.19.0

Thanks, the v0.19.0 release branch examples helpful.  Problem solved.


Add some Py03 Bindings

That way people could use it from Python which is a far more common programming language for scripting in the Industrial Automation world.

I couldn't figure out a way I was happy with to have the Python bindings within the same crate. So I instead created a new crate just for the Python bindings that use this one. I actually did this a couple of months ago but forgot to close this issue. The Python bindings can be found at https://github.com/Vadoola/ab_versions_py


tests/kernel/sched/schedule_api/ fails on LPC54114_m4

Describe the bug
test_slice_scheduling fails
To Reproduce
Steps to reproduce the behavior:

mkdir build; cd build
cmake -DBOARD=LPC54114_M4 ..
make
See error

Expected behavior
PASS
Impact
slice_scheduling
Screenshots or console output
***** Booting Zephyr OS version 2.0.0-rc1 *****

Running test suite threads_scheduling

===================================================================

starting test - test_bad_priorities

PASS - test_bad_priorities

===================================================================

starting test - test_priority_cooperative

PASS - test_priority_cooperative

===================================================================

starting test - test_priority_preemptible

PASS - test_priority_preemptible

===================================================================

starting test - test_yield_cooperative

PASS - test_yield_cooperative

===================================================================

starting test - test_sleep_cooperative

PASS - test_sleep_cooperative

===================================================================

starting test - test_sleep_wakeup_preemptible

PASS - test_sleep_wakeup_preemptible

===================================================================

starting test - test_pending_thread_wakeup

PASS - test_pending_thread_wakeup

===================================================================

starting test - test_time_slicing_preemptible

PASS - test_time_slicing_preemptible

===================================================================

starting test - test_time_slicing_disable_preemptible

PASS - test_time_slicing_disable_preemptible

===================================================================

starting test - test_lock_preemptible

PASS - test_lock_preemptible

===================================================================

starting test - test_unlock_preemptible

PASS - test_unlock_preemptible

===================================================================

starting test - test_unlock_nested_sched_lock

PASS - test_unlock_nested_sched_lock

===================================================================

starting test - test_sched_is_preempt_thread

PASS - test_sched_is_preempt_thread

===================================================================

starting test - test_slice_reset

PASS - test_slice_reset

===================================================================

starting test - test_slice_scheduling

ABCDEFGHI

ABCDEFGHI

ABCDEFGHI

A

    Assertion failed at ZEPHYR_BASE/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:63: thread_tslice: ((tdelta >= expected_slice_min) && (tdelta <= expected_slice_max) && (idx == thread_idx)) is false

B

    Assertion failed at ZEPHYR_BASE/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:63: thread_tslice: ((tdelta >= expected_slice_min) && (tdelta <= expected_slice_max) && (idx == thread_idx)) is false

C

    Assertion failed at ZEPHYR_BASE/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:63: thread_tslice: ((tdelta >= expected_slice_min) && (tdelta <= expected_slice_max) && (idx == thread_idx)) is false

D

    Assertion failed at ZEPHYR_BASE/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:63: thread_tslice: ((tdelta >= expected_slice_min) && (tdelta <= expected_slice_max) && (idx == thread_idx)) is false

E

    Assertion failed at ZEPHYR_BASE/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:63: thread_tslice: ((tdelta >= expected_slice_min) && (tdelta <= expected_slice_max) && (idx == thread_idx)) is false

F

    Assertion failed at ZEPHYR_BASE/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:63: thread_tslice: ((tdelta >= expected_slice_min) && (tdelta <= expected_slice_max) && (idx == thread_idx)) is false

G

    Assertion failed at ZEPHYR_BASE/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:63: thread_tslice: ((tdelta >= expected_slice_min) && (tdelta <= expected_slice_max) && (idx == thread_idx)) is false

H

    Assertion failed at ZEPHYR_BASE/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:63: thread_tslice: ((tdelta >= expected_slice_min) && (tdelta <= expected_slice_max) && (idx == thread_idx)) is false

I

    Assertion failed at ZEPHYR_BASE/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:63: thread_tslice: ((tdelta >= expected_slice_min) && (tdelta <= expected_slice_max) && (idx == thread_idx)) is false

    Assertion failed at ZEPHYR_BASE/tests/kernel/sched/schedule_api/src/test_slice_scheduling.c:63: thread_tslice: ((tdelta >= expected_slice_min) && (tdelta <= expected_slice_max) && (idx == thread_idx)) is false

FAIL - test_slice_scheduling

===================================================================

starting test - test_priority_scheduling

PASS - test_priority_scheduling

===================================================================

starting test - test_wakeup_expired_timer_thread

PASS - test_wakeup_expired_timer_thread

===================================================================

starting test - test_user_k_wakeup

PASS - test_user_k_wakeup

===================================================================

starting test - test_user_k_is_preempt

PASS - test_user_k_is_preempt

===================================================================

Test suite threads_scheduling failed.

===================================================================

PROJECT EXECUTION FAILED

Environment (please complete the following information):

OS: Linux
Toolchain (e.g Zephyr SDK, ...)
R2.0.0-rc1

@MaureenHelm

I think this should be a random (sporadic) fail of the notorious time-slicing test, and nothing to do with this board. It passes for me, locally, on the same board.
Can we have @andyross look at the scheduling test?

Can't reproduce this as well, it maybe spuroius as @ioannisg mentions.
@hakehuang is there any other detail in reproducing this issue?

@hakehuang could youhelp us a bit more in this issue?

@ioannisg , I just download it to board and run it.  let me try to find a easy way to reproduce it.

I've reproduced this issue by doing git checkout v2.0.0-rc1
It does pass on the latest codebase.

Same results for me. I am closing this, then. Please, re-open if needed, @hakehuang .

@agansari this is, once more, not reproducible, on current master. What's your take - shall we close the issue again? Could you try it yourself as well?

@ioannisg as i last remember it's related to #18651, this means it will not reproduce every time.
Will try to reproduce this issue again today.

Tested 5 times on master branch, will be closed as it passes.


greetd: 0.9.0 -> 0.10.0

Updating greetd from 0.9.0 to 0.10.0 with sha256 from nurl. How do you get the cargoHash?
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Commit message should be greetd: 0.9.0 -> 0.10.0

Mass ping, closing - please properly branch off master and open a new PR

Mass ping, please resubmit.

Mass ping, please resubmit.


[add feature]: Background change with cool css effects

Want to add background image and cool css effects

@Jivan052 please assign this issue to me

Hi @Hunter764 I will close issue in next 2 days. It will good if you create PR for proposed issue.

@Jivan052 assign this issue to me


GoToDefinition doesn't always work in template classes

I created a minimal working example for go-to-definition not working inside a template class:
struct A {
  void foo() {}
};

template <int N> struct B {
  const int n = 3;
  static constexpr int m = 3;
  A a;

  void bar() {
    this->a.foo();

    B<N> *p;
    p->a.foo();

    B<n> *q;
    q->a.foo();

    B<m> *r;
    r->a.foo();

    const int k = 3;
    B<k> *s;
    s->a.foo();

    B<3> *t;
    t->a.foo();
  }
};

In the above example, go-to-definition works only on the last two calls to a.foo().
This is surprising, given that hovering on any a correctly recognizes the type as struct A.
The output of the clangd extension doesn't show any error (a textDocument/definition is sent to the server, and a reply is received, I'm guessing it's an empty one).
System information
Output of clangd --version:
clangd version 10.0.0 (https://github.com/llvm/llvm-project d32170dbd5b0d54436537b6b75beaf44324e0c28)

Editor/LSP plugin:
vscode-clangd v0.1.6

Operating system:
Debian GNU/Linux 8 (jessie) 64-bit

Unfortunately, this is a regression in Clangd 10.0 that you are using. This bug is no longer present at HEAD. You can download latest Clangd snapshot here https://github.com/clangd/clangd/releases or have VSCode download it for you.

Thanks for the quick response.
What do you mean by "have VSCode download it"? Doesn't it download the latest stable release?
Anyway, I downloaded it manually and the go-to-definition problem is indeed fixed in that version.
There are still other, seemingly related issues:

Find references on A::foo returns just the last two calls (s->a.foo() and t->a.foo())
Hover information on any of the first 4 a.foo() calls is empty

Should I open another issue for the problems I mentioned?

No, this one is fine as it's still open.

1. Find references on `A::foo` returns just the last two calls (`s->a.foo()` and `t->a.foo()`)

This is a known issue, on file as #258. Note that the solution I suggest in that issue wouldn't handle this snippet exactly as written, only in the case where B::bar() is actually instantiated somewhere in the project. We could conceivably go with a heuristic approach instead (or in addition) that would handle the snippet as written.

We could conceivably go with a heuristic approach instead (or in addition) that would handle the snippet as written.

It looks like the heuristic approach has come up already as well, as in tracked in #399. I think we can consider the find references part of this a duplicate of that.
Will keep this open to investigate the hover part further.

Ha! It turns out that the reason go-to-definition works for the first four cases is via the textual heuristic; AST-based attempts fail.
So, we have a couple of options for fixing this:

Get hovers to use a textual heuristic as well (tracked in #303)
Improve our AST-based heuristics so they handle these cases

The reason our current AST-based heuristics fail is that an expression like this.a->foo is two nested CXXDependentScopeMemberExprs: this->a (with base expression this and member name a), and this->a.foo (with base expression this->a and member name foo).
Our current heuristic handles cases where the base expression's type resolves to a template specialization type or similar; so it works for this->a because the type of this resolves to B<N>. However, it does not work for this->a.foo because the type of this->a is a dependent type.

So, we have a couple of options for fixing this:
* Get hovers to use a textual heuristic as well (tracked in #303)

* Improve our AST-based heuristics so they handle these cases

The choice here also affects whether or not #399 will actually fix the find-refs part of this. If we go with the textual approach, #399 will not fix the find-refs part (unless we get find-refs to use a textual heuristic as well, which is less likely to fly).

For this reason, I'd like to at least explore improving our AST-based heuristics.

I was able to get this to work: proposed patch.


[cli] Listing a lot of clusters takes a long time

When listing clusters, there is a secondary call for every cluster to get a node count for that cluster, this is obviously bad in a setup running a high number of clusters.
This should be moved into a formatter for the cluster so the CLI can stop doing the extra calls.

This is available in cli v2.4.3-rc1 2.4 master

Testing should include the CLI to validate node counts, and the API by looking at the cluster object which now has a node count.
Without running a lot of clusters the slowness won't be visible.

Ran Benchmarks on a Rancher v2.4-head server with 25 clusters
Previously, using cli v2.4.0:
Time (mean ± σ):      6.902 s ±  0.379 s   [User: 135.6 ms, System: 33.3 ms]
Range (min … max):    6.405 s …  7.325 s

With v2.4.3-rc1:
Time (mean ± σ):      4.734 s ±  0.583 s    [User: 75.0 ms, System: 14.6 ms]
Range (min … max):    3.697 s …  5.044 s

Time has been reduced by approx. 31%
Correct node counts are still returned in the rancher cluster ls call.
Also validated in cluster API there is a field called nodeCount which lists the correct number of nodes

Ran Benchmarks on a Rancher v2.4-head server with 120 clusters
Previously, using cli v2.4.0:
Benchmark #1: rancher cluster ls
  Time (mean ± σ):     41.345 s ±  0.610 s    [User: 281.0 ms, System: 81.3 ms]
  Range (min … max):   40.322 s … 41.882 s    5 runs

With v2.4.3-rc1:
Benchmark #1: rancher cluster ls
  Time (mean ± σ):     24.802 s ±  0.662 s    [User: 110.8 ms, System: 20.9 ms]
  Range (min … max):   23.670 s … 25.421 s    5 runs

Time reduction is more significant as we increase cluster size.
This has been fixed


How does offline transaction signing work in burrow?

I am a bit familiar with how offline transaction signing works for hyperledger fabric. I am not sure how offline transaction signing works in burrow. Can someone guide me with an example or a documentation?

Thanks for your question @sueno51! The current setup involves something called 'mempool signing', whereby any node with access to the corresponding keys for an input account will sign an unsigned transaction received over GRPC. In addition, the same server also exposes an endpoint to explicitly sign raw transactions. I would note however that we intend to change the core functionality of transaction signing here, so watch this space!