Remove double price for the same token in clearing prices

I found an ugly bug: If the clearing price is not unique in the clearing price table, it will duplicate many entries and will find too many internal trades. This caused our slippage results to be for quasimodo.
One example is the tx from the new test. It happened only for settlements with liquidity orders and hence it was hard to find.
Testplan:
Understand the unit test. Make sure the prices from the clearing price table are unique.

I think we use it only for value estimations. And these values are compared against other values with a range comparison. Hence small modifications in the price will only have small modifications in the values and hence the range comparisons will most of the time be the same.
What are you concerns?


RailsScript Support

Adds support for RailsScript by including an Element to initialize Cocoon.  This does not affect Cocoon in anyway.
Since RailsScript is compatible with Turbolinks, this also adds turbolinks support.

Interesting. I had never of railsscript. I had a quick look, not quite sure what the advantage is? Could you explain it?
From what I deduce it gives a standard way of writing your javascript, but other than that I see no advantage. The "controllers" seem to suggest you are doing something client MVC like, but you are just defining code that will be called for the responding controller+action.
I personally prefer a more general approach: my javascript will respond to items being on the page, and I my body tag always has the controller + action as classes (if I would need something really specific in js or css dependency).
Anyway: seems interesting. As for this implementation: I am in the process of (really slowly --not spending enough time on it) converting the cocoon js to coffeescript and a class (and refactoring in the process, so bits could be reused more), so that would alleviate the need for this entirely. Also: this completely copies the js to coffee, this would mean having to maintain the code twice (at this moment).

RailsScript is meant to create clean and maintainble JS that is compatible with Turbolinks.  So all your JS is loaded and initialized at once, which speeds up page load times on get requests, since it's only replacing html and no re-initializing all the JS and CSS.  Pairing this with the RailsScript page transitions, https://github.com/gemgento/rails_script/wiki/Turbolinks-Page-Transitions, you get a single page application feel in addition to the decreased load times.
Your right about duplicating the code base.  I'm just going to modify my fork further to eliminate the duplicated code and I will maintain it separately.  Though it has already been converted to coffeescript, so feel free to grab that part.


Update books.md

Add Collecting Field Data with QGIS and Mergin Maps

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @geomenke would you mind signing the OSGEO CLA please?

(and congrats on the new book!)

Done! Thanks :)


[Android package] Support QR code Parsing

Problem
<what's wrong or missing, please include any applicable:

expected behavior
actual behavior
steps to reproduce
system configuration
screenshots, images, logs, etc.

Proposed Solution
<suggested fix, suggested enhancement>

This is already done and tracked by #1103
@franck-apple, I'll defer to you to appropriately close it.

SW BRB: Closing

SW BRB: Closing


Feat/motion monitor

add motion monitor

Good Job!
The next step would be how to analyze these data and generate reports.


Update .travis.yml with latest Rails and Ruby versions

Sorry we missed this somehow, addressing in #96


admin_bdy branch: run AIMS database functions

Final step in the process is to run the AIMS database functions for updating reference data. Will need to check the return codes and raise message appropriately.
fnreferencedataupdatelocality
fnreferencedataupdatemeshblock

Using sh script to coordinate. Have comment/added these but only populating temp table (not table in admin_bdy schema) will need go-ahead before a run. See last push

Great.


Update lang.json

Added Hebrew (he-IL) version.

Sorry, I think I will on hold adding new languages at the moment, because I don't think there's enough UI space to select more languages (which requires redesign the layout), also it would be hard to maintain while new features with extra language keys are currently in development. (You still can use it in your own installation though.)


Data Table - Styling issue with sticky header

I enabled sticky header in the table component.
Issue:

Seems like having issue with size: short. Extra space is coming after header row.
Its only working fine for normal: size

@abhisheksinghrana doesn't seem to be happening any more in storybook. Do you still have this issue?

@abhisheksinghrana doesn't seem to be happening any more in storybook. Do you still have this issue?


Logged in user not being saved to storage

I am new to flutter and am trying to get my application integrated with aws cognito.
I took your example main.dart file and replaced the following code in the login screen class (sending the user to a new screen instead of displaying the snackbar message. I tested with the message and it does display I am logged in.
/**
final snackBar = new SnackBar(
content: new Text(message),
action: new SnackBarAction(
label: 'OK',
onPressed: () {
if (signUpSuccess) {
Navigator.pop(context);
if (!_user.confirmed) {
Navigator.push(
context,
new MaterialPageRoute(
builder: (context) =>
new ConfirmationScreen(email: _user.email)),
);
}
}
},
),
duration: new Duration(seconds: 30),
);
Scaffold.of(context).showSnackBar(snackBar);

**/
Navigator.push(
context,
MaterialPageRoute(builder: (context) => SecondScreen()),
);
On the second screen, I moved the copied the code from the _SecureCounterScreenState class in the main.dart example file to build my own screen:
class _SecondScreenState extends State {
final _userService = new UserService(userPool);
User _user = new User();
bool _isAuthenticated = false;
CognitoUser _cognitoUser;
Future _getValues(BuildContext context) async {
try {
await _userService.init();
_isAuthenticated = await _userService.checkAuthenticated();
if (_isAuthenticated) {
// get user attributes from cognito
_user = await _userService.getCurrentUser();
_cognitoUser = await _userService.getCognitoUser();
    // get session credentials
    final credentials = await _userService.getCredentials();
  }
  return _userService;
} on CognitoClientException catch (e) {
  if (e.code == 'NotAuthorizedException') {
    await _userService.signOut();
    Navigator.pop(context);
  }
  throw e;
}

}
@override
Widget build(BuildContext context) {
final f = new DateFormat.yMMMMd("en_US");
return new FutureBuilder(
    future: _getValues(context),
    builder: (context, AsyncSnapshot<UserService> snapshot) {
      //if (snapshot.hasData) {
        //if (!_isAuthenticated) {
        //  return new LoginScreen();
        //}

        return new Scaffold(
          appBar: AppBar(
            title: Text(f.format(new DateTime.now())),
            backgroundColor: Color.fromARGB(255, 234, 100, 34),
          ),
          body: new Container(
            decoration: new BoxDecoration(
              color: Color.fromARGB(255, 212, 43, 63),
            ),
            child: _cognitoUser == null
                ? Container(
              child: Text("null"),
            )
                : Container(
              child: Text(_cognitoUser.getUsername()),
            ),
          ),
        );
      //};
    }
);

}
}
If I uncomment this code:
if (snapshot.hasData) {
//if (!_isAuthenticated) {
//  return new LoginScreen();
//}
I receive a builder returned null error.
With it commented out, _cognitoUser == null
Can you help me understand what I am doing wrong?
I am trying to use the login screen, then send the user to a second screen that uses displays the cognito user's username. The storage doesn't seem to be either saving or retrieving the user properly.
Thanks for your help

Hi @bbradley72, can you help to format the code? Cheatsheet here. It's a bit hard to read at the moment. Thanks.

Sorry, I should have previewed it before I submitted. Thanks for your help.
I am new to flutter and am trying to get my application integrated with aws cognito.
I took your example main.dart file and replaced the following code in the login screen class (sending the user to a new screen instead of displaying the snackbar message. I tested with the snackbar message and it does display I am logged in.
/**
final snackBar = new SnackBar(
	content: new Text(message),
	action: new SnackBarAction(
	label: 'OK',
	onPressed: () {
		if (signUpSuccess) {
			Navigator.pop(context);
			if (!_user.confirmed) {
				Navigator.push(
					context,
					new MaterialPageRoute(
						builder: (context) => new ConfirmationScreen(email: _user.email)),
					);
				}
			}
		},
	),
	duration: new Duration(seconds: 30),
);

Scaffold.of(context).showSnackBar(snackBar);
**/

Navigator.push(
	context,
	MaterialPageRoute(builder: (context) => SecondScreen()),
);

On the second screen, I moved the copied the code from the _SecureCounterScreenState class in the main.dart example file to build my own screen:
class _SecondScreenState extends State {
	final _userService = new UserService(userPool);
	User _user = new User();
	bool _isAuthenticated = false;
	CognitoUser _cognitoUser;

	Future _getValues(BuildContext context) async {
		try {
			await _userService.init();
			_isAuthenticated = await _userService.checkAuthenticated();
			if (_isAuthenticated) {
				// get user attributes from cognito
				_user = await _userService.getCurrentUser();
				_cognitoUser = await _userService.getCognitoUser();

    			// get session credentials
    			final credentials = await _userService.getCredentials();
  			}
  			return _userService;
		} on CognitoClientException catch (e) {
  			if (e.code == 'NotAuthorizedException') {
    			await _userService.signOut();
    			Navigator.pop(context);
  			}
  			throw e;
		}
	}

	@override
	Widget build(BuildContext context) {
		final f = new DateFormat.yMMMMd("en_US");

		return new FutureBuilder(
	    	future: _getValues(context),
	    	builder: (context, AsyncSnapshot<UserService> snapshot) {
	     	 	//if (snapshot.hasData) {
	        		//if (!_isAuthenticated) {
	        			//  return new LoginScreen();
 	       			//}

 	       			return new Scaffold(
          				appBar: AppBar(
            				title: Text(f.format(new DateTime.now())),
	            			backgroundColor: Color.fromARGB(255, 234, 100, 34),
    	      			),
        	  			body: new Container(
            				decoration: new BoxDecoration(
              				color: Color.fromARGB(255, 212, 43, 63),
	            		),
    	        		child: _cognitoUser == null
        	        		? Container(
            	  				child: Text("null"),
            				)
                			: Container(
          	    				child: Text(_cognitoUser.getUsername()),
            				),
          				),
	        		);
    	  		//};
    		}
		);
	}
}

If I uncomment this code:
if (snapshot.hasData) {
//if (!_isAuthenticated) {
	// return new LoginScreen();
//}

I receive a builder returned null error.
With it commented out, _cognitoUser == null
Can you help me understand what I am doing wrong?
I'm basically just testing the storage of the cognito user using this code, but it always is displaying null on the second screen. Once I figure that out, I should be able to the JWT token and make my API calls to lambda.
child: _cognitoUser == null
	? Container(
		child: Text("null"),
	)
	: Container(
		child: Text(_cognitoUser.getUsername()),
	),
),

I am trying to use the login screen, then send the user to a second screen that uses displays the cognito user's username. The storage doesn't seem to be either saving or retrieving the user properly.
Thanks for your help

Hi Jon,
I think I solved the issue. I had moved the signupscreens and userservice to their own files and imported them into main.dart using a relative path. Apparently, you have to use package:my_package_name/filename.dart in main or things don't work properly.
See this defect:
https://github.com/dart-lang/sdk/issues/33076
I changed:
import 'constants.dart';
import 'signupscreen.dart';
import 'userservice.dart';
to:
import 'package:my_package_name/constants.dart';
import 'package:my_package_name/signupscreen.dart';
import 'package:my_package_name/userservice.dart';
now when i proceed to the secondscreen, it displays my username as expected.
This also worked when I closed the app and restarted it.
It appears my issue was a dart defect unrelated to this code.
I'm going to close this issue.
Thanks for helping me. Sorry for the newbie question, this is my first flutter/dart project.


Shortcut for Copy in sql editor not wroking nor Right Click

In Sql editor shortcut for copy (Ctrl+c) and right click pop menu not working
I am running omnidb as desktop application in ubuntu 16.04 64bit
I dont know is this a bug or some configuration issue

Hi @heejit ,
You are right that on the app version the right click inside the editor is disabled. We will include this for the next version. On the server version, you are able to use the right click menu provided by the browser.
I tested the app version here in an Ubuntu 16.04 LTS 64-bit virtual machine and I found no problems using Ctrl-C, Ctrl-X and Ctrl-V:

OmniDB allows you to configure shortcuts. Do you have a shortcut set for Ctrl-C?

Regards,
William Ivanski

no shortcut with ctrl+c

That is very strange. Can you do some tests for us?
1- Can you confirm that ctrl-c / ctrl-x / ctrl-v is working outside of OmniDB?
2- Can you try to paste (Ctrl-v) in OmniDB's editor something that was copied from another app? Firefox, chrome, anything.
3- Can you try to paste in another editor something that was copied (that you tried to copy with Ctrl-c) from OmniDB's interface?
Rafael.

1- Can you confirm that ctrl-c / ctrl-x / ctrl-v is working outside of OmniDB?
Yes
2- Can you try to paste (Ctrl-v) in OmniDB's editor something that was copied from another app? Firefox, chrome, anything.
Ctrl + v is working
3- Can you try to paste in another editor something that was copied (that you tried to copy with Ctrl-c) from OmniDB's interface?
Pressing Ctrl+c not copying anything

Hi @heejit ,
Does Ctrl-x work on OmniDB?
Also, what is the graphical environment you use on Ubuntu?

Ctrl+x work as expected
graphical env - Xfce

till ctrl+c added ctrl+x will be helpfull

Hi @heejit ,
We were not able to simulate your issue. However, since we last spoke, many improvements were made to the interface. Can you please try again to see if all shortcuts work as expected?
Best regards,
William

shortcut are working fine  thanks

Thanks for your feedback. Closing this.


option to use partner ast_pkg

Signed-off-by: Sharon Topaz<EMAIL_ADDRESS>Adding an option to use partner ast_pkg instead of open source ast_pkg

This looks fine to me. Over to @tjaychen and @msfschaffner.

please fix the CI failure. Looks like some tests timed out as CI ran over 45 mins. Otherwise, LGTM.

@weicaiyang
I can't see the log file (getting the following message: "Your account<EMAIL_ADDRESS>is not authorized to view this page").
It might be related to the problem described in issue #8191 but I am not sure.
How can I see the failure?

@weicaiyang
I can't see the log file (getting the following message: "Your account<EMAIL_ADDRESS>is not authorized to view this page").
It might be related to the problem described in issue #8191 but I am not sure.
How can I see the failure?

can you rebase on top of master and force push it to see if CI can pass?

@weicaiyang
I did and it is ok now. Thanks Weicai.


Not getting any speedup/memory reduction for Mistral 7B + QLoRA

Setup
model_id = "mistralai/Mistral-7B-Instruct-v0.1"

bnb_config = BitsAndBytesConfig(
    load_in_4bit=True,
    bnb_4bit_use_double_quant=True,
    bnb_4bit_quant_type="nf4",
    bnb_4bit_compute_dtype=torch.bfloat16
)

# load base LLM model and tokenizer
model = AutoModelForCausalLM.from_pretrained(model_id, torch_dtype=torch.float16,
                                              quantization_config=bnb_config, use_flash_attention_2 = True)

Code:
results = []
for n in range(1, 25):

    print(f'Processing {n} examples')
    tokenized_prompt = tokenizer([context]*n, return_tensors="pt")

    length = len(tokenized_prompt['input_ids'][0])+1
    print(length)
    t0 = time()
    with torch.no_grad():
        output = model.generate(
            inputs = tokenized_prompt['input_ids'],
            max_new_tokens = 400,
            repetition_penalty = 1.2
        )
    t1 = time()

    time_taken = t1 - t0
    mem_usage = memory()
    new_token_length = len(output[0]) - length
    tokens_per_second = new_token_length * n / time_taken
    time_per_batch = time_taken/n

    print('Time taken = ', time_taken)
    print(f'Tokens/s = {tokens_per_second}')

    gc.collect()
    torch.cuda.empty_cache()

    results.append({'batch_size': n, 'time_taken': time_taken,
                    'tokens_per_second': tokens_per_second, 'memory_usage': mem_usage, 'time_per_batch':time_per_batch})

Results below
There are virtually identical...any ideas?

Do you know what the bottleneck of the model during inference? Have you profiled it?
If attention doesn't take that much time (e.g. most of the time is spent on quantized linear layer) then speeding up attention with FlashAttention wouldn't make much of a difference.
In general attention will take more time proportionally if the context is long (2k or 4k) or the batch is large (above 16).

I'll look into that, thanks. FYI the context is ~ 2k tokens already so would expect some decent speedups if the attention is taking up a large part of the inference time

With FA2:

Without FA2:

Is there anyway to tell what fraction of time is taken by attention?
Also I think FA2 is only used for prefill and not decoding (I'm guessing, I haven't looked at HF code)? If most of the time is spent in decoding then I wouldn't expect a difference either.


Spread operator problem

Description
Spread operator problem in a reducer (React & Redux). I put this in my reducer file:

const INITIAL_STATE = { all: [] };

export default function(state = INITIAL_STATE, action) {
  switch(action.type) {
    case FETCH_BLOG_POSTS:
      return { ...state, all: action.payload.data };

    default:
      return state;
  }
}

But when i put in the console: "brunch watch --server" this produces a syntax error. This works in others build tools.
Expected behavior
The code should have been okey
Actual behavior
Tell us what actually happens.
27 Jan 16:09:43 - error: Compiling of app/reducers/reducer_blog_posts.js failed.
   SyntaxError: app/reducers/reducer_blog_posts.js: Unexpected token (8:15)
      6 |   switch(action.type) {
      7 |     case FETCH_BLOG_POSTS:
   >  8 |       return { ...state, all: action.payload.data };
        |                ^
      9 |
     10 |     default:

Environment

Brunch: 2.10.3
Node: 6.9.2
NPM: 3.10.9
Operating system: macOS sierra (10.12.2)

package.json contents
  "name": "brunch-app",
  "description": "Description",
  "author": "Your Name",
  "version": "0.1.0",
  "repository": {
    "type": "git",
    "url": ""
  },
  "scripts": {
    "start": "brunch watch --server",
    "build": "brunch build --production"
  },
  "dependencies": {
    "axios": "^0.15.3",
    "react": "^15.4.2",
    "react-dom": "^15.4.2",
    "react-redux": "^5.0.2",
    "react-router": "^3.0.2",
    "redux": "^3.6.0",
    "redux-promise": "^0.5.3"
  },
  "devDependencies": {
    "auto-reload-brunch": "^2.7.1",
    "babel-brunch": "^6.0.6",
    "babel-preset-react": "^6.22.0",
    "brunch": "^2.0.0",
    "clean-css-brunch": "^2.0.0",
    "css-brunch": "^2.0.0",
    "hmr-brunch": "^0.1.1",
    "javascript-brunch": "^2.0.0",
    "sass-brunch": "^2.9.0",
    "uglify-js-brunch": "^2.0.0"
  }
}

brunch config contents
exports.config = {
  hot: true,

  files: {
    javascripts: {joinTo: 'app.js'},
    stylesheets: {joinTo: 'app.css'},
  },

  plugins: {
    babel: {
      presets: ['es2015', 'es2016', 'react']
    }
  }
};

Thank you

Temporary fix:
obtained from: http://stackoverflow.com/questions/40126537/spread-operator-equivalent-of-object-assign and http://babeljs.io/docs/plugins/preset-stage-3/

Install Stage 3 preset from babel ( npm install --save-dev babel-preset-stage-3 )
Add to presets in brunch.config. In my case:

plugins: {
    babel: {
      presets: ['es2015', 'es2016', 'react', 'stage-3']
    }
  }

And works. But it's not a definitive solution i think.

Hi @hmontes
Unfortunately object rest spread transform is not included to the es2015 and es2016 presets, so if you want to use this feature you have to use stage 3 preset which includes this one or if you don't need all features of stage 3 you can install and use only object rest spread transform
http://babeljs.io/docs/plugins/transform-object-rest-spread/
More details about all babel presets and what they include you can see here
http://babeljs.io/docs/plugins/#presets


[stable/sugarcrm] Fix typo in deployment

Fixed typo in deployment.yaml referencing wrong application name

/ok-to-test

/lgtm


sftp: Completely ignore all modtime checks if SetModTime=false

What is the purpose of this change?
Adjusted the logic in the SetModTime function to completely disable all checks associated with the update if sftp-set-modtime is disabled.
This handles really odd edge cases where an SFTP server will remove the file immediately upon upload (for example, as part of a batch processing workflow). If the file is removed, the SetModTime function still attempts to stat() the file, which does not at that point in time exist.
The code should be pretty obvious in what it's doing 😄
Checklist

[X] I have read the contribution guidelines.
[X] I have added tests for all changes in this PR if appropriate.
[X] I have added documentation for the changes if appropriate.

[X] I'm done, this Pull Request is ready for review :-)

This looks fine!  I just kicked the CI to get it to go green.

That looks great!  I don't know why it was written the way it was before - your code is much better - thanks!
Will merge now.


Add Edilson Matola to Contributors list

Added my name to the Contributors list

Hello @edilsonmatola
Thank you for your contribution, and congrats on your pull request!


"CĂLĂRAȘI" is listed in the drop-down menu

Description:
"CĂLĂRAȘI" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Călărași" in the search bar.

Expected results
The location is listed in the drop-down menu as "Municipiul CĂLĂRAȘI, CĂLĂRAȘI".


Use IS_DEV_OR_DEMO for playground

This PR makes the rendering of the playground optional (only when in dev/demo).
Fixes #5452

LGTM @matmair


Include an auth_time claim on the set of generated tokens

We need Identity to provide time at which the user was signed in so that it can be included as an auth_time claim.

We should take a look at this as part of https://github.com/aspnet/Identity/issues/650

Is this claim expected to only change when an explicit sign in method is called?  Or can we update the time whenever we generate a new set of claims for the user?

Basically should this track the user's last login time (LastLoginDate in DB)?  Or should this be meta data that's only valid for a particular cookie/set of claims (generated once via the SignInAsync method)?

cc @blowdart

According to http://openid.net/specs/openid-connect-core-1_0.html

auth_time
Time when the End-User authentication occurred. Its value is a JSON number representing the number of seconds from 1970-01-01T0:0:0Z as measured in UTC until the date/time. [...] (The auth_time Claim semantically corresponds to the OpenID 2.0 PAPE [OpenID.PAPE] auth_time response parameter.)

And according to http://openid.net/specs/openid-provider-authentication-policy-extension-1_0.txt

auth_time
(Optional) The most recent timestamp when the End User has
actively authenticated to the OP in a manner fitting the
asserted policies.

FWIW, we use this in IdentityServer (and add our own claim at auth time). This is the reason we need an authentication handler to wrap any other handlers: https://github.com/IdentityServer/IdentityServer4/blob/dev/src/IdentityServer4/Hosting/AuthenticationHandler.cs#L70
and here's adding the claim: https://github.com/IdentityServer/IdentityServer4/blob/afb09a6872e12a2c77dcc7854841453e2f5f52fb/src/IdentityServer4/IdentityServerPrincipal.cs#L114

POR is to add this automatically to the set of claims we generate in the claims identity, but they need to be generated only once per actual sign in call (not refreshed with cookie)

BTW, @danroth2 , you could simply do this in the login page.

The underlying feature for identity to track sign activity is here be8232d3f9c7a312314ab42dfe37047ec3b16665
You will need to opt into 2.0 via AddEntityFrameworkStoresV2/Latest()


Error: nothing provides libXss1 needed by atom-1.12.8-0.1.x86_64

Hi,
It seems like you've patched one problem, only to expose yet another with the release of Atom 1.12.8. As while you may have fixed a CentOS dependency issue there's a new Fedora dependency issue. Trying to install Atom 1.12.8 with Fedora's DNF package manager (namely on Fedora 25) gave the error:
Last metadata expiration check: 1:00:11 ago on Wed Jan  4 07:13:30 2017.
Error: nothing provides libXss1 needed by atom-1.12.8-0.1.x86_64
(try to add '--allowerasing' to command line to replace conflicting packages)

Thanks for your time,
Brenton

libXScrnSaver is probably the Fedora package Atom is meant to depend on in place of libXss1.

Oh noooo
Thanks for the report!

Also hit this. 1.12.7 installs fine on fedora 25.

as a workaround, you may do the following
rpmrebuild -e -p atom.x86_64.rpm
replace libXss1 by libXScrnSaver, save and then install the newly created RPM
sudo dnf install /home/USER/rpmbuild/RPMS/x86_64/atom-1.12.8-0.1.x86_64.rpm

@nsoui thanks but frankly what's the point? The only difference between 1.12.7 and 1.12.8, according to the release notes, is that the CentOS packaging issue is fixed. So why not stick to 1.12.7 until this issue is resolved.

Confirmed it's libXScrnSaver in Fedora (24).
$ sudo dnf whatprovides /usr/lib/libXss.so.1.0.0
Last metadata expiration check: 1:58:17 ago on Wed Jan  4 08:50:39 2017.
libXScrnSaver-1.2.2-10.fc24.i686 : X.Org X11 libXss runtime library
Repo        : @System

libXScrnSaver-1.2.2-10.fc24.i686 : X.Org X11 libXss runtime library
Repo        : fedora

One can also get around this with sudo rpm -Uvh --nodeps atom.x86_64.rpm assuming libXScrnSaver is installed.

Relevant commit: https://github.com/atom/atom/commit/af4da948e9aed3d62de3a52992fab5f8c69e5f36
It looks like the rpm was built on a non rhel/fedora image (Build host was testing-docker-a184e49d-56cf-445e-ab72-c1ccdf1e0e32). My guess is that there will need to be two rpm builds: Red Hat-like, Other (SuSE-like? just a guess...).

Also seen with atom-beta-1.13.0.beta9-0.1.x86_64.

I have a PR open that should address this issue. https://github.com/atom/atom/pull/13536.  Works for Centos and Fedora so far. Testing on OpenSuse. Will patch today if things look good.

I have a same issue

Sorry about this, folks. Until we have a proper fix we've rolled this change back for 1.12.9 and 1.13.0-beta10.

@iolsen Given that #13536 doesn't actually resolve the issue (unless you build separate SUSE vs. RHEL/Fedora RPMs), should this issue be reopened? It's still uninstallable on F25, unless you use --nodeps.
	libXss.so.1 is needed by atom-beta-1.14.0.beta3-0.1.x86_64```

@fooishbar Thank you for reporting this :sparkles:
This issue was later fixed in https://github.com/atom/atom/pull/13573 but this unfortunately did not make it into the latest hotfix release. I have added this to our regression tracking issue.

Hi @fooishbar, I've seen this also when you run sudo rpm -i atom.x86_64.rpm.  since you're on Fedora 25, can you try running sudo yum install atom.x86_64.rpm? (or sudo dnf install ./atom.x86_64.rpm see: https://github.com/atom/atom#fedora-22)
I don't think running sudo rpm would resolve the dependency and if you install it with nodeps, atom will install but will probably get a runtime error when you try starting atom.

@ungb I am on F25 indeed, and there are no runtime errors as libXScrnSaver is installed, providing libXss.so.1 for 64-bit. dnf will resolve it by installing 32-bit X11 libraries, which seems a bit of a waste. Hopefully when #13573 lands in packages (I'm currently trying 1.14.0-beta3), this will just go away.

check the line to fixing the probelm https://flight-manual.atom.io/getting-started/sections/installing-atom/#platform-linux

@fooishbar let us know if the new changes to how to install on linux fix the issue for you ✌.

@ungb Sorry, I no longer use Atom.

Nor do I. I feel Vim and Visual Studio Code (VSCode) are superior to Atom now, partly because on Linux they are more devoid of these sorts of issues and also because until recently they were easier to keep up-to-date on Linux. That and because they tend to have better features, like VSCode's auto-complete for JavaScript is truly intelligent, following 'requires' so that function definitions are automatically loaded.
Still grateful for Atom's developers and their efforts to maintain this fine piece of software.


Peer servers do not start

Due to a wrong not_if certificates do not get created on peer servers (affected controller/api)

I need to add a test that items start OK on non-first masters.


US890036: Release preparation

Ticket: https://internal.almoctane.com/ui/entity-navigation?p=131002/6001&entityType=work_item&id=890036

A developer build has not yet been created for this branch. Click here to go ahead and create the build...

CI Build Link:
http://sou-jenkins2.swinfra.net:8080/job/CAFapi/job/CAFapi~opensuse-opensearch1-image~US890036~CI


Add FEN string parsing

https://github.com/ProgramFOX/Chess.NET/commit/30c777983c49608262da3fdd9aa60fdfcbb7016f


Plugin does not work together with gatsby-plugin-transition-link

Hey! I appreciate the plugin you have created, but there is some issue which I cannot solve for myself and thought that maybe there is a problem in the code of yours.
I am developing a static website using Gatsby and I have these two plugins:

gatsby-plugin-scroll-reveal
gatsby-plugin-transition-link

Separately each plugin works just fine, but scroll reveal stops working after a transition to another page. It does work when I reload the page manually but not after there has been a transition.
I am not using any crazy configuration,, it is a very basic site. This is the second project I have seen this issue with.
Maybe there is some project configuration I must make for these plugins to work together?
Thank you a lot!

Hi @Reinards, gatsby-plugin-transition-link generate a wrapper of your main page. That's could be a reason why scroll-reveal don't work properly.

Hey @solubletech , thank you. Is there anything I can do about it without editing the source code of these plugins?

Hey @Reinards , can be because you are adding gatsby-plugin-transition-link before in the config. Assure that gatsby-plugin-scroll-reveal loads first!


Access control

We need to implement per-app/user and per-organization/group access control, such as who or which group can read or write which path patterns. We may need to store which user belongs to which group in Central Dogma's internal storage.
/cc @tokuhirom

(WIP)
Roles

System Administrator
Group Administrator
User

System Administrator

There is a default group named as administrators which provides a strong power for its members.
A default administrator: dogma/dogma?

User

A user can see his or her own projects by default. (which is created by them)
A user has a list of groups which belongs to him. He may be an administrator for some groups.

A permission to add or remove users

Group

A group may consist of projects, and each project has permissions for the group.

A permission to read the project
A permission to write the project
A permission to generate an application token of the project

A user may be added to a group by group or system administrator.

Application Token

A token belongs to a project by default.
Need to belong to a group?

API

/users (for System Administrator)
/users/projects?user={user ID} (user parameter for System Administrator. Returns the projects belonging to login user if user parameter is missing.)
/users/groups?user={user ID}
/users/tokens?user={user ID}
/groups (for System Administrator)
/groups/{group name}/projects
/groups/{group name}/members
/groups/{group name}/tokens
/tokens (for System Administrator)

Do not change the name project to organization. Keep the name and implement features first. Discuss the name later.


both "autoevent" and "scheduler" call "HandleReadCommands" which causes crash

Using 1.0.1 images, I add one mock-mqtt device which sends data "randfloat64" every 5s, set up a "5s" autoevent of deviceresoure "ping", and one scheduler of "testmessage" occur every 3s, then I find the edgex-device-mqtt frequently disconnect and reconnect to the broker, after several minutes the service panics with following kinds of errors.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x46f039]
goroutine 4102 [running]:
io.ReadAtLeast(0x0, 0x0, 0xc0001930c0, 0x1, 0x1, 0x1, 0xa4dea0, 0xa54f01, 0xc0001930c0)
       /usr/local/go/src/io/io.go:310 +0x59
io.ReadFull(0x0, 0x0, 0xc0001930c0, 0x1, 0x1, 0x1, 0x0, 0xc000562de8)
       /usr/local/go/src/io/io.go:329 +0x58
github.com/eclipse/paho.mqtt.golang/packets.ReadPacket(0x0, 0x0, 0x0, 0x0, 0x0, 0xa90300)
       /go/pkg/mod/github.com/eclipse/paho.mqtt.golang@v1.1.1/packets/packets.go:105 +0x9f
github.com/eclipse/paho%2emqtt%2egolang.(*client).connect(0xc000631c00, 0xc414e0)
       /go/pkg/mod/github.com/eclipse/paho.mqtt.golang@v1.1.1/client.go:399 +0xe9
github.com/eclipse/paho%2emqtt%2egolang.(*client).Connect.func1(0xc000631c00, 0xc0001140b0, 0xc0005bdb80)
       /go/pkg/mod/github.com/eclipse/paho.mqtt.golang@v1.1.1/client.go:223 +0x3c9
created by github.com/eclipse/paho%2emqtt%2egolang.(*client).Connect
       /go/pkg/mod/github.com/eclipse/paho.mqtt.golang@v1.1.1/client.go:195 +0x1eb

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x8b24de]
goroutine 589 [running]:
github.com/eclipse/paho%2emqtt%2egolang.(*client).internalConnLost(0xc0003e5c00, 0xc41480, 0xc0000baa00)
       /go/pkg/mod/github.com/eclipse/paho.mqtt.golang@v1.1.1/client.go:460 +0x5e
created by github.com/eclipse/paho%2emqtt%2egolang.errorWatch
       /go/pkg/mod/github.com/eclipse/paho.mqtt.golang@v1.1.1/net.go:332 +0x1df

the reason may be as stated in the title. both "autoevent" and "scheduler" call "HandleReadCommands" and register to mqtt broker using the same "clientID" get from "connectionInfo.ClientId", conflict arises and for some reason the service panics.
when I leave the "ClientId" in protocol to be blank, it works all fine.

Sounds like a race condition similar to the one we had with subscribing to ZMQ. Best guess is the paho.mqtt package is not thread safe. May need to put a mutex around the register to mqtt broker

I reproduce the error by create three autoEvents.
[[DeviceList]]
  Name = "MQ_DEVICE"
  Profile = "Test.Device.MQTT.Profile"
  Description = "General MQTT device"
  Labels = [ "MQTT"]
  [DeviceList.Protocols]
    [DeviceList.Protocols.mqtt]
       Schema = "tcp"
       Host = "<IP_ADDRESS>"
       Port = "1883"
       ClientId = "CommandPublisher"
       User = ""
       Password = ""
       Topic = "CommandTopic"
  [[DeviceList.AutoEvents]]
    Frequency = "1s"
    OnChange = false
    Resource = "testrandnum"
  [[DeviceList.AutoEvents]]
    Frequency = "1s"
    OnChange = false
    Resource = "testping"
  [[DeviceList.AutoEvents]]
    Frequency = "1s"
    OnChange = false
    Resource = "testmessage"

level=DEBUG ts=2019-08-08T05:15:49.488789Z app=edgex-device-mqtt source=executor.go:42 msg="AutoEvent - executing {\"frequency\":\"1s\",\"resource\":\"testmessage\"}"
level=DEBUG ts=2019-08-08T05:15:49.488799Z app=edgex-device-mqtt source=executor.go:42 msg="AutoEvent - executing {\"frequency\":\"1s\",\"resource\":\"testping\"}"
level=DEBUG ts=2019-08-08T05:15:49.488799Z app=edgex-device-mqtt source=executor.go:42 msg="AutoEvent - executing {\"frequency\":\"1s\",\"resource\":\"testrandnum\"}"
level=DEBUG ts=2019-08-08T05:15:49.490254Z app=edgex-device-mqtt source=command.go:200 msg="Handler - execReadCmd: deviceResource: message"
level=DEBUG ts=2019-08-08T05:15:49.490644Z app=edgex-device-mqtt source=command.go:200 msg="Handler - execReadCmd: deviceResource: ping"
level=DEBUG ts=2019-08-08T05:15:49.49095Z app=edgex-device-mqtt source=command.go:200 msg="Handler - execReadCmd: deviceResource: randnum"
level=DEBUG ts=2019-08-08T05:15:49.491524Z app=edgex-device-mqtt source=command.go:207 msg="Handler - execReadCmd: deviceResource: {\"description\":\"device message\",\"name\":\"message\",\"properties\":{\"value\":{\"type\":\"String\",\"readWrite\":\"W\",\"size\":\"0\"},\"units\":{\"type\":\"String\",\"readWrite\":\"R\"}}}"
level=DEBUG ts=2019-08-08T05:15:49.491582Z app=edgex-device-mqtt source=command.go:207 msg="Handler - execReadCmd: deviceResource: {\"description\":\"device awake\",\"name\":\"ping\",\"properties\":{\"value\":{\"type\":\"String\",\"readWrite\":\"R\",\"defaultValue\":\"pong\",\"size\":\"0\"},\"units\":{\"type\":\"String\",\"readWrite\":\"R\"}}}"
level=DEBUG ts=2019-08-08T05:15:49.491932Z app=edgex-device-mqtt source=command.go:207 msg="Handler - execReadCmd: deviceResource: {\"description\":\"device random number\",\"name\":\"randnum\",\"properties\":{\"value\":{\"type\":\"Float64\",\"readWrite\":\"R\",\"size\":\"4\",\"floatEncoding\":\"eNotation\"},\"units\":{\"type\":\"String\",\"readWrite\":\"R\"}}}"
level=INFO ts=2019-08-08T05:15:49.492125Z app=edgex-device-mqtt source=driver.go:279 msg="Create MQTT client and connection: uri=tcp://:@<IP_ADDRESS>:1883 clientID=CommandPublisher "
level=INFO ts=2019-08-08T05:15:49.492481Z app=edgex-device-mqtt source=driver.go:279 msg="Create MQTT client and connection: uri=tcp://:@<IP_ADDRESS>:1883 clientID=CommandPublisher "
level=INFO ts=2019-08-08T05:15:49.492816Z app=edgex-device-mqtt source=driver.go:279 msg="Create MQTT client and connection: uri=tcp://:@<IP_ADDRESS>:1883 clientID=CommandPublisher "
level=INFO ts=2019-08-08T05:15:49.496887Z app=edgex-device-mqtt source=driver.go:154 msg="Publish command: {\"cmd\":\"message\",\"method\":\"get\",\"uuid\":\"5d4bb0051da32727627da749\"}"
level=WARN ts=2019-08-08T05:15:49.497086Z app=edgex-device-mqtt source=driver.go:288 msg="Connection lost : EOF"
level=INFO ts=2019-08-08T05:15:49.497474Z app=edgex-device-mqtt source=driver.go:154 msg="Publish command: {\"cmd\":\"ping\",\"method\":\"get\",\"uuid\":\"5d4bb0051da32727627da74a\"}"
level=INFO ts=2019-08-08T05:15:49.497587Z app=edgex-device-mqtt source=driver.go:154 msg="Publish command: {\"cmd\":\"randnum\",\"method\":\"get\",\"uuid\":\"5d4bb0051da32727627da74b\"}"
level=WARN ts=2019-08-08T05:15:49.497988Z app=edgex-device-mqtt source=driver.go:288 msg="Connection lost : EOF"
level=WARN ts=2019-08-08T05:15:49.501355Z app=edgex-device-mqtt source=driver.go:291 msg="Reconnection failed : Network Error : %!s(<nil>)"
level=WARN ts=2019-08-08T05:15:49.501406Z app=edgex-device-mqtt source=driver.go:288 msg="Connection lost : write tcp <IP_ADDRESS>:63071-><IP_ADDRESS>:1883: use of closed network connection"
level=WARN ts=2019-08-08T05:15:49.501584Z app=edgex-device-mqtt source=driver.go:288 msg="Connection lost : EOF"
level=WARN ts=2019-08-08T05:15:49.502569Z app=edgex-device-mqtt source=driver.go:288 msg="Connection lost : write tcp <IP_ADDRESS>:63072-><IP_ADDRESS>:1883: use of closed network connection"
level=WARN ts=2019-08-08T05:15:49.502527Z app=edgex-device-mqtt source=driver.go:291 msg="Reconnection failed : Network Error : %!s(<nil>)"

@nbfhscl @lenny-intel
I think there are two way to solve this issue.
1.Put mutex to lock the request, this will take some latency.
2.Remove the clientID or leave the clientID empty and then Broker will provide unique clientID.
http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc398718031
https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html#_Toc3901059

A Server MAY allow a Client to supply a ClientID that has a length of zero bytes, however if it does so the Server MUST treat this as a special case and assign a unique ClientID to that Client

https://mosquitto.org/man/mosquitto-conf-5.html

MQTT 3.1.1 allows clients to connect with a zero length client id and have the broker generate a client id for them. Use this option to allow/disallow this behaviour. Defaults to true.

What do you think?

@weichou1229
Mock device has same issue too, when using more than one autoevents, func "onCommandReceivedFromBroker" was called by several goroutines and func "sendTestData" create mqtt client with same id "ResponsePublisher", which could causes failure.
INFO   2019-08-09 14:49:27   Handle read commands failed: can not fetch command response: method=get cmd=message
ERROR   2019-08-09 14:49:27   AutoEvent - error occurs when reading resource message

what about maintain several long-connected clients on demands

Right! Alternative, You can create mock device according this doc.
Async value is a long-connected connection to subscribe the readings. Maybe you can use async value instead of the scheduler job.

Hello,
I am triying to launch the command in order to find the executable command. However, i am stuck because of this error:
MQTT Docker log:
edgex-device-mqtt | level=INFO ts=2019-10-02T11:46:06.945546211Z app=edgex-device-mqtt source=driver.go:279 msg="Create MQTT client and connection: uri=tcp://:@<IP_ADDRESS>:1883 clientID=CommandPublisher "
edgex-device-mqtt | level=INFO ts=2019-10-02T11:46:06.947118137Z app=edgex-device-mqtt source=driver.go:154 msg="Publish command: {"cmd":"randnum","method":"get","uuid":"5d948dfeb8dd790001bf0c4e"}"
edgex-device-mqtt | level=INFO ts=2019-10-02T11:46:11.948379424Z app=edgex-device-mqtt source=driver.go:122 msg="Handle read commands failed: can not fetch command response: method=get cmd=randnum"
edgex-device-mqtt | level=ERROR ts=2019-10-02T11:46:11.948980258Z app=edgex-device-mqtt source=executor.go:45 msg="AutoEvent - error occurs when reading resource testrandnum"
We deleted the clientID and the autoevent, but we have this error.
Thank you

make sure the sdk version in go.mod is later than
github.com/edgexfoundry/device-sdk-go v0.0.0-20191023171807-49a95f741ef7

@nbfhscl Do you still got this error?  Is it fine to close this issue?


add qwen1.5 models

Description
Adding support for 10 new Qwen1.5 models:

Qwen/Qwen1.5-0.5B
Qwen/Qwen1.5-0.5B-Chat
Qwen/Qwen1.5-1.8B
Qwen/Qwen1.5-1.8B-Chat
Qwen/Qwen1.5-4B
Qwen/Qwen1.5-4B-Chat
Qwen/Qwen1.5-7B
Qwen/Qwen1.5-7B-Chat
Qwen/Qwen1.5-14B
Qwen/Qwen1.5-14B-Chat

Fixes #506
I updated the existing Qwen.ipynb to demonstrate loading the original generation and loading the new generation.
I also verified that the following holds for all models (except for 14B where I had to run in half precision, and there it holds for atol=1e-2):
torch.allclose(torch.softmax(hf_logits, dim=-1), torch.softmax(tl_logits, dim=-1), atol=1e-3)

I didn't include the 72B models in this PR, as I was not able to test them.

It wouldn't surprise me if these were going to be called Qwen 2 but they
changed their mind at the last minute, and couldn't be bothered to edit the
code lol
On Fri, 9 Feb 2024, 9:35 am Andy Arditi, @.***> wrote:

@.**** commented on this pull request.
In transformer_lens/loading_from_pretrained.py
https://github.com/neelnanda-io/TransformerLens/pull/507#discussion_r1484618443
:

@@ -896,6 +916,28 @@ def convert_hf_model_config(model_name: str, **kwargs):
"final_rms": True,
"gated_mlp": True,
}

elif architecture == "Qwen2ForCausalLM":

Oh this isn't a namespace that I up with - this is actually the name of
the HuggingFace model class. See the following:

config.json
https://huggingface.co/Qwen/Qwen1.5-0.5B/blob/main/config.json#L3
Qwen2ForCausalLM
https://github.com/huggingface/transformers/blob/d123e661e44225bc30cfaf6691daba9691d04153/src/transformers/models/qwen2/modeling_qwen2.py#L1100C1-L1100C46
class definition in the transformers
https://github.com/huggingface/transformers library

I was confused to see the Qwen1.5 models as instances of Qwen2ForCausalLM,
but I guess they implemented Qwen2ForCausalLM with a Qwen2.0 release in
mind. Given this, I anticipate Qwen2.0 to use the same architecture class.
If there are subtle edge cases (something like introducing grouped query
attention), I think this can be handled in the future PR that adds support
for Qwen2.0 models.
—
Reply to this email directly, view it on GitHub
https://github.com/neelnanda-io/TransformerLens/pull/507#discussion_r1484618443,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASRPNKPKU7E4PLH2ZRWVTMLYSZM57AVCNFSM6AAAAABDAPMBP2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZSHA4TKNRYGQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Added some minor comments, otherwise LGTM! Happy to merge once those are addressed

Can I bump this? (Would be nice to have a really small Qwen model for dev purposes)


Flash size arguments in megabits like '8m' are deprecated.

Hello guys, I am a newbie. I'm use mac to flash the sonoff basic. And this is the error that I get when I run flash with this code : make -C examples/sonoff_basic flash monitor
Can you all help Me? 🙏🏼
esptool.py -p /dev/tty.SLAB_USBtoUART --baud 115200 write_flash -fs 8m -fm dout -ff 40m
0x0 /Users/romadhonfajar/homekittest/esp-open-rtos/bootloader/firmware_prebuilt/rboot.bin 0x1000 /Users/romadhonfajar/homekittest/esp-open-rtos/bootloader/firmware_prebuilt/blank_config.bin 0x2000 ./firmware/sonoff_basic.bin
WARNING: Flash size arguments in megabits like '8m' are deprecated.
Please use the equivalent size '1MB'.
Megabit arguments may be removed in a future release.
esptool.py v2.8
Serial port /dev/tty.SLAB_USBtoUART
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/serial/serialposix.py", line 265, in open
self.fd = os.open(self.portstr, os.O_RDWR | os.O_NOCTTY | os.O_NONBLOCK)
FileNotFoundError: [Errno 2] No such file or directory: '/dev/tty.SLAB_USBtoUART'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/esptool.py", line 3201, in
_main()
File "/usr/local/bin/esptool.py", line 3194, in _main
main()
File "/usr/local/bin/esptool.py", line 2883, in main
esp = ESPLoader.detect_chip(each_port, initial_baud, args.before, args.trace)
File "/usr/local/bin/esptool.py", line 273, in detect_chip
detect_port = ESPLoader(port, baud, trace_enabled=trace_enabled)
File "/usr/local/bin/esptool.py", line 237, in init
self._port = serial.serial_for_url(port)
File "/usr/local/lib/python3.7/site-packages/serial/init.py", line 88, in serial_for_url
instance.open()
File "/usr/local/lib/python3.7/site-packages/serial/serialposix.py", line 268, in open
raise SerialException(msg.errno, "could not open port {}: {}".format(self._port, msg))
serial.serialutil.SerialException: [Errno 2] could not open port /dev/tty.SLAB_USBtoUART: [Errno 2] No such file or directory: '/dev/tty.SLAB_USBtoUART'
make: *** [flash] Error 1

You need to set environment variable ESPPORT to point to your ESP8266 tty device. Right now it is set or defaults to /dev/tty.SLAB_USBtoUART which seem not to be correct in your case.
The easiest way to find out the correct port is to disconnect your device from USB, do ls /dev/tty.*, then reconnect device, do ls again and find out which new device has appeared.

Oh, I see. Now I can figure it out Sir 🙏🏼 My port appears now and not face the error like above.
But on step 12 with the function make -C examples/sonoff_basic flash monitor
I get this message Sir

esptool.py -p /dev/tty.usbserial --baud 115200 write_flash -fs 8m -fm dout -ff 40m
0x0 /Users/romadhonfajar/homekittest/esp-open-rtos/bootloader/firmware_prebuilt/rboot.bin 0x1000 /Users/romadhonfajar/homekittest/esp-open-rtos/bootloader/firmware_prebuilt/blank_config.bin 0x2000 ./firmware/sonoff_basic.bin

WARNING: Flash size arguments in megabits like '8m' are deprecated.
Please use the equivalent size '1MB'.
Megabit arguments may be removed in a future release.
esptool.py v2.8
Serial port /dev/tty.usbserial
Connecting......................................_____
A fatal error occurred: Failed to connect to Espressif device: Timed out waiting for packet header
make: *** [flash] Error 2

And stuck cannot flash.
Can you help me, Sir? Thanks for your help.

You are making progress :)
Now you need to put soNoff in flashing mode.
The moment you connect your Sonoff to your computer, you need to push its push button . Keep it pushed for 1-2 second and then leave it.
Then try again with flashing command

You are making progress :)
Now you need to put soNoff in flashing mode.
The moment you connect your Sonoff to your computer, you need to push its push button . Keep it pushed for 1-2 second and then leave it.
Then try again with flashing command

Thanks you Sir 🙏🏽
Actually I have done it Sir, press the button for 3 seconds on sonoff while connect to my laptop.

It’s not about how long you press it. When you power it up, bootloader (startup code) checks if button is pressed (or corresponding pin is connected to ground), then it loads special “flashing” code, otherwise it loads normal firmware.

It’s not about how long you press it. When you power it up, bootloader (startup code) checks if button is pressed (or corresponding pin is connected to ground), then it loads special “flashing” code, otherwise it loads normal firmware.

The button is pressed before I attach the usb serial to my laptop Sir.
I’m refer to this step on internet :

Do not plug into the USB on your computer.
Do not connect the Sonoff to mains power.
Press and hold the push button on the Sonoff board.
Insert the FTDI converter USB in your computer (while holding the push button).
After 2–3 seconds, release the push button.
Now it's in flash mode.

But my sonoff cannot flash. Or I miss another step?

It’s not about how long you press it. When you power it up, bootloader (startup code) checks if button is pressed (or corresponding pin is connected to ground), then it loads special “flashing” code, otherwise it loads normal firmware.

The button is pressed before I attach the usb serial to my laptop Sir.
I’m refer to this step on internet :

Do not plug into the USB on your computer.
Do not connect the Sonoff to mains power.
Press and hold the push button on the Sonoff board.
Insert the FTDI converter USB in your computer (while holding the push button).
After 2–3 seconds, release the push button.
Now it's in flash mode.

But my sonoff cannot flash. Or I miss another step?

Sir @maximkulkin I’ve done with the load for flashing firmware. But I’ve face another problem.
When I run the program make -C examples/sonoff_basic flash monitor
This error came out :
esptool.py v2.8 Serial port /dev/tty.usbserial Traceback (most recent call last):   File "/Library/Frameworks/Python.framework/Versions/3.8/bin/esptool.py", line 3201, in <module>     _main()   File "/Library/Frameworks/Python.framework/Versions/3.8/bin/esptool.py", line 3194, in _main     main()   File "/Library/Frameworks/Python.framework/Versions/3.8/bin/esptool.py", line 2883, in main     esp = ESPLoader.detect_chip(each_port, initial_baud, args.before, args.trace)   File "/Library/Frameworks/Python.framework/Versions/3.8/bin/esptool.py", line 273, in detect_chip     detect_port = ESPLoader(port, baud, trace_enabled=trace_enabled)   File "/Library/Frameworks/Python.framework/Versions/3.8/bin/esptool.py", line 237, in __init__     self._port = serial.serial_for_url(port)   File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/serial/__init__.py", line 88, in serial_for_url     instance.open()   File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/serial/serialposix.py", line 272, in open     self._reconfigure_port(force_update=True)   File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/serial/serialposix.py", line 435, in _reconfigure_port     termios.tcsetattr( termios.error: (22, 'Invalid argument')
Now whats my problem Sir? Need your help. And I’m so sorry for my problem with flashing 🙏🏽

@Romadhonfajar looks like your esp tool is not installed correctly.

That looks like something with FTDI driver. Can you try using corresponding /dev/cu.* interface instead (/dev/cu.usbserial?)?

I had a similar error message as him. I had to reinstall esptool and python pip on my mac. After that it would work. @Romadhonfajar if you run esptool without any arguments does it run without error or does it crash with similar output?


Read the ML best practices white paper

The ML white paper by MATLAB is available here

Lessons learned:

Export model to workspace for classifying new data
Generate code to possibly train with new data
To avoid overfitting :

Use enough data, i.e. 10 000 data points! Only resolution of 100m = 167px roughly satisfies this.
Use regularization
Use cross-validation!


[Datafusion] - Support joins on Float32/Float64 columns

Describe the bug
When I joins on Float32/Float64 columns, there is a issue:
> select * from public.simple as a join (select * from public.simple as b) on a.c1=b.c1;
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Internal("Unsupported data type in hasher")', datafusion/src/physical_plan/hash_join.rs:583:14
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Internal("Unsupported data type in hasher")', datafusion/src/physical_plan/hash_join.rs:583:14
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Internal("Unsupported data type in hasher")', datafusion/src/physical_plan/hash_join.rs:583:14
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Internal("Unsupported data type in hasher")', datafusion/src/physical_plan/hash_join.rs:583:14
0 rows in set. Query took 0.034 seconds.

table info:
> show columns from public.simple;
+---------------+--------------+------------+-------------+-----------+-------------+
| table_catalog | table_schema | table_name | column_name | data_type | is_nullable |
+---------------+--------------+------------+-------------+-----------+-------------+
| datafusion    | public       | simple     | c1          | Float64   | NO          |
| datafusion    | public       | simple     | c2          | Float64   | NO          |
| datafusion    | public       | simple     | c3          | Boolean   | NO          |
+---------------+--------------+------------+-------------+-----------+-------------+

There is also this similar issue #187, These issues is caused by hash join equal rows not support Float32/Float64 datatypes. I will fix this.
https://github.com/apache/arrow-datafusion/blob/26399ed2405dcacd505f4af73c5ecf608cb6aa9d/datafusion/src/physical_plan/hash_join.rs#L759-L796

Thanks @francis-du , I have assigned the issue to you :)

OK, Thanks~


include reclassification tab and integration of custom land cover map

There is a request from Bangladesh to use the application with their national land cover map. Could you integrate the reclassification tab and ability to use a custom land cover map into the module?
Thanks Pierrick!!

What are there expectation ?
use a custom land cover map and reclassify it into the matrix that we use or make the matrix fully customizable ?

The expectation is the ability to use their national land cover map instead of a global dataset.
Would you be able to make the matrix fully customizable using any legend(s)?
I imagine it would be easier for you if they translate their maps to the 6 IPCC classes so the classes will match the existing matrix.

In the new GPG there is the option to specify changes within IPCC categories. With a custom map - the user should still define how the classes correspond to the IPCC categories (as sub-categories of the IPCC). If it is possible to make the matrix customizable based on a land cover map, we should do something like this.


Document missing and new known limitations

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b76ba7dd4b0cc433f928ad56f07602090804afa4/
Edited pages:

v19.1/known-limitations.md
v19.2/known-limitations.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/14dd6134dfa1c3ba8be04c8d4b8b1c4bbcf5180a/
Edited pages:

v19.1/known-limitations.md
v19.2/known-limitations.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/52001aa7904f1afe5710e6d72a63610f824583a0/
Edited pages:

v19.1/known-limitations.md
v19.2/known-limitations.md


Add javadoc.io badge

Pretty handy web service that hosts the javadocs published to maven central.

neat, thanks.


Confusing iree-compile and tools/iree-compile targets

I was wondering why iree-compile does not pick up the changes I made in the compiler, until I discovered the following in build.ninja:
build iree-compile: phony compiler/bindings/python/iree/compiler/_mlir_libs/iree-compile
build tools/iree-compile: CXX_EXECUTABLE_LINKER__iree-compile_Debug tools/CMakeFiles/iree-compile.dir/iree-compile-main.cc.o

So iree-compile is a phony target aliasing to python bindings, while all other iree binaries are phony targets aliasing to their tools/ counterpart, e.g.:
build iree-benchmark-module: phony tools/iree-benchmark-module
build iree-dump-module: phony tools/iree-dump-module

This can be quite confusing. It's better to be consistent here.

@ScottTodd you were just messing with this, yes?

@ScottTodd you were just messing with this, yes?

No, I don't think so. I've reviewed some changes to the python bindings and how those targets are set up, but don't have any work planned in that area myself.

I thought this had to do with the cmake targets in tools

I now see
build iree-compile: phony tools/iree-compile

Hmm, I'm still seeing it as aliasing to compiler/bindings/python/iree/compiler/_mlir_libs/iree-compile. Have you enabled IREE_BUILD_PYTHON_BINDINGS when trying out?

Urgh, now. For that I'd have to remember how to build the python bindings. My cmake build dir is too old...

Oh, yup. When I build with the bindings enabled I see the same as you. Sorry about that. I'm not sure we really have a system for things that belong in two subprojects (infra and python bindings). Looks like some investigating of the Python bindings CMake configuration is required here.

A symptom of this (from @MaheshRavishankar):

nasty build issue I ran into. If I have IREE_BUILD_PYTHON_BINDINGS on iree-compile in tools/iree-compile doesn't get updated.... Only compiler/bindings/python/iree/compiler/_mlir_libs/iree-compile gets updated. So I kept rebuilding iree-compile and kept having my changes not being picked up when I was using tools/iree-compile....

@stellaraccident could you take a look at addressing this? I think Lei has identified the root cause that is leading to the confusing behavior Mahesh is experiencing


JS Processor is broken

When I try to require the js-strings processor multiple things fail.
var jsStrings = require('./node_modules/gulp-selectors/lib/processors/js-strings');

First:
Error: Cannot find module '../utils/libraries'

Which is due to a wrong requiring path.
When I fix this to libraries = require('../utils/library') this happens:
var classLibrary = libraries('class').getAll(),
                                                       ^
TypeError: Cannot call method 'getAll' of undefined

I haven't gone any further.

Try using the package directly in you gulp workflow instead of requiring the libraries individually:
var gulp = require('gulp');
var selectors = require('gulp-selectors');

gulp.task('default', function() {
	gulp.src(['index.html', 'style.css', 'script.js'])
		.pipe(selectors.run())
		.pipe(gulp.dest('./dist'));
});

The libraries aren't meant to be used separately so they haven't been tested outside of the gulp-selectors package. I'll try to add a more thorough example to the repo today or tomorrow to better demonstrate it.

The js string processor was never reconnected to the processor utils when I made some changes since it can be dangerous. I have updated it so it should work now, but be careful!

It will only run on selectors which have already been processed
It will replace string literals, there is no smart regex at work here


Use video.js for audio/video

The new video player is  added for web so I'm closing this. We still need to strip out the old player for electron once the sdk provides streaming support.


making adm experimental

@lfryc @matzew could you check&merge ?

:eyes:

Ok, I like the experimental, :+1:
but, the variant code snippets are for Cordova.
Since it's experimental... should we do something else ?
e.g. point to the official Amazon doc ? and mention that the server is ready and and the SDK is in the works ?

Yeah, in the snippets , instead of code , we can point to doc, let me add this

@sebastienblanc wanna add something in this PR? Or should we close ?

No I will add something
On Mon, Jun 22, 2015 at 3:18 PM, Matthias Wessendorf <
<EMAIL_ADDRESS>wrote:

@sebastienblanc https://github.com/sebastienblanc wanna add something
in this PR? Or should we close ?
—
Reply to this email directly or view it on GitHub
https://github.com/aerogear/aerogear-unifiedpush-server/pull/600#issuecomment-114099363
.

@matzew PR has been updated

:eyeglasses:

@sebastienblanc I like that!
:+1: from my perspective!

merged to master


Toast doesn’t work when keyboard is up

What happens when a Toast is tossed with the keyboard active?
What is expected?
Scenario: error posting a comment

Bug Report Dump (Auto-generated)

Version 1.12.0 (1106)
Device: iPhone 7 Plus (iOS 11.0.3)
TestFlight: true

Nice find. Should:

Appear above kb
Reposition when kb dismisses/appears

Sent with GitHawk


stat /composer.phar: no such file or directory

Hi,
This morning, I've follow your article about run Symfony on docker http://geoffrey.io/a-php-development-environment-with-docker.html
Full trace :
On execute the create-project command, I have an error :
exec: "/composer.phar": stat /composer.phar: no such file or directory
Error response from daemon: Cannot start container a970bf5b60f1d855290b2557a0767c2e1281ae7e3829df17554b32ee0b236f54: [8] System error: exec: "/composer.phar": stat /composer.phar: no such file or directory

Same error for me.

Same for me, and I've found the problem I think, it's on the build of the image, if you copy the Dockerfile and run docker build -t composer . it shows the following errors:
Step 4 : RUN php -r "readfile('https://getcomposer.org/installer');" | php
 ---> Running in acbecccc776b
PHP Warning:  readfile(): SSL operation failed with code 1. OpenSSL Error messages:
error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed in Command line code on line 1
PHP Warning:  readfile(): Failed to enable crypto in Command line code on line 1
PHP Warning:  readfile(https://getcomposer.org/installer): failed to open stream: operation failed in Command line code on line 1


Added argument index to UDF params

Added arg index to udf params, we need this during code gen on the host.
Created a new info type for UDF parameters.
Modified UserDefinitionsNameResolver to not use record type, since I didn't find a way to get the index of a pram.

            }

When would this occur? Should this be an error?

Refers to: src/libraries/Microsoft.PowerFx.Core/Parser/TexlParser.cs:139 in 64e7d6e. [](commit_id = 64e7d6e276de357a62c50204f83f96e29582f63b, deletion_comment = False)

            }

When would this occur? Should this be an error?
Refers to: src/libraries/Microsoft.PowerFx.Core/Parser/TexlParser.cs:139 in 64e7d6e. [](commit_id = 64e7d6e, deletion_comment = False)

TokEat() will add an error if current token is not a colon

            }

When would this occur? Should this be an error?
Refers to: src/libraries/Microsoft.PowerFx.Core/Parser/TexlParser.cs:139 in 64e7d6e. [](commit_id = 64e7d6e, deletion_comment = False)

This will occur if we have a UDF like Add(a, b:Number):Number = a + b;
colon is missing after a, TokEat() will add an error if current token is not a colon

            }

When would this occur? Should this be an error?
Refers to: src/libraries/Microsoft.PowerFx.Core/Parser/TexlParser.cs:139 in 64e7d6e. [](commit_id = 64e7d6e, deletion_comment = False)

This will occur if we have a UDF like Add(a: Number. b:Number) = a + b;
cTokEat() will add an error if current token is not a colon

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

Add tests, and then I'll sign off!

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.


who's is this?

https://github.com/sdushantha/soundcloud-dl/blob/5e08170008f819dbc59c686e4988e10efa65ebc0/soundcloud-dl.py#L16

I dont know. I had a old script which I got off pastebin which would download from SoundCloud but it stopped working and I took the id from that script


chore: replace all console.logs with logger

This PR replaces all SSR console logs with dd logger.

@paolodamico i have been replace all console.{error|log|warn|info} on the ssr.


[BUG]: Undefined properties when using drizzle-kit push

What version of drizzle-orm are you using?
0.36.0
What version of drizzle-kit are you using?
0.27.1
Describe the Bug
When using drizzle-kit push I'm receiving the following error:
TypeError: Cannot read properties of undefined (reading 'isRLSEnabled')
My client setup:
import { drizzle } from "drizzle-orm/neon-http";
import * as schema from "@/lib/database/schema";

export const db = drizzle(process.env.DATABASE_URL!, { schema: schema });

Drizzle config:
import dotenv from "dotenv";
import { defineConfig } from "drizzle-kit";

dotenv.config({ path: ".env.local" });

export default defineConfig({
  dialect: "postgresql",
  schema: "./lib/database/schema.ts",
  out: "./lib/database/migrations",
  dbCredentials: {
    url: process.env.DATABASE_URL!,
  },
  strict: true,
});

Expected behavior
No response
Environment & setup
Development

Same Error for me, using supabase

exactly the same thing for me too

the same thing for me too

same problem occurring for me as well. not sure what's up with this; a recent migration worked out alright--i'm using xata postgres

I'm having the same error

i did something really weird...so i have multiple schemas defined in my schema.ts and i removed all of them except one. did npx drizzle-kit generate and then npx drizzle-kit migrate. repeated the process by re-adding my schemas and somehow everything worked...not sure what's up with that though.

same error for me with postgres

same

I have the same, for postgres generate.

Update: Tried with 0.26.2, tells me to upgrade...
This version of drizzle-kit is outdated
Please update drizzle-kit package to the latest version 👍

same package drizzle & drizzle-kit versions
getting same error when running drizzle-kit generate
postgres

I tried the "delete schema, generate, revert partially, generate again, then use latest schema, and generate one more time" and it worked somehow

a folder with 'bad' migrations was my issue. deleted that and all's well now🙌🏽

same

It seems there is a missing nullcheck and adding an optional chaining operator in drizzle-kit code fixes the issue. I cannot assure it will works if you avec RLS defined, but if you don't you should be able to generate migrations correctly.

Go to node_modules/drizzle-kit/bin.cjs
Edit line 29886.
Replace

 if (table4.isRLSEnabled !== tableInPreviousState.isRLSEnabled) {

With
if (table4.isRLSEnabled !== tableInPreviousState?.isRLSEnabled) {

About the issue:
tableInPreviousState is known to be possibly undefined as line 29878 checks for it:
const policiesInPreviousState = tableInPreviousState ? Object.keys(tableInPreviousState.policies) : [];

There must be a type issue or misconfiguration somewhere that Typescript did not catch it at compile time.

pushing a fix in 30 mins

sorry for a long fix for this blocker

tysm!

It seems there is a missing nullcheck and adding an optional chaining operator in drizzle-kit code fixes the issue. I cannot assure it will works if you avec RLS defined, but if you don't you should be able to generate migrations correctly.
1. Go to `node_modules/drizzle-kit/bin.cjs`

2. Edit line 29886.
   Replace

 if (table4.isRLSEnabled !== tableInPreviousState.isRLSEnabled) {

With
if (table4.isRLSEnabled !== tableInPreviousState?.isRLSEnabled) {

About the issue: tableInPreviousState is known to be possibly undefined as line 29878 checks for it:
const policiesInPreviousState = tableInPreviousState ? Object.keys(tableInPreviousState.policies) : [];

There must be a type issue or misconfiguration somewhere that Typescript did not catch it at compile time.

@iyansr do this for now

Changing the node_modules/drizzle-kit/bin.cjs file generates disable rls SQL statement.
I'm also facing this with the latest version of drizzle-kit

It's still not on the latest version; I needed to run a few more checks, which showed me one more bug that I urgently needed to fix. I will try to make the latest release today. Meanwhile, you can use
drizzle-kit@rls-fix

@xfhg
I tried

when i run npx drizzle-kit push
It give a prompt to accept or not

but after i accept, it trhow the error

@xfhg I tried
when i run npx drizzle-kit push
It give a prompt to accept or not

but after i accept, it trhow the error

same thing when use `drizzle-kit@rls-fix`

not related to this issue, seems like you are using sqlite dialect to push and rls is postgres-only feature

fix released in<EMAIL_ADDRESS>

tysm!


Add Incident EventType

Version 2 - Add Incident EventType
Summary
Add an incident value to the EventType Enumeration
Motivation
Adding an incident value to the EventType enumeration enables publishers to inform drivers about events that close or restricts the use of road segments. This is valuable because it reduces driver uncertainty and increases the probability of driver success.  It also fulfills use cases identified by WZDx working group members and state transportation officials.  These use cases include informing citizens about road closures after a hurricane and informing transportation management centers about road status during emergencies.
Adding 'closures' will bolster the specifications usefulness.  A more useful  specification is more likely to be implemented.  More implementations inform more drivers about hazards to navigation.  Better informed drivers avoid hazards resulting in safer, cleaner, and more efficient transportation.
IncidentRoadEvents vs WorkZoneRoadEvents
IncidentRoadEvents are very similar to WorkZoneRoadEvent.  They are different in the following ways:

The property type_of_work is dropped from the IncidentRoadEvent object.
The property end_date  is optional in IncidentRoadEvent object.
The property type_of_incident is created for the IncidentRoadEvent object.  Incident types are described using event_cause from the Transportation Management Data Dictionary 3.1 (TMDD)

Proposed changes
EventType Enumeration

Value
Description

work-zone
An area of a trafficway with highway construction, maintenance, or utility-work activities.  A work zone is typically marked by signs, channeling devices, barriers, pavement markings, and/or work vehicles.  It extends from the first warning sign or flashing lights on a vehicle to the "End of Road Work" sign or the last traffic control device.  A work zone may be for short or long durations and may include stationary or moving activities.Inclusions:Long-term stationary highway construction such as building a new bridge, adding travel lanes to the roadway, and extending an existing trafficway.Mobile highway maintenance such as striping the roadway, median, and roadside grass mowing/landscaping, and pothole repair.Short-term stationary utility work such as repairing electric, gas, or water lines within the trafficway.Exclusions:Private construction, maintenance, or utility work outside the trafficway.*The AASHTO term equivalent to roadway is traveled way.*The AASHTO term equivalent to trafficway is highway, street, or road.Source: https://www.fhwa.dot.gov/publications/publicroads/99mayjun/workzone.cfm

detour
A temporary rerouting of road users onto an existing trafficway to avoid a work zone or other impedance.Source: https://mutcd.fhwa.dot.gov/htm/2009/part6/part6c.htm

restriction
A section of roadway that has limitations of how that section can be used.

incident
Incidents or events that close or restrict the use of road segments.

IncidentRoadEvent Object
The IncidentRoadEvent object locates and describes incidents or events that close or restrict the use of a road segment.
The IncidentRoadEvent is a type of road event; it has a core_details property which contains the RoadEventCoreDetails and exists within a RoadEventFeature.
Properties

Name
Type
Description
Conformance
Notes

core_details
RoadEventCoreDetails
The core details of the road event that are shared by all types of road events, not specific to work zones.
Required

types_of_incident
Array; One or More Incident Types
A list of one or more incident types indicating the cause of closure or restriction.
Required
Incident types are described using event_cause enumerations from the Transportation Management Data Dictionary 3.1 (TMDD)

start_date
String; date-time
The UTC time and date when the event begins.
Required
All datetime formats shall follow RFC 3339 Section 5.6. Example: 2016-11-03T19:37:00Z.

end_date
String; date-time
The UTC time and date when the event ends.
Required
All datetime formats shall follow RFC 3339 Section 5.6. Example: 2016-11-03T19:37:00Z.

start_date_accuracy
TimeVerification
A measure of how accurate the start date-time is.
Required

end_date_accuracy
TimeVerification
A measure of how accurate the end date-time is.
Optional

beginning_accuracy
SpatialVerification
Indicates how the beginning coordinate was defined.
Required

ending_accuracy
SpatialVerification
Indicates how the ending coordinate was defined.
Required

location_method
LocationMethod
The typical method used to locate the beginning and end of a work zone impact area.
Required

vehicle_impact
VehicleImpact
The impact to vehicular lanes along a single road in a single direction.
Required

lanes
Array; [Lane]
A list of individual lanes within a road event (roadway segment).
Optional

beginning_cross_street
String
Name or number of the nearest cross street along the roadway where the event begins.
Optional

ending_cross_street
String
Name or number of the nearest cross street along the roadway where the event ends.
Optional

beginning_milepost
Number
The linear distance measured against a milepost marker along a roadway where the event begins.
Optional
A milepost or mile marker is a surveyed distance posted along a roadway measuring the length (in miles or tenth of a mile) from the south west to the north east. These markers are typically notated on State and local government digital road networks.

ending_milepost
Number
The linear distance measured against a milepost marker along a roadway where the event ends.
Optional
A milepost or mile marker is a surveyed distance posted along a roadway measuring the length (in miles or tenth of a mile) from the south west to the north east. These markers are typically notated on State and local government digital road networks.

event_status
EventStatus
The status of the event.
Optional

worker_presence
WorkerPresence
Information about whether workers are present in the road event area.
Optional

reduced_speed_limit_kph
Number
The reduced speed limit posted within the road event, in kilometers per hour. This property only needs to be supplied if the speed limit within the road event is lower than the posted speed limit of the roadway.
Optional

restrictions
Array; [Restriction]
A list of zero or more road restrictions that apply to the roadway segment described by this road event.
Optional
Restrictions can also be provided on an individual lane.

Used By

Property
Object

properties
RoadEventFeature

Version 1 - Superseded by version 2 Above
Summary
Add a closure value to the EventType Enumeration
Motivation
Adding a closure value to the EventType enumeration enables publishers to inform drivers about road closures.  This adds value to road event feeds by reducing driver uncertainty and increasing the probability of driver success.  It also fulfills use cases identified by WZDx working group members.  These use cases include informing citizens about road closures after a hurricane and informing transportation management centers about road status during emergencies.
Adding 'closures' will bolster the usefulness of RoadRestrictionFeeds and hopefully increase its uptake.  It might also server Work Zone Data feeds.
Proposed changes
After

Value
Description

work-zone
An area of a trafficway with highway construction, maintenance, or utility-work activities.  A work zone is typically marked by signs, channeling devices, barriers, pavement markings, and/or work vehicles.  It extends from the first warning sign or flashing lights on a vehicle to the "End of Road Work" sign or the last traffic control device.  A work zone may be for short or long durations and may include stationary or moving activities.Inclusions:Long-term stationary highway construction such as building a new bridge, adding travel lanes to the roadway, and extending an existing trafficway.Mobile highway maintenance such as striping the roadway, median, and roadside grass mowing/landscaping, and pothole repair.Short-term stationary utility work such as repairing electric, gas, or water lines within the trafficway.Exclusions:Private construction, maintenance, or utility work outside the trafficway.*The AASHTO term equivalent to roadway is traveled way.*The AASHTO term equivalent to trafficway is highway, street, or road.Source: https://www.fhwa.dot.gov/publications/publicroads/99mayjun/workzone.cfm

detour
A temporary rerouting of road users onto an existing trafficway to avoid a work zone or other impedance.Source: https://mutcd.fhwa.dot.gov/htm/2009/part6/part6c.htm

restriction
A section of roadway that has limitations of how that section can be used.

closure
A section of roadway that may not be used.

ClosureRoadEvent
Adding a closure EventType creates a ClosureRoadEvent Object.  The ClosureRoadEvent is modeled after the RestrictionRoadEvent Object but with two additional properties. The vehicle_impact enumeration is added (see issue 264 ) to describe the event's affect. event_cause is added (see Issue 269 to inform drivers why an event occurred.
The event_cause property emulates the cause element found in the eventDescription property described in section <IP_ADDRESS> of the Transportation Management Data Dictionary 3.1 (TMDD).  The event_cause property will be populated using the Disasters (issue 276), Special Events (issue 277), and Winds issue coming enumerations described in sections <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS> respectively.
An example:
ClosureRoadEvent Object
The ClosureRoadEvent object is a linear road event that locates and describes roadways that may not be used.
The ClosureRoadEvent is a type of road event; it has a core_details property which contains the RoadEventCoreDetails and exists within a RoadEventFeature.
For representing closures due to road work, see the WorkZoneRoadEvent.
Properties

Name
Type
Description
Conformance
Notes

core_details
RoadEventCoreDetails
Describes the basic characteristics of a road event.
Required

restrictions
Array; [Restriction]
A list of zero or more road restrictions that apply to the roadway segment described by this road event.
Conditional: required if lanes property is not provided.
Restrictions can also be provided on an individual lane.

lanes
Array; [Lane]
A list of individual lanes within a road event (roadway segment).
Conditional: required if restrictions property is not provided.

vehicle_impact
VehicleImpact
The impact to vehicular lanes along a single road in a single direction.
Required

event_cause
Disasters Type, Winds Type, Special Events Type
A value, from an enumeration, describing why a restriction is in place.
Optional

Used By

Property
Object

properties
RoadEventFeature

Some complexity is regarding what road event object the closure type should be used with and what is means on each object. Right now, there is a one-to-one mapping between the EventType values and a specific road event object, such as WorkZoneRoadEvent, DetourRoadEvent, and RestrictionRoadEvent.
It seems like what closure is trying to solve could be done using the VehicleImpact, as proposed in #264. For example if a RestrictionRoadEvent has a vehicle_impact value of all-lanes-closed, it signifies the road is closed. I'm thinking of "closure" as more of a sub-type of an event than an event type, unless there are other properties that are specific to "closure"s that would necessitate the need for a new ClosureRoadEvent object.

@DeraldDudley I think what Jacob was getting at is that adding closure to the EventType enumeration is incomplete without specifying what type of road event it should be associated with - a RestrictionRoadEvent or maybe a new ClosureRoadEvent (assuming WorkZoneRoadEvent isn't considered)? The answer to that question depends on what other information should be conveyed - for instance, the cause of the closure you outlined in #269, #276, and #277.
I don't think closures due to weather or special events fit with the other restrictions in the RestrictionType, so your inclination to add a new event type for closures makes sense to me. There are more steps to the overall implementation though

@mark-mockett Sorry I didn't catch that.  Thank you for clarifying.
Adding closure to the EventType would result in a ClosureRoadEvent.  ClosureRoadEvents, RestrictionRoadEvents, and DetourRoadEvents could all be used in RoadRestrictionFeeds to inform drivers about unusual road use constraints.

I would like to recommend that the new EeventType object be called IncidentRoadEvent. The word 'closure' can be bit confusing given that WorkZoneRoadEvent can also have closures. Also, IncidentRoadEvent name would allow for roadway impacts more than just closure.

Attached is a list of incident/event causes we use in the Bay Area 511 system.
Incident cause enumeration.xlsx

Updated the Issue #270 with latest thoughts of the Extension Subgroup

FYI, very few agencies use the word "accident". Most prefer "crash" or "incident".  I would suggest we do the same.

FYI, very few agencies use the word "accident". Most prefer "crash" or "incident". I would suggest we do the same.

Agree its a bit outdated but we're trying to stick with the TMDD so we don't create competing enumerations...

Will the IncidentRoadEvent occur in a the RoadRestrictionFeed or will a new feed be created for this new event type?
Would you be open to implementing these changes in a forked version of the repo? I feel that the extension-related issues and content that has no relation to work zones are making it hard to follow what WZDx is, harder to find issues, PRs, and objects that are relevant to the primary goal of WZDx, to standardize representing work zone data.
I'd suggest we create a new wzdx-extended repository in the @usdot-jpo-ode organization which would be wzdx plus all non-work zone related work (e.g. restrictions, incidents).

Will the IncidentRoadEvent occur in a the RoadRestrictionFeed or will a new feed be created for this new event type?

Would you be open to implementing these changes in a forked version of the repo? I feel that the extension-related issues and content that has no relation to work zones are making it hard to follow what WZDx is, harder to find issues, PRs, and objects that are relevant to the primary goal of WZDx, to standardize representing work zone data.

I'd suggest we create a new wzdx-extended repository in the @usdot-jpo-ode organization which would be wzdx plus all non-work zone related work (e.g. restrictions, incidents).

I'll post an issue proposing a new feed type for restriction today.  Just haven't gotten to it yet.
Open to Discuss - The WZ spec obviously adds value to the Extension but the Extension adds value (increased accessibility) to the WZ too.  I'm concerned about divergent specs.


Better error message for "invalid module item"

Instead of module item, this patch changes the term to "statement".
Also, add a special message for the case when we are sure that the semicolon is missing.
(Took me a while to merge the error messages for all the duplicated states. We should really have a way to automate it).

Furiously merging this


windows support in full

Codecov Report

Merging #95 (998d67f) into master (3936dc7) will increase coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   51.13%   51.56%   +0.42%
==========================================
  Files           1        1
  Lines         483      479       -4
==========================================
  Hits          247      247
+ Misses        209      205       -4
  Partials       27       27

Impacted Files
Coverage Δ

gobrew.go
51.56% <ø> (+0.42%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix: flashing 5110 failing

This fixes the issue where flashing the psk would always fail. Not sure if this was intentional since the correct code was commented out above?

Indeed. I forgot to remove this after testing I thing. Thanks.


Software Packages

Within the software inventory, it needs to be refactored to use packages.
Use case
Across multiple OS's the same software name has a different package name, this can also include a different version. So that two different packages don't report as different software when in fact they are the same, adding a model to track packages for the same software would be an idea.
Requirements

[ ] different OS packages which are in fact the same software to report to ITAM as the same software.

Tasks

[ ] fetch base OS docker containers and create "software inventory"

added 5m of time spent

added 20m of time spent

debian and ubuntu use semver amoungst their version numbers. see https://unix.stackexchange.com/questions/96599/understanding-debian-dpkg-package-version-numbers

/cc @jasonpagetas

marked this issue as blocking #2

added 30m of time spent


[SPARK-18523][PySpark] SparkContext.stop should catch ConnectionRefusedError as well

This is a follow up to https://github.com/apache/spark/pull/15961. I'm currently on:
pyspark                   3.5.0              pyhd8ed1ab_0    conda-forge
py4j                      <IP_ADDRESS>           pyhd8ed1ab_0    conda-forge

When Spark JVM process gets OOM-Killed, SparkContext.stop fails with ConnectionRefusedError, which leaves the SparkSession/Context in a "dirty" state.
Traceback (most recent call last):
  ...
  File "<TRUNC>/lib/python3.11/site-packages/pyspark/sql/session.py", line 1796, in stop
    self._sc.stop()
  File "<TRUNC>/lib/python3.11/site-packages/pyspark/context.py", line 654, in stop
    self._jsc.stop()
  File "<TRUNC>/lib/python3.11/site-packages/py4j/java_gateway.py", line 1321, in __call__
    answer = self.gateway_client.send_command(command)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<TRUNC>/lib/python3.11/site-packages/py4j/java_gateway.py", line 1036, in send_command
    connection = self._get_connection()
                 ^^^^^^^^^^^^^^^^^^^^^^
  File "<TRUNC>/lib/python3.11/site-packages/py4j/clientserver.py", line 284, in _get_connection
    connection = self._create_new_connection()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<TRUNC>/lib/python3.11/site-packages/py4j/clientserver.py", line 291, in _create_new_connection
    connection.connect_to_java_server()
  File "<TRUNC>/lib/python3.11/site-packages/py4j/clientserver.py", line 438, in connect_to_java_server
    self.socket.connect((self.java_address, self.java_port))
ConnectionRefusedError: [Errno 111] Connection refused

What changes were proposed in this pull request?
In SparkContext.stop catch both Py4JError and ConnectionRefusedError from self._jsc.stop().
Why are the changes needed?
Otherwise it's not possible to close/clean up SparkSession/Context
Does this PR introduce any user-facing change?
Yes. Before this PR, the user would get the stacktrace you can see above, after this change, the SparkContext.stop() would not fail when the Spark JVM processed gets OOM-Killed (or killed in some other way).
How was this patch tested?

start a SparkSession
kill -9 the JVM process
sc.stop() with and without this patch

Was this patch authored or co-authored using generative AI tooling?
No.

Can we file a new JIRA? We should set the properties of fixed version so needs a new JIRA

@HyukjinKwon done: https://issues.apache.org/jira/browse/SPARK-48711


[KSDK2_MCUS] Fix I2C slave address

I2C slave address on TARGET_KSDK2_MCUS is set as (user_input_address | 1) << 1.However, the bit shift is needless.So, this commit removes it.
(My mbed account is mrks.I have accepted contributor_agreement.)

LGTM


PUT/POST requests are not working with Insomnia CLI

Expected Behavior
All tests are passed in the Insomnia Desktop application. Therefore, I expect with the same test and same environment, all tests should pass in Insomnia cli by executing:
inso run test

Actual Behavior
GET requests are working without a problem while PUT/POST requests are returning timeout exception with the following message:
 Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/var/folders/th/5r2pytjj4896gkc2d_wzryyh0000gn/T/insomnia-testing/0.219043078405891-test.ts)
      at listOnTimeout (node:internal/timers:557:17)
      at processTimers (node:internal/timers:500:7)

This behavior also affects the related CI/CD pipeline on GitHub which is one of the good features of Insomnia.
I add two screenshots to clarify the problem:

Reproduction Steps

Create PUT or POST request in Insomnia.
Define a test that uses the created request.
Go to terminal and execute inso run test by choosing related test and environment (if exists)
Should receive timeout error

Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
Inso CLI 3.0.0
What operating system are you using?
macOS
Operating System Version
macOS Monterey 12.2.1
Installation method
homebrew
Last Known Working Insomnia version
No response

Hi @emredmrcan thanks for reporting this issue!
I wasn't able to reproduce the simplest case, for example using this repository.

Are you by any chance using chained requests on your PUT/POST requests?
Or maybe are you using a particular request body? (e.g. reading a file, ...)


Additional variations of common licenses

I'm not sure where you want license misses, but here are a few I found.  Several looked like either simple whitespace changes or missing '*' values.
    - emperror.dev/errors                       # MIT
    - github.com/magiconair/properties          # bsd-2-clause
    - github.com/jtacoma/uritemplates           # bsd-3-clause
    - github.com/pmezard/go-difflib             # bsd-3-clause (unmaintained)
    - github.com/samuel/go-zookeeper            # bsd-3-clause
    - go.uber.org/dig                           # MIT
    - go.uber.org/dig/internal/dot              # MIT
    - golang.org/x/sys/internal/unsafeheader    # bsd-3-clause
    - golang.org/x/sys/unix                     # bsd-3-clause
    - gopkg.in/ini                              # apache-2.0
    - gopkg.in/yaml.v2                          # apache-2.0
    - github.com/gorilla/mux                    # bsd-3-clause

This tool is really great.  Thanks for making it & the GH Action!

:wave: sorry I missed you opening this issue @schmidtw, and thanks for the praise 🙇
github/licensed doesn't actually do any license parsing or classification itself, it uses licensee for that.  I'd recommend opening an issue in that repo because there's not too much that this tool specifically can handle to fix it.
I'm going to close this for now, but please reopen if you feel there's more to be done here 🙏


Create managing-sub-account-resources

Per the content created, images are expected to be under ../images/, but I don't have permissions to upload there. Please save files to the correct path and ensure they're named appropriately.

You can upload images using the “Upload files” button under the “Code” tab. https://github.com/jeremypeters49/PublicKB/tree/patch-3


Add docs for Connections and SignalR namespaces

Part of https://github.com/dotnet/aspnetcore/issues/27286

Docs Build status updates of commit b751729:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

aspnet-core/xml/ns-Microsoft.AspNetCore.Builder.Extensions.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.Builder.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.ConcurrencyLimiter.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.Connections.Features.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.Connections.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.SignalR.Client.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.SignalR.Protocol.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.SignalR.xml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit edb887c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

aspnet-core/xml/ns-Microsoft.AspNetCore.Builder.Extensions.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.Builder.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.ConcurrencyLimiter.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.Connections.Features.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.Connections.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.SignalR.Client.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.SignalR.Protocol.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.SignalR.xml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit c88ad5a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

aspnet-core/xml/ns-Microsoft.AspNetCore.Builder.Extensions.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.Builder.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.ConcurrencyLimiter.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.Connections.Features.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.Connections.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.SignalR.Client.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.SignalR.Protocol.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/ns-Microsoft.AspNetCore.SignalR.xml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


No Plugin to render images

I am trying to use the react project components.But I am not able to render the DICOM files as there is no PLUGIN coming from ohif so the availablePlugins list is empty and if I set the defaultViewportPlugin, it just renders a black screen.
I was wondering if I need any specific configurations for the plugin.
Thanks.

@atony88 are you still having this issue with the latest version of the react branch? There are some rough docs on extensions and modules currently in Draft PR: https://deploy-preview-393--ohif.netlify.com/advanced/extensions.html

This issue is a little stale, so I'm going to close it for now. Please feel free to start up the conversation again ^_^
For what it's worth, we've recently revamped all of our docs for version 2. I intend to expand on our plugin/extensions documentation further over the next 2-months as we refine and improve that functionality as part of our ongoing partnership with key integrators 👍