expr/builtin_fncall: implement HexIntArg, HexStrArg

What have you changed? (mandatory)
expr/builtin_fncall: implement string.{HexIntArg, HexStrArg}
What are the type of the changes? (mandatory)

New feature (non-breaking change which adds functionality)

How has this PR been tested? (mandatory)
unit test
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
no
Does this PR affect tidb-ansible update? (mandatory)
no
Refer to a related PR or issue link (optional)
#3275

@AndreMouche mysql and tidb both return "C" for case 12.3. Do we need to support this in HexIntArg?
mysql> select hex(12.3);
+-----------+
| hex(12.3) |
+-----------+
| C         |
+-----------+
1 row in set (0.00 sec)

@sweetIan we don't need to do that because both mysql and TiDB cast 12.3 to 12 already before call hex.

LGTM.

/run-unit-test

@sweetIan please merge master and resolve conflicts 😄

/run-unit-test


Add query to count content-type headers used for WordPress pages

In discussing with @dmsnell in the #core-html-api Slack channel about whether XHTML support should be removed from core, I wanted to do a query to see how many WordPress pages are actually served with the Content-Type of application/xhtml+xml. Even when the response body contains valid XML/XHTML markup, browsers will still use the HTML parser if the Content-Type is text/html. So we can determine whether attempting to maintain valid XHTML syntax is important for WordPress by checking how often pages are returned as application/xhtml+xml. Presuming my query is correct, in short, the answer is very few: specifically four and they are all limited to mobile. In fact, there are more pages returned as RSS or plain text than XHTML.

client
content_type
count

desktop
text/html
4082654

desktop
application/rss+xml
32

desktop
text/plain
11

desktop
application/x-perl
2

desktop
text
2

desktop

2

desktop
x-httpd-php
2

desktop
texthtml
2

desktop
twentyseventeen
1

desktop
html_type
1

desktop
charset=utf-8
1

desktop
text/xml
1

desktop
text/css
1

desktop
another text/html
1

desktop
1
1

desktop
application/atom+xml
1

desktop
application/json
1

mobile
text/html
5459935

mobile
application/rss+xml
61

mobile
text/xml
7

mobile
text/plain
7

mobile
application/xhtml+xml
4

mobile
texthtml
3

mobile

3

mobile
text
2

mobile
text/HTML
2

mobile
charset=utf-8
2

mobile
x-httpd-php
2

mobile
html_type
1

mobile
application/x-perl
1

mobile
1
1

mobile
Array
1

mobile
text/css
1

mobile
twentyseventeen
1

mobile
another text/html
1

mobile
utf-8
1

mobile
text/htmltext/html
1

mobile
application/atom+xml
1

mobile
application/json
1

(Query elapsed time: 53 sec)
I checked the four URLs that were being returned as application/xhtml+xml when crawled, and they are all one is returning text/html now. The other three are returning application/xhtml+xml only when emulating a mobile device.
For reference, these are the URLs which were serving valid XHTML at crawl time:

http://www.kenkomura.jp/ (XHTML only for mobile)
http://www.nukumori-fukumitsu.com/ (XHTML only for mobile)
http://kittokito-ichiba.co.jp/ (XHTML only for mobile)
https://yakaze.jp/ (not XHTML for either desktop or mobile now)

Interestingly the sites are all Japanese.
So I think it is safe to say that WordPress can safely abandon any attempt to serve valid XML pages.

There is only one quirk which I think is crucial to fix: I think we should limit results to only those where client = 'mobile', otherwise I believe we get duplicate URLs, and I assume that is currently the case. Whether mobile or desktop is used doesn't matter what we're trying to achieve here, so then I'd say we should use mobile just because the dataset is larger.

@felixarntz I've made this change to the query. I've updated the description to reflect the changes. However, doing so exposed something surprising: I re-checked the URLs when emulating a mobile device in DevTools, and actually they are only serving valid XHTML to mobile devices. For desktop, they serve HTML. So I wonder actually if these should be considered duplicates given the possibility of content negotiation based on client type?

Could you please apply these changes and rerun the query to update the PR description when you get a chance?

@felixarntz Query re-run and results added to PR description. Indeed the results show that only mobile clients are getting served the 4 XHTML responses.

Is there a Trac ticket to further discuss removing non-HTML5 support? Based on this data, certainly seems reasonable.

@felixarntz No, not that I'm aware of. However, @dmsnell may be on the cusp of doing so as part of the HTML API effort, since it is somewhat the motivator for doing this in the first place.

After chatting with @azozz I think I'm going to create a Trac ticket for it, but the next few days I'll be away from my work. It's all driven by the desire to know what we're allowed to change and what we aren't. For example, WordPress arbitrarily breaks most HTML named character references because it wants to limit the allowed set to those that were in the HTML4 spec plus a few hand-picked names. For example, if you save ⥰ in the database, it will be corrupted by kses and display as ⥰ instead of as ⥰, because kses turns it into &RoundImplies;, being unaware of the HTML5 named character references. I'd like to fix these things, but it's unclear if we can make this call since it's required by HTML5 but not by HTML4


[Hotfix][connector-v2][e2e] Fix maven scope

Purpose of this pull request
Fix maven scope

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

@hailin0 PTAL，Thanks！


TypeScript definitions missing from npm package

Hello,
I just noticed on v0.9.1 and v1.0.1 the index.d.ts file is missing from the package.

Fixed in v1.1.1


feat: convert thirdparty donation tests to Playwright

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Alright, the tests should be good to go. It will fail in the Ci because secrets do not work in PR's

Thank you for your patience, @Sembauke. I had a chance to look into testing payment elements' (paypal button and stripe elements) best practices.
To test the functionality, all papal and stripe calls should be intercepted and replaced with mock responses for different scenarios. That way we avoid the issues associated testing against external apis.
To test if the payment elements are displayed properly, there are two routes and both have their pros and cons:

completely mock the payment elements iframes.
pass only the client keys to load the actual elements.

I personally think the hybrid solution of testing actual elements and intercepted api calls would be the way to go, but let's hear from others before proceeding.

I personally think the hybrid solution of testing actual elements and intercepted api calls would be the way to go, but let's hear from others before proceeding.

Thanks for looking into this, Ahmad. I agree that this strikes the best balance. It makes sure that we've done our part correctly without the issue inherent to testing a third party. Our part being using the PayPal and Stripe libraries correctly in learn.

@raisedadead this should do it.

Here are further considerations:

our api is currently mocked. To have an e2e, the calls from our api to stripe should be mocked instead.
since we are not passing the secrets, this test could run with other e2e test in the same workflow.
if that is the case, we can have these tests as a part of the donate page tests and remove the e2e third party workflow.


Add code to benchmark multiple implementation of treeregressor

Codecov Report
Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (e827041) 78.33% compared to head (7ff24eb) 78.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   78.33%   78.75%   +0.41%
==========================================
  Files          35       37       +2
  Lines        3674     3826     +152
==========================================
+ Hits         2878     3013     +135
- Misses        796      813      +17

Files
Coverage Δ

...d/reference/c_ops/c_op_tree_ensemble_classifier.py
92.15% <100.00%> (ø)

...ed/reference/c_ops/c_op_tree_ensemble_regressor.py
95.55% <100.00%> (ø)

onnx_extended/tools/onnx_io.py
91.07% <ø> (ø)

onnx_extended/validation/_tree_d14_f100.py
100.00% <ø> (ø)

onnx_extended/_command_lines_parser.py
87.44% <96.00%> (+1.12%)
:arrow_up:

onnx_extended/validation/bench_trees.py
86.88% <86.88%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Duplicated records due totable joins

One of the table joins causes there to be duplicated records. Figure out which table join it is and fix the issue

I am pretty sure this is due to sample comments table join.

Will not fix, all comments shoudl be retained


Post a message to the webhook using cURL

The example given there does not work.
curl -H 'Content-Type: application/json' -d '{\"text\": \"Hello World\"}' <YOUR WEBHOOK URL>

It should be update to something like this:
curl -H 'Content-Type: application/json' -d '{"@context": "http://schema.org/extensions","@type": "MessageCard", "text": "Hello World"}' <YOUR WEBHOOK URL>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 28316a67-22fa-8a05-1ae0-fbe1c5720ef9
Version Independent ID: 8a250e46-2a30-af86-839d-9f83a8b48041
Content: Sending messages to Connectors and Webhooks - Teams
Content Source: msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

Same issues observed by trying out ths example.

Try formatting the json without the slashes and it works! I have also put the payload with -d at the end.

Please feel free to reopen if you have further query

The documentation needs to be changed to remove the escaping slashes from the payload.

This fixes the issue: https://github.com/MicrosoftDocs/msteams-docs/issues/1649
In this documentation: https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/connectors-using#post-a-message-to-the-webhook-using-curl
// on macOS or Linux
curl -H 'Content-Type: application/json' -d '{\"text\": \"Hello World\"}' <YOUR WEBHOOK URL>
This returns:
Bad payload received by generic incoming webhook.
The correct command is:
curl -H 'Content-Type: application/json' -d '{"text": "Hello World"}' <YOUR WEBHOOK URL>
without the backslashes \
This returns:
1


feat: multiple agent support

add multiple agent support
Screenshot

Thank you for the contribution! 🥳
Some lines have ; and some don't. If you could run the prettier formatter, that'd be great! Have you manually tested this? I'll give it a shot in a bit too.

Yes, I've manually tested. It works

@ytcheng I'll test, merge, and do a release in the morning (it's 1am here) ;p.
Thanks again!

Just a small improvement suggestion and a question.
The text should be "Connect to an Agent" (a to an). :grin:
Also, what would be multiple agents? In a workspace?
Scott

@smolinari some users will have a workspace that contains a database and a container that they code in, or maybe multiple containers in more abstract scenarios.
In these situations, you might have multiple agents you can connect to inside a single workspace!

Hmm... interesting. Didn't think about having more than one agent in a workspace. Cool. More possibilities.... :grin:
Scott

✅ Updated branch with most recent changes
✅ Added support to also selecting agents on Sidebar:
When the workspace only has multiple agents, now we list them and allow users to open an agent directly:

For workspaces with a single agent, use the default view:


Fixed tabs in yaml and python files to only use spaces.

There were some tabs before comments in 3 files. On the travis.yml file it caused pre-commit's yaml-checker to fail.
There were a few python files that had tabs before comments.
Both 'worked' but aren't considered best practices of not mixing tabs and spaces.

Coverage decreased (-0.4%) to 81.468% when pulling 32b94e17beb058638b23fe57b7da8bd2d47c8743 on jed-frey:development/jed-frey/tabfix into ccbd7acf4ed83fadb7bbdfaf36af1114908dfca8 on python-control:master.

Coverage decreased (-0.4%) to 81.468% when pulling 32b94e17beb058638b23fe57b7da8bd2d47c8743 on jed-frey:development/jed-frey/tabfix into ccbd7acf4ed83fadb7bbdfaf36af1114908dfca8 on python-control:master.


Cannot read property 'document' of undefined

With this plugin enabled I receive the titled error message after opening a folder.
It only happens if the folder opens without any previously opened files.

Facing same issue

Fix in version 1.5.2


Update Application.php

Higher timeout value to dramatically lower CPU usage

Great! But I think that timeout must be set in config.

Yes, I agree. I'll make pull request with that feature soon.

By the way i don't recommend you to use gearman in HL projects because it still buggy.
If your queues grow to 300 000 tasks, gearman server can't handle it correctly.
Beanstalk and rabbitMQ have more stability in such situations. And they have more useful features.


Added "caseSensitive" parameter

Currently before accepting new entries on the input there's a check that checks whether this tag is already present. This check is case insensitive.
Though, there are occasions where capital letters matter. For this reason I added a new (boolean) parameter called "caseSensitive". This parameter is by default "false" (that means the input checks tags existence in a case-insensitive manner, exactly as it is now).
If the user wants to make the check case-sensitive then he can enter this parameter with value "true" on the tag.
Example:
-- without case-sensitive
Having entered the "abc" tag in the input "Abc" is not acceptable
-- with case-sensitive="true"
Having entered the "abc" tag in the input "Abc" is also accaptable

Sorry for not replying sooner.
Could you check the CONTRIBUTING file and adjust your PR according to it?

Any update on this?


fix: accept number as value of options

Thanks for your interest in improving this project! 0.2.0 published. You can use {{variable, number}} (defined in the i18next document), then it will generate number | string | bigint for you.


add support in read_csv for parameter skiprows to not only be int or list (like in pandas)

The dask.dataframe.read_csv function now mimics more the behavior of
the pandas read_csv function
The pandas read_csv function allows the
skiprows parameter to be of type range or set
Also case when not assigning skiprows is now explicit

Test it out for yourself:
import dask.dataframe as dd
import pandas as pd
df = pd.read_csv("file.csv", skiprows=range(18)) # this works anyway
df = dd.read_csv("file.csv", skiprows=range(18)) # this works only after fix

[x] Tests added / passed
[x] Passes flake8 dask

Thanks @JulianWgs .  Would you be willing to add a small test to https://github.com/dask/dask/blob/master/dask/dataframe/io/tests/test_csv.py ?

Is this OK? Fails with old version, but passes after fix.

Yes!  That looks great.  Thank you!

Thanks @JulianWgs .  Merging.
Also I notice that this is your first commit to the dask repository.  Welcome!


Release notes not found for jdk-<IP_ADDRESS>+1 or jdk-<IP_ADDRESS>+1

Describe the bug
Release notes not found for jdk-<IP_ADDRESS>+1 or jdk-<IP_ADDRESS>+1
With the message "Oops... We couldn't find those release notes... "
To Reproduce
Steps to reproduce the behavior:

Go to 'https://adoptium.net/temurin/releases/?version=11'
Click on 'Release notes'

Screenshots

Desktop (please complete the following information):

OS: [ macOS]
Browser [chrome]

Thanks. I believe we need to generate the release notes with instructions from : https://github.com/adoptium/adoptium/issues/241
In the meantime, they are point releases that add a very small fix for:
https://bugs.openjdk.org/browse/JDK-8313765
The previous release notes are still relevant for everything else.
https://adoptium.net/temurin/release-notes/?version=jdk-11.0.20+8
https://adoptium.net/temurin/release-notes/?version=jdk-17.0.8+7

I've published the new release notes, they may take a little while to appear on the website.

works for 8 and 16, still nothing for 11 and 17.
https://adoptium.net/temurin/release-notes/?version=jdk-<IP_ADDRESS>+1
https://adoptium.net/temurin/release-notes/?version=jdk-<IP_ADDRESS>+1

works for 8 and 16, still nothing for 11 and 17. https://adoptium.net/temurin/release-notes/?version=jdk-<IP_ADDRESS>+1 https://adoptium.net/temurin/release-notes/?version=jdk-<IP_ADDRESS>+1

@sshaaf they are now there


Better chat input

Adds a text menu input that allows the user to select out of a predefined list in the gameframe:

Adds a text input that supports arrow keys, keyboard and mouse selection, and copy/cut/paste.

Also gives us a framework to add basically whatever we want to that panel.
Currently nothing uses this, but I would like to convert all uses of ChatboxInputManager to this in the future.

Please rebase


Better CFDP params to Put Request conversion functions

Codecov Report

Merging #107 (ef01a63) into main (39763c1) will increase coverage by 2.58%.
The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   71.95%   74.54%   +2.58%
==========================================
  Files         112      112
  Lines        7744     7742       -2
==========================================
+ Hits         5572     5771     +199
+ Misses       2172     1971     -201

Flag
Coverage Δ

unittests
74.54% <100.00%> (+2.58%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

tests/config/test_cfdp_conversions.py
100.00% <100.00%> (ø)

tmtccmd/cfdp/request.py
48.14% <100.00%> (ø)

tmtccmd/config/cfdp.py
95.65% <100.00%> (+1.53%)
:arrow_up:

... and 21 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Rewrite the script execution security mechanism.

Currently, the whitelist/blacklist mechanism implemented in JavascriptInstance.cpp is based on a 'gut feeling' without real auditing to security, and e.g. issue #341 escapes this blacklist. To allow more comprehensive options for managing client-side safety, rewrite the script execution logic as follows:

By default, executing all scripts from external asset storages is disabled. Scripts from the local system are allowed to run.
Then, add a command line parameter --allow_external_scripts which takes one of the values 0,1,2 or 3, with the meaning:

0: Do not execute scripts from external trusted asset storages.
1: Allow execution of scripts from trusted asset storages, but do not allow any script extensions to be imported in them.
2: Allow execution of scripts from trusted asset storages, but only allow them to utilize the whitelisted script extensions.
3: Allow execution of scripts from trusted asset storages, with all script extensions enabled.

Then, add a command line parameter --allow_untrusted_scripts which takes one of the values 0,1,2 or 3, with the same meanings as above, but these apply to scripts from untrusted sources.

Then, rework the script asset request mechanism in EC_Script to NOT request a script asset if the execution of that script is disabled altogether. (to avoid it ending up in the asset cache, which enables a potential untrust source if an attacker somehow manages to tamper with the cache)

What would be a default for lets say viewer-browser.xml that is usually used when starting a login from a web portal.
All scripts that show anything visible or offers some functionality to the end user must at least have qt.core and qt.gui. I understand the white and blacklists are quite bad but how would any worlds really have any funtionality without some extension? I assume the 1 option would be default as it is now, trusted storages can use the whitelisted extensions and classes?

For untrusted storages 0, for trusted storages 2. Also an option would be to allow the user to specify the level of trust when choosing to trust a storage.


IIS Web App Manage - setup IIS Application pool - Optional password field not working

We are using IIS Web Application Manage in a release to create a new IIS Application pool on a local server (using release agents).
We want to configure this application pool to run as a service account. I set up the Identity Custom Account and leave the password field blank (as the field is optional).
Since it's a service account we don't want to set a password.
When I run the release I get the following error message:

Cannot bind argument to parameter 'String' because it is an empty string.

The release runs without error if the password field contains a random character.
So, it does not seem like the password is truly an optional field?

@Ianril According to the help text for the password field, the only case where the task will not require the password is when you are using a gMSA account. You can find more info about gMSA on the internet. (ex: https://blogs.technet.microsoft.com/askpfeplat/2012/12/16/windows-server-2012-group-managed-service-accounts/)

Has there been any movement on this?  I don't understand why this is an enhancement and not a defect.  The field is marked as optional but the task throws an error when it is not provided.

Any communication on a timeline when this will be corrected?  For security sake, we would like to move to deployment groups in our releases but cannot without this working.

Sorry for the delay. We are looking into this. I will update on timelines soon.

The fix should be available in all accounts within 2 weeks.


[Debugger] Cannot find module '_debugger'

Hi team,
Today when I tried to use the brw.enterRepl();  command to run the debugger into my tests I got this weird error.
My Environment

Node Version: 8.9.4

Protractor Version: 5.2.2

Browser(s): Chrome 65.0.3325.181

Operating System and Version: MacOs High Sierra 10.13.3

Output from running the test:

Steps to reproduce the bug
I just used brw.enterRepl(); and I got the error where says the debugger cannot found the _debugger module.

It seems when I installed all the NPM modules, the protractor module not installed all the dependencies.

Closing because duplicate with  #4307


Stack Smashing

13:36:40.995 -> BLE Advertised Device found: Name: , Address: 4f:94:11:6f:26:4e, manufacturer data: 4c001005229870d425, txPower: 8, rssi: -74
13:36:40.995 -> BLE Advertised Device found: Name: , Address: 06:ad:cd:18:de:2f, manufacturer data:<PHONE_NUMBER>2a5b65e3ab75c44a6967734c656e6f766f, rssi: -96
13:36:42.531 -> Found our service
13:36:42.531 ->
13:36:42.531 -> Stack smashing protect failure!
13:36:42.531 ->
13:36:42.531 ->
13:36:42.531 -> Backtrace: 0x40082399:0x3ffc84c0 0x4009372d:0x3ffc84e0 0x400823aa:0x3ffc8500 0x400d5e92:0x3ffc8520 0x400d5f91:0x3ffc85c0 0x400d68c7:0x3ffc8610 0x400d69fe:0x3ffc86b0 0x400d235d:0x3ffc8710 0x400d256d:0x3ffc8750 0x400da2e0:0x3ffc8770
the BLE client application is restarting again and again when it attempts to connect to an ios device on which the server is hosted
And there is a stack smashing protect failure
I am not able to find where the issue is.
If the ble library is compatible with ios devices, it should work

exact same bug here

downgarded to ESP version 2.0.17 and no more crash but still no notification

Find the following function in the BLERemoteCharacteristic.cpp file and replace it with it. The problem will be solved.
void BLERemoteCharacteristic::retrieveDescriptors() {
log_v(">> retrieveDescriptors() for characteristic: %s", getUUID().toString().c_str());
// Remove any existing descriptors.
removeDescriptors();
uint16_t offset = 0;
esp_gattc_descr_elem_t result[10];  // Array to hold multiple results.
while (true) {
uint16_t count = 10;  // Number of descriptors to retrieve in each call.
esp_gatt_status_t status = ::esp_ble_gattc_get_all_descr(
getRemoteService()->getClient()->getGattcIf(),
getRemoteService()->getClient()->getConnId(),
getHandle(),
result,
&count,
offset
);
if (status == ESP_GATT_INVALID_OFFSET) {  // End of the entries.
  break;
}

if (status != ESP_GATT_OK) {
  log_e("esp_ble_gattc_get_all_descr: %s", BLEUtils::gattStatusToString(status).c_str());
  break;
}

if (count == 0) {
  break;
}

for (int i = 0; i < count; i++) {
  log_d("Found a descriptor: Handle: %d, UUID: %s", result[i].handle, BLEUUID(result[i].uuid).toString().c_str());

  BLERemoteDescriptor *pNewRemoteDescriptor = new BLERemoteDescriptor(result[i].handle, BLEUUID(result[i].uuid), this);
  m_descriptorMap.insert(std::pair<String, BLERemoteDescriptor *>(pNewRemoteDescriptor->getUUID().toString(), pNewRemoteDescriptor));
}

offset += count;  // Increment the offset by the number of descriptors retrieved.

}
log_v("<< retrieveDescriptors(): Found %d descriptors.", m_descriptorMap.size());
}

thanks for your answer but it did not solved the issue.
To fix it I removed the warnings :
bool setupCharacteristics(BLERemoteService* pRemoteService, NotifyCallback pNotifyCallback)
{
// Get all the characteristics of the service using the handle as the key
pmapbh = pRemoteService->getCharacteristicsByHandle();
// Only interested in report characteristics that have the notify capability
for (itrbh = pmapbh->begin(); itrbh != pmapbh->end(); itrbh++)
{
BLEUUID x = itrbh->second->getUUID();
Serial.print("Characteristic UUID: ");
Serial.println(x.toString().c_str());
// The UUID must match the report UUID
if (ReportCharUUID.equals(itrbh->second->getUUID()))
{
  // Found a report characteristic
  Serial.println("Found a report characteristic");

  if (itrbh->second->canNotify())
  {
    Serial.println("Can notify");
    // Register for notifications from this characteristic
    itrbh->second->registerForNotify(pNotifyCallback);

    sprintf(bfr, "Callback registered for: Handle: 0x%08X, %d", itrbh->first, itrbh->first);
    Serial.println(bfr);
  }
  else
  {
    Serial.println("No notification");
  }
}
else
{
    sprintf(bfr, "Found Characteristic UUID: %s\n", itrbh->second->getUUID().toString().c_str());
    Serial.println(bfr);
}

}
return true; // Indicate success
}
bool connectToServer()
{
Serial.print("Forming a connection to ");
Serial.println(myDevice->getAddress().toString().c_str());
BLEClient*  pClient  = BLEDevice::createClient();
Serial.println(" - Created client");
pClient->setClientCallbacks(new MyClientCallback());
// Connect to the remote BLE Server.
pClient->connect(myDevice);  // If you pass BLEAdvertisedDevice instead of address, it will be recognized type of peer device address (public or private)
Serial.println(" - Connected to server");
// BLE servers may offer several services, each with unique characteristics
// We can identify the type of service by using the service UUID
// Obtain a reference to the service we are after in the remote BLE server.
// This will return a pointer to the remote service if it has a matching service UUID
BLERemoteService* pRemoteService = pClient->getService(serviceUUID);
if (pRemoteService == nullptr)
{
Serial.print("Failed to find HID service UUID: ");
Serial.println(serviceUUID.toString().c_str());
pClient->disconnect();
return false;
}
Serial.println(" - Found HID service");
setupCharacteristics(pRemoteService, notifyCallback);
pRemoteService = pClient->getService(BatteryServiceUUID);
if (pRemoteService == nullptr)
{
Serial.print("Failed
to find battery service UUID: ");
Serial.println(BatteryServiceUUID.toString().c_str());
}
else
{
Serial.println(" - Found battery service");
setupCharacteristics(pRemoteService, BatteryNotifyCallback);
}
connected = true;
return true; // Indicate success
}


Update on the automatic change cyber security

Add the update and automatic Control hackers

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[x] I have added the 'writer impact' label
[x] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Best business


L515. NiR, DEPTH and RGB data are not synchronized with each other (frame numbers of NIR, DEPTH and RGB are different).

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
L515

Firmware Version
<IP_ADDRESS> To <IP_ADDRESS>

Operating System & Version
Win (8.1/10)

Kernel Version (Linux Only)

Platform
Pc

SDK Version
}

Language
C/C#

Segment

Issue Description

Config

Get frame and print the number of frames of each type.

Output: Frame number of them are not the same => NiR, DEPTH and RGB data are not synchronized with each othe.

Question
Why is there such difference? Please tell me how to solve this problem?

@RealSenseSupport  please help me with this problem! Thank you!

Hi @anhTuan0712
Just a couple of observations.  I notice that you're able to set the camera into the same resolution for all streams.  Our supported Depth, IR, Confidence resolutions are 320x240, 640x480, 1024x768.  The color resolutions that are supported are 960x540, 1280x720, 1920x1080
When I configure my camera using RealSense Viewer, the Depth, IR and Confidence streams are aligned.  When pausing the stream, you can see that the streams are aligned on frame number etc.  Color is a separate stream and I wouldn't expect the color stream frame count to be identical to that of the Depth, IR, Confidence streams.
I'm using the 2.43 RealSense Viewer and L515 camera FW 1.5.5 which is the latest FW.

Hi @anhTuan0712
Just a couple of observations. I notice that you're able to set the camera into the same resolution for all streams. Our supported Depth, IR, Confidence resolutions are 320x240, 640x480, 1024x768. The color resolutions that are supported are 960x540, 1280x720, 1920x1080
When I configure my camera using RealSense Viewer, the Depth, IR and Confidence streams are aligned. When pausing the stream, you can see that the streams are aligned on frame number etc. Color is a separate stream and I wouldn't expect the color stream frame count to be identical to that of the Depth, IR, Confidence streams.
I'm using the 2.43 RealSense Viewer and L515 camera FW 1.5.5 which is the latest FW.

I'm glad I received your answer!
I have the following 2 issues that need you to clarify:

Do you have any mistakes when you say "The color resolutions that are supported are 960x540, 1280x720, 1920x1080",when I check that color resolution 640x480 still supported on SDK 2.43 and FW 1.5.5?

Yes I understood this issue " Color is a separate stream and I wouldn't expect the color stream frame count to be identical to that of the Depth, IR, Confidence streams." but why Depth and Ir are not aligned (asynchronous).
2.1) when I use the SDK in my application the number of the IR frame and the Depth frame number is sometimes not aligned (asynchronous).
2.2) Here is my code (I check if not aligned then stop program).

2.3) Here is the error output.

2.4 )The error will be more easily encountered if the computer CPU is high.

Hi @anhTuan0712
Do you have any mistakes when you say "The color resolutions that are supported are 960x540, 1280x720, 1920x1080",when I check that color resolution 640x480 still supported on SDK 2.43 and FW 1.5.5?
As stated our official supported RGB resolutions are 960x540, 1280x720, 1920x1080.  If your camera is showing more than this, it is an anomaly.  Future FW releases may remove these unsupported resolutions, I just want to make sure you're aware of that.
Regarding synced frames, I cannot see anything specific in your code that could cause this but I do not think any of our samples that keeps records of frames similar to that of the RealSense Viewer is having issues with missed frames or unsynced frames.

Hi @RealSenseSupport .

This problem "As stated our official supported RGB resolutions are 960x540, 1280x720, 1920x1080. If your camera is showing more than this, it is an anomaly. Future FW releases may remove these unsupported resolutions, I just want to make sure you're aware of that" I understand, thank you.
For this issue "Regarding synced frames, I cannot see anything specific in your code that could cause this but I do not think any of our samples that keeps records of frames similar to that of the RealSense Viewer is having issues with missed frames or unsynced frames.", it only shows up at a few moments and then it can be restored on its own, so it's unlikely that you can see the error in the Realsense Viewer (recommended above).

=> Please check like my code above.

Hi @RealSenseSupport.
On the "Intel realsense viewer" app, it's hard to see this error but luckily I've seen it.

Hi @anhTuan0712
We are still not able to reproduce this at all.  We also went ahead and updated the Viewer to 2.47 which is the latest to make sure we have the latest updates to the SDK package and updated the L515 FW.  Did notice you using the 2.43 release.  I'm wondering if it's a system level or USB level bandwidth issue that could be causing the frames to arrive delayed.

Hi @anhTuan0712  Do you require further assistance with this case, please?

Case closed due to no further comments received.


Parallel hang attempting to process extra ghost nodes/zones

Describe the bug
I looked into why the mili.py regression test is hanging in parallel mode on Windows.
The hang occurs in avtGenericDatabase::CommunicateGhostZonesFromDomainBoundaries while processing extraGhostNodes/extraGhostZones.  1 of the processors has extraGhostZones information and goes down the path of attempting to ExchangeScalar, which leads to a parallel communication attempt , the other doesn't take that path.
To duplicate I opened mili_test_data/single_proc/d3samp6.plt.mili using 2 processors, and created a Pseudocolor plot of Primal/Shared/edrate
I think the extraGhost information needs to be shared across processors ?

What might have to happen is some collective comm on a bool as a precursor step to indicate if any processor needs to take that path and if so, all processors take it though those that do not need to are able to without contributing any data (e.g. sends or allgathers or whatever are of zero size) in the MPI calls.


Upgrade to node v4.4.6

Bug: T138561

Coverage remained the same at 95.132% when pulling b006feae1b3b7126e30c765d84adaf8219b48edd on d00rman:node446 into 472767b579c20ad1bf7c2d21bd863dbef61be052 on wikimedia:master.

I don't think that' required for a change like this, but 👍

Yes, it is. We use the node version from package.json to build the module dependencies for the deploy repo, and we have binary ones there.

@d00rman I mean if my +1 is necessary for such a change, not that the change is necessary :)


Is it possible to set column_name based on value from request.user data in data export?

Is it possible to set column_name based on value from request.user data, for example, request.user.company.name?
class UserProfileResource(resources.ModelResource):
    custom_field = fields.Field(attribute="custom_field", column_name="...")

Yes you can do this if you dynamically create a Resource, for example:
class YourResource(ModelResource):
    def __init__(self, company_name):
        super().__init__()
        self.fields["custom_field"] = fields.Field(
            attribute="custom_field", column_name=company_name, widget=widgets.CharWidget()
        )

The slightly tricky part is injecting the company name when instantiating the Resource.  Are you exporting via the Admin interface?

Are you exporting via the Admin interface?
Thank you @matthewhegarty . I export in Celery task so there is not a problem.


macOS App

i miss in readme:
i need to checkout this repo and build the macOS client? or where i can find it after the pod install?

You have to build it, right after its own pod install

@yagiz this could be a good idea to use the release side of GitHub tu put macOS .app, no ?

@juliengdt Currently this repo contains both iOS and macOS client. Release side is only for Pod version. I think separating these would be a better approach.


Explore additional layout control surfaces for discoverability

The goal of this issue is to experiment with new layout control surfaces to help users understand/discover the different layout customization options.
The initial version of this is available in insiders and disable-able via workbench.experimental.layoutControl.enabled

The latest here is

hei, how can we exit the view without keyboard?

I think we should add a close button to the left-top

From testing: Some entries toggle on click, other entries are more like radio boxes, I think this picker needs a UX revisit.

My thoughts:

I like the theme picker-like quick pick approach
Can we get radio buttons supported?
Can we use checkboxes? Instead of the eye?
Highlighting sections based on the hovered/focused item is a great idea

Can we get radio buttons supported?
Can we use checkboxes? Instead of the eye?

Right now the quickpick is all or nothing with checkboxes so that would need to change but is a pretty large item.
Only after that would it be worth implementing radio button support for a group for this feature.
Also I might also say that having #120866 would be a dependency as I think a bunch of checkboxes (6 in this case) is kinda jarring over the approach @sbatten already took.

I think one of the way to fix the mixture of toggles is to switch to using checks for all items, which makes it easier to understand and it maps to the appearance menu. I'd also remove the layout modes as those aren't really customization. I'd also rename the titles to make them more readable:

@misolori this is not really possible with today's quick pick, but I agree on having a more uniform visualization. The current design spawns from another desire: I would like to come up with a UX that does not prevent us from adding custom visualization icons as well. On the left it would be nice to have codicons for each part to help the user identify the parts before selection

Based on @sbatten's idea on adding icons for each area to identify the area I made a little mockup that could show this:

There were also some other ideas from the design team around using the right controls (checkbox vs toggle), which would require some api changes, that i think properly represent each control:

There's also the "simpler" approach of no icons:

Also +1 to highlighting the active area for the visibility items:

@misolori

I think one of the way to fix the mixture of toggles is to switch to using checks for all items, which makes it easier to understand and it maps to the appearance menu.

All checks feels bad to me since some are checks and some are radio buttons.
That last mockup looks fantastic though 👍

Short-term, how about prefixing mutually-exclusive labels with circle-filled or circle-outline, and toggles with check or nothing? Put the appropriate layout icon (after) that state-icon.

Short-term, how about prefixing mutually-exclusive labels with circle-filled or circle-outline, and toggles with check or nothing? Put the appropriate layout icon (after) that state-icon.

A mockup I created using Developer Tools

Prefixes are \eab2 (check), \ea71 (circle-filled) and \2003 (EM SPACE)

maybe it's better to use dot instead for activity-bar and status-bar
I think it is hard to distinguish sidebar and activity-bar at first-quick peek

It's a really useful feature, especially including the menu bar since pressing alt frequently doesn't work.
How will users using the native title bar find the feature, though? If I didn't skim the release notes I wouldn't have found it.

I'm not seeing that layout button.

@ElanHasson You can add it with

@sbatten maybe link that description's mention of custom title bar to the setting that controls this.

I used to locate my terminal at the left side(right next to the side bar) like what "move panel to left" did in the previous version (1.63).
So I wanted to make it similar using this updated feature but I couldn't find the option that moves the side panel to the left side.
Or am I missing something?

@lexiconium see https://github.com/microsoft/vscode/issues/142075 https://github.com/microsoft/vscode/issues/141569

@ElanHasson @bpasero @heartacker @Tyriar @TylerLeonhardt please fix what you broke ( #141569 ) before experimenting with stuff.

@adam-arold what makes you think I had anything to do with this?

@adam-arold what makes you think I had anything to do with this?

This issue was referenced in the release notes in the section that introduced the breaking change.

I would like to have a quicker way to show/hide the side panel, something similar to the activity bar would be perfect.

This issue was opened by (and is assigned to) @sbatten. I am not a member of the project team.

I see. Who can I talk to in this case if the issue was purposefully miscategorized as a feature request instead of a breaking change?

I would like to have a quicker way to show/hide the side panel, something similar to the activity bar would be perfect.

@AlbertoFabbri93 are you seeing the Configure Layout button on your title bar?

If not, set "workbench.experimental.layoutControl.enabled": true and "window.titleBarStyle": "custom"
Hold down your mouse button on that button, drag the highlight down the menu to Show Side Panel item, then release the mouse button.
If you prefer a keyboard shortcut, bind one to the View: Toggle Side Panel command.

@ElanHasson You can add it with

Thanks @sbatten.
I'm also seeing an issue when I set a layout it doesn't persist across sessions. My expectation was that if I set a layout, it persists without additional config.

@ElanHasson can you please file a separate issue with repro steps so I can confirm whether the behavior you are seeing is a bug?

Will do.

Similar use case as @lexiconium. I'm curious if we're overlooking something.
Prior to the new layout controls, I was able to dock my terminal side-by-side with the Side Bar on the right side of the window. As far as I can tell, the new layout controls prevent this type of layout and, instead, enforce the Side Panel to be on the opposite side of the window as the Side Bar.

The button doesn't appear in full screen on macOS, could we move it to the tab bar instead? I'd like to use this, but I almost always have VSCode full screen, so I can't without changing my workflow.

@gjsjohnmurray Thank you very much for the reply, I have the Configure Layout button enabled but I feel like it is not that convenient if you are often toggling the visibility of the side panel.

I like the new feature, but it needs a quick access button (more than the button up top which requires two clicks, as opposed to the sidebar which only requires one click) and a key code (command-shift-B makes sense on a Mac).

Please help me see the button. I do not see the button, in full screen nor windowed.

My Settings:

window.titleBarStyle: custom
workbench.experimental.layoutControl.enabled: true
workbench.enableExperiments: true

Steps Performed (click to toggle visibility):

In full-screen mode.
Confirm window.titleBarStyle setting is custom (was already set to this).
Change workbench.experimental.layoutControl.enabled to true.
From full-screen to windowed mode.
Restart VS Code.
In windowed mode.
Merge all windows.
From windowed to full-screen mode.
Confirm workbench.enableExperiments is set to true (was already set to this).
Cry here.

VS Code 1.64.0 / MacOS Monterey 12.1

try my extension.
https://marketplace.visualstudio.com/items?itemName=heartacker.toggle-panel

I'm not able to get my preferred panel setup with the new sidebar, previously I had:

|------------editor------------|------side panel------|------side bar------|

@IdemIsDito , the new side panel cannot be moved to the same side as the side bar. To do this, we have re-enabled you to move the bottom panel to the the right side with the side bar.

For those following this issue, please try out this new setting in insiders: workbench.experimental.layoutControl.type

wonderful

inharmonious  menu icon
too bigger

@misolori maybe we go back to the less abstract icon for workbench

we've updated the layout icon to be a bit smaller, open to more feedback:


fix(ApiClient): fix handling text response from server. before fix handled only json response

Hi,
When server returns regular text, the response goes into "response.text" and not "response.body", so current ApiClient ignores it.

This changement return null in plain text if an action promise resolve or reject with null value, which is not practical.


ATE and RTE calculation

Hello these days I had the pleasure of using your repository, I wanted to ask if the metrics defined in the Cal_TE function are the same from which you obtain the values in the reference paper, also I wanted to ask you how they were defined in the code.
Thank you

Absolute trajectory error and relative trajectory error are defined in https://ieeexplore.ieee.org/document/9196860/similar and also another paper of ours: https://dl.acm.org/doi/abs/10.1145/3534594
Ate is the displacement error over the whole trajectory while rte is the ate for 1 minute.


Update to OpenGeode 0.1.0 cmake

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Silence management

User Story

As a Giant Swarm engineer, I want to be able to manage silences using Silence CRD only (without having to access to alertmanager)
As a Giant Swarm customer, I want to be able to see the silences on my installation, maybe create them for temporary test clusters as to not page Giant Swarm engineers

Tasks

[ ] Reflect status of silences in Alertmanager in Silence CRs (list of silenced alerts), maybe add an annotation on the cluster to know that it is affected by silences (kinda like what VPA does)
[ ] Have a read-only alertmanager (not able to create silences) https://github.com/giantswarm/giantswarm/issues/25312
[ ] Make alertmanager private if possible (port-forward only)?
[ ] Create silence CR through opsctl https://github.com/giantswarm/giantswarm/issues/25941
[ ] Document silences so customers can use them https://github.com/giantswarm/giantswarm/issues/23492 https://github.com/giantswarm/roadmap/issues/1045
[ ] Push silence operator into prometheus-operator

cc @giantswarm/sig-opsprocess did I miss anything?

looks good to me - i think the main thrust of the discussion was that we should have only one way to create silences, and that should be via silence CR, and i think this covers that


omni completion as a source

With nvim-compe, one could add omni completion as a source doing the following:
  source = {
    omni = {
        filetypes = {'tex'},
    },
    ....

This was really nice since we could use compe with vimtex completion, for example.
Is there any way to have the same feature in nvim-cmp?

I have no plan.
I hope someone create it.

That's a pity, I hope this will get resolved one way or another, vimtex is my only blocker to move to nvim-cmp

I've tried to support vimtex but vimtex's regular expression does not expose to the external plugin so I can't realize it.


refactor: remove service impl trait

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 299 (0.0%)  changed or added relevant lines in 5 files are covered.
7 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.2%) to 72.135%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

crates/service/src/routes/status.rs
0
1
0.0%

crates/service/src/routes/cost.rs
0
3
0.0%

crates/service/src/routes/request_handler.rs
0
6
0.0%

crates/service/src/service.rs
0
6
0.0%

crates/service/src/service/indexer_service.rs
0
283
0.0%

Files with Coverage Reduction
New Missed Lines
%

crates/service/src/tap/checks/deny_list_check.rs
1
98.15%

crates/service/src/service/indexer_service.rs
3
0.0%

crates/service/src/service.rs
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>7:
0.2%

Covered Lines:
5501

Relevant Lines:
7626

💛  - Coveralls


Add Pydantic Json field support

Fixes https://github.com/pydantic/pydantic-settings/issues/78

please review


Support for dependent jobs

Looking at metronome as a Chronos replacement, is there support (current or planned) in Metronome for adding jobs that run on completion of other jobs? Chronos supports this.

@srikanth-viswanathan There is currently no support, but one of the main items on the Metronome roadmap is the possibility to define workflows for jobs, which in effect will be much the same as dependencies in Chronos. We'll setup a design doc at some point in the future that will be open for discussion, but feel free to outline some of the functionalities or semantics you'd expect (apart from a 1:1 feature parity with Chronos).

hi @meichstedt:
We're keeping a close eye on this project at Yelp (with the thought that we could potentially replace Chronos with it), so I thought I'd chip in with some of thoughts on what we would like to see from workflows/a dependency graph.

We have pretty simple graphs: rarely do they go more than a few levels deep, though we do have some jobs that have multiple parents.

Each of our jobs are Docker images.

We're currently suffering because of chronos#543. I think the 'workflow' idea you have should be designed with this in mind - that is, each 'run' of a workflow should be an independent execution unit, so that partial runs of multiple executions aren't combined to trigger jobs. To be clear, I'd kind of expect a 'run' of a workflow to be a single invocation of the graph traversal, and each run to be a unique entity. That way, the problem described in the linked ticket couldn't occur, as a subsequent successful run of a job after a failure could not trigger the execution of a job from a previous run before all of the parents have run again.

The above problem does introduce some complexity: I guess metronome would have to 'snapshot' the current state of the graph to execute each run independently. A further thought needs to be given to the mutability of a run: if I were to delete or update a job that was part of a currently-executing run, what would happen? Would in-flight runs be modified, or untouched?
These are obviously difficult problems to solve, but it'd be great if you could keep them in mind whilst designing this feature, and we're happy to give thoughts and feedback going forward.
Thanks!

Hi @Rob-Johnson
thanks for your input, totally makes sense to me. The current design in Metronome is that each JobRun is unique and handled by a dedicated actor. To be in line with this, an actor handling one unique workflow invocation should naturally invoke distinct JobRuns (and fail if one required step eventually doesn't succeed, and not continue if a similar step of another workflow execution succeeds). It sounds crazy that Chronos interweaves workflow executions.
I guess for an MVP, a job that's part of a current execution could not be deleted/updated without canceling the execution, but it depends on the implementation: if a workflow references a specific job version, it could as well be easier to let it continue running even if the job spec has been updated in the meantime.
It'll take us some time to come up with a shareable design doc, but as said before, I'm happy to collect requirements/acceptance criteria 😀

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1637. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Is Old .net mvc or webapi can use idrv3 plug to connect idrv4 sso

I check a lot of information,like google,github,stackoverflow, many people have such a scene, is the use of isrv4 as the SSO server, then they have a lot of non.Net core.Net freamwork webapi , the old project to nedd token verification in idrv4 sso, so they can only use IdentityServer3.AccessTokenValidation.
In theory, a client system like AccessTokenValidation doesn't need to pay attention to which version of SSO is, because it will do token verification if it follows oidc protocol. I also see the above GitHub a lot of issue, but also illustrates the problem, but I would like to ask, because this scene will be more, so you can determine whether we use IdentityServer3.AccessTokenValidation compatible with all idrv4 in.Net freamwork old webapi? Because it's very likely that these old API will almost never be altered and upgraded to.Net
The version of core is a very common scenario for IdentityServer3.AccessTokenValidation's robust docking with idrv4's SSO. Whether your project is going to write a sample. Let me talk about how to use IdentityServer3.AccessTokenValidation in old.Net webapi projects to do idrv4 SSO. I think there will be many people who want to upgrade idrv4 want to know this knowledge.
Even a lot of people want to know whether old.Net MVC project can use original identityserver3 plug-in to connect idrv4's AuthorizationCode or other modes.
thank you
Sorry about my English is not good

https://github.com/IdentityServer/CrossVersionIntegrationTests

This seems to be a general question about IdentityServer - not a bug report or an issue.
Please use one of the our free or commercial support options
See here for more details.
Thanks!


Setting default for target scaling with MQ-CNN to True to work with D…

…istrOutput
Issue #, if available:
https://github.com/awslabs/gluon-ts/issues/1069
Description of changes:

Updated default scaling for large to True to be used with DistrOutput
Left default for scaling_decoder_dynamic_feature to be False
Pass scaling_decoder_dynamic_feature to training and prediction networks

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dcmaddix thanks! I think scaling must be off when quantile_output is used, because apparently the output doesn’t get scaled back: so you don’t want to scale the input, otherwise for fixed model parameters and two series ts and alpha*ts, you will get the same predictions for any alpha > 0. To allow for scaling in this case, the output quantiles should be scaled back.
On the other hand, scaling appears to be necessary when using distributions, otherwise NaNs are all over the place unless data is nicely scaled (like all time series with the same magnitude or something).
So I ended up making the default value for scaling dependent on what is being used, which maintains backwards compatibility in the quantile_output case, and fixese the distr_output one. Plus I've fixed the shape issue described in #1069.

@dcmaddix thanks! I think scaling must be off when quantile_output is used, because apparently the output doesn’t get scaled back: so you don’t want to scale the input, otherwise for fixed model parameters and two series ts and alpha*ts, you will get the same predictions for any alpha > 0. To allow for scaling in this case, the output quantiles should be scaled back.
On the other hand, scaling appears to be necessary when using distributions, otherwise NaNs are all over the place unless data is nicely scaled (like all time series with the same magnitude or something).
So I ended up making the default value for scaling dependent on what is being used, which maintains backwards compatibility in the quantile_output case, and fixese the distr_output one. Plus I've fixed the shape issue described in #1069.
Edit: I had to bump the test accuracy for the distr_output cases, since now the default scaling behaviour changed.

@dcmaddix thanks! I think scaling must be off when quantile_output is used, because apparently the output doesn’t get scaled back: so you don’t want to scale the input, otherwise for fixed model parameters and two series ts and alpha*ts, you will get the same predictions for any alpha > 0. To allow for scaling in this case, the output quantiles should be scaled back.
On the other hand, scaling appears to be necessary when using distributions, otherwise NaNs are all over the place unless data is nicely scaled (like all time series with the same magnitude or something).
So I ended up making the default value for scaling dependent on what is being used, which maintains backwards compatibility in the quantile_output case, and fixese the distr_output one. Plus I've fixed the shape issue described in #1069.
Edit: I had to bump the test accuracy for the distr_output cases, since now the default scaling behaviour changed.

Looks great, thanks for updating the default to cover both cases! :)


fix: server action

Fixes: https://github.com/dai-shi/waku/issues/554

It's not that easy, we need to split server code and client code.
For now, the boundary is file based, so this PR alone doesn't work.
As noted in #554, our first focus is importing server files from client files. Please be patient.


Add info on custom port for private registry image

I still think it is a bug in the portal, but according to the Uservoice posting, it is not (https://feedback.azure.com/forums/169385-web-apps/suggestions/31304650). So the docs should at least give a hint on how to work around this issue.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@sheepcount : Thanks for your contribution to the Azure documentation! The author, @ahmedelnably, has been notified to review your proposed change.

#sign-off


Issue #30 (#367)

[x] I have added the tests to cover my changes.
[x] I have updated the documentation and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

@venkatBala I'm handing this off to you to merge if you want.


Add Anti-crossing and Doped problem generators

Closes #621 as redundant

Codecov Report

Merging #693 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
+ Coverage   91.85%   91.95%   +0.09%
==========================================
  Files          60       61       +1
  Lines        4222     4274      +52
==========================================
+ Hits         3878     3930      +52
  Misses        344      344

Impacted Files
Coverage Δ

dimod/generators/__init__.py
100.00% <100.00%> (ø)

dimod/generators/anti_crossing.py
100.00% <100.00%> (ø)

dimod/generators/random.py
95.83% <100.00%> (+1.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec6944...ee8ae3f. Read the comment docs.

looks a lot cleaner!


WorldEdit mod malfunctions with SpongeForge present

Affected Product(s)
SpongeForge
Version
spongeforge-1.16.5-36.2.5-8.1.0-RC1256-universal
Operating System
Win10
Java Version
1.8.0_351 (Oracle)
Plugins/Mods
spongeforge-1.16.5-36.2.5-8.1.0-RC1256-universal
forge-1.16.5-36.2.39
And I tested:
worldedit-mod-7.2.5
worldedit-mod-7.2.6-SNAPSHOT-dist
worldedit-sponge-api8.1.0-7.2.11

Describe the bug
After editing the mods.toml in the WorldEdit jar file to remove the Sponge mod dependency data, the plugin loaded but did not function properly. Results were the same for WE versions 7.2.5 and 7.2.6. Several issues were found:
(1) The right-click event for the wand tool does not fire. Left click works OK.
(2) The majority of the commands don't work. e.g. //pos1, //pos2, //set, /jumpto, ...  There's lots of  Root command /unknown:replacenear does not have an associated plugin! and similar in the log.
(3) I could get a few commands to work but the results were very broken. //extinguish fires but won't put out fires, and the brush tool activates but no changes occur, Instead, the phase tracker says Illegal Direct Chunk Access.  This happens only with SpongeForge installed.
(4) The Sponge Version of WorldEdit (worldedit-sponge-api8.1.0-7.2.11) won't load in Forge at all, it just gives [com.sk89q.worldedit.world.registry.LegacyMapper/]: Failed to load the built-in legacy id registry java.lang.NoClassDefFoundError: net/minecraft/world/level/block/state/BlockState
Enginehub folks would vastly prefer that the Sponge version of WorldEdit worked on both SpongeVanilla and SpongeForge, The ideal situation would be that SpongeVanilla used the same obfuscation environment as SpongeForge, or at least allowed a way for plugins to work with Forge obfuscation mappings applied - this would allow the Sponge WorldEdit plugin to work on SpongeForge too.
Here's the server log from trying the brush tool, with WE version 7.2.5:
2023-01-10-1.log
Link to logs
No response

For reference, PR #3711 is where 1-3 of this went to roost.

(1) Fixed in #3844

(2) Fixed in #3847

(3) Fixed in #3855
worldedit-forge is now working properly.
mods.toml must still be edited to remove the broken dependency declaration. This has been fixed a while ago by https://github.com/EngineHub/WorldEdit/commit/770350b83133949cd909b07754d1cf5bf20755ed but no official build has been published since.

Here is a ready-to-use version, compiled from official sources without modifications:
https://github.com/Yeregorix/WorldEdit/releases/tag/7.2.6-spongeforge

If (4) is unlikely to be resolved, we can close this issue. At least we have WE working on both SpongeAPI8 platforms, even if they happen to be different versions.


Flow and StateFlow generics support for Swift

just like mvvm-livedata we need support of coroutines Flow out of box.
for iOS we need class-wrapper to save generic type and we need in iosMain generation of this class-wrapper accessors.
example:
commonMain
class MyViewModel: ViewModel() {
    val login: MutableStateFlow<String> = MutableStateFlow("")
    val isLoginEnabled: Flow<Boolean> = login.map { it.isNotEmpty() }
}

iosMain
class CMutableStateFlowOpt<T>(private val wrapped: MutableStateFlow<T>): MutableStateFlow<T> by wrapped {
    fun observe(block: (T) -> Unit): Closeable { ... }
}

class CMutableStateFlow<T: Any>(wrapped: MutableStateFlow<T>): CMutableStateFlowOpt<T>(wrapped)

class CStateFlowOpt<T>(private val wrapped: StateFlow<T>): StateFlow<T> by wrapped {
    fun observe(block: (T) -> Unit): Closeable { ... }
}

class CStateFlow<T: Any>(wrapped: StateFlow<T>): CStateFlowOpt<T>(wrapped)

class CFlowOpt<T>(private val wrapped: Flow<T>): Flow<T> by wrapped {
    fun observe(block: (T) -> Unit): Closeable { ... }
}

class CFlow<T: Any>(wrapped: Flow<T>): CFlowOpt<T>(wrapped)

iosMain (autogenerated by compiler plugin - need to be developed in this isue)
val MyViewModel.loginWrapped: CMutableStateFlow<String> = CMutableStateFlow(login)
val MyViewModel.isLoginEnabledWrapped: CFlow<Boolean> = CFlow(isLoginEnabled)

as result in swift we will see:
class MyViewModel: ViewModel() {
    let login: MutableStateFlow
    let loginWrapped: CMutableStateFlow<NSString>
    let isLoginEnabled: Flow
    let isLoginEnabledWrapped: CFlow<KotlinBoolean>
}

for now can be used https://github.com/rickclephas/KMP-NativeCoroutines


Allow referencing modules outside of node_modules folder with @angular/compiler-cli 5.0.0

- [x ] bug report -> please search issues before submitting
- [x ] feature request

Versions.
angular 5.0.0
ngtools/webpack 1.8.0
Repro steps.
we have application that uses umd angular libraries which reference current application modules. with new compiler-cli this is not supported as it does a check if module resides within node_modules folder. with old cli we were able to use webpacl alias's to resolve this. but seems like with new version we are not able to complete this change.
Gives below error:
Error: Trying to import a source file from a node_modules package: import /Users/123/stash/features/xyz-ui/app/xyz/core/coreModule.ts from /Users/123/stash/features/xyz-ui/node_modules/@ xyz/ux/ux.ngfactory.ts
Ex:
our application has core module under app/core/coreModule.ts and also contains app/core/public_api.ts (which exports coreModule.ts)
application also uses umd bundled library from node_modules/@xyz/ux folder using @xyz/ux import. and this folder reference app/core/coreModule through @xyz/core import.
our build tscofnig contains paths to point @xyz/core to app/core/public_api.ts.
with new compiler and ngtool/webpack builder we are not able to build the app as compiler_host.ts throws error from below line.
https://github.com/angular/angular/blob/3db7112b89c609389abd8b48b0610f9c6f9510a6/packages/compiler-cli/src/transformers/compiler_host.ts#L579
Appreciate if this can be resolved with next minor version.

Same as @mlakmal, but only in AOT not with ng serve.
It's seems to be clearly impossible to build an app in AOT mode with a node_module importing environments/* or any others paths relative to the current project
Somebody knows a quick fix to bypass this ?
Previous CLI's version could be compatible with angular 5.x ?
Thx a lot.

Our quick workaround was just to comment out the line in compiler_host.js that's throwing the exception. Everything compiles fine after that, so it's definitely not a hard stop rule.

For production, with continious delivery, devops or similar, it could be a real hard stop ^^.
Anyway, your reply is welcome and really usefull.
Thank you @djimoh5 .
An other quickfix/fallback: compile without AOT and waiting for new release/fix, not perfect but it works.

We use this workaround:
https://gist.code.ipreo.com/sergii-kurganskiy/15412a7daac5270cf9cafe58c3e4bd7b
Basically it's just a copy-paste of internal webpack AngularCompilerPlugin code.

Hey @Paulskit, what exactly have you done? I cannot open the repo :|

Here is another link: https://pastebin.com/30qJPrNt
Workaround is to try regular resolving (the same as AngularCompilerPlugin already does) for modules that doesn't match (in ACP opinion).
Works great so far.

Sorry if I bother you with this, but how have you managed to integrate this in a CI environment with angular cli? As far as I know, you cannot modify webpack without detaching the app?

I use webpack directly with @ngtools/webpack. Angular CLI unfortunately doesn't offer enough flexibility for our needs.

Ok. For several reasons, I cannot eject the app here in our setup :(
Are there any plans to fix this in future CLI releases?

Unfortunately for now, we went with something like this for our build process:
<EMAIL_ADDRESS>patched="$compiler_host"".bak"
if [ ! -f "$patched" ]; then sed -i\'.bak\' \'186,188d\' "$compiler_host" && touch "$patched"; fi

I also hit the same issue. We have a shared module with typescript files and those modules are consumed by our main app.

Still happening with v6

Still happening with v6.9

This has gotten a bit stale. Can anyone reproduce this with 8.1.0?

@Splaktar
I just updated my answered, mixed up my npm version with angular and cli

Can someone provide a reproduction repository that we can clone and see this error please?

Can someone provide a reproduction repository that we can clone and see this error please?

It's not as simple as a single repo, one needs two repos and at least one of them published to npmjs or other NPM repo.
I'll try to do it but I don't know if I have time.
But sure this is problematic in complex enterprise architectures, and if there is no explicit need for this  check, it should be removed.

Unfortunately this is the situation for us too.
While we are slowly migraing to  monorepo we still have some (internally) published libraris, and if those depend on the libraries already in the monorepo we git this error. for now, we patch angular's compiler host, the current position of the error is on line
235 we nuke the whole else block with this: (angular 8.2.14)
` sed -i.bak '234,236d' "$compiler_host" && touch "$patched";
and everything works fine

It looks like this solution does not work in production mode. I get errors saying my service (which comes from the internal library) does not exists. And when I look at the output main.js there is indeed no reference to the service but the one place it is injected.
It is a component with 7 injected services and it's definition looks like this : [FeaturesServiceRestPublic,ApplicationServiceRestSecured,Sc,bl,J,xc,_c]
The first two where not imported not minified.


Replace rollup-plugin-html with @web/rollup-plugin-html

What I did

Replace rollup-plugin-html with @web/rollup-plugin-html
Also replace babel-plugin-bundled-import-meta with @web/rollup-plugin-import-meta-assets
Also replace @open-wc/rollup-plugin-polyfills-loader with @web/rollup-plugin-polyfills-loader

Fix #1980

We're planning on dropping support for IE11 in the generator, this reduced the need for a wrapper config like this one so we will ship just a plain rollup config in the generator. We can still make this change for people who still use the config though.
It looks like there are some functional errors with the integration tests, that needs to be looked into. Since you're no longer applying the babel import meta plugin, the assertions need to be updated.

Thanks @LarsDenBakker! I still have this one:

How to deal with this ids?

That'd be hard to test then, we can also skip them.

@LarsDenBakker updated! Now just one test failing 😕
https://github.com/open-wc/open-wc/pull/2213/checks?check_run_id=2641928407#step:7:175

Maybe related: https://github.com/open-wc/open-wc/issues/2037

@abdonrd you replaced babel-bundled-import-meta with @web/rollup-plugin-import-meta-assets so the test assertions need to be updated accordingly. I'll pull this branch and make the changes

Replaced by #2228


Update how-to-change-password.md

Added new video on the page. Rows 29 -31. Hope all works well.

I got just 'This video isn't available anymore'. Changed the link type to 'embedded'.


Decode split times

Add functionality to extract and decode personal best split times for each track, does not write anything new to CSVs or image/block device.
Clarify unknown track names
Cleanup CLI output into fixed width tables
Added 'cmos' structure information to README.md

TODO:

[ ] Verify times are correct for maps, assumed same track order (requires playing races on machine)

This is awesome! I hadn't even thought about the splits, that will be great to have too if we can write back for comparing actual speed runs. I'm going to merge this in now but I'm going to leave it open because I have some other questions comments.
I'll take a look at integrating the split times to the CSV output, I haven't looked at the code yet, but I'm going to guess there is only one per track would would be inelegant to add to the existing output. So this may be the thing to be worth restructuring to use better parameters.
It looks like you are using the v1.00d image for data, have you extracted the EXE from that? Someone on my discord server was saying it still has the debug symbols in it so that may be helpful.
_AiRabbit_WinHistoryData I feel like will be for the "Free race limiter" feature. The game is supposed to track the percentage of Win/Loss for players and adjust the AI to be harder so they can't get too many free races for coming in first. That variable name sounds like a good fit for the kind of data needed for that. There's not a lot to gain from reading that so it can probably be the lowest priority.

There's 5 split times for every track, but it appears some tracks don't use all 5, the code flags splits that still have the default times as unused. I suspect two separate CSVs will be the best implementation, but leave that till after the checksum mystery issue is resolved.
Yes I've decompiled the HYDRO.EXE from 1.00d (haven't looked at your image yet), symbols haven't been obfuscated much so I was able to get those human readable names for the offsets in the CMOS data.
The data area at _AiRabbit_WinHistoryData appears to have a couple functions that manipulate data there called _cmos_ResetAiDifficultySettings and _cmos_ResetTrackDifficultySettings called from the audit menu. (the audit menu isn't very complex)
I'm hoping the integrity checks the machine does at boot are very simplistic, it certainly predates cryptographically signed software but might have a checksum that needs to be bypassed, but if so I don't see why some menu items can't be changed from say "PRESS BOOST BUTTON TO START" to "SUBSCRIBE TO TECH TANGENTS". Graphics and model data will probably be quite difficult though, haven't figured any of that out.


feat(demo): add responsive step demo

Example demonstrates how to use responsive step feature and how to hide the grid when all columns are hidden
Close #95

I think hiding the grid when all columns are hidden shouldn't be addon responsibility. It's user choice whether hiding the grid or not by add a listener when a responsive step event is triggered. User should also take care of the initial flickering if decied to hide the grid in any step.

Placing the responsibility on the addon for managing grid visibility makes the implementation more convenient for users. It abstracts away the complexity of handling grid visibility and flickering, making the addon more user-friendly. Users can focus on defining responsive steps and let the addon take care of the details. Having the addon manage grid visibility ensures consistency across different implementations. It also makes the codebase more maintainable and less error-prone. If each user had to manually handle grid visibility, it could lead to varied implementations and potential issues.
Moreover, it's not that they "decide to hide the grid in any step", but that there will always be flickering in some device (thus any use of the feature would have to implement the workaround in order to prevent flickering).

In that case I'd create an opt-in feature to hide the grid when all columns are hidden.

But the issue has never been "hide the grid when all columns are hidden" but "Show Grid once [the first] ResponsiveStep applies". Regardless of how you configure the responsive steps, there will be some flickering until the first responsive step applies.


Update Network Commissioning cluster XML to match specification.

REVIEW NOTE: Only the first of the three changesets is manually-written.
Spec changes happened in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6193
Fixes https://github.com/project-chip/connectedhomeip/issues/25008

Is the removal of the zzz_generated Darwin files in the first commit intentional, they seem unrelated to this change?

Is the removal of the zzz_generated Darwin files in the first commit intentional

It is.  That code should not exist, did not exist, was incorrectly re-added by a bad merge in another PR, and mentions some of these types (which is why I noticed it).


feat(azure): add support for Azure DNS Private Resolver Inbound Endpoint

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Config-based prediction with Xarray-bsed output format

Add CLI to predict embeddings.
Use Xarray to organize and store the predictions so that specific conditions and cells can be indexed directly.

I've turned on the merge commits option. git log and git blame should be more intuitive to read.
There is a trade-off with git-blame granularity. With squashed commits it's easier to link a change to a PR, which in the longer term has been more useful for me. Also people tend to write PRs better than they would write each of the commit messages, and it is difficult to enforce descriptive commit messages without manually rewriting history very often.

Interactive prediction is quite useful. I also tested the prediction CLI. If feasible, please write lighting_logs during prediction to the parent directory of output_path.

@ziw-liu I think the prediction and plotting are in good shape! You can squash and merge the current state.
I am summarizing outstanding comments, which should be handled in the next PR:

Please write lighting_logs during prediction to the parent directory of output_path of predictions.
Consider using fastcluster? I notice a warning: Clustering large matrix with scipy. Installing fastcluster may give better performance.
Most importantly, does z-scoring of features collapse clusters?


Coder: add support for test unit execution

We want a test unit execution support similar to the example execution.

We can execute test cases for packages and package tags:

Group a filter result into package -> class -> method overview:


Investigate possibiilty to implement automations using browser-specific API

This task is divided into two subtasks:

[ ] Firefox #2623

[ ] Chrome #2624


Update submodule to use HTTP, correct branch

Two adjustments:

The SSH version of this only works if you use SSH keys. (This failed for me because I don't). I believe that HTTP should work for everyone in all circumstances because this dependency is public.
Use the specific branch in the submodule (ensures users don't need to submodule sync then check out the right branch)

Wonderful, many thanks @cjappl


esprima six

getting this error:
npm WARN deprecated<EMAIL_ADDRESS>deprecated in favor of rework-import
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":"0.8.x"} (current: {"node":"5.1.0","npm":"3.3.12"})
npm WARN install Couldn't install optional dependency: Registry returned 404 for GET on https://registry.npmjs.org/esprima-six
on os x 10.11.1

@niteswim: this issue is being tracked in #145

I pushed a hot fix to npm with<EMAIL_ADDRESS>which should fix installs. Let me know if there are more problems.


Error in merge to a quantized model: Cannot merge adapters to a quantized model.

Reminder

[X] I have read the README and searched the existing issues.

System Info
LLaMA Factory, version 0.9.1.dev0
Ubuntu LTS 20.4
Reproduction
Fine tune Qwen2-VL-72B-Instruct-AWQ model with lora:

model_name_or_path: /x/.cache/huggingface/hub/models--Qwen--Qwen2-VL-72B-Instruct-AWQ
stage: sft
do_train: true
finetuning_type: lora
lora_target: all
dataset
dataset: sensepro_dataset  # video: mllm_video_demo
template: qwen2_vl
cutoff_len: 1024
max_samples: 1000
overwrite_cache: true
preprocessing_num_workers: 112
output
output_dir: saves/qwen2_vl-72b-awq/lora/sft
logging_steps: 10
save_steps: 500
plot_loss: true
overwrite_output_dir: true
train
per_device_train_batch_size: 8
gradient_accumulation_steps: 8
learning_rate: 1.0e-4
num_train_epochs: 3.0
lr_scheduler_type: cosine
warmup_ratio: 0.1
bf16: true
ddp_timeout: 180000000
eval
val_size: 0.1
per_device_eval_batch_size: 1
eval_strategy: steps
eval_steps: 500

Expected behavior
I fined tuned a Qwen2-VL-72B-Instruct-AWQ model with lora and the output is in:
/x/lfactory/LLaMA-Factory/saves/qwen2_vl-72b-awq/lora/sft
When I try to merge the adapter_model.safetensors with the Qwen2-VL-72B-Instruct-AWQ, I got the following error:
 "ValueError: Cannot merge adapters to a quantized model."
Could you please help me to solve this.
Others
No response

+1

It is not possible to merge an adapter to a quantized model, use the un-quantized model instread

It is not possible to merge an adapter to a quantized model, use the un-quantized model instead

如果GPU资源无法加载没有量化的模型该怎么办呢？这样训练得到的qlora权重就会失去意义。能否在训练的时候加入选项，如果是qlora训得，就在最后保存模型的时候，直接保存已经合并了adapter权重的模型，并用awq，或者gptq之类的方法进行量化保存。

It is not possible to merge an adapter to a quantized model, use the un-quantized model instead

Pls can you tell if I can use llama-factory to quantize qwen2-vl-7b-instruct to an awq one?


feat: add postgis adapter support

Requests to the database through postgresql adapters and postgis adapters are identical, and it would be more convenient if it were not necessary to write the initializer config, which you advised for the example in this pull request https://github.com/pat/thinking-sphinx/pull/828

Thanks for the PR @mykhailovasylenchuk, but I'm going to leave this as it is. I realise it's a little less convenient, but I'd rather keep the directly-supported adapters to a minimum, so TS isn't so coupled to further adapters.


e2e/cypress:fixed test cases

Summary
accessibility_nav_diff_regions_spec.js
channel_members_rhs_spec.js
message_display_mode_colorize_username_spec.js
Release Note
NONE

/e2e-test

/update-branch

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/251092

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/251853

/update-branch


K8SPG-191 update crd on operator update

Test name
Status

init-deploy
passed

upgrade
passed

demand-backup
passed

smart-update
passed

scaling
passed

version-service
passed

recreate
passed

scheduled-backup
passed

affinity
passed

monitoring
passed

self-healing
passed

operator-self-healing
passed

clone-cluster
passed

tls-check
passed

users
passed

ns-mode
passed

commit: https://github.com/percona/percona-postgresql-operator/pull/228/commits/e7e0b81afd22f40651823ddc4f1de9e18ab4e779
image: perconalab/percona-postgresql-operator:PR-228-e7e0b81a-pgo-apiserver
image: perconalab/percona-postgresql-operator:PR-228-e7e0b81a-pgo-event
image: perconalab/percona-postgresql-operator:PR-228-e7e0b81a-pgo-rmdata
image: perconalab/percona-postgresql-operator:PR-228-e7e0b81a-pgo-scheduler
image: perconalab/percona-postgresql-operator:PR-228-e7e0b81a-postgres-operator
image: perconalab/percona-postgresql-operator:PR-228-e7e0b81a-pgo-deployer


Cypress tests for Back button

closes #738 LiveURL: https://smartfaq-cypress-tests-for-back-button.surge.sh

:tada: This PR is included in version 1.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SmartROI initial scan issue

branch: shifted_controllers and roi_debug
SmartROI was hanging after receiving an initial scan from the machine. This was not the scan that we had sent from the bridge.
Seems to be a problem in update_roi, which is called regardless of whether or not the scan is one we want to process.
Fixed in roi_debug by moving this line inside the check as to whether this is a scan we want to process.
But: need to check why this was happening -- why update_roi was upset with an MS1 scan from the machine.
Suggested test:
in shifted_controllers branch -- wrap the update_roi method in a try block and send the exception to the log...

We think this is due to the ROI code not handling profile mode scans. Needs to be checked, but no longer a priority.


Meta description validation

I added 3 meta description checks in validate_meta_descriptions task,
meta description should:

present in all .html files
be less than 160 characters
be not empty

related to https://github.com/fulldecent/mtssites/issues/45

Looks great, thank you


yardl version not yet defined or set during build

Soon we'll need to actually version yardl, which may include:

Defining version in the repo
Configuring build to set version/commit in cmd/yardl.go
Tag and release

https://github.com/microsoft/yardl/blob/76ea21d383fd8979dff584ae3b7de10f3e340453/tooling/cmd/yardl/main.go#L10-L13

@naegelejd, I'm sure we can improve the process, but we we tag and release, and set the version on the binary.
$ wget -q https://github.com/microsoft/yardl/releases/download/v0.3.0/yardl_0.3.0_linux_x86_64.tar.gz

$ tar -xvf yardl_0.3.0_linux_x86_64.tar.gz
LICENSE
NOTICE.txt
yardl

$ ./yardl --version
yardl version 0.3.0 commit b9465f513d149ba699da8531b65e3d786202d229

Got it. This is done automatically by goreleaser in the Github CI workflow
https://github.com/microsoft/yardl/blob/76ea21d383fd8979dff584ae3b7de10f3e340453/.github/workflows/ci.yml#L199
https://github.com/microsoft/yardl/blob/76ea21d383fd8979dff584ae3b7de10f3e340453/.github/workflows/ci.yml#L220-L224
Doing this locally at build time is not a priority, so... closing.


Vegas fails to work when circe 0.9.3 is imported in Zeppelin

Vegas doesn't graph if the user imports circe 0.9.3 in Zeppelin.
To reproduce in Zeppelin, import the following in the spark interpreter and run a sample Vegas example:

org.vegas-viz:vegas_2.11:0.3.11
io.circe:circe-core_2.11:0.9.3

Throws exception:
java.lang.NoSuchMethodError: io.circe.Printer.copy(ZZLjava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)Lio/circe/Printer;
  at vegas.spec.package$.<init>(package.scala:11)
  at vegas.spec.package$.<clinit>(package.scala)
  at vegas.DSL.ExtendedUnitSpecBuilder.toJson(SpecDSL.scala:55)
  at vegas.render.ShowHTML.apply(ShowRender.scala:19)
  at vegas.render.ShowHTML.apply(ShowRender.scala:18)
  at vegas.DSL.SpecBuilder$SpecBuilderRenderOps$.show$extension(SpecDSL.scala:99)

Attaching screenshots:
Failure: circe 0.9.3 is imported

Success: no circe library is imported

I am currently working on the fix for this. vegas.spec. Spec singleton seems to be the one that requires changes. I'd like to connect with contributors/founder who wrote that code. My suggestion is to reduce the number of lines in vegas.spec. Spec by modularizing it. There are more than 2000 lines in a single file.
Any feedback?

@aishfenton @oshikiri

My suggestion is to reduce the number of lines in vegas.spec. Spec by modularizing it. There are more than 2000 lines in a single file.

core/src/main/scala/vegas/spec/Spec.scala is automatically generated by argus package (c.f. https://github.com/vegas-viz/Vegas/issues/93 and here).

@oshikiri Updates on this:

It looks that argus needs to be updated to 2.8 (not released yet)
Assuming there is a breaking change in circe 0.7 - 0.9. Do you know of any?

Assuming there is a breaking change in circe 0.7 - 0.9. Do you know of any?

I don't know about it. Could you send a pull request and check using travis-ci?


Unable to detect error after calling functions.https.onCall -task is never faulted/cancelled

[REQUIRED] Please fill in the following fields:

Unity editor version: 2019.4.11f1
Firebase Unity SDK version: <IP_ADDRESS>
Source you installed the SDK: .unitypackage (.unitypackage or Unity Package Manager)
Problematic Firebase Component: Cloud Functions (Auth, Database, etc.)
Other Firebase Components in use: Auth, Firestore, Analytics, Dynamic Links(Auth, Database, etc.)
Additional SDKs you are using: Facebook, AdMob (Facebook, AdMob, etc.)
Platform you are using the Unity editor on: Window (Mac, Windows, or Linux)
Platform you are targeting: Android (iOS, Android, and/or desktop)
Scripting Runtime: IL2CPP (Mono, and/or IL2CPP)

[REQUIRED] Please describe the issue here:
I have been trying to call an onCall function from my Unity game, write some stuff into my Cloud Firestore, and back to Unity to detect if everything was okay or if there was an error. In order to proceed.
Things that work fine: calling the function, passing arguments, validating those arguments, writing into the database, returning successfuly value as a JSON string.
Things that do not work: detecting if there was an error or not in the onCall when I go back into the client side (i.e. Unity side).
The below is a simplified version of my Cloud Functions code. I am using Node.js 10, and writing in Javascript:
exports.tutorialCompleted = functions.https.onCall((data, context) => {

	return doSomething(data, context.auth.uid).then(newUData => {

             	...  //Create map

         	return JSON.stringify(map);

       }).catch(err => {
         	console.log('Error', err);

		//I tried to return:
         	// (1) return err;
		// (2) return null;
		// (3) return Promise.reject("rejected");
      		return new functions.https.HttpsError('Error', 'error');
       });
});

The return return JSON.stringify(map); works fine, and I can access the values. The problem is on the error. I tried (1) returning the same error that I get on the catch, (2) returning a null value, (3) returning a rejected promise, (4) returning (or throwing!) an HttpsError. None of these work! Unity always says that the task completed, that is not cancelled and not faulted.
Note: I have tried to purposefully send my function to the catch block. In those cases, (1-3) worked but were unrecognizable in my Unity side, and (4) simply exploded everything in the server side, and the game just froze waiting for a response that never came.

Now, my Unity code looks as follows:
internal static callFunction(string functionName, object data) {
        // Get the instance
        FirebaseFunctions ffunction = FirebaseFunctions.DefaultInstance;

        // Call the function
        Task<HttpsCallableResult> mytask = ffunction.GetHttpsCallable(functionName).CallAsync(data);

	mytask.ContinueWith((Task<HttpsCallableResult> task) => {

		// If the task was completed successfully
                if (task.IsCompleted) {
			Debug.LogError("Task Completed");
                }
		else if(task.IsFaulted) {
			Debug.LogError("Task Faulted");
		}
                else {
			Debug.LogError("Task Cancelled");
                }
            });
	}
}

Whatever happens, task.IsFaulted and task.IsCanceled will always say false, and the task.IsCompleted always says true. How should I detect the error in Unity. I don't want to make a workaround to send a custom JSON in case of error!

Does it work as expected if you replace return new functions.https.HttpsError with throw new functions.https.HttpsError as documented here?

Does it work as expected if you replace return new functions.https.HttpsError with throw new functions.https.HttpsError as documented here?

Hello @patm1987. As per my opening issue, on the point (4), I tried_"returning (or throwing!)_". So yeah, I've already tried what you suggest and still doesn't work. What happens is that Functions do not return anything to Unity, and Unity keeps waiting forever for a result that never arrives.

Hi @fer-gamboa
Just to confirm, does this issue happen on both Android and in Unity editor?
Also, if you deploy something like the following, does the Unity Task failed properly?
exports.httpErrorTest = functions.https.onRequest((request, response) => {
  // Send an http error with no body.
  response.status(400).send();
});

Thanks,
Shawn

Hello @chkuang-g. Thanks for replying, but as explained, I am using onCall and not onRequest. I cannot use onRequest either.
What I have found so far:

If a task fails, Unity will still recognise it as Completed and Failed, both at the same time. So you need to evaluate IsFaulted first, before the Completed.

When throwing an HttpsError, I can only make it work if the first argument is either failed-precondition or invalid-argument. Changing that to any other custom string completely invalidates the exception, and it is thrown in the Firebase console, never reaching Unity. However, I have not tested this much, but my initial attempts seem to point to this type of behaviour.

throw new functions.https.HttpsError('failed-precondition', 'Cannot complete the request');

@fer-gamboa
If you take a look of the description for Task.IsComplete, it stated: true if the task has completed (that is, the task is in one of the three final states: RanToCompletion, Faulted, or Canceled); otherwise, false.
https://docs.microsoft.com/en-us/dotnet/api/system.threading.tasks.task.iscompleted?view=net-5.0
That is, it is the right way to check Task. IsFaulted before Task.IsComplete.
Could you confirm if Task. IsFaulted is false in any of the following scenario?

return new functions.https.HttpsError('Error', 'error');
throw new functions.https.HttpsError() with error code listed here, except for "ok".

Thanks,
Shawn

I finally managed to try this. In particular, tried aborted and not-found.  In both cases I managed to catch it in Unity.
The message can be read if you do: task.Exception.InnerException.Message.
But to read the actual "code" (or text) that I wrote on the function, I needed to do:
// Cast the inner exception:
Firebase.Functions.FunctionsException fe = (Firebase.Functions.FunctionsException)t2.Exception.InnerException;

// Get the code
string code = fe.ErrorCode

In that case, when I sent aborted in CloudFunctions, I received Aborted in Unity. Notice the difference in capitalisation. I didn't manage to test more to see how the others (those with a - in between) are received in Unity.

Yes, you are correct.
You can see how to find the error code from this sample.
https://github.com/firebase/quickstart-unity/blob/241b0e5f527fb0b2088709a16e747d080853ca89/functions/testapp/Assets/Firebase/Sample/Functions/TestCase.cs#L64
So seems like we get some conclusion here:

In cloud function, throw HttpsError instead of returning it
Check Task.IsFaulted before Task.IsComplete
Use task.Exception.InnerException to get the error code.

I'll close this issue.  Please open a new issue if you still have problem using Functions.
Shawn


Add one-time filtering functionality:

What does this PR implement/change/remove?
This enables running single methods with filtering. Improves the filtering UX.
Checklist

[X] Tests added
[X] Similar commits squashed

The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes

Hey @jacobweinstock thanks for implementing this! It looks good to me,
I'll test it out on some hardware and report back.

This LGTM! just needs a rebase on main.


Roll Flutter Engine from 99f2653cbb79 to 9f3640822d6f (1 revision)

https://github.com/flutter/engine/compare/99f2653cbb79...9f3640822d6f
2023-05-25<EMAIL_ADDRESS>[Rasterizer] Make resubmit information temporary (flutter/engine#42001)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Introduce new SLA parameters related to the pilots

Latency, Bandwidth, Throughput, Packet Loss, Instantiation Time etc..

[ ] Need to check in detail all three pilots

[x] Find a way to split in pilot the same bussiness guarantee that is measures differently in each case

[ ] Industrial Pilot

GOLD

Availability > 99,99% --> NS1/NS2
Latency < 100ms --> NS1/NS2
Jitter < 20ms --> NS3

SILVER

Availability > 99% --> NS1/NS2
Latency < 500ms --> NS1/NS2
Jitter < 35ms --> NS3

BRONZE

Availability > 95% --> NS1/NS2
Latency < 1000ms --> NS1/NS2
Jitter < 50ms --> NS3

[ ] Include in the SLOs

[ ] Monitor them and check vilations - pending till metrics will be available from pilot side


High CPU usage on Mac OS. Drains battery on laptop.

I'm unable to reopen the following ticket, and am still having problems:
https://github.com/Microsoft/vscode/issues/38913
I've added comments to the above ticket.
Thanks

@rchavez-nejmgroup can you follow https://github.com/Microsoft/vscode/wiki/Performance-Issues

will do

FYI I am having the same issue on my macbook pro (high sierra 10.13.1), since vscode was updated (today) to 1.18.1. The fan is screaming since then :(

What is the size of your workspace/project (how many files)?
doesn't matter, the Code Helper fires up and consumes CPU as soon as VSCode starts
What languages are used in this project?
doesn't matter, see above.  Usually I'm just working in XML or JSON
Which Code process consumes the most resources?
Code Helper -- screen capture attached

The Code Helper process disappears when I exit VSCode
I've run code --disable-extensions  to see if there's an extension causing the problem, but Code Helper starts up and consumes CPU regardless
I've reset settings/emptied them - the problem persists
I ran code --verbose, but I'm not seeing any suspicious output

To find out more about this issue, we need to get at the process that is causing the high load. VS Code creates multiple processes, each with different tasks. Depending on your OS you can get at the full command line of the process and paste it here. On Mac, the Activity Monitor allows to find the PID of the process and from a terminal ps aux | grep <pid> reveals its arguments.

On Windows a tool like Process Explorer helps:

Once you have the information please update this issue with it. Thanks!

There appears to be only one process (69069).  Here's the dump:
rchavez          69069 214.3 13.3  7269408 2229080   ??  R     9:38AM   1:42.98 /Users/rchavez/Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper /Users/rchavez/Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap --type=watcherService
rchavez          69162   0.0  0.0  4278008   1056 s000  S+    9:39AM   0:00.00 grep 69069

Marking as duplicate of https://github.com/Microsoft/vscode/issues/3998 then. As a workaround you can set: "files.useExperimentalFileWatcher": true

When I run VSCode -- Insiders I don't have the same problem.  The Code Helper comes and goes in Activity Monitor, it doesn't stick around.  CPU usage is only 5.x% or so.