[Event Request] codeunit 952 "Time Sheet Chart Mgt."

Could you please provide a new Event Subscriber in codeunit 952 "Time Sheet Chart Mgt." to add more filters to record "Resource":
local procedure AddColumns(var BusChartBuf: Record "Business Chart Buffer")
    var
        UserSetup: Record "User Setup";
        Resource: Record Resource;
    begin
        if not UserSetup.Get(UserId) then
            exit;

        Resource.SetRange("Use Time Sheet", true);
        if not UserSetup."Time Sheet Admin." then
            Resource.SetRange("Time Sheet Approver User ID", UserId);
        // -NewEvent
       OnBeforeAddColumnsOnAfterSetResourceFilters(Resource);
       // +NewEvent
        if Resource.FindSet then
            repeat
                BusChartBuf.AddColumn(Resource."No.");
            until Resource.Next() = 0;
    end;

Publisher signature
// -NewEvent
[IntegrationEvent(false, false)]
local procedure OnBeforeAddColumnsOnAfterSetResourceFilters(var Resource: Record Resource)
begin
end;
// +NewEvent

@ElioCometto, you should provide the requested event signature, that this event can be added, as you wish. (Check out other issues to see how it can be provided.
e.g.
[IntegrationEvent(false, false)]
local procedure OnAddColumnsOnAfterSetResourceFilters(var Resource: Record Resource;)
begin
end;

Side Note: You can write al after the first three ` to get code highlighting ```al
'

@ElioCometto, you should provide the requested event signature, that this event can be added, as you wish. (Check out other issues to see how it can be provided.
e.g.
[IntegrationEvent(false, false)]
local procedure OnAddColumnsOnAfterSetResourceFilters(var Resource: Record Resource;)
begin
end;

Side Note: You can write al after the first three ` to get code highlighting ```al
'

@ElioCometto, you should provide the requested event signature, that this event can be added, as you wish. (Check out other issues to see how it can be provided.
e.g.
[IntegrationEvent(false, false)]
local procedure OnAddColumnsOnAfterSetResourceFilters(var Resource: Record Resource;)
begin
end;

Side Note: You can write al after the first three ` to get code highlighting ```al
'

@pri-kise, thanks for your advice.
I hope it is now in the correct form.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 43428.


permanent delete permission for blob/container SAS

Adds new permission to blob sas permission list builders.

/check-enforcer evaluate

/azp run java - storage - tests-weekly

nvm me, wrong PR.

LGMT. When we target this to main could you kick off weekly tests to validate that we got service versions conditions right?

/azp run java - storage - tests-weekly

API changes have been detected in com.azure:azure-storage-blob. You can review API changes here
API changes
-         V2020_10_02("2020-10-02");
+         V2020_10_02("2020-10-02"),
+         V2020_12_06("2020-12-06");
+         public boolean hasPermanentDeletePermission()
+         public BlobSasPermission setPermanentDeletePermission(boolean permanentDeletePermission)

/azp run java - storage - ci

/azp run java - storage - tests

/azp run java - storage - ci

API changes have been detected in com.azure:azure-storage-common. You can review API changes here
API changes
+         public boolean hasPermanentDeletePermission()
+         public AccountSasPermission setPermanentDeletePermission(boolean permanentDeletePermission)

/azp run java - storage - tests

/azp run java - storage - ci


Migrate ha-tahoma to Overkiz integration in core

Let's keep track of the PR's and the work we need to do, to get everything to core.
2022.2

[x] Base PR + Sensor
[x] Lock PR + platforms
[x] Button entity
[x] Number entity
[x] Light platform
[x] Small Overkiz refactor
[x] Add unique ID to config flow
[x] Scene platform
[x] Binary sensor entity
[x] Address feedback: full mypy strict typing
[x] Move to Overkiz 1.1.0 (remove casting in coordinator)
[x] Select entity
[x] Address feedback: improve coordinator with Registry
[x] Don't close HA session in Config Flow
[x] Switch platform
[x] Update sensor platform
[x] Add missing binary sensors
[x] Fix where model can be str(none)
[x] Add missing buttons
[x] Move to constants
[x] Add diagnostics support
[x] Address feedback (https://github.com/home-assistant/core/pull/64000#discussion_r786654864)
[x] Move logger _LOGGER = logging.getLogger(__name__) to const.py and import it
[x] Cover platform
[x] Address feedback: better config flows tests (https://github.com/home-assistant/core/pull/62640#discussion_r776278803)
[x] Implement reauth
[x] Add zeroconf discovery
[x] Implement Somfy OAuth

2022.3

[x] Siren platform
[x] Support StatelessAlarmController and StatelessExteriorHeating via switch
[x] Chain RTS cover commands
[x] Add Low Speed functionality

2022.4

[x] Alarm Control Panel platform (rewrite to EntityDescription)

Climate implementations

[x] AtlanticElectricalHeater
[x] AtlanticElectricalHeaterWithAdjustableTemperatureSetpoint https://github.com/home-assistant/core/pull/72790
[x] AtlanticElectricalTowelDryer https://github.com/home-assistant/core/pull/73788
[x] AtlanticHeatRecoveryVentilation https://github.com/home-assistant/core/pull/74015
[x] AtlanticPassAPCHeatingAndCoolingZone
[x] AtlanticPassAPCZoneControl
[x] AtlanticPassAPCDHW
[x] DimmerExteriorHeating (moved to number entity)
[ ] EvoHomeController
[ ] HeatingSetPoint
[ ] HitachiAirToAirHeatPump https://github.com/home-assistant/core/pull/81743
[ ] HitachiAirToWaterHeatingZone
[x] SomfyHeatingTemperatureInterface (parlty migrated to select / number entity)
[x] SomfyThermostat

TODO (2022.5 +)

[x] Fix assumed state check
[ ] Add local (jailbreaked) support (needs Config Flow work + pyoverkiz work + tests)
[ ] Water heater platform (one by one, and fully tested)
[ ] Add tests for diagnostics feature
[ ] Rewrite executions.get("") to have it typed
[ ] Extend diagnostics (add history of events) and make it possible to get it per device.
[x] Implement https://github.com/iMicknl/python-overkiz-api/pull/330
[ ] Code quality: move cover entities back to a single file

TODO (long term?)

[ ] Address feedback: less DRY in async_setup_entry https://github.com/home-assistant/core/pull/62916#discussion_r780707184
[ ] Support low speed service (is this still required?)
[ ] Raise Overkiz events in DataUpdateCoordinator (on failure etc.)
[ ] Add battery sensor (like in current state_attributes implementation)
[ ] Basic tests via setup.json definitions?
[ ] Execute command service?

Other

[ ] Merge core integration back to custom component (keep tahoma domain)
[ ] Fix remaining issues in ha-tahoma repo

(+ make sure all documentation is ready on-time for the core publish)

I've review all open overkiz core PRs, enjoy ;)
I can merge after they got fixed.

@Quentame <3, thanks! I hope to be a bit less busy in the coming weeks to add some more PR's!

2022.12: AtlanticPassAPCHeatingAndCoolingZone - PR https://github.com/home-assistant/core/pull/78659 got merged

2022.12: AtlanticPassAPCDHW - PR https://github.com/home-assistant/core/pull/78665 got merged

2022.12: Add Brandt, Hexaom, SIMU & Ubiwizz as virtuals integrations of Overkiz - PR https://github.com/home-assistant/core/pull/79566 got merged

2022.12: Add Overkiz AtlanticElectricalHeaterWithAdjustableTemperatureSetpoint - PR https://github.com/home-assistant/core/pull/72790 got merged

Interested in the "EvoHomeController", any update or estimated availability ?
I have it and can do some testings, currently I'm available to see the temperatures and set points of heating devices behind evohome.
Thanks a lot for this heavy work !

@sanvalerius does EvoHomeController work in ha-tahoma?

2022.12: Add Overkiz Hitachi DHW - PR https://github.com/home-assistant/core/pull/81536 got merged

2022.12: Add Overkiz DomesticHotWaterProduction - PR https://github.com/home-assistant/core/pull/81538 got merged

2022.12: Use same Overkiz (Atlantic) climate entity for 2 different ui widget name - PR https://github.com/home-assistant/core/pull/82955 got merged

@sanvalerius does EvoHomeController work in ha-tahoma?

Partially, on the "Overkiz" (official), I only get the room temperatures.
On the "Tahoma Custom", I get the room temperatures, the "set-point temp" (that I can set to a new value), with thermostat lovelace cards as well.
the Evohome controller "appears" as an entity, but seems doesn't display the live status (alway in auto) and We can't interact with it (ie change the mode to "away" or "holidays")


Razor Component "Retry" UI is hidden behind Bootstrap fixed-top navbar when connection is lost

I am running a mix of Razor Pages and Razor Components.
I have set my Bootstrap 4 Navbar css class as "fixed-top".
When the SignalR connection to the server is lost, the "Retry" UI is partially hidden behind the Navbar making it difficult, if not impossible to read.
Suggested fix, center the UI on both vertical and horizontal axes.
I would have a go at this myslef, or even just add a custom class in for it but I'm still a noob and trying to figure it out :)

So I found the css tag to change it if anybody needs it #components-reconnect-modal
I've added some padding to the top which has helped, but I feel this will be a problem for other people too so I think the default should be changed.

Thanks for contacting us, @smadgerano.
Would you like to send us a PR with the proposed fix? We'll happily consider it.

I've never done a pull request, and have no idea about running tests or creating them. I can try to pick some stuff up, but might take a while lol

Absolutely no problem - there is no urgency in regards to this issue, as it doesn't meet the bar for us to tackle immediately. We'll consider it for the 5.0 release.

this code creates a modal box using css to handle reconnect / reload

Lost Connection

                <button type="button" class="close" data-dismiss="modal" aria-label="Close">
                    ×
                </button>

                    Connection lost -- please wait, attempting to reconnect

                <input type="button" value="Reconnect" onclick="Reconnect()" />
                <button type="button" class="btn btn-secondary btn-sm" onclick="location.reload()" >Refresh Page</button>


Fade In Animation Missing

On Clicking notification icon-
Updates list need FADE IN animation -which is an UX enhancement.

Not really a necessity. Doesn't add much value to the cause.


lifetime: duplicated emit of eviction

fix duplicated emit of eviction event on evicting cut app.
add new event preemption on app been preempted.

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[ ] documentation is changed or added

Does this deprecate the event "evict"?

event evict was renamed to eviction


Use goreleaser to release to S3

In addition to releasing to GitHub, release the binaries to S3
so that they're available via CloudFront at
https://install.edgebit.io/releases/edgebit-cli/

Duplicate to #8


Explore Premium in Blocks

we newly implement the concept of premium and free concept in block

i explored the concept of free and premium concept in blocks it’s really amazing


[test] Improve testing for pdflatex builder

The current test for pdflatex involves generating a document and checking the resultant pdf file. It would be good to improve testing to support:

[ ] check of latex syntax against a reference?
[ ] include more tests for latex builder upstream in myst-nb
[ ] add more error conditions and test

Issue taken from PR #73


Duplicate Ids in a two instance microservice

Hello, I am using .Net 5 API and the nuget of the IdGen 3.0.0
I am using two instances of this API
In the logs, I noticed for some cases I have a pk violation, which pk is a long from IdGen .
Here are some pieces of my code
public static class UniqueIdGenerator
	{
		private static IdGenerator? _generator;

		public static void Configure(int generatorId)
		{
			if (_generator != null)
				throw new InvalidOperationException();

			_generator = new IdGenerator(generatorId);
		}

		public static long CreateId() => _generator?.CreateId() ?? throw new InvalidOperationException();
	}

Then I register it in program.cs class
public class Program
	{
		public static void Main(string[] args)
                {
                       UniqueIdGenerator.Configure(0);
                       //bla bla bla
                }
         }

and for example, if I want to create a new customer I call the static method like
public async Task AddCustomer(AddCustomerRequest request)
{
    var customer = new Customer
    {
        Id = UniqueIdGenerator.CreateId(),
        Name = request.Name,
        Phone = request.Phone
        //etc
    }
    //bla bla bla
}

Now I have some logs like that
Microsoft.EntityFrameworkCore.DbUpdateException: An error occurred while updating the entries. See the inner exception for details.
---> Microsoft.Data.SqlClient.SqlException (0x80131904): Violation of PRIMARY KEY constraint 'PK_Customers'. Cannot insert duplicate key in object 'dbo.Customers'. The duplicate key value is<PHONE_NUMBER>98987520).
And the customer with id<PHONE_NUMBER>98987520 already exists.
Is something wrong with my configuration of IdGen?
Thanks in advance!

I think you should use only 1 instance, I got this kind of issue before due to multi IIS worker
If you use multi instance, try to setup difference generatorID for your instances

IdGen is meant to be used as singleton (or as transient with guaranteed unique generatorid). If you're getting duplicate ID's then you're most likely using multiple instances with the same generator id.
See #33 or #26 for example,

Because it is not clear to me, do you mean for example in the first instance of microservice to use for example UniqueIdGenerator.Configure(0);
and in the second instance a different int like
UniqueIdGenerator.Configure(1);
?

Yes; if you have multiple instances they each need their own GeneratorID; they don't "know" about eachothers existence (hence the 'uncoordinated' part) and start generating ID's on their own. The only thing preventing collisions (duplicates) is each relying on having their own GeneratorId. But, if at all possible, I'd just use a singleton instance.


get rid of the plot chart pin button

This pin button is showing plot chart buttons because among the possible types of vtkMRMLAbstractViewNode, these are vtkMRMLPlotViewNodes.
One approach is to hide the pin button like we did with lungair here.

Also why are we using vtkMRMLPlotViewNodes and injecting tables into them rather than using vtkMRMLTableViewNodes?
Then we wouldn't have to create our own qMRMLTableView and inject it into the widget, but could instead use the vtkMRMLTableViewNode API for doing that. IDK if that's better or worse, just throwing it out there as something to consider.


Verb list page - Allow deselecting all verbs, Allow selecting all verbs

I thin we could have an upper checkbox where ticking you could get all selected and unticking you get everything wiped.
It could be a three state checkbox, marked --> all selected, gray marked --> some checks selected, not mark --> no verbs selected

Okay I have a question. If the upper checkbox is gray marked and you tick on it, all other verbs get selected or deselected?

I would follow same behavior as in GMail, if you do that by mistake you can click the cancel button and go back
What do you think?

I like the idea

What do you think about this approach?

Looks great,
We will have to work on the ui layout later on, but is great

I'm gonna create the PR then :)


[RFC] CORS

One of the next bigger features I'm planning on implementing is better support for CORS.  However, I wanted to take some time before starting development to hopefully gather some use cases/feedback from various developers.  The hope is to use this feedback to to develop the feature in the best way.
The current idea that I had was to use a config file with Regex based paths to control how CORs get applied.  Where default settings can be defined.  An array of paths can be defined using regex to control what regex header values get applied based on request url.  If the header value is not defined on a path, it would use the default value, otherwise would use the path specific value.
cors:
  enable_cors: true
  defaults:
      allow_credentials: false
      allow_origin: api.myapp.com
      allow_headers: ['X-Custom-Auth']
      allow_methods: ['POST', 'PUT', 'GET', 'DELETE']
      max_age: 3600
      expose_headers: []
      origin_header_name: Origin
  paths:
      '^public/api/':
          allow_origin: *
      '^/api':

Reasoning for liking this is it provides the most flexibility.  The regex could just match all routes and apply the default settings, or certain routes could be excluded, or certain routes could have diff settings if that was needed.
I also plan on looking into doing something similar to how rails did yaml config files, where you are able to pull ENV vars/etc into it, which would make for easy env based setups like Docker.
Any feedback/concerns/other ideas would be welcome.  Would like to have a solid idea that provides a clean, easy to develop, flexible experience.

Option 2:
Do something similar to Serialization Groups but for CORS.
The yaml file would still be used, but instead of regex based matching, use the config file to configure CORS defaults and/or a set of groups.  The config file would also have a setting on how to apply the settings.  Either all routes get the default settings unless overridden by a group or disabled explicitly on each route or only enabled for routes with a group.  In practice this would be a field in the route annotation:
athena.yaml
cors:
  enable_cors: true
  defaults:
    allow_credentials: false
    allow_origin: api.myapp.com
    allow_headers: ['X-Custom-Auth']
    allow_methods: ['POST', 'PUT', 'GET', 'DELETE']
    max_age: 3600
    expose_headers: []
    origin_header_name: Origin
  strategy: include
  groups:
    - public:
         allow_origin: *

Where this defines the defaults to use for all routes, where all routes will have the defaults, unless explicitly disabled or overridden. The public group includes settings from defaults if not set.
  # CORS explicitly disabled for this route
  @[Athena::Routing::Get(path: "/add/:val1/:val2", cors: false)]
  def self.add(val1 : Int32, val2 : Int32) : Int32
    val1 + val2
  end

  # CORS settings overridden by a group
  @[Athena::Routing::Get(path: "/me", cors: "public")]
  def self.get_me : String
    "Jim"
  end

Just make sure that default is not Allow-Origin: * to avoid CSRF issues

Yea for sure.  Is a good question of what to make the defaults.  I'm thinking im just not going to set any defaults as I don't really have a way to know their domain or what their settings should be.  Would be kinda strange to enable CORS and see nothing change but is a better alternative than a less secure default.

To give an update on this.  I did go with option 2.  It just provides the most flexibility, with a more easy to maintain setup.  High level plan of its functionality, subject to change:
cors:
  enabled: true
  strategy: whitelist
  defaults: &defaults
    allow_credentials: false
    allow_origin: <%= ENV["ORIGIN"] %>
    allow_headers: ['X-Custom-Auth']
    allow_methods:
      - GET
      - POST
      - PUT
    max_age: 3600
    expose_headers: []
    origin_header_name: Origin
  groups:
    - legacy:
        <<: *defaults
        allow_origin: <%= ENV["LEGACY_ORIGIN"] %>
        allow_methods:
          - GET
    - public:
        <<: *defaults
        allow_origin: *

The config is rendered via ECR before read; mostly to give support inserting ENV vars into the config.  In the future I could see this adding in settings dynamically based on ENV or some custom construct.
The config file uses YAML anchor tags to include options from the defaults group into other groups.  This allows for a clean syntax to reuse properties and only override the necessary ones.
The strategy property, either whitelist or blacklist, determines how the CORS settings get applied.

whitelist - Defaults are not applied to anything by default.  Will only apply the settings to controllers/actions explicitly set.
blacklist - Defaults are applied to all paths, unless explicitly disabled for a given controller/action.

In both cases, fields have been added to both the ControllerOptions and GET/.. method annotations.
@[Athena::Routing::ClassOptions(cors: false)\
struct MyController < Athena::Routing::Controller
  ...
  @[Athena::Routing::Get(path: "/public/test", cors: "public")]
  def self.public_test
    ...
  end
end

In this example, CORS would be disabled all actions within the MyController controller.  However it would be enabled with the settings from the public group on the public_test action.
The priority is action > controller > defaults.  Where defining a group on an action would override the settings of the controller.  Defining a group on a controller would override the default settings.
CORS priority, with inheritance, groups, and strategy should provide pretty flexible functionality.


fix: raises ValueError on conditional and operator

if lhs evaluates to false, rhs must be ignored, but rhs was evaluated then ValueError is occurred.
I fixed this issue same as OR operator.

Coverage decreased (-0.0002%) to 93.387% when pulling 7ee35a8510eff9d6a3c3385c8a8cf18c1819c712 on kiyonori-matsumoto:dynamodb-and-order into 2509237d6c65ab6717db6e2ada9ffea4a89dd8c4 on spulec:master.

Thank you!


Ability to get meta data on save()

Our server sends a new token once the current token has been expired. This is being received through the JSON in meta, which is being returned by the server. I can retrieve the new token through meta during the find - GET request. I want to do the same on the save - POST / PATCH. I can see the new token through the debug, but I cannot get it in the onSuccess closure.
I have a method called setupSpine(withContentTypeHeader: acceptHeader: andAccepterHeader: ) which returns a Spine object.
When I am saving a resource I use
setupSpine(withContentTypeHeader: "contentType", andAcceptedHeader: "accepted").save(resource).onSuccess { (resource) in
    // Manipulate the returned resource
}

I would like to have the ability to get the meta as I do in the find operation
setupSpine(withContentTypeHeader: "contentType", acceptHeader: "accept").find(query).onSuccess { (resources, meta, jsonapi) in
    print("Meta: \(meta)")
}

I managed to overcome this issue by creating a new function in the Spine class:
saveWithMeta<T: Resource>(_ resource: T) -> Future<(resource: T, meta: Metadata?, jsonapi: JSONAPIData?), SpineError>.
Using this function I can now use any top level meta which I am getting from the server.
@wvteijlingen what do you think about this approach?


Update torch to 2.1.1 and xformers to 0.0.23

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[X] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[ ] Yes
[X] No, because this is probably not necessary

Have you updated all relevant documentation?

[ ] Yes
[ ] No

Description
Update Pytorch to the most recent version 2.1.1 and Xformers to 0.0.23. Both versions are compatible with each other.
Update the required Torchvision version since Pytorch 2.1.1 requires Torchvision>=0.16.1
Tested without any errors or regressions.
Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

[ ] Yes
[ ] No : please replace this line with details on why tests
have not been included

[optional] Are there any post deployment tasks we need to perform?

Thanks @Malrama
Torch upgrades 🫣
Can a tester try updating from cu118 to 2.1.1+cu121 to see if there's any issues?

2.1.1+cu121

It is already running on 2.1.1+cu121. Everything running good!

I anticipate that the torch issues will continue (as they have already).

Bigger issue is that dependencies from torch include a typing_extensions update that seems to break
ImportError: cannot import name 'deprecated' from 'typing_extensions' (...\lib\site-packages\typing_extensions.py)
It looks like something deeper in Pydantic might need an update here too


next step

Helllo,
Thanks for your great tutorial - not really an issue but what is the next step after the predictions stage? e.g. constructing summary statistics?  https://github.com/yahoo/TensorFlowOnSpark/wiki/GetStarted_Standalone
Thanks
Nick

Hi Nick,
That tutorial was mostly to give folks a taste of running a TF app on top of TFoS.  You can add some summary statistics if you'd like... just note that this example does provide an accuracy per batch.  But basically, it's up to you (and/or your particular application's use-case) where to go next... e.g. you can either try to improve or fine-tune the model, or package it up for online serving (w/ TF-Serving), or use it (as-is) for batch inferencing...
Lee


📝 Add note in CORS tutorial about allow_origins with ["*"] and allow_credentials

Couldn't get credentials working with allow_origins set to ['*']. Thought this might help others.
I was lucky to find this after a while: https://stackoverflow.com/questions/46288437/set-cookies-for-cross-origin-requests
which explains: "Also, make sure the HTTP header Access-Control-Allow-Origin is set and not with a wildcard *."
Specifying some origins, allows my axios request with { withCredentials: true } set to work.

Good point! Thanks for the contribution @dsmurrell ! :rocket: :cake:
And thanks @Kludex for the review :coffee:


It should be possible to delete an organization containing suborganizations

We should probably add an extra warning screen when the user deletes an organization with suborgs, asking them if they are really really sure and that this action will also delete all suborgs


Support for managing Debian-based OS

The current os.pp limits this module to not being able to manage Ubuntu or other Debian-based OS. It would be helpful to add this ability, because the module is very close to working on Ubuntu otherwise. If helpful I could submit a small patch, after some testing, for Ubuntu.

Yes, please. If you have condition to test it propperly for debian, do it :-) . Please submit your small patch

Samuraiii added a Debian support for the module. Please could you test a new release beta 1.0.0-rc1 of the module?


feat(minifier): fold string.length / array.length

#8172  👈 (View in Graphite)
main

How to use the Graphite Merge Queue
Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 29, 2:13 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


New version: JetBrains.DataSpell version 2024.1

Created by 🥟 Dumplings in workflow run #4161.
Logs
Updated: 2023.3.5 → 2024.1
Submitting WinGet manifests

Microsoft Reviewers: Open in CodeFlow

Hi @SpecterShell,

This PR's version number 2024.1 has 2 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 2023.3.5, which has 3 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)
(Automated response - build 876)

Reset approval workflow.


Context driven conversations

Hi Devs,
Great work! There is a lot of potential for OSS LLMs, especially coming from a group like H2O.
Regarding some tests I've been doing: How do you include context in an instruction? e.g. tasks like summarization, Q&A based on a passage etc. When i was testing Dolly, there was a section under langchain where you can explicitly provide a context (https://huggingface.co/databricks/dolly-v2-12b#langchain-usage)
Is there a way to get this working with h2oGPT? Ive tried manaully appending a context before / after the instruction, but the model seems to ignore this. I saw a PR for Langchanin integration https://github.com/h2oai/h2ogpt/pull/111, and when this is merged would h2oGPT also support similar examples like what I pointed under Dolly?
Thanks,

First, I'll make sure to have a description like DB provide for langchain integration.  It basically involves using our pipeline, but I'll make sure it's tested etc.
As for context, in the langchain case it's just another f string one sets in the prompt format.  langchain by default hides alot of extra contextual things in its prompt for various tasks that are not really well suited for instruct-tuned models.  But I'll make sure to describe that in any doc updates.
Kinda related, but not exactly answering your question:
In the gradio app and API there is a "context" variable.  This is like the system instruction that is pre-appended (only once if in chat mode).
E.g. in expert mode at bottom:

Or for client API:
https://github.com/h2oai/h2ogpt/blob/e7835139eee24d5c371a435710298154c15806cd/client_test.py#L62

Thanks, interested in server side implementations so will try the api you provided.


base tailwind variables

I followed the install instructions and most of of tailwind works, but I noticed that I couldn't get the ring class to work with windicss.
For example, if I have run a file with a single file with <div class="ring-2" /> i get:
.ring-2 {
  -webkit-box-shadow: var(--tw-ring-inset) 0 0 0 calc(2px + var(--tw-ring-offset-width)) var(--tw-ring-color);
  box-shadow: var(--tw-ring-inset) 0 0 0 calc(2px + var(--tw-ring-offset-width)) var(--tw-ring-color);
}

But nothing appears as i suspect the css vars like --tw-ring-color and are not defined. This is likely a noob tailwindcss configuration issue, as I'm not sure how the base tailwind imports in a svelte project with windicss. Any ideas?

I think you're right. I must have missed something when defining this utility. I'll fix this problem later when I release a new version. please wait a moment.

Yes, i started to look at the source code and realized that you had completely replaced tailwindcss. But windicss is so fast, it's totally worth a few hiccups! :)

https://github.com/voorjaar/windicss/commit/4fa095b75518b8a313fcd467eafe53a76b633b87 fix this.


Dataset cannot be copied if masker comes from a gzipped file

When I try to use the ale_2mm target (e.g., when loading a Sleuth dataset), the resulting Dataset cannot be copied due to the following error:
TypeError: cannot serialize 'IndexedGzipFile' object

After digging a bit, if I just uncompress the associated mask file, everything works fine. I believe it's an issue I came across a while ago with nibabel (see https://github.com/cosanlab/nltools/issues/281). I thought the issue was resolved in the newest versions of nibabel, but I may have just misunderstood what was causing it. In any case, I think we need to either enforce uncompressed files for our masks or find some safer way of loading them in our masker objects.
BTW, converting to a masker with utils.get_masker() doesn't help.

As a temporary solution, we could incorporate a check into the get_masker() function that determines if an input is from a gzipped file and raises a warning if so?

@tyarkoni Based on some testing in #400 and the original cosanlab issue, it looks like the bug is eliminated by not having indexed_gzip installed. This is why I encountered the bug on my laptop and not in CircleCI.
Do you have any thoughts on what we should do? Add indexed_gzip as a dependency and work around the bug by default or add some kind of check to see if it's installed and raise a warning if the right conditions are met?

I don't feel I know enough about the packages in question to have an informed opinion, so I'll defer to your judgment on this.
The only thing I do feel pretty strongly about is that things should still work fine without any user intervention—a warning is fine, but no additional configuration should be necessary. Assuming that's what's on the table (i.e., implicitly unpack the gzipped mask to a temporary location and then use that instead, with a warning), that seems fine. But if this isn't already a known issue on the NiBabel repo, might be worth raising it for discussion there.

@rmarkello shared the following trick that we can use:
import gzip
import nibabel as nib

nib.openers.HAVE_INDEXED_GZIP = False
nib.openers.IndexedGzipFile = gzip.GzipFile

At the moment, it might be sufficient to place this in get_masker(), and then reset the nib.openers parameters after the image is loaded. There are probably a bunch of edge cases where this might not be enough (e.g., if a mask is "fetched" from a nii.gz file and loaded before reaching get_masker or if an image is provided at Dataset initialization instead of being loaded as part of __init__), but I don't think we can cover everything.

It looks like the original issue is resolved in indexed_gzip v1.1.0 (https://github.com/pauldmccarthy/indexed_gzip/issues/28), but now I get an error trying to do the same thing:

AttributeError: '_io.BytesIO' object has no attribute 'mode'

It looks like, now that indexed_gzip has resolved its issue, NiftiMasker is the problem.
from copy import deepcopy
from nilearn.input_data import NiftiMasker

masker1 = NiftiMasker('nifti.nii').fit()
deepcopy(masker1)  # no error

masker2 = NiftiMasker('nifti.nii.gz').fit()
deepcopy(masker2)  # error

Back to nibabel. I've opened https://github.com/nipy/nibabel/issues/969 about it.

Ref: https://github.com/pauldmccarthy/indexed_gzip/pull/50

This should be fixed in indexed_gzip v1.4.0, so it will be a matter of adding indexed_gzip >= 1.4.0 to our dependencies.

This should be fixed in indexed_gzip v1.4.0, so it will be a matter of adding indexed_gzip >= 1.4.0 to our dependencies.


Bug fix for deadlock issue with cache eviction

@aashraybhandar1 looks like duplicate of #529 please close if not required.


Provide llvm debug packages for windows and linux gcc 12

I want to debug the crashes on the C++ side, but currently there is only 1 llvm debug package llvm-791523-linux-x64-gcc-9-Debug.tar.xz.
I am using Windows and linux with gcc 12.
Provided with a debugging pipeline, I can debug/locate the crashes better and maybe assist you with a fix.
Because RelWithDebInfo doesn't apparently gives a crash log on Windows.
Thanks.

I tried with ubuntu gcc 9 unsuccessfully.

If you have the time to look into that, then that would be great.

I will take a look at the CI and seen what I can do.

The issue with these is all the inlined functions in LLVM/Clang won't have any entries in the call stack, which makes debugging almost impossible.

Yes I knew something like must be happening under the hood.

I'm currently on a time crunch for the following 2 weeks, most probably won't be able to look into anything CppSharp soon, but feel free to ask questions or ping me later and we can fix this.

No worries, we are not in a rush, I will open a PR which will add bindings generators for other languages and will start committing there slowly while benefiting from the CI.


Fix login state management

Purpose

Issue #1639 was caused by a stale login token not being refreshed after the expiry period
The login code only fetched the login token once when the page was loaded and did not properly reflect login state changes if the user logged in and out unless the page was refreshed.
Update the React state management code to use a context to pass login state to all the components that need this to render properly.

Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
[ ] Yes
[X] No

Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
[ ] Yes
[X] No

Type of change
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist
See CONTRIBUTING.md for more details.

[X] The current tests all pass (python -m pytest).
[ ] I added tests that prove my fix is effective or that my feature works
[X] I ran python -m pytest --cov to verify 100% coverage of added lines
[X] I ran python -m mypy to check for type errors
[X] I either used the pre-commit hooks or ran ruff and black manually on my code.

Manual deploy w/ app services login test

prettier failed!


improve performance of parseRange

before:
node benchmarks/parseRange.js
size: 150, bytes=0-100 x 1,905,512 ops/sec ±0.40% (191 runs sampled)
size: 150, bytes=0-4,90-99,5-75,100-199,101-102 x 490,499 ops/sec ±0.32% (191 runs sampled)

after:
node benchmarks/parseRange.js
size: 150, bytes=0-100 x 12,073,083 ops/sec ±0.48% (190 runs sampled)
size: 150, bytes=0-4,90-99,5-75,100-199,101-102 x 1,380,042 ops/sec ±0.48% (193 runs sampled)

Checklist

[ ] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[ ] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

@climba03003 There is a regex check so that only ranges with "bytes=" were processed. So if "none" is set, it wont be processed by parseRange.
So we can savely drop the type as we never process the "none"-case?!

There is a regex check so that only ranges with "bytes=" were processed. So if "none" is set, it wont be processed by parseRange.

Yes, the .type is not used in anywhere.
But it is more complete for the function itself to provide the whole view of Range header.

Can I just simply rename it to parseBytesRange?

Can I just simply rename it to parseBytesRange?

Yes

@climba03003
PTAL


prepare.sh

in prepare.sh line 4
zip -r data/lvis_clip_image_embedding.zip data/lvis_clip_image_embedding/*
so i wanna check that the baiduyun link 173 files ==above "lvis_clip_image_embedding.zip"?
and then i need do next:
./tools/dist_train.sh  configs/lvis/prompt_save_train_reuse.py 2 --work-dir workdirs/prompt_save_train
./tools/dist_train.sh  configs/lvis/prompt_save_val.py 2 --work-dir workdirs/prompt_save_val
to ./detpro/data/lvis_clip_image_proposal_embedding/train&val  under ./data/
sorry to disturb you. i can't reproduce the result because of my fault.

in prepare.sh line 4 zip -r data/lvis_clip_image_embedding.zip data/lvis_clip_image_embedding/* so i wanna check that the baiduyun link 173 files ==above "lvis_clip_image_embedding.zip"? and then i need do next: ./tools/dist_train.sh configs/lvis/prompt_save_train_reuse.py 2 --work-dir workdirs/prompt_save_train ./tools/dist_train.sh configs/lvis/prompt_save_val.py 2 --work-dir workdirs/prompt_save_val to ./detpro/data/lvis_clip_image_proposal_embedding/train&val under ./data/ sorry to disturb you. i can't reproduce the result because of my fault.

Yes, you should decompress all the 173 zips which will get about 100000 embeddings  and then compress them into the lvis_clip_image_embedding.zip


px_uploader: Sp2 header to MAVLINK_REBOOT command

thanks! can you check that it actually works with and without protocol splitter, and then merge


feat: use exception wrapper in cli commands

What does this pull request change?
wrap functions in the dmss exception wrapper function to avoid duplicate error handling.
Why is this pull request needed?
Issues related to this change
closes #70

see question posted in https://github.com/equinor/dm-cli/issues/70:
should we use the exception wrapper function if API errors are accepted?


Monitors cpu ressources

New feature: monitoring for CPU
Link to GPU monitoring.
Link to fix Studio
Monitoring CPU hardware
In this PR we add the possibility for the user to monitor the CPU, RAM, and disk during one experiment.
To use this feature you can use it with a simple argument:
from dvclive import Live

with Live(monitor_system=True) as live:
    ...

If you want to use advance features you can specify each parameter this way:
from dvclive import Live
from dvclive.monitor_system import MonitorCPU

with Live(monitor_system=True) as live:
    live.monitor_cpu = MonitorCPU(interval = 0.1, num_samples=15, directories_to_monitor=["/data", "/home"]))

And this is how the editor help should looks like:

If you allow the monitoring of your system, if will track:

system/cpu/count -> number of CPU cores
system/cpu/usage (%) ->  the average usage of the CPUs.
system/cpu/parallelization (%) -> How many CPU cores use more than 20% of their possibilities? It is useful when you're looking to parallelize your code to train your model or process your data faster.
system/ram/usage (%) -> percentage of the RAM used. Useful to increase batch size or data processed at the same time in the RAM.
system/ram/usage (GB) -> RAM used. Useful to increase batch size or data processed at the same time.
system/ram/total (GB) -> Total RAM in your system
system/disk/usage (%) -> Amount of disk used at a given path in %. By default uses "." meaning where the python executor was launched. You can specify the paths you want to monitor. For instance the code example above monitor /data and /home. Data and code often lives in very different paths/volumes, so it is useful for the user to be able to specify its own path. Note that as their can be several paths specified, the full metric name is system/disk/usage (%)/<idx>. For instance it would be system/disk/usage (%)/0 for the /data and system/disk/usage (%)/1 for /home.
system/disk/usage (GB) ->  Amount of disk used at a given path.
system/disk/total (GB)  ->  Amount of total disk storage at a given path.

All the values that can change during an experiment can be saved as plots. Timestamps are automatically recorded with the metrics. Other metrics (that don't change) such as CPU count, RAM total and disk total are saved as metrics but cannot be saved as plots.
I decided to split the usage in % and GB. First, because it is more consistent with the other loggers out there. Second, both are extremely relevant based on which cloud instance you run your experiment. If you only run your experiment on the same hardware, the distinction is not really interesting.
Files generated
The metrics about the CPU are stored with the log_metric function. It means that the .tsv files are stored in the dvclive/plots folder. A specific folder, system, contains all the metrics about the CPU to distinguish them from the user-defined metrics. The metrics are also saved in the dvclive/metrics.json file.
Plot display
Here is what VScode extension looks like:

Here is what Studio looks like:

Note that studio update is a little buggy, but it is fixed in this PR

[x] ❗ I have followed the Contributing to DVCLive guide.
[ ] 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

@AlexandreKempf Sorry for the delay here. For any PR like this where you introduce a new feature, it would be great if you could include a demo of the feature in the PR. Some useful ways to demo it can be:

Record a video via screencast, https://www.loom.com, https://asciinema.org, etc.
Include an example notebook, script, repo, etc.
Write a draft of the docs PR

Once it's merged, you can reuse it by posting it to https://iterativeai.slack.com/archives/C064XEWG2BD

Also note that windows tests are failing

Sorry if I forget this from your previous work on this, but is GPU usage a separate callback you plan to add later?

plots use steps as x by default when we log metrics. Using timestamps makes more sense if available (timestamp=True). It is weird for the monitoring resources to be plotted with steps.

Can we configure these plots to use timestamps as the x-axis? WDYT about putting these into a separate dir like dvclive/plots/system?
I guess it goes beyond the idea of a generic callback system, but seems like a cleaner UX. I'm also unsure whether we need to expose a whole callbacks system to users for this, or whether there's a simpler way for them to enable/disable logging system metrics (even if we use callbacks internally).

it can be nice to have a time flag system to know where we are in training (steps are not very informative). This is very useful to align the hardware resources with specific algorithm parts.

Sorry, I don't follow. How is it different from the previous point?

Thanks for the description and video @AlexandreKempf . It's way easier to review it now and understand.
A few questions, before reviewing the code itself in details:

Why do we need a separate callback? It's a bit confusing to pass a callback into a callback. Is it what other product do? E.g. W&B , neptune, comet? Can we review and summarize how they do this?

@dberenbaum

Can we configure these plots to use timestamps as the x-axis? WDYT about putting these into a separate dir like dvclive/plots/system?
Yeah, that is a cool idea. Initially, I put them into dvclive/plots/metrics/system because I use the log_metric function that naively puts them here. And I tried to change the dvc.yaml to have the system subdirectory to take timestamp as X. But this doesn't work if a parent directory is set to another X (in that case, dvclive/plots/metrics was set to step.

I guess it goes beyond the idea of a generic callback system, but seems like a cleaner UX. I'm also unsure whether we need to expose a whole callbacks system to users for this, or whether there's a simpler way for them to enable/disable logging system metrics (even if we use callbacks internally).
I agree with the UX, and I also find it more modular and easy to extend (with GPU, TPU, pricing for cloud ...). But I agree with you and Ivan, the user doesn't need to know how it works under the hood. And the callback in a callback is not great either. I'll change it to only take a monitor_system  boolean.

Sorry, I don't follow. How is it different from the previous point?

I was thinking of something like this:

@dberenbaum Revert all the changes about timestamp so that we use step instead. We might change it in the future, but for now, it produces this result when we compare two experiments:

Which is not satisfying.
I tried to find a way to set the x-axis as relative to the first timestamp on vega-lite but I couldn't find the right config to make it work.
Also I fixed the lightning issue and made sure it works with the vanilla one (with Live() as live).

I tried to find a way to set the x-axis as relative to the first timestamp on vega-lite but I couldn't find the right config to make it work.

I think we could log the relative timestamp to the tsv file, but I'm fine to make this a follow-up issue and proceed with step for now.

I think we could log the relative timestamp to the tsv file, but I'm fine to make this a follow-up issue and proceed with step for now.

It is sad that is the only way of dealing with it, and that Vega-lite doesn't seem to support that (even with all the transformations they provide). I'll give it a go today.

FYI I changed the name of the metrics so that they are a bit simpler and consistent with the other platforms (W&B, Neptune ...).

I find this roadmap cleaner than trying to hack our way into the solution. What do you think?

Let's create a separate issue and discuss there.
Do we also need a follow-up issue for gpu metrics? Any other items that you consider out of scope but want to open an issue for?
Is it otherwise ready for review?

Yeah, I was waiting for this PR to be reviewed before I started working on GPU monitoring. No need to add the issue for the GPU, It'll be done by tomorrow on another PR. I'll create any relevant issues I can think of and that are missing here.

folks, product question (I think I asked it before, but I'm can't find it and if it was answered before) - do we have to do sub-callbacks / modules? can it be all part of the DVCLive itself? Is it automatic and default behavior in other products?

Codecov Report
Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (b8526e9) 95.55% compared to head (8654aee) 95.07%.
Report is 2 commits behind head on main.

Files
Patch %
Lines

src/dvclive/monitor_system.py
82.66%
9 Missing and 4 partials :warning:

tests/test_monitor_system.py
92.40%
0 Missing and 6 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   95.55%   95.07%   -0.49%
==========================================
  Files          55       57       +2
  Lines        3532     3712     +180
  Branches      314      346      +32
==========================================
+ Hits         3375     3529     +154
- Misses        110      125      +15
- Partials       47       58      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Note there are errors on windows

@AlexandreKempf You can just ping here or request a review again once you feel it's ready. 🙏

@shcheklein @dberenbaum
Please consider this PR also, because it will probably be merge in this branch before we merge to main
https://github.com/iterative/dvclive/pull/785


https://github.com/deepmind/alphafold/blob/main/run_alphafold.py

@google-ospo-team @google-admin @googlebot

- [ ] -


Master

[x] I have followed (at least) the PR section of the contributing guide.

Pull example


Removed lib/tasks/cucumber.rake

Remove the lib/tasks/cucumber.rake script because Cucumber is no longer used in this app.

Coverage decreased (-0.08%) to 52.4% when pulling 1e223e7b10e45ef18a7fca18aed9a45e374473e4 on jhsu802701:pr_remove_cucumber_rake into<PHONE_NUMBER>48a993617335038f7126b36314cecf on minnestar:master.

Thank you.


Add Resource Request: International Network of Open Science & Scholarship Communities

What is the resource called?:
International Network of Open Science & Scholarship Communities
What is the link to the resource?:
https://osc-international.com/
Please provide a short description of the resource (1-3 sentences):
INOSC is an international network of local Open Science & Open Scholarship communities (OSC). OSCs are hubs where academics learn from their peers how to make their workflows more open. More and more academics are joining OSCs, ready to put Open Science to practice.
Which step of the research cycle does the resource belong to?:
Project start
If possible, please provide the exact path where you want this resource to go?:
Open (i.e., everything in the resource is free and open to use)

Added


Fix ordering by File in Unique reports mode

Ordering by File when Unique reports are enabled should give an alphabetical order.
Closes #1198

Doesn't seem to work. The query executed by default when we open a run is this:
ELECT reports.id AS reports_id, reports.bug_id AS reports_bug_id, reports.checker_message AS reports_checker_message, reports.checker_id AS reports_checker_id, reports.severity AS reports_severity, review_statuses.bug_hash AS review_statuses_bug_hash, review_statuses.status AS review_statuses_status, review_statuses.author AS review_statuses_author, review_statuses.message AS review_statuses_message, review_statuses.date AS review_statuses_date, files.filename AS files_filename, files.filepath AS files_filepath
        FROM reports LEFT OUTER JOIN files ON reports.file_id = files.id LEFT OUTER JOIN review_statuses ON review_statuses.bug_hash = reports.bug_id LEFT OUTER JOIN (SELECT anon_2.id AS id
        FROM (SELECT max(reports.id) AS id, max(reports.severity) AS severity
        FROM reports LEFT OUTER JOIN files ON reports.file_id = files.id LEFT OUTER JOIN review_statuses ON review_statuses.bug_hash = reports.bug_id
        WHERE reports.run_id IN (1) GROUP BY reports.bug_id) AS anon_2 ORDER BY anon_2.severity DESC
         LIMIT 500 OFFSET 0) AS anon_1 ON anon_1.id = reports.id
        WHERE anon_1.id IS NOT NULL

This returns the result ordered by reports.id, which is consistent with the output seen on the webpage.
It looks like an ORDER BY in a subtable is broken by the join.


filter returns the wrong field

HiveSource(database, "${table}")
.withColumns("field1", "field2")
.filter("field2", v=> v== "somevalue")
The v there is for field1 for some reason

Must be the with columns breaking it because there's tests around filter.
On 9 March 2016 at 10:33, Stefan<EMAIL_ADDRESS>wrote:

HiveSource(database, "${table}")
.withColumns("field1", "field2")
.filter("field2", v=> v== "somevalue")
The v there is for field1 for some reason
—
Reply to this email directly or view it on GitHub
https://github.com/eel-sdk/eel/issues/132.

Are there case differences between field2 in the hive database and field2
in the filter?
On 9 March 2016 at 10:35, Stephen Samuel (Sam<EMAIL_ADDRESS>wrote:

Must be the with columns breaking it because there's tests around filter.
On 9 March 2016 at 10:33, Stefan<EMAIL_ADDRESS>wrote:

HiveSource(database, "${table}")
.withColumns("field1", "field2")
.filter("field2", v=> v== "somevalue")
The v there is for field1 for some reason
—
Reply to this email directly or view it on GitHub
https://github.com/eel-sdk/eel/issues/132.

Can you do this:
HiveSource(database, "${table}")
.withColumns("field1", "field2")
.foreach( row => println(row))
.filter("field2", v=> v== "somevalue")
And see if the row is respecting the withColumns. I suspect it not be.
On 9 March 2016 at 10:37, Stephen Samuel (Sam<EMAIL_ADDRESS>wrote:

Are there case differences between field2 in the hive database and field2
in the filter?
On 9 March 2016 at 10:35, Stephen Samuel (Sam<EMAIL_ADDRESS>wrote:

Must be the with columns breaking it because there's tests around filter.
On 9 March 2016 at 10:33, Stefan<EMAIL_ADDRESS>wrote:

HiveSource(database, "${table}")
.withColumns("field1", "field2")
.filter("field2", v=> v== "somevalue")
The v there is for field1 for some reason
—
Reply to this email directly or view it on GitHub
https://github.com/eel-sdk/eel/issues/132.

Ok. found the issue. the Frame::filter takes the index out of the schema. However the row (internalrow) respectes the order of the columns defined by withColumns.
all the functions in Frame where outer.schema is used are affected.
option 1: is get the index with once we have the row (the rows has the columns)
option 2: enhance Frame trait to have def columns: Seq[String]

We could just update the schema to be in the same order as the columns specified. Then it should all fall together?

or that as option 3


Migrate Fortis Pipeline to Event Hub

Currently, all fortis events are ingested into queues, which add significant latency to the pipeline. The initial point of entry should be a single event hub where the supported data contract is an unoppinionated and  flexible schema. The other advantage is one can publish sensor data to the Fortis pipeline.

This is no longer necessary given that we're moving all the processing to Spark.


Deprecate and remove inductive ... :=

Description
Today, Lean accepts all of the following:
inductive DogSound
  | woof
  | grr

inductive DogSound :=
  | woof
  | grr

inductive DogSound where
  | woof
  | grr

It seems that the overwhelming majority of declarations use the latter syntax (with where). In the interest of simplifying things, how about we deprecate the first two?
Context
The broad context here is that I'm writing the new reference manual with tooling that can let us know about undocumented tokens. The documentation should be comprehensive and describe what the language does.
Deprecating these two alternate syntaxes, rather than documenting them, would make Lean code more uniform and reduce the language surface area.
I'm not advocating immediate removal - a long deprecation period won't hurt anything - but a warning would be useful.
Impact
Add :+1: to issues you consider important. If others are impacted by this issue, please ask them to add :+1: to it.

Why not enforce the first one and deprecate both := and where for inductive? I would find that more uniform because in a def it is also not allowed, i.e. the following is wrong:
def f : Nat → Nat where
  | 0 => 42
  | (.succ n) => f n

where after def is valid, and is used for defining instances:
def foo : Inhabited Nat where
  default := 0

It looks like mathlib uses no-where and core Lean uses where. It'd be interesting knowing what's most commonly used in the wild if we're deciding by pragmatism.
I don't mind going with where though.

#5533 has a linter for no-where, with an exception for the no-constructor case. There's still the whole test directory to update, which seems to have a few hundred no-where inductive commands.
Do we want to be strict about where? I think it makes sense deprecating :=, but I'm thinking it would be less disruptive if where were to simply be optional.

The where style just seems like waste of space. It never disambiguates anything, right?

The where style just seems like a waste of space. It never disambiguates anything, right?

I don't think it does. But I think the ship sailed long ago on discussing the merits of syntax choices other than by appeal to least disruption.

Note, in lean 3 there was only no-where syntax, so I think your theory doesn't match. I'm pretty sure that when where was introduced core used it across the board, and that's where we got where we are now.

I have hard numbers: 79% of inductives in core use where, 21% use no where, and 0% use :=.
Personally, if we have to deprecate two out of three, I would rather deprecate both := and where. If we wanted a keyword here, with would have been more appropriate. The where keyword is for structure/conjunctive data, and with (like in match) is for disjunctive data.
I'll make another PR that deprecates just :=, which is an easy decision! I'm going to deprecate it for structure as well unless there are any objections. Using := for structure is a Lean-3-ism.

The := variants are now deprecated.
I don't really want to resolve whether where should be required or not at the moment, so what do you think about leaving it in the current state for now @david-christiansen, where where is optional?

I strongly dislike where being optional - this was something that threw me for a loop as a language learner.
When where is omitted on inductive declarations, it behaves identically to as if it were present. When where is omitted on structure declarations, it produces a (valid) structure with zero fields - much different behavior than with the where! I had to ask about this on the Zulip a little while back to figure out just what was going on, because I was expecting inductive and structure declarations to behave relatively similarly to each other (and other constructs using where, like class and instance). I would much rather where be consistently enforced, by a lint or otherwise.


docs: FTL-13046 update contribution guidelines

:tada: This PR is included in version 2.1.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


[stable/aws-s3-proxy]: provide support for serviceAccount annotations

Description
This PR adds support for service account annotations.

Checklist

[x] Title of the PR starts with chart name (e.g. [stable/mychartname])
[x] I have read the contribution instructions, bumped chart version and regenerated the docs
[ ] Github actions are passing

@alekc I can't update your branch on this PR so you need to rebase or merge master into your branch.

@max-rocket-internet I merged the master branch to get it up to speed. Could you start the workflow?

@alekc it's already out of date again as there are many commits to this repo. Normally there is an a button that allows me to update your branch:

But it's missing on this PR, probably because you removed this access or because you've created a PR for a branch that is not in your own account.

weird. If we do not manage to get to the release this time around either feel free to close the pr? Not sure what else can be done.

Also, the aut-merge is correctly enabled, the issue which prevents the merge is that I cannot start the pipelines for checking.

Merged, finally 🙂 Thanks @alekc!


Sony DPT-CP1 page turning issue

Hello,
Not sure I'm the first guy encounter this issue: I managed root the device after I received from B&H(the original firmware version of the device is 1.4.xxx I remember). how ever, one issue very bothered me, every time I turn page(regardless using KOREADER or official DigitalApp app), I can hear very light sound like "zhi...."(very hard to make descriptions, you can image just like shutter sound during photo capturing with digital camera). no any sound heard if just click any button. do you think this could be device defect?
I tried to factory reset the device but failed, still didn't get any clue.
Thanks!

Hi robertsjchen,
I can confirm this light noise “issue” that you described also exists on my device.
But dont worry, I'm sure it does NOT result from the root operation. If you put the unrooted device very close to your ear (I did this test yesterday when my DPT-CP1 remained unrooted), you hear the sound as well.
Another strange thing I found is: this "zhi....“ sound is more perceptible when turing page under landscape mode using KOREADER. Luckily most time I keep my device in portrate mode.

Thanks for your testing, Jory!
then confirmed is a common "issue" and not caused by any root operating.


Inactive tension_only member still takes load

Describe the bug
Inactive tension_only member still takes load
To Reproduce
See this self-contained example.
Cantilever stayed with cable
All members are two-force
In the amended case, an additional cable stay is added to the opposite side, which is supposed to have no effect.

# Create a new finite element model
braced_frame = FEModel3D()
braced_frame.add_node('N1', 0, 0, 0)
braced_frame.add_node('N2', 100, 0, 0)
braced_frame.add_node('N3', 0, 10, 0)

E = 29000 # ksi
G = 11400 # ksi
nu = 0.3  # Poisson's ratio
rho = 0.490/12**2  # Density (kci)
braced_frame.add_material('Steel', E, G, nu, rho)

Iy = 3 # in^4
Iz = 3 # in^4
J = 0.0438 # in^4
A = 1.94 # in^2

braced_frame.add_member('push', 'N1', 'N2', 'Steel', Iy, Iz, J, A)
braced_frame.add_member('pullup', 'N3', 'N2', 'Steel', Iy, Iz, J, A, tension_only=True)
braced_frame.def_releases('pullup', Ryi=True, Rzi=True, Ryj=True, Rzj=True)
braced_frame.def_releases('push', Ryi=True, Rzi=True, Ryj=True, Rzj=True)

braced_frame.def_support('N2', *[False]*2, *[True]*4)
braced_frame.def_support('N1', *[True]*6)
braced_frame.def_support('N3', *[True]*6)
braced_frame.add_node_load('N2', 'FY', -10)

braced_frame.analyze()
print('pullup', braced_frame.Members['pullup'].max_axial())
print('push',braced_frame.Members['push'].max_axial())
print('==========================')

braced_frame.add_node('N4', 0, -10, 0)
braced_frame.add_member('pulldown', 'N4', 'N2', 'Steel', Iy, Iz, J, A, tension_only=True)
braced_frame.def_releases('pulldown', Ryi=True, Rzi=True, Ryj=True, Rzj=True)
braced_frame.def_support('N4', *[True]*6)

braced_frame.analyze()
print('pullup',braced_frame.Members['pullup'].max_axial())
print('push',braced_frame.Members['push'].max_axial())

print('pulldown',braced_frame.Members['pulldown'].max_axial())
print('pulldown',braced_frame.Members['pulldown'].active)

Output (both latest main as well latest pypi release)
pullup -100.49875621120889
push 99.99999999999997
==========================
pullup -50.24937810560445
push 99.99999999999997
pulldown 50.24937810560445
pulldown {'Combo 1': False}

Obviously the lower "pulldown" cable is (incorrectly) sharing the load as a compressive member, even though it is (correctly) marked as inactive, halving the load the "pullup" cable takes.
Expected behavior
The force in "pullup" cable in the amended should remain the same.

Thanks for the reply - the problem is not really the inactive member though, because it is trivial to check if it is active first (though some doc may help).
Note that the other cable (N3-N2) (always active) gets its load halved, as if the slack cable (N4-N2) takes away half the load by acting as a compression member. It is the load on the active cable that is a problem.

I've reviewed the code and this is definitely a bug. This shouldn't be too hard to isolate and resolve. I'll make this my top priority for Pynite.

I'm closing in on this issue. It appears the global nodal displacements are correct, and the stiffness matrix is correct, but the member internal forces are still storing results from the prior iteration before the T/C member deactivates. I should have this resolved soon.

Thanks. Yes I think the displacements are correct (being identical in both cases) as well - I should have checked that earlier!

This issue has been resolved in the latest release. It was a bug. I will flag this issue as a bug for documentation.


local worker --inline-limit option is blocking --include cargo maelstrom option

Both --inline-limit and --include have the same short flag -i

Fixed in 63c0a1a4c7e2772a5637641ba7df0902322d0f97


Various forward rules improvements

This is all extracted from my lab course experiment, I can try to synthesize test cases if you want. The last commit is less clear-cut, it could be argued that it should at least be restricted to reducible transparency (though Lean itself usually applies it at default afaik).

Thank you very much!


How to filter by host

Hi,
I would like to set a specific configuration for my API subdomain (api.domain.com) but I can't set it up with paths:
my actual configuration :
nelmio_cors:
  defaults:
    allow_credentials: true
    origin_regex: true
    allow_origin: ['*','*/*']
    allow_methods: ['GET', 'PUT']
    allow_headers: ['Content-Type', 'Authorization']
    max_age: 3600
  paths:
    '^/': ~

This is not working :
...
paths:
  'api\.%base_host%':

Thanks for your help

hi @asuri0n, did you find a way to fix your issue?


Merge into dev

Coverage decreased (-0.1%) to 54.692% when pulling 7d5798549bf39e878b6c6006f209c9d323dfd5ea on dev-new-ui into 29f3e609e7b779820aa91a6366775978156306e1 on dev.


Hosted website and updated readme accordingly

I hosted the website on vercel and then updated the readme.
#2

Thanks for showing interest. I am closing this PR.


Error: Cannot find module 'babel-runtime/regenerator' since 6.0.0-beta.9

➜  website git:(master) ✗ react-static start
module.js:549
throw err;
^
Error: Cannot find module 'babel-runtime/regenerator'
at Function.Module._resolveFilename (module.js:547:15)
at Function.Module._load (module.js:474:25)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object. (/usr/local/lib/node_modules/react-static/lib/commands/start.js:8:43)
at Module._compile (module.js:652:30)
at Module._compile (/usr/local/lib/node_modules/react-static/node_modules/pirates/lib/index.js:83:24)
at Module._extensions..js (module.js:663:10)
at Object.newLoader [as .js] (/usr/local/lib/node_modules/react-static/node_modules/pirates/lib/index.js:88:7)
at Module.load (module.js:565:32)
Environment

react-static -v: 6.0.0-beta.9
node -v: v8.11.1
yarn --version or npm -v: 1.7.0
Operating system: MacOS

Steps to Reproduce the problem
Base your steps off of any freshly installed react-static template!

npm install -g<EMAIL_ADDRESS>(latest also)
react-static start
profit!

Duplicate #684 and #670. Fixed in master.

I can confirm it's broken in<EMAIL_ADDRESS>It should have been fixed in<EMAIL_ADDRESS>or<EMAIL_ADDRESS>but I think something went wrong with the npm release. cc @tannerlinsley
If I use master - it works.

Apparently swimmer is being pulled in which doesn't use babel 7 yet. It looks like it works with master (instead of the npm package) as the dev dependency still pull in the old babel-runtime via jest.
@tannerlinsley If you don't mind, I would PR the swimmer repo.

I don't think this is fixed since there hasn't been any new releases since this issue was filed.


Support package patterns that include ...

Gobin seems like a neat way to install my go tooling in a version wise controlled way, and at the same time keeping all dependencies out from $GOPATH.
One of the tools I use is @dominikh neat go tools, which unfortunately doesn't let themselves be installed using gobin:
$ gobin honnef.co/go/tools/...
failed to run go get -d honnef.co/go/tools/...: exit status 1
go: finding honnef.co/go/tools/... latest
go: finding honnef.co/go/tools latest
go get honnef.co/go/tools/...: no matching versions for query "latest"

Hm, did tagged version have to be in semver? Is that why...

We can now try out https://go-review.googlesource.com/c/go/+/171138 on tip.


build: Use target_compile_options

Description
When using pkgconfig the value of <NAME>_CFLAGS_OTHER can contain compiler flags along with preprocessor definitions. If there is a compiler flag and its passed to target_compile_definitions then it will be treated as if it is a preprocessor definition.
Found a case where a statically compiled LibRaw with a statically compiled Little-CMS caused LibRaw_DEFINITIONS to have -pthread in its listing which was passed to the compiler as a definition, -D-pthread. This caused a build failure with auto-moc.
Add an additional parameter for the add_oiio_plugin macro to take COMPILE_OPTIONS and pass those to target_compile_options which can differentiate between compiler flags and preprocessor definitions. Pass LibRaw_DEFINITIONS to the CMake macro to prevent the above error.
Tests
Issue found while updating Little-CMS in https://github.com/microsoft/vcpkg/pull/42187 and the change fixes the build issue found there. This is an attempt to upstream it so the issue is fixed.
Checklist:

[X] I have read the contribution guidelines.
[X] I have updated the documentation, if applicable. (Check if there is no
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
[X] I have ensured that the change is tested somewhere in the testsuite
(adding new test cases if necessary).
[X] If I added or modified a C++ API call, I have also amended the
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
[X] My code follows the prevailing code style of this project. If I haven't
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.

This looks reasonable, thanks for the fix.
Can you please affix the DCO to your commit and re-push? Thanks.

This looks reasonable, thanks for the fix. Can you please affix the DCO to your commit and re-push? Thanks.

Done. Thanks for the speedy review!

Ok looks like everything is happy @lgritz

I'll backport this to the next 3.0 and 2.5 patches.

Thanks @lgritz ! I will update the vcpkg port once you get it on the 3.0 branch. You might want to look at https://github.com/microsoft/vcpkg/tree/master/ports/openimageio to see if there are any other patches that might be of interest to the project there.

@donny-dont
Quick glance:

fix-dependencies.patch : I'm not sure I understand why those find_dependency calls are needed in the exported cmake config if those packages' types or headers aren't mentioned in our public API headers. I think on Linux/MacOS, .so dependencies are transitively understood by the linker, and .a dependencies will get folded into our library. So is this a Windows-specific need? I'm also not sure exactly why the other changes here are needed.
fix-openexr-target-missing.patch : Same as above, I'm not sure if this is still needed, since OIIO doesn't use any OpenEXR types in its public APIs.
fix-openimageio_include_dir.patch : maybe? I'm not exactly sure I understand what that does. Did we just get the path wrong? If we never noticed the problem before, does it simply mean that the line is not needed at all?
imath-version-guard.patch : irrelevant now that OIIO no longer support Imath 2.x.

It's hard to evaluate without understanding exactly why each of these change were made. But in general, any of them that are still relevant and necessary, I think we'd be happy to have them "upstreamed". It seems more maintainable for our build scripts to work for vcpkg out of the box, even if they have an occasional "if vcpkg" logic somewhere, than to have a lot of patches added on your end that we could break at any time without really being aware that they exist.
I'd prefer that everything be attempted to be upstreamed, and only have vcpkg-side patches for the few things that for whatever reason we aren't able to accept.

@lgritz In general we try to avoid patching anything that would result in 'putting words in one's mouth'; build system changes that adapt how dependencies are found to the way they are deployed in vcpkg we will often just take, but if there's something that would be very visible to users or touches sources meaningfully we're going to want upstream to at least look first.
https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#patching

fix-dependencies.patch : I'm not sure I understand why those find_dependency calls are needed in the exported cmake config if those packages' types or headers aren't mentioned in our public API headers. I think on Linux/MacOS, .so dependencies are transitively understood by the linker, and .a dependencies will get folded into our library. So is this a Windows-specific need? I'm also not sure exactly why the other changes here are needed.
fix-openexr-target-missing.patch : Same as above, I'm not sure if this is still needed, since OIIO doesn't use any OpenEXR types in its public APIs.

I don't know about whether things get 'folded into' your libraries, but that certainly isn't how it normally works for .as or static .libs. (I haven't dug into whether openimageio is doing something different or special to merge the dependent .as together. If it is doing that, we would probably have to patch that out in vcpkg because vcpkg customers might want to choose different versions of those dependencies or similar, but we wouldn't bother you trying to upstream that as we would understand that to be a specific-to-vcpkg problem)
CMake will want to see any targets you've target_link_libraries'd when your exported targets are loaded even if that results in no actual compiler or linker command line changes.
CMake bindings can export things like requirements on compiler switches unrelated to what would end up on your link line.

fix-openimageio_include_dir.patch : maybe? I'm not exactly sure I understand what that does. Did we just get the path wrong? If we never noticed the problem before, does it simply mean that the line is not needed at all?

Hmmm this should have probably been submitted upstream. I don't know exactly why it was added either in https://github.com/microsoft/vcpkg/pull/27766/files .

imath-version-guard.patch : irrelevant now that OIIO no longer support Imath 2.x.

I'm not sure I understand; as far as I can tell that OIIO no longer supports Imath 2.x is exactly why this patch is here, to warn people that that combination will explode.


docker/bash.sh: lookup docker image in Jenkinsfile

This PR makes it possible to type
docker/bash.sh ci_cpu tests/scripts/task_config_build_cpu.sh
and the same version of ci_cpu as is used in Jenkins will be
used to run the command.

cc @leandron @comaniac can you help to look at this PR?


The exists method lacks permission check

Alluxio Version:
master.
Describe the bug
I tested the exists method of HDFS and Alluxio. HDFS need to have execution permission on the parent folder and Alluxio has no permission to check.
To Reproduce
HDFS
test code:
public static void printStatus(FileSystem fileSystem, String path) {
    try {
        System.out.println(fileSystem.exists(new Path("/a/b/c")));
    } catch (Exception e) {
        e.printStackTrace();
    }
}

without parent permission:

drwx------   - alluxio staff          0 2022-08-04 15:41 /a/b

output:
Caused by: org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.security.AccessControlException): Permission denied: user=hdfs, access=EXECUTE, inode="/a/b/c":hdfs:staff:drwx------

with parent permission:

drwx--x--x   - alluxio staff          0 2022-08-04 15:41 /a/b

output:
true

Alluxio
test code:
public static void exists() throws Exception {
   FileSystem fs = getFileSystem();
   System.out.println(fs.exists(new AlluxioURI("/a/b/c")));
}

without parent permission:

drwx------  alluxio    staff                        2       PERSISTED 08-31-2022 09:05:59:745  DIR /a/b

output:
true

Expected behavior
The exists method requires permission check.
Urgency
Urgency.
Are you planning to fix it
Yes.

Wondering how this bug is discovered, in what scenario?


Print ESP-IDF and arduino-esp32 core versions to the boot file

This pull request prints the ESP-IDF version and arduino-esp32 core versions to the boot text file.
@tyeth  Would it be possible to double-check this works and tests OK? I used a QT Py ESP32-S2.
Resolves: https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/issues/597

Looks good, rev tft s3:
Adafruit.io WipperSnapper
Firmware Version: 1.0.0-beta.88
Board ID: feather-esp32s3-reverse-tft
MAC Address: 70:04:1D:CD:F1:10
ESP-IDF Version: v5.1.4-586-gb6b4727c58-dirty
ESP32 Core Version: 3.0.4
ERROR: Invalid IO credentials in secrets.json! TO FIX: Please change io_username and io_key to match your Adafruit IO credentials!

@tyeth  Fixed the typo, requesting a re-review/approval prior to merging.


feat: remove dropdown in favour of Accessible one

Remove dropdown from package in favour of New dropdown
Signed-off-by: Jordan Hall<EMAIL_ADDRESS>

My thought is the same as my comment on the LG Dashboard PR, we've now got 2 separate packages with components,

Shared that thought. however, they no way to bring it in without reexporting the same component :/ Any ideas on that would be great


VUE CLI UI support VS Code as default editor

What problem does this feature solve?
when clicking on the "open in editor" button in the UI, should allow configuring which editor we want to open. For example, Sublime, VS Code, Atom
What does the proposed API look like?
Add a configuration button in the UI to allow setting of the default editor

Found the solution

npm install --save-dev launch-editor-middleware

create vue.config.js

paste the following code

const openInEditor = require("launch-editor-middleware");

module.exports = {
  configureWebpack: {
    devServer: {
      before(app) {
        app.use("/__open-in-editor", openInEditor("code"));
      }
    }
  }
};

references:

https://cli.vuejs.org/guide/webpack.html#simple-configuration

https://github.com/vuejs/vue-devtools/blob/master/docs/open-in-editor.md

https://github.com/yyx990803/launch-editor

You can also just set EDITOR env variable to code

How can it be set for a users machine?

Could this be set in the ~/.vuerc ?
The use case is for users who want to set it and forget it, for their computer

I found that if I run EDITOR=code vue ui and then open a project in my editor via the UI, it opens it in sublime if it is open. If I close sublime, it will open it in code.

This is how launch-editor works, maybe open an issue here if you want the env var to have priority over running processes.

@johnpapa Did you ever get this working?  I have been trying but can't find a working solution?
I have defined the EDITOR variable and am able to properly view it

The value is wrong, it should be the name of the VS Code executable, code on Linux

@akryum after I posted this message, I realized the value was wrong, so I chanced to code but still not able to get it working.

Did you try restarting vue ui in a new terminal, logout/login again or restarting the whole computer?

Solution for MacOS:

Install VS Code as per this page:https://vscode-eastus.azurewebsites.net/docs/setup/mac (ensure you setup "launching from the command line")
Add the EDITOR env variable to ~/.bash_profile something like this:
EDITOR=code
export EDITOR
Test your settings by opening a new Terminal window and running:
printenv EDITOR
Note: When Terminal.app opens a new window, it will run .bash_profile. Not, as users familiar with other Unix systems would expect, .bashrc.

In Windows 10: add
EDITOR=code
in *.env file

cd ~ in .zshrc file
export EDITOR=code

set the env variable "EDITOR=code"

Setting editor to code didn't help in my case:

Doesn't work for me either
I did
export EDITOR=cursor
echo $EDITOR
> cursor

But when clicking a code link in the UI, it opens vs code

Brute force fixed it by doing
which code
> /usr/bin/code
rm -rf /usr/bin/code
which cursor
> /tmp/.mount_cursorCzRS0Z/cursor
sudo ln -s /tmp/.mount_cursorCzRS0Z/cursor /usr/bin/code

Btw don't do this if you don't know how to fix your system after


Add EEP A5-02-01 support by implementing another EnOcean device.

Breaking Change:
None
Description:
Only events are emitted, since the sensor doesn't have a state.
The type is automatically selected depending on the configured device class.
Packets are checked if they really origin from a compatible device
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
...
device_type: occupancy

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[ ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:
it doesn't
If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @joshwapohlmann,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Hi @joshwapohlmann,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Please review if these changes are of any interest before I invest more time.

This PR seems to have gone stale. Closing it.


Feat/react dApp demo

Description:
This pull request includes a ReactJs project that demonstrates the use of DAppConnetor.
Related issue(s):
Fixes #
Notes for reviewer:
This pull request includes scripts for building and running the project in a similar way as the current example project.
npm run build:demos

npm run dev:demos

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Hi @franfernandez20 Just checking in on this PR. Given the updates since the PR was opened, should we revisit this PR?

closing as outdated. thanks for the contribution @franfernandez20


Use git log --all by default

To replicate the behavior of hg log, I believe that the default should be git log --all instead of just logging from HEAD. Not sure all the implications of this yet, so waiting until the dust clears from 0.7.

I would like to triage this for 1.0.


Cygdb not working with recent virtualenvs

In recent Python virtualenvs, there is no activate_this.py file.
Cygdb therefore fails to load:
Reading symbols from python3-dbg...done.
gdb command file: Activating virtualenv: /home/myuser/.virtualenvs/myenv; path_to_activate_this_py: /home/myuser/.virtualenvs/myenv/bin/activate_this.py
Traceback (most recent call last):
  File "<string>", line 8, in <module>
FileNotFoundError: [Errno 2] Aucun fichier ou dossier de ce type: '/home/myuser/.virtualenvs/myenv/bin/activate_this.py'
/tmp/tmpohzn6ela:19: Error in sourced command file:
Error while executing Python code.

Is cydbg supported with python3-dbg at all? If so, the documentation is outdated http://docs.cython.org/en/latest/src/userguide/debugging.html Not sure if that's the cause of this issue though.

To do: find the right way to activate a Py3 venv and do that in Cygdb.py.

Not sure if that's the cause of this issue though.

Answering my old self: this happens for virtual environments created with Python 3 venv or pyenv, see https://stackoverflow.com/a/33637378/554319.

For the moment, testing this horrible hack:
            if virtualenv:
                # path_to_activate_this_py = os.path.join(virtualenv, 'bin', 'activate_this.py')
                # print("gdb command file: Activating virtualenv: %s; path_to_activate_this_py: %s" % (
                #     virtualenv, path_to_activate_this_py))
                # with open(path_to_activate_this_py) as f:
                #     exec(f.read(), dict(__file__=path_to_activate_this_py))
                import sys
                sys.path.insert(0, os.path.join(virtualenv, "lib", "python3.7", "site-packages"))

PR welcome that fixes this. Even one that resolves it only for Py3.

Recently ran into this issue setting up cygdb in an existing environment that uses venv extensively. What's required to push through the fix? The last comments on the PR date from last September.
If some help is needed, I can jump in.


feat: Initialize notebook to packages tutorial

Overview
This PR sets up the general notebook to packages tutorial for the 2024 Hackweek

@jomey, @scottyhq, or @JessicaS11 Could you please enable workflow so I can see the preview, thanks! 😄

Anyone on the organizing team should in theory be able to add the 'preview' label that kicks off the workflow

I don't think I'm part of this org

I don't think I'm part of this org

Invite sent


Finished Working on Navbar

Finished working on the Navbar, started working on the landing page

Finished working on the Navbar, started working on the landing page

Great, please allow me to work on the footer. I started, am almost done


[KeyVault] Certificate Attributes should be read-only

https://github.com/Azure/azure-rest-api-specs/blob/master/keyvault/2016-10-01/swagger/keyvault.json#L2056
Currently, only created and updated are marked as read-only for certificate attributes. However, expires and not-before are also read only, but not marked as such.

@pomortaz feel free to reassign, if you're not the right person from Key Vault team to help fix this issue.

@veronicagg I don't have permission to assign issues. Please assign this to @RandalliLama


Collisions do not recalculate when updating collision_layer

Godot version:
3.2.2-rc3
OS/device including version:
Windows 10 x64
Issue description:
I have an Area2D with a large collision shape. I instantiate a KinematicBody2D with collision_layer = 0 and place it within the Area2D's collision radius. Inside of the _ready() function for the body, it sets collision_layer = 1. Previously this would cause the body_entered signal to be emitted on the Area2D, but now the signal is not emitted. Note that if you move the body out of collision radius with the Area2D and then back into the radius, the signal will be emitted as expected.
Steps to reproduce:
Simply run the attached project. In 3.2.1 you will see
Body detected: Body
Body detected: @Body@2
Body detected: @Body@3
Body detected: @Body@4

There is no output in 3.2.2-rc3
Under the hood this is simply instantiating bodies with the parameters mentioned above on a 1 second timer and printing in the body_entered signal handler.
Minimal reproduction project:
BugDemo.zip

I suppose it's debatable whether this is a bug or a fix. Consider the scenario where the CollisionObjects are both PhysicsBodies changing the collision/mask layer when they're overlapping so they now interact would create a sudden, huge, unrealistc separation impulse. Others have this problem when changing the position of a KinematicBody directly so that it overlaps with a RigidBody. It's also why it's so important to place Bodies away from other Bodies when creating them.
Finally, it's worth noting that this only happens when changing the collision/mask layer combination. In the example project, if the Bodies being added already have the required collision layer, the signal does get triggered.

I agree that this is not obviously wrong behavior at first glance, however I do think it violates the principle of least surprise. If I put two physics bodies overlapping, I expect them to be repulsed. If I put a physics body inside of an Area2D, I expect it to be detected. If I change the collision layer/mask of a body, I would expect one of two things to happen:

The simulation is updated to account for the new layer/mask and the next frame will have the appropriate enter/leave signals
Godot throws an exception saying that you cannot change the layer/mask

What I don't expect is that the overlapping bodies completely fail to detect each other unless they move out of each others' radius and then back in. If changing the collision layer/mask is not supported anymore, that's fine. I can find a way to hack around it. But if it is still supported, it probably shouldn't work like this.

Interestingly, even in v3.2.1, if changing the collision layer is delayed it doesn't work either. I changed the Body.gd to this:
extends KinematicBody2D

var pressed = false

func _input(event):
	if !pressed and event.is_action_pressed("ui_accept"):
		collision_layer = 1
		print("Changed " + name + "'s collision layer!")

Which produces the following output when a ui_accept key is pressed:
Changed @Body@4's collision layer!
Changed @Body@3's collision layer!
Changed @Body@2's collision layer!
Changed Body's collision layer!

No signals are triggered either.
So this problem is bigger than it just not working when changing it in _ready() in v3.2.2.rc3.


RNAseq: why is outSAMmapqUnique = 50

Should be 60, right? See also https://www.biostars.org/p/178387/
Pointed out by Teck Por

TopHat sets the unique mapping quality value as 50
compatibility between STAR bam with downstream analysis like cufflinks ???
https://sequencing.qcfail.com/articles/mapq-values-are-really-useful-but-their-implementation-is-a-mess/

can use either 50 or 60 make no difference.
http://gatkforums.broadinstitute.org/gatk/discussion/4285/documentation-error-in-rnaseq-workflow?


Histogram implementation

Implement histogram package.

This PR https://github.com/pingcap/tikv-client-lib-java/pull/67 will address this issue.


adi_update_boot points to old releases

http://swdownloads.analog.com/cse/fpga_sd/latest_boot.txt
still seems to point to 2017 release?

Yeah this is rather unmaintained. If we don't want to maintain this we should remove it.

I will call you - hopefully there is someone we can assign to updating this.

The script was updated to point to latest release.


Set Content-Length header in requests

Some endpoints, such as the /statuses/filter.json streaming endpoint,
will return a "412 Precondition Failed" error if the content length
isn't specified in the request.

Thank you!


python311Packages.yaramod: 3.20.1 -> 3.20.2

Diff: https://github.com/avast/yaramod/compare/refs/tags/v3.20.1...v3.20.2
Changelog: https://github.com/avast/yaramod/blob/v3.20.2/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 256391 run on x86_64-linux 1

4 packages built:

python310Packages.yaramod
python310Packages.yaramod.dist
python311Packages.yaramod
python311Packages.yaramod.dist


Custom User test

Adds CustomUser schema and new SchemaTest to validate translation of data from provider struct to user struct
I have also implemented a couple of tests for demonstration purposes (only):

To show the redirection I'm experiencing when there's a general error (after trying to create a user); and
A test to demonstrate what I'd expect if issue #90 is considered relevant

Let me know if you think the demo tests aren't relevant and I'll remove them! Let me know if you'd prefer the code to be arranged in a different way

Thanks!
In this case you're testing logic written in test so it doesn't make sense to have them. However, I think it would be really good to have as a guide on https://powauth.com/guides.
I usually put unit tests in the guides like this: https://powauth.com/guides/2019-09-14-password-breach-lookup-and-other-password-validation-rules.html#unit-tests
Would you be interested in writing up a guide for this?

No problem. I'll have a crack!


Build Step - Login To ACR Failed

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Run deploy.yml  All steps before this step succeeded.

Any log messages given by the failure

Expected/desired behavior

OS and Version?

Windows 10
LoginToACR-Failed.zip

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Same issue here. The error I'm getting at the LoginToACR step is:
parse error: Invalid numeric literal at line 1, column 8
Error: Process completed with exit code 4.

Not sure if it is the same as you all but I got an error in the following step  Deploy Container Apps although the docker login command seems successful.
ERROR: Failed to retrieve credentials for container registry. Please provide the registry username and password

Not sure if it is the same as you all but I got an error in the following step Deploy Container Apps although the docker login command seems successful.
ERROR: Failed to retrieve credentials for container registry. Please provide the registry username and password

Not actually even getting that far.  The command just before the docker login is what is failing for me.
RE:  refresh_token=$(curl https://${{ env.RESOURCE_GROUP_NAME }}acr.azurecr.io/oauth2/exchange -v -d "grant_type=access_token&service=${{ env.RESOURCE_GROUP_NAME }}acr.azurecr.io&access_token=$access_token" | jq -r .refresh_token
I believe the issue is related to the pipe "|jq -r .refresh_token"  If I run that command above without the pipe to the "jq" command then I'll get the error you described.

Same issue here. The error I'm getting at the LoginToACR step is:
parse error: Invalid numeric literal at line 1, column 8 Error: Process completed with exit code 4.

Yep, that's exactly the error I got.


StrongSwan/LibreSwan support

Hi there! Cool project, thanks! I made something similar but yours is better :)
I was wondering, if you would be opposed to adding a few kernel modules, needed for IPsec.
The following kernel modules would need adding:

kmod-ip6-vti
kmod-ipsec6
kmod-ipt-ipsec
kmod-ip-vti
kmod-iptunnel4
kmod-ipsec4
kmod-xfrm-interface

I'll happily make a PR to do this - just wanting to check if it will be accepted if I do so!

Sounds legit to me to be added in the full release, but only adding kernel modules will probably not be enough. Instead I could add those packages :

libreswan : will automatically add the required kernel deps
strongswan : seems heavy but modular so I will pick a subset of all available modules

Sounds good! I'll make a PR.

I added libreswan (and dependencies). Build is in progress.
Regarding strongswan, it cannot be built-in at the same time as libreswan so I made a choice because there are much less dependencies.

Thanks - package is showing up, I will test it out over the next few days. Happy holidays!


pub get nor running due to error in pubspec.lock file

pub get not working, showing some error in pubspec.lock file

Delete your pubspec.lock file and try running it.
It should recreate a pubspec.lock if it does not find one.


Updates to property object are not being updated

In the below project you can edit the right-hand values of the items. This should update the values in the view part as well, but it does not.
It's uncertain if this is a problem with using ux:Property, or so other defect.
Project: https://github.com/mortoray/fork-sandbox/tree/master/Nov2017/ItemListing

The alternative to this would be using a Model in the Each, which we are disallowing now:
			<Each Items="{items}">
				<MyItem Model='MyItem({})'/>
			</Each>

@sebbert I think I recall you mentioning that we only support on Model per app right now? (I might be totally wrong)

@nekronos That wasn't a restriction that existed before. And I've always assumed that components will have their own independent Model's. We even recognize the need for them in https://github.com/fusetools/fuselibs-public/issues/563
Put another way, if we don't have a way to make components with Model then we won't be able to get rid of Observable, and will have an incomplete state system.