Fail for ejc-sql

UNDERCOVER: error while covering /home/travis/build/kostafey/ejc-sql/ejc-sql.el
UNDERCOVER: please open a new issue at https://github.com/sviridov/undercover.el/issues

Here is a source:
https://github.com/kostafey/ejc-sql/blob/new-cache/ejc-sql.el
Can I provide some more info for debug?

Hi @kostafey, thanks for the report. I will investigate it a bit later.
Yes, you can provide additional information by doing following:

Go to ejc-sql.el file in Emacs
Run M-x edebug-all-defs
Run M-x eval-buffer
At this point you should be able to see exact place where error happens

Ok, it's my mistake. Here &optional is redundant:
(cl-defun my-fn (var &optional &key other-vars...

This is sufficient:
(cl-defun my-fn (var &key other-vars...

Thank you.


Support --fix and fix-all assist

fixes #161
https://github.com/invertase/dart_custom_lint/assets/20165741/b6cdd917-d8b3-4c28-988c-5e93822466e0

Needs testing.
Especially with regards to:

fixes emitting their fixes to a different file
multiple fixes overwriting the same offset (likely unsupported)
lints with no fixes
lints with multiple fixes
lints with fixes emitting multiple ChangeBuilders
--fix should not overwrite // ignore and // expect_lint
fix-all should not overwrite // ignore and // expect_lint


Make the parser options configurable

The RazorParserOptions were only configurable via an internal interface
and an extension method on the builder. This isn't suitable for VS because
we need to be able to update the configuration while the editor is open,
without creating a new engine.

565dd309575d3ed22dab545fd454c39cff4da7af


plot2d can't set a specified cmap

when I finish a workflow and I want to plot my GRADIENT_01 with a specified cmap, I use the following command:
$ seisflows plot2d GRADIENT_01 vp_kernel -c seismic
I get the error message:
Traceback (most recent call last):
File "/home/zhaox/anaconda3/envs/py311/bin/seisflows", line 8, in <module>
sys.exit(main())
^^^^^^
File "/home/zhaox/seisflows-master/seisflows/seisflows.py", line 1396, in main
sf()
File "/home/zhaox/seisflows-master/seisflows/seisflows.py", line 447, in call
getattr(self, self._args.command)(**vars(self._args))
File "/home/zhaox/seisflows-master/seisflows/seisflows.py", line 1118, in plot2d
plot_model.plot2d(parameter=parameter, cmap=cmap, show=True,
File "/home/zhaox/seisflows-master/seisflows/tools/model.py", line 585, in plot2d
zero_midpoint=zero_midpoint)
^^^^^^^^^^^^^
UnboundLocalError: cannot access local variable 'zero_midpoint' where it is not associated with a value
It is because if I set the value of cmap, then the zero_midpoint  will not be assigned a value.
I think it is easy to fix. Thx.

Hi @bzdzdxb, thanks for raising this issue, glad to see the plotter is being used! I will give this a look this week and get back to you!


Use JSON from the test context, not the parent context.

Summary
See https://github.com/facebook/jest/issues/1822#issuecomment-263717270. For some reason this didn't work previously but now it does and it is great!
cc @kentcdodds who also had trouble with this.
Test plan
jest

This is wonderful! Thank you!


Documentation

Add documentation and example page. Domain needs bikeshedding. fresh.dev would be awesome, but very expensive.

@lucacasonato Wouldn't it be nice if we could write Wiki pages for the documentation? If yes, I would like to contribute.


the background view is turn to white

when i present a alert, the background is white , and i did not set the controller's backgrund color
liek this :

It looks like modalPresentationStyle of the alert controller was set to incorrect value (it should be UIModalPresentationCustom). Also, notice that the background color of the content controller should be explicitly set to UIColor.clear.

It looks like modalPresentationStyle of the alert controller was set to incorrect value (it should be UIModalPresentationCustom). Also, notice that the background color of the content controller should be explicitly set to UIColor.clear.

here is my code:

Strangely enough, when I was debugging this APP with the cable, it works fine.
but when i did not use the cable, and run this app, the background view is turn to white.

The usage of DWAlertController looks good. Btw, you don't need to set modalPresentationStyle at all neither on your content controller (vc) nor alert itself. All appearance and transitions are managed by DWAlertController class.
Please check the Example app if you have issues on your device with any of the custom alerts there. I would suggest adding your CMDataSetAlertController to the Example app and check if you still have those background color issues.

The usage of DWAlertController looks good. Btw, you don't need to set modalPresentationStyle at all neither on your content controller (vc) nor alert itself. All appearance and transitions are managed by DWAlertController class.
Please check the Example app if you have issues on your device with any of the custom alerts there. I would suggest adding your CMDataSetAlertController to the Example app and check if you still have those background color issues.

thanks man，I thought again，and i I found there a category in my project, like this:

this categoty reload the UIModalPresentationStyle, that's the problem!
Anyway, thanks man!


Getting "resource name may not be empty" when installing with third_party/istio-stable/istio-minimal.yaml

I'm getting an error "resource name may not be empty" when installing with third_party/istio-stable/istio-minimal.yaml.
kubectl apply -f "https://raw.githubusercontent.com/knative-sandbox/net-istio/master/third_party/istio-stable/istio-minimal.yaml"
error: error when retrieving current configuration of:
Resource: "install.istio.io/v1alpha1, Resource=istiooperators", GroupVersionKind: "install.istio.io/v1alpha1, Kind=IstioOperator"
Name: "", Namespace: "default"
Object: &{map["kind":"IstioOperator" "spec":map["addonComponents":map["pilot":map["enabled":%!q(bool=true)] "prometheus":map["enabled":%!q(bool=false)]] "components":map["ingressGateways":[map["enabled":%!q(bool=true) "name":"istio-ingressgateway"] map["enabled":%!q(bool=true) "k8s":map["service":map["ports":[map["name":"status-port" "port":'\u3aac'] map["name":"http2" "port":'P' "targetPort":'\u1f90'] map["name":"https" "port":'\u01bb' "targetPort":'\u20fb']] "type":"ClusterIP"]] "label":map["app":"cluster-local-gateway" "istio":"cluster-local-gateway"] "name":"cluster-local-gateway"]]] "values":map["global":map["useMCP":%!q(bool=false) "jwtPolicy":"first-party-jwt" "proxy":map["autoInject":"disabled"]]]] "metadata":map["namespace":"default" "annotations":map["kubectl.kubernetes.io/last-applied-configuration":""]] "apiVersion":"install.istio.io/v1alpha1"]}
from server for: "https://raw.githubusercontent.com/knative-sandbox/net-istio/master/third_party/istio-stable/istio-minimal.yaml": resource name may not be empty

Also the serving development instructions (https://github.com/knative/serving/blob/master/DEVELOPMENT.md#deploy-istio) need to be updated, since we no longer have third_party/istio-stable/istio-crds.yaml.

@taragu Thank you for the report.
As @ZhiminXiang updated in https://github.com/knative-sandbox/net-istio/pull/357, current istio manifest needs istioctl command. So ccould you please use third_party/istio-latest/install-istio.sh (wrapper script) to install it?
For serving development instructions, it is also still working in progress here https://github.com/knative/serving/pull/9301. Sorry if it caused you any trouble.

@nak3 thanks for the update!

net-istio's DEVELOPMENT.md now suggests that we use  third_party/istio-latest/install-istio.sh.
serving repo's DEVELOPMENT.md was updated by https://github.com/knative/serving/pull/9301.
I think we can close this issue. @taragu please feel free to re-open if you have found any other issue.


HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8

HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8
Changes:

Patch is based on the merged patch from HADOOP-16050
Decided a better name for SSLSocketFactoryEx would be DelegatingSSLSocketFactory because the class is not OpenSSL specific (e.g. it is capable of just delegating to the JSSE)
Add a bunch of code comments to DelegatingSSLSocketFactory
Documented fs.s3a.ssl.channel.mode in performance.md and core-default.xml
If a user tries to configure OpenSSL as the mode via fs.s3a.ssl.channel.mode an UnsupportedOperationException is thrown.

Testing Done:

Ran all S3 tests mvn verify and S3 scale tests mvn verify -Dparallel-tests -Dscale -DtestsThreadCount=16 (did not have S3Guard or kms tests setup)
Ran TestDelegatingSSLSocketFactory on Ubuntu and OSX with -Pnative and confirmed the test passes on both systems (on OSX it is skipped, on Ubuntu it actually runs)
Ran the ABFS tests against "East US 2" and the only failure was ITestGetNameSpaceEnabled.testNonXNSAccount (known issue)
Ran mvn package -Pdist -DskipTests -Dmaven.javadoc.skip=true -DskipShade, un-tarred hadoop-dist/target/hadoop-3.3.0-SNAPSHOT.tar.gz and ran ./bin/hadoop fs -ls s3a://[my-bucket-name]/ successfully and that I could upload and read a file to S3 using the CLI without the wildlfy jar on the classpath

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
92
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
30
Maven dependency ordering for branch

+1
mvninstall
1139
trunk passed

+1
compile
991
trunk passed

+1
checkstyle
144
trunk passed

+1
mvnsite
162
trunk passed

+1
shadedclient
1062
branch has no errors when building and testing our client artifacts.

+1
javadoc
124
trunk passed

0
spotbugs
58
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
237
trunk passed

_ Patch Compile Tests _

0
mvndep
20
Maven dependency ordering for patch

+1
mvninstall
103
the patch passed

+1
compile
1087
the patch passed

+1
javac
1087
the patch passed

+1
checkstyle
150
the patch passed

+1
mvnsite
168
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

+1
shadedclient
714
patch has no errors when building and testing our client artifacts.

+1
javadoc
122
the patch passed

+1
findbugs
260
the patch passed

_ Other Tests _

+1
unit
549
hadoop-common in the patch passed.

+1
unit
298
hadoop-aws in the patch passed.

+1
unit
86
hadoop-azure in the patch passed.

+1
asflicense
50
The patch does not generate ASF License warnings.

7572

Subsystem
Report/Notes

Docker
Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux bc86dcd2f684 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ae4143a

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/1/testReport/

Max. process+thread count
1347 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

(did not have S3Guard or kms tests setup)

You are going to have to do S3Guard tests here because that talks to another AWS endpoint, and it's important to know if there are any regressions. I'm not worried about the KMS stuff, or the assumed role code; there's enough test of AWS Session credentials that talking to AWS STS is handled.
FWIW, we directly talk to the following service s in production code

AWS S3
AWS Secure Token Service
DynamoDB

We need to make sure we are going near all of them.
I've just been looking to see where there's already a good parameterized test we could (abuse) to add another option to the config set, so guaranteeing coverage of interaction with these services without adding new tests (and new test delays). Nothing immediately springs to mind, though ITestS3AContractSeek seems like a good choice. Adding an extra column for each of the three options to set the SSL binding would verify that the seek code was happy with it and that, when run with s3guard enabled, we'd be implicitly testing that.
Sahil: what would you think about replacing ITestS3ASSL with some extra parameterization of the ITestS3AContractSeek test? I know it's nominally wrong to mix things up this way, but it would (a) not make test time any worse than it is and (b) do a more rigorous test: the seek code is skipping around, aborting connections etc?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
114
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
26
Maven dependency ordering for branch

+1
mvninstall
1358
trunk passed

+1
compile
1226
trunk passed

+1
checkstyle
157
trunk passed

+1
mvnsite
183
trunk passed

+1
shadedclient
1113
branch has no errors when building and testing our client artifacts.

+1
javadoc
130
trunk passed

0
spotbugs
61
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
250
trunk passed

_ Patch Compile Tests _

0
mvndep
23
Maven dependency ordering for patch

+1
mvninstall
108
the patch passed

+1
compile
1015
the patch passed

+1
javac
1015
the patch passed

+1
checkstyle
139
the patch passed

+1
mvnsite
162
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

+1
shadedclient
731
patch has no errors when building and testing our client artifacts.

+1
javadoc
128
the patch passed

+1
findbugs
270
the patch passed

_ Other Tests _

+1
unit
576
hadoop-common in the patch passed.

-1
unit
35
hadoop-aws in the patch failed.

-1
unit
33
hadoop-azure in the patch failed.

+1
asflicense
46
The patch does not generate ASF License warnings.

7781

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux ef01615eb0e8 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4e66cb9

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/2/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/2/artifact/out/patch-unit-hadoop-tools_hadoop-azure.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/2/testReport/

Max. process+thread count
1347 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
66
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
25
Maven dependency ordering for branch

+1
mvninstall
1060
trunk passed

+1
compile
1102
trunk passed

+1
checkstyle
131
trunk passed

+1
mvnsite
157
trunk passed

+1
shadedclient
988
branch has no errors when building and testing our client artifacts.

+1
javadoc
112
trunk passed

0
spotbugs
56
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
65
hadoop-tools/hadoop-aws in trunk has 1 extant findbugs warnings.

_ Patch Compile Tests _

0
mvndep
27
Maven dependency ordering for patch

+1
mvninstall
108
the patch passed

+1
compile
1235
the patch passed

+1
javac
1235
the patch passed

+1
checkstyle
141
the patch passed

+1
mvnsite
164
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
5
The patch has no ill-formed XML file.

+1
shadedclient
656
patch has no errors when building and testing our client artifacts.

+1
javadoc
121
the patch passed

+1
findbugs
266
the patch passed

_ Other Tests _

+1
unit
551
hadoop-common in the patch passed.

+1
unit
290
hadoop-aws in the patch passed.

+1
unit
82
hadoop-azure in the patch passed.

+1
asflicense
51
The patch does not generate ASF License warnings.

7563

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 5dcb5d26befd 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c0a0c35

Default Java
1.8.0_212

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/3/artifact/out/branch-findbugs-hadoop-tools_hadoop-aws-warnings.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/3/testReport/

Max. process+thread count
1411 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
89
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
64
Maven dependency ordering for branch

+1
mvninstall
1327
trunk passed

+1
compile
1320
trunk passed

+1
checkstyle
162
trunk passed

+1
mvnsite
188
trunk passed

+1
shadedclient
1188
branch has no errors when building and testing our client artifacts.

+1
javadoc
128
trunk passed

0
spotbugs
63
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
69
hadoop-tools/hadoop-aws in trunk has 1 extant findbugs warnings.

_ Patch Compile Tests _

0
mvndep
25
Maven dependency ordering for patch

+1
mvninstall
125
the patch passed

+1
compile
1053
the patch passed

+1
javac
1053
the patch passed

+1
checkstyle
158
the patch passed

+1
mvnsite
173
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

+1
shadedclient
753
patch has no errors when building and testing our client artifacts.

+1
javadoc
131
the patch passed

+1
findbugs
287
the patch passed

_ Other Tests _

+1
unit
558
hadoop-common in the patch passed.

+1
unit
299
hadoop-aws in the patch passed.

+1
unit
88
hadoop-azure in the patch passed.

+1
asflicense
48
The patch does not generate ASF License warnings.

8373

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux aac944343d4d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 17e8cf5

Default Java
1.8.0_222

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/4/artifact/out/branch-findbugs-hadoop-tools_hadoop-aws-warnings.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/4/testReport/

Max. process+thread count
1572 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
75
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
1234
trunk passed

+1
compile
1084
trunk passed

+1
checkstyle
155
trunk passed

+1
mvnsite
165
trunk passed

+1
shadedclient
1156
branch has no errors when building and testing our client artifacts.

+1
javadoc
138
trunk passed

0
spotbugs
62
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
270
trunk passed

_ Patch Compile Tests _

0
mvndep
26
Maven dependency ordering for patch

+1
mvninstall
111
the patch passed

+1
compile
1039
the patch passed

+1
javac
1039
the patch passed

+1
checkstyle
151
the patch passed

+1
mvnsite
157
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

+1
shadedclient
759
patch has no errors when building and testing our client artifacts.

+1
javadoc
126
the patch passed

+1
findbugs
284
the patch passed

_ Other Tests _

+1
unit
585
hadoop-common in the patch passed.

+1
unit
290
hadoop-aws in the patch passed.

+1
unit
89
hadoop-azure in the patch passed.

+1
asflicense
46
The patch does not generate ASF License warnings.

7926

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux f34904fd3b01 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 70b4617

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/5/testReport/

Max. process+thread count
1503 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
89
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
23
Maven dependency ordering for branch

+1
mvninstall
1194
trunk passed

+1
compile
1219
trunk passed

+1
checkstyle
152
trunk passed

+1
mvnsite
186
trunk passed

+1
shadedclient
1118
branch has no errors when building and testing our client artifacts.

+1
javadoc
129
trunk passed

0
spotbugs
70
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
276
trunk passed

_ Patch Compile Tests _

0
mvndep
26
Maven dependency ordering for patch

+1
mvninstall
125
the patch passed

+1
compile
1113
the patch passed

+1
javac
1113
the patch passed

+1
checkstyle
161
the patch passed

+1
mvnsite
159
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

+1
shadedclient
812
patch has no errors when building and testing our client artifacts.

+1
javadoc
139
the patch passed

+1
findbugs
291
the patch passed

_ Other Tests _

+1
unit
571
hadoop-common in the patch passed.

+1
unit
289
hadoop-aws in the patch passed.

+1
unit
88
hadoop-azure in the patch passed.

+1
asflicense
45
The patch does not generate ASF License warnings.

8154

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux f23d5ce26b1f 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 397a563

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/6/testReport/

Max. process+thread count
1761 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@sahilTakiar I've left some comments.
it'd be good for @DadanielZ to review too

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
44
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
21
Maven dependency ordering for branch

+1
mvninstall
1055
trunk passed

+1
compile
1084
trunk passed

+1
checkstyle
135
trunk passed

+1
mvnsite
136
trunk passed

+1
shadedclient
949
branch has no errors when building and testing our client artifacts.

+1
javadoc
108
trunk passed

0
spotbugs
54
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
216
trunk passed

_ Patch Compile Tests _

0
mvndep
21
Maven dependency ordering for patch

+1
mvninstall
101
the patch passed

+1
compile
977
the patch passed

+1
javac
977
the patch passed

-0
checkstyle
139
root: The patch generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14)

+1
mvnsite
151
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

+1
shadedclient
638
patch has no errors when building and testing our client artifacts.

-1
javadoc
28
hadoop-aws in the patch failed.

-1
javadoc
24
hadoop-azure in the patch failed.

-1
findbugs
23
hadoop-aws in the patch failed.

-1
findbugs
22
hadoop-azure in the patch failed.

_ Other Tests _

+1
unit
510
hadoop-common in the patch passed.

-1
unit
24
hadoop-aws in the patch failed.

-1
unit
23
hadoop-azure in the patch failed.

+1
asflicense
37
The patch does not generate ASF License warnings.

6609

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 368b8c6531d7 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e356e4f

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/7/artifact/out/diff-checkstyle-root.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/7/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/7/artifact/out/patch-javadoc-hadoop-tools_hadoop-azure.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/7/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/7/artifact/out/patch-findbugs-hadoop-tools_hadoop-azure.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/7/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/7/artifact/out/patch-unit-hadoop-tools_hadoop-azure.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/7/testReport/

Max. process+thread count
1462 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
23
Maven dependency ordering for branch

+1
mvninstall
1044
trunk passed

+1
compile
1116
trunk passed

-0
checkstyle
73
The patch fails to run checkstyle in root

+1
mvnsite
148
trunk passed

+1
shadedclient
861
branch has no errors when building and testing our client artifacts.

+1
javadoc
111
trunk passed

0
spotbugs
58
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
217
trunk passed

_ Patch Compile Tests _

0
mvndep
23
Maven dependency ordering for patch

+1
mvninstall
110
the patch passed

+1
compile
1069
the patch passed

+1
javac
1069
the patch passed

-0
checkstyle
129
root: The patch generated 14 new + 0 unchanged - 0 fixed = 14 total (was 0)

+1
mvnsite
134
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

+1
shadedclient
636
patch has no errors when building and testing our client artifacts.

-1
javadoc
29
hadoop-aws in the patch failed.

-1
javadoc
26
hadoop-azure in the patch failed.

-1
findbugs
25
hadoop-aws in the patch failed.

-1
findbugs
24
hadoop-azure in the patch failed.

_ Other Tests _

+1
unit
549
hadoop-common in the patch passed.

-1
unit
25
hadoop-aws in the patch failed.

-1
unit
27
hadoop-azure in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

6702

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux e9f6e1e4f99c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 094d736

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/8/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-970/out/maven-branch-checkstyle-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/8/artifact/out/diff-checkstyle-root.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/8/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/8/artifact/out/patch-javadoc-hadoop-tools_hadoop-azure.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/8/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/8/artifact/out/patch-findbugs-hadoop-tools_hadoop-azure.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/8/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/8/artifact/out/patch-unit-hadoop-tools_hadoop-azure.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/8/testReport/

Max. process+thread count
1379 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
21
Maven dependency ordering for branch

+1
mvninstall
1031
trunk passed

+1
compile
1093
trunk passed

+1
checkstyle
130
trunk passed

+1
mvnsite
140
trunk passed

+1
shadedclient
940
branch has no errors when building and testing our client artifacts.

+1
javadoc
104
trunk passed

0
spotbugs
51
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
212
trunk passed

_ Patch Compile Tests _

0
mvndep
21
Maven dependency ordering for patch

+1
mvninstall
102
the patch passed

+1
compile
998
the patch passed

+1
javac
998
the patch passed

-0
checkstyle
142
root: The patch generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14)

-1
mvnsite
23
hadoop-azure in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

+1
shadedclient
616
patch has no errors when building and testing our client artifacts.

-1
javadoc
26
hadoop-aws in the patch failed.

-1
javadoc
24
hadoop-azure in the patch failed.

-1
findbugs
24
hadoop-aws in the patch failed.

-1
findbugs
22
hadoop-azure in the patch failed.

_ Other Tests _

+1
unit
515
hadoop-common in the patch passed.

-1
unit
23
hadoop-aws in the patch failed.

-1
unit
23
hadoop-azure in the patch failed.

+1
asflicense
38
The patch does not generate ASF License warnings.

6567

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 9a21ba77ad37 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 69ddb36

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/9/artifact/out/diff-checkstyle-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/9/artifact/out/patch-mvnsite-hadoop-tools_hadoop-azure.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/9/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/9/artifact/out/patch-javadoc-hadoop-tools_hadoop-azure.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/9/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/9/artifact/out/patch-findbugs-hadoop-tools_hadoop-azure.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/9/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/9/artifact/out/patch-unit-hadoop-tools_hadoop-azure.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/9/testReport/

Max. process+thread count
1463 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
76
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
27
Maven dependency ordering for branch

+1
mvninstall
1196
trunk passed

+1
compile
1214
trunk passed

+1
checkstyle
188
trunk passed

+1
mvnsite
204
trunk passed

+1
shadedclient
1272
branch has no errors when building and testing our client artifacts.

+1
javadoc
165
trunk passed

0
spotbugs
66
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
290
trunk passed

_ Patch Compile Tests _

0
mvndep
27
Maven dependency ordering for patch

+1
mvninstall
134
the patch passed

+1
compile
1306
the patch passed

+1
javac
1306
the patch passed

+1
checkstyle
178
the patch passed

+1
mvnsite
210
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

+1
shadedclient
900
patch has no errors when building and testing our client artifacts.

+1
javadoc
165
the patch passed

+1
findbugs
341
the patch passed

_ Other Tests _

-1
unit
606
hadoop-common in the patch failed.

+1
unit
95
hadoop-aws in the patch passed.

+1
unit
82
hadoop-azure in the patch passed.

+1
asflicense
57
The patch does not generate ASF License warnings.

8655

Reason
Tests

Failed junit tests
hadoop.security.TestRaceWhenRelogin

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux c9230587c16e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/10/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/10/testReport/

Max. process+thread count
1391 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/10/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
34
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
23
Maven dependency ordering for branch

+1
mvninstall
1273
trunk passed

+1
compile
1190
trunk passed

+1
checkstyle
162
trunk passed

+1
mvnsite
173
trunk passed

+1
shadedclient
1137
branch has no errors when building and testing our client artifacts.

+1
javadoc
143
trunk passed

0
spotbugs
63
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
273
trunk passed

_ Patch Compile Tests _

0
mvndep
26
Maven dependency ordering for patch

+1
mvninstall
111
the patch passed

+1
compile
1082
the patch passed

+1
javac
1082
the patch passed

+1
checkstyle
149
the patch passed

+1
mvnsite
158
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
5
The patch has no ill-formed XML file.

+1
shadedclient
740
patch has no errors when building and testing our client artifacts.

+1
javadoc
122
the patch passed

+1
findbugs
294
the patch passed

_ Other Tests _

-1
unit
612
hadoop-common in the patch failed.

-1
unit
30
hadoop-aws in the patch failed.

-1
unit
32
hadoop-azure in the patch failed.

+1
asflicense
49
The patch does not generate ASF License warnings.

7756

Reason
Tests

Failed junit tests
hadoop.fs.TestTrash

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 4f056127dd8a 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/11/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/11/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/11/artifact/out/patch-unit-hadoop-tools_hadoop-azure.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/11/testReport/

Max. process+thread count
1453 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/11/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
100
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
65
Maven dependency ordering for branch

+1
mvninstall
1288
trunk passed

+1
compile
1210
trunk passed

+1
checkstyle
155
trunk passed

+1
mvnsite
170
trunk passed

+1
shadedclient
1118
branch has no errors when building and testing our client artifacts.

+1
javadoc
129
trunk passed

0
spotbugs
71
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
272
trunk passed

_ Patch Compile Tests _

0
mvndep
25
Maven dependency ordering for patch

-1
mvninstall
20
hadoop-aws in the patch failed.

-1
mvninstall
18
hadoop-azure in the patch failed.

+1
compile
1158
the patch passed

+1
javac
1158
the patch passed

-0
checkstyle
159
root: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)

+1
mvnsite
170
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
3
The patch has no ill-formed XML file.

+1
shadedclient
760
patch has no errors when building and testing our client artifacts.

-1
javadoc
38
hadoop-tools_hadoop-aws generated 4 new + 1 unchanged - 0 fixed = 5 total (was 1)

+1
findbugs
310
the patch passed

_ Other Tests _

+1
unit
625
hadoop-common in the patch passed.

+1
unit
90
hadoop-aws in the patch passed.

+1
unit
92
hadoop-azure in the patch passed.

+1
asflicense
46
The patch does not generate ASF License warnings.

8140

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 8104ee6f99c6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 524b553

Default Java
1.8.0_212

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/12/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/12/artifact/out/patch-mvninstall-hadoop-tools_hadoop-azure.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/12/artifact/out/diff-checkstyle-root.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/12/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/12/testReport/

Max. process+thread count
1348 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/12/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
87
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
26
Maven dependency ordering for branch

+1
mvninstall
1263
trunk passed

+1
compile
1211
trunk passed

+1
checkstyle
155
trunk passed

+1
mvnsite
172
trunk passed

+1
shadedclient
1122
branch has no errors when building and testing our client artifacts.

+1
javadoc
131
trunk passed

0
spotbugs
64
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
274
trunk passed

_ Patch Compile Tests _

0
mvndep
27
Maven dependency ordering for patch

+1
mvninstall
126
the patch passed

+1
compile
1140
the patch passed

+1
javac
1140
the patch passed

-0
checkstyle
154
root: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)

+1
mvnsite
169
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
3
The patch has no ill-formed XML file.

+1
shadedclient
753
patch has no errors when building and testing our client artifacts.

-1
javadoc
34
hadoop-tools_hadoop-aws generated 4 new + 1 unchanged - 0 fixed = 5 total (was 1)

+1
findbugs
310
the patch passed

_ Other Tests _

+1
unit
615
hadoop-common in the patch passed.

+1
unit
94
hadoop-aws in the patch passed.

+1
unit
83
hadoop-azure in the patch passed.

+1
asflicense
46
The patch does not generate ASF License warnings.

8051

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 6153829a62f6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 524b553

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/13/artifact/out/diff-checkstyle-root.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/13/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/13/testReport/

Max. process+thread count
1348 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/13/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

thanks for updating this. Was this just a rebase + push or have you made other changes?

didn't push anything, not sure why yetus deleted all your comments. although I did start to actively work on this a few days ago, working on addressing your comments and should have an updated patch by the end of the week (hopefully sooner).

Yes, I rebased this and addressed your comments. Having some trouble running all the tests though. I ran against us-east-1 and all the tests except the follow pass: mvn test -Dtest=ITestS3AContractRename,ITestAuthoritativePath,ITestS3GuardTtl . I think it is because I don't have S3Guard access (working on getting access).
I'm working on getting S3Guard access, but wanted to update the PR in the meantime. Once I get access will re-run the tests with mvn verify -Ds3guard -Ddynamo.
Still trying to understand how to test against AWS Secure Token Service as well.

Re-ran tests with:
<property>
  <name>test.fs.s3a.sts.enabled</name>
  <value>true</value>
</property>

In my auth-keys.xml file, and all the tests passed (except for ITestAuthoritativePath and ITestS3GuardTtl).
I re-ran ITestS3AContractRename and it works now, so the maybe the test was just flaky.

Patch is coming together nicely -nearly there. Done CLI tests as well as the -aws suite,
A big fear of mine is that the current patch will, through transitive references, fail if the
wildfly JAR isn't on the CP.
But I couldn't actually create that failure condition when I tried on the CLI.
first, extended patched cloudstore s3a diagnostics to look for the new class
``
class: org.wildfly.openssl.OpenSSLProvider
Not found on classpath: org.wildfly.openssl.OpenSSLProvider

tested IO against a store -all good.

and when I switch to an unsupported mode I get the expected stack trace

2019-09-16 13:06:11,124 [main] INFO  diag.StoreDiag (DurationInfo.java:(53)) - Starting: Creating filesystem s3a://hwdev-steve-ireland-new/
2019-09-16 13:06:11,683 [main] INFO  diag.StoreDiag (DurationInfo.java:close(100)) - Creating filesystem s3a://hwdev-steve-ireland-new/: duration 0:00:561
java.lang.UnsupportedOperationException: S3A does not support setting fs.s3a.ssl.channel.mode OpenSSL or Default
at org.apache.hadoop.fs.s3a.impl.NetworkBinding.bindSSLChannelMode(NetworkBinding.java:86)
at org.apache.hadoop.fs.s3a.S3AUtils.initProtocolSettings(S3AUtils.java:1266)
at org.apache.hadoop.fs.s3a.S3AUtils.initConnectionSettings(S3AUtils.java:1230)
at org.apache.hadoop.fs.s3a.S3AUtils.createAwsConf(S3AUtils.java:1211)
at org.apache.hadoop.fs.s3a.DefaultS3ClientFactory.createS3Client(DefaultS3ClientFactory.java:58)
at org.apache.hadoop.fs.s3a.S3AFileSystem.bindAWSClient(S3AFileSystem.java:543)
at org.apache.hadoop.fs.s3a.S3AFileSystem.initialize(S3AFileSystem.java:364)
at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:3370)
at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:136)
at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:3419)
at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:3387)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:502)
at org.apache.hadoop.fs.Path.getFileSystem(Path.java:365)
at org.apache.hadoop.fs.store.diag.StoreDiag.executeFileSystemOperations(StoreDiag.java:860)
at org.apache.hadoop.fs.store.diag.StoreDiag.run(StoreDiag.java:409)
at org.apache.hadoop.fs.store.diag.StoreDiag.run(StoreDiag.java:353)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
at org.apache.hadoop.fs.store.diag.StoreDiag.exec(StoreDiag.java:1163)
at org.apache.hadoop.fs.store.diag.StoreDiag.main(StoreDiag.java:1172)
at storediag.main(storediag.java:25)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hadoop.util.RunJar.run(RunJar.java:323)
at org.apache.hadoop.util.RunJar.main(RunJar.java:236)
2019-09-16 13:06:11,685 [main] INFO  util.ExitUtil (ExitUtil.java:t

which is telling me that my fears are misguided?

what do others say?

BTW, @bgaborg  been having problems with STS tests too -try setting a region for the endpoint. Starting to suspect the latest SDK needs this now.

Did a full test run -Ds3guard -Ddynamodb -Dscale -Dauth; all failures DDB table delete timeouts and the (known) prune one. All good otherwise.

Thanks for the feedback and running all the tests Steve! I left a comment above about why I think the everything will still work without wildfly on the classpath.
Working on addressing the other comments.

Addressed comments, re-ran tests, the only additional failure is ITestS3AFileOperationCost, which is failing on trunk for me as well.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
147
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
100
Maven dependency ordering for branch

+1
mvninstall
1532
trunk passed

+1
compile
1361
trunk passed

+1
checkstyle
167
trunk passed

+1
mvnsite
205
trunk passed

-1
shadedclient
1289
branch has errors when building and testing our client artifacts.

+1
javadoc
149
trunk passed

0
spotbugs
71
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
270
trunk passed

_ Patch Compile Tests _

0
mvndep
22
Maven dependency ordering for patch

+1
mvninstall
129
the patch passed

+1
compile
1130
the patch passed

+1
javac
1130
the patch passed

-0
checkstyle
181
root: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)

+1
mvnsite
169
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

+1
shadedclient
801
patch has no errors when building and testing our client artifacts.

-1
javadoc
33
hadoop-tools_hadoop-aws generated 4 new + 1 unchanged - 0 fixed = 5 total (was 1)

+1
findbugs
266
the patch passed

_ Other Tests _

+1
unit
545
hadoop-common in the patch passed.

+1
unit
87
hadoop-aws in the patch passed.

+1
unit
92
hadoop-azure in the patch passed.

+1
asflicense
48
The patch does not generate ASF License warnings.

8761

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-970/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/970

JIRA Issue
HADOOP-16371

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 3eeeb1eb687e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 66bd168

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/14/artifact/out/diff-checkstyle-root.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/14/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/14/testReport/

Max. process+thread count
1341 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-970/14/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

the only additional failure is ITestS3AFileOperationCost, which is failing on trunk for me as well.

Is it? That's not good. That test uses the file system metrics to make assertions about how many operations actually go to S3. If it's failing either there is something wrong with assertions in your environment, or the connector is potentially making to many or too few calls to S3.
What are your test S3Guard settings?

thanks for the final revision and explanation of why classloading wasn't going to be a problem
+1 -committed to trunk. Thanks!


Use common data between Perl/Ruby/Go versions (eg. JSON)?

Hi,
just was this new Go version thanks to your reply. I was interested in reusing some of the data from Sisimai in my PHP code, and I'm wondering why you didn't go the route of having a common set of data that could be reused between the various language versions of Sisimai?
For example you could have a set of JSON files that list the various strings and pairs for matching reasons, like I extracted here: https://gist.github.com/bohwaz/9c5b8354089a15033ea1a97a267cabfb#file-reasons-json
And probably the same with other parts, like matching Rhost errors, which are mostly just large arrays. Some parts might be too complex to make "generic" like in Lhost. But having the same common data for each library would avoid having to replicate changes on strings from one library to the other, reducing duplicate code efforts.
For example you would have a "sisimai-data" repo that would be pulled by various libraries to have up to date data for matching reasons, Rhost, etc.
Maybe there is an obvious reasons you didn't go this route that I can't see right now?
Anyway, thank your for your work, very interesting and useful :)

@bohwaz Apologies for the delayed response.
I think that unifying fixed strings, starting with error message patterns, is a good idea. After initially releasing the Perl version of Sisimai, I created a Ruby version on a whim because I wanted to run it on AWS Lambda. At that time, I separated set-of-emails as a repository for test emails common to both.
Since error messages were implemented using a large number of regular expressions at the time, I was concerned that using them in a common external file would cause excessive I/O at runtime and slow things down. Therefore, I decided that hardcoding them in the repository was the most reasonable approach. I thought that since error message patterns are rarely updated, I could just copy them if needed.
Now that all error message patterns have been changed to fixed strings, I may reconsider this if it doesn't cause any performance issues, including I/O.
However, my current thinking is that I strongly prefer to keep all files necessary for installation, testing (make test), and execution in a single repository.
By the way, the process of copying and pasting changes to a separate repository, while seemingly unproductive, acts as a self-contained code review and can surprisingly lead to finding improvements in the code.
Thank you for your ideas and feedback!

Thank you, all perfectly understandable points.
Maybe a solution would be to have a central repo of strings, and each library could generate a native source file from this repo, eg. a hash table, which would be versioned in git. This way you would have zero performance issue as the strings would be in the code, but you wouldn't have to manually match the strings between different libraries.
This would also work for your requirement to keep all files in the same repo, as you would have a copy of the strings in each repo.


Test bdowney gryoscope task

This task is complete and Brendan is completing a user guide for it. That will be posted when it is available.
For reference,
See task l3g4200d-atxmega128abu
We need to develop a test case for making sure the software meets all functionality requirements.
That also entails testing the ability for this task to run on the development boards.

Assign Anson

Anson assigned

https://db.tt/LR6u11Zu


Note (in docu) that Json.Decode.succeed may fail?

The current documentation says (http://package.elm-lang.org/packages/elm-lang/core/4.0.1/Json-Decode#succeed):

A decoder that always succeeds.

But actually, this should be preconditioned on the input being valid JSON. Already something simple as an empty string as input can make the decoder fail. That's non-obvious and has led to confusion, see here and here (and also in the more distant past).
Maybe warn about this in some way in the documentation, since the current wording "always succeeds" does raise wrong expectations?

Is addressed in the new documentation.


Request for a priority incompatibility fix on two mods

Hi, I saw that you fixed a bunch of issues on other mods.
There's a situation where two mods I want to use use the same game rule with priority 1000. I want to change one mod's priority, but currently, there's no solution for that on Forge 1.18.2 (at least afaik). (I own none of those mods)
The mods are project save the pets and domestication innovation - I hope there's something you can do or a mod you know that might help here. Thanks for your attention.
https://github.com/AlexModGuy/DomesticationInnovation/issues/158

At first, the issue should able to fix.
But as the repo name shows. This mod is for Dawncraft instead of a fix mod. I have no motivation to do that.


Add DB location for OmniFocus 2 purchased from Mac App Store

The DB location for OmniFocus 2 purchased from Mac App Store is:
${HOME}/Library/Containers/com.omnigroup.OmniFocus2.MacAppStore/Data/Library/Caches/com.omnigroup.OmniFocus2.MacAppStore/OmniFocusDatabase2

Thanks - I'll add that to the list

Fixed in V1.0.19.


netbird pre-shared not persistent

Describe the problem
PreShared key not persistent in the config.json on ubuntu 20.04 , 22.04 , 23.04 , Windows and Mint. (At least this distros I tested)
To Reproduce
Steps to reproduce the behavior:

netbird up --preshared-key PreSharedKey
cat /etc/netbird/config.json    --> PreShared key is in the config
netbird down   --> Still Key is in the Config
netbird up        --> Key removed from the konfig

Same problem when using gui. I already opened a issue #845  which was closed as fixed but the problem is still in the 0.20.3.
Expected behavior
Key should be persistent in the config.josn because after restarts of the service or the server the client connects without the key so preshared key protection is disabled ...
NetBird status -d output:
If applicable, add the output of the netbird status -d command
Is think not relevant because the connection is working fine when connected without preshared key or using netbird up --preshared-key with every connect.
Screenshots
Same problem/screenshots then in #845

is no one using the pre-shared key function (still not persistent in 21.5)?
Because in my tests every  time netbird is started I need to manually add the psk (in the UI I needed to readd it and in CLI I need to define the option --preshared-key)

@mlsmaycon thank you very much in linux this is working perfectly fine now. i will ask my collegue to also test it in windows but it looks great.

@mlsmaycon windows 11 is now also tested and working fine. I think we can close this now.
Thank you very much for the fix :)


Reference to manual setup for external repository

There is a reference to setting up an external repository at the beginning of this doc:
"To manually configure continuous deployment from a cloud repository that the portal doesn't directly support, such as GitLab, see Set up continuous deployment using manual steps."
That points to https://github.com/projectkudu/kudu/wiki/Continuous-deployment#setting-up-continuous-deployment-using-manual-steps
However the ability to setup an external repository seems to be missing from Deployment Center in Azure Web Apps now. I see some reference that makes me thing this used to be possible. Can you clarify if this is possible or not any longer?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81dce42d-71bc-9ac0-b016-4add247bb48a
Version Independent ID: 72e95a87-a302-d06c-5a0f-e2f5caf201d1
Content: Continuous deployment - Azure App Service
Content Source: articles/app-service/deploy-continuous-deployment.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@jasonpnnl, Thanks for the question! We are taking a look into this and will get back to you soon.

@cephalin , Could you please verify this documentation and update if this is possible or not any longer?

Now I see what the difference is. These options are only available for Windows Web Apps, not for Linux Web Apps. Perhaps that needs to be clarified in the doc.

@jasonpnnl , Thank you so much for the update. We will update the document.

@jasonpnnl Thank you for reporting. I've added a new section that calls out Windows only for external repos. It should be published sometime today. #please-close


Possibility to specify test execution order

Hello,
I want to implement some integration tests.
How can I specifiy an execution order if the tests rely on each other like a test chain?
Is there a sample how multiple classes acts on execution? I need to execute the different test classes in a specific order as well.
In the default implementation using fluent syntax the it["..."] tests are always executed before the nested context from the same level.

Hi @r-weisser , glad to hear you're using NSpec.
Actually there's no way to order execution of tests (say, it blocks) within the same context. At least from experience in our team - and in general testing literature - relying on test execution order is generally discouraged.
We do have many cases though where a particular test makes sense only in a specific scenario, so you end up building a number of test scenarios with many paths and sub-paths:

When this happens

Test this A
And when also this happens

Test this B1
Test this B2
And when finally this happens

Test this C

Instead when something else happens

Test this D1
Test this D2

Here, you know for sure that A test will run before B tests, which in turn will run before C test. Accordingly, you can run preparatory setup for each of those context, and those setup will run in order too. The only thing, you cannot tell the order between B1 and B2, for example.
If it fits your bill, NSpec excels at this test scenario construction, and it makes for a nice output of that as well.

Thanks for the fast response. I'll give it a try.
In the meantime I'm still wondering how the following setup will behave regarding order or parallization.
Are they executed in one step - first class 1 then class 2 OR first class 2 then class 1
OR can the tests executed in a random mixed order like 1.1, 1.21, 2.1, 1.22, 2.22, ... ?

Using multiple classes with tests e.g.

Class 1

Before
Test 1.1
Context 1.2

Test 1.2.1 executed first or second
Test 1.2.2 executed first or second

After

Class 2

Before
Test 2.1
Context 2.2

Test 2.2.1 executed first or second
Test 2.2.2 executed first or second

After

There's currently no parallelization in NSpec test execution.
Regarding order of classes/contexts: within a test assembly, each nspec-derived class is executed one after the other, no order guaranteed. Within a spec class, each context "at the same level" is executed one after the other, again no order guaranteed. Before leaving a context to pass to the next, all its sub-contexts are traversed and executed.
Regarding order of before/act/test/after/etc., there are info about that in wiki as well as in main site.

Relevant Stack Exchange Code Review QnA


ImportError raised when trying to load 'treebeard.templatetags.admin_tree': No module named util

On MAC during the make sandbox
site-packages/django/template/backends/django.py", line 148, in get_package_libraries
"trying to load '%s': %s" % (entry[1], e)
django.template.library.InvalidTemplateLibrary: Invalid template library specified. ImportError raised when trying to load 'treebeard.templatetags.admin_tree': No module named util
make: *** [build_sandbox] Error 1

I think that this problem is related to django 1.9, try this:
pip uninstall django

than
pip install "django<1.9"

@redaelli How is this a solution??

@a115, well for now it is until the dependencies are correct or until it's compatible with djang 1.9

1.3 will be compatible with django 1.9


expose AddError via Dao interface

[x] Do only one thing
[x] Non breaking API changes
[ ] Tested

Note: test suite pass but didn't add a new test. Tested the change in real application though.

What did this pull request do?
Expose DB.AddError() to DAO interface.
User Case Description
We build most of our queries using reusable Scopes() functions. In most cases the query validates few constraints and needs a way to propagate the error back.

Seems the error is not added to the current db but initialized a new one?

Seems the error is not added to the current db but initialized a new one?

Thanks @jinzhu for replying
I opted to reuse the existing withError method that seems to be everywhere else. What do you think?


Fixes #314: Add PRISM async notebook

Closes #314

@alaws-USGS - could you update this file with a brief description of these 3 notebooks?

@amsnyder Added!


Add convert to AsyncAPI from Postman collection support

As the PR was just merged, it's now possible to convert Postman collection to AsyncAPI v3, and it should be possible to do this through the CLI. Checkout https://github.com/asyncapi/converter-js?tab=readme-ov-file#postman-collection-to-asyncapi-conversion for how to do it.
https://github.com/asyncapi/converter-js/pull/276

I am on it : )

Hey @jonaslagoni as i have done #1498, i would like to take this

Hey @jonaslagoni as i have done #1498, i would like to take this

@Gmin2 After discussion with @Souvikns we decided to submit this issue in the bounty program.  Please let me start working on this issue, if you have any doubt let me know thanks for cooperation

@jonaslagoni  @Souvikns I want to take this issue. As i have made the specifications for conversion of postman collection into async api . I would love to work on this issue. Here is the link that pr.

/bounty

Bounty Issue's service comment
Text labels: bounty/2024-Q4, bounty/medium, bounty/coding
First assignment to regular contributors: 2024-09-20 00:00:00 UTC+12:00
End Of Life after: 2024-10-31 23:59:59 UTC-12:00
@asyncapi/bounty_team
The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.
Regular contributors should explain in meaningful words how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue.

I can see that we can only export the Postman collection in a JSON file and not in a YAML file. In the Pull Request mentioned, it's converting YAML postman collection file to Async API file. @ItshMoh, Can you guide me on how we can export the Postman collection to a YAML file?

@dhruvilmehta
Bounty Issues are not collaborative work, and the Bounty Program is not a Mentorship Program. You are expected to be able to deliver the solution autonomously with only a little strategic guidance from the AsyncAPI Maintainer. Please describe how would you approach the resolution of this Bounty Issue, preferably with a coding draft.

@Gmin2 Will work on this issue, We have discussed it, and He has done the prerequisite task of this issue

We need to introduced a new option for format parameter named postman(as format was introduced in this ), and then we need to also add isPostmanCollection in convert.js as introduced in this, and finally we need to add a testcase for it
I would like to work on this as part of bounty program
cc @aeworxet, @Souvikns

Bounty Issue's Timeline

Complexity Level
Assignment Date (by GitHub)
Start Date (by BP Rules)
End Date (by BP Rules)
Draft PR Submission
Final PR Merge Start
Final PR Merge End

Medium
2024-09-21
2024-10-07
2024-11-17
2024-10-20
2024-11-03
2024-11-17

Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

Does the code work as expected after the merge of https://github.com/asyncapi/cli/pull/1527?

Does the code work as expected after the merge of #1527?

Screencast from 03-10-24 04:31:19 PM IST.webm

@Souvikns, as the AsyncAPI Maintainer, who was responsible for the resolution of this Bounty Issue from the AsyncAPI's side, please confirm its technical resolution.

I confirm that this bounty issue is resolved succesfully.

Bounty Issue Is Completed 🎉
@Gmin2 (githubID 127925465), please go to the AsyncAPI page on Open Collective and submit an invoice for USD 200.00 with the expense title Bounty cli#1516, tag bounty, and full URL of this Bounty Issue in the description.


[JAX] Meta Learning Tutorial?

Hi Phillip,
Thank you for open-sourcing the course!
I was wondering whether there is a specific reason that the meta learning tutorial was not "ported" to Jax? :slightly_smiling_face: Is it because you did not find the time, or rather because of issues you encountered while doing the porting?

Hi Imahn,
There is no specific reason for the meta-learning tutorial being not yet in JAX, I simply didn't find the time to do it yet. I hope to get to it at some point, since by using the jax.grad transformations, it is actually easier to implement these algorithms in JAX than in PyTorch :)


ci: disable codecov from build

codecov dissapeard from pypi, breaking billions of builds at once.
Possible security related problem is "anyone can now snap up codecov with a malicious package that would be installed on many systems currently depending on codecov."
This seems to be handled by pypi admins, but still it is breaking the builds
Hi, PyPI administrator here. Just wanted to confirm that the entire codecov project was removed by the project maintainers at 2023-04-12 12:41:12 UTC. The 0.0.0a2 release was later uploaded by an unrelated third party that was helpfully trying to prevent the released project name from being acquired by attackers and distributing malware. That version has since been removed and the name prohibited from re-registration.
https://github.com/codecov/python-standard/issues/31
https://community.codecov.com/t/codecov-yanked-from-pypi-all-versions/4259

Let's wait a bit how the situation around codecov will resolve.


Blog Post on IP2Geo processor

Describe the blog post your would like to write
How to add country of incoming requests based on IP address using IP2Geo processor
What is the title of the blog post?
New real time IP to Geo processor for OpenSearch
Who are the authors?
Who will be listed as the authors of this blog post
Heemin Kim, Junqiu Lei, Satish Nandi, Vamshi Vijay Nakkirtha
What is the proposed posting date?
9/22

Added comments. I will approve once the comments are addressed.

@krisfreedain - Blog is GTG. Let's publish.

Looks like this one has been satisfied. https://opensearch.org/blog/use-opensearch-benchmark-with-randomized-query-terms/


Merge prTesting_201903131035 branch to master branch

OPS Build status updates of commit 2799d90:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


npm install -g karma (unable to install)

I have tried to install node.js two numbers of systems.  no one is working. environment variables are set. Please help me out, Even I have tried to create .npmrc file
Node.JS tried with https://nodejs.org/dist/latest/node-v4.0.0-x64.msi
===SYSTEM ONE ===after this other system has some issues===================
C:\installer\Solution\MVCApp>npm install -g karma
npm ERR! registry error parsing json
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\
node_modules\\npm\\bin\\npm-cli.js" "install" "-g" "karma"
npm ERR! node v4.0.0
npm ERR! npm  v2.14.2
npm ERR! Unexpected token <
npm ERR! <!DOCTYPE html PUBLIC"-//W3C//DT
D XHTML 1.0 StaticRequestInfo={Referer:document.referrer};function EscapeBrowser
Frame(){try{if(window.top.location==window.self.locatio
![node_err]n){}else{window.top.location.href=document.location.href}}catch(Error){}}function SetRequestTitle(){document.title=document.domain}function InitiateFrameRequest(){var url = "/?acc=0F4B1
727-114A-4EF2-AC1B-1DB964D84818&ref=http%3A%2F%2Fww15.registry.nmpjs.org%2Fkarma
&framerequest=1&pcc=";document.write("<frameset rows=\"100%,*\" frameborder=\"no
\" border=\"0\" framespacing=\"0\"><frame src=\""+url+"\" name=\"landingparent\"
 id=\"landingparent\"><\/frameset>")}SetRequestTitle();EscapeBrowserFrame();</sc
ript><meta http-equiv="refresh" content="0;url=/?acc=0F4B1727-114A-4EF2-AC
1B-1DB964D84818&ref=http%3A%2F%2Fww15.registry.nmpjs.org%2Fkarma&framerequest=1&
noscript=1&pcc="><noframes><meta http-equiv="refresh" content="0;url=
/?acc=0F4B1727-114A-4EF2-AC1B-1DB964D84818&ref=http%3A%2F%2Fww15.registry.nmpjs.
org%2Fkarma&framerequest=1&noscript=1&pcc="></noframes>
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     C:\installer\Solution\MVCApp\npm-debug.log
===SYSTEM SECOND ====================================================

There are two main issues here, the first one is that python is missing from your path, make sure you follow the instructions here to ensure node-gyp is working.
The second is that karma should not be installed globally, it should be installed locally to your project and to get karma as a binary into your path you should run npm install -g karma-cli.

Thanks for this (Problem resolved, but there is one issue left),
Python 2.7.10
I have followed the same steps from Windows section
Downloaded : https://www.python.org/ftp/python/2.7.10/python-2.7.10.amd64.msi
Installation Done:
Verified with Path Envirnoment Variables.
It works fine with npm install -g karma-cli.
I am also getting another issue Node pattern, is mis match patterm, refer below screen shot.

You need use *.js and not **.js

Yes, sorry silly mistake. that is resolved.
I was struggling installation issue from last 1 day.
Now I am going to write test cases.

Enjoy :)


[LIGHTNODE] As a user, I want to see a link to my SellMore Page on the BuyMore page so that I am able to sell more

Closing it,as we will not work on the Sellmoreboard


rdsbroker: bump to version 1.18.0

What
Releases https://github.com/alphagov/paas-rds-broker/pull/145
How to review
Release to a dev env, check you can restore a mysql database.

🚨⚠ Please do not merge this pull request via the GitHub UI ⚠🚨

Together we have confirmed that this does what it should do.


[IDEA/REQUEST] Suggestions for optimising default iA Writer fonts

Heya—this one should be pretty quick but I didn't have the time to write up a PR. 3 things you could fix:

Right now you're loading the iA Writer fonts into the theme as format('truetype'), which is less space-efficient (about 3x). You can convert the variable fonts to format('woff2-variations') and save a good 100kb or so per font.
I don't think you're loading the fonts correctly to use the bold font weight (at least, I copied your code into a snippet on my iPad and it didn't work right). Since they're variable fonts, you need to explicitly set format('woff2-variations') (if you're fixing the first problem) at the end of each font and specify a range for the font-weight (ex. font-weight: 400 700 for the iA Writer fonts). This will get bold to work while keeping space requirements low.
You're technically supposed to include the license for the iA fonts when you redistribute them ;)

It should be easy to fix; I went to the trouble of doing both of these steps myself for my personal theme, and I uploaded them at this gist. Probably a copy-paste job :)

Hi! First of all, thanks for the recommendations!
I should have paid closer attention to the font's license, and that's on me. I'll be including it in the next version, as well as encode it using the different format. I did used to have it with woff2, but when editing it several times and re-encoding, I must have used the ttf format without thinking too much of it.
As for the bold error, I believe it's a font issue, as reported in their repo. I've already tried the variable range for font-weight, but it did not fix the issue (it actually made other errors, for some reason). Thanks to the contribution of another member of the community, I now have a version of iA Quattro S with that bold issue fixed, which will be included in the next update.
Again, thanks for the feedback 😉

Happy to help—I actually found your project through looking into the bold type issue 😅
I’m not 100% sure, but the bold issue you’re seeing with Quattro V could be down to different browsers’ support for variable fonts, or maybe just a couple problems with setting up the CSS. FWIW the code in my snippet is definitely working on the latest iPadOS & macOS, but it’s probably not the most robust support for wide OS & browser support ^_^
Cheers for taking a look and getting back so quickly!


Extend Sonatype Lift with ORT

Awesome to see ORT using Sonatype Lift!
Lift is a way to deploy tools across multiple repositories without having to configure that tool for each repo and it also supports custom tools. You could experiment with adding ORT to Lift if you’re interested https://help.sonatype.com/lift/extending-lift. That might be a low-friction way to roll ORT out to GitHub users (i.e. install Lift + add ORT configuration).
Let us know if you need any help!

Thanks for the idea! That could be a sneaky way to get GitHub integration for free 😉

Ha yea. That's one of the reasons we designed Lift to be extensible. It allows projects to install one thing to get multiple analyses rather than having to install and maintain multiple tools.

Closing, as Lift was sunsetting on August 12, 2023.


load balancer: Rename selectPool to selectExistingConnection

load balancer: Rename selectPool to selectExistingConnection to be more clear about the semantics of the method.
Risk Level: Low
Testing: Existing
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/retest


Add sphere example

Add parameter and mesh files for Example 4 - 3D Flow around a Sphere

@cenr20 can  you remove the .msh file from the PR? I prefer to only leave .geo when possible, it makes for much lighter PR.
:)!

Done!


Surface resolution

Current meshes are very high resolution.
We should create alternate versions, den-{den} for # of vertices, and provide all of them (or give options on cmdline).
128x256 currently
64x128 ?
32x64 ?
16x32 ?
https://github.com/jordandekraker/Hippocampal_AutoTop/blob/79f0d5540be2e1f23826f1079852cb8e1409b961/misc/unfold_ref_256x128x16.nii.gz
https://github.com/jordandekraker/Hippocampal_AutoTop/blob/79f0d5540be2e1f23826f1079852cb8e1409b961/tools/warps_gifti/create_template_unfold_gifti.m#L6
https://github.com/jordandekraker/Hippocampal_AutoTop/blob/79f0d5540be2e1f23826f1079852cb8e1409b961/tools/warps_gifti/create_template_unfold_gifti.m#L9

I was thinking it would be good to generate a standard, decimated mesh that has roughly equal face sizes based on a group-averaged hippocampus. We could create a standard mapping of hippunfold vertices to the vertices of a decimated version.
In Boris' lab we will likely try to add an atlas for hippocampal surfaces to this toolbox: https://github.com/MICA-MNI/BrainStat.
This toolbox assumes face sizes are roughly equal, and for doing stats it would be nice to decimate a bit too since some bootstrapping tests can be compute heavy!
I'll try something like this and keep you posted!

Yea I've been thinking about that too. Instead of creating an average surface and working with that (which has some downsides, e.g. blurring the anatomy), could alternatively update our unfolded standard mesh (equal face size in unfolded space), to have a triangulation with variable face sizes, based on the face size when transformed to native space. Those face sizes are the gyrification measures we compute already..
I've played around like this and still need to finish writing to a gifti, but the adaptive mesh looks like this (here I just used an average gyrification from ~30 subjects, but easy to swap that out for say all HCP training subjects).. Will commit in a branch once I iron the last few things out..

With this approach we can set the target face size we want, so can easily generate different resolutions too. The one pictured here is ~16K vertices. This should also improve our surfaces in the really curved parts, since it ends up sampling much more densely than what we have in our existing scheme.

Very nice! I think this could do the trick.
Another approach that I explored a bit is a decimation algorithm. In this case the algorithm also produces roughly equal face sizes, doesn't add any new vertices, and keeps an index of which original vertices were kept. Here is an illustration using a 512x256 surface from 3D PLI (so going from 32K vertices down to 2K, but also note some vertices are lost in the corners):

Yeah in the case where you have a single high-res surface I think doing decimation/re-meshing makes alot of sense. In general I think a combination of approaches is might be more optimal than either on their own.
E.g. could start with a variably-meshed grid and also decimate in native space (then wouldn't require such a dense mesh to begin with)..
However for the hippunfold (nnunet surfaces) we will probably want to use a group-average hippocampus, as the sampling for these single high-res cases is different enough (eg with all the digitations seen).. could probably confirm by comparing what a gyrification map looks like for this case compared to a nnunet hippunfold..

Finally got around to tidying up the scripts and started a PR for creating the new templates with varying densities, and spacing adjusted to result in uniform (on average) meshes in native space.  Draft PR: #74
If you want to see an example of these warped to a subject, they are here:
https://github.com/khanlab/hippunfold/tree/custom-density/gen_unfold_template/example_transformed
and the new unfold templates are here:
https://github.com/khanlab/hippunfold/tree/custom-density/hippunfold/resources/unfold_template_avgarea
(note the naming of files in the example is by target vertex area, whereas it is density in the unfolded template, but they have 1-1 correspondence (e.g. 0.1mm^2 is 11k vertices)

This is now resolved in #74


feat: add pico8 language server

PR for nvim-lspconfig
https://github.com/neovim/nvim-lspconfig/pull/3041
Already available in mason-registry:
https://github.com/mason-org/mason-registry/tree/main/packages/pico8-ls

@williambotman /fixup


Example for apply_complex_function

You should probably make this PR a draft for now :)

I think it is fixed now!

Docs reference: https://manimce--1500.org.readthedocs.build/en/1500/reference/manim.mobject.mobject.Mobject.html#manim.mobject.mobject.Mobject.apply_complex_function


Permission

Good day Mr. edgedalmacio,
Sir I would like to ask your permission in using this restful api for our thesis project. If you could kindly grant me the authority to use this in our project.  Thank you in advance.

See issue https://github.com/edgedalmacio/phisix/issues/35


Code Refactor

Update Eslint rules
Fix lint errors
Fix Vue errors in developer console

It’s the same. I was just wondering if you think it’s preferable to do this way rather than the explicit cast
Get Outlook for iOShttps://aka.ms/o0ukef

From: Raymond Nguyen<EMAIL_ADDRESS>Sent: Thursday, September 24, 2020 6:26:08 AM
To: CrisisCleanup/crisiscleanup-3-web<EMAIL_ADDRESS>Cc: Tobi Abiodun<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [CrisisCleanup/crisiscleanup-3-web] Code Refactor (#983)
@raymondxd commented on this pull request.

In src/components/WorksiteFilters.vuehttps://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#discussion_r494205351:

@@ -264,8 +264,9 @@

<div

                       v-for="option in field.values"

                       v-if="Boolean(option.value)"

                       v-for="option in field.values.filter(

                         (option) => !!option.value,

@tabiodunhttps://github.com/tabiodun thanks for your comment
First of all, I was not sure what type of option.value is. I check the next code snippets and it was sth like string, I thought.
Based on this input, I think in order to convert string value into boolean, I simply used !! which will get true/false value from the strings.
Is Boolean() different from the above intention?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#discussion_r494205351, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKO62QFNGPT3YQ7ETFSHTLSHMNEBANCNFSM4RX2FKTQ.

I just checked and yes, it's the same functionality.
If so, I will suit myself to the codestyle that you've been using to keep
consistency.
Thanks for pointing that out.
On Thu, Sep 24, 2020 at 6:27 PM Tobi Abiodun<EMAIL_ADDRESS>wrote:

It’s the same. I was just wondering if you think it’s preferable to do
this way rather than the explicit cast
Get Outlook for iOShttps://aka.ms/o0ukef

From: Raymond Nguyen<EMAIL_ADDRESS>Sent: Thursday, September 24, 2020 6:26:08 AM
To: CrisisCleanup/crisiscleanup-3-web <
<EMAIL_ADDRESS>Cc: Tobi Abiodun<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: Re: [CrisisCleanup/crisiscleanup-3-web] Code Refactor (#983)
@raymondxd commented on this pull request.

In src/components/WorksiteFilters.vue<
https://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#discussion_r494205351

:

@@ -264,8 +264,9 @@

https://github.com/tabiodun thanks for your comment
First of all, I was not sure what type of option.value is. I check the
next code snippets and it was sth like string, I thought.
Based on this input, I think in order to convert string value into
boolean, I simply used !! which will get true/false value from the strings.
Is Boolean() different from the above intention?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<
https://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#discussion_r494205351>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/AAKO62QFNGPT3YQ7ETFSHTLSHMNEBANCNFSM4RX2FKTQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#issuecomment-698258747,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQEEWTQGYKUO6VZ2W32O54DSHMNKJANCNFSM4RX2FKTQ
.

Awesome. Thanks. Also thanks for all these updates. I’ll look to approve once I get up.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Raymond Nguyen<EMAIL_ADDRESS>Sent: Thursday, September 24, 2020 6:31:08 AM
To: CrisisCleanup/crisiscleanup-3-web<EMAIL_ADDRESS>Cc: Tobi Abiodun<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [CrisisCleanup/crisiscleanup-3-web] Code Refactor (#983)
I just checked and yes, it's the same functionality.
If so, I will suit myself to the codestyle that you've been using to keep
consistency.
Thanks for pointing that out.
On Thu, Sep 24, 2020 at 6:27 PM Tobi Abiodun<EMAIL_ADDRESS>wrote:

It’s the same. I was just wondering if you think it’s preferable to do
this way rather than the explicit cast
Get Outlook for iOShttps://aka.ms/o0ukef

From: Raymond Nguyen<EMAIL_ADDRESS>Sent: Thursday, September 24, 2020 6:26:08 AM
To: CrisisCleanup/crisiscleanup-3-web <
<EMAIL_ADDRESS>Cc: Tobi Abiodun<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: Re: [CrisisCleanup/crisiscleanup-3-web] Code Refactor (#983)
@raymondxd commented on this pull request.

In src/components/WorksiteFilters.vue<
https://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#discussion_r494205351

:

@@ -264,8 +264,9 @@

https://github.com/tabiodun thanks for your comment
First of all, I was not sure what type of option.value is. I check the
next code snippets and it was sth like string, I thought.
Based on this input, I think in order to convert string value into
boolean, I simply used !! which will get true/false value from the strings.
Is Boolean() different from the above intention?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<
https://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#discussion_r494205351>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/AAKO62QFNGPT3YQ7ETFSHTLSHMNEBANCNFSM4RX2FKTQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#issuecomment-698258747,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQEEWTQGYKUO6VZ2W32O54DSHMNKJANCNFSM4RX2FKTQ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#issuecomment-698260268, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKO62QVNZIEAGKM4K65UQDSHMNWZANCNFSM4RX2FKTQ.

My pleasure. Please leave more comments when you find any.
On Thu, Sep 24, 2020 at 6:33 PM Tobi Abiodun<EMAIL_ADDRESS>wrote:

Awesome. Thanks. Also thanks for all these updates. I’ll look to approve
once I get up.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Raymond Nguyen<EMAIL_ADDRESS>Sent: Thursday, September 24, 2020 6:31:08 AM
To: CrisisCleanup/crisiscleanup-3-web <
<EMAIL_ADDRESS>Cc: Tobi Abiodun<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: Re: [CrisisCleanup/crisiscleanup-3-web] Code Refactor (#983)
I just checked and yes, it's the same functionality.
If so, I will suit myself to the codestyle that you've been using to keep
consistency.
Thanks for pointing that out.
On Thu, Sep 24, 2020 at 6:27 PM Tobi Abiodun<EMAIL_ADDRESS>wrote:

It’s the same. I was just wondering if you think it’s preferable to do
this way rather than the explicit cast
Get Outlook for iOShttps://aka.ms/o0ukef

From: Raymond Nguyen<EMAIL_ADDRESS>Sent: Thursday, September 24, 2020 6:26:08 AM
To: CrisisCleanup/crisiscleanup-3-web <
<EMAIL_ADDRESS>Cc: Tobi Abiodun<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: Re: [CrisisCleanup/crisiscleanup-3-web] Code Refactor (#983)
@raymondxd commented on this pull request.

In src/components/WorksiteFilters.vue<

https://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#discussion_r494205351

:

@@ -264,8 +264,9 @@

https://github.com/tabiodun thanks for your comment
First of all, I was not sure what type of option.value is. I check the
next code snippets and it was sth like string, I thought.
Based on this input, I think in order to convert string value into
boolean, I simply used !! which will get true/false value from the
strings.
Is Boolean() different from the above intention?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<

https://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#discussion_r494205351

,
or unsubscribe<

https://github.com/notifications/unsubscribe-auth/AAKO62QFNGPT3YQ7ETFSHTLSHMNEBANCNFSM4RX2FKTQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#issuecomment-698258747
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AQEEWTQGYKUO6VZ2W32O54DSHMNKJANCNFSM4RX2FKTQ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<
https://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#issuecomment-698260268>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/AAKO62QVNZIEAGKM4K65UQDSHMNWZANCNFSM4RX2FKTQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CrisisCleanup/crisiscleanup-3-web/pull/983#issuecomment-698261325,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQEEWTSOM6BXOQHO2MCWLL3SHMN65ANCNFSM4RX2FKTQ
.

While waiting for @tabiodun's final review -- will try and solve some of these conflicts.

@raymondxd -- Oh, wow look at this. I must have missed it earlier.
VueTypes does still recommend eslint-plugin-vue -- readding that should resolve the ~600 default prop warnings I got running yarn lint.
What do you think?

@BradenM Thanks for pointing out about vue-types and eslint-plugin-vue-types.
I checked the documentation and yes, it was recommended to have eslint-plugin-vue-types when using vue-types.
I just added it back. Plz check.


feat: JSON Files Merging Script

What?
Add a function that helps in merging multiple json files that contains different algos or envs or tasks or seeds related to the same experiment setup in order to have a centralised json file that will be used in the plotting tools.
Why?
We often run experiments on different computes causing us to have the same benchmark experiments in different json files.

Closing because the same code is in #45 and it is easier to review only one PR.

This feature is handled in #45 therefore no need to merge this PR