Add releases/versioning

It would be great to start tagging versions of the bash-it to make it easier to know if we have the latest version available, rollback to an older version in case of issues, etc...
Thanks for this great project!

That's a nice suggestion, and something I've thought about myself, too. For some other projects I use Git Flow, with an unstable "develop" branch, and a stable "master" branch for releases.
For Bash-it, this might not be as easy as one might think, though. A couple of questions/food for thought:

What does a "version" mean for Bash-it? What goes into a release, and how do we decide when to cut a new release? Not sure whether a version number (like Bash-it v2.3.5) has a real meaning - what are the "rules" for what causes a major version increase, what a minor version, what a patch?
When someone creates a Pull Request for a bug fix or a feature request, and we merge that, do we always automatically create a new release for that? Or do we wait until we have collected a couple of changes and then create a release?
Version/Release management creates some overhead, someone would have to maintain the release numbers in GitHub, and sooner or later, people are going to ask for a change log or release notes. Someone needs to create/update/maintain all of this.

Thinking about these has so far stopped me from setting up proper releases for Bash-it. Every change (once merged) goes directly into the "master" branch, and people updating or cloning will always get the latest version.
Is there a compelling reason for having release numbers/versions that would make a particular task easier? Let's discuss...

It's just "nice" to know what you are "running" v1.0.23 and that the latest is v1.0.43... which means you know that you are "missing" 20 "updates" (although minors) and you can even check the changes through github's releases page.
The "overhead" is really minor : YOU as the project owner decide whether it makes sense to tag the master branch (which would be the one and only branch to tag), full stop. It only becomes an overhead if you want to maintain a changelog for every release...
right now it's :
Bash-it successfully updated.

Migrating your installation to the latest version now...

All done, enjoy!

or
Bash-it is up to date, nothing to do!

but there is not way to get back to the repo and check the changes... which i would love to be able to check!

I disagree that the overhead is minor for this. Right now the workflow is merge to master and folks can do a git pull if they want the latest changes with no overhead except pressing Merge as a maintainer. Adding a release process means we have to tag things and figure out what the flow to master should be. I think @nwinkler's question is still yet-to-be-answered:

Is there a compelling reason for having release numbers/versions that would make a particular task easier?

I could possibly make a case for having version numbers tied to dates and adopting a git-flow like merge to develop and release to master workflow. Then version numbers would be something like v17.09 and v17.10. Again though, I'm not sure what problem that solves.
Reading between the lines, I think you're after a little more feedback on what's happening @kbsali. How many updates are being applied, how far behind are you, and so on? I agree that some feedback on what is happening during bash-it update would be nice. Displaying something like the output of:
git log --merges HEAD...origin/master --format=%b

We could use that to get at the number of changes since your update as well. Taking it a step further, adding a [Y/n] prompt gives you the option to abort and jump into the specifics if you have questions. Right now running bash-it update requires a lot of trust. 😄

Great answer - thanks @tswicegood!

 :)
I believe it is a "common best practice" to version software and there are tools for automating the release process making the "overhead" minor (sorry to insist! ;)).
As you say @tswicegood "bash-it update requires a lot of trust" and the solution you propose (git log --merges HEAD...origin/master --format=%b) is an overhead for the user! :) Which is ok, I can live with it!
Btw, I see there are 66 issues opened, sometimes having releases would help spot if the user is running the latest version of bash-it or not.

No no no, please don't give up 😄 It's users like you that provide input and feedback to open-source projects, and projects like Bash-it rely on feedback - please keep the suggestions coming. Just because we don't agree 100% on something does not mean that you should stop with providing feedback.
There's a couple of things here:

Yes, I agree that adding a version number to software releases is a best practice - I follow that for most of my work. I see Bash-it as an exception for the reasons I've given above: It's not clear to me what constitutes a release or a version. If we had created a new release for each of the 600+ Pull Requests, we would have had to create and manage a lot of releases. Unless we come up with a good definition as to when to create a major, a minor or a patch release, I don't see an easy way out of this. Bash-it is not a logging library, or a database driver, where I'm really interested in the differences between the versions - for me, running the latest version of Bash-it is usually good enough. You seem to have a different need, and we should try to address that.
If there is a tool that makes creating/maintaining versions and releases on GitHub trivial, then please feel free to provide a link or a description to such a tool. If there is a tool that automatically creates a (meaningful) change log and creates a GitHub release, then I'm interested in seeing that - and we should consider using it.
I think you got @tswicegood's suggestion wrong. He was not suggesting that you run the git log command yourself. The way I understood it, we should add the output of git log (or similar) to the bash-it update command so that you get to see what is going to be updated.

Having said that, I think that the problem is more complex. You're probably not interested in seeing a list of commits, but rather want a meaningful change log that shows the changes in high-level terms, for example "Added a plugin for garblefoo" instead of the 17 commits that were done for adding the insanely complex garblefoo plugin. Right?
I'm more than happy to discuss the requirements with you, and I'm sure that we can come up with some meaningful and useful additions. We'll have to balance the administrative overhead, of course...
Reopening, since I find the discussion interesting and would like to learn more about what you're looking for.

Re-reading your last sentence, would it make sense to include something like "There have been XX commits in the master branch since you last updated Bash-it" as part of the bash-it update command, and then a link to the "commits" page on GitHub? At least as a starting point...

No no no, please don't give up 😄 It's users like you that provide input and feedback to open-source projects, and projects like Bash-it rely on feedback - please keep the suggestions coming. Just because we don't agree 100% on something does not mean that you should stop with providing feedback.

💯  * 👍

I think you got @tswicegood's suggestion wrong. He was not suggesting that you run the git log command yourself. The way I understood it, we should add the output of git log (or similar) to the bash-it update command so that you get to see what is going to be updated.

Yeah! I'm thinking the workflow goes like:
$ bash-it update
There are 3 updates to apply…
Update or view the details? [Y/v/n] v
  - Add plugin for acme widgets
  - Update git completion
  - New theme called awesomeness
Apply? [Y/n] Y
All done, enjoy
$

That could be done by the user right now, but I think we should do it as part of update – possibly with a -y|--yes flag that continues the current behavior.

@tswicegood is awesome! :+1:

The question is how we get from the list of commits (which might be rather verbose) to a concise list of changes like shown in your example?

No need to change anything. Merge commits via PR produce a great changelog. Against current master, I ran git reset --hard 2742adbe, then ran this command:
$ git log --merges --format="  - %b" HEAD...origin/master
  - Update brew completion
  - Move enabled components to a global directory
  - Fix execution of trap DEBUG on subshells

The two key things here are --merges which only shows merge commits (i.e., the way we merge PRs), and --format="  - %b" which updates to show only the body message. By default the commit message for PRs merged contains the subject with the PR # and such and the title as the body. To that end, I'm gonna change the settings to only allow merge commits of PRs so we have this as an option.
If you wanna get fancy, you can do some fun stuff with awk and prefix all of those with the PR # and such too.

That's great - no need to squash commits or anything! Since we're using Push Requests for changes, every change to master should result in a merge and will show up in this log - cool!

I would like to see tags on the repo, even if they simply marked points in time as Bash-it involves. Maybe you could tag on the first day of each month?
Use case: https://github.com/embark-framework/embark-docker/blob/master/Dockerfile
I'm specifying dependency versions in a Dockerfile to aim for reproducible builds (well, as reproducible as possible when it comes to this kind of thing).  I could download a commit-specific gzip'd tarball for Bash-it from GitHub, but that's a bit of a hassle, and there's no option for git-cloning a specific commit. So, currently, I'm leaving Bash-it un-versioned. I could fork and create tags myself, might end up doing that.

@michaelsbradleyjr Thanks for the request - I understand the requirement and the desire to have a tagged version available at all times.
Unfortunately, I don't have the time to go through this process each month... Are you aware of an automated way of doing this?

Here's what the current implementation of bash-it update looks like:
$ bash-it update
544a092: Show upgrades before blindly upgrading (Travis Swicegood)

Would you like to update to 544a092? [Y/n]
Bash-it successfully updated.

Migrating your installation to the latest version now...

All done, enjoy!```


Phoenix 1.5.0 Compatibility

Phoenix 1.5.0 has been released in April. Would it be possible to update scrivener to provide compatibility with the new version ?

Yes! Is this hard work, or simply dependencies upgrade?

Relevant pull requests:

Phoenix 1.5 by geofflane · Pull Request #98 · mgwidmann/scrivener_html

relax deps to allow phoenix 1.5 by jaimeiniesta · Pull Request #97 · mgwidmann/scrivener_html

We might need to organize a fork of this project; see:

Maintenance Help · Issue #103 · mgwidmann/scrivener_html

The master branch has been updated a few days ago to add compatibility: https://github.com/mgwidmann/scrivener_html/pull/97


Blot speed changes depending on active tab

https://github.com/hackclub/blot/assets/5891442/179f6a49-4169-42c5-9db5-0edca71274dd

This is interesting. Today when using Arc I can tab away without issue, but when Zoom goes fullscreen the blot fully stops. I wonder if there's a browser setting we can recommend people enable if they're doing this sort of thing


:bulb: Recommendation Engine (Spotify).

Idea Contribution

[X] I have read and agree to follow this project's Code of Conduct.

Tell us about your idea.

[x] Implement Recommendation.
[x] Recommendation engine notebook.

Anything else?
No response

Done.


Leading Zeros

I am having problems with Chrome, as it will not except jwk generated by rsa-pem-to-jwk due to leading zeroes in some parameters. Currently it is the "n" parameter that the issue but I think I have seen other parameters causing problems depending on the key.

@keean Do you have an example key that reproduces this issue?

Tracking @keean's comment on chromeium issue tracker:

{"kty":"RSA","n":"APDbvfbCVXxvQFOCV2yHO4P9pZTZBG79sNo2k1PTwXWJd_T_-wCBuO14fQtTkcQRfFhZYx6wy6TEvzLUFmtNJ7X4iuRe2Jzf-hntk2i1huz93HAY67N6w0mUYtAp1S9rZdXisgAFgDeVUhjhBV1r4_KmvGRFojQwuIRymAHHF2nr","e":"AQAB"}

This is the error Chome gives me:
DOMException: The JWK "n" member contained a leading zero.

This is the code that generates the keys:
var fs = require('fs')
, ursa = require('ursa')
, rsa_pem_to_jwk = require('rsa-pem-to-jwk')
;
function add_answer_key(state) {
return new Promise(function(succ, fail) {
console.log('generating answer key');
//var key = ursa.generatePrivateKey(8192);
var key = ursa.generatePrivateKey(1024);
console.log(key);
var pem = key.toPrivatePem();
state.public_key = JSON.stringify(rsa_pem_to_jwk(pem, {}, 'public'));
state.private_key = JSON.stringify(rsa_pem_to_jwk(pem, {}, 'private'));
succ(state);
});
}
function write_private_key(state) {
return new Promise(function(succ, fail) {
fs.writeFileSync(state.file + '_private.jwk', state.private_key);
succ(state);
});
}
function write_public_key(state) {
return new Promise(function(succ, fail) {
fs.writeFileSync(state.file + '_public.jwk', state.public_key);
succ(state);
});
}
var state = {file: 'test1'};
add_answer_key(state)
.then(write_private_key)
.then(write_public_key)
.catch(function(e) {
console.error(e);
});

I am using Chromium, Version 47.0.2526.16 (64-bit).

The last two weeks I've spent a lot of time trying to figure out issues just like this one.
It turns out that BigInts use a leading '0x00' to indicate that the number is positive if the high-order bit (0x80) is set.
Because I've had a ton of trouble over the years trying to cobble together the mismatch one-off libraries (or wrangle the ultra large ones), I finally came around to creating my own solution as a small, lightweight set of libraries that are tested and have the same APIs:

Rasha.js (for RSA)
Eckles.js (for ECDSA)

Whereas before it would have been a major headache to get everything (JWK, PEM, SSH, CSR) together, now node has proper RSA and EC support (since v10.12) and the leftover bits that aren't native are only a few hundred lines of code (about 550 lines each) across a small number of files.

var Rasha = require('rasha');

Rasha.import({ pem: '...' }).then(function (jwk) {
  console.log(jwk);
});


BS 1.37 update

Hello! I've compiled a version of this plugin for Beat Saber 1.37. I was wondering if I could get your permission to post this amazing plugin in the BSMG discord (Beat Saber Modding Group) so that it become available to more people. Thank you!

Thank you for your pull request.
We will confirm that it works and release it.
Posting to the BSMG discord is OK.
I am not good at English and have not seen much BSMG, so it would be helpful if you could introduce me.
Thank you in advance.


Unable to list empty albums

Could add a parameter to allow us to get albums even if they are empty. For example:
PhotoGallery.listAlbums(
      mediumType: MediumType.video,
      hideIfEmpty: false,
    )

Added hideIfEmpty parameter to be able to show empty albums on version 1.0.1, but it's only available on iOS. I don't find the way to achieve this on Android.


Set-TppAttribute uses int and not string for 'config/Write'

When developing the Add-TppAdaptableHash function, which uses Set-TppAttribute, the result back from adding a new secret store entry is a VaultID number. This is interpreted by Set-TppAttribute as an [int] type when passed to both 'config/WritePolicy' and 'config/Write'. It appears that when 'config/WritePolicy'  is used, the value passed in the Values parameter has to be a string for it to work, or a 500 error is generated.
It would probably be the best approach to make sure the parameters used for both endpoints are cast to be strings, to avoid this kind of issue.

Changing the title as from testing in Postman, it's 'config/Write' that fails with the 500 error. Am also opening a ticket on the Venafi side for this to see if we can find out what is the correct behaviour

@wilddev65 were you able to find out the correct behavior?

Nope, was added to JIRA and doesn't appear anyone looked at it.


Add events service page

Update the layout and navbar styling of the website, as well as adding new constants . The changes include:

Updated layout to be more responsive and optimized for larger screens.

Added new constants for easier maintenance

Added the events service page and it's associated components

On the hero section i was thinking maybe you could reduce font size a little bit such that it does not cover the entire screen.

Will fix that tomorrow, thank you


A way to filter down cards based on authors and collaborators

Especially as multi-author webs become more common

The userID string is fine, but ideally it would be the pretty version of it in the future

The filter should be like author/ID_STRING and collaborator/ID_STRING where ID_STRING is either a single ID, or ID1+ID2 or me (the signed in user's ID)

[ ] authors with single
[ ] authors with multiple
[ ] authors with me
[ ] a link from author title cards to filter to their cards


Revert "realtime_tools: 1.12.0-0 in 'melodic/distribution.yaml'"

Reverts ros/rosdistro#17924.  This caused breakage with downstream consumers of these packages.

same comment as https://github.com/ros/rosdistro/pull/17934#issuecomment-391035129


No transformed depth images at NFOV

Describe the bug
I am getting transformed depth images at WFOV mode, but the NFOV images are not transformed , so there is no color map geometry.
Screenshots
This is the  transformed depth image at WFOV with the following settings

    device_configuration = K4A_DEVICE_CONFIG_INIT_DISABLE_ALL;
    device_configuration.color_format             = k4a_image_format_t::K4A_IMAGE_FORMAT_COLOR_BGRA32;
    device_configuration.color_resolution         = k4a_color_resolution_t::K4A_COLOR_RESOLUTION_720P;
    device_configuration.depth_mode               = k4a_depth_mode_t::K4A_DEPTH_MODE_WFOV_2X2BINNED;
    device_configuration.synchronized_images_only = true;
    device_configuration.wired_sync_mode          = k4a_wired_sync_mode_t::K4A_WIRED_SYNC_MODE_STANDALONE;
    device.start_cameras( &device_configuration );

This is the"transformed" depth image at NFOV (it is the same with any binned, unbinned  setting
)

    device_configuration = K4A_DEVICE_CONFIG_INIT_DISABLE_ALL;
    device_configuration.color_format             = k4a_image_format_t::K4A_IMAGE_FORMAT_COLOR_BGRA32;
    device_configuration.color_resolution         = k4a_color_resolution_t::K4A_COLOR_RESOLUTION_720P;
    device_configuration.depth_mode               = k4a_depth_mode_t::K4A_DEPTH_MODE_NFOV_2X2BINNED;
    device_configuration.synchronized_images_only = true;
    device_configuration.wired_sync_mode          = k4a_wired_sync_mode_t::K4A_WIRED_SYNC_MODE_STANDALONE;
    device.start_cameras( &device_configuration );

To Reproduce
I am using the following code: https://github.com/UnaNancyOwen/AzureKinectSample/blob/master/sample/cpp/transformation/kinect.cpp from @UnaNancyOwen
Desktop (please complete the following information):
Ubuntu 18.04

SDK Version:  1.4

Is this a bug or isn't NFOV supported. If WFOV has worked, I don't see any hindrance with NFOV
Thanks for your help

I thought about it and I think the transformation works and is correct in your pictures.
I think transformation does not mean, that you should get a rectangular image after it. Only that the image looks like it was taken from the perspective of the color camera, so its origin/coordinate system is the one from the color camera.
The reason you have a rectangular image at WFOV is because the depth image covers a larger area than the color camera. So every color pixel you will have overlap with the depth image.
At NFOV this is not the case. The depth image is smaller than the color image, so the transformed image can't be rectangular. It would have no depth information at the outer areas.
You can see the overlap of the different modes in the documentation:
https://docs.microsoft.com/en-us/azure/kinect-dk/hardware-specification#camera-field-of-view

Thank you  for your answer, it clarified my question!


Expenses - Reimbursable checkbox is still shown when doing Create from Map

Reproducible in production?: Yes
TR link** Exp https://expensify.testrail.io/index.php?/cases/view/2567325
Expected Result:
The Reimbursable checkbox is hidden as the setting is "Always non-reimbursable"
Actual Result:
The Reimbursable checkbox is shown and defaults to Reimbursable
Action Performed:
Precondition: Have the "Cash expenses are" set to "Always non-reimbursable" in Workspace Expenses setting

Go to Staging.Expensify.com
Go to Expenses page
Click "New Expense" - "Create from Map"
Enter addresses and click "Save"
Click "Save" in New Expense modal
Click the newly created Distance Expense

Workaround:
Unknown
Notes/Images/Videos
https://github.com/user-attachments/assets/e4b2843c-210d-44af-a28a-f8d4a207c99a

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @akinwale

@bfitzexpensify Can you please upload the video again, I can't load the video in the OP. Thanks.


Task: Fix the auto assign GitHub action, so that if the other issue has a pull request attached, it allows for further assignment of multiple issues as long as each issue has a pull request

The code is here https://github.com/OWASP/BLT-Action/blob/main/src/index.js

The code is here https://github.com/OWASP/BLT-Action/blob/main/src/index.js

@DonnieBLT  thank you sir, it's very much clear now☺

now this issue is closed by #12


Update expired cert

What is the purpose of the change
Update expired client.pem.
Brief change log
Update client.pem.
Add new client.pem to jks store.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The runtime per-record code paths (performance sensitive): (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

/run-all-tests


Add identity methods for #sum and #product

This patch adds additive_identity and multiplicative_identity to types that support addition and multiplication, respectively.
Enumerable#sum and #product use those methods to determine the initial value if none is provided. They previously relied on zero and zero + 1 which works only for numerical arithmetics.
I didn't include a fallback to zero or zero + 1 if the new methods are not available. There's probably no way to add a warning for that be cause zero method itself is not deprecated. So it should just break hard instead of continue to work for a while. It doesn't make sense to support zero in the long term, so we should just drop it directly. I wouldn't expect many custom types rely on sum + zero behaviour.
Some optimizations are also included:

Enumerable#sum for String element type delegates to #join
Array#sum for Array element type delegates to #flatten

Resolves #10126

Is it really appropriate to use the recursive #flatten here when #+ performs only one level of flattening?

The #product change is unlikely to break anything because with zero + 1 it was very much limited to simple numeric types.
Motivation for the breaking change was #sum no longer using .zero, but that actually still works as a fall back. So probably not really a breaking change.

The #product change is unlikely to break anything because with zero + 1 it was very much limited to simple numeric types.
Motivation for the breaking change was #sum no longer using .zero, but that actually still works as a fall back. So probably not really a breaking change.


Fix json panic

Thanks to @mxpetit for the report.

coverage: 99.865%. remained the same when pulling 83bafbc5ab3f15e45b21cbddf2be90f60581f3a5 on fix-json-panic into 6a1fb6b46b618048b3d254a7d09deecf6432583d on master.


fix file command py

'self' was Commands, instead of the file instance

Description
WIP fix, not a real fix for now

Motivation and Context
check_duplicate_operation, log_operation and others are broken right now

How has this been tested?
badly

Screenshots (if appropriate)
Types of changes

Changes visible to users:

[x] Bug fix (prefix: fix - non-breaking change which fixes an issue)
[ ] New feature (prefix: feat - non-breaking change which adds functionality)
[ ] Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)

Internal changes:

[ ] Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
[ ] Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
[ ] Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

[x] My code follows the code style of this project and passes yarn run lint.
[ ] My change requires a change to the documentation.
[ ] My change works!

Fixed by https://github.com/Josh-XT/Agent-LLM/pull/150


Additional Action buttons

Add a panic button to the interface that will stop the robots immediately.
Add a set base state for accelerometers in the interface.
Add an override muse concentration for non-success cases.

Fixed in #14


Bug: If line wraps, SGR reset does not clear attrs after content

Environment
Windows build number: Microsoft Windows [Version 10.0.18362.295]
Windows Terminal version (if applicable): latest master

This is a little tricky to describe--please bear with me.
I've given the example repro using pwsh, but I have also checked with plain C++ code, compiled and then run from cmd, and it's still a problem (so pwsh/PSReadLine are not interfering).
Steps to reproduce

Create a string "s" with SGR sequences that sets foreground to red, and background color to white, and then at the end of the string an SGR reset (which should set fg and bg back to their defaults: gray on black).
Write the string to the console, and observe that it works as expected. After the content, the rest of the line (to the window edge) is black.
Now make the string longer by just adding content in the middle... long enough that it will wrap.
Write the string to the console, and observe that it works differently. After the end of the content, the rest of the line (to the window edge) is white.

Expected behavior:
The behavior should be the same, whether or not the line wraps. And I think the current behavior in the non-wrapping case seems correct.
Actual behavior:
If the line wraps, the altered background color inexplicably shows up after the end of the content, to the end of the line.
Example repro:
$csi = "`e["
$fgRed = "${csi}91m"
$bgWhite = "${csi}107m"
$reset = "${csi}0m"

$s = "default ${fgRed}fg red ${bgWhite}bg white, no wrapping${reset} (courtesy reset)"

$s

$s2 = "default ${fgRed}fg red ${bgWhite}bg white, this content should be long enough to cause the line to be wrapped blah blah blah blah blah blah blah blah blah blah blah${reset} (courtesy reset)"

$s2

Picture:

And actually, it gets weirder: if I tweak the string's length such that the wrap occurs in the middle of the "courtesy reset" portion of the content... the bug does not repro.

This is to be expected. When the content wraps at the bottom of the viewport it causes the buffer to scroll up, and the newly revealed line is filled with the current background color, which is white. If you cleared the screen before outputting the s2 you'd see the end of the line with a black background.
For comparison, here's a similar test case in an XTerm shell on Ubuntu. Notice that it's only the last occurrence (where the screen has scrolled) that has the white background at the end of the line.

Whoa! Yep, that seems to explain it. Thanks @j4james !


Add back responsive gutters

We had the responsive gutters in Alpha.6 which was extremely helpful. If we are going full responsive and supporting multiple resolutions, why not keep the responsive gutters?
$grid-gutter-widths: (
  xs: $grid-gutter-width-base,
  sm: $grid-gutter-width-base,
  md: $grid-gutter-width-base,
  lg: $grid-gutter-width-base,
  xl: $grid-gutter-width-base
);

Duplicate of #22944. As they were implemented, it generated extra and inaccurate markup.

@mdo
Do I get it right? This feature is removed and it will not be available in the final version?


Pull request for master

Discover the clone url of pagure repository
Name the remote to push with the host type

Ho, that's weird, my last PR was sent to the new location. Here is the log of this one:
Forked repository: https://github.com/TristanCacqueray/git-pull-request
Fetching origin
Rebasing branch `master' on branch `origin/master'
Current branch master is up to date.
Force-pushing branch `master' to remote `github'
Enumerating objects: 16, done.
Counting objects: 100% (16/16), done.
Delta compression using up to 8 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 1.91 KiB | 1.91 MiB/s, done.
Total 9 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4), completed with 3 local objects.
To https://github.com/TristanCacqueray/git-pull-request.git
   e4d50c4..c541814  master -> master
Pull-request created: https://github.com/jd/git-pull-request/pull/1


data directory is assumed to start at root instead of current directory

Describe the bug
data directory is assumed to start at root instead of current directory.   The issue is encountered from runexamples.sh which downloads the data into current directory and then untars into ./workspace.  However,  the following code from tutorials/3d_classification/torch/densenet_evaluation_array.py  with leading "" is replaced with / at run time.
    data_path = os.sep.join(["", "workspace", "data", "medical", "ixi", "IXI-T1"])

Proposed change is to use . as below (or make it a command line argument)
    data_path = os.sep.join([".", "workspace", "data", "medical", "ixi", "IXI-T1"])

To Reproduce
Steps to reproduce the behavior:

setup the environment

conda create --yes --name monai python=3.8
conda activate monai
git clone https://github.com/Project-MONAI/tutorials
cd tutorials
pip install -r requirements.txt

run ./runexamples.sh

./runexamples.sh
Running 3d_classification/torch/densenet_training_array.py
MONAI version: 0.6.0
Numpy version: 1.21.1
Pytorch version: 1.9.0
MONAI flags: HAS_EXT = False, USE_COMPILED = False
MONAI rev id: 0ad9e73639e30f4f1af5a1f4a45da9cb09930179

Optional dependencies:
Pytorch Ignite version: NOT INSTALLED or UNKNOWN VERSION.
Nibabel version: 3.2.1
scikit-image version: 0.18.2
Pillow version: 8.3.1
Tensorboard version: 2.4.1
gdown version: 3.13.0
TorchVision version: 0.10.0
ITK version: 5.1.2
tqdm version: 4.42.1
lmdb version: 1.2.1
psutil version: 5.8.0
pandas version: 1.3.1
einops version: 0.3.0

For details about installing the optional dependencies, please visit:
    https://docs.monai.io/en/latest/installation.html#installing-the-recommended-dependencies

Traceback (most recent call last):
  File "3d_classification/torch/densenet_training_array.py", line 142, in <module>
    main()
  File "3d_classification/torch/densenet_training_array.py", line 67, in main
    im, label = monai.utils.misc.first(check_loader)
  File "/opt/miniconda3/envs/monai/lib/python3.8/site-packages/monai/utils/misc.py", line 73, in first
    for i in iterable:
  File "/opt/miniconda3/envs/monai/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 521, in __next__
    data = self._next_data()
  File "/opt/miniconda3/envs/monai/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1203, in _next_data
    return self._process_data(data)
  File "/opt/miniconda3/envs/monai/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1229, in _process_data
    data.reraise()
  File "/opt/miniconda3/envs/monai/lib/python3.8/site-packages/torch/_utils.py", line 425, in reraise
    raise self.exc_type(msg)
FileNotFoundError: Caught FileNotFoundError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File "/opt/miniconda3/envs/monai/lib/python3.8/site-packages/nibabel/loadsave.py", line 42, in load
    stat_result = os.stat(filename)
FileNotFoundError: [Errno 2] No such file or directory: '/workspace/data/medical/ixi/IXI-T1/IXI314-IOP-0889-T1.nii.gz'

Expected behavior
expect the examples to run
Screenshots
see above
Environment (please complete the following information):

OS osx
Python version 3.8
MONAI version [e.g. git commit hash]
CUDA/cuDNN version N/A
GPU models and configuration N/A

Additional context
Add any other context about the problem here.

Hi @yiheng-wang-nv ,
Could you please help take a look this ticket?
Thanks in advance.

I am making couple of mods to improve testing.   Feel free to assign this to me as I am in a process of making changes.

On Aug 1, 2021, at 10:42 AM, Nic Ma @.***> wrote:
Hi @yiheng-wang-nv https://github.com/yiheng-wang-nv ,
Could you please help take a look this ticket?
Thanks in advance.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Project-MONAI/tutorials/issues/297#issuecomment-890532560, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQFY5G24X3TNQWAF7JKMCLT2VMO5ANCNFSM5BLGLIHQ.


Update specs2-core, specs2-scalacheck to 4.10.2

Updates

org.specs2:specs2-core
org.specs2:specs2-scalacheck

from 4.8.3 to 4.10.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2" } ]

labels: test-library-update, semver-minor

Superseded by #206.

Superseded by #206.


Fix broken imports due to fastcore changes

delegates was moved to fastcore.meta

#43 go their first I'm afraid. Plus were locking fastcore to the version before these were introduced in #39


Add auto merge

@conda-forge-admin, please add bot automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/flask-pymongo-feedstock#2.


confused TrackedObject‘s speed direction

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
in map_based_prediction_node.cpp,  the code
// assumption: the object vx is much larger than vy
if (object.kinematics.twist_with_covariance.twist.linear.x >= 0.0) return;
seems not correct, as the vx and vy is not aways >= 0  in  map/world coordinates system;
at same time, vx may not necessarily be the main direction
Expected behavior
Clearer definition of coordinate systems
Actual behavior
confused TrackedObject‘s coordinates system
Steps to reproduce
see code about use of twist
Versions
No response
Possible causes
No response
Additional context
No response

@YoshiRi
Could you take a look at this?

Let me share the background:

The object twist and acceleration are represented in the object frame (Not in map frame. Sorry, I think this information should written in somewhere.)
updateObjectData is used to fix object orientation so that the planning module do not consider negative velocity

So the code intention is that normally vehicle lateral motion won't be faster than longitudinal one.
I think we need to add the custom message description to somewhere in our document.
@xunkaixin
Was this what you want to discuss about?

perfect, thanks. the document is important


Set contain to limit on grandparent, rather than direct parent.

Hello! I have some panzoom images inside a div which is inside a wrapper. How do I set it so contain blocks the image from moving outside the grandparent, rather restricting it inside the parent?
example markup:
Goal: contain panzoom within wrap, rather than parent

You can do this by overriding $parent on the panzoom instance...
var instance = $elem.panzoom('instance');
instance.$parent = $('.wrap');
instance.resetDimensions();

It will then use wrap's position/dimensions for the container.


Move sdc library back to HAPI structures

Yeah that's right @joiskash - HAPI formats the JSON output slightly differently. We can look into JSON formatters if this becomes an issue.


Caller.py Spotify API GET /search bug if multiple types as params of caller agent output

If the output of the caller agent looks something like:
Caller:
Operation: GET
Input: {
"url": "https://api.spotify.com/v1/search",
"params": {
"q": "Mariah Carey",
"type": "track,album",
"market": "US",
"limit": "20",
"offset": "0",
"include_external": "audio",
"order": "popularity desc"
}
}
Which is valid according to the Spotify OAS, the current code in caller.py will fail because it can't handle multiple values for "type": "track,album". I am going to raise a pull request to fix this.

@Yifan-Song793 @WeiminXiong @nightdessert & @Jdelbarcogarza circling back on this issue I raised a few weeks ago. Looking forward to hearing some feedback. Thank you!


initialRouteParams not being passed to initial scene for StackNavigator

I'm having an issue where this.props.navigation.state.params remains undefined for the initial scene in a StackNavigator, even though I'm passing initial params through initialRouteParams.
Minimal example to reproduce included:
import React from 'react';
import {
  AppRegistry,
  Text,
} from 'react-native';
import { StackNavigator } from 'react-navigation';

class HomeScreen extends React.Component {
  static navigationOptions = {
    title: 'Welcome',
  };

  render() {
    const { state } = this.props.navigation
    return <Text>{state.params.someParam}, Navigation!</Text>;
  }
}

const ReactNavigationTestCase = StackNavigator({
  Home: { screen: HomeScreen },
}, {
  initialRouteName: 'Home',
  initialRouteParams: { someParam: 'Bonjour' }
});

AppRegistry.registerComponent('ReactNavigationTestCase', () => ReactNavigationTestCase);

Sorry, I missed the pull request fixing this exact issue (#150) . Closing now!

Hey @mauritsd, I wasn't able to get this to work, even when pulling from you master branch of the library.
What I'm trying to do is pull in a prop set in launchOptions when the app starts and then have that accessible in my initial scene.
I created an issue to tackle this directly as well at #634.
Any help would be really great.
Thanks!
Josh

can you guys please give a solution which works for react-navigation-3 in which you must set up your app container directly.


Price grabber creation of cache table is very slow and may be causing site slowness and bot issues

Specifically this is taking minutes or even longer:
INSERT INTO cache (`time`, name, price, low, high, week, month, season)
SELECT
    MAX(`time`) AS `time`,
    name,
    MIN(CASE WHEN `time` =<PHONE_NUMBER> THEN price ELSE 999999 END) AS price,
    MIN(price) AS low,
    MAX(price) AS high,
    SUM(CASE WHEN `time` ><PHONE_NUMBER> AND price = 1 THEN 1 ELSE 0 END) / SUM(CASE WHEN `time` ><PHONE_NUMBER> THEN 1 ELSE 0 END) AS week,
    SUM(CASE WHEN `time` ><PHONE_NUMBER> AND price = 1 THEN 1 ELSE 0 END) / SUM(CASE WHEN `time` ><PHONE_NUMBER> THEN 1 ELSE 0 END) AS month,
    SUM(CASE WHEN `time` ><PHONE_NUMBER> AND price = 1 THEN 1 ELSE 0 END) / SUM(CASE WHEN `time` ><PHONE_NUMBER> THEN 1 ELSE 0 END) AS season
FROM low_price
GROUP BY name;

We should either make it faster or do it another way or sacrifice some granularity or older data.

As of right now I've turned OFF price grabbing. So if everything becomes great starting now we know we've found our culprit. If nothing has improved in 24 hours I'll start looking elsewhere. I think it's ok to miss 24 hours of pricing date to find out easily.

Already feels like this was definitely the case.

From this:
https://stackoverflow.com/questions/45176506/how-to-improve-performance-of-an-insert-into-select-x-from-y-group-by-z-mysql/45176852#45176852
I got a >6x speedup on local (from 1m 17s to 13s). Prod takes 8m to do the query local takes 77s so the implication is this would take the runtime down to 80s on prod. That might be good enough.

Production speedup is >16x! Woo!
Query OK, 15684 rows affected (8 min 59.61 sec)
=>
Query OK, 15684 rows affected (33.94 sec)
Restarting price grabbing on prod and we'll keep an eye on it!
Woop!

Awesome


CSS properties not working?!?

When i try to edit my css, adding clip-path, display, transform and some other variables, my waybar closes and it tells me its an invalid property

First line in this section of the documentation says:

GTK is used to apply styles and works with a limited subset of CSS.


fix: prevent video from overflowing or having no width

🎯 Goal

Fix regression bug that reduced video width in both MessageList and Thread to 0. The media width was set back to width: 300px instead of max-width: 300px.
Prevent videos from overflowing in thread.

🎨 UI Changes

:tada: This PR is included in version 2.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


bottombar overlapping navigation drawer

I was trying to implement bottombar with android default navigation drawer. It's working nice but left navigation drawer is going under bottombar on slide,  I can't figure out what is the problem, how to fix it?

@b2cbd are you able to resolve this overlapping issue?

@azeemchaudhrry Yes, you need to put bottom bar layout as a first child of drawer layout in your xml file.

@b2cbd Hi, would you please share your xml code? I'm still having that same problem. Thank you so much.

@Zukune this might help you.
xml:

C#:
_bottomBar = BottomBar.Attach(content_layout, savedInstanceState);

@azeemchaudhrry  Thank you for your reply but cannot resolve method Attach. Do u have any idea of this? Thank you

if you are using in native android then go attach().
above code is for xamarin I am using this library in xamarin.

@Zukune
`

<LinearLayout
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:id="@+id/nav"
    android:orientation="vertical"

    <include layout="@layout/toolbar"
        android:id="@+id/toolbar"/>

</LinearLayout>

<android.support.v4.widget.DrawerLayout
    android:id="@+id/drawer_layout"
    android:layout_below="@+id/nav"
    android:layout_width="match_parent"
    android:layout_height="match_parent" >

    <RelativeLayout
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:layout_marginTop="1dp">

        <com.roughike.bottombar.BottomBar
            android:id="@+id/bottomBar"
            android:layout_width="match_parent"
            android:layout_height="55dp"
            android:layout_alignParentBottom="true"
            android:background="@color/main_color_500"
            app:bb_activeTabAlpha="1"
            app:bb_inActiveTabAlpha="0.6"
            app:bb_activeTabColor="@android:color/white"
            app:bb_inActiveTabColor="@android:color/white"
<EMAIL_ADDRESS>            app:bb_showShadow="false"
            app:bb_tabXmlResource="@xml/menu_bottombar" />

        <FrameLayout
            android:id="@+id/container"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:layout_above="@id/bottomBar"/>

    </RelativeLayout>

    <FrameLayout
        android:id="@+id/content_frame"
        android:layout_width="match_parent"
        android:layout_height="match_parent" />

    <include
        android:layout_width="@dimen/drawer_width"
        android:layout_height="match_parent"
        layout="@layout/list_view"
        android:layout_gravity="start"/>
</android.support.v4.widget.DrawerLayout>

`

@azeemchaudhrry @b2cbd Thank you guys for your help, it's working now.


Lists concatenattion

Hi, how can I join (concatenate) two lists in helm templates? I've found no option in sprig or go templates libs...

closing as inactive.

use concat
https://helm.sh/docs/chart_template_guide/function_list/#concat


Remove withOnyx HOC from BaseUserDetailsTooltip

Coming from here
Problem: When using the lists like LHNOptionList or OptionList, each Avatar is wrapped by tooltip that shows basic information about the user. It becomes very problematic on large datasets, where lists are rendering multiple avatars. BaseUserDetailsTooltip is wrapped by withOnyx hoc, getting the full list of personalDetails for each avatar, and then using lodashGet to get user details based on user ID passed to the component. For large personal details lists it seems like a big overhead since it gets the full list from Onyx each time and then gets only one record from thousands of objects. This calculations are done for each tooltip in the app, which means if user is scrolling through a long list, it reaches Onyx for data and filters it for each element.
Solution: To avoid that, we should remove withOnyx from BaseUserDetailsTooltip and instead pass the required data about the user by props. With this solution, the personalDetails can be accessed from Onyx just once. This solution will affect all the occurencies of the tooltips displaying user data. I did a quick PoC on the OptionList component and noticed reduced amount of blank spaces while scrolling the list on a heavy loaded account. During the measurements it also helped to reduce rendering time of a tooltip from ~200ms to ~15ms. Looks like it would also have a positive impact on performance of LHNOptionList.

Hi, I'd like to work on this issue

Proposal for discussion: https://github.com/Expensify/App/pull/30333

aSsigning you both, could you cross review your PRs

still discussing

Not overdue, looking for internal volunteer to take this one on

After internal discussion I was about to come back to the issue and prepare my #30432 PR to be open, but noticed that in the meantime my proposal became obsolete as the similar change was already introduced in #30354. Closing my PR then.
cc @mountiny

Thank @TMisiukiewicz for working on this!

Going to close this and scope out a migration plan elsewhere as discussed here: https://expensify.slack.com/archives/C05LX9D6E07/p1701331185944559?thread_ts=1701278908.602239&cid=C05LX9D6E07

I just realized that we should just keep this open and look for an internal champ for fixing this.
Adding https://github.com/Expensify/App/pull/30333

I think we can keep this closed for


Github tests fail: "Error:  We have duplicated artifacts attached." with jboss-parent 40

Pull request #48 fails to run the automated test:
[INFO] --- maven-source-plugin:3.3.0:jar-no-fork (attach-sources) @ wildfly-jakartaee-ear-archetype ---
[INFO] Building jar: /home/runner/work/wildfly-archetypes/wildfly-archetypes/wildfly-jakartaee-ear-archetype/target/wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT-sources.jar
Error:  We have duplicated artifacts attached.

....
Error:  Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork (attach-sources) on project wildfly-jakartaee-ear-archetype: Presumably you have configured maven-source-plugn to execute twice times in your build. You have to configure a classifier for at least on of them. -> [Help 1]

This happens with the commandline mvn install verify, but not with mvn clean install.
It seems to be caused by the upgrade from maven-source-plugin 3.1.0 to 3.3.0 in jboss-parent 40 (https://github.com/jboss/jboss-parent-pom/pull/188).
When using 3.1.0, there is just a warning:
[INFO] --- source:3.1.0:jar-no-fork (attach-sources) @ wildfly-jakartaee-ear-archetype ---
[INFO] Building jar: C:\Temp\github\wildfly-archetypes\wildfly-jakartaee-ear-archetype\target\wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT-sources.jar
[WARNING] artifact org.wildfly.archetype:wildfly-jakartaee-ear-archetype:java-source:sources:30.0.0.Final-SNAPSHOT already attached, replace previous instance

The most simple workaround could be to remove the "maven-sources-plugin", because I think there is no reason to deploy a sources jar file with the archetype:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-source-plugin</artifactId>
    <configuration>
        <skipSource>true</skipSource>
    </configuration>
</plugin>

What do you think?

After fixing the previous issue, on my windows machine the "install verify" command fails to execute the next step with this error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-archetype-plugin:3.2.1:integration-test (default-integration-test) on project wildfly-jakartaee-ear-archetype:
[ERROR] Archetype IT 'multi' failed: java.io.IOException: File C:\Temp\github\wildfly-archetypes\wildfly-jakartaee-ear-archetype\target\test-classes\projects\multi\project\multi\build.log unable to be deleted.

The file is not locked afterwards, I can delete it without problems. So this seems to be a maven problem? Maybe related to the previous problem?

@jmesnil Pulling you in, as you did all the recent changes ;-)

@WolfgangHG thanks for the heads up, I'll have a look

Closing it. "verify" goal was removed.


feat: Support pagination in issue-list screen and pull-list screen

Question
Response

Version?
v1.6.0

Devices tested?
iPhone 6 Simulator

Bug fix?
no

New feature?
yes

Includes tests?
no

All Tests pass?
yes

Related ticket?
#751

Screenshots

Description

Support pagination in issue-list screen and pull-list screen
Clean useless old codes
Fix bugs caused by store refactoring

one is during fetching pull request details, caused by #775
stop converting entity ids to lower cases, see https://github.com/gitpoint/git-point/issues/826#issuecomment-434563624, cc @machour

Sadly, the ability to show different colors between closed and merged pull requests, see #852, is broken. Because the search API always returns state closed. I will open an issue to record it and hope someone can implement later.

Coverage decreased (-1.4%) to 48.895% when pulling 224e8647a6a334f67fe827d688cb4d94b82ebfe2 on chinesedfan:paginate-repo-related into 2d17c522093ade3b47741161cbc70a6d0233cc02 on gitpoint:master.


Improvise project structure with cookiecutter

fixes #12

@iamareebjamal What are the main things which I should remove?

Everything related to webpack and templates

https://www.thefreedictionary.com/improvise

Hello @Haider8! Thanks for updating this PR.

In the file oscarine_api/public/views.py:

Line 3:1: F401 'flask.current_app' imported but unused
Line 3:1: F401 'flask.render_template' imported but unused
Line 3:1: F401 'flask.request' imported but unused
Line 12:1: F401 'flask_login.login_user' imported but unused

@iamareebjamal Should I also remove all the npm commands?

Yes

@iamareebjamal I have updated the PR. There are still some things which aren't needed like bcrypt and flask-caching, so should I remove all those? Secondly, the tests are to be written for the new code. Should I open new PR for that or do it here only? I have one doubt also, is the current way to list the requirements is right as far as detection by dependabot is concerned?

Flask caching and bcrypt are fine. Tests should be done in a separate PR
Yes, requirements are good


Styled-components not recognise the variable inside the media theme

Guys, recently I encountered problems like this:
WORK case:
    ${media.breakpointDown(media.sm)`
      height: 50px;
    `}

NOT WORK case:
    ${media.breakpointDown(media.sm)`
      height: ${wrapperHeightMobile};
    `}

wrapperHeightMobile = "50px" has been passed in via props
Thanks

theme ?
    ${media.breakpointDown(media.sm)
height: ${({ theme }) => theme.wrapperHeightMobile};
}
props:
    ${media.breakpointDown(media.sm)
height: ${(props) => (props.wrapperHeightMobile)};
}
https://styled-components.com/docs/basics#adapting-based-on-props


Removed dash from SID generation

IAM policies have a restriction on characters in the SID field and don't allow dashes (https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_sid.html). I've removed the dash from the SID generation during rolegen.

LGTM. Thanks!


Installation

Hi,
I just submitted an issue in the old repo about the cursor jumping to the wrong line in case of compilation errors (it reads the column number from the error, and not the line number).
I then saw that a pull request was made, and that this repo was born. Now my real question is : As I install through package control, when I search for ElixirFormatter, how do I know that this package is installed, and not the one in the unmaintained repository? As both readme files declare the same name.
Thank you.

Ok so I found in the Package Control website that this is the repo corresponding to the package.

@lud just as a clarification for this, we took over the package name, since the original was defunct.

That is what I supposed, thank you for making it clear!


Would be nice if mocha sets the NODE_ENV variable to 'test'

Pretty handy if different middlewares / configs etc. in Express or such is needed when running the test suite.

i dont want to force it on anyone, but you can easily just do NODE_ENV=test mocha etc or add it a makefile etc

fair enough!

One of the advantages of not having this set by default is when writing tests for apps that run in many different environments. For example, one app that I develop has an additional set of tests that it runs on a staging server (NODE_ENV=staging) when it has access to production quality data. As the DB config and the logging transports all depend on that env variable, mocha overwriting it would cause some issues.
-1 on this.

Just to clarify I meant an implementation where NODE_ENV would default to test but could be overwritten. However setting it through a Makefile is good enough for me. I just don't want to type NODE_ENV=test mocha everytime :)

for sure. i always have make test since i dont even really want to go look up the mocha config or anything, mocha.opts gets around most of that but still

A possible workaround, assuming you're running mocha from the same terminal every time, would be:
$ export NODE_ENV=test
$ mocha
NODE_ENV will persist through every command that runs in that window.

As far as I know NODE_ENV=test mocha doesn't work on Windows, neither does make.

It would be nice to have a simple --env option so you can write tests that don't depend on a specific platform.

@felixfbecker - for windows,  set NODE_ENV=test && mocha

Sure but then the same command will not work on *nix systems, if you want to put it in your npm test script

@felixfbecker @tswaters have you checked env-test?

That only works for NODE_ENV though and relying on values of NODE_ENV is bad practice. See http://12factor.net/config

I know this is super super old, but cross-env (https://www.npmjs.com/package/cross-env) takes care of the windows issue.

@halkeye Good tip, thanks.

I am one of those people that always runs raw mocha because I like to --grep single tests. To me this is a fundamental aspect of Test Driven Development, which in turn is a fundamental approach to software development. The suggestions to use make or npm (which do not pass on the --grep arg) betray a lack of awareness or indeed interest in a TDD approach. Which is somewhat ironic, given this is all about a prominent testing tool.

npm run test -- --grep whatever will work fine
Also you can use https://www.npmjs.com/package/env-test and add requires env-test to your mocha.opts too
There's lots of options out there.

But should someone that doesn't know that npm run test -- --grep whatever works, then goes straight to mocha, be penalised?
Mocha itself should be the one championing idempotency. The env-test plugin is the only real solution here.

Since this still seems to get a lot of traffic I thought I would throw out a relatively simply solution for people like me who wish there was a --env flag.  What I've been doing is add a test/mocha.env.js file in the repo, and then add --require test/mocha.env.js to mocha.opts:
// mocha.opts
--require babel-register
--require test/mocha.env.js
--timeout 60000

// mocha.env.js
process.env.NODE_ENV = 'test';

Per @jasonk, the same approach works in TypeScript:
// In mocha.opts
--require test/mocha.env
...

// In mocha.env.ts
process.env.NODE_ENV = 'test';

Guys, cannot get what do you mean by "There are plenty of other ways to get this done" https://github.com/mochajs/mocha/issues/185#issuecomment-54729812.
I have simple requirement my CI&CD should be able to change env variables for TEST/STAGE/PROD, how it would do it? Change .env file on flight? Or how?

Okay, I had to do this way (within package.json script section):
"test": "HEADLESS=$HEADLESS URL=$URL mocha -A --recursive tests -t 10000"
So it means that it will pass URL and HEADLESS params to mocha.
Examples of use:
HEADLESS=false URL=http://example.com npm run test

@tombh

But should someone that doesn't know that npm run test -- --grep whatever works, then goes straight to mocha, be penalised?

Yeah, and it can get even worse than that for people who do know that trick.  For instance in Sequelize I had to use two double dashes because it has npm scripts running other npm scripts:
npm run test-postgres -- -- --grep sheesh
Further more, the test-postgres script is something like
DIALECT=postgres npm run test-unit && npm run test-integration which means that only test-integration receives the options.

Actually whoops I mistakenly thought this issue was about getting options from a MOCHA_OPTS environment variable, I googled for that and skimmed to quickly

Another idea: if you use mocha's config JavaScript file you can just put it there:
.mocharc.js:
process.env.NODE_ENV = 'test';

module.exports = {
  require: 'ts-node/register/transpile-only',
  extension: ['ts'],
  watchExtensions: ['ts'],
  spec: ['test/**/*.test.ts'],
}

since node 20.6.0: use "node-option" to natively load an env file.
.mocharc.json:
{
	"ui": "bdd",
	"node-option": ["import=tsx", "env-file=.env.test"],
}


[2.3.1] Runtime error in prod build. Dev runs clean.

I'm getting an error when running the production build. I do a:
yarn run build
yarn run start

and the server comes up fine. But when I hit it, I get this:
TypeError: store.getState is not a function
    at ApolloClient.setStore (/Users/jay/code/freightslayer-next/node_modules/apollo-client/apollo.umd.js:3473:44)
    at /Users/jay/code/freightslayer-next/node_modules/apollo-client/apollo.umd.js:3308:23
    at /Users/jay/code/freightslayer-next/node_modules/redux/lib/applyMiddleware.js:49:16
    at Array.map (native)
    at /Users/jay/code/freightslayer-next/node_modules/redux/lib/applyMiddleware.js:48:27
    at createStore (/Users/jay/code/freightslayer-next/node_modules/redux/lib/createStore.js:65:33)
    at createReduxStore (/Users/jay/code/freightslayer-next/build/dist/config/modules/apollo-redux.js:154:45)
    at Function._callee$ (/Users/jay/code/freightslayer-next/build/dist/config/modules/apollo-redux.js:179:34)
    at tryCatch (/Users/jay/code/freightslayer-next/node_modules/regenerator-runtime/runtime.js:65:40)
    at Generator.invoke [as _invoke] (/Users/jay/code/freightslayer-next/node_modules/regenerator-runtime/runtime.js:303:22)

If I view the store object at the point of the exception, it looks like this:
{
  getState: undefined,
  dispatch: [Function: dispatch]
}

When the code is run in the dev server, the same object looks like:
{
  getState: [Function: getState],
  dispatch: [Function: dispatch]
}

Anyone have any insight into this?

We can't tell anything without looking at code.
Could you give us any sample code to test with?

Please re-open this issue after that.


Issue with faqs-with-keywords.json

Hi, I have used the faqs-with-keywords.json sample json in my sharepoint list. It has worked well but when I have tried to add an additional field from my list into the json, the data from that field does not show. However, when I change view and switch back to the view I have used on the JSON, the data appears. I want to use the json view within a sharepoint page but cant if the data randomly disappears. Any ideas on what could be causing this data to randomly disappear? Thanks.
When data has disappeared

When data appears as expected

@adamhastie
Have you checked the additional field is included in your custom view?
List settings -> scroll down -> select your custom view and checkboxes corresponding to the included/excluded fields

I think that may have solved it! Rookie error. Thanks for the help

@Fedes365 Thank you for answering!!!!
I'll close this issue since it appears to be solved!


how to build sql with "OR", "LIKE" word.

example:
SELECT a FROM table WHERE b = 1 OR c = 1
SELECT a FROM table WHERE b = 1 AND c = 1 AND (d like "dd" OR e like "ee")

builder.build({
  type: 'select',
  table: 'table',
  fields: ['a'],
  condition: {
    $or: [
      { b: 1 },
      { c: 1 }
    ]
  }
});

builder.build({
    type: 'select',
    table: 'table',
    fields: ['a'],
    condition: {
        b: 1,
        c: 1,
        $or: [
          { d: { $like: 'dd' } },
          { e: { $like: 'ee' } }
        ]
    }
});

Thanks
first one worked.
second seem something error.
sql.query show follow
select "a" from "table" where "b" = 1 and "c" = 1 and ("d" like $p1 or "e" like $p2);
$p1 $p2  replace the 'dd' and 'ee'

miss separatedValues : false option

OK, but it is not safe coz separatedValues: false enable potential SQL injections.

if set separatedValues : true, how to use sql text with "$p1 $p2" ,I use node msql(npm install mysql)
I didn't want potential SQL injections. :(


Improve handling of light and dark backgrounds

REDMINE-17746

Coverage remained the same at ?% when pulling d4e05fe5952f1b4ece41bee5a5fbb42417c77455 on tf:dark-background into 26edc7f8b8fabc3a37a5a183cecebb428b7a23cd on codevise:master.


Filtering by an empty object returns nothing

CrateDB version
latest, 5.3.0
CrateDB setup information
No response
Problem description
No response
Steps to Reproduce
cr> CREATE TABLE a (o OBJECT);
CREATE OK, 1 row affected  (0.298 sec)

cr> INSERT INTO a VALUES ({});
INSERT OK, 1 row affected  (0.009 sec)

Actual Result
cr> SELECT * FROM a WHERE o = {};
+---+
| o |
+---+
+---+

Expected Result
cr> SELECT * FROM a WHERE o = {};
+----+
| o  |
+----+
| {} |
+----+

Can I work in this?

Hi @karenhernandeze, sure, I assigned the issue to you. Thanks for your interest!
Just reflecting on the probably root cause: empty objects are not in the index and we have to do the full scan in such special cases. = are handled by EqOperator and for empty objects in should fall to genericFunctionFilter/full scan.
This would an entry point for investigations.

Hi @karenhernandeze, do you need help with this?


Add visual command arrow to sim visualization

The simulation needs a visual indicator (green arrow) showing the commanded direction/velocity of the robot. E.g. visual linear velocity commands (x,y) and angular velocity/heading commands.

This is awesome

plz link to branch


Add MatchStrategyFactory Test

Task
add test
Task List:

[ ] Add  MatchStrategyFactoryTest to test  MatchStrategyFactory

Please read the Contribution Guideline before submitting the PR

I wanna do this, please assign me

please to<EMAIL_ADDRESS>

I can do this task , please assign to me

please to<EMAIL_ADDRESS>
Done,  Very happy to be able to participate


[requires.io] dependency update on master branch

[Current coverage][cc-pull] is 25.50%

Merging [#11][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #11   diff @@
==========================================
  Files            14         14
  Lines           698        698
  Methods           0          0
  Messages          0          0
  Branches         73         73
==========================================
  Hits            178        178
  Misses          520        520
  Partials          0          0

Powered by Codecov. Last updated by [05ccce2...fc665df][cc-compare]
[cc-base-branch]: https://codecov.io/gh/pypa/linehaul/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/pypa/linehaul/compare/05ccce26929a42a6284ede5ed59c4840e2806f61...fc665dfca96ea4b932ec38cc7d2255cc0031319a
[cc-pull]: https://codecov.io/gh/pypa/linehaul/pull/11?src=pr


Issue credits to Omo

Issue 5000 credits to @Omoaholo.

 Follow up
On Thursday, 14-Mar-24 23:48:29 UTC by Gov4Git dev
Issued 5000 credits to member @omoaholo.


#1-model implementation

resolves #1

TODO:

[ ] fix off-by-one pixel issue (problem is that the first conv layer does not yield an image of full pixels but with a decimal number, pytorch then uses the floor function to round down basically, therefore this cannot be reconstructed by the transpose layer)
[ ] deconv "forward" - propagate max activation feature map
[ ] deconv layer initialization
[ ] add method to disable deconv mode
[ ] double check model implementation and module order
[ ] add proper initialization method (pytorch default is usually not a proper way, at least there are better ones)
[ ] stick to python naming conventions and fix formating issues
[ ] improve forward cache handling (e.g. use clear function, update function)
[ ] add all but only necessary classes to the module init file


fix: resolve nuget transitive reference problems

This uses the poorly documented buildTransitive folder to enable packages to correctly include build targets.
Closes #1490.
I've tested this locally, and it behaves correctly when used from VS and command line (dotnet add ...).

That's sounds very promising! I've spent hours looking for this! It looks like it does not work for source dependency, but if it works for nuget PackageReference, this is great news!


fix(ios): copyTo should overwrite any existing file (CB-6938)

https://issues.apache.org/jira/browse/CB-6938
Platforms affected
iOS, all versions.
What does this PR do?
It fixes CB-6938.
Instead of returning an error 12 (PATH_EXISTS_ERR), it tries to remove the existing file, then to copy the "new" one.
What testing has been done on this change?
Simulator: iPhone 5 and iPhone 6 @ iOS 9, 10.
Real device: iPhone 5 @ iOS 10.
No unit test provided nor written.
Checklist

[X] Reported an issue in the JIRA database
[ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

Hey, I just fixed the problem that caused Android tests to fail in master. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR.

Rerun with current test configuration.

CI: Once more please.


Passing multiple certs for CA validation

It would be nice that requests allowed passing multiple certs for CA validation. It might be for reason or another be unfeasible to merge CA certs into one bundle. In comparison stdlib ssl you can run load_verify_locations arbitrary amount of times to load more certificate locations.

Requests absolutely does allow that, you just need to concatenate your various certs together into one file that you then pass to verify.

Yeah, I was meaning without concatenating your certs together in one file. That's specifically what load_verify_locations called multiple times avoids. That's especially useful on Windows since the system certificate store is not a file but a binary storage accessed through an API.

@nanonyme Currently we can't achieve this: we just don't have the primitives. At the very least we would need shazow/urllib3#507 to get merged before this is even possible.
Additionally, the stdlib SSL module only allows this for some versions: specifically, those with SSLContext objects. That limits it to 2.7.9 and later, which is problematic.
Finally, of course, this doesn't solve the Windows problem since Windows users can't point OpenSSL at a file period, they need another solution.
Altogether, I think this is just too niche a request to satisfy at the moment. It seems like it would make life easier for a tiny minority of users, but that minority would be just as well served by a merge of sshazow/urllib3#507 and then playing with SSLContext objects.
Thanks for the suggestion, though! Please keep them coming. =)


Button example is not working correctly

Bevy version
#7598, but on my fork so I recommend checking it for yourself.
Relevant system information
Rust version: 1.67.0
OS: Windows 10
What you did
cargo run --example button
What went wrong
The hovering works correctly, but when I press the button it doesn't react until I move the cursor or release the mouse button.
Additional information
It works without the WinitSettings::desktop_app() resource, so I expect the bug to be related to it.

Hi there. I have encountered this bug too. It happens with bevy 0.11.0 on windows 11 but on web it works.
After fiddling around I have made this band-aid fix :
fn redraw_on_button_action(mut redraw: EventWriter<RequestRedraw>) {
    redraw.send(RequestRedraw);
}

which is then used:
        .add_systems(
            Update,
            redraw_on_button_action.run_if(move |mouse_button_input: Res<Input<MouseButton>>| {
                                mouse_button_input.just_pressed(MouseButton::Left) || mouse_button_input.just_released(MouseButton::Left)
            }),
        )

(button press check can be moved inside the system)
I think it's caused by difference on mouse input handling between platforms...


Speeding up loading of large projects

Doing some timing tests, I found it currently takes the CCLE project page ~15 seconds to load. While this may not seem like much, it is 15 seconds every time the project page is loaded, making it quite slow for users to go to the CCLE project page, check out a sample, go back to the CCLE project page, check out a different sample, and so on.
CCLE is just 329 samples. For TCGA or PCAWG (each ~2500 samples), or Genomics England (>16,000 samples), the load time for the project page will become far too long.
The timing tests revealed that the longest part of this process (~14 seconds) is the following lines of code:
    dfl = []
    samples = df['Sample_name'].unique()
    for sample in samples:
        project, sample_info = get_one_sample(project_name, sample)
        dfl.append(pd.DataFrame(sample_info))

    aggregate = pd.concat(dfl)

The call to get_one_sample is relatively expensive since it iterates over the entire set of samples and finds the one with the matching name.
        current = runs[sample_num]
        if len(current) > 0:
            if current[0]['Sample name'] == sample_name:
                 sample_out = current

We will need to optimize this process greatly to accommodate larger-scale datasets.

Fix was relatively simple, and is implemented in #97. Reduces loadtime of the CCLE project page from 15s to 1-2s (critical step reduced from 14s to 0.6s).


[SPARK-18752][hive] "isSrcLocal" value should be set from user query.

The value of the "isSrcLocal" parameter passed to Hive's loadTable and
loadPartition methods needs to be set according to the user query (e.g.
"LOAD DATA LOCAL"), and not the current code that tries to guess what
it should be.
For existing versions of Hive the current behavior is probably ok, but
some recent changes in the Hive code changed the semantics slightly,
making code that sets "isSrcLocal" to "true" incorrectly to do the
wrong thing. It would end up moving the parent directory of the files
into the final location, instead of the file themselves, resulting
in a table that cannot be read.
Tested with existing unit tests and also ran some Hive integration tests
with a version of Hive containing the changes that surfaced the problem.

Test build #69757 has started for PR 16179 at commit f1e09f4.

Test build #69757 has finished for PR 16179 at commit f1e09f4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69757/
Test FAILed.

Hmm, those tests passed locally... let me rebase.

I think I know what the problem is, this will require some test changes.

Test build #69805 has started for PR 16179 at commit 93e07db.

Test build #69805 has finished for PR 16179 at commit 93e07db.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69805/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #69817 has started for PR 16179 at commit 93e07db.

Test build #69817 has finished for PR 16179 at commit 93e07db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69817/
Test PASSed.

 Even its documentation is a little self-contradictory (https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DML). It says the path can be a URI, but if "LOCAL" is defined, it's always a local path. I'd have to try it on Hive but right now I'm kinda swamped with other things.

To answer the first question:
> load data local inpath 'hdfs:/user/systest/data.csv' into table test;
Error: Error while compiling statement: FAILED: SemanticException [Error 10028]: Line 1:23 Path is not legal ''hdfs:/user/systest/data.csv'': Source file system should be "file" if "local" is specified (state=42000,code=10028)

For the second question ("load data" with "file" URI) it seems to move the file from the local file system to the warehouse (as the Hive doc I linked above sort of suggests).

https://issues.apache.org/jira/browse/HIVE-6024
Based on the above JIRA, Hive has an interal change. Do we need to add the related test cases to VersionSuite like what we did for CTAS in https://github.com/apache/spark/pull/16104?

@gatorsmile that is not the change that surfaced the problem. Again, this change is not to work around a bug in Hive. This change is because Spark is doing things incorrectly, and we were just lucky to not hit this problem before. Hive is correct. Spark is not. Thus the change.
The changes that actually surface the problem are in Hive 2.1, which Spark does not yet support (officially at least?) as a metastore client.
Internally we have patches from Hive 2.1 in our Hive, so we started seeing this problem. Because Spark is behaving incorrectly, it's better to fix it to avoid future issues.
VersionSuite is not meant to capture these things; it's meant to make sure the HiveShim reflection code is doing the right thing for the various versions of Hive. In fact, it's not the test that failed for us (the "InsertIntoHiveTable" did).

I can understand the existing way is not correct and we should use LOCAL in LOAD DATA command for populating the value of isSrcLocal. However, we also introduce behavior changes in InsertIntoHiveTable.
After the changes, we always set isSrcLocal to false for InsertIntoHiveTable. These temporary data files in staging directory of InsertIntoHiveTable will be moved to the table location instead of copying to the table location. Is that right?
VersionSuite is also being used for testing end-to-end behaviors in https://github.com/apache/spark/pull/16104. In the future, we need to add more test cases to ensure the support of all the Hive versions. I think this is the right thing we should continue.
BTW, I am also trying to see whether the test case coverage of our LOAD DATA is complete or not.

After the change these temporary data files in staging directory of InsertIntoHiveTable will be moved to the table location instead of copying to the table location. Is that right?

It depends. Without this change, it would depend on where the table was. If the table was in HDFS (or anything but the local FS), the files would be moved, so the behavior doesn't change. If the table was in the local filesystem, before this change the files would be copied, and later deleted when the staging directory was deleted. So in the end, it's the same thing.
With the change, the data would be moved in both cases, which is also correct and leads to the same result.
I just want to reinforce, again, that this is not about a change in behavior in Hive at all. This is Spark using a Hive API incorrectly.

VersionSuite is also being used for testing end-to-end behaviors in #16104.

I'm not sure that's such a great idea, but in any case, the tests for this change are the existing tests in "InsertIntoHiveTableSuite" and "HiveCommandSuite". So basically you'd be asking to run those against all different version of Hive metastores supported by Spark. It's doable, but that's a bigger change that I don't really think is necessary here. The Hive semantics haven't changed. Spark was depending on undocumented behavior that worked out of luck, and this change fixes that.

The changes LGTM, as we do propagate the isSrcLocal incorrectly. It would be better if we can also fix the inconsistent behavior of LOAD DATA between spark and hive, and improve the test coverage, in a follow-up

This PR is fixing an issue exposed in Hive 2.1. I am not very clear why Hive 2.1 made such a change. If we can know the background of this change, it might be easier for us to judge whether this is the only issue after the change. At least, I am thinking this PR does not make it worse. I am OK about this PR.

This PR is fixing an issue exposed in Hive 2.1.

No. This PR is fixing a misuse of an internal hive API. It's important to understand that there's nothing wrong in Hive here, that it's Spark that is using Hive's internal API incorrectly and that it's safer for Spark to not do that.

If it makes it easier for you to understand why this has nothing to do with Hive 2.1, look at the unit test changes. They show that Spark was behaving differently from Hive in that particular situation ("LOAD DATA" with a warehouse in the local file system - Hive would move the source file, Spark would copy it and leave it around).

Test build #69973 has started for PR 16179 at commit a8482a5.

Test build #69973 has finished for PR 16179 at commit a8482a5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69973/
Test PASSed.

Test build #69976 has started for PR 16179 at commit b451a70.

Test build #69976 has finished for PR 16179 at commit b451a70.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69976/
Test PASSed.

LGTM except 2 minor comments: https://github.com/apache/spark/pull/16179#discussion_r91852909 and https://github.com/apache/spark/pull/16179#discussion_r91846277

Test build #70030 has started for PR 16179 at commit 4e37c80.

Test build #70030 has finished for PR 16179 at commit 4e37c80.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70030/
Test PASSed.

LGTM

Merging to master. Thanks!

Should we merge it to Spark 2.1? cc @vanzin @rxin @cloud-fan

Maybe after 2.1.0 goes out? It's not really a critical fix.


feat(analytics): add "letUsKnow" and intro buttons tracking

References #637 LiveURL: https://smartfaq-add-more-analytic-events.surge.sh

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add option to build without Windows DLL Generation

Hey there!
This PR includes the following changes:

Fixed the history functionality to exclude empty strings.

Added an option to build without Windows DLL Generation in Dockerfile, resulting in a smaller image size:

REPOSITORY               TAG               IMAGE ID       CREATED        SIZE
reversessh/reverse_ssh   latest            7435eccd4b80   2 hours ago    1.84GB
reversessh/reverse_ssh   onlylinux         b10cc132c478   2 hours ago    942MB

Also, please note that to build without Windows DLL Generation, you can use the following command:
docker build --build-arg WINDOWS_SUPPORT=false . -t reversessh/reverse_ssh:onlylinux

Hi there.
Thanks for your pull request.
I have a few questions/statements.
The docker container is designed to have all the features of the rssh server readily available to anyone. Without having to manually build or tweak.
So it seems a little counter to that goal to have an important feature disabled.
If folks want they can reduce their own docker images if that's required for them
Secondly.
Love the qol/bug fix for the history on the command line, makes a huge deal of sense and I can't believe I didn't think of doing that.
However I'd prefer if you split this out into it's own pr as its not nothing to do with the windows dll generation.
Also bumping dependency versions in this is also not something that should be here.
More than happy to do that bit myself or have a seperate pull request if bumping the deps would include something important like a security patch/ssh feature like the ssh-rsa v2 key support.
Long story short:

without further justification I don't think having a toggle for the dll generating in the docker image fits the goal of the docker image
the history bug fix is good and id like to see that in its own pr

Thanks for your feedback!
Regarding the Windows DLL Generation feature, the default Docker image will still include all features, but users can now build the image without it by using the --build-arg WINDOWS_SUPPORT=false flag.
Regarding the fix for the history functionality, I'm glad you like it. I understand your point that it is not directly related to the Windows DLL generation, but I included it in the same pull request because it was a small change and I thought it made sense to group them together. However, I can create a separate pull request for it if you prefer.
For the dependency updates, I understand your concern and will create a separate pull request if there are any security patches or important SSH features.
Let me know how you would like to proceed. Best regards.


Remove "in Kubeflow" from "Multi-Tenancy"

See #2465

@Bobgy can you please approve? :)

/lgtm
/approve
Thank you！


Unable to run on Windows because of uvloop dependency

Dear authors,
I was excited to try your application for my work with high-dimensional EMG data, but unfortunately your dependency on the server's use of "uvloop" does not allow me to use it on Windows, because the library does not support Windows itself. As far as I can tell, there is only one line where the dependency is used. Would it be possible to substitute this with something that is more cross-platform friendly?
I'd be happy to hear from you.

Hi, thank you for pointing out this issue. Several months ago I tried to support Windows. But, I still was not able to find enough time to support Windows (Windows is quite different from UNIX/Linux, and supporting it needs a lot of effort for preparing the environment, testing, etc).  Realistically, I cannot find time to support Windows for the next few months.
So, if you want to try the web app soon, please try to use Linux with a virtual machine environment on your windows.

Hi, finally, I supported Windows.


Syntax Highlighting optional class variable in type definition file.

Issue Type: Bug
VSCode syntax highlighting breaks when it encounters an optional class level variable in a type definition (.d.ts) file.
The example below is a simplified version of what I was seeing in one of my emitted type definition files.
When pasting this block into a .d.ts file, you should see the variables "private readonly" below where test2?; is declared in the TestClient turn from the expected dark blue to a light blue, or the same color as the variable name.  This has reaching affects throughout the file and causes other things below it to be improperly rendered. I've provided the TestClient2 definition to show a simple case of it.
// test.d.ts
export declare class TestClient {
    private readonly test1;
    private readonly test2?;
    private readonly test3;
    private readonly test4;
}

export declare class TestClient2 {
    private readonly test1;
    private readonly test2;
    private readonly test3;
    private readonly test4;
    private readonly test5;
}

VS Code version: Code 1.25.1 (1dfc5e557209371715f655691b1235b6b26a06be, 2018-07-11T15:43:53.668Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3592)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.94GB (8.78GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

tslint
eg2
1.0.34

vsliveshare
ms-
0.3.504

vscode-icons
rob
7.24.0

Opened https://github.com/Microsoft/TypeScript-TmLanguage/issues/642 and https://github.com/Microsoft/TypeScript-TmLanguage/issues/643 to track this upstream


SWARM-1222: Fix security web xml detector and add security fraction detection test.

[X] Have you followed the guidelines in our Contributing document?
[X] Have you created a JIRA and used it in the commit message?
[X] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[X] Have you built the project locally prior to submission with mvn clean install?

Hi @bobmcwhirter @Ladicek. Although code could be a bit simpler in WebXmlDescriptorScanner.java I preferred adding those checks just in case the inputstream passed to method is changed at some time , to avoid coupling between method parameters and what we are expecting. That's why I added checks for any inputstream. Hope it makes sense.

I don't understand what does this do, and I don't really understand the uncloseable stream stuff. If that's because we need to read from the stream multiple times, then maybe we can switch from using an input stream to a string?

Hi @Ladicek. There is already a consistent API across all detectors that is using inputstream etc. Additionally, changing API would require much more changes than these ones AFAIK.

BTW @Ladicek , about the uncloseable stuff I added an explanation in commit, "Motivation" section:
"Modifications
After fixing security detector, other bug arised, because shrinkwrap utility class for parsing web.xml (Descriptors) was closing the stream, which caused error when a second webxml fraction detector was executed (for example, JSFServletDetector and SecurityWebXmlDetector). In order to fix that, it was need to use inputstream that needed 2 requirements:
1-Not closing stream just in case any used tool was doing it without asking for it (like Descriptors class).
2-Enabling support for marking inputStream, as we need to "rewind" stream to the initial point so next webxml fraction detectors is chain could do their job.
Although the new inputstream with previous requirements (UncloseableBufferedInputStream) was added at the generic scanning method (we need the same inputstream so we can reset to the beginning of the stream), it shouldn't affect other detectors that doesn't use mark and reset. These features are used in SecurityWebXmlDetector, though, where we mark the inputstream each time, so we can reset the stream if it reached its end (stream.available ==0)"

Said that, @bobmcwhirter @Ladicek it's true that changing the utility that parses web.xml from Shrinkwrap's Descriptors to other (custom or available third party library) would avoid adding that UncloseableBufferedInputstream useless. If both of you want me to implement such a thing, just let me know. Just wanted to keep the same existing code if possible.

Ah, sorry @juangon, I didn't read the commit message. Thanks.
Frankly, I still think if we need to read the content multiple times, then we shouldn't be using InputStream but something like String, byte[] or Supplier<InputStream>. But I just tried to understand the fraction autodetection code and failed (again), so I'm not trying to guess how much work that would be.
I don't think we should avoid Descriptors, no.

So I took the time to go through the fraction detection code once more and this PR started to make sense to me. But with the uncloseable stuff -- we'll be leaking resources, no?
Here's a branch https://github.com/Ladicek/wildfly-swarm/commits/stop-passing-around-inputstreams where I replaced passing around InputStreams by passing around InputStreamSuppliers. Just for Scanners -- the FractionDetectors don't need that. @juangon What do you think, would something like this work?

Thanks Ladislav! I am checking it...

@Ladicek -- added you as the reviewer.  Once you approve, you can merge (or I will).

@bobmcwhirter I was able to check @Ladicek pull request with some slightly modification and it works, but I have the feeling that API is "asking us to move to other side". I am trying moving some parts to Scanner as I think it makes more sense. I did that yesterday but it isn't working properly, I am fixing that now. After fix I think each part will do the job it should be. Hope to finish it today or tomorrow...Sorry!

Should this be closed in favor of the other PR?

Yes @kenfinnigan. Closing this one, let's focus on https://github.com/wildfly-swarm/wildfly-swarm/pull/514


Failed building wheel for pypandoc

I followed option 2 to build deposit-cli with native Python and when running pip3 install -r requirements.txt I get the following error
Requirement already satisfied: click==7.1.2 in /usr/lib/python3.9/site-packages (from -r requirements.txt (line 40)) (7.1.2)
Requirement already satisfied: six==1.15.0 in /usr/lib/python3.9/site-packages (from -r requirements.txt (line 69)) (1.15.0)
Requirement already satisfied: cached-property==1.5.2 in /usr/lib/python3.9/site-packages (from -r requirements.txt (line 72)) (1.5.2)
Collecting cytoolz==0.10.1
  Downloading cytoolz-0.10.1.tar.gz (475 kB)
     |████████████████████████████████| 475 kB 26.1 MB/s
Collecting eth-hash==0.2.0
  Downloading eth-hash-0.2.0.tar.gz (6.9 kB)
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-586xffq7/eth-hash_020bb57e28a44f19bbc4d3e79e0bc476/setup.py'"'"'; __file__='"'"'/tmp/pip-install-586xffq7/eth-hash_020bb57e28a44f19bbc4d3e79e0bc476/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-yjcmt6lh
         cwd: /tmp/pip-install-586xffq7/eth-hash_020bb57e28a44f19bbc4d3e79e0bc476/
    Complete output (47 lines):
    WARNING: The wheel package is not available.
    WARNING: The wheel package is not available.
      ERROR: Command errored out with exit status 1:
       command: /usr/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-wheel-owzcy7da/pypandoc_c852620a913c4fe2ba30d4ba9e324535/setup.py'"'"'; __file__='"'"'/tmp/pip-wheel-owzcy7da/pypandoc_c852620a913c4fe2ba30d4ba9e324535/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-3yyqv2s3
           cwd: /tmp/pip-wheel-owzcy7da/pypandoc_c852620a913c4fe2ba30d4ba9e324535/
      Complete output (8 lines):
      no pandoc found, building platform unspecific wheel...
      use 'python setup.py download_pandoc' to download pandoc.
      usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
         or: setup.py --help [cmd1 cmd2 ...]
         or: setup.py --help-commands
         or: setup.py cmd --help

      error: invalid command 'bdist_wheel'
      ----------------------------------------
      ERROR: Failed building wheel for pypandoc
    ERROR: Failed to build one or more wheels
    Traceback (most recent call last):
      File "/usr/lib/python3.9/site-packages/setuptools/installer.py", line 75, in fetch_build_egg
        subprocess.check_call(cmd)
      File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
        raise CalledProcessError(retcode, cmd)
    subprocess.CalledProcessError: Command '['/usr/bin/python', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmp4s796e19', '--quiet', 'pypandoc']' returned non-zero exit status 1.

    The above exception was the direct cause of the following exception:

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-586xffq7/eth-hash_020bb57e28a44f19bbc4d3e79e0bc476/setup.py", line 44, in <module>
        setup(
      File "/usr/lib/python3.9/site-packages/setuptools/__init__.py", line 152, in setup
        _install_setup_requires(attrs)
      File "/usr/lib/python3.9/site-packages/setuptools/__init__.py", line 147, in _install_setup_requires
        dist.fetch_build_eggs(dist.setup_requires)
      File "/usr/lib/python3.9/site-packages/setuptools/dist.py", line 721, in fetch_build_eggs
        resolved_dists = pkg_resources.working_set.resolve(
      File "/usr/lib/python3.9/site-packages/pkg_resources/__init__.py", line 766, in resolve
        dist = best[req.key] = env.best_match(
      File "/usr/lib/python3.9/site-packages/pkg_resources/__init__.py", line 1051, in best_match
        return self.obtain(req, installer)
      File "/usr/lib/python3.9/site-packages/pkg_resources/__init__.py", line 1063, in obtain
        return installer(requirement)
      File "/usr/lib/python3.9/site-packages/setuptools/dist.py", line 780, in fetch_build_egg
        return fetch_build_egg(self, req)
      File "/usr/lib/python3.9/site-packages/setuptools/installer.py", line 77, in fetch_build_egg
        raise DistutilsError(str(e)) from e
    distutils.errors.DistutilsError: Command '['/usr/bin/python', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmp4s796e19', '--quiet', 'pypandoc']' returned non-zero exit status 1.
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

python -V: 3.9.2
System: Arch Linux

When following option 3 (virtualenv), I get
% pip3 install -r requirements.txt
ERROR: Can not perform a '--user' install. User site-packages are not visible in this virtualenv.

Note that the instructions say to call python3 setup.py install before pip3 install, which works. Option 2 goes the other way round.

So the problem seems to be a missing installation of pandoc. It's not mentioned in the build requirements and I'd like to avoid installing pandoc with all its Haskell dependencies on my machine. Would be great if the building of docs could be somehow disabled optionally.

Hi @sebastianst,
Hmm, I couldn't reproduce your error from my side.
What's your pip version? You can get it from pip3 --version. If it's too old, try python3 -m pip install --upgrade pip.

pip 20.3.1 from /usr/lib/python3.9/site-packages/pip (python 3.9) - on Arch, I usually only have problems because stuff is too new :sweat_smile:
Anyway, the main problem seems to be a missing installation of pandoc

pip install pypandoc


feat[swa 252]underline "what is this?" text

The type of this PR is: feat

This PR resolves SWA-252 underline "what is this?" text
Description

PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ ] I have tested my changes on iOS and Android.
[ ] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[ ] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added an app state migration, or my changes do not require one. (What are migrations?)
[ ] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against 6a72115032fbf67793c7b91895f388810bd6385f

really nice!! thank you for making changes to take us to a better palette place. I have a couple of suggestions and then we are ready.

Thank you! 🙏  It was necessary to update LinkText to a styled Text otherwise we couldn't pass it our custom colour "black60".


chore(master): release 1.1.103

:robot: I have created a release beep boop
1.1.103 (2023-07-03)
Miscellaneous

deps: update dependency secretlint to v7.0.1 (33268e4)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/keywind/releases/tag/v1.1.103 :sunflower: