HBASE-28959 Output fsreadtime in SlowLogPayLoad to hbase:slowlog.

Re-triggered the build

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 57s

master passed

+1 :green_heart:
compile
5m 19s

master passed

+1 :green_heart:
checkstyle
1m  4s

master passed

+1 :green_heart:
spotbugs
2m 55s

master passed

+1 :green_heart:
spotless
0m 59s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

-1 :x:
mvninstall
1m 25s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
0m 24s
/patch-compile-hbase-client.txt
hbase-client in the patch failed.

-0 :warning:
javac
0m 24s
/patch-compile-hbase-client.txt
hbase-client in the patch failed.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  3s

the patch passed

-1 :x:
spotbugs
0m 25s
/patch-spotbugs-hbase-client.txt
hbase-client in the patch failed.

-1 :x:
hadoopcheck
1m 48s

The patch causes 14 errors with Hadoop v3.3.6.

-1 :x:
hadoopcheck
3m 33s

The patch causes 14 errors with Hadoop v3.4.0.

+1 :green_heart:
spotless
1m 19s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

33m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6502/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6502

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 6216a0397525 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8617730acbf7854fabc97b39c5d42cbd1beea3ca

Default Java
Eclipse Adoptium-17.0.11+9

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6502/2/artifact/yetus-general-check/output/patch-javac-3.3.6.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6502/2/artifact/yetus-general-check/output/patch-javac-3.4.0.txt

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for patch

-1 :x:
mvninstall
1m 21s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
0m 32s
/patch-compile-hbase-client.txt
hbase-client in the patch failed.

-0 :warning:
javac
0m 32s
/patch-compile-hbase-client.txt
hbase-client in the patch failed.

+1 :green_heart:
javadoc
0m 56s

the patch passed

-1 :x:
shadedjars
3m  7s

patch has 14 errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
0m 23s
/patch-unit-hbase-client.txt
hbase-client in the patch failed.

+1 :green_heart:
unit
253m 37s

hbase-server in the patch passed.

283m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6502/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6502

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux f8a27afa87b0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8617730acbf7854fabc97b39c5d42cbd1beea3ca

Default Java
Eclipse Adoptium-17.0.11+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6502/2/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6502/2/testReport/

Max. process+thread count
4827 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6502/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

The changes look good. @CCweixiao could you resolve the above warnings from jenkins build results?

The changes look good. @CCweixiao could you resolve the above warnings from jenkins build results?

I'm building directly on top of the master branch, is it because I didn't submit a test case? The changes are simple and do not require test cases

The changes look good. @CCweixiao could you resolve the above warnings from jenkins build results?

Thank you for your reply, looks like there's something wrong with the code, I'll fix it as soon as possible.

Re-triggered the build

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 44s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 57s

master passed

+1 :green_heart:
compile
4m 56s

master passed

+1 :green_heart:
checkstyle
0m 59s

master passed

+1 :green_heart:
spotbugs
2m 39s

master passed

+1 :green_heart:
spotless
0m 54s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 19s

the patch passed

+1 :green_heart:
compile
4m 43s

the patch passed

+1 :green_heart:
javac
4m 42s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
spotbugs
2m 58s

the patch passed

+1 :green_heart:
hadoopcheck
17m 50s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
1m  7s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

60m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6502/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6502

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux b8af555b4ed6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0c3c77fd03759ceda411b877abe14c1f7eacf28e

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 21s

the patch passed

+1 :green_heart:
compile
1m 33s

the patch passed

+1 :green_heart:
javac
1m 33s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed

+1 :green_heart:
shadedjars
6m 40s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  8s

hbase-client in the patch passed.

+1 :green_heart:
unit
217m  1s

hbase-server in the patch passed.

255m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6502/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6502

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 1da955ee2551 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0c3c77fd03759ceda411b877abe14c1f7eacf28e

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6502/4/testReport/

Max. process+thread count
5390 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6502/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


docker service rm removes only 1 replica per node

Summary:  when I do docker service rm xxx where xxx is a service with 5 replicas spread across two nodes, I find that only one replica gets removed on each node.  The remaining three replicas get stopped, but not removed.
Output of docker version:
ubuntu@ip-192-168-33-20:~$ docker version
Client:
 Version:      1.12.0-dev
 API version:  1.25
 Go version:   go1.6.2
 Git commit:   691bbea
 Built:        Fri Jul  1 17:24:51 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0-dev
 API version:  1.25
 Go version:   go1.6.2
 Git commit:   691bbea
 Built:        Fri Jul  1 17:24:51 2016
 OS/Arch:      linux/amd64

Output of docker info:
ubuntu@ip-192-168-33-20:~$ docker info
Containers: 3
 Running: 0
 Paused: 0
 Stopped: 3
Images: 3
Server Version: 1.12.0-dev
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 43
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host null overlay
Swarm: active
 NodeID: 6jjvdt26ht5goi1eqdl0vbmb7
 IsManager: No
Runtimes: runc
Default Runtime: runc
Security Options: apparmor seccomp
Kernel Version: 4.2.0-41-generic
Operating System: Ubuntu 15.10
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 991.1 MiB
Name: ip-192-168-33-20
ID: RRIP:NAJO:QAPS:HJB2:4RS2:FRPZ:LTBM:W4CZ:IXIB:6PNU:LY7N:NTMR
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 19
 Goroutines: 60
 System Time: 2016-07-01T22:41:20.925823885Z
 EventsListeners: 0
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Two node swarm on AWS
Steps to reproduce the issue:

Start with a working 2-node swarm; manager = <IP_ADDRESS> and worker = <IP_ADDRESS>

2.  Start a service with 5 replicas:  docker service create --replicas 5 --name frontend --env QUEUE_HOSTNAME=redis --env OPTION_A=Kats --env OPTION_B=Doggies --network mynetwork --publish 80/tcp mikegoelzer/s2_frontend:latest
3.  Observe that in this case 2 containers get scheduled to <IP_ADDRESS>, and 3 to <IP_ADDRESS>:
ubuntu@ip-192-168-33-10:~$ docker ps
CONTAINER ID        IMAGE                            COMMAND                  CREATED             STATUS              PORTS               NAMES
ec052f0efbde        mikegoelzer/s2_frontend:latest   "python app.py"          3 hours ago         Up 3 hours          80/tcp              frontend.5.6xafdlj24uh4usev1vbaodsnc
6ebda47c63f0        mikegoelzer/s2_frontend:latest   "python app.py"          3 hours ago         Up 3 hours          80/tcp              frontend.1.bvat96kuyy5xokehxvinas5pw

and
ubuntu@ip-192-168-33-20:~$ docker ps
CONTAINER ID        IMAGE                            COMMAND             CREATED             STATUS              PORTS               NAMES
5cf10ee5f606        mikegoelzer/s2_frontend:latest   "python app.py"     3 hours ago         Up 3 hours          80/tcp              frontend.2.0bf6r1kx711vxaouu0o9u5gul
f63e47c854e9        mikegoelzer/s2_frontend:latest   "python app.py"     3 hours ago         Up 3 hours          80/tcp              frontend.3.7pqp83961dzydonllkbf4nvqi
09119685c9ca        mikegoelzer/s2_frontend:latest   "python app.py"     3 hours ago         Up 3 hours          80/tcp              frontend.4.44crtadceuot29rfoa2v1i676

4.  Now do docker service rm frontend
5.  Wait several minutes to ensure system has had adequate time to converge
6.  Run docker ps -a on both machines and observe the following:
ubuntu@ip-192-168-33-10:~$ docker ps -a
CONTAINER ID        IMAGE                            COMMAND             CREATED             STATUS                      PORTS               NAMES
ec052f0efbde        mikegoelzer/s2_frontend:latest   "python app.py"     3 hours ago         Exited (0) 49 seconds ago                       frontend.5.6xafdlj24uh4usev1vbaodsnc

and
ubuntu@ip-192-168-33-20:~$ docker ps -a
CONTAINER ID        IMAGE                            COMMAND             CREATED             STATUS                        PORTS               NAMES
f63e47c854e9        mikegoelzer/s2_frontend:latest   "python app.py"     4 hours ago         Exited (137) 14 minutes ago                       frontend.3.7pqp83961dzydonllkbf4nvqi
09119685c9ca        mikegoelzer/s2_frontend:latest   "python app.py"     4 hours ago         Exited (137) 14 minutes ago                       frontend.4.44crtadceuot29rfoa2v1i676

Describe the results you received:
6ebda47c63f0 and 5cf10ee5f606 were stopped and removed.  The other three containers were stopped but not removed.
Describe the results you expected:
I expect all 5 containers to be stopped and removed.
Additional information you deem important (e.g. issue happens only occasionally):
None

ping @stevvooe @tonistiigi
The orchestrator should be removing all associated tasks when the service is removed. I think the issue is most likely at the agent level.

Just noticed that our test for this only checks active containers https://github.com/docker/docker-1.12-integration/blob/1.12-integration/integration-cli/docker_api_swarm_test.go#L225 . That needs to be updated.

Logs? My guess is that an error escaped during removal and we just failed out.

@mgoelzer I tried to reproduce but couldn't. Does this appear on some specific images or networking setup. If you can reproduce, please post daemon logs.

Without logs, I am not sure if this is the same issue, but I've reproduced this in rc3.
After generating these examples and removing the service, there are orphan containers:
$ docker ps -a -f name=angry
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
c4683915c083        alpine:latest       "sh"                20 hours ago        Created                                 angry_volhard.8.158923tb8caod0qe8l29393un
eb063366c99a        alpine:latest       "sh"                20 hours ago        Created                                 angry_volhard.4.cd1jwcz7m8tbj0o4tuhpkj89w
4b17aa0280d5        alpine:latest       "sh"                20 hours ago        Created                                 angry_volhard.6.dxm3enk1xqvnz77kni8f4lpfo

We can see this is a bug in the agent, since it receives a zero-length assignment set:
time="2016-07-07T02:17:12.840678263Z" level=debug msg="(*worker).Assign" len(tasks)=5 module=agent
time="2016-07-07T02:17:12.841325218Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=eao1hthvmca9do23p1zq740rd
time="2016-07-07T02:17:12.841878234Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=dzfoijc0e2yw56rqimqbihfob
time="2016-07-07T02:17:12.842323922Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=e8co44ynek75xzxqp2m69ya6h
time="2016-07-07T02:17:12.842748483Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=ey808aaq9y7uuhdb05m7q7s8g
time="2016-07-07T02:17:12.843165886Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=e4gc1y8o2lg6tv8zu4tx5xesq
time="2016-07-07T02:17:12.847570754Z" level=debug msg="(*worker).Assign" len(tasks)=4 module=agent
time="2016-07-07T02:17:12.848010114Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=e8co44ynek75xzxqp2m69ya6h
time="2016-07-07T02:17:12.848383331Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=ey808aaq9y7uuhdb05m7q7s8g
time="2016-07-07T02:17:12.848889004Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=e4gc1y8o2lg6tv8zu4tx5xesq
time="2016-07-07T02:17:12.849477471Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=eao1hthvmca9do23p1zq740rd
time="2016-07-07T02:17:12.853341242Z" level=debug msg="(*worker).Assign" len(tasks)=3 module=agent
time="2016-07-07T02:17:12.853996649Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=ey808aaq9y7uuhdb05m7q7s8g
time="2016-07-07T02:17:12.854522246Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=eao1hthvmca9do23p1zq740rd
time="2016-07-07T02:17:12.855985998Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=e8co44ynek75xzxqp2m69ya6h
time="2016-07-07T02:17:12.857859799Z" level=debug msg="(*worker).Assign" len(tasks)=2 module=agent
time="2016-07-07T02:17:12.858316904Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=eao1hthvmca9do23p1zq740rd
time="2016-07-07T02:17:12.858814482Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=ey808aaq9y7uuhdb05m7q7s8g
time="2016-07-07T02:17:12.876622577Z" level=debug msg="(*worker).Assign" len(tasks)=1 module=agent
time="2016-07-07T02:17:12.877513298Z" level=debug msg=assigned module=agent task.desiredstate=SHUTDOWN task.id=ey808aaq9y7uuhdb05m7q7s8g
time="2016-07-07T02:17:12.880530782Z" level=debug msg="(*worker).Assign" len(tasks)=0 module=agent
time="2016-07-07T02:17:12.921916215Z" level=debug msg="Increasing token expiration to: 60 seconds"
time="2016-07-07T02:17:13.134765261Z" level=debug msg="Pulling ref from V2 registry: alpine:latest"
time="2016-07-07T02:17:13.136058894Z" level=debug msg="pull progress map[status:Pulling from library/alpine id:latest]"
time="2016-07-07T02:17:13.136918198Z" level=debug msg="pull progress map[status:Digest: sha256:3dcdb92d7432d56604d4545cbd324b14e647b313626d99b889d0626de158f73a id:latest]"
time="2016-07-07T02:17:13.137394238Z" level=debug msg="pull progress map[status:Status: Image is up to date for alpine:latest id:latest]"
time="2016-07-07T02:17:13.191278185Z" level=debug msg="container mounted via layerStore: /var/lib/docker/aufs/mnt/4602f992138863483606b474e0d17776e4b45ad357eee2b98c35804e2e8b2116"
time="2016-07-07T02:17:13.226260160Z" level=debug msg="state changed" module=taskmanager state.desired=RUNNING state.transition="PREPARING->READY" task.id=cd1jwcz7m8tbj0o4tuhpkj89w
time="2016-07-07T02:17:13.228080658Z" level=debug msg="(*Agent).UpdateTaskStatus" module=agent task.id=cd1jwcz7m8tbj0o4tuhpkj89w
time="2016-07-07T02:17:13.229743960Z" level=warning msg="cannot find target task in store" method="(*Dispatcher).UpdateTaskStatus" node.id=1mml4ok4j88yixp1sttsbblw6 node.session=a2no8i7cqpb4e4n6tv6onf3hl task.id=cd1jwcz7m8tbj0o4tuhpkj89w
time="2016-07-07T02:17:13.230336112Z" level=debug msg="task status reported" module=agent
time="2016-07-07T02:17:13.235782665Z" level=error msg="task unavailable" method="(*Dispatcher).processTaskUpdates" module=dispatcher task.id=cd1jwcz7m8tbj0o4tuhpkj89w
time="2016-07-07T02:17:13.471820057Z" level=debug msg="Pulling ref from V2 registry: alpine:latest"
time="2016-07-07T02:17:13.472562320Z" level=debug msg="pull progress map[status:Pulling from library/alpine id:latest]"
time="2016-07-07T02:17:13.473125498Z" level=debug msg="pull progress map[status:Digest: sha256:3dcdb92d7432d56604d4545cbd324b14e647b313626d99b889d0626de158f73a id:latest]"
time="2016-07-07T02:17:13.473561482Z" level=debug msg="pull progress map[id:latest status:Status: Image is up to date for alpine:latest]"
time="2016-07-07T02:17:13.520004817Z" level=debug msg="container mounted via layerStore: /var/lib/docker/aufs/mnt/4f63ca0beba83351ebca5d553490d94cfa3f0508a748e20968e61abcc1529afe"
time="2016-07-07T02:17:13.556612793Z" level=debug msg="state changed" module=taskmanager state.desired=RUNNING state.transition="PREPARING->READY" task.id=dxm3enk1xqvnz77kni8f4lpfo
time="2016-07-07T02:17:13.557552436Z" level=debug msg="(*Agent).UpdateTaskStatus" module=agent task.id=dxm3enk1xqvnz77kni8f4lpfo
time="2016-07-07T02:17:13.560054352Z" level=warning msg="cannot find target task in store" method="(*Dispatcher).UpdateTaskStatus" node.id=1mml4ok4j88yixp1sttsbblw6 node.session=a2no8i7cqpb4e4n6tv6onf3hl task.id=dxm3enk1xqvnz77kni8f4lpfo
time="2016-07-07T02:17:13.560669873Z" level=debug msg="task status reported" module=agent
time="2016-07-07T02:17:13.641956929Z" level=error msg="task unavailable" method="(*Dispatcher).processTaskUpdates" module=dispatcher task.id=dxm3enk1xqvnz77kni8f4lpfo
time="2016-07-07T02:17:14.428810365Z" level=debug msg="Calling GET /v1.24/containers/json?all=1"

A few things to note:

We don't see any removal errors.
The errors present are not in the removal chain, as far as I can tell, so they aren't relevant.

I was unable to get a goroutine dump but my guess is there is a deadlock on remove.

Edited the title to reflect the commonalities between the reports from @stevvooe and me.

I found a race condition between task creation and removal, which could cause orphan containers. But I am not sure whether or not the race is the root cause for this issue. Please take a look at PR https://github.com/docker/swarmkit/pull/1152.

@jinuxstyle Do you have a reliable reproduction? We aren't able to reproduce this easily and don't see the errors that should be displayed in the logs.

Yes, I have a script which can reproduce it in 100%. It needs a kind of stressful test to enlarge the race window. I will upload the script to gist.  Hold on for a moment.

Post it here: https://gist.github.com/jinuxstyle/07f4decb25bfcf6d5388c0231c593b7a. To reproduce the issue, give the option [loops] a value larger or equal than 40, according to my test. It uses busybox as the image which is more lightweight. If you change the image to mikegoelzer/s2_frontend, you can reproduce it in 10 loops as I tested.

@jinuxstyle @mgoelzer I've characterize the cause of this in #24858 (and with considerable help from @jinuxstyle 🙇 ).

@mgoelzer For the most part, we have mitigated this for swarm mode. Let's go ahead and close this.
#24858 is still an active bug affecting swarmkit.


python311Packages.qpsolvers: init at 3.4.0

Description of changes
qpsolvers is python library for solving quadratic programming problems. It contains wrappers for multiple solvers like osqp, cvxopt, quadprog and much more.
Metadata
homepage URL: https://github.com/qpsolvers/qpsolvers
source URL: https://github.com/qpsolvers/qpsolvers
license: LGPLv3
platforms: platform independent (python3.10)

Close #244480
Depend on #244528, #244529 and #244530
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

@natsukium Ok, all done.

Fixed!

Result of nixpkgs-review pr 244532 run on aarch64-linux 1

32 packages marked as broken and skipped:

python310Packages.bambi
python310Packages.bambi.dist
python310Packages.qiskit
python310Packages.qiskit-aer
python310Packages.qiskit-aer.dist
python310Packages.qiskit-finance
python310Packages.qiskit-finance.dist
python310Packages.qiskit-ibmq-provider
python310Packages.qiskit-ibmq-provider.dist
python310Packages.qiskit-ignis
python310Packages.qiskit-ignis.dist
python310Packages.qiskit-nature
python310Packages.qiskit-nature.dist
python310Packages.qiskit-optimization
python310Packages.qiskit-optimization.dist
python310Packages.qiskit.dist
python310Packages.scikit-survival
python310Packages.scikit-survival.dist
python311Packages.qiskit-aer
python311Packages.qiskit-aer.dist
python311Packages.qiskit-finance
python311Packages.qiskit-finance.dist
python311Packages.qiskit-ibmq-provider
python311Packages.qiskit-ibmq-provider.dist
python311Packages.qiskit-ignis
python311Packages.qiskit-ignis.dist
python311Packages.qiskit-nature
python311Packages.qiskit-nature.dist
python311Packages.qiskit-optimization
python311Packages.qiskit-optimization.dist
python311Packages.scikit-survival
python311Packages.scikit-survival.dist

8 packages failed to build:

python310Packages.blackjax
python310Packages.blackjax.dist
python310Packages.jaxopt
python310Packages.jaxopt.dist
python311Packages.blackjax
python311Packages.blackjax.dist
python311Packages.jaxopt
python311Packages.jaxopt.dist

24 packages built:

python310Packages.cvxpy
python310Packages.cvxpy.dist
python310Packages.daqp
python310Packages.daqp.dist
python310Packages.osqp
python310Packages.osqp.dist
python310Packages.qpsolvers
python310Packages.qpsolvers.dist
python310Packages.qutip
python310Packages.qutip.dist
python310Packages.scs
python310Packages.scs.dist
python311Packages.cvxpy
python311Packages.cvxpy.dist
python311Packages.daqp
python311Packages.daqp.dist
python311Packages.osqp
python311Packages.osqp.dist
python311Packages.qpsolvers
python311Packages.qpsolvers.dist
python311Packages.qutip
python311Packages.qutip.dist
python311Packages.scs
python311Packages.scs.dist

LGTM, but the scs test seems to hang on x86_64-linux.🤔

Hmmm... On my laptop all fine:

nix build .#python3Packages.scs

Sourcing python-remove-tests-dir-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing setuptools-build-hook
Using setuptoolsBuildPhase
Using setuptoolsShellHook
Sourcing pip-install-hook
Using pipInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing python-namespaces-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing setuptools-check-hook
Using setuptoolsCheckPhase
Sourcing pytest-check-hook
Using pytestCheckPhase
Removing setuptoolsCheckPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/wd5h7sgdalf727b6938zba0wawi38mvb-source
source root is source
setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/test/test_solve_random_cone_prob_mkl.py
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
building
Executing setuptoolsBuildPhase
Namespace(scs=False, gpu=False, mkl=False, openmp=False, float32=False, extraverbose=False, gpu_atrans=True, int32=False, blas64=False)
/nix/store/b7rq6rjxyg23rwx0s8bv6vi7k6kwm3py-python3.10-setuptools-67.4.0/lib/python3.10/site-packages/setuptools/__init__.py:85: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated. Requirements should be satisfied by a PEP 517 installer. If you are using pip, you can try `pip install --use-pep517`.
  dist.fetch_build_eggs(dist.setup_requires)
running bdist_wheel
running build
running build_py
creating build
creating build/lib.linux-x86_64-cpython-310
creating build/lib.linux-x86_64-cpython-310/scs
copying src/__init__.py -> build/lib.linux-x86_64-cpython-310/scs
running build_ext
setup.py:97: DeprecationWarning:
numpy.distutils is deprecated since NumPy 1.23.0, as a result
of the deprecation of distutils itself. It will be removed for
Python >= 3.12. For older Python versions it will remain present.
It is recommended to use setuptools < 60.0 for those Python versions.
For more details, see:
https://numpy.org/devdocs/reference/distutils_status_migration.html
from numpy.distutils.system_info import get_info
blas_armpl_info:
NOT AVAILABLE
blas_mkl_info:
NOT AVAILABLE
blis_info:
NOT AVAILABLE
openblas_info:
libraries = ['lapack', 'lapacke', 'blas', 'cblas', 'lapack', 'lapacke', 'blas', 'cblas']
library_dirs = ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib']
language = c
define_macros = [('HAVE_CBLAS', None)]
runtime_library_dirs = ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib']
blas_opt_info:
libraries = ['lapack', 'lapacke', 'blas', 'cblas', 'lapack', 'lapacke', 'blas', 'cblas']
library_dirs = ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib']
language = c
define_macros = [('HAVE_CBLAS', None)]
runtime_library_dirs = ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib']
lapack_armpl_info:
NOT AVAILABLE
lapack_mkl_info:
NOT AVAILABLE
openblas_lapack_info:
libraries = ['lapack', 'lapacke', 'blas', 'cblas', 'lapack', 'lapacke', 'blas', 'cblas']
library_dirs = ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib']
language = c
define_macros = [('HAVE_CBLAS', None)]
runtime_library_dirs = ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib']
lapack_opt_info:
libraries = ['lapack', 'lapacke', 'blas', 'cblas', 'lapack', 'lapacke', 'blas', 'cblas']
library_dirs = ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib']
language = c
define_macros = [('HAVE_CBLAS', None)]
runtime_library_dirs = ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib']
Supported SIMD extensions in this NumPy install:
baseline = SSE,SSE2,SSE3
found = SSSE3,SSE41,POPCNT,SSE42,AVX,F16C,FMA3,AVX2
not found = AVX512F,AVX512CD,AVX512_SKX,AVX512_CLX,AVX512_CNL,AVX512_ICL
Blas info:
{'libraries': ['lapack', 'lapacke', 'blas', 'cblas', 'lapack', 'lapacke', 'blas', 'cblas'], 'library_dirs': ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib'], 'language': 'c', 'define_macros': [('HAVE_CBLAS', None)], 'runtime_library_dirs': ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib']}
Lapack info:
{'libraries': ['lapack', 'lapacke', 'blas', 'cblas', 'lapack', 'lapacke', 'blas', 'cblas'], 'library_dirs': ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib'], 'language': 'c', 'define_macros': [('HAVE_CBLAS', None)], 'runtime_library_dirs': ['/nix/store/amwml0fw056mnqviqf0ps7zc71kzyfx4-lapack-3/lib', '/nix/store/zs7hl4lk9y3wc2pixkincxyq6i35xd84-blas-3/lib']}
/nix/store/b7rq6rjxyg23rwx0s8bv6vi7k6kwm3py-python3.10-setuptools-67.4.0/lib/python3.10/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
Finished executing setuptoolsBuildPhase
@nix { "action": "setPhase", "phase": "installPhase" }
installing
Executing pipInstallPhase
/build/source/dist /build/source
Processing ./scs-3.2.3-cp310-cp310-linux_x86_64.whl
Requirement already satisfied: numpy>=1.7 in /nix/store/3ypm1j8qa1prs2xincgxxh2cjr7cdbv6-python3.10-numpy-1.24.2/lib/python3.10/site-packages (from scs==3.2.3) (1.24.2)
Requirement already satisfied: scipy>=0.13.2 in /nix/store/l0jqa20zxqpmnf8s0yggvhgn54xyh23i-python3.10-scipy-1.10.1/lib/python3.10/site-packages (from scs==3.2.3) (1.10.1)
Installing collected packages: scs
Successfully installed scs-3.2.3
/build/source
Finished executing pipInstallPhase
@nix { "action": "setPhase", "phase": "pythonOutputDistPhase" }
pythonOutputDistPhase
Executing pythonOutputDistPhase
Finished executing pythonOutputDistPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v58803xygn02h597445k4w6b50wyh7l4-python3.10-scs-3.2.3
shrinking /nix/store/v58803xygn02h597445k4w6b50wyh7l4-python3.10-scs-3.2.3/lib/python3.10/site-packages/_scs_direct.cpython-310-x86_64-linux-gnu.so
shrinking /nix/store/v58803xygn02h597445k4w6b50wyh7l4-python3.10-scs-3.2.3/lib/python3.10/site-packages/_scs_indirect.cpython-310-x86_64-linux-gnu.so
checking for references to /build/ in /nix/store/v58803xygn02h597445k4w6b50wyh7l4-python3.10-scs-3.2.3...
patching script interpreter paths in /nix/store/v58803xygn02h597445k4w6b50wyh7l4-python3.10-scs-3.2.3
stripping (with command strip and flags -S -p) in  /nix/store/v58803xygn02h597445k4w6b50wyh7l4-python3.10-scs-3.2.3/lib
shrinking RPATHs of ELF executables and libraries in /nix/store/4adwy4x82rwfpyf20qv59wd905z12cxg-python3.10-scs-3.2.3-dist
checking for references to /build/ in /nix/store/4adwy4x82rwfpyf20qv59wd905z12cxg-python3.10-scs-3.2.3-dist...
patching script interpreter paths in /nix/store/4adwy4x82rwfpyf20qv59wd905z12cxg-python3.10-scs-3.2.3-dist
Executing pythonRemoveTestsDir
Finished executing pythonRemoveTestsDir
@nix { "action": "setPhase", "phase": "installCheckPhase" }
running install tests
no Makefile or custom installCheckPhase, doing nothing
@nix { "action": "setPhase", "phase": "pythonCatchConflictsPhase" }
pythonCatchConflictsPhase
@nix { "action": "setPhase", "phase": "pythonRemoveBinBytecodePhase" }
pythonRemoveBinBytecodePhase
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" }
pythonImportsCheckPhase
Executing pythonImportsCheckPhase
Check whether the following modules can be imported: scs
@nix { "action": "setPhase", "phase": "pytestCheckPhase" }
pytestCheckPhase
Executing pytestCheckPhase
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-7.2.1, pluggy-1.0.0
rootdir: /build/source
collecting ...
collecting 5 items
collected 26 items
test/test_scs_basic.py .....                                             [ 19%]
test/test_scs_object.py ......                                           [ 42%]
test/test_scs_rand.py .....                                              [ 61%]
test/test_scs_sdp.py .....                                               [ 80%]
test/test_solve_random_cone_prob.py .....                                [100%]
======================== 26 passed in 107.20s (0:01:47) ========================
Finished executing pytestCheckPhase
pytestCheckPhase completed in 1 minutes 54 seconds
@nix { "action": "setPhase", "phase": "pytestcachePhase" }
pytestcachePhase
@nix { "action": "setPhase", "phase": "pytestRemoveBytecodePhase" }
pytestRemoveBytecodePhase

You are right. I can build scs with nix-build -A python3Packages.scs.
Let's disable that test only for x86_64-linux.

Done 👍


Multiple messenger interface support

Description
Multiple user interface support added.
Checklist

[ ] I have performed a self-review of the changes

To Consider

Add tests (if functionality is changed)
Update API reference / tutorials / guides
Update CONTRIBUTING.md (if devel workflow is changed)
Update .ignore files, scripts (such as lint), distribution manifest (if files are added/deleted)
Search for references to changed entities in the codebase

The latter.


New package: iCSV v1.0.0-DEV

Registering package: iCSV
Repository: https://gitlab.com/leibersp/PYiCSV.jl
Created by: https://gitlab.com/leibersp
Version: v1.0.0-DEV
Commit: bf96db5739007cdb63a14a81c6080adb3d4d9b6b
Git reference: HEAD

Closing in favor of https://github.com/JuliaRegistries/General/pull/120255


DOC-180: Add hamburger menu for small screens

This fixes DOC-180: https://linear.app/buildkite/issue/DOC-180/hide-site-menu-on-mobile

Let me know how you feel about thickness of the lines, the animation, and the speed of transition.
I've deliberately not done any extra styling to the menu as yet to keep this small, but we can always adjust the look of it too.

@lachlanhardy I think this PR breaks styling on desktop:

@chrislloyd Good catch, thanks. On it!


Run workspace/contract compilation in parallel

Problem
We're currently compiling each package in a workspace sequentially (similarly for contract functions). This doesn't take advantage of multiple cores which would speed up compilation times.
Happy Case
We should compile each package/contract function on a separate thread (up to a maximum depending on the user's system. WASM is also restricted for this.)
Care needs to be taken so that errors, etc. are printed correctly rather than being interwoven.
Alternatives Considered
No response
Additional Context
This should be delayed until after the rest of the workspace changes being made.
Would you like to submit a PR for this Issue?
No
Support Needs
No response

@TomAFrench are you not the best person to take this on?

I could take it on but it's a matter of prioritisation. aztec-packages would be the main beneficiary of this issue being resolved but they're currently handling this through spinning up multiple instances of nargo to compile the contracts individually.
At the same time there's monorepoing work to do, ABI encoding packages to make, etc. which allow us to move faster or are tied to epics which we've committed to. This means I'm unlikely to work on this in the short term.

More generally, carrying a lot of assigned issues has drawbacks:

I'm less able to use the issues which are assigned to me to me in planning my day/week it's turned into another backlog rather than a focused list.
Having this issue assigned to me gives the impression that it's "mine", which means

External contributors are less likely to pick this up.
Readers of this issue get the expectation that I am or should be actively working on it.

External contributors are less likely to pick this up.
That's a fair point regarding external contributors being less likely to pick it up, I was aiming to have most issues have an owner per-se, so that there were none that fell by the wayside.

I'll remove owners from issues which are good first issues and then remove owners from issues which I think are good for onboarding external developers and use the "help-wanted" label for those.

I'm less able to use the issues which are assigned to me to me in planning my day/week

Ah thats good feedback, I thought that the P-HIGH/MEDIUM categorization would have helped, but checking, I can see that a lot of things assigned to you are P-MEDIUM, so it does turn into a bit of a backlog.


Install pwsh(PowerShell) and the profile also in Linux and Darwin

Using in WSL2 helps to maintain as https://github.com/kachick/PSFzfHistory
And testing the pwsh behavior in github actions runner...

Give it a try!


[docs] sdkmanager path is outdated

Describe your idea
Hello,
While following the docs to setup an AOSP emulator, I noticed the sdkmanager path was outdated.
Previous: $ANDROID_HOME/tools/bin/sdkmanager
New: $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager
Have a nice day!

Hey @adrienharnay, thanks for the report!
This path is version dependent and indeed changed in the latest versions.
We're planning to improve the Android docs and to fix some sections, so we'll make sure this will be fixed as well.
CC @jonathanmos


firstWhere throws when provided orElse: null if no items matched (expectation was null returned)

The firstWhere docs say that if there's no matching element a StateError will be thrown unless you provide an orElse argument. However I was just caught out that if I pre-filter the list with another .where() which matches no elements, a StateError is thrown regardless of the orElse:
[1]
  .where((a) => a > 10)
  .firstWhere((a) => a == 0, orElse: null);

Bad state: No element
    at Object.wrapException (<anonymous>:611:17)
    at WhereIterable.firstWhere$2$orElse (<anonymous>:1302:17)
    at Object.main (<anonymous>:1372:54)

IMO this behaviour seems wonky (and different to other similar methods from other languages I've used) - it means chaining wheres and then a firstWhere isn't the same as putting all the conditions in the firstWhere (which seems to encourage a single firstWhere with a long set of conditions), however if that's how it's expected to be I think there should be a mention in the docs that an empty input will always throw regardless of the condition of the orElse argument.

Oh dear, I see what's happening... orElse: null of course is the same as not passing orElse! That's a bit unfortunate... should there be some sort of undefined value? ;-)
Probably related: #7939
In C#'s LINQ there's a .FirstOrDefault, .SingleOrDefault which are used quite a bit; would something similar be considered?

The orElse parameter is a function, not a value. That's occasionally annoying, but also strictly more powerful than passing a single value. It also allows you to actually use null as a default by calling as:
someIterable.firstWhere(test, orElse: () => null);

I have yet to run into a case where I want firstWhere to throw :-/

The orElse parameter is a function, not a value

Whoops! Makes sense now (well, kinda).

I have yet to run into a case where I want firstWhere to throw :-/

I can't think of one off the top of my head, but in C#/LINQ we definitely used First() and FirstOrDefault() a fair bit (and same for Single's). FirstOrDefault was definitely more common though (and the opposite for Single because that was really used specifically to crash if something is not as expected).

@DanTup when the collection is expected to also contain null. I can imagine such cases, but I never run into one myself, so the default case "throwing" is IMHO annoying.

Sure, I'll go with it's a bad default - I just think there's a place for both and both could be made easy (like they are in C# where there are just two methods, First and FirstOrDefault). While FirstOrDefault doesn't let you customise the default value, you can easily append ?? someValue on the end (for nullables at least).

@DanTup am I right that for now firstOrDefault not exists?

@fryette I don't think so. You might be able to implement it with an extension method that just calls firstWhere with an orElse though :-)

@DanTup Is this a good way to solve this?
/// Returns the first element that matches the provided test or null if no match is found.
T? firstWhereOrNull(bool Function(T element) test) {
    final list = where(test);
    return list.isEmpty ? null : list.first;
}

@hecker this issue is quite old and firstWhereOrNull has since been added to package:collection:
https://pub.dev/documentation/collection/latest/collection/IterableExtension/firstWhereOrNull.html
I would use it from there (that package has many other similar variants of iterable methods). The implementation looks like this:
T? firstWhereOrNull(bool Function(T element) test) {
  for (var element in this) {
    if (test(element)) return element;
  }
  return null;
}

I think your implementation may behave slightly differently for Iterable<T>s (I think calling isEmpty and first could cause two enumerations of the iterable?).


Use async embedding when provisionning the DB if in the event loop

Draft until https://github.com/langchain-ai/langchain/pull/16875 is merged

Closing in favor of https://github.com/langchain-ai/langchain/pull/17635


Can't run testnet-v4 node

I've pulled master branch and installed akash.
Next:
./akash init enflow --chain-id testnet-v4
./akash keys add enflow
curl -s curl https://raw.githubusercontent.com/ovrclk/net/master/latest/genesis.json > ~/.akash/config/genesis.json
Next edited config.toml (https://github.com/lightiv/SkyNet/wiki/Akash-Seed-Node-Installation-Guide)

Next
 ./akash start
But got error:
panic: Any JSON doesn't have '@type'
And
./akash validate-genesis
Error: error validating genesis file /Users/constantine/.akash/config/genesis.json: failed to unmarshal genutil genesis state: unknown field "gentxs" in types.GenesisState

So I think something wrong with akash version?

Hey @Enflow-io, thanks for the bug report.
There are two issues at play here.

Akash binary release version, which I assume you pulled 'master' or recent release since you're using akash binary, which uses CosmosSDK 0.40+. This change came recently to ovrclk/akash, and breaks compatibility with the current mainnet and the testnet described in the guide you're following: https://github.com/lightiv/SkyNet/wiki/Akash-Seed-Node-Installation-Guide
ovrclk/net/latest is referencing the previous CosmosSDK build of Akash; which produce akashd and akashctl binaries.

It was tagged to work with Akash v0.7.8-rc3; releasing akashd & akashctl.
Unfortunately right now, github.com/ovrclk/net/latest is not interoperable with github.com/ovrclk/akash:master.

Sorry for the confusion, we're working on cleaning up and improving consistency of the documentation.
If you'd like to continue with that guide, pull the binaries from v0.7.8-rc3, and they should match net/latest's genesis.json formatting.


chore: adds webhook validation for syncReplicaElectionConstraints

Closes #304
Signed-off-by: Armando Ruocco<EMAIL_ADDRESS>

/ok-to-merge


Using my own buttons to invoke the export (outside of the chart)

I am trying to invoke export with my own buttons, outside of the chart, but am getting the following error :
TypeError: AmCharts.AmExport is not a constructor

I was using an example I found on stackoverflow at http://jsfiddle.net/BGuuT/2/ which works by the way, but doesn't seem to in my own implementation for some reason.  Maybe I have a newer version?
I am including in my page :
amcharts-3.21.12/amcharts.js
amcharts-3.21.12/serial.js
amcharts-3.21.12/plugins/export/export.js

html is :

JPG

PNG

SVG

CSV

JSON

PDF

XLSX

Print

I am getting the correct export value to pass here, but the constructor error still shows :
chart = AmCharts.makeChart("chart_chart", { .......... });

$('body').on('click', '#chart-selector .dropdown-item', function(e) {

    var test = $(this).data('click');

    //chart download action
	var exp = new AmCharts.AmExport(chart);
	    exp.init();
	    exp.output({
	        format: test
    	});
});

The only difference I can see between the mine and the link given is export.js compared to amexport_combined.js - the latter is not a file given in amcharts though.  Ideas?

New comment from Zendesk by Anthony Piris on ticket 37219.
(replying here will automatically notify amCharts support agent)

Hi there,
I responded to your stackoverflow post here: https://stackoverflow.com/a/50629996/6106614
To summarize - the example you're referencing is using an old version of the plugin, which is why you get the undefined AmExport error. The examples I linked, along with the one I created should get you started. The export plugin documentation also talks about the API methods in more detail.
I hope this helps.
Best,
Anthony Piris
amCharts

Can you provide the any example in amchart4 as same like above?
Is it possible to call amchart export adaptor functionality in amcharts4 v?


Dart Polymer element + dart2js: let me import into a Polymer JS project

 Issue by kevmoo
Originally opened as dart-lang/sdk#15227

No clue if this is practical, but it'd be great.

Create polymer element with foo.dart + foo.html
dart2js to foo.js
Deploy foo.html + foo.js ... somewhere
Polymer JS app can <link rel="import" href="foo.html">
It works!

 Comment by iposva-google

Added Triaged label.

 Comment by anders-sandholm

Added Area-Polymer label.

 Comment by jmesserly

Removed Library-Polymer label.

 Comment by sethladd

This is a good question for the dart2js team.

 Comment by jmesserly

Removed Area-Polymer label.
Added area-pkg, Pkg-Polymer labels.

 Comment by jmesserly

so it will work now, but might not give you the result you expect. :)
two issues:

dart2js output will be very large. I'd guess at least ~400k minified. But it will grow slowly for each added widget, so might be okay for a really big widget library compiled together.
you'll need JS -> Dart interop to talk to the Dart element. I don't know how that is accomplished but Justin probably does.

So it works but ... is probably not usable in practice.
Not sure how to proceed, due to issue dart-lang/sdk#1 above. Open to suggestions...

cc @justinfagnani.
cc @dgrove.
Added NeedsInfo label.

 Comment by a14n

(Divagating and assuming I never dive into dart2js) For issue dart-lang/sdk#1 it would be interesting if dart2js could create a js file containing the bases for Dart + polymer runtime emulation. This file could be imported in the generated polymer-element (with <link tel="import" src="dart-polymer-base.html"> or something like that) and shared between dart polymer-elements. The polymer-element would thus contain only a limited js file that would be based on. It looks like the deferred loading. I really don't know if this is possible. What do you think ?

 Comment by sigmundch

Added this to the Later milestone.

 Comment by sigmundch

Removed this from the Later milestone.

 Comment by sigmundch

Added Polymer-P-2 label.

 Comment by sigmundch

Removed Polymer-P-2 label.
Added Polymer-Milestone-Later label.

 Comment by sigmundch

Removed Priority-Unassigned label.
Added Priority-Medium label.

 Comment by sigmundch

Removed Polymer-Milestone-Later label.
Added PolymerMilestone-Later label.


EOA migrate tests failing

@MaxMustermann2
__________________________________________________________________________________ test_eoa_access_success __________________________________________________________________________________

    @pytest.mark.order( 15 )
    def test_eoa_access_success():
        with open(
            os.path.join(
                os.path.split( __file__ )[ 0 ],
                '../build/contracts/StakingPrecompilesSelectors.json'
            )
        ) as f:
            abi = json.load( f )[ "abi" ]
        # on Vanilla brownie, this will raise a ContractNotFound because of missing bytecode
        # but just the ABI is enough to interact with the contract
        # https://github.com/MaxMustermann2/brownie/commit/8ae2995159c06eddd7e2098a984e08d27542b79f
>       precompile = Contract.from_abi(
            "StakingPrecompile",    # any name works
            "0x00000000000000000000000000000000000000FC",
            abi
        )
E       brownie.exceptions.ContractNotFound: No contract deployed at 0x00000000000000000000000000000000000000fc

tests/test_staking_contract.py:789: ContractNotFound
_____________________________________________________________________________________ test_eoa_migrate ______________________________________________________________________________________

    @pytest.mark.order( 18 )
    def test_eoa_migrate():
        # useful if used via -k
        create_validator( validator_address, validator_info, pk )
        with open(
            os.path.join(
                os.path.split( __file__ )[ 0 ],
                '../build/contracts/StakingPrecompilesSelectors.json'
            )
        ) as f:
            abi = json.load( f )[ "abi" ]
        # on Vanilla brownie, this will raise a ContractNotFound because of missing bytecode
        # but just the ABI is enough to interact with the contract
        # https://github.com/MaxMustermann2/brownie/commit/8ae2995159c06eddd7e2098a984e08d27542b79f
>       precompile = Contract.from_abi(
            "StakingMigrationPrecompile",    # any name works
            "0x00000000000000000000000000000000000000FC",
            abi
        )
E       brownie.exceptions.ContractNotFound: No contract deployed at 0x00000000000000000000000000000000000000fc

tests/test_staking_contract.py:1065: ContractNotFound

Hi @gupadhyaya, brownie, by default, assumes that bytecode must be present at an address to build a Contract object to allow interaction with it. However, for precompiles (across all chains, including Ethereum) this is not the case. I have built a fork of brownie at MaxMustermann2/brownie with that assumption removed in the no-bytecode-no-fail branch, with the following commit message:
 Allow empty bytecodes in Contract.from_abi

Some chains have decided to add ABI-driven precompiled contracts,
similar to the current cryptographic precompiles available in Ethereum.
These precompiles are handled directly by the file `contracts.go` and
as such do not have an available bytecode. However, it is possible to
interact with them if the function selectors are available.

Example chains include (1) abeychain, (2) Moonbeam, both of which use a
staking precompile with no bytecode and just an ABI. See also
harmony-one/harmony#3906

To install this, you can
pip uninstall eth-brownie
pip install https://github.com/MaxMustermann2/brownie/archive/refs/heads/no-bytecode-no-fail.zip

Please note that similar steps need to be done for pyhmy as well. The difference against harmony-one/pyhmy is the addition of validator signed messages (SlotKeySigs) which were added later as a requirement in CreateValidator (and SlotKeyToAddSig for EditValidator).
pip uninstall pyhmy
pip install https://github.com/MaxMustermann2/pyhmy/archive/refs/heads/validator-sigs.zip

Alternatively, I recommend using a virtual environment and just installing requirements.txt in that.
python3 -m pip install --user virtualenv
python3 -m venv env
source env/bin/activate
pip install -r requirements.txt


feat(apps/prod/tekton/configs/pvcs): add global crate index mirror

Reverts PingCAP-QE/ee-ops#1142

/approve


Error when clicking on Finagle nav item

Issue was due to cache. Cache busting on roadmap as high priority issue.


Translate table into sections and columns for tables that do not have visible border as these tables are used for layout purposes

The limitation is 3 columns max.

Closing this for now...way to complex and risky versus the potential benefits


PivotTableUi; horizontal sizer isn't updated correctly when there are only row items and the row headers completely fill out the available space

We can fix the sizer so the scrollbar allows for room to the desired position, but this doesn't solve the problem.
The reason is in the design of the pivot table. The current design supports scrolling the values of the rows in the vertical position, but not in the horizontal position. Horizontal scrolling is supported, but scrolls only column tuples.
It is not simply the matter of changing that logic. In general, the desired behavior is to have the row headers "frozen", allowing the cells and columns to be scrolled when scrolling horizontally.
In this case, the size taken up by the row headers is simply larger than the available window, not only leaving no room for any columns, but not even for showing all row headers.

For now we will work around it. For the Data Preview we sort of can.


fix: revise formatting for docs.yml file

For an example of how to fill this template out, see this Pull Request in the Wiki.
Description
This PR fixes the formatting in the docs.yml file in the Issue template folder.

Fixes Issue
Closes #47
Closes #51

Acceptance Criteria
N/A

Type of Changes
This PR makes the following changes:

Renames the description field to details to make it more clear what the field is for.
Adds a label attribute to the details field to make it more readable.
Updates the description attribute for the details field to provide more specific instructions for what to include in the issue description.
Renames the possible-solution-and-benefit field to solution to make it more clear what the field is for.
Updates the description attribute for the solution field to provide more specific instructions for what to include in the proposed solution.
Adds a validations section to the solution field to make it clear that the proposed solution is required.

Make sure your code follows the code style of this project.
Make sure your code is up2date.
The title of the PR is the same as the title of the issue.

Type

x
:bug: Bug fix

:sparkles: New feature

:hammer: Refactoring

:100: Add tests

:link: Update dependencies

:scroll: Docs

Updates
Before

After

Testing Steps / QA Criteria

I updated the coressponding issue. Is there a way to check beforehand that the yml file is now working? Can you share these testing steps?

I updated the corresponding issue. Is there a way to check beforehand that the yml file is now working? Can you share these testing steps?

That's a good question @YuriDevAT. I think the way to test is to see something like this:

I guess this is after merging it? Or can you already see that on your created branch in the forked version?

I guess this is after merging it? Or can you already see that on your created branch in the forked version?

Let me check

Please resolve conflicts to get this PR merged.

Please resolve conflicts to get this PR merged.

Well do

Hi @YuriDevAT. The merge conflicts are too difficult to solve, so I'm going to do a new PR for this


Add instruction names

I proposed some annotations to the RISC-V Sail code which added human-readable names for each mnemonic, starting with just those in the "base" set for now.
Feedback to me for that PR included that many of the proposed instruction names weren't official names already expressed in the RISC-V ISA specification.
This issue is to try to address that concern by getting agreement on names for the mnemonics (base only for now), and adding them in some form to the specification. First step is to get agreement on instruction names. Is there a process to get 'official' agreement? Should I encode the names as changes to the specification in a PR so that it can be reviewed?
Below is a table that lists:

The base mnemonics (those found in model/riscv_insts_base.sail).
Those names that are pretty clearly defined in the specification. (There are not many, and some of those still involve some inference.)
My proposed names (coming out of my "Sailing Downstream" project).
A couple of somewhat random references that have made some attempt at naming the instructions as well.

It's anecdotal, but there is reasonable agreement among the 3 ad-hoc naming attempts.

mnemonic
RISC-V ISA Specification 20240411
Sailing Downstream
MIT 6.191
risc-v.guru

lui
load upper immediate
load upper immediate
Load Upper Immediate
Load Upper Immediate

auipc
add upper immediate to pc
add upper immediate to PC

Add Upper Imm. to PC

jal
jump and link
jump and link
Jump and Link
Jump And Link

jalr
jump and link register
jump and link register
Jump and Link Register
Jump And Link Register

beq

branch if equal
Branch if =
Branch Equal

bne

branch if not equal
Branch if ≠
Branch Not Equal

blt

branch if less than
Branch if < (Signed)
Branch Less Than

bge

branch if greater than
Branch if ≥ (Signed)
Branch Greater Than

bltu

branch if less than (unsigned)
Branch if < (Unsigned)
Branch Less Than

bgeu

branch if greater than or equal to (unsigned)
Branch if ≥ (Unsigned)
Branch Greater Than

addi

add immediate
Add Immediate
ADD Immediate

slti
set less than immediate
set less than immediate
Compare < Immediate (Signed)
Set < Immediate

sltiu

set less than immediate unsigned
Compare < Immediate (Unsigned)
Set < Immediate Unsigned

xori

XOR immediate
Xor Immediate
XOR Immediate

ori

OR immediate
Or Immediate
OR Immediate

andi

AND immediate
And Immediate
AND Immediate

slli
logical left shift
shift left (logical) immediate
Shift Left Logical Immediate
Shift Left Immediate

srli
logical right shift
shift right (logical) immediate
Shift Right Logical Immediate
Shift Right Immediate

srai
arithmetic right shift
shift right (arithmetic) immediate
Shift Right Arithmetic Immediate
Shift Right Arithmetic Imm.

add
addition
add
Add Immediate
ADD

slt
signed compare
set less than
Compare < (Signed)
Set <

sltu
unsigned compare
set less than (unsigned)
Compare < (Unsigned)
Set < Unsigned

and

AND
And
AND

or

OR
Or
OR

xor

exclusive OR
Xor
XOR

sll
logical left shift
shift left (logical)
Shift Left Logical
Shift Left

srl
logical right shift
shift right (logical)
Shift Right Logical
Shift Right

sub
subtraction
subtract
Subtract
Subtract

sra
arithmetic right shift
shift right (arithmetic)
Shift Right Arithmetic
Shift Right Arithmetic

lb

load byte

Load Byte

lh

load halfword

Load Halfword

lw

load word
Load Word
Load Word

ld

load double

Load Double

lbu

load byte unsigned

Load Byte Unsigned

lhu

load halfword unsigned

Load Halfword Unsigned

lwu

load word unsigned

Load Word Unsigned

ldu

load double unsigned

Load Double Unsigned

sb

store byte

Store Byte

sh

store halfword

Store Halfword

sw

store word
Store Word
Store Word

sd

store double

Store Double

addiw

add immediate word

ADD Immediate Word

addw

add word (RV64)

ADD Word

subw

subtract word (RV64)

Subtract Word

sllw

shift left (logical) word (RV64)

Shift Left Word

srlw

shift right (logical) word (RV64)

Shift Right Word

sraw

shift right (arithmetic) word (RV64)

Shift Right Arithmetic Word

slliw

shift left (logical) immediate word (RV64)

Shift Left Immediate Word

srliw

shift right (logical) immediate word (RV64)

Shift Right Immediate Word

sraiw

shift right (arithmetic) immediate word (RV64)

Shift Right Arithmetic Imm. Word

fence

fence (memory)

Sync Thread

fence.tso

fence (total store order)

fence.i

fence (instruction)

Sync Instruction & Data

ecall
environment call
environment call

mret

machine-level return

sret

supervisor-level return

ebreak
environment breakpoint
environment breakpoint

wfi
Wait for Interrupt
wait for interrupt

sfence.vma
supervisor memory-management fence
store fence (virtual memory address)

Aren't all of these instruction mnemonics the exact ones clearly used in the Unpriv spec (and hence need no discussion or agreement on making them official since they are already official and part of ratified specs)?

Aren't all of these instruction mnemonics the exact ones clearly used in the Unpriv spec?

The mnemonics are all present. I want to add human-readable names to the ISA specification. So "slli" would have an associated name like "shift left logical immediate". In its current form, the ISA specification has very few clearly distinguished such names.

It seems that the RISC-V Unified Database project is also busy adding instruction names, so I've added the names they chose to the table:

mnemonic
RISC-V ISA Specification 20240411
Sailing Downstream
riscv-unified-db
MIT 6.191
risc-v.guru

lui
load upper immediate
load upper immediate
Load upper immediate
Load Upper Immediate
Load Upper Immediate

auipc
add upper immediate to pc
add upper immediate to PC
Add upper immediate to pc

Add Upper Imm. to PC

jal
jump and link
jump and link
Jump and link
Jump and Link
Jump And Link

jalr
jump and link register
jump and link register
Jump and link register
Jump and Link Register
Jump And Link Register

beq

branch if equal
Branch if equal
Branch if =
Branch Equal

bne

branch if not equal
Branch if not equal
Branch if ≠
Branch Not Equal

blt

branch if less than
Branch if less than
Branch if < (Signed)
Branch Less Than

bge

branch if greater than
Branch if greater than or equal
Branch if ≥ (Signed)
Branch Greater Than

bltu

branch if less than (unsigned)
Branch if less than unsigned
Branch if < (Unsigned)
Branch Less Than

bgeu

branch if greater than or equal to (unsigned)
Branch if greater than or equal unsigned
Branch if ≥ (Unsigned)
Branch Greater Than

addi

add immediate
Add immediate
Add Immediate
ADD Immediate

slti
set less than immediate
set less than immediate
Set on less than immediate
Compare < Immediate (Signed)
Set < Immediate

sltiu

set less than immediate unsigned
Set on less than immediate unsigned
Compare < Immediate (Unsigned)
Set < Immediate Unsigned

xori

XOR immediate
Exclusive Or immediate
Xor Immediate
XOR Immediate

ori

OR immediate
Or immediate
Or Immediate
OR Immediate

andi

AND immediate
And immediate
And Immediate
AND Immediate

slli
logical left shift
shift left (logical) immediate
Shift left logical immediate
Shift Left Logical Immediate
Shift Left Immediate

srli
logical right shift
shift right (logical) immediate
Shift right logical immediate
Shift Right Logical Immediate
Shift Right Immediate

srai
arithmetic right shift
shift right (arithmetic) immediate
Shift right arithmetic immediate
Shift Right Arithmetic Immediate
Shift Right Arithmetic Imm.

add
addition
add
Integer add
Add Immediate
ADD

slt
signed compare
set less than
Set on less than
Compare < (Signed)
Set <

sltu
unsigned compare
set less than (unsigned)
Set on less than unsigned
Compare < (Unsigned)
Set < Unsigned

and

AND
And
And
AND

or

OR
Or
Or
OR

xor

exclusive OR
Exclusive Or
Xor
XOR

sll
logical left shift
shift left (logical)
Shift left logical
Shift Left Logical
Shift Left

srl
logical right shift
shift right (logical)
Shift right logical
Shift Right Logical
Shift Right

sub
subtraction
subtract
Subtract
Subtract
Subtract

sra
arithmetic right shift
shift right (arithmetic)
Shift right arithmetic
Shift Right Arithmetic
Shift Right Arithmetic

lb

load byte
Load byte

Load Byte

lh

load halfword
Load halfword

Load Halfword

lw

load word
Load word
Load Word
Load Word

ld

load doubleword
Load doubleword

Load Double

lbu

load byte unsigned
Load byte unsigned

Load Byte Unsigned

lhu

load halfword unsigned
Load halfword unsigned

Load Halfword Unsigned

lwu

load word unsigned
Load word unsigned

Load Word Unsigned

ldu

load doubleword unsigned

Load Double Unsigned

sb

store byte
Store byte

Store Byte

sh

store halfword
Store halfword

Store Halfword

sw

store word
Store word
Store Word
Store Word

sd

store doubleword
Store doubleword

Store Double

addiw

add immediate word
Add immediate word

ADD Immediate Word

addw

add word (RV64)
Add word

ADD Word

subw

subtract word (RV64)
Subtract word

Subtract Word

sllw

shift left (logical) word (RV64)
Shift left logical word

Shift Left Word

srlw

shift right (logical) word (RV64)
Shift right logical word

Shift Right Word

sraw

shift right (arithmetic) word (RV64)
Shift right arithmetic word

Shift Right Arithmetic Word

slliw

shift left (logical) immediate word (RV64)
Shift left logical immediate word

Shift Left Immediate Word

srliw

shift right (logical) immediate word (RV64)
Shift right logical immediate word

Shift Right Immediate Word

sraiw

shift right (arithmetic) immediate word (RV64)
Shift right arithmetic immediate word

Shift Right Arithmetic Imm. Word

fence

fence (memory)
Memory ordering fence

Sync Thread

fence.tso

fence (total store order)

fence.i

fence (instruction)

Sync Instruction & Data

ecall
environment call
environment call
Environment call

mret

machine-level return
Machine Exception Return

sret

supervisor-level return
Supervisor Exception Return

ebreak
environment breakpoint
environment breakpoint
Breakpoint exception

wfi
Wait for Interrupt
wait for interrupt
Wait for interrupt

sfence.vma
supervisor memory-management fence
supervisor memory-management fence (virtual memory address)
Supervisor memory-management fence


Add test for "unreachable code"

https://github.com/nbQA-dev/nbQA/blob/350f7bacbf76dda0e98ea41563c1cdd6641035ab/nbqa/replace_source.py#L61-L63
this is actually reachable if the tool "eats" the entire cell's contents

(except for comments)


resize image in edit view

I want to show full image in edit or filter view but at the moment I only get cropped image if image size is too large.
Any idea how to do this?

@kuls14 Also interested.

@kuls14 I found the answer. You should go to SquareEditingStack and comment all the code.

@Arideno  I have tried your solution but it doesn't seem to work

Same issue here. Image get's cropped first time that it's edited.

@Rep2 I'm having the same issue. Have your figured out a fix?

@UNLK8852 no, didn't find a solution

does anyone know how to turn off square cropping?

If anyone still looking for a solution, this might help. Just look for a initialCrop function inside SquareEditingStack class. then just remove the custom square size. that's it ...

@Jeplin thanks for the comment. A little bit of further investigation showed that the you can disable SquareEditingStack in PixelEditViewController using usesSquareCropping: false in init


updated names of expeditions

Some of the names in the API seemed outdated so I renamed them to their actual questnames. Makes it easier to follow what you are actually choosing.

Thank you! I actually don't know if I want to merge this yet. I assume this is correct, but this would be a breaking change for not that much upsight. Even then, I think the other names would also have to be renamed accordingly:
Cauldron = 101,
Witch = 102,
WitchesBrew = 103,

The actual game client still uses the old names, so I doubt the interaction with them has changed enough to warrant a breaking change like that tough (Regardless of Witches brew, or Balloons quest, you pickup well/cauldron first). So I would prefer this to just be doc comments for now.
/// New name: Cauldron
Well = 101,
/// New name: Witch
Girl = 102,
/// New name: WitchesBrew,
Balloons = 103,

That way old code continues to work and a new dev can just read the IDE documentation, or jump to definition to see, what they are called now.
What do you think?


Broken Find In Files function on OS X

With this theme installed, I can't use Find In Files function on OS X.

Uh oh. I've actually solved this by dragging the panel up -- can't get it back into this state neither! :smile:


Installation failed

yarn install failed with this error:
	Configuration for rule "react/jsx-sort-props" is invalid: 	Value "data["0"].shorthandLast" has additional properties.         Configuration for rule "react/jsx-sort-props" is invalid: 	Value "data["0"].shorthandLast" has additional properties.

Looks like jsx-sort-props has something to do with yannickcr/eslint-plugin-react (a dev dependency of this project) but I'm not sure why you'd be seeing this error on install. The issue doesn't seem specific to react-codemod though. See:

https://github.com/airbnb/javascript/issues/1016
https://github.com/airbnb/javascript/issues/979
https://github.com/react-boilerplate/react-boilerplate/issues/895
etc

A fresh install (of this project) works fine for me. Maybe check out the troubleshooting suggestions mentioned on the issues I linked to and see if any of them help you out?
I'm going to close this issue for now since I don't think this is caused by react-codemod.


Finally my bots are spawning every 5 seconds and i get 75 bots :v

update all in the FreeAgarBots v2.5 im tested now and it's working. I made a changes of this repo for obtain 75 bots

does it follow the mouse?

skype me please i need help with mine my skype is darkhound123!!!


[eosiolib]multi_index wrong code comment

Hi,
eosio::multi_index::index::upper_bound(uint64_t) does return one past the last element (end() if none) and does not return the last item within the given bound. This contradicts the documentation (see below). I think code behaviour is "correct" per c++ iterator  standards and code doc. should be updated.
Thanks

/**
       *  Searches for the `object_type` with the highest primary key that is less than or equal to a given primary key.
       *  @brief Searches for the `object_type` with the highest primary key that is less than or equal to a given primary key.
       *
       *  @param primary - Primary key that establishes the target value for the upper bound search
       *
       *  @return An iterator pointing to the `object_type` that has the highest primary key that is less than or equal to `primary`. If an object could not be found, it will return the `end` iterator. If the table does not exist** it will return `-1`.
       *

You are correct.  Can you clean up the comment and make a Pull Request?  Make sure you use develop branch.

This is similar to std::map::upper_bound which returns the pointer to the element next to the highest element of the key. For example, to iterate all the elements of the same key
for (auto i = idx.lower_bound(key); i != idx.upper_bound(key); ++i) { ... }

@taokayan the comment is wrong.  The line:
"Searches for the object_type with the highest primary key that is less than or equal"
should be:
"Searches for the object_type with the highest primary key that is greater than"
@awalga can you fix that (and any other instances that are wrong in that comment and submit a Pull Request?

Resolved by #6285.


Potential NPE in ACL plain

BUG REPORT

Please describe the issue you observed:

Our code analyses found the following potential NPE:

Return null to caller
https://github.com/apache/rocketmq/blob/b4240d5cea8d001c21b9c0d73f5aa700fcd0d568/acl/src/main/java/org/apache/rocketmq/acl/common/AclUtils.java#L276

Function getYamlDataObject executes and returns
https://github.com/apache/rocketmq/blob/b4240d5cea8d001c21b9c0d73f5aa700fcd0d568/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java#L134

aclAccessConfigMap is passed as the this pointer to function java.util.Map.get (aclAccessConfigMap can be null)
https://github.com/apache/rocketmq/blob/b4240d5cea8d001c21b9c0d73f5aa700fcd0d568/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java#L137

Commit: b4240d5cea8d001c21b9c0d73f5aa700fcd0d568

Please tell us about your environment:
N/A

Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):

Does anyone solve this problem，could I submit a PR to fix it?

would you like to submit a PR to fix it?

Does anyone solve this problem  now，could I submit a PR to fix it?

would you like to submit a PR to fix it?

Does anyone solve this problem now，could I submit a PR to fix it?

Not yet. Would you please submit the PR? Thanks.

would you like to submit a PR to fix it?

Does anyone solve this problem now，could I submit a PR to fix it?

Not yet. Would you please submit the PR? Thanks.
OK


Refactor: Migrate to simple Job builder

No need build and unwrap when build a job.
let job = Print { number: 1 }
        .job()
        .delay(Duration::seconds(1));

https://github.com/cptrodgers/aj/issues/8


Validate if a string is less or equal if the value is different from nil

[x ] I have looked at the documentation here first?
[ x] I have looked at the examples provided that may showcase my question here?

Package version eg. v9, v10:
v10.11.0
Issue, Question or Enhancement:
I want to validate a string is less or equal than 20 if the value is different from nil.
Code sample, to showcase or reproduce:
This is the struct trying to validate.
type UpdateRequest struct {
	Slug *string `validate:"max=20"`
}

Also tried with this struct.
type UpdateRequest struct {
	Slug *string `validate:"lte=20"`
}

The field Slug is a pointer so I think it should be validated only if the value is different from nil but if I send a nil value, the validation fails. Is there a way to validate the string length only if the value is different from nil?

Ohh, I wasn't aware of "omitempty". This is the working solution.
type UpdateRequest struct {
	Slug    *string    `json:"slug" validate:"omitempty,max=20"`
}


172420671 common tests

This PR makes a base set of tests that all classes implementing the QuantumBackend or QuantumSimulator interfaces need to satisfy.

Added some basic test cases here: 8170d63. I think if we want to increase our test coverage, we should leave that for a future story.


Fix copyright year syntax

I forgot vue init tries to parse {{  }}, and thus caused error when trying to use.
This properly escapes the mustache syntax in the component so that it doesn't cause any error now. \{{  }}

PR#60 Also fixes this issue (and others) and can be merged instead of this PR if approved.


How to load a string with Netron Load method?

I am using Netron V2. It's a great software.
In some times, I need to use a string and not a URL or a local HTML file. And I also don't want to make the string in a local storage.
So I think if it's possible to make the Load method support not only URL and file, but also a HTML string?
Is it possible?
Thanks very much.

I have know how to do it.

There always be.

Example can be found in the documentation:
neutron := NeutronWindow("abc")


Docker UI stop to restart stopped UI containers

Create a special container that can take web requests for stopped UI containers, then restart the container and re-direct the request. This would probably require an extra configuration in jwilder/nginx-proxy to recieve the stopped event and transfer to a new container.

Could use docker-py to read events from the docker socket, then control NGINX. Probably could just duplicate most of  jwilder/nginx-proxy, with a bit more complexity.
If so, should definitely have the controller running in a seperate process, and nginx mapps in the config file, with inotify to restart on changes.


Update dependencies

Move SVGO to version 1.0.5 and refactor to handle optimize() returning a promise.
Drop RSVP dependency.
Update broccoli dependencies.

Sorry about the test failures, I didn't think to check the travis file.


[DTK] repo changed

I can't open issues on the superproject, so i put it here.
The dtk repo changed to gitlab. medInria3 has already applied the change here: https://github.com/medInria/medInria-public/pull/336
We need to change the repo also, music does not compile for now

It seems that this was only a connexion problem.
The original medInria clone is http://dtk.inria.fr/+medinria/dtk/dtk-clone-medinria
However, medInria no longer uses this old clone, and uses https://gitlab.inria.fr/dtk/dtk which is only supporting Qt5 even older versions.
An other example that we soon need to switch to medInria2/MUSIC3 :).
I close for now this issue.


[ISSUE-30] Remove closed requirements from versioning

Close #30
I came to the conclusion that it is better not to version closed requirements. The main reason is that I realised that, by tracking closed requirements, they will (correctly) be used as lock files during CI-CD workflows and thus we will not test the most updated package configurations (available with any tested python version) ignoring some possibile issues (e.g. in this very PR I had to change line 141 of py4ai/core/data/model/ml.py because the old version of mypy we used didn't mark that  a parameter typed as str could not be defaulted to None)

Should we close (without merging) this PR given the discussion on issue #30 ?

Should we close (without merging) this PR given the discussion on issue #30 ?

Actually I found probably a better solution than simply ignoring closed requirements: I modified Makefile so that existing requirements*.txt files are not used as lockfiles anymore.
This way we could keep on versioning closed requirements files, giving the users a reference for a working environment, but they are not used as lockfiles anymore (i.e. we can check updates in our dependencies).
To me this is the best solution for a library like this one (in contrast to an application, where requirements should be kept as stable as possibile to facilitate portability)

Yes, it actually seems nice. I didn't have time to try poetry yet but I followed the project and it actually looks good. Please go ahead with a PR!


Re-enable capturing of error logs

About 2 weeks ago, I implemented node-level error handling. Well, that was really nice, but hid a bunch of node errors from getting captured in DD and Sentry. This PR logs out the errors to Sentry and DD before returning the response to the caller.

Does this mean you could remove the logging.error calls I added?

Yes, this is the plan - i want to verify this logging approach does get to both services though. The logging.error calls in value_or_error are not producing anything in DD to my understanding


Added hashcash

I'm still not sure about this way of integrating with OT. I extended CollectorTraceExporter and overridden _sendData method (which would needed to be created in the OT-JS repository). Any other ideas are welcome.

This idea has been dropped.


#4482 Correct the DataTypeName for PostgreSQL

Fixes #4482.
Changes proposed in this pull request:

add PostgreSQL dataType

Note:

doublePrecision is support double precision . DATATYPE-FLOAT
identifier is support complex type ROWTYPES-DECLARING

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@95779d7). Click here to learn what that means.
The diff coverage is 10.32%.

@@            Coverage Diff            @@
##             master    #4525   +/-   ##
=========================================
  Coverage          ?   55.47%
  Complexity        ?      331
=========================================
  Files             ?      953
  Lines             ?    17942
  Branches          ?     3396
=========================================
  Hits              ?     9953
  Misses            ?     7348
  Partials          ?      641

Impacted Files
Coverage Δ
Complexity Δ

...t/ddl/column/alter/AddColumnDefinitionSegment.java
0% <ø> (ø)
0 <0> (?)

...dl/column/alter/ModifyColumnDefinitionSegment.java
0% <ø> (ø)
0 <0> (?)

...nt/ddl/constraint/ConstraintDefinitionSegment.java
0% <ø> (ø)
0 <0> (?)

...l/segment/dml/item/ShorthandProjectionSegment.java
0% <ø> (ø)
0 <0> (?)

...e/sql/parser/sql/segment/generic/TableSegment.java
33.33% <ø> (ø)
0 <0> (?)

...l/parser/sql/segment/dml/column/ColumnSegment.java
50% <ø> (ø)
0 <0> (?)

...er/sql/statement/generic/AbstractSQLStatement.java
100% <ø> (ø)
1 <0> (?)

.../sql/parser/sql/statement/dcl/RevokeStatement.java
0% <0%> (ø)
0 <0> (?)

.../sql/parser/visitor/impl/PostgreSQLDMLVisitor.java
0% <0%> (ø)
0 <0> (?)

...ingsphere/sql/parser/visitor/SQLServerVisitor.java
0% <0%> (ø)
0 <0> (?)

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95779d7...88f3a0c. Read the comment docs.

Pull Request Test Coverage Report for Build 9872

0 of 6 (0.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.03%) to 59.113%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java
1
0%

sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java
3
76.0%

Totals

Change from base Build 952:
-0.03%

Covered Lines:
10606

Relevant Lines:
17942

💛  - Coveralls

I wonder whether you want to continue to involve in the community to do anything interesting or go on with #4482?

Yes, I want to continue to participate and contribute to the community. # 4482 I will continue to finish.

Yes, I want to continue to participate and contribute to the community. # 4482 I will continue to finish.

@yuzel
Very welcome. But my suggestion is to follow your own pace since I do not want this issue to stress you too much. 😃
Grow up with the community and demonstrate your capabilities!

MONEY is not a keyword of PostgreSQL.
https://github.com/postgres/postgres/blob/d952373a987bad331c0e499463159dd142ced1ef/src/include/parser/kwlist.h