How to enable Rewind when using the Pipeline API?

As the docs says "Pipelines are recommended over streams", people now are trying the new Pipes API.  I notice there's a  dev blog:

the other core pipelines feature is the ability to peek at data in the Pipe without actually consuming it.

But how could we read the HTTP Request Body without actually consuming it? I thought if we don't invoke pipeReader.AdvanceTo(s,e), the body won't be consumed. So I tried create a middleware like this:
async Task IMiddleware.InvokeAsync(HttpContext httpContext, RequestDelegate next)
    {
        if(httpContext.Request.Method != HttpMethods.Post){
            return;
        }
        PipeReader bodyReader = httpContext.Request.BodyReader;
        ReadResult readResult;
        while(true){
            readResult = await bodyReader.ReadAsync();
            if(readResult.IsCompleted)
            {
                break;
            }
        }
        Process(readResult.Buffer);  // process the read only sequence
        // we don't invoke the bodyReader.AdvanceTo(s,e) method here
        bodyReader.Complete();     //  with this line , or without this line, both doesn't work
    }

But it doesn't work. Is there any guide for this ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 49b15fd3-39b5-3ad9-8c4e-b8160360dee9
Version Independent ID: c33981af-93ce-d4be-a265-5d4696666c7a
Content: Request and Response operations in ASP.NET Core
Content Source: aspnetcore/fundamentals/middleware/request-response.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @jkotalik
Microsoft Alias: jukotali

You can call PipeReader.Advance(readResult.Buffer.Start, readResult.Buffer.End); By passing in readResult.Buffer.Start for consumed, you are saying that you haven't consumed any of the ReadResult. By passing in readResult.Buffer.End, you are saying you have examined everything, which tells the Pipe to not free any buffers and the next time ReadAsync returns, more data would be in the buffer.
As a general rule as well, each call to ReadAsync must be paired with a call to Advance.
async Task IMiddleware.InvokeAsync(HttpContext httpContext, RequestDelegate next)
    {
        if(httpContext.Request.Method != HttpMethods.Post){
            return;
        }
        PipeReader bodyReader = httpContext.Request.BodyReader;
        ReadResult readResult;
        while(true){
            readResult = await bodyReader.ReadAsync();
            if(readResult.IsCompleted)
            {
                break;
            }
            bodyReader.Advance(readResult.Buffer.Start, readResult.Buffer.End);
        }
        Process(readResult.Buffer);  // process the read only sequence
        bodyReader.Complete();     //  with this line , or without this line, both doesn't work
    }

@newbienewbie  that's all covered in https://docs.microsoft.com/en-us/dotnet/standard/io/pipelines

@jkotalik @Rick-Anderson Thanks so much for your detailed explanation!


Add a CLI tool

Might help to fix https://github.com/okfn/datapackage-validate-py/issues/7
Maybe some feature are missing such as validating several files (glob https://docs.python.org/3/library/glob.html might help)

@scls19fr Thanks for the PR, it looks good! Unfortunately, it was sent in a bad hour. We've just merged this repository into https://github.com/datapackages/datapackage-py. I tried cherry-picking your PR to keep you as the author, but there were too many conflicts.
It would be great to have a CLI command like datapackage validate /path/to/datapackage.json in that other project. If you have some time, would you mind sending this PR to the other repository?
Sorry again for the changes, and thanks for your contribution :+1:


See which programs are associated with a given question

Somewhere on the page for a specific question, show the programs it is associated with. Feedback/idea from Rochester.

Repeat of #239


Q: How to auto rename internal link complement

I set new link format to relative path to file and in #116 it already impliment link to match obsidian settings.
somehow, I want to auto rename like obsidian internal link suggest does. (example: ../foo/bar will create [[../foo/bar|bar]])
I see that it has option insert an alias that transformed from the displayed internal link that my solve my problem. but I don't know how to use regex... I tried to learn how to code it before but no luck... I still confuse and can't learn it by myself. so I open this issue to ask question...
Thanks
tldr; I want to insert alt name when enter internal link complement. from [[../path1/path2/filename]] to [[../path1/path2/filename|filename]]

Hi, @l2eused :)
Please try to set .+/(?<name>.+)$ 👍


Fix update_crds for istio/api having a beta.0 label

Please provide a description of this PR:
In the release-1.20 branch, the RMs ran go get<EMAIL_ADDRESS>as part of the update_deps. This updated the go.mod to have a version like:
	istio.io/api v1.20.0-beta.0

The update_crds script failed with this trying to checkout the beta.0 branch (which doesn't exist). The code was updated for rc and beta similar to the istio/istio code later in the script (noting we have a . after beta and rc in our labels) to fix the issue in the release-1.20 branch in https://github.com/istio/istio/pull/47625.
This is a manual cherry pick of the script change only to the main branch.

/cherry-pick release-1.20

@ericvn: new pull request created: #47633

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cherry-pick release-1.19

@ericvn: new pull request created: #48616

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


[App Deploy Improvements] Create PR title suggestion in Checklist

Context
https://expensify.slack.com/archives/C07J32337/p1727090083328389
Solution

[ ] Update the PR Checklist
[ ] See about updating the PR template to include a title hint

Not overdue

Two options I think:
[Type][Scope/Feature]: Brief description of change

[Type][Scope/Feature]: Brief description of change (Github Ticket/Issue ID)

Originals
	•	fix: [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen.
	•	fix: Error when selecting distance rate that no longer has tax rate.
	•	Fix - Attachment - Unable to download a txt attachment until the browser is refreshed.
	•	Use SearchRouter everywhere and drop Chat finder.
	•	fix: update library and patch for react-native-config.
	•	Support empty value for categories and tags.
	•	fix: Tapping thread reply of expense hold offline, hmm not here displayed briefly.
	•	[P2P Distance] Rate currency doesn’t match expense currency.
	•	Fix report screen opened in background when starting QAB flow.
	•	[Expense ReportPreview Avatar] Update report preview avatar to use owner.
	•	fix deleted message not found page.
	•	Debug Mode - “Has RBR” is not shown for report that has RBR in LHN.

Example with [Type][Scope]
	•	[Fix][P2P Distance]: Participants amount displayed 0.00 briefly on confirmation screen
	•	[Fix][Tax Rate]: Error when selecting distance rate with no tax rate
	•	[Fix][Attachment]: Unable to download a txt attachment until browser refresh
	•	[Chore][Search]: Use SearchRouter everywhere, remove Chat finder
	•	[Fix][Library]: Update react-native-config
	•	[Fix][Tags/Categories]: Support empty values
	•	[Fix][Offline]: Thread reply shows “not here” briefly on expense hold
	•	[Fix][P2P Distance]: Rate currency mismatch with expense currency
	•	[Fix][QAB]: Report screen opened in background during flow
	•	[Update][Expense]: Update report preview avatar to owner
	•	[Fix][Deleted Message]: “Message not found” page error
	•	[Fix][Debug Mode]: “Has RBR” not shown for RBR reports

Example with [Type][Scope] and issue
	•	[Fix][P2P Distance]: Participants amount displayed 0.00 briefly on confirmation screen (#47370)
	•	[Fix][Tax Rate]: Error when selecting distance rate with no tax rate (#49044)
	•	[Fix][Attachment]: Unable to download a txt attachment until browser refresh (#49898)
	•	[Chore][Search]: Use SearchRouter everywhere, remove Chat finder (#49984)
	•	[Fix][Library]: Update react-native-config (#50059)
	•	[Fix][Tags/Categories]: Support empty values (#50122)
	•	[Fix][Offline]: Thread reply shows “not here” briefly on expense hold (#50126)
	•	[Fix][P2P Distance]: Rate currency mismatch with expense currency (#50142)
	•	[Fix][QAB]: Report screen opened in background during flow (#50200)
	•	[Update][Expense]: Update report preview avatar to owner (#50424)
	•	[Fix][Deleted Message]: “Message not found” page error (#50440)
	•	[Fix][Debug Mode]: “Has RBR” not shown for RBR reports (#50468)

	•	[P2P Distance]: Participants amount displayed 0.00 briefly on confirmation screen
	•	[Tax Rate]: Error when selecting distance rate with no tax rate
	•	[Attachment]: Unable to download a txt attachment until browser refresh
	•	[Chore][Search]: Use SearchRouter everywhere, remove Chat finder
	•	[Library]: Update react-native-config
	•	[Tags/Categories]: Support empty values
	•	[Offline]: Thread reply shows “not here” briefly on expense hold
	•	[P2P Distance]: Rate currency mismatch with expense currency
	•	[QAB]: Report screen opened in background during flow
	•	[Expense]: Update report preview avatar to owner
	•	[Deleted Message]: “Message not found” page error
	•	[Debug Mode]: “Has RBR” not shown for RBR reports

In terms of readability,
[Type / Project Name][Feature/Scope] <description> is probably my preferred method

not overdue, monthly

not overdue


Added Peterson Graph Problem

Added Peterson Graph Problem python code under the Python Folder.

You are good to go with Peterson graph Problem. Just remove the Binary search commit so that we can merge your PR

Heya,
I have deleted the branch I used to commit the binary search program using
git push origin --delete new-branch.
Do I need to make any more changes?
On Thu, Oct 1, 2020 at 1:31 AM Paurush Tiwari<EMAIL_ADDRESS>wrote:

You are good to go with Peterson graph Problem. Just remove the Binary
search commit so that we can merge your PR
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/geekquad/AlgoBook/pull/27#issuecomment-701613713, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMKZQ5TYGOW4567AT7BQ263SIOFCFANCNFSM4R7QBIJA
.

@SaiAshish2906 the problem still persists. We can still see your 2 commits, one for Peterson and other for binary. Resolve this issue anyhow, so that we can finally merge.


Kotlin 1.5.0-RC compatibility issue

Hello, Kotlin 1.5.0-RC is around the corner and I checked if it played nicely with KtRssReader, but due to the new Duration api changes it wasn't happy about it;
java.lang.NoSuchMethodError: No static method getDays(I)D in class Lkotlin/time/DurationKt; or its super classes (declaration of 'kotlin.time.DurationKt' appears in /data/app/~~8tbLKXsRF-XaLJOxrS_dhQ==/com.example.test.android.app-6jJoF5SXNmXOC7dOK8x6_g==/base.apk!classes26.dex)
        at tw.ktrssreader.config.KtRssReaderConfig.<init>(KtRssReaderConfig.kt:31)
        at com.example.test.android.feed.net.FeedNetDataSourceImpl.read(FeedNetDataSourceImpl.kt:19)
        at com.example.test.android.feed.FeedRepositoryImpl$fetchFeed$2.invokeSuspend(FeedRepositoryImpl.kt:52)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
        at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

I started here: https://github.com/ivanisidrowu/KtRssReader/pull/70 but I havent tried it yet since I couldn't figure out where you change the project version so I could publish locally and try it in my own project..
edit: I did some further investigation and its still unclear what causes this crash, only did the problem go away if I uninstalled the kotlin plugin in android studio (canary) and reinstalled the latest stable one via File -> Settings -> Build, Execution, Deployment -> Build Tools -> Gradle.

Update: this seems to have been caused by a bug in the kotlin compiler plugin. Kotlin 1.5.0 was released today together with a new compiler plugin and I no longer get this issue. I'll close this issue, feel free to do whatever with the pull request #70

@sphrak, thanks for the contribution!

@ivanisidrowu I take it back, I was too quick yesterday -- the issue reported does not happen at compile time -- only in runtime so the issue is still there. I will fix the comments and also target the stable version instead of the release candidate


update import to add 2 new NCBITaxon

@sabrinatoro do you also plan to create a PR to add NCBITaxon:87882 to https://github.com/obophenotype/ncbitaxon/blob/master/subsets/taxon-subset-ids.txt?
I think this additional step was added during a time you were OOO, https://mondo.readthedocs.io/en/latest/editors-guide/import-terms-for-logical-axioms/#detailed-instructions-for-adding-a-new-ncbi-taxon-identifier

@sabrinatoro do you also plan to create a PR to add NCBITaxon:87882 to https://github.com/obophenotype/ncbitaxon/blob/master/subsets/taxon-subset-ids.txt?

I did not, and didn't realize there was a specific extra step for NCBITaxon. I will try this and reach out if there are still problems. Thanks!

This extra step will not fix the other problem of the taxon not being added, but also hopefully will not create any new problems :)


fix Issue 15000 - Changes to userShell either need to be reverted or …

…the std.process documentation needs to be updated
https://issues.dlang.org/show_bug.cgi?id=15000

Auto-merge toggled on

LGTM, agree that the changes to userShell were merged a little too hastily.


Folder path setting cannot be saved

Folder path setting cannot be saved，as shown in the following screenshot

Hey! I've been trying to recreate this, but haven't been able to.
Could you walk me through the steps you take?
Is it the enabling of the setting that doesn't save? Or does it not, when you write a folder path and press enter, save that path?

I also thought it was a bug, but apparently I wasn't using it correctly!
After you select the folder you need to type Enter and it will actually add a folder.
@chhoumann maybe a button "Add" next to the selection field will make it more clear?

As @aviskase says, an extra hit of the enter key is required to save correctly.Thanks aviskase for the answer.
There is another problem though, after adding a path, clicking the delete button does not work.

You are absolutely right. I will add buttons to make this more clear. Thank you!

As @aviskase says, an extra hit of the enter key is required to save correctly.Thanks aviskase for the answer.
There is another problem though, after adding a path, clicking the delete button does not work.

This should already have been fixed. Please update to the latest version :)


Add support for different time ranges (e.g. days, weeks, months)

[x] Replace month-centric index+duration with start/stop date.
[x] Scale horizontal axis (and labels) to fit the supplied tasks.
[x] Don't mutate dates; store temporal metadata in a Map somewhere.
[x] Auto-import and upgrade previous data format from URL.
[ ] Add e2e tests.
[ ] Re-consider @js-temporal/polyfill usage (it's pretty large; maybe check dayjs?)

Example data

View months example
View weeks example
View days example

Screenshots

Seeing some e2e snapshot flakiness; reported via https://github.com/microsoft/playwright/issues/11177


Issue #102 - accomplishments

Fix Issue #102

Update template selectors with new accomplishments
Fix existing template selectors for accomplishments
Update profile with new accomplishments
Update profile cleaner with new accomplishments
Add logic to click "Show More" buttons on accomplishments

Included in PR #121


Scoping of using

It's not an issue but rather a question.
In the code example provided, if I rewrite it like this:
string manyLines=@"This is line one
This is line two
Here is line three
The penultimate line is line four
This is the final, fifth line.";

using var reader = new StringReader(manyLines);
ReadAndLog(reader);

public void ReadAndLog(StringReader reader)
{
    string? item;
    do {
        item = reader.ReadLine();
        Console.WriteLine(item);
    } while(item != null);
}

Will the object reader still be properly disposed?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 042902cc-1598-5df1-34cc-caa0fad63e02
Version Independent ID: e186d0c4-523e-38f7-2cde-d00109ea784b
Content: using statement - C# Reference
Content Source: docs/csharp/language-reference/keywords/using-statement.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Yes.
It's equivalent to
using (var reader = new StringReader(manyLines))
{
    ReadAndLog(reader);
}

as the scope isn't "longer".

Thanks for the question @cnotoham and the prompt answer @gfoidl
I'll close this as an answered question.


Feature Request: extend 3d conformation useBasicKnowledge to force chair\boat\twisted conformation for heterocycles

Is there any way to force a cycle, for example in C1CCN(CCCC)CC1, to be always in 3D chair conformation? Currently, different conformers have different conformations even after optimizing each conformer with UFF and\or MMFF optimization.
I guess that useBasicKnowledge in conformer generation should be extended to include this option.

Is there a built-in way to do this? Thanks!


Update mamba blog post to recommend miniforge instead of mambaforge

mambaforge is discontinued and it is integrated into miniforge now (check message below from miniforge Github repository):

Click to see message
Mambaforge (Discouraged as of September 2023)
With the [release](https://github.com/conda-forge/miniforge/releases/tag/23.3.1-0) of Miniforge3-23.3.1-0, that incorporated the changes in https://github.com/conda-forge/miniforge/pull/277, the packages and configuration of Mambaforge and Miniforge3 are now identical. The only difference between the two is the name of the installer and, subsequently, the default installation directory.
Given its wide usage, there are no plans to deprecate Mambaforge. If at some point we decide to deprecate Mambaforge, it will be appropriately announced and communicated with sufficient time in advance.
As of September 2023, the new usage of Mambaforge is thus discouraged. Bug reports specific to Mambaforge will be closed as won't fix.

The link should still be this one: https://github.com/conda-forge/miniforge#miniforge3
But we should point to download and install miniforge instead of mambaforge. The rest can remain the same, mamba should work from miniforge.

One of the screenshots needs t be updated

Solved via #80 and #74


MountVolume.SetUp failed for volume "higress-ca-root-cert" : configmap "higress-ca-root-cert" not found

MountVolume.SetUp failed for volume "higress-ca-root-cert" : configmap "higress-ca-root-cert" not found
应该如何排查呢？

看一下 controller pod 有没有正常启动
---- Replied Message ----
| From | @.> |
| Date | 10/17/2024 05:09 |
| To | alibaba/higress @.> |
| Cc | Subscribed @.***> |
| Subject | [alibaba/higress] MountVolume.SetUp failed for volume "higress-ca-root-cert" : configmap "higress-ca-root-cert" not found (Issue #1401) |
MountVolume.SetUp failed for volume "higress-ca-root-cert" : configmap "higress-ca-root-cert" not found
应该如何排查呢？
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

谢谢回复，controller pod已经是启动状态；
Volume问题好像部署etcd也有问题，我先自己本地排查一下吧；多谢您。


chore(ci): specify Node version in CodeSandbox CI

This is an attempt at installing a specific Node version in the CodeSandbox CI.

CodeSandbox now supports specific Node versions in their configuration: https://github.com/algolia/autocomplete.js/blob/06cb3d9306c06624c4b9d7d4254db08905f645b2/.codesandbox/ci.json#L6


Feature: Write conversion of Rocrate to zip files

The microservice assumes that it will get the Rocrate zip file in a request to interact and store.
This feature will make sure that a user is downloading this microservice as a Python package and has a directory in the local system, it first gets converted into zip file and then in the request, it will be sent as binary or form data.

I'm not sure I fully understand what you want to do here. Can you please increase the description? :)


compiling resources

Hi , is there any wrapped command for things like : pyside-rcc and pyside-uic , so does pick up the right one depending on the framework in use ?

wondering, if the tool has to work on more than one (eg: PySide/PySide2) ... should resource should be compiled for both ?

checking now, but should be compatible, so is matter of having some logic on when we compile the resource files.

ok looks like is not, as in the compiled resouce file  we end up (eg: pyside) with from
PySide import QtCore

There isn't any wrapper at the moment, but one could potentially be built in.
I reckon that if the resulting resources can't be used in all bindings, then there probably isn't much point in wrapping it.
If you were to provide a wrapper, it could get tested on each supported platform and each supported binding via Travis and the pull request.  Have a look at the currently ongoing pull request for load_ui for example.

To my knowledge, pysideuic is its own module and is not part of PySide or PySide2. So far, we haven't attempted to map modules which aren't part of the actual bindings but I can't see why this could not be done.
How would such a module be imported though?
Perhaps something like this:
from Qt import pysideuic

...?

Oh, wait, are we talking about the standalone executables such as pyside-uic.exe?

Thinking of fixing this in the various setup.py which are doing the
compilation  of the resources, replacing in the compiled resource :
.QtGui with Qt.QtGui
On Aug 4, 2016 09:26, "Fredrik Averpil"<EMAIL_ADDRESS>wrote:

Oh, wait, are we talking about the standalone executables such as
pyside-uic.exe?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mottosso/Qt.py/issues/88#issuecomment-237474231, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAYavSjZZoMKINc4ScTLrN5hI7dqnXY8ks5qcZQJgaJpZM4JbonW
.

Thinking of fixing this in the various setup.py which are doing the
compilation  of the resources, replacing in the compiled resource

Possible to show an example of this?

Sure, so when you compile an py from an rcc file, the first lines of the compiled one looks like this:
# -*- coding: utf-8 -*-

# Resource object code
#
# Created: Fri Aug 5 10:17:32 2016
#      by: The Resource Compiler for PySide (Qt v4.8.5)
#
# WARNING! All changes made in this file will be lost!

from PySide import QtCore
qt_resource_data = "......................."

This should be changed after the compilation as :
# -*- coding: utf-8 -*-

# Resource object code
#
# Created: Fri Aug 5 10:17:32 2016
#      by: The Resource Compiler for PySide (Qt v4.8.5)
#
# WARNING! All changes made in this file will be lost!

from Qt import QtCore
qt_resource_data = "......................."

I'll give this  a shot and let you know.
This way we should be able to provide backward compatibility.

so, in the setup.py of the tool I'm working in at the moment, I've been adding a post processing call which does pretty much this, which seems to be working fine :
import fileinput
filepath = '/home/efesto/Desktop/resource.py'
replace = 'from Qt import QtCore'
for line in fileinput.input(filepath, inplace=True):
	if 'import QtCore' in line:
		print line.replace(line, replace)
	else:
		print line

wondering, does worth providing a wrapper with popen which kicks the compilation and replace ?
it could be retained in a /bin folder under the project as qt-rcc
let me know.
Cheers.
L

Interesting. I haven't used these features myself, so I'll rely on your experiences.
I'm a bit blurry on how the setup.py comes in to play. Are you saying that you distribute your software with a PyQt or PySide compiled resource file, and re-map it when setup.py is used? That is, during installation?
Could you show a small runnable example?

To cut to the chase, what I'm looking for is the tests for this feature, before we start talking about an implementation.
The tests will more or less be the minimal, yet complete, examples that you come up with. Once there are tests, it will be more easily understood what your end game is and how we can reach it.
For example.
def test_compile_resources():
  import Qt
  Qt.compile_resources(dirname="/path/to/resources", fname="my_resources.py")
  assert os.path.isfile("path/to/resources/my_resources.py"), "nothing written"

This tells us, in just a few lines:

How to use the end result
What the interface will look like
What the expected result is

The tests could also include importing this file and asserting some of its content, like (1) the variable in which the data resides and (2) the header comment and (3) the use of Qt instead of PySide etc.

How about this for support coming from Qt.py?

Compile natively with either PyQt or PySide
Search-and-replace PyQt or PySide with Qt and write a new file
Done

That way, developers can work natively and Qt.py doesn't have to wrap any functionality, whilst still being able to provide support for all bindings. Win-win-win.
The interface could look something like this.
$ pyside-uic my_resources # writes my_resources.py
$ python -m Qt --convert my_resources.py # writes my_resources_qt.py

I wonder if they produce identical results though?
If so, I agree this is a win-win-win 😉

isn't it a bit inconsistent as you are providing wrappers for loading the ui ?
This two step process doesn't make much sense, either is done from within the code (Qt.compile_resource(in, out) ), or for me , simply worth keeping it on the various setup.py

simply worth keeping it on the various setup.py

Fair enough. Let's make it part of the docs on how to do that, and we're done.

cool, then please remember to add this also for the uic files, otherwise people will be having all sorts of issues.
Cheers.
L.

then please remember to add this also for the uic files

What uic files? Sorry, I don't follow.

Ui (uic) files are created through designer-qt4 and the can be compiled
(similarly to resources) to py using pyside-uic
This, usually, allow to load the ui faster than through the load ui
command.

I see, ok. Would you be up for writing this part of the README?

@hdd please have a look at the latest release which implements the alpha feature --convert: https://github.com/mottosso/Qt.py/releases/tag/0.5.0

I think Lorenzo is asking about compiling resources, such as png's and jpeg's, into a .py file. --convert only handles .ui files.

Oh 😮 allright 😄


Included tag search capabilities

Resolves #31998
The first screenshot shows the tag page without any filter being applied:

The second one, shows the page when the given filter returns no tag:

The last one shows a single tag being filtered:

Thanks for the PR! Would you be able to include a screenshot of the change?

For sure, @techknowlogick . Here they go :)
The first screenshot shows the tag page without any filter being applied:

The second one, shows the page when the given filter returns no tag:

The last one shows a single tag being filtered:

It's better to have a search results count following the text of the Table head. The number is different from the one on the Tab which means the total tags amount.

It's better to have a search results count following the text of the Table head. The number is different from the one on the Tab which means the total tags amount.

I've submitted some changes to show the number of tags on the header of the tags table. I've attached some evidences to show how it looks now.


Sample with js input and json output

Sample showing usage of the ilib-loctool-javascript to extract string using a wrapper regular expression, and using ilib-loctool-json for output. Uses latest changes to the json and javascript plugins

I have a question. I checked the output data is generated ko/KR/strings.json and de/DE/string.json
If the target locales are en-GB, and en-US, Does loctool place en/strings.json if they have common translation data?
or generate all data and place each en/GB/strings.json, en/US/strings.json?

Currently, the plugin does not implement localeMap feature yet, so it will put the file in the full path en/GB/strings.json and en/US/strings.json. I was trying to focus my changes on only the features we needed for our Box project. We can add localeMaps later. We have lots of examples from the other plugins!


Script to merge objects from 3 qc steps

We will replace the seurat_merge.R script with another that

merges seurat objects from 3 qc steps

This is assigned to @AntoniaChroni.

This is being addressed in the PR https://github.com/kids-first/kf-dev-single-cell-rna/pull/33
After a discussion with @migbro, he recommended converting the notebook into an R script for Docker convenience. @dmiller15 will work on this.

The script is available in this PR: https://github.com/kids-first/kf-dev-single-cell-rna/pull/38
Specifically: https://github.com/kids-first/kf-dev-single-cell-rna/blob/ffe50770c88522968b1cddfbe3008f6635ce2063/scripts/seurat_filter.R


Improve error logging when a container fails to start

Related issue https://github.com/testcontainers/testcontainers-node/issues/682, you can see from the error log that the wait strategy is failing because the image is distroless.
It'd be nice to surface this without having to enable logging.

That would be very helpful. I have a compose file that starts 10 containers. Sometimes my pipeline fails with:
[test](https://github.com/actions/runs/11874097483/job/33089644145#step:11:6220)
Error: Health check failed: unhealthy

   at testcontainers/compose.ts:11

   9 |   const composeFilePath = resolve(rootDir, 'docker/env-test');
  10 |
> 11 |   const environment = await new DockerComposeEnvironment(composeFilePath, 'docker-compose.yml')
     |                       ^
  12 |     .withStartupTimeout(120000)
  13 |     .withWaitStrategy('web-1', Wait.forHealthCheck())
  14 |     .withWaitStrategy(

    at HealthCheckWaitStrategy.waitUntilReady (/home/runner/work/apps/web/node_modules/.pnpm/testcontainers@10.14.0/node_modules/testcontainers/src/wait-strategies/health-check-wait-strategy.ts:26:13)
    at waitForContainer (/home/runner/work/apps/web/node_modules/.pnpm/testcontainers@10.14.0/node_modules/testcontainers/src/wait-strategies/wait-for-container.ts:17:5)
    at /home/runner/work/apps/web/node_modules/.pnpm/testcontainers@10.14.0/node_modules/testcontainers/src/docker-compose-environment/docker-compose-environment.ts:155:13
    at DockerComposeEnvironment.up (/home/runner/work/apps/web/node_modules/.pnpm/testcontainers@10.14.0/node_modules/testcontainers/src/docker-compose-environment/docker-compose-environment.ts:133:7)
    at runCompose (/home/runner/work/apps/web/e2e/testcontainers/compose.ts:11:23)
    at globalSetup (/home/runner/work/apps/web/e2e/globalSetup.ts:19:16)

There is absolutely no information which container failed.


Fix nil pointer dereference

As the pagination options are a pointer they can be nil, this has to
accounted for.
Also simplified the content-type header setting to avoid code
duplication.

As a side note I have permission to merge this without any reviewing, I think I probably shouldn't

As the pagination options are a pointer they can be nil, this has to
accounted for.

Also simplified the content-type header setting to avoid code
duplication.

As a side note I have permission to merge this without any reviewing, I think I probably shouldn't

Hey @cg14823, nice find!
I gave you write permissions to the repository a couple of days ago! I've added a CODEOWNERS file with myself and you in it and I've added restrictions to the main branch so that at least 1 approval is required from a code owner for a PR to be merged 😃


[AAE-15797] add action for processing coverage report using jacoco-report plugin

I had thought of creating a more generic action, for example a "process coverage report" action, not one specific to the jacoco report plugin. In the future we will also use sonarcloud and could add it within this action without any other changes. What do you think?

changed the name of action to process-coverage-report

please document it in the README

updated the documentation

just update the PR title according to the new name and it's good for me

Updated.


RTTA eligibility changes

Trello card
RTTA funnel eligibility chnages
Context
The RTTA funnel requires additional questions to determine whether candidates are eligible for a Return To Teaching Adviser
Changes proposed in this pull request
Implement additional questions
Guidance to review
Test new flow to verify it conforms to the specification

Looks good to me - demoed to policy and advisers team


[BUG] Unused imports not removed

Describe the bug A clear and concise description of what the bug is.
Pycln doesn't remove two unused imports
To Reproduce Steps to reproduce the behavior:

Take this code snippet:

import nanoid
from django.core.validators import MaxValueValidator, MinValueValidator
from django.db.models import (
SET_NULL,
CharField,
DurationField,
FileField,
ForeignKey,
TimeField,
UUIDField,
)

In the above, MaxValueValidator, MinValueValidator, and TimeField are all unused.

2. Run this Pycln command:
```bash
$ pycln that_file.py

Error traceback or unexpected output (if present):

Looks good! ✨ 🍰 ✨
1 file left unchanged.

**Expected behavior**:

I expect the unused imports to be removed.

**Environment (please complete the following informations):**

- Python Version: 3.9.10
- Pycln Version: 1.1.0
- OS Type: macOS

Hi @denizdogan , did you try to run Pycln with the -a/--all flag?
Please let me know if that helps so I can close this issue.

Hi again @denizdogan, I did the experiment myself and everything went as expected with the -a/--all flag:
$ pycln x.py --all
  x.py:2:0 'from django.core.validators import MaxValueValidator' has removed! 🔮
  x.py:2:0 'from django.core.validators import MinValueValidator' has removed! 🔮
  x.py:3:0 'from django.db.models import TimeField' has removed! 🔮
  x.py 3 imports has removed! 🚀

All done! 💪 😎
3 imports has removed, 1 file has changed.

so now I'm gonna close this issue, if that didn't help you, plz feel free to reopen this issue again.
+ Thanks a lot for being around.


feat: add support for CommitStats

This draft adds support for returning CommitStats for a transaction. CommitStats must specifically be requested from the backend to be returned. The current implementation adds access to CommitStats as follows:

The property SpannerConnection.ReturnCommitStats is added and specifies whether transactions that are created on this connection should return commit stats.
The property SpannerTransaction.ReturnCommitStats is added and specifies whether this specific transaction should return commit stats. The default value is taken from the connection, but can be changed for a specific transaction.
The property SpannerConnetion.LastCommitResponse is added and contains the response for the last commit that was executed by a transaction on this connection.

The reason for adding the ReturnCommitStats property to SpannerConnection is that we want to be able to support CommitStats for commands that are executed without a transaction (i.e. for EphemeralTransaction).
There are a couple of possible alternative solutions that could also be considered:

The ReturnCommitStats property could be removed from SpannerConnection and be added to SpannerCommand. Setting it to true for a SpannerCommand only makes sense as long as the SpannerCommand does not use a transaction, as the command will not automatically commit. Instead, it should in that case be set on the SpannerTransaction.
The LastCommitResponse property could be removed from SpannerConnection and added as a CommitResponse property to SpannerCommand and SpannerTransaction.

The advantage of the alternative solution(s) is that the properties are defined directly on the objects that actually execute the commit. The disadvantage is that there are two different ways of requesting and inspecting commit statistics, depending on whether you use an explicit transaction or not.
Having the ReturnCommitStats on SpannerConnection (both as the only solution, or in combination with a specific property on SpannerTransaction and/or SpannerCommand), is that we could also allow users to define a value for the property in the connection string. That would allow users to turn commit stats on/off without having to change the code.

@jskeet @amanda-tarafa
I would really appreciate your input on the considerations in the description of this PR before continuing with additional tests etc. WDYT?
(The current PR only includes some additional asserts to existing integration tests. I do intend to add separate tests for this feature, but I would like to first get an agreement on what would be the best approach to add this feature.)
@skuruppu Please feel free to also add any additional input you might have.

Will try to have a look later today.

I'll take a look later as well, thanks!

(The CI error is caused by the emulator, which does not yet support returning commit stats)

Haven't looked at the PR yet, but here are some initial thoughs based on the PR description.

we want to be able to support CommitStats for commands that are executed without a transaction (i.e. for EphemeralTransaction)

Is this a hard requirement? I think we could agree that inspecting (in code) commit stats is an advanced feature, so it doesn't seem unreasonable to me to require an explicit transaction to access that feature. If a user is not even setting up an explicit transaction it is probably because they are not interested in what happens with it. If we drop this requirement, the feature surface and its implementation becomes so much simpler and straightforward. But not only that, I'm also worried about how SpannerConnetion.LastCommitResponse would behave in a multithreaded environment where the connection is shared and several transactions may be open at any given time.
I would keep SpannerConnection.ReturnCommitStats as a default (and as pointed out can be included in the connection string) and SpannerTransaction.ReturnCommitStats as a means to override that default for specific transactions, but I would add ISpannerTransaction.CommitStats instead of any of the other alternatives to store the actual commit stats, notice that with this approach, the stats would also be available for EphemeralTransactions, only thing is that EphemeralTransactions are not inmediately exposed.
But going further, I would say that the main use of this feature is for diagnostics purposes? Hardly any production code will execute depending on whether the commit stats were this or that? So, the question is, do we really need to expose the commit stats via code? Or could we think of a way of making them easily added to logs and turned on and off from the connection string? We already have a rudimentary logging mechanism in place for diagnostic purposes, so, could we take advantage of that to expose these stats? And also, at the end of the day, if some user really really needs to access commit stats in code, they can always use the lower level library (custom retries are already exposed via the lower level library).

@amanda-tarafa
Thanks for the elaborate answer.

But not only that, I'm also worried about how SpannerConnetion.LastCommitResponse would behave in a multithreaded environment

Yes, I was worried about that as well. I tried to find a definite answer to whether a DbConnection implementations are normally thread safe or not, but with at best mixed results. If a SpannerConnection is (intended to be) shareable between multiple threads, the LastCommitResponse is a non-starter.

Is this [support for ephemeral transactions] a hard requirement?

@skuruppu That's in the end for you to say.
The design document does not specifically mention it, probably because most (all?) other client libraries do not implement ephemeral transactions in the same way as the .NET client does. There are a number of situations that are (very) similar where we do (intend to) support it:

JDBC driver: The JDBC driver supports autocommit and will support CommitStats in that mode as well. This will be done by implementing a LastCommitResponse style solution. JDBC connections are by design not thread safe and can have at most one transaction active at any time, so we don't have to worry about shared connections or multiple simultaneous transactions.
Java, Node, and Go client libraries: All these libraries support some sort of write(Enumerable<Mutation>) method. These methods write a list of mutations in what is basically an ephemeral transaction and can return CommitStats.

But going further, I would say that the main use of this feature is for diagnostics purposes?

That is my understanding as well. Users sometimes run into the limit of max 20,000 mutations in one transaction, and as that mutation count is quite difficult to calculate when you have multiple secondary indices etc., this feature will allow users to get a better idea on what the actual mutation count is for specific transactions / statements. Being able to turn this on/off using configuration is not a hard requirement, but could be nice to have to debug an application that occasionally runs into this limit.

@amanda-tarafa

I definetely thinkg they belong in the transaction, not the command either, commands can be reused.

I would say that the fact that a command can be reused is not necessarily a blocker for letting a user inspect commit stats and other metadata of the ephemeral transaction that was used for the command, but it would be if a command is potentially reused by multiple threads. I don't think that is the intended usage of a DbCommand and/or SpannerCommand.
The user would of course have to inspect the property after executing the command, as it would be lost / overwritten by the results of the next execution if the command is reused.

@amanda-tarafa

I definetely thinkg they belong in the transaction, not the command either, commands can be reused.

I would say that the fact that a command can be reused is not necessarily a blocker for letting a user inspect commit stats and other metadata of the ephemeral transaction that was used for the command, but it would be if a command is potentially reused by multiple threads. I don't think that is the intended usage of a DbCommand and/or SpannerCommand.
The user would of course have to inspect the property after executing the command, as it would be lost / overwritten by the results of the next execution if the command is reused.

Oh no, the command is not intended to be used concurrently by several threads, it wouldn't actually work as expected, as in it is not thread safe. But it can be reused, and I think it'll be confusing to have the commit stats there, in context B you might have access to some commit stats from context A that you don't know anything about, etc. Also, the fact that the commit stats would be populated in the command at different points in time (after the command executed if under ephemeral transactions or after the transaction commited if under explicit transaction) adds yet another level of confusion.
In my view, from a design perspective, the commit stats belong with the transaction. But I still would prefer not even exposing them there, but having a mechanism to log them or not.

Also, the fact that the commit stats would be populated in the command at different points in time (after the command executed if under ephemeral transactions or after the transaction commited if under explicit transaction) adds yet another level of confusion.

Sorry, I wasn't completely clear on that:

I would only populate the CommitStats for a command if it was executed using an ephemeral transaction.
CommitStats for a transaction should definitely go in the SpannerTransaction class (considering the fact that the LastCommitResponse solution is a non-starter).

Given @skuruppu's comments, I wonder whether it would make sense to have both ReturnCommitStats and LastCommitResponse (or LastCommitStat) just on SpannerCommand, and the setting automatically propagated to SpannerTransaction.
While a SpannerCommand can be reused, that would typically be more obvious in code (it's unlikely that a user will have an instance variable of type SpannerCommand for example, whereas they may do so for SpannerConnection even if I'd prefer they didn't).
Does the SpannerCommand/SpannerTransaction interaction work in a way that would allow the public API change only to affect SpannerCommand? Or are transactions used without the user ever being aware of a SpannerCommand? (It's been a while since I've looked at all of this in detail, and a surface-level browse would probably miss things.)

Given @skuruppu's comments, I wonder whether it would make sense to have both ReturnCommitStats and LastCommitResponse (or LastCommitStat) just on SpannerCommand, and the setting automatically propagated to SpannerTransaction.
While a SpannerCommand can be reused, that would typically be more obvious in code (it's unlikely that a user will have an instance variable of type SpannerCommand for example, whereas they may do so for SpannerConnection even if I'd prefer they didn't).
Does the SpannerCommand/SpannerTransaction interaction work in a way that would allow the public API change only to affect SpannerCommand? Or are transactions used without the user ever being aware of a SpannerCommand? (It's been a while since I've looked at all of this in detail, and a surface-level browse would probably miss things.)

I think it would be doable from a technical perspective, but I'm not sure it would be a very user-friendly solution. Providing access to commit stats on SpannerCommand makes sense for commands that are executed without a transaction, as it basically means that the command itself is a transaction. For actual transactions, the user will execute multiple SpannerCommands within the transaction and then call commit on the transaction. The user would then have to inspect the last command that was executed in the transaction to find the commit stats. (The commit call itself is not a SpannerCommand).

For actual transactions, the user will execute multiple SpannerCommands within the transaction and then call commit on the transaction.

Ah, yes, of course. That makes sense. Thanks.
So to summarise:

We need it on SpannerCommand because some transactions are implicit

We could decide that in order to get the stats, you have to be explicit about the transaction. That would simplify things, yes?

We need it on SpannerTransaction because the stats are effectively transaction-wide

Is that a reasonable summary, or have I still missed things? I do think it would be best not to put it on SpannerConnection until we have a clear and reasonable use case for it. Basically I'm in favour of deferring API surface changes until they're necessary, so long as we don't do anything to prevent them being added later on. I'd like to take the same approach to SpannerCommand, although I can see that's a slightly harder sell.

What about Jon's proposal yesterday of a sink or similar. I still like this better because it does away with the commit stats being a property of the command (and of transaction).

Add an Func<CommitResponse, Task> OnCommitAsync to both the command and the transaction, that gets called when either is commited. This means that the CommitResponse is not part of the state of the command.
As an alternative, which I like better, it could be Func<IList, CommitResponse, Task> OnCommitAsync added to the connection itself. CommandInfo is a new type that contains the description of the command, as in, what type of command, the SQL that got executed and the parameters. With CommandInfo we avoid sending the command itself which could potentially have been changed when it's process by the commit handler.
(And in both cases it would be a Func returning a task so it can be async).

@jskeet Your summary is spot on.
Not supporting the feature for ephemeral transactions would certainly simplify it, but I don't think it is a reasonable thing to do. If a user wants to debug a query that is using an ephemeral transaction in an existing application, it is quite a big ask to require the user to change the existing application code to (temporarily) use explicit transactions at that point.
The event model sound promising, and my preference would also be to implement it as @amanda-tarafa suggested in the second bullet, i.e. as an event on the SpannerConnection. That would mean that there is only one place where CommitResponse can be accessed, instead of on both SpannerCommand and SpannerTransaction.

We could decide that in order to get the stats, you have to be explicit about the transaction. That would simplify things, yes?

It depends. The idea would be for the user to quickly take some production code, add a parameter to set ReturnCommitStats=true and be able to get a result. But if it's not too tricky to start/end a transaction then I suppose that's fine. We can show how to do it in a code sample.

We could decide that in order to get the stats, you have to be explicit about the transaction. That would simplify things, yes?

It depends. The idea would be for the user to quickly take some production code, add a parameter to set ReturnCommitStats=true and be able to get a result. But if it's not too tricky to start/end a transaction then I suppose that's fine. We can show how to do it in a code sample.

Risking sounding repetitive, @skuruppu the description of the use case you just gave it's spot on "diagnostics". This seems more and more to be something the user could activate with a flag in production and get some logs to inspect.
Adding the information in code as we have been discussing requieres either:

The user debugging production code almost certainly in a different environment than production, which has zero guatantees of reproducing the issue they want to diagnose (or they have to go through hoops to reproduce the production environment or debug in it).
Or the user writing code to capture the commit stats in code and push them to a log so they can have the production information available. But we can do this for them, and make the logs available with a flag switch I think.

Would this be something that you'd considered? What to me feels off about this feature on the higher level library is that we have a lot of code to make things transparent for users, hide transactions when they don't explicitly use them, hide transations that retry on failures, etc. And then we want to expose very low level information about those same things that we are hiding. That's why it is so hard design wise to come up with a clean surface, I think.

@amanda-tarafa I actually added a comment on our spec doc to the feature team to check whether they're ok with this being a logging option. I'll report back with what they say.
I think I agree in terms of debugability that logging this result would be perfectly reasonable. There is a risk though of the behavior being different across client libraries. I wanted to check with the team on whether that would be acceptable.

Just to close out the discussion, yes, we think it's reasonable for the CommitResponse to be logged in the ADO.NET layer. But the values should only be logged if the user sets the ReturnCommitStats property (we might want to call it LogCommitStats) and either of the values in the commit stats is not null.
Hope that makes sense.

Replaced by #5506


Add possibility to select the fixers we want to run

This tool does not allow disabling some fixers. This makes it harder to use. For instance, FormGetnameToGetblockprefixFixer must run only after you replace all usages of your type names by class names when adding fields. As you tool is only able to upgrade core form types, it means it leaves the project in a broken state by default.

Yes, I know. The idea was to make this work before v1.0, unfortunately I did not have enough time to dedicate to the project.
For the time being, I'm just trying to review and merge PRs.
Thanks!

Well, the infrastructure is based on php-cs-fixer. And this tool has the --fixers option in its command-line. The work would be to port this feature too

Yes.


Save only the most recent build cache for each element

See original issue on GitLab
In GitLab by [Gitlab user @TheRealMichaelCatanzaro] on May 21, 2018, 23:19
I have six different build directories for WebKitGTK+ under ~/.cache/buildstream/build. That doesn't make sense: why does BuildStream need more than one?
The total size is absurd, I gave up on nautilus's counting when it surpassed 25 GB. It would be desirable to limit the size of the entire ~/.cache/buildstream to way less than that.

In GitLab by [Gitlab user @tristanvb] on May 23, 2018, 16:27
Two things:

the size of the build directly contains mostly hardlinks to the staged dependency artifacts, so a du -hs of the build directory alone is misleading (its taking much less space than you might think)
this should instead be fixed by issue #76, once we get both the caching of failed builds, along with caching of the build tree itself (issue #21), we will no longer ever leave the build directories behind, since they will always be constructable from a cached failed build artifact. Disk usage will only need to be managed by the artifact quota which [Gitlab user @tlater] is working on now (issue #135).

In GitLab by [Gitlab user @tristanvb] on May 23, 2018, 16:27
closed

In GitLab by [Gitlab user @toscalix] on May 23, 2018, 16:47
marked this issue as related to #76

In GitLab by [Gitlab user @toscalix] on May 23, 2018, 16:47
marked this issue as related to #21

In GitLab by [Gitlab user @toscalix] on May 23, 2018, 16:47
marked this issue as related to #135


How I set the View height acoring to the video height.

I am making an app in which I want to set the top view height according to the video height. If the video nature is horizontal then set its height according to the horizontal height and if its vertical then set height vertically as youtube built in app work.
Belwo is my react native youtube code. it work good if video is horizontal but if video is portrait than video is stretched. I want to set the height according to the video height.
<YouTube
apiKey="my_api_key"
//videoId={this.props.videoId} // The YouTube video ID
videoId={'rWvnZG2z7AU'}
play={false} // control playback of video with true/false
fullscreen={false} // control whether the video should play in fullscreen or inline
loop={this.props.loop} // control whether the video should loop when ended
onChangeState={e => console.warn(e.state)}
onChangeQuality={e => this.setState({quality: e.quality})}
onError={e => this.setState({error: e.error})}
showFullscreenButton={true}
resumePlayAndroid={false} //because app crashed after come back on the same screen
controls={2}
showFullscreenButton={true}
style={{
flex: 1,
width:'100%',
alignSelf:'baseline',
aspectRatio:1
}}
/>
Sorry for my English.

Any update on this. I am also facing the same issue

@ UsmanAhsanPs19 have you tried adding aspectRatio of 16:9 to the video. I think it works!! You can set it like,
aspectRatio: 16/9


remove support for asymmetric ppi in imagesto___ filters and use ppi=…

…XXX as integer as it is in cups
Solves #347

Thank you very much, it is merged now.


Add more gtm events to Symphony

What is included in this request?

[ ] Bug Fix
[ ] New feature
[X] Changes to an existing feature
[ ] New extension
[ ] Changes to an existing extension

Describe your changes
(If this is a new extension or feature, please describe in detail what the extension or feature does)
Added additional events to Symphony onboarding/rule builder
Are you adding any dependencies or calling external APIs?

[X] No
[ ] Yes (Please list the dependencies or APIs below and how they're being used)

:tada: This PR is included in version 1.24.0-dev.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.24.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Updating User Stories and Requirements on the Wiki

Edited User stories for US01.01.01 to US02.02.01


TypeError: CouchAuth is not a constructor

Hi, first of all thanks for this effort.
I followed the installation and it was installed successfully with no issues.
Following the simple minimalist configuration that will get me up and running right away resulted in an error.
I am using nodejs 16
var couchAuth = new CouchAuth(config);
^
TypeError: CouchAuth is not a constructor
at Object. (/home/mar/myapp/app.js:44:17)
at Module._compile (node:internal/modules/cjs/loader:1105:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
at Module.load (node:internal/modules/cjs/loader:981:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
at node:internal/main/run_main_module:17:47

I fixed the example in the README. I was a bit premature with updating the names - the exported class is still called SuperLogin.

Thank you!!


Update travis.yml for disable wallet testing.

I don't think this will have any effect at all, see https://github.com/dashpay/dash/blob/master/depends/README.md

If some packages are not built, for example make NO_WALLET=1, the appropriate options will be passed to Dash Core's configure. In this case, --disable-wallet.

Please check the effect from the failed travis build log

Hmmm... Interesting... but still not convinced :) fails due to a bug I think (should be fixed by https://github.com/dashpay/dash/pull/1991)

Yes, I found the bug then I guess using travis to show you the bug should be better than try fixing the bug. Then, later new pr would not miss this disable wallet failed case again. :)

Anyway, agree with you that this should be fixed somewhere else so the statement in that README.md will be true. Closing this :)


Plan for v0.1.0

Below is the sketch of todo-s for beta (until v0.1.0 the gem should be treated as alpha):

[ ] implement group customers (presumable on top of poseidon-cluster)
[ ] implement migrator with ruby-style operations

[ ] create a topic (described by ROM::Kafka::Dataset)
[ ] add partitions to a topic
[ ] configure a topic
[ ] delete topic

Closing due to inactivity, also poseidon is deprecated/unmaintained


Can not call multiple functions consecutively through APIs in "wasm_export.h"

Problem
Hi, I want to use the Function APIs (in wasm_export.h) to continuously call multiple Functions in one module instance in a program.

The c++ code is as below:
    wasm_function_inst_t func1 = wasm_runtime_lookup_function(module_inst, "get_params_buffer_size", "()i");
    if (wasm_runtime_call_wasm_a(exec_env, func1, 1, params_buffer_size, 0, nullptr)) {
        printf("Successful Execution func1!\n");
    } else {
        printf("Execute function func1 failed. Error: %s\n", wasm_runtime_get_exception(module_inst));
    }

    wasm_function_inst_t func2 = wasm_runtime_lookup_function(module_inst, "get_results_buffer_size", "()i");
    if (wasm_runtime_call_wasm_a(exec_env, func2, 1, results_buffer_size, 0, nullptr)) {
        printf("Successful Execution func2!\n");
    } else {
        printf("Execute function func2 failed. Error: %s\n", wasm_runtime_get_exception(module_inst));
    }

    wasm_function_inst_t func3 = wasm_runtime_lookup_function(module_inst, "get_params_buffer_addr", "()i");
    if (wasm_runtime_call_wasm_a(exec_env, func3, 1, params_buffer, 0, nullptr)) {
        printf("Successful Execution func3!\n");
    } else {
        printf("Execute function func3 failed. Error: %s\n", wasm_runtime_get_exception(module_inst));
    }

    wasm_function_inst_t func4 = wasm_runtime_lookup_function(module_inst, "get_results_buffer_addr", "()i");
    if (wasm_runtime_call_wasm_a(exec_env, func4, 1, results_buffer, 0, nullptr)) {
        printf("Successful Execution func4!\n");
    } else {
        printf("Execute function func4 failed. Error: %s\n", wasm_runtime_get_exception(module_inst));
    }

But I can always only successfully call the first function. The result of running the program is:
Successful Execution func1!
Execute function func2 failed. Error: Exception: uninitialized element
Execute function func3 failed. Error: Exception: uninitialized element
Execute function func4 failed. Error: Exception: uninitialized element
params buffer size: 16384
params buffer addr: 0
results buffer size: 0
results buffer addr: 0

Environment
The version I used is WAMR-1.1.0. I have set:
set (WAMR_BUILD_INTERP 1)
set (WAMR_BUILD_FAST_INTERP 1)
set (WAMR_BUILD_AOT 1)
set (WAMR_BUILD_LIBC_WASI 1)
set (WAMR_BUILD_BULK_MEMORY 1)

And I use wasi-sdk 16.0 to compile my module.
$ ../../wasi-sdk-16.0/bin/clang++ --sysroot ../../wasi-sdk-16.0/share/wasi-sysroot hello.cpp \
-nostartfiles -fvisibility=default -Wl,--no-entry \
-Wl,--export=get_params_buffer_size \
-Wl,--export=get_results_buffer_size \
-Wl,--export=get_params_buffer_addr \
-Wl,--export=get_results_buffer_addr \
-o hello.wasm

Question
can I use it like this? Or do I need to open some configuration when using it like this？

I seem to have found the problem. When I include iostream in the module source code, there will be a problem, but if I replace it with stdio.h, it will run smoothly. The problem lies in the WASI-SDK?

Could you re-build the wasm module with -mexec-model=reactor option?
Seems it's related to the command/reactor mode, see https://github.com/WebAssembly/wasi-libc/pull/264

Could you re-build the wasm module with -mexec-model=reactor option?
Seems it's related to the command/reactor mode, see WebAssembly/wasi-libc#264

It works for me. Thanks!


Fix /notification/devices error mapping

Closes #793

Return 500 if any server error is found while posting to /v1/notifications/devices/
If no server errors are found and client errors are present 4XX, return 400

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

25 of 28 (89.29%)  changed or added relevant lines in 2 files are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 88.497%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/routes/notifications/handlers.rs
24
27
88.89%

Files with Coverage Reduction
New Missed Lines
%

src/utils/errors.rs
8
31.2%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
11379

Relevant Lines:
12858

💛  - Coveralls

@fmrsabino It's ok for me to go, but I'm missing a test for this

@fmrsabino It's ok for me to go, but I'm missing a test for this, checking only the status code does not feel enough

It's not testing just the status code. It's testing the error body. The test had to be adjusted.


DEMO: Update onyo set with filtering

Currently, the demo does:
onyo set -y USB_A=2 */laptop_*.* */*/laptop_*.*
This is done to demonstrate how to update a value for all laptops in the inventory.
Later (after onyo get exists) the laptops should either be selected with a flag of onyo set, or with the usage of a subshell which calls onyo get.

Depends on #113


Install npm dependencies in "Check npm Dependencies" template

The "Check npm Dependencies" template is used to check for compatibility of dependencies with the licensing of projects that use npm for dependency management.
The Licensed tool is used for this check. This tool requires the dependencies to have been installed in advance.
Previously, the template's task did not install the dependencies. This caused the check to fail whenever the dependencies were not already installed by chance.
The dependency check tasks are intended to be applicable to projects of any type since the Licensed tool supports multiple project types (referred to as "sources"). Each project type might have different requirements for advance preparation of the dependencies. A call to a general:install-deps task was added to the dependency check tasks for this purpose. A different variant of that task will be provided for each specific project type. In project types where no preparation is needed, an empty general:install-deps task must be added in order to allow the task call to succeed.

I did set up the general:cache-dep-licenses task to install dependencies when I wrote the original version for the arduino/setup-task repository (https://github.com/arduino/setup-task/pull/497), but somehow left that part out when I added the template here in the assets repo (https://github.com/arduino/tooling-project-assets/pull/259).

I originally named the dependencies preparation task general:install-deps. However, the actual preparation might not involve installing dependencies in some project types (e.g., no preparation at all is needed in Go module-based projects). So I decided that task name might cause confusion and changed it to the more generally applicable general:prepare-deps.

Example of the previous version of the template causing a spurious failed workflow run in an npm-based project due to the dependencies not being installed:
https://github.com/per1234/arduino-lint-action/actions/runs/3755689041/jobs/6380983198#step:6:7
Caching dependency records for arduino-lint-action
  npm
    Error @actions/core (^1.10.0)
task: Failed to run task "general:cache-dep-licenses": exit status 1
    Error @actions/http-client ()
    Error @actions/tool-cache ()
    Error semver ()

  * Errors:
    * arduino-lint-action.npm.@actions/core
      - missing<EMAIL_ADDRESS>required by arduino-lint-action@

    * arduino-lint-action.npm.@actions/http-client
      - missing<EMAIL_ADDRESS>required by arduino-lint-action@

    * arduino-lint-action.npm.@actions/tool-cache
      - missing<EMAIL_ADDRESS>required by arduino-lint-action@

    * arduino-lint-action.npm.semver
      - missing: semver@^[7](https://github.com/per1234/arduino-lint-action/actions/runs/3755689041/jobs/6380983198#step:6:8).3.[8](https://github.com/per1234/arduino-lint-action/actions/runs/3755689041/jobs/6380983198#step:6:9), required by arduino-lint-action@

Error: Process completed with exit code 1.

The same process completing successfully once the dependency installation operation was added to the task:
https://github.com/per1234/arduino-lint-action/actions/runs/3755779962/jobs/6381158769#step:6:20
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.

added 462 packages, and audited 463 packages in [7](https://github.com/per1234/arduino-lint-action/actions/runs/3755779962/jobs/6381158769#step:6:8)s

31 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
Caching dependency records for arduino-lint-action
  npm
    Caching @actions/core (1.10.0)
    Caching @actions/exec (1.1.0)
    Caching @actions/http-client (2.0.1)
    Caching @actions/io (1.1.2)
    Caching @actions/tool-cache (2.0.1)
    Caching lru-cache (6.0.0)
    Caching semver-6.3.0 (6.3.0)
    Caching semver-7.3.[8](https://github.com/per1234/arduino-lint-action/actions/runs/3755779962/jobs/6381158769#step:6:9) (7.3.8)
    Caching tunnel (0.0.6)
    Caching uuid-3.4.0 (3.4.0)
    Caching uuid-8.3.2 (8.3.2)
    Caching yallist (4.0.0)
  * [12](https://github.com/per1234/arduino-lint-action/actions/runs/3755779962/jobs/6381158769#step:6:13) npm dependencies

The previous template version was installed in the arduino/setup-protoc repository (https://github.com/arduino/setup-protoc/pull/35). Confusingly, the workflow runs in that repository are passing despite the use of the flawed template. The explanation is that the current action packaging approach involves checking the node_modules folder into the repository. Those dependencies are generally only updated on release, so even though the workflow runs are passing they don't provide an accurate indication of the project's current dependency license compliance status.

The failed link check workflow job run (https://github.com/arduino/tooling-project-assets/actions/runs/3756232059/jobs/6382076872) is unrelated to the changes proposed here. It is likely caused by a transient outage. So it shouldn't be considered a blocker for this PR.
I'll keep an eye on the problem and if it doesn't eventually resolve itself I'll provide some fix for those links via a separate PR.


chore: Adjust metrics units

Description
Fixes: #1389

Note for reviewer: The corresponding PR is opened in the control-plane charts repository.

Please make sure to also run the corresponding make targets in the interal repo, otherwise the charts will not be rendered and the Pipelines will fails


2d_best model using FPN3D

Hi,
In your yaml files in 2d_best, the conv body of model is "FPN3D.add_fpn_ResNet101_conv5_body". Is there something wrong with it?
Thanks!

And the model_final.pkl is also the 3D model, which uses 7x7 kernel in the first layer.

It is just implemented using a 3D conv operation. The time dimension of that kernel is 1 (VIDEO.TIME_KERNEL_DIM = 1 in the config), which effectively makes the kernel 2D.

Excuse me，I think the  final feature map output of the base 3D network for a THW input is TH/16W/16 after 4 residual block. What's wrong with me?


Check if Neko Project II is already running

Is it appropriate to add a feature of checking if Neko Project II is already running, so as to evade potential corruptions on disk images and floppy images?

I think few of methods.

Selecting config file by command line.
Lock reading to opened image files.

There may be some players enjoying NP2 by multiple driving.
Since quality can not be perfect, we recommend to backup images on user.
If it can be implemented, I will add it.
Thanks.

Also, is it appropriate to identify NP2 sessions by configuration files, so that only one instance of NP2 is allowed for each configuration file?

It is natural that instances control files,
I think it is unnatural for a file to identify an instance.
An instance has a shorter lifecycle than a file.
(Stoic integrity is necessary?)


[TuyaWebPlatform] Cannot acquire token, waiting 185 seconds.

Describe the bug
When Starting tuya web platform get error   [TuyaWebPlatform] Cannot acquire token, waiting 185 seconds.
After 185 seconds get error [TuyaWebPlatform] Authentication error: Get accesstoken failed. Username or password error!
I have checked that username and password are correct
Steps To Reproduce
I dont know how to reproduce I have deleted the plugin and reinstalled, even created a new tuya account
Plugin Version
1.1.5
Homebridge Config
{
"platform": "TuyaWebPlatform",
"name": "TuyaWebPlatform",
"options": {
"username"<EMAIL_ADDRESS>"password": "mypasswordgoeshere",
"countryCode": "1",
"platform": "tuya"
}
}
Plugin Log
@milo526_homebridge-tuya-web.log.txt
Thanks in advance for any help

Having the same problem as well. Tried uninstalling the plugin and adding it back, but now I it won’t even add it back to HomeKit when I scan the QR code for the child bridge.

Have you managed to fix the error?

Same error for me sadly, previously has been working fine for years.

Same issue here


Windows Explorer issue

Hi Paul,
Thank you for the brilliant work.
Working on Windows 10 Pro. Craftsman 0.17.
I am facing the same problem I mentioned last time, it was with the craftsman's file AddUserFeatureOverrideModifier.cs where you are deleteing AddUser.cs  file and replacing it with AddUser.cstemp.
File.Move(tempPath, classPath.FullClassPath);
The program will raise an exception
"The process cannot access the file because it is being used by another process."
The problem was that the file AddUser.cstemp is still used by the Windows Explorer (Process Explorer shows that) when
you are renaming it by
File.Move(tempPath, classPath.FullClassPath);
To solve the problem I have had to close the file first by calling
// delete the old file and set the name of the new one to the original name
File.Delete(classPath.FullClassPath);
output.Close();
File.Move(tempPath, classPath.FullClassPath);
Could you kindly investigate the problem.
Best regards,
Amalsharief

hey, thanks for reporting this with the details and keeping me honest! i've still never been able to repro this myself, but i see a likely culprit in some lingering tech debt i missed. will get a pre-release patch up soon for you to try.

@amalsharief i just published 17.1 which I'm hoping fixes things. going to repoen this to track it but let me know one way or another if you don't mind (i still can't repro myself)!

Craftsman 0.17 result
No problem with the same configuration using CentOS 7


Keeps crashing on windows go version 1.23.0

Running in watch mode
Starting processes...
Generating CSS...
Starting server...
test/__htmgo
__htmgo\pages-generated.go:16:37: cannot use cc (variable of type *h.RequestContext) as h.Ren value in argument to pages.RootPage: *h.RequestContext does not implement h.Ren (missing method Render)

ok thanks for the good work

I have it tested now its working on windows ty

@JohnKinyanjui just fyi I noticed a few more issues on windows as im testing it now and I just pushed fixes. You'll need to run the same commands above to get new cli version
Seems there was an issue with killing processes for htmgo watch

Did it, thanks for the update


Cant get temperature from new broadlink

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
**Home Assistant release (hass --version):**0.60.0
**Python release (python3 --version):**3.5.3
**Component/platform:**broadlink
Description of problem:
temperature always show 0.0. i have bought a new broadlink device, model says "rm pro+"
Expected:
to get temperature
Problem-relevant configuration.yaml entries and steps to reproduce:
- platform: broadlink
  update_interval: 60
  host: <IP_ADDRESS>
  mac: '34:EA:34:42:E6:91'
  name: Home
  monitored_conditions:
    - temperature

Traceback (if applicable):

Additional info:

Enable log for the Broadlink sensor, and check the log

nothing in there... its not failing, just getting a result of 0.0

You should see something from the Broadlink component in the log if you enable debug logging

added   homeassistant.components.sensor.home_temperature: debug
and   homeassistant.components.broadlink: debug
still nothing

Try
homeassistant.components. sensor.broadlink: debug

same.....

Then your Broadlink device reports 0, and there is probably something wrong with it.
This is unrelated to Home-assistant

i noticed that the difference from other devices, is that it says "model: RM PRO+" on the sticker. other devices just write "RM PRO"

This is the correct logging statement but there is not much configured to log there.
homeassistant.components. sensor.broadlink: debug

If you aren't getting errors in the log after configing that, it is connecting to the device. Unfortunately since I don't own this device I can't troubleshoot it for you.

Talked to broadlink.... they said that rm pro+ doesnt have temp senssor.... only rm pro.  closing the issue...


Update Loader.js

This PR changes

Nothing, it's a bug fix

Describe the changes below:

Changed Loader.loadImageTag behavior to exclude firefox from loading cached images (#2534)

I was unsure about updating the README and CHANGELOG files, should I create a new 2.6.4 section with to-be-annonced date and add my changelist there?

Yes, please do exactly that. I'll merge this PR now, but you can submit the readme / log updates in another PR.


⚠ Bofrost.lu has degraded performance

In 97939c7, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1521 ms

Resolved: Bofrost.lu performance has improved in 2b9d87f after 6 minutes.


Sometimes the ads dont load, nor does the video.

As my title says, the ads sometimes are stuck on a blank screen with the time the ad is supposed to run for. The progress bar isn't loading, so i refresh the page, and then nothing loads. There are no other plugins enabled on my laptop (win 10) and the plugin, the exact same setup and version on my desktop (win11) works without any issues.

I should add, my browser is Opera GX and sometimes the adblocker works, other times it doesn't. It is very strange,

That happened to me sometimes, really weird, can you check your network/console to see if anything strange is being blocked?

Today I found the same problem.

Same thing happened to me today.

same here

same for me, i guess youtube changed something about their anti adblock script

yt definitely changed something today. not a single adblocker, including this one works for me now. The page simply doesn't load when i have all adblockers off. Somehow, if i open videos in a new tab, they still won't load even without any adblockers. strange.

it doesn't work now

Adding on to this. It doesn't totally not work like some of the people are claiming here, but it is hit or miss as of today. Any ads that appear to overlay over a video seem to pop up, though a page refresh removes them.
Midrolls seem to be handled just fine, still, from my personal testing. It's only ads at the start of the video, and it isn't consistent.

Same as everyone else says. Most of the time just a blank broken looking screen appears for a long time and then after a few minute video starts playing. Same thing keeps happening even if you stop using adblocker and this script.

I have the same issue.

I will be able to update my issue later today, as I will have access to my desktop setup again. Will reply with the update when I can.

Same issue in Brave

Updating my issue, It still works flawlessly on my desktop.

not working in chrome for me either

it may be vpn related

@Astral100 VPN related how? I'm not using any VPN.

Oh ok. I am using VPN, same as another user here, so I thought it might be related. But I guess not.

We should ask other people that have the issue and have reported here, but I think many users just surf the web normally :S


list_targets_by_rule method - EventBusName parameter is not included

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/events/client/list_targets_by_rule.html contains EventBusName parameter which is not included in the moto.
As a result, when the method is called for rules with the same names but created on different eventbuses, it returns all targets for both rules.
`
events_client = boto3.client("events")
    events_client.create_event_bus(Name="newEventBus")

    events_client.put_rule(Name="Test_rule_name1", EventBusName="default", ScheduleExpression="rate(5 minutes)")
    events_client.put_targets(
        Rule="Test_rule_name1",
        EventBusName="default",
        Targets=[
            {
                "Id": "Test1",
                "Arn": "arn:aws:events:eu-west-1:111111111111:event-bus/default",
                "DeadLetterConfig": {"Arn": "arn:aws:sqs:eu-central-1:111111111111:QueueName1"},
            }
        ],
    )
    event_pattern = {"source": ["aws.ec2"]}
    events_client.put_rule(
        Name="Test_rule_name1", EventBusName="newEventBus", EventPattern=json.dumps(event_pattern)
    )

    events_client.put_targets(
        Rule="Test_rule_name1",
        EventBusName="newEventBus",
        Targets=[
            {
                "Id": "Test2",
                "Arn": "arn:aws:events:eu-west-1:222222222222:event-bus/default",
                "DeadLetterConfig": {"Arn": "arn:aws:sqs:eu-central-1:222222222222:QueueName2"},
            },
            {
                "Id": "Test3",
                "Arn": "arn:aws:events:eu-west-1:333333333333:event-bus/default",
                "DeadLetterConfig": {"Arn": "arn:aws:sqs:eu-central-1:333333333333:QueueName3"},
            },
        ],
    )

    result = events_client.list_targets_by_rule(Rule="Test_rule_name1", EventBusName="newEventBus")
 `

result contains all 3 targets (include Test1) but should return only targets from Test_rule_name1 on newEventBus (Test2 & Test3)

Thanks for raising this @michuer, and welcome to Moto! Marking it as an enhancement.


Several questions about how to set Control module parameters

When I try to tuning Control module, there are several parameters that i can't understand well.
1.“enable_steer_mrac_control”:In which situation that we need to use mrac controller?
2.“max_abs_speed_when_stopped”in vehicle_param.txt file represent what? In other words,what's the meaning of this flag? And "standstill_acceleration", "brake_minimum_action" in control_conf.pb.txt。 What's the difference between them?
Thank you for reading my questions carefully.

Thanks for the questions for the Apollo Control module!
The answers to your questions:
(1) enable_steer_mrac_control can be enabled if there is non-neglected dynamics and time-latency in the by-wire steering mechanism in the autonomous vehicle (i.e., there are delay dynamics or time latency between the steering command and actual steering feedback from chassis). The MRAC control is used to offset the dynamic delay brought from the by-wire steering system.
(2) max_abs_speed_when_stopped: because the speed measurement/estimation accuracy from the vehicle chassis or IMU is limited, there may be very small speed even if the vehicle is at or almost at the stop mode. This flag is used to judge if the vehicle can be treated as stopped (speed < max_abs_speed_when_stopped, then stopped).
standstill_acceleration: when the car parks at the parking gear, there must be some small braking command (i.e., the negative acceleration command) to hold the car at "standstill" status and avoid the car to slip forward. This parameter is used to define the  "anti-slipping" acceleration command at the parking mode.
brake_minimum_action: used to define the minimum realizable brake action by by-wire mechanism. For most of vehicles it is set to 0 by default.
Please let us know if you get any further questions. Thanks.


ci: add script to check for helm chart updates

This script automatically fetch new helm chart dependency, unpacks them in the charts directory and creates a PR in Github
Testing Run:
src/update-helm-chart-deps.mjs

And you should see two PRs: one for ingress-nginx and the other for cert-manager.
This script still needs polishing.
The ultimate goal is to run in as a GitHub Action, e.g.:

patch updates every day
minor updates every week
major updates TBD

This currently might not work for ArgoCD and Tekton because the directories are argocd (instead of argo-cd) and tekton-pipelines (instead of tekton-pipeline). But maybe just renaming these directories will do the trick here. I could not verify that, because neither of them has minor updates as of now (actually Tekton none at all).

I have no general objections to be using this for an initial version. I can take this as a base for adding the Bitnami charts maybe (such as oauth2-proxy, rabbitmq, minio). I had already tried out a very basic bash script that did the updating of files, just not the metadata, but it could be added here quite well I think.

I enhanced that script so it reads configuration from env variables. There is a simple GH pipeline as a PoC.


LUA or FLA

What is your question?
So a sound effect linked to the LUA or FLA? I would like to add this sfx to this

add playSound('Release')

Where would I put it directly?

If you want the sound to play when you hit it put it under goodNoteHit.
if you want it to play when you miss  put it under opponentNoteHit.

Hit:
-- Function called when you hit a note (after note hit calculations)
-- id: The note member id, you can get whatever variable you want from this note, example: "getPropertyFromGroup('notes', id, 'strumTime')"
-- noteData: 0 = Left, 1 = Down, 2 = Up, 3 = Right
-- noteType: The note type string/tag
-- isSustainNote: If it's a hold note, can be either true or false
function goodNoteHit(id, noteData, noteType, isSustainNote)
	if noteType == 'Attack' then
		characterPlayAnim('dad', 'hit', true);
		characterPlayAnim('boyfriend', 'throw', true);
		cameraShake(none, 0.01, 0.1); -- none is nothing anyway
		playSound('Release')
	end
end

Miss:
-- Called after the note miss calculations
-- Player missed a note by letting it go offscreen
function noteMiss(id, noteData, noteType, isSustainNote)
	if noteType == 'Attack' then
		playSound('Release')
	end
end

It's still not working
function onCreate()
--Iterate over all notes
for i = 0, getProperty('unspawnNotes.length')-1 do
--Check if the note is an Attack Note
if getPropertyFromGroup('unspawnNotes', i, 'noteType') == 'Attack' then
setPropertyFromGroup('unspawnNotes', i, 'texture', 'ATTACK_assets'); --Change texture
setPropertyFromGroup('unspawnNotes', i, 'hitHealth', '0.5'); --Default value is: 0.023, health gained on hit
setPropertyFromGroup('unspawnNotes', i, 'missHealth', '0'); --Default value is: 0.0475, health lost on miss
setPropertyFromGroup('unspawnNotes', i, 'hitCausesMiss', false);
		if getPropertyFromGroup('unspawnNotes', i, 'mustPress') then --Doesn't let Dad/Opponent notes get ignored
			setPropertyFromGroup('unspawnNotes', i, 'ignoreNote', true); --Miss has no penalties
		end
	end
end
--debugPrint('Script started!')

end
-- Function called when you hit a note (after note hit calculations)
-- id: The note member id, you can get whatever variable you want from this note, example: "getPropertyFromGroup('notes', id, 'strumTime')"
-- noteData: 0 = Left, 1 = Down, 2 = Up, 3 = Right
-- noteType: The note type string/tag
-- isSustainNote: If it's a hold note, can be either true or false
function goodNoteHit(id, noteData, noteType, isSustainNote)
if noteType == 'Attack' then
characterPlayAnim('dad', 'hit', true);
characterPlayAnim('boyfriend', 'throw', true);
cameraShake(none, 0.01, 0.1); -- none is nothing anyway
end
end
-- Called after the note miss calculations
-- Player missed a note by letting it go offscreen
function noteMiss(id, noteData, noteType, isSustainNote)
if noteType == 'Attack' then
-- nothing
end

And I changed Release to Slash

Hmm...
one sec...

If this doesn't work i don't know what will...
function onCreate()
	--Iterate over all notes
	for i = 0, getProperty('unspawnNotes.length')-1 do
		--Check if the note is an Attack Note
		if getPropertyFromGroup('unspawnNotes', i, 'noteType') == 'Attack' then
			setPropertyFromGroup('unspawnNotes', i, 'texture', 'ATTACK_assets'); --Change texture
			setPropertyFromGroup('unspawnNotes', i, 'hitHealth', '0.5'); --Default value is: 0.023, health gained on hit
			setPropertyFromGroup('unspawnNotes', i, 'missHealth', '0'); --Default value is: 0.0475, health lost on miss
			setPropertyFromGroup('unspawnNotes', i, 'hitCausesMiss', false);

			if getPropertyFromGroup('unspawnNotes', i, 'mustPress') then --Doesn't let Dad/Opponent notes get ignored
				setPropertyFromGroup('unspawnNotes', i, 'ignoreNote', true); --Miss has no penalties
			end
		end
	end
	--debugPrint('Script started!')
end

-- Function called when you hit a note (after note hit calculations)
-- id: The note member id, you can get whatever variable you want from this note, example: "getPropertyFromGroup('notes', id, 'strumTime')"
-- noteData: 0 = Left, 1 = Down, 2 = Up, 3 = Right
-- noteType: The note type string/tag
-- isSustainNote: If it's a hold note, can be either true or false
function goodNoteHit(id, noteData, noteType, isSustainNote)
	if noteType == 'Attack' then
		characterPlayAnim('dad', 'hit', true);
		characterPlayAnim('boyfriend', 'throw', true);
		cameraShake(none, 0.01, 0.1); -- none is nothing anyway
		playSound("Slash", 1, "SlashingSound")-- Thanks tylerandari12!
	end
end

-- Called after the note miss calculations
-- Player missed a note by letting it go offscreen
function noteMiss(id, noteData, noteType, isSustainNote)
	if noteType == 'Attack' then
		-- nothing
	end
end

If this doesn't work i don't know what will...
function onCreate()
	--Iterate over all notes
	for i = 0, getProperty('unspawnNotes.length')-1 do
		--Check if the note is an Attack Note
		if getPropertyFromGroup('unspawnNotes', i, 'noteType') == 'Attack' then
			setPropertyFromGroup('unspawnNotes', i, 'texture', 'ATTACK_assets'); --Change texture
			setPropertyFromGroup('unspawnNotes', i, 'hitHealth', '0.5'); --Default value is: 0.023, health gained on hit
			setPropertyFromGroup('unspawnNotes', i, 'missHealth', '0'); --Default value is: 0.0475, health lost on miss
			setPropertyFromGroup('unspawnNotes', i, 'hitCausesMiss', false);

			if getPropertyFromGroup('unspawnNotes', i, 'mustPress') then --Doesn't let Dad/Opponent notes get ignored
				setPropertyFromGroup('unspawnNotes', i, 'ignoreNote', true); --Miss has no penalties
			end
		end
	end
	--debugPrint('Script started!')
end

-- Function called when you hit a note (after note hit calculations)
-- id: The note member id, you can get whatever variable you want from this note, example: "getPropertyFromGroup('notes', id, 'strumTime')"
-- noteData: 0 = Left, 1 = Down, 2 = Up, 3 = Right
-- noteType: The note type string/tag
-- isSustainNote: If it's a hold note, can be either true or false
function goodNoteHit(id, noteData, noteType, isSustainNote)
	if noteType == 'Attack' then
		characterPlayAnim('dad', 'hit', true);
		characterPlayAnim('boyfriend', 'throw', true);
		cameraShake(none, 0.01, 0.1); -- none is nothing anyway
		playSound("Slash", 1, "SlashingSound")-- Thanks tylerandari12!
	end
end

-- Called after the note miss calculations
-- Player missed a note by letting it go offscreen
function noteMiss(id, noteData, noteType, isSustainNote)
	if noteType == 'Attack' then
		-- nothing
	end
end

I appreciate you trying but it didn't work. I even tried changing "SlashingSound" to just "Slash" still didn't work and the attack animation name is "attack" not "throw"

Ive got nothing else...
Sorry ;-;

But I do have a question...
whats the point of cameraShake(none, 0.01, 0.1);?

But I do have a question...
whats the point of cameraShake(none, 0.01, 0.1);?

I have no idea
The Lua file for it was in a fnf mod pack dodging and dancing

Remove it and try one last time...
I think I know whats wrong. (Its something with errors that  arent fatal.)

But I do have a question...
whats the point of cameraShake(none, 0.01, 0.1);?

Here's the link for it https://youtu.be/-6HqF9tkRmY

But I do have a question...
whats the point of cameraShake(none, 0.01, 0.1);?

Here's the link for it https://youtu.be/-6HqF9tkRmY

The animation works in game too

But I do have a question...
whats the point of cameraShake(none, 0.01, 0.1);?

Here's the link for it https://youtu.be/-6HqF9tkRmY

The animation works in game too

https://youtube.com/shorts/VbDKGjlnjXg?feature=share

Remove it and try one last time...
I think I know whats wrong. (Its something with errors that  arent fatal.)

 My username is Aden-Mystio#9184


Upgrade to OCaml 5.1

Let's upgrade our compiler version to the latest.
This is very similar to #2 so refer to this issue for details on how to proceed.
I haven't looked at the changes between 4.14 and 5.01 in the compiler libraries so I'm not sure if this upgrade will be seemless or will require changes to our code but I'll gladly guide you if it does.

@NathanReb I would really like to work on #27 since that is a medium issue and would get me a chance to work with the tests but if that is not assigned to me, I would like to work on this one. (I'm also available to work on both the issues).

Hi @NathanReb
I would like to work on this issue as a good first issue seeing I will be contributing for the first time in the api-watch project.

@Siddhi-agg I assigned you to a more complex issue as you have already made contributions to the project.
@mridulsrivastavaa or @nawarajshah would you be interested in taking care of this?
@iAlexeze I'm really sorry, I'll try to favor applicants who already showed interest before but couldn't contribute before because all issues were taken. If they are not interested anymore and do not manifest I will gladly assign this to you!

@NathanReb yes i am intrested

@Siddhi-agg I assigned you to a more complex issue as you have already made contributions to the project.
@mridulsrivastavaa or @nawarajshah would you be interested in taking care of this?
@iAlexeze I'm really sorry, I'll try to favor applicants who already showed interest before but couldn't contribute before because all issues were taken. If they are not interested anymore and do not manifest I will gladly assign this to you!

Yes, I am interested in contributing in this issue .

I have made a pull request, @NathanReb can you please review this?

I assigned @nawarajshah since they got here first. I'll try to think of another good first issue @mridulsrivastavaa but you should also look for other projects in the meantime as I can't guarantee you'll get a chance to contribute here unfortunately.

I assigned @nawarajshah since they got here first. I'll try to think of another good first issue @mridulsrivastavaa but you should also look for other projects in the meantime as I can't guarantee you'll get a chance to contribute here unfortunately.

If any good first issue gets open please assign me to it. Meanwhile I'll look for other projects to contribute to.


(FM-7550) Fixes for agent based port_channel acceptance tests

Codecov Report

Merging #81 into puppet6 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           puppet6     #81   +/-   ##
=======================================
  Coverage     5.49%   5.49%
=======================================
  Files          169     169
  Lines        20624   20624
=======================================
  Hits          1133    1133
  Misses       19491   19491

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c950ae1...36257fa. Read the comment docs.


Regenerate TextAnalytics with swagger file v3.1-preview.1

Fixes #9991 and #9591.

Looks good from codegen POV

@ramya-rao-a and @willmtemple could you take a look?


fix: 🐛 fix bug which crashes app on browse block last page

:tada: This PR is included in version 1.4.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add schema validation to CPP generated code

A data file's associated schema should be available to check the validity of the input data, and perhaps short-circuit before creating a cpp object.

Just a thought: Could we do validation directly in the generated cpp, rather than using a separate validation library?


Bug: Fix for Query with Special Characters Failing Against Overseer

Modified Overseerr call to encode the query parameter
Added new util function, url-encode-illegal-characters (sources from hato.middleware) but with URL encoding all non alpha-numeric characters.

This is a good solution for now - but I think I need to figure out why hato wasn't URL-encoding everything.

You know this issue...you commented on the Overseer repo...https://github.com/sct/overseerr/issues/2010
Look at my last comment here. https://www.reddit.com/r/Clojure/comments/1akfy0a/comment/kp9v1eo/?context=3
It's not that the encoding is wrong, it's that Hato is using + to encode spaces, but Overseer expects %20.

You know this issue...you commented on the Overseer repo...https://github.com/sct/overseerr/issues/2010

And I had promptly forgotten about it.


Markdown highlighting not working directly after an HTML tag

VSCode Version: 1.52.0
OS Version: Windows 10

Steps to Reproduce:

In a markdown file write:

# Title

**test**

See that the title and the bold text are not highlighted.

To fix this problem, the user can add an empty line:

But when using an extension which adds an anchor to titles for generating Table of Content, for example, we don't always have the control of where the HTML elements are being added.

Does this issue occur when all extensions are disabled?: Yes

This matches how the markdown is rendered:

Github has the same behavior:

# Title

**test**

Sorry @mjbvz,  when reporting the issue I changed the HTML element used compared to my code because I thought it was the same for all of them.
The code I used in my application is actually using anchor HTML element.

# Title

**test**

I just checked on VSCode and Github the markdown is being rendered correctly.

GitHub demo:

Title

test
End of GitHub demo

I guess there is a special case for the anchor element here.


Create documentation page with glossary of terms

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[ ] Did you write any new necessary tests?
[x] Did you update the CHANGELOG?

Proposed Changes
See #1349.
Closing issues
Closes #1349.

Codecov Report

:exclamation: No coverage uploaded for pull request base (docs-prototype@8670ae2). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@               Coverage Diff                @@
##             docs-prototype   #1353   +/-   ##
================================================
  Coverage                  ?   6.60%
================================================
  Files                     ?     204
  Lines                     ?   12637
  Branches                  ?       0
================================================
  Hits                      ?     835
  Misses                    ?   11802
  Partials                  ?       0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Use image hosted on ghcr.io

https://github.com/cybozu-go/moco/issues/535

Use image hosted on ghcr.io.
We also use a local mysql image to run E2E tests after building the MySQL image.
This allows more detailed testing of the built mysql image.

I rebased this PR because it conflicted with https://github.com/cybozu-go/moco/pull/548.