Fix various NDEBUG compiler warnings

This is an alternative to #1255. With this NDEBUG compiles without warnings for me.

To be clear: the grand goal of #1255 was to make it such that use of a variable inside log_debug() and log_assert() would block the unused-variable warning, even under #define NDEBUG, without any additional user intervention.
Requiring YS_ATTRIBUTE(unused) -- whilst it does suppress the warning (which admittedly is the main title of both PRs) -- my position is that this (a) imposes a cognitive load for developers, who don't typically compile with NDEBUG, and (b) is a suppression that will persist even if the log_*() is later removed, resulting in a false negative.

To be clear: the grand goal of #1255 was to make it such that use of a variable inside log_debug() and log_assert() would block the unused-variable warning

I think someone building with NDEBUG doesn't want unnecessary code to run. So I guess we should use those warning to guide us to actually remove that unnecessary code in the NDEBUG case.
Simply to trust that the compiler will optimize away is overly optimistic in my opinion. And generally not a good guess from my experience.
So just making the compiler warning go away is imo a step in the wrong direction. We should actually fix the underlying condition the compiler is warning us about, which is that we are spending cycles on calculating things that are not used.

Requiring YS_ATTRIBUTE(unused) -- [..] even if the log_*() is later removed, resulting in a false negative.

And that's why it should only be used in cases where using #ifndef blocks would be cumbersome (for example because it's a function parameter), or where we just want log_assert to check the return code of a function we want to call anyway, such as the toposort examples in my patch.

I agree with your points. We should use YS_ATTRIBUTE(unused) sparingly, but (assuming we get many more liberal uses of log_{assert,debug}()) this would assume that we have to apply it to every variable which is only used by those functions. I would still not prefer that, but not something I would die fighting for.
Your suggested change from #1225 should be obvious enough for a compiler to optimise, no?
- #  define log_assert(_assert_expr_)
+ #  define log_assert(_assert_expr_) do { if (0) (void)(_assert_expr_); } while (0)

more liberal uses of log_{assert,debug}()) this would assume that we have to apply it to every variable which is only used by those functions.

I'd argue that in this case the code should be structured in a way so that there is one big #ifndef block containing all the variables and log_debug() calls, instead of creating individual variables here and there just so we can log them later.

Your suggested change from #1225 should be obvious enough for a compiler to optimise, no?

My point is that we actually want to get that warning message for unused variables, as they are indicators of us potentially performing unnecessary computations. This change would suppress the warning, without doing anything about the underlying problem the compiler is warning us about.

I'd argue that in this case the code should be structured in a way so that there is one big #ifndef block containing all the variables and log_debug() calls, instead of creating individual variables here and there just so we can log them later.

Normally, that is the case. In a few rare bits of my code, I call functions that have side-effects and that return something. In a debug scenario, I'd like to output those return values, or maybe assert on them. During NDEBUG those variables are no longer consumed, and so cause a warning. Since this only happens rarely, I can YS_ATTRIBUTE(unused) them, then.


Try setting env var that setup-node writes to .npmrc

The setup-node action writes an .npmrc file with NODE_AUTH_TOKEN as a placeholder for use when doing things like publishing packages. See https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#publish-to-npmjs-and-gpr-with-npm for an example. Let's see if this fixes the auth issue in the libs release.
Signed-off-by: Luke Tillman<EMAIL_ADDRESS>

note that it won't solve the issue on golang side


Typo fix: MX_THREAD_LOCAL

This file should be simply removed in favor of dmlc-core/thread_local

@tqchen I see

please hold until this has been merged: https://github.com/dmlc/dmlc-core/pull/247

@ZihengJiang could you remove the file and update dmlc-core?


Default translation for custom fields and entities

First of all, way to reproduce problem:

Set lang in the settings to default (English)
Add a custom "test" field for the Account entity, set it's label to "Test" (click "update schema", and so on)
See brand new field on the Account page with name "Test"
Change lang in the settings for example to Russian
Back to the Account page and see "orocrm.account.test.label" instead of human readable name

I think, expected behaviour should be something like this:

English translation should be "default"
If we change settings to non-English lang and there is no translation for label (or other things), English translation should be displayed
If we create for example custom field in Russian "mode", English translation should be automatically duplicated from Russian. So if we change settings to English we should see same label as we created.

@turboezh can you please check if it's still relevant? Thank you.

Hi.
Yes, I've just reproduced the problem on demo-b2b.orocrm.com.
But in reversed way:

switch language to Russian in Language settings;
create custom field foo_test2 in Account entity and label it Тест2. Label in account view is as it was created - Тест2;
switch language back to English. Label is Orocrm.Account.Foo_test2.Label now.

And by the way. I saw oro.tag.entity_plural_label instead Tags label when I switched to Russian.

It is not a bug. We do not have a UI that would allow simultaneous translation into multiple languages, independent from the currently selected language. We intend to add the translation management UI to OroPlatform in one of the next releases.
If you are willing to propose a quick fix that you believe will work for most users we may consider and accept it as an interim solution as well.


Version 1.0.0 - the first major version

The first major version is here! 🎉
Version 1.0.0 introduces large updates to the design system like updating to MUI v5, changing Storybook environment and changing the DatePicker component. It introduces a lot of breaking changes and the migration from previous versions should be done carefully. We acknowledge there might be some stones that were left unturned so if you run into any issues please open a new issue here!
Changes
🆙 MUI v5 upgrade

MUI is a core dependency of the design system and this update focused on customisation developer experience.
Changes styling library to emotion and styling can now mostly done with the efficient sx prop
If you used the design system components previously in your project we recommend checking out the MUI migration guide for details about the changes

📚 Changing Storybook environment from CRA to Next.js

Doesn't change the npm package but focuses on the Storybook documentation and contributor experience
Changes old CRA environment to current go-to React env, Next.js
Simplifies eslint config and adds eslint-plugin-storybook
Move stories under their own folder

📆 Datepicker upgrade

Changes the underlying Datepicker component used from react-dates to MUI datepicker. React-dates was not actively maintained and running old versions of dependencies so this was a very welcome change.
The datepicker now doesn't enforce a single date utility library but instead provides support for Moment, DateFns, Dayjs and Luxon.
Changes the look and feel of the Datepicker component, adds a quick year selection
Removes support for date range selection which will be added at a later stage

📦 New component: Box and other minor changes

New Box component for easy styling with the sx prop, Box basically acts as a HTML div element that you can apply sx styles to
Paper now also has a story for easier discovery of the component. Paper is fairly similar to Box but has built-in elevation
One of the underlying components for DropdownMenu, MenuList, was replaced with Menu
MUI system props are hidden in stories but can be used with most components. But we recommend using the sx prop instead of these

That looks awesome, really appreciate heavy lifting you have done here @PetroSilenius and @susannalandstrom 💪

Thanks Kacper!🙏🏻

Looks so good! Thanks for pushing this forward and doing most of the work @PetroSilenius ! 🎉 I actually just realised that label and showDaysOutsideCurrentMonth props are missing from storybook arguments on DatePicker component. Should we still add those?

Hey good catch! I'll add those here

@PetroSilenius remebr to modify the relaeas notes with the same info as we have in this PR. The release creates itself in the pipeline, but you have to edit it manually

@PetroSilenius remebr to modify the relaeas notes with the same info as we have in this PR. The release creates itself in the pipeline, but you have to edit it manually

Thanks for the reminder @dusan-turajlic ! I'll make sure to do that👍🏻


Graph explorer widget

Adds the integrated graph explorer widget.
Test Procedure:

Run the GraphExplorer.ipynb notebook
Review the code
checkout and doit if feeling thourough.

Blocked by #68 #61
Closes #74

TODO need to pull improved_vis before merge.

TODO need to pull improved_vis before merge.

So I've gotten it back up to working browser stuff over on #84... we could:

merge that in here (i can't retarget it)
merge this first, then do more review

So I've gotten it back up to working browser stuff over on #84... we could:

merge that in here (i can't retarget it)
merge this first, then do more review

So I've gotten it back up to working browser stuff over on #84... we could:

merge that in here (i can't retarget it)
merge this first, then do more review

Lets merge this then do more. I'm working on another small patch PR based on comments from santiago.

So I've gotten it back up to working browser stuff over on #84... we could:

merge that in here (i can't retarget it)
merge this first, then do more review

Lets merge this then do more. I'm working on another small patch PR based on comments from santiago.

Not sure how conflicts appeared. Investigating now.

Not sure how conflicts appeared. Investigating now.


TreeView: scrambled contextflyouts when dynamically assigned

Describe the bug
Our application uses contextmenu flyouts that are dynamically configured depending on the tree view item data. When tree nodes are removed and added the dynamic context menu does not match with the datacontext of the related tree view item.
As we still have some XML-defined static contextmenu flyouts and our treeview uses template selectors the ContextRequested event will be swallowed. Instead, we tried with Loaded, Opeing, and DataContextChanged events. They all show the same issue that context menus get scrambled.
For the moment we get the best behavior when defining Opening events in the menuflyout.
The issue strongly correlates with the memory-leaking behavior reported in #8275. When using Clear() which leaks all nodes the scrambling is very frequent (but not always). With proper node removal, the issue is triggered very seldom. Unfortunately, occasionally it is still observed.
Steps to reproduce the bug
Unpack TreeStability_scrambling.zip.
Restore Nuget packages. Close and reopen the solution (to avoid a weird deployment error). Compile and run (in Debug x64).
Frequent Occurrence

Select Populate Method Mixed
Select Clear Method Clear()
Click on Repopulate Once several times
Inspect with right-click on red items the dynamic context menu. The number must match the number of the treeviewitem
In the failure case the context menu number is smaller and belongs to an earlier tree node

Rare Occurrence

Select Populate Method Mixed
Select Clear Method RemoveAtEnd() recursive
Perform Repopulate Once many times and inspect the context menu.
With this mode, the issue is very hard to catch (needs a lot of patience)

Example of failure cases

Be aware that Populate Methods Mixed 1st Expanded and Mixed 2nd Expanded suffer from the IsExpanded() crash, see  #8275.
Expected behavior
The number shown in the sub-context menu of 'Dynamic' should match the number of the related tree view item.

Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.2.4: 1.2.230217.4
Windows version
Windows 10 (21H2): Build 19044, Windows 10 (20H2): Build 19042
Additional context
Some More Background
 would be the obvious way.  But for unknown reasons, the Items Property in MenuFlyoutSubItem is a read-only property from Xaml side. As we have the UI element inside a template we also cannot use the approach using x:Name (that is documented on every documentation page of MS). The event ContextRequested isn't of help either. As soon as an initial context menu is defined in Xaml it gets swallowed.
Removing and re-attaching the events in code didn't help. It seems that the datacontext of the flyout is different than the underlying data.

Issue with all element properties updated directly in code
Actually, not only do context menu entries get scrambled but any element property that gets updated directly by code. This can be e.g. a background color of a text field.
void MainWindow::OnDataContextChanged(
    winrt::Windows::Foundation::IInspectable const& sender,
    winrt::Windows::Foundation::IInspectable const& args)
{
    if (const auto border = sender.try_as<winrt::Microsoft::UI::Xaml::Controls::Border>())
    {
         border.Background(brush);  // <- Will fail as border background is set directly
         // Iterate through elements to get the property
         // ...
         textblock.Text(text);  // <- Will fail as textblock property text is set directly
         if (const auto item = border.DataContext().try_as<TreeStability::FirstItem>())
         {
             item.Name(text);  // <- Will work as textblock entry is updated over the data context with x:bind
         }
    }
}

In the following example (see attached solution TreeStability_FailureCaseOpeningContextMenu.zip) we modify the background color, one of the textbox texts and the context menu by code. Once the failure is triggered all these directly modified properties show the wrong value. The ones that are changed over the data context with x:bind behave correctly.

Once we hit the failure mode all future updates will be scrambled. When the failure mode is triggered is not exactly clear in the example I managed to trigger it by opening a context menu by right click or just during normal Clear() operations. It also seems system dependent. We could see the initially described context scrambling only on specific systems.
The scrambling manifests itself in this case as a recycling of an older visual style that does not match the current data context. The changes are updated on a background object but do not get used for display. This looks like virtualization is causing the issue as it doesn't seem to care about element property updates.
Workaround using x:bind
From the above observations a possible solution for the context menu scrambling becomes obvious.
Only perform treeview and listview item updated by using x:bind!
For the context menu it is unfortunate that we cannot use x:bind on Items() [See https://github.com/microsoft/microsoft-ui-xaml/issues/1087]. Thus, we need to use x:bind on ContextFlyout. This is quite unfortunate as the entire context menu needs to be recreated with every update.
<DataTemplate x:Key="oneTreeViewItemTemplate" x:DataType="local:FirstItem">
    <Border
        ContextFlyout="{x:Bind ContextMenu, Mode=OneWay}"
        DataContextChanged="{x:Bind OnDataContextChanged}">
        <StackPanel
            Orientation="Horizontal"
            Background="#50ff0000"
            CornerRadius="3"
            Padding="4"
            Spacing="16">
            <TextBlock
                Text="First"/>
            <TextBlock
                Text="{x:Bind Name, Mode=OneWay}"/>
            <TextBlock
                Text="{x:Bind Uid, Mode=OneWay}"/>
            <TextBlock
                Text="{x:Bind FirstValue, Mode=OneWay}"/>
        </StackPanel>
    </Border>
</DataTemplate>

winrt::Microsoft::UI::Xaml::Controls::Primitives::FlyoutBase FirstItem::ContextMenu() const
{
    return contextMenu_;
}

void FirstItem::OnDataContextChanged(
    winrt::Windows::Foundation::IInspectable const& sender,
    winrt::Microsoft::UI::Xaml::DataContextChangedEventArgs const& args)
{
    if (const auto data = args.NewValue().try_as<TreeStability::FirstItem>())
    {
        contextMenu_ = winrt::Microsoft::UI::Xaml::Controls::MenuFlyout();
        // Replace MenuFlyoutSubItem as just replacing the Items() will not work
        auto dynamicFlyout = winrt::Microsoft::UI::Xaml::Controls::MenuFlyoutSubItem();
        dynamicFlyout.Text(L"Dynamic");

        // Fill Items()
        auto flyout = winrt::Microsoft::UI::Xaml::Controls::MenuFlyoutItem();
        flyout.Text(data.Uid());
        flyout.Tag(winrt::box_value(winrt::hstring(data.Name())));
        dynamicFlyout.Items().Append(flyout);

        auto staticFlyout = winrt::Microsoft::UI::Xaml::Controls::MenuFlyoutItem();
        staticFlyout.Text(L"Static");

        contextMenu_.Items().Append(dynamicFlyout);
        contextMenu_.Items().Append(winrt::Microsoft::UI::Xaml::Controls::MenuFlyoutSeparator());
        contextMenu_.Items().Append(staticFlyout);

        RaisePropertyChanged(L"ContextMenu");
    }
    else
    {
        OutputDebugStringW(L"Error: Expected a FirstItem type, but got something else.\n");
        assert(!"Expected a FirstItem type, but got something else.");
    }
}

winrt::Microsoft::UI::Xaml::DependencyProperty FirstItem::firstValueProperty_ =
    winrt::Microsoft::UI::Xaml::DependencyProperty::Register(
        L"FirstValue",
        winrt::xaml_typename<winrt::hstring>(),
        winrt::xaml_typename<TreeStability::FirstItem>(),
        winrt::Microsoft::UI::Xaml::PropertyMetadata{ winrt::box_value(winrt::hstring()) }
);

See TreeStability_workaround.zip for the full solution that is working expected.
Note: The ticket https://github.com/microsoft/microsoft-ui-xaml/issues/1652 is closely related but the proposed approach will not solve the scrambling. It is not enough to replace the entire flyout. Only updating the full context menu by x:bind will behave correctly.


Challenge: allow interacting with bot from discord chat

Just trying to think of a new feature that we can add now that we are familiar with basic API and have got something working.
I am thinking of a feature where after seeing the alert for price, user can send a command to bot to change the max/min limit for alerting.

Not sure if this is possible or not, but I am guessing there should be some API which allows to send POST requests.

I think this is going to be a tough feature to implement.


Fix build breakage with Node.js 10.0.0-10.9.0.

The five argument WriteUtf8() method was introduced in Node.js v10.0.0,
it doesn't exist in older 10.x releases.

Fixes: https://github.com/nodejs/nan/issues/832
Refs: https://github.com/nodejs/nan/pull/825

@bnoordhuis Do you think it would be a good idea to extend the test matrix with the initial node.js versions (e.g. add TRAVIS_NODE_VERSION="10.0.0",...)?

We could do that for 10, but doing it for others would lead to too large a test matrix.
Ideally it would not be necessary. I still do not see why changes of this nature are introduced in minor versions of Node, but that ship has sailed so we have to make the best of it.
On December 17, 2018 11:05:16 PM GMT+02:00, "Gerhard Stöbich"<EMAIL_ADDRESS>wrote:

@bnoordhuis Do you think it would be a good idea to extend the test
matrix with the initial node.js versions (e.g. add
TRAVIS_NODE_VERSION="10.0.0",...)?

I would vote to add it for the "active" NodeJs versions, e.g. 10 and 11. I don't expect that anyone will touch older versions but I could imagine that the same deprecation mechanism used in Node 10 could happen again in 11 to prepare for 12.
Maybe remove versions like 5 from the matrix to reduce load?

@kkoopa LGTY? Would be best to put out a bug fix release ASAP.

Yes, I will look through it and likely publish tonight when I get home.
On December 18, 2018 5:37:48 PM GMT+02:00, Ben Noordhuis<EMAIL_ADDRESS>wrote:

@kkoopa LGTY? Would be best to put out a bug fix release ASAP.

Done, thank you both for triaging this.


CQM Objective having 0 energy for all samples

Hi, I've written a script for a TSP model, and weirdly all the energies for the samples are 0. Could you kindly assist with this?
my code is in my repo :
https://github.com/ACE07-Sev/CQM-TSP
If you could kindly assist me in resolving this I'd be immensely grateful. (it's a bit urgent hence I would be immensely grateful if you could help me solve this as soon as possible. Thank you so much for the support)

As before, I'd recommend reaching out to our Leap community.


Unify the expression between versions

Come from https://github.com/toml-lang/toml/pull/737

@pradyunsg How did you want to handle PRs to the site? Since there's never been one I guess there's no process in place!

@cannikin I think there's 2 kinds of PRs we'd see:

touching the frontend code
I'd like for you to review these, if you're able to make the time. Maybe anyone of the folks w/ the commit bit can do these reviews/merges. OTOH, since you've written the bulk of the frontend code, you're the best person to review those changes. :)

translations
I think we should have some sort of process for this. I propose we require at least one person (not the author) who is familiar with the language to review the PR. This can basically be anyone from the community since I'm sure we don't know all the relevant languages. I'm willing to trust people won't fake this w/ a sock puppet or whatever, but looking at the profiles should be sufficient to protect against this.

There's also gonna be PRs or something for releases of new versions, but we can get to that when we get there. :)
All this should get written down into contributing / maintainance documentation (I'll be doing that this weekend) and, then, we should be fine.

In this particular case do we need a second contributor to review or do is @LongTengDao good to go?

@LongTengDao authored both of these files, and these changes are language/consistency tweaks.
I think it'd be OK to merge this in as is. We've already had a more-than-long-enough grace period where someone could've reviewed this in the original PR. :)


Refine UI

The app is looking a bit different than the initial vision from the designer so it would be great if we could refine the UI to adhere with it.

Can I make this update in the main activity?

Can I make this update in the main activity?

Yes, that would be awesome!


Add new types to package exports definition for ESM support

Description
As of today, it's not possible to resolve the new typings with a TS project using ESM. With these changes, you can import types in ESM project, e.g.:
import type { SearchHit, SearchResponse } from '@opensearch-project/opensearch/api/types'

This is also backwards compatible with projects converting from TS + CommonJS to TS + ESM.
Issues Resolved
Closes #204
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[x] Linter check was successfull - yarn run lint doesn't show any errors
[x] Commits are signed per the DCO using --signoff
[x] Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AMoo-Miki

Is there a way to add a test for this so we don't break it in the future?

Is there a way to add a test for this so we don't break it in the future?

Unfortunately I'm not sure if there is an easy way to test it - it probably requires setting up a child project with ESM and type checking.
However, after having another look at the type definitions, I noticed the ./api/types -module is already exported from the root typings as opensearchtypes namespace export, similarly as ./api/requestParams. Should we export just the ./api/new as explicit ESM (type) export, and request users to import the types from ./api/types via the root package namespace export, such as:
import { ApiResponse, opensearchtypes } from '@opensearch-project/opensearch'
import { Client } from '@opensearch-project/opensearch/api/new'

const client: Client
const response: ApiResponse<opensearchtypes.SearchResponse<TDocument>> = await client.search({ ... })

Technically we could export the new types via the root typings as well, but if they're still partially work in progress and opt-in, I'd keep them separate.

@dblock @kavilla @AMoo-Miki not trying to rush anything, but happy to improve upon your request.
I'd suggest we change this PR to export only the new types
    "./api/new": {
      "types": "./api/new.d.ts"
    }

What do you think?

@perttukarna Is this related to https://github.com/opensearch-project/opensearch-js/issues/670#issuecomment-1864866676 ?

@nhtruong yes and no. 😄 This won't solve the problem of having two different type definitions for the client, but merely makes the new type definitions available for certain project setups (TS + ESM in particular).

@dblock @kavilla @AMoo-Miki can you take a look, please?


[Question] Support constraining via context free grammar for dsls

Hi @lbeurerkellner,
Do you have any plans to "natively" integrate token constraint into the lmql language, perhaps through ATLR/Lark/ENBF grammar notation? This is a feature currently supported by guidance (https://github.com/guidance-ai/guidance?tab=readme-ov-file#context-free-grammars) and outlined in examples from other projects like outlines (https://github.com/outlines-dev/outlines?tab=readme-ov-file#using-context-free-grammars-to-guide-generation).

We have some plans, but there is no concrete ETA currently. I will keep the issue to track the status.
Do you have any concrete use cases in mind?

Do you have any concrete use cases in mind?

Yes, I do. I recently was playing around with a DSL for HMI testing within the automotive domain. Using guidance my script look like the following:
from transformers import AutoModelForCausalLM, AutoTokenizer
import torch
import guidance
from guidance import models, system, user, assistant, gen, select, one_or_more

checkpoint = "HuggingFaceH4/zephyr-7b-beta"
lm = models.TransformersChat(checkpoint, device_map="auto", torch_dtype=torch.bfloat16)

@guidance(stateless=True)
def enter_teststep(lm):
    return lm + "Enter " + gen(stop="into", max_tokens=20) + " into the " + gen(max_tokens=3) + "."

@guidance(stateless=True)
def tap_teststep(lm):
    return lm + "Tap the " + gen(stop="button", max_tokens=3) + " button"

@guidance(stateless=True)
def modification_teststep(lm):
    return lm + select(["Activate", "Deactivate"]) + " the " + gen(stop="option", max_tokens=3) + " option"

@guidance(stateless=True)
def slider_modification_teststep(lm):
    return lm + select(["Increase", "Decrease"]) + " the " + select(["vertical", "horizontal"]) + gen(stop="slider", max_tokens=3) + " slider by " + one_or_more(select(['0', '1', '2', '3', '4', '5', '6', '7', '8', '9'])) + gen(max_tokens=2)

@guidance(stateless=True)
def selection_teststep(lm):
    return lm + "Select " + gen(stop="from", max_tokens=5) + " from the list"

@guidance(stateless=True)
def teststep(lm):
    return lm + select([enter_teststep(), tap_teststep(), modification_teststep(), slider_modification_teststep(), selection_teststep()])

system_msg = "You are an expert in software testing within the automotive infotainment domain. Additionally, your understanding of the ANTLR grammar is enormous."

prompt = """Antlr Grammar for Test Case Description DSL in the Infotainment Domain:

grammar TestCase;

testcase: 'Testcase:' ID
  'Preconditions:' teststeps*
  'Actions:' teststeps+
  'Postconditions:' teststeps*;

teststeps: enterStep
  | tapStep
  | modificationStep
  | sliderModificationStep
  | selectStep;

enterStep: 'Enter the' OBJECTNAME 'into the' TARGETNAME;

tapStep: 'Tap the' OBJECTNAME 'button';

modificationStep: (Activate | Deactivate) 'the' OBJECTNAME 'option';

sliderModificationStep: (Increase | Decrease) 'the' ORIENTATION OBJECTNAME 'slider by' NUMBER UNITS;

selectStep: 'Select' OBJECTNAME 'from the list';

OBJECTNAME: ID;
TARGETNAME: ID;
ORIENTATION: 'vertical' | 'horizontal';
UNITS: ID;
NUMBER: DIGIT+;
Activate: 'Activate';
Deactivate: 'Deactivate';
Increase: 'Increase';
Decrease: 'Decrease';

ID: [a-zA-Z]+;
DIGIT: [0-9];

User Test Case:

Testcase: Check bass slider from -10 to 10

Preconditions:
Tap the settings button
Tap the tone settings button

Predict the next logical test step using the grammar rules.

The next logical test step is the following action:
-
"""

with system():
    llm = lm + system_msg

with user():
    llm += prompt

with assistant():
    llm += teststep()

resulting in the following response:


#9 Add check for spaces around equal sign

Closes #9

@artem-russkikh Thank you for your contributing!
I've left a few comments. Could you please fix them?

@artem-russkikh I've just updated the readme file. Please pull new changes from the master branch.

@artem-russkikh Thanks a lot! You're awesome! ❤


Improve select menu integration

See comments for explanations.

Just did some blaming on the original select menu stuff. I originally wrote this all back around Feb 2012. It's lasted for a while.

You also might want to actually test all this.

i don't know i've merged joshcode blind before and it works 100% of the time

Alright, I think these class changes should fix the focus issues. Also @mdo says hi.

Awesome! Thanks friends! 😻

@josh does the PRs page work differently than Issues? The focus is still kind of weird on PRs :(

PRs and Issues should be pretty similar. I think there might be some other navigation items somewhere screwing with that activation. Though, I would think some of my changes would help.


Longer Todos show ugly spacing

The text spacing of a one-line Todo item looks fine and is left justified. Todo items that are long enough to word-wrap onto the next line are badly spaced to stretch the first line to fill the entire todo window. This is caused by text-align: justify in keikaku.css at line 23, which seems to be ignored for single-line divs, so it only takes effect for multi-line Todo items:
#keikaku-todo-list .todo-description {
    text-align: justify;

I experimented with the dev console to change it to text-align: left. It looks much better for multi-line Todo items and doesn't change the display of single-line Todo items.
Browser: Chromium
OS: MacOS

It does indeed look a bit weird in certain cases. I guess I can justify removing that line.


add ip_access filter

add IPAllowlist filter
Issues associated with this PR
Your PR should present related issues you want to solve.
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style

Make sure Goimports has run
Show Golint result

After referring to nginx, I think that blocklist and allowlist can be used at the same time. When both are configured, blocklist will be used to check whether ip is forbidden, and then allowlist is used to check whether ip is allowed to be accessed. When only one of them is configured, only the configured one will take effect. Do you think this satisfies the demand?

I think that blocklist and allowlist can be configured more than one，and the rules are checked in sequence until the first match is found.

After referring to nginx, I think that blocklist and allowlist can be used at the same time. When both are configured, blocklist will be used to check whether ip is forbidden, and then allowlist is used to check whether ip is allowed to be accessed. When only one of them is configured, only the configured one will take effect. Do you think this satisfies the demand?

I think that blocklist and allowlist can be configured more than one，and the rules are checked in sequence until the first match is found.

oh, you are right！our list can be confirugred more than one addrs.
btw,  what‘s the default action when both are configured, allow or deny？

After referring to nginx, I think that blocklist and allowlist can be used at the same time. When both are configured, blocklist will be used to check whether ip is forbidden, and then allowlist is used to check whether ip is allowed to be accessed. When only one of them is configured, only the configured one will take effect. Do you think this satisfies the demand?

I think that blocklist and allowlist can be configured more than one，and the rules are checked in sequence until the first match is found.

After referring to nginx, I think that blocklist and allowlist can be used at the same time. When both are configured, blocklist will be used to check whether ip is forbidden, and then allowlist is used to check whether ip is allowed to be accessed. When only one of them is configured, only the configured one will take effect. Do you think this satisfies the demand?

I think that blocklist and allowlist can be configured more than one，and the rules are checked in sequence until the first match is found.

oh, you are right！our list can be confirugred more than one addrs. But, what‘s the default action that both are configured, allow or deny？

deny, blocklist first

After referring to nginx, I think that blocklist and allowlist can be used at the same time. When both are configured, blocklist will be used to check whether ip is forbidden, and then allowlist is used to check whether ip is allowed to be accessed. When only one of them is configured, only the configured one will take effect. Do you think this satisfies the demand?

I think that blocklist and allowlist can be configured more than one，and the rules are checked in sequence until the first match is found.

After referring to nginx, I think that blocklist and allowlist can be used at the same time. When both are configured, blocklist will be used to check whether ip is forbidden, and then allowlist is used to check whether ip is allowed to be accessed. When only one of them is configured, only the configured one will take effect. Do you think this satisfies the demand?

I think that blocklist and allowlist can be configured more than one，and the rules are checked in sequence until the first match is found.

oh, you are right！our list can be confirugred more than one addrs. But, what‘s the default action that both are configured, allow or deny？

deny, blocklist first

if we have a scenario like this，allow will be default action. it's too flexible...
    allow  <IP_ADDRESS>;
    deny <IP_ADDRESS>/24;
    allow all;

Welcome to our community （dingding）


Switch to dokken images in Travis & update platforms

Remove EOL CentOS 5 / openSUSE 13.2
Add Debian 9 / openSUSE Leap
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

@lamont-granquist If you're still Ok with the changes things are passing now. The CentOS issue was actually fixed in an updated openssh cookbook that handles docker, but all the other stuff is still worth having and gets us a tiny bit closer to turning the webapp and learn chef testing back on.

you need to rebase again, again


Don't require restart

after #150 - we shouldn't require restart to have a better UX - need to find what blocks us from doing that.

Might be related to #124


factor disk-based state storage to injectable type

It's now injected directly into commands that need it
The GDM loaded from disk is now directly injectable as well
This is a breaking change to the command line, you can not
specify a state dir right now, except via configuration.
It's apparent we need to use CLI flags in injection.
Adds a couple of readability tweaks.

UPDATE: State directory can now be specified via environment, e.g.:
    SOUS_STATE_LOCATION=$HOME/.local/share/sous/state sous [init|rectify|query_adc|query_gdm]

UPDATE2: State directory also has a default location, following XDG conventions (i.e. XDG_DATA_HOME and default value for that), so no need to specify it unless it's somewhere else.


You may need an appropriate loader to handle this file type.

I install this package on my laravel project and it always prompt this error when I debug the laravel/nova tool
**You may need an appropriate loader to handle this file type.**
My environment
NPM: 8.5.1
node: v12.22.9

That is a problem with your bundler or bundler config, not this package.


Work slow!

The loop for finding right UID in database need to check all IDs. Too slow operation.

In procces: search in databse by ID not Card ID.


Unable to authenticate on Azure China Cloud using CLI based authentication

Bug Report

What happened?

Here is my code -
package main

import (
	"context"
	"fmt"

	"github.com/Azure/azure-sdk-for-go/sdk/azcore/policy"
	"github.com/Azure/azure-sdk-for-go/sdk/azidentity"
	a "github.com/microsoft/kiota-authentication-azure-go"
	msgraphsdkgo "github.com/microsoftgraph/msgraph-sdk-go"
)

func main() {
	ctx := context.Background()

	// Create Azure CLI credential
	cred, err := azidentity.NewAzureCLICredential(nil)
	if err != nil {
		fmt.Printf("Error creating Azure CLI Credential: %v\n", err)
		return
	}

	tokenOptions := policy.TokenRequestOptions{
		Scopes: []string{"https://management.chinacloudapi.cn/.default"},
	}
	_, err = cred.GetToken(ctx, tokenOptions)
	if err != nil {
		fmt.Printf("Error obtaining token: %v\n", err)
		return
	}

	// Create an authentication provider with the Azure CLI credential
	auth, err := a.NewAzureIdentityAuthenticationProvider(cred)
	if err != nil {
		fmt.Printf("Error creating authentication provider: %v\n", err)
		return
	}

	// Create a request adapter using the authentication provider
	adapter, err := msgraphsdkgo.NewGraphRequestAdapter(auth)
	if err != nil {
		fmt.Printf("Error creating graph adapter: %v\n", err)
		return
	}

	// Create a new Microsoft Graph client with the adapter
	client := msgraphsdkgo.NewGraphServiceClient(adapter)

	// Example of listing users
	users, err := client.Users().Get(ctx, nil)
	if err != nil {
		fmt.Printf("Error getting users: %v\n", err)
		return
	}

	// Iterate through the user list
	for _, user := range users.GetValue() {
		fmt.Printf("User ID: %s, Display Name: %s\n", *user.GetId(), *user.GetDisplayName())
	}
}

What did you expect or want to happen?
It should work with Azure China Cloud
How can we reproduce it?
Anything we should know about your environment.

I guess this is about the error mentioned in https://github.com/turbot/steampipe-plugin-azuread/issues/167 (if not, please share details about the error)? That error suggests the CLI requested a token for Graph in Azure Public Cloud from Azure China i.e., someone called AzureCLICredential.GetToken() with the wrong scope. If it was the Graph client making the call, you need to configure that client to pass the correct scope for Azure China (https://graph.chinacloudapi.cn//.default). Looks like https://github.com/microsoftgraph/msgraph-sdk-go/issues/26 shows how to do this.

Thanks for the quick reply @chlowell, So below is the correct way to set the China Cloud endpoint -
package main

import (
	"context"
	"fmt"

	"github.com/Azure/azure-sdk-for-go/sdk/azidentity"
	a "github.com/microsoft/kiota-authentication-azure-go"
	msgraphsdkgo "github.com/microsoftgraph/msgraph-sdk-go"
)

func main() {
	ctx := context.Background()

	// Create Azure CLI credential
	cred, err := azidentity.NewAzureCLICredential(nil)
	if err != nil {
		fmt.Printf("Error creating Azure CLI Credential: %v\n", err)
		return
	}

	if err != nil {
		fmt.Printf("Error obtaining token: %v\n", err)
		return
	}

	// Create an authentication provider with the Azure CLI credential
	auth, err := a.NewAzureIdentityAuthenticationProvider(cred)
	if err != nil {
		fmt.Printf("Error creating authentication provider: %v\n", err)
		return
	}

	// Create a request adapter using the authentication provider
	adapter, err := msgraphsdkgo.NewGraphRequestAdapter(auth)
	if err != nil {
		fmt.Printf("Error creating graph adapter: %v\n", err)
		return
	}

	adapter.SetBaseUrl("https://microsoftgraph.chinaclouapi.cn/v1.0")

	// Create a new Microsoft Graph client with the adapter
	client := msgraphsdkgo.NewGraphServiceClient(adapter)

	// Example of listing users
	users, err := client.Users().Get(ctx, nil)
	if err != nil {
		fmt.Printf("Error getting users: %v\n", err)
		return
	}

	// Iterate through the user list
	for _, user := range users.GetValue() {
		fmt.Printf("User ID: %s, Display Name: %s\n", *user.GetId(), *user.GetDisplayName())
	}
}

That looks like the right function to me because judging by its name, NewAzureIdentityAccessTokenProviderWithScopes does what you need, but I'm not familiar with these modules (they aren't part of the Azure SDK). You may need to pass https://microsoftgraph.chinacloudapi.cn//.default for the scope--note the empty segment //.


Add make-boot-image service

Hi @XECDesign , would it be possible to get some feedback on this packaging approach? This service aims to create replacement images for linux-image--2712 packages that include the kernel directly into a signed ramdisk. I suspect I'll probably need a replacement linux-image-rpi-2712 meta-package too?

Updated documentation, validator.py, inserted preinst script to remove /boot/firmware/config.txt
This will have to be parked for-now as the cryptroot initramfs is unable to insmod the compressed .ko.xz modules. We can revisit this once the cryptroot image has been updated.

@roliver-rpi Is this ready to review in earnest?

@roliver-rpi Is this ready to review in earnest?

No, the current cryptroot initramfs is unable to insmod the compressed .ko.xz modules that we take from the linux-image package. This should be parked until we update the cryptroot initramfs.


users can't discuss/comment their files

A messaging feature is not implemented at the moment, so let's implement a commenting feature for privately and publicly shared files. A user should be able to post a comment on a file that has been uploaded, or post a comment on another users file. This is a bug, since this feature is important and will improve usability of the system. Let's modify the README and document this feature. Then, let's implement it and test.
Also see discussion #191

@yegor256 @ggajos lets keep the discussion going until its implemented.

@k0r yes, let's keep this ticket open for the future

@yegor256 netbout + nerodesk is going to be great.

@yegor256 updated.

@k0r I updated the title of the ticket too

@k0r also, "other suggestions" should be submitted in separate tickets. We're trying to keep strictly one ticket per problem, for clarity

@yegor256 this feature can be moved to 0.4 or 1.0 if necessary.

feature omitted from the project.

@k0r don't close it, ask @ghost to do do it, since he created it, thanks!

@yegor256 feature omitted from the project.

@karato close this one please, we won't implement it


qt_gui_core: 2.0.0-2 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository qt_gui_core to 2.0.0-2:

upstream repository: https://github.com/ros-visualization/qt_gui_core.git
release repository: https://github.com/ros2-gbp/qt_gui_core-release.git
distro file: rolling/distribution.yaml
bloom version: 0.10.1
previous version for package: 2.0.0-1

qt_dotgraph

No changes

qt_gui
* Fix 'dict_keys' object not subscriptable (#243 <https://github.com/ros-visualization/qt_gui_core/issues/243>)
* Contributors: Michael Jeronimo

qt_gui_app

No changes

qt_gui_core

No changes

qt_gui_cpp
* Fix duplicated QMap to QMultiMap (#244 <https://github.com/ros-visualization/qt_gui_core/issues/244>)
* Switch to using the filesystem implementation in rcpputils. (#239 <https://github.com/ros-visualization/qt_gui_core/issues/239>)
* Contributors: Chris Lalancette, Homalozoa X

qt_gui_py_common

No changes

This is a release bump to pick up the new dependency introduced by #28547


Issue with static_framework and MetalPetal as a dependency

Hello, I am using MetalPetal as a dependency in my pod, which has static_framework = true. When I add my pod to a new project, I get:
[!] Using Swift static libraries with custom module maps is currently not supported. Please build MetalPetal as a framework or remove the custom module map.
Checklist

[x] I've read the README
[x] If possible, I've reproduced the issue using the master branch of this repo
[x] I've searched for existing GitHub issues

Environment

Info
Value

MetalPetal Version
1.23.0

Integration Method
CocoaPods

Platform & Version
iOS 12.0+

Device
NA

Please refer to https://github.com/CocoaPods/CocoaPods/issues/9023

Thanks, unfortunately use_frameworks! :linkage => :static messes with other Pods in the project. I need to keep looking for a workaround.

If you are not intend to implement any new MTIImagePromise, you can remove the module map file from the podspec file.

great, thanks!


Feature request: compose

Since most Plexis functions are pure we can create composed functions using closures.
compose works in a more functional way and provides users with flexibility, creating complex and tricky string operations. compose actually invokes a series of functions.
@param {Function[]} [funcs] The functions to invoke.
@returns {Function} Returns the new composite function.

Example usage
import compose from '@plexis/compose';
const inc = x => x + 1;
const add = (x, y) => x + y;
const ops = compose(inc, x => add(x, 2));

ops(1); // returns 4;
ops(10); // returns 13;

Aliases
import compose from '@plexis/compose';
import {compose, _do} from 'plexis';

@vorillaz, can I take this ?

@dungwinux Thanks so much for contributing, go for it!


WIP: Remove redundant TraCI connecting

close #42

@JVillella test_boids is not deterministic, it failed due to different rand num.


[HOLD for payment 2023-04-27] [$1000] No red line for error in login page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

go to https://staging.new.expensify.com/
If logged in then log out of the app
Enter any number without country code to trigger error
Press on continue

Expected Result:
App should underline 'Phone or email' field with red color like it does on error on other fields throughout the app
Actual Result:
App keeps the green underline on 'Phone or email' field on error instead of underlining the field with red.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.93-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680512267199719
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01097b0f4dbbc159f0
Upwork Job ID:<PHONE_NUMBER>312259072
Last Price Increase: 2023-04-04

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

I'm getting a red line when I reproduce, so closing

Hi @laurenreidexpensify, on staging, there is still green line below field on error, is this latest build from main folder?

Ah good catch, confirmed on staging error is reproducible

📣 @suphero! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

Triggered auto assignment to @flodnv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01fa246dc16e21fcc7

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Proposal
Please re-state the problem that we are trying to solve in this issue.
Red line does not appear under the text input for error in login page.
What is the root cause of that problem?
The root cause of this issue is that we're not properly validating the phone number on the frontend. The regex defined here, does not validate the phone number similar to the backend.
What changes do you think we should make in order to solve the problem?
We can use a regex similar to what we're using on the backend to validate the phone number. We can also use a regex like this to validate the phone number on the login form:
^[\+]?[(]?[0-9]{3}[)]?[-\s\.]?[0-9]{3}[-\s\.]?[0-9]{4,6}$

What alternative solutions did you explore? (Optional)
None

@allroundexperts we already added isValidPhoneLogin before API call

Proposal
Please re-state the problem that we are trying to solve in this issue.
Red line does not appear under the text input for error in login page.
What is the root cause of that problem?
The root cause of this issue is that we're not properly validating the phone number on the frontend. The regex defined here, does not validate the phone number similar to the backend.
What changes do you think we should make in order to solve the problem?
We can use a regex similar to what we're using on the backend to validate the phone number. We can also use a regex like this to validate the phone number on the login form:
^[\+]?[(]?[0-9]{3}[)]?[-\s\.]?[0-9]{3}[-\s\.]?[0-9]{4,6}$

What alternative solutions did you explore? (Optional)
None

@allroundexperts we already added isValidPhoneLogin before API call

@jayeshmangwani Yes, but the regex we're using in there is not consistent with the validation we're doing on the backend.

Yes got your point

@allroundexperts I believe the regex it's standard we are using to validate the phone number is fine.
@suphero Proposal looks good to me, which use adds the highlight of the input if there is any error while login.
cc: @flodnv

Yeah probably with the product team can you check internally? @flodnv

The red border color for this makes sense to me.

Yep, this all sounds good to me 👍

📣 @suphero You have been assigned to this job by @flodnv!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Thanks @flodnv, I’ll open the PR as soon as possible.

A very similar bug was posted here: https://github.com/Expensify/App/issues/16760#issuecomment-1497862602 - it appears to be the same problem, but not just on the login page - it's also occurring within the app under the add bank account flow. Would anyone be opposed to combining that issue into this one and taking care of both in one go?

The phone numbers on the issue are handled as invalid email addresses instead of phone numbers and they are already getting a red line on the login page.
123435345/5/ :

1234353455? :

?_@1234353455 :

However invalid phone number (such as<PHONE_NUMBER>) on the login page is accepted by the server on the company information.
Login page:

Company Information:
https://user-images.githubusercontent.com/846531/230200898-38f286f9-c3e1-4a9e-b244-45faf308c41f.mp4
I think we should handle the issues separately.

And how do you handle this error with only regex (and without relying on server error) ?

This last one is specifically a server error

If there is no other obstacle, I'm opening the PR.

@flodnv Should we wait on anything here?

Trying to get screenshots on mobile native. It's the first time I start the app on mobile.

@flodnv Should we wait on anything here?

@Santhosh-Sellavel I don't think so? I am not following, what do you think we should be waiting on?

@flodnv Should we wait on anything here?

@Santhosh-Sellavel I don't think so? I am not following up, what do you think we should be waiting on?

Some errors might be specifically something wrong on the server, highlighting input on that case are we okay with that

I think that's fine because there are no other inputs on this form.

@suphero can you please apply to this job on Upwork? https://www.upwork.com/jobs/~01097b0f4dbbc159f0 Thanks!

@suphero can you please apply to this job on Upwork? https://www.upwork.com/jobs/~01097b0f4dbbc159f0 Thanks!

I've applied, thanks.

Hi @laurenreidexpensify, thanks I have also accepted the offer.

Note to myself: All offers are sent in Upwork for C, C+ and bug report

@suphero, @flodnv, @laurenreidexpensify, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Do we need to take any action?
@flodnv @Santhosh-Sellavel

@suphero No looks like we all good now that this has been deploying to staging! https://github.com/Expensify/App/actions/runs/4745920510
Once it's on prod this will update with payment date, which is 7 days from that

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.2-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17168

If no regressions arise, payment will be issued on 2023-04-27. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@laurenreidexpensify] Determine if we should create a regression test for this bug.
[ ] [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Reviewing TestRail it looks like our use cases for testing log in are:
Verify users can create new accounts and can log in with:

Public domain accounts - Gmail accounts
Expensifail accounts - High Traffic accounts
Accounts with an active 2FA

As we don't have an sms log in flow, I think we should add this

@suphero I don't think you accepted the offer in Upwork yet - can you check again and make sure you have accepted. Thanks!

I have accepted the offer, thanks for reminding me.

Everyone has been paid, @Santhosh-Sellavel let's work on closing out the final steps above so we can close out

@Santhosh-Sellavel once you've filled out checklist above we can close. Thanks

Regression Test Steps
From the PR, covers all cases we can use this.

Scenario 1 - Invalid Phone number

If logged in, log out of the app.
Enter "1234567890" into the "Phone or email" field.
Press the "Continue" button.
Ensure the app underlines the "Phone or email" field in red.

Success scenario:

Enter the phone number of an existing account.
Press the "Continue" button.
Ensure the app navigates to the "Password" page.

Scenario 2 - Invalid Password

If logged in, log out of the app.
Enter a valid phone number or email into the "Phone or email" field.
Press the "Continue" button.
Enter an invalid password into the "Password" field.
Press the "Sign In" button.
Ensure the app underlines the "Password" field in red.

Success scenario:

Enter the valid password into the "Password" field.
Press the "Sign In" button.
Ensure the app successfully signs in.

Scenario 3 - Invalid Two-Factor Code

If logged in, log out of the app.
Enter the email/phone of an account with TFA enabled into the "Phone or email" field.
Press the "Continue" button.
Enter the valid password into the "Password" field.
Press the "Sign In" button.
Enter an invalid two-factor code into the "Two factor code" field.
Press the "Sign In" button.
Ensure the app underlines only the "Two factor code" field in red.

Success scenario:

Enter the valid two-factor code into the "Two factor code" field.
Press the "Sign In" button.
Ensure the app successfully signs in.

Scenario 4 - Invalid Magic code

If logged in, log out of the app.
Enter the email/phone of an account with Passwordless input enabled (beta feature) into the "Phone or email" field.
Enter an invalid magic code into the "Magic code" field.
Press the "Sign In" button.
Ensure the app underlines the "Magic code" field in red.

Success scenario:

Enter the valid magic code into the "Magic code" field.
Press the "Sign In" button.
Ensure the app successfully signs in.

@flodnv this is something we missed handling so it's not introduced anywhere so we can skip the first three in the checklist as N/A.
But we have to add steps to test the improvement, Does this look good to you?
cc: @laurenreidexpensify

It looks good, but it's really heavy. We should ask QA what they think, and if they think we can simplify it.

Yeah, agree with that.  If need they could add it as multiple cases

Thanks @Santhosh-Sellavel - have passed that onto the QA request case. Closing this one out.


BUG: FAQ section dark mode feature not working

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
In the FAQ page , the dark mode feature toggle button is not working. It is not getting toggled to the dark mode. When clicked on the button nothing is happening.
https://github.com/Anushkabh/krishiconnect/assets/124669890/3be3b27f-ffc8-4ba5-a31d-39d3c24c719e
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hey @DevNandini02 !
You can start working on this issue.
Happy Coding ✨


cut off 95%

In the analysis the cutoff is 95% of the biggest blob for a trait to be retained.
If the trait is not retain and necessary for the rest of the analysis it create problems
in this case , the eye of the fish is excluded, /fs/ess/PAS2136/BGNN/Minnows/Segmented/INHS_FISH_23706_segmented.png
I feel the cut off is to restrictive.
Or we need a criteria to remove fish using the presence matrix.
This need to be clarified

I see, there are plenty of fish to play with, you are right, but in the last run with the 95% cut off I was fixing bug I got with around 60 images and realize that some had the small patch of eye in the caudal fin that were about 8% of the main eye like here
/fs/ess/PAS2136/BGNN/Minnows/Segmented/INHS_FISH_23706_segmented.png

We choose 60% for the moment


add experiment metadata to dev center page

enable experiement on node developer center

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/index.yml
:white_check_mark:Succeeded
View (azure-node-latest)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Vendor binaries inside of the main executable

Intent is to reduce the dependencies of dartboard to docker alone (and only in case the k3d backend is in use, otherwise no dependencies at all).
Summary of changes:

teach make to download interesting binaries
embed interesting binaries into golang executable
upon run, extract embedded binaries into .bin
when necessary, run embedded binaries from .bin

Last step is the biggest change, WIP.

The changes seem solid so far, what mechanism did you have in mind for distributing dartboard itself (docker images)?

Plain executable (like kubectl) and possibly docker image

kubectl was fully adapted, continuing on helm, k6 dropped.
Last one standing will be tofu. There question is: does it make sense to keep the tfexec baggage around or not?


SPDX JSON has external reference category of PACKAGE_MANAGER instead of PACKAGE-MANAGER

What happened:
Generated an SBOM in SPDX JSON format and took a look at the output and noticed it has external reference category of "PACKAGE_MANAGER".
What you expected to happen:
Per the SPDX JSON schema the value should be "PACKAGE-MANAGER", i.e. the separator should be a hyphen, not an underscore.
How to reproduce it (as minimally and precisely as possible):
Just run syft against a container and generate an SBOM in SPDX JSON format.
Anything else we need to know?:
Don't think so.
Environment:

Output of syft version:
0.58.0

OS (e.g: cat /etc/os-release or similar):
Ubuntu 10.04.6 LTS

Turns out this may be due to an inadvertent update in the JSON schema, see this.

We'll keep an eye on where it goes on that issue and what they decide. Great find thanks for the issue @ddillard!
Is this currently throwing any errors of compatibility on your end with this inadvertent update?

No, this isn't causing me any issues the moment.  I was just doing some testing and noticed the discrepancy.  If the proposed fix is implemented no changes will be required in syft, though I do believe grype might need a minor update.

Both are going to be supported so no issue for SBOM generation.

Just a note: there was a request to undo this change: https://github.com/anchore/syft/issues/1596


Fix global.get("foo.bar") for functionGlobalContext set values

Hey Nick,
Thanks for the quick response on discourse.

[v0.19.3] Node-RED version:
[v8.11.4] node.js version:

I tested the commit and it does fix the global.get for an object, but something else is going on here.
Import this flow:
[{"id":"f04a7ee8.bc4dc8","type":"inject","z":"db0d5b42.be5f8","name":"Go","topic":"","payload":"","payloadType":"str","repeat":"","crontab":"","once":true,"onceDelay":"","x":510,"y":200,"wires":[["61d941a9.4cf188"]]},{"id":"61d941a9.4cf188","type":"function","z":"db0d5b42.be5f8","name":"get gVar.counter","func":"msg.payload = global.get(\"gVar.counter\");\nreturn msg;","outputs":1,"noerr":0,"x":670,"y":200,"wires":[["a2d4f073.4edd08"]]},{"id":"a2d4f073.4edd08","type":"debug","z":"db0d5b42.be5f8","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":850,"y":200,"wires":[]},{"id":"56d40926.e258f","type":"inject","z":"db0d5b42.be5f8","name":"Load Manually","topic":"","payload":"","payloadType":"str","repeat":"","crontab":"","once":false,"onceDelay":"","x":540,"y":260,"wires":[["914ad10b.7d9ad8"]]},{"id":"914ad10b.7d9ad8","type":"file in","z":"db0d5b42.be5f8","name":"Reload gVar.js","filename":"/home/pi/.node-red/gVar.js","format":"utf8","x":720,"y":260,"wires":[["a65fbaeb.1fc4d8"]]},{"id":"a65fbaeb.1fc4d8","type":"function","z":"db0d5b42.be5f8","name":"parse","func":"msg.payload = msg.payload.replace('module.exports=','');\nglobal.set(\"gVar\",JSON.parse(msg.payload));\nreturn msg;","outputs":1,"noerr":0,"x":870,"y":260,"wires":[["a2d4f073.4edd08"]]}]
Create a file "/home/pi/.node-red/gVar.js" and put this in it:
module.exports={"counter":0,"isHome":true,"isSound":true,"isSoundAway":true,"isLight":true,"isLightAway":true,"button1State":true,"button2State":true,"prevAlarmCnt":1,"lmNodeID":1,"dalNodeID":2,"dht11NodeID":3,"dht22NodeID":4,"pirNodeID":5,"gateNodeID":6,"bmeNodeID":7,"adcNodeID":10,"w1NodeID":11,"w2NodeID":12,"w3NodeID":13}
I have this at the beginning of my settings.js:
// DG added - Global Vars
var gVar;
try {
gVar = require("/home/pi/.node-red/gVar.js");
} catch(err) {
gVar = {};
}
// DG end - Global Vars
And this is in settings.js under
functionGlobalContext: {
// os:require('os'),
// jfive:require("johnny-five"),
// j5board:require("johnny-five").Board({repl:false})
// DG added below this line (**use comma when adding more options):
fs:require('fs'), // read/write files in function nodes
gVar:gVar // See start of this file
// DG added - END (**No comma on last line)
},
This should set you up for the test case.
Steps:

sudo service nodered restart
in syslog you'll see [error] [function:get gVar.counter] TypeError: Cannot read property 'counter' of undefined
look at new context browser, gVar object was loaded properly.

Go to the flow and click "Go" (configured inject at start-up).  The result is "TypeError: Cannot read property 'counter' of undefined" as in syslog at startup.
Now manually click "Load Manually" inject and gVar can be accessed at will.
Click "Go" again and it gets returned.

I know I need to get away from this method of persistence. This method only covers 10% of my persistent variables.  It does allow me to control disk writes during testing.
Thanks again!

Thanks for the detailed issue report - always helpful.
You've hit a subtle case that affects both the in-memory and file-based context stores - both of which are now fixed. Will release 0.19.4 in the next day or so (am on vacation, but will have time to do it tomorrow hopefully).
In case you're interested in the details... we have a utility function to get the value of an object's property based on a string description. So in your case, it is passed in the contents of global context and the string "gVar.counter".
If the value doesn't exist, there are two possible cases.

if gVar exists, but doesn't have a counter property, then it returns undefined
if gVar doesn't exist it throws an error

It was this second case you were hitting. But why, you may ask, does gVar not exist when you have set it via functionGlobalContext. Well, that's because the code has to first check the in-memory context to see if it has a newer value for gVar.counter before it looks at whatever was in fGC - and it's this lookup in memory that was hitting the error. It's a valid error to hit - but the memory context store should have accepted it and returned undefined.


Bucket Tier[POST]: API to Create tier policy

Issue/Feature Description:
As a admin, I want to create tier policy. That tier can be used by user during bucket creation.
Why this issue to fixed / feature is needed(give scenarios or use cases):
How to reproduce, in case of a bug:
Other Notes /  Environment Information: (Please give the env information, log link or any useful information for this issue)

POST http://IP:PORT/v1/tenantId/tiers
Request Body:
name: string, Name of tier
backends: [], list of backendIds
Response:
Return Code: integer, Ex:200
Message: string, Ex: Successfully Created!


building with latest RC, main.css doesn't seem to be generated

Hi,
Thank you Ionic Team for the latest release candidate
but I seem to have a problem with I try to build with the sidemenu template
Short description of the problem:
building sidemenu project with latest RC and npm.
on first time starting the project up, the icons don't appear
when starting the project with ionic serve --lab, for a second, it seems the main.css has been removed from build folder. (In fact, the only file left in the build folder is polyfills.js)
Steps to reproduce:

ionic start --v2 myApp sidemenu
cd myApp
ionic serve --lab,(notice the icons don't appear) quit
ionic serve --lab, (notice the page1 don't appear, view console log to find that main.css seems to be deleted and not generated even when building is complete )

This issue was moved to driftyco/ionic-app-scripts#82

Hello, thanks for using Ionic! Since this is a build issue and not an issue with the conference app I have moved this issue to the app-scripts repo. Thanks!


document.createCDATASection missing

document.createCDATASection is missing though the spec indicates its presence: https://dom.spec.whatwg.org/#dom-document-createcdatasection
https://runkit.com/brettz9/5814f88df248640014f701e3/branches/master

Yes, it was recently added to the spec. Pull request welcome.

@brettz9 @domenic addressed in https://github.com/tmpvar/jsdom/pull/1649


Dedicated Pages added!!

Title : Dedicated Pages added for --
1.  Santorini ,Aegean Sea
2. Machu Picchu ,Peru
3. Grand Canyon National Park ,Arizona
Issue No. : #97  JWOC 2024
Code Stack : HTML CSS and JAVASCRIPT
Close #97  JWOC 2024
SCREENSHOTS**************
PAGE 1  Santorini ,Aegean Sea

PAGE 2 Machu Picchu ,Peru

PAGE 3 Grand Canyon National Park ,Arizona

THIS PAGES ARE NOT OPTIMIZED FOR DIFFERENT SCREEN SIZES*************
Checklist:

[X] I have mentioned the issue number in my Pull Request.


get complete list of courseware in flexible pricing request

Pre-Flight checklist

[x] Testing

[ ] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
https://github.com/mitodl/mitxonline/issues/950
What's this PR do?
This is to fix the course/program filter implemented in https://github.com/mitodl/mitxonline/pull/965
On RC https://rc.mitxonline.mit.edu/staff-dashboard/flexible_pricing, it only displays one course in the dropdown, there should be 12 courses/programs there
It appears to only return the distinct course/program from https://rc.mitxonline.mit.edu/api/flexible_pricing/applications_admin/?l=3&o=0

The previous approach is also flawed as it's computing the DISTINCT course/program from the result of api/flexible_pricing/applications_admin/, in the frontend
This PR is to fix the dropdown "Search by Course/Program",  it should return a complete list of DISTINCT courses/programs from flexible pricing requests, with no limit.
How should this be manually tested?
Go to Flexible pricing from the staff dashboard: http://mitxonline.odl.local:8013/staff-dashboard/flexible_pricing
The dropdown "Search by Course/Program" should display a unique list of courses/programs from flexible pricing requests

It should filter out requests based on the selected course/program

@jkachel Good catch. I was testing my own requests and didn't realize the filter was limited to myself. I also added some sort of order by fields, just so that it doesn't return random order

Codecov Report

Merging #978 (1b11152) into main (2b7be89) will decrease coverage by 0.14%.
The diff coverage is 63.33%.

@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   84.56%   84.41%   -0.15%
==========================================
  Files         143      143
  Lines        6889     6919      +30
  Branches     1152     1157       +5
==========================================
+ Hits         5826     5841      +15
- Misses        864      877      +13
- Partials      199      201       +2

Impacted Files
Coverage Δ

flexiblepricing/serializers.py
85.00% <56.52%> (-11.50%)
:arrow_down:

flexiblepricing/views/v0/__init__.py
85.71% <83.33%> (-0.26%)
:arrow_down:

flexiblepricing/urls.py
100.00% <100.00%> (ø)

ecommerce/views/v0/__init__.py
89.61% <0.00%> (-0.87%)
:arrow_down:

ecommerce/models.py
88.69% <0.00%> (-0.60%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


In the post method when no data was passed means it doesn't show any field errors?

When I am passing without any fields on the post method, it doesn't show fields required message rather it shows one error as base object empty. I want all the field errors on that. Is that possible?

Apologies for the delayed response here. Can you provide an example? The error object comes from Joi, we just decorate it.


PHP 7.0: invalid numeric literal error due to invalid octal number

When you try to run composer install on a PHP 7.0.0 (stable) machine, you will get an error along the lines of
Parse error: Invalid numeric literal in /home/vagrant/git/math/tests/Moontoast/Math/BigNumberTest.php on line 622

Having a look at line 622, you'll see this:
$convertValues = array(10, 27, 39, 039, 0x5F, '10', '27', '39', '5F', '5f', '3XYZ', '3xyz', '5f$@');

and using Google for above error you immediately find PHP bug #70193 and there's this explanation:

Numbers starting with 0 are octal literals. 08 is not a valid octal literal, so you get an error now. Previously it was silently treated like 0.

which really makes sense.
Obviously, the problem is the "octal" (as interpreted by PHP) value 039 which is in fact not octal (9 isn't a valid octal digit). I changed 039 and -039 to 037 and -037, respectively, and now there are now more syntax errors and the tests pass.
I hope you didn't choose 039 because it might produce an unexpected result when converting bases and changing it to 037 doesn't somehow make it "easier" to pass the tests.
What do you think?
(Note: the "bump" commit was to trigger Travis CI)

@ramsey I just noticed Packagist points to your fork of this repo. Would like me to send a PR against your fork instead?

Yes, please. This repo is no longer maintained.

Closing in favor of https://github.com/ramsey/moontoast-math/pull/1


Pulling in @channemann big changes and DML links instead of images in intro/readme

Pulls in @channemann big edits and minor tweaks in addition from me.

I think this reverts all of Chris's changes.  You may need to pull master/dev and rebase...

  LGTM and good to merge.


[Bug] mysql ddl "on update current_timestamp" compatibility improvements

Search before asking

[X] I had searched in the issues and found no similar issues.

Java Version
all
Scala Version
2.11.x
StreamPark Version
all
Flink Version
all
deploy mode
None
What happened
Currently, there is a syntax "ON UPDATE CURRENT_TIMESTAMP" in StreamPark's MySQL DDL, This syntax is only supported starting from MySQL version 5.6.5. For users whose MySQL version is lower than 5.6, it will cause the execution ddl failed.
Error Exception
No response
Screenshots
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!(您是否要贡献这个PR?)

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'm willing to take on this issue, please assign it to me, thank you.


"tests all" command remove all configuration of Pixhawk

I'm using Pixhawk 2.1 ( Cube ) with 1.9.0(beta) firmware. I just wanted to test sensor with the nuttx shell "tests" command. However, I saw the option "tests all". Before I used the command, I configured whole sensors, airframe etc.. After used command whole setup configuration is went off. I have parameters backup but it's a real problem for someone who don't have.
Can someone test also this command and if it's only related to me?
Screenshots:
Before use 'tests all'

Using command

After use

I can reproduce this behavior on my Pixhawk cube as well.
@julianoes just pinging to let you know here the stale bot is on my opinion wrong.

I wonder if this is only on Cube or in general.

@davids5 FYI

I wonder if this is only on Cube or in general.
It seems general. Just tested on a Pixhawk3 Pro.

@bozkurthan @julianoes - the test all does a `tests parameters' and it is a destructive test on parameters.
nsh>  param show sys*
Symbols: x = used, + = saved, * = unsaved
x   SYS_AUTOCONFIG [508,1034] : 0
x + SYS_AUTOSTART [509,1035] : 4011
x   SYS_CAL_ACCEL [510,1037] : 0
x   SYS_CAL_BARO [511,1038] : 0
x   SYS_CAL_GYRO [512,1039] : 0
x   SYS_CAL_TDEL [513,1040] : 24
x   SYS_CAL_TMAX [514,1041] : 10
x   SYS_CAL_TMIN [515,1042] : 5
x   SYS_COMPANION [516,1043] : 0
x   SYS_FMU_TASK [517,1044] : 1
x   SYS_FORCE_F7DC [518,1045] : 0
x   SYS_HAS_BARO [519,1046] : 1
x   SYS_HAS_MAG [520,1047] : 1
x   SYS_HITL [521,1048] : 0
x   SYS_MC_EST_GROUP [522,1049] : 2
x   SYS_PARAM_VER [523,1050] : 1
x   SYS_RESTART_TYPE [524,1051] : 2
x   SYS_STCK_EN [525,1052] : 1
x   SYS_USE_IO [526,1053] : 1

 560/1285 parameters used.
nsh>  tests parameters
INFO  [tests] RUNNING TEST: ResetAll
INFO  [tests] TEST PASSED: ResetAll

INFO  [tests] RUNNING TEST: SimpleFind
INFO  [tests] TEST PASSED: SimpleFind

INFO  [tests] RUNNING TEST: ResetAll
INFO  [tests] TEST PASSED: ResetAll

INFO  [tests] RUNNING TEST: ResetAllExcludesOne
INFO  [tests] TEST PASSED: ResetAllExcludesOne

INFO  [tests] RUNNING TEST: ResetAllExcludesTwo
INFO  [tests] TEST PASSED: ResetAllExcludesTwo

INFO  [tests] RUNNING TEST: ResetAllExcludesBoundaryCheck
INFO  [tests] TEST PASSED: ResetAllExcludesBoundaryCheck

INFO  [tests] RUNNING TEST: ResetAllExcludesWildcard
INFO  [tests] TEST PASSED: ResetAllExcludesWildcard

INFO  [tests] RUNNING TEST: exportImport
INFO  [tests] TEST PASSED: exportImport

INFO  [tests] ALL TESTS PASSED
INFO  [tests]   Tests passed :      8
INFO  [tests]   Tests failed :      0
INFO  [tests]   Tested assertions : 42
INFO  [tests] TuneID: 14
parameters PASSED
nsh> INFO  [ekf2] Mag sensor ID changed to 396825
 param show sys*
Symbols: x = used, + = saved, * = unsaved
x   SYS_AUTOCONFIG [508,1034] : 0
x   SYS_AUTOSTART [509,1035] : 0
x   SYS_CAL_ACCEL [510,1037] : 0
x   SYS_CAL_BARO [511,1038] : 0
x   SYS_CAL_GYRO [512,1039] : 0
x   SYS_CAL_TDEL [513,1040] : 24
x   SYS_CAL_TMAX [514,1041] : 10
x   SYS_CAL_TMIN [515,1042] : 5
x   SYS_COMPANION [516,1043] : 0
x   SYS_FMU_TASK [517,1044] : 1
x   SYS_FORCE_F7DC [518,1045] : 0
x   SYS_HAS_BARO [519,1046] : 1
x   SYS_HAS_MAG [520,1047] : 1
x   SYS_HITL [521,1048] : 0
x   SYS_MC_EST_GROUP [522,1049] : 2
x   SYS_PARAM_VER [523,1050] : 1
x   SYS_RESTART_TYPE [524,1051] : 2
x   SYS_STCK_EN [525,1052] : 1
x   SYS_USE_IO [526,1053] : 1

 560/1285 parameters used.
nsh>

@hamishwillee - do we need a warning is the docs?

@davids5 could we restore the params after the test?

@julianoes we could and code size and exec time expenses. . But this is not a use case of the system as far as I know. @dagar may have an opinion.

We could split the destructive part into a standalone test that doesn't run by default. It could also print a huge warning about what's going to happen.


got script error on running applescript.

I got a script error when running the line "do shell script ..." of the applescript supplied in readme.
 *ERROR*: Wrong type argument: stringp, nil

How did you run the script?

I just installed emacsclient through brew cask and I found the same issue.
Here is my solution to better handle the case when no input is given:
on emacsclient(input)
	set cmd to "/Applications/Emacs.app/Contents/MacOS/bin-x86_64-10_9/emacsclient -n -c -a \"/Applications/Emacs.app/Contents/MacOS/Emacs\""
	if input is not equal to missing value then
		set cmd to cmd & " '" & input & "'"
	end if
	do shell script cmd
end emacsclient

on open location input
	emacsclient(input)
end open location

on open inputs
	repeat with raw_input in inputs
		set input to POSIX path of raw_input
		emacsclient(input)
	end repeat
end open

on run
	emacsclient(missing value)
end run

I think your EmacsClient is worth a specific GitHub to allow updating it and update its Brew Cask plugin w/o modifying Org-Capture-Extention. If you agree I can take care of it.

on emacsclient(input)
	do shell script "/Applications/Emacs.app/Contents/MacOS/bin-x86_64-10_9/emacsclient -n -c -a \"/Applications/Emacs.app/Contents/MacOS/Emacs\" " & input & ""
end emacsclient

delete the single quote before input and after input solved the issue

@captainmalloc: Thanks for your solution, which works for me.
I agree with you that "EmacsClient is worth a specific GitHub to allow updating it and update its Brew Cask plugin".
I think that path should better be /Applications/Emacs.app/Contents/MacOS/bin/emacsclient so that whenever, as now, Brew has superseded and removed bin-x86_64-10_9, EmacsClient.app can continue to work. Brew seems to maintain bin as a link to the appropriate current bin-$ARCH-$VERSION directory, resetting it each time it upgrades Emacs.app.


Basic support for mfem::Mesh

Fixes #160

I added a commit as an attempt to make the actions support being triggered from forks

Hm, the origin is wrong.. I first had github.event.repository.name which I thought should be /user/repo, but it only yielded repo unfortunately.. I removed .name just to try, but that gives a dictionary of course.. In principle this should work I think but I have to find out how to get the URL of the repo that triggered the wf


[SPARK-31761][SQL][3.0] cast integer to Long to avoid IntegerOverflow for IntegralDivide  operator

What changes were proposed in this pull request?
IntegralDivide operator returns Long DataType, so integer overflow case should be handled.
If the operands are of type Int it will be casted to Long
Why are the changes needed?
As IntegralDivide returns Long datatype, integer overflow should not happen
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT and also tested in the local cluster
After fix

SQL Test
After fix

Before Fix

cc @HyukjinKwon

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27689/
Test PASSed.

Looks good if tests pass. The conflict was minor and this PR is just to make sure the tests pass.

Test build #123050 has started for PR 28628 at commit 07b9b82.

Test build #123050 has finished for PR 28628 at commit 07b9b82.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123050/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27691/
Test PASSed.

Test build #123051 has started for PR 28628 at commit 07b9b82.

Test build #123051 has finished for PR 28628 at commit 07b9b82.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123051/
Test PASSed.

Thanks! Merged to branch-3.0.


Project funding sidebar update

Scope
https://ixo.atlassian.net/browse/WEB-1
Work Done
Sidebar on project funding pages
Steps to Test
http://localhost:3000/projects/did:ixo:SHd1eLeN2gg3eWnNXLSvw4/bonds/did:ixo:U7GK8p8rVhJMKhBVRCJJ8c/accounts
Screenshots

@aliangm So far so good. Navigation for Project > Funding seems perfect.
Would you also make the navigation for Investment > Dashboard?
You should work around src/common/Investment/Sidebar


Add .travis.yml config and badge.

Hey @gregjones, if you're okay with using Travis for CI, here's a PR that adds a good starting configuration and a badge to the README:

Ensure gofmted code.
Run go vet.
Run tests with race detector.
Run on 1.6 and tip, but tip is an allowed failure with fast finish on.

Feel free to close this PR if it's not helpful to you. This is related to https://github.com/gregjones/httpcache/issues/38#issuecomment-195017030.

Of course, if you do this, the status will be failing until #38 is resolved.

Thanks, very useful. I took the -s of the gofmt check because I didn't know it existed, and have never had my editor set to run it, but will probably revisit that at some point.


Script ignores index.* files

I did a basic installation, didn't change the config file, but saw that it should not list a directory if it has an index file in there, however that's not true in version 2.6.0 - directory is still getting listed completely ignoring an index file.

same here. A Link is created behind the directory, which opens the directory in a new window. However, when selecting the directory directly, the directory is listed. At least regarding to the comment, a click on the directory should bring me to the linked folder.

Documentation is wrong/unclear.

it depends on the theme, how directories with index files are handled. default theme adds a link at the end of the line to get to the directory directly
should be configurable


[Feature] Support Short-Time Fourier Transforms

Short-Time Fourier Transforms (STFT) and its inverse are used extensively in signal processing.
Function definition will match scipy:
https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.stft.html
https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.istft.html

You can assign this to me.

Cool.. if we include this, I wonder where it would go? I'm not opposed to including it in core or a sub-package but I think there is a decision to be made there.
I see jax implemented it in a scipy.signal subpackage https://jax.readthedocs.io/en/latest/_autosummary/jax.scipy.signal.stft.html, and PyTorch implemented it at the top level https://pytorch.org/docs/stable/generated/torch.stft.html
Also our Whisper implementation already has an STFT in MLX you might find useful: https://github.com/ml-explore/mlx-examples/blob/main/whisper/whisper/audio.py#L104-L127

I think adding them in core is best - they’re fundamental algorithms and used frequently.  A separate signal sub-package makes sense if you anticipate adding more functions from scipy.signal in he near future. (https://jax.readthedocs.io/en/latest/jax.scipy.html#module-jax.scipy.signal)
Thanks for pointing me to the Whisper implementation, I haven't seen in yet

One tiny issue about stft of mlx-example/whisper, the noverlap parameter does not actually represent the overlap of frames; instead, it is semantically equivalent to hop_length in torch.stft.
I found it a little bit misleading while implementing istft. @awni

Is it not the same as noverlap in the Scipy implementation? https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.stft.html
I think that's a good reference to follow.

Still working on this CL, shouldn't be much longer.
 t = (x.size - nperseg + noverlap) // noverlap does look wrong though, maybe that's where the confusion is. The denominator should be the number of steps.

Is it not the same as noverlap in the Scipy implementation? https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.stft.html
I think that's a good reference to follow.

No.
According to this hop_length = nperseg - noverlap
In stft in mlx-example/whisper noverlap is being used as hop_length. It appears to be a naming mistake, the logic looks good to me.

Still working on this CL, shouldn't be much longer.

Cool.
I was implementing a istft specific to my problem, not a general one.


Can I change the host of webContainer node server

I want to download some file by using nodejs in webContainer,but i have the CORS problem, Can I change the origin of nodejs

Please continue the discussion in #982.
As explained there, no it's not possible. The only way you can work around this is by setting up a proxy yourself (by using Cloudflare Workers or AWS Lambda Functions). Or by using the Allow Cors Chrome plugin.

Please continue the discussion in #982.
As explained there, no it's not possible. The only way you can work around this is by setting up a proxy yourself (by using Cloudflare Workers or AWS Lambda Functions). Or by using the Allow Cors Chrome plugin.

you mean i can startup a html server just like the image, but how i can make webcontainer to use my website and get the hash code


feat: Refactor Response class and add new initialization methods

Changes

Add default response status and status text in the Response constructors
Add Response.jsify method for initializing Response with a JS object as body
Separate Response.json method from Response.jsify for initializing Response with a JSON-encodable object as body
Add documentation for main the constructors of Response

Motivation
jsify is subject to minification and has somewhat bad performance. When using dart compile with minification enabled, the response json gets minified (after a certain depth AFAIK). It should not be the case. The new Response.json behaves simlarly from the previous implementation except that it doesn't minify as it uses json.encode. Renamed the previous implementation to Response.jsify as it could still be useful for some cases.

Well, as jsify can translate Dart objects to Js objects directly, people could still have some use. As it was the old behavior I figured I would leave it.

I'm not really familiar with the project, but it looks alright at a quick glance.
I'd still consider this a breaking change (since the "json" constructor changes).
And it'd be great to have some tests. But the project doesn't seem to have some atm, so that's alright I guess


Able to create a custom "NameConverter" in StrawberryConfig

Hi, I'm trying to create a new NameConverter like in the code below for maintain first underline and ignore capitalize when exists double underlines:
from strawberry.schema.name_converter import NameConverter

def custom_camel_case(value: str) -> str:
    # maintain first underline if exists to maintain readonly fields
    first = ""
    if value[0] == "_":
        first = "_"
        value = value[1:]

    # apply camel case in each block separated by double underlines
    blocks = value.split("__")
    for i, block in enumerate(blocks):
        components = block.split("_")
        blocks[i] = components[0] + "".join(
            x.capitalize() if x else "_" for x in components[1:]
        )

    # return first word with joined camel case blocks
    return first + "__".join(blocks)

class CustomNameConverter(NameConverter):
    def get_graphql_name(self, obj: HasGraphQLName) -> str:
        if obj.graphql_name is not None:
            return obj.graphql_name

        assert obj.python_name

        if self.auto_camel_case:
            return custom_camel_case(obj.python_name)

        return obj.python_name

The idea is to get the results below:

_id → _id
name → name
_id__like →_id__like
_created__gte → _created__gte
_created_at__gte → _createdAt__gte
_created_at__gte_hadouken → _createdAt__gteHadouken

But when I try to overwrite this parameter as per the code below I get an error:
from dataclasses import field

import strawberry
from strawberry.asgi import GraphQL
from strawberry.schema.config import StrawberryConfig

# ... rest of  "CustomNameConverter" code here ...

@strawberry.type
class Query:
    @strawberry.field
    def counter(self) -> int:
        return 1

config = StrawberryConfig()
config.name_converter = field(default_factory=NameConverter)

schema = strawberry.Schema(query=Query)

graphql_app = GraphQL(schema)

This is the error...

Does anyone have any idea what I need to do to get this method overwritten?

Hi @leandroluk, I think you have an error where you set the name converter instance, this:
config = StrawberryConfig()
config.name_converter = field(default_factory=NameConverter)

should become this:
config = StrawberryConfig()
config.name_converter = NameConverter()

or even this:
config = StrawberryConfig(name_converter=NameConverter())

@leandroluk I'll close this, let me know if you need more help :)


Standalone build don't work on different pc

Description
I recently encountered a strange issue. Initially, I developed a Unity project that utilizes the Mediapipe plugin. After completing the project, I built a version that worked fine on my PC. However, when I attempted to run it on a different PC, things didn't go as expected. The annotation points didn't appear on my face (which is recorded through the webcam). As a result, I decided to build the project on the new PC, where the previous build didn't work. When I opened the project, I encountered errors related to the asset loader type from the bootstrap component. To resolve these errors, I changed the asset loader type from "streaming assets" to "local." Then, I switched it back to "streaming assets" for the build. After fixing these errors, I successfully built and ran the project, it worked fine. Interestingly, I also rechecked the first build version from my old computer, and it somehow worked as well. For now, everything seems to be functioning correctly, but I would like to understand the cause of this issue and learn how to prevent it from occurring in the future.

I suspect that the necessary model files were not included in the initial build, but the information above is not enough to provide a conclusive answer.
If you'd like to specify the cause, please share the reproduction steps and the corresponding logs after confirming that the issue can be reproduced in your environment.

how can i add necessary models to build?


Panoptes does not show progress

It seems that Panoptes does not generate the sqlite database and thus did not record the progress of the workflow

Should be fixed in bgcflow_wrapper 0.3.3