Migrate json-rpc-engine library into core monorepo

As part of Shared Libraries Q3 OKRs, the team would like to migrate json-rpc-engine library ( https://github.com/MetaMask/json-rpc-engine) into core monorepo to make it easier to maintain.
See #1079 comment for instructions on accomplishing this.

Note that json-rpc-engine has a number of PRs pending from rekmarks that we'd like to preserve, but not before merging the repo. We should migrate those branches/PRs into core so that they aren't lost

Reopening since this isn't done yet!


Show default behavior of reader/writer in DateTime customization samples

Addresses https://github.com/dotnet/docs/pull/14056#discussion_r319259228.

I just noticed that this standard folder doesn't have a language identification which will make harder to enable CI tests later for this folder, if we wanted. Also, there's no obvious path if we want to add a VB counterpart.
Shouldn't this be added to the https://github.com/dotnet/samples/tree/master/snippets/csharp folder instead @rpetrusha @BillWagner?

I think the basic path is fine -- I don't think we want to primarily segregate code based on language, so that the corresponding examples in specific languages have completely different paths, But we do want to differentiate the language in the event that we have examples in multiple languages. So it seems to me that a good path is snippets/standard/datetime/json/custom-reading-with-utf8jsonreader/cs, as you suggested in the first paragraph of your comment, @mairaw.

That also means that we should move the existing examples to a cs directory.

Sounds good @rpetrusha. We don't currently test the snippets folder anyway. It seems we use csharp as the folder name whenever we have C# samples though.

I'm closing this PR because the target document for these samples already showcases the default behavior. This change is redundant: https://github.com/dotnet/samples/pull/1412#discussion_r321065206.
I'll open another PR adding a parent "cs" folder to the paths of all the samples for the Json-DateTime doc: https://github.com/dotnet/samples/pull/1412#issuecomment-528105208.


StructuralLM copy related work from layoutlmv2

Describe
Model I am using LayoutLM:
layoutlmv2 related work

structralLM related work

Both accepted by ACL2021， who copy who

https://arxiv.org/abs/2012.14740
https://arxiv.org/abs/2105.11210
Thanks for the question. My boy. Who copy who?
While, the most interesting part is that, Table 1 in StructuralLM copies the numbers of Table 1 in LayoutLMv2, but changes the name from UniLMv2 to RoBERTa.

changes the name from UniLMv2 to RoBERTa.

How do you feel about such bad plagiarism

changes the name from UniLMv2 to RoBERTa.

How do you feel about such bad plagiarism？ https://github.com/alibaba/AliceMind

I suggest you should post it on zhihu.com

changes the name from UniLMv2 to RoBERTa.

How do you feel about such bad plagiarism？ https://github.com/alibaba/AliceMind

I suggest you should post it on zhihu.com

那我要得罪很多人，圈子太小

Thank you for your interest in our work. StructuralLM and LayoutLM propose different solutions to the problem of visually-rich document modeling. The StructuralLM approach is original and distinct from LayoutLM in document types, model architectures and research findings. Our StructuralLM paper has properly cited the previous work of LayoutLM(v1), and referred to the baseline models used in the v1 paper, including the name RoBERTa. LayoutLM(v2) later replaced the baseline from RoBERTa to UniLMv2, which led to the discrepancy in the model names. As StructuralLM and LayoutLM both address the same research problem, which is an emerging topic with limited studies in the past, that results in the similarity in citations of the related work sections.
We sincerely appreciate the contribution of LayoutLM to this research field.

Thanks @lcl6679292 for the clarification! We have also fixed the typo which is mentioned in https://github.com/microsoft/unilm/issues/592.

very interesting

It's not clear how the cell-level embeddings are different from the word-level embeddings used in LayoutLM. Your paper doesn't talk about the specifics of generating the cell-level embeddings from the unstructured training data. Is it based on the x, y coordinates of the word-level bounding boxes being close enough to one another?
For example, a quote from your paper:

Therefore, we need to reprocess the scanned document images to obtain the layout information of cells. Like the pre processing method of LayoutLM, we similarly process the dataset by using Tesseract 1, which is an opensource OCR engine.

It seems like you are saying that you do the exact same thing as LayoutLM. Please help me understand what I am missing.


allow minor and patch Faraday versions

from faraday maintainer
I already try not to have feature changes between patch releases, only
bugfixes. That was the philosophy between all past 0.8.x releases.
When we're ready to release 1.0, then we'll know it is stable. Until
then, the patch releases will signify bug fixes and minor releases will
signify API upgrades, just like semver.

https://github.com/lostisland/faraday/issues/515#issuecomment-146046693
to lend credence, this PR is taking the same approach as faraday_middleware gem
https://github.com/lostisland/faraday_middleware/blob/master/faraday_middleware.gemspec#L16

Coverage remained the same at 95.858% when pulling 9facd36ac4df12de96d3c5f365577243de389c1a on mtyeh411:fix_faraday_version into 96daaf56765652a5ffc792f645f6b3a4a42ce9bb on intridea:master.


CodeChef Starters contest rating is showing in CodeChef long challenge graph

In the Contest rating graph, CodeChef starter contest are showing in long challenge

This is fixed and deployed. Please let us know if there is any further enhancement on this required.


Add prefix for OOTB application configs

As a developer, I'd like to add prefix to all the configurations associated with OOTB applications, so we will not run into naming collisions and facilitate persisting the entires in Spring Cloud Config.
Acceptance:

All the OOTB application configurations have prefixes such as log.sink, time.source etc.

This needs to be discussed further before we implement anything IMHO. Still need to clarify the need, and see how several instances of the same module are expected to be taken care of (e.g. the equivalent of transform --expression=x | transform --expression=y)

Those modules using port option complete blows up in CF as it's adding PORT env variable.

Depends on spring-cloud/spring-cloud-dataflow#432

spring-cloud/spring-cloud-dataflow#432 generally covers the overall filtering and whitelisting of application properties, so we may not need to explicitly also prefix app names to deploy them in the desired platform.


"Argument appears to not be a ReactComponent"issues

When i fallow docs and  run storybook the storybook throw error like title also i try copy your repo example deps and try again the result is same also i give an error "react-textarea-fit" module error do you have any recommendation of how can i solve this problem in my project

@batuhanbaybas  was you able to fix that?


Is it maintained?

Can it be updated for recent Tokio version and published on crates.io?

Would like to see this. UDS is very useful for cross-platform IPC since Windows now supports it, but it's a shame that mio/tokio don't support it on Windows out of the box yet


Don't recurse to children in ArrayData::validate_full

Which issue does this PR close?

Closes #.
Rationale for this change

There is no safe way to construct an invalid ArrayData, additionally there is no way to safely construct ArrayData that doesn't perform validation.
The result is that when building nested data structures, the same ArrayData will be validated multiple times unnecessarily. I think this is a footgun that is best removed, if people really want to recursively validate, it is easy enough for them to do so explicitly
What changes are included in this PR?

Are there any user-facing changes?

Perhaps footgun is the wrong word, it is a surprising performance hit that is impossible to workaround without using unsafe. Recursive validation isn't necessary for soundness, and just increases the likelihood that people reach for unsafe, with all its potential implications :sweat_smile:

Perhaps then an alternative might be to make ArrayData::try_new not recursively validate? Basically I want a safe API to construct an ArrayData that doesn't validate the ArrayData I have already safely constructed, and therefore validated

Perhaps then an alternative might be to make ArrayData::try_new not recursively validate? Basically I want a safe API to construct an ArrayData that doesn't validate the ArrayData I have already safely constructed, and therefore validated

I would be more comfortable with this (explicitly disabling recursive validation via ArrayData::try_new()) when we can clearly apply the argument that ArrayData is aways validated (either explicitly or via unsafe)

Edit Edit: Once https://github.com/apache/arrow-rs/pull/3247 is merged there is no use of unsafe in arrow-flight, arrow-csv or arrow-ipc aside from the flatbuffer generated code.

🎉

looks like a nice improvement


Google unsupported?

Describe the bug
["⛔ Error: Failed to get token - unsupported model provider: google"]
To Reproduce
.env
GOOGLE_API_KEY=XXXXXXXXXXX
trump.character.json
"name": "trump",
"clients": ["direct"],
"modelProvider": "google",
"settings": {
"secrets": {},
"voice": {
"model": "gemini-1.5-flash"
Expected behavior
"⛔ Error: Failed to get token - unsupported model provider: google"]
Additional context
Is Google supported??? Do I need to change anything else to make Google work?

make sure you're running the latest release
it's GOOGLE_GENERATIVE_AI_API_KEY


Agenda autoupdate problem

Add two new items: a hidden and a visible one.
Move the visilble item below the hidden one so that it becomes a child.
Now the visible one is shown as hidden, which is correct and expected.
Now QuickEdit the parent item and make it visible -> It is expected that all items are now marked as visible, but the second one itn't. Only reload helps.

@ostcar Any idea how we can trigger the auto update for all child items if item.type is changed?

There is another way to reproduce this error:
Create two normal items and one hidden items.
Make one normal item the child of the other normal item.
Then make the normal parent item a child of the hidden item

The problem is, that is_hidden is part of the rest api and is not calculated on the client.
If on a parent item the is_hidden flag changes then only the parent item is send to the client and therefore the child is not updated.
The solution is to create a method on the client then checks the flag from the rest api and also the flag on any parent element. Therefore the rest-api should be changed to return the value from the db and not the calculated value (because it has to be calculated on the client anyway).
@normanjaeckel could you change the server and @emanuelschuetze could you change the client?

@emanuelschuetze can fix the server and client in one step: For the server only remove 'is_hidden' from fields in agenda/serializers.py ItemSerializer meta class.

This should be solved with the new client. If otherwise, please reopen this issue.

I think this is still valid.

Cannot be reproduced anymore. Closing.


Rename Pulsar metadata config field

Renames the pulsar metadata config field metadataFields to metadata.fields to match the pattern of other config field names.
@navina
release-notes

adds metadata.fields configuration field to pulsar metadata ingest.

The test failure is not related to this PR so merging


Is there any update?

Hi, lizeyan! Is there any update on this project? I am really interested in this plugin since I am planning to update existing Zotero metadata and I found this repo. If there is any I  can help with, please let me in. :)

I just found doing this is much harder than I thought. I will finish this when I have time.
I cannot find a good database that contains all the fields, especially the official proceeding name, conference name, and series. I have tried DBLP and OpenAlex.

Have you ever used this tool? It contains a collection of many conference proceedings and most of them are from the deep learning field. I hope this may be an alternative one for the current time.

I create the first working version, but it is not fully tested. See https://github.com/lizeyan/Zotero-meta-update/tree/dev
I use CrossRef and DBLP now.
Welcome to contribute.


[release_table] Improve script for Debian

add an ignore_empty_releases to exclude empty releases (which are future releases for Debian),
improve logging,
add the YYYY-mm month_year date format.

Merging, only expected errors (apple).


Array.reduce initialValue allows incorrect array type to be supplied

Bug Report
When supplying an array to the initialValue argument of Array.reduce and specifying the type of that array as a multi type array (i.e Array.reduce<(string|number|boolean)[]>), it's possible to then supply an array typed to only one of those types to the initialValue argument (i.e string[]) without an error being raised.
🔎 Search Terms
typescript array reduce initial value bug
🕗 Version & Regression Information

This is the behaviour in every version I tried, and I reviewed the FAQ for entries about reduce

⏯ Playground Link
Playground example
💻 Code
type arrayTypes = string | number | boolean;

const arr = [1, 2, 'three', 'four', 'five', 6, true],
    store: string[] = [];

const result = arr.reduce<(arrayTypes)[]>((accum: (arrayTypes)[], value: arrayTypes):  (arrayTypes)[] => {

    accum.unshift(value);
    return accum;

}, store);

console.log(result); // [true, 6, "five", "four", "three", 2, 1]
console.log(store); // [true, 6, "five", "four", "three", 2, 1]
console.log(result === store); // true

🙁 Actual behavior
Allows an incorrect array type to be supplied to initialValue argument
🙂 Expected behavior
Supplying the incorrect array type to InitialState argument should raise a type error

This is working as intended.  Method parameters are intentionally bivariant, which leads to Array<T> being covariant in T; hence string[] is considered to be a subtype of (string | number | boolean)[].  This is unsound, but convenient.  Strict soundness is not a goal of TypeScript (see Non-Goal #3).   See this comment on #274 and this comment on #9825 for more information.


Inheriting constructors of isl::optional results in a compilation error on gcc 6.4 and lower

The following code fails to compile on gcc versions 6.4 and lower:
struct foo : nonstd::optional<int> {
    using nonstd::optional<int>::optional;
};

while it appears to work with gcc version 7.1 and above. The compilation error produced (with --std=c++14 GCC 6.4 on godbolt.org):
<source>:1704:34: error: 'template<class U> constexpr foo::foo(U&&)' inherited from 'nonstd::optional_lite::optional<int>'

     using nonstd::optional<int>::optional;

                                  ^~~~~~~~

<source>:1704:34: error: conflicts with version inherited from 'nonstd::optional_lite::optional<int>'

<source>:1704:34: error: 'template<class U> foo::foo(nonstd::optional_lite::optional<T>&&)' inherited from 'nonstd::optional_lite::optional<int>'

<source>:1704:34: error: conflicts with version inherited from 'nonstd::optional_lite::optional<int>'

<source>:1704:34: error: 'template<class U> foo::foo(const nonstd::optional_lite::optional<T>&)' inherited from 'nonstd::optional_lite::optional<int>'

<source>:1704:34: error: conflicts with version inherited from 'nonstd::optional_lite::optional<int>'

Compiler returned: 1

@improbable-nickkrempel believes it could be due to the change in inheriting constructor semantics
which resolves issue 1941. Switching the SFINAE method used from a default argument to a default template type does seem to resolve the issue. Is there any reason why optional_REQUIRES_A is used when using SFINAE with constructors instead of optional_REQUIRES_T, or could the method be switched in order to better support older GCC versions?

@improbablejan, started working on it...

@improbablejan, it looks like nonstd::optional<> can now be inherited from.
Thanks for your helpful suggestion.

Thanks for the quick turnaround!


Application using django-bitcoin is unaware of transaction fees

If a transaction fee is required from completing a transaction, it will get debited from the main wallet.dat account, and the user won't get informed. We need a way to raise an exception when a transaction fee from a transaction happens.

Now the transaction fee is deducted from the wallet. This is suboptimal solution, because wallet balance can go to negative that way. However, it is very minor issue in practice, and because it is impossible currently to calculate the fee beforehand, this won't fix for the time being.
(However, it is possible to patch your bitcoin client to not do the transaction if fees are added).


Simplify cardano-cli commands as much as possible

Commands like generate-txs have an insane number of options, and some seem to be for testing and benchmarking.
Normally, this command should be just generate-tx which generates a single tx. Generating multiple txs should probably be a separate command. Anything that is really only for benchmarking should be hidden for regular users.
I also wonder about things like (--byron-legacy | --bft | --praos | -mock-pbft | --real-pbft). Shouldn't these be extracted from the config file which is a separate command line parameter?

Look at this after the Shelley node CLI. I’d probably use the command name to present a simpler set of options (ie one codebase but different options depending on how the command is invoked)

This has progressed significantly. A new ticket can be created if necessary.


Idea: use webpack.DefinePlugin instead of context for meta

Just a thought here.
I've found that is much easier to use webpack.DefinePlugin to specify global variables than using react context.
Should we make this the default way people provide meta data? Or perhaps just add into the docs?
https://github.com/MoOx/phenomic/blob/master/themes/phenomic-theme-base/src/components/Header/index.js#L23
Wiring up react context for global information is (not too bad but) sometimes painful.
This was super easy:
  new webpack.DefinePlugin({
        'process.env': { TWITTER: 'awesomeTweets'}
   }),

{ process.env.TWITTER &&
          <a
            href={ `https://twitter.com/${process.env.TWITTER}` }
            className={ styles.link }
          >
            <Svg svg={ twitterSvg } cleanup />
              { "Twitter" }
          </a>
}

Just capturing my thoughts on this. =)

Just for reference. This is my refactor: https://github.com/serverless/site/commit/5932b6c85313e2ebc90bc8ae978ef9a407ffbdf3
With all global config stuff centralized: https://github.com/serverless/site/blob/5932b6c85313e2ebc90bc8ae978ef9a407ffbdf3/src/_config.js and then added to webpack.DefinePlugin https://github.com/serverless/site/commit/5932b6c85313e2ebc90bc8ae978ef9a407ffbdf3#diff-3fe40ded64ba5bb89dcae9266f8dc418R15

No sure if that's a good idea as it only make sense for "small" value, you can't use this for big values.
Anyway, context requirement might be replaced by a simple provider component in the future (with collection refactor)

Indeed. I actually need to use both in our site. Closing this =)


Readiness probe traffic currently identifies as unknown traffic, should be properly categorized.

Describe the feature request
Readiness-probe traffic currently identifies as unknown traffic, it should be properly categorized to avoid confusion with the actual unknown source traffic.
Deployment manifest
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    version: v2
    app:  frontend-nodejs-app
  name: frontend-nodejs-app-2
  namespace: istio-ssl-sample
spec:
  selector:
    matchLabels:
      app:  frontend-nodejs-app
      version: v2
  template:
    metadata:
      labels:
        app:  frontend-nodejs-app
        version: v2
      annotations:
        sidecar.istio.io/rewriteAppHTTPProbers: "false"
    spec:
      serviceAccountName: frontend-nodejs-app-sa
      containers:
        - name: frontend-app
          image: frontend-nodejs-app:v2
          imagePullPolicy: Always
          livenessProbe:
            httpGet:
              path: /ready
              port: 8443
              scheme: HTTPS
            initialDelaySeconds: 5
            periodSeconds: 10
            timeoutSeconds: 1
            successThreshold: 1
            failureThreshold: 5
          readinessProbe:
            httpGet:
              path: /ready
              port: 8443
              scheme: HTTPS
            initialDelaySeconds: 10
            periodSeconds: 10
            timeoutSeconds: 1
            successThreshold: 1
            failureThreshold: 3
          ports:
          - name: https
            containerPort: 8443
          volumeMounts:
            - name: certs
              mountPath: /home/node/app/certs/
              readOnly: true
          resources:
            requests:
              cpu: 50m
              memory: 90Mi
            limits:
              cpu: 50m
              memory: 90Mi
      volumes:
        - name: certs
          secret:
            secretName: ssl-certs

The main thing to notice using annotation: rewriteAppHTTPProbers.  Traffic coming for readinessProbe is shown as unkonwn in Kiali which is based on telemetry data. Also, the attached Kiali graph for reference.

Installed Istio version: 1.6.5
Describe alternatives you've considered
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[x] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Additional context

To help better track this issue, could you post some more details like version of Istio you installed and metrics you've seen. Thanks!

I have updated the issue with the needed information.

Why are you setting rewriteAppHTTPProbers? I think if you do not do that it would work as expected

Any more info?

This is expected without rewriteAppHTTPProbers. We have recommended + enabled by default for many releases now, so I don't think there is anything to do here?

This is expected without rewriteAppHTTPProbers. We have recommended + enabled by default for many releases now, so I don't think there is anything to do here?


os.popen('stty size', 'r').read().split()

Hello, in the 45th row of  DeepLung/nodcls/utils.py  : _, term_width = os.popen('stty size', 'r').read().split()。The version of my python is 3.6, the error will occur if it runs：ValueError: not enough values to unpack (expected 2, got 0). I try to print(os.popen('stty size', 'r').read())，but the output is 'stty' ����...Can you help me ? Many thanks.

How about using anaconda Python 2?

How about using anaconda Python 2?

My Python is 3.6. Many thanks for your reply. Best wishes.


feat(Page): add Page.wsEndpoint, for monitoring / debugging.

I'm using Puppeteer for parallel scraping in a personal project. I have one master connected to 25 Chrome instances running on separate worker machines, each of which might have multiple tabs open.
I've been using a hack that pokes into the private fields of Page and Session to get the equivalent of this PR, for monitoring purposes. I have a scheduler that keeps track of available pages, and assigns pages to tasks. When a task errors out, having the /devtools/page URL allows me to connect directly to the tab and see what happened.
I'm submitting this PR hoping that others will find the feature useful, and that I won't have to maintain my hack :smile:

@pwnall thank you Victor for the detailed explanation.
As per offline discussion, I'll close this for now. Hopefully, hopefully the newly introduced target.createCDPSession() should help.


MSSQL: Throw validation error if "ordered" is specified in createSequence/alterSequence

Description
SqlServer does not support an ordered/unordered clause in sequences and so Liquibase should throw a validation error if the user attempts to specify it in either createSequence or alterSequence.
https://docs.microsoft.com/en-us/sql/t-sql/statements/create-sequence-transact-sql?view=sql-server-ver15
Fixes #2528

I did not add an automated test because the change simply adds to the configuration of CreateSequenceGenerator and AlterSequenceGenerator vs. adding new logic. I'm working on a better way to be able to capture the configuration details in tests but do not have that ready, and this one-off check seems unuseful.

NOTE: For users who have ordered=false in their changelog currently, it will be a breaking change because their changelogs will now fail validation.
That seems expected because they are telling us they want to say they can be unordered, and we can't give that to them and should tell them that. It seems unlikely that people will be many people will be setting ordered=false in sqlserver.
It won't be a problem for mssql users who had ordered=true in their changelog, because previously that would have thrown a SQL exception and now it throws a validation exception. So it's not breaking something that worked before, it just gives a better error.

Manual Testing
Setup
Use next changelog:
    	<changeSet id="1" author="Liquibase" labels="setup">
    		<createSequence sequenceName="SETUP_SEQUENCE" startValue="1" incrementBy="1"/>
  	</changeSet>

	<changeSet id="2" author="Liquibase" labels="create">
    		<createSequence sequenceName="TEST_SEQUENCE" startValue="1" incrementBy="1" ordered="true" />
  	</changeSet>

	<changeSet id="3" author="Liquibase" labels="alter">
    		<alterSequence sequenceName="SETUP_SEQUENCE" ordered="true" />
  	</changeSet>

Run liquibase update --changelog-file changelog.xml --labels setup against MSSQL database
Test Cases
Verify update shows correct error message for createSequence tag with ordered attribute

liquibase --changelog-file changelog.xml --labels create
ordered is not allowed on mssql error message is shown

Verify update shows correct error message for alterSequence tag with ordered attribute

liquibase --changelog-file changelog.xml --labels alter
ordered is not allowed on mssql error message is shown

Test Results
Verify update shows correct error message for createSequence tag with ordered attribute. PASS
Unexpected error running Liquibase: Validation Failed:
     1 changes have validation failures
          ordered is not allowed on mssql, pr2549-changelog.xml::2::Liquibase

Verify update shows correct error message for alterSequence tag with ordered attribute. PASS
Unexpected error running Liquibase: Validation Failed:
     1 changes have validation failures
          ordered is not allowed on mssql, pr2549-changelog.xml::3::Liquibase

Liquibase version [Core: //mssql-no-ordered/1544/0e92b5/2022-02-16 22:00+0000, Pro: master/591/f653ec/2022-02-09T18:09:13Z] #1544


Endpoint for admin to retrieve all hazard types

@sosualfred Please can i have this task assigned to me


Update ReadMe with the FloodMap Repo Link

Hi,
is there a link to the map? can you help me locate it?


Remove short circuiting cached execution of transforms

This PR removes the short circuit code path where we avoided executing a transform via the BuildOperationExecutor if we knew already that it would be served from the in-memory cache. This was a change to reduce the overhead of the executor, but this approach does not work well with more complex inputs used for artifact transforms.

I really think we should find a way to avoid doing it this way. It's basically just a workaround to skip the cost of locking the executor. Anyway, that'll have to be a separate effort later. :(


Need clarity on behavior when updating dynamic queries for large licensing groups

It may take a significant amount of time for licensing groups with dynamic membership to update their memberships after a query change.  Depending on how the change is processed, and how long it takes to rebuild membership, this could result in a loss of license/service and bounced email for affected users.
How will updating dynamic user group queries will affect membership and licensing assuming that all current members will still be included in updated query results?
1. No effect – each current member evaluated separately to confirm membership/licensing and pre-existing members will retain their membership and licensing
2. Lost licensing - Membership and licensing cleared, then membership and licensing rebuilt; licenses could be lost for as long as it takes to evaluate all users in the tenant against the new membership query.
3. Something else entirely?

@ENT56,
Thanks for leveraging Azure docs feedback channel to raise this question. Could you please share the Azure documentation for which this feedback is applicable to?
--This channel is reserved for ‘Azure docs’ feedback- for sharing doc feedback and suggesting content improvements.

@ENT56 Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply and we will gladly continue the discussion.


Adding function apps for New E2E Test

Adding function apps to test end to end functionality of kafka extension with Confluent Cloud and Azure Eventhub for the following languages -

Dotnet(out-proc)
Dotnet(in-proc)
Java
Javascript
Typescript
Powershell
Python

Please fix the nit picks otherwise LGTM

LGTM, please add all the topic name in localsettings config that is

All the node in js apps should be in string datatype format currently all are in binary format

apps should be in string datatype format currently all are in binary format

This follows the default template. Also provides us the chance to test both string and binary formats.


Frequent mosquitto restarts cause test failures as systemd interferes

Describe the bug
We observe randomly failing test cases. These are caused by restarting mosquitto / connecting and disconnecting to c8y.
In the end we have a combination of system-tests that cause to many restarts in a specific time window.
To Reproduce
Restart mosquitto often :)
Expected behavior
Tests should not fail due to side-effects.
Screenshots
Test : log_request_error_messages
10:00:28 INFO    Error: failed to connect Cumulocity cloud.
10:00:28 INFO    Caused by:
10:00:28 INFO        Systemd returned unspecific error for service mosquitto while performing restart it.
10:00:28 INFO        Hint: Lacking permissions or service's process exited with error code. (restarting)

Note: Tedge only sees a generic one as error code. There is no log from mosquitto as systemd is causing the issue.
Additional context
Workaround is to disable the check in mosquittos service file (see links below). But we need a better solution.
Either reduce execution time or find a better Idea.
https://github.com/abelikt/thin-edge.io/blob/continuous_integration/ci/tweak.sh
https://github.com/abelikt/thin-edge.io/blob/continuous_integration/ci/mosquitto.service
AC:

Test-Prep script that checks for preconditions instead of restarting etc. directly.
If AC 1 is not possible share what is the situation and why it is not possible.

Timeboxed to 2

A workaround could be to ask systemd, the OS how long mosquitto is running and then decide how to continue

When pysys tests run locally on a PC without the tweaked service file, we observe even more issues. As the Tests will run faster on the PCs


[BUG] CPU Architectures naming is not consistent with OpenSearch plugins

Describe the bug
CPU architectures are named x86_64 and aarch64 in OpenSearch, where as rest of the plugins use x64 and arm64.
Also platform for MacOS has different naming conventions, OpenSearch/Dashboards use darwin and the plugins use macos.

[ ] CPU architecture - Done PR #612
[ ] MacOS Platform

Also the google trends show the latter are on the rise.

Merged the changes, closing.

Reopening this as we have another item to take care of.


python3Packages.vultr: 0.1.2 -> 1.0.1

Motivation for this change
Update to latest upstream release 1.0.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I guess that this update will break the Home Assistant tests.

Result of nixpkgs-review pr 125962 at aebd78e4 run on aarch64-linux 1

1 package failed to build:

home-assistant

2 packages built successfully:

python38Packages.vultr
python39Packages.vultr

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

I guess that this update will break the Home Assistant tests.

Yes - nixos x86_64:
AttributeError: <class 'vultr.vultr.Vultr'> does not have the attribute 'server_list'

That is still a problem with v2021.7.0.

Result of nixpkgs-review pr 125962 run on x86_64-linux 1

1 package failed to build:

home-assistant

2 packages built:

python38Packages.vultr
python39Packages.vultr


Update gem to use ActiveSupport >= 7.0

This PR updates this gem to support the latest ActiveSupport version v<IP_ADDRESS>
~In order to do this we need to fix a namespacing issue in Rails/ActiveSupport https://github.com/rails/rails/pull/47733~
~To demonstrate that the fix in the linked PR works, I created a proof-of-concept monkeypatching the ActiveSupport::TaggedLogging class with a local copy. I will update this PR to remove the monkey-patched version once the PR to Rails is merged.~
It turns out we "simply" need to load active_support to use the individual classes.

It turns out we "simply" need to load active_support to use the individual classes.

To clarify a bit, require "active_support" does not load everything. However it does set up autoloads for a number of "core" classes that are used in many of the individual components (like IsolatedExecutionState):
https://github.com/rails/rails/blob/355fd5929058ee3a73032c5f62de3d8819550482/activesupport/lib/active_support.rb

What are we gaining from this? Is the older version breaking something?

I'm not sure about the gemspec changes... adding require "active_support" is definitely the important part


Time Zone in Feeder

@jprante i know that metrics updates "$metrics.lastexecutionstart" and "$metrics.lastexecutionend" in UTC. But i hope there is an option to set the local time zone. Hence i updated timezone as "TimeZone.getDefault()" in below script. But it still writes the time in UTC.
Please let me know if i'm doing anything wrong or is there any workaround to write the timestamp into state file in other timezone (server timezone) instead of default UTC. Below is my statefile.
{
"type" : "jdbc",
"jdbc" : {
"password" : "test",
"elasticsearch" : {
"host" : "localhost",
"port" : "9300",
"cluster" : "testdeves"
},
"timezone" : "TimeZone.getDefault()",
"index" : "testindex",
"statefile" : "statefile.json",
"metrics" : {
"lastexecutionstart" : "2015-09-04T07:39:10.823Z",
"lastexecutionend" : "2015-09-04T07:51:52.468Z",
"counter" : "6",
"enabled" : "true"
},
"type" : "testtype",
"user" : "test",
"url" : "jdbc:sqlserver://localhost:1433;databaseName=xxx",
"sql" : [ {
"statement" : "SELECT id, last_modified FROM xxx.test where last_modified > ?",
"parameter" : [ "$lastexecutionend" ]
} ]
}
}

You have to use timezone IDs. Like
"timezone" : "America/Los_Angeles"

@jprante  i have tested with "timezone" : "GMT". But still no the same issue. could you please help me out.


About gather operator

I want to use torch.gather for NestedTensor, but report this error
RuntimeError: Could not run 'aten::gather' with arguments from the 'PrivateUse1' backend.
How can I solve it?

Hello @linyangsdu,
gather is currently not implemented. Could you post a snippet with your intended use so we can implement it?
Thanks,
Christian


fix(web): fix buttonGroups list-style-type fix #362

fix cosmetics #362

:tada: This PR is included in version 1.24.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


added basic e2e case for score core functionality

This test add some basic test cases for score core functionality command. Need to add more edge cases.

Closing it for now. This has been added to https://github.com/interlynk-io/sbomqs/pull/257.


0.6.4 is now repeating content sections within a loop

0.6.3 was running perfectly for my code. The item in the loop were iterated properly.
0.6.4 is now just dumping the same first item for every iteration.
all my code stayed the same. I just updated composer.
File: project_item.foil
<?php $this->section('itemsection')?>
<div class="job clearfix pitem" style="page-break-inside: avoid" id="<?=$this->v('project.htmlid','')?>">
	<div class="<?=$this->col1_css ?>">
    	    <?= $this->insert($this->v('itemlogosectionview','partials/itemlogo_psup')); ?>

	       <?php $this->section('projectyearsection')?>

        		<?=$this->v('project.year','')?>

    		<?php $this->replace()?>

    		<?php $this->section('projectfeessection')?>

        		<?=$this->v('project.fees')?>

    		<?php $this->replace()?>

<?php $this->replace() ?>

The foil above was called from File: body.foil
<?php foreach($this->majorProjects as $project):?>
	<?=$this->insert('partials/project_item',['project' => $project]) ?>
<?php endforeach; ?>

I suspect this change could be the reason,  src/Section/Section.php
[https://github.com/FoilPHP/Foil/compare/0.6.3...0.6.4]
if (empty($this->mode)) {
             $this->mode = self::MODE_REPLACE;
         }
-        $this->content = ob_get_clean();
+        $buffer = ob_get_clean();
+        $this->content or $this->content = $buffer;
+        $this->content = ($this->mode & self::MODE_APPEND) ? $buffer.$this->content : $this->content;
         if ($this->mode & self::MODE_OUTPUT) {
             echo $this->content();
         }

Please suggest. Thanks.

Hi @thevikas sorry to year that. I'll look at this as soon as I can, but will not be before next week.
I hope thta for now you can require 0.6.3 to avoid the issue.
Thanks for reporting.

Already changed back to prev version. :)

@thevikas your code is quite complex... and I can't understand where all these sections are defined.
You are requiring  project_item.foil in loop, and inside it replacing a section itemsection that I don't see defined anywhere.
Can you provide a Gist with (a semplified version of) the code you are suing so that I can easily reproduce the issue? Thanks.

@thevikas It seems I figured it out myself... and it was a simple fix.
I pushed to dev branch the fix. Can you please give it a try requiring Foil from dev-dev?
If it works for you this fix will be merged in v0.6.5.
Thanks.

just saw your messages. checked and your changes are keeping my views same. you can merge it. thanks a lot.

Happy to hear that, @thevikas
I am waiting for feedback on another open issue before releasing new version, so both fixes will be included.
Thanks for your interest and for reporting.

You are requiring project_item.foil in loop, and inside it replacing a section itemsection that I don't see defined anywhere.

how do you define sections?
i have refactored my complex views into many files with most sections in separate foil files.
that design is working for me except when sections are within loops. for that i have to work around.
then there are few other workarounds like overwritten sections are still called even though the last one is used. this can be fixed too.

@thevikas Well, normally, sections are not intented to be used like that.
The point of sections is to be able to be replaced / extended in a child template. If you have no child template, there's no reason to use sections at all.
Moreover, if you use the section in a loop, the ipotetical child template, which one should replace?
In short, you should not use sections in a loop. I don't see which is the benefit you want to gain from using sections there...
For example, imagine you gave a tample named projects.php, like this:

Projects

<?php $this->section('projects') ?>

<?php
foreach($this->v('projects ') as $project) {
  $this->insert( 'project', [ 'project' => $project ] );
}

<?php $this->stop() ?>

it requires in loop a partial named project.php that could be something like this:
<div id="<?= $this-v('project.id') ?>">

<?= $this-v('project.title') ?>

<?= $this-v('project.description') ?>

This works just fine without using sections.
If you use section inside the project.php template, those sections can't be replaced / extended anywhere, nor can replace / extend an already defined section, because parent template is not defining any section... so, which is the benefit to use section at all inside the partial?
On the contray, a child template can use projects.php (the one that contains the foreach) as layout by calling $this->layout('projects') and then edit projects section by adding more projects (extending the section with $this->append()) or completely replace projects by using $this->append().
This make sense, because adds flexibility to the template, but having sections in a loop, honestly is something that I can't find useful in any way.


Contributing: add instructions on wildcards in import statements

Clarifies the wildcard policy in Contributing.md.
Relates to #2875.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.12%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19549

Relevant Lines:
23519

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.12%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19549

Relevant Lines:
23519

💛  - Coveralls


Add Abyssal company

Abyssal is a Portuguese company whose main offices are located in Leça da Palmeira (Polo do Mar UPTEC).
I've added a new category because it didn't seem to fit in any of the others. Is that alright?

Hey @joaoportela,
Do you know whether this company is or not using Nodejs?

https://github.com/ftonato/nodejs-in-portugal

@ftonato I know that they are not using Nodejs. Thanks for asking.

Hi @joaoportela,
I have some mixed feelings about creating the "Subsea" category.
Isn't it too restrictive? Do you know other portuguese companies in that area?
I know that we already have a category with only one entry (Gaming).
But I really believed that more companies in that area would appear soon.
Do you believe it can fit in an existing category?
If not, can we create a broader one with more chances of having other companies?
What do you think?
Thanks.

I would propose 3 options:

Sea instead of sub sea to include over water tech

Example https://www.itjobs.pt/empresa/xsealence-sea-technologies

Drone since relates well to what Abyssal does

Example https://www.itjobs.pt/empresa/spin-works

Vehicles by abstracting "Automotive" into "Vehicles"

I agree with the change to sea. It would allow for the inclusion of more companies.
As for more companies for sea/subsea I would also suggest Oceanscan

Ok @joaoportela, lets change it to Sea and wait to see if other companies are added.
Feel free to add others or reach out to people working in similar companies. :)

Also, please don't forget to add the new category to the table of contents.

Thanks @joaoportela!


link Crystal from the release page

This can be merge now since it will only appear on index.ros.org after the job has been triggered manually.

Merging after considering @nuclearsandwich PR #60 as an approval of this patch :wink:


Fixed #25845 -- Fixed incorrect timezone warnings in custom admin templates.

Fixed false timezone warnings if a custom admin base.html template doesn't specify the "data-admin-utc-offset" body attribute.
Added Selenium tests for Firefox, Chrome and IE based on DateTimePickerShortcutsSeleniumFirefoxTests, as suggested by @timgraham in #5769.
https://code.djangoproject.com/ticket/25845

Please add a mention in docs/releases/1.9.1.txt too.

Just to be sure that I don't put nonsense in the release notes - would this be acceptable or should it include more details?
* Fixed incorrect timezone warnings in custom admin templates
  (:ticket:`25845`).

Also, should I squash my commits if I make further changes so that the pull request only contains one commit like now?

I would say "in custom admin templates that don't a data-... attribute in the body tag." Maybe the upgrade tip about adding it in custom templates could be mentioned in the 1.9 release too?
Yes, you can squash commits when updating.

I updated the PR with the discussed changes. The fix in DateTimeShortcuts.js is now way simpler. The check on if (body.getAttribute(...)) { ... } should be enough to reliably test if the body attribute is set:
"" ? true : false
false
null ? true : false
false
undefined ? true : false
false

"0" ? true : false
true

I removed the Selenium test and instead added another assert in the DateTimeShortcuts.test.js' init() test. I had problems getting the JS tests to run with grunt, but the test worked in the browser.

merged in 9af40f5df13801ffadcc5ded7440e4616123959f, thanks!


Add tests to cover sslPlugin enabled code paths in HttpBlobHandler

Those tests verify that custom ssl logic in HttpBlobHandler works
correctly if a plugin overwrites CrateNettyHttpServerTransport and
sets sslEnabled to true.

ack

[Current coverage][cc-pull] is 80.58%

Merging [#3531][cc-pull] into [master][cc-base-branch] will decrease coverage by 7.75%

@@             master      #3531   diff @@
==========================================
  Files          1169       1169
  Lines         39215      39247     +32
  Methods           0          0
  Messages          0          0
  Branches       6376       6352     -24
==========================================
- Hits          34641      31626   -3015
- Misses         4574       5294    +720
- Partials          0       2327   +2327

3 files (not in diff) in ...in/java/io/crate/udc were modified. more

Misses +4
Partials +5
Hits -9

2 files (not in diff) in ...icsearch/action/bulk were modified. more

Misses +7
Partials +24
Hits -31

1 files (not in diff) in ...elasticsearch/action were modified. more

Misses +12
Partials +16
Hits +26

1 files (not in diff) in ...va/org/elasticsearch were modified. more

Partials +7
Hits -7

2 files (not in diff) in ...io/crate/rest/action were modified. more

Misses +4
Partials +5
Hits -9

2 files (not in diff) in ...te/planner/statement were modified. more

Partials +6
Hits -6

12 files (not in diff) in ...e/planner/projection were modified. more

Misses +38
Partials +54
Hits -92

9 files (not in diff) in ...ate/planner/node/dql were modified. more

Misses +2
Partials +32
Hits -35

1 files (not in diff) in ...o/crate/planner/node were modified. more

Misses +1
Hits -1

3 files (not in diff) in .../crate/planner/fetch were modified. more

Misses +3
Partials +8
Hits -11

Powered by Codecov. Last updated by [31e0f7f...5e2ba3d][cc-compare]
[cc-base-branch]: https://codecov.io/gh/crate/crate/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/crate/crate/compare/31e0f7f447eaa006e756c20bd32346b2680ebee6...5e2ba3d8b9db97410f624b62efa407a9ca9d39c1
[cc-pull]: https://codecov.io/gh/crate/crate/pull/3531?src=pr

ack


Optimizer confusion, no documentation

I am working on a reinforcement learning crate (rl) and am using burn to implement a deep Q network example. I am trying to use the AdamW optimizer, but the documentation around using these optimizers directly is very unclear. I have read chapter 6 of the burn book, and have looked through the docs, but I am still confused as to why AdamWConfig::init() returns impl Optimizer instead of the actual AdamW struct. What is the purpose of these optimizer structs if the configs dont initialize them, and you can't manually construct one?
Overall really happy with the burn experience, and want to contribute at some point in the future, but I've noticed when I get into the weeds of a very custom use case, the documentation is unclear or missing.
In this case, I am forced to add another generic on my SnakeDQN struct and all implementations even though I know exactly which optimizer it will be using. I am not aware of a better workaround if I want to keep my current paradigm of holding initialized modules in the SnakeDQN struct.
pub struct SnakeDQN<'a, O: Optimizer<Model<B>, B>> {
    env: &'a mut GrassyField<FIELD_SIZE>,
    policy_net: Model<B>,
    target_net: Model<B>,
    memory: ReplayMemory<GrassyField<FIELD_SIZE>>,
    loss: HuberLoss<B>,
    optimizer: O,
    exploration: EpsilonGreedy,
    gamma: f32,
    tau: f32,
    lr: f32,
    episode: u32,
}

impl<'a, O> SnakeDQN<'a, O>
where
    O: Optimizer<Model<B>, B>,
{
    pub fn new(
        env: &'a mut GrassyField<FIELD_SIZE>,
        model_config: ModelConfig,
        loss_config: HuberLossConfig,
        optim_config: AdamWConfig,
        exploration: EpsilonGreedy,
    ) -> Self {
        Self {
            env,
            policy_net: model_config.init(&*DEVICE),
            target_net: model_config.init(&*DEVICE),
            memory: ReplayMemory::new(50000),
            loss: loss_config.init(&*DEVICE),
            optimizer: optim_config.init(),
            exploration,
            gamma: 0.86,
            tau: 2.7e-2,
            lr: 3.58e-3,
            episode: 0,
        }
    }
}

CC @laggui @nathanielsimard

Having another issue as well, am trying to implement the soft update of the target network in a deep Q learning environment, see pytorch equivalent:
pnsd, tnsd = self.policy_net.state_dict(), self.target_net.state_dict()

for key in pnsd:
  tnsd[key] = pnsd[key] * self.hp["tau"] + tnsd[key] * (1 - self.hp["tau"])

self.target_net.load_state_dict(tnsd)

I see that burn has the concepts of visitors and mappers, which seemed to be the best way to implement this. However, the documentation around visitors, mappers, and generally accessing the parameters of a model is either missing or very hard to find. Even this small section in the book is out of date with the trait definitions. There do not appear to be any examples of the intended way to use these traits either.
I feel like burn has tons of potential to be THE goto machine learning framework in rust, but the lack of clear documentation and examples is holding it back. I really think documenting existing code should be a higher priority than adding new features at this point, and would be happy to help if someone can answer my questions and clear this stuff up for me.

@benbaarber Thanks for the PR that made the optimizer concrete. Hope this solves your problem regarding holding an optimizer in your struct. Regarding the visitor and mapper, I think it's a very nice candidate for a new advanced section in the book. Adding more docs on the trait wouldn't be a bad idea either.
For your specific problem, I think you would need a mapper, similar to how our optimizers are actually implemented and update the model's parameters. See this mapper as a reference. Let me know if it helps, and don't hesitate to ask your questions on the Discord; we are a bit more responsive there!
Right now, we aren't really prioritizing more features, but rather improving performance. Feel free to open issues in areas where Burn would benefit from more documentation and examples; we may prioritize it!

@nathanielsimard Thanks for the response

For your specific problem, I think you would need a mapper, similar to how our optimizers are actually implemented and update the model's parameters. See this mapper as a reference.

This helps alot, thanks.

Right now, we aren't really prioritizing more features, but rather improving performance. Feel free to open issues in areas where Burn would benefit from more documentation and examples; we may prioritize it!

Sounds good. I understand the Visitor/Mapper paradigm a bit better now after looking around the codebase, though I think some really basic examples would go a long way with newcomers (like me) being able to quickly and easily use these features. The thing I was confused about at first was where to store the parameters after visiting them (which I will try to open a PR later today adding this as an example on either the trait or in the book or both). Then I was a bit confused about using Mapper to adjust the parameters of the target model as a function of itself and the policy model, which I will try to figure out today and will definitely ask in the discord if I'm lost there.
Thank you again for the help


Open daily note and templater don't go well together

I have a template for my daily note that has links to yesterday's and tomorrow's daily note in the header. I used templater like this:
[[<% tp.date.yesterday("YYYY-MM-DD") %>|< gestern]] | [[<% tp.date.tomorrow("YYYY-MM-DD") %>| morgen >]]
If I insert the template on a note, it works fine. If I use "Open daily note", it doesn't do anything. Why is that? What am I missing?

@ruben-sg in Templater, you need to enable this

Didn't see that. Thank you!


Change Gpio state judgement method

NXP's Board can't use the API Gpio.getValue,
if the gpio is used for output.
Signed-off-by: Jindong<EMAIL_ADDRESS>

Hi, I have already signed it, and my company's name is NXP. Please verify. Thanks.

I confirm the corporate CLA has been signed by NXP Semiconductors

This was fixed already, for all boards, in https://github.com/androidthings/sample-simplepio/commit/9c1147d4c34a155b10b6f35fa227bda992551c8a


Making interface widget closer to the one in Django Admin.

I have also updated the after.png image to reflect the new style for user interface


Can not debug Typescript files

I've been unable to debug any typescript files in my project https://github.com/TheGrandUser/Hexcrawl
The project was created using VS 2013 Update 3, with I think the then current Web Essentials. I simply added the ts files using the context menu in the solution explorer.
I had modified the .csproj file a little to try matching another project's that could debug ts files, but to no avail

Please try the latest 1.4 Release. closing the issue for now for the lack of activity.

This does appear to be fixed. Thanks


Add flag to parse user overrides for code words

I had to add the ability to get the mappings from a PhoneticConverter since that's where we define overrides and we also need the --dump- alphabet flag to display them accordingly.
Checklist

[x] Ran cargo xtask fixup for formatting and linting
[x] Modified all relevant documentation
[ ] Updated CHANGELOG.md per "Keep a Changelog" format
[ ] Added tests covering any code changes

I may want to try and normalize any override values to be capitalized...


fix(dependencies)

Updated version dependencies, added Kerberos to satisfy a dependency

@siteshackinc The build failed.

Mistakinly added a couple wrong versions, updated a few more with my next PR

@siteshackinc which dependency requires kerberos? Our builds have been passing so far and we haven't noticed any issues. Also, Angular 1.4 has some changes that we need to account for, so please do that in a separate PR.

npm WARN EPEERINVALID<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN EPEERINVALID<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN EPEERINVALID<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

@siteshackinc we already fixed some of these and a more current PR is open, so we're just going to close this one. Thanks for making the initial push!


Destiny 2 still appearing on my game library

Hi,
Destiny 2 still been show on my game library.
Best regards,

Hi, please report here: https://github.com/bartok765/galaxy_blizzard_plugin
This repo is not maintained anymore


Example code does not work

Hi, I tried the example code here
https://github.com/CollectionFS/Meteor-CollectionFS/tree/devel/packages/s3#client-server-and-s3-credentials
250 px width image copy gets saved, but not both
Any thoughts ?
if ( Meteor.isServer ) {
var avatarStoreLarge = new FS.Store.S3("avatarsLarge", {
  accessKeyId: Meteor.settings.AWSAccessKeyId,
  secretAccessKey: Meteor.settings.AWSSecretAccessKey,
  bucket: Meteor.settings.AWSBucket,
  transformWrite: function(fileObj, readStream, writeStream) {
    gm(readStream, fileObj.name()).resize('250', '250').stream().pipe(writeStream)
  }
})

var avatarStoreSmall = new FS.Store.S3("avatarsSmall", {
  accessKeyId: Meteor.settings.AWSAccessKeyId,
  secretAccessKey: Meteor.settings.AWSSecretAccessKey,
  bucket: Meteor.settings.AWSBucket,
  beforeWrite: function(fileObj) {
    fileObj.size(20, {store: "avatarStoreSmall", save: false});
  },
  transformWrite: function(fileObj, readStream, writeStream) {
    gm(readStream, fileObj.name()).resize('20', '20').stream().pipe(writeStream)
  }
})

Images = new FS.Collection("avatars", {
  stores: [avatarStoreSmall, avatarStoreLarge],
  filter: {
    allow: {
      contentTypes: ['image/*']
    }
  }
})

} else {
    var avatarStoreLarge = new FS.Store.S3("avatarsLarge");
    var avatarStoreSmall = new FS.Store.S3("avatarsSmall");

    Images = new FS.Collection("avatars", {
      stores: [avatarStoreSmall, avatarStoreLarge],
      filter: {
        allow: {
          contentTypes: ['image/*']
        }
      }
    })

}

Interesting observation
I insert the files from the console for testing as follows
var newFile = new FS.File();
newFile.attachData('https://crossorigin.me/http://www.wallpaperup.com/uploads/wallpapers/2014/01/25/237083/47b7ca5bd727bcda5c2dff4086f1a6d0.jpg', function (error) {
  if (error) throw error;
  newFile.name("newOne.png");newFile.metadata = {foo: "bar"};
  Images.insert(newFile, function (error, fileObj) {
    //If !error, we have inserted new doc with ID fileObj._id, and
    //remote URL data will be downloaded and stored on the server. The
    //URL must support a HEAD request since we do one to get the
    //content type, size, etc. for filtering inserts.
  });
});

Observation is, When I run this code multiple times, One image is created each time [ 2 should have been created ] but the image size toggles between the big and small everytime.. dont know exactly whats going on in here

Ok seems like the issue I had was I was using the same bucket, When you use different buckets, its all good.. Any thoughts how to fix this ?
I want to use one bucket and different folders

One other fix I'm running with right now
beforeWrite: function(fileObj) {
      return {
          name: 'different_name_1 '
      }
  },

For each instance I give a different name so then there are two file with different names


Modded multiplayer issues

Hello all... Im having troubles playing multiplayer with my brother on tmodloader, when i host all goes fine with friends but my brother goes slow motion at about 25-30 fps with frame skip off and subtle and lags with frame skip on  (in single player he runs the game fine and smoothly), we tried everything like changing the game priority, hosting with the console and host and play but nothing works. What should we do? thanks in advance.

For one, you should state your modlist. I am closing this because it is an issue in one of the mods you are playing, not tModLoader. See:


Bulk data imports

The ability to consume item data in bulk.
Like exports (#310), this functionality changes significantly with scale; it's easy to do a small dinky version of this but throwing significant bulk at it will have the potential to destabilise an app.
Also like exports, imports can be run at the app layer (ie. in node; requiring uploads, background workers, temp files, batching, etc.) or using DB-level tools.
Import functionality may form part of our upgrade strategy for KS4 apps; ie. import from a mongo instance (eg. users could provide connection details in the admin UI).

Import formats? Excel, JSON, CSV
Import from existing Keystone instance/MongoDB?
Specific access control for this or just use create permissions?

CSV/JSON import will  be a useful feature

@molomby did we conclude that stuff in #301 is stuff Keystone should do (or assist with), but bulk imports like this are not a Keystone concern?

We can use extension or custom action approach to have this. https://github.com/keystonejs/keystone-5/issues/1739


use new test config

Use new test config

blocked by qiime2/qiime2#782

@misialq, same thing as here: https://github.com/bokulich-lab/q2-assembly/pull/94#issuecomment-2256547672


Version mismatch between pom and release

While the currently released version is 1.4, the pom still hinges at 1.1-SNAPSHOT. These values should under all circumstances be identical.
Please update the version manually for once and include an automatic process of updating the version number into the release process.

@yegor256 please, pay attention to this issue

@semantosoph well, Maven recommends to keep SNAPSHOT version in the repository, while more stable versions get releases to Maven Central. We can't keep 1.4 in master branch, since we're changing it all the time. See https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN401

@yegor256 Mhm. Would still need to be 1.4-SNAPSHOT in pom, wouldn't it?

@semantosoph no, it has to be something from the future. In our case it has to be 2.0-SNAPSHOT. Let me fix it.

@semantosoph fixed in e4cd3e4d6

Fine. Working towards a new major version feels good anyway. :smile:

I can't do it for technical reasons, I'm very sorry. If you don't know what to do, submit this error as a ticket here:
0.15.2 96d4c0a 2017-07-30T06:58:34
java.io.IOException: java.lang.IllegalArgumentException: There are 1 parameter(s) but only 0 format argument(s) were provided.
	at org.cactoos.func.IoCheckedFunc.apply(IoCheckedFunc.java:74)
	at com.zerocracy.farm.SmartFarm.lambda$null$4(SmartFarm.java:137)
	at com.zerocracy.farm.StkSafe.process(StkSafe.java:89)
	at com.zerocracy.farm.reactive.Brigade.process(Brigade.java:103)
	at com.zerocracy.farm.reactive.Brigade.process(Brigade.java:82)
	at com.zerocracy.farm.reactive.FlushAction.process(FlushAction.java:85)
	at com.zerocracy.farm.reactive.FlushAction.exec(FlushAction.java:67)
	at com.zerocracy.farm.reactive.FlushAction.exec(FlushAction.java:35)
	at org.cactoos.func.FuncOf.lambda$new$3(FuncOf.java:88)
	at org.cactoos.func.FuncOf.apply(FuncOf.java:104)
	at org.cactoos.func.IoCheckedFunc.apply(IoCheckedFunc.java:66)
	at org.cactoos.func.UncheckedFunc.apply(UncheckedFunc.java:59)
	at org.cactoos.func.RunnableOf.run(RunnableOf.java:89)
	at com.jcabi.log.VerboseRunnable.run(VerboseRu...


Hugo version 2

In order for me to fork / put in suggestions as a PR, I think we need the hugo version on the mster branch.

Also, since this is so preliminary, you may want to just back up the hugo code, delete this repo, and start from scratch (so there's no jekyll baggage in the commit/branch history).

I'm testing out merge first. Indeed, we should probably start from scratch the repo.


Image not loading more than once per app session

Description
Image not loading from SourceProperty Binding in ContentView - Works fine on Xamarin.Forms.Image. The CachedImage is amazing, and is way faster than the stock one, but I need to know it will load all images just as well as Xamarin's.
I've set up the successCommand and it never gets hit, as well as retryCount > 500 with a retryDelay > 500, just goes strait to the ErrorPlaceholder. Like it's not even trying to pull from the url.
A particular image that's failing - https://media.wattswater.com/UPC/Image/098268238518.tif.jpg
I event set the source directly to the referenced url, instead of through a binding, and it still failed to load.
If I have an ErrorCommand set, it gets hit, and the args show a null reference exception with the following stack trace:
  at FFImageLoading.Cache.ReuseBitmapDrawableCache`1[TValue].ProcessRemoval (TValue value, System.Boolean evicted) [0x00030] in C:\projects\ffimageloading\source\FFImageLoading.Droid\Cache\ReuseBitmapDrawableCache.cs:235
  at FFImageLoading.Cache.ReuseBitmapDrawableCache`1[TValue].Remove (System.String key, System.Boolean evicted) [0x0005f] in C:\projects\ffimageloading\source\FFImageLoading.Droid\Cache\ReuseBitmapDrawableCache.cs:383
  at FFImageLoading.Cache.ReuseBitmapDrawableCache`1[TValue].Add (System.String key, TValue value) [0x00078] in C:\projects\ffimageloading\source\FFImageLoading.Droid\Cache\ReuseBitmapDrawableCache.cs:349
  at FFImageLoading.Cache.ImageCache`1[TValue].Add (System.String key, FFImageLoading.Work.ImageInformation imageInformation, TValue bitmap) [0x00059] in C:\projects\ffimageloading\source\FFImageLoading.Droid\Cache\ImageCache.cs:171
  at FFImageLoading.Work.ImageLoaderTask`3+<RunAsync>d__108[TDecoderContainer,TImageContainer,TImageView].MoveNext () [0x0056e] in C:\projects\ffimageloading\source\FFImageLoading.Common\Work\ImageLoaderTask.cs:564

On further testing, it looks like the image will load exactly once (anywhere on my app). I've got a 'recently viewed' section when I load up the app, and the image loads there fine. But it will not load any subsequent times during that application session.
If it's not in the recently viewed portion, then i'll see the image load successfully in the search results, but it'll then fail if I proceed to try to look at the item in the detail view. Then if I restart the app, it'll show properly in the recently viewed portion, but will no longer show up in search results, or in the item detail.
Steps to Reproduce
.... coming if I have time to make a repro.
Expected Behavior
Image loads
Actual Behavior
Image fails to load
Basic Information

Version with issue: 2.3.4
Last known good version: unknown
Platform: Android only - IOS seems fine.

Screenshots

Reproduction Link / Code
var carousel = new PanCardView.CarouselView()
            {
                ItemTemplate = new DataTemplate(() =>
                {
                    var img = new CachedImage() { VerticalOptions = LayoutOptions.FillAndExpand, HorizontalOptions = LayoutOptions.FillAndExpand, ErrorPlaceholder = "not_found.gif", RetryCount = 100, RetryDelay = 100 };
                    img.SetBinding(CachedImage.SourceProperty, "ImageUrl");
                    return new ContentView() { Content = img, HorizontalOptions = LayoutOptions.FillAndExpand, VerticalOptions = LayoutOptions.FillAndExpand };
                }),
                PanDelay = 0,
                IsAutoNavigating = false,
                IsCyclical = false
            };

Can you reproduce it with 2.3.5?

Yes, same behavior.

Are you sure? That bug was fixed, there's a null check there now. Please provide a new stack trace and check if you updated package in all projects.

Nope, you are correct. A full clean and rebuild did the trick. Thanks for the help!
And good work!


NBFNet Loading Issue.

          Hi! There is currently some bug in loading state dicts that contains `data.Graph`. For NBFNet, since these two attributes are static and can be computed from the dataset, you may just pop them from the state dict and load the rest of the state dict like

state = torch.load(checkpoint_file, map_location=solver.device)
state["model"].pop("graph")
state["model"].pop("fact_graph")
solver.model.load_state_dict(state["model"], strict=False)

Originally posted by @KiddoZhu in https://github.com/DeepGraphLearning/torchdrug/issues/89#issuecomment-1094501984

The error persists in the current iterations as well. I think this hack should be added to the documentation.

We updated this in the newest version of A*Net, which also includes a new implementation of NBFNet.


Why ActorDestroy and remove_all_actors() are both called in scenario classes?

Hi, Carla team!
I find that in most scenario classes, ActorDestroy method is used in the end of the scenario behavior sequence (_create_behavior).
I wonder if this is necessary because self.remove_all_actors() is always called in __del__().
Desktop (please complete the following information):

OS: [Ubuntu 16.04]
CARLA Version [CARLA 0.9.11]
Python version [3.5]
Version [0.9.11]

Hey @youngsend, we general methodology is to use the ActorDestroy for actors that end their behavior in weird places (such as bikes in the middle of the road). On the other side, the fact is that trying to remove an actor that is already dead doesn't create any issues (such a warning printout), so we also tend to add more ActorDestroy than necessary.

@glopezdiest, thank you for the explanation! I see.


The save's planetDefs.xml does not update to reflect changed in the config's planetDefs.xml

Version of Advanced Rocketry
AdvancedRocketry-1.12.2-1.4.0-84-universal
Have you verified this is an issue in the latest unstable build
N
Version of LibVulpes
LibVulpes-1.12.2-0.2.8-32-universal
Version of Minecraft
1.12.2
Description of the problem
There's a bit problem with Continuum right now where none of the AR planets have the right ores or artifacts. For some reason, the planetDefs.xml from the save is not being updated to match the one in the config, so there's no way for modpack makers to ever update the planets
Specifically, this is what an old save's planetDefs.xml looks right now:
 <planet name="Litherite" DIMID="30" customIcon="iceworld">
            <isKnown>false</isKnown>
            <fogColor>1.0,1.0,1.0</fogColor>
            <skyColor>0.533,0.509,1.0</skyColor>
            <gravitationalMultiplier>90</gravitationalMultiplier>
            <orbitalDistance>180</orbitalDistance>
            <orbitalPhi>270</orbitalPhi>
            <rotationalPeriod>54000</rotationalPeriod>
            <atmosphereDensity>50</atmosphereDensity>
            <biomeIds>advancedrocketry:crystalchasms</biomeIds>
            <oceanBlock>techreborn:techreborn_techreborn.potassium</oceanBlock>
            <fillerBlock>minecraft:snow</fillerBlock>
        </planet>

while this is what the config's looks like for the same planet
		<planet name="Litherite" DIMID="30" customIcon="iceworld">
			<isKnown>false</isKnown>
			<fogColor>1.0,1.0,1.0</fogColor>
			<skyColor>0.533,0.509,1.0</skyColor>
			<gravitationalMultiplier>90</gravitationalMultiplier>
			<orbitalDistance>180</orbitalDistance>
			<orbitalPhi>270</orbitalPhi>
			<rotationalPeriod>54000</rotationalPeriod>
			<atmosphereDensity>50</atmosphereDensity>
			<oreGen>
				<ore block="environmentaltech:litherite" minHeight="4" maxHeight="80" clumpSize="15" chancePerChunk="64" />
			</oreGen>
			<biomeIds>advancedrocketry:crystalchasms</biomeIds>
			<artifact>environmentaltech:structure_panel 0 64</artifact>
			<oceanBlock>techreborn:techreborn_techreborn.potassium</oceanBlock>
			<fillerBlock>minecraft:snow</fillerBlock>
		</planet>

This is from FTBTeam/FTB-Continuum/issues/218

is the config to B:resetPlanetsFromXML=false in the advancedRocketry.cfg set to true? that should reset the one from the world to match the config.

Oh wow, I had no idea there was a config setting for that. That's totally on us then, if that works. Thanks!

It apparently resets itself before the game even reaches the launch screen, so it doesn't affect saves in any way whatsoever.

It also puts it on the modpack player to change configs, instead of letting the modpack maker do it, which is also pretty bad for pack makers.

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


Additional fixes for uid fields in vcs_ entities

Description
Follow up to #511 . Missed a few places.
Type of change

[x] Bug fix

@tovbinm I didn't bump


fix styles

I am not sure if this the correct fix!
I changed the app.css with tailwind calls
@tailwind components;
@tailwind utilities;

and ran npm aging, and this seams to fix the issue

I think this issue happened now after this update
https://github.com/filamentphp/filament/pull/3712/files

Thanks for your PR. I also did some testing and refactoring so I merged the changes in #9


NoSuchMethodError: Class 'GeneratedColumn' has no instance method 'count'.

  Future<int> queryCount<T extends Table, D extends DataClass>({
    required TableInfo<T, D> tableInfo,
    required Expression<bool> whereExpr,
  }) async {
    final count = (tableInfo as dynamic).id.count();
    final sel = selectOnly(tableInfo);
    sel.where(whereExpr);
    sel.addColumns([count]);
    return (await sel.getSingle()).read(count) as int;
  }

E/flutter (14243): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: NoSuchMethodError: Class 'GeneratedColumn<int>' has no instance method 'count'.
E/flutter (14243): Receiver: Instance of 'GeneratedColumn<int>'
E/flutter (14243): Tried calling: count()

Most methods in the query builder are built with extensions. This is so that Expression<int> and Expression<String> can have different methods on them. Extension members are resolved statically though, and so if you cast to dynamic they won't be available.
If you want to be able to re-use some columns in different tables, the approach described in https://github.com/simolus3/drift/discussions/2866 may be a useful resource. But even without special setup, you can fix your code:
  Future<int> queryCount<T extends Table, D extends DataClass>({
    required TableInfo<T, D> tableInfo,
    required Expression<bool> whereExpr,
  }) async {
    final count = ((tableInfo as dynamic).id as Expression<int>).count();

Or, without any dynamic thanks to runtime schema introspection:
  final count = (tableInfo.columnsByName['id'] as Expression<int>).count();


Support using avro serializers outside of avro4k

Issue
We currently have a LocalDate field with the  LocalDateSerializer. Now if we use Json or any other decoder/encoder, it fails as the serializer is only accepting an avro encoder/decoder.
But the serializer itself is not using the avro methods, but only kotlinx methods like encodeInt or encodeLong.
Proposal
Only check the avro encoder/decoder if the serializer need it.

Released in v2.0.0


feat: add subscriber k8s fuzz test

Proposed changes
add fuzz test in /chaoscenter/graphql/server/pkg/k8s
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[x] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[ ] I have signed the commit for DCO to be passed.
[ ] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Can you check a build pipeline? @inpyu


push bouncer: Fix instructions in register_server.py.

See especially the second commit.

@rishig I think we might want to keep the second copy, not the first, so that we print out what we would send to the server before telling them to agree to the ToS.

updated!


navigation vim: lock fn layer

The documentation said the Fn layer should be locked : https://github.com/OneDeadKey/arsenik/blob/d433298231b9c6ca4ea7bacf41c2b3dbc23a14f1/README.md?plain=1#L147-L148
This PR fix the config to match the doc.

Good catch, although I believe the funpad works better as a layer-while-held. Most of the time, I just want to hit a single Fn key and having to manually leave the layer feels a bit cumbersome. It’s not like the numpad where you’re often staying for more than 2 keys. Maybe we should change the README instead?


Bubbles Toggle Inconsistent

I updated to the latest version a few days ago. I notices that the filter and bubbles objects had changed to a v2.
I have the bobbles toggle on my dashboard and I've noticed that the new toggle operates in an odd way.
e.g. The toggle is off on my dashboard. I press the button and the bubbles come on as expected. However, the icon on the dashboard changes to 'on' then a few second later turns to off. The bubbles on the spa are still on.
I then have a difference where the spa is using the bubbles, but the dashboard says they are off.
I sometimes have to press the toggle a couple of times to eventually get the spa to respond and turn off the bubbles.
Turning on the bubbles on the spa's control is also not showing as ON on the dashboard. This is an issue for me especially as I'd written an automation to turn off bubbles after 10 minutes. That's not recognising the button press, so doesn't trigger the timer.
I had no issues with the previous version, but this new one is proving inconsistent.
Anyone else seeing the same?

This started for me about a week ago. No updates were performed at the time, I was on v1.1.5
Updating to the latest release yesterday has not resolved the issue, neither has deleting the integration and entities and re-configuring.

One odd effect I've noticed - if I turn on the bubbles from my HA dashboard, then they activate and show as toggled on on the dashboard. However, when I toggle the bubbles off via the same dashboard, the FILTER icon switches off, then a second later, the bubbles also go off then immediately show as on again.
Has the filter and bubbles entities got mixed up somewhere?

I've just set up my Milan tub and noticed that the bubble state seems to be shown by the filter switch.
Steps to reproduce:

Start with all features off in HA and on tub.
Turn on bubbles from HA
Tub bubbles turn on, HA shows on briefly.
After about 1 second, bubbles toggle switches off in HA and filter toggle turns on. Tub stays in same state with bubbles on and filter off.

I'll try do some more testing of the various states and report back.

I turned the bubbles on this morning and ran into this issue, but 15 minutes later when I checked, the toggle was showing correctly. It also now seems to be updating in real time.
I wonder if the problem was an intermittent connection between the spa and cloud causing the delay in updating the value. I believe I have seen elsewhere someone mention that the bestway app can connect and control the spa locally? That would explain though why the app shows the correct state while this integration shows the issue.
It would also explain another issue where the toggle wasn't working for control either but was a short while later.
If it happens again, I'll try disabling wifi on my phone and using the bestway app to see if that also encounters the issue.

I don't know if it's related, but when I turn the tub off in HA, the filter/heat go off as expected, but when I turn it back on, it turns on the filter and the bubbles.
If I try to turn on and off the bubbles in HA, the bubbles turn off but so does the filter.

@craigmcfly could you clarify? You say "when I turn the tub off in HA", but I've only just added the main power switch to the code today, so what was it you were turning off/on?

Okay, so I have dug into this a bit deeper. The HA template creates a
master on/off toggle by default for your entire module on the dashboard,
which results in inconsistent behaviour (cos the individual toggles weren't
designed for that).
Once I deleted that toggle from the dashboard, all was well.
Sorry for the confusion
On Wed, 13 Sept 2023, 21:04 cdpuk, @.***> wrote:

@craigmcfly https://github.com/craigmcfly could you clarify? You say
"when I turn the tub off in HA", but I've only just added the main power
switch to the code today, so what was it you were turning off/on?
—
Reply to this email directly, view it on GitHub
https://github.com/cdpuk/ha-bestway/issues/32#issuecomment-1718244369,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF4TEALYSYJOCKLUO2W7SKLX2IGUBANCNFSM6AAAAAA2L56ELU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks. I have now found a couple of logic bugs that were probably causing the issues described above. These will be included in the next release.


[BUG] Question/possible bug?

What happened?

Basically my console is getting spammed with:
"[org.slf4j.impl.SimpleLogger:write:318]: [JDA Gateway-Worker 1]: WARN net.dv8tion.jda.internal.requests.WebSocketClient - Hit the WebSocket RateLimit! This can be caused by too many presence or voice status updates (connect/disconnect/mute/deaf). Regular: 1 Voice: 0 Chunking: 0"

Note the number for "Regular" started around 9000ish and has been decreasing over time. Once it hit 1 it has seemed to stop or at least slowed its rate
What should happen?

Not spam?

Steps to reproduce

Boot server with latest version
let run for some time

Version

[ ] 1.12
[X] 1.16

Platform

[X] Forge
[ ] Spigot

Mod version: dcintegration-2.1.0-1.16
Config file

https://pastebin.com/QnGpDxXf
REMOVE YOUR BOT TOKEN BEFORE UPLOADING!!!

Crash report if available (use https://hastebin.com)

No crash, log file is a little messy as it split into multiple files (servers been up for a day)
latest log: https://gist.github.com/YOYOK9/244538ad10b26fa176ebca631a33d683

Apologizes Hastebin refused to let me save the log..
Additional info
-This is more of a question towards if I should be worried about an output (spam) in mu servers console. Not 100% sure if its a bug

Did you enable Server Members Intent on your Bot's settings page?

Will give it a try, however have a newer issue now, but I think it is just a forge compatibility issue. Will try it in the next update though

Getting something similar and I have both intents on:
https://paste.srnyx.xyz/raw/uyodanefad


use wildfly-checkstyle-config 1.0.4 & checkstyle 6.7

Windows Build 1478 is now running using a merge of 9b425f3db35b035f43853abf2255b5e8d0427a4d

Linux Build 1925 is now running using a merge of 9b425f3db35b035f43853abf2255b5e8d0427a4d

Core - Full Integration Build 1065 is now running using a merge of 9b425f3db35b035f43853abf2255b5e8d0427a4d

Windows Build 1478 outcome was SUCCESS using a merge of 9b425f3db35b035f43853abf2255b5e8d0427a4d
Summary: Tests passed: 3122, ignored: 71 Build time: 0:21:26

Linux Build 1925 outcome was SUCCESS using a merge of 9b425f3db35b035f43853abf2255b5e8d0427a4d
Summary: Tests passed: 3122, ignored: 71 Build time: 0:23:08

Core - Full Integration Build 1065 outcome was SUCCESS using a merge of d52172b991eec3fadadd8429d258fef9d534a825
Summary: Tests passed: 2872, ignored: 375, muted: 1 Build time: 0:51:44

Core - Full Integration Build 1066 is now running using a merge of d52172b991eec3fadadd8429d258fef9d534a825

Linux Build 1926 is now running using a merge of d52172b991eec3fadadd8429d258fef9d534a825

Windows Build 1479 is now running using a merge of d52172b991eec3fadadd8429d258fef9d534a825

Windows Build 1479 outcome was SUCCESS using a merge of d52172b991eec3fadadd8429d258fef9d534a825
Summary: Tests passed: 3122, ignored: 71 Build time: 0:21:36

Linux Build 1926 outcome was SUCCESS using a merge of d52172b991eec3fadadd8429d258fef9d534a825
Summary: Tests passed: 3122, ignored: 71 Build time: 0:23:25

Core - Full Integration Build 1066 outcome was SUCCESS using a merge of d52172b991eec3fadadd8429d258fef9d534a825
Summary: Tests passed: 2872, ignored: 375, muted: 1 Build time: 0:49:39

Core - Full Integration Build 1107 is now running using a merge of 698e99ac411936e3f1284e717fb30c93d9d42fbf

Windows Build 1517 is now running using a merge of 698e99ac411936e3f1284e717fb30c93d9d42fbf

Linux Build 1967 is now running using a merge of 698e99ac411936e3f1284e717fb30c93d9d42fbf

Windows Build 1517 outcome was SUCCESS using a merge of 698e99ac411936e3f1284e717fb30c93d9d42fbf
Summary: Tests passed: 3207, ignored: 71 Build time: 0:23:03

Linux Build 1967 outcome was SUCCESS using a merge of 698e99ac411936e3f1284e717fb30c93d9d42fbf
Summary: Tests passed: 3207, ignored: 71 Build time: 0:25:55

Core - Full Integration Build 1107 outcome was SUCCESS using a merge of 698e99ac411936e3f1284e717fb30c93d9d42fbf
Summary: Tests passed: 2877, ignored: 377, muted: 1 Build time: 0:49:38


 I think if you made a new branch, rebased the branch on upstream, and cherry picked your commits. Then force pushed it into master, you would have done it successfully, restoring lost history, for the benefit of mankind.
Benefits:

Due credit to the 35+ developers that spent a combined 6000+ hours to make this port possible.
It's easier to maintain your port, rebasing on upstream, or cherrypicking commits later
It's easier to fork your port, lets say by someone who wants to port it to another console.
It's easier to study your source to learn from it.
Quite sad to delete history, even if it was by accident.

Also:

Restore credit to the 35+ developers that spent a combined 6000+ hours to make this port possible.

It's the little things that counts :)

It appears that the branching point was https://github.com/diasurgical/devilutionX/commit/e6f4e216319a7f9b867092d777691a79550c9e22, some this commit there are only 62+/702- lines of difference to f21751373d43afb542dc4580e882c123cdbe5715 (the original commit in this repo).
Most of the changes consist of stripping the code from the network layer. This can be done less invasively by referencing this commit instead: https://github.com/diasurgical/devilutionX/commit/c998dfdbfb4aff6dd221b5b0838d019605982747

I have now rebased the devilution-nx fork on upstream master here in this PR: https://github.com/diasurgical/devilutionX/pull/181
Not that several outstanding issues still have to be addressed before the code is ready for merge upstream, but at least it is now clear what has been changed, and this brings some fixes to the Nintendo Switch code.

The port has now been fully upstreamed, here are some of the fixes that has been made:

All code now matches the original Diablo (fixing a few in game bugs)
Fix save game compatibility
All builds are now automatically compiled for the switch via CircleCI
Fix zooming in the minimap for some keyboards
Correct directional sounds
Fix multiplayer bug
Fix crash in town with some compilers
Correct crash when exiting menu
Error messages implemented in GUI
Much lower CPU usage
Unlocked FPS (vsync instead of 20)
Many bug fixes in the controller implementation
More responsive controller
Highlight both primary and secondary target
Improved spell targeting when using a controller

@lantus please change this repo into a propper GitHub fork so that we can get credit and easily merge future improments.
(Automatic widescreen support is just around the corner)

We have enow release 1.1.0 upstream, this includes widescreen support which looks pretty great on the Switch I'm told :)
https://github.com/diasurgical/devilutionX/releases


Question about panic 'send on closed channel'

At one project we hit the problem with message in logs:
panic: send on closed channel
ee-app          |
ee-app          | goroutine 25 [running]:
ee-app          | github.com/spiral/broadcast.(*Router).Dispatch(0xc000317580, 0xc00030ec60)
ee-app          | 	/go/pkg/mod/github.com/spiral/broadcast@v0.0.0-20191206140608-766959683e74/router.go:45 +0x219
ee-app          | github.com/spiral/broadcast-ws.newPool.func1(0xc00031ff50)
ee-app          | 	/go/pkg/mod/github.com/spiral/broadcast-ws@v1.1.2/conn_pool.go:34 +0xa3
ee-app          | created by github.com/spiral/broadcast-ws.newPool
ee-app          | 	/go/pkg/mod/github.com/spiral/broadcast-ws@v1.1.2/conn_pool.go:31 +0xea

Also in logs it was detected records about disconnections:
ee-app          | DEBU[0080] [ws] <IP_ADDRESS>:44406 websocket: close 1001 (going away)
ee-app          | DEBU[0080] [ws] <IP_ADDRESS>:44406 disconnected

Could you describe what should be fixe for correct work in this case?

github.com/spiral/broadcast-ws v1.1.2 used

github.com/spiral/broadcast-ws v1.1.2 used