Finer graph locks

Add finer-grained locking for aufs
benchmark                       old ns/op       new ns/op     delta
BenchmarkConcurrentAccess-8<PHONE_NUMBER>8     26834747      -99.74%

benchmark                       old allocs     new allocs     delta
BenchmarkConcurrentAccess-8     309948         7232           -97.67%

benchmark                       old bytes     new bytes     delta
BenchmarkConcurrentAccess-8     23943576      1578441       -93.41%

Job: Docker-PRs-WoW-TP4 FAILED:

---
2T16:05:56Z" level=error msg="hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0"
ERROR:  hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0
INFO: End of cleanup
INFO: Ended at Fri Feb 12 16:05:56 CUT 2016 (1m 14s)
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe D:\temp\hudson5621591934427263090.sh
+ set +e
+ set +x
INFO: Nuking /d/CI
time="2016-02-12T16:06:02Z" level=error msg="hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0"
ERROR:  hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0
INFO: End of clean
---

I like that you added a test/benchmark before going at it.

@cpuguy83 btw you can use benchcmp for beauty benchmark reports comparison :)

Was wondering with what magic people did that. Thanks!

@cpuguy83 are you going to do the same for the rest of the drivers? I think all of them have the same problem.

@calavera That was my plan, though I have to admit for some reason now I'm not getting those numbers I posted above (which I originally ran multiple times), so looking into it.

Closing this until I can fix it, found an issue.

Ok, this is updated, see the updated bench numbers

wow LGTM

Job: Docker-PRs-WoW-TP4 FAILED:

---
	      56	docker-1.11.0-dev.exe.md5
  0%
100%
	    New File  		      88	docker-1.11.0-dev.exe.sha256
  0%
100%
	    New File  		  27.1 m	docker.exe
  0.0%
  3.6%
  7.3%
 11.0%
 14.7%
 18.3%
 22.0%
 25.7%
 29.4%
 33.0%
 36.7%
 40.4%
 44.1%
 47.7%
 51.4%
 55.1%
 58.8%
 62.5%
 66.1%
 69.8%
 73.5%
 77.2%
 80.8%
 84.5%
 88.2%
 91.9%
 95.5%
 99.2%
100%

------------------------------------------------------------------------------

               Total    Copied   Skipped  Mismatch    FAILED    Extras
    Dirs :         1         0         1         0         0         0
   Files :         4         4         0         0         0         0
   Bytes :   54.39 m   54.39 m         0         0         0         0
   Times :   0:00:00   0:00:00                       0:00:00   0:00:00

   Speed :<PHONE_NUMBER> Bytes/sec.
   Speed :            67994.475 MegaBytes/min.
   Ended : Saturday, February 13, 2016 12:57:04 AM

+ ec=0
+ set +x
INFO: Linking the built binary to /d/CI/CI-7a
---

Maybe another issue: I think the Clean method need a read lock.
https://github.com/cpuguy83/docker/blob/finer_graph_locks/daemon/graphdriver/aufs/aufs.go#L486

Job: Docker-PRs-WoW-TP4 FAILED:

---
	      56	docker-1.11.0-dev.exe.md5
  0%
100%
	    New File  		      88	docker-1.11.0-dev.exe.sha256
  0%
100%
	    New File  		  27.1 m	docker.exe
  0.0%
  3.6%
  7.3%
 11.0%
 14.7%
 18.4%
 22.1%
 25.7%
 29.4%
 33.1%
 36.8%
 40.5%
 44.2%
 47.9%
 51.5%
 55.2%
 58.9%
 62.6%
 66.3%
 70.0%
 73.7%
 77.3%
 81.0%
 84.7%
 88.4%
 92.1%
 95.8%
 99.5%
100%

------------------------------------------------------------------------------

               Total    Copied   Skipped  Mismatch    FAILED    Extras
    Dirs :         1         0         1         0         0         0
   Files :         4         4         0         0         0         0
   Bytes :   54.27 m   54.27 m         0         0         0         0
   Times :   0:00:00   0:00:00                       0:00:00   0:00:00

   Speed :<PHONE_NUMBER> Bytes/sec.
   Speed :            65125.364 MegaBytes/min.
   Ended : Wednesday, February 17, 2016 2:39:33 AM

+ ec=0
+ set +x
INFO: Linking the built binary to /d/CI/CI-72
---

Thanks @sillyousu
Although this probably won't ever be called but by a single goroutine and only while it has exclussive access to the graphdriver, I agree it should have a lock.
I've added one, but I'm not sure it is the best solution since it is technically feasible for other operations to be mounting things while Cleanup is trying to unmount... but again I don't think the engine can even call things these in parallel.

please, rebase those two commits, they go together :wink:

PS: LGTM when we have a single commit.

@calavera The last two?

Ok, I've moved this into two commits. 1 for fixing some of the issues with aufs, the other to add the id-based locking.

@cpuguy83 it's ok for me. but don't you think that per-object lock will solve issue in more performant way(no allocations on first lock etc.)?

I kinda liked the commit with the bench only. I can't get it to actually run on the first commit.
Is the auplink error message an actual error? I'm getting that running the bench.
Here's what I use to get results on the second commit:
λ TESTFLAGS='-bench=. -cpu 2,4,8 -benchtime 10s' TESTDIRS='daemon/graphdriver/aufs/' make test-unit

results
BenchmarkConcurrentAccess  	time="2016-02-25T21:48:38Z" level=error msg="Couldn't run auplink before unmount /tmp/aufs-tests/aufs/mnt/c775c928309c3b7f49caecc92323a21508b707e6390d775812e5b356b8e49d53: exit status 22"
      10<PHONE_NUMBER> ns/op
BenchmarkConcurrentAccess-2	      20	 812425911 ns/op
BenchmarkConcurrentAccess-4	      10<PHONE_NUMBER> ns/op
BenchmarkConcurrentAccess-8	      10<PHONE_NUMBER> ns/op
coverage: 80.1% of statements
ok  	github.com/docker/docker/daemon/graphdriver/aufs	114.734s

Updated per @LK4D4's suggestion and posted new bench results.

@MHBauer What's the issue getting it to run on the first commit?

Cool
LGTM

@cpuguy83 It seems to hang. Maybe it's just taking a long time.

@MHBauer It does create a lot of contention, but still finishes pretty fast on mine system... are you on an SSD?

ssd but in a vm. OSX-> docker-machine/virtualbox. Maybe I should set up a dev-vm someday.
I'm certainly not saying anything is wrong. I want to run it. I am curious.

@MHBauer I'd prefer to make sure there is nothing wrong, also you have my same setup :)

Well, just to be clear, the f310141 commit works great. No problems with that. Tests run and finish.
I'm only talking about 55c91f2. It compiles and then aufs.test goes to sleep.

hehe :) that's really weird.

Ok, I'm merging, it seems ok.


ADF SDK change for AUX 5.1 (sprint 45)

Can one of the admins verify this patch?

Hi @jackmagic313, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (jikma). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci add to whitelist


Class Doc for PHP

Added an option to specify a jsdocs_author setting and have it shown on
the Class DocBlock @author tag. Added an option to parse the
class/interface name and populate the @package and @subpackage tags.

Hi @JavierParra
you can explainme how i can use your develop ?
Thanks


it is hard for me to customise the image or title of menu! please help!

I'll do it in next version.

@JJJJJJJerk  Done in new version.


AN-364: Download both variants of solc compiler during build

As per Slack, HardHat first attempts to download the linux-amd64 compiler. This always fails to execute, which causes HardHat to always fall back to the solc JS/WASM variant, which is platform and CPU agnostic and does execute. This is also the case in v0.2.2.
The main bug, apart from the Alpine incompatibility, is that the process of downloading solc js sometimes results in a corrupt file. I always start from a clean state (docker system prune -f --all) when running these builds, but sometimes builds fail continuously. I think a corrupt copy of the compiler is being cached by Amazon CloudFront.
The fault is intermittent: this commit for the 10th of November, for instance, sometimes succeeds and sometimes fails for me.
v0.2.2 so far has not failed once, I've built it on a loop more than 30x.
The contents of this PR download both compilers and manifests, expecting HardHat to always fall back to the platform agnostic compiler. This has been built > 20x now and hasn't failed.
This will also fix a scenario where HardHat can't download the compiler due to a proxy server.
@Siegrift does not believe the e2e tests issue is related.

@Siegrift does not believe the e2e tests issue is related.

Siegrift knows :)


Unknown atom type 79

hi tring to generate optimal molecules for a particular target but got "Unknown atom type 79"
help, please
from torchdrug import core, models, tasks, utils

model = models.RGCN(input_dim=dataset.node_feature_dim,
                   hidden_dims=[256, 256, 256, 256,256,256,256],num_relation=dataset.num_bond_type,
                   short_cut=True, batch_norm=True, concat_hidden=True)

task = tasks.GCPNGeneration(model, dataset.atom_types,
                            max_edge_unroll=12, max_node=38,
                            task="plogp", criterion="ppo",
                            reward_temperature=1,
                            agent_update_interval=3, gamma=0.9)
optizer = optim.Adam(task.parameters(), lr=1e-5)
solver = core.Engine(task, dataset, None, None, optimizer,
                     gpus=(0,), batch_size=16, log_interval=10)
_________________________________________________________here is the error
solver.train(num_epoch=10)

~/anaconda3/envs/torchDrug/lib/python3.8/site-packages/torchdrug/data/molecule.py in is_valid(self)
    533         if torch.isnan(max_atom_valence).any():
    534             index = torch.isnan(max_atom_valence).nonzero()[0]
--> 535             raise ValueError("Fail to check valence. Unknown atom type %d" % self.atom_type[index])
    536
    537         is_valid = self.explicit_valence <= max_atom_valence

ValueError: Fail to check valence. Unknown atom type 79

Hi! This is because we use a simple tensor-based valence check routine to accelerate the computation. We didn't cover rare atoms like the 79-th atom. Could you point out where this error is located at in the stack?


Android.view.InflateException: Binary XML file line #46 in :layout/listheader_opensource:

About this issue
I am continuously getting  Android.view.InflateException: Binary XML file line #46 in :layout/listheader_opensource on runtime although my project includes
implementation "com.google.android.material:material:1.0.0"
Exception
android.view.InflateException: Binary XML file line #46 in
:layout/listheader_opensource:
Binary XML file line #46 in :layout/listheader_opensource: Error inflating class com.google.android.material.button.MaterialButton
Caused by: android.view.InflateException:
Binary XML file line #46 in :layout/listheader_opensource: Error inflating class com.google.android.material.button.MaterialButton

Please try material 1.1.0. Also make sure your activity uses the material theme as parent

setting the activity theme to this solved the issue
<EMAIL_ADDRESS>


Add License to project

The project doesn't have a license specified. This makes using this package difficult as it means "that you retain all rights to your source code and no one may reproduce, distribute, or create derivative works from your work" (source). You can use GitHub's license choosing tool at choosealicense.com to decide on a license. The license terms can be added to a LICENSE.txt file, and updated in setup.py.
I'd be happy to send a PR to add these if you already know what license you'd prefer to use (I would recommend MIT license, same as similar projects like QCoDeS)

You're absolutely right and I agree about going with the MIT license. @crmcrae would the copyright be under your name?


Android Studio Open iOS module in xcode does not work with flavors

Steps to Reproduce

Create dev and prod flavors
Open Android Studio and right click iOS module
Select Flutter -> Open iOS module in xcode.

Expected results: xcode opend
Actual results: Error
flutter --no-color build ios --simulator
Building com.flutter.example.prod for simulator (ios)...

The Xcode project defines schemes: dev, prod
You must specify a --flavor option to select one of them.
Encountered error while building for simulator.
Process finished with exit code 1

Logs

[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.14.6 18G2022, locale en-NZ)
    • Flutter version 1.12.13+hotfix.8 at /Users/jayhuang/Development/flutter/sdk
    • Framework revision 0b8abb4724 (3 weeks ago), 2020-02-11 11:44:36 -0800
    • Engine revision e1e6ced81d
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/jayhuang/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/jayhuang/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.2.1, Build version 11B500
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 43.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (2 available)
    • SM J730F         • 5200ad94f49d7449                         • android-arm • Android 9 (API 28)
    • Pengfei's iPhone • 0c8b971747f4a965baa677b4e23b29b6136a6dba • ios         • iOS 13.1.3

• No issues found!

Hi @PandaGeek1024
does it run from terminal?
(example: flutter build ios --flavor production lib/main_production.dart --verbose)
Thank you

For some reason, upgrade to 3.6.1 and restart fix the issue. will try a while and see if it is fully fixed.

Hi @PandaGeek1024
given your last message I feel safe to close this issue,
if you disagree please write in the comments and I will reopen it.
Thank you


Make all add-ons CommonJS importable

Make all add-ons importable with CommonJS. Both of the following coding snippets should work:
Example for the attach add-on
var attach = require('./addons/attach');

or
var attach = require('./addons/attach/attach');

This PR closes #52.

LGTM 🐻


HBASE-28657 Backport HBASE-28246 Expose region cached size over JMX m…

…etrics and report in the RS UI (#5565)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.6 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 26s
branch-2.6 passed

+1 :green_heart:
compile
3m 16s
branch-2.6 passed

+1 :green_heart:
checkstyle
0m 56s
branch-2.6 passed

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 12s
branch-2.6 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 44s
the patch passed

+1 :green_heart:
compile
3m 13s
the patch passed

+1 :green_heart:
javac
3m 13s
the patch passed

+1 :green_heart:
checkstyle
0m 55s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m 12s
Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

33m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5983/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5983

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 541501b8e07c 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.6 / ba15d67a35

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5983/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.6 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 42s
branch-2.6 passed

+1 :green_heart:
compile
1m  1s
branch-2.6 passed

+1 :green_heart:
shadedjars
5m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
branch-2.6 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 19s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

+1 :green_heart:
shadedjars
5m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 25s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
0m 23s
hbase-hadoop2-compat in the patch passed.

+1 :green_heart:
unit
210m 52s
hbase-server in the patch passed.

236m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5983/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5983

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 968f52839773 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.6 / ba15d67a35

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5983/1/testReport/

Max. process+thread count
4269 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5983/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.6 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  7s
branch-2.6 passed

+1 :green_heart:
compile
1m  9s
branch-2.6 passed

+1 :green_heart:
shadedjars
5m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
branch-2.6 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 49s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
5m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 28s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
0m 28s
hbase-hadoop2-compat in the patch passed.

+1 :green_heart:
unit
225m  4s
hbase-server in the patch passed.

254m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5983/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5983

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7580ebe5f8b1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.6 / ba15d67a35

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5983/1/testReport/

Max. process+thread count
4230 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5983/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[FLINK-9895][tests] Ensure error logging for NettyLeakDetectionResource

What is the purpose of the change
This PR is a small addition to #6363 to ensure that ERROR logging is enabled for Nettys ResourceLeakDetector, as otherwise the the leak will not cause test failures.
Verifying this change

disable error logging in flink-runtime for ResourceLeakDetector. (see log4j-test.properties)
disable auto-release in FileUploadHandler
run FileUploadHandlerTest

+1


Two prompts have been found

When I set up the snippet, I found that there were two same options in the prompt.

In the figure above, I set btn, txt, ui, vc, and they all have become two options.

@htoooth are these snippets bound to a language ?

Yes, I set all these snippets to JavaScript.

@tahabasri


TS type compatibilty

I created default angular application and added the following code to app.component
import { Schema } from '@orbit/data';
import Store from '@orbit/store';

const schemaDefinition = {
  models: {
    planet: {
      attributes: {
        name: { type: 'string' },
        classification: { type: 'string' }
      },
      relationships: {
        moons: { type: 'hasMany', model: 'moon', inverse: 'planet' }
      }
    },
    moon: {
      attributes: {
        name: { type: 'string' }
      },
      relationships: {
        planet: { type: 'hasOne', model: 'planet', inverse: 'moons' }
      }
    }
  }
};

const schema = new Schema(schemaDefinition);

it seems it works as a js code, however, as a TypeScript it produces the following error referring to a relationship type
...
Types of property 'type' are incompatible.
                    Type 'string' is not assignable to type '"hasMany" | "hasOne"'.

Is that a bug or it is expected that it should be used another way?

What version of TS are you using? Can you please provide a small sample repo I can check out?

@dgeb
tsc --version
Version 2.4.2

Everything: latest.
I just created default app with angular cli and added some your sample code to app.component.ts
It seems to work up until I uncomment relationships here and here.
PS
What I'm trying to create is a simple demo app for this JSON API server (a few simple resources, toOne/hasMany/manyToMany relationships, sorting, filtering, pagination is supported, OAuth). If anyone has an interest I would be very happy to accept any help.

@dgeb As I said earlier in parallel I try orbit.js in JS and have a bigger success with describing schemas and adding models. When I read the documentation I think I got it, however, when I try to connect the test to a real local JSON API server I got some issues with a ConnectionStrategy::_generateListener where target appears to be undefined.
Could you please have a look at the code and say what's wrong with it?

@dgeb I've fixed the issue with the relationship type. Though I'm struggling to make orbit.js work with JSON API backend. Could you please give a link to working sample in JS/TS?

@neomerx for future readers, can you clarify the TS issue you had above?
I'll check out your example soon. One thing to be aware of is the need to return data using the JSONAPI Content-Type. See https://github.com/orbitjs/orbit/issues/453
Here's an example that uses ember-orbit together with a JSONAPI backend - https://github.com/cerebris/peeps-ember-orbit
This app relies on this Rails backend app.
I plan to publish some simpler, non-ember-specific examples soon.

I added TS types and I was surprised it worked fine with attributes but not with relationships.
Before
const schemaDefinition = {
  models: {
    planet: {
      attributes: { ...},
      ...
    }
  }
};

After
const modelDefinitions: Dict<ModelDefinition> = {
  planet: {
    attributes: { ...  },
    relationships: { ...  }
  },
};

const schemaDefinition: SchemaSettings = {
  models: modelDefinitions
};

I am so new to TS that I can't even say who's to blame :smile: Though as a software developer this behaviour and compiler error looks odd.
The way I found the solution? I checked your tests for this functionality! Definitely recommended for future readers :wink:
#453 I not the case here. I most likely have some very basic issue with configuration. As far as I can see in a browser the problem occurs before sending any requests to the server.
Thanks for the app link. My app already works with ember.js and I'm looking at orbit.js as promising diversification option. So angular/vue/etc users can use JSON API backends.

I found how to deal with the original issue. Though I would much appreciate a working example of interaction with a JSON API server.

Hi @neomerx, I saw your now defunct repo angular-orbitjs-poc and would be highly interested to hear how your tests went. I'm in the very same boat right now, as I want to use OrbitJS for JSON-API support in an Angular application. There's also JSData, but Orbit just comes with so much more and follows the Ember brilliancy. 🤗
Did you investigate options for Orbit in combination with RxJS or even ngrx?

@mblackritter I was waiting for some feedback from @dgeb for a month or two and tried to make a working sample while improving my TS and JS skills. Unfortunately, I wasn't able to make it work with orbit. So I removed the repo.
As @dgeb

I plan to publish some simpler, non-ember-specific examples soon.

we have some hope

having just bumped into this, here's what's going on (for future readers).
In TypeScript, when you create an object literal like this
const x = { type: 'hasOne' };

the type of x is regarded as
{ type: string }

In most situations, it would be quite annoying if we got another result. Once we move on from this statement where x is declared and initialized, the type of x has been established.
Now, if we pass x into a function -- for example, the Schema constructor
new Schema(x);

TypeScript is going to determine if the type of the variable provided
{ type: string }

is type equivalent to what the function wants as an argument
{ type: 'hasOne' | 'hasMany' }

is type-equivalent to the value provided
In this situation, the answer is NO. Schema( ... ) doesn't want type to be just any string -- it can only be one of few specific strings ("hasOne" or "hasMany"). We have found that string is a narrower type than 'hasOne' | 'hasMany'.
There are two ways to fix this.
1) We can cast our values to the narrower string literal types that Schema() is looking for
const x = { type: 'hasOne' as 'hasOne' };

You may have heard that type casting is something you should strive to avoid. This is one case where it's perfectly fine. It's clear to any reader that you just want this value to be regarded as something more specific than a string. We are not weakening the type-safety of our code in any way by doing this.
2) You can pass your object literal directly into the function, without creating a variable for it
new Schema({ type: 'hasOne' });

In skipping the stop of creating a variable, we skip the step where our 'hasMany' value is regarded as a string -- we go straight to checking whether our value 'hasMany' is type-equivalent to 'hasMany' | 'hasOne' (which it is).

@neomerx for future readers, can you clarify the TS issue you had above?

As you can see the Schema takes  SchemaSettings or undefined, so assigning SchemaSettings
type to SchemaDefinition satisfies the TS compiler.  Here is the updated code snippet,
import { Schema, SchemaSettings } from "@orbit/data";
import Store from "@orbit/store";

const schemaDefinition: SchemaSettings = {
  models: {
    planet: {
      attributes: {
        name: { type: "string" },
        classification: { type: "string" }
      },
      relationships: {
        moons: { type: "hasMany", model: "moon", inverse: "planet" }
      }
    },
    moon: {
      attributes: {
        name: { type: "string" }
      },
      relationships: {
        planet: { type: "hasOne", model: "planet", inverse: "moons" }
      }
    }
  }
};

const schema = new Schema(schemaDefinition);
const store = new Store({ schema });


Increase font size, enlarge the form, increase space around paragraphs

New default font size = 18px.

In the end, we don't enlarge the form.


Border around image not looking used with transparent images

The border around the random avatar image is not needed on any full square images, and looks really bad when used with transparent icons or, for example, Discord emoji. See how it looks when using transparent images:

The border is a default from foundry. I can add an option to remove it.

Thank you. That's more than enough.


Factory/Library: Deterministic contract addresses

In UniswapV2Factory and UniswapV2Library, we use the CREATE2 opcode in Ethereum by carefully selecting a unique salt value in order to have a deterministic contract address for each (factory, token0, token1) combination.
Can we do the same in Soroban?
Can we implement the UniswapV2Library's pairFor function?

Check https://discord.com/channels/897514728459468821/1114313260653613168/1117846612446818485

https://discord.com/channels/897514728459468821/1052278452130152488/1052288429158830090

https://discord.com/channels/897514728459468821/966788672164855829/1095122556471746643

The contract ID is the SHA256 hash of the HashIDPreImage xdr union (https://github.com/stellar/stellar-xdr/blob/eab1622f18b8101aa0cea76361c08beaeaa8d715/Stellar-transaction.x#L629). If you can build the right *CONTRACT_ID* case then you'll be able to pre-compute.
Btw the WASM hash is not used to calculate contract IDs.

Solved with https://github.com/paltalabs/deterministic-address-soroban


Changes to list view config registry not picked up after Tomcat restart

After Tomcat restart, changes to the list view config registry are not picked up (even though the file is in everytime)

Moved to VIVO project JIRA.


[✨] Update the Qwik Library starter

Is your feature request related to a problem?
Following up on #5097
Describe the solution you'd like
We need to update the starter vite.config.ts and add
dts({
	// ...
	entryRoot: 'src'
})

and also
build: {
  // ...
  rollupOptions: {
    output: {
        preserveModules: true,
        preserveModulesRoot: 'packages/kit-headless/src',
      },
  }
}

Describe alternatives you've considered
not relevant
Additional context
I think we should implement this fix only after we fix https://github.com/BuilderIO/qwik/issues/5473

I agree, we should wait until #5473 is fixed before doing this. I'd currently rather have the "big" bundle rather than the namespace issues preserveModules creates.

Is it still valid?


Can't find a elegant way to define a multi instanciated component

Hi Oskca,
First of all, many thanks for this very nice and convenient GopherJS extension on VueJS.
I'm struggling with proper Component definition in order to define a component wich can be instanciated many time within a html page
I've finally wrote this working code :
const (
	TemplateCounter = `

			 Like

		{{cnt}}

`
)

// CounterComp GopherJs Code
type CounterComp struct {
	*js.Object
	Cnt int `js:"cnt"`
}

func NewCounterComp() *CounterComp {
	cc := &CounterComp{
		Object: js.Global.Get("Object").New(),
	}
	cc.Cnt = 0
	return cc
}

func (cc *CounterComp) Inc() {
	cc.Cnt++
}

// RegisterCompteurComp registers to current vue intance a counter component having the following profile
//  <counter color="some_color_name"></counter>
func RegisterCompteurComp() *vue.Component {
	o := vue.NewOption()
	o.Template = TemplateCounter

	//o.Data = func() interface{} {
	//	return NewCounterComp()
	//}
	// which is equivalent to following
	//o.Set("data", NewCounterComp)
	// and also equivalent to following (kept because shorter)
	o.Data = NewCounterComp

	o.AddMethod("Inc", func(vm *vue.ViewModel, args []*js.Object) {
		vm.Data.Set("cnt", vm.Data.Get("cnt").Int()+1)
	})

	o.AddProp("color")

	return o.NewComponent().Register("counter")
}

This code works ok (it enables multiple counter component intances to work side to side, with a specific value in each occurence), but It does not please me :
As o.SetDataWithMethods(NewMessageComp) ( nor  o.SetDataWithMethods(NewMessageComp())) does not seem to work in this case (method "Inc" is not defined on JS side), is there a way to use the actual method assocatied with the Go type, instead of having to "rewrite" the logic in a (Gopher)JS way ?
As a turn around, I used the o.AddMethod... stuff, but it is frustrating for me as it does not reuse the func (cc *CounterComp) Inc() method from CounterComp Go type.
Any hint (or even better, a more comprehensive exemple for component) would be really appreciated
Best Regards
Laurent

Having a second look at GopherJS wiki (https://github.com/gopherjs/gopherjs/wiki/JavaScript-Tips-and-Gotchas#tips), I found out kind of a solution :
Here is the reworked version of func RegisterCounterComp :
`// RegisterCounterComp registers to current vue intance a counter component having the following profile
//
func RegisterCounterComp() *vue.Component {
o := vue.NewOption()
o.Template = TemplateCounter
o.Data = NewCounterComp
o.AddMethod("Inc", func(vm *vue.ViewModel, args []*js.Object) {
	(&CounterComp{Object:vm.Data}).Inc()
})
//o.AddMethod("Inc", wrapMethod((*CounterComp).Inc))

o.AddProp("color")

return o.NewComponent().Register("counter")

}
`
This doesn't map directly the exported method of Go Type CounterComp, but at least it enables to reuse the Inc() method.


Hiding the Feedback button

Description

I'd like to know if there's a way to hide the "No, Send Feedback" button in the dialog

Device information

Android OS version: 8.0.0
Compile SDK version: <IP_ADDRESS>
Build tools version: 27.0.3
Any other relevant information:

Steps to reproduce:

Open dialog using RateMyAppDialog.showAlways

Hello again @ahabbaba9,
Only way of doing this would be to extend RateMyAppDialog with your own implementation of it, override onCreateView() and create a new showAlways() method that works exactly the same but starts your dialog instead of ours.
Thanks,
Elvis


Add a Unit Test for litmus ansible plugin actionable.py

FEATURE REQUEST
What happened:
The litmus ansible plugin actionable.py needs the unit-tests to be written. (https://github.com/litmuschaos/litmus/blob/master/tools/plugins/actionable.py)
What you expected to happen:
Create the unit-tests (along with refactoring of the source, where needed) for the litmus.
Anything else we need to know?:
References :
https://stackoverflow.com/questions/652292/what-is-unit-testing-and-how-do-you-do-it
http://pythontesting.net/framework/unittest/unittest-introduction/

Hi @dargasudarshan , I would like to work on this issue.

@Skchoudhary you can work on this issue. In case of any query reach us at our slack channel.

@dargasudarshan  @princerachit  I have created a Test class structure in this commit. Just want a confirmation that I am doing it in right way ?

@Skchoudhary , you can continue with the approach taken. Here are some good references on writing unit tests for ansible:

References: https://docs.ansible.com/ansible/2.5/dev_guide/testing_units_modules.html
Ansible Unit test for callback : https://github.com/ansible/ansible/blob/devel/test/units/plugins/callback/test_callback.py

@ksatchit Can you help me from here?
I haven't right test case before. So I am confused on what value assertion should check.

OpenEBS specific ansible plugins will be maintained at https://github.com/mayadata-io/litmus


Automate Org signup/creation

Depends on https://github.com/18F/cg-site/issues/219.

cf. https://github.com/18F/cg-scripts/pull/27

Was talking with @phirefly last night, and I wonder if we might look at C2 for this.


Fix language (request/response)

Context
The current content erroneously references an HTTP response header as a a request.
Changes proposed in this pull request
An attempt to fix ☝ , though it may be slightly clunky and need checking/improving/correcting by an expert.

Thanks @alexbishop1, I've made an attempt, let me know what you think.
Also re. the point about publicapi.pymnt.uk; I think there may have been some other instances that needed changing in the same section of the docs, would you be able to look at where I've changed these and let me know if these changes were sensible?
Many thanks 👍


Server is not closed when close() is used

Hello,
I'm trying to write integration test for my first Koa application (I come from Rubyland originally).
I noticed with every new import of my server in my integration tests, the number of request calls inside koa router is increasing. What that means? When I make one call, inside Koa server generates the request multiple times how many times the server is listened.
import app from '../../app'
import tokenSchema from '../../app/schemas/token'
import errorSchema from '../../app/schemas/error'
import {
  createUser,
  truncate,
} from '../helpers'

describe('Authentication API', () => {
  let server

  before(async () => {
    await<EMAIL_ADDRESS>  })

  beforeEach(() => {
    server = app.listen()
  })

  afterEach(() => {
    server.close()
  })

  after(async () => {
    await truncate('users')
  })

  describe('POST /auth', () => {
    context('when an user uses valid credentials', () => {
      it('returns authentication token response', async () => {
        const response = await request(server)
          .post('/api/v1/auth')
          .set('Content-Type', 'application/json')
          .send({ email<EMAIL_ADDRESS>password: 'password' })

        expect(response.status).to.equal(201)
        expect(response.type).to.equal('application/json')
        expect(response.body).to.be.jsonSchema(tokenSchema)
        expect(response.body.token).to.be.a('string').that.is.not.empty
      })
    })

    context('when an user uses invalid credentials', () => {
      it('returns invalid authentication error', async () => {
        const response = await request(server)
          .post('/api/v1/auth')
          .set('Content-Type', 'application/json')
          .send({ email<EMAIL_ADDRESS>password: 'passwrd' })

        expect(response.status).to.equal(401)
        expect(response.type).to.equal('application/json')
        expect(response.body).to.be.jsonSchema(errorSchema)
        expect(response.body).to.deep.equal({
          error: {
            type: 'invalidAuthentication',
            description: 'The credentials are incorrect.',
          },
        })
      })
    })
  })
})

// import server from '../../app/server'
import app from '../../app'
import errorSchema from '../../app/schemas/error'
import {
  createUser,
  truncate,
} from '../helpers'

describe('Users API', () => {
  let server

  beforeEach(() => {
    server = app.listen()
  })

  afterEach(async () => {
    server.close()
    await truncate('users')
  })

  describe('POST /users', () => {
    context('when a given user is not registreted yet', () => {
      it('returns the user response', async () => {
        const response = await request(server)
          .post('/api/v1/users')
          .set('Content-Type', 'application/json')
          .send({ email<EMAIL_ADDRESS>password: 'password' })

        expect(response.status).to.equal(201)
        expect(response.type).to.equal('application/json')
        expect(response.body).to.exist
      })
    })
  })
})

When the second spec is called. The request inside Koa route is called twice.
These tests pass but there are other which depends on number of data in DB. I don't know what's wrong.
My app looks
import Koa from 'koa'
import koaBody from 'koa-body'
import logger from 'koa-logger'
import { ENVIRONMENT } from '../config'
import { unprotectedRouter, protectedRouter } from './routes'
import validationErrorsMiddleware from './middlewares/validationErrors'
import internalErrorsMiddleware from './middlewares/internalErrors'
import exceptionsMiddleware from './middlewares/exceptions'
import authorizedErrorsMiddleware from './middlewares/unauthorizedErrors'
import jwtMiddleware from './middlewares/jwt'

const app = new Koa()

if (ENVIRONMENT !== 'test') {
  app.use(logger())
}

app.use(koaBody({
  urlencoded: false,
  text: false,
}))

// Error middlewares
app.use(exceptionsMiddleware)
app.use(internalErrorsMiddleware)
app.use(authorizedErrorsMiddleware)
app.use(validationErrorsMiddleware)

app.use(unprotectedRouter.routes())
app.use(unprotectedRouter.allowedMethods())

app.use(jwtMiddleware)

app.use(protectedRouter.routes())
app.use(protectedRouter.allowedMethods())

export default app

I use the latest koa, mocha, chai, supertest including esm for enabling ES module support. I tried multiple options and this is the latest iteration of that. It looks the server doesn't close after calling close(). In this case, there is no connection made during server initialization so the closing would be fine.
My dependencies:
  "dependencies": {
    "ajv": "^6.5.2",
    "bcrypt": "^3.0.0",
    "camelcase": "^5.0.0",
    "esm": "^3.0.72",
    "firebase-admin": "^5.13.0",
    "jsonwebtoken": "^8.3.0",
    "knex": "^0.15.2",
    "koa": "^2.5.2",
    "koa-body": "^4.0.4",
    "koa-jwt": "^3.3.2",
    "koa-logger": "^3.2.0",
    "koa-router": "^7.4.0",
    "objection": "^1.2.0",
    "objection-db-errors": "^1.0.0",
    "pg": "^7.4.3"
  },
  "devDependencies": {
    "chai": "^4.1.2",
    "chai-as-promised": "^7.1.1",
    "chai-http": "^4.0.0",
    "chai-json-schema-ajv": "^3.0.0",
    "dotenv": "^6.0.0",
    "dotenv-flow": "^0.1.0-beta.3",
    "mocha": "^5.2.0",
    "nodemon": "^1.18.2",
    "sinon": "^6.1.4",
    "sinon-chai": "^3.2.0",
    "supertest": "^3.1.0"
  }

I would recommend you to use request(app.callback());. You can read why in #1061 and #1064.

I am going to close this as solved. Feel free to reopen if you still have issues with this.

@fl0w Thanks. There is any more a problem. I forgot to mention app.callback() helped me. But, there is possible to meantion this in the documentation?
@dicearr Thanks for the tip!

@deepj maybe, however this is not a Koa thing. But how node http works and supertest, there's no point for Koa docs to mention all caveats of cross usage of node packages.


[Bug]: Activate version message does not respect stream alias

Singer SDK Version
0.11.1
Python Version
3.9
Bug scope
Targets (data type handling, batching, SQL object generation, etc.)
Operating System
Linux
Description
ActivateVersion messages crash the tap if a stream map alias is used.
This is the offending function in target_base.py

    def _process_activate_version_message(self, message_dict: dict) -> None:
        """Handle the optional ACTIVATE_VERSION message extension.

        Args:
            message_dict: TODO
        """
        stream_name = message_dict["stream"]
        sink = self.get_sink(stream_name)
        sink.activate_version(message_dict["version"])

Note this:
sink = self.get_sink(stream_name)

This is wrong. It should be this:
sink = self.get_sink(stream_map.stream_alias)

Code
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.695027Z","message":"INFO:target-bigquery:Initializing 'target-bigquery' target sink...","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.695375Z","message":"INFO:target-bigquery:Initializing target sink for stream 'e_call_center_candidate_submission'...","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.742855Z","message":"Traceback (most recent call last):","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.743201Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/bin/target-bigquery\", line 8, in <module>","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.743459Z","message":"    sys.exit(TargetBigQuery.cli())","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.743688Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/lib/python3.9/site-packages/click/core.py\", line 1130, in __call__","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.744026Z","message":"    return self.main(*args, **kwargs)","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.744270Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/lib/python3.9/site-packages/click/core.py\", line 1055, in main","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.744502Z","message":"    rv = self.invoke(ctx)","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.744736Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/lib/python3.9/site-packages/click/core.py\", line 1404, in invoke","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.744967Z","message":"    return ctx.invoke(self.callback, **ctx.params)","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.745209Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/lib/python3.9/site-packages/click/core.py\", line 760, in invoke","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.745439Z","message":"    return __callback(*args, **kwargs)","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.745664Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/lib/python3.9/site-packages/singer_sdk/target_base.py\", line 563, in cli","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.745894Z","message":"    target.listen(file_input)","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.746119Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/lib/python3.9/site-packages/singer_sdk/io_base.py\", line 34, in listen","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.746345Z","message":"    self._process_lines(file_input)","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.746572Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/lib/python3.9/site-packages/singer_sdk/target_base.py\", line 264, in _process_lines","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.746806Z","message":"    counter = super()._process_lines(file_input)","severity":"info"}
meltano_yobify_1            | Need help fixing this problem? Visit http://melta.no/ for troubleshooting steps, or to
meltano_yobify_1            | join our friendly Slack community.
meltano_yobify_1            |
meltano_yobify_1            | Run invocation could not be completed as block failed: Loader failed
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.747043Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/lib/python3.9/site-packages/singer_sdk/io_base.py\", line 84, in _process_lines","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.747281Z","message":"    self._process_activate_version_message(line_dict)","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.747537Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/lib/python3.9/site-packages/singer_sdk/target_base.py\", line 403, in _process_activate_version_message","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.747779Z","message":"    sink = self.get_sink(stream_name)","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.748016Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/lib/python3.9/site-packages/singer_sdk/target_base.py\", line 153, in get_sink","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.748342Z","message":"    self._assert_sink_exists(stream_name)","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.748603Z","message":"  File \"/project/.meltano/loaders/target-bigquery/venv/lib/python3.9/site-packages/singer_sdk/target_base.py\", line 247, in _assert_sink_exists","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.748923Z","message":"    raise RecordsWithoutSchemaException(","severity":"info"}
meltano_yobify_1            | {"consumer":true,"producer":false,"string_id":"target-bigquery","cmd_type":"elb","stdio":"stderr","name":"target-bigquery","level":"info","timestamp":"2022-10-10T08:57:15.749170Z","message":"singer_sdk.exceptions.RecordsWithoutSchemaException: A record for stream 'public-e_call_center_candidate_submission' was encountered before a corresponding schema.","severity":"info"}
meltano_yobify_1            | {"exc_info":["<class 'meltano.core.runner.RunnerError'>","RunnerError('Loader failed')","<traceback object at 0x7f94e395b840>"],"timestamp":"2022-10-10T08:57:16.965835Z","level":"error","message":"Loader failed","severity":"error"}

@spacecowboy - Thanks for raising this!

Still relevant and open to contributions


Fix build and generated output for .NET Standard

solution doesn't build by default
generated complex types contain properties for enum as 'ua:Int32' instead of 'opc:Int32'. same for xml. the generated files fail the Type Dictionary validation. see https://github.com/OPCFoundation/UA-.NETStandard/pull/1590
one of the samples in the .NET samples repo cannot resolve a referenced file
need latest tbd core stack to fix the uanodes output which contains too many type references

waiting for latest opc.Ua.Core release


Disable Helm tests, again

Supporting the Helm tests requires larger changes to how we build and access the ack-generate CLI. It is outside the scope of the #66 pull request, so I am reverting the change until it can be fully assessed and solved.
This PR should clear up any blockers to the e2e tests for the time being.

/lgtm


Improve VM performance by reducing instruction size

Per this reddit thread that discussed various different methodologies of significantly speeding up SuperFetch's virtual machine - reducing the instruction size by encoding offset flags as part of the instructions opcode seemed to be the most feasible and performant because it reduces the overall size of the instruction by 3 bytes(assuming there aren't more than 256 opcode types - I'll explain that later) herby reducing cache misses, and it'll reduce the processing time per instruction by bypassing the need for runtime computation of registers and their offsets.
A potential issue would be that there may be more than 256 (the max amount of enum types that can still fit in a byte), opcode types, there may be certain performance issues. However, instructions sizes will still have been signifgantly decreased and runtime offsetting bypassed.

Added the branch fast-vm, this will be where updates to the vm take place.

There are 54 compiler opcodes and 294 machine opcode types (compiler opcodes but with offset flags included). There should not be a major impact to performance.

Completed


upgrading dependencies

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 64.826%

Files with Coverage Reduction
New Missed Lines
%

flexmeasures/init.py
2
83.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
6867

Relevant Lines:
9858

💛  - Coveralls

Should this be backported?

No I don't think so.


[BUG] [QE] Panic when running integration test

General information

OS: macOS
Hypervisor: vfkit
Did you run crc setup before starting it (Yes/No)? Yes
Running CRC on: Laptop

CRC version
# Put `crc version` output here
CRC version: 24.08.27+e222fc
OpenShift version: 4.16.7
MicroShift version: 4.16.7

Host Operating System
ProductName:		macOS
ProductVersion:		14.4
BuildVersion:		23E214

Steps to reproduce
This can be reproduced by running integration test on the local machine. For example:
make GINKGO_OPTS="--ginkgo.label-filter='vm-resize'" BUNDLE_PATH="--bundle-path=/Users/gvyas/.crc/cache/crc_vfkit_4.16.7_arm64.crcbundle" PULL_SECRET_PATH="--pull-secret-path=/Users/gvyas/Downloads/pull-secret.txt" integration

Expected
No panic
Actual
Ran 20 of 36 Specs in 703.655 seconds
SUCCESS! -- 20 Passed | 0 Failed | 0 Pending | 16 Skipped
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x1010efb4c]

goroutine 1 [running]:
time.(*Timer).Stop(...)
	/opt/homebrew/Cellar/go/1.23.0/libexec/src/time/sleep.go:114
testing.(*M).stopAlarm(...)
	/opt/homebrew/Cellar/go/1.23.0/libexec/src/testing/testing.go:2392
testing.(*M).Run(0x140000feaa0)
	/opt/homebrew/Cellar/go/1.23.0/libexec/src/testing/testing.go:2037 +0x65c
github.com/crc-org/crc/v2/test/integration_test.TestMain(0x140000feaa0)
	/Users/gvyas/work/crc/test/integration/testsuite_test.go:38 +0x90
main.main()
	_testmain.go:47 +0x98
FAIL	github.com/crc-org/crc/v2/test/integration	704.552s
FAIL
make: *** [integration] Error 1

Logs
Before gather the logs try following if that fix your issue
$ crc delete -f
$ crc cleanup
$ crc setup
$ crc start --log-level debug

Please consider posting the output of crc start --log-level debug  on http://gist.github.com/ and post the link in the issue.

The root cause of this panic is that there is a race condition due to flag.Parse being called concurrently in two places: https://github.com/crc-org/crc/blob/main/test/integration/testsuite_test.go#L36 and https://github.com/crc-org/crc/blob/main/test/extended/util/proxy.go#L75 (The function here is called as a goroutine in the proxy_test.go file).
Another issue that I came across while working on this is that UserMode is not returned as default in the current code which causes certain issues in running the tests (in the case of MacOS and Windows). The PR for this will address this as well.

fixed in #4380


Mutt-wizard: Issues with sourcing

Issue description
Mutt-wizard creates a configuration that sources files in the build derivation, this means that if mutt-wizard is updated, and the old package is garbage-collected, then mutt can't find the required files.
Steps to reproduce
Install muttwizard
Update muttwizard
Garbage-collect
Technical details
The files in question are
/nix/store/hash-mutt-wizard-v/share/mutt-wizard/mailcap
and
/nix/store/hash-mutt-wizard-v/share/mutt-wizard/mutt-wizard.muttrc
If they could be moved to:
/run/current-system/sw/share

and the mw script patched to generate configs that point there instead the issue should be able to be resolved, right?
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.0, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.5pre20211007_844dd90`
 - channels(root): `"nixos-21.11pre327669.b67e752c29f, nixpkgs-21.11pre327669.b67e752c29f, anbox-2021-06-refresh.tar.gz-2021-06-refresh"`
 - channels(user): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

@SCOTT-HAMILTON


Self signed certificate，client p12 pass validation，but -1206 error code

Would you care to elaborate your issue? I don't even find which error uses the -1206 code.


at_risk_counts results as arrays or dataframe instead of under plot?

Hey!
I would like the results of the add_at_risk_counts to be saved as an array or something instead of it just being part of my plot. Is there any way of doing that?
Any help would be greatly appreciated!

Unfortunately there's no current way to do this =\
You'd have to duplicate the logic here into it's own function and pass in the fitter objects

Thank you for the quick response! I'll do that then :)


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc we don't use Prow
/assign we don't use Prow
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/eventing ee96d0b...a72cfc9:
  > a72cfc9 Remove unsupported stackdriver tracing backend (# 5881)
  > 36bf0bd Add securityContext to Knative Eventing core objects (# 5863)
  > 81afe0b upgrade to latest dependencies (# 5879)
bumping knative.dev/hack 29f86c2...96aac1c:
  > 96aac1c Add wait_until_object_exists library function (# 96)

Codecov Report

Merging #336 (e392f73) into main (eb93df2) will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   80.57%   80.31%   -0.27%
==========================================
  Files          20       20
  Lines         767      767
==========================================
- Hits          618      616       -2
- Misses        135      137       +2
  Partials       14       14

Impacted Files
Coverage Δ

pkg/vsphere/adapter.go
62.59% <0.00%> (-1.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb93df2...e392f73. Read the comment docs.


Uploading Synk Scan fails wiht 500 status code

Bug description
Uploading snyk.json throws 500 status code
Steps to reproduce
Steps to reproduce the behavior:

Go to Engagement>Import_scan
Import 'Snyk Scan' json result
see the error

Expected behavior
status 201
Deployment method (select with an X)

[ ] Kubernetes
[X] Docker
[ ] setup.bash / legacy-setup.bash

Environment information

Operating System: [CentOS Linux release 7.6.1810 (Core)  ]
DefectDojo version: [Docker Hub Latest]

Sample scan files (optional)
snyk.zip
Screenshots (optional)

Additional context (optional)
Retire.js results also throws 500 error

@devEricA @praveendvd has included a sample scan file, please verify.

Worked fine on mine @devGregA under the dev branch. @praveendvd Which branch are you using?

Worked fine on mine @devGregA under the dev branch. @praveendvd Which branch are you using?

Hi i am using docker image,
Below are the steps i did
stop all containers (sudo docker stop $(sudo docker ps -aq)
remove all images using (sudo docker system prune -a)
run the dojo container  (sudo docker run -it -p 8000:8000 appsecpipeline/django-defectdojo)
created a new product under research adn development
created a new engagement
upload synk report
i tried in another centos OS system and was able to reproduce the issue
i am logged in as non root , and i have only admin account in dojo

works fine for me too on the dev branch. @praveendvd  checkout to the dev branch.
git checkout dev
docker-compose build
cp dojo/settings/settings.dist.py dojo/settings/settings.py
docker/setEnv.sh dev
docker-compose up ```

before running these commands remove all images.

works fine for me too on the dev branch. @praveendvd checkout to the dev branch.
git checkout dev
docker-compose build
cp dojo/settings/settings.dist.py dojo/settings/settings.py
docker/setEnv.sh dev
docker-compose up ```

before running these commands remove all old images.

@dr3dd589 @devEricA @devGregA
Hi , I cloned the latest code from git and ran the docker. Now the upload is working from UI but not through API.
Below is the python python code i used
Note: The defect dojo api package is the latest one available in the git. i pulled the code and installed through ' python setup.py develop'.
#!/usr/bin/python

#import the package
from defectdojo_api import defectdojo
import os

#setup DefectDojo connection information
host = 'http://localhost:8000'
api_key = '<Provide_API>''
user = 'admin'

#instantiate the DefectDojo api wrapper
dd = defectdojo.DefectDojoAPI(host, api_key, user, debug=False)

print dd.upload_scan(1,"Snyk Scan", "<file_path>/snyk.json", "True", "2019-08-08")

Could you please guide me here, is it issue with pytho api
how to try this manually , what would be the payload. How to try the same using rest-client or postman.

works fine for me too on the dev branch. @praveendvd checkout to the dev branch.
git checkout dev
docker-compose build
cp dojo/settings/settings.dist.py dojo/settings/settings.py
docker/setEnv.sh dev
docker-compose up ```

before running these commands remove all old images.

@dr3dd589 @devEricA @devGregA
Hi , I cloned the latest code from git and ran the docker. Now the upload is working from UI but not through API.
Below is the python code i used for uploading the scan results
Note: The defect dojo api package is the latest one available in the git. i pulled the code and installed through ' python setup.py develop'.
#!/usr/bin/python

#import the package
from defectdojo_api import defectdojo
import os

#setup DefectDojo connection information
host = 'http://localhost:8000'
api_key = '<Provide_API>''
user = 'admin'

#instantiate the DefectDojo api wrapper
dd = defectdojo.DefectDojoAPI(host, api_key, user, debug=False)

print dd.upload_scan(1,"Snyk Scan", "<file_path>/snyk.json", "True", "2019-08-08")

Could you please guide me here, is it issue with pytho api
how to try this manually , what would be the payload. How to try the same using rest-client or postman.

Hi i was able to check the same using postman, and it throws the same error, @devGregA  @devEricA @dr3dd589

works fine for me too on the dev branch. @praveendvd checkout to the dev branch.
git checkout dev
docker-compose build
cp dojo/settings/settings.dist.py dojo/settings/settings.py
docker/setEnv.sh dev
docker-compose up ```

before running these commands remove all old images.

@dr3dd589 @devEricA @devGregA
Hi , I cloned the latest code from git and ran the docker. Now the upload is working from UI but not through API.
Below is the python code i used for uploading the scan results
Note: The defect dojo api package is the latest one available in the git. i pulled the code and installed through ' python setup.py develop'.
#!/usr/bin/python

#import the package
from defectdojo_api import defectdojo
import os

#setup DefectDojo connection information
host = 'http://localhost:8000'
api_key = '<Provide_API>''
user = 'admin'

#instantiate the DefectDojo api wrapper
dd = defectdojo.DefectDojoAPI(host, api_key, user, debug=False)

print dd.upload_scan(1,"Snyk Scan", "<file_path>/snyk.json", "True", "2019-08-08")

Could you please guide me here, is it issue with pytho api
how to try this manually , what would be the payload. How to try the same using rest-client or postman.

Hi i was able to check the same using postman, and it throws the same error, @devGregA @devEricA @dr3dd589

Hi team dev branch is working , master branch had the issue. Thank you for the help @devGregA @devEricA @dr3dd589


Fix unix domain socket binding for reverse tunnel

I case of unix domain socket, local host:port is always <IP_ADDRESS>:0 and when another client wants to connect with a different unix socket path, it binds it to the existing connection.

Hello,
Thank you for the PR.
The fix look good, just some merge request conflict to fix ;)


Extra spacing above top heading in a callout

From this doc
    {{
    docCallout (Some {{ 🤔 }})
      {{
      ## What about LLVM?

      Blah blah blah
      }}
    }}

We get

This has been fixed it appears.


Model was trained, how to run anomaly detection on custom video file?

Have followed the steps to train the model on the HEVI features and ego-motion files provided by the author. Now I have:

fol_epoch_091_loss_0.0113.pt
ego_pred_epoch_091_loss_0.0180.pt

Then I need to run anomaly detection on a custom video file downloaded from the internet. How to do this?
Currently my understanding is to follow the below steps to process the video:
Detection: MaskRCNN
Tracking: DeepSort
Dense optical flow: FlowNet2.0
Ego motion: ORBSLAM2
Then refer the code in run_fol_for_AD.py & run_AD.py for the anomaly detection?
Thanks.

Have followed the steps to train the model on the HEVI features and ego-motion files provided by the author. Now I have:

fol_epoch_091_loss_0.0113.pt
ego_pred_epoch_091_loss_0.0180.pt

Then I need to run anomaly detection on a custom video file downloaded from the internet. How to do this?
Currently my understanding is to follow the below steps to process the video: Detection: MaskRCNN Tracking: DeepSort Dense optical flow: FlowNet2.0 Ego motion: ORBSLAM2
Then refer the code in run_fol_for_AD.py & run_AD.py for the anomaly detection?
Thanks.

 Can you please tell me how to generate features (specially ego_motion using orbslam_2)for your video file?
thank you

No, not yet

hi, I am a student from china, can you please share the HEV-I dataset with me? Thank you very much!

Have followed the steps to train the model on the HEVI features and ego-motion files provided by the author. Now I have:
* fol_epoch_091_loss_0.0113.pt

* ego_pred_epoch_091_loss_0.0180.pt

Then I need to run anomaly detection on a custom video file downloaded from the internet. How to do this?
Currently my understanding is to follow the below steps to process the video: Detection: MaskRCNN Tracking: DeepSort Dense optical flow: FlowNet2.0 Ego motion: ORBSLAM2
Then refer the code in run_fol_for_AD.py & run_AD.py for the anomaly detection?
Thanks.

hi, I am a student from china, can you please share the HEV-I dataset with me? Thank you very much!
My email address is<EMAIL_ADDRESS>

Hi @sbjshxbxijs you don't need to have the raw HEVI dataset to train your model. Just download the feature files in the README and extract them out (they become train and val), then edit 'data_root' in 'fol_ego_train.yaml' to where those train and val are stored. Run the train scripts and you will get similar result.

@sbjshxbxijs Are you sure? Have you try it? I did train successfully with just those files and got similar loss value as this issue's starter.

@sbjshxbxijs Are you sure? Have you try it? I did train successfully with just those files and got similar loss value as this issue's starter.

Did you only use the festure files but not the HEVI dataset during training?

Did you only use the festure files but not the HEVI dataset during training?

Hello can you help me with the checkpoints directory because when I run the proejct it gives the error of no checkpoint directory.

Hi @Awais-019,
You only need to make a new directory in the current working directory that is matched with the configuration in the fol_ego_train.yaml file, for me it is checkpoint_dir: "checkpoints/fol_ego_checkpoints". It is the directory that the checkpoint will be stored, so your job is to prepare it first.

Thanks but what about best ego model it also gives error.

Check it is giving this error FileNotFoundError: [Errno 2] No such file or directory: 'checkpoints/ego_pred_checkpoints/epoch_080_loss_0.001.pt'

hi, I am a student from china, can you please share the HEV-I dataset with me? Thank you very much!

Hi I don't have the authority to share the raw videos with you. However I have uploaded the train and validation features I extracted from the HEV-I paper : https://github.com/MoonBlvd/tad-IROS2019#hev-i-dataset
These should be enough to train a FOL model.

@Awais-019 I think you didn't put the data in the directory that your code is looking at. I saw @sbjshxbxijs posted a similar issue.

Check it is giving this error FileNotFoundError: [Errno 2] No such file or directory: 'checkpoints/ego_pred_checkpoints/epoch_080_loss_0.001.pt'

did you run train_pred_ego.py first? You won't have those checkpoints if you haven't ran ego motion training.


@opentelemetry/instrumentation version 0.34.0 breaks @opentelemetry/instrumentation-fs

What happened?
Steps to Reproduce
"use strict";
const { FsInstrumentation } = require("@opentelemetry/instrumentation-fs");
const { registerInstrumentations } = require("@opentelemetry/instrumentation");
registerInstrumentations({
    instrumentations: [
        new FsInstrumentation()
    ]
});
const fs = require("fs/promises");

Expected Result
no crash
Actual Result
C:\work\otel-contrib-1305\node_modules\@opentelemetry\instrumentation-fs\build\src\instrumentation.js:53
                        if (instrumentation_1.isWrapped(fs.promises[fName])) {
                                                                   ^

TypeError: Cannot read properties of undefined (reading 'access')
    at InstrumentationNodeModuleDefinition.patch (C:\work\otel-contrib-1305\node_modules\@opentelemetry\instrumentation-fs\build\src\instrumentation.js:53:68)
    at FsInstrumentation._onRequire (C:\work\otel-contrib-1305\node_modules\@opentelemetry\instrumentation\build\src\platform\node\instrumentation.js:79:35)
    at C:\work\otel-contrib-1305\node_modules\@opentelemetry\instrumentation\build\src\platform\node\instrumentation.js:133:29
    at C:\work\otel-contrib-1305\node_modules\@opentelemetry\instrumentation\build\src\platform\node\RequireInTheMiddleSingleton.js:54:27
    at Hook._require.Module.require (C:\work\otel-contrib-1305\node_modules\require-in-the-middle\index.js:175:32)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (C:\work\otel-contrib-1305\r.js:9:12)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)

Node.js v18.12.1

Additional Details
This is caused by #3161.
Splitting the module name on / here is not correct for built in modules like fs/promises.
As a result the instrumentation-fs hook for fs is called but gets the exports from fs/promises.
OpenTelemetry Setup Code
"use strict";
const { FsInstrumentation } = require("@opentelemetry/instrumentation-fs");
const { registerInstrumentations } = require("@opentelemetry/instrumentation");
registerInstrumentations({
    instrumentations: [
        new FsInstrumentation()
    ]
});
const fs = require("fs/promises");

package.json
{
  "name": "otel-contrib-1305",
  "version": "1.0.0",
  "main": "r.js",
  "scripts": {
    "start": "node r.js"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "dependencies": {
    "@opentelemetry/api": "1.3.0",
    "@opentelemetry/instrumentation-fs": "0.6.0"
  }
}

Relevant log output
C:\work\otel-contrib-1305\node_modules\@opentelemetry\instrumentation-fs\build\src\instrumentation.js:53
                        if (instrumentation_1.isWrapped(fs.promises[fName])) {
                                                                   ^

TypeError: Cannot read properties of undefined (reading 'access')
    at InstrumentationNodeModuleDefinition.patch (C:\work\otel-contrib-1305\node_modules\@opentelemetry\instrumentation-fs\build\src\instrumentation.js:53:68)
    at FsInstrumentation._onRequire (C:\work\otel-contrib-1305\node_modules\@opentelemetry\instrumentation\build\src\platform\node\instrumentation.js:79:35)
    at C:\work\otel-contrib-1305\node_modules\@opentelemetry\instrumentation\build\src\platform\node\instrumentation.js:133:29
    at C:\work\otel-contrib-1305\node_modules\@opentelemetry\instrumentation\build\src\platform\node\RequireInTheMiddleSingleton.js:54:27
    at Hook._require.Module.require (C:\work\otel-contrib-1305\node_modules\require-in-the-middle\index.js:175:32)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (C:\work\otel-contrib-1305\r.js:9:12)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)

Node.js v18.12.1

fyi @mhassan1

I will take a look at this. I had added a test case especially for fs/promises, but I guess it was not a good test case.

Here is what I have discovered:

In<EMAIL_ADDRESS>require('fs/promises') was actually not being instrumented on its own without an additional call to require('fs'). This is because RequireInTheMiddle(['fs'], { internals: true }, onRequire) does not call onRequire for fs/promises (this could be considered an unexpected behavior in RITM, since it will call onRequire for sub-path exports in non-core modules).
In<EMAIL_ADDRESS>require('fs/promises') causes an attempt to instrument fs/promises, but this !baseDir check causes the patch function to be called with exports of fs/promises, even though it is expecting the exports of fs. A potential fix would be to add an if (module.name === name) check there, since we only want to call the patch function for fs and not for fs/promises. This would return us to the prior state, where we are not calling onRequire for fs/promises.

I will put up a PR to restore the prior behavior.

I think (1) is actually a bug/missing functionality in the fs instrumentation. it should register a hooks for "fs/promises" and ensure that it is able to handle that either or both hooks are called in arbitrary order.


datadog agent is running but that host is not showing up in Datadog UI Console

Datadog agent is running in the system but that is not being displayed in Infrastructure Hosts and also metrics are not present.
I feel the data is not being sent to site.
I'm not able to find out the issue.
Can any one help me with this issue.

Hi @chakreshkolluru,
For your request, please contact our support and send them your logs.
Thanks.


Optimization information

The wiki needs a page on optimization for CreateJS and Pixi.

The page has been created, with the major bits about art: https://github.com/SpringRoll/SpringRoll/wiki/Optimized-Art-Creation-and-Usage

Will expand on this doc.

This is a SpringRoll 1 issue, closing


Add consistent flannel configuration.

Hi,
it is extremely annoying to configure flannel from cloud-config. When doing flannel configuration, you have to think about YAML, JSON, SHELL syntaxes and catch bugs in different files.
Please add consistent configuration for flannel in single file.

Flannel is configured through command line options and JSON in etcd. I'm going to close this issue as I can't see a better way to do this, if you have some suggestions I can reopen it.


Unite HATVault files

We currently have the HATVault files separated by logic. But I think now with the new architecture it's just confusing and unnecessary, I'd suggest moving everything into one file.

I will not protest if you do this :)

After we finish with all the PRs I'll try that


Preview of 3.11.0

Generated release branch. Contains all planned PRs. Will not be merged, is just here for review.

Coverage remained the same at 100.0% when pulling ce91295f5e3a827d77037db2c461ff55b6fb3e76 on release/3.11.0 into 9aafcbe96578f40276d7f779ab5421a908cea611 on develop.


The set crypto hack no longer works

This is amazing client but plz fix this issue

I can work out a fix.


(Flaky-test) Failure to build postgres image during tests

[ERROR] The command '/bin/sh -c /pulsar/django/init-postgres.sh' returned a non-zero code: 1
[ERROR] The command '/bin/sh -c /pulsar/django/init-postgres.sh' returned a non-zero code: 1
[ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.4.13:build (default) on project pulsar-standalone-docker-image: Could not build image: The command '/bin/sh -c /pulsar/django/init-postgres.sh' returned a non-zero code: 1 -> [Help 1]
[ERROR]

It's showing up here: https://github.com/apache/pulsar/pull/6202/checks?check_run_id=432265311
logs_14410.zip

This has been fixed https://github.com/apache/pulsar/pull/6279, can we close it? @devinbost

@tuteng Yes, I will close this issue. Thanks for letting me know!


Clarifying restrictions on FunctionName attribute

I hit this issue when creating a function name and found the regex in the codebase which the update is based on.

@aaronpowell : Thanks for your contribution! The author, @tdykstra, has been notified to review your proposed change.

#sign-off


I think the nav bar option animation is to be updated and in mobile the opening list item animation is missing

I want to add some hovering animation to the nav bar option list and in small devices the hamburger menu button has no animation.
Describe the solution you'd like
I will add the animation in the CSS section of the project and it will enhance user experience.

in this image the hovering animation and in the second image I will add the opening smooth animation. I am contributing as part of SWOC 2024

go for it

if its open can i work on it @akshitagupta15june ?

I am working on it
On Tue, Jan 2, 2024, 10:40 AM Pritish Bhawal @.***>
wrote:

if its open can i work on it @akshitagupta15june
https://github.com/akshitagupta15june ?
—
Reply to this email directly, view it on GitHub
https://github.com/akshitagupta15june/PetMe/issues/1431#issuecomment-1873624843,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT2NZ4TEZN34VBH4AXCNFILYMOJDFAVCNFSM6AAAAABBIYQFKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTGYZDIOBUGM
.
You are receiving this because you were assigned.Message ID:
@.***>

i am unable to solve the issue please anyone can work on it

can i work on it? @akshitagupta15june

can you please assign me this issue under SWOC.

Hey @akshitagupta15june , Can you please assign me this issue ?
I will work as early as issue is assigned

@akshitagupta15june can you please assign me this issue under SWOC.


Add yml file for read the docs

https://docs.readthedocs.io/en/stable/config-file/v2.html
Need to tell it to install guzzle

Gonna hold off until support for pipenv is merged: https://github.com/rtfd/readthedocs.org/issues/3181
Looks like it's getting close


add fjogeleit to owners

Signed-off-by: Frank Jogeleit<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:
Be able to review and approve falcosidekick-ui related PRs.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr after the PR has been reviewed.
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 770f9f335a97f4135853547de41cb9a4cfda0ada

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Concurrency issue?

Hi using gargoyle.is_active we've found in our sentry this exception:
Stacktrace (le chiamate più recenti alla fine):

  File "django/core/handlers/base.py", line 164, in get_response
    response = response.render()
  File "django/template/response.py", line 158, in render
    self.content = self.rendered_content
  File "django/template/response.py", line 135, in rendered_content
    content = template.render(context, self._request)
  File "django_jinja/backend.py", line 64, in render
    return self.template.render(context)
  File "jinja2/environment.py", line 989, in render
    return self.environment.handle_exception(exc_info, True)
  File "jinja2/environment.py", line 754, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "./yellow/our_template.html", line 83, in block "main_content"
    {{ render_company(company_name, switch_is_active("ourswith", request.user)) }}
  File "yellow/templatetags/tags.py", line 137, in switch_is_active
    return gargoyle.is_active(switch_slug, *instances)
  File "gargoyle/manager.py", line 58, in is_active
    switch = self[key]
  File "gargoyle/manager.py", line 34, in __getitem__
    return SwitchProxy(self, super(SwitchManager, self).__getitem__(key))
  File "modeldict/base.py", line 23, in __getitem__
    self._populate()
  File "modeldict/base.py", line 168, in _populate
    elif self.local_cache_has_expired():
  File "modeldict/base.py", line 108, in local_cache_has_expired
    recheck_at = self._last_checked_for_remote_changes + self.timeout

Seems to be a concurrency issue in the function  local_cache_has_expired
105.  if not self._last_checked_for_remote_changes:
106.      return True  # Never checked before
107.
108.  recheck_at = self._last_checked_for_remote_changes + self.timeout
109.  return time.time() > recheck_at

We use:
django 	1.8.4
gargoyle 	0.11.0

What is the actual exception that is being thrown?

Hi, the concurrency issue has been fixed in our fork django-modeldict-yplan (in this commit), please check it out at https://github.com/YPlan/django-modeldict .

Thank you!

Forgot to say: we're also maintaining nexus and gargoyle.


add monitor for image sync

Current Behavior
we don't know the status for image sync to CN
Proposed Behavior

Solution Proposal

done by jenkins


chore: upgrade sharp to 0.31.3

Quick Checklist

[X] I have read the contributing guidelines
[ ] I have written new tests, as applicable (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[X] I have added a changeset, if applicable

What kind of change does this PR introduce? dependency upgrade

What is the new behavior (if this is a feature change)? none

Does this PR introduce a breaking change? no

Other information:

@JonasKruckenberg I'm not quite sure why this one is failing. I haven't looked at it much, but I know you've dealt with some Sharp upgrades before, so maybe you have some ideas?

will take a look 👍🏻 also what happened to dependency PRs here?

So this issue is that sharp or libvips changed the way the quality option for pngs works causing the produced image to be different. I would suggest we just update our test fixtures accordingly (I tried to push to your branch but I think I'm not allowed) so just run ppm test -- -u to update fixtures. Then you just need to update the hash in the vite test file and you're good 👍🏻

Okay. I'll take a stab at updating the fixtures later
If you get to it before I do, you should be able to push to my branch

Hmm. I've run that command to update the fixture. The tests still seem to be failing. I'm not sure if there's something else we need to do?
Also, the image looks much worse. I'm not sure if we're worried that the image quality has degraded or if that's just a better interpretation of the image parameter and is fine

closing in favour or #494


TextFormField does not support obscureText and textCapitalisation

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

In TextFormField, add obscureText to true and assign textCapitalization to TextCapitalization.characters

Expected results
The keyboard should be capitalized in both show and hide character in TextFormField with obscureText
Actual results

In TextFormField, add obscureText to true and assign textCapitalization to TextCapitalization.characters
The device keyboard is capitalised when the show text is clicked but when the hide text is clicked, the keyboard defaults to lowercase characters.

Code sample
Code sample
TextFormField(
  textCapitalization: TextCapitalization.characters,
  obscureText: true,
);

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
Reloaded 1 of 1588 libraries in 334ms (compile: 79 ms, reload: 83 ms, reassemble: 155 ms).
Reloaded 1 of 1588 libraries in 318ms (compile: 63 ms, reload: 133 ms, reassemble: 108 ms).
Reloaded 1 of 1588 libraries in 201ms (compile: 20 ms, reload: 62 ms, reassemble: 110 ms).
Reloaded 58 of 1588 libraries in 408ms (compile: 187 ms, reload: 104 ms, reassemble: 101 ms).

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.3.8, on macOS 13.0.1 22A400 darwin-arm, locale en-IN)
    • Flutter version 3.3.8 on channel stable at /Users/admin/Workspace/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52b3dc25f6 (9 months ago), 2022-11-09 12:09:26 +0800
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/admin/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = /Users/admin/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/admin/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A309
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.80.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (3 available)
    • Client iPhone 14 (mobile) • A77B6DEE-BB30-4428-B1B3-5E1018973062 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-16-0 (simulator)
    • macOS (desktop)           • macos                                • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm
    • Chrome (web)              • chrome                               • web-javascript • Google Chrome 114.0.5735.248

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi @vbj187. Thanks for filing this issue. I am able to reproduce this on the latest master and stable channels. The keyboard doesn't show capitalized texts when obscureText is set to true. Otherwise it works as expected.
flutter doctor -v

[✓] Flutter (Channel stable, 3.10.6, on macOS 13.4 22F66 darwin-arm64, locale
    en-NG)
    • Flutter version 3.10.6 on channel stable at /Users/dammya/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f468f3366c (12 days ago), 2023-07-12 15:19:05 -0700
    • Engine revision cdbeda788a
    • Dart version 3.0.6
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version
    32.1.0-rc1)
    • Android SDK at /Users/dammya/Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • ANDROID_HOME = /Users/dammya/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.80.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (4 available)
    • sdk gphone arm64 (mobile) • emulator-5554                        •
      android-arm64  • Android 11 (API 30) (emulator)
    • iPhone 14 Pro (mobile)    • DCF2031A-7EA9-42FF-8CD4-D4584F3E7A6D • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)           • macos                                •
      darwin-arm64   • macOS 13.4 22F66 darwin-arm64
    • Chrome (web)              • chrome                               •
      web-javascript • Google Chrome 114.0.5735.248

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[✓] Flutter (Channel master, 3.13.0-8.0.pre.65, on macOS 13.4 22F66 darwin-arm64, locale en-NG)
    • Flutter version 3.13.0-8.0.pre.65 on channel master at /Users/dammya/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9c10151508 (2 hours ago), 2023-07-24 11:26:05 +0200
    • Engine revision 4734a709cb
    • Dart version 3.1.0 (build 3.1.0-333.0.dev)
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/dammya/Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • ANDROID_HOME = /Users/dammya/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.80.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (4 available)
    • sdk gphone arm64 (mobile) • emulator-5554                        • android-arm64  • Android 11 (API 30) (emulator)
    • iPhone 14 Pro (mobile)    • DCF2031A-7EA9-42FF-8CD4-D4584F3E7A6D • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)           • macos                                • darwin-arm64   • macOS 13.4 22F66 darwin-arm64
    • Chrome (web)              • chrome                               • web-javascript • Google Chrome 114.0.5735.248

[✓] Network resources
    • All expected network resources are available.

• No issues found!

What devices were you guys reproducing this on, both Android and iOS?
I'm curious what happens in native apps of those platforms, too.  Is it possible to create an obscured native field with a capitalized keyboard?

It issue happens in both iOS and Android
On Fri, 28 Jul, 2023, 4:00 am Justin McCandless, @.***>
wrote:

What devices were you guys reproducing this on, both Android and iOS?
I'm curious what happens in native apps of those platforms, too. Is it
possible to create an obscured native field with a capitalized keyboard?
—
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/131176#issuecomment-1654666534,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN35VRQS425PJMP4BQWBX3DXSLTYTANCNFSM6AAAAAA2VGLDIQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Always target cluster local gateway for RewriteHost rules

Following on from @ZhiminXiang's suggestion in  https://github.com/knative-sandbox/net-istio/pull/174, better to always target the cluster local gateway in RewriteHost rules, since the user may want to set up https/authentication on the external gateway that might otherwise get in the way of the request.
/assign @ZhiminXiang @tcnghia

/lgtm
/approve