Encounter list page

Create a new page to list out the encounters created by the user on the device. All previous encounters will be listed regardless of the user who created them. This is the first page users see when they login and upon clicking 'Add encounter'
the user is taken to Habitat use form.
The flow of the UI is as follows -
Login page -> Encounter list page -> click 'Add encounter' -> New Habitat use page -> click 'Save habitat' -> Goes to Encounter overview page.
This is where the user can edit Encounter details or Add new habitat or End the encounter.
When user clicks on 'End encounter' they are taken to Encounter list page.
Wireframes:
https://drive.google.com/drive/folders/1CdAHfQRHZbC5htGi2Vei-zolPUDkXGps?usp=sharing
Tech Tasks:

create components

[x] create a ListItem and reuse it in HabitatUseList
[x] create a ListHeader and reuse it in HabitatUseList
[x] create a ListSubheader
expected data structure: today and previousEncounters are separate lists with both type ChunkedEncountersData = {month: string; year: number; entries: {id: string; data: EncounterItem}[]}[]
[x] create Encounters which shall consume a custom hook and render two EncounterLists, one for todaysEncounters and one for previousEncounters.
[x] create EncounterList, which renders several <ul>s in a loop.
[x] inside EncounterList, make primary/secondaryTime props in ListItem of todaysEncounters be time. Make primary/secondaryTime props in ListItem of previousEncounters be date.
[x] inside EncounterList, rename the variables in the loop.
[x] write tests for EncounterList displaying data against the emulator if possible, otherwise against a mocked datastore.
[x] inside EncounterList, make the Load previous month button disappear after 12 months of data have been loaded.
[x] make the Load previous month button disabled while the data is being loaded. Consume the isLoading flag from the hook to do so.

[x] create test for getEncountersByTimeRange for ensures encounters are ordered, even after you change the start date of something => QUESTION: what should happen when encounter doesn't have a startTime (this field is optional in the form)?- make startTime mandatory
create a useEncountersByMonth hook

expected return type is {today: ChunkedEncountersData; previousEncounters: ChunkedEncountersData; loadNextMonth: () => void}, isLoading: boolean}. It takes a datastore as an argument.
tests should use mocked Date.now()
[x] create a getEncountersByTimeRange within the hook function that transforms raw data of type {id: string; data: EncounterItem}[] to ChunkedEncountersData. Ensure that it sorts the data correctly.
[x] make same month's encounters split into today and previousEncounters (first of month until yesterday)
[x] make sure previous month's structure is {month: string; year: number; entries: []} when encounters for that month are not available
[x] making the load more function undefined after the data for last 12 months was loaded
[x] return an isLoading flag while encounters are being loaded

[x] transform timestamps of all data returned by datastore from the firestore timestamp object to a JavaScript date object. Maybe two helper functions, eg. isFirestoreTimestampField and parseFirestoreTimestamp might be useful.
Pages and flow

[x] ~HOLD ON - WAIT FOR RESULT OF USER TESTING. Add a navigation test to pages/__tests__ folder to ensure adding a new encounter takes you to the NewHabitatUse form.~
[x] ~HOLD ON - WAIT FOR RESULT OF USER TESTING. Creating a new encounter from EncounterList should create a new empty encounter and save it to the database. Write a test for this behavior.~
NOTE: the two tasks above will be done in another story
[x] Go to encounters list after login

[x] Style changes:

[x] Revisit typography.js to cater for different font weight, color and size combinations.
[x] Title size 18px (ListHeader)
[x] Title font weight 600 (ListHeader)
[x] List item size 16px (ListItem)
[x] Padding on left/right edges (List)
[x] Button 100px width (ListHeader)
[x] Bring right arrow in (ListItem)
[x] Fix arrow color (ListItem)
[x] Fix ListItem text overflow
[x] Change cursor in Load previous month button to be a hand
[x] Giant footer in small screens
[x] Add more space between sequence nr and species
[x] Change message displayed when there are no encounters today (currently the message is "No encounters in August")

Acceptance Criteria:

Create an Encounter list page - refer wireframe
Clicking on 'Add Encounter', takes user to habitat form
When user is on the encounter list page, and no previous encounters are listed, they see a message - refer wireframe
When user is on the encounter list page, and there are some previously created encounters for the past month, they see them listed under the month name - refer wireframe
When user is on the encounter list page, and there are no previously created encounters for the past month, they see a message 'no encounters listed'- refer wireframe
Clicking on 'Load more' - loads previously created encounters one month at a time
Loaded encounters should be in reverse-chronological order

Out of Scope:

Linking encounter list page to encounter overview page - this will be covered in #47
Success and error messages shown in wireframes (not relevant to this story).

Questions:

Disabling load more button effect
Default route

[ ] remove hand cursor when the button load more is disabled
[ ] investigate why there are no today's encounters shown after an encounter is created while being offline


node v10 crashes with sqlcipher

Until now, I have been using<EMAIL_ADDRESS>and node v8 with sqlcipher 3.4.2 with no problem whatsoever. I use a x64 linux machine to cross-compile to an arm linux, and it works fine (--target-arch=arm --target-platform=linux).
Problems arise when I migrate node to v10.14.2 and try to re-compile. When using the so cross-compiled module, I get a node crash when attempting to execute a get (I get no error when opening the db).
For information, I have another module that requires cross-compilation and that one works fine in node v10. Only node-sqlite3 is breaking. Also, if I compile using sqlite3 instead of sqlcipher, it also seems to work.
Two things caught my attention: a lot of warnings about deprecated stuff when compiling, but I think this is just about the same a for node v8; and the fact that an older version of nan is being used (2.10.0), and it clearly states it's for node <= 9.
Any thoughts?
Thanks.

I tried today with sqlcipher v4.0.1 and node v10.15.0, with same outcome: crash when executing database.get(). Compiles and runs fine with node v8.15.0

Would you be able to try with v5.0.3? 🙂


Create support for Matrix URIs

PR related to issue #968. @grabbou

@mgonto this is something that we want to use to support complex filtering in our REST APIs. Want can we do to speed up the merge?
Thanks again for this awesome piece of software. It's a lifesaver.

+1

+1

I think we can close this one, the structure of the code changed, so it needs to be done again.


Support TLS

close #118
works based on @codeflows, thanks for his excellent work.
Implement
I think there is no need to implement TLS handshake ourselves, we can just use Deno.startTls to do that. Thus, TLS will be limited by it. I have opened a PR request for more abilities https://github.com/denoland/deno/issues/18851

MTLS is not supported

Configurations
provide two configurations

tls.mode (disabled or verify_identity): hard to implement other modes  limited by Deno.startTls
tls.caCerts

Test

I have tested it locally with some mysql-compatible serverless database

works with planetScale whose cert is signed by Let's Encrypt
works with TiDBCloud serverless tier whose cert is signed by Let's Encrypt
works with TiDBCloud dedicated tier whose cert is self-signed

import { Client } from "./mod.ts";
const planetscale = async () => {
    const client = await new Client().connect({
        hostname: "aws.connect.psdb.cloud",
        username: "zaibc8chxlig2v0qevme",
        password: "****",
        port: 3306,
        tls: {
            mode: "verify_identity",
        },
    });
    const { rows: users } = await client.execute(`show databases`);
    console.log(users);
    await client.close();
};
const tidbcloudserverless = async () => {
    const client = await new Client().connect({
        hostname: "gateway01.eu-central-1.prod.aws.tidbcloud.com",
        username: "***.root",
        password: "****",
        port: 4000,
        tls: {
            mode: "verify_identity",
        },
    });
    const { rows: users } = await client.execute(`show databases`);
    console.log(users);
    await client.close();
};
const tidbclouddedicated = async () => {
    const client = await new Client().connect({
        hostname: "tidb.hsqimmori8j.clusters.dev.tidb-cloud.com",
        username: "root",
        password: "****",
        port: 4000,
        tls: {
            mode: "verify_identity",
            caCerts: [
                await Deno.readTextFile("ca.pem"),
            ],
        },
    });
    const { rows: users } = await client.execute(`show databases`);
    console.log(users);
    await client.close();
};
planetscale()
tidbcloudserverless()
tidbclouddedicated()

I have tried a lot to test MySQL and MariaDB, but failed to open SSL or generated the right self-signed cert for them. Thus,   this pr does not have tests now. I will try it at another time, but I think it is also ready to be reviewed for it has been tested for some cloud products with tls.

compatibility

can‘t work with the Deno version which does not support starttls
have not tested the compatibility with MySQL and MariaDB. I think the compatibility issue may exist. But we can't do more about it because it depends on howDeno.startTls handles the TLS. For example, how to verify hostname

@lideming PTAL, this pr lacks tests but I think it is also ready for review. I will continue trying to add test for it

@uki00a can you take a look?

@uki00a Thank you for your review and I have optimized the code according to your comment. PTAL again.
This pr excludes the mariadb:latest in the GitHub action test to pass all checks.
This test will fail with the following message:
OCI runtime exec failed: exec failed: unable to start container process: exec: "mysql": executable file not found in $PATH: unknown

But it is not the fault of this pr, it will fail even in master https://github.com/denodrivers/mysql/pull/160. I think we can skip this test in this pr and open another pr to fix it.

@lideming can this pr be merged?


Add payment intent for stripe

@Azdaroth seems like while working on 3ds we did not pull request & merge this branch to our bookingsync branch. We need to merge it in order to not break compatibility with stripe while merging this one: https://github.com/BookingSync/active_merchant/pull/5

@Azdaroth yeah, we are using this branch on prod


Update language server to support microprofile-config.properties

Quarkus supports both src/main/resources/application.properties and src/main/resources/META-INF/microprofile-config.properties, the latter being the MicroProfile standard configuration file.
The language server supports application.properties but not microprofile-config.properties. This request is to add support for microprofile-config.properties to get syntax highlighting, code completion, etc.
The primary justification is that developers often like to develop portable code, and this request would help to achieve that goal while remaining productive. In  addition, developers often want to try existing projects on Quarkus, and having code completion of existing microprofile-config.properties would greatly facilitate this use case without having to RTFM. Ex: "Re-hosting my project on  Quarkus nearly works, but how the heck do I change the default http port"? Code-completion really helps with scenarios like this!

@jclingan thank's for having reported this issue.
If I understand correctly microprofile-config.properties should have only microprofile properties (ex : MyClass/mp-rest/url) and application.properties should have microprofile properties and Quarkus properties both.
Is that?

Let me add @kenfinnigan. We would want any kind of property (quarkus, application, microprofile) supported by both property files. However, I want to check with Ken (who can pull in others if required) on having both property files at the same time for the same app.  I wouldn't think we would want that.

Is this anything more than adding an additional filename the editor and validation extension will react to ?

Is this anything more than adding an additional filename the editor and validation extension will react to ?

If the idea is to have in microprofile-config.properties the same behavior than application.properties I think it can be easy to do. As @maxandersen it's just adding a file name is the package.json of the vscode-quarkus.
The only thing that we must manage too is on JDT LS extension side which load application.properties to get the server port (to manage CodeLens URL (base url)). We will need to load the both files.

codelens url ? what is that for ?
What from the properties file does JDT LS need to get a base url ? (I assume here JDT LS is just for java content assist/validation but sounds like there is something else at play here ? )

codelens url ? what is that for ?

It's for JAX-RS:

See PR at https://github.com/redhat-developer/quarkus-ls/pull/140#issuecomment-552788862
You can configure the port in application.properties with
quarkus.http.port=9090. In this case, the Codelens URL will display this port. The CodeLens is managed by the JDT LS extension because we need the Java AST to get the proper JAX RS method.

We definitely don't want both files present in the same app.
For Quarkus we push for MP and Quarkus config to be in application.properties.
The use case would really only be for migrations from other frameworks that use MicroProfile.
So the file only needs to support MicroProfile properties I think

@kenfinnigan did you mean the same thing than my comments https://github.com/redhat-developer/vscode-quarkus/issues/181#issuecomment-570807204 ?

Yes, sorry for confusion

@angelozerr @kenfinnigan No, wait, not the same thing if i parse that comment correctly. Only one file should exist in a project, either microprofile-config.properties or application.properties. The chosen configuration file should contain all properties necessary to configure quarkus, microprofile, and the application.
BTW, if both exist, things get ugly with "which one takes priority", etc. It's just easier to say one or the other.

I would disagree that it makes sense for microprofile-config.properties to include Quarkus properties

I would disagree that it makes sense for microprofile-config.properties to include Quarkus properties

@jclingan @kenfinnigan once you will decide together what you want to have we will start implementing something. Please describe what you wish to have in detail (takes a sample and please tell me what you want to have (which properties for completion, etc).
The thing that I understand is that it's not possible to have the two files microprofile-config.properties and application.properties in the same project.
Perhaps we could have an error on the top of application.properties (when it is opened) and in microprofile-config.properties (when it is opened) to say "you cannot have microprofile-config.properties and application.properties file in the same project". We could have too a code action (quick fix) which provide "delete application.properties and copy properties in the microprofile-config.properties " (we should just check that LSP protocol can manage a delete file (@fbricon are you aware with that?)

See PR at redhat-developer/quarkus-ls#140 (comment)
You can configure the port in application.properties with
quarkus.http.port=9090. In this case, the Codelens URL will display this port. The CodeLens is managed by the JDT LS extension because we need the Java AST to get the proper JAX RS method.

okey, but this feature seem to be useful for a bunch of other tech (like any jax-rs app) so I reckon this feature would need to be able to look in multiple locations anyway  :)

lets just keep this simple. the editor should work on any of these property files imo; no need to treat them differently at this stage.
wether we are interested in adding hard or even soft validation of what kind of properties are in them I'm +0 on as with custom config sources I don't see how we can even validate based on filename what is expected or not.

I got a +1 from @dmlloyd as well. Waiting to get feedback from @kenfinnigan.

If consensus is to align them, I’m ok with that
Sent from my iPhone

On Jan 8, 2020, at 17:00, John Clingan<EMAIL_ADDRESS>wrote:

I got a +1 from @dmlloyd as well. Waiting to get feedback from @kenfinnigan.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Taking a look at other MicroProfile runtimes out there, it looks like they allow any property in any supported config source, but there is an order of precedence/priority. For quarkus, my tests (dev & prod modes) show that properties in application.properties overrides anything in microprofile-config.properties. I think that order is appropriate and supporting both simultaneously is proper behavior. @maxandersen, @kenfinnigan, @dmlloyd, agreed?

OK, @angelozerr, via various methods we have come to an agreement. Here are the details;

As a baseline, microprofile-config.properties editing should have the same behavior as application.properties. The only difference is the filename.
Both application.properties and microprofile-config.properties can exist in the same project at the same time (FYI: application.properties takes precedence).
Not immediately required but an additional nice feature would be yellow underlining of properties that are being overridden (or are overriding) the same property from another config source. For example, if quarkus.http.port is in both the microprofile-config.properties and application.properties, then the yellow underline message in microprofile-config.properties should be that it is being overridden by application.properties, and in application.properties, there should be a message that it is overriding the same property in microprofile-config.properties. Ditto for other config sources like:  system properties ("-D"), env variables, application.properties, and microprofile-config.properties in that order of precedence (system property the highest priority) . I guess throw application.yaml in there too when tooling is ready. We don't have to get into custom or dynamic config sources.

@jclingan thank a lot for your detailed and very clear comment. We could start to manage microprofile-config.properties like application.properties which should not be hard.

Thanks  Angelo. When this is done, I can open a separate issue for the third bullet (underlining) when this issue is complete. I just wanted to give you a bit of direction of where we could go.

Thanks Angelo.

When this is done, I can open a separate issue for the third bullet (underlining) when this issue is complete. I just wanted to give you a bit of direction of where we could go.

I will do that soon. You can new create an issue about the third bullet


wiki home page broken links

Describe the bug
Wiki home page still referencing broken link such as (https://ibm.github.io/FHIR )
Environment
wiki
Expected behavior
Broken link should be fixed. And also LinuxForHealth renaming needed.

@berkant-k Thanks for letting us know. We're working our way through these rebrand issues and will endeavour to get this fixed for our next release/release candidate.

I pushed an update to fix all the broken links and finish the renaming on the wiki.


Added Border and Hover Effect to "Book Your Trip" Section

Fixes:  #(issue no.) #1006
Description
Issue is solved..
here is the video you can easily see the changes...
Uploading Untitled video - Made with Clipchamp (10).mp4…
Sorry for the delay...
Please review this and merge..
Thankyou

@ShaikHafiza Please see the conflicts .

@ShaikHafiza Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Tilde in Sign Column

How do I get rid of the tildes in the sign column? I was able to set fillchars = ' ' before but that doesn't work when using the foldtext plugin.

You mean something like this?

Also,
You should be doing something like this.
vim.o.fillchars = "eob: ,fold: ";

And not
vim.o.fillchars = ' ';

Also, You should be doing something like this.
vim.o.fillchars = "eob: ,fold: ";

And not
vim.o.fillchars = ' ';

You're right. I do have "eob" in my options but not "fold". Thanks for your help, and thanks for the plugin!


[BUG] After updating to 0.5.0 only the Parts tab is shown

@G-Pereira Are other tabs enabled?

@G-Pereira did you stop the server before performing the update? Try restarting the server process

@SchrodingersGat I didn't, but afterward I always reboot the system and this time was no exception.
@eeintech That did the trick weird how the update changes a thing like that. @SchrodingersGat was that intentional?

Also I've noticed that enabling Sales orders does not enable Sales so enabling SO without enabling Sales is pointless.

This is not an intended behavior, no. It needs addressing.

@SchrodingersGat It happened to me too... see #2014 (this is a duplicate)

Oh you've meant the database engine, MySQL

Ok I don't know why it would but there could be in relation to the type of backend... it's quite rare error though and not reproducible...

@SchrodingersGat I would say revert #1999 and leave this behind us.


(test) rewrite of split_bash_parsing and added unit test

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Rewrite of the said method. With extra unit test file.

Give a summary of what the PR does, explaining any non-trivial design decisions
See unit test for method's capabilities.

Seems like the rewrite needs more tweaks itself... Set to draft.

Closing, tests were picked up in other PR.


Merge development to main

@rogervankanten  There are two tests failed related to mamba, could you help check why is it?


Change font size in Vs settings

Code search is so good!
but I want to change it font size!
This may be a place to say!

Sounds like a reasonable request :)

This should be fixed with 0.9.15. Please re-open if not addressed.


Added support for Swift version 4

I personally use this library and there was an opened issue #43 so I resolved the issue by providing support for swift version 4. Thanks

For objective-c, the example in README needs more @objc like this https://github.com/Jasonlhy/EPSignature/blob/master/Pod/Classes/EPSignatureViewController.swift


CORS ERROR

I wish to use your API on my project. However, my requests keep getting blocked due to a CORS policy.

Hi @Christone007
Thank you for reporting this.
The API is configured with cors, so there shouldn’t be any CORS issues by default. Could you please share the exact error message and details of your request?


bumped scala to 2.12.0

akka-http is undergoing some versioning changes (alongside a repo separation, see https://github.com/akka/akka-http/issues/3). OTOH, people may want to start using scala 2.12, hence this PR

Thanks for tracking the latest versions :)

More than happy to help out a bit :)

Thanks for the PR. Was waiting for the final release to do the bump.
@ktoso you have an ETA for the final release?


chore(api): Update API dev deps for cross-platform Python 3.6.4

(Edit: written by @mcous)
To prevent problems with robot update, we need to make sure that our development Python version and dependencies match production as closely as possible and that everything works cross-platform (because update files will be generated on multiple platforms).
The "cross-platform" part of things turned out to be terrible.
This PR threw a bunch of stuff at the wall to get stuff to stick:

Updated pipenv to 11.6.8 for numerous bugfixes
Updated pytest to 3.4.2 and locks coverage to 4.4.2 to fix weird pytest plugin bugs in Windows
Refactored use of pipenv

Removed --system option to allow pipenv to create a virtualenv
Limited use of --ignore-pipfile option to CI
Updated api/Makefile to use the virtualenv

Delegated prod dep versions to setup.py and lock them there

Also updated a few Python version callouts to 3.6

Generated Pipfile.lock on Ubuntu for safety

I spent a lot of time comparing lockfiles generated by<EMAIL_ADDRESS>and windows
It appears the lockfiles are completely cross-platform now, so:
We probably don't need to do this moving forward

Anyway, API install, dev, and test tasks are all passing on my macOS 10.12, Windows 10, and Ubuntu 14.04. Please verify on your machines as well:

Ensure you have an install of Python 3.6

*nix - pyenv install 3.6.4
Windows - choco install python --version=<IP_ADDRESS>80116 --yes

Uninstall pipenv if you have it for safety - pip uninstall pipenv

This won't be necessary if (1) was a new install

Run top level install task - make install
Run API level test make test-api or make -C api test
Run API level dev task - ENABLE_VIRTUAL_SMOOTHIE=true make -C api dev

Probably run the app dev task, too: make -C app dev

P.S. I'm going to squash this PR before merging

pipenv run appears to be swallowing SIGINT on Windows?? Trying to build a simple repro

Been doing some research, and I actually can't get ctrl-C to work with make dev on Windows on edge...make quits but the process is left running. If I try running the process without make ctrl-C does nothing at all (same behavior with and without pipenv). @btmorr or @Laura-Danielle have you experienced this? Not only can I not get it to work, I can't even get the aiohttp hello world to quit with ctrl-C on Windows...
# server.py
# tested on python==2.6.4, aiohttp==2.3.8 and aiohttp==3.0.7
from aiohttp import web

async def hello(request):
    return web.Response(text="Hello, world")

def init(loop=None):
    app = web.Application()
    app.router.add_get('/', hello)
    return app

web.run_app(init(), host='localhost', port=8080)

This would seem to indicate that ctrl-C misbehavior on Windows is not a regression introduced by this PR, so I would be inclined to merge and move forward

After talking with @btmorr, confirmed that ctrl-C problems on Windows are not a regression and likely an underlying issue with aiohttp or asyncio


⚠ ClamAV has degraded performance

In 522fc06, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 49 ms

Resolved: ClamAV performance has improved in 6143bb6.


Support Wagtail 3.0

Ticket: https://projects.torchbox.com/projects/support-team/tickets/491
Make the current package support Wagtail 3.0.
I selected some changes from this MR, then added Wagtail 3.0 changes
https://github.com/wagtail/wagtail-factories/pull/50

Drop Python 3.6 (EOL)
Drop Django 2.2 (EOL), 3.1 (EOL)
Drop Wagtail 2.11 (EOL), 2.13 (EOL), 2.14 (EOL)
Drop factory_boy <3.2
Add Python 3.10
Add Django 4.0
Add Wagtail 2.15 LTS and 2.16 and 3.0

Hi @mvantellingen ,
I wonder if this can get merged and have a release?


API for Efficient Stream of Ion Values

We have an IonReader trait that captures both the "iteration" over the stream and the value the stream is currently on.  This is a fine API, but there are cases (especially when we start to think about macros in Ion 1.1), that this API becomes difficult to compose on.  I propose we create an API that de-couples the stream from the value without while deferring computation on the value it is on.
At a high-level, the API might look something like this:
pub enum Instruction {
  /// Advance to the next token.
  Next,
  /// Skip to the end of the current container
  NextContainerEnd,
}

struct AnnotatedToken<'a>{ ... }

trait TokenStream {
  fn next_token(&mut self, instruction: Instruction) -> IonResult<AnnotatedToken>;
}

The above is quite a simplification, but it demonstrates the basic structure.  AnnotatedToken would represent the next token deferring computation on a field name, annotations, or the underlying scalar value, the beginning of a container, end of the container, or the end of a stream.
It would be straightforward to adapt this TokenStream wrap any IonReader (though some care would have to be done to model this on both user-level/system-level/raw-level variants to do it generically), and the other direction should be relatively straightforward as well (make any TokenStream into an IonReader.   The latter gives us TokenStream to Element.

A draft version of a tokens module can be found here:
https://github.com/almann/ion-rust/tree/c25531f59667cbf17420470f9a2e8963db96fc9d/src/tokens
The thunk that underlies this can be found here:
https://github.com/almann/ion-rust/blob/c25531f59667cbf17420470f9a2e8963db96fc9d/src/thunk.rs


Boolean values?

It might be better to avoid using integers as if conditions, etc.

Candidate syntax for Boolean literals: !t, !f. Or change to Scheme/Racket style (#t, #f) and change comments to something else (e.g. // comments).

To keep a small core, use integers (later may change to rationals).


add support for sqlite3

I'm going to try and update my branch with some of these changes.

@jcormier can you verify that we have already sqlite3 support i saw it in the database adapters if so i think we can delete this here?

conflict resolution
RUN apt-get update \
 && DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y \
      supervisor logrotate nginx mysql-client postgresql-client ca-certificates sudo tzdata \
      imagemagick subversion git cvs bzr mercurial darcs rsync ruby${RUBY_VERSION} locales openssh-client \
      gcc g++ make patch pkg-config gettext-base ruby${RUBY_VERSION}-dev libc6-dev zlib1g-dev libxml2-dev \
      libmysqlclient20 libpq5 libyaml-0-2 libcurl3 libssl1.0.0 uuid-dev xz-utils \
      libxslt1.1 libffi6 zlib1g gsfonts vim-tiny sqlite3 libsqlite3-dev \
 && update-locale LANG=C.UTF-8 LC_MESSAGES=POSIX \
 && gem install --no-document bundler \
 && rm -rf /var/lib/apt/lists/*

I implemented a version of sqlite3 support in the sqlite3 branch, mentioned at #350.  Was never merged in since it was missing backup/restore support.
Closing this pull request since we have our own copy of the changes.


Extend calnex tool to report firmware upgrade progress

Summary: Update API to add type for instrument/status response, add API method for get instrument status and add test. Update firmware to call instrument/status endpoint and check if progress is not -1.
Differential Revision: D44715461

Codecov Report
Patch coverage: 37.03% and project coverage change: -0.08 :warning:

Comparison is base (db316f9) 58.68% compared to head (6d2d435) 58.60%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   58.68%   58.60%   -0.08%
==========================================
  Files         129      129
  Lines       11556    11580      +24
==========================================
+ Hits         6782     6787       +5
- Misses       4223     4238      +15
- Partials      551      555       +4

Impacted Files
Coverage Δ

calnex/firmware/firmware.go
31.25% <11.11%> (-5.34%)
:arrow_down:

calnex/api/api.go
63.56% <50.00%> (-0.81%)
:arrow_down:

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


SW-25604 - Added support to display unit and unit name in article list component

1. Why is this change necessary?
customers want to see units in the product list
2. What does this change do, exactly?
display unit and unit name of each product
3. Describe each step to reproduce the issue or behaviour.
if you want to select the units in the article list there are any.
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/SW-25604
5. Which documentation changes (if any) need to be made because of this PR?
none
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Why does the check failed?

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-25708
Please use this issue to track the state of your pull request.

Did I forgot something or why its still marked as "Incomplete"?

@h3llj0ck3y it isn't marked as incomplete? :thinking:

Hehe. Sorry my fault. Great, thanks for the Quick-Pick. :D

Thanks for your Contribution! :blue_heart:


Dataset Mgmt Certificate test clean up

Fix bug of reading commissioner session id after rx MGMT_ACTIVE_SET/MGMT_PENDING_SET
Restore ML16 address after modifying meshlocal prefix if the node keeps attaching
Fix bug of THCI

Current coverage is 69.43% (diff: 25.00%)

Merging #739 into master will increase coverage by 0.05%

@@             master       #739   diff @@
==========================================
  Files           102        102
  Lines         15487      15490     +3
  Methods        2110       2110
  Messages          0          0
  Branches       1851       1852     +1
==========================================
+ Hits          10746      10756    +10
+ Misses         4157       4154     -3
+ Partials        584        580     -4

Powered by Codecov. Last update a6d2f19...a14052b


Add tests for fast FP atomics

The use of hint is necessary because the compiler cannot determine all cases in which using fast FP atomics is safe. In particular, it is only safe to do so on coarse grain memory pages, which are enabled for mapped items as in this PR:
https://github.com/ROCm-Developer-Tools/llvm-project/pull/149
Under USM mode, when a pointer is not mapped, it can still be used in a target region, but its pages could be managed as fine grain memory. Fast FP atomics on fine grain memory is a no-op, which is not what the user of atomic would want.

Running the first four tests on MI100 shows that there is no performance difference for single-precision floating-point add.
Success atomic sum of 5001 double's using CAS loop is: 12502500.000000 in 0.561011 secs
Success atomic sum of 5001 float's using CAS loop is: 12502500.000000 in 0.006414 secs
Success atomic sum of 5001 double's using fast FP atomics is: 12502500.000000 in 0.006381 secs
Success atomic sum of 5001 float's using fast FP atomics is: 12502500.000000 in 0.006408 secs


New version: CryptoGroups v0.6.1

Registering package: CryptoGroups
Repository: https://github.com/PeaceFounder/CryptoGroups.jl
Created by: @JanisErdmanis
Version: v0.6.1
Commit: 4648c74ccac6392ba19b5cb9df92edd726c3bcd0
Reviewed by: @JanisErdmanis
Reference: https://github.com/PeaceFounder/CryptoGroups.jl/commit/4648c74ccac6392ba19b5cb9df92edd726c3bcd0#commitcomment-148716735
Description: Groups for cryptographic applications

I have a few changes. Let's block then.


Merge/upstream merge 6 oct 2017

Important upstream stuff we probably want in this merge:

React 16 support
PropTypes clean up so we stop getting deprecation warnings
Less annoying RFC/PR templates :)

http://seek-asia-style-guide--5428123c85c20191c3be5dc3fa7ac11aec2ae493.surge.sh


[IOU] At power-on, POC and RESET_N are not valid.

At power-on, POC remains HIGH and RESET_N goes immediately High-Z.
Expected behaviour is:

POC should remain HIGH for ~2.4 ms, then driven LOW.
RESET_N should be LOW while POC is HIGH, remain LOW until the video scanner overflows (TC=1), then driven High-Z on the next PHI_1.

Fixed by https://github.com/frozen-signal/Apple_IIe_MMU_IOU/pull/2


Visual Studio integration does not work correctly with projects on UNC paths

I run vcpkg at work, where we use folder redirection from a server for the documents folder. VCPKG's integration does not seem to handle this, and gives the following error.
error MSB3021: Unable to copy file "Microsoft.PowerShell.Core\FileSystem::\SERVER\Folder Redirection\USER\Documents\Concurrency Camp\CppAsync\Debug\libuv.dll" to "\SERVER\Folder Redirection\USER\Documents\Concurrency Camp\CppAsync\Debug\libuv.dll". The given path's format is not supported.

@ThadHouse, do you have a chance to double confirm it?

I'm so sorry I forgot to test. I have easier access to shares so I'll give it a quick try tomorrow.

I just double checked with the latest build, and yes this is still a problem. I get the same error.

@ThadHouse, thanks for confirm this problem!


Translated pdf instructions to Spanish. 2. Added clarification to …

…write initials inside parenthesis. 3. added periods to instructions. 4. subbed parents to parent(s)/legal guardian(s) in English instructions. 5. subbed (initial) for (write their initials) in English instructions. 6. added instructions to print two copies.

Awesome! Thanks @paulo-g-martinez !

Looks like it failed linting. The errors look like the can be fixed with yarn run lint:fix.
You can see the errors by looking at the details for the travis ci build above.
Once it passes, it can be merged.

I might also recommend that "el / Los"  on items 3&4 are changed to "el/los" (remove capital).

Right. Sorry about that. I hadn't ever worked with yarn or js before but I think I got it figured out. Let's see if this one works. It's working locally.

decapitalized "el/Los" to "el/los"
ran: yarn run lint:fix
(btw I had to "downgrade" my node. I think the default brew install yarn set me up with version 10.something.)


Chinese or other foreign domains get seen as invalid

Issue summary
Domain: 漢字4.bbtest.net
Is being seen as invalid domain
Error I'm getting:
The host ??4.bbtest.net is invalid: it contains invalid characters.
System informations
(In case of a bug report Please complete the table below)

Information
Description

Pdp version
6.1

PHP version
7.4

OS Platform
Ubuntu 22.04

Standalone code, or other way to reproduce the problem
<?php
    use Pdp\Rules;
    use Pdp\Domain;

    class DomainParser {
        private $publicSuffixList;
        private $domainInfo;

        function __construct() {
            file_put_contents("public_suffix_list.dat", file_get_contents("https://raw.githubusercontent.com/publicsuffix/list/master/public_suffix_list.dat"));
            $this->publicSuffixList = Rules::fromPath('public_suffix_list.dat');
        }

        function parseDomain($domain) {

            $parsedDomain = Domain::fromIDNA2008($domain);

            $this->domainInfo   = $this->publicSuffixList->resolve($domain);
            $rootDomain         = $this->domainInfo->registrableDomain()->toString();
            $subDomain          = $this->domainInfo->subDomain()->toString();

            return array(
                'rootdomain' => $rootDomain,
                'subdomain' => $subDomain,
                'domain' => $this->domainInfo->domain()->toString(),
                'suffix' => $this->domainInfo->suffix()->toString(),
                'secondleveldomain' => $this->domainInfo->secondLevelDomain()->toString(),
                'registrabledomain' => $this->domainInfo->registrableDomain()->toString(),
                'suffix_iana' => $this->domainInfo->suffix()->isIANA()
            );

        }
    }
?>

Using this part to get the result, it's in a try catch clause ofcourse.
<?php
    require "vendor/autoload.php";
    use Pdp\Rules;
    use Pdp\Domain;

    include("app/classes/DomainParser.php");

    $domainParser   = new DomainParser();
    $domain = "漢字4.bbtest.net";

    try {
        $parsedDomain = $domainParser->parseDomain(mb_convert_encoding($domain, 'ISO-8859-1','utf-8'));
    } catch(Exception $e) {
        echo $e->getMessage();
    }

?>

Expected result
Look at the array it returns.
Actual result
Look at the array it returns.
Is this fixed in the latest version?

Alright nevermind, seems that converting it to ISO 88591 and UTF8 is the issue.
I used to import the data into mongo, and mongo was the one complaining about strange chars.
So once removing mb_convert_encoding, it'll work.


The Quarry touch controls

Added touch controls for The Quarry.

No worries, I'll revise it.

Just updated the layout.

Do the X and Y buttons do anything?

Only for QTE events

I thought QTE events only use analog sticks and A button? https://www.trueachievements.com/game/The-Quarry-Xbox-One/walkthrough/2

I'll amend the layout

The X button is used in the menus, so I'll add it to the top row

Both X and Y buttons are needed for menu
Maybe putting LB and RB on the same side? (left)
LT buttond does nothing
Update the position of A & B buttons, make them feel more natural to press

Let me handle the rest

Maybe something like this?

Like this. You don't need the inventory button.

Thanks!

Thanks for finishing it. Really appreciate it.


Possible to use WebdriverIO helper independently?

Hello! I really love the API allowed by your WebdriverIO helper. Is it possible to use just that wrapper outside of CodeceptJS?

You may try :)
I think you can import the module of WebDriverIO, create an instance of class and use it. Just don't forget to call before/after/init hooks in order to make it work


Video Samples v1

Update Video samples for v1

Bump google-cloud-video_intelligence to 0.25.0
Update Quickstart
Update Label Detection sample
Update Label Detection with local file sample
Updated Shot Change sample
Removed Face Detection sample
Removed Safe Search sample
Added Explicit Content Detection sample
Updated specs and README

Test "can analyze labels from a local file" hangs.

The Video specs pass!


org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find horologist:base-ui:unspecified.

Bumping versions causes this error: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find horologist:base-ui:unspecified.
When changing:
implementation 'com.google.android.horologist:horologist-media-ui:0.1.15'

to:
implementation 'com.google.android.horologist:horologist-media-ui:0.2.0'

I'm using these Horologist dependencies:
implementation 'com.google.android.horologist:horologist-compose-layout:0.2.0'
implementation 'com.google.android.horologist:horologist-audio:0.2.0'
implementation 'com.google.android.horologist:horologist-audio-ui:0.2.0'
implementation 'com.google.android.horologist:horologist-media:0.2.0'
implementation 'com.google.android.horologist:horologist-media-ui:0.2.0'

Thanks for reporting it, we also noticed it and released version 0.2.1 with the missing module.
Please try that version and let us know if you are still having issues.


[CHECKLIST] MP-ECDSA Protocol

Code from the dkg-gadget crate of the dkg-substrate repo must be refactored inside the new gadget/protocol model provided by this repository to create a more robust, maintainable, and streamlined implementation.
Since the dkg has two types of protocols (keygen and signing), we can run two different protocols via webb_gadget::run_protocol selected twice, sharing some state that allows the signing to use the keygen's output public key. Thus, this task will include these two different phases.
Phase I: Keygen Protocol

[x] #27
[x] #28

Phase II: Signing Protocol

[x] #29
[x] #30

Ideally, there would be no need for an in-memory shared state between the KeygenProtocol and the SigningProtocol. Instead, we would use the off-chain storage as we currently do in the DKG to fetch keys for a specific session.
Since the function webb_gadget::run_protocol also requires a connection to a blockchain and a network implementation, we will also need to complete the following tasks:
Phase III: Networking

[ ] #31
[ ] #32

Note: the client should be identical between the keygen and signing protocols. The network will be nearly identical, the only difference being that the underlying network stream will be multiplexed to split signing and keygen messages.
Next, the two protocols for keygen and signing will need to be put together as such:
let keygen_protocol_future = webb_gadget::run_protocol(keygen_gossip_network, keygen_protocol, blockchain_connection.clone());
let signing_protocol_future = webb_gadget::run_protocol(signing_gossip_network, signing_protocol, blockchain_connection);

tokio::select! {
    res0 = keygen_protocol_future => res0,
    res1 = signing_protocol_future => res1,
}

Thus, this step of tying together the two protocols and creating a program entrypoint with a main function will need to be encapsulated in an additional step:
Phase IV: Application Binary

[ ] #33

Finally, everything must be tested:
Phase V: Testing

[ ] #34
[ ] #35

Reopening this checklist, as there are a few tasks that needs to be done first to complete the whole workflow.


Added arm64 runtime support, reusable runtime stack.

Issue #, if available:
Description of changes:
Added support for the custom runtime using the arm64 pwsh runtime.
Added an example for publishing the layers for x86_64 pwsh runtime, arm64 pwsh runtime, and x86_64/arm64 AWS.Tools.Common layer.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Replaced with a WAY better PR...


Analyse and implement rate limiters

To reduce overloading the server and prevent potential exploits it is important to think about rate limiting the API.

Each API end-point needs to be looked at for a potential rate limiter.
As well as API routers and the global API.
Each rate limiter needs to be checked for its appropriate parameters. (How many requests per time frame is allowed)?
The rate limiters need to be implemented.
The rate limiters need to be tested.

Info on rate limiters by Google
https://cloud.google.com/architecture/rate-limiting-strategies-techniques
https://cloud.google.com/armor/docs/rate-limiting-overview
Info on rate limiters by Facebook
https://developers.facebook.com/docs/graph-api/overview/rate-limiting
https://developers.facebook.com/docs/marketing-apis/rate-limiting

New rate limiters have been added in commit 96cc8dd8610e92baf000a85925ce32c05ba57b85
But the issue will remain open, because new API end-points will be added in the future.


° not interpreted correctly as º

360° when interpreted should show up as 360° , but shows up as the original text

@ds949 Could you please create a plunker.

@ds949 I thinks something wrong with your app css. It's working fine for me. Please check it again.

Closing this issue. Feel free to re-open it if your issue still not resolve.


Kick off release v1.18.6

Kick off release v1.18.6
Signed-off-by: Ryan Hamilton<EMAIL_ADDRESS>

/assign @yanavlasov


Sure. A lot of the links are broken because they need to be made relative. If you have any questions about what to link to just post them here.

@Min2who are you still working on this one ?


Fix formatting of allowed values

Before
Error: type cat is not valid. Possible values are: adjectives, colours, dogs, gladiators, greek, marvel, materials, `trees
After
Error: type cat is not valid. Possible values are: adjectives, colours, dogs, gladiators, greek, marvel, materials, trees

Haha, thank you. I found that annoying when I spotted it last week but not enough to fix 🙏


Fix error handling in CRYPTO_dup_ex_data in 1.0.2

This is what remains from this for 1.0.2.
Checking of the return value from the dup_func
is not really necessary there IMHO.

Merged. 62f488d31733e5dc77b339f905b44f165550e47d


[Feature Request] - Setting tabs aside

Would be great to bring back this feature as well. No need to save the current states of apps, just launching them in one window would be enough.

Do you mean set tabs aside feature like Microsoft Edge legacy?

If setting tabs aside means just hiding those tabs temporarily like MSEdge legacy, then it is not very hard to implement.
If it requires relaunching apps, or saving and reloading tabs when United Sets is closed, #10 might be needed for this issue.
I'm not sure which one you mean. Can you clarify?

Yes I mean the Edge Legacy feature.
But Edge Legacy didn't hide the tabs, it saved them, you could turn the PC off and still restore them afterwards. There is a faithful copy of this feature as an extension for Chrome, you can check how it works:
https://github.com/xfox111/TabsAsideExtension
So the two ways you described are the same. I just propose saving/restoring not only browser tabs but apps as well, i.e. the second option. Maybe even syncing them between devices like the aforementioned extension does.
For example, I create a school project and group a word document, some edge tabs and some unknown app. Then I set it aside for a month, can turn the PC off and etc. After that, pressing restore should open that exact document and those tabs, but for an unknown app it could just reopen it from scratch if saving its state was not possible.

Oh sorry I forget how it works. Thanks for clarification. To make implementation easier, I think I will implement like this.

When setting tabs aside, just hide the window and you can get the window back instantly at the state it is in (assuming the app does not do some crazy stuff when it is hidden)
if you close United Sets and reopen the next time bringing those tabs back will rerun the apps.

The reason I do not Closing window is not easy

Sorry accidentally pressed the  button

Implementation steps

[ ] Setting tabs aside but does not save the tabs when we close the app
[ ] Implement #10
[ ] Full setting tabs aside implementation

That was also a problem in edge legacy, when websites wanted something saved, e.g. inking. Edge just set aside all other tabs and kept these. Not an elegant solution, but there is some logic.
Also a small thing: when setting group aside, it didn't hide the entire window, but left a "start page" tab so that you could easily switch between saved groups.

I would say that the page when the app is opened with no tabs open to be "start page"

Anyways, we plan to work on #12 first then we might take a look at this afterward. This is because the tab system is going to be changed, and the way to store data will also need to be implemented for those changes.
Implementation on #12 is expected to not take more than a week.
Note: Even though I overestimated the time needed by a lot, I do not guarantee that statement.

Good News! I finished implementing the first mockup. This does not save if you close and reopen the app.

However, in order for me to continue as I say, I need to implement #10
Therefore, I added "base feature for enhancement needed" tag, meaning that I will continue to implement this after #10 is implemented.

Could be implemented soon since #47 was merged


Stopped working with newest version of Youtube

The latest YouTube update broke this great module. The app updated to version 10.11.55 on March 27th. I tried updating to the newest version of this module (1.3.7 at the time of this thread) but the notification doesn't even appear when selecting a video as it did before the YouTube update.
I'm on a rooted HTC One M8 with android version 4.4.4 Kit Kat!
Cheers

Not gonna to check this since we have newer update 10.12.

 The latest one I can download from Google Play is 10.11.55, I can't download 10.12:

Now if you are saying that the module works fine in 10.22, point me in the direction of the YouTube apk in that version and I will try to install it and report back. As is, it is broken.

Google "apkmirror youtube"

Of course I had already found that mirror, but here is the latest there:

You referenced 10.22, not 10.12.53 which seems to be the latest here. I shall attempt to install 10.12.53 and test!
Cheers

I never mentioned 10.22.

You should not install x86 version, install normal arm one.

So I installed the latest 10.12.53, but there is no change, even after reboot. The HTC One M8 is an extremely popular phone so I'm wondering why others haven't spoken up about this issue..
Thank you for your responsiveness...I just love the feature and was disappointed when it stopped working. No doubt it is Google trying to prevent this since it is a pay-for-"feature" in YouTube now  :-/

After installing 10.12 on my HTC One M8 ,Its perfectly working !!

On you on Lollipop by chance?

Yes I am on L Viper Rom

Ok Good to know. I ended up getting this to work, but I had to uninstall all YouTube updates, then uninstall this module, reboot, re-install both, reboot, then activate the module, reboot.
After that sequence the module is working :+1: but I do have the same bug as @troidem with the X only removing the notification, but not actually stopping the track from playing. Honestly, this may have been the functionality from past versions but I'm not sure. I can always stop by pausing it from the notification first and then tapping the X to remove the notification. Thanks guys.


No host route for GIF remote address if gateway is IPv6 link-local

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
When setting up a GIF tunnel, a host route for the remote address is supposed to be created (using the gateway of the selected parent interface):
https://github.com/opnsense/core/blob/40a64dc9f535254057d1c25778a7c6054f959b2e/src/etc/inc/interfaces.inc#L667
This works if the gateway has an IPv4 address or IPv6 GUA / ULA. But the route doesn't get created if the gateway address is IPv6 link-local (as is common for IPv6 gateways).
The root cause is probably here, where nothing seems to be returned if the gateway is IPv6 link-local:
https://github.com/opnsense/core/blob/40a64dc9f535254057d1c25778a7c6054f959b2e/src/etc/inc/interfaces.inc#L642
I don't know since when this issue exists, didn't have such a setup before.
To Reproduce
Steps to reproduce the behavior:

Go to 'Interfaces: Other Types: GIF' and add a new tunnel. 'Parent interface' must have a link-local IPv6 gateway, 'GIF remote address' must be IPv6.
Go to 'Interfaces: Assignments' and assign the new tunnel interface.
Go to 'System: Routes: Status'.
See error: No host route for GIF remote address.

Expected behavior
A host route for the GIF remote address should be created.
Environment
OPNsense 22.7.r1_8 (amd64, OpenSSL)

@maurice-w for now I'm not sure what's wrong. I have a similar setup but I get a link local gateway and the route command fails:
/interfaces_gif_edit.php: The command '/sbin/route add -host -'inet6' 'GUA' 'LL'' returned exit code '1', the output was 'route: writing to routing socket: Network is unreachable add host GUA: gateway LL fib 0: Network is unreachable'

Which might be true... do we have to force host routes to interface here because of LL/GUA mismatch?

It works when I add the route manually like this:
route add -host -inet6 2001:db8::1 fe80::1%hn0
Specifying the interface (%hn0) is indeed mandatory for link-local gateways.

ok, thanks for the hint. will fix :)

let me know if this works for you 575c8a5233d5867ca7, but it does look good here

This works indeed. Thanks for the quick fix!


Support passing a user-defined state value to AuthCodeURL on public clients

Related to #485, #227, and #407.

Why do you need to pass in your own state on public client? MSAL should perform both legs (authorization call and token call) on public client.
I can understand this scenario for confidential client, where you need MSAL only to generate the auth code URL, redirect the user there and then MSAL calls AcquireTokenByAuthCode

Maybe it isn't needed. I'm using the confidential client and needed it. I started working on it before seeing #485 was sitting there. I had done both sides since the functionality appeared similar, so I figured I might as well submit it.

Why do you need to pass in your own state on public client? MSAL should perform both legs (authorization call and token call) on public client.
I can understand this scenario for confidential client, where you need MSAL only to generate the auth code URL, redirect the user there and then MSAL calls AcquireTokenByAuthCode

Agreed with what @bgavrilMS said.
Also want to add that some MSALs historically have the generate auth url function even in public client, and it looks like MSAL Go does. So, technically we could have added state support for that legacy function. But perhaps we shouldn't bother, and just deprecate that function and ask app developers to use public client's interactive function instead. If you would also agree, let's close this PR and close issues that are public-client-only as wontfix.


download link updates

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/debugger/debug-live-azure-applications.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Mikejo5000 looks like maybe we shouldn't merge this until Monday when 15.5 releases?

@gewarren Yes, it's for the 15.5 release. I approved it, but put the don't merge label on it.


e2e test fast api version error when running locally

Bug report
Description of the bug

When running e2e test in the terminal from dashboard-e2e package, the following error occured.
pkg_resources.ContextualVersionConflict: (fastapi 0.65.2 (/home/chawin/rmf-web/.venv/lib/python3.8/site-packages), Requirement.parse('fastapi~=0.63.0'), {'api-server'})
[2]
[2] During handling of the above exception, another exception occurred:
[2]
[2] Traceback (most recent call last):
[2]   File "/home/chawin/rmf-web/.venv/bin/rmf_api_server", line 6, in <module>
[2]     from pkg_resources import load_entry_point
[2]   File "/home/chawin/rmf-web/.venv/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3243, in <module>
[2]     def _initialize_master_working_set():
[2]   File "/home/chawin/rmf-web/.venv/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3226, in _call_aside
[2]     f(*args, **kwargs)
[2]   File "/home/chawin/rmf-web/.venv/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3255, in _initialize_master_working_set
[2]     working_set = WorkingSet._build_master()
[2]   File "/home/chawin/rmf-web/.venv/lib/python3.8/site-packages/pkg_resources/__init__.py", line 570, in _build_master
[2]     return cls._build_from_requirements(__requires__)
[2]   File "/home/chawin/rmf-web/.venv/lib/python3.8/site-packages/pkg_resources/__init__.py", line 583, in _build_from_requirements
[2]     dists = ws.resolve(reqs, Environment())
[2]   File "/home/chawin/rmf-web/.venv/lib/python3.8/site-packages/pkg_resources/__init__.py", line 772, in resolve
[2]     raise DistributionNotFound(req, requirers)
[2] pkg_resources.DistributionNotFound: The 'fastapi~=0.63.0' distribution was not found and is required by api-server

Steps to reproduce the bug

Go into packages/dashboard-e2e folder
Run npm run test

Additional information

Updating the Pipfile to add fastapi = "~=0.63.0" to [packages] or pipenv install 'fastapi~=0.63.0' and making sure that port 8000 is not in use (lsof -i TCP:8000 | grep LISTEN) allows the e2e to run correctly. but I'm still not sure why it is this way because the dependency of api-server does not need to change.
Pipfile
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
fastapi = "~=0.63.0"

[dev-packages]
black = "==20.8b1"
isort = "~=5.8"
pylint = "~=2.7"
coverage = "~=5.5"
# api-server
api-server = {editable = true, path = "./packages/api-server"}
requests = "~=2.25"
# reporting-server
reporting-server = {editable = true, path = "./packages/reporting-server"}
# ros-translator
ros-translator = {editable = true, path = "./packages/ros-translator"}

[requires]
python_version = "3.8"

Adding the fastapi package to [dev-packages] will cause the confict error to appear
pkg_resources.ContextualVersionConflict: (fastapi 0.65.2 (/home/chawin/rmf-web/.venv/lib/python3.8/site-packages), Requirement.parse('fastapi~=0.63.0'), {'api-server'}

Older versions of fastapi had a security vulnerability so it needs to be updated, try clearing the .venv dir and running bootstrap again.

Solved by clearing .venv


Fixes for nextcloud 25

Currently this breaks the test-suite for the CRUD test.
Not yet sure if this is caused by the URL not being present in the addressbook or the PUBSUB_URL not being set. I'll need to check the setup to make things pass.


Improve support for zsh and possibly other shells

tsu invokes the user's selected shell by running the symlink ~/.termux/shell.
zsh checks the name of the symlink to determine what compatibility mode to use. shell causes zsh to start in sh compatibility mode, which is usually not desirable.
Other shells may have similar detection mechanisms in place (bash has one, but it does not trigger on shell).
This pull request makes tsu resolve the symlink and invoke the user's selected shell directly. This fixes the issue for zsh and possibly other shells, too.

Is readlink installed by default on Termux?

It's in busybox as well as coreutils. Busybox, I believe, should be present in every Termux installation.

Sorry for the late merge.
I didnt had time for Android stuffs.
Can you please try the latest tsu from master branch after this merge..
and see if everything is working?


JCMediaManager.textureView leaks context

JCMediaManager.textureView is a static variable instantiated from JCVideoPlayer. It holds a strong reference to a Context and is not destroyed unless you invoke addTextureView().
I'm not familiar with TextureView, but the easiest fix I can think of without rewriting the code is to move textureView to a WeakReference. This'd mean that we should check if it's null each time we were to use it. You can see an example of that in https://github.com/lipangit/JieCaoVideoPlayer/pull/535. I don't know if that would have consequences on the logic, I don't think so, but it should be tested.
As I've mentioned in previous issues and PRs, the whole project lacks encapsulation and proper visibility modifiers, which makes it a software architecture nightmare. Since this is really hard to fix, my recommendation would be to try to improve on future developments.

This is import for quality of code but not in hurry


Page result type throws error

Hello,
when returning Page from repository query, it's throwing an error. Either it's wrongly documented or it's a bug.
Sample application is here

Stacktrace (from Gitter thread)
Caused by: org.springframework.dao.IncorrectResultSizeDataAccessException: Incorrect result size: expected 1, actual 31 at
org.springframework.dao.support.DataAccessUtils.nullableSingleResult(DataAccessUtils.java:100) ~[spring-tx-5.2.11.RELEASE.jar:5.2.11.RELEASE] at
org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate.queryForObject(NamedParameterJdbcTemplate.java:237) ~[spring-jdbc-5.2.11.RELEASE.jar:5.2.11.RELEASE] at
org.springframework.data.jdbc.repository.query.AbstractJdbcQuery.lambda$singleObjectQuery$1(AbstractJdbcQuery.java:115) ~[spring-data-jdbc-2.0.5.RELEASE.jar:2.0.5.RELEASE] at
org.springframework.data.jdbc.repository.query.PartTreeJdbcQuery.execute(PartTreeJdbcQuery.java:98) ~[spring-data-jdbc-2.0.5.RELEASE.jar:2.0.5.RELEASE]

@schauder actually I think here is the error little bit different. Here I've tried to use newer spring boot so maybe something has changed.

Closing as duplicate of #774.


[metrics] v2 of metrics support using metric filters

to @austinbyers or @jacknagz
cc @airbnb/streamalert-maintainers & @mime-frame
size: medium
contributes to: #157
Background

After a v1 attempt in https://github.com/airbnb/streamalert/pull/247, it was discovered that the implementation had a major set back:

We quickly discovered that we were exceeding the 150 transactions-per-second allowed by CloudWatch's PutMetricData limits and thus were being throttled practically immediately.
This is more speculative, but the latency of calling boto3 with the metric data (exacerbated by being throttled) may also cause a slight increase in the rule processor invocation time.

Changes

Migrate to utilizing CloudWatch Metric Filters to allow for filtering CloudWatch logs for specific terms and extracting values from those log entries.
Metrics will now be compiled per-cluster and also sent to an aggregate metric that encompasses all clusters. For instance, the metric for S3DownloadTime will appear as:

RuleProcessor-S3DownloadTime (aggregate)
RuleProcessor-S3DownloadTime-PROD (prod cluster)
RuleProcessor-S3DownloadTime-CORP (corp cluster)

Logs with metrics will default to logging json using: json.dumps({'metric_name': metric_name, 'metric_value': value}), resulting in lines like:

[INFO]	2017-08-29T06:12:52.56Z	89bd8174-cc61-4e64-862b-4b084de2281f
{
   "metric_name": "TriggeredAlerts",
   "metric_value": 2
}

The new MetricLogger class can be extended to use non-default logging formats and specify different filter patterns/value lookup - but the defaults should cover most of our use cases for now.
Example of the new metrics, namespaced under StreamAlert in CloudWatch metrics:

Graph showing failed log parsing from data coming into 2 rule processors in different clusters:

Caveat(s)

We lose the ability to assign 'dimensions' to our CloudWatch metrics being posted, which allows for better segmentation of metric data in dashboard. For instance, we could break out metrics by functions name and cluster using dimensions.

The band-aid approach to make up for the lack of dimensions is prefixing metric names with the function name and adding a suffix for the cluster. We now will have metric names similar to: RuleProcessor-FailedParses-PROD

Testing

Deployed these changes in a test AWS account, utilizing a multiple cluster configuration to ensure all the metrics played well together.

Other

Migrating some logging instantiation to within init - this is most in preparation of moving all logging into the shared package in the near future

Upcoming

Doc changes to demonstrate how to enabled/disable metrics
CloudWatch alarm creation through the cli for any available metric filter.

Coverage decreased (-1.1%) to 93.864% when pulling<PHONE_NUMBER>a5a9c7a242fc536053b60e4112919d on ryandeivert-metric-filters into ef18fa232314c8aa6f74e26c8510638a5fa0cbd7 on master.

Coverage decreased (-0.5%) to 94.449% when pulling cba60e9cce6de3c8ecbd4c076e334ff50bb9b8fa on ryandeivert-metric-filters into ef18fa232314c8aa6f74e26c8510638a5fa0cbd7 on master.

Coverage decreased (-0.1%) to 94.853% when pulling 774cb16cde5a0518ed0ac53b5e61c006a9014be3 on ryandeivert-metric-filters into ef18fa232314c8aa6f74e26c8510638a5fa0cbd7 on master.

Coverage decreased (-0.1%) to 94.853% when pulling 0f871b59285ea13e73f4843574079b13dc1664f6 on ryandeivert-metric-filters into 8710b1552e3225f36eb0a21987b71e8a215e9faa on master.

Coverage increased (+0.3%) to 95.221% when pulling 7907cd05f71bf98ddc77e554d54afc9b44ad74e6 on ryandeivert-metric-filters into 8710b1552e3225f36eb0a21987b71e8a215e9faa on master.

Coverage increased (+0.2%) to 95.214% when pulling 7907cd05f71bf98ddc77e554d54afc9b44ad74e6 on ryandeivert-metric-filters into 8710b1552e3225f36eb0a21987b71e8a215e9faa on master.


send webcam to a defined screen + relative position

control window should provide an option to select the screen where the webcam should appear and at which position in relation to the screen dimensions

Using the Windows UWP CompactOverlay-mode (aka picture in picture) does not allow to define the placement of the window. I hope this will be integrated in future versions of Windows. ¯_(ツ)_/¯


Membership trends

creates new plot/json showing membership trends tracked against 6  month moving average.

API key for query 298 needs to be added to secrets.

This is PHENOMENAL! Thank you @maneesha !!!


ext_authz: fail closed when status is unset

Description: Currently if the status field of the CheckResponse message is unset, the request is permitted. This behavior is not documented or tested and could be charitably be described as "surprising." This PR changes the behavior to deny requests when status is unset and adds test coverage.
Risk Level: Low
Testing: Unit testing
Docs Changes: N/A
Release Notes: Yes

Friendly ping @brandonweeks.


[harfbuzz] Build error with visual studio 2015

Host Environment

OS: [e.g. Windows/Linux etc...]
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
./vcpkg install xxxx
Failure logs

Cut and paste the appropriate build messages from the console output.
Attach every failure log file mentioned in the console output.

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

@gisnewbird  Please provide the repro steps and failure logs.


Remove Mentions of Namespace CLI Configuration Requirements

Do not inform the user that he or she must configure a namespace before using the CLI

Closes https://github.com/openwhisk/openwhisk/issues/1797

@csantanapr, please review.

@dubeejw @csantanapr should the CLI be updated to also remove the --namespace features? (property set/get etc.)

Do you think there are users still out there that haven't unset their namespaces?

If they haven't it's fixable by editing the .wskprops file.

@csantanapr, is this ready for merge?

rebase this to remove the merges?

Given #1570 - maybe i'll merge this into my pr so i can amend it for --insecure. What do you think?

suggest we remove the section:  ## Setting up the deprecated OpenWhisk CLI (Python based).

there are also references to setting namespace in the vagrant doc.

Updates added. Will need another review.

@csantanapr, please review.

@dubeejw did you squashed with new content?
It makes it difficult to review and see what's the delta from the last time you got a review.
Leave the previous commits as you make changes just add more commits, we will take care of squashing at the time of merging.

@csantanapr, will do.

merged bb2c198ccc1aaa024c7ddf87dbd4ac686ca78462


Fix code smells

Address code smells reported by sonar to close #27

Codecov Report
Patch coverage: 95.65% and project coverage change: +0.51 :tada:

Comparison is base (21c9383) 88.49% compared to head (c1df56d) 89.01%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
+ Coverage    88.49%   89.01%   +0.51%
===========================================
  Files           14       14
  Lines          513      528      +15
===========================================
+ Hits           454      470      +16
+ Misses          59       58       -1

Impacted Files
Coverage Δ

dkron/migrations/0001_initial_20210729.py
100.00% <ø> (ø)

dkron/migrations/0002_job_retries.py
100.00% <ø> (ø)

dkron/utils.py
86.15% <95.00%> (+1.01%)
:arrow_up:

dkron/management/commands/run_dkron.py
91.22% <100.00%> (+2.51%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


OSX build and Cmake improvements

Hello, I would like to share a couple of comments from my OSX build - maybe you find something interested in these changes:

Scaling - for retina screens it seems a bit to big:

		dpi /= 96.0f;

		// enable dpi awareness
		if (Settings::Instance().General.AutoScale) {
			Settings::Instance().DPIScale = **std::floor(dpi)**;
			Logger::Get().Log("Setting DPI to " + std::to_string(dpi));
		}

dpi is 1.375000 - looks better if round() or floor()

Packaging app - I am attaching simple .app template that allows you build a standard OSX GUI application:

rm -rf bin/SHADERed.app
cp -rv templates/osx_tools.app bin/SHADERed.app
mkdir -p bin/SHADERed.app/Contents/MacOS
mv bin/SHADERed bin/SHADERed.app/Contents/MacOS/SHADERed
cp -rv bin/data bin/themes bin/templates bin/plugins bin/SHADERed.app/Contents/Resources/

templates.zip
Small change to in main.cpp that changes current directory to SHADERed.app/Contents/Resources/ (propably this should be replaced with something better):
	if (argc > 0) {
#if defined(__APPLE__)
        // check if we are running from .app
		if (ghc::filesystem::exists(ghc::filesystem::path(argv[0]).parent_path().append("../Resources"))) {
			ghc::filesystem::current_path(ghc::filesystem::path(argv[0]).parent_path().append("../Resources"));

			ed::Logger::Get().Log("Setting current_path to " + ghc::filesystem::current_path().generic_string());
		}
#else
		if (ghc::filesystem::exists(ghc::filesystem::path(argv[0]).parent_path())) {
			ghc::filesystem::current_path(ghc::filesystem::path(argv[0]).parent_path());

			ed::Logger::Get().Log("Setting current_path to " + ghc::filesystem::current_path().generic_string());
		}
#endif
	}

Application is using a couple of libs I am not using and keeping them globally is something I am not fan of :) Here is a piece of CMakeLists that downloads and builds all extensions locally. Maybe you would be interested to make this as an option (Cmake 3.14 is required):
include(FetchContent)

# sdl2
FetchContent_Declare(
    sdl2
    GIT_REPOSITORY "https://github.com/SDL-mirror/SDL.git"
    GIT_TAG "release-2.0.10"
)
FetchContent_MakeAvailable(sdl2)
# prepare SDL2/ header folder
if(NOT EXISTS "${sdl2_BINARY_DIR}/include/SDL2")
    execute_process(COMMAND ${CMAKE_COMMAND} -E create_symlink ${sdl2_SOURCE_DIR}/include ${sdl2_BINARY_DIR}/include/SDL2)
endif()
set(SDL2_INCLUDE_DIRS ${sdl2_BINARY_DIR}/include)
set(SDL2_LIBRARY_DIRS ${sdl2_BINARY_DIR}/libs)
set(SDL2_LIBRARIES SDL2-static)

# glew
FetchContent_Declare(
    glew
    URL "https://sourceforge.net/projects/glew/files/glew/2.1.0/glew-2.1.0.zip"
)
FetchContent_GetProperties(glew)
if(NOT glew_POPULATED)
  FetchContent_Populate(glew)
  # Top level doesn't contain the CMakeLists.txt, it is in the "build/cmake" subdirectory
  add_subdirectory(${glew_SOURCE_DIR}/build/cmake ${glew_BINARY_DIR})
endif()
set(GLEW_INCLUDE_DIRS ${glew_SOURCE_DIR}/include)
set(GLEW_LIBRARY_DIRS ${glew_BINARY_DIR}/libs)
set(GLEW_LIBRARIES glew_s)

# glm
FetchContent_Declare(
  glm
  GIT_REPOSITORY "https://github.com/g-truc/glm.git"
  GIT_TAG "<IP_ADDRESS>"
)
FetchContent_MakeAvailable(glm)

set(GLM_INCLUDE_DIRS ${glm_SOURCE_DIR})
set(GLM_LIBRARY_DIRS ${glm_BINARY_DIR})

# ASSIMP
FetchContent_Declare(
    assimp
    GIT_REPOSITORY https://github.com/assimp/assimp.git
)
FetchContent_MakeAvailable(assimp)

set(ASSIMP_INCLUDE_DIR ${assimp_SOURCE_DIR}/include ${assimp_BINARY_DIR}/include)
set(ASSIMP_LIBRARY_DIR ${assimp_BINARY_DIR})
set(ASSIMP_LIBRARIES assimp)

# sfml
FetchContent_Declare(
    sfml
    GIT_REPOSITORY "https://github.com/SFML/SFML.git"
    GIT_TAG        "2.5.1"
)
FetchContent_MakeAvailable(sfml)

set(SFML_INCLUDE_DIR ${sfml_SOURCE_DIR}/include)
set(SFML_LIBRARIES sfml-system sfml-audio sfml-network sfml-graphics)

Regards
Pawel

Hello!
Here are my thoughts:
Scaling
I think that there should be a better way to handle this. Like maybe dividing DPI by a different value to get correct scaling value? Rounding it down seems a bit extreme to me.
Packaging app
Thank you for providing the template and these steps. I would like to provide macOS builds though there is currently some feature missing from SHADERed for macOS (recompiling on file change). I think I won't be providing macOS builds until that gets implemented. This way I think it would be pretty bad UX especially since SHADERed is already pretty buggy (working to change that :sweat_smile:)
CMake update
This is absolutely cool, I didn't know something like that existed. Thanks, I'll probably apply this in one of the upcoming updates when I'll have more time to test it.
Thank you for opening this issue. I'll leave it open until I fix/implement these things.

Small addition to packaging script - I haven't noticed that SFML installs couple of additional dependencies - they are copied now into final .app package:
#!/bin/bash

set -e

cmake -DBUILD_SHARED_LIBS=OFF ..
make

echo "*** Packaging app ..."

pushd ..

rm -rf bin/SHADERed.app
cp -rv templates/osx_tools.app bin/SHADERed.app
mkdir -p bin/SHADERed.app/Contents/MacOS
mv bin/SHADERed bin/SHADERed.app/Contents/MacOS/SHADERed
cp -rv bin/data bin/themes bin/templates bin/plugins bin/SHADERed.app/Contents/Resources/

popd

install_name_tool -add_rpath<EMAIL_ADDRESS>../bin/SHADERed.app/Contents/MacOS/SHADERed
cp -va _deps/sfml-src/extlibs/libs-osx/Frameworks ../bin/SHADERed.app/Contents/


Update gltf-pipeline files

Contains:

https://github.com/CesiumGS/gltf-pipeline/pull/655

This required some manual formatting fixes 😕 maybe this could be aligned somehow...

This required some manual formatting fixes

@javagl Was this to ensure prettier was happy?

This fixes, https://github.com/CesiumGS/cesium/issues/11821, correct?
Can we add that to CHANGES.md?

Was this to ensure prettier was happy?

Yes. Apparently, gltf-pipeline and CesiumJS disagree here when it comes to some details:

And this was also not auto-fixed by prettier (or I mistyped something - didn't investigate it further, but could do that, if desired).

This fixes, https://github.com/CesiumGS/cesium/issues/11821, correct?

It was supposed to, but I have to admit that I did not (yet) check it in the specific sandcastle (only in local tests).

Can we add that to CHANGES.md?

Done. The conditions are very specific (I could have just written "Fixed a bug with legacy B3DMs"...). But there certainly is room for debate about the "right" behavior. Some parts of the KHR_materials_common spec are not as 'strict' as the newer glTF specs (e.g. it does not define color spaces and such). But hopefully, the new behavior makes sense for the (rare) case that this happens in the real world...

Thanks @javagl! We'll look into making sure prettier version are matching to avoid the formatting issue in the future.


Is ACI limited in python functions?

For example, if I add os.path.exists(model_path) in the init() function of score.py, the deploy will fail with CrashLoopBackOff.
Therefore I couldn't even debug to verify if model file exists when using other models following this guidance..

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 89cb4f9c-34e0-b4df-f911-e083c420cee8
Version Independent ID: 5be8b3bb-fb17-175a-7ca0-d69cef414799
Content: Image classification tutorial: Deploy models - Azure Machine Learning
Content Source: articles/machine-learning/service/tutorial-deploy-models-with-aml.md
Service: machine-learning
Sub-service: core
GitHub Login: @sdgilley
Microsoft Alias: sgilley

@xieofxie Thanks for the feedback. We are investigating the issue and will update you shortly.

@xieofxie I have tried to recreate the scenario to check if the deployment fails. With the same check to confirm the model_path my deployment works fine and the endpoint returns results. Here are the changes in score.py

Deployed the model as endpoint without errors

Response from the web service:

The error you have reported is because the line os.path.exists(model_path) is added before model_path is actually defined in the score.py file. Please try to use it after the path is created and it should work fine.

This causes the crashloopbackoff error during deployment.

Thanks~ @RohitMungi-MSFT
My script is right. However I set overwrite=True in Model.deploy to avoid removing new endpoints. And I am afraid it is the root cause. A new one works fine..


Any impact due to middleware in express app

We are using same code base for express based application as well as lambda.
As per configuration we have used
const awsServerlessExpressMiddleware = require('aws-serverless-express/middleware');
app.use(awsServerlessExpressMiddleware.eventContext());

in our app.js file.
Currently we do not see any issues into our standalone application.
Both (Lambda deployment, express based application) are working fine.
Do we need to consider something while running application in standalone mode (without lambda) ?

It should not cause any issues sincethis method converts the x-apigateway-event or x-apigateway-context header to the event and context objects. However, you will see this error in your logs: 'Missing x-apigateway-event or x-apigateway-context header(s)'.


Dev

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (ebcde1e) compared to base (d17abb0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         2    +1
  Lines           77        83    +6
=========================================
+ Hits            77        83    +6

Impacted Files
Coverage Δ

py_tictoc_timer/__init__.py
100.00% <100.00%> (ø)

py_tictoc_timer/tictoc.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Create app without "-win32-x64" in the name.

Homework

[x] I looked at nativefier --help and https://github.com/nativefier/nativefier/blob/master/API.md
[x] I searched existing issues, open & closed. Yes, my question is new.
[x] I'm using the latest version available at https://github.com/nativefier/nativefier/releases

Your question
I'm following readme

To create a native desktop app for medium.com, simply nativefier "medium.com"

Nativefier will try to determine the app name, and well as lots of other options. If desired, these options can be overwritten. For example, to override the name, nativefier --name 'My Medium App' 'medium.com'

and I'm trying to create app:
nativefier --name 'Google Calc' https://docs.google.com/spreadsheets/u/0/
or
nativefier --name 'Google Calc' 'https://docs.google.com/spreadsheets/u/0/'
but it gives me this error:

URL "Calc'" lacks a protocol. Will try to parse it as HTTPS: "https://Calc'". Please pass "http://Calc'" if this is what you meant.
Cannot automatically retrieve the app icon: Error: getaddrinfo ENOTFOUND calc

and the app is not created. First example uses double quotes and second (with --name) uses single quotes. Is the readme section outdated or I don't understand something?
Anyway I wrapped name in double quotes:
nativefier --name "Google Calc" https://docs.google.com/spreadsheets/u/0/
and it works but the app created is named "Google Calc-win32-x64". Is there a way to create app without "-win32-x64"? Or if I rename app after creating it will I be able to update it?
Context

Nativefier: 45.0.5
Node.js: 17.1.0
Npm: 8.1.4
OS: Windows10 21H2 OS build 19044.1348

The "-win32-x64" is just a folder that it is placed into. The exe should be named Google Calc.exe. The contents of this folder (including the executable) can be moved wherever you'd like.


How to get JSON-LD with groundings?

What is the invocation for getting a JSON-LD file with Eidos mentions with attached groundings? I tried doing
sbt “runMain org.clulab.wm.eidos.apps.ExtractFromDirectory ../../ml4ai/WorldModelers/MITRE_Evaluation_Documents output_dir”
but the output .jsonld files do not have the grounding information.

This may not be enough, but see the section "Related resources" towards the bottom of readme.md to begin.

Is the word2vec loading?
On Thu, Mar 22, 2018 at 8:17 PM Keith Alcock<EMAIL_ADDRESS>wrote:

This may not be enough, but see the section "Related resources" towards
the bottom of readme.md to begin.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/issues/212#issuecomment-375531236, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFInibFZ1ZoBOElyicWM4ygF2R393hjPks5thGk6gaJpZM4S4GFz
.

Ok, got it - I am downloading the 2.3G vector file and will try it with useW2V=true. I'll let you know if it works.

I think it worked, so closing now.

Sorry, forgot to update - yes it worked!


How to navigate to a screen and also focus on a tab

When navigating to a screen that contains the tab view of two tabs, the focus will be on the left tab, or the one the user already switched to before.
Is it possible to focus on one of the tab?
Expected behaviour
Choose tab to focus on when navigating to the screen containing the tabs
Code sample
This is my code of the screen that contains the two tabs:
import _ from 'lodash'
import { TabView, SceneMap, TabBar } from 'react-native-tab-view'

import FirstTab from '../organisms/service.first.organism'
import SecondTab from '../organisms/second.organism'

export default class ServiceScreen extends ComponentSuperclass {
  constructor (props) {
    super(props, 'ServiceScreen', true)

    this.state = {
      index: _.get(this.getStore().ui, 'tabService', 0),
      routes: this.getRoutes(),
    }

    this.view.tab.onIndexChange = this.onIndexChange
    this.view.tab.renderTabBar = this.renderTabBar
  }

  getRoutes () {
    const route = key => ({ key, title: this.lang.tab[key] })
    return [ route('current'), route('history') ]
  }

  renderTabBar (props) {
    const tabBar = {
      ...props,
      ...this.tab.bar,
    }
    return <TabBar {...tabBar} />
  }

  tabHistory () { return <FirstTab/> }
  tabCurrent () { return <SecondTab /> }

  onIndexChange (index) {
    this.ui('tabService', index)
    this.setState({ index: index })
  }

  render () {
    this.view.tab.navigationState = {
      index: this.state.index,
      routes: this.state.routes,
    }

    this.view.tab.renderScene = SceneMap({
      current: this.tabCurrent,
      history: this.tabHistory,
    })

    return <TabView {...this.view.tab} />
  }
}

Screenshots (if applicable)

What have you tried
I cannot use the above screen to focus on one of the tabs, because this screen will not be re-rendered once re-navigated to.
Is there a way to focus on one of the tabs from outside this screen?

Your Environment

software
version

ios or android

react-native
0.62.2

react-native-tab-view
2.14.0

react-native-gesture-handler

react-native-reanimated

node

npm or yarn

@omerfaran did you managed to find a solution?

I solved this using a "Context Provider" to save the state of index that the Tab component refers to
  // Tabs
  return (
        <TabView
          swipeEnabled
          renderTabBar={() => null}
          navigationState={tabContext.state}
          renderScene={SceneMap({
            first: First,
            second: Second,
            third: Third,
          })}
          onIndexChange={index => tabContext.setTab(index)}
        />

  // Misc Component
  return (
    <TouchableOpacity onPress={() => tabContext.setTab(1)} />
  )

any other solutions for this ? Context API doesn't seem to be working for me.

Lol I've found a solution by passing the current index as 'position' prop to tabbar


Move HR blog post for Offsite to published list

Pull Request
PR checklist
Please check if your PR fulfills the following requirements:

[ ] Does this PR fix an existing issue?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Could you solve the conflicts @shivaylamba ? Also, I don't think you need a review to update those kinds of things, but I'll let @ferdi05 confirm

I am closing this as @dichotommy had already created a separate PR for this and it was merged.

Could you solve the conflicts @shivaylamba ? Also, I don't think you need a review to update those kinds of things, but I'll let @ferdi05 confirm

Indeed @shivaylamba, this is super basic, so you can just create the PR, mostly to notify with the comments every person involved when needed, and merge it right after.
Thanks @CaroFG
indeed there is a conflict to fix


Cast all values before inserting

I think this could be very useful for working with times or custom types

I'll take a run at this one!

Whoops! Closed this accidentally.
I took a stab at an implementation. It's been a while @davidkuhta, so I hope you don't mind. I'm going to test it on a project or two tomorrow before submitting a PR.

Hey @jsteiner, what's the status of this one?

@teamon sorry, forgot to update here. This was merged into master as https://github.com/thoughtbot/ex_machina/commit/d7142b69be2d77d46cda1b06e0ac2ed0d3386046
It's still not up on hex.pm. We'll probably release a new version sometime soon.


[scripts] Fix code coverage problems due to inlining

Libra's script to report code coverage has been passing "-Cinline-threshold=0" in an attempt to forcibly disable inlining. We run coverage with a debug build, so that shouldn't have been strictly necessary but at some time in the past that worked fine. But, LLVM's inliner has gotten smarter and a threshold of zero just means that inlining should never increase code size. Now adding that option actually has the effect of enabling inlining, and for functions with a single call site and many arguments, it is often a code size win to inline. That's great for perf but it totally messes up the coverage data, because all the counts for an inlined function go to the line(s) where it is called and you can't tell what is covered within the function. With our current version of Rust (1.42), dropping the "-Cinline-threshold=0" option solves this problem, and that option shouldn't be necessary in the future, either.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I don't know of a good way to test this automatically, but it would be great if we had something to make sure this does not regress. Suggestions welcome!

@bors-libra delegate+
This looks good.
For future reference, this PR can be tested in place by adding - code-coverage below this line in CI config
https://github.com/libra/libra/blob/d6a2f89527f1843b36780141679796fed6f76a2f/.circleci/config.yml#L236
CI will trigger the coverage job as part of the commit verify flow.  After you are satisfied with the test result, you can un-do the change in CI config.

:v: @bob-wilson can now approve this pull request

I'm not worried about testing it in the sense of breaking CI. I've already tested it locally. The thing that we don't have for testing is a way to detect if this regresses again. I'm pretty sure we did not have this problem last fall when we set up coverage testing in CI, and I suspect something changed in the Rust compiler and/or LLVM. We're fixing it now, but if some future version of Rust causes similar problems, how will we notice? I guess if we're actually paying attention to our coverage results, we will notice if there is a sudden jump in the numbers.

@bors-libra r=sausagee

:pushpin: Commit 94a3ece has been approved by sausagee

:hourglass: Testing commit 94a3ece58f5685530809ae2fb4020fa9dd8610ea with merge d0b02a6819a8e52756fa57445c999ea7ac597864...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sausagee
Pushing d0b02a6819a8e52756fa57445c999ea7ac597864 to master...


Unable to export logs and Share on android device, its working fine in ios

Future exportAllLogs() async {
FlutterLogs.exportLogs(exportType: ExportType.ALL);
return _completer.future as FutureOr;
}
but _completer unable to return value ,

Word by word duplicate of #24
Why did the author post it twice with different accounts?


fix system time

if the system time is (very) wrong then https cert validation falsely fails.  Also logs are hard to interpret.
I tested this out on a node by copying in the modified file and rerunning genesis-bootloader.
@Primer42 @defect @qx-xp @schallert @sushruta rfr

:+1:

LGTM


Generic Support for RedisModules

@xetorthio
I'm working on custom redis module. Would like to add generic commands capability to Jedis. So basically you can pass a generic command name and var-args of arguments and them get the result to a specific type like Long, List, String.
Cheers,
Diego Pacheco

Hi @diegopacheco thx for taking the time to make a PR. Before moving forward, I'd suggest opening an issue as a "design discussion" to propose an alternative interface to the current implementation https://github.com/xetorthio/jedis/blob/master/src/test/java/redis/clients/jedis/tests/ModuleTest.java#L33-L47 and highlight your use-case about why this interface would be useful.
Remember that Jedis is a general purpose redis library for Java. So any changes that we make -specially on the interfaces- should be as generic as possible so anyone can benefit.

In addition to that, try searching in the current issues/pr as some discussions around modules are already on-going. I.E: https://github.com/xetorthio/jedis/issues/1713

@marcosnils
Thanks for the feedback. I can do my use case with:
https://github.com/xetorthio/jedis/blob/master/src/test/java/redis/clients/jedis/tests/ModuleTest.java#L33-L47
Cheers,
Diego Pacheco


[CONTROLLER/RECORDER] fix event bug

This PR is for:

Server

Fixes event bug
Steps to reproduce the bug
Changes to fix the bug

change map value point to struct

Affected branches

main

Checklist

[ ] Added unit test to verify the fix.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhengya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


build.cabal.sh: Use cabal new-run

The previous approach was terribly unreliable, potentially picking up stale executables which lead me to waste an hour debugging #425.

@bgamari Wait, something is wrong. Looks like we messed things up in #430.
Could you do this change to build.sh instead? build.global-db.sh should actually be a direct invocation of GHC like here:
https://github.com/snowleopard/hadrian/blob/10b8358882867ebfef0a48b9ba28d08fcf37eedb/build.sh
And build.sh is the default build script, which is Cabal-based, so your commit should change it. I'll fix build.global-db.sh.

Andrey Mokhov<EMAIL_ADDRESS>writes:

@bgamari Wait, something is wrong. Looks like we messed things up in #430.
Could you do this change to build.sh instead? build.global-db.sh should actually be a direct invocation of GHC like here:
https://github.com/snowleopard/hadrian/blob/10b8358882867ebfef0a48b9ba28d08fcf37eedb/build.sh
And build.sh is the default build script, which is Cabal-based, so your commit should change it. I'll fix build.global-db.sh.

Whoops. Thanks for catching this; I should have looked at the result of
the rebase.

@bgamari Thanks, merged now!

Oops, just realised this broke Travis... :-S Will try to fix.

@bgamari I think the above commit is what you meant.

Still broken :-S No idea why it's still:
cabal: Unknown target '--lint'.
There is no component '--lint'.
The project has no package '--lint'.


fix(completion): prevent error when getting activeItem with an empty collection

Summary
With an empty collections, itemInputValue was undefined which was throwing an error when destructuring it.
Result

We now check that itemInputValue exists before returning it, otherwise, we return null.
The activeItemId returned was -1, we now return null if there's no items in the collections.

@Haroenv They are, but to be clear, this wasn't the code responsible for the bug, this was only a refactor. The fix happens in getNextActiveItemId.

Thanks for the clarification!


Added api functionality to client

The client now has a local api server with 2 api calls

api/getURL - This will give the URL of the testing server being used for the current session in interact.sh
api/getInteractions → This api will take the url of the testing server and send the information about its interactions.

Thanks for this contribution @Alphaviper7769 !

@Alphaviper7769 I'm closing this due to missing information about the use case


#56 services section left hand text filling the box

Current coverage is 47.18%

Merging #143 into master will not affect coverage as of 6711178

@@            master    #143   diff @@
======================================
  Files           18      18
  Stmts          284     284
  Branches         0       0
  Methods          0       0
======================================
  Hit            134     134
  Partial          0       0
  Missed         150     150

Review entire Coverage Diff as of 6711178

Powered by Codecov. Updated on successful CI builds.


Add Toggle Core package to packagist

Epic: https://github.com/pheature-flags/pheature-flags/issues/1 Toggle Core
Package: https://github.com/pheature-flags/toggle-core
Description:
We need to add pheature/toggle-core package to Packagist, to allow the community to easily install it in any PHP project.

Done


(Routing) False Routing Redirected

I make vercel.json to prevent wrong routing from the user, it's work but something seems wrong 🤔
Yes it is redirected to home, but the address bar still www.example.com/wrongroute, it should be www.example.com/ right?

thank u @elianiva