Tooltip - Web component element is missing in Canvas section

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
Tooltip - Web component element is missing in Canvas section
Steps to reproduce:

Access storybook webpage
Select Tooltip component
Click on Canvas section
Verify if the tooltip component is displayed
Tooltip component is currently not displayed
Click on Docs section
Verify if the tooltip component is displayed
Tooltip component is displayed

Expected Behavior: Tooltip component should be displayed in the canvas section
Current Behavior: Tooltip component is not displayed in the canvas section
Please refer the below screenshot:

Reduced test cases
No response
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome, Firefox, Microsoft Edge
Which npm package?
No response
What version of npm package are you using?
No response
Priority
Medium
What product/project are you using Modus Components for?
QA
What is your team/division name?
QA

Looks like this was resolved via #1384


go to the next page with a specific condition (conditional page break)

HI
how to go to the next page (go to next docx page and keep going) with a specific condition like
+++IF condition +++
+++= page_break +++
+++END-IF+++
In python can use this
//code
from   docxtpl import DocxTemplate, R, InlineImage
page_break = R('\f')
//docx template
{% if condition %}
{{r page_break }}
{% endif %}
and how use index in FOR
and when try merge two docx file catch this error
"For source /word/document.xml, cannot find part word/media/template_document.xml_img1.jpg from rel img1=media/template_document.xml_img1"
i can not get this error with docxtpl  before

I have faced a similar situation and following is what I have used.
In JS code,
createReport({
            template,
            data: {
                ...data,
                pageBreak: '||<w:br w:type="page" />||',
            },
            cmdDelimiter: ['{{', '}}'],
        });

In template
{{ IF condition }}
{{pageBreak}}
{{ END-IF }}

In a similar vein, I solved this with:
const report = await createReport({
  ...
  additionalJsContext: {
      pagebreak: (show) => (show || typeof show === 'undefined') ? '||<w:br w:type="page"/>||' : '',
  }
})

which slims down the syntax a bit whilst allowing any given conditional or falsy value to prevent the break from showing, such as:
{{ pagebreak($idx < $component.issues.length) }}
{{ pagebreak($idx < 5) }}
{{ pagebreak($name === 'Alice') }}
{{ pagebreak($data) }}

pagebreak() can also be called without an argument to always output a break (or used within other contexts such as IF).

Thanks for this solution @davidjb !! 🥳

I encountered a problem with this method, since the <w:br w:type="page"/> comes wrapped inside an
<w:t xml:space="preserve">
    <w:br w:type="page" />
</w:t>

So I'd actually had to replace the text manually, here is the snippet if anyone wants it:
export function sanitizeDocumentXml(bin: Uint8Array) {
  try {
    writeFileSync('/tmp/template.docx', bin);
    execSync('unzip -o /tmp/template.docx -d /tmp/template');

    const documentXml = readFileSync('/tmp/template/word/document.xml', 'utf8');

    const sanitizedDocumentXml = documentXml.replaceAll(
      '<w:t xml:space="preserve"><w:br w:type="page" /></w:t>',
      '<w:br w:type="page" />',
    );

    writeFileSync('/tmp/template/word/document.xml', sanitizedDocumentXml);
    execSync('cd /tmp/template && zip -r /tmp/template.docx ./*');

    return readFileSync('/tmp/template.docx');
  } catch (error) {
    console.log('[sanitizeDocumentXml]: error', error);
    return bin;
  }
}

I believe this is compatible with most operation systems, but I tested in linux

||<w:br w:type="page" />||

Hey, I have tried this solution and actually it does not make the page break. Here is the templated:
*FOR chartData IN chartsData*
*$chartData.pageBreak*

*$chartData.question*

*IMAGE chart($chartData.imageSrc)*

*IF $chartData.table*
*IMAGE table($chartData.table)*
*END-IF*

*END-FOR chartData*

and this is the result:

I have faced a similar situation and following is what I have used. In JS code,
createReport({
            template,
            data: {
                ...data,
                pageBreak: '||<w:br w:type="page" />||',
            },
            cmdDelimiter: ['{{', '}}'],
        });

In template
{{ IF condition }}
{{pageBreak}}
{{ END-IF }}

Hey @SuchiraD, for some reason this does not break my pages. Here is my template:
*FOR chartData IN chartsData*
*pageBreak*

*$chartData.question*

*IMAGE chart($chartData.imageSrc)*

*IF $chartData.table*
*IMAGE table($chartData.table)*
*END-IF*

*END-FOR chartData*

then, the code:
const buffer = await createReport({
        cmdDelimiter: ['*', '*'],
        template,
        additionalJsContext: {
            pageBreak: '||<w:br w:type="page" />||,
            chartsData,
            chart: (imageSrc) => {
                ...
            },
            table: (table) => {
                ...
            }
        }
    })

and here is the result:


No implicit conversion of hash into integer

Bug Description
i just forked and cloned the repo i installed ruby
after running the command   bundle exec middleman build or server
i get this error : no implicit conversion of hash into integer
Browser (please complete the following information):

windows
chrom

Last upstream Slate commit (run git log --author="\(Robert Lord\)\|\(Matthew Peveler\)\|\(Mike Ralphson\)" | head -n 1):
Put the commit hash here

I'm getting the same issue.

What version of Ruby?

What version of Ruby?

Yep came back to post that the Ruby version was indeed the issue :)

Still getting this on latest slate release and using the minimum ruby version is allows, 3.3.3. Anyone know a fix?

Getting the same error using
ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x64-mingw-ucrt]
on Windows.
Any suggestion?

Use jsdoc or typedoc, much easier to use
On Wed., Feb. 15, 2023, 6:32 a.m. Infinite Loop Development Ltd, <
@.***> wrote:

Getting the same error using
ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x64-mingw-ucrt]
on Windows.
Any suggestion?
—
Reply to this email directly, view it on GitHub
https://github.com/slatedocs/slate/issues/1438#issuecomment-1431225563,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQF3ZKXLO3X5VA57GSNTVFTWXS5FVANCNFSM44NIOTLA
.
You are receiving this because you commented.Message ID:
@.***>


Remove customizations since they will be available in Volto17 core

This pr should only be merged after the frontend is upgraded to Volto 17.20

The changes were made because the Volto components were updated by the core team during the review process, while our version was the initial one that I developed

Found the original diff from Volto 17.16.0:
3a4,5
>  * Volto pr: https://github.com/plone/volto/pull/6036
>  * Remove after the pr has been merged and put in the right version
6,7c8
< import React, { useState } from 'react';
< import { compose } from 'redux';
---
> import React, { useState, useEffect } from 'react';
10c11,12
< import { FormFieldWrapper, Icon } from '@plone/volto/components';
---
> import { Icon } from '@plone/volto/components';
> import FormFieldWrapper from '@plone/volto/components/manage/Widgets/FormFieldWrapper';
37a40
>     value: propValue,
41c44
<   const [value, setValue] = useState(flattenToAppURL(props.value));
---
>   const [value, setValue] = useState(flattenToAppURL(propValue));
42a46,51
>
>   useEffect(() => {
>     if (propValue !== value) {
>       setValue(flattenToAppURL(propValue));
>     }
>   }, [propValue, value]);
180c189
< export default compose(withObjectBrowser)(InternalUrlWidget);
---
> export default withObjectBrowser(InternalUrlWidget);


How to discriminate boolean and date from server point of view?

Hi @DT-DawidWroblewski, Best wishes for 2023,
As you use only one scope to call userinfo ... As a server developper, how can I determine the reply type to send back?
Patrice

Hi @patrice-conil ! Wishing you all the best in 2023!
As a developer you receive a reply type according to your declaration that happens during onboarding process.
Due to legal concerns, it is required that developer/service provider delivers a statement regarding

what is the use case for API consumption
how consent acquisition process is designed, along with consent wording
what is preferred reply type (boolean or timestamp)

according to onboarding declaration API is being set up in a way that satisfies developer/SP.

Hi @DT-DawidWroblewski,
So, as a server developer, I have to maintain a link between the subscription portal and the simswap service to check what was subscribed during the onboarding process (Because I need this information to forge the reply).
Why not to use two different scopes to discriminate the returned info?

Hi @patrice-conil !
this might be an option - let's discuss it on our next call :)


don't send the client its own on-join MODE line

Fixes #353.
(I thought I'd put up the PR now since it's so simple, we can keep discussing on #353 whether we actually want to make the change.)

Noice, thanks for the PR! Good change is good~


Add Maven Topic

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md

I am:

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection

EDITING AN EXISTING TOPIC OR COLLECTION*
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

Please explain why these changes are necessary:
CURATING A NEW TOPIC

[x] I've formatted my changes as a new folder directory, named for the topic as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please explain why you think this topic should be curated:
Maven is a popular tool among Java developers and is often searched for. Having a description of this topic as links to more documentation will help developers searching for it on GitHub for the first time.
CURATING A NEW COLLECTION

[ ] I've formatted my changes as a new folder directory, named for the collection as it appears in the URL on GitHub (e.g. https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please explain why you think this collection should be curated:
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Can someone help suggest what the Maven logo should look like? It seems like 288 x 288 is expected, but I don't know of any Maven square logo.

Thanks so much for your first contribution!  You rock, @RohanNagar


[Feature Request] Windows Eternal Support by LegacyUpdate

Can LegacyUpdate ports latest security and most important features that most softwares depends on it (how the future goes...) from latest Windows to older versions of Windows and push it as an update for older versions of Windows (for EOL versions that most people are using these days like Windows XP, 7 and so on..) by LegacyUpdate servers
Also, for most native look, could LegacyUpdate be runnable in control panel and standard EOL version of Windows Updates control panel be disabled/removed
This could make it looks like more native and if ports for security updates gets always created for these most used Windows versions, potentially those EOL versions of Windows could be used forever (until the hardware gets too old to not be able to turn on anymore) and getting security in the same time too
Also, most apps will not stop to work since modded kernels that fakes Windows version to the apps could make a better apps compatibility and with getting some critical features from latest Windows supported versions ported to these versions of Windows, latest apps could be used on these EOL versions of Windows without any issues
(Optional: Porting UWP capability, bootstrap and dependencies from newer Windows versions to the EOL versions that are mostly used - they could also be served as an optional windows compatibility updates 👍)

Pretty sure it's more complicated than that to port newer updates to old Windows versions (and especially UWP), even with the Extended Kernel, so I doubt it's happening anytime soon. Also it's out of scope for Legacy Update, as it only focuses on giving access to official updates on older systems.


Read more settings from manifest.yml and/or config.yml

To roll out the features like #295 or #286 throughout a big, global team easier, it would be nice to be able to set them in one or more of these places:

exactly once - this would happen if we could add them to manifest.yml. I think that it makes pretty much sense for #295 as the level of parallelization may depend on the resources that the organization is willing to provide for parallelized git operations per single user.
once per user per workstation - if it would be possible to add them to config.yml generated for a manifest.

What are your thoughts about it, @dmerejkowsky ?

I think that it makes pretty much sense for Parallelize sync #295 as the level of parallelization may depend on the resources that the organization is willing to provide for parallelized git operations per single user.

I don't agree with that :)
It's nice to let user choose how much processes to use. Besides, the manifest may be consumed by very different machines (from a small laptop on battery while traveling in the train to a big 64-core CI worker ...)
Also, as I said in #286 , I think this feature should be a different command (or an option in sync).

Ok, maybe it's not a good idea to add it to manifest.yml, but what about config.yml?
Without this I have to resort to adding this to my ~/.bash_profile to enable parallelization for sync by default:
function tsrc() {
    if [[ "$1" == "sync" ]]; then
        /opt/homebrew/bin/tsrc sync -j auto
    else
	/opt/homebrew/bin/tsrc $@
    fi
}

Hum. Interesting - did not think you would need to write bash code for that.
First off, why are you using -j auto just for sync ? Do you not need it for init too?
Second, I think there are two ways we could go around this:

Just use -j auto as the default for tsrc sync
Allow use to configure tsrc behavior globally. In that case, I think a ~/.config/tsrc.yml may be better)

That being said, I'm still not convinced we need this feature at all - sorry if I'm a bit blunt, but this sounds like a lot of work to just avoid typing 7 characters :stuck_out_tongue:
Note: I may be biased though, because I've been using a pretty nice system to avoid typing long commands for quite some time now (I put all the commands I type in a local db and then use fzf to select and re-run previous entries quickly)

That being said, I'm still not convinced we need this feature at all - sorry if I'm a bit blunt, but this sounds like a lot of work to just avoid typing 7 characters

That would avoid me typing well more than 7 characters:

once tsrc sync,
then oh, too slow, press Ctrl-C,
and tsrc sync -j auto :grinning: (and several times a day sometimes :facepalm:)

@dmerejkowsky would you be open for a PR implementing a setting in config.yml?

put all the commands I type in a local db and then use fzf to select and re-run previous entries quickly

I use fzf too already, but that local db for commands idea sounds nice, any pointers?

I use fzf too already, but that local db for commands idea sounds nice, any pointers?

You can start with something like cat .history | fzf .... Personally I use far to many lines of Rust code to store in a db the working directories, the files I edit and the commands I run, then use  ... | fzf anyway. The code is here if you want to look at it: https://git.sr.ht/~dmerej/bwataout

Are you planning to implement this, @pdecat ? Because if not then I can give it a try.
@dmerejkowsky : can you please reopen this issue if we agree that this is a valid feature request?

Are you planning to implement this, @pdecat ? Because if not then I can give it a try.

Hi, I was planning it, but did not start anything so feel free to do it :)


Update wire protocol and peer architecture documentation

Fixes #913

Codecov Report

Merging #922 (c6f06d8) into master (828364b) will decrease coverage by 0.62%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
- Coverage   50.51%   49.88%   -0.63%
==========================================
  Files         145      145
  Lines        7544     7589      +45
==========================================
- Hits         3811     3786      -25
- Misses       3066     3129      +63
- Partials      667      674       +7

Impacted Files
Coverage Δ

pkg/config/consts.go
0.00% <ø> (ø)

pkg/config/loader.go
58.97% <0.00%> (+0.74%)
:arrow_up:

pkg/core/candidate/validator.go
57.14% <ø> (ø)

pkg/core/chain/legacy.go
26.08% <0.00%> (-2.49%)
:arrow_down:

pkg/core/chain/mock.go
8.33% <ø> (ø)

pkg/core/chain/sequencer.go
91.30% <ø> (ø)

pkg/core/consensus/agreement/accumulator.go
83.01% <ø> (ø)

pkg/core/consensus/agreement/handler.go
56.14% <ø> (ø)

pkg/core/consensus/agreement/store.go
62.12% <ø> (ø)

pkg/core/consensus/agreement/testutil.go
100.00% <ø> (ø)

... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a20982...c6f06d8. Read the comment docs.


[Enhancement]  Add return value for sendHeartbeat related method

Before Creating the Enhancement Request

[X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary
Add return value for sendHeartbeat related method
Motivation
Add return value for sendHeartbeat related method for getting result.
Describe the Solution You'd Like
Add return value for sendHeartbeat related method
Describe Alternatives You've Considered
No
Additional Context
No response

is this issue open?


Memory leak (even after webclient.close())

Hello,
I want to thank you for your amazing work. I'm using your lib since almost 1 year now and it's really nice.
I'm having an issue about memory (heap memory).
Showcase 1: I'm starting my app without doing any scrap
Heap: 74Mo

Showcase 2: I'm starting my app and doing 1 scrap with close
Heap: 256Mo

class ArkeaArenaFetcher {

    fun fetch(): List<EventJpa> {
        val webClient = WebClient().apply {
            options.isCssEnabled = true
            options.isJavaScriptEnabled = true
            cssErrorHandler = SilentCssErrorHandler()
            javaScriptErrorListener = SilentJavaScriptErrorListener()
            options.isThrowExceptionOnFailingStatusCode = false
        }

        return try {

            val page = webClient.getPage<HtmlPage>("https://www.arkeaarena.com/fr/programmation/tous-les-evenements/#")
            webClient.waitForBackgroundJavaScript(4000)
            val container: HtmlElement = page.getFirstByXPath("//div[@class='events-list ajaxed']/div[@class='container']")
            val rawEvents = container.getByXPath<HtmlElement>("a")
            rawEvents.map(::htmlToInfra)
        } catch (e: Exception) {
            emptyList()
        } finally {
            webClient.close()
        }
    }

     private fun htmlToInfra(html: HtmlElement): EventJpa {
        // convert html to Kotlin object
        ...
     }

}

Showcase 3: I'm starting my app and doing 1 scrap with close + other clean + gc
Heap: 166Mo

The code is the same as the showcase 2 but only the finally clause is changing like below
        finally {
            webClient.cache.clear()
            webClient.topLevelWindows.forEach { it.close(false) }
            webClient.topLevelWindows.forEach { it.jobManager.removeAllJobs() }
            webClient.cookieManager.clearCookies()
            webClient.close()
            System.gc()
        }

The issue here is even when I'm closing the webclient instance there is still memory which is not released. Here in my example code I'm dealing with a single source but in production I'm dealing with multiple sources.
I also tried

.use in Kotlin (try with resources) (article)

Other info

Language: Kotlin
HtmlUnit version: 3.9.0 (the behaviour is the same on older versions)

Article read about the memory subject:

https://maxrohde.com/2013/01/05/fix-htmlunit-memory-leak
https://htmlunit.sourceforge.io/faq.html#MemoryLeak

Similar issues

#639

@fleboulch - first of all - great to see that this is of some use for you; thanks for the feedback
can you please add
webClient.cookieManager.clearCookies()

to your second case, because this is not part of the close process.
And can you please try HtmlUnit 3.11.0....

The issue here is even when I'm closing the webclient instance there is still memory which is not released. Here in my example code I'm dealing with a single source but in production I'm dealing with multiple sources.

I think there is a lot of things that are created and stored - but i think the point is: if you create a webClient several times and do some scraping, after closing the client the memory should go back to the level after the first round....

I would like to use 3.11.0 version but my suite test is failing since 3.10.0.
I added a comment here

Second issue found when trying to migrate from 3.9.0 to 3.11.0 (comment)

Hello @rbri,
I'm seeing you are preparing a 4.0.0 version. That's a great news !
Did you have time to check the regressions I mentionned in my comments here?

I tried v4.0.0 and regressions are mentionned earlier disappeared!
Thanks for the amazing work @rbri :tada:
I still have my base issue with memory leak (I tried some stuff you told me above but it's not working)

@fleboulch sorry for the long pause

The issue here is even when I'm closing the webclient instance there is still memory which is not released. Here in my example code I'm dealing with a single source but in production I'm dealing with multiple sources.

There are some internal (class based) caches that might be the reason.
I think a valid test scenario looks like this

warmup

create a new web client und open url A
waitForBackgroundJavascript for at least some seconds
close the web client
have a look at the memory

retry A

if you now open A again and again (new webclient, open A, close client), there should be no major change in the memory consumed after the client is close (and maybe a gc performed)
this should be the case at least if there are not that many changes on the page itself

try B

if you now open another web page in another client this might lead to another memory increase because more js classes are loaded or we have some more css to parse

retry B

this should not allocate significant more memory

So far the theory - will try to find some time to check the code again.

Thanks for your reply @rbri ! I really appreciate your deep investigation.
I will try your scenario on my code to check if your assumptions are true.
I'm using different webclients because at the beginning I was parallelizing the calls

I checked your comment and it seems correct!
On my app I need to scrap multiple sites/external sources and I don't need any cache mechanism (even more after a close). I'm scrapping these websites once a day so the memory used stays high.
What are your recommandations for my usage?

Hello @rbri,
Do you have some news about this issue?

@fleboulch sorry far too many things on my desk.
Will try to think a bit more about this during the next days. Sorry


Finish implementing revert logic for all txs in the case of actual_fee > max_fee

Finish implementing revert logic for all txs in the case of actual_fee > max_fee
Description
Part of #862
Checklist

[x] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

#911 :police_car: 🚨

Codecov Report

Merging #911 (5e9d38c) into charge_max_fee (acc0584) will decrease coverage by 0.04%.
The diff coverage is 62.50%.

@@                Coverage Diff                 @@
##           charge_max_fee     #911      +/-   ##
==================================================
- Coverage           91.12%   91.08%   -0.04%
==================================================
  Files                  54       54
  Lines               13515    13529      +14
==================================================
+ Hits                12315    12323       +8
- Misses               1200     1206       +6

Files Changed
Coverage Δ

src/transaction/declare.rs
92.79% <62.50%> (-0.71%)
:arrow_down:

Closed in favor of #917


Update Set-Mailbox Params exclude linked subtype

Update Parameter Description for Params:

MessageCopyForSendAsEnabled
MessageCopyForSendOnBehalfAsEnabled
to explicitly limit availability of parameter to user mailbox which are not linked.

Docs Build status updates of commit 4b08d3e:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 49f8cce:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 49f8cce:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/mailboxes/Set-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 328c37f:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 328c37f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/mailboxes/Set-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 86b73da:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 86b73da:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/mailboxes/Set-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 608c750:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 608c750:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/mailboxes/Set-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Are the dev libraries and compilers needed for fah-gpu-amd?

The size of the current fah-gpu-amd image is about 3.9GB.
It is too large compared to 92.1MB of the size of fah-gpu (Nvidia CUDA).
Currently, fah-gpu-amd installs the rocm-dev package, which depends on the ROCm runtime and development libraries and LLVM compilers that rely on the g++ development environment.
I guess that this image's goal is to provide OpenMM, precisely speaking OpenCL, runtime to run the FAH core 22 efficiently.
If my guess is correct, only the runtimes related to OpenCL acceleration would be enough.

#23 accepted, thanks.


Documentation for developers on Component creation

what should we review?

http://superelastix.readthedocs.io/en/latest/Development.html
review it: enough detail? what structure do we want?


how to add header to static file request

i use AJAX to download static file, but not on same domain ,
i want to set header to corssdomain
what is best way to do it?

CORS in general via stream handlers. Making CORS simpler to use will be the focus of an upcoming release.


bug: jsdoc lint issue

Describe the bug
if function has no "/** */" jsdoc element, jsdoc not working

Closing as done


Error during data processing

I have this Exception but I dont know what generetad it.
01:29:58 ERROR Error during data processing. Client sessionId: c9c29ae0-1d4c-447f-8dfa-bed8022d0b04, data: java.lang.NullPointerException.
Do you know why this happens?

I also got the Exception:
2017-03-16 14:55:10.791 ERROR InPacketHandler:112 - Error during data processing. Client sessionId: a542a0c6-8cd5-4d41-ae7a-48bd4cc40707, data:
java.lang.NullPointerException: null
at com.corundumstudio.socketio.JsonSupportWrapper.readAckArgs(JsonSupportWrapper.java:46) ~[goeasy-node.jar:na]
As I found that it caused by there is no related AckCallback with the specified ackId.
So when do the log:
log.error("Can't read ack args: " + src.readLine() + " for type: " + callback.getResultClass(), e);
NullPointerException will be thrown out.
What confused me , normally when reigster an AckCallback, there will be a debug log:
log.debug("AckCallback registered with id: {} for client: {}", index, sessionId);
But I can not find this log for the ackId which can not find related AckCallback.

Some issue but i fixed. eg:
 var room = {
      id: '00001',
      name: 'TEST'
    }
    io.emit('create_room', JSON.stringify(room))
    io.on('create_room', function (data) {
      console.log(data)
    })

Use  JSON.stringify serialization your data


Add atom.whenShellEnvironmentLoaded()

This provides a way to be notified when the shell environment has loaded—even if it's already happened. (This implements the proposal from #14155.)
cc @nathansobo @maxbrunsfeld

Rebuilding on Circle CI. Seems like a lot of failures and hard to believe they're legit.

✨ Once we get a green build I'm cool with the code and test coverage.


kW_flex does not seem to work

With this Market Model:

and this LES, I get an error when trying to calculate a business case. I have tried to use different strategies.
I realise that there are no technologies with working flexibility strategies in this LES but there are blue and green curves nevertheless (which are equal). I expect zero flexibility to be measured.

The flexibility measures aren't properly "hooked up"; I'll see that this gets done.
Out of interest, what is the kW_flex measure specifically? The market model has two flexibility-related measures implemented:

FlexibilityRealised: The actual flexibility of each endpoint throughout the year: the difference between the blue and green curves in each time-step.
FlexibilityPotential: The average flexibility throughout the year: the average difference between the blue and green curves.

(See "Flexibility-related measures in #219).

what is the kW_flex measure specifically?

I think we should have them both indeed and name them:

kWh_flex_realised
kWh_flex_potential

We will be measuring the total kWh of flex in our LES anyway instead of the instantaneous flex in kW so let's make that expicit.

We will be measuring the total kWh of flex in our LES anyway instead of the instantaneous flex in kW so let's make that explicit.

Understood! The measures are in fact in kWh already, but I'll change the name(s) to reflect that.

Closing; the two flexibility measures have been added to the front-end, called "flex_realised" and "flex_potential".


Please add the below NOTE in the technet

Note: Malware release is not possible for end users from quarantine regardless of whether a user release action was configured in the quarantine policy.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db041b73-f7c9-db6c-070b-a7c974de640c
Version Independent ID: dffb7045-3ba8-a014-d1be-462ca1d609b5
Content: Configure anti-malware policies - Office 365
Content Source: microsoft-365/security/office-365-security/configure-anti-malware-policies.md
Product: m365-security
Technology: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

Checking.

OK. Done.
Thanks for the feedback.
Closing

Thanks Chris ..
Thanks & Regards,
Mithun Rathinam
Support Escalation Engineer , Beta Engineer
<EMAIL_ADDRESS>Working Hours: M-F 08:00AM - 05:00PM (EDT)
[Microsoft Logo]
From: Chris Davis @.>
Sent: Thursday, June 16, 2022 9:48 PM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Mithun Rathinam @.>; Author @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Please add the below NOTE in the technet (Issue #8927)
Changes should be visible by Th 6/16 10:00 AM PDT (GMT-7:00).

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F8927%23issuecomment-1157866093&data=05|01|Mithun.R%40microsoft.com|d236ac96bbce4d1751c208da4fb3cda7|72f988bf86f141af91ab2d7cd011db47|1|0|637909930959579956|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=VgZvuJA9ZyCOFfTpbCewI398vUKazL2z0cA8Y9wG71c%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZUWA2LQMLNYBPA5GVVT7DTVPNHUBANCNFSM5Y32P77A&data=05|01|Mithun.R%40microsoft.com|d236ac96bbce4d1751c208da4fb3cda7|72f988bf86f141af91ab2d7cd011db47|1|0|637909930959579956|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=BAx3h2%2BlgqZci4bwLzx0Df6N89MDLnNpe4iiwBsNvck%3D&reserved=0.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


Errors with SvelteKit 1.0.0-next.191 or newer

I hope this isn't an anomaly with my configuration, but since upgrading to Sveltekit 1.0.0-next.191 or newer, I'm getting a bunch of promise errors that prevent subscriptions from working. Queries still work though, despite the errors. I'm using a similar setup to my houdini-kit example.
GET /$houdini/index.js net::ERR_ABORTED 403
subscription:1 Uncaught (in promise) TypeError: Failed to fetch dynamically imported module: /src/routes/subscription.svelte
start.js:1190 Uncaught (in promise) TypeError: Failed to fetch dynamically imported module: /src/routes/__layout.svelte
async function (async)
start @ start.js:1183
(anonymous) @ subscription:16
subscription.svelte:29 GET /$houdini/artifacts/SubUsers.js net::ERR_ABORTED 403

My guess it may have to do with their security upgrade to Vite 2.6.12, specify allow list, and print warning and the location of the $houdini folder.

@skrenes did you ever get to the bottom of this? I haven't had a lot of time to dig into the 2.6.12 changes but if you have a working configuration now I can update the project

@AlecAivazis unfortunately I've been swamped and haven't had a chance to try to problem solve this. For my project, I've simply kept @sveltejs/kit locked on 1.0.0-next.190. My guess is that it'll come down to either moving /$houdini to /src/_$houdini or adding /$houdini to the allow list.

@skrenes I had a similar issue that I managed to solve by tweaking the Vite conf to this:
vite: {
      server: {
        fs: {
          allow: ['..']
        }
      },
			resolve: {
				alias: {
					$houdini: path.resolve('.', '$houdini')
				}
			}
		},

Reference: https://vitejs.dev/config/#server-fs-allow
Might be worth trying :)

Thanks so much @heliumbrain ! I also appreciate the reference. I tried to specifically allow only the Houdini folder and config directory, but the allow list seems to only respect paths. So I filed this bug: https://github.com/vitejs/vite/issues/5689. In the meantime, I set the allow line to allow: ['.'], rather than allow: ['..'],, since it's technically more restrictive.


Strange action errors in mirrored projects?!

Description
After update to 1.22.3 I see many of errors

in many mirrored projects?!
And than I saw this

or

or

or

What was activated with 1.22.3 release? What happens here?
Gitea Version
1.22.3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
2.47.0
Operating System
Ubuntu 22.04.3 LTS x86_64
How are you running Gitea?
gitea-1.22.3-linux-amd64
Database
PostgreSQL

I see that

are activated. I didn't activate it.

How can I fix it?
I can't go over the whole list and do it manualy.
When I deacticate the Actions in one specific project than I see the error

and when I click on the x I get 404 error.

@lunny ?

@lunny I see more and more mirrors with ...

I have no idea, maybe it's related to #32120 . @yp05327 @Zettat123

I see that

are activated. But not for all mirror.
And I didn't activate it.

Do you mean that  the "Actions" unit of some repositories are automatically enabled after upgrading to v1.22.3? If so, I think this issue is not related to #32120. Did you upgrade from v1.22.2 to v1.22.3?

Example

I didn't activate the Actions for all the affected projects.

And the red x is now after upgrade to 1.22.3.
When I add new mirror, Actions are activated

Should the Actions be activated or not? If yes, what happens here for mirrors? Why I see the whole failed old history?
Why will be the red x shown for mirrors? Looks like an error, but why is this now in 1.22.3?
How can I check in the database which projects are affected? Can remove the red x for affected projects?

I compared 1.22.2 (older status) and 1.22.3 instances for same mirrors.
1.22.2 -> actions tab is not activated
1.22.3 -> actions tab is activated

When I add new mirror, Actions are activated -> is this right? Was this activated in 1.22.2 too?

Yes. New repositories (including mirrors) created in versions after v1.22 will have "Actions" enabled by default. See #27482. However, I don't think repositories created before v1.22 will automatically enable "Actions" after upgrading. I'll do some testing to confirm.

There is a proposal to disable "Actions" for mirror repositories by default. I support this idea.

#30350

When does these jobs start being triggered?
I'm sorry I don't know the language in your screenshot.

Does this mean last month?
And when did you upgrade the instance?
If the jobs are triggered before the update, it make sense. And I think this means before the update, the action unit is already enabled. But you said, they are disabled before the update, and enabled after the update, which is strange.
But if they are all triggered after the update, it means during the update, action units was enabled. Then it should be a bug or something is wrong from Gitea side.

But if they are all triggered after the update, it means during the update, action units was forcibly enabled. Then it should be a bug or something was wrong from Gitea side.

This is where I suspect a bug exists. But I can't find any evidence that Gitea forcibly enabled the "Actions" unit.

@Zettat123
Yes. I think it is the point, so I asked, and then we can know what happened.

When does these jobs start being triggered?
I can see some of them, but I'm sorry I don't know the language in your screenshot.  Does this mean last month?

It's German. And it mean last month.
I'm wondering too, that I see this actions.

And when did you upgrade the instance?

~2 days aftrer 1.22.3 was released.

If the jobs are triggered before the update, it make sense. And I think this means before the update, the action unit is already enabled. But you said, they are disabled before the update, and enabled after the update, which is strange. And I have no idea about it yet. But if they are all triggered after the update, it means during the update, action units was forcibly enabled. Then it should be a bug or something was wrong from Gitea side.

But i didn't enable any actions. I checked a lot of mirrors and most of them has no activated actions.

This https://github.com/auth0/go-auth0 is an mirror.
2 months ago

And 1.22.3 was upgraded on 09.10.2024

And here othe mirror with activated action but wihout any errors

This is because the trigger of these 2 workflows are creating PR to main branch and workflow_dispatch (manually excute)

So IMO, actually, there's no bug and the only thing you need is #30350

And here othe mirror with activated action but wihout any errors

This is because the trigger of these 2 workflows are creating PR to main branch and workflow_dispatch (manually excute)
ps: for @Zettat123, the workflow files: https://github.com/stanford-oval/storm/tree/main/.github/workflows

I see. Actually, the "Actions" unit was enabled for all repositories, but only some of them had actions runs due to workflow triggers.

Will the patch make it like it was before or does something still need to be fixed in the database?

In another way, it is not difficult to implement a new options when migrating the repo.
But how to handle these existing mirrors, adding a migration or a maintenance operation or doctor?

To batch disable the "Actions" unit of existing mirrors, users can use the API PATCH
/repos/{owner}/{repo} to update repos.

And today I see first system messages

I missing here info to the project.
2024/10/15 19:50:18 ...eb/routing/logger.go:102:func1() [I] router: completed GET /repo/search?sort=updated&order=desc&uid=1&team_id=undefined&q=&page=1&limit=15&mode=&archived=false for <IP_ADDRESS>:0, 200 OK in 95.1ms @ repo/repo.go:556(repo.SearchRepo)
2024/10/15 19:50:22 ...ns/schedule_tasks.go:87:startTasks() [E] CreateScheduleTask: SetJob: yaml: line 15: did not find expected key
        /source/services/actions/schedule_tasks.go:87 (0x1ec5678)
        /source/services/actions/schedule_tasks.go:24 (0x25858bc)
        /source/services/cron/tasks_actions.go:63 (0x25858bd)
        /source/services/cron/tasks.go:111 (0x25824c7)
        /source/modules/graceful/manager.go:92 (0xaa9d26)
        /source/services/cron/tasks.go:88 (0x258223a)
        /source/services/cron/tasks.go:67 (0x2586d93)
        /usr/local/go/src/reflect/value.go:596 (0x4fccc5)
                Value.call: call(frametype, fn, stackArgs, uint32(frametype.Size()), uint32(abid.retOffset), uint32(frameSize), &regArgs)
        /usr/local/go/src/reflect/value.go:380 (0x4fbdd8)
                Value.Call: return v.call("Call", in)
        /go/pkg/mod/github.com/go-co-op/gocron@v1.37.0/gocron.go:122 (0x2563904)
        /go/pkg/mod/github.com/go-co-op/gocron@v1.37.0/executor.go:87 (0x2561b31)
        /go/pkg/mod/github.com/go-co-op/gocron@v1.37.0/executor.go:213 (0x2562817)
        /go/pkg/mod/github.com/go-co-op/gocron@v1.37.0/executor.go:269 (0x25632b7)
        /usr/local/go/src/runtime/asm_amd64.s:1695 (0x47b0a0)
                goexit: BYTE    $0x90   // NOP

Same #30244

Can I use this
; [actions]
;; Enable/Disable actions capabilities
;ENABLED = false

to disable action temporary?
And this
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Cleanup expired actions assets
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;[cron.cleanup_actions]
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;ENABLED = true
;RUN_AT_START = true
;SCHEDULE = @midnight

to cleanup all the action jobs?

It is a global setting for all repos, if you do not need to use actions in this instance, you can disable it globally.
Clean up only remove action job log, related data and artififacts, it will not delete those action jobs.

It is a global setting for all repos, if you do not need to use actions in this instance, you can disable it globally.

Thx,

Clean up only remove action job log, related data and artififacts, it will not delete those action jobs.

hm.
Are you working on a solution to this problem?
The failed action jobs are flooding my system messages view.

For existing mirrors, no good solution from me.
As it is related to repo_unit table in DB.
If there's a record with unit type 10 (action), and it is not globally disabled, then it means action unit is enabled.
We can not simply remove these records in migration, as users may need it.
So we can only do it by ourselves (cli or sql) or add a new maintenance operations, but it is not a usually used feature I think, so  maybe there's no worth to implement it.
↑ It is for the action jobs
And the commit status (x in dashboard repo list) is recorded in another table, and if you don't want to see them, maybe you also need to clean it.
So, as a summary, I have no good idea now for completely solving it for these existing mirrors.

Understand. Means I have fix it for ~20.000 mirrors by myself. Or I do

To batch disable the "Actions" unit of existing mirrors, users can use the API PATCH /repos/{owner}/{repo} to update repos.

this with an script for all the mirrors?
I this case I should send only has_actions = false as an json? Right?
This will disable the action. And how can I than fix this

?

I this case I should send only has_actions = false as an json? Right?

Yes.
https://github.com/go-gitea/gitea/blob/9116665e9c1c01d882c919fb3058f7fdb695350e/routers/api/v1/repo/repo.go#L1018-L1027

@Zettat123 I did this for ~3500 mirrors. Looks good.
And what should be removed in th database to remove this

?
This is visible after I set has_actions = false. And click on the x or o show 404.

I think these commit status can be removed manually from the database with
delete from commit_status where repo_id = (select id from repository where is_mirror = true)
delete from commit_status_summary where repo_id = (select id from repository where is_mirror = true)

I this case I should send only has_actions = false as an json? Right?

Yes. You only need to set the fields that need to be changed.

I have now a script which I run after I added some new mirrors.
But for the next release there will be a fix in gitea? Means, when I import new mirror "Actions" will be deactivated by default?

I think these commit status can be removed manually from the database with
delete from commit_status where repo_id = (select id from repository where is_mirror = true)
delete from commit_status_summary where repo_id = (select id from repository where is_mirror = true)

Thx. I try this next weekend with an Gitea-DB backup.

@lunny is there a fix in the next release that for new mirrors "Actions" will be not activated?

Yes, I think there should be a PR to fix that but there is no ETA


Add Check example on README

Hello there!
I've noticed that ther is no Check example on the README file. Do you plan on adding it on a near future?

Yeah, both Check and Try has no docs yet.


glist not populating after greload

Not critical, but whenever doing a greload the glist shows the correct total number of players but the distribution of the players over the servers connected is always 0.
Using Build #133
Screenshot:
https://thumb.gyazo.com/thumb/1200/_723b7a089d435bdacd10ac12b85906aa-png.jpg

Does this change when you use plugins that provide similar lists?

Actually our waterfall is pretty lightweight, just have a status, permission, and admin plugin but nothing else that produces a list.

Read again, I asked the other way around ^^ but anyways better test if the issue also exists when you use BungeeCord - if yes - report that to them.

This issue does not reproduce with BungeeCord.  I set up a test network using BungeeCord instead of Waterfall and after greload, the list is accurate.
Screenshot:

The one thing I have not tried yet is updating to Waterfall build 134 that was released earlier today, but from what I've heard this issue has been around for a while.

Mark if you use normal bungee cord and reload it glist stays the same and isn't affected then if you use Waterfall and do greload glist is removed but still counts as players are online but offline at the same time

Confirm this, using greload it break player counter

Using waterfall build 138 and it still does this.

You're not supposed to use greload anyways though...

Fair enough.  I only use it when I make the occasional minor configuration change.  If I'm adding or upgrading a plugin, I always queue up an overnight restart. So this definitely isn't a gamebreaking bug, but just thought I'd report it.

@braceyourself07 Even if the glitches caused by greload were to be fixed - there's no guarrantee you plugins would take care of that too... so it's really just for testing purposes


[BUG] Race condition in BsonMapper

Version
LiteDB 5.0.21
.NET 8.0.401
Linux (Fedora 38)
Describe the bug
Specifically, what I see is an occasional stacktrace:
System.NotSupportedException : Member Id not found on BsonMapper for type MyNamespace.MyType
 Stack Trace:
at LiteDB.LinqExpressionVisitor.ResolveMember(MemberInfo member)
at LiteDB.LinqExpressionVisitor.VisitMember(MemberExpression node)
at LiteDB.LinqExpressionVisitor.ResolvePattern(String pattern, Expression obj, IList`1 args)
at LiteDB.LinqExpressionVisitor.VisitMethodCall(MethodCallExpression node)
at System.Linq.Expressions.ExpressionVisitor.VisitLambda[T](Expression`1 node)
at LiteDB.LinqExpressionVisitor.VisitLambda[T](Expression`1 node)
at LiteDB.LinqExpressionVisitor.Resolve(Boolean predicate)
at LiteDB.BsonMapper.GetExpression[T,K](Expression`1 predicate)
at LiteDB.LiteCollection`1.DeleteMany(Expression`1 predicate)

when running an expression like
collection.DeleteMany(item => idsToDelete.Contains(item.Id))

Code to Reproduce
I cannot reproduce this consistently, it only happens once in a while, likely while I am running multiple concurrent transactions not against the same collection, but using the same types.
I believe this is a race condition caused by #2493, here's the possible race I see that this PR introduced:

Thread A enters GetEntityMapper here, and does not find the mapper.
Thread A calls BuildAddEntityMapper, and goes past this line, adding an entity mapper to the _entities dictionary.
Thread A is preempted by thread B, which enters GetEntityMapper.
Thread B finds a mapper and returns, but this mapper won't work, as it has not yet been populated with fields, resulting in the stacktrace above.

This code has existed for a long time, and this issue only started after updating to the latest version, which contains this fix. There may be a different cause, though my trace above seems plausible.

Oh i see it now. Thats pretty bad, i am sorry for that. Would you mind pr'ing a fix?

Sure. The by far easiest fix would be to just move the lock statement outside of the TryGetValue, unless there are performance implications of that (it should be fine)? I'm not familiar enough with the change you made to tell if there is another way to fix it.

I made a PR with a simple fix, though I'm not sure it is the best solution, since it will come with a performance cost that I think the original author of this code wanted to avoid.

Performance < Stability

Hey @einarmo can you have a look at my pr and if it solves your issue? My solution doesnt require locking all the time and should still be safe from race conditions


x/vuln: exit with status 2 when relevant

Govulncheck should follow the go command pattern for exit status.
For example, in case when https://pkg.go.dev/flag#ExitOnError should be returned.

Addressed in https://go-review.googlesource.com/c/vuln/+/487736


Turn GPS Base Stations

Current metadata draft for the Utah TURN GPS Stations layer. Let me know what you think! Thank you!

I think this looks good for the most part. One minor change:
"In some areas we extends past the boundary of Utah when we have been invited by those communities."
I would consider revising this. Perhaps:
"In some areas, our boundary extends beyond Utah where we have been invited..."

I would consider revising this. Perhaps:
"In some areas, our boundary extends beyond Utah where we have been invited..."

That sentence isn't in the most recent commit.  At the moment, the language is simply: "This network is available in Utah and some surrounding areas". Do you want me to include the bit about us being invited, or just leave it at that? Either way works for me, I just wasn't sure if the being invited part was an essential detail or not.

@miriamseely - leave it the way you have it. I think it sounds good.


Validation: Navigation should clear optional navigation params

https://github.com/aspnet/AspNetCore/pull/12407

Done


Swiper highlighting does not respect case-fold-search

When I perform a Swiper search with the default settings, I get results that indicate that a case-insensitive search is being preserved (e.g. I search for utah and get matches for Utah). However, the highlighting is always case-sensitive (e.g. the matches for Utah are listed, but they're not highlighted, although the matches for utah are highlighted).

Ahem. My mistake regarding the transfers. I thought this was under the wrong repository, but it's not.

Reopening the issue as promised, and I will be happy to accept a pull request addressing the problem, but I will not be the one working on it (see #65).


Failed to resolve: com.github.chrisbanes.photoview:library:2.0.0

When I use it at Android studio ,I have Add "maven { url "https://jitpack.io" } " in root build.gradle file ,and dependencies {
implementation 'com.github.chrisbanes:PhotoView:2.0.0'
}... but Failed to resolve: com.github.chrisbanes.photoview:library:2.0.0

can you post your build.gradle file content

Try it with 2.1.4

I am also facing this issue.

I am also facing this issue. Can we re-open this issue @Jawnnypoo ?

+1

If you are seeing issues, it is more than likely an issue with Jitpack or your internet connection.

ERROR: Failed to resolve: com.github.chrisbahines:PhotoView:2.00

I meet same problem and i have add  add "maven { url "https://jitpack.io" } " in root build.gradle

If you are seeing issues, it is more than likely an issue with Jitpack or your internet connection.

Thanks
Adding maven { url "https://jitpack.io" } in project level build.gradle resolved my issue.

If you are seeing issues, it is more than likely an issue with Jitpack or your internet connection.

Thanks
Adding maven { url "https://jitpack.io" } in project level build.gradle resolved my issue.

it's solved the problem thx 👍 @RumsPatel

the problem for me was that I had putmaven { url "https://jitpack.io" } in the wrong place.
I'd put it inside buildscript -> repositories (mistakenly next to maven { url 'https://maven.fabric.io/public' }, but it should've been inside allprojects -> repositories

I was also facing the same issue, but my problem was that I'd not included maven { url "https://jitpack.io" } in the allprojects -> repositories inside the project level gradle file.
buildscript {
    repositories {
        google()
        jcenter()
        maven { url "https://jitpack.io" }
    }
}

I had it added above, and the library failed to load.
Once I added it to the below code also, it worked:
allprojects {
    repositories {
        google()
        jcenter()
        maven { url "https://jitpack.io" }
    }
}

Hope this helps.

Paste - maven { url "https://www.jitpack.io" } in settings.gradle and
paste this dependency - implementation 'com.github.chrisbanes:PhotoView:latest.release.here' in build.gradle

i already have this inside my Project Gradle
repositories {
        google()
        mavenCentral()
        maven { url 'https://jitpack.io' }
    }

I have also added   implementation 'com.github.chrisbanes:PhotoView:2.3.0' to the dependencies inside Module Gradle yet it's still not working, can anyone help me ?


[continuelist addon] Add tasklist support

Adds support for tasklist - [ ]  and - [x]  syntax in the continuelist addon.

Looks good. Merged as 82ab0b4


chore: setup connect-go proto files

Motivation and Context
This is used for https://github.com/wundergraph/terraform-provider-cosmo.
The package can be used like this:
go get github.com/wundergraph/cosmo@638540986b469dxxxxxxxxxxxxxxxxxx

TODO

[ ] Tests or benchmark included
[ ] Documentation is changed or added on https://app.gitbook.com/
[ ] PR title must follow conventional-commit-standard

Our pipelines will fail when the git directory is dirty. This happens on router builds at least automatically.
Didn't saw this as an artifact, clients using it have to ensure those are up to date which is at the moment the terraform-provider which needs to adapt to whatever changes here.

Does it mean a workflow will fail when the code becomes outdated in this repo?

Not necessarily in the terraform provider. It will fail there when e2e tests are failing which are running against latest cosmo.
I think it's a good idea to keep the files updated in general.
Nevertheless I think no one will do unless you need to, or the pipeline fails. This would be  latest in the router builds as they are running the generate-go command and do the dirty check, even though it's unrelated.
The controlpalne ci seems to be the only place where this would make sense, even when publishing it somewhere later.
Are there any considerations on reusing things on the router?


Why not provide documentation

I found out that there are only resource-server document and no authorization-server here(https://docs.spring.io/spring-security/reference/servlet/oauth2/index.html). Why not provide document about spring-authorization-server

Hi @NeoZephyr! We're actively working on reference documentation that will be released next week with the 0.3.0 release. You can find a preview here. I'll close this as answered.


OHRI 2081-deleted active visit banner tag.

Deleted active visit banner tag
Requirements

[ ] This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
[ ] My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

@kirwe changes from this PR have been merged with https://github.com/UCSF-IGHS/openmrs-esm-ohri/pull/1745
Please crosscheck for the css files and delete them as well as @CynthiaKamau suggested


Run Seeder Order By KeyName

Not sure if we really need this. If we have a requirement to seed data one after the other in an ordered fashion, the easiest way would be to just to add a new interface like IBrandSeeder that inherits from ICustomSeeder, register it in the DI, and modify the RunSeedersAsync method in the CustomSeederRunner, so that we can initialize each of the seeders manually one after the other. This looks like an added complexity to me.

There are some good things here for sure.
I like the idea of the ApplicationDbInitializer running the seeders instead of the ApplicationDbSeeder.
The ApplicationDbSeeder should then be renamed to IdentitySeeder, as that is what it does, seeding roles and users which is identity.
But doing it like this indeed needs a way to order them. From the top of my head, there's 2 ways to go about this:

the way you did it, with a key in the ICustomSeeder interface on which can be ordered...
another way is not registering them automatically, but do it manually where you can very explicitly define the order.

I think the second way is the better one. I does need a bit more code, but it makes the process more explicit and less "magic" which is a plus.
If we would go with the first one, I wouldn't make the property a string though, but rather an int "Priority" or something like that (lower is better), then you can have a default of 0 and give a negative number to the one from identity for instance.

Having thought a bit more on it... When ApplicationDbSeeder is renamed to IdentitySeeder then ICustomSeeder should be renamed to IApplicationDbSeeder and its InitializeAsync method should be renamed to SeedAsync and take an ApplicationDbContext as a parameter.
Starting to make more sense that way I think ;-)

Let's say it's a feature that I had implemented for my own need to populate and then I proposed again because I thought it was useful.
Of course, everything can be improved.
I was thinking of creating isolated modulators (ICustomSeeder/IApplicationDbSeeder) that I could order the execution (RolesSeed, RootSeed/AdminSeed, BrandSeed, ProductSeed, ...)

I don't see where this is considered not useful... It just needs some more iterating on.


Container dialog 'Version' field should have tooltip/watermark with explanation

What exactly user should type: R3.4? 3.4.0? Maybe pre-fill with 'latest'?

Maybe just a drop-down?

Maybe... But where do we get the list? what to do with new versions?

Still reproes

Tooltip was overridden by Watermark. Should work after #3996 is checked in.


[R000586] Rep. James Renacci

Rep. James Renacci:
http://renacci.house.gov
Likely contact form URL to start with:
http://renacci.house.gov/contact-me/

YMAL file not found. I am working on it.


Fix websocket batch RPC

Currently throws an "unknown message received" error.  Example data field is:
'[{"jsonrpc":"2.0","id":4,"result":"0x00000000000000000000000000000000000000000000021a72a75ef8d57ef000"},{"jsonrpc":"2.0","id":5,"result":"0x0000000000000000000000000000000000000000000000028c418afbbb5c0000"}]\n'

Fixed in b42b47e4a11616cd955c15794ed72a5a623c16df


Find random engineer to review PR #19613

Problem
The new automation isn't working, and I am unable to randomly assign an engineer to review my PR that has been approved by C+
Solution
Whoever is assigned to this issue by pullerbear will need to review the PR.
 How do we do that?

WTF

@muttmuure can you try adding the engineering label please? We weren't able to trigger assignment with the C+ reviewed string

:D

THANK YOU

@bondydaa you won the hacky lottery. Your prize is that you are the randomly assigned reviewer for my notification PR 🎉


Update CONTRIBUTING.md to use Github Generate release notes button

This button does pretty much the same thing as the github_changelog_generator script described now in the CONTRIBUTING guide. No need for this script anymore since this functionality is now built-in.
┆Issue is synchronized with this Jira Task by Unito

Recent similar discussion - https://ably-real-time.slack.com/archives/C03JDBVM5MY/p1713542539425589
Owen somehow managed to do that in ably-js.

Ah cool, seems like you can type in a dummy tag name in the "choose a tag" field 👍


Look into implementing async/await

It would be nice if tasks could be async, but this looks like a major undertaking.
In particular, there is particular concern regarding the system that detects which dependencies are in play if tasks get involved, and I have currently completely avoided problems with multiple threads in play.
Still, it would be nice.
As an example of what I could hope to accomplish:
var context = new SignalContext();
var employeeId = context.State(0);
var employee = context.Computed(() => {
    await using var dbContext = await dbContextFactory.CreateAsync();
    return dbContext.Employees.FirstOrDefault(emp => emp.id == employeeId.Value);
});

and then render employee in a blazor form.
This can currently be done in an effect:
var context = new SignalContext();
var employeeId = context.State(0);
context.Effect(async () => {
    var id = employeeId.Value; // <-- this needs to be done before the first await
    await using var dbContext = await dbContextFactory.CreateAsync();
    return dbContext.Employees.FirstOrDefault(emp => emp.id == id);
});

The main issue here is that the method will return upon the first encounter of awaiting a not-yet-complete object, and then dependency tracking will stop. In the above example the state variable is read before any such await, so this will be handled. However, you cannot create another compute that uses this employee to, say, calculate a nice display name, as this would run when the first await returned back to the signal system, not when the entire task has completed running.
Basically, in the above example, the signal system is oblivious to anything happening after the first await.

Async code could also lead to multiple computed expressions being evaluated at the same time, or different parts of their code interleaved. This might make it hard to handle dependency detection properly. Maybe execution context could be used to handle this.

I seem to have been able to implement async/await, but I need to decide if this is the way to go.
I particularly liked the simplicity of state.Value, but a property cannot be async, so once async/await was introduced I had to switch to methods.
This also posed a slight problem with Blazor, in terms of syntax, what seems the best syntax to express values to render is not possible since the markup is not async.
I will leave it on the attached branch for now, and think about it.


Connect to API.

Hello Reviewer! 👋🏾

- In this pull request, I did the following things:-

Make use of the Bookstore API (https://www.notion.so/Bookstore-API-51ea269061f849118c) as my backend.
Use Axios (https://axios-http.com/docs/intro) with createAsyncThunk to make my HTTP requests to the backend
Fetch the books from the Bookstore API after the component has rendered.
Refactor the add book and remove book features to persist my changes in the server while checking if my application behaves the same way after the refactoring.

Thanks for the Professional Review @didierganthier. 🙏🏾 🙏🏾


(JS-0359) Detected the use of require statements except in import statements

Description
In other words, the use of forms such as var foo = require("foo") are banned. Instead use ES6 style imports or import foo = require("foo") imports. Example - The not-preferred way :
Occurrences
There are 5 occurrences of this issue in the repository.
See all occurrences on DeepSource → deepsource.io/gh/appsmithorg/appsmith/issue/JS-0359/occurrences/

If it is fine, I'd like to take this one up

Hi @mohanarpit, If it's not worked by anyone, I want to work on it.
cheers.

Hey @bharat-patodi! I've assigned this issue to you, please make sure to read our Contribution Guidelines before raising a PR!

Thanks @nidhi-nair

Verified as part of regression testing


add flexibility to componentDidUpdate

imagine when there is a state change to clear the current value (i.e. the value is an empty String), it will be better to reset the default opening screen to current date, instead of caching the previous value.
Plus, It will throw error when there is a change in maxDate or minDate when value is empty, as the state of date, month and year were cached, and when it is out of range


Update changelog about 2 recent pull requests

2 pull requests - #239 and #240 - I've submitted recently aren't mentioned at the top of the changelog. Adding them to minimise the effort required when the next release will be done.
On a related note, what do you think of adding a pull request template with a checklist? One of the items could be to add an entry at the top of the changelog.

The template sounds a sensible idea. Can you please open a new issue for that, so that we can discuss about it?

Done with #254


Improve readability of "EKU" abbreviation

I was at one point in time not 100% sure, what you meant by the abbreviation "EKU" in a certain context. So I decided it could be helpful to have this abbreviation one time written out in the documentation.

@cardonator could you please re-approve this PR? I changed it from being a Draft PR to a PR

@zakird could you please approve this one?


Could you please also publish to https://open-vsx.org/

Could you please also publish to https://open-vsx.org/?
So we can use it in VSCodium (open source rebuild of VSCode).

We have already listed this extension on open-vsx, you can find it here: https://open-vsx.org/extension/ktiays/aicursor

Thanks.


Declarative framework version + Automatic API spec parser

Nice PR! :fire:

It is not ready yet. I have to polish the code and to add a documentation.


Correct handling of auto save

Fixes a bug in #62, #61

Thanks for the bugfix, you're correct. Unfortunately, this change is not backwards compatible (compared to 4.0.0). If I'm not mistaken, the method should read as follows:
    private function shouldHandle(AssetEvent|DataObjectEvent|DocumentEvent $event): bool
    {
        if (!self::$isEnabled) {
            return false;
        }

        $isAutoSave = $event->hasArgument('isAutoSave') && $event->getArgument('isAutoSave') === true;

        if ($event instanceof AssetEvent && (!$isAutoSave || $this->configurationRepository->shouldHandleAssetAutoSave())) {
            return true;
        }

        if ($event instanceof DataObjectEvent && (!$isAutoSave || $this->configurationRepository->shouldHandleDataObjectAutoSave())) {
            return true;
        }

        if ($event instanceof DocumentEvent && (!$isAutoSave || $this->configurationRepository->shouldHandleDocumentAutoSave())) {
            return true;
        }

        return false;
    }

What do you think?

Your solution does the same thing as what I proposed but mine is slightly more readable, because of the early exit when there is no autosave.
We already assessed, that the event is one of AssetEvent,DataObjectEvent or DocumentEvent so imho there is no need for a check inside the if statements when we could exit early.
Chat GPT Agrees:

The two provided PHP code snippets, despite slight structural differences, essentially perform the same functional checks due to the constraints imposed by the method's signature, which specifies the allowed event types (AssetEvent, DataObjectEvent, DocumentEvent). In both snippets, all non-auto-save events are processed (because if the event is not an auto-save, the function returns true), and auto-save events are only processed if they match the allowed event types and if the specific auto-save configuration for that event type is enabled (e.g., shouldHandleAssetAutoSave for an AssetEvent). Therefore, despite their differences in structure and condition checks, both code snippets are functionally equivalent in terms of handling these specified event types and considering the auto-save condition.


Architecture documentation

We should have a file, explaining the architecture and the different concepts behind it, in detail.

Please use Gliffy to create architecture diagrams that can be exported as images and embedded within an architecture.md document.

@ThomasBurleson Sure, I'll use them once I found any case, where some diagrams are appropriated. Can't think about anything right now.

@DevVersion - please work on this soon. Angular Material v1.1.0 is being released this week and the material-tools is included in that announcement.

Closed with #18


Lint for stopPropagation calls in JavaScript

What are you trying to accomplish?

There was an incident last week that resulted in dotcom's global nav list appearing to load forever. The issue was caused by adding a stopPropagation() call to the dialog invoker's click event handler, which prevented dotcom's own click handler from running.
Except in very specific circumstances, we should not be swallowing events using stopPropagation. See this article for an explanation. This PR adds eslint rules for both stopPropagation and stopImmediatePropagation. The idea here isn't to stop us from ever using these functions, but to make sure we consider the ramifications of doing so before disabling the lint rule.
This PR also disables the lint rule for all the places we currently call stopPropagation and stopImmediatePropagation. I will file a separate issue for auditing these existing usages.
Integration

No changes necessary in production; this change is dev-only.
List the issues that this change affects.
Fixes https://github.com/github/primer/issues/3034
Risk Assessment

[x] Low risk the change is small, highly observable, and easily rolled back.
[ ] Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
[ ] High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

@keithamus yeah, I understand where you're coming from, it is absolutely the right tool for the job in certain scenarios. Personally tho I don't feel like adding a disable is very much friction. It's designed to make us pause momentarily and maybe ask about the need for stopPropagation() when reviewing code. Plus, if we feel like it's too onerous, we can always remove the linter; it's only a few lines of config.


BigValue Format Tag Error on data update

The most basic way to reproduce:
<script>
  import { BigValue } from '@evidence-dev/core-components';

  let testData = [{ test: 1 }];
  setTimeout(() => {
    testData = [{ test: 2 }];
  }, 1000);
</script>

<BigValue data={testData} value="test" />

on the second render (after the 1000ms timeout), I get an exception:
Uncaught (in promise) potentialFormatTag.toLowerCase is not a function

I've just repro'd this error again:
https://github.com/evidence-dev/northstar-report

Run the project
Change some sql

Error:

@archiewood I don't think the fix has released yet, still in #1045

Ah, that tracks


[Bugfix/LIVE-11132]: add ptxSwapMoonpayProviderEnabled as an identity and tracker analytics property

📝 Description

add ptxSwapMoonpayProviderEnabled as an identity and tracker analytics property.
remove from swap page since it is now an extra property for all events.

❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-11132
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

[x] npx changeset was attached.
[ ] Covered by automatic tests.
[x] Impact of the changes:

🧐 Checklist for the PR Reviewers

[ ] The code aligns with the requirements described in the linked JIRA or GitHub issue.
[ ] The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
[ ] There are no undocumented trade-offs, technical debt, or maintainability issues.
[ ] The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
[ ] Any new dependencies have been justified and documented.
[ ] Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Do we want this on LLM as well? Or just desktop?

@beths-ledger This is good for desktop only.


Question: Completed handler

I  tried to add a completed handler to the justcoroutines sample:
async.Completed([](auto const & /sender/, AsyncStatus s)
{
printf("completed\n");
});
This throws an exception (winrt::hresult_illegal_delegate_assignment) because await_adapter::await_suspend also tries to register a completed handler.
Shouldn't await_adapter::await_suspend not honour any existing completion handler and call it in its own completed handler?

The Windows Runtime’s async pattern does not permit more than one completed handler because reasoning about the correctness of what you suggest is simply too problematic in general. What if a third caller decides to do the same…
Anyway, you have three choices – get(), co_await, and Completed – and are certainly capable of achieving this level of composability given the primitives provided by C++/WinRT. Rather than providing your own Completed handler, simply use get() or co_await to do the Completion handling and then chain your own completion logic to the end of one of those.


Release grpc 1.30

I think we should also release 1.31, but want to make sure we have this first.

Does this mean, that we need to switch to<EMAIL_ADDRESS>in Golang too?

Does this mean, that we need to switch to<EMAIL_ADDRESS>version in Golang too?

I don't see that anywhere in this repo - we just use google.golang.org/grpc without a version.

Does this mean, that we need to switch to<EMAIL_ADDRESS>version in Golang too?

I don't see that anywhere in this repo - we just use google.golang.org/grpc without a version.

No. I'm asking about go-commo(https://github.com/namely/go-common/blob/master/go.mod#L50) and other services.

Does this mean, that we need to switch to<EMAIL_ADDRESS>version in Golang too?

I don't see that anywhere in this repo - we just use google.golang.org/grpc without a version.

No. I'm asking about go-commo(https://github.com/namely/go-common/blob/master/go.mod#L50) and other services.

We will when we update to this version in the protorepo (and your service updates the protorepo reference)

OK. Looks good in go-common test - https://github.com/namely/go-common/pull/343


Linker abi:cxx11 issues when or-tools is used as a library

When or-tools is used as a library, some functionality related to string manipulation cannot be used as is in C++11 code.
I am getting the following linker errors:
(.text+0xd9f): undefined reference to `StrCat[abi:cxx11](AlphaNum const&, AlphaNum const&)

Environment:
gcc 6.3.0
Debian Stretch
Investigation:
Seems that the problem can be solved by adding -D_GLIBCXX_USE_CXX11_ABI=1.
Workaround:
Use different functions for string manipulation.

2 answers:

We have integrated abseil-cpp in the library. This will help using these libraries.
or-tools needs c++11 support.

Closing the issue.


Add S3 dropoff pipeline example for Jenkins

Add S3 dropoff pipeline example for Jenkins.
This ticket can be closed when a demonstrator exists for how to use S3 to push data out from the Jenkins pipeline to idg.berkeleybop.io .

@justaddcoffee This is functionally done on issue-82-s3-push. Scavange, close, etc. as needed.

excellent, thanks @kltm


Skip version numbers

In order to fix dmfs/oauth2-essentials#83 we need to skip a few version numbers. The best idea is probably to jump directly to 1.21.3

Republished 0.21.3 as 1.21.3


Update search-cloud-based-mailboxes-for-on-premises-users.md

with the exchange workitem 1888394
it has being enabled ww for the whole tenants

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks


NIFI-5744: Put exception message to attribute while ExecuteSQL fail

Put exception message to flowfile attribute if exception occur.
Add unit test to ExecuteSQL, ExecuteSQLRecord.
Update document annotation.
Similar exception catching also implement in other processors like InvokeHTTP, GenerateTableFetch.
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Reviewing...

Just to connect the dots here, there is some dissent from the PMC about this approach, so we should do our best to reach consensus on the mailing list before this PR is merged, in case the direction changes (switch from an attribute to additional outgoing relationships, e.g.)

Thanks for the remind, there are some nice discussions in the mailing list.
I'll fix capitalization after we have consensus.

@mattyb149 Not sure if you've seen my latest reply to the email chain, but it looks like this is already a standard pattern used in ~12 other processors. Would love to see the discussion come to a conclusion in the email chain though.

Hey, @yjhyjhyjh0, can you rebase against master and push a new squashed commit? I think this is ready to merge if we resolve this new code conflict.

Thanks for the suggestion.
Rebase against master, solve conflicts and squash into single commit.


Dev Issues

Can't run debug with Xcode 14.0.1

[x] fixed by uncomment and change "platform": ios, "11.0" => "platform": ios, "140"


Revise Status Badge Component

Description of issue:

Revise the StatusBadge to be an actual component that accepts props, and could be used like this:

// Renders gray
<StatusBadge type={'notice'}>Registration Required</StatusBadge>

// Renders yellow
<StatusBadge type={'alert'}>Cancelled</StatusBadge>

[ ] Add the StatusBadge component
[ ] Integrate with Storybook
[ ] Write basic tests

Looks like this:

Component in question (if applicable):

Status Badge

Metronome Link (if applicable):

Metronome

Figma Link (if applicable):

Figma

Updated the design link.


Don't check for new articles on startup broken

Vienna always checks for new articles on startup even when the preference is disabled.

From my observations (through requests to allow access to Keychain), it's not "always". It's occasional on relaunches.
Try this experience:

wait the scheduled refresh to occur
quit the app and relaunch it

It this is done in a short time interval, the refresh does not occur immediately after the relaunch.
Since the switch to NSBackgroundActivityScheduler (#1311), the OS has some discretion regarding when the task is executed. Apparently, as the identifier of the scheduler is persistent, the system can "guess" if it's interesting or not to redo something it did recently…

I did not come across any cross-launch persistence in the documentation. I wonder if it can be avoided by invalidating the refresh scheduler before quitting Vienna, e.g. in -dealloc.

I wonder if it can be avoided by invalidating the refresh scheduler before quitting Vienna, e.g. in -dealloc.

I think it's fine as it is : the "Check for new articles on start up" option is respected when it is activated. If it isn't, we have a "smart" timer.
I think we should change the default behavior : "Check for new articles on start up" should be unchecked on initial setup of the application.

I think the forced refresh at startup should give the system a signal that a refresh happened, so that it does not call the refresh handler too soon after. It could be achieved by scheduling the activity immediately upon startup and then scheduling the regular one afterwards. I am also thinking that NSBackgroundActivityScheduler is likely better moved to RefreshManager.
I think that NSBackgroundActivityScheduler ties into xpc/activity.h somehow, maybe it is even a wrapper for it. It does not seem to give any other options though.

This might actually be due to this option in my preferences which hasn't worked before (because I've never left Vienna open for 3 hours...)

I'll keep an eye on it and see what happens.


Update version of Boost used on Travis, commit keyword to update cached dependencies

Uses Boost 1.65 for all builds except with gcc-4.9; configurations can be built using Boost 1.61 by adding a MINIMUM_DEPENDENCIES=true environment variable. Boost installation commands have been put in their own function.
Recognizes [update_cache] in commit messages to purge the contents of the dependencies directory, or if the commit message also contains boost or zmq, it will only remove the dependencies mentioned in the commit message.

just to be clear the cache for boost and zmq will only be updated if the commit contains [update_cache] and the "boost" note will be ignored if there is no [update_cache] flag.
We will have to be careful on squash commit to remove that unless desired

Yea, if the update_cache flag isn't there, no updates to the cache will happen (unless it doesn't exist for whatever reason). Worst case, the build takes an extra 5 minutes.


remove homepage js and add class to template

Added

Class "index" to the main element for the homepage template

Removed

JavaScript in homepage template for adding 'index' class to the primary-content div

Changed

Better organized some homepage styles in index.less

@virginiacc this still needs review.

@amymok ready for review

Looks good!


Serialize results with repeated measurements

Fixes #5015
Also had to fix some other results methods to use records instead of measurements, including the default repetitions property implementation, and __eq__ and __add__ methods.

Automerge cancelled: A required status check is not present.
Missing statuses: ['Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage']


I cant see if this has been fixed but it seems to not like my user id

Error: Error { tag: Tag(Default, 1), profile: Some(Profile(Uncased { string: "default" })), metadata: Some(Metadata { name: "TOML file", source: Some(File("C:\Users\me\Desktop\NotHax\aeode\config.toml")), provide_location: Some(Location { file: "src\lib\config.rs", line: 22, col: 14 }), interpolater:  }), path: ["DISCORD_USER_ID"], kind: InvalidType(Str("629700611994157057"), "u64"), prev: None }

this is my toml config
DISCORD_TOKEN="Token" SPOTIFY_USERNAME="aa" SPOTIFY_PASSWORD="a" DISCORD_USER_ID="629700611994157057"

I had this same issue, turns out you don't need to but the quotation marks around the DISCORD_USER_ID

@StellarJay77 now im getting Error: Error { tag: Tag::Default, profile: Some(Profile(Uncased { string: "default" })), metadata: None, path: [], kind: DuplicateField("discord_token"), prev: None }

Error: Error { tag: Tag::Default, profile: Some(Profile(Uncased { string: "default" })), metadata: None, path: [], kind: DuplicateField("discord_token"), prev: None }

Just to be clear, is the toml config all on the same line or is each key pair on a separate line like the example?

@codetheweb

Error: Error { tag: Tag::Default, profile: Some(Profile(Uncased { string: "default" })), metadata: None, path: [], kind: DuplicateField("discord_token"), prev: None }

this was fixed by putting it in lower case but now im getting
$ '/c/Users/Fizz/Desktop/aoede/windows-latest-aoede.exe' Client ended: Http(UnsuccessfulRequest(ErrorResponse { status_code: 401, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("discord.com")), port: None, path: "/api/v10/users/@me", query: None, fragment: None }, error: DiscordJsonError { code: 0, message: "401: Unauthorized", errors: [] } }))

my discord is 𝒻𝒾𝓏𝓏⛤#6666 if you want to msg me thru there for a quicker response

Did you try the other method using setx? If so, you may need to go into windows environment variables and delete the environment variable you created. Win+R > "C:\Windows\system32\rundll32.exe" sysdm.cpl,EditEnvironmentVariables

@StellarJay77 yeah lol

deleted em now

thx

it has the code grant but still comes up with

Doesn't look like you authorized or invited your bot to your discord sever.

wdym?

@StellarJay77

You need to generate an html link and invite your bot to your server. You
select bot and system.control then I just gave my bot admin rights. Copy
and paste the invite link into your browser and authorize the bot for your
server.
On Sun, Feb 5, 2023, 2:34 p.m. Fizz @.***> wrote:

[image: image]
https://user-images.githubusercontent.com/88443296/216849798-699bbb9a-1a46-48ef-a4d0-2f0c74d658e7.png
@StellarJay77 https://github.com/StellarJay77
—
Reply to this email directly, view it on GitHub
https://github.com/codetheweb/aoede/issues/34#issuecomment-1418283586,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOVOEJVVM3VF5UBKS5DRG4LWWATI3ANCNFSM6AAAAAAUOHVPAA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@StellarJay77 wheres system.control?

Sorry applications.commands
On Sun, Feb 5, 2023, 2:55 p.m. Fizz @.***> wrote:

@StellarJay77 https://github.com/StellarJay77 wheres system.control?
[image: image]
https://user-images.githubusercontent.com/88443296/216850696-f37641af-d7c1-4d9e-9ce9-6b6916287301.png
—
Reply to this email directly, view it on GitHub
https://github.com/codetheweb/aoede/issues/34#issuecomment-1418287888,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOVOEJVOA3XC54XQWRLKMJ3WWAVXVANCNFSM6AAAAAAUOHVPAA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sorry applications.commands
…
On Sun, Feb 5, 2023, 2:55 p.m. Fizz @.> wrote: @StellarJay77 https://github.com/StellarJay77 wheres system.control? [image: image] https://user-images.githubusercontent.com/88443296/216850696-f37641af-d7c1-4d9e-9ce9-6b6916287301.png — Reply to this email directly, view it on GitHub <#34 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOVOEJVOA3XC54XQWRLKMJ3WWAVXVANCNFSM6AAAAAAUOHVPAA . You are receiving this because you were mentioned.Message ID: @.>

ok i did this but now it isnt adding to the servers

is there a specific redirect or anything i need?

Nope, just copy the generated URL into a browser, sign into your discord
account and assign the bot to a server you have admin access to.
On Sun, Feb 5, 2023, 3:10 p.m. Fizz @.***> wrote:

is there a specific redirect or anything i need?
—
Reply to this email directly, view it on GitHub
https://github.com/codetheweb/aoede/issues/34#issuecomment-1418291441,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOVOEJQRYKAVVXZTTKXGWWTWWAXOBANCNFSM6AAAAAAUOHVPAA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@StellarJay77 I tried that it goes to the redirect and just doesn't add the bot

You have to have admin or owner privilages to the server you are trying to
add the bot to.
On Sun, Feb 5, 2023, 4:20 p.m. Fizz @.***> wrote:

@StellarJay77 https://github.com/StellarJay77 I tried that it goes to
the redirect and just doesn't add the bot
—
Reply to this email directly, view it on GitHub
https://github.com/codetheweb/aoede/issues/34#issuecomment-1418313741,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOVOEJUS2DVMF7THXMR7SRTWWA7U5ANCNFSM6AAAAAAUOHVPAA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I tried a server I'm owner on and a server I'm admin on and neither worked

Not sure then if the bot is not being added to your server.
On Sun, Feb 5, 2023, 4:44 p.m. Fizz @.***> wrote:

I tried a server I'm owner on and a server I'm admin on and neither worked
—
Reply to this email directly, view it on GitHub
https://github.com/codetheweb/aoede/issues/34#issuecomment-1418327877,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOVOEJX7DINDJZNT2V24WYLWWBCOPANCNFSM6AAAAAAUOHVPAA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hopefully @codetheweb or someone can help then

It might be getting added to your guild, but it appears as offline until you're in a voice channel--could you double-check it's not just offline? (This behavior is confusing and I think it should probably be changed.)

It 8snt I checked the offline and the logs

When using the url from the console
https://user-images.githubusercontent.com/88443296/217313653-f10a05e3-339b-4e2e-b553-0c35da3af854.mp4
When making own link
https://user-images.githubusercontent.com/88443296/217315338-20e21639-a1eb-4ce0-bae9-18ce57e59851.mp4

For your own link you chose applications.commands.permissions.uupdate not applications.commands which is in the last column on the right.

yh swapped but does the same thing

This isnt an issue with the application, it's with your bot being authenticated with your discord server. I noted that it wasn't requesting admin access either. It's like you don't have permissions on that account to add bots to your server.

This isnt an issue with the application, it's with your bot being authenticated with your discord server. I noted that it wasn't requesting admin access either. It's like you don't have permissions on that account to add bots to your server.

how tf does that work lmao i tried on multiple servers

Don't know. I would suggest bringing it up in the discord community.

Don't know. I would suggest bringing it up in the discord community.

hhmm, alright

Tried new server and new bot
https://user-images.githubusercontent.com/88443296/217362304-6014b1ba-2ce8-40f8-adff-b7acd6d6125f.mp4

So you were able to get the bot to join the server?

no

Maybe try a different browser.

wanna add me on discord and we speak there n i just log the outcome here?
also imma try now

the bot works (without commands) i tested it on an old bot

I'm working at the moment but I might be able to later. The way this all works is you run the application on your PC and it acts like a bridge between your Spotify account and the bot in your discord server. The bot is told to follow your user account into the voice channel you are connected to and stream the audio from Spotify to that channel. Until you can get a bot to join your discord server you won't be able to do anything.

I'm working at the moment but I might be able to later. The way this all works is you run the application on your PC and it acts like a bridge between your Spotify account and the bot in your discord server. The bot is told to follow your user account into the voice channel you are connected to and stream the audio from Spotify to that channel. Until you can get a bot to join your discord server you won't be able to do anything.

Yeah i tried it on one of my old bot tokens that was already in the server and it did what it said on the box lol

i think its a bug with my dev acc cuz i tried adding it from my alt and it didnt work


Move to PHP 7.4

Coverage decreased (-0.003%) to 97.739% when pulling 7bd34cfa5ced99873ade9abf5fbcdb64c146d080 on feature/move-to-php7-4-features into 8d19ce245a8cd75c7067c21f70f1b7ad0cff51f2 on master.