Problem with Electron 4.x.x & Node v.11.11.0

Summary of Problem

I have an Up Board: https://up-board.org/up/specifications/

I have installed Ubuntu 18.04 on it according to their documentation:
https://wiki.up-community.org/Ubuntu (scroll down to Ubuntu 18.04 installation and configuration)

Please take note that for this Up Board I had to install Ubuntu kernel 4.15.0 for UP from PPA on Ubuntu 18.04. ==> It's all on the same page (wiki link above)
This may be an important detail for this issue.

I installed Electronjs and my application is running just fine. So far so good. I then have:

installed electron-rebuild

added it to my json file ==> “install” : “electron-rebuild",

I run npm install ==> everything good so far

I installed serialport ==> npm i --save serialport

I run again ==> npm install ==> ERROR (Log shown below)

Can anyone help please?
========================THE ERROR MSG============================
An unhandled error occurred inside electron-rebuild
make: Entering directory '/home/dan/Desktop/samapp/node_modules/@serialport/bindings/build'
CXX(target) Release/obj.target/bindings/src/serialport.o
In file included from ../../../nan/nan_converters.h:67:0,
from ../../../nan/nan.h:222,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
../../../nan/nan_converters_43_inl.h: In static member function ‘static Nan:: imp ::ValueFactoryBase::return_t Nan:: imp ::ToFactory::convert(v8::Localv8::Value)’:
../../../nan/nan_converters_43_inl.h:60:46: error: no matching function for call to ‘v8::Value::BooleanValue(v8::Isolate*&)’
return Just(val->BooleanValue(isolate));
^
In file included from /home/dan/.electron-gyp/4.0.7/include/node/node.h:67:0,
from ../../../nan/nan.h:53,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
/home/dan/.electron-gyp/4.0.7/include/node/v8.h:2580:37: note: candidate: v8::Maybe v8::Value::BooleanValue(v8::Localv8::Context) const
V8_WARN_UNUSED_RESULT Maybe BooleanValue(Local context) const;
^~~~~~~~~~~~
/home/dan/.electron-gyp/4.0.7/include/node/v8.h:2580:37: note:   no known conversion for argument 1 from ‘v8::Isolate*’ to ‘v8::Localv8::Context’
In file included from /home/dan/.electron-gyp/4.0.7/include/node/v8.h:26:0,
from /home/dan/.electron-gyp/4.0.7/include/node/node.h:67,
from ../../../nan/nan.h:53,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
/home/dan/.electron-gyp/4.0.7/include/node/v8.h:2588:47: note: candidate: bool v8::Value::BooleanValue() const
V8_DEPRECATE_SOON("Use maybe version", bool BooleanValue() const);
^
/home/dan/.electron-gyp/4.0.7/include/node/v8config.h:346:48: note: in definition of macro ‘V8_DEPRECATE_SOON’
#define V8_DEPRECATE_SOON(message, declarator) declarator
^~~~~~~~~~
/home/dan/.electron-gyp/4.0.7/include/node/v8.h:2588:47: note:   candidate expects 0 arguments, 1 provided
V8_DEPRECATE_SOON("Use maybe version", bool BooleanValue() const);
^
/home/dan/.electron-gyp/4.0.7/include/node/v8config.h:346:48: note: in definition of macro ‘V8_DEPRECATE_SOON’
#define V8_DEPRECATE_SOON(message, declarator) declarator
^~~~~~~~~~
../src/serialport.cpp: In function ‘Nan::NAN_METHOD_RETURN_TYPE Open(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/serialport.cpp:41:75: warning: ‘v8::String::Utf8Value::Utf8Value(v8::Localv8::Value)’ is deprecated: Use Isolate version [-Wdeprecated-declarations]
v8::String::Utf8Value path(Nan::Tov8::String(info[0]).ToLocalChecked());
^
In file included from /home/dan/.electron-gyp/4.0.7/include/node/v8.h:26:0,
from /home/dan/.electron-gyp/4.0.7/include/node/node.h:67,
from ../../../nan/nan.h:53,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
/home/dan/.electron-gyp/4.0.7/include/node/v8.h:3007:28: note: declared here
explicit Utf8Value(Localv8::Value obj));
^
/home/dan/.electron-gyp/4.0.7/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
declarator attribute((deprecated(message)))
^~~~~~~~~~
bindings.target.mk:104: recipe for target 'Release/obj.target/bindings/src/serialport.o' failed
make: Leaving directory '/home/dan/Desktop/samapp/node_modules/@serialport/bindings/build'
make: *** [Release/obj.target/bindings/src/serialport.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/dan/Desktop/samapp/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:197:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
gyp ERR! System Linux 4.15.0-37-generic
gyp ERR! command "/usr/local/bin/node" "/home/dan/Desktop/samapp/node_modules/.bin/node-gyp" "rebuild" "--target=4.0.7" "--arch=x64" "--dist-url=https://atom.io/download/electron" "--build-from-source"
gyp ERR! cwd /home/dan/Desktop/samapp/node_modules/@serialport/bindings
gyp ERR! node -v v11.11.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
Failed with exit code: 1
Error: make: Entering directory '/home/dan/Desktop/samapp/node_modules/@serialport/bindings/build'
CXX(target) Release/obj.target/bindings/src/serialport.o
In file included from ../../../nan/nan_converters.h:67:0,
from ../../../nan/nan.h:222,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
../../../nan/nan_converters_43_inl.h: In static member function ‘static Nan:: imp ::ValueFactoryBase::return_t Nan:: imp ::ToFactory::convert(v8::Localv8::Value)’:
../../../nan/nan_converters_43_inl.h:60:46: error: no matching function for call to ‘v8::Value::BooleanValue(v8::Isolate*&)’
return Just(val->BooleanValue(isolate));
^
In file included from /home/dan/.electron-gyp/4.0.7/include/node/node.h:67:0,
from ../../../nan/nan.h:53,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
/home/dan/.electron-gyp/4.0.7/include/node/v8.h:2580:37: note: candidate: v8::Maybe v8::Value::BooleanValue(v8::Localv8::Context) const
V8_WARN_UNUSED_RESULT Maybe BooleanValue(Local context) const;
^~~~~~~~~~~~
/home/dan/.electron-gyp/4.0.7/include/node/v8.h:2580:37: note:   no known conversion for argument 1 from ‘v8::Isolate*’ to ‘v8::Localv8::Context’
In file included from /home/dan/.electron-gyp/4.0.7/include/node/v8.h:26:0,
from /home/dan/.electron-gyp/4.0.7/include/node/node.h:67,
from ../../../nan/nan.h:53,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
/home/dan/.electron-gyp/4.0.7/include/node/v8.h:2588:47: note: candidate: bool v8::Value::BooleanValue() const
V8_DEPRECATE_SOON("Use maybe version", bool BooleanValue() const);
^
/home/dan/.electron-gyp/4.0.7/include/node/v8config.h:346:48: note: in definition of macro ‘V8_DEPRECATE_SOON’
#define V8_DEPRECATE_SOON(message, declarator) declarator
^~~~~~~~~~
/home/dan/.electron-gyp/4.0.7/include/node/v8.h:2588:47: note:   candidate expects 0 arguments, 1 provided
V8_DEPRECATE_SOON("Use maybe version", bool BooleanValue() const);
^
/home/dan/.electron-gyp/4.0.7/include/node/v8config.h:346:48: note: in definition of macro ‘V8_DEPRECATE_SOON’
#define V8_DEPRECATE_SOON(message, declarator) declarator
^~~~~~~~~~
../src/serialport.cpp: In function ‘Nan::NAN_METHOD_RETURN_TYPE Open(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/serialport.cpp:41:75: warning: ‘v8::String::Utf8Value::Utf8Value(v8::Localv8::Value)’ is deprecated: Use Isolate version [-Wdeprecated-declarations]
v8::String::Utf8Value path(Nan::Tov8::String(info[0]).ToLocalChecked());
^
In file included from /home/dan/.electron-gyp/4.0.7/include/node/v8.h:26:0,
from /home/dan/.electron-gyp/4.0.7/include/node/node.h:67,
from ../../../nan/nan.h:53,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
/home/dan/.electron-gyp/4.0.7/include/node/v8.h:3007:28: note: declared here
explicit Utf8Value(Localv8::Value obj));
^
/home/dan/.electron-gyp/4.0.7/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
declarator attribute((deprecated(message)))
^~~~~~~~~~
bindings.target.mk:104: recipe for target 'Release/obj.target/bindings/src/serialport.o' failed
make: Leaving directory '/home/dan/Desktop/samapp/node_modules/@serialport/bindings/build'
make: *** [Release/obj.target/bindings/src/serialport.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/dan/Desktop/samapp/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:197:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
gyp ERR! System Linux 4.15.0-37-generic
gyp ERR! command "/usr/local/bin/node" "/home/dan/Desktop/samapp/node_modules/.bin/node-gyp" "rebuild" "--target=4.0.7" "--arch=x64" "--dist-url=https://atom.io/download/electron" "--build-from-source"
gyp ERR! cwd /home/dan/Desktop/samapp/node_modules/@serialport/bindings
gyp ERR! node -v v11.11.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
Failed with exit code: 1
at SafeSubscriber._error (/home/dan/Desktop/samapp/node_modules/spawn-rx/lib/src/index.js:267:84)
at SafeSubscriber.__tryOrUnsub (/home/dan/Desktop/samapp/node_modules/rxjs/internal/Subscriber.js:207:16)
at SafeSubscriber.error (/home/dan/Desktop/samapp/node_modules/rxjs/internal/Subscriber.js:158:26)
at Subscriber._error (/home/dan/Desktop/samapp/node_modules/rxjs/internal/Subscriber.js:92:26)
at Subscriber.error (/home/dan/Desktop/samapp/node_modules/rxjs/internal/Subscriber.js:72:18)
at MapSubscriber.Subscriber._error (/home/dan/Desktop/samapp/node_modules/rxjs/internal/Subscriber.js:92:26)
at MapSubscriber.Subscriber.error (/home/dan/Desktop/samapp/node_modules/rxjs/internal/Subscriber.js:72:18)
at SafeSubscriber._next (/home/dan/Desktop/samapp/node_modules/spawn-rx/lib/src/index.js:242:65)
at SafeSubscriber.__tryOrUnsub (/home/dan/Desktop/samapp/node_modules/rxjs/internal/Subscriber.js:207:16)
at SafeSubscriber.next (/home/dan/Desktop/samapp/node_modules/rxjs/internal/Subscriber.js:145:22)
npm ERR! code ELIFECYCLE
npm ERR! errno 255
npm ERR<EMAIL_ADDRESS>install: electron-rebuild
npm ERR! Exit status 255
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/dan/.npm/_logs/2019-03-14T22_44_50_163Z-debug.log

I switched to Node Version v10.13.0 and this solved the problem.
It seems that v11.11.0 probably triggers the problem.
==> Is this issue known?
If someone else runs into this issue and you are just starting off: use nvm to install node version v10.13.0.

I ran into this problem also.  I think Serialport doesn't play well with Electron 4.x because there's no "binding.gyp" in the root of the project, which (I think) Electron requires to rebuild the library for it's version of Node.
gyp: binding.gyp not found (cwd: /Users/dstein/electron-app/node_modules/serialport) while trying to load binding.gyp
.gyp info it worked if it ends with ok
 gyp info using<EMAIL_ADDRESS> gyp info using<EMAIL_ADDRESS>| darwin | x64
 gyp info spawn /usr/local/bin/python2
 gyp info spawn args [ '/Users/dstein/.config/yarn/global/node_modules/node-gyp/gyp/gyp_main.py',
 gyp info spawn args   'binding.gyp',
 gyp info spawn args   '-f',
 gyp info spawn args   'make',
 gyp info spawn args   '-I',
 gyp info spawn args   '/Users/dstein/electron-app/node_modules/serialport/build/config.gypi',
 gyp info spawn args   '-I',
 gyp info spawn args   '/Users/dstein/.config/yarn/global/node_modules/node-gyp/addon.gypi',
 gyp info spawn args   '-I',
 gyp info spawn args   '/Users/dstein/.electron-gyp/.node-gyp/4.1.4/include/node/common.gypi',
 gyp info spawn args   '-Dlibrary=shared_library',
 gyp info spawn args   '-Dvisibility=default',
 gyp info spawn args   '-Dnode_root_dir=/Users/dstein/.electron-gyp/.node-gyp/4.1.4',
 gyp info spawn args   '-Dnode_gyp_dir=/Users/dstein/.config/yarn/global/node_modules/node-gyp',
 gyp info spawn args   '-Dnode_lib_file=/Users/dstein/.electron-gyp/.node-gyp/4.1.4/<(target_arch)/node.lib',
 gyp info spawn args   '-Dmodule_root_dir=/Users/dstein/electron-app/node_modules/serialport',
 gyp info spawn args   '-Dnode_engine=v8',
 gyp info spawn args   '--depth=.',
 gyp info spawn args   '--no-parallel',
 gyp info spawn args   '--generator-output',
 gyp info spawn args   'build',
 gyp info spawn args   '-Goutput_dir=.' ]
 gyp: binding.gyp not found (cwd: /Users/dstein/electron-app/node_modules/serialport) while trying to load binding.gyp
 gyp ERR! configure error
 gyp ERR! stack Error: `gyp` failed with exit code: 1
 gyp ERR! stack     at ChildProcess.onCpExit (/Users/dstein/.config/yarn/global/node_modules/node-gyp/lib/configure.js:336:16)
 gyp ERR! stack     at ChildProcess.emit (events.js:189:13)
 gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
 gyp ERR! System Darwin 18.2.0
 gyp ERR! command "/usr/local/bin/node" "/usr/local/bin/node-gyp" "rebuild" "--target=4.1.4" "--arch=x64" "--dist-url=https://atom.io/download/electron"
 gyp ERR! cwd /Users/dstein/electron-app/node_modules/serialport
 gyp ERR! node -v v11.4.0
 gyp ERR! node-gyp -v v3.6.2
 gyp ERR! not ok

I see them here in the repo https://github.com/node-serialport/node-serialport/tree/master/packages/bindings
But when I do npm install serialport the file isn't there, so Electron cannot rebuilt the module:
drwxr-xr-x     8 dstein  staff    256 Apr 10 10:25 .
drwxr-xr-x  1096 dstein  staff  35072 Apr 10 10:25 ..
-rw-r--r--     1 dstein  staff  35669 Oct 26  1985 CHANGELOG.md
-rw-r--r--     1 dstein  staff   1105 Oct 26  1985 LICENSE
-rw-r--r--     1 dstein  staff    181 Oct 26  1985 README.md
drwxr-xr-x     4 dstein  staff    128 Apr 10 10:25 lib
-rw-r--r--     1 dstein  staff   2435 Apr 10 10:25 package.json
-rw-r--r--     1 dstein  staff    230 Oct 26  1985 test.js

I guess maybe the contents of that bindings directory would have to be added to the NPM module.

Oh, perhaps maybe this may be part of the problem.  I'm not sure what the exact solution is, but I suspect that because the bindings.gyp is not in the main "serialport" npm module, that this may be the reason for this error?
gyp: binding.gyp not found (cwd: /Users/dstein/electron-app/node_modules/serialport) while trying to load binding.gyp
Maybe that bindings package would need to be combined for this to work.


[Feature Request] Lighting for multiple moons

Hey there,
first of all, I really love this module. It's just perfect that the lighting is adjusted to suit the time of day. Now that the scene can also be illuminated by the moon phase from the Simple Calendar, I wanted to ask if it would also be possible to support multiple moons?
As far as I know, the illumination is only set on the basis of the first moon.
Simple Calendar offers the possibility to configure several moons and their colour, so it would be great if the second moon could also be taken into account. I would also be happy if the configured colour of the moons in Simple Calendar had an effect on the illumination.
As a side note, I am currently running a Warhammer campaign and there are two moons in the world, one of which (Morrslieb) is green.
Cheers
Berytak

Hiya! Thanks for the kind words, and for the descriptive request. Could you elaborate a bit on how you envision this working?

Aside from colour stuff, what would the multiple moons functionally do in the SmallTime interface?
How should they be represented?
Would the colour of a moon actually impact the Darkness colour of scenes? Feels to me like moon colour on its own wouldn't affect that at all?

Hi @unsoluble
Of course, I'm happy to elaborate a little further.
If I have understood the option "Moon Phase Effects Darkness" correctly, the moon phase simply sets the maximum darkness at night within a scene. But this is only influenced by the first moon configured in Simple Calendar. The second moon has no effect on this option.

In this case only "Mannslieb" affects the darkness setting but not "Morrslieb".
You can also set the colour of the moons in the Simple Calendar options. I don't know if it's possible to change the colour of the global illumination, but I suppose that would be a suitable option.
"Morrslieb" creates an eerie green glow and seeing that in a scene would be awesome without having to adjust the lights every time.
Example of what it could look like.

So let's summarise again:

Moons created in Simple Calendar after the first one should also affect the darkness settings.
It would be great if the scene gets a colour tint of the configured moon colour at night. (A full moon would probably be enough).

But I'm actually not sure if this can be realised and if so, then how.
I apologise if I have not made myself clear, but English is not my first language.
Cheers
Berytak

I want to add to this - it would be nice to be able to configure how bright each moon IS. I have 2 moons and when both are full its nearly as bright as daylight, when one of the moons shouldn't give much light, and if the above was implemented, would really only provide a tint to said light.
So an option to configure how 'bright' each moon is when the setting is enabled would be great, since right now, I have to disable this feature otherwise many nights are too bright.

Can tell you both straight-up that I'm not going to be implementing support for more than one moon — that'd be an exponential nightmare of complexity. Changing the Darkness tint based on a colour pulled from SC is theoretically possible, will look into it. Adding a config for the percentage impact that the phase brightness has on scene Darkness is also feasible. Extremely limited free time these days tho, so might be a while.

Moon tint and phase impact have been added in 1.19.0


awless list records * symbol shown as \052

awless list records --filter name=bla
Wildcard records under NAME show symbol * as \052

Thanks for reporting. We will have a look at that according to current resources to work on that.

Same here


Switch to form

I had to do some things to make the project work locally for me, like remove topbar (your JS setup is different than mine so I assume it works for you).
Screenshot of what I mean:

Also quickly updated core components to look more like what you had, since I used them.

I had switched from keyup to a form before I realized top bar was failing esbuild so I’ll never know if I could have gotten that way to work. Only move forward no looking back never stop never stopping

Also JS version: https://x.com/ryanrwinchester/status/1837091582408892682


[master] Bump Mesos to nightly master 192f435

High-level description
This is a routine bump to the latest Mesos and mesos-modules.
Related JIRA Issues
Checklist for all PRs

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Changelog:
https://github.com/apache/mesos/compare/9127c792c5a20aee2f31a2e56854c2490a9ca608...192f435c23d9052fa960907ebb38be04fa84b308

[ ] Test Results: [link to CI job test results for component]

[ ] Code Coverage (if available): [link to code coverage report]

Closing this as it contains a regression in Mesos. See https://jira.apache.org/jira/browse/MESOS-9177.


hardware in the loop test problem

Hi
I have a problem with hil test. I have changed the SYS_AUTOSTART parameter to 1001. Then I run the jMAVSim in HITL mode and start the QGC(v.2.9.7). I send the missions to vehicle. But when I armed the system, it just rises indefinitely not going to waypoints. I have also done the sensor calibration.

@metusa thanks for reporting. @bkueng and I were able to reproduce the problem. A fix is in the works in  #5716


generate links

link to image in graphite
link to view trigger results

Coverage remained the same at 88.713% when pulling b7d16224d4c5f610b62328a1f9a33a70a1796537 on feature/generate-links into 4395a94a27333d773d879d00a2bd3c16137989b3 on develop.

Coverage remained the same at 88.713% when pulling 26c1df446d68e4df57de243fe8d3a19a84408942 on feature/generate-links into 4395a94a27333d773d879d00a2bd3c16137989b3 on develop.


add cacert action to auto update

defined an action to auto update cacert extracted by the curl team.
Refer: https://curl.se/docs/caextract.html

Upptime bot commits with the message ":arrow_up: update CACERT"
Logs when nothing to commit shows as a failed run, is it okay? or should we have some sort of error-handling to show it as a successful run?

You're right, if we're already on the latest version we should silently ignore that error.

I added the error-handling syntax.
Check-out: Logs when nothing to commit


Cannot set source property dynamically on an angular directive

I was using plyr with angular directive as suggested in http://stackoverflow.com/a/37950692 and it works great.
Now I'm looking to switch between youtube and external video source depending upon some condition. I have removed data-type and data-video-id and trying to use source property on the instance. However I'm getting TypeError: Cannot set property 'source' of undefined
I've created a plnkr to demonstrate the issue. (check browser console)
https://plnkr.co/edit/pARzwIjxBv5imCjr9waA?p=preview
It works fine with template in line 10 (commented) but that in line 11 throws above error. Looks like plyr doesn't find any elements to instantiate, hence it fails.
How to handle this case?
Environment

Browser: Chrome
Version:  55
Operating System: OSX
Version: Sierra

I'm closing this since it's now outdated and phrased as a question. If you still have this issue, please upgrade Plyr in the example and paste the full stack trace. Also our slack is better for questions.


Intermittent Inability to Access Right-Click menu in chat

Some of my players, some of the time, are unable to right click on a chat message (usually to try to use a hero point) and have a menu show up.
This is very vague, and for that I apologize.  It's been happening since our first session months ago, and I've been trying to narrow it down, but there doesn't seem to be rhyme or reason as to why it's happening.  3 of the 6 players have this issue from time to time.  It doesn't seem to be session related -- they can have the menu appear once, not appear two minutes later, and appear again 5 minutes after that.  I believe everyone having issues is using Chrome, but at least one of us that isn't having issues is also using Chrome (one of the non-issue is using Edge).  It's not tied to the message itself, as I have always been able to spawn the menu myself when they are having troubles.
If anyone has any further troubleshooting that could help narrow down, I can try them in our next session.

Unable to reproduce the issue. Will need more info or reliable steps to reproduce it.


locks down ami_builder IAM user to a single VPC

We want to ensure that the IAM user can create/destroy instances
in a specific VDC only to protect other VDCs from accidental or
malicious shutdown of instances.  IAM permissions are quite complicated
and unintuitive. After much trial and error, we successfully followed
the instructions in this Amazon post: http://amzn.to/1ouXPo0
In essence:

create a role with no policy attached (VPCLockDown)
In the user policy, give the user access to:

assign the role to instances
control instances with the role
bring up instances in a specific VPC (only)
global permissions to describe things (to discover resources)

Whereas it's not really obvious why we need to create an instance role,
that is the key to making the user policy work.

Looks good. Merge away.

@jonauman: We should probably scope f18b2e7 to just the subnet and VPC IDs for now, which are the variables will may change and are introduced in this pull request.
I also wonder if those variables should be null, so that they're mandatory and Terraform will fail fast if they're not supplied.

Generally we try to avoid merge commits in branches such as 2cf8499 because they lack any explanation for the changes in the code. Happy to pair to help remove it.

I think this is looking good now but I'll leave this for someone else with more context to review the EC2 permissions.


Feat/258/oob webhooks

requires aca-py 0.7.5
(not yet releassed on pypi, currently in rc0 pre-release state)
closes #258

depends on #249 to be merged (contains changes of #249)

is also addressed in #251


Dependencies azure-sdk-for-go from auth.go no longer exist

https://github.com/masterzen/winrm/blob/master/auth.go
"github.com/masterzen/azure-sdk-for-go/core/http"
"github.com/masterzen/azure-sdk-for-go/core/tls"

Please, fix it.

I don't understand what happens, the repository is definitely here: https://github.com/masterzen/azure-sdk-for-go

@masterzen sorry, it's my mistake, i'll close the issue.
Thank you!


adding beginner level java programs

i will add basic java programs . Please assign me this issue @lovishprabhakar02

@Ishnoor-kaur A very Happy New year to you. May this year be more prosperous and joy filling for you. I'll be assigning this issue to you.

@Ishnoor-kaur A very Happy New year to you. May this year be more prosperous and joy filling for you. I'll be assigning this issue to you.

@Ishnoor-kaur Also @BhavyamSharma7 has already created the folder for Java Program so make sure you add your program in the same.

@Ishnoor-kaur Also @BhavyamSharma7 has already created the folder for Java Program so make sure you add your program in the same.


driver.tap based on x,y co-ordinates

How to do driver.tap based on x,y coordinates on the device

In my use case, this is require to tap on Google Map Marker. Since Google Map is not Flutter widget, none of the current Finder work.


Revert "CDPD-2339, CDPSDX-716, CDPSDX-715 - updated configs with warnings sup…"

Reverts hortonworks/cloudbreak#5886
Does not work with our default CM version. @jasonwmcswain

Unfortunately, it's a long ongoing issue that we cannot commit changes with the default version of CM in CB, because CM does not ignore unknown properties and we cannot upgrade and newer CM builds fail with different errors. We should have a jira to ignore every unknown property. Otherwise, it will be always a battle to get in new properties.


fixing typos in comments and README

The PR corrects typos:

slack -> Slack
langauge -> language
preceed -> precedes
tha -> that
mached -> matched
unit -> uint

Fixes #257
Fixes #258

THANK YOU for this. Do you think we can add the corrects from the two issues that are open. Essentially where unsigned int is labeled as unit instead of unit?

@ardan-bkennedy done

Do you think we can add the corrections from the two issues that are open

Yes, I fixed by replacing unit with uint in the sentence When you declare a type using a non-precision based type (uint, int).

Can you also make sure your name is in the CONTRIBUTORS File.

Added.


Adding packagaes

Hi -
I was wondering about the polices for this image regarding adding packages. Specifically, I was wondering if we could get gcloud preinstalled? I would also be interested in poppler-utils (pfd information and manipulation). Would PR for these be desired?
My use case is having these packages available in GCF.
Thanks!

Thanks for opening this issue.  I will talk to the appropriate teams to determine if this is possible.

After looking at this more, we would prefer not adding additional packages to the base image unless there is a need by many users for those packages.
This is first because the additional packages will cause the image to become bigger, and we don't want the image to be bigger than it needs to.
Second, if you need, you can create a custom Dockerfile derived from the base image in this repo and add the custom packages that you need.
Based on this, I am going to close this issue at this time, but let me know if you want to discuss this topic more.

My goal in adding the packages was to make them available in GCF. Is there
another way to do that?
On Mon, Jul 9, 2018, 7:39 PM Dominic Kramer<EMAIL_ADDRESS>wrote:

Closed #169
https://github.com/GoogleCloudPlatform/nodejs-docker/issues/169.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/nodejs-docker/issues/169#event-1723597279,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAR4jINxYMfJOWuvvDPC7VZCIJq0ZhGeks5uE4csgaJpZM4UGlnA
.


Add authentication to vendors controller

Why was this change made? 🤔
Fixes #58
This commit contains more work that initially expected as I worked in the UI to ensure authentication was working for vendor interactions. This led to other bits of work:

Make a clearer delineation between authentication-related controllers (LoginController), UI controllers, and API controllers (#61)
Use REMOTE_USER in bin/dev to handle authentication in local dev (and add to README)
Rename stats controller (+ views + route) for consistency with other controllers, now that that list has grown
Wire up basic vendor interactions in UI for easier testing (both in browser and in RSpec)
Use the folio_id param of vendors as the ID in the route (which the controller was only doing, and which I only found once the views were written up)

This commit also brings coverage back up to 💯
How was this change tested? 🤨
CI

@ndushay 💬

a couple comments for your consideration. Mostly praise. We inadvertently crashed a little so it would be great to get this merged ASAP.

Made all the changes, so this is ready for another look.
Thanks for the review, and hope we didn't crash too badly!


PROPOSAL: Allow scrape_timeout and scrape_interval to be configured via relabeling (i.e. based on kubernetes_sd annotations)

Proposal
Prometheus allows to configure a global scrape_timeout value but also allows to set an override for each job - https://prometheus.io/docs/prometheus/latest/configuration/configuration/#scrape_config
This allows to only selectively set higher timeouts, i.e. if there is a rather slow target somewhere. Also running with different scrape_intervals makes sense and is easily configurable.
While it's possible to apply tailored configuration of timeouts just for targets that need special treatment this changes when using service discovery, i.e. the kubernetes_sd to configure the jobs. There the scraping targets and their specifics are not all read from the Prometheus config file, but learned dynamically. Behind each job there could be thousands of targets to scrape rendering any per target "tailoring" of the timeout useless or rather too broad as it will affect all targets not a single target which is usually behind a single statically configured scraping job. But with xyz_sd the jobs are now massive multiplexers.
Labeling allows to override a series of values such as the path and the scheme and I also know there has been a discussion about exposing more scrape_config variables to the labeling https://github.com/prometheus/prometheus/issues/1176 before.
In that very discussion @brian-brazil labeled ability to use dynamic configuration of the scrape_timeout and  scrape_interval a feature request (https://github.com/prometheus/prometheus/issues/1176#event-493205677)
this very feature I now like to propose.
I know it's quite possible to create two or more sets of each job with boolean labels to turn on either one or the other for each target based on some annotation, but this really causes the configuration to become messy, especially if you think about different scrape_interval and well as independently have different scrape_timeouts. Additionally with service discovery you want the source (in this case the application developers / users of the Kubernetes cluster) to define if and how exactly their application should be scraped. Certainly when it comes to sensible information such as authentication this poses a limit to what Prometheus can handle and should take in via this mechanism.
But as for this very proposal I suggest to allow per target configuration of settings which are already available to configure "one layer up", on the job level.
(Maybe adding lower and upper bounds makes sense, but this could also simply be done with the already existing regex matching on the annotations value by simply ignoring too high or too low values.)

Also running with different scrape_intervals makes sense and is easily configurable.

Can you clarify what exactly you're asking for here? Multiple scrape intervals per Prometheus is discouraged for sanity, and is thus not something we're going to make easier.

rather to broad.

What's the problem with the timeout being too high?

Additionally with service discovery you want the source (in this case the application developers / users of the Kubernetes cluster) to define if and how exactly their application should be scraped.

As was discussed in the issue you linked, there are limits to what we're going to accept in Prometheus - at some point needs are sufficiently complex that you need a proper configuration management approach. Particularly if you're doing something innately complicated like allowing users to select their own scrape intervals.

Maybe adding lower and upper bounds makes sense, but this could also simply be done with the already existing regex matching on the annotations value by simply ignoring too high or too low values.

This is getting fairly complicated, you're seem to be asking relabelling gain the ability to do arithmetic.

I that very discussion @brian-brazil labeled ability to use dynamic configuration of the scrape_timeout and scrape_interval a feature request (#1176 (comment))

That's bug triage, I wouldn't read much into it. Any issue requesting new functionality is a feature request, it doesn't mean that it's something we're actually going to implement it.
Overall it sounds like your use case is quite complicated, to the point where it's not going to be sane to add all the features you require to Prometheus itself. I'd suggest taking a configuration management approach, and also consider if you can make your setup simpler.

Also running with different scrape_intervals makes sense and is easily configurable.

Can you clarify what exactly you're asking for here? Multiple scrape intervals per Prometheus is discouraged for sanity, and is thus not something we're going to make easier

I initially just ran into the issue of having different timeouts for very slow responding exporters.
Raising the scrape interval for just those was just a second idea. But I guess you are right this makes things A LOT more complex (having different sampling / scraping rates)

rather to broad.

What's the problem with the timeout being too high?

My thought here was, that a timeout should somehow help the overall system stability and performance, but it would also allow to recognize non-responding exporters quicker by not using a huge but potentially necessary high timeout that's required for one special exporter for all the others as well.

Maybe adding lower and upper bounds makes sense, but this could also simply be done with the already existing regex matching on the annotations value by simply ignoring too high or too low values.

This is getting fairly complicated, you seem to be asking relabelling to gain the ability to do arithmetic.

No, as I stated regarding the regex filtering, limiting what values of a label should be allowed could be done using the regex feature. My thought was less about implementation, but rather the use case of not allowing every (technically) possible value for timeouts (or, if even, wanted "scrape_interval").

Overall it sounds like your use case is quite complicated, to the point where it's not going to be sane to add all the features you require to Prometheus itself. I'd suggest taking a configuration management approach, and also consider if you can make your setup simpler.

Maybe giving things a second thought, having two scraping configs in Prometheus, each having their own timeout value or maybe also scrape_interval and then simply allow "selecting" either using labels is the way to go here.

Maybe giving things a second thought, having two scraping configs in Prometheus, each having their own timeout value or maybe also scrape_interval and then simply allow "selecting" either using labels is the way to go here.

I'd like to know what is the default scrape_interval for targets discovered via SD? Is that the global scrape_interval or the one mentioned inside the SD job? eg. If kubernetes_sd_config is used for scraping over pods with a scrape_interval of 30s and a global of 15s, what will the independent pods inherit as their scrape_interval?

@souvikdas95 Prometheus uses scrape_interval from the scrape configuration, if this is undefined then it uses the scrape_interval value from global.

Wouldn't it be the very equivalent of metrics_path? I can't figure out what the high amount of complexity is that would be added through making that configurable via annotation, given that it's configurable in the "static" scrape_configuration.

If we allow to specify per job scrape_interval, what is the purpose of restricting relabeling of the scrape_interval. We could write in the docs - it's not recommended to have multiple scrape_intervals for performance (other?) reasons. But if an operator wants to have them for some reason (guess performance?), inconvenience of configuring it (with keep/drop filtering and copy-pasting other parts of relabel_config) will not stop him from doing so. Operator will just think 'why this software makes me configure it in a such strange way'.

I'd also be interested by the possibility to use relabeling to configure scrape_timeout for specific "slow" targets.

Us also. We have our own custom exporters that get data from 3rd party APIs and they are slow. Would be great to just set this in a k8s annotation 🙂

We have a lot of relabel_configs in kubernetes_sd_configs job. Now we have to copy-paste whole job definition at least three times: normal,  "slow" for resource hungry exporters and "fast" for services that requires more detailed metrics. Maintaining this is ugly and limited to only defined options.

Note that this would enable service discoveries to decide the scrape interval. Which i am not sure we should allow.

Yeah, as I already mentioned earlier in the issue intricate choices of intervals is not something we should be encouraging, and in the rare cases where a 2nd interval can make sense it's already possible via configuration management and relabelling. I think we should close this as won't fix.

We have reviewed this request in the bug scrub and decided to close this issue for the reasons mentioned in this thread.


fix(IRequestOptions) Make app optional in IRequestOptions

See https://github.com/jameswlane/jest-express/issues/242
And a formatting issue.

@mnalsup Thank you for the PR, I appreciate your help with this project.
@all-contributors please add @mnalsup for code

:tada: This PR is included in version 1.10.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@mnalsup Sorry it took a bit, Semantic-Release bot was acting strange. I think I got it fixed and release updates like it should be. You fix is now live on npm.


Turn updatePpi, setupGL and logConfig methods protected

Hello,
I am working on improvements for https://github.com/yangweigbh/Libgdx-CardBoard-Extension. It has a lot of duplicated code, I am reducing this extending original classes from libgdx.
But sometimes some methods still need to be called from super so I am turning them into protected to make this improvements easier.

@Tom-Ski, Can you please, take a look?

Hi there.
I just changed three methods from private to protected to extend the class AndroidGraphics.


Incompatibility with Touch Punch on iPad2

My goal is to have drag+drop and double tap working on mobile but I haven't seen an "easy" example to integrate Hammerjs with jQuery Ui's draggable and droppable. Most of the example code requires me to basically write whatever jQuery UI already offers on the desktop. That forced me to use Touch Punch, which solves the problem. But when I try to use $(element).bind('doubletap') with hammerjs, It will interfere with the element's draggable. It will still drag but to a limited distance. I feel that the problem is probably some namespace conflict for the events associated with drag+drop.
So i either have to try to disable Hammerjs's drag and drop handling code or I have to find a way to make Hammerjs working with
jQueryUI so i don't have to write drag+drop handlers myself. Please let me know if you have some suggestions for making this work.
Thanks in advance.

Anyone found a fix yet?

Hi, Anyone find a solution?


Inconsistent parsing behavior in for loops

Code:
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.19;

contract C {
    function f() external {
        for (uint256 i = 0; i < 100; uint256 x = 0) {}
    }
}

solang compiles this just fine, while solc throws an error:
Error: Expected ')' but got identifier
 --> a.sol:6:46:
  |
6 |         for (uint256 i = 0; i < 100; uint256 x = 0) {}
  |                                              ^

This is because the last part (update) of the for loop is parsed as a statement in solidity.lalrpop:
https://github.com/hyperledger/solang/blob/5d395e41f031eb087ff8033b615c5195c7899a0b/solang-parser/src/solidity.lalrpop#L771-L773
While Solidity's specification defines this as an expression (link).
I'm opening this issue because I don't know if this is intended/part of the Solang dialect, or if it's a bug.

Thanks @seanyoung!


refactor request url interpolate tests

#326
@gavv Hi! Check out please. I split tests into subtests, but I couldn't think of a case when invalid interpol string error is returned. And there was an issue with checking value on nil, it was duplicated in here and here

Thanks for PR!

I split tests into subtests.

Looks fine.
One suggestion: I'd merge two "basic" subtests into one, rename it to "constructor" (because it tests how NewRequestC works), and make it table-driven, with the following table fields: path, path args, expected url.

I couldn't think of a case when invalid interpol string error is returned

Seems it can't be reached with current implementation. The error could be triggered only if interpol string is invalid, e.g. there is unmatched brace. You already have a test for it. However, this error will be handled early by NewRequestC, and WithPath just won't be executed.
After looking at the code a bit, I found it's strange that NewRequestC tries to perform interpolation even if there are not pathargs given. It would be safer to avoid messing with interpol in this case, e.g. modify initPath as follows:
if len(pathargs) != 0 {
    <all the interpolation code goes here>
}

r.path = path

AND, magically, if we do this, we'll also be able to cover both errors (in initPath and in withPath), by providing invalid interpol string and providing args either to constructor or to WithPath.

And there was an issue with checking value on nil, it was duplicated in here and here

Good catch.

Could you please also cover this branch? https://coveralls.io/builds/58476221/source?filename=request.go#L153
(nil patharg passed to constructor)

Yeah, sure

After looking at the code a bit, I found it's strange that NewRequestC tries to perform interpolation even if there are not pathargs given. It would be safer to avoid messing with interpol in this case, e.g. modify initPath as follows

If I add this if, the following is success, but must be failure:
req := NewRequestC(config, "GET", "{arg")
req.chain.assert(t, failure)

And I don't know why, but it also affects interpolation in constructor even if it doesn't seem to have any affect

I managed to fix the problem. It was because of assigning to a new variable path inside if-statement

Thanks!
Based on your changes, I proceeded with refactoring of interpol tests in this commit: c3059a97fa350e4067b9585917c35aa786bd6f25


Thread-safety configurator

https://github.com/inpime/fader/blob/master/api/config/configuration.go

use https://github.com/fader/sdata
deleted https://github.com/inpime/fader/tree/master/utils/sdata and

appendorreplcae.go
appendorreplcae2.go

Done 74830af4db60ceb83a5276d5c4857eb10da8a534
Closed


tweak some defaults

Lower ident timeout to 1.5 seconds, as discussed in #oragono
Enforce connection limits at the granularity of ipv4 /32's and ipv6 /64's
Raise the limit on number of new connections to 64 every 10 minutes
(for the benefit of people behind large IPv4 NATs)

Maybe ips-per-subnet should get a boost too, based on the same rationale about large NATs?
I'd be fine keeping both ips-per-subnet and max-connections at their current values too, as long as the README (or some related documentation) clearly calls out the need to tune them.

It's hard to strike a balance between allowing a decent number of people to connect, and not allowing yourself to be spammed like crazy... I'm gonna pull this into master and made the limit 32 per 10 minutes, then add some info to the readme about tuning the values and some alternate suggestions.


Assisted Keys+: Signing API

Task Description
Implement and integrate signing API for Assisted Keys+(BIP-85 based) w/ the existing one.
Note: Due to re-derivation of child(and the child root) from BIP-85 parent, the signing operation for Assisted Keys+ is going to be relatively slow.
Dependencies

#4440
#4441

Closing cc @Parsh


Did multiple CSS changes

Did following changes,

Changed the color of cross button that is used to close the navigation menu.

Added padding to navigation links.

Removed the background of links that appear on hover to make a good User Interface.

Added new animated hover effects to all the links, in a way such that it looks more professional.

U can see the changes here : CLICK HERE

@Nish251103 Please review the changes and kindly approve this PR.
Thanks :))

Okay. Thank You for the updates

Welcome and Thanks :)


Fixes IntoIterator example in flexibility guidelines

This is a bit of a small change, but when I was going through the Flexibility guidelines section, I noticed the IntoIterator example specified using IntoIterator<Item = i64>, but all of the original types specified implement IntoIterator<Item = &i64> as seen here: https://play.rust-lang.org/?gist=e5c49f401b986b822adf1210ab02f990
This PR fixes the documentation to recommend using IntoIterator<Item = &i64> instead.

Ah you're correct, the snippet should have a lifetime specifier
I do think this was still closed prematurely though because the case specified is incorrect:
fn foo<I: IntoIterator<Item = T>>(iter: I)

will not accept a &Vec<T>, &[T], or &SomeContainer<T> because those impl IntoIterator<Item = &T> and not IntoIterator<Item = T>, as shown in the playground link


'all' property config is not working

When I tried to add 'all' property to include all the files, I found it is not working in the jest report

I believe the 'all' option works, unless you are not using the latest version.
For example, the npm cache with package-lock.json, anyway I just release a new version<EMAIL_ADDRESS>which will install latest version mcr, please try it, or remove package-lock.json and reisnstall.

I tried the 1.0.4 and it is not working. Attached the screenshot shows the first one is generated by monocart, the second one is generated by jest

could you share your jest configuration?

coverageReporters: [
['lcov'],
['json'],
['text-summary']
],
reporters: [
'default',
['jest-monocart-coverage', {
logging: 'debug',
name: 'Unit Tests Coverage Report',
reports: [
['raw'],
['lcov'],
['json'],
['text-summary']
],
all: {
dir: ['./src'],
filter: {
// exclude files
'/*.test.js': false,
'/tests/': false,
'/*.js': true
}
},
onEnd: () => {
console.log('onEnd is called.');
}
  }]
],

Is it possible that there's an issue with the filter?
Could you try removing this filter and try again?
filter: {
// exclude files
'/*.test.js': false,
'/tests/': false,
'/*.js': true
}

Those are copied from playwright config, let me try. Or could you share your example repo let me try to reproduce it?

Try current repo https://github.com/cenfun/jest-monocart-coverage
npm i
npm run test

Please use this jest.config.js
`
module.exports = {
// Enable coverage
collectCoverage: true,
coverageDirectory: "./coverage-reports/istanbul",
collectCoverageFrom: [
  "src/**/*.js"
],
// Recommended to use `v8` to support the generation of native v8 coverage reports.
//coverageProvider: 'v8',
// Monocart can also support all coverage reports, so there is no need to set up reports here.
//coverageReporters: ['none'],
coverageReporters: [
    ['lcov'],
    ['json'],
    ['text'],
    ['text-summary']
],

reporters: [
    // If custom reporters are specified, the default Jest reporter will be overridden. If you wish to keep it, 'default' must be passed as a reporters name:
    'default',

    // Monocart custom reporter to generate coverage reports.
    ['./lib', {
        // logging: 'debug',
        name: 'Jest Monocart Coverage Report',

        //outputDir: './coverage-reports/istanbul',

        all: './src',

        sourcePath: {
            'src/': ''
        },

        reports: [
            ['raw'],
            ['lcov'],
            ['json'],
            ['text'],
            ['text-summary']
        ],

        onEnd: () => {
            console.log('onEnd');
        }
    }]
],

globalTeardown: './global-teardown.js'

};
`
npm run test
npx jest test/wrapped.test.js

I know your concern now. For Istanbul reports like text and text-summary, there are different calculation results between monocart and jest(v8-to-istanbul).
It should be able to be fixed for the all option, but I recommend you to use V8's reports, such as console-details and console-summary, so that it is no need to switch back to Istanbul.
            reports: [
                ['raw'],
                ['lcov'],
                ['json'],
                ['text'],
                ['text-summary'],
                ['console-details'],
                ['console-summary']
            ],

Moreover, I want to clarify that the Monocart is designed to handle V8's coverage data directly, or convert V8 to Istanbul. However, if you're directly using Istanbul's data, it's recommended to use Istanbul's reports directly, no need using Monocart.

Is it going to be fixed for Istanbul? We do have a plan of using v8, but right now we have to stick with Istanbul.
The reason I choose jest monocart report is I need raw coverage files in order to merge with playwright test using the monocart reporter, if you have a solution of generating raw files in jest, please let me know. Thanks

@stevez  It should be fixed in version<EMAIL_ADDRESS>

If this works then we can disable the jest report and use only the monocart report

Yes it works now


Web fonts stopped working

Which version of PhantomJS are you using? Tip: run phantomjs --version.
2.1.1
What steps will reproduce the problem?

google-font.svg:
<?xml version="1.0"?>
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="200" height="200">
  <style>@import url(https://fonts.googleapis.com/css?family=Pacifico);</style>
  <text x="10" y="20" font-family="Pacifico">Pacifico Font</text>
</svg>

google-font.js:
var webPage = require('webpage');
var page = webPage.create();

page.open("google-font.svg", function start(status) {
  page.render('google-font.png', {format: 'png', quality: '100'});
  phantom.exit();
});

Expected: output image renders webfont
Actual: default font is used

Which operating system are you using?
Windows 2008, Windows 10
Did you use binary PhantomJS or did you compile it from source?
binary
Please provide any additional information below.

It works on 2.5.0-development
Our setup was working fine and then it seemed to just stop working, perhaps second half of December to beginning of January.
Doesn't work on 2.0.

Hi! Thanks for reporting. But I am not sure what's the point of this issue? Could you please elaborate?

font-face just seems to not work anymore, so it renders the default font instead of the custom font

Possible duplicate: #14885


Happy Pokemon Day Banner 👀

What's your idea?
Funny idea to have a banner that says "Happy Pokemon Day!" Timed research issue given that 02/27 is Pokemon day.
@EthanThatOneKid.

Closing as duplicate of #181.


Fixed PMBoK Wikipedia link markdown typo

This PR fixes PMBoK Wikipedia link markdown typo on https://riskfirst.org/thinking/One-Size-Fits-No-One.

Thanks Serhan Tutar, can I credit you in the contributors list?

Thanks Serhan Tutar, can I credit you in the contributors list?

It's okay for me. It's one character fix, not that important though. 😏

Still much appreciated, thanks
https://github.com/risk-first/website/blob/master/overview/Contributors.md


fix: revert Encoding API

Issue # (if available)
https://github.com/awslabs/llrt/pull/431#issuecomment-2227203324
Description of changes
Revert to the implementation prior to applying encoding_rs for optimal performance and footprint.

The source structure (e.g., file separation) maintains the most recent structure.
Methods and properties that can be retained are retained. However, there are some that are not functional.
Support for utf16le is not included in this PR because we are not sure if it can be done immediately.
For UTF-16LE, only the conversions required by TextDecoder are supported.

Checklist

[x] Created unit tests in tests/unit and/or in Rust for my feature if needed
[x] Ran make fix to format JS and apply Clippy auto fixes
[x] Made sure my code didn't add any additional warnings: make check
[x] Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

All but TextEncoder.encodeInto() are now supported.

I think we could have utf-16le support without using encoding_rs. :)

Hi @richarddavison , All have been addressed. :)


Implement taskfinder.showInFinder method.

Fixes error "No command found with the name “taskfinder.showInFinder”."

Sorry, I missed this. I'll review and merge ASAP.


LazyArray loading of std::vector<> branch fails with 'value too large' error

Hi,
I've been experimenting with Uproot and thought I'd give it a try on a set of flat ROOT ntuples I need to make some plots from.  These guys contain a single TTree called gst which has a large, but not unreasonable number of branches (93).  Many of the branches are std::vector<double> or std::vector<int>.
I can read these vector-of-value branches fine when I open one file at a time with uproot.open(), pull the tree out, and use array() or arrays(), e.g.:
>>> f = uproot.open("/path/to/gst.root")
>>> gst = f["gst"]
>>> pdgf = gst.array("pdgf")
>>> pdgf[0]
array([2112, 2212,  211, 2212,  211], dtype=int32)

which is an array of pdg codes as expected.
However, when I try to use a lazyarray() to chain several ntuples of with the same tree in them together, I get a (rather inscrutable) value too large error:
>>> uproot.lazyarray("/path/to/*.gst.root", "gst", "pdgf")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/awkward/array/base.py", line 106, in __repr__
    return "<{0} {1} at 0x{2:012x}>".format(self.__class__.__name__, str(self), id(self))
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/awkward/array/chunked.py", line 272, in __str__
    return super(ChunkedArray, self).__str__()
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/awkward/array/base.py", line 96, in __str__
    first = self[:3]
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/awkward/array/chunked.py", line 411, in __getitem__
    chunk = self._chunks[chunkid][(slice(local_start, local_stop, step),)]
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/awkward/array/virtual.py", line 369, in __getitem__
    return self.array[where]
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/awkward/array/chunked.py", line 411, in __getitem__
    chunk = self._chunks[chunkid][(slice(local_start, local_stop, step),)]
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/awkward/array/virtual.py", line 369, in __getitem__
    return self.array[where]
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/awkward/array/virtual.py", line 295, in array
    return self.materialize()
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/awkward/array/virtual.py", line 326, in materialize
    array = self._util_toarray(self._generator(*self._args, **self._kwargs), self.DEFAULTTYPE)
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/uproot/tree.py", line 1912, in __call__
    return self.branch.array(interpretation=self.interpretation, entrystart=entrystart, entrystop=entrystop, flatten=self.flatten, awkwardlib=self.awkwardlib, cache=None, basketcache=self.basketcache, keycache=self.keycache, executor=self.executor, blocking=True)
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/uproot/tree.py", line 1395, in array
    _delayedraise(fill(j))
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/uproot/tree.py", line 56, in _delayedraise
    exec("raise cls, err, trc")
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/uproot/tree.py", line 1363, in fill
    source = self._basket(i, interpretation, local_entrystart, local_entrystop, awkward, basketcache, keycache)
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/uproot/tree.py", line 1149, in _basket
    basketcache[basketcachekey] = basketdata
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/uproot/cache.py", line 67, in __setitem__
    self._cache[where] = what
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/cachetools/lru.py", line 21, in __setitem__
    cache_setitem(self, key, value)
  File "/cluster/tufts/minos/external-update/install/lib/python2.7/site-packages/cachetools/cache.py", line 49, in __setitem__
    raise ValueError('value too large')
ValueError: value too large

I experimented with this with a cache (per the example) with sizes up to 1 GB with no different results.  (The files are only 53MB each so it seems unlikely that I'd need to go much bigger than that.)
Intriguingly, if I try to access a branch that contains only a single value, it works fine:
>>> uproot.lazyarray("/path/to/*.gst.root", "gst", "neu")
<ChunkedArray [14 14 14 ... 14 14 14] at 0x000002ba0350>

so something has gone wrong with the 'ragged' array stuff, I suppose.
Would appreciate any help here -- Uproot seems like a nice tool.  Thanks!

I suspect that the issue is related to how ChunkedArrays and VirtualArrays (which are used together to build lazy arrays) report their nbytes. If so, it would be an awkward-array error, not an uproot error, but the demarcation line isn't made clear by the interface.
ArrayCache uses its values' nbytes to determine if it's too full and needs to evict some data to stay under its limitbytes. However, if a single item is larger than its limit, then no amount of eviction will help. The cachetools library says, "value too large" when this happens.
The values in question are supposed to be chunks, not the entire array, so a 1 GB limit means that no chunk can be larger than 1 GB. Since your largest file is 53 MB, it sounds like this shouldn't be happening: chunks can be smaller than files, but files aren't glued together into larger chunks. Nevertheless, you do have another handle: you can make the chunks smaller with entrysteps (determines how many entries are in a chunk).
If it's counting the entire array as one object in the cache (thus, the sum of all chunks is what counts against you), then that would be a bug. I took a look at how VirtualArray handles nbytes, since it in principle doesn't know the size of its data until it loads it, and it takes nbytes as an optional constructor argument. Uproot has to give it the right value (and uproot has enough information to do so: ROOT files let you know the uncompressed size of a TBasket before you read it)—maybe that's where the bug is.
In the short term, you might want to look into iterating over your data with the older (and better tested) uproot.iterate function (see also the tutorial). Some users have told me they prefer getting data a chunk at a time in a for loop (what uproot.iterate does) because it gives them more control over the memory management.
Good luck!

Indeed, I do seem to be able to do what I want (so far, at least) using uproot.iterate.  It's a little less convenient for my purposes, but it's functional.  I'm not sure whether I need to propagate any of this upstream, if it's really a problem with awkward-array?  Or does it need more triage still?

I need to more fully triage it, and then fix it. (It does sound like a bug, but there's still a chance that it's a misunderstanding, depending on the size of your files, but you've told me that the biggest is 53 MB.)
Thanks for letting me know!
(I wanted to give you another option so that you're not held up by the time it takes me to fix it.)

Oh, ok -- thanks!
I'd be happy to provide one (or several) of the files if you find you can't reproduce it with something simpler -- just let me know.
Appreciate the lightning-fast responses!

I haven't been able to reproduce it. If you have an example for me to get working, please re-open this issue with that example.
(I'm going through a lot of issues now and need to close ones I can't fix without more information.)

Ok.  I'll supply an example when I have a moment.


Update StringColumnCurrencyUnitMapper.java

CurrencyUnit class in joda money has not any method getCurrencyCode()
so, must use value.getCode(); instead of value.getCurrencyCode();
getCurrencyCode() method exist in Currency class, and  CurrencyUnit class have getCode() method

in joda money version 1.0.1
CurrencyUnit class has not getCurrencyCode() method
But
in joda money version 0.12
CurrencyUnit class has getCurrencyCode() method
and usertype.core version 6.0.1.GA has incompatible with joda money version 1.0.1


docs(LOG): Added documentation

Added Log Plugin documentation
closes #1653

Coverage increased (+0.04%) to 78.614% when pulling 6704a0e554da64d08533d85262253919142e66df on MarcosEllys:doc-plugins into 46974e00d0bcb58fbacdafb8321d70b1709f610d on clappr:dev.

Since this PR wasn’t updated, I’ll close it for now. Please open a new one or reopen if necessary.

Hello,
Can you please clarify how to set the log level to LEVEL_DISABLED, LEVEL_INFO, etc?  I can't seem to find those vars.
Can you actually disable the logging or has that not been implemented yet?
Thanks


Improve ElasticsearchRelation extensibility

What kind an issue is this?

[ ] Bug report. If you’ve found a bug, please provide a code snippet or test to reproduce it below.
The easier it is to track down the bug, the faster it is solved.
[x] Feature Request. Start by telling us what problem you’re trying to solve.
Often a solution already exists! Don’t send pull requests to implement new features without
first getting our support. Sometimes we leave features out on purpose to keep the project small.

Feature description
Some times, third party code requires to extends some parts of Spark connectors. Concretelly, ElasticsearchRelation  is a probable candidate to be this way used.
Currently, its implementation for PrunedFilteredScan interface's buildScan method leaves its return type to Scala's type inference thus resulting in ScalaEsRowRDD which is possible because it is more concrete.
However, ElasticsearchRelation subclasses wouldn't be able to return an RDD[Row] instance.
Why is that important?
Because, many ElasticsearchRelation's child classes goals are related to modifying the results  ElasticsearchRelation would yield...
Steps to reproduce
... for example, by mapping over the resulting RDD.
Code :
org.evilcorpt.spark.sql

class SomeNewClass(...) extends ElasticsearchRelation(...) {
...
    def buildScan(requiredColumns: Array[String], filters: Array[Filter]): RDD[Row] =
        super.buildScan(requiredColumns, filters).map(someTransformationFunction)
...
}

There is PR providing the feature change:
https://github.com/elastic/elasticsearch-hadoop/pull/826


fix segfault with php 5.5 & auto_prepend_file

Fix a crash when xhprof_enable() is used in an auto_prepend_file

Was seeing this segfault with php 5.5.18.  Can confirm that this PR fixes the crash.

@epriestley care to review and merge?

I confirm that the PR fixes the crash in my environment. @epriestley please review and merge
PHP 5.5.9-1ubuntu4.6 (cli) (built: Feb 13 2015 19:17:11)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies
with Zend OPcache v7.0.3, Copyright (c) 1999-2014, by Zend Technologies

I added a test for this in 63169a7 and applied a smaller fix in a3bc669 (some of the changes seemed unrelated). Thanks!


widget design comments in 6.1 beta

Hi,
I have been testing the 6.1 beta and I have some comments on the widget design: the icon on the left side indicating if it is unread or starred, etc. uses too much of the precious space. Wouldn't it make more sense to have it on the top like any of the iOS built-in widgets (see Reminders for instance). Also, would it be possible to have at least two lines for each item?

@brentsimmons / @vincode-io
I'll work on some additional widget designs. I think the current ones are fine, but no harm in spicing it up a bit with more options.

+1 on requesting some additional widget designs. I love using this app as a news source, but the big icons to the left of the iOS widgets take up quite a bit of space imo. Would love alternatives to these. In particular, an "unread" widget without the blue dot icon would be fantastic!


judges-action#193: add compare to Fbe::FakeOctokit

Need for https://github.com/zerocracy/judges-action/issues/193

@Suban05 please review

@yegor256 please merge this pr

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 35min)

@Suban05 Thank you for your code review contribution! We appreciate your effort, but there's room for improvement. As per our policy, you've earned 4 base points, but we had to deduct 10 points due to the low number of comments (only 2). To ensure you receive some recognition, we've adjusted your reward to 4 points, which is our minimum. Remember, more detailed feedback helps everyone improve. Your current balance stands at +272. Keep up the good work and aim for more comprehensive reviews next time! 💪

@rultor release, tag is 0.0.66

@rultor release, tag is 0.0.66

@yegor256 OK, I will release it now. Please check the progress here

@Yegorov Thank you for your contribution! You've earned +4 points for this submission. Here's the breakdown: +4 as a base reward, -4 for having only 4 comments (which is below our target of 6), and +4 to ensure a minimum reward. While we appreciate your effort, please aim for more comprehensive code reviews in the future to maximize your points. Keep the contributions coming! Your updated balance is +196.

@rultor release, tag is 0.0.66

@yegor256 Done! FYI, the full log is here (took me 22min)


output/test/e100_valacc0.98349.pth availability?

pth2onnx.py mentions a weights file output/test/e100_valacc0.98349.pth but this doesn't exist in the output folder. Could this please be made available?

Thank you for your interest in this repo. I apologize that I am unable to provide the model at this time as it was trained on the intranet during my previous job at the company. And that is based on our business data, with more accurate labeling and a relatively simple validation set, so the score is relatively high.
I don't know what your specific scenario is. If it's optimization for academic paper growth points, then movenet is not a good baseline because it has not published any papers or has no official open source implementation.
If it is for your own project, it is recommended that you supplement more training data. At the same time, if it is not limited to using movenet, it is now recommended that you try the newly released RTMPose.


Oxford commas

Use Oxford commas and break into smaller phrases/sentences for easier reading:
https://github.com/ross-rotordynamics/ross/blob/master/paper/paper.md#L79-L82
cc https://github.com/openjournals/joss-reviews/issues/2120

We have tried to improve this on commit 17c399c.

fixed in https://github.com/ross-rotordynamics/ross/pull/504


task 400 : PAWS

task 400 using PAWS

Looks good to me!  Leaving it here for @swarooprm to check before merging it.

Please rename your file with lowercase letters and also in readme so that tests pass and we can merge this PR.

@swarooprm I can add the task you suggested but the paw dataset doesn't contain that many multiple paraphrase for each instance.
here how many paraphrases it has:
8 paraphrase: 15 instance
7 paraphrase: 10 instance
6 paraphrase: 11 instance
4 paraphrase: 912 instance
3 paraphrase: 1171 instance
2 paraphrase: 7471 instance
1 paraphrase: 35449 instance
should I go ahead and just make the instances from those with more than 3 paraphrase? I kinda feel the output count would be too low.


[Features] alternate theme feature

Purpose

Allows selection of default or alternate theme when launching the call Composite

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Test the code

Select feature from checklist (Secondary theme)
Make sure the primary color is different (should be teal).

What to Check
Verify that the following are valid

...

Other Information

going to amend this PR a bit with updated theme before resubmitting for review.

Adam,
For memory and fps diagnostics, on first install, immediately appear on top permissions is open. By default we keep it false, so then when checkbox turned on, permissions are requested.
Noticed warning

API 21, button tint is not working

Adam, For memory and fps diagnostics, on first install, immediately appear on top permissions is open. By default we keep it false, so then when checkbox turned on, permissions are requested.
Noticed warning
API 21, button tint is not working

Closing and updating (as meetings progress, some changes required)

Limit to 3 colors used
Name the colors more effectively.

Also need to test across wide api range a bit more.

Should be updated/opened again shortly.


[Newtonsoft] Publish new version of Batch dataplane for preview branch

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please add REST spec PR link to the SDK PR
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

https://azuresdkci.westus2.cloudapp.azure.com/view/TEST-NetSdkJobs/job/MaddiePS-Sign/81/

@matthchr This is a rerelease for Batch dataplane for the PowerShell Batch preview module (with Newtonsoft Json 10).  Can you take a look and let me know if you want me to make any changes?

@maddieclayton - This looks good to me. Are you going to publish a new version or did you want me to do it?

@matthchr I can take care of publishing as soon as the PR is merged.  Thanks for the review!


add a few more expansions

Possible pitfalls:

Square brackets in the PAX East pack
Really long white card with a colon in the PAX Prime pack
Several PAX injokes that won't make sense out of context that we probably should excise
No explicit licence on the third expansion, based on the source PDF -- might be worth getting someone to check the physical box

@zuzak:

Square brackets in the PAX East pack

Do these cause any problems that you have noticed?

Really long white card with a colon in the PAX Prime pack

Yeah, let's see how we go…

Several PAX injokes that won't make sense out of context that we probably should excise

Looking at the PAX packs, I don't follow most of it so yeah I'd personally be against using these in any game I am playing in. I will of course still merge this.

No explicit licence on the third expansion, based on the source PDF -- might be worth getting someone to check the physical box

I've been told by people who have the physical packs that they are all the same CC license, so I'm willing to assume this one is too until told otherwise. But I will remove it from github if it isn't CC like the others.
Thanks for typing this up!


Any chances that Kajabi will be supported?

If yes, how do we extract it in the same way as all other sites?

Please fill out the full site support request.

There you go.
Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.04.17. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[ x] I've verified and I assure that I'm running youtube-dl 2019.04.17

Before submitting an issue make sure you have:

[x ] At least skimmed through the README, most notably the FAQ and BUGS sections
[ x] Searched the bugtracker for similar issues including closed ones
[ x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ x] Question
[ ] Other

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://bit.ly/2ZjQw6N
Playlist: unsure how to extract the playlist url

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
Will love to learn how to extract videos myself from Kajabi platform. Kindly advise the steps necessary.


How to Insert Images at Specific Positions Within Text in Gemini pro vision?

Description of the bug:
I am working with Gemini pro vision and am looking to implement a feature where an image can be inserted at a specific position within the text, not just at the beginning or end like in the Google studio. As shown in the attached image, the picture is embedded in the middle of the text. Could anyone suggest APIs that enable this effect? Are there any code examples or libraries that I could refer to for this purpose?
The current api can just insert img as；
response = multimodal_model.generate_content(
                [_prompt, jpeg_image],
    )

Actual vs expected behavior:
No response
Any other information you'd like to share?
No response

response = multimodal_model.generate_content(
                [_prompt, jpeg_image],
)

Hi, the API already handles this case. A single turn takes a list of parts. A part can be text or an image.
prompt = ['before', image1, 'middle', image2, 'after']
response = multimodal_model.generate_content(prompt)

Should work, let us know if there's a more specific problem.


Nested struct inside a templated class doesn't provide completions

Using a nested struct inside of a templated struct inside another templated function does not provide code completions:
template <typename T>
struct Foo {
    struct Bar {
        int Field;
    };
};

template <typename AnotherT>
void func() {
    typename Foo<AnotherT>::Bar bar;
    bar.|  // expecting to have "Field" as a possible completion here.
           // Other features also don't work, e.g. I can write "bar.AnotherField"
           // and it won't highlight it as an error.
}

Using int instead of AnotherT in bar definition works as expected:
template <typename T>
struct Foo {
    struct Bar {
        int Field;
    };
};

template <typename AnotherT>
void func() {
    //           vvv
    typename Foo<int>::Bar bar;
    bar.|  // has "Field" as a completion suggestion.
}

Logs
Unfortunately my only current clangd install is on a dev machine with company code which I can't share. Let me know if logs are absolutely needed, I'll try to fire up an unrelated clangd to test this behavior.
System information
Output of clangd --version:
 $ ~/clangd_14.0.3/bin/clangd --version
clangd version 14.0.3 (https://github.com/llvm/llvm-project 1f9140064dfbfb0bbda8e51306ea51080b2f7aac)
Features: linux+grpc
Platform: x86_64-unknown-linux-gnu

Editor/LSP plugin: VSCode clangd v0.1.21
Operating system:
 $ cat /etc/issue
Ubuntu 20.04.3 LTS \n \l

Confirmed. This is similar to #432 and #810, and should be fixed by getting code completion to use  HeuristicResolver as dicussed here.


Change user creation

Users for now does'nt honor "system", nor custom login shell, home, etc..
Proposed solution 1
Use an object to specify user, allow to seamlessly add any user option
Proposed solution 2

add "manage_users" variable
add "*_manage_user" variable foreach services, that inherit of manage_users per default
add /var/lib/{username} as home, and nologin hardcoded
create user when *_manage_user

As discussed in meeting, solution 2 is to be implemented


Chess: Add specification & Initial Project Structure

Motivation
Issue title is self-explanatory.
Ref #342

Closing in favor of https://github.com/FuelLabs/sway-applications/issues/342


Allow connect in export { componentName }

Hi React-Redux team.
import connect from react-redux;

Class Profile extens Component {
 - - -
}

export { Profile }

In this case, how to allow connect

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux where there are a lot more people ready to help you out. Thanks!


fixes error ReferenceError: afterEach is not defined

I was getting this error, and made this change when running chakram locally.

Hi @cjwilburn, thanks for the pull request. AfterEach is defined in the mocha test framework and Chakram relies on this function to alert users to problems with promise usage.
What version of mocha are you using?

@dareid I'm using 2.3.4

@dareid when the tests failed, I did notice that it was running in node 0.10.x. I'm using node 4.1.2 (npm v2.14.4).I could be running into issues there. I'll try downgrading my node version to see what happens.

I have just updated my versions of node and mocha to match yours and the tests seem to be running correctly. Is there any chance you could run npm test for chakram 1.2.1 to see if they run correctly on your machine?
If they do, any chance you could provide more information on the tests you are running or the command you are running to perform the tests?

With the change in the PR on my local, I am indeed getting the same error on npm test as the Travis error on those same versions of node. Not sure why I was initially getting this error when the tests were running using mocha path/to/tests


Change hook_cfg type access to hook_cfg.get()

Motivation
Python dictionary does not support dot notation to access values. Fixes #396
Modification
Changed hook_cfg.type to hook_cfg.get('type', None).
Checklist
Before PR:

[x] Pre-commit or other linting tools are used to fix the potential lint issues.
[x] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[x] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[x] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

LGTM.


fix: use logo on header

:tada: This PR is included in version 2.0.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


{ARO} Change ARO module to track 2 Python SDK version v1.0.0

Description

This PR updates ARO CLI module to track 2 SDK. Changes include:

Updating requirements to pull the latest Python module
Update LRO with new method names begin_ prefix
Update AzureRedHatOpenShiftClient class => AzureRedHatOpenShift4Client

Testing Guide

[x] Track 2 SDK generated and tested in a downstream ARO-RP repo and merged with PR 1649
[x] Completed style check with command: azdev style aro
[x] Completed linter check with command: azdev linter aro
[x] Completed mock tests with command: azdev test aro --no-exitfirst
[x] Completed live tests with command: azdev test aro --live --no-exitfirst

History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

ARO

LGTM.