python311Packages.rtree: 1.1.0 -> 1.2.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.rtree is: R-Tree spatial index for Python GIS
meta.homepage for python311Packages.rtree is: https://toblerity.org/rtree/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.2.0 with grep in /nix/store/ynzk8a8qawz07qm6ldqhkmjczmabzk4l-python3.11-rtree-1.2.0
found 1.2.0 in filename of file in /nix/store/ynzk8a8qawz07qm6ldqhkmjczmabzk4l-python3.11-rtree-1.2.0

Rebuild report (if merged into master) (click to expand)

13 total rebuild path(s)

13 package rebuild(s)

First fifty rebuilds by attrpath
flatcam
python311Packages.bsuite
python311Packages.folium
python311Packages.geopandas
python311Packages.osmnx
python311Packages.plotnine
python311Packages.rtree
python311Packages.spyder
python311Packages.wktutils
python312Packages.geopandas
python312Packages.plotnine
python312Packages.rtree
spyder

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ynzk8a8qawz07qm6ldqhkmjczmabzk4l-python3.11-rtree-1.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.rtree https://github.com/r-ryantm/nixpkgs/archive/3f4aa4721f1cbe137c6ac55b1d4446adc71e3746.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/3f4aa4721f1cbe137c6ac55b1d4446adc71e3746#python311Packages.rtree

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ynzk8a8qawz07qm6ldqhkmjczmabzk4l-python3.11-rtree-1.2.0
ls -la /nix/store/ynzk8a8qawz07qm6ldqhkmjczmabzk4l-python3.11-rtree-1.2.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:

python312Packages.geopandas
python312Packages.plotnine

10 packages built:

flatcam
python311Packages.bsuite
python311Packages.folium
python311Packages.geopandas
python311Packages.osmnx
python311Packages.plotnine
python311Packages.rtree
spyder (python311Packages.spyder)
python311Packages.wktutils
python312Packages.rtree

Maintainer pings
cc @bgamari for testing.

meta.homepage is too old.

Result of nixpkgs-review pr 282165 at 3f4aa472 run on aarch64-darwin 1

1 package marked as broken and skipped:

python312Packages.osmnx

1 package failed to build:

flatcam

3 packages built successfully:

python311Packages.osmnx
python311Packages.rtree
python312Packages.rtree


New package: AdGuard.AdGuard.Beta version 7.17.4622.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Link could be found at https://adguard.com/en/beta.html?platform=windows

@wingetbot waivers Add Validation-Domain

@stephengillie

@wingetbot waivers Add Validation-Domain

For some reason wingetbot is ignoring this command for the second time (the first time).

Sorry for its seemingly fickle behavior lately.


Content-Length property not parsed correctly

For some projects, we are seeing a fatal server shutdown.

This is because we have some responses from the server not being parsed correctly. Although Content-Length is present, the results have been parsed with "jsonrpc" as the key. Somewhere our results are getting corrupted and are not parsing correctly.

I've debugged and logged from the server. The content we are sending looks correct. Here are three calls that were incorrectly parsed on the client.
{"jsonrpc"" => ""2.0","id":277,"method":"workspace/inlayHint/refresh","params":[]}Content-Length: 76"}
{"jsonrpc"" => ""2.0","id":278,"method":"workspace/codeLens/refresh","params":[]}Content-Length: 78"}
{"jsonrpc"" => ""2.0","id":279,"method":"workspace/diagnostic/refresh","params":[]}Content-Length: 82"}

If you look at the MonitorStream.log, the information being passed from the Roslyn server look correct and are not corrupted.

{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":4,"message":"[LanguageServerHost][07:24:25.094][Start]codeLens/resolve"}}Content-Length: 77
{"jsonrpc":"2.0","id":277,"method":"workspace/inlayHint/refresh","params":[]}Content-Length: 76
{"jsonrpc":"2.0","id":278,"method":"workspace/codeLens/refresh","params":[]}Content-Length: 78
{"jsonrpc":"2.0","id":279,"method":"workspace/diagnostic/refresh","params":[]}Content-Length: 82

Given that the results being sent from the server are parse-able and correct, it seems like something is getting corrupted on the client side? Here is the project that this repros consistently with: ReproNetCode.zip

I've found the problem, but I don't know what it means. In the middle of the buffer we have this logging inserted..
[Info]Begin Processing assembly Assembly-CSharp candidates

[Info]End Processing assembly Assembly-CSharp candidates

[Info]Timing:
Total: 719.7607 msec
  OnVisitSyntaxNode: 0.6842 msec (150) [0.1479]
    HasGhostComponentAttribute: 0.2518 msec (4) [0.001]

This is definitely what is messing up the parsing. I took a look at the messageBuffer tryReadHeaders parsing. Everything is going normally, and the method is producing Content-Length : x until it hits this:

Looking at the log of what is sent from the server, this addition isn't coming from the server.  There are three calls in a row that match what the client is trying to parse. Length 1064, 139 and then 196.

{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":4,"message":"[LanguageServerHost][04:14:36.761][Start]textDocument/semanticTokens/range"}}Content-Length: 1064
{"jsonrpc":"2.0","id":13,"result":[{"range":{"start":{"line":6,"character":17},"end":{"line":6,"character":22}},"data":{"SyntaxVersion":"2023-08-28T16:14:36.3575048Z-10020-0","ListIndex":0,"TextDocument":{"uri":"file:///c:/Users/beccam/Downloads/ReproNetCode/ReproNetCode/Assets/Truc.cs"}}},{"range":{"start":{"line":12,"character":13},"end":{"line":12,"character":17}},"data":{"SyntaxVersion":"2023-08-28T16:14:36.3575048Z-10020-0","ListIndex":1,"TextDocument":{"uri":"file:///c:/Users/beccam/Downloads/ReproNetCode/ReproNetCode/Assets/Truc.cs"}}},{"range":{"start":{"line":15,"character":9},"end":{"line":15,"character":14}},"data":{"SyntaxVersion":"2023-08-28T16:14:36.3575048Z-10020-0","ListIndex":2,"TextDocument":{"uri":"file:///c:/Users/beccam/Downloads/ReproNetCode/ReproNetCode/Assets/Truc.cs"}}},{"range":{"start":{"line":21,"character":9},"end":{"line":21,"character":15}},"data":{"SyntaxVersion":"2023-08-28T16:14:36.3575048Z-10020-0","ListIndex":3,"TextDocument":{"uri":"file:///c:/Users/beccam/Downloads/ReproNetCode/ReproNetCode/Assets/Truc.cs"}}}]}Content-Length: 139
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":4,"message":"[LanguageServerHost][04:14:36.766][End]textDocument/codeLens"}}Content-Length: 196

This bug was originally reported with Unity projects. Poking around online it does look like this logging may be related?

Here is what I guess is happening:

the extension uses stdio to talk to the server
inside the server process there is a library or some other code that write to stdio which then messes up the whole communication.

You have two choices:

somehow redirect stdio to the connection inside the server process if this is possible inside C#.
or the better solution is to use pipes / file sockets to communicate with the server then you have your own dedicated communication channel. The VS Code LSP client support this with the --pipe options https://github.com/microsoft/vscode-languageserver-node/blob/a2954d24a550ea567df3d60d1c8eb86d39707149/client/src/node/main.ts#L347

I've resolved this issue by creating the dedicated communication channel. Closing - thanks!


Any kind of community communication?

Should we add some sort of zulip/discord/slack for this package? Adding a channel in an existing forum would be the easiest, anything else feels a bit overkill I think.

I don't see any benefit, to be honest.
Especially because zulip, discord and slack are gated communities. I do not participate in any.
Why do you think are issues not sufficient?

I find it a bit easier to have a back-and-forth conversation about a topic, or just ask a fast/simple question in a more chat-like interface.
I see the point though that it's a bit overkill for this size package.

I think that keeping even simple questions in the issues is better because users that might come up with the same question can easily find them here.
If you think about more personal questions between us authors, feel free to shoot an email any time! :wink:

I don't think this library is particularly heavy traffic to warrant a separate discussion platform and it makes finding information quite a bit more challenging. Keeping all discussions here is healthier IMO.

Sounds good then :)


DDS static messages only work when at least two instances of Yazi are running

What system are you running Yazi on?
Linux Wayland
What terminal are you running Yazi in?
wezterm 20240203-110809-5046fc22
yazi --debug output
Yazi
    Version: 0.3.0 (dac72eb 2024-08-10)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.3.0

Emulator
    Emulator.via_env: ("xterm-256color", "WezTerm")
    Emulator.via_csi: Ok(WezTerm)
    Emulator.detect : WezTerm

Adapter
    Adapter.matches: Iterm2

Desktop
    XDG_SESSION_TYPE: Some("wayland")
    WAYLAND_DISPLAY : Some("wayland-1")
    DISPLAY         : Some(":0")

SSH
    shared.in_ssh_connection: false

WSL
    /proc/sys/fs/binfmt_misc/WSLInterop: false

Variables
    SHELL              : Some("/usr/bin/zsh")
    EDITOR             : Some("nvim")
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None
    ZELLIJ_SESSION_NAME: None

Text Opener
    default: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block  : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

tmux
    TMUX   : false
    Version: 3.4

Dependencies
    file             : 5.45
    ueberzugpp       : 2.9.6
    ffmpegthumbnailer: 2.2.2
    magick           : 7.1.1-36
    fzf              : 0.54.3
    fd               : 10.1.0
    rg               : 14.1.0
    chafa            : 1.14.1
    zoxide           : No such file or directory (os error 2)
    7z               : 17.05
    7zz              : No such file or directory (os error 2)
    jq               : 1.7.1

--------------------------------------------------
When reporting a bug, please also upload the `yazi.log` log file - only upload the most recent content by time.
You can find it in the "/home/dedukun/.local/state/yazi" directory.

Did you try the latest nightly build to see if the problem got fixed?
Yes, and I updated the debug information above (yazi --debug) to the nightly that I tried
Describe the bug
The DDS static messages only work when at least 2 instances of Yazi are running.
I've done some tests and this issue seems to have been introduced when pub_static was replaced with pub_to in #1172.
It's being affecting users that are using bookmarks.yazi in Yazi v0.3, as reported in this issue .
Minimal reproducer
Add the following plugin test.yazi
local publish = ya.sync(function(_, msg)
	ya.err("Published Test Message: " .. tostring(msg))
	ps.pub_to(0, "@test", msg)
end)

local subscribe = ya.sync(function()
	ya.err("Subscribe")
	ps.sub_remote("@test", function(body) ya.err("Read Test Message: " .. tostring(body)) end)
end)

return {
	entry = function(_, args)
		if args[1] == "pub" then
			publish("Test")
		else
			publish(nil)
		end
	end,
	setup = function(_) subscribe() end,
}

Call the setup function in init.lua and add two entries in keymap.toml like, for example:
[[manager.prepend_keymap]]
on = [ "?", "P" ]
run = "plugin test --args=pub"
desc = "Publish test static message"

[[manager.prepend_keymap]]
on = [ "?", "C" ]
run = "plugin test"
desc = "Clear static messages"

Then:

open Yazi (making sure that no other instance is running) and publish a message
close and reopen Yazi again
the test message was not saved (is not printed when subscribing)

If doing this steps are done with 2 instance of Yazi running it works
Anything else?
No response

Thanks for reporting, should be fixed in https://github.com/sxyazi/yazi/pull/1467

It's working as expected now, thanks for the quick fix.


Regression with LOB output parameters since v2.6.1

With go-ora v2.6.1 or newer, the CLOB example code throws the following error:
Can't read data with output1:  go-ora: Blob column type require Blob or []byte values

This appears to be due to the Valuer interface functions being added in https://github.com/sijms/go-ora/commit/7d2be8d453a3d7eee3a7df619d5fb9bd9553aa6c.

Relatedly, in my application I'm using a driver.NamedValue object with Value: Out and Dest: &Blob to call a PL/SQL procedure that outputs a BLOB "OUT" parameter.  Prior to go-ora v2.6.1 this was working well, but since upgrading to v2.6.1 my code has been throwing this error:
PLS-00306: wrong number or types of arguments in call to '<function name>'
I can make my code work again by commenting out the return nil at https://github.com/sijms/go-ora/blob/v2.6.1/v2/parameter_encode.go#L206, or by commenting out the entire *Blob Value() function.  (Either of these hacks ensures that the case *Blob: code block at https://github.com/sijms/go-ora/blob/v2.6.1/v2/parameter_encode.go#L473 will actually be executed).

Many thanks @sijms, both for this fix and for all the work you've done in creating go-ora!

also thank you for your contribution which help in fixing this issue


re visiting beginner's exercise : Code for computation of area of square, circle and rectangle in C

I tired to revisit the code I have learnt from online community
#include<stdio.h>
#include<math.h>
int main()
{
int choice;
printf("Enter\n1 for finding area of Square\n2 for finding area of Circle\n3 for finding area of Rectangle");
scanf("%d",&choice);
switch(choice) {
case 1: {
float side,area;
printf("Enter Sides of Square\n");
scanf("%f",&side);
area=(float)sideside;
printf("Area of Square is %f\n",area);
break;
case 2: {
float radius,area;
printf("Enter Radius of Circle\n");
scanf("%f",&radius);
area=(float)3.14159radiusradius;
printf("Area of Circle %f\n",area);
break;
case 3: {
float length,breadth,area;
printf("Enter Length and Breadth of Rectangle\n");
scanf("%f %f",&length,&breadth);
area=(float)lengthbreadth;
printf("Area of Rectangle is %f\n",area);
break;
}
}
}
{
default: printf("Choice other than 1, 2 and 3");
break;
}
}
}
// the most confusing part was  the reasoning behind the brackets. Then I started initiation and count to close.
also learnt that default to be put within main structure.

hoping it will help.


Exclude Rule Not Working

I'm running the following command trying to exclude the hardcoded credentials finding but the finding is still being flagged.
gas -exclude=G101 ./folder/*.go

Are you able to provide more details on the example? This example works as expected for me
➜  gas git:(master) cat /tmp/*.go
package main

import "fmt"

func main() {
	username := "admin"
	password := "admin"
	fmt.Println("Doing something with: ", username, password)
}
➜  gas git:(master) ./gas  /tmp/*.go
0
Results:

[/tmp/sample.go:7] - Potential hardcoded credentials (Confidence: LOW, Severity: HIGH)
  > password := "admin"

Summary:
   Files: 1
   Lines: 9
   Nosec: 0
  Issues: 1

➜  gas git:(master) ./gas -exclude=G101 /tmp/*.go
0
Results:

Summary:
   Files: 1
   Lines: 9
   Nosec: 0
  Issues: 0

Here are a few more details
/tmp ❯❯❯ cat f.go
package main

import "fmt"

func main() {
       	password, passwordErr := models.FindPasswordReset(db, request.Id)
}
/tmp ❯❯❯ gas -exclude=G101 f.go
Results:

[f.go:6] - Potential hardcoded credentials (Confidence: LOW, Severity: HIGH)
  > password, passwordErr := models.FindPasswordReset(db, request.Id)

Summary:
   Files: 1
   Lines: 7
   Nosec: 0
  Issues: 1

/tmp ❯❯❯ go version
go version go1.6 darwin/amd64

I'm having a tough time reproducing this. Is your test on latest master?
This type of thing is a perfect example of why I need to embed version information so I'm going to create a bug for that.

After updating go and pulling down the latest version it no longer flags my example.
~/c/ ❯❯❯ cat f.go
package main

import "fmt"

func main() {
        password, passwordErr := models.FindPasswordReset(db, request.Id)
}
~/c/❯❯❯ gas f.go
Results:

Summary:
   Files: 1
   Lines: 7
   Nosec: 0
  Issues: 0

Thanks. I'm going to close this for now but will be revisiting the hardcoded password logic in a separate issue. Hopefully if there was an issue I'll uncover it as a part of that work.  Thanks for the bug report anyway.

Sounds good. Any idea why it wouldn't flag the example above now when not including the exclude flag?

At the moment we look for secrets that are directly hardcoded in your program but the logic is pretty low tech. We examine assign statements and look for constants or string literals on the right hand side.  So we can detect this kind of thing:
username := "admin"
password := "secret"
sessionId := login(username, password)

But not really the example you provided. There is still much work needed to be done to improve the existing rules 😄

Gotcha. Thanks for your work!
On Tue, Nov 8, 2016 at 10:34 AM, Grant Murphy<EMAIL_ADDRESS>wrote:

At the moment we look for secrets that are directly hardcoded in your
program but the logic is pretty low tech. We examine assign statements and
look for constants or string literals on the right hand side. So we can
detect this kind of thing:
username := "admin"password := "secret"sessionId := login(username, password)
But not really the example you provided. There is still much work needed
to be done to improve the existing rules 😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoASTScanner/gas/issues/57#issuecomment-259168931,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZT1dv-0_8PH4HM0xj7PLfGQX1tebc-ks5q8JZrgaJpZM4KhTrR
.


Leveling tracker, gem skill set name

Would it be possible to show the source skill set name of the gem when the guide says to purchase it?
Also would like to list every gem instead of just saying press CTRL+F V
Currently it looks like this:

But I'm thinking something like this:

The skill set name I mean:

Exile-leveling already knows about it and passes it in the "note" property:

{
  "type": "gem_step",
  "requiredGem": {
    "id": "Metadata/Items/Gems/SkillGemSplittingSteel",
    "uid": 0.2503280378534358,
    "note": "Level 1-12"
  },
  "rewardType": "quest"
},
{
  "type": "gem_step",
  "requiredGem": {
    "id": "Metadata/Items/Gems/SupportGemChanceToBleed",
    "uid": 0.07273198219231336,
    "note": "Level 1-12"
  },
  "rewardType": "vendor"
},

Hmm, sounds reasonable. I'll need to find a way to prevent the panel from bloating too much, though. For your PoB, what's the highest number of gems that can be purchased at once?

I think the most is 6 at once (when reaching act 6, Lilly).

I could add a tooltip to gems to show the skill set name, if that helps. You would still be able to bulk-buy them, and this would give access to this info on-demand at a much later stage (I don't know if that's too relevant because I don't use PoB).
The main problem is panel spacing, as mentioned earlier, but also that the leveling tracker has been in for quite some time: if I take a look into it now, there'll probably be quite a lot that I would want to improve, which I currently don't have the time for.
Let me know what you think.


Sum of Constructor-types loses validation

require 'bundler/inline'

gemfile do
  source 'https://rubygems.org'
  gem 'dry-types'
end

module Types
  include Dry::Types.module

  MyInt = Types.Constructor(Integer) { |value| Types::Strict::Integer[value] }
end

p Types::MyInt[3] # ==> 3
p Types::MyInt.optional[3] # ==> 3
p Types::MyInt.optional[nil] # ==> nil
p Types::MyInt.optional['3'] # ==> "3"
p (Types::MyInt | Types::MyInt)[nil] # ==> nil
p (Types::MyInt | Types::MyInt)['3'] # ==> "3"
p Types::MyInt['3'] # ==> "3" violates constraints (type?(Integer, "3") failed) (Dry::Types::ConstraintError)

This constructor type is just a wrapper around Types::Strict::Integer and should behave exactly the same. Passing it the values 3 (first line), '3' (last line) and nil (not in this POC) indeed behave like this.
When using this Constructor type in a Sum type, it appears to be have lost some of that validation. Creating a sum type with .optional allows nil (as expected), but also allows the string '3' (unexpected). Creating a sum with with itself also allows nil (unexpected). Creating the sum of Types::Strict::Integer with itself does work as expected and disallows nil and '3'
The logic at Sum#try and Sum#call looks wrong to me: Sum#call calls Sum#try without a block. Sum#try then gets a result from checking both sides of the sum, which is a Dry::Types::Result::Failure with the input as instance variable. Because we don't have a block here, the method returns result, and the check on if result.success? feels superfluous. Then Sum#call just returns the instance variable of the returned value, no matter if it is successful or not, which results in our original input.
I'm not really sure why the sum of Types::Strict::Integer with itself or combined with optional does not display this behaviour, it does not appear to use Sum#call.
It does not appear to have a direct connection with Constructor, most likely it can be triggered with other (non-default) types as well.

This constructor type is just a wrapper around Types::Strict::Integer and should behave exactly the same.

This isn't true. Constructor type uses a lambda/proc to build values. Lambdas are opaque for dry-types hence it cannot infer type properties of the wrapped type. Sum types don't raise errors unless both branches are constrained types but the type you get Constructor is not constrained (intentionally). If you make it constrained with .constrained(type: Integer) it'll work the way you expected.


Branch Deploy and node Updates

Branch Deploy and node Updates
This pull request updates the branch-deploy Action to use auto-unlocking and the merge deploy mode. It also updates all node packages with npm update

.lock

.wcid

.deploy


Installation

Hi... i registered honeygain using your referral and successfully install the script but at the end after docker pull the image got this warning
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
is it ok? run on armbian aarch64/arm64v8...
last question...  can i install others like iproyal, traffmonetizer etc all together?
thank you

i found the solution add --platform linux/amd64
docker run -d --name "$NAME" --restart=always honeygain/honeygain -tou-accept -email "$EMAIL" -pass "$PASSWORD" -device honeygainnode
to
docker run -d --name "$NAME" --restart=always --platform linux/amd64 honeygain/honeygain -tou-accept -email "$EMAIL" -pass "$PASSWORD" -device honeygainnode

https://hub.docker.com/r/honeygain/honeygain/tags
I checked the official image and it seems that the deployment of machines with arm64 architecture is not allowed at the moment, so I'm sorry this modification doesn't work (the official docker is not cross-compiled, only amd64 is adapted)
As for whether it is possible to run multiple projects at the same time, the result is yes, I have written shell scripts corresponding to the projects you mentioned:
https://github.com/spiritLHLS/Hang-up-items#挂机项目合集


Pie Chart is not being displayed in pandas profile report

I am trying to have variables of categorical type with less than 10 unique values show as a pie chart. I see an option in the configuration yaml. However, when I generate the report I still see it as a bar chart.

Hi @bedangSen, the pie chart is added to the report, but doesn't replace the frequency table as you might have expected.
For instance, see "Pclass" in: https://pandas-profiling.github.io/pandas-profiling/examples/master/titanic/titanic_report.html
(click "Toggle details" to see the pie chart)

Ahhh I gotcha! Apologies for the confusion, this is great! Quick question though - is there a way to change the color of the pie chart to the primary colors selected in the config file? (Example attached below)

@bedangSen Not yet, however the change would be simple. You're welcome to contribute.
You can find the relevant code here: https://github.com/pandas-profiling/pandas-profiling/blob/master/src/pandas_profiling/visualisation/plot.py#L283

I did an implementation of the custom colour feature : #904


window keys: creep vs tzp

@abrahamjuliot
something I noticed

FF nightly: tzp-839 properties vs c-837
opera: tzp-997 vs c-997
chrome: tzp-1004 vs creep-1004

so it's a gecko thing (I thought it might be because the console is open, but alas that is not it). I tested older FFs

FF60:  tzp-769 (creep broken by webrtc)
FF68 tzp-784 c-782 - same two items difference
I stopped there

the gecko difference is always Performance and PerformanceNavigationTiming
I hate it when code doesn't replicate - who knows what else you could drop off (that adds entropy) or me pick up (that are not stable). I though we were the same. Why the difference?
Please explain yourself young man :)

😁
Yes, Performance and PerformanceNavigationTiming are removed and the Event is moved to the end of the list.
As far as I know, this adds a bit of stability when the console is opened/closed or RFP is turned on/off, but I'm not sure if it adds much. On creep, this reduces the amount of unique window samples captured and lowers the count of loose fingerprint switching tracked. I have not tested this in older versions yet.
// if Firefox, remove the 'Event' key and push to end for consistent order
// and disregard keys known to be missing in RFP mode
if (isFirefox) {
    const keyMovedByInspect = 'Event'
    const keysMissingInRFP = ['PerformanceNavigationTiming', 'Performance']
    const index = keys.indexOf(keyMovedByInspect)
    if (index != -1) {
        keys = keys.slice(0, index).concat(keys.slice(index + 1))
        keys = [...keys, keyMovedByInspect]
    }
    keysMissingInRFP.forEach(key => {
        const index = keys.indexOf(key)
        if (index != -1) {
            keys = keys.slice(0, index).concat(keys.slice(index + 1))
        }
        return keys
    })
}

Ahh, BTW, I sort gecko results but not others - that takes care of the console being open for me (IDK about chrome, I thought that was covered)
Performance is not missing with RFP on (at least not in nightly) - no big deal, it was probably missing in earlier versions - probably changed when they tweaked performance entries - probably this one - https://bugzilla.mozilla.org/show_bug.cgi?id=1637985
Entropy wise, I'm happy to collect those two values, I mean it's entropy :)

actually, I do sort them for all engines - I just do some gecko stuff before sorting
I played with my code and did some debugging
ESR78 // bca850600dfb

RFP off 813

console open
last 4 items: Node,Document,HTMLDocument,Performance
last 4 items: Document,HTMLDocument,Performance,Event <-- storage tab selected at some stage - becomes sticky
RFP items: Performance,PerformanceNavigationTiming
sorted hash: eb06d1c4372efeef24c472f28b152f19323ced86

console closed
last 4 items: netscape,Node,Document,HTMLDocument
RFP items: Performance,PerformanceNavigationTiming
sorted hash: eb06d1c4372efeef24c472f28b152f19323ced86

--------

RFP on 812

console open
last 4 items: Node,Document,HTMLDocument,Performance
last 4 items: Document,HTMLDocument,Performance,Event <-- all you have to do is select/deselect storage tab
RFP items: Performance
sorted hash: c82a70670ecc84e9a55e4ffe34e190e74ecd7024

console closed
last 4 items: netscape,Node,Document,HTMLDocument
RFP items: Performance
sorted hash: c82a70670ecc84e9a55e4ffe34e190e74ecd7024

So yeah, I remember this, might have been in the old TZP repo .. where sorting created stability.  I'm slicing at Performance + 1, but how does that work when the last item is HTMLDocument - reopening to remind myself to check this
I'll check the other FF versions to see where RFP dropped Performance

OK, so I fixed my debug code
95 RFP off
closed
	- last 4 items: HTMLDocument,EventCounts,Map,Performance
	- RFP items: Performance (838/838),PerformanceNavigationTiming (338/838)
open
	- last 4 items: EventCounts,Map,Performance,Event
	- RFP items: Performance (837/838),PerformanceNavigationTiming (337/838)
open - select storage
	- last 4 items: Map,Performance,Event,Location
	- RFP items: Performance (836/838),PerformanceNavigationTiming (336/838)

95 RFP on
closed
	- last 4 items: HTMLDocument,EventCounts,Map,Performance
	- RFP items: Performance (837/837)
open
	- last 4 items: EventCounts,Map,Performance,Event
	- RFP items: Performance (836/837)
open - select storage
	- last 4 items: Map,Performance,Event,Location
	- RFP items: Performance (835/837)

check - RFP drops PerformanceNavigationTiming
in gecko, Performance is always last. But if the console is open, the last item is Event. But if you select the Storage tab, even if you select then deselect it, it seems as if in FF95 at least, the last item now becomes Location (I didn't have that in my false positives, only in knownGood - I will patch that)
And I also have StyleSheetList as a false positive as well (I think its FF < 62 or something). So in gecko, I find Performance, ignore Event Location and StyleSheetList and anything after that is suspect (things extensions are playing with) and from the suspect list I remove knownGood = lets me catch the fake random items from chameleon, and the fake items from cydec
So I had it right - as long as Performance is always expected regardless of RFP. Now imma gonna test, thanks a bunch - to see if/when RFP affected Performance (it didn't in ESR78) and I rely on this, so it better not :)

OK, I'll finish testing later, but here we go

am up to FF65 (but it FF62+ matches FF nightly)
I don't think android would have been any different
the second set for console-y is when you have selected the storage tab at some stage

AFAICT,  RFP doesn't affect Performance (so far) being at the end (or very near end)
note: TZP code ignores isFFLegacy (< v60) and doesn't attempt to find fake/suspect
e.g. FF52 ended in a whole heap of `CSS*` stuff

FF60-61
- RFP-n console-n: Node,Document,HTMLDocument,Performance
- RFP-y console-n: Node,Document,HTMLDocument,Performance
- RFP-n console-y: HTMLDocument,Performance,Event,StyleSheetList / Performance,Event,StyleSheetList,Location
- RFP-y console-y: HTMLDocument,Performance,Event,StyleSheetList / Performance,Event,StyleSheetList,Location

FF62+
- RFP-n console-n: Node,Document,HTMLDocument,Performance
- RFP-y console-n: Node,Document,HTMLDocument,Performance
- RFP-n console-y: Document,HTMLDocument,Performance,Event / HTMLDocument,Performance,Event,Location
- RFP-y console-y: Document,HTMLDocument,Performance,Event / HTMLDocument,Performance,Event,Location

I think I screwed up my earlier tests (since edited)
see this
https://github.com/arkenfox/TZP/blob/88df9aaaa38e99f058fbee6c6e667be90a3aa0b7/js/misc.js#L75
and now see this - https://github.com/arkenfox/TZP/commit/88df9aaaa38e99f058fbee6c6e667be90a3aa0b7
i used to let allProps = props and even though it's an array, sorting either also sorts the other, but now I do this

props.forEach(function(item) {allProps.push(item)}) and they're not entangled

I thought only objects had that fucked up quantum entanglement

https://github.com/arkenfox/TZP/blob/88df9aaaa38e99f058fbee6c6e667be90a3aa0b7/js/misc.js#L86
OK, tested 37 browsers, six tests each, new tab when switching to RFP on

Performance is always last (or almost last if console open)

RFP doesn't affect this

If console is open
FF60-61: Event + StyleSheetList or Event + StyleSheetList + Location comes after Performance
FF62+ Event or Event + Location comes after Performance

FF60-61
- RFP-any console-n: Node,Document,HTMLDocument,Performance
- RFP-any console-y: HTMLDocument,Performance,Event,StyleSheetList / Performance,Event,StyleSheetList,Location

FF62-88
- RFP-any console-n: Node,Document,HTMLDocument,Performance
- RFP-any console-y: Document,HTMLDocument,Performance,Event / HTMLDocument,Performance,Event,Location

FF89-96
- RFP-any console-n: HTMLDocument,EventCounts,Map,Performance
- RFP-any console-y: EventCounts,Map,Performance,Event / Map,Performance,Event,Location

my work here is done

PS: all the extra shit in TB is from NoScript - I tested them as well with and without NoScript extension enabled (ESR60, 68, 78, 91)

I don't treat these as false positives, but as suspect (but knownGood)

https://github.com/arkenfox/TZP/blob/32ebe3e7e41d930fc480ff7a2d000d82805e121d/js/misc.js#L36-L39
...aaaaaaand .. now my work is done

noted for posterity
	// https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41694
		// allowlist NS 11.4.20+ - i.e remove false positives
		// allow slider at safer
	aFilter = ["Element","Event","HTMLCanvasElement","HTMLElement","HTMLFrameElement",
		"HTMLIFrameElement","HTMLObjectElement","Location","MediaSource","Proxy","URL","webkitURL"
	]

event and location are there because they can come after performance depending on the console being open and if various tabs have been used (I think it was storage or network adds Location) - so the five in the linked tor ticket are standard, the rest are added when on safer - FYI, time for some 💤


chore(main): release 1.0.1

:robot: I have created a release beep boop
1.0.1 (2024-07-07)
Bug Fixes

update template (2243fae)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.1
:sunflower:


Bad proposal position with Firefox and jQuery modal window

I tried to use jango-autocomplete-light 2.3.3 in a jQuery 1.12.4 / Bootstrap 2.3.3 modal windows
It works like a charm in Chromium browser but not totally in Firefox (45.9.0). In this case, the results are show out of the modal windows about 3 cm on bottom right.

If I remove the modal class on the div, the input results are correctly shown. I tried to re-arrange tags but without real effect. Is there a better way to use modal window with autocomplete-light module ?

I think reporting it to firefox would be better.
Otherwise, another version of JAL used a different positioning system that was compatible with model boxes, but not with django admin - at that time, on the old theme.


Disable linters with many offenses in todo file

When autogenerating the todo file we used to list as excluded all the files with offenses. This looks horrible when having many files. :worried:
Now when we have more than 15 files we exclude the lint instead, similarly as it is done in Rubocop. :bowtie:
Closes https://github.com/brigade/haml-lint/issues/223

Hey @Ana06, thanks for the pull request!
This looks great. It would be really appreciated if we could add a test for this specific logic to ensure this behavior is preserved.
Here's an example test which should be easy to adapt for this case, though you'll likely need to create a separate context to capture the fact that there are more than 15 offending files: https://github.com/brigade/haml-lint/blob/1fc103a906e34baa4014cae1b5a5771d4cbe8d89/spec/haml_lint/reporter/disabled_config_reporter_spec.rb#L85-L99
Thanks again!

@sds

This looks great. It would be really appreciated if we could add a test for this specific logic to ensure this behavior is preserved.

There you have the tests! :wink:

Here's an example test which should be easy to adapt for this case, though you'll likely need to create a separate context to capture the fact that there are more than 15 offending files

I kept it in the text context and also add this to the other test cases (such as prints each lint on its own line) as it was only tested with one linter before and I think it is more precise to test it with two. I think separate it would be more complicate.
Also, I realised that the tests used to have 3 files inspected, 3 lints detected (now 19 files inspected, 19 lints detected). But one of the files is repeated. So I think it should be 18 and no 19 files inspected. I also added a commit for that. :wink:

Thanks for adding those tests, @Ana06. Merged!


remove helm chart oadp install yaml

Description
Remove helm chart oadp install yaml and use the oadp-install policy to trigger oadp installation
Related Issue
https://issues.redhat.com/browse/ACM-10890
Changes Made

set pruneObjectBehavior: DeleteIfCreated on the oadp-install policy to uninstall oadp when the policy is deleted
remove the 2 yaml files installing the oadp operator; it will be installed by the policy
fixed a formatting issue with the policy - removed comments from the if stm

Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist

[x] I have tested the changes locally and they are functioning as expected.
[ ] I have updated the documentation (if necessary) to reflect the changes.
[ ] I have added/updated relevant unit tests (if applicable).
[x] I have ensured that my code follows the project's coding standards.
[x] I have checked for any potential security issues and addressed them.
[x] I have added necessary comments to the code, especially in complex or unclear sections.
[x] I have rebased my branch on top of the latest main/master branch.

Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2
Definition of Done

[ ] Code is reviewed.
[ ] Code is tested.
[ ] Documentation is updated.
[ ] All checks and tests pass.
[ ] Approved by at least one reviewer.
[ ] Merged into the main/master branch.

/cc @tesshuflower


#447 Refactor tradeslip to use sdkv2, react-query and jotai

Work done:

[x] Move state and data fetching from mobx to hooks + jotai atoms
[x] Refactor components to use new tradeslip state hooks.
[x] Implement data fetching using sdkv2.
[x] Implement transaction using sdkv2.

Leaving react hook form refactor for another issue.

Is there a need to use TradeSlipStore with new state for tradeslip implemented?

Is there a need to use TradeSlipStore with new state for tradeslip implemented?

The only thing that uses it is the right drawer component to determine if it should change to tradeslip if items length changes. I can refactor this to use the new jotai tradeslip state.

Seems like trade slip items are being removed when I add an amount

To receive doesn't change when amount is changed
To receive amount seems incorrect:

Amount Input gets cleared when adding another item to the trade slip

Getting 'Infinity ZBS' on that same market


chore: update dev dependencies

:tada: This PR is included in version 1.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Waypoint behavior for kubernetes.default.svc.cluster.local

If a user deploys a waypoint in default, should in include  kubernetes.default.svc.cluster.local? We will need to decide and implement any changes

Today its 100% broken. https://github.com/istio/istio/pull/50323 makes it work, but it does go through the waypoint.


message edit: Edit and save removes the edit pencil.

If you edit a message and click save, the on-hover pencil edit icon next to the timestamp doesn't show up until your mouse leaves the message box. The other two icons do.
This should hopefully be a fairly quick fix if someone wants to take it up!

@zulipbot claim

Increasing priority, since this is pretty confusing.  @akhilmd maybe this is a good issue for you while you're working on message editing?

@zulipbot claim


Provider.ifPresent biconsumer

Expected Behavior
this would be the same as below, similar syntax to java Optional.ifPresent
providers.gradleProperty("spring.profiles.active").ifPresent({ key, value -> systemProperty(key, value })

Context
current workaround
  providers.gradleProperty("spring.profiles.active").orNull?.run {
    systemProperty("spring.profiles.active", this)
  }

other ticket which contains more context. This is not a solution for that problem, but rather some improved syntax when problems like that arise.
------------------------------------------------------------
Gradle 7.5.1
------------------------------------------------------------

Build time:   2022-08-05 21:17:56 UTC
Revision:     d1daa0cbf1a0103000b71484e1dbfe096e095918

Kotlin:       1.6.21
Groovy:       3.0.10
Ant:          Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM:          17.0.4 (Eclipse Adoptium 17.0.4+8)
OS:           Mac OS X 12.6 x86_64

Duplicate of #13401 , though the suggestion here to map a system property to K,V won't work as the Provider api is a single value (given the property name, provide the value).
Doable via a Kotlin extension function:
public inline fun <reified S> Provider<S>.ifPresent(block: (S) -> Unit) {
    if (isPresent) {
        block(get())
    }
}

Thank you for your interest in Gradle!
This issue will be closed as a duplicate of

https://github.com/gradle/gradle/issues/13401

Please add your use case and 👍 to that issue.


Provide ability to associate backend role and security role during monitor create

Is your feature request related to a problem? Please describe.
Provide ability to associate backend role and security role during monitor create.
Currently, during monitor creation the user backend roles and security roles are resolved and associated with monitor. There is no option for the User to select which backend role and security role to get associated instead of all.
Describe the solution you'd like
Provide optional field to add backend role and security role in the POST _plugins/_alerting/monitors API. When these optional fields are provided, and these are present in resolved roles - use provided roles to associate with monitor.

@skkosuri-amzn is this expected to make its way into the 1.3 release?

@brijos . thank you for letting me know. Please let me know if there is any additional information / context I can aide with.

Hi, any news here?

@sevenval-admins - if you and folks you know are looking for this feature - please make sure they give is a thumbs up at the top.

@lezzago Can we close this based on the PR linked above being merged in or is there any additional work to be done?

We have updated the documentation and starting from 2.4, we support allowing to specify backend roles.


No decoder surfaces left, cannot allocate memory

"Doesnt work, it constantly says No decoder surfaces left, cannot allocate memory
output is first frame and sounds. gpu is 3070. pls help" - Odd_Ad9780
https://www.reddit.com/r/TeardownGame/comments/t5wvgx/comment/hzaz7j0/?utm_source=share&utm_medium=web2x&context=3

fixed by adding -extra_hw_frames 2 before file input - https://stackoverflow.com/a/68061732

Didn't fix it apparently

Screenshot of issue occurring

FFmpeg needs to have NVENC support at build


Discussion: Should default template engine allow literal property binding.

I think I’ve only ever seen a literal property binding by mistake, so I’m tempted to keep this strict. However, I wanted to farm for dissent a little bit. Currently…
NOT OK
html`<div .foo="bar"></div>`;

OK
html`<div foo="bar"></div>`;

or…
html`<div foo="${'bar'}"></div>`;

^^ But this last one is considered an anti-pattern and should not be used.

IMO, we should not allow .foo="bar" — this binding can be expressed within the html syntax. And, if it’s really needed (e.g., the custom element doesn’t do attribute syncing), you can use .foo="${'bar'}" as a last resort.

🤔 — I actually think we should do what we’re currently doing… just totally ignore that. You can do this today:
document.body.innerHTML = `
  <div .foo="bar">
    I have an attribute named dot-foo with a value bar!
  </div>
`;

I want to try very hard not to mess with default behavior… I wonder if that means we ought to actually not fail in the case of:
html`<div .foo="bar" .another="${whatever}"></div>`;

… not totally sure what the “best” choice here is!

OK, one more thought, then I’m done commenting here 😸
I think we actually want to purposefully ignore this. I.e., expect that folks might put a . in front of attributes. The spec allows for it!


Feature/use package format 2

Status
PRODUCTION / DEVELOPMENT
Description
Use version 2 of the package.xml format. See http://www.ros.org/reps/rep-0140.html

@esteve Can we close this and do each package as we reorganise the repository/packages?


Ionide Send to F# Interactive terminal window produces garbage output in vscode 1.9.0

Something broke when updating to 1.9.0. I don't know if you or Ionide folks need to fix this.

VSCode Version: 1.9.0
OS Version: OSX El capitan 10.11.6

Steps to Reproduce:

Install Ionide-fsharp extension
Send any fsharp code line to Interactive window with option + /
you get garbage chars at the terminal prompt after command executes
Next time you send your command will fail due to the garbage chars

From terminal - F# interactive
> type PersonType = {First:string; Last:string}
- ;;

type PersonType =
  {First: string;
   Last: string;}

> ^?^? <-- Garbage chars

This is likely a duplicate of https://github.com/Microsoft/vscode/issues/19766
@pgus can you try adding this to your settings and let me know if it fixes it?
"terminal.integrated.flowControl": false

/cc @Krzysztof-Cieslak

Yes, setting flowControl false solved it. Thanks


BUG - Freshness tests fail when models disabled

Are you a current Fivetran customer?

Fivetran created Issue
Describe the bug

When a users sets a model enabled variable to false (ie. intercom__using_company_tags: false), then the freshness tests will error out because the user does not in fact have that table in their source system.
Steps to reproduce

Don't have one of the tables in your source.
Set the variable to false to disable the use of it.
Run dbt source freshness and watch an error occur because the freshness test on that source table is still being run.

Expected behavior

When a user disables a model, the freshness tests do not run.
Package Version

packages:
  - package: fivetran/intercom_source
    version: [">=0.3.0", "<0.4.0"]

Warehouse

[X] BigQuery
[X] Redshift
[X] Snowflake
[X] Postgres
[ ] Databricks
[ ] Other (provide details below)

Additional context

This same issue has already been resolved in other dbt packages. See the dbt_greenhouse_source PR for how this is resolved.

This fix will be live in the next v1 release of the intercom_source package 🎉


Xcode 9: improved logging of native Gherkin

Issue
Native Gherkin lines are not clearly traceable in Xcode results output
Solution
New XCTContext.runActivity API in XCTest introduced in Xcode 9 makes it possible to wrap everything together that is executed within a native Gherkin step 🎉. See screenshot:

I am ready to make a pull request with this, but I decided to go via the Issue section first, especially because this is based on the Xcode 9 beta. See for the diff: https://github.com/net-a-porter-mobile/XCTest-Gherkin/compare/master...smaljaar:feature/xcode9-use-xcactivity-to-improve-native-logging?expand=1
Please let me know if any comments or suggestions.

Love it! (Also, didn't know it existed until now!)
My only issue is backwards compatibility - is there a way that we can determine whether this is available and fall back to the legacy approach if it isn't? I don't know how quickly other uses of this library will move to Xcode 9 :|

This is amazing 😍

@kerrmarin @smaljaar Given we can't migrate to swift4 just yet (see #68, sigh) and xcode9 is live now, what do people think about just removing the version check (sorry, I know I was the one who asked for it in the first place!) and upping the version number to 0.11 ?

Sound good to me. I did have a crack at #68 a while back but I got busy and it took a back seat. I'll see if I can think of something this weekend.

Great - done here: https://github.com/net-a-porter-mobile/XCTest-Gherkin/pull/78

I had a go at 68 too; I tried to write that bit in objective-c but I couldn't get the pod to build with a combination of swift and objc :(

Right, this is in master, and tagged as 0.11.0 - it's pushing to the pod trunk repo as we speak, but over my home internet so give it a while. When it's pushed, I'll close this issue.


Docstrings For Session class

Description
All of the methods for Session have docstrings now. I don't want to have to merge again so I'm a pull request and I'll type up docstrings for the rest of the classes after this is merged.
GitHub Issues
#40

Coverage increased (+0.3%) to 89.675% when pulling 95549c6336dd988962294fc6929bcdda621ef80b on frozenjava:docstrings into d50e83d67102231f31fd901dce120996a4cdf31e on refindlyllc:development.


Handle ast::MacroCall in classify_name and impl FromSource for MacroDef

Fixes #2260

Now hover works directly on macros at the definition point... which is not that useful haha.

bors r+

Btw, there's a similar fixme here:
https://github.com/rust-analyzer/rust-analyzer/blob/ad10c4b8e2d81af7fc35a466cd434e2c3952bfd8/crates/ra_ide_api/src/goto_definition.rs#L73
I think it should be doable after: https://github.com/rust-analyzer/rust-analyzer/pull/2213/files. hir::GenericParam should implement HasSource, and everything else should fall out naturally I think.


Color output

Parse colors from git configuration via colorparse.

This will need to wait for https://github.com/ogham/rust-ansi-term/issues/19 in ansi_term.

Commit https://github.com/git-series/git-series/commit/a8fd3e174565faf527f0dbfea956175d692b654c implements colorized diffs.
Still need to implement colorized diffstats.


Document working with icon/class providers

There doesn't seem to be any documentation on working with addIconProvider on ProjectManager, WorkingSetView and FileTreeView.
@dangoor's original blogpost contains much of the relevant information though http://www.kevindangoor.com/2014/09/intro-to-the-new-brackets-project-tree/
There's also this reference on the change log:

New/Improved Extensibility APIs

File list decorators - To modify the appearance of the Working Files list or the project tree below it, extensions can register decoration providers to add icons or arbitrary CSS. Use WorkingSetView.addIconProvider(), WorkingSetView.addClassProvider(), ProjectManager.addIconProvider(), or ProjectManager.addClassesProvider().

If there's already some information about these on the Wiki, can someone point me to it?
Additionally the JSDoc links don't seem to work (https://github.com/adobe/brackets/blob/master/src/project/FileTreeView.js#L1051 -> http://brackets.io/docs/current/modules/project/FileTreeView.html#-addClassesProvider

@petetnt Do you want to decorate something with the registered providers or you want to register some providers?

I am thinking about a sort of step-by-step guide for making an icon provider, not for myself but for cases such as #12218. Like a Working with icon providers type of page to the wiki (https://github.com/adobe/brackets/wiki)


feat: Add System Statistics Metrics Endpoint

Summary of Changes
Added a new endpoint that can be called to fetch statistics from the database. The current implementation is just for neo4j. For the rest of the dbs it should show a non implemented error.
I didn't include it under the neo4j sub-url, since I strongly believe for that even the existing api.add_resource(Neo4jDetailAPI, '/latest_updated_ts')
should get renamed as it is now supporting more than the neo4j implementation (that I guess was  the only thing supported when it was first-released). Maybe it makes sense to make some changes and renamings in a follow-up MR for the existing latest_updated_ts endpoint.
That's why I created this one under the system file in swagger.
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes make test

Codecov Report

Merging #228 (25f0b5c) into master (2752492) will increase coverage by 2.53%.
The diff coverage is 70.68%.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   74.10%   76.63%   +2.53%
==========================================
  Files          25       27       +2
  Lines        1255     1344      +89
  Branches      136      160      +24
==========================================
+ Hits          930     1030     +100
+ Misses        297      269      -28
- Partials       28       45      +17

Impacted Files
Coverage Δ

metadata_service/api/user.py
100.00% <ø> (ø)

metadata_service/proxy/shared.py
28.57% <28.57%> (ø)

metadata_service/proxy/neo4j_proxy.py
71.59% <58.57%> (-3.41%)
:arrow_down:

metadata_service/api/badge.py
61.29% <61.29%> (ø)

metadata_service/api/system.py
66.66% <66.66%> (ø)

metadata_service/proxy/base_proxy.py
67.07% <71.42%> (-0.07%)
:arrow_down:

metadata_service/proxy/atlas_proxy.py
80.19% <79.31%> (-4.12%)
:arrow_down:

metadata_service/__init__.py
76.92% <100.00%> (ø)

metadata_service/api/dashboard.py
81.81% <100.00%> (+8.48%)
:arrow_up:

metadata_service/api/table.py
100.00% <100.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7bcf0...25f0b5c. Read the comment docs.

@feng-tao @allisonsuarez When you guys get some time, kindly asking for a Code Review here.
Thanks!

@feng-tao any reason we shouldn't land this?

Codecov Report

Merging #228 (7d752ba) into master (2752492) will increase coverage by 2.33%.
The diff coverage is 70.13%.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   74.10%   76.43%   +2.33%
==========================================
  Files          25       27       +2
  Lines        1255     1515     +260
  Branches      136      182      +46
==========================================
+ Hits          930     1158     +228
  Misses        297      297
- Partials       28       60      +32

Impacted Files
Coverage Δ

metadata_service/api/popular_tables.py
100.00% <ø> (ø)

metadata_service/api/user.py
100.00% <ø> (ø)

metadata_service/entity/dashboard_query.py
100.00% <ø> (ø)

metadata_service/entity/dashboard_summary.py
100.00% <ø> (ø)

metadata_service/entity/description.py
100.00% <ø> (ø)

metadata_service/entity/tag_detail.py
100.00% <ø> (ø)

metadata_service/proxy/statsd_utilities.py
81.25% <ø> (ø)

metadata_service/util.py
100.00% <ø> (ø)

metadata_service/proxy/shared.py
28.57% <28.57%> (ø)

metadata_service/api/badge.py
61.29% <61.29%> (ø)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc3193...7d752ba. Read the comment docs.


[BUG] Rename node text input messes up character encoding

Hi Ivan,
Looks like there's a new bug.
http://jsfiddle.net/7b05o9qt/3/

Right-click "Node1", click "Rename"
Type "<>", click away - node will get renamed
Right-click "<>" again and click "Rename"
You will see this:

That's using 3.3.1 version, but the issue isn't there in 3.0.x.
Thanks!

This is because of the escaping which prevents XSS attacks from happening (since jsTree allows the users to input HTML in the nodes). If you want the above example to work - disable HTML input:
http://jsfiddle.net/7b05o9qt/4/
Best regards,
Ivan

Yes, I know about force_text flag. But I have a scenario where I use HTML in node names - I'm adding children count: Node A <small title="This node has 6 children">(6)</small> AND I allow users to rename them.
Is there any chance that you'd decode entities before setting value of rename text input?
Thanks!


Get an Account on SAP BTP to Try Out Free Tier Service Plans

Tutorials: https://developers.sap.com/tutorials/btp-free-tier-account.html
I am afraid the best you can do now is to retire the tutorial, because the Free tier for BTP is not available for individuals anymore.

@AnnikaGonnermann @Madeline-Schaefer
Does this tutorial need to be retired based on the comment above?

Hey @CimermanDenis - thank you for your feedback. We've added a note stating "This tutorial helps you to sign an enterprise account with SAP that includes services with free service plans." For now, we are going to keep it for enterprise accounts.
Best
Annika


Update README.md - fix one grammar mistake.

I have noticed one grammatical mistake in README inside section "Bugs and feature requests"
"we make a best effort"  should be "we make our best effort"
Screenshot-

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please review my PR.

Sorry a few others found the same changes first. I'm curious, are these generated with some typo/grammar checker tool?


cannot f_open from SD card when using SRAM bootloader

i've recently had to implement the SRAM bootloader on a Daisy Seed for a project to compensate for my program's large size, and need to access an SD card for a JSON registry and .wav audio files. however, the program returns an error 1 (FR_DISK_ERR) after around 20 seconds of stalling on a call to f_open. f_mount on the root directory returns FR_OK.
another thing worth noting is that the bootloader takes 30 seconds to start the program (ie. the on-board LED is oscillating) when the SD card is connected, compared to the usual 2.5 seconds when disconnected. there are no .bin files on the SD card.
here is the code i have tried running on the internal flash as-is, on the SRAM memory with the bootloader and the QSPI memory. needless to say, it works normally on the internal flash; it doesn't on SRAM and QSPI
#include "daisy_seed.h"

using namespace daisy;

DaisySeed hw;
SdmmcHandler sdcard;
FatFSInterface fsi;

FIL file;

int main(void)
{
    hw.Init();
    hw.StartLog(true);

    System::Delay(1000);

    SdmmcHandler::Config sd_config;
    sd_config.Defaults();
    sdcard.Init(sd_config);
    fsi.Init(FatFSInterface::Config::MEDIA_SD);
    f_mount(&fsi.GetSDFileSystem(), fsi.GetSDPath(), 0);

    System::Delay(1000);

    hw.PrintLine("opening...");
    if(int result = f_open(&file, "registry.json", (FA_OPEN_EXISTING | FA_READ)))
    {
        hw.PrintLine("COULD NOT OPEN - %ld", result);
    }
    else
    {
        hw.PrintLine("OPENED OK");
    }
}

and here is my Makefile
# Project Name
TARGET = Sandbox
APP_TYPE = BOOT_SRAM
USE_FATFS = 1

# Sources
CPP_SOURCES = main.cpp

# Library Locations
LIBDAISY_DIR = ../libDaisy
DAISYSP_DIR = ../DaisySP

# Core location, and generic makefile.
SYSTEM_FILES_DIR = $(LIBDAISY_DIR)/core
include $(SYSTEM_FILES_DIR)/makefile

i am suspecting the bootloader of monopolizing the SD card management by virtue of its scan search for a .bin file on the device when it is connected. i absolutely do not need the SD card for that purpose, so this is a little annoying considering the internal flash seems to be my only option now.
is there something i can do to somehow be able to open and read files from the SD card again?
thanks!

So, this is more likely to do with the default layout of the SRAM linker script, which puts the default .bss (uninitialized memory) into the DTCMRAM on the STM32.
That memory is unable to communicate with the SDMMC peripheral.
The FIL object has to be in a location that can use that peripheral.
There are a few solutions:

You can use a linker script that reduces the "program space", and still utilizes the AXI SRAM for bss (albeit less), and leave your code as-is.

An example of the linker a linker script is here. The SRAM_EXEC section size determines the "program memory", while the SRAM section is your default internal bss size.

You can move the FIL object above into the external SDRAM (the only other memory section capable of communicating with the SDMMC).

This can be done by adding an attribute to the global variable:
FIL DSY_SDRAM_BSS file;

Hope that helps!

@stephenhensley hi! thank you for the quick response.
here is a list of the things i have tried since your comment:

using the default SRAM script while FIL is on .sdram_bss (DSY_SDRAM_BSS attribute);
using the nimbus linker script while FIL is on .bss (no attribute);
using the nimbus linker script while FIL is on .sdram_bss;
changing the default SRAM script so .bss goes to > DTCRAM AT > SRAM

nothing here seems to have worked, unfortunately... i am getting a consistent error log in each of those scenarios
f_mount 0
opening...
COULD NOT OPEN - 1

is there something i'm still missing here? linker scripts were completely new to me up until today, so i might not fully understand what is going on here...

okay! my bad, it seems like loading the program on the QSPI does allow for SD card operations. i must've messed up somewhere while testing it but APP_TYPE = BOOT_QSPI returns FR_OK on f_open.
this is still very strange to me though, from looking at the QSPI linker script it doesn't seem there is anything different from what i've been trying to tweak in the SRAM linker, aside from .text being loaded on the QSPI flash rather than the SRAM. do you have any ideas as to why this may be happening?

hmm, glad to hear you got it functioning on BOOT_QSPI.
I could have sworn I've done some SDMMC stuff with the BOOT_SRAM option. I've definitely done a few things with FatFS and USB drives while using the bootloader.
There shouldn't be much of a difference between the SRAM/QSPI linkers except that nearly all of the AXI SRAM is used for program space in the default SRAM linker.
In the case of using the .sdram_bss section, it may also be required to put the FatFSInteface in that section as well.

What return code do you get from your f_open call?

What return code do you get from your f_open call?

so far it's always been 1 (FR_DISK_ERR)

In the case of using the .sdram_bss section, it may also be required to put the FatFSInteface in that section as well.

i suspected that too, i think i tried it but it didn't change anything... i should definitely try it again though! it's entirely possible that this entire situation is caused by distraction errors, so i'll give it another proper go and report back if i can get a consistent error behaviour outlined. in any case i can confirm without a doubt that the QSPI linker script works :)

hi there! reporting back on this issue, i've come back to the linker script business and have found that the nimbus.lds file you've mentioned earlier works in conjunction with putting the DSY_SDRAM_BSS attribute on the FIL object! so i would consider this issue closed for now, as i can now manage to run my program with all features from the SRAM. thank you, and sorry for the inconvenience!


Roll Engine from b807dfde90a1 to b0eb010e68ed (1 revision)

https://github.com/flutter/engine/compare/b807dfde90a1...b0eb010e68ed
2021-06-12<EMAIL_ADDRESS>[web] last batch of test null safety (flutter/engine#26719)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


Fixed preview update of date and color

tasks:

[ ] gather feedback for my changes

related prs:

https://github.com/massiveart/husky/pull/581

informations:

q
a

Fixed tickets
none

BC breaks
none

Documentation PR
none

The preview change for color still doesn't work if you use the color picker to change the value.

@danrot fixed


RateLimitExceededEvent.java file is missing in  1.7.5.RELEASE

Describe the question
RateLimitExceededEvent.java file is missing in  1.7.5.RELEASE
Additional context

Hi @sharunthomas
This class is not there because it's a new feature, and as you can see here the line 1.7.x has hit its End-Of-Life (EOL) and is no longer maintained.
I suggest you upgrade to Spring Boot 2 and use the latest version of this library.


Fix TypeError when loading HTML5AudioFile

This PR

Fixes a bug

HTML5AudioFile#load would error in strict mode.

👍


Issue with setProgress in swift3

I tried to use setProgress(0.0, animated: true) at first but when I get progress by "self.progressBar.progress" it's return 0.3 not 0.0 and I tried to set 0.3035. It's still return 0.3 for me.
Why it's not update?

I have set at "self.progressBar.progress" instead of "setProgress" and it work fine!.
But I need animated. Is it a bug?


Content Management Systems, chapter 2, Sunday Roll Call

Leave a comment with these two things:

A summary of your last chapter using only emojis
Something you'd like to share, anything goes! (within respect)

emoji cheat sheet

😁

💯💻💯

:smiley:

:wave:

👍

👋😁👋

🤒🤔🤧😧🧐🥸

👍


Omnitrace 1.7: error out when data workers are used to async move minibatches from host->dev

Repro:
import torch
import numpy as np

assert torch.cuda.is_available(), "GPU is not available"

device = torch.device("cuda")

# Data workers > 0 leads to bug (pinned memory has no effect)
# https://pytorch.org/docs/stable/data.html#multi-process-data-loading
kwargs = {'num_workers': 1, 'pin_memory': True}

samples = 1000
shape = 5
out_elems = 2

# Inputs
train_tensorx = torch.Tensor(np.ones([samples, shape, shape]))
# Outputs
train_tensory = torch.Tensor(np.ones([samples, out_elems]))

train_dataset = torch.utils.data.TensorDataset(train_tensorx, train_tensory)
train_loader = torch.utils.data.DataLoader(train_dataset, batch_size=4, shuffle=True, **kwargs)

sumd = np.zeros([shape,shape])

for batch_idx, (data, _) in enumerate(train_loader):
    data = data.to(device)

print("Complete!")

fails with e.g.:

Produced on EPYC Trento + MI250X node (Crusher at OLCF). The slurm call was
srun --gpus=1 omnitrace-python -- worker_repro.py
Omnitrace (1.7)
PyTorch (1.13 + rocm5.2)

Was able to reproduce the error on Threadripper PRO 3955WX + RX6900XT.

I was able to reproduce the bug with CUDA too instead of HIP.
[New Thread 0x7ffff03a3700 (LWP 1071712)]
[New Thread 0x7fffefba2700 (LWP 1071713)]
[New Thread 0x7fffef3a1700 (LWP 1071714)]
[New Thread 0x7fffeeba0700 (LWP 1071715)]
[New Thread 0x7fffee39f700 (LWP 1071716)]
[848.464]       perfetto.cc:55903 Configured tracing session 1, #sources:1, duration:0 ms, #buffers:1, total buffer size:1024000 KB, total sessions:1, uid:0 session name: ""
[omnitrace][1071299][0] Setting up background sampler...
[New Thread 0x7fffed79c700 (LWP 1071717)]
[New Thread 0x7fffecf9b700 (LWP 1071718)]
[omnitrace][1071299][0][SIG27] Sampler for thread 0 will be triggered 300.0x per second of CPU-time (every 3.333e+00 milliseconds)...
[omnitrace][1071299][187] Background process sampling polling at an interval of 0.010000 seconds...
[omnitrace][1071299] OpenMP version: 201611, runtime version: LLVM OMP version: 5.0.20140926
[New Thread 0x7fff06a31700 (LWP 1071792)]
[New Thread 0x7fff06230700 (LWP 1071793)]
[New Thread 0x7ffef5a2f700 (LWP 1071794)]
[New Thread 0x7ffeed22e700 (LWP 1071795)]
[New Thread 0x7ffee4a2d700 (LWP 1071796)]
[New Thread 0x7ffedc22c700 (LWP 1071797)]
[New Thread 0x7ffed3a2b700 (LWP 1071798)]
[New Thread 0x7ffecb22a700 (LWP 1071799)]
[New Thread 0x7ffecaa29700 (LWP 1071800)]
[New Thread 0x7ffeba228700 (LWP 1071801)]
[New Thread 0x7ffeb1a27700 (LWP 1071802)]
[New Thread 0x7ffe9efcb700 (LWP 1071869)]
[Thread 0x7ffeb1a27700 (LWP 1071802) exited]
[Thread 0x7ffeba228700 (LWP 1071801) exited]
[Thread 0x7ffecaa29700 (LWP 1071800) exited]
[Thread 0x7ffecb22a700 (LWP 1071799) exited]
[Thread 0x7ffed3a2b700 (LWP 1071798) exited]
[Thread 0x7ffedc22c700 (LWP 1071797) exited]
[Thread 0x7ffee4a2d700 (LWP 1071796) exited]
[Thread 0x7ffeed22e700 (LWP 1071795) exited]
[Thread 0x7ffef5a2f700 (LWP 1071794) exited]
[Thread 0x7fff06230700 (LWP 1071793) exited]
[Thread 0x7fff06a31700 (LWP 1071792) exited]
[Detaching after fork from child process 1071870]
[New Thread 0x7ffeb1a27700 (LWP 1071871)]
[omnitrace][1071299][1] Creating new thread on PID 1071299 (rank: 0), TID 7
[New Thread 0x7ffeba228700 (LWP 1071895)]
[omnitrace][1071299][1][SIG27] Sampler for thread 1 will be triggered 300.0x per second of CPU-time (every 3.333e+00 milliseconds)...

Traceback (most recent call last):
  File "/opt/conda/envs/pytorch-cuda/lib/python3.9/site-packages/torch/utils/data/dataloader.py", line 1163, in _try_get_data
    data = self._data_queue.get(timeout=timeout)
  File "/opt/conda/envs/pytorch-cuda/lib/python3.9/queue.py", line 180, in get
    self.not_empty.wait(remaining)
  File "/opt/conda/envs/pytorch-cuda/lib/python3.9/threading.py", line 316, in wait
    gotit = waiter.acquire(True, timeout)
  File "/opt/conda/envs/pytorch-cuda/lib/python3.9/site-packages/torch/utils/data/_utils/signal_handling.py", line 66, in handler
    _error_if_any_worker_fails()
RuntimeError: DataLoader worker (pid 1071870) is killed by signal: Segmentation fault.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/jrmadsen/devel/c++/AMDResearch/omnitrace-dyninst/build-omnitrace/lib/python/site-packages/omnitrace/__main__.py", line 382, in main
    prof.runctx("execfile_(%r, globals())" % (script_file,), ns, ns)
  File "/home/jrmadsen/devel/c++/AMDResearch/omnitrace-dyninst/build-omnitrace/lib/python/site-packages/omnitrace/profiler.py", line 219, in runctx
    exec_(cmd, globals, locals)
  File "<string>", line 1, in <module>
  File "/home/jrmadsen/devel/c++/AMDResearch/omnitrace-dyninst/build-omnitrace/lib/python/site-packages/omnitrace/__main__.py", line 56, in execfile
    exec_(compile(f.read(), filename, "exec"), globals, locals)
  File "/home/jrmadsen/devel/c++/AMDResearch/omnitrace-dyninst/build-omnitrace/examples/python/pytorch-example.py", line 51, in <module>
    run(samples, shape, out_elems, **kwargs)
  File "/home/jrmadsen/devel/c++/AMDResearch/omnitrace-dyninst/build-omnitrace/examples/python/pytorch-example.py", line 25, in run
    for batch_idx, (data, _) in enumerate(train_loader):
  File "/opt/conda/envs/pytorch-cuda/lib/python3.9/site-packages/torch/utils/data/dataloader.py", line 681, in __next__
    data = self._next_data()
  File "/opt/conda/envs/pytorch-cuda/lib/python3.9/site-packages/torch/utils/data/dataloader.py", line 1359, in _next_data
    idx, data = self._get_data()
  File "/opt/conda/envs/pytorch-cuda/lib/python3.9/site-packages/torch/utils/data/dataloader.py", line 1315, in _get_data
    success, data = self._try_get_data()
  File "/opt/conda/envs/pytorch-cuda/lib/python3.9/site-packages/torch/utils/data/dataloader.py", line 1176, in _try_get_data
    raise RuntimeError('DataLoader worker (pid(s) {}) exited unexpectedly'.format(pids_str)) from e
RuntimeError: DataLoader worker (pid(s) 1071870) exited unexpectedly
Exception - DataLoader worker (pid(s) 1071870) exited unexpectedly

[omnitrace][1071299][0][omnitrace_finalize] finalizing...
[omnitrace][1071299][0][omnitrace_finalize]
[omnitrace] configuration:
[Thread 0x7fffed79c700 (LWP 1071717) exited]

Based on gdb not catching the segfault and this line:
[Detaching after fork from child process 1071870]

I suspect this is related to #191 -- i.e. omnitrace is segfaulting when the child process is exiting.

I've confirmed this all boils down to an issue with perfetto when fork is called while perfetto is still tracing. It works fine if I stop tracing when fork is called and resume tracing in the parent process returns from the fork call.

Closed by #250


Support automatic ref unwrapping in plugin-vue-jsx

Clear and concise description of the problem
I searched around and was surprised not to see any issues about this topic; I apologize if it's a duplicate.
JSX with Vue works great in vite, but it's very easy to forget which items are computed/refs and require .value
const App = defineComponent({
  setup() {
    const quantity = 100;
    const uom = "kg";
    const amount = computed(() => `${quantity} ${uom}`);

    return () => (
      <div class="bg-red-300">
        quantity: {quantity}, uom: {uom};{" "}
        {/* ☹ Invalid VNode type: undefined (undefined) at <App> */}
        You have {amount} of potatoes.
      </div>
    );
  },
});

Suggested solution
It would be really nice if the compiler was able to automatically unwrap ComputedRef and Ref without having to explicitly state .value, like SFCs do.
Alternative
Using .value everywhere in templates
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Hey @bbugh, this is not something in the scope of Vite Core. Check out https://github.com/vuejs/rfcs/pull/228 if you would like to see some ideas that the Vue community is thinking on to tackle this issue, but for reference Vite Core is framework agnostic so this kind of features should be implemented by each framework community through plugins.

Oh dang, sorry. That explains why I couldn't find anything. Thank you!


Medicaid question is not as simple as yes/no

Having only yes/no for the Medicaid option was difficult. User thinks most people won’t know this question, so potentially having a “maybe” would be good to allow them to get through the form. Some people are eligible for Plan First, which isn’t really that helpful healthcare-wise, but they might not be sure whether that counts as Medicaid for this question.

I vote for adding a "Not Sure" option

+1
This was verified again in user testing this morning

Don't see a yes/no field for medicaid. Could use more clarity on this before fixing.

We're talking about the Medicaid question on the prescreening page, not in patient details.

Thanks @esmithayer. Sorry @bengolder I assumed this question only existed within the pre-screener. Where else is it?

ooh, I was looking in patient details.

Let's keep this one open since we'll want to update in the server as well to make sure not sure evaluates uniquely. Do we think it should be lenient or strict?

We should tell them we aren't sure, and then direct them to a place where they can figure it out. In essence, we should deal with these answers the way that Access Now or others would deal with it, which I assume is to refer people to navigators.

Definitely better. We've heard feedback on the pre-screening asking for information as to why and why aren't individuals eligible. Pointing to a navigator sounds great.


Add documentation badge to README.md

Codecov Report

Merging #68 (d5c3f41) into master (ea7b76c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   91.57%   91.57%
=======================================
  Files           7        7
  Lines        2268     2268
=======================================
  Hits         2077     2077
  Misses        191      191

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7b76c...d5c3f41. Read the comment docs.


Improve the layout of info on the 'Test ownership' page.

Some of these include:

Removing the FAQs and integrating their content into relevant page headings that provide instructions on how to do a task (or fulfil a use case).
Moving the upload TESTOWNERS file to after the heading/section that explains the format of the file first.
Moving content on how to obtain team slugs to the top of the TESTOWNERS file format heading/section.

The following description of the first test file pattern in the TESTOWNERS file:
# The following example teams will be the test owners for all test
# location metadata (that is, test files) from your pipeline builds
# in this repository. While both these example teams own these
# tests, the first team specified in this file pattern becomes the
# default owner for all test files from your pipeline builds. Any
# file pattern matches defined later in this file take precedence
# and override any file patterns defined further up this file.
# Therefore, unless a subsequent file pattern match takes
# precedence, `team-slug-1` will have any flaky tests assigned to
# them by default.
*                     team-slug-1 team-slug-2

which I had modified to make a little clearer, still doesn't really explain the purpose behind specifying multiple teams for this (or any other) test file pattern.
The original FAQ:

Can more than one team own a test?
More than one team may own a test, and the order of teams in your TESTOWNERS file is important. The first team listed will be the default owner, and they will be auto-assigned to the test if it flakes. Any team with suite access can override this auto-assignment.

Also doesn't really explain clearly why I would want to specify additional teams for a given test file pattern.

Paraphrased from @jameshill regarding specifying multiple teams for a give test file pattern:

Default team: this team will be automatically notified of issues with the test
Other teams: can be identified as an owner, and therefore will appear in reports around the reliability of that test. However, these teams will not be notified

Will update the docs content accordingly.


[ContainerRegistry] update for better codegen for data plane Track 2 SDK libraries

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify: update swagger to allow better codegen for data plane Track 2 SDK libraries

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@jeremymeng , if the Track 1 swagger filepath is  Microsoft.ContainerRegistry/preview/2019-08-15/, would it make sense to move the Track 2 swagger to a filepath with a different date?  Or does the date mean a specific version of the service, and so the Track 2 file describes the same one and we should use the same date?

Or does the date mean a specific version of the service

yes I believe it is the service version. At least that what I've been seeing in Storage.

@jeremymeng is this ready to merge?

@jeremymeng is this ready to merge?

@tjprescott I contacted and would like to get some review and approval from the service team first.

@jeremymeng please ping me when you are ready to merge this

@tjprescott It's ready to go!


Remove legacy REST API versions

Closes: #3224
What's Changed

Change default REST API version to 2.0
Remove declared support for REST API versions 1.2 through 1.5
Remove REST API serializers specific to versions of the API prior to 1.5/2.0

Remove viewset versioning that used these older serializers
Remove test cases that were specific to older API versions

TODO

[x] Explanation of Change(s)
[x] Added change log fragment(s) (for more information see the documentation)
n/a Attached Screenshots, Payload Example
[x] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features) - need to document changes to API deprecation policy.
n/a Example Plugin Updates (when adding/changing features)
[x] Outline Remaining Work, Constraints from Design

Does this doc still need to be updated? https://docs.nautobot.com/projects/core/en/stable/development/#deprecation-policy

Does this doc still need to be updated? https://docs.nautobot.com/projects/core/en/stable/development/#deprecation-policy

Yes, my understanding was that @bryanculver was planning to handle that with a separate PR into develop.

Does this doc still need to be updated? https://docs.nautobot.com/projects/core/en/stable/development/#deprecation-policy

Yes, my understanding was that @bryanculver was planning to handle that with a separate PR into develop.

I think we should still document which APIs and serializers are being removed as of this PR which hopefully I can get to before EOD.

Should we also address this: https://github.com/nautobot/nautobot/blob/gfm-issue-3224/nautobot/extras/api/views.py#L606-L609 in this PR?

Should we also address these:
* https://github.com/nautobot/nautobot/blob/gfm-issue-3224/nautobot/extras/api/views.py#L606-L609

* https://github.com/nautobot/nautobot/blob/gfm-issue-3224/nautobot/extras/api/views.py#L640-L644

in this PR? Or is that separate because it's not necessarily versioned.

We should definitely consider removing them in 2.0, but since those aren't versioned endpoints, I think they're beyond the scope of this PR.


commands after switchTo in webdriverio works like there was no switchTo

For example i want to test a page with link to target=_blank.
I use  I.switchTo(0);
And in selenium i see that the it indeed switched to this new page. But any following command after it just bring focus on the first page again, so im not able to test whats on that second page.

Hi @aldarund
is switchTo method is working for you ?
because i tried it's not working for. getting - Unsupported frame locator: java.util.HashMap

Please try to update to 1.0.0 and try again. to switch to iframe, use switchTo, if you want to switch tab, use switchToNextTab


Remove dependecy of vulnerable uglify-js version.

Is your feature request related to a problem? Please describe.
The poject uses an outdated version of uglify-js (version 1.3.5, from dist which is an 11 year old package not developed any more). It is affected by CVE-2015-8857.
Describe the solution you'd like
The dependency on the package with a critical vulnerability should be removed. Either by replacing the dist package with a newer version, or using the newer version of uglify-js for this package.

Hello,
I am not a JS developer, so I am not sure what solutions are valid here. I am also not sure how dependencies are handled, especially with the case here where multiple versions of the same package are a dependency. I also don't know which tools can be used for testing. If you have any hints I could start looking into this myself.

Hi @kappmeier
Thanks for pointing this out. I'm not sure why, but Dependabot Alerts never fired for these, but I did see them in the security tab once I went looking.
Thankfully, these packages were not in use and I was able to simply remove them as deps.

This will be fixed in v3.5.1, which I am working on releasing now


venafi: cabundle field example

We can't get a venafi issuer to connect to venafi because the ca bundle is not parsed correclty.
We have the certificate in pem format, it looks like:
----- BEGIN CERTIFICATE ---
...
...
---- END CERTIFICATE ---

how do we pass this to the venafi issuer?
Can we get an example, may be added to the doc?
The doc seems to suggest that we have to encode this pem file with base64 and pass the result as a single line array of bytes. We tried that (removing the \n) and it didn't work.
We tried passing the already base64 encoded content of the pem file (the content between BEGIN and END) as a single line array (removing the \n) and it didn't work.
We tried passing the entire file, as a single line and it didn't work.
/kind bug

we keep getting this error: Failed to parse PEM trust bundle, which seems to be coming from here: https://github.com/Venafi/vcert/blob/756b43677ddb75cca676b33d8504db2aa3578dd6/client.go#L41

I'm also stuck on this.
Does it want the actual plain-text contents? For example,
caBundle: |
-----BEGIN blah blah-----
adgasdfsaf
------END blah blah------
Does it want it as a single line?
caBundle: -----BEGIN blah blah ------xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx------END blah blah-----
Does it want the whole thing encoded again?
caBundle: AB7239C3029BCE12387
It's unclear and I can't get anything to work..

I'm also stuck on this.
Does it want the actual plain-text contents? For example,
caBundle: |
-----BEGIN blah blah-----
adgasdfsaf
------END blah blah------
Does it want it as a single line?
caBundle: -----BEGIN blah blah ------xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx------END blah blah-----
Does it want the whole thing encoded again?
caBundle: AB7239C3029BCE12387
It's unclear and I can't get anything to work..

Figured I'd post as this did come back up on slack.
You want it on one line in base64 format. Eg this is from k explain issuer.spec.venafi.tpp
  caBundle	<string>
    Base64-encoded bundle of PEM CAs which will be used to validate the
    certificate
    chain presented by the TPP server. Only used if using HTTPS; ignored for
    HTTP.
    If undefined, the certificate bundle in the cert-manager controller
    container
    is used to validate the chain.

So you want to take your CA cert:
cat myca.crt | base64

Take that output and put it in your issuer:
spec:
  venafi:
    caBundle: <String from above>

Please note to ensure you encode it with 1 line output. On linux I think that's base64 -w0 but on mac it does this by default.


Proposal: Make it easier to specify (and comment) a list of illegals

Is your request related to a specific problem you're having?
Yes, illegal can become hard to read when it includes multiple items.
Any alternative solutions you considered...
I saw this in routeros which brought this to my attention (again).
      { // illegal constructs
        variants: [
          { begin: /^@/, end: /$/ },               // dns
          { begin: /\/\*/, end: /\*\// },          // -- comment
          { begin: /%%/, end: /$/ },               // -- comment
          { begin: /^'/, end: /$/ },               // Monkey one line comment
          { begin: /^\s*\/[\w-]+=/, end: /$/ },    // jboss-cli
          { begin: /\/\//, end: /$/ },             // Stan comment
          { begin: /^\[</, end: />\]$/ },          // F# class declaration?
          { begin: /<\//, end: />/ },              // HTML tags
          { begin: /^facet /, end: /\}/ },         // roboconf - лютый костыль )))
          { begin: '^1\\.\\.(\\d+)$', end: /$/ }   // tap
        ],
        illegal: /./
      },

But this is very verbose and you have to think about it for a minute to realize what it's doing.
Note: Do not focus on if this is a GOOD idea for routeros to have such a long list (it may not be)... that's not a concern here... there are definitely cases where a list of 2-3 illegals makes very good sense.  I only show this as one example of how you'd do this today (get a more readable illegal list) without any core library changes.
The solution you'd prefer / feature you'd like to see added...
Instead I'd like to formalize that as:
{
    illegal: [
      /^@/,      // dns
      /\/\*/,    // C style multi-line comment
      /%%/,      // some other comment...
      // ...
    ],
}

And these would be auto-joined with regex.either...  The older single regex or string format would still be supported.  But if we saw an array here when we're call regex.either on it...

Very much related: https://github.com/highlightjs/highlight.js/issues/2833
This is exactly the kind of this this proposal would make trivial:
(mode, parent) => {
  if (typeof mode.illegal === "object") {
    mode.illegal = regex.either(mode.illegal)
  }
}

A ~5 line plugin PLUS the tests for this would also be trivial since we only need to test the transform itself, not the whole parser.


Set up with Appveyor

#6  Needs completed first.

I didn't know you could use mingw with Appveyor. I will have to look into this to actually implement it. If you know an example, please leave a link <3


Adds clickable stunts and stunt chat output

This PR partially handles a fairly old feature request (#39), giving users the ability to click stunts to send the stunt name and description to the chat.
New templates and styles have been added as part of the update.
I haven't touched aspects and consequences as part of this addition as the layout is completely different, and I think some thought needs to be put into how to best handle the additional functionality for those components.
I was originally going to merge this code into your existing rollable-stunts branch, but I see that that branch is way behind the current master. I've also been working with the 0.8.x version of FateX, so it might be best to roll this update into some of the 0.8 compatibility improvements and fixes. Feel free to merge it wherever you think is appropriate.

Basically all of these changes make use of the old styles and template structures. I think it would be more work to update this to the current approach than to just write it from scratch.


erigon: 2.55.1 -> 2.59.2

Description of changes
Bumps erigon to 2.59.2.
This is required to sync with the current mainnet, 2.55 is pre-Dencun and can't proceed past March 13th.
This also matches the go tags to what upstream does in their releases - the addition of silkworm recently broke the build for auto-updates - they should work again after this.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thank you !


platform support

This PR includes a lot of changes to make Lensed run on a wider variety of platforms.
To make installation under Linux easier, there are two new features regarding dependencies. The first is the deps folder: as explained in the README, one can extract either or both of CFITSIO and MultiNest there, run make deps from the root folder of Lensed, and a subsequent call to make will pick up the dependencies automatically. The second is a set of variables that can be passed to make for specifying the location of the OpenCL implementation and a number of extra libraries that are necessary to link MultiNest (e.g. -llapack -lblas -lgfortran when using GCC). These settings are cached and need not be passed on subsequent builds.
Further changes deal with the craziness that is OpenCL across platforms. I tried to support everything from OpenCL 1.0 to 1.2 as well as possible, falling back to some sensible defaults when something is not supported by the older standard. Also implementation-specific details for Nvidia and Apple platforms have been taken care of. The result is the beginning of wrapping up OpenCL functionality into Lensed-specific modules, as per #63, resulting in less code duplication. An additional benefit is the (theoretical) support for multiple OpenCL platforms on the same machine.
Finally, some incompatibilities of the code with pure standard C99 have been removed.
I have tested this PR on the systems available to me: Mac with Intel & AMD, Linux with CUDA 4.0. I would be happy for further tests before merging it.

Don't merge this yet, I want to work out some related kinks before testing this again.