[BUG]

Hi, I'm experiencing some interoperablity issues with other AWS services in the same AWS Lambda that I'm using to connect to my Amazon Opensearch cluster.  Below is the code that I'm using to connect and test with.
You'll see I'm throwing an error to test the catch that will send an SNS message (reportError is just an SNS Publish).  With no errors it runs fine and I get my ping response back.  If I remove the Opensearch code and throw and error the SNS works fine but when I have both I get a timeout.
import * as Validator from "../libs/validation";
import { reportError } from "../libs/reportError";
import { createAwsConnector } from "../libs/aws-connector";
import { defaultProvider } from "@aws-sdk/credential-provider-node";
import { Client } from "@opensearch-project/opensearch";

// getDevices returns a list of all the devices in a property
export const handler = async (event, context) => {
  const {
    headers = null,
    // pathParameters = null,
    // queryStringParameters = null,
  } = event;
  let client = null;
  try {
    const credentials = await defaultProvider()();
    client = new Client({
      ...createAwsConnector(credentials, process.env.REGION),
      log: "trace",
      node: process.env.ESHOST,
    });
    const response = await client.ping();
    console.log(`Got Response`, response);
    throw new Error("test");
    const value = Validator.headers.validate(headers);
    if (value.error) {
      return {
        statusCode: 400,
        body: JSON.stringify({
          errors: value.error.details.map((detail) => detail.message),
        }),
      };
    }
    return {
      statusCode: 200,
      body: JSON.stringify({ message: "hi" }),
    };
  } catch (error) {
    await reportError(
      `${process.env.SERVICE_NAME} error`,
      `${JSON.stringify(error.stack, null, 4)} \n\n timestamp: ${Date.now()}`
    );
    console.log("error", error.stack);
    return {
      statusCode: 400,
      body: JSON.stringify({
        error: "something",
      }),
    };
  }
};

Is it possible the Opensearch connection conflicts with the ability to send to other AWS Services?  Is there a way to close the Opensearch Client so that I know for sure the collection is down?  I am running the Lambda in the same VPC as the Opensearch cluster and it can connect to other AWS services so long as I don't do the Opensearch connection.
Thanks!

I think I found the issue.  Likely related to VPC configuration.


Revert "Get a truly unique prefix per cluster searcher globally."

Reverts vespa-engine/vespa#19684
Broke system test https://github.com/vespa-engine/system-test/blob/master/tests/search/explain/explain.rb

Tests needs an update. Will fix.


go CLI does not have the expected type for annotation values

The go CLI is setting the value type as a String even when the expected type should be JSON.

Example:
wsk -i action get /whisk.system/samples/wordCount
"key": "sampleInput",
"value": "{ "payload": "Five fuzzy felines"}"


Investigate why containing is very slow sometimes

@jBorkowska experiences this in the customer project. On big widget trees, it takes many minutes for a single withDescendant to complete.

Looks like "complex finders are slow" is not only our realization. See the spot package. One of its goals is:

find.ancestor() and find.descendant() are slow, spot aims to be faster by walking a subset of the widget tree

We might want to check it out in the future. That package looks very interesting.
cc: @jBorkowska, @mateuszwojtczak, @shilangyu


omrse.owl dead, long live omrse-core.owl?

As of https://github.com/ufbmi/OMRSE/commit/0441eaddfbab7ea9493ae18b2fa08033ca8832b1 , https://raw.githubusercontent.com/ufbmi/OMRSE/master/omrse/omrse.owl contains 0 classes and is otherwise < 3 KB in size.
On the other hand, https://raw.githubusercontent.com/ufbmi/OMRSE/master/omrse/omrse-core.owl has lots of classes and is 260 KB.
Should I start using omrse-core.owl instead of omrse.owl?

Mark,
Functionally, yes, the old omrse.owl has been moved to omrse-core.owl.  You
would miss all new modules that get imported into omrse.owl other than
core, however.  Such as omrse-language.owl and the hot-off-the-presses
omrse-education.owl (which is still only on the development branch).
Bill
On Thu, Apr 23, 2020 at 11:28 AM Mark A. Miller<EMAIL_ADDRESS>wrote:

As of 0441ead
https://github.com/ufbmi/OMRSE/commit/0441eaddfbab7ea9493ae18b2fa08033ca8832b1
, https://raw.githubusercontent.com/ufbmi/OMRSE/master/omrse/omrse.owl
contains 0 classes and is otherwise < 3 KB in size.
On the other hand,
https://raw.githubusercontent.com/ufbmi/OMRSE/master/omrse/omrse-core.owl
has lots of classes and is 260 KB.
Should I start using omrse-core.owl instead of omrse.owl?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ufbmi/OMRSE/issues/100, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJR55S6WRXS75OZ7AAJ4V3ROBNCRANCNFSM4MPEZVDA
.

I'm assuming your question is answered.  If you have a request for a change, or additional questions, please don't hesitate to start a new issue.


debian related

unfortunately i cannot easily work on this currently because dssp2-standard relies on selinux 2.7 RC1 but there are 3 things in debian stretch that need addressing:

make the rpm module work for apt/dpkg:
this should be relatively easily by just labeling apt and dpkg with the rpm.cmd_file type and by making rpm.script.subj an aliases of dpkg_script_t

make openssh work:
in debian we cannot use the $!_ssh_user_server.subj solution so debian needs its own user context config files: because ssh_server needs to transition to user domains instead of ssh_user_server domains. and i need to allow ssh_server to transition to these user domains

associate wheel.id with the adm group in debian instead of the wheel group
debian uses adm group instead of wheel group

as for 1. i took care of dpkg (i think) just need to address apt i suppose


MD029 Is there a way to "hide" tables embedded in an ordered list?

Hi @DavidAnson
We have developed training documentation where we want to embed a table into an ordered list.  Unfortunately, when we do that, it breaks the ordered list and is reported as an error in MD029.  See below for an example.  If there was a way to "hide" the table, such as when one hides a special character by placing the backslash character immediately before it, that might work?

Here is a table in an ordered list with no issues. Is that what you want?
https://dlaa.me/markdownlint/#%25m%23 Table in ordered list

1. Text
   | Table | Table |
   |-|-|
   | Table | Table |

Here is a table in an ordered list with no issues. Is that what you want?
https://dlaa.me/markdownlint/#%25m%23 Table in ordered list

1. Text
   | Table | Table |
   |-|-|
   | Table | Table |

Yes this would work.  I attempted to indent the tables 4 spaces, but when I did that, they blew up.

Yes this would work.  I attempted to indent the tables 4 spaces, but when I did that, they blew up.

Maybe try adding the leading | to the rows when you indent

Maybe try adding the leading | to the rows when you indent

Thank you @DavidAnson and @nschonni.  It worked great.  The tables blew up because I didn't indent the appropriate number of spaces. Now is both formatted correctly and passing the lint check.  This item has been resolved.

Thank you @DavidAnson and @nschonni.  It worked great.  The tables blew up because I didn't indent the appropriate number of spaces. Now is both formatted correctly and passing the lint check.  This item has been resolved.


Update JIRA when a finding is edited

Description
When you edit a finding, the JIRA is not updated.
Test results
Tested that the description + title of a JIRA are updated when the finding is edited.

@coheigea this could be very alarming to users not expecting this new behavior. Could you add a checkbox to the Jira config option toggling this behavior? Same thing for #7707

@Maffooch Done, please review again. I'll update the other PR to use this config when this PR is applied.


Jira Issues vs. GitHub Issues

One of the development tasks for the GitHub Plugin is to collect "Changes on Issues".  My assumption is this is analogous to Jira Changelogs, which are used to calculate Issue Lead Time. However, Issues in GitHub are different from Issues in Jira. So if we are going to calculate Issue Lead Time based on GitHub data, we will need a different approach.
My understanding is that Jira Changelogs tell us about changes in status from opening to closing. We will want to consider how we can infer changes in status from GitHub data.
One thing we should consider is that Issues in GitHub are often linked to Pull Requests. We can consider enriched fields like "Time to First Pull Request" on an issue. In this way, we could tell the time between when an Issue is first opened to when a Pull Request is first opened for that Issue, to when that Pull Request is finally merged, and maybe some steps in between, like "reviewed", "commented on" or "assigned".
These are some suggestions of how we can infer something similar to Lead Time and status changes. Please comment below with any further thoughts or suggestions.
Thanks!

@klesh @Startrekzky Key differences between Jira issue and Github issue:

Github issue doesn't have the various statuses that Jira issue has. For Github issue, it's just open or closed.
Github issue doesn't differentiate between resolved and rejected. We only know it's been closed.

@kevin-kline Please correct me if I'm wrong.
@klesh @Startrekzky We'll need to factor these differences in when we design the domain layer.

Yep, we still need to collect the label-event we talked about the other day.
We may work sth out base on that.

This is now covered in our design docs


Fix tf-signal tests on pip packages.

Jenkins, test this please.

Sorry about this! Is there any way I should have noticed this? I'm pretty sure internally the pip tests were passing when I submitted.

I think one way was pip_smoke_tests, but we need a better way to explain the situation in the presubmit tests.


OpenScan breaks with 12 pages

Using the fdroid version, I scanned 12 pages and when trying to edit them, the system breaks and I have to forceshutdown it.
The smaller scans with just a few pages work fine.
And I was able to crop 3 or 4 pages before this happened.

Could you mention your phone specs?

Phone: Xiaomi Mi 9 (Model M1902F1G)
Android: 10
OpenScan: 2.2.0 (F-Droid)


⚠ Bofrost.fr has degraded performance

In f5e1188, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1302 ms

Resolved: Bofrost.fr performance has improved in 672ff9e after 6 minutes.


Duplicate file builds with Lambdas using same handler file

I have been playing with logLevel: info  and have discovered that if you have multiple lambda functions defined using same root handler file, builder is executed multiple times (once for each lambda) which adds build time for many functions.
Example serverless.yml
package:
  individually: false

functions:
  function1:
    handler: src/handler.handleFunction1
    events:
     - http:
          method: get
          path: function1

  function2:
    handler: src/handler.handleFunction2
    events:
     - http:
          method: get
          path: function2

It produces logs
  .esbuild\.build\src\handler.js      1.1mb
  .esbuild\.build\src\handler.js.map  4.2mb

Done in 386ms

  .esbuild\.build\src\handler.js      1.1mb
  .esbuild\.build\src\handler.js.map  4.2mb

Done in 400ms

I have tried it and is using it with multiple function and it really adds time to build.
It would be great if it was possible to only build unique files.

I think this should stem down to why would you use the same handler as an entrypoint? This defeats the purpose of esbuild in trying to create the smallest possible file size for you.

@samchungy not in case when using
package:
  individually: false

then I am expecting to have all functions bundled in one ZIP file
And when most of lambdas are working with same libraries and only difference is preprocessing incoming data in different format for different lambda function, such code is eventually just a small part of overall code and doesn't need to be split to different entrypoints, but it is more cleaner to have it as separate lambda


Load image from repo if present

Do not run repo2docker but load an image if image.tar is present. The name of the image could be set, use the ID, or configured via codecheck.yml.

The name of the image is in the image metadata... it's simply the one generated by r2d.
https://github.com/jupyter/repo2docker/pull/778 has this. Let's see if it get's merged...


workaround to uses of arbitrary_loop causing non-determinism

I am implementing Arbitrary by hand and using it with cargo-fuzz. Ideally, I'd like to allow the fuzzer to control the length but I wanted to experiment with different upper bounds before picking one in the harness. However, I noticed that I could not re-use the corpus given changing the upper bound introduced non-determinism, and I'd like to be able to simply insert/ extend from the corpus instead of starting from scratch. Is there an alternative pattern to support looping being configurable without affecting how the rest of the input is interpreted?
For example, I have something in my harness very similar to https://github.com/bytecodealliance/wasm-tools/blob/main/crates/wasm-smith/src/core.rs#L1070 where I am modifying u.arbitrary_loop(Some(1), Some(100),. to u.arbitrary_loop(Some(1), Some(1000),.

Unfortunately this is a fairly fundamental limitation of arbitrary's approach. You could do things like always consume 100 bytes of input, create a new Unstructured of those 100 bytes, and do your arbitrary loop with that sub-Unstructured but it is pretty clonky and maybe wastes bytes or maybe 100 bytes isn't enough, etc...

Thanks, I will have to re-think my approach and consider how to seed the fuzzer more effectively


Add confirmation on public key retrieval

Currently the app does not prompt on public key retrieval.
Proposition :

Implement a new command ConfirmRecipient that:

send an identity to Ledger Nano,
returns the public key and 90 00 only if it matches the Ledger Nano public key.

Add prompt on command GetRecipient (02)

Done in dcf11249d09c81e30578021bbc3b96552ed78e1a and app-age/434ab54.
Thanks.


Upgrade Apache Arrow to 10.0

Arrow release starts to break build again.

Still pending homebrew and pypi to get arrow 10.
We should pin the arrow version later to control the release timing.


how to config different configmap for different pod in one statefulset

I want to inject configmap of telegraf for rabbbitmq cluster, and rabbitmq run in one statefulset with three replicas. And the need of monitor is config rabbitmq node self for rabbitmq pod like this:
[[inputs.rabbitmq]]
url = "http://<IP_ADDRESS>:15672"
username = "admin"
password = "QINtwo5P16SsCmPv"
header_timeout = "3s"
client_timeout = "4s"
nodes = ["rabbit@msg01"]
So how can I config for telegraf configmap of rabbitmq to achieve this need, when one pod of rabbitmq statefulset start, it config nodes with pod hostname for pod configmap thank you!

Hi @like-inspur. I do not quite follow the issue here. The k8s-sidecar-injector is responsible for adding containers, environment variables, and volumes into pods as they are being launched.
You might look into using k8s service discovery to have stable DNS name for your rabbitmq instance, and hardcode that into your config for telegraph.


Enhancement proposal: Dependency injection support using an attribute

Instead of having to assign the instance to a field in the constructor manually:
public class MyClass
{
	private ClassToInject _classToInject;

	public MyClass(ClassToInject _classToInject) {
		_classToInject = classToInject;
	}
}

Allow this kind of syntax for dependency injection, like most DI frameworks:
public class MyClass
{
	[Inject]
	private ClassToInject _classToInject;
}

This would save a lot of code, much easier to maintain and much more readable when there is a lot of dependencies.

Similar to BlazorComponent injection: https://blazor.net/docs/dependency-injection.html#request-a-service-in-a-component
For base classes is very useful

Closing because while this is an interesting suggestion, we have no plans to support this pattern. There are some 3rd party DI containers that can be used with ASP.NET Core that support similar patterns.


Unable to setup Nord vim with packer.nvim

I've been trying to install Nord vim on neovim with packer but am getting this error
Error detected while processing /data/data/com.termux/files/home/.local/share/nvim/site/pack/pack
er/start/nord-vim/colors/nord.vim:
line  729:
E117: Unknown function: exist
line  862:
E117: Unknown function: exist
Press ENTER or type command to continue

I am using termux but I've tried it on my pc too and got the same results.
I am trying to write my config in Lua for the first so I am confused that if I messed smth
Thanks

This again, this should have been fixed by e2555c10c7f006f9a052419bc00056456731da6b


s3: Update to new changes in minio-go

Fixes #388

Don't merge this yet, there is one more change i am pushing which needs to be fixed.

Thanks for the PR, just ping me if you're done, then I can just update minio-go in restic. :)


Delete Files in Table Scans

I'm looking to start work on proper handling of delete files in table scans and so I'd like to open an issue to discuss some of the design decisions.
A core tenet of our approach so far has been to ensure that the tasks produced by the file plan are small, independent and self-contained, so that they can be easily distributed in architectures where the service that generates the file plan could be on a different machine to the service(s) that perform the file reads.
TheFileScanTask struct represents these individual units of work at present. Currently though, it's shape is focussed on Data files and it does not cater for including information on Delete files that are produced by the scan. Here's how it looks now, for reference:
https://github.com/apache/iceberg-rust/blob/cde35ab0eefffae88c521d4e897ba86ee754861c/crates/iceberg/src/scan.rs#L859-L886
In order to properly process delete files as part of executing a scan task, executors will now need to load in any applicable delete files along with the data file that they are processing. I'll outline what happens now, and follow that by my proposed approach.
Current TableScan Synopsis
The current structure pushes all manifest file entries from the manifest list into a stream which we then process concurrently in order to retrieve their associated manifests. Once retrieved, each manifest then has each of it's manifest entries extracted and pushed onto a channel so that they can be processed in parallel. Each is embedded inside a context object that contains the relevant information that is needed for processing of the manifest entry. Tokio tasks listening to the channel then execute TableScan::process_manifest_entry on these objects, where we filter out any entries that do not match the scan filter predicate.
At this point, a FileScanTask is created for each of those entries that match the scan predicate. The FileScanTasks are then pushed into a channel that produces the stream of FileScanTasks that is returned to the original caller of plan_files.
Changes to TableScan
FileScanTask
Each FileScanTask represents a scan to be performed on a single data file. However, multiple delete files may need to be applied to any one data file. Additionally, the scope of applicability of delete files is any data file within the same partition of the delete file -  i.e. the same delete file can need to be applied to multiple data files. Thus an executor needs to know not just the data file that it is processing, but all of the delete files that are applicable to that data file.
The first part of the set of changes that I'm proposing is refactor FileScanTask so that it represents a single data file and zero or more delete files.

The data_file_content property would be removed - each task is implicitly about a file of type Data.
A new struct, DeleteFileEntry, would be added. It would look something like this:struct DeleteFileEntry {
    path: String,
    format: DataFileFormat
}

A delete_files property of typ Vec<DeleteFileEntry> would be added to FileScanTask to represent the delete files that are applicable to it's data file.

TableScan::plan_files and associated methods
We need to update this logic in order to ensure that we can properly populate this new delete_files property. Each ManifestEntryContext will need the list delete files so that if the manifest entry that it encapsulates passes the filtering steps, it can populate the new delete_files property when it constructs FileScanTask.
A naive approach may be to simply build a list of all of the delete files referred to by the top-level manifest list and give references to this list to all ManifestEntryContexts so that, if any delete files are present then all of them are included in every FileScanTask. This would be a good first step - code that works inefficiently is better than code that does not work at all! It would also permit work to proceed on the execution side.
Improvements could then be made to refine this approach to filter out inapplicable delete files that goes into each FileScanTask's delete_files property.
How does this sound so far, @liurenjie1024, @Xuanwo, @ZENOTME, @Fokko?

Hi, I've recently implemented merge on read in my library using iceberg rust and submitted a working simplified version of the code, which looks somewhat similar to the A naive approach version you proposed!  (I have to read the same delete file on my different nodes)
This pr is https://github.com/apache/iceberg-rust/pull/625
About this issue. I have some doubts.
About FileScanTask {DeleteFileEntry}. as you said, the delete file and data file are many-to-many, so even if list delete file is saved in the file task, in the optimal case, the call still needs some special operations to make sure that all data file and delete file are dispatched to the same node, and that the delete file file is not read repeatedly. And most likely, this scheduling result is consistent with the partitioning result.
In this case, I prefer to expose the partitioning result directly in the file task. Please correct me if there is any misunderstanding

I'm happy to add the partitioning result to the task. This is useful to the executor node when deciding how to distribute tasks, as it enables the use of a few different strategies, the choice of which can be left to the implementer.
It is not necessarily the case that the delete file is read repeatedly if the delete file list is added to the file scan task, since we can store the parsed delete files inside the object cache, preventing them from being read repeatedly on the same node as they'd already be in memory. If the executor ensures that all tasks with the same partition get sent to the same executor, then the files would only be read once.

Thanks - I have some skeleton code for the required changes to reader.rs that I'm going to share over the next few days as well.

Thanks for taking a look at the above, @liurenjie1024. I've just submitted a draft PR which outlines the second part of the approach - how we extend the filtering in the arrow reader to handle delete files. https://github.com/apache/iceberg-rust/pull/652
@liurenjie1024, @Xuanwo, @ZENOTME, @xxhZs: if you could take a look at that PR also when you get chance and let me know if you think that the approach seems sensible, that would be great!


HAP fails to parse tag with space after opening bracket

It seems like HAP fails to recognize
"
< table"
as the start of a TABLE-tag.
Instead I get a #text element that starts with "\r\n< table"
I had to workaround this by parsing the document twice, first time modifying innerHtml of  text nodes regex-replacing "^\s*<\s+" with "<", then reparsing the corrected document.
Browsers are perfectly happy with a space there so I think HAP also should be.
Running 1.8.1 from nuget.

Hello @JorgenLindell

Browsers are perfectly happy with a space there

I disagree here, most browser (if not all) will parse is as text.
The following HTML:

asa

 will parse the
 as a text field like HAP do.
The HTML will display the following output:
asa
I'm not sure which browser you use, but one we tried didn't supported the additional space.
Best Regards,
Jonathan

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Bulk Operations •  Dapper Plus •  LinqToSql Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

Hi,
You are right, sorry. I was convinced that fragment came from an actual working page. Obviously it wasn't. (Or it was, but that page was broken...)
Sorry for wasting your time.
brgds
Jörgen


population viability filtering unavailable

I just noticed that in my updated screencast it is not possible to filter population phenotypes on viability, even when viability annotations are present.
See ark1

ignore ;)


Upgrade JarJar to 1.6.5 for better Java 9 support

Needed to be able to shade some jars that contain Java 9 module info.

@eed3si9n I know you have a lot on your plate, but would it be possible to get this merged and released? Is there something that I can do?

0.14.6 is released.

Thanks!


Feature Request: Enforce mandatory sections

When app starts, only title-and-description section slug is selected.


constant torque with regularization around zero

Reported by ahaumer on 4 Nov 2015 18:35 UTC
Modelica.Mechanics.Rotational.Sources.ConstantTorque provides only torque in one direction. If you want to change torque direction when speed goes through zero, you have to introduce the same boolean parameter TorqueDirection as in Modelica.Mechanics.Rotational.Sources.LinearSpeedDependentTorque and Modelica.Mechanics.Rotational.Sources.uadraticSpeedDependentTorque. Additionally, in case TorqueDirection = false, you have to provide a regularization (i.e. linear speed dependent torque) below a minimum speed.
Setting TorqueDirection = true by default, the enhancement is backwards compatible.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1818

Comment by ahaumer on 4 Nov 2015 18:37 UTC
implemented enhancement by 7d563d75eac62c0242dbed336fc0ad0ee8320088

Modified by beutlich on 4 Nov 2015 21:58 UTC

Changelog modified by beutlich on 4 Nov 2015 21:58 UTC
Added optional direction dependency on angular velocity to Modelica.Mechanics.Rotational.Sources.ConstantTorque

Comment by dietmarw on 6 Nov 2015 08:50 UTC
Sorry I think I'm confused by the naming and meaning of TorqueDirection. Could you clarify:

TorqueDirection = false: Now torque suddenly has a direction which is totally counter-intuitive to the variable name and in addition the ConstantTorque block no longer provides a constant torque but a variable one?

TorqueDirection = true: Torque is now direction independent.

If I understood this correctly then please remove that option again in order to not break the essential funtionality of this block but rather provide a new one that is not called Constant... that provides that functionality.

Modified by dietmarw on 6 Nov 2015 09:05 UTC

Changelog removed by dietmarw on 6 Nov 2015 09:05 UTC

Modified by dietmarw on 6 Nov 2015 09:06 UTC

Modified by dietmarw on 6 Nov 2015 09:07 UTC

Comment by ahaumer on 7 Nov 2015 14:53 UTC
The usage of parameter TorqueDirection is completely the same as in LinearSpeedDependentTorque and QuadraticSpeedDependentTorque (since a rather long time):
  parameter Boolean TorqueDirection=true
    "Same direction of torque in both directions of rotation";

Rather easy to understand, this means the direction of torque does NOT depend on the direction of rotation in case TorqueDirection=true.
The ConstantTorque with default TorqueDirection=true is fully backwards compatible.
Setting TorqueDirection=false is a nice enhancement, having in both directions of rotation the same sign of power (driving or braking).
If we're going to change this, we should change LinearSpeedDependentTorque and QuadraticSpeedDependentTorque, too, which we can't to keep backwards compatibility.

Comment by dietmarw on 8 Nov 2015 01:23 UTC
Replying to [comment:7 ahaumer]:

The usage of parameter TorqueDirection is completely the same as in LinearSpeedDependentTorque and QuadraticSpeedDependentTorque (since a rather long time):

Just because it's been there for a long time does not automatically mean it was a good design and should be adapted also for newer models in the same way.

  parameter Boolean TorqueDirection=true
    "Same direction of torque in both directions of rotation";

Rather easy to understand, this means the direction of torque does NOT depend on the direction of rotation in case TorqueDirection=true.

So TorqueDirection = true means the torque has no direction, agreed?

The ConstantTorque with default TorqueDirection=true is fully backwards compatible.
Setting TorqueDirection=false is a nice enhancement, having in both directions of rotation the same sign of power (driving or braking).
If we're going to change this, we should change LinearSpeedDependentTorque and QuadraticSpeedDependentTorque, too, which we can't to keep backwards compatibility.

The major problem is that you introduced a functionality to a component that conflicts with the very nature of that component, it's called ConstantTorque. I don't mean that the functionality is a bad thing in general just not in a component with that name. So better add a new component with that feature and leave the old one as it is.

Comment by ahaumer on 9 Nov 2015 09:07 UTC
Maybe the choice for the parameter naming in LinearSpeedDependentTorque and QuadraticSpeedDependentTorque is not perfect, but it is a good idea to have a homogenous naming for parameters of similar components and change the nameing later (when a conversions cript is used).
The "nature of the component" is not completely clear:
"Constant" means the same direction of torque (i.e. accelerating / decelerating in different directions of rotation) or the same energy / power direction ((i.e. accelerating or decelerating in both directions). Both is useful, and the enhancement is backwards compatible. If you don't want to use the new functionality, just ignore the new parameter ...

Comment by dietmarw on 9 Nov 2015 09:58 UTC
The issue is that if one wants the new implemented feature of a speed-dependent torque one would not look for it in the ConstantTorque component. It also would be nice to hear what the library officer responsible for rotational has to say about this.

Comment by hansolsson on 9 Nov 2015 16:26 UTC
I agree with Dietmar's concern - and noticed that the description says "Constant torque, not dependent on speed".
A ConstantTorque model that changes direction of torque depending on speed is problematic to me:

If the parameter 'TorqueDirection' is not evaluated this may lead to unexpected system of equations in existing models.
I don't know the physical background and I fear that some will use this as a cheap friction element - which seems plausible, but doesn't work.
It requires a new regularization parameter.

Comment by ahaumer on 9 Nov 2015 17:01 UTC
You didn't get my point: What does "not dependent on speed" mean?
a) torque -x Nm, i.e. in positive direction of rotation braking, in negative direction of rotation driving, sign of torque doesn't change.
b) torque x Nm, braking in both directions of rotation, ie. sign on torque changes when reversing the rotation. In that case you need a regularization around zero speed.
Up to now we had a), but b) is what I want to have in many cases as a load for drives.
Try to load a drive with "constant torque" and brake the drive to zero speed: in case a) the drive accelerates in opposite direction after going through zero speed.
What's the problem with having both alternatives in one component?

Comment by dietmarw on 9 Nov 2015 17:57 UTC
Toni, I perfectly understand the application and use(fulness) of this. However if you have a simple component that is called ConstantTorque then that's what it should do. If you want to add your functionality then it is better to have a different component that you might call, e.g., BrakingTorque that changes direction automatically and does exactly what you describe and it is clear by the name that this is what it does. I.e., the user will at once know what to expect from a braking torque and from a constant torque respectively.
In general "overloading" components with special functionalities that are also hidden in components (with conflicting names in addition) does not help usability. It really is just like in the proven Unix philisophy: The Unix philosophy emphasizes building short, simple, clear, modular, and extensible code that can be easily maintained and repurposed by developers other than its creators.

Comment by hansolsson on 10 Nov 2015 08:52 UTC
Replying to [comment:13 dietmarw]:

Toni, I perfectly understand the application and use(fulness) of this. However if you have a simple component that is called ConstantTorque then that's what it should do. If you want to add your functionality then it is better to have a different component that you might call, e.g., BrakingTorque that changes direction automatically and does exactly what you describe and it is clear by the name that this is what it does. I.e., the user will at once know what to expect from a braking torque and from a constant torque respectively.

And my earlier point is that we already have it called: 'BearingFriction' (as far as I understand). The worst case would be that 'BearingFriction' is considered too complicated and therefore we extend ConstantTorque with similar functionality...
However, this also got me worried about TorqueDirection in LinearSpeedDependentTorque.

Comment by otter on 10 Nov 2015 09:29 UTC
The component with torqueDirection=false is a component that models a brake with an approximate Coulomb-friction model where the stuck phase is approximated by a steep torque characteristic and the sliding friction torque is a constant (instead of being speed dependent). Such approximations are sometimes needed, e.g., when using inverse models of friction components. At DLR we also use such approximations, but typically use an exponential approximation so that the characteristic is differentiable (as needed for inverse models):
tau = 2*tau_constant/(1 + exp(-w*0.01/w_min)) - tau_constant;

The above approximation has |tau| = 0.99*|tau_constant| at w=w_min. Other people use an atan(..) approximation instead of using the exponential.
So, I agree that in principal the model from Toni is useful (and in fact, all friction components in the Rotational library should be extended so that with a flag it is possible to switch to an approximate model without stuck phase where the friction characteristic is strict monotonically increasing and is differentiable (so the characteristic is invertible).
However, the model as it is now, cannot be inverted and therefore cannot be used in inverse models. This could be fixed by using the above alternative approximation. This approximation has still the issues that (a) I have not yet seen such friction characteristics (typically friction becomes larger with larger speed) and (b) it will be hard for a numerical solver to invert it due to the very flat characteristic of the approximation above.
So I would propose the following:

either describe the use case of your approximation in the documentation (but if you just want to model a "real" brake, then I would find it much better to use Components.Brake, which is a good model for a "real" brake),
or do not include the TorqueDirection parameter.

Note, if the brake model shall be used in an inverse model, then the following approximation would be better, where the speed-dependency of the sliding friction torque allows a reasonable numerical inversion:
tau = d*w + 2*tau_constant/(1 + exp(-w*0.01/w_min)) - tau_constant;

where "d" is the damping constant and describes the speed dependency
(for w>w_min, tau = tau_constant + d*w)

Comment by ahaumer on 15 Nov 2015 10:40 UTC
Ok. I reverted ConstantTorque back to the original version with additonal remarks in the Info, and designed "SignTorque" with constant torque which changes sign with the direction of rotation. The regularization around zero is smooth and differentiable once. It is not intended to be used as a friction, but in many cases you want to test an electric drive in both directions of rotation as a motor, i.e. the idealized load torque is constant with different sign dependent on direction of rotation.
Resolved by c1501c0660a44ac924bd9f24bb3cadf8705aca42

Modified by beutlich on 15 Nov 2015 20:20 UTC

Changelog modified by beutlich on 15 Nov 2015 20:20 UTC
Added new models Modelica.Mechanics.Rotational.Sources.SignTorque and Modelica.Mechanics.Translational.Sources.SignForce; Added new variable Modelica.Mechanics.Rotational.Sources.ConstantTorque.w

Comment by dietmarw on 16 Nov 2015 07:55 UTC
Thanks. Two things though.

Ideally if you revert you should really revert to the original by doing svn svn merge -c -REV . (TortoiseSVN has a menu for this too I believe) and not manually adding new changes that kind of resemble the original state but really do not.

I guess 922e1bf75ae7b7fe40ccf31bd3b1b015c6974e00 to c5840233661a64987084dcb712876e680ccf7d7d are probably related to this ticket but don't have any commit message. **NEVER EVER COMMIT WITHOUT COMMIT MESSAGE!!! **. 213e2d4f04276b926e17185a2a438aa392520dd7 and 9ad29ad5ec01e3087f53aee27c3c185ac8e67017 are also lacking the reference to this ticket. This makes it really hard to later find out why certain changes were done or elements were added. There should always be a ticket that links/justifies a commit.

Comment by anonymous on 16 Nov 2015 18:26 UTC
Why is ModelicaTest.Rotational.AllComponents not updated if a new component SignTorque was added to Rotational? Also ModelicaTest.Translational should reflect the new component SignForce.

Comment by beutlich on 17 Nov 2015 10:22 UTC
Replying to [comment:19 anonymous]:

Why is ModelicaTest.Rotational.AllComponents not updated if a new component SignTorque was added to Rotational? Also ModelicaTest.Translational should reflect the new component SignForce.

Reopen for the sake of missing test cases in ModelicaTest.

Changelog removed by beutlich on 17 Nov 2015 10:22 UTC

Comment by ahaumer on 19 Nov 2015 10:11 UTC
resolved by 5c7062e14c28b7e9096aca53c2b233b96dd51ee5:Added test cases for SignTorque and SignForce to ModelicaTest

Modified by beutlich on 19 Nov 2015 14:47 UTC

Changelog modified by beutlich on 19 Nov 2015 14:47 UTC
Added new models Modelica.Mechanics.Rotational.Sources.SignTorque and Modelica.Mechanics.Translational.Sources.SignForce; Added new variable Modelica.Mechanics.Rotational.Sources.ConstantTorque.w

Comment by hansolsson on 19 Nov 2015 15:00 UTC
Just wondering, I thought the changes of ConstantTorque were reverted, so what was the reason for the following:
Added new variable Modelica.Mechanics.Rotational.Sources.ConstantTorque.w

Comment by beutlich on 19 Nov 2015 15:09 UTC
Replying to [comment:23 hansolsson]:

Just wondering, I thought the changes of ConstantTorque were reverted, so what was the reason for the following:
Added new variable Modelica.Mechanics.Rotational.Sources.ConstantTorque.w

Variable w was added by Toni. I guess it was by design since the other torque sources also have w as variable present. But actually w is not needed.


Readme edits

The README looks pretty good, but there are a couple of issues in the "Configured Variables" table:

Footnote (5) tells users to enter integer values only, not units like "px" or "vw". But every single corresponding "default" value has explicit units shown, and there is no indication of what units will be applied to the naked integer.
What you have now is likely to lead to needless confusion and frustration. If the user cannot select units, then the default values in this table shouldn't show them, and the description should name the (de facto required) unit explicitly.  But if the user cannot select units, then there shouldn't be any units in the config.js file, either - you're basically instructing users to remove the units that are already in there!  If what  you mean is "Do not change the units that are in config.js", then say that - but expect users to change them anyway.

The "placement -offset" line shows a value range of "[0,95)" [sic].  The use of an opening bracket with a closing parenthesis looks like a typo; if it isn't one it needs to be explained.

The set of values itself is also somewhat mysterious. I don't see why "0" would be an allowed value on one extreme, but "100" is not allowed on the other.  It's also not immediately clear to me why the unit is "vh" regardless of whether the widget is placed top/bottom or left/right. Perhaps it is clear to CSS programmers?

This table does not follow the order or the syntax in the config.js file, and it's not sorted in alphabetical order, either.  If the table were any longer it would be kind of annoying to have to scroll back and forth looking for things.  Still, one order or the other should be applied.

The structure of the "followUpLinks" section is more complex than what is in the table.That's not a major issue for people who know JSON, but that does not necessarily describe people who would be tasked with implementing this widget.
On the whole, I'd re-order the table to match config.js, and I would expand the content of the "followUpLinks" line the same way as has been done for "size" and "placement".  Then I'd expand the description to include a) what in the JSON structure can be changed ("url" only? "title"?);  and b) to remove the implication that anything in there should be a multivalued list of URLs - unless that is actually valid.

Addressed and released in https://github.com/NASA-PDS-Incubator/feedback-widget/releases/tag/v1.1.1


Update for CUDA 12.4.0

xref: https://github.com/conda-forge/cuda-feedstock/issues/17

@conda-forge-admin, please restart ci

@conda-forge-admin , please re-render

Looks like we were missing cuda-nvprune builds
Started new builds: https://github.com/conda-forge/cuda-nvprune-feedstock/pull/5#issuecomment-1981814235

@conda-forge-admin, please restart CI


Add Initial OAuth to Kabanero Console

We need some sort of GitHub OAuth connected to the console application to do collection based events for the users.
A lot more discussion in child issue #65 on options for the initial pass

Implemented in kabanero-io/kabanero-landing/pull/114


Provide msi - installer

Would you be willing to provide an msi-based installer? I'd love to install asn1editor as a winget package, but this only works with msi installern, not with zip-files.

I have no plans to wrap into MSI installer, unfortunately.

Would you accept a Pull Request if I'd create an installer project?

Probably yes if I will be able to maintain it. I have an experience only with Advanced Installer product.


How to automatically generate the ceps codebook?

I changed the sample rate from 16k to 32k and modify the NB_BANDS, but I wonder how to generate the ceps codebook?

I changed the sample rate from 16k to 32k and modify the NB_BANDS, but I wonder how to generate the ceps codebook?

Bro, have you solved this problem? I am also converting the sampling rate to be processed and I want to switch to 8KHz


Feat: make k8s friendly

Remove WebApp for health check
introduce packages for testing Redis and Kernel (redis-server and curl)

@obdulia-losantos well spotted, thanks


Automated cherry pick of #8686: feat(region): add option NoCheckOsTypeForCachedImage

Cherry pick of #8686 on release/3.5.
#8686: feat(region): add option NoCheckOsTypeForCachedImage

Codecov Report

Merging #8687 into release/3.5 will increase coverage by 11.95%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/3.5    #8687       +/-   ##
================================================
+ Coverage         6.03%   17.99%   +11.95%
================================================
  Files              795       84      -711
  Lines           124282     8853   -115429
================================================
- Hits              7503     1593     -5910
+ Misses          116114     7091   -109023
+ Partials           665      169      -496

Flag
Coverage Δ

aFlag
17.99% <ø> (+11.95%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/compute/models/loadbalanceragents.go

pkg/compute/models/networks.go

pkg/mcclient/options/k8s/statefulset.go

pkg/compute/models/dbinstanceresource.go

pkg/compute/models/dbinstance_parameters.go

pkg/compute/models/dns_zones.go

pkg/cloudprovider/cloudprovider.go

pkg/baremetal/utils/ipmitool/ipmitool.go

pkg/keystone/models/regionresource.go

pkg/httperrors/consts.go

... and 693 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ffdb26...37c3da9. Read the comment docs.

/lgtm
/approve


Issue

When I go on Hypixel and try to play Skyblock with this mod in 1.16.4 latest version it lets me go on Hypixel but when I try and play Skyblock it will crash I have SteveKungLib on to latest version I just crash when I try to play can you please fix it?

Do not update SteveKunG's Lib, stay on 4.0.1.

Do not update SteveKunG's Lib, stay on 4.0.1.

well it should work with PR #61

well it should work with PR #61

thx
On Fri, 22 Jan 2021 at 06:20, remplerus<EMAIL_ADDRESS>wrote:

well it should work with PR #61
https://github.com/SteveKunG/SkyBlockcatia/pull/61
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SteveKunG/SkyBlockcatia/issues/59#issuecomment-765333602,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASPLVVF2NAYSBRFSIMYIN53S3FNP3ANCNFSM4WESBH5Q
.


why show this type error on console?

Its saying that the node module doesnt exits in the node modules once again try to install the module

It might've been a legitimate bug but I can't reproduce it anymore. Would you try updating the version?


Patched hide and restore windows

Implement #9
Now you can use <MOD>+e and <MOD>+<SHIFT>+e to hide and restore windows.

That's how it looks like:
https://user-images.githubusercontent.com/30021675/128114158-07e59b67-d7da-4e87-9865-2b0760fdcfaa.mp4

whoa! whats the compositor?

I'll keep this on hold until this gets resolved .
https://github.com/siduck76/chadwm/issues/6#issuecomment-891997192

whoa! whats the compositor?

I am using jonaburg/picom
And my picom configuration is here


Enable new link styles

A new option in GOV.UK Frontend v3.12.0, that will be become the default in the next major version.
Do we want to enable these?

Enabled in #512 instead.


Multiselect option is not updating

I dynamically added options in multiselect but mutliselect just has initial list items.
how can I refresh mutliselect with new options.

Will this work without a postback?  How will it know to take another look if I have added more options to the database?
Thanks,
Mark

I'm afraid this doesn't work with the latest version anymore. I've just tried to implement this however there's no new option added. Also this solution doesn't work: https://github.com/michael/multiselect/issues/16#issuecomment-1032270
Anybody has a working example?

Yes, yes, yes! Thank you carlos1001.  This works GREAT! I cant tell you how pleased I am that you have took the time to provide this solution. Many Thanks!


Reviews Sections..

Title and Issue number
Title : Review Section
Issue No. : 401
Close #401
Video (mandatory)
https://github.com/user-attachments/assets/fdae5c23-fccf-441d-a3b5-b52ea539c6ff
Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md if its a new page/tech stack
[x] I have gone through the  contributing.md file before contributing

Additional context
added reviews section..
Are you contributing under any Open-source programme?

[x] I'm a GSSOC-EXT contributor
[x] I'm a HACKTOBERFEST contributor

@jeevan10017 Please review PR...

@jeevan10017 Review PR

no need of it, existing one is good.

@jeevan10017 there should be review section.. from that customer can get better ideas..

@jeevan10017 if you want then i can make design better of it


Crash on the demo-app when switching between Zxing / Zbar

When quickly switching between Zxing / Zbar reader mode on scanner camera preview, a null pointer exception may occur.
java.lang.NullPointerException: Attempt to invoke virtual method 'void com.google.zxing.MultiFormatReader.setHints(java.util.Map)' on a null object reference

Resolved by #196


Account number hardcoded

Crate
ibc-relayer
Summary of Bug
Account number is hard-coded to '0' in the logic to sign a transaction
Version
v0.1.1
Steps to Reproduce
When using a key for an account that is not '0' the tx raw transaction will not work. For example testing with a chain where the key was for an account with number '1' the tx failed with unauthorized.
Change the logic to use the account number retrieved from the chain.

For Admin Use

[X] Not duplicate issue
[X] Appropriate labels applied
[X] Appropriate milestone (priority) applied
[X] Appropriate contributors tagged
[x] Contributor assigned/self-assigned

@andynog Can you please open a PR for your fix if it's ready?

@andynog Can you please open a PR for your fix if it's ready?

Hi @romac this was fixed on PR #753, not sure why the issue was not closed

Oh right, will close it then :)


compute() changes a dataframe column dtype from uint64 to float64

What happened:
I created 2 pandas dataframes with a single cell each (containing a UUID), and saved them to disk.
I then created a dask dataframe from these 2 pandas dataframes using read_csv(...) + added a second column (uuid_0) derived from the first one (uuid).
The dtype of column uuid_0 is uint64 before calling ddf.compute()... and float64 after:
Dask dtypes before compute:
uuid      object
uuid_0    uint64
dtype: object

Pandas dtypes after compute:
uuid       object
uuid_0    float64
dtype: object

What you expected to happen:
I expected the dtype of column uuid_0 to be uint64 both before and after ddf.compute().
Minimal Complete Verifiable Example:
# imports
import glob
import dask
import dask.dataframe as dd
import pandas as pd

from dask.distributed import Client
client = Client(n_workers=1, memory_limit='1GB')

# save 2 pandas dataframes to disk
df1 = pd.DataFrame(
    [
        ["873ba3b6983a40e89f0a97cad14f7c05"],
    ],
    columns=["uuid"]
)
df1.to_csv("df1.csv")

df2 = pd.DataFrame(
    [
        ["2a09e98e7cec4d40ab52cd52e0aea266"]
    ],
    columns=["uuid"]
)
df2.to_csv("df2.csv")

# read CSVs into dask dataframe
ddf = dd.read_csv(sorted(glob.glob(f"df*.csv")),
                  skiprows=1,
                  names=['uuid'])

# create a second column derived from 'uuid'
ddf["uuid_0"] = ddf["uuid"].str.slice(stop=16).apply(func=int, base=16, meta=("uuid_0", "uint64"))

# check dtypes
print(f"Dask dtypes before compute:\n{ddf.dtypes}\n")
df = ddf.compute()
print(f"Pandas dtypes after compute:\n{df.dtypes}")

Anything else we need to know?:
Because my unsigned integers are large, I loose numerical precision during the uint->float conversion ;(
Environment:

Dask version: 2.30.0
Python version: 3.8.6
Operating System: Linux (FROM python:3.8.6-buster in Dockerfile)
Install method (conda, pip, source): poetry

n.b. I ran the above snippet in a jupyter notebook.

@chrish42 ^^

With your example, I tried just calling apply on the pandas dataframes. The first one produced a uint as expected, but the second one didn't:
df2.uuid.str.slice(stop=16).apply(int, base=16)

gives:
0<PHONE_NUMBER>573858112
Name: uuid, dtype: int64

I think this is the root of the issue, because when the partition dataframes are concatenated if the dtypes don't match they are upcast. I am not sure if this is a pandas bug or expected behavior. As a workaround I would suggest adding in an astype
ddf["uuid_0"] = ddf["uuid"].str.slice(stop=16).apply(int, base=16, meta=("uuid_0", "uint64")).astype("uint")

Thanks @jsignell for the quick investigation and workaround suggestion, it also worked on my side for the code snippet above... I'll give it a try on my real data set.
I didn't think about adding an astype, assuming the meta arg passed to dask.apply was essentially doing the same thing (and more)... clearly I was wrong!

As far as I understand, setting meta like that sets the expectation for the output, but doesn't do any work to coerce the output to that.

Nice catch & thank you @jsignell. Totally didn't think of looking for signed vs. unsigned when I was shown this. Hopefully when Pandas has good, solid NA support, these kinds of implicit lossy conversions can be disabled. They certainly are a source of bugs and problems. I'm assuming that's still further down the road, though. Right?
@dtourillon Does that solve this problem on your real dataset?
In the meantime, what do we do with this issue? Can we do something in the meantime to surface those potential problems a bit more? A warning? Or would that be too disruptive? If that's the case, I guess we can simply close this.

Nice catch & thank you @jsignell. Totally didn't think of looking for signed vs. unsigned when I was shown this. Hopefully when Pandas has good, solid NA support, these kinds of implicit lossy conversions can be disabled. They certainly are a source of bugs and problems. I'm assuming that's still further down the road, though. Right?
@dtourillon Does that solve this problem on your real dataset?
In the meantime, what do we do with this issue? Can we do something in the meantime to surface those potential problems a bit more? A warning? Or would that be too disruptive? If that's the case, I guess we can simply close this.

@dtourillon Does that solve this problem on your real dataset?

Yes it does, thanks to @jsignell 's suggestion.
I am therefore ok closing this issue... but will leave it to someone more experienced in dask to decide if we should close as is or add a warning as suggested by @chrish42 .

@dtourillon Does that solve this problem on your real dataset?

Yes it does, thanks to @jsignell 's suggestion.
I am therefore ok closing this issue... but will leave it to someone more experienced in dask to decide if we should close as is or add a warning as suggested by @chrish42 .

My inclination is to close. Unless someone has a clear idea of where such a warning would go

My inclination is to close. Unless someone has a clear idea of where such a warning would go


Authorization Keys for Projects

TheThingsNetwork integrations will POST data to Sensetif, so we need to allow for a Authorization Key to be generated on Sensetif side, to be entered in TheThingsNetwork's webhooks. This should be per Project to allow a great deal of flexibility.

I think the "API Keys" in Grafana can be used for this and nothing additional is required.


Adding C# FaceLocator template using Computer Vision Api

@fabiocav  can you take a look at this PR?

Addresses #217

Want to use this PR as the forcing function for a new "Samples" category? Then we add this new sample to that category, as well as the following existing templates:
GitHubCommenter-CSharp
HttpGET(CRUD)-CSharp
HttpGET(CRUD)-NodeJS
HttpPOST(CRUD)-CSharp
HttpPOST(CRUD)-NodeJS
ImageResizer-CSharp

updated as per comments


Can't select hour between 1 to 10.

I think it can illustrate the issue well.
https://jsfiddle.net/w8nuL9fz/1/

@chmln if it helps, this issue started appearing in 2.2.5 (2.2.4 worked fine).

This issue applies to single digits (1-9). 10AM works fine.
So the regex to validate time must not be accounting for single-digit hours.

Resolved by  fa3e3f4
Check the docs for the updated version.
I've also added a unit test for this behavior https://github.com/chmln/flatpickr/blob/d237c39782ec2d4cca4050c0c2ab69d5a627e3cb/test/flatpickr.spec.js#L465-L468
Thanks for reporting the issue :+1:


Set accept null

Since keys of Maps can now be null, it enables the same rule with the Sets

+1

+1

+1


chore(deps): upgrade Apache Jena Fuseki docker image to v2.0.9 (DEV-1299)

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix: represents bug fixes
[ ] Refactor: represents production code refactoring
[ ] Feature: represents a new feature
[ ] Documentation: documentation changes (no production code change)
[x] Chore: maintenance tasks (no production code change)
[ ] Style: styles updates (no production code change)
[ ] Test: all about tests: adding, refactoring tests (no production code change)
[ ] Other... Please describe:

Issue Number: DEV-1299
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Does this PR change client-test-data?

[ ] Yes (don't forget to update the JS-LIB team about the change)
[x] No

Other information

Resolved by #2362


trinucleotideMatrix error: Error in .Call2("solve_user_SEW", refwidths, start, end, width, translate.negative.coord

Describe the issue
When using  maftools trinucleotideMatrix function, I got an error in "Extracting +/- 20bp around mutated bases for background C>T estimation", hg19 contigs were used and I checked to see if there's aberrant chromosomes like chrUn it show none. Also I've updated maftools to latest release and it didn't work. I really have no idea what has happened.
Command
> laml.t.tnm = trinucleotideMatrix(maf = maf_t, prefix = 'chr', add = TRUE, ref_genome = "BSgenome.Hsapiens.UCSC.hg19")
-Extracting 5' and 3' adjacent bases
-Extracting +/- 20bp around mutated bases for background C>T estimation
Error in .Call2("solve_user_SEW", refwidths, start, end, width, translate.negative.coord,  :
  solving row 57: the supplied start/end lead to a negative width
> head (maf_t@data)
   Hugo_Symbol Entrez_Gene_Id Center Build Chromosome Start_Position End_Position Strand        Variant_Classification Variant_Type Reference_Allele Tumor_Seq_Allele1 Tumor_Seq_Allele2
1:      TAS1R1             NA     NA  hg19          1        6639396      6639396     NA            frameshift_variant          DEL                A                 A                 -
2:       PHF13             NA     NA  hg19          1        6676837      6676837     NA              missense_variant          SNP                G                 G                 C
3:     TNFRSF8             NA     NA  hg19          1       12198365     12198370     NA conservative_inframe_deletion          DEL           GCCACA            GCCACA                 -
4:        PAX7             NA     NA  hg19          1       19027162     19027162     NA              missense_variant          SNP                C                 C                 T
5:       WASF2             NA     NA  hg19          1       27744803     27744811     NA   disruptive_inframe_deletion          DEL        GTATCACAG         GTATCACAG                 -
6:      ADGRB2             NA     NA  hg19          1       32221968     32221968     NA              missense_variant          SNP                A                 A                 T
                                                                                Tumor_Sample_Barcode     Protein_Change i_TumorVAF_WU i_transcript_name tumorDP germlineDP
1: /snpeff/TDNe-115-XLZE7T-1-T2_FKDL210181767-1a-N503-N503_H3V5HDSX2_L4_output-tnhaplotyper2_eff         p.Lys760fs        0.3290       NM_138697.4     108         87
2:/snpeff/TDNe-115-XLZE7T-1-T2_FKDL210181767-1a-N503-N503_H3V5HDSX2_L4_output-tnhaplotyper2_eff         p.Lys20Asn        0.1570       NM_153812.3      46         38
3: /snpeff/TDNe-115-XLZE7T-1-T2_FKDL210181767-1a-N503-N503_H3V5HDSX2_L4_output-tnhaplotyper2_eff p.His473_Ser474del        0.0741       NM_001243.5      45         29
4: /snpeff/TDNe-115-XLZE7T-1-T2_FKDL210181767-1a-N503-N503_H3V5HDSX2_L4_output-tnhaplotyper2_eff        p.Arg268Cys        0.2310       NM_002584.3      42         32
5: /snpeff/TDNe-115-XLZE7T-1-T2_FKDL210181767-1a-N503-N503_H3V5HDSX2_L4_output-tnhaplotyper2_eff p.Cys127_Thr129del        0.0980       NM_006990.5      27         25
6:/snpeff/TDNe-115-XLZE7T-1-T2_FKDL210181767-1a-N503-N503_H3V5HDSX2_L4_output-tnhaplotyper2_eff        p.Phe157Tyr        0.3190    NM_001364857.1      80         58

<EMAIL_ADDRESS>
   1   10   11   12   13   14   15   16   17   18   19    2   20   21   22    3    4    5    6    7    8    9    X    Y
2136  660 1088  911  214  556<PHONE_NUMBER>  221 1767 1272  583  212  509  828  424  655  598  845  710  938  648    1

Session info
Run sessionInfo() and post the output below

> sessionInfo() R version 3.6.3 (2020-02-29) Platform: x86_64-pc-linux-gnu (64-bit) Running under: CentOS Linux 7 (Core)  Matrix products: default BLAS:   /home/public/R/lib64/R/lib/libRblas.so LAPACK: /home/public/R/lib64/R/lib/libRlapack.so  locale:  [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C               LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8     LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8    LC_PAPER=en_US.UTF-8        [8] LC_NAME=C                  LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C         attached base packages: [1] stats4    parallel  stats     graphics  grDevices utils     datasets  methods   base       other attached packages:  [1] BSgenome.Hsapiens.UCSC.hg19_1.4.0 BSgenome_1.54.0                   rtracklayer_1.46.0                Biostrings_2.54.0                 XVector_0.26.0                    GenomicRanges_1.38.0               [7] GenomeInfoDb_1.22.1               IRanges_2.20.2                    S4Vectors_0.24.4                  maftools_2.8.05                   QDNAseq_1.22.0                    CGHbase_1.46.0                    [13] marray_1.64.0                     limma_3.42.2                      Biobase_2.46.0                    BiocGenerics_0.32.0                loaded via a namespace (and not attached):  [1] compiler_3.6.3              RColorBrewer_1.1-2          R.methodsS3_1.8.1           bitops_1.0-7                R.utils_2.10.1              tools_3.6.3                 zlibbioc_1.32.0              [8] digest_0.6.27               lattice_0.20-38             rlang_0.4.10                Matrix_1.2-18               DelayedArray_0.12.3         cli_3.0.1                   GenomeInfoDbData_1.2.2      [15] globals_0.14.0              grid_3.6.3                  data.table_1.14.0           impute_1.60.0               listenv_0.8.0               future.apply_1.8.1          DNAcopy_1.60.0              [22] parallelly_1.27.0           XML_3.99-0.3                survival_3.1-8              CGHcall_2.48.0              BiocParallel_1.20.1         GenomicAlignments_1.22.1    splines_3.6.3               [29] Rsamtools_2.2.3             codetools_0.2-16            matrixStats_0.58.0          SummarizedExperiment_1.16.1 future_1.21.0               RCurl_1.98-1.4              R.oo_1.24.0
--

> | >
>

Maftools only use normal chromosomes.

Right, I mean normal chromosomes exactly. I tabled maf.silent[["Chromosome”]] like other issues posted before and there’s no contigs like chrUn, only had chr 1-22, X and Y. But still got this error. Why did it happen?

2021年8月31日 上午11:22，Shixiang Wang @.***> 写道：
Maftools only uses normal chromosomes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/PoisonAlien/maftools/issues/764#issuecomment-908866718, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6ADXY2CZBG2QWGRKNZ673T7RDINANCNFSM5DDE4MOA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

The error is
solving row 57: the supplied start/end lead to a negative width

There are two causes:

End position in your input data is < Start position
Upstream and downstream of mutated base has exceeded the valid reference genome region as the program stop at Extracting +/- 20bp around mutated bases for background C>T estimation.

Could you check the causes or provide a minimal reproducible dataset for debugging?

Also, would it be possible to provide a reproducible example?

Here’s the reproducible example maf file. I didn’t inspect any abnormal thing with row 57.

2021年8月31日 下午1:53，Anand Mayakonda @.***> 写道：
Also, would it be possible to provide a reproducible example?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/PoisonAlien/maftools/issues/764#issuecomment-908921424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6ADX76524ROKPOJL6UG3DT7RU5FANCNFSM5DDE4MOA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi @xxzzwan
I think you forgot the attachment.

I've attached the maf by email. Could you find that?

TDNe-115-XLZE7T-1-T2_eff.txt

Hi,
Could you please post your import read.maf command? The values in Variant_Classification are what seems to be from VEP?

I used SnpEff to annotate called variants and use perl script to convert vcf into maf.
>syn <- c("synonymous_variant","start_retained","stop_retained_variant")
>a<- data.table::fread("mymaf")
>vc <- names(table(a$Variant_Classification))
>nonSyn <- setdiff(vc,syn)
>b<-read.maf("mymaf", vc_nonSyn = nonSyn)

Is it a SnpEff-specific problem? Should I use ANNOVAR or VEP instead?

It should be fine.
But still, I would recommend vcf2maf (which internally uses VEP). It will take care of MAF conversion and transcript prioritization.

Thank you so much! I see what's wrong now. Thank you so much! I think this issue can be closed!


Add unit testing

Firstly, this builds termix as a shared library, which allows the test executables to be linked and run on their own. I have also added a small test runner script which runs all the tests and displays stdout from any failing tests and sets the exit code accordingly. You can compile and run the tests with make test.

Please make distiction between debug/test build and working build. Add target for release which will compile termix as normal application without -fPIC and for test which builds with test coverage and debug symbols.

Will do - but what do you mean "builds with test coverage"? Do you mean including the test target as part of the default (all) target?

Now you can build in release mode by doing NDEBUG=1 make.

That'll do, I guess. Changes are pretty massive, so I'll accept it as is for now.


Debugger should show unescaped strings

VSCode Version: 1.9.0
OS Version: Ubuntu 16.04

Steps to Reproduce:

Create a new .net core project with dotnet new
Specify the following main function:

        public static void Main(string[] args)
        {
            var test = @"{""Test"": 123}";
            Console.WriteLine(test);
        }

Put a break point on the last ending brace of the function
Debug

----> Observe the variables and watch window shows the value of the string as "{\"Test\": 123}" when it should show the unescaped value of {"Test": 123}.
This is important because I"m in the process of writing an application to read and write structured (json) logs and trying to verify some things with the debugger, and it's adding extra steps to verifying the json being output (since I have to manually unescape it in order to pretty print it for verification)
I have no idea if this is C# or VSCode specific.

This is coming from the C# extension, so please file the issue here https://github.com/OmniSharp/omnisharp-vscode

Will do thanks!


Added support for upcasting to multiple events

Can you apply your PR to the 1.2 branch?

Can you update the changelog like: https://github.com/treehouselabs/event-store/pull/6/commits/d65bd27cf2401a507ea7ad6779463314991303ae


PPM migrate selectors [delivers #165805309]

Description
Migrate getEstimatedRemainingWeight, getActualRemainingWeight selectors to the ppm entity file.
Code Review Verification Steps

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change

Closing PR for now until we pick up the story again.


link phone number

Hello,
I have a mistake when the crawler check link tag with a phone number inside : phone contact
[21:15:28] [CRITICAL] Internal error: No connection adapters were found for 'tel:0800006272' Traceback (most recent call last):   File "PwnXSS-master/pwnxss.py", line 73, in <module>     start()   File "PwnXSS-master/pwnxss.py", line 54, in start     crawler.crawl(getopt.u,int(getopt.depth),getopt.proxy,getopt.user_agent,check(getopt),getopt.method,getopt.cookie)   File "PwnXSS-master/lib/crawler/crawler.py", line 50, in crawl     self.crawl(url,depth-1,base,proxy,level,method,cookie)   File "PwnXSS-master/lib/crawler/crawler.py", line 50, in crawl     self.crawl(url,depth-1,base,proxy,level,method,cookie)   File "PwnXSS-master/lib/crawler/crawler.py", line 42, in crawl     urls=self.getLinks(base,proxy,headers,cookie)   File "PwnXSS-master/lib/crawler/crawler.py", line 19, in getLinks     text=conn.get(base).text   File "/usr/local/lib/python3.9/site-packages/requests/sessions.py", line 555, in get     return self.request('GET', url, **kwargs)   File "/usr/local/lib/python3.9/site-packages/requests/sessions.py", line 542, in request     resp = self.send(prep, **send_kwargs)   File "/usr/local/lib/python3.9/site-packages/requests/sessions.py", line 649, in send     adapter = self.get_adapter(url=request.url)   File "/usr/local/lib/python3.9/site-packages/requests/sessions.py", line 742, in get_adapter     raise InvalidSchema("No connection adapters were found for {!r}".format(url)) requests.exceptions.InvalidSchema: No connection adapters were found for 'tel:0800006272'

fixed release wait for v.3


Create Indy Fork Sync Workflow from main repository Commonjava/indy

This is GitHub Actions Workflow for sync fork repository from main repository.
Things to know:

This should live in master branch
Environmental variables should be configured from user side with user values
In main repository this workflow should be disabled because it is sync fork repository from main repository
If there are additional env variables which should be hiden from public viewing then they should be added in "settings" under "secrets" options

Do you mean once this is merged, it will push upstream/master changes to my forked repo/master branch every midnight?

Do you mean once this is merged, it will push upstream/master changes to my forked repo/master branch every midnight?

Same question. :-)

Do you mean once this is merged, it will push upstream/master changes to my forked repo/master branch every midnight?

When it will be merged it will be shown on master branch of  commonjava/indy (here it needs to be disabled from repo settings) repo and on next your fork sync it will be shown on your user for repo (geored/indy or ruhan1/indy or ligangty/indy ... ) and from there it will start doing daily sync from main commonjava repo to your's user repositories so you don't have to do it manually anymore :)

Do you mean once this is merged, it will push upstream/master changes to my forked repo/master branch every midnight?

When it will be merged it will be shown on master branch of commonjava/indy (here it needs to be disabled from repo settings) repo and on next your fork sync it will be shown on your user for repo (geored/indy or ruhan1/indy or ligangty/indy ... ) and from there it will start doing daily sync from main commonjava repo to your's user repositories so you don't have to do it manually anymore :)

Some more questions:

Do the downstream repos need to add any permissions to enable these actions?
How to resolve conflicts if there are?

Some more questions:

Do the downstream repos need to add any permissions to enable these actions?
How to resolve conflicts if there are?

No. there no need to add any new permisions, github is watching directory .github/workflows for new actions/workflows and execute them.
Same as any other conflicts :) making PR, but in general if action cannot execute normal on your user side/your repository then you should check your own settings that you put as env. variables, but those (if you check commands in action) are just simple user config name and mail that is used for internal github logging, main env. variable is GITHUB_TOKEN which is set up automatically from GH for every user and used when you sync your repository, it's same commands that you are using localy on your comp. when you wan't to sync your fork with main commonjava repo.

Do you mean once this is merged, it will push upstream/master changes to my forked repo/master branch every midnight?

When it will be merged it will be shown on master branch of commonjava/indy (here it needs to be disabled from repo settings) repo and on next your fork sync it will be shown on your user for repo (geored/indy or ruhan1/indy or ligangty/indy ... ) and from there it will start doing daily sync from main commonjava repo to your's user repositories so you don't have to do it manually anymore :)

Some more questions:

Do the downstream repos need to add any permissions to enable these actions?
How to resolve conflicts if there are?

Damn, i press wrong button here.


Support svg

Thanks for making this plugin. When using /Embed asset file, .svg files should be treated just like .png and other image formats, but currently produce a link instead.

Please try in v1.4.1.

That works, thanks for the quick fix!


Features/weather location

Added apixu API for cities.
Using Alamofire to do the request and Realm to store them

Great work @sergiobaro.
Now re-reading through the code I think there are few little changes we could do (little if we only had refactor capabilities :( )


Add license files

Closes #60

In the absence of any disagreement, I'm going to merge this. I think licensing can be a barrier to use, and I don't want that.


Disable go to profile page for optimistic user

Details

Disable go to profile page for optimistic user
Fixed Issues

$ https://github.com/Expensify/App/issues/22691
PROPOSAL: https://github.com/Expensify/App/issues/22691#issuecomment-1631954206
Tests

Login with any account
Go offline
Create a new chat with the user that isn't a recent contact
In the report, click the header
Verify that the cursor is disabled and can not open profile page
Click on the display of the user in welcome message text
Verify that the cursor is text and can not open profile page
Create a group chat with the user that isn't a recent contact
In the report, click the header to open participant page
Click on the avatar of this user
Verify that the cursor is disable and can not open profile page
Go online and verify that the cursor is changed to pointer and can open profile page
Go to FAB > request money
Enter any amount to go to the next step
Search and select the user that isn't a recent contact
In confirm page, verify that the cursor is disabled when hovering over the avatar and can not open profile page

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Login with any account
Go offline
Create a new chat with the user that isn't a recent contact
In the report, click the header
Verify that the cursor is disabled and can not open profile page
Click on the display of the user in welcome message text
Verify that the cursor is text and can not open profile page
Create a group chat with the user that isn't a recent contact
In the report, click the header to open participant page
Click on the avatar of this user
Verify that the cursor is disable and can not open profile page
Go online and verify that the cursor is changed to pointer and can open profile page
Go to FAB > request money
Enter any amount to go to the next step
Search and select the user that isn't a recent contact
In confirm page, verify that the cursor is disabled when hovering over the avatar and can not open profile page

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screencast from 29-07-2023 14:33:57.webm

Mobile Web - Chrome
https://github.com/Expensify/App/assets/129500732/ade84102-f8f3-4bb2-8c0a-a9d925f3342e

Mobile Web - Safari
https://github.com/Expensify/App/assets/129500732/7814f174-ef89-4393-a9c5-c6c5b3b1c58e

Desktop
https://github.com/Expensify/App/assets/129500732/d5a466d2-4125-40b8-bccd-fe9981be3324

iOS

https://github.com/Expensify/App/assets/129500732/8ef66586-9b85-4330-9fe8-3dd71448b954

Android
https://github.com/Expensify/App/assets/129500732/a6255bd6-a56c-4810-aede-21793028e12c

The other thing I noticed was Disabled Mouse Cursor. @Julesssss Do we want to show disabled mouse cursor when user won't be able to go to Profile page? I think showing normal cursor instead of hand pointer should convey the message to user that the item is not pressable.

I think it's hard to display normal cursor because disable style of base components is disable cursor.

Damn, in that case lets leave it for now.

@dukenv0307 There were few issues in the request money flow. Can you please merge main and check the following issues.

Console error on pressing request money
Had to press Next button twice in request money flow

https://github.com/Expensify/App/assets/25876548/0c4cbc5f-3a1d-4c70-8174-92ebebb5921c

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.50-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

The draft is created, do we need to wait for issue created to open it or not?

I think you know this now, but yeah the PR should be created against the new bug issue. Then we can link it to this one via a comment.

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


The app wont run! Get vcard errors!

Hi I've downloaded and ran npm install. Then npm run serve. It throws errors in regard to the vuetify vcard title not found.  What is the correct way to install this?  Beside wanting to use this for personal listening use, I'm also trying to learn how to build Vue real world apps like this.
Thanks.

what vuetify version are you using?
don't update your packages, leave it as is.


What edition should 1.0 target?

The generated source in master at the moment needs nightly because the gen script is currently enabling nightly to svd2rust.
error[E0554]: #![feature] may not be used on the stable release channel
 --> /Users/jacobrosenthal/.cargo/git/checkouts/efm32-rs-8afe14a491208763/e359ec3/src/lib.rs:6:1
  |
6 | #![feature(untagged_unions)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

Seems like were a ways out on that feature https://github.com/rust-lang/rust/issues/32836
Im thinking 1.0 published should probably target stable. If you agree Ill change that.
Also cargo gen needs nightly, I think from rustfmt, but I dont think that matters. Ill document it in the readme though.
error[E0554]: #![feature] may not be used on the stable release channel
   --> /Users/jacobrosenthal/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-graphviz-306.0.0/lib.rs:289:1
    |
289 | #![feature(rustc_private, nll)]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: #![feature] may not be used on the stable release channel
   --> /Users/jacobrosenthal/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-graphviz-306.0.0/lib.rs:290:1
    |
290 | #![feature(str_escape)]
    | ^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors

Right, kind of forgot I also overrides into nightly here.
I don't have any strong preference for stable though, so if it should be nightly we can mention it in the readme. As far as I checked the only addition for nightly is untagged_union directive. So I guess we can go stable just by dropping this.

Yeah.. Honestly I can almost guarantee theyre going to be doing good svd2rust work soon and Ill bet it has more nightly stuff, but I figure lets get one release out there for stable folks?

3:33 PM J<•japaric> Jacob_____: you should not relase 1.0 until all your crate dependencies are also 1.0. The reason is that if you ever need to bump the minor version of a dep then you may be forced (e.g. due to re-exports) to do a new major release of your crate
3:33 PM (of course, unless you are fine making several major releases of your crate)
3:37 PM J<Jacob_____> Jacob Rosenthal @japaric thanks. Thoughts on how to offer nightly and stable?
3:38 PM for PAC which doesnt offer a way to feature flag as far as I know
3:38 PM maybe svd2rust nightly boolean should take a feature flag name
3:41 PM J<•japaric> Jacob_____: imo, svd2rust should not even have a nightly flag. the overlapping register stuff can be handled without unions (nightly); it just hasn't been implemented. see https://github.com/rust-embedded/svd2rust/issues/218


❓ [Question] How do you convert part of the model to TRT?

❓ Question
Is it possible to convert only part of the model to TRT. I have model that cannot be directly converted  to trt because it uses custom classes. I wanted to convert only modules that can be converted but as I tried it torch cannot save it.
What you have already tried
I tried the following:
import torch.nn
import torch_tensorrt

class MySubmodule(torch.nn.Module):
    def __init__(self):
        super(MySubmodule, self).__init__()
        self.layer = torch.nn.Linear(10, 10)

    def forward(self, x):
        return self.layer(x)

class MyMod(torch.nn.Module):
    def __init__(self):
        super(MyMod, self).__init__()
        self.submod = MySubmodule()
        self.submod = torch_tensorrt.compile(self.submod, inputs=[
            torch_tensorrt.Input(shape=(1, 10))
        ])

    def forward(self, x):
        return self.submod(x)

if __name__ == "__main__":
    model = MyMod()
    scripted = torch.jit.script(model)
    scripted(torch.zeros(1, 10).cuda())
    scripted.save("test.pt")

But it raises exception: RuntimeError: method.qualname() == QualifiedName(selfClass->name()->qualifiedName(), methodName)INTERNAL ASSERT FAILED at "../torch/csrc/jit/serialization/python_print.cpp":1105, please report a bug to PyTorch.
Environment

PyTorch Version (e.g., 1.0): 1.10.2
CPU Architecture: intel
OS (e.g., Linux): linux
How you installed PyTorch (conda, pip, libtorch, source): pip
Build command you used (if compiling from source):
Are you using local sources or building from archives: from archives
Python version: 3.8
CUDA version: 11.3
GPU models and configuration: rtx 3090
Any other relevant information:

You have a few options. 1. You can do what you did, but not sure how this how this would effect serialization since you have non PyTorch code in your torchscript. I would like to know what exactly produced this error in PyTorch, but can't look at that right now. 2. You pass the full module (MyMod) to torch_tensorrt.compile and setting MySubmodule as a torch_executed_module. This will tell TorchTRT to represent the submodule in terms of PyTorch operations instead of coalesced into a tensorrt engine. 3. You can also do this at the operator level with torch_executed_ops as well which will do the same for the single op.


Error when creating classes from this file

Download https://www.betaavoindata.fi/data/fi/dataset/kasvinsuojeluaineet JSO and try to create classes..

Try generating your classes with this site: https://jsontodelphi.com

@mraihacat exactly which endpoint are you calling?

The is a button 'Avaa' where you can download a JSON file. This is going to be a Open Data from Finnish governement.
I

@mraihacat  I've fixed the problem.
I dont have time to make a proper release, because it requires unit test and stuff, but if you want a preview version of my fil. Please email med<EMAIL_ADDRESS>and I'll send you the code.


ContentType header Bug with storing images outside of web root

Found an issue with my PR with images outside of root :/ It doesn't set the Content Type header correctly and defaults to text/html. I guess RewritePath takes care of that automatically which uses IIS's internal native processing to do that.
In the DiskCache.AddImageToCacheAsync it does accept a mimetype, however that is not persisted anywhere to be re-used. The only way to take advantage of that would be to write out a json file or something in addition to the persisted image file (maybe you have a better idea).
The easier hackier way would be to just manually map known content types based on the file extension. This might be the only option currently and is actually what the RewritePath would be doing anyways.
I'll create a PR for that but let me know what you think.

PR: https://github.com/JimBobSquarePants/ImageProcessor/pull/530

Had a look at the PR. That's the sanest, most lightweight solution we have with the API as it is. I'll get a release out asap.

Will close this since the PR was pulled in


Figure out placeholder in constraint.

There is a placeholder key on constraint. I'm not sure what this actually does. Very often it won't have enough information to generate a valid constraint and can cause failures.

Need to figure out what placeholder on constraints mean.

Placeholder is to just show in interface builder but not actually used at runtime. I think you can just ignore the value.

Nice, thanks @drumnkyle ! Have you seen symbolic? I'm ignoring it at the moment and creating the constraint anyway.

@KingOfBrian I'm not sure what symbolic is. Haven't seen it much. Sorry.


Highlight functions that can panic if misused

Similar to issue #190 I think it would be useful to indicate functions that can panic if misused. Sometimes it might not be obvious that it's even possible to misuse a certain function, so it would be a good hint for users to properly read its documentation.
Clippy has an open issue about warning when a function panics but doesn't have a # Panics section in the rustdoc: https://github.com/rust-lang/rust-clippy/issues/1974. That approach might be a reasonable way to determine if a function should be highlighted.

Hm, now that I think about this more, this seems pretty niche, and unlikely to be implemented in rust-analyzer proper. One day, once we have extension API, there might be a 3rd-party tool for this, but now, in the interst of keeping the issue list focused on actionable items I am going to close.


fix(statutory): disable submit button when loading

:tada: This PR is included in version 1.35.16 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Promo: Softpedia

Linux section @ Softpedia. PAD file to be created using http://www.padbuilder.com/ and stored on mf.com (linked from the documentation).

PAD file to be added to GitHub repository + to be linked from the MD documentation.


If looking at image other than one, a new run image updates don't work

because blob only has one image

done on 1.6


Controlling relative tabindex of tabs

Currently when I TAB through the controls in a wizard, the buttons for navigating the wizard pages always come a) first and b) consecutively for every page. This means that if I want to use TAB to navigate the controls on a page, I have to first TAB past the wizard buttons. This feels a bit awkward to me, and a more natural order would let me TAB through all of the controls on a page before focus went to the button for the next wizard page. In other words, I'd like TAB (plus pressing enter on page buttons) to take me "linearly" through the wizard from start to finish. Is there a way to do this with the current wizard implementation? If not, is there any chance that it could be added?

@abingham maybe i am miss understanding, but can't you just use tabindex on the elements?

I'm not sure if that's an option. As I recall (I don't have the project in front of me at the moment), I wasn't able to set the tabindex on the page buttons for the wizard. When I tried setting them, the number got ignored.
But even if I can set the tabindex on the page buttons, it will still be pretty tedious to make them mesh properly with the rest of the controls, esp. if I add or remove controls over time. It seems like there's a "natural" tab order that could be automatically applied to the controls and the page buttons.
It's entirely possible that I'm missing something simple, BTW. I'm relatively new to client-side web stuff.