return user properties and response topic as part of CON ACK from redis lua plugin for MQTT5 clients

Environment

VerneMQ Version: 1.10.2
OS:  Red Hat Enterprise Linux Server 7.5 (Maipo)
Erlang/OTP version (if building from source): N.A
VerneMQ configuration (vernemq.conf) or the changes from the default: enabled vmq_diversity plugin
Cluster size/standalone: 1 node

Expected behaviour
We are writing or extending out-of-the-box redis.lua plugin of vmq_diversity to support our below custom needs:
-  Authentication and authorization based on, way we store in our redis data store.
-  Return the user-properties and response topic if authentication is successful.
-  Only for MQTT 5 clients, as above are only supported in MQTT5. So we use hook "auth_on_register_m5".
Below is our customized, redis.lua script for the above requirements:
function auth_on_register_m5(reg)
    print('auth_on_register_m5',reg.username)
    if reg.username ~= nil and reg.password ~= nil then
        unameKey = "username:"
        hashKey  = "test.client.restricted.broker.creds"
        if reg.mountpoint ~= "/restricted" then
           hashCodeVal = hashCode(reg.username)
           bucket = hashCodeVal % 512
           hashKey = "test.client.creds:"..bucket
        end
        res = redis.cmd(pool, "hget " .. hashKey .." " .. unameKey..reg.username)
        res = json.decode(res)
        if reg.password == res.passhash then
            -- properties = reg.properties
                return {properties =
                   {p_user_property =
                      {{k1 = "v1"}, {k2 = "v2"}, {k3 = "v3"}}}}
        end
    end
    return false
end

From the above code what we expect is MQTT5 client gets authenticated using data stored in redis and return the user-properties/response topic(its not there in the above snippet) if authentication is successful.
And con ack packet to the client will get user-properties and response topic.
Actual behaviour

MQTT5 client's doesn't get user-properties/response topic in con ack, although there are no errors seen in logs and client(mqtt5) gets con ack packet as well but without user-properties and response topic fields in it.

Please let us know this is supported in vmq_diversity or not. If not then how this can be achieved, as this is from MQTT 5 specification.

@vshirol thanks, this is a duplicate of https://github.com/vernemq/vernemq/issues/1764
For context, read my answers there.
In short: VerneMQ behaviour is spec conform (it chooses not to send user properties) but exposing this to plugins (so that they can override it) is a useful addition and should be implemented.

@ioolkos
Thanks for your quick response. When you say exposing this to plugins should be is useful addition and should be implemented, any idea in which version of VMQ its going to part of?

@vshirol I have not yet decided. Feel free to propose a PR, it might even be a totally low hanging thing.
What I wanted to say is that I see the use case for this, and deem it a valuable feature.

I have create a PR, Please review and merge it.
Sample response of auth_on_register_m5 hooks is:
{ok, #{properties => #{p_response_info => <<"test">>}}}.

@Jothy90  Thanks for these changes, to me changes look good though I haven't tested it. I might not be correct person to review these and merge. May be @ioolkos ?

Sorry I see its already reviewed and merged.  Thanks to both @Jothy90 & @ioolkos.

Hi @ioolkos/@Jothy90 as code is merged for this request, can you please let me know in which upcoming version of VMQ release this will be available and tentative timeline?


Clean up donation application

#2738 introduced some code that could be cleaned up. See the review there for more information on cleanup efforts.

Moved out of the repo!


Add stub template for CF on Kubernetes WG

This PR proposes a working group dedicated to providing the Cloud Foundry developer experience on top of Kubernetes and its ecosystem.

@gcapizzi I pushed some revisions. PTAL!

LGTM!

Merging: a quorum of the TOC has approved and there has been no outstanding discussion for the past week.


Omnibus dependabot update:

Consolidate PRs:

#2259
#2258
#2257
#2256
#2255
#2254
#2253
#2247
#2227

Also, replaced github.com/Microsoft/cosesign1go with unreleased version to retract<EMAIL_ADDRESS>implicit import.

Lets update cosesign1go to latest (I asked them to release a new version recently): https://github.com/microsoft/cosesign1go/releases/tag/v1.2.0


Bug report

Steps to reproduce

Complete last level.
Click next button.
Open dev-tool and you will keep receiving errors.

Logic broken here?
this.currentLevelIndex = this.nextUnsolvedLevelIndex();

nextUnsolvedLevelIndex will return undefined after all levels finished. Thus setting  currentLevelIndex  as undefined  caused no valid level as correct reference.


Install on mac

If you have a mac and had successfully run the website, could you paste your command lines?

Fixed.
First: follow https://jekyllrb.com/docs/installation/macos/
Second: delete bundler if you have installed it using a different ruby. >gem uninstall bundler
Third: reinstall bundler following the instruction. If you have issues with nokogiri, just >gem uninstall nokogiri before install bundler. The bundler will fetch the correct nokogiri

shjzhang@Shangjias-MacBook-Pro UNLV-SPFG.github.io % bundle exec jekyll serve
Configuration file: /Users/shjzhang/github/UNLV-SPFG.github.io/_config.yml
            Source: /Users/shjzhang/github/UNLV-SPFG.github.io
       Destination: /Users/shjzhang/github/UNLV-SPFG.github.io/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
      Remote Theme: Using theme mmistakes/minimal-mistakes
       Jekyll Feed: Generating feed for posts
                    done in 9.919 seconds.
 Auto-regeneration: enabled for '/Users/shjzhang/github/UNLV-SPFG.github.io'
bundler: failed to load command: jekyll (/usr/local/lib/ruby/gems/3.0.0/bin/jekyll)
/usr/local/lib/ruby/gems/3.0.0/gems/jekyll-3.9.0/lib/jekyll/commands/serve/servlet.rb:3:in `require': cannot load such file -- webrick (LoadError)
	from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-3.9.0/lib/jekyll/commands/serve/servlet.rb:3:in `<top (required)>'
	from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-3.9.0/lib/jekyll/commands/serve.rb:184:in `require_relative'
	from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-3.9.0/lib/jekyll/commands/serve.rb:184:in `setup'
	from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-3.9.0/lib/jekyll/commands/serve.rb:102:in `process'
	from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-3.9.0/lib/jekyll/commands/serve.rb:93:in `block in start'
	from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-3.9.0/lib/jekyll/commands/serve.rb:93:in `each'
	from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-3.9.0/lib/jekyll/commands/serve.rb:93:in `start'
	from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-3.9.0/lib/jekyll/commands/serve.rb:75:in `block (2 levels) in init_with_program'
	from /usr/local/lib/ruby/gems/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `block in execute'
	from /usr/local/lib/ruby/gems/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `each'
	from /usr/local/lib/ruby/gems/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
	from /usr/local/lib/ruby/gems/3.0.0/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
	from /usr/local/lib/ruby/gems/3.0.0/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
	from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-3.9.0/exe/jekyll:15:in `<top (required)>'
	from /usr/local/lib/ruby/gems/3.0.0/bin/jekyll:25:in `load'
	from /usr/local/lib/ruby/gems/3.0.0/bin/jekyll:25:in `<top (required)>'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/lib/bundler/cli/exec.rb:58:in `load'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/lib/bundler/cli/exec.rb:58:in `kernel_load'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/lib/bundler/cli/exec.rb:23:in `run'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/lib/bundler/cli.rb:484:in `exec'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/lib/bundler/cli.rb:31:in `dispatch'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/lib/bundler/cli.rb:25:in `start'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/exe/bundle:48:in `block in <top (required)>'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/lib/bundler/friendly_errors.rb:103:in `with_friendly_errors'
	from /Users/shjzhang/.gem/ruby/3.0.0/gems/bundler-2.3.5/exe/bundle:36:in `<top (required)>'
	from /usr/local/opt/ruby/bin/bundle:23:in `load'
	from /usr/local/opt/ruby/bin/bundle:23:in `<main>'

I have this error after running

bundle exec jekyll serve

I followed https://stackoverflow.com/questions/65989040/bundle-exec-jekyll-serve-cannot-load-such-file and solved the problem. or this one https://github.com/jekyll/jekyll/issues/8523
Maybe later on the Gemfile should be updated to include
gem "webrick"
or
bundle add webrick

Reopening issue until READMEs are updated with info from @zhangsj96's most recent comment.

Closing with commit 2884c3d995c6e709140567d4daa14f791be4961a.
Thanks for the suggestion, @zhangsj96!


Fix path issue between radarr, sonarr and qbittorrent

More details can be found here:

https://wiki.servarr.com/radarr/system#bad-remote-path-mapping
https://trash-guides.info/Radarr/Radarr-remote-path-mapping/

Done!


OctopOS Prime Venue Designs-6

Design OctopOS Prime's kitchen and cooking in the kitchen.
You can use the Chef Octopos mascot you made last week.


javascript error: Comms::sendIq called before startComms

Advertising of monetized Frameworks is strictly forbidden and will be reported

[ ] The language must be English, if you are not fluent in English consider using: https://www.deepl.com/translator if it supports your native language

[ ] Please check if any other issue already adresses your concerns or if a recent PR is already fixing the mentioned issue

[ ] Please make sure to format your code, and to mark your code as such, with the provided tools from github (upper right of this box)

[ ] Please state your Operating System (inlcuding version), your Python Version, and your installation way (pip, from repo) and if you are running it inside a docker container

[ ] Note that the pip installation might be behind, so try to fix your issue with a pull from the repo and update to the most recent version

[ ] Follow the Stackoverflow Guidelines (https://stackoverflow.com/help/how-to-ask) when in need of help

[ ] Consider posting your question on Stackoverflow if it is a general programming question

[ ] There will be no support for spamming, or other mischief

[ ] There will be no support for finding professionals

Sir getting below error in WAPI.js,
javascript error: Comms::sendIq called before startComms
(Session info: chrome=91.0.4472.77)
chrome version is:91

@rajeshshettysrs
Hey man !!!
See here https://github.com/mukulhase/WebWhatsapp-Wrapper/issues/1033#issuecomment-853758511

@rajeshshettysrs
Hey man !!!
See here #1033 (comment)

Thank you very very much sir and thanks to @bobaoapae
Just change store discovery for WapQuery, getting wrong reference.
"{ id: "WapQuery", conditions: (module) => (module.default && module.default.queryExist) ? module.default : null},"
this solution worked for above issue.


Introduce new changes for running on new cluster

Hi Christopher,
are the edits for the new cluster on top of the changes Petet Steinbach had done? i had just pulled that 2 weeks back or so, so should I redo the entire thing?
Best
Akanksha
Akanksha Jain
PhD student, Tomancak Lab
Max Planck Insti. of Molecular cell Biology and Genetics, Dresden, Germany

On Jun 15, 2016, at 11:05 AM, Christopher Schmied<EMAIL_ADDRESS>wrote:
Merged #28 https://github.com/schmiedc/snakemake-workflows/pull/28.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/schmiedc/snakemake-workflows/pull/28#event-692957614, or mute the thread https://github.com/notifications/unsubscribe/AKRdVeESy3RF8doPSy2gxEHgNnkhAk17ks5qL8BmgaJpZM4I2JNW.


is there a way to add annotation for each property

etc:
public calss SomeClass{
    private String code;
    private String msg;
}

auto generate to
public class SomeClass{
    @NotNull
    private String code;
    @NotNull
    private String msg;
}

if there are popmenu for user to chosen which property need to be modify , it's better
thanks..

private (.*) (.*);

@NotNull\(message="$2\")\n    private $1 $2;

solve it


Network / port should contain also IP address

Addons that have WebUI (Grafana, InfluxDB, etc.) can configure WebUI port.
For example in case of Grafana, there is 80/tcp: 3000 configuration option.
For Linux setups (not on dedicated hardware), there is a need to limit this to localhost IP address only (limit to dst-IP).
E.g. when starting docker you can put option -p <IP_ADDRESS>:3000:80
However there is no way how to configure this in hassio.
Could you please add this option? Or is it possible to do by modifying some configuration file?
If I modify addons.json with

"network": {
"80/tcp": "<IP_ADDRESS>:3000"
}

the modification gets overwritten.
Docker modifies iptables firewall by default so there is no easy way to limit this by setting iptables firewall. You can disable this but you will loose this functionality for other Docker containers.
https://community.home-assistant.io/c/feature-requests

Set the port on UI to None and you can only reach it from internal virtual network


TextButton and TextButton.icon are of different height

Steps to Reproduce

Run flutter create bug.
Update the files as follows:

lib/main.dart:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('TextButton different height'),
      ),
      body: Center(
        child: Row(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            TextButton(
              child: Text('Button one'),
              onPressed: () {},
              style: ButtonStyle(
                backgroundColor: MaterialStateProperty.all<Color>(Colors.blue),
                foregroundColor: MaterialStateProperty.all<Color>(Colors.white),
              ),
            ),
            Padding(
              padding: EdgeInsets.all(5),
            ),
            TextButton.icon(
              label: Text('Button two'),
              icon: Icon(Icons.android),
              onPressed: () {},
              style: ButtonStyle(
                backgroundColor: MaterialStateProperty.all<Color>(Colors.blue),
                foregroundColor: MaterialStateProperty.all<Color>(Colors.white),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

Run app in Android emulator.

Expected results:
I expect to see two buttons of equal height. For example if I toggle leading icon on Material Design button doc the height of the button does not change.
Actual results:

Logs

[√] Flutter (Channel beta, 1.25.0-8.3.pre, on Microsoft Windows [Version 10.0.19041.746], locale sv-SE)
    • Flutter version 1.25.0-8.3.pre at C:\Users\Leif\Programmering\Libraries\flutter
    • Framework revision 5d36f2e7f5 (10 days ago), 2021-01-14 15:57:49 -0800
    • Engine revision 7a8f8ca02c
    • Dart version 2.12.0 (build 2.12.0-133.7.beta)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Leif\Programmering\Android\android-sdks
    • Platform android-30, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code, 32-bit edition (version 1.52.1)
    • VS Code at C:\Program Files (x86)\Microsoft VS Code
    • Flutter extension version 3.18.1

[√] Connected device (3 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 87.0.4280.141
    • Edge (web)                         • edge          • web-javascript • Microsoft Edge 88.0.705.50

• No issues found!

It is possible that to create a flat button with a non-transparent background, I should use an ElevatedButton and set elevation to 0 or use an outlined button and change background and border colour of it. Because ElevatedButton and OutlineButton does not seem to have this bug/problem with different height when you set a background colour.
But the migration docs says FlatButton => TextButton.
Or I was wrong from the beginning to use FlatButton to create a flat button with a background?

It is possible that to create a flat button with a non-transparent background, I should use an ElevatedButton and set elevation to 0 or use an outlined button and change background and border colour of it. Because ElevatedButton and OutlineButton does not seem to have this bug/problem with different height when you set a background colour.
But the migration docs says FlatButton => TextButton.
Or I was wrong from the beginning to use FlatButton to create a flat button with a background?

Hi @Leffe108
This is due to the icon's height, it's higher than the default text higher. If you set custom icon height it matches the default text height. Of course, it should have been done this way, it should match height by default.
Preview

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('TextButton different height'),
      ),
      body: Center(
        child: Row(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            TextButton(
              child: Text('Button one'),
              onPressed: () {},
              style: ButtonStyle(
                backgroundColor: MaterialStateProperty.all<Color>(Colors.blue),
                foregroundColor: MaterialStateProperty.all<Color>(Colors.white),
              ),
            ),
            Padding(
              padding: EdgeInsets.all(5),
            ),
            TextButton.icon(
              label: Text('Button two'),
              icon: Icon(
                Icons.android,
              ),
              onPressed: () {},
              style: ButtonStyle(
                backgroundColor: MaterialStateProperty.all<Color>(Colors.blue),
                foregroundColor: MaterialStateProperty.all<Color>(Colors.white),
              ),
            ),
            Padding(
              padding: EdgeInsets.all(5),
            ),
            TextButton.icon(
              label: Text('Button two'),
              icon: Icon(
                Icons.android,
                size: 14,
              ),
              onPressed: () {},
              style: ButtonStyle(
                backgroundColor: MaterialStateProperty.all<Color>(Colors.blue),
                foregroundColor: MaterialStateProperty.all<Color>(Colors.white),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (7 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (1 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-13.0.pre.144, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-13.0.pre.144 at /Users/tahatesser/Code/flutter_master
    • Framework revision 2007186d2e (11 hours ago), 2021-01-24 12:54:00 -0800
    • Engine revision fdddf87080
    • Dart version 2.12.0 (build 2.12.0-253.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (3 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
    • macOS (desktop)                    • macos         • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 88.0.4324.96

• No issues found!

As far https://github.com/flutter/flutter/issues/74593#issuecomment-766356894, I would say ElevatedButton is good for this elevation zero.
Thank you

Hi @Leffe108
This is due to the icon's height, it's higher than the default text higher. If you set custom icon height it matches the default text height. Of course, it should have been done this way, it should match height by default.
Preview

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('TextButton different height'),
      ),
      body: Center(
        child: Row(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            TextButton(
              child: Text('Button one'),
              onPressed: () {},
              style: ButtonStyle(
                backgroundColor: MaterialStateProperty.all<Color>(Colors.blue),
                foregroundColor: MaterialStateProperty.all<Color>(Colors.white),
              ),
            ),
            Padding(
              padding: EdgeInsets.all(5),
            ),
            TextButton.icon(
              label: Text('Button two'),
              icon: Icon(
                Icons.android,
              ),
              onPressed: () {},
              style: ButtonStyle(
                backgroundColor: MaterialStateProperty.all<Color>(Colors.blue),
                foregroundColor: MaterialStateProperty.all<Color>(Colors.white),
              ),
            ),
            Padding(
              padding: EdgeInsets.all(5),
            ),
            TextButton.icon(
              label: Text('Button two'),
              icon: Icon(
                Icons.android,
                size: 14,
              ),
              onPressed: () {},
              style: ButtonStyle(
                backgroundColor: MaterialStateProperty.all<Color>(Colors.blue),
                foregroundColor: MaterialStateProperty.all<Color>(Colors.white),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (7 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (1 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-13.0.pre.144, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-13.0.pre.144 at /Users/tahatesser/Code/flutter_master
    • Framework revision 2007186d2e (11 hours ago), 2021-01-24 12:54:00 -0800
    • Engine revision fdddf87080
    • Dart version 2.12.0 (build 2.12.0-253.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (3 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
    • macOS (desktop)                    • macos         • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 88.0.4324.96

• No issues found!

As far https://github.com/flutter/flutter/issues/74593#issuecomment-766356894, I would say ElevatedButton is good for this elevation zero.
Thank you

Hi @Leffe108
Thanks for filing the issue, I verified this on the latest stable and the master channel and the issue is still reproducible.

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('TextButton different height'),
      ),
      body: Center(
        child: Row(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            TextButton(
              child: Text('Button one'),
              onPressed: () {},
              style: ButtonStyle(
                backgroundColor: MaterialStateProperty.all<Color>(Colors.blue),
                foregroundColor: MaterialStateProperty.all<Color>(Colors.white),
              ),
            ),
            Padding(
              padding: EdgeInsets.all(5),
            ),
            TextButton.icon(
              label: Text('Button two'),
              icon: Icon(
                Icons.android,
              ),
              onPressed: () {},
              style: ButtonStyle(
                backgroundColor: MaterialStateProperty.all<Color>(Colors.blue),
                foregroundColor: MaterialStateProperty.all<Color>(Colors.white),
              ),
            ),
            Padding(
              padding: EdgeInsets.all(5),
            ),
            TextButton.icon(
              label: Text('Button two'),
              icon: Icon(
                Icons.android,
                size: 14,
              ),
              onPressed: () {},
              style: ButtonStyle(
                backgroundColor: MaterialStateProperty.all<Color>(Colors.blue),
                foregroundColor: MaterialStateProperty.all<Color>(Colors.white),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

Output

flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 11.5.2 20G95 darwin-x64, locale en-US)
    • Flutter version 2.5.3 at /Users/flo/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (5 days ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.0, Build version 13A5212g
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile)    • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 12 Pro Max (mobile) • 98CBBFB1-4069-4A28-B7F7-138911ACBE72 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 11.5.2 20G95 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.6.0-12.0.pre.406, on macOS 11.5.2 20G95 darwin-x64, locale en-US)
    • Flutter version 2.6.0-12.0.pre.406 at /Users/flo/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 71a0b6169d (73 minutes ago), 2021-10-20 02:08:04 -0400
    • Engine revision 115c859b2c
    • Dart version 2.15.0 (build 2.15.0-233.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile)    • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 12 Pro Max (mobile) • 98CBBFB1-4069-4A28-B7F7-138911ACBE72 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 11.5.2 20G95 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

Thank you

This is WAI per https://github.com/flutter/flutter/issues/74593#issuecomment-766637683


Add unix socket for listening.

nginx can listen on unix sockets in addition to v4 and v6 addrs. This adds parameters to permit this use case.
http://nginx.org/en/docs/http/ngx_http_core_module.html#listen
The parameters emulate the ipv6 implementation. The enable parameter only affects listen in the unix socket case (not things like proxy_pass), so I called this listen_unix_socket_enable rather than unix_socket_enable.

Very nice. Thanks for the code!


chore(ci): create PRs for nix flake updates automatically

Description of change
Automatically creates PR with flake.lock update, which is file with Nix dependencies
It doesn't run it on PRs not to create PRs from PRs

How has this been tested? (if applicable)
Here is action run https://github.com/thingsbych/binsider/actions/runs/11388924732/job/31687028064
And PR that it created https://github.com/thingsbych/binsider/pull/3

I don't get why we need this. Can we maybe run it weekly like we do with Dependabot? Can you explain it a bit?

Sadly dependabot can't update nix flakes, but ofc it can be ran weekly


Logging v2 - Syslog output with UDP not working

SURE-3452
Rancher Server Setup
Rancher Cluster:
Rancher version: v2.5.9
Number of nodes: 3
Node OS version: Ubuntu 18.04
Downstream Cluster:
Number of Downstream clusters: 1
Node OS: Ubuntu 18.04
RKE/RKE2/K3S version: RKE2
Kubernetes version: 1.20.8
CNI: canal
Other:
Underlying Infrastructure: VMWare
Any 3rd party software installed on the nodes: No
Describe the bug
Logging v2 syslog output with UDP not working. After configuring UDP transport , there was no traffic observed on port 514.
To Reproduce
Install Logging with chart version 3.9.400
Install and configure rsyslog on a remote system
Enable log filtering by creating a file /etc/rsyslog.d/remote.conf with below content
$ModLoad imtcp.so         # load module
$InputTCPServerRun 514 # Starts a TCP server on selected port
$ModLoad imudp.so         # provides UDP syslog reception
$UDPServerRun 514         # start a UDP syslog server at standard port 514
$template RemoteLogs,"/var/log/remote/%HOSTNAME%/%PROGRAMNAME%.log"
. ?RemoteLogs& ~
Create a ClusterOutput
apiVersion: logging.banzaicloud.io/v1beta1
kind: ClusterOutput
metadata:
name: demo-test
namespace: cattle-logging-system
spec:
syslog:
buffer:
timekey: 1m
timekey_use_utc: true
timekey_wait: 10s
format:
app_name_field: kubernetes.pod_name
hostname_field: cluster
log_field: message
host: <IP_ADDRESS>
insecure: false
port: 514
transport: udp
Create a ClusterFlow
apiVersion: logging.banzaicloud.io/v1beta1
kind: ClusterFlow
metadata:
name: demo-flow
namespace: cattle-logging-system
spec:
filters:

record_transformer:
records:

cluster: clsterX
globalOutputRefs:

demo-test

Result
No logs were transferred.
Expected Result
Logs should be transferred to remote syslog.
Additional context
Workaround:
Is workararound available and implemented? yes
What is the workaround:
Replace the logging object's fluentd image with ghcr.io/banzaicloud/fluentd:v1.13.3-alpine-8 , it works fine with UDP.
(kubectl edit loggings.logging.banzaicloud.io rancher-logging)
Looks like below patch is missing and we need updated fluentd image or Logging operator.
https://github.com/cloudfoundry/fluent-plugin-syslog_rfc5424/pull/8/files

Is this a duplicate of https://github.com/rancher/rancher/issues/32144

It looks like a recent fluentd image has solved this and we upgraded to the image elsewhere. I'll send this to QA for validation.

Pass verified in 2.6-head Commit ID 8cc8121

provisioned a syslog server
created a cluster output with server ip and port 514 / UDP
created a deployment on cluster
tailed syslog on syslog server

Logs flowed via UDP


Make all text inputs full-width

On the Options page there really isn't any reason not to make these inputs full width. Especially the site URL one could easily be longer than the current input provided.
Before:

After:

Rebased.


Slightly More Robust FSM Architecture

Changes:

Organized Core scripts into individual folders called BaseEntityServices, BaseMessages, BaseServices, and BaseStates.
ApplicationManager script still lives at the root of Core.
Created IEntityService interface for generic typing of services specific to managing and interacting with Unity ECS portions of a codebase. This architectural component is still under construction. More to come Soon (TM).
Created IState which is an interface with one method that enforces the return of the Type of IState. This interface will be used to enforce the creation of specific IStates, such as IApplicationState and make it less likely that enumless states cannot be mixed up between different state machines.
Created IFiniteState, which enforces the return of a Type of IFiniteState for similar reasons.
Created IStateMachine, which is an interface used to generically type our various state machines in the application for bootstrapping purposes, as well as retrieval via the Service Locator Pattern.
Created a StateMachineManager for adding IStateMachines to the ApplicationManager during bootstrapping, and retrieval of IStateMachines via the service locator pattern.
Created a BaseStatMachine abstract class, which enforces the state change pattern through a protected void method called SetState.
Defined a specific type of IMessage called StateChangedMessage that is used to construct messages pertaining to states changing. This enforces our StateChangedMessages to have a specific format (i.e. no more mixing up prevState, nextState, and currentState)
Created an example set of scripts that show all of the above in action located in Runtime/States/ApplicationState and a corresponding MainMenuController which allows the user to test setting states via a canvas in the TestScene.

For More Info See:
closes #14

Reminder to self to perform code documentation via XML tags before slamming the merge button.


Flaky test: centos-8-4.13 (failed: Exception: (Sys_error) Cannot allocate memory

This occurred here https://github.com/mirage/irmin/pull/1689
┌──────────────────────────────────────────────────────────────────────────────┐
│ [FAIL]        HTTP.FS                  14   Unrelated merges.                │
└──────────────────────────────────────────────────────────────────────────────┘
pwd=/src/_build/default
Executing: "../../_build/default/test/irmin-unix/test.exe serve 0<PHONE_NUMBER> &"
[exception] (Sys_error
  "../../_build/default/test/irmin-unix/test.exe serve 0<PHONE_NUMBER> &: Cannot allocate memory")
            Raised by primitive operation at Test_http.suite.(fun) in file "test/irmin-http/test_http.ml", line 209, characters 14-29
            Called from Lwt.Sequential_composition.bind.create_result_promise_and_callback_if_deferred.callback in file "src/core/lwt.ml", line 1860, characters 23-26
            Re-raised at Irmin_test__Common.Make_helpers.run.(fun) in file "src/irmin-test/common.ml", line 294, characters 11-47
            Called from Lwt.Sequential_composition.map.(fun) in file "src/core/lwt.ml", line 2004, characters 35-40
            Re-raised at Lwt.Miscellaneous.poll in file "src/core/lwt.ml", line 3068, characters 20-29
            Called from Lwt_main.run.run_loop in file "src/unix/lwt_main.ml", line 31, characters 10-20
            Called from Lwt_main.run in file "src/unix/lwt_main.ml", line 118, characters 8-13
            Re-raised at Lwt_main.run in file "src/unix/lwt_main.ml", line 124, characters 4-13
            Called from Alcotest_engine__Core.Make.protect_test.(fun) in file "src/alcotest-engine/core.ml", line 180, characters 17-23
            Called from Alcotest_engine__Monad.Identity.catch in file "src/alcotest-engine/monad.ml", line 24, characters 31-35

irmin-http has been removed https://github.com/mirage/irmin/pull/1902


Is there a rel=nofollow extension?

I'm using python-markdown for user generated text on a website and I would like to mark all the links as rel="nofollow" which I believe is a good practice in that situation to inhibit spam. Is there an extension for that? Do you think it would be worth adding if there isn't? Or simply maintaining as a third party extension?
I'm probably going to try to adapt: https://github.com/Undeterminant/markdown-newtab for the purpose unless I find something that handles the issue. I can't see anything from my searches though. A post process filter approach exists as well but it seems like it might be hard to perfect the regex: http://blog.rafaljonca.org/2010/01/simple-nofollow-filter-for-markdown.html
Thanks for the excellent project.
Michael

@michaeljones Hi! If you're still looking for a rel="nofollow" extension, here's one that I made: markdown-nofollow.


unique index is created when auto migrate run in each time

GORM Playground Link
Description
type SysUser struct {
	ID       int    `gorm:"primaryKey;autoIncrement"`
	Name     string `gorm:"size:50;not null"`
	Username string `gorm:"size:50;uniqueIndex;not null"`
	Password string `gorm:"type:text;not null"`
	Email    string `gorm:"type:text;"`
	Active   bool   `gorm:"default:false"`
	Audit
}
db.AutoMigrate(
		&SysUser{},
)

result in mysql

seems works for me or please create playground pr

the unique index seems ok now. But some fields will run command alter every time.
pls check the pr below.
https://github.com/go-gorm/playground/pull/116

the issue should be fixed on latest master.


Rename Container to Ref

The Container class is widely misunderstood and underused.  However it can be very useful to implement a return parameter. This PR rename the class according to this usage. It will make some signatures easier to understand: (example inspired by a similar function from UDPSocket)
# This method has 3 outputs:
# * The received message written into `buffer`.
# * The number of bytes written as the return value.
# * The information on the sender of the message is stored in `sender_info`.
fun recv_from(buffer: NativeString, sender_info: Ref[nullable SocketAddress]): Int

Bonus Ref tip!
Ref can also be used as a hackish equivalent to a static variable in C. This example use the dreaded once keyword to easily get a singleton, but it could be done cleaner with an attribute in Sys.
fun foo
   ...

    # Count the number of times foo is executed
    var counter = once new Ref[Int](0)
    counter.item += 1
    print "foo has been executed {counter.item} times"
end

I'm baffled by such a change, :shipit: !

@R4PaSs, I know, it will take a while to get used to the new name!

+1

RIP Container.

+1. Changed your example to use a fun instead of a var.


Multi-Tenant The App Registration

We used B2c for Authentication to our app which use "local" account now I want to add "Multi-Tenant Azure AD" Authentication to it. I understand the default "User flow" is not working and I have use the custom policy. I am trying to use this Article  (Set up sign-in for multi-tenant Azure Active Directory using custom policies in Azure Active Directory B2C)   to set up Multi-Tenant Authentication for B2C. However So far I didn't have that much luck.
I setup everything based on instruction. However, when I try to do the last part which is testing the Authentication  in B2C ( Section Test your custom policy) I couldn't find the My App that I register on My Tenant ( not B2C ) ( see instruction under "Register an Azure AD app") in list "Applications" to test it.  (see picture below)

Two questions :

Are you sure that the App Registration (step one in document) should be in Azure AD not in B2C?  If yes then
How should I add the app I added in my Azure AD to list of App in B2C so it recognize it?

And if I try with any existing B2C Application I get this error :
AADB2C90289: We encountered an 'invalid_client' error connecting to the identity provider.
Thanks
Hossein

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f53d6e64-7bed-a987-c4bb-57fb1b116d48
Version Independent ID: fe33fd59-07ac-54d4-1926-f867aa6fc168
Content: Set up sign-in for multi-tenant Azure AD by custom policies - Azure AD B2C
Content Source: articles/active-directory-b2c/identity-provider-azure-ad-multi-tenant.md
Service: active-directory
Sub-service: b2c
GitHub Login: @garrodonnell
Microsoft Alias: godonnell

more on this,
so The Enterprise App I set up in My Tenant is not and cannot register in b2c tenant. When I test the policy I get the claim (it is HS256 I am not sure that is going to cause any issue) but when I run my application it give me error saying  " The client id {My Azure App Client ID} specified in the request is not registered in tenant 'xyzb2c.onmicrosoft.com'
.

@hjabbar61
Thanks for your feedback! We will investigate and update as appropriate.

@hjabbar61
Thank you for your feedback!
Since this issue isn't directly related to improving our docs, and to gain a better understanding of your issue, I'd recommend working closer with our support team via an Azure support request. Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
Teams Q&A forum for technical questions about the configuration and administration of Microsoft Teams on Windows.
Microsoft Teams Community forum
Thank you for your time and patience throughout this issue.

The instructions reference two apps:

An app registered in an Azure AD B2C tenant that you are setting up authentication for.
An app registered in an Azure AD tenant that you are using as an identity provider.

When you are testing the custom policy you should be using the B2C app. I hope this makes sense.
The error you're getting may be caused by an incorrect client_id set up when configuring Azure AD as an identity provider.

Thank you @garrodonnell. The issue is in the Article it says Azure AD  ( see https://learn.microsoft.com/en-us/azure/active-directory-b2c/identity-provider-azure-ad-multi-tenant?pivots=b2c-custom-policy#configuring-optional-claims )  but the app should be created in Azure B2C.
After I set it as Azure B2C App it gives me the claim (token) but was encrypted with HS256. and when I tried to use it in my application it gives me "Key is not matched" error. After a little bit of search I found out that I have to reissue the Policy Keys that we created (mentioned in this Article  https://learn.microsoft.com/en-us/azure/active-directory-b2c/tutorial-create-user-flows?pivots=b2c-custom-policy#add-signing-and-encryption-keys-for-identity-experience-framework-applications   ) and it returns RS256 encrypted token
Now my next challenge is to get the FirstName, Last Name and Email within the claim. Currently when I login using Company's Azure AD  it doesn't provide the email (but gives me first name and last name) and when I login B2C user it doesn't give me any of those three values.  Do you know how I can resolve that?
Thanks
Hossein

Hi @hjabbar61 - Glad you got it working. You should be able to find details on how to configure tokens and claims at the link below:
https://learn.microsoft.com/en-us/azure/active-directory-b2c/configure-tokens?pivots=b2c-custom-policy
Given that your original issues is now resolved I'm going to close this issue.
#please-close


fix(KP-324): use replaceAppWithWWW argument as false while creating PDF links in pdfAPI

After some investigation I realized that we have a function called getCurrentHost it has an argument called replaceAppWithWWW and the default value for that is true. I assume by sending a false as it's value the problem will be solved.
And I assume to actually know if this ixed the issue we should merge the code to master and check it on ref environment.

We Have worked on this task together with all other developers in a pair-programming session regarding TDD development.


Change model on the fly

Earlier this day, I raised an issue here: https://github.com/jackMort/ChatGPT.nvim/issues/414
Then, I decided to dive into the codebase and add the feature myself using my proposed change.
What's new:
openai_params.model can now be either a constant string (only method so far) or a function that returns a string containing the model (new). The model is thus computed on the fly when an API request is made.
Motivation for the change
So far, without this change, it has not been possible to change the model you are using on the fly. With the modifications this PR introduces, one can now pass a function instead of a fixed model, and the function returns the model to be used. This function is evaluated on API invokation.
Code changes:

add a Utils.collapse_openai_params function to, if the openai_params.model parameter is a function, evaluate the function when an API request is made
add Utils.table_shallow_copy as a helper function for Utils.collapse_openai_params
if the model is determined on the fly, write <dynamic> in the settings menu
added documentation and a condiguration example to the README.md

Testing
I have tested every related command (ChatGPT, ChatGPTActAs, ChatGPTRun) and they're all still working perfectly.
Apology letter (lol)
Finally, I want to apologize for the many "debugging" commits. While working on the feature, I found it easiest to commit the changes and let lazy put them into my editor so I could test them, then go back to the plugin.

great thanks, could you please reformat to satisfy stylua and make PR more readable?

I have now refactored the PR to (hopefully) be more readable and have tried to fix the formatting. This has been quite troublesome as I have been on holiday since the day after I had raised the PR and don't have my laptop with me... Could you please approve the workflow so I can see if reformatting worked?

Would love to see this feature merged

It would also be great to have some kind of lua api exposed which allowed for model parameters to be set. Something like:
require('chatgpt').open_chat({ ... model params ... })

It would also be great to have some kind of lua api exposed which allowed for model parameters to be set. Something like:
require('chatgpt').open_chat({ ... model params ... })

Maybe, I don't think there's too much need for that though. I don't see much utility in the ability to change any settings other than the model and the endpoint at runtime. If you want to open a chat with a different model, you can do that already by manipulating what the function returns and then vim.cmd("ChatGPTRun").

Would love to see this feature merged

By the way, you can already use this feature by specifying my fork instead of the main repo until it got merged :)
I've been using it ever since I made the PR

It would also be great to have some kind of lua api exposed which allowed for model parameters to be set. Something like:
require('chatgpt').open_chat({ ... model params ... })

Maybe, I don't think there's too much need for that though. I don't see much utility in the ability to change any settings other than the model and the endpoint at runtime. If you want to open a chat with a different model, you can do that already by manipulating what the function returns and then vim.cmd("ChatGPTRun").

For my use case the function is unnecessarily complicated when you could pass a simple argument to the API

It would also be great to have some kind of lua api exposed which allowed for model parameters to be set. Something like:
require('chatgpt').open_chat({ ... model params ... })

Maybe, I don't think there's too much need for that though. I don't see much utility in the ability to change any settings other than the model and the endpoint at runtime. If you want to open a chat with a different model, you can do that already by manipulating what the function returns and then vim.cmd("ChatGPTRun").

For my use case the function is unnecessarily complicated when you could pass a simple argument to the API

Also a function is not complicated at all, it is supposed to be a one-liner: function() return chatgpt_config.model end
And then, when you want to change models, you dont have to interact with the function, you just change chatgpt_config.model

It would also be great to have some kind of lua api exposed which allowed for model parameters to be set. Something like:
require('chatgpt').open_chat({ ... model params ... })

Maybe, I don't think there's too much need for that though. I don't see much utility in the ability to change any settings other than the model and the endpoint at runtime. If you want to open a chat with a different model, you can do that already by manipulating what the function returns and then vim.cmd("ChatGPTRun").

For my use case the function is unnecessarily complicated when you could pass a simple argument to the API

Also a function is not complicated at all, it is supposed to be a one-liner: function() return chatgpt_config.model end And then, when you want to change models, you dont have to interact with the function, you just change chatgpt_config.model

In my case, I am developing a telescope extension that offers interactive and chat modes through a picker. I'd rather not have the user of the extension declare a function in their chatGPT.nvim config. It would be much nicer if the telescope extension could use the API I suggested above

I just a question, we can set the models via a runtime function but not the API key right? AFAIU when a shell command is given as api key it is only executed at startup and can't be changed afterwards. But that would be great as it could allow changing for example from gpt-4o to openrouter.ai 's claude 3.5 sonnet. If you dot know openrouter.ai is a website offering a common openai api for pretty much any llm, whereas for example anthropic's API is not compatible.
Any idea how I can change the API key at runtime?

I just a question, we can set the models via a runtime function but not the API key right? AFAIU when a shell command is given as api key it is only executed at startup and can't be changed afterwards. But that would be great as it could allow changing for example from gpt-4o to openrouter.ai 's claude 3.5 sonnet. If you dot know openrouter.ai is a website offering a common openai api for pretty much any llm, whereas for example anthropic's API is not compatible.
Any idea how I can change the API key at runtime?

You can make your neovim config write to a file and make the command read the file and echo its contents

Yes but that's just at startup and not at runtime right?

Yes but that's just at startup and not at runtime right?

Oh right yeah I forgot.
I guess you could try changing internal variables of the plugin. That didnt work for the model but maybe it does for the api key


Fix the version of sweetalert

Can you fix the version of sweetalert to 1.1.3.
The newest version of sweetalert is breaking the ng-sweet-alert

:+1: I'm getting the same issue, I had to fix sweetalert to 1.1.3.

Same here.

What is the solution? I tried to change "angular-sweetalert": "~1.1.3" in bower.json but it didn't help. @harshavardhan-reddy @CaporalDead

@emrealparslan93  Yes you need to install sweetalert manually (1.1.3). This will override the sweetalert installed by ngSweetAlert.

You can also modify your bower.json to point to our forked repository:
{
    "angular-sweetalert": "git@github.com:theviralab/ngSweetAlert.git#c0b746e"
}

This installs the correct version of SweetAlert. This is a temporary solution until PR #79 gets merged.

Fix this issue please, yesterday I wasted my 2-3 hr and found then this issue

Thank you @oitozero  for merging #79 .
It seems that declaring the dependency as follows:
{
    "angular-sweetalert": "latest"
}

Still does not work, since if I'm not mistaken latest points to the most recent tagged release (which in this case still contains the old version of bower.json).
Pointing to master instead of latest fixes this. Also, creating a new release should solve this as well.

#83 can fix the issue


Add RetryableTransaction, update RetryableQuery to prevent database deadlocks in EntityWriteGateway

1. Why is this change necessary?
As discussed with @OliverSkroblin when writing entities in multiple threads and/or transactions at the same time deadlocks may occur in the database. When a deadlock occurs within a transaction, MySQL rolls back the transaction internally. Therefore the whole transaction can be retried. This is also stated in the MySQL error message:
ERROR 1213 (40001): Deadlock found when trying to get lock; try restarting transaction

The EntityWriteGateway uses a transaction but uses a RetryableQuery inside this transaction (code). In case of a deadlock a single query of the transaction is now retried (code) even though the transaction was already rolled back internally by the database. Since queries inside a multi-query-transaction may depend on each other, this causes all kinds of unintended behaviour (i.e. foreign key constraint violations).
The description of the RetryableException that is caught also suggest to retry the transaction, not a single query.
Therefore the usage of the current RetryableQuery only works when running a single query in no transaction.
2. What does this change do, exactly?
This PR adds a RetryableTransaction class which can be used to execute a number of commands (queries) inside a transaction which can be rolled back and retried as a whole without side effects or unwanted behaviour.
Additionally the current usages of RetryableQuery are updated to check whether or not the query is executed inside a transaction. Now if this is the case, the RetryableQuery will not be retried when a deadlock occurs.
For that the functions execute and retryable have been backwards-compatibly updated to accept a Doctrine\DBAL\Connection $connection to ensure this new safe behaviour.
3. Describe each step to reproduce the issue or behaviour.
Run two complex processes, e.g. create new versions of an existing order and update many products at the same time.
A real life example is the order document creation via the administration. This creates a new order version and triggers a complex product subscriber from the Pickware ERP plugin. Since this is a race condition error, your results may vary.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

I updated the changelog.
More importantly: I updated the EntityWriteGateway so it actually uses the new RetryableTransaction - which is described in the PR description and was the main reason for this PR. I lost these code changes somehow before opening the PR.

I added the UPGRADE INFORMATION part of the changelog.
I changed the RetryableQuery constructor as discussed.
I rebased the branch onto trunk.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-14082
Please use this issue to track the state of your pull request.

Hey @hanneswernery ,
sorry that it took so long to get back to this.
I just checked out your PR and wanted to do the usual rebase, but there are a few merge conflicts.
Could you rebase your PR and fix these conflicts? Then I can put it into our internal review and hopefully get it done soon : )

thanks : )

What is the status of this PR? The faulty handling of deadlocks seems to cause other problems, e.g. https://issues.shopware.com/issues/NEXT-15805

What is the status of this PR? The faulty handling of deadlocks seems to cause other problems, e.g. https://issues.shopware.com/issues/NEXT-15805

Since nothing happened here for a while I prepared a hotfix from this PR and applied it to our installation. The mentioned issue is not fixed, so it seems something else regarding transaction handling is broken besides this PR.

Here are two beginTransaction calls where the transaction code is not wrapped in a try-catch block. Don't know if this is the cause, but it looks wrong to me either way:

https://github.com/shopware/platform/blob/ab7223a804311d1c2a49dde2bb5dcd5dba1ecb61/src/Core/Content/Product/DataAbstractionLayer/ProductIndexer.php#L158
https://github.com/shopware/platform/blob/ab7223a804311d1c2a49dde2bb5dcd5dba1ecb61/src/Core/Content/Category/DataAbstractionLayer/CategoryIndexer.php#L166

I guess these could be wrapped in the new RetryableTransaction class as well.

These ain't working: (8289d011a9b0f7b1892b5671f0f7eb825ff5ce19, 9da6473672e07f54a49f4252990f3a893327e1de @OliverSkroblin)

https://github.com/shopware/platform/blob/ab7223a804311d1c2a49dde2bb5dcd5dba1ecb61/src/Core/Framework/DataAbstractionLayer/Indexing/ChildCountUpdater.php#L44
https://github.com/shopware/platform/blob/ab7223a804311d1c2a49dde2bb5dcd5dba1ecb61/src/Core/Content/Product/DataAbstractionLayer/SearchKeywordUpdater.php#L191
https://github.com/shopware/platform/blob/ab7223a804311d1c2a49dde2bb5dcd5dba1ecb61/src/Core/Content/Product/DataAbstractionLayer/ProductCategoryDenormalizer.php#L93

These lines catch exceptions which are needed for the control flow of transactions, i.e. which have to reach the new RetryableTransaction class.
It also does not make sense to split up large queries for deadlocks. This code is (or should be) wrapped in one transaction either way and InnoDB decides based on the size of the transaction, i.e. how many rows are modified, which one to roll back. Not based on the number of queries.
Best solution here is using RetryableQuery, which works with the new RetryableTransaction class and which works when the Updater is not wrapped in this class.
Fixing all mentioned issues (wrap ProductIndexer and CategoryIndexer in RetryableTransaction and removing the catch blocks, i.e. remove the split updates) resolves NEXT-15805.

By the way, I don't see why the sleep call should be necessary:
https://github.com/shopware/platform/pull/1668/files#diff-104cca720ab1150a9e4052ed394ce25bce03969849e2aeec954156e41189ba21R41
If a deadlock occurs, only one transaction is rolled back. The other one is committed. Likely, when the failing one is retried, the other one has already run through.
I guess in most cases the sleep statement will only prolong the execution of the script. If a transaction is long-running, it might help. But transactions should not be long running anyway and I doubt that a few microseconds will help in that case.
IMHO it would be better to leave the sleep out at the moment and observe how it works out in practice.

@UlrichThomasGabor Thanks for your feedback, we will have a look at this internally. Unfortunately we also are waiting for Shopware to merge this. I will ask them again, if they can merge this PR.

@hanneswernery Why do you think it makes a difference if queries are executed as batch or non-batch inside of a transaction?
From my understanding it should not make a difference:

It also does not make sense to split up large queries for deadlocks. This code is (or should be) wrapped in one transaction either way and InnoDB decides based on the size of the transaction, i.e. how many rows are modified, which one to roll back. Not based on the number of queries.

Or more specific: From my understanding, performing such work inside of a transaction non-batchy produces only SQL overhead, but will not result in less deadlocks.

Hi @UlrichThomasGabor , my last changes are the result of a discussion with @OliverSkroblin. The original PR caused some unwanted behaviour changes on the current trunk.
Main reason is that regular non-retryabe exceptions were not mapped (translated into a user-facing error) anymore. This is because this mapping is only called on non-batchwise executions. The original code retried every exception non-batchwise manually.
The original PR and the somewhat more correct retry logic that does not retry non-retryable errors (non-batchwise) broke this mapping behaviour.
The last commit reintroduces this manual retry which in turn calls the mapping again. The current state is still pending, I am waiting for a response from @OliverSkroblin

@OliverSkroblin Why is this behavior unwanted?
Basically, this method makes no sense to me:
https://github.com/shopware/platform/blob/8e56c285549ee9019a6cebffb15af4262361ef79/src/Core/Framework/DataAbstractionLayer/Dbal/EntityWriteGateway.php#L116-L146
This is all wrapped in one transaction, so should be executed atomically. Wether, this is executed as a single or as multiple SQL statements, has no effect on whether a deadlock will occur or not. It just prolongs the execution by generating overhead and thus conflicts with the most-basic best practice that transactions should be as fast/small as possible.
If the intend of "batch vs. non-batch" is "should be executed as one transaction or as multiple", then the solution should be to split the transaction or not. That does not happen at the moment.
If the intend of "batch vs. non-batch" is "should block other transaction as least as possible", then changing the isolation level is the way to go. (If this is possible. Otherwise, it becomes complicated...)
Either way, the last commit does not make it worse, but in my opinion does not solve any problem. I would revert it, remove any non-batch code, and if this performs bad in practice, then check if isolation levels can be lowered for certain transactions.
I don't get why batch vs. non-batch has anything to do with throwing Exceptions. This sounds like an unrelated issue to me.

Hi Ulrich,
first of all, thank you for looking so deeply into this topic.
As you probably noticed I'm not very active on github, so feel free to ping me in the community chat ;).
Regarding your questions and suggestions:

https://github.com/shopware/platform/pull/1668#issuecomment-895197619

This has brought some performance optimizations, and it also happened more often that these places ran into a deadlock or unique constraints. So I added the try catch here to try an single insert/update/delete first and otherwise do a single update/insert.
Of course it can be that this now collides with the new RetryableTransaction.

https://github.com/shopware/platform/pull/1668#issuecomment-895961473

The sleep call is necessary, because there could be not only 2 but also 10 transactions that are trying out the same records. These run then at the same time into a deadlock and will try at the same time also again an update. This sleep call is just to make sure that this happens a little bit staggered.

https://github.com/shopware/platform/pull/1668#issuecomment-901846298

Perhaps there is a misunderstanding here. The behavior is not unintentional, but rather breaking. We have functions in the core that rely on the event thrown there in the try catch. By changing the entity gateway for the first time the pipeline did not run anymore and tests for duplicate constraints and error reportings were red. Therefore, I played this information back.
However, if this error reporting causes us to have a performance as well as stability loss on the transactions, then I am happy to replace this with an alternative in the next major.
Only as it is now I can't take it into the core because:

It's a breaking change because existing mechanics will be undermined.
The pipelines of us are red.

As discussed with @OliverSkroblin , I will take another look at the PR and will remove the "unnecessary non-batch manual retry" (😅) again. Instead I will refactor the error mapping a bit so it will work with batchwise executions.
With these changes, this PR will add the correct retry logic without breaking the error mapping and without unnecessary retries 👍

Hi Ulrich,
first of all, thank you for looking so deeply into this topic.
As you probably noticed I'm not very active on github, so feel free to ping me in the community chat ;).

What is the community chat? The forum?

Regarding your questions and suggestions:

Add RetryableTransaction, update RetryableQuery to prevent database deadlocks in EntityWriteGateway #1668 (comment)

This has brought some performance optimizations, and it also happened more often that these places ran into a deadlock or unique constraints. So I added the try catch here to try an single insert/update/delete first and otherwise do a single update/insert.
Of course it can be that this now collides with the new RetryableTransaction.

Yes, this conflicts in general with transactions.
This is "more performant" because transactions are shorter and therefore are less likely to deadlock. But this "improvement" comes at a cost, i.e. one indexing action is split into multiple transactions and when an exception occurs, the previous transactions are already committed and the current one fails, thus bringing inconsistency into the data.
Additionally, when the control flow is coming from EntityGateway and it already is in a transaction, this "improvement" is not possible at all.
There are various ways to improve the situation. We can just call, if you want to know my opinion. Might be better than discussing in text form.

Add RetryableTransaction, update RetryableQuery to prevent database deadlocks in EntityWriteGateway #1668 (comment)

The sleep call is necessary, because there could be not only 2 but also 10 transactions that are trying out the same records. These run then at the same time into a deadlock and will try at the same time also again an update. This sleep call is just to make sure that this happens a little bit staggered.

Well, it can stay, it's not seriously problematic, but personally I think it also works when it's not there.

Add RetryableTransaction, update RetryableQuery to prevent database deadlocks in EntityWriteGateway #1668 (comment)

Perhaps there is a misunderstanding here. The behavior is not unintentional, but rather breaking. We have functions in the core that rely on the event thrown there in the try catch. By changing the entity gateway for the first time the pipeline did not run anymore and tests for duplicate constraints and error reportings were red. Therefore, I played this information back.
However, if this error reporting causes us to have a performance as well as stability loss on the transactions, then I am happy to replace this with an alternative in the next major.
Only as it is now I can't take it into the core because:

It's a breaking change because existing mechanics will be undermined.
The pipelines of us are red.

Yes, this might require more than one step. But the current code, and also the code after merging this PR, is just not working correctly. It's either failing more often than necessary, or data consistency can be lost with a deadlock in the worst case.

What is the community chat? The forum?

https://slack.shopware.com/ :wink:


Add fsspec version constraint

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4461971) 100.00% compared to head (a02c05b) 100.00%.
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##            master      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           25        25
  Lines         2363      2362    -1
=========================================
- Hits          2363      2362    -1

Files
Coverage Δ

triad/utils/entry_points.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


generates ... inside of ... - invalid HTML

When the images are rendered inside of paragraphs, this plugins leaves the paragraphs and replaces the <img ... or <a ...><img ... with the newly built <figure ....
That results in <figure> inside of <p> which is invalid html (https://validator.w3.org).

something to look into...


多集群部署与管理: practice/multiple-cluster.md

This article is waiting to be claimed. practice/multiple-cluster.md

/accept

Thank you @dwctua, this issue had been assigned to you.

/assign @zhongfox

本文已发布，https://www.servicemesher.com/istio-handbook/practice/multiple-cluster.html


When to call close?

Hello,
I am using shade in a play application.
I am currently using a singleton for my cache instance:
val cache = Memcached(...)

Is it ok to use it like this?
And when my application ends, I will then call cache.close?  Is this the best practise?

You should definitely call close() to cleanup when your Play app shuts down. I think the best way to do it is via ApplicationLifecycle (see the official docs)

That is what I am doing, just confirming thanks!


Including BCC github repository

In order to help others to find the repository, I suggest to include the github repository.
I faced an issue with warnings when I tried to install the BCC and I could find the solution by installing the BCC through the source code (https://github.com/iovisor/bcc/issues/3366) . I don't know if it could be useful to include this information here somewhere.

There is a reference to the BCC project GitHub and installation instructions on p15 of the book. Is there somewhere else you would like to see it?

There is a reference on p15 of the book but it can't do any harm to add it here too, thanks


2774 make TestTextFilterProcessor running again

Purpose
2773 make TestTextFilterProcessor running again
Remarks

PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no

Already fixed in #2375


feat(vite-plugin-nitro): add internal deployment support for cloudflare

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/analogjs/analog/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Which package are you modifying?

[ ] vite-plugin-angular
[x] vite-plugin-nitro
[ ] astro-angular
[ ] create-analog
[ ] router
[ ] platform
[ ] content
[ ] nx-plugin
[ ] trpc

What is the current behavior?
Extra plugin configuration is needed to deploy to Cloudflare Pages

Closes #
What is the new behavior?
No extra plugin configuration is needed to deploy to Cloudflare Pages
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
[optional] What gif best describes this PR or how it makes you feel?

Hi @brandonroberts 🙂 👋
Any chance you could try to integrate nitro-cloudflare-dev as well here? 😃 🙏

Hi @brandonroberts 🙂 👋
Any chance you could try to integrate nitro-cloudflare-dev as well here? 😃 🙏

@dario-piotrowicz could be doable based on the example @jculvey put together.
https://github.com/jculvey/c3-analog-example

@brandonroberts yeah 🙂
But james' version requires some code in userland, it's not terrible and I'm fine with it, but if we could actually leverage nitro-cloudflare-dev instead that's be nicer
Not a huge deal 🙂


make nan as float

/usr/local/lib/python3.9/site-packages/yfinance/base.py:2126: FutureWarning: Setting an item of incompatible dtype is deprecated and will raise in a future error of pandas. Value 'NaN' has dtype incompatible with float64, please explicitly cast to a compatible dtype first.
dates.loc[dates[cn] == '-', cn] = "NaN"

Fixes https://github.com/ranaroussi/yfinance/issues/1799
I rebased to dev. Old PR was closed https://github.com/ranaroussi/yfinance/pull/1805


Removed services are still doing an ACME refresh

Context:

Removed a service about a month ago
Certificate was still valid at that time, remained valid till the end of April
I would expect the control plane to not refresh the certificate, instead it does

Unable to reproduce at this moment. I have a bunch of certificates expired and not renewed since I removed the stack.


Update chronicle-agent examples, update CI

Background
Closes https://github.com/rstudio/helm/issues/445
Summary

Fixes chronicle-agent yaml example from https://github.com/rstudio/helm/issues/445 feedback
Expands complex-values.yaml test files with the chronicle-agent and a busybox sidecar, which will run in our ci
Fixes some, but not all issues in the connect/workbench complex values that will cause silent templating failures in our ci: https://github.com/rstudio/helm/actions/runs/7133027308/job/19424836827
Updates the chronicle-agent image reference to point to ghcr.io/rstudio/chronicle-agent:2023.10.4, the last agent release

The plan is to eventually condense the server and agent releases into 1, for now they do diverge a bit though

Notes
We are currently failing 1 ci job: https://github.com/rstudio/helm/actions/runs/7132419728/job/19422921712, complaining that we haven't bumped up the chart version in this PR.
We haven't changed the contents of these charts though, just the docs and ci. Bumping up the chart version is unwarranted, so I'm going to ignore this complaint.
This is coming from https://github.com/rstudio/helm/blob/main/.github/workflows/chart-test.yaml#L33, and I don't think ct list-changes is flexible enough to ignore .md or .ci file changes:
% ct list-changed --help

Usage:
  ct list-changed [flags]

Flags:
      --chart-dirs strings        Directories containing Helm charts. May be specified multiple times
                                  or separate values with commas (default [charts])
      --config string             Config file
      --exclude-deprecated        Skip charts that are marked as deprecated
      --excluded-charts strings   Charts that should be skipped. May be specified multiple times
                                  or separate values with commas
      --github-groups             Change the delimiters for github to create collapsible groups
                                  for command output
  -h, --help                      help for list-changed
      --print-config              Prints the configuration to stderr (caution: setting this may
                                  expose sensitive data when helm-repo-extra-args contains passwords)
      --remote string             The name of the Git remote used to identify changed charts (default "origin")
      --since string              The Git reference used to identify changed charts (default "HEAD")
      --target-branch string      The name of the target branch used to identify changed charts (default "master")

hence why i'd rather just ignore this for now - I don't have a good fix in mind.

@shahmonanshi @tnederlof @colearendt I'm  not who sure who the go to for the approval on this PR will be, but I was hoping some of you could take a look and give the okay on these changes. Thank you in advance!

I was thinking we don't need to bump up the chart versions if we're not including any changes to our actual templates in this branch.

@AlexMapley sorry, I don't know much with regards to the CI, @colearendt will likely know more there.

No worries @tnederlof, ty for taking a look anyways. With https://github.com/rstudio/helm/pull/457 we can probably close this branch too soon


Events not firing in Safari

Describe the bug
on:change and on:inputEvents don't fire on ` element in Safari (but they do in Chrome). I don't have Firefox installed so wasn't able to test that.
The simplest example of the bug uses the example code from the book (but it also happened with some of my own code)
Leptos Dependencies
axum = { version = "0.7", optional = true }
console_error_panic_hook = "0.1"
leptos = { version = "0.6", features = ["nightly"] }
leptos_axum = { version = "0.6", optional = true }
leptos_meta = { version = "0.6", features = ["nightly"] }
leptos_router = { version = "0.6", features = ["nightly"] }
tokio = { version = "1", features = ["rt-multi-thread"], optional = true }
tower = { version = "0.4", optional = true }
tower-http = { version = "0.5", features = ["fs"], optional = true }
wasm-bindgen = "^0.2.89"
thiserror = "1"
tracing = { version = "0.1", optional = true }
http = "1"

To Reproduce
Add an event handler to an input event to update a signal.  I even tried the basic example from the book, as well as several of my own.
The simplest example is  a direct copy from the book
pub fn InputFromBook() -> impl IntoView {
    let (name, set_name) = create_signal("Controlled".to_string());

    view! {
        <input type="text"
            on:input=move |ev| {
                // event_target_value is a Leptos helper function
                // it functions the same way as event.target.value
                // in JavaScript, but smooths out some of the typecasting
                // necessary to make this work in Rust
                set_name(event_target_value(&ev));
            }

            // the `prop:` syntax lets you update a DOM property,
            // rather than an attribute.
            prop:value=name
        />
        <p>"Name is: " {name}</p>
    }
}

Expected behavior
It should update the  name to reflect what has been typed in the input.  It only does so in Chrome, but not Safari.

Hm. I just opened up an example client-side-rendering demo, and an example SSR/hydration demo with Axum, and pasted in the example code above, and both of them worked correctly in Safari, Chrome, and Firefox alike. (Safari 17.1 on macos)
Are you sure there isn't something else going on here?

Thanks for looking into it so quickly. It might possibly be an interaction with Thaw. I’ll look into it and get back to you.Sent from my iPhoneOn 3 Mar 2024, at 20:04, Greg Johnston @.***> wrote:
Hm. I just opened up an example client-side-rendering demo, and an example SSR/hydration demo with Axum, and pasted in the example code above, and both of them worked correctly in Safari, Chrome, and Firefox alike. (Safari 17.1 on macos)
Are you sure there isn't something else going on here?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Withdraw collateral

This to allow users to withdraw assets held on their Vega key.

[x] link from wallet sidebar with withdraw page #628
[x] Drop down for selecting asset to withdraw (logic to default to an asset with a non-zero balance) or deep link to a specific asset
[x] input for amount (use max link for all that is in general account)
[x] input for eth wallet to withdraw too (can use connected wallet)
[x] Button to trigger action in connected eth wallet
[x] track transaction progress
[x] handle errors

https://www.figma.com/file/PPZp6wIZmhgTemLrIozO1A/token.vega.xyz?node-id=3977%3A101066

@mattrussell36 I think we can mark this as done?

Yup. Closing!


How do i create an array of objects?

i.e. something like this
"addresses":[
{"type":"work", "address_line1":"val1", "address_line2":"val2"},
{"type"home","address_line1":"val3", "address_line2":"val4" }
]
Is that possible now? or does it require a custom parser to be written?
Thanks! Seems like a promising solution.

I am having a similar issue so thought to re-open this one instead of a new one..
My csv is as follows:
slug,name,image,price,gallery
bloom,bloom,placeholder.png,14.95,image,image
I would like to make an array out of gallery, so that I have the various images as objects to later iterate over them. No matter what kind of brackets etc I use, I can't get it to work, any input would be much appreciated :)


ScrambleStrings

Assigned Issue Number ?
#942
Language Opted ?
C/C++/Python/Java/
Number of files added or updated ?
1/2/3/4/...
Name of these files ?
main folder => sub_folder => ... => ... => ... file.py
example :
Algorithm => Search_Algorithm => Linear_Search => Linear_Search.py
Checklist

[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've fill up this entire template correctly.

Hi @ricky1812 Please fill the PR template correctly.


[Suggestion]: Synced Aggro/Non-Aggro themes.

Description of feature request
Ok, so in short, i'm making a resource pack where the aggro music is a more hyped up version of the non-aggro theme. However, they both restart whenever it switches, what about a toggle (off by default) where the non-aggro and aggro music both sync on the same time, so transitioning is clean.

Might be difficult to implement cleanly but I could look into it


fix: arbitrum check ether balance #97

https://github.com/spearbit-audits/LiFi/issues/97#issuecomment-1246177363


Create account button should link to workers signup

https://dash.cloudflare.com/sign-up/workers

all the buttons in this section go to cloudflare.com

https://docs.google.com/spreadsheets/d/1Fa5e8OniZXCPy3RdMR7B4i5zQpIOzcjhIMh9hfnJ_ZQ/edit#gid=0


test: Create a test factory module

Is your feature request related to a problem? Please describe.

A simple way to generate test fixtures
Describe the solution you'd like

Ability to generate events for different triggers for test fixtures
Describe alternatives you've considered

AWS Sam CLI can generate events, that can be saved to the file system. But ideally this should be done on demand. Also Sam does not support all of the same data classes powertools supports

https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-cli-command-reference-sam-local-generate-event.html

Additional context

@sthulb
Could you explain what is missing in the referenced ticket? I have already created a utility to load fixtures for sample events, and it  is being shared across the parser, event source data classes and the event handler.


[Question] Running App without any display

Shows
Warning: Native Component  for "VRSceneNavigator" does not exist
Warning: Native Component fro "VRTARScene" does not exist
Warning: Native Component fro "VRTText" does not exist
What are the supported devices in android?

Hi @godmode97,
We currently should support devices using Android 4.4 'Lollipop' (API level 21) or above that have proper hardware like a gyroscope and accelerometer. You can try anything higher than 19 and see if it's work.
What device are you using for you app? Are you getting those errors using the Viro Testbed or your own android project?
If it's your own project make your sure do the following:
Run the setup_ide.sh under your project root. This will setup the react-viro package properly so you don't get the errors above.
Further, AR is not supported yet for android. We are actively working on ARCore support which we plan to launch at early Nov in our 2.1 release, so ViroARScene wouldn't work yet, but ViroScene will.
Let me know if you have any more questions or if the above doesn't work for you!

Hi @godmode97 , ARCore for Android should now be supported in the latest release of Viro 2.1.
You can view a list of officially supported devices https://developers.google.com/ar/discover/#supported_devices.
To update, you can view the instructions https://docs.viromedia.com/docs/releases.
Please give it a shot and let us know if you encounter any issues. Thanks!

Closing due to inactivity.
If you still have issues, feel free to re-open this issue or create a new one.
The latest releases are here:
React Viro - https://docs.viromedia.com/docs/releases
ViroCore - https://virocore.viromedia.com/docs/releases
Thanks for using Viro!


Upgrade (or remove) AdGuardHome?

Hi! AdGuardHome has a bug in older versions (https://github.com/AdguardTeam/AdGuardHome/issues/5281) that sets the MTU really low. This has very subtle bugs, including breaking Tailscale subnet routing. It looks like once could override the default AdGuardHome config at /etc/adguardhome.yaml, or we can upgrade the AdGuardHome package, but I can't see that available in the OpenWRT repositories.
edit: My situation is currently remotely accessed, so I'm not trying to change things up on the router side right now, but I have manually set the MTU on the ethernet interface of one of my clients that is providing tailscale subnet routing, and it has fixed this issue.

Do you mean ADG is changing the br-lan MTU? I couldn't replicate the issue on the latest firmware, if you're running an older SmoothWAN version then this may be a problem since ADG used to be the DHCP server.

Do you mean ADG is changing the br-lan MTU? I couldn't replicate the issue on the latest firmware, if you're running an older SmoothWAN version then this may be a problem since ADG used to be the DHCP server.

Ah, didn't realized it changed back to not being the DHCP server. My mistake. I haven't updated in a bit as I've got to set some time aside to copy settings to/from.

Great, updating next version to static binary release instead of OpenWrt repo version due to other missing features as well.


[tool_crash] FileSystemException: Cannot copy file to 'E:\flutternzroproject\nzroprojectsample\android\build.gradle', OS Error: Access is denied., errno = 5

Command
flutter create nzroprojectsample

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot copy file to 'E:\flutternzroproject\nzroprojectsample\android\build.gradle', OS Error: Access is denied.
, errno = 5
#0      _File.throwIfError (dart:io/file_impl.dart:635:7)
#1      _File.copySync (dart:io/file_impl.dart:340:5)
#2      ForwardingFile.copySync (package:file/src/forwarding/forwarding_file.dart:30:50)
#3      ForwardingFile.copySync (package:file/src/forwarding/forwarding_file.dart:30:50)
#4      Template.render.<anonymous closure> (package:flutter_tools/src/template.dart:267:18)
#5      _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:377:8)
#6      Template.render (package:flutter_tools/src/template.dart:190:24)
#7      CreateCommand._renderTemplate (package:flutter_tools/src/commands/create.dart:799:21)
#8      _rootRunUnary (dart:async/zone.dart:1198:47)
#9      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#10     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#11     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#12     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#13     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#14     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#15     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
#16     Template.fromName (package:flutter_tools/src/template.dart)
#17     _rootRunUnary (dart:async/zone.dart:1198:47)
#18     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#19     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#20     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#21     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#22     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#23     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#24     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)

[✓] Flutter (Channel stable, 1.22.0, on Microsoft Windows [Version 10.0.19044.1889], locale en-PH)
    • Flutter version 1.22.0 at C:\src\flutter\flutter
    • Framework revision d408d302e2 (1 year, 11 months ago), 2020-09-29 11:49:17 -0700
    • Engine revision 5babba6c4d
    • Dart version 2.10.0

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[✓] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 50.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[✓] VS Code (version 1.68.0)
    • VS Code at C:\Users\Rauf Mukaram\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.42.0

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.

Flutter Application Metadata
No pubspec in working directory.

@NadeerMukaram
You are on very old version of Flutter. Please upgrade to latest stable (3.0.5) and see if you still get same error or not.
If yes, then there's similar issue open for your reference : https://github.com/flutter/flutter/issues/69116, so follow-up in it.
Closing as duplicate.


zeroc-ice-36: 3.6.3 -> 3.6.5, fix; zeroc-ice: 3.7.2 -> 3.7.6, enable tests; both: clarify license

Motivation for this change

zeroc-ice-36 is broken
zeroc-ice does not run tests
The license for both is specified as gpl2 where gpl2Only is the correct license
Both are out of date

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 135087 run on x86_64-linux 1

1 package failed to build:

zeroc-ice-cpp11

3 packages built:

murmur (murmur_git)
zeroc-ice (zeroc_ice)
zeroc-ice-36

Result of nixpkgs-review pr 135087 run on x86_64-linux 1

4 packages built:

murmur (murmur_git)
zeroc-ice (zeroc_ice)
zeroc-ice-36
zeroc-ice-cpp11

Result of nixpkgs-review pr 135087 at b6266dce run on aarch64-linux 1

4 packages built successfully:

murmur
zeroc-ice
zeroc-ice-36
zeroc-ice-cpp11