doc: Fix CLI doc

Proposed changes

~Update the Becoming a Network Player tutorial with latest CLI~
Some CLI doc minor edits

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (improve a current implementation without adding a new feature or fixing a bug)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Build (changes that affect the build system)
[x] Docs (documentation only changes)
[ ] Test (adding missing tests or fixing existing tests)
[ ] Other... Please describe:

Checklist

[ ] I have read the CONTRIBUTING documentation
[ ] I have read the WRITING DOCUMENTATION guidelines

Links in the checklist are broken.

Rebased and fixed conflicts.

Fixed conflicts again

Thank @rigwild for this contribution!


LuaAPI class not found - needed to start the project

Describe the bug
When attempting to launch the game project on linux, x86_64, 12Gb RAM, the following message appears:

To Reproduce
Steps to reproduce the behavior:
Download the project by cloning the repository, then try to start it with Godot 4.2 stable
Expected behavior
Obviously, this external class should already be included in the project. Do I need to install the LuaAPI extension from the AssetLibrary?
Desktop (please complete the following information):

OS: Ubuntu Linux 2310
Version : latest main branch

Open the project settings, and under Plugins enable LuaAPI and DiscordSDK

Yeah I immediately thought about that, but even though the .gedextension file exists in the addons directory, it doesn't appear in the settings

Ok, I spotted what the error was: I use godot 4.2 and the addon is build for 4.2.1
you maybe should specify this in the readme


Question about get() method

I was taking a look at this fantastic library and I got a bit confused with the behavior of get method.
My example is quite simple. Single activity that fetches pics from Flickr.
In the MainActivity I have the following code (in onResume()):
        disposable.add(searchPhotos
            .flatMap(search -> photoStore.get(search).toObservable()
                .onErrorReturn(Resource::error)
                .observeOn(AndroidSchedulers.mainThread())
                .startWith(Resource.loading())
            )
            .observeOn(AndroidSchedulers.mainThread())
            .subscribe(r -> {
                ptr.setRefreshing(r.isLoading());
                if (r.isSuccess()) {
                    photoAdapter.accept(r.data);
                }
            }, OnErrorNotImplementedException::new)
        );

The Store is created as:
    Store<Resource<FlickrData>, PhotoRequest> providePhotoStore(PhotoService photoService) {
        return StoreBuilder.<PhotoRequest, Resource<FlickrData>>key()
            .fetcher(fetchFlickrPhotos(photoService))
            .memoryPolicy(MemoryPolicy
                .builder()
                .setExpireAfterWrite(TimeUnit.MINUTES.toSeconds(10))
                .setExpireAfterTimeUnit(TimeUnit.SECONDS)
                .build())
            .open();

And the key is an object PhotoRequest that is basically as the following:
@AutoValue
public abstract class PhotoRequest implements Parcelable {
    public abstract String search();
    public abstract Integer page();
}

The app fetches 20 items/page and when the user scrolls to the bottom of the app, it fetches the next page.
I have noticed the following in the following use case:
Scenario:

Scroll to get three pages
home the app
get back to the app

Expected behavior:

the last search object has page() == 3

Behavior:

the store however returns all the items previously fetched (all 3 pages == 60 items).

Why is that?
Thanks for this fantastic library.

Not sure why it would be returning all the previously fetched items for when the key has a page() == 3. We don't append responses to each other. Which Flickr api are you using? I'll try to duplicate it on my end.

My apologies! Just debug my sample app and it was a bug in my adapter :D
I will close the issue!


jnp.isfinite bug

Description
jnp.isfinite triggers cuda error.
import jax.numpy as jnp

jnp.isfinite(jnp.array([1,2]))

error:
2023-02-28 17:05:29.820789: E external[/org_tensorflow/tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:429](https://vscode-remote+ssh-002dremote-002b192-002e168-002e68-002e103.vscode-resource.vscode-cdn.net/org_tensorflow/tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:429)] Could not create cudnn handle: CUDNN_STATUS_INTERNAL_ERROR
2023-02-28 17:05:29.822036: E external[/org_tensorflow/tensorflow/compiler/xla/status_macros.cc:57](https://vscode-remote+ssh-002dremote-002b192-002e168-002e68-002e103.vscode-resource.vscode-cdn.net/org_tensorflow/tensorflow/compiler/xla/status_macros.cc:57)] INTERNAL: RET_CHECK failure (external[/org_tensorflow/tensorflow/compiler/xla/service/gpu/gpu_compiler.cc:626](https://vscode-remote+ssh-002dremote-002b192-002e168-002e68-002e103.vscode-resource.vscode-cdn.net/org_tensorflow/tensorflow/compiler/xla/service/gpu/gpu_compiler.cc:626)) dnn != nullptr
*** Begin stack trace ***
	_PyObject_MakeTpCall
	_PyEval_EvalFrameDefault
	_PyEval_EvalFrameDefault
	_PyFunction_Vectorcall
	_PyEval_EvalFrameDefault
	_PyEval_EvalFrameDefault
	_PyFunction_Vectorcall
	PyObject_Call
	_PyEval_EvalFrameDefault
	_PyFunction_Vectorcall
	_PyEval_EvalFrameDefault
	_PyEval_EvalFrameDefault
	_PyFunction_Vectorcall
	_PyEval_EvalFrameDefault
	_PyFunction_Vectorcall
	_PyEval_EvalFrameDefault
	_PyFunction_Vectorcall
	PyObject_Call
	_PyEval_EvalFrameDefault
	_PyFunction_Vectorcall
	_PyEval_EvalFrameDefault
	...

GPU

### Additional system info

Python 3.9.15

### NVIDIA GPU info

+-----------------------------------------------------------------------------+
| NVIDIA-SMI 525.85.05    Driver Version: 525.85.05    CUDA Version: 12.0     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA GeForce ...  Off  | 00000000:01:00.0 Off |                  N/A |
|  0%   38C    P8     9W / 250W |  11146MiB / 11264MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A    350485      C   ...a3/envs/jaxai2/bin/python    10692MiB |
|    0   N/A  N/A    354089      C   ...a3/envs/jaxai2/bin/python      450MiB |
+-----------------------------------------------------------------------------+

I think actually that's a symptom of you running out of GPU memory.
You appear to be running two JAX processes on the same GPU. See also https://jax.readthedocs.io/en/latest/gpu_memory_allocation.html
The error message could be improved, certainly.

I am using on Jupyter/VSCode/Remote.
I have two notebooks with the same code and using the same environment.
I added %env XLA_PYTHON_CLIENT_MEM_FRACTION=0.2 in the first cell.
I kill all processes and check nvidia-smi: 100% of memory available.
I run in one of the notebooks and it works.
I kill all processes and check nvidia-smi: 100% of memory available.
I run in  the other notebook and it fails.  (I even tried to copy the file that works but ... no, it is does not work).
I also tried cloning the environment and updating jax in one of them and the same error happens with jax 0.4.4
I am monitoring my GPU memory usage and it is never over 40%.  I believe you are right that there is a memory leak somewhere and maybe it is not jax related, but I have no idea on how to debug.
¯_(ツ)_/¯.
BTW, in the notebook where it fails, if I use numpy (which I guess moves the computation to the cpu), it works.
np.isfinite(jnp.array([1.,2])) works.


Fire "Calculating" echo with monotonic clock

If the system clock is rolled back after the timeout
is set, the echo may not fire.
Using a monotonic clock ensures that it fires at or
after LONGTIME has elapsed.

This looks good.  Thanks.


Layout options for folder content display

What's the Problem?
Current layout for folder content is very spacious, nice to the eye but little useful for frequent file operations. Currently the display seems to about 50% larger than the default windows explorer density.
Solution/Idea
Offer something like most email programs offer: 3 different density settings, like comfortable, compact and tense? Or at least a line height setting.
Alternatives
No alternatives, currently it seems to be a fixed setting.
Priorities
Would be nice to have and improve usability
Files Version
Version: <IP_ADDRESS>
Windows Version
OS Version: 10.0.19042.1348
Additional comment
No response

Merging with #1940


Opening the finder causes syntax highlighting to change?

Describe the bug
Opening the finder causes syntax highlighting to change. Very strange behaviour, visible here:
https://user-images.githubusercontent.com/6242344/227183058-7f7c9fc7-d3d6-4917-9d37-809041d08394.mov
syntax, colorscheme and filetype are all correct before and after the change. Are you aware of anything that might cause this? It wasn't happening before I updated to the latest version of this plugin.
Steps to reproduce
Install the plugin and tokyonight, this is run on a Typescript file. Can provide minimal recreation or further details if needed
Expected behavior
The highlighting does not change.
Neovim version (nvim -v)
NVIM v0.8.3
lspsaga commit
44ae62d
Terminal name/version
iTerm2, Build 3.4.19

oh it need disable syntax when close finder  in 0.8.3 . but currently the finder had rewrite in next version . so probably you need wait the next version merge ...because most bugfix I do it in new version ..

Ok, no problem, thanks. Shall I leave this open until the next version lands?


kvstore: drop support for ca-file field in etcd client config

The usage of the ca-file field was removed in etcd v3.4. Support in Cilium was deprecated in 1.7 by commit 50867c809d58 ("etcd: use ca-file field from etcd option if available") with targeted removal in Cilium 1.8. Enough time has passed since then. Remove the backwards compatibility wrapper.
Drop support for the ca-file field in etcd client config, deprecated in Cilium 1.7.

/test


Search bar with multi select dropdown

Features

When search is performed, should display a dropdown.
Search function should take place after typing 3 letters minimum, and then display the dropdown.
Items on dropdown should be selectable.
Should be able to submit selected data.

Design URL for specs : https://xd.adobe.com/view/809c4f44-9861-4f57-978a-e2d3515a426e-d5cf/
Default search field

Search input with text entered

Search input with selected fields

Search input and submit data button

@shanaka-rajitha comments on design:

Search input with selected fields

The selection design needs more work. The screenshot depicts multiple rows checked, but only single string Randy is contained within searchbox instead of multiple. Please design the proper textbox selection for multi selection as well.
Also the gap between textbox and dropdown is way too much. See law of proximity.

Search function should take place after typing 3 letters minimum, and then display the dropdown.

What's reasoning for 3 letters minimum? Wouldn't it be better to show results right away so that people don't think it doesn't work?
I would suggest having a look at how Fluent solves these issues and use it as base. Will save both design and development time.
I am also not convinced about checkbox selection. This seems like better suited for ui.table which provides checkbox selection together with search capability. We can provide a flag to render the table columnless + borderless if needed.

Including @mtanco @iamabhishekmathur

I would suggest having a look at how Fluent solves these issues and use it as base. Will save both design and development time.

@sandruparo @shihan007 team can you have a look at this and update the designs accordingly.


No Acient Cities are generated

Describe the problem
see title
What Should Happen
Ancient Cities should be generated
What Biome
Deep Dark
Object Id
No response
Minecraft Version
1.20
Iris Version
v2.7.1-1.20.1
Relevant log output. (IF APPLICABLE)
No response
Checklist

[X] I am using an unmodified version of the overworld. (If you modified the overworld and see an issue, contact support)
[X] I am using the latest version of the overworld OR I have made sure this issue was not already resolved on the latest version.
[X] I am using Spigot, Paper, Tuinity, or Purpur. (If you are not, and still think it is a valid issue, contact support)

known issue il add them soon

/ i was working on that tdy actually

any updates?

coming soon there is already a dev version


trim blb eip name

Fix #58

Hi @hello2mao,
We noticed that CodeLingo has been failing for you lately and you decided to uninstall. We're working on a fix for it now. How would you have preferred for us to support you? Would it help to get a message from the CodeLingo team on your PRs when the bot fails or hangs?
Also, we're just in the process of making PRs to all of our installed orgs to demonstrate our new tenets. Is there any main repo that you'd like us to run make a PR to?


sort alphabetical

🚀 should be useful 🤷♂

🎉

Phew! That looks like them all! 😄
I'll try to keep up to date on these a little more often - sorry for the million of emails you probably received! 😉


Make MetricRegistry extendable so that clients can use specialized metrics

(This PR is a follow-up of thread on metrics user group: https://groups.google.com/forum/#!searchin/metrics-user/sampling/metrics-user/aaI_eDuor_I/R41D-4MufOsJ)
This PR introcudes changes that allow clients of Metrics library to create their own specialized versions of MetricRegistry that could handle client-specialized versions of metrics e.g. specialized Timer.
In particular, in our case we want to introduce the notion of sampling (downsampling) for metrics. The reason for that is that in our high performance services we observe significant drop in performance when we use timers. The drop we observe varies from few up to 15%. The latter figure relates to the case where service covered by timer returns very simple response.
The changes proposed in this PR enable client of metrics library to create a specialized version of MetricRegistry (as subclass) that can create and register specialized versions of metrics (also using subclassing). For that we need access to getOrAdd() from subclasses.
When it comes to another change with Context access modifier:
This change is required as specialized version of Timer class may require to have different behaviour for  Timer.Context. In specialized version of Timer we have to subclass so that new timer can be registered and then picked up for reporting purposes. However inheritence requires that our new timer returns Context on time() call. Currently, as Timer.Context has only private constructor it cannot be subclassed.
In our case we created NoOpContext context that does not perform any operation, and as a result time is not measured. Our SampledTimer returns NoOpContext always but every N-th time (N is sampling factor) where normal Context is returned.
Alternative approach would require making Context an interface (as here: https://github.com/engineerMike/metrics/commit/68e2c355ccd7b6a2cde391b221d870188ed92459). But it is more invasive approach.
In future we consider putting together metrics-sampling plugin that would contain all logic around sampling -- especially if others need that feature (let us know!). It could be maintained separately as Ryan's metrics-spring (https://github.com/ryantenney/metrics-spring) or merged.

This will be supported in v4.


Usage of format string literal necessitates Python 3.6

https://github.com/chromano/wi/blob/ee5ddf40c62a28524fa205143cb97d5e94792610/wi#L102
Since the usage is so trivial, it would be nice if a more backwards-compatible approach were used instead.

Or .. https://github.com/asottile/future-fstrings ;-)
But I agree with removing the fstrings for projects/situations like this where simplicity and backwards compatibility are beneficial to users.

Much appreciated. Also did not know about future-fstrings, very useful 🙏

@evictor I totally agree with you. Also, I think it makes sense to go a little further and wrap any prints with a log or output function.


Added fonts will not display when the computer is restarted, and restarting the font cache fixes it.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.92.2
OS Version: Version: Windows 11 (Windows_NT x64 10.0.22631)

When the font is messed up:

After restarting the font cache and restarting VS Code:

Steps to Reproduce:

Enable a new font within VS Code. Specifically, enable Fira Code with font ligatures.
Restart VS Code and code for a few minutes.
Exit VS Code.
Put the computer to sleep.
Wake the computer and open VS Code.
The font now changes to monospace or any default font set below "Fira Code."
Open Windows services.
Restart Windows font cache service.
Restart VS Code.
Font now appears as Fira Code.

Duplicate of #173543 but thanks for the steps!


chore: update ce sdk version and codegen

Updates the cloudevents sdk to support CESQL v1

Proposed Changes

Update the cloudevents sdk
Update codegen (this led to an unrelated format change)

Release Note

The CESQL filter dialect now supports the CESQL v1 specification (https://github.com/cloudevents/spec/releases/tag/cesql%2Fv1.0.0)

/cc @pierDipi @matzew @creydr
/hold until we have an equivalent PR to update the go SDK in eventing core

/test upgrade-tests

/test upgrade-tests

/unhold

/retest-required

/retest-required

/retest

/retest-required

/retest

/retest

/retest

/test upgrade-tests


Windows path conflicts with glob paths

Hello,
I recently wanted to migrate my project to use your auto-route module, but when I finished all my routes were gone (I got 404s when I tried to GET them).
Then i logged out the finished route names in your module:

As you can see, the glob routes are ../../ but when I path.resolve("./routes/"), windows returns ..\..\..
I wrote this quick fix which works for my windows system in both cases.

Let me do some check before i merge this, i want to be sure this does not affect other systems, i hate that windows does not follow POSIX standards :laughing:

released as version<EMAIL_ADDRESS>Thanks for the pr :)

@GiovanniCardamone
Thanks for merging, but when I install version 2.1.2 the code is the same as 2.1.1. Maybe you forgot to build?

oh gosh! D: yes i did, i have to really set up automatic build and deploy for this package

<EMAIL_ADDRESS>


FR: Jetty Quickstart should be supported

Jetty Quickstart was developed for GAE and is a part of both existing maven plugins.  We should support it somehow in all the new ones. blog

sounds good. Please file an issue for that.
On Thu, Jul 7, 2016 at 4:18 PM, Les Vogel<EMAIL_ADDRESS>wrote:

Jetty Quickstart
http://www.eclipse.org/jetty/documentation/9.4.x/quickstart-webapp.html
was developed for GAE and is a part of both existing maven plugins. We
should support it somehow in all the new ones. blog
https://webtide.com/jetty-9-quick-start/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/issues/155,
or mute the thread
https://github.com/notifications/unsubscribe/AA9X6NsSnzVR_R77f4qsxWReP1VdxiZoks5qTV78gaJpZM4JHdXn
.

--
Elliotte Rusty Harold
<EMAIL_ADDRESS>


Fix #497: upgrade to knative 0.4.0

This upgrades both Knative eventing and serving to 0.4.0 (eventing 0.4.0 depends on serving 0.3.0 but it does not seem a strict requirement).
All those libraries require different version of the kubernetes api, so I've forced the one required by operator-sdk, since we only use structs from prometheus or knative.
I've just tested it on Minishift.

Just 1360 files.. This little/useless PR :-)


Strict Query String Matching?

This expectation
        mockServer.when(
                request()
                        .withMethod("GET")
                        .withPath("/companies/")
                        .withQueryStringParameter("acctNum", "1234567")
        ).respond(
                response()
                        .withHeaders(
                                new Header(HttpHeaders.Names.CONTENT_TYPE, "application/json")
                        )
                        .withBody("{\"items\":[]}"))
        );

Matches even if there are additional query parameters.  Is there a way to be more strict with the expectation (and verification)?  For instance, if there are any additional query parameters I would like this to fail to match.  Example of the situation I'd like matching to fail included below.
2015-09-16T16:57:47,908 INFO nioEventLoopGroup-10-3 -  - HttpRequestMatcher.infoLog - request:

	{
	  "method" : "GET",
	  "path" : "/companies/",
	  "queryStringParameters" : [ {
	    "name" : "acctNum",
	    "values" : [ "1234567" ]
	  }, {
	    "name" : "random",
	    "values" : [ "thing" ]
	  } ],
	  "headers" : [ {
	    "name" : "Accept",
	    "values" : [ "application/vnd.manheim.v1+json" ]
	  }, {
	    "name" : "Authorization",
	    "values" : [ "Bearer AUTHTOKEN" ]
	  }, {
	    "name" : "Content-Type",
	    "values" : [ "text/plain;charset=ISO-8859-1" ]
	  }, {
	    "name" : "Accept-Charset",
	    "values" : [ "big5, big5-hkscs, cesu-8, euc-jp, euc-kr, gb18030, gb2312, gbk, ibm-thai, ibm00858, ibm01140, ibm01141, ibm01142, ibm01143, ibm01144, ibm01145, ibm01146, ibm01147, ibm01148, ibm01149, ibm037, ibm1026, ibm1047, ibm273, ibm277, ibm278, ibm280, ibm284, ibm285, ibm290, ibm297, ibm420, ibm424, ibm437, ibm500, ibm775, ibm850, ibm852, ibm855, ibm857, ibm860, ibm861, ibm862, ibm863, ibm864, ibm865, ibm866, ibm868, ibm869, ibm870, ibm871, ibm918, iso-2022-cn, iso-2022-jp, iso-2022-jp-2, iso-2022-kr, iso-8859-1, iso-8859-13, iso-8859-15, iso-8859-2, iso-8859-3, iso-8859-4, iso-8859-5, iso-8859-6, iso-8859-7, iso-8859-8, iso-8859-9, jis_x0201, jis_x0212-1990, koi8-r, koi8-u, shift_jis, tis-620, us-ascii, utf-16, utf-16be, utf-16le, utf-32, utf-32be, utf-32le, utf-8, windows-1250, windows-1251, windows-1252, windows-1253, windows-1254, windows-1255, windows-1256, windows-1257, windows-1258, windows-31j, x-big5-hkscs-2001, x-big5-solaris, x-compound_text, x-euc-jp-linux, x-euc-tw, x-eucjp-open, x-ibm1006, x-ibm1025, x-ibm1046, x-ibm1097, x-ibm1098, x-ibm1112, x-ibm1122, x-ibm1123, x-ibm1124, x-ibm1364, x-ibm1381, x-ibm1383, x-ibm300, x-ibm33722, x-ibm737, x-ibm833, x-ibm834, x-ibm856, x-ibm874, x-ibm875, x-ibm921, x-ibm922, x-ibm930, x-ibm933, x-ibm935, x-ibm937, x-ibm939, x-ibm942, x-ibm942c, x-ibm943, x-ibm943c, x-ibm948, x-ibm949, x-ibm949c, x-ibm950, x-ibm964, x-ibm970, x-iscii91, x-iso-2022-cn-cns, x-iso-2022-cn-gb, x-iso-8859-11, x-jis0208, x-jisautodetect, x-johab, x-macarabic, x-maccentraleurope, x-maccroatian, x-maccyrillic, x-macdingbat, x-macgreek, x-machebrew, x-maciceland, x-macroman, x-macromania, x-macsymbol, x-macthai, x-macturkish, x-macukraine, x-ms932_0213, x-ms950-hkscs, x-ms950-hkscs-xp, x-mswin-936, x-pck, x-sjis_0213, x-utf-16le-bom, x-utf-32be-bom, x-utf-32le-bom, x-windows-50220, x-windows-50221, x-windows-874, x-windows-949, x-windows-950, x-windows-iso2022jp" ]
	  }, {
	    "name" : "User-Agent",
	    "values" : [ "Java/1.8.0_51" ]
	  }, {
	    "name" : "Host",
	    "values" : [ "localhost:1080" ]
	  }, {
	    "name" : "Content-Length",
	    "values" : [ "0" ]
	  } ],
	  "keepAlive" : true,
	  "secure" : false
	}

 matched expectation:

	{
	  "method" : "GET",
	  "path" : "/companies/",
	  "queryStringParameters" : [ {
	    "name" : "acctNum",
	    "values" : [ "1234567" ]
	  } ]
	}

This is a good idea but it will be covered in #180, please add any additional comments to that ticket


There is a way to intercept carousel navigation changes?

Is your feature request related to a problem? Please describe.
It's not a problem. I just want more flexibility to tweak some custom behaviors I have in my use case.
Describe the solution you'd like
I would like a way to add a callback function to be called every time a navigation happen in the carousel.
Describe alternatives you've considered
Maybe a new prop in the <Carousel /> component to pass a callback function that receive as arguments the next and previous slide.

This would be super useful to be able to listen to an event called @change for example, so I know the current index value of the carousel.

Hi there,
On mobile when you are scrolling on the page and you scroll down the page over the carousel it changes the slide and It would be great to have something like that to intercept this behavior.
Regards

Use case: I need to load some content on the slide only when it becomes visible (or close to be visible).
The ideal would be to have a @change event as suggested by @leifriksheim
<carousel @change="changed">
  <slide>toto</slide>
  <slide>titi</slide>
  <slide>tata</slide>
</carousel>

//...
methods: {
  //...
  changed(page, event) {
    console.log('Carousel is showing the page:', page);
    console.log('Direction', event.direction);
    console.log('Previous slide index', event.previousSlideIndex);
    console.log('Change type', event.changeType); // touch|navigation|api
  },
},

Other events would be useful too:

@slide-start
@slide-end
@loop (just cycled)

And maybe some events directly on a specific slide:

@enter
@leave


Frontend: ProductPage

User story
Who: As a developer
What: I want to implement a ProductPage container
Why: Users should be able to see a single Product page with details of that product.
Acceptance criteria

Check the wireframes here:
https://www.figma.com/file/yo4QT2EcPo83HAMI3ydMxb/HYF-Wireframes?node-id=216%3A28468
Implementation details

Closing this issue since I have no idea what is happening with the components that are required to make the ProductPage container.


DE43 regex needs to updated

The DE43 regex makes an assumption about the DE43_POSTCODE field, that it will always be 4-10 contiguous non-whitespace characters. However, not all postal codes particularly for non-US locations adhere to that. For instance, British postal codes can contain a space partway through, which causes the regex match to fail. And Irish postal codes are three characters. I propose updating the default regex to be
r"(?P<DE43_NAME>.+?) *\\(?P<DE43_ADDRESS>.+?) *\\(?P<DE43_SUBURB>.+?) *\\(?P<DE43_POSTCODE>.+?) *(?P<DE43_STATE>.{3})(?P<DE43_COUNTRY>.{3})$"}

For reference, the current regex is
r"(?P<DE43_NAME>.+?) *\\(?P<DE43_ADDRESS>.+?) *\\(?P<DE43_SUBURB>.+?) *\\(?P<DE43_POSTCODE>\S{4,10}) *(?P<DE43_STATE>.{3})(?P<DE43_COUNTRY>.{3})"

Thanks for reporting this.. I have not looked deeply into international postcode formats so this seems like a reasonable approach.. I'll make some updates shortly and release an update.

The final regex I have come up with is:
(?P<DE43_NAME>.+?) *\\(?P<DE43_ADDRESS>.+?) *\\(?P<DE43_SUBURB>.+?) *\\
(?P<DE43_POSTCODE>.{10})(?P<DE43_STATE>.{3})(?P<DE43_COUNTRY>\S{3})$

That looks reasonable to me!

Great. I'll release an update with this change over the weekend.

Updated in a1cbf0ee and released as v0.6.1.

Wonderful, thanks!


Strip slashes to fix Windows issue.

This should make it possible to (finally) run Humbug on Windows. Currently it manages to detect line coverage just fine after the initial test run, but while running the actual mutation testing it marks every test with a S (uncovered).
I managed to track the issue down to the coverage.humbug.[hash].cache file, more specifically the name of the cache file. On Windows all the file paths' backslashes are escaped in the coverage report (coverage.humbug.php), so C:\Path\To\My\File.php would be C:\\Path\\To\\My\\File.php and this is the path being md5'd for the filename of the cache. To retrieve this cache file later the method loadCoverageFor() is called with a file path, this path however isn't escaped so the method would end up with a different hash and thus can't find the cache file.
Not sure if stripslashes() will end up removing other things in weird cases, but it felt like a cleaner solution than str_replace('\\\\', '\\', $matches[1]).

Thanks!


Redesign Footer Section for Enhanced UI

Redesign of Footer Section
Current Issue:
The current footer layout (shown below) lacks a modern design and better structure:

Proposed Changes:
I propose the following improvements for the footer:

Logo: Center-align the logo for a more balanced look.
Layout:

Create separate sections for "About," "Legal," and "Social Media Links."
Update spacing and padding for better readability.

Styling:

Improve font styling (use modern fonts, adjust sizes).
Add hover effects on social media icons.

I would like to work on this.
Please assign it to me under gssoc-ext and hacktoberfest.

Hyy @T-Fathima, I'm assigning this issue to you,

Hyy @T-Fathima, Can you do star to this repo?

Hyy @T-Fathima, Can you do star to this repo?

Yes sure done


[netcore] Compact protocol encoding + negotiation

🚀 Feature Request
Our current protocol negotiation protocol is a bit chatty, even when done optimistically. For example, every consensus rpc call requires a constant overhead of 58 bytes per request from our optimistic negotiation protocol.
[ open substream ]
> <u16-prefix>/libra/protocol-select/1.0.0
> <u16-prefix>/libra/consensus/rpc/1.0.0
> <uvarint-prefix><protobuf RPC request>
< <uvarint-prefix><protobuf RPC response>

The overhead of the protocol-select and consensus/rpc protocol announcements is:
58 bytes = 2 + 28 + 2 + 26.
Instead of transmitting the full u16-prefixed byte-strings, e.g., "/libra/protocol-select/1.0.0", we could encode each protocol as a single uvarint and maintain the plaintext mapping for debugging. In other words, "/libra/protocol-select/1.0.0" <=> 0x0a and "/libra/consensus/rpc/1.0.0" <=> 0x0b. Then the optimistic negotiation overhead is just 2 uvarints, which for most cases will be just 2 bytes.
Additionally, we could encode the version string separately and follow semver when upgrading network protocols. For instance,
"/libra/protocol-select/1.0.0"
    <=> <protocol-id> <uvarint-prefix> <semver-string>
    <=> 0a            05               31 2e 30 2e 30

Note: I need to imagine a concrete use-case where making a semver-backwards-compatible version bump on a network protocol actually makes sense... otherwise, we can just fold-in the version into the protocol-id and only explicitly handle backwards-incompatible upgrades.
cc @bothra90

Closed by new compact handshake protocol PR #3358


User preferences, stored on server against account

Leads to:  room css option, theme url option (to get themes out of config files and cross platform), a place to put last.fm details, frees us from config files now we're cross-platform.

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

Also prefs page could have optional reddit-like "flair", e.g. national flag shown next to username

Also prefs page could have optional reddit-like "flair", e.g. national flag shown next to username

Once server side themes are available - please add a text only one.
Having soundbounce in weechat style would be soo good (and most likely so much faster)
LIttle mockup:

That theme is very similar to Anita's dark minimal, check it out here https://dl.dropboxusercontent.com/u/98755356/Soundbounce_Themes/themes.html#

is it possible to use themes on the mac osx version? the theme patch only modifies stuff in the windows builds

Currently no, but we're moving the themes to be stored in user prefs on server, not locally in client, so will work on all platforms once that's done.


Implemented toMavenString method

https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html

@bbleiberg Updated PR. Please have a look

@ken-duck  Updated PR. Please have a look


Feature/Invoke-PnPGraphMethod

Type

[ ] Bug Fix
[x] New Feature
[ ] Sample

Related Issues?
Fixes #873
What is in this Pull Request ?
Add a new command Invoke-PnPGraphMethod to invoke generic Microsoft Graph API Methods.

Updated GraphHelper to support additional headers on all methods
json utility to convert to PSObject/object
updated src/Commands/Base/InvokeSPRestMethod.cs to use json convert utility
implemented src/Commands/Graph/InvokeGraphMethod.cs
docs for Invoke-PnPGraphMethod

Thanks @4ndri  for this amazing cmdlet and the PR !
Have merged it and it should be available in tomorrow's nightly !
Much appreciate your contribution


Unable to resolve NULL driver for [Akaunting\Setting\Manager].

I tried to install the setting module but facing an issue that is showing
Unable to resolve NULL driver for [Akaunting\Setting\Manager].
Can you please check and provide a solution to fix the error.

You should set the correct driver in config file


add MCOPY opcode

To be in Cancun.
in Solidity 0.8.24:
https://soliditylang.org/blog/2024/01/26/solidity-0.8.24-release-announcement
https://eips.ethereum.org/EIPS/eip-5656

Thanks, we will update to cancun before it officially starts


Support for non-root test users

This commit provides the ability for board farm administrator to have tests run on a lan and wan device using a non-root user. To actually do so, an administrator would do the following:
Create a test user with password on the lan and wan devices
I have a user named "tester" with the password "test"
Clone the boardfarm git repo to your LAN and WAN devices
We need some scripts to run directly on the LAN and WAN devices. To do this, we clone the boardfarm git repo to our LAN/WAN device. I actually clone it via sudo into /opt/boardfarm.
Run prepare_for_nonroot on the LAN and WAN devices
prepare_for_nonroot gets the system into a state where it can function as a lan or wan device with tests running as a nonroot user. prepare_for_nonroot's command line works as follows.
prepare_for_nonroot lan|wan --user test_user_name
If you don't have --user in the argument list, it defaults to tester.
Reboot the LAN and WAN computers
Add the LAN and WAN username and password to your json config
bft knows that if you provide a username other than root that you are running the tests as non-root and adjusts accordingly.
Run bft like normal
I'll add this to documentation once I get approval from folks but this is a big enough change that I'd like to get a once over from some other team members. Any thoughts @miska @mattsm @mbanders?

This is pretty big change, let's think about it a bit. Don't like the idea of having to run stuff on the LAN/WAN though. Could we have a one time password request to install the required items?

It's certainly not a change to commit overnight :)
I could modify prepare_for_nonroot to ssh to the lan/wan device and run all of the important setup I think.

No updates in a long time, going to close


[Bug]: Sensors not updating themselves, error setting up sensors

What happened?
Hello Klaus,
I had a issue with sensor sensor.clagehomeserver_bila_koupelna_consumption_energy which did not update itself, it got loaded when the home assistant has been restarted but then it stayed the same till the restart of Hassio. Then I noticed in logs that there is a problem with another sensors as below:
From 3 energy sensors:
sensor.clagehomeserver_bila_koupelna_heater_status_power - shows actual realtime energy consumption
sensor.clagehomeserver_bila_koupelna_consumption_energy - gets updated only when hassio is restarted
sensor.clagehomeserver_bila_koupelna_heater_setup_totalpowerconsumption - is unavailable with the error message down below. [In clage smart app the status called total Power/Water consumption is 0.0 kW / litres)
The same is true for the 3 corresponding water sensors.
Also the sensor: sensor.clagehomeserver_bila_koupelna_number_of_watertaps is updated only when hassio is restarted.
I have heater software version DSX3CP-v1.1.11 - which smart app is not letting me update, but I have not yet tried to update it on the heater itself.
Can I try something to help diagnose the issue?
Thank you very much
Version
latest
What version of Home Assistant are you seeing the problem on?
2021.11.
Relevant log output
Logger: homeassistant
Source: custom_components/clage_homeserver/sensor.py:602
Integration: CLAGE Homeserver (documentation, issues)
First occurred: November 22, 2021, 8:01:48 AM (12802 occurrences)
Last logged: 11:34:11 AM

Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 134, in _handle_refresh_interval
    await self._async_refresh(log_failures=True, scheduled=True)
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 265, in _async_refresh
    update_callback()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 325, in _handle_coordinator_update
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 486, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 519, in _async_write_ha_state
    state = self._stringify_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 492, in _stringify_state
    if (state := self.state) is None:
  File "/config/custom_components/clage_homeserver/sensor.py", line 602, in state
    return self.coordinator.data[self.homeservername][self._attribute]
KeyError: 'heater_setup_totalPowerConsumption'

-----------

Logger: custom_components.clage_homeserver
Source: custom_components/clage_homeserver/__init__.py:129
Integration: CLAGE Homeserver (documentation, issues)
First occurred: November 24, 2021, 7:40:59 AM (73 occurrences)
Last logged: November 24, 2021, 8:10:59 AM

Unexpected error fetching clage_homeserver data: 'NoneType' object is not subscriptable
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 187, in _async_refresh
    self.data = await self._async_update_data()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 147, in _async_update_data
    return await self.update_method()
  File "/config/custom_components/clage_homeserver/__init__.py", line 129, in fetch_states
    await self._hass.async_add_executor_job(homeserver.requestStatus)
  File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.9/site-packages/clage_homeserver/clage_homeserver.py", line 369, in requestStatus
    response = ClageHomeServerMapper().mapApiStatusResponse(status)
  File "/usr/local/lib/python3.9/site-packages/clage_homeserver/clage_homeserver.py", line 29, in mapApiStatusResponse
    heater = status.get('devices')[NUMBER_OF_CONNECTED_HEATERS-1]
TypeError: 'NoneType' object is not subscriptable

----

Logger: homeassistant.components.sensor
Source: custom_components/clage_homeserver/sensor.py:602
Integration: Sensor (documentation, issues)
First occurred: November 22, 2021, 8:01:27 AM (2 occurrences)
Last logged: November 22, 2021, 8:01:27 AM

Error adding entities for domain sensor with platform clage_homeserver
Error while setting up clage_homeserver platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 382, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 607, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 715, in add_to_platform_finish
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 486, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 519, in _async_write_ha_state
    state = self._stringify_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 492, in _stringify_state
    if (state := self.state) is None:
  File "/config/custom_components/clage_homeserver/sensor.py", line 602, in state
    return self.coordinator.data[self.homeservername][self._attribute]
KeyError: 'heater_setup_totalPowerConsumption'

Hi @O-Palda ,
I have the same version of the homeserver. The update via App does not work for me either. An error message, about file access, that I could not solve.
I will have a look and come back later.

Thank you a lot, sadly I am not a programmer, I tried to access the homeserver through console and utilize "total" parameter as defined in section 3.5 of the documentation that should probably sent only the total consumption without all previous watertaps, but I was not able to sent the parameter right, it always returned all watertaps and it took few seconds (currently we are at 9276 taps), but this parameter could enable faster response from homeserver?
If I looked at the python source code of the library I think that it gets totals by enumeraring all watertaps?

I have drafted a new version; we can test it now in HA.

Hi Klaus,
I have updated the addon and all errors are gone from the log.
The totals now correspond to the "Last 4 years" statistics in Clage smart app.
Litres are spot on, energy differs by 0.3 kWh (smart app shows bigger number as 980.3 kWh), I will check it after evening shower how will it change on both.
Thanks a lot :)

Hi Klaus,
I have tried to create a pull request, but I have failed spectacularly :/ as it has been added as pull request to my fork instead https://github.com/O-Palda/clage_homeserver/pull/1
I have basically increased the precision to two (electricity) and one (water) in totals and removed the final rounding as it seemed to me as redundant.
I can see that today I have consumed 2.48 kW and 87.2 l so these decimals seems better to me for statistical purposes. It also lines nicely with the clage smart app.
I have modified line 334 and 335:
       consumption_energy = round(int(heater_logs.get('power'))/1000,1)    # power	uint32_t	1/1 Wh	6 Wh	Energy demand in kWh, it is energy(kWh) not power (kW)
        consumption_water = round(int(heater_logs.get('water'))/100,0)      # water	uint32_t	1/100 l	0,42 l	Amount of water used in liters
        consumption_energy = round(int(heater_logs.get('power'))/1000,2)    # power	uint32_t	1/1 Wh	6 Wh	Energy demand in kWh, it is energy(kWh) not power (kW)
        consumption_water = round(int(heater_logs.get('water'))/100,1)      # water	uint32_t	1/100 l	0,42 l	Amount of water used in liters

and 340, 341:
'consumption_energy': round(consumption_energy,0),               # Total energy in kWh
'consumption_water': round(consumption_water,0),                 # Total water volume in liters
'consumption_energy': consumption_energy,               # Total energy in kWh
'consumption_water': consumption_water,                 # Total water volume in liters
Thanks a lot

I have tried to create a pull request, but I have failed spectacularly :/ as it has been added as pull request to my fork instead O-Palda/clage_homeserver#1

You have been almost there. Next time you can try to compare across forks.
I have published the new version 224ffd5to be tested.

Hello Klaus,
I have the new version deployed for the last two days and it works splendidly.
Thank you very much

Ok, den we can close the issue.


Issue - Unlimited error glitch found

I'm using the latest relief version on Windows 11 and tried uploading my own font only to select it and get no less than ten thousand "Processing Font files" error messages on the right side of my screen. They're still going and I've disabled the plugin. The font is a custom one that I made myself of my handwriting and the only thing different with it than most fonts is that it contains ligatures, "th", "ch", and "sh". I don't think those should cause an issue as it's just a ttf file. Any idea what's going on?

Hmm. Thanks for using my plugin.
Can you upload the font so that I can test it locally?

Sure, ignore the fact that it's in code, it's for a school project
Hektik-Regular.zip


Access Point Refactor && Update

Fixes #536
So the new method of toggling an access point is using t2 ap --on/--off, just like t2 wifi --on/--off.
This PR also add functionality similar to t2 wifi, i.e.,
Nicks-MBP:tessel-test hipsterbrown$ t2 ap
INFO Looking for your Tessel...
INFO Connected to tessel-router.
INFO SSID: RouterName
INFO Password: APPassword
INFO Security: psk2
INFO IP Address: <IP_ADDRESS>
INFO Enabled

If you rebase on master, the Travis errors should be fixed!

Awesome, I'll make those fixes tonight.

Fantastic! The code looks good. Some smoke tests:
➜  t2-cli git:(HipsterBrown-ap-refactor) ✗ t2 ap
INFO Looking for your Tessel...
INFO Connected to Tessel-02A3844F1188.
INFO Tessel-02A3844F1188 is not configured as an access point (run "t2 ap --help" to learn more)
➜  t2-cli git:(HipsterBrown-ap-refactor) ✗ t2 ap --help

Usage: t2 ap [options]

Options:
   -t TIMEOUT, --timeout TIMEOUT     Set timeout in seconds for scanning for networked tessels  [5]
   -i PRIVATEKEY, --key PRIVATEKEY   SSH key for authorization with your Tessel
   --name NAME                       The name of the tessel on which the command will be executed
   --lan                             Use only a LAN connection
   --usb                             Use only a USB connection
   --lanPrefer                       Prefer a LAN connection when available, otherwise use USB.  [false]
   -o, --output                      Enable or disable writing command output to stdout/stderr. Useful for CLI API consumers.  [true]
   -n, --ssid                        Name of the network.
   -p, --pass                        Password to access network.
   -s, --security                    Encryption to use on network (i.e. wep, psk, psk2, wpa, wpa2).
   --off                             Disable the access point
   --on                              Enable the access point

Configure the Tessel as an access point
➜  t2-cli git:(HipsterBrown-ap-refactor) ✗ t2 ap --on
INFO Looking for your Tessel...
INFO Connected to Tessel-02A3844F1188.
INFO Access Point successfully enabled.
➜  t2-cli git:(HipsterBrown-ap-refactor) ✗ t2 ap
INFO Looking for your Tessel...
INFO Connected to Tessel-02A3844F1188.
INFO Tessel-02A3844F1188 is not configured as an access point (run "t2 ap --help" to learn more)

So I think when we get a --on flag, we should actually check and see if an SSID and password have been set for the ap. In the above example, I ran t2 ap --on and it reported success but then t2 ap reported that it hasn't been configured to run as an access point. My /etc/config/wireless looks like:

config wifi-device 'radio0'
        option type 'mac80211'
        option channel '11'
        option hwmode '11g'
        option path '10180000.wmac'
        option htmode 'HT20'
        option disabled '0'

config wifi-iface
        option device 'radio0'
        option network 'wifi'
        option mode 'sta'
        option disabled '0'
        option ssid 'technicallyHome'
        option key 'Rusty007'
        option encryption 'psk2'

config wifi-iface
        option device 'radio0'
        option network 'lan'
        option mode 'ap'
        option encryption 'psk2'
        option disabled '0'

So you can see there is no SSID or password.
Continuing the smoke tests:
➜  t2-cli git:(HipsterBrown-ap-refactor) ✗ t2 ap -n MyNetwork -p Tesssel11
INFO Looking for your Tessel...
INFO Connected to Tessel-02A3844F1188.
INFO Created Access Point successfully. SSID: MyNetwork, password Tesssel11, security mode: psk2
➜  t2-cli git:(HipsterBrown-ap-refactor) ✗ t2 ap
INFO Looking for your Tessel...
INFO Connected to Tessel-02A3844F1188.
INFO SSID: MyNetwork
INFO Password: Tesssel11
INFO Security: psk2
INFO IP Address: <IP_ADDRESS>
INFO Enabled
➜  t2-cli git:(HipsterBrown-ap-refactor) ✗ t2 ap --off
INFO Looking for your Tessel...
INFO Connected to Tessel-02A3844F1188.
^C%   # This appears to be some other unrelated bug where it didn't run the process or something...
➜  t2-cli git:(HipsterBrown-ap-refactor) ✗ t2 ap --off
INFO Looking for your Tessel...
INFO Connected to Tessel-02A3844F1188.
INFO Access Point successfully disabled.
➜  t2-cli git:(HipsterBrown-ap-refactor) ✗ t2 ap
INFO Looking for your Tessel...
INFO Connected to Tessel-02A3844F1188.
INFO SSID: MyNetwork
INFO Password: Tesssel11
INFO Security: psk2
INFO IP Address: <IP_ADDRESS>
INFO Disabled
➜  t2-cli git:(HipsterBrown-ap-refactor) ✗ t2 ap --on
INFO Looking for your Tessel...
INFO Connected to Tessel-02A3844F1188.
INFO Access Point successfully enabled.
➜  t2-cli git:(HipsterBrown-ap-refactor) ✗ t2 ap
INFO Looking for your Tessel...
INFO Connected to Tessel-02A3844F1188.
INFO SSID: MyNetwork
INFO Password: Tesssel11
INFO Security: psk2
INFO IP Address: <IP_ADDRESS>
INFO Enabled

Looks good! If I were really nitpicky, I might suggest you change "Enabled" to "State: Enabled" to be consistent with the rest of the logs.
So I think you could either fix the above issue regarding checking ssid before setting --on or you could do it in another PR if you want to move on.

@johnnyman727
Ah good catch on the --on predicament. I think I'll leave that for another immediate PR, just to break up the amount of changes in one build. Also, do you think I should return the access point info when it's enabled, so users don't have to go through an extra step to get that info?
I like the State: Enabled/Disabled idea. I wasn't sure how to phrase it before but that works perfectly. I'll push a fix for that asap and get this through.

Also, do you think I should return the access point info when it's enabled, so users don't have to go through an extra step to get that info?

Yeah, I think that's actually a great suggestion.
Also, I did some more testing to check if the weird hang I experienced would happen again and it turns out it happens every time I run t2 ap --off just after having run t2 ap --on. The reason is because the call to tessel.simpleExec(commands.reconnectDhcp()) is actually returning an error that is reported by OpenWRT: udhcpc: sendto: Network is down. The rejection seems to be swallowed somewhere. I think we should fix this before merging to ensure a good user experience with the CLI.

The reason is because the call to tessel.simpleExec(commands.reconnectDhcp()) is actually returning an error that is reported by OpenWRT: udhcpc: sendto: Network is down. The rejection seems to be swallowed somewhere. I think we should fix this before merging to ensure a good user experience with the CLI.

Ok good catch. I'll work that into this build.

@johnnyman727 I've updated the t2 ap output to match your suggestion. Also, errors are now rejected correctly and passed through to tessel-2.js to be logged.

:clap:


Automatically generate previews for docs PRs

This is not super polished yet. The config is a bit messy, all steps related to docs-building are repeated (should be extracted to a composite action), and there are too many jobs displayed in the PR "Checks" section.
There are two paths for this workflow:

A PR is opened from a local branch (e.g. by maintainer): https://github.com/mfisher87/earthaccess/pull/4
A PR is opened from a fork (by any community member): https://github.com/mfisher87/earthaccess/pull/8

For path #1, things are simple; just build the docs and trigger the deploy. The workflow will have access to all the secrets it need.s
For path #2, things are complicated! pull_request events from forks don't have access to repo secrets for security reasons. pull_request_target events don't have access to the changes proposed on the fork for security reasons. One alternative is to trigger the workflow with a comment, and that's the route I took (based on quarto-dev/quarto-web project), and tried to make it convenient.
This is working on my fork because I've populated the Netlify secrets in my fork. This repo (or NSIDC org) needs to follow the Netlify setup procedure (see additions to contributing docs) and populate the secrets. I can set up the Netlify account with my work GitHub account @MattF-NSIDC if that helps!

Yeah, I really like that feature of RTD! That's what motivated me to build this. I've used RTD with Sphinx before, and it looks like it supports MkDocs, but I haven't looked any closer than that. Will it support everything we're doing, including rendering the notebooks at build-time? :thinking:
We could double-publish the docs to GitHub Pages and RTD if that's the case (and get previews for free from RTD)...
I put this together assuming that we wanted to stick with GitHub Pages as our main documentation site, and that's probably an assumption worth challenging. @betolink, what do you think?

It looks like @betolink set up readthedocs for this repo at some point https://readthedocs.org/projects/earthdata
I should have looked closer earlier, there's already a readthedocs config file in the repo https://github.com/nsidc/earthaccess/blob/main/readthedocs.yml
Maybe flipping the PR preview switch in readthedocs will "just work"?

I should have looked closer earlier

:rofl: Me too! Nice find.
It looks like it may be deployed to RTD under its old name, though: https://earthdata.readthedocs.io/en/latest/
I'm getting a 404 for earthacess.readthedocs.io. I agree, flipping the switch and letting RTD render these previews is miles better than maintaining all this :)

Got hold of Luis on Slack and he's busy with IceSat2 Hackweek. I'll need him to grant permissions to edit the RTD setup, maybe can do that this evening. If we can just flip that switch in the admin panel, I'll decline this way-overcomplicated PR. We can treat the RTD URL being out-of-date as a separate issue.


Syncing latest changes from upstream main for kubernetes-csi-addons

PR containing the latest commits from upstream main branch

/approve
/lgtm

/lgtm

@iPraveenParihar can you please create a BZ and backport for this fix to release-4.17 branch?


Popover Menu Content

Hi, I got disabled popover like below from the image. I can't click on anything. It seems CommandItem components from shadcn got applied data-disabled attribute set to false. I have no idea how to solve it in the code, but I manage to remove that attribute from the inspect the items can be clickable again.

Ahha! Thanks mate. It does work.


Update package.json

fix type export for latest node versions

What does this PR do?
This PR is to fix the type export issue with the latest versions of node. For example, this error being thrown in a new Vite react project:

Test Plan
This is a package.json change, testing includes using the SDK in a project with a newer node version.
Related PRs and Issues
An issue on the parent repo
Have you read the Contributing Guidelines on issues?
Yes

Hey @TristonWasik , Please kindly note that the repository in question is marked as [READ-ONLY], indicating that creating pull requests directly on this repository is not possible. It would be highly recommended to submit a pull request to the following repository instead: https://github.com/appwrite/sdk-generator. This particular repository serves as the starting point for the project and is where proposed changes should be made.
Before proceeding with the pull request, I am tagging @lohanidamodar and @TorstenDittmann here for review regarding if this PR is indeed the solution that we might need.

Closing as this was already done in the sdk generator and will be in the next release.
https://github.com/appwrite/sdk-generator/pull/653


Add TeamMemberStatus to TeamMember

protocol changes for member status. Removes the UserEldestSeqno field in favor of the status field since UserEldestSeqno != EldestSeqno could mean either a RESET or DELETED user, we should just be using the status field

I think the idea was to not have to do this, and to just treat deleted users as if they were active.

approved in person


fix: updated the headlessui/react package and refactored its usage

Context

fixes #1616

Changes

Refactored the Dialog and Transition components from the headlessui/react package to ensure compatibility with the latest version.
Removed deprecated code related to these components after the recent update.

@chavdarohit please add a comment to the story, so I can assign it to you

I hope you’re doing well! Just wanted to check in on my PR submitted yesterday. I’d appreciate any feedback when you have a moment.

@chavdarohit looking good, doing a deployment right now, so I just need a few more days until I aprove this and merge it to master. Will be done this week probably. Sorry for making you waot a bit. But everything looks ok.

@Tymmmy  Thank you for the update! No worries at all—I appreciate your efforts. I look forward to the merge when you’re ready. :)

@chavdarohit can you take a look at the build errors? There might be an extra dialog maybe added since then and that is why you need to remove from an extra file some code.

yaa i got the problem it is because the conflict let me fix it

i just updated the PR can you try again

Looks like prettier checks, maybe try pnpm format? @chavdarohit

@chavdarohit well done, merged to master. Thank you for the contribution.

Thanks for merging 🏁 also can you mark the issue close and add the label of the hacktoberfest-accepted it will be glad

@Tymmmy could you please add the label for the hacktoberfest-accepted then only my contribution will count for that

@Tymmmy i can understand but already what happened if the hacktoberfest community is not accepting the pr within 7 days so timer will go and it will be not accepted but if there is hacktoberfest-accepted label in this PR after the time will complete it will automatically accept so i am requesting to just add it


Submit button from obs with a forecast zone not behaving

If I click on the submit an ob button (blue button in the lower right hand corner) from the obs view within a fx view, it appears responsive but does not open the obs form. This is happening whether it reads "submit" or as just the "+" when you scroll down.  I don't know if this is helpful but it feels the same as tapping on a card to bring me to the avalanche forecast. Everything else - scrolling, loading more obs, clicking into an ob works... but not the button. No issue if I go to the observations from the global nav and click submit.

https://github.com/NWACus/avy/assets/119702342/12c5d383-98d8-4790-b051-a1f1eb48237b

I can't reproduce this even on my low-powered Android device. Even right after startup when things are pretty slow, pushing the button does get the modal to pop up - with some lag - but even just after one push. I wonder if the total ignoring of input is an S10e issue.

@stevekuznetsov this is issue we ran into on the call with Sierra

This is a dupe of https://github.com/NWACus/avy/issues/530

Yulia mentioned this issue to me while getting spun up, and I found a nav issue with the button when first launching the app. I think it could be the same issue.
Repro steps:

Open the app on a clean launch
Go to a forecast zone and then observations. make sure not to tap the observations tab before doing this
Submit button doesn't work


Create integration test suite and migrate appropriate tests from unit test suite #590

@juwara0
old code review:
https://reviewable.io/reviews/softlayer/sl-ember-components/961#-K3M0g5h0RoEcbunqmuO
removed:

default rendered state
negative assertion: disabled, name, placeholder, readyonly, value
optional prop supported
negative assertion
Required property supported
negative assertion
Help text supported
negative assertion
added:
default rendered state
assertion for 'form-control' class
typeahead suggestionsNamePath class test

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

Review status: 0 of 2 files reviewed at latest revision, 11 unresolved discussions.

tests/integration/components/sl-input-test.js, line 42 [r1] (raw file):
We do not need to do this render or the assert below to check that control-label is not set. Just render the template with the property being set and verify that the class gets applied.

tests/integration/components/sl-input-test.js, line 56 [r1] (raw file):
Please break this into two assertions one verifying that there is a class control-label and the other one can be this one.

tests/integration/components/sl-input-test.js, line 74 [r1] (raw file):
This test and the one below are duplicates. You only need one or the other.

tests/integration/components/sl-input-test.js, line 93 [r1] (raw file):
instead lets do this assertion as:
assert.strictEqual(
        this.$( '>:first-child' ).find( '.text-info' ).length,
        1,
        '"optional" property sets class "text-info"'
    );

tests/integration/components/sl-input-test.js, line 111 [r1] (raw file):
instead lets do this assertion as:
assert.strictEqual(
        this.$( '>:first-child' ).find( '.text-danger' ).length,
        1,
        '"required" property sets class "text-danger"'
    );

tests/integration/components/sl-input-test.js, line 163 [r1] (raw file):
instead lets do this assertion as:
assert.strictEqual(
        this.$( '>:first-child' ).find( '.help-block' ).length,
        1,
        '"helpText" property sets class "help-block"'
    );

tests/integration/components/sl-input-test.js, line 239 [r1] (raw file):
please remove the spaces after " id : " so that it is "id: "

tests/integration/components/sl-input-test.js, line 277 [r1] (raw file):
We do not need to do this render or the assert below to check that the property is not set. Just render the template with the property being set and verify that the property gets applied.

tests/unit/components/sl-input-test.js, line 76 [r1] (raw file):
Please revert this change... it should be:
const inputElement = this.$( 'input' ).get( 0 );

tests/unit/components/sl-input-test.js, line 78 [r1] (raw file):
Please revert this change... it should be:
const events = jQueryData( inputElement, 'events' );

tests/unit/components/sl-input-test.js, line 364 [r1] (raw file):
This test needs to stay. Do not remove it.

Comments from the review on Reviewable.io

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 11 unresolved discussions.

Comments from the review on Reviewable.io

Review status: 0 of 2 files reviewed at latest revision, 11 unresolved discussions.

tests/integration/components/sl-input-test.js, line 42 [r1] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 56 [r1] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 74 [r1] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 93 [r1] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 163 [r1] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 239 [r1] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 277 [r1] (raw file):
Done.

tests/unit/components/sl-input-test.js, line 76 [r1] (raw file):
Done.

tests/unit/components/sl-input-test.js, line 78 [r1] (raw file):
Done.

tests/unit/components/sl-input-test.js, line 364 [r1] (raw file):
Done.

Comments from the review on Reviewable.io

@notmessenger: this issue is ready for your review

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from the review on Reviewable.io

tests/integration/components/sl-input-test.js, line 42 [r1] (raw file):
If this is "done" why is this render and assertion still in the PR?

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 1 unresolved discussion.

tests/integration/components/sl-input-test.js, line 42 [r1] (raw file):
I removed the old render and assertion which was a "negative assertion". thus addressing michael's comment as "done".

Comments from the review on Reviewable.io

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 14 unresolved discussions.

tests/integration/components/sl-input-test.js, line 46 [r2] (raw file):
use assert.ok() since hasClass() returns a boolean

tests/integration/components/sl-input-test.js, line 194 [r2] (raw file):
Needs to be an assert.strictEqual() against the length() of find(), as no results returned from find() will still be a jQuery object.

tests/integration/components/sl-input-test.js, line 199 [r2] (raw file):
Needs to be an assert.strictEqual() against the length() of find(), as no results returned from find() will still be a jQuery object.

tests/integration/components/sl-input-test.js, line 204 [r2] (raw file):
Needs to be an assert.strictEqual() against the length() of find(), as no results returned from find() will still be a jQuery object.

tests/integration/components/sl-input-test.js, line 209 [r2] (raw file):
Needs to be an assert.strictEqual() against the length() of find(), as no results returned from find() will still be a jQuery object.

tests/integration/components/sl-input-test.js, line 214 [r2] (raw file):
Needs to be an assert.strictEqual() against the length() of find(), as no results returned from find() will still be a jQuery object.

tests/integration/components/sl-input-test.js, line 227 [r2] (raw file):
What impact does this have on the test assertions?  I do not see anything tested or affected by this property.

tests/integration/components/sl-input-test.js, line 233 [r2] (raw file):
Needs to be an assert.strictEqual() against the length() of find(), as no results returned from find() will still be a jQuery object.
This seems to be the same assertion in the "Typeahead classes are present" test case.  What sets it apart/why is  it here also?

tests/integration/components/sl-input-test.js, line 238 [r2] (raw file):
Needs to be an assert.strictEqual() against the length() of find(), as no results returned from find() will still be a jQuery object.
This seems to be the same assertion in the "Typeahead classes are present" test case.  What sets it apart/why is  it here also?

tests/integration/components/sl-input-test.js, line 243 [r2] (raw file):
Needs to be an assert.strictEqual() against the length() of find(), as no results returned from find() will still be a jQuery object.
This seems to be the same assertion in the "Typeahead classes are present" test case.  What sets it apart/why is  it here also?

tests/integration/components/sl-input-test.js, line 248 [r2] (raw file):
Needs to be an assert.strictEqual() against the length() of find(), as no results returned from find() will still be a jQuery object.
This seems to be the same assertion in the "Typeahead classes are present" test case.  What sets it apart/why is  it here also?

tests/integration/components/sl-input-test.js, line 253 [r2] (raw file):
Needs to be an assert.strictEqual() against the length() of find(), as no results returned from find() will still be a jQuery object.
This seems to be the same assertion in the "Typeahead classes are present" test case.  What sets it apart/why is  it here also?

tests/unit/components/sl-input-test.js, line 183 [r2] (raw file):
The value of "value" is set based on this logic:
const value = 'object' === Ember.typeOf( item ) ?
                            Ember.get( item, namePath ) : item;

not all of this logic is tested in this test case and should be.

Comments from the review on Reviewable.io

tests/unit/components/sl-input-test.js, line 77 [r2] (raw file):
Should not be referencing _data directly.  See https://github.com/softlayer/sl-ember-components/issues/917 and/or speak to @SpikedKira for more info

Comments from the review on Reviewable.io

Review status: 0 of 5 files reviewed at latest revision, 15 unresolved discussions.

tests/integration/components/sl-input-test.js, line 46 [r2] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 194 [r2] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 199 [r2] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 204 [r2] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 209 [r2] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 214 [r2] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 227 [r2] (raw file):
removed test and made a skip test for "suggestionsNamePath" prop.

tests/integration/components/sl-input-test.js, line 233 [r2] (raw file):
removed test and made a skip test for "suggestionsNamePath" prop.

tests/integration/components/sl-input-test.js, line 238 [r2] (raw file):
removed test and made a skip test for "suggestionsNamePath" prop.

tests/integration/components/sl-input-test.js, line 243 [r2] (raw file):
removed test and made a skip test for "suggestionsNamePath" prop.

tests/integration/components/sl-input-test.js, line 248 [r2] (raw file):
removed test and made a skip test for "suggestionsNamePath" prop.

tests/integration/components/sl-input-test.js, line 253 [r2] (raw file):
removed test and made a skip test for "suggestionsNamePath" prop.

tests/unit/components/sl-input-test.js, line 77 [r2] (raw file):
Done.

tests/unit/components/sl-input-test.js, line 183 [r2] (raw file):
Done.

Comments from the review on Reviewable.io

tests/dummy/app/templates/demos/sl-input.hbs (with impact on the comment left for tests/dummy/app/controllers/demos/sl-input.js):  I see that you want to demonstrate this other way of specifying content, but you have done so at the expense of the "simpler" way.  Demonstrate both of them.

Reviewed 5 of 5 files at r3.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

tests/dummy/app/controllers/demos/sl-input.js, line 4 [r3] (raw file):
All of the same value option that were present before need to remain.  This is to demo that "bla" filters past "blue", for example, etc.

tests/integration/components/sl-input-test.js, line 194 [r2] (raw file):
This assertion should be an assert.strictEqual() against the length() of find().  There are two reasons for this:

It aligns with all other similar occurrences in the rest of the code base
It does not tie us to the structure of the DOM.  We are not concerned that there is a span but rather that there is an element with the class of twitter-typeahead applied to it.  If you wish to recommend the approach you have taken the we can do so but as a separate development effort, as it will affect more files than just the ones represented in this PR.

tests/integration/components/sl-input-test.js, line 199 [r2] (raw file):
This assertion should be an assert.strictEqual() against the length() of find().  The reasons for doing so are the same listed for the "twitter-typeahead class exists" assertion.

tests/integration/components/sl-input-test.js, line 204 [r2] (raw file):
This assertion should be an assert.strictEqual() against the length() of find().  The reasons for doing so are the same listed for the "twitter-typeahead class exists" assertion.

tests/integration/components/sl-input-test.js, line 209 [r2] (raw file):
This assertion should be an assert.strictEqual() against the length() of find().  The reasons for doing so are the same listed for the "twitter-typeahead class exists" assertion.

tests/integration/components/sl-input-test.js, line 214 [r2] (raw file):
This assertion should be an assert.strictEqual() against the length() of find().  The reasons for doing so are the same listed for the "twitter-typeahead class exists" assertion.

tests/integration/components/sl-input-test.js, line 323 [r3] (raw file):
Create a new issue regarding addressing these skipped tests

tests/unit/components/sl-input-test.js, line 183 [r2] (raw file):
The code you took out in this modification should have also remained in order to test both logic paths of the ternary assignment of value.

tests/unit/components/sl-input-test.js, line 221 [r3] (raw file):
Create a new issue regarding addressing these skipped tests

Comments from the review on Reviewable.io

@notmessenger added both examples.

Review status: all files reviewed at latest revision, 9 unresolved discussions.

tests/dummy/app/controllers/demos/sl-input.js, line 4 [r3] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 194 [r2] (raw file):
fixed.

tests/integration/components/sl-input-test.js, line 199 [r2] (raw file):
fixed. fyi: typeahead has 2 input fields with the class "typeahead".

tests/integration/components/sl-input-test.js, line 204 [r2] (raw file):
fixed.

tests/integration/components/sl-input-test.js, line 209 [r2] (raw file):
fixed.

tests/integration/components/sl-input-test.js, line 214 [r2] (raw file):
fixed.

tests/integration/components/sl-input-test.js, line 323 [r3] (raw file):
Done.

tests/unit/components/sl-input-test.js, line 183 [r2] (raw file):
there is 2 inputs so that this.$( 'input' ) wouldnt work. the reason its component.get( 'value' ) is because the value is being set in https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/addon/components/sl-input.js#L174 once we select a suggestion. now in regards to the ternary operator, in this case both https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/addon/components/sl-input.js#L171 get the key of the suggestion selected. so it would always be the same value thus only tested once.
<input id="ember396-input" type="text" class="form-control typeahead ember-view ember-text-field tt-input" autocomplete="off" spellcheck="false" dir="auto" style="position: relative; vertical-align: top; background-color: transparent;">

tests/unit/components/sl-input-test.js, line 221 [r3] (raw file):
Done.

Comments from the review on Reviewable.io

Review status: 1 of 5 files reviewed at latest revision, 9 unresolved discussions.

tests/unit/components/sl-input-test.js, line 183 [r2] (raw file):
disregard my last message, fixed.

Comments from the review on Reviewable.io

Build is failing

Reviewed 4 of 4 files at r4.
Review status: all files reviewed at latest revision, 10 unresolved discussions, some commit checks failed.

tests/dummy/app/templates/demos/sl-input.hbs, line 34 [r4] (raw file):
"names" ?

tests/dummy/app/templates/demos/sl-input.hbs, line 262 [r4] (raw file):
Change to:

Array of objects used as typeahead suggestions.  Each object must contain a key whose name matches the suggestionNamePath property value, which is "name" by default".

The "suggestionNamePath" text should be wrapped in  tags.

tests/integration/components/sl-input-test.js, line 195 [r4] (raw file):
Remove "span" from find().  We do not want to be tied to the structure of the DOM. We are not concerned that there is a span but rather that there is an element with the class of twitter-typeahead applied to it

tests/integration/components/sl-input-test.js, line 201 [r4] (raw file):
Replace with:  this.$( '>:first-child' ).find( '.typeahead' ).length

tests/integration/components/sl-input-test.js, line 202 [r4] (raw file):
Why are there two of these?  Is this due to how the plugin is rendering things?

tests/integration/components/sl-input-test.js, line 207 [r4] (raw file):
Replace with this.$( '>:first-child' ).find( '.tt-input' ).length,

tests/integration/components/sl-input-test.js, line 213 [r4] (raw file):
Replace with this.$( '>:first-child' ).find( '.tt-menu' ).length,

tests/integration/components/sl-input-test.js, line 219 [r4] (raw file):
Replace with  this.$( '>:first-child' ).find( '.tt-dataset' ).length,

tests/unit/components/sl-input-test.js, line 183 [r2] (raw file):
I don't know what this test case should be doing by its description, but the conversation we are having should be that the existing test case of https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/tests/unit/components/sl-input-test.js#L353-L362 should remain, as well as both logic paths of the ternary should be tested.  I don't know how these have anything to do with a trigger?  Maybe it's just the name, as it's the trigger that then checks all this other data?  That's why I like the https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/tests/unit/components/sl-input-test.js#L353-L362 test case.  Seems perhaps these should remain separate.

Comments from the review on Reviewable.io

Review status: 2 of 5 files reviewed at latest revision, 10 unresolved discussions.

tests/dummy/app/templates/demos/sl-input.hbs, line 34 [r4] (raw file):
Done.

tests/dummy/app/templates/demos/sl-input.hbs, line 262 [r4] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 195 [r4] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 201 [r4] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 202 [r4] (raw file):
so the input field and the typeahead field both have typeahead class applied. thats why there is 2.

tests/integration/components/sl-input-test.js, line 207 [r4] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 213 [r4] (raw file):
Done.

tests/integration/components/sl-input-test.js, line 219 [r4] (raw file):
Done.

tests/unit/components/sl-input-test.js, line 183 [r2] (raw file):
so the ternary logic paths have been tested(both providing the same value, a string, as designed). you are right that the test desc was wrong and it has been updated and separated.

Comments from the review on Reviewable.io

@notmessenger can you re-run this build? seems an error on travis end

It's actually related to https://github.com/softlayer/sl-ember-components/issues/1248  I will get this reviewed and merged in.

Review status: 2 of 5 files reviewed at latest revision, 10 unresolved discussions.

Comments from the review on Reviewable.io

https://github.com/softlayer/sl-ember-components/issues/1248 has been merged into the EmberCli-1.13.8 branch

Review status: 2 of 5 files reviewed at latest revision, 10 unresolved discussions, some commit checks failed.

Comments from the review on Reviewable.io

Reviewed 3 of 3 files at r6.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

tests/dummy/app/templates/demos/sl-input.hbs, line 262 [r6] (raw file):
Remove the extraneous " after default

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r7.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from the review on Reviewable.io


set system time plugin resets time to wrong value in the past if gps doesn't have a fix. Do not trust GPS time if there is no fix

set system time plugin resets time to wrong value in the past if gps doesn't have a fix.
Do not trust GPS time if there is no fix

This could be easily fixed with a hardcoded minimum value.


Build and store dev release artifacts on each push to trunk

This pull request adds a new Github Actions workflow which builds .tar.gz and .whl release artifacts and stores it as a Github Actions artifact.
Those artifacts are not stored long term and are primary meant to be used for testing and similar purposes.

Codecov Report

Merging #1668 (8422635) into trunk (8c4f229) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk    #1668   +/-   ##
=======================================
  Coverage   83.27%   83.27%
=======================================
  Files         400      400
  Lines       87227    87227
  Branches     9260     9260
=======================================
  Hits        72638    72638
  Misses      11448    11448
  Partials     3141     3141

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4f229...8422635. Read the comment docs.

Confirmed it's working - https://github.com/Kami/libcloud/actions/runs/2006767284.


December 11 Progress

Monday, December 11

Change Log

[x] Integrate Auth0 for SSO Login
[x] Custom username and avatar generator using Toucanny
[x] Colorful front page with boid simulation

Note
Before pushing to main, we need to make sure our deployment environment has the correct environment variables to support Auth0 features. This requires making new OAuth2 tokens on GitHub, Google, and Apple for the development URL https://www.codenest.space. Will do this once pull request is ready to merge. Code will still work locally with the correct .env file.
Future Milestones

[ ] Syntax highlighting
[ ] Language detection (by file extension)
[ ] User settings
[ ] Custom themes
[ ] Limit user permissions on servers (Can't download or run malicious content)
[ ] Project templates (see Replit Templates)
[ ] Standard output section
[ ] Git section (See Replit Git Pane)

LGTM


Cursors don't attach to controllers at runtime.

Cursors seems to not find their parent controller after a period of time. They spawn in world space super big at 0,0,0.

I had the same problem. I ended up setting the controllers via the editor & commented out the lines in the script that try to find it in realtime. I'm using the SteamVR Unity Toolkit, so I just made the controller fields public & dragged in the controllers from the hierarchy. I think this resolved the large cursor, but I'm still having trouble getting anything to work (e.g. I still can't point and click on UI elements).


feat: add subscription_tags_ignored variable

Overview/summary
This PR adds the subscription_tags_ignored variable to the subscription module. This variable allows users to specify a list of tags to ignore when updating the subscription.
In one customer scenario, the customer has internal cost center information that is applied and updated as tags to the subscription outside of the vending module. Running the Terraform deployment results in overwriting the tags, so we need the ability to ignore certain tags.
Testing evidence
Please provide testing evidence to show that your Pull Request works/fixes as described and documented above.
As part of this pull request I have

[x] Checked for duplicate Pull Requests
[ ] Associated it with relevant issues, for tracking and closure.
[x] Run and make fmt & make docs to format your code and update documentation.
[ ] Created unit and deployment tests and provided evidence.
[ ] Updated relevant and associated documentation.

@JPEasier
Have you tested that this works?
I believe that lifecycle.ignore_chanegs cannot reference a variable. I tested this locally to be sure:
❯  t plan
╷
│ Error: Invalid expression
│
│   on main.tf line 9, in resource "terraform_data" "test":
│    9:     ignore_changes = var.ignore_changes
│
│ A static list expression is required.
╵

Hi @matt-FFFFFF,
Nope, I haven't tested it jet, our current solution is to load the module locally and manipulate the subscription submodule.
Anyway, I found this open issue https://github.com/hashicorp/terraform/issues/24188
So currently there is no chance for a dynamic lifecycle element.
So we can close this PR, but I am open for ideas! 😄


Integration tests are not supported with WSO2 EI

Description:
Integration tests are not supported with WSO2 EI. Current test cases are written to support for WSO2 ESB.

Fixed in https://github.com/wso2-extensions/esb-connector-servicenow/pull/11.


reexport other grammers crates from grammers-client

So that users of the library don't have to add all these dependencies manually, matching all the versions.

You'll need to rebase from master before CI is green here as well.


Possible improvements for documentation

Improvement points for our project
Left by few other people already doing opensource in Samsung

Add contribution document with Exact step-by-step description on how to create a new PR ( example )
Add link to MIT license official site in all places where we mention it
Edit install/run/tests examples in the Readme, such that code can be copied and executed without any change
(currently we have some lines that start from # or $ that should be manually removed)
Add pull-request-template.md

All this is just opinion/advice

I agree with all your suggestions!
Regarding number 2. do you mean we should add MIT license link on all .md files?

I agree with all your suggestions! Regarding number 2. do you mean we should add MIT license link on all .md files?

I meant the line The CredSweeper is an Open Source project released under the terms of MIT License V2. here in readme:
https://github.com/Samsung/CredSweeper#license

@meanrin

I agree with all your suggestions! Regarding number 2. do you mean we should add MIT license link on all .md files?

I meant the line The CredSweeper is an Open Source project released under the terms of MIT License V2. here in readme: https://github.com/Samsung/CredSweeper#license

Oh.. It was missed. I think it would be good to add.


caper: init at 0.9

Description of changes
Caper is a tool for understanding and processing "pcap expressions" (also known as tcpdump filters) which are used for network packet analysis.
Caper can be used for:

Expanding out pcap expressions "in full" to understand their implicit features.
Reasoning about whether two expressions accept the same set of packets, or how their accepted packets differ.
Converting pcap expressions into BPF programs.
Converting between pcap expressions and English.

More info can be found in the Caper paper (https://www.nik.network/caper/pcap_semantics.pdf).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Please squash all package related commits into one.


feat: Allow custom TF|2 paths for debug builds

The point behind this is to allow for custom paths for dev builds that can be hardcoded to allow pointing to some (fake) Titanfall2 install. That way when working on a machine with no proper Titanfall2 install or one where it's not being auto-detected, the path can be temporarily hardcoded by the developer to avoid having to select it on each recompile of the backend.
Obviously the added custom path should not be pushed and if pushed accidentally, rejected by PR reviewers.
#[cfg(debug_assertions)] ensures that the check is only performed in debug builds.

Thinking about it #61 kinda makes this PR obsolete anyway, as developer can just set custom path once and then it'll stay stored ^^


Request for website to be added: wilde-it.co.uk

Hello, Please would you consider adding my website to 250kb.club?
Website: https://wilde-it.co.uk
GTMetrix Scan: https://gtmetrix.com/reports/wilde-it.co.uk/h3qb0MD3/
Size (compressed): 139.9
Thanks

added


sage activation error 500

Submit a feature request or bug report

[x] I've read the guidelines for Contributing to Roots Projects
[ ] This is a feature request
[x] This is a bug report
[ ] This request isn't a duplicate of an existing issue
[ ] I've read the docs and NPM Debugging Guidelines post and followed them (if applicable)
[ ] This is not a personal support request that should be posted on the Roots Discourse forums

Replace any X with your information.

What is the current behavior?
error 500
What is the expected or desired behavior?
a complete activation of the theme

Please provide steps to reproduce, including full log output:
X
Please describe your local environment:
WordPress version: 4.6.1
OS: linux
NPM/Node version: X
Where did the bug happen? Development or remote servers?
remote servers
Is there a related Discourse thread or were any utilized (please link them)?
X
Please provide use cases for changing the current behavior:
X
Other relevant information:
Hi, i downloaded the latest version of sage and after uploading the entire folder in the themes folder in my e wordpress i started with activation... but after activation i had an error 500. in wp-config. I put on "TRUE" the WP_DEBUG, and i found an error on src/helpers.php on line 27... how can i fix this problem?

did you actually read my comment? https://github.com/roots/sage/issues/1725#issuecomment-249199527

if you had followed the steps in the template, you would understand that this is a personal support request that shouldn't be posted here

if you continue to make issues for support requests we'll have to restrict you from the repository since we don't need everyone watching this repo getting notifications for this shit.


Release 3.35.0

Since the build works now (Thanks to all, especially @Willena of course) the world may benefit from the new 3.35 release. One new thing is support for "ALTER TABLE DROP COLUMN" which is very hard to work around.

@INPUTsys-Chris, The  SQLite MC owner released version 1.2.0 based on 3.35.0 yesterday. As the build is repaired it should be relatively simple to produce a new version without too much delay.

Version 3.35.0 has been released.


how to get passport's Auth info in this middleware

ref: https://github.com/prismagraphql/graphql-middleware/issues/8#issuecomment-392764010
hi all, i use express + passport-oauth2 in my web.
and i want to use graphql to wrap exist restapi, with permission check.
i follow the examples/permissions , but in this line
https://github.com/prismagraphql/graphql-middleware/blob/6889d229181e49b4e8711d22a960900b103c2632/examples/permissions/index.js#L40
the context.request.isAuthenticated() alway false,
and i debug into the code, it looks like the this have nothing about auth info.
anybody can tell me how to use this library whit passport ?

and thanks @maticzav

Hey @geminiyellow 👋 Could you reopen this issue in https://github.com/maticzav/graphql-shield ?
I think thsi might be well solved there!

Thank you for reopening this issue here. I assume you are using Yoga as a server bundler (if not, you should definitely check it out http://github.com/graphcool/graphql-yoga). To pass props from express middleware into graphql resolvers, you have to forward your request to the context (afaik, this also defaults if you haven't overwritten it)
const server = new GraphQLServer({
  typeDefs: './src/schema.graphql',
  resolvers,
  context: req => ({
    ...req
  }),
})

const isAuthenticated = rule()(async (parent, args, ctx, info) => {
  return ctx.request.isAuthenticated()
})

I hope this helps you, otherwise, please provide more details about your application so I can reproduce the bug. 🙂

@maticzav thanks for your help.and I did something as yours. and I try to check it in context and check it in rule, alway false. I don’t know why.

@geminiyellow, could you verify that the functions runs correctly if used solely as an express middleware?

@maticzav i try to post query from the playground, Is this the reason?
it looks like that yoga is very hard to use with express together,
when add a static folder, the playground cannot access.

Yes, this is probablly it! Try making  a request from a website or copy HTTP headers that should be sent to Playground.

oohh, that is it. thank you for your help @maticzav . playground should give a README.

Ayy 🎉 Happy to hear it works!
I suggest you make a proposal there!


'hmset' with mapping of length 0

I am receiving 'hmset' with mapping of length 0 error on accessing my admin url in django.
I have set SESSION_ENGINE = 'redis'
After removing this line I am not receiving this error.
`#redis.py
from django.contrib.sessions.backends.base import SessionBase
from django.utils.functional import cached_property
from redis import Redis
class SessionStore(SessionBase):
@cached_property
def _connection(self):
    return Redis(
        host='<IP_ADDRESS>',
        port='6379',
        db=0,
        decode_responses=True
    )

def load(self):
    return self._connection.hgetall(self.session_key)

def exists(self, session_key):
    return self._connection.exists(session_key)

def create(self):
    # Creates a new session in the database.
    self._session_key = self._get_new_session_key()
    self.save(must_create=True)
    self.modified = True

def save(self, must_create=False):
    # Saves the session data. If `must_create` is True,
    # creates a new session object. Otherwise, only updates
    # an existing object and doesn't create one.
    if self.session_key is None:
        return self.create()
    data = self._get_session(no_load=must_create)
    session_key = self._get_or_create_session_key()
    self._connection.hmset(session_key, data)
    self._connection.expire(session_key, self.get_expiry_age())

def delete(self, session_key=None):
    # Deletes the session data under the session key.
    if session_key is None:
        if self.session_key is None:
            return
        session_key = self.session_key
    self._connection.delete(session_key)
@classmethod

def clear_expired(cls):
    # There is no need to remove expired sessions by hand
    # because Redis can do it automatically when
    # the session has expired.
    # We set expiration time in `save` method.
    pass

`

HMSET requires at least one key/value pair within the mapping dict. It is an error to call HMSET with an empty (0 length) dict. Assuming the error is coming from your SessionStore.save() method, you probably have no session data to save. A simple if data: check in that method will likely fix this.

@andymccurdy  while accessing the admin page of Django, I can't add that check.

The SessionStore you pasted is not implemented properly. If you authored the SessionStore class, you can easily fix it. If this is from another package, you can either submit a but to that package and ask them to fix it or you can subclass their SessionStore and fix it yourself.
This is not a redis-py bug.

Closing this as it does not appear to be a redis-py bug.


Update naming to use proper js naming schema

Currently, all functions are snake_case. They should be updated to camelCase

resolved with commit d244d04