document semantics

Intro
It would be great if there was a section or separate doc documenting the semantics of Aff and it's execution model. for example, this is not written down nor in readme nor in Aff module documentation; Semantics section of this issue is not quite documented (if it's still true); results of this and this discussion/changes would be a good fit for such document/section as well.
Why this is useful?
It would help folks already using Aff to better understand it and reason about code written in Aff, as well as help them author safer/performant/correct software. It would also help new PureScript developers who are just starting in utilizing powers of Aff and get up to speed much faster.
It would also be useful to better understand the implications of changes made on Aff going forward.
Also for other non-JS backends having semantics clearly represented as text will guide them in implementing a version of Aff which is matching in semantics of JS version, which will potentially increas code portability.
What efforts should be taken to achieve this?
I have no understanding of internal machinery of Aff but folks who do could dump some topic which should be covered in this doc/section so we have some kind of plan/outline.
Once that's clear, others can volunteer, including me, on filling some details.
Another approach would be to go through tests and extract out information from there.
Ideally, statements in the will have links to supporting tests.

Would like to hear what people think. Are gains of achieving this worth the effort?

I think most questions around Aff behavior are "what should happen when I do __ while in __ state". It would be helpful to have a working PureScript reference implementation in terms of specific state transitions so that one could construct a Fiber state, apply the transition, and see what you get out of it. I'm not sure if that's exactly what you might want for "semantics" but it at least can give you a clear answer.

I started this a while back, and then abandoned it because it requires non-trivial existential encodings in PureScript, and I think that it loses a lot of clarity. One option is to implement it in Haskell, but then it's not something you can actually use, or to wait until we have better language support.

I don't quite see what PureScript reference implementation in terms of specific state transition could be, if you have some sketch of high-level functions/types can you post that, or some example of similar thing done somewhere else? If it's supposed to be used when someone has the question then why wouldn't a Haskell version be usable? I'm asking because we can write CLI wrapper over that and distribute using npm, so it can be used by non haskellers, but I guess i'm missing something.


vscode: Fails to register service workers breaking web views

Describe the bug
Running VS Code results in an error any time it tries to render a web view. This breaks core
functionality such as release notes, extensions pages/panels.
Steps To Reproduce
Steps to reproduce the behavior:

Run NIX_ALLOW_UNFREE=1 nix run --impure unstable#vscode
See any webview fail to load. This can be the release notes or any extension's page.

Expected behavior
VS Code webviews work and can display their contents.
Screenshots

The error text:
Error loading webview: Error: Could not register service workers: InvalidStateError: Failed to register a ServiceWorker: The document is in an invalid state..

Additional context
I have not noticed this problem on my NixOS systems, but it appears to be a problem on macOS.
Notify maintainers

@eadwu @Synthetica9 @maxeaubrey @bobby285271
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-darwin"`
 - host os: `Darwin 21.6.0, macOS 10.16`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.8.1`
 - channels(jhamilton7): `"darwin, home-manager, nixpkgs"`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/etc/nix/inputs/nixpkgs`

I can confirm this issue on darwin arm64 also for version 1.70.2 . But I have not seen this error for versions 1.69.2 and 1.70.0

I should have put the version of VS Code in the issue, apologies for that. Here is what I get when I check the version (with my flake locked on nixos/nixpkgs/release-22.05):
➜ nix run .#vscode -- --version
1.69.2
3b889b090b5ad5793f524b5d1d39fda662b96a2a
x64

Switching my flake to nixos/nixpkgs so it'll be using master, I get:
➜ nix run .#vscode -- --version
1.70.2
e4503b30fc78200f846c62cf8091b76ff5547662
x64

The issue persists for both of these versions unfortunately.

I asked two coworkers that were still on Big Sur to try running VS Code with Nix and I got some interesting results:
Coworker A
Reproduced the issue:

nix-info output
 - system: `"x86_64-darwin"`
 - host os: `Darwin 20.3.0, macOS 10.16`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.4`
 - channels(root): `"nixpkgs"`
 - channels(ckisielius): `"darwin"`
 - nixpkgs: `/etc/nix/inputs/nixpkgs`

Coworker B:
Could not reproduce the issue:

nix-info output
 - system: `"x86_64-darwin"`
 - host os: `Darwin 20.6.0, macOS 10.16`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.11.0`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

I just went and tested again in case I missed something and it appears that the issue may have been running two separate instances of VS Code at the same time. I had always been executing my nix run nixpkgs#vscode from within the VS Code terminal. That would make the issue happen every time.
I tried quitting all VS Code instances and running nix run nixpkgs#vscode from iTerm2 and, perhaps unsurprisingly, it worked perfectly well!
I'll be closing this issue as the problem was due to running two different instances of VS Code and not about NixPkgs' build of VS Code.


dev.zip can not download from official website

It looks like we can't download dev.zip file from website Alchemy Contest

After tried many times, I solved it......

Thanks for letting us know. We have fixed it.


Improve raised exceptions

Improve raised exceptions

convert message from bytes to string when using Python 3  (using str.decode should work on both Python 2.x and Python 3)
add result code and errno values to the NNError exception class when raising an exception

The last change allows to react appropriately when we are interested in specific errno, i.e. EAGAIN to repeat send operation.

Removed result_code. I assume it will be always -1 on error.
The *args, **kwargs are part of Exception.__ini__ signature, so just retaining the interface.

Thanks!


Change the AST to make it easier to pattern match and remove ambiguities

This is derived from a discussion at #23. The tl;dr is that wrapping literals in :__block__ works, but makes it cumbersome to pattern match against. Some other nodes could be changed as well, like sigils.
The changes to be made would be such that the following syntaxes would be mapped as follows:
foo -> {:var, metadata, :foo}
400_000 -> {:int, [token: "400_000" | metadata], 400000}
42.0 -> {:float, [token: "42.0" | metadata], 42.0}
:foo -> {:atom, metadata, :foo}
[1, 2] -> {[], metadata, [1, 2]}
{1, 2} -> {:{}, metadata, [1. 2]}
~w[a b c] -> {{:sigil, "w"}, metadata, [segments, modifiers]}
{:sigil, meta, ["w", segments, modifiers]} for sigils would be ambiguous with function calls, for example. ~w/foo #{:bar}/a and foo("w", "foo #{:bar}", 'a') already produce the very same AST, with the only exception that the sigil has a :delimiter metadata that lets us recognize it as an actual sigil. Because AST nodes metadata order is not guaranteed, we can't just pattern match the metadata to assert it's a sigil. Hence the idea of using a tuple as the node type instead.
The same goes for lists. If the list node is {:list, meta, elements}, then [1, 2, 3] and list(1, 2, 3) would produce exactly the same AST, so I was thinking on using {[], meta, elements} instead. I'm not very happy with the loss in readability there, but it would work.
There are some opportunities to enrich the AST further, for example, the AST for A.B.C.fun is this:
{{:., _, [{:__aliases__, [], [:A, :B, :C], :fun]}, _, []}

By leveraging the :static_atoms_encoder parser option, we could transform it to this:
{{:., _, [{:__aliases__, [], [
  {:atom, _, :A}, {:atom, _, :B}, {:atom, _, :C}
], {:atom, _, :fun}]}, _, []}

Which, of course, it a lot more verbose, but on the other hand it allows us to:
a) Have a more consistent AST, meaning we no longer have some places were atoms are wrapped and others were they're not
b) We can have more precise information about where exactly each alias segment is happening
For b we would still miss information about where exactly the dots are located, but at least we could accurately replace the inner segments.
The final change I had thought of is to make the parsing safe by default, meaning that parsing a file wont create new atoms. The downside is that the Formatter only works with atoms, so Sourceror.to_string would create new atoms anyways and we're back to square one.

Some side effects of this:

We need a custom traversal function instead of relying on Macro.traverse
The Zipper API may need to be updated to handle this new AST, meaning it may no longer work as expected with the regular AST
We need an extra step before passing the AST to the formatter, so we give it something it can understand

All of these are easily addressable.

You can try these changes in the rich_ast branch
CC @marcandre

Sigils were changed to {:"~", metadata, [letter, contents, modifiers]}

@doorgan would it be wiser to wait for these changes to be applied before using sourceror? I have a couple of mix tasks I want to add to Surface that could make good use of sourceror but I believe I may have to change the implementation a lot when the new AST comes out.

Hi @msaraiva, I don't see these changes applied to the main branch anytime soon, as it's still too experimental and I realize it will take quite some time to find something that works fine for Sourceror use cases.
When the time to merge them comes closer I'll let you know and I'll be happy to help you migrate the Surface scripts :)

@doorgan sounds good!
I didn't know these changes were that far away. I'll give v0.8.1 a try then.
Cheers.

@msaraiva I initially intended to apply them in 1.9, but I started to deviate too much from the original goal and I want to have a clearer spec first. There's lot of nuances when it comes to having completely unambiguous node types that I need to resolve 🙂. So maybe they will land in 1.10 or 1.11.


[SRE-117] hasura 1.2.1 upgrade

Hasura 1.2.1 upgrade
Addition of hasura-cli
Addition of regex-tdfa

Rebased on master.

#186 makes this easier. Once merged you can rebase to get access to the migration script

Relies on PR #186 being merged and this branch rebased.

@craigem 186 has been merged


Make an example with React Router using loaders and actions (without React context)

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
3.5.0
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
2.0.7
Public or Confidential Client?
Public
Description
I would like to have an example with React Router's new API with loaders and actions (createBrowserRouter). I'm asking this because loaders and actions don't have React's context and are almost framework agnostic - I can have my service in pure Javascript and not worry about what is consuming it. The services' API should be able to grab the user's token to make requests without any React's context, probably in a middleware interceptor for all api calls (axios, window fetch or any other).
I did it before with MSAL v2, but it doesn't seem to be possible anymore, as everything is dependable of the MSAL Provider (react's context). The example given have some really weird logic for navigation which is far from ideal and also doesn't use the new React Router's provider. Another thing, the example uses Create React App, something not being used for some time now by the whole community - not only that, it's not recommended by anyone anymore.
Also, is it ok to save MSAL instance inside a global store (zustand / redux / signal)?
Thank you in advance!
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
None
Source
External (Customer)

I did it before with MSAL v2, but it doesn't seem to be possible anymore, as everything is dependable of the MSAL Provider (react's context).

This hasn't changed between MSAL v2 and v3. Can you tell me a little more about what broke with the upgrade?
Ultimately msal-react is an optional wrapper providing convenient hooks and components to address common use cases. It's not feasible to offer these things without context but if you don't need these things you can use msal-browser directly and skip msal-react.

It's convenient to use msal-react for sure but it's also very common to leave services out of react context and still need the token. I understand the way it's done can't be used the way I'm proposing though, so I'll just leave it as a suggestion. It'd be better if it used a signal system internally so the object could be extracted and be used globally, that's all.
Having said that, is it possible to use msal-browser and msal-react together? I imagine it's the same problem, but just asking.
The way I use today is wrong, I initiate the classe twice and by the time it starts the second, they are synced with the same data (don't know how or why)... so I don't get any errors and everything works. I don't use the first initialization and can't export it anyway so must be because of that. It's also very hacky and will probably break at some point. I could try that "technique" as well, since I only use the second form - the first one is there only for the initialization.

Having said that, is it possible to use msal-browser and msal-react together? I imagine it's the same problem, but just asking.

Yes, not only is it possible but it is mandatory. msal-react is a wrapper around msal-browser. msal-browser is required in order to use msal-react but msal-react is not required to use msal-browser.

I initiate the classe twice and by the time it starts the second

Instantiating PublicClientApplication more than once is not recommended. PublicClientApplication should always be instantiated outside the react component tree, then passed in to the MsalProvider, if using msal-react. This way you have access to PublicClientApplication both inside and outside Context. Please do note, however, if you are using msal-react all interactive requests (acquireTokenPopup/acquireTokenRedirect) should be done from inside Context as doing so outside may prevent state from updating and result in incorrect/buggy behaviors.

@tnorling sorry for necroing an older issue, but does this mean that msal-react has no official support for react-router-dom's Loader/Action API? Those only operate outside the React context. If so, is there any guidance on how to use MSAL (either msal-browser or msal-react) with the Loader/Action API?


Fix color scheme observer crashes in Safari

Resolve #245. Turns out matchMediaDarkScheme object doesn't have addEventListener, but only addListener in Safari 13.1.2. IDK why this wasn't reproduced elsewhere, maybe it was changed in Safari minor version that you don't have yet? ¯\_(ツ)_/¯

It’s probably because I’m using Safari Technology Preview (Release 110, Safari 14.0, WebKit 156<IP_ADDRESS>.2).

Huh, I thought that Safari TP is completely broken because of https://github.com/swiftwasm/carton/issues/25

Yeah, I’m using a local override on dev.js to run delete BigInt; before everything else.

I'm also using that override to use Safari on Big Sur.


Replace the buildTree() method by injected expr tracing approach

Hi! I hope it will be a big step forward for runn and I'm so happy to introduce this improvement :tada:
What's new?

Offers better pretty printing output in tree format for expr evaluation results.
The new implementation is based on tracing approach. All evaluation results including intermediate states of the expr programs are preserved in memory, so each expr program is not be evaluated again during the pretty printing phase.
The tracing feature is tested by the official expr testdata

Drawbacks

Some performance overhead added due to tracing
(breaking change) Removed YAML style # line comment handling. The behavior is changed in order to accept every valid syntax expr codes (the # symbol is a pointer/special variable marker in expr lang)

Behind the scenes
At first, I was trying to implement my proposal of the issue #803. However, soon I realized the current buildTree() method is not robust and there is no enough room for future development. That is why I decided to re-implement the pretty printing feature for expr evaluation results in completely new way.

@h6ah4i
GREAT WORK!!!!!!!!! Thank you!!
First of all, thank you. I will now check the code.

However, soon I realized the current buildTree() method is not robust and there is no enough room for future development.

I agree with you.

(breaking change) Removed YAML style # line comment handling.

This was granted at a time when expr-lang did not have the ability to comment, and should go away.
However, we cannot suddenly lose it, so I will try to be able to give a message that it is deprecated ( and replace ^# to //
simply).


USB DP Display on Rock5B

I have recently tested this OS on my rock 5b and really require the need for DP display.  I have modified my rock 5b to provide 5V external power supply so that, I can use the freed typec port as DP. I have a DP to VGA adapter that I have using with my rock pi 4b for CDN DP which works well and good. I have tinkered with kernel a bit as well to enable DP aux support on usbdp_phy0 but it does not work.

I am available for testing any of your builds, thanks

Thanks for your testing and report.
May I ask if DP outputs normally on official Debian/Armbian? If it works, could you elaborate on how did you make it? so I can confirm what we can do for your ask.
If it does not, I think it's better to ask in radxa form since openfyde uses radxa's kernel directly.

Sadly it doesn't work on radxa's kernel. I read the rk3588 usb dp guide and followed the instructions as mentioned there. But, it never worked with rock 5b.


Invalid escape sequences are not allowed in tagged template literals

spec moved to stage 4, so tagged template literals with invalid escape sequences should parse in ecmaScript 2018. AST spec.

@adrianheine This was implemented long time ago. See https://github.com/ternjs/acorn/commit/f1a88fe75c19598e716c608a953db294fa9701e1

My mistake, I didn't set the correct ECMAScript version when checking this.


#253 Fix issue with always defined defaultLayout property which alway…

…s render default view, but the one that was specified to render.

The default is by design, but apparently should have been released as a major since some use cases aren't using a layout at all. The fix for those apps is exphbs({defaultLayout: null})

The behavior of the API has changed, causing untouched code to no longer work. A fix should be implemented that will behave the same.

@Ismail-codinglab This project isn't updated very often so if you want to wait for a fix you might be waiting a while.


feat: rename Data.Set.Ncard to Data.Set.Card

We rename Data.Set.Ncard to Data.Set.Card, since this file now contains two separate cardinality definitions, not just ncard.

bors merge


TypeScript namespace shadows the function with the name

For a TS file as follows (valid TS), typedoc doesn't report param as a function. It only reports param as a module.
export function param() {}

/**
 * namespace comments
 */
export namespace param {
  export const path = {
    number: function() {},
    boolean: function() {},
  }
}

We expect to the following nodes:

param: Function
param: Module (namespace)

path: Object literal

number: Property
boolean: Property

But param: Function node is missing.
See https://github.com/strongloop/strong-docs/blob/2a7dae4a4d98bdefa2f42121b676f28fb15b14b3/test/fixtures/ts/Greeter.ts

Let me close it as dup of #472. I'll comment there.


No graphics drawn if ReactDOM.render is delayed (setTimeout)

I'm planning on rewriting some code in react-konva, and I noticed that it wasn't drawing anyting.
I tried the demo, and it seems that the problem might be a delayed call to ReactDOM.render.
No canvas appears in the dom tree.
I added this to the demo:
setTimeout(function(){
    ReactDOM.render(<App/>, document.getElementById('container'));
}, 1000)

http://jsbin.com/saxipodado/edit?js,output

It is just some jsbin magic with protecting.
// noprotect solve the issue
http://jsbin.com/herafoxudo/edit?js,output

I see. So it must have been something else in my project.


replaceScript method is "VITE_PRELOAD" replace first only.

replace() is replace first target.
https://github.com/richardtallent/vite-plugin-singlefile/blob/5516a454d54d297219881d4e73df22a2a0b4560f/src/index.ts#L23-L29
It seems to me that replaceAll() should be used.
https://github.com/richardtallent/vite-plugin-singlefile/blob/5516a454d54d297219881d4e73df22a2a0b4560f/src/index.ts#L26
↓
	const newCode = scriptCode.replaceAll(preloadMarker, "void 0")

Change made, will be in the next release

@richardtallent thank you very much!

The commit containing this correspondence is here.
https://github.com/richardtallent/vite-plugin-singlefile/commit/d3589eec2b6d9309f7732ed9ed8eff0c3761f112

The commit containing this correspondence is here.
https://github.com/richardtallent/vite-plugin-singlefile/commit/886cdd720b85fb4fc34f1dc2bb56eb3a1e24195c


build server.js

dependencies:
express, ejs, superagent, dotenv, pg, method-override
use .env for port assignment, API keys, and db-url

Server created and tested. All dependencies included. Added and indicated space for routes and functions for both client-facing and DB refresh features.


autoHideBadge  is not working

I have enabled the autoHideBadge  option but is still shown on my website.

Thanks for reporting the issue!
It has been fixed in version 1.5.0


ARTEMIS-3323 - ensure openwire message id is unique and consistent fo…

…r the life of a broker when converted from core

other than the System.err that seems an accident. (If you intended for it, it's best to use logger.debug() anyways) it LGTM.
As long as the test suite is green and if you fix the System.err.println() this is good to go.


Scale center weights of conv2d

@sethtroisi what is the context for these images?

I wanted a record of using tf.summary.image, it was super easy and looked okay.

The larger context is they are the conv2d kernels from the center_conv experiment


KAFKA-16579: Revert Consumer Rolling Upgrade

Consumer Rolling Upgrade is meant to test the protocol upgrade for the old protocol.  Therefore, I am removing old changes.
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.4
session_id:       2024-04-18--004
run time:         1 minute 38.006 seconds
tests run:        3
passed:           3
flaky:            0
failed:           0
ignored:          0
================================================================================
test_id:    kafkatest.tests.client.consumer_rolling_upgrade_test.ConsumerRollingUpgradeTest.rolling_update_test.metadata_quorum=ISOLATED_KRAFT.use_new_coordinator=False
status:     PASS
run time:   33.562 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.consumer_rolling_upgrade_test.ConsumerRollingUpgradeTest.rolling_update_test.metadata_quorum=ISOLATED_KRAFT.use_new_coordinator=True
status:     PASS
run time:   34.902 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.consumer_rolling_upgrade_test.ConsumerRollingUpgradeTest.rolling_update_test.metadata_quorum=ZK.use_new_coordinator=False
status:     PASS
run time:   29.447 seconds
--------------------------------------------------------------------------------

@lucasbru - This is just to remove the consumer protocol from testing as it is not suited for this test. Much appreciated if you get a chance to look at this.


Interning data

I find the doc not super clear on how to use InternedData
What I have so far is sth like

a Map<String, Long> internedStrings = new HashMap<>();
InternedData.Builder internedDataBuilder = InternedData.newBuilder();
when I want to add a new event I'm doing sth like

TrackEvent.newBuilder()
  .setNameIid(toTrackName(name))
 //  ... other stuff

and I have
    private long toTrackName(String name) {
        var iid = internedStrings.computeIfAbsent(name, __ -> iidCounter.getAndIncrement());
        var eventName = EventName.newBuilder()
            .setIid(iid)
            .setName(name)
            .build();
        internedDataBuilder.addEventNames(eventName);
        return iid;
    }

basically get an ID for each new 'name' string, and add that to the interned data, but store the iid and not the name on the track.
I also add the interned data to my trace packet like so

TracePacket.newBuilder()
            .setTrustedPacketSequenceId(1)
            .setInternedData(internedDataBuilder.build())
            .build()

but in the generated trace, the track names are all null.
What am I doing wrong ?

See this textproto representation.
What's probably weird is that I have my map to get unique ids, so for instance for each TaskStarted, the map returns ID 4
I then store it in my interned data builder (only once) via
        var eventCategory = TrackEventOuterClass.EventCategory.newBuilder()
            .setIid(4)
            .setName("TaskStarted")
            .build();
        internedDataBuilder.addEventCategories(eventCategory);

and below, for the event that should reference this, you can see e.g. this packet
packet {
  timestamp: 9447
  trusted_packet_sequence_id: 1
  track_event {
    category_iids: 4                     <------------------------------- this is what I understood would link it to the proper interned string
    debug_annotations {
      name_iid: 5
      dict_entries {
        name_iid: 6
        string_value_iid: 7
      }
      dict_entries {
        name_iid: 8
        string_value_iid: 9
      }
      dict_entries {
        name_iid: 10
        string_value_iid: 11
      }
      dict_entries {
        name_iid: 12
        string_value_iid: 13
      }
      dict_entries {
        name_iid: 14
        string_value_iid: 15
      }
      dict_entries {
        name_iid: 16
        string_value_iid: 17
      }
    }
    type: TYPE_SLICE_BEGIN
    name_iid: 3
    track_uuid: 2
  }
  timestamp_clock_id: 64
}

Thanks for sharing the trace. I think these changes should solve your problems:

The first packet you emit should have sequence_flags: 1 (documented in trace_packet.proto). You're basically telling trace_processor that the interned data from this point on can be considered complete.
0 is not a valid iid. The iids should start from 1.
Iid "spaces" are separate for each type. DebugAnnotation.string_value_iid uses a different "space" from TrackEvent name_iid. For example, in your textproto, you have:

    event_names {
      iid: 108
      name: ":core:analytics:generateDemoReleaseResources"
    }

and then later:
      dict_entries {
        name_iid: 8
        string_value_iid: 108
      }

That string_value_iid cannot refer to 108, because it's an event_name. If you want something that can be used as a string_value_iid, you should replace the first block with:
    debug_annotation_string_values {
        iid: 108
        str: ":core:analytics:generateDemoReleaseResources"
    }

This also means that if you want, you can reuse the same iid number for different types and they will not conflict (smaller iids will save space due to varint encoding).
Hope this helps, let me know if this doesn't solve you problem

Hey @ddiproietto
sorry for answering only now, but this is indeed working correctly now
thanks


⚠ Bofrost.de has degraded performance

In f6bea09, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 876 ms

Resolved: Bofrost.de performance has improved in 241b9c5 after 6 minutes.


Add Vrbo (vrbo.com) to sites.json

Sorry about the revisions, JSON should now be error-free.

Hello @7h3w1zz ,
This repo has been dormant for years, I suggest you submit your PR on our maintained fork over at jdm-contrib/jdm

Thanks for the heads up  @tupaschoal, will do


Enquiring about coordinate transformation

Hello everyone,
I am trying to understand the coordinate system in OpenFAST. So, made an attempt to transform the LSS forces from rotating frame of reference (LSShftFya) to fixed frame . Then compare with  LSShftFys. For the transformation I am using simple rotational matrix as my simulation does not have any yaw dof and subjected to only steady wind.
      theta = RtSpeed % [rad/s]
      % Rotation matrix for rotation about the x-axis
        R_x = [1, 0, 0;
               0, cos(theta_i), -sin(theta_i);
               0, sin(theta_i), cos(theta_i)];

        % Forces in body-fixed frame at time t(i)
        F_BF = [RotThrust(i); LSShftFya(i); LSShftFza(i)];

        % Transform forces to fixed frame
        F_FF = R_x * F_BF;

However, I am not able to match the calculated forces after transformation with LSShftFys, LSShftFzs. I wanted to make sure if LSShftFya,LSShftFza can be transformed this way.

Appreciate any help!

Dear @PaulKSmith,
I agree with all of your math except that you are using RtSpeed for the angle in rad/s rather than Azimuth in radians.
Best regards,

Thanks!
Somehow misinterpreted. It matches perfectly now.


[SPARK-32301][PYTHON][TESTS] Add a test case for toPandas to work with empty partitioned Spark DataFrame

What changes were proposed in this pull request?
This PR proposes to port the test case from https://github.com/apache/spark/pull/29098 to branch-3.0 and master.  In the master and branch-3.0, this was fixed together at https://github.com/apache/spark/commit/ecaa495b1fe532c36e952ccac42f4715809476af but no partition case is not being tested.
Why are the changes needed?
To improve test coverage.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Unit test was forward-ported.

Test build #125817 has started for PR 29099 at commit e986c65.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30428/
Test PASSed.

Test build #125817 has finished for PR 29099 at commit e986c65.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125817/
Test FAILed.

retest this please

Test build #125824 has started for PR 29099 at commit e986c65.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30435/
Test PASSed.

Test build #125824 has finished for PR 29099 at commit e986c65.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125824/
Test FAILed.

I am going to merge this since this is just a forward-port that doesn't cause any behaviour change. I am 100% confident about this fix.

Merged to master and branch-3.0.

BTW, the tests passed in GitHub Actions


Add cw-gitpod-base docker hub push for appveyor CI

Added docker build and push steps to appveyor.yml config for cw-gitpod-base image

also maybe this ends up under interwasm docker? what do you think Orkun and Simon?

Sounds good

@webmaster128 should we wait for docker password, or merge and take care of it in another PR?

@orkunkl we'll need to put this on a branch of the original repo (i.e. not a fork) in order to properly test. It will fail now on main. So I suggest commenting out the main entry in the whitelist, merge, and finalize on a new PR branch.


Permissions for App Creators/Designers

The article lists 3 entities and the permissions needed to create apps. This is true, but these permissions alone do not allow the user to access the Site Map designer from the app designer page. I do not wish to give a user the full "System Customizer" role, but still would like them to be able to customize the site map from the app designer. What additional permissions are required for this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f6f4fcae-9cd2-2e69-43e5-c06386229c8f
Version Independent ID: baff9deb-098c-f465-0bb5-0aba6e44c4fd
Content: Create a site map for an app in PowerApps
Content Source: ce/customize/create-site-map-app.md
Service: crm-online
Product: unspecified
GitHub Login: @Mattp123
Microsoft Alias: matp

@GregEnns I received a reply from the program manager for this feature who stated that the privileges in the documentation are correct, but there is a known issue with privileges in the designer that is expected to be fixed soon.  If you want, you can add this issue at https://experience.dynamics.com/ideas/.
Closing issue.


extends capabilities and tests for finalizers

Tested: via make test
Let me know if I totally borked up by making copyObject part of the reconciler interface.
It seemed like the best way to get access to the namespace in the same way that
other functions were doing it.

/assign @srampal
And because we were talking about this, I'd like their input.
/assign @yiqigao217

Is this still a WIP?

I'd like to get input before I mark it done. So...ready for review?
On Thu, Oct 10, 2019, 7:38 PM Ryan Bezdicek<EMAIL_ADDRESS>wrote:

Is this still a WIP?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/multi-tenancy/pull/142?email_source=notifications&email_token=AM6RRQZU4ILSFOK4BK4LCEDQN7RLBA5CNFSM4I7UHGSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA6RTJA#issuecomment-540875172,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6RRQ3CR52RST2Q2JDL3N3QN7RLBANCNFSM4I7UHGSA
.

I'll mark that as ready for review in a second.

Thank you!
I'll hunt down where the decision process is made and make those changes
tonight.
On Fri, Oct 11, 2019, 7:00 AM Adrian Ludwin<EMAIL_ADDRESS>wrote:

@adrianludwin commented on this pull request.
/hold
In incubator/hnc/api/v1alpha1/hierarchy_types.go
https://github.com/kubernetes-sigs/multi-tenancy/pull/142#discussion_r333999453
:

@@ -103,6 +104,9 @@ type Condition struct {
// - "OBJECT_OVERRIDDEN": an object in this namespace has been overridden from its parent and will no longer be updated
//
// - "OBJECT_DESCENDANT_OVERRIDDEN": an object in this namespace is no longer being propagated because a propagated copy has been modified

//
// - "OBJECT_HAS_FINALIZER": The object has a finalizer type set, and should not be propagated.

"has a finalizer set" - no need for the word "type"
In incubator/hnc/pkg/controllers/object_controller.go
https://github.com/kubernetes-sigs/multi-tenancy/pull/142#discussion_r334002563
:

@@ -137,12 +138,12 @@ func (r *ObjectReconciler) ensureCorrectAncestry(ctx context.Context, log logr.L
}

// We found the object in an ancestor namespace. Is this object the same as the source?

instCopied := copyObject(inst)

instCopied := r.copyObject(src.GetNamespace(), inst)

This isn't the right place for this logic. copyObject is called in
multiple contexts: deciding whether to copy the object, and actually
copying the object. We only want to set the conditions during the decision
process; it doesn't make any sense to be setting it while actually
propagating!
In addition, the function we're in right now is called
ensureCorrectAncestry. It would be surprising for this function to also
do a check on the inherent properties of the object.
So I think I'd like to add some method called something like
ensureCanPropagate which gets called either before or after the call to
ensureCorrectAncestry. If it fails, update should early-exit, and it
should add the condition to the forest.
In incubator/hnc/pkg/controllers/object_controller.go
https://github.com/kubernetes-sigs/multi-tenancy/pull/142#discussion_r334005986
:

@@ -284,14 +285,25 @@ func (r *ObjectReconciler) onDelete(ctx context.Context, log logr.Logger, nnm ty
return nil
}

-func copyObject(inst *unstructured.Unstructured) *unstructured.Unstructured {
+func (r *ObjectReconciler) copyObject(nsNm string, inst *unstructured.Unstructured) *unstructured.Unstructured {

r.Forest.Lock()
defer r.Forest.Unlock()
ns := r.Forest.Get(nsNm)
if !ns.Exists() {

return nil

If you look at the callers for copyObject, you'll see that a lot of them
use the returned value immediately after it comes out of this function, so
returning nil will result in a segfault. So for this solution to work,
you'd have to modify all the call sites. That's a good "code smell" that
this functionality doesn't belong here :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/multi-tenancy/pull/142?email_source=notifications&email_token=AM6RRQYQ6R6BDBJ52MZZICDQOCBINA5CNFSM4I7UHGSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHWEGVY#pullrequestreview-300696407,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6RRQ7OWMROAJRRDMWVI5LQOCBINANCNFSM4I7UHGSA
.

Cool! I was unsure of the wording too.
I'm on it!
On Fri, Oct 11, 2019, 7:52 AM yiqigao217<EMAIL_ADDRESS>wrote:

@yiqigao217 requested changes on this pull request.
In incubator/hnc/api/v1alpha1/hierarchy_types.go
https://github.com/kubernetes-sigs/multi-tenancy/pull/142#discussion_r334029711
:

@@ -28,6 +28,7 @@ const (
CritAncestor              Code = "CRIT_ANCESTOR"
ObjectOverridden          Code = "OBJECT_OVERRIDDEN"
ObjectDescendantOverriden Code = "OBJECT_DESCENDANT_OVERRIDDEN"

ObjectHasFinalizer        Code = "OBJECT_HAS_FINALIZER"

We can probably rename the condition to ObjectInternal, considering we
are checking 3 fields for now DeletionGracePeriodSeconds,
DeletionTimestamp,Finalizers. We may also check more object internal
issues in the future in the ensureCanPropagate() function suggested by
Adrian below.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/multi-tenancy/pull/142?email_source=notifications&email_token=AM6RRQ77KBIBUNLLFIAOIL3QOCHJBA5CNFSM4I7UHGSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHWOJEA#pullrequestreview-300737680,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6RRQ7VT623VMAEBTQ5UYLQOCHJBANCNFSM4I7UHGSA
.

Excellent! Thank you!
On Fri, Oct 11, 2019, 8:53 AM yiqigao217<EMAIL_ADDRESS>wrote:

@yiqigao217 commented on this pull request.
In incubator/hnc/pkg/controllers/object_controller.go
https://github.com/kubernetes-sigs/multi-tenancy/pull/142#discussion_r334060205
:

// Clear all irrelevant fields. cf https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.15/#objectmeta-v1-meta

copied.SetCreationTimestamp(metav1.Time{})

copied.SetDeletionGracePeriodSeconds(nil)
copied.SetDeletionTimestamp(nil)
copied.SetFinalizers(nil) // TODO: double-check this is the right thing to do?

if copied.GetDeletionGracePeriodSeconds() != nil {

ns.SetCondition(forest.Local, tenancy.ObjectHasFinalizer, "finalizer set")

For OBJECT_ conditions, the key should be a string in the format of
group/version/kind/namespace/name. forest.Local is the key for
locally-set namespace conditions, not object conditions.
You can find the documentation at #76
https://github.com/kubernetes-sigs/multi-tenancy/issues/76
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/multi-tenancy/pull/142?email_source=notifications&email_token=AM6RRQ4QWJBEAM7VQMZ7CT3QOCOPXA5CNFSM4I7UHGSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHWYBLQ#pullrequestreview-300777646,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6RRQYMTNVEK27WVHECUUDQOCOPXANCNFSM4I7UHGSA
.

Ok! Made all changes requested, passes make test.
Happy Friday!

/hold

Fyewf! That'll keep me busy for a while. Thank you for your input and
guidance!
(The comment deletion was accidental and I missed it in review.)
On Sun, Oct 13, 2019, 5:24 AM Adrian Ludwin<EMAIL_ADDRESS>wrote:

/hold
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/multi-tenancy/pull/142?email_source=notifications&email_token=AM6RRQZZIQUANAR3PAFF4J3QOMHOTA5CNFSM4I7UHGSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCVEYQ#issuecomment-541413986,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6RRQ2CUEWZ72FX4A7552LQOMHOTANCNFSM4I7UHGSA
.

Having a bit of trouble with the unit test, reading documentation. Will report more as I finish this today.

Nice! Thank you. I figured Eventually had something to do with asynchronous
calls.
I'll restore the import and rewrite this test.
Do you have any ideas on testing for propagation as well? Maybe set a
condition, then a parent and then grab the object and test for a condition?
The step I'm having the most trouble with is grabbing the correct namespace
so I can test for a condition.
On Sun, Oct 13, 2019, 2:27 PM Adrian Ludwin<EMAIL_ADDRESS>wrote:

@adrianludwin commented on this pull request.
In incubator/hnc/pkg/controllers/object_controller_test.go
https://github.com/kubernetes-sigs/multi-tenancy/pull/142#discussion_r334297672
:

tenancy "github.com/kubernetes-sigs/multi-tenancy/incubator/hnc/api/v1alpha1"

Can you restore this please? Usually we have (up to) three blocks of
imports:

Core libraries (eg context)
Packages from other repos (eg k8s.io/...)
Other packages from this repo (eg v1alpha1)

In incubator/hnc/pkg/controllers/object_controller_test.go
https://github.com/kubernetes-sigs/multi-tenancy/pull/142#discussion_r334297766
:

if hasAnyCondition(ctx, barName) {

	panic("CONDITION SET")

}

Based on https://onsi.github.io/gomega/#making-assertions, I'd say
something like:
Expect(hasAnyCondition(ctx, barName)).ToNot(Equal(true))
You shouldn't panic since it stops the rest of the tests from running.
Usually, you'll use Eventually() instead of Expect() since the latter
runs immediately while the former can retry for up to two seconds
(configurable in suite_test.go IIRC, but please don't change it). This is
necessary because the controller is running asynchronously alongside the
test code, so when you make a change (like updating the test apiserver), it
takes a few moments to respond.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/multi-tenancy/pull/142?email_source=notifications&email_token=AM6RRQ3EXUFSFEVVI7CG3BDQOOHELA5CNFSM4I7UHGSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHY65SI#pullrequestreview-301067977,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6RRQ746PVQ3AQGSFRURB3QOOHELANCNFSM4I7UHGSA
.

It should be relatively easy to set a condition in a test - just set the parent of a namespace to something that doesn't exist. There should be lots of examples in hierarchy_controller_test.go.
I'm not sure what you mean by "grabbing the correct namespace." Perhaps have a live chat or video meeting with @yiqigao217 and then pull me in if you're still having trouble?

I think I've got it figured out. I'll get back at it tomorrow after work.
Cheers,
Thanks for all your help!
On Mon, Oct 14, 2019, 6:02 PM Adrian Ludwin<EMAIL_ADDRESS>wrote:

It should be relatively easy to set a condition in a test - just set the
parent of a namespace to something that doesn't exist. There should be lots
of examples in hierarchy_controller_test.go.
I'm not sure what you mean by "grabbing the correct namespace." Perhaps
have a live chat or video meeting with @yiqigao217
https://github.com/yiqigao217 and then pull me in if you're still
having trouble?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/multi-tenancy/pull/142?email_source=notifications&email_token=AM6RRQ67XM23EZGFBNOHHPLQOUJCBA5CNFSM4I7UHGSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBHB6WY#issuecomment-541990747,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6RRQ46KA7ZWQ5W5OIVHPTQOUJCBANCNFSM4I7UHGSA
.

Do you have any ideas on testing for propagation as well? Maybe set a condition, then a parent and then grab the object and test for a condition? The step I'm having the most trouble with is grabbing the correct namespace so I can test for a condition.

I don't think you need to set a condition to test the propagation. The OBJECT_METADATA condition should be set by your code in object controller if anything's wrong with the object metadata. You can just test in 2 steps:

Set finalizer (or deletion meta) to a src object and see if OBJECT_METADATA condition is set.
Set a child namespace to the src object namespace and see if the src object is propagated to this child namespace.

Thank you!
That actually answers all of my hanging questions.
I'll update tonight with more details and my rational.
On Tue, Oct 15, 2019, 8:59 AM yiqigao217<EMAIL_ADDRESS>wrote:

Do you have any ideas on testing for propagation as well? Maybe set a
condition, then a parent and then grab the object and test for a condition?
The step I'm having the most trouble with is grabbing the correct namespace
so I can test for a condition.
I don't think you need to set a condition to test the propagation. The
OBJECT_METADATA condition should be set by your code in object controller
if anything's wrong with the object metadata. You can just test in 2 steps:

Set finalizer (or deletion meta) to a src object and see if
OBJECT_METADATA condition is set.
Set a child namespace to the src object namespace and see if the src
object is propagated to this child namespace.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/multi-tenancy/pull/142?email_source=notifications&email_token=AM6RRQZMQ3NCVJCSUITIGGTQOXSEZA5CNFSM4I7UHGSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBJJXGQ#issuecomment-542284698,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6RRQ6KM4HP37QLUC2Z4J3QOXSEZANCNFSM4I7UHGSA
.

Ooh, I was confused about that for sure. I'll change the calls as it isn't
necessary to pass the namespace if it's passed with the instance.
On Tue, Oct 15, 2019, 8:21 AM yiqigao217<EMAIL_ADDRESS>wrote:

@yiqigao217 commented on this pull request.
In incubator/hnc/pkg/controllers/object_controller.go
https://github.com/kubernetes-sigs/multi-tenancy/pull/142#discussion_r335019206
:

@@ -284,14 +292,38 @@ func (r *ObjectReconciler) onDelete(ctx context.Context, log logr.Logger, nnm ty
return nil
}

+func (r *ObjectReconciler) ensureCanPropagate(nsNm string, inst *unstructured.Unstructured) bool {

r.Forest.Lock()
defer r.Forest.Unlock()
ns := r.Forest.Get(nsNm)
if !ns.Exists() {

return false

}
//TODO TAYLOR
var conditionString string
if len(strings.Split(r.GVK.String(), ".")) > 1 {

affected := strings.Split(r.GVK.String(), ".")

conditionString = fmt.Sprint(affected[0], "/", affected[1], "/", affected[2], "/", nsNm, "/", ns.Name())

The last piece in the string should be inst.GetName() since it's the name
of the object not namespace name. ns.Name() is the same as nsNm here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/multi-tenancy/pull/142?email_source=notifications&email_token=AM6RRQ5BPOCCDI4Q5W7BPS3QOXNV3A5CNFSM4I7UHGSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIABJLY#pullrequestreview-301995183,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6RRQ7IPSEVM22Y6FYRDKLQOXNV3ANCNFSM4I7UHGSA
.

I will continue work on this tomorrow night. Had some stuff come up.

Closing as @entro-pi told me they aren't ready to work on this for the time being.


dApp quickstart

Fast as possible walkthrough of setting up a dApp. Preview: https://docs-staging-git-dapp-quickstart-trili-tech.vercel.app/dApps/quickstart

Not sure it is a good idea to propose a quickstart with some "cooked" code.
If there is no step by step approach from scratch, you hide the complexity of installing some dependencies (taquito, etc...) and specific configuration (like the polyfills issues)
I fear that the reader wil not learn a lot, just runnning command to launch the app  :/

Also it just talk about the frontend part without explaining the link with a deployed smart contract. It think it is important to explain how this link is done

@zamrokk Ok, I've restored a version that walks you through setting up the app with svelte and copying the code in. It's basically a tutorial minus most of the explanation of what's going on.
I also figured  that because this is a dApp quickstart, it should use an existing smart contract and handle just setting up the web frontend. Later I can do a smart contract quickstart for the other side. What do you think?

Withdrawn. I'll add links from the landing page to the beginner-level tutorials and that's probably good enough as a quickstart.


activity checker

The bot randomly tags an user between 9 am and 5 pm. The user needs to react to the interaction within half an hour, or else the user loses karma. Ranging from 20-100 or something like that

Alsjeblieft niet

How about no

Wayo, harsh


Several fixes

Participants can be filtered by the default group of a meeting (Fixes #1175)
Groups in comment sections are translated (Fixes #1169)
Referenced motions will be appended to the extension field of a recommendation (Fixes #1168)
Supporter of motions are shown (Fixes #1166)
NotifyService is started up when going into a meeting. So, a channel id is received immediately if one is in a meeting.

@GabrielInTheWorld Linter still failed


Windows overlapping -> Cannot see signature help

I could probably make a PR for this if you want me to.
IMO then window layout should be calculated something like this:

calculate max(autocomplete.height, documentation.height) -> they should start on the same row
add height of signature help -> combined height
calculate top of total layout based on cursor relative to viewport, in signature help windows bottom row should be one row above cursor row, the other two windows top row should be one row below cursor.

But....what happens if there's not enough room in the viewport to fit the autocompletion window below the cursor?
It would have to be placed above. If that's the case then the signature help window would be placed awkwardly far above (or not displayed?).

calculate max(autocomplete.height, documentation.height) -> they should start on the same row

Totally agree

But....what happens if there's not enough room in the viewport to fit the autocompletion window below the cursor?
It would have to be placed above. If that's the case then the signature help window would be placed awkwardly far above (or not displayed?).

I was thinking it would make sense to put the signature help in place of the documentation, and have the documentation only show up on manual trigger. Wdyt?

I guess it's up to preference 🤷
I agree that displaying both signature help and autocompletion window is probably not gonna work.
So maybe add a field on blink.cmp.WindowConfig like displayWhenOverlapping.
Possible values signature-help and autocompletion. Default value signature-help

Also have the similar problem... but mine have the issue of also covering up the letter (there is a d under the signature help)

@Saghen  Any updates on this?

There are still cases where the autocomplete covers the signature help so I'll keep it open

The signature help will now move to the opposite side of the completion menu and the documentation window will not overlap it

Is there a configuration I need to set to prevent autocomplete overlapping the signature window?
When I autocomplete a function, the cursor moves inside the parentheses for inserting arguments. Without typing it shows the autocomplete menu while overlapping the signature float.


Instancing a viewport in runtime stops godot half a second

Godot version:

Godot 3 to 3.1 dev
OS/device including version:

Win 7 GeForce GTX 660/PCIe/SSE2
Issue description:

Playing a game from GodotJam2018 i find an issue that stops godot several frames. This is the game:
https://securas.itch.io/skrolls-of-thermos
(source is included)
The designer instance scenes that contain viewports. Every time one of this scenes is instanciated, godot spikes half a second (to big stutter, about 0.40 sec). Stutter happends in instancing, not in node entering tree. I don´t know if this behaviour of viewport is normal, but I report.
Steps to reproduce:
Open the game and play, in some computers, every time a enemy or a shoot is spammed, the multi-frame skip happends.
Minimal reproduction project:

https://github.com/securas/Skrolls-of-Thermos

Can anyone still reproduce this bug in Godot 3.2.1 or any later release (e.g. 3.2.2rc1)?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.
(the provided link is dead)

Closing due to no reply. Please comment if you can still reproduce in 3.2.3+.


Ḥover effect on buttons

I noticed there is no hover effect on buttons on home page , would you like me to work on it under hacktoberfest ?

I noticed there is no hover effect on buttons on home page , would you like me to work on it under hacktoberfest ?

Hii @PCoder23 yes please proceed 😇

Closes via #79


Kilic and Herumi give different root commitments

When comparing mainnet state conversion performed with kililc and herumi for #37, I noticed that the root commitments were different.

Kilic
Herumi
multiExpThreshold
width

e22e60…8e593c
f559f5…54e691
26
10

Both pass tests, so the offending sequence needs to be extracted from mainnet :neutral_face:

Fixed by upgrading to the latest go-kzg. Closing.


Flag to disable PhEDExInjector; setup to enable all datatiers in RucioInjector

Fixes #9946
Status
ready
Description
This PR provides:

a PhEDExInjector parameter to disable the component: enabled (default to True). If the component is disabled, it keeps running but not doing anything (returning on the 1st line of the algorithm method)
change how listTiersToInject parameter is handled in RucioInjector. If the component is enabled, and that list is empty, then it means the component is supposed to inject every single data produced by the agent against the Rucio system.

Is it backward compatible (if not, which system it affects?)
yes
Related PRs
none
External dependencies / deployment changes
none

This PR seems to be working fine. @todor-ivanov can you please review just in case I missed something?

Thanks for the review Todor. Code has been updated as per your suggestion.

Thanks for the review, Todor.


Add a web chat app

adding a web chat ui after that adding the server side using sockets

Hello @swapnilsparsh i thought it will be assigned to me.
Can i make a pr for this issue as it is not assigned to me.
i have solved this issue but it is not assigned to me that what to do sir?


Error LEDs fixed

This removes PermitStoreLocalCap from error LEDs since this is no longer supported in CHERIoT Ibex. It also make the cycling on FPGA go faster which is a nicer effect.

Thanks, I've updated the commit message!


README guide cannot be followed fully without edits done

https://github.com/nirmata/kyverno-notation-aws/blob/main/README.md?plain=1#L37 ain't from public ECR registry
844333597536.dkr.ecr.us-west-2.amazonaws.com/kyverno-demo:v1
So any follow of README.md will result to errors related to auth

I guess here preferable should be highlighted that you should build your own image for setup purposes, as it's not stated so, so that assumption is that image provided in documentation could be used for testing purposes - which wouldn't work as signer profile ain't available for everybody

We expect users to create their own image for this and not follow this example, but I can understand how this can be assumed, I will update the readme to make this more clear


USER STORY: Admin Delete Content

As an admin, I can delete any content added to the app by its users so that any offending content is removed.

Moved to backlog, to do after frontend done.


fix autocompletion bug

see https://codecombat-core.slack.com/archives/C49HU8WLA/p1680618586488659

i think we need to fix those.  otherwise the snippets won't work. see slack message i posted


how can I sample a random state from an environment?

In my project, I need to be able to sample a random but valid state (the underlying physics state, not the observation) from any environment, let's say cartpole.
In order to do that, I have to know the range of each element in qpos and qvel, however I cannot find any of those information online.
Can anyone help me with this please?

Hi @tungnd1705 . I think you'll have to access the internals of the mujoco-model structure (mjModel) in order to grab the information for the ranges of the joints (if these have a range). E.g. for cartpole there're two joints (see cartpole.xml):

The slide joint for the cart has a range of -1.8, +1.8, which you can grab from mjModel->jnt_range[ID_OF_SLIDE_JOINT], which is an array of 2 floats (min-max). You can access these fields by using the python bindings. I think the call could be something like this (the physics structure can be obtained from env.env._physics, or some other access point in the environment wrapper):

# get the id of the slide-joint (joint-name="slider")
jnt_id = physics.model.name2id['slider']
# grab the range of the slide joint (should be an ndarray of length 2)
jnt_range = physics.model.jnt_range[jnt_id]

The hinge joint for the cart has no range. Because it's an angle, you could assume it goes from [0-2*np.pi]. If this joint had a range, then you could access it in a similar way as the above example.

Note: I'm not quite sure regarding the bindings, but I think the core developers included support to access geoms, bodies and joints by their names, which would be a better option over having to grab the id and then grabbing the required information. Check this method, in which they access a field called named for name-based access
Note: I'm not sure if there are ways to access min-max ranges for qvel, as they can be in principle "unbounded" (unless simulation becomes unstable). I would use some reasonable defaults for these though, like some not-to-large ranges for velocities, etc.
In order to avoid having to check your model for each joint, you could iterate all valid joints of your model and check if they have range or not (querying the model.jnt_limited field). If you have limits, you grab them as in the example above, and if not, you could set them according to the joint-type, which you could grab using model.jnt_type, and if they're hinge-joints, you set a default of [0-2*np.pi], if they're slide-joints you could set a default of [-np.inf, np.inf], etc. I think the joints are parsed in order, so if you iterate over model.njnt (number of joints), then they relate in increasing order with their respective qpos. Also, the only way to increase add a qpos is by adding a joint (which can add 1,3,4,7 qpos values, depending of the joint-type), so I'm pretty sure all your q-values for the random-state you want to sample would have the correct ranges (if any).
Here's the Mujoco API-reference in case you need it api-ref.. If you still have any issues just post a comment :smile: .

thank you @wpumacay , you comment helped a lot
I also found this, which is pretty all I need to sample a random state

Great @tungnd1705 :smile: . I think you could close this issue if there's no more help needed related to this issue :+1: .


[Port Request] 1.20.2

Can we get this ported to 1.20.2?

You can find a 1.20.4 version on my fork. If you really need .2 specifically, I can probably get that working too


New Tooltips implementation

Closes #239
Closes #20

I opened https://github.com/readthedocs/addons/pull/422 with some of the work missing here.

Marking this ready for review so @agjohnson can take a look if he wants.


Changed font on metadata editor

This fixes #465
Added textarea and input to index.css. Now the font and the size is the same. (It only affects metadata page)

Without 'input' in css

With 'input' in css


Hello, will there be a new version of this addon?

This addon is excellent and it's irreplaceable for me, major of my study is based on it. So I really expect a update of this addon

@s609078902 I'm reaching out to @luoliyan at his email address to ask about the same.
But in the mean time, I've fixed a couple issues and published the fixes in https://ankiweb.net/shared/info/999215520.

@s609078902 I'm reaching out to @luoliyan at their email address to ask about the same.
But in the mean time, I've fixed a couple issues and published the fixes in https://ankiweb.net/shared/info/999215520.

That's a good news for me. Thank you for your contribution.

I'm only testing with the latest version right now.
Here's the version on my machine:
Version 2.1.54 (b6a7760c)
Python 3.9.10 Qt 6.3.1 PyQt 6.3.1


Sync Triggers needs to respect Disabled functions

Function metadata also supports a "disabled" attribute as follows:
{
  "disabled": true,
  "bindings": {
    "input": [
      {
        "type": "timerTrigger",
        "schedule": "05:00:00"
      }
    ]
  }
}

The function runtime does not run a disabled function (e.g. it won't be polling the queue, running the timer, etc.). Details on format can be found in the wiki here: https://github.com/Azure/azure-webjobs-sdk-script/wiki/function.json.

It'd be so much easier if there was a way to do this from the Functions app instead of Kudu.

I don't understand your comment David. I created this issue because currently the Kudu API is the one choosing which functions to report back with and it needs to take this into account. The Functions app portal will have a toggle button mapping to this setting.

I meant that ideally we'd find a way for this logic to exists in the functions app instead. Right now, we're in a bit of a strange situation as Functions effectively have a split management API, some of it in Kudu and some of it in Functions app.

Hi
Kudu will continue to run in Azure App Service. However, this repo will no longer be maintained.
If the problem persists and is related to running on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


UI: fix hover over for entity cards

Hover on the emoji and the reply should stay longer and cover the entire panel, each reply in a thread should have the entire panel and can hover to get the emoji reply button. The highlighter in the above image should be expanded its cutting over the text.

https://user-images.githubusercontent.com/38649/175785139-2e4b43d6-8ccf-4be2-9303-a30609227abe.mov

[ ] Increase the Size of the hover box and icons inside it.

[ ] Increase the Size of the emoji's


CHECKS run on non-web containers

The documentation seems to indicate that CHECKS should only happen on web procs, however from the output below (on 0.4.3) it seems to be running the CHECKS for every type:
-----> DOKKU_SCALE file found
=====> web=1
=====> worker=1
-----> Running pre-flight checks
       For more efficient zero downtime deployments, create a file CHECKS.
       See http://progrium.viewdocs.io/dokku/checks-examples.md for examples
       CHECKS file not found in container: Running simple container check...
-----> Waiting for 10 seconds ...
-----> Default container check successful!
=====> xxx container output:
=====> end xxx container output
-----> Running pre-flight checks
       For more efficient zero downtime deployments, create a file CHECKS.
       See http://progrium.viewdocs.io/dokku/checks-examples.md for examples
       CHECKS file not found in container: Running simple container check...
-----> Waiting for 10 seconds ...
-----> Default container check successful!
=====> xxx container output:
=====> end xxx container output

We run a basic "are the containers up" check on deploy. I'd have to look at the code to see what exactly we should be doing/documented as doing.

We definitely run a default timeout-style check on all containers.
https://github.com/progrium/dokku/blob/de832c596a92631f70f6c83eea4bce8a8efe59e5/plugins/checks/check-deploy#L82-L107
It should also be noted the documentation states dokku runs custom checks on the web proctype.
The web proctype is the only proctype that will invoke custom checks as defined by a CHECKS file.

We definitely run a default timeout-style check on all containers.

:+1:, thanks for clarifying.

We can definitely be more clear in the docs (and in fact just point people to the zero-downtime deploys page).

I'd like to request an option to skip checks for non web containers.
In my case, I'm checking that my Rails app is up, and the other process is a Resque worker. It's safe to fire up another worker in any case, so I'd like to skip the check.
Maybe the CHECKS file should be divided by process type DOKKU_SCALE and we could set SKIP=true or something along those lines?
(Sorry, I'm not sure where feature requests like this should go...)

@trevorturk mind opening up another issue and explaining how this feature might work?


Allocation timeout flag

Add a flag for specifying timeout period for waiting for allocations of nodes.
Usage example: make beztest REGEXP="--allocationTimeout=1"

why is this feature needed? what is the problem you are trying to solve?


Interaction with Casper smart-contract source code verification service for feat-2.0 branch

Port of changes from https://github.com/casper-ecosystem/casper-client-rs/pull/144/files adjusted to be merged into the branch tracking Node version 2.0

Hey guys, can we merge the PR on dev first ? and then we need to fix CI/CD on feat-tracke-node-2.0 because right now this branch is not CI/CD checked.

@wojcik91 can you please pull feat-track-2.0 to remove that removes vergen dependency ?

@gRoussac I applied your review suggestions.

@wojcik91 I need to checkout your branch to see what clippy complains about
error: package `clap_lex v0.7.2` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.73.0
Error: Either upgrade to rustc 1.74 or newer, or use
cargo update -p<EMAIL_ADDRESS>--precise ver
where `ver` is the latest version of `clap_lex` supporting rustc 1.73.0

@wojcik91 I think the best would be to bump the toolchain as per casper-node seeting
Please make this change reviewed by @mpapierski
https://github.com/teonite/casper-client-rs/pull/3

@wojcik91 I think the best would be to bump the toolchain as per casper-node setting
Please make this change reviewed by @mpapierski
teonite#3

I merged the update and it seems that locally it works now.
Just out of curiosity - is there a specific reason why this project is not using a lockfile? Previously I did not notice this issue because this specific dependency was at 0.6.0 in my Cargo.lock.

I see the test failure, will resolve.

Just out of curiosity - is there a specific reason why this project is not using a lockfile? Previously I did not notice this issue because this specific dependency was at 0.6.0 in my Cargo.lock.

it's a long debate I have no opinion, I think committing lock files either rust or npm has pros and cons. Right now we have it on casper-nod, not on the client, the client is more simple it should just pass CI/CD with cargo update in any case. We can not decide this for your PR but it might be considered I guess.

Just out of curiosity - is there a specific reason why this project is not using a lockfile? Previously I did not notice this issue because this specific dependency was at 0.6.0 in my Cargo.lock.

it's a long debate I have no opinion, I think committing lock files either rust or npm has pros and cons. Right now we have it on casper-nod, not on the client, the client is more simple it should just pass CI/CD with cargo update in any case. We can not decide this for your PR but it might be considered I guess.

Sure, I certainly don't aim to convince anyone to make any sweeping changes as part of this PR :)
Just thought there was some project-specific reason I did not consider since it seems unorthodox.

@wojcik91 Please review/merge this PR https://github.com/teonite/casper-client-rs/pull/5


One last edge case for private team scanning

There's still an edge case with team scanning. If one does not provide -scanPrivateReposOnly=true, https auth is still requested for repo cloning:
# ./gitallsecrets -token=xxx -org=xxx -orgOnly=1 -teamName=xxxxxx -toolName=thog -user=""
Org was specified combined with orgOnly, the tool will proceed to scan only the org repos and nothing related to its users
Cloning the repositories of the organization: SimpliSafe
If the token provided belongs to a user in this organization, this will also clone all public AND private repositories of this org, irrespecitve of the scanPrivateReposOnly flag being set..
https://github.com/...
xxxxx fork and the cloneFork flag was set to false so moving on..
Done cloning org repos.
Since team name was provided, the tool will clone all repos to which the team has access
Listing teams...
Cloning the repositories of the team: XXXXXXXXX(NNNNNNNN)
Listing team repositories...
https://github.com/xxx/...
https://github.com/xxx/...
https://github.com/xxx/...
...

Username for 'https://github.com': Username for 'https://github.com': Username for 'https://github.com': Username for 'https://github.com': Username for 'https://github.com': Username for 'https://github.com': Username for 'https://github.com': Username for 'https://github.com': Username for 'https://github.com': Username for 'https://github.com': ^C

If one does provide -scanPrivateReposOnly=true, then the team based scanning is not done:
# ./gitallsecrets -token=xxx -org=xxx -orgOnly=1 -teamName=xxxxxx -toolName=thog -scanPrivateReposOnly=true
scanPrivateReposOnly flag is provided with either the user, the repoURL or the org
Checking to see if the SSH key exists or not..
SSH key exists and file size > 0 so continuing..
scanPrivateReposOnly flag is provided along with the org
Checking to see if the token provided belongs to a user in the org or not..
Even though the token belongs to a user in this org, there are no Private repos in this org

With the attached fix, private team scanning does run:
# ./gitallsecrets -token=xxx -org=xxx -orgOnly=1 -teamName=xxxxxx -toolName=thog -scanPrivateReposOnly=true
scanPrivateReposOnly flag is provided with either the user, the repoURL or the org
Checking to see if the SSH key exists or not..
SSH key exists and file size > 0 so continuing..
Org was specified combined with orgOnly, the tool will proceed to scan only the org repos and nothing related to its users
Cloning the repositories of the organization: SimpliSafe
If the token provided belongs to a user in this organization, this will also clone all public AND private repositories of this org, irrespecitve of the scanPrivateReposOnly flag being set..
xxx is a fork and the cloneFork flag was set to false so moving on..
git@github.com:xxx/...
Done cloning org repos.
Since team name was provided, the tool will clone all repos to which the team has access
Listing teams...
Cloning the repositories of the team: xxxxxx(NNNNNNN)
Listing team repositories...
git@github.com:xxx/...
git@github.com:xxx/...
xxx is a fork and the cloneFork flag was set to false so moving on..
...

Matt

@matthew-cox I was finally able to get this merged. Sigh!! We also made a couple other changes, that I think, you might like!


Simplify Controller Workflow

This PR makes the following changes to the snapshot controller
workflow:

After a snapshot creation request is sent to the plugin,
create VolumeSnapshotData object first, and then bind
VolumeSnapshotData to VolumeSnapshot and update VolumeSnapshot
status.
Simplify getSnapshotStatus function because now VolumeSnapshotData
would have been created if status is Pending.

/lgtm

/lgtm


feat: add user and channel names

Adding user names and channel names to labels.
I know this may not be idea, as names can change, but this is something my server admins wanted and are now using, so I at least wanted to contribute back my changes.
I am not a java dev so if anything needs cleaned up let me know and I will try my best.
Awesome project!

Thanks for the PR. I think we could make this an optional feature which can be toggled using a enviroment variable.

Thanks for the PR. I think we could make this an optional feature which can be toggled using a enviroment variable.

At what level in your code do you want that checked? Like I mentioned I am not a java dev but I would love to take a crack at it, just want to make sure I follow your direction.


Add Apache container

Have apache work as a dropdown replacement for nginx (VirtualHost configs, ssl, routing, etc.).

@Mvzundert Watch this for Apache SSL certs support

closed by #87


Same shortcut for two different actions

I have set up a shortcut in skhdrc to toggle the topmost of sketchybar using two different key combinations:
# sketchybar
fn - b : sketchybar --bar topmost=on
fn - m : sketchybar --bar topmost=off

Is it possible to toggle the topmost with just one combination? If topmost is "on", turn it "off", and vice versa?

One option would be to use sketchybar --query and jq to find if the value of the setting and decide what to do from there. For example:
# in a script file somewhere (I keep mine in ~/.config/skhd/scripts)

# -- topmost.sh -- #
#!/usr/bin/env bash

# queries sketchybar's bar element and returns a JSON object with properties
# jq filters for the "topmost" property in the object and returns true if the value of topmost is "on"
if $(sketchybar --query bar | jq '.topmost == "on"'); then
  # if topmost is on, turn off
  sketchybar --bar topmost=off
else
  # vice versa
  sketchybar --bar topmost=on
fi

Then in skhdrc:
fn - m : ~/.config/skhd/scripts/topmost.sh


PP-149 Refactor Acquisition feeds and Annotators

Currently, please ignore all OPDS2 classes, they are just POCs.
Description
This aims to remove all XML directives from within the feed and annotator workflows And also to simplify the workflow making it more linear and less circular Only a Serializer should write XML to the feed.
The feed workflow should always be AcquisitionFeed -> Annotator -> Serializer, as opposed to the back and forth that was occurring earlier.
About 70% of the time that went into this PR refactoring tests and understanding the different paradigms used in the existing code.
This is not a complete rewrite, all the logic has been left as-is without any changes.
Feed Class
Only bothers with the outer shell of the feed, which is everything except the publications in OPDS2 and <entry>'s in OPDS1.
Eg. The facet links and other metadata.
Annotator Class
Populates the data required for each work entry and may also potentially add some additional metadata into the outer feed.
Serializer Class
Accepts pydantic models and outputs the OPDS feed in whichever format it is responsible for.
Pydantic Models
We use pydantic models (FeedEntryType's) to store the annotated information for the feed as well as for each entry.
The FeedEntryType model is the base model for any nestable attribute of the OPDS feeds.
Eg. If we have an acquisition link, we know this is nestable with indirectAcquisitions, so all links are inherited from the FeedEntryType models so they can have arbitrary information added into them.
:warning: XML cache fields :warning:
The model fields Work.simple_opds_entry and Work.verbose_opds_entry are not used in this implementation because the implementation is specifically not targetting XML.
This means we no longer have an internal partial cache of XML entries per work record.

Motivation and Context
In order to allow all API feeds to be served in both OPDS1 and OPDS2 protocols all the XML generation had to be extricated from the Feed and Annotator classes, and pushed into a separate serializer class.
JIRA

How Has This Been Tested?
All the Feed and Annotator tests were copied and refactored to work with the new style classes.
All the Feeds and Annotators have unit tests that test the equivalence between the old and new style classes, thereby ensuring we are creating exactly the same feeds.
Manually tested whichever endpoints came to mind.

Checklist

[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.

I'm just starting the code review on this, but one thing that I see immediately is it would be really nice if we had some type hints on all this new code.
Ideally I'd like to see  core.feed_protocol.* added to the strict section of the tool.mypy.overrides config, so that we enforce type checking there.
diff --git a/pyproject.toml b/pyproject.toml
index 6e503ae69..9e9d59a81 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -74,6 +74,7 @@ module = [
     "api.adobe_vendor_id",
     "api.circulation",
     "api.integration.*",
+    "core.feed_protocol.*",
     "core.integration.*",
     "core.model.announcements",
     "core.model.hassessioncache",

I might just be misunderstanding the design here, but why use Pydantic over a normal Python dataclasses for the classes in types.py? Pydantic is great for validating data, but I don't see where we are taking advantage of that validation functionality here.

I might just be misunderstanding the design here, but why use Pydantic over a normal Python dataclasses for the classes in types.py? Pydantic is great for validating data, but I don't see where we are taking advantage of that validation functionality here.

One reason was to have validations, which ended up not being required (yet).
Another reason was to allow arbitrary values into the init method as is used with the FeedEntryType.
This class can be used to add arbitrary data to any part of the feed/entry.
Eg. The subject classifications are FeedEntryTypes with additional keys 'scheme', 'label' and 'term'.
If we use dataclasses, we would need to create special data types for all the different kinds of tags/keys possible, which isn't terrible but just adds to the coding overhead.

Thanks @RishiDiwanTT. I'll code review the rest of this today.

@jonathangreen I think I got everything, and rebased #1340 as well to allow simultaneous code reviews.

@RishiDiwanTT I went through and resolved all the comments that were addressed. Looks like there are a couple more with some work left to do on them.
The other thing is this comment:

Before this is merged I'd like to figure out what we do with the old annotator and feed code. I'd prefer that we remove the old feed and annotator classes (including updating the database to remove the unused cache fields) as part of this PR, think they confuse things, now that we have the new classes that are part of this PR. However I'm open to handling this however you would like, if you want to remove them in a future ticket instead.

How would you like to handle this?

@RishiDiwanTT I went through and resolved all the comments that were addressed. Looks like there are a couple more with some work left to do on them.
The other thing is this comment:

Before this is merged I'd like to figure out what we do with the old annotator and feed code. I'd prefer that we remove the old feed and annotator classes (including updating the database to remove the unused cache fields) as part of this PR, think they confuse things, now that we have the new classes that are part of this PR. However I'm open to handling this however you would like, if you want to remove them in a future ticket instead.

How would you like to handle this?

@jonathangreen Considering both PRs are still in-progress I would like to take this up as an additional ticket, since this may need some effort to ensure we're not breaking some dependant functionality still in use.

Okay looks like all the comments are resolved here. Since we are removing the old classes in a followup, can you make a jira ticket for that @RishiDiwanTT?

Once https://github.com/ThePalaceProject/circulation/pull/1340 gets merged into this, I think there at two things that we need to do before this one can get merged:

Rename feed_protocol directory
Update to main and remove the couple references to the self_hosted variable that was removed in https://github.com/ThePalaceProject/circulation/pull/1344.


Bug: Language detection

The PR for language detection, loops through the array and replaces the latest extension with the latter.
e.g. If the last file to walk through is a .js file in a typescript codebase, the language is detected as Javascript.
@hacktivist123

Oh yes, I haven’t created a specific file for typescript projects yet so since Typescript is mostly JavaScript. I just default to generating a JavaScript gitignore for ts files for now.
Unless I didn’t get your issue

Check the PR I'll open next (I'll leave it as a draft), You can let me know if you want me to test it and you can merge it.

I didn’t consider this edge case, damn! Good catch.
I’ll test it out and merge.
Open the PR for merge .

I will do that, I need to ignore directories that start with (.). The WalkDir traverses through .git directory  🥲

fixed in #20


Understand and document our Next.js 15 support

We should investigate, fully understand and document our adapter support for Next.js 15, to what extent we support this version of Next.js and what feature of it we support and which we don't

[!Note]
This for our currently experimental prerelease package

@vicb I think you should already have a pretty good idea of the support for Next.js 15, but I don't think you have a 100% clear idea of the extent of our support for it, or do you?
Please feel free to add to the issue any extra context you have 🙂

The Next (15 or earlier) is a valid question.
I think we have issues for all the known gaps.
The first "TODO" issue on the project board is about adding more tests which should give us a better understand about where we stand.
As this issue is not actionable and has no good definition of done, you should consider moving it to a discussion.

As this issue is not actionable and has no good definition of done, you should consider moving it to a discussion.

I'm not sure how this is not actionable and doesn't have a good definition of done 😕 (definition of done === our supported doc is updated with Next.js 15 and all its features)
Anyways if you find this issue not valuable for tracking purposes please feel free to close it, no hard feelings 🙂

Maybe we can use #108 (investigation) and #159 (docs) adding specific points there?

Ok, I've added comments there 🙂
Thanks 👍


gtexpcube2 outdated options for PASS8

At http://fermi.gsfc.nasa.gov/ssc/data/analysis/scitools/binned_likelihood_tutorial.html
it is written:
"If you provide gtexpcube2 a filename for your counts cube, it will use the information from that file to define the geometry of the exposure map. This is legacy behavior and will not give you the necessary 20Â° buffer you need to completely account for the exposure of nearby sources. (It will also cause an error in the next step.) Instead, you should specify the appropriate geometry for the exposure map, remembering that the counts cube used 0.2 degree pixel binning. To do that, enter 'none' when asked for a Counts cube."
What ENRICO does is  to pass gtexpcube2 the CCUBE from which it takes the geometry (hence putting the xref and yref nxpix and nypix options as INDEF). Would it be possible to set these geometrical options taking the numbers from the configuration files as now suggested in the Fermi SCience Tool tutorial?
Thank you in advance,
Roberta
cc @zblz @davidsanchez

Hi
the function GtBinnedMap in gtfunction.py set up the use of gtexpcube2 by giving a ccube file. this cube file is generated with
    evtbin['nxpix'] = self.npix
    evtbin['nypix'] = self.npix
    evtbin['binsz'] = self.binsz

and
#Maps binning
self.binsz     = self.Configuration['space']['binsz']
self.npix      = int(2*self.roi/sqrt(2.)/self.binsz)
best
david

I have close this issue. reopen it if needed


Add integration tests

Description
This pull request adds a Github Actions Workflow to run our integration tests. It should run automatically on pull requests from branches on the base repository and has access to Github Secrets to gather credentials for running tests. But due to some issues with our cloud workspace setup, the tests will all fail right now. So for this PR we've set the workflow to only run on the workflow_dispatch event, which means a user must click a button to start the workflow. Once we square away the workspace setup with the DECO team we'll make a follow-up PR to run these automatically.
Checklist

[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

This PR has been on-hold while we fixed permissions issues on the SQL warehouse. We needed to GRANT CREATE ON hive_metastore TO <service principal user id>. I tested locally to confirm this works. It does! So just now I manually kicked-off a Github Actions workflow to run all our integration tests. If this passes, I will merge.

It's not presented in the "All checks have passed" badging at the bottom of this PR because the change hasn't merged to main yet. But you can see the outcome of the action run here: https://github.com/databricks/dbt-databricks/actions/runs/4206303847/jobs/7549931337

Progress: all the functional tests are now passing but the integration tests fail. We presently invoke these tests manually with pytest in the Github action. Whereas during local development we use tox.
We skipped tox on the github action initially because we couldn't figure out how to pass the environment secrets to tox in a way that didn't leak secret material in the GH action logs. By invoking pytest directly we avoided that issue. But since invoking pytest directly won't work for the integration tests we must now return to the problem of how to use tox in GH actions without leaking sensitive data.


[DOC] Updated knn docs

Description

Added input to KNN

/intelci: run

@napetrov please confirm it's ok to merge


[$1000]  IOU - Currency edit in confirmation page causes missing header and wrong redirection

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/26520
Action Performed:

Go to staging.new.expensify.com
Go to + > Request money > Enter an amount > Select a payer
On confirmation page, click on the Amount
Edit the amount only > Click Next
On the confirmation page, click on the Amount again
Change the currency
Click Next

Expected Result:
In Step 6, Amount header does not disappear
In Step 7, user is redirected to the confirmation page
Actual Result:
In Step 6, Amount header disappears
In Step 7, user is redirected to the payer selection page. This is a different behavior observed in Step 4 when user is redirected to the confirmation page when the amount is changed
Action Performed:

Go to staging.new.expensify.com
Go to + > Request money
Enter an amount
Change the currency

Expected Result:
The amount is preserved and does not change
Actual Result:
The amount is not preserved and it changes to zero
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.62-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/c6c4b202-6dba-4f2a-8a31-113c072902f2
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010711a82a596d6dcc
Upwork Job ID:<PHONE_NUMBER>758937600
Last Price Increase: 2023-09-03

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
https://github.com/Expensify/App/commit/470c54a37f80f4b9782b3d48b55394cd107d4d2a caused regression.
https://github.com/Expensify/App/blob/e088539f32561dca5e0490300bd9e5684cd54d04/src/pages/iou/IOUCurrencySelection.js#L87
In this code snippet, the goBack function with true as the second parameter replaces the modal without considering the previous state. This leads to unexpected behavior, such as the issue we've encountered and the resetting of text input.
What changes do you think we should make in order to solve the problem?
We should use Navigation.navigate function instead of goBack function.
Navigation.navigate(`${props.route.params.backTo}?currency=${option.currencyCode}`);

What alternative solutions did you explore? (Optional)
N/A

@marcaaron If you have no problem, we should combine this with https://github.com/Expensify/App/issues/26587

This was probably caused by Wave 5 PRs. We need to solve this my Monday and it's weekend.
I gonna make this external to get immediate proposals and PRs

Combined with https://github.com/Expensify/App/issues/26587

@hayata-suenaga could you please take a look here? I can make PR ASAP.

@napster125 could you kindly post a video showing navigation still works after your changes and then we can proceed with your PR

of course!
https://github.com/Expensify/App/assets/136437976/7ccd8524-46a2-469b-a057-19d827325574

@napster125
also do you think this one is also somehow related to this issue?

No, I have seen this issue but I think it's not triggering pressOnEnter. But I'm not sure why.

@hayata-suenaga Also, I think it was happening before.

@napster125 perfect! thank you for the video
I remember that the particular commit you linked was aded to solve an issue with the following flow:
workspace chat -> request money -> distance request -> add Start and Finish -> Next -> edit the amount -> save -> correctly taken back to the previous screen
can you also test this flow little quick with your change and link the video 🙇 🙇 🙇

@hayata-suenaga I am unable to edit the amount on the confirmation page. Is this intentional?

@hayata-suenaga me too, I can't reproduce such flow.

@hayata-suenaga I am unable to edit the amount on the confirmation page. Is this intentional?

checkout right now...

I'm looking forward to your PR @napster125 🚀

@hayata-suenaga I have applied on Upwork. My Upwork profile url is https://www.upwork.com/freelancers/~01212c68bbcaede4db.

@napster125 Do you have the PR ready? I can make it right now and you could do a review and checlist? Are you available to do that in coming hours?

@napster125 Whats you Slack handle?

I have just make a commit and am making the PR. And my slack name is Pluto.

Thanks, awaiting your PR, please post it in the Slack thread once raised https://expensify.slack.com/archives/C01GTK53T8Q/p1693731985567709?thread_ts=1693696719.158669&cid=C01GTK53T8Q

This is fixed in staging

Providing there's no regressions, I'm correct in saying that $1500 is due to @napster125?

@sophiepintoraetz thats right and that should be the only payment here, thanks!

Offer sent - I'll release payment on 11 Sep

Actually, I'm going to close this one out and create a new one with the appropriate issue, seeing as payment is the only thing left here.


Add possibility to open PDF at a specific page

As stated in the title, I would love the feature to be able to open the full PDFs at a specific page.
In my usecase we settled on filtering out the specific page we wanted to open at, but opening at the right page would be much smoother.

Thanks! Opening the PDF at a specific page would come a very handy feature. However, my experience with streamlit is not deep and moving to a specific page means scrolling down the PDF to a certain place. I'm currently not sure how this could or should be implemented, but I'm happy to follow suggestions.

Have not delved too deep into your code, but before swapping to your code we used something like this:
import base64
import streamlit as st
import fitz

if __name__ == "__main__":
    file = fitz.open(file, filetype="pdf")
    file = file.write()
    base64_pdf = base64.b64encode(file).decode("utf-8")
    st.markdown(
        f'<iframe src="data:application/pdf;base64,{base64_pdf}#page={page_number}" type="application/pdf"></iframe>',
    )

        )

Where we used the #page=page_number that seems to be part of some standard pdf string.
This would not require any scrolling if you use this kind of string somewhere!

Thanks!
@solita-tsjoberg are you using the rendering=legacy_iframe or legacy_embed?
We could easily add this parameter to it, but this method works only on a small subset of  browsers when used by a separate component.
In fact, I was thinking to remove it completely at some point, but it seems it's still used more than I though. 🤔

Neither, we are using the default unwrap rendering.

@solita-tsjoberg the version 0.0.18-dev0 should have what you need using the unwrap rendering.
Please see here, and here for more details.