[style] format-code in Python, supports --base

Rewrite the format-code Shell script into Python, and make it support "--base=..." argument.
The refactoring is for better maintainability, and the "--base" arg allows reformatting the whole repository instead of the current diff.

This seems to work, though the way that these two python scripts interact with each other is very sad

Yeah it's slightly awkward, although one can argue it's Unix-philosophy :) smaller programs, doing separate items of work, and their combinations.
A more Python-friendly way would probably be to move the core stuff into a separate "lib" .py file that's included from "CLI" .py files, but I felt it's too heavy-weight for 2 use cases. Also the headache with Python's import story. I'll keep this option in mind though.

This seems to work, though the way that these two python scripts interact with each other is very sad

Yeah it's slightly awkward, although one can argue it's Unix-philosophy :) smaller programs, doing separate items of work, and their combinations.
A more Python-friendly way would probably be to move the core stuff into a separate "lib" .py file that's included from "CLI" .py files, but I felt it's too heavy-weight for 2 use cases. Also the headache with Python's import story. I'll keep this option in mind though.

I think I would just have the lib part be a function in find-files-for-linting. The main() of find-files-for-linting would call it and print the output to CLI, while this file could call it directly.
I have not had headaches with python imports before - especially with two scripts that are co-located. Could you elaborate?

This seems to work, though the way that these two python scripts interact with each other is very sad

Yeah it's slightly awkward, although one can argue it's Unix-philosophy :) smaller programs, doing separate items of work, and their combinations.
A more Python-friendly way would probably be to move the core stuff into a separate "lib" .py file that's included from "CLI" .py files, but I felt it's too heavy-weight for 2 use cases. Also the headache with Python's import story. I'll keep this option in mind though.

I think I would just have the lib part be a function in find-files-for-linting. The main() of find-files-for-linting would call it and print the output to CLI, while this file could call it directly. I have not had headaches with python imports before - especially with two scripts that are co-located. Could you elaborate?

OK, let me try that out!
As for imports - it's usually related to import search paths. A random example from Chromium repository - it's a nice combo of prepending, appending, preloading and reloading modules just to make the interpreter happy: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ash/policy/tools/generate_device_policy_remover.py;l=43-58;drc=4a8573cb240df29b0e4d9820303538fb28e31d84

This seems to work, though the way that these two python scripts interact with each other is very sad

Yeah it's slightly awkward, although one can argue it's Unix-philosophy :) smaller programs, doing separate items of work, and their combinations.
A more Python-friendly way would probably be to move the core stuff into a separate "lib" .py file that's included from "CLI" .py files, but I felt it's too heavy-weight for 2 use cases. Also the headache with Python's import story. I'll keep this option in mind though.

I think I would just have the lib part be a function in find-files-for-linting. The main() of find-files-for-linting would call it and print the output to CLI, while this file could call it directly. I have not had headaches with python imports before - especially with two scripts that are co-located. Could you elaborate?

OK, let me try that out!
As for imports - it's usually related to import search paths. A random example from Chromium repository - it's a nice combo of prepending, appending, preloading and reloading modules just to make the interpreter happy: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ash/policy/tools/generate_device_policy_remover.py;l=43-58;drc=4a8573cb240df29b0e4d9820303538fb28e31d84

Addressing this in #1045.


Side Bar Arrow Direction Incorrect in Hebrew Locale

I've noticed that the side bar arrow on the Hebrew version of the website is pointing in the opposite direction of what is expected.
https://github.com/user-attachments/assets/9f6815cc-0870-4bb0-9e9b-68bac1100165

Working on it.

I fixed it,
I can't push the changes to brunch,
How can I get permission for this?

fixed successfully


replace text using python docx

I try to change the text in the original docx - file.
I wrote the codes:
for paragraph in document.paragraphs:
for run in paragraph.runs:
if run.font.size:
run.text = ' " ' + run.text + ' " '
but the order dosen't replace the text in the original file.

you might want to double check the if statement; because this code example works for me:
from docx import Document
document = Document()
par = document.add_paragraph('test text')
for paragraph in document.paragraphs:
    for run in paragraph.runs:
#         if run.font.size:
        run.text = ' " ' + run.text + ' " '

for paragraph in document.paragraphs:
    for run in paragraph.runs:
        print(run.text)
>>>   " test text "

thx, but I want python to add quotation marks only while the font text size is 15 and not for each run...
In addition, I thought about it, and if python will add quotation marks to each run, it might to add
it even when there is a sequence of run in size 15, therefor, prehaps I will need to order:
"while run.font.size...."
[likes for "HELLO WORLD i like to..." --> " 'HELLO' 'WORLD' i like to..." (I use upper case to present
letter in size 15). Anyway, right now I didn't succeed do it even for each run.

Is this really an issue? Can it be closed?

Try reading the font size from paragraph.style.font.size instead of reading it from paragraph.runs....

@MaaleRw StackOverflow is a good place for learning-support questions like this. Make sure you use the "python-docx" tag on the question so those of us that follow that tag will see it.


Don't emit mutable globals

A proposed fix for https://github.com/rustwasm/wasm-bindgen/issues/2386, based on @alexcrichton's comment here: https://github.com/rustwasm/wasm-bindgen/issues/2386#issuecomment-738266000
We emit a shim function that sets the stack pointer, so we can avoid emitting mutable globals.
Mutable globals aren't supported everywhere Wasm is.
This PR seems to pass tests, but I believe it doesn't actually avoid exporting the stack pointer yet.
I'm not sure where to look for that, and I imagine we should add a test to ensure we actually don't export mutable globals.
This is my first foray into the wasm-bindgen codebase, so I expect there to be some mistakes in this code.
I think I might still need to modify export_shadow_stack_pointer to not export it to the wasm module...

I've resolved all the comments from your preview review :)

Thanks!

Which version will include the improvement? I need it as well. @alexcrichton

Which version will include the improvement? I need it as well. @alexcrichton

I've done a version bump at https://github.com/rustwasm/wasm-bindgen/pull/2435

I've done a version bump at https://github.com/rustwasm/wasm-bindgen/pull/2435


Exclamation mark comment support in fixed format mode

Using Punchcard mode, Intel Fortran and gfortran support the exclamation mark to put inline comments at the end of a line. I was able to enable this functionality by adding the following pattern in fortran.tmLanguage:
	<dict>
		<key>begin</key>
		<string>(^[ \t]+)?(?=!-)</string>
		<key>beginCaptures</key>
		<dict>
			<key>1</key>
			<dict>
				<key>name</key>
				<string>punctuation.whitespace.comment.leading.ruby</string>
			</dict>
		</dict>
		<key>end</key>
		<string>(?!\G)</string>
		<key>patterns</key>
		<array>
			<dict>
				<key>begin</key>
				<string>!-</string>
				<key>beginCaptures</key>
				<dict>
					<key>0</key>
					<dict>
						<key>name</key>
						<string>punctuation.definition.comment.fortran</string>
					</dict>
				</dict>
				<key>end</key>
				<string>\n</string>
				<key>name</key>
				<string>comment.line.exclamation.mark.fortran.modern</string>
				<key>patterns</key>
				<array>
					<dict>
						<key>match</key>
						<string>\\\s*\n</string>
					</dict>
				</array>
			</dict>
		</array>
	</dict>

The pattern is directly taken from modern.tmLanguage.

I would like to try this but cannot locate fortran.tmLanguage... Where is it supposed to be? Thanks.

@Cordusio I would be glad to get a bit of help. The fortran.tmLanguage is located in the syntaxes folder

This is not an issue for me anymore. I am closing it. Feel free to reopen if still needed.


Where can I donate?

Do you have a Paypal? Patreon? Some sort of avenue for donating?
All other drag and drop solutions were too costly but this one works and is free.
Where can I donate for the work you put into it?

I'm glad you find this project useful.  I, too, found the commercial add-ins way too expensive for this basic functionality, especially if you want to deploy it across all the computers in an entire organization.
I added a donate button on the main page/readme file.  Thanks!


Mobile - SEM Pages - Form Rendering Issue

The /forms/campaign-variants/get-a-quote-campaign.json  form is not rendering properly on mobile. This is happening on all pages that use this form.
Example: https://www.shredit.com/en-us/marketing/23purge

This issue is now fixed. via: https://github.com/aemsites/stericycle-shared/pull/552

@ravise5 rendering issue flagged previously however it is now rendering too narrow. can we see that it spans the full width of the mobile margins?
EDS

Live:


Event Silence

during an event  we should silence all output not initiated by a broadcaster or guest

what do you mean by "event" ?

Event as in special event. Sometimes some of the broadcasts get special guests that pick the songs for an hour.

/beQuiet, by default for whiteListed people, on the plugin 'quiet'.


Harkness component (for assessing harkness tables) not finished

This page needs to be made functional, and link from the AddHarkness component. It should include:

timer (already created but needs to have the time saved)
a list of students (clickable)
when you click on a student's name, it should allow you to enter marks (level 1->4+) for each stat entered in the AddHarkness component
should allow teacher to add comments for each student

This has been finished (finally!)


Fix horizontal scroll in the Colors tab

There's some strange horizontal overflow in the Colors tab that's causing some weird UI jumps. Let's try to avoid just tossing in an overflow-x: hidden to figure out the root cause of this.

Hey @Teddarific
There seems to be multiple elements causing the overflow. I've recorded videos to show where the problems occur.
Desktop to small tablet: https://www.loom.com/share/67fd4e4bc33e4934a576590518000849
Mobile: https://www.loom.com/share/53a7c5063be24f989dbf1bfadc457a21
Don't know how responsive we want mirrorful to be but the component that seems to cause the most trouble at the moment is the AddColorSkeleton.tsx. I'd be happy to look into it further if needed.

Ah appreciate the looms, Kenny! In terms of responsiveness, responsiveness would be ideal, but I think we can assume that users will not be on mobile for now so not super concerned for smaller screen sizes, but I think we definitely want to work towards responsiveness.
I might play around later, but feel free to take a stab at it if you're interested — I've mainly been trying to figure out what exactly is causing horizontal overflow on a desktop screen!


Add support for Unreal Engine 5.4

The plugin needs to build, but we also need it building on CI as well.
(UE 5.4 Preview 1 is currently available for download)

I have been attempting to compile a 5.4 version of the plugin and ran into issues with the UE 5.4 Preview 1 release.   Other developers have also run into the same issues as reported below.   The release is missing some of the UE5Rules and UE5ProgrammingRules libraries.
https://forums.unrealengine.com/t/ue-5-4-compile-error-catch2/1770453
My workaround it to download the latest code release for 5.4 from EpicGames/UnrealEngine github repository and building against it.

I was able to get cesium-unreal-samples up and running with UE 5.4 Preview 1 on Windows.
You can build from this branch and follow the typical developer workflow to build cesium-native and the cesium-unreal plugin. In addition, I had to update my samples project build settings to at least V4, DefaultBuildSettings = BuildSettingsVersion.V4
Not ready for a pull request quite yet, but should get some users by until full support comes along.

Also tested dropping the plugin directly into a fresh project (blueprints or C++). Seems to work just fine.
You can grab some of the built artifacts from here

Also tested dropping the plugin directly into a fresh project (blueprints or C++). Seems to work just fine.
You can grab some of the built artifacts from here

Hi csciguy8,
I download artifact of CesiumForUnreal-53-ue_5.4_support, and put it into [my UE5.4]/Engine/Plugins/Marketplace, and then i got an error, and UE5.4 exits.

Also tested dropping the plugin directly into a fresh project (blueprints or C++). Seems to work just fine.
You can grab some of the built artifacts from here

Hi csciguy8,
I download artifact of CesiumForUnreal-53-ue_5.4_support, and put it into [my UE5.4 directory]/Engine/Plugins/Marketplace, and then i run UE5.4 and i got an error, and UE5.4 exits. Can you give some advices on how to run cesium for unreal in UE5.4?

Hey @wuwei416. Is your project a C++ project? If so, you have to build and run it from the .sln file. If not, you should convert it to C++ (you can do it with unreal 5.3 by just adding a C++ class).
Check here https://forums.unrealengine.com/t/how-can-i-convert-a-blueprint-project-to-c-project-in-ue5/526755
and here https://www.youtube.com/watch?v=8E0ZbBfNF2E

Hey @wuwei416. Is your project a C++ project? If so, you have to build and run it from the .sln file. If not, you should convert it to C++ (you can do it with unreal 5.3 by just adding a C++ class). Check here https://forums.unrealengine.com/t/how-can-i-convert-a-blueprint-project-to-c-project-in-ue5/526755 and here https://www.youtube.com/watch?v=8E0ZbBfNF2E

Hi vacuitydev,
Thank you for the reply.
Now,  I was able to get cesium-unreal-samples up and running with UE5.4 on Mac, but when i try to run the game in iOS or MacOS, i get crash, Can you give some advices on that?  Thanks!

Hey @wuwei416. Is your project a C++ project? If so, you have to build and run it from the .sln file. If not, you should convert it to C++ (you can do it with unreal 5.3 by just adding a C++ class). Check here https://forums.unrealengine.com/t/how-can-i-convert-a-blueprint-project-to-c-project-in-ue5/526755 and here https://www.youtube.com/watch?v=8E0ZbBfNF2E

Hi vacuitydev,
Thank you for the reply.
Now, I was able to get cesium-unreal-samples up and running with UE5.4 on Mac, but when i try to run the game in iOS or MacOS, i get crash, Can you give some advices on this error? Thanks!

Hey @wuwei416. Is your project a C++ project? If so, you have to build and run it from the .sln file. If not, you should convert it to C++ (you can do it with unreal 5.3 by just adding a C++ class). Check here https://forums.unrealengine.com/t/how-can-i-convert-a-blueprint-project-to-c-project-in-ue5/526755 and here https://www.youtube.com/watch?v=8E0ZbBfNF2E

Hi vacuitydev,
the steps are:
1.I put built artifact into UE5.4/Engine/Plugins/Marketplace
2. create a blank UE5.4 project
3. enable cesium for unreal plugin in UE5.4
4. restart UE5.4, then I get this error

Besides, i am working on MacOS

@wuwei416 you need to put the plugin in your project's Plugins directory in this case, not in the Engine plugins directory. This is required because the plugin must be built for UE 5.4 (since it doesn't already include 5.4 binaries), and UE will not build a plugin in the Engine/Plugins directory.

@wuwei416 you need to put the plugin in your project's Plugins directory in this case, not in the Engine plugins directory. This is required because the plugin must be built for UE 5.4 (since it doesn't already include 5.4 binaries), and UE will not build a plugin in the Engine/Plugins directory.

Hi Kring,
Thanks for your information.

@wuwei416 you need to put the plugin in your project's Plugins directory in this case, not in the Engine plugins directory. This is required because the plugin must be built for UE 5.4 (since it doesn't already include 5.4 binaries), and UE will not build a plugin in the Engine/Plugins directory.

Hi Kring,
Thanks for your information.
I am a beginner in UE/cesium development, and I will tell you my operating steps. Can you help me check if they are correct？
1.download https://github.com/CesiumGS/cesium-unreal-samples from https://github.com/CesiumGS/cesium-unreal-samples, create dir Plugins in sample project root dir.
2.download cesium for unreal plugin package:CesiumForUnreal-53-ue_5.4_support

@wuwei416 you need to put the plugin in your project's Plugins directory in this case, not in the Engine plugins directory. This is required because the plugin must be built for UE 5.4 (since it doesn't already include 5.4 binaries), and UE will not build a plugin in the Engine/Plugins directory.

Hi Kring,
Thanks for your information.
I am a beginner in UE/cesium development, and I will tell you my operating steps. Can you help me check if they are correct？
1.download https://github.com/CesiumGS/cesium-unreal-samples from https://github.com/CesiumGS/cesium-unreal-samples, create dir Plugins in sample project root dir.
2.download cesium for unreal plugin package:CesiumForUnreal-53-ue_5.4_support
3.unzip CesiumForUnreal-53-ue_5.4_support and copy "CesiumForUnreal" to sample project Plugins directory
4.open CesiumForUnrealSamples.uproject by UnrealEditor5.4

Hi @wuwei416, can we continue this thread on the forum? Either a new post or this related one.
(Btw, your steps look good to me. Also, if you're able to wait a bit, we are planning to release official 5.4 support soon)

Hi @wuwei416, can we continue this thread on the forum? Either a new post or this related one.
(Btw, your steps look good to me. Also, if you're able to wait a bit, we are planning to release official 5.4 support soon)

Hi csciguy8,
This is good to me.
And can you please tell me the specific schedule， one month later，or two month later：）

And can you please tell me the specific schedule， one month later，or two month later：）

@wuwei416 , how about now? :)
Support for UE 5.4 is now official...
https://github.com/CesiumGS/cesium-unreal/releases/tag/v2.5.0

And can you please tell me the specific schedule， one month later，or two month later：）

@wuwei416 , how about now? :)
Support for UE 5.4 is now official... https://github.com/CesiumGS/cesium-unreal/releases/tag/v2.5.0

Hi csciguy8，
I am working on Unreal5.3.2 now, i am not sure when we will switch to Unreal5.4, anyway, thank you for the reply.


bug: minor log fix

Description

wrong command in the log: 'pip install crawlee[playwright]', it should be "pip install 'crawlee[playwright]'"
Issues

N/A

Testing

N/A

Checklist

[ ] Changes are described in the CHANGELOG.md
[ ] CI passed

I understand the reasoning behind using single quotes around the package name with the extra, as it helps with shell compatibility when dealing with brackets.
The backticks... Since this is just a log line without any formatting, I'm unsure whether using backticks (`) isn't just less readable.

What do you think @janbuchar?

hmm, we need the PR title check here. bug: prefix for any PR makes no sense unless you planned to introduce a new bug with the PR :D

hmm, we need the PR title check here. bug: prefix for any PR makes no sense unless you planned to introduce a new bug with the PR :D

I mean, we can update the log generator to put bug: in the same bucket as fix:

hmm, we need the PR title check here. bug: prefix for any PR makes no sense unless you planned to introduce a new bug with the PR :D

Hehehe, sorry! still used to the last company, there we were using "bug: for bug fixes", "feat: for new features" and similarly

I mean, we can update the log generator to put bug: in the same bucket as fix:

or we can actually follow the specs and not use random prefixes like bug: :D

here is the PR check we use in other repositories
https://github.com/apify/crawlee/blob/master/.github/workflows/check-pr-title.yml


how do you use this

hi @collatzcoder ! just found this port for 1.19.2 Trackwork and I don't know how to use this could you make instructions, or a youtube video for this? sorry I'm not good with this kind of stuff

Sorry for the misunderstanding, it doesnt technically exist right now. I
don't know java and am currently searching for a dev for a 1.19.2 trackwork
port, but nobody seems to be willing to help. If you know any java devs
feel free to put them in contact with me as I need one desperately.
On Sat, Aug 3, 2024 at 12:16 PM 4AuGlory @.***> wrote:

hi! just found this port for 1.19.2 Trackwork and I don't know how to use
this could you make instructions, or a youtube video for this? sorry I'm
not good with this kind of stuff
—
Reply to this email directly, view it on GitHub
https://github.com/collatzcoder/trackport/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7F7T4DZHI2HAFNKNZE66ODZPUF6XAVCNFSM6AAAAABL6CDYBKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DMNJRGAYDCMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Aryan Thapa-Chhetri
Walter Payton College Prep
10th


Missing Transit Gateway & Direct Connect Gateway State

Hello,
since the direct connect service had expanded, it would be nice if transit gateway & direct connect gateways could also be monitored.
BR

Hello @githubnoobieme - happy to look into it! Of course, pull requests are welcome.  Could you let me know the urgency of this request?  Are you looking to use the functionality ASAP?


[Doc] The installation doc is not identical and out of data

Describe the bug
The installation doc of TuGraph is not identical with the quick start doc.
And the installation doc is out of date and has some errors in it, like:

In the quick start doc, we can directly pull the image from docker hub, but in installation doc, we should download the image and load the image manually.
In the docker run script, we should not run the container in interactive mode if we want to use exec to login into the container.
There is no port setting in the script but there is a note about it. And I think we should always use 7070 as the default port, in the note message, it uses 7090 which is a little bit confusing.
And the installation doc has no content about how to start the service, so I need to look into the Service operation doc. But in that documentation, the commands are not suitable for container usage like I can't find a ./lgraph_server, I should use lgraph_server directly.

I think the Quick start and Installation should be identical and there should be no error in the steps to start a service. And maybe in all the docs like service operation, they should always contain all envs like locally start or in container.
PS. It is really great if we put a sample lgraph_config.json file in the /root folder of the image.

Got it, it will be fixed sooner or later in one month.
Pull request for doc fix is welcome.


Log format of full URL

Here is an example of my access log:
<IP_ADDRESS> - [06/Nov/2019:01:14:46 +0000] "GET https://lepture.com/feed.xml HTTP/1.1" 200 35538 "-" "Tiny Tiny RSS/19.8 (http://tt-rss.org/)" "0.003"

So I tried with %v
%h - [%d:%t %^] "%m %^://%v%U %H" %s %b "%R" "%u" "%T"

But goaccess told me that %v is NULL.

Closest you could get due to the parser needing a delimiter between specifiers would be
goaccess log --log-format='%h - [%d:%t %^] "%m %^://%v/%U %H" %s %b "%R" "%u" "%T"' --date-format='%d/%b/%Y' --time-format=%T

Thanks, that's what I'm doing now.

Glad that solved the issue. Closing this. feel free to reopen it if needed.

Thanks.


Switching from winston to winston-color throws fatal error

I have a logging library setup around using Winston, and I wanted to add some color to it, so I installed winston-color and switched it out with winston, and nothing else changed.

error: uncaughtException: Winston.transports.Console is not a function date=Thu Mar 17 2016 09:37:31 GMT-0700 (MST), pid=1038, uid=502, gid=20, cwd=/Users/jh..... this goes on for a while

It looks like this may be because the winston-color package doesn't have the transport Winston.transports.Console... How can I use the existing transports, but add color to the console output?
Heres the library which uses the winston package

I added as following and it worked.
logger.add(require('winston').transports.File,.............


Named Slot for message avatar

Is your feature request related to a problem? Please describe
At first, thanks for this great component :-)
It would be great if the message avatar could be also exchanged like for the room avatar.
We use a component for the user avatar, so we need to replace the image in the message by our component like for the room avatar.
Describe the solution you'd like
At a named slot for message avatar like room-list-avatar_{{ROOM_ID}} but for a message or per user.
So somethink like
message-avatar_{{MESSAGE_ID}} or message-avatar_{{USER_ID}}

Indeed that makes sense to add this slot. Will do that shortly

message-avatar_{{MESSAGE_ID}} slot added in https://github.com/antoine92190/vue-advanced-chat/commit/48092be45e47c8b14da48e5d78f3227c5a1bffc8


Fix cljs compilation for apps depending on Clerk render stack

So far sci.nrepl is only mentioned in the :dev but it's used in clerk frontend.

@zampino right, been meaning to make this change as well, thank you! I undid the config change which doesn't change behavior as I understand it (we can't merge false) so I don't think it adds clarity.


LED clones on redo

Steps to recreate:

Place LED
Undo
Resize Window
Redo

Unwanted behavior: more than one led in the LED information bar, actual LED in top left corner instead of supposed to be position

I use issue-4 branch as origin.

/cib

I can not reproduce this behaviour in the current refactored version in https://github.com/morgenmuesli/LED-Detection/commit/a0067257192dcde2f5ff73166e582011c65b19bc. Maybe due to the changes in how LEDs are being placed the bug solved.


How is RoBerta base trained?

How's roberta base pre-trained? It seems that you did not mention it in your paper. Specifically, I would like to know what data it used for pre-training?

Details are provided in Table 9 in the Appendix: https://arxiv.org/pdf/1907.11692.pdf. roberta.base follows the architecture of BERT-base and is trained on the same data as roberta.large.


(v3) more package updates

Please review the PR by going through each commit.

@kirrg001

I think the commit message style you have used for v3 might become a bit of an issue with respect to changelog generation? Or at least, it is different than what we used for v2.
This was a commit message with a breaking change for v2:

And this is how that looked in the changelog:

Differences:

For v2 we used the format "BREAKING CHANGE: ..." with a colon and then the description of the change in the same line, for v3 it looks like we mostly use BREAKING CHANGE without colon, and then a newline. Not entirely sure if that is relevant, but https://www.conventionalcommits.org/en/v1.0.0/ reads as if the colon needs to be there?
It looks like some (most? all?) commit messages only list a some reasoning why we dropped support for something in the BREAKING CHANGE footer. If I am not mistaken, the content of the BREAKING CHANGE footer will be put in a separate section in the changelog, without any reference to the full commit message.

So the last part would mean we generate this list of breaking changes for the 3.0.0 changelog:

...
v1 is from 2019
...

But the "v1 is from 2019" would not have any indication that it relates to fastify I think?

TL;DR: I think this particular commit message should have been

Good catch 👍 I remember that we also did the mistake in the beginning of v2. I will rewrite the breaking change messages before merging v3 👍

Added a task to #884

Rewrite breaking changes messages


[Autocomplete] Suggestions cannot be found using iOS VoiceOver swipe gesture

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Equipment

Iphone 8
Safari
iOS 12.1.4

Suggestions in the listbox are very difficult to find when using iOS VoiceOver + Safari.
When swiping forward from the text field or the combobox, VoiceOver skips over the listbox altogether and moves past it to the next content on the page.
Focus on textfield...

... then focus on background elements after swiping forward:

To find the suggestions, the user must explore-by-touch and search the screen – which they might not know they should try.
The issue appears to be aria-owns not working properly in iOS VoiceOver+Safari, in combination with the listbox portal being placed at the end of the DOM. As a result the listbox is separated from the input field for the user.
The problem does not exist with Talkback on Android, where aria-owns has better support.

Expected Behavior 🤔

VoiceOver focus is placed on the first suggestion in the listbox when swiping from the input field.
The user can easily find the suggestions without having to explore-by-touch

Refer to the Authoring Practices example (https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html), where the listbox is placed as a sibling to the Combobox.  In this configuration, I can find the suggestions as expected by swiping forward from the input field, even without aria-owns.

Steps to Reproduce 🕹

Steps:

Start VoiceOver on an iPhone
Open Autocomplete demo page (https://material-ui.com/components/autocomplete/)
Navigate to "Combobox" example
Start writing 'T'
Place focus back on the input field
Swipe right to go to the next element.

Context 🔦
This same problem exists in many popular implementations of the WAI-ARIA 1.1 pattern. This includes Downshift (see issue 779), ReachUI (see issue #284) and React Autosuggest.
One implementation that does not have the problem is Vue Autosuggest. There are probably others as well.
I have tried to find out if Apple has plans to improve aria-owns support in the future, but haven't been able to find any info.
In the mean time, perhaps it is possible to modify the source order of the component to mimic the WAI-ARIA example?

Your Environment 🌎

Tech
Version

Material-UI Core
v4.5.2

Material-UI Labs
v4.0.0-alpha.30

React
16.11.0

iPhone
8

iOS
12.1.4

We have made a few changes since the first release of the component. Could you try https://master--material-ui.netlify.com/components/autocomplete/?
We have one demo that doesn't portal, the GitHub one. Does the problem reproduce on this one?
Thanks.

We have made a few changes since the first release of the component. Could you try https://master--material-ui.netlify.com/components/autocomplete/?
We have one demo that doesn't portal, the GitHub one. Does the problem reproduce on this one? Or even the useAutocomplete demo?
Thanks.

@oliviertassinari It has the same behavior unfortunately, but for a different reason. VO doesn't seem to find the listbox when it is contained inside the role=combobox:

   ...

The only configuration I've found that works on iOS is if you place the listbox as a sibling to the combobox instead of a descendant. This is what the Authoring Practices example does:

@fymmot Awesome, let's fix it.


[Feature Request]: Add Write Support for Azure CosmosDB with Core(SQL) API

What would you like to happen?
CosmosDB: Add Write support for Azure database CosmosDB with Core (SQL) Api.
Currently the API only supports CosmosDB reads.
https://github.com/apache/beam/issues/23604
Issue Priority
Priority: 2 (default / most feature requests should be filed as P2)
Issue Components

[ ] Component: Python SDK
[X] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

.add-labes azure,cosmosdb,database

@Miuler I see you added code to Support Read from Azure Cosmos DB. Is there a plan to support write to cosmos with core api


Use target pointer width rather than x86

The code https://github.com/stencillogic/astro-float/blob/891843d8341d032f889f1b77077dd7ceb05b7a01/astro-float-num/src/defs.rs#L11-L33 has a lot of code that is configured based on x86 or not(x86). Is there a reason that x86 is special, or could this instead use #[cfg(target_pointer_width = 64)]/#[cfg(target_pointer_width = 32)]?

Basically, the library only supports x64 and x86. Hence it uses just x86 and not(x86) here and there. It was tested for ARM once, but in general ARM is not supported at the moment.


Remove version from dev-dependencies to make it easier to publish.

Since #7333, released in 1.40, Cargo will strip dev-dependencies that don't have a version.  These two crates aren't published to crates.io, and thus they have to be commented out each time a release is made. This change avoids that step.

r? @Eh2406
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+

:pushpin: Commit 0b5c065f8d1b0f9e78cdf4f9da9bb25e04624552 has been approved by Eh2406

:hourglass: Testing commit 0b5c065f8d1b0f9e78cdf4f9da9bb25e04624552 with merge d4817887ec6afaa126aad6d27757e64561e33062...

:sunny: Test successful - checks-actions
Approved by: Eh2406
Pushing d4817887ec6afaa126aad6d27757e64561e33062 to master...


Allow configuration of Assets package name

Q
A

Branch?
1.x

Bug fix?
no

New feature?
yes

Related tickets
fnone

License
MIT

When you have an application with multiple webpack encore configuration, you are required to specify the 3rd argument of encore_entry_link_tags and encore_entry_link_tags Twig methods
https://symfony.com/doc/current/frontend/encore/advanced-config.html#defining-multiple-webpack-configurations
This PR introduces 2 configuration vars : css_package_name & js_package_name that are covering that need.

Thanks 👍


Caching when CacheDir is defined

I added some basic caching support. Changes should be backward compatible and enable cache only when CacheDir is defined. I needed to make ContextMap public to make request object serializable with gob.

So I added a docstring, we agreed about sha1 and last thing is this ContextMap. I know that it's not necessary to make it public, but I don't know how to convince encoding/gob to work without having it public.

I know that it's not necessary to make it public

The problem here is that it breaks the thread safety of the Context object.
Another option is to use https://golang.org/pkg/sync/#Map instead of the default golang map which is thread safe by default. It would break the current API, but that's a smaller problem than the thread unsafety IMO.

Good point. I will try to solve it.

So I solved it by Marshaling and Unmarshaling Context to nil.

Perfect && great job, thank you =)


Fails to compile

The culprit is here:
https://github.com/ShinobuAmasaki/libpq-fortran/blob/edc0fc25c06b3b41615282d5d5d21e396a1f491e/src/wraps/PQconninfoParsePrepare.c#L25
Not sure how errlen is used in this function as it doesn't point to length or vice versa.

Submitted a PR for this in #3.


Add note about valid Java package name for groupID

CQDOC-18946
Added note to README.md about valid Java package name for groupID
Description
See above
Related Issue
https://jira.corp.adobe.com/browse/CQDOC-18946
Motivation and Context
It was a good suggestion from a reader. https://github.com/AdobeDocs/experience-manager-core-components.en/issues/31
How Has This Been Tested?
Same change passed MD validation in our public docs. https://git.corp.adobe.com/AdobeDocs/experience-manager-core-components.en/pull/214
Screenshots (if appropriate):
None
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation change
[ ]

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

You should adjust the regex in https://github.com/adobe/aem-project-archetype/blob/a64611987fe69c4a344682f67a552c5414960e56/src/main/resources/META-INF/maven/archetype-metadata.xml#L35 accordingly to enforce this constraint


Use ? for Mapping Result Errors

To promote Roc developers providing context for Results when propagating errors with try, we want to add a new operator ? that acts as a Result.mapErr equivalent. Some example usages:
fileContents =
    try File.read! "file.txt" ? FailedToReadFile

fileContents =
    try File.read! "file.txt"
        ? FailedToReadFile

{} = File.save! "file.txt" contents ? \err =>
    Logging.error! "Failed to save file.txt: $(Inspect.toStr err)"

    FailedToSaveFile err

It should be higher precedence than try such that try will propagate errors after ? is applied, but it does not need to be used with try.
We should always attempt to format onto the same line as the fallible code, but can optionally wrap to a newline with an indentation to imply continuation; this prevents code from reading like we apply ? after try.
The new ? operator should be able to handle mapping over errors using pure or effectful mappers, meaning it should be its own AST node. We can start with a pure-only implementation, since we are waiting on purity inference still.
If a pure handler is used with the new ?? "Result.withDefault" operator, we should raise a warning that the error mapping is unnecessary, since it will always be discarded by ??.

Does this bind tighter than try? and how does this feel when we move to static dispatch with ? postfix operator?
fileContents =
    File.read!("file.txt")? ? FailedToReadFile

And Richard in a Zulip thread suggested that this should always be early return on error like try.  Basically, append a mapErr with the provided Err tag and then desugar the try.

Maybe a keyword is more appropriate?  The same could be said for ?? I think.
Maybe orelse for ?? and errwith(or orthrow) for ?
I think
fileContents =
    try File.read!("file.txt") errwith FailedToWrite

or
fileContents =
    File.read!("file.txt")? errwith FailedToWrite

Read better than the above. But then with Static Dispatch do we gain anything when it would just be
fileContents =
  File.read!("file.txt").map_err(FailedToWrite)?

If we want to discuss this kind of thing, a topic in the #ideas channel of the Zulip chat would be the right place to do it!


Fix for #11

Still needs to be compiled. Aside from fixing #11, this also lays out a framework for non-utility/graphic pack additions.

Things left:

[ ] Squash https://github.com/ev1l0rd/yalnpv/commit/8f3ffe702f5eb551d32a3a653fdd4fecd6e53ca2 and https://github.com/ev1l0rd/yalnpv/commit/ff7367404c239a996b692673ccd2dc8bb0fb96c7
[ ] Compile code

Then I will merge this and make a release.


[Preemptive] migrate to flutter_map 3

IMPORTANT: This depends on ibrierley/flutter_map_dragmarker#17
final version is not in place!!
fleaflet/flutter_map#1333

All done, thanks for this.


Help wanted, adding defaults to vcfanno config

Hi Brad,
I'm trying to add another built in vcfanno config (cfr. `vcfanno: [gemini,otherdefault,custom.conf]).
Could you give me some pointers where and how I should add this? I'd like to do some tests and see if it's something that worthy for production.
Thanks
M
PS, congrats on the new release, I've been looking forward to it.

Matthias;
Thanks for offering to contribute additional configurations to bcbio. There are three things you need:

A vcfanno configuration file that defines the annotation approaches for each genome you support. Examples are here: https://github.com/chapmanb/bcbio-nextgen/tree/master/config/vcfanno
Add the vcfanno configuration file to the ggd-recipe used to install these for bcbio: https://github.com/chapmanb/cloudbiolinux/blob/master/ggd-recipes/hg38/vcfanno.yaml
ggd-recipes (https://github.com/chapmanb/cloudbiolinux/tree/master/ggd-recipes) for all data files used in the annotation.

The last is the one that takes the most work since we'd need to have bcbio installing these to make them available to your configuration script. We'd like these to be general purpose and configurable if large. Do you have an example of what you'd like to contribute? That would help with discussing specifics. Thanks again.

Hi Brad,
Thanks for the info. I'm looking into making dbNSFP and dbscSNV available for both vep and snpEff users.
Ideally, I'd remove dbNSFP/dbscSNV from the VEP plugins and add a config for vcfanno.
That way, users can annotate with everything from jpopgen using vcfanno: [gemini,jpopgen].
We're using both resources quite intensively and already worked around some caveats etc, which VEP doesn't seem to handle. If you approve, I can submit a PR at cloudbiolinux with the config we're using.
A ggd recipe for the data itself is already available.
Cheers
M


Packit cannot checkout release tag locally with pkgs.fedoraproject.org remote

What happened? What is the problem?
Packit cannot checkout release tag locally with pkgs.fedoraproject.org remote. It only works for anonymous clone, but doesn't work for authorized fedora user.
What did you expect to happen?
packit pull-from-upstream should works locally if Fedora package cloned via authorized ssh git clone from src.fedoraproject.org dist git.
Example URL(s)
https://src.fedoraproject.org/rpms/speedtest
Steps to reproduce
1. fedpkg clone speedtest
2. cd speedtest
3. packit pull-from-upstream

Resulting error:
Proposing update of the following branches: rawhide
2023-10-08 12:28:23.774 upstream.py       INFO   Version in upstream registries is '1.1.2'.
2023-10-08 12:28:23.846 local_project.py  INFO   Checking out upstream version v1.1.2.
2023-10-08 12:28:23.860 api.py            INFO   Checking out the original branch rawhide.
2023-10-08 12:28:23.888 utils.py          ERROR  Cannot checkout release tag.

Full output with debug:
packit --debug pull-from-upstream

packit --debug pull-from-upstream.log
Authorized git clone:
git remote -v
origin<EMAIL_ADDRESS>(fetch)
origin<EMAIL_ADDRESS>(push)

Anonymous git clone:
git remote -v
origin	https://src.fedoraproject.org/rpms/speedtest.git (fetch)
origin	https://src.fedoraproject.org/rpms/speedtest.git (push)

Workaround

[ ] There is an existing workaround that can be used until this issue is fixed.

Participation

[ ] I am willing to submit a pull request for this issue. (Packit team is happy to help!)

Relevant part from the logs:
2023-10-08 13:06:25.474 utils.py          DEBUG  Input directory is an upstream repository.

Apparently it is deduced as the upstream instead of the dist-git.

It looks like this is the issue:
https://github.com/packit/packit/blob/7581995d78074a7a5bbd87b1fab410a40d18f8ed/packit/constants.py#L66-L71
Candidates are a set of pairs/tuples and this check can never succeed:
https://github.com/packit/packit/blob/7581995d78074a7a5bbd87b1fab410a40d18f8ed/packit/cli/utils.py#L326
It used to be a simple set of URLs before https://github.com/packit/packit/commit/b09b64e53ab3525bb0bd2726323a08f089073f50.

ugh, that's on me…


New Installation: Missing Database Table

Missing Database Table
Error: Table settings for model Setting was not found in datasource database.
Notice: If you want to customize this error message, create app/View/Errors/missing_table.ctp
STACK TRACE
CORE/Cake/Model/Model.php line 3243 → Model->setSource(string)
CORE/Cake/Model/Model.php line 2696 → Model->getDataSource()
APP/Model/Setting.php line 70 → Model->find(string, array)
APP/Controller/AppController.php line 68 → Setting->load()
[internal function] → AppController->beforeFilter(CakeEvent)
CORE/Cake/Event/CakeEventManager.php line 248 → call_user_func(array, CakeEvent)
CORE/Cake/Controller/Controller.php line 670 → CakeEventManager->dispatch(CakeEvent)
CORE/Cake/Routing/Dispatcher.php line 184 → Controller->startupProcess()
CORE/Cake/Routing/Dispatcher.php line 162 → Dispatcher->_invoke(BooksController, CakeRequest, CakeResponse)
APP/webroot/index.php line 109 → Dispatcher->dispatch(CakeRequest, CakeResponse)
ROOT/index.php line 43 → require(string)

@kinshuksunil how are you trying to start the app? Are you using docker, or just running on a php installation? Did you go through the installation steps, http://openam.github.io/calibrephp/#installation?

I copied the files to the directory. Did not use the Docker approach.
Edited the database.php, core.php and settings.php
Now when I launch the app by visiting the URL, I face this error.

@kinshuksunil Did you manage to fix it?

@kinshuksunil can change the database.php back to what it originally was, and then just go to the settings (user dropdown) and set the path for where your metadata.db file is, e.g. /Users/michael/Documents/Calibre Library/metadata.db

@kinshuksunil @hjbarraza I've made a couple small updates, and updated the documentation site.

I will try these out and update. I had stopped using the tool.

Fixed. Sorry for the late reply.

Thanks will try again this weeekend.


Developed test cases

Codecov Report

Merging #7 into master will increase coverage by 90.90%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           master        #7       +/-   ##
============================================
+ Coverage    9.09%   100.00%   +90.90%
============================================
  Files           1         1
  Lines          33        33
  Branches        6         6
============================================
+ Hits            3        33       +30
+ Misses         24         0       -24
+ Partials        6         0        -6

Impacted Files
Coverage Δ

index.js
100.00% <100.00%> (+90.90%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead4a1a...87466ba. Read the comment docs.


Update transport version to 6.3.15

Purpose

$subject.
Update orbit/snakeyaml version 1.26.0.wso2v1

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #26486 into ballerina-1.2.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.2.x   #26486   +/-   ##
================================================
  Coverage            14.59%   14.59%
================================================
  Files                   51       51
  Lines                 1411     1411
  Branches               219      219
================================================
  Hits                   206      206
  Misses                1189     1189
  Partials                16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fcbca...0feccaa. Read the comment docs.


:wFix callback ID management

I like the PR title fellow Vim user :)

This shouldn't have been opened!


HELP: Uploaded content is not recognized by PHP

I am trying to catch the uploaded file using $_FILES global array. While the content of file is sent to server, it seems PHP could not catch uploaded file meta-data (file name etc). So the $_FILES is empty. By the way, it's strange that I should set both file and data properties to file
    $scope.upload = function (files) {
        if (files != null && files[0]) {
            var file = files[0];
            console.log(file);

            file.upload = Upload.http({
                url: 'rest/file/',
                data:file,
                fileName:'test',
                file: file
            });

            file.upload.then(function (response) {
                file.result = response.data;
            }, function (response) {
                if (response.status > 0)
                    $scope.errorMsg = response.status + ': ' + response.data;
            });

            file.upload.progress(function (evt) {
                file.progress = Math.min(100, parseInt(100.0 * evt.loaded / evt.total));
            });
        }
    }

HTML markup:

                Background
                <input ngf-select ngf-change="upload($files)" accept="image/*"
                       ng-model="form.background"
                       name="background" type="file"/>

                		= 0">

There is a wiki page for PHP, have you look at it?

Yes, I have read it and tried it. It seems the issue is about the file name. It is not sent to server. It file contents is available using 'php://input however the $_FILE array is empty.
BTW: why both file and data are set to file in the PHP example.
Thanks.

I have updated the wiki, you don't need to set both or set the content-type.

Closing this, if you are still having issues please create a new one or reopen this.

https://github.com/danialfarid/ng-file-upload/issues/763
From version 5.0.0 instead of setting fileFormDataName you can set sendFieldsAs: "form"


[allocbox-to-stack] Add a new semantics attribute that says vars of a nominal type marked with _semantics("boxtostack.mustbeonstack") must be on the stack.

This is just an experimental option I added for the swift-nio people to play with.

@swift-ci smoke test and merge


Add autocomplete to goose terminal

Don't know if its possible but giving goose precise content is key to having it work well. So I'm constantly copy pasting class names etc. into the terminal from the main window. So getting an editing experience like typing in intellij where you can quickly choose class names, functions etc. would be great. Bonus points to enable autocomplete things copilot.
I usually type in an editor and paste into goose currently.

I will attempt to build one, but it might take a while


Allow control to be chosen by shapes

So if we forget the advanced controls, there is just one simple rule:
* **All nodes with a box shape will be added to the Controller**
  This will match the box shapes in the controller.
  It would be easy for the users to understand and remember this setting.

No thanks. My default is Box shapes for ALL nodes. I dont want all of the controls added just because of my workflow.
Same for "colors" really. This should be a key combo that triggers a menu item (add to controller).
It would be much better to NOT hijack UI to use for populating other things, unless the node is marked to do so.
Why? Lots of reasons, like I said with the shapes, some people have color-blindness problems.

It would be much better to NOT hijack UI to use for populating other things, unless the node is marked to do so.

Yeah, maybe that would be the best solution.
@chrisgoringe, Could you reconsider this ?
We could have an option to add to controller in the node's right click menu.
And the nodes could have an icon, in the top right corner, or something, to visually indicate they were added to the Controller.

Yeah, I think you've convinced me.
The idea behind (re)using colors was that we could have more than one panel. But that functionality is now down (much better) with the groups.
I'll do a right-click menu.


cargo:rustc-link-arg-tests not available to unit/module tests

Problem
According to The Cargo Book, the build.rs file can emit the cargo:rustc-link-arg-tests=FLAG setting to have it applied passed to rustc as a -C link-arg=FLAG but only when building a "tests target". From the documentation it's not immediately clear that this only works with integration-style tests in tests/. Furthermore, there's no indication of  how special link args might be specified for unit tests (this is particularly relevant for running tests for PyO3 extension modules on MacOS).
Also, if there are no tests tests/, the cargo test comands fails with the message:
error: invalid instruction `cargo:rustc-link-arg-tests` from build script of ...
The package xyz ... does not have a test target

Steps
1. Create a project with the following files:
Cargo.toml:
[package]
name = "build-script-link-args-for-tests"
version = "0.1.0"
edition = "2021"
[dependencies]

build.rs:
fn main() {
    println!("cargo:rustc-link-arg-tests=-Wl,-rpath,/usr/local/lib") // Arbitrary flag.
}

src/lib.rs:
pub struct Foo;

#[cfg(test)]
mod tests {
    #[test]
    fn can_haz_foo() {
        let _ = crate::Foo;
    }
}

2. Run tests
cargo test

(observe cargo "invalid instruction" error)
3. Add an integration test
tests/test_foo.rs:
use build_script_link_args_for_tests::Foo;

#[test]
fn i_haz_foo() {
    let _ = Foo;
}

4. Run tests
cargo test

(observe no cargo error)
5. Observe application of linker arguments
RUSTFLAGS='--print link-args' cargo test | grep '\-Wl,\-rpath,/usr/local/lib'

(observe linker arg only applied to .../build-script-link-args-for-tests/target/debug/deps/test_foo-...)
Possible Solution(s)
a. Allow cargo:rustc-link-arg-tests to apply to unit (in-module) tests, or create a new flag specific to unit tests. 😄
b. Update documentation to indicate unit tests aren't supported by this feature. 😞
Notes
May also apply to #[bench] functions.
Version
cargo 1.62.1 (a748cf5a3 2022-06-08)
release: 1.62.1
commit-hash: a748cf5a3e666bc2dcdf54f37adef8ef22196452
commit-date: 2022-06-08
host: aarch64-apple-darwin
libgit2: 1.4.2 (sys:0.14.2 vendored)
libcurl: 7.79.1 (sys:0.4.51+curl-7.80.0 system ssl:(SecureTransport) LibreSSL/3.3.6)
os: Mac OS 12.4.0 [64-bit]

I'm not sure, but I think this was just an oversight.  My original intent mentioned in https://github.com/rust-lang/cargo/pull/8441#issuecomment-659013313 was that it applied to unittests as well:
cargo:rustc-link-arg-tests=…         # equivalent to --tests (including unittests)

However, I think in #10274 that was an oversight.
Implementation-wise, I think the check applies_to needs to also consider the CompileMode.  I'm not sure if it should check is_rustc_test or is_any_test; one would need to determine if it makes sense to also pass flags to rustdoc for doctests (I think maybe "yes"?).

equivalent to --tests (including unittests)

If the "equivalent to --tests" means the equivalence of target selection, it implies

lib and bins as unit tests
no doctests

I am not sure if that's really what we want.
Also, what should cargo do when both cargo:rustc-link-arg-bins and cargo:rustc-link-arg-tests are specified?

Compile mode build

Only apply rustc-link-arg-bins. No problem in this case.

Compile mode test

Should we only apply rustc-link-arg-tests, or apply both tests and bins linker args?

Another thing I am uncertain is if a user invoke cargo t --example exp, do we want add link arg from cargo:rustc-link-arg-tests for that example's unit tests?
We've got some small details to determine. I feel like the most important question is "what is counted as a unit test?" in this feature. A simple solution could be adding link arg from cargo:rustc-link-arg-tests for every rustc invocation with --test flag. Though it feels inconsistent from others extra link arg.

Here are my thoughts on the points you brought up, but I must admit to knowing very little of the cargo internals and the various link stages it works with, so what I have to say may be of limited value.

If the "equivalent to --tests" means the equivalence of target selection, it implies

lib and bins as unit tests
no doctests

I am not sure if that's really what we want.

My wording there wasn't very precise, but I'm not sure what it should be. What it probably comes down to is how many linker invocations are there per target "kind", and does cargo expose those different cases outside of its internals?
To illustrate, say we have a project with the files tests/test_foo.rs, src/bin/foo.rs, and src/lib.rs, each with one or more #[test] function in them. If we run cargo test, does that result in 3 different linker invocations? If the answer is "yes", and cargo:rustc-link-arg-tests is all we have to work with, then either it should apply to all three linker invocations, or we need a new feature to specify one or more of the others separately. After reading your points, I think the latter may be needed.
The problem is we have two dimensions we're trying to treat as one. We have (what I'm calling) the "target kind" (bins, lib, examples, benches, tests), and then two modes: build and test. build mode is understood and clear: create the artifacts for when #[cfg(not(test))] (except for tests, which is just skipped in build mode?). Each of the target kinds in this mode already have their own cargo:rustc-link-arg-XXX flag and is covered.
However, in test mode, when #[cfg(test)], we may need different linker flags depending on the target kind; that is, the location of where the #[test] annotation appears (a bin file, a lib file, a tests file, an example file, etc.). Right now cargo:rustc-link-arg-tests only applies to the tests kind, but we see that's not enough. But applying it to all the target kinds seems wrong too. So I'm not seeing anyway around having separate test mode flags for the different kinds. Something like this:

Target Kind
Flag
Note

tests
cargo:rustc-link-arg-tests
As it is now

bins
cargo:rustc-link-arg-test-bins

lib
cargo:rustc-link-arg-test-lib

examples
cargo:rustc-link-arg-test-examples

examples
cargo:rustc-link-arg-test-benches
Is this needed?

I'm not sure where doctests fit in here. In this context, is it a "kind" that's only relevant in the test mode (like tests)?
Does this feel directionally correct?

Thank your for providing a solution on this topic! Most of your understanding is correct. Each test target, either unit test or integration test results in a linker invocation. You proposal is also straightforward IMO, though just feels like a bit like feature bloat (not your fault, just cargo provides so many options).
This https://github.com/rust-lang/cargo/pull/8441#issuecomment-659013313 proposes
cargo:rustc-link-arg-test-LIBNAME=…  # for unittest of lib only?

which is similar to your solution, and somehow may resolve your original use case. There are also syntaxes to specify the name of a target, although they have yet been implemented so far. I couldn't think a way to avoid adding such an amount of new instructions 😞.

Another option to keep it simple (until proven to be insufficient in the wild):

Target Kind
Flag
Note

tests
cargo:rustc-link-arg-tests
As it is now

not tests
cargo:rustc-link-arg-tests-unit
#[cfg(test)] anywhere but ./tests

If down the road we need to differentiate between bins and lib, etc. , then we could add an optional [KIND={bins|lib|doctest}] specifier, but hold off until that day arrives.

I bumped into this today. I have some embedded 'bin' code which uses a custom linker script to collect some static items tagged with a linker section so they appear next to each other in the resulting binary, the linker script also exposes start/end addresses so that the entire set can be accessed from rust code.  It all works fine, but then I went to write so unit tests and ran into the error below.
error: invalid instruction `cargo:rustc-link-arg-tests` from build script of `my-crate v0.1.0 (...)`

build.rs snippet:
    println!("cargo:rustc-link-arg-tests=-Tlink/registry.ld");

Here's my use-case so you can see why I need this:
linker script snippet:
.registry_items :
{
    . = ALIGN(4);
    KEEP(*(.registry.items))
    KEEP(*(.registry.items.*))
} > CODE

_registry_items_section_vma_start = ADDR(.registry_items);
_registry_items_section_vma_end   = ADDR(.registry_items) + SIZEOF(.registry_items);

extern "C" {
    pub static mut _registry_items_section_vma_start: u32;
    pub static mut _registry_items_section_vma_end: u32;
}

...

let first: *const RegistryItem = &_registry_items_section_vma_start as *const u32 as _;
let last: *const RegistryItem = &_registry_items_section_vma_end as *const u32 as _;

let item_count: usize = last.offset_from(first) as _;

Registry {
    items: slice::from_raw_parts(first, item_count),
    ...
}

and the codebase has many RegistryItems like this, scattered over many source files.
#[link_section = ".registry.items.THING1"]
pub static REGISTRY_ITEM: RegistryItem = RegistryItem {
    length: mem::size_of::<Thing1>() as u16,
    id: things::THING1,
};

The idea is that the list of things is built at link-time and there is no source dependency between the 'things', or the Registry implementation itself.
To recap - my goal is add to the linker script used by unit tests so that my '.registry.items.*' appear in a contiguous block of memory instead of where they would usually be placed.

I think we are also running into this issue, see https://github.com/nabijaczleweli/rust-embed-resource/issues/69.
The only way I've managed to get linker flags to get passed through to the unit test binaries that cargo test generates is to pass them through the catch all of cargo:rustc-link-arg. That does seem to work.

I'd also like to request a small doc update to cargo:rustc-link-arg-bins if possible. In the cargo book that says "Passes custom flags to a linker for binaries", but I feel like it might be worth calling out that they don't apply to the test binaries that cargo test creates.
Thanks!


latest Qt.py breaks model tester

python 3.10. we used an older version (1.3.7) of qt.py. after updating to the latest (1.4.1) one we get tons of tests failing with this error:
self = <pytestqt.modeltest.ModelTester object at 0x000002202AE80D00>

    def _test_basic(self):
        """Try to call a number of the basic functions (not all).

        Make sure the model doesn't outright segfault, testing the functions
        which make sense.
        """
>       assert not self._model.buddy(qt_api.QtCore.QModelIndex()).isValid()
E       TypeError: 'PySide6.QtCore.QAbstractItemModel.buddy' called with wrong argument types:
E         PySide6.QtCore.QAbstractItemModel.buddy(QModelIndex)
E       Supported signatures:
E         PySide6.QtCore.QAbstractItemModel.buddy(typing.Union[PySide6.QtCore.QModelIndex, PySide6.QtCore.QPersistentModelIndex])

the only thing that changed is Qt.py. the attribute passed is correct and I do not understand why this is complaining.
posting here in case someone else had the same issue and have a solution.

If you used 1.3.7, then you must also have used PySide2/PyQt5, as Qt 6 support was added in 1.4.1. This looks to be a PySide6 error, or more specifically an issue with the "model tester".
What is this "model tester"? Best Qt.py could do is provide a wrapper, but it would require this tester to use it.

yes we are still using PySide2/PyQt5 and we are getting ready for the new ones. I assumed that updating Qt.py would have no effect on the existing pipeline. I'm looking at the diff between the two versions and I see nothing that would explain the problem.
model tester is some automated pytest thing that tests models:
https://pytest-qt.readthedocs.io/en/latest/modeltester.html

the environment didn't change. the python/pyside/pyqt version are the same etc etc. the only change was update to qt.py
I also have errors in qtbot:
E       pytestqt.exceptions.TimeoutError: Signal  not emitted after 9000 ms

this indicates that pytest fixtures we had been using are no longer compatible with the 1.4.1

But, this error is coming from PySide6?
E       TypeError: 'PySide6.QtCore.QAbstractItemModel.buddy' called with wrong argument types:
E         PySide6.QtCore.QAbstractItemModel.buddy(QModelIndex)
E       Supported signatures:
E         PySide6.QtCore.QAbstractItemModel.buddy(typing.Union[PySide6.QtCore.QModelIndex, PySide6.QtCore.QPersistentModelIndex])

Upgrading would have no effect on PySide2/PyQt5, can you confirm?

I think I see the issue. we have both pyside2 and pyside6 available and it seems that the updated Qt.py is picking up pyside6 while the older one was picking up pyside2 in the same environment. is there a way to specify priority if both are available?

See https://github.com/mottosso/Qt.py?tab=readme-ov-file#override-preferred-choice

of course. sorry, long day. Thank you for your assistance and sorry to bug you. works perfectly.


feat: update to black v24 and fix double curly braces (Updated PR #216)

Ok, I mistakenly closed #216, here's #216 + my two commits
@mbhall88 can you please respond to my comments on #216 and see if you're happy with my two added commits?
We can then keep updating this branch here.
Brice

All looks good to me. Good idea on refactoring the { addition.
As for merging from snakefmt branches, sure we can do that. I do prefer from my own fork though just in case I try and push to master, which wouldn't matter on my fork. There is an option to allow you to push to my PRs - it's a checkbox in the right panel of the PR below the "Lock conversation" section. If you select that it allows maintainers of snakefmt to push to the PR. Maybe we can just try and remember to check that. Anyway, I don't mind either way.

Oh, being able to push to our respective forks is much better, as you say it protects us from mistakenly pushing to master here. Will have a look for that checkbox next time round (can't see it on the PR right now, though)


Fix: Change wording on the window

For grammatical purposes, would this make sense to include wireguard in the window instead of [user] will hold your ovpn configurations. If not, feel free to close this PR as I always wondered why it wasn't added to the window to include wireguard. Thank you!

In that case I think would make more concise something like:
"Will hold your VPN client configuration files"

In that case I think would make more concise something like:
"Will hold your VPN client configuration files"

Fair, pushing a fix now! 👍🏻

Tis done.

and and merges to master


balanceData error

[ 'balanceData error', {} ]
{ Error: ESOCKETTIMEDOUT
at ClientRequest. (C:\Users\NOAH\node\binance-triangle\node_mod
es\request\request.js:816:19)
at Object.onceWrapper (events.js:313:30)
at emitNone (events.js:106:13)
at ClientRequest.emit (events.js:208:7)
at TLSSocket.emitTimeout (_http_client.js:706:34)
at Object.onceWrapper (events.js:313:30)
at emitNone (events.js:106:13)
at TLSSocket.emit (events.js:208:7)
at TLSSocket.Socket._onTimeout (net.js:410:8)
at ontimeout (timers.js:498:11) code: 'ESOCKETTIMEDOUT', connect: false }

I assume this is an error you are receiving? Please provide some context ie when does this error occur, provide the rest of the stack trace, what is your operating system, node version etc.

Thanks dear i thing it was my network problem
how can i deploy this project on a service like heroku  or  so that it can run on its own i have tried it out but it is not working.

I would recommend something like AWS

thanks @bmino  have you currently able deploying this project in any cloud linux /unix VM if yes that is the min um BNB balance needed to execute successful trades.
currently am able to spot to arbitrage opportunities but i cant execute any.
Iam also trying to understand the code base can you email  me an explanation on how function calculateArbitrage() works.

I use AWS regularly for the best performance and latency. Personally I run ubuntu/windows locally.
calculateArbitrage() does the following:

Clones a copy of the depth cache of all related symbols
Iteratively calculates if there is a triangle arbitrage opportunity for any pairing
Updates the HUD
Makes logging updates
Sets a timeout before repeating the process

Go ahead an open a new issue if you want some further discussion about this


mat-select options overlay shifted left when first child element is a mat-optgroup

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Options overlay renders at the same position regardless its first child element
What is the current behavior?
When a mat-select's first child element is a mat-optgroup (vs a mat-option), the options overlay is shifted to the left. This is more noticeable when combined with a mat-form-field's appearance="outline"
What are the steps to reproduce?
https://stackblitz.com/edit/angular-hskr5f?file=app%2Fselect-optgroup-example.html
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 7.2.7
Angular Material 7.3.1
macOS 10.14.3
Chrome 72.0.3626.119
Firefox 65.0.1
Safari 12.0.3

The select tries to position either the selected option or the first option on top of the trigger text. Options inside groups have some indentation which we have to compensate for, hence why the panel is moved more to the left. Closing because it works as expected.


The meanong

            gt = 2 * gt - 1

what's this operation in train.py line 920

Hi, it converts images in the [-1, 1] range


Move SanitizeHtmlService to npm module and sails.js config

in we.js 0.3.x sanitizer is avaible in we.sanitize


feat: move utils to internal (#27)

This pull request hides the unstable packages in utils by moving them to the internal folder, also extracting reflect methods into an own package. Not sure how internal works out on libraries - may be I have to revert later.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
841

Relevant Lines:
841

💛  - Coveralls


napri plugin not launching properly on Windows

This is because in #800 , we forgot to push one of Joshua's suggestions. This was raised by a user in https://github.com/axondeepseg/axondeepseg/discussions/826

I would like to express my heartfelt gratitude for providing such an excellent tool and your prompt response. I downloaded version 5.0.0 of AxonDeepSeg, but when I tried to open it with Napari, I was unable to locate the AxonDeepSeg plugin in the plugins menu.
The code is as follows.Generating axon and myelin segmentation masks and saving. * * * Integrity test passed. AxonDeepSeg is correctly installed. * * * (base) yunmanshan@### ~ % ads_napari WARNING:root:openblas_set_num_threads not found
pip show AxonDeepSeg Name: AxonDeepSeg Version: 5.0.0 Summary: Python tool for automatic axon and myelin segmentation Home-page: https://github.com/neuropoly/axondeepseg Author: NeuroPoly Lab, Polytechnique Montreal Author-email<EMAIL_ADDRESS>License: MIT Location: /Users/yunmanshan/axondeepseg/axondeepseg/AxonDeepSeg/axondeepseg Editable project location: /Users/yunmanshan/axondeepseg/axondeepseg/AxonDeepSeg/axondeepseg Requires: Required-by: (ads_demo) yunmanshan@##### axondeepseg %
ls /Users/yunmanshan/Downloads/axondeepseg/AxonDeepSeg init.py model_cards.py pycache models ads_utils.py morphometrics apply_model.py params.py download_model.py postprocessing.py download_tests.py segment.py integrity_test.py testing logo_ads-alpha.png visualization logo_ads-alpha_small.png (ads_demo) yunmanshan@##### axondeepseg %

This may be related to my own issues running napari on Mac, which was an issue on the napari side not AxonDeepSeg side. I opened an issue there about it: https://github.com/napari/napari/issues/7259
I think the problem was mainly that I was using Napari + a terminal that was running Rosetta (which simulates an intel CPU instead of ARM/M1 CPU). Doing so + a miniconda install (which was using intel-built binaries of some of the dependencies) caused issues. I know I changed my terminal options to no longer use rosetta, but also I believe we had updated the install script to use miniforge (but, you might need not to be running rosetta for it to pull the correct binaries). Maybe try that? Here's a link on how to change this setting: https://www.youtube.com/watch?v=9W8rTTE1WEA

@yunmanshan have you tried my suggestion?


Something about msvcr120

By @james-amarth

It seems to be that msvcr120 isn't actually installed with Titanfall, despite being required (also not present in __Installer), could we get a troubleshooting page about it with the fix being to install https://aka.ms/highdpimfc2013x64enu
VS2013 correlates to msvcr120 (instead of 2012 being 120, thanks Microsoft)
it's cropped up a few times as of recent and probably more with the steam sale making Titanfall cheap

Note that it's not clear yet whether simply starting vanilla first would solve the issue.

You do need msvcr120, but it does often come with many other games.

Having recently performed a fresh install and experienced the error myself I can confirm that starting vanilla does not fix it.
Either way instructions on how to resolve where added with #116 so this issue can be closed now ^^


feat(robot-server): persist previous run results and commands

Overview
Persisting protocol engine state to the DB on run pause and on run update. closes #8474
Changelog

moved ProtocolRunData to protocol_engine/state
added method get_protocol_run_data to StateView
insert ProtocolRunData and Commands into DB on route /runs/{runId} update to not current
insert ProtocolRunData and Commands into DB on route /runs/{runId}/actions when calling engine_store.runner.run()
get all commands and get commands slice on route '/runs/{runId}/commands'
get command by id on route '/run/{runId}/commands/{commandId}'
create run command on route '/runs/{runId}/commands'
create run action on route '/runs/{runId}/actions'
added run_data_manager.py and moved router logic related to engine_store and run_store there.
added run_controller.py to manage active run actions.

Review requests

make sure end points return proper data.
are we missing any tests?
naming makes sense
merged edge into branch. Make sure merge looks correct
docstrings make sense
acceptance test coverage

Risk assessment
High risk management. Need to make sure the end points are not broken and data is returned as expected.

Comments on acceptance tests to be handled in new PR
Found one raised error that was not caught in the router, fixed

Run store could raise RunNotFoundError on insert_action

Fixed up some docstrings
Made protocol_run_data > state_summary rename changes in more places for consistency

Running final smoke tests, and will merge if CI and those tests pass


Spans and flame graphs

Currently all our data is associated with a single instance in time - they are events.
There is however many things that require data to span a time range, such as audio and video.
Another useful thing to use spans for is for flame graphs, which is a way to visualize a call graph:

Such a flame graph is useful for profiling, but also for observability, i.e. understanding how a piece is connected.
Implementation
And easy way to implement this is to use a special enum Span { Begin, End } component.
We then have a special time range query that is aware of spans (i.e. querying for data in the time range [#10, #20] must include time ranges that spans [#0, #30]).
Together with a special Flame Graph Space View we have a pretty good start.
Threads and processes
For multi-threaded or multi-processed data we must have one flame-graph per thread:

We should also be able to record relationships between threads. For instance, we want to be able to see that thread A is blocked waiting on thread B and C (see also https://github.com/EmbarkStudios/puffin/issues/174).
This also means log events should come with a ProcessId and ThreadId component.
API
For Python, a with scope makes sense, as does a function decoration:
@rr.span
def my_function(images):
    for image in images:
        with rr.span(f"image {image.name}"):
            process(image)

…with optional recording argument
In Rust and C++ we would need to use macros, similar to e.g. puffin and loguru.
See also

https://github.com/rerun-io/rerun/issues/2852
https://github.com/rerun-io/rerun/issues/2963
https://github.com/rerun-io/rerun/issues/4622

It probably makes a lot of sense to both take inspiration and make sure we're ultimately compatible with OpenTelemetry. In this case worth looking at the tracing package: https://opentelemetry-python.readthedocs.io/en/latest/api/trace.html

Implementation
And easy way to implement this is to use a special enum Span { Begin, End } component.
We then have a special time range query that is aware of spans (i.e. querying for data in the time range [#10, #20] must include time ranges that spans [#0, #30]).
Together with a special Flame Graph Space View we have a pretty good start.

I'm not sure I understand why we need to introduce a new/special component for this?
Since the timepoint we have to day is effectively a start timepoint, an alternative implementation I had in mind was to introduce a second, optional timepoint for every log event, which specifies the end timepoint of the event (which therefore becomes a span rather than an event at this point).
If the end timepoint isn't specified, then we only look at the start timepoint and consider the event to be instantaneous, as we do today. Otherwise it's a span.
This allows to have spans that cover different time units quite naturally (e.g. "this event spanned 278ms wall-clock time (log_time), 90 simulation ticks (sim_tick) and was instantaneous on the the frame timeline (frame_nr)").
Then I don't think we need to change anything query-wise? Haven't thought about it enough to be sure though.

That is another way of implementing it for sure, but it is quite useful to be able to distinguish an event from a span, and it is also useful to be able to express half-open spans (spans with just a start or just an end).
I envision a flame-graph like view where log events (e.g. text and images) are shown as single point inside the span that contains them.

Maybe we should separate these concepts as:

Event: data + a time point
Duration event: data + start and end time
Span: an operation (unit of work) + a start and end time.

A hierarchical set of spans make up a trace

A trace can be visualized as a flame graph

Multiple events can be produced within a span


The editor's 2D and 3D viewports do not respond to slow mouse movements on Linux at high framerates

Operating system or device, Godot version, GPU Model and driver (if graphics related): Fedora 27 KDE, Godot Git https://github.com/godotengine/godot/commit/aa6772d7abb3ff1ff77b1b658617904bb0af1fbb, NVIDIA GeForce GTX 1080 (driver version 387.22)
Issue description: The editor does not respond to slow mouse movements in a 2D or 3D editor viewport (such as panning or aiming in freelook mode).
The issue is worsened if the editor renders at very high framerates (upwards of 200 FPS), which is easily achievable in 2D with modern GPUs when using the Update Always viewport update mode. Note that I'm using a flat libinput acceleration profile, which means that mouse acceleration is disabled on my system; I also had mouse acceleration disabled on Windows, without any issues.
This can make the editor pretty annoying to use, as it becomes much harder to adjust your viewport accurately.
Steps to reproduce: Begin panning in 2D or 3D while moving the mouse slowly.

Can you reproduce the issue at normal framerates and a high (<5cm) zoom level? I have noticed similar behavior there, and I think it might be related to editor input smoothing.

Can you reproduce the issue at normal framerates and a high (<5cm) zoom level?

It also occurs (albeit less strongly) when using the default Update Changes viewport update mode, which caps to 125 FPS.

Update: As of commit https://github.com/godotengine/godot/commit/fb8f71fe54d32487e6ac6fa90b783b7fa74d7170 on Fedora 28, this bug is still partly present. It's mostly noticeable when trying to pan using the middle mouse button in a 3D scene while using the Update Always viewport update mode with V-Sync disabled (so that the editor runs above 60 FPS).


Notice: Undefined variable: message in vendor\eden\core\src\Argument.php on line 54

Hello,
After I installed the latest version via composer and  run
$database = eden('mysql', '[HOST]' ,'[DBNAME]', '[USER]', '[PASS]'); //instantiate
I get a msg:
Fatal error: Call to undefined function eden() in /index.php on line
I search this error on google and see this issues https://github.com/Eden-PHP/Mysql/issues/1
I add Eden::DECORATOR; after require autoload
require_once __DIR__.'/vendor/autoload.php'; Eden::DECORATOR;
And I get a new php error:
Notice: Undefined variable: message in D:\HomeServer\htdocs\phpdemo\mail\vendor\eden\core\src\Argument.php on line 54

Notice: Undefined variable: code in D:\HomeServer\htdocs\phpdemo\mail\vendor\eden\core\src\Argument.php on line 54

Please help me, thanks!

Enable Eden
The following documentation uses eden() in its example reference. Enabling this function requires an extra step as descirbed in this section which is not required if you access this package using the following.
Eden\Core\Control::i();

When using composer, there is not an easy way to access functions from packages. As a workaround, adding this constant in your code will allow eden() to be available after.
Eden::DECORATOR;

For example:
Eden::DECORATOR;

eden()->inspect('Hello World');

This project has been through several iterations over the years and has ended up at https://github.com/CradlePHP/Storm - This is maintained regularly currently

I have the same issue, not resolved even after using Eden::DECORATOR; ...


How to use createSelectorCreator with reselect-tools

I'm creating a custom selector with my own deep equality check like:
const createDeepEqualSelector = createSelectorCreator(defaultMemoize, equals);

However, it's not clear how to use with with reselect-tools.

Hey @samuelcastro - this was a pretty obvious feature but I left it out because I haven't been using it in my codebase. The problem is here. This should default to createSelector and be overridable. For now you can probably just copy it. Don't worry about _allSelectors not being exposed - you can get your selectors into the graph by registering them.

In version 4.0.0 of reselect, they'll be adding selector dependencies internally, which will mean we no longer need to shim createSelector. If the shim isn't necessary, we won't have this problem any more.

What is the status of this?  I would like to use it but I need createSelectorCreator functionality?

Fixed in https://github.com/skortchmark9/reselect-tools/pull/13


Projects_Akash_logMessage

1948_AkashLogmessage.1.0.1.zip
Dear Vajrang, Kindly upload this piece of code or give me creds to upload package. thank you Akash


Allow x-bte-transfomer field for trapi apis

Helps solve https://github.com/biothings/BioThings_Explorer_TRAPI/issues/521 w/ https://github.com/biothings/api-respone-transform.js/pull/38

x-bte-transformer is not needed for TRAPI APIs


Error in @stitches/tailwind Documentation (wrong import of createCss)

This is mentionned in Configure section of stitches/tailwind:
import {createCss} from @stiches/styled instead of @stitches/css, right ?
Capture:

Ah, yes, fixed 😄


Back button on /defi route doesn't work

IMPORTANT: NO BOUNTIES WILL BE PAID FROM 2/5 - 2/14 - IF YOU COMPLETE THIS BOUNTY DURING THIS TIMEFRAME WE WILL REMIT PAYMENT ON 2/14
Overview
The back button on the top left hand side of the /defi route links to nothing but works on the /defi/earn route.
Recreation Steps:

Go to ShapeShift and connect a wallet
Click on the defi button at the top of the page
Click on the earn button on the defi page
Click the back button twice and notice the button on /defi/earn works but not on /defi

Acceptance Criteria
-Works in accordance with criteria specified by @SS-FOX-McCloud @DiggyDiggy2 @reallybeard
Bounty Documentation

Please check out our docs for how to get in touch with us or ask questions.

@tshifty I would like to work on this


fix: use lerna typings provided by DefinitelyTyped project

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Fixes #1350  🦕

Due to my commit mail being the @users.noreply.github.com provided by Github I can't verify it with my Google account. I will have to recommit with another mail later as there no other way afaik?

I will have to recommit with another mail later as there no other way afaik?

Yeah, the commit will have to come from an email address that can sign the CLA


flyway-core 7.7.0 (was 7.5.4)

Updates org.flywaydb:flyway-core from 7.5.4 to 7.7.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.flywaydb", artifactId = "flyway-core" } ]

labels: test-library-update, semver-minor

Superseded by #158.


libqmlbind: init at 0.2.0

Motivation for this change
C bindings for QtQuick, since a lot of programming languages have issues dealing with C++, and so is useful for writing Qt bindings to other languages. Not the highest priority package, since the only language I know that uses these bindings is Ruby, Swift (which I believe was abandoned), and my bindings for Crystal, but I thought I'd submit a pull request anyways.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Can you rename the commit title to match the pull request title? libqmlbind: init at 0.2.0

I am going to switch to a different library, don't see the need to have this merged anymore


Allow import from absolute URLs (or passthrough import mode)

Closure Compiler rejects import statements from an absolute URL. This should be easy to support if it just passes them through verbatim. Instead any presence of such a line causes the entire script to fail to compile.
Example in.js:
import test from "https://cdn.example.com/test.js";

Command line:
java -jar ./closure-compiler.jar --js in.js --js_output_file out.js --compilation_level SIMPLE --language_in ECMASCRIPT_2020 --language_out ECMASCRIPT_2020
Observed result:
in.js:2:0: ERROR - [JSC_INVALID_MODULE_PATH] Invalid module path "https://cdn.example.com/test.js" for resolution mode "BROWSER"
  2| import test from "https://cdn.example.com/test.js";
     ^

1 error(s), 0 warning(s)

Expected result:
Output file to contain the same import statement.
Similar to issue #3707, if there is a passthrough module resolution mode, we can just set it to output import statements verbatim and this case will work. This makes it much easier to use Closure Compiler as a general minifier tool, since otherwise the presence of module features causes the whole compilation to fail.

Are you hoping for a "file by file" compilation here?  Or are you hoping the resulting bundle would preserve the import?
For one off dependencies, you can use the output wrapper to wrap the compiler's output to make it a module.

Yes, I think this is basically a "file by file" case - we're basically using Closure Compiler as just a minifier, because it is probably the most sophisticated minifier anyone's built.
Since we're just minifying code, we don't care about changing imports at all, so it's fine for Closure Compiler to just pass through imports unmodified.
I'm not sure what you mean about using an output wrapper - how does that help in this case? We need this to work in general though, not for one-off cases.


Problem with sharedParams number in controller

When using sharedParams.addNumber(...), then the controller shows a numberBox input field with 4 arrow buttons. 2 look like standard number in-/decrease buttons (right hand side of input pointing up/down). When using those, the number in the input field is shortly shown then immediately is deleted (always shows 1). If you input the number manually, it's also deleted. When using the other 2 (looks custom made) arrow buttons (pointing left/right on the sides of the numberBox) I get the error:
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0
/js/controller.js:2020:24  TypeError: step is undefined

Hi,
Yes, the component needs a step to work properly, for example:
sharedParams.addNumber('my-number', 'my-label', 0, 1, 0.001, 0.707);

where the parameters are : key, label, min, max, step, defaultValue
(be aware that this version of soundworks will be deprecated soon)

I'm always happy to see activity on this project :-)
M
On Tue, 21 Jul 2020, 10:37 Benjamin Matuszewski<EMAIL_ADDRESS>wrote:

Hi,
Yes, the component needs a step to work properly, for example:
sharedParams.addNumber('my-number', 'my-label', 0, 1, 0.001, 0.707);
where the parameters are : key, label, min, max, step, defaultValue
(be aware that this version of soundworks will be deprecated soon)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/collective-soundworks/soundworks/issues/14#issuecomment-661718684,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCS6WAVZJK2CZAWT44G4L3R4VHUNANCNFSM4PDKAJDQ
.

I hope it will be a good surprise for you in September then :)

Ooh!
On Tue, 21 Jul 2020, 12:11 Benjamin Matuszewski<EMAIL_ADDRESS>wrote:

I hope it will be a good surprise for you in September then :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/collective-soundworks/soundworks/issues/14#issuecomment-661766875,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCS6WBXP6G5ZN3DJQC2OCDR4VSWVANCNFSM4PDKAJDQ
.

Works! Thanks for that very fast reply!! There are still two sets of buttons but that's alright :) And if I could add something to my wishlist for the next version: optional limits :)

Perfect !


Feature req: Don't use Prowlarr

With Zilian and now the Torrentio scraper it would be nice if it was possible to only use those two options and not Prowlarr.

it is possible, put some example values in env variables and just don't select anything on the configuration WebUI.

I will add a toggle soon so it's more explicit 🫡


Move rxjs/add/* modules to a separate package for 6.0?

Most of us are in agreement that we'd advise people use the pipeable operators instead of the prototype patching for a variety of reasons that have been outlined elsewhere.
Do we want to keep the rxjs/add/* modules in the same package as everything else, or do we want to have a separate package to support dot-chaining on NPM?
Or... more extreme... should we eliminate them? Maybe even wait for v 7 for that?
Either way, how could we best educate people of the caveats?

@kwonoj @david-driscoll

This seems related with https://github.com/ReactiveX/rxjs/issues/2911, so in next major, dot chain operator syntax is no longer default thing? I think this discussion is really depends on those direction.

Yeah, I suppose it's related for sure. Although it doesn't really have to be... you can definitely have dot-chaining without lift.

There should be long other discussions need to be done, But first I'd downvote to eliminating it completely. It's too radical even for major breaking.

@kwonoj I think I agree. I don't think I'm down for completely eliminating it. At least not in the short to mid-term. But a separation might provide people better guidance and clarity.

yes, I'm sort of agreeing to separate packages, especially given size constraint we'd like to achieve in pkg. Either case it'll be huge breaking so through guide / migration process should be prepared.

A separate package could possibly have very confusing bugs with node module resolution / node_modules structure where the Observable import may not resolve to the correct version (I've hit bugs like that and they are insanely hard to debug). It would also mean it's harder to upgrade to v6 (e.g. a Greenkeeper PR won't do it). I would vote for keeping them in the main package for now and deprecate them. Then they can be removed in a future major version when most people are using lettable operators.

@felixfbecker the separate package would need to have peer-dependency requirements.

so talking to @ladyleet for a minute on slack I think I understand what you want to do.
My suggestion is to bring lerna which makes it possible to publish multiple packages from the root with the same version.
so we probably start with

core (all of rxjs)
websocket subject
ajax subject


Finish preparing for v0.6.0-rc1 release

Signed-off-by: Nick Young<EMAIL_ADDRESS>
Release v0.6.0 prep PR.

Thanks @youngnick!
/lgtm


Bloop doesn't start: IOException java not such file or directory

Version(s) 0.1.2
Describe the bug
When running a simple example store here I encounter this error:
[benkio@nixos:~/temp]$ scala-cli compile TableReservationSystem.sc
Bloop daemon status: not running
Starting Bloop 1.4.19 at /home/benkio/.local/share/scalacli/bloop/daemon using JVM /home/benkio/.cache/coursier/arc/https/github.com/adoptium/temurin17-binaries/releases/download/jdk-17%252B35/OpenJDK17-jdk_x64_linux_hotspot_17_35.tar.gz/jdk-17+35/bin/java
Error: java.io.IOException: Cannot run program "/home/benkio/.cache/coursier/arc/https/github.com/adoptium/temurin17-binaries/releases/download/jdk-17%252B35/OpenJDK17-jdk_x64_linux_hotspot_17_35.tar.gz/jdk-17+35/bin/java" (in directory "/home/benkio/.local/share/scalacli/bloop"): error=2, No such file or directory
For more details, please see '/home/benkio/temp/.scala-build/stacktraces/1646573019-12945047684502775367.log'

[benkio@nixos:~/temp]$ scala-cli --version
0.1.2

[benkio@nixos:~/temp]$ ls /home/benkio/.cache/coursier/arc/https/github.com/adoptium/temurin17-binaries/releases/download/jdk-17%252B35/OpenJDK17-jdk_x64_linux_hotspot_17_35.tar.gz/jdk-17+35/bin/
jar*	    javadoc*   jdb*	   jhsdb*   jmap*      jrunscript*  jstatd*
jarsigner*  javap*     jdeprscan*  jimage*  jmod*      jshell*	    keytool*
java*	    jcmd*      jdeps*	   jinfo*   jpackage*  jstack*	    rmiregistry*
javac*	    jconsole*  jfr*	   jlink*   jps*       jstat*	    serialver*

To Reproduce
Just donload the gist at https://gist.github.com/benkio/baa4fe1d50751cd602c4175f1bb39f4d and run
scala-cli compile file.sc
Expected behaviour
It should run fine as the scastie version here: https://scastie.scala-lang.org/urJPRXNTQGuwhcLCFAtJMQ

If you are running on Nixos which it looks like then it's the running of unpatched binaries issue. I have the same problem on my set up (it runs fine on another machine that is linux with nix).

Yes, I'm on NixOs unstable.
Then I just have to wait until it's solved by upgrading to a new version/binaries in the nixos channels?
(BTW it could be helpful in case someone else encounter the same error these days)

Apologies I should have been more clear. It is a problem, of sorts, in running a non-nixos prebuilt binary that is downloaded (which is what the scala-cli program appears to do to run the operation described by the arguments)  and then trying to run that via nixos which won't accept it - see nixos wiki. There seem to be a few ways of trying to accommodate this but I have not attempted any of these in this case yet.

I see, but I expected this: https://github.com/kubukoz/scala-cli.nix to include such tricks :smile:
Shall I migrate/link this issue there?

I'll try ASAP

Tried right now, specifying the jvm id as bloop jvm option solves the problem!!!
I close the issue then.
Here the shell output for reference
[benkio@nixos:~/temp]$ scala-cli compile TableReservation.sc
Bloop daemon status: not running
Starting Bloop 1.4.19 at /home/benkio/.local/share/scalacli/bloop/daemon using JVM /home/benkio/.cache/coursier/arc/https/github.com/adoptium/temurin17-binaries/releases/download/jdk-17%252B35/OpenJDK17-jdk_x64_linux_hotspot_17_35.tar.gz/jdk-17+35/bin/java
Error: java.io.IOException: Cannot run program "/home/benkio/.cache/coursier/arc/https/github.com/adoptium/temurin17-binaries/releases/download/jdk-17%252B35/OpenJDK17-jdk_x64_linux_hotspot_17_35.tar.gz/jdk-17+35/bin/java" (in directory "/home/benkio/.local/share/scalacli/bloop"): error=2, No such file or directory
For more details, please see '/home/benkio/temp/.scala-build/stacktraces/1648383902-9060340931562694713.log'

[benkio@nixos:~/temp]$ scala-cli --version && which java && java --version
0.1.2
/home/benkio/.nix-profile/bin/java
openjdk 17.0.1 2021-10-19
OpenJDK Runtime Environment (build 17.0.1+12-nixos)
OpenJDK 64-Bit Server VM (build 17.0.1+12-nixos, mixed mode, sharing)

[benkio@nixos:~/temp]$ scala-cli compile TableReservation.sc --bloop-jvm='system|17'
Compiling project (Scala 3.1.1, JVM)
Compiled project (Scala 3.1.1, JVM)

[benkio@nixos:~/temp]$

PS: when you run scala-cli compile --help the option --bloop-jvm doesn't appear. Adding it is worth considering


Test files now  pytest

Description
Changed test files to use pytest
Verification
Ran pytest on the files

I recall we had an issue with pytest.skip earlier, can you make sure that's no longer an issue where you replaced unittest.skip?  to ruff's banned-api

Closing, this is a very simple change that shouldn't require as much review as this has gotten so far.


Adding custom fields in OmniAuth::Form

It would be nide to have an option to add custom fields /text, hidden/ to the login form.
The gitlab added CSRF protection for omniauth providers, see my MR https://github.com/robdimarco/omniauth_crowd/pull/23.
As I'm no ruby expert, is there any other way to push custom fields into the form or the code needed to be changed?

Thanks for the pull request, I just merged it.
I think the code would need to be changed to allow for custom fields, happy to look at pull requests.


CNN branch

did you use pre-train for PidiNet ?

Yes, we have added pre-train for Pidinet in weights folder
https://github.com/Omid-Nejati/BEFUnet/tree/main/weights