Error while using string.Split("|||") function.

While using the below policy expression an 'incorrect values' error is thrown:
<set-variable name="testing" value="@{
            var separator = "|||";
            var content = "data1|||data2|||data3";
            var values = content.Split(separator);
            return values;
        }" />

From the documentation it appears that there is support for System.String type, however the above error seems to suggest otherwise.  Please clarify if it is something that is not supported.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2a90be78-63d0-8ee0-d1d6-a9280e2ba892
Version Independent ID: 500c452d-372b-92a9-dfca-b2586669a9bf
Content: Azure API Management policy expressions
Content Source: articles/api-management/api-management-policy-expressions.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

@spmanjunath Thanks for the feedback. We are actively investigating and will get back to you soon.

@spmanjunath Since your delimiter comprises of multiple characters (|||), you might try using String.Substring or Regex.Split instead: https://docs.microsoft.com/en-us/dotnet/api/system.string.split?view=netframework-4.8#alternatives-to-stringsplit

@spmanjunath We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Release 0.6.0-beta.3 on CocoaPods

Thanks for the reminder! I've pushed the new version to CocoaPods.


Page group clone

We already have page clone functionality in the system.If we could extend it to page group level that would be time saving

We will take up this feature in Roadmap 3

Sure


RangeError: Maximum call stack size exceeded

I am using knex 0.12.6 and node 6.9.1 and there seems to be a problem with where clauses and functions.
With a simple query:
const query = knex('store')
  .where(function where() {
    this.where('id', 1);
  })
  .toSQL();

It doesn't even get in the where callback it errors before.
RangeError: Maximum call stack size exceeded
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:97:27)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)
    at Object.containsUndefined (/srv/dp/api/current/node_modules/knex/lib/helpers.js:115:35)

It may be similar to #1725 but upgrading to latest knex did not fix the issue.

@smitt04 What dialect is this reproduced with? I've been running knex 12.6 and node 6 in production for months without having this issue, so thinking it could be dialect specific.

this is mysql. Let me see if i can get a test.

It took me a while but i finally was able to replicate it. I couldn't get a simple project to replicate it, so i kept on adding to it until it got closer and closer to my project structure. Unfortunately it is a little complex involving an http server and graphql. But i tried to make it as simple as possible.
Here is the simplest project i could create to replicate it.
knexTest.zip
Steps to test:

run npm install
run app node app.js
navigate to http://localhost:8000/graphql?query={
  query
}

That should execute the simple graphql query an return the error. You will also be able to see the stack trace in the terminal.
I suspect it is a problem with domains but not sure. Let me know if you have any questions or still can't reproduce.

This seems to be the minimal testcase
npm install knex sand-http

const knex = require('knex')({ client: 'mysql' });
const http = require('sand-http');
const query = knex('store')
  .where(function () {
    this.where('id', 1);
  })
  .toSQL();

You are right, that is much shorter. So i looked into sand-http to try and figure why it was causing this issue, as it doesn't do anything by just requiring it.
It turns out it was because of
require('generator-bind').polyfill();

so by changing out sand-http for generator-bind causes the same issue.
const knex = require('knex')({ client: 'mysql' });
require('generator-bind').polyfill();
const query = knex('store')
  .where(function () {
    this.where('id', 1);
  })
  .toSQL();

It is weird that the generator-bind is causing this issue. Removing it fixes it, so i will do that for now. I will let you decide if you think this is still an issue or not.

@smitt04 @elhigu Looking at the code of 'generator-bind' module, it is directly modifying the prototype of Function, and naturally knex's code calls querybuilding functions with a bound context of the query builder instance. Since generator-bind has overwritten the bind function on Function's prototype, this is the result.
Personally, I would say this is not a knex issue.

I saw this error trying to use Knex from a webdriverio test. There, the issue was caused by webdriverio using the node-fibers package, which unfortuinately adds a new method to Function.prototype.
I'm currently investigating whether this is something that can be fixed in webdriverio, whether it can be fixed by changing the logic of containsUndefined() to avoid circular references (which is what causes the Maximum call stack exceeded, as it forever recurses trying to check a circular reference), or whether I'll have to run Knex migrations through the CLI instead of through the JS API to ensure it runs in a clean environment.

I was getting caught out by this. In order to use Knex, I added a hasOwnProperty check in containsUndefined. I'm sure not on the impact but it's not caused anything to fail.

I'm experiencing the same problem in a WebdriverIO context.
Unfortunately, if I wish to wipe and reseed the whole database before each test suite, the CLI alternative is not an option (at least I dont know a way to run CLI commands between "describe"s)
@thomasboyt could you find anything on this?

I maintain a fork that fixes this (at least for us). You could try that
version and see if that helps. Github foxdog-studios knex. Sorry no link
doing this with thumb
On 24 Apr 2017 8:22 pm, "Andrés Mata Suárez"<EMAIL_ADDRESS>wrote:

I'm experiencing the same problem in a WebdriverIO context.
Unfortunately, if I wish to wipe and reseed the whole database before each
test suite, the CLI alternative is not an option (at least I dont know a
way to run CLI commands between "describe"s)
@thomasboyt https://github.com/thomasboyt could you find anything on
this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tgriesser/knex/issues/1851#issuecomment-296795965,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAU7XxpYAO4kIqPQUzm16vHOnzx1UPqbks5rzPZngaJpZM4La6G7
.

@andresmatasuarez I do the same thing, and a quick fix is to put
(Function.prototype as any).future = null;
somewhere at the start of your code

sorry @wwwouter, I didn't quite get your fix. (Function.prototype as any).future = null; is a syntax error

Sorry, we use typeScript. In javascript it's:
Function.prototype.future = null

@andresmatasuarez @thomasboyt
Just a quick thing because I have read that other people had the same issue: I added a chrome extension to my WDIO test by adding it base64 encoded to capabilities.chromeOptions.extensions. Due to that, I saw the following error on each exit though: Maximum call stack size exceeded, even when the feature didn't have any errors. The solution was to remove the extension again from the capabilities before spawning, like so:
    before: (capabilities) => {
        // We have to remove the base64 encoded chrome browser extensions as
        // the object WDIO carries along otherwise takes up too much memory
        delete capabilities.chromeOptions.extensions
}

I had this problem when running tests within Jest. Not sure if it was due to Jest, but in the end the only fix was to use a RAW query instead.

@smitt04 @elhigu Looking at the code of 'generator-bind' module, it is directly modifying the prototype of Function, and naturally knex's code calls querybuilding functions with a bound context of the query builder instance. Since generator-bind has overwritten the bind function on Function's prototype, this is the result.

For information the same error happens when using the query builder syntax (where((qb: Knex.QueryBuilder) => { ... }) which presumably doesn't or shouldn't rely on function binding.

@laurent22 Can you create a failing test with the repro?

Unfortunately it's hard to extract just that part, but if you're willing to try I've put the issue in this branch:
https://github.com/laurent22/joplin/tree/knex_max_call_size_bug
To try it would just be:
npm install
cd packages/server
npm test -- shares.folder -t 'should get delta changes - user 1 and 2 are in sync, user 2 adds a note to shared folder'

To view the database structure, you can comment out await afterAllTests();, then run the test again, and open db-shares.test.sqlite.
If you want to test and make changes, from another terminal window run npm run watch (from the root of the monorepo)
And the infinite loop happens here: https://github.com/laurent22/joplin/blob/f5bfdd893745990c5cc7b15276edc47dc8315d6d/packages/server/src/models/ChangeModel.ts#L92

@laurent22  Could you check if this still fail:
npm install sand-http

const knex = require('knex')({ client: 'mysql' });
const http = require('sand-http');
const query = knex('store')
  .where((qb) => {
    qb.where('id', 1);
  })
  .toSQL();

If that works, it is probably a different problem.

@elhigu, I can't replicate it with your code, but I can if I add a "whereIn" condition:
const knex = require('knex')({ client: 'mysql' });
const http = require('sand-http');

knex('store')
.where((qb) => {
    qb.whereIn('id', qb.select('1'));
})
.toSQL();

In that case I get the error RangeError: Maximum call stack size exceeded. I guess whereIn is the issue then as I'm also using this in my code where the infinite loop is happening.

qb.whereIn('id', qb.select('1'));  looks wrong.
It should be qb.whereIn('id', knex.select('1'));

Indeed it doesn't give the error with this syntax, although I would expect that the query context should be the same all along, so using the same query builder? And, in any case, if it's wrong shouldn't it print an error rather than go into an infinite loop?
In any case I can't quite wrap my head around these nested queries, some using "qb", some "knex", some "this" so I'll probably keep using raw queries for that for now.

In your case you are creating query builder instance and then you modify inplace that instance and put it inside itself... same kind of case like in this, but in more sutil form:
const builder = knex('table');
builder.select('1');
builder.where('id', builder);


Misspellings: assignemnts and indentity.

[Enter feedback here]
Two misspellings on this page: assignemnts and indentity.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 44b9a84f-6765-67dc-bb7b-04303e070c03
Version Independent ID: 32fc20a0-4321-c74a-34aa-909f43a72db0
Content: Grant permission to applications to access an Azure key vault using Azure RBAC
Content Source: articles/key-vault/general/rbac-guide.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@douglasmaciver
Thanks for your feedback! We will investigate and update as appropriate.

@douglasmaciver
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


BrowserStack integration

What is the context of this PR?
Added capability to run functional tests via BrowserStack from the command line. Using the BrowserStack local tunnel.
How to review
Trigger the tests locally by running the following command.
BROWSERSTACK_USER=#### BROWSERSTACK_ACCESS_KEY=#### yarn test_functional_browserstack

This is proving to be un-reliable - sometimes the tests don't run, and sometimes they run multiple times on BrowserStack. Also the new functional tests don't seem to work - they launch locally in Chrome. I say we should park this and pick it back up once all the functional tests are in one place. We should also consider the effort it would take to move to ChimpJS as this may prove more reliable than the code we've written to do this.

I've thought some more about this, given that it doesn't break any existing functionality and it gives us a way to run functional tests against BrowserStack I think we should merge this.


PHP-FPM liveness_check

I'm working with Docker containers and my gaeapp has 2 supervisor services running:
nginx
php-fpm

I need to configure my /rediness_check and /liveness_check to make sure those services are running. I tried to implement the custom path on my default.yaml file:
liveness_check:
  path: "/_ah/health.php"

and it didn't worked the liveness_check started returning a 301 instead and there was no request to my path. It would be nice to have better documentation on this or some samples using custom health checks that are supposedly supported by the docs: https://cloud.google.com/appengine/docs/flexible/php/reference/app-yaml#liveness_checks

Custom healthchecks are largely going to be up to the person implementing to make it happen. The docs advise you to specify a custom URL but the URL you specified is going to be matched by the regular expression in this file and not passed on to your application.
Instead you should point the rediness and liveness checks at your own URL like ${DOCUMENT_ROOT}/_app/health.php.


Added NLog ADX sink

Added Nlog ADX Custom target

Notice to provide an array of parameters (Ex. ColumnMappings), then consider using this (where SinkColumnMapping becomes class instead of struct)
[ArrayParameter(typeof(SinkColumnMapping), "columnMapping")]
public IList<SinkColumnMapping> ColumnMappings { get; private set; }

Then you can do this in NLog.config:
<target name="ADXTarget" xsi:type="ADXTarget">
       <columnMapping name="abc" columnType="bing" ValuePath="hello" />
       <columnMapping name="def" columnType="bong" ValuePath="world" />
</target>

Or like this in appsettings.json:
 "target": {
      "ADXTarget": {
        "type": "ADXTarget",
        "columnMappings": [
          {
            "name": "abc",
            "columnType": "bing",
            "ValuePath": "hello"
          },
          {
            "name": "def",
            "columnType": "bong",
            "ValuePath": "world"
          }
        ]

Btw. it looks like this ColumnMapping is very hardcoded, and depends on ADXLogEvent. So maybe it should not be configurable at all, but just be reflection based on ADXLogEvent-properties.
See also: https://github.com/NLog/NLog/wiki/How-to-write-a-custom-target
See also: https://github.com/NLog/NLog/wiki/Properties-constraints-for-custom-extensions

Notice to provide an array of parameters (Ex. ColumnMappings), then consider using this (where SinkColumnMapping becomes class instead of struct)
[ArrayParameter(typeof(SinkColumnMapping), "columnMapping")]
public IList<SinkColumnMapping> ColumnMappings { get; private set; }

Then you can do this in NLog.config:
<target name="ADXTarget" xsi:type="ADXTarget">
       <columnMapping name="abc" columnType="bing" ValuePath="hello" />
       <columnMapping name="def" columnType="bong" ValuePath="world" />
</target>

Or like this in appsettings.json:
 "target": {
      "ADXTarget": {
        "type": "ADXTarget",
        "columnMappings": [
          {
            "name": "abc",
            "columnType": "bing",
            "ValuePath": "hello"
          },
          {
            "name": "def",
            "columnType": "bong",
            "ValuePath": "world"
          }
        ]

Btw. it looks like this ColumnMapping is very hardcoded, and depends on ADXLogEvent. So maybe it should not be configurable at all, but just be reflection based on ADXLogEvent-class-properties.
See also: https://github.com/NLog/NLog/wiki/How-to-write-a-custom-target See also: https://github.com/NLog/NLog/wiki/Properties-constraints-for-custom-extensions

Hi @snakefoot ,
We have decided to remove the columnmappings altogether. Can you see if the asked comments can be negated?
And really  thankyou for the review,  Can you check now if we are fine now or missing something?


🐛 fix canny URL

openbook.canny.io -> okuna.canny.io
might have already been fixed in someone's branch but here it is anyway

Thanks!


[Bug Report]: All ADO pipelines triggering on PRs

Describe the bug
When working on PRs, all the ADO pipelines trigger unintentionally.
To reproduce
Start a PR, do changes to the branch in your PR, go to ADO and see all the CARML related pipelines have triggered.
Code snippet
No response
Relevant log output
No response

Testing to fix this with the use of the pr: none


#5388 enter key in easyform textfield should press button

There is one more issue with datepicker (flatpickr):
Flatpickr consumes the Enter button keypress event and it seems that https://github.com/chmln/flatpickr/issues/355 solves the issue only for keydown.
@scottdraves  is it OK to use the keydown instead of the keypress here?
Or maybe we should use different datepicker library eg. jquery-ui?
Second thing is if we should move the Text implementations as it uses the beakerx module instead the jupyter-js-widget. That is to disable the text widget preventing the Enter keypress event delegation.

i'm getting this:

oh no it's in master


Problem computing time ranges using ".intervals()"

Hi there,
while the promised
print('\n'.join(map(lambda x: x.rfc3339(), \
  maya.intervals(start=maya.now(), end=maya.now().add(days=1), interval=60*60))))

seems to work as expected, we had problems when computing time ranges with different parameters.
While, when attempting to compute time ranges of one week into the future, using an
interval of 23 hours
print('\n'.join(map(lambda x: x.rfc3339(), \
  maya.intervals(start=maya.now(), end=maya.now().add(weeks=1), interval=60*60*23))))

still seems to work fine, running the computation with an
interval of 24 hours
print('\n'.join(map(lambda x: x.rfc3339(), \
  maya.intervals(start=maya.now(), end=maya.now().add(weeks=1), interval=60*60*24))))

runs into an endless loop. On the other hand, using
25 hours as an interval
in fact uses an interval of 1 hour:
print('\n'.join(map(lambda x: x.rfc3339(), \
  maya.intervals(start=maya.now(), end=maya.now().add(weeks=1), interval=60*60*25))))

Maybe you or @timofurrer could have a look at this?
Last but not least: Thanks for conceiving and maintaining this fine Python package. Have a Merry Christmas or other holiday of your choice!
With kind regards,
Andreas.

In the meanwhile, we settled for the rrule feature from the dateutil package as @moin18 suggested at Iterator for continuous datetimes. Thanks, Moinuddin!

I just ran into this. The problem seems to be that the implementation doesn't correctly account for a timedelta's seconds. I have a proposed fix here: https://github.com/kennethreitz/maya/pull/169

Fixed by @ftobia ! Thank you very much! :tada:


Make AST nodes more uniform

Add Node prefix to Variable, ArrayIndex, and Reference classes
Use nouns for node names (e.g. ArrayIndexingNode instead of ArrayIndexNode)
Add ProcessDeclarationNode and HostDeclarationNode
Rename Host to HostName
Maintain declaration order in ProgramNode

Resolved by ad9460afe48b34ee2bc5e97067686796653da2d0.


Regaddressfix

Whitelist fees set to zero. Fixed register address. for Multisig. Added a few tests and applied changes Nikos requested in the previous pull request. Refactored some code.

Tested and ready to go

What's the purpose of changing set to vector? Is it the case we can the same pub key multiple times? Should that be expected?

Set was changed to a vector, as explained, to retain the order of the pubkeys which is essential in multisig  address recreation/verification. That data is not used for that purpose at the moment,  but there may be a time in the future when we will need it.


Update Glutin to 0.21.0

Fixes #2757
Note that this represents a significant change to the public API of the OpenGL backend. In addition to the various type changes needed due to changes in Glutin 0.21:

In Glutin 0.21, make_current() consumes the Context struct. So it is not possible for the types in gfx-backend-gl::window::glutin to make themselves the current context anymore. After this PR, the calling code must make the context current before instantiating any gfx windowing types.

gfx-backend-gl::window::glutin::Headless must now carry a Starc because only non-current contexts implement Send and Sync in Glutin 0.21, but only current contexts can be used to implement hal::Instance. To help with constructing a Headless, I have added Headless::from_context().

get_window() has been renamed get_context() to reflect that, in Glutin 0.21, glutin::WindowedContext dereferences to glutin::Context rather than glutin::Window and additional steps must be taken to access the Window.

PR checklist:

[x] make succeeds (on *nix)
[x] make reftests succeeds
[x] tested examples with the following backends: OpenGL
[x] rustfmt run on changed code

One design decision I'd particularly welcome input on is that none of the types in gfx-backend-gl::window::glutin support being used with glutin::Contexts that are glutin::NotCurrent. Non-current contexts are basically useless for anything until they're made current. The only value I could find in storing NotCurrent Contexts was making the containing type sendable to another thread, but the OpenGL backend already uses Starc for that. But if I am missing some reason support for these would be important, please let me know.
On a similar note, I am concerned that the solution I've come up with here unduly hampers apps' ability to use multiple Contexts. Because of the way making a context current/not-current in 0.21 consumes the struct and potentially creates a new one and/or changes its type, it's awkward to store them in other structs unless you have mutable access to move things in/out of the struct. This is further complicated because the existing code needs to make the Context current inside functions where self is not mutable.
I started building a solution by making these types store an Option inside a Cell inside a Starc, but it feels dirty to me, and it's not clear to me if this is even a supported way to use gfx-backend-gl. Could someone who is better-versed in gfx tell me if this is even a valid use case to worry about?

@arashikou sorry for letting this sit for a bit. It's a complex piece to review (for me), and just occurred at the same time as our Mozilla all hands. We'll get this sorted out ASAP.

Could someone who is better-versed in gfx tell me if this is even a valid use case to worry about?

Well, we definitely need to support GL operations on a device with &self borrowing. And that requires GL context to be active. So there needs to be some way to make it active, likely by utilizing some form of internal mutability (like RefCell).

@kvark No worries! It was a complex piece for me to understand well enough to write, so I know it's not easy to review. Is there anything I could do to make reviewing easier next time? I'm pretty new to OSS and open to advice on how to effectively contribute.
Thank you for taking a look at this. Just to be sure I've been clear: There is no way to enforce that the Context is active. At best, we can require that it be possibly active. So right now, the code as I've written it assumes the caller made the context active before passing it to gfx and that it will never become inactive. i.e. There will never be any other contexts but this one. That much is the minimum necessary to get the tests passing.
But the tests never have multiple contexts active at once. Having multiple contexts means continually deactivating and reactivating them as you switch between them. If we want to allow for the possibility of the context becoming inactive and gfx needing to reactivate it, then we will have to do something with internal mutability.

bors got stuck?
bors r+

Bors has been pending on this PR since I submitted it, TBH.

bors r-

bors retry

bors r+

Bors retry

On Jun 24, 2019, at 16:17, bors[bot]<EMAIL_ADDRESS>wrote:
Canceled (will resume)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@bors glad to see you back, bro!


How do i get local mac address of device bluetooth?

@biks152207 You should ask this on StackOverflow.


Metrics tests can't run on Mac

Only run metrics tests on Linux

LGTM, I've double-checked that this doesn't prevent the test from being run on my linux box.


Whitelisting forms specific checkpoints

Please ensure your pull request adheres to the following guidelines:

[ ] make sure to link the related issues in this description
[ ] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues
Thanks for contributing!

it is not clear how these checkpoints will be used in analysis and what insights can be derived from them


Serial number in config request

Add serial number to config request.

There is no serial number in their documentation.
https://wiki.mikrotik.com/wiki/Manual:System/Resource
There is no serial number accessible from RouterOS scripts on any of these three different devices either.

RBD53GR-5HacD2HnD
hAP ac lite
CHR


Early stopping

Add a Poisson KPI model for Stan and the unit test (Unit tests might run even longer now)
Fixed setup.py such that Stan model files are also installed with the remaining modules

Coverage decreased (-0.08%) to 76.312% when pulling e0ff0f8b65e8cb9686c3d5571543e7320337dd42 on feature/early-stopping into 1498e59b6bccc4621f5b680d555d5c6373d6d25c on dev.

Coverage decreased (-0.03%) to 76.365% when pulling 8d63ac7a3c7568c772c4ad87261aafec0983bcc2 on feature/early-stopping into 1498e59b6bccc4621f5b680d555d5c6373d6d25c on dev.

ok, obviously the addition of a prior messed up with the random seed, fixed that now. Does that resolve #85 , @gbordyugov ?

unfortunately not @jbao

Reducing the initial stepsize seems to solve the problem of numerical instability (which amounts to several run-time warnings about parameter constraints).
See also https://groups.google.com/forum/#!topic/stan-users/hpGvb_ZpJ3c

Coverage decreased (-0.03%) to 76.365% when pulling c57f3a6ad74ed79e985f253703b9ed1f108f6953 on feature/early-stopping into 1498e59b6bccc4621f5b680d555d5c6373d6d25c on dev.


feat(map): use autoware_cmake to avoid Boost warning

Description
https://github.com/autowarefoundation/autoware.universe/pull/849 からBoostのwarningが出ているパッケージだけを抜き出して適用
Related Links
https://tier4.atlassian.net/browse/AEAP-488
Tests performed

下記のコマンドでビルドしてmap以下のパッケージでBoostのwarningが出ないこと
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --catkin-skip-building-tests --parallel-workers 8 --packages-up-to  $(colcon list --base-path src/autoware/universe/map/ | awk '{print $1}')

Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Codecov Report

:exclamation: No coverage uploaded for pull request base (beta/v0.3.16@ee0f0d2). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.3.16    #531   +/-   ##
==============================================
  Coverage                ?   3.35%
==============================================
  Files                   ?     179
  Lines                   ?   17046
  Branches                ?    4616
==============================================
  Hits                    ?     572
  Misses                  ?   15978
  Partials                ?     496

Flag
Coverage Δ

differential
3.35% <0.00%> (?)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[feature request] allowing user play / control

Can we have a function that allows user to play as an agent in the environment? It allows for demonstration data collection etc.

Hmm, you don't need an additional function to do that. You could simply have a human specify an action, and then call the move or turn function on the simulator object with the appropriate arguments.


Resource edit buttons are not hidden if user lacks permissions

If you go to resource version page in private browser: https://hangar.benndorf.dev/MiniDigger/Test/versions/5.2.35/paper
You'll notice, that you have orange edit buttons available, which open the appropriate edit menu:

They should be hidden, if user doesn't have permission to edit resource.
You can't submit the change, as backed returns "You must be logged in" error.

Should be an easy PR
https://github.com/PaperMC/Hangar/blob/master/frontend/components/modals/versions/DependencyEditModal.vue#L4
Needs an v-if $perms.canEditProject or however the perm is called, else hopefully I can take a look tomorrow

Wow, is this like, the first legit bug issue?

The first of many ^^

Oh yeah, can't wait for that.

I've reported a few >:(

I've reported a few >:(

https://www.youtube.com/watch?v=5sBhc8je8Y0


Cannot configure multiple paths over same custom port

It appears it is not possible to have multiple paths that use the same custom port number (which is likely unintentional). For example:
app.UseHealthChecks("/health/live", port: 9999);
app.UseHealthChecks("/health/ready", port: 9999);

The second configured path in the example ("/health/ready") is not accessible because the first configured path is hogging up the port - seemingly due to the equality condition set up in HealthCheckApplicationBuilderExtensions.cs UseHealthChecksCore() method, line 214.
app.MapWhen(
  c => c.Connection.LocalPort == port,
  b0 => b0.Map(path, b1 => b1.UseMiddleware<HealthCheckMiddleware>(args)));

This middleware is great; thank you for your work.

Thanks. This looks like this is indeed a bug.

Fixed for the 2.2.0 release. Thanks for the feedback 👍


Question about retry: :always Req option

Hi @wojtekmach!
Thanks for the library! I've said it many times and every time I get a chance I like to say that I love your work. I love Req too!
I wanted to reach out about the following behavior and see if I am missing something:
I created a small repro script, using mix_install_examples (again, amazing work and resource for the community :heart:) as follows:
# server.exs
# https://github.com/wojtekmach/mix_install_examples/blob/main/plug_cowboy.exs

Mix.install([
  {:plug_cowboy, "~> 2.5"}
])

defmodule Router do
  use Plug.Router
  plug(Plug.Logger)
  plug(:match)
  plug(:dispatch)

  get "/" do
    IO.inspect("Yay")
    send_resp(conn, 200, "Hello, World!")
  end

  match _ do
    send_resp(conn, 404, "not found")
  end
end

plug_cowboy = {Plug.Cowboy, plug: Router, scheme: :http, port: 4000}
require Logger
Logger.info("starting #{inspect(plug_cowboy)}")
{:ok, _} = Supervisor.start_link([plug_cowboy], strategy: :one_for_one)

# unless running from IEx, sleep idenfinitely so we can serve requests
unless IEx.started?() do
  Process.sleep(:infinity)
end

# req.exs
# https://github.com/wojtekmach/mix_install_examples/blob/main/req.exs

Mix.install([
  {:req, "~> 0.3.1"}
])

opts = [retry: :always]

Req.get!("http://localhost:4000/", opts) |> IO.inspect()

Then, we:

run the server: elixir server.exs
run the req to hit the server: elixir req.exs
get the following output:

paulo_notes_hg [main] $ elixir scripts/random/req_why_200_retry/req_why_200_retry.exs

17:14:20.533 [error] retry: got response with status 200, will retry in 1000ms, 3 attempts left

17:14:21.540 [error] retry: got response with status 200, will retry in 2000ms, 2 attempts left

17:14:23.581 [error] retry: got response with status 200, will retry in 4000ms, 1 attempt left
%Req.Response{
  status: 200,
  headers: [
    {"cache-control", "max-age=0, private, must-revalidate"},
    {"content-length", "13"},
    {"date", "Thu, 13 Oct 2022 00:14:26 GMT"},
    {"server", "Cowboy"}
  ],
  body: "Hello, World!",
  private: %{}
}

I guess I misunderstood what [retry: :always] meant. I thought it would retry only if needed. If we got a 200, we would not error and try again. Am I missing something?

Good catch. Looking back not sure what should be the semantics of :always so I will most likely remove it in favor of either more explicit options or leaving this to the user altogether which they can do today via a lambda.
out of curiosity how did you expect this would work?

out of curiosity how did you expect this would work?

We thought it was a "retry until it worked" option. Then we saw retries for 200s and started to look into it more.
I also think we should mention the use-case, it may give more context to you:
We need to retry POST requests. We want exactly what :safe provides, but for POSTs.
When we saw we were not retrying (because of it being a POST) we looked into retry: :always. We actually agreed with the approach of NOT allowing that to happen since POSTs in essence alter data. But, some apis ask for POSTs that are really GETs. GraphQL deals with POSTs as well so maybe that's something to consider like you mentioned above.
Thanks for looking into this!

excellent, that'd be great! We like the default max_retries, but maybe you are seeing something we will likely have to deal with later on and we don't know about it yet 😂
retry: :transient, max_retries: :infinity -> "don't you stop trying till this is done!"

ah, sorry, just to be clear I think a max_retries < :infinity is the way to go.

yes, for sure. We won't use infinity, I just thought it was funny 😂

Would love a built in :transient option that works with e.g. POST


Change error message

Closes #514 by making the error message say the semantic type is not registered instead of saying it does not have a registered format.
Here's the thing about this. This error is being raised when a semantic type does not exist AND when a semantic type does not have a directory format. Currently, there does not seem to be a good way to tell if a semantic type has been registered without a corresponding format.
In other words, the previous error message was lying when the type itself wasn't registered. This one is lying when the type is registered but has no format. There doesn't seem to currently be a good way to distinguish between the two situations. I believe this error message will generally be less confusing in the scenarios where it is likely to be encountered.

@gregcaporaso I pushed a commit changing the error message, but I'm not seeing it here for some reason.


CMake Improve

Hi, thank you for sharing this useful library. This PR simply fixes some minor issues (which I believe are better to be fixed) in CMakeLists.txt. For example,

Paths are fixed (e.g., from src/*.cpp to SMPL++/src/*.cpp)
Unused libraries are removed (e.g., GLEW is linked but never used)

Thanks for your contribution!


Function to reacquire flags (restart server)

Hi,
I've found that when I refresh my compile_commands.json file, which ycmd is using to get the flags for my files, I'm not able to get it to refresh to use the new flags. I run ycmd-clear-compilation-flag-cache, I turn ycmd-mode off and on, I close the file and re-open it, etc. The only thing that seems to work is restarting emacs. Is there some other way to do it? I assume that restarting the server would do it; I think that ycmd exposes such a command in vim, but it is not available seemingly in emacs.
Cheers.

If you do M-x ycmd-open when the server is running, then the server gets restarted. The file is after that unparsed, you can see the ? next to ycmd in the mode-line. So you need to M-x ycmd-parse-buffer to reparse.

@ptrv Cool, thanks.  I'll close for now and re-open only if this doesn't work. Thanks again!


Firebase web goes offline when using Cordova Plugin Firebase together

Hi guys,
I'm experiencing a little disconcerting problem. We have a web app working with firebase web and when
we tried to integrate with Cordova Plugin Firebase, the moment that cordova initializes and we get the token for notifications our firebase connection goes offline. When we force the app to go to background it's connection status goes online and when we get it to foreground again it goes to offline... pretty wierd.
Someone had something like this before?
How can we solve this?
Thanks,
Juan.

With Firebase Web - do you mean the firebase-js-sdk?
i think i am facing the same issue. happy if someone could help :)

what do you use from the web sdk that is not available though the plugin? its probably not a good idea to use both sdk's at the same time. the best solution would be to integrate any missing features into this plugin so that you don't need to use both.

Hey,
just wanted to mention that I am also using both with version 0.1.9 of this plugin and never faced this issue.
I am using the push-stuff of the plugin and auth + db from the js-sdk.

@robertarnesson We need all the commands for the realtime-database...
Im not sure if im experiencing the same issue but logging events dont work at my device so i think so :)

@robertarnesson I'm using all the database and auth part, my app is a webapp that can be used also embeded in cordova so I cannot use all native cordova stuff.

Chiming in here, setting our app up for the first time. Our app is a web + Android + iOS app, and it looks like this plugin breaks / doesn't work on web?
Can we please fix that / make this work on web too? Not too thrilled about having to deal with multiple firebase libraries (I'm sure nobody here is), and it seems like a pretty straightforward fix - have the Android / iOS specific functions (like notifications) become stubs / empty functions when not available. Could even have the use pass in a param on initialization or run a special function (ie FirebasePlugin.disableNativeFunctionality()), would still be much better than trying to work with two plugins

closing for cleanup, please re-open if this is still an issue


Does not take into account bit depth and channel numbers

To measure how many bytes are in x milliseconds for an audio sample you must take into account the bit depth and number of channels. For example, to find n bytes in x milliseconds this is what I do
long bytes_per_second(int sample_rate, int8_t bit_depth, int8_t channels) {
    auto byte_depth = bit_depth / 8;

    return sample_rate * channels * byte_depth;
}

auto bytes_per_second = bytes_per_second(sample_rate, bit_depth, channels);
auto bytes_per_millisecond = bps / 1000;
auto bytes_per_chunk = bytes_per_millisecond * // 10, 20 or 30 milliseconds;

For 10 milliseconds of bytes of an 8000 sample rate this could be 80 bytes or 160 bytes for 16 bits or 160 bytes for 8 bits but 2 channels etc. Currently fvad_process only accepts 80 bytes for 8000 and 10 milliseconds. Does the WebRTC vad place these limitations?
Also, would it hurt the WebRTC's vad accuracy if I gave it bytes within the in-between range of 10 - 20 - 30 milliseconds? Like 11 or 24 milliseconds worth of bytes? This is a problem for me because I end up with left over bytes that don't fit neatly into 10,20,30.
So I was hoping I could redistribute the byte sets to include 1 more byte per chunk that will help use up the remainder bytes. Hope this makes sense given 18 bytes / 4 chunk_size = 4 bytes per chunk with remainder of 2 bytes solution could be to use 5 bytes per chunk for the first 10 bytes and then 4 byte chunks for the remaining 8 bytes

The VAD engine internally works only with these fixed chunk sizes and only with 16-bit single-channel audio.
If you have samples in a different range, just multiply them with a factor so they end up in the 16-bit range, i.e. -32768 to 32767. If you have multi-channel-audio, you could just average the samples from all channels into one.
If your audio data isn't a multiple of 10/20/30 ms, either just drop the last rest at the end (maybe assume the detection result is the same as the last complete chunk before it), or fill up the last chunk with zeros.
(may I'll add this to the README...)

Currently fvad_process only accepts 80 bytes

80 is actually the number of 16-bit samples, not bytes, for a 10ms chunk at 8000Hz sample rate.


Brand installer w/ new images

need the product.img/setup.img for anaconda to swap out pixmaps and provide an overall pretty experience.

@peasead will provide the images

Done and done.
https://github.com/rocknsm/SimpleRock/commit/10dd0f80bc981a742ee654b549520077ac6aaf91

anaconda still needs to be done. Reopening.


⚠ Bofrost.be has degraded performance

In 6599a55, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1988 ms

Resolved: Bofrost.be performance has improved in 648e846 after 14 minutes.


feat(2023-02-21): updated the sdk as per the api spec released on 2023-02-21

NEW FEATURES

Datapath in LoadBalancers
LoadBalancerLoggingDatapathPatch
Clones for Snapshot
Clones for BackupPolicyPlan
IPVersion in NetworkACLRulePrototype
TrustedPlatformModule support for Baremetal servers
EnableSecureBoot support for Baremetal server
Protocol, ResponseHopLimit in InstanceMetadataService,  InstanceMetadataServicePatch, InstanceMetadataServicePrototype

BREAKING CHANGES

LoadBalancerLogging -> LoadBalancerLoggingPrototype
InstanceAvailabilityPrototype availabilityPolicy -> InstanceAvailabilityPolicyPrototype availabilityPolicy

CHANGES

None

BUG FIXES

None

updating of copyright message

:tada: This PR is included in version 0.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update to Metrics 2.0

Updates to SwiftMetrics 2.0 which adds a new case the TimeUnit enum (#88, fixes #87)

These changes are now available in 1.0.0-rc.1.2


Profile with extensions only doesn't have its extensions synced

Testing #188613
I have a partial profile called "blank" that only has extensions synced. However, it doesn't appear to sync correctly (from the left window to right window)

Synced data:

Profile seems to be synced correctly for me. Can you please check in the right window in the extensions view if the extension is installed? Also check if the settings are using default profile?

Followed the same steps and could not reproduce. Can you please share the settings sync logs while you reproduce the issue again?

Here's a video of me getting into that state with logs visible:
https://github.com/microsoft/vscode/assets/2230985/b851fc12-cb08-4fe7-b8e0-5cd1513fc791

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Show the "Format" field

?nasaweather::atmos is missing the most important information, in the Format field. This was an issue in the first chapter of the R Markdown course which suggests looking at ?atmos through the web interface that uses RDocumentation.
Not sure if this is the right place to put this. The two websites (Datacamp and RDocumentation) have no links for contact or feedback.

Thanks for reporting @franknarf1, you are indeed in the right place for this.
The Format section should indeed be part of this page, as you mentioned, we'll look into it

The Format section is now part of the documentation:
https://www.rdocumentation.org/packages/nasaweather/versions/0.1/topics/atmos


Development container definition for Elm (0.19.0)

I wanted to try out Elm and had to install the binaries to my computer (bummer 🤔), so I decided to make this container definition instead 😏.
As of now, there is not vscode debugger for Elm yet, which is why the Readme guides developers to run the cli command directly to start the samples.
This definition is based on debian and includes both the Elm (0.19.0) binaries as well as the Elm VS Code extension.
The test project files were taken directly from the official Elm Architecture Tutorial.

Oops! Missed you'd done some commits to address the feedback.  LGTM! Merging.

Oops! Missed you'd done some commits to address the feedback. LGTM! Merging.

Just noticed that you had merged the PR without me making the appropriate changes (LICENSE still there). I will create a simple hello-world sample of my own and remove the licensing & other files to comply with your distribution. Will reference this in the upcoming PR.
Sorry about that @Chuxel


Complete [Widget] style methods

[x] boxShadow
[x] backgroundImage
[x] backgroundBlur
[x] backgroundBlendMode (?)
[x] linearGradient
[x] radialGradient
[x] sweepGradient
[ ] overflow
[x] scrollable
...

overflow will be considered later


Data Model Revision

Strategies may be attached to trades, positions, and dividends via a join table

A ManyToMany relationship between trading entities and strategies could make the database update process more straightforward. However, it may complicate the data quering


:sparkles: Increase bundle timeouts to 15 mins

Merging to see if this help before US workday starts.


Leverage new project scaffolding for management-plane new service onboarding

For management-plane new service onboarding, we should leverage new project scaffolding instead of template.
To be consistent with the behavior of DPG new service onboarding.
When this is ready, we should update https://eng.ms/docs/products/azure-developer-experience/develop/sdk-generate-mgmt-dotnet accordingly.

---high priority item

[ ]  xxx.Samples.csproj not generated and  not included in .sln
[ ]  assets.json not generated
[ ]  <PackageId>Azure.ResourceManager.xxx</PackageId> not generated in Azure.ResourceManager.xxx.csproj
[ ]  tests/xxxManagementTestBase.cs  and /tests/xxxManagementTestEnvironment.cs not generated

--low priority item

[ ]  difference: <Description> xxx.</Description> in Azure.ResourceManager.xxx.csproj
[ ]  difference: <PackageTags>xxxx</PackageTags> in Azure.ResourceManager.xxx.csproj
[ ]  difference: [assembly:Azure.Core.AzureResourceProviderNamespace("Microsoft.Template")] in  Azure.ResourceManager.xxx.csproj
[ ] redundant: <TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks> in Azure.ResourceManager.xxx.csproj
[ ] redundant: <IncludeOperationsSharedSource>true</IncludeOperationsSharedSource> in Azure.ResourceManager.xxx.csproj
[ ] redundant: additionalDirectories in tsp-location.yaml
[ ] redundant:
$(RequiredTargetFrameworks)
$(NoWarn);CS1591
  in Azure.ResourceManager.xxx.Tests.csproj

https://github.com/Azure/autorest.csharp/pull/5167


"Pucheni" is listed in the drop-down menu

Description:
"Pucheni" is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Type "Pucheni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Pucheni, DÂMBOVIȚA".


Go version upgrade script should not ignore patch version

This came up as part of #5837, specifically in the docker/debug/Dockerfile https://github.com/jaegertracing/jaeger/pull/5837/files#diff-ab8e812479730d5975aa87291a563e1dc0e0cf03c790d5d126c54f4248b3820bR4
When scripts/check-go-version.sh is run it only preforms substitution of major.minor versions, which resulted in golang:1.22.6-alpine becoming golang:1.23.6-alpine - a non-existent version at this time. In the other places it replaces versions like 1.22.x, where substitution works fine, but when the patch version is explicitly specified the script should probably just fail and let us update the files manually.

Do we have to be assigned to get the issue or just create a PR if it can be resolved?


Do not use else after a return in an if clause

Also use string literals.

don't merge this until we know why tsc is failing.

:shipit:


Add link to HARMONY video/slides to help

https://www.youtube.com/watch?v=h0SCn0ZDqq8
https://drive.google.com/file/d/1Q0X6GNQlT5PfZOcBNVu1B92SSAxJWrnS/view?usp=sharing
https://biosimulators.org/help
https://run.biosimulations.org/help

Done


Change to add sha option at getCommit method.

I tried to get commit comment and called getCommits method such as below snipets.
Github = require 'github-api'
github = new Github(
  token: MY_GITHUB_TOKEN,
  auth: 'oauth'
)
commit = github.getCommits(
  sha: ONE_COMMIT_HASH,
  (err, commits) ->
    console.log(commits.length)
)

But got commits aren't single commits...
And I've read github API documentation and found below article!

GET /repos/:owner/:repo/commits/:sha

FYI: https://developer.github.com/v3/repos/commits/#get-a-single-commit

I think you may be missing a slash on that, though I haven't specifically checked it yet. Could you please write a unit test and update the README with your change, then rebase your commits? Thanks!

Oh, which slash is your said?
OK, I'll call again after updating unit test and README. Thanks!

Closed in error; reopening.

Sorry for my neglecting...
This API calling seems to get correctly specified repository sha1 commit hashes. So, I'll close it.


Qt4 migration

migrating qt3 to qt4

Can this commit history be cleaned up a bit before merging?  You don't have to squash it into a single commit but try and merge some of these commits together into a single logical change set for each commit record that has a meaningful message describing the change.


fix(SegRendering): preserve canvas transform matrix after seg render

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR contains a bug fix.

What is the current behavior? (You can also link to an open issue here)
The current behavior is that my overlay (rendered using the Overlay Tool) is getting resized and translated once the segmentation is rendered.

Note that the text is not even entirely on the screen, also there are two ellipsis that aren't even being shown, they appear on the screenshot below.

What is the new behavior (if this is a feature change)?
Now my overlay is not being resized nor translated and renders on the position where I expected it to be, also the segmentation kept working fine.

Now we can see that the text is well positioned and that the ellipsis are in the right place.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
This PR shoudn't introduce any breaking change.

Other information:
Previously after rendering the segmentation cornerstone was always transforming the canvas to follow the identity matrix, but in cases where we had an overlay using a different transformation matrix, it would undesirably affect the original overlay.
Also did some minor refactorings on the renderFill function of the src/eventListeners/internals/renderSegmentationFill.js file.

LGTM 🏅

:tada: This PR is included in version 6.0.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CNDB-8538 (legacy): Fix PendingRangesCalculatorService

Discussed with @jtgrabowski and decided not to port it to cc-migration-release


chore(UI):move new RWD to top for ES

Checklist:

[X] I have read freeCodeCamp's contribution
guidelines.
[X] My pull request has a descriptive title (not a vague title like Update  index.md)
[X] My pull request targets the main branch of freeCodeCamp.
[ ] I have tested these changes either locally on my machine, or GitPod.

@moT01 Thanks for adding the changes needed

BTW do we have these steps recorded somewhere for reference, like Language lead handbook?

We don't really have anything specific for when a new superblock is finished being proofread and how to move it into place. We have this for when a new language gets added, which includes some information about that superOrder object.

Thanks @moT01, I did check the docs, but missed that portion. This is helpful


Fixed UI-Bugs

PR Fixes:

1 FIxed UI bugs
2 Improved Video Chapters
3 Fixed Readme
4 Added keyboard shortcut to access search
5 Added global search within course (referred @ItsFlash10's code)
6 Added dynamic metadata to courses

Resolves Almost all the ui related issues
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue

@devsargam @hkirat please have a look at this. Fixes a lot (almost all) of the ui related bugs/issues...

sir is this the expected behaviour ? i guess it is supposed to slightly more width than this ?
https://github.com/user-attachments/assets/d26b3cd0-29be-465c-b51e-942cf09d326c

Hey @amanbairagi30, thanks for pointing that out! That page was in a previous PR, will fix it now.

Added to things to review :)

@keshav-exe #1176 also has search API changes, you can either bring it here or we can get it merged separately. Works both ways.
PS: Let it get merged separately [Want the increased contribution count lol]xD
cc: @devsargam

@keshav-exe Bhai next try to split changes in different PR's as its much easier to go through and if something happens we can roll back quickly for each functionality and not whole PR

@keshav-exe also if you can provide before/after video

@keshav-exe Sir, please provide before after video otherwise will close the PR in five days/

@siinghd sorry I just saw this, will doing before and after right away!

@keshav-exe Bhai next try to split changes in different PR's as its much easier to go through and if something happens we can roll back quickly for each functionality and not whole PR

noted bhai🫡

Hey @keshav-exe, can you make more atomic small changes in a pr. Also there are merge conflicts here. Closing for now. Feel free to open small but many


Set up with Heroku

@MaxWofford: Is this good to merge?
Not sure what the current status of surrogate.

@paked: No progress in getting it working since last update. The dyno will randomly take longer than 60 seconds to restart.

Repo has been merged with hackclub/proxy (only available to @hackclub/staff) and will not be deployed to Heroku due to requirement of serving SSL traffic on multiple domains.


Adjust the OpenShift Resources to make up for the new PDF webservice

Reduce the other component resources to make up for the new PDF web service on all environments.
Useful link: https://docs.developer.gov.bc.ca/request-quota-increase-for-openshift-project-set/

All the analytics-related web services were reduced to CPU limit of 100
The document web service CPU limit was increased to 1400

I am verifying that forms-flow-documents are working on DEV and TEST.


How to set custom location for each user.

Hi Jasekz.
In my project, I want to give a different location for each user. I know it is easy with dropzone. In Laradrop there is no option for it. Give me a clue to fix this.
Thank you!

Hi @uisuru ,
What do you mean by 'location'?

Hi @jasekz,
The path that store uploaded files.

The filepath as well as the storage engine can be set in the .env file - see https://github.com/jasekz/laradrop#configuration-env , specifically, the LARADROP_DISK_PUBLIC_URL definition.
If you need to dynamically determine the location, you can do so by either overriding the Laradrop controller or listening for the Jasekz\Laradrop\Events\FileWasUploaded event, which provides all data about the uploaded file and allows you to execute your own actions based on business logic as needed.
Hope that answers your question, but let me know if it does not.

Just wanted to check in on this, @uisuru;  let me know if you're able to do what you need.

I go throw following issues but no luck. Try to override but it does not work for me.
https://github.com/jasekz/laradrop/issues/13
https://github.com/jasekz/laradrop/issues/4
If you have any idea give me a clue.
Thank you.


Name Autocorrect

As it is close to the deadline, I will be bypassing branch protections. @saiutkarsh33 I have created issues based on the issues I raised in this PR.


File location for temporary file in remove_empty_variables

When using remove_empty_variables.main and specifying just a file name with no location, e.g. remove_empty_variables.main('ncas-aws-10_iao_20221117_surface-met_v1.0.nc'), the function attempts to create the temporary file in the root directory of the computer. This can be bypassed by specifying the file location as ./ncas-aws-10... when referring to the current directory, with the tmp file being written into the current directory; this is the desired behaviour

Fixed with commit a9195c0, should be included in version 2.0.1


middleware/etcd: stub zones

Multiple zones are easy with etcd in CoreDNS, but stubzones make it somewhat complicated, as the same information may be configured twice. What if we only checked stubzones for the first zone configured in the etcd config. This would simplify some bits and also does not allow conflicting stuff in etcd.
The only thing we do need, is checking if the stubzone isn't one of the configured zones - but I believe that code is already there.
Oh, and tests.

Yes, it is. Added bunch of units tests. Only needs integration tests #100

Also test: external lookup of a CNAME and CNAME to points to a name inside etcd, but for another zone.


Substitutions in dictionaries config

This is for https://github.com/yandex/ClickHouse/issues/940
I've changed ExternalLoader so it uses ConfigProcessor now and can handle the substitutions.
There is one trouble: for ConfigProcessor to understand custom includes file location the config has to have "yandex/include_from" element. This is not the case for <dictionaries><dictionary>...</dictionary></dictionaries> so <include_from> does not work there. The workaround is to use <yandex><dictionary></dictionary></yandex> as the dictionary config format. That is also a bit more consistent with config.xml and users.xml so I preferred not to introduce more complexity in ConfigPaser with an additional "root element" parameter and changed the docs instead.
Existing dicts configuration works without any changes since the name of the root element is irrelevant for the ExternalLoader.
P.S. There is a config library that has all this merging and loading logic and is generally more human-friendly. We may think of migrating to it sometime later https://github.com/puppetlabs/cpp-hocon

Perfect!
BTW, why "Submodule poco updated 265 files"? Probably by accident. I can merge and update it back to the last commit.

There is a config library that has all this merging and loading logic and is generally more human-friendly. We may think of migrating to it sometime later https://github.com/puppetlabs/cpp-hocon

I hear about HOCON for second time (or for the first time, as I almost forgot it).
We already have request to add support for YAML (in addition to XML, keeping all semantics).
This is low priority task.

BTW, why "Submodule poco updated 265 files"
no idea... I changed nothing there.

HOCON is more convenient than XML and definitely more clear than YAML. We use it as the default config format in our newest systems. It came from Scala world and is probably less known for this reason. Anyway it's just kind of sugar since current configs are pretty clear.


TAJO-1573: Fix addColumn bug (fieldsByName should maintain a list per a simple field name)

addColumn function is fixed. getNaturalJoinCondition, verifyProjectedFields, verifyIfTargetsCanBeEvaluated functions are changed together.

Test cases are also missed in this patch.


Identifier Activity Analysis Dispatch

Please check all that apply:

[x] New playbook
[ ] Bugfix
[ ] Feature add
[ ] Code style update (formatting, renaming)
[ ] Documentation
[ ] Other (please describe):

Release Notes
Replace the following list with release notes that describe the high level components of the PR:

[x]  new file:   playbooks/Identifier_Activity_Analysis_Dispatch.json
[x]  new file:   playbooks/Identifier_Activity_Analysis_Dispatch.png
[x]  new file:   playbooks/Identifier_Activity_Analysis_Dispatch.py
[x]  new file:   playbooks/Identifier_Activity_Analysis_Dispatch.yml

Playbook quality checklist
Please check if your PR fulfills the following requirements.
Requirements for Settings

[x] Playbook name is A-Z in Title case with underscores between words. (e.g. MS_Graph_Search_and_Purge)
[x] Category in Title case with spaces between words (e.g. Identifier Reputation Analysis)
[x] Description is free of grammatical errors and describe what the playbook does.
[x] Notes list any setup required on the third-party API as well as intended areas for customization.
[x] Label is set to '*'

Requirements for all playbooks

[X] Playbook block count not greater than 15 (not including Start and End blocks).
[X] No more than 3 branching paths.
[ ] If referencing a custom list, Notes document what the expected values are in that custom list.

Requirements for all playbook blocks

[x] All blocks have a custom name no more than 4 words, all lowercase, and separated by space (e.g. close workbook task)
[x] All blocks that support a Notes Tooltip have it filled out. Must be grammatically correct and describes the intended purpose of that block.
[ ] Where custom code is used, block notes indicate presence of custom code (e.g. "This block uses custom code")
[x] No block is disabled by custom code
[x] Custom code is documented with notes

Requirements for specific blocks
Action

[ ] Use apps available on Splunkbase
[ ] Use asset names that are the app name, all lowercase separated by underscores (e.g. Azure AD Graph becomes azure_ad_graph)

Utility

[x] Block is using community version

Playbook

[X] Block is using local version

Requirements for specific playbooks
Other considerations (PR type specific)

[x] If new playbook, there is a screenshot ending in .png with the same name as the playbook .json
[x] Playbook major minor version matches repo (e.g. 5.5 != 6.0)
[x] PR contains both .py and .json

Thanks for contributing!

Missing D3fend tag D3-IAA
Format block should be an aggregate of all child playbook reports.
Current:

Desired:

RE: merge_reports action for the markdown notes:
Because the dispatch_playbooks portion returns fully formatted tables from each of the inputs, including headers, merging them should be just a matter of looping over each one and including white space at the bottom of each loop to allow for separation. I don't think we need to duplicate the work done in the input playbook here?


TCK-CPP: Implement AccountUpdateTransaction JSON-RPC Endpoint

Problem
AccountUpdateTransaction  test isn't covered by the TCK-CPP server.
Solution
We should implement JSON-RPC methods (endpoints) for AccountUpdateTransaction  for the TCK-CPP server.
Alternatives
No response

Duplicate of #702. Closing


Extract TestExtras into dedicated target

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.56%. Comparing base (8450205) to head (87a8383).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage   97.56%   97.56%
=======================================
  Files          14       14
  Lines         328      328
=======================================
  Hits          320      320
  Misses          8        8

Flag
Coverage Δ

unittests
97.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add consumer endpoint for fetching hints

This change is

Connects #141

v2/pkg/consumer/consumer.proto, line 254 at r2 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
nit: wrap comments to 80 chars.
This should also have a response protocol.Header, like other Response message types.
Also, what do you think about separating primary_hints from repeated backup_hints? See also https://github.com/jgraettinger/gazette/blob/expose-etcd/v2/pkg/consumer/shard_spec_extensions.go#L120

I just installed an editor extension to make sure my comments are the correct number of lines.
I didnt add the header because the request did not need to be proxied. But if I am going to add it to the response I suppose I should also add it as an optional parameter to the request?
I am onboard for separating hints once we land your PR.

v2/pkg/consumer/shard_api.go, line 160 at r2 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
The list of hint keys is going away (in favor of a key /prefix and integer number of backups to keep).
Key names will then have really obvious & fixed names (/prefix/shard-id.primary, /prefix/shard-id.backup.0, /prefix/shard-id.backup.1, etc). I think it'll be trivial to match them up.

Sounds good.

v2/pkg/consumer/shard_api.go, line 156 at r2 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
git.liveramp.net/arbortech/go's readme has a more extensive write-up on style, but:

Prefer var where allowed over :=. var makes it obvious to the reader that all variables are being declared & not re-assigned. If a variable is being intentionally shadowed, use of var makes this obvious and compiler-enforced.
If var wouldn't compile because one of the variables is being re-assigned, then use :=. But it's not necessary to re-mix code just to avoid :=.

In other words, usages of := should indicate to the reader that there's an actual re-assignment of at least one variable happening within the statement.

:+1:

v2/pkg/consumer/lifecycle.go, line 261 at r3 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
^ still here

forgot to push my local commit :(

v2/pkg/consumer/shard_api.go, line 156 at r3 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
how about:
ks.Mu.RLock()
var item, ok = allocator.LookupItem(...)
ks.Mu.RUnlock()

then you can dispense with the defer. |item| is by-value and cannot change underneath you.

Good call. This was a copy paste from the resolver but this is much better.

v2/pkg/consumer/lifecycle.go, line 230 at r3 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
nit: this is pretty awkward.
What this is smelling like to me, is that fetchHints should return a POD struct with the spec / TxnResponse / FSMHints.
Then, fetchBestHints can become pickBestHints (or pickFirstHints? what is "best"?), operating over that struct.

The more I look at it I see what you are talking about with the overlap between this function and pickFirstHints. I am not familiar with the POD pattern but I googled it and I think I know what you are going for, I will throw something up just let me know if I am missing the make.

v2/pkg/consumer/lifecycle.go, line 230 at r3 (raw file):
Previously, jskelcy (Jake Skelcy) wrote…
The more I look at it I see what you are talking about with the overlap between this function and pickFirstHints. I am not familiar with the POD pattern but I googled it and I think I know what you are going for, I will throw something up just let me know if I am missing the make.

Let me know if this is what you had in mind.

a discussion (no related file):
I am going to suggest there be no more movement on this change until #151 is landed


Add optional skipProviderCheck field to chain schema

Allows addition of chains that don't support dAPIs. Closes #153.
I tested this by:

changing the default rpcUrl to nonsense for arbitrum-goerli-testnet.json, running yarn generate:chains and confirming that an error was returned when running export CHAIN=arbitrum-goerli-testnet; yarn providers:ping
then I added "skipProviderCheck": true, reran yarn generate:chains, and the ping command passed

CI docs failure addressed in #156.


fix git mistake by making a PR we can ignore, sigh

Now we ignore this and close this branch for good.


morphio::Morphology supports serialization through pickle

https://pybind11.readthedocs.io/en/stable/advanced/classes.html#pickling-support
This is a simplistic attempt at supporting Pickle.
The serialization simply returns a string with the NeuroLucida representation of
the morphology.
A new morphio::Morphology ctor that takes a stringstream argument has been
added. It is used for the deserialization.

@mgeplf I've added you mainly for the design. @st4rl3ss mainly for the C++
The rationale behind this PR is that I need the Morphology class to support pickling to rebase NeuroM v2. Indeed, we've recently added some multiprocessing features to NeuroM (https://github.com/BlueBrain/NeuroM/commit/4f01b4cabee1f469bd5f7313c0efbc9854dedf27) and now I can't rebase mut_morphio branch of NeuroM on top of master.


added testing for Python 3.9, which is currently beta

:grey_exclamation: Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

Expand to view the summary

Build stats

Build Cause: [Pull request #864 opened]

Reason: Aborted from #2

Start Time: 2020-06-18T09:54:28.058+0000

Duration: 5 min 42 sec

Commit: bd6bfaaca54f7fbab16d0b464ebff82ae2d8fd96

Steps errors
Expand to view the steps failures

Name: Restore files previously stashed

Description: coverage-python-2.7-none

Duration: 0 min 0 sec

Start Time: 2020-06-18T09:59:08.443+0000

log

Log output
Expand to view the last 100 lines of log output

[2020-06-18T09:58:41.033Z] Still waiting to schedule task
[2020-06-18T09:58:41.034Z] Waiting for next available executor on ‘linux&&immutable’
[2020-06-18T09:58:41.049Z] Still waiting to schedule task
[2020-06-18T09:58:41.050Z] Waiting for next available executor on ‘linux&&immutable’
[2020-06-18T09:58:41.065Z] Still waiting to schedule task
[2020-06-18T09:58:41.066Z] Waiting for next available executor on ‘linux&&immutable’
[2020-06-18T09:58:41.084Z] Still waiting to schedule task
[2020-06-18T09:58:41.084Z] Waiting for next available executor on ‘linux&&immutable’
[2020-06-18T09:58:41.101Z] Still waiting to schedule task
[2020-06-18T09:58:41.101Z] Waiting for next available executor on ‘linux&&immutable’
[2020-06-18T09:58:41.117Z] Still waiting to schedule task
[2020-06-18T09:58:41.117Z] Waiting for next available executor on ‘linux&&immutable’
[2020-06-18T09:58:41.186Z] Still waiting to schedule task
[2020-06-18T09:58:41.186Z] There are no nodes with the label ‘windows-2019-docker-immutable’
[2020-06-18T09:58:41.215Z] Still waiting to schedule task
[2020-06-18T09:58:41.215Z] There are no nodes with the label ‘windows-2019-docker-immutable’
[2020-06-18T09:58:41.244Z] Still waiting to schedule task
[2020-06-18T09:58:41.244Z] There are no nodes with the label ‘windows-2019-docker-immutable’
[2020-06-18T09:58:41.271Z] Still waiting to schedule task
[2020-06-18T09:58:41.272Z] There are no nodes with the label ‘windows-2019-docker-immutable’
[2020-06-18T09:58:41.301Z] Still waiting to schedule task
[2020-06-18T09:58:41.301Z] There are no nodes with the label ‘windows-2019-docker-immutable’
[2020-06-18T09:59:00.452Z] Failed in branch Python-python-2.7-1
[2020-06-18T09:59:00.461Z] Failed in branch Python-python-2.7-2
[2020-06-18T09:59:00.470Z] Failed in branch Python-python-2.7-3
[2020-06-18T09:59:00.482Z] Failed in branch Python-python-2.7-4
[2020-06-18T09:59:00.492Z] Failed in branch Python-python-2.7-0
[2020-06-18T09:59:00.500Z] Failed in branch Python-python-3.5-1
[2020-06-18T09:59:00.510Z] Failed in branch Python-python-3.5-2
[2020-06-18T09:59:00.519Z] Failed in branch Python-python-3.5-3
[2020-06-18T09:59:00.528Z] Failed in branch Python-python-3.5-4
[2020-06-18T09:59:00.538Z] Failed in branch Python-python-3.5-0
[2020-06-18T09:59:00.547Z] Failed in branch Python-python-3.6-1
[2020-06-18T09:59:00.556Z] Failed in branch Python-python-3.6-2
[2020-06-18T09:59:00.565Z] Failed in branch Python-python-3.6-3
[2020-06-18T09:59:00.574Z] Failed in branch Python-python-3.6-4
[2020-06-18T09:59:00.584Z] Failed in branch Python-python-3.6-0
[2020-06-18T09:59:00.594Z] Failed in branch Python-python-3.7-1
[2020-06-18T09:59:00.603Z] Failed in branch Python-python-3.7-2
[2020-06-18T09:59:00.613Z] Failed in branch Python-python-3.7-3
[2020-06-18T09:59:00.623Z] Failed in branch Python-python-3.7-4
[2020-06-18T09:59:00.638Z] Failed in branch Python-python-3.7-0
[2020-06-18T09:59:00.649Z] Failed in branch Python-python-3.8-1
[2020-06-18T09:59:00.659Z] Failed in branch Python-python-3.8-2
[2020-06-18T09:59:00.668Z] Failed in branch Python-python-3.8-3
[2020-06-18T09:59:00.678Z] Failed in branch Python-python-3.8-4
[2020-06-18T09:59:00.687Z] Failed in branch Python-python-3.8-0
[2020-06-18T09:59:00.698Z] Failed in branch Python-python-3.9-rc-1
[2020-06-18T09:59:00.709Z] Failed in branch Python-python-3.9-rc-2
[2020-06-18T09:59:00.719Z] Failed in branch Python-python-3.9-rc-3
[2020-06-18T09:59:00.728Z] Failed in branch Python-python-3.9-rc-4
[2020-06-18T09:59:00.738Z] Failed in branch Python-python-3.9-rc-0
[2020-06-18T09:59:00.747Z] Failed in branch Python-pypy-2-1
[2020-06-18T09:59:00.758Z] Failed in branch Python-pypy-2-2
[2020-06-18T09:59:00.768Z] Failed in branch Python-pypy-2-3
[2020-06-18T09:59:00.777Z] Failed in branch Python-pypy-2-4
[2020-06-18T09:59:00.786Z] Failed in branch Python-pypy-2-0
[2020-06-18T09:59:00.795Z] Failed in branch Python-pypy-3-1
[2020-06-18T09:59:00.805Z] Failed in branch Python-pypy-3-2
[2020-06-18T09:59:00.815Z] Failed in branch Python-pypy-3-3
[2020-06-18T09:59:00.824Z] Failed in branch Python-pypy-3-4
[2020-06-18T09:59:00.834Z] Failed in branch Python-pypy-3-0
[2020-06-18T09:59:00.845Z] Failed in branch windows-2.7-none
[2020-06-18T09:59:00.856Z] Failed in branch windows-3.5-none
[2020-06-18T09:59:00.867Z] Failed in branch windows-3.6-none
[2020-06-18T09:59:00.878Z] Failed in branch windows-3.7-none
[2020-06-18T09:59:00.889Z] Failed in branch windows-3.8-none
[2020-06-18T09:59:05.690Z] Post stage
[2020-06-18T09:59:06.001Z] + pip3 install --user coverage
[2020-06-18T09:59:07.394Z] Collecting coverage
[2020-06-18T09:59:07.969Z]   Downloading https://files.pythonhosted.org/packages/2a/3e/fc18ecef69f174c13493576f46966053c1da07fd8721962530dc1a10b1ca/coverage-5.1-cp36-cp36m-manylinux1_x86_64.whl (227kB)
[2020-06-18T09:59:08.235Z] Installing collected packages: coverage
[2020-06-18T09:59:08.235Z] Successfully installed coverage-5.1
[2020-06-18T09:59:08.267Z] Running in /var/lib/jenkins/workspace/thon_apm-agent-python-mbp_PR-864/src/github.com/elastic/apm-agent-python
[2020-06-18T09:59:08.534Z] Error when executing always post condition:
[2020-06-18T09:59:08.535Z] hudson.AbortException: No such saved stash ‘coverage-python-2.7-none’
[2020-06-18T09:59:08.535Z] 	at org.jenkinsci.plugins.workflow.flow.StashManager.unstash(StashManager.java:159)
[2020-06-18T09:59:08.535Z] 	at org.jenkinsci.plugins.workflow.support.steps.stash.UnstashStep$Execution.run(UnstashStep.java:76)
[2020-06-18T09:59:08.535Z] 	at org.jenkinsci.plugins.workflow.support.steps.stash.UnstashStep$Execution.run(UnstashStep.java:63)
[2020-06-18T09:59:08.535Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
[2020-06-18T09:59:08.535Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[2020-06-18T09:59:08.535Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[2020-06-18T09:59:08.535Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2020-06-18T09:59:08.535Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2020-06-18T09:59:08.535Z] 	at java.lang.Thread.run(Thread.java:748)
[2020-06-18T09:59:08.535Z]
[2020-06-18T09:59:08.642Z] Stage "Building packages" skipped due to earlier failure(s)
[2020-06-18T09:59:08.739Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-06-18T09:59:08.834Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2020-06-18T09:59:08.935Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2020-06-18T09:59:08.985Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2020-06-18T09:59:09.084Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2020-06-18T09:59:09.178Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2020-06-18T09:59:09.542Z] Running on Jenkins in /var/lib/jenkins/workspace/thon_apm-agent-python-mbp_PR-864
[2020-06-18T09:59:09.720Z] [INFO] getVaultSecret: Getting secrets
[2020-06-18T09:59:09.802Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-06-18T09:59:10.721Z] + chmod 755 generate-build-data.sh
[2020-06-18T09:59:10.721Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-864/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-864/runs/1 ABORTED 282391
[2020-06-18T09:59:11.271Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-864/runs/1/steps/?limit=10000 -o steps-info.json
[2020-06-18T09:59:11.522Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-864/runs/1/tests/?status=FAILED -o tests-errors.json


feat(split): use configuration-observability-oss, removed xService

Description of your changes

use configuration-observability-oss
use configuration-gitops-flux
removed xService

Fixes #114
I have:

[x] Read and followed Upbound's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[x] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested
--- PASS: kuttl (2382.59s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (2382.10s)
PASS
15:06:02 [ OK ] running automated tests

/test-examples


[9.x] New frequencies

This PR adds new scheduling options:

a new everyEightHours frequency
new everyXHoursAt frequencies, enabling to set the minute offset in the hour for all everyXHours frequencies.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


"requireDestinationTag=true" is set, but is it possible to transmit without a tag?

I created an address on testnet.
Then I made it "requireDestinationTag=true".
So what I'm curious about here is
Is it no longer possible to send coins to this address without a destination tag?
I sent it without a tag...and it was sent...
As far as I know, after setting “requireDestinationTag=true”,
I know it can't be sent without a tag, but it can be sent.
Why is this happening?

Documentation is at https://xrpl.org/payment.html.

Check to make sure that you've actually enabled the account's RequireDest flag.

@intelliot
Thank you for your kind reply.
yes I will tell you the address.
"rHs1GC7kDW27zCYGWAkZXggfHtv9UHJdhJ" is the address...
I confirmed that "requireDestinationTag=true" with the getAccountInfo RPC.
Why is it sent well without tags?

@intelliot
oh!! I made a big mistake...
When I checked tx_json,
I kept sending destination_tag as "0".
Solved. thank you


Princess Luna: Watch gumroad.com

Princess Luna requests the watch of the watch_keyword gumroad\.com. See the Metasmoke search here and the Stack Exchange search here.

gumroad\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

!!/approve

Coverage remained the same at 65.087% when pulling 6466e75cece36d7bb531afb339ab4aed9fa86e7c on auto-blacklist-1523903188.9308827 into 49dc35910499e2bd2ef49a50dbfe352ae9ca15be on master.


Navigation to Target Causes Superfluous Line Selection at Target

Double clicking an address to navigation in linear view is the easiest way to repro. Occasionally, and often after navigating to target, many extra lines will be selected, obfuscating the actual target.

Fixed in 2.4.2974-dev.


Make path-parser replaceable with other library

Hi @troch
path-parser has very limited functionality.
It would be nice to make it replaceable using some config option.
Also it is not possible to define routes with multiple varying query params.

Hi @aleksandrlat, it would concern route-node package rather than router5. What is limiting you with path-parser?

We need optional params.

Is it possible to redirect from hash routes like /#part1/part2 to /part1/part2 with router5?
We are adding router5 and we are changing hash urls to regular. And we want to redirect from old urls to new.

Optional parameters are achievable with forwardTo. It's a little verbose, but I'm open on potential abstractions at the router level (i.e. generating the example below). For using a different parser, I'm unsure about the outcome (whether it's something which is feasible or not), and I'm not willing to try myself.
{
    name: 'parentRoute',
    path: '/route',
    forwardTo: 'parentRoute.default',
    children: [
        {
            name: 'default',
            path: '/'
        },
        {
            name: 'withId',
            path: '/:id'
        }
    ]
}

Is it possible to redirect from hash routes like /#part1/part2 to /part1/part2 with router5?

 Or you can add a plugin which wraps the start function and applies that logic (see browser plugin for inspiration).

Thank you @troch!
Also for url like this http://localhost:3000/user/settings?integrationstab=true&no-rsc-connect
no-rsc-connect does not appear in params of route. I use queryParamsMode = loose

For using a different parser, I'm unsure about the outcome (whether it's something which is feasible or not), and I'm not willing to try myself.

Will you accept PR if I implement it?

@troch It would be nice to have options URL params.
Especially for routes displaying default / unfiltered content (content without the URL param).
Right now the route needs to be registered two times, and the forwardTo does not really change this, since the example with two child routes now totals 3 unique routes.


Allow regex to match namespaces

Made a fix to allow namespaced classnames in the database to work with the Fluent extension.
e.g "MySite\Page\CustomPage"."Fieldname" wouldn't match to augment the query

This is a good fix; Unfortunately it doesn't merge cleanly for some reason. Maybe it needs to be rebased on master?
Can you please add a unit test with a namespaced class to show that it works?
Thanks very much. :)

bump

bamp

I rebased and merged it with https://github.com/tractorcow/silverstripe-fluent/commit/d75c0a17c1095f8dac0c148f6aef770ff1a32a1f


HACK: Avoid retransmissions by wiping buffers.

As per @staticfloat's request, this avoids retransmitting previous buffers by wiping them in the interrupt handler. This is a hacky solution because it's expensive to wipe these buffers, esp. when we'll start using GPUs again (because this would result in writes to GPU memory over the PCIe bus, which I'm not even sure is OK to do in an interrupt handler). But for now, it might help debugging the other issues we're dealing with.
A better solution would be to disable the DMA loop from the interrupt handler when an underflow occurs, and re-enable it in liblitepcie from dma_process or when fetching a new write buffer. But that's more finicky, and I just wanted something that would work for now.
Test script:
#include <stdio.h>
#include <string.h>
#include "liblitepcie.h"

const int data_width = 16;
const char* litepcie_device = "/dev/litepcie0";

int main() {
    static struct litepcie_dma_ctrl dma = {.use_reader = 1, .use_writer = 1};
    dma.loopback = 1;

    if (litepcie_dma_init(&dma, litepcie_device, 1, 0))
        exit(1);

    char *buf_wr;
    char *buf_rd;

    // fill the DMA reader buffers with known data
    while (dma.reader_sw_count <= DMA_BUFFER_COUNT) {
        litepcie_dma_process(&dma);

        // process the buffers that are ready
        while (1) {
            buf_wr = litepcie_dma_next_write_buffer(&dma);
            if (!buf_wr)
                break;

            memset(buf_wr, 1, DMA_BUFFER_SIZE);
        }
    }

    // empty a single buffer to show where we stopped transmitting
    while (1) {
        litepcie_dma_process(&dma);
        buf_wr = litepcie_dma_next_write_buffer(&dma);
        if (buf_wr) {
            memset(buf_wr, 255, DMA_BUFFER_SIZE);
            break;
        }
    }

    // check the looped back buffers
    for (int i = 0; i < 2*DMA_BUFFER_COUNT;) {
        litepcie_dma_process(&dma);

        // process the buffers that are ready
        while (1) {
            buf_rd = litepcie_dma_next_read_buffer(&dma);
            if (!buf_rd)
                break;
            printf("buffer %d: %d\n", i, buf_rd[0]);
            i++;
        }
    }

    return 0;
}

Before this change:
buffer 0: 1
...
buffer 351: 1
buffer 352: -1
buffer 353: 1
...
buffer 541: 1

After:
buffer 0: 1
...
buffer 93: 1
buffer 94: -1
buffer 95: 0
...
buffer 542: 0

A better solution would be to disable the DMA loop from the interrupt handler when an underflow occurs, and re-enable it in liblitepcie from dma_process or when fetching a new write buffer. But that's more finicky, and I just wanted something that would work for now.

Turns out that doesn't work, the DMA engine expects to be run contiguously and stopping/re-starting it will introduce unwanted behavior/synchronization issues. A better solution would be to introduce a register to disable the RF output when set, which could be toggled by the driver when detecting an underflow.

The alternative: a CSR that temporarily disables transmission, https://github.com/enjoy-digital/xtrx_julia/commit/9737744842416868bf8c1c9541c30459efa3c4f3. I'll look into integrating this.


Create mission_goals.md

Initial version of mission and goals for DID Method Standardization

LGTM other than some minor adjustments highlighting that this is a multi-organization initiative.

Great suggestions @msporny, thank you!


Gaussian Mixture with BIC/AIC

Reference Issues/PRs

19338
What does this implement/fix? Explain your changes.
It automatically selects the best GM model based on BIC or AIC among a set of models that are parameterized by:

Initialization scheme, which could be random, k-means or agglomerative clusterings (as done in mclust, see below)
Covariance constraints
Number of components

Any other comments?
This work is inspired by mclust (a package in R) and its performance is evaluated on synthetic and real data (Athey, et al., 2020).

@asaadeldin11 Do you mind taking a quick look? Thanks!


Invoking setters to populate POJO

Is there a way to force the mapper to use setters to populate a POJO? When my POJO has overloaded constructors the mappers expects an exact constructor matching the arguments with the columns in the SELECT clause. For instance,
class MyPojo {
    private Long id;
    private String name;

    // No constructor
}

Note that MyPojo has default (no-arg) constructor only.
DynamicJdbcMapper<MyPojo> mapper = JdbcMapperFactory.newInstance().addKeys("id").newMapper(MyPojo.class);
ResultQuery<?> query = dsl
        .select(
                MY_TABLE.ID.as("id"),
                MY_TABLE.NAME.as("name"))
        .from(MY_TABLE).where(MY_TABLE.ID.eq(1));

MyPojo pojo = mapper.stream(query.fetchResultSet()).findFirst().orElse(null);

The above works fine.
But in my case MyPojo is a legacy class and comes with a whole bunch of constructors:
class MyPojo {
    private Long id;
    private String name;

    public MyPojo(Long id) {
        this.id = id;
    }
}

Note the Pojo now has an overloaded constructor. This causes the mapper to not work with the same query. I get the following error:
Could not find eligible property for 'name' on  class com.bla.bla.MyPojo

It is apparent that the mapper is trying to look for a constructor with arguments matching the columns in the SELECT clause. I don't want to add overloaded constructors (the SELECT column list is huge). It'd be nice to force the mapper to call the setters regardless.

there is some heuristics  to find an injection point. If there  is a  setter it should be able to use it.
I would need a reproducer to see where the problem is.

there is some heuristics  to find an injection point. If there  is a  setter it should be able to use it.
I would need a reproducer to see where the problem is.


add docs for HPO on SLURM

@EthanMarx heard that you are in transit. I'll pull this in. And in fact it might be easier to read the rendered docs.


chore: add pod name to dc project label

Adds the pod name to the Docker Compose project name. This completely eliminates the orphaned container warning messages for me, though I don't know all the ramifications of this change. Basic commands like up, status, stop, & rm all seem to work.
One effect (drawback?) is that by default a new network will be created for each pod, unless one changes the pod definitions to use a manually-created external network—which is what I did. IMO this is something that should be Cage's responsibility, but I didn't see any code path specific to network creation, so I guess that would be a new feature.
Apologies for any newbie mistakes: my only experience with Rust has been reading the Rust book yesterday.
closes #108

I'm seeing lots of cargo clippy errors about imports that shouldn't have been affected by my changes, and I don't see any such errors in master. What's up with that?

Thank you for the suggestion!
Unfortunately, I believe that this change would break the ability of services in different pods to access each other over the network, which is a very important cage feature that Faraday uses heavily to communicate between front-end services and internal services.

Unfortunately, I believe that this change would break the ability of services in different pods to access each other over the network, which is a very important cage feature that Faraday uses heavily to communicate between front-end services and internal services.

That’s what I mentioned in my PR description, when I said

One effect (drawback?) is that by default a new network will be created for each pod, unless one changes the pod definitions to use a manually-created external network—which is what I did. IMO this is something that should be Cage's responsibility, but I didn't see any code path specific to network creation, so I guess that would be a new feature.

If cage took responsibility for network creation instead of relying on the Docker Compose default behavior, then we could preserve the original behavior that cage provides now without any additional effort on behalf of the user, while still making projects pod-specific.


How to make the body content dimmed or blurred when dialog is active?

I want to make the body content dim or maybe blurred when any dialog is active. I currently did it using useEffect hook and manual state so if dialog becomes active, the body content except for dialog gets dimmed. But this is true only for 1 dialog, not for every dialog.
Could there be a feature where if any dialog becomes active, the body behind it gets dimmed? alternatively please suggest how to do it for all dialogs without declaring useState and useEffect wherever we use dialog component.
   useEffect(() => {
      const body = document.getElementById("dashRoot");
      if (isDialogOpen) {
         body?.classList.add("dialogActive");
      } else {
         if (body?.classList.contains("dialogActive")) {
            body.classList.remove("dialogActive");
         }
      }
   }, [isDialogOpen]);

(I could make a custom hook that does this. but I wanted to do this without requiring to declare the hook as well)

i meant dimmed as reduced opacity so the background doesn't scream along with dialog.
So it seems the DialogOverlay is not working for me. Do I have to import it to use it or I am missing something?

Would be helpful if you could set up a codesandbox with a minimal reproducible example

Not a fan of codesandbox or similar online IDE's but upon trying it in a fresh project with just shadcn dialog, the overlay seems to work.
I guess some of my modifications to dialog component in my project made the overlay to not work. Need to figure out that then.

Update: found out the cause. I had removed the class bg-black/80 from the overlay, hence the issue.
Many thanks for your time. I will close this issue now

Is there an option to access the className attributes from the exposed components like  or anything else to change it without altering the source component? I tried everything I could but wasn't able to change the opacity.

Is there an option to access the className attributes from the exposed components like \u003CDialog/>

All the components do provide a prop to add any classnames you want.

Thank you for your fast answer I really tried to add a depending prop to every part but it's not working for me to change the bg-black/80 from the exposed component where would I add the className prop?
  <Dialog className=""> // I tried to set it here but it doesn't allow className here
        {/* <DialogContent className="" /> */} // I also added this exitra component for testing if it works to add this and add the className here but also no success

My Page Content

        <DialogContent className="max-h-screen overflow-y-auto">
          <DialogHeader>d
            <DialogTitle></DialogTitle>
            <DialogDescription></DialogDescription>
          </DialogHeader>
          My Dialogs Content
        </DialogContent>
      </Dialog>

Where should I add the className="bg-red-500/50" prop to test it?

Where should I add the className="bg-red-500/50" prop to test it?

Tbh it should work when you add it into the main Dialog component, to test, you could check if the styles are there in browser when you inspect element on it. If it seems to be not applying, one of the possible reasons I think could the black color is overriding your red color.

I'm sorry but I think you're wrong. I tried to add it to the main Dialog lots of times and it never worked.

Update DialogOverlay and DialogContent to accept additional parameter, so that you can have complete control over it
const DialogOverlay = React.forwardRef<
  React.ElementRef<typeof DialogPrimitive.Overlay>,
  React.ComponentPropsWithoutRef<typeof DialogPrimitive.Overlay> & { overlayOpacity: number }
>(({ overlayOpacity, className, ...props }, ref) => (
  <DialogPrimitive.Overlay
    ref={ref}
    className={cn(
      `fixed inset-0 z-50 ${overlayOpacity === 100 ? `bg-black` : `bg-black/${overlayOpacity}`}  data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0`,
      className
    )}
    {...props}
  />
))
DialogOverlay.displayName = DialogPrimitive.Overlay.displayName

And the DialogContent
const DialogContent = React.forwardRef<
  React.ElementRef<typeof DialogPrimitive.Content>,
  React.ComponentPropsWithoutRef<typeof DialogPrimitive.Content> & { removeCloseIcon?: boolean, overlayOpacity?: number }
>(({ removeCloseIcon = false, overlayOpacity = 80, className, children, ...props }, ref) => (
  <DialogPortal>
    <DialogOverlay overlayOpacity={overlayOpacity} />
    <DialogPrimitive.Content
      ref={ref}
      className={cn(
        "fixed left-[50%] top-[50%] z-50 grid w-full max-w-lg translate-x-[-50%] translate-y-[-50%] gap-4 border bg-background p-6 shadow-lg duration-200 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:slide-out-to-left-1/2 data-[state=closed]:slide-out-to-top-[48%] data-[state=open]:slide-in-from-left-1/2 data-[state=open]:slide-in-from-top-[48%] sm:rounded-lg",
        className
      )}
      {...props}
    >
      {children}
      {!removeCloseIcon && (
        <DialogPrimitive.Close className="absolute right-4 top-4 rounded-sm opacity-70 ring-offset-background transition-opacity hover:opacity-100 focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:pointer-events-none data-[state=open]:bg-accent data-[state=open]:text-muted-foreground">
          <Cross2Icon className="h-4 w-4" />
          Close
        </DialogPrimitive.Close>
      )}
    </DialogPrimitive.Content>
  </DialogPortal>
))
DialogContent.displayName = DialogPrimitive.Content.displayName

i have additional option to remove default close icon for my use case