killer sensor: add support for fmod_ret

this PR is a followup to https://github.com/cilium/tetragon/pull/1948.
It adds fmod_ret support to the killer sensor and further improves testing.
killer sensor: add fmod_ret support

Failure of go tests seems unrelated:
--- FAIL: TestMatchCloneThreadsIDs (0.76s)
     threads_test.go:158:
        	Error Trace:	/home/runner/work/tetragon/tetragon/go/src/github.com/cilium/tetragon/pkg/sensors/exec/threads_test.go:158
        	Error:      	Not equal:
        	            	expected: 0x6148
        	            	actual  : 0x6146
        	Test:       	TestMatchCloneThreadsIDs

CC: @tixxdz
I will retry and see if the issue persist.

@olsajiri thanks! Pushed a new version, PTAL.

@tixxdz name needs to change IMO but I think its fine to do  a search and replace and move PR. I wouldn't mix it up with improvements/fixes.


Add pipeline for running AB Testing of Cilium Parameters

This pull request introduces a new performance evaluation pipeline for A/B testing with Cilium parameters. The changes include the addition of a new YAML configuration file, a Terraform variables file, and a JSON file for test inputs.

@microsoft-github-policy-service agree company="Microsoft"

lgtm, thanks Hao!


has state class total_increasing, but its state is not strictly increasing

Version of the custom_component
2.3.0
Describe the bug
My home assistant crashed last night and went through the debug logs and found a warning related to this integration. I'm pretty sure it's not what crashed my home assistant but thought I'd create an issue for it regardless.
It looks like the energy_added_sensor is supposed to be "total_increasing" but it got a state that was not increasing.
Debug log
2022-06-02 04:15:10 WARNING (Recorder) [homeassistant.components.sensor.recorder] Entity sensor.tesla_energy_added_sensor from integration tesla_custom has state class total_increasing, but its state is not strictly increasing. Triggered by state 47.95 (48.06) with last_updated set to 2022-06-02T08:10:19.803916+00:00. Please report it to the custom component author.

Looks like the API does sometimes reduce the value without hitting 0.

Bump on this issue. Without going back to 0 between charges, it is impossible to aggregate the total amount of charge for a given period. For example, using a utility meter for monthly energy consumption on the energy added sensor does not work.

I am still getting that error:
Entity sensor.domis_tesla_energy_added from integration tesla_custom has state class total_increasing, but its state is not strictly increasing. Triggered by state 49.86 (50.12) with last_updated set to 2022-12-29T12:47:04.912625+00:00. Please report it to the custom integration author.

I am still getting that error:
Entity sensor.domis_tesla_energy_added from integration tesla_custom has state class total_increasing, but its state is not strictly increasing. Triggered by state 49.86 (50.12) with last_updated set to 2022-12-29T12:47:04.912625+00:00. Please report it to the custom integration author.

This is because energy added from the car sometimes decreases slightly when the battery cools down, in your case from 50.12 to 49.86. Really we should be using energy used rather than energy added, and that will never decrease. However it would have to be calculated since it's not provided by the API.
The warning doesn't cause any problem however, the value can decrease by up to 10% at a time before the consumption resets.


Parsing question

First off, many thanks for this library and great work
I managed to get the rss xml parsed and it looks like this
<rss version="2.0">
     <channel>
        <title>
       </title>
        <title>
       </title>
         .......
     </channel>
</rss>

So I'm trying to extract the title as such but its not returning anything.
        for elem in xml["rss version=\"2.0\""]["channel"] {

            print(elem["title"].element!.text!)
        }

Ah it should be
for elem in xml["rss"]["channel"] {
            print(elem["title"].element!.text!)
 }

Hi @acegreen - glad you were able to figure it out! Yup, the version part of the rss element is the attribute - there is support for filtering elements by attribute as well, but it looks like you don't need that at the moment.


Secrets default parameter

The secrets parameter should be set per default in the action, but letting the user overwrite it and customize which secrets are injected in the action.

It is not possible to set secrets as a default parameter as you do not have access to the secrets object within the action. This makes perfectly sense, since a user of a action should be aware if this object is accessed. Closing issue.


TS3 Plugin not working

Hi maybe im too dumb to get it working or something might be wrong:
2018-04-25 19:24:22: python.d INFO: ts3: external: check() => [OK]
2018-04-25 19:24:22: netdata ERROR : PLUGINSD[python.d] : File /var/cache/netdata/netdata.runtime_ts3_external/main.db is too old. Clearing it.
2018-04-25 19:24:22: netdata INFO  : PLUGINSD[python.d] : File /var/cache/netdata/netdata.runtime_ts3_external/run_time.db is too old (last collected<PHONE_NUMBER> seconds ago, but the database is 3996 seconds). Clearing it.
2018-04-25 19:24:28: python.d ERROR: ts3: external: Socket timed out.
2018-04-25 19:24:28: python.d ERROR: ts3: external: 'NoneType' object has no attribute 'send' used configuration: host: IP....... port: 10011 socket: None
2018-04-25 19:24:28: python.d ERROR: ts3: external: update() unhandled exception: expected string or buffer
maybe someone can help me ?
Config:
external:
update_every: 1
# priority: 60000
# retries: 10
host: 'xxxxxxxxx'
port: 10011
# sid: 1
user: 'yxyxyxyx'
pass: 'yxyxyxyxy'

I had a similar problem and could fix it by using the IP address of the host (in my case '<IP_ADDRESS>' instead of 'localhost')

This problem should be fixed with the latest version. There was an issue with the SockeService. I changed the import path and it at least worked for me when trying to reproduce the error.

I'll try it and then close the issue when its working.


Not working with Ruby 2.5.0

I got these issues in my rails project(Rails 5.2.0.rc1, Ruby 2.5.0) using this gem.

Running tests got uninitialized constant ActiveSupport::TestCase::FactoryBot (NameError)
In the rails console, FactoryBot is not available(uninitialized constant FactoryBot).
Generating new model won't automatically generate factories(factories/*.rb).

Everything is working fine after I downgrade to Ruby 2.4.2.
I also created a repo which could reproduce all the errors.

How do I duplicate the problem? I cloned the repo, bundled and tried bin/rails test.

@mikegee It's strange. I tested this on another computer and I couldn't reproduce it either. However, I did encounter this problem at my workplace. I guess it's because of the operating system or some libraries? I'll check this again to see if I can find more info next Monday.

I'm still getting errors on the particular computer. But my colleague didn't get anything wrong with this repo. I'm closing this issue as I think it's nothing related to this gem.

Got the
uninitialized constant ActiveSupport::TestCase::FactoryBot (NameError)

error, stopping spring solved it:
bin/spring stop

@ug0 Have you managed to resolve this for your local env?
Having the same issue with my local env with 2.6.6.
CI builds pass, but I can't run them locally because of uninitialized constant FactoryBot
Since CI passes, I believe requiring explicitly isn't necessary (and never was prior to ruby and rails update)


Displaying More than Two Themes

Issue type
I'm submitting a ...  (check one with "x")

[ ] bug report
[ ] feature request
[X] question about the decisions made in the repository

Issue description
Current behavior:
The current ngx-admin displays only two themes by default.
Expected behavior:
I would like to have the ability to show a list of themes in a drop down and users should be able to pick one of them instead of limiting only to ttwo.
Steps to reproduce:
Use any out-of-the-box installation of ngx-admin and you should see only two themes.
Related code:
None
Other information:
None

Hey @nsankaranarayanan, following the Advance Step here https://akveo.github.io/nebular/#/docs/guides/enabling-theme-system you can add more themes. And then put a dropdown to the header to be able to select any of those themes.

Hey @nsankaranarayanan, are we good to close it?

It also looks like you have added this as a default feature in the new version. I am good to close this.


Incompatibility with recent versions

It does not work anymore in last PHPStorm version.
I use currently PHPStorm 2020.3. May you update it?
Thanks in advance!

Thank you 😊. New update on the way ! 🏃♂

In two business day, it'll release 🚀


opt.scale is always ignored

If scale is provided, its value is ignored and replaced with a scale computed from the default zoom.
Relevant lines: https://github.com/uber-common/viewport-mercator-project/blob/master/src/perspective-mercator-viewport.js#L76-L87

If scale is provided, its value is ignored and replaced with a scale

@donmccurdy Yes, the idea is that the class uses the named parameters listed in the constructor. It's intended to be a typical set of web mercator parameters, such as used by mapbox-gl/react-map-gl/deck.gl.
If you have scale instead of zoom, just convert it to zoom before you pass it in by calculating the base 2 logarithm:
new WebMercatorViewport({
   ...,
   zoom: Math.log2(scale)
});

@donmccurdy Just noticed that the docs do list scale. I'll take a second look to decide what should be changed. In the meantime, use the workaround above.


Include cause in unexpected exceptions

Description
Include cause in unexpected exceptions
Also added info level logging to see these messages in a PR
And removed artifacts step as they were never used and the martix of jdk
release would override them (saves couple minutes from check runtime)
Testing
Added an exception and verified it appeared in the output
Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The cause(error message) would be exposed to client. Is it sufficient to log the cause as a part of stacktrace in logs?

Being that this PR was created to expose the exception message, and we shouldn't expose these messages in this way I have created https://github.com/opensearch-project/security/issues/1644 to track the root cause (tests aren't collecting/outputing log.error from the cluster under test).  Closing out this PR.


[Question]ELK 6.0.0 bug in chrome environment (wale, edge, explorer working)] SearchGuard6.0.0-17.beta1 and the default default setting has a hang phenomenon

Kibana version:
6.0.0
Elasticsearch version:
6.0.0
Server OS version:
CentOS 7.0
Browser version:
Chrome 62.0.3202.94
Search Guard 6.0.0-17.beta1 Operation Test
Basic login logic is  working, page pausing occurs on the dashboard.
1. elasticsearch Search Guard Working

2. Kibana Search Guard paused after login
has not Response

Request URL is the same, but in 6.0.0 version, it is looped and there is no response value

page not found message is normal.

Did I missing something..?
Regards,
jinsu.

I cannot reproduce the behavior. I get the 404 for non-existing index patterns and Kibana behaves normally. Is there anything in the Kibana logfiles? Is there anything in the Elasticsearch logfiles?
Also, which user are you using for logging in to Kibana? As far as I understood you just used the default configuration shipped with Search Guard, is this correct?

No feedback and not reproducible


Fix pytest 2

@JustinGrilli  I was trying to fix the CI and thought it might be a setup tools issue.  Now on this branch the CI isn't even running which is strange.


NIST Api Key to solve intermittent fail to download

I can't see how to use the NIST Api Key.
It's very important to reduce download error due to the rate limit imposed by the NIST: https://nvd.nist.gov/developers/start-here
I'm having intermittent fail due to Unable to download NVD CVE 2010
Am I doing something wrong?
I'm running dep check for a lot of projects every night.

We are not yet using the NVD APIs; we are currently using the NVD Data Feeds which will be retired in September 2023 (might have the date slightly off).
See https://jeremylong.github.io/DependencyCheck/data/index.html. One of the options would be to mirror the NVD locally so that you do not have these issues. If you are using the CLI or Docker image - consider shifting to use owasp/dependency-check-action. This is an image that is updated nightly with the latest data.
Another mistake a lot of people make is not caching the data directory. If you save the data directory you won't have to re-download all of the NVD data every day.

Yes - just keep the data folder between executions.


python3Packages.aocd-example-parser: init at unstable-2023-12-17

Description of changes
This package is needed for the aocd Python 3 package as a dependency.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The contents of this commit is also present in #284227. As a result, this PR will be closed.


Multiple shadow roots deprecated

Hi, I am trying to use chess-board component in an ionic app it fails with the following error message:

Calling Element.createShadowRoot() for an element which already hosts a shadow root is deprecated. See https://www.chromestatus.com/features/4668884095336448 for more details. (chess-board.js:15)

I am loading chess-board.html via index.html of the ionic app and type FEN in a page's .html
Is there a way to overcome this issue?  Thanks.

It fails here
      this._frameRoot = this.createShadowRoot();
      this._frameRoot.appendChild(_templates.frameTemplate.content.cloneNode(true));

It's just a deprecation warning, and it should still work perfectly for a while until Google removes the message. However, I will make the proper changes to my code soon to remove that warning.

The latest release should be OK now.

Thank you!


Get Sharepoint Access - Master Spreadsheet

Description:
This ticket is to be able to get access to the Master Spreadsheet for our system to be able to import data

[ ] Connect to the Master Spreadsheet on Sharepoint without using a user token

Hey team! Please add your planning poker estimate with Zenhub @marcellmueller @rafasdc @VB-at-Bis

Please add your planning poker estimate with Zenhub @rafasdc

The library used for authentication node-sp-auth currently has two vulnerabilities on their packages, will need a patch.


Separate Exports

Check if Rollup fits the below requirements

Seperate export per file - Likely https://rollupjs.org/guide/en/#outputpreservemodulesroot
CJS/ES6 exports (possibly esm as well)

Provide a way to may contributing easy. Currently there's no conventional way of seeing your live changes for a component, except storybook which may be limiting. This should speed up development significantly.
Setup a beta release channel. ex: npm i<EMAIL_ADDRESS>Verify the bundle size of each component
Verify that the CSS of a component is loaded correctly in SSR

Additional points:

Start migrating leftover v4 code to v5 - https://github.com/squaredev-io/matte/issues/48
Add tests - https://github.com/squaredev-io/matte/issues/55
Setup GH actions for release - related: https://github.com/squaredev-io/matte/issues/54

cc @momegas @ksiabani any comments/suggestions?
https://github.com/squaredev-io/matte/issues/77

This is too technical for me, so I am OK with what you decide. Please put each issue to the relevant milestone. Is it a basic need for v1? Put it in Version 1.0 milestone. Otherwise put it to version Next


Stripe::InvalidRequestError Exception: You must supply a valid card error with subscriptions

Attaching a subscription directly in the create method gives an "Stripe::InvalidRequestError Exception: You must supply a valid card" error:
Stripe::Customer.create(description: @user.full_name, email: @user.email , plan: @subscription.plan_stripe_id, card: @payment.stripe_card_token)

If I create the customer directly:
customer = Stripe::Customer.create(description: @user.full_name, email: @user.email, card: @payment.stripe_card_token)

everything works. The only difference is that I passed a plan to the create method.

@sebastiandeutsch  use source instead of card

@alexmamonchik it works thanks.


Need to set GlobalVarAccess = TRUE

Can All Integration Type Event's property to be changed so that GlobalVarAccess = TRUE.  Can this be a default setting for all new and future event creations.

No, this we cannot do, as that would mean that changing a global variable would be a breaking change going forward. Please be more specific about the issue you would like to address, and we will take a look at your requests one by one.

Jasper, This is a generic request to have better scope to interact and manipulate global variables in the event publishing codeunits.  If this is implemented, it will lead to less direct code change to manipulate global variables as you can access them in the event subscripting codeunit.


Fix note icon, UL marker size, dot-leader

Revert the note admonition icon to the older info circle.
Make unordered lists bullets larger.
Add the TOC dot-leader back in.

Change codespan font to Jetbrains mono.

Make page number column in TOC fixed width so the column does not look wavy.
Make Figure number and Table number column in list of figures and list of tables fixed width so that captions line up and dont look wavy. Perhaps something like below:
# List of figures settings
lof:
  label_width: '3em'  # Adjust the width for figure labels
  align: left
  caption:
    indent: '4em'  # Ensure captions align consistently

# List of tables settings
lot:
  label_width: '3em'  # Adjust the width for table labels
  align: left
  caption:
    indent: '4em'  # Ensure captions align consistently

Bullets could possible be fixed this way:
# List settings
list:
  indent: '$horizontal_rhythm * 1.5'
  item_spacing: '$vertical_rhythm / 2'
  bullet:
    font_size: 'round($base_font_size * 1.5)'
    content: '•'

I'll give that a try.

Didn't seem to work.

I've fixed the bullets.  I have it looking like this now:

That looks good. Thanks!

how does the level 2 and level 3 sub-bullet look?

Here's what all 3 levels look like:

The size and shape look good! Could the second level also have color black instead of white.

How's this:

Thanks! Looks good!

btw, setting the :bibtex-style: apa, which matches the ISA manuals will fix your bibliography alignment issue.

I think the LaTex ISA manual - before asciidoc coversion - used to use ieee bibtext style. It would be preferred to use ieee style..

Ah, OK.  This is a known issue with the ieee style in asciidoc.  I'll see if there's a resolution.

@wmat - would you be updating the codespan font as well to something like Jetbrains mono?

Yes, I'll do that as well.

JetBrainsMono has been added to my docs-resources branch and pointed codespan at it.
As for the Bibliography, it'd be some work to make the ieee formatting match LaTeX.  I know this isn't ideal, but I don't think it's warranted right now.  Can you live with the layout the way it is?
So what's left for the iommu spec?  The alignment of the LoF and LoT?

Thanks!

As for the Bibliography, it'd be some work to make the ieee formatting match LaTeX. I know this isn't ideal, but I don't think it's warranted right now. Can you live with the layout the way it is?

I think I can live with that.

So what's left for the iommu spec? The alignment of the LoF and LoT?

The two other item I was tracking were

"wavy" numbers column in TOC, LoF, and LoT.
Lining up the caption text to start from same column in LoF and LoT.

So if I use JetBrainsMono as the font for lists it's slightly approved, at least for text alignment but I can't seem to get the wavy numbering to go away:

The Jetbrains mono was to help solve the weird ligatures that were being previously produced like this "&". Hopefully updating to Jetbrains fixed that

Looks like this now:

Thanks! This looks nice! The older one rendered "&" and "~" using really odd characters.

OK, great.  That screen capture was from my local build btw.  I'll make the changes to docs-resources next.

The GitHub action build is now using all of these fixes in docs-resources.  Should probably close this now and open new issues as you find them.

One thing I noticed is that the text inside tables is much smaller than the main body text. Was that intentional?

I thought that was fixed. I’ll look shortly.
Bill Traynor
Documentation Build and Release Engineer
RISC-V International
Join us in Munich, Germany at RISC-V Summit Europe
https://riscv-europe.org/summit/2024/ from 24-28 June. Be a part of the
new wave of European computing innovation!
On Tue, Jun 11, 2024 at 3:23 PM Ved Shanbhogue @.***>
wrote:

One thing I noticed is that the text inside tables is much smaller than
the main body text. Was that intentional?
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-iommu/issues/345#issuecomment-2161457092,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAN6ZH63XJR7DV2NHSNK23ZG5FEFAVCNFSM6AAAAABI7HY7RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGQ2TOMBZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

So table_font_size was changed to 11.5 recently and then overwritten back to 9 with the merging of the two themes.  9 seems a bit small to me.  I'm thinking a size of ($base_font_size * 0.9em) would be appropriate.  That is the equivalent to 10.35 pt when base font size is 11.5 pt.

Thanks! That looked good!

One small nit if its not too hard to fix. I think the bullets are now a bit too big - I believe they are set to 1.5xbase-font - perhaps 1.25xbase-font is more appropriate. I pasted a google doc compared to the current render.

I actually am just using unicode glyphs.  I believe that one is U-26AB.  Does this look better?  I can hardly see the difference.

i can't get it to change :/

Maybe it will respond to a "font-size" tag in ulist?
ulist:
marker:
disc:
content: "\u26ab"
circle:
content: "\u26ab"
square:
content: "\u25a0"
font-family: JetBrainsMono
font-size: ????

that's exactly what I tried.

Maybe U+2022 is better?

I tried a bunch of these and seems like what you have currently is  the best among all.


compatibility with llama.cpp

Hey, first of all, amazing work. Thanks for building an open llama model. As the title suggests, I would like to know if this model could be compatible with llamacpp
Thanks

Works flawlessly with OpenAlpaca, but I strongly assume this means OpenLLaMa will work as well.

Amazing, then we can take advantage of all the tools in llama.cpp. Especially the M1 gpu inference. I get 88ms per token on guanaco 13b on my MacBook. which is quite fast considering how big the model is.


Provide a Layer combinator form Layer<Has & Has, E, A> to Layer<Has<A & B>, E, A>

In some cases is necessary provide a conversion between Layer<Has<A> & Has<B>, E, A> to Layer<Has<A & B>, E, A>.
A possible and simple implementation could be:
export const toProduct = <R1, E1, B>(other: L.Layer<R1, E1, H.Has<B>>, tagO: Tag<B>) => <R, E, A>(
  self: L.Layer<R, E, H.Has<A>>,
  tagS: Tag<A>,
) => (tagab: Tag<A & B>) =>
  L.zip(other)(self)["|>"](
    L.chain((ab) => {
      const sa = tagS.read(ab[0])
      const sb = tagO.read(ab[1])

      return L.pure(tagab)({ ...sa, ...sb })
    }),
  )

Notes:

I am not sure if Has<A> & Has<B> is isomorphic to Has<A & B>
This operator was useful when I migrated http-fetch from legacy

Can you provide an example where this would be useful? In general they are not isomorphic as you could have functions with the same name in A and B and that would make A&B collide

Closing for inactivity


Changing IdentityModel package versions to beta5

Shouldn't this be in release?

It's against release - I created a bad PR on GitHub.

:shipit:


Config is .json5?

Why exactly is it a non-existent file format?

Json5 is an actual file format.
https://json5.org/
And as for why the config is in it: It has comments.

alright then, thought you'd mistyped or something.


feat: crawl PR and production

Changes

Fixes #285
Got stuck with an undescriptive error. Fixed it and made a PR to upstream.
Got stuck not knowing what the error means exactly. Asked a question about it.

Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

Followed up in the question, looks like this is stuck atm.


docs: change Google Cloud to Cloud

Closes #1992
This will change all references of Google Cloud to simply Cloud, with the exception of Google Cloud Platform since that references the platform itself and not the individual services.

@stephenplusplus before I revert any of the changes I think I would like confirmation from @jgeewax, his issue seems to want to remove it everywhere, not just from some of the APIs.

The comments with "Revert" are for what the Google Developer's Console UI shows. It would be incorrect if we said to find it under a name that doesn't exist.

@stephenplusplus PTAL


fix python runner oauth2

Fixes https://github.com/streamnative/function-mesh/issues/489
(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)
Master Issue: #
Motivation
Make changes according to https://github.com/streamnative/function-mesh/issues/489#issuecomment-1300713980
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation
Check the box below.
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

disable the legacy test case and tracking with https://github.com/streamnative/function-mesh/issues/508


CupertinoPicker change textColor

Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If you're changing visual properties, consider including before/after screenshots (and runnable code snippets to reproduce them).
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

Thanks for the contribution!
Looks like this PR has some test failures. Can you fix those? Please also fill out the PR description in the template. Can you please also add a test? Thanks!

The text style of CupertinoPicker and CupertinoDatePicker is controlled by pickerTextStyle and dateTimePickerTextStyle in CupertinoTextThemeData, respectively. Could you update the pull request description section to help us better understand why an additional textColor field is needed?

The text style of CupertinoPicker and CupertinoDatePicker is controlled by pickerTextStyle and dateTimePickerTextStyle in CupertinoTextThemeData, respectively. Could you update the pull request description section to help us better understand why an additional textColor field is needed?

My app has a dark theme option, primaryColor in dark active mode does not have white text. So I thought it was possible to put the color you want in the text of CupertinoPicker.[https://imgur.com/a/bOxGyps](mode light)
[https://imgur.com/a/JyHn8cN](mode dark)

Thanks for the explanation! As I understand it, you want the picker's text color to change based on whether dark mode is on? I think it is the default behavior if you use the default dateTimePickerTextStyle (or pickerTextStyle).
You can set it to a different CupertinoDynamicColor if you want to change the colors used:
final TextStyle newDateTimePickerStyle = CupertinoTheme.of(context).textTheme.dateTimePickerTextStyle.copyWith(
  textColor: CupertinoDynamicColor.withBrightness(
    lightColor: ....,
    darkColor: ....,
  )
);
CupertinoTheme(
  data: CupertinoTheme.of(context).copyWith(
    textTheme: CupertinoTheme.of(context).textTheme.copyWith(
      dateTimePickerStyle: newDateTimePickerStyle,
    ),
  ),
  child: ...
)

Thanks for the explanation! As I understand it, you want the picker's text color to change based on whether dark mode is on? I think it is the default behavior if you use the default dateTimePickerTextStyle (or pickerTextStyle).
You can set it to a different CupertinoDynamicColor if you want to change the colors used:
final TextStyle newDateTimePickerStyle = CupertinoTheme.of(context).textTheme.dateTimePickerTextStyle.copyWith(
  textColor: CupertinoDynamicColor.withBrightness(
    lightColor: ....,
    darkColor: ....,
  )
);
CupertinoTheme(
  data: CupertinoTheme.of(context).copyWith(
    textTheme: CupertinoTheme.of(context).textTheme.copyWith(
      dateTimePickerStyle: newDateTimePickerStyle,
    ),
  ),
  child: ...
)

sorry for the delay, i was traveling. I tested the code and wow! this works perfectly. thank you!


Implement child bounty list

figma link
https://www.figma.com/file/cIcOZxD9Ctqdj4xc9Xoctm/doTreasury?node-id=2358%3A19101

tab


Use FS when loading Scavengers' data

This prevents issues with loading old state while hotpatching.

readIfExistsSync?

Can't this just be fixed by putting Chat.uncacheDir('./config/chat-plugins/'); in the /hotpatch command?

uncache is honestly kind of dumb; I've been meaning to implement a JSON loader/saver in FS.


Linux: stroking svg path is breaking subsequent content

This problem started with <IP_ADDRESS>-8302 (linux)
<!DOCTYPE html>

    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>issue: svg path stroke is breaking subsequent content</title>

Content Before SVG

    <svg width="200" height="200">

        <circle cx="50" cy="50" r="40" stroke="green" stroke-width="4" fill="yellow" />

        <path d="M 50 50 H 110 V 110 H 50 L 50 50 Z"
              fill="green"
              stroke="red"
              stroke-width="5"/>

        <circle cx="150" cy="150" r="40" stroke="green" stroke-width="4" fill="yellow" />
    </svg>

Content After SVG

Notes to svelte users:

document.createElementNS is used by svelte to create svg elements at runtime.
you may need to replace return document.createElementNS('http://www.w3.org/2000/svg', name); with return document.createElement(name);

solved with <IP_ADDRESS>


Fixes for comments and warnings

Fixed warnings and comments

@dangershony or @monsieurleberre Could you guys merge it? I don't have permissions to do it


Unstable removeComments and removeEmptyLines

My codebase has 15,382,523 tokens , when I set the removeComments and removeEmptyLines true , the terminal stucks forever, even ctrl-c not working.

Hi, @rockmandash !
Thank you for reporting this issue!
I've analyzed the problem and identified that the main thread is hanging during the processing. I plan to implement non-blocking operations similar to what we're already using in the security check functionality.
I'll work on the fix and update you soon.

@rockmandash
This issue has also been fixed and released in v0.2.7! Please try it out.
https://github.com/yamadashy/repomix/releases/tag/v0.2.7

@rockmandash
Thanks for the detailed report, @rockmandash!
While the process seems to be getting stuck at api/index.php.develop, it's hard to say with certainty if that's the sole cause. However, the fact that your repo includes Python code is very relevant.
Current handling for large Python files can indeed be a bottleneck. The existing implementation may cause some performance issues, and can sometimes cause the terminal to freeze.
Regarding the use of a temporary directory for repos, I'm a bit skeptical if it would solve the issue, but processing large files by copying them to a temp directory and then processing them using streams might be a good approach. However, that's a big change, so for a faster fix, using worker threads to process files outside the main thread will likely be a more effective solution.
We are also exploring using tree-sitter in the future, which might improve processing performance even further.


Move change theme listener from code file to workspace

Description
Currently is onChange event attached to CodeFileView.
If no editor is open & "Automatically change theme based on system appearance" is set, theme is not changing.
Maybe move this to workspace ?

Related Issues

closes #1324
closes #1325

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] The issues this PR addresses are related to each other
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] My changes are all related to the related issue above
[ ] I documented my code

@Wouter01 is this okay ?

@Wouter01 is this okay ?

Yes, thank you!

@allcontributors add @dvandyy for bug


Connect compilation mode scrolling with flycheck movement

This is likely quite hard to do, and I don't see a clean solution to this; however, we now have better keybindings for both kinds of movements and those are documented in the README, so closing this as a wontfix (esp since at some point, we're going to connect this up to verus-analyzer, and at that point, having this will not be important anyways).


How to implement driving from indexA -> indexB -> indexC -> ........

Hi @eleurent,
I'm trying to give the ego-vehicle a planned route, and make it follow the route,

start at the south entry (se) of the right roundabout
leave the right roundabout via the west exit (wx) (enter the left roundabout via "wx")
leave the left rounabout via east exit (ee) (enter the right roundabout via "ee")
loop this cycle

I see, in road.py, you've defined several functions,
def next_lane (self, current_index: LaneIndex, route: Route = None, position: np.ndarray = None,                   np_random: np.random.RandomState = np.random)
def next_lane_given_next_road (self, _from: str, _to: str, _id: int,                                   next_to: str, next_id: int, position:
Few points i got stuck,
-If i use function next_lane, how to define the parameter "Route",  is it an index used to describe a tuple[start, end, route_number] which is equavilent to the current_index ?
-If i use function next_lane_given_next_road, how can i define the parameter "Position"
-After the definations of them, where to send them.
This video shows my other planned trajectory, which goes from the south entry of left roundabout to the right handside highway. As you see, it takes the minimum path between start and end point automatically. BUT, if i wish it travelling a different path, how can i achieve it?
https://user-images.githubusercontent.com/115365057/221671052-00979ff5-1e79-4483-aac7-9e2665ce8a91.mp4
Thank you for your reply!

Hi,

how to define the parameter "Route", is it an index used to describe a tuple[start, end, route_number] which is equavilent to the current_index ?

the route is a list of LaneIndex, where LaneIndex is the tuple (start node, end node, lane number)

If i use function next_lane [...], -If i use function next_lane_given_next_road...

You are not really supposed to use them directly.
Usually, after creating the road network and ego-vehicle, you can just define its route (sequence of LaneIndex) automatically by calling plan_route_to(node_destination). See e.g.:
https://github.com/eleurent/highway-env/blob/abcef8da79dedf0dfdbe2db5b176d6f203366489/highway_env/envs/roundabout_env.py#L150
This simply select the shortest path in the road network. But if you want, you can also edit the vehicle.route manually to choose another path: you have to provide a sequence of LaneIndex (start, end, number) such that the next start matches the previous end. See e.g. the implemetation of plan_route_to:
https://github.com/eleurent/highway-env/blob/abcef8da79dedf0dfdbe2db5b176d6f203366489/highway_env/vehicle/controller.py#L62
If you want an infinite loop between the two roundabouts, you can just create a very long list, or update it whenever it is empty.

Appreciate !
Besides, when I make env "intersection-V0", I got TypeError: unsupported operand type(s) for *: 'float' and 'NoneType'
I've tried numpy version 1.10--1.24, but they don't work.
May i know your numpy version?
thanks

Mmmmh, that's weird, the translation_axis should never be None (this is not a problem related to numpy).
I don't see how that can happen: this line is called after the two for-loops which should initialise the min_distance and translation_axis to non-None values at least once (unless will_intersect is false, but then the line is not called).
I have not managed to reproduce the issue, can you share more information about the error. For instance, can you add a print(a, b, displacement_a, displacement_b) at the beginning of are_polygons_intersecting, so I can reproduce the issue with the same inputs and investigate?

Thank you for replying me, I just solved this, after I copied the newest version of "intersection-v0"


Review Kirby support and EOL policy

Kirby is listed under 4.0 in "Further releases" at https://getkirby.com/releases. Moreover the current description does not seem in line with https://getkirby.com/buy.

It seems 4.0 is eol:
https://forum.getkirby.com/t/kirby-3-4-security-releases/30908/2

we received reports of three potential vulnerabilities in the Panel and decided to release fixes today in https://github.com/getkirby/kirby/releases/tag/4.1.1
We are also providing patches for Kirby 3:
<IP_ADDRESS>: https://github.com/getkirby/kirby/releases/tag/<IP_ADDRESS>
<IP_ADDRESS>: https://github.com/getkirby/kirby/releases/tag/<IP_ADDRESS>
<IP_ADDRESS>: https://github.com/getkirby/kirby/releases/tag/<IP_ADDRESS>
<IP_ADDRESS>: https://github.com/getkirby/kirby/releases/tag/<IP_ADDRESS>
<IP_ADDRESS>: https://github.com/getkirby/kirby/releases/tag/<IP_ADDRESS>

I see two options on Kirby:

We add cycle for 4.1 and update 4.0 cycle eol = releaseDate(4.1)
We update cycle 4.0 to 4

I tend for option 2
@marcwrobel can the automation handle the updates this way?
Opinions or other ideas?

can the automation handle the updates this way?

Yes, it can.
Option 2 seems more in line with the way the product is supported, and is simpler to maintain.


Roll Flutter Engine from e2bd89f97e7f to 0aa657800da8 (5 revisions)

https://github.com/flutter/engine/compare/e2bd89f97e7f...0aa657800da8
2023-03-06<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from lO7cFvQ7UoYqKRDnV... to YHXIOcHEIEtyHcNG4... (flutter/engine#40094)
2023-03-06<EMAIL_ADDRESS>Roll Skia from 7e1756b42f94 to fd380c7801f8 (4 revisions) (flutter/engine#40095)
2023-03-06<EMAIL_ADDRESS>Fix incorrect response to platform SystemSound.play (flutter/engine#39992)
2023-03-06<EMAIL_ADDRESS>Sequester all Skia<->DL interactions into the skia sub-module (flutter/engine#40083)
2023-03-06<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from 4iq5VNjEcZIlrUtDK... to kQnUhe74CH6d0V1vj... (flutter/engine#40090)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 4iq5VNjEcZIl to kQnUhe74CH6d
fuchsia/sdk/core/mac-amd64 from lO7cFvQ7UoYq to YHXIOcHEIEty
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Better documentation of buid/develop environment

Description:
Im trying to solve some known issues in the fmt core-formatters... anyway im getting some broken tests... i guess im missing a php lib or maybe a missing flag in the php.init
It would be nice to have a documentation about the environment to work with the bare sources or better provide the working environment for development (docker or vagrant)
Failing code:
ubuntu@ubuntu-xenial:/opt/tools$ uname -a
Linux ubuntu-xenial 4.4.0-97-generic #120-Ubuntu SMP Tue Sep 19 17:28:18 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

ubuntu@ubuntu-xenial:/opt/tools$ php scripts/test.php -v
Running tests...
...........................................................................................................................................................................................................................................................................................................................................................!...................................................................SS....................................................
Tests:469
Broken:1
--- /opt/tools/scripts/../tests/355-utf8-align.out      2017-12-12 14:58:43.370869528 +0000
+++ /opt/tools/scripts/../tests/355-utf8-align.out-got  2017-12-12 15:00:26.914571858 +0000
@@ -1,7 +1,7 @@
 <?php
 $utf8 = array(
-       'aitė\b' => 'as',
-       'ytė\b'  => 'is',
+       'aitė\b'  => 'as',
+       'ytė\b'   => 'is',
        'iūtė\b' => 'ius',
-       'utė\b'  => 'us',
+       'utė\b'   => 'us',
 );
Took 0.97347211837769
run test.php -v to see the error diffs

ubuntu@ubuntu-xenial:/opt/tools$ php --version
PHP 7.0.22-0ubuntu<IP_ADDRESS> (cli) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.0.22-0ubuntu<IP_ADDRESS>, Copyright (c) 1999-2017, by Zend Technologies

by the way same is working on:
[eiriarte@buero-a48 fmt]$ uname -a
Linux buero-a48 4.11.12-1-rt16-MANJARO #1 SMP PREEMPT RT Tue Oct 17 18:15:30 UTC 2017 x86_64 GNU/Linux

[eiriarte@buero-a48 fmt]$ php scripts/test.php -v
Running tests...
.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Tests:469
Broken:0
Took 1.655534029007

[eiriarte@buero-a48 fmt]$ php --version
PHP 7.1.12 (cli) (built: Nov 22 2017 17:43:08) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
    with Xdebug v2.5.5, Copyright (c) 2002-2017, by Derick Rethans

anyway its not possible to build the project (*.phar) with the second config but in the first one.
thanks in advance

Hi
I think we needn't any additional configuration for PHP.
For the Travis Build (5.6, 7.0, 7.1) are all successful (:

hi
good to know about the new travis integrations working... 👍
anyway in the first config the same test(355) is broken even without my changes... (master)
:]

got it: php-mbstring and php-xml were missing...
-> php-xml cries from the beginning becouse of missing function utf8_encode
-> php-mbstring was found by enabling disabling modules...


Initial slides for BHNT 78

Initial slides for BHNT 78 - if you have more news - please direct them my way

https://www.androidcentral.com/eu-makes-switch-signal-its-messaging-app-choice?amp


Is it possible to permission of folder?

Is it possible to permission of folder with role wise .I have use spalit/permission package so i want to your package integrate with permission package. can you guide for it

spalit/permission

Are you referring to Spatie?

Private folders allow only the owner of the folder to read/write. How the private folders are named can be customized, please see this document: https://unisharp.github.io/laravel-filemanager/config#private_folder_name


chore(main): release 2.0.0

:robot: I have created a release beep boop
2.0.0 (2024-02-08)
⚠ BREAKING CHANGES

Alter name of base dev container image

Features

Alter name of base dev container image (b1b26e6)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/jwbennet/project-base/releases/tag/v2.0.0 :sunflower:


Tensorflow Object detection -> How to get class name from trained model (.pb file)

Guys,
Tensorflow Object detection -> How to get class name from trained model (.pb file)
Trained with four class, i want to know how to get class name based on input give.
I checked with existing trained model and can able to get index value , but not able to get index/class name for my own trained mode
Any help appreciated !

You can invoke model.predict() if using Keras, then call probas.argmax(axis=-1)
A similar issue 2291 may help your case.
Here is the issue template to fill out:
System information
Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce:
You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

Nagging Assignee @wt-huang: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


Update migrate_agent.ipynb -> was refering to the wrong doc link

concerning issue https://github.com/langchain-ai/langchainjs/issues/6650

Fixes # (issue)

Thank you!

Failure is due to the notebook predating our lint check, should go back and fix it at a future date.


fix:  npm run dev-server error resolved

This error was coming with me, and 3-4 other pc's in which i tried to setup.
Error: You must provide the URL of lib/mappings.wasm by calling SourceMapConsumer.initialize({ 'lib/mappings.wasm': ... }) before using SourceMapConsumer     at readWasm (/home/test/superset_setup/superset/superset-frontend/node_modules/react-hot-loader/node_modules/source-map/lib/read-wasm.js:8:13)     at wasm (/home/test/superset_setup/superset/superset-frontend/node_modules/react-hot-loader/node_modules/source-map/lib/wasm.js:25:16)     at /home/test/superset_setup/superset/superset-frontend/node_modules/react-hot-loader/node_modules/source-map/lib/source-map-consumer.js:264:14
How to reproduce:

Try fresh installation
after superset/superset-frontend when you will do npm run dev-server , then above error will come.

Above error was also resolved by doing this:
export NODE_OPTIONS=--no-experimental-fetch
But i thought it is better to put in code.

@lilykuang @michael-s-molina @villebro @rusackas @eschutho @geido i have added one change to solve one error that was coming while running npm run dev-server, to run superset-frontend.
Please review.

When you say "PCs" do you mean Windows machines? I haven't run into this on Mac, so I'm trying to understand the nature of the error, so I can better understand why this change is needed.

I tried on linux machines.

@Abhishek-kumar-samsung can you add this environment variable to your local/dev/production machines instead as an option? It may be a more flexible option here, in case the rest of the application uses these fetch commands, which I did find some in a quick code search.

@eschutho @rusackas
I have removed the changes from package.json and moved it to documentation. Written if that error comes to anyone, then he/she can use the solution.
Please review.


Mjv/on off madness

Added dev assets for the button and for the toggle blocks (the ones that show and hide depending on the button state)
Also added dev SFX, these should be global maybe? or play near a switch or the toggle blocks, so that everyone knows somebody flipped the switch.
Enemies can press the button currently for more shenanigans, we could set up traps to divert players to a different room to get out of a puzzle


Assertion Failed!

This happed when i try to open the singularity. Mod worked until zoom popped out on my screen, then this happened for 1st time.

1st button ("Przerwij") means abort
next means retry
last means Ignore
Abort Crash
Retry Crash
Ignore nothing


Add Key and Joybutton extension to convert to ImGui types

The PR allows for Godot developers to check against Godot keycodes in an ImGUI window.
Improves on: https://github.com/pkdawson/imgui-godot/pull/12

Looks good, thanks!


Vscode doesn't work with python 3.8(Last Version)

When i try to work using python 3.8.6 And debug he give me Errors and when i change to other IDLE he work or if i work with an  other version like

And the problems for them both like for the the python.exe inside this path:
C:\Python38\
C:\Users\name\AppData\Local\Programs\Python\Python38-32

1. System info:
Operating System: Windows 10 Pro 64-bit (10.0, Build 19041) (19041.vb_release.191206-1406)
Windows Version:  2004
Processor: Intel(R) Core(TM) i5-5300U CPU @ 2.30GHz (4 CPUs), ~2.3GHz
Memory: 16384MB RAM

And you can check it here :
https://github.com/microsoft/vscode/issues/107967

Thanks for the bug report, but unfortunately we need some more information from you in order to triage this issue appropriately. Please edit your opening comment by providing a filled-in copy of our issue template. Once you are done please leave a comment to that effect.


find_extrema based on parallel reduction

This adds find_extrema_reduce function and change find_extrema function to use it if there is enough local memory on device to perform an efficient parallel reduction. If there is not, find_extema_with_atomics is used (just like it was).
find_extrema_reduce and find_extema_with_atomics get the same time results in perf_max_element benchmark. For vectors with 134217728 elements the difference is visible.
master branch:
=== max_element with stl ===
size,time (ms)
2,0.000231
4,0.000260
8,0.000286
16,0.000299
32,0.000312
64,0.000364
128,0.000421
256,0.000519
512,0.000779
1024,0.001274
2048,0.002192
4096,0.004097
8192,0.007887
16384,0.015551
32768,0.030970
65536,0.061633
131072,0.123388
262144,0.251553
524288,0.506069
1048576,1.010500
2097152,2.298420
4194304,4.540600
8388608,9.029470
16777216,18.179500
33554432,36.464900
=== max_element with compute ===
size,time (ms)
2,2.938670
4,2.953160
8,2.982040
16,3.020810
32,2.960240
64,3.023210
128,3.006550
256,3.052890
512,3.005860
1024,2.995740
2048,3.060540
4096,2.994000
8192,3.076960
16384,3.008020
32768,3.046970
65536,3.040360
131072,3.092490
262144,3.138090
524288,3.187000
1048576,2.986230
2097152,3.074310
4194304,3.280390
8388608,3.608900
16777216,4.278090
33554432,5.508340
---
67108864, 7.90407 ms
134217728, 13.3829 ms

=== max_element with bolt ===
size,time (ms)
2,0.239094
4,0.242006
8,0.242288
16,0.243363
32,0.242257
64,0.243461
128,0.243329
256,0.241237
512,0.413800
1024,0.520461
2048,0.729220
4096,1.151180
8192,1.964450
16384,3.618160
32768,6.824630
65536,11.551800
131072,22.584200
262144,28.026900
524288,28.072100
1048576,27.904700
2097152,28.255900
4194304,28.788000
8388608,26.075500
16777216,25.414200
33554432,28.391500

pr_improving_find_extrema branch:
=== max_element with compute ===
size,time (ms)
2,2.951420
4,3.024390
8,2.964650
16,3.017970
32,3.006210
64,3.144770
128,3.117730
256,3.126830
512,3.064650
1024,3.069900
2048,3.055710
4096,3.098720
8192,3.127860
16384,3.130310
32768,3.098050
65536,3.114520
131072,3.190490
262144,3.240010
524288,3.252840
1048576,3.347880
2097152,3.471760
4194304,3.582500
8388608,3.625560
16777216,4.242310
33554432,5.249320
---
67108864, 7.20043 ms
134217728, 11.2549 ms

However, when worst case scenario is used, i.e. vector contains elements from 0 to vector.size() - 1, performance of  find_extema_with_atomics decreases.
int global = 0;
int next_int()
{
    return global++;
}

When function next_int() is used to fill vector instead of rand_int(), performance of find_extema_reduce remains the same, but performance of  find_extema_with_atomics decreases:
2097152,5.000910
4194304,6.930040
8388608,10.957300
16777216,18.637500
33554432,34.256900

Another argument for merging this PR is fact that find_extema_reduce work for OpenCL 1.0, when current find_extema_with_atomics  does not (I have to say that I don't no why it does not work).

Looks good, left a few inline comments. Benchmark numbers look great!

Thanks for all your comments! That's why I like code reviews and four-eyes principle.

I removed out-of-order queue check and printf pragma. I added parameter_cache for work group size and number of work groups per compute unit.

Thanks! Merged!

Great!
I think after GSoC'15 (or earlier if I will have time) I will add support for custom comparison function for find_extrema (therefore for max_element() and min_element()). I'll create issue for this.
@pavanky Thanks for your input!


mmSpoof changes

This has two changes

modified mmSpoof.md file as per the reference from Agrim
added two images to support the changes

Do a pull request to ucsdwcsng/ucsdwcsng.github.io  branch


Failing to compile manually

I can't get the latest version to compile manually. I thought it maybe had something to do with a patch I applied, but I exited the directory, removed the whole cloned directory, re-cloned it just to make sure everything was fresh, and tried again, with the same issue. Something during ninja install is causing an error, and I can't figure out for the life of me what it is. It always errors out at a different step. Sometimes it doesn't error out until the very end, sometimes it's at the very beginning. It worked just fine for me on the previous version. Here is the output for meson --cross-file build-win64.txt --buildtype release --prefix /home/matt/dxvk build.w64:
The Meson build system
Version: 0.52.1
Source dir: /home/matt/gits/dxvk
Build dir: /home/matt/gits/dxvk/build.w64
Build type: cross build
Project name: dxvk
Project version: v1.5
C compiler for the build machine: ccache cc (gcc 9.2.0 "cc (GCC) 9.2.0")
C linker for the build machine: GNU ld.bfd 2.33.1
C++ compiler for the build machine: ccache c++ (gcc 9.2.0 "c++ (GCC) 9.2.0")
C++ linker for the build machine: GNU ld.bfd 2.33.1
C compiler for the host machine: x86_64-w64-mingw32-gcc (gcc 9.2.0 "x86_64-w64-mingw32-gcc (GCC) 9.2.0")
C linker for the host machine: GNU ld.bfd 2.33.1
C++ compiler for the host machine: x86_64-w64-mingw32-g++ (gcc 9.2.0 "x86_64-w64-mingw32-g++ (GCC) 9.2.0")
C++ linker for the host machine: GNU ld.bfd 2.33.1
Build machine cpu family: x86_64
Build machine cpu: x86_64
Host machine cpu family: x86_64
Host machine cpu: x86_64
Target machine cpu family: x86_64
Target machine cpu: x86_64
Checking if "winelib check" compiles: NO (cached)
Program x86_64-w64-mingw32-windres found: YES (/usr/bin/x86_64-w64-mingw32-windres)
Library vulkan-1 found: YES
Library d3d9 found: YES
Library d3d11 found: YES
Library dxgi found: YES
Library d3dcompiler_43 found: YES
Library d3dcompiler_47 found: YES
Program glslangValidator found: YES (/usr/local/bin/glslangValidator)
Dependency threads found: YES (cached)
Dependency threads found: YES (cached)
Build targets in project: 13
Found ninja-1.9.0 at /usr/bin/ninja

After cd build.w64; ninja install, like I said it's different every time but here's the output starting at the first error for the most recent attempt:
[44/247] Compiling C++ object 'src/vulkan/67fefa6<EMAIL_ADDRESS>FAILED: src/vulkan/67fefa6<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/vulkan/67fefa6@@vkcommon@sta -Isrc/vulkan -I../src/vulkan -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -pthread -MD -MQ 'src/vulkan/67fefa6<EMAIL_ADDRESS>-MF 'src/vulkan/67fefa6<EMAIL_ADDRESS>-o 'src/vulkan/67fefa6<EMAIL_ADDRESS>-c ../src/vulkan/vulkan_loader.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/vulkan/../util/rc/util_rc_ptr.h:3,
                 from ../src/vulkan/vulkan_loader.h:4,
                 from ../src/vulkan/vulkan_loader.cpp:1:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[45/247] Compiling C++ object 'src/spirv/e922df6<EMAIL_ADDRESS>FAILED: src/spirv/e922df6<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/spirv/e922df6@@spirv@sta -Isrc/spirv -I../src/spirv -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/spirv/e922df6<EMAIL_ADDRESS>-MF 'src/spirv/e922df6<EMAIL_ADDRESS>-o 'src/spirv/e922df6<EMAIL_ADDRESS>-c ../src/spirv/spirv_code_buffer.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/spirv/../util/rc/util_rc_ptr.h:3,
                 from ../src/spirv/spirv_include.h:12,
                 from ../src/spirv/spirv_instruction.h:6,
                 from ../src/spirv/spirv_code_buffer.h:8,
                 from ../src/spirv/spirv_code_buffer.cpp:4:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[46/247] Compiling C++ object 'src/spirv/e922df6<EMAIL_ADDRESS>FAILED: src/spirv/e922df6<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/spirv/e922df6@@spirv@sta -Isrc/spirv -I../src/spirv -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/spirv/e922df6<EMAIL_ADDRESS>-MF 'src/spirv/e922df6<EMAIL_ADDRESS>-o 'src/spirv/e922df6<EMAIL_ADDRESS>-c ../src/spirv/spirv_module.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/spirv/../util/rc/util_rc_ptr.h:3,
                 from ../src/spirv/spirv_include.h:12,
                 from ../src/spirv/spirv_instruction.h:6,
                 from ../src/spirv/spirv_code_buffer.h:8,
                 from ../src/spirv/spirv_module.h:5,
                 from ../src/spirv/spirv_module.cpp:3:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[47/247] Compiling C++ object 'src/vulkan/67fefa6<EMAIL_ADDRESS>FAILED: src/vulkan/67fefa6<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/vulkan/67fefa6@@vkcommon@sta -Isrc/vulkan -I../src/vulkan -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -pthread -MD -MQ 'src/vulkan/67fefa6<EMAIL_ADDRESS>-MF 'src/vulkan/67fefa6<EMAIL_ADDRESS>-o 'src/vulkan/67fefa6<EMAIL_ADDRESS>-c ../src/vulkan/vulkan_presenter.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/vulkan/../util/rc/util_rc_ptr.h:3,
                 from ../src/vulkan/vulkan_loader.h:4,
                 from ../src/vulkan/vulkan_presenter.h:11,
                 from ../src/vulkan/vulkan_presenter.cpp:1:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[48/247] Compiling C++ object 'src/spirv/e922df6<EMAIL_ADDRESS>FAILED: src/spirv/e922df6<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/spirv/e922df6@@spirv@sta -Isrc/spirv -I../src/spirv -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/spirv/e922df6<EMAIL_ADDRESS>-MF 'src/spirv/e922df6<EMAIL_ADDRESS>-o 'src/spirv/e922df6<EMAIL_ADDRESS>-c ../src/spirv/spirv_compression.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/spirv/../util/rc/util_rc_ptr.h:3,
                 from ../src/spirv/spirv_include.h:12,
                 from ../src/spirv/spirv_instruction.h:6,
                 from ../src/spirv/spirv_code_buffer.h:8,
                 from ../src/spirv/spirv_compression.h:5,
                 from ../src/spirv/spirv_compression.cpp:1:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[49/247] Compiling C++ object 'src/dxbc/5c53ffa<EMAIL_ADDRESS>FAILED: src/dxbc/5c53ffa<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/dxbc/5c53ffa@@dxbc@sta -Isrc/dxbc -I../src/dxbc -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-MF 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-o 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-c ../src/dxbc/dxbc_chunk_shex.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/dxbc/../dxvk/../util/rc/util_rc_ptr.h:3,
                 from ../src/dxbc/../dxvk/dxvk_include.h:14,
                 from ../src/dxbc/../dxvk/dxvk_shader.h:5,
                 from ../src/dxbc/dxbc_include.h:3,
                 from ../src/dxbc/dxbc_common.h:3,
                 from ../src/dxbc/dxbc_chunk_shex.h:3,
                 from ../src/dxbc/dxbc_chunk_shex.cpp:1:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[50/247] Compiling C++ object 'src/dxbc/5c53ffa<EMAIL_ADDRESS>FAILED: src/dxbc/5c53ffa<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/dxbc/5c53ffa@@dxbc@sta -Isrc/dxbc -I../src/dxbc -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-MF 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-o 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-c ../src/dxbc/dxbc_chunk_isgn.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/dxbc/../dxvk/../util/rc/util_rc_ptr.h:3,
                 from ../src/dxbc/../dxvk/dxvk_include.h:14,
                 from ../src/dxbc/../dxvk/dxvk_shader.h:5,
                 from ../src/dxbc/dxbc_include.h:3,
                 from ../src/dxbc/dxbc_common.h:3,
                 from ../src/dxbc/dxbc_chunk_isgn.h:5,
                 from ../src/dxbc/dxbc_chunk_isgn.cpp:1:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[51/247] Compiling C++ object 'src/dxbc/5c53ffa<EMAIL_ADDRESS>FAILED: src/dxbc/5c53ffa<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/dxbc/5c53ffa@@dxbc@sta -Isrc/dxbc -I../src/dxbc -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-MF 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-o 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-c ../src/dxbc/dxbc_defs.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/dxbc/../dxvk/../util/rc/util_rc_ptr.h:3,
                 from ../src/dxbc/../dxvk/dxvk_include.h:14,
                 from ../src/dxbc/../dxvk/dxvk_shader.h:5,
                 from ../src/dxbc/dxbc_include.h:3,
                 from ../src/dxbc/dxbc_enums.h:3,
                 from ../src/dxbc/dxbc_defs.h:3,
                 from ../src/dxbc/dxbc_defs.cpp:1:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[52/247] Compiling C++ object 'src/util/ed6d25d<EMAIL_ADDRESS>FAILED: src/util/ed6d25d<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/util/ed6d25d@@util@sta -Isrc/util -I../src/util -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/util/ed6d25d<EMAIL_ADDRESS>-MF 'src/util/ed6d25d<EMAIL_ADDRESS>-o 'src/util/ed6d25d<EMAIL_ADDRESS>-c ../src/util/com/com_guid.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/util/com/../../d3d11/../dxgi/../dxvk/../util/rc/util_rc_ptr.h:3,
                 from ../src/util/com/../../d3d11/../dxgi/../dxvk/dxvk_include.h:14,
                 from ../src/util/com/../../d3d11/../dxgi/dxgi_interfaces.h:3,
                 from ../src/util/com/../../d3d11/d3d11_interfaces.h:3,
                 from ../src/util/com/com_guid.cpp:3:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[53/247] Compiling C++ object 'src/dxbc/5c53ffa<EMAIL_ADDRESS>FAILED: src/dxbc/5c53ffa<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/dxbc/5c53ffa@@dxbc@sta -Isrc/dxbc -I../src/dxbc -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-MF 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-o 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-c ../src/dxbc/dxbc_common.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/dxbc/../dxvk/../util/rc/util_rc_ptr.h:3,
                 from ../src/dxbc/../dxvk/dxvk_include.h:14,
                 from ../src/dxbc/../dxvk/dxvk_shader.h:5,
                 from ../src/dxbc/dxbc_include.h:3,
                 from ../src/dxbc/dxbc_common.h:3,
                 from ../src/dxbc/dxbc_common.cpp:1:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[54/247] Compiling C++ object 'src/util/ed6d25d<EMAIL_ADDRESS>FAILED: src/util/ed6d25d<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/util/ed6d25d@@util@sta -Isrc/util -I../src/util -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/util/ed6d25d<EMAIL_ADDRESS>-MF 'src/util/ed6d25d<EMAIL_ADDRESS>-o 'src/util/ed6d25d<EMAIL_ADDRESS>-c ../src/util/config/config.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/algorithm:62,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/regex:38,
                 from ../src/util/config/config.cpp:4:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[55/247] Compiling C++ object 'src/dxvk/1752c3e<EMAIL_ADDRESS>FAILED: src/dxvk/1752c3e<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/dxvk/1752c3e@@dxvk@sta -Isrc/dxvk -I../src/dxvk -I.././include -I. -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -pthread -MD -MQ 'src/dxvk/1752c3e<EMAIL_ADDRESS>-MF 'src/dxvk/1752c3e<EMAIL_ADDRESS>-o 'src/dxvk/1752c3e<EMAIL_ADDRESS>-c ../src/dxvk/dxvk_shader.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/dxvk/../util/rc/util_rc_ptr.h:3,
                 from ../src/dxvk/dxvk_include.h:14,
                 from ../src/dxvk/dxvk_shader.h:5,
                 from ../src/dxvk/dxvk_shader.cpp:1:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[56/247] Compiling C++ object 'src/dxbc/5c53ffa<EMAIL_ADDRESS>FAILED: src/dxbc/5c53ffa<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/dxbc/5c53ffa@@dxbc@sta -Isrc/dxbc -I../src/dxbc -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-MF 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-o 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-c ../src/dxbc/dxbc_analysis.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/dxbc/../dxvk/../util/rc/util_rc_ptr.h:3,
                 from ../src/dxbc/../dxvk/dxvk_include.h:14,
                 from ../src/dxbc/../dxvk/dxvk_shader.h:5,
                 from ../src/dxbc/dxbc_include.h:3,
                 from ../src/dxbc/dxbc_common.h:3,
                 from ../src/dxbc/dxbc_chunk_isgn.h:5,
                 from ../src/dxbc/dxbc_analysis.h:3,
                 from ../src/dxbc/dxbc_analysis.cpp:1:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
[57/247] Compiling C++ object 'src/dxbc/5c53ffa<EMAIL_ADDRESS>FAILED: src/dxbc/5c53ffa<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/dxbc/5c53ffa@@dxbc@sta -Isrc/dxbc -I../src/dxbc -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-MF 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-o 'src/dxbc/5c53ffa<EMAIL_ADDRESS>-c ../src/dxbc/dxbc_compiler.cpp
In file included from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_algo.h:61,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/functional:65,
                 from ../src/dxbc/../spirv/../util/rc/util_rc_ptr.h:3,
                 from ../src/dxbc/../spirv/spirv_include.h:12,
                 from ../src/dxbc/../spirv/spirv_instruction.h:6,
                 from ../src/dxbc/../spirv/spirv_code_buffer.h:8,
                 from ../src/dxbc/../spirv/spirv_module.h:5,
                 from ../src/dxbc/dxbc_compiler.h:6,
                 from ../src/dxbc/dxbc_compiler.cpp:1:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h: In function ‘void std::pop_heap(_RAIter, _RAIter, _Compare)’:
/usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h:320:51: error: expected ‘)’ before ‘;’ token
  320 |    std::__pop_heap(__first,(__last, __last, __cmp);
      |                   ~                               ^
      |                                                   )
ninja: build stopped: subcommand failed.

As you can see from the meson command I have all the dependencies (the winelib check has always said no, I can't figure that whole thing out but I don't think it matters here), and I haven't edited any files, like I said this fails with a completely fresh cloned repo. Doing it the "easy way" from the guide, using package-release.sh also fails with the same errors at the same step.
System information

GPU: AMD Radeon RX 580
Driver: xf86-video-amdgpu, mesa-aco-git 20.0.0_devel
Wine version: Staging 4.21
DXVK version: 1.5-3
OS: Arch Linux kernel 5.4.5-arch1-1

Something is borked in your STL for some reason. Where did you get your mingw from?

From the AUR? I just reinstalled it, too. Do I need it from somewhere else?

These are the packages I have installed according to yay -Q | grep -i mingw
mingw-w64-binutils 2.33.1-1
mingw-w64-crt 7.0.0-1
mingw-w64-gcc 9.2.0-1
mingw-w64-headers 7.0.0-1
mingw-w64-winpthreads 7.0.0-1

Weird. I'm running the exact same versions and it's working fine here :woman_shrugging:
However, line 320 in /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/stl_heap.h looks different here:
	  std::__pop_heap(__first, __last, __last, __cmp);

So, uh, maybe try reinstalling mingw-w64-gcc or try fixing it manually, I guess.

Oh my god this is driving me insane. So, I went to reinstall mingw-w64-gcc, and it absolutely will not build, which has been an issue before.  I know that's not your purview. Anyway, So I then decided to just go ahead and edit the file manually as you suggested. The line is the exact same as what you said yours looks like. Like that second weird parenthesis that shows up in the error isn't in my file. Now when I try to run ninja install I get a different error:
[55/182] Generating 'src/d3d11/bca5607<EMAIL_ADDRESS>../src/d3d11/../dxgi/shaders/dxgi_presenter_vert.vert
[57/182] Generating 'src/d3d11/bca5607<EMAIL_ADDRESS>../src/d3d11/../dxgi/shaders/dxgi_presenter_frag.frag
[82/182] Compiling C++ object 'src/d3d...5607<EMAIL_ADDRESS>FAILED: src/d3d11/bca5607<EMAIL_ADDRESS>x86_64-w64-mingw32-g++ -Isrc/d3d11/bca5607@@d3d11@sha -Isrc/d3d11 -I../src/d3d11 -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/d3d11/bca5607<EMAIL_ADDRESS>-MF 'src/d3d11/bca5607<EMAIL_ADDRESS>-o 'src/d3d11/bca5607<EMAIL_ADDRESS>-c ../src/d3d11/d3d11_buffer.cpp
In file included from /usr/x86_64-w64-mingw32/include/corecrt.h:10,
                 from /usr/x86_64-w64-mingw32/include/crtdefs.h:10,
                 from /usr/x86_64-w64-mingw32/include/stddef.h:7,
                 from /usr/lib/gcc/x86_64-w64-mingw32/9.2.0/include/stddef.h:1,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/cxxabi_init_exception.h:38,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/bits/exception_ptr.h:38,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/exception:143,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/stdexcept:38,
                 from /usr/x86_64-w64-mingw32/include/c++/9.2.0/array:39,
                 from ../src/d3d11/../dxvk/../util/log/log.h:3,
                 from ../src/d3d11/../dxvk/dxvk_include.h:3,
                 from ../src/d3d11/../dxvk/dxvk_device_info.h:3,
                 from ../src/d3d11/../dxvk/dxvk_adapter.h:3,
                 from ../src/d3d11/../dxvk/dxvk_device.h:3,
                 from ../src/d3d11/d3d11_buffer.h:3,
                 from ../src/d3d11/d3d11_buffer.cpp:1:
/usr/x86_64-w64-mingw32/include/ocidl.h:2441:1: internal compiler error: Segmentation fault
 2441 | __CRT_UUID_DECL(IPropertyPageSite, 0xb196b28c, 0xbab4, 0x101a, 0xb6,0x9c, 0x00,0xaa,0x00,0x34,0x1d,0x07)
      | ^~~~~~~~~~~~~~~
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://gcc.gnu.org/bugs/> for instructions.
[95/182] Compiling C++ object 'src/d3d...607<EMAIL_ADDRESS>ninja: build stopped: subcommand failed.

I have no idea what the deal is, but I've tried it on an Arch install and 2 different Manjaro installs.  Oh well, it's not DXVK so I guess I'll have to figure something else out.

Are you running a first-gen Ryzen CPU by any chance? I heard from multiple users that GCC 9.2 causes some trouble with those for some reason.

I'm running second-gen, but I think it was a memory issue having my RAM clocked at 3200MHz, GloriousEggroll told me first and second-gen ryzen seem to not like going above 3000MHz. I lowered it to 3000MHz and it works.


Ministry User Create Institution

- Additional Context

This feature is required for the Business BCeID alternate solution.
Steps for a basic BCeID to have access

Ministry User Creates Institution Account
Ministry User Add's admin user to that location
Institution user logs in and finishes account setup (programs, locations), designation, adjusting roles, etc
If additional users are required for a BASIC BCeID institution, ministry users are required to add

- Acceptance Criteria

[ ] On Ministry portal, Add "Create Institution" to top nav
[ ] On click of "Create Institution" display the "institution details" form
[ ] The Legal operating name will be entered by a ministry user
[ ] On click of "Submit" create the institution account

- Tech Notes

Institution guid=null

Future Q for @abschwenker FYI: Should Basic BCeID users be able to edit operating legal authority field? CC: @andrewsignori-aot


Copy the currentContext into the cache when it's still valid

This fixes a problem where the cache was lost after a successful pickup of the cache. So to repro:

Run with happypack, generate cache
Run again, see the cache get picked up
Run again, see the cache go missing

With this patch, 3 successfully picks up the cache

Nice catch! This reminds me to add some coverage around the cache. Thanks for fixing :grin: