bug: Mobile browser on scroll status bar not hidden. A 4 years old BUG!!

Hi,
It's the second time I asked it.
You say in your website that with Ionic you can have a mobile website and an app with the same code but you lied!
I spent months to develop my app+website and now the website really sucks, the problem is this: https://github.com/ionic-team/ionic/issues/19081 and people asked about it 4 years ago.
With angular there is no problems, on Ionic yes.
Please if you can't fix it give me a work around because my website now seems an old fashion one and it's not really good. Here if you want to try it: https://roomlessrent.com

Thanks for the issue. As stated in the bug report you linked to, we are not scrolling on the body element which is why you are experiencing this behavior. Safari listens for scrolling on the body element in order to know when to collapse/show the address bar.
The issue you linked to provides a temporary workaround that you can use while we investigate alternatives. I am going to close this issue in favor of the one you linked to. Thanks!


Pytorch solves gym environments faster than tensorflow using the same training implementation and network architecture

Issue type
Performance
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf2.13
Custom code
Yes
OS platform and distribution
Ubuntu 22.04.2 LTS
Mobile device
No response
Python version
3.10.12
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
11.8
GPU model and memory
T4 GPU
Current behavior?
I have encountered a performance difference between my PyTorch and TensorFlow implementations of the Double Deep Q-Network (DDQN) algorithm in a Gym environment. Both implementations share identical DDQN architectures, exploration routines, and training flows. However, the PyTorch implementation consistently converges faster, requiring fewer episodes to solve the environment.
Details:
Network and Training Flow: Both PyTorch and TensorFlow implementations employ the same dense neural network architecture (two hidden layers of [512, 128]) and training procedures. The timing for weight optimization is nearly identical between the two.
Exploration: Identical exploration strategies are employed in both implementations, ensuring consistency in agent behavior. Both of them use epsilon-greedy exploration.
The optimization code for each framework is:
Tensorflow:
@tf.function
def optimize_model(self,
                   experiences,
                   max_gradient_norm = float('inf')):
    states, actions, rewards, next_states, is_terminals = experiences
    #batch_size = len(is_terminals)

    with tf.GradientTape() as tape:

        # We get the argmax (or maximum action index using the online network)
        argmax_a_q_sp = tf.argmax(self.online_model(next_states), axis=1)
        # Then we use the target model to calculate the estimated Q-values
        q_sp = tf.stop_gradient(self.target_model(next_states))

        # And extract the max value using the index gotten with the online model
        max_a_q_sp = tf.expand_dims(tf.gather(q_sp, argmax_a_q_sp, axis = 1)[:,0], axis = 1)
        # Then we start computing the loss value
        target_q_sa = rewards + (self.gamma * max_a_q_sp * (1 - is_terminals))

        # Flatten the column_indices tensor
        actions_ = tf.reshape(actions, [-1])

        # Use tf.range to create row indices
        row_indices = tf.range(actions_.shape[0])
        row_indices = tf.cast(row_indices, tf.int64)
        # Create combined indices
        combined_indices = tf.stack([row_indices, actions_], axis=1)

        # Gather elements from the second tensor using combined indices
        q_sa = tf.gather_nd(self.online_model(states), combined_indices)
        q_sa = tf.reshape(q_sa, (-1, 1))

        #q_sa = tf.gather(self.online_model(states), actions, axis=1)
        td_error = q_sa - target_q_sa
        value_loss = tf.reduce_mean(tf.square(td_error) * 0.5)
    variables = self.online_model.trainable_variables
    gradients = tape.gradient(value_loss, variables)

    self.value_optimizer.apply_gradients(zip(gradients, self.online_model.trainable_variables))

Pytorch:
def optimize_model(self,
                       experiences,
                       max_gradient_norm = float('inf')):

        states, actions, rewards, next_states, is_terminals = experiences
        batch_size = len(is_terminals)
        # We get the argmax (or maximum action index using the online network)
        argmax_a_q_sp = self.online_model(next_states).max(1)[1]
        # Then we use the target model to calculate the estimated Q-values
        q_sp = self.target_model(next_states).detach()
        # And extract the max value using the index gotten with the online model
        max_a_q_sp = q_sp[np.arange(batch_size), argmax_a_q_sp].unsqueeze(1)

        # Then we start computing the loss value
        target_q_sa = rewards + (self.gamma * max_a_q_sp * (1 - is_terminals))
        q_sa = self.online_model(states).gather(1, actions)

        td_error = q_sa - target_q_sa
        value_loss = td_error.pow(2).mul(0.5).mean()
        self.value_optimizer.zero_grad()
        value_loss.backward()
        #torch.nn.utils.clip_grad_norm_(self.online_model.parameters(), max_gradient_norm)
        self.value_optimizer.step()

I'm seeking guidance on potential factors that might explain this performance gap. Could variations in internal library optimizations, autograd systems, GPU utilization, or other factors play a role in this discrepancy? Any insights or suggestions for further investigation would be greatly appreciated.
You can access to an example by following this link:

Standalone code to reproduce the issue
You can find the code in this GitHub repository: [GitHub Repository](https://github.com/LuisFMCuriel/SwarmyMcQLearny).

Alternatively, you can easily access an example by following this link to a Colab notebook:
[![Open In Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/LuisFMCuriel/SwarmyMcQLearny/blob/main/notebooks/SwarmyMcQLearny.ipynb)

Relevant log output
No response

Hello, @LuisFMCuriel ! Could you please have a look at this gist where I tried to replicate the error reported?
Thank you!

Hi @sushreebarsa ! Thanks for the quick replay. Yes, I confirm the result. Running the example for each (for example for 60 episodes), the tensorflow implementation has an elapsed time of 00:00:37 whereas the pytorch implementation has an elapsed time of only 00:00:09, having roughly the same reward (these numbers might change since seed is not set, but the behaviour is the same every time you run it). Is this a problem with my implementation of the neural gradient optimization? The program gives you the optimization time, and it looks to be approximately the same for both, so I am not sure where is the timing bottleneck.
Thanks again for the time!!


updating freegeoip zipcode response format

It appears freegeoip's format for their response JSON has changed. It now uses zip_code. See this example:
https://freegeoip.net/json/github.com

Can you fix the test for freegoip geocoder ?

Should be fixed now.

Sorry about adding commit 299f5f1 to this PR. Would you prefer it on a separate PR instead?

Thanks for the test fix


uv run always installs project even already installed in editable mode

uv version: 0.2.3

I have setup a python project with pyproject.yaml, and installed it in editable mode using uv pip install -e ..
When invoking uv run, it always installs the project in build directory:
$ uv run ls
warning: `uv run` is experimental and may change without warning.
Resolved 40 packages in 14ms
Uninstalled 1 package in 0.59ms
Installed 1 package in 23ms
 - <project_name>==1.0.0 (from file:///workspace)
 + <project_name>==1.0.0 (from file:///home/vigilans/...)

And resolved / audited log always pop up in all uv run executions:
$ uv run echo
warning: `uv run` is experimental and may change without warning.
Resolved 40 packages in 16ms
Audited 40 packages in 0.05ms

If .venv folder is not writable, the log will be
$ uv run ls
warning: `uv run` is experimental and may change without warning.
Resolved 40 packages in 415ms
error: failed to remove file `/workspace/.venv/lib/python3.7/site-packages/__editable__.<project_name>-1.0.0.pth`
  Caused by: Permission denied (os error 13)

Seems it tries to revert the editable mode and install in dist mode (what Uninstall 1 packages and Install 1 packages in first log is).
It would be better if installation in editable mode also works for uv run.

This is covered by #3628. Thanks!


Live Preview doesnt work on first load

Inline Admonitions dont seem to work in Live Preview mode until the app is reloaded.

Fixed in 1.4.6


Pin version of requests package

A bit of testing is required.
It looks like gql[requests] pulls a version of requests that is not compatible with urllib 2.x.
Result is the following error:
cannot import name 'appengine' from 'requests.packages.urllib3.contrib'
Possible solutions:

Pin the version of requests to something compatible with gql 3.4.0 and urllib 2.x
Pin the version of urllib to 1.x

Does the PR fix this issue?

It does solve the problem but I have not looked if it is a known issue. Only found information that the error is related to urllib3 and requests compatibility.
Looking at gql and requests requirements my guess is pip is not resolving the deps correctly and the following happens.

gql pulls requests < 3
requests pulls urllib3 < 3 (In our case urllib3 2.x ignoring gql requirements for urllib3 < 2)?

gql
https://github.com/graphql-python/gql/blob/d140b830cd47fea5513b6bc30b1289c6416d25df/setup.py#LL44C1-L48C2
install_requests_requires = [
    "requests>=2.26,<3",
    "requests_toolbelt>=0.9.1,<1",
    "urllib3>=1.26,<2",
]

requests
https://github.com/psf/requests/blob/6e5b15d542a4e85945fd72066bb6cecbc3a82191/setup.py#LL61C1-L66C2
requires = [
    "charset_normalizer>=2,<4",
    "idna>=2.5,<4",
    "urllib3>=1.21.1,<3",
    "certifi>=2017.4.17",
]

Problem was fixed in gql 3.4.1. Upgrading it is the better fix.
https://github.com/graphql-python/gql/issues/412


Add eczanemveben.com to domain list

Add eczanemveben.com to domain list

I would rather not add a specific domain to the blocklist.
You are able to add your own keywords to a fork of the list, if you like.
Otherwise, I will add a few terms and phrases found in the comment screenshot you provided.
browsed your web
browsed that web
browse your web
browse that web
dermocosmetics product
dermocosmetics-product
dermocosmetic product
dermocosmetic-product

Thanks, agreed


maintainers: add sstef

Motivation for this change
Add a new maintainer before being able to add new packages
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

welcome aboard


Make errors from Save thread propagate to main thread

Basically, if the save function has an uncaught exception and the error isn't correctly sent to the main thread, then the GUI will crash.
https://stackoverflow.com/questions/2829329/catch-a-threads-exception-in-the-caller-thread

Should implement this logic for all threads, but the saving thread I think is the current problem

From linked website, I'm seeing that a couple of good ways to handle errors from outside main thread would be:

ThreadPoolExecutor
overwriting the Thread class exception hook

I don't think these methods stop crashes, but we should be able to at least log the error before the crash which will help solve the root problem.

Maybe something like this could work?


[python] Bindings for upgrade_domain

Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Connects #3220 to the Python user-facing layers.
Notes for Reviewer:
I was going to do Python+R on a single PR but the line count is ~400 which is enough (IMO) so I'll make a separate for R -- cc @mojaveazure

@nguyenv ready for next round!

Thanks @nguyenv !


Update dependency androidx.core:core-ktx to v1.10.1

This PR contains the following updates:

Package
Type
Update
Change

androidx.core:core-ktx (source)
dependencies
minor
1.2.0 -> 1.10.1

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Release notes:
https://developer.android.com/jetpack/androidx/releases/core

Lots of fixes
Significant clean-up of nullability annotations to improve Kotlin usability
Added @RequiresPermission to APIs that require granting the POST_NOTIFICATIONS permission on SDK 33 and above.
No breaking changes found that affect this library


Delete empty file : _.js

This file _.js is empty.
So, I am removing it to make codebase cleaner.
If in case you are thinking of adding code to it, later on.
Then, It can be added back at that time until then, let's make our codebase cleaner and contributable.

BTW, Loved Your Project Man !

Thanks for the contribution! I used this file while testing the extension but you're right.


minor gamma cleanups.

This should arguably should use Base.@assume_effects :terminates_locally but that only exists on 1.8+.

Awesome! I'm wondering if we should go ahead and solve https://github.com/JuliaMath/Bessels.jl/issues/58 here.
Essentially, that issue can be solved by having some check if x is an integer and (x < 21) to just return the base factorial lookup table....  I'd honestly be fine just to have a different dispatch for it. So you would only hit that branch if you input an integer nu but I guess we could also check for it within the routines... but it seems way easier to do it here than update all of the functions. Something like
function gamma(x::Integer)
    if x < 21
        if x > 0
            return float(factorial(x - 1))
        elseif x < 0
            return DomainError...
        else
            return Float64(Inf)
        end
    else
        return gamma(Float64(x))
    end
end

Great - I'll merge and test if this solves that issue.


Reddit section is outdated

Reddit section has almost only dead services.

Yes. Have to cross them out.


[feature request]  legit addremove

It would be nice to improve the git command live API by replacing
git add . -vA

with
legit addremove

similiar to the way Mercurial does it.

git add -A is similar enough to hg's addremove.


Adding defectDojo_engagement_survey to Installed Apps

After the merge of PR # 1601, the dev branch was throwing the error specified below.
RuntimeError: Model class defectDojo_engagement_survey.models.Question doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS. error
This commits addresses the error by adding the engagement_survey  to installed apps.

@Maffooch Please check if I am doing this correctly.

It’s already included on line 446. Not sure what the issue is. I’ll look into.

I cant reproduce this issue. Don't know what the deal is. #1601 passed all the travis checks as well.

I've the same issue after a merge from dev.

I also ran into an issue today, running a docker-compose build, with the following message:
django.core.exceptions.ImproperlyConfigured: Application labels aren't unique, duplicates: defectDojo_engagement_survey
It seems it made it through another PR somehow... like @Maffooch 's 4 months ago? what..?

So yea, something was/is weird. Had the issue in one env, but not the other.

I have a theory here, but not sure if it's accurate. Pulling changes made to settings.py.dist do not update settings.py unless the entire file is copied over. If there was any sort of overwrite, the users personal settings in settings.py would be blown out. This explains why I couldn't reproduce the error with a fresh instance and why @dougmorato's fix was to include it as in app in settings.py.
Whether this theory is correct or not, this pull request will not fix it because it's adding the same app twice a few lines apart.


Make Architecture Diagrams available in Visio format for download

I love these articles but it is very difficult to review the diagrams, even at 200 magnification in the browser.  It would be great to get them in source format to review as well as use as a basis for our own architecture diagrams.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81712a5d-c3c2-f49b-17f8-559a8011aa84
Version Independent ID: d0c0d5e5-4b61-26c1-570f-24654eef4b57
Content: Develop a secure Azure AD Web application
Content Source: articles/security/develop/secure-aad-app.md
Service: security
GitHub Login: @TerryLanfear
Microsoft Alias: terrylan

@robcamer Thank you for your feedback! We have assigned this issue to the author to review further and take the right course of action.

This content has been archived and is no longer being updated.
#please-close


Add extractingByKey(Object, InstanceOfAssertFactory) to AbstractMapAssert

Also PR for release notes: assertj/doc#19
Check List:

Fixes N/A
Unit tests : YES
Javadoc with a code example (on API only) : YES

Closed by my reference mistake 😅 reopening it

@joel-costigliola PR ready!

Integrated thanks @scordio!


macOS 10.14 Mojave support

It seems that current versions do not support the latest macOS.

@raynexuslin, could you, please, describe the problem more detailed?

I'm so sorry. This was a mistake on my side. Sorry for any inconvenience caused. TBB is working properly on macOS Mojave.

Actually, I meant to say that non of the release versions on Github release notes indicate support for macOS 10.14. However, I later tried installing TBB via Homebrew and it was a success. It runs properly as well. Sorry again for opening a random issue. There is no problem with TBB.


Support new C# styles

ImplicitUsing
In .NET 6 SDK cli:
dotnet new console

Source code results only 1 line:
Console.WriteLine("Hello world");

That code is placed into global namespace. IL2C currently doesn't support any global namespaces.
Nullable
Any nullable reference types don't affect any IL code, but it requires to implement by some attribute types.
IL2C currently doesn't have Attribute base type.
In IL2C, it may be better to just define an Attribute type, since (for now) all attributes are simply ignored.

In 3400c23ddaf1124e0f831cc366265e7efa2dd8f8, found same problem for global function in built net6.0 tfm.
This tfm always created Main() method and assigned for entry point attribute on library assembly.


Keyboard Navigation Mode

[ Problem ]

User Action

Click Empty Space on Explorer
Shift + Arrow (Up/Down) for selecting files
= it dont select first file.
= VSCode Explorer is KeyboardNavigation is [Hight Mode]
= But I'd like to use this with [Select Mode]

this is really important to only keyboard user.
[ Feature ]
When i try [Fleet IDE], it has KeyboardNavigation mode.

Select : Normal Select for Keyboard Arrow
Highlight : User cant select first item with Shift + Arrow

Maybe I'm confused. I can understand the confusion with the shift selection not including the start element, but what is something you're unable to do with keyboard in the explorer that you'd like to do?

Maybe I'm confused. I can understand the confusion with the shift selection not including the start element, but what is something you're unable to do with keyboard in the explorer that you'd like to do?

hi sir.
i use finder ( osx ). select mode is my basic thinking. that is just my option. i think.. if user can choose option by settings, it will be good.
and i dont want to use mouse. and i want to make this the same way with finder

If focus and selection are disjoint and you're not in a multi-selection context we prefer the focused element. Even if the element doesn't appear selected all features should work as you would expect similar to finder. Let me know if you don't see that behavior

If focus and selection are disjoint and you're not in a multi-selection context we prefer the focused element. Even if the element doesn't appear selected all features should work as you would expect similar to finder. Let me know if you don't see that behavior

Shift + Up/Down
[ Fleet IDE > KeyboardNavigation > Select Mode ] = What i want

[ Fleet IDE > KeyboardNavigation > Highlight Mode ] = Now VSCode mode

[ Finder Or Default Almost Explorer > Select Mode ]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Add variable docker_machine_ssh_cidr_blocks allowing ssh ingress restriction

Description
My company uses CloudSploit (https://cloudsploit.com/) to monitor our AWS account, the current configuration causes alerts because of the ingress configuration of the docker machine instance. As such, I added the docker_machine_ssh_cidr_blocks to allow the configuration of this value like the gitlab_runner_ssh_cidr_blocks variable does.
Migrations required
No
Verification
Deployed on a private instance.
Documentation
Documentation has been updated.

@kevinrambaud fully agree the docker machine runners do not require world ingress in general. So good catch. I also spot that the current naming is not that clear. For example ssh for the resource meant for the docker machine.

@kevinrambaud @npalm What value do you guys recommend we set on the cidr? My company's infosec team also does not like the open ingress security group on ports 2376 and 22 but I dont know what value I should be setting. What needs SSH access? What needs docker port access?


Allow for multiple environments

You can now store multiple environments instead of overwriting when authenticating a new environment.
This will store environments in an array of objects to allow for this.
Now after you've added additional environments you are able to sync a specific .env by providing the server and environment ID. This is especially useful if you have multiple .env files. Eg.:
Authentication
// Add two environments
npx envault envault.server.test 1 llT8J6tEDbtJgSln
npx envault envault.server.test 2 BXYtZdNkQjtWSqE6

Syncing
npx envault 												// Will still sync .env from "1"
npx envault envault.server.test 2 --filename=.env.settings  // Will sync .env.settings from "2"

If no server and environment provided it will default to the first environment that was added for backwards compatibility.

Really like this idea. Having the ability to deal with multi-tenancy would be much easier this way.

I completely agree. This is a neat idea

Hi @danharrin, I wondered if you'd had a change to look at this PR. No rush, but would love to get your eyes on in when you get a chance.

Very sorry, I didn't have notifications enabled for this repo. Will review soon 👍

Hey, I want to make changes, but this PR is based on the main branch of the repo instead of a branch, so I can't. Can you reopen the PR from a branch please?

@tonning Just for visibility.

Thank you @danharrin for looking at this. I hope this is what you meant and this new PR helps, if not please let me know and I'll try again. Thank you 👍

No, unfortunately that didn't help. Did you have the "allow maintainers to make changes" checkbox off when you created the PR?

#13 is now merged


add guessingGame.go

What the program do?
It is a guessing game. Guess the number between 1 to 100.
In what programming language it is written?
Golang

Thanks for my first merge to GitHub.


[CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema

Description

Target

[ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[ ] I checked that each commit in the pull request has a meaningful subject line and body.

[ ] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@lburgazzoli you have some commits in this PR from seda and others that are not related. Maybe you can rebase and update this PR.

oh damn, I thought I had removed them, will rebase tomorrow

@davsclaus done

Should
"deprecated" : "false",

Not be a json boolean type (according to spec) ???
"deprecated" : false,

The order of type, description, title, etc seems to not be strict/consistent. I wonder if we can make it the same order everywhere. Sometimes description is before title, and other times its after etc.
This file will be regen more often when we fix typo, add new option, change a default etc. So it would be good to ensure the generator is 100% on all OS (not like. that XML XSD that is a bit of a pain)

@davsclaus let me have a look

Should
"deprecated" : "false",

Not be a json boolean type (according to spec) ???
"deprecated" : false,

done

The order of type, description, title, etc seems to not be strict/consistent. I wonder if we can make it the same order everywhere. Sometimes description is before title, and other times its after etc.

I have changed the json schema generation to be consistent, at least with what Jackson's ObjectMapper allows to configure. Let me know if you spot any  inconsistency

Hmm jackson still dumps it in different order. They should use a linked map so the values are in the order they are added.

Our own library camel-util-json has a basic JsonObject / JsonArray which is consistent. And JSooner has prettyPrint methods to dump

Hmm jackson still dumps it in different order. They should use a linked map so the values are in the order they are added.

can you give me an example ?

https://github.com/apache/camel/blob/3907d9991010aa7cbda1a8bb1f647911458a6cac/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/BacklogTracer.java#L350

All the dev consoles uses it as well, see core/camel-console
And mind that if you have some text then you can use the escape method to make it json safe (but you very likely do not need that, we use it to dump source code in json etc.)

Its likely a bunch of work to change so maybe create a JIRA ticket and put it as v4.1.

I mean, an example of a unordered property :)
But I think I got it so basically there were a discrepancy in the order the properties were set for types and related properties but Jackson did serialize them according to the insertion order. It should be fixed now.
I'll try to use camel-util-json later as it would mean changing a number of things now :)

Its likely a bunch of work to change so maybe create a JIRA ticket and put it as v4.1.

https://issues.apache.org/jira/browse/CAMEL-19717

ok, I think now the PR is now ready.
I did some investigation for https://issues.apache.org/jira/browse/CAMEL-19717 but I found that there is an issue with escaping https://issues.apache.org/jira/browse/CAMEL-19718 which seems not super easy to fix if we want to preserve the option to escapes forward slashes.
I will digg into that a little bit more in the coming days

LGTM
@lburgazzoli we need to merge this today so it has time to get into 4.0 GA


Consider adding a files section in package.json

Currently after install this module we are getting all these files and directories:
CHANGELOG.md  CONTRIBUTING.md  ext  http  index.js  lib  LICENSE
OLDOCS.md  package.json  README.md  test  v02  v03  v1

It would be good to add a files section in package.json to discard unneeded resources for end-user installations.
https://docs.npmjs.com/files/package.json#files

Ideally we have a src directory.

Landed in https://github.com/cloudevents/sdk-javascript/commit/f8a62b2843b12fe894201670770a00c034ab701d


Add UUID final

Related Issue
#272 has all the info we need.

@Domino987 I went ahead and merged. Please let me know if we should revert.

Looks great 👍


Confluent client unexpectedly mutates function arguments

The KafkaJS consumer unexpected mutates the inputs to some of its methods. For example, kafkaJSClient.pause(topics) will mutate the input topics by adding the .partitions key if it's undefined. I generally expect that Javascript functions treat their inputs as immutable, so I don't need to defensively clone function arguments before passing them to a library. Mutation can lead to unexpected results.
In this case, I want to call .pause(assignments) during the rebalance callback for some assignments. This is mutating the assignment objects, leading to unexpected side effects in the assignment logic.

Yes, that's right, I'll change this and check other functions, too, we shouldn't be mutating arguments.


Improving the GUI of the digital clock project

@SamarthTech I’d love to contribute to your digital clock project by improving the GUI with features like customizable themes, alarm/timer functions, and adding a date or weather display for a more dynamic experience.

@SamarthTech pls merge this pr as i have to make two more prs


Need documentation on Map Options object

There are numerous references to the object but no declarative description.

Thanks for the heads-up.
Updated the docs @ http://onury.github.io/geolocator

made a mistake. pls re-check the docs now.

Looks good. Thanks for the great code!

https://www.closient.com/


Report Directory Structure when using an outputFile name

There seems to be an issue with the report directory structure when specifying an output directory and outputFile.
Using the karma.conf:
junitReporter: {
        outputDir: 'reports/karma',
        outputFile: 'report.xml',
        suite: ''
    },

I would expect:
/reports/karma/$browserName/report.xml
/reports/karma/$browserName/report.xml
/reports/karma/$browserName/report.xml
etc etc for the various browsers, however my output appears like so:

Without specifying the outputFile the output is as expected
junitReporter: {
        outputDir: 'reports/karma',
        outputFile: undefined,
        suite: ''
    },

Are you still seeing this with 0.3.3?

This is 0.3.3, yes.
Cheers

Could you share the rest of your karma.conf? I'm having trouble reproducing.. thanks

Of course.
Cheers
// Karma configuration
// Generated on Thu Aug 06 2015 11:58:03 GMT+0100 (BST)
var webdriverConfig = {
    hostname: '<IP_ADDRESS>',
    port: 4723
}
module.exports = function(config) {

  config.set({

    // base path that will be used to resolve all patterns (eg. files, exclude)
    basePath: '',

    browserNoActivityTimeout: 1000000,

    // frameworks to use
    // available frameworks: https://npmjs.org/browse/keyword/karma-adapter
    frameworks: ['jasmine', 'requirejs'],

    // list of files / patterns to load in the browser
    files: [
      'test/test-main.js',
      {pattern: 'environment-config.js', included: false},
      {pattern: 'environment-config.json', included: false},
      {pattern: 'js/**/*.*', included: false},
      {pattern: 'test/jasmine/spec/**/*.spec.js', included: false},
    ],

    junitReporter: {
        outputDir: 'reports/karma',
        outputFile: undefined,
        suite: ''
    },

    // list of files to exclude
    exclude: [
    ],

    // preprocess matching files before serving them to the browser
    // available preprocessors: https://npmjs.org/browse/keyword/karma-preprocessor
    preprocessors: {
    },

    // test results reporter to use
    // possible values: 'dots', 'progress'
    // available reporters: https://npmjs.org/browse/keyword/karma-reporter
    reporters: ['progress', 'junit'],

    // web server port
    port: 9876,

    hostname: '<IP_ADDRESS>', //points to accessible Karma server

    // enable / disable colors in the output (reporters and logs)
    colors: true,

    // level of logging
    // possible values: config.LOG_DISABLE || config.LOG_ERROR || config.LOG_WARN || config.LOG_INFO || config.LOG_DEBUG
    logLevel: config.LOG_INFO,

    // enable / disable watching file and executing tests whenever any file changes
    autoWatch: true,

    // start these browsers
    // available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
    browsers: ['Android', 'Chrome', 'Firefox', 'PhantomJS', 'Safari'],
    // browsers: ['iOS'],

    customLaunchers: {
        'iOS-Safari' : {
            base: 'WebDriver',
            platformName: "iOS",
            deviceName: 'iPhone 5',
            config: webdriverConfig,
            browserName: 'Safari',
        },
        'Android' : {
            base: 'WebDriver',
            platformName: "Android",
            deviceName: 'Android',
            config: webdriverConfig,
            browserName: 'Browser',
        }
    },

    // Continuous Integration mode
    // if true, Karma captures browsers, runs the tests and exits
    singleRun: true

  })
}

I had the same issue, it appears to be fixed by ac7beca0c0258439fa765aad809ebba0f6f456d5.

I thought the same thing @adriaanthomas, but that fix should be part of 0.3.3. @fraserhart what version of Karma are you running?

0.3.3 does not contain this fix.
I tested with this in my package.json:
    "karma-junit-reporter": "karma-runner/karma-junit-reporter#ac7beca0c0",

0.13.9
Cheers

Ah, my mistake @adriaanthomas, thanks!  - @fraserhart I guess you have your answer there :)

Beautiful. Thanks guys :)

I still had this issue with a newer version, but just for your information you can set useBrowserName to false:
junitReporter: {
   outputDir: 'reports/karma',
   outputFile: results.xml,
   suite: '',
   useBrowserName: false
},


Attribute may silently crash

Steps to reproduce
function Test-BadAttribute
{
    [CmdletBinding()]
    Param
    (
        # Param1 help description
        [Parameter]
        [ValidateSet("a","b")]
        $Param1,

        [Parameter]
        [ValidateSet()] # Bad attribute - the constructor is failed
        $Param2
    )

    Begin
    {
    }
    Process
    {
    }
    End
    {
    }
}

1. Test-BadAttribute -Param1 <Press Tab>
2. Test-BadAttribute -Param1 <Press Enter>
3. Test-BadAttribute -Param1 "a" <Press Enter>

Expected behavior

IntelliSenese work for Param1 and don't  work for Param2 with error message
or IntelliSenese don't work for both parameters with appropriate error message.
Show appropriate error message.
Cmdlet work well or don't work with showing appropriate error message.

Actual behavior

No exception. No error message. IntelliSense don't work.
Murky error message: it is impossible to understand that there is a problem with any attribute, which is the attribute and which is the parameter.
The same as 2. and the cmdlet don't work.

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
BuildVersion                   <IP_ADDRESS>
CLRVersion
GitCommitId                    v6.0.0-beta.1-7-g7fa53aedb3c7514cf1c2a19af6c26566661596d9-dirty
OS                             Microsoft Windows 10.0.10240
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Silent failure for the entire param() block also occurs when there is a typo in the attribute.  For example, the following outputs nothing:
function f { param([NonExistentAttribute()]$x,$y) }
(Get-Command f).Parameters

Possible place for the fix https://github.com/PowerShell/PowerShell/blob/e8bf6ca18a04ee04b290d2f01f5ef01750280d36/src/System.Management.Automation/engine/parser/Compiler.cs#L1702-L1705

I think this will be tricky to fix in a meaningful way. The function code isn't executed until it's actually invoked; the missing attribute type could well be added as a powershell class (for example) before the function is actually run.
Running the function yields the expected error, so I'm not sure there's anything we can really fix here?

@vexx32 Please look repro steps in the OP.

@iSazonov gotcha, that's not clear at all and can be improved. Not sure about tab completion though 🤔

I have a proposed solution to the issue which will function as follows:

Test-BadAttribute -Param1 <Press Tab>: the "a b" valid values are displayed.
Test-BadAttribute -Param1 <Press Enter>: error message "Missing an argument for parameter 'Param1' ...",
Test-BadAttribute -Param1 "a" <Press Enter>: works properly.
Test-BadAttribute -Param1 "a" -Param2<Press Tab>: nothing happens.
Test-BadAttribute -Param1 "a" -Param2<Press Enter>: error message "Missing an argument for parameter 'Param2'. Specify a parameter of type 'System.Object' and try again.".

In addition, on the first time Test-BadAttribute is activated, after the first Enter or Tab (which comes first), error message is displayed "WARNING: Parameter $Param2 cannot be used since its ValidateSet is empty".
The main issue I see with this approach is that the error message in step 5 suggests that Param2 may have valid values, but I didn't find a better functioning approach.
Is this approach acceptable?
If it is, then I need help with:

How should the above ""WARNING" message be displayed?  Currently I am using Console.WriteLine but I assume this is not the right way to do this.
Were should the test cases be added?

4. Test-BadAttribute -Param1 "a" -Param2<Press Tab>: nothing happens.

Why nothing?
What if there is a typo in the attribute name?

Test-BadAttribute -Param1 "a" -Param2: nothing happens.

Why nothing?

Nothing, because in the suggested solution GetRuntimeDefinedParameter() adds Param2 as legal ValidateSetAttribute parameter with empty list of valid values.

What if there is a typo in the attribute name?

In this case Tab shows the list of current directory files as the valid values.

as legal ValidateSetAttribute parameter with empty list of valid values.

Do you change the attribute? I think it is nit right direction to address the issue.
The issue asks to add more information to script developer if there are errors/typos in using attributes.

The approach I took is:

In validateValidateSetAttribute() change the exception thrown in the following code to a new exception ArgumentEmptyValidateSetException, to make sure it is unique exception for this case: https://github.com/PowerShell/PowerShell/blob/3d49de134ea9b98ad5991bc7974575a7b242181d/src/System.Management.Automation/engine/Attributes.cs#L1702-L1704
In GetRuntimeDefinedParameter(), catch the PSArgumentEmptyValidateSetException exception in the following call to GetAttribute(): https://github.com/PowerShell/PowerShell/blob/3d49de134ea9b98ad5991bc7974575a7b242181d/src/System.Management.Automation/engine/parser/Compiler.cs#L1800
In the catch body a new ValidateSetAttribute attribute is created with an empty list of valid values.

Initially, I planned that the catch body will just through the same exeception, but now with the real parameter name.  However, in this case Tab for Param1 does not do anything, and even if Param1 is set with a legal value, after the Enter the Param2 exception is shown.  With the above approach the function can be used as long as Param2 is not included in the command line.
The catch body also issues the "WARNING" message, and this is why I asked how to properly display this warning message.  As I wrote, I am also not sure were to add test cases (and examples of test cases for functions parameters will also help).

The issue is not exclusively about ValidateSetAttribute. Any wrong attribute should raise an user friendly message.

The issue is not exclusively about ValidateSetAttribute.

The specific error message in the issue is about ValidateSetAttribute - the ArgumentOutOfRangeException message thrown by ValidateSetAttribute().  I am not sure it is related top other attribute types.
This is a "Murky error message" because ValidateSetAttribute() does not know the parameter name (and I didn't find a relatively easy way to pass it the parameter name).  As far as I understand, in all other cases it is called the list is from internal list, so the '"argument "validValues"' in the message is o.k.

You can replace ValidateSetAttribute with ValidateRange for investigating.
Again, with Test-BadAttribute -p<tab> user should get an useful error message why IntelliSense does not work. Really there is an exception (we can see it if press  instead of ) but IntelliSense code hides it.

with Test-BadAttribute -p<tab> user should get an useful error message why IntelliSense does not work. Really there is an exception (we can see it if press instead of ) but IntelliSense code hides it.

Seems I misunderstood the main issue.  I thought it is that "validValues" should be "Param2" in the error message 'InvalidArgument: Cannot process argument because the value of argument "validValues" is out of range.'.
From the ValidateRange example and and using bool parameter I see that there are some issues with the auto complete:

The above <tab> issue that "should get an useful error message why IntelliSense does not work".  I assume that the required fix is showing the exception error message that IntelliSense currently hides.

When specifying empty ValidateRange parameter, after <enter> the following MethodException error is shown, but there is no such error message for empty ValidateSet.  I assume a fix is to show such MethodException error for empty ValidateSet (and maybe other attribute types).

MethodException:
Line |
  10 |          [ValidateRange()] # Bad attribute - the constructor is failed
     |          ~~~~~~~~~~~~~~~~~
     | MethodArgumentCountException Cannot find an overload for ".ctor" and the argument count: "0".

When a parameter is defined as bool, int, etc., <tab> shows the current folder files as valid values, instead of something like "$True, $False, 1 or 0"  for bool and probably showing nothing for int.  I assume that this should be fixed for all parameter types, except for switch.

Should all these issues be fixed?  If not, which of them (or other related issues that I didn't see) should be fixed?

When a parameter is defined as bool, int, etc.,  shows the current folder files as valid values, instead of something like "$True, $False, 1 or 0" for bool and probably showing nothing for int. I assume that this should be fixed for all parameter types, except for switch.

This is a separate issue(s). We can find many such ones. Most from them could be fixed by improving a type inference.
In the issue we say only about improving the user experience with broken attributes:

typo in name
wrong attribute arguments
an exception in attribute implementation and so on.

In the issue we say only about improving the user experience with broken attributes:

To allow letting the use know about errors during tab-complete, an error message should be displayed to the user.  However, I did not find any PSReadLine method that allows to do that before .
Did I miss something, or such method should be added to allow to show tab-completion errors?  I assume that just using Console.WriteLine() is not good enough, since the completion options may be shown in a GUI menu (unless such  menu is never used by PowerShell).

There are a lot of WriteError() methods. We should find an appropriated one from current (execution) context.

After further evaluation I now believe that a proper solution to this issue requires changes to PSReadLine.  This is assuming that after showing the tab-completion error message, the PS prompt should be displayed again.  E.g., case "1." from the original issue description should look something like:
PS> Test-BadAttribute -Param1 <Tab>
Error: No completion options found since parameter "$Param2" ValidateSet is empty

PS> Test-BadAttribute -Param1

However, displaying the prompt after the error message should be done by PSReadLine, similar to the way the prompt is displayed after the completion options are displayed by PSReadLine/Completion.cs PossibleCompletionsImpl():
    menu.DrawMenu(null, menuSelect:false);
    InvokePrompt(key: null, arg: _console.CursorTop);

For this, PSReadLine should be able to receive the error message, display it and then re-display the prompt.  This is similar to the way it handles the received the completion options list (and maybe the error message can be implemented by returning the message as a special case of the completion options).
Does this approach seem reasonable?  If it is, is it worth trying to implement it? (I am far from understanding the full process done for tab-completion between PSRealLine and PowerShell, but it seems that the required changes for this approach are relatively local, so I am willing to try.)

@davidBar-On Thanks for your research! I thought it was easier to fix than it turned out.
I'd expect this works without PSReadline too in a way.
Perhaps @daxian-dbw could comment how better the fix could be implemented.


➕ Add Javax annotations dependency

Javax annotations is a dependency that is used to provide annotations like @Nullable or @Nonnull, them could be useful for testing and teaching beginners how really the game works by the inside. In fact, Eclipse IDE and more ide allow you to see at javadoc section the annotations that a field posseses.

I almost forgot to do spot stuff XD


Problem Solved

Dear MLCC,
Please ignore my previous pull request. It was incomplete assignment. I have completed my assignment just before submitting this pull request. Check it out.

Don't send pull request in master branch


Projects bug fix

To reproduce the original bug:

Go to the projects index page (https://mushroomobserver.org/projects)
Copy the full name of an existing project
Click 'Add Project' (upper right corner)
Paste the name into the "Title" field
Click "Create"
See the page re-render but with an error complaining about the name already exists
Enter a new Title
Click "Create"
Boom!

The problem was that we were not setting the @projects ivar in ProjectsController#create.
Note, this PR also attempts to fix the occasional spec failure related to TEST_PAGES.  I was able to reliably reproduce this issue locally with: rails t --seed 10928

coverage: 93.629% (-0.01%) from 93.64% when pulling 9d3c41d1568de5292af5966d973b905b7662deae on projects-bug-fix into<PHONE_NUMBER>06b49610131fbf6caeb23bc12a579e on main.


Allow overriding cache id and tag validation in Zend_Cache

Closes #317

The inheritance may be a way of extending, therefore the protected stuff should be considered as a part of the API (in general). But those changes look fine to me.

therefore the protected stuff should be considered as a part of the API (in general)

protected is not a part of the public API.

Agreed. Our policy has always been that we don't keep BC for protected.

No problems on Travis: https://travis-ci.org/froschdesign/zf1/builds/46177629

ping @akrabat


Feat 498 pyd v2

Closes #498
Still in progress
Updating the validators

v2 removes validator and root_validator and changes them to field_validator and model_validator with different interfaces

Resolving serialization warnings

There seems to be an issues doing round trip serialization/de-serialization of nested models. I'm looking into this issue further.

Upgrades pydantic to version 2
Changes in the example json files:

Decimal class now gets rendered as strings instead of floats. (This change is unavoidable)
I changed stuff like Optional[List[str]] = None to List[str] = [] and changed the corresponding null values to empty lists. I can change them back, but this makes things slightly easier to maintain since we don't need to do checks against None. Again, if this isn't the desired behavior, I can change things back
Everything else remains the same, so from a user standpoint, it shouldn't be too different

Changes to the schemas

It seems v2 renders fields like field_name: Optional[str] as anyOf in the schema. I think in v1 it just marked the field as "requried": false. I'm not sure if there's a way to prevent that change.
This is a work in progress, but it's been difficult to use non-string and non-int enums. I changed all of them to "tagged" classes. For example, modalities and institutions are different. I'm working on making it so the users can still use the same interface (modality=Modality.ECEPHYS), but I need to do some refactoring. For the standard str and int enums, I kept them the same. I set the base model config to use_enum_values=True so the schema just renders the value and not the class name.
pydantic raises warnings about adding extra information in the fields outside of the description. I removed all instances of "units=" and "additionalProperties=".
I'll need to explore more how different the changes are between the old v1 and v2 schemas.
I changed some of the class names that were the same across modules (session.Laser and device.Laser for example). I renamed the stuff in session to something like LaserConfigs but I can rename them back to their original name, but it was a bit confusing knowing which was which.

Changes to the package organization

I removed the deprecated packages
I put all the core models into a single package to make it easier to know which classes are AindCoreModels
I put models that get imported into different packages into a models package. This makes it easier to avoid circular imports and having to use future annotations.

@mekhlakapoor @yosefmaru We can ignore github's new line warnings for the auto-generated json files

I've left some comments - take a look. If you want to ignore them for now and turn them into issues to fix, that's fine. They're mostly small. A few might be worth fixing now. But if you do merge, let's turn them into issues so we fix them soon.

I've left some comments - take a look. If you want to ignore them for now and turn them into issues to fix, that's fine. They're mostly small. A few might be worth fixing now. But if you do merge, let's turn them into issues so we fix them soon.

I pushed a couple of commits that addresses your comments


Issue with Vue.js

Hi,
When I add the following code in one JS file, compilation not happening.
var userlogin = new Vue(
{
  el: '#user-login',
  data: { user_name:"", user_password:"" },
  mounted(){
    this.$http.post('api/index.php',{
      type: 'user_login'
    }).then(response =>{
        //console.log(response.body);
    }, response =>{
      // error callback
    });
  }
});

Vue js not supported? Please help.
Thanks.

I've seen that you are using the new EcmaScript 6 standard; JSCompiler is based on UglifyJS which doesn't support EcmaScript6. I'm currently exploring a new alternative that could fix this soon.

Okay, thanks.
On Thu, 8 Mar 2018 at 02:09 Karl Tayfer<EMAIL_ADDRESS>wrote:

I've seen that you are using the new EcmaScript 6 standard; JSCompiler is
based on UglifyJS which doesn't support EcmaScript6. I'm currently
exploring a new alternative that could fix this soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/daPhyre/brackets-jscompiler/issues/18#issuecomment-371276785,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACAV-rhQc2qjdIm06EEUNyzJdp0a5ZGzks5tcEWCgaJpZM4RZT7t
.


New plugin: html viewer (web browser)

From pierre.raybaut on 2009-10-25T13:22:25Z
By 'rvdboomgaard':
BTW: how much trouble would it to add a new type of window to spyder? I
would like to
add the html viewer in order to put in some documentation in html format (for a
vision course i would like to switch from matlab to python).
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=101

From pierre.raybaut on 2010-01-06T02:54:31Z
Owner: ---

From pierre.raybaut on 2010-02-06T07:52:55Z
Status: Fixed


Fix - encodeUri used twice (global one removed)

The bad URL check is performed twice.
Globally through app.use(), and locally, through the assert_url() private function called within each and every validation endpoint. This is causing the queried URL to be encoded twice, thus resulting in 404 or 500 errors.
As assert_url seems to be always used in a "rule-of-thumb" fashion and contains more in-depth checks for the URL's to be validated, I'd propose to remove the global one.

I signed it!

Fixes #49

Thanks! Sorry for the delay.

Thank you @ithinkihaveacat


Mention updating ownerReferences in CRD version deprecation doc

This is a Feature Request

What would you like to be added

I would like the documentation about CustomResourceDefinition version upgrade and removal to mention that owner references pointing at CustomResources that were created at the CustomResourceDefinition version-to-be-removed, need to point at the new version and optionally suggest a recommended/best-practices way how the controller authors could do this (so that users don't have to manually update their CustomResources).
Why is this needed
It could be useful for folks that write controllers that create CustomResources (or other resources) that are owned by CustomResources as well as for users.
I feel like this could be easily overlooked/skipped if not mentioned in the docs as the only indication of the owner reference on an object being broken after a CRD version is no longer served might be that the object doesn't get garbage collected correctly.
(I'd be happy to PR the update if you think it might be useful, but I am not 100% sure what could be a recommended way to update the owner references.)

/remove-lifecycle rotten
/remove-lifecycle stale
I think this would still be useful


Revert "fix: update pgmeta to latest version"

Reverts supabase/cli#824

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.839%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3612

Relevant Lines:
5748

💛  - Coveralls


Improve SQL reference on partitioning

Add landing page for ALTER PARTITION that references the only
relevant subcommand, CONFIGURE ZONE.
Update PARTITION BY to cover by tables and indexes. Also add
this statement to the SQL statements list and cross-reference
it more.
Update other ALTER landing pages for usability and consistency.

Fixes #5869.
Fixes #5868.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c683ca246173897a5485c85c04e21200aca2da34/
Edited pages:

v19.2/alter-database.md
v19.2/alter-index.md
v19.2/alter-partition.md
v19.2/alter-range.md
v19.2/alter-table.md
v19.2/configure-zone.md
v19.2/online-schema-changes.md
v19.2/partition-by.md
v19.2/show-partitions.md
v19.2/sql-statements.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/652c4ef11a2c1b70d897c76c890a0b952b70e951/
Edited pages:

v19.2/alter-database.md
v19.2/alter-index.md
v19.2/alter-partition.md
v19.2/alter-range.md
v19.2/alter-table.md
v19.2/configure-zone.md
v19.2/online-schema-changes.md
v19.2/partition-by.md
v19.2/show-partitions.md
v19.2/sql-statements.md


Handle integer metric name

Coverage increased (+0.02%) to 93.403% when pulling a4883b77bfaa74e76a2c085e88b4eb87f2b1f406 on feature/integer-metric-name into d18b986273488adf3db5d51de02581e927155226 on master.

Coverage increased (+0.02%) to 93.403% when pulling a4883b77bfaa74e76a2c085e88b4eb87f2b1f406 on feature/integer-metric-name into d18b986273488adf3db5d51de02581e927155226 on master.


:mag: fix float index problem of #63

Codecov Report

Merging #64 (fbf8d5e) into main (b8588c5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   98.47%   98.47%
=======================================
  Files           9        9
  Lines         589      589
=======================================
  Hits          580      580
  Misses          9        9

Impacted Files
Coverage Δ

plotly_resampler/aggregation/aggregators.py
98.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8588c5...fbf8d5e. Read the comment docs.


Update init script to get again /var/log/fail2ban.log

Update init script to get again /var/log/fail2ban.log from /etc/fail2ban/fail2ban.conf and .local
removed hardcoded --logtarget=syslog which forced the syslog logging

Hi. So there is a config in /etc/fail2ban that will instruct fail2ban to log to syslog? Which one?

root@openrt:~# cat /etc/fail2ban/fail2ban.local
[DEFAULT]
##loglevel = DEBUG
loglevel = INFO
logtarget = /var/log/fail2ban.log
where you can put syslog into logtarget...

Thanks for the contribution!


Update client code to receive and pass back a bot ID

The client code needs to be updated to manage the identify of the open bot project. Up to this point, that information was stored in the server, but responsibility will now move to the client code to enable multi-user scenarios.
Describe the solution you'd like

[x] When a bot project is opened or created, capture the included bot id and make it easily available throughout the app
[x] Amend the code for all actions that make API calls to the server to include the bot id as part of the payload (~ 15 endpoints)
[x] Update client code to include bot ID in the routes such that /dialogs/main is now /bot/:ID:/dialogs/Main. This applies to all routes that refer to content from a bot project, including settings.
[x] Ensure that, given a bot id in the url, the application is loads the appropriate content into the editor and provides the correct value to api calls
[x] Handle errors resulting from an invalid bot id - redirect user to the home screen and/or the open bot dialog.

This is completed in #2023

addressed via https://github.com/microsoft/BotFramework-Composer/pull/2023


chore: change ApisixUpstream, use upstreams instead of ports

Also, this PR fixed the bug in endpoints controller, which use the container port as the component in upstream name, now we'll refer to the corresponding service, and find the service port, nevertheless, we didn't handle the endpoints deletion, since in that case, the service was deleted, so we cannot find the reference relationship. But that's OK since even we handle the deletion, what we can do is just reset the nodes array to empty in Upstream (so requests response will be 502 Bad Gateway), while in our case, requests will be sent to the endpoints, and maybe requests are OK if Pods are alive, or requests will get 504 Gateway Timeout. Maybe we can use service port name to build the upstream name, if this difference is important.
Anyway, delete Service/Endpoints before the ApisixUpstream is not a good way, and always remove ApisixUpstream before the Service and Endpoints.

Codecov Report

Merging #218 (f883bee) into master (8bcbc60) will decrease coverage by 0.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   45.58%   44.71%   -0.88%
==========================================
  Files          34       33       -1
  Lines        2029     2026       -3
==========================================
- Hits          925      906      -19
- Misses        968      981      +13
- Partials      136      139       +3

Impacted Files
Coverage Δ

pkg/ingress/apisix/upstream.go
87.17% <100.00%> (-0.63%)
:arrow_down:

pkg/apisix/cluster.go
28.90% <0.00%> (-6.17%)
:arrow_down:

pkg/apisix/route.go
39.73% <0.00%> (-1.99%)
:arrow_down:

test/e2e/e2e.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcbc60...f883bee. Read the comment docs.

Codecov Report

Merging #218 (f883bee) into master (8bcbc60) will decrease coverage by 0.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   45.58%   44.71%   -0.88%
==========================================
  Files          34       33       -1
  Lines        2029     2026       -3
==========================================
- Hits          925      906      -19
- Misses        968      981      +13
- Partials      136      139       +3

Impacted Files
Coverage Δ

pkg/ingress/apisix/upstream.go
87.17% <100.00%> (-0.63%)
:arrow_down:

pkg/apisix/cluster.go
28.90% <0.00%> (-6.17%)
:arrow_down:

pkg/apisix/route.go
39.73% <0.00%> (-1.99%)
:arrow_down:

test/e2e/e2e.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcbc60...f883bee. Read the comment docs.

The change is not what we desired now. Will re-implement.


Enable Migrations Support for MongoDB

Is your feature request related to a problem? Please describe.
Enable migrations to support the Mongo driver
Describe the solution you'd like
Ability to use migration, schema, and other cli tools for Mongo driver
Describe alternatives you've considered
Building a custom script to handle it and run via ts-node
Additional context
n/a

As promised on slack, here are few notes about how to implement this:

Migrator and its migration related dependencies now depend on AbstractSqlDriver, easiest approach would be probably to introduce MongoMigrator that would be used instead
currently migrations are about registering SQL commands via addSql(), this is obviously not usable for mongo, we might need some additional helper command in the MongoMigration class, maybe getCollection(entity)?
another piece of code that will be needed is MongoMigrationStorage, we could also use mongo storage provided by umzug, but that would probably create new connection which is unnecessary
last thing will be to adjust MikroORM wrapper class so it does return the appropriate migrator class based on the current platform

Ability to use migration, schema, and other cli tools for Mongo driver

We discussed migration on slack, obviously supporting schema related things in mongo is totally different story. As there is no schema present, there is not much we can do here. I can imagine entity generator to work based on the first record in given collection, but I do not see a way how we could have mongo flavoured schema generator.

I would like to look into this soon, but I just realised that you asked for more than just migrations.
How do you think schema generator could work for mongo? We can check for existing/missing collections, we could also check for defined properties based on the first document, but how would the schema update work? I am not sure if it makes sense to run something like find and update queries to change a type of a column or rename it - that sounds like really performance heavy thing.

Indexing in Mongo (for production uses) has to be done through migrations. Apart from "schema", that single use-case justifies mongo-aware migrations IMHO

Apparently, according to the closed issue above (#1002), Mongo does not support migrations - and dumps an Knex error on the user.
Ideally there could be a better warning? Just throwing it out there - who knows...

@B4nan
We started to use Mikro-ORM instead of mongoose and love it more and more.
Seeds just works, without additional library, with the same configuration file. Amazing.
Now it's time to implement migrations.
It's just a fact - sometimes we need to change something in the database. Even in MongoDB.
Solutions exist. For example https://github.com/seppevs/migrate-mongo
I cannot imagine different flow for migration with MongoDB.
Just two functions - up and down where you can do what you want.
And migration state persists in the database.
So, I want to leave my feedback here. And I like to know your thoughts and plans regarding this feature.

I will go with the easy way and create new @mikro-orm/migrations-mongodb package, as the current one depends on knex, and I definitely dont want to make it depend on mongo too (might be worth cleaning up in v6, let's see). Otherwise the CLI interface should be the same, only available migration type will be a blank one, it will have a driver instance available, plus a getCollection(entityName) shortcut.

@B4nan , for what it's worth, mongodb has transactionstransactions  for a while now.
it supports "DDL" operations like collection and index manipulations : https://www.mongodb.com/docs/upcoming/core/transactions/#std-label-transactions-create-collections-indexes

Mongo transactions are supported for quite some time, since v4 iirc.

Mongo transactions are supported for quite some time, since v4 iirc.

I meant auto-transactional migrations would be a must for mongo driver migrations; as since 4.2 it supports "DDL-like" operations.
But you already did it, so sweet ☺


Fixed Clang -O2 optimization problem

This turned out to be caused by a slew std::string = const char* that clang optimized and did not do the proper casting. I think this is a strict aliasing-like problem (I could be wrong, my comp-sci lingo isn't perfect). I have corrected the code to use only const char*.
I assume this problem might carry through into epics and other odb read things,. I'll keep my eye out, but other mac users should as well.

@pcbend, I changed the logic around a bit in the infinite while loop. Can you see any pitfalls that I may have missed?

So i might be missing something, i've been staring at a computer for a long
time.   Does this actually search the nodes?  It looks like it checks the
first one and either it works or it breaks the loop...
i can look again later when my eyes are a bit fresher.
On Mon, May 4, 2015 at 8:26 PM, Ryan Dunlop<EMAIL_ADDRESS>wrote:

@pcbend https://github.com/pcbend, I changed the logic around a bit in
the infinite while loop. Can you see any pitfalls that I may have missed?
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98890619
.

You are correct, I think that first break should be a continue.

On May 4, 2015, at 8:59 PM, pcbend<EMAIL_ADDRESS>wrote:
So i might be missing something, i've been staring at a computer for a long
time. Does this actually search the nodes? It looks like it checks the
first one and either it works or it breaks the loop...
i can look again later when my eyes are a bit fresher.
On Mon, May 4, 2015 at 8:26 PM, Ryan Dunlop<EMAIL_ADDRESS>wrote:

@pcbend https://github.com/pcbend, I changed the logic around a bit in
the infinite while loop. Can you see any pitfalls that I may have missed?
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98890619
.

—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98895887.

i think that would work too.
On Mon, May 4, 2015 at 9:00 PM, Ryan Dunlop<EMAIL_ADDRESS>wrote:

You are correct, I think that first break should be a continue.

On May 4, 2015, at 8:59 PM, pcbend<EMAIL_ADDRESS>wrote:
So i might be missing something, i've been staring at a computer for a
long
time. Does this actually search the nodes? It looks like it checks the
first one and either it works or it breaks the loop...
i can look again later when my eyes are a bit fresher.
On Mon, May 4, 2015 at 8:26 PM, Ryan Dunlop<EMAIL_ADDRESS>wrote:

@pcbend https://github.com/pcbend, I changed the logic around a bit
in
the infinite while loop. Can you see any pitfalls that I may have
missed?
—
Reply to this email directly or view it on GitHub
<
https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98890619

.

—
Reply to this email directly or view it on GitHub <
https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98895887
.

—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98895996
.

I've removed that bad break entirely and it looks like it fixed allllll of the problems. Good catch!

excellent, nicely done that xml stuff is a pain.
On Mon, May 4, 2015 at 9:04 PM, Ryan Dunlop<EMAIL_ADDRESS>wrote:

I've removed that bad break entirely and it looks like it fixed allllll of
the problems. Good catch!
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98896259
.

I spoke a little too soon. For some reason our O1 is now dying because node isn’t being set… This comes before the issue I fixed…and O1 used to work. That means there was an error before that the compiler was somehow compiling away…

On May 4, 2015, at 9:21 PM, pcbend<EMAIL_ADDRESS>wrote:
excellent, nicely done that xml stuff is a pain.
On Mon, May 4, 2015 at 9:04 PM, Ryan Dunlop<EMAIL_ADDRESS>wrote:

I've removed that bad break entirely and it looks like it fixed allllll of
the problems. Good catch!
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98896259
.

—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98899120.

This is the function that is killing us.
const char* TXMLOdb::GetNodeName(TXMLNode *node) {
   TList *list = node->GetAttributes();
   if(list) {
      std::string buffer = ((TXMLAttr*)(list->At(0)))->GetValue();
      //list->Delete();
      return buffer.c_str();
   } else {
      return "";
   }
}

Am I wrong in saying that I don't think this code should always work? Or do strings do something special in memory like smart pointers?

No you are right, that shouldn't work.  The string will be destroyed upon
returning making the data in it undefined.
I guess we got luck so far that the compilers we have been using have
handled it ok.
On May 4, 2015 10:09 PM, "Ryan Dunlop"<EMAIL_ADDRESS>wrote:

This is the function that is killing us.
const char* TXMLOdb::GetNodeName(TXMLNode *node) {
TList list = node->GetAttributes();
if(list) {
std::string buffer = ((TXMLAttr)(list->At(0)))->GetValue();
//list->Delete();
return buffer.c_str();
} else {
return "";
}
}
Am I wrong in saying that I don't think this code should always work? Or
do strings do something special in memory like smart pointers?
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98905648
.

Ok, I think all of the code I changed would have worked the way it was if this function was ok. I’m going to make this function return a string, we should be good to go after that.

On May 4, 2015, at 10:18 PM, pcbend<EMAIL_ADDRESS>wrote:
No you are right, that shouldn't work. The string will be destroyed upon
returning making the data in it undefined.
I guess we got luck so far that the compilers we have been using have
handled it ok.
On May 4, 2015 10:09 PM, "Ryan Dunlop"<EMAIL_ADDRESS>wrote:

This is the function that is killing us.
const char* TXMLOdb::GetNodeName(TXMLNode *node) {
TList list = node->GetAttributes();
if(list) {
std::string buffer = ((TXMLAttr)(list->At(0)))->GetValue();
//list->Delete();
return buffer.c_str();
} else {
return "";
}
}
Am I wrong in saying that I don't think this code should always work? Or
do strings do something special in memory like smart pointers?
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98905648
.

—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/pull/306#issuecomment-98908718.

I think it's very easy to get sloppy with const char* because everyone thinks of them as strings and not as pointers (I do anyway). We just have to keep an eye out for them and only return them when they are data members (I think it's easy to get sloppy with mallocs in these situations).


Z-fighting

Versions

Minecraft: 1.12.2

Forge: <IP_ADDRESS>60

EUEL: 1.23.6

EmbersifiedExtended: 1.2.2

Mixinbooter: 9.1

Soot UEL: 1.11.0

Aetherworks UEL: 1.1.0

Mystical Mechanics: 0.18

No Optifine or other optimization mods were used. Vanilla MC on Fast Graphics.

What happens
During my playtesting I've found that several of EUEL's blocks have z-fighting errors whenever you move your camera.
I haven't tested all the different blocks, but these screenshots of the ejectors on the conduit should illustrate it.

I never touched any models/textures of the mod itself. This means these Z-fighting issues also exist in the original mod.
Thanks for your report!


Adding specs for new _list/indices and _list/shards APIs

Description
Adding specs for _list/indices and _list/shards APIs, new paginated alternates of _cat/indices and _cat/shards. Both the new list APIs will continue to support all the params supported by existing cat API counterparts in addition to three new parameters which are specific to pagination (namely next_token, size and order).
Related Opensearch changes: https://github.com/opensearch-project/OpenSearch/issues/14258 & https://github.com/opensearch-project/OpenSearch/issues/14257
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock Can you please take a look again? Added tests taking inspiration from existing _cat APIs. Verified the tests by running them against Amazon Opensearch domain.

The staging 2.18 distribution seems to be missing the _list APIs, and as a result Spec test in CI are failing.

@dblock Thanks for reviewing. I have addressed previous set of comments, please do take a look again whenever you get a chance. Also, sorry for the delay in between the revisions, got occupied with other urgent items.
On the tests, i have updated the staging distributions for 2.18 and 3.0 and the newly added list tests are passing. Not sure why some of the existing ones have started to fail. Trying to root cause.

The 3.0 build gets generated even if not all plugins build with it, so looks like the update SHA doesn't have all the plugins? Try another more recent SHA until the tests all pass, possibly hunt down why the build is failing for the plugins that are failing (geospatial looks like).

Got it, I had sorted the distributions via the newest and used the latest one already. Can this staging build be triggered manually to generate a latest distribution?

The 3.0 build gets generated even if not all plugins build with it, so looks like the update SHA doesn't have all the plugins? Try another more recent SHA until the tests all pass, possibly hunt down why the build is failing for the plugins that are failing (geospatial looks like).

Got it, I had sorted the distributions via the newest and used the latest one already. Can this staging build be triggered manually to generate a latest distribution?

You should try with a newer SHA. The builds happen every day.
If the build is broken (other tests failing, please try another SHA or chase that down).

Looks like the style checker is failing for good reason (use of indices instead of indexes, etc.).

Looks like the style checker is failing for good reason (use of indices instead of indexes, etc.).

We have a namespace called indices that has been around since the beginning of time. Shouldn't it be the other way around where the use indices over indexes?

Looks like the style checker is failing for good reason (use of indices instead of indexes, etc.).

We have a namespace called indices that has been around since the beginning of time. Shouldn't it be the other way around where the use indices over indexes?

The descriptive text was standardized as "indexes", but technically it's "indices" in APIs and such I believe. Let's open an issue in docs about potentially changing that, but for now the style checker is correct.

Test run against 3.0.0 build is the only failing task. Newly added spec tests though are passing, the existing plugin related tests are failing.

@dblock @nhtruong Can you please help with suggestions on 3.0.0 build? I have picked up the latest SHA as part of this PR.
Thanks!

Looks like we don't have a good 3.0 build since with all the plugins, hence the failures :(
Undo the 3.0 hash change and add version: '< 3.0' in the new list tests, maybe with a # TODO: re-enable in 3.0, see  https://github.com/opensearch-project/opensearch-api-specification/pull/613.

Undo the 3.0 hash change and add version: '< 3.0' in the new list tests, maybe with a # TODO: re-enable in 3.0, see  https://github.com/opensearch-project/opensearch-api-specification/pull/613.

@dblock Thanks for the suggestions. The tasks are green now, please take a look whenever you get a chance.
Thanks!

Good work @gargharsh3134, thanks for hanging in here!


troubleshooting numpy

Lesson learned: don't leave a branch without testing for three days and 25 commits


[x] I've not introduced breaking changes.

The issue related to this has been marked closed by the author, I also cannot seem to recreate the issue relating to using a lowercase true. Is this PR still necessary?

I am unable to reproduce the issue that this is supposed to fix.
I have tried a mixture for the value

true
false
TRue
TruE
truE
FalsE

All seem to be accepted by the game.

The issue related to this has been marked closed by the author, I also cannot seem to recreate the issue relating to using a lowercase true. Is this PR still necessary?

No need, This is a misunderstanding.


Use updated fibers

Change package.json to use vladimirov/fibers_1_0_5_fixes branch where node-fibers are built with all the latest fixes. This is a temporary change that has to be removed after merging vladimirov/fibers_1_0_5_fixes into master of node-fibers repo. The temp change is required for testing purposes.

:+1:


Refactored tests, removed testify/assert

Hi!
I tried to resolve #2.
Hope you like it :)

You are right, forgot about it :)


Deploy with interactive defaults

I had to deploy recently and would have liked sensible defaults with prompts. What do you think?

I don't see much need for interactive inputs as we have only 2 required parameters. This PR produces no deployment command output for me either interactively or via ./deploy<EMAIL_ADDRESS>next.

That said, if positional arguments continue working just like today, why not. But currently I get no output from any ssh commands, so something is wrong.
Also, this PR was probably meant to be submitted against live.

This PR does not change the current behaviour when using positional arguments, so it's fully backwards compatible.
The interactive nature and sensible defaults kick in when running just ./deploy

If I run it in debug mode (DEBUG=1) I get the following:
+ set -e
+<EMAIL_ADDRESS>+ VERSION=www
+ VERSIONS=(previous www next)
+ GIT_SHA=
+ '[' -n '' ']'
+ echo

+ read -rp 'Which user & host do you want to deploy to? (press enter for gerhard@www.rabbitmq.com): ' remote_host
Which user & host do you want to deploy to? (press enter for gerhard@www.rabbitmq.com):
+<EMAIL_ADDRESS>+ '[' -n '' ']'
+ echo

+ read -rp 'Which website version is this? (press enter for www or choose one of: previous www next): ' version
Which website version is this? (press enter for www or choose one of: previous www next):
+ VERSION=www
+ TMP_DIR=/tmp/to_deploy_www
+ ssh<EMAIL_ADDRESS>mkdir -p /tmp/to_deploy_www
+ rsync -qcrz --delete --perms --chmod=a+rwX --exclude=site/man code conf site wordpress-theme gerhard@www.rabbitmq.com:/tmp/to_deploy_www
+ ssh -t<EMAIL_ADDRESS>sudo '/tmp/to_deploy_www/code/deploy-remote www '
[sudo] password for gerhard:
Feeds will be mirrored by the user rabbitmq
######.#.#####.###########.##.#..#######.#####.##.###.#..##.#..#.##.##.####.##.#.########.#######...#####.#..###.##.###########.#.#########.######.###.#.##########.###.....######################################.#############.########.######....................................................................................................................................######........................................................................................................................................................#
Site www.rabbitmq.com already enabled
[ ok ] Reloading web server config: apache2.
Connection to www.rabbitmq.com closed.

@michaelklishin has a point: the script in live calls set -x before starting the actual deploy. The new script should keep this behavior, even if you set it earlier with DEBUG=1. Otherwise, it asks for a password but we don't have any context.

👀

@michaelklishin 👀


Allow usage of MPSolver.SetStartingLPBasis in Python API

@flomnes do you prefer that I open this PR into google's main branch directly instead, to have their opinion?

@flomnes do you prefer that I open this PR into google's main branch directly instead, to have their opinion?

Yes, I think it's a good idea

@flomnes do you prefer that I open this PR into google's main branch directly instead, to have their opinion?

Yes, I think it's a good idea

OK, I opened a PR from our main to theirs first

see: https://github.com/google/or-tools/pull/4188


Once RTSP server is set up, how to get video stream from client?

Hello, I'm new to Android. My purpose is to set up a server on an Android device and use another Android device to get the video stream. I followed example 1 to start a RTSP server but I have no idea how to get the video stream from a client. I want to know how the client program can be written and what's the URL to obtain the stream?
I tried to obtain the Wi-Fi IP according to this link and got "rtsp://ip obtained:1234". Is it the correct way?
WifiManager wifiMgr = (WifiManager) getSystemService(WIFI_SERVICE); WifiInfo wifiInfo = wifiMgr.getConnectionInfo(); int ip = wifiInfo.getIpAddress(); String ipAddress = Formatter.formatIpAddress(ip);
Thank you everyone!

It's a correct way. The next step is to connect to rtsp://ip:port with or without additional URI parameters

Thanks! I figured out it may be the problem of my phone. I used another phone and it worked. Cheers!

I doing the same work now.  Which example can be used as rtp client on the phone?Can you post your codes about connect to the example1's server?

@SSSANTON I finished this project few months ago, I will have a check and tell you later!


Failed to add device

Required information

Distribution: Ubuntu
Distribution version: 16.04
The output of "lxc info" or if that fails:

lxc info
config:
core.https_address: '[::]:8443'
core.trust_password: true
storage.zfs_pool_name: MainMachine1
apiextensions:

id_map
apistatus: stable
apiversion: "1.0"
auth: trusted
public: false
environment:
addresses:

<IP_ADDRESS>:8443
'[2a01:4f8:210:54d8::2]:8443'
architectures:
x86_64
i686
certificate: |
driver: lxc
driverversion: 2.0.7
kernel: Linux
kernelarchitecture: x86_64
kernelversion: 4.4.0-79-generic
server: lxd
serverpid: 2475
serverversion: 2.0.9
storage: zfs
storageversion: "5"

Issue description
after i did apt-get upgrade and reboot , i can't mount any new device ( ftp-mounted folder here) to containers ; also exist devices from past inside containers are permission denied now ...
lxc config device add host1 uploads disk source=/ftpmount/uploads/ path=/home/uploads/ error: Failed to add mount for device: Error calling 'lxd forkmount 25176 /dev/.lxd-mounts/lxdmount_024123295 /home/uploads': err='exit status 1'
shell : /ftpmount/profiles # lxc config device add host1 uploads disk source=/ftpmount/uploads/ path=/home/uploads/ error: Failed to setup device: remove /var/lib/lxd/devices/host1/disk.home-uploads-: device or resource busy
Really i need some helps now , cuz it happened on a produce server unfortunately

Hi,
Does that still happen after you restart the container?
Can you include the output of:

lxc config show --expanded host1
ls -lah /var/lib/lxd/devices/host1/
cat /proc/self/mountinfo
lxc exec host1 -- cat /proc/self/mountinfo


feat: improve savers sendMax heuristics (#4137)

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #4144   👈

This comment was auto-generated by Graphite.


Changed dep from GitHub to NPM

This is just a good move in general.  Specifically doing it now as I attempt to evaluate stackblitz.com, which requires dependencies to be published to npm.

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   99.22%   99.22%
=======================================
  Files          71       71
  Lines        1685     1685
  Branches      264      264
=======================================
  Hits         1672     1672
  Misses         13       13

Flag
Coverage Δ

#builder
100% <ø> (ø)
:arrow_up:

#runtime
94.11% <ø> (ø)
:arrow_up:

#srcapp
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdbac84...6727f40. Read the comment docs.


SideNavigationViewController Crashlytics error

Hi, I'm using Crashlytics in my app, and i get this error while opening my app.

something weird is that this error happens only in the version of crashlytics, the same version in the simulator or installed on my phone by xcode, this error does not occur

Hi, can you send me the initialization code you are using and the version of MK? Thank you!

I have two places that i call sideNavigation
in appDelegate, case user is already logged
let storyboard = UIStoryboard(name: "InicioView", bundle: nil)

            let mainVC = storyboard.instantiateViewControllerWithIdentifier("MainViewController")
            let sideVC = storyboard.instantiateViewControllerWithIdentifier("LeftMenuViewController")

            window = UIWindow(frame: UIScreen.mainScreen().bounds)
            window?.rootViewController = SideNavigationViewController(mainViewController: mainVC, sideViewController: sideVC)
            window?.makeKeyAndVisible()

and when is new user, after press login button.
let storyboard = UIStoryboard(name: "InicioView", bundle: nil)
                    let mainVC = storyboard.instantiateViewControllerWithIdentifier("MainViewController")
                    let sideVC = storyboard.instantiateViewControllerWithIdentifier("LeftMenuViewController")
                    let vc = SideNavigationViewController(mainViewController: mainVC, sideViewController: sideVC)

                    self.presentViewController(vc, animated: true, completion: nil)

the version that I use to upload to crashlytics was 1.24.15

Is the breakage occurring when the user logs in and you switch the controller, or is it happening when they are already logged in? Or both?

on both

So two things.
The issue is complaining about BAD_ACCESS, which means that somewhere there is a reference to an object that no longer exists. This could be because of using Storyboards. We do not offer full Storyboard support at this time.
Further more, rather than using two instances of SideViewController, have you thought of using a single setup that swaps the mainViewController if the user is logged in or becomes logged in? This may help in the memory management of the object.
I cannot see anything that screams issue in the code. So it is strange that a BAD_ACCESS issue is arising.
Before I run further testing on this, is it possible to update to the latest version and run these tests?

Yes, I'll update to latest version, like I said, only happens on the version that I install from crashlytics.. on Simulator I don't get this error.

Yes, I understand. I am updating the closures and animations to use more elaborate ARC support, which would ensure that no cycles occur.

I just tried installing the latest version, using Carthage (v1.25.8), and I'm getting the same BAD_ACCESS error. I simply added the following to my AppDelegates:
http://s.lars.io/20151221153648_itjuf0wwhi.png
And this is the error:
http://s.lars.io/20151221153611_fw5tb68wps.png
My Storyboard looks like this:
http://s.lars.io/20151221153825_0mtahp1jng.png
(I have some additional views, but I simplified it for this case)

Hi @LarsDR, Thank you for posting the issue you found. We are looking into this issue and will post a comment later today with the next steps.

We haven't been able to reproduce this issue. Tomorrow there will be a release with some updates to the memory management of the Side Navigation. If the issue persists, please re-open the ticket or file a new one. Thanks again for bringing this to our attention :)

@adamdahan Can you try and reproduce this issue. Thank you!

I Found that Crash when run in Release Mode
[SideNavigationViewController retain]: message sent to deallocated instance 0x125d371f0

add log
	/**
	:name:	init
	*/
	public convenience init(mainViewController: UIViewController, sideViewController: UIViewController) {
		self.init()
		self.mainViewController = mainViewController
		self.sideViewController = sideViewController
		prepareView()
		prepareMainViewController()
    NSLog("SideNavigationViewController preSideView")
		prepareSideView()
    NSLog("SideNavigationViewController postSideView")
	}

  deinit{
    NSLog("SideNavigationViewController deinit")
  }

And the crash output log was
2015-12-22 15:41:06.734 MyApp[5228:707153] SideNavigationViewController preSideView
2015-12-22 15:41:06.738 MyApp[5228:707153] SideNavigationViewController deinit
2015-12-22 15:41:06.738 MyApp[5228:707153] *** -[SideNavigationViewController retain]: message sent to deallocated instance

I Found  a workaround by comment two line animation code of prepareSideView as below
//		MaterialAnimation.animationDisabled {
			self.sideView.position.x = -self.sideViewControllerWidth / 2
			self.sideView.zPosition = 1000
//		}

I found that if your mainVC isn't a NavigationControllerViewController, then the side view is deallocated. I got it working (also by commenting out MaterialAnimation.animationDisabled like @banxi1988) now, but only when I'm navigating directly to the NavigationViewController that I have.

@banxi1988 The workaround that you are doing shouldn't be needed. @adamdahan and I have found a couple things that may be causing the issue. I will let @adamdahan share more about the storyboard usage and how to avoid @LarsDR issue when setting them up. Generally, what is happening with the
MaterialAnimation.animationDisabled {
...
}

is that the animationDisabled is capturing a lazy loaded property, which is increasing ARCs reference count for that object. What should be happening within the block -- is usage of the sideView with an unowned or weak reference, as well, the lazy property should be converted to an optional and when prepareSideView is called, the sideView may be instantiated thus passing a single reference to the animation block.
I am going to make the changes today and issue a release. Then if you guys can test and try and reproduce the issue, that would be great!

@LarsDR I tested the side nav and it seems to be working fine as long as the storyboard is configured correctly.
Because we do not support storyboards the only configuration that will work is following these steps:

Go to your Target's info panel and make sure it is not looking to load the application from a base storyboard. You can see this underneath the "Main Interface" area in the info panel. If it has "Main" there or some other storyboard name - delete it.

*Side note, I noticed that the image http://s.lars.io/20151221153825_0mtahp1jng.png has a -> Pointing to the root view controller of the storyboard but your code does not use the method instantiateInitialViewController(). You specify which controllers you use so you can remove "Is Initial View Controller" from the identity Inspector.
If you do step 1. and keep your app delegate the way it is. You should have no problem using the side nav.
If it does not work, please reference this example project for how to do it: https://github.com/CosmicMind/MaterialKit/tree/master/Examples/Storyboards/SideNavigationViewController

@adamdahan I actually solved the issue, by moving the 'login' part to a new storyboard, using that as 'initial load', and then transition (with the SideNavigationViewController) to the 'logged in' storyboard, which has a NavigationViewController.

@LarsDR I do the login / logout pattern you are doing in a lot of apps that are social. The best thing I have found in my experience is to have a view controller that is always at the root of the window. I call this the "BackingViewController".
If the user is logged in then the BackingViewController adds the "Logged in" storyboard's initial view controller as a child via UIViewControllerContainment.
If the user is logged out the BackingViewController swaps it's child with the "Logged out" storyboard's initial view controller.
A few reasons why this is a great idea:

It allows for animated transitions without taking snapshots and writing hokus pokus code.
It is safer because the windows.rootViewController is never modified.
Does not cause the "jump" effect when swapped the windows.rootViewController.

Anyways,
Glad you got it to work :)

@danieldahan Hi,I was wandering why we need so many lazy property.
I mean slideView will always be used ,so I can't see any benifit from using lazy property.

Please try the latest release 1.26.0. There were changes made to the internals of SideNavigationViewController in order to solve the bugs that were described in this issue. As mentioned, we were not able to reproduce the issues specified, so any help in determining if the bug still exists would be much appreciated. Please reopen or create a new ticket if the bug persists. Thank you!

@danieldahan Hi,I Just try 1.26.0 and It' works very well.
Thank you.

Awesome!

Daniel Dahan
M: +1<PHONE_NUMBER>
Skype: djondahan

On Dec 22, 2015, at 8:48 PM, banxi<EMAIL_ADDRESS>wrote:
@danieldahan Hi,I Just try 1.26.0 and It' works very well.
Thank you.
—
Reply to this email directly or view it on GitHub.


Fix defunct keyword 'application' in PengineBuilder()

Simply add the missing keyword.

Looks good, congrats on your first commit!


JavaDocs?

I seem to be unable to find the javadocs for sarxos. Mind pointing me in the right direction?

Javadocs for Webcam Capture API? Download javadocs JAR from Maven Central:
http://repo1.maven.org/maven2/com/github/sarxos/webcam-capture/0.3.11/webcam-capture-0.3.11-javadoc.jar
Extract it (e.g. with WinZip, WinRar, unzip, Archive Manager or whatever) and open index.html to read javadocs.
Just FYI, if your IDE is integrated with Maven and you have dependency defined in POM you just need to ctrl-click on class and it will automatically download both javadoc and sources.


Update upgrading-linux-nodes.md

Translate docs/tasks/administer-cluster/kubeadm/upgrading-linux-nodes into Korean language. I did this for korean people can read this doc easily.
Issue no https://github.com/kubernetes/website/issues/40688

Duplicate https://github.com/kubernetes/website/pull/40716
/close