fail install with brew

Hello,
I'have made a fresh install for zsh and powerlevelk9 and i got lot of error.
I have uninstall all and made install again wiht iterm2, but with the same result
I works with the mac having last mojave version
Thank for help

The problem here seems to be your shell. P9K is a theme for zsh however you are inside a bash. You might want to open zsh first before sourcing p9k

@sambadevi is right. P9K does not work with bash. @cchopin try it with a proper brew install as @sambadevi suggested. Thanks @sambadevi


runtime: recover does not correctly recover from panic

This program should exit normally, but it currently exits with a panic: https://play.golang.org/p/XnJ41HvD9Gw
It exits normally when compiled with gccgo or with -gcflags=-N. Notably, it does not crash with the alternative code I suggested at https://go-review.googlesource.com/c/go/+/286712/1/src/runtime/panic.go#1038. (Discovered this by accident while trying to test gccgo instead and happened to still have that test code patched into my local tree.)
/cc @danscales @randall77

Thanks for the test case @mdempsky .  I fixed this bug and added your test case to https://golang.org/cl/286712  .  I didn't fix the other bug that you filed -- that looks more complex to fix.  But I think we can just go with cl/286712 for the immediate Go 1.16 release (if reviewers are happy).

Thanks for the test case @mdempsky .  I fixed this bug and added your test case to https://golang.org/cl/286712  .  I didn't fix the other bug that you filed -- that looks more complex to fix.  But I think we can just go with cl/286712 for the immediate Go 1.16 release (if reviewers are happy).


Add propTypes to frost-button and allow pack property to be passed in for icon

#PATCH#
CHANGELOG

Added new pack property to frost-button which gets passed down to underlying frost-icon.
Fixed issue with button icons having wrong color.
Updated frost-button to use ember-prop-types for better property validation warnings.

Approved - love the cleanup


Customize the Rel for an Embedded List

By default, it looks like the EmbeddedResourceConverter is setting the property name for the collection to the Rel value of the first IResource in the list of resources.  But, there are many cases where you may have an embedded resource on your object that represents a list of other resources, but you want to control the name of that list.
For example, given a list of BeerRepresentations, you may want to call the list beers: [...] rather than the default which is just beer: [...].

Did a PR for this ever get made?

Yeah, I remember seeing it. Meanwhile must ... finish ... this .... project ....!

closing stale issue


Add missing include and library paths

Adds CUDAFLAGS (from the nvcc activation script) to the NVCC profile because calls to NVCC (not just the host compiler) need to know where to find header files.
I didn't do anything for Windows because it's skipped.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Closes https://github.com/conda-forge/cuda-nvcc-feedstock/pull/19/

cc @robertmaynard

@conda-forge-admin, please rerender


Set-PnPTenantSite -DisableCompanyWideSharingLinks

Does it override the CompanyWideSharingLinks for all existing sites, in effect calling
Set-SPOSite -Identity <site> -DisableCompanyWideSharingLinks
for each site? Or does it change the setting tenant wide (???) enforcing it for new sites as well?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1a3421f8-18a1-e826-41d2-99ca3e54a468
Version Independent ID: c47284f0-fa03-017c-4873-f11a5090c75e
Content: Set-PnPTenantSite (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Set-PnPTenantSite.md
GitHub Login: @techwriter40
Microsoft Alias: kirks

@officedocsbot assign @yogkumgit

Hello @spoman007 Sandeep, how are you? 👍
I will need to kindly ask you to visit this other repo to open PnP issues. PnP cmdlets are maintained by the community, a member of it will pick it up there.
Thanks

@get-itips  Thank you very much for the contribution and sharing this explanation. @kkazala
Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@yogkumgit
Yes, I do believe the update to documentation is needed. This is why I reported this issue from within the documentation page
May I ask you to look into this? Thank you in advance :)

@kkazala
Documentation for PnP cmdlets is directly referenced from the PnP source code that is in the repo I pointed out.

@kkazala kindly follow the link Andres has suggested. Thanks.

At the bottom of the https://docs.microsoft.com/en-us/powershell/module/sharepoint-pnp/set-pnptenant?view=sharepoint-ps page, there's a Feedback section which we can use to report issues.
And as a customer, I expect to report the issue there, and Microsoft to either respond or to reassign the issue to another repo
Instead you tell me that it's my job to report the issue again? And you prefer to write me 5 different messages telling me where to report it again, instead of just doing it yourself?
Wow
I'm just going to test it by myself, it's easier and faster
thank you for your time

At the bottom of the https://docs.microsoft.com/en-us/powershell/module/sharepoint-pnp/set-pnptenant?view=sharepoint-ps page, there's a Feedback section which we can use to report issues.
And as a customer, I expect to report the issue there, and Microsoft to either respond or to reassign the issue to another repo
Instead you tell me that it's my job to report the issue again? And you prefer to write me 5 different messages telling me where to report it again, instead of just doing it yourself?
Wow
I'm just going to test it by myself, it's easier and faster
thank you for your time

Hello @kkazala Kinga, how are you ? 👍
I can understand your frustration, you are right, the feedback section leads you here, as the team behind it is working on a solution, I was instructed to kindly redirect anyone to the right place where they will get an answer. I am a collaborator on this repo and I try to do my best.
Hope this clarifies it to you, have a nice day!


potential alternative to mpl-point-clicker

Hi @prajayshah and others
awesome to see that your considering using mpl-point-clicker! If you ever need help with it feel free to ask on discourse.matplotlib.org and I can try to help.
But what I wanted to mention is: I'm not exactly clear on your use case, but if it's selecting specific data points then you might consider another of my maptlotlib tools: scatter-selector-widget which is in the mpl-interactions package.

Hi @ianhi
Thanks very much for your comments and suggestion! my use case so far was to click retrieve specific datapoint on line plots specifically (see attached screenshots). i adapted mpl-point-clicker for this, it was a little finicky but I managed to get it to work.
i didn't know about the scatter-selecter-widget, it does look useful as well. would it work for lineplots? or is there another tool you suggest for selecting datapoints on lineplots?

i didn't know about the scatter-selecter-widget, it does look useful as well. would it work for lineplots? or is there another tool you suggest for selecting datapoints on lineplots?

currently it does not work for lineplots - although it really should be made to work with them. all that scatter selector is doing is providing a wrapper about the matplotlib pick event. All the real work happens here: https://github.com/ianhi/mpl-interactions/blob/8f718e6f000baeccbf71319cbf0d1aab46303963/mpl_interactions/widgets.py#L35-L53
see https://matplotlib.org/stable/gallery/event_handling/pick_event_demo.html for a comprehensive demo of that event
So you can probably just borrow from that to use it with line2d. Though an optimal implementation would also have the option to draw a point over the point closest to the mouse as you moved it around.
If you make any progress towards getting something like that working I'd be happy to accept a PR adding it mpl-interactions :) and also could help you work on the implementation

good to know! ill follow up with a PR if I end up working on that further at all myself.
closing this issue here for now :)


Add arXiv paper to README

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   99.81%   99.81%
=======================================
  Files          18       18
  Lines        1095     1095
=======================================
  Hits         1093     1093
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b82bb...ea59588. Read the comment docs.


bump node 22.x.x LTS

Applied mkpr on package.json
sed s/"node": ">=22\.9\.0"/"node": ">=22.11.0"/

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.301%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
122

Relevant Lines:
122

💛  - Coveralls


ci: Update Buildifier

https://github.com/bazelbuild/buildtools/releases/tag/6.1.0

pulling random bins down into the build system

...you mean the linters and code coverage uploader that are only used in the CI?

...you mean the linters

wow buildifer is a horrible name for a linter :<
yes... seems that's what I mean

Yeah, it's not obvious Buildifier's a linter unless you know about it previously. :P It formats and lints our Bazel build files.


Livelab 912 Setup JMS

WMS 912
General requirements

Information in the workshop is adequate and updated
Code is correct and working
Links are correct
Make sure you enter the help email link in your manifest.json
Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list
Please confirm that the following is completed before submitting your PR

[x] All filenames are lower case (including folders, images, files, etc.)
[x] Filenames are descriptive
[x] Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
[x] Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
[x] Image references in markdown contain an alternate text

Modified the name of livelab 2 in introduction.

Removed the references to free tier in prerequisite as required by self QA


Release Google.Cloud.Gaming.V1 version 2.1.0-beta01

Changes in this release:
New features

Enable REST transport in selected APIs. Set GrpcAdapter=RestGrpcAdapter.Default in the client builder to use this transport (commit 5008946)

Created release for Google.Cloud.Gaming.V1-2.1.0-beta01


Send Message and Typing

Hello Team,
is there ant documentation how to handle send messages with typing methods to avoid whatsapp block bots .
Best Regards

I do this
send Typing 5sec
Send message
Send stop typing

is it working good, and whatsapp doesn't block your numbers ?

@Saifallak  why stop typing after we sent message, can we do :
send Typing 5sec
Send stop typing
Send message

@mitnick2012 no reason, just though of how i do it on my phone,
typing, send, stop typing
for blocking part:
meta will not block you if you're not spammer, and if they did, it's easy to unblock by contacting them.
anyway, all of that on your own risk.

Thanks for explanation


Update README.md

godoc.org is deprecated
pkg.go.dev is actual site for documentation

The Go Team is still working on getting pkg.go.dev up to snuff.  It still is missing features and has bugs.
This PR is not needed at this time.

@tooolbox @KosToZyB Would we say https://pkg.go.dev/github.com/robfig/cron is now up to snuff?


Check if data points exist every loading of project

Description
Fixes #283
Check the issue for more details
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Tested on?

[ ] Windows
[ ] Linux Ubuntu
[ ] Centos
[x] Mac
[ ] Others  (State here -> xxx )

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged

@YCCertifai @kengeSkyMind check the issue #283 for information
if there's no problem,
the last one who approved merge the code.
this will be included in 1.1.1
thanks guys

@YCCertifai @kengeSkyMind check the issue #283 for information
if there's no problem,
the last one who approved merge the code.
this will be included in 1.1.1
thanks guys


Add support for custom default flag values

Hi guys,
We would like to be able to set custom default values for our flags in order to improve our "sane defaults" strategy. Not all of our flags will have false/null by default. I have added support for this in this PR.
Cheers,
Olga

Hi @matthewelwell I have made the changes requested :)


About onng

Is NGT only able to implement the onng algorithm via the ngt command? How does ngtpy implement onng algorithm? Ann-benchmarks seems to be the onng algorithm implemented by the ngt command.

I have just released NGT v1.7.7 that includes the graph reconstruction function (Optimizer) for ngtpy. However, it does not include any manual of it yet. Now I am just writing manuals about it. Here is a brief example.
# ngt reconstruct-graph -m S -o 10 -i 120 anng_path onng_path
optimizer = ngtpy.Optimizer()
optimizer.set(num_of_outgoings = 10, num_of_incomings = 120)
optimizer.execute(anng_path, onng_path)

Optimizer will also help you.

@masajiro thank you! I separated a small dataset of 10000 in gist1m. I built an empty index, adding 100 vectors to it, up to 10,000 each time. I set the query to return 100 neighbors, but only 42 neighbors were returned during the test. When I test in gist1m, I can return 100 neighbors normally. Is the data set of 10000 too small?

It is not too small. Before calling the optimizer, could you check if you can get 100 neighbors?

Here is the Optimizer reference to construct ONNG.


warpctc: module object has no at tribute 'WarpCTC'

I build the mxnet from source and follows the step in #7002.But I found it works well if I use python3 but error occurred for python2----"AttributeError: 'module' object has no attribute 'WarpCTC'"

@Mendel1 - Did you make clean, set right path in config.mk and rebuild mxnet?
Here is the issue with solution discussed -
https://github.com/apache/incubator-mxnet/issues/2587
Please reopen if issue persist.


Updating to the same version

Whenever I click on update or update all:

Uninstalled and installed again but the issue persists.
As a side note, also this. The version seems to have an incorrect format (0..8.6)

Same issue, same details.  Code says it's 0.8.7 on the modules page (not the pop-up install page, but the general overview page).

Should be fixed now. Reopen if I'm wrong


OpImageSparseRead must not be used with an image with Dim = SubpassData

An image with Dim = SubpassData can only be used when sampled = 2, i.e. not sampled.   The image instructions that operate on an image "without a sampler" are OpImageRead, OpImageWrite, and OpImageSparseRead.  The first two explicitly say what happens if Dim =SubpassData.  Need to handle OpImageSparseRead; I suspect you're not allowed to use Dim = SubpassData in this case

Dim = SubpassData is intended for on-device cached tiled.
The sparse memory concept is fo binding to memory buffers with more flexible residency and partitioning, definitely not the same use for SubpassData

Fixed with #1129


No shading funcitonality as per Readme.

The Readme claims that there's not only coloring but also shading functionality, however in the linked v4.5 it could not be found, while the video mentioned there is no longer available.
From what I found in other videos online, shading was already available in v4.1.8, why was it removed in 4.5b?

https://github.com/lllyasviel/style2paints/issues/140#issuecomment-632072647

Is there a way to download a compiled old version? Since the videos weren't made by the creators (I think), it must've been distributed.

Style2Paints V4, which contained the shading algorithm, was provided as an online service around the year of 2018 (No offline version). Now, the GPU server has been shut down due to high fee.
Perhaps DeepNormals may offer some lighting effect.


get the database

Hi , thanks for the great efforts , it is really useful tool , but is the database available as well ? do you have seeds for it ?
Thanks.

Hi,
The seeding is done be the two commands listed below. Now that I think about it, these could be moved to database seeders instead of commands. Basically they parse the official Onix codelists from JSON and then insert the models to the database. Does this answer your question?
https://github.com/lasselehtinen/onix-codelist/blob/master/app/Console/Commands/UpdateCodelists.php
https://github.com/lasselehtinen/onix-codelist/blob/master/app/Console/Commands/UpdateElements.php

That's great thank you very much.

Hi I've tried that out , I got the codelist seed in my local db  after making a minor modification on "UpdateCodelists.php"
Perhaps  the onix freed structure has been changed from how it used to be

I will make a pull request if you find it useful to merge it :) ,
Thanks again for the help

The PR has been now merged. Seems like they indeed changed the JSON structure at some point.


Adding readthedocs

This PR adds readthedocs to qlf with:

Frontend/Backend overview
How to install QLF
How to run qlf with docker
How to change desispec version
How to change bokeh plots

Available at https://qlf.readthedocs.io/en/latest/index.html

@felipeaoli I just added the steps to add a new metric on qlf can you please review this pr?


The argument type 'Future Function(OpeningDetails, dynamic)' can't be assigned to the parameter type 'Future Function(OpeningDetails)'

    // Runs after all the migrations but BEFORE any queries have a chance to execute

    beforeOpen: (engine, details) async {
      engine.customStatement('PRAGMA foreign_keys = ON;'); //shows error here

      if (details.wasCreated) {
        // rest of the code

"The argument type 'Future Function(OpeningDetails, dynamic)' can't be assigned to the parameter type 'Future Function(OpeningDetails)'" This is thrown when I write custom statement to enable foreign keys.

Just solved this by removing the first parameter "engine" and simply changing the code to:
    // Runs after all the migrations but BEFORE any queries have a chance to execute

    beforeOpen: (details) async {
      await customStatement('PRAGMA foreign_keys = ON');

This works.

Yes, just using a single details parameter is the right way to go here.
Does the documentation still refer to the old (engine, details) function somewhere? If so, please let me know and I'll fix that, thanks!

@simolus3 No, it doesn't. The documentation is updated. Thanks !


Revert "Remove no longer needed custom fingerprints"

This reverts commit 05f2c7c8ecfa4c222d59431d999833503f267cbd, reversing changes made to 5a4f0857df455c0d478a74cf9dda5e8a2b15b09d.
Sentry is getting confused about which stack trace frames are in-app vs outside-app. So it's merging unrelated exceptions together.
I think we should be able to tweak Sentry config to do the right thing but for now I'll revert the PR.

Let's try this.


Move addStablePoints from solver to post-solve

Calculating the "stable points" mNrmTrg and mNrmStE is a costly operation that is not useful in most contexts. This commit moves that code out of the solver and into a method on IndShockConsumerType, which is called as part of post_solve only if it is appropriate. The results get put into both self.bilt and self.solution (for compatibility with tests).
Please ensure your pull request adheres to the following guidelines:

[ ] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[ ] Updated documentation of features that add new functionality.
[ ] Update CHANGELOG.md with major/minor changes.

All tests pass, adding changelog entry.

@sbenthall @alanlujan91 The fixes for this were extremely tiny: Add missing T_cycle definitions in one notebook and add on a missing string declaration in check_conditions-- one of the "GIC_message undefined" errors was because it meant to define a string, but didn't. Should be ready to merge.

looks good to me!

It looks like this was approved but then never merged. In doing some work today, I became confused that the code didn't look the way I expected. I'm going to see if this can be rectified with the current master branch.

sorry, I guess I approved it but was waiting for @sbenthall's review

I apologize for my part in any miscommunication around this.
It will be great when this gets merged in.

All tests should pass now. I'm having the same issue as Alan: running black locally does not generate the same formatting as the remote's version of black.

@sbenthall This passes tests now and is up to date with master. The only file that's substantively changed is ConsIndShockModel.py; the other three files are tiny compatibility adjustments.


Sprite accelerates slower in Y direction than in X direction

In this simple program (https://makecode.com/_9RwKijPorHxC) in Arcade Beta, we set ax and ay and follow the values of vx and vy as the sprite moves.

When we set ax and ay to the same value (e.g. ax = 0.2, ay = 0.2) everything behaves as expected.
When we set ax and ay to the same value (e.g. ax = 0.2, ay = 0.2) everything behaves as expected.
When we set ax and ay to opposite values (e.g. ax = -0.2, ay = 0.2) then vy increases at half the rate of vx and sometimes stops increasing in value for several steps.
When we set ax and ay to opposite values (e.g. ax = 0.2, ay = -0.2) then vy increases at half the rate of vx and sometimes stops increasing in value for several steps.

The same problem happens for ax and ay greater than 1, but only if there's a decimal component (e.g. ax = 2.2, ay = -2.2).
Is there a precision problem here?
Thanks.

@riknoll is this a bug or somehow expected behaviour.

it's a bug


Policies in service templates are serialized not as a list

According to 3.9.2 in the TOSCA spec, policies in a service template must be serialized as a list of policy definitions. Like in this example:
policies:
    - my_anti_collocation_policy:
        type: my.policies.anticolocateion
        targets: [ my_co_location_group ]
        # For this example, specific policy definitions are considered
        # domain specific and are not included here

Currently, Winery serializes policies in a map.

Fixed by https://github.com/OpenTOSCA/winery/pull/216

@zhululai the latest GMT image will now serialize policies as a list.
@duelle we'll also update the examples in the particles in the hours/days.


[XLA] Thunk to cudnn fp16 kernels for F16 batchnormalization and enable cudnn for batchnormalization by default

When using cuDNN for batchnormalization, xla currently thunks fp16 batchnorms to fp32 kernels by casting fp16 inputs and gradients to fp32 in the tf2xla bridge. This is non-optimal since cuDNN 7.6 has highly efficient Half kernels that can be leveraged. This PR modifies cudnn_batchnorm_rewriter and cudnn_batchnorm_thunk such that the converts introduced in the bridge get eliminated and the corresponding fp16 cudnn APIs get called.
Note that instead of eliminating convert ops, I add converts which then get eliminated by algebraic_simplifier. PR adding capability to eliminate of convert pairs was merged earlier.
While investigating performance of mobilenet, it was found that enabling cuDNN for Batchnorm improves performance by around 10-12%. Running the numbers for a set of convolutional networks in addition to mobilenet with cuDNN turned on for Batchnorm, showed that enabling cuDNN, either improves performance or keeps it the same. This PR enables cudnn for batchnorm by default  based on the above-mentioned performance enhancements.

I'll create 2 separate PRs and address the comments.

Pushed another commit incorporating most of the comments. Figured it would be convenient to address most of the comments here before migrating to the 2-PR submission. Will address the refactoring to use templates in the subsequent PR.

Pushed another commit incorporating most of the comments. Figured it would be convenient to address most of the comments here before migrating to the 2-PR submission. Will address the refactoring to use templates in the subsequent PR.

Thanks Ayan, LMK when this is ready to review.
Btw, do you have a microbenchmark showing the performance difference between XLA's batchnorm and cudnn's batchnorm?

Sorry for the delayed response. Using tf_cnn_benchmarks in https://github.com/tensorflow/benchmarks for mobilenet_v2, the most recent numbers that I have are as follows:
With cudnn BN: ~4500 images/sec
With Fused kernel BN: ~3200 images/sec
This is on a GV100. Note that this is based on fairly new repo but not the latest. The latest tensorflow has some refactors that causes the benchmark script to fail (tensorflow contrib has been refactored somehow). The benchmark scripts haven't been updated to reflect those changes. A few weeks back, I had the numbers looking like this:
With cudnn BN: ~4500 images/sec
With Fused kernel BN: ~3800 images/sec
The numbers seems dynamic but it is clear that at this point cudnn batchnorm performs better than the kernel fusion.
I actually investigated the kernel fusion for batchnorm and found that the difference is predominantly due to GTE thwarting fusion of multioutput fused kernels. Infact there are other cases where see that FusionFusion merger (i.e, fusion across GTE ) is the bottleneck.

@sanjoy I have pushed the PR to thunk to cudnn (https://github.com/tensorflow/tensorflow/pull/32887). Please take a look. I will create a new PR with the cudnn_batchnorm_rewriter changes once this PR is merged. The rewriter changes are dependent on https://github.com/tensorflow/tensorflow/pull/32887 getting merged.

@AyanmoI Can you please resolve conflicts? Thanks!

@sanjoy Please take a look at https://github.com/tensorflow/tensorflow/pull/33259 which handles fp16 batchnorms in cudnn_batchnorm_rewriter. Please note that https://github.com/tensorflow/tensorflow/pull/33259  addresses all the comments you made in this PR.

@AyanmoI Can you please resolve conflicts? Thanks!

@gbaned This PR has been split into 2 parts actually. Part 1 https://github.com/tensorflow/tensorflow/pull/32887 has already been merged. Part 2 https://github.com/tensorflow/tensorflow/pull/33259 is up for review. I will close this PR eventually. I had just kept this around as a reference.


Display attendance information correctly on profile page and keep track of user's bonus days

Look at the first 2 commits to see the pre-jshint changes.
Fixes #138
also fixes #228

eek! bonusAttendance should be a virtual! This will break attendance!

we can detect bonusAttendance days from the ClassYear

i.e. ClassYears keep track of bonusAttendance days, so you can reference a users attendance from bonusDays

other than that- this is good refactor

Small Group contains the fix for #228 already (it was lodged in one of the early commit messages)

I think we should try to do linting changes in separate pr's much cleaner and easier to merge worry free

I was planning on it, but my editor did some by accident. Also, seve - fixing 228 it was a side effect of making the bonus days work. I'll refactor once your code is merged

And for the bonus days - its cleaner so that activities that happen to be on the same day as a meeting can have a bonus code.  (Potentially we should also do that in general, so you can have more than one code per day)

:+1: let's merge after small groups

this WILL still break live site attendance- the result will be those who attended a bonus day will get a valid day of attendance

@kmcnellis how is this going?


Fix Firefox subpixel rendering bug

Applies a minimal 1px outline to all shadows and rebalance other shadows in order to fix Firefox's subpixel rendering bug.
Fixes #414
I'm conflicted on whether this should actually be solved this way. Ultimately, this is Mozilla's fault in rendering subpixel shadows incorrectly (there's really no room for debate on this as far as I understand it - if designers intentionally create a shadow with subpixel parameters, the mathematics of computing those partial values is unquestionable. Their rendering engine is handling these wrong.)
This fix not only sets a precedent of even more complicated manual shadow definitions, but it also actually fucks up the way these shadows render on Chrome-based browsers. The downgrade isn't huge (as it is balanced to be fairly decent for both), but especially on 4K+ displays like mine, you can tell the faint 1px solid border is there and it doesn't look quite as crisp and "3D" as before this change.
I don't have an issue with having a fix for their bug anyways, but the way this is implemented is quite complicated. It would be nicer if we could code-gen something that doesn't require us to manually add these to each shadow definition.

Maybe use Sass/SCSS and have a function that creates an optimized pseudo-3D border/shadow given a few parameters?

Maybe use some sort of browser query to downgrade these shadows to a small selection of basic 1px borders if the user is on Firefox?

The depressing alternative to any of the above is to do what almost everyone else has done and use a more flat design style with simple 1px solid borders everywhere (e.g. GitHub, VS Code, ...) and totally give up on our nice pseudo-3D border shadows and the subpixel imbalances that give the great feeling we have today.
Personally, I'm a big fan of the way it looks, but there's also nothing wrong with the standard flat rectangles and solid border stuff, so the pain is more about what we'd lose than what we'd end up with.


East and West Cowes IOW

Both entries are also in the Gazetteer as HAM.
In each case please move the HAM search records to the IOW entry and remove the HAM entry.
Please move the search records for Cowes IOW  and Cowes I O W to the Cowes entry and remove these entries.
The only entries that should remain are the IOW entries.
Geoff

Done


Support Except field of NetworkPolicy

Fixes #71

@lzhecheng could you try your e2e test based on this PR? I tested manually and it worked as expected.

/test-e2e

/test-e2e

/test-e2e

@tnqn , I think you have triggered the e2e test. Do you mean anything else ?

@tnqn , I think you have triggered the e2e test. Do you mean anything else ?

@lzhecheng I only meant the e2e test you wrote, after I asked I looked at e2e README and found it's quite easy to run it so have tested it manually. Please ignore my request.


Making changes to config.yaml on docker

I am running Martin on Docker with Docker-compose file. I am trying to figure out how to make changes to config.yaml file while Martin is running.
In order to retrieve config.yaml file I have come up with a hacky solution. I run this docker-compose.yaml file:
version: '3'
services:
 martin:
   image: ghcr.io/maplibre/martin:v0.8.7
   restart: unless-stopped
   ports:
     - "3000:3000"
   environment:
     - DATABASE_URL="url"
   command: --save-config /home/config.yaml

This save a config file in /home dir. Then I am able to run this command to retrieve it:
docker exec container_id cat /home/config.yaml

Now, I have a config.yaml file locally which I can edit and probably let Martin use with command: --config /home/config.yaml in Docker-compose.yaml.
Very hacky solution. Is there a better way to do it?

You can do one of these:

just run martin binary locally - you don't need any dependencies, just the binary download from github's releases
map a local dir to docker, and save the file there. See this question, and use --save-config to save to the mapped dir. This way you don't need to docker exec, and you can simply re-run docker later and pass --config instead of --save-config to use modified configuration.


Declare Python 3.4 as incompatible

Python 3.4 testing has been dropped in #608, but it was not declared as incompatible in setup.py because the code base was expected to still work with Python 3.4 for a while. This compatibility finally broke with the 21.1.0 release. At least one of the problematic commits is e09b1d642339d7d94ba58d7855da40e65ed1a88f introducing an import of the typing module not available in Python 3.4.
Trying to import attr with Python 3.4 gives the following exception:
>>> import attr
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/gosmannj/Documents/projects/attrs/.venv/lib/python3.4/site-packages/attr/__init__.py", line 7, in <module>
    from . import converters, exceptions, filters, setters, validators
  File "/Users/gosmannj/Documents/projects/attrs/.venv/lib/python3.4/site-packages/attr/converters.py", line 8, in <module>
    from ._make import NOTHING, Factory, pipe
  File "/Users/gosmannj/Documents/projects/attrs/.venv/lib/python3.4/site-packages/attr/_make.py", line 34, in <module>
    import typing
ImportError: No module named 'typing'

Alternatively, it might be a possibility to add the typing backport as dependency for Python 3.4 installs. But I suppose this is not desired as official Python 3.4 support has been dropped.

Ah yes I wanted to test it before releasing but found it too cumbersome to find a working 3.4. 🙈

Hi @hynek, I just encountered this in my CI. Would you consider yanking 21.1.0 and posting a new release with the correct python_requires so that pip installs the correct version?

Yes, I was thinking that.

21.2 is on PyPI, 21.1 is yanked.

Just a heads up: unfortunately it seems that the last pip version compatible with Python 3.4 predates yanking packages, so it still finds 21.1.0. So those of us still testing on 3.4 have to work around this by specifying attrs <21.
This isn't a criticism - it's just part of the reality of keeping older things working. I just thought I'd leave a note here for anyone else wondering why the problem doesn't seem to be solved. :slightly_smiling_face:

Aw crap, I hoped/thought yanking’s served-side. :(
Thanks for letting us know Thomas!

No worries. Unfortunately, I think there's no way it could be purely server side and still allow the yanked version to be installed if that specific version is pinned, because pip doesn't tell the server that it's looking for a specific version.


no performance increase for multi-GPU

I'm noticing that the performance is not affected at all when using multiple GPUs at a time, although the code seems to use DistributedDataParallel, I'm confused.
The number of batches per epoch is the same, and the seconds per iteration are the same ( I use tqdm to measure it)
There is one change in my code however, I set DDP(....., find_unused_parameters=True), I've tried it both, enabled and disabled, and still the speed is the same.
for quick checking, I advise just using tqdm around the epoch loop
for batch_idx, (x, x_lengths, spec, spec_lengths, y, y_lengths, speakers_or_embeds) in tqdm((train_loader),
        '', len(train_loader), disable=writers is None):

Speed on VCTK dataset, for both single GPU and multiGPU (4x RTX 8000):

293.8784s/epoch
1.63sec/batch

Find the environment information bellow
$ python -m torch.utils.collect_env
Collecting environment information...
PyTorch version: 1.6.0
Is debug build: No
CUDA used to build PyTorch: 10.2

OS: Pop!_OS 20.04 LTS
GCC version: (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
CMake version: Could not collect

Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: Quadro RTX 8000
GPU 1: Quadro RTX 8000
GPU 2: Quadro RTX 8000
GPU 3: Quadro RTX 8000

Nvidia driver version: 470.63.01
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.0.5

Versions of relevant libraries:
[pip3] numpy==1.18.5
[pip3] torch==1.6.0
[pip3] torchvision==0.7.0
[conda] numpy                     1.18.5                   pypi_0    pypi
[conda] torch                     1.6.0                    pypi_0    pypi
[conda] torchvision               0.7.0                    pypi_0    pypi

nevermind, just noticed that batch size gets doubled and that's why the time per step doesn't matter


PF-435: Confirmation prompt for delete commands.

Added a confirmation prompt for all delete commands: groups delete, resources delete, workspace delete.
Are you sure you want to delete (y/N)?
Added an optional --quiet flag to suppress the interactive prompt.
Updated all existing tests to use the --quiet flag. Added new tests for the interactive option.

There was 1 unit test failure with a SAM socket timeout exception: ClientExceptionHandling. I ran it locally and it passed.


login bug

Describe the bug
login:error:googlesignin.null:developer_error
To Reproduce
Steps to reproduce the behavior:
tap login with google
Expected behavior
login:error:googlesignin.null:developer_error
Screenshots
Couldn't get it sorry
Smartphone (please complete the following information):

Device: [Galaxy A56 5G]
OS: [Knox or One UI, Idk which]
Version [13]

Additional context
Also when asking to send a forget password thing no email is sent or I just haven't gotten it yet.

I don't have access to pc right now.
But it's no issue to read Novels without loginig in.


[SOLVED] ImportError: cannot import name 'image_from_url_text' from 'modules.generation_parameters_copypaste' (/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/generation_parameters_copypaste.py)

whenever i try to run the ui it throws me this error, help!! it used to work just fine

I solved by using the solution given in 183 issue which consists of cheking the "update repo" option when running the second cell


Weird characters when connected to PowerShell via ssh

I am using your iOS terminal to communicate with BASH and Powershell remote servers. When I connect to a BASH session, everything works as expected. But when I connect to a PowerShell session, every time I type something, only garbage characters are displayed. Yet when I press RETURN, the correct command executes. For instance:
I connect to a macOS 11 machine running PowerShell as its default shell. I get:
PowerShell 7.1.3
Copyright © Microsoft Corporation.

https://aka.ms/powershell
Type 'help' to get help.

PS /Users/frios>

All is good until I start typing. I type
d
and I get
d$<5>
then I type i and the d disappears and I get
$<$<5>
then I type r and I get
$<5$<5>
If I then hit return I get the proper directory output on the screen but if the screen is full, the cursor jumps to mid screen.
Anyone seen this type of behavior before?

I did not set my shell to pwsh, but I tried logging into my machine with it, and could not reproduce it.

Thank you. I am trying to figure out where the issue is occurring... is it a terminal issue or something else in the chain. It does happen consistently when I use SwiftTerm library in my iOS app to log into any server that has pwsh as its default shell: Windows, Mac or Ubuntu (Arm or X86-64). It is an input issue; i.e. it only occurs to characters I type. The interesting thing is that as far as I recall, this used to work fine at the end of last year. Any suggestions where I should start debugging to see if I can figure this out?
Thank you.

I would suggest that you log all the data that you receive and send, so you can take a look at what is going on.
One possibility is that you are not passing an environment to the remote site that allows it to operate, perhaps something like the TERM variable not been passed, or some other expectation is not really being met.

I have traced my input and output through my ssh layer and through the terminal layer.
(I am using ipworksSSH as my ssh layer)
I am setting the terminal type to vt100.
When I connect to a pwsh terminal, then I type the letter d, I get back in my ssh layer's stdOut method
d

$<5>
I can see the d at the end of the first line, then a bunch of control sequences. I pass all of this from my ssh layer to a TerminalView instance's feed method as a byteArray. I assume that the control sequences would be eventually handled by the parser.parse method. Is that not correct?

I tried setting up an account, with pwsh, but when I do, and I try doing sudo to it, I get:
"/usr/loca/bin/pwsh: no such file or directory"
Even if it is there, and I have execute permissions.

OK so I have a break point in my SSH onStdOut function. When I type the letter d I get on the first break:
1b 5b 39 33 6d 64 ( this should be setting the foreground to yellow and typing the d)
I hit continue and I get
1b 5b 33 37 6d 1b 5b 30 6d (sets a white foreground, then default foreground)
I hit continue again and I get
1b 5b 32 34 3b 31 39 48 24 3c 35 3e (no underline and some other stuff)
Then its done for that input.
Esc sequence interpretations from here: https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences

I tried setting up an account, with pwsh, but when I do, and I try doing sudo to it, I get:
"/usr/loca/bin/pwsh: no such file or directory"
Even if it is there, and I have execute permissions.

On an Ubuntu server, mine is located at /usr/bin/pwsh

I setup an Ubuntu machine to try this, and it works fine:

I am using the iOS sample in the project

The 3c 35 3e sequence being "<5>" is not part of xterm/vt100 infocmp, so I suspect that you have the wrong TERM value.
What is the TERM value?
Try running this:
PS /home/pwsh> env

The Term value is TERM=xterm-256color

OK, I set my SSH layer to xterm-256color and that definitely fixes the weird character problem!  Thank you for the help. I still have another issue, but I will attempt to figure out what is going on first, I think it might be a terminal size issue.
But thank you!

Great news!


BBBC022 on s3://cytodata cannot be downloaded

I'm trying to copy the BBBC022 profiles from cytodata s3 bucket to set up a benchmark pipeline for our cell painting method development. I can list the files in the bucket, but cannot copy or sync anything. Could you please change the permissions accordingly?
Thanks.

@tilenkranjc Sorry for the inconvenience. I am in the process of getting all of the cytodata datasets moved over to the cellpainting-gallery. Once that is complete, you'll be able to access BBBC022 there as cpg0030-gustafsdottir-cellpainting.
In the meantime, there are many other Cell Painting datasets already available in the cellpainting-gallery that you might be able to use instead?
@shntnu I too can only ls cytodata so I need your help to fix permissions before I can complete the transfer of Bioactives-BBBC022-Gustafsdottir (cpg0030-gustafsdottir-cellpainting) and LUAD-BBBC043-Caicedo (cpg0031-caicedo-cmvip).

Thanks for the info. Yeah, happy to wait for the data to be transferred.
Meanwhile, I used the original features from the bbbc website. BBBC022 is kind of convenient dataset for benchmarking, that's why it'd be great to have the processed features data.

@tilenkranjc The data has been transferred to cellpainting-gallery as cpg0030-gustafsdottir-cellpainting.
Please feel free to ask questions in that repo if you have any trouble accessing the files.


added new sample tab-react-router

Q
A

New sample?
yes

Related issues?
mentioned in #284(https://github.com/pnp/generator-teams/issues/284)

What's in this Pull Request?
Added new sample to explore how to make yo team generator based teams app tab to use React Router

Great sample; thanks very much!


Fix environment handling from containers.conf

Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

Fixes https://github.com/containers/libpod/issues/5685

LGTM once things go green. I have some questions, but they're unrelated to this PR.

@giuseppe PTAL

LGTM

@rhatdan all kinds of test unhappiness.

Yes for some reason, my new test will not pass, although works when I run this by hand.  Will continue playing with it.

/lgtm
/hold

/hold cancel


Adding jake serve

Just a small quality of life improvement. Let's you serve without switching to pxt-microbit

@pelikhan good idea! I added one


fix: Reset allowed callers cache when switching between project settings

Description
Reset allowed callers cache when switching between project settings
Task Item
Closes #7866
Screenshots

Coverage decreased (-0.001%) to 50.567% when pulling c66a7c25b48d9ad7abed83f2a8075885516be956 on durnford/fix/allowed-callers into 008fa93680f4fa76519414977208e123ce5309bf on main.


Does not support non-querystring pagination

Correct me if I'm wrong, but it seems this library is making assumptions about how pagination should be propagated via the URL. Specifically, it assumes:

The pagination parameters will be part of the query string.
The query string keys are hard-coded to page and pp.

This obviously does not support URL pagination formats such as http://example.com/my/page/123.

Hello.
Yes, for the moment this pagination only supports: ?page=X and &pp=X.
Thanks


Auto indentation fails with javascript functions

VSCode Version: 0.10.11
OS Version: OS X 10.11.3

Steps to Reproduce:

Write a JS function like this:

   .run(function (Config) {
    // some code here
    });

press alt+shift+f
Result:

 .run(function(Config) {
    // some code here
  });

The whitespace between function and (Config) part gets deleted, which leads to our linter crying!
Expected result:

 .run(function (Config) {
    // some code here
  });

Bug.

VSCode 0.10.12 will offer a setting for this:
	"typescript.format.insertSpaceAfterFunctionKeywordForAnonymousFunctions": true

@dbaeumer isn't that something that VSCode should find out from linterfiles? So for example if we have eslint enabled and the option  "space-before-function-paren": [2, "always"] exists, the auto-indent shouldn't delete the space?


504 errors for /sim/search when limit varies

Thanks so much for maintaining this API. I've been running queries with /sim/search and I keep getting 504 Gateway Timeouts when I change the limit setting. I also occasionally get 500 errors. See below for examples, I'd really appreciate any help to solve this.
Query 1 (limit = 10)
https://api.monarchinitiative.org/api/sim/search?is_feature_set=false&metric=phenodigm&id=MONDO%3A0001134&limit=10&taxon=10090

Query 2 (limit = 5)
https://api.monarchinitiative.org/api/sim/search?is_feature_set=false&metric=phenodigm&id=MONDO%3A0001134&limit=5&taxon=10090

we've recently updated some limits that should result in better performance moving forward, please let us know if you continue to see issues.  Also feel free to reach out to discuss your analysis needs - https://monarchinitiative.org/help/contact


Thoughts on Freenginx

I noticed this link today and the content is quite eye opening: https://www.infoq.com/news/2024/03/freenginx-ngnix-web-server/
It talks about security concerns with F5 and I was wondering if you’d consider adopting the new fork to embrace a more safer and secure path forward which sticks with the original intentions of Nginx
As of now the source code is not available in GitHub but in Hg (Mercurial), I’m keeping an eye on it to see if there will be a container image or not to simplify things.
Code: http://freenginx.org/hg/nginx

I found this unofficial mirror: https://github.com/freenginx-mirror/nginx

Be aware that this project uses OpenResty, not nginx.

Be aware that this project uses OpenResty, not nginx.

The name threw me off 😅


API documentation generation using Jazzy

New Issue Checklist

[x] I have tried with the latest version of OHHTTPStubs
[x] I have read the README
[x] I have read the Using the right Swift Version of OHHTTPStubs for your project section
[x] I have searched in the existing issues
[x] I have read the OHHTTPStubs wiki to see if there wasn't a detailed page talking about my issue

Issue Description
I am wondering if it would be nice to add jazzy to generate the API documentation.
This would:

expose the code documentation automatically, reducing the workload of maintaining the README and the wiki
add information about API documentation coverage: we could then see if the API is fully documented

I'm not sure there's any point on doing that ourselves while CocoaDocs already does that for us?
http://cocoadocs.org/docsets/OHHTTPStubs/

Note that if you click on the
badge in the README it will send you straight to that API documentation on CocoaDocs already. That's pretty standard for README files of most pods :wink:

Oh right! I did not notice that! Thanks!

CocoaDocs is shutting down at some point iirc

CocoaDocs is indeed sunsetting as Ashton-W mentioned. See the maintainers blog post here.

Ok so it will be a thing that we will need to address in the near future. I'll let this issue open to remind ourselves of this.


Investigate skip_before_x actions

Followup on an issue that surfaced in #38.

@gblakeman I confirm that neither of the skip_before_action :check_for_lockup nor the skip_before_filter :check_for_lockup work right after the server has been restarted.

But they do work if I make a change to the application_controller.rb and the ApplicationController code gets re executed. (in development mode)

It looks like a bug.

@gblakeman Is this still an issue? Does this only affect 4.1.X?

@guaguasi I was never able to reproduce it and was leaving it open to investigate further, but haven’t had the time.

I have not been able to re-produce either. Closing it for now.


Add a docs project using tut.

The goal here is to type-check our docs to avoid code rot. We
desperately need more docs and this is a way to help ensure we keep
things up-to-date.
Eventually we'd like to use sbt-microsites. Right now these aren't
compatible with sbt 1.0, so we're going to produce markdown
documentation here and figure that we'll eventually be able to put it
somewhere.
Apologies to Tom: this probably supersedes the old microsites PR.

Confirmed that tests pass locally. Tired of waiting for Travis.


fix(infra): Use highcpu instances for relays

Already deployed, this is part I did not commit by accident.


Fix: select-notifications disappears after clicking "Done"

Fixes #4752
Test URLs
https://github.com/notifications?query=repo%3Asindresorhus%2Frefined-github
Screenshot
https://user-images.githubusercontent.com/46634000/133923470-46a61400-7abe-4a28-bd68-915dbb8c063d.mp4
GitHub fires some events when "Done" is clicked (notably two socket:message events from .js-updatable elements) but they're not correlated to the removal of the dropdown: sometimes it happens before, sometimes after.
So in the end I went with a simple selector-observer.

selector-observer should be the only thing called in init: Use to add the first dropdown and it will automatically add it when the element you're tracking is removed. That's how we use it everywhere

It seems to work!


PKGBUILD from AUR fails to compile typescript to javascript

This issue was already fixed in master as I can build successfully from it, but the PKGBUILD gets the broken version.

PKGBUILD from AUR fails to compile typescript to javascript

This is what I expected to happen when I do that major changes within the sources. I'll probably work within the PKGBUILD to make it more dynamic about the changes like that and automatically adapt to them.

but the PKGBUILD gets the broken version

With the logic how WebCord versioning works within PKGBUILD, everything is alright on that side (there's no tag like v2.0.0-beta2, mostly because I need to adapt the Actions for that)...

I believe I fixed all of the issues with the PKGBUILD. I've also improved its logic, so it will recognize the @types NPM packages automatically (to install all types needed at the compile time) as well as support the packages like electron5, as long as they provides=('electron=5'). That means, PKGBUILD will less likely to break when there're some major changes done to WebCord like when there's a new dependency added to the package.json.
Also, I'm glad to have people interested in development packages, I hope you will find it as stable experience as I do, even when some parts of the program still seems to be in Work in progress state.

I still have this problem:
(3/6) Compiling TypeScript to Javascript...
sources/code/renderer/preload/docs.ts:14:8 - error TS2339: Property 'setOptions' does not exist on type 'typeof import("/var/tmp/pamac-build-itai/webcord-git/src/webcord/node_modules/@types/marked/index")'.

14 marked.setOptions({
          ~~~~~~~~~~

sources/code/renderer/preload/docs.ts:15:17 - error TS7006: Parameter 'code' implicitly has an 'any' type.

15     highlight: (code, lang) => {
                   ~~~~

sources/code/renderer/preload/docs.ts:15:23 - error TS7006: Parameter 'lang' implicitly has an 'any' type.

15     highlight: (code, lang) => {
                         ~~~~

sources/code/renderer/preload/docs.ts:41:12 - error TS2339: Property 'setOptions' does not exist on type 'typeof import("/var/tmp/pamac-build-itai/webcord-git/src/webcord/node_modules/@types/marked/index")'.

41     marked.setOptions({baseUrl: mdFile});
              ~~~~~~~~~~

sources/code/renderer/preload/docs.ts:42:40 - error TS2551: Property 'parse' does not exist on type 'typeof import("/var/tmp/pamac-build-itai/webcord-git/src/webcord/node_modules/@types/marked/index")'. Did you mean 'Parser'?

42     mdBody.innerHTML = sanitize(marked.parse(readFileSync(mdFile).toString()));
                                          ~~~~~

  node_modules/@types/marked/index.d.ts:46:14
    46 export class Parser extends marked.Parser {}
                    ~~~~~~
    'Parser' is declared here.

sources/code/renderer/preload/docs.ts:118:12 - error TS2339: Property 'setOptions' does not exist on type 'typeof import("/var/tmp/pamac-build-itai/webcord-git/src/webcord/node_modules/@types/marked/index")'.

118     marked.setOptions({
               ~~~~~~~~~~

Found 6 errors.

Failed to compile TypeScript sources to JavaScript
Error: Failed to build webcord-git

@Itai-Nelken it seems that PKBUILD does not respect the proper dependency versions. I'll probably just came with different dependency strategy:

instead of making a package list from PKGBUILD, it will just remove the blacklisted devDependencies in package.json.
instead of trying to guess the electron version installed within the OS (which doesn't work well anyway) it will try to guess the electron version from PKBUILD. This could be made for the other dependencies as well, e.g. typescript.

I believe that will make the WebCord installation via AUR much more stable, as it should this way use similar dependency versions as those currently supported by WebCord. For now, I'll probably just update the marked to the newer version and adapt it to work well with my code.

@Itai-Nelken It should build at this moment, but the PKGBUILD still needs to be improved... I'll close it once I'll do that.

Works now, thanks!

@Itai-Nelken it seems that PKBUILD does not respect the proper dependency versions. I'll probably just came with different dependency strategy:
* instead of making a package list from `PKGBUILD`, it will just remove the blacklisted `devDependencies` in `package.json`.

* instead of trying to guess the `electron` version installed within the OS (which doesn't work well anyway) it will try to guess the electron version from `PKBUILD`. This could be made for the other dependencies as well, e.g. `typescript`.

I believe that will make the WebCord installation via AUR much more stable, as it should this way use similar dependency versions as those currently supported by WebCord. For now, I'll probably just update the marked to the newer version and adapt it to work well with my code.

I've updated the PKGBUILD, it should now use the similar dependencies as in package.json. There should be no longer issues like that.

works now, but I can't update electron as webcord needs the older version.

works now, but I can't update electron as webcord needs the older version.

Yea, that's because it were broken with Electron 16 and even if I mitigated the issue, Electron 15 is still recommended for a whole functionality.
It should update once Electron 16 will be allowed in package.json.


Fix/example app debug

Issues Addressed
#279
Reinitialize Flutter Engine when initializing SDK with a different id

moving to a release merge


add precompile workload

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.34%. Comparing base (82129d9) to head (a1cd256).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   94.68%   94.34%   -0.34%
==========================================
  Files          34       32       -2
  Lines        2295     2123     -172
==========================================
- Hits         2173     2003     -170
+ Misses        122      120       -2

Flag
Coverage Δ

unittests
94.34% <ø> (-0.34%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Swirl 1.8RC:  Swagger API link is 404

From the Swirl homepage in v. 1.8RC, the "Swagger" link is 404.

Link URL:  http://localhost:8000/swagger-ui/
Re-checked in v. 1.7, working there.  The issue is new to 1.8RC

Fixed in 1.8

Verified fixed in 1.8, closing.


query-handbrake-log: Reading time & speed on logs created in Windows doesn't work in OS X

I switch between Windows and OS X frequently, which means I do transcodes in both operating systems, and I noticed this bug when trying to analyze log files using query-handbrake-log afterwards.
In OS X:
djss-Mac-Pro:friends djs$ query-handbrake-log s friends\ s06e22.mkv.log
25.886818 fps friends s06e22.mkv
djss-Mac-Pro:friends djs$ query-handbrake-log s friends\ s06e23.mkv.log
/usr/local/bin/query-handbrake-log: fps not found: /Volumes/Green/mac_encodes/a/friends/friends s06e23.mkv.log

If I'm Windows it can read logs created in both OS X and Windows.
Checking the bitrate (b) works. It's just speed (s) and time (t) that is affected, because it needs the fps which it can't find?
I'm attaching two logs, one for OS X and one for Windows.
Archive.zip

@lambdan Thanks for testing this case and opening this issue. I can easily reproduce the problem with the files you supplied, too.
Your diagnosis and the error message is correct. The query-handbrake-log tool is failing on OS X because it can't find fps in the .log file generated on Windows. And I suspect that's because the regular expression I'm using to find it is somehow getting confused by the CRLF-style line endings on Windows.
Unfortunately, these line-ending bugs are trickier to fix in a cross-platform way that you would think. Stay tuned...

@lambdan OK, I have a patch which fixes the bug:
diff --git a/bin/query-handbrake-log b/bin/query-handbrake-log
index e8b8ba0..20f3985 100755
--- a/bin/query-handbrake-log
+++ b/bin/query-handbrake-log
@@ -145,7 +145,7 @@ HERE
               if fps_line.nil?
                 fps_line = line
               elsif fps_line_2.nil?
-                if fps_line =~ / ([0.]+) fps$/
+                if fps_line =~ / ([0.]+) fps\r?$/
                   fps_line = line
                 else
                   fps_line_2 = line
@@ -173,7 +173,7 @@ HERE
           else
             Console.debug fps_line

-            if fps_line =~ / ([0-9.]+) fps$/
+            if fps_line =~ / ([0-9.]+) fps\r?$/
               fps = $1
             else
               fail "fps not found: #{log}"
@@ -182,7 +182,7 @@ HERE
             unless fps_line_2.nil?
               Console.debug fps_line_2

-              if fps_line_2 =~ / ([0-9.]+) fps$/
+              if fps_line_2 =~ / ([0-9.]+) fps\r?$/
                 fps_2 = $1
                 fps = (1 / ((1 / fps.to_f) + (1 / fps_2.to_f))).round(6).to_s
               else

This works on OS X but, unfortunately, I don't have access to my Windows machine at the moment. Can you try this on OS X yourself but, especially, can you try this on Windows to make sure it doesn't break anything there?
Thanks!

@donmelton Seems to be working:

I also tried it on OS X and it did work there aswell.

@lambdan Excellent! Thanks for testing that. Especially so quickly.
OK, I'll do my full regression test later this afternoon and queue this up for a 0.9.1 release. However, 0.9.1 probably won't happen until the end of the week since I just did the 0.9.0 release last night and I want to give other people time to test it in case I have any other regressions.

@lambdan I've decided to skip a 0.9.1 version because this will go in the same release as #68 which is a new feature. And that merits a bump to 0.10.0 instead. So this will probably go out sometime today.

@lambdan OK, version 0.10.0 was just released with this bug fix. Just gem update video_transcoding to get it. Thanks, again!

@lambdan D'oh! Thanks for closing that. I forgot. :)


Save temporary clustering of KK2 in the Kwik file

quoting @thesamovar
def f(kk):
  clusters = kk.clusters
  ... (do what you want with the clusters)

kk = KK(...)
kk.register_callback(f)

This f gets called at the end of each iteration.
If you want every N iterations, inside f put:
if kk.iteration%N==0

@thesamovar  it seems like the callback is called many times during a split iteration? does that make sense? it looks like it's stuck in an infinite loop and the split never ends...

Ah yes, my mistake I should have mentioned that. During splitting, a subset/copy KK object is created, and this inherits the callbacks. To ignore that, add the following at the beginning of the callback function:
if kk.name!='':
    return

It's not stuck in an infinite loop though, it's just very slow to do the splitting.


Threaded rayon

Intends to address the issue of effectively serialized decode (#245), where all
tasks end up being executed on the main thread instead of being
distributed into other workers.
We had neglected that most work is scheduled in sync (apppend_row such
as in decoder.rs:903 instead of apppend_rows). This meant most were
executed with an immediate strategy.
The change pushes all items into a bounded task queue that is emptied
and actively worked on when it reaches a capacity maximum, as well as
when any component result is requested. This is in contrast to
std::multithreading where items are worked on while decoding is in
progress but task queueing itself has more overhead.
cc: @Shnatsel

According to the profile, this did actually parallelize things, but now it requires Huffman decoding to complete before Rayon kicks in.
The performance results are a toss-up: on some images the default parallelization is 25% faster; on others this approach is 20% faster.
According to the profile, Huffman decoding completes before we start performing IDCT - in contrast to the rayonless version. Is there perhaps a way to combine the pipelining and Rayon's low-overhead scheduling? Say, spawn worker threads up front and have them pick tasks off the task queue immediately?

Say, spawn worker threads up front and have them pick tasks off the task queue immediately?

We can't, or at the very least I don't see how. rayon doesn't offer something a JoinHandle. We can either wait on the task immediately in the method that schedules it (rayon::scope etc.) or we schedule it at a later date.
We can try adjusting the constants here, or adding specifically some serialization points though.

Wait, I have actually measured it incorrectly. I need to turn off all the OTHER parallelization that Rayon does to make an apples-to-apples comparison. It might very well be that this approach with IDCT on Rayon is always slower than the DIY parallelization.

 I had assumed that scopes can only end in code by stepping out (side note: that was a longheld error in my thought pattern, in an totally unrelated topic as well) but with async fn that is no longer true. If we could convince rayon that async_scope is useful then we can indeed have join handles for (basically) free—hold on to the future that will finalize and terminate the scope when dropped.
Apart from being a very rough idea that I haven't present well.. that's …. interesting.

Ah, turning off parallel color conversion also gated on rayon feature makes this PR 25% slower even on its previously "good" cases, and 30% slower on the large CMYK test image.
I'm afraid this approach strictly inferior to manual parallelization.
If parallelization overhead is a problem for small images, could we perhaps simply skip it heuristically based on the expected image size?


updated_at timestamp not updated on delete if soft deletes enabled

Laravel Version: 5.4.24
PHP Version: 7.0.10
Database Driver & Version: php_sqlsrv_7_ts_x64 v4.0.8629.2

Description:
When deleting a model that has soft deletes enabled, the correct update time will be written to the database, but the model itself is not updated with the proper timestamp.
Steps To Reproduce:
I found the issue because of a very small test case that compares all attributes of a model:
// Make a test case out of it...
// Model class has created_at, updated_at and deleted_at timestamps
$model = new Model(['foo' => 'bar']);
$model->save();
sleep(2);
$model->delete();
$this->assertDatabaseHas('models', $model->getAttributes());

Result will be something like the following:
Failed asserting that a row in the table [models] matches the attributes {
    "id": 1,
    "foo": "bar"
    "updated_at": "2017-06-08 16:31:08.000",
    "created_at": "2017-06-08 16:31:08.000",
    "deleted_at": "2017-06-08 16:31:10.000"
}.
Found: [
    {
        "id": "1",
        "foo": "bar",
        "created_at": "2017-06-08 16:31:08.000",
        "updated_at": "2017-06-08 16:31:10.000",
        "deleted_at": "2017-06-08 16:31:10.000"
    }
].

I've tested out the following code in the SoftDeletes trait which appears to pass on the test your wrote...
/**
 * Perform the actual delete query on this model instance.
 *
 * @return void
 */
protected function runSoftDelete()
{
    $query = $this->newQueryWithoutScopes()->where($this->getKeyName(), $this->getKey());

    $time = $this->freshTimestamp();

    $this->{$this->getDeletedAtColumn()} = $time;
    $this->{$this->getUpdatedAtColumn()} = $time;

    $query->update([$this->getDeletedAtColumn() => $this->fromDateTime($time)]);
}

Will try get a PR in soon.


2.6 UX: Implement new Landing Page

Add a new landing page - this should be the default initial view unless in a single cluster deployment (!isMultiCluster)
Example below:

Things to consider:

Showing banner for release notes on upgrade (this is shown as a modal in the Ember UI) and allowing the usr to dismiss the notice
Allowing the user to choose a different landing page in the future (should allow to choose the Landing Page, a specific Cluster or any multi-cluster product - e.g. Fleet, Cluster Mgmt (provisioning)
Providing links to docs that we will create and being able to view those - e.g. migration guide, keyboard shortcuts

@mantis-toboggan-md Happy to discuss this further

@mantis-toboggan-md Had a good look at this - some suggestions:

Can we rename the page to home rather than whats-new
Can we make the whats new info a page? I don't think we localise this currently, but should think about a folder structure with the locale in there to support static docs that are localised
Some boxes like the "What do you want yo see..." and "Migration Assistance" should be dismissable - having a close icon to remove them and not show them in the future
Clusters table: I think we should remove the table actions (single and multi) in this usage. Clicking on the cluster name should navigate to that cluster rather than showing the cluster yaml
For choosing where to go on login, the last login should be a restricted list of a specific cluster or a few global apps/products like Fleet and Cluster Mgmt (when its there).
The community links is required on the support page as well, so I suggest we turn that into a component that can be used in both places
I've created a layout for the support page and made various visual tweaks that should work well when combined with your work here

In issue description there is a comment: this should be the default initial view unless in a single cluster deployment (!isMultiCluster). Can you please explain more? - I can't see anything different when logging in with 0 / 1 / 2 clusters
I created following issues:

Can't filter by cluster name - https://github.com/rancher/dashboard/issues/2924
Learn more button points to placeholder page - https://github.com/rancher/dashboard/issues/2925

"Single cluster" is a different packaging mode for situations where things like creating clusters will not apply because you're inherently only managing one cluster, and therefore some Ui options will be hidden.  This is for some future/side projects and is not something you configure.
It is not based on how many clusters you can see happening to be 1 (or any other number).


Feat: Allow passing an eventId as context

We would like to pass an eventId as a parameter in the $record so that we can communicate the eventId to other handlers in the logger.

This branch should target the develop branch, not master

@cleptric was this closed by mistake? It sounded as a reasonable request 🤔

Wops! We need to protect develop then!

@vladanpaunovic Can you do so please?

Done. develop now has same branch protection rules as master

@jwissels do you mind rebasing this PR and removing the extra commits that are coming from master?

@ste93cry i'll get on it!

Closing since i cannot update source branch in the PR
see https://github.com/getsentry/sentry-php/pull/1403


CKS registry and state updates

Add registry credentials to cks creation, and caàtch failures on creation on for better state

@JSpon Thanks for your contribution. Can you please add tests for this?  It's also good to follow this once you've added your tests as this can help catch things before the github workflow runs it.


Add a Fusion.Import function to import an array of functions

Motivation
Often times when using Fusion, users will import a lot of basic functions from the fusion entry table, these include:

New
Children
Computed
Tween
Spring
Value
OnEvent
OnChange

Proposal
I propose we add a Fusion.Import() function, this function will accept an array of strings, all of which will get imported into the current script's global environment.
Here's an example:
-- Other variables...
Fusion.Import({"New", "Children", "Value", "OnChange"})

New "TextLabel" {
  -- Props
}

Here could be a possible implementation:
local function importAll(toImport: {string})
  local env = getfenv(2)
  for module in ipairs(toImport) do
    if typeof(module) ~= "string" then
      logErrorNonFatal("invalidImportString") -- We can only accept strings.
      return
    end
    if env[module] ~= nil then
      logWarn("overridenModuleImport")
      -- This won't error, however it will warn the user that the imported module
      -- already exists in the script, this could be because it's already imported or
      -- because it was overriden by a variable.
    end

    -- Import the module here, we'd need to avoid creating a loop by re-requiring the fusion module.
  end
end

One downside of this is that we manipulate the function environment, something which hasn't been used much in the codebase.

I've just been thinking of an Idea to avoid a cyclic require loop.
We could store all of the fusion functions into a dictionary which then points to the specific folder of where it's located.
Example:
local itemMap = {
  [{"New", "Children", "OnChange"}] = Package.Instances,
  [{"Tween", "Spring"}] = Package.Animation
}

One downside of this is that we manipulate the function environment, something which hasn't been used much in the codebase.

This is for good reason. Using the function environment is generally considered bad practice, interferes with static code analysis, and can cause Luau to deoptimise, which we would like to avoid.
Ultimately, within idiomatic Luau right now, all imports need to be explicit. It's annoying, but that's how it is, and really the only way we can change this is by going to the language team and asking them to address this. As is, I don't believe there to be a good idiomatic solution to this, other than 'import all the things manually'.


typo: Double word "the"

Hi, @nschonni the specs files are generated from our source code so we don't accept fixes to them as they would be overwritten.
However, I checked the typos you pointed out and found that some are still present even in the newer versions, I will be fixing the typos from our side so the generated specs do not have these typos. Thanks!


Safari photo upload crashes the tab in iOS 8.0.2

Too much memory being used? Something is crashing whenever we choose to take a photo from safari instead of uploading from the gallery. Gives the error "An error occurred and the web page was reloaded".
Mostly on iPhone 6.
cc @weerd @sbsmith86

FYI - I have been testing with 8.1.2 and was able to post in Safari with camera twice without issues.

@aaronschachter you have iphone 5 right?

iPhone 5S

Clarification, this has happened mostly on iPhone 6. I think Diego also had it happen once to him, but nowhere near as frequently.

@mikefantini any other reports of this? Not able to recreate it.

closing for now.
@lkpttn if you see this again and are able to consistently reproduce it, please open.
I haven't heard of Zendesk complaints that point to this being an issue for users


Fix vis_param palette validation

Addresses #1611

Uses self.vis_params which are validated (possibly modified), instead of user-passed argument.
Ensures the tuple from default box.Box palette is a list type.
Makes a copy of the original user-passed vis_params dict so that it does not get modified.

@jdbcode Thanks for looking into this. It appears that the vis_params are modified after calling the _validate_vis_params() function. This is probably the unintended consequence after @naschmitz introduced the function in #1567.
from geemap.ee_tile_layers import _validate_vis_params
import geemap.colormaps as cm
igbp_palette = cm.palettes.Spectral
vizParams = {'min': 0, 'max': 17, 'palette': igbp_palette}
_validate_vis_params(vizParams)
vizParams


Errors in the code? Why optimize on test data (if I don't misunderstand)

Hi! Recently I'm using your code and I find something strange in your implementation of targeted attack. So here is the code you use to generate adversarial examples on test data, though I'm not familiar with TensorFlow, I think if you run "sess.run()" including g_optim and d_optim, then you'll update the parameters of D and G right? But the feed_dict here is test_data and test_label as shown here, which means you're optimize your GAN on the test data.
I'm just confused about why you need to do so. If understand correctly, LG-GAN generates adversarial examples at one shot, so you don't need to update the parameters in G or D during the generation. Again I'm not quite sure about TensorFlow so please correct me if I'm wrong. Or, is it really a bug? Or out of some special purpose?

So, from my perspective, if you want to perform attack on test data, you only need to run
score, test_adv_data = sess.run([pred, generator_pc], feed_dict=feed_dict)

once without including any optim in "sess.run()".
I'm not sure whether my understanding is correct. But I tried my modified version of the attack and I discover similar (even slightly better) results than reported in the paper. So I think this (possible) bug doesn't change the contribution of this paper.
But to be honest, I still want to know whether it is truly a bug. Please close this issue whether you want to modify the code or not because it doesn't affect the experimental results. But I hope you can tell me your answer :)

Sure, I will check the code soon, and thank you so much for your effort!
Best,
Hang
Hang Zhou
Ph.D
http://home.ustc.edu.cn/~zh2991/
From: Ziyi Wu
Date: 2020-09-04 23:34
To: RyanHangZhou/LG-GAN
CC: Subscribed
Subject: Re: [RyanHangZhou/LG-GAN] Errors in the code? Why optimize on test data (if I don't misunderstand) (#2)
So, from my perspective, if you want to perform attack on test data, you only need to run
score, test_adv_data = sess.run([pred, generator_pc], feed_dict=feed_dict)
once without including any optim in "sess.run()".
I'm not sure whether my understanding is correct. But I tried my modified version of the attack and I discover similar (even slightly better) results than reported in the paper. So I think this (possible) bug doesn't change the contribution of this paper.
But to be honest, I still want to know whether it is truly a bug. Please close this issue whether you want to modify the code or not because it doesn't affect the experimental results. But I hope you can tell me your answer :)
―
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Floor temperature - new feature request

Most of Salus thermostats have S1, S2 terminals witch allow to connect floor temperature sensor. When connected, floor temperature  is reported in app. Any chance to add this to default to HA?

Hello, i also have S1 terminal with floor temperature sensor but my VS20WRF show it in app only if i set in settings "use as main termperature sensor".
When i set "use as additional sensor to limit floor temperature" i can only set limit to 27 for my laminate but app show then air temperature only.
I suspect that VS20WRF has both temperature to do this logic but can we get it?
Also right now output from library doesn't show it is control over floor (S1) or over air, it will be useful to get this info.


Document clearModuleCache when running in development vs. production mode

💬 Questions and Help
I am working on integrating Loadable into an existing codebase, and we were running load/performance tests locally and found that the Loadable build was much slower; this was until we realized the significant difference when running in development vs. production modes (duh).
It is all due to this line of code in util.js:
export const smartRequire = modulePath => {
  if (process.env.NODE_ENV !== 'production') {
    clearModuleCache(modulePath)
  }
// ...

Of course, we shouldn't have been running performance tests in development mode, however I would expect to see this documented somewhere and I wasn't able to find anything mentioning it specifically.
Thoughts?

During development, with hot module replacement in place, this file might change. And it is causing a real performance degradation?

Hello @parties, I think I am gonna remove this method, it is confusing for user. The best is to use a webpack plugin for that: https://github.com/smooth-code/smooth.js/blob/master/packages/smooth/src/webpack/plugins/smooth-cache-hot-reloader.js.
I think the strategy is better and less invasive for the user. What do you think?


Failed to load https://file.hankcs.com/hanlp/ner/ner_bert_base_msra_20200104_185735.zip.

Traceback (most recent call last):
File "E:\Anaconda\lib\site-packages\hanlp\utils\component_util.py", line 48, in load_from_meta_file
obj.load(save_dir, **load_kwargs)
File "E:\Anaconda\lib\site-packages\hanlp\common\component.py", line 244, in load
self.build(**merge_dict(self.config, training=False, logger=logger, **kwargs, overwrite=True, inplace=True))
File "E:\Anaconda\lib\site-packages\hanlp\common\component.py", line 255, in build
loss=kwargs.get('loss', None)))
File "E:\Anaconda\lib\site-packages\hanlp\components\taggers\transformers\transformer_tagger.py", line 36, in build_model
model, tokenizer = build_transformer(transformer, max_seq_length, len(self.transform.tag_vocab), tagging=True)
File "E:\Anaconda\lib\site-packages\hanlp\layers\transformers\loader.py", line 101, in build_transformer
assert len(vocab) == 1, 'No vocab found or unambiguous vocabs found'
AssertionError: No vocab found or unambiguous vocabs found
https://file.hankcs.com/hanlp/ner/ner_bert_base_msra_20200104_185735.zip was created with hanlp-2.0.0-alpha.5, while you are running 2.0.0-alpha.36. Try to upgrade hanlp with
pip install --upgrade hanlp
If the problem persists, please submit an issue to https://github.com/hankcs/HanLP/issues .

[auto-reply] Thanks for your comment. However, the essential information is required. Please carefully fill out the form then reopen it.


Add sdk base image

The docker image builds, but we need to exercise the tag/push logic before merge
/hold
This PR results in the creation of 4 new images published to quay:

quay.io/repository/operator-framework/operator-sdk-amd64
quay.io/repository/operator-framework/operator-sdk-s390x
quay.io/repository/operator-framework/operator-sdk-ppc64le
quay.io/repository/operator-framework/operator-sdk-arm64

If anyone else needs to test the image builds, this is how I did it:

Enable travis on my fork of this repository

Add environment variables for the build so they push to my quay repository

Create the repositories in quay, and set them to public.

include [travis deploy] in the commit message.
NOTE: If the test jobs fail, they will cancel the deploy stage, but test jobs can be cancelled.

/retest

@joelanford I made some substantive changes since you approved.

Rebased latest master, CI was still failing due to dependency problem (ansible 2.10, now pinned to 2.9) that has already been fixed.


Add vertical line tracking while mouseOver the chart (like in flot.js)

Hello all,
I am searching for a solution to add this feature to chart.js sincer 5 days ago:
http://www.flotcharts.org/flot/examples/tracking/index.html
Look at the vertical line following the mouse. I do not need the points values and nothing. Just the vertical line.
Is there any way to implement this in chart.js? Does anyone have it?
Thank you a lot!

I'm sure you could accomplish this on the client side by first getting the coordinates of the mouse and then drawing a line through the annotations plugin.

I donnot want annotations plugin, coz when you use it with more than 2 graphs, it slows down the system like crazy. I have also wrote an issue there.
https://github.com/chartjs/chartjs-plugin-annotation/issues/41

@Alexisander the reason the annotation plugin is slow is that it uses the same canvas so when the mouse moves, the entire chart must be re-rendered. I think you can create your own plugin that uses 2 canvases layer on top of each other and then draw your line of the upper canvas so that clearing it does not require re-rendering the chart

Closing since the solution is to write a custom solution as a plugin.
The request for the zoom feature should be opened on https://github.com/chartjs/chartjs-plugin-zoom


Some fine tuning for thomaswue

Check List:

[x] Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
[x] All formatting changes by the build are committed
[x] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
[x] Output matches that of calculate_average_baseline.sh
[x] For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)

Execution time: 0.45s
Execution time of reference implementation: 120.37s

This is some final (?) fine tuning. Should give a few more %. Next step would be to convert the hash table array into an "inlined data structure" with all unsafe access, but not sure if I want to go there ;-).
Update: Got this down to 0.41s  now on my machine with processing segments at 2MB each and also processing with 3 scanners in parallel in the same thread.

It doesn't seem to make a difference on the eval machine:
Using java version 21.0.2-graal in this shell.
Validating calculate_average_thomaswue.sh -- measurements_1B.txt
Picking up existing native image 'target/CalculateAverage_thomaswue_image', delete the file to select JVM mode.

+ rm -f measurements.txt
+ ln -s measurements_1B.txt measurements.txt
Benchmark 1: timeout -v 300 ./calculate_average_thomaswue.sh 2>&1
  Time (mean ± σ):      2.189 s ±  0.043 s    [User: 0.002 s, System: 0.004 s]
  Range (min … max):    2.075 s …  2.225 s    10 runs

Summary
  thomaswue: trimmed mean 2.19823098707, raw times 2.07534146632,2.19937587432,2.16664367332,2.2091708203200002,2.22455168132,2.22013504532,2.19476398532,2.20274883332,2.20429925032,2.18871041432

Leaderboard

| # | Result (m:s.ms) | Implementation     | JDK | Submitter     | Notes     |
|---|-----------------|--------------------|-----|---------------|-----------|
|   | 00:02.198 | [link](https://github.com/gunnarmorling/1brc/blob/main/src/main/java/dev/morling/onebrc/CalculateAverage_thomaswue.java)| 21.0.2-graal | [Thomas Wuerthinger](https://github.com/thomaswue) | GraalVM native binary, uses Unsafe |

Btw. this might be interesting to you: I am seeing this exception on two other entries:
Fatal error: Failed to leave the current IsolateThread context and to detach the current thread. (code 12)

For instance here. Any idea what might be the cause and how to avoid it?

Btw. this might be interesting to you: I am seeing this exception on two other entries:
Fatal error: Failed to leave the current IsolateThread context and to detach the current thread. (code 12)

For instance here. Any idea what might be the cause and how to avoid it?

It seems it comes from here:
https://github.com/oracle/graal/blob/9d05067f874b7c00f75b7f62cfea4a64eca93e33/substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/c/function/CEntryPointSetup.java#L82
    public static final class LeaveEpilogue implements CEntryPointOptions.Epilogue {
        private static final CGlobalData<CCharPointer> errorMessage = CGlobalDataFactory.createCString(
                        "Failed to leave the current IsolateThread context.");

        @Uninterruptible(reason = "epilogue")
        static void leave() {
            int code = CEntryPointActions.leave();
            if (code != CEntryPointErrors.NO_ERROR) {
                CEntryPointActions.failFatally(code, errorMessage.get());
            }
        }
    }

I'll try to find the cause.
Related problem:
https://github.com/quarkusio/quarkus/issues/6606#issuecomment-586340877

. (code 12)

Maybe @peter-hofer can help =)

Yes, this looks like a potential native image bug. I will check with the team.

and to detach the current thread.

It's actually here (GitHub text search is not that good ...):
https://github.com/oracle/graal/blob/9d05067f874b7c00f75b7f62cfea4a64eca93e33/substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/c/function/CEntryPointSetup.java#L95
    public static final class LeaveDetachThreadEpilogue implements CEntryPointOptions.Epilogue {
        private static final CGlobalData<CCharPointer> errorMessage = CGlobalDataFactory.createCString(
                        "Failed to leave the current IsolateThread context and to detach the current thread.");

        @Uninterruptible(reason = "epilogue")
        public static void leave() {
            int code = CEntryPointActions.leaveDetachThread();
            if (code != 0) {
                CEntryPointActions.failFatally(code, errorMessage.get());
            }
        }
    }

Yes, this looks like a potential native image bug. I will check with the team.

There's an open issue from Mar 24, 2021 for that same error msg and code:
https://github.com/oracle/graal/issues/3305

Btw. this might be interesting to you: I am seeing this exception on two other entries:
Fatal error: Failed to leave the current IsolateThread context and to detach the current thread. (code 12)

For instance here. Any idea what might be the cause and how to avoid it?

There are at least three entries where this error happened:
https://github.com/gunnarmorling/1brc/pull/479
https://github.com/gunnarmorling/1brc/pull/510
https://github.com/gunnarmorling/1brc/pull/575

@gunnarmorling Could you please evaluate this new version? It consistently beats the top entry now on my machine, so with a bit of luck, it could get below 2s ;-).

It is below 2 sec indeed, and quite a bit in fact! Could you describe perhaps on a high level what is making this huge difference at this point?
Benchmark 1: timeout -v 300 ./calculate_average_thomaswue.sh 2>&1
  Time (mean ± σ):      1.890 s ±  0.011 s    [User: 0.002 s, System: 0.004 s]
  Range (min … max):    1.859 s …  1.898 s    10 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

Summary
  thomaswue: trimmed mean 1.89342727442, raw times 1.85925432142,1.8941132214199998,1.8928165554199998,1.89327190942,1.89163260842,1.89773446642,1.89233219542,1.89314723642,1.89674720142,1.89335726742

Leaderboard

| # | Result (m:s.ms) | Implementation     | JDK | Submitter     | Notes     |
|---|-----------------|--------------------|-----|---------------|-----------|
|   | 00:01.893 | [link](https://github.com/gunnarmorling/1brc/blob/main/src/main/java/dev/morling/onebrc/CalculateAverage_thomaswue.java)| 21.0.2-graal | [Thomas Wuerthinger](https://github.com/thomaswue) | GraalVM native binary, uses Unsafe |

Excellent! Below 2s. Mission accomplished ;-).
So the main changes are to adopt processing segments in 2MB blocks to make sure all threads finish at the same time (otherwise other threads might sit idle while one thread finishes its part). This is inspired by @artsiomkorzun's solution. Looking at the perf flamegraph of his solution showed the benefit in wall clock time.
The other major change is to process 3 scanners in parallel in the same thread. This increases instructions per cycle, because there is more straight-line code that the Intel processor can then optimize better. The machine code generation is also more efficient, because there are quite some 64-bit long constants involved (in finding delimiters) and those are better shared if the same operation is done 3 at a time.

Awesome, really cool!

Excellent! Below 2s. Mission accomplished ;-).
So one main change is to adopt processing segments in 2MB blocks to make sure all threads finish at the same time (otherwise other threads might sit idle while one thread finishes its part). This is inspired by @artsiomkorzun's solution. Looking at the perf flamegraph of his solution showed the benefit in wall clock time.
The other major change is to process 3 scanners in parallel in the same thread. This increases instructions per cycle, because there is more straight-line code that the Intel processor can then optimize better. The machine code generation is also more efficient, because there are quite some 64-bit long constants involved (in finding delimiters) and those are better shared if the same operation is done 3 at a time.

Beautiful solution Thomas! :star_struck: :star_struck:
I think the main speed up came from smaller segments, and doing that inside the hot loop !, because you get the huge benefit of still using the same Result[] results = new Result[1 << 17];
I'm not sure how much performance was gained from unrolling (spliting) the scanners.
But you for sure knows!!! =)

It is a bit difficult to isolate (and might be different on the benchmark machine), but from the total 15% improvement over the previous entry, it seems almost an equal contribution from both of those changes. Doing 3 in parallel definitely helps more than 5% on my machine.


This lib has existed for 2 years, when will it be out of Beta?

We're actively working on a refreshed Android SDK
When V3 of that SDK is released we plan to base the Java SDK off the same kotlin source. We'll take it out of beta at that point.


Implement expression templates for units magnitudes

Right now, magnitudes expand in the user-facing types, which makes them verbose and hard to understand. We could incorporate the same generic approach that we use for other entities as well. Those could either be resolved to prime numbers lazily or be expanded to prime numbers in an invisible base class that will be used for all the arithmetics?
With this, we could get decent types and all the features of the current design. For example instead of quantity<reference<fuel_consumption{}, scaled_unit<magnitude<power_v<2, -2>{}, power_v<5, -2>{}>{}, derived_unit<non_si::litre, per<si::kilo_<si::metre{}>>>>{}>{}, double>> we could get quantity<reference<fuel_consumption{}, scaled_unit<magnitude<1, per<100>>{}, derived_unit<non_si::litre, per<si::kilo_<si::metre{}>>>>{}>{}, double>>.
Also, common units could work fine as we could try to find the GCD for an equation (like std::ratio does).

Weighing in for posterity as the original implementer of vector space magnitudes:
I like the idea of using some kind of expression template for the user-facing types that show up in compiler errors.  Overall, it seems like a similar strategy to the opaque types we use for units, and which work really well.  I think this is worth pursuing.
One possible alternative to expression templates would be for the type to be templated on a string, which is the label for the magnitude.  (We don't have magnitude labels yet, but we'll get them someday.)  IIRC, we tried this a little bit earlier, but found that the representation in the compiler error was really bad: not only was it character-for-character, but I think the characters were also represented by their numeric ASCII codes (!).  If we could get a commitment from all of the compilers to print the type as a string (e.g., magnitude<"5280">) in compiler errors, then this might be better than expression templates, because we wouldn't be limited in terms of what integers we could display.  I think expression templates seem like a safer bet overall, though.

We decided to not go this way. Providing good and readable expression templates for magnitudes is far from being easy and complicates the design too much with not much benefit. To limit the scope of the issue we decided to add support for a common_unit. With this, the raw magnitude type will leak to the user only from the units like l/100km.