sync_to_async: shield async code from StopIteration

StopIteration seems to be used in the guts of async generators, from PEP-525:
The protocol requires two special methods to be implemented:

An __aiter__ method returning an asynchronous iterator.
An __anext__ method returning an awaitable object, which uses StopIteration exception to "yield" values, and StopAsyncIteration exception to signal the end of the iteration.

This apparently means raising StopIteration anywhere in async code just generates an error, which also can't really be caught by user code... sigh
This is a partial fix for #1200 for defense in depth, the K2IS-specific parts will follow in a separate PR.
Contributor Checklist:

[ ] I have added or updated my entry in the creators.json file
[ ] I have added a changelog entry for my contribution
[ ] I have added/updated documentation for all user-facing changes
[x] I have added/updated test cases
[ ] I have included the rebuilt production build of the client (only if changes were made to the GUI)

Reviewer Checklist:

[ ] /azp run libertem.libertem-data passed

@sk1p is this ready for merging? Are any of the unchecked items applicable/TODO? :-)

@sk1p is this ready for merging? Are any of the unchecked items applicable/TODO? :-)

Should be ready for merging.


Fix the benchmark

:tada: This issue has been resolved in version 1.10.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add Secret generator to template files to generate JWT Secret in WA_W…

…EB_JWT_CRYPTO_KEY

This diff defines the WA_WEB_JWT_CRYPTO_KEY in a secure way in each deployment by using AWS SecretManager to generate a secret string of 64 characters and setting it to the env variable
The variable is then used in all running webapp instances.

Better version merged in #14


Better handling of network issues

Currently there is no attempt to handle network issues. Things that could be done:

Not failing silently (happens sometimes)
Better error messages instead of dumping a stacktrace
Retrying

Closing due to inactivity.


Update Learn More Link

Link in README.rst doesn't work, wrong link.
Correct one: https://kennethreitz.org/essays/2013/01/27/repository-structure-and-python


Localize errors by storing them in a resx file

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.

Steps to reproduce
Code clean up issue: Store errors used in Find, Install in resx file for localization, per this comment: https://github.com/PowerShell/PowerShellGet/pull/1065#discussion_r1175663651
Expected behavior
Errors are stored in resx file

Actual behavior
Currently errors are in each .cs file.

Error details
No response
Environment data
platform agnostic

Visuals
No response

This would be a requirement to ship in Windows


Make HackAUBG letters animation slower

Can you as well change the font and/or the boldness of the text below

Also it seems that the font is a bit small when viewed from a phone.


added browser_initialized? method to the driver

We came across the following issue while running cucumber tests:
  undefined method `browser_initialized?' for #<Capybara::Webkit::Driver:0x007f698bb9e3c0> (NoMethodError)
  /home/runner/test/vendor/bundle/ruby/2.2.0/gems/capybara-2.6.0/lib/capybara/session.rb:109:in `reset!'
  /home/runner/test/vendor/bundle/ruby/2.2.0/gems/capybara-2.6.0/lib/capybara.rb:285:in `block in reset_sessions!'
  /home/runner/test/vendor/bundle/ruby/2.2.0/gems/capybara-2.6.0/lib/capybara.rb:285:in `each'
  /home/runner/test/vendor/bundle/ruby/2.2.0/gems/capybara-2.6.0/lib/capybara.rb:285:in `reset_sessions!'
  /home/runner/test/vendor/bundle/ruby/2.2.0/gems/capybara-2.6.0/lib/capybara/cucumber.rb:8:in `After'

Capybara drivers implemented browser_initialized? method with this commit: https://github.com/jnicklas/capybara/commit/5665396fc99fe73340e88998ffa7a4d2eda6ffa2
So I added the same method here.

Hey @dmilisic. Our driver inherits the base Capybara driver, which implements this method. An explicit implementation should not be required. Also, we test against multiple versions of Capybara and have not seen this behavior. Are you sure you're running the latest version of capybara-webkit?

Sorry @mhoran... We were using version 1.1.0 of capybara-webkit since newer versions aren't comptible with the newest capybara (2.6.0)
We downgraded capybara to 2.5.0 and upgraded capybara-webkit to 1.7.1 and it works without the fix.
Sorry once again for the reported issue...

I just released capybara-webkit 1.8 which is compatible with the latest Capybara.


Cannot use the alpaca.7B model

Bug description
I downloaded the ggml-alpaca-7b-q4.bin from the internet and docker cp it in to the /usr/src/app/weights folder. It is there now, however it stays unnoticed by Serge. Even after restarting and fumbling around, I cannot select the model when starting a chat.
Steps to reproduce
Download ggml-alpaca-7b-q4.bin
docker cp ./ggml-alpaca-7b-q4.bin :/usr/src/app/weights
restarting the docker container
Environment Information
Debian 10.03 runnig in VirtualBox
Docker version 23.0.2, build 569dd73
Screenshots
No response
Relevant log output
No response
Confirmations

[X] I'm running the latest version of the main branch.
[X] I checked existing issues to see if this has already been described.

Have you tried downloading 7B from the download manager included in Serge ?
Otherwise, you could try to rename your file from ggml-alpaca-7b-q4.bin to 7B.bin to see if Serge can detect it.

@VanHallein Did you figured out the issue?


Puma with workers: Prometheus Exporter Failed To Collect Puma Stats undefined method `stats' for Puma:Module

Hello,
I'm trying to get puma metrics on muti worker configuration
prometheus_exporter (0.6.0)
puma (3.11.0)
rails (= 5.0.4)
ruby:2.4.5
I run bundle exec prometheus_exporter -b <IP_ADDRESS> -p 9394 alongside puma on a docker container.
The rails integration seems to work, I can get ruby_http_sql_duration_seconds, ruby_http_duration_seconds...
But If I add
after_worker_boot do
  require 'prometheus_exporter/instrumentation'
  PrometheusExporter::Instrumentation::Puma.start
end

to by config/pumar.rb I get
Prometheus Exporter Failed To Collect Puma Stats undefined method `stats' for Puma:Module

Let me know if you need more informations
Kind regards

I ran into a similar issue running Puma in single mode, and found this comment by schneems: https://github.com/puma/puma/issues/1512#issuecomment-493089586
It's because stats is being called in a "non web-server context".
What I did notice is that I only get the error once and then I do get the expected data in Prometheus, so if I had to guess, it fails during initialization but every subsequent call is successful.

I ran into a similar issue running Puma in single mode, and found this comment by schneems: https://github.com/puma/puma/issues/1512#issuecomment-493089586
It's because stats is being called in a "non web-server context".
What I did notice is that I only get the error once and then I do get the expected data in Prometheus, so if I had to guess, it fails during initialization but every subsequent call is successful.

So is there any solution for this?

Got the same but for ActiveRecord:
Prometheus Exporter Failed To Collect Process Stats undefined method `spec' for #<ActiveRecord::ConnectionAdapters::ConnectionPool:0x000055b5bf49d1b0>

ran into the same problem, any updates?

Same problem on multiple applications

Same problem, any solution?

Same here. Just once it shows the error on boot, then no more.
Would be great to fix it or find a workaround.

Same problem, with ruby 2.3.1 & RoR 4.2.5
I get all the time
2023-08-14_12:46:42.21384 Prometheus Exporter Failed To Collect Puma Stats undefined methodstats' for Puma:Module
2023-08-14_12:46:42.24894 Prometheus Exporter Failed To Collect Puma Stats undefined method stats' for Puma:Module 2023-08-14_12:46:42.25549 Prometheus Exporter Failed To Collect Puma Stats undefined method stats' for Puma:Module
2023-08-14_12:46:42.33401 Prometheus Exporter Failed To Collect Puma Stats undefined method stats' for Puma:Module 2023-08-14_12:46:42.33685 Prometheus Exporter Failed To Collect Puma Stats undefined method stats' for Puma:Module
2023-08-14_12:47:12.21616 Prometheus Exporter Failed To Collect Puma Stats undefined method stats' for Puma:Module 2023-08-14_12:47:12.25134 Prometheus Exporter Failed To Collect Puma Stats undefined method stats' for Puma:Module
2023-08-14_12:47:12.25753 Prometheus Exporter Failed To Collect Puma Stats undefined method stats' for Puma:Module 2023-08-14_12:47:12.33637 Prometheus Exporter Failed To Collect Puma Stats undefined method stats' for Puma:Module
`


UI Grid refresh/reload issue

I am using UI Grid for a data grid display. All columnDefs and data are real-time and can change depending on user selection, but i cannot make the reset of UIGrid work. I tried to use $compile to recompile and append element on very refresh.
var newRsGrid = $compile('')($scope)
rsGrid.empty();
rsGrid.append(newRsGrid);
It seems to work but is throwing lots of exceptions like: Error: [$compile:ctreq] Controller 'uiGrid', required by directive 'uiGridRow', can't be found!
I found a related issue at https://github.com/angular-ui/ng-grid/issues/3096, but don't know if he got the same error as i do. Can someone help with a solution? Will UI-Grid reset/reload be supported in 3.0?

3.0 will be the functionality we currently have, but with the remaining 3.0 milestone bugs fixed.  So no, this won't be in 3.0.
The usual way to reset the grid at the moment is to wrap your enclosing directive in an ng-if, so you can toggle the ng-if off, wait for one digest cycle, then toggle it on again.

Thanks, Paul! Can you point to a URL where i can find some sample code with this "ng-if" technique?

No, not off the top of my head, although I've seen it somewhere in a plunker before.  But it's pretty simple.

But "" has to be wrapped in a directive, right? And then use the wrapper directive inside ng-if?

Sorry i couldn't paste any code in here. It's swallowed.

You should be able to paste, I've edited.
The normal way is:

And then in your controller, when something happens that would trigger a refresh:
  var refresh = function() {
    $scope.refresh = true;
    $timeout(function() {
      $scope.refresh = false;
    }, 0);
  };

Yes, it's working! I simply set $scope.refresh to be true and then false, and reset gridOptions with new data and it works. The only minor thing noticed is that the timeout in "ui-grid-auto-resize" keeps changing the grid size. After i removed ui-grid-auto-resize attribute, it's working just fine. Thnaks!

Glad you got it working.

 Many thanks.

Well thank you.  Nothing like getting nice thoughts for something I did months ago.  :-)

I have resolved my problem ! Thanks a lot! That's working!@PaulL1

Thank you c0bra and PaulL1, ng-if solves that issue. Had this for months, thank you very much!

Hello.
I have the same problem.
I created a new function in my controller to refresh data after a search.
$scope.atualizarComposicaoQuimica = function (resultado) {        $scope.grdComposicaoQuimica.data = $.parseJSON(resultado) }
In my div, I added ng-if:

And in my controller I added tge code:
var refresh = function () {                 $scope.refresh = true;                 $timeout(function () {                     $scope.refresh = false;                 }, 0);             };
But i continue get the error "Controller 'uiGrid', required by directive 'uiGridRow', can't be found!"
Help-me please!

running  gridApi.core.refresh() does not result in and changes;
gridApi.core.refresh().then((d)=>{
      console.log( d );
})
//outputs undefined

This error occurs after I update my div with a PartialViewResul from controller:
$("#divDadosAcoInterno").html(partialView);
After this action, I execute the code follow to update my data:
angular.element(document.getElementById('grd-ComposicaoQuimica')).scope().atualizarComposicaoQuimica(result)

Hola, soy de colombia.
hablo muy poco, espero me puedan ayudar.
Intento que se modifican automaticamente lo datos en las filas de mi tabla,
estos datos van cambiando en tiempo real, pero no he logrado que se cambien en la interfaz de red, con ningun metodo.
intento utilizar refresh Rows() pero tampoco lo logro.
Adjunto el codigo:
var app = angular.module('app', ['ngAnimate', 'ngTouch', 'ui.grid', 'ui.grid.selection', 'ui.grid.exporter']);
app.controller('MainCtrl', ['$scope', '$http', 'i18nService', function ($scope, $http, i18nService) {
$scope.deleteRow = function(row) {
var index = $scope.gridOptions.data.indexOf(row.entity);
$scope.gridOptions.data.splice(index, 1);
};
$scope.addData = function(row) {
$scope.gridOptions.data.push({

            field: 'Clave',
            field: 'Conductor',
            field: 'Placa',
            field: 'Ruta',
            field: 'HoraSalidaEstimada'
          });

};
$scope.gridOptions = {

enableSorting: true,
minimumColumnSize: 90,
columnDefs: [

  {field: 'Eliminar', width: '7%', cellTemplate: '<button class="btn primary" ng-click="grid.appScope.deleteRow(row)">Eliminar</button>'},
  {field: 'Clave', width: '6%'},
  {field: 'Conductor', width: '8%'},
  {field: 'Placa', width: '7%'},
  {field: 'Ruta', width: '6%'},
  {field: 'HoraSalidaEstimada', name:'H.S.E', width: '7%'}

],

exporterMenuCsv: false,
enableGridMenu: true,
enableSelectAll: true,
//exporterCsvFilename: 'myFile.csv',
exporterPdfDefaultStyle: {fontSize: 8},
exporterPdfTableStyle: {margin: [10, 10, 10, 10]},
exporterPdfTableHeaderStyle: {fontSize: 9, bold: true, italics: true, color: 'red'},
exporterPdfHeader: { text: "Ruta:", style: 'headerStyle' },
exporterPdfFooter: function ( currentPage, pageCount ) {
  return { text: currentPage.toString() + ' of ' + pageCount.toString(), style: 'footerStyle' };
},
exporterPdfCustomFormatter: function ( docDefinition ) {
  docDefinition.styles.headerStyle = { fontSize: 22, bold: true };
  docDefinition.styles.footerStyle = { fontSize: 10, bold: true };
  return docDefinition;
},
exporterPdfOrientation: 'landscape',
exporterPdfPageSize: 'LETTER',
exporterPdfMaxGridWidth: 450,
//exporterCsvLinkElement: angular.element(document.querySelectorAll(".custom-csv-link-location")),
onRegisterApi: function(gridApi){

  $scope.gridApi = gridApi;

}

};
i18nService.setCurrentLang('es');
$http.get('http://localhost:8080/docs/api/ULTIMAVERSION6/data/Tabla.json')
.success(function(data) {
$scope.gridOptions.data = data;
var refresh = function() {
$scope.refresh = true;
$timeout(function() {
  $scope.refresh = false;
}, 0);

};
});

}]);

Hi, I am from Colombia.
I speak very little, I hope I can help.
I try to automatically modify the data in the rows of my table,
These data are changing in real time, but I have not been able to change them in the network interface, with any method.
I try to use refresh Rows () but I do not get it either.
I am enclosing the code:
$http.get('http://localhost:8080/docs/api/ULTIMAVERSION6/data/Tabla.json')
.success(function(data) {
$scope.gridOptions.data = data;
var refresh = function() {
$scope.refresh = true;
$timeout(function() {
$scope.refresh = false;
}, 0);

@PaulL1 @PaulL1 can you help me!! thanks


Nest.Experimental package

if https://github.com/elastic/elasticsearch/pull/38413 lands it would be better if we put API's that are not stable in a separate package that can be versioned differently.
Currently we do lockstep releases with Elasticsearch Major.Minor this means we can not introduce breaking changes until a new Major of Elasticsearch is released.
Experimental and beta API's in Elasticsearch are subject to breaking changes in Minor releases. So that puts us in a bind. Historically we've found ways to accommodate this when it arose.
Experimental and beta API's in practice do not change that much though and so a separate package could proof overkill.

This approach was changed recently and the following section added to the README

Low Level Client Compatibility
The Elasticsearch.Net low level client will expose functionality in REST APIs that are marked as either experimental or beta. This functionality is marked as such using the  XML documentation comments, which contains the stability and a description of the compatibility guarantees. Examples below:
/// Note: Experimental within the Elasticsearch server, this functionality is experimental and may be changed or removed completely in a future release. Elastic will take a best effort approach to fix any issues, but experimental features are not subject to the support SLA of official GA features. This functionality is subject to potential breaking changes within a minor version, meaning that your referencing code may break when this library is upgraded.
/// Note: Beta within the Elasticsearch server, this functionality is in beta and is subject to change. The design and code is less mature than official GA features and is being provided as-is with no warranties. Beta features are not subject to the support SLA of official GA features. This functionality is subject to potential breaking changes within a minor version, meaning that your referencing code may break when this library is upgraded.
If you use this experimental or beta functionality, by taking a dependency on it within your code, you are exposing yourself to the potential for binary breaking changes within that major version.

Therefore the intention is to ship experimental and beta packages in the low level client, with the above caveat, and then look to introduce a Nest.Experimental package at a later date.

Unlikely to do this in the short term.


[server][test] Add integration test for thread pool jumping by enabling/disabling AA or WC.

Summary, imperative, start upper case, don't end with a period

PartialUpdateTest#testEnablePartialUpdateOnActiveActiveStore change
This PR adds an integration test support for verifying the pool jumping strategy: KafkaConsumerServiceDelegator.ConsumerPoolStrategyType.CURRENT_VERSION_PRIORITIZATION, when version role and workload type changed.
ConsumptionTask change
We also add consumer pool name into the ConsumptionTask's id string, we are able to know the consumer thread comes from a certain pool. This will ensure TopicPartitionIngestionContext contains the ConsumptionTask's id string for certain topic partition belonging to a specific version topic. To assert the pool changed or not, we rely on previous debugging method by querying TopicPartitionIngestionContext from server host.
How was this PR tested?

Does this PR introduce any user-facing changes?

[*] No. You can skip the rest of this section.
[] Yes. Make sure to explain your proposed changes and call out the behavior change.

Hello @haoxu07 ... it looks like the test added in this PR might be flaky? See this example, where the modified integration test failed 5 times in a row:
https://github.com/linkedin/venice/actions/runs/10620188779/job/29439452773?pr=1147
The failures come specifically from verifyConsumerThreadPoolFor, which was added in this PR, but IDK if it indicates an issue with the main code or with the test code.
Would you mind taking a look please?


code review - 20.09.16

ProtocolMessageSerializer :
why do you need to implement your own serializer? it it becase of size of a serialized message? protobuf or smth like that would handle this easily and be even more small(and fast while serializing\deserializing).
ResettableCountDownLatchTests: can you please describe what is happening here? i dont get what does 'v' stands for in this tests
'entities' package: every class here is more like 'repository' because 'entity' is a single object that is stored into a database.
TStreamsFactoryTest
ln 26: look at http://www.scalatest.org/user_guide/using_assertions (find 'assertThrows'). 'false shouldBe true' is fantastic!

ResettableCountDownLatchTests: can you please describe what is happening here? i dont get what does 'v' stands for in this tests

See #443

ProtocolMessageSerializer :
why do you need to implement your own serializer? it it becase of size of a serialized message? protobuf or smth like that would handle this easily and be even more small(and fast while serializing\deserializing).

Let it be.

'entities' package: every class here is more like 'repository' because 'entity' is a single object that is stored into a database.

Opened #446

TStreamsFactoryTest
ln 26: look at http://www.scalatest.org/user_guide/using_assertions (find 'assertThrows'). 'false shouldBe true' is fantastic!

Opened #447


Implement Maximum Error Histogram Algorithm

This issue is for implementing the methods described in the paper: Space Efficient Streaming Algorithms for the Maximum Error Histogram. There, two different algorithms are proposed: piecewise constant histogram (PCH) and piecewise linear histogram (PLH). Both can be considered lossy time series compression techniques and will be valuable assets to TerseTS.

PWLH is still missing. This I reopen this issue.


add hostNetwork: true  for alpine in Kernel2Ethernet2Kernel

hi @glazychev-art
I deployed the Kernel2Ethernet2Kernel example, but modified the alpine configuration. The configuration is as follows. I don't know if nsm supports it, but it looks like it works.
---
apiVersion: v1
kind: Pod
metadata:
  name: alpine
  labels:
    app: alpine
  annotations:
    networkservicemesh.io: kernel://kernel2ethernet2kernel/nsm-1
spec:

  hostNetwork: true
  dnsPolicy: ClusterFirstWithHostNet

  containers:
  - name: alpine
    image: alpine:3.15.0
    imagePullPolicy: IfNotPresent
    # simple `sleep` command would work
    # but we need `trap` to be able to delete pods quckly
    command: ["/bin/sh", "-c", "trap : TERM INT; sleep infinity & wait"]
  affinity:
    podAntiAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        - topologyKey: kubernetes.io/hostname
          labelSelector:
            matchExpressions:
              - key: app
                operator: In
                values:
                  - nse-kernel

But if I add another client2 in kustomization.yaml and the client2.yaml configuration is the same as above, it doesn't seem to work.
Looking forward to your help, thank you very much
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

namespace: ns-kernel2ethernet2kernel

resources:
- ns-kernel2ethernet2kernel.yaml
- client.yaml
- client2.yaml
- netsvc.yaml
- ../../../apps/nse-kernel

patchesStrategicMerge:
- patch-nse.yaml

@316953425
Have you tried to change the interface name for the second client from nsm-1 to nsm-2?
  annotations:
    networkservicemesh.io: kernel://kernel2ethernet2kernel/nsm-2

@316953425 Have you tried to change the interface name for the second client from nsm-1 to nsm-2?
  annotations:
    networkservicemesh.io: kernel://kernel2ethernet2kernel/nsm-2

hi @glazychev-art
yes
client and client2 have same ip

@316953425
As I can see you have both nsm-1 and nsm-2 for alpine and alpine-2. And they have different IP-addresses: <IP_ADDRESS> and <IP_ADDRESS>.
You see both interfaces because alpine and alpine-2 are located in the same network namespace.
Please take a look at what the hostNetwork flag means in Kubernetes.

hostNetwork

hi @glazychev-art
I'm new to k8s. I'm very sorry that I don't quite understand what you mean. Two pods in the same namespace cannot use hostNetwork: true at the same time. Is that true?

In your example above you have both nsm-1 and nsm-2:

Two pods in the same namespace cannot use hostNetwork: true at the same time. Is that true?

Kubernetes namespace and Linux network namespace are completely different things.
Please refer to the Kubernetes documentation to understand what hostNetwork option means.

hi @glazychev-art
my client.yaml have config like this :
  annotations:
    networkservicemesh.io: kernel://kernel2ethernet2kernel/nsm-1
spec:
  hostNetwork: true
  dnsPolicy: ClusterFirstWithHostNet

my client2.yaml have config like this :
annotations:
networkservicemesh.io: kernel://kernel2ethernet2kernel/nsm-2
spec:
hostNetwork: true
dnsPolicy: ClusterFirstWithHostNet
why in pod client and client2 both have nsm-1 and nsm-2
I read the hostNetwork document. I understand that hostNetwork maps the physical network directly to the pod. Is it because of hostNetwork?

In your example above you have both nsm-1 and nsm-2:


Using the new API of vtkCompositeDataDisplayAttributes.

Block-attributes are mapped by vtkDataObject*.

@lorensen , this patch fixes the build issues due to these changes.

Created #23


Add unit tests with coverage > 90%

You need to add a plug-in to automatically measure the coverage of your code with tests.

@AlexandraSokolova add gradle plugin for coverage
@Aemmie create unit tests for module report-generator
@KirillSto create unit tests for module jira-connector
@safronovD create unit tests for module rule-engine
@Solomonov create unit tests for module classifier

@KirillSto @Solomonov Please, finish this task by the end of the week.


Add query multitenancy and fix some bugs

This works for me end to end now. Since Grafana cannot set arbitrary
headers and we don't have an auth frontend in between Grafana and the
distributor yet, the distributor is temporarily taking the user ID from
basic auth. So to test with Grafana, edit the datasource and enable
basic auth with any user name (becomes userID) and password (is
ignored).
Switching around user IDs in basic auth in the data source seems to
indicate that it all works, end-to-end!

Bit of a shame we have to copy so much code?
LGTM otherwise.

@tomwilkie Yeah, that's not how we want to keep it, for sure. I will chat with Fabian to see what he thinks about making parts of the API code more reusable.


Add FormData validation at the add_field method.

Prevent errors being raised further down the stack by ensuring content_type, content_transfer_encoding and filename are instances of str in add_field. Technically filename can be a bytes instance, but I think for sanity we probably just want to ensure that it is a str as well.

The PR is looks good, but please rewrite test.
I prefer three separate tests for each raised exception.
Also tests should directly forbid bytes parameter like b'data'

Also, please, add yourself to CONTRIBUTORS.txt :)

Merged. Thanks!


Improvements on Transforms Documentation

Problem statement
Identify potential improvements to our documentation on creating transforms
Acceptance criteria

[ ] Identify gaps and potential improvements to our documentation on creating transforms noted in this ticket
[ ] Reviewed and aligned with Onboarding Engineers
[ ] Follow-on ticket(s) to create that documentation created

@victor-chaparro Can we add this as an agenda item to Engr sync this Friday?

Generic Examples for filters  Covid Pipeline vs UP - FHIR path
-- Regex match, does not match, has valid data for
Examples of how to implement Covid Pipeline settings as receiver transforms
How to filter antigen vs antibody?
Examples for how to use look up tables in transforms
FHIR enrichment transforms vs Receiver transforms

@JessicaWNava go through questions and see what could be added as documentation

@victor-chaparro What is the status on this one?

Antigen / Antibody documentation still blocked by Platform needing to finish the feature. Otherwise, all other ideas can be considered for a future sprint.
These are nice to haves, not need to haves.


Typo in package.json

Environment data

VS Code version: 1.39.1
Extension version (available under the Extensions sidebar): 2019.10.41019
OS and version: OSX 10.14.6
Python version (& distribution if applicable, e.g. Anaconda): N/A
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: N/A
Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info #3977): N/A

Expected behaviour
"description": "Select the Jupyter server URI to connect to. Select 'local' to launch a new Jupyter server on the local machine.",
Actual behaviour
"description": "Select the Jupyter server URI to connect to. Select 'local' to launch a new Juypter server on the local machine.",
Steps to reproduce:

Visit the settings page for the extension and see the description for jupyterServerURI.

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
N/A

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)
N/A

Happy to provide PR

Thanks for the PR! We will have a look when we can.


Cannot reproduce the same results for Sim10k->Cityscapes task

Hi @krumo ,
Thanks for this great work, I have some questions.
I'm trying to reproduce the results of your example (adapting from Sim10k dataset to Cityscapes dataset)
I get higher value for second line (image-level alignment only) AP50 = 38.07 and a lower value for third line (ins-level alignment only) AP50=34.88
However AP50 values for the rest of the lines are acceptable.
I suppose there is a difference in hyperparameters for each experiment.

could you please confirm if you use:
DA_IMG_GRL_WEIGHT: 0.2
DA_INS_GRL_WEIGHT: 0.2
in all the experiments for this dataset. Or you use different DA_IMG_GRL_WEIGHT when you use the image-level alignment only and a different DA_INS_GRL_WEIGHT
when you use the instance-level alignment only?

to make sure that I do it correctly, when I want to do the second line experiment (image-level alignment only ), I just comment the lines:
https://github.com/krumo/Detectron-DA-Faster-RCNN/blob/44e5b9acda4957c6016c36384e17e0c80e47894a/detectron/modeling/model_builder.py#L227-L230
Is there anything else to do?

you said in  #1 you don't provide a configuration about weight loss, and the weights for two-level adaptation are the weights of GRL in two levels
is that means DA_IMG_GRL_WEIGHT=DA_INS_GRL_WEIGHT= λ ?

λ is a trade-off parameter to balance the Faster R-CNN loss and our newly added domain adaptation components.

if that true, where this DA_IMG_GRL_WEIGHT: 0.2 and DA_INS_GRL_WEIGHT: 0.2 came from? in the paper they didn't mention such a value.

we set λ= 0.1 for all experiments

finally, in this case the L_cst is not multiplied by λ, but again in the paper

L=L_det+λ(L_img+L_ins+L_cst)

please correct me if i am wrong.
Thanks again

Hi @h13hiba,
Thanks for your attention! According to my experience, adversarial training is quite unstable and it's not suprising to get these results. However, a consistent improvement should be observed after combining image-level and instance-level adaptation.

Yes, I use the same parameter setting for Sim10k->Cityscapes task with different alignment methods. Both DA_IMG_GRL_WEIGHT and DA_INS_GRL_WEIGHT equals 0.2.
Yes, that's also how I did to test image-level only adaptation.
Yes. My implementation here is consistent with the original one in Caffe.
I get them by testing different parameter setting because I cannot reproduce the same results with the parameter setting stated in paper on Caffe2 and Detectron.
In my implementation, L_cst is also multiplied λ. Please look at Line 342 and Line 348.
Please let me know if you still have any confusion.

Thanks @krumo  for your reply, just last question: why did you use  L1 distance instead of L2 distance?
https://github.com/krumo/Detectron-DA-Faster-RCNN/blob/44e5b9acda4957c6016c36384e17e0c80e47894a/detectron/modeling/model_builder.py#L364-L365

@h13hiba In my understanding, in the original paper L_cst is the sum of L2 distances of many scalars. A scalar's L1 distance is the same as its L2 distance. That's why I use L1 distance here.

Hi @krumo ,
Which paper do you mean here:

I get them by testing different parameter setting because I cannot reproduce the same results with the parameter setting stated in paper on Caffe2 and Detectron.

Hi, @h13hiba
Since you have trained this model successfully, i want to discuss some errors occurred in my training process. I'm trying to reproduce the results of the example addressed in the article (adapting from Sim10k dataset to Cityscapes dataset) , First, it went on training, when it iterated to 60 iters, some errors appeared as following:
terminate called after throwing an instance of 'caffe2::EnforceNotMet'
what():  [enforce fail at distance_op.cu:64] X.dim32(i) == Y.dim32(i). 498 vs 499. Mismatch in dimensions /  Error from operator:
input: "gpu_0/repeated_img_probs" input: "gpu_0/ins_probs" output: "gpu_0/consistency_dist" name: "" type: "SquaredL2Distance" device_option { device_type: 1 cuda_gpu_id: 0 }
*** Aborted at<PHONE_NUMBER> (unix time) try "date -d @1553173945" if you are using GNU date ***
PC: @     0x7fcff4083428 gsignal
*** SIGABRT (@0x3e8000019ce) received by PID 6606 (TID 0x7fceb27fc700) from PID 6606; stack trace: ***
@     0x7fcff4429390 (unknown)
@     0x7fcff4083428 gsignal
@     0x7fcff408502a abort
@     0x7fcfed9a784d __gnu_cxx::__verbose_terminate_handler()
@     0x7fcfed9a56b6 (unknown)
@     0x7fcfed9a5701 std::terminate()
@     0x7fcfed9d0d38 (unknown)
@     0x7fcff441f6ba start_thread
@     0x7fcff415541d clone
@                0x0 (unknown)
I have checked the training dataset carefully and make sure they are correctly transformed.
Can you figure out the reason why it terminated?

Hi @Baby47,
I've encountered this problem too, and figured it was due to the code in the _add_consistency_loss method in model_builder.py
In this method the the mean image domain predictions are manually broadcasted along the instance domain predictions, but here it is assumed that there are always 256 instances per image. When there are less instances (by an odd number) your error shows up.
I've rewritten the core methods of the python layer that does the reshaping so that the right size and distributing takes place. I've replaced the second input, 'ins_probs', by 'rois':
`def expand_as(inputs, outputs):
img_prob = inputs[0].data
rois = inputs[1].data
import numpy as np
mean_da_conv = np.mean(img_prob, (1,2,3))
repeated_da_conv = np.expand_dims(mean_da_conv[rois[:,0].astype(np.int32)], axis=1)
outputs[0].feed(repeated_da_conv)
def grad_expand_as(inputs, outputs):
    import numpy as np
    img_prob = inputs[0].data
    rois = inputs[1].data
    grad_output = inputs[3]
    grad_input = outputs[0]

    grad_o = grad_output.data[...]
    # sums = np.zeros(img_prob.shape[0],dtype=np.float32)
    # for b_idx,g_o in zip(rois[:,0],grad_o[:,0]):
        # sums[b_idx] += g_o
    # probably faster:
    sums = np.bincount(rois[:,0].astype(np.int32),grad_o[:,0]).astype(np.float32)
    g_is = sums/(img_prob.shape[1]*img_prob.shape[2]*img_prob.shape[3])

    grad_i = np.empty(img_prob.shape,dtype=np.float32)
    for b in range(img_prob.shape[0]):
        grad_i[b,...] = g_is[b]

    grad_input.reshape(img_prob.shape)
    grad_input.data[...] = grad_i`

and in the later parts of the method replace 'ins_probs' for 'rois' :+1:
model.net.Python(f=expand_as, grad_f=grad_expand_as, grad_input_indices=[0], grad_output_indices=[0])(['img_probs', 'rois'], ['repeated_img_probs'])
I know this should have been in a pull request, but for now here it is.

Hi @Baby47,
I've encountered this problem too, and figured it was due to the code in the _add_consistency_loss method in model_builder.py
In this method the the mean image domain predictions are manually broadcasted along the instance domain predictions, but here it is assumed that there are always 256 instances per image. When there are less instances (by an odd number) your error shows up. Note that it is unnatural when there are that less detections. Note that the selection of these 256 detections does rely on the target set labels.
I've rewritten the core methods of the python layer that does the reshaping so that the right size and distributing takes place. I've replaced the second input, 'ins_probs', by 'rois':
def expand_as(inputs, outputs):
img_prob = inputs[0].data
rois = inputs[1].data
import numpy as np
mean_da_conv = np.mean(img_prob, (1,2,3))
repeated_da_conv = np.expand_dims(mean_da_conv[rois[:,0].astype(np.int32)], axis=1)
outputs[0].feed(repeated_da_conv)
def grad_expand_as(inputs, outputs):
import numpy as np
img_prob = inputs[0].data
rois = inputs[1].data
grad_output = inputs[3]
grad_input = outputs[0]
grad_o = grad_output.data[...]
# sums = np.zeros(img_prob.shape[0],dtype=np.float32)
# for b_idx,g_o in zip(rois[:,0],grad_o[:,0]):
    # sums[b_idx] += g_o
# probably faster:
sums = np.bincount(rois[:,0].astype(np.int32),grad_o[:,0]).astype(np.float32)
g_is = sums/(img_prob.shape[1]*img_prob.shape[2]*img_prob.shape[3])

grad_i = np.empty(img_prob.shape,dtype=np.float32)
for b in range(img_prob.shape[0]):
    grad_i[b,...] = g_is[b]

grad_input.reshape(img_prob.shape)
grad_input.data[...] = grad_i

and in the later parts of the method replace 'ins_probs' for 'rois' :
model.net.Python(f=expand_as, grad_f=grad_expand_as, grad_input_indices=[0], grad_output_indices=[0])(['img_probs', 'rois'], ['repeated_img_probs'])
I know this should have been in a pull request, but for now here it is.

Thanks you a lot. Have you tried to minimize 256 instances per image? I will have a try whether your code works.


[Feature Request] make Chrome/Firefox the default internet browser on windows workspace

Internet Explore still seems to be the default web browser when triggered by other application (e.g. github desktop). Can we make Chrome the default internet browser for all windows instances?

We can close this ticket upon resolving #4


Let danger run on pull_request_target

Summary
This is a nit. Did some cleanups on our Danger setup.
The most substantial work is:

Moved over danger to run on pull_request_target. This allow us to re-use the Github Action access token without having to provide one.
Fixed an issue with the Pick Request label which was not applied correctly.
Removed the danger_id as we were not passing it correctly.

Changelog
[Internal] - Let danger run on pull_request_target
Test Plan
Tested locally with yarn danger pr https://github.com/facebook/react-native/pull/34197

I think that this started creating errors in PRs. Example

I think that this started creating errors in PRs. Example. @cortinico

I think that this broke something with the danger tokens, like here

I think that this broke something with the danger tokens, like here. @cortinico

I think that this broke something with the danger tokens, like here. @cortinico

Yup my bad. I missed a:
        env:
          DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}


Positive pairs in data augmentaions.

For GraphCL paper,  the positive pairs are both augmentations views using some augmentations in GraphCL paper.
But when I read code in unsupervised_TU/gsimclr.py, I found only one view is augmented, the other view is original without augmentation.
I wonder if I'd like to reproduct the results in paper, should I change x to another augmentaion view using some augmentations?
In other words, such implementations in code means one original view and one augmentaion view is enough for experiement?

Besides, In GraphCL_Automated/unsupervised/gsimclr.py, I have similar questions. In code , there is only compute one augmentation view's distribution, and the other view is original view. I think there are some differences between paper and code. Could you help me explain such cases?
By the way, I'm so thankful to all of you for such great and inspirable work! Best wishes for you !

Hi @Bunnyqiqi,
Sorry for the late reply. Please refer to https://github.com/Shen-Lab/GraphCL/issues/40.


How to use Slime instead of .leex in LiveView?

I see #61 and #63 #64
But I still have no clue if I can use .slime to replace .leex and how to set it up?
I tried just using slime but the app won't compile :)

I think I got it
Might not be right but, instead of
def render(assigns) do
    <%= TaskView.render("tasks.html", assigns)
end

Just do
def render(assigns) do
    ~L"""
      <%= TaskView.render("tasks.html", assigns) %>
    """
end

Works for me.

@owenstrevor I haven't had the chance to explore Slime + LiveView yet but I'd welcome any information you've learned. This is definitely something we want to support 😁

@owenstrevor I tried your solution and it seems to function, but for when I look at the socket traffic it's re-rendering the whole template each time something changes, rather than just the parts that changes.  Is that what you're seeing?
I think that the problem is that it's got to be "live" rendering all the way down, including calling live_render instead of render.  If you call render` at any point it will just consider that entire template as the dynamic data and re-render it.  A pretty cool fallback behavior, but not fully efficient.
But you don't seem to be able to do live_render with .html.slim files yet.  I'm going to keep poking to see what I can find.

An open question I don't know the answer to: I know that in Rails it supports having a sequence of extensions on views and works backwards.  So I would expect something like .html.leex.slim might work because it would see the .slim and turn it into a HTML or an EEX template, then if it's an EEX template it could see the .leex and interpret the EEX template as normal.  But if I were to guess, I would say even if phoenix did work backward on extensions like this that .slim files don't actually produce EEX templates but rather rendered HTML...

Proof of concept that seems to be working so far:
defmodule PhoenixSlime.LiveViewEngine do
  @behaviour Phoenix.Template.Engine

  @doc """
  Precompiles the String file_path into a function definition
  """
  def compile(path, _name) do
    path
    |> read!
    |> EEx.compile_string(engine: Phoenix.LiveView.Engine, file: path, line: 1)
  end

  defp read!(file_path) do
    file_path
    |> File.read!()
    |> Slime.Renderer.precompile()
  end
end

config :phoenix, :template_engines,
  slim: PhoenixSlime.Engine,
  slime: PhoenixSlime.Engine,
  slimleex: PhoenixSlime.LiveViewEngine

I could see having a LiveViewEngine in the phoenix_slime package, but perhaps there would be a simpler way with a way to pass an engine argument in to simply switch the engine option for EEx.compile_string but to default to Phoenix.HTML.Engine

@cheerfulstoic I would love if you'd open a PR with a new LiveViewEngine!

👍 Done.  I was holding off because it didn't seem to be fully working as far as sending down only the dynamic bits that have changed in sub-templates.  But probably more important to get it working for people first ;p

Great work @cheerfulstoic @doomspork, any docs on how to use this in the FooLive.ex?
Just so I got it, this PR compiles the slime into leex?

Hey @owenstrevor .  That's kind of right, though really if you use a PhoenixSlime.LiveViewEngine (by creating a file with the extension slimeex) then phoenix_slime just switches from using Phoenix.HTML.Engine to Phoenix.LiveView.Engine.  I think that that engine is what is used to render the leex files.  But this change doesn't effect the ~L sigil (I think I saw a change for that somewhere else...)

Why this task is closed? Why documentation has no info?

@mxrguspxrt You have to add slimleex: PhoenixSlime.LiveViewEngine to config templates as you can see on README and change extension to .slimleex as you can see on @owenstrevor comment.

Thank you @rjurado01 :purple_heart:


[SPARK-17840] [DOCS] Add some pointers for wiki/CONTRIBUTING.md in README.md and some warnings in PULL_REQUEST_TEMPLATE

What changes were proposed in this pull request?
Link to contributing wiki in PR template, README.md
How was this patch tested?
Doc-only change, tested by Jekyll

Test build #66732 has started for PR 15429 at commit 29941b9.

Test build #66732 has finished for PR 15429 at commit 29941b9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66732/
Test PASSed.

Test build #66808 has started for PR 15429 at commit 65f0bd3.

Test build #66808 has finished for PR 15429 at commit 65f0bd3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66808/
Test PASSed.

Merged build finished. Test PASSed.

Thanks - merging in master.


Auto-restart function of devtools in spring boot not working

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.83
OS Version: windows11

Steps to Reproduce:

Create a java gradle project with spring initializer (add jpa, lombok, mysql driver, web, devtools dependencies)
Install the spring boot extension from vscode
Open the spring boot project folder in vscode
Change the application.properties file to application.yml
Start debugging
Edit and save the java code
Auto-restart should work fine at this point, but it doesn't.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.83.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!


Error while deleting of a function with a quoted custom type

System information:

Ubuntu 18.04
DBeaver Version <IP_ADDRESS>909081341

Connection specification:

PostgreSQL 9.6.8 on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0, 64-bit.
The default driver.
Do you use tunnels or proxies (SSH, SOCKS, etc)? Answer: No.

Describe the problem you're observing:
Cannot delete a function with a quoted custom type.
Steps to reproduce, if exist:

Create a quoted custom type with comma:
CREATE TYPE "my,type" AS (a INTEGER, b TEXT);`
Create a function:
CREATE FUNCTION test(a "my,type") RETURNS INTEGER LANGUAGE SQL AS $$ SELECT 1 $$;
Update a functions list in DBeaver.
Delete the function.

Include any warning/errors/backtraces from the logs
"ERROR: type "my" does not exist".

Thanks for the bug report

Verified


[Crash]: Entering Illusioner Tower or Labyrinth causes crash

Mod Loader (Required)
Fabric
Minecraft Version (Required)
1.20.1
Mod Version (Required)
8.0.1
Notes (Required)
Running Illager Invasion on a 1.20.1 fabric server and entering some (not all) Illusioner Towers or Labyrinth structures causes both client and server to crash :/
Crash Report (Required)
https://gist.github.com/MetaForge/73369aa6df89fd923dced49a1f714a51
latest.log (Optional)
No response

Fixed in latest version.


Update CLI p2p bounds options

Correct the default values for p2p-peer-lower-bound and p2p-peer-upper-bound, and add a little explanation as requested by some users.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Thermostat

Please add a mode switch for the thermostat: heating and cooling! convenient for automations at different times of the year when one socket is used for the heater and fan

Hi @vitva
Which thermostat device model are you referring to?

Hi Sonoff Th 16 for homebridge Ewelink
Thanks

This would be good!
For reference, The ecobee thermostat has the following four selections in HomeKit: [OFF, HEAT, COOL, AUTO].
So, If there was an accessory simulation for Sonoff Th 16 thermostat, wherein a couple of EweLink switches could be setup to be controlled by the Sonoff Th 16 for when the room needs to be heated or cooled, that would be awesome!
Then one Switch could control a Room Air Conditioner or a Fan, while another Switch could control a Space Heater.

Hello Ben! I just thought, what if it is implemented as an additional parameter in the settings? whoever needs it activates and will use it and by default do it as it is now

What would be the functionality of the modes? Just to turn the device on?

the functionality will be the same as when just heating, control the temperature and maintain it ... but if I also need to cool, for example, with a fan and also control the temperature
let's say if there is heating, turn on the outlet with a heater; if there is cooling, turn on the outlet with a fan, well, this is an example. I think there will be a lot of different applications
maybe I'm not expressing my thoughts quite correctly

I understand what you are saying, but I will explain my perspective of the feature I have implemented.

if there is heating, turn on the outlet with a heater

You can now expose this particular outlet as a heater, based on the temperature reading of another sensor.

if there is cooling, turn on the outlet with a fan

You can also expose this separate outlet as a cooler, based on the same sensor as above.
So instead of having a "fake" thermostat which controls two outlets via automations, you can directly expose both outlets as heaters or coolers based on the temperature that the sensor reads.
Indeed this is just my opinion but does this not seem more simple? Because then you don't need the extra homekit automations.

I agree that this option will be easier, but when heating is needed, I don't think that cooling is also needed, and in this case that I suggest one entity controls the climate as a whole and not several ... that's why I proposed this implementation as an additional setting that needs to be activated. thereby expanding even more possibilities if the user needed them

Hi @vitva please update to the beta version of the plugin.
Inside the "Thermostat Devices" section of the config, when selecting the TH10/16 as a model and thermostat "show as", you should see this new option "Show Heat/Cool Modes".

Tick this box, then restart the plugin. You should then see both modes available in the home app...

Thanks to Ben for the implementation! Everything works exactly as I wanted 👍

Feature has been released in v8.9.0 :)


Remove 'Preview' because of GA

Remove 'Preview' indicator because Microsoft Azure officially announced the General Availability of Azure Data Lake Storage Gen2.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: emres sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@theresapalmer OK to merge?


Efs 1153 graph does not obey ndjson accept header

fix $graph to use ndjson when Accept: application/fhir+ndjson header is passed
Add check to remove logging from ignored urls
Update jwt bearer to handle spaces in cognito groups
update pcakages to fix glob warning
updated node to latest version.  Devs will need to run nvm install to install node 20.16 on their machines.
Add code to handle when the log string is too long in winston logging.  Cleans up unnecessary errors in logs and potentially prevents the node process getting killed because of this.

While testing found, "undefined" in logs


CEPH custom volumes cross-host issues

information
Ubuntu 18.04.1 LTS
config:
  cluster.https_address: <IP_ADDRESS>:8443
  core.https_address: <IP_ADDRESS>:8443
  core.trust_password: true
api_extensions:
- storage_zfs_remove_snapshots
- container_host_shutdown_timeout
- container_stop_priority
- container_syscall_filtering
- auth_pki
- container_last_used_at
- etag
- patch
- usb_devices
- https_allowed_credentials
- image_compression_algorithm
- directory_manipulation
- container_cpu_time
- storage_zfs_use_refquota
- storage_lvm_mount_options
- network
- profile_usedby
- container_push
- container_exec_recording
- certificate_update
- container_exec_signal_handling
- gpu_devices
- container_image_properties
- migration_progress
- id_map
- network_firewall_filtering
- network_routes
- storage
- file_delete
- file_append
- network_dhcp_expiry
- storage_lvm_vg_rename
- storage_lvm_thinpool_rename
- network_vlan
- image_create_aliases
- container_stateless_copy
- container_only_migration
- storage_zfs_clone_copy
- unix_device_rename
- storage_lvm_use_thinpool
- storage_rsync_bwlimit
- network_vxlan_interface
- storage_btrfs_mount_options
- entity_description
- image_force_refresh
- storage_lvm_lv_resizing
- id_map_base
- file_symlinks
- container_push_target
- network_vlan_physical
- storage_images_delete
- container_edit_metadata
- container_snapshot_stateful_migration
- storage_driver_ceph
- storage_ceph_user_name
- resource_limits
- storage_volatile_initial_source
- storage_ceph_force_osd_reuse
- storage_block_filesystem_btrfs
- resources
- kernel_limits
- storage_api_volume_rename
- macaroon_authentication
- network_sriov
- console
- restrict_devlxd
- migration_pre_copy
- infiniband
- maas_network
- devlxd_events
- proxy
- network_dhcp_gateway
- file_get_symlink
- network_leases
- unix_device_hotplug
- storage_api_local_volume_handling
- operation_description
- clustering
- event_lifecycle
- storage_api_remote_volume_handling
- nvidia_runtime
- container_mount_propagation
- container_backup
- devlxd_images
- container_local_cross_pool_handling
- proxy_unix
- proxy_udp
- clustering_join
- proxy_tcp_udp_multi_port_handling
- network_state
- proxy_unix_dac_properties
- container_protection_delete
- unix_priv_drop
- pprof_http
- proxy_haproxy_protocol
- network_hwaddr
- proxy_nat
- network_nat_order
- container_full
- candid_authentication
- backup_compression
- candid_config
- nvidia_runtime_config
- storage_api_volume_snapshots
- storage_unmapped
- projects
- candid_config_key
- network_vxlan_ttl
- container_incremental_copy
- usb_optional_vendorid
- snapshot_scheduling
- container_copy_project
- clustering_server_address
- clustering_image_replication
- container_protection_shift
api_status: stable
api_version: "1.0"
auth: trusted
public: false
auth_methods:
- tls
environment:
  addresses:
  - <IP_ADDRESS>:8443
  architectures:
  - x86_64
  - i686
  certificate: |
    -----BEGIN CERTIFICATE-----
    removed for brevity
    -----END CERTIFICATE-----
  certificate_fingerprint: 2f568344e52fa6cfe94346aa7babbc090c75ca09b05958219e60f9c39ef7c488
  driver: lxc
  driver_version: 3.1.0
  kernel: Linux
  kernel_architecture: x86_64
  kernel_version: 4.15.0-39-generic
  server: lxd
  server_pid: 76853
  server_version: "3.9"
  storage: ceph | zfs
  storage_version: ceph version 10.2.11 (e4b061b47f07f583c92a050d9e84b1813a35671e)
    | 0.7.5-1ubuntu16.4
  server_clustered: true
  server_name: host-0003
  project: default

Issue description
I get the following error when trying to attach a ceph storage volume to a container that resides on a host in the cluster that differs from the one the storage volume was created on:
Error: Add disk devices: Failed to setup device: Failed to initialize storage volume "test" of type "custom" on storage pool "ceph": no such file or directory
When not passing a target cluster member as a target, the cluster will decide what host to put a new container on. When the cluster decides to put a container on another host in the cluster, this error occurs.
I thought this would have to do with the volume being mapped on the host that was used to create it and be the exact same issue as #5422, but after rbd unmap lxd/custom_test the problem persisted.
Am i supposed to keep track of cluster hosts myself and always pass a target?
Steps to reproduce

Create storage volume on ceph pool lxc storage volume create ceph test
Create container on different host lxc launch ubuntu: test --target=other-host
Attach volume to container lxc storage volume attach ceph test test /mnt

Information to attach
The lxc info test --show-log shows the following. Is this related?
lxc test<PHONE_NUMBER>2533.714 WARN     conf - conf.c:lxc_setup_devpts:1641 - Invalid argument - Failed to unmount old devpts instance

For custom storage volumes on CEPH, we must make sure that:

On creation, we temporarily map, format and unmount the rbd volume
On attach, if not already mapped and mounted, we do that, along with creating the needed path on disk
On delete, we notify all hosts about it so they can clean things up

We already have a check in place to prevent mapping cross-host so that part should be fine, but we want to make sure we don't have the rbd volume mapped on the host that created it unless it's also used there and we need to make sure we create relevant paths when needed and do cluster-wide cleanup on delete.

I'll try to take a look at this myself since I've got a reproducing environment for this but I'll be travelling tomorrow so it may take a little while before I get to that.


Implement a distributed systems algorithm

We want to offer all people using MeiliSearch in their companies the possibility to do it without worrying about potential crashes. We want to provide a fault-tolerant search engine. One way to achieve this is to guarantee the high availability of the service. Many solutions are available to accomplish this. We believe that the best of them is the implementation of the RAFT consensus. The Raft consensus is perfect for creating a robust distributed system.
There are two main libraries in rust to implement RAFT, raft-rs, and actix-raft. raft-rs is the most famous of the two, but it is also more complicated. It requires the implementation of all ticks management. Actix-raft is less popular but even a much higher level (based on the actor system).
Regardless of the library used, the network part must be implemented. There are several possibilities. Use grpc, do traditional HTTP, or create a peer-to-peer network. The last option seems very interesting for several reasons. The libp2p library is complete, well implemented, and easy to use. There are, for example, very nice features like mdns, broadcast, compression, and encryption.

I tried to use the combination of actix-raft and libp2p but it wasn't successful. The actix-raft library, has only one example on GitHub, raftor. I tried to make this project work but after a few minutes of use I saw that it was in development, but with few contributions. It wasn't working well and ram consumption was skyrocketing. I also tried to use libp2p which seems very promising. Only, to raft we need acquittal. I didn't find the best practices to manage my swarm like I wanted.
In the end, I left on a known and healthy basis. raft-rs + grpc-rs. I searched for an application that used it other than TiKV. I found bayard. I started by cloning the project and removing everything that was useless to me. All the CLI and associated GRPC management. this removed almost 75% of the code. I also replaced the use of tantivy with a simple HashMap. Once I tested this raft, I made it my starting point to develop the raft interface on MeiliSearch.

Now there's still a lot to do. Here's a list.

[x] Make the sample raft test
[ ] Update raft-rs from 0.4.3 to 0.6.0-alpha
[ ] Use Prost instead of rust-protobuf
[ ] Link meilisearch-raft to meilisearch-core and meilisearch-http
[ ] Fin a way to improve error handling
[ ] Fin a way to improve channels & change from threads to async/await

You might take a look at the activity around bastion and artillery for node discovery. https://artillery.bastion.rs/getting-started/getting-started.html

What about outsourcing the index storage to tikv (https://github.com/tikv/tikv)?

hey, any update on this?

Hey @hah, we are currently working on a POC of a raft consensus, we managed to make it work but it is not releasable for now. We have a big work to do on Bug tracking.
thanks for your interest on this feature @hah! 😃

This is no more relevant, we close it, we have several issues on this topic and the work is in progress.


Error: process is not defined

My React version is 17

Temp fix
https://stackoverflow.com/a/64553486/2811107

facing this same issue in my project
factoryWithTypeCheckers.js:170 Uncaught ReferenceError: process is not defined
at s (factoryWithTypeCheckers.js:170:1)
at i (factoryWithTypeCheckers.js:241:1)
at factoryWithTypeCheckers.js:116:1
at index.js:14:1
at u (context.js:34:1)
at Module../node_modules/react-iconly/dist/index.modern.js (factoryWithThrowingShims.js:16:1)
at Module.options.factory (react refresh:6:1)
at webpack_require (bootstrap:24:1)
at fn (hot module replacement:61:1)
at Module../src/components/DashboardNav.jsx (AdminDashboard.jsx:5:1)
s @ factoryWithTypeCheckers.js:170
i @ factoryWithTypeCheckers.js:241
(anonymous) @ factoryWithTypeCheckers.js:116
(anonymous) @ index.js:14
u @ context.js:34
./node_modules/react-iconly/dist/index.modern.js @ factoryWithThrowingShims.js:16
options.factory @ react refresh:6
webpack_require @ bootstrap:24
fn @ hot module replacement:61
./src/components/DashboardNav.jsx @ AdminDashboard.jsx:5
options.factory @ react refresh:6
webpack_require @ bootstrap:24
fn @ hot module replacement:61
./src/pages/Dashboard.jsx @ index.js:7
options.factory @ react refresh:6
webpack_require @ bootstrap:24
fn @ hot module replacement:61
./src/App.js @ bundle.js:21
options.factory @ react refresh:6
webpack_require @ bootstrap:24
fn @ hot module replacement:61
./src/index.js @ SignUpStep2.jsx:48
options.factory @ react refresh:6
webpack_require @ bootstrap:24
(anonymous) @ startup:7
(anonymous) @ startup:7

Yeap, me too, the same issue.
I am using react-scripts: 5.0.0 version and 17 version of React.

I've the same issue in my react project, but i still not find the solution

Potential fix here: #33, please test it and let me know if works as expected.

Potential fix here: #33, please test it and let me know if works as expected.

your PR didn't merge correctly, you can check your PR changes and current state of repository in package.json .

@MiladPashaei try to downgrade react-scripts package from your project to 4.0.3, until a fix will be provided.


CharacterBody2D constantly jumps when moving

Godot version
4.0.3.stable.mono
System information
Windows 11, gl_compatibility
Issue description
A CharacterBody2D in an empty scene keeps constantly jumping during its movement. I tried both MoveAndCollide() and MoveAndSlide() in high velocity (212, 212).
// Called every frame. 'delta' is the elapsed time since the previous frame.
public override void _Process(double delta)
{
    this.MainPlayerEntity.MoveAndCollide(new Vector2(2f, 2f));
}

Note the GIF recorder is a bit laggy here, so it's a bit inaccurate.
Steps to reproduce

Create a simple project with a empty 2D scene
Attach a CharacterBody2D with some bitmap or graphics inside
Move the CharacterBody2D within _Process in the root 2D scene.

Minimal reproduction project
N/A

Please read the documentation, you need to use delta
For support questions and help please first turn to the other community channels, this is for bug reporting, not a help desk.


Add BSC Testnet

Thanks for PR can you update the readme so it has the bsc testnet in the table please…

https://gitlab.com/aave-tech/nft/backend-social/-/tree/master/backend/src

Thanks for PR can you update the readme so it has the bsc testnet in the table please…


ServiceCollectionExtensions: Fix registration with options

Description
There is an issue with the overloads in ServiceCollectionExtensions that uses instance instead of action. This problem is caused by the following line of code (o = options):
public static IServiceCollection AddMudSomeService(this IServiceCollection services, SomeOptions options = null)
{
   options ??= new SomeOptions();
   services.AddMudSomeService(o => {
     o = options;
   });
}

To illustrate this problem, consider the following simple code:
static void Main(string[] args) {
  AddMudBlazorSnackbar(new TestConfiguration() { Value = "NewValueNonAction"});
  AddMudBlazorSnackbar(configuration => configuration.Value = "NewValueAction");
}

public static void AddMudBlazorSnackbar(Action<TestConfiguration> configuration) {
  var options = new TestConfiguration();
  configuration(options);
  Console.WriteLine(options.Value);
}

public static void AddMudBlazorSnackbar(TestConfiguration configuration) {
  AddMudBlazorSnackbar(o => o = configuration);
}

public class TestConfiguration {
  public string Value { get; set; } = "Default";
}

The result will be:
Default for first method
NewValueAction for second method.
We can also observe this issue in the screenshot provided, where the value was set but ended up being the default value in the IOption.

The AddMudServices is using the overloads that are broken.
NB! Interestingly, the AddMudBlazorSnackbar is the only method worked correctly because it directly injects the instance without using services.Configure(options):
 configuration ??= new SnackbarConfiguration();
services.TryAddScoped<ISnackbar>(builder => new SnackbarService(builder.GetService<NavigationManager>(), configuration));

For IServiceCollection, the recommended approach for options is to use an Action.
I have addressed this issue by reassigning each property, but I have also marked those overloads as [Obsolete].
Other changes
I found few bugs and fixed:

There is a missing property assignment for QueueDelay in PopoverOptions.
In SnackbarService, I replaced the usage of SnackbarConfiguration with IOptions<SnackbarConfiguration] to maintain consistency with the rest of the code.
I added additional tests for ResizeOptions and slight changes as the check for r is null && l is not nul was missing, and removed the public override int GetHashCode() => ReportRate method. It is not recommended to calculate the hash code based on mutable properties. Or maybe consider using a record then?
I removed the second constructor in ResizeObserver as it is not recommended when using the class for dependency injection. If someone decides to replace the DI framework with another one, the constructor selection logic might differ.
I moved ServiceCollectionExtensions from Service folder to Extensions folder. All extensions should be in the Extensions folder to quickly locate the file.

How Has This Been Tested?
I have wrote a full test of ServiceCollectionExtension. I don't know if it's redundant or an overkill.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

I also don't know if this is intentional, but ResizeOptions.BreakpointDefinitions is always mutated by ResizeListenerService at boot, and it doesn't take into account if you set any value or not, it will always be replaced:
https://github.com/MudBlazor/MudBlazor/blob/d295075a547d84f07a4faa197c14c22eb89f3c65/src/MudBlazor/Services/ResizeListener/ResizeListenerService.cs#L36
I have not addressed this.

I'm btw surprised that nobody hit that, I guess most people use defaults or lambda, and for the most important SnackBar it was actually set correct as I described above.

Actually, I found one issue where person described that there is no effect of settings when he set PopoverOptions in the AddMudServices.

I remember being baffled by that issue when i first saw it - thanks for finding the root issue!

I also don't know if this is intentional, but ResizeOptions.BreakpointDefinitions is always mutated by ResizeListenerService at boot, and it doesn't take into account if you set any value or not, it will always be replaced:
https://github.com/MudBlazor/MudBlazor/blob/d295075a547d84f07a4faa197c14c22eb89f3c65/src/MudBlazor/Services/ResizeListener/ResizeListenerService.cs#L36
I have not addressed this.

Hmm, this looks extremely suspicious. Doesn't this nullify the user's breakpoints?

I also don't know if this is intentional, but ResizeOptions.BreakpointDefinitions is always mutated by ResizeListenerService at boot, and it doesn't take into account if you set any value or not, it will always be replaced:
https://github.com/MudBlazor/MudBlazor/blob/d295075a547d84f07a4faa197c14c22eb89f3c65/src/MudBlazor/Services/ResizeListener/ResizeListenerService.cs#L36
I have not addressed this.

Hmm, this looks extremely suspicious. Doesn't this nullify the user's breakpoints?

It is. This is why I said I'm unsure if its intentional or what?

It looks to me like a bug. The original intention might have been to initialize the breakpoints if none are provided by the user. Probably a nullcheck is missing.

It looks to me like a bug. The original intention might have been to initialize the breakpoints if none are provided by the user. Probably a nullcheck is missing.

Yes, it looks like a bug to me as well. But let's address this in separate PR.
We have multiple issues here. Even before this PR the ResizeListenerService and BreakpointService both share the same instance of ResizeOptions.
And both mutating the BreakpointDefinitions, while BreakpointService does check if custom values are provided with:
if (options.BreakpointDefinitions == null || options.BreakpointDefinitions.Count == 0)
{
	options.BreakpointDefinitions = DefaultBreakpointDefinitions.ToDictionary(x => x.Key.ToString(), x => x.Value);
}

It doesn't really matter, as the ResizeListenerService will override them. But then when we add the check to ResizeListenerService there still will be conflict, as each of them has their own set of breakpoints which we also discussed earlier if you remember.


Adding more end-to-end like tests to detekt

@chao2zhang and me had a discussion about adding more end-to-end like tests to detekt's code base. This is definitely beneficial in terms of code quality.
Hence, the quote from PR #3319 is included in this issue. It contains a good idea, which might be followed. Of course this is an opened discussion. So please feel free to submit your ideas inside this issue.

In my mind, such end-to-end tests should be a separate module or repo that applies detekt gradle plugin, runs against some kotlin code with violations, and validates the error can be reported. This does not exist today but I definitely can help sparkle the discussion

Other option (no exclusive): checkout some opensource projects that already use detekt and run them.
Problem: we need to be carefull with false positives if they break their build.
Pros: we test agains real code.
Some options: Firefox & LeakCanary.

Problem: we need to be carefull with false positives if they break their build.
Pros: we test agains real code.

I guess this is hard to automate, since the tests directly depend on 3rd party code. If 3rd party gets changed, those tests have to be adapted in the detekt repository. For testing purposes it's enough to have a few files containing some issues and folders to test detekt end-to-end.
For rules testing your approach is fine though. This repo already contains a script to verify rule behavior on 3rd party GitHub code. However, this topic here is strictly not about testing rules.

Such integration tests need to keep some code with violation of detekt rules. I doubt a 3rd party repo would satisfy our need: Well-maintained repos tend to have good hygiene to remove detekt violations quickly.

My statement was based on out-dated information. Please allow me to correct the statement here. In addition to the common unit testing, this project embraces two ways to test our Gradle plugins:

Using ProjectBuilder from gradle-api, we can assert on specific Task this way.
Using GradleRunner from gradle-testkit, we can perform assertions based on the input and output of Gradle.

The end-to-end would probably use GradleRunner, but the current test does not seem to have high coverage. For example:

DslGradleRunner.ktFileContent only generates Kotlin code violating MagicNumber.
AutoCorrect is not verified.

End-to-end would be exceeding beneficial as we are introducing tooling and lower-level changes.

Problem
One of the problems that I encountered when prototype #3327:

Because the integration tests using gradle-testkit are all under detekt-gradle-plugin/src/test
Because AGP is introduced as compileOnly dependency in detekt-gradle-plugin
Problem: testing android gradle plugin using gradle-testkit does not work out of the box

Some technical lower-level details: JavaGradlePluginPlugin:204 uses main/runtimeClassPath which does not include AGP. Therefore, the tests will fail at run time. The exact exception is:
* What went wrong:
    Plugin [id: 'com.android.library'] was not found in any of the following sources:

    - Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
    - Gradle TestKit (classpath: /Users/cazhang/detekt/detekt-gradle-plugin/build/classes/java/main:/Users/cazhang/detekt/detekt-gradle-plugin/build/classes/kotlin/main:/Users/cazhang/detekt/detekt-gradle-plugin/build/resources/main:/Users/cazhang/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-gradle-plugin-api/1.4.10/c06dc95764119b3188034c644805de9b76148806/kotlin-gradle-plugin-api-1.4.10.jar:/Users/cazhang/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.4.10/ea29e063d2bbe695be13e9d044dcfb0c7add398e/kotlin-stdlib-1.4.10.jar:/Users/cazhang/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-common/1.4.10/6229be3465805c99db1142ad75e6c6ddeac0b04c/kotlin-stdlib-common-1.4.10.jar:/Users/cazhang/.gradle/caches/modules-2/files-2.1/org.jetbrains/annotations/13.0/919f0dfe192fb4e063e7dacadee7f8bb9a2672a9/annotations-13.0.jar)
    - Plugin Repositories (plugin dependency must include a version number for this source)

Note that the dependencies in Gradle TestKit are exactly from main/runtimeClasspath.
Solution

Move all integration tests (gradle-testkit) of detekt-gradle-plugin into a separate module, which also resolves the issue mentioned here. This allows us to configure a publicly invisible module and make our tests work out of the box.
Separate android plugin into a separate module. This requires a fair amount of refactoring.
Customize testkit dependencies following https://docs.gradle.org/current/userguide/test_kit.html#sub:test-kit-classpath-injection. I have spent half of my day on this and due to my limited gradle knowledge, I couldn't get it fully working.

Recommendation
Solution 1 can kill two birds with one stone. We can create a detekt-gradle-integration-tests module, put some code with detekt violations and build tests verifying detekt end-to-end, including the android variant of gradle plugin.

Thank you very much for this further elaboration. I completely agree with your recommendation (solution 1). This solves the problem. I don’t think a big refactoring for solution 2 is beneficial looking towards detekt v2.0.

Move all integration tests (gradle-testkit) of detekt-gradle-plugin into a separate module, which also resolves the issue mentioned here. This allows us to configure a publicly invisible module and make our tests work out of the box.

@schalkms if possible, would you mind changing the issue title to be Setup the correct pipeline for integration test of detekt gradle plugin? This issue mentioned in https://github.com/detekt/detekt/issues/3324#issuecomment-751909633 now happens quite often for my recent PRs.

@schalkms if possible, would you mind changing the issue title to be Setup the correct pipeline for integration test of detekt gradle plugin? This issue mentioned in https://github.com/detekt/detekt/issues/3324#issuecomment-751909633 now happens quite often for my recent PRs.

@chao2zhang I updated the title.

@chao2zhang I updated the title.

This issue was also discovered earlier as described in the main summary of #2493

This issue was also discovered earlier as described in the main summary of #2493


Issue with View/Edit/Create - Location Attributes

Steps to replicate:
Login as an ECMPS user
In the workspace, open any configuration tab and navigate to the Location Attributes and Relationships section
Click View/Edit/Create options. Fails to open the respective modal.
Note: No pre-filtering is required on this section. Any UI work or creation of backend endpoints out of scope for this ticket

Bug Fixed


Per Issue #306, simplifies this RFC and removes the ~please_ack decorator

@dhh1128 - as you'll see, I removed ~please_ack and did not create a decorator RFC for it. At this time, I'm not aware of any implementations that have that.  Even if we add it back here, or in a separate RFC, I don't think the advanced features are necessary at this time. As noted in the second commit, I removed links from other RFCs to the ~please_ack section of this RFC and added a TODO to link to the new RFC when it is added.

@swcurran : I'm not strongly opposed to this change, but I'm not particularly in favor of it, either. Is there a reason why you feel like it is worth doing?

Okay, I went and read issue #306.
I don't mind removing this content from the main RFC, but I don't want to just throw away the thinking about ~please_ack. That is substantial thinking, and just deleting it to start over doesn't seem appropriate.
I'd say, if you want to make the simplifying change, please create an RFC for ~please_ack and move the other content there.

Fortunately, we've used a version control system, so we can still get to
the content. :-)
I'm happy to create an RFC for ~please_ack, but it will be a very simple
version, and will not have anything about the "advanced features" from the
original PR. I think while the simple version is needed, the advanced
features not compelling.  I can do a new RFC, but thought others (like you)
might want to add more.  My thought is that we do the simple ~please_ack
decorator and then a separate RFC that defines a subscription decorator
that covers the advanced features.
On Tue, Nov 19, 2019 at 7:45 PM Daniel Hardman<EMAIL_ADDRESS>wrote:

Okay, I went and read issue #306
https://github.com/hyperledger/aries-rfcs/issues/306.
I don't mind removing this content from the main RFC, but I don't want to
just throw away the thinking about ~please_ack. That is substantial
thinking, and just deleting it to start over doesn't seem appropriate.
I'd say, if you want to make the simplifying change, please create an RFC
for ~please_ack and move the other content there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hyperledger/aries-rfcs/pull/316?email_source=notifications&email_token=AAHYRQUYRWFXLRC7WLRXB3DQUSXFTA5CNFSM4JPLQ5BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEQTIYA#issuecomment-555824224,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHYRQSRPOSK24X67JO4NXDQUSXFTANCNFSM4JPLQ5BA
.

That answer ("I'll put ~please_ack in a new RFC if I have to, but I'm not
moving the advanced thinking") doesn't feel reasonable to me. You are
forcing two issues to be combined that ought to be separated:

Limiting the scope of the current RFC so we can promote its core to
ACCEPTED status.
Deleting functionality that's been described that you apparently don't
believe in.

We can accomplish #1 without taking any position on #2, and that's what
should be done for the current issue. This requires us to shift content out
of the RFC--not wholesale delete it.
On Wed, Nov 20, 2019 at 11:00 AM Stephen Curran<EMAIL_ADDRESS>wrote:

Fortunately, we've used a version control system, so we can still get to
the content. :-)
I'm happy to create an RFC for ~please_ack, but it will be a very simple
version, and will not have anything about the "advanced features" from the
original PR. I think while the simple version is needed, the advanced
features not compelling. I can do a new RFC, but thought others (like you)
might want to add more. My thought is that we do the simple ~please_ack
decorator and then a separate RFC that defines a subscription decorator
that covers the advanced features.
On Tue, Nov 19, 2019 at 7:45 PM Daniel Hardman<EMAIL_ADDRESS>wrote:

Okay, I went and read issue #306
https://github.com/hyperledger/aries-rfcs/issues/306.
I don't mind removing this content from the main RFC, but I don't want to
just throw away the thinking about ~please_ack. That is substantial
thinking, and just deleting it to start over doesn't seem appropriate.
I'd say, if you want to make the simplifying change, please create an RFC
for ~please_ack and move the other content there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/hyperledger/aries-rfcs/pull/316?email_source=notifications&email_token=AAHYRQUYRWFXLRC7WLRXB3DQUSXFTA5CNFSM4JPLQ5BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEQTIYA#issuecomment-555824224
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAHYRQSRPOSK24X67JO4NXDQUSXFTANCNFSM4JPLQ5BA
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hyperledger/aries-rfcs/pull/316?email_source=notifications&email_token=AAQ3JCAELVW5LUYRFP52G4DQUVNH7A5CNFSM4JPLQ5BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEESP3IA#issuecomment-556072352,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQ3JCFP4TACTRS5XQNTDQ3QUVNH7ANCNFSM4JPLQ5BA
.

As noted, I deleted content from the RFC for the goal of getting the RFC into an accepted state.  That content was removed from that does not prevent anyone from putting it into a separate RFC.
On the separate issue of what to do with the content removed from the RFC, I stated above my recommendation - add an RFC for the simple ~please_ack, and take the advanced thinking and apply it to a more general subscription mechanism vs. tied directly to the ack/please_ack as I think the tie between them is not particularly strong.

An alternative is that we merge this version of the RFC, move it to accepted and then someone (perhaps you :-) ) can just submit a new proposed ACK RFC that is the same as the previous version.  That gives us something to point to with for Aries Stable, and nothing is deleted.
As noted, I'm fine with the approach, but would raise a question about whether the advanced features should be part of the ACK protocol.  That would be aligned with the process.
Alternatively, what I have done here goes in as a different ACK RFC vs. reusing the same 0015 numbering.
Thoughts from a process perspective?  My goal is that we have an accepted RFC that reflects what has been built so that we can reference it in Aries Stable.

Updated the PR to add a new RFC for ~please_ack that moves both the decorator and the advanced concepts from the RFC 0015-ACKs.
@dhh1128 - what do you think? I did eliminate the png's :-)

I am just getting off of a plane, but this sounds great, and I will try to
merge it tomorrow morning when I get up.
On Wed, Nov 20, 2019, 5:12 PM Stephen Curran<EMAIL_ADDRESS>wrote:

Updated the PR to add a new RFC for ~please_ack that moves both the
decorator and the advanced concepts from the RFC 0015-ACKs.
@dhh1128 https://github.com/dhh1128 - what do you think? I did
eliminate the png's :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hyperledger/aries-rfcs/pull/316?email_source=notifications&email_token=AAQ3JCH3TUE5SVNNHXAGFBTQUXHAFA5CNFSM4JPLQ5BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEWJDAI#issuecomment-556568961,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQ3JCCN5XVQL5VO2X2MBTLQUXHAFANCNFSM4JPLQ5BA
.


Handle AzureException during storage upload.

Backport #3930
(DCOS-40442) AzureException during storage upload.

@mesosphere-mergebot merge-it


Use standart crypto library to generate certificates

holding off on merging - I'm seeing this with install - but will run again since it might be an issue on my end:
$ oc logs -n fulcio-system fulcio-server-c4955b5d6-fx7cq
2023-12-04T18:46:13.326Z	FATAL	app/serve.go:253	error during PEM decoding

If @JasonPowr or @osmman can install & confirm this is not an issue, please comment!

Thank @sallyom for finding the bug. I fixed cause of the problem which was that I didn't encode the fulsio-root certificate into PEM format.

I tested this, all works well now!


iOS [Acr.UserDialogs] This is the bait library, not the platform library. You must install the nuget package in your main executable/application project

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[x] iOS
[] Android
[] UWP
[] NET Standard 1.1

Version of OS(s) listed above with issue
Real device (iOS 11.1.1,iOS 11.1.2...)
Version of ACR UserDialogs Library
7.0.0-beta2 (Xamarin Form .NET Standard 2.0)
(Acr.UserDialogs is installed both .NET Standard project and iOS project)
Expected Behaviour
Launch application after splash screen on TestFlight devices( iOS simulators are fine)
Actual Behavior
[Acr.UserDialogs] This is the bait library, not the platform library. You must install the nuget package in your main executable/application project
Code of Conduct

No Library Update Requests
No Timeline Requests
Please read through the documentation and FAQs
Please be respectful of my time. I put a lot of effort into my libraries.  I try to support the issue requests within a day.  I'm not psychic, so please take the time to fill out the above form as complete as possible

This has been answered many times.  Please read the install instructions.

I have exactly the same issue, but it occured only within 7.0.0-beta2 version.
ACR.UserDialogs with all "linked" packages, are installed at PCL project, as well as Android and iOS projects. Till 6.5.1 it works fine, but it's throwing mentioned error at 7.0.0-beta2, only at iOS. Cleaning all bin/obj/packages folders, clearing whole solution, restarting and rebuilding didn't solves the issue.

Re-tested with 7.0.0-beta3 - issue fixed, everything works fine also at iOS.
Thanks


新版deeplx需要设置token，插件没有输入token的配置项

Access token is set. Use the Authorization: Bearer  header to access /translate.

That's optional. But I think I will release a new version.

@Herbertzz Done. #11

Thank you. 🎉


Revert "Temporarily remove the navigation preload dependency"

Reverts GoogleChrome/workbox#1570

Coverage remained the same at 86.514% when pulling 89c1bff6d2199e500901df80f1e6ae7a02fc7149 on revert-1570-remove-nav-preload-dep into d95348b930cce11c400e236adf3ca5c0727d9815 on master.


remove unused time features

leaving out std doesn't really do anything because formatting implies std per https://docs.rs/crate/time/0.3.0/features.
However local-offset is unused here, and since this is the feature that reintroduces thread-safety shenanigans it seems worthwhile to avoid it if we can.
It may be that what this really means is that the current implementation of timestamp_local() is in fact not doing anything to localise the timestamp, and that's a bug.  I'm in the UTC timezone, so it's not quite straightforward for me to test this!
Edit: yeah, I'm pretty sure that there is no localisation going on.  Probably what you really want is
-    let now: time::OffsetDateTime = std::time::SystemTime::now().into();
+    let now = time::OffsetDateTime::now_local();

the implementation of  time::OffsetDateTime::now_utc() is exactly what you currently have in timestamp_local()
I'll submit a second MR and you can choose!

Wow 👀
Good investigative work.....


Docker Hub official image

Hello, I know this is a little early, but I am sure some folks would love to have ready-to-go images to play with Roc (without surprise, I would include myself into this group).
I can also create a repository under my namespace, if the team is not eager to maintain a Docker image (which I can totally understand in regard to all the remaining work).
I can see 2 tags for the image:

ubuntu-2204-nightly
alpine-3-nightly

[os]-[os-major-version]-[roc-version]

Not sure if tagging minor OS version makes sense at this point.
The most basic image for demonstration purpose:
FROM ubuntu:22.04

RUN apt-get update --fix-missing
RUN apt-get upgrade --yes
RUN apt-get install --yes \
    wget \
    libc-dev \
    binutils \
    build-essential \
    clang
RUN wget -q -O roc.tar.gz https://github.com/roc-lang/roc/releases/download/nightly/roc_nightly-linux_x86_64-latest.tar.gz
RUN mkdir /usr/lib/roc
# --strip-components=1 not needed once https://github.com/roc-lang/roc/issues/4118 is solved.
RUN tar -xvz -f roc.tar.gz --directory /usr/lib/roc --strip-components=1

ENV PATH="$PATH:/usr/lib/roc"

N.B.: probably not the correct repo, if the idea is well received the team may create the docker repository under the roc-lang namespace.
Being part of the namespace would allow to automatize building the Docker images once a new version (nightly) comes out.

It would be great to create a user with the permissions 1000:1000 as per the Node.js official Docker image to ease the permission handling of this image through a container when run in case it has to create/read/delete files since running a container as root can be an issue, especially for folks running on Linux or Mac (can't say that for Windows as I have never used Docker on Windows).
FROM archlinux:latest

ARG USER_ID=1000
ARG GROUP_ID=1000

USER root

WORKDIR /root

RUN pacman -Syy --noconfirm wget tar gzip \
  && groupadd --gid $GROUP_ID roc \
  && useradd --uid $USER_ID --gid $GROUP_ID --create-home --shell /bin/sh roc \
  && wget -q -O roc.tar.gz https://github.com/roc-lang/roc/releases/download/nightly/roc_nightly-linux_x86_64-latest.tar.gz \
  && mkdir --parent /usr/local/lib/roc \
  && tar -xvz -f roc.tar.gz --directory /usr/local/lib/roc --strip-components=1

ENV PATH="$PATH:/usr/local/lib/roc"

USER roc

WORKDIR /home/roc

Not sure why I'm getting a Can't find module Os when running the repl inside the container but it works as expected with the correct permissions.
Using Archlinux here, but it could easily be swapped out for Debian or Alpine, although from the tests, alpine seems to be not working as for Archlinux, I'm suspecting a missing dynamic library for roc to run just like I did for Elm some years ago.

Hi @khalyomede,
I've already claimed the roclang username on dockerhub (roc-lang was not allowed).
Someone on zulip was also interested in a docker image.
If someone would be willing to make a PR to the roc repo with a Dockerfile and tests (github workflow) I'll set up nightlies with dockerhub. The tests at the end of this script should be used.

The official docker images are available at: https://hub.docker.com/u/roclang


[NEW FEATURE] Support for SRV record

We use redislabs to manage our redis clusters. They optimize the hardware and run multiple clusters on the same ip with different port. Since the port is different, we could manage the DNS mapping better. Say, I destroy the cluster and recreate a new one, it requires application to be restarted. With SRV record support, this should be a straightforward change without requiring a restart.

@ganeshs adding support for SRV record seems like a too specific feature, but I think we can add a generic "address resolver" (see https://github.com/xetorthio/jedis/tree/address_resolver).
This way you'll be able to easily add srv record resolver based on https://github.com/dnsjava/dnsjava for example.

@gkorland That should work. Let me try it out.

https://github.com/xetorthio/jedis/pull/2036

Resolved by #2151


Provide a way to navigate to oldest unread message and show an ---- unread messages ---- bar above

Modern Chat apps show the oldest unread message and start the chat view with that.
The package should offer a way to locate last read message base on message id and directly show it on top of the page with a marker. This is a common behaviour in Whatsapp or Messenger.
ChatView widget should have an lastReadMessageId field. When non null should work like described above.

Hmm
required


Workbooks updates for IPv6

Added signins by Ipv6 to  the signins workbook
Added named locations without CA coverage to the CA gap analyzer workbook
Added IPv6 addresses not part of Named locations to CA gap analyzer workbook

PR Checklist

[ ] Explain your changes, so people looking at the PR know what and why, the code changes are the how.
[ ] Validate your changes using one or more of the testing methods.

If adding or updating templates:

[ ] post a screenshot of templates and/or gallery changes
[ ] ensure your template has a corresponding gallery entry in the gallery folder
[ ] If you are adding a new template, add your team and template/gallery file(s) to the CODEOWNERS file. CODEOWNERS entries should be teams, not individuals
[ ] ensure all steps have meaningful names
[ ] ensure all parameters and grid columns have display names set so they can be localized
[ ] ensure that parameters id values are unique or they will fail PR validation (parameter ids are used for localization)
[ ] ensure that steps names are unique or they will fail PR validation (step names are used for localization)
[ ] grep /subscription/ and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR validation
[ ] remove fallbackResourceIds and fromTemplateId fields from your template workbook or they will fail PR validation

@SarahBar requesting your review as this is related to the IPv6 support in Azure AD which went live recently
https://learn.microsoft.com/en-us/troubleshoot/azure/active-directory/azure-ad-ipv6-support


Add Custom Labels to Deployment Containers

As an Anchor Platform developer I would like to add custom labels to the deployment and the containers.   For this story please add the feature to the helm chart to enable adding custom labels to the deployment containers.


Using Docker container name

https://github.com/UniversalRobots/Universal_Robots_ExternalControl_URCapX/blob/3a2048d1c69b6fc04e2f15c965a9cde1d75fcbef/README.md?plain=1#L62
As you have named your container, it may be easier to just reference the container's name directly when following the logs instead of the ID (ID's are subject to change which makes to user have to call docker ps frequently).
You can simply type the following to get the logs every time:
docker logs -f universal-robots_external-control_external-control-backend

@K-Michallik thanks


Does this module support HTTP2?

What do I need to do?

Hi @0079123,
What are you trying to accomplish? This module enables an RTMP/RTP backend for Nginx. It does support HTTP/2 streaming with HLS through the HTTP/2 module inside of Nginx. This project also has the benefit of being extremely well documented: https://github.com/arut/nginx-rtmp-module/wiki/Directives
If you're trying to accomplish HLS streaming over HTTP/2, please look at the application hls {} directive in the Wiki: https://github.com/arut/nginx-rtmp-module/wiki/Directives#hls

I don't think there is anything related to http2 in the hls directive.

@campones Correct. The HTTP2 support is completely independent of this module. Just adding the proper HTTP2 directives to the server{} block of your Nginx configuration is sufficient enough to enable HTTP2 support for HLS/M3U8 streams.

I know


Upgrade requirements

Codecov Report

Merging #93 (3cead68) into main (c0f9cbd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #93   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          173       173
  Branches        26        26
=========================================
  Hits           173       173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f9cbd...3cead68. Read the comment docs.


[Translation] La Casa Infestata(Korean)

What kind of translation do you want to add (mark with an X, e.g. [X] Descent)?

[X] Mansions of Madness
[ ] Descent

Scenario name or url
La Casa Infestata

Translation File
Localization.Korean.txt

I've sent a message to the author to notice him this translation, @cheeseguyhcl

Korean translation is now online. You can close this issue, @cheeseguyhcl

ok thank you!


I have read the CLA Document and I hereby sign the CLA

#6

I have read the CLA Document and I hereby sign the CLA

Hi @Lia0409
Please don't try to modify .github repo.


Remove translations 2.1

https://github.com/open-cluster-management/backlog/issues/12642

@birsanv This defect is approved for 2.1.x now. If we want the e2e tests to pass, we will have to deploy a cluster with 2.1 and set up the old-style of Travis variables (from before cluster-keeper). Do you want me to do that or are you OK to just force merge it, as the risk should be low.

@KevinFCormier I agree the risk is low and we should just force merge


Set up automated tests via Github Actions

This PR sets up the boilerplate for automated tests on github. To avoid unnecessary tests (e.g. when the PR is not ready yet), I set it up so that the tests run after "Ready for review".
To run the tests locally: pytest
For now there is just a dummy hello_world function until we start to populate the proteus module.
I renamed proteus.py -> start_proteus.py to avoid a name collission with the module.
Closes #86

@timlichtenberg

@nichollsh This PR is ready, could you have a look at it?

Snuck in a coverage badge while I have admin rights 😅

Currently the PROTEUS logo is not displayed correctly on the main Github page. Do you also want to fix this while at it?


.hello command suggestion

It only can be used when the user is in a voice channel. The bot will join the same voice channel, say hello, and then leave. Simple Enough.
Documentation:
https://discordpy.readthedocs.io/en/latest/api.html

I would like to take this up

Please update with the suggestions given in PR @Ave-Eren

Hey! I would like to take this issue up


Add files via upload

Screenshot of updated guidance Reference Architecture, this should supercede PR#2
Issue #, if available:
Description of changes:
Uploaded updated and agreed upon Reference architecture screenshot
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Uploading newer Reference Architecture image required


Support for collapsible content?

first, thank you for a great library!
Seems like the following Notion content:

Is being evaluated as:

I guess in such cases, we can use the <details>, for example: https://gist.github.com/pierrejoubert73/902cc94d79424356a8d20be2b382e1ab

Hey there,
Thanks for reporting. Seems like a quick task to do.
Should be available in the next release.

Alright, so quick update. I have implemented the logic and it looks something like this:
Notion:

Result:

However there are few limitations one must be aware of. One cannot use annotations in the toggle text.

This feature is available in the latest version (v2.4.0)

Amazing! thank you so much!


[AutoPR cdn/resource-manager] [Hub Generated] Review request for Microsoft.Cdn to add version preview/2019-06-15-preview

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6599

(message created by the CI based on PR content)


Broken Textures

miguipkv on Atlas server found a strike textured golbat and it is broken.

Just confirmed that the Strike-palette is now fixed