Write-DbaDbTableData failing with TIMESPAN values

Verified issue does not already exist?
Yes
What error did you receive?
HI All,
I need your help please.
I'm developping a PS Script that is doing some statistics and monitoring on the SQL infra in my company...
I'm trying to copy the jobs history to a centrale datawarehouse from the source server.
I'm doing a select on the source server and getting the database in the below sql types :
[Job_ID] [varchar](150) NOT NULL, [Run_Status] [tinyint] NOT NULL, [Run_DateTime] [datetime] NOT NULL, [Duration] [time](7) NOT NULL
The variable $JobsHistory contains the result :
`
$GetJobsHistoryQuery = "SELECT jh.[Job_ID], j.[Server_Name], [Run_Status], [Run_DateTime], [Duration]
FROM [dbaDB].[dbo].[Job_History] jh
INNER JOIN [dbo].[Job_Inventory] j ON j.Job_ID = jh.Job_ID"
    $JobsHistory= @()

    TRY {
        $JobsHistory += Invoke-DbaQuery -SqlInstance $TargetServer -Database $TargetDatabase -Query $GetJobsHistoryQuery -EnableException
    }CATCH {
        $Exception = $_.Exception.Message
        $FunctionError =  "Catched Error Details : " + "`r`n" + "Function:"  + "`t"   + "Copy-ServerJobsHistory" +
                    "`r`n" + "Job Name :"    + "`t`t" + $servername +
                    "`r`n" + "Error:"     + "`t`t" + $Exception + "`r`n ******************** `r`n"

        Write-Host " ERROR 35 : Cannot retreive Jobs History from the server [$TargetServer] `r`n $FunctionError"
        Add-Content -Path $Logfile -Value " ERROR 35 : Cannot retreive Jobs History from the server [$TargetServer] `r`n $FunctionError"
        Break;
    }

`
However, When I'm trying to insert this data on the central datawarehouse:
 $TempTableName ="[dbo].[TmpTable_$($TargetServer)_Job_History]"         TRY {             $JobsHistory | Write-DbaDbTableData -SqlInstance $MainServer -Database tempdb -Table $TempTableName -AutoCreateTable -EnableException         }CATCH {             $Exception = $_.Exception.Message               $FunctionError =  "Catched Error Details : " + "rn" + "Function:"  + "t"   + "Copy-ServerJobsHistory" +
"rn" + "Job Name :"    + "tt" + $servername +
"rn" + "Error:"     + "tt" + $Exception + "rn ******************** rn"
        Write-Host " ERROR: Cannot BULK Insert Jobs History To [tempdb] in $MainServer `r`n $FunctionError"
        Add-Content -Path $Logfile -Value " ERROR : Cannot BULK Insert Jobs History To [tempdb] in $MainServer `r`n $FunctionError `r`n $FunctionError"
        Break;
    }

 I'm getting the below error:
[17:05:04][Copy-ServerJobsHistory] Failed to bulk import to [tempdb].[dbo].[TmpTable_BFCSQL2-PIVOT.corp.colas.com_Job_History] | L'objet doit implémenter IConvertible.
After some checks It seems the error is comming from the[Duration] timevalue. Actually, the table created by the command has below column type :
[Job_ID] nvarchar NULL,
[Server_Name] nvarchar NULL,
[Run_Status] [int] NULL,
[Run_DateTime] [datetime2] NULL,
[Duration] nvarchar  NULL
`
And we can clearly see that the [Duration] type is not the same anymore.
For the moment I have a work around, as I'm creating the table before hand.
However, can this issue be corrected ?
I've also done some code checks to help and I think that the issue should quickly be resolved by changing the key/value table $PStoSQLTypes and set the line 'TimeSpan'              = 'nvarchar(30)'; as 'TimeSpan'              = 'Time(7)';
Many Thanks.
Steps to Reproduce
As described in  the previous session.

Create an array of TimeSpan values.
Call the command Write-DbaDbTableData as below

$array | Write-DbaDbTableData -SqlInstance $MainServer -Database tempdb -Table $TempTableName -AutoCreateTable -EnableException

Are you running the latest release?
Yes
Other details or mentions
No response
What PowerShell host was used when producing this error
PowerShell Core (pwsh.exe), Windows PowerShell (powershell.exe), Windows PowerShell ISE (powershell_ise.exe)
PowerShell Host Version
Name                           Value

PSVersion                      5.1.17763.2183
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17763.2183
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
SQL Server Edition and Build number
Microsoft SQL Server 2016 (SP2) (KB4052908) - 13.0.5026.0 (X64)   Mar 18 2018 09:11:49   Copyright (c) Microsoft Corporation  Standard Edition (64-bit) on Windows Server 2016 Standard 10.0  (Build 14393: ) (Hypervisor)
.NET Framework Version
.NET Framework 4.7.3740.0

hum, .net timespan can also be GREATER than 24 hours, which is the max value for time(7), hence not the correct type.
You'd be much better off extracting starttime and doing a dateadd to it with the duration to extract the "endtime", so you can account for durations greater than 24 hours

hmmmm I fully understand your point.
But for me it is ok if I could import the data as nvarchar to the SQL server database ....
The problem is that SQL Server is refusing the match TimeSpan<==>NVarChar ....
Also many be I'm wong in my analysis and that the error is not linked to this ...
Can you please double check :D
[17:05:04][Copy-ServerJobsHistory] Failed to bulk import to [tempdb].[dbo].[TmpTable_BFCSQL2-PIVOT.corp.colas.com_Job_History] | L'objet doit implémenter IConvertible.
`

The -AutoCreateTable feature is not meant to be perfect but only a quick option for typical cases. If you want to improve it, feel free to code that and open a pull request.
So I will close this for now, but we can reopen and label it as a feature request if you want to work on that.


Update Composer dependencies (2024-03-15-00-17)

Visual regression test passed!
View the visual regression test report


no-any: remove fixer, amend error message

PR checklist

[x] Addresses an existing issue: #2491
[x] New feature, bugfix, or enhancement

[x] Includes tests

[ ] Documentation update - was never documented

Overview of change:
Removes the fixer and amends the error message as suggested in #2491
Fixes: #2491
Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:
[bugfix] removed fixer of no-any

Yes thanks you!  This makes this rule a lot less susceptible to errors by uninformed developers that would run into this message.


Bootstrap discovery service regression

Since https://github.com/istio/istio/pull/40607, the bootstrap agent has a few issues:

https://github.com/istio/istio/pull/40607#discussion_r952831409 we retrying infinite loop with 0s backoff. Likely fix in https://github.com/istio/istio/pull/40643#pullrequestreview-1092353181
We no longer report errors properly. I had a bug in my own PR which made it fail in Send. While we send the error to sendToChannelWithoutBlock, this is never reported in logs at all

cc @hzxuzhonghu

Actually i am not sure if the error reporting is a regression or it has always been broken


Fix typo in comment

Signed-off-by: Guangwen Feng<EMAIL_ADDRESS>

Thanks. Would you mind to fix this one too in the same PR ?
https://github.com/metal3-io/cluster-api-provider-metal3/blob/f43c80935472ae7f3550ab62f9aedcee0cecb8c9/config/crd/bases/infrastructure.cluster.x-k8s.io_metal3datatemplates.yaml#L828
/ok-to-test

Thanks. Would you mind to fix this one too in the same PR ?
https://github.com/metal3-io/cluster-api-provider-metal3/blob/f43c80935472ae7f3550ab62f9aedcee0cecb8c9/config/crd/bases/infrastructure.cluster.x-k8s.io_metal3datatemplates.yaml#L828
/ok-to-test

You can run make generate-manifests to have the same fix on the manifest.

Sure, I have updated the PR, thanks for the review.

/test-integration
/lgtm

/cc @maelk

/cc @kashifest

/cc @kashifest

/approve

/approve


Make dialogue clone

Hi !
So a use case I've had is to get all the paths of a yarn program.
Mostly so I can read through them individually as if they're complete stories and fix any pacing issues or weirdness.
For that, I had in mind a recursive script thing in mind that would give me all the possible paths.
Problem is that it relies on cloning a dialogue.
The primary change is making TextProvider clone but it kinda fits in line with the current way we make variable storage clone

Hmmm, those errors in CI look spurious
error: trait `StrRefExt` is never used
   --> crates/core/src/types/type.rs:214:7
    |
214 | trait StrRefExt {
    |       ^^^^^^^^^

??

Makes sense to me! Sorry I took a while to answer.

No worries :) should be ready to go now


xplat: wmemset should return a value

wmemset implementation was missing return value. Trivial fix.

:+1:

@obastemur Thanks!


Failed to parse source map

Hi,
great component that is really to integrate in an existing application ! Thanks
But, anyway, a small problem when one is trying to build a Web application in React Native/Expo. I run the command npx expo export:web that builds the Web application with Webpack and I get some warning log:
Failed to parse source map from '/app/node_modules/autolinker/src/anchor-tag-builder.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/anchor-tag-builder.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/autolinker.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/autolinker.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/html-tag.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/html-tag.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/htmlParser/parse-html.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/htmlParser/parse-html.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/index.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/index.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/match/email-match.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/match/email-match.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/match/hashtag-match.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/match/hashtag-match.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/match/index.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/match/index.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/match/match.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/match/match.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/match/mention-match.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/match/mention-match.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/match/phone-match.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/match/phone-match.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/match/url-match.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/match/url-match.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/matcher/email-matcher.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/matcher/email-matcher.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/matcher/hashtag-matcher.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/matcher/hashtag-matcher.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/matcher/index.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/matcher/index.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/matcher/matcher.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/matcher/matcher.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/matcher/mention-matcher.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/matcher/mention-matcher.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/matcher/phone-matcher.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/matcher/phone-matcher.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/matcher/tld-regex.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/matcher/tld-regex.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/matcher/url-match-validator.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/matcher/url-match-validator.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/matcher/url-matcher.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/matcher/url-matcher.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/regex-lib.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/regex-lib.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/truncate/truncate-end.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/truncate/truncate-end.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/truncate/truncate-middle.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/truncate/truncate-middle.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/truncate/truncate-smart.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/truncate/truncate-smart.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/utils.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/utils.ts'

Failed to parse source map from '/app/node_modules/autolinker/src/version.ts' file: Error: ENOENT: no such file or directory, open '/app/node_modules/autolinker/src/version.ts'

Seems like something is amiss with your webpack config because those files definitely don't exist and I'm not sure why it's looking for them. The autolinker dependency in node_modules only has dist JS files (and some .d.ts).
Closing as this seems unrelated to this lib but happy to reopen if needed.

I am using the default Webpack configuration embedded into the Expo Web build and I did not changed anything. Probably that they ignore the .d.ts files and they expect to find only .ts files ... not sure about this. I will try to investigatye and if I find something I will keep you informed :slightly_smiling_face:

I just had a look in the Expo issues and I found https://github.com/expo/expo/issues/23296 that seems to be related with this problem :slightly_smiling_face:
Thanks


Installation page for Zig 0.13.0 still refers to Zig 0.12.0

In this page for installing Zig 0.13.0:
https://zig.guide/getting-started/installation
the text still refers to Zig 0.12.0, rather than Zig 0.13.0. For example,

Choose a build of Zig 0.12 for Linux that matches your CPU architecture. If you're unsure which architecture you're using, this can be found with:

Extract the archive using tar, e.g.
tar xf zig-linux-x86_64-0.12.0.tar.xz

Add the location of your Zig binary to your path, e.g.
echo 'export PATH="$HOME/zig-linux-x86_64-0.12.0:$PATH"' >> ~/.bashrc

Choose a build of Zig 0.12 for Windows that matches your CPU architecture. Most Windows systems use x86_64, also known as AMD64. If you're unsure which architecture you're using, this can be found with:

Verify your installation with zig version. The output should look like this:
$ zig version
0.12.0

These instances of 0.12 or 0.12.0 should all be replaced with 0.13 or 0.13.0.

fixed


Support for MongoDB in addition to PostgreSQL

Describe the bug
No bug, just additional feature request.  I would like the system to support MongoDB, in addition to PostgreSQL.
My expectation is that many would continue to want PostgreSQL.  But will chat with you about that.
Best, Garry

@gbinder2 It's been a bit, but we are starting work on adding support for NoSQL (mongo compatible API).  See the issue and linked PR here: https://github.com/open-amt-cloud-toolkit/mps/issues/1063

Released in MPS 2.12.0


Works with absurd-sql ?

Hello,
Does sqliteviz wwork with AbsurdSql

Sqliteviz uses sql-js which has a pr for adding absurd-sql functionality https://github.com/sql-js/sql.js/pull/481. Currently sqliteviz does not support it.


[SPARTA-622][WEB]: Geo parser cannot be configured from UI

Given a policy wizard
When I am creating a transformation
And I select 'geo parser' type
Then input field is not shown.
Given a policy wizard
When I am creating a transformation
And I select 'geo parser' type
And I add a new output field
Then I can only select 'String' as type.

default configuration appears:
{
  "latitude": "lat",
  "longitude": "long",
  "inputFormat": "unixMillis"
}

should be:
{
  "latitude": "lat",
  "longitude": "long"
}

Still happening.
First time appears properly but going to another type and going back to the GeoParser it is wrong

+1

Output Fields box is not disabled when the user tries to edit it.

:shipit:

Comment accepted. Will treat it ASAP


Time Entry for a common task on behalf of other participants

Suggesting a nice-to-have feature -> Its better If a team member is allowed to log time entry for a common task(say, a meeting) on behalf of rest of the participants while entering time for himself.
Don't you think this is gonna be an awesome feature after all? ;)

@udariv This is a great idea. What if some of the teammates have already entered time for that task? That would give extra trouble for those teammates if you also report time on behalf of them, yeah?

In that case, why don't we indicate the person that someone is trying to help him/her in logging the time? may be by an email notification as a request?  There, we can give an option to accept or reject the time log request and based on his/her action we can decide whether to actually log the time in Jira.
What do you think?


mobile: Add debug logging in the Swift tests

This PR adds debug logging in the Swift tests to make debugging test failures easier.
Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

/assign @abeyad

/retest

/retest

/retest

@abeyad this is now ready for review.


Build release & sign only on merge / release / release PR

Fixes #982 plus slight reorg, see comments

Nice!


go-dqlite: init at 1.7.0

Motivation for this change
Add go-dqlite, which includes a binary for interfacing with dqlite clusters.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I've used the dqlite-demo for the Jepsen test mentioned here: https://github.com/canonical/dqlite/issues/258, so I'm pretty confident that this works.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/265

builds, runs, and functions as expected on NixOS.

Closing due to OP not responding to reviews, and deleting their branch.


Change log level from error to warning of media_player.plex

Description:
Workaround, to avoid filling log with error when Plex server is down
Related issue (if applicable): fixes #16653
Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

What's the problem with Travis ???


Dark mode and prefers-color-scheme

It would be nice having a dark mode. Using prefers-color-scheme, there would be no need on a button to toggle or anything like that, making this just dependent on providing dark variants for colours.

+1000 !!!

Yes it would be nice, but unfortunately I do not plan to add this feature.
It will need to be added in a PR from the community.

+1000 !!!

I will probably implement this feature, but I won't be making a custom color profile.


Added Columnar Cipher in Java

Columnar Cipher used in networking with encryption and decryption added.

@bhaveshlohana
can you add 'hacktoberfest-accepted' label to this PR?


I want to disable log file generation.

What method should I use?

That might be what you're looking for. In config.ini

The file "fixivutil.log" will eventually be created even though you have tried each of these settings.

Then I don't think It can be disabled in settings. Next best thing is disable it in the source code

Is it possible to add this function?

Try this workaround and see if it does it. Open PixivHelper.py in an editor. Add logging.disable() in line 40.
find def get_logger and replace it with this.
def get_logger(level=logging.DEBUG):
    '''Set up logging'''
    global logger
    if logger is None:
        script_path = module_path()
        logger = logging.getLogger('PixivUtil' + PixivConstant.PIXIVUTIL_VERSION)
        logger.setLevel(level)
        # __logHandler__ = logging.handlers.RotatingFileHandler(script_path + os.sep + PixivConstant.PIXIVUTIL_LOG_FILE,
        #                                                       maxBytes=PixivConstant.PIXIVUTIL_LOG_SIZE,
        #                                                       backupCount=PixivConstant.PIXIVUTIL_LOG_COUNT,
        #                                                       encoding="utf-8")
        __formatter__ = logging.Formatter(PixivConstant.PIXIVUTIL_LOG_FORMAT)
        # __logHandler__.setFormatter(__formatter__)
        # logger.addHandler(__logHandler__)
    return logger


Convert to shared does not get rid of password - account can still be logged in to

We've discovered that mailboxes converted to a shared mailbox still allow the original user/pass to gain access to the account, at a minimum, for SMTP relay. This is even when the license has been removed after being converted.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58fb81a0-5744-18b2-1636-a41c771ef0db
Version Independent ID: fad4cd45-1a93-bfee-e82b-892752317056
Content: Convert a user mailbox to a shared mailbox
Content Source: Office365-Admin/email/convert-user-mailbox-to-shared-mailbox.md
Service: o365-administration
GitHub Login: @dianef77
Microsoft Alias: dianef

I've checked this on the field, and actually it works.
the old user can log in using the regular credentials and is even being used to avoid to get licenses for some customers.

@Toasty66 - Thank you for submitting feedback. It seems you are asking to open a service ticket or have a question about support.
I think the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP. Based on outcome let me know if it is something that can be called out in the docs.
Please follow this link contact support for business products: https://docs.microsoft.com/office365/admin/contact-support-for-business-products
If you don't mind please keep us posted here on the resolution and I really want to get this information you are discovering back into the docs.
NOTE:  We used to use this link to a video explaining how to open a support ticket.
Here is a quick video on opening a ticket: https://www.youtube.com/watch?v=puuOy0sEg1Y

@AndreaBarr - This issue can be closed. Thank you.


Service Unavailable

Hi,
after installing mizu binary I run:
mizu tap ".*" -A
I can see the list of pods being tapped in the terminal.
I get:
Mizu is available at http://localhost:8899/mizu
However when I try to open that I get:
`{
"kind": "Status",
"apiVersion": "v1",
"metadata": {
},
"status": "Failure",
"message": "error trying to reach service: dial tcp <IP_ADDRESS>:8899: i/o timeout",
"reason": "ServiceUnavailable",
"code": 503
}
`
kubectl is correctly working on my box.
I can also see the temporary mizu-collector pod running in the cluster.
Is it a port forward issue?

I've also added mizu roles using this manifest file
examples/roles/permissions-all-namespaces.yaml
I'm experiencing same issue though.

Last log line from the mizu-collector pod is:
2021-07-30T14:16:28Z INFO : Websocket Connection event - Tapper connected: PoLQpd5knkGjzEky5D6YzNkOabMOMoEmIyTBxGIZvz8p3GhBwppv8NRmXtD8BHb023I4SKGc2WDQV5v2dlVmnrYE3iFTY1c7V0Pe

Hi @fabfianda,
Thanks for reaching out.
What version of Mizu do you use? In latest stable release we use proxy instead of port forward.
It might be a bug that the proxy not ready yet, can you try to reload the page after few seconds/a minute.
BTW You are welcome to join our public slack channel at the following link:
https://join.slack.com/t/up9/shared_invite/zt-tfjnduli-QzlR8VV4Z1w3YnPIAJfhlQ

I'm using the one you get from the homepage.
Even a few minutes it still claims service is Unavailable

Can you check that kubectl proxy works for you?
https://kubernetes.io/docs/tasks/extend-kubernetes/http-proxy-access-api/

Yes, it loads and works as expected

I've just tried version 0.7.26 and the response is same:

kind
"Status"

apiVersion
"v1"

metadata
{}

status
"Failure"

message
"error trying to reach service: dial tcp <IP_ADDRESS>:8899: i/o timeout"

reason
"ServiceUnavailable"

code
503

More information:
proxy launched by mizu works as expected too:
so if I open http://localhost:8899/ while mizu is running I can see the k8s proxy response (with list of endpoints)

endpoints created on k8s seem good too
mizu-api-server   mizu   <IP_ADDRESS>:8899

Thank you for the additional info @fabfianda
The proxy seems to work fine, the next thing to check is the web socket. The "CLI" opens a web socket to the "Agent" on "ws://localhost:8899/mizu/ws" I suspect it fails to connect. It should be written in the logs. Can you please share here the logs from "mizu-collector" pod, and the CLI Stderr log?

Update: tried with other clusters and it seems to work as intended. So the issue is currently limited to a single K8s cluster. I'll try and provide more information.

Thanks for the heads-up! We are planing to release a new stable version on Sunday, which has many fixes. It might solve your issue as well.
If not, you will be able to run it with 'dump-logs' option mizu tap ".*" --set dump-logs=true - which will store the logs from cli and k8s nodes to a zip file which you can share here.

Hi @fabfianda, we have a new Mizu version: 0.10.0 which contains several fixes and new features. You can run it agains your cluster which earlier version had issues with.
If it still not working please run Mizu with dump-logs option (mizu tap --set dump-logs=true) and upload the zip file created at the end of the execution with all logs to the issue.

@fabfianda hope both of the clusters work for you with the new version. I am closing this issue because of inactivity, you are more then welcome to open a new one if you have any additional issues


Upstream patch for opi BPM

Ties to https://github.com/cloudfoundry-community/eirini-bosh-release/pull/69.
Part of the effort to upstream patches we currently have on kubecf - https://github.com/SUSE/kubecf/issues/12.

@jimmykarily how hard would it be to get this in the eirini BOSH release?

@f0rmiga if that gets merged, wouldn't we remove the patch altogether?

@viovanov Yes. In any case, I wanted to have this merged here so we don't get confused about differences in what we have in the patch and what we have upstream as a PR.

The eirini bosh relese is becoming obsolete because of #651


TypeError: converter is not a function

Sorry this is mistakenly open issue.

Try to revert to a previous version https://github.com/beatgammit/node-coordinator/issues/8#issuecomment-266175225


fix: remove verbose log

Fixes #1322

IMO it should be noisy so that the user updates their package to the latest version, even if it's a patch version. Sorry, but I'll block this until @digorithm gives his thoughts, because this PR removes patch mismatch warnings altogether.
In the meantime, could you share with us the noisy logs and how they look?

Thanks @nedsalk, this is a thoughtful remark. However, patch versions in all repos maintained by Fuel Labs are supposed to be backward compatible, meaning: no breaking changes whatsoever. So a change from 0.x.1 to 0.x.2 should never cause any issue. Given that that's a thing, it doesn't make much sense for us to be noisy about it.


Bad Expires Header

Describe the bug
After a while running on 0.2.4 I see:
I/flutter (22581): Contact: <sip:87583pl2@b82666150434.invalid;transport=ws>;+sip.ice;reg-id=1;+sip.instance="<urn:uuid:0cd08581-fdc2-47ca-8665-e75ee84b7ad1>";expires=600
I/flutter (22581): Expires: 600
I/flutter (22581): Contact: <sip:87583pl2@b82666150434.invalid;transport=ws>;+sip.ice;reg-id=1;+sip.instance="<urn:uuid:0cd08581-fdc2-47ca-8665-e75ee84b7ad1>";expires=600
I/flutter (22581): Expires: 600
I/flutter (22581): Contact: <sip:87583pl2@b82666150434.invalid;transport=ws>;+sip.ice;reg-id=1;+sip.instance="<urn:uuid:0cd08581-fdc2-47ca-8665-e75ee84b7ad1>";expires=600
I/flutter (22581): Expires: 600

To Reproduce
This is on my own app, but will check on example app.
Expected behavior
No duplicates.
System Infomation()
[✓] Flutter (Channel stable, 1.20.2, on Linux, locale en_GB.UTF-8)
    • Flutter version 1.20.2 at /home/ghenry/development/flutter
    • Framework revision bbfbf1770c (3 weeks ago), 2020-08-13 08:33:09 -0700
    • Engine revision 9d5b21729f
    • Dart version 2.9.1

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /home/ghenry/Android/Sdk
    • Platform android-30, build-tools 28.0.3
    • Java binary at: /home/ghenry/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/192.6392135/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Android Studio (version 3.6)
    • Android Studio at /home/ghenry/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/192.6392135
    • Flutter plugin version 37.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.48.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.2.0

[✓] Connected device (1 available)
    • SM (mobile) • android-arm64 • Android 10 (API 29)

Same when registering to tryit.jssip:
I/flutter (22696): REGISTER sip:tryit.jssip.net SIP/2.0
I/flutter (22696): Via: SIP/2.0/WSS ifv6181l7iox.invalid;branch=z9hG4bK285808995
I/flutter (22696): Max-Forwards: 69
I/flutter (22696): To<EMAIL_ADDRESS>I/flutter (22696): From: "Flutter SIP UA" <sip:hello_flutter@tryit.jssip.net>;tag=3163l666b5
I/flutter (22696): Call-ID: t0d70nbsierkqadcvtcptp
I/flutter (22696): CSeq: 1 REGISTER
I/flutter (22696): Contact: <sip:43uwp44j@ifv6181l7iox.invalid;transport=ws>;+sip.ice;reg-id=1;+sip.instance="<urn:uuid:7c7b679d-aba2-4283-a5b9-984670502db1>";expires=600
I/flutter (22696): Expires: 600
I/flutter (22696): Allow: INVITE,ACK,CANCEL,BYE,UPDATE,MESSAGE,OPTIONS,REFER,INFO
I/flutter (22696): Supported: path,gruu,outbound
I/flutter (22696): User-Agent: Dart SIP Client v1.0.0
I/flutter (22696): Content-Length: 0
I/flutter (22696):
I/flutter (22696): [2020-09-01 20:34:10.434] Level.debug websocket_interface.dart:171 ::: Received WebSocket message
I/flutter (22696): [2020-09-01 20:34:10.440] Level.debug transport.dart:314 ::: received text message:
I/flutter (22696):
I/flutter (22696): SIP/2.0 200 OK
I/flutter (22696): Via: SIP/2.0/WSS ifv6181l7iox.invalid;branch=z9hG4bK285808995
I/flutter (22696): To: <sip:hello_flutter@tryit.jssip.net>;tag=ebec76fc69a1b64d3ac8a167a40d8ff6.7e10
I/flutter (22696): From: "Flutter SIP UA" <sip:hello_flutter@tryit.jssip.net>;tag=3163l666b5
I/flutter (22696): Call-ID: t0d70nbsierkqadcvtcptp
I/flutter (22696): CSeq: 1 REGISTER
I/flutter (22696): Contact: <sip:3ehcu5wo@184400153305.invalid;transport=ws>;expires=479;pub-gruu="sip:hello_flutter@tryit.jssip.net;gr=urn:uuid:429b68c5-ab8b-4a5d-baf5-c8e66d4c0b5a";temp-gruu="sip:uloc-5f1ee42f-5c6-c0a1-067e3044@tryit.jssip.net;gr";+sip.instance="<urn:uuid:429b68c5-ab8b-4a5d-baf5-c8e66d4c0b5a>";reg-id=1
I/flutter (22696): Contact: <sip:i0uqr765@qypv445t3beu.invalid;transport=ws>;expires=599;pub-gruu="sip:hello_flutter@tryit.jssip.net;gr=urn:uuid:ef1c9d18-ad03-4c9b-947e-43d5112b1eaa";temp-gruu="sip:uloc-5f1ee42f-5c5-d0a1-067e3044@tryit.jssip.net;gr";+sip.instance="<urn:uuid:ef1c9d18-ad03-4c9b-947e-43d5112b1eaa>";reg-id=1
I/flutter (22696): Contact<EMAIL_ADDRESS>
what's changed recently?

Here's a full fresh trace from clicking register with nothing entered on the example app:
I/flutter (23559): [2020-09-01 20:38:11.693] Level.debug websocket_interface.dart:37 ::: new() [url:wss://tryit.jssip.net:10443]
I/flutter (23559): [2020-09-01 20:38:11.980] Level.debug websocket_interface.dart:50 ::: SIP URI: sip:tryit.jssip.net:10443;transport=wss
I/flutter (23559): [2020-09-01 20:38:11.994] Level.debug ua.dart:103 ::: new() [configuration:Instance of 'Settings']
I/flutter (23559): [2020-09-01 20:38:12.17] Level.info config.dart:244 ::: Check mandatory parameter => sockets.
I/flutter (23559): [2020-09-01 20:38:12.93] Level.info config.dart:244 ::: Check mandatory parameter => uri.
I/flutter (23559): [2020-09-01 20:38:12.112] Level.debug config.dart:250 ::: Check optional parameter => authorization_user.
I/flutter (23559): [2020-09-01 20:38:12.123] Level.debug config.dart:250 ::: Check optional parameter => user_agent.
I/flutter (23559): [2020-09-01 20:38:12.133] Level.debug config.dart:250 ::: Check optional parameter => connection_recovery_max_interval.
I/flutter (23559): [2020-09-01 20:38:12.145] Level.debug config.dart:250 ::: Check optional parameter => connection_recovery_min_interval.
I/flutter (23559): [2020-09-01 20:38:12.156] Level.debug config.dart:250 ::: Check optional parameter => contact_uri.
I/flutter (23559): [2020-09-01 20:38:12.166] Level.debug config.dart:250 ::: Check optional parameter => display_name.
I/flutter (23559): [2020-09-01 20:38:12.177] Level.debug config.dart:250 ::: Check optional parameter => instance_id.
I/flutter (23559): [2020-09-01 20:38:12.188] Level.debug config.dart:250 ::: Check optional parameter => no_answer_timeout.
I/flutter (23559): [2020-09-01 20:38:12.205] Level.debug config.dart:250 ::: Check optional parameter => session_timers.
I/flutter (23559): [2020-09-01 20:38:12.217] Level.debug config.dart:250 ::: Check optional parameter => session_timers_refresh_method.
I/flutter (23559): [2020-09-01 20:38:12.228] Level.debug config.dart:250 ::: Check optional parameter => password.
I/flutter (23559): [2020-09-01 20:38:12.238] Level.debug config.dart:250 ::: Check optional parameter => realm.
I/flutter (23559): [2020-09-01 20:38:12.249] Level.debug config.dart:250 ::: Check optional parameter => ha1.
I/flutter (23559): [2020-09-01 20:38:12.259] Level.debug config.dart:250 ::: Check optional parameter => register.
I/flutter (23559): [2020-09-01 20:38:12.268] Level.debug config.dart:250 ::: Check optional parameter => register_expires.
I/flutter (23559): [2020-09-01 20:38:12.277] Level.debug config.dart:250 ::: Check optional parameter => registrar_server.
I/flutter (23559): [2020-09-01 20:38:12.285] Level.debug config.dart:250 ::: Check optional parameter => use_preloaded_route.

I/flutter (23559): [2020-09-01 20:38:13.40] Level.debug websocket_interface.dart:89 ::: Web Socket is now connected
I/flutter (23559): [2020-09-01 20:38:13.45] Level.debug websocket_interface.dart:158 ::: WebSocket wss://tryit.jssip.net:10443 connected
I/flutter (23559): [2020-09-01 20:38:13.52] Level.debug ua.dart:851 ::: Transport connected
I/flutter (23559): [2020-09-01 20:38:13.59] Level.debug sip_ua_helper.dart:116 ::: connected => Instance of 'EventSocketConnected'
I/flutter (23559): [2020-09-01 20:38:13.72] Level.warning registrator.dart:120 ::: <sip:603w8w66@kcrysoas6xfm.invalid;transport=ws>;+sip.ice;reg-id=1;+sip.instance="<urn:uuid:fd8565df-bbbf-4db8-9a76-3e42cea6e837>"
I/flutter (23559): [2020-09-01 20:38:13.124] Level.debug transport.dart:167 ::: send()
I/flutter (23559): [2020-09-01 20:38:13.134] Level.debug websocket_interface.dart:133 ::: send()
I/flutter (23559): [2020-09-01 20:38:13.167] Level.debug websocket_dart_impl.dart:51 ::: send:
I/flutter (23559):
I/flutter (23559): REGISTER sip:tryit.jssip.net SIP/2.0
I/flutter (23559): Via: SIP/2.0/WSS kcrysoas6xfm.invalid;branch=z9hG4bK745301011
I/flutter (23559): Max-Forwards: 69
I/flutter (23559): To<EMAIL_ADDRESS>I/flutter (23559): From: "Flutter SIP UA" <sip:hello_flutter@tryit.jssip.net>;tag=00e075wa5u
I/flutter (23559): Call-ID: chufytertiiecmrkp6wssg
I/flutter (23559): CSeq: 1 REGISTER
I/flutter (23559): Contact: <sip:603w8w66@kcrysoas6xfm.invalid;transport=ws>;+sip.ice;reg-id=1;+sip.instance="<urn:uuid:fd8565df-bbbf-4db8-9a76-3e42cea6e837>";expires=600
I/flutter (23559): Expires: 600
I/flutter (23559): Allow: INVITE,ACK,CANCEL,BYE,UPDATE,MESSAGE,OPTIONS,REFER,INFO
I/flutter (23559): Supported: path,gruu,outbound
I/flutter (23559): User-Agent: Dart SIP Client v1.0.0
I/flutter (23559): Content-Length: 0
I/flutter (23559):
I/flutter (23559): [2020-09-01 20:38:13.238] Level.debug websocket_interface.dart:171 ::: Received WebSocket message
I/flutter (23559): [2020-09-01 20:38:13.246] Level.debug transport.dart:314 ::: received text message:
I/flutter (23559):
I/flutter (23559): SIP/2.0 200 OK
I/flutter (23559): Via: SIP/2.0/WSS kcrysoas6xfm.invalid;branch=z9hG4bK745301011
I/flutter (23559): To: <sip:hello_flutter@tryit.jssip.net>;tag=ebec76fc69a1b64d3ac8a167a40d8ff6.1bbd
I/flutter (23559): From: "Flutter SIP UA" <sip:hello_flutter@tryit.jssip.net>;tag=00e075wa5u
I/flutter (23559): Call-ID: chufytertiiecmrkp6wssg
I/flutter (23559): CSeq: 1 REGISTER
I/flutter (23559): Contact: <sip:3ehcu5wo@184400153305.invalid;transport=ws>;expires=236;pub-gruu="sip:hello_flutter@tryit.jssip.net;gr=urn:uuid:429b68c5-ab8b-4a5d-baf5-c8e66d4c0b5a";temp-gruu="sip:uloc-5f1ee42f-5c6-c0a1-067e3044@tryit.jssip.net;gr";+sip.instance="<urn:uuid:429b68c5-ab8b-4a5d-baf5-c8e66d4c0b5a>";reg-id=1
I/flutter (23559): Contact: <sip:603w8w66@kcrysoas6xfm.invalid;transport=ws>;expires=600;pub-gruu="sip:hello_flutter@tryit.jssip.net;gr=urn:uuid:fd8565df-bbbf-4db8-9a76-3e42cea6e837";temp-gruu="sip:uloc-5f1ee42f-5c5-f0a1-067e3044@tryit.jssip.net;gr";+sip.instance="<urn:uuid:fd8565df-bbbf-4db8-9a76-3e42cea6e837>";reg-id=1
I/flutter (23559): Path: <sip:<IP_ADDRESS>:7060;transport=u
I/flutter (23559): [2020-09-01 20:38:13.577] Level.debug sip_ua_helper.dart:129 ::: registered => Code: [200], Cause: registered, Reason: OK

Maybe because it's seeing multiple registerations from this user and adding those Contacts. I'll check the spec.

Yeah, that's alright in a 200 OK with multiple Contact headers.

This is something on our SIP proxy side in dev env. Closing.

I've been reviewing our SIP Proxy config (OpenSIPS 3.1) which is new because we're using RFC8599 and the OpenSIPS team states:

It seems the Dart UA has a tendency to "accumulate" Contacts and Expires headers in its subsequent registration requests.  Or, precisely: for each re-registration request, Dart simply re-appends the same Contact header and the same "Expires: 600" header.
Since the mid-registrar performs no automatic cleanup of all those Expires headers (fun fact: OTOH, it does clean up all those duplicate Contacts!), the downstream element replies with "400 Bad Expires Header", since it detects more than 1 such header.

So looks like this is a issue in dart-sip-ua
Thanks.

So basically it's here as we are appending to the extraHeaders array:
    var extraHeaders = _extraHeaders ?? [];

    extraHeaders.add(
        'Contact: ${this._contact};expires=${this._expires}${this._extraContactParams}');
    extraHeaders.add('Expires: ${this._expires}');

on a RE-REGISTER, we're adding more Contacts and Expires.

But it looks like this was meant to be?
https://github.com/cloudwebrtc/dart-sip-ua/commit/16c40d0adfc25d3fc78e7601abb3fb6f25f9f1d7#diff-31533826f9ed31563257c2abedeba5b5

How is List.from different as you're still adding more Expires headers?

var extraHeaders = _extraHeaders ?? []; will directly refer to the pointer, new data will be added to _extraHeaders, and List.from(...) will use a copy of _extraHeaders ?? [].

Ah, that makes sense. Thanks for explaining.
On Sun, 6 Sep 2020, 11:22 CloudWebRTC<EMAIL_ADDRESS>wrote:

var extraHeaders = _extraHeaders ?? []; will directly refer to the
pointer, new data will be added to _extraHeaders, and List.from(...) will
use a copy of _extraHeaders ?? [].
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/cloudwebrtc/dart-sip-ua/issues/115#issuecomment-687749224,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG66DUOK5JNCOIJTULGBLSENPG3ANCNFSM4QRW2HYQ
.

This has been working correctly all day now. You should do a new release :)
On Sun, 6 Sep 2020, 14:16 Gavin Henry<EMAIL_ADDRESS>wrote:

Ah, that makes sense. Thanks for explaining.
On Sun, 6 Sep 2020, 11:22 CloudWebRTC<EMAIL_ADDRESS>wrote:

var extraHeaders = _extraHeaders ?? []; will directly refer to the
pointer, new data will be added to _extraHeaders, and List.from(...)
will use a copy of _extraHeaders ?? [].
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/cloudwebrtc/dart-sip-ua/issues/115#issuecomment-687749224,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG66DUOK5JNCOIJTULGBLSENPG3ANCNFSM4QRW2HYQ
.


Terminate old sessions

When running pgweb in multi-session mode, there's no way to remove any old sessions. They will stick around for a long time until the server restarts. We should remove any sessions that have no activity within last 24 hours. There's already a timestamp implemented on the client struct that records the last usage time.

Implemented in master


Postgres?

How to add postgresql dsn?

Your environment variables are injected you can see them in the server scope. You manually build the dsn in the application.cfc.
I personally for ease would look at the Postgres config and break out into environment variables host,username, port and password. Then use these to build my dsn


Remove unused tbb/task.h include to avoid deprecation warnings

Signed-off-by: Edward Lam<EMAIL_ADDRESS>

@Idclip Note that it looks like from the build log, these warnings are still showing up in the explicit instantiation cases for some reason (eg. when compiling D:\a\openvdb\openvdb\build\openvdb\openvdb\instantiations\VolumeToSpheres.cc in the openvdb_static Windows build in the CI) . But I don't get these because it seems like we don't currently build with explicit instantiations. Or perhaps there's some other build difference. The motivation for this commit was to fix the warning we got when building the VDB SOPs themselves in the Houdini code.

@e4lam thanks for pointing that out - looks like they are still showing up in the regular CI builds too:
Windows Release (with EI): https://github.com/AcademySoftwareFoundation/openvdb/runs/4824722768?check_suite_focus=true
Windows Debug (without EI): https://github.com/AcademySoftwareFoundation/openvdb/runs/4824722777?check_suite_focus=true
I suspect it's being included by tbb itself...

@Idclip Ah I didn't look at the regular CI builds. We're also building with TBB 2020 U3 but I just noticed that we're a bit behind having only merged from upstream back in Nov 1 so maybe other things have changed since then.

@Idclip Ah yes, confirmed that something in upstream added these new warnings. If I build in our build system with upstream master instead, I'm now also seeing a lot more TBB Warnings.

PS. Also getting a build error now as well:
envdb\io\Archive.cc(1005,25): error C2065: 'OPENVDB_FILE_VERSION_HBOOST_UUID': u
ndeclared identifier

@Idclip It looks like we lost the changes in upstream master needed to suppress these warnings. Here's a comparison on Threading.h that we have compared to upstream master:
$ diff $HFS/custom/include/openvdb/thread/Threading.h Threading.h
11,16d10
< #ifndef __TBB_show_deprecation_message_task_H
<     #define __TBB_show_deprecation_message_task_H
<     #define OPENVDB_THREAD_THREADING_RESTORE_DEPRECATION_MESSAGE_TASK
< #endif
<
<
59,64d52
<
< #ifdef OPENVDB_THREAD_THREADING_RESTORE_DEPRECATION_MESSAGE_TASK
<     #undef __TBB_show_deprecation_message_task_H
<     #undef OPENVDB_THREAD_THREADING_RESTORE_DEPRECATION_MESSAGE_TASK
< #endif
<

Or perhaps we never managed to merge this commit upstream. :(

I've now issued PR #1290 for this.


Remove cookie and survey banners from guide

I have split this into a separate PR to https://github.com/alphagov/govuk_publishing_components/pull/61 so the Visual Diff Tool can be properly tested once this is merged.
This will allow the visual diff tool to correctly compare component guide pages without the banners adding noise to diff.

can we test this? I'm guessing not since static is not included in our tests?

Can we test for cookie headers?
If you visited the component guide then returned to government-frontend, presumably you'd still not see the survey?


glTF-Sample-Models AnimatedMorphSphere seems wrong

gltf_viewer -u -a opengl ../shallow/glTF-Sample-Models/2.0/AnimatedMorphSphere/glTF/AnimatedMorphSphere.gltf

at some point during the animation the sphere looks like the screenshot below:

surprisingly, this seems like it's WAI: https://github.com/KhronosGroup/glTF-Sample-Models/tree/main/2.0/AnimatedMorphSphere


feat: allow disabling loading screen

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[x] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Adds a cli option to disable the loading screen.

Resolves #6025
Checklist:

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[x] I have added tests to cover my changes (if not applicable, please state why)
[x] All new and existing tests are passing.

Codecov Report

Merging #6026 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #6026      +/-   ##
==========================================
+ Coverage   95.68%   95.68%   +<.01%
==========================================
  Files          82       82
  Lines        2689     2690       +1
  Branches      690      690
==========================================
+ Hits         2573     2574       +1
  Misses         98       98
  Partials       18       18

Flag
Coverage Δ

#e2e
100% <ø> (ø)
:arrow_up:

#fixtures
50.33% <50%> (-0.02%)
:arrow_down:

#unit
92.67% <100%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

packages/cli/src/options/common.js
100% <ø> (ø)
:arrow_up:

packages/cli/src/utils/config.js
93.93% <100%> (+0.18%)
:arrow_up:

packages/config/src/options.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac723e6...9bd84cf. Read the comment docs.

We also need to set next to https://github.com/nuxt/nuxt.js/blob/dev/packages/config/src/config/_app.js#L43
loadingScreen: true
Also, a test need to be added as well as docs.

Looking at the current documentation for cli I don't see any reasonable way to add it. Perhaps a change to the documentation is not required after all.

@pimlie Indeed there are reasons to test using development mode. Building and running takes more time and enables some unwanted features. If we must we will migrate to building and running but it's easier to just disable the loading screen. Doing it with a cli option seemed naturual. It would also be possible to create a special env variable for the tests and set the loadingScreen flag in nuxt config according to that. I'd like to see another opinion on that.

Since it's mostly for CI, could an environment variable do the trick?

This PR is in the wrong state. Adding an option to disable loading-screen module, makes sense but nuxt dev CLI is NOT meant to be used in CI/Testing environments. If performance is a real concern increase CI resources or disables optimizations like minify.
I think adding an option would be enough. You can create a custom build script that programmatically import Builder from @nuxt/builder and initiate build (with dev: true?) and start listening at any moment. This is not an official solution nor recommended or guaranteed to always work.

Should we then close this PR?

I still want it implemented. The new option is not yet documented, everything else has been changed as requested. Perhaps the option needs a better name but I can't think of one.

Still changes to cli are unnecessary as stated above. For building with special use cases, a custom script should work.

Changes to cli have been removed. The only change is a new option that changes when the dev server starts listening.

PR is conflicting (so commands/dev.js changes are remaining). I'll try to resolve.

@pimlie That was exactly what I did initially. Unfortunately there are issues with that approach. The loading screen is a module that can't be removed, you will run into serveral issues if you try doing that. I was really upset when I discovered that.
For my use case the loading screen itself is not even the issue. I thoght it was which is why I named this PR the way I did and tried removing the loading screen module etc. But what I really need is the server to start listening later, when the actual site is ready to be displayed. If it starts listening too soon requests to the site will just result in a timeout or reading the loading screen, both of these are not desireable. Even if I do start listening later the loading screen module can't be removed because the build indicatior still relies on it.
The timeout issue might be resolvable, haven't looked into it. Without the loading screen module the server started listening and requests made before build finished would hang for an infinite time. My pipeline has a 2 hour time limit which was exceeded. Requests get a response only after build has finished.

Actually, you can remove the loading screen with using a hook (that you can merge with your app config in the tests):
export default {
  hooks: {
    'modules:before': function (nuxt) {
      nuxt.options.devModules = nuxt.options.devModules.filter((name) => name !== '@nuxt/loading-screen')
    }
  }
}

You can also use the build:done hook to know when the build is done and you can start calling your application for e2e testing.
Also, you can also use nuxt.hook('build:done', () => ...) syntax.

I think I should just make a fresh new PR and close this. We are just not on the same page here.

Sure :)

Followed by #6272.

 https://github.com/nuxt/nuxt.js/pull/6272


Document how to use VS Code's component model tooling to use WASM services inside a VS Code extensions

With the component model tooling we now have an easy way to integrate WASM services into VS Code extensions. We should document this via samples and a blog post.

Hey @dbaeumer! We're interested in running some of our Kotlin code as WASM binaries in VSC.
Is this possible ATM? K/WASM requires GC.

Yes, stay tuned. There will be a blog post soon on how to do that. If the Kotlin code compiles to something that has only a main function (e.g. is more like a OS program) we have already support for it. See https://code.visualstudio.com/blogs/2023/06/05/vscode-wasm-wasi

Nice, thanks! We'd like to expose functions to the JS side. Or maybe interoperate with VS Code APIs directly.
Note sure of those options will be covered, but I'll check the blog post once it's out.

Both cases are covered.

Damn, VS Code on 🔥

The blog post is out: https://code.visualstudio.com/blogs/2024/05/08/wasm

Thanks @dbaeumer. Had a read already and everything makes sense.
Had my hopes too high for the "Full extension in Rust" part, but I guess waiting for the WASI spec is better (AFAIU 0.3 targets early/mid 2025).


Added update query to set flagged status to 1

Fixes #4713
Refs #4529
This will fix numbers in the dashboards, and local variables for the hot module.
This doesn't fix #4658

:+1:


Fix glyphlayout not being an Observable for LaTeXStrings

Description
I noticed that using latex strings as axis labels in Axis3 results in wrong, static rotations so I did some digging. It turns out that glyphcollection decides it no longer is an Observable after notify(plot.position) (it is before) but instead is the glyphcollection in the first lift. Removing the name collision fixes this.
Fixes #1417 as well.
Type of change
Bug fix (non-breaking change which fixes an issue)

Compile Times benchmark

Hm yeah I think we don't need the output tuple variable names at all, I just put them there to show the relationship to the output above it. The difference is that the lower function returns just one glyphlayout, so the missing s was intentional. Below, the code checks whether we're dealing with one or multiple glyphlayouts. It's not the cleanest logic to be sure


TCA 1.7.0 minimum version error iOS15

Description
After the TCA update from version 1.6 to 1.7 got the error:

The project has a minimum version iOS 15.
Checklist

[ ] I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
[X] If possible, I've reproduced the issue using the main branch of this package.
[X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior
No response
Actual behavior
No response
Steps to reproduce

Create a new project
Lower ios version to ios15
Add TCA dependency with exact version 1.7.0
Build

The Composable Architecture version information
1.7.0
Destination operating system
iOS 15
Xcode version information
Version 15.2 (15C500b)
Swift Compiler version information
swift-driver version: 1.87.3 Apple Swift version 5.9.2 (swiftlang-<IP_ADDRESS>.56 clang-15<IP_ADDRESS>.5)
Target: x86_64-apple-macosx14.0

Description says https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/observationbackport#Overview

With version 1.7 of the Composable Architecture we have introduced support for Swift 5.9’s observation tools, and we have backported those tools to work in iOS 13 and later. Using the observation tools in pre-iOS 17 does require a few additional steps and there are some gotchas to be aware of.

As I understood it should work out of the box.

I have the same problem. I have been using 1.7.0 version so far, but starting from yesterday the project is no longer possible to build.

Having the exact same issue at the moment and it's critical for us to figure it out since our CI and release train is currently on hold until this is figured out. I'm trying to figure out how to fix it / pin swift-perception to a specific version, but I'll update in a few minutes.

This made the trick https://github.com/pointfreeco/swift-composable-architecture/issues/3028#issuecomment-2083573439. I'm on TCA 1.8.0 and I pinned swift-perception to 1.1.1 and that worked perfectly fine.

Thanks @alejandro-honor-ed it works for me (added https://github.com/pointfreeco/swift-perception with fixed 1.1.5)

Should be fixed now
https://github.com/pointfreeco/swift-perception/releases/tag/1.1.7

This was also fixed version 1.10.1 of TCA, so you can fix by pinning to TCA 1.10.1 or swift-perception 1.1.7. Sorry for the churn! We tried fixing a problem that only affected people still on iOS 17.0.0 beta, and sadly it caused more problems than it solved.

@pm-dev The "exact" option in SPM should really only be used close the root of your application, ideally only the app target, and sparingly even then. It's just that "exact" dependencies make it very easy to run into un-resolvable dependency graphs, and so should be used with care, and only temporarily. So we would never want to do it in TCA.


cloudlist: 1.0.4 -> 1.0.6

Diff: https://github.com/projectdiscovery/cloudlist/compare/refs/tags/v1.0.4...v1.0.6
Changelog: https://github.com/projectdiscovery/cloudlist/releases/tag/v1.0.6
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


chore: release 2.2.0

:robot: I have created a release *beep* *boop*
2.2.0 (2021-11-21)
Features

application: Add a tutorial to start a new Telestion project (a3143d3)
docs/application: :sparkles: Add tutorial about using the JsonMessage inteface (29fdcb9)
docs/application: :sparkles: Add tutorial for adding configuration options to Verticles (f54a162)
docs/application: :sparkles: Fill out (i.e., actually write) the "Writing a Verticle" tutorial (405335f)
images: :bento: Add event bus bridge explanation diagram to assets (d9ff906)
images: :bento: Add event bus explanation diagram to assets (0ea91cc)
images: :bento: Add general Telestion structure overview diagram to assets (e2a1fcd)
stylesheet: :lipstick: Make it possible to center images (d505b2f)

Bug Fixes

docs/application: :bug: Add missing reference to Backend Tutorials overview page (dfc7694)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wuespace/telestion-docs/releases/tag/v2.2.0 :sunflower:


mobile: gomobile should sign with debug.keystore if exists

The apks should be signed with ~/.android/debug.keystore rather than the embedded certificate. We can fallback to the embedded certificate if there is no debug.keystore.

FYI, debug.keystore is in an undocumented Java format. There's a note here about it: https://github.com/golang/mobile/blob/master/cmd/gomobile/writer.go#L56

Why don't we shell out to keytool if user has SDK installed on their machine? If keytool is not on the PATH, we can fallback to the hardcoded key.
cc/ @hyangah

I have found the Android SDK does not put itself on the PATH, nor encourage users to set other environment variables. IDE-based projects expect to be used from inside IDEs. So how do you intend to find the tools on the average user's machine?
That said, keytool I believe is part of the JVM, not the Android SDK. It may well be common on the PATH of people with the SDK installed. (Or it may be inferable from some common Java environment variable.) So using it might well work, it just needs to be tried on a relatively light SDK setup.

keytool is a part of JDK. None of these details conflicts with my idea to fallback to the embedded key if we can't shell out and export. I would consider this as a workaround, we may recommend the user to have keytool in their PATH for debug.keystore support.

I'm OK with it if it is generally useful in the usual cases. That is, does the default install of Android Studio put keytool on the path on OS X, Linux, and Windows? Two out of three would be useful enough. If zero, it's not worthwhile. It's an empirical question.

I don't think Android Studio does anything with installation of keytool,
but Android Studio requires JDK, and JDK installation seems to place the
keytool in an easily discoverable place (e.g. /usr/bin in my case). The
default install of ubuntu doesn't seem to have it, but after apt-getting
open-jdk, i found it in /usr/bin. Given that the installation is not
painful, I think documentation mentioning the keytool is sufficient and
relying on keytool is okay.
2015-04-07 22:21 GMT-04:00 David Crawshaw<EMAIL_ADDRESS>
I'm OK with it if it is generally useful in the usual cases. That is, does
the default install of Android Studio put keytool on the path on OS X,
Linux, and Windows? Two out of three would be useful enough. If zero, it's
not worthwhile. It's an empirical question.
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/10090#issuecomment-90783258.

--
__

At what point in the documentation would this be mentioned? I'm trying to avoid "first, install java" as a development requirement for all-Go apps. (Because it will have to be followed with "second, uninstall the Ask toolbar".)

It should be mentioned in the lines of "if you already have a debug.keystore, we will use it" which already indicates that they have keytool on their machine. debug.keystore is generated by keytool. JDK is not a hard requirement, we will fallback to the embedded key.
You may argue that we should restrict the tool to the PEM keys. Apple distributes certificates as p12, the users will similarly need to convert them to PEM.

I am closing this issue in the favor of using a dummy key for development. We will introduce a flag to provide a PEM file for release builds. Or we might ask to user to provide the key from a known location such as ~/.gomobile/android.pem.
Both strategies seems to be applicable to the iOS release builds.


Add more description to main readme and multi-node readme

Add more description to readme for main and multi node to install golang 1.7.x and setting kubeconf for multinode vagrant install to setup kubeconf

@andrecolin Thanks for the PR. Maybe instead of 1.7.x, we can go straight with 1.8.x?
Btw, have you signed CLA?

This is rather outdated and didn't address the original review. Going to close, but feel free to open if you'd like to take on responsibility for it.


KV delete should allow wildcards

Overview
Since KV (ADR-8) can now have subjects with wildcards, it becomes very useful to implement delete to delete key sub-ranges
kv.delete("a.*").  This allows applications to easily cleanup values that may be "hierarchical" in nature without knowing the possible values that may be stored underneath.
The current behavior is to reject values with wildcards, but this is inconsistent with history and watches. Presumably, this is not in parity with get, but possibly the API could be expanded to do an mget which can deal with ranges without having to resort to doing consumers on the underlying stream.

We need https://github.com/nats-io/nats-server/issues/2495 to be done for this - sure we can do without but wont be efficient.
At the same time we should add a ranged get variant that returns []Entry or itterator of Entry (whatever works for a specific language)

The server work for https://github.com/nats-io/nats-server/issues/2495 was done ages ago, so in theory we can do this now.  Needs discussion.


[SPARK-31361][SQL][FOLLOWUP] Use LEGACY_PARQUET_REBASE_DATETIME_IN_READ instead of avro config in ParquetIOSuite

What changes were proposed in this pull request?
Replace the Avro SQL config LEGACY_AVRO_REBASE_DATETIME_IN_READ  by LEGACY_PARQUET_REBASE_DATETIME_IN_READ  in ParquetIOSuite.
Why are the changes needed?
Avro config is not relevant to the parquet tests.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running ParquetIOSuite via
./build/sbt "test:testOnly *ParquetIOSuite"

@cloud-fan @HyukjinKwon Minor fix for tests

Test build #122353 has started for PR 28461 at commit 2b5536a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27020/
Test PASSed.

Test build #122353 has finished for PR 28461 at commit 2b5536a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122353/
Test PASSed.

Merged to master and branch-3.0.


add option to request token via Launchpad

This change adds an option to use Launchpad for the creation of the Bearer token

Closed in favor of https://github.com/ghrcdaac/cumulus-api/pull/7


ESP-Modbus v2.0.0-beta Modubs TCP Slave crash restart (IDFGH-11927)

I need to run both Modbus RTU and Modbus TCP Slave on ESP32S3, I found ESP-Modbus v2.0.0-beta can meet my needs,
But when I tested examples\tcp\mb_tcp_slave again, there was this statement in the function static mb_event_group_t mbc_tcp_slave_check_event(void *ctx, mb_event_group_t group)
BaseType_t status = xEventGroupWaitBits(mbs_opts->event_group_handle, (BaseType_t)group, pdTRUE, pdFALSE, portMAX_DELAY); will cause ESP32S3 to crash and restart.
The error prompt is as follows
D (5852) mb_object.slave: created object mbs_tcp@0x3fcb1cc8
W (5852) mb_port.timer: mbs_tcp@0x3fcb1cc8, start timer (1000000).
W (5862) mb_object.slave: 0x3fcb1cc8:EV_READY
I (5912) SLAVE_TEST: Modbus slave stack initialized.
I (5912) SLAVE_TEST: Start modbus test...
ESP-ROM:esp32s3-20210327
Build:Mar 27 2021
rst:0x8 (TG1WDT_SYS_RST),boot:0x2b (SPI_FAST_FLASH_BOOT)
Saved PC:0x42002dbb
0x42002dbb: panic_handler at D:/esp32/esp-idf/components/esp_system/port/panic_handler.c:146
SPIWP:0xee
mode:DIO, clock div:1
load:0x3fce3810,len:0x178c
load:0x403c9700,len:0x4
load:0x403c9704,len:0xcb8
load:0x403cc700,len:0x2d98
entry 0x403c9914
I (31) boot: ESP-IDF v5.3-dev-1353-gb3f7e2c8a4 2nd stage bootloader
I (31) boot: compile time Jan 18 2024 15:37:04
How to solve this?

Hi @greentd,
Thank you for the issue. This happens because the port for Modbus TCP Slave is not implemented yet in v2.0.0. There are placeholders instead of real implementation. The implementation will be updated after completion of some other tasks. I will inform you as soon as it is ready.

Hi @greentd,
Thank you for the issue. This happens because the port for Modbus TCP Slave is not implemented yet in v2.0.0. There are placeholders instead of real implementation. The implementation will be updated after completion of some other tasks. I will inform you as soon as it is ready.

Looking forward to your updates!

Also waiting for this update :-)

Hi @greentd,  @fink-at-trmc-dk,
The esp-modbus v2.0.0-beta.1 component is released.
The updated version supports the multi-instance TCP Slave and Master with its own communication options. The pre-release esp-modbus component version 2.0.0-beta.1 can be selected by idf_component.yml in main folder like below:
dependencies:
  idf:
     version: ">=4.1.0"
  espressif/esp-modbus:
    version: "^2.0.0-beta"
  espressif/mdns:
    version: "^1.0.0"
    rules:
      - if: "idf_version >=5.0"
  mb_example_common:
    path: "../mb_example_common"
  protocol_examples_common:
    path: ${IDF_PATH}/examples/common_components/protocol_examples_common

The issue is closed, feel free to reopen if you have any issues.


idris2Packages.pack: init at 2024-02-07

Description of changes
Pack is the most popular package manager for Idris2. I’ve mostly focused on making it easier to package Idris2 programs as Nix derivations but there is definitely demand for using nixpkgs to install Pack and then using Pack to build Idris2 projects.

Things done
Result of nixpkgs-review run on x86_64-darwin 1

1 package built:

idris2Packages.pack

Result of nixpkgs-review run on x86_64-linux 1

1 package built:

idris2Packages.pack

Result of nixpkgs-review pr 344109 run on aarch64-darwin 1

1 package built:

idris2Packages.pack

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/1016/180

I have installed idris2Packages.pack and some more on NixOS 24.11:
gmp # GNU multiple precision arithmetic library
idris2 # A purely functional programming language with first class types
idris2Packages.idris2Api # Idris2 Compiler API Library
idris2Packages.idris2Lsp # Language Server for Idris2
idris2Packages.pack # An Idris2 Package Manager with Curated Package Collections

but I cannot update:
~ pack update
...
In file included from casts.c:1:
In file included from ./casts.h:3:
In file included from ./cBackend.h:8:
./_datatypes.h:3:10: fatal error: 'gmp.h' file not found
    3 | #include <gmp.h>
      |          ^~~~~~~
1 error generated.
make[2]: *** [<eingebaut>: casts.o] Fehler 1
[ build ] make[2]: Verzeichnis „/home/klt/.pack/.tmp0/idris2-compiler/support/refc“ wird verlassen
make[1]: *** [Makefile:11: build-refc] Fehler 2
[ build ] make[1]: Verzeichnis „/home/klt/.pack/.tmp0/idris2-compiler/support“ wird verlassen
make: *** [Makefile:176: /home/klt/.pack/.tmp0/idris2-compiler/support/c/libidris2_support.so] Fehler 2
[ fatal ] Error when executing system command.
          Command: "make" "support" "PREFIX=/home/klt/.pack/install/f840d1b771be59000b478780dcfc1dfa2bfde624/idris2" "SCHEME=scheme"
          Error code: 2

Where can I get gmp.h from?

@kaelte pack update is a self-update command. I haven’t thought on how we might support it because you cannot of course write to the location where nix installs pack so self updating feels out of scope for a nix installation of pack. I think if you want to use pack’s self update then there is no reason to install pack via nix since you aren’t managing the install via nix once you self update — pack can be installed on a nix machine using pack’s install instructions if you’d like it installed to the pack’s default location in your home folder where it supports self updating.


Allow markup language to be set in YAML rather than file extension

This recently came up (again) in the Markdown community. There is no standard markdown file extension. In fact, Markdown's creator (John Gruber) uses .text which offers no hint of what markup language is used. Sure, I can run my own instance of Jekyll with .text set to invoke the markdown parser, but why should I need to?
Every source file has a YAML section. Why can't that define the markup language used within? That way I can use whatever file extension I want.  Personally, I would like to see a default set in _config.yml which can be overridden on an individual basis in each files YAML section.  Of course, when neither is set, the current behavior should continue.

I use .md which is nice, short and to the point.


add no_std build test for verifier

We need a build test to ensure that the verifier code (risc0-zkvm crate with default-features = "false") can build with #![no_std].

Closed by #911


Create Hello_Ada_1.adb

Please format your PR according to the contribution guide.

I have changed the name according to the contribution guide. Please merge my pull request.

You changed the PR name but not the file name...


More editor refactor

It turns out™ the previous refactor is not good enough. With that, it is easier to make mistake that keep mounting/unmounting Map.ts. It is slow(need to initialize mapbox and deckgl) and also it doens't do clean up correctly.
I believe this PR does make things better. And now the only sad part is the Map.ts. but it is very hard to make mistake and other componets won't be affected.

I believe the CI is weird. We didn't change any server files in this PR and I'm pretty that import is not unused.

I believe the CI is acting weirdly. We didn't change any server files in this PR and I'm pretty that import is not unused.

Okay it is good, some sea packages updated. The build is not really deterministic because we don't commit Cargo.lock. But after checking rust manual, it seems a good practice for non lib project. (I don't fullly understand that. Especially we build the production binary separately)

I believe the CI is acting weirdly. We didn't change any server files in this PR and I'm pretty that import is not unused.

Okay it is good, some sea packages updated. The build is not really deterministic because we don't commit Cargo.lock. But after checking rust manual, it seems a good practice for non lib project. (I don't fullly understand that. Especially we build the production binary separately)

lol, I'm a idoit, I read the manual the wrong way. We should commit Cargo.lock for binary project, not for lib project. I'll add it soon.


Added PasswordCommandSystemTest

Pull Request Test Coverage Report for Build 175

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.094%

Totals

Change from base Build 166:
0.0%

Covered Lines:
1975

Relevant Lines:
2778

💛  - Coveralls


Remove add'l serialization on *schema

We previously sent schemas as strings to preserve key ordering.
The backend has been updated to accept maps on submit and the key ordering issue has been addressed.
Blocked on https://github.com/massdriver-cloud/massdriver/pull/1403

We'll want to double check this before publishing.


AttributeError: module 'jax.random' has no attribute 'KeyArray'

from diffusers.training_utils import set_seed
Report an error when encounter this line

Not sure why you're getting this. Please make sure that you are working with the correct libraries and versions.


Cannot compile

The prepare script does not run on windows.

After yarn install I run rollup -c which complains:

import meta from './package.json' assert { type: 'json' };
What does the assert mean ? After removing it the bundles were built.

@urbanhop perhaps it's related to your version of node. See this: https://stackoverflow.com/questions/60205891/import-json-extension-in-es6-node-js-throws-an-error


Cleanup configure_secret_token

Use Rails.application instead of the class Vmdb::Application.
Don't reset the token and secrets if the token is already set

Please review @matthewd @Fryguy

@Fryguy @matthewd Are you ok with this PR?


Target component

Hi there, thanks for the great library!
I want to attach a transitionend event to my component, but I want to avoid using React's synthetic event system because I need to know the specific time the real browser event occurred. For context, this is so I can measure the time between events with the User Timing API.
I have something like this:
      <EventListener
        target={this.transitionEl}
        onTransitionEnd={this.onTransitionEnd.bind(this)}
      >
        <div
          ref={(ref) => { this.transitionEl = ref; }}
        >
// …

This works, but I get a warning because, on the initial render, this.transitionEl is undefined (the ref hasn't been set yet).
Is this safe to do? Do you have any better recommendations?
Thanks!

I want to avoid using React's synthetic event system

Hey, thanks for raising that concern, that's an interesting use case!

This works, but I get a warning

The warning has been introduced with #31, we could revert.
I have been using a different solution on react-swipeable-view as we do with Material-UI.
I'm not sure what's the best answer is.

Is this safe to do?

Yes, it's.

Do you have any better recommendations?

You miss the event prefixes with that solution. I discovered it with https://github.com/react-bootstrap/dom-helpers/pull/19.
So I would recommend using an event prefixing tool.
Regarding improving the API for that use case. I have thought about adding a targetSetter property, that could be used like this:
<EventListener
  targetSetter={(setter) => this.targetSetter = setter}
  onTransitionEnd={this.onTransitionEnd.bind(this)}
>
  <div
    ref={(ref) => { this.targetSetter(ref) }}
  >
// ...

I'm not sure it's a good idea. What do you think?


Use 'gamemanagement' permission in mafia.js

The 'mafiamanagement' permission isn't a default permission defined in config/config-example.js and therefore the commands can only be used by groups having the 'root' permission (usually only administrators).

This is intentionally done because the mafia plugin isn't stable enough yet


Do not allow floats as memory value

https://bugzilla.redhat.com/show_bug.cgi?id=1710775
we should allow floats and different values than Gi for web-ui future versions

Pull Request Test Coverage Report for Build 1673

4 of 5 (80.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 83.982%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/utils/validations.js
4
5
80.0%

Totals

Change from base Build 1662:
-0.04%

Covered Lines:
3977

Relevant Lines:
4536

💛  - Coveralls

Pull Request Test Coverage Report for Build 1942

4 of 5 (80.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 83.982%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/utils/validations.js
4
5
80.0%

Totals

Change from base Build 1662:
-0.04%

Covered Lines:
3977

Relevant Lines:
4536

💛  - Coveralls

created issue for future releases https://github.com/kubevirt/web-ui-components/issues/479


Removed Ugly Scrolls

If you change the overflow element to auto it only shows up when it needs to. Now it looks a lot better

Add GIF

I've been meaning to fix this for so long, but since it doesn't happen on OS X (which our team all use on our school-issued computers), I never remembered. Thank you!

It's okay It just looked really bad on Linux and windows.
Sent from my Motorola Moto G (4) using FastHub

Yeah, I'm on Fedora at the moment and see what you mean.


Navigate between screens with Compose: Android Basics with Compose

Note: The quantityOptions property comes from calling collectAsState() in the line before the NavHost. Other properties from the view model will be accessed the same way.
It looks like it does not
It comes from DataSource.kt
quantityOptions  has nothing to do with the viewmodel

Hello @Maxmarra,
Thank you for reaching out to us and sharing your feedback. The text is updated by the Note message in the codelab:


[Feature]: add Logo

Describe the feature you want to add
add MyButton Logo to the project

OpenGraph Tags
README
anywhere suitable

Describe your proposed solution
No response
Describe alternatives you've considered, if relevant
No response
Additional context
No response

Hi dear Shahali, I think I've sent you the logo materials right? If I didn't, please let me know and If I did, let's go.

@F-Shahali Hi dear Shahali, I think I've sent you the logo materials right? If I didn't, please let me know and If I did, let's go.

Hi Mr. Rostami, yeah you're right. But this issue has been addressed and the related PR has been merged. Do I need to do anything else?

@F-Shahali Hi dear Shahali, I think I've sent you the logo materials right? If I didn't, please let me know and If I did, let's go.

Hi Mr. Rostami, yeah you're right. But this issue has been addressed and the related PR has been merged. Do I need to do anything else?

OK, great. So far so good.
Thanks for your prompt answer.

I linked this issue to the associated PR.
sometimes an issue is getting handled through more than one pull request, and it is better to mention each portion of enhancement in each PR's description (plus tagging the issue like #23), and finally in the last PR, it is better to add the associated issue in the development option of the last PR.

I linked this issue to the associated PR. sometimes an issue is getting handled through more than one pull request, and it is better to mention each portion of enhancement in each PR's description (plus tagging the issue like `#23`), and finally in the last PR, it is better to add the associated issue in the `development` option of the last PR.

OK, thanks for mentioning this point.


[FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

What is the purpose of the change
This pr is aims to introduce a new dynamic partition pruning strategy named FlinkDynamicPartitionPruningConverterProgram to instead of the old dpp rule DynamicPartitionPruningRule  to support more dpp patterns. Now, the old dpp rule is tightly coupled with the join reorder rules, which will affect the result of join reorder. At the same time, the dpp rule don't support these patterns like union node/ agg node in fact side、dim side is a sub-query etc. This pr will fix this two problem together.
Brief change log

Introduce a new dynamic partition pruning strategy named FlinkDynamicPartitionPruningConverterProgram to instead of the old dpp rule DynamicPartitionPruningRule.
Add more UT tests in FlinkDynamicPartitionPruningConverterProgramTest.

Verifying this change

Add more UT tests in FlinkDynamicPartitionPruningConverterProgramTest.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no docs

It's better we can add this optimization in flink-tpcds-test module, we can do it in another pr.

It's better we can add this optimization in flink-tpcds-test module, we can do it in another pr.
Ok. I will make a jira issue to track this work.


Minor issue: Extension logo invisible in dark mode

The current logo is black with transparent background. This makes it seem invisible in dark mode.
You could add a white circle behind the black tabs to make it work in dark or light mode.
Happy to fix it for you.

I've done a new version of the logo here:
https://thelab-my.sharepoint.com/:f:/g/personal/david_thelab_com_au/Epsses6bI1xOsmPyRRd8tzABGZeP7VCdvmpBSHecMPhJLg?e=RdXK0p
I also gave the + tab a bright blue background.. If you'd rather it was just white, let me know and I'll remove it.

Hello @solidifier, thank you for your contribution.
The issue is fixed by the PR #32.


Ternary two different types infers to one type when one is a subset of the other

Bug Report

🔎 Search Terms
ternary type union
Maybe related: https://github.com/microsoft/TypeScript/issues/33070, https://github.com/microsoft/TypeScript/issues/20863
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about https://github.com/microsoft/TypeScript/issues/31751, but that isn't really it I guess

⏯ Playground Link

Playground link with relevant code
💻 Code

type A = { a: number; b: string }
type B = { a: number }

const a: A = { a: 5, b: '' }
const b: B = { a: 10 }

// ab infers as B, should be A | B
const ab = Math.random() > 0.5 ? a : b

🙁 Actual behavior
ab infers to B
🙂 Expected behavior
ab should infer to A | B

@danielbartsch In that example the variable ab is still typed B, not A | B. Assigning a value to a variable narrows the type of the variable, and you're assigning a value of type B - so ab is of type B. This behaviour is intentional.
If you want to explicitly type it as A | B you can use a type assertion:
const ab: A | B = (Math.random() > 0.5 ? a : b) as A | B


calico-node cannot refresh expired serviceaccount token due to apiserver throttling

Expected Behavior
calico-node is able to refresh the serviceaccount token used by calico CNI
Current Behavior
AKS had a customer report the following errors from Calico CNI: "error getting ClusterInformation: connection is unauthorized: Unauthorized". The errors occurred consistently across multiple nodes for about 30 hours, then resolved without intervention. The cluster had 8 nodes at the time the incident occurred.
Upon investigation, we discovered that:

requests from calico-node to apiserver to create the serviceaccount token were failing due to a 429 response from apiserver. The errors in the calico-node logs looked like:

2023-05-06 05:25:29.092 [ERROR][87] cni-config-monitor/token_watch.go 131: Failed to update CNI token, retrying... error=the server was unable to return a response in the time allotted, but may still be processing the request (post serviceaccounts calico-node)

we observed that all of the 429 responses were coming from one pod of apiserver (out of six pods running)

apiserver was using API Priority and Fairness and classifying the requests from calico-node as workload-low

Possible Solution
I suspect this might be a new failure mode introduced by https://github.com/projectcalico/calico/pull/5910. In particular, when calico-node instances happen to connect to an overloaded apiserver replica and the CNI token expires, apiserver may throttle the requests to create a new serviceaccount token. This prevents the calico-node from refreshing the token, causing CNI failures.
Steps to Reproduce (for bugs)
I'm not sure how to reproduce this issue. We had a customer report the problem, and it resolved after ~30 hours without intervention.
Context
We had one customer report this issue running AKS-managed Calico.
Your Environment

Calico version v3.24.0
Orchestrator version (e.g. kubernetes, mesos, rkt): kubernetes 1.24.9
Operating System and version: Linux (Ubuntu 18.04)
Link to your project (optional):

Oooh, fun.
Sounds like one option here might be to configure FlowSchemas for Calico so that it's not lumped into the "workload-low" category, which is obviously not quite correct for a critical infrastructure component.
I'm not sure we can ship one of those by default in Calico, as it probably will vary by cluster configuration, but perhaps it's something we should add to our documentation.
As for code changes we might make, those are a bit less obvious. Maybe one of these?

Increase the validity period of our tokens so that we're less susceptible to transient errors like this.
Perhaps there is some timeout we can increase so that if the apiserver is burdened we wait a bit longer?

Sounds like one option here might be to configure FlowSchemas for Calico so that it's not lumped into the "workload-low" category, which is obviously not quite correct for a critical infrastructure component.
I'm not sure we can ship one of those by default in Calico, as it probably will vary by cluster configuration, but perhaps it's something we should add to our documentation.

That sounds like a reasonable solution. Agree that apiserver shouldn't be classifying requests from Calico as workload-low.

As for code changes we might make, those are a bit less obvious. Maybe one of these?

Increase the validity period of our tokens so that we're less susceptible to transient errors like this.
Perhaps there is some timeout we can increase so that if the apiserver is burdened we wait a bit longer?

There are some env vars in client-go that enable exponential backoff https://github.com/kubernetes/kubernetes/blob/3d27dee047a87527735bf74cfcc6b8ff8875f66c/staging/src/k8s.io/client-go/rest/client.go#L36-L37 I'm not completely sure it would have helped in this case, but might be worth exploring.


Switch to gRPC at Knative backend

Signed-off-by: Bora M. Alper<EMAIL_ADDRESS>

gRPC:
$ ./bin/word_count metamorphosis.txt
INFO[0000] Starting job0 (1/1)
Map 14 / 14 [=======================================================] 100.00% 0s
Reduce 1 / 1 [======================================================] 100.00% 0s
INFO[0000] Job 0 - Total Bytes Read:	838 kB
INFO[0000] Job 0 - Total Bytes Written:	29 kB
Job Execution Time: 138.027528ms

HTTP:
$ ./bin/word_count metamorphosis.txt
INFO[0000] Starting job0 (1/1)
Map 14 / 14 [=======================================================] 100.00% 0s
Reduce 1 / 1 [======================================================] 100.00% 0s
INFO[0000] Job 0 - Total Bytes Read:	838 kB
INFO[0000] Job 0 - Total Bytes Written:	29 kB
Job Execution Time: 93.899599ms

FYI


Translations update from Weblate

Translations update from Weblate for ephios/ephios.
Current translation status:

Coverage remained the same at 82.134% when pulling 087ba763df7937d024e515835cdc793bf0a9c1ef on translations into 0e1ebeca9828abc95ce1453579e7c2b41f191d75 on main.


feat: add ip detect config

Signed-off-by: lixd<EMAIL_ADDRESS>
What type of PR is this?

/kind feature
What this PR does / why we need it:
add kc-agent ip-detect method config.
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:
kcctl deploy / join add an ip-detect flag to config kc-agent's ip-detect method.
kc-agent read /etc/kubeclipper-agent/kubeclipper-agent.yaml file to get ip-detect method when need. such as install k8s, kc-agent will get the ip-detect method to find the current node's ip.

Does this PR introduced a user-facing change?

kcctl deploy / join add an ip-detect flag

Additional documentation, usage docs, etc.:

Codecov Report

Merging #71 (cfa13a0) into master (6e38bc5) will increase coverage by 0.39%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   11.35%   11.75%   +0.39%
==========================================
  Files          95       98       +3
  Lines       14725    14883     +158
==========================================
+ Hits         1672     1749      +77
- Misses      12832    12905      +73
- Partials      221      229       +8

Impacted Files
Coverage Δ

pkg/cli/join/join.go
0.00% <0.00%> (ø)

pkg/scheme/core/v1/k8s/cluster.go
0.12% <0.00%> (-0.01%)
:arrow_down:

pkg/scheme/core/v1/k8s/kubeadm.go
3.45% <0.00%> (-0.06%)
:arrow_down:

pkg/cli/deploy/deploy.go
16.20% <20.00%> (+0.05%)
:arrow_up:

pkg/utils/autodetection/method.go
36.53% <36.53%> (ø)

pkg/utils/autodetection/filtered.go
65.21% <65.21%> (ø)

pkg/utils/autodetection/interface.go
67.16% <67.16%> (ø)

pkg/utils/netutil/netutil_linux.go
37.50% <80.00%> (+4.16%)
:arrow_up:

/assign @x893675

/cc @x893675

/lgtm
/approve


Set exitcode when service is not found

In the following code when bad app is specified we get an error and non-zero status code.
But when app is ok but service is wrong we do not get an exception and status code is 0.
So I cannot trace when wrong service is called.
Please have a look:
max@MacBook-Pro-Max tmp % nameko run no_service.no_app --config=config.yml
Traceback (most recent call last):
  File "/Users/max/Library/Python/3.7/bin//nameko", line 10, in <module>
    sys.exit(main())
  File "/Users/max/Library/Python/3.7/lib/python/site-packages/nameko/cli/main.py", line 112, in main
    args.main(args)
  File "/Users/max/Library/Python/3.7/lib/python/site-packages/nameko/cli/commands.py", line 110, in main
    main(args)
  File "/Users/max/Library/Python/3.7/lib/python/site-packages/nameko/cli/run.py", line 181, in main
    import_service(path)
  File "/Users/max/Library/Python/3.7/lib/python/site-packages/nameko/cli/run.py", line 46, in import_service
    __import__(module_name)
ModuleNotFoundError: No module named 'no_service'

max@MacBook-Pro-Max tmp % echo $?
1

Now with wrong sub-service:
max@MacBook-Pro-Max tmp % nameko run test_app.no_app --config=config.yml
Error: No module named 'test_app.no_app'
max@MacBook-Pro-Max tmp % echo $?
0

I can confirm this is also the case in my dev installation of Nameko 2.12.0. This seems to be caused by this line only printing the error message but not exiting the process afterwards with a nonzero exit code.
This seems to have been fixed in 3.0.0, as the underlying CLI parsing module has been updated. Still, would it be useful to patch 2.12.0 to correctly return an error exit code here?


Angular 13 - Component factory argument

Hi,
after upgrade to Angular 13 I noticed an error that occurs only in development profile (for now).
It seems like the component factory is called with a deprecated argument combination.
In production profile it still builds and works, but I guess it can be expected to break with upcoming releases.
Error message is as following:
ERROR Error: ASSERTION ERROR: It looks like Component factory was provided as the first argument and an options object as the second argument. This combination of arguments is incompatible. You can either change the first argument to provide Component type or change the second argument to be a number (representing an index at which to insert the new component's host view into this container) [Expected=> true == false <=Actual]
    at throwError (core.mjs:326)
    at assertEqual (core.mjs:277)
    at ViewContainerRef.createComponent (core.mjs:23151)
    at NestedEllipsisDirective.restoreView (ngx-nested-ellipsis.js:217)
    at NestedEllipsisDirective.ngOnInit (ngx-nested-ellipsis.js:137)

@romankh Thanks for pointing that out!
Fixed in<EMAIL_ADDRESS>

@lentschi Thanks for the fix, works like a charm


[SPARK-46317][INFRA][FOLLOWUP] Install lxml in PyPy3.8

What changes were proposed in this pull request?
This PR aims to install lxml in PyPy3.8.
Why are the changes needed?
#44247 seems to break the PyPy3.8 daily CI.

https://github.com/apache/spark/actions/runs/7239278196/job/19721018105

Traceback (most recent call last):
  File "/usr/local/pypy/pypy3.8/lib/pypy3.8/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/pypy/pypy3.8/lib/pypy3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/__w/spark/spark/python/pyspark/sql/tests/test_session.py", line 22, in <module>
    from lxml import etree
ModuleNotFoundError: No module named 'lxml'

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

LGTM pending CI

thanks, merged to master

Thank you, @zhengruifeng ! 😄

Thank you!