Gommitizen needs to be run in the root of the repository to work

If gommitizen is run in a subdirectory of the repository, once the .version.json, the changelog and other files are updated/created when git is trying to add those files to the repository for commiting them, gommitizen fails.
This could fail due to the relative path from a subdirectory. Maybe trying to control the path where we are from could fix this problem when those files before said are being added to the repository.

Fix: Show a message to run gommitizen in the root path of the git repository.


w2l_decoder.py gives AssertionError on line 144

The assertion in question:
for i, (word, spellings) in enumerate(self.lexicon.items()):
                word_idx = self.word_dict.get_index(word)
                _, score = self.lm.score(start_state, word_idx)
                for spelling in spellings:
                    print(spelling)
                    spelling_idxs = [tgt_dict.index(token) for token in spelling]
                    assert (
                        tgt_dict.unk() not in spelling_idxs
                    ), f"{spelling} {spelling_idxs}"
                    self.trie.insert(spelling_idxs, word_idx, score)
            self.trie.smear(SmearingMode.MAX)

Does anyone know what could be causing this? I have successfully trained a language model and manually inspected the arpa file and tested the binary and it seems to be fine. It seems it's going through the lexicon file, word by word, and it finds a word it doesn't like - then fails. Where should I start to begin debugging? I've been stuck for a few days. Viterbi decoding works well but i'd like to use kenlm decoding.

i think i got it. i was generating my dictionary from the training transcript but my lexicon contained symbols that hadn't been encountered in the training. im going to try generating a dictionary from my corpus and go from there.

Looks like this is related https://github.com/pytorch/fairseq/issues/2734

Managed to get to the bottom of this. I had followed the @mailong25 instructions which generate a dict file from the training transcript. This will give the error I experienced when we encounter a word in the lexicon which has characters not found in the transcript. Better to generate the dict from the corpus instead to avoid such a problem.


Do Tablite Support different datasets Concurrently ?

Hi Team,
Can we support different datasets and can store at different location and process it concurrently.
Regards,
Akahs

Hi @akash-goel  - It could probably be done. Could you describe your use case in a little more detail?

Hi ,
we have a user case , in which we have multiple users which are using a webapp and are trying to work on different files.
At the Server end we want to read the file , process it and share the results to the users concurrently.
when i have checked the Tablite i am not able to see where tablite is storing the data , is it storing in a different file or the same file and can we change the location of storage.
Please let me know if this usecase works with tablite.
Regards,
Akash

Data is stored in tmp/tablite.hdf5. This file - just like sqlite3 - can contain an infinite number of datasets (as long as you have disk space).

Thanks for your response ,
I have tried on small dataset , Functionality working fine but when i am trying with big dataset getting below error.
Code Block
from tablite import Table Table.reset_storage() t3 = Table.import_file('Data_test.csv') t3.show()
Error
`Traceback (most recent call last):
File "", line 1, in
File "\lib\multiprocessing\spawn.py", line 116, in spawn_main
exitcode = _main(fd, parent_sentinel)
File "\lib\multiprocessing\spawn.py", line 125, in _main
prepare(preparation_data)
File "\lib\multiprocessing\spawn.py", line 236, in prepare
_fixup_main_from_path(data['init_main_from_path'])
File "\lib\multiprocessing\spawn.py", line 287, in _fixup_main_from_path
main_content = runpy.run_path(main_path,
File "\lib\runpy.py", line 265, in run_path
return _run_module_code(code, init_globals, run_name,
File "\lib\runpy.py", line 97, in _run_module_code
run_code(code, mod_globals, init_globals,
File "\lib\runpy.py", line 87, in run_code
importing: processing 'Data...est.csv': 66.99%|██████████████████████████████▏              | [00:04<00:01]
exec(code, run_globals)
File "c\API\tablite_test.py", line 11, in
t3 = Table.import_file('Data_test.csv')
File "\lib\site-packages\tablite\core.py", line 1756, in
import_file
t = reader(**config, **additional_configs)
File "\lib\site-packages\tablite\core.py", line 481, in text_reader
with TaskManager(cpu_count - 1) as tm:
File "\lib\site-packages\mplite_init.py", line 79, in enter
self.start()
File "\lib\site-packages\mplite_init.py", line 89, in start
worker.start()
File "\lib\multiprocessing\process.py", line 121, in start
self._popen = self._Popen(self)
File "\lib\multiprocessing\context.py", line 224, in _Popen
return _default_context.get_context().Process._Popen(process_obj)
File "\lib\multiprocessing\context.py", line 326, in _Popen
return Popen(process_obj)
File "\lib\multiprocessing\popen_spawn_win32.py", line 45, in init
prep_data = spawn.get_preparation_data(process_obj._name)
File "\lib\multiprocessing\spawn.py", line 154, in get_preparation_data
_check_not_importing_main()
File "\lib\multiprocessing\spawn.py", line 134, in _check_not_importing_main
raise RuntimeError('''
RuntimeError:
An attempt has been made to start a new process before the
current process has finished its bootstrapping phase.
    This probably means that you are not using fork to start your
    child processes and you have forgotten to use the proper idiom
    in the main module:

        if __name__ == '__main__':
            freeze_support()
            ...

    The "freeze_support()" line can be omitted if the program
    is not going to be frozen to produce an executable.

importing: saving 'Data...est.csv' to disk: 70.00%|████████████████████████████▋            | [00:04<00:01]`
Can you please guide what configuration we can do to load the file.

As noted in the config in line 21 the single processing limit is 1_000_000 rows. When the data exceeds this number of rows, tablite switches to multiprocessing.
As you are using windows, this means you need to make your module importable for the windows subprocess 1.
The easiest way to do this, is to wrap your code block in a function, such as this:
def main():
    Table.reset_storage()
    t3 = Table.import_file('Data_test.csv')
    t3.show()

if __name__ == "__main__":
    main()

Closing this issue as there has been no news since April 21st.


Docs appbar lacks a bit of padding

Link to the Page
skeleton.dev
Describe the Issue

On mobile browsers (probably all?) the appbar lacks some padding to the right of the GH icon. I tested Edge in iPhone 12 and Chrome on some recent Samsung.
Not a big deal, but since the YT stream is bringing a lot of new devs it might be worth making sure the first impression is good.
Are you able to create a Pull Request with the fix?
None

@Etchelon Thank you sir! I'll get this fixed asap!


SageMaker fails because Conversation object is not found

We are hosting a model in SageMaker and today we observed the following error in our logs when the model was being relaunched in the instance:
ImportError: cannot import name 'Conversation' from 'transformers.pipelines' (/opt/conda/lib/python3.9/site-packages/transformers/pipelines/__init__.py)

I found someone reported a similar issue in https://discuss.huggingface.co/t/cannot-import-conversation-from-transformers-utils-py/91556. When digging into the changes in the transformers dependency I found this change regarding the Conversation object: https://github.com/huggingface/transformers/pull/31165
Based in our logs, the last time the model was successfully relaunched in our SageMaker infrastructure (2 days ago), the version of the package that was downloaded was transformers-4.41.2-py3-none-any.whl, but when the error started to be observed, the downloaded version was transformers-4.42.1-py3-none-any.whl.
According to the pull request mentioned above, the change is effective as per version 4.42, which was released 18 hours ago at the moment of writing this issue.
I think a change is needed in src/sagemaker_huggingface_inference_toolkit/transformers_utils.py to reflect the new structure of the code in the transformers dependency or pin the dependency version to version 4.41.2 to prevent the issue in the future.
In our case, we are updating our requirements.txt file to pin the version 4.41.2, but other users might not be aware of what is happening, therefore they are not aware of this fix.

I have the same problem when running SageMaker specifying transformers 4.44
2024-08-08T20:54:55,820 [INFO ] W-9000-model-stdout com.amazonaws.ml.mms.wlm.WorkerLifeCycle -   File "/opt/conda/lib/python3.10/site-packages/sagemaker_huggingface_inference_toolkit/transformers_utils.py", line 24, in <module>
2024-08-09T14:03:27,296 [INFO ] W-9000-model-stdout com.amazonaws.ml.mms.wlm.WorkerLifeCycle -     from transformers.pipelines import Conversation, Pipeline
2024-08-09T14:03:27,297 [INFO ] W-9000-model-stdout com.amazonaws.ml.mms.wlm.WorkerLifeCycle - ImportError: cannot import name 'Conversation' from 'transformers.pipelines' (/opt/conda/lib/python3.10/site-packages/transformers/pipelines/__init__.py)

I tried specifying transformers 4.41.2, but that triggered this error:
2024-08-09T15:14:27,329 [INFO ] W-9000-model-stdout com.amazonaws.ml.mms.wlm.WorkerLifeCycle - ImportError: peft<=0.6.2 is required for a normal functioning of this module, but found peft==0.12.0.
Specifying peft<=0.6.2 triggered this error:
"rope_scalingmust be a dictionary with two fields,typeandfactor, got {\u0027factor\u0027: 8.0, \u0027low_freq_factor\u0027: 1.0, \u0027high_freq_factor\u0027: 4.0, \u0027original_max_position_embeddings\u0027: 8192, \u0027rope_type\u0027: \u0027llama3\u0027}" }

I have also encountered this issue when trying to update to the most recent version of transformers and continue making use of the sagemaker-huggingface-inference-toolkit.
Is the simple fix for now to simply remove the Conversation import from the place highlighted in the original comment?
I'm more concerned that this highlights a lack of maintenance and / or wider usage of this package across the community. What is the recommended way to host HF models for inference in SageMaker that does not make use of the sagemaker-huggingface-inference-toolkit?

@ed-berry I'm still having this issue if I use the latest version of transformers (4.44.2), and I get other errors if I use transformers 4.41.2.
I see your PR, but it still hasn't been merged. @philschmid  has approved it, but it currently says "This workflow requires approval from a maintainer." Do you know how we can bring this to the attention of the maintainers?

Hey @joann-alvarez. That PR will need merging and a new release of the inference toolkit creating to resolve the issue if you aren't able to use an older version of transformers.
Yeah, one of the maintainers needs to approve a run of the GitHub workflows that check the PR before it can be merged. I'm not sure how we flag that beyond creating a PR and this issue though.
Your best bet might be trying to get an older version of transformers working for now.

Hi, how do I use the latest version? I'm trying to deploy FLUX to Sagemaker but I'm facing this issue when installing transformers==4.43.4

Is there any update or temporary solution to this? I can't pin it to a specific lower version as sagemaker would complain about it

Can you try adding temporary install/add huggingface-hub==0.25.2, while we are looking into that

@philschmid I just tried adding that. I still get this error since I've been getting since August:
2024-10-21T15:08:07,968 [INFO ] W-9000-model-stdout com.amazonaws.ml.mms.wlm.WorkerLifeCycle - ImportError: cannot import name 'Conversation' from 'transformers.pipelines' (/opt/conda/lib/python3.10/site-packages/transformers/pipelines/__init__.py)
It also seems that huggingface-hub==0.25.2 was already installed.

Pinning transformers==4.41.2 is suboptimal in our case. Setting huggingface-hub==0.25.2 also didn't help. A fix would be great!

I took these steps, and I think one of them ended up fixing it. Get the latest version of sagemaker and install the latest version of sagemaker-huggingface-inference-toolkit. I installed these in the environment where I was executing the script to deploy, and I also added the latest version of sagemaker-huggingface-inference-toolkit to the requirements of the container. Lastly, I switched the image I had been using to one built on top of sagemaker's prebuilt one for inference, with version 2.0 of pytorch. I switched to the one with the latest version of pytorch they had.
I'm not sure which of these fixed it.

Hi @joann-alvarez, which image did you use?


Wrong french keyboard layout

Description
Briefly describe the issue
Running from archlinux the test on CentOS of https://learn.chef.io/learn-the-basics/rhel/get-set-up/ is wrong mixing en-US layout and French with not . nor /
Chef Version
Tell us which version of chef-client you are using (see below for Server+ChefDK bugs).
The online test version
Platform Version
Tell us which Operating System distribution and version chef-client is running on.
Your online test version
Replication Case
Tell us what steps to take to replicate your problem.  See How to create a Minimal, Complete, and Verifiable example
for information on how to create a good replication case.
From Archlinux - Ratpoison - Chromium running https://learn.chef.io/learn-the-basics/rhel/get-set-up/ the centOS online test give wrong layout keyboard with no . nor /
Client Output
The relevant output of the chef-client run or a link to a gist of the entire run, if there is one.
https://learn.chef.io/learn-the-basics/rhel/get-set-up/
The debug output (chef-client -l debug) may be useful, but please link to a gist, or truncate it.
https://learn.chef.io/learn-the-basics/rhel/get-set-up/
Stacktrace
Please include the stacktrace.out output or link to a gist of it, if there is one.
NOTE: CHEF CLIENT BUGS ONLY
This issue tracker is for the code contained within this repo -- chef-client, base knife functionality (not
plugins), chef-apply, chef-solo, chef-client -z, etc.

Server issues
ChefDK issues
Cookbook Issues (see the https://github.com/chef-cookbooks repos or search Supermarket or GitHub/Google)

@tpetchel can you comment on the set up of the RHEL ami for learnchef? @aurelien-git does this problem occur if you try a basic CentOS AMI?


Fix: when default visualization is displayed, its entry is not present in the chooser list.

Pull Request Description
The visualization was blank because we set a new visualization instance with same data for attaching, so VisualizationManager skipped attaching (and thus the data for previous instance were not shared with the new one).
And the entry was visible, because we informed chooser about selected vis before the visualization list arrived.
Fixes #5992 may also fix some other issues with blank visualizations.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

I will check it


x509/by_file.c: fix unreachable and redundant code

Fixes #21534
I tried to fix;

Unreachable code
It is impossible to get to lines 146-147 and 208-209 in functions X509_load_cert_file_ex() and X509_load_crl_file()

if (ret == 0)
    ERR_raise(ERR_LIB_X509, X509_R_NO_CERTIFICATE_FOUND);

Lots of redundant code
For example, in function X509_load_cert_file_ex() on line 99, if in == NULL call goto and execute BIO_free(in) (it is NULL) and X509_CRL_free(x) (it is NULL also).
On lines 132-133 execute X509_CRL_free(x), but after that we go to the lines under err, where we again do X509_CRL_free(x).
And similar in other places in code.

No oiptimal check
On lines 104-107 in X509_load_cert_file_ex() there is check

if (type != X509_FILETYPE_PEM && type != X509_FILETYPE_ASN1) {
    ERR_raise(ERR_LIB_X509, X509_R_BAD_X509_FILETYPE);
    goto err;
}

but it would be more optimal to use else {} on line 146 instead of it

Breaking the code style
In function by_file_ctrl_ex()

Squashed and merged to master. Thank you for your contribution!


ImagePullSecrets in Helm charts for Docker Registry

I recently encounter a situation where pods -not only PSO's- were evicted due to some pressure on nodes.
Then it went into a kind of scheduling loop:

PSO operator was down
Apps' Pods were not able to dettach/attach volume, no CSI available
PSO Pods/DB could not terminate because of the finalizer not being available
Apps and PSO Pods were getting into a crashloop and imagepull
Rate limiting on dockerhub was reached for image pulling
PSO could never start even after forcing finalizing the pods, because of docker hub blocking the image pull.

I sorted it out by creating a secret with my dockerhub credentials -we have a paid account- and setting the imagePullSecrets on PSO's Deployments&StatefulSets. It appears I could not do that through the helm charts and it will be replaced in next update.
Once nodes health OK, PSO was back again thanks to the secret, the cluster recovered.
It is the first time I am getting blocked in the middle of a troubleshooting because of docker's limits.
Is there a way to specify the secret in the helm values.yaml ?

We are updating the DockerHub account and will fix the rate limiting issue for image pulling.

I reread the documentation about docker hub rate limit and as far as I understand the quota is applied to the puller not the publisher, thus it is important that we can set our credentials in imagePullSecret as documented in the link above (see Kubernetes). From a practical point of view, referencing the secret from the helm chart's values.yaml. Don't you think? @sdodsley

Whilst I agree that there are pull limits for individual users, the issue we were seeing was that the Pure docker account hosting the images was a free account and therefore had limits placed on the number of image requests from it. These limits no longer exist as we have upgraded to a  Team account.
Should we see an uptick in issues with individual user accounts experiencing pull issues, we can certainly look into your suggestion as a possible solution.

@sdodsley  thank you for your message, I cannot find this information anywhere. As we are also docker hub users may you be kind enough to highlight where requests limits applied to image publisher is documented and how you may know when quota is reached ? I can only see pull limits. btw when we were facing the issue with your image it was just with any image trying to be pulled unauthenticated from docker hub so that was obviously our limit applied. thanks

@sdodsley actually I confirmed the opposite so you may review it:
https://www.docker.com/pricing/resource-consumption-updates
"Rate limits for Docker image pulls are based on the account type of the user requesting the image - not the account type of the image’s owner. These are defined on the pricing page."

@mscbpi Yes - I agree with you after reading the blog post. Docker do not make it obvious and there is an implication in their pricing guidelines that the pull limits are based on the hosting account as well.
I will raise this issue with our Product Management team as it could impact not just PSO and its ultimate merging with Portworx, but also Portworx's as well.

So PSO will merge with portworx ? 😀

Yes - we have a roadmap for the complete integration by the end of this calendar year.
if you would like us to give you a presentation on the PSO -> PX roadmap please let me know by emailing me at<EMAIL_ADDRESS>


[FR] Offer users a free bet on a market

As a market creator, I'd like to be able to attach free bets to a market, similar to the way "boosting" is done now.

Market owners would be able to buy free bets on a market page, in a similar location to the "Boost" field
Users would see the free bets as they scroll through the feed

For Yes/No markets, users could potentially be shown two buttons, "Free M$5 Yes Bet" and "Free M$5 No Bet", similar to the "Claim M$ 5" button for boosting

Free bets would be constrained to one free bet per trader per market

This would allow market creators to directly purchase engagement on their markets.
Discord discussion

speculative visualization of the free bet buttons and form UI

This has been discussed a lot. Directly paying for bets is something people ask for a lot, but I continue to think it's mechanically fraught and makes the feed experience worse.
I think the best iteration would be to have 3 buttons to allow people to choose to get Y Yes shares, N No shares, or $M3. I think keeping the option to just take money is actually good, because the viewer may not want a position in the market, may not be interested enough or opinionated enough. This keeps advertisers honest and prevents spam, instead encouraging them to make markets that people will find interesting.

@sipec Thanks for the feedback, I appreciate it! Let me know if you want me to take a crude swing at the dev work for this, or if the team wants help doing User Acceptance Testing (if this gets prioritized).


Echart lt and gte is not working properly[Bug]

Version
8.0.1
Link to Minimal Reproduction
No response
Steps to Reproduce
1.In E-Charts use visual map
2.write lg and gte value and both values will be same
3. this is giving error
Current Behavior
 "visualMap": [
    {
      "top": 50,
      "right": 0,
      "pieces": [
        {
          "color": "#F44336",
          "gte": 0
        },
        {
          "color": "#43A047",
          "lt": 0
        },
        {
          "color": "#43A047",
          "lt": 0
        }
      ],
      "show": false,
      "outOfRange": {
        "color": "#6e6e6e"
      },
      "seriesIndex": 0
    }
  ]

This is giving me error.
Because of this i am not able to plot the chart
Expected Behavior
This value should work like if greater then that value then it should give that color and for less then value it show apply that color.
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

cannot reproduce: Demo Code
woks as expected

For the bar chart, it's working properly. But for line chart it's not working..
option = {
yAxis: {},
xAxis: {type: 'category'},
tooltip: {},
series: [
{
type: 'line',
name: 'profit',
}
],
dataset: [
{
dimensions: ['year', 'profit'],
source: [
{
year: '2010',
'profit': 100,
},
{
year: '2011',
'profit': 200,
},
{
year: '2012',
'profit': -150,
},
{
year: '2013',
'profit': 300,
}
]
}
],
"visualMap": [
{
"top": 50,
"right": 0,
"pieces": [
{ "color": "#F44336", "gte": 0},
{ "color": "#43A047", "lt": 0 }
],
//"show": false,
"outOfRange": {
"color": "#6e6e6e"
},
//"seriesIndex": 0
}
]
};
This is the JSON I tried..

ok, bug confirmed with latest sample code,
visualMap produces an error for line series:
"failed to run code TypeError: Cannot read properties of undefined (reading 'coord')"

workaround: add a small value to one of the pieces
      pieces: [
        { color: '#F44336', gte: 0 +0.001 },
        { color: '#43A047', lt: 0 }
      ],


failed to load the native TensorFlow runtime

Issue type
Build/Install
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
2.17.0
Custom code
Yes
OS platform and distribution
Microsoft Windows 10.0
Mobile device
No response
Python version
3.12.6
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
it shows that an import error " DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed
Standalone code to reproduce the issue
Traceback (most recent call last):
  File "C:\Program Files\Python312\Lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 70, in <module>
    from tensorflow.python._pywrap_tensorflow_internal import *
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:/Users/admin/1.py", line 1, in <module>
    import tensorflow as tf
  File "C:\Program Files\Python312\Lib\site-packages\tensorflow\__init__.py", line 38, in <module>
    from tensorflow.python import pywrap_tensorflow as _pywrap_tensorflow  # pylint: disable=unused-import
  File "C:\Program Files\Python312\Lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 85, in <module>
    raise ImportError(
ImportError: Traceback (most recent call last):
  File "C:\Program Files\Python312\Lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 70, in <module>
    from tensorflow.python._pywrap_tensorflow_internal import *
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.

Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/errors for some common causes and solutions.
If you need help, create an issue at https://github.com/tensorflow/tensorflow/issues and include the entire stack trace above this error message.

Relevant log output
Traceback (most recent call last):
  File "C:\Program Files\Python312\Lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 70, in <module>
    from tensorflow.python._pywrap_tensorflow_internal import *
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:/Users/admin/1.py", line 1, in <module>
    import tensorflow as tf
  File "C:\Program Files\Python312\Lib\site-packages\tensorflow\__init__.py", line 38, in <module>
    from tensorflow.python import pywrap_tensorflow as _pywrap_tensorflow  # pylint: disable=unused-import
  File "C:\Program Files\Python312\Lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 85, in <module>
    raise ImportError(
ImportError: Traceback (most recent call last):
  File "C:\Program Files\Python312\Lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 70, in <module>
    from tensorflow.python._pywrap_tensorflow_internal import *
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.

Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/errors for some common causes and solutions.
If you need help, create an issue at https://github.com/tensorflow/tensorflow/issues and include the entire stack trace above this error message.

Hi @arzappu  ,
Could you please provide the tensorflow and the compatible version which you are trying to install. Also there are at least 3 possible scenarios:
You need to install the MSVC 2019 redistributable
Your CPU does not support AVX2 instructions
Your CPU/Python is on 32 bits
There is a library that is in a different location/not installed on your system that cannot be loaded.
https://github.com/tensorflow/tensorflow/issues/61887
Thank you!


Product Management Features

Define the Product model with necessary fields including name, description, price, and seller reference.
Implement product CRUD operations in the product controller.
Secure product creation, update, and deletion routes to ensure only authenticated sellers can perform these actions.
Create routes for listing all products and fetching single product details.


support singularity 'pause' request

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

  Generated by :no_entry_sign: Danger

I don't think you want to be constructing your tests via the otpl manifest parser ? (ext/otpl/manifestparser_test.go)
Other than that it looks to me like you are on the right path to getting the pause in place.

Codecov Report

Merging #814 into master will decrease coverage by 0.06%.
The diff coverage is 9.09%.

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   52.82%   52.75%   -0.07%
==========================================
  Files         278      278
  Lines       16548    16568      +20
==========================================
  Hits         8741     8741
- Misses       7113     7132      +19
- Partials      694      695       +1

Impacted Files
Coverage Δ

lib/deploystatus.go
0% <ø> (ø)
:arrow_up:

lib/dummy_rectification_client.go
0% <0%> (ø)
:arrow_up:

lib/deploystatus_string.go
50% <0%> (ø)
:arrow_up:

ext/singularity/recti-agent.go
55.25% <0%> (-2.93%)
:arrow_down:

lib/deploystate.go
19.04% <100%> (ø)
:arrow_up:

ext/singularity/deployer.go
66.66% <20%> (-1.36%)
:arrow_down:

cli/sous_jenkins.go
15.38% <0%> (-1.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 530bf04...46b03c2. Read the comment docs.


Show poster and link to EmberMap video

Hey Offir, now that you and Ryan have finished the video let's link to it in the readme!

Thank you both so much! The video looks fantastic. 😸


org.freedesktop.Secret.Service not available for use, secrets stored insecurely

Describe the bug
After installing from flatpack, product works as advertised though shows error at the bottom of window.
this is storing the "secret" information insecurely, kdewallet manager and wallet itself are both open and running when I launch this application.
To Reproduce
Steps to reproduce the behavior:

Open Application
look at bottom bar
See error: "org.freedesktop.Secret.Service not available for use, secrets stored insecurely"

Expected behavior
Login and store information in a secure manner
Desktop

OS: Fedora 37 KDE - Kernel 6.0.18-300    AMD & Intel Based systems x86_64

HowTo:
https://rtfm.co.ua/en/what-is-linux-keyring-gnome-keyring-secret-service-and-d-bus/
Install packages:
GUI:
qdbusviewer – view objects and messages, is a part of the qt5-tools set
d-feet – D-Bus debugger
bustle – D-Bus message analyzer and profiler
And Run it:
$ d-feet
Open Epic-Asset-Manager, close and open again.

Thank you @firebitsbr for providing the gudie, I should probably include it in some form of FAQ.
@The-Maize the issue is that KDE currently does not have an implementation of secret manager. AFAIK they are working on it. In the mean time the "insecure" means that they are unencrypted on the drive which is not any less secure than what Heroic launcher or even the official EGS store does, so there is no "real" concern in terms of exposing the secrets to the public. If your system is compromised to the point of these being at risk you probably have other problems.

This is just a warning message. I need to see if keepass is able to serve as the secret service(if it listens through dbus correctly). Will install it in a VM to see if and how this can be made work.

I do not think it is case sensitive. I do not doubt that it works, just not sure how gtk/flatpak talks to it there.

I made a crucial decision to not display the warning anymore. I do have couple reasons for this:

It works on the supported DE (Gnome)
If it does not work it saves the secret like any other similar tool(looking at Legendary) which is presumably "secure enough"
I have no control over how every single DE implements their secret manager and if they all use the same standard
If and When there is a DE agnostic way of handling this I will use that instead of the current implementation but as of now this is "fine"

How did you patch AUR?:) Just curious I can patch in in AUR as well if it works properly for most test cases


Lucid + Froala: emoticons problem in Post to Context/Public Feed

The Emoticons seem to have incorrect z-index:
Lucid:
Protean:

https://una.io/page/view-discussion?id=7342

Froala is missing in the home page and time line but appears in other areas like pages. Can you please help me fix this issue?

I am Ruben Ollervides

Froala is missing in the home page and time line but appears in other areas like pages. Can you please help me fix this issue?

It's just a setting, it can be changes in Studio > Timeline > Settings > Post > Enable post form editor toolbar

@AlexTr Awesome! It's back🙂Thank you!

@AlexTr Also people are posting in these areas (see image) 4 places to post link😳 people are getting confused. The best place to post articles & videos is where the ➕ is ( images & videos are great)and you can paste a link in the share icon far right. Is there a way to remove these other places? So there is no confusion? Also if you post on these other areas only the link posts without image or video. The non Froala link icon at the bottom posts image but they are cut off and looks pretty bad.

@Rigal777 could you please post question in forum - https://una.io/page/discussions-home ?
thank you


HWKALERTS-188 Add cross-tenant ops per fetching events/alerts

Creating new /admin endpoint for cross tenant operations
Add support for fetching alerts/events from multiple tenants
Add additional tests

please @jshaughn, could you review ?
I haven't included on this one the batching optimizations.
I'm performing some local testing before to send them into the code.
But this cross tenant feature is almost ready for review.

Thanks for the comments.
I'm going to prepare a following commit with suggestions applied.


Suggestions for modifying the default icon.

This is a fantastic software, and I appreciate the author's active maintenance.
I have a small suggestion: could the default software icon be changed, or could dedicated icons be created for different formats (Maybe i can provide artistic support)? The current icon is a bit scary; I mean, when I open a folder, those eyes look a bit frightening. This is just my personal feeling. I don't want to affect your development progress, and I apologize for this very subjective and selfish request. I would be very grateful if you could consider it.

I humbly agree.  It is striking, but also looks a bit odd when somebody is looking over your shoulder.
I would like something like the existing, but maybe just outline strokes of an abstract eye over alpha.

Thank you for your response. I agree that abstraction is a wonderful choice.
From a psychological perspective, abstract styles do not convey very concrete emotions through the eyes.
Flat or illustrative styles might also achieve a similar effect.
If you need my help with creative design, please feel free to leave your email, and I will send you the draft once it’s ready. Currently, this service is free, and I hope this request does not put any pressure on you.
Additionally, AIGC is also a good option.

Thank you for your comments.  You can avoid seeing the ugly icon if you use mrv2's custom file requester instead of relying on Windows Explorer.
Regarding the icon, if you can provide me with an .svg drawing of it, you can send it to<EMAIL_ADDRESS>

Hi, i also had some designs in mind when reading this issue. They are are bit more modern, and clearly inspired by current Windows 11 App icons – but i think this is a good direction for mrv2 to go in.
If you want any more variations or suggest something on these icons, just shoot it out.

I designed an icon, sorry it took some time, my graphic design skills still need improvement. This is an SVG file, you can open it in AI or a browser.

@JomW  Your icon is very similar to mrv2's original icon and I think it would not be much of an improvement.
@AltaArts Sent me two icons privately which are similar to the mrv2 icon currently in beta, which, after trying it, I don't fancy it much.
@Thane5  Your design of Icon_02 is BY FAR my preferred icon.  It is elegant and the pupil as a play button conveys mrv2's use rather well.  It also sits well with both Windows 11 and its rounded design works with macOS too.  Contact me privately with the details (.svg file or large .png file, etc).  If you want compensation for it, I would need to know how much and whether you have a Paypal account.

I agree, Thane5's look like they will work well!  Nice!

Glad you like them.
Here you have an archive with the final version as an SVG, PNG, and my Affinity Designer file:  Export.zip

(No money needed, i'm just doing my part at making this free software even better.)

here is a slightly revised version. with the corner readius matching that of other macOS apps. The PNG now also has a dropshadow from Apple's design templates, which their app icons apparently need.
mrv2_Icon.zip

I just updated to 1.2.3 and congrats!  The icons look great and work well!
Nicely done @Thane5  and @ggarra13!

I noticed that the last icon looks too small on Windows.  Therefore i made seperate png for Windows, without the shadow and no transparent border.
mrv2_icon.zip
Can you define seperate icons per platform, or do they all just use one shared icon? In case thats not possible, it would probably make sense to use the windows icon globally. Though i would like to see a screenshot from a mac user to make sure it does not look bad.

Though i would like to see a screenshot from a mac user to make sure it does not look bad.

Here's how it looks on the macOS dock with the original design.  To me it looks great!

Good to hear it looks as expected.
Unfortunately the Mac icon looks kind of tiny on the Windows 11 taskbar. Here it is to the left of the windows icon:

On my Windows 11 Pro machine, it looks the same size as most other icons:

Weird...  v1.2.4 that I just installed for testing and used for setting the file associations looks small.  The previous version (v1.2.3 no longer with file associations) looks fine.  Recent Files associated to it also look small.  But on Explorer, where I used Windows' Photo Associations first and then mrv2 associations again to get preview pictures all looks fine.

Something in Windows or in my installer is doing some funky stuff....

Btw are you able to define a "File type" icon for this program? Many programs have specific icons that are different from the program icon, when a file is associated with that program but has no thumbnail image. Most of the Adobe apps do this, like Photoshop but also Acrobat

Okay.  I fixed the Windows resize issue, which was tricky as Windows 11 Pro kept caching the thumbnails making me think it was not working.
Regarding different file types for different extensions, I am afraid I will not do it.  Doing so involves using COM (a technology that I think even Microsoft no longer uses) and it is really ugly code.
What I suggest, if you have Windows 11 Pro is to take advantage of the Windows Photo utility (as documented in mrv2's docs), which will show a thumbnail of most images/movies but still open it with mrv2.  See the mrv2 FAQ - Windows.

Fixed in v1.2.4 beta.  Closing the issue.


Expose Node3DEditorViewport to GDScript

One user and I want access to the cameras from the 3D editor viewports for tools and plugins.
Post on the QA forums
I went ahead and exposed the Node3DEditorViewport class, which has a method for getting the camera.
I've added a method to EditorInterface, get_node3D_editor_viewport(int p_idx), to access these viewports.
If it is preferable that I don't expose Node3DEditorViewport, I could expose this functionality through EditorInterface instead e.g.
get_node3d_editor_camera(int p_idx)
set_node3d_editor_message(string message, int p_idx, double p_time)
Bugsquad edit: This closes #26534. This closes https://github.com/godotengine/godot-proposals/issues/1302.

The class should be documented if it's going to be exposed: https://docs.godotengine.org/en/stable/community/contributing/updating_the_class_reference.html

@Phischermen  Is this still desired? If so, it needs to be rebased and tested on the latest master branch.

I have just rebased and tested. It appears to still work!

i guess this is dead ?

This would be helpful for those making plugins that manipulate the editor cameras.

Closed in favor of #68696


Raise Warning message if to_pdb attempts to write unknown columns

Coverage increased (+0.4%) to 92.347% when pulling 947a9d946f7bb967bc6c2506dcfb7a42cd432057 on columns into 87be029cbf646be80bd776cf2092b7014100c01b on master.

Coverage increased (+0.4%) to 92.347% when pulling 947a9d946f7bb967bc6c2506dcfb7a42cd432057 on columns into 87be029cbf646be80bd776cf2092b7014100c01b on master.


dokku plugins-install is resulting in "Permission denied" error

I have successfully deploying and running a few dokku apps on amazon EC2 and vagrant (both on ubuntu 14 LTS).
But, on both system, I am not able to deploy any plugin using dokku plugins-install command.
$ dokku plugins-install https://github.com/beedesk/dokku-docker-options.git
/var/lib/dokku/plugins/00_dokku-standard/install: line 16: /etc/init/dokku-redeploy.conf: Permission denied

The relevant lines look like this:
# temporary hack for https://github.com/progrium/dokku/issues/82
# redeploys all apps after a reboot
case "$DOKKU_DISTRO" in
  ubuntu)
    sudo cat<<EOF > /etc/init/dokku-redeploy.conf
    ...
EOF

At first, I thought it was issue #82. But, I tried to change the owner of the conf file, but it only get me another permission error in one of the next step.
I couldn't find other related issue, so I decide to file this.
Is it a known bug?
Is there some workaround I can use to get around the problem?

The plugins-install command does not install plugins, it merely runs the install pluginhook. You need to follow the directions of that plugin to install it.

@josegonzalez, thanks for the quick reply.

hey guys,
just want to report I found this error again today.
    mattions@carrier:~$ dokku plugins-install
    /var/lib/dokku/plugins/00_dokku-standard/install: line 16: /etc/init/dokku-redeploy.conf: Permission denied

The solutions was to run dokku with sudo:
    sudo dokku plugins-install

and I've managed to install the mariadb plugin.


RFC: add iterator support for generating the sequence of negative odd integers

Checklist

Please ensure the following tasks are completed before submitting a feature request.

[x] Read and understood the Code of Conduct.
[x] Searched for existing issues and pull requests.
[x] The issue name begins with RFC:.

Description

Description of the feature request.

This RFC proposes adding iterator support for generating the sequence of negative odd integers. This would be similar to the package @stdlib/math/iter/positive-even-integers.
The implementation would have the following package name:
Package: @stdlib/math/iter/negative-odd-integers
Alias: iterNegativeOddIntegersSeq
Related Issues

Does this feature request have any related issues?

None.
Questions

Any questions for reviewers?

No.
Other

Any other information relevant to this feature request? This may include screenshots, references, sample output, and/or implementation notes.

No.

Added in<PHONE_NUMBER>cacff91b60d4ba7e130a53cf2fe928.


It seems that memory leak occurs when image-api-go is called.

I replace the web-port imageHandler func with the following code, to make it easier to observe(making more requests on one click).  The memory usage of image-api-go is keeping growing when click classify.
type mock struct {}

func (m *mock)WriteHeader(statusCode int) {
}

func (m *mock)Header() http.Header {
	return nil
}
func (m *mock)Write(b []byte) (int, error) {
	return len(b), nil
}

func imageHandler(w http.ResponseWriter, r *http.Request) {
	println("imageHandler ....")
	body, err := ioutil.ReadAll(r.Body)

	if err != nil {
		println("error: ", err.Error())
		panic(err)
	}
	api := r.Header.Get("api")
	if api == "go" {
		daprClientSend(body, w)
		for i:=0;i<10;i++ {
			go func() {
				for i:=0;i<10;i++ {
					daprClientSend(body, &mock{})
				}
			}()
		}
	} else {
		httpClientSend(body, w)
	}
}

Thanks. @q82419 Can you look into this? It appears that the TF host function call has a memory leak. Thanks.

I think I can find the reason.
Let me fix on 0.9.0-rc1 in next week. Thanks.

Hi @chenyukang ,
I think the life-cycle in go may cause memory issue.
It's proper to use conf.Delete() directly after VM creation rather than use defer here,
And use vm.Delete() directly after VM execution rather than use defer here.
And the import objects created here should call the Delete() methods after VM deleted.
For the wasmedge_tensorflow_interface rust crate, I fixed the memory issue in rust and you can use the 0.2.2 version.
But after all, the memory leak in rust which will be compiled into WASM will all disappear after VM deletion.
I've overviewed the WasmEdge-Tensorflow and I cannot find the un-deallocated objects now.
Maybe we can look into and find the reason in the future, and the following graph shows that it's better after the adjustment:

Thanks.

I closed this issue since pr #20 is merged. Feel free to reopen this issue, if there is anything wrong. @Taction


fix(gui): return actual size of videos

This was introduced in #188 and overlooked.

We should think about renaming the video{1,2}Frames variables to something like video{1,2}DiffFrameIndices to prevent misunderstandings. the arrays dont actually contain the frames, they contain frame indices according to the diff sequence :)

yes, maybe we could cover that in a refactor ticket next sprint


Fixed EMAConfig on line 1103.

Before submitting

[ no] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
[ yes] Did you read the contributor guideline?
[ no need for an update] Did you make sure to update the docs?
[ no need] Did you write any new necessary tests?

What does this PR do?
Fixes # (issue).
Fixed the metadata on line 1103 the help key was not in quotes.
I found this through my compiler which kept giving me this error
File "/home/disk1/q/main.dist/fairseq/dataclass/configs.py", line 1103, in EMAConfig
    default=False, metadata={help: "store exponential moving average shadow model"}

NameError: name 'help' is not defined

I then opened up the script in VSC and discovered the quotes where forgot so I just added them in and now it works. :)
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
Yup!

Just wondering what the status of this pr. :)


infra: improve release workflows

Description
Add refinements for release/prerelease workflows:

auto-changelog is taken out of release-it lifecycle: it doesn't update the file when called after the version bump, and is only needed for latest releases, so the command is moved to create-release.yaml as a separate step
tail -1 is added to the workflow step that retrieves the next version, to avoid capturing WARNINGs
GITHUB_TOKEN and RELEASE_BRANCH variables are moved to the workflow env, to avoid duplications

Codecov Report

Merging #42 (db117ec) into main (becf274) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   96.37%   96.40%   +0.03%
==========================================
  Files          28       28
  Lines         578      582       +4
  Branches      132      135       +3
==========================================
+ Hits          557      561       +4
  Misses         19       19
  Partials        2        2

Impacted Files
Coverage Δ

src/translator/regex.js
100.00% <ø> (ø)

mocks/roam.js
100.00% <100.00%> (ø)

src/translator/createTEX.js
90.77% <100.00%> (+0.22%)
:arrow_up:


Update fancy UI to only start the clock on tests when they start executing.

I'm not sure what we should do with tests that haven't started executing yet. One option is to keep them in the same window as the executing tests, but to change the counter to a word that represents the state. These would then sort below the currently-executing tests in the window.
Another option is to summarize this information somewhere else and to not have waiting tests listed in the executing window.
I guess we'll just have to see which looks betters.
Definition of Done

[ ] CHANGELOG.md updated.
[ ] Issue is in the correct milestone.

Depends on #64.

I'm not sure what we should do with tests that haven't started executing yet.
I gave it some thought and I'm not sure what to do about them either.
Mixing them in with the running jobs I don't like that much mostly because to me it weakens the meaning of the running dialog.
Having their own dialog for them can really clutter things and the way the viewport is we don't have a ton of vertical space.

I think maybe it needs more thought / discussion about the situation where we want to know which jobs are pending, so I wish to split out some other issue for dealing with that and close this one.


Shutdown issue

Thank you so much for the detailed guide.
I am new to hackintosh.... I’m lucky that I have exact same laptop as you.... so I just copy your open core and almost everything works right.
Only one issue is that x1c won’t shutdown or reboot. After clicking shutdown or reboot in macOS, x1 turn off the screen but it will not power off. I have to hold down the power bottom for couple seconds to force it.
Is there any solution for open core?
Thanks

Hmm that's wierd. Are you using the same BIOS version as I do (1.45)? This is important as different BIOS versions can mess withe the ACPI patches. You could also try enabling verbose boot, so you see exactly where the shutdown gets stuck

thank you for the guide.
I just found that my BIOS is 1.46 and seems Lenovo only provide 1.48 version now and it requires Windows.
If I have to live with 1.46 BIOS, which ACPI should I amend?
I will try verbose boot and report back

ACPI is not really a field that I'm very familiar with. I mainly incorporate the patches done by @tylernguyen for the x1c6, after extensive testing. The machines are almost identical an he's way better at this stuff than I am. If he updates his BIOS I will push the changes here as well after I tested them.
However I'm afraid I can't really help you, as I lack the time and the knowledge to reallly dive into it

@marioeva Can you please dump your unpatched ACPI? I can try and take a look.

@marioeva Can you please dump your unpatched ACPI? I can try and take a look.

You are so nice, much appreciated.
Please see attached system report and EFI ( which is copied from here)
EFI.zip
SysReport.zip

@marioeva
I diff your EFI against mine and on first glance, it doesn't look much different and shouldn't cause any problems. Could you try removing/disabling your network card?

I used open core 0.59, all default setting, then copy your kext and apci. Now 80% of time the issue is fixed.. For remaining 20% of time, the machine reboots instead of shutdown.
Its not perfect but I can live with in
Thank you both again for the help

@marioeva
The issue in question is fixed by https://github.com/tylernguyen/x1c6-hackintosh/blob/master/patches/SSDT-EXT1-FixShutdown.dsl
Make sure that your ACPI patches are loaded in the correct order.
You need to patch USB properly. It is likely that the x5 has a different usb mapping than the x6.

Thank you.


[Backend System] Build out Services

Backend System Info

RFC
Overview Issue
Milestone

Service Tasks
Tasks related to building out service definitions and implementations.

[x] Service corresponding to app-backend is missing, may need new capabilities added to the backend-app-api? Implement the possibility to configure a single root fallback? I.e. /* -> /api/app/*
[x] Logger: Winston “compatible” BS Logging implementation or winston directly, research pros/cons, #15245
[x] Cache
[x] Database
[x] Config - if we want more methods we'll extend the interface
[x] Discovery
[x] HttpRouter

[x] Figure out how to handle root middlewares and middleware configuration in general. Might be an additional root scoped http service, or some other solution. Exploration ongoing in mob/root-http-service-experiments, #15462

[x] Permissions
[x] Scheduler
[x] ~UrlReader® - needs easier configuration methods~~
[x] Suffix all service interface definitions with *Service, #15237
[x] Move all helpers that we want to deprecate to backend-common, for example loggerToWinstonLogger

[x] loggerToWinstonLogger, #15529

[x] Remove backend-common dependency from backend-plugin-api
[ ] Potentially rename some core services with a Legacy* prefix for the ones we want to replace?

Low priority tasks

[ ] Deprecation path for @backstage/backend-common, needs replacement:

[ ] Context
[ ] Discovery
[x] Logging #15688
[ ] Middleware
[ ] Reading
[ ] Scm
[x] Service #15589
[ ] Tokens
[ ] ContainerRunner
[ ] Other utils
[x] Config loading #15688
[ ] Path/URL utils -> maybe move to backend-plugin-api?

[ ] FetchService
[ ] Remove backend-common dependency from backend-app-api

[x] createServiceBuilder #15589
[x] loadBackendConfig #15688
[ ] CacheManager
[ ] DatabaseManager
[ ] DatabaseManager
[x] createRootLogger #15688
[ ] ServerTokenManager
[ ] UrlReaders

[x] Explore options for accessing services in service factory options, i.e. meta factories
[ ] New or evolved services

[ ] Metrics service + exporter and configuration of views
[ ] Explore options for decoupling DatabaseService from Knex
[ ] TokenManager - tweak to handle all kind of identities? Authentication Header Standardization both for producing and consuming the Backstage Token with the claims.

Options for other ORMs

https://github.com/drizzle-team/drizzle-orm
https://www.prisma.io/
https://github.com/kysely-org/kysely

@Rugvip Should this have been allowed to close?

bump

Closing in favor of https://github.com/backstage/backstage/issues/24493


Refactor to allow AddHttpClient, extension method for service collect…

Small changes into OpenAi to allow AddHttpClient pattern and example project for AspNetCore. Additional package is introduce to follow convention from microsoft. LangChain.NET.NetCore should be introduce to nuget.

@CrazyBaran PR looks great 👌 looks like the tests are failing though 🤔

@jeastham1993 Yep I can see. Try to follow, whats wrong.

I dont know what this Rider do here, but right now should be good.


Upgrade to ESLint

JSHint is old news and doesn't handle ES6 syntax very well. Upgrade to ESLint.

I was going to take a stab at this, but have you seen the esnext flag in jshint 2?
Stack Overflow mention
What would you prefer?

My choice would be ESLint.  JSHint is lacking the extension mechanism. ESLint has the widest support for ES6 features JSHint is pretty basic ES6 support. ESLint also has custom rule support which can turn out to be pretty cool

The esnext flag doesn't work very well unfortunately. It still has trouble handling things like block scoping. I was going to start with the following ESLint file. I think there's a few style things I wanted to change/add, but this is a good starting point (just remember to do an ESLint reset before running).
{
	"ecmaFeatures": {
		"arrowFunctions": true,
		"blockBindings": true,
		"classes": true,
		"defaultParams": true,
		"destructuring": true,
		"modules": true,
		"objectLiteralComputedProperties": true,
		"objectLiteralShorthandMethods": true,
		"objectLiteralShorthandProperties": true,
		"templateStrings": true,
		"jsx": true
	},

	"env": {
		"browser": true // override with `node` for Node linting
	},

	"rules": {
		"comma-dangle": [2, "never"],               // disallow trailing commas
		"no-cond-assign": [2, "always"],            // disallow assignment in conditional expressions
		"no-console": [2, true],                    // disallow use of console
		"no-debugger": [2, true],                   // disallow use of debugger
		"no-dupe-args": [2, true],                  // disallow duplicate arguments in functions
		"no-dupe-keys": [2, true],                  // disallow duplicate keys when creating object literals
		"no-duplicate-case": [2, true],             // disallow a duplicate case label
		"no-empty": [2, true],                      // disallow empty statements
		"no-empty-class": [2, true],                // disallow the use of empty character classes in regular expressions,
		"no-ex-assign": [2, true],                  // disallow assigning to the exception in a catch block
		"no-extra-boolean-cast": [2, true],         // disallow double-negation boolean casts in a boolean context
		"no-extra-semi": [2, true],                 // disallow unnecessary semicolons
		"no-func-assign": [2, true],                // disallow overwriting functions written as function declarations
		"no-inner-declarations": [2, true],         // disallow function or variable declarations in nested blocks,
		"no-invalid-regexp": [2, true],             // disallow invalid regular expression strings in the RegExp constructor,
		"no-irregular-whitespace": [2, true],       // disallow irregular whitespace outside of strings and comments
		"no-negated-in-lhs": [2, true],             // disallow negation of the left operand of an in expression
		"no-obj-calls": [2, true],                  // disallow the use of object properties of the global object (Math and JSON) as functions,
		"valid-typeof": [2, true],                  // Ensure that the results of typeof are compared against a valid string,
		"curly": [2, "multi-line"],                 // specify curly brace conventions for all control statements
		"eqeqeq": [2, true],                        // require the use of === and !==
		"guard-for-in": [2, true],                  // make sure for-in loops have an if statement
		"no-alert": [2, true],                      // disallow the use of alert, confirm, and prompt
		"no-caller": [2, true],                     // disallow use of arguments.caller or arguments.callee
		"no-empty-label": [2, true],                // disallow use of labels for anything other then loops and switches
		"no-eval": [2, true],                       // disallow use of eval()
		"no-extend-native": [2, true],              // disallow adding to native types
		"no-extra-bind": [2, true],                 // disallow unnecessary function binding
		"no-implied-eval": [2, true],               // disallow use of eval()-like methods
		"no-iterator": [2, true],                   // disallow usage of __iterator__ property
		"no-labels": [2, true],                     // disallow use of labeled statements
		"no-lone-blocks": [2, true],                // disallow unnecessary nested blocks
		"no-loop-func": [2, true],                  // disallow creation of functions within loops
		"no-multi-str": [2, true],                  // disallow use of multiline strings
		"no-native-reassign": [2, true],            // disallow reassignments of native objects
		"no-new": [2, true],                        // disallow use of new operator when not part of the assignment or comparison
		"no-new-func": [2, true],                   // disallow use of new operator for Function object
		"no-new-wrappers": [2, true],               // disallows creating new instances of String,Number, and Boolean
		"no-octal": [2, true],                      // disallow use of octal literals
		"no-octal-escape": [2, true],               // disallow use of octal escape sequences in string literals, such as var foo = "Copyright \251";
		"no-proto": [2, true],                      // disallow usage of __proto__ property
		"no-redeclare": [2, true],                  // disallow declaring the same variable more then once
		"no-return-assign": [2, true],              // disallow use of assignment in return statement
		"no-void": [2, true],                       // disallow use of void operator
		"no-with": [2, true],                       // disallow use of the with statement
		"radix": [2, true],                         // require use of the second argument for parseInt()
		"wrap-iife": [2, true],                     // require immediate function invocation to be wrapped in parentheses,
		"strict": [2, "never"],                     // controls location of Use Strict Directives
		"no-delete-var": [2, true],                 // disallow deletion of variables
		"no-shadow-restricted-names": [2, true],    // disallow shadowing of names such as arguments
		"no-undef": [2, true],                      // disallow use of undeclared variables unless mentioned in a /*global */ block
		"no-undef-init": [2, true],                 // disallow use of undefined when initializing variables
		"no-unused-vars": [2, {                     // disallow declaration of variables that are not used in the code
			"vars": "all",
			"args": "none"
		}],
		"no-use-before-define": [2, true],          // disallow use of variables before they are defined

		// Style Enforcement
		"indent": [1, "tab", { "indentSwitchCase" : true }],
		"brace-style": [1, "1tbs"],
		"comma-spacing": [1, { "before": false, "after": true }],
		"comma-style": [1, "last"],
		"key-spacing": [1, { "beforeColon": false, "afterColon": true }],
		"new-cap": [1, { "newisCap": true, "capIsNew": false }],
		"no-array-constructor": [1, true],
		"no-mixed-spaces-and-tabs": [1, "smart-tabs"],
		"no-multiple-empty-lines": [1, { "max": 1 }],
		"no-new-object": [1, true],
		"no-spaced-func": [1, true],
		"no-trailing-spaces": [1, true],
		"one-var": [1, "never"],
		"quotes": [1, "single"],
		"semi": [1, "always"],
		"space-after-keywords": [1, "always"],
		"space-before-blocks": [1, "always"],
		"space-before-function-paren": [1, "never"],
		"space-infix-ops": [1, true],
		"space-return-throw-case": [1, true],
		"spaced-line-comment": [1, "always"],

		"no-var": [2, true],
		"object-shorthand": [1, true]
	}
}


Mutliple resposne:WriteHeader calls.

Using this code:
package main

import (
	"net/http"

	"github.com/go-zoo/bone"
)

func idex(w http.ResponseWriter, r *http.Request) {
	w.Header().Set("Content-Type", "application/vnd.api+json")
	w.Write([]byte("This is the index page!\n"))
}

func main() {
	mux := bone.New()
	mux.Get("/", http.HandlerFunc(idex))
	http.ListenAndServe(":8080", mux)
}

This is the output of a curl call:
> curl -I localhost:8080//
HTTP/1.1 302 Found
Location: /
Date: Thu, 08 Oct 2015 08:05:28 GMT
Content-Length: 19
Content-Type: text/plain; charset=utf-8

The problem here is that the Content-Type can't be set. The go application prints out:
2015/10/ 08 10:05:28 http: multiple response.WriteHeader calls

After googling this for a little it seems that once you have written to the header once, later writes will
not work. The code above works using the default mux. Quickly searching through the codebase hints that this part:
https://github.com/go-zoo/bone/blob/e63596ff159b4354ee470d619f949c9f2dc959c6/helper.go#L67-L68
Might be the problem. I hope that I have included enough information to reproduce.

Sorry for being sooooooo stupid!
I realized a second after I did this that using the -I option on curl was messing things up. Again, I am sorry for the inconvenience :(


Ignore meta characters in substring

Supersedes #5

Thanks a lot, this has been merged into master and 0.10.1 has been released.

Thanks for the quick response. Will update my depending projects then :)


BufferEncoding global incorrectly documented

Version: Deno 1.38.5
type BufferEncoding =
    | 'ascii'
    | 'utf8'
    | 'utf-8'
    | 'utf16le'
    | 'ucs2'
    | 'ucs-2'
    | 'base64'
    | 'base64url'
    | 'latin1'
    | 'binary'
    | 'hex';

This is available on the NodeJS global when using the @types/node package (https://docs.deno.com/runtime/manual/node/npm_specifiers/#including-node-types).
function example(encoding: NodeJS.BufferEncoding) {
}

I moved this issue to the docs repo becacuse it incorrectly says to import it from the node:buffer module as @hallvors pointed out.

The docs still reference importing from node:buffer, which still doesn't work.


Opened cli.js when calling mac's vscode from orbstack

Describe the bug
Title
To Reproduce
Steps to reproduce the behavior:

/mnt/mac/opt/homebrew/bin/code config.txt

Expected behavior
Open config.txt
Screenshots

Logs
Attach log files by opening OrbStack's Help menu and clicking “Show Logs”, or email them for privacy.
PLEASE ATTACH THE ENTIRE LOG FILE WITHOUT REMOVING ANY LINES. There is usually important context earlier in the log.
Info report

<paste here>

Additional context
Add any other context about the problem here.

Fixed for the next version. As a workaround, run code instead of /mnt/mac/opt/homebrew/bin/code.

Fixed for the next version. As a workaround, run code instead of /mnt/mac/opt/homebrew/bin/code.

code build.gradle.kts
exec: "code": executable file not found in $PATH

After adding homebrew to vm's path, I encountered the same issue

Is /opt/homebrew/bin in your Mac PATH? Is your terminal profile's shell different from your user's login shell? It should get the PATH from your shell automatically.

Fix released in v0.14.0. Sorry, this release was in testing for much longer than expected and bug fixes also got held up.


CASMNET-1541 - Add 4 port 1G OCP card nodes and bugfixes

Summary and Scope

Change gateway nodes from 4 port 25G cards to 4 port 1G OCP card.
Add dvs and ssn nodes as 4 port 1G OCP card nodes.
Change large memory node common name from lm to lmem.
Read SHCD cell data values only, not values and formulas.
Change switch interface/port descriptions from src:slot:port==>dst:slot:port to dst:slot:port==>src

PR checklist (you may replace this section):

[x] I have run nox locally and all tests, linting, and code coverage pass.
[x] I have added new tests to cover the new code
[x] My code follows the style guidelines of this project
[x] If adding a new file, I have updated pyinstaller.py
[x] I have updated the appropriate Changelog entries in readme.md
[x] I have incremented the version in the readme.md
[x] I have incremented the version in canu/.version and .version

Issues and Related PRs

Resolves CASMNET-1541

Testing
Tested on:

Two large customer systems.

Still missing architectural definition between river_ncn_leaf and river_ncn_node_4_port_1g_ocp.

Still missing architectural definition between river_ncn_leaf and river_ncn_node_4_port_1g_ocp.

@coreyjjohnson there are no 1G connections on a river_ncn_leaf.  We can either have 25/40 connections or 1G connections but otherwise having any:any just throws PoR out the door.  Originally we had thought for gateways that 25/40G cards, but in practical use (ie. customer systems) gateways are 1G connections.  So we're changing the model.


[Dubbo-issue2352][Baiji-8]Add util tests for HeaderExchangeChannel.

What is the purpose of the change
Fix #2352
Brief changelog
Add HeaderExchangeChannel.java
Verifying this change
Add some until tests for HeaderExchangeCHannel.
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b4db875). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2369   +/-   ##
=========================================
  Coverage          ?   54.85%
  Complexity        ?     5260
=========================================
  Files             ?      573
  Lines             ?    25426
  Branches          ?     4513
=========================================
  Hits              ?    13947
  Misses            ?     9378
  Partials          ?     2101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4db875...6bbb5a9. Read the comment docs.

Please focus on #2387


modify some names and comments in edmf

Purpose

To-do

Content

[ ] I have read and checked the items on the review checklist.

bors r+

bors r+

bors r+


Error: Unable to find a subscription.

Miniflux says "Unable to find a subscription." when i try to add the next rss/xml:
http://argenteam.net/rss/portal_movies_subtitles.xml
This is the debug.log file:
[2016-12-14 04:48:51] PicoFeed\Client\Curl Fetch URL: http://argenteam.net/rss/portal_movies_subtitles.xml
[2016-12-14 04:48:51] PicoFeed\Client\Curl Etag provided:
[2016-12-14 04:48:51] PicoFeed\Client\Curl Last-Modified provided:
[2016-12-14 04:48:51] PicoFeed\Client\Curl cURL total time: 0.518502
[2016-12-14 04:48:51] PicoFeed\Client\Curl cURL dns lookup time: 0.000151
[2016-12-14 04:48:51] PicoFeed\Client\Curl cURL connect time: 0.257392
[2016-12-14 04:48:51] PicoFeed\Client\Curl cURL speed download: 3650
[2016-12-14 04:48:51] PicoFeed\Client\Curl cURL effective url: http://argenteam.net/rss/portal_movies_subtitles.xml
[2016-12-14 04:48:51] PicoFeed\Client\HttpHeaders HTTP status code: 200
[2016-12-14 04:48:51] PicoFeed\Client\HttpHeaders HTTP header: Date => Wed, 14 Dec 2016 04:49:35 GMT
[2016-12-14 04:48:51] PicoFeed\Client\HttpHeaders HTTP header: Server => Apache-Coyote/1.1
[2016-12-14 04:48:51] PicoFeed\Client\HttpHeaders HTTP header: X-Grails-Cached => true
[2016-12-14 04:48:51] PicoFeed\Client\HttpHeaders HTTP header: Content-Type => application/rss+xml;charset=ISO-8859-1
[2016-12-14 04:48:51] PicoFeed\Client\HttpHeaders HTTP header: Vary => Accept-Encoding
[2016-12-14 04:48:51] PicoFeed\Client\HttpHeaders HTTP header: Content-Encoding => gzip
[2016-12-14 04:48:51] PicoFeed\Client\HttpHeaders HTTP header: Content-Length => 1893
[2016-12-14 04:48:51] PicoFeed\Client\HttpHeaders HTTP header: Connection => close
[2016-12-14 04:48:51] PicoFeed\Reader\Reader: Try to discover subscriptions
[2016-12-14 04:48:51] PicoFeed\Reader\Reader:

Someone can confirm? Thanks

The feed seems malformed and indicate an invalid RSS version: 0.94.

Too bad, thanks.


Composite endecs should rethrow exceptions with more detail

Currently most composite endecs just pass on exceptions, making it hard to figure out where the exception even originated from.
Ideally, they should rethrow exceptions and provide context on where the exception is coming from (e.g. StructField should specify the name of the field)

Should be done with the latest version of endec 0.1.4


Add fix for UnobservedTaskException when server Unavailable

Checks the status code for Unavailable and observes the exception to avoid GC Finalizer from throwing it.
Fixes #24421
@jtattermusch

Fix would need to be done against v1.46.x now that https://github.com/grpc/grpc/pull/29225 has been merged.

Note: With the Grpc C# implementation being placed into maintenance mode, this PR will actually need to be remade for 1.46.x. We can complete the majority of the review here first before moving it.


Confusing documentation around scopes

The documentation can be pretty confusing when it comes to scopes.
Take for example the page covering /approot. It mentions the Files.ReadWrite.AppFolder Graph scope in the first paragraph but switches without context to referencing onedrive.appfolder and onedrive.readwrite. Unless the reader happens to stumble upon the very last section of the OneDrive endpoint page, they could become very easily confused. Even if they did read that section, they wouldn't know that Files.ReadWrite.AppFolder is only supported for MSAs if they looked at the remarks in the Graph documentation.
It would be helpful to have some standardized Permission Scopes format. The standardization picked up by the Microsoft Graph doc set certainly isn't ideal, but it was a reasonable attempt to provide some standardization:

Permission type
Permissions (from least to most privileged)

Delegated (work or school account)
scope 1, scope 2, etc

Delegated (personal Microsoft account)
Not supported.

Application
scope 1, scope 2, etc

Would something like this make sense?

Permission type
Microsoft Graph
OneDrive Personal
SharePoint and OneDrive for Business

Delegated (AAD)
Files.ReadWrite.AppFolder
Not Supported
Files.ReadWrite.AppFolder

Delegated (MSA)
Not Supported
OneDrive.AppFolder
Not Supported

Application
Files.ReadWrite.AppFolder
Not Supported
Files.ReadWrite.AppFolder

Just spent a whole day on this. I just used onedrive.appfolder for authorization, but always got an "InvalidAuthenticationToken" error when querying /me/drive/special/approot:
{
  code: 'InvalidAuthenticationToken',
  message: 'CompactToken parsing failed with error code: 8004920A',
  innerError: {
    'request-id': 'dcf5c100-fe8c-4603-9b29-0b4b25a66ca1',
    date: '2019-09-20T13:00:13'
  }
}

The error message makes me think that the token is messed up when sending the request. I didn't notice that it is a scope problem.

As part of a repository clean up effort we are closing older issues. If this issue remains, please: open a new issue, reference this issue, and provide any additional details that may help in resolution. Thank you for your understanding as we work to improve our responsiveness.


Way to skip elements (process nonsequentially) in a data flow?

Enhancement 🚀
This is not really an enhancement, but more a question: is there a way to process dataflows non-sequentially? I tried looking through the documentation, searching online, even looking through the source code in deepdoctection/dataflow/common.py. From what I've seen, dataflow only implements the iter methods.
Motivation  💪
I could wait for the iterator, but can that may take minutes at a time.
Alternatives ⚖
I also tried
df = analyzer.analyze(path=path)
y = df[100]

but it didn't work.
Additional context 🧬

Right now, none of the dataflow classes have a __getitem__ - method and I think it will only make sense for those that have a 1:1 correspondence between input and output (e.g. SerializerFiles.load and a few others but not for those that buffer datapoints and process inputs across several threads/processes or that take and one input and yield n outputs).
As long a the analyzer processes pages in a strict sequential manner it could be implemented, though.


Dynamic block forging for the P2P mode

Fixes input-output-hk/ouroboros-network#3159, requires input-output-hk/ouroboros-network#3800.

Updated to a newer version of ouroboros-network
Added blockForging to Protocol type class
Set initial block forging
Added SomeBlockType and reflBlockType
Update block forging configuration on SIGHUP

This work is ongoing.

Closed in favor of https://github.com/input-output-hk/cardano-node/pull/5383#event-9822210243


survey component updating user

Issue 55, calls update user after quiz, I want to do some more testing on it regarding different quiz answers it may have to have some functionality added but it no longer errors so yk thats a plus.

Corrected logic for calculating quiz results


Support query methods on GarageClient::Resource

It would be nice if GarageClient::Resource provided a fluent interface similar to how ActiveRecord allows querying of attributes. The data in a GarageClient::Resource is in a Hashie::Mash, which already provides querying of attributes.
This proposed change passes "query" style methods to the underlying Hashie::Mash.
e.g.
resource.title
# => 'A resource'
resource.title?
# => true
resource.product_id
# => nil
resource.product_id?
# => false

You have to implement #respond_to_missing? when implementing #method_missing (and your commit seems to be based on too old commit).

You have to implement #respond_to_missing? when implementing #method_missing (and your commit seems to be based on too old commit).

Thanks for pointing out! I've updated accordingly.


Refactor AnyView init fromValue implementation

Codecov Report
Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 13.25%. Comparing base (2b39e17) to head (b3e8361).

Files
Patch %
Lines

.../OpenSwiftUI/Core/Runtime/ProtocolDescriptor.swift
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   13.34%   13.25%   -0.10%
==========================================
  Files         185      185
  Lines        4383     4360      -23
==========================================
- Hits          585      578       -7
+ Misses       3798     3782      -16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


init command hangs if no git repo initialized in folder

Bug report
Describe the bug
The init command hangs if no git repo initialized in folder
To Reproduce

Create new folder
Run supabase init

Expected behavior
Prompt the user that git must be initialized in the folder
System information

OS: Windows
Version of supabase-js: 0.15.2
Version of Node.js: 14.4

That's odd, this shows me:
❯ supabase init
Error: Cannot find Git root. Are you in a Git repository?

Most likely a path handling issue, but I don't have a Windows machine to test this.

Can confirm this issue is present on Windows. Running git init solves the issue

Working on a fix- will submit a PR shortly


Saving Journal Width

Currently you can resize the journal's width with the jewel in the corner, but it needs to be done each time you relog.

Pull-Request
https://github.com/bittiez/ClassicUO/pull/14

Added #19


Have the backend return thoughts that are presorted, no hardcoding columns

The frontend of RetroQuest does a lot of sorting and filtering on the array of thoughts and is really slow at doing this. When 4 people are using app at the exact same time I noticed the UI slow down and start to lag because of all of this frontend processing.
In order to fix this, sorting should happen on the backend and the frontend is just a presentation layer. This restructure of the code is actually quite huge because it hits the meat and potato portions of the app.

The work on this has been completed and needs to be reviewed with @abarna10 because he has the magic touch when it comes to bugs in codebases ;).

This has been completed but I did find some edge cases in dev where if a user ends a retro in one browser, the other browsers don't get theirs visually cleared. I can fix this easily.

Upon futher testing of prod I realized that this bug exists in prod too so it's not apart of this PR, nice!


Prep Symbols (scene) for Beta

Description

modularize
update to better viewpoint
replace colors

Checklist:

[ ] Set target branch to main (current release) or v.next (next release)
[ ] Request a reviewer
[ ] Assign a reviewer
[ ] Tag reviewer in comment

@mbcoder please could I get a review?

@Luiy0 second review please


Mobile text width bug

via @ashfurrow
Related: https://twitter.com/aehlke/status/683449465815068672

Should be better now!


Sonoff SNZB-01 button isn't a switch

Zigbee2MQTT version: 1.27.0
Python version: 3.9.13
Domoticz version: 2022.1 build 14360
Plugin version: 3.1.0-beta
As I'm saying this device is a button and not a switch.
The state should  return to off after be pressed, otherwise it's manageable as the button always return the latest status.

Hello,
it's normal, button stay in last state when pushed .
To compensate it, in your favorite domotic program (mine is domoticz) just create a blocly or a script which re-put the button to the "off " state when pushed,  after, per example 1 second.

I'm also working with domoticz. I don't know why my previous script was not working,
but today a new blockly script do what I want. The previous script also included a set to off state.


Text To Speech web page

Prerequisites

[X] I am a GSSoC-22 Participant
[X] I checked to make sure that this issue has not already been filed

Description
I would like to add a web page that features converting text to speech.
Tech Stack
Web Development (HTML,CSS,JS)

@XZANATOL Go for it. Good Luck 👍


Allow proxysql checks to specify stats database name

What does this PR do?
Allow the instance config for the proxysql check to set an alternate database name to run stats queries against.
Motivation
The previosuly-hardcoded stats database is correct if you're connected as an admin user, but doesn't exist if you're connected as a stats-only user.
From a security point of view, it's probably better for datadog to connect as a stats user, since those aren't granted access to sensitive data. The existing checks should all work as a stats user, but for those users the 'stats' database is called 'main' instead.
Additional Notes
The default config for database_name is the same as the previously hardcoded name in the queries, so this should be backwards compatible.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

By the way, I don't appear to have permission to add labels. I'm guessing that's what the "PR Labels / apply" action that failed was supposed to do - if anyone has any thoughts on why it's failing, I'd appreciate it.

Hi @tabacco ,
It seems passing database to pymysql.connect() has no effect. Removing stats. prefix from queries seems enough.
It's possibly due to the fact that stats users (listed in stats_credentials) are limited (defaulted) to stats database.

A user that connects to Admin with admin-stats_credentials credentials can only access this schema.

Any though on this ?

Note: somehow, queries like SELECT * FROM stats_mysql_global also work for admin users (proxy) even though the "selected database" is "admin".
root@4ba27ac178ac:/# mysql -u proxy -pproxy -h proxysql -P6032 --prompt='Admin> '
Admin> select database();
+------------+
| DATABASE() |
+------------+
| admin      |
+------------+
1 row in set (0.00 sec)

Admin> SELECT * FROM stats_mysql_query_rules;
+---------+------+
| rule_id | hits |
+---------+------+
| 1       | 0    |
+---------+------+
1 row in set (0.01 sec)

Well that's interesting. It didn't occur to me to not try specifying the db name. I wonder if that's a byproduct of the fact that proxysql's admin database is actually sqlite.


increase ephemeral-storage for a k8s node

Hi, I'm not sure whether it's me doing sth wrong or it's a bug.
We are using v4.4.2 of this module with

cluster_kubernetes_version = "v1.25.4"
node_pool_image_type            = "oke"
node_pool_os                    = "Oracle Linux"
node_pool_os_version            = "7.9"

and my assumption was that when we pass the following configuration for node_pools
{
  general = {
    shape = "VM.Standard.E4.Flex", ocpus = 8, memory = 16, node_pool_size = 3, boot_volume_size = 500
  }
}

nodes in the general pool should have allocatable 16 CPUs, around 16GB of memory, and around 500GB of storage. However, it's not the case. The allocatable storage size is way lower than 500GB.
k get nodes <MY_NODE> -o yaml

...
status:
  allocatable:
    cpu: "16"
    ephemeral-storage: "37070025462"
    hugepages-1Gi: "0"
    hugepages-2Mi: "0"
    memory: 15985156Ki
    pods: "110"
  capacity:
    cpu: "16"
    ephemeral-storage: 40223552Ki
    hugepages-1Gi: "0"
    hugepages-2Mi: "0"
    memory: 16087556Ki
    pods: "110

...

  nodeInfo:
    architecture: amd64
    bootID: <redacted>
    containerRuntimeVersion: cri-o://1.25.1-111.el7
    kernelVersion: 5.4.17-2136.315.5.el7uek.x86_64
    kubeProxyVersion: v1.25.4
    kubeletVersion: v1.25.4
    machineID: <redacted>
    operatingSystem: linux
    osImage: Oracle Linux Server 7.9
    systemUUID: <redacted>

Does the module allow changing the allocatable.ephemeral-storage size?

Maybe you are lacking ephemeral space by not growing the filesystem at boot time.
If you are customizing the userdata don't forget to add:
adjust block volume size
/usr/libexec/oci-growfs -y
Ref. https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/main/modules/oke/cloudinit/worker.template.sh


FactoryServer.sh unable to execute

Experiencing issues? Check our Troubleshooting FAQ wiki!
Describe the Bug
I'm trying to run this container on Google Compute Engine when I run into an error. run.sh fails when trying to run FactoryServer.sh. Might be related to issues #314 and #320?
/home/steam/run.sh: line 108: ./FactoryServer.sh: Permission denied

Your Runtime Command or Docker Compose File
docker run \
--sig-proxy=false \
--name=satisfactory-server \
--hostname satisfactory-server \
--rm \
--volume ./satisfactory-server:/config \
--env MAXPLAYERS=4 \
--env ROOTLESS=false \
--env STEAMBETA=false \
--env PGID=20166 \
--env PUID=20162 \
--memory 12G \
--publish 7777:7777/udp \
--publish 7777:7777/tcp \
wolveix/satisfactory-server:latest

Debug Output
===== Satisfactory Server 1.8.6 =====
https://github.com/wolveix/satisfactory-server

Debugging enabled (the container will exit after printing the debug info)

Printing environment variables:
declare -x AUTOSAVENUM="5"
declare -x DEBUG="true"
declare -x DISABLESEASONALEVENTS="false"
declare -x GAMECONFIGDIR="/config/gamefiles/FactoryGame/Saved"
declare -x GAMESAVESDIR="/home/steam/.config/Epic/FactoryGame/Saved/SaveGames"
declare -x HOME="/home/steam"
declare -x HOSTNAME="satisfactory-server"
declare -x LANG="en_US.UTF-8"
declare -x LANGUAGE="en_US:en"
declare -x LOG="false"
declare -x MAXOBJECTS="2162688"
declare -x MAXPLAYERS="4"
declare -x MAXTICKRATE="30"
declare -x OLDPWD
declare -x PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
declare -x PGID="20166"
declare -x PUID="20162"
declare -x PWD="/config"
declare -x ROOTLESS="false"
declare -x SERVERGAMEPORT="7777"
declare -x SERVERSTREAMING="true"
declare -x SHLVL="1"
declare -x SKIPUPDATE="false"
declare -x STEAMAPPID="1690800"
declare -x STEAMBETA="false"
declare -x TIMEOUT="30"
declare -x USER="steam"
declare -x VERSION="1.8.6"
declare -x VMOVERRIDE="false"

System info:
OS:  Linux satisfactory-server 6.1.100+ #1 SMP PREEMPT_DYNAMIC Sat Sep 21 16:23:38 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
CPU: Intel(R) Xeon(R) CPU @ 2.20GHz
RAM: 15GB/16GB
HDD: 4GB/16GB (29% used)

Current version:
1.8.6
Current user:
uid=0(root) gid=0(root) groups=0(root)
Proposed user:
uid=20162(?) gid=20166(?) groups=20166(?)

Exiting...

System Specs (please complete the following information):
===== START ISSUE REPORT =====
OS:  Linux satisfactory-server-20240924 6.1.100+ #1 SMP PREEMPT_DYNAMIC Sat Sep 21 16:23:38 UTC 2024 x86_64 Intel(R) Xeon(R) CPU @ 2.20GHz GenuineIntel GNU/Linux
CPU: Intel(R) Xeon(R) CPU @ 2.20GHz
RAM: 15GB/16GB
HDD: 1GB/2GB (60% used)
===== END ISSUE REPORT =====

Logs
satisfactory-server-log-240924.txt
Additional Context
My current user:
$ id
uid=20162(me) gid=20166(me) groups=20166(me),4(adm),27(video),412(docker),20165(google-sudoers)

I've also tried this with PGID=0, PUID=0 but your script doesn't allow for that.
Also tried --ROOTLESS=true --user=20162:20166 but run into permissions denied issues:
$ docker run \
> --sig-proxy=false \
> --name=satisfactory-server \
> --hostname satisfactory-server \
> --rm \
> --volume ./satisfactory-server:/config \
> --env MAXPLAYERS=4 \
> --env ROOTLESS=true \
> --env STEAMBETA=false \
> --env PGID=20166 \
> --env PUID=20162 \
> --user 20162:20166 \
> --memory 12G \
> --publish 7777:7777/udp \
> --publish 7777:7777/tcp \
> wolveix/satisfactory-server:latest
===== Satisfactory Server 1.8.6 =====
https://github.com/wolveix/satisfactory-server

Checking available memory: 15GB detected
Clearing old Satisfactory logs (set LOG=true to disable this)
The current user does not have write permissions for /config

This suggests that there's a permissions issue on the host itself, which the container is unable to resolve. Please verify that your ./satisfactory-server path is correctly owned by your specified PUID/PGID.

I ran sudo chown -R me satisfactory-server but that wasn't the solution. It turns out that the VM image I was using (container-optimized OS / cos-113-18244-151-80) disables execution of scripts and executables by default. I had to remount my disk without noexec for it to work properly. Thanks for the help!

I ran sudo chown -R me:me satisfactory-server but that wasn't the solution. It turns out that the VM image I was using (container-optimized OS / cos-113-18244-151-80) disables execution of scripts and executables by default. I had to remount my disk without noexec for it to work properly. Thanks for the help!

Hey there!
I'm struggling with the exact same issue.  Wondering if I could get some assistance or guidance on this if possible.

@linton1187 Is this a local machine? Can you check if your user is the owner of the ./satisfactory-server folder? I can provide you with commands if you're not familiar.


v16 Tracking Issue

SDK v47 upgrade & migrations
TODO

[x] https://github.com/CosmosContracts/juno/issues/697
[x] https://github.com/CosmosContracts/juno/issues/610
[x] ICQ from StrangeLove
[x] https://github.com/CosmosContracts/juno/pull/730
[x] https://github.com/CosmosContracts/juno/pull/708
[x] https://github.com/CosmosContracts/juno/pull/707
[x] https://github.com/CosmosContracts/juno/pull/706
[x] https://github.com/CosmosContracts/juno/pull/705
[x] https://github.com/CosmosContracts/juno/pull/692
[x] https://github.com/CosmosContracts/juno/pull/689
[x] https://github.com/CosmosContracts/juno/pull/690
[x] Wasm based oracle (OjO)

COMPLETED WOOOO!


Enhance Makefile and add editorconfig

Prerequisites
Put an x into the box(es) that apply:

[ ] This pull request fixes a bug.
[ ] This pull request adds a feature.
[x] This pull request enhances existing functionality.
[ ] This pull request introduces breaking change.

For more information, see the Contributing Guide.
Description
This PR enhances the Makefile and its targets. List of changes:

add help target and colorize the output logs
add verify: Verify vendor dependencies
add fmt and checkfmt for go files formatting
add build-all which builds for all the specified OS/ARCH as well as sha256sum file
add release helper targets: major, minor and patch which auto upgrade version to corresponding logical next version
add tools which installs any required tools for development or CI jobs
add -mod=vendor and make sure the usage of Makefile targets will be universal, no matter if you're running it within GOPATH or outside of it.

Also added .editorconfig file to enforce unified file coding, line ending, tab/space sizes etc on all different IDEs and text-editors.
Added a checkfmt job on the CI pipeline as well to make sure we test code formatting on each PR as well. This means that if that job fails the formatting of go files are incorrect and can be fixed manually or by running make fmt from the root of the repo.
Issues Resolved
Fixes #67
Fixes #88
Checklist
Put an x into all boxes that apply:

[x] I have read the Contributing Guidelines.

Tests

[ ] I have added tests to cover my changes.
[ ] All tests pass when I run make test.

Documentation

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Code Style

[x] My code follows the code style of this project.

@khos2ow thank you for your submission! As I see it, your pull request addresses many diverse things that should be split up into dedicated submissions. Obvious candidates are the .editorconfig (which I find really useful), a new approach to versioning and creating releases, and potentially some more. I'd also like to you to take some time to explain this approach and why we need it.

To be honest I didn't want to create two PRs with only one file change in each (one for editorconfig and one for .golangci.yml), but I'll be happy to extract these to their own PRs if you see fit.
In terms of Makefile refactoring, those are the practices I've gathered over the while and potentially will be really useful. One of the main advantages is that you are not bound to be in GOPATH for the make targets to work (this is my own setup)
The release helper targets will potentially make the release process easier for the maintainers. When the time comes what needs to be done is essentially to decide which version bump is needed. Let's assume we want to go from v0.6.0 to v0.7.0 the only command needed is:
cd /path/to/local/clone
git checkout master
git pull # make sure the master is up to date
make minor push=true

This will bump the version, create a tag with that version and push it to remote.
And potentially the release artifacts can be generated locally with make build-all and manually uploaded to github release page.

@metmajer do you want to proceed with this PR? or any suggestion on breaking it down into smaller PRs?

Yes, I do. Could you please...

Adapt the .editorconfig to reflect the current indentation scheme? Right now, we use tabs, not spaces. Also, why use a tab size of 8 in the Makefile if you otherwise suggest 4 spaces? I suggest we use 4 everywhere.
I am currently not convinced by the semi-automated versioning scheme. I just don't see the benefit over editing the VERSION file manually. Can we remove the versioning magic from this PR for now?

Thanks!

That's true, actually another section should be added in .editorconfig for .go files to enforce tab, although gotfmt already takes care of this, but that should've been added.

The reason I specifically set tab size of 8 for Makefile was to get the correct visual alignment. Because most of the editors consider tab size of 4 instead of actual 8. Consider the following for tab size of 4 and 8 for Makefile:

IMO maintaining current version of binary in VERSION file is both redundant and error prone. Considering that we're releasing through git tags, and those are predictable and discoverable (programmatically) we don't really need to capture the same thing in a file.
And also the process of releasing a new version will be slightly harder if we do have such a file. Maintainer needs to bump the version in that file, commit and push it, and then tag the branch.
To be fair, if we choose to keep the VERSION file, it will still be easier to execute a make target (such as make minor) which does all the above rather than do them manually.

added .go in .editorconfig and set a tab size of 4 for it.
moved long script from Makefile to their own external files and removed the tab size of 8 for Makefile.

Thanks for applying the changes, @khos2ow. Meanwhile, I have added some additional feedback. Aside, please...

Rename the directory „hack“ to „scripts“.
Should we invoke git-chglog as part of a release? Until now, I have used the Git commit message „Update Changelog.“, but it shows up in the Changelog itself. We should check, if specific (this) commit messages can be excluded in the git-chglog config. Can you look into this?

Should we invoke git-chglog as part of a release?

I really like the idea, it can be done in scripts/release/release.sh right after git tag --annotate ...., so immediately after releasing a tag we can generate and update CHANGELOG and push it too.

I totally agree with you on handling the brew formula update in a different PR, but a new release target should include an update of the Changelog. The updated Changelog should be contained in the tag, too.

I just revisited the doc of git-chglog and the easiest (and cleanest) way we can do, from now on, is to prefix commit with keywords, such as feat:, fix:, doc:, ... and only generate the changelog for subset of them. The changelog config of the git-chglog itself looks like this:
options:
  commits:
    filters:
      Type:
        - feat
        - fix
        - perf
        - refactor
  commit_groups:
    title_maps:
      feat: Features
      fix: Bug Fixes
      perf: Performance Improvements
      refactor: Code Refactoring
  header:
    pattern: "^(\\w*)\\:\\s(.*)$"
    pattern_maps:
      - Type
      - Subject

So instead of doing crazy hack to exclude Update Changlog commit, we can follow the convention mentioned above. What do you think about this approach Martin?

The problem with the approach you‘ve mentioned is that this project has never followed structured commits. This is why our current git-chglog looks the way it is. If we were to introduce these groups now, old commit messages would not be shown anymore. Is there no easier approach? What if we check for and ignore that commit message in the template? Also, I am not a fan of structuring commit messages. Thoughts?

Also, this hack can‘t be crazier than your version number hack in the Makefile 😀

Oh I see. I'm trying to see if I can make the config work to be able to generate the old commit message and generate new format from now on. If not successful manually remove the "Update Changelog" from the list.

Ok I've managed to make changelog both backward and forward compatible:

it keeps the previous changlog records intact
it considers <type>: <subject> as the new commit format (the same as git-chglog's Changelog itself)

@metmajer how do you want to proceed with this?

Awesome! That‘s the approach we need. Will you make your changes part of this PR? If we require specific commit message prefixes, we may have to amend CONTRIBUTING.md. Hm?

I think PR of its own would be better, because it will change .chglog/* and as you mentioned CONTRIBUTING.md

Agree that we don‘t need to change CONTRIBUTING.md. If you already have a Changelog template available, I‘d really prefer to have it in here to complete the release target. If more work will be needed, let‘s conclude the PR here and add the template in an upcoming PR very soon.

This commit 280835e will solve the template, but I prefer to have it in its own PR. If you feel like this is the correct place for it just proceed with this PR, otherwise let me know to revert that and open its own PR.

There's only one gotcha point, that we have to start using the new format for commit message <type>: <subject> from start of the next release, otherwise the changelog for current release (v0.7.0) might get corrupted.