Use with rollup directly

Hi all,
I'm not a ViteJS user, however I am a user of rollup, and more precisely of rollup-plugin-vue which is now archived and says to move to Vite.
Since I don't want to migrate my whole build process from Rollup to Vite, I asked the Rollup team if they would consider internalizing a fork of rollup-plugin-vue. They politely said no and told me to try using this Vite plugin in Rollup directly since the interfaces are very similar.
Basically, I am wondering if I could use this plugin as a Rollup plugin to replace<EMAIL_ADDRESS>which is the latest version compatible with Vue 2. And if so, how?
I tried to replace it in my config:
      vue({
        template: {
          transformAssetUrls: false
        },
        style: {
          preprocessOptions: {
            scss: {
              sourceMap: options.sourceMaps,
              includePaths: [projectDir.path('./node_modules/')]
            }
          }
        }
      })

But if fails with the following error:
Error [RollupError]: Expected a pseudo-class or pseudo-element.
    at error (/Users/me/myproject/node_modules/rollup/dist/shared/rollup.js:206:30)
    at Object.error (/Users/me/myproject/node_modules/rollup/dist/shared/rollup.js:23499:20)
    at Object.error (/Users/me/myproject/node_modules/rollup/dist/shared/rollup.js:22765:42)
    at /Users/me/myproject/node_modules/@vitejs/plugin-vue2/dist/index.cjs:990:21
    at Array.forEach (<anonymous>)
    at transformStyle (/Users/me/myproject/node_modules/@vitejs/plugin-vue2/dist/index.cjs:982:19)
    at transform (/Users/me/myproject/node_modules/rollup/dist/shared/rollup.js:22743:16)
    at ModuleLoader.addModuleSource (/Users/me/myproject/node_modules/rollup/dist/shared/rollup.js:22949:30) {
  id: '/Users/me/myproject/app/windows/preferences/components/displayName.vue?vue&type=style&index=0&scoped=53dbc385&lang.scss',
  hook: 'transform',
  code: 'PLUGIN_ERROR',
  plugin: 'vite:vue2',
  watchFiles: [
    '/Users/me/myproject/app/windows/preferences/index.js',
    '/Users/me/myproject/app/windows/preferences/components/emailList.js',
    '/Users/me/myproject/app/lib/content/vue_components/tabs.js',
    '/Users/me/myproject/app/windows/preferences/components/displayName.vue',
    '/Users/me/myproject/app/windows/preferences/components/deviceList.js',
    '/Users/me/myproject/app/windows/preferences/components/settings.vue',
    '/Users/me/myproject/app/windows/preferences/components/logList.js',
    '/Users/me/myproject/app/windows/preferences/components/filetypesWhitelist.vue',
    '/Users/me/myproject/app/lib/content/vue_components/askQuestionModal.vue',
    '/Users/me/myproject/app/lib/content/vuex_base_stores/askQuestionStore.js',
    '/Users/me/myproject/app/extensions/extensionsList.vue',
    '/Users/me/myproject/app/lib/content/i18n-loader.js',
    '/Users/me/myproject/app/extensions/index.js',
    '/Users/me/myproject/app/lib/content/windowUtils.js',
    '/Users/me/myproject/app/lib/content/externalLinks.js',
    '\x00plugin-vue2:normalizer',
    '/Users/me/myproject/app/windows/preferences/components/displayName.vue?vue&type=style&index=0&scoped=53dbc385&lang.scss'
  ],
  consumed: true
}

Anyone knows if it's worth a harder try?

I have ported this plugin to unplugin, so it may work in rollup. Here it is: https://github.com/so1ve/unplugin-vue2. If you are interested in it, please try it out and feedback. Any bug report is welcome!

We were able to swap out rollup-plugin-vue for @vitejs/plugin-vue2 on our project without making other changes, but we didn't have any extra config in ours.
Here's our current Rollup config: https://gitlab.com/gitlab-org/gitlab-docs/-/blob/main/rollup.config.js
And here's the PR where we made the change: https://gitlab.com/gitlab-org/gitlab-docs/-/merge_requests/3842
However, after doing this, CSS in <style> blocks in our components no longer gets included in the JS bundle (same as this).
Sounds like that behavior can be changed by using a Build Option, but I haven't be able to get that sort of config option working when using it directly with Rollup. Suggestions welcome if anyone knows how to do this! For now we're just writing CSS elsewhere.

Hi @sarahg were you ever able to solve the CSS issue? I recently tried a fresh project with Rollup+vite-plugin-vue2 and also found that my css files were saved as chunks like "output-9c1fc18a.css" but not included or injected into the JS bundle.
I'm not a power user but I wonder if the name of the css file gets passed to other plugins in the chain and if a custom hook could be made to take that css file and inject it.

@derrickb I didn't dig into it further, no, we've just stopped writing CSS styles in our Vue files and bundle it elsewhere. Not ideal, but it works fine. We have limited resources on this project, so we're focused more on getting from Vue 2 to Vue 3 rather than solving this one.

@sarahg I have some good news and was planning to reply here to let you know: the bundling/inject works if using the postcss plugin!
import vue from '@vitejs/plugin-vue2';
import postcss from 'rollup-plugin-postcss';

//in your plugins array:
plugins: {
  vue(),
  postcss({
    extract: false //or true
  })
}

What's really nice is the postcss plugin has an extract option which works properly with either true or false values, so you can selectively inject (false) or extract to a .css file (true) depending on your needs.


Adding a License

Hi,
I would like to use your code for a project. Would it be possible to either have a license added or get permission to use your code?
Thank you.

I've added a license - I consider this to be in the public domain, so do with it what you wish.


Remove jQuery

This really isn't an issue per se, but more of a question: Would @buschtoens be ok with a PR removing jQuery?
It looks like it's only used in a few spots:

Managing some mouse event listeners in lt-column-resizer
Getting some various widths (.width(), .outerWidth())
Class toggling
Parent/Closest dom traversal
Outdated blueprint code

The only someone tricky thing is the usage of the .closest and the computed $column property used in lt-column-resizer
I'd be happy to do this, just wanted to make sure I wasn't missing any sort of big ticket issues.

Yes


GitHub homepage for Vienna links to the wrong website

The project homepage on GitHub links to www.vienna-rss.org,  which is a very dodgy looking coupons site, instead of www.vienna-rss.com. The first time I came across Vienna I went to the coupons site and needlessly got very concerned about the legitimacy and safety of the app. It'd be good to have the link fixed. Thanks for a great app!

Thank you, I'll change It shortly :)

All done!


chore: Migrate OsConfig to OwlBot

A lot of new files. The changes in old files seem OK.

I manually tested the owlbot.py.


How to move a image in all directions (left, right, top, bottom) ?

Hey, I tried to move an centered image, but its only moving left or right... how to move top and bottom ?
I want to move the centered image to the top with 25% padding(gap) from top.

Hi, can you clarify what you’re trying to do with some code?
It sounds like you’re going to want to create a new blank image (with
appropriate padding) and overlay the existing on.

$image
	->fromFile('img/base.png')	// load image
	->overlay('img/overlayimage.png','center')
	->toFile('output/filename.png');

I had a base.png which is a background image and i want to overlay a image on it. I want it to be centered in y-axis and i want to move the overlay image to top in on x-axis ( if its css we something like margin -100px ). Check the attached image you will understand clearly.

Try using overlay with offsets:
// Variables used for clarity
$anchor = 'center';
$opacity = 1;
$xOffset = 0;
$yOffset = -100;

$image->overlay($overlay, $anchor, $opacity, $xOffset, $yOffset);

I missed using $opacity field so the overlay image output is blank, now i given $opacity=1, Its working now, Thanks for you time man.


chrono's NaiveTime & Duration

From the status page, I see that Arrow's types - Time32, Time64, and Duration are supported. How do I map chrono's NaiveTime, Duration to these types?
I see you've mentioned how chrono's NaiveDateTime is mapped to arrow DataType Date64 in 2/3 strategies.
EDIT: I hope I'm interpreting this right... looks like you're already introducing this via https://github.com/chmp/serde_arrow/pull/218

Duration and NaiveTime and not yet on the road map.

Duration: I don't think chrono exposes a parser
NaiveTime: should be easy to implement as chrono offers a parser

NaiveTime and NaiveDate were already supported, add support for from_samples and improved the docs in #239


Fix Practical Python Programming and Dabeaz LLC urls and rename master branch to main

Hi, there! i'm Danix, a developer. I saw the Awesome Python in Education README and i see a typo in the Practical Python Programming course and his creator url. For this contribution, i fixed this typo and changed his creator name from dabeaz to Dabeaz LLC, that is the organization where his creator published the course. Well, there was other error: the only branch of this repository is named master, and to add it to Awesome it needs to be named "main", i fixed this error too! That is all, so well, i hope Awesome Python in Education accept my contribution.

I've already changed the master branch name to main. About the Dabeaz LLC mention change, I'd prefer not to do that (the author and his nickname are known enough to link his personal account). Thank you! 🍰


Logging method and status code

Codecov Report

Merging #101 into master will not change coverage.

@@          Coverage Diff          @@
##           master   #101   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          72     72
  Lines        1985   1987    +2
=====================================
+ Hits         1985   1987    +2

Impacted Files
Coverage Δ

shelf/endpoint_decorators.py
100% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bafee76...c815159. Read the comment docs.

I think it would be cool to do something like
my_list = [
    response.status_code
]

for key, value in response.headers.iteritems():
    my_list.append("{0}: {1}".format(key, value))

logger.info("\n".join(my_list))

Also, could you instead make the verb part of the main logging format string and add stuff to the RequestLogFilter for it?

@kyle-long Good idea. hopefully this is close enough 58e8b5571ab52f364e5eeeab436c89a78bf974a9 - The log headers is used by request and response headers so I just made that function redact it instead.


Dead links for variant and Error types

Example:

PacketPeer , method put_var, param is typed var. (can be found in Dictionary class as well).
PacketPeerUDP , method wait , return value is typed Error.

Both are shown as clickable in the help browser. Both lead to empty pages. Ideally, they should point to documentation pages of the types.

var is an any type value, weird that it wants to use a page

var is an any type value, weird that it wants to use a page

Shouldn't it be Variant?

hmm yes i guess


Add GitHub actions workflows for building Artichoke

This commit adds two workflows: ci and rustdoc. The rustdoc
workflow is equivalent to the deploy job in the CircleCI config. The
ci job splits apart by source language with a dedicated job for
building and running tests of the rust sources.
The Rust build is run on a matrix of linux, windows, and macos. The
remaining jobs run on only linux.
This commit introduces a new script that only does formatting using
prettier and clang-format. The plan is to introduce a Rakefile and dev
dependency on Rake to automate developer workflows, making node an
optional dependency for development.

This PR removes the ruby frontend binary.
https://github.com/rust-lang/cargo/issues/7919


Server initialization failed.

[Error - 7:50:12 PM] Server process exited with code 1.
[Error - 7:50:12 PM] Server initialization failed.
Message: Pending response rejected since connection got disposed
Code: -32097
[Error - 7:50:12 PM] Connection to server got closed. Server will not be restarted.
[Error - 7:50:12 PM] templ client: couldn't create connection to server.
Message: Pending response rejected since connection got disposed
Code: -32097

I'm having the same trouble, here is the output of the error in my machine (using wsl2/arch, don't know if the info in relevant)
[Info  - 2:08:05 PM] 2024/06/26 14:08:05 Created View (#1)
	directory=/home/heitor/repos/go-library-manager
	view_type="GoMod"
	root_dir="file:///home/heitor/repos/go-library-manager"
	go_version="go version go1.22.4 linux/amd64"
	build_flags=[]
	env={GOOS:linux GOARCH:amd64 GOCACHE:/home/heitor/.cache/go-build GOMODCACHE:/home/heitor/go/pkg/mod GOPATH:/home/heitor/go GOPRIVATE: GOFLAGS: GO111MODULE: GoVersion:22 GoVersionOutput:go version go1.22.4 linux/amd64
 ExplicitGOWORK: EffectiveGOPACKAGESDRIVER:}
	env_overlay=[]

[Info  - 2:08:06 PM] 2024/06/26 14:08:06 go/packages.Load #1
	view_id="1"
	snapshot=0
	directory=/home/heitor/repos/go-library-manager
	query=[/home/heitor/repos/go-library-manager/... builtin]
	packages=11
	duration=1.096788128s

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x87a880]

goroutine 23 [running]:
github.com/a-h/templ/cmd/templ/lspcmd/proxy.(*Server).CodeAction(0xc00008a4b0, {0xa55290, 0xc0002c43c0}, 0xc00012f4a0)
	/home/heitor/go/pkg/mod/github.com/a-h/templ@v0.2.707/cmd/templ/lspcmd/proxy/server.go:294 +0x480
github.com/a-h/protocol.serverDispatch({0xa55290, 0xc0002c43c0}, {0xa5b340, 0xc00008a4b0}, 0xc000119800, {0xa55568, 0xc000288d00})
	/home/heitor/go/pkg/mod/github.com/a-h/protocol@v0.0.0-20230224160810-b4eec67c1c22/server.go:158 +0x4013
github.com/a-h/protocol.NewServer.ServerHandler.func1({0xa55290, 0xc0002c43c0}, 0xc000119800, {0xa55568, 0xc000288d00})
	/home/heitor/go/pkg/mod/github.com/a-h/protocol@v0.0.0-20230224160810-b4eec67c1c22/server.go:36 +0x7e
github.com/a-h/protocol.Handlers.ReplyHandler.func1({0xa55290, 0xc0002c43c0}, 0xc000280e58, {0xa55568, 0xc000288d00})
	/home/heitor/go/pkg/mod/go.lsp.dev/jsonrpc2@v0.10.0/handler.go:35 +0xc6
github.com/a-h/protocol.Handlers.AsyncHandler.func2.2()
	/home/heitor/go/pkg/mod/go.lsp.dev/jsonrpc2@v0.10.0/handler.go:114 +0x76
created by github.com/a-h/protocol.Handlers.AsyncHandler.func2 in goroutine 11
	/home/heitor/go/pkg/mod/go.lsp.dev/jsonrpc2@v0.10.0/handler.go:112 +0x165
[Error - 2:08:34 PM] Connection to server got closed. Server will not be restarted.
[Error - 2:08:34 PM] Server process exited with code 2.

And the coloring work in some files but not others?

I have also received that message and, although I don't know if the problem may be related, I fixed it (in vscode) by downgrading the version from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>

I have also received that message and, although I don't know if the problem may be related, I fixed it (in vscode) by downgrading the version from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>
Tanks bro, that helped for now!

The next version of templ will solve this issue, so going to close  this for now, thanks for raising.

Fixed in https://github.com/a-h/templ/releases/tag/v0.2.731


Extension fails to find proxy

This happens probably because the extension calls mirrord ext which spawns the proxy but takes too much time for the actual process to connect. In the proxy we have few seconds that we wait for first connection but when executed from mirrord ext it does the first connection, so the actual process connection has 1-2s to connect which is too fast.
need a better solution for this.

Closed in #1230


FORTECH - Job not found

ENVIRONMENT: production
URL: https://peviitor.ro/
Browser: Microsoft Edge
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:

Open "https://solr.peviitor.ro"
Go to Fortech - Business Analyst
Check the job on the Fortech website - https://www.fortech.ro/job-openings/business-analysts

EXPECTED RESULT:
The job is valid
ACTUAL RESULT:
The job exists on the company's website, but it disappears when  want to apply for this job

FORTECH was not made with python

Fortech is on python now, is fully working


Monitoring - can't completely clean up after disabling cluster monitoring

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Enable Monitoring with large size requirement CPU & RAM
Disable Monitoring without enabling Monitoring completely

Result:
Can't clean up the cluster-monitoring App of System Project
Other details that may be helpful:

Enable - Disable (quickly) may output the same result.
Enable Monitoring in a limited resource environment also output the same result.
Workaround:

Re-enable the Monitoring, assign 1m CPU & 1m RAM to Prometheus
Disable Monitoring again after starting Prometheus

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.2.2-rc11
Installation option (single install/HA): single

The same bug exists when enabling cluster monitoring with default values in Rancher: master 4/17 705af32

The bug fix is validated on Rancher master 397e8a8f
Test those two cases:

enable and disable the cluster monitoring really quickly multiple times
enable and disable the cluster monitoring in the environment with limited resource

this seems still an issue in 2.3.3 when enabling cluster monitoring in a Windows enabled cluster


ui-material-tab not showing in Svelte Native

Which platform(s) does your issue occur on?
-Android
-Android versions

emulator

Please, provide the following version numbers that your issue occurs with:

CLI: 8.1.5
Cross-platform modules: 8.1.5
Runtime(s): 8.1.1
Plugin(s):

"devDependencies": {
    "@nativescript/android": "8.1.1",
    "@nativescript/types": "~8.1.1",
    "@nativescript/webpack": "~5.0.0",
    "svelte": "~3.44.0",
    "svelte-loader": "^3.1.2",
    "svelte-native-preprocessor": "^1.0.0",
    "svelte-preprocess": "^4.7.0",
    "typescript": "~4.3.5"
  }

Please, tell us how to recreate the issue in as much detail as possible.

npm install --save @nativescript-community/ui-material-tabs
Then add the following code in app.ts:

import { svelteNativeNoFrame } from 'svelte-native'
import { DomTraceCategory, registerNativeViewElement } from 'svelte-native/dom';
import { Tabs, TabStrip, TabStripItem, TabContentItem } from '@nativescript-community/ui-material-tabs';
import App from './App.svelte'
import { Trace } from '@nativescript/core';

Trace.addCategories(DomTraceCategory);
    Trace.enable();

registerNativeViewElement("tabs", () => Tabs);
registerNativeViewElement("tabStrip", () => TabStrip);
registerNativeViewElement("tabContentItem", () => TabStripItem);
registerNativeViewElement("tabStripItem", () => TabContentItem);

Try to use the component like so:

<gridlayout  backgroundColor="#FFFAF3">
        <tabs selectedIndex="1">

            <tabStrip>
                <tabStripItem>

                    <image src="font://" class="fas"></image>
                </tabStripItem>
                <tabStripItem class="special">

                    <image src="font://" class="fas"></image>
                </tabStripItem>
                <tabStripItem class="special">

                    <image src="font://" class="fas"></image>
                </tabStripItem>
            </tabStrip>

            <tabContentItem>
                <gridLayout>

                </gridLayout>
            </tabContentItem>
            <tabContentItem>
                <gridLayout>

                </gridLayout>
            </tabContentItem>
            <tabContentItem>
                <gridLayout>

                </gridLayout>
            </tabContentItem>
        </tabs>
    </gridlayout>

After doing all the above, the page appears blank in the emulator. By the way I am new to svelte native, so I am definitely sure I am missing something.

@nasiriyima the tab component might be needing a special svelte implementation.
I think it was in svelte native when tabs were actually part of N. Can you go on discord in the svelte native channel (in svelte server) to discuss this?

@farfromrefug Thanks for the input. Can you kindly share the link to the svelte native discord server to me. I will really appreciate it thanks!

@nasiriyima https://discord.gg/VYzj972s

For anybody who needs this component in svelte native : this code is working.
Just there is an inversion here :
registerNativeViewElement("tabContentItem", () => TabStripItem);
registerNativeViewElement("tabStripItem", () => TabContentItem);

registerNativeViewElement("tabStripItem", () => TabStripItem);
registerNativeViewElement("tabContentItem", () => TabContentItem);


[IMPROVEMENT] Add global setting for enable v1 or v2 volume support

Is your improvement request related to a feature? Please describe (👍 if you like this request)
Add global setting for enable v1 or v2 volume support.
Describe the solution you'd like

Describe alternatives you've considered

Additional context

Verified passed on master-head (longhorn-manager be08850) following the test steps.

I think we can backport this improvement to v1.5.4. WDYT? @innobead


If we didn't download, don't try to extract

what's the reason for this?

Because I still see lots of CI errors in FAKE because of parallel instances trying to extract the same package. I already tried some mitigations before (like https://github.com/fsprojects/Paket/pull/3554 where I download into a temporary file), but I still see

(from https://dev.azure.com/fakebuild/FSProjects/_build/results?buildId=1149)
and

(from https://dev.azure.com/fakebuild/FSProjects/_build/results?buildId=1150)
I assume the reason is: Downloading now works, but both paket instances try to extract the package in parallel. This is probably not the best mitigation and not 100% but I hope it gets my build failures down to a reasonable level...
But let's see if it is still green.

something went red. let's retry the build


HIVE-27429: Disable flaky test TestCompactionMetrics#testCleanerFailuresCountedCorrectly

What changes were proposed in this pull request?

Why are the changes needed?

mvn test -Dtest=TestCompactionMetrics#testCleanerFailuresCountedCorrectly  -pl ql/
http://ci.hive.apache.org/job/hive-flaky-check/697/testReport/
I also have found several PR  integration tests failed with the test TestCompactionMetrics#testCleanerFailuresCountedCorrectly
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4408/1/tests
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4404/1/tests/
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4402/4/tests/
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4360/5/tests/
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4372/10/tests/
Does this PR introduce any user-facing change?

How was this patch tested?

@zhangbutao The following PR should fix this flaky test - #4410 .

@zhangbutao The following PR should fix this flaky test - #4410 .

It is greate if it can be fixed! I will test it again after https://github.com/apache/hive/pull/4410 is merged.

@zhangbutao #4410 is merged, can you please check if this PR is still needed? if not can we close this?

@zhangbutao #4410 is merged, can you please check if this PR is still needed? if not can we close this?

yes，closing it


Always extend model otherwise creating doesnt get rules

Fixes: https://github.com/tastyigniter/TastyIgniter/issues/626

The model is already extended in FormController::createOnSave, what we should do is merge rules from the extension only when a model record exists

Updated to use $form->model->exists

Thank you!


Use Data.Compact to serialize K definition at compilation time

Fixes #2943
Scope:
This change makes use of the Data.Compact library to serialize the initialized KORE definition ahead of time and then load it into memory at the start of kore-exec for symbolic execution and search. Nothing necessarily prevents us from using it for other execution modes as well, but I figured we would start with the basic case and we can add on more cases in follow-up changes if we so desire.
Note: the integration tests do not currently test this code path! It is only exercised if krun passes the path to a binary serialized file instead of the path to definition.kore. this requires frontend change that cannot be merged until this change is in master. Thus, the integration tests passing with this change indicates that the old code path still works. I have manually tested the new code path with the modified frontend and it did pass the integration tests.
DO NOT MERGE unless the head commit of this branch as of merge time passes the integration tests manually with the modified k frontend in addition to all checks being green.
Estimate:

Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

[ ] Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
[ ] Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
[ ] Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
[ ] Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

Here is the changes that will be made to the frontend after this is merged: https://github.com/runtimeverification/k/pull/2551
As you can see in that diff, all the frontend is really doing differently is calling kore-exec --serialize instead of kore-parser. Since kore-exec --serialize already parses and verifies the definition, all we're doing is adding the extra step of compacting and serializing it when that's done.
As far as performance, this takes the time to execute a single step of the haskell backend on the c semantics down from like 40 seconds to 7 seconds. That's a pretty substantial improvement. It also sizeably increases the GC throughput in the backend while executing because it puts the initialized KORE definition in what's called a compact region, which essentially means, among other things, that it's not being traced by the garbage collector.
You are correct that it probably does increase the memory usage somewhat, because one consequence of being a compact region is that any pointer into any part of a compact region keeps the entire region alive and prevents garbage collection. But overall as you can see, the difference is relatively minor, and the actual execution time improves substantially. compilation does take longer, but in doing so it saves substantial amounts of time on the fast path, so overall you benefit greatly unless you are compiling a lot of definitions and then never using them. So overall it is a substantial win.


Progressbar sometimes too long

Steps to reproduce:
pycp /veeeeeeeeeeeeeeerrrrrrrrrrrrry/looooooooooooooooooong/paaaaaaaaaath/{src,dest}

The problem is that the output of describe_transfer is not guaranteed to take less than the line width, and after that it's too late to know which segment of the line should be truncated

Update: this is by design, the very purpose of the describe_transfer is to display both source and destination, reducing the noise as much as possible (hence the arrow and the computation of a common middle part).
So if it is still larger than the terminal size, there's nothing we can do.
This is the exception: all other info must fit on one line, otherwise you get ugly outputs.


fix: check for timeout in wait_deployment_replica_ready and fail if so.

Which issue(s) this PR fixes:

Issue https://github.com/longhorn/longhorn/8183
What this PR does / why we need it:
Adds a check for timeout when waiting for deployment to create successfully.
Special notes for your reviewer:
Additional documentation or context

Still testing, so created PR as draft.

RWX tests failed as hoped.  The "broken" longhorn-share-manager image I am using is jmunson4suse/longhorn-share-manager:8183-test1
Removing the "draft" status.  This is ready to go.


Sb 9805

Codecov Report

Merging #368 into release-1.14-sp3 will increase coverage by 0.04%.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##             release-1.14-sp3     #368      +/-   ##
======================================================
+ Coverage               40.83%   40.87%   +0.04%
  Complexity                765      765
======================================================
  Files                     110      110
  Lines                    7536     7528       -8
  Branches                  850      850
======================================================
  Hits                     3077     3077
+ Misses                   4132     4124       -8
  Partials                  327      327

Impacted Files
Coverage Δ
Complexity Δ

...n/java/org/sunbird/common/models/util/JsonKey.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae3f039...e2d18c2. Read the comment docs.


issues i see

hi,
here is the list of bugs i see from windows 7 pro 64 bit:
-menu items share a directory is dimmed when file is selected
-menu item view or set permissions is dimmed when file is selected
-under file  drop down the compress... and uncompress seem to work but not in a way expected (i expected it to be compress to zip)
-under drop down Disk item,format disk is dimmed ( well folder labeled C:\ is selected (behavor unexpected but i guess this was used with floppy disks not hard drives)
--under drop down Disk item Share as and stop sharing is dimmed (unexpected, but i guess this is a deprecated pre windows smb sharing option)
overall a good prodect

Thanks @T8z5h3 for your thoughts.  Compress == file system compression, not zip.  The disk format question is discussed in issue #62.  The rest behave as expected for the code base.  Please suggest any additional issues you see.


Have expenses page links direct to correct filters

Pullerbearing ()
cc @tgolen
Details
Update the URL params to direct the "View all receipts" link to the expenses page with the correct filters turned on.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/180928
Tests

Go to NewDot and create a workspace
Click on the reimburse receipts page
Then click view all receipts to be redirected to OldDot
Make sure that you see the correct policy selected in the Policy selector, the reimbursable/billable switch set to reimbursable, and the Submitter dropdown set to "All Submitters"

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Remove swipeX methods as they swipe the wrong direction

All of the methods that are a simple "swipeX()" (e.g. swipeUp, swipeDown, swipeLeft, swipeRight) actually use the opposite SwipeElementDirection, which is just confusing.
I'd like to replace all these methods with a simple swipe(SwipeElementDirection direction) method

Thinking of renaming SwipeDown to ScrollDown to match its implementation.


Added path to karma configuration file in debug command

LGTM
Sorry, missed this. I had updated the test command, but not debug. This became necessary because else the test library would not let us require() files.

That makes sense. Thanks for merging it!


Refactor configuration object to class based

Hopefully, this will solve https://github.com/rtfd/readthedocs.org/issues/3806 (or maybe it will be split in two PRs).
I'm refactoring the existing code to be class based instead of using a dictionary, this will allow us to extend the behavior and have a common interface for multiple versions of the configuration file.

Please ignore the linter errors p:

This is what I have done so far:

Refactor BuildConfig from a dict based to a base class.
Make the ConfigWrapper object thinner and use more the config object itself.

To completely remove the ConfigWrapper object we need to take some decisions, and I think the PR is getting a little big. So, maybe I can revert the changes related to making the ConfigWrapper object thinner and just leave the refactor from dict to a base class.

I just removed the ConfigWrapper class, tests are only failing in test_config_wrapper for obvious reasons p: Tomorrow I'll see what tests we can port to test_config.

I have tested this with some projects from github that have a readthedocs.yml file, it works as expected so far. I'll be re-reviewing all the code to see if there is something missing.

I just left some comments about things we can remove (maybe in other PR), I think this is ready. Next step is creating the version2 and the class selector of the configuration object.


[TickTick] create a task from selected text

Extension
https://www.raycast.com/appest/ticktick
Description
create a task from the selected text.
Maybe the selected text could be the task description (contents)
Who will benefit from this feature?
No response
Anything else?
No response

Already published to the store, you can config it in the plugin preference. https://github.com/raycast/extensions/pull/9238

@raycastbot close this issue


No "argument" in $Block

I use your class with the last release of ParsedownExtra and Parsedown.
When I try to generate a TOC, I've these errrors :

PHP Warning:  Illegal string offset 'argument' in /my_project//vendor/ParsedownToc.php on line 47
PHP Notice:  Undefined index: attributes in /my_project//vendor/ParsedownToc.php on line 58
PHP Warning:  Illegal string offset 'argument' in /my_project//vendor/ParsedownToc.php on line 60
PHP Warning:  Illegal string offset 'argument' in /my_project/vendor/ParsedownToc.php on line 60

For information, theses lines are impacted :

47: if (preg_match('/[ #]*{('.$this->regexAttribute.'+)}[ ]*$/', $Block['element']['handler']['argument'], $matches, PREG_OFFSET_CAPTURE)) {

58: $link = "#".$Block['element']['attributes']['id'];

60: $Block['element']['handler']['argument'] = $Block['element']['handler']['argument']." ";

I don't autided too Pardown source code to known how to solve this problem, can you solve ?
Thanks, have a nice day.

I have a simple hot fix, change the ['handler']['argument'] part to ['text'].
In the current version of Parsedown 1.7.4 the 'handler' key is just a string with the content 'line'.

Sorry for the trouble I find out why I believed it worked on 1.7.x turns out that I did use a 1.8.x file but have renamed it 1.7.1 when I made my test lab, I have now fixed that little annoying issue. Hope this didn't put you guys into too much trouble

Same issue here.
Fix is to replace if condition with just:
$text = $Block['element']['text'];

ParseDown 1.7.4 and Extra 0.8.1, so latest stable versions.
The code in ParseDownToc is doomed to fail: https://github.com/BenjaminHoegh/parsedownToc/blob/effb0d76b005bbef5a5d57ced792d5b34e44f723/ParsedownToc.php#L88
As if the argument index is not set, the variable will not be set. It should create an exception here I think?


Check the copytodns && copytossl buttons on resolved

Seems they cleanup the cache after adding :O

The cache was erroneously cleaned without user direct intervention-removed


Reconstruct wiki repository

We want to merge wiki content from YaccConstructor/QuickGraph and KeRNeLith/QuikGraph, reintegrating them together, preserving history -- if at all possible.

This was done in a push to the wiki's repo made yesterday.


Cleanup .zip and reset folders from after project reset

Right now devs need to manually cleanup both .zip files and the reset folders that end up in deleted, we'd like to automate this away so it's automatic.

[ ] delete zip files used to let end user download project
[ ] delete folders moved for a reset

The .zip files are being created in the system temp dir, so it's probably okay to let a server process handle it, deleting any files older than 7 days. The folders being moved for a reset are using the HgService.SoftDeleteRepo method, so once we have a policy in place for handling soft-deleted projects then that will affect this as well. Perhaps soft-deleted projects get hard-deleted after 90 days?


components/bootloader: Build fails for CONFIG_FLASHMODE_QIO=y

When I enable QIO flash mode with CONFIG_FLASHMODE_QIO=y the linker fails with
build/bootloader/main/libmain.a(flash_qio_mode.o):(.literal.enable_qio_mode+0x8): undefined reference to `esp_rom_spiflash_master_config_readmode'
build/bootloader/main/libmain.a(flash_qio_mode.o): In function `enable_qio_mode':
sdk/esp32-esp-idf/components/bootloader/src/main/./flash_qio_mode.c:167: undefined reference to `esp_rom_spiflash_master_config_readmode'

A recursive grep for esp_rom_spiflash_master_config_readmode shows the call, the prototype definition but no implementation of this function (9050307dfe600c915adaccf8076220d6474876db).

Hi @devsaurus ,
Thanks for reporting this. This was a regression merged earlier this week (1132ef7554). We are currently in the process of merging a fix, it should land in the next few days.
Angus

Fixed in 85e76a7.


Is it ok to ignore license files?

To keep the zip file as small as possible, all the LICENSE files or ignored and are not copied to the zip file. Is this ok to do or not? Probably this isn't and the licenses should be copied to the zip as well.

License files are not ignored anymore in the distribution zip directory.


Change Javascript -> JavaScript

Summary
Fix JavaScript naming in docs.

Codecov Report

Merging #6070 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6070   +/-   ##
=======================================
  Coverage   64.12%   64.12%
=======================================
  Files         217      217
  Lines        8332     8332
  Branches        4        3    -1
=======================================
  Hits         5343     5343
  Misses       2988     2988
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5f5e0...6f60ebe. Read the comment docs.

Thanks!


Bug in Tic Tac Toe

The game doesn't end in the scenarios seen above. This is, because the bottom left is miscalculated in the right diagonal. The symmetrical equivalent for the left scenario works as expected.

Opening a new branch to hotfix this issue

Problem: double overshoot, the bottom overshoot has to be checked again


allow multiple respondents to be assigned to respond to a survey

Admins will be able to create a list of respondents (or invite new users to become respondents) that are allowed to respond to each survey.

We decided that this could wait until other base functionality is working.


error in scan with pyhon 3.7.2

When I try to connect an RTU device during the scan I get an error because the instruction does not work. data[:4] is a string and then also if the base_addr is right systems not recognize it.
if data[:4] == b'SunS':     self.base_addr = addr     # print('device base address = %d' % self.base_addr)     break
I've tried to change b'Suns' in 'Suns' but I get an error in a following statement.
This is my python code
import sunspec.core.client as client d = client.SunSpecClientDevice(client.RTU, 1, 'com9', baudrate=19200, timeout=10)
address, Com, baudrate and timeout and connection using sunspec dashboard works correctly.

This strikes me as a duplicate of #60.  Maybe give #62 a try (yourenv/bin/pip install git+https://github.com/altendky/pysunspec@60-altendky-bytes_for_both_py2_and_py3).

Updated with a fix. Give it a try and see if it works for you.


Use content-based primary key for artefact metadata

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

requires https://github.com/gardener/cc-utils/pull/1089


[SLM] iOS refactor

This PR refactors the iOS app to fully support SLM, specifically addressing the following items:

[X] Fetch modelID and modelLib from app-config.json instead of mlc-chat-config.json
[X] Refactor app-config.json
[X] Update ModelRecord schema accordingly
[X] Update localID to modelID
[x]  Update docs

PR now ready for review. cc @CharlieFRuan @tqchen

Let us followup with the convention update per https://github.com/mlc-ai/mlc-llm/pull/1659


Why does "KB" mean kibibytes?

human-size-rs treats "KB" as an alias for "KiB" (1024 bytes), however no other abbreviations in human-size-rs have such an alias. And, this name is inconsistent with GNU coreutils which interprets "KB" as kilobytes (1000 bytes).
Some research suggests that it might be in accordance with the JEDEC standard. However, human-time-rs doesn't recognize "MB", which that standard interprets as mebibytes, so that doesn't seem to be the reason.
Is there another reason for interpreting "KB" as kibibytes?

I did indeed follow the JEDEC standard. But I have no idea why I only did so for kibibytes...
Maybe "KB" should be removed from the standard parsing implementation and additional parsing functions should be supplied that are explicit about whether they are decimal (kilobytes) or binary (kibibytes). Something like the following:
/// Base 1000 values (kilobytes).
enum Decimal { }

/// Base 1024 values (kibibytes).
enum Binary { }

fn parse<T>(input: &str) -> Result<Size, ParseError> {
    // ...
}

// Calling:
let value = parse::<Decimal>("10 KB")?;
assert_eq!(value, SpecificSize::new(10, Kilobyte));


[CIT-459] Use the batcher to batch collectd message

Proposed changes

Use the crate common/batcher to batch the collectd messages.
This first draft is focused on getting things work.
One still needs to improve configuration, code clarity.

Types of changes
What types of changes does your code introduce to thin-edge.io?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactorings that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #401 (8c9baba) into main (1492984) will decrease coverage by 0.90%.
The diff coverage is 34.83%.

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   66.16%   65.26%   -0.91%
==========================================
  Files         104      104
  Lines        6534     6399     -135
==========================================
- Hits         4323     4176     -147
- Misses       2211     2223      +12

Impacted Files
Coverage Δ

mapper/tedge_mapper/src/collectd_mapper/monitor.rs
0.00% <0.00%> (ø)

mapper/tedge_mapper/src/collectd_mapper/batcher.rs
72.00% <30.00%> (-10.59%)
:arrow_down:

...apper/tedge_mapper/src/collectd_mapper/collectd.rs
88.28% <83.33%> (-0.61%)
:arrow_down:

mapper/thin_edge_json/src/group.rs
84.96% <0.00%> (-5.23%)
:arrow_down:

common/mqtt_client/src/lib.rs
26.00% <0.00%> (-1.84%)
:arrow_down:

mapper/thin_edge_json/src/serialize.rs
96.89% <0.00%> (-1.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1492984...8c9baba. Read the comment docs.


Upgrade bilinovel.com.js and yymanhua.com.js

Using the provided extension API this.request, for unknown reasons, does not throw an error when the request times out (Some requests will time out, possibly because of high concurrency), causing the program to block waiting for the request that has timed out.
Like these requests:

You can see the error about the timeout request in the miru.log, but in the javasceipt code, it does not throw an error. So I can't retry by catching the error.

I don't know if this is a Bug or if there is something wrong with my code. I finally solved the timeout problem using the Promise.race😥

@OshekharO Hello？I just wanted to check in on the status of my PR. It has been pending for a while now, and if there is any problem that prevents the code from merging, please let me know🥺


storage: add unit tests for StorageRevertsIter

Sorry, we're having some issues on CI. I'll rebase once the PR with the fix is in


SPIN-159 Add additional block device volume types to AWS pipeline deploy stage.

@skorten @pansonm @obuckley-kenzan Please review, story is located here: https://projects.kenzan.com/jira/browse/SPIN-159

Looks like the layout is wrapping to accommodate additional volume types (Chrome):

Can one of the admins verify this patch?

There is an empty blockDevices[] array in the JSON when you set the Number of Volumes to zero. Haven't tested a deploy but best to clean up and remove array if there are no elements.

@pansonm
I reviewed blockDevices field with @bsawyer .  It should be ok, there is a command model that reflects all the possible values and their defaults and gets updated as needed as the user fills out the form.  From there, we can see there are already existing properties with default values of [].
That said, it can't hurt to test but as far as we can tell, that is the convention already established.

@obuckley-kenzan Agree this is an established pattern. I tested and it works fine.


How to change index.html?

❓Question
I need to add some html scripts and styles in the main index.html file how to do that using availity workflow?

As far as styles, we usually have an index.sass file that gets imported into the index.html and compiled to css by workflow. You may look at a library like Helmet to take care of modifications to the HTML https://github.com/nfl/react-helmet


Should handle new SDK AXML files

Need to be able to handle non-null spaces strings as string attributes.

This was closed in https://github.com/rednaga/axmlprinter/commit/38f3b5ad2b920bc44a97533da5e584dfda4912d8 on https://github.com/rednaga/axmlprinter/blame/master/src/main/java/android/content/res/chunk/sections/StringSection.java#L76


Add our values and explain the vision for this group

Autonomous -> managed by the community
Nonprofit
Framework for other meetups
...

need text for content

@gorhgorh @zooma2k18: can you start a draft for this? :)

sure, I'm out tonight but I'll start tomorrow

values are available here: https://github.com/parisp2p/community/tree/master/docs


Consider making schema::Schema fields public for testing

I have been experimenting a bit with constructing a single source of truth when developing an adapter. Here is the general idea I'm using right now

Use a src/schema.trustfall.graphql as source of truth: All Rust types/enums/etc. must conform to this file. It is included statically using include_str! and parsed to a static schema::Schema ref using lazy_static!
Use testcases to ensure that the standard Token variant (as used in demos) follows this schema

The last point becomes a problem since schema::Schema currently hides for example vertex_names, that could be used to verify naming etc.
In the same vein: Since typename for tokens should be the same as the names in the schema, I would instead suggest a procedural macro that simply make the variant names the type names (see hackernews impl Token block)
It would perhaps be more desirable to generate either the schema from Rust types (like juniper does for GraphQL) or Rust code from the schema, but that would require some macro magic. Something like the $[derive(GraphQLObject)] (#[derive(TrustfallVertex]?) would make development go brrrr

I wouldn't make the fields themselves public[0], but I'm open to adding accessor methods that expose iterators and point-lookup functions over the data.
Another interesting option: add a built-in adapter for querying schemas, so users could do
{
  Vertex {
    name @filter(op: "=", value: ["$name"])

    property {
      name @output
      type @output
    }
  }
}

or something to that effect.
[0]: Our current schema is fully materialized and parsed from a file. But sometimes schemas are way too big for that, especially once we start combining them across adapters. I've worked with schemas of hundreds of thousands of types, which needed over 500MB of RAM to get represented in this form. So it would be convenient to not get locked into a specific representation with particular fields etc. and instead offer an API that we can maintain stable regardless of the underlying format.
I'm open to a proc-macro for __typename as you suggest, as well as macro magic for Rust -> schema or vice versa. It isn't clear to me that one direction is strictly preferable to the other there, and it may be just a case of "prototype then evaluate."

If you still need to query schemas, try the new SchemaAdapter in Trustfall v0.5.1: https://github.com/obi1kenobi/trustfall/releases/tag/trustfall-v0.5.1
It already power the new stub generator crate I recently created: https://github.com/obi1kenobi/trustfall/blob/main/trustfall_stubgen/src/adapter_creator.rs#L127-L133


Audio not syncing?

https://gist.github.com/RenegadeEagle/3752b204e5974c2ab65a
So I have this code here. And I am attempting to combine all videos inside of my Videos folder, although it seems that the Audio is not Syncing correctly with all the videos.
Is there a reason for this? Maybe a fix? Thanks.

Nothing so far?

Also noticed this happening after appending a third video, tried appending all three videos using the append example and then appending the first two and then the third video with merged video and still have this problem. Isn´t there a way to fix this?

Is there a solution?

Nothing so far?

Let me explain what happens here:
The shortest video duration is ~40ms (1 out of ~25 frames per second), you
can only have videos of the length 40,80,120,160 and so on millisecond.
The shortest audio duration is 21 or 23ms (44.1 or 48KHz).
You can most likely already imagine what is happening: Even if you try your
best you might run into a situation where audio and video have different
durations up to (audio frame duration / 2) = 10.5 or 11.5ms.
If this is added up -> ouch! You need to compensate for that if you append
multiple videos and add an extra audio frame or omit an audio frame.
Sometimes i've seen that encoders systematically produce shorter audio than
video or the other way around. If you append that -> ouch, offset! If the
video is longer than the audio you cannot use the part without audio when
appending as this will lead to an offset/lip-sync issue in the next part.
You might try to compensate by adding silence.
Does that help to understand what's going on?
Grüße,
Sebastian
terry<EMAIL_ADDRESS>schrieb am Di., 25. Apr. 2017 um 09:51 Uhr:

Nothing so far?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/sannies/mp4parser/issues/21#issuecomment-296948030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKUD33kl103MocbsM8fR4Tk8GEfZLbRks5rzaXugaJpZM4C0pgO
.

This functions will append videos with no out of sync problems
`@Throws(Exception::class)
fun appendVideos(videoPathList: List, targetFilePath: String) {
    val movies = videoPathList.flatMap { file -> listOf(MovieCreator.build(file)) }

    val finalMovie = Movie()

    val videoTracksTotal = mutableListOf<Track>()
    val audioTracksTotal = mutableListOf<Track>()

    var audioDuration = 0.0
    var videoDuration = 0.0

    movies.forEach { movie ->

        val videoTracks = mutableListOf<Track>()
        val audioTracks = mutableListOf<Track>()

        movie.tracks.forEach { track ->

            val trackDuration = track.sampleDurations.toList()
                .map { t -> t.toDouble() / track.trackMetaData.timescale }.sum()

            if (track.handler == "vide") {
                videoDuration += trackDuration
                videoTracks.add(track)
            } else if (track.handler == "soun") {
                audioDuration += trackDuration
                audioTracks.add(track)
            }
        }

        // Adjusting Durations
        adjustDurations(videoTracks, audioTracks, videoDuration, audioDuration).let {
            audioDuration = it.audioDuration
            videoDuration = it.videoDuration
        }

        videoTracksTotal.addAll(videoTracks)
        audioTracksTotal.addAll(audioTracks)
    }

    if (videoTracksTotal.isNotEmpty() && audioTracksTotal.isNotEmpty()) {
        finalMovie.addTrack(AppendTrack(*videoTracksTotal.toTypedArray()))
        finalMovie.addTrack(AppendTrack(*audioTracksTotal.toTypedArray()))
    }

    val container = DefaultMp4Builder().build(finalMovie)

    val fos = FileOutputStream(targetFilePath)
    val bb = Channels.newChannel(fos)
    container.writeContainer(bb)
    fos.close()
}

class Durations(val audioDuration: Double, val videoDuration: Double)

private fun adjustDurations(
    videoTracks: MutableList<Track>,
    audioTracks: MutableList<Track>,
    videoDuration: Double,
    audioDuration: Double
): Durations {

    var diff = audioDuration - videoDuration
    val tracks: MutableList<Track>
    var durationOperator: Double
    val isAudioProblem: Boolean

    when {
        // audio and video match, no operations to perform
        diff == 0.0 -> {
            return Durations(audioDuration, videoDuration)
        }
        // audio tracks are longer than video
        diff > 0 -> {
            tracks = audioTracks
            durationOperator = audioDuration
            isAudioProblem = true
        }
        // video tracks are longer than audio
        else -> {
            tracks = videoTracks
            durationOperator = videoDuration
            diff *= -1.0
            isAudioProblem = false
        }
    }

    // Getting the last track in order to operate with it
    var track: Track = tracks.last()
    var counter: Long = 0

    // Reversing SampleDuration list
    track.sampleDurations.toList().asReversed().forEach { sampleDuration ->

        // Calculating how much this track need to be re-adjusted
        if (sampleDuration.toDouble() / track.trackMetaData.timescale > diff) {
            return@forEach
        }
        diff -= sampleDuration.toDouble() / track.trackMetaData.timescale
        durationOperator -= sampleDuration.toDouble() / track.trackMetaData.timescale
        counter++
    }

    if (counter != 0L) {
        // Cropping track
        track = CroppedTrack(track, 0, track.samples.size - counter)

        //update the original reference
        tracks.removeAt(tracks.lastIndex)
        tracks.add(track)
    }

    // Returning durations
    return if (isAudioProblem) {
        Durations(durationOperator, videoDuration)
    } else {
        Durations(audioDuration, durationOperator)
    }
}`


:art: Load fonts from disc, not Google Fonts

Load fonts "Source Sans Pro", "Montserrat" from disc, not Google Fonts.
Fonts on disc in fonts folder in styles as ttf, woff files for browser support.

Thanks for you PR!
I think it would be better to create a separate .scss file with @font-face definition for each font, so we can include it only once in template.scss instead of re-creating a @font-face for each component.
For example:
styles/fonts/Montserrat.scss
@font-face { … }

styles/template.scss
@include "fonts/Montserrat",
         "fonts/SourceSansPro";

Could you try to change this so I can merge your pull request?

Thanks! 😊 Yeah, sounds good. Have updated it accordingly!


SOLR-8803: OOM killer for Windows

https://issues.apache.org/jira/browse/SOLR-8803

Shawn is going to commit the patch on the jira. closing this PR since it was just an example.


fetchgithub: allow private repos to use fetchgit

Replaces #138011
Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 138809 run on x86_64-linux 1

15 packages built:

bundix
cabal2nix
crate2nix
crystal2nix
dep2nix
go2nix
haskellPackages.cabal2nix-unstable
haskellPackages.nvfetcher
haskellPackages.update-nix-fetchgit
nix-prefetch-git
nix-prefetch-scripts
nix-update-source
nvfetcher
update-nix-fetchgit
vgo2nix


exec_publish_done kills its script

Hello,
I'm running nginx 1.17.0 with the rtmp module on Ubuntu 18.04 server.
I'm using the exec_push and exec_publish_done directives in order to run  bash scripts (.sh) i made for.
The exec_publish is working good and launch a bash scritpt (start.sh) that starts an FFmpeg process. It correctly sends the kill signal when publishing stops.
The exec_publish_done, then, launches another bash script (stop.sh) that starts another FFmpeg process but at the same time it starts and immediately stops.
Manually running stop.sh is currently working good.
My question is: is it possible that the exec_publish_done also sends a SIGTERM or kill immediately after the execution of that script?
I also noticed that this behaviour seems not to be present when i test it after closing and restarting Nginx (stop nginx -> start nginx -> start publish -> exec_publish works -> stop publish -> exec_publish_done works -> restart publish -> exec_publish works -> stop publish -> exec_publish_done does not work anymore).
Same thing also by changinx nginx version (1.14 and 1.15) and ffmpeg version.

Yes it is possible. You can use signal traps.


nc_test_run_diskless2 timeouts on 4.9.0

While trying to build the 4.9 release on Arch, I’ve seen one unexpected test failure:
95/244 Testing: nc_test_run_diskless2
95/244 Test: nc_test_run_diskless2
Command: "/usr/bin/bash" "-c" "export srcdir=/build/netcdf/src/netcdf-c-4.9.0/nc_test;export TOPSRCDIR=/build/netcdf/src/netcdf-c-4.9.0;/build/netcdf/src/build/nc_test/run_diskless2.sh run_diskless2.sh "
Directory: /build/netcdf/src/build/nc_test
"nc_test_run_diskless2" start time: Jun 22 12:04 UTC
Output:
----------------------------------------------------------

*** Create file
ok.

*** Create file diskless
ok.

*** Open file
ok.

<end of output>
Test time = 1500.10 sec
----------------------------------------------------------
Test Failed.
"nc_test_run_diskless2" end time: Jun 22 12:29 UTC
"nc_test_run_diskless2" time elapsed: 00:25:00
----------------------------------------------------------

Not sure what fails actually, it just timeouts.

Merging #2319 might fix this.

I can confirm, cherry-picked on top of 4.9.0 and…
        Start  95: nc_test_run_diskless2
 95/254 Test  #95: nc_test_run_diskless2 .................   Passed    5.53 sec


Question: unable to make line-numbers work

I downloaded the library with core, default theme, all languages selected, line-highlight, line-numbers, file highlight, show language and highlight keywords plugins.
Then I include the js and the css on a page and I add the following html code:

Some javascript code here

And the code is highlighted correctly, the language is shown at the top-right corner (so that plugin is working correctly) but I don't get line numbers.
Am I doing something wrong?

Do you have any running code? i.e. jsfiddle, codepen, plnkr, etc

@javatlacati No, I'm developing on a private server. I was now trying to make a jsfiddle but there is no build of the prism library (with all those components) that I know so I could load it on jsfiddle. So I suppose I will have to upload it myself somewhere. Unless I can use the download link from the "Customize your download" prism page.
I forgot to mention. There are no errors on the console at all.

http://codepen.io/anon/pen/LVqGoj

This is really annoying. If I create in customize your download one with just core, default theme, the 4 default languages and line numbers plugin. It still doesn't work.
If on the other hand I load individually the core prism.js, the javascript language component, and the line numbers plugin from the tag 1.0.1, it works fine.
If I try to genere that combination with the customize download I'm forced to selec c-like too. And it doesn't work. Don't know if it would work without the c-like because it can't be deselected and have javascript selected at the same time.
I'm going to create a last customize one with only css language to test. My last attempt. If it still fails I will need to try to join the files myself and see what happens.

I found the problem. The generated js and css files are fully dependant. You can't build a css with a group of components selected and then change components and download only the js file because it won't work.

I also had the same problem, that plugin line-numbers was not displayed. The problem was, that I had a custom css for pre tag, that overwrites padding from plugin css. So, line numbers were not displayed because of the wrong padding.


SCIM2 Me endpoint user provisioning with empty password response does not reflect the users correct action

Suggested Labels
Affected/wso2is5.9.0alpha
US-JDBC
DB-MSSQL
Priority/Normal
Severity/Major
Steps to Reproduce
Provision a user with SCIM2 ME endpoint with null value for password field
curl -v -k --data '{"schemas":[],"name":{"familyName":"Johnson","givenName":"Alex"},"userName":"abcd","password":"","emails":[{"primary":true,"value":"alex.j@gmail.com","type":"home"},{"value":"alex_j@wso2.com","type":"work"}],"EnterpriseUser":{"employeeNumber":"123A","manager":{"value":"Taylor"}}}' --header "Content-Type:application/json" https://<IP_ADDRESS>:9443/t/wso2.com/scim2/Me
The response will be as follows
{"schemas":["urn:ietf:params:scim:api:messages:2.0:Error"],"detail":"Error in adding the user: abcd to the user store. PasswordInvalidAsk Password Feature is disabled","status":"500"}
When we send a request with null value for username response will be as follows
{"schemas":["urn:ietf:params:scim:api:messages:2.0:Error"],"scimType":"invalidValue","detail":"31301 - Username null is not valid. User name must be a non null string with following format, ^[\\S]{3,30}$","status":"400"}
Should make the response consistent when password is null to match with the users correct action
when the password does not match the password standards
curl -v -k --data '{"schemas":[],"name":{"familyName":"Johnson","givenName":"Alex"},"userName":"abcde","password":"12","emails":[{"primary":true,"value":"alex.j@gmail.com","type":"home"},{"value":"alex_j@wso2.com","type":"work"}],"EnterpriseUser":{"employeeNumber":"123A","manager":{"value":"Taylor"}}}' --header "Content-Type:application/json" https://<IP_ADDRESS>:9443/t/wso2.com/scim2/Me
Response
`{"schemas":["urn:ietf:params:scim:api:messages:2.0:Error"],"scimType":"invalidValue","detail":"30003 - Credential is not valid. Credential must be a non null string with following format, ^[\S]{5,30}$","status":"400"}
`
This also needs to change to say for the user exactly that the password does not match with the expected standards

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Remove last few report.managerEmail uses

cc @thienlnam since hopefully this will be the last change needed for tasks 🙏 (related to email -> accountID migration)
also cc @puneetlath so you're aware! we're getting close!
Details

We're working on getting rid of emails & using accountIDs instead - see https://github.com/Expensify/Expensify/issues/294647
Purpose = to increase privacy / prevent emails from being leaked around the app  - in onyx & in API calls
Note: We need to watch out for creating reports / tasks with BRAND NEW users that we may / may not have personal details for yet. I believe we now store email addresses in personal details when we start chats (since we must have typed in their email address?) but I'm not 100% sure, which is why it needs to be tested.
Fixed Issues
$ Related to https://github.com/Expensify/Expensify/issues/294647
$ Finishes up https://github.com/Expensify/Expensify/issues/299956
Tests
Make sure task actions still work well:

Create new task
Edit task name / description
Assignee (brand new & existing)

Note: You should test on multiple devices so you can make sure all task updates work correctly for:

The receiver / assignee / report attendees
The same user, on another device (ex: edit tasks on chrome & make sure you see the same correct updates on mobile)

Similarly, make a few money requests & edit / delete them, make sure everything still works perfectly

[ ] Verify that no errors appear in the JS console

Offline tests
Same as above, everything should work optimistically offline
QA Steps
Same as above

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native
(see MacOS: Chrome / Safari video)

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3885503/205c3216-0715-45df-8781-da1956071b29

MacOS: Desktop

Nice! Should we have a C+ test it?

@puneetlath  Yesssss definitely! 👍  I'm going to do a bit of testing on my side too, then will look for a C+ to take this on 🙏

Sweet, sounds good!

FINALLY tests pass, let's get some C+ to help test now! I uploaded a vid of some tests w/ ios & web

Thanks @shubham1206agra for volunteering to help with this!

@Beamanator Can you merge latest main here?

@shubham1206agra done! 👍

@shubham1206agra just checking, are you able to review this today? 🙏

@Beamanator Can you review this video (especially at the last)?
https://github.com/Expensify/App/assets/58412969/4cdb189d-a76a-4a12-8408-18d83911ca1c

@shubham1206agra sorry I didn't see your message! Is there anything in particular you think isn't working properly? I'll watch and see if I notice anything

Aah it looks like deleting tasks isn't updating the other user live - have you noticed this before @thienlnam ? (see video above, around minute 2:22) - it looks like it did update both users when the user who created the task deleted it (around minute 1:22), but not when the other person deletes it (minute 2:22)

@shubham1206agra it would be great if you could try, if you can't repro in staging/prod I'm happy to give it a go - but I'm pretty busy with other things at the moment

@Beamanator The Same can be repro in prod. I think we can continue the review now.

Nice, yeah I agree @shubham1206agra 👍

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Yeah there are currently some PRs to fix some functionality with cancel task

Good to know @thienlnam 🙏
I'll fix merge conflicts 😓

Conflicts fixed! @shubham1206agra can you please test again before we move forward? 🙏

Not sure why Melvin requested a review from me. Looks like an internal engineer was already assigned. Gonna unsubscribe, but lmk if an additional review is needed.

@Beamanator Still works fine

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.96-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[VS Code] The collaboration session expired. Please sign in and try again.

%0A%0A%23%23 Error:%0AThe collaboration session expired. Please sign in and try again.%0A%0A%23%23 Steps to Reproduce:%0A1.%0A2.%0A%0A||Version Data|%0A|-:|:-|%0A|**extensionName**|VSLS|%0A|**extensionVersion**|1.0.249|%0A|**protocolVersion**|2.2|%0A|**applicationName**|VSCode|%0A|**applicationVersion**|1.34.0|%0A|**platformName**|MacOS|%0A|**platformVersion**|18.5.0|

Looks like we detected the workspace was expired while trying to send heartbeat to connect to service. @dlebu Can you take a look? If this is by design, then we should not show "Report a problem" to GitHub for this information message.
@Ramnikov Can you attach liveshare logs, you can get them by running "liveshare: export logs" from vscode command palette.

@Ramnikov Can you confirm if you had the collaboration session open for a long time (i.e. more than 20 days) before experiencing this issue?

@Ramnikov any update? Were you unblocked eventually?

Dear @dlebu,
the issue did not appear again.
From my side the issue can be closed.
With regards
Andrey


Added new soap requests

This PR adds the SOAP calls for building group tree, see https://github.com/jsforce/jsforce/issues/382

This makes sense to me. Also not even very soapy!

:black_medium_small_square:


fix: card size and add configuration value to set full size card

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

How is the new sizing option being used?

I need to update the readme and editor.
By default it should now have the normal size, like other cards.
If you like to have the card like it was before
Switch to the yaml editor and add at the root level of the card full_size: true

@jankete i've added the option in PR #107 to the visual editor and updated the readme


Add search capabilities.

Add a search bar to the website. Consider using a Jekyll pluging, or google search.

If using google search, then create custom search engine using account from issue #8.


Remove check events from GitHub Updates webhook

Sending all these check messages to discord on every push to every branch is too much imo. Maybe remove this event?

Resolved


Filter real Rust panic!() from those that are caught with catch_unwind()

Hi, thank you for the great extension you made!
I'd like to request a feature to be able to specify lines of code or even files where panic!() is expected and natural. Or if it is simpler, to stop only on panic!() that causes the thread abort (i.e. it was not catched by panic::catch_unwind()
For example we implement cancellation of an operation through a panic
impl Canceled {
    pub fn throw() -> ! {
        std::panic::resume_unwind(Box::new(Canceled::new()))
    }
}

And having the option Rust: op panic turned on it becomes unmanageable to catch real panics.

Do you have any ideas on how to implement it?   Right now breaking on panic is implemented simply as a function breakpoint on rust_panic (which is called early during a panic).   I don't know of a similarly easy way to break on "unhandled panics".
Please keep in mind that users will expect this to work with all panic unwind implementations, of which Rust currently has at least four: DWARF, SjLj, SEH, SEH64, depending on target platform.

@vadimcn, hmm, sorry I am not experienced with that so much. You are right, something like "uncaught panic" or "unhandled panic" would be the better name.
I'd imagine we could scan the callstack for catch_unwind and resume when found. I know that JS debugger implements similar "Uncaught error" option, maybe we cheat and see some of their code, but I doubt it would be so helpful due to totally different world of Rust and JS

And, to clarify this option should not replace existing onpanic, it better be just one more checkbox.

I expect that getting this to work reliably on all platforms will be challenging... not something I want to invest my time into right now.
But since you only need this to work in your particular setup, you could probably create Python script that does what you want and attach it as a callback  to a breakpoint.  Have it return true if you want to stop and false otherwise.


[Bug] [K8s Workflow Node] The job on k8s is running, but the node shows failure

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
After the job is submitted to k8s, the node fails. (in fact, the job on k8s is running)
And I can't find any error logs.
...
...
[INFO] 2022-12-30 16:33:15.955 +0800 - [K8sJobExecutor-examples-68] start to submit job
[INFO] 2022-12-30 16:33:16.195 +0800 - [K8sJobExecutor-examples-68]  submitted job successfully
[INFO] 2022-12-30 16:33:57.990 +0800 - Send task execute result to master, the current task status: TaskExecutionStatus{code=6, desc='failure'}
[INFO] 2022-12-30 16:33:57.990 +0800 - Remove the current task execute context from worker cache
...
...

Full log
[INFO] 2022-12-30 16:33:15.641 +0800 - Begin to pulling task
[INFO] 2022-12-30 16:33:15.708 +0800 - Begin to initialize task
[INFO] 2022-12-30 16:33:15.741 +0800 - Set task startTime: Fri Dec 30 16:33:15 CST 2022
[INFO] 2022-12-30 16:33:15.783 +0800 - Set task envFile: /opt/dolphinscheduler/conf/dolphinscheduler_env.sh
[INFO] 2022-12-30 16:33:15.784 +0800 - Set task appId: 36_68
[INFO] 2022-12-30 16:33:15.833 +0800 - End initialize task
[INFO] 2022-12-30 16:33:15.834 +0800 - Set task status to TaskExecutionStatus{code=1, desc='running'}
[INFO] 2022-12-30 16:33:15.835 +0800 - TenantCode:root check success
[INFO] 2022-12-30 16:33:15.917 +0800 - ProcessExecDir:/tmp/dolphinscheduler/exec/process/root/7826084625920/8058590247072_4/36/68 check success
[INFO] 2022-12-30 16:33:15.951 +0800 - Resources:{} check success
[INFO] 2022-12-30 16:33:15.951 +0800 - Task plugin: K8S create success
[INFO] 2022-12-30 16:33:15.951 +0800 - Success initialized task plugin instance success
[INFO] 2022-12-30 16:33:15.951 +0800 - Success set taskVarPool: null
[INFO] 2022-12-30 16:33:15.955 +0800 - [K8sJobExecutor-examples-68] start to submit job
[INFO] 2022-12-30 16:33:16.195 +0800 - [K8sJobExecutor-examples-68]  submitted job successfully
[INFO] 2022-12-30 16:33:57.990 +0800 - Send task execute result to master, the current task status: TaskExecutionStatus{code=6, desc='failure'}
[INFO] 2022-12-30 16:33:57.990 +0800 - Remove the current task execute context from worker cache
[INFO] 2022-12-30 16:33:58.023 +0800 - The current execute mode isn't develop mode, will clear the task execute file: /tmp/dolphinscheduler/exec/process/root/7826084625920/8058590247072_4/36/68

What you expected to happen
The k8s node is awesome, hope it works
How to reproduce
Version: 3.1.1
Create a workflow, add k8s task nodes, and use a correct image ...
Always happens.
Anything else
No response
Version
3.1.x
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I will fix this  issue.


chore: update dependencies

Updated both bower and npm dependencies to latest versions. Most notably angular, karma, protractor and http-server. Note that some older versions of http-server (and transitively karma) threw errors on Windows with non-english locales.
Tested all scripts with node versions 4.4.0 and 5.9.0 (on Windows 10) and everything seems to work as expected.
--
There is also a 2nd (optional) commit that changes the served folder to ./app (instead of the project root). I think it makes sense, but I may have missed the reasoning for the original decision.

Superceeded by #341.


Running LongQC always returns Killed error

Hi, thanks for creating LongQC. I am trying it on PacBio subreads BAM file which has 160 GB, but I am always getting Killed error. Here is my command:
/usr/src/Python-3.10.0/python /opt/LongQC/longQC.py sampleqc --output sample_longQC --preset pb-sequel --index 200M --sample_name sample --ncpu 10 --mem 1 m64065_200925_092426.subreads.bam
I tried different values for CPU, mem and index but always getting Killed error. I suppose main culprit is creation of fastq files in Analysis folder. Is there a way for that to be omitted, since I am only using figures, not fastq file. Version of software is LongQC 1.2.0c.

Hi @looxon93,
Thanks for your interests in our app and valuable feedback.
Indeed, managing subreads.bam is much tougher than HiFi bam in many aspects. fastq (or fasta) is the only acceptable format for some internal calculation, hence the conversion from bam to fastq. The figures technically generated from those fastq files, not from bam or any other files. I'm not sure the cause of Killing, but if it's caused by space issue, then skipping this conversion is actually not trivial for LongQC, even for figures.
Also, in subread case, memory requirement can be quite high. In default (4G), in some cases, >100G bytes memory could be needed, this is particularly common for reads having a skewed GC composition. You've already reduced it to 200M (0.2G), but please make sure your env has enough memory for even 0.2G index size as OOM error can kill the process either. 16GB memory would be ok for 0.2G index size (--index option).
Yoshinori


Fix error with fly

The fly function invalidly reads the third argument of the command function as a boolean. This works fine if said command is ran via the flynoclip
If the :fly command is ran via normal means this is what the noclip argument of the function will be a table, it won't be a boolean. The argument noclip will be normally this table:
{
	["Options"] =  ▼  {
		["Chat"] = true
	},
	["PlayerData"] =  ▼  {
		["Level"] = 900,
		["Player"] = "Player1",
		["isDonor"] = true
	}
}

This is invalid behavior, and adonis sets the .Value of the BoolValue to that table, which results in undocumented behavior (currently it sets to true, but if an update comes to Rbx then it would have a different result, or totally break).
Another issue is that the :flynoclip command sends it's full args to the :fly commands function, meaing if you do :flynoclip all, each player will then run :fly all which causes a lot of lag.
Also using a pre-defined function argument instead of a command argument conflicts with current (and potentially future)
This pull request fixes:

Invalid usage of the third function argument (stops conflicting with global function arguments,  stops undocumented instance property behavior)
:flynoclip invalidly using the args table resulting in undesired behavior and lag (if ran on multiple people)

Fixed by:

Function argument bug fixed by using command arguments instead of function arguments
:flynoclip bug fixed by using a custom args table

Note: I didn't know #939 existed. However this one has a more thorough fix for the fly error. And this also fixes another issue with :flynoclip


Unable to create product through Dashboard 2.0

What I'm trying to achieve
To create a product.
Steps to reproduce the problem

Try to add a product through the new Dashboard.

~Enter just the name -> Something went wrong: GraphQL error: 'NoneType' object has no attribute 'has_variants'~ - Fixed in https://github.com/mirumee/saleor/pull/3804
Enter name and product type (variant-less) and any other fields (all or just couple) -> Save changes to Error and nothing happens, SKU field is required but not shown
Required fields are not marked as required.

What I expected to happen
Product is successfully created.
Screenshots

No required fields

System information
Operating system: n/a
Browser: Chrome

One issues with the API:

throws an exception when product-type is not selected

Other front-end related issues:

when a variant-less product type is selected the SKU field is not shown
required fields are not shown, instead "Save" changes to "Error" when attempting to save

There's also a problem with sending "null" (in quotes) for descriptionJson (JSONString) fields, it throws an error Expected type "JSONString", found "null".. From the looks of it it's a known issue -> https://github.com/graphql-python/graphql-core/issues/224.
@dominik-zeglen any way we can instead send null (without quotes) or "" for empty description?

I think we're not showing errors coming from API in this view (which is not the first time we forget about it - maybe we should improve our components to require it somehow?)


Unsupported op: type: reshape

When trying to compile a neural network that ends with a reshape layer, I got the following output:
(vitis-ai-tensorflow2) Vitis-AI /workspace > vai_c_tensorflow2 -m quantized_model_test.h5 -a /opt/vitis_ai/compiler/arch/DPUCVDX8G/VCK190/arch.json -o vai_c_output -n test --options "{'cpu_arch': 'arm64', 'mode': 'normal', 'save_kernel': ''}"
**************************************************
* VITIS_AI Compilation - Xilinx Inc.
**************************************************
[INFO] Namespace(batchsize=1, inputs_shape=None, layout='NHWC', model_files=['quantized_model_test.h5'], model_type='tensorflow2', named_inputs_shape=None, out_filename='/tmp/test_org.xmodel', proto=None)
[INFO] tensorflow2 model: quantized_model_test.h5
[INFO] keras version: 2.4.0
[INFO] Tensorflow Keras model type: functional
[INFO] parse raw model     : 94%|█████████████████████████████████████▋  | 16/17 [00:00<00:00, 19548.17it/s]
Traceback (most recent call last):
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/bin/xnnc-run", line 33, in <module>
    sys.exit(load_entry_point('xnnc==1.4.0', 'console_scripts', 'xnnc-run')())
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/__main__.py", line 49, in main
    runner.normal_run(args)
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/runner.py", line 123, in normal_run
    target=target,
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/xconverter.py", line 145, in run
    model_files, model_type, _layout, in_shapes, batchsize
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/core.py", line 123, in make_xmodel
    model_type=model_t,
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/translator/tensorflow_translator.py", line 107, in to_xmodel
    model_type,
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/translator/tensorflow_translator.py", line 177, in create_xmodel
    name, layers, layout, in_shapes, batchsize
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/translator/tensorflow_translator.py", line 2119, in __create_xmodel_from_tf2
    f"*** Unsupported op: type: {op_type}, name: {wrapper_name}"
ValueError: *** Unsupported op: type: reshape, name: tf_op_layer_Reshape

The documentation states that the Reshape operation is supported in TF2. Is it because the Reshape is the last layer?
I use Vitis-AI 1.4.1.

Hello,Sorry for late reply.
Please provide model files.

Can you share your floating point model and quantized model so we can analyze the problem further. Thank you.

Hi @NeutrinoXY ，
This problem has been fixed in Vitis AI 2.5, please use Vitis AI 2.5 docker. Do you have any other questions? If not, we will close this issue. If there is a new issue later, please reopen the issue. Thank you.