CC, CXX: .pythranrc + env variables, who win?

It seems to me that when both CC/CXX environment variables and .pythranrc are set, the content of the environment variables is used.
In the doc, it is not clear who win in this case:

Wants to try your own compiler? Update the CC and CXX fields from your pythranrc, or set the same env variables to the right compilers.

On Intel environment, it seems to me that it would be good that
.pythranrc > env variables

because CC and CXX can be used for other things (to use icc).
If we want to keep environment variables stronger than the values in .pythranrc, we can have
PYTHRAN_CC / PYTHRAN_CPP > .pythranrc > CC/CPP

mmmh, while I understand your issue, the generally accepted rule is to have env variable take precedence over config file, as in:

https://docs.pylonsproject.org/projects/pyramid/en/latest/narr/environment.html
https://docs.docker.com/compose/env-file/

so we definitievely want
env variables > .pythranrc

In addition to common practice, the rational seems to be: you can change an env variable per call, while you don't change settings that often.
It would be an API change to rename CC/CXX to PYTHRAN_*, and I'm not sure I want to go that way.
Still there is hope for you :-)
If you want to set the compiler used by pythran while CC/CXX are already set, say by iccsetvars.sh then add an alias:
alias pythran="CC=gcc CXX=gcc pythran"

and if you want PYTHRAN_CC to override CC, a simple wrapper like
!/bin/sh
PYTHRAN="/path/to/pythran"
if [ -n "$PYTHRAN_CC" ]; then
    export CC=$PYTHRAN_CC
fi
$PYTHRAN $*

should do the trick

#1050 clarifies the situation.

Your proposed solutions would work when using the command line pythran but not when Pythran is used in a setup.py.  In this case, I don't see how one can build a package using Pythran if CC/CXX point towards the Intel compiler. That's why I proposed that Pythran would be sensible both to CC and PYTHRAN_CC with the following precedence:
PYTHRAN_CC / PYTHRAN_CXX > .pythranrc > CC/CXX
But anyway, now that it is clear in the doc that CC/CXX > .pythranrc, it's acceptable.
But people (and I) will need to write warnings in the documentation of packages using Pythran, since in clusters, intel modules tend to define CC/CXX so users can be surprized to get a compile error doing (with a correct .pythranrc):
module load intel/17.2
pip install a_package_using_pythran

What about
PYTHRANCC > CC > .pythranrc

would that solve yourt issue?

It would solve an issue but then if we introduce another env variable (PYTHRANCC), I don't understand the advantage of
PYTHRANCC > CC > .pythranrc
compare to
PYTHRANCC > .pythranrc > CC
I see one advantage of PYTHRANCC > .pythranrc > CC, which is that we avoid this strange behavior for people who correctly set .pythranrc and don't know about CC/CXX variables and still cannot install a package using Pythran. The users get a unclear compilation error and don't understand what happen. For an example, see https://bitbucket.org/fluiddyn/fluidfft/issues/16
If we have PYTHRANCC + CC, one can easily override the config file setting per call.
If we have PYTHRANCC + CC, we don't rename CC/CXX to PYTHRAN_* since CC/CXX are still taken into account.

The issue youmention makes sense. Still, CC > config is the defacto standard... I don't see any easy solution to this, apart from having pythran-genertaed code be icc compilant :-)
Documentation merged in #1050

apart from having pythran-genertaed code be icc compilant :-)

Sure it would be the best solution!
I close this issue since the doc is now explicit. Users just have to be careful. :-)


SOME PROBLEMS

Hi, this program is very fantastic and useful, but i meet some problems.
I've installed Anaconda, but i can't installed pyqt4 ,there is only python3.x+pyqt5.
Another issue is in generateGrid.py.
def openGrid(self):

    flags = QFileDialog.DontResolveSymlinks | QFileDialog.ShowDirsOnly #ask for a directory
    gridDirectory = QFileDialog.getExistingDirectory(self, 'Data Folder containing grid files', '', flags)

    if gridDirectory == "":
        return
    else:
        #Test if files exists and extract data

        gridX_entities = getData.getDataFromFile([gridDirectory+'/gridx.dat'], 0, singleColumn=1)
        gridY_entities = getData.getDataFromFile([gridDirectory+'/gridy.dat'], 0, singleColumn=1)

Can't find reference 'getData.getDataFromFile' in 'getData.py.'.
When i click open analysis,it will crash.

Hi,
I've  created a fork for Python 3.6 + PyQt 5 here: https://github.com/JurriDluggi/Python_DIC/tree/pyQt5
I tried to change gridx.dat/gridy.csv to gridx.csv/gridy.csv, which is being generated...
but the GUI still crashes in some cases...


[Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [HttpClientGroupMapping]

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request

located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/consumer/HttpClientGroupMapping.java line 309,314
analysis and explanation:
This method calls the size() method on a collection and compares the result to zero to see if the collection is empty.
Describe the solution you'd like
For better code clarity, it is better to just use col.isEmpty().
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

I would like to work on this issue. Please assign it to me.

No size()method is present at line 309,314

No size()method is present at line 309,314

Due to code updates, it may be different from the actual location, which is now at lines 362 and 369.

@Alonexc
I will do it by eod


how to reset/unset textures?

This may be a silly question, but how do you unset or reset a texture after it's applied? In other words how do you clear/remove a texture that was set?
edit: looking at the code, I guess entering an empty string for the filename works? However all the Texture properties are still on the geometry objects. It would be nice to be able to remove them completely.

This may be a silly question, but how do you unset or reset a texture after it's applied? In other words how do you clear/remove a texture that was set?

Yes, if you set empty string to URL the texture will be reset. If you reload the file the textures will not be visible.

edit: looking at the code, I guess entering an empty string for the filename works? However all the Texture properties are still on the geometry objects. It would be nice to be able to remove them completely.

This should be new option in this case. But there is small problem with unload texture at current 3D view. I was trying to do that but the FreeCAD crashed. So for now you can only remove the URL and reload the FreeCAD project file.
Feel free to reopen this issue or create new one. I will think about it in the future, so maybe there will be some improvements.


Static links to tag releases changed

Hi @brycelelbach, something changed when you revised the release logs yesterday. We used to point to https://github.com/NVlabs/cub/archive/v1.8.0.tar.gz but now it changes to https://github.com/NVlabs/cub/archive/1.8.0.tar.gz (the "v" is missing). I think it is a breaking change. Any chance it could be reverted?

CI log:
https://dev.azure.com/nsls2forge/nsls2forge/_build/results?buildId=2572&view=logs&j=2928da41-3b64-5ab6-d69b-0a36120eed79&t=63f0ac55-36da-5f67-e095-598517af0be7&l=443

Whoops, yes that was a mistake; the v tags should be left for compatibility
reasons. Can you update to point at the new tags though?
--
Bryce Adelstein Lelbach aka wash
US Programming Language Standards (PL22) Chair
ISO C++ Library Evolution Chair
CppCon and C++Now Program Chair
CUDA Core C++ Libraries (Thrust, CUB, libcu++) Lead @ NVIDIA
On Tue, May 19, 2020, 07:20 Leo Fang<EMAIL_ADDRESS>wrote:

CI log:
https://dev.azure.com/nsls2forge/nsls2forge/_build/results?buildId=2572&view=logs&j=2928da41-3b64-5ab6-d69b-0a36120eed79&t=63f0ac55-36da-5f67-e095-598517af0be7&l=443
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NVlabs/cub/issues/182#issuecomment-630850795, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADBG4WA7TR2TYJCVFB6E2DRSKIRHANCNFSM4NFBOPTA
.

Thanks, Bryce. Yes we can, just wanna make sure it won't change again 🙂

It won't change again. If you can just update to the new link, that would
be great
--
Bryce Adelstein Lelbach aka wash
US Programming Language Standards (PL22) Chair
ISO C++ Library Evolution Chair
CppCon and C++Now Program Chair
CUDA Core C++ Libraries (Thrust, CUB, libcu++) Lead @ NVIDIA
On Tue, May 19, 2020, 09:26 Leo Fang<EMAIL_ADDRESS>wrote:

Thanks, Bryce. Yes we can, just wanna make sure it won't change again 🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NVlabs/cub/issues/182#issuecomment-630931179, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADBG4UIFLMHKFTKTJR5YLLRSKXLLANCNFSM4NFBOPTA
.

Actually it would really be best if you just start using CUB from the CUDA
toolkit. You'll be broken by 11.0 anyways if you dont, as CUB and Thrust
are version locked.
--
Bryce Adelstein Lelbach aka wash
US Programming Language Standards (PL22) Chair
ISO C++ Library Evolution Chair
CppCon and C++Now Program Chair
CUDA Core C++ Libraries (Thrust, CUB, libcu++) Lead @ NVIDIA
On Tue, May 19, 2020, 09:29 Bryce Adelstein Lelbach aka wash <
<EMAIL_ADDRESS>wrote:

It won't change again. If you can just update to the new link, that would
be great
--
Bryce Adelstein Lelbach aka wash
US Programming Language Standards (PL22) Chair
ISO C++ Library Evolution Chair
CppCon and C++Now Program Chair
CUDA Core C++ Libraries (Thrust, CUB, libcu++) Lead @ NVIDIA
On Tue, May 19, 2020, 09:26 Leo Fang<EMAIL_ADDRESS>wrote:

Thanks, Bryce. Yes we can, just wanna make sure it won't change again 🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NVlabs/cub/issues/182#issuecomment-630931179, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADBG4UIFLMHKFTKTJR5YLLRSKXLLANCNFSM4NFBOPTA
.

Actually it would really be best if you just start using CUB from the CUDA toolkit. You'll be broken by 11.0 anyways if you dont, as CUB and Thrust are version locked.

Hi Bryce, yes I was aware of this change, and in fact it was brought up recently (https://github.com/cupy/cupy/issues/3346).
The problem for package and library providers is backward compatibility: I expect it takes a few more years for dropping CUDA 9 & 10 completely, and before that happens we need a way to build the CUB support, without or with the pretense of Thrust. (In CuPy the two supports are currently independent of each other.)
Plus, some advanced users may be unhappy with the shipped CUB version and want to stay up-to-date, so I think there will be a need to hack the locking mechanism you recently added to CUB and Thrust so as to make them decoupled. I would love to know if you have good suggestions.

The best option to stay on an older version of CUB is to check out both an older version of CUB and an older version of Thrust.

Fixed, up to 1.8.0, and just on the https://github.com/NVlabs/cub repo. For newer releases and the current development trunk https://github.com/thrust/cub, please use the A.B.C scheme instead of vA.B.C

Thanks for follow-up, @brycelelbach.

Fixed, up to 1.8.0, and just on the https://github.com/NVlabs/cub repo.

As of 12:18am, May 20, the link still does not contain the "v" prefix: https://github.com/NVlabs/cub/archive/1.8.0.tar.gz. Could it be that it takes a day or longer to reflect the changes?

For newer releases and the current development trunk https://github.com/thrust/cub, please use the A.B.C scheme instead of vA.B.C

Sounds good. My only question for the latest releases on NVlabs/cub: Are they meant to mirror what are available on Thrust/cub?

While I think it's best to have a separate issue on this discussion, for my own needs I am almost there, so let me continue 😅

The best option to stay on an older version of CUB is to check out both an older version of CUB and an older version of Thrust.

So, if an application only needs CUB (as it can be used indep. of Thrust), it won't matter (as it was) what version(s) of Thrust are available in the include search path, right?

https://github.com/NVlabs/cub/archive/v1.8.0.tar.gz
Works fine for me
--
Bryce Adelstein Lelbach aka wash
US Programming Language Standards (PL22) Chair
ISO C++ Library Evolution Chair
CppCon and C++Now Program Chair
CUDA Core C++ Libraries (Thrust, CUB, libcu++) Lead @ NVIDIA
On Tue, May 19, 2020, 21:21 Leo Fang<EMAIL_ADDRESS>wrote:

Thanks for follow-up, @brycelelbach https://github.com/brycelelbach.
Fixed, up to 1.8.0, and just on the https://github.com/NVlabs/cub repo.
As of 12:18am EST, May 20, the link still does not contain the "v" prefix:
https://github.com/NVlabs/cub/archive/1.8.0.tar.gz. Could it be that it
takes a day or longer to reflect the changes?
For newer releases and the current development trunk
https://github.com/thrust/cub, please use the A.B.C scheme instead of
vA.B.C
Sounds good. My only question for the latest releases on NVlabs/cub: Are
they meant to mirror what are available on Thrust/cub?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NVlabs/cub/issues/182#issuecomment-631227091, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADBG4WITR55ZH26RUY64J3RSNLDZANCNFSM4NFBOPTA
.

Oh OK...So this is a hidden link not shown in the release notes.

Yes; that is a legacy link. It will work but please don't rely on it for
future releases. We want one tagging scheme across all our libraries to
simplify our scripting and that scheme is X.Y.Z
--
Bryce Adelstein Lelbach aka wash
US Programming Language Standards (PL22) Chair
ISO C++ Library Evolution Chair
CppCon and C++Now Program Chair
CUDA Core C++ Libraries (Thrust, CUB, libcu++) Lead @ NVIDIA
On Tue, May 19, 2020, 22:38 Leo Fang<EMAIL_ADDRESS>wrote:

Oh OK...So this is a hidden link not shown in the release notes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NVlabs/cub/issues/182#issuecomment-631248219, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADBG4SEBB4AFISP4JWYDV3RSNUDVANCNFSM4NFBOPTA
.

Thanks, Bryce! https://github.com/NVlabs/cub/issues/182#issuecomment-631227729 is my last question 🙏

CUB depends on Thrust; there's a circular dependency in some of the iterator headers. Depending on what you are using you may or may not depend on Thrust.

Thanks a lot, Bryce! So we better get some tests with newer CUB started, preferably before CUDA 11 is released so we have some time to make any necessary fix.
I think the main thread is addressed, so are my side questions 😅 So I'm closing it.


⚠ Not detecting travis-ci.com statuses

TravisCI has recently stopped using the commit status, and has switched to only using the checks API.
This breaks greenkeeper, because it'll push the commits, and will wait until CI finishes, but will never do anything because of that change.
Ref: https://blog.travis-ci.com/2018-09-27-deprecating-github-commit-status-api-for-github-apps-managed-repositories

Hey, did you update the permissions for greenkeeper? The status checks require a new permission from the user otherwise greenkeeper is not allowed to receive the webhooks. It might be hard to find, there should be a highlighted section in the settings for greenkeeper in github

I haven't seen that greenkeeper was requesting new permissions. Usually if an app wants new permissions I get an email notification.
I just checked, and greenkeeper does have access to the checks API

From: anderspree<EMAIL_ADDRESS>Sent: Saturday, October 6, 2018 9:44:37 AM
To: greenkeeperio/greenkeeper
Cc: wolfy1339; Author
Subject: Re: [greenkeeperio/greenkeeper] ⚠ Not detecting travis-ci.com statuses (#944)
Hey, did you update the permissions for greenkeeper? The status checks require a new permission from the user otherwise greenkeeper is not allowed to receive the webhooks. It might be hard to find, there should be a highlighted section in the settings for greenkeeper in github
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/greenkeeperio/greenkeeper/issues/944#issuecomment-427575030, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEYfFWYH-pNqbUuRq6dgtSz0cXOoceQYks5uiLPFgaJpZM4XLMYq.

Is it an error that this was closed?
Greenkeeper does have access to checks. I have double checked.

From: anderspree<EMAIL_ADDRESS>Sent: Monday, October 8, 2018 4:19:17 AM
To: greenkeeperio/greenkeeper
Cc: wolfy1339; Author
Subject: Re: [greenkeeperio/greenkeeper] ⚠ Not detecting travis-ci.com statuses (#944)
Closed #944https://github.com/greenkeeperio/greenkeeper/issues/944.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/greenkeeperio/greenkeeper/issues/944#event-1889635525, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEYfFWQMl2OWOgxl_dbbUwl5G9T704Ubks5uiwqFgaJpZM4XLMYq.

oh ok, sorry I read that as the missing permissions were the cause

if its helpful, my projects continue to get the PRs from greenkeeper correctly. we use travis for public and private projects and have not seen any problem with the PRs getting opened

@wolfy1339 can you write me the affected repositories, here or via<EMAIL_ADDRESS>I couldn't find something in the logs so far.

https://github.com/hellomouse/GNS
It created the branch and all, but didn't create a PR. I created the PR manually myself

Greenkeeper just created another branch with no PR. Here's the specific branch: https://github.com/hellomouse/GNS/tree/greenkeeper/%40octokit/rest-15.13.1

you have that dependency defined as a range. greenkeeper creates a branch to determine if in-range updates break your build, but doesn't open a PR for in-range updates because your defined range would already include them. you will only get PRs for updates that fall outside your defined range.
https://greenkeeper.io/docs#greenkeeper-step-by-step

Alright, but then the branch shouldn’t be left there afterwards? Greenkeeoer should clean up after itself like it does when it’s PRs are merged
From: Matt<EMAIL_ADDRESS>Sent: October 10, 2018 12:14
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [greenkeeperio/greenkeeper] ⚠ Not detecting travis-ci.com statuses (#944)
you have that dependency defined as a range. greenkeeper creates a branch to determine if in-range updates break your build, but doesn't open a PR for in-range updates because your defined range would already include them. you will only get PRs for updates that fall outside your defined range.
https://greenkeeper.io/docs#greenkeeper-step-by-step
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/greenkeeperio/greenkeeper/issues/944#issuecomment-428634946, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEYfFZooBmbkJmGOcOmo6VU9sN__UMJ5ks5ujhztgaJpZM4XLMYq.

yeah, that should be what happens. if that's not the case, might be worth changing the title of this issue to make it clear what the problem really is


/versions returned HTTP 502

As stated earlier I'm using Synapse Docker + Nginx as my homeserver configuration. But nowhere Nginx configuration mentioned something about /versions location.
Anyhow, now I see this warning in sliding-sync (I got sliding-sync working now and it works with Element X). However I think Synapse and the Nginx example configurations need to be improved to avoid seeing:
16:58:40 WRN Could not contact upstream homeserver. Is SYNCV3_SERVER set correctly? error="/versions returned HTTP 502" dest=https://matrix.melroy.org

If sliding-sync means _matrix/client/versions. Then I do not understand the error, since that works at my side:
https://matrix.melroy.org/_matrix/client/versions

Same here, downgrading to v0.99.14 makes things work again.

Same here, downgrading to v0.99.14 makes things work again.

Uh. OK? But does that version do a version check? If so what is the url then?

Downgrading shouldn't help at all, as that code hasn't been touched between 0.99.14 and 0.99.15.
It will help to show the architecture here:
                                              +------------+
                                .-----------> | Homeserver |
                               |              +------------+
+---------+           +---------------+           ^
| Clients | <-------> | Reverse Proxy |           | /sync, /versions check
+---------+           +---------------+           v
                               |              +--------------------+
                               `------------> | Sliding Sync Proxy |
                                              +--------------------+

The environment variable SYNCV3_SERVER controls how the proxy will talk to your homeserver. On startup, the proxy will do a quick check to see if this variable seems correct. It does this by issuing an HTTP GET /_matrix/client/versions. If this fails, it may indicate a problem with your networking (i.e SYNCV3_SERVER is wrong). It is only a warning because there are valid networking configurations where you can hit /sync and other required endpoints, but /versions is not allowed.

If sliding-sync means _matrix/client/versions. Then I do not understand the error, since that works at my side:
https://matrix.melroy.org/_matrix/client/versions

This is not the same thing as what I'm describing. I'm describing how to connect to your homeserver from the point of view of a container behind the reverse proxy. What you're doing by hitting this URL is going down the "Client -> Reverse Proxy -> Homeserver" route, which as you can see, is independent to the arrow between "Sliding Sync Proxy -> Homeserver".
Hopefully this provides enough information to debug your networking configuration.

My synapse and syncv3 are also both running in docker containers with nginx as reverse proxy.
I am getting the same warning:
error="Get \"http://matrix-synapse:8008/_matrix/client/versions\": dial tcp <IP_ADDRESS>:8008: connect: connection refused" dest=http://matrix-synapse:8008
But inside the syncv3 docker I can perfectly curl that url with the expected JSON as response!
Also the Element X app says my server doesn't support sliding sync.

@SoftwareSchlosser I had the same problem. This is probably happening because synapse server is not fully started. I fix it with adding healthcheck to synapse server.
healthcheck:
  test: ["CMD", "curl", "-fSs", "http://localhost:8008/health"]
  interval: 15s
  timeout: 5s
  retries: 3
  start_period: 5s

and add depends_on to sliding sync.
depends_on:
  synapse:
    condition: service_healthy


invalid example code?

The docs show the following to set "to" field for an email:
data = { "to" =><EMAIL_ADDRESS>whom!"} }
But it doesn't seem to work. I had to use:
data = { "to" =><EMAIL_ADDRESS>}

Hello,
Thank you for contacting us.
Issue discussed & closed here https://github.com/mailin-api/sendinblue-ruby-gem/issues/4
Regards
SendinBlue Team


Clarify the interaction between trampolines and -Wl,-z,noexecstack

Clarify the description of -Wtrampolines and -Wl,-z,noexecstack to make it clear code that requires trampolines on the stack will crash with the -Wl,-z,noexecstack mitigation and how the usage of -Wtrampolines warns of such occurences.
Also adds an additional considerations for -Wl,-z,noexecstack covering:

how modern compilers determine the noexecstack markings automatically, but missing markings result in the stack being mapped executable
how Linux versions prior to 5.8 also expose other program data executable if the stack is not mapped as non-executable

+1


Compendiumcollection

closes #651

There are some open TODOs concerning the metadata and some generics. I'm kinda clueless as to what I should do there


Added Dutch translation

🙂

Awesome! I will try to review soon, there is also a in game asset to translate 'Charging paper' see my other merge request for the german one, I can gimp it if you just want to provide translation.


4 more data/info sources

Thanks, Matt! A couple of questions:

It looks like the mosquito data/study you added is an earlier/nearly-identical version of the study already listed in this guide. (Same authors, same approach.) Or am I misunderstanding?

The spread prediction paper is very interesting, but currently doesn't contain any structured data. I'm trying to get the data, but haven't received it yet. Do you happen to have the data, by any chance?

It looks like the mosquito distribution paper I added was written as a precursor to, or just one part of, the 'global compendium' paper. They both reference the same data. I think the source you already have is more complete though. I've removed the reference to that paper but have left the csv data in.
I don't think the data from the spread prediction paper is public and I haven't attempted to contact anyone for it.

Thanks! Very helpful. Made a few edits here: https://github.com/BuzzFeedNews/zika-data/tree/pr-4

Some language tweaks.
Removed the mosquito CSV, since it's already easily available, stable, and well-documented, on Dryad.
Waiting to include the spread-prediction paper until data from it is available.

Does that look good to you? If so, I'll merge that in and add you to the acknowledgements.

Yep looks good. Closing this PR.


Add glob support to tcp+sni

We'd love to have glob matching for the tcp+sni requests.
I'll make a PR for this if I can.

@jorgemarey By any means please do ! :)


(#101) Added missing instructions for EPEL

Also clarified optional packages for RHEL server vs. workstation

The link to the Git Contributions wiki page has changed to https://github.com/google/earthenterprise/wiki/Development:-Git-Contributions.  We need to change that in README.md

While we're on this, should we also consider reviewing the script that automates the environment setup on the different platforms?

@tst-ppenev I've never used that script. I can maybe take a look at it with some context, but it seems like it might be beyond the scope of this ticket, or at least beyond the scope of this pull request :)

@tst-ccamp: Yeah, it certainly is outside the scope of this ticket. I was just thinking, it may be easier to tell a third-party user they can also run a script, instead of reading setup instructions.
It's at https://github.com/google/earthenterprise/pull/412/files#diff-00e002f840808e80a2c02dc2b9d5a19f. It doesn't use the DTS repositories, so it may need to be updated, if we want to use them. I wasn't sure if we can do without EPEL, if we use DTS, or what we, actually, use from it.

Plenty of approvals - merging.


ip address of dockerized client in distributed testing

Hello, for running client in distributed testing mode using docker, how can we assign a reachable ip address for the client container?
When I start client it has container ip of <IP_ADDRESS>
But my remote jmeter docker (running on container host <IP_ADDRESS>:1099) tries  to connect to <IP_ADDRESS> but can't. It has error
2019-07-22 18:15:47,937 ERROR o.a.j.s.RemoteTestListenerWrapper: Exception on testEnded on host <IP_ADDRESS>:1099
java.rmi.ConnectIOException: Exception creating connection to: <IP_ADDRESS>; nested exception is:
	java.net.NoRouteToHostException: Host is unreachable (Host unreachable)

I discovered that we should pass in --network=host when invoking the docker run for the client and that will provide a reachable ip.


Calling wt from cmd for working directory "C:" causes an error

Hi,
I was testing the new command line options to open a Windows Terminal for a specified working directory. When calling wt new-tab -d "C:\" from PowerShell this seems to work. Calling the same command from cmd however will print the error message [error 0x8007010b when launching powershell.exe']` in the newly opened Windows Terminal instance. Using the "-p" option to launch a different shell will provoke the same error message for the executable associated with the specified profile name.
Environment
Windows build number: Microsoft Windows [Version 10.0.18363.657]
Windows Terminal version: 0.9.433.0

Steps to reproduce
Call wt new-tab -d "C:\" from cmd.
Expected behavior
Open a new Windows Terminal tab with path C:\ set as the current working directory.
Actual behavior
Opens a Windows Terminal instance with the message:
[error 0x8007010b when launching `powershell.exe']

Interesting. It looks like we're not handling quotes properly when there aren't spaces.

Unfortunately this is the default behavior if the command line gets tokenized to argv. This is unrelated to spaces in the path. The backslash just escapes the double quote and thus, it's treated as literal character. Also CommandLineToArgvW behaves the same.
You could escape the backslash with another backslash make it work again like wt new-tab -d "C:\\".
If we want to fix that we would need to establish our own command line tokenization.

Yeah had the same error when using this command wt -d C:\Users\cinnamon\GitHub\WindowsTerminal ; split-pane -p "Command Prompt" ; split-pane -p "Ubuntu" -d \wsl$\Ubuntu\home\cinnak -H

You must know that your username is not cinnamon, right?

Yes, but that's not the issue here

What else is the issue then? You call it with a non-existing user profile and with wsl$ which certainly should have been rather $wsl (but which I wouldn't expect to get expanded to a value in a Windows command line).

(Actually, wsl$ is correct here. "cinnamon" and "cinnak" are not correct.)
It also looks like you don't even have a profile named Ubuntu.
Kayla's example was an example, not something that you can just run out of nowhere. You need to have a "command prompt" profile and an "ubuntu" profile, and the directories she's listed in the arguments, for it to work the same way.
You may benefit from the command line arguments documentation.

Similarly I'm trying to set a context menu shortcut via registry to open terminal from a folder's background context menu.  I used to do this successfully with cmder by setting the command to "c:\path\to\cmder.exe" /START "%V".
Trying this with "C:\Users\krage\AppData\Local\Microsoft\WindowsApps\wt.exe" --startingDirectory "%V" shows the same 0x8007010b error when the path is the root of a lettered drive.  It seems to work for other paths though with or without contained spaces, eg. C:\Windows and C:\Program Files both succeed.
I tried changing the command to "C:\Users\krage\AppData\Local\Microsoft\WindowsApps\wt.exe" powershell.exe -NoExit -Command Set-Location -LiteralPath "%V".  Using this in the root of a drive doesn't generate an error but fails to change the path, the powershell session just winds up in the default starting directory of the default terminal profile.  Paths without spaces eg. C:\Windows change directory successfully.  Powershell shows an error for paths with spaces eg. C:\Program Files gives an error like this as though the quotes around the path didn't survive:
Set-Location : A positional parameter cannot be found that accepts argument 'Files'.
At line:1 char:1
+ Set-Location -LiteralPath C:\Program Files
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Set-Location], ParameterBindingException
    + FullyQualifiedErrorId : PositionalParameterNotFound,Microsoft.PowerShell.Commands.SetLocationCommand

As a quick hack for %V, you might be able to use.. hmm. "%V\."?

(Actually, wsl$ is correct here. "cinnamon" and "cinnak" are not correct.)
It also looks like you don't even have a profile named Ubuntu.
Kayla's example was an example, not something that you can just run out of nowhere. You need to have a "command prompt" profile and an "ubuntu" profile, and the directories she's listed in the arguments, for it to work the same way.
You may benefit from the command line arguments documentation.

I have it working with a userprofile of Ubuntu-18.04, but what I'm wondering is what the error as described in the issue is coming from, [error 0x8007010b when launching powershell.exe']`

You're getting that error because you have a specified a working directory (with -d) that does not exist.

You're getting that error because you have a specified a working directory (with -d) that does not exist.

Awesome, thank you, fixed

Awesome, thank you, fixed

As a quick hack for %V, you might be able to use.. hmm. "%V\."?

Thanks, this seems this works everywhere I've tried so far.

Triaged this into 1.0; we should see if there's something we can do about it.

Triaged this into 1.0; we should see if there's something we can do about it.

I can take this and solve it along with #4170. I recall that I already have a piece of code to parse the command line somewhere in my snippet collection. Likely still in C though.
@zadjii-msft Do you think we need an alternative way to preserve literal quotes in the arguments? Or would it be OK to have them removed after tokenization? From what I see in the docs I'd guess it's save to strip them all.

I think that:

"C:" doesn't work in cmd.exe because it escapes the quotation mark
"C:" works in powershell.exe because it uses another character to escape (`)
This is the expected/standard argument handling behavior? This can only be fixed with custom/non-standard argument handling?

(Sorry I deleted my comment earlier.)
Isn't this standard behavior though? It looks like cmd.exe just passes the whole command line to the app while powershell parses the command line with its own rules and then escapes the arguments to recreate a command line. In particular, powershell doesn't care about backslashes so "C:\" is parsed as an argument with value C:\ which is then correctly escaped for CommandLineToArgvW. But cmd.exe just gives the command line as-is so "C:\" gets parsed as C:".
Should we really fix this in the terminal? Is this not a problem from cmd.exe? Other apps behave like this as well:
Powershell:
PS C:\Users\gregd> git "hello\" world
git: 'hello\' is not a git command. See 'git --help'.

cmd:
C:\Users\gregd>git "hello\" world
git: 'hello" world' is not a git command. See 'git --help'.

I think that the terminal should stay consistent with other apps and use the standard CommandLineToArgvW.

Is this not cmd.exe/Powershell's own problem?
Good point. But it doesn't behave the same in all shells and unfortunately it's not only a problem of the CMD. It fails from within the Run dialog and it fails also from a shortcut.
However, I just try to fix this in my PR because it has been accepted as an issue ...

was struggling with  "%V" on command line and seems it need escapes too:  \"%V\"
so ended up on this "Terminal window cmd" command on shell shortcut - if any help...
@="PowerShell -windowstyle hidden -Command \"Start-Process cmd -Verb RunAs -ArgumentList '/c start wt -p cmd -d \"%V\"'\""

Just to confirm, you are starting powershell, to start cmd, to start WT, to start powershell.
Why is your invocation three commands when just one would be fine? That’s crazy.

I've been using these context menu shortcuts:
(https://www.tenforums.com/tutorials/60132-open-bash-window-here-administrator-add-windows-10-a.html)](https://www.tenforums.com/tutorials/60132-open-bash-window-here-administrator-add-windows-10-a.html)
to be able to easy open "Open command/bash window here as administrator"
but I've not found any hint on how to create the same for Windows Terminal?
Actually there are still two more escapes missing from \"%V\" because this doesn't put the "" around path name and also when using shortcut on top of the Drive it requires the \. ending, so this works for all (Directory-Background/-shell/Drive/LibraryFolder):
@="PowerShell -windowstyle hidden -Command \"Start-Process cmd -Verb RunAs -ArgumentList '/c start wt -p cmd -d \"\"%V\\.\"\"'\""

@3col is there any reason you can’t just use wt.exe /d "%V\." instead of launching THREE DIFFERENT SHELLS AT ONCE

I see: you want the runas verb. Hm.

These all come from token errors

Because the Error Message goes throw 3 directories one read one edit one publisher
@UnsnappedKhan8
@krage
@Boereck
@DHowett-MSFT
@salmanmkc
@3col


Remove untranslated chapters

gr/lessons/specifics/eex.md: is an empty file.
pl/lessons/advanced/protocols.md: only the title has been translated.

Check out [this] (https://github.com/doomspork/elixir-school/commit/d55c1a19abd434cfd5680b76fe41563d547ca4bc) commit, it is the one emptying gr/lessons/specifics/eex.md (it's your commit, thats why I reference it)

@gemantzu do we need to add back that lesson or is it okay being removed for now?

I think it should be added back, I can only assume it was only removed by mistake.

You're correct @gemantzu, that is a translated lessons and not a placeholder!  @eksperimental can you take a look at fixing that?

I'm  still wondering how this file got emptied out. I will submit a commit reverting that change, and rebase this one.

I have submitted a new PR to fix the issue with the Greek translation (https://github.com/doomspork/elixir-school/pull/1124)
and I have updated this PR accordingly

BTW, thank you @gemantzu for finding out that mistake of mine

Thank you @eksperimental 👍


Make TAPI performance tests profilable

It wasn't so easy after all, I had to change a few more things around to make the TAPI tests behave more like the other ones. Now it works.


[zh] sync /configuration/secret.md

Sync with en #41137.
Performed an action, without any other changes:

Move ## Types of Secret in front of ## Working with Secrets

See preview please.

/lgtm
/approve


Split Readme into smaller files to improve readability

Move the contributing and FAQ sections into their own files.
Make the Readme file more about the actual information so that the list isn't "below the fold".
Made a number of small content and wording changes as well.

Should now be in a better state for a review.

LGTM LYW! :)


Improved documentation and example around AMBASSADOR_SINGLE_NAMESPACE

AMBASSADOR_SINGLE_NAMESPACE was previously undocumented.

Duplicate of https://github.com/datawire/ambassador/pull/245


feat: add option to "demojify" vimdoc output

Would close #14

Thank you for making the changes so quickly!


Fix deadlock in SftpStore LS

As pointed out by @byungk SftpStore.list deadlocks for directories with more than 64 entries.

Closed in favor of https://github.com/fs2-blobstore/fs2-blobstore/pull/6


Provide a way to get EntityRowMapper

I want to reuse the EntityRowMapper to query using JdbcTemplate, currently I can't find an easy way to get the mapper for an entity class and have to copy paste code from DefaultDataAccessStrategy to create one. It would be nice if you could support this some how.

Have you consulted the documentation?

Custom RowMapper or ResultSetExtractor
@Query annotation with rowMapperRef/rowMapperClass attributes

Other than that, we do not accept RowMapper query method arguments.

I think you miss understand me, I'm not using @Query annotation but using JdbcTemplate/NamedParameterJdbcTemplate to execute some query built at runtime. This query will return the entity so it's would be nice if I can reuse the EntityRowMapper class of spring data jdbc to map the result to entity.
Basically like this:
      var entityRowMapper = //Some how get spring data jdbc row mapper for entity class
      var user = namedParameterJdbcTemplate.queryForObject(
              "select * from users where id = :id",
              Map.of("id", "0001"),
              entityRowMapper
      );


Fix for TLS dashboard

Setting up a TLS dashboard currently causes some issues, as initially reported in #5053. Problems were partially fixed by #5055, but some issues remain:

Setting dashboard_protocol to https causes the dashboard to try accessing Prometheus API though https too. However, Prometheus does not support TLS natively. Setting up a reverse proxy such as nginx would be needed for this. For now, we just fix the protocol as plain http, which is what Prometheus supports.

People are currently using ceph dashboard set-grafana-api-ssl-verify False as a workaround to get Grafana to work with TLS. In order to get the certificate to validate correctly, we can allow the user to override grafana_server_addr with a FQDN listed in the certificate's CN or altsubjects.

Just for reference, I'm deploying with the following config:
dashboard_protocol: https
dashboard_admin_user: admin
dashboard_admin_password: ommited
dashboard_crt: 'ceph.crt'
dashboard_key: 'ceph.key'
grafana_admin_user: admin
grafana_admin_password: ommited
grafana_crt: 'ceph.crt'
grafana_key: 'ceph.key'
grafana_server_addr: somedomain.ufscar.br

@fmount @fultonj @gfidente FYI

@thotypous how can you deal with multiple grafana instances?
One of the main supported scenarios which is the reason to properly compute the grafana_server_addr fact is to allow users defining multiple grafana servers, configuring the ini file using the correct fact for the current node in which grafana is deployed.

Sorry for the delay. I had several issues with the cluster I was using for tests and only got to test the patch against master a few minutes ago.
The previous approach was completely incorrect, sorry. I was originally testing against cae24dd85a979ed40efc7de384c158a04bd3558d, then took too long to send the PR and messed up when rebasing. I didn't pay attention to the new grafana_server_addrs fact.
@fmount Please take a look at the new approach.


Add environment configuration.

This is already implemented in jib-maven-plugin but not documented. We should add it to jib-gradle-plugin as well.

This doesn't seem to be necessary since the environment can be configured at run-time.


No documentation for cf-typography

CF-typography's readme directs people to the Capital Framework documentation site for documentation. It's not included there.
https://cfpb.github.io/capital-framework/components/

It's a little nuanced, but that's supposed to be talking about how to include cf-typography in your project. The Docs and Demo are linked at the top of the README, and at the top of the page.

So cf-typography should be missing from this list of components?

Oh, I see what you're saying. No, it should not be missing from that page.

Typography has a page now!
https://cfpb.github.io/capital-framework/components/cf-typography/


Why does the channel name look different?

Submit feature requests to http://www.mattermost.org/feature-requests/. File non-security related bugs here in the following format:
Summary
Issue in one concise sentence.
Environment Information

Device Name: iOS, Android
OS Version:
Mattermost App Version: 1.31.2
Mattermost Server Version: 5.23.0

Steps to reproduce
You can check it in the sidebar.
Expected behavior
It should look the same.
Observed behavior
Personal and group messages look different.
The name is shown in the personal message, and the ID is shown in the group channel.
In the previous version, the name was shown regardless of the channel type.
Below is a personal channel

Below is a group channel

Possible fixes
If you can, link to the line of code that might be responsible for the problem.

@bitdessert do you have consistent repro steps? Cause I cannot reproduce

@enahum Just click on the top left hamburger button(drawer button). Create and compare 1:1 conversations and group(1:N) conversations. You can see that each chat room name is expressed differently

@bitdessert Would you be able to help test if you see the same on v1.32 beta version?

@enahum Have you changed this option?
Change the options in the desktop app as shown below.
Account Settings-> Display Settings -> Teammate Name Display -> Show first and last name
What I tested was after selecting the third option.
If you select the first or second option, it changes like the desktop app, but the third option does not change on the mobile.

@josephbaylon can you try and repro and file a ticket if needed?
thanks.

@enahum I tested it by pulling version 1.32 from git and it looks good.

Thanks for confirming... can we close this issue then?

@enahum Will it be patched in version 1.31? If not, when will 1.32 be released?

A new verdion is released every 16th of the month, so 1.32 will be released in 13 days from today (June 16th 2020)

@enahum So there are no patch plans in 1.31?

Right, no plans to have this in a dot release

@enahum OK, thanks :)


EB 4.4 scoped metadata fails for idps in testaccepted state

When requesting the scoped idps-metadata, it fails when the respective SP is in testaccepted, rather than prodaccepted state.
Aug 13 18:07:29 t03 EBLOG[30052]: > QUEUED TIMESTAMP: 2015-08-13T18:07:29+02:00| EB[0ZZbuXVhfoxxCMrCdgxjw-rOn4f][55ccc0c0a8e4b] [Message ERR] Unable to find EngineBlock configured as Identity Provider. No 'https://engine.test2.surfconext.nl/authentication/idp/metadata' in repository!
Example URL: https://engine.test2.surfconext.nl/authentication/proxy/idps-metadata?sp-entity-id=https://sp.testshib.org/shibboleth-sp

Fixed in 4.4.11.


MGDCTRS-1149:chore: update SA fields in edit connector flow

This PR updates SA fields in the edit connector flow. Added helper text to the Client Secret field.
When you edit SA Client Id It displays the Client Secret field with 5 pre-field bullet points. Once you update the secret field with a new value you can see the EyeIcon which shows/hide entered value. It also validates the empty values

Cool, that looks good @uidoyen.  I had a test also here and I think it functions as described.  One change that is still needed for MGDCTRS-1149 is that the client secret field should be visible by default when the user goes into the editing mode.  For example to cater for a case where maybe a user copied their secret wrong in the first place and just needs to update that field.  Unfortunately the original design didn't cater for this edge case, and with the current UI in this case the user would have to maybe delete/replace a character in the client ID field for the secret field to show up so that it can be updated.

@gashcrumb this should be fine now.


Language translator

Worked on Issue Number: #531
Issue Name: Language translator
Issue Type: Feature Added.
Video:
https://user-images.githubusercontent.com/77090462/168413891-30a53725-9d81-42ea-b487-192acb522d8b.mov

@manisha-27 @heet-kumar @heet-kumar Please check and review it.


Run twice?

If I run image_optim twice over an image, is that to my benefit by any means?

In vast majority of cases no. Rarely I saw few more bytes shaven on second run from some files, but normally second run will be useless.
I've thought about adding "ultimate" mode (as part of adding compression levels) which will apply all workers in all possible orders repeatedly to find the best possible compression, though such mode will be very time consuming.

@toy ah, alright. so having this as a rake task to run over all my images before deploy, is fine?

@tejasmanohar Yes, running once will be sufficient. Also if using image_optim through railtie you will have an advantage of optimised images been cached.

@toy using jekyll, not rails. no downsides of running twice, correct? because i was planning to add this function to the build rake task which means the same files could go through this process multiple times

@tejasmanohar No downsides except time, I've just created an issue about caching #83.


OSError: [WinError 6] The handle is invalid while running 'datacamp courses command'

When I'm running the datacamp courses command, the chrome browser pop-up opens for a second and closes. Then I'll get the below error in the cmd.
+--------+------------------------------------------+------------+------------+------------+
| ID     | Title                                    | Datasets   | Exercises  | Videos     |
+--------+------------------------------------------+------------+------------+------------+
Please wait /Exception ignored in: <function Chrome.del at 0x0000022D0DB08AE0>
Traceback (most recent call last):
File "C:\Users\mnatr\AppData\Local\Programs\Python\Python312\Lib\site-packages\undetected_chromedriver_init_.py", line 843, in del
File "C:\Users\mnatr\AppData\Local\Programs\Python\Python312\Lib\site-packages\undetected_chromedriver_init_.py", line 798, in quit

me too

I am getting the exact same error.


Fix remark plugin for diagram/mermaidjs not working

Using the remark plugin as documented (to enable mermaid diagrams in md/mdx) fails:
ENOENT: no such file or directory, open 'C:\projects\YoniFeng-blog\node_modules\mermaid\dist\mermaid.js'
The issue is that mermaid switched to ESM modules. mermaid.js no longer exists.
I tried naively using the ESM module (and adding type: "module" to the puppeteer's launch args), but that didn't work.
Downgrading dependency as a quick fix.

btw I wasn't able to re-build dist/index.js.
❯ pnpm run build

><EMAIL_ADDRESS>build C:\oss\web-garden\components\Diagram
> parcel build index.ts

🚨 Build failed.

@parcel/core: No transformers found for Diagram.astro.

  C:\OSS\web-garden\components\Diagram\node_modules\.pnpm\@parcel+config-default@2.7.0_@parcel+core@2.7.0\node_modules\@parcel\config-default\index.json:3:3
     2 |   "bundler": "@parcel/bundler-default",
  >  3 |   "transformers": {
  >    |   ^^^^^^^^^^^^^^^^^
  >  4 |     "types:*.{ts,tsx}": ["@parcel/transformer-typ
  >    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  >  5 |     "bundle-text:*": ["...", "@parcel/transformer
  >    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  >  6 |     "data-url:*": ["...", "@parcel/transformer-in
  >    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  >  7 |     "worklet:*.{js,mjs,jsm,jsx,es6,cjs,ts,tsx}":
  >    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  >  8 |       "@parcel/transformer-worklet",
  >    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  >  9 |       "..."
  >    | ^^^^^^^^^^^
  > 10 |     ],
  >    | ^^^^^^
  > 11 |     "*.{js,mjs,jsm,jsx,es6,cjs,ts,tsx}": [
  >    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 12 |       "@parcel/transformer-babel",
  >    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 13 |       "@parcel/transformer-js",
  >    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Am I doing something wrong?

Thank you, this is a much needed fix for my sites too

Thank you for chiming in!
I admit I don't wan't to maintain library relying on puppeteer anymore (or any big binaries stuff really, even sharp has been annoying twice for me).
Like OG Image generation with Satori, I believe we must find a way to not spin up a whole browser for generating mermaid diagram, server-side.
When I built this, I was conscious of those limitations, but I wanted to see how far we could get.
In practice, it's cumbersome to put puppeteer anywhere in your pipeline. Even with all caching tricks you can find.
I think @remcohaszing has been doing some work here, but I didn't dug that yet!

https://github.com/remcohaszing/mermaid-isomorphic
https://github.com/remcohaszing/remark-mermaidjs

btw I wasn't able to re-build dist/index.js.

I was not really accustomed to building / packaging at that time, so I used parcel, but really, just tsc could have done the job here.
Oh, and good news, you don't need to transpile to JS anymore in order to load TypeScript stuff from the Astro config file (with MJS). I found that by accident.
So basically you could import the source directly.

I keep this open because pinning a older version cannot be considered as a "fix".
Cheers

Both projects you linked use either Pupeteer or Playwright.
I understand this is far from an ideal solution and probably becomes a build bottleneck for sufficiently large projects (that make extensive use of mermaid diagrams), but implementing an ideal solution probably isn't trivial and would likely be a considerable maintenance burden.
I agree this doesn't fix the issue, it's just a quick hack I did to unblock myself.
Closing this PR.

You need to use a browser. See https://github.com/remcohaszing/remark-mermaidjs/issues/3 for context.
You can't load ESM in Chrome / WebKit using a file: protocol. See https://github.com/microsoft/playwright/issues/22292
Mermaid moved to ESM only in version 10. The UMD bundle is being added back in https://github.com/mermaid-js/mermaid/pull/4281. For now, you can use a pinned version of 10.0.3-alpha.1.
As @JulianCataldo pointed out, I recently created mermaid-isomorphic to take away most of the pain of working with Mermaid in Node.js. I haven't released it yet though.


UnicodeDecodeError

Hi I talked to you a while ago about other of this errors, and it's happening again with a teacher's file that I'm converting.
So the error was UnicodeDecodeError: 'ascii' codec can't decode byte 0xd3 in position 1: ordinal not in range(128)
I will send the data that wasn't working with one that works (chlorphyll), sorry to bother again.
srry.zip

Hi pandamal!
No worries, it's not a bother. I will take a look when I get some time in the next few days. The problem is caused by an unexpected character somewhere in the data, it should (hopefully) be an easy and quick fix.
Best,
-DDH

Hi pandamal,
I've released a fix for the script. The error was caused by a "Ó" character in some of the sample names. I've added a quick fix for handling extended ascii characters (they get replaced with "�"). I'll try and come up with a more elegant solution in the near future. The script should convert your teacher's files now.
-DDH


Live preview feature needed

Is it possiable to preview plantuml generated images on save, just like markdown preview.

A live preview would need a completely different integration with plantuml as it is done right now. The Atom package only calls plantuml. Is not integrated at all into the generation pipeline which would be needed to have a fluent user experience as regenerating images on each key stroke would take to much time. Closing this for now.


Refactor to be able to call migration using pure function call.

This allows library to be called directly from task runners, such as gulp, grunt or similar. Removed global references for "_" and "promise" to minimize possible side effects when importing library. Use "color/safe" version to color message to avoid modifying string prototype.

:+1: must have

@aphel-bilisim-hizmetleri please let me know if you are considering merging this, otherwise I will publish forked version of this on NPM. Thanks.

@aphel-bilisim-hizmetleri
@lkaragol
please consider adding contributors, if you guys aren't going to maintain this anymore :smile:

This is an excellent PR. @tkirda did you ever publish with these changes on NPM?


Upgrade Ubuntu to 22.04 from 20.04

What:
Upgrade Ubuntu to 22.04 from 20.04
Why:
We want to upgrade Ubuntu base image to 22.04.

We'll also want to update this in our CI matrix

@mollykarcher

We'll also want to update this in our CI matrix

I am not sure if it would break anything there if we change Github actions workflow to use 22.04. Do you think it will break any workflow? Usually this change is for Docker base image which doesn't care about the host OS.

closing in favour of https://github.com/stellar/soroban-tools/pull/1158


Add ingress for grafana and prometheus

Signed-off-by: Chun Lin Yang<EMAIL_ADDRESS>Add ingress for grafana and prometheus to be consistent with other. This decision was made in this pr: https://github.com/istio/istio/pull/9217

/cc @sdake

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clyang82, gyliu513
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [gyliu513]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test istio-integ-k8s-tests

prow/e2e-dashboard.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test istio-integ-k8s-tests

prow/e2e-dashboard.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-dashboard

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: clyang82, gyliu513
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-dashboard

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake Hi Steven, I have switch to release-1.1.  Please help to review. Thanks.

/retest

/assign @sdake

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

prow/e2e-dashboard.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
7960b1204d26a99b403f67d174f3e787166238f4
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

prow/e2e-dashboard.sh
7960b1204d26a99b403f67d174f3e787166238f4
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
7960b1204d26a99b403f67d174f3e787166238f4
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
7960b1204d26a99b403f67d174f3e787166238f4
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
7960b1204d26a99b403f67d174f3e787166238f4
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

prow/e2e-dashboard.sh
7960b1204d26a99b403f67d174f3e787166238f4
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
7960b1204d26a99b403f67d174f3e787166238f4
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clyang82, gyliu513, morvencao
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [gyliu513,morvencao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

prow/e2e-dashboard.sh
7960b1204d26a99b403f67d174f3e787166238f4
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
7960b1204d26a99b403f67d174f3e787166238f4
link
/test e2e-mixer-no_auth

prow/istio-unit-tests.sh
103166a5d827a2eb554218bf242247233d179e3c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
7960b1204d26a99b403f67d174f3e787166238f4
link
/test e2e-mixer-no_auth

prow/istio-unit-tests.sh
103166a5d827a2eb554218bf242247233d179e3c
link
/test istio-unit-tests

prow/e2e-dashboard.sh
103166a5d827a2eb554218bf242247233d179e3c
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
103166a5d827a2eb554218bf242247233d179e3c
link
/test istio-unit-tests

prow/e2e-dashboard.sh
103166a5d827a2eb554218bf242247233d179e3c
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
103166a5d827a2eb554218bf242247233d179e3c
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: clyang82, gyliu513, morvencao
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
d885cfd9314cbde7e880066dc29232abf22430f6
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
d885cfd9314cbde7e880066dc29232abf22430f6
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
d885cfd9314cbde7e880066dc29232abf22430f6
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ce739d190e5bf10e7b2020be46a1178dbe8e36be
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
0abac6a420b1a061f2ef86e4692498a70dead7d4
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
d885cfd9314cbde7e880066dc29232abf22430f6
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
d885cfd9314cbde7e880066dc29232abf22430f6
link
/test istio-unit-tests

prow/istio-presubmit.sh
d885cfd9314cbde7e880066dc29232abf22430f6
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clyang82, gyliu513, morvencao
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Improve exception error messages

@josevalim can you review error messages? I have reduced the information for sandbox timeout messages but should be enough information.

NB: This includes a breaking change for the pool API

This looks great. The only one unclear to me is the "because of queue", everything else looks excellent!

Ah I see there is a race condition in the tests.
Also I think we can remove the backwards incompatible change by creating
the exception in the client process and sending the exception as the
reason. This should smooth things over with the ecto sandbox.
On 27 April 2016 at 06:17, José Valim<EMAIL_ADDRESS>wrote:

This looks great. The only one unclear to me is the "because of queue",
everything else looks excellent!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/fishcakez/db_connection/pull/34#issuecomment-214972044

merged in master


Chore: Merge dependabots

What
While working on resolving the PDF issue, multiple dependabots were left on hold.  This PR merges them into a songle commit so we can quickly get the service back up to speed
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
The standards in the Git Workflow document on Confluence should be followed
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

PS - you may wish to bump axios in package.json to version 1.7.3


observableT should accept Observable as the root type

Currently observableT accepts
  Publisher<Observable<Type>>

It should be (or an alternative provided for)
  Observable<Observable<Type>>

https://github.com/aol/cyclops/pull/207


About Test bug

While I use the test script of vocdataset, it will occur a bug----[Errno 2] No such file or directory: 'data/vocsbd/Vocdevkit/V0C2012/3PEGImages/2007_000033.jp9. How to deal with it?

I find what‘s happen. While I delete old documents about that path. The problem is dealt with. So just redownload.

Great.


Create automated backup for openmetadata application

in progress - S3 bucket created, now to create a automated job.


Uncaught Error in list_market_book

I had exposure moved to a new account where the orders no longer seem to have a placedDate.
05/29 05:27:05 ERROR query_market_books
Traceback (most recent call last):
File "/home/code/venv/lib/python3.6/site-packages/betfairlightweight/endpoints/baseendpoint.py", line 111, in process_response
for x in result
File "/home/code/venv/lib/python3.6/site-packages/betfairlightweight/endpoints/baseendpoint.py", line 111, in
for x in result
File "/home/code/venv/lib/python3.6/site-packages/betfairlightweight/resources/bettingresources.py", line 585, in init
self.runners = [RunnerBook(**i) for i in kwargs.get("runners")]
File "/home/code/venv/lib/python3.6/site-packages/betfairlightweight/resources/bettingresources.py", line 585, in
self.runners = [RunnerBook(**i) for i in kwargs.get("runners")]
File "/home/code/venv/lib/python3.6/site-packages/betfairlightweight/resources/bettingresources.py", line 505, in init
self.orders = [RunnerBookOrder(**i) for i in orders] if orders else []
File "/home/code/venv/lib/python3.6/site-packages/betfairlightweight/resources/bettingresources.py", line 505, in
self.orders = [RunnerBookOrder(**i) for i in orders] if orders else []
TypeError: init() missing 1 required positional argument: 'placedDate'

@xgshark before fixing this do you know if any other fields are missing? I worry that fixing placedDate will just result in another also needing a fix (like customerStrategyRef..)

I tried to replicate this but failed as I do not get orders without placed date out of list_cleared_orders and the few open ones in the outright markets were placed without a strategy ref.
The error message says that it is ONE required positional argument missing though so fixing that would be good enough to not throw an error?


remote transcoding fails with DVR-LiveTV

getting playback error when trying to play LiveTV or Transcode DVR recordings

As am I (using a hdhomerun),   Given the usr is something like:
http://<IP_ADDRESS>:32600/devices/dvb%23hdhr%231%23286352909/media/triplet%3A%2F%2F8746%3A31%3A1300?param=%3C%3Fxml%20version%3D%221%2E0%22%20encoding%3D%22UTF-8%22%3F%3E%0A%3Ctunedata%3E%3Ctt%3E4%3C%2Ftt%3E%3Cdq%3E0%3C%2Fdq%3E%3Cdr%2F%3E%3Cfr%3E570000%3C%2Ffr%3E%3Cmd%3E0%3C%2Fmd%3E%3Csr%3E0%3C%2Fsr%3E%3Cpl%3E0%3C%2Fpl%3E%3Clf%3E8%3C%2Flf%3E%3Cl1%3E0%3C%2Fl1%3E%3Cl2%3E0%3C%2Fl2%3E%3Cls%3E0%3C%2Fls%3E%3Cpp%3E0%3C%2Fpp%3E%3Chz%3E0%3C%2Fhz%3E%3Cin%3E0%3C%2Fin%3E%3Cfc%3E0%3C%2Ffc%3E%3Ct%3E31%3C%2Ft%3E%3Cn%3E8746%3C%2Fn%3E%3Cs%3E1300%3C%2Fs%3E%3Cen%3E0%3C%2Fen%3E%3C%2Ftunedata%3E%0A

And pointing at localhost (to the master), it probably need to skip trying to remote transcode.

I've added the following to avoid it, since my url as above has http://<IP_ADDRESS>:32600/devices  Unsure if other types of tuner do this.
Added:
 # FIX: For transcodes of tuners, they request from local host, they may need to be either
    #      pointed at the plex host (maybe?) or something else.
    #      Anyway, forcing local transcode.
    if 'http://<IP_ADDRESS>:32600/devices/' in ' '.join(args):
        log.info("Found Live TV request...forcing local transcode")
        return transcode_local()

Where the fix for eae_prefix is.

Oh also needs exclusion on:
http://<IP_ADDRESS>:32400/livetv


Statistics Retrieval - Extra Support

Fixes #20.
Changes proposed in this pull request:

Includes support for executing single statistics
Introduced CommonStatisticProcessor for direct access to common statistic result executions.

@lopezton

Pull Request Test Coverage Report for Build 78

50 of 53 (94.34%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 86.893%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/com/tonelope/tennis/scoreprocessor/processor/MatchProcessor.java
4
5
80.0%

src/main/java/com/tonelope/tennis/scoreprocessor/processor/statistics/StatisticProcessor.java
41
43
95.35%

Totals

Change from base Build 75:
0.1%

Covered Lines:
537

Relevant Lines:
618

💛  - Coveralls


[$500] Bank account - Selected bank account is not checked in bank account selection step

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal team
Action Performed:

Go to staging.new.expensify.com.
Go to workspace settings.
Select a workspace.
Go to Bank account.
Click Connect online with Paid.
Log in with Chase account.
Back in bank account selection page, select any bank account.

Expected Result:
The selected bank account is checked in the checkbox.
Actual Result:
The selected bank account is not checked in the checkbox.
This issue also occurs with the checkbox in Company owner steps.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/5ec1d4f7-7363-4203-a8fc-4f21c5e6282b
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f67808490772984d
Upwork Job ID:<PHONE_NUMBER>193760768
Last Price Increase: 2024-02-27

We think that this bug might be related to #vip-bills
CC @davidcardoza

Probably good, do you agree with the fix @jjcoffee @roryabraham @danieldoglas ?

That sounds good to me as well, I noticed that happening on https://github.com/Expensify/App/issues/37271 as well, but the error logged is different there.

@ZhenjaHorbach hmm thanks for checking that.
Yeah, thanks for pointing out that pull request.
I think checking if the value exists makes sense since most of the forms are not using value outside of the form like it's the case with the exit survey and that property was just implemented.  @roryabraham @mollfpr what do you think?

@ZhenjaHorbach's proposal LGTM and makes sense that it comes from https://github.com/Expensify/App/pull/34925 given this is only happening on staging. Also agree that checking if value is undefined makes sense here as value is an optional prop that's meant to only be used if using the component as a controlled input (i.e. it should work as expected without it!).
https://github.com/Expensify/App/blob/22b63905fa23b83c21208eb6d707dd8c86d4d1a7/src/components/RadioButtons.tsx#L35-L36
:ribbon::eyes::ribbon: C+ reviewed

Leaving this to you @roryabraham since you originally wrote the code

whoops, my mistake. I made RadioButtons a controlled component without refactoring other usages to be controlled. I like @ZhenjaHorbach's proposal to make it work as controlled or uncontrolled, but I think that we can leave defaultCheckedValue as it still has a utility for parent components using RadioButtons as an uncontrolled component

btw @ZhenjaHorbach, are you in the #expensify-open-source slack room?

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/34925/
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/34925/files#r1515894840
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Go to workspace settings
Select a workspace
Go to Bank account
Click Connect online with Paid
Log in with Chase test account details
Back in bank account selection page, select any bank account
Verify that selected bank account is checked in the checkbox

Do we agree 👍 or 👎

Payouts due:
Contributor: $500 @ZhenjaHorbach (paid in Upwork - https://www.upwork.com/nx/wm/workroom/36490106/overview)
Contributor+: $500 @jjcoffee (paid in Upwork - https://www.upwork.com/nx/wm/workroom/36497814/overview
Upwork job is here.
Regression test here - https://github.com/Expensify/Expensify/issues/376594
closing


can't support  ResponseEntity

feign  can't deserialize ResponseEntity from response
interface ServiceClient{
 BaseResult<AddressDto> getAddress(int addressId);
}
response:
{"Result":true,"Message":null,"Data":{"UserId":1,"AddressId":2,"ProvinceId":10000,"CityId":11000,"CountyId":0,"IsDefault":0,"Address":"xxx","AddressDetail":"xxxxx"},"Version":0,"ErrorCode":0}
deserialize result:
BaseResult(Result=false, Message=null, Data=null, Version=0, ErrorCode=0)
Class defination
public class BaseResult<T> implements Serializable {
private boolean Result;
  private String Message;
  private T Data;
 private int Version;
 private int ErrorCode;
//getter;setter
}
public class AddressDto implements Serializable {
private int UserId ;
  private int AddressId ;
 private long ProvinceId ;
 private long CityId ;
 private long CountyId ;
   private int IsDefault ;
private String Address ;
   private String AddressDetail ;
//getter;setter
}

Please learn how to properly format the code

Also please read the template of an issue you've deleted when you've filed this issue and add the missing information
<!--
Thanks for raising a Spring Cloud issue. What sort of issue are you raising?

Question

Please ask questions about how to use something, or to understand why something isn't
working as you expect it to, on Stack Overflow using the spring-cloud tag.

Bug report

Please provide details of the problem, including the version of Spring Cloud that you
are using. If possible, please provide a test case or sample application that reproduces
the problem. This makes it much easier for us to diagnose the problem and to verify that
we have fixed it.

Enhancement

Please start by describing the problem that you are trying to solve. There may already
be a solution, or there may be a way to solve it that you hadn't considered.
-->

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Add Dockerfile and instructions

Hi there!
I've added a Dockerfile that makes a relatively small multi-stage image of the CLI that should be usable cross-platform (only tested on macOS so far but no reason to believe it would fail on Windows/Linux).
I'm interested in contributing something more meaningful (i.e. tests for #10 when I have a little more time) but wanted to send this for now. I also understand if you don't want to merge since it does sadly change your repo stats from  100% to 99.1% Rust, 0.9% Dockerfile :smile:.
Question for maintainers:

This builds and appears to run with latest release of Rust as of 10/22, version 1.56. Should this be pinned to another Rust version?
I haven't looked too closely into amzn/ion-c CMake files but the only C/C++ build dependencies on Debian appeared to be cmake and clang. Should I update the README to reflect this or Dockerfile be sufficient?

Thanks!
Issue #, if available:
N/A
Description of changes:

Added Dockerfile to build minimal, multi-stage image
Updated README with build instructions

Recording of local build/test:

Currently builds image size 85.8MB from local build on macOS
docker images
REPOSITORY                               TAG               IMAGE ID       CREATED          SIZE
ion-cli                                  0.1.1             e81a9d863b95   49 minutes ago   85.8MB

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks, @camerondurham! This looks great. Getting ion-cli to build can be a bit of a hassle right now, so having an easy Dockerized path reduces the barrier to entry for folks looking to experiment.

This builds and appears to run with latest release of Rust as of 10/22, version 1.56. Should this be pinned to another Rust version?

v1.56 is fine, though as of today there's a v1.56.1. Does

I haven't looked too closely into amzn/ion-c CMake files but the only C/C++ build dependencies on Debian appeared to be cmake and clang. Should I update the README to reflect this or Dockerfile be sufficient?

I think it's worth mentioning in the README.

Thanks for the review and comments @zslayton !
Revision summary:

added Github workflow that will run on PRs and push to master branches
re-ordered Docker usage instructions
added note about build dependencies
updated to latest 1.56.1 Rust Docker image

On my fork, the workflow is working as expected.
Summary in repo commits here:

Successful workflow: https://github.com/camerondurham/ion-cli/actions/runs/1410831208
Failed workflow (removed clang): https://github.com/camerondurham/ion-cli/actions/runs/1410847829
Fixed build again: https://github.com/camerondurham/ion-cli/actions/runs/1410855706

I am sure you are aware of this, but this repo's action policy should maybe limit when actions run for certain contributors if it isn't already? Docs: Configuring Required Approval For Workflows


vscodium: 1.58.1 -> 1.58.2

Motivation for this change
Upgrades vscodium from 1.58.1 to 1.58.2
This PR was automatically generated by nixpkgs-upkeep.

CI workflow that created this PR.
Internal tag: 1c625a940cfcb2e436ffeb4520d05449.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 130414 at ff76c0c0 run on x86_64-linux 1

2 packages built successfully:

vscodium
vscodium-fhs

Result of nixpkgs-review pr 130414 run on x86_64-darwin 1

1 package built:

vscodium

patch update, no reason to keep it open.

@samuela Would it be possible to trigger your tool to provide version 1.59.0 which fix a crucial bug with extension marketplace?

I think the bot should make a PR relatively soon.
@drupol  You can make a PR yourself if you are interested.
The bot is running update-vscodium.sh script inside the vscode directory.
If you tag me in the PR you make, we can get this merged within 24 hours.
Let me know if anything doesn't make sense.

@drupol I believe it hasn't run yet due to https://github.com/samuela/nixpkgs-upkeep/issues/15. I'll try to get it back up and running asap.

Done with https://github.com/NixOS/nixpkgs/pull/133219


Configurable Asserter System Message and Human Message - Target Version 0.2.0b1

Configurable prompts for asserter

[x] Implement separate testing system handler with optional arguments to replace existing prompts
[x] Unit tests for the above
[x] Documentation update
[x] Change the name from asserter prompt injector to asserter prompt configurator
[x] Change parameter name in BehavioralAssertion constructor to not sound like a security problem

Target release: v0.2.0b1

Architectural decisions taken:
We want to introduce additional friction in this situation BECAUSE it is a dangerous feature, users should not be overriding the default prompts to the asserter LLM without thinking long and hard.
Therefore - we use a frozen dataclass to store the prompts and an asserter prompt injector class that contains the default prompts.
for safety, those prompts should only be accessed as a read-only object using an @property decorator.
Still tinkering with logic to shove it into semantic assert but it's honestly very straightforward from here. Please refer to release/0.1.0b5 to see the new classes

Done with 0.2.0b1


Added comments

Fixes #63 Also fixes #47

Current coverage is 60.12%

Merging #83 into master will decrease coverage by -2.35% as of b5b9872

@@            master     #83   diff @@
======================================
  Files           49      50     +1
  Stmts          946     983    +37
  Branches       159     166     +7
  Methods          0       0
======================================
  Hit            591     591
  Partial         33      33
- Missed         322     359    +37

Review entire Coverage Diff as of b5b9872

Powered by Codecov. Updated on successful CI builds.


dagger: 0.6.2 -> 0.6.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dagger/dagger/releases.
meta.description for dagger is: A portable devkit for CICD pipelines
meta.homepage for dagger is: https://dagger.io
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.6.3 with grep in /nix/store/i3rpffhqlp07sy7i6dik5g6wfb6afbvv-dagger-0.6.3
found 0.6.3 in filename of file in /nix/store/i3rpffhqlp07sy7i6dik5g6wfb6afbvv-dagger-0.6.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
dagger

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i3rpffhqlp07sy7i6dik5g6wfb6afbvv-dagger-0.6.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dagger https://github.com/r-ryantm/nixpkgs/archive/cf6c1fb1852b225b64f01f118813e50cda7d2158.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i3rpffhqlp07sy7i6dik5g6wfb6afbvv-dagger-0.6.3
ls -la /nix/store/i3rpffhqlp07sy7i6dik5g6wfb6afbvv-dagger-0.6.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dagger

Maintainer pings
cc @jfroche @sagikazarmark for testing.

Result of nixpkgs-review pr 242777 run on aarch64-darwin 1

1 package built:

dagger


feat: Add parser support

This PR adds support for supplying a parser through query/mutation/...-options.
The idea is that we give the option to set the parserFn in e.g. QueryOptions. The type of the parsed value will the sieve through to the results. See the added tests for examples!

Is there any documentation about this feature?

Is there any documentation about this feature?

Sorry for the delay on this, we are working on a blog post.
But maybe the following code can help you.

final ResultParserFn<List<String>> parserFn = (data) {
          return data['viewer']['repositories']['nodes']
              .map<String>((node) => node['name'] as String)
              .toList();
        };
        final _options = QueryOptions(
          document: parseString(readRepositories),
          variables: <String, dynamic>{
            'nRepositories': 42,
          },
          parserFn: parserFn,
        );
        final repoData = readRepositoryData(withTypenames: true);

Basically, you parse the JSON return from the server in a Dart object, this function is very useful when you will use autogenerate code for decode the JSON

This was an actual breaking change that was released as a patch.

The "breaking" part refers to the type parameter that is required even if parserFn is omitted on SubscriptionOptions, QueryOptions and MutationOptions constructors.
Added an issue and a suggestion of how to fix here: https://github.com/zino-hofmann/graphql-flutter/issues/1052


To avoid cluster failure during initial deployment, the cluster can be deployed with the private DNS zone resource ID

Hi,
Please advise where the zone ID would be defined as the property I see for the API specified only allow System or None.
Thanks
Dan

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0b68f2c4-bb6c-11a2-6c61-8af4057a2438
Version Independent ID: e3498bed-1447-6841-8353-9f1b5d3dc8df
Content: Create a private Azure Kubernetes Service (AKS) cluster - Azure Kubernetes Service
Content Source: articles/aks/private-clusters.md
Service: azure-kubernetes-service
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@DanGiffen
Thanks for your feedback! We will investigate and update as appropriate.

@DanGiffen
I'm going to assign this to the document author so they can take a look at it accordingly.

@MGoedtel
Can you please check and add your comments on this doc update request as applicable.

#reassign:schaffererin

Hi @DanGiffen, thank you for your feedback. This issue has been resolved and the doc is now updated. I will now close this GitHub issue. Thanks again!
#please-close


Full-screen-false button character "\u2922" is not displayed on some ? Android devices

Describe the bug
Full-screen-false button character "\u2922" is not displayed on some ? Android

The html source code is OK :  <button class="ol-full-screen-false" type="button" title="Plein-écran">⤢</button>
I have tested it on Android (Lineage OS 14.1 with Chromium 78 and Firefox lite (firefox 69) : same result.
To Reproduce
Steps to reproduce the behavior:
1 - goto https://openlayers.org/en/latest/examples/full-screen.html
2 - open url with some Android device
3 - the ⤢ "\u2922" is not displayed but a replacement character (a square with a contained cross).
Expected behavior
Have the ⤢ displayed.
Maybe it should be tested with other devices and Android version to be confirmed ?
Thanks,
Eric
https://developer.android.com/guide/topics/resources/internationalization
https://stackoverflow.com/questions/52792453/unicode-character-to-represent-fullscreen

Hello,
I have "solved" it using :
new FullScreen({
                     label: '\u26F6'

This unicode is displayed on both Firefox and Chromium for Android.
Eric

This could be related to the font-family in use on your page? It looks like Openlayers doesn't specify a font-family in it's css file so the full-screen element will inherit the font family of the containing page.
Should OpenLayers specify a font-family known to support the Unicode characters it uses for this and other symbols?


Add a .bat entry point for flutter tools

Currently, this only calls out to the PowerShell Script, which is kind of slow. In the future, we will transfer more logic from PowerShell to cmd for faster starup time.
https://github.com/flutter/flutter/issues/7654

FYI @cpu-chromium in case you're curious. :)


Style elements within text editors using the atom-text-editor::shadow selector or the .atom-text-editor.less file extension.If you want to target overlay elements, target them directly or as descendants of atom-overlay elements.

In stylesheets\gutter-breakpoint.less: Style elements within text editors using the atom-text-editor::shadow selector or the .atom-text-editor.less file extension.
If you want to target overlay elements, target them directly or as descendants of atom-overlay elements.

Thanks @samijnih, this issue have been fixed in https://github.com/kiddkai/atom-node-debugger/pull/39/files


Auth: username to password changed

Hello Anthony.
Many thanks for the great boilerplate.
That helps me a lot.
With the BasicAuth I got into trouble when I was able to perform queries with incorrect passwords.
The small inaccuracy is corrected with this PR, I think.
Kind regards
22degrees

Hi @22degrees, I'm glad the boilerplate works for you 🙌🏾
Well spotted! It's a typo. I'm merging it!
Thanks