Host header field does not mention non-standard ports

This appears to have changed somewhere between 0.4.1-beta3 and 0.4.1.
icecap has an HTTP hander test that fails as follows after upgrading to 0.4.1:
FAIL in (http-tests) (http_test.clj:70)
expected: {:remote-addr "<IP_ADDRESS>",
           :headers {"host" "localhost:8378", "content-length" "0"},
           :server-port 8378,
           :keep-alive? true,
           :uri "/test/example",
           :server-name "localhost",
           :query-string nil,
           :body nil,
           :scheme :http,
           :request-method :get}
  actual: {:remote-addr "<IP_ADDRESS>",
           :headers {"host" "localhost", "content-length" "0"},
           :server-port 8378,
           :keep-alive? true,
           :uri "/test/example",
           :server-name "localhost",
           :query-string nil,
           :body nil,
           :scheme :http,
           :request-method :get}
    diff: - {:headers {"host" "localhost:8378"}}
          + {:headers {"host" "localhost"}}

I think this might be a bug. However, the current relevant RFC section (RFC 7230, §5.4) says nothing explicit about what happens for nonstandard ports. The old RFC was explicit about this requirement:

A "host" without any trailing port information implies the default port for the service requested (e.g., "80" for an HTTP URL).

If I'm reading the current RFC correctly; the Host header depends on what the request sent:

A client MUST send a Host header field in all HTTP/1.1 request messages.  If the target URI includes an authority component, then a client MUST send a field-value for Host that is identical to that authority component, excluding any userinfo subcomponent and its "@" delimiter (Section 2.7.1).

That test does use a URL with that port specified; so I think the old behavior was correct. Not sure if this changed in aleph or in netty; I'd be happy to dig down into that and submit a fix if this change wasn't intentional and you read the RFC the same way I do :-)

The issue that led to this change can be found at https://github.com/ztellman/aleph/issues/210.  Looking at the linked RFC, the grammar mentions the port, but doesn't say why it might or might not be included.  The current logic driving the inclusion of the port is here: https://github.com/ztellman/aleph/blob/master/src/aleph/http/client.clj#L288.
If you think I've misread the RFC, I'm willing to reconsider, but right now I'm leaning towards leaving this as they are.

Thanks for your reply! That issue appears to deal with default ports. The old RFC specified omission was optional in that case. I have heard (but not personally experienced) that concern about crummy servers before. However, this is a non-standard port; it appears both the old and current RFCs are unambiguous that the port should be in the Host header in that case.
I know some folks who have more experience maintaining HTTP libraries (client/server) than I do; I'll reach out to them to see if they can provide some context re: either point.

In addition to my own parsing, I've conferred with @glyph (founder, Twisted) and @lukasa (author, hyper HTTP/2 library). Both confirm "nonstandard port -> mandatory in Host"; former confirms "don't add "optional" standard port because some servers are terrible".
Assuming you're OK with the current RFC interpretation that the host header value contains the port iff the specified URL does, I'd be happy to implement that. I'd also be happy to implement the version that always strips the port if it is the default even though it is specified in the URL, although I believe that to be incorrect; and ironically you need that to connect to some of the arcanely configured IIS servers.
Context: old bad IIS checks host  headers against a literal list; if configuration specifies the port even when it's the default; you must specify the port in Host header as well. These boxes are even rarer than the usual broken IIS; specifying the default port explicitly is rare to begin with, plus they're quick to receive attention since so many clients will fail to connect.

I'm pretty sure that the current implementation adheres to "the host header value contains the port iff the specified URL does", but if there's some way it doesn't that seems like a reasonable compromise to me.  For all other special workarounds, anyone is free to set their own "Host" header without the port, which I think is a good enough escape hatch.

Derp. That caused me to re-examine the current behavior. So the actual bug here was that my test had expected and actual reversed, so I was misinterpreting the test failure. You're right; aleph previously (incorrectly) was not adding the port, and the current version (correctly) adds it. Sorry!

No worries, I appreciate you checking with other people writing HTTP libraries, since I wasn't sure what's the "standard" approach to this behavior.

I've now heard from one other person, so I'm reasonably confident the behavior you described is the best possible one; i.e. add it to the Host header if and only if it was in the request URL.


Mac Compatible Framework

Hi,
When I build Dollar/Cent with carthage, the resulting frameworks are not compatible with Mac Projects. I tried to fork the repo and add in Mac targets for both frameworks. It worked when built manually, but I couldn't get it to build with Carthage.
Is there a way you could add Mac frameworks to the library to make it easier to use with Mac Projects?

Taking a look.

Closing this as it works for me locally. Please reopen with more details if it still doesn't work.


212-Fix Accordion Tab Index

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #212
Test URLs:

Before: https://main--fonterra-fernleaf--hlxsites.hlx.page/en/products/milk-powder-for-whole-family
After: https://212-accordion-tabindex--fonterra-fernleaf--hlxsites.hlx.page/en/products/milk-powder-for-whole-family

performance drop:
https://pagespeed.web.dev/analysis/https-212-accordion-tabindex--fonterra-fernleaf--hlxsites-hlx-live-en-products-milk-powder-for-whole-family/2rljuf73jz?form_factor=mobile

@asthabh23  pls check https://pagespeed.web.dev/analysis/https-212-accordion-tabindex--fonterra-fernleaf--hlxsites-hlx-live-en-products-milk-powder-for-whole-family/8zf515mqip?form_factor=mobile.

after multiple runs, looks fine to me @sselvara


Is it possible to shrink wrap?

Tested with FlexBoxLayoutManager with RecyclerView in my own project and the demo playground app.
Also researched about css behavior to see if this is normal behavior.
Issues and steps to reproduce

Set layout manager flexwrap to wrap and use with Recyclerview as usual

FlexboxLayoutManager layoutManager2 = new FlexboxLayoutManager(this);
layoutManager2.setFlexWrap(FlexWrap.WRAP);

Set the recyclerview items to have 0dp width and height and inflate within adapter as usual

<ImageView
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="0dp"
    android:layout_height="0dp"
    android:layout_margin="4dp"/>

In the adapter's onBindViewHolder, set the width, height, minWidth, minHeight, flexGrow, and flexShrink

FlexboxLayoutManager.LayoutParams flexboxLp = (FlexboxLayoutManager.LayoutParams) imageView.getLayoutParams();
flexboxLp.setMinHeight(0);
flexboxLp.setMinWidth(0);
flexboxLp.setFlexGrow(0.0f);
flexboxLp.setFlexShrink(1.0f);
flexboxLp.width = thumb_width;
flexboxLp.height = thumb_height;

Expected behavior
Items in the row should shrink to accommodate 1 more item before wrapping to the next line
Items should not grow to accommodate remaining space
Actual behavior
Empty space is left at the end of the row and the next item is wrapped to the next line

Version of the flexbox library
0.3.0
Link to code
I'm currently experimenting with this in my personal project Chesto the latest commit being https://github.com/wightwulf1944/Chesto3/commit/cf766fd59aafbe2e8c59525f48a04adf2c067197. Please see MainActivity.java, MainAdapter.java, and main_recycler_item.xml

It's an expected behavior.
flexShrink works if flexWrap is set to nowrap because with flexWrap set to wrap (or wrap_reverse), the FlexboxLayoutManager is going to put the view to the next line instead of overflowing it's parent.
If you want to fill the remaining space in each line, please try setting a positive value (e.g. 1f) to each item's flexGrow attribute.

And what if (in a FlexboxLayout) a single elemrnt in a row is larger then available width? Overflow parent?


React Portal support

First of all, thanks for doing such an amazing job with jest-axe 💓 💯 👏🏻
The issue
We're trying to use jest-axe to verify the output of Reakit components.
Here's the PR that captures the work: https://github.com/reakit/reakit/pull/652
We basically configured axe to test components on isolation and now we're [trying to verify the HTML output of a component:
test("renders with no a11y violations", async () => {
  const { container } = render(<ButtonWithTooltip />);
  const results = await axe(container.innerHTML);

  expect(results).toHaveNoViolations();
  cleanup;
});

However, we're facing the following error:
["Error: Uncaught [NotFoundError: The node to be removed is not a child of this node.]
        at reportException (/Users/lluis/Code/reakit/node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:62:24)
        at innerInvokeEventListeners (/Users/lluis/Code/reakit/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:346:9)
        at invokeEventListeners (/Users/lluis/Code/reakit/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:281:3)

Many Reakit components make use of React Portals, and we noticed when we switch off portals ( through a prop ) then the jest-axe test pass.
So the question being is this library compatible with portals? 🤔

Having another looks at this, the issue might be in our side.
Our custom <Portal /> component attempts to remove itself from his parent DOM whenever this one changes ( cc. @diegohaz  ) and somehow this conflicts with jest-axe wiping out the DOM while executing axe checks.

When I put this together I didn't anticipate Portals:
If you can figure out a way around this, we could update the library or add documentation to the README.

Thanks @nickcolley, I'll try to have a look and if possible suggest a solution 🤞🏻

I was able to test it by using baseElement
const { baseElement } = render();
const results = await axe(baseElement)

@kennygrubb is that this? https://testing-library.com/docs/react-testing-library/api#baseelement

@nickcolley yup I think he refers to that, @diegohaz explained it here, I guess we're good closing this now 💆🏻♂ 🎊 ( as it wasn't a problem of the library but how our tests were written )

@lluia what do you think about adding something to the README to explain that?
I'll re-open if you or someone else is interested.

@nickcolley yup happy to open a PR adding some small explanation on the README 💅🏻 🙌🏼

Closing this out for now but you're still welcome to add some documentation if you want to in the future, thank you.

@nickcolley here you go 💚


With Django 1.11 files get post-processed multiple times

On Django 1.11 I see pipeline post-process the same file to the same hashed version multiple times and in the end I have 2 different files e.g.
media/admin.min.70004aec9612.css
media/admin.min.3719a5a090af.css

That does not happen on Django <1.10
example snippet of a my config:
         'admin_min_css': {
                'source_filenames': (
                'js/libs/chosen/chosen.css',
            ),
            'output_filename': 'admin.min.css',
         },

Anyone else experiencing that? Possibly related to the introduction of storage.ManifestStaticFilesStorage.max_post_process_passes in 1.11

I confirm this error with Django 1.11.10. I see pipeline post-process the same file multiple times.
Post-processed 'bower_components/bootstrap/dist/css/bootstrap.css' as 'bower_components/bootstrap/dist/css/bootstrap.60711a51db5e.css'
Post-processed 'bower_components/bootstrap/dist/css/bootstrap.css' as 'bower_components/bootstrap/dist/css/bootstrap.cb8a77bb5700.css'
Post-processed 'bower_components/bootstrap/dist/css/bootstrap.css' as 'bower_components/bootstrap/dist/css/bootstrap.3c7be87695cb.css'

after a while, this error comes up:
Post-processing 'All' failed!

Traceback (most recent call last):
  File "./manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/home/karten_stage/venv/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 364, in execute_from_command_line
    utility.execute()
  File "/home/karten_stage/venv/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 356, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/karten_stage/venv/local/lib/python2.7/site-packages/django/core/management/base.py", line 283, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/karten_stage/venv/local/lib/python2.7/site-packages/django/core/management/base.py", line 330, in execute
    output = self.handle(*args, **options)
  File "/home/karten_stage/venv/local/lib/python2.7/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 199, in handle
    collected = self.collect()
  File "/home/karten_stage/venv/local/lib/python2.7/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 145, in collect
    raise processed
RuntimeError: Max post-process passes exceeded.

I use S3BotoStorage.

Turns out it's a bug in Django 1.11
HashedFilesMixin's post_process() yields multiple times for the same file
https://code.djangoproject.com/ticket/28604

@bitcity  Sorry I dont remember what I did about it, or if I just accepted it as it did not break things.

I temporarily used CachedStaticFilesStorage instead of ManifestStaticFilesStorage, it works for me.

I am going to close this, because it seems to be the bug of django. It can be re-open later.

When using S3 if query-string authentication is enabled, you can end up in a situation where CSS files contain URLs with query-string parameters such as AWSAccessKeyId=...&Signature=...=&Expires=... -- and each time each file is hashed, these can change, creating an endless loop of differing hashes. Turing AWS_QUERYSTRING_AUTH off might help.


⚠ Bofrost.at has degraded performance

In 87d0fae, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1080 ms

Resolved: Bofrost.at performance has improved in f12d774 after 6 minutes.


Add Elm libraries to implementations list

Adds two Elm libraries to the implementations list.
For information on Elm: http://elm-lang.org/
Link to elm-jsonapi: https://github.com/noahzgordon/elm-jsonapi
Link to elm-jsonapi-http: https://github.com/noahzgordon/elm-jsonapi-http

Nice to see some Elm libs! Thanks.


cbmc: init at 5.63.0

Description of changes

Cadical is used as sat solver backend.
https://github.com/diffblue/cbmc/releases/tag/cbmc-5.63.0
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I mean, it doesn't feel right to have a non-executable file in bin.

I mean, it doesn't feel right to have a non-executable file in bin.

Sure, then I will move it to share/cbmc and wrap goto-cc to locate it.

I mean, it doesn't feel right to have a non-executable file in bin.

Sure, then I will move it to share/cbmc and wrap goto-cc to locate it.

Done

Looks OK to me, since ls_parse.py seems more like an internal utility than a binary that should be available to users on $out/bin.


SyntaxError: Named export 'item' not found. The requested module '@1password/op-js' is a CommonJS module, which may not support all module.exports as named exports.

Your environment
op-js version: 0.1.10
CLI version: 2.19.0
OS: macOS Ventura 13.5.1
What happened?
Syntax error when importing op-js after upgrading from 0.1.9 to 0.1.10:
SyntaxError: Named export 'item' not found. The requested module '@1password/op-js' is a CommonJS module, which may not support all module.exports as named exports.

(import succeeds after reverting to 0.1.9)
What did you expect to happen?
Import succeeds as before (with 0.1.9).
Steps to reproduce

Have this in package.json:

{
  ...
  "dependencies": {
    "@1password/op-js": "0.1.10",
    ...
  },
  "type": "module",
  ...
}

Import item from op-js (and rename it):

import { item as opItem } from '@1password/op-js'

Notes & Logs

Reported on the 1Password Developer Slack
Response from @jodyheavener with a working fix in branch jh/fix-cjs

I'm getting similar errors but from the other side - my codebase is CommonJS and I can't use 0.1.10 because I get an  "Cannot use import statement outside a module" error, because dist/index.js contains import statements (e.g. ESM syntax).

Hey all, yes thanks for raising this. We recently changed how the package was compiled so that we weren't bundling all the dependencies together. The package was previously all CJS but our change resulted in some ESM syntax being used. The fix I have moves us back to an all CJS package. I'll have up shortly.

A coworker linked me this today, it's very handy to know about: https://publint.dev/<EMAIL_ADDRESS>

Oh dang, that is very neat! Thank you for sharing :)


Create README.md

Looks good, a few comments:

I would great a new header ## Usage and put ### Quick start and ### Installation under it.
I would put ### Installation before ### Quick start

@Steven-Palayew Ah sorry, I should have said I was still reviewing. I left a couple comments for things I think it would be good to include.


Frightening error message even when everything is fine

During Pythran execution, one can get this message
/tmp/tmppilay8qq/source.c:1:10: fatal error: cblas.h: No such file or directory
    1 | #include <cblas.h>
      |          ^~~~~~~~~
compilation terminated.

This is just an output problem because the actual compilation is fine. However, users can be afraid. When everything is fine, it's not too bad. But when there is actually another error, it's bad because people tend to focus on cblas.h.
Would it be possible to hide this error log ?

can you share your .pythranrc, the .py and list the installed blas deps so that
I can reproduce?
Thanks!

Empty .pythranrc
.py with just
# pythran export toto
toto = 1

Pythran installed with:
conda create -n env_pythran pythran networkx=2.5.1
conda activate env_pythran

If I install pythran from source in this conda environment, I also get the error log.

Nop, it does not suppress the message and gives a error in numpy.distutils.system_info!
I can get the message just with:
import numpy.distutils.system_info as numpy_sys
numpy_sys.get_info("blas")

But I can't find a way to redirect it. I guess this message does not go through sys.stdout or sys.stderr.

I submitted a lower level approach in #1799, I think it works as expected :-)

I confirm that here the message is correctly suppressed by silent. Thanks!


Cleaning up dataDir breaks backwards comparability.

Cleaning up dataDir from #571 breaks backwards comparability.
https://github.com/improbable-eng/thanos/pull/571#issuecomment-430632467
compact command failed: clean working temporary directory: remove /var/thanos/data: device or resource busy

I use data-dir the same as the mount path of volume in k8s, hence dir couldn't be deleted.
The workaround is to set data-dir as nested dir. I.e. in my case this's: /var/thanos/data/compact

Sorry, my bad... I also meet the problem when it is integrated in Kubernetes today.
So could we clean up the subpath directories such as compact and downsample instead of the temporary directory itself?

i meet this problem too, when add hostpath as volume in kubernetes


[TEST] Enable arm_cpu qnn.conv2d i8mm test

Enabling the test now we have LLVM > 11 in the docker images.
cc @ekalda @neildhickey

Fixed in #15484


It doesn't work on Bootstrap 4

Hi, this is a awesome project!
But it doesn't work on Bootstrap 4.0.0-beta， just like this:

I can second this. I fixed your issue by adding display:block to .dropdown-menu.inner.
But with "bootstrap": "^4.0.0-beta.2" the dropdown selects all the options at once and it throws an error.
Cannot read property 'offsetTop' of undefined error
// scroll to selected option
var offset = that.$lis.eq(selectedIndex)[0].offsetTop - that.$menuInner[0].offsetTop;
offset = offset - that.$menuInner[0].offsetHeight/2 + that.sizeInfo.liHeight/2;
that.$menuInner[0].scrollTop = offset;

Often the menu is out of the window

All options get selected when selecting a single option

I see this is a duplicate of #1135

Bootstrap 4 support has officially been added in v1.13.0!


Dev build doesn't work due to several missing dependencies.

I'm about to put in a PR to track this, but here's the reproduction steps

clone https://github.com/vue-play/vue-play
cd vue-play
yarn
yarn run build

Pretty much the steps I took and it failed. Also it notably requires vbuild to be installed globally (which should be stated in the documentation if that's the intent).
I'll start from a fresh npm install with only yarn installed and list the missing dependencies.

First failure (due to missing vbuild):

Close on #14


index.html missing

In the README.md it is listed that there should be an `index.html' in the root of the project, but I don't see it

Good catch. That's a mistake. Fixed.


Explore Page: Show logos in cards

closes https://github.com/hypha-dao/dho-web-client/issues/1028

@pugakn fixed!


Possible to use pretrained VCTK_ model from Hifi-GAN?

Yes, you can try

I don't think, since official Hifigan repo provides only generator https://drive.google.com/drive/folders/1vJlfkwR7Uyheq2U5HrPnfTm-tzwuNuey , whilst to resume here from checkpoint, both generator and discriminator are required.
checkpoints directory :  cp_hifigan
Loading 'cp_hifigan/g_00440000'
Complete.
Loading 'cp_hifigan/do_00440000'
Complete.
Loading 'cp_hifigan/do_00440000'

There are two ways you can try this:

You can train a VCTK model that includes generators and discriminators.
Use this universal model, which contains generators and discriminators.
https://drive.google.com/drive/folders/1YuOoV3lO2-Hhn1F2HJ2aQ4S0LC1JdKLd


cilium installation failed on specefic EKS instance type

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I got these error messages on the cilium pod when the EKS instance type is m6i.2xlarge
my cilium version is 1.9.18 based on documentation.
level=info msg="All pre-existing resources related to policy have been received; continuing" subsys=k8s-watcher
level=info msg="Successfully synchronized CiliumNode custom resource" name=ip-172-30-21-228.ec2.internal subsys=ipam
level=info msg="Waiting for IPs to become available in CRD-backed allocation pool" available=0 helpMessage="Check if cilium-operator pod is running and does not have any warnings or error messages." name=ip-172-30-21-228.ec2.internal required=2 subsys=ipam
level=info msg="Waiting for IPs to become available in CRD-backed allocation pool" available=0 helpMessage="Check if cilium-operator pod is running and does not have any warnings or error messages." name=ip-172-30-21-228.ec2.internal required=2 subsys=ipam
level=info msg="Waiting for IPs to become available in CRD-backed allocation pool" available=0 helpMessage="Check if cilium-operator pod is running and does not have any warnings or error messages." name=ip-172-30-21-228.ec2.internal required=2 subsys=ipam
level=info msg="Waiting for IPs to become available in CRD-backed allocation pool" available=0 helpMessage="Check if cilium-operator pod is running and does not have any warnings or error messages." name=ip-172-30-21-228.ec2.internal required=2 subsys=ipam
level=info msg="Waiting for IPs to become available in CRD-backed allocation pool" available=0 helpMessage="Check if cilium-operator pod is running and does not have any warnings or error messages." name=ip-172-30-21-228.ec2.internal required=2 subsys=ipam

Cilium Version
1.9.18
Kernel Version
Linux ip-172-30-21-228.ec2.internal 5.4.196-108.356.amzn2.x86_64 #1 SMP Thu May 26 12:49:47 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Kubernetes Version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.1", GitCommit:"3ddd0f45aa91e2f30c70734b175631bec5b5825a", GitTreeState:"clean", BuildDate:"2022-05-24T12:26:19Z", GoVersion:"go1.18.2", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"22+", GitVersion:"v1.22.10-eks-84b4fe6", GitCommit:"cc6a1b4915a99f49f5510ef0667f94b9ca832a8a", GitTreeState:"clean", BuildDate:"2022-06-09T18:24:04Z", GoVersion:"go1.16.15", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.24) and server (1.22) exceeds the supported minor version skew of +/-1
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

As the error message indicates, are there any errors or warnings in the operator logs?
My guess is that m6i.2xlarge is too new to be understood by Cilium 1.9 (which is EOL). You can work around that issue by manually providing the instance limit metadata for m6i.2xlarge via the aws-instance-limit-mapping configmap value, see the following comment for an example:
https://github.com/cilium/cilium/issues/20280#issuecomment-1163052908

Thank you. It works


Ensure-PnPFolder should be Resolve-PnPFolder

There's no such thing as Ensure-PnPFolder

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05b385a5-4bb6-e858-d114-df8b6b41114f
Version Independent ID: e9821d8f-8e0b-5939-9f3e-43bffb6a0e7b
Content: Get-PnPFolder (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Get-PnPFolder.md
GitHub Login: @techwriter40
Microsoft Alias: kirks

@officedocsbot assign @yogkumgit

Hello @jimdavis66
Thanks for your feedback.
Actually, Ensure-PnpFolder is an alias of Resolve-PnpFolder, so the hint in the referenced article still works.
Thank you

@get-itips  Thank you very much for the contribution and sharing this explanation. @jimdavis66
Hope this comment is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close


Add OvalBorder and BoxShape.oval

Fix https://github.com/flutter/flutter/issues/103829
Flutter supports rectangles and circles, but doesn't support ovals (circles that are not squared). I adjusted two things:

Add BoxShape.oval. There is a comment saying new shapes shouldn't go here. I believe oval could be an exception to that, since BoxShape.oval is basically BoxShape.circle without constraints. It is easier to implement oval than circle. In most places, I just call drawOval instead of calculating the smaller side and drawing a circle. If you disagree, I can remove it, no problem 😀.
Add OvalBorder. Works like CircleBorder, but it is unconstrained. I haven't solved lerp from Oval to Circular or from Oval to others, only it to itself (which lerps do you think are useful?). Stadium lerps to Circular and RoundedRectangle lerps to Circular.

    ShapeBorder stadiumToPartialCircleLerp(double t) => stadiumLerp.lerpTo(
        CircleBorder(
          eccentricity: 0.5,
          side: BorderSide(
            color: Colors.blue.withOpacity(0.5),
            width: 5,
            strokeAlign: debugStrokeAlign,
          ),
        ),
        t)!;

    ShapeBorder stadiumToCircleLerpFullyRound(double t) => StadiumBorder(
          side: BorderSide(
            color: Colors.blue.withOpacity(0.5),
            width: 5,
            strokeAlign: debugStrokeAlign,
          ),
        ).lerpTo(
            CircleBorder(
              eccentricity: 0.0,
              side: BorderSide(
                color: Colors.purple.withOpacity(0.5),
                width: 5,
                strokeAlign: debugStrokeAlign,
              ),
            ),
            t)!;

    return Column(
      children: [
        Row(
          children: spaceRow(32, [
            for (double t in [0, 0.25, 0.5, 0.75, 1])
              Container(
                width: width,
                height: height,
                decoration: ShapeDecoration(
                  color: Colors.red.withOpacity(0.25),
                  shape: stadiumToCircleLerp(t),
                ),
              ),
            Container(
              width: width,
              height: height,
              decoration: ShapeDecoration(
                color: Colors.white.withOpacity(0.25),
                shape: CircleBorder(
                  eccentricity: 1,
                  side: BorderSide(
                    color: Colors.white.withOpacity(0.5),
                    width: 5,
                    strokeAlign: debugStrokeAlign,
                  ),
                ),
              ),
              child: const Center(child: Text('1.0')),
            ),
          ]),
        ),
        Row(
          children: spaceRow(32, [
            for (double t in [0, 0.25, 0.5, 0.75, 1])
              Container(
                width: width,
                height: height,
                decoration: ShapeDecoration(
                  color: Colors.red.withOpacity(0.25),
                  shape: stadiumToPartialCircleLerp(t),
                ),
              ),
            Container(
              width: width,
              height: height,
              decoration: ShapeDecoration(
                color: Colors.white.withOpacity(0.25),
                shape: CircleBorder(
                  eccentricity: 0.5,
                  side: BorderSide(
                    color: Colors.white.withOpacity(0.5),
                    width: 5,
                    strokeAlign: debugStrokeAlign,
                  ),
                ),
              ),
              child: const Center(child: Text('0.5')),
            ),
          ]),
        ),
        Row(
          children: spaceRow(32, [
            for (double t in [0, 0.25, 0.5, 0.75, 1])
              Container(
                width: width,
                height: height,
                decoration: ShapeDecoration(
                  color: Colors.brown.withOpacity(0.25),
                  shape: stadiumToCircleLerpFullyRound(t),
                ),
              ),
            Container(
              width: width,
              height: height,
              decoration: ShapeDecoration(
                color: Colors.white.withOpacity(0.25),
                shape: CircleBorder(
                  eccentricity: 0.0,
                  side: BorderSide(
                    color: Colors.white.withOpacity(0.5),
                    width: 5,
                    strokeAlign: debugStrokeAlign,
                  ),
                ),
              ),
              child: const Center(child: Text('0.0')),
            ),
          ]),
        ),
      ],
    );
  }
}

class RoundedRectangleToCircle extends StatelessWidget {
  const RoundedRectangleToCircle({
    required this.width,
    required this.height,
    Key? key,
  }) : super(key: key);

  final double width;
  final double height;

  @override
  Widget build(BuildContext context) {
    const debugStrokeAlign = StrokeAlign.inside;

    final roundedLerp = RoundedRectangleBorder(
      side: BorderSide(
        color: Colors.red.withOpacity(0.5),
        width: 5,
        strokeAlign: StrokeAlign.inside,
      ),
    );

    ShapeBorder roundedToOvalLerp(double t) => roundedLerp.lerpTo(
        OvalBorder(
          side: BorderSide(
            color: Colors.blue.withOpacity(0.5),
            width: 5,
            strokeAlign: StrokeAlign.inside,
          ),
        ),
        t)!;

    ShapeBorder roundedToPartialCircleLerp(double t) => roundedLerp.lerpTo(
        CircleBorder(
          eccentricity: 0.5,
          side: BorderSide(
            color: Colors.blue.withOpacity(0.5),
            width: 5,
            strokeAlign: debugStrokeAlign,
          ),
        ),
        t)!;

    ShapeBorder roundedToCircleLerpFullyRound(double t) =>
        RoundedRectangleBorder(
          side: BorderSide(
            color: Colors.blue.withOpacity(0.5),
            width: 5,
            strokeAlign: debugStrokeAlign,
          ),
        ).lerpTo(
            CircleBorder(
              eccentricity: 0.0,
              side: BorderSide(
                color: Colors.purple.withOpacity(0.5),
                width: 5,
                strokeAlign: debugStrokeAlign,
              ),
            ),
            t)!;

    return Column(
      children: [
        Row(
          children: spaceRow(32, [
            for (double t in [0, 0.25, 0.5, 0.75, 1])
              Container(
                width: width,
                height: height,
                decoration: ShapeDecoration(
                  color: Colors.red.withOpacity(0.25),
                  shape: roundedToOvalLerp(t),
                ),
              ),
            Container(
              width: width,
              height: height,
              decoration: ShapeDecoration(
                color: Colors.white.withOpacity(0.25),
                shape: CircleBorder(
                  eccentricity: 1.0,
                  side: BorderSide(
                    color: Colors.white.withOpacity(0.5),
                    width: 5,
                    strokeAlign: debugStrokeAlign,
                  ),
                ),
              ),
              child: const Center(child: Text('1.0')),
            ),
          ]),
        ),
        Row(
          children: spaceRow(32, [
            for (double t in [0, 0.25, 0.5, 0.75, 1])
              Container(
                width: width,
                height: height,
                decoration: ShapeDecoration(
                  color: Colors.red.withOpacity(0.25),
                  shape: roundedToPartialCircleLerp(t),
                ),
              ),
            Container(
              width: width,
              height: height,
              decoration: ShapeDecoration(
                color: Colors.white.withOpacity(0.25),
                shape: CircleBorder(
                  eccentricity: 0.5,
                  side: BorderSide(
                    color: Colors.white.withOpacity(0.5),
                    width: 5,
                    strokeAlign: debugStrokeAlign,
                  ),
                ),
              ),
              child: const Center(child: Text('0.5')),
            ),
          ]),
        ),
        Row(
          children: spaceRow(32, [
            for (double t in [0, 0.25, 0.5, 0.75, 1])
              Container(
                width: width,
                height: height,
                decoration: ShapeDecoration(
                  color: Colors.brown.withOpacity(0.25),
                  shape: roundedToCircleLerpFullyRound(t),
                ),
              ),
            Container(
              width: width,
              height: height,
              decoration: ShapeDecoration(
                color: Colors.white.withOpacity(0.25),
                shape: CircleBorder(
                  eccentricity: 0.0,
                  side: BorderSide(
                    color: Colors.white.withOpacity(0.5),
                    width: 5,
                    strokeAlign: debugStrokeAlign,
                  ),
                ),
              ),
              child: const Center(child: Text('0.0')),
            ),
          ]),
        ),
      ],
    );
  }
}

Cc @gspencergoog. Kind of related to the PR you just reviewed 😅. This is a lot simpler.

I think if we're going to add a new shape, then it should support lerping to all the other shapes.  The problem is that adding a new shape is exponential in the number of lerps you need to implement, since not only does this have to lerp to, say, rectangle, rectangle needs to lerp to it. For three shapes, you need three lerp functions.  For five, you need ten. If we had 32 shapes, we'd need 496 lerp functions. (x = n(n-1)/2). We don't have to support every lerp, but the more the better.  I'd say at least oval->rectangle, oval->rounded rect, oval->circle, oval->stadium, and back again.
It also makes the burden of adding a new shape exponentially harder, so we should consider if this is one of the shapes we really want to have.  It seems reasonably likely that it is, but we should choose carefully.

I like that better, since it doesn't increase the cost of adding a new shape. What about making it more "lerpable": instead of a bool, make the parameter a double that goes from 0.0 to 1.0, where 0.0 is an oval, and 1.0 is a circle. The problem is the name of this parameter: circularity? rotundity? ovalness (reverse sense)? I think I'm leaning towards circularity.

Having it be a continuum will make it more useful anyhow: I can imagine wanting a semi-oval circle even when I don't want to lerp it.

I'll test that, probably tomorrow. There is already a property like you described used in lerping. It will be kind of weird, but let's see the result. Because we are not lerping from round to square, it is round with min bounds to round without bounds.

Yes, but I think the rect to circle lerp parameter isn't the same as this.  They probably need to be combined somehow, which might be complicated. Or it might just be a multiply in the right place, if you're lucky. :-)

It should be simple, just the end result might be kind of weird. Let's see tomorrow.

👀 I added the ovalness but I hate that name, so I also added OvalBorder extends CircleBorder with ovalness = 1.

Here it goes! I'm not happy with the ovalness name, but I couldn't figure a better name. Maybe fitToSquare, a colleague has proposed cornerStretchAmount, edgeRoundnessRatio and cornerRoundingRatio.
It would be better if 1 = squared circle, 0 = oval, because then (1 - ovalness) wouldn't be necessary (you will see when you review the code).
But, it works.
I updated the sample code with a complex example lerping everything.

I'll take a look.  What about "eccentricity" for the name instead of "ovalness"?
I'm not sure it matches the textbook definition, but it does make some sense: eccentricity of 0.0 is a circle, and 1.0 is a very "eccentric" ellipse.
"The eccentricity of an ellipse is the ratio of the distance from the center to the foci and the distance from the center to the vertices."

I replaced ovalness with your circularity idea.
I think 0.0 = ellipse and 1.0 = circle makes slightly more sense codewise. (I changed from ovalness to circularity to make this change).
But eccentricity could also work. I guess first check the code, then we can discover the name we want.

Now it is using eccentricity 👀

@bernaferrari are you still wanting to merge this?  I think we're really close here.

Yes, I just don't know what else we need.

Don't worry, I'll forgive you if you can help give an end to the round outside StrokeAlign saga before it is too late :P

I think if we're going to add a new shape, then it should support lerping to all the other shapes. The problem is that adding a new shape is exponential in the number of lerps you need to implement, since not only does this have to lerp to, say, rectangle, rectangle needs to lerp to it. For three shapes, you need three lerp functions. For five, you need ten. If we had 32 shapes, we'd need 496 lerp functions. (x = n(n-1)/2).

It's actually a bit more complicated than that, because some of the lerps actually generate new (otherwise inaccessible) types, which you then need to be able to lerp to/from. For example, _CompoundBorder, _RoundedRectangleToCircleBorder, _StadiumToRoundedRectangleBorder, etc. And do we need to support lerping from a _RoundedRectangleToCircleBorder to a _StadiumToRoundedRectangleBorder? How would we even implement that without making at least one public. :-)

Ok, I fixed the issue and made some tiny changes:

Added lerpTo to OvalBorder (lerpFrom/lerpTo is optional).
Rename RoundedRectangleBorder(..., 50% of the way to being a CircleBorder that is 20% circular) to 20% oval (since now 100% = totally oval, 0% = circle)
Added that string to StadiumBorder lerp (ops).

Ready for Google Testing again.

[BoxShape.oval] There is a comment saying new shapes shouldn't go here.

I should probably have included more information in the comment saying why:

Each new enum value is a lot of new code in a bunch of places, including in code we don't control (e.g. app code, that's why the Google tests are failing), so we'd need to write a migration guide and migrate a bunch of code.
Each new enum value requires new code in a bunch of places.
That new code likely won't get tree-shaken out, since I don't think the compiler can know which values are never used. So this has a permanent binary size cost even for people who don't use it.
In principle, we've moved to ShapeBorders rather than BoxShape for new shapes, and the existence of BoxShape is just a legacy feature at this point. Adding more shapes encourages people to use BoxShape in the future.

Should I remove it then? It felt redundant because it is even simpler than the current circle option that's available there.

I would probably recommend removing it, for the binary size issue. I agree that each individual bit of code that implements BoxShape.oval is simpler than the equivalent code for BoxShape.circle, but there's a lot of these, and they all add up, and they all end up being in the compiled binary even if the user doesn't ever use either BoxShape value.
(If we could remove BoxShape entirely, I would probably do that. But that would break code that uses it.)
If we don't remove BoxShape.oval then we have to go through the breaking change process:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes

Removed 😥
What if we had this lint https://github.com/dart-lang/linter/issues/3411 for BoxShape.circle only so that users 'upgrade' before removing ShapeBorder entirely?

I don't think that lint necessarily is the right one (see e.g. https://github.com/dart-lang/linter/issues/3411#issuecomment-1165928053) but I could see having a specific lint that looks for BoxDecorations with BoxShape.circle and suggests using a ShapeDecoration with a CircleBorder instead, yeah. That would let us move towards deprecating BoxShape.
Actually we could just deprecate BoxShape.circle with a message saying to use ShapeDecoration with a CircleBorder instead. Is there anything that wouldn't be handled by that case?

Everything would be handed in that case. But...
I don't know how it would handle this. Probably somewhere in Image accepts a shape?
decoration: const BoxDecoration(
    image: DecorationImage(
        image: AssetImage(
            'people/square/sandra.png',
             package: _kGalleryAssetsPackage,
        ),
    ),
    shape: BoxShape.circle,
),

And this, which is basically the only BoxShape usage in Flutter. Replace that with ShapeBorder?

I think the example above just becomes:
decoration: const ShapeDecoration(
    image: DecorationImage(
        image: AssetImage(
            'people/square/sandra.png',
             package: _kGalleryAssetsPackage,
        ),
    ),
    shape: CircleBorder(),
),

InkHighlight is tricky. It's unrelated to decorations and just using it for its own purposes. I would probably not touch it (though I could also imagine porting the whole ink infrastructure to ShapeBorders).

(That does mean that deprecating BoxShape.circle would be more difficult since it would affect users of InkHighlight... maybe we just deprecate shape on BoxDecoration?)

Yeah, seems like so :(
Maybe move the BoxShape from BoxDecoration to InkHighlighter too.
I'll open a PR, we can play with that.

Ok, got halfway, but tests breaking are awful 😩 basically, everywhere that expects a circle must now expect something else, right?
flutter/packages/flutter/test/material/switch_test.dart -p vm --plain-name 'Switch thumb color resolves in active/enabled states'
00:05 +15 -6: Switch thumb color resolves in hovered/focused states
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: Object or closure painting:
          'a rounded rectangle with Color(0x801e88e5), RRect: RRect.fromLTRBR(13.0, 17.0, 46.0,
31.0, 7.0)'
          'a circle with Color(0x1f000000)'
          'a circle with Color(0x33000000)'
          'a circle with Color(0x24000000)'
          'a circle with Color(0x1f000000)'
          'a circle with Color(0xff000002)'
  Actual: _RenderInkFeatures:<_RenderInkFeatures#65c76>
   Which: did not match the pattern.
          It called 5 other methods on the canvas, the first of which was drawPath(Instance of
'Path', Paint(Color(0x33000000))), but did not call drawCircle() at the time where a circle with
Color(0x33000000) was expected.
          The first method that was called when the call to drawCircle() was expected,
drawPath(Instance of 'Path', Paint(Color(0x33000000))), was called with the following stack:

Even this is breaking:

And that was the whole change:

I need to explore that better later, or might need some help with ideas on how to fix.

This is the issue:
  void _paintInterior(Canvas canvas) {
    if (_interiorPaint != null) {
      canvas.drawPath(_outerPath, _interiorPaint!);
    }
  }

Where
@override
  Path getOuterPath(Rect rect, { TextDirection? textDirection }) {
    return Path()
      ..addOval(Rect.fromCircle(
        center: rect.center,
        radius: rect.shortestSide / 2.0,
      ));
  }

vs BoxDecoration:
canvas.drawCircle(center, radius, paint)

Is it possible to somehow convert Path..addOval() to drawOval instead of drawPath? This would solve the tests.

@bernaferrari can you upload a PR in draft mode with your proposed changes so far and cc me on it? Before you sink too much time into it I'm curious to see the impact.
In general, optimizing the call from drawPath(getOuterPath) to drawCircle does seem like a good idea but it's been a while since I looked at this code so I don't recall how easy that would be to do.

Here it goes: https://github.com/flutter/flutter/pull/108052. The changes are really simple, but the code it breaks is bad (especially switch, I think it is the worst offender).
BTW, can you add the "autosubmit" label in this PR and we finish it?


Router direct page navigation

It's not possible to navigate to a page directly.

We also need unique URLs to preload each swap pairing for each direction. naming convention must be short and follow the symbol name. Example, /usdc_to_usdtz and /usdtz_to_usdc

Already fixed - #69 re-opened.


Can we update the readme with screenshots of the current state of the app?

It will be easy to get aquainted with the current state of the app and start contributing !!

@LuGO0 Sure Sir,
I was about to start documentation as the app has now achieved a basic build.
Will update you till tomorrow.

@LuGO0
Updated the README.md

added Screenshots
Steps for Starting Contribution.

ohkk shud I close it @priyanshnama ?

Yes we can close it now @LuGO0


Format

Hi,
I have a question regarding this sentence: "You'll need to know the path of the file share and enter it using the format: \contoso\fileshare."
As this whole guidance page is about helping a "generic" user, why using "contoso" in the file share path? Shouldn't it be "name_of_your_organization" or something like that instead? Or is this guidance based on demo files?
Also, does "fileshare" mean "name of your file share"?
Thanks for help and best regards,
François

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 341198a2-dad6-ea64-2bf6-7e0faec6771e
Version Independent ID: e2da40fd-880d-6519-c31f-8f1d35f30794
Content: How to use Migration Manager - Migrate to SharePoint and OneDrive
Content Source: migration/mm-how-to-use.md
Service: sharepoint-online
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

@FranNev Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Move to jar-dependencies instead of keeping jars in repository

Hi @rsim,
Recently I ran into the need of upgrading the Mondrian jars to a newer version. I wondered if you'd be interested in moving to jar-dependencies instead of keeping the jars in the git repository.
I'm sure there's further improvements that need to be made before merging this to master; feel free to comment.
Gem build steps are now:

bundle install
lock_jars
rake install_jars
gem build ...

Thanks!

Currently, I would prefer to keep Mondrian jars (that I know are working fine) in the repository. I also have compiled them with Java 7 as in some installations we still need to support Java 7.
But I think as a wokaround you can require newer versions of jar files before requiring mondrian-olap - then I think the newer versions of the jars should be first in the load path and should override the default jars from mondrian-olap. Can you try this out?

Thanks, @rsim. I'll try the solution that you propose and report back.

Closing due to inactivity.


add spectrum annotation viewer

maybe one of you java people can have a look at this as a non-integrated solution. https://github.com/PRIDE-Toolsuite/pride-inspector

my preference would be to format our mzID (and in the future pepXML) for import into someone else's viewer rather than making our own


Shipping and Discounts are not being applied.

Bug report

Extension name: firestore-stripe-payments

Describe the bug
Shipping and Discounts are not being applied.
To Reproduce
I'm trying to create a checkout session with the following code:
const checkoutSessionRef = await firebase.firestore()
        .collection("users")
        .doc(uid)
        .collection("checkout_sessions")
        .add({
            price: priceId,
            success_url: successUrl,
            cancel_url: cancelUrl,
            subscription_data: { metadata },
            metadata,
            shipping_address_collection: {
                allowed_countries: ['RO']
            },
            shipping_options: [
                {
                    shipping_rate_data: {
                        type: 'fixed_amount',
                        fixed_amount: {
                            amount: 15 * 100, // 15 RON
                            currency: 'ron',
                        },
                        display_name: 'Transport'
                    }
                }
            ],
            discounts: [{
                coupon: couponId, // ZJeyCwtL
            }],
        });

  checkoutSessionRef.onSnapshot(async (snap) => {
          const { sessionId } = snap.data();
          const stripe = await initializeStripe();
          stripe.redirectToCheckout({ sessionId });
      });

The couponId is created in the Stripe dashboard, and is the ID of the coupon object/entity. After I'm redirected to the checkout page, the discount is not applied.
I'm also using a shipping rate that is described in the code above. The shipping is not applied as well.

Expected behavior
A clear and concise description of what you expected to happen.

If applicable, add screenshots to help explain your problem.
System information

OS: [macOS]
Browser (if applies) [Chrome]

Additional context
Add any other context about the problem here.

@calacianu shipping_options is not a supported parameter (yet). We'll need to add it.
discounts support is tracked here: https://github.com/stripe/stripe-firebase-extensions/issues/322

Thank you for your reply. Is there a way to handle shipping costs using the extension or using the APIs? I need to add a fix price for every product our customers purchase.

@calacianu Checkout support shipping costs, yes. But this extension does not currently support the parameters needed to enable this.
I'll open a PR to add that.

Hi @jsteele-stripe, is the shipping cost supported now?
Cheers

How about now?

I just tried and it did not work.
So still not implemented...

@jsteele-stripe Do you have a contact at Invertase that could knock this out?
Would really help our business!
Thanks


feat(ledger): update ledger-go to support Ledger Nano S Plus

Bump ledger-go version to v0.9.3 to support Ledger Nano S Plus.

:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Visualizer plane is not rendering properly

Hi,
After enabling ARSurfaceManager prefab, the plane visualizer thing not rendering properly.
When I disable your prefab, everything is fine.
Please help me with this.
Your plugin is awesome.
I am using Samsung Galaxy S7 device for testing.
Attached is the screenshot.

Thanks,
Bhanu.

Hi,
I just pushed a new commit to help you out:

Raised the ARSurface up slightly to avoid flickering for those who render additional geometry beneath the ARSurface.

The reason for the flickering is because the shadow is actually rendered on invisible geometry - I call that invisible surface the ARSurface. Because you have the plane visualizer on at the same time at the exact same place you would get the result you see because of depth fighting.

If I take the update, Will it render properly?
Thanks,
Bhanu.

There's only one way to find out - try it ;). It should hopefully work.
On Mon, Apr 16, 2018, 11:52 BHANU PRAKASH C A<EMAIL_ADDRESS>wrote:

If I take the update, Will it render properly?
Thanks,
Bhanu.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/jonas-johansson/ARCoreUtils/issues/6#issuecomment-381543487,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIt3CHq1s9azBFgHVlZcXo_zvlkVhoggks5tpGj7gaJpZM4TTWnS
.


first draft of indiana mapping

This mapping is really simple, so I think this should be correct. The biggest area I’m unsure of is the first 5 lines

Great work, @guegueng. Most or all of these changes are minor, except for the change related to collection.

Nice! Indiana Memory is the name they are using according to the ingest
form:
https://docs.google.com/a/dp.la/document/d/11bUrkXL_KLRkGJiH4YQ3nOq97DYmMBapCXyaWSQWdt0/edit
A
On Wed, Mar 11, 2015 at 5:53 PM, Mx A. Matienzo<EMAIL_ADDRESS>wrote:

Great work, @guegueng https://github.com/guegueng. Most or all of these
changes are minor, except for the change related to collection.
—
Reply to this email directly or view it on GitHub
https://github.com/dpla/heidrun-mappings/pull/6#issuecomment-78390398.

--
Amy Rudersdorf
Assistant Director for Content
Digital Public Library of America
<EMAIL_ADDRESS>(608) 501-1502

Ready for testing.

After talking w/@guegueng I'm closing this PR and deleting the branch b/c the mapping is out of date with IN datasource and needs to be rewritten.


feat: Add decimal column writer for dwrf file format

https://github.com/facebookincubator/velox/pull/11067#issuecomment-2374368954

@xiaoxmeng @Yuhta Above comments are fixed. Would you like to take a review again? Thank you.


The speed may be wrongly reported in your paper.

your method runs backbone twice, so the speed will be slowed down obviously

HTC spends lots of time on cascade head.

@PKUbahuangliuhe Thanks for the question. The impact on the speed depends on the workload after the backbone done extracting the features. HTC does many things after that, so the speed impact isn't that strong. @ZhongYingMatrix Thanks for your help.


text without natural breaks will overflow in the notes

Text that can't be broken with current rules will overflow, here for example.

The break strategy should be adjusted to fix this.

overflow-wrap: break-word will solve it, to be clear


Android X - Handle location permission when user selects- "Allow only when using the app"

Bug Report
Problem
What is expected to happen?
Prior to Android X, when getCurrentPosition() is called, And user clicks on Allow, we used to get the current location.
Now with Android X, we get new dialog with 3 options -
Allow
Allow only when using the app
Deny
When the second option is selected, and the location is off from the device settings, Nothing happens - neither error nor success.
What does actually happen?
We should get appropriate response from the method, so that we can handle the error gracefully.
Information

Command or Code

Environment, Platform, Device

Version information

Checklist

[ ] I searched for existing GitHub issues
[ ] I updated all Cordova tooling to most recent version
[ ] I included all the necessary information above

With Android11, we get a dialog with 3 options -
Only this time
While using the app
Deny
When user select [Only this time] or [While using the app], getCurrentPosition() callback error with timeout

Also seeing this issue on Android 11. When I select 'Only this time' or 'While using the app', getCurrentPosition is timing out.

Any fix for this?

Fixed by https://github.com/apache/cordova-plugin-geolocation/pull/250


Empty pages in between pages

Hi,
I am using jsPDF to generate PDF in an ionic hybrid app. iOS has no issue exporting the my document. On Android I get a blank page in between content pages.
assessment_form.pdf
Any idea, does it relate to the page break reported?
Cheers
Olaf

Sounds strange, I have had no issues with android and jspdf. Which devices, android versions and browsers have you tried?

It happens on all our Android devices. The one I recently tested on is a SM-T230 with Android 4.4.2. Really hard to test or find and consistency because it frequently complains it is not PDF file. I have not yet discover why it works sometimes, having empty pages in between or not working at all.

Atleast the xref values are corrupt
Duplicate of #208


lego help text is hard to read

The lego usage text is currently extremely wide, making it difficult to read.  This appears to be due to the way the codegangsta/cli go library formats help text.
I made some changes that allow the help usage text to appear as follows:
NAME:
   lego - Let's encrypt client to go!

USAGE:
   lego [global options] command [command options] [arguments...]

VERSION:
   0.2.0

COMMANDS:
   run          Register an account, then create and install a certificate
   revoke       Revoke a certificate
   renew        Renew a certificate
   dnshelp      Shows additional help for the --dns global option
   help, h      Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --domains, -d [--domains option --domains option]
        Add domains to the process
   --server, -s "https://acme-v01.api.letsencrypt.org/directory"
        CA hostname (and optionally :port). The server certificate must
        be trusted in order to avoid further modifications to the
        client.
   --email, -m
        Email used for registration and recovery contact.
   --accept-tos, -a
        By setting this flag to true you indicate that you accept the
        current Let's Encrypt terms of service.
   --key-type, -k "rsa2048"
        Key type to use for private keys. Supported: rsa2048, rsa4096,
        rsa8192, ec256, ec384
   --path "/home/brett/go/src/github.com/beevik/lego/.lego"
        Directory to use for storing the data
   --exclude, -x [--exclude option --exclude option]
        Explicitly disallow solvers by name from being used. Solvers:
        "http-01", "tls-sni-01".
   --webroot
        Set the webroot folder to use for HTTP based challenges to write
        directly in a file in .well-known/acme-challenge
   --http
        Set the port and interface to use for HTTP based challenges to
        listen on. Supported: interface:port or :port
   --tls
        Set the port and interface to use for TLS based challenges to
        listen on. Supported: interface:port or :port
   --dns
        Solve a DNS challenge using the specified provider. Disables all
        other challenges. Run 'lego dnshelp' for help on usage.
   --help, -h
        show help
   --version, -v
        print the version

Unfortunately, to make this possible I needed to make a few changes to the codegangsta/cli library.  I'm willing to submit these changes to codegangsta, but I don't want to start the process unless you like this change and think it's worth pursuing.

I agree. I'm actually planning to move away from codegangsta/cli in the next release after 0.3.0 so I don't know if it's worth it to invest much time into this.

ok I'll close. Thanks.


Design the connector with exposing APIs

Description:
This is a subtask of https://github.com/ballerina-platform/ballerina-standard-library/issues/4827

Design doc :https://docs.google.com/document/d/1Aj55Pxy_L-YYA4-Jun3VAoTQnBh72oXeJSHoOrD8Gaw/edit?usp=sharing


[Bigtable] Documented defaults timeout values in the EnhancedBigtableStubSettings

Fixes #2992
Updated default timeouts for all the operations in EnhnaceDBigtableStubSettings as BigtableClientSettings settings were deprecated.

@igorbernstein2 Please have a look at this change.
Please let me know if the format can be improved for timeout listing.

@kennethlowery8190, please remove the approval. This pr needs more work and I don’t want it accidentally merged

@igorbernstein2  Please have another round of review.
I have added below points in the last commit.

Listed Description for streaming and non-streaming operation.
Tried explaining RPC vs Total timeout
Tried explaining retryDelayMultiplier.
Added default values on each setting operation's Javadoc.
Added bulkMutateRowsSettings description.

@igorbernstein2 or @kolea2, can you PTAL

@igorbernstein2 I tried to address feedback comments, Please take a look.

Just a couple minor nits, but LGTM!

@igorbernstein2 Have addressed your feedback, Please have another look.

Look like a spanner test is failing


Cache directory does not exist

This is what I'm getting.
C:\Users\james\Desktop\GitHub\porpo\scripts>python gui.py
Traceback (most recent call last):
File "C:\Users\james\Desktop\GitHub\porpo\scripts\gui.py", line 9, in
class Dirs():
File "C:\Users\james\Desktop\GitHub\porpo\scripts\gui.py", line 28, in Dirs
fastf1.Cache.enable_cache(cache_path)
File "C:\Users\james\AppData\Local\Programs\Python\Python310\lib\site-packages\fastf1\api.py", line 133, in enable_cache
raise NotADirectoryError("Cache directory does not exist! Please check for typos or create it first.")
NotADirectoryError: Cache directory does not exist! Please check for typos or create it first.
C:\Users\james\Desktop\GitHub\porpo\scripts>python main.py
Traceback (most recent call last):
File "C:\Users\james\Desktop\GitHub\porpo\scripts\main.py", line 8, in
fastf1.Cache.enable_cache('venv/F1/Cache/')
File "C:\Users\james\AppData\Local\Programs\Python\Python310\lib\site-packages\fastf1\api.py", line 133, in enable_cache
raise NotADirectoryError("Cache directory does not exist! Please check for typos or create it first.")
NotADirectoryError: Cache directory does not exist! Please check for typos or create it first.

I fixed this issue, try the nightly or stable!


Using numtide/devshell for the derived devshell

As far as I can tell, the only supported way to get a customized devshell is to override the devshell that is provided via config.nci.outputs.${projectName}.devShell. I frequently find myself adding pre-commit-hooks, extra packages or environment variables:
devShells.default = config.nci.outputs.${projectName}.devShell.overrideAttrs (old: {
  nativeBuildInputs = (old.nativeBuildInputs or []) ++ [pkgs.cargo-release];

  shellHook = ''
    export LD_LIBRARY_PATH="...:$LD_LIBRARY_PATH"
    ${old.shellHook or ""}
    ${config.pre-commit.installationScript}
  '';
});

This is a bit unergonomic, especially if you have to redo this on a lot of projects. There is a wrapper called numtide/devshell (you might know it), that also has flake-parts support and allows me to add packages and environment variables via proper options in flake-parts:
devshells.default = {
  packages = [pkgs.cargo-release];
  devshell.startup.pre-commit.text = config.pre-commit.installationScript;
  env = [ { name = "LD_LIBRARY_PATH"; prefix = "..."; } ];
};

I find this a lot more maintainable, but I love nix-cargo-integration and cannot live without it anymore. Unfortunately I cannot figure out a good way to get a numtide devshell out of it without adding a lot of stuff to each project.
Is there a simple way to convert the devshell to a numtide based devshell? And if there isn't, would you be open to adding direct support for exporting a numtide/devshell to this project? I think this could be quite ergonomic, since both projects already support flake-parts.

This would be possible, nix-cargo-integration used to use numtide devshell but I stopped using it since I didn't think it was necessary as users could just set that devshell up themselves, and add the inputs from the devshell NCI generates there, so that part is already possible.
It might be a good idea to include a passthru.numtideEnv attribute (and just env for everything else) in the generated shell to pull the environment variables into user-created numtide devshell easier. And then just add all the inputs via the generated shell's packages attribute. This should solve what you are describing I think? You would just be able to do:
devshells.default = let
  nciShell = config.nci.outputs."crate".devShell;
in {
  packages = nciShell.packages ++ [pkgs.cargo-release];
  devshell.startup.pre-commit.text = config.pre-commit.installationScript;
  env =nciShell.numtideEnv ++ [ { name = "LD_LIBRARY_PATH"; prefix = "..."; } ];
};

Maybe also just add a contrib dir or something similar to put a initializeNumtideDevshellFromNciShells.nix (awfully long name i know) module for flake-parts that does it automatically once you include that module?

That would definitely be a great start! Since both project are using flake-parts I was thinking about having a setting that would have nci define the devshell directly - so essentially converting the stuff from your comment into a opt-in option:
nci.projects.example.path = ./.;
nci.projects.example.addToDevshells = ["default"];

devShells.default.packages = [pkgs.cargo-release];
# ...

What do you think?

I'm not sure if a config option is necessary, I think a simple module import would do the job. Just importing something like a flakeModules.numtideImportGeneratedShells that will automatically import everything from the generated shells into numtide devshells with the same name should work well, and you can just pick and choose whichever ones you want to actually use, if it exported them under something like a nci.outputs.<name>.numtideDevShell.

I made it so that every devshell will have env and packages exposed so it should be possible to write a module that does this now. So you should just be able to extend nci.outputs.<name> to have a numtideDevShell option or something and just use nci.outputs.<name>.devShell.<env/packages> to get either the environment variables or the inputs,

Sounds great, thanks a lot. I'll report back when I have made a module using the new options

I just tried the following, but unfortunately cargo (and all other tools) are missing from the resulting devshell. At first I thought about using packagesFrom but the same thing seems to occur. Is there another output that contains all the tooling that I am missing right now?
    devshells.default = {
      packages = config.nci.outputs."example".devShell.packages;
      env = lib.mapAttrsToList (k: v: { name = k; value = v; }) config.nci.outputs."example".devShell.env;
    };

Oh yeah I think I forgot to mention that the toolchain itself isn't added to those. If you add the toolchain from config.nci.toolchains.shell should work?

Ah nice, it seems to work on one of my simple repositories by doing this:
    devshells.default = {
      packagesFrom = [config.nci.toolchains.shell];
      packages = config.nci.outputs."example".devShell.packages ++ [config.nci.toolchains.shell];
      env = lib.mapAttrsToList (k: v: { name = k; value = v; }) config.nci.outputs."example".devShell.env;
    };

Just adding it to packages will miss the cc and linker, and just adding it to packagesFrom misses cargo. So apparently you need it in both, but I'm not certain at this point if that just working by accident or whether this is intended by the way numtide/devshell is designed.

I've arrived at the module below now, in case anyone is interested. I think I cannot be extended to have proper multi-crate support, because it is unclear how to merge env variables from different crates properly. Some would need to be made unique and added together (LD_LIBRARY_PATH), some could conflict (architecture stuff). So currently all env variables are added to the shell.
devshell-from-nci.nix:
{
  perSystem = {
    lib,
    config,
    ...
  }: {
    options.nci.crates = lib.mkOption {
      type = lib.types.lazyAttrsOf (lib.types.submoduleWith {
        modules = [
          {
            options = {
              numtideDevshell = lib.mkOption {
                type = lib.types.nullOr lib.types.str;
                default = null;
                description = ''
                  If set, the given numtide devshell will be populated with
                  the required packages and environment variables for this crate.
                '';
              };
            };
          }
        ];
      });
    };

    config.devshells = lib.mkMerge (lib.flatten (lib.flip lib.mapAttrsToList config.nci.crates (project: cfg:
      lib.optional (cfg.numtideDevshell != null) {
        ${cfg.numtideDevshell} = {
          packagesFrom = [config.nci.toolchains.shell];
          packages = config.nci.outputs.${project}.devShell.packages ++ [config.nci.toolchains.shell];
          env =
            lib.mapAttrsToList (k: v: {
              name = k;
              value = v;
            })
            config.nci.outputs.${project}.devShell.env;
        };
      })));
  };
}

It would be possible to expose more information, but it needs to be done at a module level, possibly in dream2nix. We could probably do it NCI side but I'm not sure if that's the best way to go. I'm still not sure about it and I don't have time to come up with something there for now though.
If you want, you can PR this module into NCI probably into a contrib folder and expose it in the flake.nix (under flakeModules would be alright i think?).

I think this already covers 95% of all projects, so if it isn't trivial to do then that's fine. I'll definitely PR this once I'm sure that it works properly.
I did just test a project with some dependencies and it seems like PKG_CONFIG_PATH is not exposed in the new devShell.env attribute. On second thought it actually looks like the whole devShell.env attribute is completely empty for some reason.. But the classical exposed devshell works fine. Am I missing something?
This is my crate definition, I'm basically just compiling a dummy cargo init; cargo add bevy project.
        nci.crates.${projectName} = rec {
          numtideDevshell = "default";
          runtimeLibs = with pkgs; [
          ];
          depsDrvConfig = {
            mkDerivation = {
              nativeBuildInputs = [pkgs.pkg-config];
              buildInputs = with pkgs; [
                alsa-lib
                libxkbcommon
                udev
                vulkan-loader
                wayland.dev
                xorg.libX11
                xorg.libXcursor
                xorg.libXi
                xorg.libXrandr
              ];
            };
          };
          drvConfig = {
            mkDerivation = {
              nativeBuildInputs = [pkgs.pkg-config];
              buildInputs = depsDrvConfig.mkDerivation.buildInputs;
            };
          };
        };

I'll have to look into this later (i don't have access to a pc right now) but I'm suspecting it's probably due to the way those are exposed. I kind of did it quick so I wasn't sure if it was gonna work correctly anyway, it's probably not pulling from the correct places (combined shells (for projects) pull the nci config and add env vars from there, which afterwards should be merged with the env vars with the resulting shell but I guess something is going wrong there.

Thanks for the info, take your time.

investigating this more, i think why PKG_CONFIG_PATH doesn't appear in the numtide shell is because it doesn't have the necessary hooks, since that gets set in a hook from pkg-config. so you'd need to use the numtide rust / c modules to set this (iirc in the past nci also did this, it just used to throw everything that was a lib into one of those modules to set the correct env vars).

Good call, that was the missing piece. It isn't even necessary to include the language.c or language.rust modules from the numtide devshell, they both do just some very basic environment setup. I've created #160 with a working implementation now which just adds all dev outputs from the libraries to the LD_LIBRARY_PATH and sets the PKG_CONFIG_PATH to the one the devshell already provides.
With these changes the example bevy project from above works perfectly :)


Fails on Julia 0.5

On julia v0.5, I get the following error,
ERROR: LoadError: syntax: space before "(" not allowed in "AbstractVecOrMat{T}. By removing the space it works fine on julia v0.5 and also removes a depwarn in julia v0.4. I can send a PR if minimum version for julia is pinned to v0.4, which is v0.2 right now.

That would be nice, this is also causing troubles in other packages.

This is fixed in 6dd2496, this badly needs a tag. Closing this issue.


Version for php 7

Is there a version for php 7?

Hey! Thank you for your request. Unfortunately there's no PHP 7 version for the package, since it uses a lot of PHP 8 features. I'm sorry, but I hope you understand! 😊


Upload test coverage to Codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@a2beee3). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   99.65%
=======================================
  Files           ?        8
  Lines           ?      286
  Branches        ?        0
=======================================
  Hits            ?      285
  Misses          ?        1
  Partials        ?        0

Flag
Coverage Δ

#unittests
99.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2beee3...52936ee. Read the comment docs.


x/text/language: language.TraditionalChinese.Parent() != language.Chinese

What version of Go are you using (go version)?
go version go1.10.2 darwin/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/nick/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/nick/dev/gopath"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.10.2/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.10.2/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/l6/djg_zw1j5lgbwz4h5q92lnwr0000gn/T/go-build319403565=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
package main

import "fmt"
import "golang.org/x/text/language"

func main() {
	hans := language.SimplifiedChinese.Parent() == language.Chinese
	hant := language.TraditionalChinese.Parent() == language.Chinese
	fmt.Println(hans, hant) // true, false
}

What did you expect to see?
I expected language.TraditionalChinese.Parent() == language.Chinese
What did you see instead?
language.TraditionalChinese.Parent() == language.Und

I guess my real question is “why?”

@mpvl

That comment seems to rule out the possibility that the behaviour you're observing is a bug. In general we don't use the issue tracker for questions, it's just for actual bugs.

I guess my real question is “why?”

Are you just curious, or the observed (and documented) behaviour is causing you troubles?

Ultimately I am questioning the correctness/usefulness of this behavior.
A simple reading of the godoc doesn’t give any guidance to this behavior so I think the expected behavior described above is reasonable and the actual behavior is surprising.
As a user of this API, this caused an unexpected bug (which I was able to workaround): https://github.com/nicksnyder/go-i18n/issues/107
If this is indeed working as intended then I think better documentation would satisfy me. I am also personally curious to understand the rational for this particular behavior.

Okay, leaving this open then. Package owner @mpvl is likely the one that can answer your questions and make a decision about this.

This behavior is defined in http://unicode.org/reports/tr35/#Parent_Locales
The parent relationship is used to determine fallback data, or fields that can be inherited from "parent" languages. Generally this corresponds to stripping away the last part of a BCP 47 tag, but not always. In general, single-component tags typically apply some default script. For instance, Dutch is typically written in Latin script, so no use to write nl-Latn. However, some languages are commonly written in more than one script, and it would be bad for a user to fall back on a language for which the script is not understood.  In the case of zh and zh_Hant it is even worse, as they do not only imply a different script, but also, with high likelihood, a different language (cmn_Hans and yue_Hant, respectively). I guess zh is still widely used as there is still a decent amount of mutual intelligibility between the written form of Chinese languages if written in the same script. But one should not assume mutual intelligibility between different scripts. Hence.

Thanks for the explanation! The proposed documentation looks good to me.


added functionality to pass in lists to scatter

Wanted to be able to pass in two lists as xs, ys

bumb @glamp


drivers/cassandra: cleanup error handling in repair/clean

Coverage decreased (-0.1%) to 80.598% when pulling 48588b08787e984daa52481b59a148a71c9cffee on iksaif:master into 81b0436605efbe8f19ea158b83b4d30c42584357 on criteo:master.


v2 endpoint functions in _endpointsv2.py

in the file, _endpointsv2.py I created versions of all the endpoint methods that apply to the v2 endpoints (tried to stick as closely to the style that the originals were written in), for review before the data classes for schemas that are different in v2, then the client class can be worked on .

Looks good so far, added a few suggestions.
I think, it's better to continue in this PR until it's complete incl tests.
For the NessieClient class: WDYT about making that one "abstract" and move the existing functionality to a NessieClientV1 and the V2 stuff into a NessieClientV2? In NessieClient a "static function" (not sure if that exists in Python tho), that can construct a V1 or V2 client based on the configuration.
In the Java client we have a mechanism that checks that the API versions match (correct endpoint URL). In the Java client it "kicks in" right before the first request is issued - it performs a "GET /config" and inspects the "raw JSON" response, so it's independent from "serialization constraints" - see org.projectnessie.client.http.NessieApiCompatibilityFilter#check.

Should I try a seperate branch for soley the implementation of the of the abstract class, get that merged in then modify these methods. Just cause I sporadically have to time to work on this so I don't want too much being held up between these points.

Should I try a seperate branch for soley the implementation of the of the abstract class, get that merged in then modify these methods. Just cause I sporadically have to time to work on this so I don't want too much being held up between these points.

It's fine to use multiple commits, if necessary, in this PR (and branch) for now. Once we have the API settled and tests for the new code, we can merge it.


Increasing min margin of dashboard

Issue #3335. I'm not sure if this you wanted to fix, please check.

:+1:


The initial parameters for a condensed phase

Hi,
I performed a solvation calculation in Gaussian and, I would like to know the following: when GoodVibes reads the output and identifies that the calculation was carried out in a condensed phase, what initial value does it assume for concentration 1 mol/L or 1 bar?

Hi vaniamr,
By default, GoodVibes will use a pressure of 1.0 atm for gas phase calculations, however this should be adjusted for solvated systems using the -c option. We recommend using -c 1, which will adjust to a standard state of 1 mol/L for your calculation output files, adding a correction to the entropy in the process.
Thanks for using the program! Let us know if you have further questions!

Hi,
Yes! I used the -c option in my calculations. But my doubt is: The calculation that came out of the Gaussian already has corrections for the condensed phase, so the energy values present in the Gaussian output are already corrected for 1 mol / L. Having said that, GoodVibes, when I put the option -c, make a new correction in the values that are already corrected?
My situation is: I need some corrections to 0.0003 mol / L, so I used the option -c 0.0003. Hence what I want to know is whether a correction is made to the desired concentration directly, assuming that the value of the output is already corrected to 1 M. Or if the correction of the gas phase to the condensed phase is redone and then to the desired concentration, because if it is the last one I have phase change corrections being done twice.


How to draw a LineChartDataSet skipping certain data points

Hello,
below there is the method that I use to generateLineData. However I would like to skip the data points where the data.price value is different than INT16_MIN.
Unfortunately there is no source code for " [[LineChartDataSet alloc] initWithYVals:entries label:@"Price"];". The code below does not seem to do the job as I believe passing a mutable array to the initWithYVals method is not the correct way to deal with this (there is no fixed enumeration on it so it would not know when a data point is missed).
What should I do to get the library to skip some data points?
- (LineChartData *)generateLineData
    {
    LineChartData *d = [[LineChartData alloc] init];

    NSMutableArray *entries = [[NSMutableArray alloc] init];

    for (int index = 0; index < [self.data count]; index++)
    {
        MyData * data = [self.data objectAtIndex:index];
        if (data.price != INT16_MIN) {
            [entries addObject:[[ChartDataEntry alloc] initWithValue:data.price xIndex:index]];
        }
    }

    LineChartDataSet *set = [[LineChartDataSet alloc] initWithYVals:entries label:@"Price"];
    [set setColor:[UIColor colorWithRed:240/255.f green:238/255.f blue:70/255.f alpha:1.f]];
    //    set.lineWidth = 2.5;
    set.lineWidth = 1.0;
    [set setCircleRadius:1.0f];
    [set setCircleColor:[UIColor colorWithRed:240/255.f green:238/255.f blue:70/255.f alpha:1.f]];
    set.fillColor = [UIColor colorWithRed:240/255.f green:238/255.f blue:70/255.f alpha:1.f];
    set.drawCubicEnabled = YES;
    set.drawValuesEnabled = YES;
    set.valueFont = [UIFont systemFontOfSize:0.f];
    set.valueTextColor = [UIColor colorWithRed:240/255.f green:238/255.f blue:70/255.f alpha:1.f];
    // set.axisDependency = AxisDependencyLeft;

    [d addDataSet:set];
    return d;
}

you can just don't feed y value for the specific xIndex. It will pass it, and then connect the previous data to the next valid one.
e.g.
x: 0 1 2 3 4
y: 1    3 5 6


Import error ExternalHttpFunctionApp

We are running python app functions started by a service queue. We have made no changes on our end and we are now receiving the following error across multilple app functions:
Result: Failure Exception: ImportError: cannot import name 'ExternalHttpFunctionApp' from 'azure.functions.decorators.function_app' (/azure-functions-host/workers/python/3.9/LINUX/X64/azure/functions/decorators/function_app.py) Stack: File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/dispatcher.py", line 383, in _handle__function_load_request ExtensionManager.function_load_extension( File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/utils/wrappers.py", line 19, in call return func(*args, **kwargs) File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/extension.py", line 65, in function_load_extension sdk = cls._try_get_sdk_with_extension_enabled() File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/extension.py", line 225, in _try_get_sdk_with_extension_enabled sdk = get_sdk_from_sys_path() File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/utils/common.py", line 121, in get_sdk_from_sys_path module = importlib.import_module('azure.functions') File "/usr/local/lib/python3.9/importlib/__init__.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "<frozen importlib._bootstrap>", line 1030, in _gcd_import File "<frozen importlib._bootstrap>", line 1007, in _find_and_load File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 680, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 850, in exec_module File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/functions/__init__.py", line 14, in <module> from .decorators.function_app import (FunctionRegister, TriggerApi, BindingApi,
Unfortunately the azure interface would not let me copy the whole error message.
Our location is France Central

This the full error message: Failure\nException: ImportError: cannot import name 'ExternalHttpFunctionApp' from 'azure.functions.decorators.function_app' (/azure-functions-host/workers/python/3.9/LINUX/X64/azure/functions/decorators/function_app.py)\nStack:   File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/dispatcher.py", line 383, in _handle__function_load_request\n    ExtensionManager.function_load_extension(\n  File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/utils/wrappers.py", line 19, in call\n    return func(*args, **kwargs)\n  File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/extension.py", line 65, in function_load_extension\n    sdk = cls._try_get_sdk_with_extension_enabled()\n  File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/extension.py", line 225, in _try_get_sdk_with_extension_enabled\n    sdk = get_sdk_from_sys_path()\n  File "/azure-functions-host/workers/python/3.9/LINUX/X64/azure_functions_worker/utils/common.py", line 121, in get_sdk_from_sys_path\n    module = importlib.import_module('azure.functions')\n  File "/usr/local/lib/python3.9/importlib/init.py", line 127, in import_module\n    return _bootstrap._gcd_import(name[level:], package, level)\n  File "", line 1030, in _gcd_import\n  File "", line 1007, in _find_and_load\n  File "", line 986, in _find_and_load_unlocked\n  File "", line 680, in _load_unlocked\n  File "", line 850, in exec_module\n  File "", line 228, in _call_with_frames_removed\n  File "/home/site/wwwroot/.python_packages/lib/site-packages/azure/functions/init.py", line 14, in \n    from .decorators.function_app import (FunctionRegister, TriggerApi, BindingApi,\n","Error"

We have deployed and now the app functions are working as expected. I can see that the docker images were updated yesterday https://hub.docker.com/_/microsoft-azure-functions-python

Hello, I also hit that issue in one of my projects and I had to redeploy.
@Microsoft-team could you please investigate and provide an explanation? Thank you

I am experiencing the exact same problem (and have not done any code updates over the last few months). A fix by Microsoft would be greatly appreciated. Locally everything works fine, but remotely in the cloud it just stops.
@alex-akanthas : how did your redeploying solve this? I ran our build pipeline manually and can see that the setting Website_run_from_package points to the updated package in the storage account, but the function still fails.

When we raised a support ticket the support window reported an outage in east us and central us region for Azure function apps, we deployed in a different region and it worked. Azure should have been proactive about it. I am not sure what is the current status since today morning, but I think that became fault for more than 12 hours.

I just ran into this error as well.
It looks that the reference to ExternalHttpFunctionApp was removed in version 1.13.3 of the azure-functions python library in this change
Our code was still running version 1.13.2, which still included that reference, and we were seeing the same error as above, 500s on all calls to our HTTP functions.
Updating our code to the latest version 1.14.0 resolved the issue (though just updating to 1.13.3 might have also worked).
It appears the docker image updated to 4.19.0,
which updated the function host to 4.19.0,
which updated the python worker to 4.11.0,
which uses the python lib sdk 1.13.3
Something is this update chain broke support for the older version 1.13.2
https://github.com/Microsoft-team could you please investigate and provide an explanation how this breaking change was introduced?

@alex-akanthas and  @builtbywill : excellent. I have updated to 1.14.0 and now it works. Thanks a lot for the good explanations! Much appreciated!

@alex-akanthas  Thanks for reporting the issue. Please use following mitigation to resolve the issue. Team is working on fix, and it will be available in future releases.
Potential mitigation would be to try adding the following options:

Remove pinning of the Azure-functions library, or pin 1.14.0+
Enable Dependency Isolation: PYTHON_ISOLATE_WORKER_DEPENDENCIES to 1 in App settings.
Disable Worker Extensions (if you are not using them) - PYTHON_ENABLE_WORKER_EXTENSIONS to 0.

If the error persists, please revert the changes. Thanks


issue3787/UnsetExceptions should not be wrapped

Description
https://github.com/inmanta/inmanta-core/pull/3859/files changed how exceptions are wrapped and handled.
The unsetException should never be wrapped as it is used by the compiler. This PR fixes the introduced error.
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches master in 6be21b6261d26c3ec386750ca9953f36a15e2f4a

Processing #3941.

Processing #3940.


Feature Request: Support Hard Line Breaks in Markdown

Summary
Add hard line breaks to the markdown parser.
Reasoning

Some content needs non-paragraph linebreaks (e.g. Poetry)
It is a common feature of different Markdown dialects (Github flavored markdown, CommonMark)
therefore not supporting it breaks user expectation (at least mine)

Proposed Solution
CommonMark and Github's MD both use the following convention

two spaces followed by a newline is translated to

a backslash followed by a newline is translated to

I added this feature to the LiaScript parser .... I will still need to run a few tests, but I think we will release by the end of this week ;-)

Thanks for the quick implementation. Just for clarity's sake:

two spaces followed by a newline is translated to
a backslash followed by a newline is translated to

part 2 is now implemented by eaa6f3e
I think it is fine not to implement the spaces to line breaks-part. invisible markup is not the greatest idea.

With the latest update discovered, that now it is also possible to break headings. Do you know of other Markdowns, that support this? GitHub does not as I checked, but this would be a really nice feature to deal with long and short section-names as it is also supported by latex. The first is the title in the table-of-contents, and the second and further parts are displayed in the slide ... Just thinking aloud ...
# Hello World \
 with a longer url

This is a paragraph\
with a line-break...

[next](#a-section-with-a-very-very-long-title)

## A Section\
 with a very very long title

Demo


Camera path during render

Hi, great work! I was wondering how to alter the camera path during rendering that produces the video: "video_rgb". Thanks

For D-NeRF: here
For colmap-format: here (you should customize it.)
HyperNeRF: here

For D-NeRF: here For colmap-format: here (you should customize it.) HyperNeRF: here Neu3D: here

Thank you so much. For multiview scenes would I use the colmap format?

You can see this, original pose format is colmap, but script convert them to 3DGS's camera format


Merge fix from upstream

Due to upstream repo inactivity, I had to fork it to release fixes.

[x] typeorm - fixed cache - do not use cache when updating resources.  Upstream PR https://github.com/nestjsx/crud/pull/688 Repo PR #3
[x] FIX - select boolean type in JoinOption.  Upstream PR https://github.com/nestjsx/crud/pull/713 Repo PR https://github.com/rewiko/crud/pull/4
[ ] fix(crud-typeorm): include embeded column name in search query.  Upstream PR  https://github.com/nestjsx/crud/pull/601
[x] Update README.md https://github.com/nestjsx/crud/pull/611
[x] fix(crud): typo fix getMayRouteOptions -> getManyRouteOptions #606
[x] fix(crud): using metadata to update entities based on primary key instead of "found". Upstream PR https://github.com/nestjsx/crud/pull/622
[x] Fix constant when getting swagger extra models, Upstream PR https://github.com/nestjsx/crud/pull/626/files
[x] fix filter for user in meController, Upstream PR https://github.com/nestjsx/crud/pull/644
[x] Make updateOneBase dto type partial, Upstream PR https://github.com/nestjsx/crud/pull/679
[x] Add warning when using disallowed relation, Upstream PR https://github.com/nestjsx/crud/pull/683
[ ] feat(crud-typeorm): ignore entity decorators when saving, Upstream PR https://github.com/nestjsx/crud/pull/692
[x] fix(crud-typeorm): fix sql injection check looping on the first regex…, Upstream PR https://github.com/nestjsx/crud/pull/694
[ ] fix(crud-typeorm): use random parameter name to prevent invalid parameters, Upstream PR https://github.com/nestjsx/crud/pull/723
[x] fix(NestJSX-CRUD-TypeOrm): bug Ability to Use Search and Filter Features with Nested Entities, Upstream PR https://github.com/nestjsx/crud/pull/737
[ ] CHG - Provide options for qs url params stringify, Upstream PR https://github.com/nestjsx/crud/pull/749
[ ] Allow all relation to be joined, Upstream PR https://github.com/nestjsx/crud/pull/574
[ ] feat: add custom operators, Upstream PR https://github.com/nestjsx/crud/pull/568
[x] fix(typeorm): correct quotes for column identifiers when driver is ‘mariadb‘, Upstream PR https://github.com/nestjsx/crud/pull/546
[ ] Fix(crud-response-interceptor): classToPlain call two time, Upstream PR https://github.com/nestjsx/crud/pull/526

Greaaat ❤🔥🌹 Thanks for keeping this Up !!

Hey! Thanks a lot for this work, really appreciate it. Could you take a look to include my PR (https://github.com/nestjsx/crud/pull/622) in the next release? It features a pretty critical bug that you could not set new relations when PATCHing resources.

@dschoeni I merged your changer released via https://github.com/rewiko/crud/issues/5, https://www.npmjs.com/package/@rewiko/crud version 5.1.1

absolutely awesome, thanks a lot!

any ETA on when the other upstream stuff is gonna be worked on?
I'm especially interested in: https://github.com/nestjsx/crud/pull/274 because we really need the sequelize crud repo.

Contributions are welcome but I am not actively maintaining it, happy to merge and release things.

@rewiko If possible, could you please contribute to the following forked repo, which is more up-to-date? Thanks!
https://github.com/gid-oss/dataui-nestjs-crud

@rewiko Also, can you please review and add the following PR?
https://github.com/nestjsx/crud/pull/754
Thanks!