Port sometimes is not honored in routing

Bug description
We noticed that sometimes under an increase of traffic (not high though) when we call one service from another having several routes where the target port is not the same as the one the first service connects to, the routing goes to normal Kubernetes service as if the Istio routing is ignored.
More precisely, we narrowed it down to the following simple example:

service A calls service B using http://service-b.<namespace>.svc.cluster.local
service B has two ports 80 (http) and 3001 (http-api)
service B has Virtual Service which sends all the traffic to port 3001.

spec:
  gateways:
    - mesh
  hosts:
    - service-b
  http:
    - match:
        - uri:
            prefix: /
      retries:
        attempts: 0
      route:
        - destination:
            host: service-b
            port:
              number: 3001
      timeout: 10s

Sometimes requests from A go to service B port 80, instead of 3001
[ ] Docs
[ ] Installation
[X] Networking
[X] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Requests should always go according to the rules specified in the Virtual Service or fail.
Steps to reproduce the bug
So, I prepared a repo https://github.com/jughead/istio-routing-issue with two golang apps, A calling B.
B starts on port 3000 (which is mapped to 80 in Kubernetes Service) and 3001 (mapped to 3001). On port 3000 service B returns string 1, on port 3001 it returns 2.
When service A sees 1 from service B, it returns HTTP 400, otherwise it returns 200.
Then if I deploy that in Kubernetes with Istio sidecars, wait for them to be ready and load the service A, I sometimes see 400 statuses, although nothing is changing in the cluster and the load is not that big 50rps.
Here is the logs from istio-proxy containers. It seems as sometimes the requests go to B using PassthroughCluster, but I don't know why.
EXAMPLE SERVICE B istio proxy logs
[2021-08-02T13:39:34.165Z] "GET / HTTP/1.1" 200 - "-" "-" 0 1 1 0 "-" "Go-http-client/1.1" "1bb51296-9f7b-448b-b9f7-8b259b2f8c69" "istio-routing-issue-b" "<IP_ADDRESS>:3001" inbound|3001|http-api|istio-routing-issue-b.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:37258 <IP_ADDRESS>:3001 <IP_ADDRESS>:37910 outbound_.3001_._.istio-routing-issue-b.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:34.172Z] "GET / HTTP/1.1" 200 - "-" "-" 0 1 0 0 "-" "Go-http-client/1.1" "3ff1cf88-060f-4f53-8efb-48577b924e15" "istio-routing-issue-b" "<IP_ADDRESS>:3001" inbound|3001|http-api|istio-routing-issue-b.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:37258 <IP_ADDRESS>:3001 <IP_ADDRESS>:37910 outbound_.3001_._.istio-routing-issue-b.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:34.196Z] "GET / HTTP/1.1" 200 - "-" "-" 0 1 0 0 "-" "Go-http-client/1.1" "704a9311-136f-4887-8593-5c6b12de7b48" "istio-routing-issue-b" "<IP_ADDRESS>:3001" inbound|3001|http-api|istio-routing-issue-b.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:37258 <IP_ADDRESS>:3001 <IP_ADDRESS>:37910 outbound_.3001_._.istio-routing-issue-b.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:34.218Z] "GET / HTTP/1.1" 200 - "-" "-" 0 1 0 0 "-" "Go-http-client/1.1" "96b9214f-d53f-4d42-9c2d-c76bbb5977aa" "istio-routing-issue-b" "<IP_ADDRESS>:3001" inbound|3001|http-api|istio-routing-issue-b.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:37258 <IP_ADDRESS>:3001 <IP_ADDRESS>:37910 outbound_.3001_._.istio-routing-issue-b.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:34.251Z] "GET / HTTP/1.1" 200 - "-" "-" 0 1 1 1 "-" "Go-http-client/1.1" "2c158c34-9a3c-48c2-9ab5-1c4dacfcbc2a" "istio-routing-issue-b" "<IP_ADDRESS>:3000" inbound|80|http|istio-routing-issue-b.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:48924 <IP_ADDRESS>:3000 <IP_ADDRESS>:59766 - default
[2021-08-02T13:39:34.251Z] "GET / HTTP/1.1" 200 - "-" "-" 0 1 1 1 "-" "Go-http-client/1.1" "332b3fe6-5002-4ad1-ad00-5e5ec602f0ae" "istio-routing-issue-b" "<IP_ADDRESS>:3001" inbound|3001|http-api|istio-routing-issue-b.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:37258 <IP_ADDRESS>:3001 <IP_ADDRESS>:37910 outbound_.3001_._.istio-routing-issue-b.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:34.264Z] "GET / HTTP/1.1" 200 - "-" "-" 0 1 0 0 "-" "Go-http-client/1.1" "a6b0c4a5-fc02-4d2c-85f5-48f7e95eeba7" "istio-routing-issue-b" "<IP_ADDRESS>:3000" inbound|80|http|istio-routing-issue-b.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:48924 <IP_ADDRESS>:3000 <IP_ADDRESS>:59766 - default
[2021-08-02T13:39:34.299Z] "GET / HTTP/1.1" 200 - "-" "-" 0 1 0 0 "-" "Go-http-client/1.1" "112251fe-f884-460c-97c6-b7e48c4fb793" "istio-routing-issue-b" "<IP_ADDRESS>:3000" inbound|80|http|istio-routing-issue-b.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:48924 <IP_ADDRESS>:3000 <IP_ADDRESS>:59766 - default

EXAMPLE SERVIE A istio proxy logs

[2021-08-02T13:39:34.196Z] "GET / HTTP/1.1" 200 - "-" "-" 0 1 1 1 "-" "Go-http-client/1.1" "704a9311-136f-4887-8593-5c6b12de7b48" "istio-routing-issue-b" "<IP_ADDRESS>:3001" outbound|3001||istio-routing-issue-b.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:37910 <IP_ADDRESS>:80 <IP_ADDRESS>:59718 - -
[2021-08-02T13:39:34.196Z] "GET / HTTP/1.1" 200 - "-" "-" 0 32 2 2 "<IP_ADDRESS>, <IP_ADDRESS>,<IP_ADDRESS>" "Go-http-client/2.0" "9ecc3406-d6a0-4691-b76b-20bfe3222e16" "istio-routing-issue.example.com" "<IP_ADDRESS>:3000" inbound|80|http|istio-routing-issue-a.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:33714 <IP_ADDRESS>:3000 <IP_ADDRESS>:0 outbound_.80_._.istio-routing-issue-a.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:34.218Z] "GET / HTTP/1.1" 200 - "-" "-" 0 1 1 0 "-" "Go-http-client/1.1" "96b9214f-d53f-4d42-9c2d-c76bbb5977aa" "istio-routing-issue-b" "<IP_ADDRESS>:3001" outbound|3001||istio-routing-issue-b.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:37910 <IP_ADDRESS>:80 <IP_ADDRESS>:59718 - -
[2021-08-02T13:39:34.217Z] "GET / HTTP/1.1" 200 - "-" "-" 0 32 1 1 "<IP_ADDRESS>, <IP_ADDRESS>,<IP_ADDRESS>" "Go-http-client/2.0" "190ee33b-3148-4bd8-abfd-1d31fb29475c" "istio-routing-issue.example.com" "<IP_ADDRESS>:3000" inbound|80|http|istio-routing-issue-a.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:33714 <IP_ADDRESS>:3000 <IP_ADDRESS>:0 outbound_.80_._.istio-routing-issue-a.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:34.251Z] "GET / HTTP/1.1" 200 - "-" "-" 0 1 2 2 "-" "Go-http-client/1.1" "332b3fe6-5002-4ad1-ad00-5e5ec602f0ae" "istio-routing-issue-b" "<IP_ADDRESS>:3001" outbound|3001||istio-routing-issue-b.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:37910 <IP_ADDRESS>:80 <IP_ADDRESS>:59718 - -
[2021-08-02T13:39:34.250Z] "GET / HTTP/1.1" 200 - "-" "-" 0 32 3 3 "<IP_ADDRESS>, <IP_ADDRESS>,<IP_ADDRESS>" "Go-http-client/2.0" "33b205c1-9359-436c-8c60-a3a8ba15cf2c" "istio-routing-issue.example.com" "<IP_ADDRESS>:3000" inbound|80|http|istio-routing-issue-a.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:33714 <IP_ADDRESS>:3000 <IP_ADDRESS>:0 outbound_.80_._.istio-routing-issue-a.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:34.250Z] "GET / HTTP/1.1" 400 - "-" "-" 0 0 3 3 "<IP_ADDRESS>, <IP_ADDRESS>,<IP_ADDRESS>" "Go-http-client/2.0" "a749a45e-a2e6-44fb-8987-b6766b30ab62" "istio-routing-issue.example.com" "<IP_ADDRESS>:3000" inbound|80|http|istio-routing-issue-a.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:33732 <IP_ADDRESS>:3000 <IP_ADDRESS>:0 outbound_.80_._.istio-routing-issue-a.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:34.264Z] "GET / HTTP/1.1" 400 - "-" "-" 0 0 2 1 "<IP_ADDRESS>, <IP_ADDRESS>,<IP_ADDRESS>" "Go-http-client/2.0" "e9e203b6-8a28-4eef-985a-308267cbd1b0" "istio-routing-issue.example.com" "<IP_ADDRESS>:3000" inbound|80|http|istio-routing-issue-a.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:33714 <IP_ADDRESS>:3000 <IP_ADDRESS>:0 outbound_.80_._.istio-routing-issue-a.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:34.298Z] "GET / HTTP/1.1" 400 - "-" "-" 0 0 2 1 "<IP_ADDRESS>, <IP_ADDRESS>,<IP_ADDRESS>" "Go-http-client/2.0" "85931162-baa6-4992-a309-e32ebb6e55bb" "istio-routing-issue.example.com" "<IP_ADDRESS>:3000" inbound|80|http|istio-routing-issue-a.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:33714 <IP_ADDRESS>:3000 <IP_ADDRESS>:0 outbound_.80_._.istio-routing-issue-a.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:34.309Z] "GET / HTTP/1.1" 400 - "-" "-" 0 0 1 1 "<IP_ADDRESS>, <IP_ADDRESS>,<IP_ADDRESS>" "Go-http-client/2.0" "2f1c5d04-0e9b-45af-bea0-659924ee87d9" "istio-routing-issue.example.com" "<IP_ADDRESS>:3000" inbound|80|http|istio-routing-issue-a.istio-routing-issue.svc.cluster.local <IP_ADDRESS>:33714 <IP_ADDRESS>:3000 <IP_ADDRESS>:0 outbound_.80_._.istio-routing-issue-a.istio-routing-issue.svc.cluster.local default
[2021-08-02T13:39:15.254Z] "- - -" 0 - "-" "-" 21420 56070 109057 - "-" "-" "-" "-" "<IP_ADDRESS>:80" PassthroughCluster <IP_ADDRESS>:59766 <IP_ADDRESS>:80 <IP_ADDRESS>:59726 - -

Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
istioctl version --remote:
client version: 1.6.14
control plane version: 1.6.14
data plane version: 1.6.14 (20 proxies)
kubectl version --short:
Client Version: v1.21.2
Server Version: v1.18.16-eks-7737de
How was Istio installed?
./istioctl install -f v1.6.14.yaml
Environment where the bug was observed (cloud vendor, OS, etc)
AWS EKS

Please upgrade, I am fairly sure this is due to protocol detection timeout which is fixed since Istio 1.6. 1.6 is EOL: https://istio.io/latest/news/support/announcing-1.6-eol/.
Basically there is some (small) window to detect the protocol, which under load its timing out. This is fixed on newer versions.
Thanks!


Composite separate methods

Should be merged after other PR fixing the populate.

I need to regenerate the assets to ensure the unit tests are passing.


thread5.rs does not need Arc

It runs fine if I remove Arc wrapper. This is 7-shared-and-networking.md

This is very true! Although in your case, actual copies of the string are passed to each thread, and the Arc case shared references are passed.  Would only notice if the string was truly enormous! So let me think how to frame this example where the difference is more obvious.

Perhaps also use a struct (that doesn't implement Copy) so the benefit of Arc is clear. WIth a String, one can just use a &str and ends up no needing the owned variety to see the benefit. Am not sure though if I understand this well?

If we used a &str reference originally, then we'll always get a 'does not live long enough' error. Putting the reference into an Arc doesn't help that - it remains a reference.  I think I will emphasize that the clone here is much cheaper in the Arc case.

Have a look at the change - you can still clone the reference even if the value itself doesn't implement Clone.

I din't get the long life complaint when I used &str. See https://gist.github.com/tshepang/237d547c38e435144d6fe1887068d33e.

Puzzled me until I realized that &str is indeed Copy, so it moves just fine. It works because the lifetime of the string slice is static - if we pulled a slice out of a local string, then you would get the error:
    let string = "dolly".to_string();
    let name: &str = &string;

This would also work, const NAME: &str = "hello". So it's all about references to our own objects that have  less-than-static lifetime.

Rust is not easy

Well, this has really helped me with a delicate piece of explanation. Ultimately, plain references don't work in threads because they have too short a lifetime to work with move closures.  (Same problem with frameworks like gtk.rs).  Same problem with C++ actually, except there is nothing stopping you pointing the gun at your foot.


re-griding

Describe the bug
The regriding issue is causing an error on AWS

To Reproduce
Steps to reproduce the behavior:

re run task defintion 51 on AWS

Expected behavior
For it to work and re grid the nwp data
Additional context
There is a warning

Also had to add

now working, just need to deploy https://github.com/openclimatefix/ocf-infrastructure/pull/322

Can we close this as completed @peterdudfield?

Yea, close it


Not working properly on Safari iPhone 6?

One of the visitors of my site reported a screenshot which clearly shows that all images which don't have "src" attribute don't display on Safari iPhone 6.
Has this been tested on all mobile devices?

Yes of course

Can you report HTML, CSS and JS code that you're using on your website? Maybe I can help you. But yes, LazyLoad it's used in production on many websites, I'm pretty sure it works on all devices

Unfortunately I can't report that because I removed lazyload from the site completely after finding out that it is necessary to use invalid HTML (img without src as reported in the other issue). Logically we can't expect any browser to be able to render invalid HTML long term although it may theoretically work, so I don't want to risk the sites I am working on to have content which users may not be able to see. I have tested at least 5 different lazy load solutions and all seem to use this trick to move the img url to another attribute but it doesn't seem correct. I hope you can find a better, browser-, seo- and valid-html- friendly solution.

Thanks for the suggestion @anchev,
but putting the src and srcset in the img tag triggers the immediate download of the linked image. There's no way of lazily loading images that way.

You can probably use a placeholder gif pixel which will be replaced with the actual image. Or even better: a downsized version of the image - then search engines will be able to index it without duplicate content issues.

But @anchev, this is what you author should do. It's not up to the editor of the script to manage your HTML or downscale your images.
You could do:

...or simply use a placeholder on all your images...

Sure. I just didn't see src in the demos so I thought it must not be there at all in order your script to work properly. But if it can be there, that's great.

Psst: have you already starred this repo? All you need to do is to press the Star ★ button on the top right corner of the website. ;)


Can not open/save file from remote desktop of a windows server core installation

VsCode crashes when it tries to use the open/save dialog when it is run in a tse session of a windows server core installation.
Version: 1.35.1 (user setup)
Commit: c7d83e57cd18f18026a8162d042843bda1bcf21f
Date: 2019-06-12T14:30:02.622Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.16299

Steps to Reproduce:

Install vscode on a windows server code
Try to open a file using the file/open menu

Does this issue occur when all extensions are disabled?: Yes

From https://code.visualstudio.com/docs/supporting/requirements#_platforms I do not see Windows Server as a supported platform. Closing given that.


Add CVMFS as a singularity requirement

Although it's not a strict requirement, Singularity in the OSG needs CVMFS for image distribution perhaps this is only true for a few VOs and if that's the case, we can add a disclaimer.

You are correct, not a strict requirement.  Of course the jobs can always run the singularity command as part of the job.


Update syslog-tag mention in README.md

Description
Change the mention of syslog-tag to tag in the README.
Issues Resolved
No existing issues, though https://github.com/Accenture/adop-docker-compose/issues/115 is revelant.
Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

I hate to be even putting in this PR for a one-word change, but it was a bit of a search before I figured out this was the issue. The related (but closed) issue is eight months old, so maybe the assumption of users running a newer docker version is safe?

Thanks!


Calculate CRC32C using SIMD acceleration

This pull request contains two sections: one benchmark and modification to replace crate crc with crc32c.
A typical micro-bench run shows the following metrics

@lizhanhui Thank you very much for putting this together :+1:
The crc32c crates does not seem to provide hardware acceleration for ARM.
Have you tried benchmarking the current crc crate version the software fallback of crc32?
I just want to make sure this change will not degrade performance for environment where hardware acceleration is not leveraged.

The crc32c crates does not seem to provide hardware acceleration for ARM.

Good catch! :raised_hands:

@lizhanhui Thank you very much for putting this together 👍
The crc32c crates does not seem to provide hardware acceleration for ARM. Have you tried benchmarking the current crc crate version the software fallback of crc32?
I just want to make sure this change will not degrade performance for environment where hardware acceleration is not leveraged.

Not yet, let's add one comparison between crc32c baseline and crc.

The crc32c crates does not seem to provide hardware acceleration for ARM.

Hardware acceleration for ARM is guarded by nightly
https://github.com/zowens/crc32c/blob/d70d4e253c4570a073f485d62bc30c4fd64a4b1f/src/lib.rs#L51

After forking crate crc32c and introducing features to enable/disable hardware acceleration, I got the following result on a 2015-early Intel Macbook Air. (Note the previous run is performed on a M1 Macbook Pro, AArch64, nightly rust used)
without hardware acceleration

cargo bench --no-default-features

Conclusion: crc32c is 4X faster than crc using pure software algorithm
with hardware acceleration

cargo bench

Conclusion: crc32c is about 10X faster with hardware acceleration
@timvisee @agourlay  My Mac at home is kind of old. You can try it on your modern one.

As discussed in the issue, there is still some optimization space ahead.  Some 5X should be possible.

@lizhanhui Excellent work, you convinced me that the change is a net positive for all users.
Please remove the last commit to get back to a published version and I am good for :heavy_check_mark:

Thanks for the compliment. The last commit has been reverted.

@agourlay Hold on.  I think I spot an issue with crate crc when it's initialized with an arbitrary seed value.

CRC with custom seed/initial value is somewhat unclear in RFCs. Here is a relevant discussion
Crate 'crc' takes refin = true  into account while 'crc32c' does not. I created a pull request to make them behave consistently.
In addition, I added an extra test case to ensure we will get exactly same checksum values.
Eventually, this pull request is completely sound and ready to be merged.

@lizhanhui Very nice work! Thank you so much for your efforts.
Am I correct that we're currently waiting on https://github.com/zowens/crc32c/pull/50, after which this can be merged?

Am I correct that we're currently just waiting on https://github.com/zowens/crc32c/pull/50, after which this can be merged?

No, we can merge directly.  This pull request does not use the API that is inconsistent with crate 'crc' anymore.


missing config?

root@solar:~/moonmoon-compose# docker-compose up
ERROR: In file './docker-compose.yml' service 'version' doesn't have any configuration options. All top level keys in your docker-compose.yml must map to a dictionary of configuration options.

It looks like you're running an outdated version of docker-compose. Please update, I recommend installing via pypi pip install docker-compose or from the github releases. The packages on Ubuntu are outdated for some odd reasons.

Which is pretty weird, because Ubuntu usually ships the latest software :/

root@solar:~/moonmoon-compose# docker-compose --version
docker-compose version 1.5.2, build unknown

debconf: falling back to frontend: Readline
Adding system-user for exim (v4)
Setting up exim4-base (4.84.2-2+deb8u3) ...
E: Sub-process /usr/bin/dpkg exited unexpectedly
ERROR: Service 'moonmoon' failed to build: The command '/bin/sh -c cd /var/www/html &&     apt-get update && apt-get install -y git unzip cron &&     curl https://getcomposer.org/composer.phar -o composer.phar &&     php composer.phar install &&     rm -rf composer.phar install.php admin/ tests/ *.yml *.json            README.markdown LICENSE VERSION &&     apt-get autoremove -y git unzip' returned a non-zero code: 100
(.compenv) root@solar:~/moonmoon-compose#

I cannot reproduce the build failure. I'm currently running:
yuki@matsuoka ~ $ docker --version
Docker version 1.13.0, build 49bf474
yuki@matsuoka ~ $ docker-compose --version
docker-compose version 1.10.0, build 4bd6f1a


Fixing cancelled status for pipelines.

Closes #196.

Codecov Report

Merging #197 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #197   +/-   ##
======================================
  Coverage    62.2%   62.2%
======================================
  Files          48      48
  Lines        3934    3934
======================================
  Hits         2447    2447
  Misses       1082    1082
  Partials      405     405

Impacted Files
Coverage Δ

workers/scheduler/scheduler.go
65.43% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d44dd08...2b22916. Read the comment docs.


Issue while Adding AWS Account [BUG]

(This is in reference to issue #980)
Hi @rnithinpaladin, I was trying to add the AWS account to Paladin and I am facing some issues as I had to run the upgrade command which redeployed the entire stack probably. I made the same changes in the task definitions that we had made earlier, however, I am still getting the same error and am unable to log in. Can we quickly connect and check the configurations once? Thanks!

https://meet.google.com/ojm-yfkz-wgo?authuser=0

Hi @shoebshaikh1 , please join our slack ( https://paladincloud.io/ and click on slack link ), we can have much easier convo.

Please let us know when you are ready to join, we can jump on a call with you

Hi @shoebshaikh1 , let us use https://meet.google.com/ojm-yfkz-wgo?authuser=0 to get on a call

@Subbu-PaladinCloud , Yes I am connecting on the above link.

Fixed in 3.0


Add --showConfig argument

Summary
This solves #3288. It adds a JSON output of the config and then exits.

Adds a --showConfig argument.
Updates the --debug output to be JSON.
Updates the jest-editor-support package to use --showConfig.

Test plan

Integration tests pass.
jest --showConfig outputs config and exits.

Codecov Report

Merging #3296 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3296   +/-   ##
=======================================
  Coverage   63.89%   63.89%
=======================================
  Files         176      176
  Lines        6473     6473
  Branches        4        4
=======================================
  Hits         4136     4136
  Misses       2336     2336
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6517c7b...4c94e52. Read the comment docs.

Alright, changed the test over to snapshot and made the additional requested changes.
One thing I couldn't get working is the test for jest-editor-support. If someone could point me in the right direction to fix that test, that would be great.

I've updated the original description to include everything changed in here. I tried my best adding a test for the Settings module for jest-editor-support package, please give feedback on that. I've address all other feedback so far, good for another round of reviews. :)

cc @orta


Make AmbientValues explicit in GetPathByAddress

We want to make it possible for some address schemes to use ambient values, and other to ignore them. The best way that I can think of is to make the ambient values an explicit argument to GetPathByAddress, so that the scheme-specific extension methods can pass them in if they want them.

Done


Add Langium-like dependency injection

Also fixes a binding mistake in the test.

@Lotes Thanks again for your nice work!
Due to limited time, I just did some quick fixes on my own. Please review them carefully!


Web support

This PR depends on #92, which should be merged first.
This resolves #51.
As the URL cannot be changed in Web apps by an external process without restarting the app, attempting to use the stream APIs will result in an UnsupportedError.

@avioli

@avioli

Thank you @hacker1024

Is the package now supporting flutter web?

Is the package now supporting flutter web?

@avioli  please answer this question

I don't think it does. I'm still getting the unsupported error.

I am getting below error
Error: Unsupported operation: As the Web URL cannot be changed without restarting the application, link streams are unimplemented on this platform.


fix: add missing exports for endpoints

Exports track traces
Exports subscription capabilities

:tada: This PR is included in version 3.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Document a17-fieldset

Add to docs
There's no reference on docs to the prop :open="false" on the docs, not sure if there's any other prop that could be documented.

I think we never really document the Vue components.
But instead, I have added the option the blade directive + documented this.
See https://github.com/area17/twill/pull/1420


[2.x] Allow automatic seeding after automatic migrations

Fixes #158
If config('tenancy.seeder_class') is null or a blank string, the seeder-class parameter is not passed, and therefore Laravel's default option of calling 'DatabaseSeeder' will occur.
As with Laravel's normal seeding process, the class is treated as the "root" seeder class, which can call other seeder classes in turn.

Looks very good! I was thinking that there should be a separate job for the seeding, but:

dispatching two jobs for this could be a bit painful (race conditions)
You can't seed without migrating anyway

So using the same job is probably the right approach. I'll think about how to rename it, so that it isn't called "migrator" when it also seeds.
Speaking of point 1, there is probably a race condition in my code: the migrate job could run sooner than the DB creation job. I'll look into that.

Looks very good! I was thinking that there should be a separate job for the seeding, but:

dispatching two jobs for this could be a bit painful (race conditions)
You can't seed without migrating anyway

So using the same job is probably the right approach. I'll think about how to rename it, so that it isn't called "migrator" when it also seeds.
Speaking of point 1, there is probably a race condition in my code: the migrate job could run sooner than the DB creation job. I'll look into that.

@stancl maybe you can use Job Chaining. Job chaining allows you to specify a list of queued jobs that should be run in sequence after the primary job has executed successfully.
SetupTenant::withChain([
    new CreateTentantDB,
    new MigrateTentantDB,
])->dispatch();

@rodruiz Great suggestion, thanks! I don't work with jobs a lot so I haven't thought about that. Could make the code a lot cleaner :+1:


Overwrite message schema

Description
Using an overwritten message scheme and warning the user in this case
Fixes #1625
Type of change
Please delete options that are not relevant.

[ ] Documentation (typos, code examples, or any documentation updates)
[x] Bug fix (a non-breaking change that resolves an issue)
[ ] New feature (a non-breaking change that adds functionality)
[ ] Breaking change (a fix or feature that would disrupt existing functionality)
[ ] This change requires a documentation update

Checklist

[x] My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
[x] I have conducted a self-review of my own code
[x] My changes DO generate any new warnings
[x] I have added tests to validate the effectiveness of my fix or the functionality of my new feature
[x] Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
[x] I have ensured that static analysis tests are passing by running scripts/static-analysis.sh

@KrySeyt can you review this one, please?

В остальном LGTM


client: export OvsdbClient (but not its fields)

Allows consumers to embed the client while preserving data
encapsulation. As long as none of the members are exported
consumers can't mess around with the data, but at least can
wrap the struct with embedding.
@dave-tucker @trozet

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

33 of 37 (89.19%)  changed or added relevant lines in 3 files are covered.
159 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 73.113%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

client/monitor.go
2
3
66.67%

client/client.go
30
33
90.91%

Files with Coverage Reduction
New Missed Lines
%

client/client.go
159
66.08%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
4223

Relevant Lines:
5776

💛  - Coveralls

This allows ovnkube to break apart the Create + Start steps and pass internal info around inside the wrapping object, since the Create and Start operations may be a wildly different places in the code.
type Client struct {
	*client.OvsdbClient
	stopCh   <-chan struct{}
	monitors []client.MonitorOption
}

func newClient(cfg config.OvnAuthConfig, dbModel model.ClientDBModel, stopCh <-chan struct{}, monitors []client.MonitorOption) (*Client, error) {
	ovsdbClient, err := client.NewOVSDBClient(dbModel, options...)
	if err != nil {
		return nil, err
	}

	c := &Client{
		stopCh:      stopCh,
		monitors:    monitors,
		OvsdbClient: ovsdbClient.(*client.OvsdbClient),
	}

	return c, nil
}

// run connects the client to the database and begins processing events
func (c *Client) Run() error {
	connectCtx, connectCancel := context.WithTimeout(context.Background(), types.OVSDBTimeout)
	defer connectCancel()
	if err := c.Connect(connectCtx); err != nil {
		return err
	}

	monitorCtx, monitorCancel := context.WithTimeout(context.Background(), types.OVSDBTimeout)
	go func() {
		<-c.stopCh
		monitorCancel()
	}()

	var err error
	if len(c.monitors) > 0 {
		_, err = c.Monitor(monitorCtx, c.NewMonitor(c.monitors...))
	} else {
		_, err = c.MonitorAll(monitorCtx)
	}
	if err != nil {
		c.Close()
		return err
	}

	return nil
}

You're totally right... nevermind.


Wireguard VPP Plugin

Overview
Current limitations in VPP prevent it from integrating with wireguard. To get around these problems, we are proposing a wireguard plugin that can speak the wireguard protocol and emit wireguard encapsulated datagrams.
Link to the Google Docs document
https://docs.google.com/document/d/1ICYb2kV48l-T1qounqkUBetUAmme0znD9gl405HJ2VQ/edit#heading=h.rvc98q8enqpk

Ran ipsec between two VPP instances.
Trying to select ipsec template without encryption/decryption.

Made a plugin with simple encrypt/decrypt nodes. Trying to run it using IPIP tunnel.

Working at wireguard implementation.
In particular at crypto module and data structures (for peers, keys storing).
Wg seems to be closely related to the Linux kernel, so there are some difficulties with porting. I use wireguard-linix-compat repository.

Made a crypto module. Continue work at keys and handshake packet making.

Made a simple handshake procedure (run it manually).
Now i can also send keepalive packets (zero length message). Additionally, i sent some encrypted bytes - it works fine, the server side can correctly decrypt it.
Now i'm working at ping sending.

Ran ping via wg-plugin.
It's possible to connect two VPP instances. It seems to work correctly, i can ping each other.
Now i'm working on timers for auto key freshing and re-handshaking.

Made timers for auto key freshing and connection supporting.
Tested it on thousands ping packets. No packages were lost.
Now i'm cleaning my code and preparing draft pr.

Draft PR
https://github.com/FDio/vpp/pull/26

Made custom vpp-agent image with plugin:
https://hub.docker.com/repository/docker/artgl/vpp-agent/
https://github.com/glazychev-art/vpp-agent/tree/wg
Now i'm reworking noise-protocol based on openbsd implementation

Pushed commit to vpp repo for code review
https://gerrit.fd.io/r/c/vpp/+/28503

Wireguard plugin is contributed into vpp and vpp-agent
https://gerrit.fd.io/r/c/vpp/+/28503
https://github.com/ligato/vpp-agent/pull/1731
The next steps are:

https://github.com/networkservicemesh/networkservicemesh/issues/2105
https://github.com/networkservicemesh/networkservicemesh/issues/2105


OnShareCompleteResult : -1006

Hi,
I've checked the all posted issues and done the pre-setup (photon setup, oculus app created, user ID, user profile requested, add both accounts as the test user) but I'm still stuck on this error. Could anyone provide more info about this error code? I always got 1 correct user id and 0 from my both quest pro devices. I guess the 0 might be the reason why the sharing failed.

Hi @ddhvr. OnShareCompleteResult code -1006 is thrown when the app is not entitled.
Be sure that you:

Create an app on the Meta Quest Org Manager.
Add the app ID (found under "API" tab in the App Manager) in the Oculus Platform Settings in Unity.
Confirm that you have been granted the User ID and User Profile permissions in the App Manager under Data user Checkup.
Confirm that the test accounts (on device) are associated with the app on Meta Quest Org Manager.

Hi @stephenm2022, like I said I've done all the pre-setup in the project, but the error still exists.

Hi @ddhvr. When you enter the Anchor Sharing Demo scene, do you see a valid Oculus username and id in the UI logs?

Hi @stephenm2022 ,
At first, no. But it became valid after a few days. I guess it might need some time to be entitled.
Updated: Anchor sharing is working now but it has a noticeable difference about 10 cm off. I've tried to make both headsets as close as possible when launching. Besides, the difference could become serious when used in different places, especially in a place that has many lights and reflections. So just wondering if there's anything I can do to improve the alignment. Right now I can only guarantee that the difference would be acceptable when using both in my seat and both headsets have similar guardian areas.

Hello@stephenm2022, why is it that when I run this project scenario I have been unable to perform the functions of successfully saving local anchors, removing anchors, and aligning anchors. I can only create anchors and cubes. By the way, how to join a room?

Be sure that both users are different and logged in Oculus. If is a development app check that both users can use the app, you can use test users or add them directly as developers. Maybe that helps.

Hi @AlwaysLELE. It looks like the anchor save operations were successful; however, scene capture failed. Scene capture is only supported on the device and will fail over link.
I can also see that authentication to the Platform SDK has failed (TestUser581), which will prevent anchor sharing from working. Be sure to create a Rift app and configure the Unity project with your Rift app ID for authentication over link.


#23: Added logic, when null predicate is passed into method

Now if null predicate is passed - we return true;

Will fix this soon ;)

@rultor merge

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@dgroup Done! FYI, the full log is here (took me 2min)


when there is colums visible false,destroy the table is very slow

I create a table with some colums is not visible ,when I try to destroy the table ,It's  very slow

Thanks for your question. However, per the Contributing document please post support requests in the DataTables forums. Please also ensure that you link to a running test case showing the issue so it can be debugged.


fix: remove wrapper view from KeyboardAwareScrollView

📜 Description

💡 Motivation and Context
Additional view:

breaks styling in some cases
stickyHeaderIndices={[0]} produces a crash (because RN will try to attach Animated-based style to REA view)

📢 Changelog

JS

iOS

Android

🤔 How Has This Been Tested?

📸 Screenshots (if appropriate):

📝 Checklist

[ ] CI successfully passed

For history purposes I'm attaching pixel diff (it seems like it under/over-scrolls 1px, what can be ignored):

I opened an issue for Fabric problem in REA repository: https://github.com/software-mansion/react-native-reanimated/issues/5567


CAMEL-17792: Add documentation about the message headers (P-Q)

https://issues.apache.org/jira/browse/CAMEL-17792
Motivation
It is now possible to document a message header using annotations, let's leverage it to document the headers of the components.
Modifications
For all the components whose name starts with a P or Q

Document the messages headers using the annotations
Migrate the existing documentation of message headers to use the annotations instead
In case of common headers class for several endpoint, replace the scheme of each endpoint with a constant to facilitate usage of the element applicableFor
Move constants corresponding to headers to the headers class.

You are getting closer to Z ;)


setup globarTr once per bundle and only if needed

This PR optimizes the globals transform by:

Only adding it to the pipeline if it hasn't been opted-out of. This check was previously in the transform itself.
Only setting up the options for insertGlobals once per bundle(), instead of once for every file.

cc: @jmm

So there's no legit case for opts changing between globalTr() calls right? If so, LGTM. A few things that I noticed while looking at this:

If there's going to be a new method (_createGlobalTr) I'd be tempted to put all of the logic in that method. In other words move this part into it.

debug: opts.debug, seems superfluous? (I know it was already like this.)

Assigning mopts.globalTransform = []; seems superfluous? (I know it was already like this.)

module-deps opts.globalTransform should be documented.

So there's no legit case for opts changing between globalTr() calls right?

You know, this is weird. I've always considered a browserify instance "sealed" once you call bundle for the first time. Technically, you can always add more requires, excludes, ignores, transforms, etc. (the entry order would get messed up). However, even before this change, opts was always the same copy globalTr had in scope when it was first created - so even if you added more opts, it never saw them. But if you mutated noParse, it would see that change since that array would be available by reference. But yes, no legit case.

If there's going to be a new method (_createGlobalTr) I'd be tempted to put all of the logic in that method. In other words move this part into it.

I undid that. It doesn't follow the general code structure. There is not reason for _createGlobalTr to be a method on b since it doesn't need this. If I move the logic you suggested, then that method wouldn't return anything useful, and that would be a first in the code. Public methods return this so you can chain (minus bundle and reset), and the private methods return streams (most, if not all).

debug: opts.debug, seems superfluous?

good catch!

Assigning mopts.globalTransform = []; seems superfluous?

I think that's so you don't use opts.globalTransform to pass transforms to module-deps. That's something to figure out later.

module-deps opts.globalTransform should be documented.

I've got another idea :smile:


Some interface improvement suggestions

Suggestions:

Remove the NS1 and NS2 fields from servers, it is totally irrelevant.
Replace the NS1 and NS2 fields on domains with a textbox called "Nameservers:", which auto-populates with a ns-query for the domain in question.
Move the "Delete data" and "No longer have" switches to the bottom of the card.
Add a "Update and close" button after editing something.
Make it accept "0" as unlimited bandwidth. Right now you can add a server with 0 as bandwidth, but if you try to edit it later it will not accept a 0 in that field.

I actually like all of these suggestions and have one of my own to add.
How about adding a notes field that the user can use for any random note?
For me actually, I want to add the Webmin URL of each server, but realize that not many care to have a Webmin URL field, but a general notes field would make sense, no?


CUDA environment is broken when I run a docker container with rocker

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
When I run a docker container built on this repository with rocker, nvidia-smi and CUDA packages of autoware.universe didn't work.
Expected behavior
$ rocker --nvidia --x11 --user ghcr.io/autowarefoundation/autoware-universe:humble-latest nvidia-smi

returns the same result as
docker run --rm -it --gpus all -e DISPLAY -e TERM -e QT_X11_NO_MITSHM=1 -v /tmp/.X11-unix:/tmp/.X11-unix -v /etc/localtime:/etc/localtime:ro ghcr.io/autowarefoundation/autoware-universe:humble-latest

Actual behavior
$ rocker --nvidia --x11 --user --volume $PWD:$HOME/autoware -- ghcr.io/autowarefoundation/autoware-universe:humble-latest nvidia-smi
...
bash: nvidia-smi: command not found

or
# in the docker container
$ ros2 launch lidar_centerpoint lidar_centerpoint.launch.xml
[INFO] [launch]: All log files can be found below /home/yusuke/.ros/log/2022-05-27-18-24-13-889706-yusuke-desktop-14888
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [lidar_centerpoint_node-1]: process started with pid [14889]
[lidar_centerpoint_node-1] terminate called after throwing an instance of 'thrust::system::detail::bad_alloc'
[lidar_centerpoint_node-1]   what():  std::bad_alloc: cudaErrorInsufficientDriver: CUDA driver version is insufficient for CUDA runtime version
[ERROR] [lidar_centerpoint_node-1]: process has died [pid 14889, exit code -6, cmd '/home/yusuke/autoware/install/lidar_centerpoint/lib/lidar_centerpoint/lidar_centerpoint_node --ros-args -r __node:=lidar_centerpoint --params-file /tmp/launch_params__7bviznb --params-file /tmp/launch_params_xhbpo0pj --params-file /tmp/launch_params_3cva1bu7 --params-file /tmp/launch_params_591wukuf --params-file /tmp/launch_params_binyjp_2 --params-file /tmp/launch_params_d_ubfmz8 --params-file /tmp/launch_params_3ciwtkcg --params-file /tmp/launch_params_cy1qmkld --params-file /home/yusuke/autoware/install/lidar_centerpoint/share/lidar_centerpoint/config/default.param.yaml -r ~/input/pointcloud:=/sensing/lidar/pointcloud -r ~/output/objects:=objects'].

Steps to reproduce

build a docker image in docker directory
run a docker container with rocker
nvidia-smi

Versions
No response
Possible causes
No response
Additional context
No response

I've also met the same problem. I'm using rocker --nvidia --x11 --user --volume $HOME/autoware -- ghcr.io/autowarefoundation/autoware-universe:latest.

I have the problem with rocker --nvidia --x11 --user --volume $HOME/autoware -- ghcr.io/autowarefoundation/autoware-universe:galactic-latest but not with rocker --nvidia --x11 --user --volume $HOME/autoware -- ghcr.io/autowarefoundation/autoware-universe:latest

but not with rocker --nvidia --x11 --user --volume $HOME/autoware -- ghcr.io/autowarefoundation/autoware-universe:latest

@VRichardJP Could you tell me the hash of your images like this? I guess one is old (and based on CUDA image).
$ docker images | grep autoware-universe | grep " latest "
ghcr.io/autowarefoundation/autoware-universe                                          latest                                                                       5fdadcabfe9c   5 weeks ago     5.73GB

Yes indeed, my latest is older than galactic-latest:

docker run --rm -it --gpus all -e DISPLAY -e TERM -e QT_X11_NO_MITSHM=1 -v /tmp/.X11-unix:/tmp/.X11-unix -v /etc/localtime:/etc/localtime:ro -v $HOME/adehome:/home/adehome [ghcr.io/autowarefoundation/autoware-universe:humble-latest](http://ghcr.io/autowarefoundation/autoware-universe:humble-latest)
Using docker instead of rocker does not solve the problem. CUDA, TensorRT, and cuDNN could not be found.

@angry-crab humble-latest doesn't contain CUDA now. Please use humble-latest-cuda instead.
https://github.com/autowarefoundation/autoware/pkgs/container/autoware-universe/26944787?tag=humble-latest-cuda

Sent a PR: https://github.com/osrf/rocker/pull/182
If it's not accepted, I'll add the following block in the Dockerfile.

## Set env for nvidia-container-runtime
ENV NVIDIA_VISIBLE_DEVICES all
ENV NVIDIA_DRIVER_CAPABILITIES compute,utility

@yukke42 My PR to rocker is merged. Do you think we can close this issue?
We can set NVIDIA_DRIVER_CAPABILITIES manually until the new rocker is released.

@kenji-miyake
I'm sorry for the late replay. AND thank you for identifying the cause of this issue!
I will close this issue after creating a PR to do your suggestion.

@.kenji-miyake I'm sorry for the late replay. AND thank you for identifying the cause of this issue! I will close this issue after creating a PR to add your suggestion into the document.

I will do after this related issue is closed.

Resolved by #2732


Import Issues

Not importing all services, phone not importing at all

9900 locations - at max?

Fix with changes to upstream


Track remote changes from upstream

I'd like to konw if these changes was proposed at the base of this fork: chrisboulton/php-resque, since it could be a lot easier to leverage the evolution of that library without the overhead of tracking the changes. Further when these changes are very slight.

Looks like it might be better to move to using https://github.com/resque/php-resque - not sure I have any unique changes here other than the name in packagist and probably a version mismatch

I agree @mcfedr, please let me know if you need some help with this.
Thank you in advance.


Can not build container image with extra components for windowsservercore-ltsc2019 fails but not for windowsservercore-ltsc2022

Describe the Bug
A github actions build fails for windowsservercore-ltsc2019 by installing some extra components
as you can see here:
https://github.com/bleissem/dotnet-framework-docker/actions/runs/1517979523
build definition:
https://github.com/bleissem/dotnet-framework-docker/blob/main/.github/workflows/windows2019.yml
dockerfile:
https://github.com/bleissem/dotnet-framework-docker/blob/main/src/sdk/4.8/windowsservercore-ltsc2019/Dockerfile
By using the windowsservercore-ltsc2022 dockerfile the build does not fail
as you can see here:
https://github.com/bleissem/dotnet-framework-docker/actions/runs/1517979519
build definition:
https://github.com/bleissem/dotnet-framework-docker/blob/main/.github/workflows/windows2022.yml
dockerfile:
https://github.com/bleissem/dotnet-framework-docker/blob/main/src/sdk/4.8/windowsservercore-ltsc2022/Dockerfile

Steps to Reproduce
may run build again with the fork
https://github.com/bleissem/dotnet-framework-docker
or use the extra component id's:
# https://docs.microsoft.com/de-de/visualstudio/install/workload-component-id-vs-build-tools?view=vs-2022
    --add Microsoft.Component.MSBuild;includeRecommended ^ `
    --add Microsoft.VisualStudio.Workload.DataBuildTools;includeRecommended ^ `
    --add Microsoft.VisualStudio.Workload.NetCoreBuildTools;includeRecommended ^ `
    --add Microsoft.VisualStudio.Component.TestTools.BuildTools;includeRecommended ^ `
    --add Microsoft.VisualStudio.Workload.WebBuildTools;includeRecommended ^ `
    --add Microsoft.VisualStudio.Workload.VisualStudioExtensionBuildTools;includeRecommended ^ `
    --add Microsoft.VisualStudio.Workload.ManagedDesktopBuildTools;includeRecommended ^ `
# https://docs.microsoft.com/de-de/visualstudio/install/workload-component-id-vs-community?view=vs-2022
    --add Microsoft.VisualStudio.Workload.NetWeb;inlcudeOptional ^ `
    --add Microsoft.VisualStudio.Component.Git ^ `

for building
https://github.com/microsoft/dotnet-framework-docker/blob/main/src/sdk/4.8/windowsservercore-ltsc2019/Dockerfile

Other Information

Output of docker version

Output of docker info

The error is coming from the ngen update command. After digging into that command, I saw this in the output:
Failed to compile C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer\TF.exe because this image is a 64bit assembly; try using 64bit ngen instead.

So the problem is that the VS Build Tools registered the TF.exe, a 64-bit file, to be queued for the 32-bit version of ngen. This is clearly a bug and is likely the result of the migration to 64-bit for VS proper. I'll let the VS team know about this.
Why this only happens for Server 2019 and not Server 2022, I haven't dug into that yet.
To work around this, you can unregister the file to prevent the attempt to ngen it when running ngen update. Just add this command before running ngen update:
%windir%\Microsoft.NET\Framework\v4.0.30319\ngen uninstall "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer\TF.exe"

For tracking purposes, this is the link to the internal bug I logged for VS: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1444002/

Also, be aware that the Microsoft.VisualStudio.Workload.NetCoreBuildTools component no longer exists in the VS 2022 Build Tools installer. This is referenced in your Dockerfiles and it ends up being ignored with a warning in the installer log file that it doesn't exist.
Can I ask why you are recreating the entire SDK Dockerfile and adding the extra VS components rather than base it on the SDK image and only install the extra VS components you require?

Hello @mthalman , thanks for looking into this.
About your question: "Can I ask why you are recreating the entire SDK Dockerfile and adding the extra VS components rather than base it on the SDK image and only install the extra VS components you require?"
Well it would be indeed logical to do so.
Because the vs_BuildTools.exe  is deleted in the original Dockerfile it somehow has to be downloaded again to rerun the setup.
And because there are comments like "Workaround " in the Dockerfile I thought that to would be better to use the original Dockerfile as a blueprint to avoid errors etc. that I'm not aware of.
Also using the original Dockerfile as a blueprint enables me to ask for some kind of support. ( This issue can also be regarded as asking for support.)
It would be nice if  a docker image can be provided which is capable of running the  vs_BuildTools.exe to install additional components if needed.
Regards
Alex B.

Acquiring vs_BuildTools.exe is pretty simple when using the aka.ms link. We have documentation for doing this scenario of including additional components to the VS Build Tools installation on top of the sdk image. Check that out.

Hello @mthalman , thanks for providing the documentation link. Just because I'm curious to know, why is there a difference between the dockerfile that is provided in the documentation and the dockerfile that you use for
https://github.com/microsoft/dotnet-framework-docker/blob/main/src/sdk/4.8/windowsservercore-ltsc2019/Dockerfile
( for example the lines with # Workaround for issues with 64-bit ngen ) ?
Regards
Alex B.

The ngen workaround only needs to be once. Since the Dockerfile used in the documentation is based on the sdk image, it already has the workaround applied.

Triage: Closing per the guidance on working around the ngen issue. Feel free to respond with further questions on making use of the base sdk image.


fix: Exists delaborator merging

The binder merging feature of the delaborator was matching too much and creating ill-formed terms like ∃ (_ : True) x, True.

bors delegate+

bors r+


Multipolygon.clone() is incomplete: Modifying the clone affects the original

Multipolygon.clone() currently doesnt clone the endss field, which is a nested array.
Consequence: Clones are not completly decoupled, but changing the clone also modifies the original.
Please perform a "deep clone" of the endss fields, rather than a flat slice() on the endss-array.
Current implementation:
ol.geom.MultiPolygon.prototype.clone = function() {
  var multiPolygon = new ol.geom.MultiPolygon(null);
  multiPolygon.setFlatCoordinates(
      this.layout, this.flatCoordinates.slice(), this.endss_.slice());
  return multiPolygon;
};

I have prepared a method that does a deep clone of nested arrays, but I am not sure where to place it. So far, it is in the MultiPolygon class, but I had in mind some place where it could be accessible by other classes, if needed - maybe ol.Object?
I was also considering improving the method so that it could do a deep clone of both arrays and objects (and arrays of objects etc.). Any thoughts?
P.S. the commit can be seen here https://github.com/Kenny806/ol3/commit/e15e914cade354e211de2369af8213c8dff963ba . I don't want to make a pull request yet, as I think the cloning method should be in a different class.

Maybe you could use goog.object.unsafeClone instead?
http://docs.closure-library.googlecode.com/git/namespace_goog_object.html#goog.object.unsafeClone

Thanks, that sounds much better. I was looking for a deep clone in goog.array, didn't think of looking in goog.object (here's to reinventing the wheel). Anyway, I updated my commit to make it use goog.object.unsafeClone, see https://github.com/Kenny806/ol3/commit/06436b3217cb2abec83031ea77fd42aa98a27dcf

Created a PR: https://github.com/openlayers/ol3/pull/3359

Fixed with #3359.


Finish title scroll

Is your feature request related to a problem? Please describe.
I started to implement a wall of text that slowly scrolls before you get to the main menu screen, kind of like the start of Star Wars movies. It automatically goes to the menu when done, or if any mouse or keyboard button is clicked. However, there are 3 main issues right now:

[x] the UI doesn't scale when you resize the window to different shapes
[x] the font is too large
[x] the text itself is not finished!

Additional context
To solve these issues, you will need to read the following resources:

https://docs.godotengine.org/en/stable/tutorials/ui/index.html
https://docs.godotengine.org/en/stable/tutorials/ui/gui_skinning.html

For the text itself, it should be a short background story about Shirley calling together the tournament that the game represents. Have it include some background lore and funny RPI stuff and you're good! Feel free to ask everyone for assistance.
Make sure you work on the title_scroll branch instead of master: git checkout title_scroll && git pull origin title_scroll. You don't have to make another branch for this.

Title scroll is done and working now :)


enhancement: disable printer sharing

Printer sharing should be disabled -- computers can connect to their own damn printer.
osxlockdown checks with this command: if [ -n "$(system_profiler SPPrintersDataType | grep Shared | grep Yes)" ]; then exit 1; fi; exit 0
This will tell you if one of your printers is currently being shared, but not whether printer sharing has been enabled as a service.
Here's the output from system_profiler if you have no printers currently added but have enabled printer sharing as a service:
$ system_profiler SPPrintersDataType
Printers:

      Status: The printers list is empty. To add printers, choose Apple menu > System Preferences…, click Printers & Scanners, and then click Add (+).
      CUPS Version: x.x.x (cups-xxxx.xxxx)

No useful info there.
Here's what it looks like if you have printer sharing enabled, but have not shared the single printer you've added to your system's list:
$ system_profiler SPPrintersDataType
Printers:

    My Fancy Printer X9001:

      Status: Idle
      Print Server: Local
      ...
      System Printer Sharing: Yes
      Shared: No

The fix for both is the same, borrowed from osxlockdown: cupsctl --no-share-printers
So the only thing I'm doing differently here is checking both for the service being active and whether printers are being shared, rather than just the latter. This will be condensed into one command.

Satisfied by: https://github.com/kristovatlas/osx-config-check/commit/315acfc633f2632fa1b62d94daf18d44811152c9


Core dump error occured with some Caffe models

OS: CentOS7.4
Kernel: 3.10.0-693.el7
Caffe version: https://github.com/BVLC/caffe.git rc3
Python version: 2.7.5
AccDNN version: git commit with 9520ecd844448089e8b972718a0791936460a9d1
Vivado version: 2017.4
Problem description:
When using codegen.py to generate verilog code with caffe model, core dump error occured.
With the caffe model in example/alexnet, error messages like follows:
[libprotobuf ERROR google/protobuf/text_format.cc:245] Error parsing text-format caffe.NetParameter: 6:15: Message type "caffe.LayerParameter" has no field named "input_param".
WARNING: Logging before InitGoogleLogging() is written to STDERR
F1008 13:29:24.524755 20949 upgrade_proto.cpp:68] Check failed: ReadProtoFromTextFile(param_file, param) Failed to parse NetParameter file: deploy.prototxt
*** Check failure stack trace: ***
Aborted (core dumped)
And with the model in example/cifar10-quantized, the follows is the error informations:
[libprotobuf ERROR google/protobuf/text_format.cc:245] Error parsing text-format caffe.NetParameter: 26:22: Message type "caffe.LayerParameter" has no field named "quantization_param".
WARNING: Logging before InitGoogleLogging() is written to STDERR
F1008 13:32:43.952024 21338 upgrade_proto.cpp:68] Check failed: ReadProtoFromTextFile(param_file, param) Failed to parse NetParameter file: quantized_A16C8F4.prototxt
*** Check failure stack trace: ***
Aborted (core dumped)
I wondered is the version diffrences of Caffe cause the above? And how can i reslove these problem?
Thanks!

The official BVLC caffe version only support un-quantized model, which will use default quantization. For quantized model, please use https://github.com/pmgysel/caffe. To avoid any issue, please install ristretto Caffe.

Thanks for your reply. While, i try to use ristretto Caffe to convert the example/alexnet, the error aboved also occured:
[libprotobuf ERROR google/protobuf/text_format.cc:245] Error parsing text-format caffe.NetParameter: 6:15: Message type "caffe.LayerParameter" has no field named "input_param".
WARNING: Logging before InitGoogleLogging() is written to STDERR
F1008 15:30:25.813431  7127 upgrade_proto.cpp:68] Check failed: ReadProtoFromTextFile(param_file, param) Failed to parse NetParameter file: deploy.prototxt
*** Check failure stack trace: ***
Aborted (core dumped)
The caffe version: https://github.com/pmgysel/caffe.git with tag rc3
My command like follows:
python codegen.py example/alexnet/deploy.prototxt example/alexnet/caffe_alexnet_train_iter_450000.caffemodel --optim_file example/alexnet/optim_alexnet.conf --batch_size 1
Thanks for your help.

rc3 is still the old version from BVLC, there is no definition of "input_param" in LayerParameter .
https://github.com/pmgysel/caffe/blob/rc3/src/caffe/proto/caffe.proto#L310
Please use the master branch, it should have the definition of "input_param" in LayerParameter.
https://github.com/pmgysel/caffe/blob/master/src/caffe/proto/caffe.proto#L327

Problem resloved. Thanks.


Europe PMC dataset parameter fulltext removed

Please be aware that Europe PMC has recently removed the dataset parameter which Lagotto uses to search Europe PMC.

Thank you. It should therefore be http://www.ebi.ac.uk/europepmc/webservices/rest/search/query=https://github.com/najoshi/sickle&format=json&resultType=lite instead of http://www.ebi.ac.uk/europepmc/webservices/rest/search/query=https://github.com/najoshi/sickle&dataset=fulltext&format=json&resultType=lite. It seems that the dataset parameter is simply ignored.
Here is the documentation: http://europepmc.org/restfulwebservice#search


CPU Profiler

https://github.com/Cryptographic-API-Services/cas-dotnet-sdk/issues/69
This needs to be provided to the cas-core-lib so the framework can call to get this information.

Closing due to a different implementation.


Integrate arXlive-search

Currently has its own flask app to serve the react site but needs to be integrated into arXlive.
There are a number of challenges to the deployment that need solving with a script:

[x] the generated index file needs to be replaced with a static once containing jinja pointing to the static files on s3
[x] a script for flask_s3 to run .create_all() and send the static files to s3
[x] fix the broken metadata on the CSS files sent to s3
[x] remove the generated .map files from the static folder
[x] rename the .css and .js files as the are currently named from a hash and subject to change
[x] integrate starting the venv and triggering zappa update dev
[x] exclude the css from updating as it is manually tweaked to show the title bar

remaining tasks added as new issues, creating PR now


assert does not accept arguments of type Function other than literals

This issue was originally filed by @chalin

Language spec entry for assert reads:
The conditional expression e is evaluated to an object o. If the class of o is a subtype of Function then let r be the result of invoking o with no arguments. Otherwise, let r be o.  It is a dynamic type error if o is not of type bool or of type Function, or if r is not of type bool.
All the asserts in the sample code given below should succeed, but only the first does. Note that issue #17228 is related but distinct from the issue reported here.
https://code.google.com/p/dart/issues/detail?id=17228

class MyFunc extends Function { bool call() => true; }
void main() {
  assert(() => true); // ok

  var x = () => true;
  assert(x); // type '() => bool' is not a subtype of type 'bool' of 'boolean expression'.
  bool f() => true;
  assert(f); // type '() => bool' is not a subtype of type 'bool' of 'boolean expression'.
  var mf = new MyFunc();
  assert(mf); // type '() => bool' is not a subtype of type 'bool' of 'boolean expression'.
}

I just hit this bug again while testing something related.


Bump to ruby 2.5.0

Fixes: #6774

Probably wanna turn on 2.5 in AV too since they have the image now

appveyor looks busted for real-looking ruby 2.5 reasons?  certainly the Chef::Exception error looks like another class namespacing issue.

it's a christmas miracle!  appveyor is passing!
omnibus builds are super-hosed tho.

@chef/client-maintainers this is ready to go


build: migrate latest json language service implementation

Align with new features introduced in https://github.com/Microsoft/vscode-json-languageservice.
TODOS:

[ ] Auto completion does not really work for provided JSON schemas.

@JPinkney I did some migration to make the new features introduced in https://github.com/Microsoft/vscode-json-languageservice to this repo.
Some outstanding updates including:

fixes missing ts types in RH's yaml-languageserver
findDocumentSymbols now returns better symbol paths (array items now returns indexes)
https://github.com/Microsoft/vscode-json-languageservice/blob/master/CHANGELOG.md


Make undoable objects report and interpret blocks of changes as an actual block.

...instead of an array of individual changes.

This appears to work correctly.


Fix: do not increase Dashboard token count when Ether balance is 0

What it solves
Resolves https://github.com/safe-global/safe-react/issues/3840
How this PR fixes it
Do not include in Safe token count tokens with 0 balance
How to test it

Open the Dashboard for a Safe containing some Ether and other tokens and observe that Ether counts as a token in Dashboard Overview widget
Open the Dashboard for a Safe containing 0 Ether but other tokens and observe that the Dashboard Overview widget does not count Ether

Screenshots
Balances

Dashboard

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.003%) to 35.355%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/Dashboard/Overview/Overview.tsx
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/components/Dashboard/Overview/Overview.tsx
1
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
3601

Relevant Lines:
9245

💛  - Coveralls

Looks good to me
The counter only counts the base currency only if it has funds
I drained a safe completely to  check that the counter is set to 0 after it.


Add Makefile for build system

Simple makefile to allow building on the build system for multiple arch.
it builds a shared/static lib as well as install target.
LIBPATH is lib/i686 lib64/x86_64 libx32/i686 on the distro.
PREFIX may be better suited as /usr/local for historic reasons.
Thank you.

I suggest this so same Makefile can replace the linux.sh and mac.sh:
diff --git a/Makefile b/Makefile
index f389e9c..79e2eb5 100644
--- a/Makefile
+++ b/Makefile
@@ -1,9 +1,19 @@
 PREFIX = /usr
 LIBPATH = /lib
-CXX = g++
 AR = ar
 RANLIB = ranlib
-CXXFLAGS = -std=c++11 -Wall -DGUID_LIBUUID -fPIC
+CXXFLAGS = -std=c++11 -Wall -fPIC
+
+PLATFORM = $(shell uname -s)
+ifeq ($(PLATFORM),Darwin)
+CXX ?= clang++
+CXXFLAGS += -DGUID_CFUUID
+LIBS = -framework CoreFoundation
+else
+CXX ?= g++
+CXXFLAGS += -DGUID_LIBUUID
+LIBS = -luuid
+endif

 INSTALL = install
 PREFIX = /usr
@@ -22,11 +32,11 @@ install: all
        $(INSTALL) -D guid.h $(DESTDIR)$(INCDIR)/guid.h

 test: test.o testmain.o libcrossguid.a
-       $(CXX) $(CXXFLAGS) $^ -o $@ -L=$(LIBPATH) -luuid
+       $(CXX) $(CXXFLAGS) $^ -o $@ $(LIBS)
        ./test

 libcrossguid.so: guid.o
-       $(CXX) -shared -o $@ $<
+       $(CXX) -shared -o $@ $< $(LIBS)

 libcrossguid.a: guid.o
        $(AR) rc $@ $^

I have tested on both linux and mac.

Thanks for the suggestions! I am about to rejig the project and include a cmake file so that a makefile can be auto generated (and I don't want many types of build files in the repo).


(Enhancement) Ignore particular lines

Could you add an option to have this VSCode extension ignore particular lines?  For example, any line that includes "/* csstree-ignore-line */".
I have some code in my CSS for older browsers (e.g. -webkit-margin-before:, -webkit-margin-after:, width: -webkit-fill-available, width: -moz-available, and width: fill-available), which are reported as errors, and I'd rather have an empty "Problems" window in VSCode.  Giving me a way to have your extension not report those lines as errors would really be appreciated.
Thank you, and thank you for the VSCode extension.  :smiley:

I'd also like to be able to do this. In my case to silence a validator error when using font-display.
@font-face {
  font-display: swap;
}

Any update on this?

Any update on this?

Issue with font-display is not an issue anymore, since plugin validates at-rule's declarations based on a dictionary for at-rules now.
I believe that comments is not a good approach to disable validation.
Options we have:

Use stylelint + VS Code stylelint plugin + stylelint CSSTree plugin. In this case you may tweak syntax dictionary and use other options to fix warning. I see this approach as a better choice for now, since stylelint + CSSTree plugin may be used on CI as well.
Extend syntax dictionary in CSSTree (patch for mdn-data) or in mdn-data, and wait for merge/release and this plugin update. I may take some time, but will be helpful for others who use such properties (syntax dictionaries are incomplete currently), so that's good for a dev community.
Add some settings to this plugin. However, I'm not sure it will satisfy user's needs and looks a bit complicated for users.

Issue with font-display is not an issue anymore, since plugin validates at-rule's declarations based on a dictionary for at-rules now.
I believe that comments is not a good approach to disable validation.
Options we have:

Use stylelint + VS Code stylelint plugin + stylelint CSSTree plugin. In this case you may tweak syntax dictionary and use other options to fix warning. I see this approach as a better choice for now, since stylelint + CSSTree plugin may be used on CI as well.
Extend syntax dictionary in CSSTree (patch for mdn-data) or in mdn-data, and wait for merge/release and this plugin update. I may take some time, but will be helpful for others who use such properties (syntax dictionaries are incomplete currently), so that's good for a dev community.
Add some settings to this plugin. However, I'm not sure it will satisfy user's needs and looks a bit complicated for users.

The 'csstree-ignore-line' comment would be a great way to handle this. It's flexible, easy to understand and apply, and wouldn't require any configuration changes.


[8.x] Minor improvements to validation assertions API

This makes a couple of minor improvements to the new validation assertions API:

assertInvalid can now take no error arguments (like assertInvalid) so you can generically assert that there are errors - assertInvalid()
The errors are passed through Arr::wrap (like assertValid) so that you can just pass a single key - assertInvalid('email')

That failing test on 7.3 doesn't look related, hopefully a re-run clears it up.

Please update PHPDoc too for static analysis tools: @param  array|string  $errors.


Update device_model.py

Pull Request summary:
Added a new DeviceModel enum: C8300-1N1S-4T2X
Checklist:

[x] Make sure to run pre-commit before commiting changes
[x] Make sure all checks have passed
[x] PR description is clear and comprehensive
[x] Mentioned the issue that this PR solves (if applicable)
[x] Make sure you test the changes

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/301


HIVE-25260: Provide tableId for AllocWriteIdEvent

What changes were proposed in this pull request?

Check if the table exists for allocating write ids. If the table doesn't exist, a MetaException will be thrown.
Add tableId to JSONAllocWriteIdMessage

Why are the changes needed?

For event-base table refreshing in external cache, we need table id to check if we update a correct table.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Added a test in TestHiveMetaStoreTxns

@aasha Could you review the patch if you have a chance? Thanks.


Merge PS2 Ambience music pack

PS2 Ambience
Insert a link to the GitHub repository of the pack.
https://github.com/superfluid-cs/Steam-Deck-AudioLoader
Requirements Agreement
Failure to check the box below by writing an X between the brackets will result in the closing of your pull request. Please write any comments regarding issues with the requirements below.

[X] I have read the pack requirements. I understand that if my pull request does not meet them, it will be closed and I may be banned from the pack database.

Patched after failing build check


end_of_stream error on read()

Version of Beast is 150.
My code is here: https://gist.github.com/DragonOsman/9a7d4ee116efc575dece7d6de46bd31d .  Program output is:
POST body example: -----------------------------7e21565302ae
Content-Disposition: form-data; name="currency_amount"

125.00
-----------------------------7e21565302ae
Content-Disposition: form-data; name="to_currency"

PKR
-----------------------------7e21565302ae--

parsed_value map:
currency_amount: 125.00
to_currency: PKR
Line 477: to_currency is: PKR
Message in ec is: end of stream
message body received is:
Line 671: Error: [json.exception.parse_error.101] parse error at 1: syntax error - unexpected end of input; expected '[', '{', or a literal

My compiler is MSVC (latest version on Visual Studio 2017 IDE).  OS is Windows 10.
I saw on the Beast documentation that an eof can cause an end_of_stream error.  I also saw in the description of the error itself that it can be caused by either no new octets having been read before the eof character was encountered or when the semantics of the message indicate that the connection should be closed to indicate the end of the message.
How do I tell if my problem is because of eof or not?  It's possible that the reason for this is related to the error from the JSON library whose message is printed on Line 671, though.  I've asked about that on the JSON library's GitHub page.  And of course, this is not a bug report.

Actually, I think this is a bug in the documentation. write and async_write used to return the end_of_stream error to inform the caller that the connection should be closed, but that is no longer the case (since it interfered with other things). Now, you should just check the return value of  message::keep_alive() after sending a message. So end_of_stream always means that the remote host closed the connection. I will mark this issue as a documentation bug, thanks!

Thanks for the reply and clarification.
Does that also apply to read as well, since that's the function returning the error in my code?
So the host closed the connection?  But I added the call res.keep_alive(true); on line 654, didn't I?  Why didn't that do anything?  What else do I need to do to fix the error?

I have no idea why the host closed the connection. Keep-Alive is only a suggestion, peers are free to ignore (and often do).

I changed APIs, and now the request seems to be sent successfully, but I could still making a mistake since for some reason, the request isn't being made correctly (from what I can make of the situation).
The URL I'm trying to make the request to is (I'm substitute the access key dummy text here):
http://apilayer.net/api/live?access_key=ACCESS_KEY&currencies=PKR
The code where I'm making the request is:
std::string host{ "apilayer.net" }, api_endpoint{ "/api/live" },
	access_key{ "ACCESS_KEY" }, currencies_param{ query_data },
	target = api_endpoint + "?access_key=" + access_key + "&currencies=" + currencies_param,
	port{ "80" };
int version = 11;
std::cout << "Debug (Line 631): currencies_param=" << currencies_param << '\n'
	<< "URL is http://" << host + target << '\n';

// This object and the TCP socket perform our IO
tcp::resolver resolver{ m_ioc };

// Look up the domain name
const auto results = resolver.resolve(host, port);

// Make the connection on the IP address we get from a lookup
boost::asio::connect(m_socket, results.begin(), results.end());

// Set up an HTTP GET request message
http::request<http::string_body> req{ http::verb::get, target, version };
req.set(http::field::host, host);
req.set(http::field::user_agent, BOOST_BEAST_VERSION_STRING);

// Send the HTTP request to the remote host
http::write(m_socket, req);

Is there something I'm doing wrong here?  If so, what?  Please help me out.  Thanks in advance.


How to show full-size image instead of downloading it?

I have a model:
class Image < ActiveRecord::Base
  include Rails.application.routes.url_helpers
  belongs_to :adv

  dragonfly_accessor :content do
    copy_to(:thumb){|a| a.thumb('145x110#') }
  end

  dragonfly_accessor :thumb
end

But if I provide direct links to an image:
link_to("image", image.content.url)

It just starts to download it. How can I make it to show in browser window?

Ok, I have found an issue. I'm using single model for a multiple image upload. Looks like dragonfly doesn't work well in this case.
Controller:
@article = Article.new(article_params)
params[:article][:images].each do |image|
  @article.images << Attachment.create(original: image.tempfile, original_name: image.original_filename)
end

Models:
class Attachment < ActiveRecord::Base
  belongs_to :attachable, polymorphic: true
  dragonfly_accessor :original
end

class Article < ActiveRecord::Base
  has_many :images, as: :attachable, class_name: "Attachment", dependent: :destroy
end

View:
<%= f.file_field :images, :multiple => true %>

@Vizakenjack It can support multiple uploads with no problems. I've written a tutorial about that some time ago: http://www.sitepoint.com/asynchronous-file-uploads-rails/ Hope that helps

thanks @bodrovis


Ordering in Grouping panel not applied after refresh

System information:

Operating system: Windows 10
DBeaver version: <IP_ADDRESS>910191000
Additional extensions: None

Connection specification:

Database name and version: Oracle 12c
Driver name: Oracle
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing:
Ordering in Grouping panel is not applied after refreshing data in table.
Here is how it looks when I set ordering manually:

And here is how it looks just after refreshing table data (not grouping panel):

Notice that ordering indicator is still shown.
Steps to reproduce

Open some table
Set some grouping columns
Sort by some column in Grouping panel
Refresh table data (not data in grouping panel)

Thanks for the bug report.
Fixed

verified


Struggling With Autograd

Hey all, congrats on a fantastic paper. I'm trying out some of the scripts included here, but I'm struggling to get autograd to work (for gradient/Hessian)...
Here is my minimal reproducible example, using water as a test case:
import torch
import numpy as np

model_name = "models/aimnet2_wb97m-d3_ens.jpt"
#model_name = "models/aimnet2_b973c_ens.jpt"

device = 'cuda' if torch.cuda.is_available() else 'cpu'
model = torch.jit.load(model_name, map_location=device)

input_atomic_numbers = [8, 1, 1]
input_coord = [
    [ 0.0000,  0.0000,  0.1178],
    [ 0.0000,  0.7555, -0.4712],
    [ 0.0000, -0.7555, -0.4712],
]
input_charge = 0

numbers = torch.as_tensor([input_atomic_numbers], device=device)
coord = torch.as_tensor(input_coord, dtype=torch.float, device=device).view(1, numbers.shape[1], 3)
charge = torch.as_tensor([input_charge], dtype=torch.float, device=device)
_in = dict(coord=coord, numbers=numbers, charge=charge)

with torch.jit.optimized_execution(False):
    _in['coord'].requires_grad_(True)
    _out = model(_in)
    e = _out['energy']
    f = torch.autograd.grad(e, _in['coord'])[0]

print(e)
print(f)

Energy works fine, but I get the following error for torch.autograd.grad():
Traceback (most recent call last):
  File "/Users/cwagen/.../example.py", line 27, in <module>
    f = torch.autograd.grad(e, _in['coord'])[0]
  File "/opt/miniconda3/envs/aimnet2_pytorch200/lib/python3.10/site-packages/torch/autograd/__init__.py", line 303, in grad
    return Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
RuntimeError: element 0 of tensors does not require grad and does not have a grad_fn

This is confusing, because when I print _in before the energy call, it seems to require grad...
{'coord': tensor([[[ 0.0000,  0.0000,  0.1178],
         [ 0.0000,  0.7555, -0.4712],
         [ 0.0000, -0.7555, -0.4712]]], requires_grad=True), 'numbers': tensor([[8, 1, 1]]), 'charge': tensor([0.])}

Here's the result of conda list - I also tried the latest version of Pytorch w/ Python 3.11 and I got the same error:
# packages in environment at /opt/miniconda3/envs/aimnet2_pytorch200:
#
# Name                    Version                   Build  Channel
bzip2                     1.0.8                h10d778d_5    conda-forge
ca-certificates           2023.11.17           h8857fd0_0    conda-forge
filelock                  3.13.1             pyhd8ed1ab_0    conda-forge
gmp                       6.3.0                h93d8f39_0    conda-forge
gmpy2                     2.1.2           py310hb691cb2_1    conda-forge
icu                       73.2                 hf5e326d_0    conda-forge
jinja2                    3.1.3              pyhd8ed1ab_0    conda-forge
libabseil                 20230802.1      cxx17_h048a20a_0    conda-forge
libblas                   3.9.0           20_osx64_openblas    conda-forge
libcblas                  3.9.0           20_osx64_openblas    conda-forge
libcxx                    16.0.6               hd57cbcb_0    conda-forge
libffi                    3.4.2                h0d85af4_5    conda-forge
libgfortran               5.0.0           13_2_0_h97931a8_1    conda-forge
libgfortran5              13.2.0               h2873a65_1    conda-forge
libhwloc                  2.9.3           default_h24e0189_1009    conda-forge
libiconv                  1.17                 hd75f5a5_2    conda-forge
liblapack                 3.9.0           20_osx64_openblas    conda-forge
libopenblas               0.3.25          openmp_hfef2a42_0    conda-forge
libprotobuf               4.24.4               h0ee05dc_0    conda-forge
libsqlite                 3.44.2               h92b6c6a_0    conda-forge
libuv                     1.46.0               h0c2f820_0    conda-forge
libxml2                   2.11.6               hc0ae0f7_0    conda-forge
libzlib                   1.2.13               h8a1eda9_5    conda-forge
llvm-openmp               17.0.6               hb6ac08f_0    conda-forge
markupsafe                2.1.3           py310h6729b98_1    conda-forge
mkl                       2022.2.1         h44ed08c_16952    conda-forge
mpc                       1.3.1                h81bd1dd_0    conda-forge
mpfr                      4.2.1                h0c69b56_0    conda-forge
mpmath                    1.3.0              pyhd8ed1ab_0    conda-forge
ncurses                   6.4                  h93d8f39_2    conda-forge
networkx                  3.2.1              pyhd8ed1ab_0    conda-forge
numpy                     1.26.3          py310h4bfa8fc_0    conda-forge
openssl                   3.2.0                hd75f5a5_1    conda-forge
pip                       23.3.2             pyhd8ed1ab_0    conda-forge
python                    3.10.13         h00d2728_1_cpython    conda-forge
python_abi                3.10                    4_cp310    conda-forge
pytorch                   2.0.0           cpu_mkl_py310hed029b9_104    conda-forge
readline                  8.2                  h9e318b2_1    conda-forge
scipy                     1.11.4          py310h3f1db6d_0    conda-forge
setuptools                69.0.3             pyhd8ed1ab_0    conda-forge
sleef                     3.5.1                h6db0672_2    conda-forge
sympy                     1.12            pypyh9d50eac_103    conda-forge
tbb                       2021.11.0            he51d815_0    conda-forge
tk                        8.6.13               h1abcd95_1    conda-forge
typing_extensions         4.9.0              pyha770c72_0    conda-forge
tzdata                    2023d                h0c530f3_0    conda-forge
wheel                     0.42.0             pyhd8ed1ab_0    conda-forge
xz                        5.2.6                h775f41a_0    conda-forge

I'm new to PyTorch, so let me know what I'm doing wrong!

@corinwagen I had the same issue with the ensemble models, but managed to get it work by swapping to a single model (e.g. models/aimnet2_wb97m-d3_1.jpt)

Thanks, appreciate it - is the ensemble significantly more accurate, or are the single models a decent replacement?

The compiled ensembled models return forces, but do not keep graph to calculate higher order derivatives. This is for computational efficiency. I added the code of ensembled modes, if you need Hessian, you can re-compile ensemble with detach=False.
https://github.com/isayevlab/AIMNet2/commit/fc671d8747ccb84a8630339bc59fc99fbbfba5a5


:ignoremark and :samemark do not seem to be documented

<brokenchicken> m: s:ignoremark/e/z/ and .say given $ = "e\x[308]"
<camelia> rakudo-moar 077a75: OUTPUT«z␤»
<brokenchicken> m: s:samemark/e/z/ and .say given $ = "e\x[308]"
<camelia> rakudo-moar 077a75: OUTPUT«z̈␤»

See also: https://github.com/perl6/doc/issues/919


[Submission]: qMuVi - An open-source quantum Music Video tool

Project name
qMuVi
Github repo
https://github.com/garymooney/qmuvi
Description
A library converting quantum circuits into audiovisual experiences, bridging the gap between complex quantum computations and human perception. It renders music videos that reveal the evolution of quantum states during algorithm processing, making quantum computing more intuitive and accessible.
Email
<EMAIL_ADDRESS>Alternatives
No response
License
GNU Library or "Lesser" General Public License (LGPL)
Affiliations
The University of Melbourne
Group
other
Labels
Converter, Visualization
Website
https://garymooney.github.io/qmuvi/

Could we have a new label added "Education"?

Is there a way to rerun the tests? I've just fixed an ecosystem.json format error. I'm using poetry and am still unsure if I've set it all up correctly.

@garymooney sorry about the tests. Please ignore them as we'll be removing them soon.
I'll add the label to your PR


Set the depth camera properties in c++

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
SR300

Firmware Version
<IP_ADDRESS>

Operating System & Version
Linux (Ubuntu 18.04)

Kernel Version (Linux Only)
4.9.14

Platform
NVIDIA Jetson Nano

SDK Version
2.0

Language
C++

Segment
computer vision

Issue Description
Hi, I am new to the realsense SDK. I am trying to modify the depth properties(viz. DEPTH_PROJECTOR_POWER, DEPTH_MOTION_RANGE, etc.) of the Intel realsense SR300 in c++. I want the similar behaviour as in the realsense viewer where I can drag the trackbar and change motion to range trade off, etc. Can you please give me a code snippet that performs the same. Thank you in advance for your help and answers.

@kevinpaulsudarshan The source code of RealSenseViewer is in the link below. Please check if this helps you. Thanks!
https://github.com/IntelRealSense/librealsense/tree/master/tools/realsense-viewer

Thanks for your answer @RealSenseCustomerSupport. Actually I found the answer to my question in the sensor-control example.. Here is a small code snippet if anybody needs in the future.
rs2::context ctx;
rs2::device_list devices = ctx.query_devices();
rs2::device selected_device;

if (devices.size() == 0)
{
        std::cerr << "No device connected, please connect a RealSense device" << std::endl;

        //To help with the boilerplate code of waiting for a device to connect
        //The SDK provides the rs2::device_hub class
        rs2::device_hub device_hub(ctx);

        //Using the device_hub we can block the program until a device connects
        selected_device = device_hub.wait_for_device();
}
else
{
    selected_device = devices[0]; //select device 0 as there is only one device connected in my case
}
std::vector<rs2::sensor> sensors = selected_device.query_sensors();
rs2::sensor sensor = sensors[0]; //select sensor 0 as it is the depth sensor in my case

// Each option provides its rs2::option_range to provide information on how it can be changed
// To get the supported range of an option we do the following:
rs2_option option_type = RS2_OPTION_MOTION_RANGE; //using depth motion range trade-off as the option
float newValue = 100;
rs2::option_range range = sensor.get_option_range(option_type);
float default_value = range.def;
float maximum_supported_value = range.max;
float minimum_supported_value = range.min;
float difference_to_next_value = range.step;

if(minimum_supported_value <= newValue <= maximum_supported_value)
{
    sensor.set_option(option_type, newValue);
}
else
{
    std::cout << "  Input value of option type is out of range! " << std::endl;
    std::cout << "  Supported range for option " << option_type << ":" << std::endl;
    std::cout << "  Min Value     : " << minimum_supported_value << std::endl;
    std::cout << "  Max Value     : " << maximum_supported_value << std::endl;
}


Show video without stretching the width

I would like to know if anyone knows or knows a way to make the width of the video is consistent with the video that is playing

having same issue video looks stretched width wise

I personally recommends you using ExoPlayer, it is very simple to implement and allows you to have a fairly complete control of all the playback


exporting raw wifi beacon data

Is it possible to export raw, full, unparsed wifi beacon data?

Yes, but currently into two files via lswifi -export.

Is this what you're looking for? Or are you looking for something else? Like exporting to pcap?

Thank You, sorry for misunderstanding documentation


mongodb-connector-added

Describe your changes :

fix #1076 :I worked on the adding MongoDB Connector

Type of change :

[x] New feature

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have commented on my code, particularly in hard-to-understand areas.

Reviewers
@open-metadata/ingestion

when will it be merged?

@pmbrull closing this out

I'm sorry, why was this closed? Is there already an implementation for this purpose?


If --config of module's hook failed, hook ignored

If hook returns invalid json for --config request, addon-operator just ignores this hook.
In this case addon-operator must fail or keep trying to --config.

When error occured during configuration of module hooks, then configuration is keeping retried.
The error can be exit non zero or problems unmarshaling json. There is no validation of bindings for now.

Bug is reproduced: operator runs hook --config for all hooks of module and adds successful hooks into index. When hook --config is failed, then index is not cleaned. The next discover task doesn't initialize module hooks because index for module has entries with successful hooks.

Fixed in #33


algorithm added issue no.: #2933

this pull request is related to issue: job scheduling with deadlines.
all the description related to the problem is inside the .cpp file.
issue no.: #2933

I have modified the requested changes, please review them.

since, I have forked this repo some days ago, now I am facing conflicting issue when I am updating the readme file, because your read me file is some commit ahead of mine. I have tried several method from google but, problem not resolved so please help.
@HarshCasper

since, I have forked this repo some days ago, now I am facing conflicting issue when I am updating the readme file, because your read me file is some commit ahead of mine. I have tried several method from google but, problem not resolved so please help.
@HarshCasper

You can try this.

all requested changes has been made.

added dynamic inputting.
updated readme file.


chore: bump arabica-5 genesis-hash

Overview
Ref: #1725

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #1735 (0f81f5e) into main (b53a4ca) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1735      +/-   ##
==========================================
- Coverage   56.09%   55.99%   -0.11%
==========================================
  Files         232      232
  Lines       15147    15147
==========================================
- Hits         8497     8481      -16
- Misses       5747     5764      +17
+ Partials      903      902       -1

Impacted Files
Coverage Δ

nodebuilder/p2p/genesis.go
45.45% <ø> (ø)

share/p2p/shrexnd/pb/share.pb.go
35.81% <0.00%> (-1.90%)
:arrow_down:

share/ipld/get.go
93.38% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add docs to py-deb-workflow

Add docs to py-deb-workflow, in the scope of BP-1283.
Same as #266 plus #269
Tested in https://github.com/MOV-AI/flow-initiator/actions/runs/12142490822/job/33857093107#step:27:5

merge at will


Add some user and tech doc

it's not complete but it's a beginning
user documentation

[X] Idea products compatibility
[x] Opa version compatibility
[X] Faq (test duration and pass test )
[X] how to create new rego file and edit the template used for creation
[X] how to change highlighting color
[X] comment code

tech doc

[x] opa version used for test
[x] Architecture (project structure, kotlin gradle dsl, testing strategy)
[x] correct spelling mistakes noticed in #4
[X]  create rego file implementation

@asadali  thanks a lot for the review  !


Fix Ghseets scroll

Description
Remove multiple scroll bars in GSheets.
Fixes #6378
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/gsheet-scroll-bug

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
54.92 (0)
36.94 (0.01)
33.24 (0)
55.51 (0)

:red_circle:
app/client/src/components/editorComponents/CodeEditor/index.tsx
65.27 (0)
36.96 (0)
51.35 (0)
67.58 (-0.62)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
50.71 (0.24)
38.6 (0.88)
36.21 (0)
55.35 (0.27)

/ok-to-test sha=5a42dc8

/ok-to-test sha=05c69c0


Pages directory setting not working

Maybe we are making an error in our configuration but we are not able to set another directory as our source pages directory. Setting anything else than the default ./src/pages results in that none of the pages get rendered/created.
I created a basic example at https://stackblitz.com/edit/github-hyh7sd?file=vite.config.js and here is the vite.config.js, which doesn't work:
export default {
  plugins: [
    vituum({
      pages: {
        dir: './src/views',
      },
    }),
    twig({
      root: './src',
    }),
  ],
};

This is with the new 1.0 release.
PS. Thanks for the work and the 1.0 release.

@superflausch you need to change build.rollupOptions.input in vite.config when you're changing  pages dir. See https://vituum.dev/config/main-options.html#input or https://vituum.dev/guide/migrating-1-0.html for more info.
I can see it's creating some confusion, so I might change this to work automatically in the future 👍


Adjust branding, colors, menus, etc to integrate Viz with M-Lab site

This PR adds a number of updates to essentially integrate the Viz site with the main M-Lab site. In summary:

Addition of the top level M-Lab site menu above the Viz menu, with 'Visualizations' permanently highlighted as active
Formatting the Viz menu to look like the sub-menus on the M-Lab site
Color changes to links and buttons
Text review and edits to the About M-Lab Viz page
Standardized use of 'M-Lab Viz' instead of 'MLab Vis' since that matches our URL choice

This PR can be previewed on the Viz Staging site: https://viz-dot-mlab-staging.appspot.com/
A corresponding PR for the main M-Lab site can be previewed on my fork
Suggested order of operations for launch:

Production pipeline and API are updated and working
Review and merge of PR, deploy to production VM
Review and merge PR for the main M-Lab site

few comments about the README but LGTM


fix(cardEditor): the showLegend was in the incorrect place for TimeSeriesCards

Closes #https://github.ibm.com/wiotp/monitoring-dashboard/issues/1659
Summary

Need to move the showLegend prop down to the actual content section of the TimeSeriesCard

Change List (commits, features, bugs, etc)

This PR unfortunately does have a dependency on this PR getting integrated first: https://github.com/carbon-design-system/carbon-addons-iot-react/pull/1832

Acceptance Test (how to verify the PR)

Verify that the default TimeSeriesCard story here shows the legend:
http://<IP_ADDRESS>:3000/?path=/story/watson-iot-timeseriescard--single-point

:tada: This PR is included in version 2.141.0-next.29 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.141.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fox sample does not show bones, even in pose mode

Describe the bug
When importing the fox sample model, Blender only shows the icosphere at 0,0,0 and bones cannot be clearly seen. See screenshot below.
If I uncheck "Shapes" in Armature Viewport Display, I get the result from previous blender versions, which is visible and easy to manipulate.
To Reproduce
Steps to reproduce the behavior:

Import the fox gltf model with default settings
Click on the armature
Use ctrl-tab to enter Pose mode
Select the b_hip bone (or any other bone)
It is very difficult to see which bone is selected.

Expected behavior
Bones should be clearly visible and easy to manipulate while in pose mode, for example unchecking Shapes in Armature Viewport Display

Yes, I know the bones are pointing X-positive in this import. That is really important information. I need to be able to see this. Otherwise I'm working blind.
Screenshots
Here's the example of the problem with the fox model in pose mode with poorly visible bones and an icosphere at 0,0,0:

.blend file/ .gltf
Empty blender 4.0.2 instance (select all, delete), then importing with default settings the official Fox sample from:
https://github.com/KhronosGroup/glTF-Sample-Models/blob/master/2.0/Fox/glTF-Binary/Fox.glb
Version

OS: Windows 10
Blender Version: 4.0.2

Additional context
Followup to #2073 . The previous issue was about the bone spheres being undesirable as a default.
This issue is taking the spheres as given, showing that the spherical bone feature does not work as intended.

Hello,
Agree that in some cases, the sphere size is not the best.
Let's try to continue the discussion in a single place. Let's close this issue, and continue in #2075, as it has many example


Convert xml code idents to xaml

:tada:
Fixes #2577

@BillWagner Yes, this one was done by script, and it only changed the lang ident when it explicitly saw a .xaml file extension for the example. As long as those files have accurate extensions, we should be ok here.