Round-trip failure: untagged enum containing Vec variant is improperly deserialized

Consider the following types:
#[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
#[serde(untagged)]
enum MyValue {
    Int(i64),
    String(String),
    Enum(Enum),
    List(Vec<MyValue>),
}

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
enum Enum {
    First(String),
    Second(i64),
}

Let's try serializing a MyValue::Enum value like the following: MyValue::Enum(Enum::First("foo".to_string())). Its RON-serialized value is First("foo").
That First("foo") value unfortunately deserializes to MyValue::List([MyValue::String("foo")]) instead of our original enum-based value. This is surprising to me, because the deserialization code decides to ignore the First prefix entirely, and skip forward until the ( then deserialize a list with it. It's especially surprising because the MyValue::Enum variant is before the MyValue::List variant, and yet we still get a MyValue::List back instead of MyValue::Enum.
Here's a complete repro:
#[cfg(test)]
mod tests {
    use serde::{Serialize, Deserialize};

    #[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
    #[serde(untagged)]
    enum MyValue {
        Int(i64),
        String(String),
        Enum(Enum),
        List(Vec<MyValue>),
    }

    #[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
    enum Enum {
        First(String),
        Second(i64),
    }

    fn serialize_then_deserialize(value: &MyValue) -> MyValue {
        ron::from_str(ron::to_string(value).unwrap().as_str()).unwrap()
    }

    #[test]
    fn test() {
        let value = MyValue::Enum(Enum::First("foo".to_string()));
        let deserialized = serialize_then_deserialize(&value);
        assert_eq!(value, deserialized, "Serialized as: {}", ron::to_string(&value).unwrap());
    }
}

This fails with:
running 1 test
thread 'file::tests::test' panicked at 'assertion failed: `(left == right)`
  left: `Enum(First("foo"))`,
 right: `List([String("foo")])`: Serialized as: First("foo")', src/file.rs:X:9

Thanks to everyone that contributes to building and maintaining this awesome library! Any advice on avoiding this issue would be much appreciated.

I'll take a look now

Ok, I think I can at least explain what's happening here. #[serde(untagged)] first deserializes into a private Content value type to buffer what has been found. Then all variants attempt to deserialize from that Content type in order, and the first one to succeed returns. The issue is that RON is more expressive than serde's data model, so when the Content type is created with deserialize_any, the information that First("foo") looks like a tuple struct with name First is lost and all that remains is the information that it looks like a tuple, i.e. sequence ("foo",). @torkleyy would this issue be fixed in your future reboot? I'm not sure if this can be fixed in RON as the encoding through serde isn't lossless (unlike for JSON), but I'll see if I can find something.

#253 might be related, I'll check if it would fix the issue

With #253 the test case would pass, but:
1. Unit variants now deserialize to Value::String instead of Value::Unit:
// No longer works
assert_eq!("Foo".parse(), Ok(Value::Unit));
// This is now the new result
assert_eq!("Foo".parse(), Ok(Value::String(String::from("Foo"))));

2. A potential bug with earlier untagged enum variants is fixed as the extraneous If tag is no longer accepted in:
BuildSystem(
    version: "1.0.0",
    flags: [
        "--enable-thing",
        "--enable-other-thing",
        If("some-conditional", ["--enable-third-thing"]),
    ]
)

3. Anything that looks named-struct-like now deserializes to a singular Value::Map with one key, the struct name, and one value, the inner content:
assert_eq!("Room(width: 20)".parse(), Ok(
    Value::Map(
        vec![(
            Value::String("Room".to_owned()),
            Value::Map(
                vec![(
                    Value::String("width".to_owned()),
                    Value::Number(Number::new(20)),
                )].into_iter().collect(),
            ),
        )].into_iter().collect(),
    )
);

@torkleyy @kvark What do you think about this tradeoff? I could try to reopen and refactor #253.

Maybe at least part of #4 could be solved by adding some extra functionality to Value when doing non-self-describing deserialization.

Ok, I played around with it a bit more to get a feel of what a rough implementation could look like. It's essentially #253 but with (a) a fix that makes unnamed struct-likes work again (though this fix requires a lot more though to ensure it actually works in all edge cases) and (b) special handling in the Value Deserializer impl to get all types of structs and enums to properly roundtrip through Value. Some of that is fixing issues that #253 introduces to get untagged enums to work, but I think getting enums to roundtrip through Value might be new? Most of the new Value code is adapted from serde internals for now and could be cleaned up a lot.

You can have a look here https://github.com/ron-rs/ron/compare/master...MomoLangenstein:253-untagged-enums to see roughly what would be changed.

I guess my summary is that

it is possible
only Value and deserialize_any are affected at all
the semantics of Value change a bit as anything struct-like including enums are now encoded in the JSON way serde forces on us if we want to use untagged enums (i.e. they are wrapped in a 1-element map that goes from name to content)
it requires a lot of extra code in the Value Deserializer but it should only add functionality

@MomoLangenstein has there been any further development on this issue?

@NiklasEi I haven't done any more work on this since. If there is interest, I could definitely have another look and see if I could resolve some of the issues I came across during the initial attempt. However, this method seems to require serde's unfortunate enum workaround in any case ... which is unfortunate given that ron is more expressive than json. So if we'd want this to work, it might require a tradeoff for deserialize_any and Value. @torkleyy @kvark What would be your thoughts on this? Would it be worth looking into further?

Thank you @obi1kenobi for providing a very good test case - I just realised that https://github.com/ron-rs/ron/pull/451 fixed the issue and have added a test to ensure it remains working.

My pleasure, thanks for the fix! 🙌


Update submodule ecl to latest Mon Apr 27 12:39:40 UTC 2020

- ecl in PX4/Firmware (27232514fcaf04924ecb405e144615c23ac6e2e0): https://github.com/PX4/ecl/commit/8a9d961f0d7b0cf6371ab1fcd6d0d2ccb581d3d1
- ecl current upstream: https://github.com/PX4/ecl/commit/8b6d665a1331f94091caf2f262e09d508eb8975c
- Changes: https://github.com/PX4/ecl/compare/8a9d961f0d7b0cf6371ab1fcd6d0d2ccb581d3d1...8b6d665a1331f94091caf2f262e09d508eb8975c

8b6d665 2020-04-26 kamilritz - Avoid subtraction of two uint
70d65ea 2020-04-16 kamilritz - Test:Increase GPS jump need for rejection
c19f40e 2020-04-15 Kamil Ritz - Add reset position test for GPS and VISION
78a6b9f 2020-04-15 Kamil Ritz - SensorSimulator: Fix GPS horizontal position step
050298f 2020-04-08 Kamil Ritz - Improve matrix library usage
5749273 2020-04-08 Kamil Ritz - refactor resetPosition

It's generally been less painful overall to continuously bring in each incremental ecl change.


[locale] Updated tamil archaic numerals to the one currently used in src/locale/ta.js

Updated tamil archaic numerals to the one currently used. Ref: #5557

looks good!

Valid question. But the start of the tamil months in a year is calculated by astrological concepts. It has to be done every year. And every year those dates will change. So tamil people use english months for everything related to tech, government, business everything except for calculating dates to fix cultural events.

Since those astrological events cannot be calculated in moment.js, it can be left as it is.

Awesome! 🦄

As someone who speaks Tamil. I approve.

@naveen-bharathi Thank you.
Please also update src/test/locale/ta.js  so the tests pass.

@yg நன்றி நண்பா 👍🏻

@marwahaha. updated the tests for locale - Tamil in src/test/locale/ta.js  Ref: #5627

The build is failing, so I will close and re-open the PR.

Coverage remained the same at 88.524% when pulling 3b725a11b0c545673907694519eeee762c152b15 on naveen-bharathi:patch-2 into 471d67fe197d34486af93045d14453df901dc74e on moment:develop.

@naveen-bharathi @tk120404 @NotMoni  are there sources like CLDR or official government pages that show which numerals are correct?

yes

@NotMoni please provide some sources

I can't merge this, I couldn't fix the conflicts :(


Integration of qdrant and uptrain

Pull Request Template
Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Description
Please include a summary of the change and which issue it addresses. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style (BLACK) of this project.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I have updated the documentation accordingly.
[ ] I have added an appropriate CHANGELOG entry.

Author's Note
Please provide any additional information, questions, or concerns you have about this pull request.

@aryangoyal7 Thanks for integrating Qdrant into UpTrain. In Step 6:
results = []
for hit in hits:
print(hit.payload.get("text", ""))
print(hit.payload, "score:", hit.score)  # Print initial search results
embedding_to_evaluate = hit.vector
data = [{
    'question': "Give a list of book with Aliens attack our planet",
    'context': "",
    'response': hit.payload.get("text", "")
}]
results.append(eval_llm.evaluate(
    data=data,
    checks=[Evals.CONTEXT_RELEVANCE] #choose your evaluation metrics accordingly
))

print(json.dumps(results, indent=3))
I think hit.payload.get("text", "") should be assigned as context instead of response


nbdev_preview not starting if there is a folder with no notebook in it

Environment

Create a new folder, and a subfolder For example, /folder1/folder2
Create a new notebook in /folder1/folder2/aNotebook.ipynb
in the command line, from the root folder, issue 'nbdev_preview`

Observed behaviour
ERROR:
Error reading metadata file from /sidebar.yml

ERROR: YAMLException: bad indentation of a sequence entry (sidebar.yml, 6:20)
5:       - 00_core.ipynb
6:           - section: afolder2
                      ~
7:             contents:

Expected behaviour
nbdev_preview should start as normal.
Suggested source of the problem
in sidebar.yml (partial)
website:
  sidebar:
    contents:
      - index.ipynb
      - 00_core.ipynb
          - section: afolder2  ::: NOTE DOUBLE INDENT HERE
            contents:
              - afolder1/afolder2/aNotebook.ipynb

Yaml does not like if there is no content directly in a section, and gets thrown off if there is a double indentation instead.
This might be a YAML limitation, and a workaround is needed.
Suggested workaround 1
Add an empty notebook into that empty folder?
Suggested workaround 2
Add a meaningful error message and instructions for the user what to do?

@jerzydziewierz thanks for the helpful issue write-up! :) this should be fixed in the next release, or you can try installing from master


feat(eshell): add vertico completion for eshell history

Switching to vertico results in +eshell/search-history defaulting to eshell-list-history, using completing-read allows us to tie into vertico completions which are much nicer.

You can use consult-history for that, which has more features. cc @iyefrat

Thanks for your help!


fix: DirectEvent to BubblingEvent on Android/Windows

fix #1221

Hey @Sunbreak. Sorry we haven't reviewed your PR. I will allocate some free time this weekend, make sure the Android setup is working good for new arch and old arch and either give feedback or approve and merge it.

@Sunbreak Checked on Android in Fabric, the events do not seem to be sent anymore:

Or BubblingEvent to DirectEvent on iOS?

Or BubblingEvent to DirectEvent on iOS?

Come to think of it, maybe it should all be direct events, even for iOS and in the spec. The point of Bubbling event was that we had some weird setup where the custom view of Lottie was wrapped by another view, but now that it is gone, maybe the spec should change and it should all become direct event, cause we are capturing it there directly. Try it out, let me know how it works.

Any updates @Sunbreak ?


Focus window

Short overview
As a user I want to be able to focus a window specified by its window handle

@s1hofmann I'm interested in this as well. I'm working on solving this for my needs and will update here if I progress.

https://github.com/nut-tree/libnut-core/pull/164


Add/Enable official support of malduck extractors

Related to: https://github.com/CERT-Polska/malduck/issues/99

For output conversion: https://github.com/CERT-Polska/mwdb_iocextract


The description in the CompressedTextureLayered docs is problematic

Godot version
4.0
System information
Linux mint 21.1, Vulkan API 1.3.205, NVIDIA GeForce GTX 1050 Ti
Issue description
Currently, the description of CompressedTextureLayered is pieced together from CompressedTexture2DArray and CompressedTexture2D, it seems that the correct description is missing.

Steps to reproduce
See above.
Minimal reproduction project
N/A

The documentation here may be out of date.


Editing a date within the input manually doesn't update when saving

Steps to reproduce
Add a datepicker field
 DatePicker::make()
  ->name('start_date')->label('Start date')
  ->time24h()
  ->allowInput()
  ->required(),

Edit the input field manually

Notice how the date picker picked up the edit

Click save
Reload the page
The field is back to it's original value

It works properly when editing via the Date picker and not the input

I guess this is the same issue as #2667 with fix #2668

A follow up issue
With the fix, the display format is not properly parsable by date, while it's a good human readable format the month names are localized and then do not parse properly eg in fr
new Date('décembre 11, 2024 12:00') // Invalid date
I guess we would need to replace the month names in the current locale into the en locale before parsing it

Seems the rest of the logic is also quite flawed
const fullFormat = 'yyyy-MM-dd HH:mm:ss';
if (date.length === fullFormat.length) {
  return parse(date + 'Z', fullFormat + 'X', Date.UTC());
}

Format check on format length instead of a regex
This means the following date mars 11, 2024 12:00 will pass into that condition and parse to an invalid date


Swap the filter and order fields in the project manager

Follow-up to https://github.com/godotengine/godot/pull/61210 (can be merged independently, I'll rebase).
This matches 4.0 project manager presentation, with filter appearing on the left and order on the right.

Thanks!


Update AMI list

Signed-off-by: CfnCluster AMI bot<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I am unable to merge this PR


API - Get Recommended Actions from Text Endpoint

Goal: Implement an API endpoint to receive a text input and return a list of recommended salesforce actions based on that text.
Background: We need an endpoint that can process text and generate recommended actions. This would be used to suggest actions to a user based on the notes added by him
Tasks:

[ ] Design and implement a new API endpoint
[ ] The endpoint should receive a text input, process it, and return a list of recommended actions.
[ ] POC on openAI models needs to be done for this use case.
[ ] Handle possible errors such as invalid input or server errors.
[ ] Write tests for the new endpoint.

This task is required for the completion of user story:

TrueSparrowSystems/AI-SalesBridge-iOS-App#8
TrueSparrowSystems/AI-SalesBridge-iOS-App#11


Allow developer to specify which X2 files to import

New developer powers:
Import only students file from X2:
thor import:start --source x2 --x2-file-importers students
Import students, assessments, and behavior from X2:
thor import:start --source x2 --x2-file-importers students assessments behavior
Import from all sources and files:
thor import:start

@alexsoble Is this :+1: to merge, or does it need more work to finish?  It's cool either way and no rush, I'm just cleaning through issues and this looks good to me :)

@kevinrobinson I want to run all the different developer options against the staging site, once I've done that I'll merge in.

Works nicely on staging with real data. :+1: :blush: :100: :tada:

@kevinrobinson But seeing some errors in the import process on production now... may be related. :/


fix(bug): new should assume doc/adr

adr-tools will default to doc/adr for the new command, adrs should too for compatibility.

looks awesome dude, you rule.


KeyError when selecting "nearest" data with given tolerance

What happened: Selecting data with ds.sel(index=given_index, method="nearest", tolerance=tolerance) only works in case for each given_index exists an index that is within the given tolerance, otherwise a `KeyError: "not all values found in index 'index'" occurs.
What you expected to happen: I would expect, that those indices that are not within the tolerance would simply be dropped.
Minimal Complete Verifiable Example:
import xarray as xr
ds = xr.DataArray([1,2,3,4,5], dims=["lat"], coords={'lat':[10,20,30,50,60]})

# working example, all latitudes are within the tolerance
ds.sel(lat=[5,15,40], method="nearest", tolerance=10)
#<xarray.DataArray (lat: 3)>
#array([1, 2, 4])
#Coordinates:
#  * lat      (lat) int64 10 20 50

# failing example, latitude 40 is not within the tolerance
ds.sel(lat=[5,15,40], method="nearest", tolerance=5)
# KeyError: "not all values found in index 'lat'"

I would expect
>>> ds.sel(lat=[5,15,40], method="nearest", tolerance=5)
<xarray.DataArray (lat: 2)>
array([1, 2])
Coordinates:
  * lat      (lat) int64 10 20

Anything else we need to know?:
Environment:
Output of xr.show_versions()

INSTALLED VERSIONS
commit: 66acafa7f1f1477cfd6c5b7c3458859763433092
python: 3.8.8 | packaged by conda-forge | (default, Feb 20 2021, 16:12:38)
[Clang 11.0.1 ]
python-bits: 64
OS: Darwin
OS-release: 20.2.0
machine: x86_64
processor: i386
byteorder: little
LC_ALL: None
LANG: None
LOCALE: None.UTF-8
libhdf5: 1.10.6
libnetcdf: 4.7.4
xarray: 0.15.2.dev452+g66acafa7.d20210304
pandas: 1.2.3
numpy: 1.20.1
scipy: 1.6.0
netCDF4: 1.5.6
pydap: installed
h5netcdf: 0.10.0
h5py: 3.1.0
Nio: None
zarr: 2.6.1
cftime: 1.4.1
nc_time_axis: 1.2.0
PseudoNetCDF: installed
rasterio: 1.2.0
cfgrib: <IP_ADDRESS>
iris: 2.4.0
bottleneck: 1.3.2
dask: 2021.02.0
distributed: 2021.02.0
matplotlib: 3.3.4
cartopy: 0.18.0
seaborn: 0.11.1
numbagg: installed
pint: 0.16.1
setuptools: 49.6.0.post20210108
pip: 20.2.4
conda: None
pytest: 6.2.2
IPython: None
sphinx: None

>>> ds.sel(lat=[5,15,40], method="nearest", tolerance=5)
<xarray.DataArray (lat: 2)>
array([1, 2])
Coordinates:
  * lat      (lat) int64 10 20

This is a very surprising result, you've asked for values at three points but received two back.
The following (specifying fill_value) seems like better behaviour to me but how do you choose the coordinate label (here I picked 40 since that was provided to sel)
>>> ds.sel(lat=[5,15,40], method="nearest", tolerance=5, fill_value=-999)
<xarray.DataArray (lat: 2)>
array([1, 2, -999])
Coordinates:
  * lat      (lat) int64 10 20 40

Introducing a fill_value seems like a good idea, such that the size of the output does not change compared to the intended selection.
Choosing the original/requested coordinate as a label for the missing datapoint seems to be a valid choice because this position has been checked for valid data nearby without success.
I would suggest, that the fill_value should then be automatically determined from the _FillValue, the datatype and only at last requires the fill_value to be set.
However, the shortcoming that I see in using a fill_value is that the indexing has to modify the data ( insert e.g. -999) and also 'invent' a new coordinate point ( here 40). This gets reasonably complex, when applying to a dataset with DataArrays of different types, e.g.
import numpy as np
import xarray as xr

ds = xr.Dataset()
ds['data1'] = xr.DataArray(np.array([1,2,3,4,5], dtype=int), dims=["lat"], coords={'lat':[10,20,30,50,60]})
ds['data2'] = xr.DataArray(np.array([1,2,3,4,5], dtype=float), dims=["lat"], coords={'lat':[10,20,30,50,60]})

One fill_value might not fit to all data arrays being it because of the datatype or the actual data. E.g. -999 might be a good fill_value for one DataArray but a valid datapoint in another one.

in using a fill_value is that the indexing has to modify the data ( insert e.g. -999) and also 'invent' a new coordinate point ( here 40).

This seems totally doable though.

One fill_value might not fit to all data arrays

In quite a few functions, fill_value can be a dict mapping variable name to a value so this is workable.
Let's see what others think.

Actually does reindex do what you want, the returned coordinate labels will be what you provide.
>>> ds.reindex(lat=[5,15,40], method="nearest", tolerance=5, fill_value=-999)
<xarray.DataArray (lat: 2)>
array([1, 2, -999])
Coordinates:
  * lat      (lat) int64 5 15 40

Thanks @dcherian, this is doing the job. I'll close this issue as there seems to be no need to implement this into the sel method.

@observingClouds I think a fill_value arg in sel as in reindex is still warranted. Although reindex as @dcherian suggested works for cases the dims match the target dims, but in cases where the dims don't match, e.g., in the examples of sel: https://xarray.pydata.org/en/stable/generated/xarray.DataArray.sel.html. It'd cause error:
ValueError: Indexer has dimensions ('points',) that are different from that to be indexed along x

Example using nearest & tolerance with  reindex & sel when dims don't match based on the example in sel:
import numpy
import xarray

da = xarray.DataArray(
    numpy.arange(25).reshape(5, 5),
    coords={"x": numpy.arange(5), "y": numpy.arange(5)},
    dims=("x", "y"),
)
tgt_x = numpy.linspace(0, 4, num=5) + 0.5
tgt_y = numpy.linspace(0, 4, num=5) + 0.5
da = da.reindex(
    x=tgt_x, y=tgt_y, method="nearest", tolerance=0.2, fill_value=numpy.nan
).sel(
    x=xarray.DataArray(tgt_x, dims="points"),
    y=xarray.DataArray(tgt_y, dims="points"),
    method="nearest",
)

Output:
<xarray.DataArray (points: 5)>
array([nan, nan, nan, nan, nan])
Coordinates:
    x        (points) float64 0.5 1.5 2.5 3.5 4.5
    y        (points) float64 0.5 1.5 2.5 3.5 4.5
Dimensions without coordinates: points

Side note: I don't think it makes sense to add fill_value to sel as it would require adding new coordinates that didn't exist previously. Calling reindex first makes that more clear in my opinion.


scanning multiple ports async callback is broken

portscanner/lib/portscanner.js:141
callback(error, port)
^
TypeError: undefined is not a function

It looks like PR #28 made the (incorrect) assumption that JavaScript has method overloading. It should be fixed to detect array-like input with a simple typeof foo === 'object' && foo.length check.

FWIW, I expected that to be dealt with during a code review, before getting merged.

Still getting this error...

This should not be affecting the latest release on npm, 1.0.0, as that came out before the above mentioned PR. The fix should be pretty easy, but its best to avoid installing from GitHub for now. :)

I did install via npm, and am using version 1.0.0... it seems to also be using version 0.1.15 of async? Not sure if that could be causing the problem. I've attached a screen shot of my node module versions, along with the error I'm getting.
npm module version #s:

seems to be the same error as posted earlier:

Thank you for your quick response, any help is greatly appreciated =)

This looks like a different problem. Could you post a gist with some code that I can run to reproduce the problem, so I can double check? Based on that error message, I am guessing that you aren't passing portscanner the number of arguments it is expecting (or in the right positions).

#28 has been reverted in the latest version, if that was indeed causing it, it should be fixed now. There have also been a few improvement in handling multiple signature arguments parsing. Released a new minor version 1.1.0, please check it out and let me know.


Update Composer dependencies (2024-04-01-00-08)

Visual regression test passed!
View the visual regression test report


do not work

tested with 6/7/8
project to be removed

Would be helpful if you are a bit more precise and clarify what actually "do not work" means.

What it means 6/7/8 (Android?!)
What you expected and what actually happened?
Could you build project?
Did app itself crash?


Recording stream

Hi, is there way to record broadcast?
I was trying with createRtpStreamer, i added it inside Server.js
       room.on('newpeer', (peer) => {             peer.on('newproducer', (producer) => {                 let rtpParams = {                     remoteIP: '<IP_ADDRESS>',                     remotePort: (producer.kind === 'audio') ? 10000 : 10002};                 room.createRtpStreamer(producer, rtpParams).then((streamer) => {                     console.log('started mirroring RTP for', producer.kind);                 });             });         });
So when i publish broadcast i get in console:
::ffff:<IP_ADDRESS> 59300 new peer joined the room publisher
started mirroring RTP for audio
started mirroring RTP for video
I tried to access stream with vlc but i cant connect over rtmp://<IP_ADDRESS>:1935/stream.

Im still learning webrtc/mediasoup

Recording would be great with just a boolean field: record: true/false on each channel. If true - store video in a specific folder of the server provided in the configuration.


Example of createCardToken ?

Does anyone have an example code of how to create a card token?
I have been looking everywhere and cant find the code to implement it, I have already done it with px-android so I am guessing it is also possible with px-ios.
Or at least an example of how to instantiate MercadoPagoServices
Thank you

Also its pretty easy to do it by making a request directly to Mercado Pago API but is this way still PCI compliant?


Add a gitignore for all binary files

The repository contains binary executables. It is generally not recommended to have them along with the respective source files.
A better approach would be to create a .gitignore which eliminates all files without extensions, excluding the input files.

Thanks for pointing out  😀


Meta tag load after page load

Hi I am using Next js for server side rendering but all thing working fine but  when mobile device need view port  i trying   Meta, as well as Helmet , react-meta-tags,  but  meta tag load after page load 2.3 second,
Url : www.weswap.io
render() {
return (
  <Head>

weswapio

} />

    );
  }
please help me .. Thanks

Please see this section in the README.  When rendering on the server, you'll need to call Helmet.renderStatic() to retrieve the final <head /> tags output, then inject those into <head /> from within Next as detailed in their README.


Update visual appearance

I love weathermap but the visual appearance is kind of dated.
Compare this drawing (prob. Visio)
http://news.reannz.co.nz/wordpress/wp-content/uploads/2012/07/REANNZ_MAP_July12.jpg
To the real weathermap:
http://weathermap.reannz.co.nz/
If it could look more like the drawing that would be awesome. Smooth curved lines, modern fonts etc.

This is where GD is starting to weigh us down. It has pretty bad font handling, and not-great anti-aliasing. I'd like to get to something like that too. I've been experimenting with SVG, but that also has some issues with fonts, unless you run javascript in the browser to generate the SVG. That said, I've got a nice SVG testbed for curved links, so far:

I'm going to close this, and leave a pointer to #23 where there is discussion of allowing other rendering engines. The "modern fonts" part of your request is possible right now - it's just hard to package fonts with open source software for licensing.


ovmf (efi) booting not working on all "machines"

Not sure if i put it here or in the OMVF Repo.
Test:
Clean clone of this template script.
make all
make run
results on 2 of 3 machines -> QEMU saying: Guest has not initialized the display (yet).

Machine 1: Github Codespace (Intel(R) Xeon(R) Platinum 8370C CPU) (not working)
Machine 2: Physical Windows 11 (Fujitsu with Intel CPU) on WSL (working)
Machine 3: Physical Windows 11 (AMD Machine) on WSL (not working)
afer some search in net, i stumbled on a redit post, it was said, that the omvf could be busted, and one should try this one:
https://github.com/Absurdponcho/PonchoOS/tree/main/OVMFbin
with this downloaded : OVMF_CODE-pure-efi.fd and then started with:
qemu-system-x86_64 -M q35 -drive if=pflash,format=raw,unit=0,file=ovmf/OVMF_CODE-pure-efi.fd -cdrom template-x86_64.iso -m 2G -serial stdio
it runs into UEFI Shell (changing boot order -> bcfg boot mv 2 1 and then reset) it runs the cdrom.
Tried this with Machine 3, copied the file to Machine 1 (Github Codespace) and now all machines work. (codespace with the parameter: -display none of course)
Tried the typical things before:

Clean git clone
make clean
make distclean

Hi,
Thanks for reporting the issue, though, unfortunately, this is an issue that it is not possible to solve.
The problem is that I made the deliberate decision to only have this template work with the latest QEMU: 9.1+ as of the time of posting this.
It is basically not possible to ship/download OVMF versions that will work across the board, on all QEMU versions, and a lot of distros ship a lot of different versions, with some shipping really old ones (like Debian, Ubuntu).
Frankly, if anything, this is something that should be taken up with the QEMU and OVMF maintainers, not this template, as, short of literally detecting the QEMU version in the makefile and shipping some OVMF known to work with it (which would highly complicate the makefile for a template), there is no fix possible.
An alternative, that would at least work for x86-64, is to use the run-bios/run-hdd-bios make targets, as those will just avoid OVMF altogether.

The qemu version requirement should probably be documented in the readme

run-bios /run-hdd-bios works, but then ACPI V1 is only shown in Memory with RSDP. So no 64bit XSDP.
But thanks for the info, i will have a look at the versions. At the moment im at work, so i can only tell:
Github Codespace uses:
QEMU emulator version 4.2.1 (Debian 1:4.2-3ubuntu6.29)

i will write this down, if you like i can write some documentation. Also for the other stuff i find.

@cycl0ne that's fine, PRs are open


Channel creation permissions

Hello, I was reading through some problems and didn't find a solution for this one:
Based on default settings, when someone messages the bot, a new channel is opened and everyone in the server can see it and reply to it.  Is there something I need to configure to fix this?  I looked at the commands, but didn't see anything that indicated how to prevent people from seeing/replying to a message.  Here are my parameters in the config file:
{
"token": "",
"mailGuildId": "493140792722980914",
"mainGuildId": "493140792722980914",
"logChannelId": "493141293900234792",
"status": "Message me for help!",
"responseMessage": "Thank you for your message! Our mod team will reply to you here as soon as possible."
}
Thanks for your time!

you want this on your config.json newThreadCategoryId
create a new category and adjust itso only moderators can see it and @everyone cant read message. after that when someone dm the bot will create channel with permission synced under the category

Thanks! I’ll let you know how it goes.

Is this how it should look?
"token": "",
"mailGuildId": "493140792722980914",
"mainGuildId": "493140792722980914",
"logChannelId": "493265572293902336",
"newThreadCategoryId"
"status": "Message me for help!",
"responseMessage": "Thank you for your message! Our mod team will reply to you here as soon as possible."

you need to add the category ID too. its missing value otherwise it doesnt know where to add the channels

It worked! thank you! For anyone else that might need this, here is how it looks:
{
"token": "",
"mailGuildId": "493140792722980914",
"mainGuildId": "493140792722980914",
"logChannelId": "493265572293902336",
"newThreadCategoryId": "493265431608557571",
"status": "Message me for help!",
"responseMessage": "Thank you for your message! Our mod team will reply to you here as soon as possible."
}


feat: minimal changes to remove php8 deprecations

Minimal changes to remove php8 deprecations.
@JellyBellyDev should we add types to all class properties for a 2.0 version?

Ok to add all types and ok to generate a major 2.0, but not bump to only PHP 8.0, but 7.4 || 8.0 right?

The mixed type wad added in PHP 8, so it's not possibile to both mantain PHP 7 compatibility and remove all the PHP 8 deprecations. Otherwise we should replace the JsonSerializable interface with a custom solution.

Right, I forgot it was introduced in 8. Ok to refactor with full types and bump to 2.0!


[#2246] feat(client): Add the client for user, group,admin and role

What changes were proposed in this pull request?
The client supports to operate the user, group, admin and role
Why are the changes needed?
Fix: #2246
Does this PR introduce any user-facing change?
Yes, I will add the document later.
How was this patch tested?
Add new uts.

@jerryshao This pull request is ready to review.

@jerryshao All comments are addressed.


Commit f8b489791 is not enough. It still swallows text.

@giberti commit f8b489791a1daf8c293fd68782cbdb1367c38628 fixes one bug but introduces another:
<?php
require 'vendor/autoload.php';
use League\CommonMark\Block\Element\FencedCode;
use League\CommonMark\CommonMarkConverter;
use League\CommonMark\Environment;
use League\CommonMark\Event\DocumentParsedEvent;
use League\CommonMark\Extension\CommonMarkCoreExtension;
use Giberti\EmojiExtension\EmojiExtension;

$text = <<<END
line one: 1
LOST LINE: at 12:50:55

text text text
:hot_beverage:?
Just :show-the-unaltered-value: inline.
:smile: you re on candid :camera:

end.
END;

$environment = new Environment([]);
$environment->addExtension(new CommonMarkCoreExtension());
$environment->addExtension(new EmojiExtension());
$converter = new CommonMarkConverter([], $environment);
echo $converter->convertToHtml($text);

It eats 1 LOST LINE: at 12 text. I could fix it only by changing the REGEX which I found too general.

#4


Avoid errors when named capture groups contain forward slashes

Some plugins, most notably Jetpack, contain named capture groups in their route definitions with regular expressions which include forward slash characters. Our naive method of creating the path part hierarchy was to .split( '/' ), which would break these regular expressions in two and cause an error when the route object is being built.
To work around this, we can separate out the named capture groups and only .split( '/' ) the remaining leftover, non-capture-group parts of the path string.
Fixes #310

split-path utility needs tests

@cowboy provided this implementation of parenthesis-group-aware splitting:
"foo/(ba/(r/x))/baz".split("/").reduce((arr, part) => {
  if (arr.length !== 0) {
    const last = arr[arr.length - 1];
    const chars = last.split("");
    const counts = chars.reduce((map, char) => {
      if (!(char in map)) { map[char] = 0; }
      map[char] += 1;
      return map;
    }, {});
    if (counts["("] != counts[")"]) {
      part = last + "/" + part;
      arr.pop();
    }
  }
  return arr.concat(part);
}, [])

the idea is to split on / and then iterate over all parts and for each part that doesn't have an equal number of ( and ) join it to the next part with a / and try again
presumably, as long as the ( and ) are balanced, it should work

I like this algorithm, but given we already have a regular expression which matches named capture groups, I find the approach implemented in this PR feels simpler.  This approach can be considered in the future if we ever need to exclude other matching pairs of characters.

I tested it with the plugin directory endpoints and I can't reproduce the previous errors with your fix. Thank you!


jump to latest version

Is there any chance there is a newer version of this for 6.2.4?

client is no longer actively maintained


How can we specify we want to use BatchedGemm api and also the batch size while running Caffe with CLBLAST Library?

@psyhtest

@abhi1212 I have not followed the very latest developments but I don't think that the OpenCL branch of Caffe supports the batched GEMM API of CLBlast. However, you can still request to process your data using batches. If you are interested, I can tell you how to do this via CK-Caffe.
/cc @cnugteren @naibaf7

@psyhtest , I would love to know how we do that.
But are we referring to the number of images processed in a batch?

Also, @psyhtest we do have a batched Gemm api for Caffe2.

@abhi1212 Please take a look at greentea_math_functions.cpp to see which CLBlast functions are called from Caffe.
You can run something like this to process several images per batch (e.g. 4):
$ ck run program:caffe --env.CK_CAFFE_BATCH_SIZE=4

So, if I understand it correctly, there is no batched version of CLBlast used there right now. Maybe we should see how we can integrate that to get better performance?

Yes, @CNugteren we could combine BatchedGemm of Clblast with caffe and observe the performance.

Currently there's no BatchedGemm for OpenCL Caffe. The three options with OpenCL are subgroup convolutions (by Intel), fused im2col+gemm implementations (LibDNN), which do im2col of a whole batch plus GEMM in one single kernel, and the classical im2col+GEMM, which repeats (im2col+GEMM) N times to do the whole batch.

Wow, that seems interesting, in the classical im2col plus Gemm are you referring to the groups which we have in Caffe?

@abhi1212 No, intel subgroups are a specific technology that their GPUs have.
Hence, Intel Subgropu Convolution is limited to Intel iGPUs, not CPUs.
See here:
https://www.khronos.org/registry/OpenCL/extensions/intel/cl_intel_subgroups.txt

Thanks a lot @naibaf7 , unfortunately I dont have an Intel Gpu, so I can not run Intel subgroup convolutions.
The fused im2col+gemm implementations (LibDNN) does it do all the convolution for a single layer at once? Also, when we use ck caffe with libdnn is the fused convolution default one or we need to specify it?
Also, talking about classical convolution we do it N times for completing a particular batch, so from where do we select this parameter N, I thought it must be the group parameter in Caffe but it seems that it is not used for optimizing Caffe convolution..

@abhi1212 For AMD GPUs you can run LIBDNN convolutions, for nVidia GPUs you can run CUDNN convolutions. Yes LibDNN does the whole convolution at once.
The only GPUs that don't have a good convolution engine yet are all the ones you usally see coming with ARM based CPUs (Mali, Adreno, PowerVR)... this needs fixing.

Thanks @naibaf7, as Nvidia Gpus also support Opencl, cant I run Caffe with Libdnn on Nvidia Gpus?
I have worked with Cudnn in the past wanted to use LIbdnn or Clblast with Caffe for an Nvidia Gpu.
Also, can you please help me with the N parameter, how can we divide an entire batch into small sizes and then do im2col and gemm on it. Where can I find this parameter?

As for CK - it just provides high-level wrappers with JSON API around Caffe to unify building and running across Linux, Windows, MacOS and Android. We expose only a few parameters and leave the rest to the default build system. Current JSON params and associated CMake flags are here:

https://github.com/dividiti/ck-caffe/blob/master/package/lib-caffe-bvlc-opencl-libdnn-clblast-universal/.cm/meta.json
https://github.com/dividiti/ck-caffe/blob/master/package/lib-caffe-bvlc-opencl-libdnn-clblast-universal/scripts.linux/install.sh

Note that you can override CK environment variables from command line with installing this package, i.e.
$ ck install package:lib-caffe-bvlc-opencl-libdnn-clblast-universal --env.USE_CLBLAST=0 --env.DISABLE_DEVICE_HOST_UNIFIED_MEMORY=ON

Thanks a lot @gfursin  and @naibaf7


feat: remove logic for TopologyManager feature gate

What type of PR is this?
/kind feature

What this PR does / why we need it:
Per Feature Gates (removed) , feature gate TopologyManager is default since 1.18, and was removed from 1.29. This PR remove logic for this feature gate.
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 80.468%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
2373

Relevant Lines:
2949

💛  - Coveralls


Can epic2-df support biological replicates?

Dear Sir , I want to use epic2-df  to call diffpeaks and  my each sample has two replicates. It seems that epic2-df  can not support two input Bams for one treatment or control.  Do you have any suggestion for this problem?
Thank you very much!
Best wishes!

No, this was just a port of SICERs functionality. I'm not savvy about the
statistics
On Tue, Sep 6, 2022 at 5:46 AM hdshu @.***> wrote:

Dear Sir , I want to use epic2-df to call diffpeaks and my each sample has
two replicates. It seems that epic2-df can not support two input Bams for
one treatment or control. Do you have any suggestion for this problem?
Thank you very much!
Best wishes!
—
Reply to this email directly, view it on GitHub
https://github.com/biocore-ntnu/epic2/issues/65, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEHURURON2DE3ANCZURUIYTV425AVANCNFSM6AAAAAAQFNXVMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


feat: direct llama.cpp integration

Just a quick follow-up to say it seems to work fine:

I had to change the llama.cpp server port to 8081 to not clash with OpenWebUI (eg: ./server --port 8081 ...).
Then set the OpenAPI base URL to http://<IP_ADDRESS>:8081/v1 and the API Key to not be blank (eg: none) in OpenWebUI settings.

and it seems to be calling the OAI-like API endpoint on the llama.cpp server fine. It wasn't that clear I needed to add the /v1 to the URL and ensure the API Key not be blank though (had to find by trial and error).
The only difference I can see is there is no little "information" icon like there was with Ollama models, but it does seem to be calling the OAI-like API endpoint to get these stats:
{
  "tid": "140627543928832",
  "timestamp":<PHONE_NUMBER>,
  "level": "INFO",
  "function": "print_timings",
  "line": 313,
  "msg": "prompt eval time     =     129.89 ms /    55 tokens (    2.36 ms per token,   423.43 tokens per second)",
  "id_slot": 0,
  "id_task": 13,
  "t_prompt_processing": 129.892,
  "n_prompt_tokens_processed": 55,
  "t_token": 2.3616727272727274,
  "n_tokens_second":<PHONE_NUMBER>0782805
}

I'll report back if I can see any other major differences.

I've used this quite a bit with llama.cpp server now and the only problem I've come across is pressing the stop button doesn't actually disconnect/stop the generation. This was a problem with the Ollama server and was fixed AFAIK:
https://github.com/open-webui/open-webui/issues/1166
https://github.com/open-webui/open-webui/issues/1170
It would be helpful if this could be added to the OpenAI API code too, as otherwise the only way currently to stop runaway LLMs  is to Control-C the running server and restart it.

Another thing that might be helpful would be to add an option to hide the "Modelfiles" and "Prompts" menu options in the left, as these aren't able to be used with the OpenAI API and just add clutter.

@jukofyork I'll start working on this feature after #665, we should strive to keep all the core features.

Small update: Stop generation button is still an issue

@DenisSergeevitch that is unrelated to the issue being discussed here. Let's keep discussion of the stop generation function here:

#1568

I've completely ditched Ollama and just moved over to the llama.cpp server and just want to say thanks as it's working really smoothly with Open-WebUI! 👍

@jukofyork @DenisSergeevitch
Correct me if I'm wrong but, stop generation button not actually stopping is only an issue when running LLMs with Ollama using CPU only. Could anyone confirm this?

Sorry for the delay , i have just try the stop button and now it's okay , the stop button stop all thread "generating ollama response" and  the cpu are not used. Thanks a lot for this patch !

I confirm the issue it is with ollama.cpp using LLMs CPU only, today i have try with the latest version and the stop button work , this is top all thread ollama can be launch.
Thanks all for your work its appreciated


[BUG] Warning while resolving dependencies

Hi Bert,
I noticed that there is a warning:
Resolving wemos_d1_mini32 dependencies... Library Manager: Installing bertmelis/espMqttClient @ ^1.4.0 Unpacking Library Manager<EMAIL_ADDRESS>has been installed! Library Manager: Resolving dependencies... Library Manager: Installing AsyncTCP @ >=1.1.1 Library Manager: Warning! More than one package has been found by AsyncTCP @ >=1.1.1 requirements: Library Manager:  -<EMAIL_ADDRESS>Library Manager:  -<EMAIL_ADDRESS>Library Manager:  -<EMAIL_ADDRESS>Library Manager: Please specify detailed REQUIREMENTS using package owner and version (shown above) to avoid name conflicts Unpacking Library Manager<EMAIL_ADDRESS>has been installed!
This may not be a real bug, but I wanted to at least point it out.

When registering a package in the platformio registry, you get a warning when you are registering a library with an existing name.
I'll update the requirements with the package owner. I'm not going to create a new release for this fix though.

Solved in https://github.com/bertmelis/espMqttClient/commit/eea0d3df43946c99f9788e049480eca123e61bdd
I suppose this is only a warning and not a showstopping error.


fix: fix security issues

Also updates release workflow to use node 16.x.

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat(ui): Argo CD deep link in Promotion lists

fixes https://github.com/akuity/kargo/issues/3123

@rpelczar this is hypothetically "new plugin" that we introduced in previous PR. Could you review please?


implement tcp proxy service

What does this PR do (include background context, if relevant)?
An implementation of the TCPProxyService. There's some stuff left to do and test cases to add.
Using the Secretless logger as the primary means for error handling is a TODO

@doodlesbykumbi do you know why the k8s tests are failing in this branch? I don't think you made any changes that should affect this ...


Bad positioning of tooltips

More of an edge case but nonetheless happening in an app I am currently developing. This scenario only happens if a scroll bar is present and the element in question has a translate applied via CSS.
See example here (hover over red box)
Something like this would theoretically fix the issue (I think)
let rect = el.getBoundingClientRect();
let left = rect.left + window.pageXOffset;
let top = rect.top + window.pageYOffset;

// now we have a more accurate representation of the current top / left coords

Interesting bug. I can confirm it is happening due to the transform, but I don't understand why. This should be addressed since it could be a pretty common thing being done now with the recent push for animations by the web.

TIL!
The observed behavior is correct as per CSS spec:

For elements whose layout is governed by the CSS box model, any value other than none for the transform results in the creation of both a stacking context and a containing block. The object acts as a containing block for fixed positioned descendants.

Our tooltips are positioned using position: fixed. That means, by applying a transform – even if it is a NOP – you moved the origin for fixed positioning.
The easy fix is to move the tooltip to another container (or body).

Hm, very interesting. At least we know now and can point people here if it comes up again. Thanks for doing the research @surma!


Add Database support for Timer Use case.

Add database support for timer use case to save and retrieve preferred pomodoro work and rest intervals.

Database support for Timer Use Case has been added in PR #43 .


remove undefined reference

There is an undefined reference in the bundle.js to psModule.

Wasn’t this resolved by https://github.com/ethul/purs-loader/pull/119?

@cyrilfretlink Yes, we should probably close this one at this point. Thanks.


Reorganize handleSyncOp

Signed-off-by: Avi Deitcher<EMAIL_ADDRESS>This PR does several things to reorganize pkg/pillar/cmd/downloader/. The primary goal is to simplify the files and structure so that it will be easier to inject OCI registry downloading of artifacts for ECIs, while also standardizing how we download OCI images (currently for rkt, could be for runx or other runtimes).
This is not complete, but a good start. Most of it is:

separate a lot of downloader.go's single 2000-line file into several files:

syncOp.go - the primary handleSyncOp() and handleSyncOpResponse()
dns.go - the DNS handlers
rkt.go - all of the rkt funcs, so that the only reference to it elsewhere is in handleSyncOp() with a single call to rkt fetch

status.go - create an interface and implementation to pass to handleSyncOp(), so that it is ignorant of status.Progress or publishDownloaderStatus(), and instead just has an interface whose impl it can call st.Progress(pct) so it can update how much it is doing. This will make it easier to abstract out, for testing or using outside of pubsub for local downloads
restructured a lot of handleSyncOp() to unify it, move some switch statements outside of the for loop, unified call, easier to understand.

The last two involve some logic change, so should be reviewed carefully. I don't think I missed anything, but that easily could mean I made some real mistakes.
I would like to break it up further, but this already helps; downloader.go is down in size by half, and I can see very clearly where to do both of the tasks I want to do:

add pulling ECIs from an OCI registry
restructure how rkt pulls images

I addressed the issues you raised. Some punted on just so we can get the restructure in place quickly at the current level (as a minimum), some addressed directly, see the comments.
The other issue you raised is:

can add some go unit tests for some of these Smaller routines

No objection, but again, let's separate concerns. First break it out as is, then improve it in other PRs. The other reason to defer is that the funcs are somewhat tightly interwoven; that status/Progress() one is a good example. We need a few more of those to make testing easier.

Also, we need to do more teasing out of these; downloader.go remains 1100+ lines. But it is a start.

@rvs or @nordmark: Kalyan is good with it. Let’s get it merged in.

@kalyan-nidumolu: can you open two issues around those two points you raised above, so it doesn’t slip through in the future?

How odd. yetus failed with the odd message:

Root in master failed
Artifact not found

Urgh. That keeps happening. I’ll update it (again), and we need to get it merged in as soon as possible after that so it doesn’t happen again.


clojure: <IP_ADDRESS>7 -> <IP_ADDRESS>0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for clojure is: "A Lisp dialect for the JVM"
meta.homepage for clojure is: "https://clojure.org/"
meta.changelog for clojure is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/7aiynh1rrcsbrgcw2wax86zkcggakfai-clojure-<IP_ADDRESS>0/bin/.clojure-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/7aiynh1rrcsbrgcw2wax86zkcggakfai-clojure-<IP_ADDRESS>0/bin/clj had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/7aiynh1rrcsbrgcw2wax86zkcggakfai-clojure-<IP_ADDRESS>0/bin/.clj-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/7aiynh1rrcsbrgcw2wax86zkcggakfai-clojure-<IP_ADDRESS>0/bin/clojure had a zero exit code or showed the expected version
0 of 4 passed binary check by having a zero exit code.
0 of 4 passed binary check by having the new version present in output.
found <IP_ADDRESS>0 with grep in /nix/store/7aiynh1rrcsbrgcw2wax86zkcggakfai-clojure-<IP_ADDRESS>0
found <IP_ADDRESS>0 in filename of file in /nix/store/7aiynh1rrcsbrgcw2wax86zkcggakfai-clojure-<IP_ADDRESS>0

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

3 package rebuild(s)

2 x86_64-linux rebuild(s)
3 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
clojure
lumo
obb

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7aiynh1rrcsbrgcw2wax86zkcggakfai-clojure-<IP_ADDRESS>0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A clojure https://github.com/r-ryantm/nixpkgs/archive/e4e8a630d72247e6f8e35bb8ec97170e66d1ec31.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7aiynh1rrcsbrgcw2wax86zkcggakfai-clojure-<IP_ADDRESS>0
ls -la /nix/store/7aiynh1rrcsbrgcw2wax86zkcggakfai-clojure-<IP_ADDRESS>0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

clojure
lumo

Maintainer pings
cc @jlesquembre @thiagokokada for testing.

Result of nixpkgs-review pr 166218 run on x86_64-darwin 1

2 packages failed to build:

lumo
obb

1 package built:

clojure

Same as #165870. So LGTM.


Summaries at the end of lectures

also at end of sections before labs

[ ] RStudio
[ ] Reproducibility
[ ] Basic R
[ ] Data IO
[ ] Subsetting
[ ] Summarization
[ ] Data classes
[ ] Data cleaning
[ ] Manipulating
[ ] Esquisse
[ ] Data viz
[ ] factors
[ ] Statistics
[ ] Functions

I am making summaries at the end of sections before each lab

also at end of sections before labs

@avahoffman do we not like this practice? I thought it would be helpful for the students to perform the labs right afterwards. I will skip this for the rest of my lectures, but we can decide if we want to not do this for the future... or we could have a final summary as well that covers everything

oh okay, missed that part! Will add :)

oh ok! Only if you like the idea!

Summaries before each lab:

[ ] Intro
[ ] RStudio
[ ] Reproducibility
[ ] Basic R
[ ] Data IO
[ ] Subsetting
[ ] Summarization
[ ] Data classes
[ ] Data cleaning
[ ] Manipulating
[ ] Esquisse
[ ] Data viz
[ ] factors
[ ] Statistics
[ ] Functions

Closing this in favor of #343  :)


industrial_moveit: 0.1.0-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository industrial_moveit to 0.1.0-0:

upstream repository: https://github.com/ros-industrial/industrial_moveit.git
release repository: https://github.com/ros-industrial-release/industrial_moveit-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.24
previous version for package: null

constrained_ik
* Initial release
* Contributors: Jeremy Zoss, Levi Armstrong, Jonathan W Meyer, Dan Solomon

industrial_collision_detection
* Initial release
* Contributors: Levi H Armstrong, Jorge Nicho

industrial_moveit
* Initial release
* Contributors: Shaun Edwards, Dan Solomon

industrial_moveit_benchmarking
* Initial release
* Contributors: Jonathan Meyer, Levi Armstrong, Jorge Nicho

stomp_core
* Initial release
* Contributors: Levi H Armstrong, Jorge Nicho

stomp_moveit
* Initial release
* Contributors: Jonathan Meyer, Levi Armstrong, Jorge Nicho

stomp_plugins
* Initial release
* Contributors: Jorge Nicho

stomp_test_kr210_moveit_config
* Initial release
* Contributors: Jonathan Meyer, Levi Armstrong, Jorge Nicho

stomp_test_support
* Initial release
* Contributors: Levi Armstrong, Jorge Nicho

@dirk-thomas  thanks

@dirk-thomas it looks like the build failed, could you provide some guidance on how I can address this?

@jrgnicho Please post a link to the failing job, the relevant error message and anything you have investigated already.

Here is the link
The only thing that stands out to me is the eigen dependency issue
-- checking for module 'eigen3'
--   package 'eigen3' not found
CMake Error at /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:108 (message):
  Could NOT find Eigen (missing: EIGEN_INCLUDE_DIR)

The stomp_core packages tried to find_package Eigen which isn't found. The buildfarm only installs the dependencies which you have declared in your manifest and it looks like this package doesn't declare a dependency on eigen in its manifest: https://github.com/ros-industrial/industrial_moveit/blob/0.1.0/stomp_core/package.xml

Also, note that Eigen is a bit tricky to get right on all of the different Ubuntu/ROS combinations.  Please take a look at this commit: https://github.com/ros/eigen_stl_containers/commit/22ae7a2728bbebbe3ff859f84c90a9d575e00d97 , and the two follow-up commits, to get an idea of how to find Eigen in all permutations.

@dirk-thomas  OK thanks, I'll add the dependency to the manifest then.  @clalancette  are these steps needed for indigo?

The snippet of code I linked to above is necessary if you want the same CMakeLists.txt to work across Indigo, Jade, and Kinetic.  If you have different branches for each of the ROS releases, then you can do something simpler on a per-release basis.

@clalancette  got it, thank you

@dirk-thomas the Eigen dependency issue has been addressed in the indigo branch

You might want to look into other job failures too before trying another release, e.g. http://build.ros.org/view/Idev/job/Idev__industrial_moveit__ubuntu_trusty_amd64/1/console

@dirk-thomas the build farm caught another error related the the Eigen  dependency on saucy.  This occurred even after I made the changes suggested by @clalancette  in industrial_moveit and the build had succeeded for trusty.  See the related error log here. Could you please advice?

So, looking through the log quickly, it looks like libeigen3-dev (which is the eigen library on saucy) did not get installed into the Docker container.  Indeed, if I forcefully remove that package from my local saucy installation, I get the same error message.  So that is the immediate cause of the failure.  However, looking at your package.xml, it seems to have the dependencies listed correctly, so I'm not quite sure why libeigen3-dev didn't get installed.  Anyone else have any ideas on why that might have happened?

Please see my previous comment which points out that your package manifest doesn't declare the necessary dependency on eigen.

@dirk-thomas  I see, I added the eigen dependency to my indigo branch but never incorporated those changes into the 0.1.0 tag. Ill address that, thanks

You shouldn't change the existing version 0.1.0 but create a new patch release 0.1.1 instead.

@dirk-thomas @clalancette , I created the new release here.  Thanks

Should I create a new PR with the updated release number 0.1.1?

Yes, bloom can do that for you when you do the these.

OK, then I'll rerun the bloom procedure again.  Thanks


✨(dropdown) add new layout component "dropdown"

Purpose
A need for a dropdown component emerge from language menu which is
required to be a dropdown. Since we don't have any Framework
component available, we need to implement it first.
Proposal
This commit adds this new component including the library "dropmic"
with a Javascript and Sass sources both modified to fit our
requirements (BEM names). A dropdown sample is available from
Styleguide page.
Since dropdown component has been added, we can integrate the language menu
with it and as required add it also in header.
This update also some theme properties related from header and footer groups to
include their own CTA dropdown colors, update styleguide and language menu.

Nice! i started looking into version 2 of richie this week. I was thinking that a dropdown language chooser would be a nice to have. I'm really happy to see you guys also thought the same 😄

For coherence, we want to stick to React for js components. This PR is closed in favor of https://github.com/openfun/richie/pull/1107.


Make archiver plugable

Use https://github.com/gdiepen/python_plugin_example to enable plugins
for archivers (rar, zip, folder) this makes it easier to add new
archivers and possible to extend the available archivers without
ComicTagger needing to be updated
Caveats:

I do not believe pyinstaller includes the entire stdlib
When using pyinstaller any third-party libraries will need to be
included in the plugin folder

Should also define plugin folders for each OS


Setting up softlayer infrastructure

When looking at the the manifest in this page, I noticed that I needed to replace the networkVlan IDs. Currently I am using a infrastructure that has already been setup for me and was able to figure out what was being requested. However, if there wasn't an infrastructure already provided for me, then I wouldn't know what needed to be provisioned, like number of IP address for a cf deployment. Is there any documentation on setting up the Softlayer infrastructure itself? For example, the aws environment setup goes through everything that is needed with pictures.

@DanLavine  I think you might try to find some docs like this -> https://bosh.io/docs/init-softlayer.html

Let's make sure everything is up to date.
@gu-bin please take a look when back from CNY. Best,
max

Doc https://github.com/cloudfoundry/bosh-softlayer-cpi/blob/master/docs/bosh-init-usage.md has been deleted via PR #202


Access Denied while editing block

Steps to reproduce :

Add a new File block to a page
Select the file and enter the Link Text
Publish the page
Enter the Edit Mode on this page
Edit the file block and empty the field link text
When you save the first time, you have the normal error, but when you save another time, the following error appears :

Error
An unexpected error occurred. Access Denied

When showing the debug error output I have the following in the console :

Exception: Access Denied in file concrete/controllers/backend/user_interface/block.php on line 55

This has been tested in 8.3.3a1

This is because editing the block when it's approved actually causes a new version of the block to be created on the new version of the page. Then, the next time we do the submit, we're still passing the old block ID to the form submission.
I bet if we send back the block ID in the error response, and update the hidden bID input field, we could fix this.

editing the block when it's approved actually causes a new version of the block to be created

Why is the new Block Version created when we open the edit Dialog in the first place? - Does it need to be that way? - Isn't that the underlaying issue here?
I think it only needs to create a new Block Version when validation passes. - As long as validation on a block Editing operation fails the block does not change. - So why creating a new Block Version?
That way the Error could be avoided without having to build some sort of "workaround" to update the blockID in the DOM from the validation Error message.


Hyperlinks

Hi,
I added support for CTRL+Click navigation, as mentioned in issue: Improve classes navigation functionality #28. Also, when you move the mouse over a valid link (with CTRL pressed), a short descripction appears in the status bar about the destination of the link. Types, Methods and Fields can be navigated, local variables not.
Your Enable Unicode Replacement functionality was tricky to merge, because originally it changed the decompiled code after get from decompiler, and so the java references Start and End character positions has beed modified. Luckily, now this functionality is a part of Procyon, so it can do replacement for us during decompilation.
Now, Save and Save All also changes it's output if Enable Unicode Replacement checked (in this case generates UTF-8 output), and saves even chinese characters (hyperlinks also works with chinese characters present in java reference names, I tried it, but only if Enable Unicode Replacement checked).
I want to go on with Navigation History and Recent Files features, as soon as I have time.
Regards,
Zoltan Erdei

Looks good I've went ahead and pulled.


Interactive window with Matplotlib and notebook option

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur
(in Jupyter notebook in vscode)

import matplotlib.pyplot as plt
%matplotlib notebook
plt.imshow(some_2d_data)

Actual behavior
matplotlib_Jupyter_VSCode_interactive.txt
Expected behavior
Give an interactive matplotlib  plot

Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running: Local
Extension version: 2020.4.74986
VS Code version: 1.44.2
Python and/or Anaconda version: 3.8.1
OS: Windows

Developer Tools Console Output
Developer Tools Console Output.log

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

This is expected unless you install the matplotlib extension. See the discussion here:
https://stackoverflow.com/questions/51922480/javascript-error-ipython-is-not-defined-in-jupyterlab
You also need to use the %matplotlib widget instead of notebook

This is expected unless you install the matplotlib extension. See the discussion here:
https://stackoverflow.com/questions/51922480/javascript-error-ipython-is-not-defined-in-jupyterlab
You also need to use %matplotlib widget instead of %matplotlib notebook

getting the following warning when using %matplotlib widget
Warning: Cannot change to a different GUI toolkit: widget. Using notebook instead.
and the error is not resolved

You have to restart the kernel first.

You have to restart the kernel first.

thanks for that. but this is the output now. what should I do?

What happens if you run the cell again? Sometimes matplotlib can be buggy and not output something on the first try.
If that doesn't work, can you hit 'ctrl+shift+p', and run the 'Developer : Open Webview Developer Tools' command. It should open a chrome debug window. The console tab there may also give some clue as to what went wrong.

What happens if you run the cell again? Sometimes matplotlib can be buggy and not output something on the first try.
If that doesn't work, can you hit 'ctrl+shift+p', and run the 'Developer : Open Webview Developer Tools' command. It should open a chrome debug window. The console tab there may also give some clue as to what went wrong.

Restarted the PC. Its working now. Thanks for the help

is there and reason that %matplotlib notebook is not supported?

It must do something that is jupyter specific. It doesn't work for us.


VG-6520 - task output format undefined

(also fixes VG-6516, same issue)

Codecov Report

Merging #172 into master will decrease coverage by 0.03%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   71.19%   71.16%   -0.04%
==========================================
  Files         246      246
  Lines       15536    15550      +14
  Branches     1658     1660       +2
==========================================
+ Hits        11061    11066       +5
- Misses       4475     4484       +9

Impacted Files
Coverage Δ

app/common/simple-search/simple-search-module.js
100% <ø> (ø)
:arrow_up:

app/src/taskrunner/params/template-service.js
95.74% <100%> (ø)
:arrow_up:

app/src/taskrunner/params/param-control.js
70.09% <25%> (-5.7%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35233c3...6efb0b4. Read the comment docs.


Console output cleared with CTRL+L pops back into view when you start to type into the console.

This problem appeared after the latest windows update was performed on my computer. Problem also appeared on PowerShell 5.1. Here is a tiny GIF which visualizes the problem.

Steps to reproduce
# Try typing some basic command e.g.
> git log

# Then try clearing the console screen with CTRL+L
> [CTRL+L]

# Now console clears (or rather moves the previous output outside our field of view),
# but if we start typing again everything that was cleared gets scrolled back down
# into view (incredibly annoying).
> some other command

Expected behavior
Console stays cleared.
Actual behavior
If I start typing new command after clearing the console, old console output pops back into the view.
Environment data

Name                           Value
----                           -----
PSVersion                      6.1.2
PSEdition                      Core
GitCommitId                    6.1.2
OS                             Microsoft Windows 10.0.17763
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

This is a duplicate of Microsoft/console#302, for which there should be a fix in the current Insiders' Fast releases.

I can not repo with latest 7.0-Preview4 build.


How to use OpenIdConnect with ASP.NET Identity?

I am writing a new MVC 6 app and cannot find a way to use ASP.NET Identity along with OpenIdConnect as an external provider (same way as Google or Twitter examples). Does anybody know if this is even possible? I want to be able to create a local account for each user and store his settings but provide a way for them to sign on using OpenId Connect.

That's not what we're currently targeting OpenID connect at. As we we get closer to release we could examine treating it like any other social auth, but the templates and documentation, such as they are, are focusing on using it for authenticating to Azure Active Directory.

Thanks for the super-fast response. Will using OAuth authentication work as a social authentication?

It should do yes, I just can't point you at a sample for it :)

Oath sample is here https://github.com/aspnet/Security/blob/dev/samples/SocialSample/Startup.cs#L51

@blowdart I hope you consider treating openID connect as social auth in the future. For now, you can close the issue.


Linting fixes

Some linting fixes for YAML and Python

And some for the shell scripts (done using shellcheck and bashate)

Awesome, thank you!


Training issues on the Cityscapes dataset

First of all, thank you for your excellent work.
When I trained using LiteMono on the Cityscapes dataset, I found that its performance on this model was not very satisfactory. Do you have any related training results? I am not yet sure if it is an issue with code modifications or with the model itself. I have uploaded the results on the Cityscapes dataset below:

Hi, what PyTorch version did you use for training?

I'm using PyTorch version 2.3.0 with CUDA version cu121. My model's performance on the KITTI dataset is:

I'm using PyTorch version 2.3.0 with CUDA version cu121. My model's performance on the KITTI dataset is:

Many users have reported poor training results when they use the newer versions. Can you try PyTorch 1.7.1 or 1.12.1?

Many users have reported poor training results when they use the newer versions. Can you try PyTorch 1.7.1 or 1.12.1? But, your training on KITTI is normal.

Thank you for your reply. I will try using the dependencies you provided. Additionally, I would like to know if you have trained on the Cityscapes dataset, and how the performance was?

No. I didn't train on Cityscapes.

No. I didn't train on Cityscapes.

Thank you again for your response. I found some discrepancies between my evaluation code and the existing evaluation method. After making adjustments, the optimal results obtained are as follows:

I see. This seems better!


Tantivy should work without a store/fieldnorm/position file

Currently tantivy creates empty file even if the schema does not requires them (e.g. no field in the schema is stored for instance). The segment reader also needlessly opens and mmaps these files. jwolfe lost a bit of time when writing a converter from a different search index to tantivy.

Hi! Is this task up to date? I didn't find any empty generated files when I ran the tests.
Or did I look in the wrong place? :-)

Hi! Is there anything I can do to help with this problem?
Where is this file created?


Supporting Vite 6

So far so good. I tested it manually (on a project) and I ran the tests in this repo.
Some log messages have changed and the build command seem to be checking types in node_modules, so I disabled it with skipLibCheck.
Currently tested against v6.0.0-alpha.15.

Hey thanks for this! I've done some changes in #208 to help fix the tests, the change in connected. message will be reverted soon.
Why are you currently testing Vite 6? Have you any interest in the new environment API?
For info it would not be release soon, but if you have any feedback on this you can join the discord!

Why are you currently testing Vite 6?

I like it when plugins for an important software are prepared for the major update of that software in advance.
I want this plugin to be ready when Vite 6 released, so that it would not be a blocker for migrating to Vite 6, @ArnaudBarre

The following workspace might require its own earlier version of rollup, because the one coming from vite (4.21.3) is not declared as a compatible one with @mdx-js/rollup — the latest version of which (3.0.1) is currently installed there needs v3 max. However, it still works anyway.
 WARN  Issues with peer dependencies found
playground/mdx
└─┬ @mdx-js/rollup 3.0.1
  └─┬ @rollup/pluginutils 5.0.2
    └── ✕ unmet peer<EMAIL_ADDRESS>found 4.21.3

@ArnaudBarre ,
Please review. It's time :)


fix typo OSCP to OCSP

Correct word is OCSP (as shown in the title just above).

@jbpaux : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good. Thanks for the typo fix @jbpaux.


Enable extra warnings

These I believe are set to the default with CMake (maybe not pedantic).

@hughbe,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@hughbe ok so I looked at the Linux build and there are two classes of warnings left that get triggered by pedantic:
bmpcodec.c:1186:4: error: ISO C forbids conversion of object pointer to function pointer type [-Werror=pedantic]
00:21:03    ((PutBytesDelegate)(pointer))(data, size);
00:21:03     ^
00:21:03 bmpcodec.c: In function 'gdip_save_bmp_image_to_stream_delegate':

I can't wrap my head around these at the moment, any ideas?
The other one are warnings like:
testpen.c: In function 'test_setPenMode':
testpen.c:1301:2: error: overflow in implicit constant conversion [-Werror=overflow]
  assertEqualInt (mode, (PenAlignment)(PenAlignmentCenter - 1));
  ^

That one makes more sense to me and is fixed by removing the cast to PenAlignment.
Do you think we should look into this further or is it "too pedantic" at this point? 😄
If I fix the overflow warnings and uncomment the locations where the *BytesDelegate are used then it compiles to the end at least.

I agree. Pedantic is certainly unecessary for the unit tests. For the product code it may be good. But it looks unecessary. I reverted this change but fixed some of the warnings pedantic wuld have found.


Update posture report unmarshal

Unmarshaling the targetMetadata field is needed to determine the context of the scan

@dwertent no issue - the thing is that if we want to create some login in the Event Receiver based on these fields we need to unmarshal them as well (not possible with this code)


Feature/list update

Coverage remained the same at 99.038% when pulling 5c843053707707b4a00becbb5e5a74751cc2e0c0 on feature/list-update into 4643cdb0311b4ba1a13de5eca5563b06dd07722c on master.

Coverage remained the same at 99.038% when pulling 5c843053707707b4a00becbb5e5a74751cc2e0c0 on feature/list-update into 4643cdb0311b4ba1a13de5eca5563b06dd07722c on master.


Service now waits for sample upload message before transitioning to READY_FOR_REVIEW.

change the sample service to create a sample summary straight away, kick off the upload in the background and return immediately
change the collection exercise service to create a sample link immediately but only activate it when it receives a message on the sample-outbound-exchange with routing key Sample.SampleUploadFinished.binding
change response-operations-ui to display the state of the upload and any successful completion or error

 P2 Load sample timesout and doesn't generate samplelink record in collectionexercise

You seem to have some unused imports in your code. But otherwise looks good.

Codecov Report

Merging #61 into master will decrease coverage by 0.11%.
The diff coverage is 47.36%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   54.66%   54.54%   -0.12%
==========================================
  Files          34       35       +1
  Lines        1233     1265      +32
  Branches      143      147       +4
==========================================
+ Hits          674      690      +16
- Misses        520      534      +14
- Partials       39       41       +2

Impacted Files
Coverage Δ

...ction/exercise/service/impl/SampleServiceImpl.java
0% <0%> (ø)
:arrow_up:

...se/message/impl/SampleUploadedInboundReceiver.java
0% <0%> (ø)

...llectionExerciseStateTransitionManagerFactory.java
100% <100%> (ø)
:arrow_up:

...se/service/impl/CollectionExerciseServiceImpl.java
59.14% <76.92%> (+2.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0c8da...511c023. Read the comment docs.


Clear search parameters

Closes #28
I went the route of just clearing all search parameters — we already did this for Gauntlet-specific parameters, to avoid repeated toasts. It doesn't seem like we've used search parameters for anything other than those toasts and for data submission, but it's probably best if I do some testing and see if it breaks anything.

I knew it felt too good to be true; turns out, I forgot WA admit links include URL parameters (they work the first time, but not if the user reloads).


Different colors for different metrics types [JS]

E.g. onchain red, github green, NPM yellow or smth. Just so I easily understand that these are different
Options are here

@ryscheng can we pass a fontColor variable to the BarList component? The default color doesn't work well with lighter palettes.
Related: can we apply toLocaleString to the BarList values ?

Done here
https://github.com/opensource-observer/oso/pull/526
This will hard-code us to both:

always use light mode so text colors show up right (there's no way to set a custom font color via prop atm)
use toLocaleString for formatting numbers

Oh, actually I'll leave it to you @ccerv1 to change the colors in Plasmic once this deploys. watch it on vercel

Yep, done! Thank you!


Tracking Issue for update --precise with pre-release

Summary
RFC: #3493
Original issue: #12579
Implementation: https://github.com/rust-lang/cargo/pull/13626
Documentation: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#precise-pre-release
Extends cargo update --precise to allow pre-release versions, even if the dependency declarations do not specify a pre-release.
Unresolved Issues

[ ] Upstream pre-release match logic to semver crate
[ ] Upper bound semantic. See the unresolved questions in the RFC.

Future Extensions
No response
About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Since https://github.com/rust-lang/cargo/pull/13296 had merged, i think i can lend a hand to continue.
Just in case I forgot, I was gonna @rustbot claim.

I believe @eopb was planning on working on this.  I'd recommend coordinating with them

Yes, I'm still intending to work on this. If you'd like to help @linyihai, please reach out to me on zulip (under the same username as here).
I'm sure we can work together. The last thing I'd want to do is to slow things down by trying to hog this tracking issue.

FYI，I recently tried to implement an MVP based on RFC content.

https://github.com/rust-lang/cargo/pull/14013 shows the current implementation is a bit buggy, and there are upper bound semantic issues not yet resolved. See these test cases:
https://github.com/rust-lang/cargo/blob/050f88c3316178a064619b79ef9f56f0583488cc/src/cargo/util/semver_ext.rs#L204-L233
It is technically possible to fix them inside cargo. However to do that we'll need to duplicate the logic in semver crate. I am in the team of upstreaming things to semver.

Yes, The semver crate only supports to compare prerelease with prerelease if I remember correct，
https://docs.rs/semver/latest/src/semver/eval.rs.html#14-21
 // If a version has a prerelease tag (for example, 1.2.3-alpha.3) then it
    // will only be allowed to satisfy req if at least one comparator with the
    // same major.minor.patch also has a prerelease tag.
    for cmp in &req.comparators {
        if pre_is_compatible(cmp, ver) {
            return true;
        }
    }

So we need to add the pre tag to the version_req in order to use the semver crate,  like RFC writes:
So before,

1.2.3  -> ^1.2.3 -> >=1.2.3, <2.0.0 (with implicit holes excluding pre-release versions)
would become

1.2.3  -> ^1.2.3 -> >=1.2.3, <2.0.0-0

After some experiments on semver PR, I found something interesting,

the semver crate matches implementaion may be based on node semver compatibility.  the semver matches follow the limit  if the version has a prerelease tag then its MAJOR.MINOR.PATCH must be same with the VersionReq at least once,  and another issuse is it can't handle partial VersionReq
By removing the limit  and handle the partial VersionReq, the first proposed semantic  came out.  The prerelease tag padding logic has some controversial, like '<4.2', we chose pading it to '<4.2.0' not '<4.2.0-0' .

By look into the node semver compatibility semantic, it offers includePrerelease=true to remove the limit, then I add the test and try to implement it in semver, see https://github.com/dtolnay/semver/pull/321#issuecomment-2249961396. The result is the node semver compatibility implement ation also covers the semantic proposed by https://github.com/rust-lang/rfcs/pull/3493.


Can't run achd - assertion failed

Hello team, I was trying to run achd -testnet but got this error:
achievecoin@node:~/src/AchieveCoin-0.1-beta/src$ ./achd -regtest
achd: crypto/common.h:138: int init_and_check_sodium(): Assertion `crypto_sign_verify_detached(sig, message, sizeof(message), pk) != 0' failed.
Aborted (core dumped)

It happens for prebuild binaries and for binaries that I compile. System is Ubuntu 16.04.02, x64, kernel is  4.4.0-64-generic.
What should I do to run achd and do some testing?
Thanks!

This error could mean you need a newer version of libsodium (at least 1.0.13).
Try this:
wget http://de.archive.ubuntu.com/ubuntu/pool/universe/libs/libsodium/libsodium-dev_1.0.13-1_amd64.deb
wget http://de.archive.ubuntu.com/ubuntu/pool/universe/libs/libsodium/libsodium18_1.0.13-1_amd64.deb
sudo dpkg -i libsodium*deb

Yeah, it is OK now, thanks!


Play Rrhar'il

Seems this is still a draft.
The added shell scripts are used at the moment. So pls only submit the grub file only


Batch whisper inference

Whisper model has limitation of 30s.
Can you integrate batch inference into sherpa?
I would like to use it along with the diarization.
I'm still not sure how exactly it possible to batch it but I have some idea:
use silero-vad and aggregate segments into 30s (if there's smaller)
add silence between.
using word timestamps, estimate where's the silence added and reconstruct back the segments text.
https://github.com/thewh1teagle/loud.cpp/issues/11

https://github.com/m-bain/whisperX?tab=readme-ov-file#whisperx

If you are using CPU， it won't make much difference in speed.

If you are using CPU， it won't make much difference in speed.

If we process speaker sentences of 5 seconds each time it will process it as 30 seconds, no?
Also GPU is very important with whisper because it's heavy model and that makes much difference

If we process speaker sentences of 5 seconds each time it will process it as 30 seconds, no?

I suggest that you have a look at the Moonshine models. It does not require padding.

I suggest that you have a look at the Moonshine models. It does not require padding.

unfortunately it supports only English


An academic issues on your paper

In the video encoder part, the output is {v_cls, v_1, ..., v_k} (so the dimension is (k+1)*d)
therefore, the dimension of multi-modal video-text encoder is (k+N_t+1)*d
but according to paper: you claim that the dimension of multi-modal video-text encoder is  (N_v+N_t+1)*d
I'm confused about this...

Thanks for well spotting. There seems to be indeed a typo here: the multi-modal encoder output should be (K + N_t + 1), with K the number of patches, N_T the number of tokens and 1 for class token.
Thanks.

Thanks for your reply！


Still need to attach directory when there is already an Azure AD attached directory if opening the direct link of one file which has a parent directory

Storage Explorer Version: 1.23.0-dev
Build Number: 20220212.2
Branch: main
Platform/OS: Windows 10/macOS Monterey 12.2
How Found: From running test case
Regression From: Not a regression
Steps to Reproduce

Expand one ADLS Gen2 storage account -> Blob Containers.
Create a blob container -> Add the rbac role 'Storage Blob Data Contributor' then assign to one azure account.
Create a folder in the blob container -> Upload one file to the folder -> Attach the folder via Azure AD.
Right click the file -> Copy its direct link.
Open the direct link -> Observe the open direct link dialog.
Check whether no need to attach directory.

Expected Experience
No need to attach directory.
Actual Experience
Still need to attach directory.

@v-xianya I have merged a fix for this into main. However, at this time, detecting that an attachment already exists only works for new attachments going forward from here.

Verified this issue on the build main/20220216.1. Fixed.


Add she-bang to the top of starfish.py

This allows starfish to be run, rather than running python starfish.
Test:
[czipa1osx186 (.venv)]:~/microscopy/starfish:tonytung-env> pip install -e .
Obtaining file:///Users/ttung/microscopy/starfish
Installing collected packages: starfish
  Found existing installation: starfish 0.0.1
    Uninstalling starfish-0.0.1:
      Successfully uninstalled starfish-0.0.1
  Running setup.py develop for starfish
Successfully installed starfish
[czipa1osx186 (.venv)]:~/microscopy/starfish:tonytung-env> starfish
Usage: starfish [OPTIONS] COMMAND [ARGS]...

Options:
  --help  Show this message and exit.

Commands:
  decode
  detect_spots
  filter
  register
  segment
  show
[czipa1osx186 (.venv)]:~/microscopy/starfish:tonytung-env>

lgtm


exclude empty result metric for $consumer_group 'All'

Grafana Dashboard: If no specific 'Consumer Group' is selected (All) then only include metrics where 'group' label is present.
Currently there's a metric included and listed without a group (also not clear where this is coming from and why it's sometimes indicating a lag?!?)
Not sure if anyone else / everyone also has got this issue?

Hi @hartmut-co-uk,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
https://www.lightbend.com/contribute/cla

CLA must be signed to accept PRs. I accomodated this change in another PR.


Load nested set by default in Laravel Relation definition

Thanks so much for taking this project over!!
Is there a way to eager load a nested relationship using Laravel's relationship definitions instead of calling ->toHierarchy()?
i.e.
class Post extends Model
{
    public function categories()
    {
        return $this->hasManyRootsWithDescendants(Category::class);
    }
}

to return a nested set of categories
If this is a feature request I'd be glad to take a look Or is there a better way to load a nested set by default?

I like this idea but I envisage it being a fair bit of work. Happy for someone to look in to it, or I'll take a look if (when) I get time.


[BUG]: Judge receiving pending task for response

Describe the bug
Judge receiving pending task for response
To Reproduce
https://github.com/user-attachments/assets/aa59df80-53d4-4787-a8a6-ecee8c5e1498

This looks as expected in uat env

Hi Team User roles has been updated @rajeshcherukumalli  Please check once on All the Envs

Hi @maruthiPhanendra,
BUG not resolved in QA.
When Judge orders Advocate for Mandatory Submission, Pending Task is shown for Judge shown in the image.
Expected behaviour
Pending Task should not be shown to Judge.

Not resolved in QA
CC : @manimaarans, @Ramu-kandimalla
Refer screenshot

Issue resolved in QA:

CC: @rajeshcherukumalli @Ramu-kandimalla

Tested in UAT env:

cc: @Ramu-kandimalla @rajeshcherukumalli


Trap configuration?

Do you plan to add the ability to configure the spawning of landmines and turrets in the future? I'd find it really useful for balancing out moons a little better.

I'll add it to my todo list and see what I can do.

Thanks so much, love this mod.


Case flags 2.1 CUI RA

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PRL-4400
https://tools.hmcts.net/jira/browse/PRL-4410
Change description
This PR is based on base XUI changes for Case flags 2.1. It has a dependency on XUI PR - 2746 (https://github.com/hmcts/rpx-xui-webapp/pull/2746)
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Closing the PR due to dev ops issue.
Error: client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline
3010:24:44  + ./aks-debug-info.sh prl-ccd-definitions-pr-1553 private-law


Blade syntax escaping htmlspecialchars

Laravel Version: 5.5.50
PHP Version: 7.3.23
Database Driver & Version: SQLite3

Description:
Hey guys i am using code view, cause otherwise this will be displayed the wrong way... and thats the spirit...
When creating view templates with blade syntax the escaping doesnt seem to work the right way:
{{ "<" }} should be converted to "&lt;" (the "&" ist the special char and should be converted to "&".
Instead it stays "<". ( Although PHPs htmlspecialchars("<") would return "&lt;")

{{ "<" }} alone results in "<" whicht is fin IMHO. Same with {{ "&" }} resulting in "&"

Steps To Reproduce:
-Create a view that calls a blade layout
-Content of the blade layout;
{{ "<" }}
{{ "<" }}
{{ "&" }}
{{ "&" }}

-Open the view in your browser to check the results. Imho the correct results for each line should be:
1: "&lt;"
2: "<"
3: "&amp;"
4: "&"

Hey there,
Unfortunately we don't support this version anymore. Please check out our support policy on which versions we are currently supporting. Can you please try to upgrade to the latest version and see if your problem persists? We'll help you out and re-open this issue if so.
Thanks!

Ah nut. My bad.
I will try with laravel 7/8 versions.

Works correctly in current 7.x and 8.x releases.


Type Error for using Command /ce Server Internal Error

Its a Type Error then your will enchant a Item with PC Enchants he will kick you from the Server Internal Server Error
Error Code in a Piece:
[12:23:10] [Server thread/CRITICAL]: TypeError: "Argument 2 passed to pocketmine\item\enchantment\EnchantmentInstance::__construct() must be of the type int, string given, called in phar:///home/minecraft/plugins/PiggyCustomEnchants_dev-481 (1).phar/src/DaPigGuy/PiggyCustomEnchants/commands/subcommands/EnchantSubCommand.php on line 113" (EXCEPTION) in "pmsrc/src/pocketmine/item/enchantment/EnchantmentInstance" at line 41
[12:23:10] [Server thread/CRITICAL]: #0 plugins/PiggyCustomEnchants_dev-481 (1).phar/src/DaPigGuy/PiggyCustomEnchants/commands/subcommands/EnchantSubCommand(113): pocketmine\item\enchantment\EnchantmentInstance->__construct(object

Ups wrong Plugin issue pardon it is for the Main PCE Plugin dev version 481


Excluding files not working properly

Hi! We've been trying Overcommit in one of our latest projects at work, and after a few weeks of development, we noticed that some of the excluded files and directories are still being analyzed.
My current configuration for a Rails project consists on:
PreCommit:
  RuboCop:
    enabled: true
    on_warn: fail # Treat all warnings as failures
    command: ['bundle', 'exec', 'rubocop']
  JsHint:
    enabled: true
    on_warn: fail # Treat all warnings as failures
    command: ['bundle', 'exec', 'rake', 'jshint']
    flags: []
    exclude:
      - "vendor/**/*.js"
  CssLint:
    enabled: true
    on_warn: fail # Treat all warnings as failures
    command: ['bundle', 'exec', 'rake', 'custom_css_lint:run']
    flags: []
    exclude:
      - 'app/assets/stylesheets/flat-dream.scss'

As you see, it's not much of a complicated configuration, but still excluded files and directories are analyzed and shown as errors. There are other file patterns we've used as well, but none of them work.
I've been trying to add some spec testing this bug with no apparent luck, as over the gem's testing environment both file and directory exclusion are working. I hope to come back here with a more complete report in a few days, but it would really help to know if some of you are experiencing any similar problems.
Thanks!

Hey @MaximilianoFelice,
I notice the hooks with exclude are running Rake tasks—do these tasks accept a list of files, or do they just run against all files in your repository? If it's the latter, that explains why exclude isn't working.

Closing due to lack of response.


Fixes #issue8 - SizeChunker is not wating for chunkStart to finish before running _finishChunk

Fixes issue #8

Ran unit test after the fix. Worked.

:) sorry i missed that part. what do you think now?

No it is totally broken... Deeper refactoring is required here. We need to split _startIfNeededAndPushData into push and start in a case remainder is 0.
I think I can land your first commit in a separate branch and then refactor it further

Ok. Thanks for looking into it. Nice lib btw.


Quick Accent doesn't work with accents keys on Italian keyboard anymore

Microsoft PowerToys version
0.67.1
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
Quick Accent
Steps to reproduce
On Italian keyboard layout, Quick Accents doesn't work on keys with accents like "è", "à", etc. It works normally on other keys like "e", "a", etc.
Issue persists since several last versions.
✔ Expected Behavior
Quick Accents toolbar had to raise up with all keyboard keys.
❌ Actual Behavior
On Italian keyboard layout, Quick Accents doesn't work on keys with accents like "è", "à", etc.
Other Software
No response

I see what you mean, the Italian layout has some accented keys already:

Quick Accent is supposed to work only on base (non accented) letters. You seem to imply this used to work before. What version was this working on?
Anyway, this doesn't sound like a bug, since it was never intended, but is a Improvement request. I'll label it accordingly.
Thanks for opening the issue.

Thanks but it works previously (can't say which exact version but, I now thinking that I noticed it after reinstalling PowerTools after installing a brand new Windows 11 instead of Windows 10 with a clear installation, not upgrade).
Having it works it's essential because we need accents in capital letters and so, using Quick Accents, was incredibly useful.
F.e. "è" > "È" or "É". I used to press "è" + SHIFT to raise Quick Accent and select "È" or "É" from it's bar.
Hope that this it's clear enough.

Well, have to be honest too, I'm now in doubt that I used SHIFT + E + SPACE to reach "È" that works as expected...
Can I suggest adding this feature, anyway?
Thanks for taking time on this.

can you verify if this is still an issue with v0.74.1 /needinfo

I don't see any difference in the behavior.

Hi @nicolafarina, could you download the latest version of PowerToys and verify if this is still an issue?
/needinfo

Hi, I tested the latest version, but I don't see what I have to check, No support for accent letters keys (on Italian layout keyboard) yet.