Reloading Certificates

Environment

OS: debian 8 - docker 17 - alpine:3.5
Erlang/OTP: 19
EMQ: 2.2

Description
We are using letsencrypt to get our certificates for the SSL connections. As letsencrypt wants us to renew the certificate at least every 90 days, it would be nice to have a solution for doing that without closing the listener (and dropping all active connections) every time.
I looked at esockd as well as mochiweb if there is any solution for this but didn't found anything.
Any suggestions to make that possible?

Thank you in advance

After some further investigations I found a pretty simple solution but it needs some additional code in the source. Adding the following code to 'emqttd_app':
restart_listener(ssl, ListenOn) ->
    restart_listener({'mqtt:ssl', ListenOn});

restart_listener(wss, ListenOn) ->
    restart_listener({'mqtt:wss', ListenOn});

restart_listener(Proto, ListenOn) ->
    restart_listener({Proto, ListenOn}).

restart_listener({Protocol, ListenOn}) ->
    % get supervisor pid & child specs
    ListenerSup = esockd:listener({Protocol, ListenOn}),
    {ok, Map} = supervisor:get_childspec(ListenerSup, listener),

    % stop and delete old child (cant be simply restart if transient)
    supervisor:terminate_child(ListenerSup, listener),
    supervisor:delete_child(ListenerSup, listener),

    % start child again
    supervisor:start_child(ListenerSup, {listener,
        maps:get(start, Map),
        maps:get(restart, Map), maps:get(shutdown, Map), maps:get(type, Map), maps:get(modules, Map)}).

As well as change the exported functions to:
-export([start_listener/1, stop_listener/1, restart_listener/2]).
This will work on both SSL connections (MQTT and WSS)! 🥂
I hope it will find the way into the next release.
Cheers,
baer

@ baer Thanks for your contributions. I will review and merge the fix in next release if it works fine:)

@baer-devl restart_listener working in v2.2-rc.2


Add small test cases

For https://github.com/gunnarmorling/1brc/issues/276

Applied, thx!

I'll do another PR to allow testing of single sample

https://github.com/gunnarmorling/1brc/pull/291


Create a .set function for setting lower bound, upper bound, multipliers, and initial values for variables in nosnoc.ocp.Solver and nosnoc.Integrator

Probably with the syntax:
ocp_solver.set(var, field, varargin)

where varargin contains indices and the value to set.

Closed by #114.


Inline variables.

Codecov Report

Merging #124 (95c7b0c) into master (40fa3aa) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
- Coverage     64.52%   64.49%   -0.03%
  Complexity     1558     1558
============================================
  Files           105      105
  Lines          5809     5805       -4
  Branches       1068     1068
============================================
- Hits           3748     3744       -4
  Misses         1615     1615
  Partials        446      446

Impacted Files
Coverage Δ

...in/java/org/apache/commons/beanutils2/BeanMap.java
75.12% <100.00%> (-0.13%)
:arrow_down:

...ava/org/apache/commons/beanutils2/LazyDynaMap.java
54.76% <100.00%> (-0.54%)
:arrow_down:

...mmons/beanutils2/converters/DateTimeConverter.java
66.06% <100.00%> (-0.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fa3aa...95c7b0c. Read the comment docs.


integer on 2 bytes

with input :
decimal
26[2]

I expect 00000000: 1a00, that is 2 bytes.
But I go 00000000: 1a00 0000, that is 4 bytes.
Same appends when ask for only 1 byte, we got 4 bytes.

Hi @setop,
Thanks for reporting. Indeed, this input will produce an unexpected output as you said.
However, I have rewritten all the code in the branch called regex to which you can have a look.
In that new version, the problem is no more present.
I will merge it ASAP on master then I will close this issue.
Meanwhile you can use the regex branch.

In regex branch, it works great for 1,2,4.
Thanks

The branch regex has been merge into master. So the issue is fixed.


Add new entry to Resource.ApiGroup for Infra features

Short description:
Based on review comment in a cnv-tests PR adding an entry of operators.openshift.io/infrastructure-features to Resource.ApiGroup
More details:
As suggested by @rnetser in a cnv-tests PR, adding this entry
What this PR does / why we need it:
This would be used in tests
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/verified


'waymo_setup.md' is 404 - page not found

Hello, I want to run experiments on Waymo by refering to waymo_setup.md, however, the page is not found.

It's now in https://github.com/OpenDriveLab/Birds-eye-view-Perception/blob/master/docs/waymo_setup.md

Thanks for answering!


error when open nvim (ubuntu)

Error detected while processing /home/khadas/.config/nvim/init.vim:
line   13:
E5105: Error while calling lua chunk: .../khadas/.config/nvim/lua/builtin/utils/
constants.lua:8: attempt to index field 'fn' (a nil value)
line   16:
E5105: Error while calling lua chunk: /home/khadas/.config/nvim/lua/builtin/colo
rs.lua:63: attempt to call field 'nvim_create_user_command' (a nil value)
line   17:
E5105: Error while calling lua chunk: /home/khadas/.config/nvim/lua/builtin/othe
rs.lua:3: loop or previous error loading module 'builtin.utils.constants'
somebody can help?

can you upload entire .config/nvim folder and I will check

here
nvim.zip
thanks

possibly fixed by #206, would you please help test it?

no response


Added BackgroundColor and Image to Horizontal, Vertical layouts

@halatmit Implementation for adding BackgroundColor & Image to Horizontal / Vertical screen layouts

@afmckinney
Please review

Looks good to me, now merged into the ucr branch on gerrit

Great. Thanks


Vimeo Showcase not downloading

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

WRITE QUESTION HERE
Hi,
Trying to bulk download a Vimeo Showcase https://vimeo.com/showcase/5013672
Youtube-dl gives me this error:
ERROR: Unable to extract bootstrap data; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
I can not extract any Vimeo Showcase - Why is that? How do I fix this?
thanks

I´m using the latest version and this is the verbose log:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://vimeo.com/showcase/5013672']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.07.28
[debug] Python version 2.7.16 (CPython) - Darwin-19.2.0-x86_64-i386-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[vimeo:album] 5013672: Downloading webpage
ERROR: Unable to extract bootstrap data; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 797, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/vimeo.py", line 952, in _real_extract
webpage, 'bootstrap data'), album_id)['viewer']
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 1005, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract bootstrap data; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Hi, old question but it still not working today. Impossible to download a showcase on Vimeo.
example: https://vimeo.com/showcase/*******
Any solution please?
Thanks!


Const and non-const constructor overloads

When signatures clash, they're given an ordinal to disambiguate them. This doesn't work for constructors however.
struct Overloaded
{
    Overloaded(void* p) {}
    Overloaded(const void* p) {}
};

I'm not sure what the best answer for this is. Add extra discriminant parameters or fallback to runtime dispatch?
public void Overloaded(void* p, int isConst) // runtime
{
     var arg0 = p;
     if(isConst) Internal._Overloaded0(__Instance, arg0);
     else Internal._Overloaded1(__Instance, arg0);
}

public void Overloaded(void* p, Const.True)
public void Overloaded(void* p, Const.False)

I'm not familiar with c# generics but perhaps there's a solution there?

We have now long resolved this by choosing to only generate the non-const version since it's a superset of the other.


More arguments for the constructor of the ViewHolder class?

Hi, I can't seem to figure out how to access a variable or function of the fragment containing my ViewHolder class.
Since the constructor has to have a single View parameter, how can I access my fragment in my (static) ViewHolder implementation?
Thank you for the work!

Hi, you won't be able to access any variable or method in your fragment from a static inner class. I recommend you to keep your ViewHolder decoupled from the Fragment so it's reusable.
If you want to notifiy the fragment from the ViewHoder you can define a callback/listener. See this section


Evaluation Dataset - Ground truth Warnings

Hi,
I would like to raise a potential error around the dataset used in the evaluation method (from evaluation.py).
I got the evaluation method working when I set the following dataset:
Dataset.from_dict(
        {
            'question': list,
            'contexts': list[list],
            'ground_truths': list[list],
            'answer': list
        }
    )

However, I was receiving the following warning every time the pipeline ran:
passing column names as 'ground_truths' is deprecated and will be removed in the next version, please use 'ground_truth' instead. Note that `ground_truth` should be of type string and not Sequence[string] like `ground_truths`

Comparing to the documentation present here and in the evaluation docstrings here, ground_truth key is expected to be a list[list].
Therefore, is this warning correct? If so, to generate a string, we simply concatenate the list of strings into a single string? Separating by space, comma?
Then, on a quick experimentation, I changed the dataset key from ground_truths to ground_truth, but passing still list[list], it did not work. This makes the example given here invalid, I guess.
Thanks! I happy to provide any additional info!
I am using: ragas==0.1.0

seems like the documentation has to be updated - thanks for pointing it out .
the correct format is
Dataset.from_dict(
        {
            'question': list,
            'contexts': list[list],
            'ground_truth': list,
            'answer': list
        }
    )


PSR-16 Simple Cache Interface implementation

Adds standards compliance for PSR-16: Simple Cache Interface.

It might be worth checking out https://github.com/php-cache/integration-tests - their goal is ensuring interop between implementations and they've just added a bunch of PSR-16 tests.

@Ocramius do let me know if the TTL implementation was what you had in mind.  Thanks for the advice.

Maybe I missed something, but it doesn't look like you are handling the different capabilities of the underlying adapters - for instance, some can't store objects, some store integers as string.
This was the biggest pita when I did the PSR-6 adapter last year. The simplest approach would be to serialize() everything, but of course I didn't do that ;) If not you'll need to figure out what data types you can save natively, or start dropping support for some adapters. See the src/Psr stuff on develop for examples of that.
Finally, it doesn't look like the new PSR has much to say about errors thrown by the underlying storage. PSR-6 was explicit that they shouldn't stop the calling code carrying on. That was one of the few things that really made sense to me ;) Has there been any discussion of that? What are other implementers doing?

Hi @Sam-Burns,
thanks for your work on this but for me it doesn't look correct to just add all PSR-16 methods directly into all adapters (implementing into AbsrtactAdapter).
Lines line the following are no a good interface.
if ($ttl && ! $this instanceof TtlUsedAtWriteTimeInterface) {
    throw new BadMethodCallException('TTL not supported by cache adapter');
}

It would be better to ship wrapper for PSR-16 like it was done for PSR-6.
Also as @kynx already pointed out it's not the correct way adding an interface to mark TTL support as this interface doesn't define anything and you can (theoretically) add this feature as a storage plugin.
look here: https://github.com/zendframework/zend-cache/tree/develop/src/Psr
Something like the following should be a better approach:
namespace Zend\Cache\Psr;
use Psr\SimpleCache\CacheInterface as PsrCacheInterface;
use Psr\SimpleCache\CacheException as PsrCacheException;
use Psr\SimpleCache\InvalidArgumentException as PsrInvalidArgumentException;
use Zend\Cache\Storage\StorageInterface as ZendStorageInterface;
use Zend\Exception\InvalidArgumentException as ZendInvalidArgumentException;
use Exception;
use RuntimeException;
use InvalidArgumentException;

class SimpleCacheWrapper implements PsrCacheInterface
{
    private $storage;
    public function __construct(ZendStorageInterface $storage)
    {
        // TODO: test if the storage is suitable for matching PsrCacheInterface
        $this->storage = $storage;
    }

    public function get($key, $default = null)
    {
        try {
            $rs = $this->adapter->getItem($key, $success);
            if (!$success) {
                $rs = $default;
            }
            return $rs;
        } catch (Exception $e) {
            throw static::translateException($e);
        }
    }

    // ...

    private static function translateException(Exception $e)
    {
        $psrExceptionClass = SimpleCacheException::class;
        if ($e instanceof ZendInvalidArgumentException) {
            $psrExceptionClass = PsrInvalidArgumentException::class;
        }
        return new $psrExceptionClass($e->getMessage(), $e->getCode(), $e);
    }
}

class SimpleCacheException extends RuntimeException implements PsrCacheException
{
}

class SimpleCacheInvalidArgumentException extends InvalidArgumentException implements PsrInvalidArgumentException
{
}

Cheers

@Sam-Burns: Btw. this PR should target the develop branch

I found the following definitions in PSR-16 spec:
http://www.php-fig.org/psr/psr-16/#cache

If the underlying implementation does not support TTL, the user-specified TTL MUST be silently ignored.

This doesn't make sense to me but it is in the spec and would mean we can just ignore the TTL in the storage doesn't support TTL on writing.
http://www.php-fig.org/psr/psr-16/#cache

All data passed into the Implementing Library MUST be returned exactly as passed. That includes the variable type. That is, it is an error to return (string) 5 if (int) 5 was the value saved. Implementing Libraries MAY use PHP’s serialize()/unserialize() functions internally but are not required to do so. Compatibility with them is simply used as a baseline for acceptable object values.

This on the other hand needs to be handled by checking supportedDatatypes capabilities.
http://www.php-fig.org/psr/psr-16/#cacheexception

Interface used for all types of exceptions thrown by the implementing library.

For me this means the storage is allowed to throw exceptions (even on get()) - we just need to translate our own exceptions to implement this interface.

Actually, I would prefer an interface which specifies a "TtlPerValue" behavior instead of that TtlUsedAtWriteTimeInterface.
Actually, the whole zend-cache projects defines a global TTL for the a specific storage which is valid for any record.
I've written some implementation for this a few months ago which were are actively using for e.g. Redis or Memcached.
<?php

interface TtlPerValueCapableInterface
{

    /**
     * Sets the given value with a specific ttl
     *
     * @param string       $key
     * @param mixed        $value
     * @param null|integer $ttl
     *
     * @return boolean
     *
     * @triggers setItem.pre(PreEvent)
     * @triggers setItem.post(PostEvent)
     * @triggers setItem.exception(ExceptionEvent)
     */
    public function setItemWithTtl($key, $value, $ttl = null);
}

Created a trait and extended all necessary storage adapters:
trait TtlPerValueCapableTrait
{

    /**
     * @param StorageInterface $storage
     * @param string           $key
     * @param mixed            $value
     * @param integer|null     $timeout
     *
     * @return boolean
     *
     * @see StorageInterface::setItem
     * @see StorageInterface::getOptions
     * @see AdapterOptions::setTtl
     * @see AdapterOptions::getTtl
     */
    protected function handleTtlPerValueCall(StorageInterface $storage, $key, $value, $timeout)
    {
        $options = $storage->getOptions();
        $defaultTtl = $options->getTtl();
        if ($timeout !== null) {
            $options->setTtl($timeout);
        }

        $result = $storage->setItem($key, $value);

        $options->setTtl($defaultTtl);

        return $result;
    }
}

Probably something like this can be implemented in the future. Could remove my self-implemented logic then.

This doesn't make sense to me but it is in the spec and would mean we can just ignore the TTL in the storage doesn't support TTL on writing.

Yeah, but if the options object supports TTL, then we should set the TTL in the options anyway.

Recently realized that there are issues with storage systems which does not provide auto expire ability.
We realized that the filesystem storage is aware of the ttl option BUT the ClearExpiredByFactor plugin which will ensure that expired files will be deleted, will kill files if any ttl is defined within the storage options.
Example:
$cache = Zend\Cache\StorageFactory::factory(array(
    'adapter' => array(
        'name'    => 'filesystem',
        'options' => [ 'ttl' => 1, 'cache_dir' => '/tmp' ]
    ),
));

$cache->set('foo', 'bar', 3);

for ($i=1; $i <= 4; $i++) {
     sleep(1);
     echo "Second $i: " . $cache->get('foo') . PHP_EOL;
}

This will output:
Second 1: not-found
Second 2: not-found
Second 3: not-found
Second 4: not-found

If the configuration does not set any TTL, the value would be interpreted as 0 which wont expire any file and the record remains forever, even if you set the TTL with 3.

@boesing PSR-16 explicitly described to ignore the specified TTL if the underlying storage doesn't support it. This doesn't make sense to me but it's described that way.
For the filesystem adapter the issue is that it will handle TTL in reading the item based on current time, last modification time and defined TTL. That means the TTL defined on "set()" will be ignored and on reading it will use the TTL defined in options. So all your items gets expired after 1 second.

@marc-mabe I'm aware of that. However, there could be an implementation for the Filesystem storage which can ensure that expired files are not returned if stored with PSR-16.
Like for the tags, there could be an additional file where the storage will store the used TTL which is being verified.
I think there will be bug reports for the filesystem storage if someone stores data with PSR-16 interface. I know, the answer will be "PSR-16 describes that behavior" but I think there could be a solution for some adapters.
Just my 2 cents.

@boesing I don't like the idea to special case the PSR-16 methods on the filesystem adapter. It would be weird if setItem/getItem are having different behavior then set/get.
In my opinion we should investigate to implement a plugin to add "TTL on write" support in general. This would be reusable by all storages not supporting TTL.
Then in PSR-16 throwing an exception on TTL usage if not supported no matter what the spec describes.
PS: The current TTL handling of the filesystem adapter helps to reduce disc access a lot in some cases. I would not like to rewrite it to something slower ;)

@marc-mabe I kind of agree with you.  What you are describing is basically the intention behind the commit https://github.com/zendframework/zend-cache/pull/126/commits/0e4c9a4e71a0a86cbaad2b66a1c16829e0cb8de3 .
Please note that the file caching doesn't seem to be the only one where there are problems.  There are other cache adapters where the TTL is used at read time, and it doesn't matter what the setting was at write time.
I wanted to use an interface to label 'adapter where TTL is used on write'.  For our purpose, that is very different from 'adapter where TTL is used on read' or 'adapter where TTL isn't implemented'.  This approach was the subject of some criticism in this PR.
I'm more than happy to make any changes you can suggest to this PR for your project - I'm just not sure what I should do.  I guess a few of the options are as follows:

Use inheritance: with two abstract child classes of AbstractAdapter, which adapters can then inherit from, called AdapterWithTtlSupport and AdapterWithNoTtlSupport.
Use an interface label: empty interface used as a label, and the AbstractAdapter has to have if ($this instanceof ThingWhereTtlIsImplementedInAWayWhichIsHelpfulRightNow) in it
Use a protected method: adapters have to have protected function doesTtlWorkInThisImplementationOrShallWeJustSilentlyIgnoreIt() : bool in them.
Use traits: adapters have a trait called Psr16WhereTtlIsSupported and Psr16WhereTtlIsntGoingToWorkSorry

On your point about throwing an exception: the PR was doing that a while ago, instead of silently ignoring the TTL if it's not going work.  I can put it back if that is what you want.
If you, @Ocramius or anyone else would like to tell me if any of those approaches are something you would like to see in this PR, I'm very happy to take your guidance on how to implement this.  Please let me know.

I've added some logic a few days ago but I thought that it's not useful since it was just a case I implemented for the use case we are using in our business.
I've created some interfaces about a year ago (because of lack in zend-cache):
interface TtlPerValueCapableInterface extends StorageInterface
{

    /**
     * Sets the given value with a specific ttl
     *
     * @param string       $key
     * @param mixed        $value
     * @param null|integer $timeout
     *
     * @return boolean
     *
     * @triggers setItem.pre(PreEvent)
     * @triggers setItem.post(PostEvent)
     * @triggers setItem.exception(ExceptionEvent)
     */
    public function setItemWithTtl($key, $value, $timeout = null);
}

As you can see, this is kinda PSR-16 behavior. As I implemented that, I did not even realized that there is any PSR like that.
However, I've extended some Adapters like Redis, Filesystem and Memcached.
(NOTE: Redis and Memcached support auto expire)
We did not used Filesystem cache that often but as we started to use it, we realized that there is no auto expire at all. After that, I dig into the Adapter and realized: of course, how could the adapter know what TTL was used as the item was stored.
Therefore, I've implemented a new interface for our module today:
interface WithoutTtlAutoExpiring extends TtlPerValueCapableInterface
{

    /**
     * @param string $key
     *
     * @return boolean
     */
    public function isExpiredByTtl($key);
}

I've implemented that to the Filesystem adapter with the same logic as tags are being stored:
    /**
     * @inheritdoc
     */
    public function setItemWithTtl($key, $value, $timeout = null)
    {
        // handleTtlPerValueCall is a trait which does the same thing this PR does in `set` method
        $stored = $this->handleTtlPerValueCall($this, $key, $value, $timeout);

        if ($stored === false || $timeout === null) {
            return $stored;
        }

        $this->normalizeKey($key);
        $ttlFile = $this->getTtlFileName($key);

        // delete related ttl file (if present)
        $this->unlink($ttlFile);

        $wouldblock = null;
        $this->putFileContent($ttlFile, $timeout, true, $wouldblock);
        if ($wouldblock) {
            $this->putFileContent($ttlFile, $timeout);
        }

        return true;
    }

    /**
     * @inheritdoc
     */
    public function isExpiredByTtl($key)
    {
        $this->normalizeKey($key);

        if (!$this->internalHasItem($key)) {
            return false;
        }

        $options = $this->getOptions();
        $ttlFile = $this->getTtlFileName($key);

        if (!file_exists($ttlFile)) {
            if ($options->getTtl() === 0) {
                return false;
            }

            return true;
        }

        $ttl = $this->getFileContent($ttlFile);

        $currentTtl = $options->getTtl();
        $options->setTtl($ttl);

        // Let base logic execute the filemtime stuff, e.g.
        $expired = !$this->internalHasItem($key);
        $options->setTtl($currentTtl);

        return $expired;
    }

    /**
     * Creates the filename for the ttl information
     *
     * @param string $normalizedKey
     *
     * @return string
     */
    private function getTtlFileName(&$normalizedKey)
    {
        return $this->getFileSpec($normalizedKey) . '.ttl';
    }

This actually works as expected, since I've added a new Plugin I've created:
class DynamicTtlCacheClear extends AbstractPlugin
{

    /**
     * @inheritdoc
     */
    public function attach(EventManagerInterface $events, $priority = 1)
    {
        $this->listeners[] = $events->attach('hasItem.pre', [$this, 'hasItem'], $priority);
        $this->listeners[] = $events->attach('hasItems.pre', [$this, 'hasItems'], $priority);
        $this->listeners[] = $events->attach('getItem.pre', [$this, 'getItem'], $priority);
        $this->listeners[] = $events->attach('getItems.pre', [$this, 'getItems'], $priority);
    }

    /**
     * @param Event $event
     *
     * @return boolean
     */
    public function hasItem(Event $event)
    {
        $storage = $event->getStorage();
        if (!$storage instanceof WithoutTtlAutoExpiring) {
            return true;
        }

        $expired = $storage->isExpiredByTtl($event->getParam('key'));

        // If key is expired, stop propagation and return false
        if ($expired === true) {
            $event->stopPropagation();

            return false;
        }

        return true;
    }

    /**
     * @param Event $event
     *
     * @return void
     */
    public function hasItems(Event $event)
    {
        // Trigger getItems so we can trigger item deletion if the key is expired
        $this->getItems($event);
    }

    /**
     * @param Event $event
     *
     * @return void
     */
    public function getItem(Event $event)
    {
        $storage = $event->getStorage();
        if (!$storage instanceof WithoutTtlAutoExpiring) {
            return;
        }

        $key = $event->getParam('key');
        if (!$storage->isExpiredByTtl($key)) {
            return;
        }

        $storage->removeItem($key);

        return;
    }

    /**
     * @param Event $event
     *
     * @return void
     */
    public function getItems(Event $event)
    {
        $keys = $event->getParam('keys');
        $storage = $event->getStorage();

        foreach ($keys as $key) {
            $pre = new Event('getItem.pre', $storage, new \ArrayObject([
                'key' => $key,
            ]));
            $this->getItem($pre);
        }
    }
}

Not quite sure if this is the best way of how to do this, but actually this fixed our problem with the Filesystem adapter which does not support auto expire.
Probably this could be useful for this PR, any ideas welcome aswell.

@Sam-Burns
That's not was I mean with

Then in PSR-16 throwing an exception on TTL usage is not supported no matter what the spec describes.

What I mean is using the wrapper approach (as described in https://github.com/zendframework/zend-cache/pull/126#issuecomment-271992110) and throw an exception on constructor if the given storage doesn't support TTL on write.
Also adding an interface for TTL support is a no go if we want to implement this feature configurable by plugin for all storage adapters because a plugin can't add an interface.
-> What we have is $storage->getCapabilities()->getMinTtl() and $storage->getCapabilities()->getStaticTtl():

A min. TTL of 0 means the item never expires as TTL is not supported
Static TTL defined if the time of expiration is fixed as it's stored on write.

@boesing
The  plugin should not need any new methods on storage adapter level!
-> My basic idea would be to modify the item on write by adding the time of expiration to it. Then compare time of expiration on read and restore the original item before return.
-> Similar what the serializer plugin does.

@marc-mabe Well, I dont like the idea that the plugin has to read tons of bytes which are probably not used because of TTL expiration.
Assume there are megabytes of data stored in a cache which should use the plugin you intend. Just to see if these megabytes are fresh, all of those megabytes need to get loaded into memory just to determine if its still fresh. I actually don't like that idea, even for performance purposes.
I still don't get where the difference is between tags support and TTL support with the Filesystem adapter. Tags aren't supported natively aswell, but there is a logic implemented to store those tags into a separate file. So why not storing TTL information in a different file aswell?

@boesing

Well, I dont like the idea that the plugin has to read tons of bytes which are probably not used because of TTL expiration.

If you analyze normal cache use-cases you will notice that a cache should have at least a hit rate of 80%. That means you will only read unused cached data for max. 20% but you will not make additional IO for reading TTL in 80%.
Additionally most people will store less data as 1MB in a cache item and in PHP it should be muss less as it's used for HTTP most of the times. And for small amount of data it should be faster even if you don't think about filesystem block size etc.
Of course both ways would be possible, storing expiration time in data file or as an own file. Without real world benchmaks nobody can tell ;)
But even on going the way to store as separate file you shouldn't add weird public exposed methods to the filesystem adapter for making a pligin work. It should all be done within the plugin.

@boesing
Btw. Tagging is a totally different feature used for different purposes.
For example you can add a tag for each user on different items and then clean all items of a specific user.

I really like the idea of this patch, and fully support implementing PSR-16. However, I also agree with @marc-mabe that we should do so via a decorator class instead, as he detailed in a previous comment. That approach is simpler to test, and more in line with how we have supported standards in our existing packages in the past (PSR-6 support in this package, PSR-3 support in zend-log, etc.).
(The approach also allows users to continue using zend-cache as-is, and then decorate it to use as a PSR-16 dependency for 3rd party code.)

Closing in favor of #152, which provides an approach consistent with existing PSR-6 support.


OCaml-CI's Checks API reports duplicate entries.

debian 4.13 is reported twice in this instance but I've seen other places with duplicates.

Closing, this appears to have been fixed since the original issue was reported.


Move label check to using any_of instead of one_of

Looking at the documentation for the labeler action used, any_of is a better choice because It may become necessary to label with more than one backport label. This change supports that logic.

The failure is again due to the pull_request_target permissions issue.


Infer failed to detect Arbitrary Code Execution Under lock

Hi all,
I was trying the example provided in https://fbinfer.com/docs/all-issue-types/#arbitrary_code_execution_under_lock. However, latest Infer (up-to-date master branch) failed to detect Arbitrary Code Execution Under lock. Instead Infer reports "no issue". Could you confirm that this kind of issue is supported or I need additional code to reproduce this issue?
Thanks!

Hi @xi-liu-ds, I get a report with the latest master:
$ cat issue1477.java
package com.google.common.util.concurrent;

class SettableFuture {
  void set(Object a) {}
}

class NotUnderLock {
  SettableFuture future = null;

  public void callFutureSetOk() {
    future.set(null);
  }

  public synchronized void firstAcquisitionBad() {
    callFutureSetOk();
  }

  public void secondAcquisitionOk(Object o) {
    synchronized (o) {
      firstAcquisitionBad();
    }
  }
}
$ infer -- javac issue1477.java
...
issue1477.java:14: error: Arbitrary Code Execution Under lock
  Method `void NotUnderLock.firstAcquisitionBad()` calls `void SettableFuture.set(Object)` under a lock; executed code may acquire arbitrary locks leading to potential deadlock.
  12.     }
  13.
  14. >   public synchronized void firstAcquisitionBad() {
  15.       callFutureSetOk();
  16.     }

Found 1 issue
                                                Issue Type(ISSUED_TYPE_ID): #
  Arbitrary Code Execution Under lock(ARBITRARY_CODE_EXECUTION_UNDER_LOCK): 1

Closing optimistically, let us know if there's still an issue.


SA1200 in top-level programs

For imports in top-level programs, a SA1200 is reported for every import.

@sharwell this is back again with the latest 1.2.0-beta.354 build.
However it happens when using global usings from C# 10: https://github.com/Elskom/Sdk/pull/248

@AraHaan global usings are a different feature, so a new issue would be warranted for this.


Add protocol tracing support for applications using BoringSSL

Pixie currently supports tracing protocol traffic encrypted with certain TLS libraries (OpenSSL version 1.1.0 or 1.1.1, dynamically linked and Go TLS when a binary has debug info). This gives broad coverage, but there are other popular TLS libraries that are not supported as of today (BoringSSL being one of them). The recent work to trace netty tls traffic (#407) uncovered some common challenges to support BoringSSL more broadly.
This issue will track the work to enhance Pixie's TLS protocol tracing to include applications that use BoringSSL.

I'm in the process of drafting a design document for this work. Once the first draft is finished I'll be sharing the document here.

This is complete as of the v0.14.3 Vizier release!


Add temporary validation to disallow seed with pipeline parallel

Until we fix upstream bug
(Rebased on ~fix-lora-toks~ fix-tokenize to make the PRs stacked)

Codecov Report
Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.96%. Comparing base (76cce9d) to head (ff144ef).

Files
Patch %
Lines

src/vllm_tgis_adapter/grpc/validation.py
33.33%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   63.03%   62.96%   -0.07%
==========================================
  Files          18       18
  Lines        1285     1288       +3
  Branches      228      229       +1
==========================================
+ Hits          810      811       +1
- Misses        398      399       +1
- Partials       77       78       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@dtrifiro not a big deal but I was thinking we would have merged the fix-tokenize branch to main first, followed by merging this to main. Since they are unrelated changes. This was only targeted at the fix-tokenize branch so that we could have a single branch containing both to use in our immediate builds...


Training for propagate module with 1 GPU

Hi.
I read your paper about MiVOS, and I think it is so great.
I am training this model, but I have a problem training in 1 GPU.
Could you please show me the command line to train a propagation model with 1 GPU?
Thank you very much, and look forward to hearing from you.

python -m torch.distributed.launch --master_port 23453 --nproc_per_node=1 train.py --id someid --stage 0 --batch_size 24
See the readme for loading the stage 0 model to train stage 1.


OpenMP parallel for

I've been working with SimpleFFT for a while now in a project, and noticed some details I've modified in our local version.
Most importantly, the use of "#pragma omp parallel for" involves some overhead in setting up a multi-threaded context and passing value ranges to threads. I've never had good results with this in innermost loops, the way it's being used right now in SimpleFFT.
The alternative "#pragma omp simd" is more than likely a suitable alternative. Rather than setting up a multithreaded context, simd will use common vectorization constructs to optimize the loop, leaving the multithreading (and its overhead) to outer contexts instead.
With this change, I've had positive results enabling the flag in clang as well - noticed there was an ifdef disabling it for that environment.

Thank you for the input. Maybe some day I get to look into this more closely but I won't promise that.

No worries, I mostly wanted to make sure the issie is in here and not just
in my private copy. :)
Den mån 7 dec. 2020 19:19Dmitry Ivanov<EMAIL_ADDRESS>skrev:

Thank you for the input. Maybe some day I get to look into this more
closely but I won't promise that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/d1vanov/Simple-FFT/issues/5#issuecomment-740092269,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADOMSODCYMHGGAY6XPLWQDSTUMDVANCNFSM4UQYPRMQ
.


Admin should be able to delete talks

Delete should clear talk and all its files - only with admin

Fixed - bulk deletion is not allowed though


[stable/redis-ha] haproxy loadBalancerIP field

Is your feature request related to a problem? Please describe.
I would like to be able to express a loadBalancerIP for the haproxy iff deploying haproxy as type LoadBalancer.
Describe the solution you'd like
Example: https://github.com/helm/charts/blob/master/stable/redis/templates/redis-with-sentinel-svc.yaml#L18
haproxy:
  enabled: true
  # Enable if you want a dedicated port in haproxy for redis-slaves
  readOnly:
    enabled: true
    port: 6380
  replicas: 1
  image:
    repository: haproxy
    tag: 2.0.4
    pullPolicy: IfNotPresent
  annotations: {}
  resources: {}
  ## Service type for HAProxy
  ##
  service:
    type: LoadBalancer
    loadBalancerIP: #.#.#.#
    annotations:
      service.beta.kubernetes.io/azure-load-balancer-internal: "true"

Describe alternatives you've considered
In theory, could export the yaml for the haproxy and redeploy with desired loadBalancerIP.
Additional context
Add any other context or screenshots about the feature request here.

@andrewsail
I hadn't considered this use case for certain cloud providers... It should be a simple enough fix. Thanks for raising this.

@DandyDeveloper my pleasure! Thanks for your work. Would greatly appreciate an update on when this might be completed.

@andrewsail Done. Just waiting for a merge


[hotfix] OSF4M: Remove "All Submissions" for now

The endpoint is too inefficient to be used in production at the
moment; requests for All Submissions are timing out. This removes
the UI and the route for viewing All Submissions
see OSF-4756

I reverted this in c93b20f . Note to self: the "all submissions" endpoint is necessary for updating the submission counts.


Add plague theme

Build failure seems to be caused by #402.

Thanks @brianreumere for the force push - the Netlify tests are all green now.
There is a minor issue.
In your theme.toml you seem have an email for the author.name key. Is that intentional?

That was not intentional, I've updated it to a name instead. Thanks!


DatePicker with initial value isn't reflected on the input

Description
When I add an initial value to DatePicker, I expect the DatePicker's input to be filled with the given value.
Link to Reproduction (or Detailed Explanation)
https://stackblitz.com/edit/react-ts-6z2h8f?file=App.tsx
Steps to Reproduce

Go to App.tsx
See that DatePicker.Root has an initial value of ['2023-01-01', '2023-12-31'] but the input in the UI is empty.

Ark UI Version
1.2.1
Framework

[X] React
[ ] Solid
[ ] Vue

Browser
Google Chrome 119
Additional Information
Passing defaultValue as well for now seems to work, but ideally it shouldn't be required.,

I just pushed a fix for this. We'll release an update shortly.
If the issue persists after upgrading, I'll re-open it.


Make the disabled state of zoom controls available to ATs

The leaflet-disabled class is set on zoom controls:
https://github.com/Leaflet/Leaflet/blob/71f73785c91f50821cee4f590c41b14eeddf394c/src/control/Control.Zoom.js#L102-L104
and styles are applied to convey a "disabled" state:
https://github.com/Leaflet/Leaflet/blob/71f73785c91f50821cee4f590c41b14eeddf394c/dist/leaflet.css#L310-L314
the zoom controls remain operable however, and the state is not available to assistive technologies such as screen readers. There are at least 3 ways to convey the disabled state of buttons:

tabindex="-1" - Bing Maps for example, uses this approach. Though it may be confusing to keyboard-only users, as the button is then removed from the tab order.
The disabled attribute - Not applicable (Leaflet uses <a role="button"> as opposed to <button>).
aria-disabled="true" - May or may not be as well supported as a negative tabindex or the disabled attribute, it does seem to be well supported though.

Whether tabindex="-1" or aria-disabled="true|false" is used (I personally vote for the latter), it could be set in addition to the leaflet-disabled class for backwards compatibility.

Implementing this may satisfy (parts of) the WCAG 2.1 Success Criterion: 1.3.1 Info and Relationships and 4.1.2 Name, Role, Value for the zoom controls.

@Malvoz great suggestion! Let's go with aria-disabled in addition to the current class. Would like to submit a PR for this?

Hello @mourner , can i take this?

@mourner Sorry for the delay! I'm happy to defer this to @Augani.

If the issue is still available, can i start looking into this? @mourner

@AkshataJ96 Nobody seems to be working on this on the moment, feel free to pick it up.

Fixed in https://github.com/Leaflet/Leaflet/pull/7280.


Enabed strict dependecy on Google Cloud Dataflow runner

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PreCommit

Run Java PreCommit

R: @ibzib , @aaltay can you please review or add reviewers who can review this.

R: @ibzib , @aaltay can you please review or add reviewers who can review this.

R: @kennknowles could you take a look at this one please?

R: @kennknowles could you take a look at this one please?

Run Java_Examples_Dataflow PreCommit


closes #76 fix adsl bugs

Pull Request
Fix some minor ADSL bugs spotted by Stefan
Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!

[x] Title: Place Closes #<insert_issue_number> at the beginning of your PR title. Use the Edit button in the top-right if you need to update.
[x] Linked Issue: Ensure the related issue is linked in the "Development Section" on the right-hand side.
[x] First Contribution: If this is your first contribution, add yourself to the DESCRIPTION file.
[x] Impact on Examples: If your updates impact any examples, review locally for warnings or errors in the impacted example pages.
[x] Merge Conflicts: Developers should address any merge conflicts and merge upon successful review.
[x] New Packages: If new packages were used, ensure they are included in the DESCRIPTION file's Imports section.
[x] Updated Examples: If you added or updated an example, ensure it runs on the latest CRAN release versions of all packages used.
[x] Testing Instructions: Provide instructions on how to test the code if necessary.

Updates look good to me.
I've added just a very minor comment and I wonder if the files should be run through styler::style_file().

Since we are building up more of a code base - I propose we set up styling and spelling github actions now.

Good idea, I added https://github.com/pharmaverse/examples/issues/82 and will see if anyone wants to take it on.

@bundfussr now granted


compliance scanner reports private keys stored in image

What happened:
Our vulnerability and compliance scanner reports that private keys are stored with image
What you expected to happen:
Keys to be removed if not required
How to reproduce it (as minimally and precisely as possible):
helm show values splunk/splunk-connect-for-kubernetes > my_values.yaml
helm install my-splunk-connect -f my_values.yaml splunk/splunk-connect-for-kubernetes

Anything else we need to know?:
Full list of keys
/usr/share/gems/gems/fluentd-1.11.5/test/plugin_helper/data/cert/cert-key.pem, /usr/share/gems/gems/fluentd-1.11.5/test/plugin_helper/data/cert/cert_chains/ca-cert-key.pem, /usr/share/gems/gems/fluentd-1.11.5/test/plugin_helper/data/cert/cert_chains/cert-key.pem, /usr/share/gems/gems/fluentd-1.11.5/test/plugin_helper/data/cert/with_ca/ca-cert-key-pass.pem, /usr/share/gems/gems/fluentd-1.11.5/test/plugin_helper/data/cert/with_ca/ca-cert-key.pem, /usr/share/gems/gems/fluentd-1.11.5/test/plugin_helper/data/cert/with_ca/cert-key-pass.pem, /usr/share/gems/gems/fluentd-1.11.5/test/plugin_helper/data/cert/with_ca/cert-key.pem, /usr/share/gems/gems/fluentd-1.11.5/test/plugin_helper/data/cert/without_ca/cert-key-pass.pem, /usr/share/gems/gems/fluentd-1.11.5/test/plugin_helper/data/cert/without_ca/cert-key.pem, /usr/share/gems/gems/httpclient-2.8.3/sample/ssl/0key.pem, /usr/share/gems/gems/httpclient-2.8.3/sample/ssl/1000key.pem, /usr/share/gems/gems/httpclient-2.8.3/test/client-pass.key, /usr/share/gems/gems/httpclient-2.8.3/test/client.key, /usr/share/gems/gems/httpclient-2.8.3/test/server.key

Environment:

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.3", GitCommit:"ca643a4d1f7bfe34773c74f79527be4afd95bf39", GitTreeState:"clean", BuildDate:"2021-07-15T20:58:09Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.13-eks-8df270", GitCommit:"8df2700a72a2598fa3a67c05126fa158fd839620", GitTreeState:"clean", BuildDate:"2021-07-31T01:36:57Z", GoVersion:"go1.15.14", Compiler:"gc", Platform:"linux/amd64"}

Ruby version (use ruby --version):

ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-linux]

OS (e.g: cat /etc/os-release):

Red Hat Enterprise Linux release 8.4 (Ootpa)

Splunk version:

Splunk Enterprise
Version:
8.2.2
Build:
87344edfcdb4

Splunk Connect for Kubernetes helm chart version:

helm list -n splunk-monitoring
NAME             	NAMESPACE        	REVISION	UPDATED                             	STATUS  	CHART                              	APP VERSION
my-splunk-connect	splunk-monitoring	1       	2021-06-09 16:45:13.441189 -0400 EDT	deployed	splunk-connect-for-kubernetes-1.4.7	1.4.7

Others:

These are example/sample/dummy keys used by the underlying components for testing, mockinf, functional testing etc.
Mark these as false positives in your scanner and proceed with installcation.

Closing this issue for now, please let us know if you have any other queries. Thanks.


Add support for .OTF files

Had to update all tests and add an empty line at the end of each for consistency. Can undo if needed although it's usually a good idea to have it there.
Closes #12.

:+1: LGTM, thanks!


[WFLY-14536] Add tests to connector subsystem for attributes that all…

…ow expression
https://issues.redhat.com/browse/WFLY-14536
Thanks for submitting your Pull Request!
Please delete this text, and add a link to the Jira issue solved by this PR.
Remember to use the Jira issue ID in the PR title, and any commits.

@tadamski This one has been around for a while but we have some comments from Brian and a merge conflict, is this one we can clean up to get merged or should we close for now and resubmit once ready?

hi @darranl, I have rebased the branch and fixed the issued mentioned by Brian

Thanks, just running CI again then we can see if we can get merged.

Thanks, @tadamski


Add custom fetch option

Changes
Add fetch property to ClientOptions for custom implementations
Relates: #47 #41 #4
Checklist

[x] Tests updated
[x] README updated

@drwpow May I add a github workflow to run tests and lint on open PRs?

@drwpow May I add a github workflow to run tests and lint on open PRs?

? there are GitHub workflows already set up. what are you suggesting?

@drwpow Sorry, I overlooked because of a type error in the editor but not in the PR checks. All good

Thank you! Great feature, and great tests.


Feature Request: Installable library

Currently, the library can only be consumed in any meaningful way when adding it as a subproject, since it can not easily be installed. I would suggest adding a suitable installation configuration to build configuration.
I would be happy to contribute such a configuration if @Murthy10 considers this a useful addition.

Just awesome!
@fmorgner  Thanks a lot for all your advises and your contribution.

Closed by 3e30248


mly.set_token(MLY_ACCESS_TOKEN) missing at Colab Demo

First of all, congrats for the API!!
I was trying to test the demo when I realized that the mentioned line was missing at the notebook!!
It may be putted right after the "MLY_ACCESS_TOKEN" declaration at the third jupyter cell!
Best Regards,
Kauê

Thank you, @kauevestena for that!
Edited in the notebook.
Closing issue.


Add GET settings request in admin REST API for easy debug.

Proposal
Please provide possibility to show configuration to end user via REST API admin call, when it's not possible with accessing machine/pod/VM where wiremock is running. This will speed up debug and make communication easier.
It should provide information about version, settings and
It can be (for settings like timeouts, journaling) something like
GET /__admin/settings
You can also consider something similar to get more information about Java and OS used as wiremock host
GET /__admin/hostInfo
References
https://wiremock.org/docs/standalone/admin-api-reference/#tag/System/paths/~1__admin~1settings/post

@pmirek looks like the endpoint GET /__admin/settings is already there. But its not documented.


Prevent auto play bugged?

Even with prevent tab auto play and prevent auto play checked, some videos still auto play.

have this issue too. seems kind of rare but every so often a video will auto play.

Not sure how to reference issues..
https://github.com/YePpHa/YouTubeCenter/issues/1116


The added subscription does not show in the resource tree view

OS: All
Build Version: 20230509.1
Regression: Not a Regression
Repro Steps:

Navigate to Azure Resource Groups: Selected Subscriptions setting.
Add a subscription, such as "Azure Tools Manual Testing 1".
Check whether the added subscription shows in the resource tree view.

Expect:
The added subscription shows in the resource tree view.
Actual:
The added subscription does not show in the resource tree view.
More Info:
This issue also reproduces when adding subscription by subscription ID.

It's worth noting, the setting will relatively soon be for both desktop and VSCode.dev/GitHub.dev.


Styling of histogram subsetting controls

Too blue, too big, lose the "Axis Controls" - lose surrounding box.  Hope for more breathing space to x-axis

Could look into grey/dark grey focus issue

the x-axis and y-axis controls look bad when forced to wrap, with a more narrow screen.  minimally they should be the same width.  or, like live site, when wrapped, take up full screen width

I think it's basically fixed now.  It's not any smaller/more compact but I've got used to it this size and think it's OK.
Danica's screenshot looks a bit messed up, but that's a very narrow screen.  I checked at 1280px and 1024px and it looks fine.
Closing this ticket.


Remove the String concept exercise.

This concept exercise only consists of stub data and an author file, it is not worthwhile to keep this data around.

Ah, I missed the implementation is separate in exercises/concepts, so there is at least something there. I will take a more holistic look to understand what's going on with the current version of Concepts before removing, since requirements have changed about 3 or 4 times since this was made.


Add unit test that verifies version range mechanisms

Placeholder: add a unit test that verifies the current spec.package.version range configuration when there's new bundles available that exceed that configured package.

Closing as this was relevant to the POC branch at the time.


feat: Save artifacts of AWS device farm in jenkins pipeline

Description
LEARNER-8533
Now every Jenkins job has test results of AWS device farm, saved in its own pipeline build, which was previously available for 30 minutes only. Now with every commit on Android repo, a developer can see automation results executed on the Jenkins job.

Add post step in jenkins pipeline
Archive video file, output text file, and customer Artifacts file if the build is successful

@farhan-arshad-dev can you please review this PR.?


Tune relaying of untrusted proposals & validations:

In deciding whether to relay a proposal or validation, a server would consider whether it was issued by a validator on that server's UNL.
While both trusted proposals and validations were always relayed, the code prioritized relaying of untrusted proposals over untrusted validations. While not technically incorrect, validations are generally more "valuable" because they are required during the consensus process, whereas proposals are not, strictly, required.
The commit introduces two new configuration options, allowing server operators to fine-tune the relaying behavior:
The [relay_proposals] option controls the relaying behavior for proposals received by this server. It has two settings: "trusted" and "all" and the default is "trusted".
The [relay_validations] options controls the relaying behavior for validations received by this server. It has two settings: "trusted" and "all" and the default is "all".
This change does not require an amendment as it does not affect transaction processing.

Proposals are necessary to be able to even do validations though, right?
I would prefer if both untrusted proposals and validations are by default relayed (as it is already the case). If server operators want to limit this for some reason, they now have the option to do so. Otherwise this creates incentives to collaborate more than maybe healthy or necessary with other node operators to even be able to reliably broadcast proposals.

Proposals are necessary to be able to even do validations though, right?

Even if you never see a single trusted proposal, as long as you see the validation you will continue. Of course, if nobody else sees a trusted proposal either, that's a problem.

I would prefer if both untrusted proposals and validations are by default relayed (as it is already the case).

This is not already the case: currently trusted proposals and validations are always related. Untrusted validations are, at present, never relayed and untrusted proposal are only if they're from a cluster peer or they're proposals on top of the last ledger we consider part of the consensus set.
The not relaying untrusted validations but relaying some untrusted proposals is topsy-turvy. Again, validations are more important than proposals.
With that said, we can certainly make the default for proposals be all instead of trusted.

If server operators want to limit this for some reason, they now have the option to do so. Otherwise this creates incentives to collaborate more than maybe healthy or necessary with other node operators to even be able to reliably broadcast proposals.

I don't know that I agree completely, but I can certainly understand the point you're trying to make.

Codecov Report

Merging #3391 into develop will decrease coverage by 0.01%.
The diff coverage is 31.70%.

@@             Coverage Diff             @@
##           develop    #3391      +/-   ##
===========================================
- Coverage    70.44%   70.42%   -0.02%
===========================================
  Files          682      682
  Lines        54392    54389       -3
===========================================
- Hits         38315    38306       -9
- Misses       16077    16083       +6

Impacted Files
Coverage Δ

src/ripple/app/consensus/RCLValidations.h
80.00% <ø> (ø)

src/ripple/app/misc/NetworkOPs.cpp
63.92% <0.00%> (+0.08%)
:arrow_up:

src/ripple/app/misc/NetworkOPs.h
100.00% <ø> (ø)

src/ripple/core/Config.h
100.00% <ø> (ø)

src/ripple/core/ConfigSections.h
100.00% <ø> (ø)

src/ripple/overlay/Overlay.h
88.88% <ø> (ø)

src/ripple/overlay/impl/OverlayImpl.h
32.39% <ø> (ø)

src/ripple/overlay/impl/PeerImp.cpp
0.00% <0.00%> (ø)

src/ripple/core/impl/Config.cpp
65.62% <16.66%> (-2.13%)
:arrow_down:

src/ripple/protocol/STValidation.h
52.08% <16.66%> (-14.59%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9771210...396dfd7. Read the comment docs.

@pwang200:

sfLedgerSequence is still marked as soeOPTIONAL in STValidation::validationFormat, but is required now. The reason is we don't want to change the API of RPC etc, right? Maybe add a comment in STValidation::validationFormat to explain?

I don't think there's any reason to not change it to soeREQUIRED. I'll double-check and do that.

Right, changing from optional to required is not a breaking change.

@pwang200: addressed the typo and marked the sfLedgerSequence field as required in validations. Courtesy unit test included.


🐛 [firebase_auth] Upgrade reCAPTCHA Enterprise for Mobile dependency

Bug report
As of January 18th, the Android SDK has been updated to address a security vulnerability in the reCAPTCHA Enterprise library (see: Android Release Notes). When will this fix be brought into the firebase_auth library?
See this image for the warning being shown in Google Play Console when uploading a new appbundle in the past few days.

/cc @Lyokone


Fix compilation on Linux

Fixes #1. This is a slightly hacky fix by wrapping up the KeyringError type in an adapter type that simply uses anyhow::Error and its Debug implementation. This bypasses the fact that KeyringError itself is not Sync on Linux. A better solution would be to update the dependency on dbus present within keyring, but it's unclear if that library is still maintained.

Forgot to mention: this includes a GitHub Actions workflow to build, test, format, and lint on Linux, Mac, and Windows.

Thanks!!


ci: remove rke related logic from setup scripts

ci: remove rke related logic from setup scripts
For https://github.com/longhorn/longhorn/issues/4990
Signed-off-by: Yang Chiu<EMAIL_ADDRESS>

Let's close this first since rke1 is still supported. Continue this when it's needed.


@amplitude/analytics-browser triggers the loading of @types/node which affects the signature of setTimeout

Expected Behavior
Importing @amplitude/analytics-browser should not force the loading of types defined in @types/node
Current Behavior
@amplitude/analytics-browser imports @amplitude/analytics-types, which references the node types:
<EMAIL_ADDRESS>  Type library referenced via 'node' from file<EMAIL_ADDRESS>with packageId '<EMAIL_ADDRESS>
The beginning of<EMAIL_ADDRESS>looks like that:
/// <reference types="node" />
import { Status } from './status';

This reference to the node types is inserted by the compiler due to using NodeJS.ErrnoException in the type declaration of SystemErrorResponse. But this causes the loading of all of @types/node, which will then define the return type of setTimeout as being a Timeout object and not a number, which is very annoying when writing a project targetting the web.
Possible Solution
Types relying on Node types should be defined in @amplitude/analytics-node rather than @amplitude/analytics-types. Or a different definition of SystemErrorResponse should be provided.
Steps to Reproduce

yarn add --dev @amplitude/analytics-browser @types/node
Add this code in test.ts:import * as amplitude from '@amplitude/analytics-browser'

const a: number = setTimeout(function () {})

Add this code in tsconfig.json:{
    "compilerOptions": {
        "noEmit": true,
        "esModuleInterop": true,
        "lib": ["dom"],
        "strict": true,
        "types": []
    },
    "files": [
        "test.ts"
    ]
}

Run the typescript type checker on that code (tsc -p .)
See the error Type 'Timeout' is not assignable to type 'number'. reported on the a variable assignment
Comment the import of Amplitude and see the error disappear.

Environment

JS SDK Version: @amplitude/analytics-browser 1.2.0
Installation Method: yarn
Browser and Version: n/a

@kevinpagtakhan any idea about when this could be fixed ? It is quite annoying that importing @amplitude/analytics-browser breaks the type checking of unrelated code in our project.

Hey @stof! Thanks for choosing Amplitude. I opened a PR to remove the dependency on @types/node in our internal types package. I'll have some folks take a look at it and we'll get it out as soon as we can.

Thanks


Add unsource subcommand to pkg

This worked out of the box because there was already existing functionality for it.
Currently gives no error if the source didn't exist in the first place (not sure if it should).
Closes: #18

Migrating to new PR #182  as remote is stale


Minor: chores: Update clippy in pre-commit.sh

Which issue does this PR close?

Rationale for this change

Sometimes my codes pass checks of pre-commit, but ci still fails. So I am wondering whether keeping the "clippy" consistent between  in pre-commit.sh and in CI would be beneficial.
What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Thanks again @my-vegetable-has-exploded

Thanks @alamb.


add encoder support

please add libvpx, vorbis and/or aac/ openh264/libx264  encoders.. or instructions on how to build them and reference them in the build process for uwp. There are a number of things we can't roll out on UWP due to missing functionality.

i'm using ffmpeg-autogen which exposes the full ffmpeg API but I need to actually build a version of ffmpeg that includes encoder libraries that work on UWP. That's proving to be quite painful. It'd be really great if there was some encoder support added at least with the royalty free encoders like vp8/9 and ogg.

First you will need to build those libraries with UWP platform target. That is probably the more difficult part. I have done this myself in the past e.g. for flac decoding (not through ffmpeg but standalone). Not impossible, but quite some work to get project files right and all the needed compiler switches. Once you have the libraries, linking them into ffmpeg is more a matter of enabling the right config switches in the ffmpeg build config file.

yeah hence the request :)
This project targets UWP with libvpx which would be a great start - vp8 and vp9 encoder support
https://github.com/ShiftMediaProject/libvpx
it should be quite straightforward to add the libs from this to the ffmpeg UWP build

libvpx depends on libvorbis, which depends on libogg. So you need those three, but they are also available from the same github author. Once you have built them, you need to add --enable-libvpx to ffmpeg build config. And I think you need to have the libs in your path.
http://wiki.webmproject.org/ffmpeg/building-with-libvpx


push mnist1d to pypi

with #9  being merged, I suggest we work towards pushing this repo to pypi

I just uploaded to pypl; see https://pypi.org/project/mnist1d/


Small cursor flicker when entering command.

When entering a command with the buffer scrolled to the top, but with the current cursor placed somewhere not on the top line of the file, hitting enter in the : command window makes a small caret flash on the first line.
Feel free to close if this is a dupe of another issue.
Thanks!

Thanks @jordwalke !
Might be a similar underlying issue to https://github.com/onivim/oni2/issues/1405 - when the command line is open, we lose track of the cursor.
Interestingly, I see the cursor flash on the first line when pressing enter but not esc (although, in both cases, the cursor disappears - it's just when pressing enter, the cursor comes back first on the first line, and then teleports to the previous position)

Thanks @jordwalke !
Might be a similar underlying issue to https://github.com/onivim/oni2/issues/1405 - when the command line is open, we lose track of the cursor.
Interestingly, I see the cursor flash on the first line when pressing enter but not esc (although, in both cases, the cursor disappears - it's just when pressing enter, the cursor comes back first on the first line, and then teleports to the previous position)


confused with the evalution results from val-set

'pts_bbox_NuScenes/NDS': 0.8238093679962551, 'pts_bbox_NuScenes/mAP': 0.83450670209427}
Per-class results:
Object Class    AP      ATE     ASE     AOE     AVE     AAE
car     0.873   0.256   0.114   0.033   0.260   0.195
truck   0.832   0.327   0.115   0.033   0.191   0.216
bus     0.842   0.323   0.104   0.027   0.293   0.245
trailer 0.778   0.395   0.116   0.041   0.136   0.124
construction_vehicle    0.783   0.405   0.173   0.079   0.137   0.322
pedestrian      0.805   0.380   0.203   0.181   0.245   0.136
motorcycle      0.821   0.337   0.150   0.085   0.347   0.213
bicycle 0.871   0.271   0.169   0.079   0.155   0.009
traffic_cone    0.877   0.241   0.162   nan     nan     nan
barrier 0.862   0.289   0.110   0.050   nan     nan
Compared with the index mAP=34.6 in the paper, 83.4 is extremely abnormal when the training model provided by the author is tested on the verification set. Has anyone ever been in that situation?

Hi, which model are you using?
The model DETR3D, VoVNet on trainval, evaluation on test set
is trained on the combination of training and validation set, and is used for submission of the leaderboard(test set).

May I ask how did you perform evaluation on the test set? 83.4%mAP seems to be overfitting ? @a1600012888

May I ask how did you perform evaluation on the test set? 83.4%mAP seems to be overfitting ? @a1600012888

Do you mean the DETR3D, VoVNet on trainval, evaluation on test set model with 41.2 mAP on test set.
The results is from submitting on the leaderboard. It is also the performance you see on nuscenes leaderboard.

Yes, I mean the DETR3D, VoVNet on trainval, evaluation on test set model but I am asking about the mAP,NDS in the log, which subset did you perform evaluation on?

Hi. Should be on the validation.
Remember we don't have access for the annotation of test set(it is a heldout set for the leaderboard)

Thanks, I got it. I was confused by the super high mAP, now I realize you trained on both train and val set.  @a1600012888
Just for curious, have you evaluated the results of above + CBGS on the test set? I wonder how much gap it will have for the results on val set and test set

@WangYueFt @XuyangBai @Yqmtf11 @a1600012888  hello, have you guys trained the vovnet on nuscenes training set, how about the metrics on val set? As for resnet version, I only found the val result of resnet from the original paper but no metrics on test set.


functions disabled at raspberry pi / ubuntu system

i just publish ouii asp.net mvc core app to raspbian,
ouii works great but funcitons are disabled..
like calculator sample.. i see percent bar, also dolar bar but when i insert values , nothing change
or click button sample ... you can try at http://areyhome.dynu.com
what can be problem?

if i run at localhost:5000 on ubuntu device, functions perfect run but if remote connect via ngix .. nothing more..

Do you run it behind a reverse proxy? I think you wanted to write "nginx". Maybe it is blocking the WebSocket?

@KevinGliewe  probably right! because the components are shown but methods are unavailable... not works anything.. also 2+2 lol :)
but on rasberry pie, when i try to connect on http://localhost:5000 everythings run perfect!
what could be solution?
thanks

@halukmy so the UI shows up but is not responding?
Do you get any output on the console?

can you check this : http://areyhome.dynu.com/Home/Contact
forms work perfect but on nghix its not works

@KevinGliewe  is there any update? did you able to check it?

@halukmy My guess is the web socket is being blocked. I can't reach your server, is it still up?


az interactive failed to run

gerald@Azure:~$ az interactive
The command failed with an unexpected error. Here is the traceback:
[Errno 30] Read-only file system: '/home/gerald/.azure/commands/2020-04-27.15-41-59.interactive.354.log'
Traceback (most recent call last):
File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 206, in invoke
cmd_result = self.invocation.execute(args)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 486, in execute
load_cmd_tbl_func=self.commands_loader.load_command_table, args=args)
File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 162, in raise_event
func(self, **kwargs)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/azlogging.py", line 80, in init_command_file_logging
self._init_command_logfile_handlers(cmd_logger, args)  # pylint: disable=protected-access
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/azlogging.py", line 101, in _init_command_logfile_handlers
logfile_handler = logging.FileHandler(log_file_path)
File "/opt/az/lib/python3.6/logging/init.py", line 1030, in init
StreamHandler.init(self, self._open())
File "/opt/az/lib/python3.6/logging/init.py", line 1059, in _open
return open(self.baseFilename, self.mode, encoding=self.encoding)
OSError: [Errno 30] Read-only file system: '/home/gerald/.azure/commands/2020-04-27.15-41-59.interactive.354.log'

interactive

Let's centralize similar issues to https://github.com/Azure/azure-cli/issues/13855.


WIP - test commit, add output path option to toascii

CI gfxreconstruct build queued with queue ID 13167.

CI gfxreconstruct build # 1340 running.


Add MultiprocessIterator to the reference

The current reference does not contain MultiprocessIterator due to the top of _last_signal = object().

LGTM!


Signaling project Change of term: JAK/STAT pathway

Hi
from JAK/STAT pathway - Signaling Project #1628
The current term for JAK/STAT is GO:0007259 JAK-STAT cascade. However, considering the few steps involved in the pathway, and the way most papers refer to it, it would be more appropriated to change this term to

JAK/STAT pathway

This change should be reflected in all the relative child terms and definitions.
@RLovering

GO:0097696 receptor signaling pathway via STAT needs to be renamed as
If the Jak/STAT is an internal pathway can we move it to:
GO:0007166 cell surface receptor signaling pathway

part of GO:0097696 receptor signaling pathway via STAT

GO:0035556 intracellular signal transduction

is a GO:0097696 receptor signaling pathway via STAT

@RLovering @gantonazzo
I think that we changed the term name to receptor signaling pathway via JAK-STAT so that we could include the ligands/receptors in the pathway, rather than just the JAK/STAT intracellular bit.

But why are we including the ligands and receptors?

So, we changed the name of this because in some cases  like Dmel, we only have one pathway "domeless" that acts via JAK/STAT, but as other species e.g. humans have many of receptors that and we wanted a term that encompassed the pathway as a whole.
Perhaps, having the term 'JAK-STAT intracelluar signaling cascette' would capture that particular aspect and we could keep 'receptor signaling pathway via STAT'; alternatively, we would need 'Domeless signaling' to provide a term that captures the ligand-TF/effector pathway in the pattern similar to other pathways.

Yeah this seems a bit odd to me too - so say TGF would be annotated to both 'TGF signaling' and 'JAK/STAT signaling'?
It seems we want either: TGF signaling is upstram of JAK/STAT signaling', or create the full pathway 'JAK/STAT-activating  TGF signaling', a bit like we have for the GPCRs; what do you think?

Looking at the emails from the orignal discussion, I think the fact that it was just a two-components with no downstream part was the deciding factor was the reason for making it a pathway and removing it from IC signaling, as it would be just 4 components for the pathway as it was: ligand-receptor-Jak-Stat
In favour of the a "whole pathway" term plus casette would be how we handle RTK pathways. @gantonazzo should be back at the end of the week, as she was involved in the orignal working group, best wait for her.

Based on the agreement for SMAD intracellular signaling ideally TGF would be annotated to
'TGF signaling' AND
positive regulation of 'JAK/STAT signaling' AE part of 'TGF signaling'
And JAK and STATs in the TGF pathway will be annotated to:
'TGF signaling'
'JAK/STAT signaling' AE part of 'TGF signaling'
Why not create a GO term unpaired signaling. Then you can have
GO:0007166 cell surface receptor signaling pathway

unpaired signaling pathway
Then unpaired (1,2,and 3) and dome would be annotated with
'unpaired signaling pathway' AND
positive regulation of 'JAK/STAT signaling' AE part of 'unpaired signaling pathway'

And JAK and STAT equivalents would be annotated with
'unpaired signaling pathway'
'JAK/STAT signaling' AE part of 'unpaired signaling pathway'
Then if we create the new relationships:
GO:0035556 intracellular signal transduction

is a GO:0097696 renamed JAK-STAT intracellular signal transduction

This would also mean that JAK and STAT equivalents would be associated with 'intracellular signal transduction' term which would be better for these proteins in non-insect species and would not be wrong for Dros JAK and STAT.
Plus currently unpaired and dome are not associated with positive regulation of intracellular signal transduction, but if we do create this consistent annotation approach then hopefully all other ligands and receptors will be associated with a positive/negative regulation of intracellular signal transduction term as well as to the term that describes the ligand/receptor pathway.
Thus if we do not create the JAK/STAT intracellular signal transduction term, we will have to create different guidelines for unpaired and dome than for the other receptors and ligands

Hi @RLovering - we would definitely need a direct replacement for this pathway, as it makes no sense to just label this distinct pathway with just  "unpaired receptor  signaling" - probably could go under 'cytokine-mediated signaling pathway'. However, we've have push back on terms that are said to be too specific in the past and we need a specific term for our pathway pages.
We probably need to discuss where regulation begins and ends in pathways - that's not an issue with what you propose - I am fine with the 'closeness' of the R-L to the IC pathway - but should this be where we draw the line - for example, things involved in cytokine secretion shouldn't be +ve reg of jak-stat.

Hi all,
As Helen said, we decided to change the original term since in certain organisms, like Dmel, the pathway doesn't have any downstream section. It just requires 4 components: ligand-receptor-Jak-Stat, so it made sense to include the ligand and the receptors in the pathway itself.
I don't think I am comfortable with the idea of having an "unpaired signaling pathway" term instead of what we currently have. In my opinion, either we go through a "Domeless signalling pathway" term route (but that would probably be too specific), or we keep the current term and add a cassette term to be used in those cases where you want to refer just to the intracellular signalling (which would be my preferred solution).
It all goes back to defining pathway boundaries, which is always tricky!

Discussion with @hattrill
In fact JAK is linked to the receptor, as far as we can tell: (image from wikipedia): https://en.wikipedia.org/wiki/JAK-STAT_signaling_pathway

so, it seems weird to de-couple the JAK/STAT from the receptor itself.
So, 'cell surface receptor signaling via JAK/STAT' seems most appropriate

Fixed label and definition:
GO:0007259
-old name: receptor signaling pathway via JAK-STAT
+new name: cell surface receptor signaling pathway via JAK-STAT
-old def: "Any process in which STAT proteins (Signal Transducers and Activators of Transcription) a
nd JAK (Janus Activated Kinase) proteins convey a signal to trigger a change in the activity or
state of a cell. The receptor signaling pathway via JAK-STAT begins with activation of a recepto
r and proceeeds through STAT protein activation by members of the JAK family of tyrosine kinases
. STAT proteins dimerize and subsequently translocate to the nucleus. The pathway ends with regu
lation of target gene expression by STAT proteins." [GOC:bf, GOC:jl, GOC:signaling, PMID:1203902
8]
+new def: "A cell surface receptor signaling pathway in which ligand binding causes the receptor to
dimerize, bringing the receptor-associated JAKs into close proximity. The JAKs then phosphorylat
e and activate each other on tyrosine residues.This leads to the activation of associated STAT p
rotein, causing the STATs to dissociate from the receptor, translocate to the nucleus. The pathw
ay ends with regulation of target gene expression by STAT proteins.


[Bug]: WANNA_GCP_DISABLE_REMOTE_VALIDATION has inverted logic

Contact Details
No response
What happened?
https://github.com/avast/wanna-ml/blob/897aaad27a88b70e9bb5a6e77f4b14343671d579/src/wanna/core/utils/env.py#L41-L57
shows that the logic is the complete oposite of what the name suggests
(wanna-notebook-demo) PS C:\Projects\wanna-notebook-demo> $ENV:WANNA_GCP_DISABLE_REMOTE_VALIDATION="false"
(wanna-notebook-demo) PS C:\Projects\wanna-notebook-demo> wanna version
ℹ WANNA GCP access allowed
ℹ WANNA cloud build access is enabled
ℹ WANNA remote validation is disabled
✅ Your wanna cli is up to date with 0.2.35
(wanna-notebook-demo) PS C:\Projects\wanna-notebook-demo> $ENV:WANNA_GCP_DISABLE_REMOTE_VALIDATION="true"
(wanna-notebook-demo) PS C:\Projects\wanna-notebook-demo> wanna version
ℹ WANNA GCP access allowed
ℹ WANNA cloud build access is enabled
ℹ WANNA remote validation is enabled
✅ Your wanna cli is up to date with 0.2.35

wanna.yaml file
none

wanna-ml CLI command
wanna version

Relevant log output
No response

The tests in https://github.com/avast/wanna-ml/blob/v0.2.35/tests/utils/test_env.py#L30-L34 show also that the logic is inverse of the name of the variable.


chore: bdd-nh-1585305815 to 0.0.1

chore: Promote bdd-nh-1585305815 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


MPD password not supported

The app doesn't seem to support specifying the password for MPD (if there is one). I can't use this client because MPD is available to my entire local network, so I need to set a password.

Good call. Would being able to set it using an environment variable work for you?

I've added the MPD_PASSWORD environment variable in the latest release. I'll be leaving this issue open though, since I'd like to allow logging in in the browser in the future

Should I rename this accordingly?

Sure


Wrong project name

If the package name is "stringy", the project name must be named like it ("stringy"), not "Stringy".

Okay @tredoe project name police it was named after danielstjules/Stringy because I took inspiration from that package. So nothing wrong with naming it that way.

The real issue is because when someone import your project using import "github.com/gobeam/Stringy", then the public functions and constants can not be called using "Stringy.SomeFunc()".
That's the reason why all projects in Go are named in lower case.

okay named in lower case now.


Can't create files on protected folders

Description
Just wanted to note i am currently being unable to directly create files or folders on windows protected folders i.e (C:/, C:/Windows)
Is there any way to run 'Files' app with UAC prompt atm?
Steps To Reproduce

Open Files app
Head to any windows folder i.e (C:/Windows)
Try to create any folder or file there (Right click, New)
Give it a name and press enter
The folder/file won't be created

Expected behavior
Heading to the desired system protected folder and creating a new file expecting UAC prompt to pop-up, giving it a name and successfully create it
Files Version
v<IP_ADDRESS>
Windows Version
Windows 10 Education 21H1 19043.1165
Relevant Assets
No response

Crating files as admin is not implemented. Deleting, renaming, copy/move instead should work.

Oh, ok, looking forward to have this possibility on next updates and finally start using FilesForWindows as my everyday File Browser


libgpiod: add patch fixing cross-compilation

Fixes "undefined reference to `rpl_malloc'".

Motivation for this change
Fixes build for armv7l and probably aarch64 as well. https://github.com/brgl/libgpiod/pull/45
Tested on x86_64 as well.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

LGTM

thank you stale bot, but this is still important to me and still necessary (despite the recent libgpiod bump)

Thanks!


Remove browser recommendation text

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #11153

Description

removed "Note Due to browser implementation differences, you may need to be at 100% zoom to pass the tests on this challenge." text from "Change the Font Size of an Element" challenge. Other translations were fixed by using google translate.

I think something went wrong with git. The entire file has been replaced. Maybe a line ending issue?

@tadake as @systimotic has pointed out, this is not coming through correctly. If you still have this branch, do a git pull --rebase upstream staging. Then open the file in your text-editor of choice and make your modifications again.  Finally, run git push origin fix/[your branch name] -f to force it to override the original commit.

@tadake mostly there, but the remnants of that last file are still here. Hmm, I'm not sure how to remove it. Anyone know? cc @FreeCodeCamp/issue-moderators

I've been having lots of issues with this @dhcodes . I previously had another PR and when I tried to squash my commits somehow my commits went from 2 to 10 and not all were mine. After trying numerous things I decided to re-fork the FreeCodeCamp and restart from scratch and something went wrong haha. I believe its fixed now after I ran your commands. I can view my changes now and everything seems good. Thanks for your help guys! I'm going to be more careful next time I mess with git hahaha.

ahh I see @dhcodes  I'm not sure how to remove the remnants.

@tadake no worries; I've been in the same boat before and I'm sure I will again. What do you get when you run git status on your branch now? Does it show the deletion unstaged?

I know the issue @dhcodes . I copied the file I changed and put it back in the wrong spot. To fix this I should delete the file and redo the steps from your comment above correct?

correct I believe @tadake but shouldn't need to rebase again.

I believe it's fixed now @dhcodes . hahaha Node schools git-it didn't cover this hahaha

Tested locally and LGTM 👍 . Thanks for contributing to FreeCodeCamp 🎉 . Also, fwiw Git Immersion is the best git tutorial I've found: http://gitimmersion.com/

@dhcodes


Add worker logs to cli output

@ahmelsayed I want to get better worker diagnostics in the console, this can help in the interim.

@mamaso,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


docs: fixed some small errors in docs

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for catching these @0xflotus 🙌


Secure data transfer between master/slave in different geographical regions

Is there a way to securely transfer cluster data between master and slaves, or is this already the case?  I'm ask because I plan on eventually doing load testing scenarios that include instances that are in 2 or more different geographical regions, which means they won't all be sharing some secure infrastructure by default, for example the same VPC in AWS.  Also, would there be a simple method of adding native HTTPS ability for the reporting GUI, or is it best to apply that a higher level?

There's no built in security for communicating between master and slaves. I'd suggest setting up firewall rules (though please note that the traffic is not encrypted, so someone could theoretically sniff the URL-endpoints being tested, as well as the response time statistics).
There's no built in TLS support, but you could probably set up nginx to proxy-pass to Locust.


Add header files for openssl and fast_float to build.zig?

I'm new to zig but wanted to let you know that I got the build to complete with the duckdb sources from yesterday.
I needed to make some changes, though:

add header files for openssl and fast_float
make change in src/common/operator/cast_operators.cpp - duckdb_fast_float::from_chars changed to fast_float::from_chars

I did not change the build.zig-file.
Could/should the build.zig-file be updated to take the above changes into account (perhaps mostly the first one)?
Details below:
The zig build command appears to need to be able to find some header files for openssl and fast_float. I am not sure if the build.zig file could be amended to find these, but it seems the build completed when I placed those header files in these locations (should those be in an include directory and/or under third_party?):
$ ls third_party/httplib/openssl/
asn1err.h         comperr.h         dsaerr.h          lhash.h           pem.h             sslerr.h
asn1.h            comp.h            dsa.h             md5.h             pkcs7err.h        ssl.h
asyncerr.h        conferr.h         dtls1.h           objectserr.h      pkcs7.h           stack.h
async.h           conf.h            ecerr.h           objects.h         rsaerr.h          symhacks.h
bioerr.h          cryptoerr.h       ec.h              obj_mac.h         rsa.h             tls1.h
bio.h             crypto.h          e_os2.h           opensslconf.h     safestack.h       x509err.h
bnerr.h           cterr.h           err.h             opensslconf.h.in  sha.h             x509.h
bn.h              ct.h              evperr.h          opensslv.h        srtp.h            x509v3err.h
buffererr.h       dherr.h           evp.h             ossl_typ.h        ssl2.h            x509v3.h
buffer.h          dh.h              hmac.h            pemerr.h          ssl3.h            x509_vfy.h

$ ls src/common/operator/fast_float
ascii_number.h  decimal_to_binary.h  fast_float.h  float_common.h
bigint.h        digit_comparison.h   fast_table.h  parse_number.h

Also, there was another complaint that could be fixed by making a change in cast_operators.cpp:
$ git diff src/common/operator/cast_operators.cpp
diff --git a/src/common/operator/cast_operators.cpp b/src/common/operator/cast_operators.cpp
index 20d0f2a5a..31a9f4896 100644
--- a/src/common/operator/cast_operators.cpp
+++ b/src/common/operator/cast_operators.cpp
@@ -1040,7 +1040,7 @@ static bool TryDoubleCast(const char *buf, idx_t len, T &result, bool strict) {
                len--;
        }
        auto endptr = buf + len;
-       auto parse_result = duckdb_fast_float::from_chars(buf, buf + len, result);
+       auto parse_result = fast_float::from_chars(buf, buf + len, result);
        if (!CheckDoubleValidity<T>(result)) {
                return false;
        }

Thanks Markus. I'll check this later today. I did earlier almost same changes but forgot to update the repo.

I will update build.zig for fastfloat so you don't have to take duckdb_ out because there is a purpose for it.


fix: allow editing review with old form

Closes #3254
Checks for missing form fields, none types in review editing
Further note:
This only fixes the 500 error as it appears.  When doing some testing on it, I noticed that the following also failed when working with a review that had its scores deleted, and then was edited:

View All reviews on the submission leads to a 500 error
Viewing the review itself seems to be missing some information (like the new score if I added one)

Because this is issue/PR is us trying to move changes we made to our fork into upstream to align the two codebases, I am submitting it as is.  For the other issues, would it be better to hold off on this fix until we have time to address some of the other things that pop up, or just create issues for them?  I lean toward merging and creating issues just because this PR does remove a 500 error and iterates toward a bug free system.

I can replicate the error. But I do not think this PR is the right solution.

Create a review form with 5 fields.
Write one review.
Modify the review form on the round/lab by removing 2 of the field.

If one tries to edit and save the existing review in current Hypha you get a 500 error, bad.
Editing and saving the review with this PR will delete the removed fields form the existing Review. This is really bad. Content is sacred, Hypha can not delete it without explicit action from users.

Further testing revels that Hypha already deletes fields from existing reviews when they are edited if the fields have been removed from the review from on the lab/round. This is a bad bug.
I have confirmed that submissions works as they should nothing gets deleted.
@theskumar Can you take a look at this? We safe the form for submissions, reviews etc in to "form_fields" so the form always match the "form_data". This works as expected with submissions but not with reviews.
We should check determinations as well, and Project approval forms since they all are stream field forms and should all work the same.


Concept for explorer

This is a concept made for explorer's new design, could this be taken on as files's uwp design.

Thank you for taking the time to make this concept, most users are very happy with the current design and the plan is to keep improving what we already have rather than doing a redesign. Feel free to let us know what you feel is lacking in the current design to help us improve the design further.

This cleans up some inconsistencies and makes it closer to the new edge and adds a tree structure and a preview and details pane.

https://github.com/duke7553/files-uwp/issues/692#issuecomment-619397873

Iirc the new WinUI now supports tree-view for side panels (https://twitter.com/gus33000/status/1255152407450796033?s=20), as for colored icons, sadly that can't be done since they rely on MDL2 Assets

Colored icons are in DLLs

Yeah but UWPs can't reference them for sidebars, iirc @yaichenbaum referenced that in another issue

Thanks for your feedback. We're having trouble understanding what you're requesting and need additional information to investigate this item. Please re-open when you've filled out the issue template to the best of your ability.