Blender 2.8 Eevee Render support

For the upcomming release of Blender 2.8, it is going to use the new Eevee Render. Can Godot 3.1 support .blend files while the .blend models are saved using the Eevee Render materials?

Importing .blend files is not really possible nor recommended. However, an exporter is being worked on:
https://github.com/godotengine/blender-exporter

Is this the gltf 2.0 exporter? Does this exporter (the one that you
provided me with the link) support Eevee Render?
On Fri, Feb 2, 2018 at 7:52 PM, Gilles Roudiere<EMAIL_ADDRESS>wrote:

Importing .blend files is not really possible nor recommended. However, an
exporter is being worked on:
https://github.com/godotengine/blender-exporter
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/16308#issuecomment-362524193,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BtkAOi0797nl7hCD9YfFnXAt_Ng3ks5tQsy1gaJpZM4R2vtE
.

Is this the gltf 2.0 exporter

No. It exports directly from blender to Godot, without using gltf 2.0.
There's no such thing as an "Eevee render material". Eevee in a renderer that supports PBR. Godot supports PBR too the the material created in Blender should be easily exported to Godot's renderer.

Oh ok nice. So I can use the Eevee Render, assign certain materials to the
model, including glass materials, emission materials and the mix shader
materials, and I am also able create animations using the armature, and
then I can export the model to that certain file format (I am not sure what
file format this addon exports to), and then Godot will support it with no
issues (once when the addon is ready)?
On Fri, Feb 2, 2018 at 11:48 PM, Gilles Roudiere<EMAIL_ADDRESS>wrote:

Is this the gltf 2.0 exporter
No. It exports directly from blender to Godot, without using gltf 2.0.
There's no such thing as an "Eevee render material". Eevee in a renderer
that supports PBR. Godot supports PBR too the the material created in
Blender should be easily exported to Godot's renderer.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/16308#issuecomment-362577481,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79Bs8VLhZLLo_U5SrNTV5CN3HaZv7zks5tQwQmgaJpZM4R2vtE
.

Well, with "no issue" we don't know yet. But the goal is to export directly to the .tscn format, so no other intermediate format.
Anyway I think we can consider this issue as solved since the exporter is already being worked on. :)

Thanks :) But would it support Glassy and Emmission materials if I were to
assign these materials to the model under the Eevee Render though?
On Sat, Feb 3, 2018 at 12:14 AM, Gilles Roudiere<EMAIL_ADDRESS>wrote:

Closed #16308 https://github.com/godotengine/godot/issues/16308.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/16308#event-1455050990, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Ab79BlHW9YUkZ4xXpQ5ilqknhzEa_21qks5tQwoygaJpZM4R2vtE
.

I believe so.

https://twitter.com/reduzio/status/957659011054227456
in this twitter discussion there is some interesting information.
Evee uses the priciple shader which is afak really close to Disney's BRDF which is also what godot uses. So the principle shader will work really well I think.
but even for other shaders it seems it will be possible!


Add overview video to Readme

:tada: This PR is included in version 0.2.12 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.2.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[BUG]

Describe the bug
I want to install a specific version of cython using
pip install Cython==0.29.36
but i am getting error
"ERROR: Could not find a version that satisfies the requirement Cython==0.29.36 (from versions: none)
ERROR: No matching distribution found for Cython==0.29.36"

Code to reproduce the behaviour:
# example code

Expected behaviour
No response
OS
Windows
Python version
3.10.9
Cython version
0.29.36
Additional context
I want to install a specific version of cython using
pip install Cython==0.29.36
but i am getting error
"ERROR: Could not find a version that satisfies the requirement Cython==0.29.36 (from versions: none)
ERROR: No matching distribution found for Cython==0.29.36"

That looks very much like you have a network connection issue so pip isn't able to connect.

Thank you for your feedback I will try again.
On Saturday, October 21, 2023, 6:05 PM, da-woods @.***> wrote:
That looks very much like you have a network connection issue so pip isn't able to connect.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


isl: add 0.17.1

Motivation for this change
Upgrade isl to the latest version.
@wkennington @globin @fpletz (Not sure whom to ping, here...)
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Thanks!


Switching to Continuous breaks the app

The title sums it up pretty well, switching from paginated to continuous completely breaks the app completely, it freezes and I can’t press anything on the ttu reader and I have to delete the app and re add all my books and dictionary’s. I hope you can fix this issue or at least add like a clear ttu reader or something that resets it, so I don’t have to re add everything if something glitches. The app is dope btw

I forgot to mention I am on iOS btw, and closing out of the app doesn’t do anything either

I have tried continuous (both vertical and horizontal) on the simulator and my iPhone, and there is a noticeable sluggishness but nothing has broken the app.
I will disable the continuous mode for now.

 i have a decent amount of frequency dictionaries so it does crash for me


Cross prime meridian fix

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes issue https://github.com/roocs/clisops/issues/35

[x] Tests for the changes have been added (for bug fixes / features)
[x] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion minor has been called on this branch
[ ] I have added my relevant user information to AUTHORS.md

What kind of change does this PR introduce?:
Bug fix - where the subset request crosses the meridian but the longitudes are all positive, this implements a method to roll the dataset and reassign the coordinates to allow this subset to take place

Does this PR introduce a breaking change?:
I don't think so

Other information:
This also removes pyyaml from the requirements - I added this before the 5.4 of pyyaml version was released on conda to allow the docs to build. This version has now been released so this is no longer needed.

@huard @Zeitsperre This is our fix for coping with bounding box subsets where the requested longitude range does not overlap with the longitudes of the data itself. We believe there are no issues from your end because all the changes are dealt with in clisops.ops.subset and we haven't touched clisops.core.subset.
Please shout if you spot any problems with this. We plan to merge it tomorrow morning (UK time).

Wow! This is a spotless fix. I'm glad to see that it doesn't roll the data on the core utilities, and it seems to address the concerns you had around this. Nicely done.
Just a thought, but maybe it would be interesting to (in another PR) implement a fix on the core side that turns a bounding box into a shape in the event that it crosses the meridian/edge of the data set and sends that to the subset_shape function? It would be interesting if we could offer both approaches in CLISOPS eventually (rolling and vector-splitting).

@Zeitsperre Thanks for the review. Sounds like a good idea - I've opened an issue for it #119


Bicep Code to Full Code

Describe the feature end to end, including deployment scenario details under which the feature would occur.
Hello @jtracey93
I am trying the bicep Code. And I can able to see in GitHub repo for each resource creation we have Management group, policy and etc we need to run one by one.
Do we have overall bicep code that can be run so that once the Management is created. then the subscriptions and resources and policies.
Just Like how we deploy in Portal where deploys one by one. Do we have something in Bicep.
Awaiting Reply...
Thank You....
Why is this feature important. Describe why this would be important for your organization and others. Would this impact similar orgs in the same way?
NA
Please provide the correlation id associated with your error or bug.
NA
Can you describe any alternatives that you have taken since this feature does not exist?
NA
Feature Implementation
NA

Check previous GitHub issues

[X] I have searched the issues for this item and found no duplicate

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @Anto4595
There is no single bicep deployment to do it all. Each module is separate and needs to be deployed in the correct order as defined here: https://github.com/Azure/ALZ-Bicep/wiki/DeploymentFlow
Hope that helps


Wrong token colors display in editor

Issue Type: Bug

Description
When I pass number literal as a parameter of type parameter of function, the function and the type parameter are not colored as expected

Version: 1.44.0-insider (system setup)
Commit: 0dbae2083aff6ff2190c8e2157be95458915d464
Date: 2020-04-03T05:44:09.945Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

Please share the text of the code along with screenshots


Decoupled front end

The set of patches implements the decoupled front-end in gem5.
I marked it as WIP as it depends on #356, #357, #358.
The full implementation as well as an example how to use it is described here:
https://github.com/dhschall/gem5-fdp

A small note: there is another known fdp in the context of prefetching - the feedback directed prefetcher. It would probably be better to rename the file to not use the abbreviation.

Hello,
I'm starting to evaluate this implementation of decoupled front-end + fdp for research purposes.
First thanks for the excellent work, the code is very clean and readable!
I cherry-picked the commits of your personal branch with the latest fix for fetchTargetWidth in bytes and not instructions and for the prefetcher memory leak.
For a variety of workloads, I don't find significant IPC change. Most of them have a slight IPC decrease while using decoupled front-end over the old front-end. Even for workload that are fronted bounded.
I didn't try the FDP, I want to fully understand the decoupled front-end trade-offs before.
In my configuration, the fetch buffer size is 32 and I tries various size of fetchTargetWidth from 4 to 124. All of them have worse perf than the old front-end:/
I have 2 main questions after reading your code:
1- I see that in your implementation,  the fetch stage can only have 1 concurrent access to the icache. So the only speedup available is using FDP to prefetch entries waiting in the FTQ using the rest of the bandwidth (basically all MSHR - 1)
IIUC, the other implem from @bgodala removes this limits and allow for concurrent icache access. It then reorder the response in a buffer.
What are your thoughts on this?
2- While reading the industry perspective paper I also see one major difference: in the paper, an FTQ entry is created when a taken branch is encountered. IIUC it might takes multiples cycles before a taken branch is detected and an entry is added in the FTQ.
In your implem, each cycle where the BAC stage is not blocked, an entry will be created, even if no branch are detected.
Why did you choose to implement this way?

Hi @trollet91 ,
thank you very much for taking the time to look into it and for the great comments.
First of all, I can confirm that we (@rjc-arch and me) also found that the performance is still not good for a bunch of workloads. I guess I made a bug while refactoring the changes and I currently try to find it.
Just for me as context. What architecture (arm/x86) are you using and are you on this branch?
Also, what do you mean by I didn't try the FDP. Do you mean you have decoupledFrontEnd=False?
RE 1: Great question! You are correct in the current implementation I put the prefetching in a separate component that can be connected to the I-cache (./src/mem/prefetch/fdp.xx). However, I don't think it's a nice solution as its quite error prone. I like more the implementation of @bgodala and I started to rework that part.
RE 2: My understanding of IV is that every cycle a prediction is made on an entire 16B aligned address block. The first taken branch ends the fetch target or, if no branch is taken, the beginning of the next sequential 32B block boundary.
However, limiting the maximum fetch target size has another reason. If your BTB is completely cold or you have a very long sequential block you will not feed the FTQ with fetch targets and the fetch unit has to wait. Producing one fetch target per cycle ensures that the fetch unit has to wait only one cycle after a squash to start fetching.

Hi @dhschall ,
Any progress on the merging of fdp code as per the implementation in https://github.com/bgodala/gem5/tree/fdip to https://github.com/dhschall/gem5-fdp ?
I assume, the pipeline stage, bac, and how fetch stage access information from bac stage will remain the same. Will there be change in ftq implementation (src/cpu/o3/ftq.cc) ?

Hey @atrah22, yes I started to reworked my code with some of the ideas from the other FDP implementation.
It requires some changes especially in the BAC stage.
It works so far but I have to do some code refactoring. Will try to complete this in the next days.

Hello @dhschall
For now I'm only working on ARM.
Actually my configuration was wrong on the old test.
I had the misunderstanding that fetch was sending multiple requests in paralleled and on top of that the hardware prefetcher that you used was used to prefetch way in advance.
My goal was to only test the fetch part (the fdip hwp was disabled) and it was not giving me improvements. The performance stagnation is actually expected as the decoupled fronted without the prefetch is pretty much similar to the old front-end.
I am re-evaluating the performance with the HWP enabled. But seems like there is still a memory leak as memory explodes during long simulations (even with the patch that you sent in your local branch). Currently trying to fix that.

From a quick read of the other fdip implem, the fetch engine is sending multiple fetches in parallel. It reads the response and reorder them before sending the bytes to decode.
I'm not sure this implementation is better. From my understanding front-end have still only one concurrent fetch access to icache, and the rest is prefetched. But I don't have fetch engine uarch knowledge on latest high performance cores.

I'm preoccupied by the ease of configuration of the front-end.
Now we have two configurations  variables that may clash .
We have the fetchBufferSize that gives the number of bytes to fetch on each icache access.
We also have fetchTargetWidth that gives the number of bytes to lookup. In the current implem it also gives the maximum size of each FTQ entry (it creates a FTQ entry at the end if it does not find any branch).
What happens on straight line code if fetchTargetWidth is bigger than fetchBufferSize.
Ex: 100000 straight line nops
FetchBufferSize 32
FetchTargetWidth 40
Does this means rgat one cycles the front-end is going to fetch 32 bytes, then 8, then 32, then 8 in the current implem?
If it is the case:
Creating FTQ entries that are multiples of fetchBufferSize could solve this issue without adding complex code, to the already very complex fetch code.
Another solution would be to put basic block in the FTQ. To avoid the problem with cold BTB, we could have a maximum size before creating a FTQ (that is a multiple of fetchBufferWidth).

Would be nice to have other persons with actually uarch knowledge that could share insights (non confidential of course 😉) @andysan maybe some ppl for ARM?

Hello @dhschall , I have question (or maybe it is a bug).
Btw, I am using a different BTB structure, with different algorithm for lookup and update as per the RTL code (confidential). However, the flow is similar to your default code, in case of a BTBHit, branch predictor (predict function) is called.
Anyway, the bug/my question seems to be regarding the way the FTQ is updated in bac.cc file in void BAC::generateFetchTargets(ThreadID tid, bool &status_change) function. Below is the part of the code. Please go through my comment lines
cur_pc.set(search_addr);
//cur_pc is set to either the last instruction addr or the branch instruction addr
..........
.........
if (branch_found) {

        // branch_found as per the BTB (bpu->BTBValid(tid, search_addr);)

         staticInst = bpu->BTBLookupInst(tid, cur_pc);
        assert(staticInst);

        predict_taken = predict(tid, staticInst, curFT, *next_pc);

        DPRINTF(BAC, "[tid:%i, ftn:%llu] Branch found at PC %#x "
                "taken?:%i, target:%#x\n",
                tid, curFT->ftNum(), cur_pc.instAddr(),
                predict_taken, next_pc->instAddr());

        stats.branches++;
        if (predict_taken) {
            stats.predTakenBranches++;
        }
        // if predict_taken == false, then that means the BTB prediction didn't match with the branch predictor

    } else {
        next_pc->set(cur_pc.instAddr() + minInstSize);
    }

   /**
    * The bug seems to be in the following line, when branch_found == true && predict_taken == false
    * curFT-> finalize function makes the fetchTarget endPC = curPC, branch_found = true, predict_taken = false
    * When updatePC is called from fetch stage and thereby updatePreDecode function is called, it looks for fetchTarget's predictTaken() function which returns predict_taken.
    * So what happens is, it detects that prediction is not taken but a branch is found. However the endPC is still the branch addr (cur_pc)
    * Shouldn't the cur_pc be equal to the end of cacheline (for my case) or the end of stat_addr + fetchTargetWidth (as per the BTB valid check algorithm in your code), when the branch is not taken?
   */

    curFT->finalize(cur_pc, curFT->ftNum(), branch_found,
                        predict_taken, *next_pc);

I think adding an else condition like below could be a solution
   if (predict_taken) {
            stats.predTakenBranches++;
        }
   else {
    branch_found = false;
    search_addr = ........ // end of cacheline or start_addr + fetchTargetWidth
    cur_pc.set(search_addr);
    // if predict_taken == false, then that means the BTB prediction didn't match with
      the branch predictor.
   // change the endPC for fetchTarget which is cur_pc from the branch inst addr and make branch_found =0;
   }

Hey @atrah22, thanks for the hint.
You are right. In the current implementation fetch stops fetching whether the branch was taken or not.
I have to check how to handle this.
I'm not sure if your fix will solve the problem entirely. The problem is the BAC stage does the same and ends on any branch. If you continue without poping and moving to the next FT then BAC and Fetch are out of sync and the inRange() check will fail.
I either have to continue in the BAC stage or allow processing multiple FTs in one cycle.
IMHO the former one is better but then I need to support multiple branches to be in one FT where only one can be taken.

Hello @dhschall , Yes I agree that the support for multiple branches to be in one FT where only one can be taken is better.
For now though, I modified only fetch Stage in fetch.cc (no change in bac.cc file) to allow processing multiple FTs in one cycle when there is a not taken branch and the next PC is in the following FT. It shows performance improvement for a FS simulation of relatively big single core workload.
This feature could be important for performance.

Thanks @trollet91 for coming up with this list! All points look quite reasonable to me and would improve the implementation.
Some comments on your points:

#FT: I agree to start with one FT per branch (taken or not). It might look weird as all references say its one FT per cycle but the problem is the branch predictor history and how to manage that.

FT cross CL/alignment: For prefetching and translation it might be better to not cross. The problem is in x86 instructions can cross cache lines

taken branches: Might be easier to start with one but in case we can have more would be great. After all its a simulator to explore future design decisions not only simulating SOTA.

Max fetch target size: Limiting it to fetchBufferSize makes only sense if we generate several fetch targets in one cycle. The BAC stage bandwidth must be larger than the fetch stage. Otherwise, the BAC stage can never gain sufficient prefetch distance.

Why do you want concurrent fetches and in addition prefetches? I understand it that the demand read into the fetch buffer is a fetch all others are prefetches. Of course, you can say you pipeline the next already but what is the difference to a prefetch?

I look forward to your modifications :)
Thanks again!

#FT: I agree to start with one FT per branch (taken or not). It might look weird as all references say its one FT per cycle but the problem is the branch predictor history and how to manage that.

Why should we create a FT on a detected but  non taken branch? Is this to simplify the history management?

Max fetch target size: Limiting it to fetchBufferSize makes only sense if we generate several fetch targets in one cycle. The BAC stage bandwidth must be larger than the fetch stage. Otherwise, the BAC stage can never gain sufficient prefetch distance.

I think we need to be able to generate multiple FT in one cycle to support multiples taken branches in one cycle. The other solution is to have two non contiguous part in one FT. This is harder to implem and I doubt that it will be implemented like that in a real design.
Regarding the FT creation: let's say that fetchBufferSize is 32, and fetchTargetWidth is 48.
We have 3 options:
1/ Generate a FT for 48 bytes. This means the front-end as to fetch multiple times from the same FT.
2/ Generate a FT of 32 bytes and another FT of 16 bytes.
3/ generate one FT of 32 bytes. The 16 bytes leftover will be included in the next FT created the cycle after.
IMO the design  3/ are is easier to implement than 1/ and 2/ because the fetch stage will fully consume entry at once. This simplifies fetch logic. The generation logic is now slightly more complex but should stay very simple.
FT creation policy:

taken branch detected
reach end of cacheline
reach size of fetchBufferSize

Would you agree with a design like that?

Why do you want concurrent fetches and in addition prefetches?

For a bigger core that predicts 2 taken branches per cycle, you may want to consume two entries per cycle. But we can discuss that later it's not important now.

Hello, @dhschall and @trollet91, Full system simulation even for a small workload keeps running (stuck in loop) I think due to the warning message (in performCacheAccess function in fetch.cc) . Address is outside of physical memory, stopping fetch. This small workload (CCa of microbench) is very simple and worked always for other branch (fdp) or any version of gem5. I think, there may be a bug.
if (!cpu->system->isMemAddr(mem_req->getPaddr())) {
        warn("Address %#x is outside of physical memory, stopping fetch\n",
                mem_req->getPaddr());
        fetchStatus[tid] = NoGoodAddr;
        memReq[tid] = NULL;
        return false;
    }

Hi @atrah22 , thanks for letting me know!
That's very likely. The last commit was just a first attempt to rework and integrate suggestions from @andysan and the other FDP implementation. Though, I did not have the time to do proper cleanup and testing.

Hi @atrah22 , thanks for letting me know! That's very likely. The last commit was just a first attempt to rework and integrate suggestions from @andysan and the other FDP implementation. Though, I did not have the time to do proper cleanup and testing.

Hello, Another problem I found is regarding the tage predictor when speculativeHistUpdate flag is turned to false. There is a segmentation fault. Maybe its due to the commit "cpu: BPU support for surprise branches"

Update for anyone interested in this feature.
I took over the code from David Schall. My goal is to make the implem a bit more close to a modern processor.
The biggest change is that the Fetch class is now pure virtual and inherited by two classes 'SimpleFetch' and 'DecoupledFetch'.
SimpleFetch is the old implem and DecoupleFetch is a total new fetch pipeline implem.
Having the decoupled fetch logic on top of the old fetch logic was too hard to write/validate.
Right now I'm using the new decoupled frontend in ARM SE for an internal research project.
It's already bringing performance improvements compare to the old frontend in benchmarks with code footprint too big for icache. And similar performance for small benchmarks that fits in cache.
Once I'll be totally confident about the behavior, I will add back the code from David to handle x86 jump in uops and FS specific stalls and finally send the code to review. But it will still take some time.

@trollet91,
Is it possible now to look at the code from your git branch for the decoupleFetch even if not ready for review? That would be great. thanks.

@atrah22 Sorry right now it's in a internal zone of the company to run internal benchmarks that stresses the icache, AKA not SPEC 😄 . Moving it to upstream will require some paperwork so I will only do it once.

@dhschall , @trollet91 ,
I have another question,
After simulation, the stat, bac.noBranchMisspredict is 3,000 ~ 4,000 for a micro-benchmark. Why a non-control instruction causes a squash/flush and why a non-control instruction is miss predicted? The DPRINTF comment "Squashing due to mispredict of non-control instruction" is in the bac.cc file.


Add codeowners for documentation

Relates to https://github.com/ROCm/ROCm/issues/2832
Adding documentation team as codeowners for documentation.
Goal is to make this group of code owners reviewers when merging documentation changes.
Please note that this requires the team to be added as a role with Write permissions.

Please remove the executable permissions from the codeowners file.

Fixed in latest.
Also, would someone with admin permissions to this repo be able to add the ROCm Documentation team with write permissions? GitHub flags the additions to the CODEOWNER file as an error otherwise. Thanks!

@samjwu I added the docs team with write privilege
can you also add the original code owners to all the docs files?


chore(api): remove duplicated space

duplicate of https://github.com/DeleterBot/deleter-v2/pull/5.


asfreq / resample do not set freq with regular timeseries

If your timeseries has a regularly spaced index, so if a frequency can be inferred, using asfreq or resample with this frequency does not set the frequency (it remains None):
In [1]: df = pd.DataFrame({'date':["2012-01-01", "2012-01-02", "2012-01-03"], 'col':[1,2,3]})
In [2]: df2 = df.set_index(pd.to_datetime(df.date))
In [3]: df2.index
Out[3]:
<class 'pandas.tseries.index.DatetimeIndex'>
[2012-01-01 00:00:00, ..., 2012-01-03 00:00:00]
Length: 3, Freq: None, Timezone: None

In [4]: df2.index.inferred_freq
Out[4]: 'D'

In [5]: df2.asfreq('D').index
Out[5]:
<class 'pandas.tseries.index.DatetimeIndex'>
[2012-01-01 00:00:00, ..., 2012-01-03 00:00:00]
Length: 3, Freq: None, Timezone: None

In [6]: df2.resample('D').index
Out[6]:
<class 'pandas.tseries.index.DatetimeIndex'>
[2012-01-01 00:00:00, ..., 2012-01-03 00:00:00]
Length: 3, Freq: None, Timezone: None

Note: this is the same with a Series, however in 0.12 it works for Series (as then it is still a TimeSeries)

@jreback I can't reproduce this issue. Has it been solved already?
In [3]: df = pd.DataFrame({'date':["2012-01-01", "2012-01-02", "2012-01-03"], 'col':[1,2,3]})

In [4]: df2 = df.set_index(pd.to_datetime(df.date))

In [5]: df2.index
Out[5]: DatetimeIndex(['2012-01-01', '2012-01-02', '2012-01-03'], dtype='datetime64[ns]', name=u'date', freq=None)

In [6]: df2.index.inferred_freq
Out[6]: 'D'

In [8]: df2.asfreq('D').index
Out[8]: DatetimeIndex(['2012-01-01', '2012-01-02', '2012-01-03'], dtype='datetime64[ns]', name=u'date', freq='D')

In [9]: df2.resample('D').index
Out[9]: DatetimeIndex(['2012-01-01', '2012-01-02', '2012-01-03'], dtype='datetime64[ns]', name=u'date', freq='D')

That is certainly possible that some other change has fixed this. Do you want to do a PR to only add a test case to close this issue?

Sure

tested via #12001


Real world example / Troubleshooting

Thanks for an interesting project!
The whole point of this project is to be able to write files in a docker container via ENV variables. However, the examples you provide still contain all of the values inside the Dockerfile and are called without any env variables being passed.
I'm creating this issue because it's not working for me. Here is my complete example:
Dockerfile:
FROM ubuntu as base

RUN apt-get update; apt-get install -y jq curl

# Download the latest version of udl
RUN curl -s https://api.github.com/repos/mcasperson/UltimateDockerLauncher/releases/latest | \
    jq '.assets[] | select(.name|match("udl$")) | .browser_download_url' | \
    xargs -I {} curl -L -o /opt/udl {}

FROM otel/opentelemetry-collector-contrib:0.78.0

COPY --from=base --chmod=755 /opt/udl /opt/udl
# COPY otel-config.yaml /config/otel-config.yaml

ENTRYPOINT [ "/opt/udl" ]
CMD [ "/otelcol-contrib", "--config", "/config/otel-config.yaml" ]

docker run:
docker run -e UDL_WRITEB64FILE[/config/otel-config.yaml]='IyBzb21lIGNvbW1lbnQgdG8gc2VlIGlmIGZpbGUgaXMgcmUtdXBsb2FkZWQgd2hlbiBpdCB3YXMgY2hhbmdlZA0KZXh0ZW5zaW9uczoNCiAgaGVhbHRoX2NoZWNrOiB7fQ0KcmVjZWl2ZXJzOg0KICBvdGxwOg0KICAgIHByb3RvY29sczoNCiAgICAgIGh0dHA6DQogICAgICAgIGNvcnM6DQogICAgICAgICAgYWxsb3dlZF9vcmlnaW5zOiBbIioiXQ0KICAgICAgICAgIGFsbG93ZWRfaGVhZGVyczogWyIqIl0NCiAgZmx1ZW50Zm9yd2FyZDoNCiAgICBlbmRwb2ludDogMC4wLjAuMDo4MDA2DQpwcm9jZXNzb3JzOg0KICBiYXRjaDoNCiAgIyBXaWxsIGNvbnZlcnQgYWxsIG1vbm90b25pYywgY3VtdWxhdGl2ZSBzdW1zIHRvIG1vbm90b25pYywgZGVsdGEgc3Vtcw0KICBjdW11bGF0aXZldG9kZWx0YToNCiAgdHJhbnNmb3JtOg0KICAgIHRyYWNlX3N0YXRlbWVudHM6DQogICAgICAtIGNvbnRleHQ6IHNwYW4NCiAgICAgICAgc3RhdGVtZW50czoNCiAgICAgICAgLSB0cnVuY2F0ZV9hbGwoYXR0cmlidXRlcywgNDA5NSkNCiAgICAgICAgLSB0cnVuY2F0ZV9hbGwocmVzb3VyY2UuYXR0cmlidXRlcywgNDA5NSkNCiAgICBsb2dfc3RhdGVtZW50czoNCiAgICAgIC0gY29udGV4dDogbG9nDQogICAgICAgIHN0YXRlbWVudHM6DQogICAgICAgIC0gdHJ1bmNhdGVfYWxsKGF0dHJpYnV0ZXMsIDQwOTUpDQogICAgICAgIC0gdHJ1bmNhdGVfYWxsKHJlc291cmNlLmF0dHJpYnV0ZXMsIDQwOTUpDQpleHBvcnRlcnM6DQogIGxvZ2dpbmc6DQogICAgbG9nbGV2ZWw6ICRMT0dfRVhQT1JURVJfTE9HX0xFVkVMDQogIG90bHA6DQogICAgZW5kcG9pbnQ6ICRFTkRQT0lOVA0KICAgIGhlYWRlcnM6DQogICAgICAiJEFQSV9LRVlfSEVBREVSX05BTUUiOiAkQVBJX0tFWQ0Kc2VydmljZToNCiAgZXh0ZW5zaW9uczogW2hlYWx0aF9jaGVja10NCiAgcGlwZWxpbmVzOg0KICAgIG1ldHJpY3M6DQogICAgICByZWNlaXZlcnM6IFtvdGxwXQ0KICAgICAgcHJvY2Vzc29yczogW2N1bXVsYXRpdmV0b2RlbHRhLCBiYXRjaF0NCiAgICAgIGV4cG9ydGVyczogW2xvZ2dpbmcsIG90bHBdDQogICAgdHJhY2VzOg0KICAgICAgcmVjZWl2ZXJzOiBbb3RscF0NCiAgICAgIHByb2Nlc3NvcnM6IFt0cmFuc2Zvcm0sIGJhdGNoXQ0KICAgICAgZXhwb3J0ZXJzOiBbbG9nZ2luZywgb3RscF0NCiAgICBsb2dzOg0KICAgICAgcmVjZWl2ZXJzOiBbb3RscCwgZmx1ZW50Zm9yd2FyZF0NCiAgICAgIHByb2Nlc3NvcnM6IFt0cmFuc2Zvcm0sIGJhdGNoXQ0KICAgICAgZXhwb3J0ZXJzOiBbbG9nZ2luZywgb3RscF0NCg==' infrastructure/otel-collector:latest

And it fails with:
Error: failed to get config: cannot resolve the configuration: cannot retrieve the configuration: unable to read the file file:/config/otel-config.yaml: open /config/otel-config.yaml: no such file or directory
What am I doing wrong? How can I troubleshoot this?

Okay, I think I figured it out: Because otel/opentelemetry-collector-contrib is based on the scratch image, the process running in the container seems to have no permission to write files to disk. It would be great if /opt/udl could be a bit more verbose

That is good feedback - better error messages would definitely help here. Most of the tests focus on the happy path and do not capture failures like permission errors.

The example above will now write the error:
panic: Operation mkdir failed at path "/config/" with error "permission denied". This is usually a permission error. Make sure the Docker user has permission to this path.


Improve sample binary build dependencies

Binary crate dependencies continue to be a weak point in Cargo. This just attempts to make the binary component samples build a little bit more reliably. In these two cases, the dependent (client) crates need the component (server) crates built ahead of their build scripts as it relies on the component to produce the .winmd files that the build scripts use to generate bindings.

But of course, that doesn't work since the yml tests are executed with an explicit target which means that Cargo doesn't use the default target location for binaries, a further reminder of how poorly binaries are supported in Cargo. 😢 https://github.com/rust-lang/cargo/issues/9661


odd provider crash

random provider error i got today.
provider version == "0.13.0-2"
tf version == "1.5.7"
im doing nothing unusual here. the plan looks good, no code changes have been made since last successful run.
Plan: 2 to add, 0 to change, 1 to destroy.
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the
│ plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more
│ details.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the
│ plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more
│ details.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the
│ plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more
│ details.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the
│ plugin6.(*GRPCProvider).ValidateResourceConfig call. The plugin logs may
│ contain more details.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the
│ plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more
│ details.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).ValidateResourceConfig request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).ValidateResourceConfig request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the
│ plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more
│ details.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the
│ plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more
│ details.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).ValidateResourceConfig request was cancelled.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the
│ plugin6.(*GRPCProvider).PlanResourceChange call. The plugin logs may
│ contain more details.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).ValidateResourceConfig request was cancelled.
╵

Stack trace from the terraform-provider-opslevel_v0.13.0-2 plugin:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xb99638]

goroutine 2521 [running]:
github.com/opslevel/terraform-provider-opslevel/opslevel.(*ServiceRepositoryResource).Read(0xc000146000, {0xf2f7e8, 0xc0021b81b0}, {{{{0xf346c0, 0xc001e6af30}, {0xc89b00, 0xc001e6ae10}}, {0xf36b88, 0xc0011ae0f0}}, 0xc000146060, ...}, ...)
	github.com/opslevel/terraform-provider-opslevel/opslevel/resource_opslevel_service_repository.go:229 +0x3b8
github.com/hashicorp/terraform-plugin-framework/internal/fwserver.(*Server).ReadResource(0xc0001d7520, {0xf2f7e8, 0xc0021b81b0}, 0xc0021b8240, 0xc0014736d0)
	github.com/hashicorp/terraform-plugin-framework@v1.8.0/internal/fwserver/server_readresource.go:101 +0x64e
github.com/hashicorp/terraform-plugin-framework/internal/proto6server.(*Server).ReadResource(0xc0001d7520, {0xf2f7e8?, 0xc0021b8090?}, 0xc0021c6000)
	github.com/hashicorp/terraform-plugin-framework@v1.8.0/internal/proto6server/server_readresource.go:55 +0x3e5
github.com/hashicorp/terraform-plugin-go/tfprotov6/tf6server.(*server).ReadResource(0xc0000a1e00, {0xf2f7e8?, 0xc0021b8ff0?}, 0xc000410b60)
	github.com/hashicorp/terraform-plugin-go@v0.23.0/tfprotov6/tf6server/server.go:784 +0x309
github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6._Provider_ReadResource_Handler({0xd8ba60?, 0xc0000a1e00}, {0xf2f7e8, 0xc0021b8ff0}, 0xc001227900, 0x0)
	github.com/hashicorp/terraform-plugin-go@v0.23.0/tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go:482 +0x169
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0004b2a00, {0xf2f7e8, 0xc0021b8f60}, {0xf354c0, 0xc000002000}, 0xc0021cad80, 0xc0004568d0, 0x14dcc28, 0x0)
	google.golang.org/grpc@v1.63.2/server.go:1369 +0xe23
google.golang.org/grpc.(*Server).handleStream(0xc0004b2a00, {0xf354c0, 0xc000002000}, 0xc0021cad80)
	google.golang.org/grpc@v1.63.2/server.go:1780 +0x1016
google.golang.org/grpc.(*Server).serveStreams.func2.1()
	google.golang.org/grpc@v1.63.2/server.go:1019 +0x8b
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 15
	google.golang.org/grpc@v1.63.2/server.go:1030 +0x135

Error: The terraform-provider-opslevel_v0.13.0-2 plugin crashed!

This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.

@vini-mw thank you for pointing this out!
This issue has been resolved and will be included in the next release.


Fan Shim & Sunfounder 3.5" LCD issue

sorry for another fan shim & LCD issue. there seems no open issue regarding this so I created another one.
ok so I get the "reboot and shutdown command not working" issue with these two combination.
reboot and shutdown work great when I only use one either Fan Shim or LCD.
The issue happens only when Fan Shim and LCD is both attached to GPIO..
I'm using the latest build of raspiblitz.
Has anyone solved this issue?
I have found a similar behavior with other HAT
https://github.com/raspberrypi/linux/issues/3065
Are Fan Shim and LCD causing the same issue?

Unfortunately the only solution seems to be to abandon the shimfan: https://github.com/rootzoll/raspiblitz/issues/1006#issuecomment-585752925

Unless there is a known solution, the shimfan should probably be taken off the official parts list.

Has anyone tried this alternative: https://www.argon40.com/argon-fan-hat-for-raspberry-pi-4-raspberry-pi-3b-and-raspberry-pi-3-b.html

Has anyone tried this alternative: https://www.argon40.com/argon-fan-hat-for-raspberry-pi-4-raspberry-pi-3b-and-raspberry-pi-3-b.html

First time I see this. Please let us know your experience if you try it.
The fanshim has been removed from the recommendations due to persisting issues so closing this.

Has anyone tried this alternative: https://www.argon40.com/argon-fan-hat-for-raspberry-pi-4-raspberry-pi-3b-and-raspberry-pi-3-b.html

First time I see this. Please let us know your experience if you try it.

Hi there, seems nobody has tried the Argon40 at the end?


fix: Call setValue only if fromCache: false "useCollection / useCollectionData"

Resolves #199

@locona as per my comment on #199, this would completely change the behaviour of the hooks, so I won't be able to accept this PR as is.


Does not scan SHTML files in the repo

I just installed the action for my personal website (the repo is private, but I can add you if you want to use it as a test case), but it did not detect broken links. I assume this is because the file patterns it follows do not include the shtml extension.
I may be missing some configuration parameters here, but it would be nice if there was a parameter that lets the user specify included file patterns explicitly.

My stupidity configuring it, sorry about that.


[SPARK-45257][CORE] Enable spark.eventLog.compress by default

What changes were proposed in this pull request?
This PR aims to enable spark.eventLog.compress by default for Apache Spark 4.0.0.
Why are the changes needed?

To save the event log storage cost by compressing the logs with ZStandard codec by default

Does this PR introduce any user-facing change?
Although we added a migration guide, the old Spark history servers are able to read the compressed logs.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

Thank you for review and approval, @mridulm ! 😄

The last commit is a doc-only change and the previous commit passed core module unit tests.

Thank you all! Merged to master.


Very slow PullAsync method

I dont know if I'm the only one, but when I try to pull my data from the backend api it takes ages to complete. If it even does.
When I test the endpoints with postman I get a response within 200 ms.
The problem does not affect all tables.
Below a sample of the used code to call a pull.
await Table.PullAsync($"all{Identifier}", Table.CreateQuery()).ConfigureAwait(false);
Is there something I'm doing totally wrong?

I had a similar problem, you may be experiencing the same thing, check out this forum post:
https://social.msdn.microsoft.com/Forums/azure/en-US/8c6a1707-c3de-466e-a944-d2d817d837eb/pullasync-very-slow-query-retrieving-all-rows?forum=azuremobile#397712c1-688e-4dd1-8b24-350586878189

Hello. I had the same problem.
I checked the queries that the mobile service makes and found the problem.
if you check this file PullCursor.cs and PullStrategy.cs you can see that the skip parameter instead of going
from 0 to $top + 0 to $top + previousSkip, it goes 0, 1, 2 , 3, 4 etc etc
for example:

$SKIP
$TOP
PREVIOUS_SKIP

0
50
0

50
50
0

100
50
50

Instead they do

$SKIP
$TOP
PREVIOUS_SKIP

0
50
0

2
50
0

4
50
2

or something like that. And this forces the api to download duplicate content. So could you check if that is the case for you too ?

@thombrink Sorry for a late followup on this issue but were you able to fix this issue?

The short answer no.
I tried to, but I found some other weird quirks too, so in the end I just wrote my own simple sync mechanism based on EF core which does exactly what I wanted.
On 1 Mar 2018 10:35 pm, Ela Malani<EMAIL_ADDRESS>wrote:
@thombrinkhttps://github.com/thombrink Sorry for a late followup on this issue but were you able to fix this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-mobile-apps-net-client/issues/378#issuecomment-369738868, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFsk1JTkPf6fJDvJf_Mul30ZsBGyP82gks5taGm9gaJpZM4PHaau.


Request For Review

https://github.com/Othniel2471/space-travel/projects/1
We are two in my team

Hi @Othniel2471 and @ticoniq ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉 🎉
Highlights
✔ Added all info required in the issue
✔ Copied the kanban board correctly and ensure every member has the correct tasks assigned
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thank you for the review @danmainah


Unexpected token / in JSON at position 0

Using Angular cli version 10.
Node version 12.x

Is ng-toolkit latest version compatible with Angular 10??

Angular dependencies.

Nope, it is not compatible with Angular 10 at the moment. I suggest using nx-plugins as explained on this issue if you need serverless + universal + Angular 10 as soon as possible,

Which latest Angular version does it supports?

Which latest Angular version it supports?

Angular v8 unfortunately.

Working on it at #826


Convert serialized posts to eml

Add the serialized Postable to EML converter code for group mailboxes and associated tests.
We should converge this with Messageable code at some point with a small translator function which converts Postable to Messageable. Reason being that posts are a subset of messages. Although I feel it's a bit premature right now. Once we have tested this in prod a bit, and we know for a fact that posts are indeed a true subset of messages, we can do this convergence.

Does this PR need a docs update or release note?

[ ] :white_check_mark: Yes, it's included
[x] :clock1: Yes, but in a later PR
[ ] :no_entry: No

Type of change

[x] :sunflower: Feature
[ ] :bug: Bugfix
[ ] :world_map: Documentation
[ ] :robot: Supportability/Tests
[ ] :computer: CI/Deployment
[ ] :broom: Tech Debt/Cleanup

Issue(s)

#

Test Plan

[ ] :muscle: Manual
[x] :zap: Unit test
[ ] :green_heart: E2E

Thanks @meain . I'll punt this for now. Here's a tech debt ticket. https://github.com/alcionai/corso/issues/5155
I had one question about the message -> EML code here.
	if data.GetSentDateTime() != nil {
		email.SetDate(ptr.Val(data.GetSentDateTime()).Format(dateFormat))
	}

Any reason we are using sent date time here and not received date time or last modified date time?
Asking because posts don't have sent date time field. So I am using received date time field as an alternative.

The spec mentions it to be the "sent" datetime. The idea is to have the datetime where it was "created".

3.6.1.  The Origination Date Field
The origination date field consists of the field name "Date" followed
by a date-time specification.
orig-date       =   "Date:" date-time CRLF
The origination date specifies the date and time at which the creator
of the message indicated that the message was complete and ready to
enter the mail delivery system.  For instance, this might be the time
that a user pushes the "send" or "submit" button in an application
program.  In any case, it is specifically not intended to convey the
time that the message is actually transported, but rather the time at
which the human or other creator of the message has put the message
into its final form, ready for transport.  (For example, a portable
computer user who is not connected to a network might queue a message
for delivery.  The origination date is intended to contain the date
and time that the user queued the message, not the time when the user
connected to the network to send the message.)

Thanks Abin! I'll change it to GetCreatedDateTime()


feat: add scanRef parameter for bb artifacts

feat: add scanRef parameter for bb artifacts

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Atıl Şensalduz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Misc List Views

Misc/low priority:

I have been investigating the sorting mechanism built into ant-design-vue in hopes of fulfilling the sort-key feature listed in the description. I've extracted some of the code leveraged by the old UI for sorting, in order to hopefully set the Table.sorter to call this new function. However, what I've discovered is that I can find no mechanism with which to determine which column is being clicked/sorted. The mechanism only passes (a, b, sortOrder), with a and b seeming to be Vue.js data objects that contain, essentially, the data for an entire row in the table. I've found a spot in the ant-design-vue code where I can pass another parameter - sortColumn as the fourth parameter, and this solves the problem. I've been testing it locally. If no-one knows of another good way to accomplish this, I will issue a PR against ant-design-vue to get this change incorporated.
The referenced line would be changed to be:
const result = sortColumn.sorter(a, b, sortOrder, sortColumn);
Here is a link to the current line within the ant-design-vue repo

@ggoodrich-ipp column specific sorting function are defined in the auto-generated view/generator component like this: https://github.com/apache/cloudstack-primate/blob/master/src/views/AutogenView.vue#L344 (this is a very basic method, probably won't work for anything other than strings)

Split and moved to other tickets.


algorithmExpression 分表字段如何使用varchar类型

Question
For English only, other languages will not accept.
Before asking a question, make sure you have:

Googled your question.
Searched open and closed GitHub issues.
Read documentation: Sharding-Sphere Doc.

Please pay attention on issues you submitted, because we maybe need more details.
If no response more than 7 days and we cannot reproduce it on current information, we will close it.


How to run your codes with multiple GPU?

Hi, thnkim!
I'm using your codes to fine tune our face recognition network in pytorch, it works well when using single GPU (gpuDevice=0), I want to know how to run it with multiple GPU?
thanks!

Hello, sorry for the belated response.
When you call prepareOpenFace(), you can set useMultiGPU=True, then it should use pyTorch's nn.DataParallel(). If you would like to use some specific GPU device(s), you can modify the line model = nn.DataParallel(model) below.
def prepareOpenFace(useCuda=True, gpuDevice=0, useMultiGPU=False):
    model = netOpenFace(useCuda, gpuDevice)
    model.load_state_dict(torch.load(os.path.join(containing_dir, 'openface.pth')))

    if useMultiGPU:
        model = nn.DataParallel(model)

    return model


Found includes for boost library in glk/cuda_magic_headers.hpp

Hi Koide,
I was looking into the code and found that there are still inclusions from the boost library. But I think boost dependency should be removed several weeks ago, please check.
Thanks

Hi @Seekerzero ,
The header file includes some hpps to prevent build errors on old CUDA environments, and is no longer necessary and no longer used. I'll delete it later as it is not used by any code now.


failed to pip install pyautogui on Windows

when I was using "pip install pyautogui" on Window 10, it always reminded me failure as in the  pic .

link to this issue： https://github.com/asweigart/pyautogui/issues/292

try installing a specific version.


Support for deserializing via constructor

C#6 added support to easily create immutable objects via get-only auto properties.  It would be nice for Jil to be able to use a constructor when deserializing so we can take advantage of immutable types.
Example for how Json.Net handles this:
public class Foo
{
  public int Bar { get; }

  [JsonConstructor]
  public Foo(int bar)
  {
    Bar = bar;
  }
}

This will be a really good feature to have as I am now forced to specify 2 set of classes for each of my models, a DTO with public getter/setters and an immutable POCO built from the DTO so that I can have an immutable model which I can pass around.

You can do this for primitive types with [JilPrimitiveWrapper].
See this test for example

That's very useful and I will surely take a look but does it only support primitive types? how about immutable reference types?


chore(gitflow): merge develop to main

Describe your changes
merge develop to main for release of package @brandingbrand/code-plugin-fastlane 2.0.3
Checklist before requesting a review

[x] A self-review of my code has been completed
[ ] Tests have been added / updated if required
[ ] Documentation has been updated to reflect these changes

deployed to npm, merging


Some improvements on neo4j-core 7.0.0.alpha

This pull introduces/changes:

Some fixes on CypherError class and constructor

Pings:
@cheerfulstoic
@subvertallchris

Coverage increased (+0.3%) to 92.609% when pulling b9d43a7af01bd9cd06afa6360f7655f8ee0303ba on new_cypher_api_improvements into 60769e33b45d73ba2b81d258cef9e50ff1f33640 on master.

One comment, but otherwise this is great, thanks!

Done 👍

Released alpha.2, thanks!


Failed to parse [XML GENERATE and JSON GENERATE]

First of all, thank you for the amazing work on this library.
I was trying to parse a code base and it failed to parse COBOL files that had XML GENERATE. Example below. There are instances of JSON GENERATE as well. Any help to get past this is appreciated.
             XML GENERATE WS-BUFFER-OUT
             FROM Claims COUNT IN WS-LENGTH-NUM
                ON EXCEPTION
                   DISPLAY '****************************************'
                   DISPLAY '***** XML GENERATION ERROR ' XML-CODE
                   DISPLAY '***** KEY REF-NBR: ' TCWOAGTP-REF-NBR
                   DISPLAY '****************************************'
                NOT ON EXCEPTION
                   CONTINUE
           END-XML

Well, we are talking about cobol 85 and rather Not any Extensions like XML etc.


FLEX-4108 ~ Adds optional connection limit

SonarQube analysis reported 6 issues

 2 major
 4 minor

Watch the comments in this conversation to review them.
5 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 OslpChannelHandler.java#L165: The Cyclomatic Complexity of this method "isOslpResponse" is 22 which is greater than 10 authorized.
 OslpChannelHandler.java#L166: Reduce the number of conditional operators (21) used in the expression (maximum allowed 3).
 OslpConfig.java#L130: Remove the declaration of thrown exception 'org.opensmartgridplatform.adapter.protocol.oslp.elster.exceptions.ProtocolAdapterException', as it cannot be thrown from method's body.
 OslpConfig.java#L150: Remove the declaration of thrown exception 'org.opensmartgridplatform.adapter.protocol.oslp.elster.exceptions.ProtocolAdapterException', as it cannot be thrown from method's body.
 OslpChannelHandlerClient.java#L94: Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body.


Fix bug #748

This pull request fixes bug #748.
The issue was that context.addParentSource("", source); was missing in one implicit case of an if-else-statement in https://github.com/modelmapper/modelmapper/commit/6f2d6fa3e5e78b38ea3153d1f35fb855b1ab8476

Thanks for the fix, merged the change by https://github.com/modelmapper/modelmapper/commit/b826615c447284df98d83ab4eda247bdb055e344. Will have a release soon


[Feature] Pictorial chart（象形图）

https://echarts.apache.org/examples/en/editor.html?c=geo-beef-cuts

https://www.highcharts.com/demo/highcharts/pictorial-stackshadow

pictogram chart will be supported in v1.13.0.
related https://github.com/VisActor/VChart/pull/3392


Net Worth Graphs and Tracking Accounts

I've seen a couple people report this on the forums, but I'm not seeing an official issue report for it, so just in case...
I'm not sure if this is a bug or a feature request, but it looks like tracking account data is currently included in the  net worth graphs. Would it be possible to add some sort of setting that determines whether or not tracking account data is included? For example, some people use tracking accounts to track reimbursements, which they may not want to be included in their net worth.
http://forum.youneedabudget.com/discussion/comment/595755/#Comment_595755

This will help out with that request: https://trello.com/c/oB1ZuBkC/200-add-ynab4-filters-specific-categories-specific-accounts-specific-categories-for-net-worth-report

OK, perfect -- that should fix things for people. Feel free to close this issue?

Nah, I'll leave it here until I release the enhancement so in case anyone else comes looking for it they'll find this here and avoid opening a duplicate I reckon.

Alrighty, new plan, let's track all enhancements on the roadmap. This one is here: https://trello.com/c/oB1ZuBkC/200-add-ynab4-filters-specific-categories-specific-accounts-specific-categories-for-net-worth-report
I'm going to go ahead and close this issue. Conversation can happen on the Trello card.


WAMR has a segmentation fault while executing this wasm binary.

I have generated a wasm binary, and I process it with Wamr. But the output error message differs from other runtimes like wasmtime and wasmer.
file7.zip
wamrc -o file7.wasm.aot file7.wasm
iwasm --heap-size=0  -f main file7.wasm.aot

The outputs of WAMR are as follows:
-----------------wamr-----------------
Create AoT compiler with:
  target:        x86_64
  target cpu:    znver3
  target triple: x86_64-unknown-linux-gnu
  cpu features:
  opt level:     3
  size level:    3
  output format: AoT file
Compile success, file file7.wasm.aot was generated.
Segmentation fault (core dumped)

While the outputs of the other runtimes like wasmtime and wasmer are:
-----------------wasmtime-----------------
warning: using `--invoke` with a function that returns values is experimental and may break in the future
0
0
0
0
0
0
0
520359494

-----------------wasmer-----------------
0 0 0 0 0 0 0 520359494

Hi, the pr #2583 should fix this issue. As for the other issues you mentioned, we are actively debugging them to see where they go wrong.
BTW, kudos to the fuzzer you programmed! It is really great that you spotted those issues all at once.

Close this issue as it had been fixed.


Error generating About: StartIndex cannot be less than zero

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.

Steps to reproduce

Create a markdown file, (e.g., 'C:\temp\PlatyTemp\about_PlatyProblem.md')

# Platy Problem
## about_PlatyProblem

# SHORT DESCRIPTION

Demonstrates a problem with PlatyPS when a long word is present.

# LONG DESCRIPTION

プロバイダーもコマンドをエクスポートします。これらのコマンド名は、一般的にプロバイダー名で始まる場合が多いです。エクスポートされたコマンドのパターンについては、プロバイダーのドキュメントを参照してください。

Run New-ExternalHelp -Path C:\temp\PlatyTemp -OutputPath C:\temp\PlatyTemp -Force

Expected behavior
Under normal circumstances, PlatyPS should wrap text lines based on the `MaxAboutWidth` setting (default 80), ensuring that once a line exceeds the maximum X characters, the remaining text is moved to the next line.

Actual behavior
An exception occurs with the following message:
`StartIndex cannot be less than zero`

Error details
at System.String.Substring(Int32 startIndex, Int32 length)
   at Markdown.MAML.Renderer.TextRenderer.WrapAndAppendLines(String text, StringBuilder sb)
   at Markdown.MAML.Renderer.TextRenderer.AddAboutParagraph(ParagraphNode paragraphNode)
   at Markdown.MAML.Renderer.TextRenderer.AboutMarkdownToString(DocumentNode document)

Environment data
ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     0.14.2     platyPS                             {New-MarkdownHelp, Get-MarkdownMetadata, New-ExternalHelp, New-YamlHelp...}

Name                           Value
----                           -----
PSVersion                      5.1.19041.4894
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.4894
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Visuals
No response

There is a previous issue that was closed with an external resolution: #251.
However, I believe that PlatyPS should handle this situation better.
Workaround for who is getting same problem: Increase -MaxAboutWidth, set it to maximum line length for lines with text without space
I performed some initial troubleshooting by looking at the source code.
As indicated by the exception stack trace, the problem occurs in the function WrapAndAppendLines.
This function splits the input string (which originates from a markdown paragraph) by spaces, assuming that spaces separate words.
https://github.com/PowerShell/platyPS/blob/f9fa12821b6dbacdd16cc486b77787cdc51242fa/src/Markdown.MAML/Renderer/TextRenderer.cs#L130-L133
While the current line does not exceed MaxAboutWidth characters, it continues to add these split words.
The content is buffered in a variable called text.
https://github.com/PowerShell/platyPS/blob/f9fa12821b6dbacdd16cc486b77787cdc51242fa/src/Markdown.MAML/Renderer/TextRenderer.cs#L135-L138
In each loop iteration over words, it checks if text + word exceeds MaxAboutWidth. If so, it starts a new line.
This check involves using the Substring function, retrieving the length of the text variable minus 1.
In the case at hand, the Japanese text does not contain spaces. So, during the first iteration of the word loop, it enters the second else if condition.
Since text is still empty (on the first loop), the length returns 0, resulting in a start index exception.
https://github.com/PowerShell/platyPS/blob/f9fa12821b6dbacdd16cc486b77787cdc51242fa/src/Markdown.MAML/Renderer/TextRenderer.cs#L155-L163
I believe a simple solution would be to handle cases where a word with no spaces exceeds the maximum width. In such cases, it should fill the line with up to MaxAboutWidth characters and start a new line accordingly.


Add make target for fetching base images of custom test images we build

Very useful for refreshing test images.
Pull Request Checklist

[x] implement the feature

Trivial change not affecting tests, merging right away.


Authenticlick can't be a package as of now

Problems that need to be addressed

threading cannot be placed in a function and therefore must continuously run
If placed threads as functions or variables they would be considered an interger so it can't be closed

Problem addressed by removing with statement and treating it like a normal thread. (a global one)


Significant performance regression for datashader in numba 0.49.x

Using latest released numba (0.49.1) I'm seeing a significant performance regression when compared to numba 0.48 in a simple datashader aggregation example. I'm downgrading from 0.49.1 to 0.48 with conda install numba=0.48 --no-deps to ensure no other packages change. The simple test case I'm using is the following:
import timeit

from functools import partial

import datashader as ds
import numba
import numpy as np
import pandas as pd

canvas = ds.Canvas(plot_height=1000, plot_width=1000)

def agg(df):
    canvas.points(df, 'x', 'y', agg=ds.mean('value'))

def test_agg_performance(N, repeats=10):
    df = pd.DataFrame({'x': np.random.randn(N), 'y': np.random.randn(N), 'value': np.random.rand(N)})
    agg(df) # Warm up JIT
    return timeit.timeit(partial(agg, df), number=repeats)/repeats

print(f'Numba version: {numba.__version__}')
[(n, test_agg_performance(int(n))) for n in np.logspace(0, 8, 9)]

Here is a graph of the performance difference by the number of points being aggregated:

And here is the notebook which I used to generate the plot: https://anaconda.org/philippjfr/profiling_numba/notebook

Thanks for the report. Which threading backend are you using?

Also, which Datashader version can this be reproduced with?

Thanks for the report. Which threading backend are you using?

How do I check? I looked at numba.config.THREADING_LAYER which is just 'default'.

Also, which Datashader version can this be reproduced with?

I'm using datashader master, but I just checked 0.10.0 and the results are the same.

Run this after you've executed some Numba code.
from numba import threading_layer
print("Threading layer chosen: %s" % threading_layer())

I'm pretty sure I know what the cause will be (TBB and performing nested parallelism as requested from user code), but am going to check.

Apparently no threading layer, even after executing the aggregation I get:
~/miniconda3/envs/rapidsai13/lib/python3.6/site-packages/numba/np/ufunc/parallel.py in threading_layer()
    322     """
    323     if _threading_layer is None:
--> 324         raise ValueError("Threading layer is not initialized.")
    325     else:
    326         return _threading_layer

ValueError: Threading layer is not initialized.

Actually yeah, I don't think we use parallelism for points aggregation or rather the only parallelism we use there is dask partitioning.

ok, thanks, guess it's not what I thought it was, which is good news as that's a very hard thing to fix :)

FWIW I'm bisecting now.

Will leave it with you @esc, just wanted to make sure it wasn't threading!
Potential things off the top of my head:

SSA
Ref counting (think that invalid pass got removed in 0.49, perhaps DS was relying on it?)

Ref counting (think that invalid pass got removed in 0.49, perhaps DS was relying on it?)

i think that is the most likely case.

So my git bisect run led to the following commit:
https://github.com/numba/numba/commit/8c74571a2f97cede08c491b6c018ed144072e8bd

Which in turn led to the following PR:
https://github.com/numba/numba/pull/5338

Yeah, reverting 8c74571a2f97cede08c491b6c018ed144072e8bd on master get the performance back.

Fixed in #5795. Will make it into 0.50.0.


Use readonly #12732

Adopted readonly in vscode.d.ts

We cannot merge that yet

we use typedoc to generate the extension API page and that isn't fit for TypeScript 2.0 yet
it's unsure how readonly-ness should be expressed for objects we have created vs objects consumer create, e.g TextEditorOptions cannot be modified by setting a value ala options.lineNumbers = value but when creating a new objects they can

Thank you.
So, I should close this PR once, or wait until typedoc to version up?
Can I be of any help for it?

We are ready for this and want it for Jan

@Ikuyadeu Can you also add readonly here (basically I have searched for @readonly)

[ ] https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L1599
[ ] all in env (https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L3379)
[ ] https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L3863
[ ] https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L3914

Can the @readonly comment annotations be removed now?

@jrieken Ok,

[x] https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L1599
added redonly.But,

[ ] all in env (https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L3379)

[ ] https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L3863

[ ] https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L3914
are yet. because they're using export and namespace.

re https://github.com/Microsoft/vscode/pull/13863#issuecomment-269386882 I wanna first check how the doc generation tool handles the native readonly flag.

Something is very wrong... There are 25 files with changes

@jrieken Sorry, I missed

Reopened PR in #18251


Peer code review.

This branch was created for a code review from my coding partner. Can't wait to get his feedback.

Hi @carlylechia  👋,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉 🎉 🎉 🎉,
Cheers and Happy coding!👏👏👏

😅🤩 You're going to make an AMAZING code reviewer some day man. Thank you so much for your beautiful reviews, and for the approval.


Support adding new files and folders from bramble, part of https://github.com/mozilla/thimble.webmaker.org/issues/723

I need this for adding HTML, CSS, and JS files from the add file popup menu.  I've also added support for adding new folders, in case we want that at some point.  I had to rejig the remote command stuff so it allowed passing args, too.
I've got UI coming for this in Thimble in a follow-up PR in a min.

One small take-it-or-leave-it nit, r+ otherwise


Implemented rewrite to real path in dump_path

This fixes #254 by adding a function, get_real_store_dir, to libnixstore to support non-root nix stores, where the physical and logical paths differ.

LGTM, mind if I re-sign this and push it into my original PR?

@Thesola10 sure.


Allow passing a variable amount of values for one input parameter into args and command.

Summary
Support input parameters that are lists. Subsequently, allow them to be appended to the args or command values (see example in Use Cases).
Use Cases
The example below shows what I'd like to use. Be aware how these values are added to the args list requires some discussion. I just wrote |unpack now, which is a bit of a Pythonic way to similarly add items to a list (["--numbers", *values]).
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: dag-
spec:
  entrypoint: do-something
  templates:
    - name: something
      inputs:
        parameters:
          - name: values
      container:
        image: some-image
        args: ["--numbers", "{{inputs.parameters.values|unpack}}"]  # This should somehow become ["--numbers", "1", "3", "6", "9"].

    - name: do-something
      dag:
        tasks:
          - name: do-it
            template: something
            arguments:
              parameters:
                - name: values
                  value: ["1", "3", "6", "9"]  # This is not possible at the moment. It can only be a single value.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

will it work for you?
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: dag-
spec:
  entrypoint: do-something
  templates:
    - name: something
      inputs:
        parameters:
          - name: values
      container:
        image: alpine:latest
        command: [sh, -c]
        args: ["echo {{inputs.parameters.values}}"]  # This should somehow become ["--numbers", "1", "3", "6", "9"].

    - name: do-something
      dag:
        tasks:
          - name: do-it
            template: something
            arguments:
              parameters:
                - name: values
                  value: '["1", "3", "6", "9"]'

Wouldn't say so, no. Because then ["1", "3", "6", "9"] is still parsed as a single argument instead of multiple.

I would recommend adding one more step which will remove the [] from string and output "1", "3", "6", "9" or if your step is a script template, you can parse it before pass it.  In Argo, all parameters are string. If you want to iterate the JSON array, you can use withParam. This will pass each element from arrar to given template

Thanks for your recommendation. I understand your suggestion is a valid workaround. I can imagine it doesn't have any real priority now, but I just think it'd be more convenient in this use case to be able to use lists in parameters as well.
I see this is labelled as more-information-needed now. How can I help with that?

Thanks for confirming. I will close the issue.   more-information-needed is mainly for the user to reply.

Is there a more preferred way to post feature requests? Can this be re-opended? This is a big pain for me as well.
Wrapping the arguments in sh -c doesn't seems like the ideal solution to what must be a common issue (although I wouldn't say I know a better way to implement such a feature).
I have a similar thought where I would like to be able to pass a list to my script, and also be able to conditionally set a flag.  e.g.
---
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: script-templates
spec:
  templates:
    - name: my-cool-script-template
      inputs:
        parameters:
          - name: url_args
          - name: use_flag_args
      container:
        image: some-image
        command: ['/usr/bin/my-cool-script']
        args: [
          "--url-endpoints",
          "{{ < unpack url_args ?? > }}",
          "{{ < set --use-flag if use_flag arg is true, otherwise nothing ?? > }}",
        ]
---
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: my-cool-script
  namespace: distroflow
spec:
  entrypoint: my-cool-script-template
  arguments:
    parameters:
      - name: url_args
        value: ["href1", "href2"]
      - name: use_flag_args
        value: True
  workflowTemplateRef:
    name: script-templates

The application in the container would be invoked like: /usr/bin/my-cool-script --url-endpoints href1 href2 --use-flag


Align on priority user task list

Problem statement
[Write a short description of what you want to achieve with this task]
What you need to know
[Links to documents, workflows, or list of key people and contact info]

Document 1
Document 2
...

Acceptance criteria

[ ] ...

To do

[ ] ...

Done


No fixed height for timeout modal example

When displayed in the Service manual, which uses pym.js to resize the iframes, the timeout modal example does not display correctly because there is no set height.
Wrapping the example in a container with a fixed height should force pym to resize the iframe correctly.

On hold – Needs to be tested and then the version of the design system will need to be updated in the service manual before the fix is realised


chore(spec): remove the skip specs for electra

Motivation
Run all spec tests for electra
Description

Run all specs.

Steps to test or reproduce
Run all tests

:tada: This PR is included in v1.22.0 :tada:


Training code for Oxford dataset

Great work, and thank you for open-sourcing this project! I was able to reproduce the results on the KITTI dataset, but I encountered some issues with the Oxford dataset.
When I tried training Bevplace++ on the Oxford dataset, I only achieved a Recall@1 result of 73. I used the default code for generating BEV images (with path adjustments to fit the Oxford dataset), and the learning rate and batch size were also set to the default values. I believe something might be wrong. Could you please consider open-sourcing the training code for the Oxford dataset?

Hi @lbhwyy, thank you for your interest! The point clouds in the Oxford dataset differ from those in KITTI and NCLT because their coordinates are normalized to the range [-1, 1]. To generate accurate BEV images, you'll need to denormalize the points. In our implementation, we scale the point values by a factor of 40, which results in BEV images of size 200x200. I suggest comparing the BEV images from the Oxford and KITTI datasets to ensure the format is correct.
If you continue to encounter issues with reproducing the results, feel free to add me on WeChat (llluolun) for further discussion.

Thank you for your kindly reply!


Minor consistency tweaks

@Atinux @clarkdo just a few places function seemed to be uselessly used (and in files where () => was also used)... changed and ran the tests, ditto! No biggie :)
Just my daily pomodoro studying Nuxt.
Also noticed a few places where [].concat and Array.prototype.concat were used for the same purpose. Just thought it was cleaner to standardize on referencing the actual prototype method.

Codecov Report

Merging #3726 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #3726   +/-   ##
=======================================
  Coverage   98.25%   98.25%
=======================================
  Files          18       18
  Lines        1144     1144
  Branches      308      308
=======================================
  Hits         1124     1124
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61c0976...93580e7. Read the comment docs.


Document desired system architecture

@lavalamp Issue to remind me (or you, if you want to) write up what we discussed today wrt. write-through cache, etc.
cc @dchen1107

I added a brief bullet about this to docs/design/principles.md. We can expand there or elsewhere (e.g., docs/design/architecture.md) as necessary.


Refunded CFD is considered open

This is just a UI problem, that state should be sorted into the correct list.

I think this has been fixed.


Not working with Meteor 1.3 and app source

Non-bundled applications do not work with Meteor version 1.3 thanks to needing to compile Fibers (and the latest version of this package does not include build-essentials.

Okay, so this isn't actually a problem with 1.3 per se; it's a problem with the new version of fibers not being distributed with a binary for node 0.10.41.

Reverted fibers to version 1.0.7 in cf4ef26735cdd55d5fdc7db3bdeffae85bdfe3e9


Support comments in parser

Implementing this issue

Any updates? Could I steal this issue?

Nope. Currently implementing this issue


[BUG] Failed operational discovery of Thread devices

Reproduction steps
Hello, I am working on a PoC for a Matter hub and we want to have the hub also be a Thread Border Router. I have been working with this for a couple weeks now and have managed to get to operational discovery, but it fails every time.
This issue does not appear at all with WiFi devices.

Setup:
Raspberry Pi 4b with Ubuntu Server 23.10.
OTBR running in docker container
Commissioning with Matter (chip-tool)
chip-tool command executed:
chip-tool pairing code-thread 69 hex:0e08000000000001000035060004001fffe00708fd38de8fb4627cf00c0402a0f7f8051000112233445566778899aabbccddeeff030e4f70656e54687265616444656d6f0410445f2b5ca6f2a93a55ce570a70efeecb000300000f0208111111112222222201021234<PHONE_NUMBER>1 --paa-trust-store-path /opt/matter/certs

Debugging:
Currently able to get to the point where the Thread device is commissioned on the Thread network using Matter's chip-tool. Can confirm this by checking the child table within OTBR: ot-ctl child table.
I have verified that there are no errors on the OTBR side. The packets are received and sent just fine.
I see the operational discovery packets using avahi-browse -a.
+  otbr0 IPv6 063787A15C2B0395-0000000000000045             _matter._tcp         local
+  otbr0 IPv4 063787A15C2B0395-0000000000000045             _matter._tcp         local

chip-tool outputs an error, Timeout waiting for mDNS resolution, while on the FindOperational step:
[1714999513.967859][6179:6181] CHIP:CTL: Successfully finished commissioning step 'ThreadNetworkEnable'
[1714999513.967917][6179:6181] CHIP:CTL: Commissioning stage next step: 'ThreadNetworkEnable' -> 'FindOperational'
[1714999513.967978][6179:6181] CHIP:CTL: Performing next commissioning step 'FindOperational'
[1714999513.968027][6179:6181] CHIP:IN: Expiring all sessions for node <0000000000000045, 1>!!
[1714999513.968081][6179:6181] CHIP:CSM: FindOrEstablishSession: PeerId = [1:0000000000000045]
[1714999513.968130][6179:6181] CHIP:CSM: FindOrEstablishSession: No existing OperationalSessionSetup instance found
[1714999513.968199][6179:6181] CHIP:DIS: OperationalSessionSetup[1:0000000000000045]: State change 1 --> 2
[1714999513.969669][6179:6181] CHIP:DMG: ICR moving to [AwaitingDe]
[1714999514.168146][6179:6181] CHIP:DIS: Checking node lookup status after 200 ms
[1714999515.439296][6179:6181] CHIP:DIS: SRV record already actively processed.
[1714999515.439771][6179:6181] CHIP:DIS: SRV record already actively processed.
[1714999515.441354][6179:6181] CHIP:DIS: SRV record already actively processed.
[1714999515.441658][6179:6181] CHIP:DIS: SRV record already actively processed.
[1714999515.441912][6179:6181] CHIP:DIS: SRV record already actively processed.
[1714999515.445875][6179:6181] CHIP:DIS: Lookup clearing interface for non LL address
[1714999515.446133][6179:6181] CHIP:DIS: UDP:[fd11:22::d012:4589:e76d:1f9e%otbr0]:5540: new best score: 3
[1714999515.446193][6179:6181] CHIP:DIS: Checking node lookup status after 1478 ms
[1714999515.446262][6179:6181] CHIP:DIS: OperationalSessionSetup[1:0000000000000045]: Updating device address to UDP:[fd11:22::d012:4589:e76d:1f9e]:5540 while in state 2
[1714999515.446317][6179:6181] CHIP:DIS: OperationalSessionSetup[1:0000000000000045]: State change 2 --> 3
[1714999515.446930][6179:6181] CHIP:IN: SecureSession[0xffff8001a8f0]: Allocated Type:2 LSID:57955
[1714999515.447048][6179:6181] CHIP:SC: Initiating session on local FabricIndex 1 from 0x000000000001B669 -> 0x0000000000000045
[1714999515.449066][6179:6181] CHIP:EM: <<< [E:60042i S:0 M:121203353] (U) Msg TX to 0:0000000000000000 [0000] [UDP:[fd11:22::d012:4589:e76d:1f9e]:5540] --- Type 0000:30 (SecureChannel:CASE_Sigma1)
[1714999515.449546][6179:6181] CHIP:SC: Sent Sigma1 msg
[1714999515.449635][6179:6181] CHIP:DIS: OperationalSessionSetup[1:0000000000000045]: State change 3 --> 4
[1714999516.439920][6179:6181] CHIP:DIS: SRV record already actively processed.
[1714999516.440184][6179:6181] CHIP:DIS: SRV record already actively processed.
[1714999516.441701][6179:6181] CHIP:DIS: SRV record already actively processed.
[1714999516.441982][6179:6181] CHIP:DIS: SRV record already actively processed.
[1714999516.442226][6179:6181] CHIP:DIS: SRV record already actively processed.
[1714999516.545717][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16387
[1714999519.129858][6179:6180] CHIP:DL: Indication received, conn = 0xffff880378a0
[1714999519.130164][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16389
[1714999519.723194][6179:6181] CHIP:EM: Retransmitting MessageCounter:121203353 on exchange 60042i Send Cnt 1
[1714999521.713218][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16387
[1714999523.843283][6179:6181] CHIP:EM: Retransmitting MessageCounter:121203353 on exchange 60042i Send Cnt 2
[1714999524.200228][6179:6180] CHIP:DL: Indication received, conn = 0xffff880378a0
[1714999524.200499][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16389
[1714999524.326020][6179:6181] CHIP:DIS: Timeout waiting for mDNS resolution.
[1714999526.832197][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16387
[1714999529.318884][6179:6180] CHIP:DL: Indication received, conn = 0xffff880378a0
[1714999529.319227][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16389
[1714999529.976450][6179:6181] CHIP:EM: Retransmitting MessageCounter:121203353 on exchange 60042i Send Cnt 3
[1714999531.901893][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16387
[1714999534.437714][6179:6180] CHIP:DL: Indication received, conn = 0xffff880378a0
[1714999534.438058][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16389
[1714999537.020964][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16387
[1714999539.508301][6179:6180] CHIP:DL: Indication received, conn = 0xffff880378a0
[1714999539.508640][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16389
[1714999541.061654][6179:6181] CHIP:EM: Retransmitting MessageCounter:121203353 on exchange 60042i Send Cnt 4
[1714999542.090727][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16387
[1714999544.578227][6179:6180] CHIP:DL: Indication received, conn = 0xffff880378a0
[1714999544.578626][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16389
[1714999547.161008][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16387
[1714999549.696521][6179:6180] CHIP:DL: Indication received, conn = 0xffff880378a0
[1714999549.696854][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16389
[1714999552.279536][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16387
[1714999554.815223][6179:6180] CHIP:DL: Indication received, conn = 0xffff880378a0
[1714999554.815609][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16389
[1714999557.370905][6179:6181] CHIP:EM: Failed to Send CHIP MessageCounter:121203353 on exchange 60042i sendCount: 4 max retries: 4
[1714999557.447253][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16387
[1714999559.884884][6179:6180] CHIP:DL: Indication received, conn = 0xffff880378a0
[1714999559.885164][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16389
[1714999562.468218][6179:6181] CHIP:DL: HandlePlatformSpecificBLEEvent 16387
[1714999563.960047][6179:6181] CHIP:SC: CASESession timed out while waiting for a response from the peer. Current state was 1
[1714999563.960149][6179:6181] CHIP:IN: SecureSession[0xffff8001a8f0]: Released - Type:2 LSID:57955
[1714999563.960250][6179:6181] CHIP:DIS: OperationalSessionSetup[1:0000000000000045]: State change 4 --> 2
[1714999563.960324][6179:6181] CHIP:DIS: OperationalSessionSetup[1:0000000000000045]: State change 2 --> 1
[1714999563.960402][6179:6181] CHIP:DIS: OperationalSessionSetup:attempts done: 1, attempts left: 2, retry delay 1s, status src/system/SystemLayerImplSelect.cpp:214: Success
[1714999563.960456][6179:6181] CHIP:DIS: OperationalSessionSetup[1:0000000000000045]: State change 1 --> 6
[1714999563.960536][6179:6181] CHIP:CTL: Session establishment failed for <0000000000000045, 1>, error: src/protocols/secure_channel/CASESession.cpp:553: CHIP Error 0x00000032: Timeout.  Next retry expected to get a response to Sigma1 or fail within 8 seconds

TLDR: Matter fails operational discovery of Thread devices even though operational discovery, _matter._tcp, is shown through avahi.
Bug prevalence
Commissioning any Thread device
GitHub hash of the SDK that was being used
f52860e4d44a2653d167aa04552414e4c9015718
Platform
raspi
Platform Version(s)
1.2
Anything else?
No response

As an update to this, I found something that is off. During operational discovery, the name used for lookup within Matter is not the name that is publishing the operational discovery seen in avahi.
Matter lookup: 66D5DE6615F10EFA-0000000000000045
Name from avahi: 063787A15C2B0395-0000000000000045
I would imagine that if Matter is doing a lookup on the wrong name, it will never find it, so this seems to be the crux of the issue. I did verify that the IPv6 address Matter is using is the correct one of the device on the Thread network.

@fostergorman The log above shows the operational discovery succeeding just fine:
[1714999515.446262][6179:6181] CHIP:DIS: OperationalSessionSetup[1:0000000000000045]: Updating device address to UDP:[fd11:22::d012:4589:e76d:1f9e]:5540 while in state 2
[1714999515.446317][6179:6181] CHIP:DIS: OperationalSessionSetup[1:0000000000000045]: State change 2 --> 3
[1714999515.446930][6179:6181] CHIP:IN: SecureSession[0xffff8001a8f0]: Allocated Type:2 LSID:57955
[1714999515.447048][6179:6181] CHIP:SC: Initiating session on local FabricIndex 1 from 0x000000000001B669 -> 0x0000000000000045
[1714999515.449066][6179:6181] CHIP:EM: <<< [E:60042i S:0 M:121203353] (U) Msg TX to 0:0000000000000000 [0000] [UDP:[fd11:22::d012:4589:e76d:1f9e]:5540] --- Type 0000:30 (SecureChannel:CASE_Sigma1)
[1714999515.449546][6179:6181] CHIP:SC: Sent Sigma1 msg

But then we never get a response or an ack for that message:
[1714999519.723194][6179:6181] CHIP:EM: Retransmitting MessageCounter:121203353 on exchange 60042i Send Cnt 1
[1714999523.843283][6179:6181] CHIP:EM: Retransmitting MessageCounter:121203353 on exchange 60042i Send Cnt 2
[1714999529.976450][6179:6181] CHIP:EM: Retransmitting MessageCounter:121203353 on exchange 60042i Send Cnt 3
[1714999541.061654][6179:6181] CHIP:EM: Retransmitting MessageCounter:121203353 on exchange 60042i Send Cnt 4
[1714999557.370905][6179:6181] CHIP:EM: Failed to Send CHIP MessageCounter:121203353 on exchange 60042i sendCount: 4 max retries: 4
[1714999563.960047][6179:6181] CHIP:SC: CASESession timed out while waiting for a response from the peer. Current state was 1

So:

Is that the right IP that's being discovered?
If it is, where are the packets being lost?

Well, clearly the Matter device doing the commissioning never got the response to Sigma1.  So you should figure out where that response packet is being dropped in your specific network setup.  Is it being sent by the Thread end device?  If not, start there. If it is, then what happened to it?

(And please fix the PR summary, since operational discovery worked just fine.)


Build sometimes fails looking for Generated Files\version_gen.h

Microsoft PowerToys version
0.73.0
Installation method
Other (please specify in "Steps to Reproduce")
Running as admin
None
Area(s) with issue?
General
Steps to reproduce
Build the repo often.
✔ Expected Behavior
Build suceeds.
❌ Actual Behavior
Build fails:
e.g. https://dev.azure.com/mseng/Domino/_build/results?buildId=22379584&view=logs&j=cfa20e98-6997-523c-4233-f0a7302c929f&t=73780a56-f193-524d-7415-4f074cfcc9bb
"D:\a\_work\1\s\PowerToys.sln" (default target) (1) ->
"D:\a\_work\1\s\src\runner\runner.vcxproj.metaproj" (default target) (2) ->
"D:\a\_work\1\s\src\modules\imageresizer\dll\ImageResizerExt.vcxproj" (default target) (6) ->
(ClCompile target) ->
  D:\a\_work\1\s\src\common\version\version.h(6,10): fatal  error C1083: Cannot open include file: 'Generated Files\version_gen.h': No such file or directory [D:\a\_work\1\s\src\modules\imageresizer\dll\ImageResizerExt.vcxproj]

Other Software
No response

The work associated with this issue has been released as part of the 0.75 sprint. Please update PowerToys to the latest. https://github.com/microsoft/PowerToys/releases


php injection - validate eval input from plural forms

There wasn't any input validation on eval'd code in plural forms. Untrusted translation files could create php injection.

Thank you 👍


Feature Request: Aliases

When running the same module over and over again on an agent (screenshots, for example) it's a bit tedious to keep typing usemodule , execute, back. It would be handy if I could just type alias screenshot usemodule collection/screenshot; execute; and then just type screenshot each time I wanted to snag one.

There are currently aliases for:
bypassuac
injectshellcode
mimikatz
psinject
revtoself
sc (screenshot)
spawn
steal_token

We'll look into building custom aliases, but we're not sure how complex this would be.

Didn't know about sc, but still thought it'd be handy to be able to create aliases when you find yourself doing something fairly repetitive.

Looking at Python's cmd module that Empire's menus are built on, there doesn't seem to be an easy way to integrate aliases without building all of the underlying architecture ourselves. We may revisit, but for the time being you can edit ./lib/common/empire.py to build your own 'custom' command aliases.

@HarmJ0y Thanks!!


an error message is displays while running the app based on route

Error: Invalid configuration of route ''. One of the following must be provided: component, redirectTo, children or loadChildren
RouterModule.forRoot
([ {
path:'', loadChildren:'./mainhomemodule/mainhomemodule.module#MainhomeModule'
} ])
In mainhome.module.ts,
RouterModule.forChild
([ { path:'', component:HomeComponentComponent, children:[{ path:'', component:HomeComponent }]
}
]) ],

Closing since there isn't much info to go on and the code snippet isn't using any Material/CDK functionality.


Help to support NativeBase with Gatsby RNW plugin

Hi
I'm the author of the Gatsby RWN plugin and have tried to setup NativeBase for it, but without much success.
I've a demo here: https://github.com/slorber/gatsby-plugin-react-native-web/tree/master/examples/uikits
I've made an attempt here and commited the things that seemed to work: https://github.com/slorber/gatsby-plugin-react-native-web/commit/c0f0bbb1ecc82900bd5ee9af1e5b35a26167c2ad
The RN libraries seems to be transpiled properly, but I still get those errors:

This happens by just importing native-base and without even using it.
Could you help me try to fix my setup so that I can support NativeBase?

Please check the working repo here https://github.com/GeekyAnts/NativeBase-KitchenSink/tree/web-support

I'm disappointed you guys aren't supporting the Gatsby RN-Web effort more. Gatsby is the final upgrade that RN-Web needs in order to make it really attractive for production use.
All other UI libraries work with it, just NativeBase doesn't. Please reconsider investing some time to support Sebastian in his effort @SupriyaKalghatgi .