Enable warnings as errors

Updated .editorconfig to set policy on some duplicate warnings for TODO. Borrowed from #89 to make merging easier
Added suppressions for analyzers that seem to be misfiring. Tracked in #90
Updated cases where nullability was incorrect (something could be passed as null but wasn't, something was marked as nullable but wasn't). Where possible added asserts so we can catch cases when they arise.
Removed <NoWarn> from Moq.Analyzers.csproj
Added <TreatWarningsAsErrors> and MSBuildTreatWarningsAsErrors elements to CodeAnalysis.props

Set each to true when MSBuild property $(ContinuousIntegrationBuild) is true from DotNet.ReproducibleBuilds package

@MattKotsenas we can turn off Codacy when we get reporting of coverage up as something we can gate on. We can also check in a config file to keep the integration sane. I disabled the Sonar analyzer, so I'm really just interested in code coverage and some obvious linting things in YAML, PowerShell, and JSON files. The recommendation from Codacy is to check in the configuration for the tools used themselves and it'll pick them up.


Button Box within Supertable within Neo - color value reverts to default upon cloning Neo block

We use a Button Box - Color field inside a Super Table field, which in turn is used in a Neo field. We noticed that upon cloning a Neo block, the color in the Button Box - Color field reverts to the default value (rather than sticking to the value from the block that was cloned).
Upon trying out various combinations of fields to isolate the issue, we realized that this was only happening when a Button Box - Color field was inside a Super Table field.
This might also be related to  #37.
Please help with fixing this. Thanks.
Versions used

Craft CMS: 3.4.30
Neo: 2.7.25
Super Table: 2.5.4
Button Box: 2.0.4

Cannot replicate this on the latest versions. Please comment if this is an issue.

We have the same issue, but without Super Table (just Neo).
Versions used

Craft CMS: 3.7.48

Neo: 2.13.13

Button Box: 3.1.0

Fixed in 4.2.2.


Inconsistent mutability between WriteChunkUninit::producer and ReadChunk::consumer

WriteChunkUninit::producer is typed as &'a Producer<T>.
But ReadChunk::consumer is typed as &'a mut Consumer<T>.
With current code, switching their mutability never makes compiler error.
But inconsistent mutability between them seems to be weird.
So I think we should mark both of them as mut or both of them as not mut .

Thanks, I'm trying to fix this in #81.
The mut is unnecessary because all mutation happens via Cell via interior mutability.
While looking at this, I also found out that two of the four Cell usages are not needed, see #80.

Thanks, I'm trying to fix this in #81.
The mut is unnecessary because all mutation happens via Cell via interior mutability.
While looking at this, I also found out that two of the four Cell usages are not needed, see #80.

Do you know that #80 and #81 is conflicting?
You should mark both of chunk types as mut with #80.

Do you know that #80 and #81 is conflicting?

No, I missed that, I was only looking at those two PRs separately and didn't realize that they are conflicting.
I've merged #81 and I've closed #80.

Oh. did you take that one?
I think #81 was better.

Oh, did you take that one?
I think #80 was better.

I think #80 was better.

I think this is a matter of taste, the generated machine code should be the same in both cases, right?
My argumentation for choosing #81 was:
I cannot get rid of all Cell instances, so why bother removing half of them?
And in case of doubt, immutable is better than mutable, isn't it?
Also, I haven't yet completely given up on #48, which would also not need &mut.
But if you have a good reason for #80, we can still make the change!


How is ref_unet used?

ref_unet is called and loaded here but the outputs noise_pred_cond is not used anywhere in the prediction
What is the point of loading ref_unet, and is it trained?

You can get the answer from this issue https://github.com/zjp-shadow/CharacterGen/issues/14


python 3.12 breakage on demo_imgui_bundle.py

Excerpt: ModuleNotFoundError: No module named 'imp' when trying to run unloaded modules of python code.
What the python hive mind has decided, FYI:
https://discuss.python.org/t/how-do-i-migrate-from-imp/27885/28
Log for reference:
(.venv) jhgs-MacBook-Air:pyimgui jhg$  cd /opt/work/pyimgui ; /usr/bin/env /opt/work/pyimgui/.venv/bin/python /Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher 49427 -- /opt/work/pyimgui/main.py
For information, demos sources are available in /opt/work/pyimgui/.venv/lib/python3.12/site-packages/imgui_bundle/demos_python
WARNING: Output of vertex shader 'Frag_Color' not read by fragment shader

0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
Traceback (most recent call last):
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3489, in <module>
    main()
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3482, in main
    globals = debugger.run(setup['file'], None, None, is_module)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 2445, in run
    m = save_main_module(file, 'pydevd')
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_utils.py", line 32, in save_main_module
    from imp import new_module
ModuleNotFoundError: No module named 'imp'
0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
Traceback (most recent call last):
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3489, in <module>
    main()
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3482, in main
    globals = debugger.run(setup['file'], None, None, is_module)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 2445, in run
    m = save_main_module(file, 'pydevd')
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_utils.py", line 32, in save_main_module
    from imp import new_module
ModuleNotFoundError: No module named 'imp'
0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
Traceback (most recent call last):
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3489, in <module>
    main()
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3482, in main
    globals = debugger.run(setup['file'], None, None, is_module)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 2445, in run
    m = save_main_module(file, 'pydevd')
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_utils.py", line 32, in save_main_module
    from imp import new_module
ModuleNotFoundError: No module named 'imp'
0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
Traceback (most recent call last):
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3489, in <module>
    main()
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3482, in main
    globals = debugger.run(setup['file'], None, None, is_module)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 2445, in run
    m = save_main_module(file, 'pydevd')
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_utils.py", line 32, in save_main_module
    from imp import new_module
ModuleNotFoundError: No module named 'imp'
0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
Traceback (most recent call last):
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3489, in <module>
    main()
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3482, in main
    globals = debugger.run(setup['file'], None, None, is_module)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 2445, in run
    m = save_main_module(file, 'pydevd')
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_utils.py", line 32, in save_main_module
    from imp import new_module
ModuleNotFoundError: No module named 'imp'
0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
Traceback (most recent call last):
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3489, in <module>
    main()
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3482, in main
    globals = debugger.run(setup['file'], None, None, is_module)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 2445, in run
    m = save_main_module(file, 'pydevd')
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_utils.py", line 32, in save_main_module
    from imp import new_module
ModuleNotFoundError: No module named 'imp'
0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
Traceback (most recent call last):
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3489, in <module>
    main()
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 3482, in main
    globals = debugger.run(setup['file'], None, None, is_module)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/pydevd.py", line 2445, in run
    m = save_main_module(file, 'pydevd')
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_utils.py", line 32, in save_main_module
    from imp import new_module
ModuleNotFoundError: No module named 'imp'
^CTraceback (most recent call last):
  File<EMAIL_ADDRESS>line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 88, in _run_code
    exec(code, run_globals)
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/__main__.py", line 39, in <module>
    cli.main()
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 430, in main
    run()
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 284, in run_file
    runpy.run_path(target, run_name="__main__")
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 321, in run_path
    return _run_module_code(code, init_globals, run_name,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 135, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 124, in _run_code
    exec(code, run_globals)
  File "/opt/work/pyimgui/main.py", line 130, in <module>
    main()
  File "/opt/work/pyimgui/main.py", line 126, in main
    immapp.run(runner_params=runner_params, add_ons_params=addons)
  File "/opt/work/pyimgui/main.py", line 106, in show_gui
    @static(nb_frames=0)

  File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_trace_dispatch_regular.py", line 326, in __call__
    def __call__(self, frame, event, arg):

Hi,
Thanks for contacting me. I cannot reproduce your issue.
Based on your command line, I can diagnose several things:
(.venv) jhgs-MacBook-Air:pyimgui jhg$  cd /opt/work/pyimgui ; /usr/bin/env /opt/work/pyimgui/.venv/bin/python /Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher 49427 -- /opt/work/pyimgui/main.py

I happens inside a file/opt/work/pyimgui/main.py script which content I do not know.
However, please note that imgui_bundle bindings are separate from pyimgui.
They can coexist in the same virtual environment, however the following python code would fail!
import imgui # import imgui from pyimgui
from imgui_bundle import imgui # import imgui from imgui_bundle

As far as your error is concerned, here are the relevant lines:
File "/Users/jhg/.cursor/extensions/ms-python.python-2023.14.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_utils.py", line 32, in save_main_module
    from imp import new_module
ModuleNotFoundError: No module named 'imp'

It seems to happen inside debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_utils.pywhich is probably part of pydevd, and possibly installed by vscode (no idea about why it is inside  /Users/jhg/.cursor/extension)


Bumped Web Chat to 4.14.0

Bumped botframework-webchat version to @4.14.0
Also fixed some minor breaking changes with the formidable library.

Coverage decreased (-0.03%) to 67.828% when pulling 8ea63b54bab79d6d6b4e5182b22409d9be9b6d18 on toanzian/bump-wc into 1cd775d4f9d7529be34943cdc70334a1484314a0 on main.

@tonyanziano btw, could you remove me from codeowners? :)


Deforming (consistent vertex) .glb animation is broken since the new release

Description
My .glb's NFT's were generated from blender with vertex cache
as a deforming animated .glb and worked fine in 1.9.1,
in the newer version 1.9.2 of MV the animation looks all messed up and broken
please see live demo on desktop
Live Demo
all these 3 NFTs displays with wrong animations on Desktop but still works fine on mobile:
https://foundation.app/@ronentanchum/~/90888
https://foundation.app/@ronentanchum/~/90197
https://foundation.app/@ronentanchum/~/88631
links to .glb files on IPFS:
https://ipfs.io/ipfs/QmUtuZEc12YyRiEoF7bHzH69ZraJJvXuQs9xBMxpd3Qf7C/nft.glb
https://ipfs.io/ipfs/QmS87VqXbLpPzy36rCck2AyFiJTAxwYPHx7NK16UiP1whX/nft.glb
https://ipfs.io/ipfs/QmejbvkfT8MU3yQrtgeWNoBP2jD3z51GQu4QZEbWHHHvdm/nft.glb
Version
worked ok in 1.9.1
1.9.2 is broken
Browser Affected
Chrome 95.0.4638.69
OS
AR
In AR these animated 3 .glb files are not moving but in the web browser they do

[ ] WebXR
[ ] SceneViewer
[ ] QuickLook

Hi @RonenTanchum, thanks for reaching out. This sounds like an iOS issue. Have you tried filing a bug here?
https://bugs.webkit.org/

Hi @RonenTanchum, thanks for reaching out. I confirmed the animation doesn't work on my iPhone XR, safari, ios 15. Can you confirm if it still works with the previous version of ModelViewer like 1.8 in the same iOS/Chrome version? There is a known issue with the recent version of iOS and it'd be helpful to make sure this is not the same bug. You can also try filing a bug at https://bugs.webkit.org/ if it turns out that's the case.

47Mb! I'm impressed it  works as well as it does. The animation seems to be fine on Chrome on my Macbook  Pro, but I see some funny  artifacts on my Pixel 3 and it definitely doesn't work right in Scene  Viewer for AR. Did you check that  your glTFs are valid? Is this using  morph targets rather  than skeleton-based animation?

Hi Yes GLBs are valid, used to work fine when i minted it Sept 2021.
Using morph targets not skeleton, something in the new ver broke this and reverting back to 1.8 fixes it on all devices.

@mrdoob This looks  like a three.js morph  target regression sometime in the last 6 months. Any thoughts? Sidenote: this is  why I was concerned about NFTs automatically using  the latest MV / three.js versions rather than pinning them. These  art pieces are more likely to take advantage of edge cases, and so more likely to break with no recourse when  they can't specify a version. Then again, the opposite is true for browser  bugs, so maybe this is just a hard problem...

Opensea did fix this, reverting back to the olderver. thanks to matt
however, in foundation its still broken and they are not reverting...
here are the links to the working version on Opensea
https://opensea.io/assets/0x3b3ee1931dc30c1957379fac9aba94d1c48a5405/90888
https://opensea.io/assets/0x3b3ee1931dc30c1957379fac9aba94d1c48a5405/90197
https://opensea.io/assets/0x3b3ee1931dc30c1957379fac9aba94d1c48a5405/88631

I'm unable to reproduce. The animation looks identical in OpenSea and Foundation here (Chrome 97, MacOS 11.6.2).
For people that can reproduce the issue, any chance that you can share a screen recording here?

Yeah, it's fine on my macbook too. My Pixel 3 was showing some issues though. I'd  guess Windows? @RonenTanchum Can you be very specific about what devices repro the behavior and share a screen recording?

Yes, on mac+chrome looks ok, but on PC(win10)+chrome is broken on foundation please see screen recordings
https://user-images.githubusercontent.com/19776099/148841430-018844bd-7ffd-486e-9bf8-7f47484d2b3e.mp4

Thanks @RonenTanchum 🙏
@samaneh-kazemi you said:

I confirmed the animation doesn't work on my iPhone XR, safari, ios 15.

Do you mind specifying that "doesn't work" mean? Do you mean that it doesn't play, or that it looks like in the screen recording @RonenTanchum shared?

@samaneh-kazemi you said:

I confirmed the animation doesn't work on my iPhone XR, safari, ios 15.

Do you mind specifying that "doesn't work" mean? Do you mean that it doesn't play, or that it looks like in the screen recording @RonenTanchum shared?

I tested on 2080ti rtx & on 980ti gtx
win10 with nvidia drivers 457.30

Thanks!
Okay, I suspect https://github.com/mrdoob/three.js/pull/22293 is the culprit.

/ping @Mugen87

Yeah, the new morph target implementation based on texture arrays seems to be problematic on certain devices. Unfortunately, I have no device at hand that reproduces the bug but some devs at the three.js repo reported related issues:
https://github.com/mrdoob/three.js/issues/23190
https://github.com/mrdoob/three.js/issues/23063
@RonenTanchum Can you please verify if the same issue occurs if you import the asset with BabylonJS?
https://sandbox.babylonjs.com/
The morph target implementations are similar since both engines use texture arrays for organizing morph data. If it works with BabylonJS, there is a good chance to fix something in three's shaders.

This issue should be fixed in three.js starting from r139.

Hell yeah! thanks so much for the update, this means a lot finally people
would get to enjoy those glbs :)
Working on some new cool ones!
Thanks,
Ronen

RONEN TANCHUM
CREATIVE DIRECTOR | FOUNDER+972-585477962 | +17788075118
PHENOMENALABS.COM http://phenomenalabs.com/
On Sat, Apr 2, 2022 at 11:12 AM Michael Herzog @.***>
wrote:

This issue should be fixed in three.js starting from r139.
—
Reply to this email directly, view it on GitHub
https://github.com/google/model-viewer/issues/2986#issuecomment-1086584000,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEW4EY3DUJFFOX6UNDSVK5TVC76OBANCNFSM5IOHYYTA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Fixed in #3350


SLEEP-1458 Add instance-like filters on entities

I'm really excited about this one!
This PR adds JSON logic filters to the entities page to allow searches such as 'give me all entities that have a form instance with "A" == "100"'.
It uses the react-awesome-query-builder in the frontend, formatting the data as "subfields", and adds support in the backend to turn this into SQL EXISTS subqueries.
PR on bluesquare-components: https://github.com/BLSQ/bluesquare-components/pull/164
Related JIRA tickets : https://bluesquare.atlassian.net/browse/SLEEP-1458
Note: I'm fairly confident that the generated queries are correct. My main concern is performance when the instances/entities tables grow. I plan to use Trypelim as the guinea pig for this. With about 100K entities and 200K instances it should give us an idea of how this will scale.
Self proofreading checklist

[x] Did I use eslint and black formatters
[x] Is my code clear enough and well documented
[x] Are my typescript files well typed
[x] New translations have been added or updated if new strings have been introduced in the frontend
~My migrations file are include~
[x] Are there enough tests
~Documentation has been included (for new feature)~

Print screen / video
https://github.com/user-attachments/assets/311c8ad4-db7c-4767-a15d-6666ad4d332f
Notes
Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here

Backend LGTM
Kudos because this is advanced work with the ORM.
I'm also concerned with performance and curious to hear about how Trypelim's going to handle it.

So far so good! But it's only on about 100K beneficiaries for now. The good part about the QueryBuilder is that the frontend is already prepared for if/when we want to use something like Elastic search to return the results from the backend.

can you please move those fields


jq: fix download hash

Motivation for this change
It looks like the upstream download file for jq 1.6 has changed (this seems to be an attached source tarball on github, not an actual hash download).
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I confirm the hash is different for me, too
rasen@omicron ~/p/nixpkgs> nix-build -A jq.src --check
checking outputs of '/nix/store/mm0vjqh9pswlqahbryq24h3rr9k8qp1v-jq-1.6.tar.gz.drv'...

trying https://github.com/stedolan/jq/releases/download/jq-1.6/jq-1.6.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   602    0   602    0     0    671      0 --:--:-- --:--:-- --:--:--   670
100 1709k  100 1709k    0     0   445k      0  0:00:03  0:00:03 --:--:--  625k
warning: rewriting hashes in '/nix/store/wxib70mfqfw6i67cplpdwj79f1gs9qr9-jq-1.6.tar.gz'; cross fingers
fixed-output derivation produced path '/nix/store/ggjlgjx2fw29lngbnvwaqr6hiz1qhy8g-jq-1.6.tar.gz' with sha256 hash '0wmapfskhzfwranf6515nzmm84r7kwljgfs7dg6bjgxakbicis2x' instead of the expected hash '1a76f46a652i2g333kfvrl6mp2w7whf6h1yly519izg4y967h9cn'
error: build of '/nix/store/mm0vjqh9pswlqahbryq24h3rr9k8qp1v-jq-1.6.tar.gz.drv' failed

@GrahamcOfBorg build jq

Can we first check why it changed before merging this?

@arianvp see https://github.com/stedolan/jq/issues/1773#issuecomment-441624322


update Client interface

Would we possibly consider update the Client interface to include these existing methods in the implementation? It would make discovery easier for devs using this package. Thanks for writing this up!

@jayhtian sorry fo the late review, seems that the linter is complaining. Could your run a make format and check with a make lint to check that everything is fine?
Thanks for the contribution BTW!


Build warning: "failed to parse serde attribute"

When doing yarn build:wasm-dev
$ rustc --version
rustc 1.73.0 (cc66ad468 2023-10-03)
2023-11-09 09:36:27-05:00

warning: failed to parse serde attribute
  |
  | #[serde(rename = "XY", alias = "xy")]
  |
  = note: ts-rs failed to parse this attribute. It will be ignored.

Thanks for filing, this is a known issue -- see the ts-rs crate's docs on serde for why: https://docs.rs/ts-rs/latest/ts_rs/#serde-compatability
I haven't looked into it much yet, there might be a way to silence the warning, or maybe to use newtypes to break out the serde stuff from the ts-rs stuff.

thanks to paul


weird connection reset error

@ibrahimk157 reports having issues with bazaar, the error triggered is:
{
  "errors": [
    {
      "code": 500,
      "title": "Internal server error",
      "detail": "LogicException: Lost connection and no reconnector available. in /home/u542484920/public_html/forum/vendor/illuminate/database/Connection.php:715\nStack trace:\n#0 /home/u542484920/public_html/forum/vendor/illuminate/database/Connection.php(684): Illuminate\\Database\\Connection->reconnect()\n#1 /home/u542484920/public_html/forum/vendor/illuminate/database/Connection.php(624): Illuminate\\Database\\Connection->tryAgainIfCausedByLostConnection(Object(Illuminate\\Database\\QueryException), 'select exists(s...', Array, Object(Closure))\n#2 /home/u542484920/public_html/forum/vendor/illuminate/database/Connection.php(324): Illuminate\\Database\\Connection->run('select exists(s...', Array, Object(Closure))\n#3 /home/u542484920/public_html/forum/vendor/illuminate/database/Query/Builder.php(1637): Illuminate\\Database\\Connection->select('select exists(s...', Array, true)\n#4 /home/u542484920/public_html/forum/vendor/flarum/core/src/Settings/DatabaseSettingsRepository.php(43): Illuminate\\Database\\Query\\Builder->exists()\n#5 /home/u542484920/public_html/forum/vendor/flarum/core/src/Settings/MemoryCacheSettingsRepository.php(52): Flarum\\Settings\\DatabaseSettingsRepository->set('flagrow.bazaar....', 1)\n#6 /home/u542484920/public_html/forum/vendor/flagrow/bazaar/src/Search/FlagrowApi.php(99): Flarum\\Settings\\MemoryCacheSettingsRepository->set('flagrow.bazaar....', 1)\n#7 /home/u542484920/public_html/forum/vendor/guzzlehttp/promises/src/FulfilledPromise.php(39): Flagrow\\Bazaar\\Search\\FlagrowApi->Flagrow\\Bazaar\\Search\\{closure}(Object(GuzzleHttp\\Psr7\\Response))\n#8

This has been most likely a memory issue.

@Luceos but how come it used to work like a charm before? It used to work perfectly until i updated to the version with the update feature.

Updating is a very lengthy process, we will explore new ways of reducing memory usage and process duration in the future. We already have some ideas how to do so, but that will be a bit more far-reaching in what we do to change the Flarum install.

@Luceos it's not the updating of extensions that's not working (in fact, I haven't even tried using the update feature yet) .... it's the installation of extensions.... it used to always work but ever since the bazaar version that contains the extension update feature, even the extensions that successfully installed previously now give this same exact error if i try install them again (yes, i did remove them for the purpose of testing... but I removed them through ssh)

I have no idea what could trigger this error, but here are a few leads:
Laravel sets a database reconnect strategy (https://github.com/laravel/framework/blob/v5.1.38/src/Illuminate/Database/DatabaseManager.php#L195) but Flarum does not (https://github.com/flarum/core/blob/v0.1.0-beta.6/src/Database/DatabaseServiceProvider.php) so any databse timeout will cause this exception (thrown here https://github.com/laravel/framework/blob/v5.1.38/src/Illuminate/Database/Connection.php#L715)
Not found any useful Stackoverflow thread so far, this exception probably never happens with a real Laravel application given it has a reconnector. Maybe adding a reconnector to Flarum could prevent such issue to happen again.

We could temporarily do this ourselves and PR against core to patch this.

@Luceos Can't wait!!!


Load chart should show components of load

Currently the load chart only shows the total load on a network component. It would be very informative to be able to see how this load is composed by technology:

To be able to do this, the end-points (and the load calculation) of the network need to be able to deal with loads per technology. So, it will no longer suffice to initialise the end-points with just a single load value. In stead, an array of loads (and their respective technologies) needs to be communicated.
@grdw can you explore the feasibility of this?

This is a possibility: http://bl.ocks.org/mbostock/3885211

This is a possibility: http://bl.ocks.org/mbostock/3885211

I like that it gives a cleaner (no overlapping curves) subdivision of the load. I don't think it is perfect though because it does not show the shapes of the different contributions (except the bottom one). This could make it difficult to see which of the various technologies is actually peaking at a given point.

The library we're using for the current chart, NVD3, supports a chart like that. I don't think it can be used with the "view finder" (the smaller chart which allows you to zoom in), but that may not be a big deal since higher-resolution charts are currently supported only by using the <select> to choose a week.
--
My feeling is that this issue should probably go on-hold for now; there are two problems which will make it difficult:

Large testing grounds already involve transferring a lot of data from the Rails app to the user's browser. The Lochem scenario, which has 200+ network connections, and 35,040 loads for each connection (one for every 15 minutes in the year), already takes several seconds just to convert the data to JSON for transmission to the browser. This is not surprising since we have to send the network structure and 7 million loads. The JSON response for the Lochem scenario is 95MB (26MB compressed)! Sending technology loads might increase this by an order of magnitude. :scream:

It would be better to wait until we are caching the results of the calculation, that way we can send the technologies loads only when the user really needs them.

While the loads for "simple" technologies are easy to determine without calculating the entire network – most are a function of their capacity and their load curve – some, such as storage, are more complicated. These are only known after the network has been calculated. The way you access this data is subject to change while I work on the new flow calculator.

--
I think this should wait at least until the new network calculation is ready to avoid waisting effort on something which is likely to change. Ideally, we'd schedule a "caching" task for the next sprint, and revisit then...

Thanks for your comments @antw. Putting this issue on-hold for now.

Can this be closed?


DPL-037 Beckman endpoint should check for existing sample (C=M)

User story
DPL-037 As someone reporting on the Heron data, I would like the Beckman plate creation endpoint to :

check whether the relevant samples already exist already in Sequencescape, and
use them if exist
so that we avoid creating duplicate records, with differing COG UK IDs, for the same sample.

Who are the primary contacts for this story
Katy, Harry, James M, Sara
Acceptance criteria
When the Beckman plate creation endpoint is called from the Beckman software, or from the page where you manually scan the destination plate barcode in:

[ ] Destination plate is created
[ ] Wells on that plate are filled with either new samples, or existing samples (or a mixture), depending on whether the samples already exist in Sequencescape
[ ] Match samples based on root sample id (description), source / stock plate barcode, well position on that plate, and result (phenotype).

Additional context

Not sure how hard this will be. Might need some research first.
The other way around (Beckman first, then Sentinel) was considered and decided it was low risk, so not being actioned at this time (https://ssg-confluence.internal.sanger.ac.uk/display/PSDPUB/Duplicate+COG+UK+IDs+May+2021, 1st agenda question point b)

@andrewsparkes @emrojo do you know if the endpoints that create samples in SS will remain our responsibility, or transfer to PaM? Thanks

Viewed as unlikely to happen now that all Heron samples go through the Beckman robot only and all samples are allocated a COG UK Id on creation.


Create model package with classes

Purpose
The purpose of this PR is to fix #7
Goals
To create the classes according to the class diagram.
Approach
Created the model package with the necessary classes.
Checklist

[x] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
[x] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Related Links
https://drive.google.com/file/d/13BsmmxXJBgv3Ul5khC2Isac3Z7IxdfOU/view

Shall we avoid using Lombok getters and setters?


What're the options for the requiredToBeDocumented option?

Search terms

requiredToBeDocumented
documentation
reflection

Question
I'm new to TypeDoc. I see that the requiredToBeDocumented option is documented here: https://typedoc.org/options/validation/#requiredtobedocumented. However, I do not see documentation for what values this option accepts or what they mean. So far I've determined the possible options by intentionally triggering this error message:
[error] 'X' is an invalid value for 'requiredToBeDocumented'. Must be one of: Project, Module, Namespace, Enum, EnumMember, Variable, Function, Class, Interface, Constructor, Property, Method, CallSignature, IndexSignature, ConstructorSignature, Parameter, TypeLiteral, TypeParameter, Accessor, GetSignature, SetSignature, TypeAlias, Reference

It seems weird to me that I have to provide an invalid value in order to even find out what the valid values are.
Even after discovering these values, I'm unsure what some of them mean. Obviously some are obvious, like Function, but others aren't (to me at least). For example, what is CallSignature? (I'm unsure of others as well, not just that one.)

I've now found the possible values by browsing the API page: https://typedoc.org/api/interfaces/Configuration.TypeDocOptions.html#requiredToBeDocumented
Still haven't found any explanations though.

The API page unfortunately looks like it's also including all of TypeDoc's shortcuts which are unions of two or more reflection kinds (that enum is made up of increasing powers of two to allow such usage)
You're absolutely right that the docs are lacking here, updating!

How's this look? https://github.com/TypeStrong/typedoc-site/commit/c191ef566f0a88ba83afca55cf1d17064ce9b522

Wow thanks, that looks awesome! The only option that I'm still wondering about is Project, what does that correspond to?

The top level reflection in your documentation is the Project, guess I should make a note about that too
There's only ever one, so it generally doesn't make sense to require it be documented (it also can only be documented if you have a single entry point)

Cool, thanks! All my questions have been answered for this then! 🥳


User/sachinta/fix DeploymentManager's GetStatus

DeploymentManager GetStatus is searching for Framework package name's prefix (Microsoft.WindowsAppRuntime) to build PackageFamilyNames of Main and Singleton packages before verifying they are installed on the machine. It doesn't work as both Main and Singleton share a different package name prefix (i.e. MicrosoftCorporationII.WinAppRuntime) than that of Framework package prefix

/azp run

/azp run

/azp run


Check action performance with lot of commits

The queue loads the messages from the git log output:
private async loadMessagesFromGit(): Promise<void> {
  await this.guardThatGitRepoHasBeenInitialized()

  const noCommits = !(await this.gitRepo.hasCommits()) ? true : false

  if (noCommits) {
    return
  }

  const logCommits = await this.gitRepo.log()

  const allMessages = CommittedMessageLog.fromGitLogCommits(logCommits.all)

  this.committedMessages = allMessages.filterCommitsByQueue(this.name)
}

I suppose SimpleGit loads all commits in memory when you use logCommits.all that could be a problem. I do not expect it to be too slow or too big for very big repositories with a lot of commits but at least we should know the limit. We could improve the process (if needed) with:

Not loading all commits in memory and processing and filtering them on the fly.
Stop processing commits once we load the active job (one-job version of the queue) or all active jobs (multiple-active-jobs version of the queue)
Maybe, if we modify the nextJob() or we even add a new method to get a given job getJob(jobId: JobId) we might need to re-process the git log to find the information for the missing job if we do not have it in memory. In this case, the CommitMessageLog attribute of the queue would be only a cache of the full queue information.

I'm going to add this issue to the roadmap for a future release. This issue is not intended to be the solution for the potential bottleneck problem. If we decide to do something we can discuss the solution and create a new issue for the implementation.
@da2ce7 @yeraydavidrodriguez

Related: https://github.com/Nautilus-Cyberneering/git-queue/issues/81

We have a test project that has been using git-queue since 2022-01-11. At the moment, It has 8440 commits. I've just run a test this way:
Install git-queue to use it locally
mkdir /tmp/Nautilus-Cyberneering
cd /tmp/Nautilus-Cyberneering
git clone git@github.com:Nautilus-Cyberneering/git-queue.git
cd git-queue
git checkout v1-beta
yarn install && yarn build

I'm using the same version we are using on that test project.
Install the test project
mkdir /tmp/Nautilus-Cyberneering
cd /tmp/Nautilus-Cyberneering
git clone git@github.com:Nautilus-Cyberneering/library-consumer.git

Execute git-queue to get the latest job
TIME='\t%E real,\t%U user,\t%S sys,\t%K amem,\t%M mmem' \
INPUT_QUEUE_NAME="Library Update [library-aaa]" \
INPUT_ACTION="next-job" \
  time node /tmp/Nautilus-Cyberneering/git-queue/dist/index.js

The output:
::group::Debug info
git_repo_dir: /tmp/Nautilus-Cyberneering/git-queue
gnupg_home_dir: /home/josecelano/.gnupg
::endgroup::
::group::Setting outputs
::set-output name=job_found::false
::endgroup::
	0:00.12 real,	0.07 user,	0.02 sys,	0 amem,	37056 mmem

I think the method could be a base idea for a benchmarking workflow mentioned here. But we can use a fixed test project or create it. Using an external fixture project would make the test faster.


todo

[x] Make caches global with unsafeMake
[x] Add renderToString for SSR
[x] Remove non-standard functionality (.|@|?|ref|dataset|aria)
[x] Expose Many.from as Collection
[x] Add ref with ElementRef
[x] Add basic afterRender hook
[x] Add unit tests for render & renderToString
[ ] Add support for directives to generalise behaviour for nodes

see #2 for the directive support/discussion


[Workflows] Rename callSubWorkflow to callChildWorkflow

The Java SDK uses the method name callSubWorkflow rather than callChildWorkflow in the workflow context
The Dapr documentation refers to child workflows , so I would recommend that the Java SDK change the method name to callChildWorkflow for consistency.

@olitomlinson ok.. PR created.. I will follow the tests to see if I am missing something.
@artursouza do you know if we need to deprecate the old methods? Do you know how to create a release note for this change? It is a simple replace to upgrade to this new signature.


Workflow improvements

Description
Improve the integration & delivery workflow and the deployment workflow by splitting jobs for each platforms.
For example, in the integration & delivery workflow, we should have a job for integrating changes targetting the JVM platform, then another job for integrating changes targetting the JS platform...
Checklist

[x] Improve the integration & delivery workflow.

See this documentation for creating reusable workflows.

Done.


Extra Shortcut files in Start menu and Program Files (x86)

Shortcuts to grcdownloadblocks.dat, grcupgrade.bat, and gridcoinresearch.exe are installed in C:\ProgramData\Microsoft\Windows\Start Menu\Programs\GridcoinResearch on Windows. There is also a Shortcut to gridcoinresearch.exe installed in C:\Program Files (x86)\GridcoinResearch.
Is there any way to stop it from installing these? Most people create quick links or whatever to their wallets on their own.

In my opinion the only shortcut there should be is to gridcoinresearch.exe and the name of the shortcut should be Gridcoin Research.
Like most installers there should be an option to enable/disable creating the shortcut via a checkbox. There should be a checkbox for placing a shortcut on the desktop and a checkbox for placing it in the start menu.

in next release i'll have the stray shortcut in the program files removed. currently the short cut in start menu is cleaned up. quick launch is a internet explorer component and add an option maybe possible as i'm still looking into it more but looks like custom actions etc

Shortcut for the website should be kept, in case the application can't be started.

i'll add a shortcut for website. however i tried to do a dialog allowing user to pick what shortcuts they want to place where but for some reason it is known that the msi project has issues so its not verifying the condition to place short cuts or not. so thats out for the quick launch etc by user choice.


Update reset-cache.md

Adds content around the new tenant admin refresh.

Docs Build status updates of commit 4b4521e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/file-handlers/reset-cache.md
:warning:Warning
View (>= odsp-graph-online)
Details

docs/file-handlers/reset-cache.md

Line 52, Column 1: [Warning-multiple-h1s] Multiple H1s(H1 'Tenant Admin Reset') are not allowed. You can only have one top-level heading.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 3, Column 12: [Suggestion-ms-author-invalid] Invalid value for 'ms.author', 'rgregg' is not a valid Microsoft alias.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Language and Editorial Comments

For sanity, I am collecting all of my editorial and linguistic comments into a single issue.  Section numbers are shown for each instance individually below.  I believe most of these are Low or Medium priority, as they are not substantive.

Volume 1

1:54.1 DSUBm Actors, Transactions, and Content Modules

Table 1.54.1-1: Actors should link to the sections describing them
1:<IP_ADDRESS>-1:<IP_ADDRESS>: "that support the" should be "that supports the"
1:54.1.2: Transaction Descriptions: given that 1.2.1-1.2.5 are just links, could these sections be collapsed down to a table?

1:54.2: Actor Options

"The [actor] that declares to support this option…" is hard to parse.  Perhaps something like "[Actor]s that declare support for this option…" or "The [actor] that declares support for this option…"?
"Options that may be selected for each actor…" is a bit awkward to parse given that the guide is static text.  Perhaps something more like "Optional functionality that may be implemented for each actor…"?
It would be nice to include a table showing the differences between the related options.  E.g., columns for each 54.2.1 - 54.2.6, rows for the ITIs, and 'x's in the ones that have them; or columns for each 54.2.1 - 54.2.6 and a single row with the ITIs listed; etc.
1:54.2.1: DocumentReference Subscription for Minimal Update option

"This option extends the creation of a DocumentReference resource including also the update of the “status” and the delete events of a DocumentReference Resource." should be something like "This options extends the triggers for the creation of a DocumentReference resource to also include updates of the document “status” and delete events of a DocumentReference Resource." (extend triggers, not the creation itself).
Citations of ITI docs should be links.

1:54.2.2 DocumentReference Subscription for Full Events option

"This option extends the creation of a DocumentReference resource including all possible update events and the delete events of a DocumentReference Resource." should be something like "This option extends the triggers for the creation of a DocumentReference resource to include all possible update events and delete events of a DocumentReference Resource." (extend triggers, not the creation itself).
Citations of ITI docs should be links.

1:54.2.3 Basic Folder Subscription option

"This option permits to subscribe for Folder type List Resource and describe the basic trigger events considered for a Folder Subscription." should be something like "This option permits [subscribers/specific actor] to subscribe for events about Folder type List Resources and describes the basic trigger events considered for a Folder Subscription."
"This option includes the creation of a Folder type List Resource and a limited update event on a Folder type List Resource." should be something like "This option includes triggers about the creation and limited update events on a Folder type List Resource."
Citations of ITI docs should be links.

1:54.2.4-1:54.2.6 have the same sentence structure issues and ITI linking request.

1:54.4 DSUBm Overview

1:54.4.1 Concepts: Missing spacing between paragraphs.

1:54.5 Security Considerations

"The reader should also consider the indication included in Safety and Security section." should be something like "The reader should also consider the information included in Safety and Security section of the Subscription Backport IG."

Volume 2

2:3.110.4 Interactions

There is an 'update' interaction specified in the scope that is not shown in Figure 2:3.110.4-1

2:3.11x.4 Interactions

The diagrams in 2:3.112.4 Interactions and 2:3.113.4 Interactions contain links to all the messages.  For consistency, I would recommend either adding links to 110.4, 111.4, and 114.4 or removing them from 112.4 and 113.3.

2:<IP_ADDRESS> Expected Actions

MIME types (application/fhir+[json|xml]) are not formatted as code elements.

2:<IP_ADDRESS> Message Semantics

HTTP response codes in the second paragraph are not formatted as code elements.
"Bundle.entry.response.status" is not formatted as a code element.

2:3.111.8 Security Considerations, 2:3.112.15 Security Considerations, 2:<IP_ADDRESS> Security Considerations, and 2:<IP_ADDRESS> Security Audit Considerations

Recommended to avoid contractions ("It's") for non-native English speakers.

2:<IP_ADDRESS> Security Audit Considerations, 2:<IP_ADDRESS> Security Audit Considerations, and 2:<IP_ADDRESS>.1 Security Audit Considerations

The content is repeated for two actors, suggest collapsing into a single paragraph that references both actors.

2:<IP_ADDRESS> Message Semantics

"the Bundle.type element valued history" is different than all the other sections: "the Bundle.type element set to history"

Changes to Other IHE Specifications

IHE Technical Frameworks Document Metadata Subscription (DSUB) Profile

Table is shown as markdown source.

Hi @GinoCanessa
thank you for reporting the problems and sharing your opinion
We have published the branch
edit-post-pc
with the major part of your comments.
We think we are going to wait next week to review together this issue during the f2f.
After the review we intend to finalize the edits and close this issue.

Hi @GinoCanessa thank you for reporting the problems and sharing your opinion
We have published the branch edit-post-pc
with the major part of your comments. We think we are going to wait next week to review together this issue during the f2f. After the review we intend to finalize the edits and close this issue.

If the committee thinks that any of the suggestions/changes should involve a change to the template, please let me know. Thank you.

resolved in the last editorial integration


Enable iteration of linked list items

Closes https://github.com/wooorm/linked-list/issues/8. I wouldn't be offended if you don't merge this functionality since it's an ES5 module currently and this is introducing ES6 features. I promise iteration is a super fun feature to use, but totally understand it's not very widespread yet.
Edit: It is written in an entirely backward compatible style though, so it can work in ES5, instead of just using generator functions to create the iterator.

@blakeembrey Thanks! I resolved the comments above myself, to get a better feeling for what was going on.
Any suggestions for the docs?

Yes, sounds good! Would you like to add some examples and notes?
Also, maybe the LinkedList.from(list) may be confusing, as it’ll detach all the items in the original list!


arm/llvm/clang: add support for LLVMEmbeddedToolchainForArm release-15.0.2

Summary
arm/llvm/clang: add support for LLVMEmbeddedToolchainForArm release-15.0.2
Upstream:
https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm/releases/tag/release-15.0.2
Signed-off-by: chao an<EMAIL_ADDRESS>Impact
N/A
Testing
lm3s6965-ek/qemu-flat

I see that cibuild.sh and Dockerfile still point to 14.0.0 version. Is this PR complete? Or there is some dependency?

I see that cibuild.sh and Dockerfile still point to 14.0.0 version. Is this PR complete? Or there is some dependency?

Yes, the ci script needs to be updated after PR https://github.com/apache/incubator-nuttx/pull/7391 check in


设置syncY: true后双y轴的刻度还是不统一

The issue which is not created via https://antv-issue-helper.surge.sh will be closed immediately.
---设置syncY: true后双y轴的刻度还是不统一

请问博主解决了吗

The issue which is not created via https://antv-issue-helper.surge.sh will be closed immediately.
---设置syncY: true后双y轴的刻度还是不统一

哈喽，请问大佬解决了吗，方便提供下解决方案吗

The issue which is not created via https://antv-issue-helper.surge.sh will be closed immediately.
---设置syncY: true后双y轴的刻度还是不统一

哈喽，请问大佬解决了吗


Change "unparseable JSON" error to HTTP 400 (follow-up to #1200 / #1212)

Initial mapping of JsonParseException -- for invalid JSON that cannot be parsed -- is to HTTP 200 with ErrorCode.INVALID_REQUEST_NOT_JSON.
But it would make more sense to actually indicate it as HTTP 400 (same ErrorCode) since we cannot actually process is at all, the criteria for returning 200/OK.

Re-opened: #1217 is a pre-req but did not fully resolve this issue.


Fix PHP 8.1 deprecation notices

This fixes the deprecation notices reported in #425 by specifying the int return type for the count functions.
Initially I wanted to use the master branch but it is lacking the Predis driver that we use.
I figured this would be more inclusive than using #[\ReturnTypeWillChange] given we only need to bump to PHP7 or higher and not PHP8.
Since this removes support for PHP5 (about time I guess? :)) I would suggest to release this as 0.14.0.

Hi guys,
when this will be merged and created new release?
We are using this package in our project and we also have this deprecation notice.

@sagikazarmark ping? can you give any update on the status of the project?


Argument --no-title does not work

File README.md mentioned several examples, and the ones contains argument --no-title are not functioned as expected.
$ echo "Label,3,9,1" | termgraph --custom-tick "😀" --no-title --no-labels
termgraph: error: unrecognized arguments: --no-title

@jserv Hi, I was curious about the same things.
mkaz says the --no-title argument was old from when the title was shown by default, now there is no title by default.
The document has been updated.
Thanks.


Build error on 32 bit Linux machine

make install on my machine fails:
$ make install
# vendor output snipped
go install -ldflags "-X github.com/pilosa/pilosa/cmd.Version=v0.3.1-53-g92641ae -X github.com/pilosa/pilosa/cmd.BuildTime=`date -u +%FT%T%z`"  github.com/pilosa/pilosa/cmd/pilosa
# github.com/pilosa/pilosa/roaring
roaring/assembly.go:17: missing function body for "hasAsm"
roaring/assembly.go:19: missing function body for "BSFQ"
roaring/assembly.go:21: missing function body for "POPCNTQ"
make: *** [install] Error 2

I assume this is because it's a 32 bit system, but if not:
$ uname -rvpio
4.4.0-75-generic #96~14.04.1-Ubuntu SMP Thu Apr 20 11:06:56 UTC 2017 i686 i686 GNU/Linux

$ go version
go version go1.8 linux/386

It builds fine on 64bit.

Confirmed I cannot build on 32-bit, both Linux and OS X.


BREAKING CHANGE: added customization of routes in the config file

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines:
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #75
What is the new behavior?
Does this PR introduce a breaking change?
[X] Yes
[ ] No

Other information

@oliuz  LGTM. Nice work. Thanks!


📦 NEW: CLI Project

This PR adds the corona-cli project to the list.
And fixes a couple of other things:

👌 IMPROVE: Markdown format (spacing before after headings)
👌 IMPROVE: Lower-cased the file names away from the screaming case
🐛 FIX: Broken link of code-of-conduct file.

Peace!

Super glad to help. 😇


Enterprise landing page

New Enterprise tab and landing page. Styled after https://www.figma.com/file/I8XMe7wkMiDzL27U8ISypU/OpenCost-Enterprise?node-id=27%3A140&t=IOSD0BzBGb4Q5PzH-0
Fixes https://github.com/opencost/opencost-website/issues/66

+1 on @Annalillie's comments! I feel drop shadows really help group content in these cards

Burke has volunteered to help out here. His name isn't popping up for a mention but I have sent him this issue and its details.

@Annalillie I appreciate how the 2 things you mentioned are the exact 2 that I fought with before giving up 🤣

I've given Burke a screenshot with the needed changes highlighted

Alright, I think this is about as far as I can take this right now. I've fixed and/or improved what I could where I could. @mattray just let me know if there is anything else I can help with. Happy to walk through my changes with you in detail and to continue to be involved where ever. Below is a long-ish overview (watch at 1.5-2x) of where things landed. Enjoy!


Getting odd output from swiftCallback??

I'm using the library with Swift 3 on iOS 10.3.2. Everything seems to be working correctly, but I keep getting odd messages in the debug output:
GEOSwift # %s.
GEOSwift # %s.
GEOSwift # %s.
GEOSwift # %s.

Looks like that is coming from the swiftCallback function, defined at the top of GEOS.swift:
let swiftCallback : GEOSCallbackFunction = { args -> Void in
    if let string = String(validatingUTF8: args.assumingMemoryBound(to: CChar.self)) {
        print("GEOSwift # " + string + ".")
    }
}

Does this indicate any sort of error? If not, is it acceptable if I comment out the print statement?
Thanks!

Hi @ssokol, That appears to be debug code.
Could you please create a pull request wrapping it on a check for DEBUG?
#if DEBUG
    print("GEOSwift # " + string + ".")
#endif

Thanks!

Done. Thanks!

Merged https://github.com/GEOSwift/GEOSwift/pull/60
Thanks @ssokol!


Error when trying to build example for android

I followed the steps to setup the example project with yarn. Also made sure I have ndk installed for android but still get this error :
C/C++ debug|x86 : CMake Error at ...\react-native-skia-main\package\android\CMakeLists.txt:19 (add_library):
Cannot find source file:
C:/Users/.../Documents/Programming/react-native/react-native-skia-main/package/android/cpp/jsi/JsiHostObject.cpp
Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx

Hi @BubbleTrouble14! A much simpler approach to test out this library is to add it to a new React Native project using npm/yarn. If you want to look at any of our samples, please copy and test them out. Building like you do is for doing development of this library - is that what you're after?

I'm currently getting this issue:
Task :shopify_react-native-skia:configureCMakeRelWithDebInfo FAILED
w: Detected multiple Kotlin daemon sessions at build/kotlin/sessions

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':shopify_react-native-skia:configureCMakeRelWithDebInfo'.
C/C++<EMAIL_ADDRESS>release|armeabi-v7a : CMake Error at /.../node_modules/@shopify/react-native-skia/android/CMakeLists.txt:27 (add_library):
    Cannot find source file<EMAIL_ADDRESS>  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
    .hxx .in .txx

I installed Skia through yarn $yarn add @shopify/react-native-skia
and I get the above error when I run $./gradlew app:assembleRelease

Same error! Apparently that file location is incorrect. Not sure how to locate the file correct location.
INVALID PATH
-><EMAIL_ADDRESS>VALID PATH
-> -><EMAIL_ADDRESS>

nvm, I think I found the issue. Delete "@shopify/react-native-skia" and do "npm install". While installing the library it does the soft liking.
Issue is, if you rename the app or moved to other location, it tries to find those files from earlier location; thus error is "Cannot find source file".
So solution would be
Delete "@shopify/react-native-skia" and do "npm install"

Hi, thanks @kaustubh57 - thanks for clarifying the issue with sym links on installation - it is correct and it also makes it a bit inconvenient to move files if the symlinks aren't copied as well.


2024-05-04, 노마드 코더 클린코드 챌린지, 추천사, 1장 깨끗한 코드

https://github.com/jongfeel/BookReview/issues/745
https://github.com/jongfeel/BookReview/issues/746

https://nomadcoders.co/community/thread/9797


leaderLine position not correct after appending to div

Hi Sir
first of all thanks for creating this awesome library
I am using this library in one of my project
The case is in scrollable div the lines goes out of container because by default library adds the svg to body.

So i used document.getElementById('shapesWrapper').appendChild(document.querySelector('.leader-line')); to append the svg to my div i.e shapesWrapper which creates this output

Do you have any suggestion for this Sir

Hi @narendersaini32, thank you for the comment.
Sorry, my English is poor.
Do you mean that the issue was solved by moving the SVG to the scrollable <div> element?
What is your question?

first i am getting the overflow issue as you seen in the first image which is solved by appedning the svg to my div
but after that leaderline not correctly working you can see image2 they are not connecting

is you see the 2nd image orange one is the leaderline svg connection which is not connecting properly

I couldn't understand your words well...
But, does this help you?
https://jsfiddle.net/op2gnk0t/
https://github.com/anseki/leader-line/issues/54

yeah that will help thanks sir for your time

yeah sure can i get your personal contact details or something

What is contact details?
Please create new issue if you have another issue.


Fix a bug with refreshing the gutter UI.

I work on a package that adds a gutter to show "dot" next to a line (setting breakpoints). I noticed that sometimes the gutter UI would not update even if the code to decorate the marker successfully executed. When I debugged Atom, I realized that since the order in which gutters are added is undeterministic (unless you set the right priorities), updateCustomGutterDecorationState would sometimes return early.

Can you please add specs for this?

Added a spec as requested.

I left a couple of comments, but otherwise it looks good. :ok_hand:
Thanks @natthu for addressing this! :sparkles:

Thank you, @natthu! Great job here! :fireworks:


Watching IN_CLOSE_WRITE results in IN_CREATE to also be fired

Hi there; not 100% sure this is pyinotify-related, but i noticed that sometimes when i receive the IN_CLOSE_WRITE for a relatively large file, the file itself isn't finalized (i checked this by printing os.path.getsize on the event processing callback).
I added a sleep(1) there, but i'd be happier if i could get the confirmation that the file is really finished writing and available for processing. Any idea ?

Edit: i was listening to IN_CLOSE_WRITE, and noticed that IN_CREATE was also used (and my callback was considering the file finished)
            self.wm.add_watch(f, pyinotify.IN_CLOSE_WRITE, auto_add=True)

Is this expected ?

Hello, I noticed the same behavior. any workaround ?
Thx

Well, i just drop the call:
def on_event(self, event):
        if event.maskname == 'IN_CREATE':
            pass
        elif event.maskname == 'IN_CLOSE_WRITE':
            self.do_action(event.pathname)

Thanks for your quick answer.
in process_IN_CLOSE_WRITE method I droped the event IN_CREATE as you mentioned. but still receiving IN_CLOSE_WRITE multiple time during the action process (move in may example).
I am catching only IN_CLOSE_WRITE event
wm = pyinotify.WatchManager()
mask = (
    pyinotify.IN_CLOSE_WRITE
)

and if you have a look to the log, the file ...175645.JPG is called twice and lead to an empty file! this is weird ! I am not sure what is happening. any idea ?
2017-04-10T15:56:59.657821 - classify IN_CLOSE_WRITE /volume1/photo/Iphone/2017/IMG_20170410_175642.JPG
2017-04-10T15:56:59.774213 -    mv /volume1/photo/Iphone/2017/IMG_20170410_175642.JPG /media/photo/./2017/04/IMG_20170410_175642.JPG
2017-04-10T15:57:01.765019 - classify IN_CLOSE_WRITE /volume1/photo/Iphone/2017/IMG_20170410_175645.JPG
2017-04-10T15:57:01.780264 -    mv /volume1/photo/Iphone/2017/IMG_20170410_175645.JPG /media/photo/./2017/04/IMG_20170410_175645.JPG
2017-04-10T15:57:01.789337 - classify IN_CLOSE_WRITE /volume1/photo/Iphone/2017/IMG_20170410_175645.JPG
2017-04-10T15:57:01.820743 -    mv /volume1/photo/Iphone/2017/IMG_20170410_175645.JPG /media/photo/./2017/04/IMG_20170410_175645.JPG
2017-04-10T15:57:03.551751 - classify IN_CLOSE_WRITE /volume1/photo/Iphone/2017/IMG_20170410_175650.JPG
2017-04-10T15:57:03.568519 -    mv /volume1/photo/Iphone/2017/IMG_20170410_175650.JPG /media/photo/./2017/04/IMG_20170410_175650.JPG
2017-04-10T15:57:03.573922 - classify IN_CLOSE_WRITE /volume1/photo/Iphone/2017/IMG_20170410_175650.JPG
2017-04-10T15:57:03.592129 -    mv /volume1/photo/Iphone/2017/IMG_20170410_175650.JPG /media/photo/./2017/04/IMG_20170410_175650.JPG

Well, it's possible that the software that is actually writing the files is opening and closing them multiple times in a row. What happens if you print os.path.getsize or os.system('md5sum %s' % file) ? Is it changing the contents of the file between the 2 calls ?

If I do not move the files during the event, everything is going fine.
If I add the sleep everything is fine.
This is mean that the event is called during the file if written.
This is the log with the size, you can notice that the call is done upon file creation with 0 bytes !
I think that the IN_CLOSE_WRITE event is completly mapped on IN_CREATE event !
2017-04-10T16:20:24.649607 - classify IN_CLOSE_WRITE /volume1/photo/Iphone/2017/IMG_20170410_182017.JPG 489254
2017-04-10T16:20:24.726891 -    mv /volume1/photo/Iphone/2017/IMG_20170410_182017.JPG /media/photo/./2017/04/IMG_20170410_182017.JPG
2017-04-10T16:20:26.642540 - classify IN_CLOSE_WRITE /volume1/photo/Iphone/2017/IMG_20170410_182020.JPG 331209
2017-04-10T16:20:26.657923 -    mv /volume1/photo/Iphone/2017/IMG_20170410_182020.JPG /media/photo/./2017/04/IMG_20170410_182020.JPG
2017-04-10T16:20:26.665192 - classify IN_CLOSE_WRITE /volume1/photo/Iphone/2017/IMG_20170410_182020.JPG 0
2017-04-10T16:20:26.705520 -    mv /volume1/photo/Iphone/2017/IMG_20170410_182020.JPG /media/photo/./2017/04/IMG_20170410_182020.JPG
2017-04-10T16:20:35.209107 - classify IN_CLOSE_WRITE /volume1/photo/Iphone/2017/IMG_20170410_182024.JPG 357293
2017-04-10T16:20:35.227650 -    mv /volume1/photo/Iphone/2017/IMG_20170410_182024.JPG /media/photo/./2017/04/IMG_20170410_182024.JPG
2017-04-10T16:20:35.237309 - classify IN_CLOSE_WRITE /volume1/photo/Iphone/2017/IMG_20170410_182024.JPG 0
2017-04-10T16:20:35.260776 -    mv /volume1/photo/Iphone/2017/IMG_20170410_182024.JPG /media/photo/./2017/04/IMG_20170410_182024.JPG

I investigate a litle bit more the problem, and here is what is happening:
my do_event is calling :
os.system("mv %s %s" %(filename, tmpname)
this lead to another IN_CREATE_CLOSE event on the filename !
if I replace mv by cp, rm:
os.system("cp %s %s" %(filename, tmpname)
os.system("rm %s" %filename)

I have no problem !

it seems that the problem is related to DS_PHOTO somehow! I added a sleep(1) before processing the file to allow DS_PHOTO to see that the file has been uploaded !

If the double call always happens, you can also ignore the first one by adding the items to a list and popping it the second time it appears...


Update the go to context gif - command shows "done" rather than "+done"

NVIM v0.3.8
These commands work as expected:
Go to context: +gui shows me tasks with the tag +gui
Go to context:  clears the context and shows me all my tasks.
Go to context: +gui done, this is what I was trying to run as that's what the gif was showing.
Go to context: +gui +done, this is the command that succeeds for me.

Indeed, the gif is not up-to-date, I will change it. The correct way is +gui +done. Done is considered as a special tag.


[CEF 2171] Text at the beginning of the inline editor is sometimes truncated

On MAC, When working with multiple inline editors open in the same view, I got a truncation at the beginning of the inline editor. Here is the screenshot.

I am not able to consistently repro this. From what I can recall, I was able to repro this bug when working with a combination of Increase/Decrease the font size and opening multiple inline editors. I will update this issue, if I get this again.

@nethip Please re-open if you discover a reproducible recipe. Closing.


Make "nth" operation like "at" method from ES spec

Rename nth operation into at
Implement semantics like in the proposal: https://github.com/tc39/proposal-relative-indexing-method

Status is On Hold till proposal ins't on the Stage 4.

Another reference: https://v8.dev/features/at-method


Single Cell endRowIndex

Dear Tanaike, I use this script a lot in my work. thank you a ton!
Here's the issue I found:
Sample Code
function testApp() {
  var a1Notation = 'K1';
  var sheetId = 500;
  console.log(UtlApp.convA1NotationToGridRange(a1Notation, sheetId));
}

Output
{ sheetId: 500,
  startRowIndex: 0,
  endRowIndex: 1,
  startColumnIndex: 10,
  endColumnIndex: 1 }

Expected output
{ sheetId: 500,
  startRowIndex: 0,
  endRowIndex: 1,
  startColumnIndex: 10,
  endColumnIndex: 11 }

Steps to reproduce

Install the library
run sample code

Proposed solution
My guess is that it is a logical error in this line:
endColumnIndex: end ? end.col + 1 : 1,
I suggest to change it like this:
endColumnIndex: end ? end.col + 1 :start.col+1
If I did not understand the logics of grid creation, I'm sorry.
I also suggest to create a type for a grid like so for autocompletion purposes:
/**
 * @typedef {Object} RangeGrid
 * @property {Number} startRowIndex
 * @property {Number} endRowIndex
 * @property {Number} startColumnIndex
 * @property {Number} endColumnIndex
 */

 *
 * ...
 * @returns {RangeGrid} Gridrange.
 */
function convA1NotationToGridRange_(a1Notation, sheetName) {

Thank you for your support. And, I apologize for my late response. Now, I noticed your comment.
From your comment, I confirmed it. So, I updated this library as v1.0.1. Could you please confirm it?
Thank you so much.

Thank you for replying. Yes. This repository publishes the functions as both a library and the standalone functions in order to match the user's situation. I'm glad that those are useful for your situation. I would like to grow this repository by adding various functions.


ec(task-bundles): add rekor test task bundles

It is now possible to configure ec to accept one or more custom task bundles during a pipelinerun by specifying these bundles in our ec policy file. The addition of these task bundles to this repo will need to be followed by updates to EC policy used by Konflux.

/LGTM


✨  implement function to build a new user instance from the credential

tokens
Motivation
https://issues.jboss.org/browse/AEROGEAR-2548
Description
Add a new function to allow build a new User instance from the credential tokens. At the moment, the tokens are not verified.
Progress

[x] Implementation
[x] Unit test

Code looks good, what is the best way to test it in the example app?

@secondsun we haven't update the same app yet as the module is not ready.

@ziccardi mind reviewing again?


Upgrade fail

While running the tdupdater, it raise the following error:
SQL 1.0.8 1064 in INSERT INTO ps_configuration(name, value, date_add, date_upd) SELECT 'TB_MAIL_SUBJECT_TEMPLATE', '[{shop_name}] {subject}', NOW(), NOW() WHERE ( SELECT COUNT() FROM ps_configuration WHERE name = 'TB_MAIL_SUBJECT_TEMPLATE' ) = 0: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE ( SELECT COUNT() FROM ps_configuration WHERE name = 'TB_M' at line 3
The SQL should be written:
INSERT INTO ps_configuration(name, value, date_add, date_upd)
SELECT 'TB_MAIL_SUBJECT_TEMPLATE', '[{shop_name}] {subject}', NOW(), NOW()
FROM (select 1) t
WHERE ( SELECT COUNT(*) FROM ps_configuration WHERE name = 'TB_MAIL_SUBJECT_TEMPLATE' ) = 0

Thanks for the report. This module got replaced by module Core Updater, which does this task not with some fancy SQL, but by using class Configuration. This issue report was in mind when designing retrocompatibility in Core Updater, so it wasn't useless.

@Traumflug if it was replaced by something else - make it obvious in this repository's README. There are many articles online referring to tbupdater, and not core updater. People try to use tbupdater in vain. Me for instance :)


[Clinical Site] [Recruitment period] Add custom labels for recruitment period

According to the timeline of the recruitment period, add the following labels below recruitment period:

State: Recruitment period has not yet started - Label: Not yet recruiting;
State: Recruitment period in progress - Label: Recruiting;
State: Recruitment period has ended - Label: Active, not recruiting.

kinda confusing the last status. why just we don't show the state itself?

These label came from the business clarification document, apparently this is a common terminology for trials.
https://docs.google.com/document/d/1Fr9Vgye4-xSNplD-HFLyFW4bd7nNQHZgL3TnbUA4eSg/edit?disco=AAAAeuoOm2c


Create build script for wsl

It looks like a good translation of the build.bat system. A few error messages still reference the old batch file variables, so those will need to be corrected in any case.
However, the current build.bat system is very brittle and not something we plan to carry forward for very long. We're investigating something more robust around makefiles or msbuild. Especially given the whole BuildConfiguration.txt convention that you had to try and work with here. All of the gcc invocations themselves in our build.bat still need a lot of work as well.
We'd like to hold off on accepting other build systems until we get the above all straightened out and understood as we'll want to officially support and maintain any build process that lives in this repo.

I can maintain link until build system change. I know TinyClr is subject to change as it is earlier stage. Closing this PR can be a good point if TinyClr is easier.


Bump to v2.0.2

Pull Request Test Coverage Report for Build 306

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.522%

Totals

Change from base Build 304:
0.0%

Covered Lines:
77

Relevant Lines:
77

💛  - Coveralls


Add supported platforms pluggable function to public plans interceptor

Add supported platforms pluggable function to public plans interceptor

Coverage increased (+0.03%) to 87.456% when pulling 94097af91dc2c047e3ab8e05349be01e4123169e on public-plans-supported-plt into 0842d40a8375f7bb732aefc97c0234ddd4d7e8a3 on master.


Add cymcass

Website: https://www.cymcass.edu.hk/

@on9chai First stage of verification passed, official domain is facebook.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://m.facebook.com/ConfidentBrains/photos/a.365656994031208/919844601945775/

@on9chai Pull request merged. Thank you.


possibly changing Event code generation systems filter and trigger?

Hi So currently when the event system for a component is generated the trigger is only when that component is added and the filter checks if the entity in question has the component in question. dont you think it would be beneficial if the system also executed when the component can be removed?
A use case for event systems that also react when a component is removed is for example: I was making a button pressing game and when a pressable component was added the color of the view was white. now if the entity get the pressable component removed then the color of the view should react and change to black.
This is mostly beneficial for flag components because an issue i see with this idea is that for any other component that has a value and is not a flag component you can no longer guarantee when you are implementing the listener interface that the entity will have the component. a simple fix to this would be you would always have to write this if the listener method involved any component with values
using Entitas;

  public void OnButtonState(ButtonEntity entity, ButtonState Value)
    {
        if (entity.hasButtonState)
        {
            //do sth
        }
    }

as of right now you dont have to check if the entity has the component like i did above because the event system only executes if the entity has the component and you would only have to do that if the system reacted on removal of the component as well, but in terms of the flag components specifically i was thinking of something like this:
using Entitas;

   protected override Entitas.ICollector<ButtonEntity> GetTrigger(Entitas.IContext<ButtonEntity> context) {
        return Entitas.CollectorContextExtension.CreateCollector(
            context, Entitas.TriggerOnEventMatcherExtension.AddedOrRemoved(ButtonMatcher.Pressable)
        );
    }

    protected override bool Filter(ButtonEntity entity) {
        return (entity.isPressable==true||entity.isPressable==false) && entity.hasPressableListener;
    }

then you can say
 public void OnPressable(ButtonEntity entity)
    {
        if (entity.isPressable == true)
            Debug.Log("white button");
        else Debug.Log("grey button");
    }

Cheers let me know if my idea or statements were confusing or if its a flat out bad idea :)

Hi, in an earlier version of the event feature it was actually the way you described.
In order to avoid checks like if (entity.isPressable == true) I changed the api to
OnPressable and OnPressableRemoved
You can It's possible to listen for removed events already
Example:
[App, Unique, Event(EventTarget.Any), Event(EventTarget.Any, EventType.Removed)]
public sealed class AsyncLoadingComponent : IComponent {
}

will result in
public void OnAnyAsyncLoading(AppEntity entity) {
    gameObject.SetActive(true);
}

public void OnAnyAsyncLoadingRemoved(AppEntity entity) {
    gameObject.SetActive(false);
}

ahhhhhhhhh I forgot about that the default value on the eventType param was eventType.Added okay i see glad to have that cleared up. As a followup question i am not sure if this was already explained somewhere or described in some documentation but I noticed that there is 3rd parameter 'priority' which defaults to 0. I have not fiddled with the that param what are the effects of it?


Multi-tier highlighting for tutorials

Currently, it dims the rest but the specified component. Could also give "positive" highlighting for a component inside the non-dimmed area.

Moved to a different project


Add composer.json.

Add composer.json file so it's easy to use the library with composer tool.

+1

+1

+1

+1

It's safe to say that this package is dead and unmaintained.


Update to Bootlint v0.10.0

/CC @cvrebert @zacechola

https://github.com/zacechola/grunt-bootlint/releases/tag/v0.7.0
Will be on npm shortly.

Thanks!


[fix] Update failing benchmarks

Summary of changes
Changes introduced in this pull request:
Update failing benchmarks of following pallets

hasher
mt
verifier
linkable-tree
mixer

Reference issue to close (if applicable)

Part of #227

Is this ready to merge?


Doesn't recognize required line in Page Contructor for UWP

Hi,
I'm trying the version available from Nuget as I just realized that the version I've been using from GitHub work fairly well with continuous scanning but only when the configuration is in debug mode. Once I got to release mode and try it either on a Windows Phone or on my laptop, it bombs out quite badly.
Anyway, reading your documentation, it requires to add this to the Page's constructor
ZXing.Net.Mobile.Forms.WindowsUniversal.ZXingScannerViewRenderer.Init();
But it doesn't like it. It doesn't find the required command.
When I check the namespace, this is what it has:
ZXing.Net.Mobile.ZXing_Net_Mobile_WindowsUniversal_XamlTypeInfo
Any ideas?
Thanks.

I'm really not sure what's happening here.   Try the 2.1.0 prerelease version or wait for the 2.1.0 stable version to be released (or better yet, try the code in master).  We can reopen it if it's still an issue after that.


Fix parallel compilation when saving to object file

Moved this PR to gitlab (https://gitlab.com/StanfordLegion/legion/merge_requests/141), to clean up the diff.


Add more informations.md

I have add some more information on this topic. i hope it will helps to understand this topic very well even for beginners.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[x ] None of my changes are plagiarized from another source without proper attribution.
[x ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Reason: Since your PR was create, the master branch content has updated making some of your changes unnecessary.  Please re-sync your fork so you are looking at the latest version of master and then create a new PR if you find any changes warranted.
Thank you and happy coding.


Question/Wiki Addition

What is your question?
How would I make a custom achievement?

either
A. Use source (Achievements.hx and PlayState.hx should be the files you need to edit)
B. Create a fake achievement in lua

how would I do b


fixing a problem with the Z level that affects proxywidgets too

Hi,
am having a problem with a CombBox hidden behind other NodeGraphiObjects.
I realized that in general the order in Z might be annoying in some cases because is related to the creation order.
This PR proposes a solution to this problem.
NOTE: if you prefer, the increase in Zvalue can be done in hoverEnterEvent instead of mousePressEvent. I would personally prefer hoverEnterEvent.

Hi Davide,
Thanks for this fix. I never tried to use some combo-boxes.
I would solve this problem little bit differently.

Make an enum in Node.hpp file

enum NodeZLevel
{
    DEFAULT_Z_LEVEL = 1,   // we need to check appropriate values here
    HOVERED_Z_LEVEL = 100
};

In hoverEnterEvent set node's z-level dynamically to HOVERED_Z_LEVEL
In hoverLeaveEvent set it back to DEFAULT_Z_LEVEL

Benefits:

No global static variables
No constantly growing z-levels

What do you think?
Best,
Dmitry

this is the very first thing I tried, but it didn't work.
When you click the combobox, hoverLeaveEvent is called.
I also tried to tinker with the setZvalue of _proxywidget, but without success...

Ok, I did not know that. Maybe we should look into Qt's example?
http://doc.qt.io/qt-5/qtwidgets-graphicsview-diagramscene-example.html
Please look at the function implementation bringToFront()

Alright, I changed the PR and, code wise, it is aesthetically more pleasant ;)
Take a look

shall we move this one forward? ;)

Yes, sorry, could not encompass everything in a couple of evening hours after work :-)
There is on issue with the current implementation: by touching all the Nodes in the cycle we would cause a massive repainting, basically we would repaint the whole scene. It is not a problem for 10 nodes, but who knows, what if we have 1000? I suppose we could avoid wasting of computational resources and use the trick proposed in the Qt docs (http://doc.qt.io/qt-5/qtwidgets-graphicsview-diagramscene-example.html)
Thanks
Dmitry

I pushed the changes you suggested (more or less...) I honestly don't think it need to be more complicated than that.

Thanks, now I am happy ;)


Issues with mod_wsgi?

Hi,
I keep getting a 'module' object has no attribute 'core' when using with mod_wsgi.  Please see http://stackoverflow.com/questions/7766400/pandas-django-mod-wsgi-virtualenv for the full error description.
Evan

What error do you get trying to do:
import pandas._tseries
import pandas._sparse

This sort of error happens when there was an import error suppressed somewhere so that pandas/init.py didn't fully execute.

Ok, that produced a slightly different error.  Looks like this line 'module compiled against API version 6 but this version of numpy is 4' is the problem but not sure what it means...  Both numpy and pandas installed using pip inside the virtual environment as in "pip install numpy; pip install pandas"
[Mon Oct 24 15:05:35 2011] [info] Initial (No.1) HTTPS request received for child 0 (server openportfolio-staging.XX.com:443)
[Mon Oct 24 15:05:35 2011] [info] mod_wsgi (pid=12433): Create interpreter 'openportfolio-staging'.
[Mon Oct 24 15:05:35 2011] [info] [client XX.XX.XX.XX] mod_wsgi (pid=12433, process='openportfolio-staging', application='openportfolio-staging'): Loading WSGI script '/usr/local/web/django/www/staging/openportfolio/apache/staging.wsgi'.
[Mon Oct 24 15:05:35 2011] [error] RuntimeError: module compiled against API version 6 but this version of numpy is 4
[Mon Oct 24 15:05:35 2011] [error] [client XX.XX.XX.XX] mod_wsgi (pid=12433): Target WSGI script '/usr/local/web/django/www/staging/openportfolio/apache/staging.wsgi' cannot be loaded as Python module.
[Mon Oct 24 15:05:35 2011] [error] [client XX.XX.XX.XX] mod_wsgi (pid=12433): Exception occurred processing WSGI script '/usr/local/web/django/www/staging/openportfolio/apache/staging.wsgi'.
 You almost certainly won't get optimized linear algebra out of the box-- so if you're using np.dot anywhere or anything in numpy.linalg (or any libraries that do) you should take a closer look there.

So it turns out this was a Python path order issue.  By running sys.path.reverse() in my wsgi config file, the code now runs.
I double checked that numpy and pandas had been built against the right version - which they had (makes sense since it all worked outside mod_wsgi).  However, due to the order of Python path, the built in OS X numpy library must have been imported first causing the issue.
Thanks for your help.

(and thanks for the info re: efficiency - I only build from source because I am trying to create an easy to install django app and a pip requirements file seems the easiest way to achieve this).

Cool, glad you got it working =)


Allow the user to override lispyville themes

Currently the list of key themes for lispyville is hardcoded in the package config. The user can add more, but there is no way to unload a theme once it has been loaded.This simple change lets users set their own keys themes by setting lispyville-key-theme in their private config.

Thanks!


Survey Stuck On Loading Screen

Just trying to submit a Survey and after clicking "Submit" a "Loading" screen just sits there.  Screenshot attached.

This is now fixed.


Selenium grid extras  1.12.15 couldn't download the geckodriver automatically

It can create a folder C:\tmp\webdriver\geckodriver, but failed to download the geckodriver.
Chrome and IE are ok.

After change the geckodriver bit to 32, it can automatically download


partition resize in tinkerbell action doesn't work

What happened:
I'm creating a EKS anywhere cluster for bare metal
I try to add use a sequence of actions right after the action "stream-image":
- name: trivial-cmds0
    image: public.ecr.aws/h1a5s9h8/alpine:latest
    command: ["umount", "-f", "/"]
    timeout: 120
- name: trivial-cmds1
    image: public.ecr.aws/h1a5s9h8/alpine:latest
    command: ["printf", "'Yes\n280GB\nYes'", "|", "parted", "/dev/sda", "---pretend-input-tty", "resizepart", "2"]
    timeout: 120
- name: trivial-cmds2
    image: public.ecr.aws/h1a5s9h8/alpine:latest
    command: ["mount", "-t", "ext4", "/dev/sda2", "/"]
    timeout: 120

However, after the cluster creation command completes, I run command "fdisk -l" on the node, and find resizepart doesn't take effect.
Am I missing something?
What you expected to happen:  I expect the cluster creation will succeeds.
How to reproduce it (as minimally and precisely as possible): mentioned above
Anything else we need to know?:
Environment:

EKS Anywhere Release:
EKS Distro Release:

In the boots logs, we can see this:
{"level":"info","ts":1707357729.5200799,"caller":"syslog/receiver.go:113","msg":"host=<IP_ADDRESS> facility=daemon severity=INFO app-name=1a5c973d03fc procid=2969 msg=\"mount: /: /dev/sda2 already mounted on /.\\r\\n\"","service":"github.com/tinkerbell/boots","pkg":"syslog"}
{"level":"info","ts":1707357729.5201583,"caller":"syslog/receiver.go:113","msg":"host=<IP_ADDRESS> facility=daemon severity=INFO app-name=2fa9db43cd13 procid=2969 msg=\"mount: /: /dev/sda2 already mounted on /.\\n\"","service":"github.com/tinkerbell/boots","pkg":"syslog"}
{"level":"info","ts":1707357729.5210629,"caller":"syslog/receiver.go:113","msg":"host=<IP_ADDRESS> facility=daemon severity=INFO app-name=1a5c973d03fc procid=2969 msg=\"\\x1b[31mFATA\\x1b[0m[0000] Error running [/bin/sh [-c mount -t ext4 /dev/sda2 /]] [exit status 32] \\r\\n\"","service":"github.com/tinkerbell/boots","pkg":"syslog"}
{"level":"info","ts":1707357729.5211864,"caller":"syslog/receiver.go:113","msg":"host=<IP_ADDRESS> facility=daemon severity=INFO app-name=2fa9db43cd13 procid=2969 msg=\"\\x1b[31mFATA\\x1b[0m[0000] Error running [/bin/sh [-c mount -t ext4 /dev/sda2 /]] [exit status 32] \\n\"","service":"github.com/tinkerbell/boots","pkg":"syslog"}

Look like umount doesn't take effect.

I try to collect the commands in a script and integrated into an alpine image like this:
#!/bin/bash
set -x
umount -f /
printf 'Yes\n280GB\nYes' | parted /dev/sda ---pretend-input-tty resizepart 2
mount -t ext4 /dev/sda2 /
printf "12345" >& /gyx12345.txt
exit 0

It doesn't work either.

The magic seems in the last action: "reboot"


Crash when placing ships helm.

My server crashed, as well with the game of the player placing the block, right after placing a ships helm.
crash log ; https://pastebin.com/C4XgNDmT

This is the crashlog of the client who placed the helm. https://pastebin.com/BRDyn03Y


Metadata as separate package?

@sbooth
Hi Stephen,
Thank you for the SFBAudioEngine repo!
We previously used AudioKit for our production app and needed a reliable metadata reader/writer, which led us to your library. After extensive testing in our iOS app, I can confidently say that SFBAudioEngine Metadata reader/writer outperforms any other libraries we’ve tried. Some caused crashes, while others failed to read or write metadata properly. Your repo handles everything exceptionally well and remains stable.
I have a question: could SFBAudioEngine be split into separate packages which can work separately? For example, the audio format conversion functionality seems like an additional feature. Starting from that, it's possible to create a separate package for the metadata reading/writing module also?
Since we only need the metadata functionality, importing the entire engine brings in a lot of unused code and libraries. I understand this might not have been part of your initial design, but I’m curious if this split could be feasible. It might also help isolate potential issues in the future...
Additionally, I noticed that some links in the readme are broken: https://github.com/sbooth/SFBAudioEngine?tab=readme-ov-file#properties-and-metadata.
P.S. I would love to see a fully Swift codebase for the engine (excluding the C++ bindings). I understand the choice to use ObjC, but in these modern times, Swift represents the future, and we are using it every day. While I appreciate the use of “older” languages, we should focus on moving into the future.
That said, I’m truly grateful for the work you’ve done! I actually really like ObjC, it’s where I began my development journey.

I'm happy to hear that the metadata portion of SFBAudioEngine is working well for you. I think most of the credit should go to TagLib, though!
I have thought about splitting the metadata handling into a separate package. As things stand right now the only shared code between the player and metadata is for Shorten since that is a format not supported by TagLib. I'm interested in adding Shorten support to TagLib but that isn't a project I've started. If that were to happen I would seriously consider splitting the package into two (or three, as you suggest) separate packages.
A full Swift codebase would be nice but isn't possible with the current state of Swift-C++ interoperability. As an example, the MAC decoder requires IO methods that inherit an abstract C++ interface which isn't possible to write in Swift. So some level of Obj-C++ glue is required.

I have thought about splitting the metadata handling into a separate package. As things stand right now the only shared code between the player and metadata is for Shorten since that is a format not supported by TagLib. I'm interested in adding Shorten support to TagLib but that isn't a project I've started. If that were to happen I would seriously consider splitting the package into two (or three, as you suggest) separate packages.

Sounds great! I’ll stay tuned for updates on this. Thanks!

A full Swift codebase would be nice but isn't possible with the current state of Swift-C++ interoperability. As an example, the MAC decoder requires IO methods that inherit an abstract C++ interface which isn't possible to write in Swift. So some level of Obj-C++ glue is required.

Yeah, excluding the C++ bindings, but I was referring to all the other engine classes. From what I see, it’s mostly in Objective-C. What I’d really love is a modern, lightweight engine that can handle most media formats and is written in Swift. 👍🏻

.... for Shorten since that is a format not supported by TagLib. I'm interested in adding Shorten support to TagLib but that isn't a project I've started. If that were to happen I would seriously consider splitting the package into two (or three, as you suggest) separate packages.

Hey @sbooth, perhaps it could be split without that specific format? Maybe create another package just for it? To be honest, it's a super rare format, and most people don't even know it exists. :D

I don't plan on removing Shorten support. I'm also not sure how much of a benefit splitting the packages would actually provide.

I don't plan on removing Shorten support. I'm also not sure how much of a benefit splitting the packages would actually provide.

Ah, I see, I’m not suggesting removing it. I meant that Shorten is a relatively rare format, and it would make sense to treat it as such.
Here’s our situation: we’re using AudioKit for our production app, and we only use SFBAudioEngine for reading/writing metadata tags. However, using the entire engine repo for this purpose is quite overwhelming.
That’s why I believe splitting SFBAudioEngine into a separate repository like for example SFBAudioTags could be really beneficial. It would allow us to only include the metadata reading/writing component, making it much lighter and more modular for other people, which could add more like testers/reporters/contributors to that repo.
This separation would also streamline the process of fixing or updating components like TagLib independently(updates/fixes), which could speed up the development cycle. For example, any bug with reading tags, we could address faster/separately and  without being tied up with the entire engine code.
Moreover, isolating the metadata functionality would make the whole project easier to maintain, test, and update. We would be able to contribute more effectively as well, which is important to us. Users have reported issues with certain tags not being read, and our goal is to resolve this as quickly as possible. Currently, these issues are more difficult to address because they’re locked within the engine code, which complicates the process of fixing, testing, and updating.
By creating a separate repo for metadata handling, you would not only improve the flexibility of the project but also create a more modular setup that could attract more contributions from the community, particularly from us, as we’re highly motivated to contribute fixes.

Shorten support has been merged into TagLib so this is closer to becoming a reality.


NullPointerException when changelog.append.enabled=true but target file doesn't exist

Task List

[x] Steps to reproduce provided
[x] Stacktrace (if present) provided
[ ] Example that reproduces the problem (link to git repository is ideal)
[x] Full description of the issue provided (see below)

Steps to Reproduce

set changelog.append.enabled to true
do not have a CHANGELOG.md file in the project root
run mvn jreleaser:changelog

Expected Behaviour
Not sure what should happen:

either a new CHANGELOG.md file is created with the changelog content
or an error is thrown
but definitely not a NullPointerException !

Actual Behaviour
Maven plugin crashes.
Environment Information

Operating System: MacOS
JReleaser Version: 1.4.0
JDK Version: 11

Please paste stacktraces from [out|build|target]/jreleaser/trace.log.
trace.log

A new CHANGELOG.md should be created as a result.

FWIW I think this bug was found and fixed right after 1.4.0 during the Sonar cleanup. Must verify this claim.

Fixed with https://github.com/jreleaser/jreleaser/commit/dc3054cb25327b84c7c86a8f2fd3621b08bef70d