Use asv for scikit-bio

We are currently working on setting up asv to handle our benchmark testing for scikit-bio. While exploring the features we would like to get working, we're thinking of using asv the following ways:

Automatic benchmarking for pull requests, a la Travis. The plan is to use Github Webhooks to trigger benchmarking on our dedicated machine (there would be a daemon with a job queue). The daemon would run the benchmarks and push to a new Github page for each PR. These would be automatically cleaned up after a time period or when the PR is closed.

Include benchmarking tests inline in our repo, and update them exactly as we do with unit tests. We would add an if __name__ == '__main__' to each of these benchmarking files, which would import the timeit functionality from asv and run the benchmarks in that file. This would allow developers to run benchmarks for the unit they are modifying before and after their modification, as a smoke test before submitting a PR. These "unit" benchmarking tests would then be aliased and imported by the benchmarking file that actually gets run by asv. The goal of this would be to avoid explicitly checking the __version__ of our repo in our benchmarking file.

Does anyone here have experience implementing any of this with asv? Any suggestions as we set out? Of course we're happy to push anything useful we get working upstream.

On (2): You may be interested in looking at how we do it in Scipy: https://github.com/scipy/scipy/tree/master/benchmarks
In particular, the solution is to put the benchmarks into the same repository as the project itself, but, effectively in a completely separate Python package. Running benchmarks against the current working tree version of the package to be benchmarkerd can be done in a fairly straightforward way by making use of asv's --python=same option.
Note that it is not very useful to put the benchmarks inside the package itself, because you want to keep the set of benchmarks fixed when running them against old versions of the package. It however is possible to keep both in the same repository.

That's very helpful, thanks! We'll definitely look at scipy's implementation.
For the last point, our thinking was that if you had something like a skbio.bench defined for each git revision, inside master's benchmarking.py you can simply do:
#benchmarking.py
import skbio.bench

def time_thing():
    skbio.bench.thing()

Then each revision would have it's own implementation of thing, so revision X might be:
# bench.py
def thing():
    skbio.some_lib.thing()

but revision Y is maybe:
# bench.py
def thing():
    skbio.some_other_lib.thing()

The idea being that master does not need to know anything about compatibility with previous commits, given the constraint that benchmarking names need to remain the same.

But there might be some issues here we're not seeing.

The technical constraint here is that the benchmark names and attributes (including parameters for parameterized benchmarks) must be fixed by your "benchmarking.py", and should not depend on what is inside "skbio.bench" that varies depending on the currently active version.
Less technical thoughts on this: That approach adds more complexity, and there is additional hassle in ensuring that the benchmark code in the different versions actually does the same thing, so that results remain comparable. This might be more transparent to do with explicit version checks. It seems it will also not be possible to add benchmarks a posteriori, to see how performance of some feature has evolved previously, and whether past changes introduced performance regressions.

Just a bit of history to add to what @pv said: An earlier sketch of asv worked more like you described, but it ultimately turned out to be hard to manage because you have to basically retroactively stick commits containing the benchmarks into old history (and all of the issues that rewriting git history entails).  Perhaps with a new project this is tracktable (even then, you'd probably want to add benchmarks over time and still run them on past project history).

All valid points, glad we asked ahead of time. Thanks for your input!


Two issue about libary

I faced 2 issues

Can't scroll to first message "模拟数据第 1"

When clicking into search input, the result layout will display instead of input chat. But the result layout is hidden below the keyboard.

Please help me resolve it to the

expected result
Thanks

@HuuNguyen312
For the first question: Since you have added Search ui, you should take the new height of Search ui into consideration when calculating the sliding distance.
For the second question: the framework needs to bind an EditText as an input source, and the unbound input source pulls up the input method framework and does not automatically process it, and needs to be extended.

@HuuNguyen312 The solution to the second problem: It may be possible to extend the framework capabilities, such as supporting the binding of multiple input source controls. Currently under evaluation. Or you can remove the original input source control from the original ViewGroup and re-add it to the new ViewGroup.

@HuuNguyen312
The v1.3.10 version was released today, you can upgrade the version to solve the second problem.

@HuuNguyen312
The v1.3.10 version was released today, you can upgrade the version to solve the second problem.

@YummyLau Thanks for your support.
The second problem is solved by the addSecondaryInputView method
The first problem also occurs in your sample. I can't scroll to the first message
Please view the video: https://streamable.com/l1i9hp

@HuuNguyen312
I seemed to understand what you meant wrong before, I thought SearchUI was blocking part of your layout. In fact, the behavior shown by the Demo is normal, because the content of the list is laid out to a height by the frame, which refers to the interaction of WeChat. This is to smooth the display of the transition panel. You can freely control it by using api addContentScrollMeasurer
       .addContentScrollMeasurer(new ContentScrollMeasurer() {
                        @Override
                        public int getScrollDistance(int defaultDistance) {
                            return xxxx;  //Dynamic calculation
                        }

                        @Override
                        public int getScrollViewId() {
                            return R.id.recycler_view;
                        }
                    })

@YummyLau
I tried the method you suggested
I can only scroll to the first message when return getScrollDistance = 0.
Unfortunately, I can't scroll to the last message
Please view the video: https://streamable.com/oa3xjx
Please help me resolve it.
Thanks

@HuuNguyen312 HU
Because the height of the list in the content area has not changed, adjusting the return value of getScrollDistance only determines that the starting point of the top and bottom layout of the layout is different.
If you need the height of the list to change dynamically（it likes LienarLayout-weight), you may sacrifice the fluency of switching. You can turn off the sliding with contentScrollOutsideEnable(false), but it is generally not recommended.
Note: The library refers to a large number of IM apps. Generally, when the panel is pulled up, the sliding behavior should close the panel.
Hope it helps you.

@HuuNguyen312
Last night, I discussed with your friends on WeChat about the problem you said.
In fact, according to the trend of android11, the official processing of window changes is to implement transition animation for the translation business layout, so it is not recommended to dynamically change the height of the list when a panel appears. So sliding the list when the panel is displayed is a bad interaction. When the panel is displayed, sliding should give priority to the panel. This is just our recommendation.


License?

Hi,
Could you please add a License file to your project?  I'd like to use it but can't find any license information.
Thanks

This was addressed in e7f40679c7c7c41364a6209b1cedc769e73d7e62.


graph/traverse: better support for depth-related behaviour

What are you trying to do?
BreadthFirst and DepthFirst have got limited support for handling depth-related behaviour e.g.

Limiting scope of search based on depth
Reporting depth at which nodes are encountered

What did you try?
n/a
How does Gonum not allow you to achieve your goal?
It's possible to capture the depth at which nodes are encountered in BreadthFirst using the 'until' handler in a hacky way (record node and depth and return false).
But other than this there is no support for depth-related behaviour in the package.
What version of Go and Gonum are you using?
go 1.11.4
gonum 87d00cbe34f693711bb5689c21916c29971a08d9 (August 2019)
Is this feature absent from the current master?
Yes.
Are you able to help contribute the feature?
I guess there are multiple ways forward with this. My suggestion would be:
Depth is already tracked in BreadthFirst. A mechanism for this would need to be added to DepthFirst. Probably by replacing the NodeStack with a stack of struct{node Node, depth int} or equivalent functionality.
Then access and control over this can be added by

passing depth to the Visit handler to enable depth reporting
passing depth to the Traverse handler to enable depth control
passing depth to the DepthFirst until handler as with the BreadthFirst version, for consistency

I'd be happy to implement this if the changes would not be considered too invasive to the API. I see an update to these handlers to as a minor annoyance as opposed to anything deal breaking - it's a simple fix that doesn't require any change in behaviour (add ignored parameter?)

I need to think about these. It's unclear to me why you want a depth marker for depth first.
The API here is, by design, very spartan. The approach that you can use to obtain depth in depth first are the intended approach. While a completely generic pair of routines could be provided it would be an ugly mess and not used for most use cases. Note that these function are very small, and can easily be copied and remolded into something more precisely matching the user's needs if they don't fit as is.

In terms of the final discovered set, the algorithms are the same and differ only in discovery order. Because of the similarity I would expect them to have identical interfaces. I haven't got a specific use case off of the top of my head where a depth limited BFS wouldn't have served the purpose, although this issue was born from solving a problem where naturally I would have used a depth-limited DFS if it had been available as it was semantically a better match.

this issue was born from solving a problem where naturally I would have used a depth-limited DFS if it had been available as it was semantically a better match.

This is the key. Can you describe this use case?


NIFI-12441 Added No Tracking listing strategy to ListS3

Summary
NIFI-12441
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[X] Build completed using mvn clean install -P contrib-check

[X] JDK 21

Licensing

[X] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[X] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[X] Documentation formatting appears as expected in rendered files

@juldrixx There appears to be a test failure in the ci-workflow for the new listing strategy:
org.apache.nifi.processors.aws.s3.TestListS3.testNoTrackingList -- Time elapsed: 0.020 s <<< FAILURE

@juldrixx There appears to be a test failure in the ci-workflow for the new listing strategy:
org.apache.nifi.processors.aws.s3.TestListS3.testNoTrackingList -- Time elapsed: 0.020 s <<< FAILURE

Sorry, I didn't see that the unit test results had changed when I rebased. It should be fine now.


Update Sigma Translator for DFE to Use Kusto Backend

Updated Sigma translator for DFE to use the Kusto backend from the following repo: https://github.com/AttackIQ/pySigma-backend-kusto.
How to test:
from common import sigma_translation
sigma_translation(
    product = "dfe",
    sigma_rules=["""
        title: Mimikatz CommandLine
        status: test
        logsource:
            category: process_creation
            product: windows
        detection:
            sel:
                CommandLine|contains: mimikatz.exe
            condition: sel
        """
        ]
    )

Output:
{'queries': [{'query': 'DeviceProcessEvents\n| where ProcessCommandLine contains "mimikatz.exe"',
   'id': None,
   'title': 'Mimikatz CommandLine',
   'description': None}]}

@rc-csmith Happy to sync on this. The new backend doesn't seem to support merging multiple queries without omitting the table (e.g., DeviceProcessEvents) from the final query, which is why I had to ignore types to pass mypy tests.


How to implement AuthorizationInterceptor?

I have an authorization's scenario as below:

The NavigationController have LoginViewController as rootViewController.
In the LoginViewController, the user taps on the SignUp button, the system navigates to SignUpViewController.
In the SignUpViewController, the user fills their's information, then he taps on the register button, if success, the system navigates to HomeViewController.

Expectation:
HomeViewController should be pushed/presented or setAsRoot of the window after authorized.
@ekazaev  Could you provide an example of this?

You do not need any interceptor here. You have a direct action. User taps the button you call the configuration to present SignUpViewController. When user enters details and if it succeeds - you call the configuration to present HomeViewController.

In my case, the AuthFlow as above is called everywhere if authState is unauthorized, HomeViewController is only one of it.

let router = DefaultRouter()

class LoginViewController {

   @IBAction func signupTapped() {

        let screenConfiguration = StepAssembly(finder: ClassFinder<SignUpViewController, Any?>(options: .currentVisibleOnly),
                        factory: XibFactory())
                        .using(UINavigationController.push())
                        .from(SwitchAssembly()
                                // If login view controller present on the screen
                                .addCase(expecting: ClassFinder<LoginViewController,Any?>(options: .currentVisibleOnly))
                                .assemble(default: {
                                    // otherwise present modally
                                    return ContainerStepAssembly(finder: NilFinder(), factory: NavigationControllerFactory())
                                            .using(GeneralAction.presentModally())
                                            .from(GeneralStep.current())
                                            .assemble()
                                }))
                        .assemble()

        try navigate(to: screenConfiguration, with: nil, animated: true, completion: { result in
            // do whatever you need like send a RxSwift Signal or do nothing
        })
    }
}

class SignUpViewController {

   @IBAction func signupTapped() {
    guard userInfoIsValid() else {
        showError()
        return
    }

    let screenConfiguration = StepAssembly(
                finder: ClassFinder<SignUpViewController, Any?>(options: .current, startingPoint: .root),
                factory: XibFactory())
                .using(GeneralAction.replaceRoot())
                .from(GeneralStep.root())
                .assemble()

    try navigate(to: screenConfiguration, with: nil, animated: true, completion: { result in
        // do whatever you need like send a RxSwiftSignal or do nothing
    })
}

Something like this. Of course it has no sense to keep config in the view controllers, but if we simplify it the code will be something like this.

Also, you can reuse LoginInterceptor for the cases where navigation is not involved at all.
For example, lets assume you have a favourite button on the product(or whatever) screen. Only authorised user can add a product to his favourites. If user is not authorised, you have to offer him to login or signup. In this case no navigation process involved. But you can reuse LoginInterceptor without using a router:
@IBAction favoriteItemTapped() {
    LoginInterceptor<Void>().execute(completion: { result in
        guard result.isSuccessfull else {
            return
        }
        favoritesDataManager.addToFavorites(item: currentItedId)
    })
}

Of course it would be better to wrap it in to something and reuse the logic written in LoginInterceptor not to expose it to the module.

Great! Thank you so much. 😃


run the model but get the error, help please!

Hello! Thanks for your sharing, I get a TyoeError when I run the model, and I do not know how to solve it.
On ubuntu14.04, python3.5.2
Detail as following:
Traceback (most recent call last):
File "image_rec.py", line 357, in
main()
File "image_rec.py", line 204, in main
MODEL.load_model(dictfn)
File "/home/naver/line-brain/lixun/cnn-based/image_rec/algo/autoencoders/AE.py", line 137, in load_model
self.encoder = load_model(encoder_filename)
File "/usr/local/lib/python3.5/dist-packages/keras/models.py", line 240, in load_model
with h5py.File(filepath, mode='r') as f:
File "/usr/local/lib/python3.5/dist-packages/h5py/_hl/files.py", line 271, in init
fid = make_fid(name, mode, userblock_size, fapl, swmr=swmr)
File "/usr/local/lib/python3.5/dist-packages/h5py/_hl/files.py", line 101, in make_fid
fid = h5f.open(name, flags, fapl=fapl)
File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper (/tmp/pip-huypgcah-build/h5py/_objects.c:2840)
File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper (/tmp/pip-huypgcah-build/h5py/_objects.c:2798)
File "h5py/h5f.pyx", line 78, in h5py.h5f.open (/tmp/pip-huypgcah-build/h5py/h5f.c:2117)
OSError: Unable to open file (Unable to open file: name = 'db/models/convae_encoder.h5', errno = 2, error message = 'no such file or directory', flags = 0, o_flags = 0)
Exception ignored in: <bound method BaseSession.del of <tensorflow.python.client.session.Session object at 0x7f8d737435f8>>
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 595, in del
TypeError: 'NoneType' object is not callable

Hi there,
It seems like the encoder is named "ConvAE_encoder.h5" rather than "convAE_encoder.h5". Does changing the name solve the problem? I will have to make these changes tonight and update the repo. Thanks for helping me catch this. Feel free to update me with any other troubles you experience.
Sent from my iPhone

On Sep 7, 2017, at 3:07 AM, kshuc152<EMAIL_ADDRESS>wrote:
Hello! Thanks for your sharing, I get a TyoeError when I run the model, and I do not know how to solve it.
On ubuntu14.04, python3.5.2
Detail as following:
Traceback (most recent call last):
File "image_rec.py", line 357, in
main()
File "image_rec.py", line 204, in main
MODEL.load_model(dictfn)
File "/home/naver/line-brain/lixun/cnn-based/image_rec/algo/autoencoders/AE.py", line 137, in load_model
self.encoder = load_model(encoder_filename)
File "/usr/local/lib/python3.5/dist-packages/keras/models.py", line 240, in load_model
with h5py.File(filepath, mode='r') as f:
File "/usr/local/lib/python3.5/dist-packages/h5py/_hl/files.py", line 271, in init
fid = make_fid(name, mode, userblock_size, fapl, swmr=swmr)
File "/usr/local/lib/python3.5/dist-packages/h5py/_hl/files.py", line 101, in make_fid
fid = h5f.open(name, flags, fapl=fapl)
File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper (/tmp/pip-huypgcah-build/h5py/_objects.c:2840)
File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper (/tmp/pip-huypgcah-build/h5py/_objects.c:2798)
File "h5py/h5f.pyx", line 78, in h5py.h5f.open (/tmp/pip-huypgcah-build/h5py/h5f.c:2117)
OSError: Unable to open file (Unable to open file: name = 'db/models/convae_encoder.h5', errno = 2, error message = 'no such file or directory', flags = 0, o_flags = 0)
Exception ignored in: <bound method BaseSession.del of <tensorflow.python.client.session.Session object at 0x7f8d737435f8>>
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 595, in del
TypeError: 'NoneType' object is not callable
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I have now made the fix of the encoder model filename, and detailed the README.md file to outline the libraries needed to run the code. It should be working fine now (at least it has on my computer). The code should be able to as is with a "python image_rec.py" command. I will close this issue for now, but please let me know if you can't get it running!


[BUG] Snowflake custom_queries returns throws an error when Arrow resultset is returned

Agent Environment
agent version: Agent 7.46.0 - Commit: b2f5e36 - Serialization version: v5.0.85 - Go version: go1.19.10
datadog-agent status:
    snowflake (4.5.2)
    -----------------
      Instance ID: snowflake:9cbc4ed3d2d7c37a [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/snowflake.d/conf.yaml
      Total Runs: 16
      Metric Samples: Last Run: 1,510, Total: 25,315
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 16
      Average Execution Time : 22.888s
      Last Execution Date : 2023-08-25 02:21:24 UTC<PHONE_NUMBER>000)
      Last Successful Execution Date : 2023-08-25 02:21:24 UTC<PHONE_NUMBER>000)
      metadata:
        version.major: 7
        version.minor: 29
        version.patch: 1
        version.raw: 7.29.1
        version.scheme: semver

log entry:
CORE | WARN | (pkg/collector/python/datadog_agent.go:131 in LogMessage) | - | (cursor.py:94) | Failed to import ArrowResult. No Apache Arrow result set format can be used. ImportError: No module named 'snowflake.connector.arrow_iterator'

Describe what happened:
When running a custom query with Snowflake, either a JSON result set or Arrow resultset is usually returned. It seems that when they send back an Arrow resultset (which is usually what is returned, unless you specifically request JSON when using the Python API when logging in with PYTHON_CONNECTOR_QUERY_RESULT_FORMAT).
Describe what you expected:
The result to work.
Steps to reproduce the issue:

Create a custom_queries that might return a large result set (ours doesn't, it's like 5 columns, Snowflake likes to return Arrow or JSON at random in their API)
See error.

Additional environment details (Operating System, Cloud provider, etc):
Ubuntu 22.04.3 LTS (Jammy) on ARM64 (Graviton AWS if it matters).
Also occurs on AMD64 on a fresh install.

Hey @joshuataylor 👋 , in my test environment, I was able to see the same WARN log, although I am still able to collect the custom metrics from my custom_queries. Can you verify if you are collect to metrics from your custom query? I also see in my debug logs of my Snowflake check:
2023-08-30 19:10:32 UTC | CORE | DEBUG | (pkg/collector/python/datadog_agent.go:135 in LogMessage) | - | (cursor.py:449) | Cannot use arrow result format, fallback to json format

What may be happening is snowflake-connector-python cannot use the Arrow result set, and then fallsback on JSON for all of our API calls.

Apologies for the delay.
We don't see the event at all in Datadog.

@joshuataylor I recommend you contact Datadog support as a better channel for us to help you in this specific case. As @yzhan289 said, the log message is expected and is therefore unlikely to be the source of error, and if this was a recurring problem it's also likely that we would have run into it. It's more likely that the issue is related to the specific custom query that you're trying to run.

@joshuataylor Are you able to resolve the issue? I am also facing a similar issue with the custom query which was working before and it suddenly stopped emitting data after 10/11/2023

@Kuntal0711 Could you please reach out to Datadog support? Custom queries failing to emit data is too generic of a problem to know what the underlying issue might be without looking at details.

I haven't had time to reach out, the issue is that it can't decode arrow as
the Python library isn't bundled. So this will happen.
On Fri, 20 Oct 2023, 3:43 pm Alex Lopez, @.***> wrote:

@Kuntal0711 https://github.com/Kuntal0711 Could you please reach out to Datadog
support https://help.datadoghq.com/hc/en-us? Custom queries failing to
emit data is too generic of a problem to know what the underlying issue
might be without looking at details.
—
Reply to this email directly, view it on GitHub
https://github.com/DataDog/integrations-core/issues/15722#issuecomment-1772243972,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABW62ZE6YGGMGOCIO2ECC3YAITTVAVCNFSM6AAAAAA4EWWOTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZSGI2DGOJXGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Again, no, that's not the reason. That warning comes from here and it only results in the library knowing that it should use JSON and not Arrow format.

So it's throwing a warning that it can't decode Arrow, because the library can't be found, but that's not the reason? Can I know what the reason is?

@alopezz @joshuataylor  Thanks for the response, will follow up with Datadog support

So it warns saying it can't decode due to the arrow library not being bundled correctly, which means that we don't know if the query has been a success?
f"Failed to import ArrowResult. No Apache Arrow result set format can be used. ImportError: {e}",

Which gives this warning because the library is not included:
CORE | WARN | (pkg/collector/python/datadog_agent.go:131 in LogMessage) | - | (cursor.py:94) | Failed to import ArrowResult. No Apache Arrow result set format can be used. ImportError: No module named 'snowflake.connector.arrow_iterator'

:shrug: and it's marked as closed, so I guess it's a feature.

@joshuataylor You'll find the explanation above in this thread. That warning at import time is expected, because indeed, we don't bundle pyarrow (whether you want to call that a feature or not). This is fine because we can fall back to JSON. I still haven't seen anything that links custom queries to this warning, hence why this is marked as closed. Again, you're more than welcome to contact support so that we can actually find out what's not working and help you.

Cool well, if you set PYTHON_CONNECTOR_QUERY_RESULT_FORMAT you can force it to always return JSON by setting it to JSON (alternatively ARROW), so this issue wouldn't occur in the first place.


Pass through authentication

Hello Volkan,
Hope you are doing great. Please in my application, there is users are able to upload files. Initially, the files were uploaded on the same server where the application resides. Now, the files will have to be directed to a different server to be saved.
Please if I want to add a pass through credential that allows users to get access to this new server where the uploads will be kept, where in serenity can I add the credentials?
Regards,
George

The virtual directory IIS?

Meaning nothing is added to serenity directly right?

WebApp does not have access to the file system. Only through IIS. otherwise a security risk.

Thanks

You can also try set up an Azure blob storage account or AWS S3 to store the files, then store the URL of each file in the database (on a trigger maybe) then when you want the user to view/download the file you can just use the URL that you've saved.

You may change FilePage/Read action, or use IIS rewrite rule


Store: Cancelled/Aborted GRPC Requests Increment thanos_objstore_bucket_operation_failures_total

Thanos, Prometheus and Golang version used:
Thanos: v0.13.0
Prometheus: 2.15.2
Golang: 1.14.1
Object Storage Provider:
GCS
What happened:
We noticed a continued increases in the thanos_objstore_bucket_operation_failures_total metric while not seeing errors in the log file. After looking at other metrics it appears that when a request from query is timed out/cancelled/aborted, the thanos_objstore_bucket_operation_failures_total metric increases. We also confirmed this from the GCS side by seeing an increased rate of CANCELLED API calls around the times we noticed that the bucket operation failures metric increased.

What you expected to happen:
thanos_objstore_bucket_operation_failures_total not to increase.
How to reproduce it (as minimally and precisely as possible):
Run a large query from querier that will hit its query timeout.
Full logs to relevant components:
I can include logs if desired but they just show normal block caching operations. Even in debug mode there is nothing about a failure.

It seems to me like we need to add if !errors.Cause(err, context.Canceled) { increaseOperationFailures() }. Help wanted!

That is what is puzzling me. Query shows the request as cancelled but store shows the request as aborted, not cancelled. Is there a timer that we could be hitting? Also, I would love to help but I don't know where in the code this is getting executed. Mind pointing me in a general direction?


Fix Qt5 on develop

Replacement PR for #134. That branch was sufficiently old that it was easier to just copy and paste the relevant changes along with an updated README.

Coverage remained the same at 66.94% when pulling aa58b08aae5a74e72a19a0a3ef2cb32ec57ff7f8 on fix/qt5-develop into 6deb5fd57398745f33574667c0f0b44a5653dc55 on develop.


Article states "Microsoft Defender ATP currently does not support Windows Virtual Desktop multi-user session.", while MDATP support for WVD was announced

In this article there is still a warning (including typo) that WVD multi-user session is NOT supported, while it is currently in preview:
"Micrsosoft Defender ATP currently does not support Windows Virtual Desktop multi-user session."
However in the Microsoft Techcommunity article from May 7, 2020 https://techcommunity.microsoft.com/t5/windows-virtual-desktop/microsoft-defender-atp-now-in-preview-on-windows-10-enterprise/m-p/1372007 support for Microsoft Defender Advanced Threat Protection (MDATP) on Windows Virtual Desktop was announced enabling both single and multi-session scenarios. For WVD multisession scenario there is a note in that article stating multi-user is still in preview while single session is fully supported:
"Multi-user session scenarios is currently in Preview and limited up to 25 concurrent sessions per host/VM while the single session scenarios are fully supported."
Can the article be updated according to the announcement.
Also for WVW for onboarding the current instructions for Windows 10 and server OS are mentioned, however it is not clear to me what this means for licensing. MUST we use licensing on a per user basis, or will on a per device/host basis also be available for W10 multi session hosts? There might be Windows 10 multisession WVD scenario's for certain customers where licensing on a per device/WVD VM basis is more interesting compared to licensing per user.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 804f2883-5de4-9d54-d0b4-e64b04984aa8
Version Independent ID: 0ab9ee92-c5e1-0455-92ba-ed07ed7bd140
Content: Onboard non-persistent virtual desktop infrastructure (VDI) machines - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/configure-endpoints-vdi.md
Product: w10
Technology: windows
GitHub Login: @mjcaparas
Microsoft Alias: macapara

Hello @dvandoorn76,
the issue is already fixed in commit https://github.com/MicrosoftDocs/windows-itpro-docs/commit/c0e41df2f57f888d13c1ed9b80dcd92f0711c59c#diff-3684d7e81c25a8f6d2e8d45baca8d406
MUST we use licensing on a per user basis, or will on a per device/host basis also be available for W10 multi session hosts? - for W10, only per user licenses are available (each could be used for up to 5 devices), and for servers - standalone server licenses must be used (per device). Note, to be able to buy server license, you must have at least 50 user licenses (source: Licensing requirements)
Thank you

( commit https://github.com/MicrosoftDocs/windows-itpro-docs/commit/c0e41df2f57f888d13c1ed9b80dcd92f0711c59c )


Argument parsing fails on unclosed quotes

One of the tests for the argument parser appears to have a typo in it, and after noticing that I realized it demonstrated potential bugs. After some further investigation I found that when an opening quote is found:

It immediately jumps to that index of the string.
It considers the rest of the string to be part of a quote even if no closing quote is found.
There are no checks for quotes that contain solely whitespace.
It ignores the quote itself, even if no closing quote is ever found. (may be intentional?)

To provide some examples of input strings and what Twilight parses out of them:
"\"kind of weird\"\"but okay"; // ["kind of weird", "but okay"]
"\"one two\"three\"four five\""; // ["one two", "four five"]
"\" \"\""; // [""]

Assuming that the last "bug" is actually intentional, I believe these would be the correct outputs?
["kind of weird", "but", "okay"]
["one two", "three", "four five"]
[]

Sorry we never got to this. The command parser has been on its last legs for the past several months because of interactions, and we will now be deprecating the crate with #1352. I am therefore closing this issue.


Fix a compilier error with msys2-mingw64 ( ld.exe: cannot find -ldl )

should be merged after issue #46 ... let's take it however...


create new cli command for kubefirst create github-cluster

Define the CLI require flags for the command, to ensure we know from get-go what is needed from github and how to differentiate from a gitlab installation.

We start as 2 different create journeys, on a later ticket we have a "wrapper" create that use flags to select the proper installation strategy.

Reviewing a bit the logic we use:

Based on this exploration:
https://github.com/kubefirst/kubefirst/blob/eedfe3ed34c13a64d06193a55d9d3dd51e9fb93d/cmd/createGithub.go
Questions:

[ ] Does anything changes on setup of ArgoCD?
[ ] How to improve Hand-off screen to support github/gitlab?

Different object, Object architecture, "Strategy pattern" or different pattern of reuse.

Assumptions:

OIDC/SSO will be handled by #157

Exploring a bit how to integrate to github to try to automate github access.

Github Actions needed:

create repo
Add ssh key?

do we create the keys, or the user does that

How to get the github token?

Added on #223


Crash on launch loading folders from fixed drive C:\

Describe the bug
Files crashes on launch for no apparent reason. Window hangs for about a second (see screenshot for state) before closing and a notification: “Files - Preview: New notification”.
To Reproduce
Not sure if applicable, open up the app I guess?
Expected behavior
Files should launch and stay open, ready to be used.
Screenshots

Desktop (please complete the following information):

OS Version: Windows 10 Pro 20H2 Build 19042.685
App version: 0.23.1 (at least that’s what Store tells me)

Additional context
It may be of note that my library folders (Documents etc.) link to folders on a server in the form of \\SERVER\folder (with login), not to be confused with a network drive like H:\folder. This has worked well before, but from the log I can’t tell if that has any effect.
Files.exe.2380.dmp.zip
This .zip contains the memory dump Windows created to debug the issue.
Log file
2021-01-05 06:37:21.7814|INFO|.ctor|App launched|
2021-01-05 06:37:22.0204|INFO|.ctor|Drive added: C:\, Fixed|
2021-01-05 06:37:22.2335|ERROR|.ctor|Exception from HRESULT: 0x80270301|System.Exception: Exception from HRESULT: 0x80270301
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0x70
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task) + 0x38
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task) + 0x17
   at Files.RecentFiles.<AddItemToRecentListAsync>d__18.MoveNext() + 0x31f
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0x70
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task) + 0x38
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task) + 0x17
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult() + 0xb
   at Files.RecentFiles.<PopulateRecentsList>d__17.MoveNext() + 0x20d
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.<ThrowAsync>b__7_0(Object) + 0x1e
   at System.Action`1.Invoke(T) + 0x28
   at System.Threading.WinRTSynchronizationContext.Invoker.InvokeCore() + 0x33
   at System.Runtime.InteropServices.McgMarshal.ThrowOnExternalCallFailed(Int32, RuntimeTypeHandle) + 0x21
   at __Interop.ComCallHelpers.Call(__ComObject, RuntimeTypeHandle, Int32) + 0xb8
   at __Interop.ForwardComStubs.Stub_19[TThis](__ComObject, Int32) + 0x24
   at Microsoft.AppCenter.Utils.ApplicationLifecycleHelper.<.ctor>b__17_1(Object, UnhandledErrorDetectedEventArgs) + 0x3d
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
   at Microsoft.AppCenter.Utils.ApplicationLifecycleHelper.<.ctor>b__17_1(Object, UnhandledErrorDetectedEventArgs) + 0x75
   at System.EventHandler`1.Invoke(Object, TEventArgs) + 0x2e
   at __Interop.Intrinsics.HasThisCall__23[TArg0](Object, IntPtr, Object, TArg0) + 0x36
   at Files!<BaseAddress>+0x135e920

@tgrelka thank you for reporting this. The issue shown has been fixed in #2688. The fix will ship with the next public version.
In the meantime you can try reinstalling the app and disabling the "Recent files list" from the app Settings > Widgets

@tgrelka thank you for reporting this. The issue shown has been fixed in #2688. The fix will ship with the next public version.
In the meantime you can try reinstalling the app and disabling the "Recent files list" from the app Settings > Widgets

Reinstalling did fix the issue, displaying recent files works as well though. 🤔

Reinstalling did fix the issue, displaying recent files works as well though. 🤔

It'll work until you open the "wrong" file and then the issue will be back :)
Feel free to keep the recent list enabled, we'd be interested in finding out what king of file/file location triggers the bug

It'll work until you open the "wrong" file and then the issue will be back :)
Feel free to keep the recent list enabled, we'd be interested in finding out what king of file/file location triggers the bug

Yeah, I figured it might be a file the app has some problems with. I’ll try to investigate what file triggered the issue.
My network share was definitely connected when Files crashed, I was using it in the standard explorer.

Yeah, I figured it might be a file the app has some problems with. I’ll try to investigate what file triggered the issue.
My network share was definitely connected when Files crashed, I was using it in the standard explorer.


Generic in/out type format, with implicit gaurds. Support inline mutation/delete,updating

Search Terms
mutation, reference parameter mutation, delete, old js assignment.
Feature:
The ability to support in and out type formats for generics and output guard formats,
which would allow one to handle all inline mutations of type with assignment in js assignment and
function like delete, which mutate the type keys. Typically many function mutate the structure, in which they don't use the copy on write principle or c++ const protection as not available.
This is simple proposal to accommodate all the required cases:
This is a suggestion, the final form of this may differer.
interface A {
    a : Date;
    b : number;
    c : string;
    d : boolean;
}

const record : A = {
    a : new Date(),
    b : 1,
    c : "str",
    d : true
}

delete record.b;

// Shouldn't be accessible anymore.
record.b = 5;

// Example function signature as of sorts.
function deletefFun<This extends Record<string, any>, Key extends keyof This>(object : This, key : Key) : undefined | Key
{
    if(object[key])
    {
        object[key] = undefined; //deleted
    }
    else
    {
        return key;
    }
}

Generic Type support for Reference in/out
Require function signature to support type in and out, where the structure is internally mutated ( reference parameter) Currently ts assume that all input params will not be mutated any future.
This couple with a implicitly guard functionality for mutable ref tables, would ensure
that there can be no errors in ones coding, or require work around, everything should just work.
If inline mutation of a type is support then the output format could be compute automatically.
function deletefFun<{in:This extends Record<string, any>,out:PickInverse<This,key>}, Key extends keyof This>(object : This, key : Key) : undefined | Key
{
    if(object[key])
    {
        object[key] = undefined; //delete
    }
    else
    {
        return key;
    }
}

Generic Type with Reference in/out and implicit Gard
This would be a function with a simple implicit boolean guard format, which format that should be compatible with union kind.which would then support multiple implicit type guards.
function deleteFunGaud<{
    in: This extends Record<string, any>,
    gaurd: {
        undefined:PickInverse<This,key>,
        [Key]:Key
    }
    ,Key extends keyof This>(object : This, key : Key) : undefined | Key
{
}

Yes, in this example on the mutation is required, if because one is able to ensure that the key exists, however, if this statement could fail for any other reason or throw and error, then the type guad, would work perfectly. some underlying memory allocation failed. Some thought into the use with catch, statement to know the final mutated form, before that throw, were should be a subset of existing fields, which have not been mutated in the try, as we don't know the state until runtime and guards should need to be used for all those parameters in the catch statement, maybe a shorthand inline guard, would be good if go the catch support route too.
Examples use of functions In/Out and Guards
Exmaple 1:
deleteFunGaud(record, 'b') // results is undefined | 'b'

record.b    // is of type Error('Implicit guard check is missing, not can't be know, without runtime check')
// or
record = // This should reset the reference, back to a form that match existing type prior to mutation.

Example 2:
if (deleteFunGuad(record, 'b'))
{
    record.b // undefined and is not available, it has been removed.
}
else
{
    record.b // Is defined, because delete failed.
}

This also becomes a problem when one wants to mutate and object in old school style
style, one needs to use the spread operator or Object.assign(..) to mutate the type,
with copy on write principles alot of existing code mutates the object structure after a pull from a database. Most of the code, must now be formatted in the copy on write principle.
This is true for most all code, were results are returned and additional information is tack onto the existing database return structure. It would be nice, if index operator could automatically mutate the types, when executed in a block(body) of code.
InlineMutation
function fun(paramA : A){}

record.p : string = 'p';
record.z = 'z' as string;

fun(record) // error type mismatches, as it has been mutated.

fun({} as A) // Good

record = {} as A // fails, type mismatches as it has been mutated.

Other Related Issues:
https://github.com/Microsoft/TypeScript/issues/13783
https://github.com/Microsoft/TypeScript/issues/13195
Checklist
My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript / JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. new expression-level syntax)

This is too complex because it violates a basic assumption of the type system, that the value of an object may change but the type should stay the same.
If we allow this, they any call expression may be changing the types of its inputs. Currently we can check any expression independently, looking only at its type declaration (and type-narrowing control flow, which is much simpler than looking everywhere for side effects).
function f(x: SomeType) {
    .... // A bunch of code that we ignore when determining the return type of `f`
    return x; // We assume this is still SomeType
}

But if functions could mutate the types of their parameters, then we would have to look at every call expression that came before then to see if it has an effect, which would slow things down too much.

@andy-ms  @RyanCavanaugh Well typing system is to make sure that the shapes and forms of everything match, doesn't mean this is not suitable for a typing system. I would just say its more complex, because you have to evaluate the body of the function, all shapes on function calls, will still have to match. If it were mutated it may no longer match anymore, communicating incorrect mutation.
What if only the part of this concept that is implemented is the generic in/out, guard(out) at generic function level. No internal mutation inside the body of a function anything complicated like that. You still able to do as you said, know the shape of the input and output form would be know at the function level. But yes, you still have handle mutation at a function level. Which should just be type object update after the types of function have been evaluated. Most  functionality should exists, just wrapping it in a in/out and then update the input type after the function evaluation in the compiler with resolved out type.
Would you be open to pull requests for the feature?

Would you be open to pull requests for the feature?

"Too Complex" doesn't mean we think it's too much work for ourselves to do; it means we think the complexity it adds to the language and codebase is not justified by the value it would provide.

Well, does the TS community have any other suggestions on how to handle passing object by reference to function, were the function internally, can mutate the the typescript shape. As I understand, the goal for TS is to be a super set of JS, lacking this form of mechanism, regardless of the syntax complexity, means typescript is not a full super set of JS and doesn;t support all the mechanism patterns required.
I would really like to here what other ideas, there the ts community has for solving this.
Who makes the final calls on these things, because there is a large community and at hand?
I could present many different cases that are potentially pitfalls, were typescript is not actually type shape safe, its only type safe. We need to look at addressing the Shape safe capabilities of typescript,
which were the pitfalls still are.
When it comes to complexity, I would prefer a super set with typings to support the all the subset of commands, regardless of complex, completeness over complexity. There would be few that would write typings potentially for these method, so the complexity could be handle by the more advanced users, in my opinion. Right now, if one is to use a delete method as an example, typescript, would say everything is good, but in actually fact, downstream of any of references changes, things are not all great. typescript could be said that it actually lying to one. as the key/item is actually missing from the interface. We can write wrapper function that ensure the key exists, which means the return results will be updated, which one can continue to operator on for this case it would work.
One needs to look at the general case, in which all methods that can remove keys and change the shape, should be disallow, because they can operator on function parameter, resulting in mutation and typescript wouldn't be anywise, thinking that everything is hunky dory, while in reality it is not.
But disabling this type of function that allows mutation of the shape, would also rendering alot of functionality useless, returning us to the dark ages.
Alternatively one could look at implementing const version just like c++ of has, however, in this cases if means the input shapes for the parameters is constant, and non of the shape mutating, methods can be used in the body of the function.
If a param is not marked as const, then it is a ts error to attempt to use the variable given to a function after the function call. to use the results would force one to return the newly mutated parameter and continue operation on the return parameter under a new variable name in the parent scope.
const would become rather, verbose, so it may be better to look at inverse keyword, but this would be breaking changes to existing code, causing mass refactors potentially. So opt in of const would be good, were const is missing, on just generating compiler warnings which can be turned on or off.
One thing to remember, is that changing the shape, in TS, should not force one to have efficient statements, that results in the object being copied all, to drop or add an existing key. One will be forcing everyone to take a performance knock.
At the end of the day, a discussion needs to be had on how TS is going to align itself with JS, reading mutation of the shape, with regards to pros, crons of what regarding as acceptable performance degradation, added complexity, loss js functionality, just working out the box, like is subset language.
I feel that a discussion about this matter is the only way forward, @RyanCavanaugh, @andy-ms!
Is the community open to a discussion, I can provide many pity falls cases if required.


Formspree notification

A form has been submitted on openscience.us: Subject: New message from tera-PROMISE contact form
Received: September 26, 2015 at 09:39PM

is the plan here to inject all the form details here as a github issue?

Yes, for now we aren't using these issues but Rahul/David may use them once an automatic queueing system is in place.


Add cache to node workflows

Summary
Follow up from https://github.com/netlify/netlify-cms/pull/5895

Do you think it would have sense to do it in a different PR and change the title and commits to be more specific explaining the jobs affected?

I think it would. A separate PR for the thing we can ship and another to see performance changes will be great.

Closing this per our discussion. We can re-visit once we have a comparison on the performance improvements


Publish Docker image to Docker Hub

Hello, I wan't to try your proxy but you don't provide docker image. Could you do it ? In a CI ?

Hey, I have built and published the latest Docker image to the Docker Hub, you can pull the image with docker pull ynuwenhof/koblas:latest. I will update the Project README and set up a CI soon.


More/Better Templates

We'd like to ask Markle to do this for us, but if not, it would be great to hand off better templates to NOLA.

@skcain and I were thinking that we'd do this and #115, #116 OR #117


add TestData::getTestSamples()

Documentation for cv::ml::TrainData::setTrainTestSplitRatio explicitly states "Please, note that for each of TrainData::getTrain* there is corresponding TrainData::getTest*, so that the test subset can be retrieved and processed as well."
For some reason getTestSamples() was missing.

@mshabunin I agree that adding the function breaks ABI.
But I'd argue that the function is really missing from the 'interface' definition and thus ABI should be broken. Is there a "3.1" branch, which allows ABI/API changing pull-requests?

@andreasBihlmaier , it is assumed that version 3.1 will be binary compatible with 3.0. Actually I don't see why this function should be virtual. If you replace samples with getSamples in function body, than it will be possible to change its behaviour by overriding getSamples and getTestSampleIdx.

The problem is that https://github.com/andreasBihlmaier/opencv/blob/master/modules/ml/include/opencv2/ml.hpp#L130 states that TrainData "only specifies the interface", i.e. the closest thing to that in C++ is a pure virtual class, which TrainData actually is at the moment - all existing functions are pure virtual and are implemented in TrainDataImpl. Why should that be different for the missing getTestSamples? Especially given that getTestSamples is also pure virtual in TrainData and implemented in TrainDataImpl3

@andreasBihlmaier , you can try to move new function to the end of the virtual function list and see whether the ABI will be compatible.

@mshabunin unfortunately, this does not suffice: http://pullrequest.opencv.org/buildbot/builders/precommit_linux64/builds/4958/steps/Compare ABI dumps/logs/report-html#Type_Binary_Problems_High

@andreasBihlmaier , I don't see other alternatives:

the added method is not used (and probably will not be used) in the ML algorithms
I can't imagine a situation where this method should be overrided
the main reason to make this method virtual is to keep interface consistent

So, again, I suggest removing the virtual specifier and reimplementing the method in a base class using other virtual methods.

@mshabunin, let me assign this one to you

@andreasBihlmaier , looks good, could you please squash commits into one?

Moved to #6103


sizeof is not highlighted

sizeof is not highlighted at all. struct and return are highlighted in blue italic. Is that intentional? Is something wrong with my setup.?

@TorKlingberg I don't maintain the plugin anymore I'm afraid. Sorry for that.


Update validation to allow for empty context lists

When no strings are provided in the contexts during evaluation, the context feature's type in the dataset is the generic Sequence type rather than the expected Sequence[string], thus it fails validation with a ValueError, despite being a valid dataset.
For example, if retrieval uses an unrealistically high similarity score threshold, no contexts will be found, but the error message will be the unhelpful and irrelevant ValueError: Dataset feature "contexts" should be of type Sequence[string], got <class 'datasets.features.features.Sequence'>.
See also https://github.com/explodinggradients/ragas/issues/286

Hey @LogicalShark thanks for the PR, looks good.

hey @LogicalShark this has been fixed with v0.2, do check that out and I'm really sorry we couldn't merge your PR but thanks a lot for taking the time ❤


libicd-main linux compile

The current version cannot be compiled under Linux, and executing the make command may result in some code errors.

Please use cmake, the normal makefiles are not maintained, I neglected to remove them.
Let me know if that still gives you trouble.


Move minimal libc malloc to common library

This will (eventually) permit use of a common malloc implementation with
other C libraries, reducing the amount of Zephyr-specific code required
to support each C library.
This doesn't change the malloc implementation, it just moves the code and renames the
configuration variables.
Closes: #56243

We should move all the Kconfig's in zephyr from MINIMAL_LIBC_MALLOC_* -> to COMMON_LIBC_MALLOC_*.

Thanks, I can do that.

also document deprecation of the MINIMAL_LIBC_MALLOC_* Kconfigs in release notes

Sounds good.

We should move all the Kconfig's in zephyr from MINIMAL_LIBC_MALLOC_* -> to COMMON_LIBC_MALLOC_*.

Done.

also document deprecation of the MINIMAL_LIBC_MALLOC_* Kconfigs in release notes

Not sure where these get added?

Lots of updates to clean up this series -- I've got another series stacked on top that switches picolibc -- https://github.com/keith-packard/zephyr/tree/picolibc-common-malloc -- but that required significant logic changes in how the heap is allocated to get alignment and 'use all memory' stuff working. I'll wait to submit that until this series is done, but if anyone is interested in where this is going, that should make it more clear.

It looks like there's a regression caused by a change in the hal/atmel module which makes it incompatible with picolibc. I've submitted a PR to that, https://github.com/zephyrproject-rtos/hal_atmel/pull/32

It looks like there's a regression caused by a change in the hal/atmel module which makes it incompatible with picolibc. I've submitted a PR to that, zephyrproject-rtos/hal_atmel#32

Merged!

Merged!

Thanks! Zephyr PR #56394 queued.

I've temporarily added the atmel patch to this series to see if it fixes the tests. Alas, the wheels appear to have fallen off the CI system today.

@keith-packard as polishing this PR may take some time probably it worth to create a separate PR for https://github.com/zephyrproject-rtos/zephyr/issues/56243 fix?
Thanks!

@keith-packard as polishing this PR may take some time probably it worth to create a separate PR for #56243 fix?
Thanks!

Feel free; I've got plenty of PRs pending that I don't really want to manage another.

@keith-packard This needs a rebase.
@galak PTAL (your -1 is still pending).

I rebased, but there weren't any conflicts.

@galak ping

@galak wrote:

We should move all the Kconfig's in zephyr from MINIMAL_LIBC_MALLOC_* -> to COMMON_LIBC_MALLOC_*.
also document deprecation of the MINIMAL_LIBC_MALLOC_* Kconfigs in release notes

All MINIMAL_LIBC_MALLOC_* configs have been renamed to COMMON_LIBC_MALLOC_* with proper deprecation.
The release notes can be updated after the the feature freeze, since more changes related to this will likely follow.


Description
I have added a confirmation alert for logout , like when user click on logout a alert will pop up and it will ask **Are You sure You want to logout ** there will be two options cancel or Yes , Logout
Fixes #104
Type of Change:
Delete irrelevant options.

Code
Quality Assurance
User Interface

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?
https://user-images.githubusercontent.com/55352601/115506714-d0fe7d80-a298-11eb-869a-9288b6ca2aa3.mp4

Hi @arpit456jain could you please confirm that this change wouldn't create a conflict with the PR#102? I'm asking you to do so since both the PRs have worked upon logout functionality.

Hey @ishubham21  May be it will cause merge conflicts but no problem will pull the latest code and will merge in this branch and will also upload a video for confirmation 👍

Hey @ishubham21 i just cross check again in pr #102 he edit the files related to admin and i had put this feature for normal user in Explore/index.php
So i don't think so there will be any merge conflicts

Hey @ishubham21 i just cross check again in pr #102 he edit the files related to admin and i had put this feature for normal user in Explore/index.php
So i don't think so there will be any merge conflicts

Okay! Thanks for the confirmation.


remove preview for workspaces-based applications

Removed preview for workspace-based applications. Replaced 'must create' with 'may create'. Reorganized paragraphs to place tightly coupled information together.

@bwren

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Make DispatchEvent be enum based

Now dispatches events based on an enum instead of strings. This doesn't affect the users on_dispatch which still gets the raw event string.
Will rebase #110 on this so that it can use the enums instead of strings for specifying what event to listen for.
Conversion done via a script so shouldn't have missed anything

Since this a follow up to the waitforevent PR, what if the user wants to wait for an unknown event that isn’t in the enum? e.g. for instance imagine if the user wants to await for event “AUTO_MODERATION_CREATE” (ik its in the enum but say if it wasn’t implemented yet) the user would have to pass Unknown to the waitforevent proc and the user would not receive the event they wanted to wait for as there could be another unknown event that would be classified as Unknown as well.

More of a precursor since this should be merged before the other PR.
For unknown events it could work, basically the dispatcher needs to call checkIfAwaiting to let the wait table know of a new event and run any handlers. Since we don't really know the data of an unknown event (Since its not implemented) then we could instead pass an object like
type
  UnknownEventData = ref object of DimscordObject
    eventName: string # e.g. AUTO_MODERATION_CREATE
    data: JsonNode

and then the handler could just check the eventName and then run any needed checks on top

I did not mean to close whoops

But if the user is relaying on unknown events then they should really raise an issue to have the event actually implemented. Should unknown events even be supported for awaiting? Since if they are implemented later then it will break users code

I believe so. But I think a good idea would be a raw json waitforevent so it would wait for any event and it would be JsonNode.

Was annoying to merge this with master and then rebase #110 so will just close this and have these changes in that PR


None check for filepath in ModelCheckpoint

Check if the optional filepath is None before checking if it exists
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
N/A Did you make sure to update the docs?
[x] Did you write any new necessary tests?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?
Fixes #1535. https://github.com/PyTorchLightning/pytorch-lightning/issues/1535#issuecomment-620897607
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @yukw777! Thanks for opening this PR.

In the file pytorch_lightning/callbacks/model_checkpoint.py:

Line 89:111: E501 line too long (113 > 110 characters)

Do see the Hitchhiker's guide to code style

Line 89:111: E501 line too long (113 > 110 characters)

I'm assuming this is OK? I thought the line length limit was 120.

Line 89:111: E501 line too long (113 > 110 characters)

I'm assuming this is OK? I thought the line length limit was 120.

we set kind or warning limit 110 which is applied via pep8speaks and 120 as a hard limit in tests (flake8)

Do you think it's worth having a log for this case? E.g. "Model checkpoint isn't saved because file path not provided".
I think it's almost worth making this a warning log, it's pretty frustrating if you train a model and then realize after a few days of training that the models weren't checkpointing.

@tullie checkpoints are still saved if filepath is None. It just means that the user wants PL to dynamically figure out the path, which is inside the log folder under checkpoints.

@tullie checkpoints are still saved if filepath is None. It just means that the user wants PL to dynamically figure out the path, which is inside the log folder under checkpoints.


Disable AppCache generation

Disabling based on #450 and the fact that it’s depreciated: _https://developer.mozilla.org/en-US/docs/Web/HTML/Using_the_application_cache_
Also this would technically solve #779

Coverage remained the same at 98.346% when pulling 4a913e0fb396e2843563fb074afa521b1b0d347c on sethmcleod:master into 1e11c27c63e6ef8ea7995a06ad8eba8e732e2a89 on mxstbr:master.

Thanks @sethmcleod, much appreciated!

Disabling [Appcache] completely is also completely fine.

#779 (comment)
Would disabling AppCache cause problems in IE and Edge?
If I understand correctly Service Workers replace AppCache, but service worker support does not exist in IE or Edge.
See: Service Workers and AppCache
Given the above, it seems reasonable to use AppCache as a fallback for the foreseeable future as described in #779 (comment) Rather than disablining it all together.

You might be right...


Fetching twice for another user

Hey,
I want to fetch settings for a user after the initial fetch is done for the current logged in user (in a route middleware). I have an email that has to be translated to the locale of the user which will receive it.
In the repo $this->loaded is set to true when the initial fetch is done, so the second time it skips this and returns the data.
Any hints or tips on how to conquer this problem?

A way to run a single settings get/set with a custom constraint would probably be a good feature.
For now, I suggest you either just write some custom code to do it, or use Setting::setConstraint or Setting::setPath appropriately to make the setting store get that user's settings that way.

I think it's better to reset the loaded property to false when the setExtraColumns is called.

Closing as stale.


support some box types

related to https://github.com/abema/go-mp4/issues/13
support following box types

btrt
frma
saio
saiz
schm
tenc
trep

Codecov Report

Merging #69 (638ce59) into master (4c77d39) will decrease coverage by 1.01%.
The diff coverage is 45.83%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   81.70%   80.69%   -1.02%
==========================================
  Files          14       14
  Lines        1673     1720      +47
==========================================
+ Hits         1367     1388      +21
- Misses        175      200      +25
- Partials      131      132       +1

Impacted Files
Coverage Δ

marshaller.go
79.22% <0.00%> (-0.35%)
:arrow_down:

box_types.go
88.11% <46.66%> (-3.33%)
:arrow_down:

string.go
87.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c77d39...638ce59. Read the comment docs.


Loguru in flask with eventlet in thread started with eventlet tpool.execute fails (hashtag711)

We're developing a new UI for KoboldAI ( and have run into an issue when we added loguru.
For some reason when running a logger.debug(message) inside a tpool.execute function I get the following error:
Traceback (most recent call last):
  File "C:\Users\ebolam\Desktop\Files\git\KoboldAI\miniconda3\lib\site-packages\eventlet\queue.py", line 118, in switch
    self.greenlet.switch(value)
greenlet.error: cannot switch to a different thread

A bit more info:
We use Flask as our UI with eventlet as the backend process. Eventlet monkey patching for threads will break other pieces of our code so it is currently off. On one specific function we have a long processing time without any sleeps so the UI will become unresponsive. To prevent that, we run that function on tpool.execute so that the UI continues to run OK. Any logger.debug() call within that tpool.execute run function will cause the above error.
Any help would be appreciated.

I think you need to [disable monkey patching]( of threads using:
import eventlet
eventlet.monkey_patch(thread=False)

I remember similar issues with gevent.
In any case, if you can provide a fully reproducible example and need some help, feel free to re-open the issue.


Add Cost, Token Usage, and Latency Metrics to SDK, Playground and Evaluation

We propose to integrate additional metrics – cost, token usage, and latency – into the playground and evaluation sections. This enhancement requires modifications in both the SDK and the front-end (FE) as detailed below.
Modifications to the SDK:

SDK Output Format Change: Update the SDK to expect a JSON response from users in the following structure:{
  "message": "function output",
  "usage": {
    "completion_tokens": "value",
    "prompt_tokens": "value",
    "total_tokens": "value"
  },
  "cost": "cost value"
}

Backward Compatibility: If the output is already in the above format, return it as-is. For outputs that are plain strings (as per the previous version), reformat them to match the new JSON structure.
Latency Metric: Introduce an additional latency field in the JSON response.

Modifications to the Front-End (FE):

Response Handling: Adapt the FE to handle LLM application responses in the new JSON format.
Data Parsing and Propagation: Parse the JSON response to extract the new metrics and display them in both the playground and evaluation views.
Playground UI Update: Revise the playground interface based on the provided wireframe to showcase the new metrics effectively.

Tasks:

[x] Modify the SDK (@aybruhm) #1058
[x] Modify the FE (api, playground, evaluation) @bekossy #1059
[ ] Modify the documentation (@mmabrouk) #1060
[x] Update templates to show cost latency #1061

@bekossy

MErged


Multiple Option labels?

Hey there, Great plugin, thank you for your hard work.
I have a question,
I have a drop down which is listing multiple users, they are in an array, with first name, last name and email all separate.
I want to make the option label;
So that the label is all three, instead of one.
I used your template slot to make it show on the dropdown, but is there any way to allow it to come up on the label too?
Thanks!

Yeah you can use the prop:getOptionDescription
Just write a function in the parent component and pass it in as a prop.
In the method you write you can return anything you want
If you need some code to get started let me know.
Rob Rogers
<EMAIL_ADDRESS>
On Aug 13, 2018, at 10:02 AM, Elias Champi Hancco<EMAIL_ADDRESS>wrote:
Hey there, Great plugin, thank you for your hard work.
I have a question,
I have a drop down which is listing multiple users, they are in an array, with first name, last name and email all separate.
I want to make the label;
So that the label is all three, instead of one.
I used your template slot to make it show on the dropdown, but is there any way to allow it to come up on the label too?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks its work
my function is
getOptionDescription (item) {
return item.name + " " + item.lastName
},

Sorry, I missed this. Can you elaborate on what you mean by filterable was disabled?
Can you show me how you are using it. i.e.

prop-a=a

old.


Nuxt servermiddleware optional chaining error

Does nuxt do not support optional chaining on server middleware like webpack alias feature?

ServerMiddleware Example


Unable to claim PolkaBTC when btc transaction is sped up

Bug Description
Speeding up BTC transaction when minting will result in a UI or system bug which will cause PolkaBTC to be unwithdrawable.
To Reproduce

Go Mint PolkaBTC(https://beta.polkabtc.io/app)
Sign Transaction with polkadot.js.
Send BTC.
Speed up BTC tx before the BTC tx confirmation.
After BTC tx confirmation, try claiming PolkaBTC.

Expected behavior
The app should detect and confirm with updated tx ID.
User should be able to claim PolkaBTC.
Screenshots / Video
https://user-images.githubusercontent.com/50645218/109683764-005f0b00-7bc3-11eb-89a6-d66a21f43dd3.MP4
Additional context
Tx used in test.

First BTC tx:

614ab64533bfe31ef7f6d711f79e3abede98c68680f290a4a073d10e7ac44dcc

Updated BTC tx(Sped up):

27ab6361e60ed22f06d347708b2fc12c54157c785a8c7964689c4b84ee5c6107

REQUEST #765EA3EE16696A84D1B5D60BB75FEF68A9295EA207756E6592BC3261FF7A9F1A

OS

OS: Mac OS
Browser: Chrome
Version 88.0.4324.192

Thanks for this detailed bug report. We will look into this!


JSONPath comparison and standardisation

@cburgmer's JSONPath comparison project is currently discussing some issues relating to a proposed implementation of JSONPath known as "Proposal A". May I encourage you to get involved if you are interested in influencing the direction or, indeed, if you want to make your own proposals.
Similarly, please join us in slack (invitation) for informal discussions on the comparison project and potential JSONPath standardisation.

Thanks for letting me know!  I'll take a look.


Support loading manifest from S3

While talking to one of the community members, Edgaras Navickas, he mentioned it would be great if users could reference a manifest in an S3 bucket. This was a follow-up to issues reported in the slack thread.
Example:
DbtDag(
    project_config=ProjectConfig(
        manifest_path="s3://path/to/manifest.json",
        manifest_conn_id="aws_conn",
    ),
    render_config=RenderConfig(
        load_mode=LoadMode.DBT_MANIFEST,
    )
    # ...,
)

We can have separate tickets to support loading manifests from other cloud providers.

I'd like to add some additional ideas / comments here.
Rather than support the s3 uri, would it be worth creating a set of classes similar to the way we handle profiles.
I.e im thinking something like
ManifestSourceBase
-> S3ManifestSource
-> ArtifactoryManifestSource
-> NexusManifestSource
etc
This would make it really modular and allow us to source from numerous artifact stores, and support more than aws specific s3, think azure blob store, Google Storage, Cloudflare R2 as well as those above.

I'd like to add some additional ideas / comments here.
Rather than support the s3 uri, would it be worth creating a set of classes similar to the way we handle profiles.
I.e im thinking something like
ManifestSourceBase -> S3ManifestSource -> ArtifactoryManifestSource -> NexusManifestSource etc
This would make it really modular and allow us to source from numerous artifact stores, and support more than aws specific s3, think azure blob store, Google Storage, Cloudflare R2 as well as those above.
Thinking about integration, it would be fairly easy to just allow ManifestSourceBase as a possible type for the manifest path arg, and make ManifestSourceBase an abstract base.
This also relates in a way to #570, as they are somewhat related & competing ideas as they both deal with a remotely sourced manifest (and indeed, profiles.yml, for which the same logic could be used - Perhaps ManifestSourceBase -> CosmosFileSource or something, that would accept injects creds, or airflow conns)

This would be great. Our team would love to see this for Google Cloud Storage.

There is interest from Astro customers on this feature.

Are there any estimates of when this feature can be released? This change will help our team a lot.

@Pawel-Drabczyk I am analysing this issue at the moment and we would ideally like to have this in the upcoming Cosmos 1.6.0 release.

I have created a PR in draft for supporting this https://github.com/astronomer/astronomer-cosmos/pull/1109. Tested the implementation with AWS S3 and GCP GCS. Need some help with testing with Azure store wrt to right resources and access.

PR https://github.com/astronomer/astronomer-cosmos/pull/1109 is ready for review and I have addressed the review comments so far.


It's time up

Instructions

You are tasked with adding a new field "Due Date" to for each Todo
It should be able to display the Todos in order of due date
The user should also be able to add the due date when making a new Todo

can u assign me @Hemz1416 --> github username

!assign @Hemz1416 80

@Hemz1416 You have 80  minutes to make a PR for the issue

Can u extend my time.

!assign @Hemz1416

@Hemz1416 You have 45 minutes to raise a PR

Hey can I get assigned to this

@Hemz1416
Its been 3 hours, do you still want to work on it

!deassign

Can I get assigned to this ? @AMS003010

!assign @PandaTGOS 50

can i get assigned to this ?

@pratham-exe
This issue has already been assigned

can i get assigned after the time is up for the assigned person. ?

Kindly check the PR @AMS003010

@PandaTGOS Do you still want to work on it

I have made a PR on it

Kindly check

!deassign

Can I get assigned this task?

!assign @AutisticCoder-9000 90

@AutisticCoder-9000 You have 90 minutes

@AMS003010 hey I am done with the task, and am about to push it. Requesting you to kindly review it.

Raise a PR

Can I still do it now? Doesn't matter if I don't get assigned bounty points

Sure 😊


[develop] Only retry unconditionally for integration tests

This builds on #15114 to reduce the merge diff.
This is #15113, except that we use the new flake_retry_limit instead of just deleting it. It's now set to 0, so this has no effect anyway.

!ci-build-m e

!ci-build-me


Killercoda tutorial artifact delivery sequence fails intermittently in qa and production stage

I am exploring keptn and going through the killercoda tutorial. The tutorial first creates a keptn project on GitHub and then triggers it's delivery sequence on QA and Production.
On my first try, the release to Production failed with an error Error while creating job: job job-executor-service-job-ab7a6ead-ba1f-4914-933b--000-001 failed. Reason: BackoffLimitExceeded, Message: Job has reached the specified backoff limit
I tried restarting the tutorial, this time both QA and Production release completed successfully initially, but in the subsequent tutorial step where we modify the Keptn project to add an automated go / no-go decision step, the release to QA failed with the same error Reason: BackoffLimitExceeded, Message: Job has reached the specified backoff limit
Wish to check if this is an intermittent error while trying out Keptn in killercoda or if I am missing something.
Environment

Killercoda tutorial

Affected Component

[ ] Approval
[ ] Bridge
[ ] CLI
[ ] Datastore
[ ] Docs
[ ] Distributor / Event Broker
[ ] Helm
[ ] Istio
[ ] Jmeter
[ ] Kubernetes Integration
[ ] Openshift Integration
[ ] REST API
[ ] Webhook

Describe the bug
Release to QA and Production in the killercoda tutorial sometimes fails with an error Reason: BackoffLimitExceeded, Message: Job has reached the specified backoff limit.
Restarting the tutorial again gives the same error but now in a subsequent step (where we modify the project to add automated go / no-go decision step and then trigger the delivery sequence again)
To Reproduce
Steps to reproduce the behavior:

Go to 'https://tutorials.keptn.sh/tutorials/keptn-public-demo-011/index.html?index=..%2F..index#0
Click on 'Keptn End to End Tutorial'
Proceed with the steps. The release fails in between while following the steps
See error

Expected behavior
On being triggered, the release to QA and Production must be successful as mentioned in the tutorial steps.
Current behavior

Screenshots

Additional context

I would like to pick this up if it can be fixed to improve the tutorial. Thanks

Hi Harshal, thanks for reporting this. Error while creating job: job job-executor-service-job-ab7a6ead-ba1f-4914-933b--000-001 failed. Reason: BackoffLimitExceeded, Message: Job has reached the specified backoff limit (and the fact that it didn't happen a second time, seems to sigify that it is a transient issue with the environment that killercoda.com provides (we have no control over the infrastructure.
That said, a BackoffLimitExceeded means the pods in keptn-jes namespace were erroring. We would need the events and logs from those pods to diagnose further.
If you want to dig into the killercoda setup in more detail, it's currently hosted on @afzal442's account: [https](https://github.com/afzal442/keptn-pg-killerway/tree/master/keptn-end-to-end-delivery).
[Linking #9501 as this is another instance where we ahve to send people out to a non-Keptn-core repo to triage.]

Hey, thanks Adam for the response, I'll try to looking in the linked killercoda repo


Make the clean up work again

local group doesn't exist at this point, so just call localhost
explicitly since you can do that. Also override the ansible python
interpreter for those that are running a non-standard one.

Confirmed working as expected with the non-standard python (GCC on OSX) and cleanup executes correctly.


CSS Not Working

I've been making some changes to the CSS file that came with the template, but nothing seems to be changing. I'm trying to add a big text area and change it's height/width but I can't seem to.

I used inspect element to find where the CSS that the text area is using and found the file I'm supposed to be changing. I found 2 Bootstrap CSS files, one normal .css and one min.css. I've made changes to these CSS files and that seems to have done the trick


Version 3.23.4 - Cannot find module  [...] zod-to-json-schema/dist/esm/parsers/branded

Hey,
The latest version does not work (3.23.4)
https://stackblitz.com/edit/stackblitz-starters-jhxkjr?file=package.json
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/projects/stackblitz-starters-jhxkjr/node_modules/zod-to-json-schema/dist/esm/parsers/branded' imported from /home/projects/stackblitz-starters-jhxkjr/node_modules/zod-to-json-schema/dist/esm/parsers/record.js

me too:
Cannot find module '/Users/robson.junior/dev/site/node_modules/zod-to-json-schema/dist/esm/parsers/branded' imported from /Users/robson.junior/dev/site/node_modules/zod-to-json-schema/dist/esm/parsers/record.js
  Stack trace:
    at finalizeResolution (node:internal/modules/esm/resolve:265:11)
    at defaultResolve (node:internal/modules/esm/resolve:1157:11)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:87:39)

Looks like the import statement for branded module in this commit is not correct:
https://github.com/StefanTerdell/zod-to-json-schema/commit/ccf1cbf61c415ebb4b8252736979d5632662c208#diff-618e37ffb2ed63e6b03a60dd390c5ce5fb8c6bd8d57572104c5080948c4437f6R12
Missing .js file-extension.

@tobiasgm is correct. Add ".js" after "./branded" in the record.js and it works

Sorry about that lads! Should be fixed in 3.23.5

Issue was autoclosed after PR merging. Reopening until confirmed


pytest: max_runs option being ignored

hello there 👋
when using this with pytest:
@pytest.mark.flaky(max_runs=3)
def test_example():
    print("Running test_example")
    assert False

no matter what number I put on max_runs, it only ever retries once:
=============================================================================== short test summary info ===============================================================================
FAILED tests/test_simple_assertion.py::test_example - assert False
======================================================================= 1 failed, 34 warnings, 1 rerun in 2.15s =======================================================================

wait, nevermind, for some reason pytest-rerunfailures was also installed a poetry didn't remove it, it actually works as expected, sorry!


Create a reducer to fetch list of projects for AdminProjectPage. Dispatch type: 'FETCH_PROJECTS' to be stored in redux as 'projects'.

Created reducer and saga to fetch all projects. Name was changed slightly to conform to other names. URL connecting it to router needs to be confirmed
type: "GET_ALL_PROJECTS"
reducer: allProjects


pkgs.mailman has unresolved dependency on urllib3

The pkgs.mailman binary fails because of missing dependencies:
$ nix-shell --run "mailman --help" --packages mailman
Traceback (most recent call last):
  File "/nix/store/bp3s0p4as6cp8nlq1q54v1a9rpfl4s44-python3.7-zope.configuration-4.3.1/lib/python3.7/site-packages/zope/configuration/xmlconfig.py", line 391, in endElementNS
    self.context.end()
  File "/nix/store/bp3s0p4as6cp8nlq1q54v1a9rpfl4s44-python3.7-zope.configuration-4.3.1/lib/python3.7/site-packages/zope/configuration/config.py", line 703, in end
    self.stack.pop().finish()
  File "/nix/store/bp3s0p4as6cp8nlq1q54v1a9rpfl4s44-python3.7-zope.configuration-4.3.1/lib/python3.7/site-packages/zope/configuration/config.py", line 867, in finish
    args = toargs(context, *self.argdata)
  File "/nix/store/bp3s0p4as6cp8nlq1q54v1a9rpfl4s44-python3.7-zope.configuration-4.3.1/lib/python3.7/site-packages/zope/configuration/config.py", line 1686, in toargs
    args[str(name)] = field.fromUnicode(s)
  File "/nix/store/bp3s0p4as6cp8nlq1q54v1a9rpfl4s44-python3.7-zope.configuration-4.3.1/lib/python3.7/site-packages/zope/configuration/fields.py", line 268, in fromUnicode
    v = vt.fromUnicode(s)
  File "/nix/store/bp3s0p4as6cp8nlq1q54v1a9rpfl4s44-python3.7-zope.configuration-4.3.1/lib/python3.7/site-packages/zope/configuration/fields.py", line 171, in fromUnicode
    value = self.context.resolve(name)
  File "/nix/store/bp3s0p4as6cp8nlq1q54v1a9rpfl4s44-python3.7-zope.configuration-4.3.1/lib/python3.7/site-packages/zope/configuration/config.py", line 225, in resolve
    __import__(mname)
  File "/nix/store/inbicm302jijynnf5lsqwz1f1hhkwrk1-python3.7-mailman-3.3.0/lib/python3.7/site-packages/mailman/model/autorespond.py", line 25, in <module>
    from mailman.utilities.datetime import today
  File "/nix/store/inbicm302jijynnf5lsqwz1f1hhkwrk1-python3.7-mailman-3.3.0/lib/python3.7/site-packages/mailman/utilities/datetime.py", line 27, in <module>
    from mailman.testing import layers
  File "/nix/store/inbicm302jijynnf5lsqwz1f1hhkwrk1-python3.7-mailman-3.3.0/lib/python3.7/site-packages/mailman/testing/layers.py", line 43, in <module>
    from mailman.testing.helpers import (
  File "/nix/store/inbicm302jijynnf5lsqwz1f1hhkwrk1-python3.7-mailman-3.3.0/lib/python3.7/site-packages/mailman/testing/helpers.py", line 46, in <module>
    from requests import request
  File "/nix/store/hda8sq9vmyz2p5z1zv08vw8k6wiwpjsx-python3.7-requests-2.22.0/lib/python3.7/site-packages/requests/__init__.py", line 43, in <module>
    import urllib3
ModuleNotFoundError: No module named 'urllib3'

ping @alyssais

Note that this issue prevents the NixOS mailman module from working, too. The mailman.service cannot start up.

I believe a1eacb900e1b705678b2c199cb97baafc9b77f86 is the commit that broke the mailman wrapper.
Ping @vcunat

mailman-web has the same problem. It depends on urllib3, but the required store path in the generated wrapper is wrong.

WTF? I already reverted the commit that caused the problem: https://github.com/NixOS/nixpkgs/commit/76af9e8438cce6c503255be09f73d3b54699a254

The pkgs.mailman binary fails because of missing dependencies:
$ nix-shell --run "mailman --help" --packages mailman

I cannot reproduce this on e2867af1b24, which was master just before you
pushed your changes, for either mailman or mailman-web.  Perhaps you
tried to cherry-pick mailman things and didn't notice my earlier revert?
I'm going to revert ce6b241, since it doesn't appear to have been
necessary.

If you still get this error with the following, please re-open, but I'm
going to close this for now because I suspect it will work (have tested
on multiple systems):
NIX_PATH= nix-shell --pure -p mailman \
    --run 'cd $(mktemp -d); mailman --help' \
    -I nixpkgs=https://github.com/NixOS/nixpkgs/tarball/master

(the cd is because mailman likes to create a `var' directory in PWD.)

I was only moving a commit to staging due to large rebuild; otherwise I've had nothing to do with it.


Button Group

Description
Hi! Is it on the agenda to create a Button Group component like this(?): https://mui.com/material-ui/react-button-group/
Additional Information
No response

Hey!
We haven't planned on making a separate Button Group component, but instead provide a more primitive "Flex" component which you can use for common grid/flex layouts.
As for Split Button, we have a separate discussion going on for this: #2157


Update quality-service-pod.md

Update Burstable conditions with limit.
From the code, the Burstable QoS is: At least one Container in the Pod has a memory or CPU request or limit.
https://github.com/kubernetes/kubernetes/blob/8e0ac5b6a1105e0e9d124f240da2b7acb33e6963/pkg/apis/core/v1/helper/qos/qos.go#L39-L62

Hi @Huang-Wei would you be willing to serve as a technical reviewer for this?  Simply add a /lgtm if you feel it is technically accurate.  THANKS!
/cc @Huang-Wei

/assign

Docs change LGTM and makes sense to me from a technical perspective.
@kubernetes/sig-node-pr-reviews is this good to go?

Hi @Huang-Wei would you be willing to serve as a technical reviewer for this? Simply add a /lgtm if you feel it is technically accurate. THANKS!

Sorry for the late response. (just get back from vacation)
/lgtm
A nit is that two "or"s in a sentence doesn't read that smoothly..

/approve


LuaJIT optimiziations

I'm planning to use liquid templating in OpenResty during request phase.
That means we will be applying series of optimizations to this project to reduce GC pressure and make the code JITable.
Some of the changes might be non idiomatic, but will be needed for sake of performance.
Main concerns are:

replace use of pairs (fortunately just 2) with ipairs
cache all global functions like string.find in local variables (str:find('foo') to local find = string.find; find(str, 'foo'))
reduce table allocations (cache the metatables in :new functions)

That is just from top of my head. Guess I'll find more when actually profiling it.
I'd like to know if you would like these changes to be applied to your project or we should just maintain a fork. I'm not sure what your commitment is to this project, but ours is quite serious as it is used for templating in our API Gateway: 3scale/APIcast.
I'd be happy if we could have just one project instead of forking, but there are some issues opened for a long time: https://github.com/chenxianyu2015/liquid-lua/pull/13 https://github.com/chenxianyu2015/liquid-lua/issues/14 and we simply have to move fast.

@chenxianyu2015 do you have any feedback?


crash on java 10?

Hi again XD. Sorry to bother you again, so I'm using windows 10 and oracle jdk 10.
when i select project folder, the project won't load and this is the console output.
Exception in thread "AWT-EventQueue-0" java.lang.NoClassDefFoundError: sun/dc/path/PathException
at org.petschko.rpgmakermv.decrypt.GUI.openRPGProject(GUI.java:226)
at org.petschko.rpgmakermv.decrypt.GUI.lambda$assignMainMenuListener$0(GUI.java:162)
at java.desktop/javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at java.desktop/javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at java.desktop/javax.swing.AbstractButton.doClick(Unknown Source)
at java.desktop/javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
at java.desktop/javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown Source)
at java.desktop/java.awt.Component.processMouseEvent(Unknown Source)
at java.desktop/javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.desktop/java.awt.Component.processEvent(Unknown Source)
at java.desktop/java.awt.Container.processEvent(Unknown Source)
at java.desktop/java.awt.Component.dispatchEventImpl(Unknown Source)
at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
at java.desktop/java.awt.Window.dispatchEventImpl(Unknown Source)
at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.desktop/java.awt.EventQueue.access$600(Unknown Source)
at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)
Caused by: java.lang.ClassNotFoundException: sun.dc.path.PathException
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source)
at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
... 40 more
Anyway to solve this other than downgrade my jdk version? Thanks!

Issue was already stated here with a work around.
https://github.com/Petschko/Java-RPG-Maker-MV-Decrypter/issues/16

I recommend install Java 8 again, since Java 10 is just supported until Sept. 2018

Okay,i see.
Thanks for help!

@xpirad since it looks like this issue here was also caused by "Oracle" classes, can you let me know if the test version in this issue https://github.com/Petschko/Java-RPG-Maker-MV-Decrypter/issues/20 works on Java11?

Hi Petschko!
Thanks for updating!
I've tried <IP_ADDRESS>, there's seems to be some connection error? I'm using the latest jdk 11.0.3

I currently don't have any rpg mv project to test, but will do so when i have.
Thanks again!

Haha that's because I currently build in an Updater^^ Forgot to remove that code from starting the Program... It tries to connect to http://localhost/version.txt
But that should not cause any issues. I also removed this warning and show in the future:
[WARN]: Can't connect to UpdateUrl "{URL}"... (Connection refused)
Beside from that connection refused warning let me know if it works once you have the chance to test it =)

I will also ask the user on the first run if they want to have the update check enabled, if not it never will create any connection, but currently it's not done.

I see, nice feature!
Awesome! 👍


compilation error

you need to replace func set_size(size): by func set_size(size, keep_margins: bool = false): and  func set_position(pos): by func set_position(pos, keep_margins: bool = false):

Godot 3.2.2 and later supports 2D batching in GLES2, and Godot 3.3 and later supports batching in GLES3. This greatly improves text rendering performance, making this add-on no longer relevant.


how to get the input and output nodes of the model

You need to provide more details, but I invite you to look at the evaluate.py script as well as the model/base_model.py and model/ner_model.py files: they define methods that you can use to compute predictions.


Bug: NullReferenceException occurs when InsertAllAsync is executed on Connection that belongs to TransactionScope.

If you call InsertAllAsync method under TransactionScope, Task InsertAllAsyncInternalBase method fails to start a new transaction and NullReferenceException occurs.
It is used in the following environment.
-.NET Core 3.1

RepoDb.MysqlConnector

using (var ts =  new TransactionScope(TransactionScopeOption.Required, new TransactionOptions(), TransactionScopeAsyncFlowOption.Enabled))
{
    var dbConnection = factory.CreateConnection();
    if (dbConnection == null)
        return;
    dbConnection.ConnectionString = connectionStrings;
    await dbConnection.EnsureOpenAsync();
    var timestamp = DateTimeOffset.UtcNow;
    var defaultTimeStamp = new DateTimeOffset(new DateTime(1900, 1, 1));
    // OK
    await dbConnection.InsertAsync(new User
    {
        Id = 1,
        Name = "user1",
        Email = "email",
        CreatedAt = timestamp,
        UpdatedAt = timestamp,
        DeletedAt = defaultTimeStamp
    });

    // NG Throws System.NullReferenceException
    await dbConnection.InsertAllAsync(new[]
    {
        new User { Id = 2, Name = "user2", Email = "email", CreatedAt = timestamp, UpdatedAt = timestamp, DeletedAt = defaultTimeStamp},
        new User { Id = 3, Name = "user3", Email = "email", CreatedAt = timestamp, UpdatedAt = timestamp, DeletedAt = defaultTimeStamp},
        new User { Id = 4, Name = "user4", Email = "email", CreatedAt = timestamp, UpdatedAt = timestamp, DeletedAt = defaultTimeStamp},
        new User { Id = 5, Name = "user5", Email = "email", CreatedAt = timestamp, UpdatedAt = timestamp, DeletedAt = defaultTimeStamp},
        new User { Id = 6, Name = "user6", Email = "email", CreatedAt = timestamp, UpdatedAt = timestamp, DeletedAt = defaultTimeStamp},
        new User { Id = 7, Name = "user7", Email = "email", CreatedAt = timestamp, UpdatedAt = timestamp, DeletedAt = defaultTimeStamp},
        new User { Id = 8, Name = "user8", Email = "email", CreatedAt = timestamp, UpdatedAt = timestamp, DeletedAt = defaultTimeStamp},
        new User { Id = 9, Name = "user9", Email = "email", CreatedAt = timestamp, UpdatedAt = timestamp, DeletedAt = defaultTimeStamp},
        new User { Id = 10, Name = "user10", Email = "email", CreatedAt = timestamp, UpdatedAt = timestamp, DeletedAt = defaultTimeStamp}
    });
    ts.Complete();
    await dbConnection.CloseAsync();
}

I had replicated this bug on the Core line. It is very unfortunate, we had removed it when we migrated from the old code line (see this line in to the new code line (see this line).
The fix will be issued on the new release together with MergeAll and UpdateAll methods (to all supported RDBMS). Mind if you can share when do you need this? Thanks

@karuakun - this bug is now fixed and is a part of the latest deployment (RepoDb.MySqlConnector (v1.0.4)). Would you be able to validate in your side? Thanks
> Install-Package RepoDb.MySqlConnector -version 1.0.4

Thanks for fixing it!
I confirmed that it was fixed.

Closing this ticket now. Thanks