What about semantic versioning?

Have you thought about adding a checklist for establishing a set of semantic versioning rules?
Having spent too many years in the Java world, one nice thing you could count on is that nearly all Java libraries used the MAJOR.MINOR.FIX release notation. This is something that I believe could benefit the Go community.
While I understand that the Go community's solution to this is "vendor the version you depend on", I still believe there is value in naming and labeling specific releases.
There is a generally accepted rule within Go that once you reach a 1.0.0 version, you are making a guarantee of API compatibility. There is also a suggestion that if you want to change an API after 1.0, you need to do that using a new import path, as in:
import "github.com/myuser/mylibrary/v1"
import "github.com/myuser/mylibrary/v2"

Do you think this would be useful for Go? Too much complexity?

Hey @jbuberel, thank you for raising the question.  I had been mulling over it myself but hadn't reached a definitive conclusion.  Here is what I propose doing:
Under the Good Citizen guidance section, we have a blurb that speaks about API Stability and Maturity Grants.  That topic seems like a perfect place to discuss this.  Would you feel interested in fleshing out a draft publication/api_stability_and_maturity.md file that discusses this more deeply?
A couple of messages/values that speak out to me in terms of how this document should be worded:

There are multiple disciplines that can be chosen.  The author should pick one and stick to it consistently, trying to prefer well-known, preexisting conventions—like semver—as a default.

The author should mention something about the overall maturity of the project, what is likely to change, when, and possibly how.  Is it in use for production, a prototype, legacy, etc?

I would refrain from suggesting a particular methodology for exposing the versioning to the project's customers (e.g., version control or filesystem path literals that convey a frozen point in time).  The Go community has yet to come to full concensus itself on how to do this, if at all.  Fads explode and fade as quickly as fireworks in the night.  What does seem worth mentioning is version control release tagging, however, since it is agnostic to most of the common vendoring schemes people use.  (Vendoring and stability grants are closely related but also sufficiently orthogonal.)

Does this seem fair?
I had been thinking about writing an article about implementing one's own go fix tool to rewrite APIs for customers en masse, but only big projects that are in transition would care about this …

@matttproud - Happy to help. Let me take a pass at the first draft.
What are your thoughts on the following rule, which Rob is fond of quoting:

Once you reach a stable API, any breaking changes to that API should mean the import path changes.

You also have Eric Fowler who insists that you should never include API version information in your API request path. He suggests that versioning should be done at the level of the hostname (api.github.com vs api2.github.com). I'm not sure I would go that far though.

Sounds great.  Can't wait to see what you come up with!

Take a look at this first draft, and let me know what you think:
https://github.com/jbuberel/gochecklist/blob/master/publication/api_stability_and_maturity.md

Cool!  Looks great overall!  Want to take care of these items and then open a pull request?
Major Remarks

In the Project Maturity and Stability section, I might include a blurb about doing a favor to users to mention what could or is likely to change—provided the remarking of such things does not entail significant overhead.  APIs development is an iterative process, so sometimes reflection in the thereafter produces profound wisdom about the next time.
In the Semantic Versioning section, I might make a footnote that another option is to expect users to take appropriate steps, whatever they deem it for themselves to vendor their dependencies and just break the API for the base bath, especially moving from v1 to v2 is a rather self-explanatory exercise.  The core requirement, though, is that source control revision IDs and tags are used and meaningful.  Historically this has been my preference when the migration is abundantly straightforward.  When I needed to change a project repository's internal layout, I have created a moved.go that is similar to what upstream Go has periodically done since this is one of those trivial steps.
This should be linked from the main README.md.

Nits

Typo of langugae .
Mind attempting to break lines, where doing so does not detract from readability, to approximately 80 characters?
Mind using double spaces after period?  Markdown renderers will do the correct thing, but many folks view the content in fixed-width editors.  This will keep it consistent with the rest of the corpus?

I have gone ahead and merged #5, so I think we can mark this as fixed for now!


release: v1.0.0a8

Signed-off-by: Lars Holm Nielsen<EMAIL_ADDRESS>

Coverage remained the same at 99.286% when pulling e9f0547c8e1f916428e48d2210ca1a621a69016f on lnielsen:rel-v1.0.0a8 into 2c0a579daec4cc3b475d5578bcb82e4f3f257337 on inveniosoftware:master.


WindowsPackageType=None in a class library includes the bootstrapper

Describe the bug
If you set the the package type in a class library, then the build adds the bootstrapper to the class library:
<WindowsPackageType>None</WindowsPackageType>

This is because the condition to include the bootstrapper is very loose:
<PropertyGroup Condition="'$(WindowsAppSdkBootstrapInitialize)'=='' and '$(WindowsAppSDKSelfContained)'!='true' and '$(WindowsPackageType)'=='None'">

A workaround is to also set the WindowsAppSdkBootstrapInitialize property:
<WindowsAppSdkBootstrapInitialize Condition=" '$(WindowsAppSdkBootstrapInitialize)' == '' and '$(OutputType)' != 'Exe' and '$(OutputType)' != 'WinExe' ">false</WindowsAppSdkBootstrapInitialize>

Steps to reproduce the bug

File | New | WinUI class library
Set WindowsPackageType=None
Build
Inspect dll and observe bootstrapper

Expected behavior
No bootstrapper
Screenshots
No response
NuGet package version
1.0.0
Packaging type
No response
Windows version
No response
IDE
No response
Additional context
I noticed this when several libraries referenced each other:

C:\Users\mattl.nuget\packages\microsoft.windowsappsdk\1.0.2\include\MddBootstrapAutoInitializer.cs(11,38): warning CS0436: The type 'Release' in 'C:\Users\mattl.nuget\packages\microsoft.windowsappsdk\1.0.2\buildTransitive..\include\WindowsAppSDK-VersionInfo.cs' conflicts with the imported type 'Release' in 'SkiaSharp.Views.Maui.Controls, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\mattl.nuget\packages\microsoft.windowsappsdk\1.0.2\buildTransitive..\include\WindowsAppSDK-VersionInfo.cs'. [C:\Projects\SkiaSharp\source\SkiaSharp.Views.Maui\SkiaSharp.Views.Maui.Controls.Compatibility\SkiaSharp.Views.Maui.Controls.Compatibility.csproj]

Interesting. Yes I think you're right. Narrowing the default to also check for OutputType = Exe or WinExe should be more correct. Thanks for the feedback!
I've added this to my queue. I suspect the change itself is simple but some of our test projects happened to rely on this and will fail (spectacularly) until patched to compensate e.g. by adding <WindowsAppSDKBootstrapInitialize>true</WindowsAppSDKBootstrapInitialize> to their *proj file. IOW do-able but more of a time-sink than it might seem at first blush, so please be patient.
And yes, a workaround until fixed is to add to your *proj file <WindowsAppSDKBootstrapInitialize>false</WindowsAppSDKBootstrapInitialize> to avoid the default evaluation to true.
This has been a complicated space to date so I did some spelunking (below) to verify this conclusion. Please speak up if you see a flaw in the analysis.
+@Scottj1s sound good to you too?
Detailed Spelunking...
The default's been selected this way since 1.0-preview2, revising an earlier implementation in 1.0-preview2 which had its issues (see below).
Per Common MSBuild project properties OutputType is the

...file format of the output file. This parameter can have one of the following values:

Library. Creates a code library. (Default value.)
Exe. Creates a console application.
Module. Creates a module.
Winexe. Creates a Windows-based program.

Clearly we do want the Bootstrapper when
Condition="('$(OutputType)'=='Exe') or ($(OutputType)'=='Winexe')"
Case #1: It's probably wrong if it's a Library or Module. I suspect there's some oddball case where a DLL is loaded by a generic exe (a la regsvr32.exe, dllhost.exe, te.exe or litany of others) but that's unusual enough and ambiguous enough that we can ignore it for the default (those who truly want it to explicitly set <WindowsAppSDKBootstrapInitialize>true</>).
Case #2: What if OutputType is undefined? It's possible but again it seems we're getting into weirdly unusual territory requiring developer action to explicitly tell us if they want auto-initialization.
BTW the docs note a caveat about OutputType:

For C# and Visual Basic, this property is equivalent to the /target switch. The output type can be automatically overridden by inferencing. See OutputType set to WinExe for WPF and WinForms apps. Disable inferencing by setting DisableWinExeOutputInference to true.

but that has to do with OutputType = Exe vs WinExe so it doesn't change our calculus.
As to why the Bootstrapper default is the way it is today we need to do a little software archaeology...
The default is defined in build\NuSpecs\Microsoft.WindowsAppSDK.BootstrapCommon.targets
    <PropertyGroup Condition="'$(WindowsAppSdkBootstrapInitialize)'=='' and '$(WindowsAppSDKSelfContained)'!='true' and '$(WindowsPackageType)'=='None'">
        <!--Allows GenerateBootstrapCS/GenerateBootstrapCpp to run-->
        <WindowsAppSdkBootstrapInitialize>true</WindowsAppSdkBootstrapInitialize>
    </PropertyGroup>

which actually dates back to build/NuSpecs/Microsoft.WindowsAppSDK.MddCommon.targets as shipped in 1.0-preview2 and created in commit 48e6b8f1766210977b9c32f1b35641ae71dce551 on Oct'14,2021. Before that 1.0-preview1 defined in build/NuSpecs/Microsoft.WindowsAppSDK.Foundation.targets
<Import Project="$(MSBuildThisFileDirectory)Microsoft.WindowsAppSDK.Bootstrap.targets" Condition="'$(MSBuildProjectExtension)' != '.wapproj'" />

which was an overly broad target and led to the refinments on Oct'14 in commit 145937202bde554a46f8f1e3654f8554172e1883 for 1.0-preview2.

See the related PR Remove C# auto-initialization check for reflection#2500

Given the nature of the impact this is probably something we should not service to 1.1.
Tee'd up for 1.2 => https://github.com/microsoft/WindowsAppSDK/pull/2775

This has been resolved in 1.2


Add RecycableVolumePlugin interface

Adds interfaces for RecycableVolumePlugins.  Implementations to follow.
I'm going to add to the fakeVolume and make unit tests.  Ignore the 1st commit.  It's cherry picked from the API PR and will be gone from this PR after that PR is merged.
3 of 5 PRs from #8334
@thockin

Thank you very much for the pull request - we sincerely appreciate the work that goes into sending us a change.
We are currently in a feature-freeze and general code slush as we work toward our 1.0 release. Our initial triage indicates that this is a non-critical change at this time, so we'd like to leave it open and revisit it after 1.0. We expect the freeze to wrap up in early to mid July.
If you feel that this triage is incorrect, please respond and let us know why. We're currently accepting changes that meet any of the following criteria:
Changes directly related to v1.0 issues: https://github.com/GoogleCloudPlatform/kubernetes/issues?q=is%3Aopen+is%3Aissue+milestone%3Av1.0
Changes addressing P0 bugs: https://github.com/GoogleCloudPlatform/kubernetes/issues?q=is%3Aopen+is%3Aissue+label%3Apriority%2FP0
Changes to supported platforms to bring them up to par with the primary development platforms
Docs, user experience, and test related fixes
Thanks again for your contribution! The community is really what has made this project so exciting.

LGTM modulo comments on the first layer, which is included herein.  on-call do not merge until proper LGTM

Squashed and in-line with the API commit before it.

LGTM then just one nit

LGTM cb547f4

Closing this PR.  All commits accounted for in #9024.


[Feature Request] Input total price OR price per unit

Currently I need to input total price of bill when I refuel my car. And you calculate the unit cost. It would be nice to have it also vice versa. So when you add new fuel record, you can type unit price and final price gets calculated from it.

+1

This is added, but to preserve backwards compatibility, you can only input gas prices in Unit Cost when ADDING new records, when you go to edit an existing record you can only edit the total cost.

Since this is released, I will mark it as closed.


Update MD file on new branch 2017-11-15_07-24-21

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


style(landing-page): call to action buttons

The header section needs to be updated so that we have two "calls to action" (like in https://mui.com):

Get Started (primary button)
install text copy field

Discussed in https://github.com/ayoayco/astro-reactive-library/discussions/112

I can do this, can you assign this to me?

Can you tell me exactly where you want to place these call-to-action buttons? Should I put them where I have marked?

Hi @Lalit3716! You can remove the Astro logo, then place the call to action buttons under the text "Build fast websites, faster."


aws s3 with kms : encryption context value not working as expected

Thanos, Prometheus and Golang version used:

thanos, version 0.20.0 (branch: HEAD, revision: 893188a6752e260cf54f3c082392a521b6c92f75)
  build user:       circleci@c7e18ff0c722
  build date:       20210428-13:07:30
  go version:       go1.16.3
  platform:         linux/amd64

Object Storage Provider:
AWS
What happened:

Upgrade thanos image from v0.18.0 to v0.20.0
Errors observed in thanos-sidecar :

level=warn ts=2021-05-03T07:23:48.984793685Z caller=sidecar.go:291 err="upload 01F4DS38ZY7NYQNP0J7Q48DK1N: upload debug meta file: upload s3 object: The context value for 'aws:s3:arn' shall be equal to object's ARN" uploaded=0

What you expected to happen:
Since the config has not changed the error above should not happen
How to reproduce it (as minimally and precisely as possible):

storate config

 type: yaml
 value:
   type: S3
   config:
     bucket: <bucket-name>
     endpoint: s3.<aws-region >.amazonaws.com
     region: <aws-region >
     signature_version2: false
     insecure: false
     sse_config:
       type: SSE-KMS
       kms_key_id: arn:aws:kms:<aws-region >:<aws-account-id>:key/<kms-key-id >
       kms_encryption_context:
         "aws:s3:arn": "arn:aws:s3:::<bucket-name>"

Full logs to relevant components:
level=warn ts=2021-05-03T07:23:48.984793685Z caller=sidecar.go:291 err="upload 01F4DS38ZY7NYQNP0J7Q48DK1N: upload debug meta file: upload s3 object: The context value for 'aws:s3:arn' shall be equal to object's ARN" uploaded=0

Anything else we need to know:

Hi thanks for the report. I went over the changes for S3 and from 0.18 - 0.20 I don't see anything relevant that has been changed.
To be certain that it's related to Thanos; Could you perhaps test if reverting back to 0.18 fixes your issue? If so, please try Thanos 0.19. If this does not resolve your issue, could it be that there is something changed in AWS / configuration?
Last thing, this might be completely irrelevant but you have:
       kms_encryption_context:
         "aws:s3:arn": "arn:aws:s3:::<bucket-name>"

I haven't tested this, but the docs state:
kms_encryption_context: {}

Which lacks the " on the kms_encryption_context - Perhaps you could try the setup used as example?

@wiardvanrij this was tried already. the error re-occurs for v0.19. It disappears after rolling back to v0.18. Also, to confirm the configuration has not changed nor has the attached IAM Role/Policies.


Incorrect link provided in the documentation

Issue description
The link for Audit and Logging Information for SAP Cloud Integration (Neo) leads to Cloud Foundry documentation.
Please check and update.

Feedback Type (Optional)
None
Page Title on SAP Help Portal (prefilled)
Security Events Logged by the Neo Services
Page URL on SAP Help Portal (prefilled)
https://help.sap.com/docs/btp/sap-btp-neo-environment/security-events-logged-by-neo-services

Hi @Santaneel,
It looks like the link is fixed now. Let me know if there are other issues by reopneing this GitHub item.


Array.from causes issues

import { ClientFunction } from 'testcafe';

fixture `Getting started`.page `https://www.google.com`

const clientFunction = ClientFunction(() => {
  return Array.from(document.querySelectorAll('div')).length;
});

test('test', async t => {
  const x = await clientFunction();
  console.log(x);
});

Thank you for reaching us and posting this information.
It seems we have some problem with the compilation of ClientFunction's code with the babel. We'll investigate and fix it.

I know your example is just for demonstration purposes, but I want to mention that you can use document.querySelectorAll('div').length in the ClientFunction. And the best way to get the number of elements on the page is to use Selector's count property: Selector('div').count.

Also seeing this issue, my workaround was to use Array.prototype.slice.call()

@joywave querySlectorAll returns a node list and it is not really a typical array.
you can convert it to array using
const divs= [...document.querySelectorAll('div')];
console.log(divs.length);

The problem is fixed in the<EMAIL_ADDRESS>version.

The problem is fixed in the<EMAIL_ADDRESS>version.


Our secrets module

What is the our_secrets module in the settings.py
I cannot run the project without it :smile:

Please view Contributing guideline
our_secrets.py is where you store your database key and password, information, etc. Please see example for the file (you need to make it)

Also, if you want to contribute to the future version, please see rewrite, thanks!


Fix dangling datediff reference

FYI this just nuked some incrementals with the following error. I'm sure it's a quick fix on our end to adjust the test we use for recency checks, but just a heads up @clausherther
Compilation Error in test dbt_expectations_expect_row_values_to_have_recent_data_silver__blocks_BLOCK_TIMESTAMP__day__1 (models/silver/silver__blocks.yml)
  'dict object' has no attribute 'dateadd'

  > in macro test_expect_row_values_to_have_recent_data (macros/schema_tests/table_shape/expect_row_values_to_have_recent_data.sql)
  > called by macro default__test_expect_row_values_to_have_recent_data (macros/schema_tests/table_shape/expect_row_values_to_have_recent_data.sql)
  > called by test dbt_expectations_expect_row_values_to_have_recent_data_silver__blocks_BLOCK_TIMESTAMP__day__1 (models/silver/silver__blocks.yml)

Hmm this only fixed the ref for datediff to be explicit, so instead of calling dbt-core datediff it calls dbt.datediff.
Could you open a new issue for this and provide the necessary info to reproduce? Thanks!

If anything, I would have been this commit which is in 0.8.1 https://github.com/calogica/dbt-expectations/pull/232/commits/3df4494876cdcc49ae787e527eddad233959f76d

Yea, it may have been that one as the hourly incremental at 12 eastern is what started failing. Jumped a bit early to this one.

If you wouldn't mind, please open a BUG issue. This shouldn't happen if you're on dbt >= 1.2 I think.

Yea, once we get the issue fixed I can ticket what happened.
Looks like the models are on at least dbt 1.2.3

Either hard-coding to 0.8.0 or bumping up to dbt 1.3.0 addresses the error

Interesting, I was under the impression the date macros were all in 1.2+, but tbh we're not explicitly testing the CI pipeline for 1.2. I'll take a look, but have a feeling we won't revert the release but instead clarify the dbt version dependency.

I can't reproduce on dbt 1.2, I have a feeling you might have some other cross-package issues with dbt-utils maybe.

Likely a cross dependency like that, we'll have to address in greater detail when everyone is back next week. Appreciate your responsiveness!

We pushed a couple of updates to dbt-date and dbt-expectations that should help with issues related to also including dbt-utils. Let me know if that fixes things for you.


Bug: Background Lasso fails on line outside of image bounds

There is a problem in LassoBoundingBoxSelectTool.selection_from_points(): the points are not checked against editor widget bounds, like they are in model_selection_from_points().

Closed by commit 98fdcceaac1958523f80ecb776ca157ef471cbc5


Mona.app links don't work

I tried the "Open Profiles With..." preset for Mona.app but it doesn't seem to work:

Thanks for this amazing extension, btw.

Oh man, yea looks like Mona changed their deeplinking url scheme in the most recent update. will try to figure out what the new url should be

asked here https://mastodon.social/@tvler/112073570826506321


Adding german localisation to UTM

I just git cloned UTM, opened it with Xcode to add another language and then edited the files accordingly.
Once done I pushed this to my fork to create this pull request.
While this may sound trivial, this actually is my first one apart from some small web-edits I committed via the web interface, so I really hope this went as desired. At least the changed files do look good.
Best,
Rastafabisch

Feel free to fix some things. I was not able to test it, because UTM would not compile due to insufficient development permissions. Regarding the Main.strings file Xcode is the culprit indeed.

@conath Any update on the status of this? Should it be merged?

I will take another look at it, it probably needs to be updated for the new version.


Logging cannot be deactivated

I use your library in my Android project. I would like to suggest that there is the possibility to deactivate logging. In QLog the value for Logging Level is hardcoded to "ALL".
Also, the logging message (level INFO) I get is
I/RootBeer: LOOKING FOR BINRARY: /system/bin/su Absent :(

binRary instead of binary.

Hey @aippisch, thanks for the suggestion and the spelling error spot. I LOL'd at binRary! Please feel free to send us a pull request with the changes and we'll review and likely accept.

Hi guys and @scottyab!
There are 2x PR .. any news? will be nice to fix this issue quickly 👍
Thank you!


SOLR-17489: CLI: Deprecate variations on solr urls options

https://issues.apache.org/jira/browse/SOLR-17489
Description
See JIRA
Solution
Deprecate old options in favour of --solr-url and --name.   I am really liking how this looks after going through the code...
Debating if we should be using --collection instead of --name....   That can be a seperate ticket.
Tests
bats and java

@malliaridis  okay, this one is ready for another set of eyes!

After merging this, we can then sort out the -s in the SolrExporter.java class.

Will add CHANGES.txt all at once.


Update syntax tree visible endpoint node with packageName and version

Purpose
Update syntax tree visible endpoint node with packageName and version.
Approach
Use module object's package name and version to update custom syntax tree.
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

There are a few places not covered by the test you added ...  can you take a look?


OSStatus error: [-34018] Security error has occurred.

I'm getting the title error when I try to save something into keychain.
Any ideas?

@marioacarvalho Please add code signing entitlements to the app. From iOS 10, entitlements file is always needed for writing Keychain even without sharing.
Closing as duplicated to https://github.com/kishikawakatsumi/UICKeyChainStore/issues/106#issuecomment-247535425


fix(slots): pass noCheckmark attribute down on each slot change #170

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #170
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.

[x] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

@jason-capsule42 how are you validating that this is working? I tried linking this to auro-combobox, but I am not seeing a way to validate that this is working. In combobox, the API example for the dynamic menu is not working either?

@blackfalcon I can look why the dynamic menu example is broken right now. It certainly was working when I tested so not sure what is wrong right now.
The main thing you are looking for here is that before this fix noCheckmark attribute was applied to the menu but was not passed down to all the menu options until you took an action that caused the JS to reassess the state of all menu options (hovered over it works because that recalculates which option is activeOption). The extra space that was visible was the space for the checkmark.
If you test the working dynamic menu against the main branch:

Type into the input
Inspect the auro-menuoptions that are populated into the menu. You will see that none of them have noCheckmark.
Hover of the menu.
Inspect the auro-menuoptions that are populated into the menu. You will see that they now have noCheckmark.

Repeat this test on my branch and you will see that noCheckmark is correctly applied as soon as the slot content changes rather than waiting for a manual interaction with the menu.
I'll look into the dynamic menu issue in the morning.

:tada: This PR is included in version 3.9.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Problem with addClassNames() in 0.4.0: Uncaught InvalidCharacterError

When I upgrade scalacss from 0.3.1 to 0.4.0, I get this error in the javascript console:
Uncaught InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList': The token provided ('Styles-layoutPanel panel panel-default') contains HTML space characters, which are not valid in tokens.
The code looks like this:
import scalacss.Defaults._

// CSS styles
object Styles extends StyleSheet.Inline {

  import dsl._addClassNames

  import language.postfixOps

  val layoutPanel = style(
    addClassNames("panel", "panel-default"),
    marginTop(100 px),
    minWidth(300 px),
    maxWidth(500 px)
  )
...

The browser points me to this code as the source of the error:
trait ScalatagsJsDomImplicits {

  implicit final def styleaToJsDomTag(s: StyleA): Modifier = new Modifier {
    def applyTo(t: dom.Element) = t.classList.add(s.htmlClass)
  }

I get the same results in various browsers (The code is running under Ubuntu-16.04).

That was fixed in 0.4.1. It should go away after upgrading.

Reopen if this is isn't fixed.


process_tasks not reading database

Running:
python manage.py process_tasks
just hangs there with no output. My list of tasks doesn't seem to be changing.
I created a test task,
@background()
def test():
    print('THIS IS A TEST')

and then added it, but no luck.
tasks.py is placed inside my app's folder, like so:
apps>testapp>tasks.py
So far, none of the fields are populated. Only run at is filled in. I've tried setting that time back a few days incase the time was messed up with no luck.
Attempts are 0, and Failed At is not populated, nor is Locked At.
I can see the entry in the database, and the database isn't locked or anything either.
I can't seem to figure out how to show logging either for diagnostics
I've tried:
python manage.py process_tasks -v 3 --log-std
hoping to get some sort of response, but it hangs there as well with the blinking cursor.

Nevermind, found the issue in a bad import that wasn't caught by IDE or Django at runtime.
Wish there was logging though, since it took forever to trace this down.


Why not implement this as a directive ?

Since all this does is add a new type of event, I think it is better suited to be a directive (v-resize for example) instead of a component. That way, you can attach it to any element in the page with less visual clutter.

At first, I though it would be impossible since you need the additional elements (

) but this script  seem to work on any element and create the additional element needed without modifying/breaking the original element.
Why this choice ? Am I missing something ?
Thank you.

I agree that it could be very convenient to have a directive. resize-sensor needs to add an element inside the container you are watching for resizing. This mean that all element are not suitable for this operation.
For example,  will fail.

Well, maybe add a warning for the edge cases ? They could still do something like that:

Well, that was just my two cents, good luck for the future 👍


Feature: Monitored transitions

Hey everybody!
I tried to implement something with godot-statecharts and it did not work how I imagined it.
So I debugged everything and read through the documentation a little bit.
In the code I found that transitions are only evaluated on entering the state or a relevant event was send.
I  also found in the documentation statecharts.dev/guard the following paragraph:

Guard functions are often called while processing an external event so this must obviously be possible.  However, the statechart should be allowed to check any guard at any time, i.e. also while not processing any event.  This is to allow the author of the statechart to be free to use things like delayed events or delayed transitions.

I interpret it that a guard should be able to be checked an any time.
So I implemented it as an optional feature that the user can choose if the transition will be checked every frame.
I found a small problem with my implementation and fixed it here https://github.com/derkork/godot-statecharts/commit/a603e7d4e1b2cdc7b74ae5d7ade6bc56b1ba0ffe but that does not feel good in the current state how I implemented it.
The result worked how I imagined it, so I created a small demo to show the new functionality in action.
I hope this fits into the vision of this project!
Feel free to edit it as you please or suggest stuff that I should change, rename or delete!

@Deslucir, thanks a lot for taking the time to send a PR! I am not sure if I understand the feature correctly though. If the goal is to have transitions that are checked per frame, you can already have this. Let your transition listen to a "tick" event and then just send a "tick" event every frame to your state chart, e.g.
func _process(delta):
   state_chart.send_event("tick")

Could you also give me some more information about the use case behind this feature? In general I feel polling for a condition is something one wants to avoid if possible, so I wonder if this could actually be better done with some signal rather than checking for a condition every frame.

I'm closing this as it has been dormant for a while.


High level roadmap for v0.0.1

[x] create projects
[x] #64
[x] fetch metadata regarding projects
[x] fetch outputs of projects like SBOMs, SLSA, etc.
[x] adopt existing projects into a local cache, i.e. allow Alice’s Skootrs to become aware of projects Bob’s Skootrs created assuming Alice has at least read access - Almost done
[x] #65
[x] #66

Finished!


fix: capturing listeners remain registered after unmount

Wow great!
Would you have an idea on how to write a test for this? I actually tried to test this but there is no way in JS to know if an element has a certain event attached to it. So I couldn't find a way to test this properly.

Probably can use dispatchEvent and check that the spied function will not be called
const element = document.getElementById("simplebar");

const init = SimpleBar.prototype.init;
SimpleBar.prototype.init = () => {};

const simpleBar = new SimpleBar(element);
simpleBar.init = init;

jest.spyOn(simpleBar, 'onPointerEvent');
simpleBar.init();

simpleBar.unMount();

element.dispatchEvent(new MouseEvent('mousedown'));

expect(simpleBar.onPointerEvent).not.toHaveBeenCalled();


Handling calls in map page

The calls are not properly handled in the map page. Add support to the following features:

Visually tracking the stage of the calls
Displaying patient information
Displaying multiple waypoints
Showing/hiding waypoints
Handling declined calls

2,3 and 4 are done.


add specs that test if views render

This adds rspec tests to all views confirming that they render without error.
Most views can be tested using the shared example 'renderable view'.  However, the new media views (audio#new, video#new, image#new, and document#new) require a special shared example that stubs out the s3form.  This form is rendered through the s3_browser_uploads gem, and seems to require a fair bit of logic to test - so I am thinking that testing whether or not the s3form renders may be out of scope for this PR.
This also removes a statement from spec_helper that explicitly loads view specs.  I had added this back in PR#21 because view files hadn't been loading when we ran rspec.  But upon further local testing, it seems that this line is not needed, and is, in fact, causing the view specs to run twice.
This addresses ticket #8208,

:+1: rebase?

@anarchivist rebased.


Document OS X limitations with inject-tcp method

Hey there, really appreciate this tool! We're hoping to use it to revamp the development of our services and it seems really promising.
While setting this up I ran into a pretty big pitfall around the interaction between the inject-tcp method and OS X's System Integrity Protection feature. I was thinking it might be worth documenting this to save other people some time when setting this up.
It looks like in OS X El Capitan Apple introduced a feature called System Integrity Protection (SIP). This feature prevents, among other things, code injection into processes that originate from certain designated "protected directories" (including /usr and /bin). This includes purging dynamic linker environment variables for these processes. These protections are in place even when running as root. They can only be disabled by booting into recovery mode, and disabling them is highly discouraged.
It turns out that in practice it can be really hard to prevent some types of processes from at some going through a protected binary. We're using Telepresence to swap out services for a locally built version and build tools very frequently invoke shell scripts (which either directly invoke something like /bin/sh or indirect through/usr/bin/env, both of which are protected). Also in the Node world any "executable module" typically is actually a script starting with #!/usr/bin/env node.
We can't use the vpn-tcp method (being able to swap only one service at a time is a non-starter for us), so I'm planning on working around this in a fairly hacky way (adding hosts entries for our service names that point to the cluster). This hopefully won't actually be too bad since it will also eliminate some of the other drawbacks to the inject-tcp method (statically linked binaries and such), but I'm curious if anyone else has run into this and worked around it in a different way.

Thanks for the detailed information. This is a great starting point for improved documentation.

The methods documentation would benefit greatly from having more information about Mac-specific limitations. I can start by adapting what you posted above, but we could use your help!

We have some ideas about how Telepresence could proxy multiple services to the local machine with the vpn-tcp method, at least under certain circumstances. I'd like to understand your use case a little more clearly so I can focus my initial efforts. Would it be okay to pick up a phone call, chat in Gitter, or something along those lines?

Just to clarify, Telepresence attempts to work around SIP to some extent by creating duplicates of /bin, /usr/bin, etc. and putting those in the PATH instead of the SIP-protected originals. This allows the user to type something like env ENABLE_FROBULATE=1 ./my_binary and get the benefits of inject-tcp. What does not work is running a tool or script that has a full path to /bin/sh or /usr/bin/env or similar, since Telepresence cannot manipulate those commands when located in those protected directories.

I updated the docs in 46a020f based on your detailed write-up. Thanks again.


When computing cache keys, be more strict about checkint the module name

We want to skip hashing any called functions that are defined by triton itself, but some users put their kernels in directories named "triton", which confuses this check.  Since apparently triton is sometimes installed as a submodule (really?) we try to figure out the "root" name of the triton module and look for that instead.

not sure why but this is failing H100 😅

Is it to prevent cache rebuild when the triton itself is upgraded? Or am I missing something?

IIRC Triton already includes its own files when hashing, through a different mechanism.

Super embarrassing one character typo (I meant -len, not len -- it was a copypaste error while moving from the FB internal fork).  It's actually kind of surprising only the H100 test suite caught it, since nothing should have worked :-p

Super embarrassing one character typo (I meant -len, not len -- it was a copypaste error while moving from the FB internal fork). It's actually kind of surprising only the H100 test suite caught it, since nothing should have worked :-p

Thanks! BTW failures would have happened on A100 as well most likely but when something fails it stops other tests and usually H100 machine is faster.

Hey @ThomasRaoux, any chance to get this merged now that the tests pass?  Thanks!


create pool, unable to click on any of the left pane steps (optional), typo

@julienlim @sankarshanmukhopadhyay "Advanced Configuration" tab options depend on the some of the options selected in "Basic settings" tab. For example -

Minimum Replicas is only applicable for Standard/Replicated Pools. The Pool type is selected in "Basic settings" tab.
Minimum Replica value cannot be greater than Replica value. Again the Replica is being selected in "Basic settings" tab.

Hence we have disabled direct selection of left pane steps. User can proceed only by clicking "Next" button.

@Tendrl/qe Fixed. Please verify in tendrl-dashboard-1.2.1-04_17_2017_17_24_12.noarch.rpm

Able to click on the left pane steps now. @julienlim please have look and let us know so that we can close the issue

@nthomas-redhat @gnehapk I verified that the User is able to click the left pane now.


Set up CI that tests the CLI

This issue will probably need to be split for the different subcommands

hyperfine may be of interest.

Just as a note, I edited Jan's original message as part of my issue-pass in https://github.com/TheBevyFlock/bevy_cli/issues/34.


Update ValueError raised when storing non-integer in index

This fixes the issue mentioned the equivalent issue mentioned here in the FRAM library:
Also, updates example to use correct indexes as fixed with PR #1

Thank you, I did not check this pull request yet, but:
(1) This week-end I was hit by the "ValueError" message and a bit confused by the wording. I was actually trying to convert my value that was int already into a byte or single byte byte array. So any hint on the proper usage would have saved me a little bit of time there
(2) I feel the example code should do read and comment out the write, I am always afraid to wear out technology I don't know very well and I don't know the writing live span. But your removal of the while loop is welcomed.
(3) Your last part would fix #2
Maybe part of this pull request you would like to chasse from this file all the reference to FRAM as mentioned in #5 .
I can make a separated PR, but it always confuse me when more than one PR is pending and they could conflict with each other.

Hey @dglaude yeah, that error text comes from my somewhat recent PR to the FRAM library this was based on, so I wanted to make sure that any updates pertaining to both get addressed.  I tried to only update things that were in the scope of that (and also making sure the test code ran) but don't want to get in @FoamyGuy's way too much because I know this repo is still WIP. :) I'm sure the FRAM references will be changed as the library develops.

Commenting out the write in the sounds good to me, much appreciated if either of you want to make a separate PR for that.
We will get the references to "fram" removed before any official releases are made.
Learning that this library works with other EEPROM breakouts makes me think we might actually want to have Adafruit_CircuitPython_EEPROM library instead of the current more specific Adafruit_CircuitPython_24LC32. That would make the name of the library a little more general and we can have some different classes with the needed constants for different EEPROM breakouts that are available, and possibly allow user to pass in max_size as an init argument for use with other EEPROM devices not specifically included but that do happen to use the same communication protocol.
I've made a note for the "in the weeds" section of the meeting today to ask about the naming of this library so we can see what the team thinks and then create new repo or rename as needed. In the meantime I'll go ahead and merge this PR (and commenting write statements, or anything else that we want to do in the interim). If we do move to a new repo I'll copy over the latest version of this one to it so we start from the same spot.

Sounds like a plan!


Tests

Tests for the current Volume of code Written and merged in https://github.com/BdVade/DjangoRestAdmin/pull/12


Disallow assignment expressions in parameter defaults

See https://github.com/puppetlabs/puppet/pull/3830.
Prior to evaluating the default's expression, we need to check the expression for containing an assignment expression.

This has been ported to JIRA as NPUP-7.


Selective content partial

Hello! I'm trying to make a Flyer-component which in turn uses the Ractive fly plugin. What i'd do with React is something like this:
<Flyer>
  <Fly>Page1</Fly>
  <Fly>Page2</Fly>
  <Fly>Page3</Fly>
</Flyer>

and depending on which Fly is "active" i'd only show that Fly from this.props.children in the Flyer component. However in Ractive we've got the {{>content}} partial which shows all the passed content. What i want is to only show some of the passed content(e.g. one page at a time)
E.g. when pressing on a link that says "Page 1" i want the Flyer to only yield the first(Page 1) Fly
Versions affected:
0.7.3
This probably isn't a bug and maybe there's a solution to it but from the docs alone i couldn't figure this one out! Is there a way to just extract a part of the content partial?

You can use named partials (see https://jsfiddle.net/kho3s3jd/):
<Flyer active='{{active}}'>
  {{#partial page1}}
  <Fly>Page1</Fly>
  {{/partial}}

  {{#partial page2}}
  <Fly>Page2</Fly>
  {{/partial}}

  {{#partial page3}}
  <Fly>Page3</Fly>
  {{/partial}}
</Flyer>

And access them directly:
{{#if active === 'page1'}}
	{{>page1}}
{{/if}}
{{#if active === 'page2'}}
	{{>page2}}
{{/if}}
{{#if active === 'page3'}}
	{{>page3}}
{{/if}}

This works with both {{>name_of_partial}} partial passing and "yielded" (runs in parent context) partials: {{yield name_of_partial}}
If you're looking for something more dynamic, I'd use a dynamic component.

Hmm... Well, because of the named partials i guess it's possible with some workarounds. So although this might work but it will be extra code for the developer that is using of the component. I don't necessarily want to name the components, just be able to have an array of elements that were passed as children to my component so that i can loop through them and display the correct index depending on which page/fly the user navigated to.
I'll put some more psuedo-code of what i want to do. As a user i want to specify pages in the flyer like this:
<Flyer>
  <Fly>Page 1 that flies in when navigated to</Fly>
  <Fly>Page 2 that flies in when navigated to</Fly>
</Flyer>

In Flyer.js i would listen to when the selected index changes(aka user navigated to another page/fly):
onIndexChange: function (idx)  {
  // Set the current fly to the child with the navigated index...
  // However AFAIK there is no "this.children" concept
  this.set('currentFly',  this.children[idx]);
}

and in Flyer.html:
{{each children:i}}

    <currentFly />

{{/each}}

Is there any clean way to solve something like this or do i have to force the users of the component to write named partials for each fly?
Thanks for your quick response @martypdx

I think this is the closest you can get to what you described:

{{#if visible}}

        {{>content}}

{{/if}}`

{{>content}}

// Flayer
this.observe('active', (active) => {
    this.findAllComponents('Fly').filter((page) => {
        return page.parent === this;
    }).forEach((page, index) => {
        page.set('visible', index == active);
    });
});

Demo here:https://jsfiddle.net/dd84skdf/1/

@MartinKolarik This is exactly what i wanted and your assumption about the Fly component being defined by me is also correct. Hooray! :+1:
Thanks a lot. It's kind of difficult to figure out how to do after using React but this snippet made it easy to understand how to do something similar in Ractive!

@MartinKolarik This is exactly what i wanted and your assumption about the Fly component being defined by me is also correct. Hooray! :+1:

Good to hear that!


Don't release fallback resources not yet provisioned

In some circumnstances the client may decide to prematurely release a resource while the underlying provider was not yet invoked.
For fallback resources this means trying to delete a non-existent instance, thus the reconcile loop will remain stuck in the cleaning state due the failing delete (and the CIR resource locked).

/lgtm


Inability to reset/resume

I'm not a programmer, just an end user. Nosta was awesome in the beginning -- looks great, super-easy to use moving me through the steps. However, it froze up at the "saving" stage, and now I'm stuck in a catch-22.
It thinks I have a profile -- sort of -- and keeps me logged in, but it can't display anything because there isn't anything to find. But since it knows I've already been here and worked through the process, I can't back up or start over, so I can't fix whatever got broken.
And I can't tell what was or wasn't successful. It generated both keys for me, so theoretically I have those. But having now also spent a good deal of time trying to get set up with Nostr through other clients, it doesn't look like the private key Nosta generated is in a correct format.
Glitches happen, but the fact that there's no way to start again or pick back up where it left off is problematic.

Hi there, thank you for letting me know about the problem. Could you please share your public key (npub) with me so I can can do a few checks? It will allow me to see if any of your profile data was posted to the network.


timing: clarify identifier names.

Also added a commit for removing the misleading decimal places in the diagnostics timing screen.


Self closed custom elements

I get the following error: "Only void and foreign elements can be self closed".
<script>
  import Test from './Test.svelte';
</script>

<Test />

Turned out Svelte VSCode extensions was not working correctly due to
"files.associations": {
    "*.svelte": "html",
}

in my settings.


Make preferences collapsable and collapsed by default

Make preferences collapsable and collapsed by default, section by section (Nutritional quality, Food processing…), since they are very long to scroll, and most users won't care scrolling through all the allergens.

Preferences are already collapsable. But the default is the expanded display. It will be easy to make the collapsable display the default.

Preferences are already collapsable. But the default is the expanded display. It will be easy to make the collapsable display the default.

ooh good catch. Adding down arrow would make it more discoverable

ooh good catch. Adding down arrow would make it more discoverable

Adding down arrow would make it more discoverable

Fair enough, I'll do that too.

Adding down arrow would make it more discoverable

Fair enough, I'll do that too.

@teolemon Fixed in #111

@teolemon Fixed in #111


sort output by fields

It would be great if output is sorted according to the order of fields.

I think your opinion is right.
I might implement this feature in next version.
But now you can sort output with UNIX tool sort :)


Simplifying node hierarchy: Removing addChild/removeChild

Description
A part of the node generator/plugin functionality is to add and remove LayoutNode objects to node data/state. This functionality is removed here, and replaced by a simpler approach; just storing the IDs of target nodes in the store, and then using hooks like useNode() if objects are needed.
This removes some code and complexity, reduces run-time and memory allocation as a result, and prevents problems like #2662 from happening again. It also moves us in a slightly simpler direction, where the node generator can hopefully be written out of existence in the future.
Bullet points detailing the changes:

Most of the code changes here are to work around children-like states now having strings (node IDs) instead of LayoutNode objects. Sometimes this includes splitting up components so that we can use hooks like useNode(). Often it also changes code from calling GenericComponent to instead call GenericComponentById.
I changed the return type for useNode() to possibly return undefined in all cases. Previously it would seem like you'd always get a LayoutNode if you gave this thing a string, but that's not guaranteed.
I split off some functionality in useNavigatePage(), as it caused re-rendering which lead me to the test failure that showed that useNode() should have indicated that it could return undefined all along.
Child claim metadata is removed, as it was only used when passed to addChild() and removeChild().
Adding a concept of idMutators which is passed to plugins. Mutatators like this are used to mutate child component IDs (turning currentName into currentName-0).
The Likert component did not correctly maintain row UUIDs. This is usually not a problem, as the use-case for that component calls for mostly static rows in the data model, but it could break if used dynamically. Added a MaintainReferences component to maintain this.

I brought back the isFresh functionality to RepeatingGroupTableRow, as removing it in #2715 caused the broken test there.
Repeating groups gets a hacky internal state in item. This is used to keep track of which child-ids should be added to the component after a row is added. This state cannot be stored in the RepeatingChildrenPlugin class instance, as that is shared among all RepeatingGroup components.
Removing the setRowUuids queue, as it does the same thing as setRowExtras.
Preventing MarkPageHidden from re-rendering when the current page changes (by introducing useIsCurrentView() and making sure it doesn't set state that was already set).

Related Issue(s)

#2683
closes #2662

Verification/QA

Manual functionality testing

[x] I have tested these changes manually
[ ] Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
[ ] No testing done/necessary

Automated tests

[ ] Unit test(s) have been added/updated
[ ] Cypress E2E test(s) have been added/updated
[x] No automatic tests are needed here (no functional changes/additions)
[ ] I want someone to help me make some tests

UU/WCAG (follow these guidelines until we have our own)

[ ] I have tested with a screen reader/keyboard navigation/automated wcag validator
[x] No testing done/necessary (no DOM/visual changes)
[ ] I want someone to help me perform accessibility testing

User documentation @ altinn-studio-docs

[ ] Has been added/updated

[x] No functionality has been changed/added, so no documentation is needed
[ ] I will do that later/have created an issue

Support in Altinn Studio

[ ] Issue(s) created for support in Studio

[x] This change/feature does not require any changes to Altinn Studio

Sprint board

[x] The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
[ ] I don't have permissions to do that, please help me out

Labels

[x] I have added a kind/* label to this PR for proper release notes grouping
[ ] I don't have permissions to add labels, please help me out

Some snapshots in Percy are worrying - I'l look into that first before requesting review.


Latest main doesn't compile on windows

Running :NfnlCompileAllFiles gives this:

I'm not sure whats going on here, but no matter what I set source-file-patterns to, I can't seem to get nfnl to compile anything.
Any hints how to debug this further?

The double backslash stood out to me. So I manually changed the backslash in fs.lua to a forward slash (obviously this would get changed in a more reasonable way in the future) and things are working normally again. All of the files get compiled as expected.
Was the double backslash returned at some point from nvim filesystem apis and the file separator selected to address that at some point in the past?

Mmmm or at least making that change fixed the manual compilation via NfnlCompileAllFiles but it seems like the autocmd is not running properly. At the very least that issue is a clue

I reverted to https://github.com/Olical/nfnl/commit/9c54c2cfd4a3e3eac43473c6fe8fcfb15874e6c4 and things are working as expected

Hey! Sorry I was away last week! Sorry about the issue but thanks for giving this context, that \ is coming from inside nfnl since we use OS local path separators in all paths, or at least we should...
So in the nfnl.fs module there's a path-sep function that returns a forward or backslash depending on the OS. We use that in a few places but also in the split and join path functions.
I suspect a Neovim API is returning a forward slash path somewhere and I'm mixing it with a backslash path. And maybe with all of the APIs I'm using I just need to use forward slashes in Windows? Although that feels like a dangerous assumption.
I wonder why some of your paths have forward and some have backward. I definitely needed to use the right separators in Aniseed / Conjure which is why this logic is here at all, it was to support Windows. I just wonder if the APIs I'm using now don't need that conversion.
I'll look into this, just wanted to ack it first.

I was using the nightly build three days ago, autocmd failed to work like #32, than I updated the nightly build again two days ago, autocmd works fine.

I tested NfnlCompileAllFiles, it works fine.

NVIM v0.10.0-dev-2539+ga69c72063
Build type: RelWithDebInfo
LuaJIT 2.1.1707061634

nfnl @ 92f03c0

Here's my .nfnl.fnl:
{:source-file-patterns ["fnl/**/*.fnl" "fnl/*.fnl" "*.fnl"]
 :compiler-options {:compilerEnv _G}}

I updated to the newest nvim nightly and am getting very strange results.
NfnlCompileAllFiles continues to give the issue I see above.
Weirdly the autocommand seems to compile once. So the first change I make and save in a fennel file will get compiled but after that no further compilation happens.
I'd be happy to debug some of this further myself, but I'm sorta at a loss for where to start.

I updated to the newest nvim nightly and am getting very strange results. NfnlCompileAllFiles continues to give the issue I see above. Weirdly the autocommand seems to compile once. So the first change I make and save in a fennel file will get compiled but after that no further compilation happens.
I'd be happy to debug some of this further myself, but I'm sorta at a loss for where to start.

You can use :autocmd BufWritePost to check nfnl's autocmds bound to the right buffer ID like in #32.
My output of :echo fnamemodify(stdpath('config'), ':p') is C:\Users\unco\AppData\Local\nvim without forward slashes.
You can check it with :verbose set shellslash?.

Sorry about the delay! Had a lot on recently. So the autocmd thing is SUPER weird and should never happen, that's not how autocmds work, they exist until cleared. So something else must be at play here... I'll need to investigate.
What I'm seeing here is that despite being on Windows, almost all of your paths are / based, not \ based... which is not how I thought Windows paths worked which is why nfnl tries to respect your OS paths.
The paths in the original issue report show / for almost all segments then a \ for the one segment where nfnl has joined two paths together and selected a path separator based on your OS.
So do ALL paths you see in Neovim use forward slashes like Unix? I know I absolutely needed to do this smart slash selection in Conjure when interacting with the filesystem, so why is that not required in this case? Is it maybe a Windows setting or a Neovim one?
I'm worried if I just remove the smart slash selection it'll fix your issue and break some other Windows user's experience 🤔

And if you look at @UnderCooled's screenshot, they're all backslashes! So @Kethku, are you under WSL or something? Or even some sort of bash / unix-y environment under windows when @UnderCooled is under pure Windows with no Unix-y layers?
I don't know the Windows developer landscape so I think I need some more context and guidance here wrt Windows paths and how they can vary. I want to help, just need some more info. I'll see if I can work out what's going on with that autocmd too, that should never happen.

It's also worth noting that things like source-file-patterns need to match the path separator your OS uses because it needs to match the file paths that Neovim reports to nfnl. The default nfnl provides for you will use your OS path separator, so if you override the default, make sure you use your OS local path style.
The default value is built from ["*.fnl" (fs.join-path ["**" "*.fnl"])], so you could use fs.join-path as well to get the same automatic behaviour if you need portable config that works on Windows and Linux.

Oh, @Kethku, do you have vim.opt.shellslash set?

Okay, if you DO use it (it explains the / on Windows!) then nfnl should support it now. I hope. I still don't know what's going on with the autocmds though, those work just fine for me, maybe another windows thing?

I'm so sorry I just realized you responded. I missed the notification.

So do ALL paths you see in Neovim use forward slashes like Unix?

Hitting 1<c-g> prints with backslashes.
Executing :lua print(vim.fn.getcwd()) prints with forward slashes.

So @Kethku, are you under WSL or something?

Nope! I'm running windows 11. No wsl and no configuration that I can think of that would cause this.

Oh, @Kethku, do you have vim.opt.shellslash set?

Ok weirdly this is being set by some plugin in my config. Very frustrating because I assumed it wasn't since I don't set it myself. Regardless though I pulled the latest version and it looks like that fixed the path issue!
However I'm still getting the autocmd only running once. Shall I create a new issue for that?

I am updated to current main though which means the fix for shellslash seems to not have worked. This isn't an issue for me now that I've removed the shellslash option, but its probably worth tracking down

I have uploaded a repro config here: https://github.com/Kamholtz/nfnl-aucommand-bug-repro/tree/main
The README.md shows the steps taken to reproduce the issue on a recent nightly build, and compares it to the working behaviour on the latest stable build.

Incredible reporting! Thank you so much! So this is two issues really, one was that I didn't take shellslash into account and the other is that on Nightly the autocommand vanishes after it executes. That to me sounds like a Nightly Neovim bug and not something I should work around because that's just not how autocommands work. I'm going to have a poke through the Neovim repo, if this is happening to many autocmds this should be a huge deal there in the issues.
At least we have one issue fixed and I understand Windows + Neovim path shenanigans a little better than I did before. I'm trying to abstract path stuff away so bugs like this won't happen again + other users of nfnl things get to lean on nfnl.fs which hopefully means all systems built on nfnl can benefit from these lessons.

I can reproduce the autocmd vanishing on nightly after one run! I see no issues open in the Neovim repo that seem relevant (although I may have missed it). Now to determine if all autocmds are broken, all BufWritePost are broken or if it's just the nfnl one and then why. Maybe it's the name I'm giving it that Nightly doesn't like which is why others haven't run into this bug. And I do think it's a bug.
I checked if the default in the Lua API changed so once=true by default, but nope, it's the same!

FOUND IT. It's a Neovim bug. If a callback to an autocmd returns a Lua value like a table then the autocmd is removed, if I return nil it fixes the issue. I think I'll raise a Neovim bug I guess?

Pushed a fix to main.

https://github.com/neovim/neovim/issues/28127 issue here

So apparently that's a feature! Not sure when it was added, maybe it was always this way? But if an autocmd callback returns anything other than nil or false it will be deleted. News to me but now we know, I'll make sure none of my autocmd callbacks return something truthy, I do worry this will break Conjure in a bunch of places too and I need to go hunt through my callbacks now 😭
Thanks for these in depth reports and I hope my change fixes things for you!

Ah, on like 126 of :help news
• Returning any truthy value from a callback passed to |nvim_create_autocmd()|
  (rather than just `true`) will delete the autocommand.

I would've struggled to find that myself and this should probably be marked as a breaking change in my opinion but ¯\_(ツ)_/¯

I also think that API is unintuitive and smells like "boolean flag changing behaviour of functions", shame but I'll work around it from now on.

I've realised why this isn't a big deal for most people! In Fennel we have implicit returns, in Lua it's nil by default! So all pure Lua code gets nil unless they explicitly return something, Fennel code always returns the last thing so we have to opt OUT.
So, for Fennel users, be careful about what your autocmd callbacks return.

Wow, that's a real gotcha for fennel users. I have confirmed that the latest main has resolved the problem for me. Thank you!

Amazing. Thanks so much for the in depth investigation <3


Question for Xeditable

Hi @tiliv, I really would like to know if there is any possibility to have a validation for xeditable inputs, or any workaround making it possible to use make_xeditable with helper function (i.e 'through',  or any custom functions same as we utilize with helper function). thanks in advance for the answer.

I'd also like to know this, have you heard anything back from the dev team?
As of now I plan on adding those features from scratch somehow.

No, unfortunately not yet. I have added model level validation as a workaround.

We'll have to look at that for 1.1 and tie it to the view with a form class.  We do use a form class internally, but it's a pretty dynamic affair.  There should be something we can set up to make the situation easier to handle.


[WIP] [#100214390] Email Clarification Questions from "updates" page

Still waiting on Roz's copy edits, but feel free to code review in the meanwhile.
This pull request adds in an 'G-Cloud 7 updates' page from which a logged-in supplier can ask a tender question.
Empty questions are prohibited, as are questions that are too long (500+ words or 5000+ characters), but anything else is allowed.
The actual email address we're sending to is stored behind a new DM_CLARIFICATION_QUESTION_EMAIL config variable so that we don't have any meddlesome troublemakers asking lots of questions illicitly.
Needs the Mailchimp API key before it properly sends emails.
Lists of documents (based on Ralph's prototype) are quite rough still, but the skeleton is more or less in place.
Anyway, @quis said he'd look at it.
>> Story on Pivotal

G-Cloud 7 updates page

More screenshots once on-screen messages are approved

I've looked at it and made a few changes.

@superroz Current messages in need of review are:

Error
Current message

No question
Question cannot be empty

Question (way, way) too long
Question cannot be longer than 5000 characters

Email sent
Message sent. Cheers.

System falls over
Clarification question email failed to send


Changes for Handling the Total Calorie burned in Aggregate function

Yes @quentinleguennec while getting the data for TotalCaloriesBurnedRecordEnergyTotal, it is not of specific type which we are expecting in method channel and that is throwing error, I am not sure of other data which have similar issue, I've faced this in this particular Health Data.


Problem in Catkin build

Hello Guys,
I am participating in the Virtual challenge ( First time). After installing ROS and following the steps given in https://github.com/BCLab-UNM/SwarmBaseCode-ROS , I cloned the git repository . While I tried to catkin build , I am getting some error. Kindly help.
The error I am getting is as shown below. Please let m know if I am missing something or doing something wrong. Thanks in Advance.
=================================================================================
dexter@Gireesh-XPS: ~/SwarmBaseCode-ROS$ catkin build
Profile:                     default
Extending:          [cached] /opt/ros/kinetic
Workspace:                   /home/dexter/SwarmBaseCode-ROS
Source Space:       [exists] /home/dexter/SwarmBaseCode-ROS/src
Log Space:          [exists] /home/dexter/SwarmBaseCode-ROS/logs
Build Space:        [exists] /home/dexter/SwarmBaseCode-ROS/build
Devel Space:        [exists] /home/dexter/SwarmBaseCode-ROS/devel
Install Space:      [unused] /home/dexter/SwarmBaseCode-ROS/install
DESTDIR:            [unused] None
Devel Space Layout:          linked
Install Space Layout:        None
Additional CMake Args:       None
Additional Make Args:        None
Additional catkin Make Args: None
Internal Make Job Server:    True
Cache Job Environments:      False
Whitelisted Packages:        None
Blacklisted Packages:        None
Workspace configuration appears valid.
[build] Found '14' packages in 0.0 seconds.
[build] Package table is up to date.
Starting  >>> abridge
Starting  >>> apriltags
Starting  >>> diagnostics
Starting  >>> gazebo_plugins
Starting  >>> sbridge
Starting  >>> swarmie_msgs
Starting  >>> ublox_serialization
Starting  >>> usb_cam
Finished  <<< ublox_serialization                [ 0.1 seconds ]
Starting  >>> ublox_msgs
Finished  <<< abridge                            [ 0.2 seconds ]
Finished  <<< usb_cam                            [ 0.2 seconds ]
Finished  <<< apriltags                          [ 0.2 seconds ]
Starting  >>> apriltags_ros
Finished  <<< gazebo_plugins                     [ 0.3 seconds ]
Finished  <<< sbridge                            [ 0.3 seconds ]
Finished  <<< diagnostics                        [ 0.7 seconds ]

Errors     << swarmie_msgs:make /home/dexter/SwarmBaseCode-ROS/logs/swarmie_msgs/build.make.008.log
Traceback (most recent call last):
File "/opt/ros/kinetic/share/gencpp/cmake/../../../lib/gencpp/gen_cpp.py", line 41, in
import genmsg.template_tools
File "/opt/ros/kinetic/lib/python2.7/dist-packages/genmsg/template_tools.py", line 39, in
import em
ModuleNotFoundError: No module named 'em'
make[2]: *** [/home/dexter/SwarmBaseCode-ROS/devel/.private/swarmie_msgs/include/swarmie_msgs/Waypoint.h] Error 1
make[1]: *** [CMakeFiles/swarmie_msgs_generate_messages_cpp.dir/all] Error 2
make: *** [all] Error 2
cd /home/dexter/SwarmBaseCode-ROS/build/swarmie_msgs; catkin build --get-env swarmie_msgs | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
..............................................................................................................................................................
Failed     << swarmie_msgs:make                  [ Exited with code 2 ]
Failed    <<< swarmie_msgs                       [ 0.4 seconds ]
Abandoned <<< behaviours                         [ Unrelated job failed ]
Abandoned <<< rqt_rover_gui                      [ Unrelated job failed ]
Abandoned <<< ublox_gps                          [ Unrelated job failed ]

Errors     << apriltags_ros:make /home/dexter/SwarmBaseCode-ROS/logs/apriltags_ros/build.make.005.log
Traceback (most recent call last):
File "/opt/ros/kinetic/share/gencpp/cmake/../../../lib/gencpp/gen_cpp.py", line 41, in
import genmsg.template_tools
File "/opt/ros/kinetic/lib/python2.7/dist-packages/genmsg/template_tools.py", line 39, in
import em
ModuleNotFoundError: No module named 'em'
make[2]: *** [/home/dexter/SwarmBaseCode-ROS/devel/.private/apriltags_ros/include/apriltags_ros/AprilTagDetection.h] Error 1
make[2]: *** Waiting for unfinished jobs....
Traceback (most recent call last):
File "/opt/ros/kinetic/share/gencpp/cmake/../../../lib/gencpp/gen_cpp.py", line 41, in
import genmsg.template_tools
File "/opt/ros/kinetic/lib/python2.7/dist-packages/genmsg/template_tools.py", line 39, in
import em
ModuleNotFoundError: No module named 'em'
make[2]: *** [/home/dexter/SwarmBaseCode-ROS/devel/.private/apriltags_ros/include/apriltags_ros/AprilTagDetectionArray.h] Error 1
make[1]: *** [CMakeFiles/apriltags_ros_generate_messages_cpp.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
cd /home/dexter/SwarmBaseCode-ROS/build/apriltags_ros; catkin build --get-env apriltags_ros | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
..............................................................................................................................................................
Failed     << apriltags_ros:make                 [ Exited with code 2 ]
Failed    <<< apriltags_ros                      [ 0.8 seconds ]

Errors     << ublox_msgs:make /home/dexter/SwarmBaseCode-ROS/logs/ublox_msgs/build.make.007.log
Traceback (most recent call last):
File "/opt/ros/kinetic/share/gencpp/cmake/../../../lib/gencpp/gen_cpp.py", line 41, in
import genmsg.template_tools
File "/opt/ros/kinetic/lib/python2.7/dist-packages/genmsg/template_tools.py", line 39, in
import em
ModuleNotFoundError: No module named 'em'
make[2]: *** [/home/dexter/SwarmBaseCode-ROS/devel/.private/ublox_msgs/include/ublox_msgs/AidALM.h] Error 1
make[2]: *** Waiting for unfinished jobs....
Traceback (most recent call last):
File "/opt/ros/kinetic/share/gencpp/cmake/../../../lib/gencpp/gen_cpp.py", line 41, in
import genmsg.template_tools
File "/opt/ros/kinetic/lib/python2.7/dist-packages/genmsg/template_tools.py", line 39, in
import em
ModuleNotFoundError: No module named 'em'
Traceback (most recent call last):
File "/opt/ros/kinetic/share/gencpp/cmake/../../../lib/gencpp/gen_cpp.py", line 41, in
import genmsg.template_tools
File "/opt/ros/kinetic/lib/python2.7/dist-packages/genmsg/template_tools.py", line 39, in
import em
ModuleNotFoundError: No module named 'em'
make[2]: *** [/home/dexter/SwarmBaseCode-ROS/devel/.private/ublox_msgs/include/ublox_msgs/AidHUI.h] Error 1
Traceback (most recent call last):
File "/opt/ros/kinetic/share/gencpp/cmake/../../../lib/gencpp/gen_cpp.py", line 41, in
import genmsg.template_tools
File "/opt/ros/kinetic/lib/python2.7/dist-packages/genmsg/template_tools.py", line 39, in
import em
ModuleNotFoundError: No module named 'em'
make[2]: *** [/home/dexter/SwarmBaseCode-ROS/devel/.private/ublox_msgs/include/ublox_msgs/AidEPH.h] Error 1
make[2]: *** [/home/dexter/SwarmBaseCode-ROS/devel/.private/ublox_msgs/include/ublox_msgs/CfgANT.h] Error 1
Traceback (most recent call last):
File "/opt/ros/kinetic/share/gencpp/cmake/../../../lib/gencpp/gen_cpp.py", line 41, in
import genmsg.template_tools
File "/opt/ros/kinetic/lib/python2.7/dist-packages/genmsg/template_tools.py", line 39, in
import em
ModuleNotFoundError: No module named 'em'
Traceback (most recent call last):
Traceback (most recent call last):
File "/opt/ros/kinetic/share/gencpp/cmake/../../../lib/gencpp/gen_cpp.py", line 41, in
File "/opt/ros/kinetic/share/gencpp/cmake/../../../lib/gencpp/gen_cpp.py", line 41, in
import genmsg.template_tools
import genmsg.template_tools
File "/opt/ros/kinetic/lib/python2.7/dist-packages/genmsg/template_tools.py", line 39, in
File "/opt/ros/kinetic/lib/python2.7/dist-packages/genmsg/template_tools.py", line 39, in
import em
import em
ModuleNotFoundError: No module named 'em'
ModuleNotFoundError: No module named 'em'
make[2]: *** [/home/dexter/SwarmBaseCode-ROS/devel/.private/ublox_msgs/include/ublox_msgs/CfgCFG.h] Error 1
make[2]: *** [/home/dexter/SwarmBaseCode-ROS/devel/.private/ublox_msgs/include/ublox_msgs/CfgGNSS.h] Error 1
make[2]: *** [/home/dexter/SwarmBaseCode-ROS/devel/.private/ublox_msgs/include/ublox_msgs/CfgMSG.h] Error 1
Traceback (most recent call last):
File "/opt/ros/kinetic/share/gencpp/cmake/../../../lib/gencpp/gen_cpp.py", line 41, in
import genmsg.template_tools
File "/opt/ros/kinetic/lib/python2.7/dist-packages/genmsg/template_tools.py", line 39, in
import em
ModuleNotFoundError: No module named 'em'
make[2]: *** [/home/dexter/SwarmBaseCode-ROS/devel/.private/ublox_msgs/include/ublox_msgs/CfgNAV5.h] Error 1
make[1]: *** [CMakeFiles/ublox_msgs_generate_messages_cpp.dir/all] Error 2
make: *** [all] Error 2
cd /home/dexter/SwarmBaseCode-ROS/build/ublox_msgs; catkin build --get-env ublox_msgs | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
..............................................................................................................................................................
Failed     << ublox_msgs:make                    [ Exited with code 2 ]
Failed    <<< ublox_msgs                         [ 1.2 seconds ]
[build] Summary: 7 of 13 packages succeeded.
[build]   Ignored:   1 packages were skipped or are blacklisted.
[build]   Warnings:  None.
[build]   Abandoned: 3 packages were abandoned.
[build]   Failed:    3 packages failed.
[build] Runtime: 2.3 seconds total.
dexter@Gireesh-XPS:~/SwarmBaseCode-ROS$

Solved the issue.
" pip install empy "

Solved the issue using " pip install empy "


Getting sac to work --- WIP

What this does
Try to get the sac running without errors. Several places made to improve:

Enhanced standard deviation clamping to prevent extreme values, ensuring stability in policy outputs.
Cleaned up code by removing unnecessary comments and improving readability.
Separated encoders for critic and actor in SACPolicy to enhance model performance.
Updated action selection method to use distribution mode for better inference.
Refactored critic forward pass to streamline Q-value calculations.
Improved temperature loss calculation and added comments for clarity.
Changed YAML configuration to switch observation type for keypoints evaluation.
-Modified action sampling in SACPolicy to use reparameterized sampling, ensuring better gradient flow and log probability calculations.
Cleaned up log probability calculations in TanhMultivariateNormalDiag for clarity and efficiency.

How it was tested
python scripts/train.py policy=sac_pusht_keypoints env=pusht +dataset=lerobot/pusht_keypoints

Thanks @Ke-Wang1017! Closed this issue as we used cherry-pick to review and integrate your commits to avoid huge commit history.


Build with Go 1.15

Changed

CI image to circleci/golang:1.15
CI machine to ubuntu-1604:202007-01
Python test to use runtime3.7 instead of runtime2.7

Removed

vendor directory
dead code for test using runtime2.7

TODOs:

[x] Ready to review
[x] Automated Tests
[ ] Docs

Merging this :+1:


ParserConfig is sometimes ignored

Environment

OS Version: Ubuntu 20.04
Source build, using tag sdformat12_12.0.0.

Description

Expected behavior: When I call sdf::Root::Load(my_filename, my_parser_config), I expect the ParserConfig that I passed in to be used for the entire parse.
Actual behavior: Sometimes, the ParserConfig::GlobalConfig() is used instead, especially for included files.

Steps to reproduce
Refer to the PR at https://github.com/RobotLocomotion/drake/pull/16791.  In that PR, I replace the GlobalConfig accessor function with a runtime exception.  Then, a bazel test //multibody/parsing/... shows that exception tripping, even though I've always passed a ParserConfig to every function that I've called.
The PR has a sdformat patch for the instances that I was able to find.  Check the file drake/tools/workspace/sdformat/patches/fix_broken_config.patch from that PR.  I'd appreciate if you could incorporate that patch upstream here.
There may be more instances lurking, but those were only the ones I found.
One way you could audit for more bugs beyond what I found is to momentarily mark the dangerous functions (the ones which locally default to the the GlobalConfig) as deprecated, and then run a build and inspect all of the deprecation warnings at the call sites.  Any call sites that have a _config argument in scope but don't pass it along are suspicious.

In related news, I think it's a mistake that the CustomModelParser signature does not pass the in-effect ParserConfig along to the user's custom parser.  As the user parses their nested model, they will also need to find files, look up URIs, check the warnings policy, etc.  The user can't just use the GlobalConfig because a different config might have been chosen for this parse.

one of the fixes from your patch has already been applied in #824; I'm taking a look at the other portions

I've applied your patch and some additional improvements in https://github.com/ignitionrobotics/sdformat/pull/883, though there is still some additional work to do. For testing, I made a test branch using your suggestion of deprecating parser.hh functions that don't use ParserConfig (https://github.com/ignitionrobotics/sdformat/commit/34383d5c655eb54930d23c2780828d20b9f4f459).

another follow-up in #885


How to use the same Anonymous user?

I want a guest user to login, and create only 1 new user on my auth db.
Problem-
-On Unity editor- A new anonymous user is created with each launch of the app
On Android the guest user stays logged in but when the app is uninstalled- then another new anonymous user is created
My db is just full of anonymous users.
Note- I do use- and check monitoring authentication state
How can I prevent it from creating multiple users?  I was even thinking about login with a custom token, and save it on the user's device-  but then I need to create my own uid on the admin side and not sure if it's reliable or even a good solution?
The web has so many similar questions and frustrated developers and it seems like Firebase doesn't give a proper solution for that. You'd think it's basic. Am I missing something?

Can you tell me a little more about your use case?
On Android, do you want a person to always use the same anonymous account, even across uninstalls and re-installs? If so, I don't think there's a good solution built in for this. Persisting an anonymous account across uninstalls would be difficult to do. If you really want this you'd need to have a way of uniquely identifying a device. If your goal is to avoid creating a new anonymous accounts when testing your unity app, I'm pretty sure that installing over the existing APK without uninstalling it first will preserve the anonymous account you've already created (assuming you're signing with the same key). If Unity is uninstalling the existing APK during the upload process there's also the option of using the adb command line tool to install the APK.
And for unity, you want the unity editor to always use the same anonymous user? Unfortunately the Unity Editor version doesn't support persistence right now. It's something that we'd like to have but I don't have a timeline for if/when it will be available. In the mean time, you can just have it log in with a test account when run from the editor if you want to prevent new anonymous accounts every time you run it.

Closing this as a duplicate of #253


Update build.sbt when upgrading sbt version

Currently, updating sbt version is only reflected in file project/build.properties  but there might be usages of the same in build.sbt (sometimes as crossSbtVersions) which is not updated.
Any reason for this? Ex: https://github.com/cb372/sbt-explicit-dependencies/pull/61 does not update the value in build.sbt

As you mentioned sbt versions are currently only updated in files named build.properties see: https://github.com/fthomas/scala-steward/blob/master/modules/core/src/main/scala/org/scalasteward/core/io/package.scala#L31
It would be possible allow changes in "normal" source files to (as tested by isGenericSourceFile), but this could lead to too many changes. A problem that just happened with version numbers in text files (#1376).
Difficult decision.

hmm, yeah. closing

The file restriction is there since Scala Steward can update sbt versions (#665). I think we never tried updating sbt versions anywhere else.
If we allow Scala Steward to update sbt versions in other source files, it might produce a diff like https://github.com/cb372/sbt-explicit-dependencies/commit/014427ac6edc21d2e13e4cd7bf9133c05c8ded81 (including the change in the .travis.yml) or it might produce more bad PRs (as @mzuehlke pointed out). Maybe we should give it a try.


[Snyk] Security upgrade ruby from 2.6.5 to 2.7.6

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

openshift-configs/Dockerfile

We recommend upgrading to ruby:2.7.6, as this image has only 361 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

714
Exposure of Resource to Wrong Sphere SNYK-DEBIAN10-CURL-3065760
No Known Exploit

714
Directory Traversal SNYK-DEBIAN10-DPKG-2847944
No Known Exploit

714
Integer Overflow or Wraparound SNYK-DEBIAN10-GIT-3232718
No Known Exploit

714
OS Command Injection SNYK-DEBIAN10-OPENSSL-2807585
No Known Exploit

714
OS Command Injection SNYK-DEBIAN10-OPENSSL-2933515
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal

Checkmarx One – Scan Summary & Details – 4592b5f2-9b22-4cf7-b954-1e772a7f1eb8
No New Or Fixed Issues Found


feat(expressive-modal/lightbox-media-viewer): update expressive modal v2

Related Ticket(s)
Closes #10850, #10855
Description
Updates expressive-modal and lightbox-media-viewer components to v2 styles and prefixes
Changelog
New

{{new thing}}

Changed

update styles
update component prefixes

Removed

{{removed thing}}

@ariellalgilmore The open knob for the React wrapper stories is bugged for both components. Looks like this is a Storybook issue, since the open prop is clearly working when the story first loads. Also, the hideCaption prop isn't working in lightbox-media-viewer. This issue also exists in production. I'll create issues for both of these bugs separately.


[react-form, react-form-state] Update fast-deep-equal to ^3.1.3

Description
Keeps packages relying on fast-deep-equal (CHANGELOG) up to date with the latest version.
This is useful because I'm introducing a new devDependency in Shopify/web that relies on fast-deep-equal@3, and this will prevent having to add this dependency to the list of ignored packages in failOnDuplicateDependencies (as set up in Shopify/web’s sewing-kit.config.js).
Type of change

[ ] react-form Patch: dependency update
[ ] react-form-state Minor: dependency update

Checklist

[x] I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

This is a major bump of fast-deep-equal, which offers up a breaking change per https://github.com/epoberezkin/fast-deep-equal/releases/tag/v3.0.0-beta.0: "instances of different classes are now considered unequal"
Taking a quick look at what we pass into isEqual in quilt libs it looks like we never pass in classes, so sounds like we're fine.

/shipit

No /shipit here, you have to press the button

Awesome, I love pressing buttons! So old school 🥸


feat: hyperbolic functions

Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/issues/5838
Rationale for this change
What changes are included in this PR?
Hyperbolic functions and inverse hyperbolic functions:

Asinh
Acosh
Atanh
Sinh
Cosh
Tanh

Are these changes tested?
Partially
Are there any user-facing changes?
Yes

https://github.com/apache/arrow-datafusion/pull/5887 looks good to me -- thank you @izveigor


Fixes #13 - Add Continuous Integration

@ucsdlib/developers - Please review, comment, etc... Thanks

Besides a curl test, a netstat or ss call can be made to see if anything is listening on the port, but the service may not be ready as soon as the port is open.
ss -tl '( sport = :8985 )' | grep-q LISTEN
netstat -nl | grep -q 8985

@mcritchlow - The script has been added and circleci config has been updated.  It's working fine.  However, bundle install failed with ruby version 2.4.

@VivianChu very strange about 2.4 not working, but we can always circle back to updating Ruby as a separate task.

@lsitu or @hweng any concerns?

👍

@mcritchlow I upgrade ruby to 2.4.0 and it works in my local environment.

@mcritchlow - Here's the error message in here https://circleci.com/gh/ucsdlib/horton/66
make failed, exit code 2
Gem files will remain installed in
/home/ubuntu/horton/vendor/bundle/ruby/2.4.0/gems/json-1.8.3 for inspection.
Results logged to
/home/ubuntu/horton/vendor/bundle/ruby/2.4.0/extensions/x86_64-linux/2.4.0-static/json-1.8.3/gem_make.out
An error occurred while installing json (1.8.3), and Bundler cannot
continue.

@VivianChu @lsitu Interesting. It looks like there was/is an issue with that version of the JSON gem and Ruby/Rails compatibility https://github.com/rails/rails/issues/27450#issuecomment-269500870

@mcritchlow @VivianChu Yes, it's strange. Maybe we can try 2.3.1 for now or just circle it back later?

How about we get this merged so we can then get the other PR's merged, and then I'll setup another ticket we can work on next Sprint for getting Ruby updated?

@mcritchlow Yes. It sounds good and I'll merge it now.


RokuService: Fix a crash in getAppList when only one app is returned

Fixes https://github.com/ConnectSDK/Connect-SDK-iOS/issues/175

It would be good to add a couple of tests with wrong XML responses. The method should not crash and should return an error.

@frolov-alexey, thanks, added a few tests.


add template to field (or wysiwyg editor)

https://github.com/svennd/alies/commit/cff21370f0f0ffbaeb0091f838aa5be600593a82


Update workflows due to node 16 deprecation

Update workflows to use actions that do not use node 16

Closing as dependabot is now setup


Update LAB_AK_07_Lab1_Ex2_Playbook.md

change for new tab name
Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:

Confirmed UI change.


How to handle long forms with formly

I have model like below
const model = {
  a: {
    a1: '',
    a2: '',
    a3: ''
  },
  b: {
    b1: '',
    b2: '',
    b3: [
      {
        ba: {
          ba1: '',
        }
      }
    ]
  }
}

Now I end up writing fields like below
const fields = [
  {
    key: 'a',
    fieldGroup:[
      {
        key: 'a1'
      }
      //....
    ]
  },
  {
    key: 'b',
    fieldGroup: [
      {
        key: 'b1'
      },
      // ...
      {
        key: 'b3',
        fieldGroup: [
          {
            key: 'b3a1'
          }
        ]
      }
    ]
  }
]

This ends up rendering very bad aligned HTML because of the nested fieldgroup. I want the model nested structure to not interfere with fields and it's html representation. What are the options out there that could help me. I see there are wrappers but what else can help me?

if you don't need fieldGroup, you can use nested key: a. a1 instead:
const fields = [
  { key: 'a.a1' },
  ....
];

I want the model nested structure to not interfere with fields and it's html representation. What are the options out there that could help me.

https://github.com/ngx-formly/ngx-formly/issues/2710#issuecomment-804500185

For array items

https://main.formly.dev/docs/examples/advanced/repeating-section/


Integrate Fastlane

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   89.45%   89.45%
=======================================
  Files          31       31
  Lines        5700     5700
=======================================
  Hits         5099     5099
  Misses        601      601

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63fc8ef...4d5dafe. Read the comment docs.


[BEAM-1518] support deflate file IO

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Coverage decreased (-0.02%) to 69.153% when pulling 50da3c31726390e4ddcde81e4c4c35112fe00213 on nevillelyh:neville/BEAM-1518 into 5d6dafa26a29020afa3db2bac252ceadddbdeeac on apache:master.

@dhalperi FYI

retest this please

this is a command to jenkins that rules out flakes

retest this please

Coverage increased (+0.1%) to 69.304% when pulling 50da3c31726390e4ddcde81e4c4c35112fe00213 on nevillelyh:neville/BEAM-1518 into 5d6dafa26a29020afa3db2bac252ceadddbdeeac on apache:master.

Coverage increased (+0.1%) to 69.317% when pulling 50da3c31726390e4ddcde81e4c4c35112fe00213 on nevillelyh:neville/BEAM-1518 into 5d6dafa26a29020afa3db2bac252ceadddbdeeac on apache:master.

Thanks Neville! Looks great!


Invalid path: / As well as several questions

Browsers and versions affected
Chrome Version 92.0.4515.131 (Official Build) (64-bit)
Description
I followed the instructions and when I got to the end I had a few questions:
Is collider meant for serving the website or communicating with google glass?
I got my google app engine running but the sdk of pathToGcloudSDK/platform/google_appengine/dev_appserver.py out/app_engine/ is not valid.  What should I do with it? How do I implement it after it has been set up? Why do we need it at all? I'm sorry if this has been explained but the README doesn't really make this clear to me.
Lastly, it says at the end to navigate to the url that (I assume is generated by collidermain) and add the argument of ?wstls=false. I did this, but still I get Invalid path.

So I've been stumbling around trying to figure out what to do but I made it to the point that I initialize the server but now I get the error:
File "/root/google-cloud-sdk/platform/google_appengine/python27/sdk/google/appengine/runtime/wsgi.py", line 83, in LoadObject
obj = import(path[0])
ImportError: No module named apprtc


Is it possible to add watermark ?

Hi. Is it possible add a watermark photo to video ?

Use the built-in watermark filter, you should do something like this:
FFMpeg::open('your_video.mp4')
    ->addFilter(function ($filters) {
        $filters->watermark($watermarkPath, [
            'position' => 'relative',
            'bottom' => 50,
            'right' => 50,
        ]);
    })...

Can you give an example of the $filters? They don't have it on their docs in the section you linked. Thanks.

How you can define the watermark path ?


Hebrew Support

I would like to when Hebrew language will be supported by Bing Spell Check API. Any ETA

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b6e03b67-8c6c-2749-7778-99f7dca069c6
Version Independent ID: a6ee8911-2630-d6c4-81c7-28a5fdf4b767
Content: Language support - Bing Spell Check API - Azure Cognitive Services
Content Source: articles/cognitive-services/Bing-Spell-Check/language-support.md
Service: cognitive-services
GitHub Login: @noellelacharite
Microsoft Alias: nolachar

@Sethu2488
Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate
@noellelacharite Hi Noelle, do you have any idea about the timeline? Thanks.

Any update on the above ask would highly be appreciated.

@YutongTie-MSFT This is product feedback, not doc enhancement. Please reassign to @sezho (MSFT).

@tchristiani As you seeing, I can not assign to @sezho(MSFT) since he/she has not joined this repo. Can you please ask him/her to join?

Appreciate if you could add @sezcho(MSFT) into the thread. So that i can share the timeline to the customer.

It is being a more than a week. Kindly check and  let us know if there is any timeline.

@tchristiani Hi, I can not assign this issue to @sezho(MSFT) as he is not in the repo or have the access now. Can you please help?

He has been traveling. I have put this with another person on the team and they promised more by end of this week.

We don't have plan to support Hebrew currently.

Thank you for the information.

@Sethu2488 We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


AMS migration: assist and provide feedback (3/n)

Following up from https://github.com/ooni/backend/issues/451. This is basically me providing assistance with the migration from HKG to AMS, with QA, testing, code review, chats, rubber duck debugging sessions (where I am the 🦆).

[x] Review https://github.com/ooni/sysadmin/pull/457
[x] understand/fix frequent failures in probe-ios tests: https://github.com/ooni/probe-ios/actions/runs/315431716
[x] enumerate the places where we MUST keep existing DNS names (e.g. mobile apps)
[ ] chase miniooni measurements produced by e2etesting with null test_keys
[ ] Update e2etesting/legacy to use production names
[ ] brief review of the codebase ⏳
[ ] point testing code to the new testing infra

I will most likely add more items to this list depending on what happens. See also https://github.com/ooni/backend/issues/437.

Frequent failures in probe-ios tests
Compare:
2020/10/19 14:31:06 > GET https://ams-pg.ooni.org/api/v1/measurement_meta?report_id=20190113T202156Z_AS327931_CgoC3KbgM6zKajvIIt1AxxybJ1HbjwwWJjsJnlxy9rpcGY54VH
2020/10/19 14:31:06 < 200
{"anomaly":false,"category_code":"","confirmed":false,"failure":false,"input":null,"measurement_start_time":"2019-02-22T20:21:59Z","probe_asn":327931,"probe_cc":"DZ","report_id":"20190113T202156Z_AS327931_CgoC3KbgM6zKajvIIt1AxxybJ1HbjwwWJjsJnlxy9rpcGY54VH","scores":"{}","test_name":"ndt","test_start_time":"2019-02-22T20:21:47Z","raw_measurement":""}

to:
% curl -qs 'https://ams-pg.ooni.org/api/v1/measurements?report_id=20190113T202156Z_AS327931_CgoC3KbgM6zKajvIIt1AxxybJ1HbjwwWJjsJnlxy9rpcGY54VH'
{
  "metadata": {
    "count": 0,
    "current_page": 1,
    "limit": 100,
    "next_url": null,
    "offset": 0,
    "pages": 0,
    "query_time": 0.013468742370605469
  },
  "results": []
}

What is going on here? We should investigate!

As of 14:00 CEST, we have modified the configuration served by bouncer.ooni.io to point to AMS PG: https://github.com/ooni/sysadmin/pull/457. As a result, now I will modify e2etesting to use bouncer.ooni.io and the original onion name, such that we basically test the production infrastructure. Apparently, the cloudfront domain used by the legacy probes is gone and there's nothing that we can do about that.

chase miniooni measurements produced by e2etesting with null test_keys
@FedericoCeratto shared with me a miniooni measurement like:
{
  "content": {
    "annotations": {
      "engine_name": "miniooni",
      "engine_version": "0.9.0",
      "platform": "linux"
    },
    "data_format_version": "0.2.0",
    "input": "http://mail.google.com",
    "measurement_start_time": "2020-10-20 12:26:08",
    "probe_asn": "AS8075",
    "probe_cc": "US",
    "probe_ip": "<IP_ADDRESS>",
    "report_id": "20201020T122608Z_webconnectivity_US_8075_n1_uzjj0qlMoTcZ7flj",
    "resolver_asn": "AS8075",
    "resolver_ip": "<IP_ADDRESS>",
    "resolver_network_name": "Microsoft Corporation",
    "software_name": "miniooni",
    "software_version": "0.1.0-dev",
    "test_keys": null,
    "test_name": "web_connectivity",
    "test_runtime": 8.85e-05,
    "test_start_time": "2020-10-20 12:26:08",
    "test_version": "0.0.1"
  },
  "format": "json"
}

This measurement is clearly produced by e2etesting. I'm going to add a check in e2etesting to detect these errors.

Update e2etesting/probe-engine to use production names
We have now flipped almost everything.  Closing now, because today the Sprint ends and it makes sense to do what is missing into the next Sprint.