Setup Question

I'm using Meteor, which includes a MongoDB server. On localhost, the url for that mongo db is:
mongodb://localhost:3001/meteor
I'm trying this setup:
import { MongodbPubSub } from 'graphql-mongodb-subscriptions';
const { MongoClient } = require('mongodb');

const MONGO_URL = "mongodb://<IP_ADDRESS>:3001";
const mongoClient = new MongoClient(MONGO_URL, { useNewUrlParser: true, useUnifiedTopology: true });

async function startPubSub() {
    try {
        // Connect to the MongoDB server
        await mongoClient.connect();

        // Now that the client is connected, create the pubsub instance
        const pubsub = new MongodbPubSub({ connectionDb: mongoClient });

        // Subscribe to the "error" channel
        pubsub.subscribe("error", err => {
            console.log(`pubsub error: ${err.message}`);
        });

        console.log('PubSub initialized and connected to MongoDB');
    } catch (err) {
        console.error('Failed to initialize PubSub:', err);
    }
}

// Start the PubSub
startPubSub();

It runs without error, including printing:

PubSub initialized and connected to MongoDB

But a moment later, It throws the following error:
TypeError: this.db.collections is not a function
    at Channel.init (/myLocalDevSystem/node_modules/@mawhea/mongopubsub/src/channel.ts:153:39)
    at Channel.listen (/myLocalDevSystem/node_modules/@mawhea/mongopubsub/src/channel.ts:110:18)
    at new Channel (/myLocalDevSystem/node_modules/@mawhea/mongopubsub/src/channel.ts:43:10)
    at new MongodbPubSub (/myLocalDevSystem/node_modules/graphql-mongodb-subscriptions/src/mongodb-pub-sub.ts:55:20)

What am I missing?

I think you might need to change this
await mongoClient.connect();
const pubsub = new MongodbPubSub({connectionDb: mongoClient});

To this
const connectionDb = await mongoClient.connect();
const pubsub = new MongodbPubSub({connectionDb});

The mongoClient.connect() returns the initializes db objects
https://mongodb.github.io/node-mongodb-native/api-generated/mongoclient.html

I updated it to:
import { MongodbPubSub } from 'graphql-mongodb-subscriptions';
const { MongoClient } = require('mongodb');

const MONGO_URL = "mongodb://<IP_ADDRESS>:3001";
const mongoClient = new MongoClient(MONGO_URL, { useNewUrlParser: true, useUnifiedTopology: true });

async function startPubSub() {
    try {
        const connectionDb = await mongoClient.connect();
        const pubsub = new MongodbPubSub({connectionDb});

        // Subscribe to the "error" channel
        pubsub.subscribe("error", err => {
            console.log(`pubsub error: ${err.message}`);
        });

        console.log('PubSub initialized and connected to MongoDB');
    } catch (err) {
        console.error('Failed to initialize PubSub:', err);
    }
}

startPubSub();

I'm still getting the same doggone error. 🤨

Here is a small demo project. The pubsub setup code is in imports/apollo/resolvers.js.  If needed, run meteor npm install on the command line to install the npm packages.
https://github.com/VikR1000/apollo-skeleton-suggested-minor-updates-v400

Here's a link to a small demo repo.  It can be started via meteor run in the terminal. The RedisPubSub setup code is in imports/apollo/resolvers.js.
https://github.com/VikR1000/apollo-skeleton-suggested-minor-updates-v400

Here is my sample project using the graphql-mongodb-subscriptions package.  It uses mongoose but should be able to provide you some guidance in setting up the database collection.
https://github.com/mjwheatley/apollo-graphql-mongodb/blob/main/src/index.ts
If you are using Meteor, I'm curious why don't you just use Meteor's pub/sub feature? Are you using Meteor.methods as wells as a graphql endpoint all connected to the same database?

Great question! I'm using ApolloGraphQL for data and subscriptions.  This way I can use a relational database like PostGres, rather than MongoDB.  I'll check out the repo you provided!

That worked. Thanks very much, Matthew!


Setting up Jenkins Deployment for Testgrid in EC2

$subject will be initially done manually. We need to automate this with CF later on.

Initial setup is done. Deployment can be accessed from here for now - http://ec2-34-238-28-168.compute-1.amazonaws.com:8080/
We will have a proper URL soon.


Enable to specify file metadata on upload

When uploading files we need to allow to specify metadata associated with them.
For example if you have a text file you want to associate text/plain as its Content-Type, otherwise the browser will download the file to the disk instead of displaying it.

Migrated from: https://issues.jenkins-ci.org/browse/JENKINS-25621

This is possible with the Show Inline feature, resolved in #12


Upload failed if app is running in the background in React Native

Describe the bug
Upload failed if app is running in the background in React Native. Specially in IOS
Setup details
Please provide following details, if applicable to your situation:

Runtime environment: React Native
Used tus-js-client version: ^1.8.0-2

Please provide more details to allow us to reproduce this. However, AFAIK, iOS does not allow arbitrary background activities so it's possible that there is nothing we can do if iOS decides to kill your app if it is put into background.

@Acconut

@iqbalfaisal A screenshot is not sufficient to allow us to reproduce this. Please provide the minimal code and instructions so we can trigger the same error.

@Acconut this error will trigger when the picture is uploading and App goes to background and came back in IOS

@Acconut sorry i forgot to mention. App should be in release mode on real device rather than emulator

I personally don't have an iOS device or emulator available, so I cannot debug this. Maybe @ifedapoolarewaju could help or you, @iqbalfaisal, might be able to take a look on your own.

@Acconut i tried but failed. Kindly solved this because my app is delaying due to this problem

It's unfortunate that your app is delayed. If it's very urgent for you, we can talk about private paid support.

@ifedapoolarewaju are you there?

Yes @iqbalfaisal you're right. I'm facing the same error. Let me know when you find something useful. I think core contributor is not serious about the library.

I think core contributor is not serious about the library.

That's not a very nice claim about the work that we put into this open source project and provide to you free of any charge.
You should know that background uploads on iOS is not something we do not care about but even our native Objective-C SDK cannot do, because iOS simply doesn't allow it. I don't want to go into details but instead refer you to https://github.com/tus/TUSKit/issues/57 where you can read more. So we are inherently limited in what we can do.

That's not a very nice claim about the work that we put into this open source project and provide to you free of any charge.

I know @Acconut. I really appreciate your time and effort also your team.

You should know that background uploads on iOS is not something we do not care about but even our native Objective-C SDK cannot do, because iOS simply doesn't allow it. I don't want to go into details but instead refer you to tus/TUSKit#57 where you can read more. So we are inherently limited in what we can do.

Yes i had read this but question is why App is crashing. I Know Apple not allow background processes but Tus-Client should send error in OnError function or just stop uploading without crashing the whole App. I hope you understand my point.
Thanks

Really sorry if you hurt @Acconut

Thanks for the kind words and the explanation, @iqbalfaisal. If I understand it now correctly, there are two problems:

tus-js-client cannot upload a file while the app is in background on iOS
tus-js-client causes an unrecoverable crash if the app is put into background while an upload is running.

Problem 1 cannot be solved directly since it's a restricting from iOS (unless you use the location hack as in https://github.com/tus/TUSKit/issues/57).
Problem 2 should be solvable but I can't work on it personal because I don't have access to an iOS device or emulator. So help is in this regard greatly appreciated if you want to see this problem fixed.

Problem 2 should be solvable but I can't work on it personal because I don't have access to an iOS device or emulator. So help is in this regard greatly appreciated if you want to see this problem fixed.

Yes @Acconut  i'm talking about this problem. I have spent whole day to sort out this problem but unfortunately i have failed and frustrated. I have put this problem in future TODO list and going to release the my App. Thanks for the giving me yours important time.

@iqbalfaisal the issue is not related to tus-js-client. Instead, it is caused by a bug in core react-native. You can view the and details here.
https://github.com/facebook/react-native/pull/31392

@iqbalfaisal Thank you for the info. If I read it correctly, this fix was not yet included in any release, but will make it into 0.72.0? https://github.com/reactwg/react-native-releases/discussions/54


env values

Pull Request Test Coverage Report for Build 454205366

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.9%) to 92.308%

Totals

Change from base Build 453096259:
1.9%

Covered Lines:
73

Relevant Lines:
77

💛  - Coveralls

Pull Request Test Coverage Report for Build 454205366

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.9%) to 92.308%

Totals

Change from base Build 453096259:
1.9%

Covered Lines:
73

Relevant Lines:
77

💛  - Coveralls


feat(learn): add backend solution url to help post

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

With this, when a Camper uses the Ask for Help button on a challenge, the pre-populated post now includes a link to their solution url on backend challenges.
This just helps us on the forum, when Campers forget to include a link to the code they are trying to submit.
In order for this to work, the tests have to be run at least once with the given URL. (They do not need to pass)

@raisedadead I corresponded with @ShaunSHamilton on chat and he is going to be making a change.  Once that is done, I think the PR will be good to go.

The latest changes incorporate Randell's suggestion to look like this:


Add read me

Sorry if it is bad form to drop an issue for this. How does this feel for a first pass at the read me for this project?
Talent search and recruitment protocol designed to incentivize the end user for participating in the network.

Back-end set up instructions @QEDK

see my pull req.


Add optional heuristic for choosing best rechunk method

[ ] Closes #10226
[ ] Tests added / passed
[ ] Passes pre-commit run --all-files

I'll add some tests for this in dask/distributed.

Closed because performance depends too much on the underlying hardware to implement a good heuristic. See https://github.com/dask/dask/issues/10226#issuecomment-1602442976 for more information.


[Tech debt] Tooling for transpiling javascript/other into WGSL for WebGPU implementation

Motivation
Currently the WebGPU implementation is underway but the trouble is we have to maintain two copies of the codebase. One in js and one in WGSL.
Objective
Ideally we only have to write one version of code and have it run in both environments. Options include transpiling javascript into WGSL, or writing everything in Rust and compiling that down to WASM and WGSL.

Released in https://github.com/fribbels/hsr-optimizer/pull/570


Allow kapp delete even if default namespace was part of the application configuration

Describe the problem/challenge you have
If the default namespace is included as a resource in a kapp-deployed application, you can then not delete the application. You get the following error and you are stuck:
Error: resource deletion failed: kapp: Error: Applying delete namespace/default (v1) cluster:
  Deleting resource namespace/default (v1) cluster: namespaces "default" is forbidden: this namespace may not be deleted (reason: Forbidden)
. Delete failed: Error (see .status.usefulErrorMessage for details)
Error: exit status 1

Describe the solution you'd like
I don't think it is realistic to prevent the default namespace to be part of an application configuration, so maybe one of these two approaches could work:

If default namespace is one of the resources in the YAML, ignore it but deploy the rest of the resources in the application
If default namespace is one of the resources in the kapp-deployed application, do not try to delete the namespace during kapp delete.... Simply ignore it and delete the rest of the application resources.

Anything else you would like to add:
Here is one case in which I ran into this problem:
https://github.com/vmware-tanzu/community-edition/issues/3067
It is not the only situation in which I've experienced this issue, but I think it's a good example.

Adding steps to reproduce this issue using kctrl

Add the TCE repo

kctrl package repo add -r tce --url projects.registry.vmware.com/tce/main:0.10.0

Install cert-amanger into default ns

kctrl package install -i cert-man -p cert-manager.community.tanzu.vmware.com --version 1.6.1 --values-file - << EOF
---
namespace: default
EOF

Attempt a delete

kctrl package installed delete -i cert-man                                                                                ─╯
Delete package install 'cert-man' from namespace 'default'

Continue? [yN]: y

Target cluster 'https://<IP_ADDRESS>:49961' (nodes: minikube)

Deleting package install 'cert-man' from namespace 'default'

Waiting for deletion of package install 'cert-man' from namespace 'default'

10:51:37AM: packageinstall/cert-man (packaging.carvel.dev/v1alpha1) namespace: default: Deleting
10:51:43AM: packageinstall/cert-man (packaging.carvel.dev/v1alpha1) namespace: default: DeleteFailed

kctrl: Error: packageinstall/cert-man (packaging.carvel.dev/v1alpha1) namespace: default:
  Deleting: packageinstall/cert-man (packaging.carvel.dev/v1alpha1) namespace: default:
    Deleting: kapp:
      Error:
        Applying delete namespace/default (v1) cluster:
  Deleting resource namespace/default (v1) cluster:
    API server says: namespaces "default" is forbidden: this namespace may not be deleted (reason: Forbidden)
. Delete failed: Error (see .status.usefulErrorMessage for details)

There are a few ways forward from here,

We could make it so that kapp apps do not adopt namespaces that are already created as a guardrail against unintended deletions and that will help in situations like these. The downside is that some users migrating existing resources into kapp applications might want to adopt namespaces in which case a flag toggling this behaviour might become handy. (This is a more generic solution that helps multiple use cases).
One possible downside I can think of is that the ns won't show up when the app is inspected if not adopted.
Since, this situation is especially bothersome when it comes to packages that could possibly include a namespace resource that is overlayed depending upon configuration while the user is installing the application. This could warrant a change in kapp-controller where we filter out resources like the default namespace while deleting/deploying the application using flags exposed by kapp.
Packages which allow overlaying of namespace resources should have a guardrail against this while templating the manifests. However, if we do publish this suggestion, packages might take a while to incorporate the same.
kapp could have a set of resources, that it cannot operate upon (such as resources which the cluster does not allow deletion for). This however is pretty specific and might not be the best course of action.

There has been some discussion in the past for kapp to ignore resources which cannot be operated on and continue with deployment/deletion of other resources. However, this does not help the packaging use case as the PackageInstall deletion still fails when any of the resources cannot be operated upon.
@joe-kimmel-vmw your input would be super helpful here. How do you feel about option 2? Is it too specific or is it worth consideration.

i do think that kapp should be owner of whatever behaviour we decide on. (kapp-controller doesnt interact with any resource kapp deploys directly).
im not a huge fan of "skipping" deletion of default namespace since it seems like user should never have configured app to include default namespace (though i could see how one may want to apply some labels to default namespace via kapp).
i think with the current feature set the general answer should be that default namespace should be marked as delete-strategy=orphan, but that does mean that configuration authors need to be mindful of default vs non-default namespaces.

Since it is a hard rule that the default namespace cannot be deleted from the cluster. It does make sense for kapp to have a set of such resources hardcoded, for which it uses the "orphan" strategy for deletion.
We should probably add other similar resources to such a list as well.
We will be adding this to our unprioritized backlog  and work towards it🚀

Acceptance criteria:

[ ] Despite of type of delete strategy what we have applied to inoperable resources(like default namespace) kapp should orphan the resource in delete operation.
[ ]  For plain delete strategy (for operable resources) kapp should delete the resources on delete operation.
[ ] For orphan delete strategy (for operable resources) kapp should orphan the resources on delete operation.


Remove default actix deps

Removing the unused default actix dependencies reduces the number of
extra dependencies pulled in (e.g. actix-http and trust-dns), which is
useful for projects using actix-broker but don't need the added
dependencies.

@jthacker Thanks for the PR. Unfortunately there were build errors when I tested it. See #12
Did this build ok for you?


Feature documentation

This is a big one. Everything done here is backwards compatible code-wise, and all tests are passing in Travis CI - https://travis-ci.org/jrbeilke/zabbixapi/builds/223783663

Split up the main README and put all of the code examples into an /examples sub-directory with their own README and table of contents to better organize things.
Added YARD and documented as much of the code as possible. Can now view the code documentation locally using "yard server" or on rubydoc.info once this PR is merged.
Added RuboCop and updated the existing code to follow the majority of the Ruby Style guidelines.
Tweaked the Travis CI config to speed things up with the bundler cache and fix a few build issues (mostly jruby).

gem test was deprecated/removed so test_files is no longer needed in the gemspec - https://github.com/rubygems/rubygems/issues/730
The zabbixapi gem does not include a bin/ directory, or any executables, so I removed that from the gemspec as it is an optional attribute

Okay, I got it. Thank you for PR! :+1:


allow setting flight mode using a string value

This modifies mode.setter so that we can write:
vehicle.mode = 'LOITER'

Rather than:
vehicle.mode = VehicleMode('LOITER')

@peterbarker does this seem like a reasonable idea?  Thanks!

On Fri, 23 Jun 2017, Lars Kellogg-Stedman wrote:

@peterbarker does this seem like a reasonable idea? Thanks!

Seems reasonable.
If you're happy with it then I can pull it in.  Any changes you'd like to
make first?
(caveat: I thoroughly dislike the magically-caught-assignment stuff that
you're modifying here; Hamish has a PR in place to replace it with
something which sucks much less - attribute setters.  Since your approach
here makes just as much sense with Hamish's work I'm still happy to see it
go in :-) )

Pull away!

Tested and merged, thanks!


Multiple Daemon spawning

I have Java JDK 13 installed on my machine, as android studio and gradle currently don't support it, I have to change the jdk location for the project to the version that android installs in the path './android/android studio/jre'. But it is giving a warning of multiple daemon spawning on doing so, the project builds, but I'm not sure if this is intended behavior and whether it can cause trouble while building projects.
Expected Behavior

After changing the jdk location gradle should only be using the specified version for jdk not the JAVA_HOME of the my environment as well as the jdk location inside project structure, leading to multiple daemon spawns.
Current Behavior

Multiple daemon spawns while building projects.
Context

As Jdk 13 is currently not supported I have to change and use the jdk inside android studio to build projects, but it is causing multiple daemon spawning, although the project is build successfully regardless of the warning.
Steps to Reproduce

In a computer with java version 13 installed, try using android studio with JAVA_HOME set to JDK 13, the subproject properties are able to compile the program after changing jdk location to jre inside the android studio, but it is spawning multiple daemon on doing so.
Your Environment

Build scan URL:
Using windows 10, android studio 3.6.1, gradle 5.6.4, JAVA_HOME points to jdk 13, but inside project  structure jdk location is set to '.../android/android studio/jre' to use older version of java which android studio and gradle can build.

You appear to be in a old gradle version (5.6.4), have you tried upgrading?
Gradle introduced JDK 13 support back in Gradle 6.0 -> https://docs.gradle.org/6.0/release-notes.html#support-for-java-13

While you are correct that might stop the multiple spawning issue, but shouldn't the gradle system be not spawning two daemons when I have set the jdk location to android path instead of my home java path?

Let us know if you're still running into problems with a newer version of Gradle and Java 13


Don't comment on closed issues.
Use at least a hello, please or thank you when addressing people. People are not walls.


added new options for query string tracking

Scope & Purpose
Add new options for query string tracking

[ ] :hankey: Bugfix
[x] :pizza: New feature
[ ] :hammer: Refactoring
[x] :book: CHANGELOG entry made
[x] :muscle: The behavior in this PR was manually tested
[ ] :computer: The behavior change can be verified via automatic tests

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/12229/

http://<IP_ADDRESS>:8080/job/arangodb-matrix-pr-linux/13842/

Tests blue.


HADOOP-17290. ABFS: Add Identifiers to Client Request Header (#2520)

Contributed by Sumangala Patki.
(cherry picked from commit 35570e414a6ab9130da8cac60e563168ee0d4793)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
4m 16s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 37 new or modified test files.

_ branch-3.3 Compile Tests _

+1 :green_heart:
mvninstall
31m 30s

branch-3.3 passed

+1 :green_heart:
compile
0m 35s

branch-3.3 passed

+1 :green_heart:
checkstyle
0m 29s

branch-3.3 passed

+1 :green_heart:
mvnsite
0m 41s

branch-3.3 passed

+1 :green_heart:
javadoc
0m 32s

branch-3.3 passed

+1 :green_heart:
spotbugs
1m  9s

branch-3.3 passed

+1 :green_heart:
shadedclient
16m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 30s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed

+1 :green_heart:
spotbugs
1m  6s

the patch passed

+1 :green_heart:
shadedclient
16m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 58s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

78m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3258/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3258

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint

uname
Linux b41760acd978 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 7cf11a834841987a9a425fe8d6adcb87acfd28cb

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3258/2/testReport/

Max. process+thread count
737 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3258/2/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
10m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 37 new or modified test files.

_ branch-3.3 Compile Tests _

+1 :green_heart:
mvninstall
31m 42s

branch-3.3 passed

+1 :green_heart:
compile
0m 33s

branch-3.3 passed

+1 :green_heart:
checkstyle
0m 27s

branch-3.3 passed

+1 :green_heart:
mvnsite
0m 39s

branch-3.3 passed

+1 :green_heart:
javadoc
0m 30s

branch-3.3 passed

+1 :green_heart:
spotbugs
1m  5s

branch-3.3 passed

+1 :green_heart:
shadedclient
16m 41s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 21s

the patch passed

+1 :green_heart:
spotbugs
1m  5s

the patch passed

+1 :green_heart:
shadedclient
15m 46s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 57s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

84m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3258/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3258

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint

uname
Linux 4b7d291f653f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 7cf11a834841987a9a425fe8d6adcb87acfd28cb

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3258/1/testReport/

Max. process+thread count
735 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3258/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

TEST RESULTS
HNS Account Location: East US 2
NonHNS Account Location: East US 2, Central US
AppendBlob-HNS-OAuth

[WARNING] Tests run: 103, Failures: 0, Errors: 0, Skipped: 1
[ERROR] Failures:
[ERROR]   ITestAbfsStreamStatistics.testAbfsStreamOps:140->Assert.assertTrue:42->Assert.fail:89 The actual value of 99 was not equal to the expected value
[ERROR] Errors:
[ERROR]   ITestAzureBlobFileSystemLease.testTwoWritersCreateAppendNoInfiniteLease:178->twoWriters:166 » IO
[ERROR]   ITestAzureBlobFileSystemLease.testTwoWritersCreateAppendWithInfiniteLeaseEnabled:187->twoWriters:155 » TestTimedOut
[ERROR] Tests run: 558, Failures: 1, Errors: 2, Skipped: 98
[WARNING] Tests run: 259, Failures: 0, Errors: 0, Skipped: 76

HNS-OAuth

[ERROR] Failures:
[ERROR]   TestAbfsClientThrottlingAnalyzer.testManySuccessAndErrorsAndWaiting:171->fuzzyValidate:49 The actual value 9 is not within the expected range: [5.60, 8.40].
[ERROR] Tests run: 103, Failures: 1, Errors: 0, Skipped: 1
[WARNING] Tests run: 558, Failures: 0, Errors: 0, Skipped: 98
[WARNING] Tests run: 259, Failures: 0, Errors: 0, Skipped: 52

HNS-SharedKey

[ERROR] Failures:
[ERROR]   TestAbfsClientThrottlingAnalyzer.testManySuccessAndErrorsAndWaiting:171->fuzzyValidate:49 The actual value 10 is not within the expected range: [5.60, 8.40].
[ERROR] Tests run: 103, Failures: 1, Errors: 0, Skipped: 2
[WARNING] Tests run: 558, Failures: 0, Errors: 0, Skipped: 54
[WARNING] Tests run: 259, Failures: 0, Errors: 0, Skipped: 40

NonHNS-SharedKey

[ERROR] Failures:
[ERROR]   TestAbfsClientThrottlingAnalyzer.testManySuccessAndErrorsAndWaiting:171->fuzzyValidate:49 The actual value 10 is not within the expected range: [5.60, 8.40].
[ERROR] Tests run: 103, Failures: 1, Errors: 0, Skipped: 2
[WARNING] Tests run: 558, Failures: 0, Errors: 0, Skipped: 276
[WARNING] Tests run: 259, Failures: 0, Errors: 0, Skipped: 40

@steveloughran this would need to be merged in before #3446 to resolve merge conflicts.

merged it....as usual, everyone should feel free to remind me about backport PRs, as they are easy to miss.
mehakmeet, check all is good


rwx size is too small to hold 56 bytes backup instructions

When trying to hook some system functions (e.g. fork, execve), I see an error in logcat that reads rwx size is too small to hold 56 bytes backup instructions, and hooking fails. Looking at https://github.com/rrrfff/And64InlineHook/blob/master/And64InlineHook.cpp the hook trampoline size seems to be limited to 50 bytes, hence the error.
Call site looks like so:
#include <jni.h>
#include <unistd.h>
#include <sys/types.h>
#include "AndHook.h"

#define AKLog(...) __android_log_print(ANDROID_LOG_INFO, "AndHook", __VA_ARGS__)

static decltype(fork) *sys_fork;

pid_t __unused hook_fork() {
    AKLog("fork called");
    pid_t child_pid = sys_fork();
    if (child_pid != 0) {
        AKLog("fork child pid: %d, parent pid: %d", static_cast<int>(child_pid), static_cast<int>(getpid()));
    }
    return child_pid;
}

extern "C" JNIEXPORT jint JNICALL __unused JNI_OnLoad(JavaVM *vm, void __unused *reserved) {
    JNIEnv *env;
    if (vm->GetEnv(reinterpret_cast<void **>(&env), JNI_VERSION_1_6) != JNI_OK) {
        return JNI_EVERSION;
    }

    AKHookFunction(fork, hook_fork, &sys_fork);
    return JNI_VERSION_1_6;
}

My system is a OnePlus 3 running OxygenOS - Android 8.0.0, arm64-v8a.
I seem to have gotten it working by copying the A64HookFunction as a wrapper around theAKHookFunctionV exported from the .so files here, and increasing the trampoline size to 70 from 50.
Attached is libc.so pulled from my device:
libc.so.zip

Yes, it may require more room if there are too many pc-relative instructions (e.g, mixed adr/adrp) that need to be relocated and aligned.
I will fix it as soon as possible, thanks.

Update: same device, more functions
03-30 18:41:09.062 30170 30170 I AndHook : hooking execv
03-30 18:41:09.062 30170 30170 E AndHook : rwx size is too small to hold 80 bytes backup instructions!
03-30 18:41:09.062 30170 30170 I AndHook : hooking execve
03-30 18:41:09.062 30170 30170 E AndHook : rwx size is too small to hold 88 bytes backup instructions!

After inspecting the attached libc.so, it seems that the functions I'm trying to hook are just thin wrappers around syscalls/other functions:

So I am guessing the errors are caused by AndHook stepping on itself since it has no room to write its hooking code for each function.
I'm really not sure what can be done here...

Thanks, it is indeed a bug and I am working on a fix for this.

Hello and thanks a lot! Will have a look in a day or two 😄

So I tried it, and I have both good and bad news.
Good news is the original error doesn't happen any more and I can hook adjacent functions without crashing the program when they're called! Yay! :smile:
Bad news is that I now sometimes see crashes when calling the original function. For example, if I hook only execve, and then call
if (fork() == 0) {
    system("ps");
}

I can actually see my hook function being executed, and log its arguments:
execve: /sbin/ps ps PATH=/sbin:/system/sbin:/system/bin:/system/xbin:/vendor/bin:/vendor/xbin DOWNLOAD_CACHE=/data/cache ANDROID_BOOTLOGO=1 ANDROID_ROOT=/system ANDROID_ASSETS=/system/app ANDROID_DATA=/data ANDROID_STORAGE=/storage EXTERNAL_STORAGE=/sdcard ASEC_MOUNTPOINT=/mnt/asec BOOTCLASSPATH=/system/framework/QPerformance.jar:/system/framework/core-oj.jar:/system/framework/core-libart.jar:/system/framework/conscrypt.jar:/system/framework/okhttp.jar:/system/framework/legacy-test.jar:/system/framework/bouncycastle.jar:/system/framework/ext.jar:/system/framework/framework.jar:/system/framework/telephony-common.jar:/system/framework/voip-common.jar:/system/framework/ims-common.jar:/system/framework/apache-xml.jar:/system/framework/org.apache.http.legacy.boot.jar:/system/framework/android.hidl.base-V1.0-java.jar:/system/framework/android.hidl.manager-V1.0-java.jar:/system/framework/oneplus_sdk_utils.jar:/system/framework/oneplus_sdk_wrapper.jar:/system/framework/tcmiface.jar:/system/framework/telephony-ext.jar:/system/framework/WfdCommon.jar:/system/framework/oem-services.jar:/system/framework/qcom.fmradio.jar:/system/framework/qcnvitems.jar:/system/framework/qcrilhook.jar:/system/framework/com.qti.snapdragon.sdk.display.jar SYSTEMSERVERCLASSPATH=/system/framework/services.jar:/system/framework/ethernet-service.jar:/system/framework/wifi-service.jar ANDROID_SOCKET_zygote=9 CLASSPATH=/system/framework/XposedBridge.jar

However as soon as I try to execute the original function, the process crashes:
04-03 15:42:32.220 2902-2902/?  A/DEBUG: Build fingerprint: 'OnePlus/OnePlus3/OnePlus3:8.0.0/OPR6.170623.013/01202200:user/release-keys'
04-03 15:42:32.220 2902-2902/? A/DEBUG: Revision: '0'
04-03 15:42:32.220 2902-2902/? A/DEBUG: ABI: 'arm64'
04-03 15:42:32.220 2902-2902/? A/DEBUG: pid: 2896, tid: 2896, name: <package.name>  >>> <package.name> <<<
04-03 15:42:32.220 2902-2902/? A/DEBUG: signal 11 (SIGSEGV), code 2 (SEGV_ACCERR), fault addr 0x7c9b3e7000
04-03 15:42:32.220 2902-2902/? A/DEBUG:     x0   0000007cbc02ec47  x1   0000007fceab0a30  x2   0000007cba834e30  x3<PHONE_NUMBER>000019
04-03 15:42:32.220 2902-2902/? A/DEBUG:     x4<PHONE_NUMBER>000086  x5<PHONE_NUMBER>000000  x6<PHONE_NUMBER>000000  x7<PHONE_NUMBER>800000
04-03 15:42:32.220 2902-2902/? A/DEBUG:     x8   0000007c9b7421b8  x9   b4adc4862297e4b0  x10<PHONE_NUMBER>000086  x11<PHONE_NUMBER>000000
04-03 15:42:32.220 2902-2902/? A/DEBUG:     x12<PHONE_NUMBER>000000  x13  0000007fceab0340  x14  0000007fceab03c8  x15  0000d7a959be9ea9
04-03 15:42:32.220 2902-2902/? A/DEBUG:     x16  0000007cbc057cb0  x17  0000007cbbff5f2c  x18<PHONE_NUMBER>000020  x19<PHONE_NUMBER>000000
04-03 15:42:32.220 2902-2902/? A/DEBUG:     x20  0000007cba5fac00  x21  0000007cba8bfa00  x22  0000007fceab1038  x23  0000007c9ce36915
04-03 15:42:32.220 2902-2902/? A/DEBUG:     x24<PHONE_NUMBER>000004  x25  0000007cba8bfa98  x26  0000007c9c83c0e0  x27<PHONE_NUMBER>236658
04-03 15:42:32.220 2902-2902/? A/DEBUG:     x28<PHONE_NUMBER>000001  x29  0000007fceab0a10  x30  0000007c9b69d94c
04-03 15:42:32.220 2902-2902/? A/DEBUG:     sp   0000007fceab09f0  pc   0000007c9b3e7000  pstate<PHONE_NUMBER>000000
04-03 15:42:32.222 2902-2902/? A/DEBUG: backtrace:
04-03 15:42:32.222 2902-2902/? A/DEBUG:     #00 pc<PHONE_NUMBER>7ee000  anon_inode:dmabuf
04-03 15:42:32.222 2902-2902/? A/DEBUG:     #01 pc<PHONE_NUMBER>016948  /data/data/<package.name>/cache/lib/myjnilib.so (deleted)
04-03 15:42:32.222 2902-2902/? A/DEBUG:     #02 pc<PHONE_NUMBER>000ac4  /system/lib64/libc.so (offset 0x64000)

The same test worked on the previous version.

Thanks for Your Feedback!
That is, it crashes at calling the original execve randomly? What about doing this in the parent process? If there is something wrong with instruction relocation, it should crash every time.

Well I'm pleased to hear that😄. Close it.


cli/deposit: significantly simplify validator keystore path

PR Description
currently the validator keys are stored in an unnecessary long path and file name, e.g.,
~/.opt/byz-f/teku q9-valid-path 7s
❯ ll ~/.local/share/teku/keystore/validator_0x8612758a1376713c90900c6681849f1e04b0bca243e00246657932822fd40589a8c55165fc3b480365bcce75fa854e5c/
total 16K
4.0K drwxr-xr-x  2 user users 4.0K Apr  8 21:25 ./
4.0K drwxr-xr-x 16 user users 4.0K Apr 19 14:58 ../
4.0K -rw-r--r--  1 user users  893 Apr  8 21:25 validator_0x8612758a1376713c90900c6681849f1e04b0bca243e00246657932822fd40589a8c55165fc3b480365bcce75fa854e5c.json
4.0K -rw-r--r--  1 user users  893 Apr  8 21:25 withdrawal_0x8dc343b8bfb07f5bc93d43299d65cf577dc76aa95473a5c2563a0149e15fb077eedd52a52f699943f60ebfa02d2f9745.json

this pull request proposes to simplify the path significantly for usability handling encrypted key files:
~/.opt/byz-f/teku q9-valid-path
❯ ll ~/.local/share/teku/keystore/validator_8612758/
total 16K
4.0K drwxr-xr-x  2 user users 4.0K Apr  8 21:25 ./
4.0K drwxr-xr-x 16 user users 4.0K Apr 19 14:58 ../
4.0K -rw-r--r--  1 user users  893 Apr  8 21:25 validator.json
4.0K -rw-r--r--  1 user users  893 Apr  8 21:25 withdrawal.json

Fixed Issue(s)
N/A

The primary reason to use public key suffix of bls keystore file name is to avoid overwriting of generated keystores; also if someone decided to move/copy them all in one folder.
Is the first 7 chars of pk meant to remain unique for all keys?  With this approach, we should make sure to not overwrite if files already exist. Also, the pk(2, 9) should that be appended to validator/withdrawal.json to still keep them unique enough?

At the moment this will have no impact on my existing automation, in that it is just about to be created 😁 Good timing as far as I am concerned

Thanks, I decided to restore a trimmed version of the pubkey in the filename.
~/.opt/byz-f/teku q9-valid-path
❯ ll ~/.local/share/teku/keystore/validator_8612758/
total 16K
4.0K drwxr-xr-x  2 user users 4.0K Apr  8 21:25 ./
4.0K drwxr-xr-x 16 user users 4.0K Apr 19 14:58 ../
4.0K -rw-r--r--  1 user users  893 Apr  8 21:25 val_8612758.json
4.0K -rw-r--r--  1 user users  893 Apr  8 21:25 wdr_8dc343b.json

Done :)


another implementation about breadcrumb in bootstrap

Now I saw the implementation you made about breadcrumb. My implementation is not of value.

Coverage decreased (-61.17%) to 37.32% when pulling 4f3f1a1fa9d44940412b4be7d712cb0d0d02dce8 on bperucchi:master into f7415b1294062c2d3b6c375e504b6d0ab8095c5c on ShPakvel:master.


District label shown as Unknown and active count shown in negative (-1)

District label shown as Unknown and active count shown in negative (-1). Below is the screen shot of data and it was taken from Tamil Nadu state.

This is not an issue. The reason why the unknown is negative is because the district for the deceased is not provided by the state at that point in time. So unknown active = unknown confirmed (0) - unknown deceased (1). Hence -1.

This is not an issue. The reason why the unknown is negative is because the district for the deceased is not provided by the state at that point in time. So unknown active = unknown confirmed (0) - unknown deceased (1). Hence -1.

Its fine. But it will be good to show as 0 or NA instead of showing in negative...


burpsuite: 2023.7.2 -> 2<IP_ADDRESS>

Description of changes
https://portswigger.net/burp/releases

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This runs properly for me on my x86_64-linux box, but I'm wondering why you went with 2<IP_ADDRESS> vs 2<IP_ADDRESS>, which looks like it was released at the same time. 2<IP_ADDRESS> is also out now, but Burp Suite updates so frequently that it'd be hard to keep on top of the latest version all the time.
Thanks for the PR! Hopefully it gets accepted soon.

Closed by #276325.


added my first file

I have created my first branch, created a new file and commited it

created a new file


Update core

Updated test to match semantics introduced by https://github.com/realm/realm-core/issues/7452


Some fixes and improvements for better usage

Thank you for this project, it was very useful for me implementing the automatic translation functionality on my open source project BartyCrouch.
When using this library I came across a few minor issues though which I all managed to fix. This pull request contains all those fixes – they are all minor but important changes. Please have a look at the commits for further information but here's a short overview of the commit messages first lines:

Stop overriding explicit fromLanguage with fallback
Move thread choosing logic to callback closure
Add support for Bosnian and Serbian languages
Add Language creator method from locale

You can see how I use Polyglot in the translateEmptyValues method within this class.
If you have any questions feel free to ask. I hope this helps.

Thanks for the PR! It looks like like one of the tests started failing. Mind taking a look? :)

It fails because of my change of API: The translate callback is no longer called on the main thread – see my commit message on a078ea9. I think you should review if this change is okay or not. If it is okay it is easy to change the tests accordingly, I can do that then. What do you think?

Backwards compatibility
Since this project hasn’t reached 1.0 yet, I’m OK with making small(ish) breaking changes. I can see why not everyone wants to receive the callback on the main queue. I will note this change in the release notes.

forLocale
Can we rename this to languageForLocale and rename the first parameter to languageCode? Also tests for this would be :sparkles:

Thanks for adding Bosnian and Serbian as well!

Thanks for reviewing. I plan do the suggested changes and update the pull request within the next two hours. Stay tuned ... :)

I have done the changes you requested and even added a few more languages (like Croatian or Kiswahili). Although I also changed the test to call the main thread in the block it didn't pass on travis. It is passing on my machine locally though so I can't debug the issue. Do you have any ideas what this might be?

That’s really weird! What do you think about moving the main queue change in to a separate PR so we can diagnose it separately and get you other changes merged in first? Thanks for adding all the tests too. :D

Yeah, let's do this like you suggested.

Two small comments, and I’ll merge! Thanks for making the changes. :rocket:

Done – ready for merge now, I hope. :checkered_flag:

:green_apple: :rocket:
Thanks again for this PR!! Awesome stuff. :smile:


python3Packages.connectedcars: init at 0.1.5

Motivation for this change
Python package for the ConnectedCars REST API
https://github.com/niklascp/connectedcars-python
This is a potential Home Assistant dependency.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120252 at 0d6609d1 run on aarch64-linux 1

2 packages built successfully:

python38Packages.connectedcars
python39Packages.connectedcars

1 suggestion:

warning: unused-argument
Unused argument: pytestCheckHook.
Near pkgs/development/python-modules/connectedcars/default.nix:7:3:
  |
7 | , pytestCheckHook
  |   ^

Looks like the related home-assistant pr has stalled.
https://github.com/home-assistant/core/pull/42357

Looks like the related home-assistant pr has stalled.

No need then for this module.


loadProducts only returns first subscription in group?

If I have subscription group:
com.mycompany.myapp.premium

and in that group has:
com.mycompany.myapp.premium.3months
com.mycompany.myapp.premium.1months

loadProducts only returns one of them
com.mycompany.myapp.premium.3months

Is this normal? If so, how can I list them both so the user has a choice to pick the subscription price/duration they are after?

I just made a typo. In my actual app I did by accident:
com.mycompany.myapp_premium.1months


TextBox with BorderThickness="0" shows ............ underline in disabled state

For some reason BorderThickness is ignored in IsEnabled="False" state.

Thank you very much!


Add HTML report

Add HTML report using datavzrd
This PR adds the generation of an HTML report based on the TSV file created by vembrane.
This report will be the main output of the workflow and should help in interpreting the variants
Features

New local module datavzrd.
Generation of an excel file with datavzrd that can be accessed through the HTMl report.
Splitting of the variant TSV file columns based on predefined groups using a python script preprocess_datavzrd.py. These generates separate tables, that are linked with each other in the HTML report and are separate separate tabs in the excel file.
a datavzrd_config_template can automatically render tick plots, heatmaps and hyperlinks based on definitions in the annotation_colinfo.tsv file. The yaml file is rendered with the YTE engine and has access to the columns from the annotation_colinfo.tsv file.
In general, this makes the adaptation, extension and design changes for the HTML report much more easy and adaptable through simple modifications of the annotation_colinfo.tsv file. Please have a look at the help text of the new parameters which describe these two new assets in detail.
A draft for a HTML report design that is defined in the annotation_colinfo.tsv file. This should be discussed together and need to be extended and adapted based on design decisions.
added an identifier for each variant that is based on the columns: "chrom","pos","ref","alt","id","Feature". The latter is added as the TSV file is per variant-transcript. This is used to reference between tables and define unique entries.
new parameters:

report: boolean for generating report
datavzrd_config: optional, needs a template that is provided in assets/datavzrd_config_template.yaml
annotation_colinfo: optional, needs a annotation overview that is provided in assets/annotation_colinfo.tsv

To-Do's:

It still needs to define docker and singularity containers with datavzrd and the necessary python packages for easy usage.
refining the HTML report design: adding links, splitting and formatting columns as e.g. dbSNP entries, SIFT column, etc.

I fixed a bug with channel handling.
Beforehand, it only generated one report for one sample, now the channels are combined so that each sample generates a report.
I also changed the process resource requirements for vembrane table and datavzrd to more realistic requirements.


Global middleware + custom controller + Controller::curr() triggers No current controller available

Defining global middleware (as per the middlewares documentation) which invokes a controller that relies on Controller::curr() triggers error No current controller available

Version

silverstripe/framework 4.4.1

Example code
YAML
SilverStripe\Core\Injector\Injector:
  SilverStripe\Control\Director:
    properties:
      Middlewares:
        CustomMiddleware: %$App\Middleware\CustomMiddleware

CustomMiddleware.php
<?php

namespace App\Middleware;

use App\Control\CustomController;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Control\HTTPResponse;
use SilverStripe\Control\Middleware\HTTPMiddleware;

class CustomMiddleware implements HTTPMiddleware
{

    /**
     * @param HTTPRequest $request
     * @param callable $delegate
     * @return HTTPResponse
     */
    public function process(HTTPRequest $request, callable $delegate): HTTPResponse
    {
        return Injector::inst()->create(CustomController::class)->handleRequest($request);
    }
}

CustomController.php
<?php

namespace App\Control;

use SilverStripe\Control\Controller;
use SilverStripe\Control\HTTPRequest;

class CustomController extends Controller
{

    /**
     * {@inheritdoc}
     *
     * @throws \SilverStripe\Control\HTTPResponse_Exception
     */
    public function handleRequest(HTTPRequest $request)
    {
    	// Throw an error exception
        $this->httpError(404);
    }

}

Trace
No current controller available
Controller.php:556
SilverStripe\Control\Controller::curr()
ErrorPage.php:106
SilverStripe\ErrorPage\ErrorPage::response_for(404)
ErrorPageControllerExtension.php:29
SilverStripe\ErrorPage\ErrorPageControllerExtension->onBeforeHTTPError(404, SilverStripe\Control\NullHTTPRequest, , , , , )
Extensible.php:468
SilverStripe\View\ViewableData->extend(onBeforeHTTPError, 404, SilverStripe\Control\NullHTTPRequest, )
RequestHandler.php:524
SilverStripe\Control\RequestHandler->httpError(404)
CustomController.php:19

This is a valid state of the application. A controller is decided during the main application flow (the inner-most layer of the middleware stack). The controller is then unselected at the end of that flow. Having a controller available with Controller::curr would be a bug imo.

As an example of what could be done here - you could adjust the routing information in a middleware based on something in the request - meaning a middleware can help delegate the request to specific controllers - for instance a middleware than handles Accept headers, if you choose to handle different response content types with different controllers.

I'm not sure if that would work for you, but it may become available after you delegate the request to the Director.
E.g.:
// Controller::curr() unavailable
$result = $delegate($request);
$controller = Controller::curr(); // should be available here
// ... do something ...
return $result;

P.S. currently it appears that we actually do routing before passing control to the middlewares, so we could potentially pass that info as well (or initialise Controller::curr). However, from this issue description it's not exactly clear what are the potential use cases for that .

If the controller state persists after delegating the request, I would consider that a bug.
The controller should be de-allocated after handling the request: https://github.com/silverstripe/silverstripe-framework/blob/f842ee2eec984002fce944157837251fea193b20/src/Control/Controller.php#L219

Sorry @jakxnz . I'm going to close this as expected behaviour. Feel free to discuss further and we can re-open if required.


Feat: Improving the UI of Hero Section for Mobile devices

Describe the feature
For mobile devices the hero section takes up a lot of vertical space resulting in additional scrolling, resizing of the texts along with its alignment needs to be done to improve the user experience for mobile users
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

please assign this issue to me @anuragverma108

Assigned!
Make sure to attach before & after screenshots in your PR. Also, star the repo before working on it. While creating your PR, ensure you pull all existing changes beforehand to avoid conflicts.
Happy open-source contributing!


Options page turn black

I currently have 11 short keys. Every time I add one more, total 12, the option page edit box turns black. I need to uninstall the plugin to be able to get back to the 11 short keys, and make it work again.
Using the Firefox port 1.9.5 on 78.7.1esr (64-bit)
Just noticed that it's screen resolution related. I don't have this issues on my larger screen!

Issue now as well on the larger screen, when I added more text and clippings.


Better integration with theme gruvbox

Currently when work with gruvbox light, most of them are really well, except the tab. Anyway to improve it?

@Akin909 No, it looks almost like the one in terminal. So I think it's gruvbox here.

I'll close this out since @parkerault added the gruvbox themes (gruvbox_light/gruvbox_dark) as native Oni themes!
The PR was #2088 in case anybody ends up here and wants a nice template for making a native Oni theme.


Sniff::merge_custom_array(): Remove support for incorrectly set custom array properties

Array properties passed in from a custom ruleset need to have a type="array" attribute.
Until now WPCS was lenient when this attribute was missing and would convert an array passed as a comma delimited string to an array.
This functionality was deprecated for the only property which still "officially" allowed for a comma-delimited string list in WPCS 1.0.0 and will now be removed.
The only exception are the two array properties which can also be set via the command-line, i.e. the prefixes property for the WordPress.NamingConventions.PrefixAllGlobals sniff and the text_domain property for the WordPress.WP.I18n sniff.
If - and only if - these properties are set from the command-line, the sniffs will still convert the received string to an array.
Refs:

#1390

This PR also removes the leniency for spaces surrounding array values.
PHPCS 3.2.0 includes a similar fix as was previously made in WPCS via PR #1185, which means that properties passed as arrays will already be trimmed, so no need to do it again.
Refs:

#1185
squizlabs/PHP_CodeSniffer#1689

This might catch folks out in a more subtle way than some of the more obvious fatal errors, so sufficient attention should be drawn to it in the release notes.


IRC v3 support

Is your feature request related to a problem? Please describe.
Currently, when messages in other chat applications, like Discord, get deleted or edited, they remain as they remain as they were prior to deletion in IRC. This is a little annoying.
Describe the solution you'd like
Ideally, it'd be great to get some IRC v3 support to resolve this issue, if possible. This should allow for a more seamless experience when using v3 clients, like IRCCloud.
Additional context
https://ircv3.net/faq.html
https://ircv3.net/irc/

I am not aware that IRC v3 would allow to alter message content or delete already sent messages.  You might possibly refer to a custom IRCCloud feature:
2018-09-27 15:18:00 | james | Add support for deleting messages in private team servers, and slack integrations
This is not something that could be integrated into matterbridge, it has to be done in an IRC bouncer or hosted client service.


Add color handle, accordion, coach mark, menu item tokens

Description
New tokens:

color handle, DNA-1261
accordion, DNA-1269
coach mark, DNA-1271
menu item, DNA-1260
picker-width DNA-1268

Updated token:

updated color-slider-minimum-length, DNA-1238

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Token Diff:
Tokens added (59)

accordion-bottom-to-text-compact-extra-large
accordion-bottom-to-text-compact-large
accordion-bottom-to-text-compact-medium
accordion-bottom-to-text-compact-small
accordion-bottom-to-text-regular-extra-large
accordion-bottom-to-text-regular-large
accordion-bottom-to-text-regular-medium
accordion-bottom-to-text-regular-small
accordion-bottom-to-text-spacious-extra-large
accordion-bottom-to-text-spacious-large
accordion-bottom-to-text-spacious-medium
accordion-bottom-to-text-spacious-small
accordion-content-area-bottom-to-content
accordion-content-area-top-to-content
accordion-disclosure-indicator-to-text
accordion-edge-to-disclosure-indicator
accordion-edge-to-text
accordion-focus-indicator-gap
accordion-minimum-width
accordion-small-top-to-text-spacious
accordion-top-to-text-compact-extra-large
accordion-top-to-text-compact-large
accordion-top-to-text-compact-medium
accordion-top-to-text-compact-small
accordion-top-to-text-regular-extra-large
accordion-top-to-text-regular-large
accordion-top-to-text-regular-medium
accordion-top-to-text-regular-small
accordion-top-to-text-spacious-extra-large
accordion-top-to-text-spacious-large
accordion-top-to-text-spacious-medium
coach-mark-body-size
coach-mark-edge-to-content
coach-mark-media-minimum-height
coach-mark-minimum-width
coach-mark-pagination-body-size
coach-mark-pagination-color
coach-mark-pagination-text-to-bottom-edge
coach-mark-title-size
color-handle-border-width
color-handle-drop-shadow-blur
color-handle-drop-shadow-color
color-handle-drop-shadow-x
color-handle-drop-shadow-y
color-handle-inner-border-color
color-handle-inner-border-opacity
color-handle-inner-border-width
color-handle-outer-border-color
color-handle-outer-border-opacity
color-handle-outer-border-width
color-handle-size
color-handle-size-key-focus
component-height-400
component-height-500
menu-item-top-to-selected-icon-extra-large
menu-item-top-to-selected-icon-large
menu-item-top-to-selected-icon-medium
menu-item-top-to-selected-icon-small
picker-border-width

Token values updated (1)

color-slider-minimum-length:

200px -> desktop: 80px, mobile: 100px

:tada: This PR is included in version 12.1.0 :tada:
The release is available on:

GitHub release
npm package (@next-major dist-tag)

Your semantic-release bot :package::rocket:


mir_eval integration for multi-level segmentation

This is currently blocked pending the merge of https://github.com/craffel/mir_eval/pull/125 , but it should be easy enough to do.
We simply need a function that extracts observations, groups them according to level, and then calls out to mir_eval.hierarchy.evaluate.
Optional bonus points: convert segment_* into multi-level annotations.  This may be more coherently done within the #28 issue though.

Fixed by merging #79


www.expedia.com

Hello @chrbrk ,
This repo is not being maintained anymore, but we are trying to keep it alive on a fork here, would you kindly submit your issue there and close this one here? :)


LXC can't delete containers with very long paths in it

Due to an accident I got this super-long path in a container. Deleting the container was impossible.  Deleting the path inside the container and then the container worked.
lxc version: 4.19 (snap)
Distro: Ubuntu 18.04(container) Ubuntu20.04 (host)
$ lxc delete --force build-test
Error: Error deleting storage volume: lstat /var/snap/lxd/common/lxd/storage-pools/build_cd/container
s/oskar-build-test/rootfs/home/user/home/user/home/user/home/user/home/user/home/user/hom
e/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/cor
vus/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/h
ome/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/c
orvus/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user
/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home
/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/corv
us/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/ho
me/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/co
rvus/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/
home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/
user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/corvu
s/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/hom
e/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/cor
vus/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/h
ome/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/c
orvus/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user
/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home
/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/corv
us/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/ho
me/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/co
rvus/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/
home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/
user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/corvu
s/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/hom
e/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/cor
vus/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/h
ome/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/c
orvus/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user
/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home
/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/corv
us/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/ho
me/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/co
rvus/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/
home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/
user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/corvu
s/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/hom
e/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/cor
vus/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/h
ome/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user/home/user: file name too long

Transferring to LXD.

Hi. I'm a CS student at UT Austin and am currently taking a Virtualization class. I would be happy to take a look at this issue?

Hi. I'm a CS student at UT Austin and am currently taking a Virtualization class. I would be happy to take a look at this issue?

It's Open Souce. You can see that there isn't a WIP PR referenced in this issues, so just start. If you're not super slow you're the first submitting a PR for this. If it doens't get merged, you still learned something. There will be no one in the FOSS community promising to strangers that their PR definately  gets merged.

@dillonsamra9 sounds good, assigning it to you!

@bionade24 we're used to working with UT Austin students, every year we get a few groups of students who get to contribute to open source projects as part of their virtualization class. We steer them towards our issues labeled as Easy since those are achievable within their allotted time and the LXD team has a good idea of what needs to be done and will help them should they have questions.
For tracking purposes, each member of a group looking at a specific issue/feature will comment so we can assign the issue to them and keep track on our side of what's going on and where we may need to provide additional help :)

@bionade24 we're used to working with UT Austin students, every year we get a few groups of students who get to contribute to open source projects as part of their virtualization class. We steer them towards our issues labeled as Easy since those are achievable within their allotted time and the LXD team has a good idea of what needs to be done and will help them should they have questions.
For tracking purposes, each member of a group looking at a specific issue/feature will comment so we can assign the issue to them and keep track on our side of what's going on and where we may need to provide additional help :)

Cool, didn't know that, whish my university would do such things.

Yep, it'd be really nice if more universities would do this. It helps open source projects get a few lower priority bugs and features off their plate and shows students how the open source community works and how easy it can be to add or fix something in a random piece of software :)

Taking this over so we can hopefully have a fix in 4.22

I'm having a surprisingly hard time reproducing this issue.

Marking as Incomplete and dropping milestone as I'm unable to reproduce it...
I managed to create myself a tree about 2500 level deep, trying to even access it from within the container gets me the File name too long but delete still works flawlessly, so Go's RemoveAll function seems to be handling it well.
That was on the dir backend too (ext4).

@bionade24 can you confirm that you had this issue on dir too (others wouldn't really make sense as they don't delete individual files) and maybe try to reproduce the behavior on your side?
Here I basically had a loop do for i in $(seq 5000); do mkdir -p home/user || break && cd home/user; done which will create a tree as deep as I possibly can. When that didn't work, I went the crazy way and ran through such loops to have three hierarchies each about 1490 level deep and then I moved them one at the end of the other causing a tree around 5000 level deep. Trying to run find or du against such a tree would immediately fail as it was way too deep, but I still had no problem getting rid of the instance with lxc delete.

I'm not exactly sure anymore how I made this recursive copy, but I definately used the btrfs storage backend.
If I remeber in the next days, I'll try again, both with dir? and btrfs` backend.

Ah, btrfs, that may explain it, will need to try with that instead.

For btrfs, we don't do a standard recursive delete so much as try to locate all subvolumes, delete those and then delete the main subvolume for the instance, so there may be something there.

Another thing: I'm somewhat certain that my path was way deeper than 5000. The recursive copy did run ~10s before I realized it. Not sure if this makes any effect, though.

The 5k deep one took quite a while to create, you'd think it'd be very fast but it really slows down after 1k or so.

Got it reproduced, it's indeed btrfs specific.

Sent in a fix which works for me here.


Drop python 3.8 support & napari backends

NEP29 https://numpy.org/neps/nep-0029-deprecation_policy.html

Codecov Report
Patch and project coverage have no change.

Comparison is base (93d18e7) 85.64% compared to head (4f9cd17) 85.64%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage   85.64%   85.64%
=======================================
  Files          30       30
  Lines        1957     1957
  Branches      296      296
=======================================
  Hits         1676     1676
  Misses        201      201
  Partials       80       80

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I need this merged for what I'm doing


How to play only audio?

I saw that there is an option audio_only, but I got an error when I try to set it up from within the YouTube-viewer:
Unknown option: audio_only
Is there a way to download only audio?

Try --resolution=audio. However, this works only for videos that have an audio portion separated from the video portion.

Works! Thanks!
Most of YT videos has a separated audio stream.
Is there a way to list all the possible formats for the video/audio streams?

Is there a way to list all the possible formats for the video/audio streams?

Not yet, unfortunately, but one can use youtube-dl for this purpose:
youtube-dl --list-formats [URL]

OK. It would be nice to add it to to_do list. :)

I will think about it. Thanks!


Fixes for issues #21 and #22

This merge request contains the proposed solutions for issues #21 and #22.
Please review, and merge if you agree.

I screwed up and my accident included the test file restructuring stuff. I'll close this merge request and try again.


Enderite boots and leggins (Ideas)

What if enderite boots had such possibility to walk faster,  sneak faster and run faster on end stone and end stone bricks? Permanent speed effect would be applied and we can configure everything in config.
Enderite leggins would always protect us from levitation effect dealt by shulkers. In config we can turn it on and turn it off.

I think enderite boots should have the ability to walk in the void as well. After all, all of the enderite stuffs can float in the air.


curl_multi_select() Bug

Apparently curl_multi_select() started behaving differently and now it results in a infinite loop.
Here are the related PHP bug reports, as well as (at least) 2 solutions:
https://bugs.php.net/bug.php?id=63411
https://bugs.php.net/bug.php?id=63842

Should be fixed here, https://github.com/jmathai/php-multi-curl/blob/master/src/MultiCurl.php#L104
Please reopen if you still see this bug. Note the library has been rev'ed to 2.0 and the older version can be installed via composer with version 1.0.


[Tools] clang-tidy: add used-after-move checking

clang-tidy has a bugprone checkings under: https://releases.llvm.org/14.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/list.html . I've checked all bugprone-, the result contains many style fixing.
This patch only adds a bugprone-use-after-move into clang-tidy. It detect a used-after-move in src/storage/compaction_checker.cc, moving rocksdb::Slice doesn't clear it contents.
And maybe we can enable all bugprone-* and do some NOLINT or style fixing in the future?

We need to specify the concrete name of checkers to prevent different checkers in different version of clang-tidy.


Add an option to print logs to console..

Hi @Zorono ! Writing the logs to the console is the default behavior.

Hi @Zorono ! Writing the logs to the console is the default behavior.

LOL... it seems that I am blind since I can't find anything that makes it writes to the console except debug pkg...


Add lms_user_id by default to the user model of new cookiecutter IDAs

Description
OEP-32 standardizes the lms_user_id as the canonical identifier of a user in Open edX.
However, the lms_user_id is currently inaccessible from the default edx-cookiecutter IDA.
This issue is to add something like https://github.com/edx/program-intent-engagement/commit/4de0f0db375fd5ce47ea568a0c7c3157193c8ccf to edx-cookiecutter so JWT_PAYLOAD_USER_ATTRIBUTE_MAPPING loads the lms_user_id of incoming users into the Django User model of new IDAs built from edx-cookiecutters.
Acceptance Criteria

Mirror commit https://github.com/edx/program-intent-engagement/commit/4de0f0db375fd5ce47ea568a0c7c3157193c8ccf into cookiecutter-django-ida.
Write ADR on why we didn't go further and sync the Django user id of the new IDA to the lms_user_id of incoming users.

Additional Information

Notes for ADR from 2022-12-21 Arch Hour

Consensus:

Let’s add the lms_user_id in by default: PR + ADR
Let’s consider in the future how to reduce the number of identifiers, especially considering future efforts of unifying identity at 2U

Enterprise may have a model for this in how they stub users if they are added to subscriptions before they exist in the LMS.

Raw discussion notes:

Confusion about canonical user identifiers - LMS user ID
Pie or Exams do this thing about auto-adding LMS user ID - should we add this to the cookie cutter?  Should new services automatically have the LMS user ID in their user model?
Well, maybe not all of them need it… but many may eventually need it?
Side note: Maybe we could set the id of the user in the new service to be the same as the lms_user_id?

What about conflicts?

We should have docs in the cookiecutter about this information
On the older services we didn’t have this for a long time. We were re-using an assorted variety of user identifiers across services. Users were and many times still are being created in LMS by different services.
Ecommerce was one of the first repos where we were trying to get the lms_user_id holistically added to all calls to/from the repo & LMS
Does Enterprise has any use cases of user imports?
Enterprise has a stub record we create if a user doesn’t pre-exist in LMS
Makes sense to have lms_user_id in the user model. Maybe a future thought is to reduce our total number of ids.
In the LMS, we do have the concept of external IDs.
We have global identity as well.
Maybe we have options to map it in the future.

Thanks @pshiu. Looks great. I'm going to make one edit to the ADR note.

I made a small modification to the ADR note, but will add more thoughts here instead:

The reason we aren't going further right now is because it would be large effort with unknown consequences. Are there still cases where we create the new user and don't yet have the lms user id?
I like using "Deferred/Rejected Alternatives" as a section title for ideas that were temporarily rejected, but might be considered in the future.

Also, I'm wondering if the cookiecutter needs a doc that summarizes decisions, or "what you get with the cookiecutter", and potentially explains alternatives? May not be necessary for this, but just a thought.

@pshiu: Have you seen this ADR? https://github.com/openedx/ecommerce/blob/master/docs/decisions/0004-unique-identifier-for-users.rst. It is also relying on social auth to get LMS user ids in certain cases. I'm not sure if that still applies, and how it would relate to cookie-cutter. I also remember that code being messier than it probably needs to be.

@robrap Very interesting! I should have been aware, I suppose, as a maintainer of ecommerce. Looks like we use add_lms_user_id() when ecommerce receives requests on behalf of other users but doesn't know their lms_user_id. A good case to add in the ADR.


add test case for HHH-16360

https://hibernate.atlassian.net/browse/HHH-16360
The has 1 failure for H2 (Date) and 2 failures for PostgreSQL (Date and Double)

Fixed via https://github.com/hibernate/hibernate-orm/pull/6639


Documentation Sync with Discourse

As discussed with Paulo and Erico, let's merge it AS IS, and apply changes on Discrouse to test PR here.


Overview Dashboard Update and Zone Dashboard

JS file of the zone dashboard page needs fixing.
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'active_energy')
    at zone-overview.js:319:118
    at async zone-overview.js:313:17


Export to PDF fails, but PNG and SVG work

Hi,
A user of my tool opened https://github.com/wdecoster/NanoPlot/issues/266. do you have some pointers on how to troubleshoot?
Kaleido is used here: https://github.com/wdecoster/NanoPlot/blob/master/nanoplotter/plot.py#L68
Errors are caught and logged. It turns out that exporting to PDF fails, but PNG and SVG do work...
Thanks,
Wouter

Thanks for your interest in Kaleido. We are currently working on an overhaul that might address your issue - we hope to have news in a few weeks and will post an update then. Thanks - @gvwilson


fix: random crashes in credentials.py

os.path.sep and os.sep are supposed to do the same but os.path.sep can lead to random crashes in newer python versions with the following error
AttributeError: module 'posixpath' has no attribute 'sep'
This is also known to other projects and is caused by some broken python versions
https://github.com/pytest-dev/pytest/issues/10547
https://github.com/Toblerity/Fiona/issues/1143
https://github.com/pallets/jinja/issues/1697
The small proposed fix will avoid the issue altogether, even with broken python versions

Thanks for the report, @markste-in. It's not clear for the other issues why this is happening. All the explanation appear vague. I don't think this is an unreasonable change though. I'm going to close/open the issue to get CI running since it appears to have not run when you opened the PR. We'll take a closer look after that finishes.

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.04% :tada:

Comparison is base (97ba590) 93.29% compared to head (bc69c32) 93.34%.
Report is 209 commits behind head on develop.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2946      +/-   ##
===========================================
+ Coverage    93.29%   93.34%   +0.04%
===========================================
  Files           64       66       +2
  Lines        13588    13957     +369
===========================================
+ Hits         12677    13028     +351
- Misses         911      929      +18

Files Changed
Coverage Δ

botocore/credentials.py
98.43% <100.00%> (ø)

... and 15 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support for CUDA Fortran in the Realm CUDA Hijack

We need to add support for CUDA Fortran in the Realm CUDA hijack. Attached is a very basic hello world example from @sdcohen that we can use for testing if things work.
hello-fortran-legion.tar.gz

Commit e4b9551 handles the apparently-not-illegal case of registering a kernel with the cuda runtime that doesn't actually exist.  With that out of the way, the attached repro case then fails because it is calling cudaDeviceSynchronize outside of a CUDA task, but that's easily fixed by removing the (unnecessary and ineffective anyway) call.


Use PHP 5.4+ array syntax

This library already forces to use PHP 5.5+ as a Composer requirement, so the usage of PHP 5.3 array syntax is useless.
I've also fixed the files ending where missed.

All PHP files MUST use the Unix LF (linefeed) line ending.

Isn't this what's done here?

https://github.com/doctrine/KeyValueStore/pull/57/files#diff-d83613af915085805a52265cf5644e13R233
https://github.com/doctrine/KeyValueStore/pull/57/files#diff-17813997ab4f807f22367951bc8a18eeR103
https://github.com/doctrine/KeyValueStore/pull/57/files#diff-e432860e4d0a2af83028f0b56edb6c5aR119


replace net/http with fasthttp

@kirillDanshin also just fixed CI config. we want use go get instead of go getting packages directly.


External link in menu

Question
Is it possible to add external links to the side menu? (e.g to a gitub repository)

As far as I know, this is not possible with the default theme, but you can customize it. See docs here: https://www.docz.site/docs/components-api. The API is fairly straightforward and easy to work with. I used to create my own theme: http://docz-theme-ztopia.surge.sh/

Yes, you can do it like this:
menu: [
    'Nav 1',
    'Nav 2',
    {name: '🔗 Github', href: 'https://github.com/'},
  ],

Also having this issue, this seems to be a regression since v1. @pedronauck will this be introduced back into v2?

{name: '🔗 Github', href: 'https://github.com/'}
Does not work for me. I get a non clickable menu item with an arrow down icon.

Same issue for me

For a little more information, it appears to render a link, it just only inserts '/'.

Found a workaround: {name: 'foo', route: 'https://makeflow.github.io/boring-router'}