do not add mtlsready label to mixer if controlPlaneSecurity is not enabled

Do not add the mtlsReady label to mixer components if controlPlaneSecurityEnabled != true
bug fix for --set global.controlPlaneSecurityEnabled=false --set global.mtls.enabled=true --set global.mtls.auto=true scenario
scenario that currently works:
--set global.controlPlaneSecurityEnabled=true --set global.mtls.enabled=true --set global.mtls.auto=true
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ X ] Installation
[ X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@GregHanson: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Can we have e2e test for this?
While I think this fix is ok, I think we may need different treatment for control jobs. Afaik, we use different port for mTLS and plaintext for mixer. The controlPlaneSecurityEnabled will change which port that pilot will program sidecar to talk to mixer. Thus, a fixed DR like this can be used for mixer in all cases. Your change will fix the plaintext mode, but I think it shouldn't needed in the first place, if this DR is always be installed.
spec:
  host: istio-policy.istio-system.svc.cluster.local
  trafficPolicy:
    connectionPool:
      http:
        http2MaxRequests: 10000
        maxRequestsPerConnection: 10000
    portLevelSettings:
    - port:
        number: 15004
      tls:
        mode: ISTIO_MUTUAL
    - port:
        number: 9091
      tls:
        mode: DISABLE

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/hold
I can close my PR then https://github.com/istio/istio/pull/18030.
Could you make mtls.auto default to true, and hold this PR util Diem fixed the plain text handling? https://github.com/istio/istio/pull/18017 So that we can have fewer cherrypick?
Right now that PR is pending because we observed that even we add a check if no server side mTLS is configured, transport_socket_matches is still configured.

Many tests will fail if we turn it on by default, and I believe many of them should be gone if we have @diemtvu 's PR merged.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
e154a838e082d8a16ff234f259c6e14c99675e56
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

closing in favor of diem's PR


Ledger warning typos

When you try to withdraw the rewards using a Ledger account, the following alert is displayed:

Due to the limitation of Ledgr device, using Ledger Nano S, Forbole X  can olny withdraw rewards from up to 5 validators at a time. Using Ledger Nano X, Forbole X  can olny withdraw rewards from 20 validators at a time.

This contains some typos. Here is the correct version:

Due to the limitation of Ledger device, using Ledger Nano S, Forbole X  can only withdraw rewards from up to 5 validators at a time. Using Ledger Nano X, Forbole X  can only withdraw rewards from 20 validators at a time.

Please add your planning poker estimate with ZenHub @rachelhox


Pagination methods returns same results for any page

As of v2.0.0 paginate() and simplePaginate() methods are returning the same results if you're not providing $page argument explicitly (but there's no info about it in documentation).
This happens because both paginate and simplePaginate methods provides their arguments to BaseRepository::executeCallback via func_get_args but its documentation says:

Note: This function returns a copy of the passed arguments only, and does not account for default (non-passed) arguments.

So, all non-passed arguments are ignored and only $perPage (which is obviously the same for every request) is provided.
As a quick-fix I did this:
use Illuminate\Pagination\Paginator;

[...]

$args = [$perPage, $attributes, $pageName, $page ?: Paginator::resolveCurrentPage($pageName)];

and I'm sending this array to executeCallback instead of func_get_args.
Another fix without touching vendor code is to provide all arguments from client code:
$paginator = $repository->paginate(25, ['*'], 'page', intval($request->input('page', 1)));

If first fix is ok for you, I'll create PR, just let me know.

Thank you for your issue reporting, I'm in a business trip for few days, so I'll check it once I'm back 👍

Hello @tzurbaev, sorry for the delay 😁
I've read your issue & it seems there's misunderstanding for how the executeCallback method works, you don't have to worry about the func_get_args method as it's not used in any logic other than the MD5 hashing for cache keys, so to make it clear all passed arguments are passed explicitly to the underlying model methods, here:
    public function paginate($perPage = null, $attributes = ['*'], $pageName = 'page', $page = null)
    {
        return $this->executeCallback(get_called_class(), __FUNCTION__, func_get_args(), function () use ($perPage, $attributes, $pageName, $page) {
            return $this->prepareQuery($this->createModel())->paginate($perPage, $attributes, $pageName, $page);
        });
    }

As you can see, all passed arguments $perPage, $attributes, $pageName, $page are explicitly passed to the model, so there should be no problem, and actually it's working fine as expected, example:
$repository->paginate(5, ['*'], 'page', 2)->toArray();

Now, we're querying the first 5 records, in the second page.
Documentation will be updated to reflect this pagination example, please if you've any other issues or if there's anything I didn't get correctly feel free to update this issue again 👍

Hey, @Omranic, thank you for your response.

you don't have to worry about the func_get_args method as it's not used in any logic other than the MD5 hashing for cache keys

But as I wrote, func_get_args ignores default (non-passed) argument values. And result of func_get_args is used to generate cache key. When $page value is not provided, repository will generate the same cache key for any requests (no matter what ?page=N value is) and return the same data for any page.
$repository->paginate(5, ['*'], 'page', 2)->toArray();

This call returns correct data, but I think these methods (repository's paginate/simplePaginate) should be compatible with Eloquent ones. Do we really need to pass all 4 arguments?

@tzurbaev Yes, I agree. And I think #54 fixed this issue already as it's now passed explicitly. Right?

@Omranic no, I've just added missing $page argument in #54. I'll do another PR today.


Dependency conformance tests

This adds an "on-demand" aka manually triggerable workflow that will allow you to test whether the package conforms with various dependency sets. This workflow uses the verdepcheck GitHub Action.

FYI @bundfussr @bms63

Hey @cicdguy will this trigger only with [skip vbump]?


How is the MCM matrix constructed?

Your thoughts on the MCM matrix are great, but our dataset may not match the MCM dimensions you have provided as we don't have as many GOterm's, so I'd like to construct my own MCM matrix, can you explain what the arrays in the matrix represent? Or can you share the steps you took to construct the MCM matrix?

Your thoughts on the MCM matrix are great, but our dataset may not match the MCM dimensions you have provided as we don't have as many GOterm's, so I'd like to construct my own MCM matrix, can you explain what the arrays in the matrix represent? Or can you share the steps you took to construct the MCM matrix?

As suggested in our paper, the max constraint module (MCM) in SPROF-GO adopts a K×K matrix M (e.g., https://github.com/biomed-AI/SPROF-GO/blob/main/script/utility_files/BP_CM.npz), where M_ij = 1 if the jth GO term is a subclass of the ith GOterm, and K is the number of GO terms that need to be predicted.


Buttons "Create", "Edit" and "Delete" for template tags are absent for user

Buttons "Create", "Edit" and "Delete" tags aren't available for role "User" in Images tab.
Steps:

Log in and go to Images;
Go to Tags tab of any Template or ISO

Actual result: Buttons for manage of tags aren't available for a role "User"
Expected result: Buttons for manage of tags are available for a role "User"
Connected feature: image_tag_create, image_tag_edit, image_tag_delete
Screenshot:

Test on:
tamazlykar/1012-template-tags-action-buttons
Regression:
image_tag_create, image_tag_edit, image_tag_delete

Tested on tamazlykar/1012-template-tags-action-buttons


comment out pieces of text/code

Is there a way to comment things out? The html syntax <!-- ... --> typically works with most markdown flavors, but Weave keeps what's inside, it seems. Sorry if I missed something obvious!

I've added support for html comment syntax in text chunks.


emojis

Hi, is there a way to get also the emojis/emoticons? Thank you.

You may have to get the raw data, but this is a technical stuff to do it.


Offer Dark Mode Version of Graphs & Charts

Hi @urk-stav, glad to see someone working on this. Projects like these, really help dealing with information asymmetry in our industry.
I'd personally want to see some dark mode version of these datasets. For users who have dark mode set-up, it can amount to being met with a flash-of-blinding-light, when navigating through a page, and be met with content against pure white background.
The opposite isn't true. As in, for readers that prefer light mode, being met with dark mode content (white-ish foreground, darker shade of background) won't be as jarring.
Would you be interested in publishing this as GitHub pages? If so, you might want to use Python MkDocs Material, and see if you can offer dark mode images for users who want dark mode, and light mode images for users who want light mode. For reference, check homepage of SimpleAnalytics.
Happy to help with PR, if you need.

Thanks for suggestions. Your argument is valid.
I'll add the plots in dark mode as well.
Will let you know if I need any help later.

Done!


How to create a plugin contains multiple sub-methods ?

I'm trying to transplant gulp-connect to fly, it uses different methods to control server behavior: start, reload and close.
In gulp, they use connect.server(), connect.reload() to call different methods.
In fly documentation, it didn't mention about a plugin other than a single function. How could I achieve similar behavior in fly ?
Or, I should just put these start/reload/close methods in plugin argument, like .connect({method: 'start', options: {...}}) ?

I just took a look at fly-kit-web and browser-sync . It looks directly usage is fine, may I don't have to wrap such tool as a plugin ?

Nope, I've been using browserSync for months now & haven't lacked anything.

Great! Now I'm clear what to use. This issue seems not so necessary now.


refactor compliance checks

Whether we stay on Circle or move to Jenkins, it's a safe assumption either way that we want to reduce our pipeline's dependency on (comparatively) heavy VMs and maximize the use of container executors. One consequence of that is that we want to avoid "D-in-D" scenarios as much as possible, so it's not desirable for OSBA's pipeline to build the OSB checker image like it does today.
Over the weekend, I extracted the OSB checker into its own image so that the OSBA CI pipeline doesn't need to build it itself.

Our pipeline is configured (for now) to not fail on compliance failures, so it's a good idea to look at the output to see that this refactor works as expected:
https://circleci.com/gh/Azure/open-service-broker-azure/2749
We have 11 failures-- same as before.

This failed lifecycle tests on a known flake-- deleting Redis timed out. I think it's quite clear that the scope of this PR has no bearing on those particular tests, so I'm making an executive decision to merge this.


Chunk file reads and tokenization for text to mds conversion

Read files and tokenize in 1MB chunks.
Addresses two issues:

Tokenization is significantly slower on long sequences.
Loading extremely large files into memory at once can cause OOMs

Manual Tests
Convert files of specific sizes
With changes:
test-mds-conversion-500mb-rZDKAm Took 8 minutes
test-mds-conversion-baseline-5gb-HRj4NE (ignore the fact that baseline is in the name lol) Took 1.5 hours
Without changes:
test-mds-conversion-baseline-500mb-QJy3gj Hanging-- stopped after 2 days
Training 1 epoch with sec filings small dataset
Confirmed that the token counts are the same.
With changes:
test-mds-conversion-mpt-7b-TRKKfd
Without changes:
test-mds-conversion-baseline-mpt-7b-XTf6c2
Training 1 epoch with 5.5MB file
Confirmed that the token counts are the same.
With changes:
test-mds-conversion-mpt-7b-5mb-UY6HtO
Without changes:
test-mds-conversion-baseline-mpt-7b-5mb-71friv

@mvpatel2000 Tokenizing large strings at once is really slow. HF tokenizers are typically optimized to shorter strings: https://github.com/huggingface/transformers/issues/25873#issuecomment-1701727782


logs warning from checking feature

I'm ignoring this- what does it mean?
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked
warning in 26a7509190100074: some data from annotation isn't used: checked

https://github.com/pombase/canto/issues/1184

Yep I'm not sure what this means in the logs... (if we  don't use this feature we don't need anything in the logs, but if we do need this feature we don't need anything in the logs....)

Yep I'm not sure what this means in the logs...

Sorry, the "checked" flag is leaking though into the Canto file that gets loaded into Chado.  It's harmless.  I'll fix the Canto exporter.


Support for Random

Is there any constructor for Faker that uses a Random? I want to use this library, but it would be nice to have a constructor that passes a Random, so we can set a seed.

What do you think about setting a seed through a setter, like in here?

Fixed with the release 1.4.4


using process.stdout.write

i'm using a typescript plugin for emacs -- tide. When the output is too large, the output string will alwayls be truncated and lead to a JSON parsing error. So i modified the NodeSystem write function.

Hi @shanexu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

I need this for colorized emit as well. :+1:

AFAIR we've originally used stdout.write and replaced it with current approach because sometimes after process exited some final writes were missed (presumably because of buffering). Switching to using fs.writeSync solved the problem.

fs.fsyncSync(1) not worked for me.

Can you share a repro?

This should be fixed.


Proposal : Data Collection / Webscraping

Proposing to collect data like player stats, information etc, later be used to view on the page etc.
will be using python to write the script. Next steps?

@aaryanshsahay are you going to do the  work as a backend only or do you have an idea of displaying it on a webpage?


Disable file logging for the project manager

Due to user:// returning the current working directory when no project is open, this caused logs to be written to $HOME most of the time.
@Rubonnek Can you test this to make sure it works as expected?
This closes #40305.

After merging the patch on my 3.2 branch, I'm still getting logs written to $HOME.

@Rubonnek I see, this is because project_manager is set after I check for its value. I don't know how to fix this at this point.
I force-pushed an attempt to fix it, can you try it again?

@Calinou any chance you could redo the patch against the 3.2?
The patch doesn't apply cleanly against the 3.2 branch -- I placed the change where I thought it should be at and I was not seeing logs at $HOME nor ~/.local/share/godot/app_userdata/project_test
I'll test against the 4.0 branch tomorrow.

Works fine on master.
But shouldn't we include a check for editor too? It seems that the editor doesn't produce logs right now, but I'm not sure if it's a feature or a bug, so it's probably better to be explicit about what we want.

Thanks!

Cherry-picked for 3.2.3.


Update create-cluster-kubeadm.md

更改一些翻译上的错误
Correct some faults on zh translation

Hi @encofcomic, thanks for the fix! Before we can take a look at your PR, could you please sign the CLA?

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

Thank you for your initial contribution. Please sign the cncf-cla agreement

Thanks a lot for reviews and I've finished signing the cncf-cla agreement.

/cla check

Due to the robot and didn't check to your signed can try to input I signed or check your local mail

Cause I lived in China mainland, it may just need some time to check everything out.

I signed

/cnck-cla check

@encofcomic  Can you modify it?

@encofcomic Can you modify it?

It seems apparently I could not LoL

/close


Added constructor overload to DaClient

Addresses issue #69

I'd prefer that the new constructor accepts a URL instead of a string.

Awesome. The only other thing is that you may be able to take out the suppression message now.

Yup, I already did take out the suppression. I also had to add a reference to OpcNetApi.dll in the CLI project in order to get it to build.

Ok, awesome. Thanks for your contribution.


Confusing behaviour with Array.new(size : Int, value : T) if value is passed by reference

This is not necessarily a bug, just confusing behaviour which I would suggest to mention/warn about in the docs (apparently no issue template available for that). I think it's best illustrated with an example (I'm aware it's somewhat un-idiomatic but my real use case is much more complex and requires the nested array to be built over multiple iterations)
strings = ["abbacababaca", "bbabaccbaba", "ccbabaaca"]
n_as = strings.map { |s| s.count('a') } # [6, 4, 4]
n_bs = strings.map { |s| s.count('b') } # [4, 5, 2]
n_cs = strings.map { |s| s.count('c') } # [2, 2, 3]

# Now I want to combine these values in a nested array so that each sub-array represents one string
# with the columns/elements describing the occurence of character X in that string, i.e
# nested = [
#   [as in string1, bs in string1, cs in string1],
#   [as in string2, bs in string2, cs in string2],
#   [as in string3, bs in string3, cs in string3]
# ] or, with the actual values:
# [
#   [6, 4, 2],
#   [4, 5, 2],
#   [4, 2, 3]
# ]

nested = Array.new(3, Array(Int32).new)

[n_as, n_bs, n_cs].each do |letter|
  letter.each_with_index do |s, i|
    nested[i] << s
  end
end

pp nested # => [[6, 4, 4, 4, 5, 2, 2, 2, 3], [6, 4, 4, 4, 5, 2, 2, 2, 3], [6, 4, 4, 4, 5, 2, 2, 2, 3]]

The problem is that nested is filled with not 3 different Int32-Arrays but rather 3 references to the same Array. If you initialize it as nested = Array.new(3) { Array(Int32).new } it behaves as expected. That is, as I said, not a bug and it made sense once I found the problem in my code, but while writing, it was not obvious to me that nested = Array.new(3, Array(Int32).new) would behave the way it did (and differently from nested = Array.new(3) { Array(Int32).new }) and lead to a quite confusing bug-hunt. So I would suggest either making them behave identically (as Array.new(size : Int, & : Int32 -> T) does) or mentioning/illustrating this pitfall in the docs.

@straight-shoota privately mentioned I probably miss-read your comment 😅 . It's a valid point that the default should be to duplicate the objects when populating the array. Sorry for the noise!

Probably would have to wait for 2.x then yea? Given we probably can't just switch what the method does under the hood as someone could be making use of that behavior.
What about like adding an optional named arg on that overload to determine the behavior. Then in 2.x you can swap the default of that flag.

An alternative is to make it clearer by changing the signature so that if it's a reference type, you'd have to write:
Array.new(3, reference_to: [1])

or something like that. For value types you can omit the named argument (just call Array.new(3, 1).
It would be a breaking change, though. That said, this seems to bite a lot of people, so it might be worth it.

What about like adding an optional named arg on that overload to determine the behavior

The problem is that this can't be determined using an optional named arg. Consider this:
Array.new(3, copy_of: [1])
Array.new(3, reference_to: [1])

In the first case a reference is being passed, no way to produce a copy later. Well, I guess it could depend on dup or clone, but it's not clear. That's why the "copy of" is the block form.

if it's a reference type, you'd have to write... For value types you can omit the named argument (just call Array.new(3, 1).

This is not enough:
x = Array.new(3, Slice.new(3, 1))
x # => [Slice[1, 1, 1], Slice[1, 1, 1], Slice[1, 1, 1]]

x[0][0] = 2
x # => [Slice[2, 1, 1], Slice[2, 1, 1], Slice[2, 1, 1]]

Similar goes for Set, so merely being a subtype of Value does not guarantee value semantics, and those types will continue to trip up users.

How about throwing a warning when T is not a primitive type (or a combination of?).

Just for completeness sake: I just checked Ruby and it has the same behaviour, but they do document it extensively in the docs (https://ruby-doc.org/core-3.0.0/Array.html#class-Array-label-Creating+Arrays) :

Note that the second argument populates the array with references to the same object. Therefore, it is only recommended in cases when you need to instantiate arrays with natively immutable objects such as Symbols, numbers, true or false.

To create an array with separate objects a block can be passed instead. This method is safe to use with mutable objects such as hashes, strings or other arrays:

Array.new(4) {Hash.new}    #=> [{}, {}, {}, {}]
Array.new(4) {|i| i.to_s } #=> ["0", "1", "2", "3"]

This is also a quick way to build up multi-dimensional arrays:

empty_table = Array.new(3) {Array.new(3)}
#=> [[nil, nil, nil], [nil, nil, nil], [nil, nil, nil]]

I think this would be the easiest and cheapest solution for now, pending any design decisions. When it comes to those, can anybody think of a use case when you would actually want to exclusively fill an Array with multiple references to the same object? I would guess that in (almost?) all cases what people mean to do is create an Array of clones and in that case that should be the default behaviour.

can anybody think of a use case when you would actually want to exclusively fill an Array with multiple references to the same object?

Something like targets = Array(Item).new(10, NO_TARGET_SELECTED) where default element could be a reference object as well as a value.
I think Ruby behaviour is totally fine in this case and silently changing it to cloning would cause subtle bugs (when porting from ruby or writing code with Ruby experience). A new method with different signature could be useful though.

Let's improve the documentation to make this stand out more explicitly. The code example actually already demonstrates the behaviour, we just need to spell it out. This is done nicely in the Ruby docs.
We can still continue this discussion whether we want to restrict the API in a way to disable this trap entirely so you can't fall into it even if you didn't read the docs 🧐

I finally made a PR to improve documentation: https://github.com/crystal-lang/crystal/pull/13962
However, I'd still like to go further in order to avoid confusion.
The alternative with a block (Array.new(size : Int, & : Int32 -> T)) is functionally equivalent. There's only a tiny difference in notation: Array.new(size) { value } instead of Array.new(size, value).
Having only the block variant should be completely sufficient.
It should be relatively easy to migrate calls from Array.new(size, value) to Array.new(size) { value }. This could even be automated (ameba maybe?).

After looking a bit into usage, it seems pretty clear that the value constructor is almost exclusively used with (primitive) numbers.
Going off on that, it might also be a consideration to keep this variant but only for primitives or similar (e.g. everything without inner pointers[^1]).
Not sure if this extra effort for keeping this variant for some value types would be entirely worth it. But it might?
Problem is, at the moment it's not really possible to implement a partial deprecation. It would need a mechanism to issue deprecations only on some instantiations of a method. A similar mechanism to the ASTNode#warning macro method could work for that.
[^1]: That would still exclude Big numbers because they have pointers, yet not reference semantics.


[Bug]: Inbound SOCKS connections are closed if there's no upload

Version number
The version of the application that has the bug.
refs/tags/v1.2.2
Describe the bug
A clear and concise description of what the bug is.
The inbound SOCKS server closes connections if no upload packet is received after a short time.
To Reproduce
Steps to reproduce the behavior:

SSH to a machine
Initiate any activity on the server that takes more than 5 seconds to complete.
Wait without entering any input
The SSH connection gets closed

Expected behavior
A clear and concise description of what you expected to happen.
SSH running indefinitely and connections not being closed.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]

Additional context
Add any other context about the problem here.

This is a bug that I think I've fixed. Hopefully, the next release will be better for you.


Autodetect base location

Instead of having a plan flag, the AI should find a place for the base by itself

We can start with finding the closest place to the controller that fulfills the required conditions.

For automatic claims, the AI places both the claim and plan flag. Assessed rooms have the center marked in the roomData cache.


fix: invalidate metadata cache when dataset fails to load

Reviewers
Functional:

@atolopko-czi

Readability:

@ebezzi

Changes

modify cache code. Update dataset cache to use path to dataset as the cache key (instead of the explorer_url). Invalidate items in the metadata cache when particular errors are raised.
Update tests to use symlinks to allow for dataset cache key change

Changes

modify cache code. Update dataset cache to use path to dataset as the cache key (instead of the explorer_url). Invalidate items in the metadata cache when particular errors are raised.
Update tests to use symlinks to allow for dataset cache key change

So the motivation for this change is to ensure cache provides the latest data if/when an Explorer URL-to-S3 Path mapping changes for a dataset?

Changes

modify cache code. Update dataset cache to use path to dataset as the cache key (instead of the explorer_url). Invalidate items in the metadata cache when particular errors are raised.
Update tests to use symlinks to allow for dataset cache key change

So the motivation for this change is to ensure cache provides the latest data if/when an Explorer URL-to-S3 Path mapping is no longer valid for a dataset? When is this occurring in practice?

This happens when a dataset is replaced or deleted in revision and that revision is pubished


Update Nexus and label Template deployments

Update Nexus to 2.14.8-01.
Also, by adding the app: xxx label to the OpenShift Template, the OpenShift console's UX is better regarding exposing Route URL's etc.


Pickup js-deps

With the configuration   skip in packageJSDependencies := false  scalajs compiler creates a file called module-jsdeps.js.
Is nice if the plugin could get automatically this file in         @playscalajs.html.scripts("/assets", projectName = "module") template

Hi @giovannicandido,
FYI, the scripts are in this repository https://github.com/vmunier/play-scalajs-scripts and are independent of the sbt-play-scalajs plugin.
We would have to check if the file exists before including it to not get a 404 NotFound. To check if the resource exists, the resource base path for assets (often set to /public) would have to be passed as an argument in the playscalajs.html.scripts template.
So in my opinion playscalajs.html.scripts should stay as is. But you can simply add one line yourself to your Play template if you have set skip in packageJSDependencies := false, e.g.:
<script src="@routes.Assets.at("exampleclient-jsdeps.js")" type="text/javascript"></script>

I think the routes.Assets.at could be used to infer the location. When I get a time I will look at this

Hi,
play-scalajs-scripts v0.2.0 has been published.

It includes a playscalajs.html.jsdeps template which is also used by playscalajs.html.scripts.
Note that the usage and order of the arguments in the different scripts have changed.
You should now call @playscalajs.html.scripts("exampleClient") where you previously called @playscalajs.html.scripts("/assets", projectName = "exampleClient")

See https://github.com/vmunier/play-scalajs-scripts/pull/2 for more details on jsdeps support.
Cheers,
Vincent


SPIR-V to MSL conversion error: PerVertexKHR decoration is not supported in MSL.

MoltenVK advertises support for VK_KHR_fragment_shader_barycentric, however attempting to use the pervertexEXT GLSL attribute results in the following shader compilation error: SPIR-V to MSL conversion error: PerVertexKHR decoration is not supported in MSL.
I don't see this feature marked as optional anywhere in the extension spec, is this something that could be supported, or at least made known to the application?

Not sure if there is a direct analog of this feature in Metal.
Metal only provides a uint primitive_id and just suggests users utilize this variable to access their vertex-buffer again from within the fragment shader.

In theory I think it would be possible for MoltenVK to do this behind the scenes to provide the PerVertexKHR attribute, I do not know for sure though as I'm not well versed with Metal.


[AWS] Subnet Selection from Provisioner or Node Selector

Currently, Karpenter is getting all the nodes having standard tag kubernetes.io/cluster/<clustername>, this gives in our case 9 networks only 3 of them are expected to be used for k8s hosts. After that it takes the network randomly because there's more than 1 subnet in the same AZ.
It Will be good to have a field that'll define the tag to be used for getting networks, it'll allow having networks for hosts separate from those used for load balancers.

I experienced a similar issue, where we define three groups of subnets for our EKS clusters - public, private, and pod subnets. Some workloads should target nodes in private subnet, and other workloads target nodes in public subnet. Today we pre-define this at the nodegroup/asg level and the workloads use their nodeSelector to target either nodegroup A or B.
Supporting subnet tags on the provisioner spec.labels field seems like one possibility (e.g. node.aws.k8s.io/subnet-tags) This would allow creating the default provisioner resource scoped to tags which specify the private subnets, and another provisioner scoped to the public subnets.

Sorry for the late response on this @pzelensky. We will take this internally and sort out a long term solution. If you're interested in discussing at our Working Group, that would be awesome as well.

How can I join the group?

How can I join the group?

This page has a calendar invite w/ an Amazon Chime meeting ID to join! We're looking forward to having you there! :)
https://github.com/awslabs/karpenter/tree/main/docs/working-group
The next community meeting is next Thursday June 10th

This will be available in v0.2.7


Move service registration before hosting startups run

This allows IHostingStartup to see default service registrations and override them.
Added a test to verify that hosting startup can see the IWebHostingEnvironment. Unfortunately this is used by MVC to get the application name before the container is baked. This was found when porting our workshop from 2.2 to 3.0

cc @DamianEdwards

Link to the MVC code that requires this?

https://github.com/aspnet/AspNetCore/blob/258d34e3828a1870a16d13cd3c62d1b7a65acc4a/src/Mvc/Mvc.Core/src/DependencyInjection/MvcCoreServiceCollectionExtensions.cs#L81

Sheish. AddMvcCore should have taken in the hosting environment or app name.


Upgrading with winget installs the new version side by side

What happened?
I had installed pulumi 3.31.0 using winget two days ago. Today I've upgraded to 3.31.1 by calling winget upgrade Pulumi.Pulumi -e. Now there are both versions installed.
Steps to reproduce
Install Pulumi 3.31.0
winget install Pulumi.Pulumi -e -v 3.31.0

Then upgrade to latest version
winget upgrade Pulumi.Pulumi -e

Expected Behavior
After upgrading, only the new version should be installed and shown in Windows' Settings / Apps / Installed apps.
Actual Behavior
Two versions are installed:

In fact, in the registry you can still find the old version. The uninstall entry for 3.31.0 is is at HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{230C2656-5C54-4ABF-A123-80FDDF1ADF7D}, and for 3.31.1 it's HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{4D02F09C-1233-4A06-ADB6-FA7D4085E5B3}.
Versions used
❯ pulumi about
CLI
Version      3.31.1
Go Version   go1.17.9
Go Compiler  gc

Host
OS       Microsoft Windows 11 Pro
Version  10.0.22610 Build 22610
Arch     x86_64

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Now that pulumi 3.32.0 was released, I cannot update it as there are two old installations:
❯ winget list -q pulumi
Name   Id            Version Available Source
---------------------------------------------
Pulumi Pulumi.Pulumi 3.31.0  3.32.0    winget
Pulumi Pulumi.Pulumi 3.31.1  3.32.0    winget

❯ winget upgrade Pulumi.Pulumi -e
No installed package found matching input criteria.                                                                                ```

@Zaid-Ajaj Could you please take a look?

Hi @thoemmi, thanks a lot for taking the time to file the issue and for the detailed report.
I will investigate this and let you know how it goes.
I think it has to do with UpgradeCode being different every release but I am not sure this is the one that is the GUID popping up in the registry

@Zaid-Ajaj Yeah, that seems to be the issue. In fact, UpgradeCode must be stable across versions, and you have to change the ProductCode instead. See Preparing an Application for Future Major Upgrades for more information.

@Zaid-Ajaj could you please share if this fix was released? I just upgraded from 3.33.2 to 3.34.0 and I see both in winget:
❯ winget list pulumi
Name   Id            Version Available Source
---------------------------------------------
Pulumi Pulumi.Pulumi 3.33.2  3.34.0    winget
Pulumi Pulumi.Pulumi 3.34.0            winget

@alecor191 Thanks for reporting back! I've not tested this because I don't have a Windows machine currently but based on your info, it seems that the issue remains.
Another way to tackle this could be the following: embed MSI instructions that uninstalls previously installed version. Will need to look into it

The last 2 or so versions of the pulumi installer have included the fix for the issue, if possible can someone confirm that indeed, new Pulumi CLI installs remove the previous version? 🙏 then we can close out this issue 😄

I got into the habit of uninstalling Pulumi before installing a new version. When there's a new version I'll try to remember to ubgrade directly and report the result here :wink:

@Zaid-Ajaj just wanted to try it out. However, it seems the latest version is not available on winget (yet): I'm on 3.43.1 and wanted to upgrade to 3.44.x, but it's not available yet:
❯ pulumi version
v3.43.1
warning: A new version of Pulumi is available. To upgrade from version '3.43.1' to '3.44.0', visit https://pulumi.com/docs/reference/install/ for manual instructions and release notes.

❯ winget search pulumi
Name   Id            Version Source
------------------------------------
Pulumi Pulumi.Pulumi 3.43.1  winget

Will wait a few days and then try again.

Agreed, I don't see a PR for Pulumi > 3.43.1 in the winget packages repository.

You are right! thanks a lot for reporting this 🙏 there should have been two new releases here but automatic deployment was failing, #19 will address this situation

PR in winget package registry has opened for latest release v3.44.1 https://github.com/microsoft/winget-pkgs/pull/86307

@Zaid-Ajaj changes look good for me!
Just upgraded from 3.43.1 to 3.44.1 and I see that afterwards only 3.44.1 is installed
❯ pulumi version
v3.43.1
warning: A new version of Pulumi is available. To upgrade from version '3.43.1' to '3.44.1', visit https://pulumi.com/docs/reference/install/ for manual instructions and release notes.

❯ winget upgrade pulumi.pulumi
Found Pulumi [Pulumi.Pulumi] Version 3.44.1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/pulumi/pulumi-winget/releases/download/v3.44.1/pulumi-3.44.1-windows-x64.msi
  ██████████████████████████████  97.7 MB / 97.7 MB
Successfully verified installer hash
Starting package install...
Successfully installed

❯ winget list pulumi
Name   Id            Version Source
------------------------------------
Pulumi Pulumi.Pulumi 3.44.1  winget

I too can confirm that the upgrade is now working smoothly.


add interpreter for hy

I added a interpreter for hy, which is needed for shebangs to get detected.
Description

The changes are rather simple, I also added a sample file.
I don't think that any of the checkboxes apply here, please correct me if I'm wrong, I am really unsure.
But this pull request doesn't introduce something new, it builds on what is alredy associated with hy.
Checklist:

[ ] I am associating a language with a new file extension.

[ ] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am adding a new language.

[ ] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a syntax highlighting grammar.
[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am fixing a misclassified language

[ ] I have included a new sample for the misclassified language:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am changing the source of a syntax highlighting grammar

Old: https://github-lightshow.herokuapp.com/
New: https://github-lightshow.herokuapp.com/

[ ] I am adding new or changing current functionality

[ ] I have added or updated the tests for the new or changed functionality.

@lildude There are only 4 users of this shebang. I'm not sure it's worth it...?

Please note that the hy docs even mention the ussage of shebang in their quickstart.
Also they use a different one than me, its actually around 600 peoploe.
sorry for not stating that stuff in my initial pull request.

Also they use a different one than me, its actually around 600 peoploe.

Oh, right! My bad, I should have looked for the /usr/bin/env format.
You'll need to move the sample file to the samples/Hy/filenames/ repository and to replace it with a more realistic one (from the search query for example, though it needs to be under a permissive license).

Oh, wait, you're right (and it's the second time I make that mistake). The sample file is in the right place, and the Travis CI build failure is unrelated to this pull request.

I hope this sample file is  okay.
I don't really know what to do about the failed test but yes, they are unrelated (maybe I should have mentioned that...).

The test failures appear to be caused by recent changes to licensee which has resulted in a slightly modified hash for the four licenses in question.

Yup, you'll need to merge master into your branch to fix the failing tests for a start.


Add thread resource

Request from @LukeHoersten to use Shake for benchmarking. That requires being able to suppress all other threads when running the timing-sensitive code. One way to do that would be to have a resource:
phony "benchmark" $ withResource resourceThreads n $ ...

This would attempt to take n threads. You could also imagine resourceThreadsAll which dynamically adjusted based on ShakeOptions.
Implementation wise, the easiest thing is just to grab increasingly more threads (stopping other things from starting), then once you have them all, execute the resource protected code.

I have a single expensive command to invoke. I think I would want to do this:
withResource resourceThreads 10 $ cmd "foobar +RTS 10"

Please let me know if I'm overlooking a superior alternative.
If not, this seems like a more compelling motivation than benchmarking. Thanks for such a great library!

I've implemented some of this in my fork. Roughly, the idea is that the Pool doesn't handle the thread limits anymore, instead calling need takes a normal (finite) thread resource and then spawns the thread. unsafeExtraThread releases the resource while executing whatever and then takes it back afterwards.
The interesting question is how taking extra threads interacts with unsafeExtraThread; you don't want to have un-counted threads running during your benchmark, but running them in parallel with a more generic expensive command is useful.


Automatic render

Is it possible to automatically render daily or on startup? Manual rendering works best when complemented with automatic rendering, avoiding the need to click.

For example when in the Contents side pane. The automatic feature can be on and off using an optional parameter.


Searching for network now times out after 30 seconds.

Thank you for your pull request. It took me some time to get to it. I looked the ipconfig source code and indeed, it seems to never timeout. I confess I find that behaviour extremely desirable, in the sense that, one of the major use cases of this hook is to enable the remote unlock of an encrypted partition, I want it to try for as long as possible to configure a interface using dhcp. Which, by the way, is one of the primary reasons why I recommend that this hook be used with static ip addresses.
Having said that, I think that implementing the timeout with a fixed value, won't suit to everyone's needs. With this in mind, I plan to add an optional kernel command lihttps://projects.archlinux.org/git/mkinitcpio-nfs-utils.gitne argument for this hook, that will represent the timeout and permit the adjustment of the value anyway the user see fit. Hopefully this will meet your and possibly someone else demand.
Keep in mind that this change won't affect systemd enabled initramfs, since it uses systemd-networkd and any kind of timeout would need to be specified on the .initramfs files that configure any interfaces and using systemd-networkd arguments.
Expect this functionality to be implemented soon in this hook.


feedback loop: upping testing

Codecov Report

Merging #364 into master will increase coverage by 0.1%.
The diff coverage is 73.33%.

@@            Coverage Diff            @@
##           master     #364     +/-   ##
=========================================
+ Coverage   89.44%   89.54%   +0.1%
=========================================
  Files          24       24
  Lines        1610     1616      +6
  Branches      102      102
=========================================
+ Hits         1440     1447      +7
+ Misses        132      130      -2
- Partials       38       39      +1

Impacted Files
Coverage Δ

poseidon/poseidonMonitor/test_poseidonMonitor.py
88.93% <100%> (+0.17%)
:arrow_up:

poseidon/poseidonMonitor/poseidonMonitor.py
72.18% <25%> (+0.75%)
:arrow_up:

...llerAbstraction/NorthBoundControllerAbstraction.py
92.2% <50%> (-0.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b4378...de9bf73. Read the comment docs.


Update GitHub Metrics Configuration and Plugins

TL;DR
Updated GitHub Actions workflow to enhance metrics generation and language analysis.
What changed?

Added base_indepth: yes to include more detailed base metrics
Set repositories_batch: 1000 to analyze a larger number of repositories
Included forked repositories in the analysis with repositories_forks: yes
Increased the language limit from 8 to 10 with plugin_languages_limit: 10
Extended the recent languages analysis period from 14 to 365 days
Increased the recent languages load from 300 to 1000

#59  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Oct 11, 10:47 AM EDT: A user merged this pull request with Graphite.


HMR not working with fresh Laraval installation/vuejs-boilerplate

Laravel Mix Version: 4.1
Node Version 12.10:
NPM Version 6.11:
OS: osx

Description:
On fresh laravel installation with laravel valet HMR is not working. I tried it with
"hot": "cross-env NODE_ENV=development node_modules/webpack-dev-server/bin/webpack-dev-server.js --inline --hot --https --disable-host-check --config=node_modules/laravel-mix/setup/webpack.config.js",

With and without HTTPS. In Chrome with trusted localhost... everythink.
app.js:727 Uncaught TypeError: Cannot read property 'call' of undefined
    at __webpack_require__ (app.js:727)
    at fn (app.js:101)
    at Object../node_modules/extract-text-webpack-plugin/dist/loader.js?!./node_modules/style-loader/index.js!./node_modules/css-loader/index.js?!./node_modules/postcss-loader/src/index.js?!./node_modules/sass-loader/dist/cjs.js?!./resources/sass/app.scss (app.js:4962)
    at __webpack_require__ (app.js:727)
    at fn (app.js:101)
    at Object../resources/sass/app.scss (app.js:28580)
    at __webpack_require__ (app.js:727)
    at fn (app.js:101)
    at Object.0 (app.js:28637)
    at __webpack_require__ (app.js:727)

Steps To Reproduce:

new laravel
npm install
add <script src="{{ mix('js/app.js') }}"></script> to welcome.blade.php
npm run hot

Hello, same problem here.
Every time I run default npm run hot command I need to comment content of my app.scss file, waiting for compilation, uncomment app.scss content and waiting compilation again.
I got this problem on three different project based on Laravel at now (two of them are v5.8 and one v6).
Follow my log:
app.js:770 Uncaught TypeError: Cannot read property 'call' of undefined
    at __webpack_require__ (app.js:770)
    at fn (app.js:130)
    at Object../node_modules/extract-text-webpack-plugin/dist/loader.js?!./node_modules/style-loader/index.js!./node_modules/css-loader/index.js?!./node_modules/postcss-loader/src/index.js?!./node_modules/resolve-url-loader/index.js?!./node_modules/sass-loader/dist/cjs.js?!./resources/sass/app.scss (app.js:103854)
    at __webpack_require__ (app.js:770)
    at fn (app.js:130)
    at Object../resources/sass/app.scss (app.js:148834)
    at __webpack_require__ (app.js:770)
    at fn (app.js:130)
    at Object.0 (app.js:148891)
    at __webpack_require__ (app.js:770)

hey, i'm getting the same error
Laravel Mix Version: 4.1 and 5
Node Version 12.10.0:
NPM Version 6.11.3:
OS: osx

I have same error
Laravel Mix Version: 4.0.7
Laravel: 6.0.4
NPM Version: 6.11.2
OS: osx
npm run hot!

I just realize that app.scss is compiled by default by webpack and it is linked as a resource in mix.config.js.
So, if you remove app.scss compilation from your mix.config.js and import it to your main .vue file (default is App.vue) hmr will works great again (and I think a little bit faster).
In your main vue file add tag style like this:
<template>...</template>
<script>...</script>
<style lang="scss">
  @import('.../path/to/app.scss');
</style>

@AleeeKoi that's it! really good and working idea! I was just wondering why in vue-cli version 3 hmr is working with scss compilation and i saw they do it exactly the same way!

@AleeeKoi do you have any idea how to use this with laravel mix and tailwindcss?

@StefanNeuser I think that you can configure manually webpack in your mix file to work with tailwindcss. All scss you put in a vue file can be managed with webpack.
The following guide seems to work, but some adaptation is needed:
https://medium.com/backticks-tildes/how-to-configure-your-vue-js-app-to-use-tailwind-css-a6f95d06e1c7

if its okay if you dont need to compile you scss/css when you are working on js-only (in this case vuejs) than the second example is properly a solution too: https://github.com/JeffreyWay/laravel-mix/issues/2074#issuecomment-538929366

This error pops up occasionally when i run npm run watch.
It goes away after i clear my browser cache. :)


Improve artifact definition specification

Done

Change request: https://github.com/ForensicArtifacts/artifacts/pull/11

Rename collectors to sources
Split Registry key and value types
add file and path separator

update documentation: https://github.com/ForensicArtifacts/artifacts/pull/36

To do

Make path relative to the file system root (absolute?)
Change provides so that it has clear type indicators like sources
Define a way to specify data streams
add tags/labels e.g. for persistence method

Based on https://github.com/ForensicArtifacts/artifacts/pull/12 there is a need to specify:

NTFS ADS names
HFS fork names

Not overload FILE but create FILE_DATA_STREAM source type, e.g.
FILE_DATA_STREAM:
paths:
{path:, stream_name:}

Describe the globbing and * handling and literal *
define what the format supports in terms of globs

Think about changing artifact definition from:
name: bla

to:
artifact:
  name: bla


RGB vs BGR?

Hello,
I was looking at your implementation and I believe the input to your model is an image with RGB ordering. I was also looking at the keras implementation and they use BGR values. I have been also testing with an map evaluation script and it seems that I get better results ;using the weights that you provided from the original caffe implementation, when I use BGR instead of RBG. Do you happen to know which order should we follow when using the original caffe weights?
Thank you very much :)

It should be BGR, but currently the pretrained model was trained with RGB code so when using it an RGB input is expected, I am planning to contribute a pretrained model that was trained with BGR, then the inconsistency could be removed

Thank you @alexkoltun :)

@alexkoltun how do you train with rgb when the vgg_fc_reduced weights from caffe is in bgr? Do you have a way to convert that to rgb or do you train the vgg_fc_reduced from scratch as well?

Same question. Is the pretrained model (vgg16_fc_reducedfc.pth) in BGR or RGB order?


fixed missing code block issue in getting_started page and removed redundant import in settings page

#511 issue fixed.

It's my pleasure.


README needs a few tweaks

Heyo, I stumbled upon a couple mishaps in the Readme:

The "Should I use this?" link in the fist section points to nowhere. It's a shame because I think that would have been a useful content as I genuinely asked myself "should I use this lib" 😅.
"Auto launch feature" and "Auto update feature" paragraphs are copy-pasted. The "Auto launch feature"  section should be rewritten.

The "Should I use this?" link in the fist section points to nowhere. It's a shame because I think that would have been a useful content as I genuinely asked myself "should I use this lib" 😅.
I found the old text for that part: https://github.com/felixrieseberg/electron-wix-msi/blob/ef51bebc1b66b89a48e47121659527e743c82b53/README.md#should-i-use-this


Fixed points scaling in matplotlib and bokeh

This PR supercedes @maxalbert's PR #390, by switching the function to return the area of points and for bokeh to convert those areas into widths. Changes a few tests but should be ready for merge once the data is updated.

All tests passing, scaling_method now works correctly and matplotlib and bokeh points scale in the same way. Ready to merge.

As I understand it, this really makes point scaling more sensible and consistent across the backends. As the tests are passing, I'll merge.


improved SSR rendering

Reduced duplicated code
Added more test coverage
Added component option resolving (async to sync conversion)
Allows resolvable components
Fixed component lifecycle
Added raw render method, to allow custom streaming possibilities

Let's avoid checking in dist files for now. (Only check-in dist on releases)

Oops didn't mean to..

@yyx990803 As discussed I have ammended the PR to work with resolving components, this is now done internally to prevent blocking the UI.
As mentioned we still need to ignore reactivity, and manually call hooks.


Tag frenzy

cc @fancyremarker

Should we continue to update the 2.3, 2.2, 2.1 tags as well (in addition to latest)?

Disregard my last comment, I missed e.g.:
ifeq "$(FROM_OS):$(FROM_TAG)" "debian:wheezy"
 # COMPATIBILITY: Wheezy gets the default Debian tag.
 PUSH_TAGS = $(TAG) $(RUBY_TAG)-debian
endif

👍


[zh] Sync changes in 使用 kubeadm API 定制组件

Fix https://github.com/kubernetes/website/issues/30302
$ ./scripts/lsync.sh content/zh/docs/setup/production-environment/tools/kubeadm/control-plane-flags.md
diff --git a/content/en/docs/setup/production-environment/tools/kubeadm/control-plane-flags.md b/content/en/docs/setup/production-environment/tools/kubeadm/control-plane-flags.md
index b5a283142..ff1fedb9c 100644
--- a/content/en/docs/setup/production-environment/tools/kubeadm/control-plane-flags.md
+++ b/content/en/docs/setup/production-environment/tools/kubeadm/control-plane-flags.md
@@ -9,12 +9,12 @@ weight: 40
 <!-- overview -->

 This page covers how to customize the components that kubeadm deploys. For control plane components
-you can use flags in the `ClusteConfiguration` structure or patches per-node. For the kubelet
+you can use flags in the `ClusterConfiguration` structure or patches per-node. For the kubelet
 and kube-proxy you can use `KubeletConfiguration` and `KubeProxyConfiguration`, accordingly.

 All of these options are possible via the kubeadm configuration API.
 For more details on each field in the configuration you can navigate to our
-[API reference pages](https://godoc.org/k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm/v1beta3).
+[API reference pages](/docs/reference/config-api/kubeadm-config.v1beta3/).

 {{< note >}}
 Customizing the CoreDNS deployment of kubeadm is currently not supported. You must manually
@@ -202,7 +202,7 @@ For more details see [Configuring each kubelet in your cluster using kubeadm](/d
 To customize kube-proxy you can pass a `KubeProxyConfiguration` next your `ClusterConfiguration` or
 `InitConfiguration` to `kubeadm init` separated by `---`.

-For more details you can navigate to our [API reference pages](https://godoc.org/k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm/v1beta3).
+For more details you can navigate to our [API reference pages](/docs/reference/config-api/kubeadm-config.v1beta3/).

 {{< note >}}
 kubeadm deploys kube-proxy as a {{< glossary_tooltip text="DaemonSet" term_id="daemonset" >}}, which means

/lgtm


Error while editing the chart : smiles

A clear and concise description of what the bug is.
Expected results
to edit the charts
Actual results
shows smile icons
Screenshots
charts on dasboard

but when edit chart page shows

Environment
superset version: Superset 0.999.0dev
python version: Python 3.6.9
node.js version: v10.18.1
npm version:
Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.

[x] I have reproduced the issue with at least the latest released version of superset.

[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
log worker:
Loaded your LOCAL configuration at [/app/pythonpath/superset_config.py]
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
ERROR:flask_appbuilder.security.sqla.manager:DB Creation and initialization failed: (psycopg2.OperationalError) FATAL:  the database system is starting up
(Background on this error at: http://sqlalche.me/e/e3q8)
Loaded your LOCAL configuration at [/app/pythonpath/superset_config.py]
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully
/usr/local/lib/python3.6/site-packages/flask_caching/init.py:189: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
"Flask-Caching: CACHE_TYPE is set to null, "
worker: Warm shutdown (MainProcess)
INFO:root:logging was configured successfully

but no error on local ip

clean setup fixed


Feature: Workspace persistence

This adds the necessary persistence infrastructure, as well as global and workspace stores for persisting the following items:

Oni2 version
Workspace path
Window position
Window size

It can be merged as-is, but there's a couple minor issues I'd like to iron out that requires upstream changes:

[x] Fix "jumping" when restoring position
[x] Store and restore maximized state

Edit: Actually, this shouldn't be merged until I've converted the write to use Libuv, as it's currently blocking.
Fixes #640
Fixes #619 - We now fall back to Documents instead
Fixes #906 - We now fall back to Documents, and then ultimately to $HOME
Addresses #639, #1659

So nice to have the window size and position persisted! 🎉

I think the CI is hitting the same issue I saw in #1627 - I worked around it by adding this resolution:
"@opam/conf-pkg-config": "1.1"

Yeah, I saw that and adopted it in https://github.com/revery-ui/revery/pull/826 as well. Will bring it over here once that's merged, unless you've merged #1627 by then.

Hmm, this seems to fail everywhere except on my computer. Currently building on my Macbook to try there, but could you try this on Windows as well @bryphe ?

Hmm, this seems to fail everywhere except on my computer. Currently building on my Macbook to try there, but could you try this on Windows as well @bryphe ?

Sure, taking a look - my guess would be that the syntax server is failing to start for some reason - might've been impacted by changes to the cli or logging in Oni2_editor.re 🤔

One of them definitely has an issue with the syntax highlighting, but the rest seem to all fail for different reasons. I'll restart to see if perhaps we can get even more flavors!

/azp run

Fun 😄 It seems on OSX, it's failing when running this command
esy x Oni2 -f --version
which outputs:
##[error]Bash exited with code '2'.

exit code 2 is usually an OCaml exception - so we could try adding --debug to that invocation and see if we can get a stacktrace.

Same sort of failure on Windows. I think adding that --debug flag might give us a clue. I'll try it out on Windows too.

I think it's related to not having a ~/.config/oni2 folder on the CI machines - I moved mine and am getting an exception now (esy x Oni2_editor -f --version isn't outputting anything)
...but it's great that it caught this!

It seems like in the case where ~/.config/oni2 isn't created, it's crashing here:
  let store =
    instantiate("global", () => Schema.[entry(version), entry(workspace)]);

Hmm, shouldn't that be created automatically? And shouldn't some integration test try to exercise user configuration or keybindings or some such?

It gets created here in Filesystem.re:
let getStoreFolder = () =>
  getUserDataDirectory()
  >>= getOniDirectory
  >>= (dir => getPath(dir, "store"))
  >>= getOrCreateConfigFolder;

I think the problem is the getOrCreateConfigFolder (where the creation happens) is happening after trying to get the store path

And shouldn't some integration test try to exercise user configuration or keybindings or some such?

The integration tests do exercise user config and keybindings, but they create separate folders for it (mainly to prevent it from paving a developer's configuration when they run it 😬 )

There's really not much happening in instantiate before that gets called:
  let instantiate = (name, entries) => {
    let hash = Internal.hash(name);
    let filePath =
      Filesystem.getStoreFolder()
      |> Result.map(storeFolder => Filename.concat(storeFolder, hash))
      |> ResultEx.flatMap(Filesystem.getOrCreateConfigFolder)
      |> Result.map(folder => Filename.concat(folder, "store.json"))
      |> Result.get_ok;
    let store = {name, hash, filePath, entries: entries()};

The integration tests do exercise user config and keybindings, but they create separate folders for it

Right, that's the complicated override code.  It would be better to override the config folder more generally I think, and maybe that'd solve this issue as well.

In the meantime I can make sure to handle this more gracefully in the Persistence code. Just log an error and just continue without actually reading and writing anything.

It looks like the bug is in the mkdir function in Filesystem - which we call in getOrCreateConfigFolder:
    | None =>
      /*
       No folder was present, lets make one.
       */
      mkdir(configDir, ()) >>= (() => return(configDir))

The function is:
let mkdir = (path, ~perm=userReadWriteExecute, ()) => {
  Unix.(
    try(mkdir(path, perm) |> return) {
    | Unix_error(err, _, _) =>
      error(
        "can't create directory '%s' because '%s",
        path,
        error_message(err),
      )
    }
  );
};

AFAIK, mkdir doesn't let you make a path of nested subdirectories... We need a better mkdir that handle a 'path' of subdirectories.
Before, we'd mkdir("~/.config/oni2"), but now we're using mkdir("~/.config/oni2/store")... and I guess that extra path is causing it to fail. A quick fix could be to ensure that we're creating the ~/.config/oni2 folder first, before anything else. A better long-term fix would be to set up mkdir to recursively create subdirectories, so that it can handle arbitrary paths.
And it seems like this could also fail in the case where a user had no ~/.config/ directory at all...

@reason-native/fs has a mkDirP:
https://github.com/facebookexperimental/reason-native/blob/bb80cbca60210bd1832c280c1bbcfb2bf3add6d5/src/fs/Fs.rei#L209-L221

I tried the latest, and I'm still seeing a crash on WIndows unfortunately.

Ok, identified the crash!
(Invalid_argument "First token in path C:\\Users\\bryphe is not absolute.")
Raised at file "src/fp/Fp.re", line 220, characters 6-98
Called from file "src/dir/Dir.re", line 117, characters 16-35
Called from file "src/dir/Dir.re", line 187, characters 13-48
Called from file "src/dir/Dir.re", line 341, characters 8-20

Looks like Fp doesn't support windows style back-slashes. Looking at a place we can normalize these paths to work around it for now.

Ok, took some time but got it working now - turns out there were a couple blockers... I documented them more thoroughly in a PR to dir: https://github.com/facebookexperimental/reason-native/pull/251

Oh, I didn't notice that this is ready to be merged. I was waiting for reason-native to be updated! Thanks @bryphe!


Merchant requesting to be added to store list.

Hi there, started accepting Monero on my store through Globee today.
https://namechains.myshopify.com
Cheers
P.

i'm on it

#793
+merchant
+in progress


Remove dependency cheching and dynamic population of install_requires from setup.py

https://github.com/autonomio/talos/blob/master/setup.py#L28
It is not needed anymore, pip willmupdate libraries only if the update is actually required. Dynamic population of that metadata field results in incorrect metadata differrent for different machines.

Good catch.


Update contract form

Changes in this PR

added controllers, routes, views and form for existing_contract and new_contract

Screenshots of UI changes

Excited to see the screenshots

There is an inconsistency with the change links; a stray hyphen.


[FEATURE] Catching exceptions

Is your feature request related to a problem? Please describe.
Some functions can be the cause of exceptions which we can't handle by returning values. So we need to create catch statement
Describe the solution you'd like
I think we don't need to create try block. Just catch statement after some code:
import standard;
workflow main
{
    integer temp = int("text");
    catch CastException
    {
        println("Catch exception")
    }
}

Added in 7bf0281


Add implementation of repr to validators

It would be good if something like this was supported:
>>> repr(validate_int(max_value=10))
'validate_int(max_value=10)'

Currently we have this:
>>> repr(validation.validate_int(max_value=10))
'<function validate_int.<locals>.validate at 0x7fb8aa042ea0>'

Fixed!


link errors building master on OpenBSD due to -Wl,--no-undefined

Using cmake on OpenBSD 7.0.  make VERBOSE=1 gives:
/usr/local/bin/cmake -E cmake_link_script CMakeFiles/matio.dir/link.txt --verbose=1
/usr/bin/cc -fPIC  -Wl,--no-undefined -Wl,--retain-symbols-file,/home/builder/external/matio-bin/src/matio.sym -shared -Wl,-soname,libmatio.so.11 -o libmatio.so.11.0.3 CMakeFiles/matio.dir/src/endian.c.o CMakeFiles/matio.dir/src/mat.c.o CMakeFiles/matio.dir/src/io.c.o CMakeFiles/matio.dir/src/inflate.c.o CMakeFiles/matio.dir/src/mat73.c.o CMakeFiles/matio.dir/src/matvar_cell.c.o CMakeFiles/matio.dir/src/matvar_struct.c.o CMakeFiles/matio.dir/src/mat4.c.o CMakeFiles/matio.dir/src/mat5.c.o CMakeFiles/matio.dir/src/snprintf.c.o CMakeFiles/matio.dir/src/read_data.c.o  -lm /usr/lib/libz.so.6.0 -Wl,-rpath-link,/usr/X11R6/lib:/usr/local/lib
ld: error: undefined symbol: malloc

Running that line manually without the -Wl,--no-undefined results in a successful linking.
I'm not familiar with what that is, or why it's there...

Thanks for reporting. Does it work when build by GNU autotools?

Seems like yes, and I'm able to run the tests (many fail, but whatever).

I added FreeBSD OS by Cirrus CI and cannot reproduce: https://cirrus-ci.com/build/5653130858725376

Did you fix it?  Or is one expected to use autotools and not CMake?

No, cannot fix as I do nat have a patch if I cannot repoduce.

Looks like there is no OpenBSD option with Cirrus CI?  I reproed in a VM with a very vanilla OpenBSD installation.  That's a fair bit of work of course, which I'm not expecting you to do...

PR is welcome.

I'm also able to solve the link error explicitly adding -lc, to link against libc, which contains malloc.
The OpenBSD docs say "it is not necessary to supply the loader flag -lc", so that's a bit surprising, but maybe that general statement does not apply when --no-undefined is also supplied.
In any case, adding -lc explicitly should be harmless, and seems a good way to fix this.  But I'm not sure where's the best place to add it...

Can you please give f058e5d a try?

That worked!  Thanks!

Thanks for confirmation!


Add Summary card showing current date, next prayer & remaining time for next prayer

Add Summary Card on top of the table in the parent layout, that includes:

Day of week & current date
Next prayer
Time remaining for next prayer

To be done in future PRs: hijri date, nearest masjid, optional distance sort
Here is how it looks on desktop:

on mobile:

Can you please explain how the time remaining is calculated? I suggest writing the masjid name / time in small font below the timer.
Also by the way, does it count down on every second?
I also suggest to hide the site intro text and make it show when clicking/hovering on an information icon to save space.

It's calculated by reusing the next prayer detection logic, so it takes the last masjid having the next prayer.
It doesn't count every second because it uses the time property of iqama, if we need seconds, maybe we can use seconds_since_midnight and add seconds field to the counter.
About your suggestion, I do recommend putting this into an About page, and for the home page we could add one line, small intro, tobe more informative.

Can you please explain how the time remaining is calculated? I suggest writing the masjid name / time in small font below the timer.
Also by the way, does it count down on every second?
I also suggest to hide the site intro text and make it show when clicking/hovering on an information icon to save space.

It's calculated by reusing the next prayer detection logic, so it takes the last masjid having the next prayer.

The semantic is then: time remaining for last chance to pray. Don't we need to show the first available masjid (nearest iqama)? How about a range or 2 timers?

It doesn't count every second because it uses the time property of iqama, if we need seconds, maybe we can use seconds_since_midnight and add seconds field to the counter.

I think seconds_since_midnight is more reliable as it is the parsed value from the iqama string. No need to parse it again in the frontend code. It should be ignored if its value is 0 (Not parsed like "5 minutes after athan"). My question is more about the timer being dynamic, does it even get updated on every minute change or it is a one time calculation?

About your suggestion, I do recommend putting this into an About page, and for the home page we could add one line, small intro, tobe more informative.

Agreed.

@hammady Sorry for the delay, I removed all parse logic that uses the iqama time, now it uses seconds_since_midnight_utc. And making the timer dynamic would look cool, so I added this feature and added seconds to the timer.
About showing nearest iqama/2 timers, I'm not sure, are we going to show 2 timers with the masjid name below each? My thought was to display the least info to know the remaining time quickly.

@hammady Sorry for the delay, I removed all parse logic that uses the iqama time, now it uses seconds_since_midnight_utc. And making the timer dynamic would look cool, so I added this feature and added seconds to the timer.

Excellent!

About showing nearest iqama/2 timers, I'm not sure, are we going to show 2 timers with the masjid name below each? My thought was to display the least info to know the remaining time quickly.

If we want to show the minimal information, I believe we should show the time to "next available iqama" not the "last chance to pray". This is simply the minimum positive distance between current time in seconds UTC and the iqama times from all masjids.

@hammady Sorry for the delay, I removed all parse logic that uses the iqama time, now it uses seconds_since_midnight_utc. And making the timer dynamic would look cool, so I added this feature and added seconds to the timer.

Excellent!

About showing nearest iqama/2 timers, I'm not sure, are we going to show 2 timers with the masjid name below each? My thought was to display the least info to know the remaining time quickly.

If we want to show the minimal information, I believe we should show the time to "next available iqama" not the "last chance to pray". This is simply the minimum positive distance between current time in seconds UTC and the iqama times from all masjids.

My thoughts were to use existing logic for the next prayer, but what you said makes sense. Let me do it

@hammady This screenshot at the time of this message, that's your timezone, I'm not sure if anything wrong here

@hammady This screenshot at the time of this message, that's your timezone, I'm not sure if anything wrong here

Note it uses an old notiifed.json file, I didn't update it today

@hammady Sorry for the delay, I removed all parse logic that uses the iqama time, now it uses seconds_since_midnight_utc. And making the timer dynamic would look cool, so I added this feature and added seconds to the timer.

Excellent!

About showing nearest iqama/2 timers, I'm not sure, are we going to show 2 timers with the masjid name below each? My thought was to display the least info to know the remaining time quickly.

If we want to show the minimal information, I believe we should show the time to "next available iqama" not the "last chance to pray". This is simply the minimum positive distance between current time in seconds UTC and the iqama times from all masjids.

My thoughts were to use existing logic for the next prayer, but what you said makes sense. Let me do it

I believe both logics should be the same?
Next prayer is the one with at least next one iqama available.
Summary box: the same next available iqama from the match above.


Native ads support

Any plans to support native ads?
https://admob.google.com/home/resources/native-ads-playbook/

Any luck?  I can't find any projects that seem to work with ionic 5 at all, it is very frustrating :(  Nothing has been updated for over a year.

Unfortunately not, the feature would be very helpful


fix: add displayName and ui to layout components

Closes #2876
Description

Added displayName and ui to layout components
Current behavior (updates)

New behavior

Is this a breaking change (Yes/No):

No
Additional Information

Thanks!


IIIT Kancheepuram and IIIT Tiruchirapalli links not working

kancheepuram is spelled as kanchipuram ('i' instead of 'ee') which causes links to fail.
tiruchirapalli is spelled as tiruchirappalli (extra 'p') whisch causes link to fail.

I'm working on it.

I have fixed the issue and generated pull request #13 .
Please review it and merge it accordingly, and close the issue #12


Fix typos

infrastucture -> infrastructure

Coverage remained the same at 73.562% when pulling a6a0db708a606a6d4246cde1aa66488486a20bf8 on tiagorlampert:master into 9790d6f135c1c8cfccc0c797f47d9c68eaa48d90 on Miserlou:master.


Android: Opening link after inactivity data clear time fails to load page.

Task/Issue URL:
Tech Design URL:
CC:
Description:
Steps to test this PR:
1.
1.

Internal references:
Software Engineering Expectations
Technical Design Template

@CDRussell would you mind to review this draft to validate if the approach is correct?

@cmonfortep, happy to. would need to be next week though if that works for you

All good, whenever you have time for it.

We will try to analyze first what's the impact of this bug and how many possible launches are affected. After that, we will prioritize and look for a new strategy.


How to visualize different instances of the same .bpmn file?

I'm using signaling between two different processes, but the signal name is tied to the business key so that a signal from Process 1 won't affect all of the processes of Process2, only those with the same business key. Operationally, this is working well.
From a test perspective, I'm starting up 2 instances of Process 1 and 2 instances of Process 2 and only 1 pair of them have a matching Business Key. I want to assert that only the matching Process 2 instance is affected. Again, the test setup works.
However, in the visualization of the process coverage, the visuals are consolidated so you see the results/status of both instances (the two instances of Process 1 are combined and the two instances of Process 2 are combined).
Is there a way to separate the reporting into a per-instance view for this kind of interaction test?

@dominikhorn93 as it is about visualization - do you have an idea?

@zambrovski not possible right now. We don't save any instanceIds in the event.
{
  "source": "FLOW_NODE",
  "type": "START",
  "definitionKey": "StartEvent_OrderReceived",
  "elementType": "startEvent",
  "modelKey": "order-process",
  "timestamp":<PHONE_NUMBER>
}

If we change that, we could extend the report with a "select instance" functionality


Error: Failed to post a status (nil) on commit

Ok, error first seen while debugging Issue #261
The problem seems intermittent, and when debugging the earlier issue, I saw it in passing, but was unable to make it happen on every request.  Letting the syncer run overnight or for long periods, I see this type of error several times a day, but have not recognized a pattern.
The (nil) in the title was an addition in my code (status) to see what status was attempted to be posted.  When I see the error, it is always nil.

[ERROR]: Syncing encountered a problem. Error: Failed to post a status nil on commit 46a596181769e02277a19c2a09848d1b203fb7d0 of repo myproject/my-repo. Context: SyncPair: PR (407:k/1234-wheel) + Bot (β [my-repo] k/1234-wheel)

Looking for suggestions on what might be causing the problem (including that the status it is posting happens to be nil)
A related question is:
Is Buildasaur supposed to add any comments to the PR, for example with the results of the build?
I do not see any comments created by Buildasaur on the actual PRs.  I do see the status info where I see "1 build", "1 build in progress", or "1 build failed", but no other info.  Clicking on the status does send me to Xcode to view the status.  Is the status from the build supposed to be posted as a comment or not?
Running 1.0.0-b2, code forked for Bitbucket Server.  Trying to identify if it is a Bitbucket server issue or not.  Since we don't have any github projects (I guess I could stage one), I don't have anything to compare against.

Slightly more info after fixing (status) to really say (statusWithComment.status)
[ERROR]: Syncing encountered a problem. Error: Failed to post a status BuildaGitServer.BitBucketEnterpriseStatus on commit ce6ca2571ebe0d8b59e667dc7dbaffa69ceb63a5 of repo

Seeing that it only happens on some status posting.... looking for a pattern.
Other statuses are posted fine:  e.g.  These did not hit the error breakpoint:

[VERBOSE]: BBEStatus: {
    description = "Build waiting in the queue...";
    key = Buildasaur;
    name = Buildasaur;
    state = INPROGRESS;
    url = "https://stlt.herokuapp.com/v1/xcs_deeplink/myserver.com/aae9ab4de88ee161ac51fd231005ca35/aae9ab4de88ee161ac51fd231005f6f9";
}

[VERBOSE]: BBEStatus: {
    description = "Integration step: building...";
    key = Buildasaur;
    name = Buildasaur;
    state = INPROGRESS;
    url = "https://stlt.herokuapp.com/v1/xcs_deeplink/myserver.com/fb69145e64f3806cec314c66b5fcc66a/aae9ab4de88ee161ac51fd231005d975";
}

Once again, @reststop, unfortunately this looks like all BitBucket Server code, which was written by someone else, so I'm afraid I can't help you here.