Razor LSP generates ~~ filler for comments in HTML documents, creates syntax errors in contained languages

In my .razor page, after the html part, I have

<style>
  @* Some comments... *@       <= This gives me 19 CSS031 warnings
  .some-class {
    font-size: 10px;
  }

  @* Some more comments... *@  <= 23 CSS031
  @@media print {              <= 1 CSS041
    .some-class {              <= 1 CSS023, 1 CSS011, 1 CSS033
      font-size: 20px;
    }
  }                            <= 1 CSS001
</style>

This is how it looks:

I'm using Microsoft Visual Studio Community 2022 (64-bit) Version 17.3.6

Originally posted by @Heshyo in https://github.com/dotnet/razor/issues/7349#issuecomment-1306579637

The content of the change sent to the HTML LSP is like this:
{
  "traceparent": "00-9a5e8eca78b95643a8633722395ad6c4-41e3067eb055e342-01",
  "jsonrpc": "2.0",
  "method": "textDocument/didChange",
  "params": {
    "textDocument": {
      "version": 4,
      "uri": "file:///C:/Users/jamlew/source/repos/WebApplication1/WebApplication1/Pages/Index.cshtml__virtual.html__virtualHtmlLSPClient.html"
    },
    "contentChanges": [
      {
        "range": {
          "start": {
            "line": 13,
            "character": 0
          },
          "end": {
            "line": 13,
            "character": 0
          }
        },
        "rangeLength": 0,
        "text": "<style>\r\n  ~~ ~~~~ ~~~~~~~~~~~ ~~\r\n  .some-class { \r\n    font-size: 10px;\r\n  }\r\n\r\n  ~~ ~~~~ ~~~~ ~~~~~~~~~~~ ~~\r\n  @@media print {\r\n    .some-class {\r\n      font-size: 20px;\r\n    }\r\n  }\r\n</style>\r\n"
      }
    ]
  }
}

You can see how the ~~~~ in the content of the <style> block are breaking CSS syntax.

Yeah, this is annoying. We rewrite all non-Html to be ~ so you don't need to understand C#. We try to do this without having to understand Html. In <style>, and I assume in <script> too, that system breaks down.

Could we just stop doing that? It seems like an odd experience.

@NTaylorMullen any chance you recall why it wasn't filled in with spaces?  Was there a need to have a non-whitespace filler?

Formatting would absolutely fall on the floor if we used whitespace, as you'd remove most of it I suspect.
The solution here, for now, is to use CSS comments, and if you don't want the comments to be in the HTML file, then put your Razor comments in the CSS comment.
The real solution will be full on source mapping for Html generated documents, like we have for C#, which will enable us to remove workarounds like https://github.com/dotnet/razor/pull/6597 (which is also coming soon to code actions) and fix other issues like https://github.com/dotnet/razor/issues/7564

Yup what @davidwengier said ^ 😄

Razor comments can also cause problems for TypeScript: https://developercommunity.visualstudio.com/t/Razor-comment-in-cshtml-cause-go-to-def/10368814

Another report, where this actually causes all TypeScript functionality to break due to the server crashing: https://developercommunity.visualstudio.com/t/Intellisense-gives-Error-processing-requ/10440137

https://github.com/microsoft/TypeScript/issues/55687 is the issue tracking a fix to prevent the TypeScript compiler from crashing.


Tree types need context to compute

removes the "lazy" types Application and TypeApplication

The commit "extract BaseContext fields into ClassData" doesn't seem to belong here. It does not help/affect any of the subsequent commits in this PR. I also find it questionable. It does make the constructors simpler, but makes everything else more complex! Unless we have a compelling reason to do this (which again, doesn't seem to be in this PR), I don't think we should do this change.
Otherwise, LGTM.

@sjrd I have removed the questionable commit


Gosund like GSP11

Hi all,
started a new raspian os install completly fresh. Got 4 Gosund like SP1 with Model name GSP11 sadly i cant flash them:
could not establish sslpsk socket: [SSL: WRONG_SSL_VERSION] wrong ssl version (_ssl.c:1123)
don't panic this is probably just your phone!
new client on port 443 from <IP_ADDRESS>:64079
ID: 02480901df2734a73f0957b3dc664f1266126d3ebf8d7ef6756cecf4f7803122df249301d45324da9c3bf14d03daf9c87b
Prefix: b"H\t\x01\xdf'4\xa7?\tW\xb3\xdcfO\x12f"
PSK: 2f396b0df97be9e93147f59e440914e9dea53fcfbda21dbeae7f82b1b1c5b16c
could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:1123)
new client on port 443 from <IP_ADDRESS>:64080
ID: 029bb159e7296810a660b8ca26ba5a46f5126d3ebf8d7ef6756cecf4f7803122df249301d45324da9c3bf14d03daf9c87b
Prefix: b'\x9b\xb1Y\xe7)h\x10\xa6\xb8\xca&\xbaZF\xf5' PSK: 2d17a5619ef801e479273b30f6ddbd41874e11b99e5893d827c8171fc7b71f9d could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:1123) new client on port 443 from <IP_ADDRESS>:64081 ID: 0231ceec2ba9642f722b3b6eb4839a5922126d3ebf8d7ef6756cecf4f7803122df249301d45324da9c3bf14d03daf9c87b Prefix: b'1\xce\xec+\xa9d/r+;n\xb4\x83\x9aY"' PSK: 8c4f48aaad34a1bf80193cd3d0ecc8bcbce6aecae0e7fe1372ca3949bd57dbcb could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:1123) new client on port 443 from <IP_ADDRESS>:64082 ID: 0299a376142151fc02e275f11f9b6652dc126d3ebf8d7ef6756cecf4f7803122df249301d45324da9c3bf14d03daf9c87b Prefix: b'\x99\xa3v\x14!Q\xfc\x02\xe2u\xf1\x1f\x9bfR\xdc' PSK: ef15f6f6572e865140e5e5c201513a4468c637a94e8d88b40855b0d354d9e0d4 could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:1123) new client on port 443 from <IP_ADDRESS>:64083 ID: 029cda917a084425e268be5e60be85d49f126d3ebf8d7ef6756cecf4f7803122df249301d45324da9c3bf14d03daf9c87b Prefix: b'\x9c\xda\x91z\x08D%\xe2h\xbe^\xbe\x85\xd4\x9f'
PSK: cbb52e26f8f8aa8e48dcc00e0abc02110445dbbed1a0abae61002e83d90e444e
could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:1123)
new client on port 443 from <IP_ADDRESS>:62211
ID: 021f7dd068da91d249b3d060c5f5202b2f998477474826822e4533504dc0ecf11a3c11b505656a0a1f49bf128d6cf5ced3
Prefix: b'\x1f}\xd0h\xda\x91\xd2I\xb3\xd0`\xc5\xf5 +/'
PSK: cfd9f300c18887110da434b6ed5fb5deeeb8308662b5b94f039032532e4b0305
could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:1123)
new client on port 443 from <IP_ADDRESS>:62212
ID: 0289a11091d97389a646f1cf492f4942a1998477474826822e4533504dc0ecf11a3c11b505656a0a1f49bf128d6cf5ced3
Prefix: b'\x89\xa1\x10\x91\xd9s\x89\xa6F\xf1\xcfI/IB\xa1'
PSK: 756655e026bae66f1aa0ed2610794697575d21f9dac9dda5584004711afd9506
could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:1123)
new client on port 443 from <IP_ADDRESS>:62213
ID: 0231a81393fb34e8c1b0046c0a04ed46bd998477474826822e4533504dc0ecf11a3c11b505656a0a1f49bf128d6cf5ced3
Prefix: b'1\xa8\x13\x93\xfb4\xe8\xc1\xb0\x04l\n\x04\xedF\xbd'
PSK: b3da0869f2520a2d8e681b4bdad67a1da9c64bf2a9201dbce3fb17c05177f4d0
could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:1123)
new client on port 443 from <IP_ADDRESS>:59035
could not establish sslpsk socket: [SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:1123)
don't panic this is probably just your phone!
new client on port 443 from <IP_ADDRESS>:49208
could not establish sslpsk socket: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1123)
Can anybody help me out ?

Try Connecting vtrust-flash to a laptop or smt else

I was able to get it working on Debian 11 with downgrading openssl security level. At the end of /etc/ssl/openssl.cnf I changed the section to this:
[system_default_sect]
MinProtocol = TLSv1.1
CipherString = DEFAULT@SECLEVEL=0


Suggested Feedback on Example Notebook

I'd like to give some suggested feedback on the example notebook:
https://github.com/nicholas-roy/psytrack/blob/master/psytrack/examples/ExampleNotebook.ipynb

Almost immediately, the tutorial uses generateSim() and recoverSim() functions, but there's no comments detailing what these functions are doing or what their inputs/outputs are. This could be remedied by printing the types, shapes, etc. of the input and output objects.

Looking at the code for generateSim(), the documentation states that the function returns either:

        save_path | (if savePath) : str, the name of the folder+file where
            simulation data was saved in the local directory
        save_dict | (if no SavePath) : dict, contains all relevant info
            from the simulation

But unless I read the paper and the code, I have no idea what "all relevant info from the simulation" is.

I'd like the example notebook to specify how long hyperOpt()  should take to run. Right now I've been waiting 15 minutes with relatively small inputs (number of trials = 6000, two weights, each with 1 column) and I don't know if this to be expected. If it isn't, hopefully the example notebook would clarify how to debug the source of the slowness.

makeWeightPlot doesn't return the plot object, so I can't further do anything with the plot. It'd be great if the function returned the plot object.

Thank you for all the suggestions:
1+2) The notebook has been updated to make clear that the short bit with simulated data is a demonstration, and that the main tutorial is below!

We found the bug that was causing your optimization to slow offline. This bug should not be an issue in the new release, version 1.2.0

The plotting functions have been given an overhaul — check out the refreshed example notebook for an example, should make things a lot easier!

Thanks again!


Add André Rodrigues to Contributors list

Hi  @ao-rodrigues, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

The tutorial was very clear, easy to pick up, and it felt like I could actually be a pro at this!


v.1.69.2 appearance problem

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.69.2
OS Version:  macOS Monterey V12.5

I update my VS code on my MAC to v.1.69.2 when I open it I can't see the icons on the activity bar the icons are still hidden then when mouse over I can see also when I select my file code I can't see without putting the mouse over it
any advice to return back my IDE work correctly

Can you try disabling hardware acceleration and check if it resolves the issue,

Open command palette and search for "Configure Runtime Arguments"
Set "disable-hardware-acceleration": true
Restart

Can you try disabling hardware acceleration and check if it resolves the issue,

Open command palette and search for "Configure Runtime Arguments"
Set "disable-hardware-acceleration": true
Restart

Thank you sir that solve my problem :)

I am also experiencing this problem.  Mine is macOS 11.1 within VMware (linux host).
I can't even get the command palette to show up.
How can I set that option before launching the app?

I am also experiencing this problem. Mine is macOS 11.1 within VMware (linux host). I can't even get the command palette to show up. How can I set that option before launching the app?
EDIT: nm, found it here: #152816

Hi Phatpul,
you can follow this link https://stackoverflow.com/a/73132799/8902756


Links Not Working on the Enatega-Multivendor customer web.

Issue: Links Not Working on the Enatega-Multivendor customer web.
Description:
A critical issue has been identified on website where various links are not functioning as intended. Users are unable to navigate to other pages, access resources, or perform actions due to these non-responsive links.
Impact:
User Frustration: Users may experience significant frustration when they encounter non-working links, which can result in a poor user experience.
Reduced Functionality: Non-functional links hinder the website's overall functionality and can limit users' ability to access critical information or perform desired actions.
Steps to Reproduce:

Visit website.
Attempt to click on various links throughout the site, including navigation menus, buttons, and internal or external links.
Observe that these links do not lead to the expected destinations, do not load at all, or result in error messages.

Expected Resolution:
All links on the website must be thoroughly examined and fixed to ensure they work as intended. It is essential to provide a smooth and user-friendly browsing experience by addressing this issue promptly. This includes checking for broken links, addressing any technical errors, and testing the functionality of all links throughout the site.

Dear @Sohailqureshi9 ,
I'm happy to inform you that we've resolved the link issues for Enatega Multivendor Web.
Thank you for raising this concern, and your patience is greatly appreciated. Should you encounter any further issues or have additional feedback, please don't hesitate to get in touch.
Warm regards,
@beKashif
@Ninjas-Code-official/ninjas-code


(feature): render image alternatives (fix #100)

Development started after @MichielBijl's tweet.
would appreciate some help

alt Injection
Nearly there. I think I'm not injecting at the right moment because sometimes, the injection don't happen.

Thank you for this @borisschapira 🙌🏼.

It would be ideal if it worked when I open a tweet or open an image to full size. Currently, it only works in the timeline view.

Timeline View
Single Tweet
Full Size Modal

@filipekiss I'm wondering why it doesn't work when you click on a single tweet, and then works if you hit refresh while still viewing it. Possible bug in onSingleTweetOpen?

@jorgegonzalez not sure. The instagram feature works as expected onSingleTweetOpen. Maybe the image alternative function is running too early. But if I open a thread via the notifications tab it works. I'm guessing it's not a onSingleTwitter problem, but I'll take a look later if it's still a problem.

Now it works on timeline, single and full size view.

I fixed severa display issues and tried https://twitter.com/heydonworks/media, https://twitter.com/DavidKPiano/status/988362496154185728, and https://twitter.com/MichielBijl/media. Looks ok 😁

:shipit: :tada:

Approved :) Just waiting for @sindresorhus

I think the text should be below the image. That's how it always is and makes it feel more balanced.

Can you mention this feature in the readme feature highlights section?

I'm ok with those proposals. Will PR something during the week if nobody has committed s.t.

Won't be able to code it for several hours (family time!). Have a nice Sunday :)

No worries and no rush. Enjoy your Sunday :)

@sindresorhus I've tried 0.8rem as a font-size, and I'm inconfortable with it. If this is meant to be a a11y/inclusive move, we shouldn't add text that is smaller than the tweet's text. I would stick with 0.9rem.
Colors have been changed to match the light theme, as I don't know how to easily detect light/dark and suppose light is more commonly used.
I've tried to append the text instead of prepend. It does not play well when there is 3 or 4 images, Gallery view is broken and, more importantly: reading is interrupted on timeline view, with text above and below the image, which I find rather unpleasant (causes a loss of continuity and meaning). Is that really blocking for you?

How it looks:

If this is meant to be a a11y/inclusive move, adding text that is smaller than the tweet's text may not be desirable. I would stick with 0.9rem.

I don't understand. People with disability already have a way to get the alt text with their readers. Your argument for adding this was to remind people to add alt text.

reading is interrupted on timeline view, with text above and below the image, which I find rather unpleasant

I'm of the complete opposite opinion. I don't want my tweet to be interrupted by this fairly useless (for me) text. I understand it's a nice reminder to add alt text, but it's not essential and should be placed last in the tweet. With how this PR is right now, if I read a tweet, I'll have visually skip the alt text to get to the image.

People with disability are very diverse and don't always use readers. Think about colour-blind people, for example. I understand your comment about the feature being useless for you and therefor not-essential. I'll adapt the PR when I'll have a better understanding of how Twitter compute the ratio of images, in order to adapt it to display the alternative text. Some JS computations need to be involved.

@sindresorhus How do you feel about this configuration ?

Hey, I'm not ignoring this. Was just busy the past weeks. Looks good to me now :)


Add stream matcher matchRegexp

Codecov Report

Merging #78 (0e38347) into main (a9800d9) will increase coverage by 0.11%.
The diff coverage is 94.11%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   83.71%   83.82%   +0.11%
==========================================
  Files          30       31       +1
  Lines        1578     1595      +17
==========================================
+ Hits         1321     1337      +16
- Misses        219      220       +1
  Partials       38       38

Impacted Files
Coverage Δ

pkg/matcher/stream/builtin.go
0.00% <0.00%> (ø)

pkg/matcher/stream/match_regexp.go
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


After elassandra creates an index, some shards are not normal

elassandra <IP_ADDRESS>
at java.util.Collections$UnmodifiableMap.containsKey(Collections.java:1454)
2020-07-10 09:28:59,767 ERROR [GossipStage:1] org.apache.cassandra.service.CassandraDaemon$2.uncaughtException(CassandraDaemon.java:234) Exception in thread Thread[GossipStage:1,5,main]
java.lang.StackOverflowError: null
at java.util.HashMap.hash(HashMap.java:339)
at java.util.HashMap.containsKey(HashMap.java:596)
at java.util.Collections$UnmodifiableMap.containsKey(Collections.java:1454)
at java.util.Collections$UnmodifiableMap.containsKey(Collections.java:1454)
at java.util.Collections$UnmodifiableMap.containsKey(Collections.java:1454)
at java.util.Collections$U

It seems you have not enough memory or an erroneous settings leading to the java.lang.StackOverflowError.

On 10 Jul 2020, at 13:45, tengzhuofei<EMAIL_ADDRESS>wrote:
https://user-images.githubusercontent.com/49179198/87151116-d67c6f80-c2e5-11ea-8525-cf0dc177a84a.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/strapdata/elassandra/issues/362#issuecomment-656632561, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOMPGJZELHCWALS56WC4GDR235NRANCNFSM4OWPLSXA.

why is it restart pod is recovery?


There may be some mistakes in official documents.

there are no doubt plenty, especially in non-english languages


Missing fields in the LtC List of Terms document

Section <IP_ADDRESS> of the SDS describes metadata fields that should or must be provided for each term. Several of these are currently missing from the LtC List of Terms:

Term version IRI (REQUIRED)
Modified (RECOMMENDED)
Decision (RECOMMENDED)

The first two are related to the version date when the term was last modified. Give that LtC is a new vocabulary, the last modified date will be the same as the creation date (in this case the ratification date of 2024-02-28). The Term version IRI will be the Term IRI, concatenated with a dash, then the last modified date. (See http://rs.tdwg.org/dwc/terms/associatedMedia as an example).
Once @MattBlissett runs the script to build the CSV tables in the rs.tdwg.org repo, theses values can be retrieved from the term_modified column of the appropriate table for the termlist (i.e. namespace). Those tables will have the path
https://raw.githubusercontent.com/tdwg/rs.tdwg.org/master/database/database.csv
where database is a name assigned for that namespace. For example, the EXIF terms borrowed by Audiovisual Core have the database name exif-for-ac, with the table located at:
https://raw.githubusercontent.com/tdwg/rs.tdwg.org/master/exif-for-ac/exif-for-ac.csv
The assigned database names that will be used to create the folders when Matt runs the script are listed here under "database" for each namespace. The termlists that are included within each vocabulary will be added here after he runs the script:
https://github.com/tdwg/rs.tdwg.org/blob/master/vocabularies/vocabularies-members.csv
and the database names associated with the termlists will be here:
https://github.com/tdwg/rs.tdwg.org/blob/master/term-lists/term-lists.csv in the database column.
The table joining term names to the decisions that affected them is here:
https://github.com/tdwg/rs.tdwg.org/blob/master/decisions/decisions-links.csv
So the build script needs to go through this table and add a link to each decision that affected it. The IRI to be used for the link is formed by concatenating https://github.com/tdwg/rs.tdwg.org/blob/master/decisions/decisions-links.csv and the local name listed in the table.
You can see what this looks like for a DwC term that has been the subject of a lot of Decisions: http://rs.tdwg.org/dwc/terms/basisOfRecord .

@baskaufs
document_modified = the last modification of that specific term?

It's term_modified from the appropriate list of terms CSV for that namespace. See the notes above for how to find it. Not every term in a List of Terms document will have been changed the last time the document was modified.

Fixed. The decision field will be applicable after the first annual review.


Leshy's Solar Rejuvenation healing and description errors

a) The current healing formulae returns 0 as actor.con.mod seems to be an invalid "shortcut" (#16917)
b) The Rule Element isn't properly overwriting the description based on the ancestry.

I cannot reproduce the 2nd issue.

Ah- I see the issue
I was looking at the feat with the "edit item"

I guess this is working as intended then? Cheers


Packages affected by Node-cli ES migration

Following #203, packages will need to be moved to ES in order to continue using node-cli-authorization. Below are a list of packages that use it:

iTwin/imodel-unity-example
iTwin/connector-framework
iTwin/pcf
iTwin/imodel-reporter
iTwin/insights-api-sample-console-app
iTwin/imodel-transformer/test-app
iTwin/imodel-transformer/performance-tests

The above does not include internal packages.

Closing, moving to internal backlog.


README Improvements

Sending a pull request with some README improvements:

Improved formatting and fixed typos in getting started section
Linked to kubernodes project (helps explain what it is)
Added step to document location for cloning (#6)
Added sections about requirements (#7) and tested environments

@ericuldall Is there something else to be added to the requirements section?
For example, do you know of restrictions on the version of Golang that people can use?
Also, what do you think of the tested environments section?
I added it since I would have found it useful to see, where people got the project to work.
Could also quickly become a source of frustration, since it needs to be maintained.
Just let me know what you think and we can add your tested envs or remove it, as you like.

I'm not sure of any compatibility issues in Go and at what point this may be reverse incompatible. Do you know of any tools that can help identify compatibility issues.
I like the tested environments section. Perhaps there is a better place for that as the list may continue growing and doesn't necessarily need to take up space in the readme.
For now I'm going to merge this becuase I want future users to get the benefits/clarity from your changes. Future modifications can be addressed in other PR's.


add volman mount duration to diego health template

Oops, clicked the wrong button.
@jim80net is this something we can investigate/close, given that it's from last June?


Replace watchNamespaces and watchNamespaceSelector by watchNamespaceSelectors

Deprecate watchNamespaces and encourage users to use the kubernetes.io/metadata.name label (available since 1.22) to select namespaces by name. watchNamespaceSelectors will be added to support a list of selectors instead of a single selector as watchNamespaceSelector does.
Deprecate watchNamespaces and watchNamespaceSelector and mark for removal for  next major.
Originally posted by @aslafy-z in https://github.com/kube-logging/logging-operator/pull/1392#issuecomment-1648323722

to be fair, in a new API I would consider the selector-only option


ancom should report mean/std abundance of OTUs

This information helps in interpreting results, and computing it outside of ANCOM isn't good, as it requires the user to reproduce the grouping. For example, a dataframe like this would be ideal (building on the docstring example):

I'll share some code that will help with this as I'm adapting ANCOM for an analysis that I'm working on. (See the "proof-of-concept" commit below.)

If I'm understanding this correctly.
There are some preprocessing steps within ancom that you want to take advantage of correct?
Otherwise you could just do something like
import pandas as pd
x = pd.DataFrame({'a':[1, 2, 3, 4, 5, 6], 'b':[0, 0, 0, 1, 1, 1]})
pd.concat((x.groupby('b').mean().T, x.groupby('b').std().T))

But now since we are adding in additional statistics, why limit to mean and std?  How about 25%, 75% quartiles, min and max?
The point is, I'm not completely convinced that this sort of information should be coupled specifically with ANCOM.  It may be more appropriate to have separate preprocessing module for statistics on dataframes.
But I do agree, interpreting ANCOM isn't the most straightforward at the moment.  That is still active research.

Yes, the issue is that I want to make sure that the abundances that we're looking at are the same as the ones that ancom is comparing. Five-number summary, like you're suggesting, is probably a better idea.
This will be really important for QIIME 2, so I'm putting this in the 0.5.0 milestone.

I agree with @mortonjt that this info shouldn't be coupled with ANCOM output. For now I think it's okay to add the summary stats you guys are suggesting (since there is an immediate use-case, and it is an experimental API), but we'll need to revisit this when we have the contingency table class. I think those stats make more sense there.

That makes sense about getting the stats from contingency table. ANCOM should get the distributions of feature abundances by group from there (they'd need to be computed there to get the stats on them), which would address my concern about making sure the summaries are of the same distributions that ANCOM is operating on.

@gregcaporaso is this something you're still wanting for 0.5.0, and if so do you have bandwidth to work on it?

Yes, this would be good to get in since it's small and will be important for the QIIME 2 alpha release.

Sounds good, let me know if you need me or someone else to work on it (you're currently assigned to it).

@mortonjt, @jairideout - is there a specific reason why we default to no multiple comparison correction? It seems like a better option would be to default to holm-bonferroni (which is currently the only option other than None).

I don't think there's a specific reason, should be fine to change the default since it's an experimental API (just be sure to note in the changelog).

@mortonjt, is there a p-value that would make sense to report from ANCOM?

Nope. ANCOM has no p-values yet
On Jun 7, 2016 9:51 AM, "Greg Caporaso"<EMAIL_ADDRESS>wrote:

@mortonjt https://github.com/mortonjt, is there a p-value that would
make sense to report from ANCOM?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/issues/1293#issuecomment-224343095,
or mute the thread
https://github.com/notifications/unsubscribe/AD_a3W1icQyK7ktdUiXbQFHZ1UojhNidks5qJaGPgaJpZM4HkLRW
.

Ok, thanks. And am I right that the input should be raw (un-rarefied) counts (not relative abundances)? That's the case in the docstring example, but just want to confirm that that's the expectation as QIIME 2 will type-check for both of those requirements.

I don't think that should be type checked. It should not care about the
sequencing depth. Rarefied vs not rarefied shouldn't matter.
The only thing that should matter is that there are no zeros,  which is
currently being checked.
On Jun 7, 2016 10:00 AM, "Greg Caporaso"<EMAIL_ADDRESS>wrote:

Ok, thanks. And am I right that the input should be raw (un-rarefied)
counts (not relative abundances)? That's the case in the docstring example,
but just want to confirm that that's the expectation as QIIME 2 will
type-check for both of those requirements.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/issues/1293#issuecomment-224345737,
or mute the thread
https://github.com/notifications/unsubscribe/AD_a3dJ6g3QQh-viDhGZ-fLSozpeHojbks5qJaOngaJpZM4HkLRW
.

Ok, so that'd mean no requirement for rarefied, but we specifically don't want them to be relative abundances, right? They should be counts.

Wouldn't a composition-based method basically treat everything as relative
(relative is just the unit simplex right)?
On Tue, Jun 7, 2016 at 10:13 AM, Greg Caporaso<EMAIL_ADDRESS>wrote:

Ok, so that'd mean no requirement for rarefied, but we specifically don't
want them to be relative abundances, right? They should be counts.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/issues/1293#issuecomment-224349376,
or mute the thread
https://github.com/notifications/unsubscribe/ADyuZATIm0qcjIfakyO2hB1uQkbcZiu5ks5qJabBgaJpZM4HkLRW
.

Yes, but it does that conversion internally which is why we wouldn't want
to pass it relative abundance data.
On Tue, Jun 7, 2016 at 10:22 AM, Evan Bolyen<EMAIL_ADDRESS>wrote:

Wouldn't a composition-based method basically treat everything as relative
(relative is just the unit simplex right)?
On Tue, Jun 7, 2016 at 10:13 AM, Greg Caporaso<EMAIL_ADDRESS>wrote:

Ok, so that'd mean no requirement for rarefied, but we specifically don't
want them to be relative abundances, right? They should be counts.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/biocore/scikit-bio/issues/1293#issuecomment-224349376>,
or mute the thread
<
https://github.com/notifications/unsubscribe/ADyuZATIm0qcjIfakyO2hB1uQkbcZiu5ks5qJabBgaJpZM4HkLRW

.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/issues/1293#issuecomment-224351651,
or mute the thread
https://github.com/notifications/unsubscribe/AALvdE2r2PxIvWJ_iSJ4xCjSV9_T_vt6ks5qJajBgaJpZM4HkLRW
.

Even though the method "works" (i.e. doesn't raise an error) on rarefied input, is the researcher using the method correctly? Probably not necessary for scikit-bio to make this distinction, but we'll be tracking that kind of semantic information in QIIME 2 and can warn (at least) if the user is doing something that's likely a mistake.

If I understand correctly, they are not using the method correctly if they pass rarefied data or relative frequency data (hence wanting to type check in QIIME 2, but agree that skbio doesn't need to check for this).

Exactly.  It shouldn't even matter if they are counts or not.
On Jun 7, 2016 10:22 AM, "Evan Bolyen"<EMAIL_ADDRESS>wrote:

Wouldn't a composition-based method basically treat everything as relative
(relative is just the unit simplex right)?
On Tue, Jun 7, 2016 at 10:13 AM, Greg Caporaso<EMAIL_ADDRESS>wrote:

Ok, so that'd mean no requirement for rarefied, but we specifically don't
want them to be relative abundances, right? They should be counts.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/biocore/scikit-bio/issues/1293#issuecomment-224349376>,
or mute the thread
<
https://github.com/notifications/unsubscribe/ADyuZATIm0qcjIfakyO2hB1uQkbcZiu5ks5qJabBgaJpZM4HkLRW
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/issues/1293#issuecomment-224351651,
or mute the thread
https://github.com/notifications/unsubscribe/AD_a3eMl64drQ_P5n4-UfH6uFiVR3LI0ks5qJajDgaJpZM4HkLRW
.


standardize plotting commands in R

At the first workshop, having some lessons use plot and some use ggplot was confusing. Maintainers of this repo and others that use R (automation) should standardize to one plot method.

Very much agreed, I suggest ggplot2, that's what's used in the intro and organization lessons. Reasons for using ggplot2: easier to read with layers, more visually appealing by default (without too many lines of code for customization).

I just checked, and all of the R code in both this repo (rr-organization1) and the sister repo (rr-literate-programming) use ggplot exclusively for plotting. So perhaps this issue on this repo can be closed @mine-cetinkaya-rundel @kcranston ?

I'll open an issue in the rr-automation repo as it's there it needs to be fixed.


underscore in the right place

Template PR swap.react
Build not working ? PR closed : Merge

Code matches style guide 😏

[ ] js
[ ] react
[ ] css/sass

PR description includes  😋

[ ] issue number
[ ] brief description of the work
[ ] why you chose this solution

Git 😈

[ ] git pull --rebase origin master help

For the correct PR bonus tokens ✨
💔Thank you!

ломает действующий функционал


Support importing data from a store file

Add an import command to the store: fga store import
This should:

Write the model (if present) in the store file (same as model write)
Write the tuples (if present) in the store file (same as tuple write --file)
Convert any check tests that do not have test specific tuples to assertions and write them
Report on any errors during the process

Closing this as it is implemented #215


Load ShaderConductor dependencies on Mac and Linux

The dynamic libraries on Mac using rpath mechanisms to load dependency libraries, so is important to be in mind when you create a dylib, you must specify correct ID, dependencies and rpaths where linker will find dependency libraries.
If you download ShaderConductor Mac dylib from AzurePipeline artifacts and you use for example MacDependencies app, you can see:
File: libShaderConductor.dylib
ID: @rpath/libShaderConductor.dylib
Dependency with: @rpath/libdxcompiler.3.7.dylib
Rpaths: /Users/vts/agent/2.155.1/work/1/s/Build/ninja-osx-clang9-x64-Release/External/DirectXShaderCompiler/lib.
I created a netcore 3.0 app and make a NativeLibrary.Load to load libShaderConductor.dylib but it produces a fail when load dxcompiler library dependency.
Issues:
Dependency filename is wrong, @rpath/libdxcompiler.3.7.dylib must be @rpath/libdxcompiler.dylib
RPaths is wrong, RPaths could be @loader_path; @executable_path
Is possible fix this references using install_name_tool on Mac but maybe is possible fix it from ninja script.
This is an interesting article about this issue on Mac.
Edit. In Linux exists the same issue, it is possible fix with patchelf  command but would be fixed in ninja script.
patchelf --set-sorname libdxcompiler.so libdxcompiler.so
patchelf --set-rpath '$ORIGIN' libShaderConductor.so

It'd be good to get this fixed if possible, as it's blocking our adoption of this software on macOS. :) I'm happy to try and have a crack at it myself if you're able to direct me towards where the linking gets set up in the build process!

I'm not farmilar with the shared lib on either linux or macos. The CI runs tests on these systems but doesn't fail. Maybe because they are resolved by linker, not dlopen?
Rename and symlink sound a good way. Does anyone can provide a PR? Thanks.

It took me about 30 minutes with otool, install_name_tool and codesign to get the binary running on macOS 10.15.
I had to change the rpath for both the binary and the .dylibs.  I had to change the name of the dependencies on libdxcompiler.3.7.dylib and I had to create an .entitlements file in order to turn off hardened runtime and codesign everything with my Apple Developer certificate so it would load the dylibs.  Not fun.

Get back to this issue after all these years. I had a fix that might help. But I don't have en environment to test it. Anyone like to have a try? The change is in: https://github.com/gongminmin/ShaderConductor/commit/05f4536ad3f3be27d30c17b229bed175cf87eddb


fix ctypes-foreign depexts to work with opam 2

This commit syncs the ctypes-foreign.opam with the version downstream in ocaml/opam-repository, and uses the opam 2 style of specifying depexts.  This in turn makes depexts work with a pinned ctypes-foreign, which is useful for automated CI of this repository.

Thank you!


Starting Electron with multiple apps

I have a setup whereby Electron ships with 2 apps - each of which are subdirectories (NOT asars) within resources
One is called 'app' - the other is called 'test'
if you call 'electron' it runs 'app' (as that's the default I assume?) - I also not that if 'app' isn't available, it calls 'default_app'?
I'd assumed if you called "electron test" it would run 'test' - but it doesn't.
Note: I'm 90% sure you could run alternate asar files at some point in the past - and thus MUST be a feature people would need?

As per my other issue on auto-updating 'asar' files - it's possible a change to how Electron looks for 'apps' could offer both an 'update' solution and/or a more flexible way of handling apps?
Right now I assume it looks for - in order
app\ directory
app.asar
default_app\ directory
(not sure if it looks for default_app.asar?)
One useful idea - make it look for app_update\ or app_update.asar and rename those before running them as app\ or app.asar - that's a built-in auto-update mechanism
Another approach is allow us to specific what to look for - e.g. "electron myapp" would look for myapp\ or myapp.asar
??

They are two ways of running apps:

One is bundling your app inside Electron and Electron will always use your app when running.
Another is to execute a clean Electron in command line and it will run the app specified as parameter.

The second way is implemented in default_app, if you bundle your app inside Electron you will lose this ability, but you can always reimplement in your app.

The whole "inside electron" thing is far from clear in the docs - I'm
guessing you mean 'inside electron' to be
electronbasedir/
resources/
app/ (or app.asar)
Wheras to run it as a command-line parameter (e.g. "electron myappname")
you'd make it
electronbasedir/
myappname/ (or myappname.asar)
That's not really explained in the docs at-all at this point??
Also - it opens-up a can of worms with the way OSX apps are bundled??
On 15 July 2015 at 21:19, Cheng Zhao<EMAIL_ADDRESS>wrote:

Closed #2199 https://github.com/atom/electron/issues/2199.
—
Reply to this email directly or view it on GitHub
https://github.com/atom/electron/issues/2199#event-356866392.


Broken journal symlink while a pod's in the garbage

When you rkt gc a pod and it's moved to the garbage, not deleted, the journal data is still left on disk. However, the /var/log/journal symlink still points to the past journal in the pods/run/... directory, so the data can't be read.
Should you be able to read a pod's logs while it's in the garbage? If so, the symlink should be updated (racy) or otherwise made to work correctly. If not, the symlink should be removed when the pod is moved to the garbage.

This relates to previous discussion in  #1789, since the solution arrived at there is what makes this issue noticeable/an issue (since the pod spends significantly more time in the garbage via that solution).
Possible solutions that come to mind:

Have a canonical directory for the pod data and move symlinks or markers from prepared to run to garbage instead of moving the actual data. This would let the journal symlink persist by pointing it to the canonical directory. The downside is that this is a significant change and there's quite possible a good reason that it isn't being done.

Update the /var/log/journal symlink when you move something to the garbage. This is a simple change, but I think it's always racy (though rename is pretty quick). The failure scenario in that race isn't great because afaik journalctl won't tell you a think about the broken symlink and just print an empty journal.

Decide that reading logs of garbage containers explicitly isn't supported; delete the symlink right before moving the pod to the garbage such that it's never broken. This is a simple bug fix (leaving a broken symlink) if the current behaviour of the log being unreadable is intended. Back to finding another solution for ExitedAt.

Any other ideas, concerns, etc are welcome, /cc @iaguis @yifan-gu @sjpotter

@euank
The first solution could also make the journal data persistent regardless of the pod's lifecycle, which is preferable, but when we account the pod's storage usage, then we need to account the log storage directory as well. cc @chancez
The third one is not preferable as we still need to get the log from an exited pod.

@yifan-gu you generally can get the log of an exited pod. The third one to me suggests leaving the pod in exited, not gc'd, and figuring out a different mechanism than gc-time to do FinishedAt (such as touching an alternate well known file or otherwise reviving that discussion).

Ping on this, any opinions on option 1 above, to have a single canonical directory where the pod tree, including journal, resides, and do the locking and such on marker files/directories/links that are atomically moved for lifecycle management?
It solves a real problem of the journal symlink and I can't think of a downside other than having to refactor some scary/hairy code.

Option 1 seems like a big & complex change. I don't know how to handle the migration of the directory structure in /var/lib/rkt, e.g. when a new version is installed with apt-get install rkt while other rkt pods are still running in parallel with an older versions of rkt.

Tangentially related: someone should check if https://github.com/systemd/systemd/pull/3109 would bring regression bugs in rkt.

@alban Thanks for the heads up.


Cant patch down to lsd version 0.20.1

Downloaded the version for windows from here: https://github.com/Peltoche/lsd/releases/download/0.20.1/lsd-0.20.1-i686-pc-windows-gnu.zip. Unzipped it on desktop and ran the binary in the powershell like this:

Looked like it worked but when checking the version, its not downgraded:

Thanks in advance.

I don't know how windows works, but in the first pick you are running the downloaded file(which is not installed) and in the second one you are running the global installation. Both are different. You might wanna look up how to "install" a binary on Windows.

Okay did that. So for everyone using windows, who might also need to do that. These are the steps:

Download the lsd version u need from https://github.com/Peltoche/lsd/releases
unzip the file to ur primary drive-->In my case its C:
Copy the path to the unzipped folder
Open your Systemvariables Configuration Settings -> advanced ->path variables -> click path and than new button and paste the path of the folder u copied there. Press Ok. Make sure that the systemvariable PATHEXT has the suffix .exe in it

Now in my case I had to delete the previous version via scoop uininstall lsd and than the lsd version that I wanted is active.

Just out of curiosity, why did you want to downgrade the version?

Git bash cant handle the 256 color scheme thats introduced in lsd version 0.21.


problems with null values

For a text and select fields, when field data is loaded from view, and the data-fieldValue / data-fieldSelected is null, there is no way to edit the field, there should be some sort of placeholder.
For multiple-select, with same null value case, the plugin doesnt load, with the error:
Uncaught SyntaxError: Unexpected end of input
Also, for multiple select, if all options are deselected, it does not save.

Mostly fixed.  Remaining issues:
text and select-multiple: when saving a blank value, it saves the string 'null' into the DB, should really be setting to null.  Probably related is that the select-multiple doesnt show any value or placeholder after saving to null.
text: If value is really null in DB, it shows the field name, instead of a placeholder.

Related to the null issue, we agreed to use an empty string.

The select-multiple should show the placeholder in case of a null value after saving, not just when the control is reopened.

Text fields should show the name of the field as a placeholder.

although the text field is now showing the placeholder after saving to null, it still shows the name of the field instead when reopening the dialog.
regular (non-multiple) select should also show the placeholder in case of a null value after saving, not just when the control is reopened.

not resolved: regular (non-multiple) select should also show the placeholder in case of a null value after saving, not just when the control is reopened.

We agreed on putting !EMPTY! explicitly as in case of a default null value to maintain consistency in the API. So I think this is not an issue. Instead of {"":"","A":"A","B":"B","C":"C"} it should be  {"!EMPTY!":"","A":"A","B":"B","C":"C"}

I tired this, and it still doesnt work... it works on your end?  Please pull the latest master branch, refresh and seed, and try it with the sample account.


Add the :: operator

Was not able to find an official Ruby source...
http://marcricblog.blogspot.com/2007/11/ruby-double-colon.html

The :: is a unary operator that allows: constants, instance methods and class methods defined within a class or module, to be accessed from anywhere outside the class or module.

Depends on #36 for basic constant functionality


Replacement of "compile" with "implementation"

As "compile" is going to be deprecated end-2018, this PR replaces with "implementation" that is the new usage.

In project level gradle, should change classpath 'com.android.tools.build:gradle:3.0.1'


Stepper is looping onchange event

When using objects with usestate the onchange event is called every time, it's in a loop.
We would like the "name" property to be added and it would be great if we could get the the whole event returned instead of just the number.
BR Daniel & Atay

Created a PR for a solution!
Have yet to add the "name" prop and return the "whole event". Could you elaborate on this so we find the best solution:

What do you need the "name" property for and how do you intend to use it?
What do you mean when you say the whole event? :)

Thanks for contributing! 🪴


51 create a lizard file for before and after refactor in branch cover

Adds CC comparison, before and after refactoring

LGTM


Logout issue in Identity server 4

Hello, i am using identity server 4 with .net core 2.
i have copy and pasted quickstart template in project, but now i am facing logout issue.while i am trying to logout from identity server but it is not working and still loged in identity server.
Here is the screenshot

please let me know what i am doing wrong?

Did you update the quickstart UI code when you upgraded?

You will need to inspect the logs and diagnose some more. There's not enough info here.

Any update?

while clicked on logout,logs are here
info: Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationHandler[8]
      AuthenticationScheme: Identity.Application was successfully authenticated.
info: Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationHandler[8]
      AuthenticationScheme: Identity.Application was successfully authenticated.
info: Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationHandler[8]
      AuthenticationScheme: Identity.Application was successfully authenticated.
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Executing action method IdentityServer4.Quickstart.UI.AccountController.Logout (ASAP.IdentityServer) with arguments () - ModelState is Valid
info: Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ViewResultExecutor[1]
      Executing ViewResult, running view at path /Views/Account/Logout.cshtml.
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
      Executed action IdentityServer4.Quickstart.UI.AccountController.Logout (ASAP.IdentityServer) in 12.6394ms
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 44.5161ms 200 text/html; charset=utf-8

Was it null on the GET request to logout? If so, you need to check the logs from the end session endpoint.

Same issue here. How to recreate:

Run IdentityServerWithAspNetIdentity project in 6_AspNetIdentity sample
Go to IDP portal website (http://localhost:5000/)
Click log in (register new user if needed)
Click log out
After log out you can still see "Hello youremail" on navbar

I think user acctually gets logged out but navbar is not correctly refreshed

I think this was fixed here: https://github.com/IdentityServer/IdentityServer4.Samples/pull/222. If not, please reopen and/or let me know. Thanks.


Segment Anything Model inside Keras Applications

Would it be possible to include SAM from Meta inside Keras to use it as a backbone?

@emi-research-dl , Segment anything is now available in Keras-CV and here is the link to the PR https://github.com/keras-team/keras-cv/pull/1987.
Feel free to close this issue. Thanks!


CodeceptionClassTestsTest::testCodeceptionCommandPath fails under Windows

Hi,
On Windows 2008 R2 server, the testCodeceptionCommandPath unit test fails because of --no-colors
Here's the output of codecept run unit:
1) CodeceptionClassTestsTest::testCodeceptionCommandPath
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'E:\inetpub\webception\App\Tests\_config/../../../vendor/bin/codecept run --config="E:\inetpub\webception\App\Tests\_config/codeception_pass.yml" unit WebceptionTestClassTest.php 2>&1'
+'E:\inetpub\webception\App\Tests\_config/../../../vendor/bin/codecept run --no-colors --config="E:\inetpub\webception\App\Tests\_config/codeception_pass.yml" unit WebceptionTestClassTest.php 2>&1'

#1  E:\inetpub\webception\App\Tests\unit\CodeceptionClassTestsTest.php:115
#2  CodeceptionClassTestsTest->testCodeceptionCommandPath

I know that you don't have access to a Windows machine and I don't know much about codeception nor Yii so I figured: I'll create an issue for each unit test that fails, you can send me patches, I'll run the tests on Windows and we'll weed down the bugs. Deal? :-)

This does not seem to be specific to windows server. I am working on updating Webception to latest Codeception as WebGuy classes have gone in favor of AcceptanceTester classes and a better structure, Once I finish updating the tests to work with latest Codeception I will also be sure this test is fixed.

maybe on the meantime you can just remove such option if that's failing on you, should be the one on webception/App/Lib/Codeception.php, around line 320 getCommandPath func.

#39 should fix this minor issue.

Yep! That fixed it! Thanks!


More unit tests.

Towards #477

Current coverage is 95.66%

Merging #1193 into master will increase coverage by +0.10% as of 7723e4a

@@            master   #1193   diff @@
======================================
  Files           78      78
  Stmts         9153    9153
  Branches      1713    1713
  Methods          0       0
======================================
+ Hit           8747    8756     +9
  Partial         91      91
+ Missed         315     306     -9

Review entire Coverage Diff as of 7723e4a

Powered by Codecov. Updated on successful CI builds.


Add a new tool Github Repository URL Paste your toolkits Github repo url here and we will sync & install

⚠ Check for existing issues before proceeding. ⚠

[X] I have searched the existing issues, and there is no existing issue for my problem

Where are you using SuperAGI?
Windows
Which branch of SuperAGI are you using?
Main
Do you use OpenAI GPT-3.5 or GPT-4?
GPT-3.5
Which area covers your issue best?
Installation and setup
Describe your issue.
can I get more information or page to follow to understand how and were to do this ?
How to replicate your Issue?
No response
Upload Error Log Content
docker compose logs

This is not the place to ask questions. Please do so in the Discussion Forum and/or discord.


Add SDG library code

This PR adds the code for the SDG library #41
In order to test the code, you can run the tests/test_knowledge.py, specify the model endpoint and run the file from the root like such - python3 -m tests.test_knowledge.py

This PR adds the code for the SDG library #41
In order to test the code, you can run the tests/test_knowledge.py, specify the model endpoint and run the file from the root like such - python3 -m tests.test_knowledge.py

You'll need to move the test script to a different directory. It's getting picked up by the automation that runs unit tests. If you move it, it shouldn't run.

As of right now, none of this new code is being used, so it will not break the CLI (as confirmed by the e2e CI job).
Since this is so big, we're going to merge and keep working on it in tree.


Compatibility with Kirby 3.6 and PhotoSwipe 5

Can you please update the plugin to be compatible with Kirby 3.6 and PhotoSwipe 5?

What is currently not compatible. I have not tested the plugin in 3.6 yet. Do you already have a list of breaking changes.
Is there already a release date of PhotoSwipe5.
I will soon implement another website where I will have this plugin in use. In this process, there will certainly be an update. Until then feel free to document your experiences here.

I have created a beta version for PS5, you can test it:
https://github.com/schnti/kirby3-photoswipe/tree/PhotoSwipe-v5


Fix create database conflicts with name in schema

Closes #4566

Why does "CreateDatabase" even go through DDL? Does it needs to compute a delta? To be applied to the global schema?
It seems to me that all DatabaseCommands should be simple operations - at least delta-wise.

Why does "CreateDatabase" even go through DDL? Does it needs to compute a delta? To be applied to the global schema?

I believe that's right, yeah.


objmode context manager has to be a global else it is not identified correctly

Reporting a bug

[x] I am using the latest released version of Numba (most recent is visible in
the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[x] I have included below a minimal working reproducer (if you are unsure how
to write one see http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports).

In [10]: from numba import njit, objmode

In [11]: @njit
    ...: def impl():
    ...:     with objmode():
    ...:         print("hi")
    ...:     return
    ...:

In [12]: impl()
hi

In [13]: def gen():
    ...:     from numba import objmode
    ...:     def impl():
    ...:         with objmode():
    ...:             print("hi")
    ...:         return
    ...:     return impl
    ...:

In [14]: njit(gen())()
CompilerError: Failed in nopython mode pipeline (step: Handle with contexts)
Illegal use of context-manager.

File "<ipython-input-13-fbc5f66fa1a1>", line 4:
    def impl():
        with objmode():

expect the above is the result of the with_lifting matching on global for objmode whereas it ought to match on freevar too.

MWR:
from numba import njit
import numpy as np

def gen():
    from numba import objmode
    def impl():
        with objmode():
            print("hi")
        return
    return impl

njit(gen())()


Add lowWindConditions field

This field is used to communicate if the wind is too light to sail normally. Part of issue #277 in local-pathfinding

Will need to double check that this doesn't conflict with the latest commits to the local-pathfinding master branch


Don't handle reveals when 'receive' capability is off

Description
Currently the RECEIVE capability stops the client from asking for the secret:
https://github.com/raiden-network/light-client/blob/d65362c267857d1643194d47915948760d4beedd/raiden-ts/src/transfers/epics/locked.ts#L494-L510
If a SecretReveal was received (shouldn't happen) the client would handle it.
Acceptance criteria

Tasks

[ ] Add the same capability check to the transferSecretRevealEpic
[ ] Expand and adjust tests

@palango Thanks for opening the issue :)
What is the problem here?

@christianbrb I tried to describe it in the body of the PR. It's a very edgy case, and not a "risk", just consistency


Fix missing extensions in CI/CD

Checklist:

[x] Securely signed commits

It seems there are still some fonts missing.

convert: unable to read font `helvetica' @ error/annotate.c/RenderFreetype/1338.

I've reinstalled ghostscript but still imagick's convert still fails.

I'm not sure, but how about installing gsfonts?

I'm not sure, but how about installing gsfonts?

Thanks!


Analyzing a Monitoring run causes a crash

** Branch **
da/asa-styling (per ASA 2.3 upgrade)
Describe the bug
Performing analysis on a Monitoring run causes a crash.
To Reproduce
Steps to reproduce the behavior:

Run CLI on da/asa-styling branch
Navigate to the Monitor page
Complete a simple monitoring run. In my case, I monitored my Desktop directory and added/removed a file.
Navigate to the Analyze page
Select the completed run from step 3 in the first Run ID box
Ensure "Enable Analysis" is checked on (default)
Click "Start Analysis"
See error

Expected behavior
Analysis of the monitoring run should be successful.
Additional Context

Guided Mode fails when attempting to ONLY use a Monitor. May not be directly related.
Analysis does not fail when using Guided Mode with BOTH a FileSystem Collector AND a Monitor. May not be directly related.

Should be fixed in #570.


ToDict method added to song class

ToDict method allows for quick conversion of Song
instances to Dictionaries.
ReadMe updated.
Signed-off-by: Mathew Bramson<EMAIL_ADDRESS>

Wow, that's really succinct!


Automatic device registration happens despite GPO control. Disabled doesn't work

At the moment GPO "Windows Components/Device Registration/Register domain  joined computers as devices" has absolutely no effect. Disabled setting doesn't block Windows10 Azure AD Hybrid Join.
Once you install ServiceConnectionPoint for Azure AD Hybrid Join, every single Windows 10 machine in forest will perform AAD Hybrid Join. Doesn't matter if OU's are synced or not in AAD Connect.
Also happens in child or tree domains, they don't have to be even verified to AAD.
W10 devices get enrolled as AAD Hybrid Joined anyway.
Tested on Server 2016 with federated root domain and Windows 10 1803+1809 client VMs.
This can be huge issue for several of our customers and can delay purchasing M365 licenses until fixed.
For many organizations it is not a realistic possibility to join every W10 device in a forest to AAD
Here's comments from someone else who noticed same problem and apparently Microsoft support has replied that it's a known issue..
https://community.spiceworks.com/topic/2203360-devices-hybrid-azure-ad-joining-despite-gpo-applied-to-block-it

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2928e23e-3210-9e74-9cdb-1a19b703eac7
Version Independent ID: 44e303ca-e4bc-ba30-5aae-311aa9318278
Content: Control the hybrid Azure AD join of your devices
Content Source: articles/active-directory/devices/hybrid-azuread-join-control.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@TechTrooper Thanks for the question! We will investigate this issue and get back to you soon.

@TechTrooper can you please confirm the value of the "Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Windows\WorkplaceJoin" registry key on the machines where you applied the Group policy ?

@TechTrooper can you please confirm the value of the "Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Windows\WorkplaceJoin" registry key on the machines where you applied the Group policy ?

autoWorkplaceJoin value is 0 with the GPO applied and "Register domain joined computers as devices." set to Disabled
Here's the device state before setting up SCP for Azure AD Hybrid Join.

Here's the device state after setting up SCP for Azure AD Hybrid Join. GPO to disable registration is still applied and registry key exists, but it's ineffective. This can be disastrous for organizations expecting to perform limited registration.

@TechTrooper I have reached out to the Product group regarding this and they are working on fixing this in the nect update.
Currently the suggested workaround for this to

Delete the SCP
Create a GPO to push the belwo registry keys only to the tageted devices.

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\CDJ\AAD]
"TenantId"="" Value type as “REG_SZ”
"TenantName"="" Value type as “REG_SZ”
This registry will help the device identify which tenant to target for the device registration.
I understnad this is not the ideal solution, product team is working on this and the document will be updated with the changes as well.
Hope this helps.

@TechTrooper We have not heard from you in a while.We will now proceed to close this thread. If you have further questions, please tag me in the comments and I will gladly continue the conversation.

@ManojReddy-MSFT,
We plan deployment of AAD Hybrid join and will use Federated setup, anything to worry based on this issue?
I did test using "managed domain + sso" and that worked fine in test farm.

Hello,
Today opened a case with MS Pro Support and they confirm there is on-going issue with this "control" and without any ETA available...

@ManojReddy-MSFT,
Just a question, if we will deploy Federated domain procedure but select only "down-level" via AAD Connect configuration, then this issue that people have, shouldn't apply to such setup right?

We've just fallen foul of this issue, why has this been feedback been closed without updating the documentation to alert people the GPO control doesn't work?!

@lightupdifire Generally Device registration task runs on every Windows 10 device automatically and having the GPO described int he doc will prevent his task from running.
In a federated scenario, when you configure AAD HJ through AD connect, ADFS rules are created and updated by AAD Connect, so if the rules are created correctly then the device will be joined to Azure AD. I am not sure what you mean by "select only down-level via AAD Connect", can you post a screenshot of the setting?
@benzini00 I am sorry for the inconvinience caused by this. I was informed that the product team is making the appropriate changes and hence I clsoed the issue. I followed up with the team today and will provide an update based on that.

@ManojReddy-MSFT
Sure, we use ADFS and we want to deploy only "down-level", the 2nd option in AD Connect:

Question is, if using this 2nd option only, any similar issue like this case we could face?

@lightupdifire The ADFS claim rules required will be created when you select either of the options. So, your Windows 10 devices also will get registered if you have any in your environment.
You would have to follow the steps mentioned in this doc and clear the SCP and use a GPO to populate the required registry keys.
@benzini00 The article has been updated with the information regarding SCP. let me know if you would like us to include any other details.

@ManojReddy-MSFT,
Update of this article makes it more complex to understand what should be done, we don't want to enable automatic registration at all, only 2x servers should be allowed from 300+. What should we do?
What should be done to Disable automatic registration for Windows current devices for Managed domain?
What should be done to Disable automatic registration for Down-level devices for Managed domain?
What should be done to Disable automatic registration for Windows current devices for Federated domain?
What should be done to Disable automatic registration for Down-level devices for Federated domain?
Regards
<<
If you are using AD FS, you first need to configure client-side SCP using the instructions mentioned above but linking the GPO to your AD FS servers. This configuration is needed for AD FS to establish the source for device identities as Azure AD.>>
So only to ADFS and not to OU containing domain-joined computers?
Regards:
<<
b.  Uncheck “Automatically remove unused devices” under Services > Device Registration > Properties
Where and why?

Regards:
<<
Note
Ensure default configuration remains unchanged for “Register domain-joined computers as devices” GPO set to
“Not Configured” and “Automatically register new Windows 10 domain joined devices with Azure Active Directory” set to “Yes” when using Configuration Manager.

And if not using Configuration Manager?
Just get really confused what should I do now to STOP automatic registration for any deployment scenario I choose.. And if I choose Managed domain or Federated domain, what exactly should be done, is it possible describe step by step and not like "look above" and "look below"?
Old article was more clear in terms of document setup, reading that could better understand like to stop all devices auto-register i need: 1-2-3
Now is like only giving option what to enable to do automatic registration, but not really explaining what to do to stop it...

@lightupdifire Here is all that you need to do:

Make sure SCP entry is cleared from AD
Configure SCP on the client (in this case your 2x servers) using the client-side registry option mentioned above
If you are using AD FS, configure SCP on the AD FS itself using client-side registry option mentioned above

@SanDeo-MSFT
So if we have:

On-premise domain;
Azure AD domain;
In between AD Connect & ADFS & WAP etc.
~10x Windows 10 on-premise domain joined devices
~50x Windows 2016+ on-premise domain joined devices (running DC, ADFS, WAP etc.)
~240 Windows 2012 R2 and lower on-premise domain joined devices

Our plan is to use only "Down-level" solution now.
Our action would be:

Make sure SCP entry is cleared from AD
Configure SCP on the AD FS itself using client-side registry option mentioned above
Run AD Connect and enable "down-level"
Deploy Microsoft Workplace Join for non-Windows 10 computers

All those steps would be correct?
What will happen with "10x Windows 10" and with "50x Windows 2016"? they will not do "auto-register"?
Which exact action is stopping auto register, the "SCP clear"?

@lightupdifire You would also need to create the SCP on the client using client-side registry option.
Windows 10 and Windows 2016 will not be auto-registered. Yes, the task which is running on these devices will look for SCP and as it is cleared, auto-register will not succeed.

@lightupdifire We have not heard from you in a while. We will now proceed to close this thread. If you have further questions, please tag me in the comments and I will gladly continue the conversation.

@ManojReddy-MSFT
Can you tell what the status is regarding the option to block automatic device registration?
We have tested with the SCP GPO and want to extend by configuring AD-Connect and ADFS. However we don't want all our W10 devices and Servers end up as Hybrid AD Joined devices. I see the following options:
[Option1]
We might control this by disable syncing specific W10 and Server OU's from AD-Connect. (Q: Are these devices removed from Azure AD then?)
[Option2]
Final goal is to set-up Co-Management. So we extend the SCP GPO to additional machines and configure Co-Management also, so they end up being brought under MDM control as well.

@ManojReddy-MSFT
I'm back from short holiday :)
2 weeks ago I did open a ProSupport ticket via Azure and they confirm to me, that Product team confirms following issue:

If we select during AD-Connect configuration wizard that we want to setup only "down-level" devices
"Current version" devices will be affected and will start AADHJ

So for us will be important to block any "Current version" devices, because "Down level" devices require an agent installation at least.
Can you please advise, what will be best roll-back plan in scenario:

We follow all steps from this article
We run ADConnect and enable down-level
For some magic reason "Current devices" start auto AADHJ

How to make those devices that do auto AADHJ to be just only on-premise domain joined as they were before and stop auto process?

@nielsvdGH Removing the SCP and pushing the SCP GPO only to the devices that need to be registered to Azure is the recommended solution.
Removing the devices from sync scope will work with a managed domain. It will not work when you federate the domain. In federated scenarios, device authentication happens at the ADFS level and does not need synchronization.
@lightupdifire Yes, all versions will be affected when you enable device registration irrespective of the AD Connect setting.
Removing the SCP is the most important thing, as the automatic device registration task will look for it and when it does not find the SCP, the device will not be able to join. Once the SCP GPO is pushed, the registry key will provide the details required and the process will continue.
In a scenario, where you have windows 10 devices registered to Azure and you want to remove them, you need to do the following:

Delete the device from Azure AD.
Open CMD prompt as an admin and run the following command "dsregcmd /leave". This will manually unjoin the device.
Make sure the SCP GPO is not applying to the device or else a restart will trigger the device registration task again.

Hope this clarifies things.

@ManojReddy-MSFT
So actually if we don't have those entries in step "Clear the Service Connection Point (SCP) entry from Active Directory (AD) if it exists"
The values of azureADId and azureADName,
Then all should be fine? But is it possible that this value will be populated after we run ADConnect configuration wizzard?
Just checked production domain and can't find "azureADId and azureADName"

@lightupdifire
Yes, If that value does not exist, device would not know which tenant to register for.
AD connect configuration has a step in which SCP is configured. So after running AD connect SCP will be created. You can validate this by running the following command and remove it if it exists.
"$scp = New-Object System.DirectoryServices.DirectoryEntry;
$scp.Path = "LDAP://CN=62a0ff2e-97b9-4513-943f-0d221bd30080,CN=Device Registration Configuration,CN=Services,CN=Configuration,DC=fabrikam,DC=com";
$scp.Keywords;"
Ref: https://docs.microsoft.com/en-us/azure/active-directory/devices/hybrid-azuread-join-manual#configure-a-service-connection-point

@ManojReddy-MSFT,
So seems like it is not possible to prepare environment to block auto registration without running ADConnect wizard, is it so?
So maybe steps should be re-ordered for "Controlled validation of hybrid Azure AD join on Windows current devices", something like:

Run ADConnect configuration wizard, this will add SCP entry
Right after ADConnect configuration wizard deployed for AADHJ, clear the Service Connection Point (SCP) entry from Active Directory (AD) if it exists
Configure client-side registry setting for SCP on your domain-joined computers using a Group Policy Object (GPO)
If you are using AD FS, you must also configure the client-side registry setting for SCP on your AD FS server using a GPO

You don’t need 1 and 2 for for controlled validation.
2 is only if you had previously configured SCP using AAD Connect or using PSH. Otherwise you just need 3 and 4.
Sent from my iPhone
On Jun 20, 2019, at 6:15 AM, lightupdifire <notifications<EMAIL_ADDRESS>wrote:
@ManojReddy-MSFThttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FManojReddy-MSFT&data=02|01|sandeo%40microsoft.com|9d4f5ccfab42470555fa08d6f5815242|72f988bf86f141af91ab2d7cd011db47|1|0|636966333109794042&sdata=FoCWsN5ArD%2BN80%2BkD%2BrDR7p6mik9D4DIdwj%2FtnM2eAY%3D&reserved=0,
So seems like it is not possible to prepare environment to block auto registration without running ADConnect wizard, is it so?
So maybe steps should be re-ordered for "Controlled validation of hybrid Azure AD join on Windows current devices", something like:

Run ADConnect configuration wizard, this will add SCP entry
Right after ADConnect configuration wizard deployed for AADHJ, clear the Service Connection Point (SCP) entry from Active Directory (AD) if it exists
Configure client-side registry setting for SCP on your domain-joined computers using a Group Policy Object (GPO)
If you are using AD FS, you must also configure the client-side registry setting for SCP on your AD FS server using a GPO

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F31078%3Femail_source%3Dnotifications%26email_token%3DAJEFRT5ULL7WRH647FBYYLTP3N7F3A5CNFSM4HMLROMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYFMBBI%23issuecomment-504021125&data=02|01|sandeo%40microsoft.com|9d4f5ccfab42470555fa08d6f5815242|72f988bf86f141af91ab2d7cd011db47|1|0|636966333109804044&sdata=etRmJsfzFdJII5Z5JziQs30mH%2BC%2Fi9%2FYQVL2t7jMnDI%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJEFRT2DKTPYWGXRMX74IEDP3N7F3ANCNFSM4HMLROMA&data=02|01|sandeo%40microsoft.com|9d4f5ccfab42470555fa08d6f5815242|72f988bf86f141af91ab2d7cd011db47|1|0|636966333109804044&sdata=sbTR1TyGVH3mKaFagCTIr05q6No1yDZwCUK3DAaeBdA%3D&reserved=0.

@SanDeo-MSFT
That is the main question from me, how exactly stop auto-register.
If I start following like "how to deploy hybrid" then I need to run: ADConnect for federated domain
If I will run wizard of ADConnect for federated domain, then auto-register can happen.
I cannot do "controlled validation" first, because if I will not run wizard of ADConnect for federated domain, then SCP record not added.

@SanDeo-MSFT @ManojReddy-MSFT
Because we don't need any other device or any auto-register process to be done at all, only few required "Down level" devices,
Do you confirm that the best steps, to stop auto-register, will be by doing this setup in following order:

Run AD-Connect wizard to enable Azure AD Hybrid join for federated domain;
Monitor SCP and as soon as added, clear it out;
For ADFS, configure the client-side registry setting for SCP on ADFS servers using a GPO/manually
For few required "Down level" devices, add SCP in registry, add trusted sites and deploy client.

And btw. did anyone tested by doing:

Clear SCP from domain
Run AD-Connect client upgrade/update or check if there was auto-update done
Check if SCP added automatically back

?

@SanDeo-MSFT @ManojReddy-MSFT
Hope you are doing fine, if possible, please would be great to have comment on last 2x questions.

@lightupdifire Apologies for the delay. The action plan you have looks good.
Updating AD Connect will not affect the SCP configuration unless you rerun the configuration wizard.

@ManojReddy-MSFT,
Thanks, we plan deployment this/next week and want to make sure, that we really can stop Hybrid Azure AD join, after configuration wizard completed,
Then do HybridAADJ only for 1x Down-level device,
But even ADConnect run on Windows 2016 on-premise domain joined server :)
I guess u can "re-close" this case,
I will for sure share our experience here.

@lightupdifire Sure. I am looking forward to hearing back from you.

@SanDeo-MSFT @ManojReddy-MSFT
We run deployment, in result:

Down-level devices cannot register, errors:
a) "The registration service could not successfully authenticate your account. Please make sure you are logged in with your Active Directory domain account and try again."
b) "Hybrid Azure AD Join error: Error Message: Failed to navigate to"

Current devices registering automatically, even SCP cleared from on-prem AD,
At least we see this with Windows 10 devices, Windows Servers 2016 don't have this issue.

So in summary, I think "Controlled" process not very well running,
Also SCP record created in both location, in the domain and in the domain forest.

@SanDeo-MSFT @ManojReddy-MSFT
After troubleshooting found following:

When we run setup, seems the 5-10 seconds for clearing "keywords" was enough, to make some PC's start registering, this is why we saw some Win10 start register
When creating SCP record in AD FS can use tenant name, example: contoso.onmicrosoft.com
When creating SCP on Down-level device, need use federated domain, example: contoso.com

In summary, controlled worked well, but I would advise maybe to add in doc, to run script to clear records and make scrip loop continuously while run wizard.
If used domain and forest, then record added in both, so both must me SCP cleared.
When deploy Down-level workplace agent, it is adding needed sites to Intranet zone, so no need to add.
Thanks for helping out! Have a great all ahead ;)

@lightupdifire
The key thing to remember when you are doing a controlled validation for hybrid Azure AD join is to skip SCP configuration using Azure AD Connect. So if you are using AD FS, then you need to configure the required AD FS claims. We recommend you use Azure AD Connect to configure AD FS claims. So when using it, make sure you skip SCP configuration. This way it does not get written in AD and you do not have to worry about clearing it. Then all you do is configure SCP on the client side and those devices will start registering with Azure AD as hybrid Azure AD joined. If you are not using AD FS and instead using Azure AD authentication using password hash synchronization (PHS) or pass-through authentication (PTA), then for registering down-level devices as hybrid Azure AD join, you have to ensure Seamless Single-Sign-On is enabled as well.
Hope this helps.
Thanks

I too am confused by this article and have been far more enlightened by this comment thread than the article itself.
Suggestion: Please update the article with any relevant information shared in this thread. People should be able to read the article and get what they need in terms of configuration steps.
Question @SanDeo-MSFT , @ManojReddy-MSFT : I am working on a controlled Hybrid Join deployment in our managed (pass-hash) environment of win10 computers. I'm still not totally clear on the steps, so please verify or correct what I have listed below:

Remove Azure AD registration from any registered devices that we plan to hybrid join.
Sync device OUs in AD Connect (we currently only have users/groups synced).
DO NOT enabled hybrid join in AD Connect.
Verify SCP does not exist in on-prem AD (it doesn't, I already checked).
Configure SCP on client side.

After completing the steps above, any clients that have SCP configured should begin to hybrid join, correct?
Thanks

@JoelHazelton Apologies for the delayed response. Your action plan looks good. Only devices with SCP configured on the client-side will be joined to Azure AD.
I will work with the author to enhance the doc.

@JoelHazelton
Sharing my experience when we run Hybrid AD Join for ADFS solution:

Verify SCP does not exist in on-prem AD (it doesn't, I already checked). -> it doesn't exist, until you run AD Connect wizard to do configuration for Hybrid Azure AD Join.

SCP - as far understood, this step can be skipped during wizard of AD Connect, but to be honest,
didn't saw that option... so what we did is: A) we run AD Connect wizard B) same time we monitor domain and domain forest for SCP record in AD via ADSI edit and by PowerShell C) As soon as SCP show up in AD we clear it out, it was added in both, domain and domain forest, both cleared.

After AD Connect wizard completed, after few weeks, our Azure AD security center send us message that windowstransport for proxy for extranet become open, so we have to close it down.

We added SCP on ADFS servers and on devices that must be Hybrid AAD joined manually by registry, as we don't have many devices for this setup, where registry SCP TenantName should be federated domain name.

If critical for you, then monitoring and clearing SCP should be done quick, we saw some devices start register very quick, we got ~5 devices in ~10 sec while we cleared SCP.

I'd love to hear a comment from Microsoft when this might be fixed. Does it require an update of all Windows 10 devices to a new version for example? Even though we have a work around, it's not pretty.

Hello,
It's now 2020 and all of the useful information resides under this 'closed' feedback topic, which I find very annoying.
If device registration GPO doesn't work and you're suggesting that clearing the device registration SCP from Active Directory and using the ClientSideSCP Method is the only way to achieve a controlled rollout, could you please remove the below article, as it was the the first result on Google when I typed "Controlled roll out of Hybrid AD" -
https://docs.microsoft.com/en-us/azure/active-directory/hybrid/how-to-connect-fed-hybrid-azure-ad-join-post-config-tasks
If you could also update this article with any relevant information that would be great.
Too much conflicting information which is clearly confusing everyone!

Also, is there any ETA on when the device registration GPO will be working again? As I say, there is conflicting information on the internet regarding this topic and it would be good understand if this is still an issue or not.

I fully agree with @jakeives95. I have learned far more from this thread than from the documentation. Both this this article and "Configure hybrid Azure AD join for federated domains" needs to be more clear around which options to use when. Didn't even know about the third article @jakeives95 he just linked to. I will ignore that one considering it has not been edited since 2018.
We just started a controlled rollout thinking that the steps in this guide would be enough. However, what this guide fails to include is the fact that AD FS also needs claim rules configured - and not only to the SCP as referred to under "Configure AD FS settings". Please update this article to notify people that AD FS claim rules will need to be configured via AAD Connect or manually for a fully supported join. I know that some devices will registered without the claim rules due to the fallback option, but the fact that this information is left out resulted in a full day of troubleshooting and a delayed rollout. Some devices manage to use the fallback and other don't, so this articles is not applicable for AD FS environments unless claim rules are configured in advance. There are also other prerequisites about proxy etc. that this article leaves out.
I would even advise to migrate this article it to "Configure hybrid Azure AD join for federated domains" and "Configure hybrid Azure AD join for managed domains" - then remove it. Otherwise it needs to be updated to include all the details discussed in this thread. For example, add a section under the other tutorials for "Follow these steps to enable a per-device enrollment via GPO" and make it clear that the option would be to auto-join everything outside of your control. Then include the incredibly important step from @SanDeo-MSFT at 1 August 2019, about skipping the SCP configuration in the AAD Connect Wizard.

Is GPO control still an issue?
Looking to enabling HAADJ in the next few weeks and planning on using this GPO as part of our implementation.

It is now 2022 and the GPO to prevent Auto Azure AD Join still does not work. Moreover, when you are on a restricted network that does not have full internet access, you login is slowed down by 2 minutes. It has to time out trying to connect to azure before falling back to local authentication on Azure AD joined machines.


Removed block_id from lowered representations

This change is

crates/cairo-lang-lowering/src/inline/mod.rs line 347 at r1 (raw file):
Previously, yuvalsw wrote…
That's what I did in the first place, but then the relevant test results changes to:
before inlining - no change, one block.
After inlining - No blocks.
As in this PR:
//! > Test inlining diagnostics for a recursive function.
//! > test_runner_name
test_function_inlining
//! > function
#[inline(always)]
fn foo(ref a: felt, b: felt) -> felt {
foo(ref a, b);
b
}
//! > function_name
foo
//! > module_code
//! > semantic_diagnostics
//! > lowering_diagnostics
error: Cannot inline a function that might call itself.
--> lib.cairo:1:1
#[inline(always)]
^***************^
//! > before
blk0 (root):
Inputs: v0: core::felt, v1: core::felt
Statements:
(v3: core::felt, v2: core::felt) <- test::foo(v0, v1)
End:
Return(v3, v1)
//! > after
blk0 (root):
Inputs: v0: core::felt, v1: core::felt
Statements:
(v3: core::felt, v2: core::felt) <- test::foo(v0, v1)
End:
Return(v3, v1)
With returning empty blocks in case of failure, same besides empty "after":
//! > after

I think its ok to have no block in the output when you have diagnostics.


Crashing vscode with -Window is not responding

Type: Bug
Open visual studio code. Make changes to any of the file and save it. After sometime error window will pop up - Window is not responding. VSCode is unusually slow.
I have tried

Uninstall and then install VSCode
Disable all plugins (error still persist)
Enable only required plugins
Disable hyper scaling
Remove temp files from code
Installing vscode insider

Note I dont have McAfee installed , its using MS protect program comes with Windows  OS
VS Code version: Code 1.80.1 (74f6148eb9ea00507ec113ec51c489d6ffb4b771, 2023-07-12T17:22:07.651Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_softwarewebgpu: unavailable_software

Load (avg)
undefined

Memory (System)
31.59GB (13.92GB free)

Process Argv
--crash-reporter-id 19af7f97-a62f-43d9-a634-3ab28263d37b

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

python
ms-
2023.12.0

jupyter
ms-
2023.6.1101941928

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.17

vscode-jupyter-cell-tags
ms-
0.1.8

vscode-jupyter-slideshow
ms-
0.1.5

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263:30792226
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
282f8724:30602487
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
vsctsb:30748421
03d35959:30757346
57b77579:30736110
pythonfmttext:30731395
pythoncmvfstrcf:30756944
fixshowwlkth:30771522
hideindicator:30785051
pythongtdpath:30769146
i26e3531:30792625
pythonnosm12tcf:30779713
pythonidxpt:30784022
pythonnoceb:30776495
e537b577:30795824
dsvsc013:30795093
cmakesidepanelv2:30779593

@DonJayamanne please share remedy if you think any. I am meanwhile getting acquainted with other IDES to unblock myself.

Can you check if the issue repros with latest stable 1.85 ?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Add descriptions for DAG outputs

It seems a bit odd that "description" is a supported property for recipe inputs but not recipe outputs.  It would be good to add this at some point.

Implemented in io-refactor branch.


Get started with automated testing

starting from template yml file.

Even though the tests are failing, I'm merging so I can open a new PR with the fixed toml file.


Chisel&Bits/ForgeMultipart not functioning properly with Mekanism

Issue description:
When trying to use Chisel&Bits (v13.14) or ForgeMultipart (v<IP_ADDRESS>) in conjunction with Mekanism (v9.3.4-fix) for Minecraft 1.11.2, Forge version <IP_ADDRESS>6, I get improper functionality with cables, and pipes.

When attempting to apply a 'cover' or 'bit' it simply does not work as it should/used to
Steps to reproduce:

Place Pipe/Cable
Attempt to apply ForgeMultipart or Chisel&Bits parts
Failure

Version (make sure you are on the latest version before reporting):
**Forge: <IP_ADDRESS>6
**Mekanism: v9.3.4-fix
**Chisel&Bits: v13.14
**ForgeMultipart <IP_ADDRESS>

What exactly does not work?

The ''Multipart'' in ForgeMultipart for example. The covers would normally snap onto the cable, but as you can see in the top picture above, I can only get the cover to snap just outside of the cable. This is the same issue with Chisel&Bits, where I can't place the bits on or around the cable

The multipart of FMP isn't supported, we only support MCMP (Mcmultipart) . The C&B is a bit weird, as that's supposed to work as it's MCMP.

I updated my Mekanism to <IP_ADDRESS> and reinstalled my McMultipart. But now stuff like this happens on our server

Is the rendering failing to look connected only when C&B is on the part?

Unfortunately, no. I recorded this Video Demonstration of the effect, to allow you to better understand the effect it is having when I try linking universal cables together.
The same effect can be seen when connecting to machinery as well, and stretches across all types of cable. WIth the logistical cables however, it actually stops the item from progressing through the pipe

Any chance you've tried this with just Mek/MCMultipart/C&B installed? I've not played any of Mek in 1.11 so can't say I've seen it.

Well.. That's a first.. I've played almost every version (singelplayer and multiplayer) an this is something I haven't seen before. It looks like a mod or something is messing with the blockstates causing it not to render the connection correctly.
Is the power being transferred or is it only a render glitch?

No, power has not 'apparently' been affected by this glitch. Logistic Pipes, however, as you can see in the video above, actually stops the pipe from transferring items, until said pipe is fixed. I should also remind that this is only an issue on multiplayer, and though I forgot to add before since I didn't think it was important, I am running SpongeForge 6.1.0-BETA with Nucleus 1.1.3, PEx 2.0, VoxelSniper Sponge 8.4.1, FastAsyncWorldEdit 17.09.24 and Worldedit Forge 6.1.6

UPDATE: This is definitely an issue caused directly by sponge. After temporarily removing it, the cables and pipes worked properly, as they should. I'm not sure, however, what to do now that I've figured this out

Oh good, I don't have to suggest trying without Sponge  xD
I would suggest reporting to them, as Sponge is a very invasive core mod that does things forge mods don't anticipate. That's why it gets a lot of hate.


VideoClips.subset() does not reflect output_format of the original VideoClips

🐛 Describe the bug
When new VideoClips is created using VideoClips.subset() function, output_format of the original VideoClips is not taken into account.
Because of this, passing output_format="TCHW" argument to torchvision.datasets.hmdb51.HMDB51 does not work.
It seems that HMDB51 creates full_video_clips and video_clips for each fold of the dataset using subset() function.
Code snippet
Below is the code snippet for reproducing the bug:
import os
from torchvision.datasets import HMDB51

dataset_root = '~/workspace/dataset/hmdb51'
dataset_root = os.path.expanduser(dataset_root)
annotation_path = '~/workspace/dataset/testTrainMulti_7030_splits'
annotation_path = os.path.expanduser(annotation_path)

hmdb51_thwc = HMDB51(
    root=dataset_root,
    annotation_path=annotation_path,
    frames_per_clip=16,
    step_between_clips=1,
    frame_rate=2,
    fold=1,
    train=False,
    num_workers=8,
    output_format="THWC",
)
video, audio, class_index = hmdb51_thwc[0]
print(video.shape)

hmdb51_tchw = HMDB51(
    root=dataset_root,
    annotation_path=annotation_path,
    frames_per_clip=16,
    step_between_clips=1,
    frame_rate=2,
    fold=1,
    train=False,
    num_workers=8,
    output_format="TCHW",
)
video, audio, class_index = hmdb51_tchw[0]
print(video.shape)

Output:
torch.Size([16, 240, 320, 3])
torch.Size([16, 240, 320, 3])

Possible solution:
Passing output_format of the original VideoClips when instantiating new VideoClips in VideoClips.subset() function.
Versions
Collecting environment information...
PyTorch version: 1.12.1+cu113
Is debug build: False
CUDA used to build PyTorch: 11.3
ROCM used to build PyTorch: N/A

OS: Ubuntu 20.04.4 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.31

Python version: 3.10.6 (main, Aug 30 2022, 03:24:51) [GCC 9.4.0] (64-bit runtime)
Python platform: Linux-5.4.0-126-generic-x86_64-with-glibc2.31
Is CUDA available: True
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: NVIDIA TITAN RTX
GPU 1: NVIDIA TITAN RTX

Nvidia driver version: 515.65.01
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.2.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.2.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.2.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.2.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.2.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.2.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.2.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

Versions of relevant libraries:
[pip3] numpy==1.23.2
[pip3] pytorch-lightning==1.3.8
[pip3] pytorchvideo==0.1.5
[pip3] torch==1.12.1+cu113
[pip3] torchaudio==0.12.1+cu113
[pip3] torchmetrics==0.5.1
[pip3] torchvision==0.13.1+cu113
[conda] Could not collect

Currently, I am bypassing this issue by hardcoding video_clips.output_format = "TCHW".
For example,
hmdb51_tchw = HMDB51(
    root=dataset_root,
    annotation_path=annotation_path,
    frames_per_clip=16,
    step_between_clips=1,
    frame_rate=2,
    fold=1,
    train=False,
    num_workers=8,
    output_format="TCHW",
    _precomputed_metadata=hmdb51_test_metadata,
)
hmdb51_tchw.video_clips.output_format = "TCHW"
video, audio, class_index = hmdb51_tchw[0]
print(video.shape)

Output:
torch.Size([16, 3, 240, 320])

Thanks for the report @Simcs , I confirm that this is indeed a bug. I will create a PR to fix this.

I believe I have fixed for this issue with #6700 (will be in torchvision v0.14) and I will close the issue for now.


[Feat] Support multi-labels for a single vertex/edge

Is your feature request related to a problem? Please describe.
For the graphs in Neo4j or NebulaGraph,  a single vertex or edge can have multiple labels. For example, a vertex in Neo4j graph could be labeled as a person as well as a student, thus it has two labels: person and student. While currently, in GraphAr,  a vertex or an edge can have only one label. GraphAr needs to support multi-labels for aligning with Neo4j and Nebula.
Describe the solution you'd like

replace the label definition of GraphAr with vertex type/edge type. and
storing each label as one separate column (together, all labels of a vertex/edge table form a sparse matrix).

Describe alternatives you've considered
Storing a label list (which is complex Array type) as a property on vertices/edges.

Prefer to store one label per column for scanning vertex/edge values by a specific label in order to obtain better performance.

@freshyl @KateHed Can you help on this issue?

We seem to be reaching a point where more and more graphs are supporting multiple labels. Amazon Neptune would be another one that has this feature. I think TinkerPop will likely support this feature in the future given that there are so many graphs that feature it.

claim this task🙋🏻♂


cp4ba operators are in pending state

Describe the bug
cp4ba operators are stuck in pending state

I believe this is caused by the OLM issue with async subscriptions which should be resolved in OCP 4.10.46+ and OCP 4.11.


feat: Configure optimizing thread in runtime

It's currently in index build option, better to be able to change in runtime

Update: now the design for this is a seperated function to control optimizing thread for each index:
select alter_vector_index("t_idx", 'optimizing.optimizing_threads', 100);

We may move this feature to milestone v0.3.0.


Not compatible with IDEA 2024.3

Looks like the plugin is not compatible with IntelliJ IDEA 2024.3.

@AntoniRokitnicki , as I can see, it was changed on Dec 29. Was that version released?


[Feature request] webmin support

It would be great, if the rclone will support webmin admin frontend.

Are there some docs somewhere as to what rclone would have to do?

http://doxfer.webmin.com/Webmin/Module_Development
http://doxfer.webmin.com/Webmin/Advanced_Module_Development

+1
would be great to have any WebUI support - and since webmin has it's own security etc. maybe it would be easier to build on top of that as a plugin. RcloneBrowser is great for Desktops. But would be great to have a solution for headless Servers.

Also in support of this.  It would be a great addition to already great software.

Would anyone like to help with this?

+1

https://forum.rclone.org/t/rclonemon-web-based-remote-job-monitor/9564/35
Looks awesome. Someone able to implement in webmin?