Memory usage keeps on increasing

When trying to run
python examples/meltingpot/train_on_substrates.py

The RAM usage continuously keeps on increasing till it's full and gets killed.
Is this expected or is there a memory leak somewhere?

Thank you for reporting this @kinalmehta I think this results from repeated retracing by tf.function. It appears that this memory issue was not experienced initially as the script was run on a VM. I'll look into the retracing issue to ensure that the script runs seamlessly, even for local debugging.

The issue seems to be because of the parameters being passed to _policy method which are not TF objects and @tf.function only seems to support TF objects based on following warnings from TF
[evaluator/0] W0114 15:54:21.299422<PHONE_NUMBER>44128 def_function.py:150] 6 out of the last 6 calls to <function MADQNFeedForwardExecutor._policy at 0x7fc52c2078b0> triggered tf.function retracing. Tracing is expensive and the excessive number of tracings could be due to (1) creating @tf.function repeatedly in a loop, (2) passing tensors with different shapes, (3) passing Python objects instead of tensors. For (1), please define your @tf.function outside of the loop. For (2), @tf.function has experimental_relax_shapes=True option that relaxes argument shapes that can avoid unnecessary retracing. For (3), please refer to https://www.tensorflow.org/guide/function#controlling_retracing and https://www.tensorflow.org/api_docs/python/tf/function for  more details.

Is there any workaround or any plans to handle this.
I'm ready to help with the implementation side.

You are right @kinalmehta
You can use the _policy method without tf.function to avoid retracing.

@ldfrancis could we perhaps look into this in more detail? Since tf.function can provide significant speed ups in some cases, it might be worth seeing if there is a simple fix (i.e ensure we feed the policy a TF object) to avoid the retracing. @EdanToledo this could also be the source behind the memory issues in PPO.

Closing all TF issues as we are depreciating our TF systems.


TypeError with getType

When using apiCheck with angular-formly, I've come across this error. I'm not sure why type returns undefined. I traced the issue down to:
formlyConfig.js line 170 in getType
var type = typeMap[name]; , type becomes undefined
name has the type name, for example 'lx-input'.
typeMap has the array of types, including 'lx-input: Object'

Very interesting. How are you creating your type? Here's the entire setType function:
function setType(options) {
      if (angular.isArray(options)) {
        angular.forEach(options, setType);
      } else if (angular.isObject(options)) {
        checkType(options); // <-- at this point, the options you pass are validated using apiCheck, so the name is definitely defined and a string here.
        if (options.extends) {
          extendTypeOptions(options); // <-- if you're extending then options runs through this function, but nothing happens to the `name` property
        }
        typeMap[options.name] = options; // <-- we're putting the `options.name` here.
      } else {
        throw getError(`You must provide an object or array for setType. You provided: ${JSON.stringify(arguments)}`);
      }
    }

That function should be using apiCheck before long, but anyway, I think you get the idea. My first place to check (and step through the code) would be in the setType function.

Are you still experiencing this issue?

No longer an issue, closed!

Fantastic! :D


Refactor webhook handlers

Summary
Refactored the main POST route contents to use 2 handlers for webhook parsing. The file was really long, and it made testing and maintaining the codebase very hard. This refactor includes:

Extracting all the contents of the linear if statement to a new file utils/webhook/linear.handler.ts
Extracting all the contents of the github if statement to a new file utils/webhook/github.handler.ts
Removed dependency on the req object inside the handlers (body and headers passed as params)
Instead of calling res.send inside the handlers, the handlers exit in 2 ways:

Throw an API error exception with message and code status
Return a status string back to calling function

Haven't touched any functionality rather the exist of the handler functions

I hope these changes are the first step to further refactor the handler functions as they contain more duplicated code.

@tedspare @PeerRich wanted to add some tests with jest but realized it will be close to impossible without refactoring the main function a bit. Would love to hear your thoughts on this one 🙏

Monumental effort @scopsy - this will make the codebase much easier to navigate. Happy to review when ready.

@scopsy ready to merge?

Good on my end, we have this deployed internally for the last few days already.


[BUG] BlobClient Download methods not returning the right results

Library name and version
Azure.Storage..Blobs 12.7.0
Describe the bug
I have a model that contains two lists of interfaces:
public class MyClass
{
     public List<MyFirstInterface> FirstList { get; set; }

     public List<MySecondInterface> SecondList { get; set; }
}

I serialize the model and upload it to my Azure Blob Storage account. When I try to retrieve the blob content, one of my two lists is null, even though it should not be.
The weird part is that if I retrieve the blob using a blob-triggered Azure Function, the retrieved content is correct. My two lists are non-null and non-empty. But when I try to retrieve the blob myself using the BlobClient class of Azure.Sotrage.Blobs, I get one of the two lists null.
I have tried 2 different methods for retrieving the content of my blob as a string. First, I have used the DownloadToAsync(stream) method:
            using (var stream = new MemoryStream())
            {
                await blobClient.DownloadToAsync(stream);
                var bytes = stream.ToArray();
                string content = Encoding.UTF8.GetString(bytes);
            }

Second, I have used the DownloadAsync() method:
            var response = await blobClient.DownloadAsync();
            string content = "";

            using (var streamReader = new StreamReader(response.Value.Content))
            {
                while (streamReader.EndOfStream == false)
                {
                    content += streamReader.ReadLine();
                }
            }

Both methods return the model with one of my two lists null. I don't know what else to try at this point. Like I said, the returned model has the right values when I use an Azure Function with a blob trigger, but I cannot get the right content through the download methods of BlobClient, which is really odd.
Any suggestions or explanations?
Expected behavior
The two download methods should return the right serialized values when I call one of the Download methods.
Actual behavior
It returns the wrong value: one of my two lists is null, when it shouldn't.
Reproduction Steps
I use a model with two non-empty lists of interfaces:
public class MyClass
{
public List FirstList { get; set; }
 public List<MySecondInterface> SecondList { get; set; }

}
I serialize my model and upload it my Azure Blob Storage
I then try to retrieve the content as a string using any one of two Download methods of my blob client. First:
           using (var stream = new MemoryStream())
            {
                await blobClient.DownloadToAsync(stream);
                var bytes = stream.ToArray();
                string content = Encoding.UTF8.GetString(bytes);
            }

Second:
            var response = await blobClient.DownloadAsync();
            string content = "";

            using (var streamReader = new StreamReader(response.Value.Content))
            {
                while (streamReader.EndOfStream == false)
                {
                    content += streamReader.ReadLine();
                }
            }

Environment
.NET 6.0, in C#. I have a class library that retrives blobs by their IDs. I am on Visual Studio 2022 17.10, 64bits.

@GCoding83 Does the string have the right content before deserializing? Also, do you see the content as expected when checking the blob from the portal?

Thanks for the help. I actually realized that the problem was with my blob-retrieval logic. There is no real bug on your end. Sorry ab out that!


Enable K2 compiler.

e: moshi-ir's proguard rule generation currently doesn't support the experimental K2 compiler
Disable the K2 compiler by removing -Xuse-k2 flag or disable proguard rule gen.

https://github.com/ZacSweers/MoshiX/issues/446


Bug: Configurable attributes not working with custom flags

Description
We're trying to use rules_xcodeproj with configurable attributes and custom flags.
However when passing our custom flag
bazel run //:xcodeproj --//:word=2

The wrong value for select() is chosen.
Reproduction steps
Reproduction: https://github.com/louwers/reproduction-xcodeproj
load("@bazel_skylib//rules:common_settings.bzl", "string_flag")
load(
    "@rules_xcodeproj//xcodeproj:defs.bzl",
    "xcodeproj",
)

string_flag(
    name = "word",
    values = ["1", "2"],
    build_setting_default = "1",
)

config_setting(
  name = "word1",
  flag_values = {
    "word": "1"
  }
)

config_setting(
  name = "word2",
  flag_values = {
    "word": "2"
  }
)

cc_binary(
  name = "example",
  srcs = [
    "main.cc",
    "word.h"
  ] + select({
    "word1": ["word1.cc"],
    "word2": ["word2.cc"]
  }),
  visibility = ["//visibility:public"],
)

xcodeproj(
    name = "xcodeproj",
    project_name = "ExampleProj",
    tags = ["manual"],
    top_level_targets = [
        "example"
    ],
)

Run:
bazel run //:xcodeproj --//:word=1  # prints hello
bazel run //:xcodeproj --//:word=2  # prints world

bazel run //:xcodeproj --//:word=2
# will print hello and includes word1.cc instead of word2.cc
xed ExampleProj.xcodeproj

Expected behavior
I expect word2.cc to be included in the Xcode project in the above example when running
bazel run //:xcodeproj --//:word=2

rules_xcodeproj version
1.7.1
Xcode version
14.3
Bazel version
6.2.1
rules_apple version
No response
rules_swift version
No response
Additional information
No response

We don't support passing flags that way. You need to set it in your .bazelrc/xcodeproj.bazelrc file(s), or use extra config flags.

Alright, we thought so already. :)
Could you give an example of how to use the extra config flags?

Ah, like this:
bazel run //:xcodeproj --@rules_xcodeproj//xcodeproj:extra_common_flags="--//:word=2"

It wasn't clear to me if I needed to pass a file or something else. But now I get it.
Thanks!


Make KalkError public

I'm working on a library that will use kalk but I cannot easily handle KalkErrors because I cannot import the type. This PR makes KalkError public to it can be consumed by external code.
Thanks!

 Thanks.


update showcase.html

add 一休 app  by Hangzhou Xiuxiu Technology
app store url: https://itunes.apple.com/cn/app/yi-xiu-zhong-xiao-qi-ye-cai/id1050588308?mt=8

Hi @Menq, we don't accept PRs to gh-pages, this branch is automatically generated.
You want to make a PR to change this file instead https://github.com/facebook/react-native/blob/master/website/src/react-native/showcase.js

@bestander  Thanks !!!


Cannot build studio

Expected Behavior
Build success 👍
Current Behavior
I tried to build Lona studio according to readme but i get following error when trying to build:
Type of expression is ambiguous without more context.
File CSValue.swift Line: 239
File CSValue.swift Line: 259
File CSValue.swift Line: 292
File CSType.swift Line: 455
File CSType.swift Line: 468
File CSType.swift Line: 482
XCode version: 12.1
Swift: 5.3
Sample screenshot

You can build it by removing CSType before the .variant case.


DNSCache: TTL cleanup implementation.

The reason for this commit is to avoid large list of identities on fqdn policy
and implement the cleanup process to clean expires IPS and avoid large times on
policyCalculation.
The reason to use a cleanup map in dnsCache is to avoid to loop all the DNS
cache entries, so each second we have a map and a controller will clean the
entries that has some ips expired at that point of time.
The reason to use the controller, is to avoid to have a goroutine with a
timer.Tick each second, and have all in the same goroutine. To avoid leaks,
instead the passing time.Now() use the cache.lastCleanup to get all the entries
from the last run, policy regeneration can take more than 40 seconds in some
huge policies and with this method leak seconds entries int he cleanup map will
not happen.
Tried also with a callback function, but that can block the cache in case of the
long policyCalculation times and DNS proxy will not resolve/response correctly.
Also tried with the channel, but need to have a buffer and the Cilium way is
more related to use a controller.
This PR will not work if https://github.com/cilium/cilium/pull/6692 is not merged.
Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

This change is

test-me-please

test-me-please

test-me-please

I've marked this ready to review because the testing comments are not blocking.

test-me-please

test-me-please

sorry @eloycoto I accidentally pressed close!

test-me-please

Needs a quick refresh:
00:14:45.987     runtime: 104a105
00:14:45.987     runtime: >       --tofqdns-endpoint-max-ip-per-hostname int    Maximum number of IPs to maintain per FQDN name for each endpoint (default 50)
00:14:45.987     runtime: Detected a difference in the cmdref directory
00:14:45.987     runtime: diff -r: diff -r ./Documentation/cmdref/cilium-agent.md /tmp/tmp.20iWrMlkhK/cilium-agent.md
00:14:45.987     runtime: 104a105
00:14:45.987     runtime: >       --tofqdns-endpoint-max-ip-per-hostname int    Maximum number of IPs to maintain per FQDN name for each endpoint (default 50)
00:14:45.987     runtime: Only in ./Documentation/cmdref: cli_index.rst
00:14:45.987     runtime: Only in ./Documentation/cmdref: index.rst
00:14:45.987     runtime: Only in ./Documentation/cmdref: kvstore.rst
00:14:45.987     runtime: Please rerun 'make -C Documentation cmdref' and commit your changes

test-me-please


Add clientId implementation

Fixes #145
Changes proposed in this pull request:

Adds OAuth2 clientId support

@lchayoun can you take a look?
I'm upgrading spring boot and cloud versions, as the latest spring cloud version isn't compatible with Spring Boot 2.0.x I'm bumping the lib version to 2.3.0.

@lchayoun the security problem is related to the redis test project, it can be ignored


Show Progress Bar Only on Full Screen

I want the progress bar to be only visible when I on full screen mode, how can I do that?

I want the progress bar to be only visible when I on full screen mode, how can I do that?

Customized the ChewieController.customControls


Remove S3 credentials from bitstore.xml to allow the permission from the IAM role on EC2 instance

permission from the IAM role on EC2 instance

Hi @pasqualecvl thank you very much for PR but there are some strict dependency to satisfy at compile level https://mvnrepository.com/artifact/com.amazonaws/aws-java-sdk-core/1.11.976  that we managed at https://github.com/4Science/DSpace/pull/222/files. Basis on this work we move forward to try to manage permission at environment level in additional pull request.


Feature Request: Verify Pin Function

A function that could validate a pin without having to join it. It would return true if there was a game at that pin and false if not.

This is a feature that isn't really needed. You can use the following function:
function PinExists(pin){
  return new Promise(res=>{
    const https = require("https"),
      req = https.get("https://kahoot.it/reserve/session/" + pin),
      chunks = [];
    req.on("data",chunk=>{chunks.push(chunk);});
    req.on("end",()=>{
      const data = Buffer.concat(chunks).toString("utf8");
      if(data === "Not found"){
        res(false);
      }else{
        res(true);
      }
    });
  });
}

The function doesn't work for challenge pins, but it would act in a similar way.


eject command on windows creates different path sepalators to package.json

Description
After npm run eject on Windows , path sepalators in package.json are '\' (double back slash).

npm run eject  on Windows

package.json
"setupFiles": [
  "<rootDir>\\config\\polyfills.js"
]

npm run eject  on OS X

package.json
"setupFiles": [
  "<rootDir>/config/polyfills.js"
]

Expected behavior
"setupFiles": [
  "<rootDir>/config/polyfills.js"
]

path sepalator '/' is runs both (win/mac) environments.
Environment

npm ls react-scripts (if you haven’t ejected):
<EMAIL_ADDRESS>

node -v:
v7.4.0

npm -v:
4.1.2

Operating system:

Windows 7 64bit

Interesting, thanks. Do both variants work well, or is only / working?

/ works on win and mac,
but \\  works only on win.

Something as simple as this?
diff --git a/packages/react-scripts/scripts/eject.js b/packages/react-scripts/scripts/eject.js
index b8f9d31..02e77ca 100644
--- a/packages/react-scripts/scripts/eject.js
+++ b/packages/react-scripts/scripts/eject.js
@@ -145,7 +145,7 @@ prompt(

   fs.writeFileSync(
     path.join(appPath, 'package.json'),
-    JSON.stringify(appPackage, null, 2)
+    JSON.stringify(appPackage, null, 2).replace(/[\\]/g, '/')
   );
   console.log();

Patched eject.js  outputs duplicate path sepalator....
    "setupFiles": [
      "<rootDir>//config//polyfills.js"
    ],

But it works on windows :smile:

Hmm.. that's odd that there's duplicates.
> "<rootDir>\\config\\polyfills.js".replace(/[\\]/g, '/')
'<rootDir>/config/polyfills.js'
>

This should do it, @monamu:
diff --git a/packages/react-scripts/scripts/eject.js b/packages/react-scripts/scripts/eject.js
index b8f9d31..cf8d5d7 100644
--- a/packages/react-scripts/scripts/eject.js
+++ b/packages/react-scripts/scripts/eject.js
@@ -145,7 +145,7 @@ prompt(

   fs.writeFileSync(
     path.join(appPath, 'package.json'),
-    JSON.stringify(appPackage, null, 2)
+    JSON.stringify(appPackage, null, 2).replace(/[\\]+/g, '/')
   );
   console.log();

It worked fine :smiley: @Timer

This should be fixed in 0.9.2, please verify!

<EMAIL_ADDRESS>works fine on windows environment!
and packege.json generated  as intented.

Great, thanks for letting us know @monamu.


[Bug]: Key modifiers on subsequent down() calls not working

Bug expectation
I expect subsequent calls to down() to not ignore key modifiers like docs say at https://pptr.dev/api/puppeteer.keyboard.down/#remarks.
The example worked in eralier puppeteer version, probably v5.x. Not sure about any version in between.
Bug behavior

[ ] Flaky
[ ] PDF

Minimal, reproducible example
const puppeteer = require('puppeteer');

(async () => {
  const browser = await puppeteer.launch();
  const page = await browser.newPage();
  await page.setContent('<input id="login">');

  await page.waitForSelector('#login');
  let input = await page.$('#login');

  await page.keyboard.down('Shift');
  await input.type('a');
  await page.keyboard.up('Shift');

  await page.keyboard.press('CapsLock');
  await input.type('a');

  await page.keyboard.down('Shift');
  await page.keyboard.down('a');
  await page.keyboard.up('a');
  await page.keyboard.up('Shift');

  let value = await input.getProperty('value').then(_ => _.jsonValue());

  if (!value.includes('A')) {
    throw new Error('no uppercase a found')
  }

  await browser.close();
})();

Error string
no uppercase a found
Puppeteer configuration
No response
Puppeteer version
19.7.2
Node version
v18.12.1
Package manager
yarn
Package manager version
3.4.1
Operating system
Linux

Also reproduces in official pptr docker image with
docker run -it --rm -v $(pwd)/test.js:/home/pptruser/test.js --init --cap-add=SYS_ADMIN ghcr.io/puppeteer/puppeteer:latest node test.js

@jrandolf could you please take a look?

The comment applies only when you use the key code for the key down. For example,
const puppeteer = require('puppeteer');

(async () => {
  const browser = await puppeteer.launch();
  const page = await browser.newPage();
  await page.setContent('<input id="login">');

  await page.waitForSelector('#login');
  let input = await page.$('#login');

  await page.keyboard.down('Shift');
  await page.keyboard.down('KeyA');
  await page.keyboard.up('KeyA');
  await page.keyboard.up('Shift');

  let value = await input.getProperty('value').then(_ => _.jsonValue());

  if (!value.includes('A')) {
    throw new Error('no uppercase a found')
  }

  await browser.close();
})();

For historical reasons, we combine "key" and "code" values as acceptable inputs for key presses but only when given the latter do we actually apply modifiers because with the former (e.g. 'a'), you are specifying an explicit value.
It could be said however that we are already bias since shifting for "code" values follows the US layout, so it could "make sense" to reverse map the "key" to the "code" and then apply shift, but this would be breaking behavior.
May I ask what your use case is that requires you to do this explicit shifting?


Ruby Catalog of Things App - Kanban Board Setup 🎫

Hi there! We are @ITurres and @demesameneshoa,

Team Member 1: @demesameneshoa
Team Member 2: @ITurres
Team Member 3: @ITurres & @demesameneshoa (divided tasks).

💎 Ruby Project Kanban Board

Hi @ITurres @demesameneshoa ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
To Highlight 💯

Each card on the board has:a descriptive title✔
a description of the task.✔
Each card on the board has Descriptive commit messages ✔
columns in students' Kanban board are the same as in the template.✔
Good use of Gitflow ✔

[x]  Please check the comments under the review.

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me on( @Adebowale ) in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Great then, thank you @ademibowale!


Add App Net based CSM Observability Test

Created a new test app_net_csm_observability_test.py that's largely a copy of gamma/csm_observability_test.py with some adjustments.
Refactor some flags to be passed to the k8s_xds_server_runner.
Use ServerDeploymentArgs everywhere

This PR was based on top of #33, and a replacement of #72.

[ ]  grpc/core/master/linux/psm-csm
[ ] grpc/core/master/linux/grpc_xds_k8s_lb

[ ]  grpc/core/master/linux/psm-csm

[ ] grpc/core/master/linux/psm-csm

[ ] grpc/core/master/linux/psm-csm - xds server builder removed
[ ] grpc/core/master/linux/psm-csm

[ ]  grpc/core/master/linux/psm-csm
[ ] grpc/core/master/linux/grpc_xds_k8s_lb

@sergiitk force-pushed the app-net-csm-o11y-2 branch from 442fdea to 78ed0fe - removed my commits were split to PR #93 and merged to main
@sergiitk sergiitk force-pushed the app-net-csm-o11y-2 branch from 78ed0fe to 75c4231 - rebased against latest main

[ ] grpc/core/master/linux/psm-csm
[ ] grpc/go/master/branch/psm-csm


[in_app_purchase] [iOS] Can not load the storekit configure

Steps to reproduce

Create storekit configuration and add product with certain id
Edit scheme and add storekit into scheme
Call function queryProductDetails with certain id and not return product

Expected results
Call function queryProductDetails and return the product which setup in the Storekit configuration file
Actual results
Call function queryProductDetails and throw storekit_getproductrequest_platform_error
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

@tuyen3962
In order to properly address the issue, please provide us complete minimal reproducible code sample along with flutter doctor -v.

and throw storekit_getproductrequest_platform_error

Please provide complete error log.

please provide us complete minimal reproducible code sample

@tuyen3962 This as well importantly.

Please check it for me
Code sample:
final result = await InAppPurchase.instance.queryProductDetails({'id'});
if (result.error != null && result.productDetails.isEmpty) {
return;
}
Now I receive the error message when I query product detail in the version 3.2.0 in_app_purchase
Error when I debug it
#0      SKPriceLocaleMessage.decode (package:in_app_purchase_storekit/src/messages.g.dart:417:29)
#1      SKProductMessage.decode (package:in_app_purchase_storekit/src/messages.g.dart:372:41)
#2      _InAppPurchaseAPICodec.readValueOfType (package:in_app_purchase_storekit/src/messages.g.dart:556:33)
#3      StandardMessageCodec.readValue (package:flutter/src/services/message_codecs.dart:477:12)
#4      StandardMessageCodec.readValueOfType (package:flutter/src/services/message_codecs.dart:522:23)
#5      _InAppPurchaseAPICodec.readValueOfType (package:in_app_purchase_storekit/src/messages.g.dart:564:22)
#6      StandardMessageCodec.readValue (package:flutter/src/services/message_codecs.dart:477:12)
#7      StandardMessageCodec.readValueOfType (package:flutter/src/services/message_codecs.dart:522:23)
#8      _InAppPurchaseAPICodec.readValueOfType (package:in_app_purchase_storekit/src/messages.g.dart:564:22)
#9      StandardMessageCodec.readValue (package:flutter/src/services/message_codecs.dart:477:12)
#10     _InAppPurchaseAPICodec.readValueOfType (package:in_app_purchase_storekit/src/messages.g.dart:560:49)
#11     StandardMessageCodec.readValue (package:flutter/src/services/message_codecs.dart:477:12)
#12     StandardMessageCodec.readValueOfType (package:flutter/src/services/message_codecs.dart:522:23)
#13     _InAppPurchaseAPICodec.readValueOfType (package:in_app_purchase_storekit/src/messages.g.dart:564:22)
#14     StandardMessageCodec.readValue (package:flutter/src/services/message_codecs.dart:477:12)
#15     StandardMessageCodec.decodeMessage (package:flutter/src/services/message_codecs.dart:341:28)
#16     BasicMessageChannel.send (package:flutter/src/services/platform_channel.dart:218:18)

#17     InAppPurchaseAPI.startProductRequest (package:in_app_purchase_storekit/src/messages.g.dart:703:47)

#18     SKRequestMaker.startProductRequest (package:in_app_purchase_storekit/src/store_kit_wrappers/sk_request_maker.dart:32:9)

#19     InAppPurchaseStoreKitPlatform.queryProductDetails (package:in_app_purchase_storekit/src/in_app_purchase_storekit_platform.dart:167:18)

#20     PaymentController.handleForm (package:source_base/screen/payment_course/payment_course_controller.dart:118:22)

#21     FormTextFieldHandler.onSubmit (package:source_base/widget/textfield/text_field_node.dart:189:7)

@tuyen3962
You are most probably hitting https://github.com/flutter/flutter/issues/154047 which has been fixed last month. So please upgrade your sdk and re-run your scenario to confirm.

@darshankawar this is another variable which can be null when convert from list to object.
I find the root problem in the line 417 of message.g.dart file:
countryCode: result[2]! as String
Please check it again

SKPriceLocaleMessage.decode (package:in_app_purchase_storekit/src/messages.g.dart:417:29)
#1      SKProductMessage.decode (package:in_app_purchase_storekit/src/messages.g.dart:372:41)

https://github.com/flutter/packages/blob/4926c0f8bd99ac61e5208e3410182be97ec0c2a4/packages/in_app_purchase/in_app_purchase_storekit/lib/src/messages.g.dart#L417
and
https://github.com/flutter/packages/blob/4926c0f8bd99ac61e5208e3410182be97ec0c2a4/packages/in_app_purchase/in_app_purchase_storekit/lib/src/messages.g.dart#L372
Probably queryProductDetails() with the productID gets data from storekit, but field that will go into countryCode in the function SkPriceLocaleMessage.decode(Object result) resulting in null.

Yes, it is relevant to country code when i test it with storekit. Please check and fix it 🤩🤩🤩

cc @LouiseHsu


#feature; Support More Gamma Strategies Networks

What do you think is missing?
Get all Gamma Strategies subgraphs to be prod. This will require:

Add BSC, Moonbeam, Celo, Polygon zkEVM
Get optimism and arbitrum to be prod
Pull in latest price lib (still prolly not gonna work for polygon zkEVM, not sure ab the dev deployments rn)

Describe the solution you'd like
Let's add support for these new chains. We will also need to pull in the latest price library.
Links for reference

https://docs.gamma.xyz/gamma/learn/scans

To QA:

https://okgraph.xyz/?q=dmelotik%2Fgamma-optimism
https://okgraph.xyz/?q=dmelotik%2Fgamma-arbitrum

@dmelotik looks like:

OP has 0 TVL

Arbitrum TVL is much lower than expected. Its most likely pricing a lot of pairs incorrectly. Looks like its only taking into account pairs from Uniswap and not Ramses, Camelot, and Zyberswap

Also: https://github.com/messari/subgraphs/issues/2379


Editor removing characters when pressing TAB to indent or enter for linebreaks.

Description of your problem
What steps will reproduce the problem?
its sporadic. but might be because sometimes the only way to remove indents is to use ctrl-backspace
a regular backspace wont do anything. maybe because of the cell creating characters. #%%
restarting spyder didnt change it.
and after when adding indent with tab afterwards, it deletes the first couple characters.
the enter has a similar reason. hard to pin it down.
gifs showing it:
https://media.giphy.com/media/3ohhwjhhtZcPfGzaLe/giphy.gif
https://media.giphy.com/media/3o7aD18OHv7vYOpFlK/giphy.gif
I'm using Indentation characters "Tabulations", not Space indentation. Tab stop with: 6 spaces
Please provide any additional information below
Versions and main components
Anaconda 1.6.2
Spyder Version: 3.1.4
Python Version: 3.6

@rlaverde, this was fixed already, right?

@ccordoba12  Yes, I think this is duplicated of  #4475, already fixed in spyder3.2
@sugoidesune Please update spyder, and test if this error still happen.

Closing because of lack of response.


Have policies apply on UPDATE when appropriate

Description
Some policies only validate on CREATE, but apply to mutable objects. Let's validate on UPDATE as well.
I have checked that current policies can be bypassed using kubectl apply, kubectl patch, or kubectl edit, which is a big problem.
Checklist

[x] I have read the policy contribution guidelines.
[ ] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
[ ] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

Additional notes
I have not updated the policies that are labelled as examples and look to not be complete solutions. I have also ignored policies that use resource types I am not familiar with, such as PipelineRun, so it is possible a similar change needs to be made for the policies of those custom resources.

Respectful bump.
I am already using the updated policies, but is there something I should do here? Do you need additional tests? (not sure if that can be done for UPGRADE)

I have changed to AnyIn as requested.
I don't know what artifacthub is or how your hashes are generated, it's not documented anywhere either. If you really expect contributors to do this, you should probably document it, or better yet have GitHub CI do it (if you want contributions, that is).

If DCO is required, that should probably also be mentioned in your contribution section...
Look, I have fixed what seems to me like a security issue. I am willing to go through your hoops to have the rest of your users benefit from this, but you seem to expect that all contributors go through many such hoops, none of them listed anywhere, to appease the automated checks that you enforce on us.
I know this is open source and we all have day jobs that take priority etc, but surely you can see that something serious is broken with your process?
What's an artifacthub digest? Do I literally hash the file?

I'm sorry you've found this process so difficult. I don't recall anyone else has ever had this amount of difficulty with contributing. In any case, I've made these changes myself in PR #636 and also tried to improve the contribution guidelines so this is easier going forward. I will close this PR since all changes are accounted for in #636.


Getting wrong output after tflite conversion

1. System information

OS Platform and Distribution = Ubuntu 20.04
TensorFlow installation (pip package or built from source): pip installation
TensorFlow library (version, if pip package or github SHA, if built from source):tf-2.12.1

2. Code
Model is converted using the following code:
def representative_data_genRGB():
  path = '/content/gdrive/MyDrive/imx_tflite'
  dataset_list = tf.data.Dataset.list_files(path + '/*.jpg')
  for i in range(len(dataset_list)):
    image = next(iter(dataset_list))
    image = tf.io.read_file(image)
    image = tf.io.decode_jpeg(image, channels=3)
    image = tf.image.resize(image, [IMG_HEIGHT, IMG_WIDTH])
    image = tf.cast(image,tf.float32)
    image = image/255.
    image = tf.expand_dims(image, 0)
    yield [image]

converter = tf.lite.TFLiteConverter.from_saved_model(MODEL_TF)
# converter = tf.lite.TFLiteConverter.from_keras_model(model)
converter. optimizations = [tf.lite.Optimize.DEFAULT]
converter.representative_dataset = representative_data_genRGB
converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS_INT8]
converter.allow_custom_ops = True
converter.inference_type = tf.uint8
converter.inference_input_type = tf.uint8
converter.inference_output_type = tf.uint8
converter.target_spec.supported_types = [tf.int8]

tflite_model = converter.convert()

with open(MODEL_TFLITE, "wb") as f:
  f.write(tflite_model)

3. Failure after conversion
If the conversion is successful, but the generated model is wrong, then state what is wrong:
Following Code is used for the prediction:
try:
  import tflite_runtime.interpreter as tfl  # prefer tflite_runtime if installed
except ImportError:
  import tensorflow.lite as tfl
MODEL_TFLITE = MODEL_TFLITE
interpreter = tfl.Interpreter(model_path=MODEL_TFLITE)  # load TFLite model
interpreter.allocate_tensors()  # allocate
input_details = interpreter.get_input_details()  # inputs
output_details = interpreter.get_output_details()
img = cv2.imread('20221104084515525.jpg')
# img = cv2.cvtColor(img, cv2.COLOR_BGR2RGB)
resized = cv2.resize(img,(IMG_WIDTH,IMG_HEIGHT))/255
if(len(img.shape) == 3):
    image = np.expand_dims(resized, axis=0)
b,h, w, ch = image.shape  # batch, channel, height, width
inp,out  = input_details[0], output_details[0]
# inp,out1, out2, out3, out4  = input_details[0], output_details[0], output_details[1], output_details[2], output_details[3]
int8 = inp['dtype'] == np.uint8  # is TFLite quantized uint8 model
if int8:
    scale, zero_point = inp['quantization']
    image = (image / scale + zero_point).astype(np.uint8)  # de-scale
interpreter.set_tensor(inp['index'], image)
interpreter.invoke()
predict = interpreter.get_tensor(out['index'])

if int8:
    if out['quantization'] != (0.0, 0):
        scale, zero_point = out['quantization']
        predict = (predict.astype(np.float32) - zero_point) * scale  # re-scale

Model produces wrong results:
The attached images shows the results before and after conversion for the same input image:
Before Conversion/Keras Model Results:

After converting into tflite/tflite model results:

5. (optional) Any other info / logs
Following are the logs while converting:
2024-02-27 17:15:02.854021: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'inputs' with dtype float and shape [?,?,?,?]
	 [[{{node inputs}}]]
2024-02-27 17:15:02.930861: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'inputs' with dtype float and shape [?,?,?,?]
	 [[{{node inputs}}]]
2024-02-27 17:15:03.008753: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'inputs' with dtype float and shape [?,?,?,?]
	 [[{{node inputs}}]]
2024-02-27 17:15:06.708407: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'inputs' with dtype float and shape [?,?,?,?]
	 [[{{node inputs}}]]
2024-02-27 17:15:06.810894: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'inputs' with dtype float and shape [?,?,?,?]
	 [[{{node inputs}}]]
2024-02-27 17:15:06.903451: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'inputs' with dtype float and shape [?,?,?,?]
	 [[{{node inputs}}]]
WARNING:absl:Found untraced functions such as _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op while saving (showing 5 of 31). These functions will not be directly callable after loading.
INFO:tensorflow:Assets written to: /home/couger/2nd_shared_dataset/Custom_modelRGBPruned/202422717152_tf2.12-py3.10_96X144-4-channelRGB/model/assets
INFO:tensorflow:Assets written to: /home/couger/2nd_shared_dataset/Custom_modelRGBPruned/202422717152_tf2.12-py3.10_96X144-4-channelRGB/model/assets
2024-02-27 17:15:11.449645: W tensorflow/compiler/mlir/lite/python/tf_tfl_flatbuffer_helpers.cc:364] Ignored output_format.
2024-02-27 17:15:11.449671: W tensorflow/compiler/mlir/lite/python/tf_tfl_flatbuffer_helpers.cc:367] Ignored drop_control_dependency.
2024-02-27 17:15:11.449833: I tensorflow/cc/saved_model/reader.cc:45] Reading SavedModel from: /home/couger/2nd_shared_dataset/Custom_modelRGBPruned/202422717152_tf2.12-py3.10_96X144-4-channelRGB/model
2024-02-27 17:15:11.461083: I tensorflow/cc/saved_model/reader.cc:89] Reading meta graph with tags { serve }
2024-02-27 17:15:11.461098: I tensorflow/cc/saved_model/reader.cc:130] Reading SavedModel debug info (if present) from: /home/couger/2nd_shared_dataset/Custom_modelRGBPruned/202422717152_tf2.12-py3.10_96X144-4-channelRGB/model
2024-02-27 17:15:11.496457: I tensorflow/cc/saved_model/loader.cc:231] Restoring SavedModel bundle.
2024-02-27 17:15:11.679895: I tensorflow/cc/saved_model/loader.cc:215] Running initialization op on SavedModel bundle at path: /home/couger/2nd_shared_dataset/Custom_modelRGBPruned/202422717152_tf2.12-py3.10_96X144-4-channelRGB/model
2024-02-27 17:15:11.754645: I tensorflow/cc/saved_model/loader.cc:314] SavedModel load for tags { serve }; Status: success: OK. Took 304813 microseconds.
2024-02-27 17:15:12.143006: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_0' with dtype string and shape [43]
	 [[{{node Placeholder/_0}}]]
2024-02-27 17:15:12.143348: I tensorflow/core/common_runtime/executor.cc:1197] [/device:CPU:0] (DEBUG INFO) Executor start aborting (this does not indicate an error and you can ignore this message): INVALID_ARGUMENT: You must feed a value for placeholder tensor 'Placeholder/_0' with dtype string and shape [43]
	 [[{{node Placeholder/_0}}]]
fully_quantize: 0, inference_type: 6, input_inference_type: UINT8, output_inference_type: UINT8
/home/couger/2nd_shared_dataset/Custom_modelRGBPruned/202422717152_tf2.12-py3.10_96X144-4-channelRGB/model.tflite

@sushreebarsa
Could you please suggest, what may be the reason for the wrong results?

@sushreebarsa
Is there any update?

@priyakansal Sorry for the late response!
The model was saved and loaded successfully with some warnings about untraced functions. Could you consider disabling debug-level logging if it clutters the output. If you're encountering issues after loading the model, please investigate the missing placeholder values (inputs and Placeholder/_0).
Thank you!

Hello @sushreebarsa ,

If you're encountering issues after loading the model, please investigate the missing placeholder values (inputs and Placeholder/_0).

what should I do for the above?

@priyakansal Here is  an example;
import tensorflow as tf

# Assuming your loaded model is stored in a graph 'model_graph'

# Create a session
sess = tf.Session()

# Prepare your data (replace with your actual data)
input_data = tf.constant([1.0, 2.0, 3.0])  # Example input

# Run the model with placeholders
inference_result, input_value, placeholder_0_value = sess.run(
    [model_graph(inputs=input_data), "inputs:0", "Placeholder/_0:0"]
)

# Check for missing values
if input_value is None:
    print("Missing value for 'inputs' placeholder")
if placeholder_0_value is None:
    print("Missing value for 'Placeholder/_0' placeholder")

sess.close()

Please remember to replace the placeholder names and data preparation with your specific model and code.
By using either print statements or the session approach, you can identify if the inputs and Placeholder/_0 placeholders are not receiving the necessary data during inference.
Thank you!


Refactor DB queries ( by moving them from resolvers and reuse them)

We use queries directly in our resolvers , and it makes our code messy, I suggest we should move the queries to a separated file like https://github.com/Giveth/impact-graph/blob/staging/src/repositories/userRepository.ts in this way we can write unit tests for every function(query) and we can reuse them ( currently we have written some queries in several resolvers and it makes it hard to maintain), besides doing this will make it easier to change our ORM/DB in the future , and it's good practice to encapsulate DB queries
PS: I thinks it's not responsibility of resolvers to call DB queries
https://en.wikipedia.org/wiki/Single-responsibility_principle

[ ] Move queries from categoryResolver
[ ] Move queries from donationResolver
[ ] Move queries from projectResover
[ ] Move queries from reactionResolver
[ ] Move queries from statusReasonResolver
[ ] Move queries from userResolver

Please pay attention to these items during doing these stuffs :

Write some sucess/fail scenario test cases for every function that you write for queries
Check https://github.com/Giveth/giveth-dapps-v2/tree/develop/src/apollo/gql to see frontend uses what fields in response, maybe some joins are unnecessary ( @MohammadPCh  All the query/mutations that you use are in here or we should check somewhere else as well?)
when writing test cases, for function that use join , be aware to check wether join works correctly or not

@CarlosQ96  @aminlatifi  Correct me if you have another opinion about what I said

@mohammadranjbarz  is this issue still relevant?

@mohammadranjbarz is this issue still relevant?

We can close it


Animation lag

Hello. I have found one interesting thing.  While i scroll something on screen with your page control animation doesn't work and it starts only after scrolling is stopped. I have tried change mode for display link to .commonModes and it have worked perfectly.
internal func setupDisplayLink() {
        self.displayLink = CADisplayLink(target: self, selector: #selector(updateFrame))
        self.displayLink?.add(to: .current, forMode: .defaultRunLoopMode)
    }

Could you check it and update pod. Thank you.

Hi @shitoexe ,
Thanks for catching that. Will fix it asap.

@shitoexe Hi, we just released fix for this issue. It's available in latest release (0.1.2)


Automated install script

Description
Bash/zsh script to automate the Ubuntu/Linux install instructions
Requirements

.sh script

@a-stickan
Update - I've mostly finished the install script at this point, just need to figure out how to get added to the RoboNav repos so I can make a PR.
Something I actually would like your opinion on: I figured out the source of some of the issues we've been seeing on the command line where colcon-build errors out: these packages are not added to rosdep yet which is why people currently have to add them manually.
As a temporary fix, I could either add these as a manual step in the install script (just loop through a list of the packages and install them using apt) or modify the rosdep rules file in the users'  /etc/ros/rosdep/sources.list.d sources file to point to a fork of the repo (either hosted by the team or a member) like is suggested in the documentation for contributing to rosdep: http://docs.ros.org/en/independent/api/rosdep/html/contributing_rules.html
Any thoughts?

Personally I feel that the rosdep solution you proposed is a bit of a workaround. We should look for a solution that makes building simpler, not one that will require making forks and editing the rosdep. I think the Nanopb errors can be solved with some clever CMake and package logic, but I'll keep the rosdep idea in mind if that doesn't work out.
For non-Nanopb packages though, the standard rosdep commands should work. No idea why that would be dropping errors.

@a-stickan
Here's the rosdep file that I'm talking about:
https://github.com/ros/rosdistro/blob/master/rosdep/base.yaml
The problems I mentioned are basically just missing installing some of the system/apt packages when using rosdep because they aren't in the rosdep base.yaml file (which lists equivalent package sources for supported OS's)- these were the errors I got when originally following the setup instructions that I was able to fix by installing the packages manually at the command line. I think I will try to fix these by figuring out which ones are not included in rosdep right now and have bash download/install them in the install script I wrote.
I think these are different from the nanopb build errors that others were getting (I haven't had those errors yet so I'm not sure what they actually look like). I'll check out your PR from earlier to see if your fixed worked!

Stale issue, closing


Add an "Unauthorized" page

a page for unauthorized access

https://www.permify.co/post/implementing-role-based-access-control-in-vue-js


Sampling rate of the data

I would like to know what is the actual sampling rate of the data?
I think you had pointed this out to the author of Structure-RNN in the following thread that it is 25fps, but it is not very clear to me.
https://github.com/asheshjain399/RNNexp/issues/6
I check your source code in

src/data_utils.py#L215  : Down-sampling by two (200 fps --> 100 fps)
src/seq2seq_model.py#438 : Select 8 data from the original sequence (100 fps --> 100 fps)

If the original data is 200fps, I think the sampling rate of your data should be 100 fps, not 25 fps as mentioned in src/translate.py#L34.
Thank you.

Thank you for clarification.
I couldn't verify the original H3.6M dataset myself, due to their data format.

I couldn't verify the original H3.6M dataset myself, due to their data format.

Right, they used a strange format that matlab can read out of the box, but is tricky to read from python directly. I'm closing this issue now.


pipe doesn't do anything.

const responseStream = fs.createWriteStream('example.txt');
request
            .get('/example.zip')
            .on('error', function (err) {
                debug('Error downloading: ', err);
            })
            .on('progress', function (e) {
                debug('Percentage done: ', e.percent);
            })
            .on('response', function (res) {
                debug('response!');
            })
            .on('end', function (error, response) {
                debug('download finished', error, response);
                resolve(response);
            })
            .pipe(responseStream)

This code doesn't function. No errors are thrown, the 'end' function is called, but error and response are undefined. The response event is never triggered, nor is progress.
The end event is fired, but nothing has been written to the filestream.

It seems that if buffer is enabled and the response compressed, those events are not fired. When buffer is disabled, the file is written to and only the end event is called. It's still buggy but meets my current needs.


-DateTimeSortingFormat converts the page to plain text

We have an huge list of objects (30000+), that consists of multiple columns such as ServerName, Date, Windows updates status, AV status, etc.
When publishing that in New-HTMLTable along with New-HTMLTableCondition, it always puts the False statements first, regards to the date.
So i implemented the "-DateTimeSortingFormat", then it sorts by the Date column, but it removes all colors from the page.
It can be reproduced like this:
$Table = @()
$obj = [PSCustomObject]@{
ServerName = "Server1"
Date = $(Get-date -Format "dd-MM-yyyy HH:mm:ss")
DiskDefined = $false
IPDefined = $true
}
Start-sleep -seconds 5
$obj = [PSCustomObject]@{
ServerName = "Server2"
Date = (Get-date -Format "dd-MM-yyyy HH:mm:ss")
DiskDefined = $true
IPDefined = $true
}
$Table += $obj
New-HTML -Name "Report" {
New-HTMLTab -TabName 'ServerList' {
New-HTMLTable -DataTable $Table -DefaultSortIndex 10 -OrderMulti -DateTimeSortingFormat {
New-HTMLTableCondition -Name 'ServerName' -Type string -BackgroundColor Gray
New-HTMLTableCondition -Name 'Date' -Type string -BackgroundColor Gray
New-HTMLTableCondition -Name 'DiskDefined' -Type bool -Operator eq -Value $true -BackgroundColor Green -Inline
New-HTMLTableCondition -Name 'DiskDefined' -Type bool -Operator ne -Value $true -BackgroundColor red -Inline
New-HTMLTableCondition -Name 'IPDefined' -Type bool -Operator eq -Value $true -BackgroundColor Green -Inline
New-HTMLTableCondition -Name 'IPDefined' -Type bool -Operator ne -Value $true -BackgroundColor red -Inline
}
}
} -ShowHTML
Is that intented to work this way?

It won't work the way you do it. First of all DateTimeSortingFormat requires a string to be provided (you don't provide it) and so the table conditions are used as that string. Then your 2 top conditions have no value so they don't work at all.
$Table = @()
$obj = [PSCustomObject]@{
    ServerName  = "Server1"
    Date        = $(Get-Date -Format "dd-MM-yyyy HH:mm:ss")
    DiskDefined = $false
    IPDefined   = $true
}

$obj = [PSCustomObject]@{
    ServerName  = "Server2"
    Date        = (Get-Date -Format "dd-MM-yyyy HH:mm:ss")
    DiskDefined = $true
    IPDefined   = $true
}
$Table += $obj

New-HTML -Name "Report" {
    New-HTMLTab -TabName 'ServerList' {
        New-HTMLTable -DataTable $Table -DefaultSortIndex 10 -OrderMulti {
            #New-HTMLTableCondition -Name 'ServerName' -Type string -BackgroundColor Gray
            #New-HTMLTableCondition -Name 'Date' -Type string -BackgroundColor Gray
            New-HTMLTableCondition -Name 'DiskDefined' -Type bool -Operator eq -Value $true -BackgroundColor Green -Inline
            New-HTMLTableCondition -Name 'DiskDefined' -Type bool -Operator ne -Value $true -BackgroundColor red -Inline
            New-HTMLTableCondition -Name 'IPDefined' -Type bool -Operator eq -Value $true -BackgroundColor Green -Inline
            New-HTMLTableCondition -Name 'IPDefined' -Type bool -Operator ne -Value $true -BackgroundColor red -Inline
        }
    }
} -ShowHTML -FilePath $PSScriptRoot\mmmmm.html -Online

Please read: https://evotec.xyz/advanced-html-reporting-using-powershell/
DateTimeSorting can take strings for sorting dates in proper ways. Also, you don't have to push Date to string in your objects but can utilize the built-in functionality of PSWriteHTML which can do this for you.
Also for 30k objects I would go and enable DataStore JavaScript. Read the link it will help.


[theme] theme.transition.create defaults to non theme easing value

If you try to modify the theme.transition.easing object in the theme, it does not seem to apply to the components.
Here's a reproduction: https://codesandbox.io/s/youthful-noether-rex8r?file=/src/App.js
If you inspect the <ListItem button />, you'll see that it has a transition with a cubic-bezier that does not match with the theme I provide, even though the transition duration is updated properly.
Version: v4.11.3

The theme is created correctly, the problem is that, the styles are defined like:
    transition: theme.transitions.create('background-color', {
      duration: theme.transitions.duration.shortest,
    }),

When no easing is specified we are defaulting to 'cubic-bezier(0.4, 0, 0.2, 1)'. I'd say the proposed fix should be to always use theme's easing value, that way it would always be applied even if there are changes in the theme.
This should fix this specific scenario:
index 733e7ac2cf..bcc6ca16ae 100644
--- a/packages/material-ui/src/ListItem/ListItem.js
+++ b/packages/material-ui/src/ListItem/ListItem.js
@@ -63,6 +63,7 @@ export const styles = (theme) => ({
   button: {
     transition: theme.transitions.create('background-color', {
       duration: theme.transitions.duration.shortest,
+      easing: theme.transitions.easing.easeInOut,
     }),
     '&:hover': {
       textDecoration: 'none',

but we would need to apply it on all usages of theme.transitions.create. Also I'd propose we do the fix directly on v5, not sure if it is worthed to be backported to v4. cc @oliviertassinari

@mnajdova I don't get the same read on the issue as you do. For me, the root of the problem is the the theme.transitions.create doesn't take into account the default value of the theme, instead it's hard coded. I think that the solution is to replicate what the other subpart of the theme are doing. Basically, we have a factory, not a plain definition like
https://github.com/mui-org/material-ui/blob/a030b0e07e1354790790d9be1baa227044ce2d50/packages/material-ui/src/styles/createMuiTheme.js#L39

That's a good point. We can create createTransitions factory. It could look something like this:
import { easing, duration, getAutoHeightDuration } from './transitions';

function formatMs(milliseconds) {
  return `${Math.round(milliseconds)}ms`;
}

export default function createTransitions(inputTransitions) {
  const mergedEasing = {
    ...easing,
    ...inputTransitions.easing,
  };

  const mergedDuration = {
    ...duration,
    ...inputTransitions.duration,
  };

  const create = (props = ['all'], options = {}) => {
    const {
      duration: durationOption = mergedDuration.standard,
      easing: easingOption = mergedEasing.easeInOut,
      delay = 0,
      ...other
    } = options;

    if (process.env.NODE_ENV !== 'production') {
      const isString = (value) => typeof value === 'string';
      // IE11 support, replace with Number.isNaN
      // eslint-disable-next-line no-restricted-globals
      const isNumber = (value) => !isNaN(parseFloat(value));
      if (!isString(props) && !Array.isArray(props)) {
        console.error('Material-UI: Argument "props" must be a string or Array.');
      }

      if (!isNumber(durationOption) && !isString(durationOption)) {
        console.error(
          `Material-UI: Argument "duration" must be a number or a string but found ${durationOption}.`,
        );
      }

      if (!isString(easingOption)) {
        console.error('Material-UI: Argument "easing" must be a string.');
      }

      if (!isNumber(delay) && !isString(delay)) {
        console.error('Material-UI: Argument "delay" must be a number or a string.');
      }

      if (Object.keys(other).length !== 0) {
        console.error(`Material-UI: Unrecognized argument(s) [${Object.keys(other).join(',')}].`);
      }
    }

    return (Array.isArray(props) ? props : [props])
      .map(
        (animatedProp) =>
          `${animatedProp} ${
            typeof durationOption === 'string' ? durationOption : formatMs(durationOption)
          } ${easingOption} ${typeof delay === 'string' ? delay : formatMs(delay)}`,
      )
      .join(',');
  }

  return {
    easing: mergedEasing,
    duration: mergedDuration,
    getAutoHeightDuration,
    create,
  };
}

I've copied the create function from transitions.js and changed the default duration and easing to be from the merged values. We can remove the create function defined in transition.js after this change.

Hey, can I work on this?

@mnajdova  should I add the factory function and remove create from transition.js ?

remove create from transition.js

We should keep this one, this is unrelated.

@oliviertassinari  Alright, I'll start working on this. Thank you for your help!

@oliviertassinari  Do I also need to create the createTransitions.d.ts file along with createTransitions.js for type definitions?


Parameters dict from db_handler

@orelgueta , the function getModelParametersFromMongoDB is returning a dict with all the info for each parameter (Value, File, ...). Is this intentional? If so, the telescope_model has to be adapted because it is expecting only a simple dict with only the value of each parameter.

@orelgueta  another question: the site parameters (altitude etc) are not being returning after reading the DB. Shouldn't they be?

@orelgueta another question: the site parameters (altitude etc) are not being returning after reading the DB. Shouldn't they be?

I think this was working before because in the TelescopeModel the site parameters were being read from the yml files. I removed this part and it does not work anymore. How should we fix it?

The short answer to all questions is that the MongoDB interface is definitely not yet ready for production. It was merged to the master only due to a mistake in the Git pushes. For anything which is not pure development, I highly recommend to still use the yaml files.
I am currently modifying it to be a class anyway, so there will be many changes in the next commit.
Now, a bit more details:

the function getModelParametersFromMongoDB is returning a dict with all the info for each parameter (Value, File, ...). Is this intentional? If so, the telescope_model has to be adapted because it is expecting only a simple dict with only the value of each parameter.

Yes, this is intentional. We can write a function in the db_handler that simplifies that dict so that TelescopeModel will get a simple list of parameter/value, but I think it is better to do it outside of the db_handler. The db_handler should just provide a (semi-intelligent) interface to the DB itself.
The site parameters are not included in the DB yet at all. They are not tied to a specific telescope, so they need their own collection, under "Sites" or "Paranal" or something. Need to think about it a bit.
Perhaps the best option would be to implement a "getSiteParameters" function which is called once from TelescopeModel?

The short answer to all questions is that the MongoDB interface is definitely not yet ready for production. It was merged to the master only due to a mistake in the Git pushes. For anything which is not pure development, I highly recommend to still use the yaml files.
I am currently modifying it to be a class anyway, so there will be many changes in the next commit.

I understand, but at this point we should try to make it work somehow. I changed a lot many module to adapt for the new name scheme that only makes sense because of the DB.

Now, a bit more details:

the function getModelParametersFromMongoDB is returning a dict with all the info for each parameter (Value, File, ...). Is this intentional? If so, the telescope_model has to be adapted because it is expecting only a simple dict with only the value of each parameter.

Yes, this is intentional. We can write a function in the db_handler that simplifies that dict so that TelescopeModel will get a simple list of parameter/value, but I think it is better to do it outside of the db_handler. The db_handler should just provide a (semi-intelligent) interface to the DB itself.

I agree. It's not a problem at all, we just need to make it consistent with the dict from the ymal files.

The site parameters are not included in the DB yet at all. They are not tied to a specific telescope, so they need their own collection, under "Sites" or "Paranal" or something. Need to think about it a bit.
Perhaps the best option would be to implement a "getSiteParameters" function which is called once from TelescopeModel?

I agree.
By now I'll do an ugly hack on the TelescopeModel to add the site parameters and change the structure of the dict, so I can test my changes before PR-ing it. We should try to fix this soon though.

Sure, I am working on it now to make it usable. It's at the top of my to-do list.
I would wait a bit with a PR though, let's first also include the change to a class everywhere before you do a PR. It will probably be cleaner.

Well, I'm not sure about it. I did some changes on the db_handler that you might want to see before finishsing with your branch.
I'm almost done with mine, and will do the PR soon. I don't need to merge it soon after that.

Changes to the db_handler?? That's gonna hurt...
OK, we will see, probably will need some manual merging...

Small stuff only

OK, so I just committed the new class like db_handler. I will wait for your changes first, include them and then go over the rest of the code to make it compatible with the new class definition. After that we can include the sites parameters in the TelescopeModel and do a final merge.

Ok. I'm basically done with my branch but will do the PR tomorrow because I need to explain few things.

OK!

https://github.com/gammasim/gammasim-tools/blob/3a799d105a719bc53e3fb90b5b33c31ee567673f/simtools/model/telescope_model.py#L229-L234
Why should this be done in the db_handler? I am not sure I agree.
The next part about the site I agree (will include that in the next commit).

In case we decide that db_handler should provide a simple structured dict.
The other option is dealing with the more complicated dict at the telescope_model, which is also fine. I didn't do much thought before writing the warning message.

Can we close this one?

Why would we close it? First we have to make the decision and implement it, no?
My opinion is that TelescopeModel should receive the dict and use it everywhere (it can modify it if necessary).

That is already implemented, we just need to remove the warning. Can you do that in your DB branch?

Sure, I can do that. However, I thought the plan is to use the full dict from now on. Currently you are sort of "deleting" valuable information that comes from the DB.
I thought it shouldn't be too much work, since in most places you get a parameter value with getParameter, no?

Yes, right.
It's a bit of work actually. The TelescopeModel has to be changed in several parts.
I would prefer to do that in a separate PR and keep it as it is now.
And we could create another issue for that. This issue was meant for a easy solution to fix some bugs from pytest.

OK, no problem. Closing this for now then.


OS Dropdown should say 'Select an operating system' instead of 'Select an operationSystem'

OS Dropdown should say 'Select an operating system' instead of 'Select an operationSystem'

Good catch. The default of that widget is probably just reading whatever the name of the property is, so we should custom that text.

Yep. I'm happy to tackle it - I can't do it right this moment, so I filed it so I wouldn't forget.

Great thanks! It's probably in the list shortcuts view html.


docs: 0344-conventions-galore.md should use _

fixes #3618.
Rendered

@fmease are you open to this pull request?


transaction is not propagated to the network

Having trouble to send mined DOGE on testnet. Hope someone can help an old shibe?
Client 1.14
OS: macos
I'm initializing the client with: open -a Dogecoin-Qt --args -testnet -setgenerate true 2
then, debug console: generate
The mined coins do appear in the client and get credited after 241 confirmations but I'm having trouble sending them to another wallet.
Transaction Example:
Status: 144 confirmations
Date: 12.07.19 08:25
To: 2NFy8J5AhD6uQ6GfSiT48bQ46ona4oDSwJz
Debit: -100.00000000000 kDOGE
Transaction fee: -0.00200000000 kDOGE
Net amount: -100.00200000000 kDOGE
Transaction ID: 9f5fc8164827f8d88c7ef8faf1d0e025b22a3d24bddfd35886e73346727cce3d
Transaction total size: 1328 bytes
Output index: 1
The transaction does not appear in the blockchain despite having been confirmed 144 times.
What am I doing wrong?

Heres another example:
Status: 6 confirmations, broadcast through 4 nodes
Date: 12.07.19 14:54
To: nXNKKUTd169qKw5uNzbMfGiEhgiLcc6K4P
Debit: -50.00000000 DOGE
Transaction fee: -1.00000000 DOGE
Net amount: -51.00000000 DOGE
Transaction ID: 9ecafeecc8dc89948a33ea4728d55d6ed5f970abe2fc2aa5d943a6fcd5ca90f5
Transaction total size: 225 bytes
Output index: 0

How are you checking it's on the network? Specifically, if it's chain.so, it's because they need to upgrade their client, rather than your end.

Hi, yeah I was checking on chain.so. Didn’t know they are running an old client. Thanks for clarifying. Guess we need to update our client too since the coins didn’t reach my wallet either

I had exactly the same problem last night, which is how I know. It only affects their testnet client, so if you see it in production do let me know, but chasing them to upgrade now.


Emphasia's translation

Thanks again!

Presentation - Resources.zh.resx
Applications - Resources.zh.resx
did some minor changes after trying out the new version.

Thanks. I'll update it once I've time.

Update Chinese translation for TumblThree v<IP_ADDRESS>.zip

Thanks. I'll update with in the next release.

I've put both the source files and translation files here to avoid annoying you, or is it more convenient for you that I leave messages here every time there's an update?

No, it's perfect as it is. I like you own project containing all the translations, and I'll regularly update the main application. I just haven't had time to properly do it yet.
I'll also link to your translated readme in the TumblThree readme itself!
Thanks for all the continuous work. I really appreciate it.


[The Burning Wheel] Cannot switch tabs on character sheet

As of today (November 30th), the buttons on the top of the character sheet to switch tabs are no longer switching tabs. They were working fine the last time my group played on November 25th. We are all seeing this issue in Chrome, Firefox, Edge, and Safari.
If I manually change the value attribute of the input tag with class sheet-tabstoggle, the shown tab does change. And changes made to the sheet seem to still be synced across the network.
We can work around the issue for now by manually changing the value attribute, but it makes it very hard to play.

Found an issue for this in Seraaron's fork: https://github.com/Seraaron/roll20-character-sheets/issues/3

Roll20 Character Sheet Backend Changes where rolled out yesterday, are likely the cause of this issue. Seem my comment in the main thread for an full explanation.
The issue is identified, and a fix will be out later today, is what I was just told.

I'm not seeing this issue anymore as of today


P-UI: Add old dashboard page for now

This PR adds a simple page with the same info as the old dashboard. The tables are still missing as I am waiting for #5218

Closes #5324

At some point, we will have to add all the tables in/links to those pages.

At some point, we will have to add all the tables in/links to those pages. I added a line item into #5212 for tracking that.

Thanks @matmair


Storing video stream files

Hello,
We are considering using your distributed storage solution for storing CCTV video streams split into files. Not sure what the size is yet, but to minimize too many files (?), we thought the file size should be in GB.
Yes, we are comparing against other solutions such as HDFS, and GridFS.
What do you think you? Is SeaweedFS suitable for storing video streams?
The read access will be random because we plan to make a player that allows people to playback streams on-demand.

Memory management as in the amount of memory for my application or for SeaweedFS?

Each write is read as a whole block in the memory, before writing to disk. So it's better not to keep the blocks too large.


Update config.example.yml

why did you have to put your tokens in plain text?

OpenAI key is resolved. Telegram bot token doesn't matter


Responsibility ecological breakdown 1 4

Added first four charts of topic 8
Ordered each chart to their topic number to have an ordered structure in the divi menu

I was also thinking of ordering the charts within each topic as Huzaifa did in his website. What do you think @nanu-c ?

Deleted tooltip numbers in tenth and hundredth range  in responsibility_climate_world chart since it was showing two zeros on each region
This is the style of chart no. 4

I was also thinking of ordering the charts within each topic as Huzaifa did in his website. What do you think @nanu-c ?
In my opinion it's okey to have them sorted by category and name because the order how they gone be used in the text could change, too.


Define standard and implement prototype for async calls

Async calls are calls executed by a contract that have their execution continued in a subsequent transaction. A good example use case is contacting an oracle: a contract requires a piece of information from an oracle, so it files a request, to be fulfilled later by the oracle once the data is injected from a trusted party off-chain.
Evaluate other use cases, and help define a standard for such calls.

This idea came up during EthDenver, from a team building a bridge from ethereum to wolfram alpha


Just a suggestion (doesn't actually work!)

That's a good idea! 1 less required parameter as it's not a 'dependency' peer in the first place.
I presume 'end' event is only fired when all items are done processing and won't be fired when it is still recursing?

yeah, I was thinking only when it's finished recursing completely and all items have been dealt with. It could be useful, even if it's just logging that the process was finished or cleaning up resources or temporary data

Helpful.
The implementation looks like this now, as I'm going to have to return a function in the final chain. What do you think?
module.exports = dynamoDbBatch(
  'SCAN',
  { TableName: 'Music' }
)
.on('item', (item, event, context) => ...)
.on('end', console.log)
.handler()

I think that's pretty good, in some ways it's nice to be explicit with the handler call. However if you did want to be super fluent then functions are objects too, so I think you could add an on property to a function and return itself. e.g.
dynamoDbBatch = (args) => {
   const itemHandlers = []
   const endHandlers = []
   const batcchHandlers = []
   const handler = (event, context) => {
           .......
    }
    handler.on = (event, eventHandler) =>{
          //add event handler to appropriate array
          return handler
    }
    return handler
}

Thanks.
Don't think I understand what you mean by super fluent. How will the above implementation differ in term of usage?

I think I just understood what you meant! You were proposing on how I can eliminate the need of calling .handler(). That's quite creative. I guess it's down to:
module.exports.handler = dynamoDbBatchHandler(
  'SCAN',
  { TableName: 'Music' }
)
.on('item', (item, event, context) => ...)

or
module.exports.handler = dynamoDbBatch(
  'SCAN',
  { TableName: 'Music' }
)
.on('item', (item, event, context) => ...)
.handler()

Thinking out loud, I think I'll try to implement the first one as I'm not actually limited by the language's limitation. Most importantly, even though the second one is more explicit, the first one is a poka-yoke.

Thanks for the suggestion again, this is now done at bc6635633d290c22f15de0e17b5e094a8ab93cb8!


Fe: build from Github button

We should have something like a GH badge: https://github.com/Naereen/badges
Which when clicked will auto-load the target repository+directory combo for minting. That will require some webaverse.com Minter work to handle a query string in the URL.
Basically it would automate this minting process where you fill in the URL to mint with the .metaversefile, but starting from Github, and not requiring any additional clicks:

Another inspiration could be the "fork me on Github" badge.

"Mint me on Webaverse"

Still a good idea.


Correct a few bugs

Fixed a couple of usability issues. Also found some bugs in computing DVH plus dose metrics as well as converting data without forcing reconversion (force=False)

hi @dalmouiee, would you mind giving this PR a review. Just fixing a few things that have cropped up while using the pydicer tool :)


loading 3rd party vendor node modules with sub dependencies

Loading a single node module  is described within the wiki pretty well. Just being curious, how do I nicely load a more complex node module within a project bootstrapped with angular-cli?
E.g. angular2-apollo relies on several sub-dependencies like apollo-client, graphql, lodash, ...
I added the node module to angular-cli-build.js
var Angular2App = require('angular-cli/lib/broccoli/angular2-app');

module.exports = function(defaults) {
  return new Angular2App(defaults, {
    vendorNpmFiles: [
      '...',
      'angular2-apollo/**'
    ]
  });
};

And registered the node module ins system.js with
const barrels: string[] = [
  // ...
  // Thirdparty barrels.
  'rxjs',
  'angular2-apollo',

  // App specific barrels.
  // ...
];

// ...

// Apply the CLI SystemJS configuration.
System.config({
  map: {
    '@angular': 'vendor/@angular',
    'rxjs': 'vendor/rxjs',
    'angular2-apollo':'vendor/angular2-apollo/build/src',

    'main': 'main.js',
  },
  packages: cliSystemConfigPackages
});

However this is only loading angular2-apollo. The sub-dependencies of angular2-apollo are not getting loaded. How do I load subdependencies with system.js within angular-cli bootstraped project?
Wouldn't it be awesome having an ng helper registering and loading third party libraries?

This is an important issue- both in regards the documentation, but also for newcomers using angular-cli, like me. The first thing I tried to do with my new angular-cli project is use a commonjs module (which does not have typescript typings)
var myModule = require('some_mod'); //  exists in node_packages

That did not work, because the build system doesn't know about require(). I hit upon this after some searching.
declare function require(moduleName: string): any;

But that didn't solve it either- the require cannot resolve the path to node_modules.
The wiki article mentioned above helps, for small bits of code in vendorNpmFiles, but if it cannot discover commonjs module dependencies, I can't see how it would be useful at all in practice.
Now I am thinking I will have to replace the angular-cli provided build and bundle scripts with a webpack implementation.  Unless anyone else has pointers for how to accomplish the subject of this issue?

Currently, all subdependencies you need have to be declared for the build system to pick them up.
We are working on improving this, and there is an issue tracking it in https://github.com/angular/angular-cli/issues/882.
@guidorice try importing it via typescript: import * as some_mod from 'some_mod'.

until #882 will be solved, here is an example of a project with angular2-apollo, lodash and many more dependencies - (explanation and help in this SO answer - http://stackoverflow.com/a/38317093/1426570)


added migration guide

@Drakojin please add your content and additions to this branch

This change is

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage     91.67%   91.67%
  Complexity     1532     1532
=========================================
  Files           287      287
  Lines          3542     3542
  Branches        129      129
=========================================
  Hits           3247     3247
  Misses          231      231
  Partials         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b777e91...a8676d5. Read the comment docs.

@Drakojin thx, I'll merge the current version. That way we'll have a base guide ready. Any further additions should be done in separate pull requests.


mat: tracer for band types

Please take a look.  Similar to https://github.com/gonum/gonum/issues/938.

I believe all sorted


Error when using type as a parameter in graphql.

Error when using type as a parameter in graphql.
8 | graphql_schema_from_file!("./src/graphql/schema/schema.graphql");
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected identifier, found keyword

type User {
  accounts(type: String): [Account!]!
}

Maybe a bug with the graphql parser?

This was because of an old bug in juniper that didn't allow Rust keywords to be used in the schema. Its since been fixed in juniper and support in juniper-from-schema landed in #122.


docs(Layouts): make StickyLayout fully functional

Fixes #1994.
Requires #2016.

Codecov Report

Merging #2017 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2017      +/-   ##
==========================================
- Coverage   99.76%   99.76%   -0.01%
==========================================
  Files         148      148
  Lines        2561     2557       -4
==========================================
- Hits         2555     2551       -4
  Misses          6        6

Impacted Files
Coverage Δ

src/behaviors/Visibility/Visibility.js
100% <100%> (ø)
:arrow_up:

src/modules/Dropdown/Dropdown.js
100% <0%> (ø)
:arrow_up:

src/addons/TextArea/TextArea.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f39631...242651b. Read the comment docs.

Released in<EMAIL_ADDRESS>


Fix strict prototypes warning

Fixes -Wstrict-prototypes warnings, just like https://github.com/XboxDev/nxdk/pull/475. Related to https://github.com/XboxDev/nxdk/issues/468.

Very cool. I was going to fix this later today - you are just way too fast.
Another thing we could solve (warning wise) before updating the submodule after this, is:
nxdk/lib/pdclib/platform/xbox/functions/_PDCLIB/_PDCLIB_stdinit.c:30:47: warning: incompatible integer to pointer conversion initializing '_PDCLIB_fd_t' (aka 'void *') with an expression of type 'int' [-Wint-conversion]
static struct _PDCLIB_file_t _PDCLIB_serr = { 2, _PDCLIB_serr_buffer, BUFSIZ, 0, 0, { 0, 0 }, 0, _PDCLIB_serr_ungetbuf, _IONBF | _PDCLIB_FWRITE | _PDCLIB_STATIC,
                                              ^
nxdk/lib/pdclib/platform/xbox/functions/_PDCLIB/_PDCLIB_stdinit.c:35:47: warning: incompatible integer to pointer conversion initializing '_PDCLIB_fd_t' (aka 'void *') with an expression of type 'int' [-Wint-conversion]
static struct _PDCLIB_file_t _PDCLIB_sout = { 1, _PDCLIB_sout_buffer, BUFSIZ, 0, 0, { 0, 0 }, 0, _PDCLIB_sout_ungetbuf, _IOLBF | _PDCLIB_FWRITE | _PDCLIB_STATIC,
                                              ^

However, I probably won't do that as I'm building pdclib in a separate step. I mostly care about warnings in headers that get included in real applications (where they cause issues with -Werror).
I'll merge this later today, so you have some time to fix the nit (if you want to fix it).

That might be a bit more work to fix properly - PDCLib assumes that stdout, stdin and stderr are regular file descriptors, and this code, which comes from the example platform port, just assigns the POSIX file descriptors. We don't really have stdout, stdin or stderr (yet?).
I just decided to change the POSIX fds to INVALID_HANDLE_VALUE, not only to fix the warning, but also because someone might accidentally try to use e.g. stdout while having a file open that coincidentally has the handle 1, thus unintentionally corrupting the file.
I also put it in a separate commit to make it more visible, because it's not just a warning fix.

I just decided to change the POSIX fds to INVALID_HANDLE_VALUE, not only to fix the warning, but also because someone might accidentally try to use e.g. stdout while having a file open that coincidentally has the handle 1, thus unintentionally corrupting the file.

That is a very good idea and critical fix! Thanks.


Polish error handling and mapping

Problem
The error mapping done in ExoPlayerErrorMapper was wrong. the method receives a ExoPlaybackException extends Exception and immediately checks for it being an instance of particular exceptions. This is wrong as that check will always evaluate to false given that ExoPlaybackException is a wrapping exception.
In addition to that it would be good to have a fine granularity on the type of exception in the case it is unknown so client can elaborate better on error handling.
Finally we were prematurely invoking NoPlayer.ErrorListener.onPlalyerError for two potential errors. Media.onLoadError and Drm.onDrmSessionManagerError for client handling. According to the documentation we should only handle those cases for logging.
Solution
For the mapping we should instead check the type of ExoPlayerErrorMapper and elaborate accordingly.
For the premature invocations honor the documentation by just doing logging about that
Test(s) added
Yes, to ensure the ErrorMapper does the job as expected
Screenshots
No UI changes
Paired with
Nobody, but chatted a bit with @Mecharyry

:+1: sounds promising


saliency&(224,224)

Hello, author. I don't quite understand a few questions. I would appreciate it if you could give me an answer.
(1) Why is the size of saliency map set to 8 times that of feature map?
(2) Why is the image size fixed at (224,224)? Can it be any input size?

Hi, cherryolg.

Setting the size of saliency map to 8 times that of feature map is to control the dimension of saliency feature in SAMP module, so that the dimensions of saliency vector is comparable to the dimension of partition feature.
As mentioned in our paper, we set the image size as 224×224 following previous works.  In theory our method is suitable for arbitrary input resolutions, but some parts of this code (e.g., SAMP module) may require minor modifications to keep the dimensions consistent and then the model should be retrained.


Thresholding distance for each identity verfication

Hi, I am replicating the face verification part and use my own dataset to test. But the size of testing dataset is small so that I cannot draw ROC curve. Is there any other methods to determine thresholding distance? I set the unified threshold value manually for all identities but the performance is not good. Can I set threshold for each identity to get better performance?

For me, I set the distance threshold as 0.5

Hi @paleve, is 0.5 is enough for your dataset is there any false positive predictions?


docs: describe why we did not release CRD v1 yet

:tada: This PR is included in version 0.18.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Hardware reserved memory [ Not fixable using Bios ] after version 2004

Describe the bug
in previews windows versions i would set up vram in the bios and that's it im good to go all my ram is then usable by windows. But that wasn't the case after i have installed version 2004 20h1 since then windows started taking up 2gb of my ram as Hardware reserved and even if change Bios, its just a matter of a reboot so that windows takes back the 2gb of ram somehow its really buggin me since im very limited in terms of hardware resources and i like to make use of what i got, can't have windows yoinking ram like that, i don't play games and even if did i don't want to have system ram dedicated for the igpu
Screenshots

Desktop (please complete the following information):

OS: Windows 10, version 2004 (

@0xAssault Please ask product support or in support forums.
#please-close


nixos/nextcloud: document adminpassFile permissions

Motivation for this change
The required permissions are non-obvious without having a look at the implementation.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Instead of this we consider fixing this instead via LoadCredential.

Instead of this we consider fixing this instead via LoadCredential.

Is anyone interested in looking into LoadCredential?

Is anyone interested in looking into LoadCredential?

LoadCredential sounds good to me. I'll have a look into that.

LoadCredential sounds good to me. I'll have a look into that.

I think that's fine. Rather than waiting for a perfect fix, documenting this is fine for now so that people are warned.

Ported to stable as 7f1d27f333f2b7d4687505954bae2df01d483f2c.


[Backport]Don't discard navigations.

The webview should exist, and the check here dates back to cl/4512195 and cl/4490537 in 2007. There isn't much of a good rationale for it, and we're trying to eliminate dropped navigations, as they make things hard to reason about.
BUG=none
TEST=no changes
Review URL: https://codereview.chromium.org/1179003003
Cr-Commit-Position: refs/heads/master@{#334901}
(cherry picked from commit 0cc28d23f903b48c9f0c0f00c67dd5e1adf5c9e1)
BUG=XWALK-4378

@rakuco  @halton @lincsoon @kenchris @darktears

@axinging Thanks for the backport, you need add [Backport] prefix so that we can remove it in next rebase cycle. And could you explain how critical w/o this backport? Is there any XWALK bug reported?

@halton  BUG=XWALK-4378. Please check the comment

LGTM

LGTM

Please remember to roll DEPS.xwalk.


Bottom Bar

I cannot find the option after recent update to remove bottom bar. The option in Browser menu has been unticked yet I cannot seem to remove it from Alarm or browser screen. Has this feature been removed in recent update.

We no longer have a bottom bar on the browser views. The alarm view always has a bottom bar, it was never removable.

Here is a picture of the bottom bar that I cannot remove

The setting is still under the dashboards tab and will be functional in the next release.


Typescript Bug Requesting Uint8Array on Publishing Message but will result in error and still needs Buffer

Is this a client library issue or a product issue?
Client Library

Did someone already solve this?
no

Do you have a support contract?
No

Environment details

OS:
Node.js version:
npm version:
@google-cloud/pubsub version: 4.8.0

Steps to reproduce

Use typescript version 5.6.3

Notice that for the pubSubClient.publishMessage method it asks for a Uint8Array and says that a buffer is not assignable to type Uint8Array or string or blah blah.

Convert the buffer to a Uint8Array and process.

Notice that an error will be thrown with the error message "TypeError: Data must be in the form of a Buffer."

Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

I saw this and forgot to comment. There's another issue that covers this:
https://github.com/googleapis/nodejs-pubsub/issues/1707
I'll link this one and close.


refactor: Remove RPC_LOADING/withoutLoading

BREAKING:
Observables do not emit the symbol RPC_LOADING anymore. They will
only emit once a value is available. The operator withoutLoading
has been removed as this is now the default behaviour.
closes https://github.com/paritytech/js-libs/issues/154

I will update Fether to use the new version of js-libs with this PR https://github.com/paritytech/fether/issues/204 (which will require some new features on js-libs)


Configuration: 'identityClass' property of User component cause migration error.

What steps will reproduce the problem?
I set the identityClass property in the common/config.php
Run vagrant destroy then vagrant up commands which will rerun the migration.
'user' => [
            'identityClass' => 'common\models\User',
        ]

What is the expected result?
The migration run without error.
The migration files are fine! Because when I remove the user component from the common/config.php it runs perfectly without any errors!
What do you get instead?
==> PHP-Yii-VM: Exception 'yii\base\InvalidConfigException' with message 'The configuration for the "user" component must contain a "class" element.'
==> PHP-Yii-VM:
==> PHP-Yii-VM: in /vagrant/app/vendor/yiisoft/yii2/di/ServiceLocator.php:202
==> PHP-Yii-VM:
==> PHP-Yii-VM: Stack trace:
==> PHP-Yii-VM: #0 /vagrant/app/vendor/yiisoft/yii2/di/ServiceLocator.php(258): yii\di\ServiceLocator->set('user', Array)
==> PHP-Yii-VM: #1 /vagrant/app/vendor/yiisoft/yii2/base/Component.php(169): yii\di\ServiceLocator->setComponents(Array)
==> PHP-Yii-VM: #2 /vagrant/app/vendor/yiisoft/yii2/BaseYii.php(521): yii\base\Component->__set('components', Array)
==> PHP-Yii-VM: #3 /vagrant/app/vendor/yiisoft/yii2/base/Object.php(105): yii\BaseYii::configure(Object(yii\console\Application), Array)
==> PHP-Yii-VM: #4 /vagrant/app/vendor/yiisoft/yii2/base/Application.php(206): yii\base\Object->__construct(Array)
==> PHP-Yii-VM: #5 /vagrant/app/vendor/yiisoft/yii2/console/Application.php(89): yii\base\Application->__construct(Array)
==> PHP-Yii-VM: #6 /vagrant/app/yii(26): yii\console\Application->__construct(Array)
==> PHP-Yii-VM: #7 {main}

However if I set the class property then I will not be able to use identityClass property. In runtime I will get the Setting unknown property: common\models\User::identityClass error. So this is the trap.
Why I set the identityClass because I have to reach properties of the User object.
Additional info

Q
A

Yii version
2.0.9

PHP version
7.0

Operating system
Ubuntu Server 16.04 (Vagrant box)

You are missing the class element from the configuration.
Even the error states it ;)

However if I set the class property then I will not be able to use identityClass property. In runtime I will get the Setting unknown property: common\models\User::identityClass error. So this is the trap.
Why I set the identityClass because I have to reach properties of the User object.

Yes I missing, but If add the class element, I will get the quoted error. So it seems the class and the identityClass element cannot use together! It does not make sense, because without the identityClass property I am not able to get some attribute of the user class: \Yii::$app->user->identity->someAttribute

The issue is that you're in the console environment when applying migration and no web user is available there. It is as it should be. In migrations you should never try to use models.

I did not use the 'user' model in the migration or in the console environment. So I do not get your explanation. My configuration is existing under common

I don't get it. What are you using to run migrations? Console migrate command?


0.17 Release?

Will this be packaged up anytime soon?

is the project abandoned?

:+1:
I could pull from master but I've been looking for the .17 release to get night mode compatibility on my soundbar.

#630 and #629 seem to indicate it should have been released in November.  Wonder whats up?

I wouldn't say that the project is abandoned, but I simply didn't have enough time to do a release - it wasn't high enough on my priority list. I'll try to do a review of the currently merged and opened pull request, and see if I can do a release soon.

I am also looking for the .17 release.  I'm not sure that I can pull it myself.  If you are able to get that released, many here would appreciate it.  Thank you.

@nlagaros no, the project is not abandoned, just got busy with real life. @stefankoegl I will try to coordinate the fall out from the new Sonos release and then we should do a bug fix release thereafter. If you have time, great, otherwise we will have to figure out to get me access to PyPI.

I appreciate your time on this.  I’m most interested in events_twisted (#602) getting merged into this release.
From: Kenneth Nielsen<EMAIL_ADDRESS>Reply-To: SoCo/SoCo<EMAIL_ADDRESS>Date: Monday, May 6, 2019 at 3:39 AM
To: SoCo/SoCo<EMAIL_ADDRESS>Cc: Nicholas Lagaros<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [SoCo/SoCo] 0.17 Release? (#652)
@nlagaroshttps://github.com/nlagaros no, the project is not abandoned, just got busy with real life. @stefankoeglhttps://github.com/stefankoegl I will try to coordinate the fall out from the new Sonos release and then we should do a bug fix release thereafter. If you have time, great, otherwise we will have to figure out to get me access to PyPI.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SoCo/SoCo/issues/652#issuecomment-489533073, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AALDAD2F2QWFDC5R75YA66TPT7OEJANCNFSM4GKUPQTQ.

@nlagaros I think, from a 5 sec glance at it, that #602 uses the two file approach to twisted events, which I think has received about as much feedback as it should. So I will have a look at that as well tonight.

@stefankoegl ok, so I actually got the credentials to make a release on PyPI, so I will make one when we have the necessary fixes for the 10.1 update.

I will try and make a release today.

Wooo! Awesome guys!  I completely understand real life though.  Thanks again for the support!
/lgtm

We have had a few releases since this. Closing.


Doesn't reset after flashing via JTAG-serial (Windows 11)

Observed in v3.0.0-rc.1 but probably was an issue earlier. Host: Windows 11
When flashing via JTAG-serial the target doesn't get reset. When using --monitor option CTRL-R resets the target just fine.
From skimming over the code, it seems that reset_after and reset_after_flash (the later used by CTRL-R) are quite different

Temporarily changing HardReset to what reset_after_flash does for JtagSerial like this
impl ResetStrategy for HardReset {
    fn reset(&self, serial_port: &mut Port) -> Result<(), Error> {
        debug!("Using HardReset reset strategy");

        // self.set_rts(serial_port, true)?;
        // sleep(Duration::from_millis(100));
        // self.set_rts(serial_port, false)?;

        self.set_dtr(serial_port, false)?;
        sleep(Duration::from_millis(100));
        self.set_rts(serial_port, true)?;
        self.set_dtr(serial_port, false)?;
        self.set_rts(serial_port, true)?;
        sleep(Duration::from_millis(100));
        self.set_rts(serial_port, false)?;

        Ok(())
    }
}

Fixes it for me - so we would need the PID and decide which way to reset

Or an even simpler solution:
❯ git diff
diff --git a/espflash/src/connection/mod.rs b/espflash/src/connection/mod.rs
index f0899eb..0fd54c5 100644
--- a/espflash/src/connection/mod.rs
+++ b/espflash/src/connection/mod.rs
@@ -257,6 +257,11 @@ impl Connection {
     // Reset the device taking into account the reset after argument
     pub fn reset_after(&mut self, is_stub: bool) -> Result<(), Error> {
         match self.after_operation {
+            ResetAfterOperation::HardReset
+                if self.get_usb_pid().unwrap_or_default() == USB_SERIAL_JTAG_PID =>
+            {
+                ClassicReset::new(false).reset(&mut self.serial)
+            }
             ResetAfterOperation::HardReset => HardReset.reset(&mut self.serial),
             ResetAfterOperation::NoReset => {
                 info!("Staying in bootloader");

Some more context regarding this issue, it seems to work fine on Linux. And we've already had a similar issue in the past, see: https://github.com/esp-rs/espflash/pull/157 and https://github.com/esp-rs/espflash/pull/153. At that point we introduced the reset sequence in reset_after_flash. We dont know where this came from, but its been working since then.
We tried using the same sequence for HardReset as esptool uses, but it does not solve the issue for @bjoernQ.