Fix report functionality

Something is a bit off with report functionality it doesn't look like the reason is being saved when viewed in the moderator's report section

This is another good one to check out as well @Mxchaeltrxn

The alreadyReported aspect doesn't work but otherwise it's fixed in latest master


Add missing USE_OPENMP and apple clang support

Hello,
In this pull-request the support for apple clang on mac os is addressed.
Current Behaviour
Currently compilation on MacOS fails due to missing include guards around #include <omp.h>.
Changes
I added these guards in order to make non openmp targets compile on mac os. I added one include in kaffpaE.cpp as it is required to have omp support. Furthermore, I adapted the CMakeLists.txt to find metis headers on Mac.
Best,
Henrik

Thank you @henrixapp !


Layers always synchronized twice

olcs.AbstractSynchronizer#synchronize is always called twice when a layer is added or removed: once by olcs.RasterSynchronizer and once by olcs.VectorSynchronizer

This is expected and necessary to allow creating a vector counterpart of a
raster layer:
all the synchronizers are called and they return non-null result when they
handled the conversion.
Note that at most one synchronizer will return a non-null result with the
default synchronizers but
it is not necessary.


Bugfix: modbus with sam0 uart fails

Interrupt driven uart on sam0 currently returns true when uart_irq_tx_ready is called even if tx interrupts are not yet enabled.
This is because per the datasheet the DRE bit is always set to 1 when the DATA register is empty. This causes drivers such as modbus_serial.c to corrupt received data since it checks both uart_irq_rx_ready then uart_irq_tx_ready in that order,.
RX data is read, loaded into the shared buffer, pointer incremented, then TX is called (even though it should not be at this moment) and data is sent out and the pointer is again incremented resulting in a uart buffer overrun and RX data corruption.

The compliance check is probably going to fail. So please fix those. It is going to complain about signed-off line, and possibly the commit message summary not being formatted correctly.


feat(core): kas-grants list

Resolves #332
Resolves #253

Blocked by https://github.com/opentdf/platform/pull/1478


per-gridcell heat wave indice calculations?

Addressing a Problem?
Hi there,
I'm enjoying using xclim's heat wave indices (heat_wave_index, heat_wave_frequency; heat_wave_max_length).  However, it seems like the current implementation only accepts a scalar value of the heat wave threshold (codified in a string, e.g. '25 degC').   In reality, many heatwaves are location dependent - for example, what would be considered a heat wave in Arctic Canada would be a mild day in southern Canada.  In other words, heat wave thresholds for gridded analyses are arguably best defined on a per-grid cell basis (e.g. 99th percentile of gridpoint summer temperatures or similar).  Is there a way to implement this in xclim, to update it to accept both scalar definition of a heatwave threshold, and also a gridded definition?
Thanks!
Jeremy
Potential Solution
No response
Additional context
No response
Contribution

[X] I would be willing/able to open a Pull Request to contribute this feature.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi Jeremy, as a suggestion, you could use warm_spell_duration_index (WSDI) which is based on percentiles. The 90th percentile is supposed to be used but in reality you can compute tasmax_per on any percentile.
Beware, until #1050 is merged the metadata might be wrong if you use percentile others than the 90th.

Indeed, this is something we discussed in the past, but the need was never strong enough for us to move.
I believe it would be relatively easy to modify the definition of the "Quantity" input kind to include DataArrays that have no time dimension. "relatively" in the sense that most indices would work with minimal modifications, will others might not.
One of the "problems" I foresee is the metadata formatting. Accepting those new PercentileDataArrays required tuning the attribute machinery and so will this proposed change.  For example, using heat_wave_frequency, the current description is:
{freq} number of heat wave events over a given period. An event occurs when the minimum and maximum daily temperature both exceeds specific thresholds : (Tmin > {thresh_tasmin} and Tmax > {thresh_tasmax}) over a minimum number of days ({window}).

I'm unsure of how to rewrite this to catch all cases (fixed and variable thresholds). I would be happy to hear suggestions!
(This string is formatted after the computation of the indice. thresh_tasmin and thresh_tasmax are given to the formatting function directly as passed to the indicator, but there could be some preprocessing added. )

I work at Météo-France for the French climate service DRIAS (http://www.drias-climat.fr) which provides climate indicators. We are working to change the chain of calculation of indicators and we would be very interested in the implementation of this type of indicator.
Currently we propose the following indicators:

Number of unusually hot days (maximum temperature more than 5°C above normal)
Number of unusually hot nights (minimum temperature more than 5°C above normal)
Number of unusually cold days (minimum temperature more than 5°C below normal)
It is hoped that these developments can be incorporated
Thanks
Flore

@aulemahal

One of the "problems" I foresee is the metadata formatting. Accepting those new PercentileDataArrays required tuning the attribute machinery and so will this proposed change. For example, using heat_wave_frequency, the current description is [...]:

Would it help to render the description as a jinja template ?
We could then do something like:
description = "
{{freq}} number of heat wave events over a given period.
An event occurs when the minimum and maximum daily temperature both exceeds specific thresholds :
{% if np.isscalar(thresh_tasmin) and np.isscalar(thresh_tasmax) %}
   (Tmin > {{thresh_tasmin}} and Tmax > {{thresh_tasmax}})
{% else %}
   (Tmin > per_gridcell_tmin_thresholds and Tmax > per_gridcell_tmax_thresholds) # Not sure how to phrase it
{% end if %}"

With jinja enabled, I think it could also be used to group together multiple indices that are very similar (e.g. tx90p, tg90p, tn90p) and help with https://github.com/Ouranosinc/xclim/issues/714 I guess.

Wow fancy! I like this jinja idea, better than my "callback" version.
On the other hand, this specific case could be simpler : it could all live in Indicator.format which would detect if the InputKind.QUANTITY input is a scalar or not. Simpler (no large breaking change), but stricter, as the string wouldn't be modifiable for different indicators.
Seeing the interest from many different places, I'm increasing priority on this and planning an implementation this summer.

I don't think adding jinja within Indicator.format would cause many breaking changes.
I made a small pr, limited to _temperature.py module, just to see how it would work: https://github.com/Ouranosinc/xclim/pull/1120


Treespan

This change is

#735  👈
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 81.69014% with 13 lines in your changes missing coverage. Please review.

Project coverage is 92.77%. Comparing base (b221a63) to head (7bc9d41).

Files
Patch %
Lines

crates/prover/src/core/pcs/mod.rs
0.00%
13 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #735      +/-   ##
==========================================
- Coverage   92.87%   92.77%   -0.10%
==========================================
  Files          82       83       +1
  Lines       10923    10954      +31
  Branches    10923    10954      +31
==========================================
+ Hits        10145    10163      +18
- Misses        684      697      +13
  Partials       94       94

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Define how access-management-frontend will be hosted

Description
We will need to decide how access-management-frontend is hosted.
There are two main approaches

Host it in access-management-backend
Host it to CDN

Hosting it with the backend makes it easier to do changes on backed/front without the risk of breaking production.
Hosting it in CDN requires a version strategy to make sure we are not pushing changes to production without backend being updated to handled them. It also increases risk
Additional Information
No response
Tasks
No response
Acceptance Criterias
No response

We will host in BFF


WIP: Nomad integration test

Based on https://github.com/thegreenwebfoundation/grid-intensity-exporter/pull/5

Closing in favor of #5


Cannot find levelup modules

When using this library with TypeScript the included node_modules directory does not play nice. By using non-relative require statements like var codec = require('levelup/lib/codec') the compiler gets confused between the level-sublevel node modules directory and my project's node modules directory which contains a version of levelup that does not contain certain lib files.
I recommend a fix for this by either removing the node_modules folder from the repo (recommended) or at least making the require paths relative. If I have time I may submit a pull request with this fix.

I recommend a fix for this by either removing the node_modules folder from the repo

There is no node_modules committed to git. A require statement like require('levelup/lib/codec') is perfectly valid in Node.js. This sounds like a bug in TypeScript.


Views from PostGIS getting including in schema.rb

Whereas #134 apparently fixed this for the case where postgis is installed into your app's main schema, it doesn't seem to have fixed it for when postgis is installed to its own schema (which I prefer to do for the same reason it's nice to keep vendor stuff in a vendor/ directory).
config/database.yml:
  ...
  adapter: postgis
  postgis_schema:            postgis # default is public
  schema_search_path: public,postgis

This bug is made possible because a postgis. prefix is included in the list returned by Scenic.database.views but not included in the list added to ignore_tables by activerecord-postgis-adapter.
An easy non-forking workaround would be to just add this to an initializer:
ActiveRecord::SchemaDumper.ignore_tables += ["postgis.geography_columns", "postgis.geometry_columns", "postgis.raster_columns", "postgis.raster_overviews"]

But it seems like one of these gems should handle this configuration automatically.
So... Which one should be changed? Whose responsibility is it? :smile:
It's not clear from http://guides.rubyonrails.org/configuring.html whether or not ignore_tables is expected to contain a schema. prefix (ActiveRecord::SchemaDumper#remove_prefix_and_suffix removes any table prefix like foo_ but does nothing about schema. prefixes), but it seems to work to include it, so...
Option 1: Fix in activerecord-postgis-adapter
One obvious place to put this would be in activerecord-postgis-adapter since it knows if it's using a different schema than the default and it could add the prefix there...
Couldn't just change PostGIS.initial_setup since it's called so early on...
[23, 32] in /home/tyler/code/ruby/geo/activerecord-postgis-adapter/activerecord-postgis-adapter/lib/active_record/connection_adapters/postgis_adapter.rb
   23: require "active_record/connection_adapters/postgis/setup"
   24: require "active_record/connection_adapters/postgis/oid/spatial"
   25: require "active_record/connection_adapters/postgis/create_connection"
   26: require "active_record/connection_adapters/postgis/postgis_database_tasks"
   27:
=> 28: ActiveRecord::ConnectionAdapters::PostGIS.initial_setup

but could probably find a better callback point and move that code there...
Option 2: Fix in scenic
It would be pretty easy to fix it in scenic too. Maybe something like:
    def dumpable_views_in_database
      @dumpable_views_in_database ||= Scenic.database.views.reject do |view|
        ignored?(view.name) or ignored?(view.name_without_schema)
      end
    end

Possible downside of that is that if you defined your own view, say, geography_columns, then it would be ignored. But that's already perhaps the expected behavior from https://github.com/rgeo/activerecord-postgis-adapter/pull/208 ...
Thoughts?
Other code for reference
Where postgis. prefix gets added by scenic
[21, 30] in /usr/local/bundle/gems/scenic-1.4.1/lib/scenic/schema_dumper.rb
   24:     def dumpable_views_in_database
   25:       byebug
=> 26:       @dumpable_views_in_database ||= Scenic.database.views.reject do |view|
   27:         ignored?(view.name)
   28:       end
   29:     end
(byebug) Scenic.database.views.map(&:name)
["postgis.geography_columns", "postgis.geometry_columns", "postgis.raster_columns", "postgis.raster_overviews", "users_search", ...]

[41, 50] in /usr/local/bundle/gems/scenic-1.4.1/lib/scenic/adapters/postgres/views.rb
   41:
   42:         def to_scenic_view(result)
   43:           namespace, viewname = result.values_at "namespace", "viewname"
   44:
   45:           if namespace != "public"
=> 46:             namespaced_viewname = "#{pg_identifier(namespace)}.#{pg_identifier(viewname)}"
   47:           else
   48:             namespaced_viewname = pg_identifier(viewname)
   49:           end
   50:
(byebug) "#{pg_identifier(namespace)}.#{pg_identifier(viewname)}"
"postgis.geography_columns"
(byebug) method(__callee__)
#<Method: Scenic::Adapters::Postgres::Views#to_scenic_view>

Same issue here.
For the temporary workaround I also have this view: postgis.spatial_ref_sys
ActiveRecord::SchemaDumper.ignore_tables += [
   'postgis.geography_columns',
   'postgis.geometry_columns',
   'postgis.spatial_ref_sys',
   'postgis.raster_columns',
   'postgis.raster_overviews'
]```

I think @syntaxTerr0r's solution is sufficient for this from scenic's perspective.  As I understand the problem (which isn't fully), the fix for this should go in activerecord-postgis-adapter


feat(notification): Fixed link in notification model

Please Review:
@lsemesky
@mleeBoeing
@blynch11p

:+1:


Behavior for empty environment variables

In most programs, empty environment variable value results in a behavior as it was not defined.
In AWS CLI, defining an empty AWS_PROFILE environment variable results in the exception: botocore.exceptions.ProfileNotFound: The config profile () could not be found.
Botocore searches for a profile equal to an empty string.
To my opinion it should have the same behavior as AWS_PROFILE would not have been defined: using the [default] profile.

botocore.__version__ = '1.5.75'
OS: GNU/Linux

Thanks for your patience on this issue. I brought this up with the team and commented here on the related PR. As mentioned there, changes regarding environment variables now must be considered at a cross-SDK level in order to help ensure more consistency. Please consider creating an issue in our cross-SDK repository (https://github.com/aws/aws-sdk) for further tracking if this is still something that is needed.


Create or edit a text plugin with CKEditor 4 or 5 fails on error 'value too long'

Describe the bug
When trying to create a new text plugin item or editing an existing one from a page
(either Draft or Published) it fails on an error
Exception Value: value too long for type character varying(16)
This happening with both CKEditor 4 and 5, but never with Tiptap. However whatever the
editor i define, create a text item from the Page creation wizard does not trigger this
error and content is correctly created.
Full traceback:
Here is the traceback that is the same for both CKEditor 4 and 5. See below the
With ... sections where i've added a paste of debugging pointers i've collected along
the defined settings for each editor i've tried.
Traceback (most recent call last):
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/backends/utils.py", line 105, in _execute
    return self.cursor.execute(sql, params)

The above exception (value too long for type character varying(16)
) was the direct cause of the following exception:
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/utils/decorators.py", line 188, in _view_wrapper
    result = _process_exception(request, e)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/utils/decorators.py", line 186, in _view_wrapper
    response = view_func(request, *args, **kwargs)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/views/decorators/cache.py", line 80, in _view_wrapper
    response = view_func(request, *args, **kwargs)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/contrib/admin/sites.py", line 240, in inner
    return view(request, *args, **kwargs)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/views/decorators/clickjacking.py", line 58, in _view_wrapper
    response = view_func(*args, **kwargs)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/cms/admin/placeholderadmin.py", line 610, in edit_plugin
    response = plugin_instance.change_view(request, str(plugin_id))
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/contrib/admin/options.py", line 1950, in change_view
    return self.changeform_view(request, object_id, form_url, extra_context)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/utils/decorators.py", line 48, in _wrapper
    return bound_method(*args, **kwargs)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/utils/decorators.py", line 188, in _view_wrapper
    result = _process_exception(request, e)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/utils/decorators.py", line 186, in _view_wrapper
    response = view_func(request, *args, **kwargs)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/contrib/admin/options.py", line 1806, in changeform_view
    return self._changeform_view(request, object_id, form_url, extra_context)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/contrib/admin/options.py", line 1857, in _changeform_view
    self.save_model(request, new_object, form, not add)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/djangocms_text/cms_plugins.py", line 716, in save_model
    super().save_model(request, obj, form, change)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/cms/plugin_base.py", line 476, in save_model
    self.saved_object = pl.add_plugin(obj)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/cms/models/placeholdermodel.py", line 543, in add_plugin
    instance.save()
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/djangocms_text/models.py", line 80, in save
    super().save(*args, **kwargs)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/models/base.py", line 822, in save
    self.save_base(
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/models/base.py", line 909, in save_base
    updated = self._save_table(
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/models/base.py", line 1040, in _save_table
    updated = self._do_update(
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/models/base.py", line 1105, in _do_update
    return filtered._update(values) > 0
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/models/query.py", line 1278, in _update
    return query.get_compiler(self.db).execute_sql(CURSOR)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/models/sql/compiler.py", line 1990, in execute_sql
    cursor = super().execute_sql(result_type)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/models/sql/compiler.py", line 1562, in execute_sql
    cursor.execute(sql, params)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/debug_toolbar/panels/sql/tracking.py", line 235, in execute
    return self._record(super().execute, sql, params)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/debug_toolbar/panels/sql/tracking.py", line 160, in _record
    return method(sql, params)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/backends/utils.py", line 122, in execute
    return super().execute(sql, params)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/backends/utils.py", line 79, in execute
    return self._execute_with_wrappers(
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/backends/utils.py", line 92, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/backends/utils.py", line 100, in _execute
    with self.db.wrap_database_errors:
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/utils.py", line 91, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/home/emencia/Projects/Apps/Cookies-dev/bireli/dist/uranus/.venv/lib/python3.10/site-packages/django/db/backends/utils.py", line 105, in _execute
    return self.cursor.execute(sql, params)

Exception Type: DataError at /admin/cms/placeholder/edit-plugin/4/
Exception Value: value too long for type character varying(16)

With CKEditor 4
With the following settings
INSTALLED_APPS.extend([
    "djangocms_text",
    "djangocms_text.contrib.text_ckeditor4",
])

TEXT_EDITOR = "djangocms_text.contrib.text_ckeditor4.ckeditor4"

Custom bug debugging pointers
🐛 Line 427: From editors.get_editor_config():
   └─ Line 435: TEXT_EDITOR: djangocms_text.contrib.text_ckeditor4.ckeditor4
   └─ Line 436: config: djangocms_text.contrib.text_ckeditor4.ckeditor4
   └─ Line 437: Entering condition for uncached config with dotted path
      └─ Line 440: config.rsplit: ckeditor4
      └─ Line 440: rte_config_instance: <djangocms_text.editors.RTEConfig object at 0x7fef552e61d0>
      └─ Line 442: rte_config_instance.name: djangocms_text.contrib.text_ckeditor4.ckeditor4

🐛 Line 77: AbstractText.save:
   └─ Line 78: self.rte: djangocms_text.contrib.text_ckeditor4.ckeditor4
   └─ Line 78: rte length: 47

With CKEditor 5
With the following settings
INSTALLED_APPS.extend([
    "djangocms_text",
    "djangocms_text_ckeditor5",
])

TEXT_EDITOR = "djangocms_text_ckeditor5.ckeditor5"

Custom bug debugging pointers
🐛 Line 427: From editors.get_editor_config():
   └─ Line 435: TEXT_EDITOR: djangocms_text_ckeditor5.ckeditor5
   └─ Line 436: config: djangocms_text_ckeditor5.ckeditor5
   └─ Line 437: Uncached config with dotted path
      └─ Line 440: config.rsplit: ckeditor5
      └─ Line 440: rte_config_instance: <djangocms_text.editors.RTEConfig object at 0x7f375c2ba140>
      └─ Line 442: rte_config_instance.name: djangocms_text_ckeditor5.ckeditor5

🐛 Line 77: AbstractText.save:
   └─ Line 78: self.rte: djangocms_text_ckeditor5.ckeditor5
   └─ Line 78: rte length: 34

With TipTap
With the following settings
INSTALLED_APPS.extend([
    "djangocms_text",
])

Custom bug debugging pointers
🐛 Line 427: From editors.get_editor_config():
   └─ Line 435: TEXT_EDITOR: tiptap
   └─ Line 436: config: tiptap

🐛 Line 77: AbstractText.save:
   └─ Line 78: self.rte: tiptap
   └─ Line 78: rte length: 6

Environment
Describe your environment:

Plateform: Linux distribution
Python version: 3.10.7
Django version: 5.0.10
DjangoCMS version: 4.1.4
djangocms-text version: 0.3.3, 0.4.0

Additional context
As seen from error and debug pointer the editor name for CKEditors is clearly too long
for the max size of the 'rte' field because they are the full Python module path,
opposed to TipTag that is just the tiptap name.
However i'm very confused because i did not seen this bug from the past two weeks i
worked with djangocms-text, did i miss a thing in my settings or something else ?
First i was still with djangocms-text v0.3.3 but then after i've updated to the v0.4.0
and the bug is still there with exactly the same behaviors.
Note that my bug debugging pointers pastes reference to the code line from the v0.3.3.

@sveetch Thanks, great catch! The integration test did check if the ckeditor4 started up, but did not check save. Not the whole path should go into the DB field, just the final editor name.


Force pull from defined origin to avoid ambiguity

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Force pull from defined origin to avoid ambiguity
Describe the solution you are proposing
Previously all the calls of fetch are using string like main in branch name, but 2.2 breaks it and cause the fetch to use float which somehow breaks Grgit. Force pulling of origin/2.2 fix the issue.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

BWC tests are failing with the following error,
Build file '/home/runner/work/performance-analyzer/performance-analyzer/tmp/performance-analyzer/build.gradle' line: 587

* What went wrong:
Could not determine the dependencies of task ':paBwcCluster#rollingUpgradeClusterTask'.
> No subject alternative DNS name matching ci.opensearch.org found.

We have fixed the issue on ci.opensearch.org and will try again.


FW failsafes during TAKEOFF/LANDING

I had a brief data link loss causing a switch to RTL during a fixed wing auto takeoff yesterday. It was quick and resumed the mission, but it could have caused a crash. Would it make sense to limit this failsafe when flying a SETPOINT_TYPE_TAKEOFF or SETPOINT_TYPE_LAND? At the very least during climbout for takeoff and flare for landing.

Not sure. It would have climbed like on a takeoff and loitered. That seems safer than any other approach?

Early in the takeoff (altitude_error > _parameters.climbout_diff) roll is constrained and I'm looking at also limiting pitch for larger planes before they reach min airspeed. With home directly behind the plane and in RTL wouldn't it just be a regular position without any special constraints? It's definitely an edge case, but maybe the right solution is adding in_takeoff_situation() logic to SETPOINT_TYPE_POSITION?


Removed full line from second last item of pipeline page cards(#25depf5)

Related Issues

Closes #
Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance

[ ] I read and followed contribution rules


Consensus protocol upgrade activation mechanism

This issue tracks the code changes needed to facilitate consensus protocol upgrades.
Signaling consensus protocol upgrade features
Consensus protocol upgrade changes are associated with a feature (called a "consensus protocol upgrade feature") recognized by nodeos. Each feature will have an associated 256-bit digest that uniquely identifies it. There are two classes of consensus protocol upgrade features: those that require pre-activation via an intrinsic and those that do not.
A consensus protocol upgrade feature is activated by signaling its activation in the block header through a new block header extension type called the "protocol feature activation" extension. This extension type (which will be discussed in more detail below), includes the 256-bit digests of consensus protocol upgrade features to be activated at the start of that block.
There are constraints on whether a consensus protocol upgrade feature (of either class) can be activated:

the nodeos software must be configured to recognize and accept the feature;
and, any dependencies of the feature must have already been activated.

Furthermore, a consensus protocol upgrade feature of the class that requires pre-activation has further requirements:

activation of the feature, signaled through the block header extension, is disallowed if the same feature has not already been pre-activated via an intrinsic;
any block building on a block that included pre-activation of a feature must signal activation of that feature in its block header extension otherwise it is an invalid block.

Most consensus protocol upgrade features will likely be of the type that require pre-activation. Consensus protocol upgrade features that do not require pre-activation have the characteristic that any one of the active block producers can initiate the activation of the feature. The other block producers could still ignore that block if they were not ready to accept activation of the feature, but that is a subjective producer policy decision that would have to be coded into the nodeos software that the block producer was running. One type of subjective policy decision that will be formalized as part of this mechanism, however, is to optionally reject activation of features if they occur before a locally specified time known as the "earliest allowed activation time".
Having a type of consensus protocol upgrade feature that requires pre-activation allows the subjective policy decision by each producer to be replaced by an objective policy that runs on the blockchain. A system contract action with strict authorization requirements can use a special intrinsic to pre-activate the feature; and block producers can use, for example, the eosio.msig contract to satisfy the authority of that system contract action.
However, there is still an important use case for consensus protocol upgrade features that do not require pre-activation. For example, if the community needs to execute a consensus protocol upgrade to change the producer schedule in a situation in which all producers are down and for some reason will not be coming back up, it should be possible for nodes that understand that consensus protocol upgrade feature to accept a block produced by a producer outside of the current producer schedule as long as the block activates the feature and the producer is the appropriately scheduled producer for the given time slot under the new producer schedule. It would not be possible to pre-activate such a consensus protocol upgrade feature in the scenario when all producers are down since no blocks would be produced to execute the action that calls the pre-activation intrinsic.
"Protocol feature activation" block header extension type
This new mechanism also introduces a "protocol feature activation" extension type within block header extensions.
Currently, no extensions are allowed in the block header. This change would allow a single block extension as long as it follows the rules of a well-formed "protocol feature activation".
For a "protocol feature activation" extension to be well-formed it must have a uint16_t type value of 0 and its payload data must be the serialization of a vector of distinct 256-bit digests (the digests do not need to be in any particular order, but they must not repeat).
If further extension types are added in the future, the following constraints should still apply: at most one well-formed "protocol feature activation" extension is allowed in the vector of block extensions, and if a "protocol feature activation" extension is present, it should be the first item in the vector of extensions.
Note that the "activation set" will actually be stored in the block_header_state rather than in the ChainBase database. Changing the definition of block_header_state means that a new chain_snapshot_header version is necessary (e.g. version 2).
Pre-activating consensus protocol upgrade features
Some consensus protocol upgrade features will require pre-activation and some will not. Either way, it is possible to pre-activate a feature assuming the following conditions hold:

the nodeos software must be configured to recognize and accept the feature;
the associated 256-bit digest is not already in the "pre-activation sequence" (a sequence of 256-bit digests stored in the ChainBase database, likely in the global_property_object) nor in the "activation set";
and, the 256-bit digests of any dependencies of the feature must already exist in the union of the "activation set" and the set comprised of elements in the "pre-activation sequence".

If a feature is successfully pre-activated (this would be initiated by a special privileged intrinsic), then its associated 256-bit digest is added to the end of the "pre-activation sequence".
Activating consensus protocol upgrade features
When computing the next block_header_state, if the block header has one well-formed "protocol feature activation", the computation should start with an empty "pending activation set" and then go (in order) through the sequence of 256-bit digests deserialized from the payload data of the "protocol feature activation" extension, and for each do the following sequence of operations:

If nodeos software is not configured to recognize the digest as that of a valid consensus protocol upgrade feature it accepts, then reject the block.
If the pending block time is earlier than the "earliest allowed activation time" of the feature, reject the block.
If the digest already exists in the "activation set" (or also in the "pending activation set" if sequence of digests has not already been vetted to not have repeats), reject the block.
The 256-bit digests of any dependencies of the feature must all already exist in the union of the "activation set" and "pending activation set"; otherwise reject the block.
Add the digest to the "pending activation set".

If this is computing the next block_header_state within the fork database, it should also then merge the "pending activation set" into the "activation set" of the newly created block_header_state. However, the merge should not occur if this a pending block_header_state generated within the start_block function.
At the start of a block, prior to executing the onblock transaction, if a non-empty vector of feature digests is provided to the start_block function, then the controller logic must first ensure the above 5 steps have already occurred and then it must go (in order) through the sequence of 256-bit digests in this provided vector, and for each do the following sequence of operations:

If the digest is of a feature of the class that requires pre-activation, assert that the digest is in the "pre-activation sequence" (reject the block if the assertion fails).
Run the trigger function (if one exists) for the feature associated with the digest. If the trigger function fails, reject the block (and make sure any state changes done in the trigger functions are reverted).
Add the digest to the "activation set" of the pending block_header_state.
If the digest exists in the "pre-activation sequence", remove the digest from the "pre-activation sequence" and shift any remaining items in the sequence accordingly.

Regardless of what vector was passed into the start_block function, after the above, assert that the "pre-activation sequence" is empty. If the assertion fails, any state changes that may have been done since the start of the block should be undone and the block should be rejected.
The producer plugin would need to be modified to pass a vector of feature digests consisting of at least the digests (in order) of the "pre-activation sequence", otherwise it would not be able to start a new block after pre-activation of a feature. However, the producer plugin would be free to add additional digests of consensus protocol upgrade features to the beginning of this vector in order to activate consensus protocol upgrade features that do not require pre-activation and that were not already pre-activated. The set of digests to add would be determined from RPC calls made through the producer_api_plugin.
Checking if a feature is activated
An internal function is necessary to check if a particular feature (identified by digest) is in the "activation set". This function is mostly intended to be used by the native blockchain logic to adjust behavior according to whether a particular consensus protocol upgrade feature has been activated or not. It would also be used to implement a new intrinsic which allows contracts to query whether a feature has been activated or not.

Resolved by #6831.


Allow arbitrary options to be passed to model.save by client

Small change to allow additional options to be passed to backbone's model.save method.  This would allow, e.g. passing success/failure callbacks so that code can be executed after save successfully completes.

@abelnation - this won't do anything - the problem is that we override the actual sync method, and we never call the success/fail callbacks because we are using comms, which don't give a response to requests. See, for example, the comment at https://github.com/ipython/ipywidgets/blob/master/jupyter-js-widgets/src/widget.ts#L362.
We use some of the backbone infrastructure, but we've really customized backbone a lot, so much that sometimes it's not really recognizable as backbone anymore. I think eventually we'll just finish the job and eliminate our dependency on backbone.

(I almost did this exact thing today when trying to help fix #833, but then I realized it wouldn't do anything anyway for the above reasons.)
Thanks for the suggestion. I'm going to close this for now, since it would involve a lot more work to have these success/fail callbacks work.


Add grant test and differentiate by account type.

I added a test, but when I ran make test and intentionally broke the test, it still passed. Is there some flag I need to pass to it to make it execute all tests or fail on any that are broken?
Thanks!

thanks @justinrmiller


Header integration version 3.+

What:
Add latest version of the header to the page
Why:
As a part of the effort needed to unify the navigation experience
How:
Use latest published version of the component
Media:
https://www.loom.com/share/bca7b98bf25b4550885686134ada25c0

Thanks @thiagodemellobueno for this first round of testing.
I will take a look to the links. Other than that, there is nothing we can currently do to allow the member login to work on preview because we don't know the url that netlify will generate. It is clear that technical limitation or should I explain more?

02ef648 has the fix for the issue with external links.
Let me know if you find something else @thiagodemellobueno

@duranmla - I don't expect member login to work, but i do expect it to generate a valid URL no?

@duranmla  - aaah, i see - lets go ahead and merge it then.
And test on dev.

Although, I think there is no staging for the homepage.
Or I am missing some urls?

You are likely to know better than I.
In my understanding we just have
the netlify preview branches and:
development.debtcollective.org
then merge right to master for "production."
Normally i'd say we dont 'need a specific staging` cause netlify.
But we have so many integrations (like the stuff in packages) and interdecpendencies that we've seen the consequence of how it affects our ability to test everything together.


Appstudio update test-component-pac-bpgb

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-bpgb-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
appstudio-init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
8 seconds
appstudio-configure-build

✅ Succeeded
33 seconds
build-container

✅ Succeeded
7 seconds
show-summary


chore(main): release 1.1.0

:robot: I have created a release beep boop
1.1.0 (2024-04-27)
Features

add fish theme (#18) (19693ee)

Bug Fixes

change wezterm cursor_fg (#19) (75966c7)
use non-conflicting hl for quickfix list (d400d3f), closes #17

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/scottmckendry/cyberdream.nvim/releases/tag/v1.1.0 :sunflower:


Fix parsing of non-latin characters

By far mercury parser escapes non-latin characters into html entities because of a bug of cheerio. Followed by mercury's character encoding/decoding processing, non-latin chars become a mess.

Thank you for the pull request. Sorry, I am just noticing this now. Do you have a test case where parsing of non-latin characters was not working properly?

This is only triggered when we prefetch web content. For instance:
import Mercury from "@postlight/mercury-parser"

Mercury.parse("http://example.com", "

 美國增至超過84萬人確診新型肺炎，46000多人死亡。有衛生官員證實，兩名在2月死亡的病人，曾經感染新型肺炎，比當局早前認定的第一宗死亡個案更早出現，意味美國的死亡病例，可能比官方數字更多。

");

When fetching by Mercury there is no problem because cheerio recieves byte code, while prefetched content is a decoded string.

Oh, I understand now. Thank you. Can you exclude the yarn-error.log and README.md changes from the pull request?


CI should run +test

...and fail when FAILED or CRASHED gets seen in output.
This will get more useful as we get more tests, but we already have some so why not put them to good use?

They take two minutes to run(a third of that is compiling everything, which afaict ignores the filter), so if this is "barely any tests" I hope there's a plan for them not taking forever :P

Due to /_ semantics, test files that don't compile are currently ignored entirely. This is currently caught by my compile-everything test, but something to keep in mind if those ever get integrated.

...which is already files as #655, right


RuntimeError: Unable to open shape_predictor_68_face_landmarks.dat

So, I have cloned the repository. I have downloaded the shape_predictor_68_face_landmarks.dat
I have changed the path to the file, but I get this error. I really can't understand why.

你路径错了 或者是文件名字错了


Modernise several uses of GetSortedLanes() batch 2

Another batch.

Add new CountLanes() extension

There were several places where GetSortedLanes() was being used just to count lanes so created an extension which does that more optimally

Modernise several GetSortedLanes() call sites

bump

Added guard against null segment Info and Info.m_lanes based on similar guards in vanilla CSL code.

Oh sorry I forgot to look at this.
We should generally use GetSegmentLaneIndexesAndIds() to avoid such mistakes. but that is out of scope of this PR

@kianzarrin that's tracked in https://github.com/CitiesSkylinesMods/TMPE/issues/1489


Add query that lists SAML external identities for an Organization

Business Plan hosted customers with SAML would like a way to programmatically query information about a GitHub user account's SAML identity. The following is a GraphQL query that accomplishes this for an Organization.

[ ] Determine whether this is a standalone example for useful Business Plan hosted (SAML) queries or added under https://github.com/github/platform-samples/tree/master/graphql/queries

query {
  organization(login: "LOGIN") {
    samlIdentityProvider {
      ssoUrl
      externalIdentities(first: 100) {
        edges {
          node {
            guid
            samlIdentity {
              nameId
            }
            user {
              login
            }
          }
        }
      }
    }
  }
}

/cc @francisfuzz as you might be able to track down the author to see if they want to add this ☝

Is there any movement on this?
Also, do you know whether permissions or anything have changed in order for this to pull results?
In the past, your query above has worked, but it's now returning the following for me:
{"data": {"organization": {"samlIdentityProvider": null}}}
Let me know if I need to open a ticket or PM you, rather than posting here.

This query was super helpful for us as we're primarily using v3 and couldn't see a way to do this there. I found the token needs admin:org though which feels excessive for a read only query.

This query was also super helpful for us - v3 provides their SCIM endpoint (https://developer.github.com/v3/scim/) which gets us close, but does not provide a true way to tie a GitHub identity to a SAML identity.
Using this query in v4 we are able to pull our user's verified domain email addresses and associate it to their github handle, making our notification process a lot easier.

@AjkayAlan, I'm testing on the same where the email address for SAML authentication is different from github registered email address, can you please share us the query to trigger in GraphQL

@kamaltejaaol Unfortunately my org policy does not allow me to share code easily, specifically code I developed for our organization.
What we ended up doing was using the query provided by @osowskit above to get the SAML nameId, which corresponded to our user's primary email address associated to their enterprise account (the same address we would send emails on). Additionally, the query above gets you the user login, which is the actual github login of the associated user.
From there, you can just make a key value pair list of github login to enterprise email address. Once you have that, you should be off to the races.
In our case, we had to revoke PAT and SSH keys over a specified age limit using the credential authorizations API (https://developer.github.com/v3/orgs/#list-credential-authorizations-for-an-organization). That returns the github login, which we then look up against the list of login/email kvp's. From there, we were able to notify the users in advance that they needed to rotate their credentials to avoid disruption.

@AjkayAlan, i understand the corporate security policies, but thanks for giving the detailed explanation, i will try to work it out. Thanks again.

Hi, @osowskit
Thanks for this solution, really saved my day, however I am getting null with this query, not sure what I am missing here possibly? I have correct scope for the token and header stuff.
below is the return.
{
"data": {
"organization": {
"samlIdentityProvider": null
}
}
}

@swinton @mtodd ☝

Thanks @osowskit .
@swinton @mtodd , still stuck on it, any help will be highly appreciated.

Just did a bit more research on the issue, could it be related to SCIM is not enabled?

I am experiencing the same {"data":{"organization":{"samlIdentityProvider":null}}} issue making requests with both

a PAT with admin:org and admin:enterprise permissions
as well as a Github App with fairly substantial permissions

So I'm wondering:

My account is an org owner, but (I believe) only an enterprise member. Could this be the source of the issue?
If it is, shouldn't at least enterprise.ownerInfo.samlIdentityProvider throw an error?
More generally, what are the constraints and necessary permissions for this API?
What are its the supported consumers, and do they have varied constraints?
Are there known gotchas and caveats such as what @gracevivi523 proposed?

Also, this query has been added to the examples.

What I've learned since the above:

is that when enterprise saml identity mapping is on, organization.samlIdentityProvider is not a view into the enterprise identity mapping, and there is no way to configure it as such
enterprise saml identities can only be queried by enterprise owners

https://gist.github.com/gbaman/b3137e18c739e0cf98539bf4ec4366ad ... these details helped me to develop python code to get the saml identify value and generate report

For anyone interested in how to adapt the original query from the first comment to support pagination, after some playing around and reading the docs (I'm not too familiar with GraphQL, so this wasn't obvious to me), I got this (example below using the GitHub CLI, see also here):
gh api graphql --paginate -f query='
query($endCursor: String) {
  organization(login: "<name-of-org>") {
    samlIdentityProvider {
      ssoUrl,
      externalIdentities(first: 100, after: $endCursor) {
        edges {
          node {
            guid,
            samlIdentity {
              nameId
            }
            user {
              login
            }
          }
        }
        pageInfo{
          hasNextPage,
          endCursor
        }
      }
    }
  }
}
'

for anyone who comes here looking for a way to find the organisational email for a particular user, it is:
query {
  user(login: "SOME-USER"){
    organizationVerifiedDomainEmails(login: "SOME-ORG")
  }
}

Is there no way to get this information with a REST API endpoint?

Thanks all - this helped me out.
For anyone working with c# who gets here, here's a gist https://gist.github.com/dylan-asos/091f2b8e6a865538f061f7554fc03566 - give it an email, it'll give you the matching username/login.
I'm being overly verbose to show some of the moving parts, you could switch out some of that with parsing libs of your choice.

I'm trying this but we have SAML enabled at Enterprise level and when we try these or similar queries I get this:
The Organization's SAML identity provider is disabled when an Enterprise SAML identity provider is available.
I can't find any similar option to get this information at the enterprise level. Any ideas on how to get that info?

@EdEastman see my comment above

Gah, sorry, now I'm the guy that didn't read the thread :( oh well hopefully at least that error message will be indexed now...many thanks @barakwei - that works perfectly

for anyone who comes here looking for a way to find the organisational email for a particular user, it is:
query {
  user(login: "SOME-USER"){
    organizationVerifiedDomainEmails(login: "SOME-ORG")
  }
}

Thanks ,Here is the query with variables
query($user: String!, $org:String!) {
user(login: $user){
organizationVerifiedDomainEmails(login: $org)
}
}
{
"user": "SOME-USER",
"org": "SOME-ORG"
}

Hello,
With enterprise-level SAML I get "ownerInfo": null for the following query:
{
  enterprise(slug: "Your enterprise here") {
    ownerInfo {
      samlIdentityProvider {
        id
      }
    }
}

I still can see the sso email through web interface though.
Please help

All you need is read scope permissions now. https://github.blog/changelog/2023-03-30-samlidentity-graphql-object-now-supports-read-scope/


Readme

It would be good if the README explained how to get this application running and anything one might need to know.

This was addressed by this commit https://github.com/alphagov/business-support-finder/commit/aaa8cd29fea099001775844a7411450f017e8dda


Avoid parameter leak when falling back to wildcard route

A wilcard route can currently catch a parameter found in a previous partial match.
Example:
--> /users/{id}/books
--> /use*

As the routing system does not evaluate all its potential routes, this bug seems not reproductible yet.
When the rework of the routing system is done, try to test this case:
    test "Parameters do not leak when falling back to wildcard route":
            var tree = Tree[string].new()
            tree.insert("/{api_version}/login/", "Logged In")
            tree.insert("/users/{id}/books/{title}", "I like this book")

            let result = tree.retrieve("/users/10/books/harry-potter").get()
            check(result.value == "I like this book")
            check(result.parameters.get("id") == "10")
            check(result.parameters.get("title") == "users") # But it should be "harry-potter"

The bugs exposed by the previous snippets are not reproductible anymore. Still, I am not convinced that the routing system is leak proof.
To be continued...


ghprbPullLongDescription breaks if there are emoji in long description

When building from a PR with a green heart emoji 💚in the long description, this exception is generated:
net.rubygrapefruit.platform.NativeException: Could not set the value of environment variable 'ghprbPullLongDescription': could not convert string to current locale

Removing the emoji works around the problem

+1 same with 👌🏻

+1 my cz titles with emojis breaks the build :(

+1

+1

+1

😭 This one, too

me too


Improve clarity of 1. Your budget and expectations screen

[ ] It is unclear to the players what values are constant every round: The facilitator can explain that aspect by adding an * to the applicable values and a note below.

I do not think it is wise to hard-code this. Future versions of the game could have changes in these values as a result of news measures (e.g., increased living costs). Therefore, I would not like to change this. Also, the (*) gives extra clutter on the screen.


Middleware does not work on the client on the first load - v0.10.5

For example,
export default function (context) {
console.log(context.isClient)
}
All subsequent route changes are executed, but not the first load. This bug invalidates the use of middleware on the client side.

This is normal because the first load is on the server side, so the middleware is called from the server-side. We don't run again the middleware on the client, we simply hydrate the DOM.

And why don't you run middleware on the client? You could have some code you want to run on the client. Like modernizr, for example. With modernizr it is not clear where to put it.

modernizr you can write a plugin .
but , if you want modernizr  or else run under ie9 before plugin
( I tried if use ie8 , you will get error before plugin )
you need put it to nuxt.config.js head.script ( but have escape issue )
maybe you should put it in app.html ( template )
https://github.com/nuxt/nuxt.js/issues/452
that I want run some code under ie9 or else browser .

What I thought of is that Middleware has an access to context and therefore it is convenient to use it and do for example redirect to a certain route. Anyways, for now, I implemented modernizr check on the server side and indeed I use middleware for that. Thanks.

I second being able to run middleware on the client.  My use case is authentication via feathers-vuex which is broken on the server, so I need to exchange a reset-token for an access-token on the client, but I'm unable to run the middleware on the client.

I would also like this feature.  It seems like the most logical place for me to place the redirect logic coming from my CMS.

same issue. I want to use the middleware to fetch data and redirect if I am unauthorized. Right now I have to do it in the  components created() method

Same issue here: #2186

I used $router.redirect inside of a try catch inside of the created callback.  $router.redirect throws an error on the server but it succeeds on the client.  Then redirect to another route where you actually do what you need to do.  It sucks having to create another route and it's fragile in that it depends on the server throwing an error on $router.redirect, but it's the only workaround I could figure out.

@Atinux @rhythnic @Jones-S @christophmayrhofer @MyMediaMagnet
Looks like the best way is making an init.js plugin (ssr:false) and doing the initialization logic there.
However, redirect() does not work(router.onReady(redirect) will change page but not layout). seems like this is fixed in nuxt-edge.


tests: add sysfs test case to increase code coverage numbers

changes:

add sysfs enum test cases to improve code coverage

Pull Request Test Coverage Report for Build 2108

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 47.447%

Totals

Change from base Build 2107:
0.6%

Covered Lines:
2007

Relevant Lines:
4230

💛  - Coveralls


fix: NSelect content inaccuracies

Description
slider -> select

sorry, dont see that this problem was solved in f2a59da3a3fd69feb3197e0b0926a981f28f89d5


feat: update to API P 2.7

Codecov Report

Merging #7 (6bc3d67) into main (d0cd393) will decrease coverage by 1.19%.
The diff coverage is 83.68%.

@@             Coverage Diff              @@
##               main       #7      +/-   ##
============================================
- Coverage     84.28%   83.09%   -1.20%
+ Complexity      306      290      -16
============================================
  Files            22       18       -4
  Lines           732      627     -105
============================================
- Hits            617      521      -96
+ Misses          115      106       -9

Impacted Files
Coverage Δ

...dge/ApiPlatform/Metadata/FilterMetadataFactory.php
0.00% <0.00%> (-100.00%)
:arrow_down:

src/Bridge/ApiPlatform/State/Processor.php
0.00% <0.00%> (ø)

...rc/Bridge/ApiPlatform/State/CollectionProvider.php
76.47% <76.47%> (ø)

src/Bridge/Symfony/Serializer/ESQLMapper.php
88.23% <84.61%> (+88.23%)
:arrow_up:

src/Bridge/ApiPlatform/State/DataPaginator.php
74.11% <84.84%> (ø)

src/Bridge/ApiPlatform/State/ItemProvider.php
91.66% <91.66%> (ø)

src/Bridge/ApiPlatform/Extension/SortExtension.php
94.87% <93.33%> (-0.88%)
:arrow_down:

src/Filter/FilterParser.php
92.62% <95.65%> (-0.34%)
:arrow_down:

...c/Bridge/ApiPlatform/Extension/FilterExtension.php
87.87% <100.00%> (-1.32%)
:arrow_down:

src/Bridge/ApiPlatform/Filter/FilterDescriptor.php
97.56% <100.00%> (-0.56%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0cd393...6bc3d67. Read the comment docs.


fix(transformer/react-jsx): no need to wrap the Array when there is only one correct child element

Nice work! Thank you!


[BUG] Action Menu Not Opening with '/' Command on Android in Yoopta Editor (v4.9.1)

Has this bug been raised before?

[x] I have checked "open" AND "closed" issues and this is not a duplicate

Description
The '/' command opens the action menu on iOS but does not work on Android, impacting functionality on Android devices.
ref #362
Steps to Reproduce

Open Yoopta Editor Full Setup on an Android device.
Type '/' to try opening the action menu.

Screenshots
https://github.com/user-attachments/assets/42fede3e-c9fd-45e9-b829-34c9c55b6541
https://github.com/user-attachments/assets/7bece608-79b1-45d5-bfab-f44aa9c0488b
( '/' command does not open the action menu - Android)
https://github.com/user-attachments/assets/20298e5f-37f2-4aaa-8ff0-9ba9c16b9b3d
( '/' command opens the action menu - iOS)
Do you want to work on this issue?
No
If "yes" to above, please explain how you would technically implement this
No response

Hi @Darginec05 ,
I hope you’re doing well! I wanted to check in regarding this issue, as it’s affecting our product and causing some challenges for our Android users. We have customers awaiting the update, so if it’s possible to prioritize this fix, I’d really appreciate it.
Thank you so much for your efforts on this project, and for considering this request. Let me know if there’s anything I can do to assist!

hey 👋 @leo1104
Unfortunately, I don't have enough time to switch to this bug urgently.
But there is options to support/donate, and then bug can be prioritized


Constraints imposed on contacts on settings validation

Currently, when settings are validated, the following gets executed:
if (contact.getEmailAddress().isEmpty() || contact.getGivenName().isEmpty()) {
	errorMsg = "contact_not_enough_data";
	errors.add(errorMsg);
	LOGGER.error(errorMsg);
}

Question is: why? I mean, both the given name and e-mail address are optional in SAML 2.0 specification (section <IP_ADDRESS> of the metadata specification). We can say that it's good practice to specify them, however there are scenarios in which they are not defined and metadata should still validate correctly (e.g.: SPID assessment for full aggregator subjects).
What do you think?

The contactType value should be validated (not sure why its validation was commented) and verify its presence.
Related to the validation that you provided, the xsd defines:
Sequence [1..1]
md:Extensions [0..1]
md:Company [0..1]
md:GivenName [0..1]
md:SurName [0..1]
md:EmailAddress [0..]
md:TelephoneNumber [0..]
So all are optional, but at least one may be defined. Since we are only support as the toolkit as Contact attributes the EmailAddress and the GivenName, at least on may be provide in order to generate a valid md:ContactPerson

Thank you @pitbulk , this is clear now. However then note that there's a problem with the above check: indeed, if just ONE of given name or e-mail address is empty, validation will fail. Instead, from what we're saying, validation should fail if BOTH are empty.
I agree that perhaps a looser validation here won't hurt, especially because, even if the application does not do it by itself, the generated metadata will then be invalid and com.onelogin.saml2.settings.Saml2Settings.validateMetadata(String) (which we all are supposed to call, right? :-D) will notify us there's a problem (due to XML schema validation failure).
So we may return on this topic if we will decide to implement #326...


ERROR: could not initialize a memory descriptor

How to cope with this problem?
The environment has been settled as the ReadMe mentions.
2020-03-16 12:54:57.651335: W tensorflow/core/framework/op_kernel.cc:1318] OP_REQUIRES failed at mkl_concat_op.cc:784 : Aborted: Operation received an exception:Status: 5, message: could not initialize a memory descriptor, in file tensorflow/core/kernels/mkl_concat_op.cc:781                                                                                2020-03-16 12:54:57.787633: W tensorflow/core/framework/op_kernel.cc:1318] OP_REQUIRES failed at mkl_concat_op.cc:784 : Aborted: Operation received an exception:Status: 5, message: could not initialize a memory descriptor, in file tensorflow/core/kernels/mkl_concat_op.cc:781                                                                                Traceback (most recent call last):                                                                                File "main.py", line 64, in <module>                                                                                tf.app.run()                                                                                File "/home/humanflow/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 126, in run                                                                                _sys.exit(main(argv))                                                                                File "main.py", line 53, in main                                                                                model.train()                                                                                File "/home/humanflow/project/selflow/DDFlow/ddflow_model.py", line 332, in train                                         self.losses['abs_robust_mean']['no_occlusion'], self.losses['census']['occlusion']])                                  File "/home/humanflow/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 900, in run                                                                                run_metadata_ptr)                                                                                File "/home/humanflow/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1135, in _run                                                                                feed_dict_tensor, options, run_metadata)                                                                              File "/home/humanflow/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1316, in _do_run                                                                                run_metadata)                                                                                File "/home/humanflow/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1335, in _do_call                                                                                raise type(e)(node_def, op, message)                                                                                tensorflow.python.framework.errors_impl.AbortedError: Operation received an exception:Status: 5, message: could not initialize a memory descriptor, in file tensorflow/core/kernels/mkl_concat_op.cc:781                                                 [[Node: concat_21 = _MklConcatV2[N=2, T=DT_FLOAT, Tidx=DT_INT32, _kernel="MklOp", _device="/job:localhost/replica:0/task:0/device:CPU:0"](estimator_level_2_1/conv5/Maximum, estimator_level_2_1/conv6/BiasAdd, gradients/ExtractImagePatches_grad/Reshape_1/shape/0, estimator_level_2_1/conv5/Maximum:1, estimator_level_2_1/conv6/BiasAdd:2, DMT/_279)]]                                                                                Caused by op u'concat_21', defined at:                                                                                File "main.py", line 64, in <module>                                                                                tf.app.run()                                                                                File "/home/humanflow/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 126, in run                                                                                _sys.exit(main(argv))                                                                                File "main.py", line 53, in main                                                                                model.train()                                                                                File "/home/humanflow/project/selflow/DDFlow/ddflow_model.py", line 312, in train                                         global_step=self.global_step, regularizer_scale=self.regularizer_scale, train=True, trainable=True, is_scale=self.is_scale, training_mode=self.training_mode)                                                                                File "/home/humanflow/project/selflow/DDFlow/ddflow_model.py", line 262, in create_train_op                               losses, regularizer_loss = self.build(iterator, regularizer_scale=regularizer_scale, train=train, trainable=trainable, is_scale=is_scale, training_mode=training_mode)                                                                        File "/home/humanflow/project/selflow/DDFlow/ddflow_model.py", line 253, in build                                         losses, regularizer_loss = self.build_no_data_distillation(iterator=iterator, regularizer_scale=regularizer_scale, train=train, trainable=trainable, is_scale=is_scale)                                                                       File "/home/humanflow/project/selflow/DDFlow/ddflow_model.py", line 201, in build_no_data_distillation                    train=train, trainable=trainable, reuse=None, regularizer=regularizer, is_scale=is_scale)                             File "/home/humanflow/project/selflow/DDFlow/network.py", line 130, in pyramid_processing_bidirection                     flow_bw = _pyramid_processing(x2_feature, x1_feature, img_size, train=train, trainable=trainable, reuse=True, regularizer=regularizer, is_scale=is_scale)                                                                                File "/home/humanflow/project/selflow/DDFlow/network.py", line 112, in _pyramid_processing                                flow_estimated['refined'] = context_network(x_feature, flow_estimated['level_2'], train=train, trainable=trainable, reuse=reuse, regularizer=regularizer, name='context_network')                                                             File "/home/humanflow/project/selflow/DDFlow/network.py", line 32, in context_network                                     x_input = tf.concat([x, flow], axis=-1)                                                                               File "/home/humanflow/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/ops/array_ops.py", line 1189, in concat                                                                                return gen_array_ops.concat_v2(values=values, axis=axis, name=name)                                                   File "/home/humanflow/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/ops/gen_array_ops.py", line 953, in concat_v2                                                                                "ConcatV2", values=values, axis=axis, name=name)                                                                      File "/home/humanflow/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 787, in _apply_op_helper                                                                                op_def=op_def)                                                                                File "/home/humanflow/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 3392, in create_op                                                                                op_def=op_def)                                                                                File "/home/humanflow/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 1718, in __init__                                                                                self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access                                                                                AbortedError (see above for traceback): Operation received an exception:Status: 5, message: could not initialize a memory descriptor, in file tensorflow/core/kernels/mkl_concat_op.cc:781                                                               [[Node: concat_21 = _MklConcatV2[N=2, T=DT_FLOAT, Tidx=DT_INT32, _kernel="MklOp", _device="/job:localhost/replica:0/task:0/device:CPU:0"](estimator_level_2_1/conv5/Maximum, estimator_level_2_1/conv6/BiasAdd, gradients/ExtractImagePatches_grad/Reshape_1/shape/0, estimator_level_2_1/conv5/Maximum:1, estimator_level_2_1/conv6/BiasAdd:2, DMT/_279)]]

It seems that tf.extract_image_patches doesn't work for some tensorflow version. You can try replacing tf.extract_image_patches with another implementation, e.g.,
out_channels = d * d
w = tf.eye(out_channels*channel, dtype=tf.float32)
w = tf.reshape(w, (d, d, channel, out_channels*channel))
x2_patches = tf.nn.conv2d(x2_warp, w, strides=[1, 1, 1, 1], padding='SAME')

The tensorflow version is 1.8 gpu, as the readme said.
I try to replace tf.extract_image_patches, the error is the same.
Thank you for your replying.
------------------ 原始邮件 ------------------
发件人: "Pengpeng<EMAIL_ADDRESS>发送时间: 2020年3月23日(星期一) 中午12:25
收件人<EMAIL_ADDRESS>抄送: "zlt"<958602495<EMAIL_ADDRESS>主题: Re: [ppliuboy/DDFlow] ERROR: could not initialize a memory descriptor (#9)
It seems that tf.extract_image_patches doesn't work for some tensorflow version. You can try replacing tf.extract_image_patches with another implementation, e.g.,
out_channels = d * d w = tf.eye(out_channelschannel, dtype=tf.float32) w = tf.reshape(w, (d, d, channel, out_channelschannel)) x2_patches = tf.nn.conv2d(x2_warp, w, strides=[1, 1, 1, 1], padding='SAME')
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Java 17 Support

Your project looks very useful, but when trying to use it in a Java 17 project, the following error is displayed:
  bad class file: ~/.m2/repository/io/github/seujorgenochurras/image-to-ascii/0.0.4/image-to-ascii-0.0.4.jar(/io/github/seujorgenochurras/DefaultAsciifier.class)
    class file has wrong version 64.0, should be 61.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.

So the project is built with Java 21, and indeed, when I use that version, it compiles successfully.
Since Java 17 is still widely used and considered LTS, it would be useful to have the project, or at least a specific release branch, built using Java 17. Some developers can have restrictions which prevent them from using Java 21.
If I'm misunderstanding and there is a way to work around this issue, please let me know.
Thanks.

I'm sorry it took this long, but I'm going to downgrade the library to jdk 17

I mean jdk 21 is the latest LTS but  java community takes so fucking long to update that it is definitely better to just downgrade it

Fixed on latest release #15


Update the sidebar.js by a docusaurus lifecycle

🚀 Feature
I want to write a plugin that will update the sidebar.js
Motivation
I'm planning to write a plugin for docusaurus that will look to my components and generate the docs automatically using react-docgen. So I need a way to update the sidebar using this plugin.

Yes - having the sidebar auto-generate based on the content, folder/file structure in /docs etc. would make content management so much easier.

@mnbf9rca Try this plugin, i've just published it to npm
https://github.com/acrobit/docusaurus-plugin-auto-sidebars
You can override the name or the order of folders in the sidebars.yaml file.

Plugins lifecycles are generic across the whole website, not coupled to any plugin, such as docs. So it wouldn't make sense to add a plugin lifecycle for updating sidebars. We either need to modify the existing docs plugin or something or build an entirely new docs plugin.
Alternatively, we could add a plugin lifecycle called initialization() where you can write your own code to generate a sidebars.js file, but you can easily add a command that does that yourself before you run yarn start/build in package.json.
{
  "scripts": {
    "start": "./generate-sidebars.js && docusaurus start",
    "build": "./generate-sidebars.js && docusaurus build"
  }
}


Peak shaving is missing from the GoodWe inverter operation mode

GoodWe has added a peak shaving mode in ARM version 22 for the ET series. See: https://community.goodwe.com/Forum/details/2c9180827a7b69a0017a94a74d0c0281
It is also mentioned in the manual.
This option is missing in Home Assistant
This feature was implemented by GoodWe for the Belgian market for example. There will be a peak tariff starting from 1/1/2023
Goodwe's implementation of the peak shaving might not be the most ideal, though it can be useful when it's combined with some smart logic, for example: connect car >> switch mode >> charge battery taking into account the maximum peak >> charge EV and stop when battery is depleted, repeat until car is full. >> switch back to general mode.
So, it's an important feature.

@marcelblijleven could you have a look at this issue?

Peak shaving mode was added, in HA it will be part of 2023.3 or HACS <IP_ADDRESS>


Issue from website page Flutter FAQ

From URL: https://www.flutterchina.club/faq.md 有字重复看

That is a community website not maintained by the Flutter team. Try https://github.com/flutterchina/website/issues


improved docs

@barinder7 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Thank you!


Display inline-block / table

According to caniuse.com the display values inline-block and table are supported by IE8.
http://caniuse.com/#feat=inline-block
http://caniuse.com/#feat=css-table

:+1:

Fixed by https://github.com/israelidanny/ie8linter/commit/bc539994686875f7d9f2fbc85cc9f29e6e10e331

FYI. Currently the site still reports both inline-block and table

Published changes to the site :) Thanks.


[Feature]Assign a job to specific node

Is it possible that submit and run a job into a specific node? if yes, how to do this?

You can use dedicated virtual cluster.
/cc @mzmssg

@abuccts thanks. I use v0.11.0 of pai, it reports invalid choice: 'user' (choose from 'badgpus','blacklist') when I execute the command
python node_maintain.py user set -u {admin_username} -p {admin_password} -m {master_ip}

Seems you need to upgrade your pai becasue dedicated virtual cluster is supported in later version.
+@mzmssg to take a look.

Dedicated vc is supported in v0.14, you need an upgrade.
To achieve the binding, you need:

Create a dedicated vc with binding nodes
Add user to this vc
Submit job to that vc
Delete the dedicated vc

@mzmssg I have created a dedicated vc following your steps, but I cannot find how to add user to this vc, that document (https://github.com/microsoft/pai/blob/pai-0.14.y/docs/tools/dedicated_vc.md) didn't seems include this operation. Could you explain that? thanks.

@edenbuaa
It's the same as common vc, operated in the webport user manaement.
No need to specify in this doc.

ok, got it. thanks.


Can't update to 0.02

Hi. I tried updating to 0.02 but I'm getting error:
22-02-08 13:47:55 INFO (SyncWorker_3) [supervisor.docker.addon] Export image 87a644c9/aarch64-addon-etrv2mqtt to /data/tmp/tmpyw_dr16u/image.tar
22-02-08 13:48:54 INFO (SyncWorker_3) [supervisor.docker.addon] Export image 87a644c9/aarch64-addon-etrv2mqtt done
22-02-08 13:48:54 INFO (MainThread) [supervisor.addons.addon] Building backup for add-on 87a644c9_etrv2mqtt
22-02-08 13:55:51 INFO (MainThread) [supervisor.addons.addon] Finish backup for addon 87a644c9_etrv2mqtt
22-02-08 13:56:02 INFO (MainThread) [supervisor.backups.manager] Creating partial backup with slug 9f4973c2 completed
22-02-08 13:56:02 INFO (SyncWorker_3) [supervisor.docker.interface] Updating image 87a644c9/aarch64-addon-etrv2mqtt:0.01 to hbdk/eco2-tools:0.02
22-02-08 13:56:07 ERROR (SyncWorker_3) [supervisor.docker.addon] Invalid build environment, can't build this add-on!

Is it related directly to etrv2mqtt, like error is suggesting and I should go there? Or is it somehow related to your package?

i'm having trouble as well updating to the 0.02 versions for all three add-ons

try uninstalling the add on and installing it again.
i got that error as well, i think it's because the supervisor doesn't play nice with going from a locally build image to a prebuild.

Yup, I forgot to confirm that. Just don't forget to backup your configs ;)


Fix CircleCI token example

The CircleCI token example contains a redundant fragment /circleci/circleci/:token.
In addition, I think that you should allow a comment or a hint to be associated with the example or the provider at least to guide the user especially with private repositories.
For instance, in CircleCI, there are 3 token scopes :

status used for build status
view-builds for downloading artifacts
all to grant full read access to the project

Although it might seem that the first type is the one that should be used with the badge, the badge will not render unless an all scope token is specified.

Warnings

:warning:
This PR modified service code for circleci but not its test code. That's okay so long as it's refactoring existing code.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @haythem!

  Generated by :no_entry_sign: dangerJS

Fabulous, thank you!
Agreed the permissions issue should be documented until it's fixed. (#1064)
Would you like to add the documentation? If you put a documentation key in the badge examples containing HTML it'll render on the badge popup. Here's an example: https://github.com/badges/shields/blob/master/services/appveyor/appveyor-tests.service.js

Thanks @paulmelnikow for merging the PR.

Would you like to add the documentation ?

Yeah, sure.


How to debug jqf

hi,guys,
how can i debug jqf step by step?
Then i can know the details much easier.
I think this is very useful for us .
@rohanpadhye
any idea?
thanks sincerely.

i can debug jqf step by step now.

Thanks for the update!
On Fri, Apr 10, 2020, 1:30 AM rubby33<EMAIL_ADDRESS>wrote:

Closed #89 https://github.com/rohanpadhye/JQF/issues/89.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rohanpadhye/JQF/issues/89#event-3221189611, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABAJQMVTV5AOPETGHMC4AXLRL3KJDANCNFSM4MDZNFGA
.

i can debug jqf step by step now.
Can you tell me how you did it，thank you.


Code review

The requirement of this project is to:

Create a new empty repo.
Copy your code from a project completed during the Admissions Trial
Create a new branch for the copied code.
Open a pull request.

STATUS: Changes Required :recycle:
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

To Highlight :1st_place_medal:

Has a proper Pull Request. ✔
Good use of Github flow ✔

Changes Required

[x]  Please check the comments under the review.

Cheers and Happy coding!👏👏👏

[ ] Some linter checks failing ❌

As per project requirements, make sure all the codes are passing linter checks. Please do check and make the necessary changes👍


bug: types broken after setting a basepath

What version of Hono are you using?
4.4.0
What runtime/platform is your app running on?
node
What steps can reproduce the bug?
Typescript playground repro: link
What is the expected behavior?
There should be a way to create a typed testClient when using a basepath.
What do you see instead?
testClient types are broken when using a basepath.
Additional information
No response

I understood.
The type of Env is conflict.
Argument of type 'Hono<Env, BlankSchema, "/mybasepath">' is not assignable to parameter of type 'Hono<{}, { "/mybasepath/items": { $get: { input: {}; output: { id: number; }; outputFormat: "json"; status: 100 | 101 | 102 | 103 | 200 | 201 | 202 | 203 | 204 | 205 | 206 | 207 | 208 | 226 | 300 | 301 | ... 47 more ... | -1; }; }; }, "/mybasepath">'.
  Types of property 'fetch' are incompatible.
    Type '(request: Request, Env?: {} | Bindings | undefined, executionCtx?: ExecutionContext | undefined) => Response | Promise<Response>' is not assignable to type '(request: Request, Env?: unknown, executionCtx?: ExecutionContext | undefined) => Response | Promise<Response>'.
      Types of parameters 'Env' and 'Env' are incompatible.
        Type 'unknown' is not assignable to type '{} | Bindings | undefined

Env has two types of {} and unknown.

I'll fix this probelm later.

https://github.com/honojs/hono/blob/dfbc6c47643e027af484cfc028050124a21d9158/src/helper/testing/index.ts#L18

Explicitly unknown is not specified.

Implicit type conversion

Env["Bindings"] is unknown

ReturnType of ".get" is broken...?

enviroment in not used basePath

Either way, the returnType Env of .get will be unknown.

maybe IntersectNonAnyTypes<[E, E2]> is unknown

@thenbe

This problem can be worked around by specifying the Env directly.
But this is only temporary.


pwmetrics returns exit 0 when one of the expectations is correct

About this issue
I'm using pwmetrics, but I'm receiving a false positive when one of the expectations are passing. I couldn't find a way to make it pass only when all expectations are correct in the docs.
Config / CLI options
module.exports = {
  url: 'http://localhost:3000',
  flags: {
    runs: '1',
    submit: false,
    upload: false,
    view: false,
    expectations: true,
    disableCpuThrottling: false,
    chromeFlags: [
      '--incognito',
      '--aggressive-cache-discard',
      '--headless',
    ],
  },
  expectations: {
    ttfcp: {
      warn: '>=1500',
      error: '>=3000',
    },
    ttfmp: {
      warn: '>=2000',
      error: '>=4000',
    },
    fv: {
      warn: '>=1500',
      error: '>=4000',
    },
    psi: {
      warn: '>=1500',
      error: '>=3000',
    },
    vc85: {
      warn: '>=1500',
      error: '>=3000',
    },
    vs100: {
      warn: '>=1500',
      error: '>=4000',
    },
    tti: {
      warn: '>=1500',
      error: '>=4000',
    },
  },
};

Steps to reproduce.
I tried to make it run using
# run-pwmetrics.sh
#!/usr/bin/env bash
set -e
set -o pipefail

pwmetrics http://localhost:3000/landing --config=./pwmetrics-config.js 2> /dev/null
OUT=$?

echo "OUT: ${OUT}"
if [ $OUT -eq 0 ]
then
  echo "Successfully"
else
  echo "Error" >&2
fi

$ ./run-pwmetrics.sh

PS:

I tried run via npm script adding the same command as a npm script and both return the same error.

Screenshot

Environment

pwmetrics version: 2.0.2
Chrome version: Version 59.0.3071.115 (Official Build) (64-bit)
OS version: macOS Sierra 10.12.5
NodeJS version: v6.10.0
Yarn version: v0.27.5

As of right now the status code of pwmetrics is relative to a successful auditing execution and not the values of that execution.
If for some reason pwmetrics (actually lighthouse under the hood) was unable to retrieve the page load event for example, it could not compute the metrics which would lead to a crash in the program (see https://github.com/paulirish/pwmetrics/issues/74 for example).
Perhaps this should be changed when expectations are set. CC @denar90

Agree that the exit code should definitely be non-zero if there was an error within the expectations.
(TBH we should be exiting with 1 here as well: https://github.com/paulirish/pwmetrics/blob/6aea514f185901d7641750fda5d20c52a20a0d5a/lib/expectations.ts#L12 )

@paulirish About the process.exit(1) that you linked, it's solved in this commit (it's on PR right now). https://github.com/paulirish/pwmetrics/pull/128/commits/5c3a392cf17847ad020e70952da089a197fd45f5#diff-8ad51fb63d3211deee9a805a512386adR12

Closing this issue. It was solved in this commit. Thanks everyone.


I couldn't compile it in codespaces.

Tells me that AWS_LC not belongs to the root project.
package 'AWS_LC' didn't set the 'ROOT' variable in its build script or isn't a direct dependency of this package

oh you're right, I forgot to test it on Linux after I switched from our own aws-lc bindings to the official ones provided by AWS.

oh you're right, I forgot to test it on Linux after I switched from our own aws-lc bindings to the official ones provided by AWS.

It's not critical, I just created this issue to not forget to fix this.


[Transaction] Support produce batch transaction messages

Motivation
Currently, Pulsar only supports produce transaction messages in no batch mode.
Modifications
Add transaction id in the batch message container, if the newly added message has a different transaction id with the container, it will be added in the next batch.
Verifying this change
add a new unit test.
org.apache.pulsar.client.impl.TransactionEndToEndTest#batchProduceCommitTest
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

/pulsarbot run-failure-checks


SEPG Automated Release - v3.0.2

SEPG Details
Release Build Link: https://sou-jenkins2.swinfra.net/job/Auto-Release/508/
Build Token: github.com/CAFapi/opensuse-opensearch1-image/main/9c87e51b3ec5760c75170e34e15e57cf7e52d96e
Versioning Behaviour: Roll on to next minor
Artifacts For Release
Docker

cafapi/opensuse-opensearch1:3.0.2 (Static Tag)
cafapi/opensuse-opensearch1:3.0 (Dynamic Tag)
cafapi/opensuse-opensearch1:3 (Dynamic Tag)
cafapi/opensuse-opensearch1:latest (Dynamic Tag)

 Build Stage
Action
Status

Release Checks
completed
:heavy_check_mark:

Gather Release Data

:white_small_square:

QA Documentation Site Deployment

:white_small_square:

QA Deployment Branch Promotion

:white_small_square:

Docker Image Promotion

:white_small_square:

Maven Artifact Promotion (Closed Source)

:white_small_square:

NuGet Artifact Promotion

:white_small_square:

Artifactory Release Artifact Tagging

:white_small_square:

Generic Artifact Promotion

:white_small_square:

Maven Artifact Promotion (Open Source)

:white_small_square:

Maven Staging Repository Removal (Open Source)

:white_small_square:

Git Tagging

:white_small_square:

Git Release

:white_small_square:

Git Release Asset Deployment

:white_small_square:

Pull Request Merge

:white_small_square:

Release Branch Deletion

:white_small_square:

view the build log here


Update embedded-kafka from 3.6.1 to 3.7.0

Updates io.github.embeddedkafka:embedded-kafka from 3.6.1 to 3.7.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.github.embeddedkafka", artifactId = "embedded-kafka" } ]

labels: test-library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #95.


Corrected Color of 'Back-To-Top' Button According to Website Theme and Appearing Time

fixes #111
https://github.com/BamaCharanChhandogi/Diabetes-Prediction/assets/146121869/5e5e545f-f191-4f06-a46b-8322b96defdc

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊


update Defun doc to clarify that definitions are frozen at first .run call

Fixes #6804

Can one of the admins verify this patch?

Jenkins, test this please.

We need to wait two weeks on that one, sorry about that.

@zffchen78 @drpngx Do you have additional comments? Can we merge this or are we still in the two week waiting period mentioned above?

changed to the wording suggested by zf

Thanks @yaroslavvb. @zffchen78 can you take another look, please?

Jenkins, test this please.


Support disabling guild subscription events

Todo:

[ ] Verification / testing
[ ] Sufficient warning in docs

This is extremely broken.

The dangerous behavior interacting with disabling guild subscriptions was likely fixed with this commit:
https://github.com/discordrb/discordrb/commit/830dcf10d58c443259935df0ddfca389fed6033b
Either way though, traffic control will be done with intents, which supersedes the guild subscriptions toggle in the API.
No sense for us to support both, in this case.


Add Charmhub documentation

Description
Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that validate the behaviour of the software
[ ] I validated that new and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@gruyaume I moved part of the tutorial (deploy, configure, integrate) into a single page. If you want ever less pages, I can moved them right in index page.
I kept the setup and cleanup pages, but these can be removed if you think so.
I removed the relation under "explanation" section since they are already linked in the index.
I would keep the "how to" page since the actions to manually provide a certificate need a precise execution order.
References (actions, configs, integrations, libraries, resources) are linked to the page automatically generated.

Integration test issue addressed in the this PR.
Take a look, you might want to rebase or wait for that one to be merged :)


Adjust Formrecognizer Readme TAble

@samvaity I really don't expect this to work, but it may be worth a shot. Up to you.
In the meantime I'm filing an issue against docs WRT the bad sample as well.

This seems to be looking fine now.


feat(ui): react-native-web adopt

Please read and mark the following check list before creating a pull request:

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Short description of what this resolves:
This introduces a basic component adaptation to run with react-native-web 🎉 . As mentioned in #456, previously we had a list of problems with rendering components on a web. Mostly it is only layout issues. In general, this Pull Request refactors applying style prop with arrays instead of combining several style objects into one using a spread operator.

Adds basic support for React Native Web
Closes #456

NOTES:

ViewPager component is refactored to use Animated.View as a container with saving the previous API. But this made us able to remove some tests, because of the inability to test gesture handler. We should back to it.
Web-specific features like hover and focus states are not included in this PR. But I hope we'll back to it 🤞
This PR also does not include outline box fixes for an Input component because it is web-specific behavior. Read this guide or see an example code of how it can be resolved.

Demos:
In a playground module, there is a sample screen demonstrating a working example.
Launch a playground with a npm run start:pg:prod and following Expo CLI instructions press w to open a browser app. Then you can see a Sample item at the end of the list which demonstrates a sample layout launchable on both web and mobile platforms.

🎉


Accessibility nuri

Accessiblity

Title ( changed to something more descriptive ). Link: Title-chnaged
Used proper Image Attributes

Link-1: Proper Image Attribute
Link-2: image attribute on project
Link-3 proper attribute on chevron image
Link-4: Proper attribute of icon

Used Proper Text-heading

link-1: About section
link-2: Languages
link-3: Framework
link-4: Skills

Color Contrast ( no issue found)
Resize (no issue found)
Interaction (no issue found)
Moving content (no issue found)
Multimedia (no issue found)
Basic structure of page (no issue found)

Thank you so much, for your response
On Tue, 7 Dec 2021, 12:54 pm Carlos Robles, @.***>
wrote:

@.**** approved this pull request.
🍾🍾 STATUS APPROVED 👏🏽👏🏽
Hi @Nuri1977 https://github.com/Nuri1977 ,
Your project is complete! There is nothing else to say other than... it's
time to merge it [image: :shipit:]
Congratulations! 🎉
[image: Approved]
https://user-images.githubusercontent.com/22258274/138466108-6b14c541-6a88-44c5-ba76-c64992ac1835.gif
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have
only 3 code reviews per project. If you think that the code review was not
fair, you can request a second opinion using this form
https://airtable.com/shrQAqnBwek5a0O0s.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Ginohmk/My-portfolio/pull/8#pullrequestreview-825174078,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOAMQM7B46BWOBDWX5GUN33UPXYXXANCNFSM5JQTCGJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Support for data stream template file similar to template_file

(check apply)

[X ] read the contribution guideline

Is your feature request related to a problem? Please describe.
As template_file not supported for data stream, there is no way to create a data stream template file with the required settings from fluentd. The opensearch_data_stream type creates a default template and this requires to be modified later to add the required settings
Describe the solution you'd like
Support for data_stream_template_file when using opensearch_data_stream type similar to the config template_file support available for index when using opensearch type.
Describe alternatives you've considered
Currently data stream template file has to be created outside fluentd and also if fluentd plugin creates the default template before the external process creates it, we need to update the template as well as the data streams to reflect the new settings. There is an additional burden of managing external process.
Additional context

@cosmo0920 Any plans to support this in near future?

Should be done in https://github.com/fluent/fluent-plugin-opensearch/pull/20.


Webhooks and HTTP bindings can be combined

Currently in the bindings section, the links in HTTP and Webhooks leads to the same doc and show the same support for trigger and output. One shows support in 1.x, the other in 2.x. Can these be merged?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1df5e2bd-489d-19b2-87d3-d993ebb82021
Version Independent ID: 9e9d9ded-8f40-22be-4654-48c87f2c59e8
Content: Azure Functions runtime versions overview
Content Source: articles/azure-functions/functions-versions.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Hey @odvoskin Thanks for your feedback! We have updated the documentation to show the two as one, and these changes should be live within the next few hours.
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.