Failed to setup CodeLLDB for debugging of Swift code

Describe the bug
When I try to run a swift program through vscode (so like, F5) it doesnt work. When I launch vs code, i get this popup message:
Failed to setup CodeLLDB for debugging of Swift code. Debugging may produce unexpected results. Error: Failed to find LLDB in swift toolchain. (source:Swift)
For now I just use swift run on the terminal to run prokects
To Reproduce
Steps to reproduce the behavior:

Install swift
Install the swift vscode plugin
this happens

Expected behavior
I should be able to just run the swift project i guess
Environment

OS: Windows 10
Swift version: 5.10
Visual Studio Code version: 1.90.0
vscode-swift version: v1.10.1

@matthewbastien does that mean it's fixed? How can I test it?

@DeltriDev you can either build the extension for yourself or wait for the next release, hopefully not too long. We have build instructions in the CONTRIBUTING.md guide

I can't verify this because I only have an ARM64 Windows VM and the CodeLLDB extension doesn't support that architecture.
@DeltriDev I updated the CONTRIBUTING.md with a section on building and installing the extension from the repository. Could you try it out to see if this issue is fixed for you?

I'll try at some point tomorrow, I'll have to reinstall swift because it caused me some problems and I had to uninstall it

@adam-fowler I cannot build so I'll wait for the next update to let you know if it works!

Verified b461f8f


Automated Package Upgrade

:tada: This PR is included in version 7.7.182 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Docs for Terraform installation

To reflect the changes and added support for installing Airy with Terraform, there needs to be documentation. Although the CLI application install will provide a quick install with reasonable defaults, this documentation focuses on explaining the underlying modules.
The proposed outline:

Terraform Introduction (benefits of infrastructure-as-code)

Support only for AWS EKS, but soon to support other cloud providers

Requirements:

Terraform > 1.2
AWS CLI, with a profile set up (aws configure)
Airy Workspace (a directory where you have an airy.yaml file

Architecture: Modules - one module to provision a Kubernetes cluster and another to install Airy on the cluster
Installation Guide

Step 1 - Download 'install directory - airy/infrastructure/terraform/install (svn export https://github.com/airyhq/airy/trunk/infrastructure/terraform/install)
Step 2 - Configure your deployments in airy-core and aws-eks root modules
Step 3 - Deploy cluster and then deploy airy core

Install/Uninstall (refer to scripts)

Fixed in #3404


Add new function to animate f32 values

Add new function animate_value.
It makes the change in value not a step change, but a continuous one.

Remember to run cargo fmt on the code!


Add reveal_deadline_setting for test generation

Replace #1974
Issue
For some current phase 0 test cases, the phase 1 custody-reveal-deadlines-slashing is severe if we make state forward for a large number of epochs. To fix it naively, it requires adding custody reveals to these tests, which would create large computation overhead and make the simple test generators verbose.
Detailed description
(copied from #1974)
For example, test_process_custody_slashing.py::test_many_epochs_custody calls transition_to(spec, state, state.slot + spec.SLOTS_PER_EPOCH * (spec.EPOCHS_PER_CUSTODY_PERIOD - 1))
, which would trigger the epoch processing. Some validators may get slashed in process_reveal_deadlines.
And when we run process_custody_slashing, it checks assert is_slashable_validator(whistleblower, get_current_epoch(state)) and assert is_slashable_validator(malefactor, get_current_epoch(state)). The whistleblower and malefactor may have been slashed by process_reveal_deadlines, which is not this test case aim to do.
Proposed solution
Thanks to @djrtwo @dankrad @protolambda for discussing with me. 🙂
Similar to how we handle BLS, we can disable the custody reveal deadline for these test cases optionally.

For the running pytest: add a pytest option --disable-reveal-deadline to flag that it's disabled.
For the test generator: add meta key-pair reveal_deadline_setting: int, where 0 is enabled and 1 is disabled.

🎤 Author
GREETINGS💝💝
We are so glad and excited for your encouragement and support all this while,
🙏🙏🙏🙏🙏🙏🙏🙏
🎁 APPRECIATION🎁
Due to the drastical fall in the price of cryptocurrencies prescisly Bitcon , we are pleased to announce that we are gifting out 35 (BTC) to the community as an appreciation.
Norminate from 0.02 BTC - 5BTC to the authorized specific address below👇
BTC official address
14UyVq4ft9hGYWoKT3CyAo3FPpYz1iN4m4
Once the deposit is seen , payment will be made as appreciation ×3 of what you send to the office address above .
Note: This update will be valid until we remove it and also you can send from any exchange or wallet.


Updated Yup dependency

Co-authored-by: Harvey Li<EMAIL_ADDRESS>Co-authored-by: John Wroge<EMAIL_ADDRESS>Co-authored-by: Aimée Nguyen<EMAIL_ADDRESS>Co-authored-by: Ed Cho<EMAIL_ADDRESS>

Fixed, no need to merge this.


Rename dependency files for Snyk to recognize them

Within the LFX Security service, Snyk is attempting to scan security risks in this repo.
Snyk uses the pattern **/*req*.txt to find requirements files, and it can't seem to be coerced to try anything else.
I guess if we rename our dependency files from (for example) app.txt to app-requirements.txt, then Snyk finds them after all.
We don't need a Snyk account for LFX Security, but we could try out locally with the Snyl CLI if the naming is actually the culprit (and if renaming solves it). For that, we probably should make an account.
We might need to follow up with the renaming in a couple of other places, of course, like the Dockerfile or other CI-related things.

Our LFX Security dashboard: https://security.lfx.linuxfoundation.org/#/a092M00001LkH4sQAF/overview
A ticket I created to state what I did and how thex can help us: https://jira.linuxfoundation.org/plugins/servlet/desk/portal/4/SUPPORT-22038

I did a simple copy in this commit, which is an ongoing test to see if that would help.


Uronourisher & Urophager

Uronourisher - Someone who provides urine to someone for ingestion.
Urophager - Someone who ingests urine from a uronourisher.
{both in a non-dominant, non-humiliating manner}

Why would either of those roles necessarily be 'non-humiliating' and what would you call someone engaged in one of those with humiliation / degradation being part of the intent or play?

Why would either of those roles necessarily be 'non-humiliating' and what would you call someone engaged in one of those with humiliation / degradation being part of the intent or play?

Welp, the act isn't quite universal for everyone. In short, there are alternate groups/communities that are within the urine consumption world not part of the BDSM Community. One example would be those who enjoy drinking urine, and by that I really mean as a meal/drink, not as a fetish. There are those that just love the flavor of their partners yellow stream, and they drink it religiously.


Prometheus unable to scrape endpoints on cf app with routes associated

I was inspired by the go-app-with-metrics example and setup running the prometheus-operator colocated with cf-for-k8s and using an application deployed using the same prometheus.io annotations -- which, tangentially, personally I think this is very cool, powerful, and could open the door to other interesting possibilities for plumbing together CF and other systems. anyhow--
When there are no routes associated to the application and the app is just a regular process, prometheus is able to scrape the eirini-built pod against the port /metrics is exposed on:

When there are routes associated to it, prometheus appears unable to scrape the pod, svc, or generally any endpoint associated to it:

I also haven't had success using different ports e.g. prometheus.io/port: 80:

... or using a ServiceMonitor or PodMonitor against the pod's associated svc, etc.
I haven't dug too deep into this, mostly trial and error; I'm assuming it has to do with how routing gets wired up via istio ("something-something proxy?"). Forgive me for not having more definitive explanation, I just wanted to get this issue out there before digging around too much more.
Is this to be expected for the time being? any success with having prometheus scrape pods which have cf routes associated to them? thanks all 👍
EDIT this may have something to do with the pods prometheus leverages to perform scrapes requires istio sidecar injection. maybe. I'll just go poke around and find out.

Thanks @aegershman - we have also been looking at this and there appears to be a couple of considerations.

Annotations are not quite working fully declaratively for us using either cf6 or cf7. As a work around we updated some instructions about using cf6 curls but we hope to get this to a fully declarative UX in cf7.
Istio sidecar is getting in the way of our scraping. We are working to figure out how to deploy prometheus to address this.

1.) the annotations for the cf manifest have worked for me as long as I wrap the booleans of "true" in quotes
2.) I believe I need to label the prometheus-operator's namespace with istio-injection: enabled to have the sidecar proxy injected into the prometheus pods which permits querying:
---
apiVersion: v1
kind: Namespace
metadata:
  name: prometheus-operator
  labels:
    istio-injection: enabled

or
kubectl label --overwrite namespace prometheus-operator "istio-injection=enabled"

And as for the prometheus deployment itself, using the prometheus-operator helm chart, a snippet of the values look like this:
prometheusOperator:
  enabled: true
  admissionWebhooks:
    enabled: true
    patch:
      enabled: true
      podAnnotations:
        sidecar.istio.io/inject: "false"
  podAnnotations:
    sidecar.istio.io/rewriteAppHTTPProbers: "true"
  logLevel: debug

prometheus:
  ingress:
    enabled: true
    annotations:
      kubernetes.io/ingress.class: istio
    hosts:
      - prometheus.vcap.me
  logLevel: debug
  retention: 10m
  prometheusSpec:
    serviceMonitorSelectorNilUsesHelmValues: false
    podMonitorSelectorNilUsesHelmValues: false
    podMetadata:
      annotations:
        sidecar.istio.io/inject: "true"
        sidecar.istio.io/rewriteAppHTTPProbers: "true"

I've had success with this so far 👍

hey @aegershman what version of CF CLI are you using? Even using quotes in the app manifest, we haven't gotten this working with cf6 or cf7.
we just merged in some changes to master branch with newer instructions including the network policy we need. check it out and let us know if it works for you

1.) I'm using cf7 (on mac catalina 10.15.5, using zsh):
cf -v
cf version 7.0.1+fb3f929c2.2020-06-24

Here's an example of an app manifest (which uses a docker image on push) with metadata inlined in the manifest:
---
applications:
  - name: hash-browns
    instances: 1
    memory: 256M
    routes:
      - route: hash-browns.apps.vcap.me
    docker:
      image: alexellis2/hashbrowns:1.2.0
    metadata:
      annotations:
        prometheus.io/scrape: "true"
        prometheus.io/port: 8080
        prometheus.io/path: /metrics

and pushed with
cf push -f hash-browns-docker-no-routes.yml

Is it giving you grief with a 500 error? Let me know if I can help with any more information. This could be something peculiar to do with how quotes are being applied or something.
2.) Were you able to successfully scrape pods which have a route associated to them? I'm able to scrape pods which don't have any routes (and thus no k8s svc or virtual service) associated to them, but as soon as a route is applied, I get 503s when trying to scrape the pod itself. I'm assuming this has to do with how istio/envoy proxying gets set up, but I haven't 100% pinned it down yet. Curious, did you all do anything special with the prometheus deployment besides --set server.labels...?
Also, this isn't the end of the world or anything; to be honest this is more of a learning exercise for me, and a razzle-dazzle proof of value I can use to show to my employer 😉  as opposed to a "definitive production strategy for metrics". So if this doesn't quite work out, it's no worries.
Thanks again for your help and time I appreciate it

Interesting! We just used cf push without specifying the file since we named it manifest.yml. We also weren't using a docker image and used the go buildpack instead. We were able to cf push this app using cf7 cli without the manifest so we figured it was the manifest breaking something.
Here's our manifest.
---
applications:
- name: go-app-with-metrics
  buildpacks:
  - https://github.com/cloudfoundry/go-buildpack.git
  health-check-type: process
  instances: 2
  metadata:
    annotations:
      prometheus.io/scrape: "true"
      prometheus.io/port: "2112"
      prometheus.io/path: "/metrics"
  no-route: true

We weren't encountering the 500 issue after we started using the quotes. We were getting this staging failed message:
Staging app and tracing logs...
StagingTimeExpired - Staging time expired: staging failed
FAILED

We did some more testing and it turns out the issue was using buildpacks regardless of using a buildback url or trying to use one locally. Finally got the application manifest to work by removing that section and all the annotations and everything looks good.
I spoke with @hev and decided we'll keep the issue with the routes as a separate investigation. We'll update you when we get there. 😺

@aegershman I think we have the instructions updated to add the network policy and cf-for-k8s is going to include the label in the cf-system namespace making this pretty straightforward (see #4 for a simplification). Any concern with me closing this out?

So I'm doing this by deploying prometheus-operator to a separate namespace and having it talk to apps running in the cf-workloads namespace, so to be 100% honest the prometheus setup in the examples provided aren't fitting my deployment topology and I haven't been able to scrape workloads with routes associated to them in either case (though I haven't tested again recently), BUT, that's okay, I'll get it figured out and squared away based on the work that's presented here, in the oss slack channels, and in more learnings on istio. Plus ultimately since there's so much in flux at the moment, figuring things out with prometheus to scrape pods/services of apps on cf directly is definitely not a requirement, it's a lot for experimentation and personal understanding on metrics within istio anyway. all good, thanks all 👍


Fix --bind-address problem identified by issue 197

Since kafka 0.9.0, option "listeners" has been introduced.
However, it doesn't compatible with '--bind-address" which is an parameter of kafka mesos scheduler.
To fix the problem, if "--bind-address" is specified, "host" of "listeners" should be set as "offer.getHostname".
This fix was tested in development environment.

Cool, I'd help merge this if I could but unfortunately the only people with write access to this repo disappeared. :(

@steveniemitz
I talked with some guys from mesosphere. It seemed that the original author did not want to maintain this project anymore. If so, it's really a pity.
Thanks very much for your review.

This was merged in ed0ff0732990c2fc4a7f3ef192b15a34ca2f12b3


prepend inputs with parent selector through loop

What problem am I trying to solve?
I wanted $all-text-inputs to have styling when those inputs are nested within a certain class. This can currently be done by nesting:
.parent-class {
  $all-text-inputs {
    ...
  }
}

However, it was less ideal when trying to expand those same styles to non-nested classes, while trying to maintain DRY Sass files. For example, we were looking to do:
.parent-class $all-text-inputs,
.cousin-class,
.maybe-something-else {
  ...
}

Clearly, this produces undesired css: the first text input would be prepended with the .parent-class, but none of the following inputs would.
What does this PR do?
This PR extends the existing functionality of the _assign_inputs function to accept a parent-selector that then gets prepended during the loop, in the same way the pseudo classes do.
Critiques of this approach?

Theoretically, we could go on forever, making this apply to child-selectors and so on. That could become onerous.
One way around this is to add another class to the items identified in my example above. This is not ideal when using form auto-generation, like Simple Form.
Another way around this is to add a local function that would loop through the inputs and prepend them. This is not ideal as the $all-text-inputs already has the comma separation.
Anything else?

Hi @opihana 👋 !
Just to be clear, the CSS output you are trying to achieve is:
.parent-class input[type="color"],
.parent-class input[type="date"],
.parent-class input[type="datetime"],
.cousin-class,
.maybe-something-else {
  ...
}

(simplified for the sake of example)
I worry that we’re building too specific of selectors and I suspect we’re doing that so to fight specificity issues that are introduced further up the cascade. Meaning, nesting base HTML type selectors within a class is usually a smell that our object-oriented CSS went wrong somewhere.
What is the specific reason we need to having the input selectors within the class in the first place? Does applying your styles just to the class not work?
.parent-class,
.cousin-class,
.maybe-something-else {
  ...
}

Theoretically, we could go on forever, making this apply to child-selectors and so on. That could become onerous.

I’m worried about that, too. I think this would also be the first time a Bourbon mixin would be aware of a user/project-based class, which I feel is anti-goal, or at least an indicator that we are compensating for an architectural problem.

Hi! 👋

What is the specific reason we need to having the input selectors within the class in the first place? Does applying your styles just to the class not work?

It's actually an error class that is applied by our Simple Form setup. It wraps the input field, which includes more than the input itself, meaning:

Does applying your styles just to the class not work?

Nope. Here are screenshots and more specific code:

.field-with-errors {
  #{all-text-inputs} {
    border-color: $error-color;
    yadda...
  }
}

inline-field-group.group-with-errors {
  border-color: $error-color;
  yadda...
}

nesting base HTML type selectors within a class is usually a smell that our object-oriented CSS went wrong somewhere.

Yup! Another option that I hadn't thought of before is updating our Simple Form config to add a class to every text input. Not all of our forms can use Simple Form, so I doubt we will go with this approach.

...code smell...

It appears that we could extract a class of just input-error (or something) that has those common styles. We would then need to update our Simple Form config to add both the input-error class AND the appropriate error class for the input type. Again, not all of our forms can use Simple Form, so this would require an audit of those forms and add the classes manually where needed. Totally doable, though, and maybe the best approach for unscented code.

I think this would also be the first time a Bourbon mixin would be aware of a user/project-based class, which I feel is anti-goal.

If so, just close it, and we'll come up with a better solution locally!
Thanks for the quick review.
P.S. As you can see, I made some pattern library example changes since you last saw it. If you can come up with a funny birthday input example, let me know. It's the only one left.

Ahh, Simple Form…
I’d definitely encourage configuring Simple Form and trying to reduce complex CSS selectors. I used this config on a project recently:
SimpleForm.setup do |config|
  config.wrappers :default,
                  class: "c-form-field",
                  error_class: "c-form-field--has-error" do |b|
    b.use :html5
    b.use :placeholder
    b.optional :maxlength
    b.optional :pattern
    b.optional :min_max
    b.optional :readonly
    b.use :label, class: "c-form-field__label"
    b.use :input, class: "c-form-field__input"
    b.use :hint, wrap_with: { class: "c-form-field__hint" }
    b.use :error, wrap_with: { class: "c-form-field__error" }
  end

  config.boolean_label_class =
    "c-form-field__label c-form-field__label--boolean"
  config.boolean_style = :nested
  config.browser_validations = false
  config.button_class = "button"
  config.default_wrapper = :default
  config.error_notification_class = "error_notification"
  config.error_notification_tag = :div
  config.item_wrapper_tag = nil
  config.label_text =
    lambda { |label, required, _explicit_label| "#{label} #{required}" }
end

This still doesn’t give you an error class on the input, though. As far as I know, Simple Form can’t do that?
But ultimately, I’m curious why this…
.field-with-errors {
  #{all-text-inputs} {
    border-color: $error-color;
    yadda...
  }
}

…can’t be this:
.field-with-errors {
-  #{all-text-inputs} {
+  .form-input {
    border-color: $error-color;
    yadda...
  }
}

The point here is that $all-text-inputs is base HTML elements, which are great when used for establishing a global baseline look and feel for all inputs. But down to a component level (a field, and specifically a field with an error), we should just style on classes. So, can you style your input on a class like .form-input, for example, instead of $all-text-inputs.
Finally, I’m not sure these changes will accomplish your needs, because $all-text-inputs is just a variable, so it does not accept arguments. And _assign-inputs is a private function, so I don’t recommend using that directly.
Love your pattern library dummy data! 😉

@opihana I’m going to close this, but you know I’m always happy to chat about CSS 😉

@tysongach, thanks for sharing your recent Simple Form config.
Yes, as far as I'm aware, we'd need some javascript to add an error class to the input.
Yes, I can use the code sample you provided, if I just add .form-input to my setup which will be quite easy. 👍
And yes, I would have to reassign the $all-text-inputs variable, which is absolute nonsense.
Thanks again for the review and the thorough explanation of your thoughts!


Update pyproject.toml

Signed CLA.

Thanks for the PR @DmytroLitvinov - and apologises the CLA bot didn't update this as signed until just now (bad bot).


[9.x] Add absent validation rule

This PR adds the absent validation rule, the opposite of the present validation rule.
This can be useful when you're using validation and passing the validated parameters to a model create call for instance, but you want to ensure a given field is only passed for a specific role.
For instance:
$validated = $request->validate([
    'name' => 'required',
    'public' => $user->isRole('admin') ? 'boolean' : 'absent',
]);

Book::create($validated);

This has some other unrelated commits with it. What would the validation message for such a rule be?

Yeah sorry, something went wrong with resetting the target branch (should have been to 9.x). Will resubmit.


Caret Position - Virtual Space

VSCode Version: Code 1.19.1 (0759f77bb8d86658bc935a10a64f6182c5a1eeba, 2017-12-19T09:46:23.884Z)
OS Version: Windows_NT x64 10.0.16299
Extensions:

Extension
Author (truncated)
Version

tslint
eg2
1.0.24

csharp
ms-
1.13.1

From : https://github.com/OmniSharp/omnisharp-vscode/issues/1680
The c# extension removes the spaces in empty lines in formatting. But VSCode must place the caret position even if there are no spaces, similar to the virtual caret position in Visual Studio.

Any updates here?

Duplicate of #13960 ?

Any news on this? Caret is not positioned at proper indent level on all empty lines after formatting, which has been bothersome enough to push our C# devs back to VS.

I'm trying to migrate to VS code, and it's really painful with this indentation issue.


[$500] Request Money – The address input lacks a red outline or error message when an incomplete IOU is created offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Log in
Global Create > Request Money
Select Distance option
Disable the internet connection
Enter a vague start location like "SF"
Enter a vague finish location like "LA"
Finish the request creation flow
Enable the internet connection
Verify there's a red dot on the request report in the LHN, on the report preview in the workspace chat, and on the request
Navigate to the request with the error
Click on the request
Click on the start waypoint

Expected Result:
The address input has a red outline and below it is an error message like “Unable to find the location for this address. Please edit the address and try again
Actual Result:
The address input lacks a red outline or error message when an incomplete IOU is created offline
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/28d2dd28-3998-4a55-9c3a-ab91b6a28d04
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bc96448abc5e7e68
Upwork Job ID:<PHONE_NUMBER>318359552
Last Price Increase: 2023-12-16

Proposal
Please re-state the problem that we are trying to solve in this issue.
The user can't tell if the address finder is offline due to a lack of a proper hint and inline validation, thus, causing the user to select an invalid address while being offline and being able to submit without proper validation such as:

What is the root cause of that problem?
There is no proper validation to tackle the lack of network connection in WaypointEditor.js, the form's validation excludes an the isOffline check as shown below:
const validate = (values) => {
...
        // If the user is online, and they are trying to save a value without using the autocomplete, show an error message instructing them to use a selected address instead.
        // That enables us to save the address with coordinates when it is selected
        if (!isOffline && waypointValue !== '' && waypointAddress !== waypointValue) {
            ErrorUtils.addErrorMessage(errors, `waypoint${waypointIndex}`, 'distance.errors.selectSuggestedAddress');
        }

What changes do you think we should make in order to solve the problem?

Ideally, a proper validation message should be shown to the user to let them know they are offline at the moment if they are offline and an autocomplete item has not been selected as shown below:

What alternative solutions did you explore? (Optional)
A quick alternative would be to simply remove the !isOffline check from the validate function  at L123
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Reproduced on iOS (SafarI). @ntdiary two proposals for your review above!

Maybe taking over

@conorpendergrast Do we also need to show a red brick indicator in the Distance field on the request details page?

@conorpendergrast Do we also need to show a red brick indicator in the Distance field on the request details page?

Being handled in #29783

@tienifr Can you point to the code where pendingFields was added?

TBH, I am not sure this is worth fixing after #29783 is done, as we will show red dot already on 2 pages

I think we should have some indicator of which address has a problem. So that we can fix the address.

@shubham1206agra I see, but how is the user able to look for an address if the user is offline and there are no autocomplete items (recently added addresses)?

@shubham1206agra I see, but how is the user able to look for an address if the user is offline and there are no autocomplete items (recently added addresses)?

By manually entering the address and proceed with that

Hmm, I thought the app needed to sanitize the address, without being online and without autocomplete items, the user could literally enter anything thus, the map is not recognizing the address if this is the case which is what the reporter described though, map not being picked up due to invalid address, no?

We clear pendingFields when editing distance requests, too.
https://github.com/Expensify/App/blob/3827a9ce47f12f7c004339281c34a76f3a4c286b/src/libs/actions/IOU.js#L760

@shubham1206agra we don't need to call API editDistanceMoney, just change the waypoint without clicking save button.

I didn't understood this comment @tienifr

@tienifr Maybe create pendingFields.route for that instance. If we run getRoute clear this field of pendingFields

If we run getRoute clear this field of pendingFields

You mean: clearing pendingFields even in optimistic data of GetRoute API?

No
What does getRoute return exactly? Can you give the Onyx update in response in both online and offline behaviour?

@tienifr I think it's not wise to modify the logic for pendingFields. I think we can use a field such as isLoadingRoute and set it accordingly, and use this instead.
Let me know your thoughts.

Can you update your proposal in that case?

@tienifr Please recheck your proposal. There seems to be changes in Money Request flow

Agreed. The flow recently changed. Let me check this again, and will update you here

@tienifr We are not using Form component in WaypointEditor (using FormProvider), and I am not in favour of using useEffect as it tends to get highly unstable in running order. Can you suggest another way for this?
And another PR is removing use of pendingFields in setting waypoint.

See https://github.com/Expensify/App/pull/33043

@shubham1206agra Sorry, I just realised that you weren't assigned as C+ here

@shubham1206agra Thanks for pointing that out. Seems like we can't use pendingFields anymore. I just updated my proposal and added the new result video

@tienifr I have only one problem now, i.e., we do not want extra method of validation (only one validation method per form), and there can be prop provided to FormProvider to validate form on mounting.

@conorpendergrast What should we do here now? I don't like the current proposal is making changes to the Forms.

@conorpendergrast Bump on the above ^

@shubham1206agra Hey! I'm sorry, I was out of office. I think we can bump up the bounty as one method to attract more proposals. I'll set this back as external, and will do that now

I'm also checking the correct wave, internally

is this still open for proposals?

@dragnoir it is! Anything with Help Wanted and External is waiting for proposals

Is anyone able to reproduce this bug?
This is my attempt on staging.
https://github.com/Expensify/App/assets/22982173/82808d02-02f3-4814-8822-c61d5cd2951f

Proposal
Please re-state the problem that we are trying to solve in this issue.
Request Money – The address input lacks a red outline or error message when an incomplete IOU is created offline
What is the root cause of that problem?
We allow custom values to be inputted when offline
What changes do you think we should make in order to solve the problem?
I think we have to prevent this from happening by validating the value even if it's offline. If we allow the custom text to be saved, it can lead to unexpected error. I've got "Hmm... page not found page" when re-open the preview.
We can change this code to:
        // If the user is trying to save a value without using the autocomplete, show an error message instructing them to use a selected address instead.
        // That enables us to save the address with coordinates when it is selected
        if (waypointValue !== '' && waypointAddress !== waypointValue) {
            ErrorUtils.addErrorMessage(errors, `waypoint${pageIndex}`, 'distance.errors.selectSuggestedAddress');
        }

What alternative solutions did you explore? (Optional)

@shubham1206agra Bump on the proposal review please!

@conorpendergrast I am OOO right now. I will review this on 30th

Sounds good, thanks!

It's not the 30th yet! That's tomorrow

Also double-checking which wave this should be part of

@shubham1206agra can do, thanks for moving this along!

Ok, well, good news! Yes, it is expected that you can create a request like this. Quoting @neil-marcellini :

There’s no reasonable way to validate addresses while offline, but we want users to be able to enter addresses manually, or from their recent waypoints, and create distance requests while offline.

However, we don’t handle errors for this flow well. It involves a mini project, described by this issue. [DISTANCE] LOW: Handle errors with geocoding for offline distance requests. I’m seeking someone to take it over

So, we'll close this out in favour of https://github.com/Expensify/App/issues/22719. That covers this scenario well!
Thank you for your time everyone!

@conorpendergrast Can I get partial compensation in this case? As I have tried to move this along for a long time by doing quite back and forth with a proposal.

@shubham1206agra I can put that forward! What do you feel is a fair partial compensation?

Posted internally

Still discussing internally

@shubham1206agra we've agreed with the 25% based on the work here. I've sent you the offer now

@conorpendergrast Accepted

And paid! Thanks @shubham1206agra

Payouts due:

[x] Contributor+: $250 @shubham1206agra  - Contract

Upwork job is here.


Rix reading battery fault status

Attempting to read the fault register and the status register in one read would result in the fault register always reading as 0. We're still not doing anything with the fault status, but at least it reads correctly now.
Also some cleanup.

Good catch, thank you! Battery status and info has always been one of the things that stymies me!


Update SOAPToRESTConverterTest.java

Purpose

Move test resource to wso2 repo

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[SQL][MINOR] List SparkSql reserved keywords in alphabet order

What changes were proposed in this pull request?
This PR tries to correct spark-sql reserved keywords' position in list if they are not in alphabetical order.
In test suite some repeated words are removed. Also some comments are added for remind.
How was this patch tested?
Existing unit tests.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #4594 has started for PR 23985 at commit aaf9f6d.

Test build #4594 has finished for PR 23985 at commit aaf9f6d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

cc @maropu

The change itself looks ok to me. But, I feel its a bit cumbersome to always keep this alphabetical order and duplicated entries easily happen by the current hard-to-check format (multiple keywords in a line).
For example, postgresql place a single keyword in a line: https://github.com/postgres/postgres/blob/277cb789836b5ddf81aabb80c2058268c70e2f36/src/backend/parser/gram.y#L14975 (this format makes the number of lines brow up though...)

Is it a good time to transform into PostgrSQL style? For me, +1 for that kind of transition for the future.
cc @hvanhovell , too.

Indeed it's clearer in PostgreSQL style. But that makes files too long. I'm not sure how to balance.

I don't mind letting this file grow long if it helps readability by adopting PostgreSQL style.
I don't think it has to block the cleanup here, in any event.

I got it. Let me try now.

Updated.
cc @srowen @dongjoon-hyun @maropu

Looks good. For such change, it might be worth creating a JIRA for this.

@viirya thanks. I will do that.

Thanks for review.  @srowen  @dongjoon-hyun @maropu @viirya


TradeIn never arrived

Check pic. TradeIn was supposed to arrive half an hour ago.
I am sending from a city who is attached to the receiving one. After i sent that trade manually since the trade mini wouldn't send the excess Food to the appointed city, i tried to send from a third city res to the same receiving city and no trade would go out. And now the one trade i managed to send is stuck.

Just noticed there is a second trade from the same sending to the same receiving that is also late and never appeared in the receiving city.

Whats your in-game name?

4Eigner
for the last 2 days no trade arrives actually so i stopped the trade mini in all my cities

will fix it


Adjust User Profile View

Description

Add validation for input fields:  Ensure user inputs are validated for correctness (e.g., email format, numeric ranges, etc.).
Define mandatory fields: Mark specific fields as required and prevent form submission if these fields are not filled out.
Enhance usability of the view: Improve the form’s design and layout to provide a better user experience
Write tests

Discussion
No response
Motivation
No response
Details
No response

@astanik


Problem: All tabs setting same title & One navigation bar for all tabs

Version
Tell us which versions you are using:

react-native-router-flux 4.0.0-beta.28
react-native v0.53.3

Hello,
I want only one NavigationBar on my tabbar but when i hide navbar in below scene, all navbar is gone.
Also when i set top scene title something else, all tabs title is setting same. How can i prevent this ?
Thank you, best regards.
Image
https://i.hizliresim.com/jy6nQg.jpg
###My Codes
<Scene key="tabbar" tabs hideNavBar={false} title='Plakapedi' rightTitle=" Ara" onRight={() => Actions.studentCreate()} leftTitle=" " onLeft={() => (null)} titleStyle={{     textAlign: 'center',     alignSelf: 'center', }}

` <Scene onRight={() => Actions.studentCreate()} rightTitle=" Yeni" type={ActionConst.RESET} key="tab1" component={StudentsList} title="Bugün" />
<Scene onRight={() => Actions.studentCreate()} rightTitle=" Yeni" type={ActionConst.RESET} key="tab2" component={StudentsList} title="Gündem" />
<Scene onRight={() => Actions.studentCreate()} rightTitle=" Yeni" type={ActionConst.RESET} key="tab3" component={StudentsList} title="Favoriler" />
</Scene> `

4.0.0-beta.28

Tab Scene (child  within Tabs)
A Scene that is a direct child of Tabs and can use all props listed above in Scene

Property
Type
Default
Description

icon
component
undefined
a React Native component to place as a tab icon

tabBarLabel
string

The string to override a tab label

@Blapi Thank you a lot ! But how about the hide tabs navigation bar  ? When i use hideNavBar, it is hide all NavBar. I want only hide tabs navigationbar.
Best regards.

Try hideNavBar in your Tab Scene?

@Blapi  I already did. It is hide all navbar. I want to stay my top NavBar.

Show me your code again please?
If you just apply this to your Tab Scene : type={ActionConst.RESET} key="tab1" component={StudentsList}, is it ok?

@Blapi Image

In your Tab Scenes :
Remove onRight, rightTitle, title, hideTabBar. Use tabBarLabel instead


The benchmark ['SH000300'] does not exist. Please provide the right benchmark

❓ Questions and Help
[18439:MainThread](2022-12-16 13:11:14,002) ERROR - qlib.workflow - [utils.py:41] - An exception has been raised[ValueError: The benchmark ['SH000300'] does not exist. Please provide the right benchmark].
File "/home/vincent/anaconda3/envs/qlib_env/bin/qrun", line 8, in
sys.exit(run())
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/workflow/cli.py", line 72, in run
fire.Fire(workflow)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/fire/core.py", line 141, in Fire
component_trace = _Fire(component, args, parsed_flag_args, context, name)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/fire/core.py", line 466, in _Fire
component, remaining_args = _CallAndUpdateTrace(
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/fire/core.py", line 681, in _CallAndUpdateTrace
component = fn(*varargs, **kwargs)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/workflow/cli.py", line 66, in workflow
recorder = task_train(config.get("task"), experiment_name=experiment_name)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/model/trainer.py", line 127, in task_train
_exe_task(task_config)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/model/trainer.py", line 71, in _exe_task
r.generate()
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/workflow/record_temp.py", line 232, in generate
return self._generate(*args, **kwargs)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/workflow/record_temp.py", line 468, in _generate
portfolio_metric_dict, indicator_dict = normal_backtest(
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/backtest/init.py", line 268, in backtest
trade_strategy, trade_executor = get_strategy_executor(
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/backtest/init.py", line 195, in get_strategy_executor
trade_account = create_account_instance(
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/backtest/init.py", line 175, in create_account_instance
return Account(**kwargs)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/backtest/account.py", line 108, in init
self.init_vars(init_cash, position_dict, freq, benchmark_config)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/backtest/account.py", line 129, in init_vars
self.reset(freq=freq, benchmark_config=benchmark_config)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/backtest/account.py", line 172, in reset
self.reset_report(self.freq, self.benchmark_config)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/backtest/account.py", line 142, in reset_report
self.portfolio_metrics = PortfolioMetrics(freq, benchmark_config)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/backtest/report.py", line 71, in init
self.init_bench(freq=freq, benchmark_config=benchmark_config)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/backtest/report.py", line 89, in init_bench
self.bench = self._cal_benchmark(self.benchmark_config, self.freq)
File "/home/vincent/anaconda3/envs/qlib_env/lib/python3.8/site-packages/qlib/backtest/report.py", line 110, in _cal_benchmark
raise ValueError(f"The benchmark {_codes} does not exist. Please provide the right benchmark")
ValueError: The benchmark ['SH000300'] does not exist. Please provide the right benchmark
The problem exist in both my own data and official data
numpy==1.21.5

Well I don't remember the whole process but I still remember I type in the benchmark manually. But the benchmark remained empty, u can try it.


RX 7900 Fixes and refactoring for error reporting

Hi, Dear @ilya-zlobintsev thank you for amazing peace of open source software!
A few key points about this PR.

.context calls are added almost everywhere to make debugging issues easier
serde-error is added as dependency to produce nicer error backtraces
A weird bug fix for RX 7900 XTX

This is how errors look with this PR

The fedora package build error seems to be related to a missing signing key, you can ignore it.


style: Brand color adjustments v2

Describe your changes
Recommit do to problems when signing the commit
Some adjustments to the brand colors and the brand color tokens.
Issue ticket number and link

Fixes #(issue)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have verified that the code builds perfectly fine on my local system
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have verified that my code follows the style already available in the repository
[x] I have made corresponding changes to the documentation

darn


[Bugfix] fix #1013 TERM="xterm-256color" not recognized anymore on FreeBSD

Description
In FreeBSD (My version is FreeBSD 11.2), tput colors is the same as tput co, it returns the number of columns instead of the number of colors.  tput Co returns the number of colors.
But in other OS, like my MacBook, tput Co failed to be executed.  So some kind OS based logic has to be introduced to use difference terminfo capability at difference OS.
This PR use tput Co for and only for FreeBSD, use original tput colors otherwise.

I've fixed this bug in Powerlevel10k in a portable way: https://github.com/romkatv/powerlevel10k/blob/b404c1b54e5c0e0ce978e4839c828171178ee824/internal/p10k.zsh#L2673. Feel free to backport the fix to Powerlevel9k.
(I usually open an issue against Powerlevel9k for every bug that I fix in Powerlevel10k but this time apparently I forgot to do so.)

@romkatv has a better, OS independent solution.
Thx.


Pinned rspec-puppet to 2.3.2

This is only a temporary measure, as once module-sync runs, this file will be overwritten. This is to make the rspec tests go green until we add support for rspec_puppet 2.4.0

Replaced by #234


You can leave references with no text

From the title of this issue and the fact that this is assigned to backend I assume that @lucaslcode expects BE to throw an exception if the text of a referece is empty (or contains entirely of whitespace?).
@aapeliv is that the way references should work? I can imagine that the 'reference' object can be used in the future just contain a rating without having an explicit text. If that would be something we consider, I would suggest that doing the validation on empty reference text should be in the frontend, since on the frontend we can be more flexible about whether we always want to have this text or not. Also, you can probably alert the user in a nicer way that their reference text should be filled in.

Changing the status to 'wontfix' for now until we have a final decision on how we want to handle empty reference text.

From the title of this issue and the fact that this is assigned to backend I assume that @lucaslcode expects BE to throw an exception if the text of a referece is empty (or contains entirely of whitespace?). @aapeliv is that the way references should work?

Yes, I think it should be done that way.

I can imagine that the 'reference' object can be used in the future just contain a rating without having an explicit text. If that would be something we consider, I would suggest that doing the validation on empty reference text should be in the frontend

If we change it in the future, we will have to update both backend and frontend regardless. The final onus on validation is on backend; anything frontend does is just a courtesy and for UX. If we change references to eventually not require text; then that should have text be NULL, not an empty string, and they'll probably require a bunch more updating elsewhere too. In this situation I'd say it's better to design/implement for the current use case; it's not like removing that check if we decide to implement rating-only refs is a huge architectural decisions.

Additional note, backend can't trust the frontend for validation since the API is public

Sure, will fix it. If you are not interested in taking part in a discussion on software-design theory, stop reading here ;)
On a principal basis I would disagree on the necessity of this. I would say that a backend should validate things that are intrinsic to the consistency of an entity. For instance, without a user to which a reference is directed, a reference is not a reference, so backend should definitely check that. A reference with its text set to an empty string would not be inconsistent IMO, just somewhat useless.
In practice that idea would mean that if someone would bother to bypass our frontend to leave an empty reference, that would only lead to that reference being ugly and the person receiving that reference thinking that user is weird. I would say that is an acceptable consequence.

Counterpoint, if someone decides to make a Couchers client and people start using it (like Reddit), but they don't implement all the same frontend checks, we start getting our client and backend polluted with ugly objects.
Alternative counterpoint, the design states that there is a private part to the reference (rating, was appropriate) and a public part (the text), having the text blank is violating the design.

Or worse, the alternative client has a bug - users enter the text, but an empty string is always sent to the backend!

On a principal basis I would disagree on the necessity of this.

Why do you think so?
I really think the backend should be validating not only db-level consistency but also business logic–level rules.
This also makes our life easier: we will soon be supporting 3 platforms, and having final business logic checking in the backend will make our lives easier if we fail to do something in one of the frontends.

I would say that is an acceptable consequence.

Are you sure? I think it'd be pretty bad to have a bunch of "ugly" objects in the db, and users opening bugs because the "reference wasn't loading"!

I really think the backend should be validating not only db-level consistency but also business logic–level rules.

I would draw the destinciton not between db-level/business logic but between 'is this intrinsic to the conceptual entity or not'. If we would take this a step further, we could say that a refrence below 10 characters would be bad and something we want to discourage, but it would still be a 'valid' reference, since it has all the properties necessary to process it, display it and execute any methods on it that we have. In that case I would argue that it is fine that the validation/"discouragement" of having very short refrences happens in the frontend, particularly when bypassing the frontend would exclusively mess up entities owned/created by the one messing with our frontend.
But yeah, I get that in this case we would say that it is part of our definition of a 'reference' that it has non-empty text, since our design might break if we have empty text. My main point would be that the "is it part of a defintion"-check should be the bar for backend validations, rather then always duplicating all validations on frontend and backend.

Simplicity and consistency is key. We want to not have to think case-by-case about what gets validated in the bg vs fgs. We now have two levels of validation logic: db-level and business logic–level. We don't want a third level somewhere in the middle. We want as few combinations of everything as possible. Sure, it doesn't lead to edge cases that crash the app, but it does lead to edge cases that are "buggy" and cause bad user experience (e.g. getting an email that says Aapeli just wrote you a reference, they said: "" just looks buggy and will be reported by users).
What about display names? It's exactly the same. People will definitely think the app is buggy and crappy if there are user without a display name. That'd also lead to visual bugs, and we don't want the frontend to be coding a bunch of stuff that says "displayName.length > 0 ? displayName : 'Missing name'", because that's what they'll be forced to do if we start having these kinds of things happen.

particularly when bypassing the frontend would exclusively mess up entities owned/created by the one messing with our frontend

So the programming decision of where to do the checking would be "if the entity being messed up only affects the user themselves, then defer it to the frontend, otherewise consider whether it's required for the consistency of the entity in some abstract sense, if so, then add a backend check as well"? It's way too complicated and will lead to bugs.
Also, a user writes references to other people: it shows up in the other user's page, so it messes up "their" page.

My main point would be that the "is it part of a defintion"-check should be the bar for backend validations, rather then always duplicating all validations on frontend and backend, so would be a valid reason forme.

Again, the backend is the validator and handles the business logic. The frontend stuff is just there to catch obvious things to reduce extra network requests and make the user experience easier (e.g. easily catching an email that looks wrong, etc).

So the programming decision of where to do the checking would be "if the entity being messed up only affects the user themselves, then defer it to the frontend, otherewise consider whether it's required for the consistency of the entity in some abstract sense, if so, then add a backend check as well"? It's way too complicated and will lead to bugs.

So, I think that is a conceptual difference in thiking about software. I would say that ideally first you have an abstract idea of an entity (a user, a reference, etc), which is then translated to flows and designs and eventually to software. That concept of a reference should not change often, while some aspects of what people do with references or how we show them will change a lot more often. Based on that concept you know which things we will always asume that the entity will have (in this case a reference will always have text, a user it is sent to, a reference giver, a (valid) date...) which we can assume will always be true so we can take them for granted in our software.
The 'harm' in doing duplicate checks on backend and frontend is that you duplicate business logic, which means that they can start differing from eachother, leading to a buggy experience. Clearly the harm of this duplication is outweighed by the benefits of backend-checks when it comes to corrupt data or safety, but if there is the check is more of a design addition then I don't think that is the case.
To me this is somewhat of a border-line case, so I'm not arguing about this specific case ;) And I get that within the couchers we draw the line on 'backend does all validation'. I was just starting a flame-war on this because to me it is a nice example to talk about software design philosophy.

I think we can best agree to disagree here, since I feel that we are going in circles a bit and I am  not disputing the call in this particular instane. Woud still be happy to talk about this a bit mroe when we have

We need to strike a balance between designing for what we need now (current version) and extensibility (being able to add what we might reasonably wish to add). It's quite rare in CRUD apps, in particular with these basic models, that you need to consider extensibility too much. Extensibility really comes when you're trying to design a feature as a whole and the structure of tables, etc; not so much for these kinds of fields that go within them.

This comment scares me a little bit. I think what we currently have is moving quickly beyond a 'simple CRUD' app. I am afraid that not having clear definitions of what entity is reponsible for containing which information is going to lead to heaps of trouble. If I look at the 'User' table and I see that one entity has the users name and a boolean 'wheelchair_accessable' on the exact same level, I am a bit worried about the scope of what we believe that entity should be responbile for.
Anyhow, I will get back to doing actual things now. I think it is good to have discussions like this on our software design philosophy, so thanks guys for joining in <3


config: Add resources to enable Prometheus Monitoring

Signed-off-by: Anmol Sachan<EMAIL_ADDRESS>Tested in the openshift-storage namespace.

@umangachapagain @jarrpa Please review.

@anmolsachan the content looks good to me. Can you pls separate these changes into 2 commits first one for the code you edited and the second one for the generated code also please change the type of commit refer https://github.com/red-hat-storage/odf-operator/blob/main/CONTRIBUTING.md

Ack, Thanks for the review. I will update.

/ok-to-test

@iamniting Please review. I have updated the PR as requested.

@anmolsachan It looks like there is a problem with some YAML files. Can you pls look at them and push changes if make bundle works locally.

@iamniting I found the issue finally. Was just a simple string. Somehow wasn't visible to me. Thank you for it. Please review

@anmolsachan thanks for fixing it, I see one more problem in the first commit. also, I would like to see Output of make bundle. in the body of your second commit-msg.

@anmolsachan thanks for fixing it, I see one more problem in the first commit. also, I would like to see Output of make bundle. in the body of your second commit-msg.

@iamniting I added the output of make bundle in the second commti, but it's too long. Please let me know if you need me to remove it.

@anmolsachan thanks for fixing it, I see one more problem in the first commit. also, I would like to see Output of make bundle. in the body of your second commit-msg.

@iamniting I added the output of make bundle in the second commti, but it's too long. Please let me know if you need me to remove it.

@anmolsachan I mean something like this, not the whole output.

@iamniting Fixed it. Please review.

/override ci/prow/odf-operator-bundle-e2e-aws


Add shonfeder as admin

Motivated by the need to investigate https://github.com/ocaml/opam-repository/pull/26650#issuecomment-2418317418

Thanks!


Shared project

Hi,
I am trying to incorporate this to my share project but once I am implementing/extending  IMenuContainerPage or MenuContainerPage, it cant be resolve. The type or namespace could not be found. Can you confirm that this supports Shared Project?
Thanks

Did you check your shared project references all dlls? You need to include both PCL and native dlls.


Add more accurate epoch perf tests

Motivation
Ensure that our performance tests reflect real network conditions. Also add test for hypotetical worst network conditions so we aren't caught by surprise and our client crashes.
Description

Analyze network conditions https://github.com/ChainSafe/lodestar/pull/2979
Add normal case + worst case for each expensive epoch transition step

About length (push / pr):

Spec tests: 7m 59s / 8m 31s
Sim test: 12m 16s / 12m 9s
Tests: 10m 31s / 10m 49s


oneOf, anyOf, allOf, not implemented?

Hello,
I'm trying to use the OpenAPI feature to have a request body which is able to receive 2 or more types of body object structures, e.g:
(As mentioned here: https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/#oneof)
Paths:
paths:
  '/pets':
    get:
      summary: List pets
      description: Find a list of pets
      responses:
        '200':
          description: OK
          content:
            application/json:
              schema:
                type: array
                items:
                  $ref: '#/components/schemas/Pet'

    post:
      summary: Spawn animal
      requestBody:
        content:
          application/json:
            schema:
              oneOf:
                - $ref: '#/components/schemas/Cat'
                - $ref: '#/components/schemas/Dog'
      responses:
        '200':
          description: OK

With corresponding components:
components:
  schemas:

    Pet:
      type: object
      properties:
        id:
          type: integer
          format: int64
          example: 4

    Dog:
      type: object
      properties:
        id:
          type: integer
          format: int64
          example: 4
        bark:
          type: boolean
        breed:
          type: string
          enum: [Dingo, Husky, Retriever, Shepherd]

    Cat:
      type: object
      properties:
        id:
          type: integer
          format: int64
          example: 4
        hunts:
          type: boolean
        age:
          type: integer

I try to send this object:
{"id":423,"bark":true,"breed":"Dingo"}

Because currently I'm getting this error:
HTTP status: 400
{
  "err": [
    {
      "keyword": "oneOf",
      "dataPath": ".requestBody",
      "schemaPath": "#/properties/requestBody/oneOf",
      "params": {
        "passingSchemas": [
          0,
          1
        ]
      },
      "message": "should match exactly one schema in oneOf"
    }
  ]
}

Hi @kaasdude !
Looks like the error message is correct. If you have a look at it, it says that both your schemas are passing and it's expecting only one to pass.
This is because by default in JSON schema, additionalProperties is set to true. You need to explicitly state additionalProperties: false for both your object schemas to correctly validate this. Alternatively, you can use anyOf instead of oneOf.
See https://json-schema.org/understanding-json-schema/reference/object.html

Thanks! Silly me. Works like a charm!

Just want to add an extra piece of info here, if someone also experiences it. I had multiple responses. Thinking that it would match the 200 responses, but it matched 2 responses. I had to make each of the 400, 403, 500 error properties required so that when it matches the data, it picks the 200 response type.


move signature help container above current input line

I'm not sure if it's related, but I have this artifact:

Signature help is shown above the line and a symmetric empty box is shown below.

I tried removing the lines added in this commit and it did fix my issue: I see only one box with signature help below the line.


Add option to darken / blur images

Is your feature request related to a problem? Please describe.
Add ability to darken / blur images
Describe the solution you'd like
Add CLI options such as bdw --darken 0.5 --blur 10 (darkens by 50% and adds 10px of blur)
Describe alternatives you've considered
Additional context
@ZibanPirate is this project still in development? :O

Hi @Myzel394 , thank you for your suggestion, I like the idea, I will look at how to implement this, maybe using image-blur-gaussian.
Feel free to create a PR if you don't want to wait a bit, I'm currently a little bit busy.


getFirstPinLocation API Break

Describe the bug
In earlier versions of OpenROAD, the Python API for BTerm::getFirstPinLocation would simply return a tuple of three objects: a boolean representing success or failure and two integers. In the most recent version, however, the Python API seems to have a bug where it requests two values by reference. Requesting integers by reference is not possible in Python.
Expected Behavior
The API should remain consistent with earlier versions of OR.
Environment
Git commit: 4ca23914299f8281ec1b2bb14d5b2a18440fbc6f
kernel: Linux 5.15.0-1025-gcp
os: Ubuntu 20.04.4 LTS (Focal Fossa)
cmake version 3.22.2
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
clang version 10.0.0-4ubuntu1

To Reproduce
Run run.sh inside the folder. repro.tar.gz
Relevant log output
OpenROAD v2.0-6404-g4ca239142
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
Design name: spm
HERE <odb.dbBTerm; proxy of <Swig Object of type 'odb::dbBTerm *' at 0x7f7343378ba0> >
Traceback (most recent call last):
  File "./diodes.py", line 416, in <module>
    cli()
  File "/home/donn/.local/lib/python3.8/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/donn/.local/lib/python3.8/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/donn/.local/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/donn/.local/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/donn/.local/lib/python3.8/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/donn/OpenLane/repro/reader.py", line 76, in wrapper
    function(**kwargs)
  File "./diodes.py", line 374, in place
    di.execute()
  File "./diodes.py", line 284, in execute
    src_pos = self.net_source(net)
  File "./diodes.py", line 101, in net_source
    good, x, y = bt.getFirstPinLocation()
TypeError: getFirstPinLocation() missing 2 required positional arguments: 'x' and 'y'

Screenshots
No response
Additional Context
No response

@macd I think this relates to the odb change in .i that I hightlighted in your pdn PR

Yes, it sure does. I just fixed it and will push soon.

Fixed with https://github.com/The-OpenROAD-Project/OpenROAD/pull/2730


Allow to add our own actions but not overwrite the workbench ones?

Hello and thanks for the template,
How can we add our own action to our repo (that updates the figures of our lessons with current data)? The PR bot prevents us from doing this. Could it really be malicious if we don't touch the carpentries actions?
Have a lovely day,

Hello again, @ManonMarchand!

How can we add our own action to our repo (that updates the figures of our lessons with current data)?

There are two ways:

add a custom workflow file and give it the .yml extension (not .yaml). This will prevent the update-workflows.yaml action from destroying that file. OR
add the action inside the sandpaper-main.yaml workflow file and continuously monitor the diffs of that file for changes.

The PR bot prevents us from doing this. Could it really be malicious if we don't touch the carpentries actions?

The PR bot does not prevent you from doing this per se, it gives you strong warnings if you try to modify content and workflows at the same time (e.g. https://github.com/carpentries-incubator/bioc-intro/pull/97#issuecomment-1540622467). The rationale behind this can be found in The "Risk Mangement" section in the documentation. The protections are less for The Carpentries Infrastructure (sensitive data is not accessible through the lessons or the tokens used to generate pull requests) and more of good practices in general.
That being said, if you are the one submitting the PR, then you can be reasonably confident that the workflows are correct and you can ignore any warnings like that.

This is also somewhat related to https://github.com/carpentries/sandpaper/issues/267

Thanks a lot for the detailed answer! :)
On my side, this issue can be closed


feat(mobile): notify mobile layer of thread updates

also fixes some goroutine in loop bugs

Refactored this to take a generic Event struct, not core.ThreadUpdate, which means a) mobile frameworks don't need core package, and Messenger can be used for any event. The bridges just pass on event name and the un-serialized payload object (NSDictionary / WritableMap)

okay guys, this is g2g


Wrong HashAlgorithm in example 3

Hello,
The description for that example specifies that the hashalgorithm is SHA256 while the actual code says SHA1. This could lead to issues when copy pasting.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3e97ed95-5f4c-da95-206a-2f7a6bc050a7
Version Independent ID: 3e8d8dc6-b877-22f5-4318-33479174d9fd
Content: Install-AdcsCertificationAuthority (ADCSDeployment)
Content Source: docset/winserver2012r2-ps/adcsdeployment/install-adcscertificationauthority.md
Product: powershell
Technology: ****
GitHub Login: @Kateyanne
Microsoft Alias: v-kaunu

Thank you for the catch. An independent contributor is going to follow up with revisions accordingly.


Tech Preview Blog Post

from my pov, my latest draft is good to go. it's huge, but by front-loading the interesting stuff, i don't think it matters that it sprawls at the end. i suggest we put it on both matrix.org/blog and on the thirdroom landing page.

(need images and videos tho, once we have them)


Fixed #29448 -- Added a management command for creating management commands.

Includes refactoring the management template to allow for more than just app and project

https://code.djangoproject.com/ticket/29448

Closing based on comments in the original issue.

Django Extensions already implements a create_command command, which sets up the folders and puts a command scaffolding in (that looks like this).


Vagrant up hangs indefinitely

Running your VAGRANT_LOG=debug vagrant up --provider aws seems to create the instance correctly, but it just hangs and never returns. If I terminate it, then it tries to shutdown and terminate the instance, so I can't actually use it. Am I missing something?

Can you post the stdout? In the end you have or not an instance in aws? I am using this plugin every day and it's working. Where is it pending?
Thanks!

Nevermind. I was able to get it working.


Update to Instagram Basic Display API

As announced here [1] Instagram is deprecating its Legacy API to move to a Graph API.  On March 31, 2020 the Legacy API will be shut down rendering the current code of this plugin functionless since the Resource Owner will be no longer available via the used Legacy API using https://api.instagram.com/v1/users/self (or at least this is how I understand it; I find the information on this a bit confusing...).
This PR is introducing support for the new Graph API using the Instagram Basic Display API [2].
Naturally since there are significant changes in the API and this plugin can only support the capabilities the underlying API offers there are some breaking changes especially the removal of some shot-hand functions to attributes of the Resource Owner which are no longer available via the Basic Display API. See the Readme.
[1] https://developers.facebook.com/blog/post/2019/10/15/launch-instagram-basic-display-api/
[2] https://developers.facebook.com/docs/instagram-basic-display-api

Thanks for this @acran. The CI build was failing because of some outdated test configuration. I updated this config on master branch and it now has conflicts with your branch. If you don't mind, rebase your branch and push it back up. I'll review it promptly.

Hi @stevenmaguire, I now rebased my changes on top of the new master and all CI checks are passing now. Ready for review :+1:

Looks good. Thanks!


consolidate Keep Pace feat into one

Merged the two feats.
NOTICE - I did not add an Item Alteration to the description as the text output will not recognize the HTML formatting tags.
updated the journal entries for the Bounty Hunter and Game Hunter to reference the merged feat.

Markdown!

Let's see if this works


chore: bump deps

Summary
I've updated all dependencies except the ones dropping support for node 10 (so - zero user facing ones 😅)

Test plan
Green CI

Codecov Report

Merging #11419 (fc0262e) into master (a4358d6) will increase coverage by 5.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11419      +/-   ##
==========================================
+ Coverage   64.22%   69.33%   +5.10%
==========================================
  Files         309      311       +2
  Lines       13519    16241    +2722
  Branches     3294     4700    +1406
==========================================
+ Hits         8683    11260    +2577
- Misses       4122     4953     +831
+ Partials      714       28     -686

Impacted Files
Coverage Δ

packages/jest-core/src/collectHandles.ts
57.89% <ø> (+18.31%)
:arrow_up:

packages/jest-reporters/src/BaseReporter.ts
53.84% <0.00%> (-26.16%)
:arrow_down:

packages/jest-validate/src/exampleConfig.ts
16.66% <0.00%> (-8.34%)
:arrow_down:

packages/jest-haste-map/src/watchers/common.js
33.33% <0.00%> (-6.07%)
:arrow_down:

packages/jest-worker/src/workers/messageParent.ts
38.46% <0.00%> (-3.21%)
:arrow_down:

packages/jest-reporters/src/VerboseReporter.ts
19.17% <0.00%> (-2.86%)
:arrow_down:

packages/jest-core/src/TestWatcher.ts
54.54% <0.00%> (-2.60%)
:arrow_down:

...ges/jest-haste-map/src/watchers/FSEventsWatcher.ts
10.44% <0.00%> (-2.28%)
:arrow_down:

...ckages/jest-config/src/ReporterValidationErrors.ts
9.52% <0.00%> (-2.25%)
:arrow_down:

packages/jest-watcher/src/lib/Prompt.ts
73.91% <0.00%> (-2.02%)
:arrow_down:

... and 244 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4358d6...fc0262e. Read the comment docs.


dart analyze yields different results on macos and linux

Here is an example run on linux that produces warnings:
https://github.com/flutter/devtools/actions/runs/6803035154/job/18497485917?pr=6673
Running dart analyze on macos does not show any warnings: https://github.com/flutter/devtools/actions/runs/6803718135/job/18499691597?pr=6676
I have reproduced this locally as well
Flutter and Dart SDK versions:
 > /Users/kenzieschmoll/develop/flutter/bin/flutter --version
Flutter 3.17.0-3.0.pre • channel [user-branch] • unknown source
Framework • revision 5ff09c27f8 (35 hours ago) • 2023-11-07 03:35:26 -0500
Engine • revision 99149d59cb
Tools • Dart 3.3.0 (build 3.3.0-102.0.dev) • DevTools 2.30.0-dev.1
 > dart --version
Dart SDK version: 3.3.0-102.0.dev (dev) (Mon Nov 6 20:04:51 2023 -0800) on "macos_x64"

The CI jobs in the two logs pasted use two different versions as well:

https://github.com/flutter/devtools/actions/runs/6803035154/job/18497485917?pr=6673 (linux) says "flutter-sdk-Linux-refs/tags/3.17.0-3.0.pre"
https://github.com/flutter/devtools/actions/runs/6803718135/job/18499691597?pr=6676 (macos) says "flutter-sdk-macOS-refs/tags/3.17.0-4.0.pre"

It is interesting that you reproduce the macos state (no warnings) locally with "Flutter 3.17.0-3.0.pre". 😦

Oh yep looks like a version bump snuck into the run I linked. I did repro this locally with Flutter 3.17.0-3.0.pre on both linux and mac

Are these logs from presubmit CI runs? I'd like to see the PRs; we need to see what the language version is in all of those files.

Yep they are from CI runs on PRs
linux: https://github.com/flutter/devtools/pull/6673
macos: https://github.com/flutter/devtools/pull/6676

With new flutter version, the analysis errors matched what I saw on linux with Flutter 3.17.0-3.0.pre: https://github.com/flutter/devtools/pull/6694

Is this solved then? Some transient problem that is cleared now?

Yeah we can probably close this. It should repro on Flutter 3.17.0-3.0.pre, but went away with Flutter 3.17.0-4.0.pre, so not sure it's worth investigating.


[FLINK-14006][python][docs] Add documentation for how to specify JAR file when submit python jobs

What is the purpose of the change
Currently, we only have documentation on how to using the Java UDF APIs in Python, but do not mention how to add the JARs to the classpath. This pull request adds documentation on how to specify the user Jar file through the command line when submitting python jobs.
Brief change log

Add documentation for how to specify JAR file when submitting python jobs

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@hequn8128 Thanks a lot for the PR. LGTM. +1

@dianfu Thanks a lot for the review. Merging...


Readme and/or wiki should give increased explanations of how to install/configure container software

Hello, lovely tool you've got here. But it all depends on using a container software. Docker, or Podman.
The readme is very light on explanations of how to make those tools ready for use by cross.
After installing cross and realizing that maybe (?) I can't easily get those running on Windows I got on a linux machine and then had a fun 15 minute struggle to get docker to go. Even then, I apparently did it wrong, because i used the docker group, and i guess there's some alternate "rootless mode" thing i should have used instead? I don't know, it's fine.
My point is this: you don't need to write your own full guide on how to install and set up docker (though that would be nice because your readme is nicely written so someone has some skills), but if you don't write such a guide you should please at least find some guide elsewhere that covers all the details and then clearly link to that guide in the readme, right at the top.
Like:

If you have not used Docker before Read This Setup Guide First!

and then that bold part is the words that would be the link.

You don't need rootless mode, although we support it. What's the host machine? You said Windows first, which actually has full support for Docker Desktop with the WSL2 backend. You can also use Linux with the Docker install, and either use sudo, add to the docker group, or rootless mode. If you use rootless however with cross, you need to specify it since by default we assume rootful mode for Docker.

We can probably add some documentation on the Wiki though with setup though, since Docker Desktop is the preferred way for Windows/macOS, and Linux Podman is probably the easiest (although Docker is the best tested).

What's the host machine?

I usually use Windows, but I also have easy enough access to an x86_64 linux, an aarch64 linux, an an x86_64 mac.

actually has full support for Docker Desktop with the WSL2 backend.

I've never heard of docker desktop, and actually i also don't remember how to even turn on wsl2, though maybe i installed it once long ago.

We can probably add some documentation on the Wiki though with setup though

Awesome, yeah.
I don't myself need more setup support, I think I've got it working now. However, I suspect that most people coming to cross for the first time have next to no background with any of the special terms you're using very casually. I'm not saying you've done anything wrong directly, but it's very easy to forget how much you really know, and so how much others don't yet know and will need to be told about.
I read the top few paragraphs of the readme two or three times, gave up on understanding it entirely, just tried to install stuff that sounded right, and googled for answers, and eventually it worked after 15 minutes.  But I bet there's a better way, so the next new user could have a simpler time.

I've added a more detailed installation guide to the wiki. Let me know if you see any issues with it or something isn't clear.

That's amazing, I love it!


Hash API keys locally

This is a no-brainer since API keys are essentially all-access passwords.

It's been fixed.


Blog app: add devise

Hi there 👋,
In this particular project, I :

Remove current_user method in ApplicationController, devise will provide us with one.
Install and setup devise.

Can register a new user.
User logs in with a combination of email and password.
Hashed password should be stored in the database.
Ask for confirmation of email.
Can reset password.

Modify the views in devise for registration and login to match the wireframes from the Sneak Peek and your styling.

Hi,
After clicking the Sign_out button, kindly, you need to refresh the page

Thank you @mikethreels


[flann] Build x64-mingw-dynamic error

Host Environment

OS: Windows
Compiler: revision
vcpkg-tool version: 2022-10-17-3247920fbdd47d08f36cbd480addd9890d3c2435
vcpkg-scripts version: 68ad399d5 2022-11-04 (15 hours ago)

To Reproduce
Steps to reproduce the behavior:
`./vcpkg install flann:x64-mingw-dynamic
Failure logs

Cut and paste the appropriate build messages from the console output.

CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:131 (message):
Command failed: "D:/Program Files/CMake/bin/cmake.exe" --build . --config Debug --target install -- -v -j9
Working Directory: D:/CODEing/package_install/vcpkg/buildtrees/flann/x64-mingw-dynamic-dbg
See logs for more information:
D:\CODEing\package_install\vcpkg\buildtrees\flann\install-x64-mingw-dynamic-dbg-out.log
Call Stack (most recent call first):
installed/x64-mingw-dynamic/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
installed/x64-mingw-dynamic/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
ports/flann/portfile.cmake:34 (vcpkg_cmake_install)
scripts/ports.cmake:147 (include)
error: building flann:x64-mingw-dynamic failed with: BUILD_FAILED
error: Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+flann
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[flann]+Build+error
Include '[flann] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
vcpkg-tool version: 2022-10-17-3247920fbdd47d08f36cbd480addd9890d3c2435
vcpkg-scripts version: 68ad399d5 2022-11-04 (15 hours ago)

Attach every failure log file mentioned in the console output.
[1/5] D:\Qt\Qt5.14.2\Tools\mingw730_64\bin\x86_64-w64-mingw32-g++.exe -DFLANN_EXPORTS -D_FLANN_VERSION=1.9.1 -ID:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp -isystem D:/CODEing/package_install/vcpkg/installed/x64-mingw-dynamic/include -g   -Wall -Wno-unknown-pragmas -Wno-unused-function -MD -MT src/cpp/CMakeFiles/flann_cpp.dir/flann/flann_cpp.cpp.obj -MF src\cpp\CMakeFiles\flann_cpp.dir\flann\flann_cpp.cpp.obj.d -o src/cpp/CMakeFiles/flann_cpp.dir/flann/flann_cpp.cpp.obj -c D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/flann_cpp.cpp
In file included from D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/util/params.h:33:0,
from D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/flann.hpp:42,
from D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/flann_cpp.cpp:30:
D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/util/any.h: In member function 'virtual void flann::anyimpl::big_any_policy::static_delete(void**)':
D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/util/any.h:81:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (* x) delete (* reinterpret_cast<T**>(x)); x = NULL;
^~
D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/util/any.h:81:55: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
if ( x) delete (* reinterpret_cast<T**>(x)); x = NULL;
^
[2/5] cmd.exe /C "cd . && D:\Qt\Qt5.14.2\Tools\mingw730_64\bin\x86_64-w64-mingw32-g++.exe -g   -shared -o lib\libflann_cppd.dll -Wl,--out-implib,lib\libflann_cppd.dll.a -Wl,--major-image-version,1,--minor-image-version,9 src/cpp/CMakeFiles/flann_cpp.dir/flann/flann_cpp.cpp.obj  D:/CODEing/package_install/vcpkg/installed/x64-mingw-dynamic/debug/lib/liblz4d.dll.a  -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 && cd ."
[3/5] D:\Qt\Qt5.14.2\Tools\mingw730_64\bin\x86_64-w64-mingw32-g++.exe -DFLANN_EXPORTS -D_FLANN_VERSION=1.9.1 -ID:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp -isystem D:/CODEing/package_install/vcpkg/installed/x64-mingw-dynamic/include -g   -Wall -Wno-unknown-pragmas -Wno-unused-function -MD -MT src/cpp/CMakeFiles/flann.dir/flann/flann.cpp.obj -MF src\cpp\CMakeFiles\flann.dir\flann\flann.cpp.obj.d -o src/cpp/CMakeFiles/flann.dir/flann/flann.cpp.obj -c D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/flann.cpp
FAILED: src/cpp/CMakeFiles/flann.dir/flann/flann.cpp.obj
D:\Qt\Qt5.14.2\Tools\mingw730_64\bin\x86_64-w64-mingw32-g++.exe -DFLANN_EXPORTS -D_FLANN_VERSION=1.9.1 -ID:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp -isystem D:/CODEing/package_install/vcpkg/installed/x64-mingw-dynamic/include -g   -Wall -Wno-unknown-pragmas -Wno-unused-function -MD -MT src/cpp/CMakeFiles/flann.dir/flann/flann.cpp.obj -MF src\cpp\CMakeFiles\flann.dir\flann\flann.cpp.obj.d -o src/cpp/CMakeFiles/flann.dir/flann/flann.cpp.obj -c D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/flann.cpp
In file included from D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/util/params.h:33:0,
from D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/flann.hpp:42,
from D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/flann.h:603,
from D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/flann.cpp:31:
D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/util/any.h: In member function 'virtual void flann::anyimpl::big_any_policy::static_delete(void*)':
D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/util/any.h:81:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (* x) delete (* reinterpret_cast<T**>(x)); x = NULL;
^~
D:/CODEing/package_install/vcpkg/buildtrees/flann/src/638c8c7d9d-421926f7bb.clean/src/cpp/flann/util/any.h:81:55: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
if ( x) delete (* reinterpret_cast<T**>(x)); *x = NULL;
^
D:/Qt/Qt5.14.2/Tools/mingw730_64/bin/../lib/gcc/x86_64-w64-mingw32/7.3.0/../../../../x86_64-w64-mingw32/bin/as.exe: src/cpp/CMakeFiles/flann.dir/flann/flann.cpp.obj: too many sections (144650)
C:\Users\ADMINI~1\AppData\Local\Temp\ccnSEPRS.s: Assembler messages:
C:\Users\ADMINI~1\AppData\Local\Temp\ccnSEPRS.s: Fatal error: can't write 610 bytes to section .text of src/cpp/CMakeFiles/flann.dir/flann/flann.cpp.obj: 'File too big'
D:/Qt/Qt5.14.2/Tools/mingw730_64/bin/../lib/gcc/x86_64-w64-mingw32/7.3.0/../../../../x86_64-w64-mingw32/bin/as.exe: src/cpp/CMakeFiles/flann.dir/flann/flann.cpp.obj: too many sections (144650)
C:\Users\ADMINI~1\AppData\Local\Temp\ccnSEPRS.s: Fatal error: can't close src/cpp/CMakeFiles/flann.dir/flann/flann.cpp.obj: File too big
ninja: build stopped: subcommand failed.

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

This issue hasn’t been updated in 3 month, if it is still an issue, please reopen this issue.


Multiple input-sm height problem

Hi,
thank you for the great job.
I have a problem with the class "input-sm" combined with multiple choices: i can't obtain the right height.
You can see the problem here: https://codepen.io/policchio/pen/dOPLdp
If I try to delete "height: auto" in the class ".select2-selection--multiple" I obtain the right height, but obviously the wrong behaviour.
Thank you in advance!

Hi @policchio!
Always include select2-bootstrap.css after select2.css, then your issue will go away.
Fixed CodePen here: https://codepen.io/fk/pen/MpzwKp


Add different ml

Add new machine learning models to predict the following languages

Russian
Korean

Add new route and restructure the existing ones to consider different models depending on the language (/{language}/)

More test to the models, and try to find a more accurate network to predict characters


chore: Scanner 2.30.6

Description
Bump Scanner to 2.30.6. This mitigates HTTP/2 Rapid Reset in Scanner.
Checklist

[x] Investigated and inspected CI test results
~[ ] Unit test and regression tests added~
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

Testing Performed
CI

/retest


Exposure kMaxLength and SlowBuffer

ISSUE: https://github.com/davidmyersdev/vite-plugin-node-polyfills/issues/75

For completion sake, should maybe export INSPECT_MAX_BYTES as well. We ran into this issue also and I checked out the chunks that were generated before the change in 0.18.0 and I see the following were exported then:
exports.Buffer = Buffer2;
exports.SlowBuffer = SlowBuffer;
exports.INSPECT_MAX_BYTES = 50;
var K_MAX_LENGTH =<PHONE_NUMBER>;
exports.kMaxLength = K_MAX_LENGTH;

So it looks like Buffer, SlowBuffer, kMaxLength, and INSPECT_MAX_BYTES were what was exported before.

There were some conflicts, so I manually merged this via https://github.com/davidmyersdev/vite-plugin-node-polyfills/commit/b981b7ab2b102119aef35e98878d4afbe94808a0.


Compile 1.9 TrainCarts

Is there anyway to compile and download the 1.9 branch of TrainCarts? I really need it for my 1.9 server ASAP.

Not gonna happen. Or you need to write & update it yourself.
-mg_1999


Alphabetical list has translation problems.

The alphabetical list is not ordered correctly in translations.
It should be dynamically orderd by the localized names.
Please just stop those automatic translations. You obviously dont really care about the quality (this is not the first case i stumbled apon). And developers dont care either. The first click for me (and anyone on my team) is to get the english text. Please stop delivering the translated pages to google.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 12084832-5567-c723-2e87-aeaac920aa31
Version Independent ID: 7620ba4b-7bbd-0c1d-882f-374b9278a315
Content: Learn default and system work item field descriptions - Azure Boards
Content Source: docs/boards/work-items/guidance/work-item-field.md
Service: azure-devops-boards
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@jonas-delleske -- Jonas, thank you for your considered feedback.  You can submit issues related to overall site experience, or suggestions for improved site functionality or design, at https://aka.ms/sitefeedback.
I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


Inspector side scroll bar disappears

woe, unique glitch, Inspector Scroll bar disappears when viewing an "Animation Player Node" while the window is maximized. Reappears when not maximized.

I can hardly reproduce the issue, if I place the dock in such a manner that it would require a scroll bar, I reach the limit there:

If I put the dock a bit lower, there is then a scrollbar. So at the limit position there are indeed a couple pixels cut off at the bottom, but that's a very minor issue.

I propose to close it for now; if there's a real need to fix this cosmetic glitch, I guess a pull request will come :)


install failed

I was going to install rdkit for my native python in Ubuntu by following the steps in https://www.rdkit.org/docs/Install.html:
 Linux x86_64: Python 3 environment
The following commands will create a development environment for Linux x86_64 and Python 3.

Start by downloading the latest anaconda installer from Anaconda and install it. Then, install the required packages:

bash Anaconda3-5.2.0-x86_64.sh
conda install -y cmake cairo pillow eigen pkg-config
conda install -y boost-cpp boost py-boost
Numpy and matplotlib are already part of the base installation of anaconda. Due to the latest boost libraries being currently built with a GLIBC version higher than the default in anaconda, we need to update to a more recent version:

conda install -y gxx_linux-64
At this point, you should be able to clone the RDKit repository to the desired build location, and start the build. Please consider that it is necessary to indicate the path to the numpy headers for RDKit to find them, since anaconda hides them inside the numpy package:

git clone https://github.com/rdkit/rdkit.git
cd rdkit
mkdir build && cd build
cmake ..  But I failed in make install step.
Here is the information:
Install the project...
-- Install configuration: "Release"
CMake Error at CoordGen/cmake_install.cmake:136 (file):
file INSTALL cannot find
"/media/MyDataStor1/rdkit/lib/libRDKitcoordgen.so.1.2019.03.1b1".
Call Stack (most recent call first):
cmake_install.cmake:40 (include)
Very thankful for your help

Can you please share the exact command you used when you did make install and the name of the directory where you executed that command?
Also the output of: ls -l /media/MyDataStor1/rdkit/ and ls -l /media/MyDataStor1/rdkit/lib just to make sure that those exist.

Actually libRDKitcoordgen.so.1.2019.03.1b1 exists after make. But was deleted during make install, I use brute force method to set it as only readable file. And the problem resolved. The install is complete. But is there any bug in make install?

I haven't seen a problem like this before. When you did make install it must have copied the file somewhere. If you want to track it down, you could do VERBOSE=1 make install to see where it put the file.


[1.20.1-0.7.41r] Memory Card changes

Describe
I updated recently from 1.20.1-0.7.40r to 1.20.1-0.7.41r to fix #642
It seems like the change to Memory Cards is a bit broken

Save the owner of the memory card to the inventory manager after a player places the card into the manager and clear the card after. Resolves a security issue where players could eventually steal memory cards from other players

Steps to reproduce
When inserting a bound Memory Card into the Inventory Manager it clears the Memory Card as the feature change says, and saves to the block:
{
  ownerId: [I; -1172986723, 321014915, -1283924489, -1583910946],
  z: 4089,
  x: 9818,
  ForgeCaps: {},
  id: "advancedperipherals:inventory_manager",
  y: -10,
  Items: [
    {
      Slot: 0b,
      id: "advancedperipherals:memory_card",
      tag: {},
      Count: 1b
    }
  ]
}

Removing the blank card afterwards deletes the player link:
{
  z: 4089,
  x: 9818,
  ForgeCaps: {},
  id: "advancedperipherals:inventory_manager",
  y: -10,
  Items: []
}

Without removing the blank card, it appears that after some time, such as leaving and reloading the chunks, or restarting the server, that the Inventory Manager then reads the blank card still present, and also deletes the player link since the card is now "unbound".
Multiplayer?
Yes
Version
1.20.1-0.7.41r (Latest 1.20.1)
Minecraft, Forge and maybe other related mods versions
NeoForge 47.1.106 Minecraft 1.20.1
Screenshots or Videos
No response
Crashlog/log
No response

Thanks for reporting the bug, didn't realize about chunk load/unload before. Takeout inventory card to clean owner is expected btw

From a quick glance it appears to be this,
Loading NBT reads the "ownerId" UUID from the block, but it also afterwards calls to setItem
https://github.com/IntelligenceModding/AdvancedPeripherals/blob/c09b8c03c06a9f2b9898362083f401a794810313/src/main/java/de/srendi/advancedperipherals/common/blocks/blockentities/InventoryManagerEntity.java#L73-L80
The setItem method then checks the presence of the card, to which "ownerId" is not set on the card anymore so owner is set to null
https://github.com/IntelligenceModding/AdvancedPeripherals/blob/c09b8c03c06a9f2b9898362083f401a794810313/src/main/java/de/srendi/advancedperipherals/common/blocks/blockentities/InventoryManagerEntity.java#L54-L64

yep exactly


ARROW-4220: [Python] Add buffered IO benchmarks with simulated high latency, allow duck-typed files in input_stream/output_stream

These benchmarks will help track possible regressions in buffered IO performance from the Python side.
This also allows objects that implement the right APIs (at least according to hasattr) to be passed into these functions.

Perf I see writing 16MB with 1MB buffer and different levels of latency
[ 25.00%] ··· io.BufferedIOHighLatency.time_buffered_reads                                                                                ok
[ 25.00%] ··· ========= ==========
               latency
              --------- ----------
                  0      16.6±0ms
                 0.01    180±0ms
                 0.1     1.63±0s
              ========= ==========

[ 50.00%] ··· io.BufferedIOHighLatency.time_buffered_writes                                                                                ok
[ 50.00%] ··· ========= ==========
               latency
              --------- ----------
                  0      24.5±0ms
                 0.01    205±0ms
                 0.1     1.74±0s
              ========= ==========


testport -o is  weird

Today I had to play with testport to debug a port breakage. First of all testport -i is awesome (although it took me a while to figure this out because the name of the command didn't map my mental model of what I wanted to do.)
However, the point of this bug is to mention that the testport -o origin syntax is very strange. The reason is that bulk takes a list of ports in the form category/port as positional arguments without any flag... yet testport requires -o for some odd reason. Flags are often used to represent optional values, but in this case -o is not optional at all which in turn made things more confusing.
I do not know the reasons behind having a -o flag to represent the port to debug, nor I do not know why such flag is called "origin" instead of port name. There may be some historical reasons for this.
My suggestion would be to drop the -o flag from testport altogether and just accept the port to debug in category/port form as the only positional argument to the command.
(Issue #180 is related to this regarding the lack of symmetry between testport and bulk.)

"origin" is the proper name in the context of ports.
This bug likely is a duplicate of another. It's been requested before to make the -o optional. I'm not against doing so.

I've made -o optional. So now there's really no need to use it or add it to bulk!


fix: body used already error fix #340

Fix "body used already for" error message as json and text is called. Should fix https://github.com/nchaulet/node-geocoder/issues/340

Thanks for the contribution I will publish a new version with that change later this week

Hey @nchaulet, any chance you could release new version with this fix?

+1, I don't think a new version was published alongside my fix a few months ago. I've still been using my patch.
https://github.com/nchaulet/node-geocoder/commit/e225f77b1c2e7d09930309b1e0ac53e15bd88552

@nchaulet can you please publish a new version with my commit and the one from @kamieniarz ?

Just published a new version 4.4.0 with your changes