[FEATURE]

Description
Hey, I want to improve the below portion ui

And also I add the read more button yeah I know it's already added but it's not working properly.

Can you please assign it to me under the GSSOC'23?
Screenshots
No response
Additional information
No response

Description
Hey, I want to improve the below portion ui
And also I add the read more button yeah I know it's already added but it's not working properly.
Can you please assign it to me under the GSSOC'23?
Screenshots
No response
Additional information
No response

But why is the background picture not showing up on my end ;-;

Description
Hey, I want to improve the below portion ui
And also I add the read more button yeah I know it's already added but it's not working properly.
Can you please assign it to me under the GSSOC'23?
Screenshots
No response
Additional information
No response

You can go ahead on this!

Description
Hey, I want to improve the below portion ui
And also I add the read more button yeah I know it's already added but it's not working properly.
Can you please assign it to me under the GSSOC'23?
Screenshots
No response
Additional information
No response

You can go ahead on this!

thanks


Move kubernetes principal to package

Codecov Report

Merging #619 (1e14f7a) into main (6ac6b8c) will increase coverage by 2.36%.
The diff coverage is 78.94%.

:exclamation: Current head 1e14f7a differs from pull request most recent head b2a47c0. Consider uploading reports for the commit b2a47c0 to get more accurate results

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   56.63%   59.00%   +2.36%
==========================================
  Files          23       24       +1
  Lines        1552     1561       +9
==========================================
+ Hits          879      921      +42
+ Misses        597      562      -35
- Partials       76       78       +2

Impacted Files
Coverage Δ

pkg/challenges/challenges.go
67.68% <0.00%> (+12.23%)
:arrow_up:

pkg/identity/kubernetes/principal.go
80.35% <80.35%> (ø)

pkg/ca/fileca/load.go
68.96% <0.00%> (+10.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac6b8c...b2a47c0. Read the comment docs.


RuntimeError: copy_if failed to synchronize: device-side assert triggered

🐛 Bug

When I use the GCNConv in my codes, it happens.
batch_x
Out[6]: Batch(batch=[4368], edge_index=[2, 7456], x=[4368, 1])
batch_x_temp = self.embeddings(batch_x.x).squeeze()
batch_x_temp.shape
Out[9]: torch.Size([4368, 100])
self.gcn1(batch_x_temp, batch_x.edge_index)
RuntimeError: CUDA error: device-side assert triggered
the problem happens in norm in GCNConv
row, col = edge_index
row
Out[9]: tensor([18621, 18645, 18645,  ...,  4365,  4366,  4367], device='cuda:0')
col
Out[10]: tensor([18645,   903, 18621,  ...,  4365,  4366,  4367], device='cuda:0')
deg = scatter_add(edge_weight, row, dim=0, dim_size=num_nodes)
THCudaCheck FAIL file=/opt/conda/conda-bld/pytorch_1556653099582/work/aten/src/THC/THCCachingHostAllocator.cpp line=265 error=59 : device-side assert triggered
Traceback (most recent call last):
File "/root/anaconda3/lib/python3.6/site-packages/IPython/core/interactiveshell.py", line 2862, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "", line 1, in
F.relu(self.gcn1(batch_x_temp, batch_x.edge_index))
File "/root/anaconda3/lib/python3.6/site-packages/torch/nn/modules/module.py", line 493, in call
result = self.forward(*input, **kwargs)
File "/root/anaconda3/lib/python3.6/site-packages/torch_geometric/nn/conv/gcn_conv.py", line 95, in forward
self.improved, x.dtype)
File "/root/anaconda3/lib/python3.6/site-packages/torch_geometric/nn/conv/gcn_conv.py", line 85, in norm
deg_inv_sqrt[deg_inv_sqrt == float('inf')] = 0
RuntimeError: copy_if failed to synchronize: device-side assert triggered

Expected behavior

Environment

OS:
Python version:
PyTorch version:
CUDA/cuDNN version:
GCC version:
Any other relevant information:

Additional context

Seems to be related to https://github.com/rusty1s/pytorch_geometric/issues/669.

Yep, I found the reason. It is related to edge_mat.

Hi!
I also meet the same problem of GATConv in my code, how dou you solve it? why it is related to edge_mat? @zhenhuascut
Thank you very much!


Mapit 2016 boundaries blog

@nefiger @jbothma eyeballs pls

Looks good to me - left a question inline. Another question - couldn't we use a screenshot of mapit or do we hate it?

A screenshot seems so... literal. But ok, added. Thoughts?

:eyes:

also left an inline, otherwise cool!


onEnded fires directly vimeo clip starts

Hi I have an issue playing a vimeo clip. onEnded fires as soon as the video loads. Player works fine otherwise. Code looks like this:
step ?
               (

                    <button onClick={() => this.showVideo()}>
                        <FontAwesome name="play" size="2x" />
                    </button>

              ) : (

                    <ReactPlayer
                        url={'https://player.vimeo.com/video/' + this.props.vimeoCode } className="react-player"
                        width='100%'
                        height='100%'
                        onEnded={alert('movie ended')}
                    />

              )

The alert pops as soon as the 'play video' button is clicked after the intro and fires showVideo()

Do you have an example repo or jsFiddle showing the problem happening? I can’t reproduce this myself.

Hi Pete
Thank you for your response, much appreciated.
The repo is here:
https://bitbucket.org/emrys_hughes/sar/src/video-forward-at-end/
In this file:
https://bitbucket.org/emrys_hughes/sar/src/video-forward-at-end/src/components/Video/Video.jsx
I call the ReactPlayer component you can see the commented out alert which fires as soon as the video starts?
If you click forward you will get to a video around step4

On 25 Mar 2019, at 7:08 AM, Pete Cook<EMAIL_ADDRESS>wrote:
Do you have an example repo or jsFiddle showing the problem happening? I can’t reproduce this myself.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/CookPete/react-player/issues/572#issuecomment-475994969, or mute the thread https://github.com/notifications/unsubscribe-auth/Agn3mxalLRgXTJLFOrg0Y3jDy7iv8TGOks5vZ9tOgaJpZM4bDykL.

Ah, I didn't spot this before.. You are passing alert(...) to the onEnded prop, this will call the alert function immediately and pass the result of that function to the prop. What you want to do is pass a function to the prop, eg onEnded={() => alert('movie ended')}


early-hints: Update "any" -> "all"

From the context, it would make the most sense for all of the attributes to be present, rather than any.

@GregBrimble anything blocking this from being merged?

Sorry, lost track of this. Thanks for following up!


Create Dolma.md for vegeterian side dishes

Added new recipe to sides

This Pull request closes #7


File rename - when renaming to file which already exists, existing file gets deleted

I have two files 1.jpg and 2.jpg in a folder. When I rename 1.jpg to 2.jpg I am seeing that 1.jpg is renamed to 2.jpg and 2.jpg is deleted. API call to rename -
curl -X PATCH -H "Authorization: Bearer xxx" -H "Accept: application/json" -H "Content-Type: application/json" -H "Cache-Control: no-cache" -d '{"name":"2.jpg"}' https://mysharepointonline.sharepoint.com/_api/v2.0/drive/items/<ID of 1.jpg>
Shouldn't the API return some error message?

I observed the same issue as well. It should have return the error or renamed the file with some prefix but instead its deleting the file having same name.
Weird behavior.

Hi all, this issue should now be resolved - please let us know if you're still seeing it!

Thanks @ificator I am getting 409 with response body
{
  "error": {
    "code": "nameAlreadyExists",
    "message": "The specified item name already exists."
  }
}


Feature request: Customize Layout of Lovelace View

I've spent a few hours with Lovelace today and generally I'm finding it pretty flexible, and extremely fast.
One thing I have struggled with is defining where cards go. They tend to have a mind of their own. At least I would like to define the order of display from top left over to bottom right.
I'd like a little more control over layout in general.
Thx
JP

This comment still really holds up: https://github.com/home-assistant/ui-schema/issues/123#issuecomment-406976025

https://github.com/thomasloven/lovelace-layout-card
@thomasloven has created a custom card for this. Using it to test different ways to do this

My points:

Ability to specify Number of Columns in a view: Very helpful and will extend use of vertical stacks
Making the panel variable a string or better yet just make the option extend the columns to the full width of the page instead of choosing the first card and extending it... If they want that just use one card 🤔

IMO it would be interesting to explore some client-side control of the layout, since this is pretty specific to the screen that it's being viewed on. As a rough idea, the users could enter "edit" mode for a view, and drag/drop rearrange the cards how they make sense on this device.

for the UI editor, I envision a user being able to select "new row" and dragging/dropping whatever cards they want in there and selecting a card size of small/med/large. how that would translate to implementation or even populating in a configuration I'm not sure of, though

| hui-view.js
    const columnCount = config.columns || this.columns;

    for (let i = 0; i < columnCount; i++) {
      columns.push([]);
      columnEntityCount.push(0);
    }
    elementsToAppend = elements.filter((el, index) => {
      const column = config.cards[index].column;

      if (column && column <= columns.length) {
        columns[column - 1].push(el);
        columnEntityCount[column - 1] += computeCardSize(el);
        return false;
      }
      return true;
    });

    elementsToAppend.forEach((el) => {
      const cardSize = computeCardSize(el);
      // Element to append might be the wrapped card when we're editing.
      columns[getColumnIndex(cardSize)].push(el);
    });

This adds columns to view config.
views:
  - id: '1' # Automatically created id
    title: Testing Grounds
    columns: 3
    cards: {...}

And column to card config. Position within the column is based on order in YAML file.
- id: '1234'
  type: entities
  show_header_toggle: true
  column: 1
  entities: {...}

I think this could be implemented easily with our new editor with drag and drop but also with a Position and Column field in the UI editor. Position would move the index within the view config cards and Column would change the column variable in the card Config.

You would also need to take into account that it has to work on different kinds of screens. It is hard to make this responsive...

Columns would stack one after the other for mobile. And we could show an outline of the column for editing the layout easier in a mobile stand point

This also doesn't remove the current capabilities that we offer for auto sorting. If you only add column to some cards the rest will be sorted as they are today. Into the shortest/smallest column
I think this could be the first step into making a better system for users to customize their layout. If using the editor it would be easy to sort them by column then by index so that when its on mobile its still the same layout. We could even just build that straight into the mobile viewing. Sort ElemetsToappend by column then index

I would also like to propose making panel: true mean making the columns full width of the screen. AKA if there are 3 columns that means each column is 33% in width

just curious how work is going on this before I look to custom cards to solve my similar issues?
Thanks!!

Is there any progress? I have the same kind of issue where my cards seem to go all over the place when I want to sort them. I love the UI editor, but not able to move the cards to the position I want them in, is a shame.

I have the same kind of issue where my cards seem to go all over the place when I want to sort them

+1 for customizable columns and drag and drop. ^^

I feel like drag and drop is the one thing that HASS needs to become significantly better. Its easy to do a lot of things except its a nightmare to organize card in the UI. Drag and Drop would save a lot of time and reduce headaches for many users.

muuri library is still our best bet on this, I think. I start a POC based of @bramkragten 's work, but have yet to get it working properly: https://github.com/custom-cards/muuri-grid


download blobs from URI

Is there any way we can download blobs from uri?

I have done the same for large file downloads, by changing the AZSExecutors's method execute().
I have sent a flag from the code after configuring the AZSBlobRequestOptions and AZSOperationContext classes in the AZSCloudBlob's method downloadToFileWithURL().
In case this flag is encountered, in the execute(), I have back-propagated the NSMutableURLRequest *, from the execute() method and created a URLSessionConfiguration with a background download task.
Here, you can use the same NSMutableURLRequest for calling the downloadTask(with:) and do the download.


Fix incorrect services load (#52)

Codecov Report

Merging #53 (5cfef08) into master (ad40214) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   53.55%   53.55%
=======================================
  Files           4        4
  Lines         267      267
=======================================
  Hits          143      143
  Misses        100      100
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad40214...5cfef08. Read the comment docs.


what is the latest production version of html2canvas?

Please make sure you are testing with the latest release of html2canvas.
Old versions are not supported and issues reported for them will be closed.
Please follow the general troubleshooting steps first:

[x] You are using the latest version
[x] You are testing using the non-minified version of html2canvas and checked any potential issues reported in the console

Bug reports:
Please replace this line with a brief summary of your issue AND if possible an example on jsfiddle.
Specifications:

html2canvas version tested with:
Browser & version:
Operating system:

No version is currently suitable for production


Accessibility: [MAS2.1.1]: User is not able to navigate inside the 'Shortcuts' list with keyboard.

Build details:
OS Version: 2004(20221.1000)
Edge Dev Version: 87.0.654.0 (Official build) dev (64-bit)
URL: https://fluidframework.com/playground/?path=/docs/welcome--page
Repro Steps:
1. Navigate to 'Shortcuts' button in left nav and invoke it.
2.Now try to navigate inside the list using down arrow key and observe.
Actual Result:
User is not able to navigate inside the 'Shortcuts' list with keyboard. The list is getting collapsed when users presses down arrow key or tab.
Expected Result:
User should be able to navigate inside the 'Shortcuts' list with keyboard.
User Impact:
Users with motor impairment who are dependent on keyboard will not able to access the options inside the list if they are not navigable with keyboard.
MAS Reference:
MAS 2.1.1 - Keyboard

Ahh, these shortcuts:

this functionality is 100% within Storybook. Should we move this issue into the storybook issue queue?

No, we're tracking all issues in this repo centrally. We'll just open PRs against the Storybook repo to close these issues.

Ok, thats fine. Just making the note here that it's an upstream fix needed to resolve this ticket

TBH, I don't know if Storybook would consider this a bug. It's more a clickable tooltip than a menu. I'm not sure how actionable it'll be here in our issue queue, but at least we're tracking it.

Issue logged on Storybook issue queue https://github.com/storybookjs/storybook/issues/12819

In progress !

External issue is getting some traction. Hopefully this will mean a fix coming soon.

https://github.com/storybookjs/storybook/pull/12904 If you want to help on the review you're welcome !
I still have another round of checks (side effects, using a11y tools...)

One more item to note is that the button itself needs to inform the user that it envokes a menu. In Flunet UI we currently do that via aria-expanded="false" aria-haspopup="true"
This should probably be added in this PR.


Info Mail contains Not enough information

The info Mail for a New Task doesn't contains enough information.

One solution could be to add a Link to the Task or add the hole Task into the Mail.
For Mail Reputation are Mails without (Bad) links better.


HubConnection implements IAsyncDisposable

Fixes https://github.com/aspnet/AspNetCore/issues/13082

Let's retarget this to master to get it in and open a new issue for backporting. I'm not 100% confident I can get everything in place before going on leave and would like it in somewhere.


Find in files: Inconsistent search results when using regex and whole word matching

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.76.0
OS Version: Windows 10 22H2

Steps to Reproduce:
As an example, looking for method calls with an argument:
def one():
    target()

def two():
    target(arg=1)

def three():
    target(arg=2)

Initially I did a whole-word regex search for target\([^)], which matched all the calls providing at least one argument (i.e. two and three here).
Spread across multiple files, I found that after selecting a match in the search result list to open one file, and then selecting one in a different file, the first result disappeared from the search results.  This is presumably because with whole-word enabled, these shouldn't actually match unless the argument is a single character, which for arg here is not the case.
Testing again now on a different machine, it seems the incorrect matches don't show with multiple candidate files open.  If no files are open, candidates from all files are shown.  With one file open, candidates from that file are shown but not the others.
Whole-word matching does appear to apply correctly in other cases (e.g. here, target is correctly matched whole-word so that the likes of othertarget don't match).

Testing again now on a different machine, it seems the incorrect matches don't show with multiple candidate files open. If no files are open, candidates from all files are shown. With one file open, candidates from that file are shown but not the others.

What version of vscode does this other machine use? Did this only start happening today with the update?

I can check in the morning, but I did try on this computer before updating and it was still happening then, so probably safe to say it wasn't introduced in the latest update.

The other machine is on 1.75.1, so hasn't gained the update yet.

Here is another reproducer.

Create a FooBar.txt with this content:Foo
PrefixFoo
FooSuffix
Bar
PrefixBar
BarSuffix

Find in files (Ctrl+Shift+F) for Foo|Bar with Match Whole Word & Use Regular Expression options.
If FooBar.txt is open in an editor when search was run, works correctly, apparently equivalent to \b(Foo|Bar)\b regexp:

However, if FooBar.txt was not open when search is run, it gives unexpected matches, apparently equivalent to \bFoo|Bar\b regexp where Foo is only constrained to start the word, and Bar only to end it:

Similarly, FooBar.txt was not open when Bar|Foo search is run, it gives different unexpected matches, apparently equivalent to \bBar|Foo\b regexp:

Opening or closing FooBar.txt doesn't toggle the results between (4) vs (5)/(6) immediately; some other action is needed to re-run search (by changing search string, pressing Enter in search field, or editing any file).  That makes sense, because search results are not supposed to depend on files being open :grin:

(In all cases, there were other clean "foo" and "bar" matches in other files; I didn't test the more complex interactions between files that Terrance reports...)
1.74.3 on linux (fedora 37)
```
Version: 1.74.3
Commit: 97dec172d3256f8ca4bfb2143f3f76b503ca0534
Date: 2023-01-09T16:57:40.428Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 6.1.8-200.fc37.x86_64
Sandboxed: No
```

This also reproduced on 1.76.0.  I now re-tested #112401 (originally reported in 2020) and found that presently its behavior too depends on whether the candidate file has an open editor.
Weirdly, the theory on #112401 suggests the Whole Word constraint being applied after the regexp engine is done searching, resulting in behavior that has no equivalent regexp — whereas my theory of \bFoo|Bar\b vs. \b(Foo|Bar)\b here relies on it translating to a regexp. :man_shrugging:

Looking more into this, I don't believe this is a new issue. The find when files are open seems to handle matching a whole word differently than how the ripgrep engine does when files are closed.
In-file find uses a more complicated way of using word separators when we want a whole-word match:
https://github.com/microsoft/vscode/blob/3059063b805ed0ac10a6d9539e213386bfcfb852/src/vs/editor/common/model/pieceTreeTextBuffer/pieceTreeBase.ts#L799
Whereas our parsing into ripgrep has a simpler approach"
https://github.com/microsoft/vscode/blob/5ca7a333e12b313eda4092bf4d1ca60e365ec416/src/vs/base/common/strings.ts#L183-L188

Might be related to https://github.com/microsoft/vscode/issues/170529 (but here, the whole world toggle over-matches instead)


Please keep Makefile upto date

There is major change in package-alarms, 2 months ago, but nothing changed in Makefile.
https://github.com/apache/openwhisk-package-alarms/commit/e248a564f4f163d0cb4cca0afd3c56c63a4ed71b
This shows that while calling install-package-alarms there are significant changes in parameters but in Makefile they are still not changed.
In Makefile, we are calling installCatalogUsingWskDeploy.sh whereas in it must be installCatalog.sh.

Hopefully bumping this will get it more attention. That commit adds a few required vars that I do not know where to get.

@Keonhee
Could you take a look at this?

Ok I will try to handle this issue.


Issue running in linux

When running on a linux machine I keep running into the error below.
dlopen failed: vaudio_celt_client.so: wrong ELF class: ELFCLASS32
Failed to initialize CSGO audio decoder
Processing demo TestDemo.dem
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x0]

I've tried this on a ubuntu 22.04, 18.04 VM and docker containers. I also tried a debian VM and container, both of which failed. And lastly I tried on my unraid server which also failed.
In every case I get the same error message. So it seems like there is an issue with the build and the .so files being loaded.
I always tried locating the csgove and .so files in the same directory, and always used LD_LIBRARY_PATH=.
The .so files came from a fresh download of CSGO, on each test machine.
I also tried doing this from source, doing a checkout of the project, copying the .so files into that directory and running
LD_LIBRARY_PATH=. CGO_ENABLED=1 GOARCH=amd64 go run .
After looking at the issue I thought it might be a miss-match of 64bit vs 32bit build and files. So I also tried
LD_LIBRARY_PATH=. CGO_ENABLED=1 GOARCH=386 go run .
Which returned this error
# runtime/cgo
In file included from _cgo_export.c:3:
/usr/include/stdlib.h:26:10: fatal error: bits/libc-header-start.h: No such file or directory
   26 | #include <bits/libc-header-start.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~

I also tried this on my Windows machine, with files from its install of CSGO. And that worked perfectly. 0 issues loading files and produced good .wav files every time.
But that makes this a lot more of a challenge to automate, I'd much prefer to having this running on my server than on my gaming PC.

After more debugging I was able to determine that my copy of the 2 .so files where the 32 bit versions. Using with the correct 64 bit versions worked flawlessly.


Using middleware without a scope prefix?

Can we add a function Dream.use : middleware list -> route list -> route to add middlewares to a bunch of routes without needing a scope prefix? My use case is that in bidirectional routing, we typically create route or path 'objects' which need to be able to print out the correct path for linking purposes:
let order = [%path "/orders/%s"]

let get_order = get order (fun request order_id ->
  ...
  a [href (Path.link order) order_id] [txt "Your order"]
  ...
)

If we attach a middleware to this route with eg Dream.scope "/v2" [v2] [get_order], the path object no longer captures the correct routable path, which will be /v2/orders/:param3. But if we capture the full path:
let order = [%path "/v2/orders/%s"]

Then we need to attach middlewares without a prefix:
use [v2] [
  get_order;
  post_order;
  delete_order;
]

I have a simple working implementation now:
let use middlewares = Dream.scope "" middlewares

But something tells me this may not be the best approach. Could we support it directly in Dream?
EDIT: prior art for the name use:

Node.js Express
Go Chi

EDIT 2: the OCaml website people are also doing Dream.scope "": https://github.com/ocaml/ocaml.org/blob/5ac9eea5813c8813d4a562958af7a99d910bba81/src/ocamlorg_web/lib/router.ml#L79

OK so I see Dream.scope "/" ... tested here https://github.com/aantron/dream/blob/27ff43177b57a9c64abb39e72750fbd5f6a47199/test/expect/server/router.ml#L504 so I assume it's a supported use case...in that case maybe my use suggestion has less weight since it's already so simple. Hmm 🤔


Adds DNSPolicy to the ActiveGate section (+ updates the tests)

Adds the DNSPolicy option the the Dynakube.Spec.ActivGate section.
Updates the yamls accordingly.
Updates the statefulset_test.go to use not use the now deprecated Dynakube.Spec.Routing section.

Please also add it to the samples


Comment textbox loses scroll position on typing

Extension version: v0.82.0
VSCode Version: 1.87.2 (system setup)
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Date: 2024-03-08T15:20:17.278Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631

Steps to Reproduce:

Type enough text into a comment textbox so that it will overflow vertically.
Type a key

As you can see on my screen recording, when I enter a new character into the textbox, it "scrolls up". I can scroll down to bottom again using the scrollbar (or the scroll wheel on the mouse), but if I hit another character, it scrolls up again. Also: I can't even scroll to bottom using the down error (see screen recording), only using the scrollbar / scrollwheel.

Also: would be nice to be able to resize the textbox for when you want to write a longer comment.

Duplicate of https://github.com/microsoft/vscode/issues/207333, which is available in VS Code Insiders.


updated members.jsx

Updated members.jsx

Don't remove other members' names or your own.

Don't remove other members' names or your own.

Sorry for that mistake i will resolve it ASAP.


[Filestore] Compaction/Cleanup/FlushBytes optimization

Implement lazy compaction map loading
Implement garbage-based compaction
Use blob patching in compaction
Think about some ways to optimize Cleanup and FlushBytes and the FreshBytes layer
Global triggers for Compaction and Cleanup - triggers for total deletion marker count per fs, total blob count per fs, etc.

Use blob patching in compaction

won't use patching - it's too risky, we still keep finding bugs in it 2.5 years after it was first introduced

Found a performance issue: Compaction copies blocks which are not actually needed but whose MaxCommitId is still > than MinCommitId (CommitIds are not rebased yet) to its dst blobs. Second compaction run is needed to get rid of this garbage.

found another problem: CompactionThreshold is set in terms of blob count, max blob size is set in bytes (and the default is reasonable - 4MiB) which leads to nonstop recompactions for filesystems with large block sizes
e.g. BlockSize=128KiB, MaxBlobSize=4MiB, CompactionThreshold=20
if we have a "full" compaction range (having 64 blocks x 16 nodes == 1024 blocks) there will be 128MiB of data in it => 32 blobs which is greater than 20 which leads us to endless compactions
a possible solution is adjusting this threshold based on the BlockSize / DefaultBlockSize ratio (DefaultBlockSize == 4KiB => we will have min 1 blob per range if there is some data in this range - it's our baseline)

we also need some metrics showing the number of compactions per second split by the reasons - launches per second due to high blob count per range / due to high overall blob count / due to high garbage percentage
and outputting current garbage percentage and average blob count per range to the tablet monpage would also be nice

From the description of this issue:

Implement lazy compaction map loading
Done

Implement garbage-based compaction
Done

Use blob patching in compaction
Postponed

Think about some ways to optimize Cleanup and FlushBytes and the FreshBytes layer
TODO

Global triggers for Compaction and Cleanup - triggers for total deletion marker count per fs, total blob count per fs, etc.
Done

Add metrics for background ops, display more background ops info on the tablet monpage
Done

Also some bugs were found during the work on this issue. Some of them were fixed.
Current TODO list for this issue:

Missing deletion marker cleanup in FlushBytes (bug)
Cleanup/FlushBytes/FreshBytes layer optimization - it's actually a candidate for a separate issue
Optimize CompactionMap load times

Current TODO list for this issue:

Missing deletion marker cleanup in FlushBytes (bug)
DONE
Cleanup/FlushBytes/FreshBytes layer optimization - it's actually a candidate for a separate issue
will increase Compaction/Cleanup throughput here: https://github.com/ydb-platform/nbs/issues/1129, will work on the fresh bytes layer sometime later
Optimize CompactionMap load times
https://github.com/ydb-platform/nbs/issues/1128


Atomic Number 22

Adding Titanium, Plastitanium, Plastitanium Glass, and Titanium Glass along with some other stuff, like titanium-related structures and different borg construction

[x]  Finish Titanium, Plastitanium, etc. sheet stuff
[x]  Add Titanium Ore into savlo, and Titanium sheets to the COC
[x]  Titanium and Plastitanium tiles
[ ] Titanium and Plastitanium objects
[ ] Titanium and Plastitanium Glass Structures and Furniture
[x] Make borg machine boards
[ ]  Technologies
[ ]  Finish Borg creation method
[ ] make sure code actually FUNCTIONS before PR is done

this changes upstream content
reopen when you get the chance to continue working on this


Adding ERIS SAM

Dear developers of AMICAL,
I'm participating in the commissioning of the new ERIS instrument at VLT and, along with the two coronagraphs, I'm responsible for the 3 SAM masks in NIX (SAM-7, 9, and 23). How can I add support for those in AMICAL? Is there a simple workflow to add support for a new instrument?
Thanks for your help!
Jean

Hi @JHayoz, thanks for your interest :) For now, we do not have a proper workflow to add new instruments. The main requirement for AMICAL is to have access to an accurate determination of the aperture positions (compared to the pupil in meters) and the wavelength domain of the instrument (central wavelength, bandwidth, etc.). You can have a look at get_infos_obs.py to see the structure required by AMICAL.

Hi again @JHayoz; additionally, if you have some simulated data, we can manage to test the pipeline on them. We probably need to know what are the appropriate header keywords to select the filters automatically, but this can be solved in a second step. Let me know when you have a reasonable estimate of your mask properties and associated spectral filters :)

Hi, thanks for your answers! I don't have simulated data, just data taken during commissioning. I have pupil images with the different SAM masks inserted as well as the design of the SAMs, so in principle this should provide all the data we need. I have to look into get_infos_obs.py to understand how to provide this info to AMICAL though. I'll try it this week and will probably have some more questions about AMICAL as I go.


How to wait until all network activity on a particular page has stopped before continuing?

I was wondering if there is a way to wait until all network activity has become idle (without navigation, refreshing, or going to a new page) as the application I am writing tests for requires all API requests to complete first before some buttons become clickable etc.
I am currently doing stuff like await page.waitFor(10000) and so on but I don't think this is the best solution.
Is there any way I can write code that would act something like this:
await page.waitFor({ waitUntil: networkidle })
Any insight would be appreciated, thanks so much in advance!

Hi @saadahmad03 ,
there is a options argument by calling page.goto. In these options you can set waitUntil to networkidle2.
await page.goto(url, {waitUntil: 'networkidle2'});
https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#pagegotourl-options

Hi @rogervanwile, thank you for your response. I was actually wondering if there was an option to do
{ waitUntil: 'networkidle2 } without having to go to a new page, and to perform this operation on the current page.

@saadahmad03 thanks for the clarification. This has been requested for a while already; filed a designated bug report for it: #3083. Feel free to upvote.

can i do this with     await page.mouse.click(pos.x+pos.width/2, pos.y+pos.height/2);?


Centre the step menu

In the rollout just today, it appears the step menu expands in the leftmost column under the back arrow, instead of aligning with the step menu button.

Closing subject to redesigned step page


load, display and count the average ratings

Load existing ratings from the database and display them
On click, send a new rating to the base and count the new display average

Generally, the code is very good, you just left some junk file in it.

 Dodati ocenjivanje citata


Index out of bounds error

Hi, I ran into this error when I used a degree of 50 on a fairly large dataset (a couple hundred x,y pairs).
It happened because in the function "decompose", the int maxPosition never got set after initialized to -1, which was then used as an array index in line 139.
Perhaps this is some overflow error?
Now, I'm not mathematically inclined, so that's all I can say for now. I'll mess around with it a bit more in the meantime.
Thanks so much for publishing this work!

I forgot to mention that the method works when I used smaller degree counts.
I printed out dCurrentRatio this time and found that it was always either 0.00000 or nan, which I don't know how to interpret.

So how did you resolve the issue in your case?

I don't believe I did find a solution, sorry.


start tracking golang updates for 1.10.x

It's time to start tracking point release updates for golang See: https://github.com/containerd/containerd/commit/37765fbde5b297b81bba2d1306f9abc84e8f775d
Signed-off-by: Mike Brown<EMAIL_ADDRESS>

The CI is broken by kubernetes. I'll look into it now.

/test pull-cri-containerd-node-e2e

/test pull-cri-containerd-build

/lgtm


Django 1.6 defaults removed from django.conf.urls

I simply tried to follow a model and i got this error
ImportError
Exception Value:     No module named defaults
In my urls.py
from django.conf.urls import patterns, include, url
and I cannot import defaults
Also i looked into it and found in Django 1.5
NAME
django.conf.urls
PACKAGE CONTENTS
defaults
i18n
shortcut
static
Whereas in Django 1.6
NAME
django.conf.urls
PACKAGE CONTENTS
i18n
shortcut
static
Can you release a newer package version with no dependency on defaults ?

I am using version 0.6.3 on Django 1.10 and the error still persist

use from master branch

update your code following official django docs


Maintainers outside of base16-project

@richardneililagan you have write access to this repo but aren't on the http://github.com/base16-project team. Should I add you to the team (as a maintainer) or remove you from the project? I'm not sure if you're aware of base16-project or the changes happening to base16 in general? Additionally, if you'd like to be part of the team and maintain different projects, let me know which ones and I can add you ad a maintainer there.

@JamyGolden remove would probably be best at this point --- I'll reconsider jumping in once I can more confidently put in the time for it. Thanks for bringing it up.

Ok sounds good!


Fix drone build status badge

Should we label the build badges because they look the same (travis and drone)?

Should we label the build badges because they look the same (travis and drone)?

How?


Add mute prop

~BLOCKED~
~I haven't run the demo to make sure everything works, just want to open this to make sure it doesn't get forgotten.~ Seems to work good!
This adds a mute prop (default off) to not play the incoming message sound.
Also this makes me realize our sound is pretty high pitched and unpleasant ><

@dharness Review comment addressed, RFFR ! :)

thanks for making the change


[API] Extend times API

close #8833; close #8513; close #8559

[x] Deprecate old stuff
[x] add new times json struct (extend old)
[x] add optional user var for EditTimeOption (#8559)
[x] add remove time comment
[x] expose Created in EditTimeOption as optional var
[x] add /repos/{owner}/{repo}/issues/{index}/times

[x] GET -> TrackedTimeList
[x] POST <- EditTimeOption
[x] DELETE (reset time on issue to 0)

[x] add DELETE /repos/{owner}/{repo}/issues/{index}/times/{id} to delete specific tracked tim
[x] update GET /repos/{owner}/{repo}/times -> TrackedTimeList
[x] update GET /repos/{owner}/{repo}/times/{user}
[x] update GET /user/times -> TrackedTimeList
[ ] add query param for GET functions moved to: #9373
[x] Add Test's

[x] add time with other user and creation time
[x] get trackedTimeList
[x] delete one time
[x] reset an issue

@noerw you had some issues about times ... any suggestions so i dont have to touch the temies-api multible times ...
I'm thinking about an /api/v1/times/... endpoint because i cant just replace old api endpoints with a different json responce :(

@6543 Thanks for working on this!

Personally I'd keep the endpoints as they were until now, this follows the structure of other API features.
I'd add RepoOwner & Repo to the struct TrackedTime struct, at least for the /user/times endpoint (as mentioned by @bobemoe earlier. This allows for client side filtering).
+1 for DELETE endpoints

@noerw gitea frontend dont depend on api the simple thing is droping old stuff lead to backwarts incompatebilety and because gitea moves forward fast ... projects who use giteas api often are a litle behind the master and/or latest release ...

so my plan for now: @techknowlogick i think i can do it within 1.11.0 ?

Codecov Report

Merging #9200 into master will increase coverage by <.01%.
The diff coverage is 8.92%.

@@            Coverage Diff             @@
##           master    #9200      +/-   ##
==========================================
+ Coverage   41.06%   41.07%   +<.01%
==========================================
  Files         553      554       +1
  Lines       72041    72446     +405
==========================================
+ Hits        29582    29754     +172
- Misses      38727    38938     +211
- Partials     3732     3754      +22

Impacted Files
Coverage Δ

models/issue_tracked_time.go
50% <0%> (-17.57%)
:arrow_down:

routers/api/v1/repo/issue_tracked_time.go
0% <0%> (ø)
:arrow_up:

routers/api/v1/api.go
73.37% <100%> (ø)
:arrow_up:

modules/graceful/manager.go
25% <0%> (-6.32%)
:arrow_down:

modules/graceful/manager_unix.go
41.66% <0%> (-4.08%)
:arrow_down:

modules/task/migrate.go
25% <0%> (-3.95%)
:arrow_down:

models/issue_comment.go
42.34% <0%> (-2.37%)
:arrow_down:

modules/git/command.go
90.17% <0%> (-1.83%)
:arrow_down:

modules/references/references.go
79.9% <0%> (-1.73%)
:arrow_down:

models/error.go
32.67% <0%> (-1.19%)
:arrow_down:

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54dab5a...1ae3202. Read the comment docs.

I am not sure if it is not to late, but I would appreciate to set/edit Created time.Time or add a new field with date attribute. It would give users a possibility to set the time to a concrete date, and it would be possible to export meaningful timelog report for some period of time (last month, this year, ... for example), similar to Redmine. It would be very beneficial from project management point of view.

@arkamar I'll expose Created in EditTimeOption as potional feeld

PS: as long as it is WIP all suggestins are welcome!

I too am using this to generate a time report for a specific (monthly) period.. Currently I request all time data and then my script filters out the relevant date/month, and sums up the total times for each issue and generates a csv which includes the issue title... It's not really complicated but it could be useful if some of the functionality was built into the API:

Specify optional StartDate and EndDate so able to request only times logged within a specifc time range.
Request totals per Issue (within the date range if specified) maybe when this is enabled the individual component times don't even need to be shown?
Include issue title

I guess the time range would be most useful.. especially months/years late when there is LOTS of time data.
The other points are probably more use case specific?
For reference my PHP script to do this is: https://git.jhodges.co.uk/jhodges/GiteaBot-examples/src/branch/master/src/time_report.php

@bobemoe
Start/Stop Date:
StartDate: Created
EndDate: StartDate + Time
Summary
Request totals per Issue: I'd like to add this but this is not posible because of backwards compatiblety :(
if this would be not the case i woudld add a different struct for timestrackList:
times: [
 .... time list ...
],
summary: time
...

Include issue title
I'll change issue_index to issue item

INFO: Repo is removed because Issue has the information!
{
    "created": "2019-12-06T01:58:04.160Z",
    "id": 0,
    "issue": {
      "assignee": {
        "avatar_url": "string",
        "created": "2019-12-06T01:58:04.160Z",
        "email"<EMAIL_ADDRESS>        "full_name": "string",
        "id": 0,
        "is_admin": true,
        "language": "string",
        "last_login": "2019-12-06T01:58:04.160Z",
        "login": "string"
      },
      "assignees": [
        {
          "avatar_url": "string",
          "created": "2019-12-06T01:58:04.160Z",
          "email"<EMAIL_ADDRESS>          "full_name": "string",
          "id": 0,
          "is_admin": true,
          "language": "string",
          "last_login": "2019-12-06T01:58:04.160Z",
          "login": "string"
        }
      ],
      "body": "string",
      "closed_at": "2019-12-06T01:58:04.160Z",
      "comments": 0,
      "created_at": "2019-12-06T01:58:04.160Z",
      "due_date": "2019-12-06T01:58:04.160Z",
      "id": 0,
      "labels": [
        {
          "color": "00aabb",
          "description": "string",
          "id": 0,
          "name": "string",
          "url": "string"
        }
      ],
      "milestone": {
        "closed_at": "2019-12-06T01:58:04.160Z",
        "closed_issues": 0,
        "description": "string",
        "due_on": "2019-12-06T01:58:04.160Z",
        "id": 0,
        "open_issues": 0,
        "state": "string",
        "title": "string"
      },
      "number": 0,
      "original_author": "string",
      "original_author_id": 0,
      "pull_request": {
        "merged": true,
        "merged_at": "2019-12-06T01:58:04.160Z"
      },
      "repository": {
        "full_name": "string",
        "id": 0,
        "name": "string"
      },
      "state": "string",
      "title": "string",
      "updated_at": "2019-12-06T01:58:04.160Z",
      "url": "string",
      "user": {
        "avatar_url": "string",
        "created": "2019-12-06T01:58:04.160Z",
        "email"<EMAIL_ADDRESS>        "full_name": "string",
        "id": 0,
        "is_admin": true,
        "language": "string",
        "last_login": "2019-12-06T01:58:04.160Z",
        "login": "string"
      }
    },
    "issue_id": 0,
    "time": 0,
    "user_id": 0,
    "user_name": "string"
  }

@6543
Start/Stop date
I'm not sure I was clear in the original request, but what I mean was to add the start/end date to the API request, looking at the code it may go into FindTrackedTimesOptions as to act like a filter, so I could do something like:
"POST /repos/{owner}/{repo}/times" DATA: {"startDate":"2019-11-01","endDate":"2019-11-30"}
This would return only time data that fell into that range. Something like (excuse my syntax ;)
TrackedTime.Created >= FindTrackedTimesOptions.startDate &&
TrackedTime.Created <= FindTrackedTimesOptions.endDate

Summary
Shame it breaks BC. Maybe another API endpoint for reporting? Could have a lot more complex features included. Would be outside the scope of this PR I expect.
Include Issue
Including the full Issue looks great, I can get the title and repo etc :) Saves a lot of extra requests for my reporting script.  My concern would be the size of the API response, especially when there are hundreds/thousands of TrackedTime data.  I don't think there is pagination at the moment? Allowing the start/end date filter (as above) would reduce that as it acts as a kind of pagination in itself anyway.
Build and Test
Cant wait to give it a shot :) Thanks for your work

@6543 how come deprecate /repos/{owner}/{repo}/times/{user} in favour of /repos/{owner}/{repo}/times? This means I can no longer get times for a specific user. Will user be added to the request parameters of /repos/{owner}/{repo}/times to be able to filter out just times for a specific user?

@bobemoe I extend this too ... it already exists so ...

All who look at this PR: would consider this as ready!
when nothing more appears (and is useful...) I will add tests and remove WIP!

@6543 yes its looking great now, sorry I think I may have been building from an old branch :/
Anyway, on the latest branch, my reporting script is still running fine (no BC breaks :) and I've modified it to take advantage of the new format and can now generate the whole report in 1 request instead on hundreds! Big thanks :)
Two last things..

So what did you think about adding a time range to FindTrackedTimesOptions? I think this is almost essential for most reports and will help keep the response small.

How about being able to get a list of times for a specific user? We have /user/times for the current user (and now repo and issue is included in the output it's useful) but no way that I can see to get it for a specific user (suggest something like /user/times/{user}) without having to loop through all the repos and call /repos/{owner}/{repo}/times/{user}. I expect there may be a permission consideration here?

@bobemoe /user/times should be enougth, if you can use SUDO API?
FindTrackedTimesOptions is nice but I'll think the query is the better way to go (do not exist jet)

@6543 I've not heard of SUDO API, looks like it might be just the job. I guess in the future we may want a non-admin user to be able to generate these reports, but for the time being this is fine.
Not sure what you mean by the query instead of FindTrackedTimesOptions I'm not overly familiar with GO or Gitea code. Which ever way you think is best to implement :) What is this query?

Like the options (state,labels, ...) of GET /repos/{owner}/{repo}/issues

@bobemoe

We realy have to think who should be able to add/delete time at witch point ...

Like the options (state,labels, ...) of GET /repos/{owner}/{repo}/issues

Yeah, I imagine an ideal scenario would be finer grain permissions on user accounts so that a "Billing Department" user could have read access to times, maybe limited to their Organisation, or just repos they have read only perms to. Hmmm. Lots to consider. They way it works now suites me fine though, especially with sudo api :)

I thought the API request options from the URL and body were used to populate FindTrackedTimesOptions which then is used to generate the DB query where it would need to be limited to the time range? I think I may be reading the code wrong ;)

@bobemoe no worry I'll code for you :D

Looking good :) I'll give it a test in the morning.  So it did go into FindTrackedTimesOptions in the end, my GO must not be as bad as I thought it was ;)

note for me: found query arguemt for time based filtering: https://developer.github.com/v3/activity/notifications/#parameters

I'll split this PR so it wont block 1.10.0 !

@lunny done

@lunny done

@lunny do you have time to review? otherwise I'll ask others

@lunny getTrackedTimes do not exist - should i creat it?

I'll resolve conflicts tomorow

@lunny can you look at it? - i resolved and improved

@zeripath 4562fcfb02ee70486838451884b194839e426363 do you mean this?

@zeripath done - I added migration because now times are not deleted from database but flaged as deleted

@lunny think this is ready again :)

@lunny hope dont missed souch things this time

@zeripath do you have time to 👀 ?

@zeripath 050ae6f3a1e8eaf7bf8fadf16df5e850336f7a6d should work - if @techknowlogick has a solution with xorm I'm happy to add

Error: api_issue_tracked_time_test.go:77: Response: {"message":"pq: FOR UPDATE is not allowed with aggregate

@zeripath found working solution link
opts.ToSession(e).Table("tracked_time").Cols("deleted").Update(&TrackedTime{Deleted: true})
if I specify Table and then Colum it works :D
xorm SetExpr can only use string link

@techknowlogick you dont have to look for a solution anymore

@lunny i added /modules/indexer/code/bleve.index/ to gitignore - it apeared after one of your code-refactors are you ok with it? (dont like to make a one line PR)

ready to merge :rocket:

@6543 could you remove the line from .gitignore and re-push - for some reason I cannot push to this branch on your repo.

@zeripath added your suggestion and added you to maintainer of my fork for later changes ...

ready to merge :rocket:

make lg-tm work


Biome Seeds

SO I want to make a mooshroom biome, I am using a specific seed, when I am in singleplayer the seed worls, but when I am on my server and try to generate a mooshroom world it fails.

Could not reproduce. See my test world sheet here: https://docs.google.com/spreadsheet/ccc?key=0AiJFRtVWw9TfdHlHRFlTSzRxUGlVa1Q3azdRa1ZUbFE#gid=0
Mainly this world:
/mv create kjk normal -s kjkszpj
/mv create kjk normal -s -684300403
Here is what it should look like as of CB 1.1:
http://minus.com/mbh7OwPSv1
Make sure you're typing the numbers/letters.

Closing as no response (and tested working). Please feel free to continue discussion here and we will reopen if needed.


Update googleads/googleads-php-lib version from ~35.0.0 to ^35.0

Due to the composer.json version string for googleads/googleads-php-lib, new minor updates to that library are not available.

Changes appear to have been directly committed in https://github.com/nikolajlovenhardt/laravel-google-ads/commit/464bbbae90e31c887e7a67cfb3e2c5991ae7d6af

Thank you @matthewnessworthy


play_long_file fails

Even with soundfile and libsndfile1 installed, I get "TypeError: buffer_read() got an unexpected keyword argument 'ctype'" when I try to run it.  Even if I try soundfile samples, they fail but for differing reasons.

You seem to be using a very old version of python-sounddevice.
See #149.


Test/keepalive http

Closes #791

Codecov Report

Merging #804 (db66a97) into main (2f0eb65) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
+ Coverage   52.01%   52.06%   +0.04%
==========================================
  Files          69       69
  Lines        2082     2082
  Branches       65       66       +1
==========================================
+ Hits         1083     1084       +1
+ Misses        999      998       -1

Impacted Files
Coverage Δ

zio-http/src/main/scala/zhttp/service/Client.scala
57.14% <100.00%> (ø)

zio-http/src/main/scala/zhttp/service/Server.scala
58.82% <0.00%> (+1.96%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0eb65...db66a97. Read the comment docs.


Pan from left doesn't seem to work on iPad landscape...

Doesn't work period. Might just take it out altogether.


Properties missing from RunResponse class

As best as I can understand, the intention of the RunSvc.GetAsync(ThreadId, RunId) is to retrieve the details for a single Run.
I believe that this method corresponds to this OpenAI API call: https://platform.openai.com/docs/api-reference/runs/getRun
I see the response is contained in the RunResponse class, but the RunResponse class is missing the actual properties of the Run that I'm looking to read such as "status".
Can you add them?

Thanks for your feedback! I added the missing properties to the response class. v.1.3.6 released.

looks good.  Thank you.  Closing...


[Audit]: M-01 ERC-721 Does Not Support ERC-165

What is the feature you would like to see?
The ERC721 implementation does not support ERC-165, which is required by the interface, and popular marketplaces such as OpenSea and Rarible call supportsInterface on any NFTs they interact with. If an ERC-721 implementation does not implement ERC-165, other contracts, dApps, or marketplaces will not be able to easily verify whether the contract supports the ERC-721 interface. This means that platforms or third parties that rely on ERC-165 to check for compliance will not recognize the contract as an ERC-721 token. As a result, the NFT contract may face limited interoperability and integration issues with external systems that expect proper ERC-165 implementation.
Consider adding support for ERC-165 to ensure compatibility with marketplaces and third- party systems.
Contribution Guidelines

[X] I agree to follow this project's Contribution Guidelines

Closed by https://github.com/OpenZeppelin/rust-contracts-stylus/pull/309


Align the api with the dotnet api

Is it possible to add the new api from Flow to the api for python?

I think most of the calls are added, maybe a couple that are not. I haven't looked at whether it is possible, but it would be good if it is.

i thought we should update the doc first.

Some can be added without a lot of work (like ShowMsgError) but some didn't work for me when I tried some work arounds (like OpenUri).

Some can be added without a lot of work (like ShowMsgError) but some didn't work for me when I tried some work arounds (like OpenUri).

It's possible because OpenUri needs a Uri object, which is not provided by jsonrpc plugin. Therefore, it cannot be requested. OpenUrl shall work.


AllowShortIfStatementsOnASingleLine not working

clang-format failed with the below error. Consider reporting this by creating an issue here: https://github.com/LiquidHelium/atom-clang-format/issues.
Error message: "YAML:5:38: error: invalid boolean
AllowShortIfStatementsOnASingleLine: Never
                                     ^~~~~

Works fine when running clang-format manually from command line.

Don't work, even if press (ctrl+k, ctrl+f) manually, still don't work.
The error is same:
_YAML:15:38: error: invalid boolean
AllowShortIfStatementsOnASingleLine: Never
Error reading /home/..../.clang-format: Invalid argument_

What if I change input method from Chinese to default English, it will work fine.
Maybe it conflicts with input tool.


fix reaction string

Closes #123

Hello @AndrewJConley! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file interactive/mechanism/reactions.py:

Line 31:25: E231 missing whitespace after ','
Line 33:80: E501 line too long (107 > 79 characters)
Line 35:22: W291 trailing whitespace
Line 42:80: E501 line too long (109 > 79 characters)
Line 44:22: W291 trailing whitespace


Input: fluid property doesn't work with Flexbox

## Bug Report
### Steps
Insert a Search component with the 'fluid' property and add display: flex to it's CSS
### Expected Result
The input becomes as big as its container.
### Actual Result
The input becomes a small box.
### Version
2.0.3
### Testcase
[Fork, update, and replace this pen to show the bug]:
https://codesandbox.io/s/semantic-ui-react-forked-jzbub

@Cheddargt that is how flexbox works.  If you want the child element to expand to the size of the container, you need to set the flex-grow property on that element. flex as a prop is not intended to be displaying the input as a direct child of another element flex container. If you take a look at the CSS, flex changes the Input to display: flex.
I updated your example showing you that if you set the flex-grow to 1 the element displays as you would expect. You do not even need to set the flex prop.
What you are doing in your example is not really how the markup for those elements are intended to be used so the props and styles are not necessarily going to work as you would expect.

@Cheddargt that is how flexbox works.  If you want the child element to expand to the size of the container, you need to set the flex-grow property on that element. flex as a prop is not intended to be displaying the input as a direct child of another element flex container. If you take a look at the CSS, flex changes the Input to display: flex.
I updated your example showing you that if you set the flex-grow to 1 the element displays as you would expect. You do not even need to set the flex prop.
What you are doing in your example is not really how the markup for those elements are intended to be used so the props and styles are not necessarily going to work as you would expect.

Oh, my bad! I tried everything but absolutely forgot about flex-grow :(
But wait, so why does Dropdown expand naturally? Does it have flex-grow: 1 pre-set?

But wait, so why does Dropdown expand naturally? Does it have flex-grow: 1 pre-set?

@Cheddargt The .fluid class also has width: 100% on it, which will also work in place of flex-grow in this particular scenario.
.ui.fluid.dropdown {
    display: block;
    width: 100%;
    min-width: 0;
}


IMPROVE - Error Handling When Creating a Vehicle

Describe the feature you to improve

In func addVehicle in the SettingsViewModel it doesn't handle if there's an error from Firebase
Add a do-catch block to show an error in an alert if an error is thrown

Hi, I'd like to work on this one

@samuelowino you create a PR but never commented that you wanted to work on this issue, as request in the README.md.
Next time, please make sure you comment on the issue you want to work on, before jumping in and coding. This prevents multiple people working on the same issue.

Hi can you assign me this issue ?

Forgot to asked if you could please assign me to this issue.

@activcoding Be sure to comment on the issue before making a PR next time! thank you!


Require crown position for dead standing trees

@jess-shue , when a tree is DS, the current FFF removes the requirement to record crown position. This should be required.

Oh, that's right! Okay, we should leave as is then.
I'll leave this open to clarify in the field guide.

OK, will not change this rule then!

Crown position and dead crown position now required for DS trees in the app.


Feature 264 - Viewability: Implement viewability schema

PR to add viewability schema to core ExperienceEvent. This is related to open issue #264.
@kstreeter  @cdegroot-adobe

This should be an extension schema and not part of XDM proper. It is much too specific to a particular product and library

@gabebarcelos-adobe, in response to @lrosenthol's comments, I believe that the definition of digital advertising "viewability" is standardized by IAB/MRC guidelines, and the properties captured here appear to be what would be required to fulfill those guidelines.  If that's true, I feel like we should keep this as part of core XDM, and perhaps just make sure the descriptions make it clear that this is used to fulfill the guidelines.

@kstreeter - agreed, these changes implement IAB/MRC guidelines which is why we originally put it under core XDM. I've gone ahead and moved it back to core with the latest push. The descriptions have also been further tweaked to clarify viewability standards, happy to add more details is needed.

@gabebarcelos-adobe I've got one outstanding comment on the experience event example: it has a "version" field which does not exist in the schema.

@kstreeter - Thanks for pointing that out, i've updated the example file to align with the schema.

Hi @lrosenthol when you have confirmed your comments have been addressed we'll merge this in.

@lrosenthol - It has been 7 days since you were requested to confirm your comments were addressed. Please do so as we need to merge in this body of schema.


use ack instead of grep for nicer formatting

Ack makes the results pretty and does some common-sense directory excludes.
First ever pull request, ever, of all time. Am I doing it right?

I'm cool with that. I was going to ultimately tweak search to make it, you know, more better, so this is a good first step.
You're doing things right with the pull. :)

Hooray!

Thanks! Still need to make this better and closer to what I have in mind for this, but as an ack newbie it's awesome to learn a bit more from the man himself. :metal:


Bug with displaying remaining input

when I look at https://mosaic.ought.org/w/a1646514-3eb2-4acb-b34c-e07cba697ee1 while logged in as an admin, I see the remaining budget at -69. Looking at it in private browsing mode, I see it at -298 like you guys have reported

See also more discussion here: https://ought-inc.slack.com/archives/CLHBPR4JV/p1565788755007900

Identified the problem which is that admins outside of experiment flow see exports in question as their original exports, while non-admins get the exports converted into imports.

This was intentionally set up this way a while ago so admins could navigate to a workspace and edit the question if there was a need to. Though this editing capability had been removed. So I propose we just always convert exports in questions to imports, even for admins not in experiment flow. This should solve the problem.

cool, sounds right


limit projected ED50s to 2 digits

hey Yulia, I thought this was fixed in a previous release? ED50 values should be limited to 2 digits after period = XY.ZZ °C

Hi @reefgenomics
The following line of the code already does this. It exists in our previous release.
Probably you have to rerun the package installation to get the newest version of the R package from GitHub:
if(!require(devtools)){
   install.packages("devtools")
}

devtools::install_github("greenjune-ship-it/CBASSED50")

Please, let me know if it helps


Change replace method in generateSignature

replace  method doesn't make a replacement when the parameter is a string. It converts it to a Regex without the g flag.
The consequence is that it will just replace the first occurrence found in the string. If signatures have mutliple =, + or \ after convertion, just the first occurrence will be replaced and the signatures comparaison will fail.
To make a real string replacement, we need to do string.split('=').join(''); or to pass directly a Regex with g flag.
This PR will fix #9

Thank you! Great catch!


Facebook signin now works, for the very first signin by a voter

Now calls voterFacebookSaveToCurrentAccount() instead of voterMergeTwoAccountsByFacebookKey()
for a voters first signin via Facebook

👍

resolves wevote/Campaigns/issues/42


Unable to edit prices for patient types under Billing Type Items

This is very urgent as there some price mistakes from the general data we uploaded.
Please add it to the Milestone and prioritize.
@Samshal

There is a fix for this now.
There is a delete button for the prices and then they can re-entered


Indicate that Randomize takes a bool, not a uint16

@ericlaw1979 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Mounting ships causes crash

Soo, I managed to make the ship assemble, but now, mounting it crashes the servers sponge installation, I suspect movingworld being the culprit based on the report, so I opened the Issue here.
I do have the crashreport, but I can't seem to find the log files and I don't want to crash the server again.
Crashreport: http://pastebin.com/guVbAzgm

Open the issue on sponge, I can't see anything from MovingWorlds codebase that causes this, they might not be checking if something's null or not because it's a NPE.


App goes in core dump if the physics = true is istantiated at startup in heavy scenes

In very heavy scenes (sorry, not able to provide a useful code right now) if physics: true the app produces a core dump.
The same code works if I use Component.onCompleted: physics = true.
Here the backtrack:
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007fc3f68d7230 in QList<ContactEvent>::QList(QList<ContactEvent> const&) ()
   from /usr/lib/x86_64-linux-gnu/qt5/qml/Bacon2D.1.0/libbacon2dplugin.so
(gdb) bt
#0  0x00007fc3f68d7230 in QList<ContactEvent>::QList(QList<ContactEvent> const&) ()
   from /usr/lib/x86_64-linux-gnu/qt5/qml/Bacon2D.1.0/libbacon2dplugin.so
#1  0x00007fc3f68d7013 in Box2DWorld::SayGoodbye(b2Fixture*) ()
   from /usr/lib/x86_64-linux-gnu/qt5/qml/Bacon2D.1.0/libbacon2dplugin.so
#2  0x00007fc3f68bf851 in b2World::DestroyBody(b2Body*) ()
   from /usr/lib/x86_64-linux-gnu/qt5/qml/Bacon2D.1.0/libbacon2dplugin.so
#3  0x00007fc3f68d8f2d in Box2DBody::setWorld(Box2DWorld*) ()
   from /usr/lib/x86_64-linux-gnu/qt5/qml/Bacon2D.1.0/libbacon2dplugin.so
#4  0x00007fc3f68f5f3c in Box2DBody::qt_metacall(QMetaObject::Call, int, void**) ()
   from /usr/lib/x86_64-linux-gnu/qt5/qml/Bacon2D.1.0/libbacon2dplugin.so
#5  0x00007fc40e526944 in QQmlVMEMetaObject::metaCall(QMetaObject::Call, int, void**) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#6  0x00007fc40e541b7f in QQmlPropertyPrivate::write(QObject*, QQmlPropertyData const&, QVariant const&, QQmlContextData*, QFlags<QQmlPropertyPrivate::WriteFlag>) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#7  0x00007fc40e5435fb in QQmlPropertyPrivate::writeValueProperty(QObject*, QQmlPropertyData const&, QVariant const&, QQmlContextData*, QFlags<QQmlPropertyPrivate::WriteFlag>) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#8  0x00007fc40e543d31 in QQmlPropertyPrivate::writeBinding(QObject*, QQmlPropertyData const&, QQmlContextData*, QQmlJavaScriptExpression*, QV4::ValueRef, bool, QFlags<QQmlPropertyPrivate::WriteFlag>) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#9  0x00007fc40e5b851c in QQmlBinding::update(QFlags<QQmlPropertyPrivate::WriteFlag>) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#10 0x00007fc40e5b8c7e in QQmlBinding::expressionChanged(QQmlJavaScriptExpression*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#11 0x00007fc40e592497 in QQmlNotifier::emitNotify(QQmlNotifierEndpoint*, void**) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#12 0x00007fc40e52f10c in QQmlData::signalEmitted(QAbstractDeclarativeData*, QObject*, int, void**) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#13 0x00007fc40f324141 in QMetaObject::activate(QObject*, int, int, void**) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#14 0x00007fc3f68e238b in Scene::initializeEntities(QQuickItem*) ()
   from /usr/lib/x86_64-linux-gnu/qt5/qml/Bacon2D.1.0/libbacon2dplugin.so
#15 0x00007fc3f68e2604 in Scene::componentComplete() ()
   from /usr/lib/x86_64-linux-gnu/qt5/qml/Bacon2D.1.0/libbacon2dplugin.so
#16 0x00007fc40e5c19c7 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#17 0x00007fc40e545bab in QQmlComponentPrivate::complete(QQmlEnginePrivate*, QQmlComponentPrivate::ConstructionState*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#18 0x00007fc40e545c67 in QQmlComponentPrivate::completeCreate() ()
   from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#19 0x00007fc40e547d70 in QQmlComponent::create(QQmlContext*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#20 0x00007fc40fcf51ab in QQuickView::continueExecute() ()
   from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#21 0x00007fc40fcf55fd in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#22 0x0000000000400d2f in main ()

I'll try to provide other useful informations asap

happen on which platform? desktop? mobile?
can you provide a minimal code that the problem occurs with you??
thanks

Looks like amd64 Ubuntu. Are you using the Ubuntu packages or built from
git? Code sample would be helpful.
On Jun 30, 2015 9:33 PM, "Rodrigo Oliveira"<EMAIL_ADDRESS>wrote:

happen on which platform? desktop? mobile?
can you provide a minimal code that the problem occurs with you??
thanks
—
Reply to this email directly or view it on GitHub
https://github.com/Bacon2D/Bacon2D/issues/114#issuecomment-117387193.

Sorry for missing details.
I'm on Ubuntu 15.04 and I installed the package from the repo.
I created a little demo of the bug, but I'm not sure it's the same, because also Component.oNcompleted it crashes.
Also, it requires two scenes, one with physics: true and the other with an entity.
Just using qmlscene bug.qml it crashes/
import QtQuick 2.3
import Bacon2D 1.0

Game {
    gameName: "bug.rpadovani"
    height: 100
    width: 100

    Scene {
        anchors.fill: parent
        physics: true
    }

    Scene {
        anchors.fill: parent
        PhysicsEntity {
            fixtures: [
                Edge {
                    vertices: [
                        Qt.point(0, 0),
                        Qt.point(2, 1)
                    ]
                }
            ]
        }
    }
}

Unfortunately for this example gdb is useless 'cause doesn't give informations.
Anyway, the app where first I found the problem is hosted here: https://launchpad.net/falldown
You need to edit falldown/scenes/MainScene.qml to reproduce it

I reproduced it here, pretty strange. Will try to analyze it soon, thanks!

Just a quick check, maybe this problem occur because there are no currentScene being set on Game, changing bug.qml to the below ran without problems:
import QtQuick 2.3
import Bacon2D 1.0

Game {
    gameName: "bug.rpadovani"
    height: 100
    width: 100
    currentScene: Scene {
        anchors.fill: parent
        physics: true
    }

    Scene {
        anchors.fill: parent
        PhysicsEntity {
            fixtures: [
                Edge {
                    vertices: [
                        Qt.point(0, 0),
                        Qt.point(2, 1)
                    ]
                }
            ]
        }
    }
}
```

can you test with your game to check if it works?

Anyway we should do some verification on it while initializing Game.


Ci/cd

ALPACKED test assignment:
Configured CI/CD to each push to the master branch and it builds the website and deploys it to S3+CDN(CloudFront)
Infrastructure created with Pulumi
Configured Contentful CMS

@nikmar13 Please do these PRs in your private repository, not here. Thank you!

@nikmar13 Please do these PRs in your private repository, not here. Thank you!

Sorry) thank u


fc23192

https://github.com/topjohnwu/ondk/commit/fc231925a125d792025508bd602dc1c33201bee2

https://github.com/topjohnwu/ondk/commit/fc231925a125d792025508bd602dc1c33201bee2


Allow defines the shader name that appears in spector.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15038/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15038/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15038/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15038/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15038/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15038/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15038/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15038/merge#BCU1XR#0

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15038/merge/testResults/webgpuplaywright/index.html

WebGL2 visualization test reporter:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15038/merge/testResults/webgl2playwright/index.html


Support Region ignore

I broken my phone screen too, it have a similar symptom, but it click on a point instead of a line.
So I suggest to add functions to block a region (can be a line or a point)
by the way, how to build it?

Sorry, I don't have Android phone anymore, I can't add more feature and test it.
It's built with Android Studio.
Feel free to fork it and make the change.

Ok, thank you very much!


Overlay decorations wrapped in a div not displaying

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

When I attempt to add a decoration that is wrapped in a div (to effectively create a tool tip),
it does not render in the workspace.
Steps to Reproduce

 Run code akin to this:

`      var wrapper = document.createElement("div");
wrapper.className += "tooltip";
  var message = document.createElement("span");
  message.className += "tooltiptext";
  message.innerText = err.Text;
  wrapper.appendChild(message);

  var toolTip = editor.decorateMarker(marker, {type: 'overlay', item: wrapper});`

Expected behavior:

A tool tip is displayed wrapped in a styled div.
Actual behavior:

No tool tip is rendered in the workspace.
Reproduces how often:

100%
Versions

node 8.9.3 x64
atom 1.38.2
Windows 10
Additional Information

The element is definitely there, your issue is that you are applying the tooltip class to it, which is only intended for things like this tooltip:

The problematic part of that class making it not show up in your use case is the opacity: 0:

Thanks for reaching out!

Because we treat our issues list as the Atom team's backlog, we close issues that are questions since they don't represent a task needing to be completed. For most questions about Atom there are a lot of options, check out:

User Documentation — The Atom Flight Manual
Developer Documentation — Atom API Documentation
FAQ — The Atom FAQ on Discuss
Message Board — Discuss, the official Atom and Electron message board
Chat — Join the Atom Slack team

On Discuss and in the Atom Slack team, there are a bunch of helpful community members that should be willing to point you in the right direction.


PR: Improve update UX and automatically download latest installers

Description of Changes

Show download status and status bar icon (Spyder version, if checking for updates, if an update is pending, downloading installer, installing, etc)
Logic to download and run the new Windows/MacOS installer version if available

Part of #19112
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @jsbautista

Hello @jsbautista! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/application/container.py:

Line 82:1: E305 expected 2 blank lines after class or function definition, found 1
Line 119:20: E225 missing whitespace around operator
Line 120:35: E225 missing whitespace around operator
Line 272:13: E117 over-indented
Line 279:5: E301 expected 1 blank line, found 0
Line 281:1: W293 blank line contains whitespace
Line 289:1: W293 blank line contains whitespace
Line 302:64: W291 trailing whitespace
Line 304:33: W291 trailing whitespace
Line 305:43: E251 unexpected spaces around keyword / parameter equals
Line 305:45: E251 unexpected spaces around keyword / parameter equals
Line 306:50: E231 missing whitespace after ','
Line 307:27: E225 missing whitespace around operator
Line 308:17: E128 continuation line under-indented for visual indent
Line 309:17: E128 continuation line under-indented for visual indent
Line 314:9: E306 expected 1 blank line before a nested definition, found 0
Line 316:31: E225 missing whitespace around operator
Line 319:69: E251 unexpected spaces around keyword / parameter equals
Line 319:71: E251 unexpected spaces around keyword / parameter equals
Line 319:80: E501 line too long (89 > 79 characters)
Line 319:90: W291 trailing whitespace
Line 342:1: W293 blank line contains whitespace
Line 344:1: W293 blank line contains whitespace
Line 364:80: E501 line too long (80 > 79 characters)
Line 366:80: E501 line too long (100 > 79 characters)
Line 672:1: E303 too many blank lines (3)
Line 674:9: W292 no newline at end of file

In the file spyder/plugins/application/widgets/install.py:

Line 30:1: E302 expected 2 blank lines, found 0
Line 46:1: E302 expected 2 blank lines, found 1
Line 158:1: W293 blank line contains whitespace
Line 159:9: E265 block comment should start with '# '
Line 159:9: E303 too many blank lines (2)
Line 159:80: E501 line too long (80 > 79 characters)
Line 178:80: E501 line too long (80 > 79 characters)
Line 181:19: E231 missing whitespace after ','
Line 187:5: E303 too many blank lines (2)
Line 203:5: E303 too many blank lines (3)
Line 221:1: E305 expected 2 blank lines after class or function definition, found 1
Line 226:16: W292 no newline at end of file

In the file spyder/plugins/application/widgets/status.py:

Line 20:1: E265 block comment should start with '# '
Line 21:1: E265 block comment should start with '# '
Line 54:9: E303 too many blank lines (2)
Line 78:1: W293 blank line contains whitespace
Line 80:1: W293 blank line contains whitespace
Line 80:1: W391 blank line at end of file

@dalthviz ; A preview of the process of checking for new updates:

@jsbautista just in case, I think the tests are failling since for the new application/widgets dir you need to add a __init__.py file.

Seems like there are some errors with the status constants @jsbautista. To check the tracebacks you can check the CI log: https://github.com/spyder-ide/spyder/runs/7567303687?check_suite_focus=true#step:15:1790

@jsbautista I think that this needs a rebase on top of the latest 5.x to prevent errors in the CI. For that fetch in your local repo upstream and then rebase on top upstream/5.x. So running something like this should do it:
git checkout 5.xUpdateSpyder
git fetch upstream
git rebase upstream/5.x

If that works without issue the you can force push the rebase with:
git push -f

If you need help or some error message appears let me know :+1:

Hi @dalthviz, could you give me a last review before removing the WIP?

Hi @dalthviz

@dalthviz ; A preview of the process of checking for new updates:

@jsbautista @dalthviz, can you guys advise on how to test this PR? I'd like to check that the this downloads and launches the DMG for macOS, but I don't know how to artificially trigger the update notification.

can you guys advise on how to test this PR? I'd like to check that the this downloads and launches the DMG for macOS, but I don't know how to artificially trigger the update notification.

@mrclary on Windows I was testing this by changing the __version__ variable at spyder/__init__.py to 5.3.1 from the installed version

Just in case, a preview of the way this is working on Windows:

Automatic check for updates enabled, but keep update pending and then launch it from the status bar:

Cancel download:

Automatic check for updates disabled, access to the Check for updates... action from the status bar and start download:

Installation process starting (which comes automatically after the download finishes):

@mrclary cloud it be possible for you to do some .gif or screen recording to check how things are looking on MacOS? Maybe just the part related to the download finishing and the .dmg running. I tried checking on my MacOS vm but I'm not being able to launch Spyder if I install the .dmg from PRs. I get a dialog saying that the process should be terminated:

Maybe I'm doing something wrong/missing some setup on my MacOS vm (I think I'm running Big Sur 11.0.1) to be able to run Spyder from a PR .dmg installation?

I see the progress bar, but the dmg is not opened. Let me take a look at what is going wrong there...

FYI, @dalthviz, I think the reason that your locally built macOS installer is failing is because the python-lsp-server was installed in editable mode during the build. That should not matter, but I noticed that for some reason this is causing a problem. The workaround is to install it in standard mode in the build environment. If you are in the macOS installer directory with the build environment activated:
$ python ../../install_dev_repos.py --not-editable --install python-lsp-server

On macOS, with my latest code suggestion...

On macOS, with my latest code suggestion...

Is this suggestion already applied @mrclary ? (I'm not totally sure where is was suggested). Is the one to use ' '.join... for the command arguments?

On macOS, with my latest code suggestion...

Is this suggestion already applied @mrclary ? (I'm not totally sure where is was suggested). Is the one to use ' '.join... for the command arguments?

Yes, it looks like it was fixed. I was not referring to ' '.join... but to incorrect naming destination variable for the temporary downloaded file.

On macOS, with my latest code suggestion...

Is this suggestion already applied @mrclary ? (I'm not totally sure where is was suggested). Is the one to use ' '.join... for the command arguments?

Yes, it looks like it was fixed. I was not referring to ' '.join... but to incorrect naming destination variable for the temporary downloaded file.

Sorry, that was my mistake. I forgot to "submit" my review that had the codes suggestion.

I've made a suggestion to fix the description messages, FYI

Also, just to confirm @dalthviz @ccordoba12 once this is ready, this should either have a major rebase to consolidate the many "WIP" commits into atomic, well-described units before merging, or just be squash merged.

@CAM-Gerlach this will be squash merged :+1:

Just in case @jsbautista seems like the error to generated the Windows installer is unrelated to the changes on the PR but to the PyPI json API to retrieve a release/info about a package for certifi which had a release some hours ago.

I'm good


ci(perf): Disable .NET native for uwp builds

Disables unused .NET native for UWP sample builds

@mergifyio backport release/stable/2.7 legacy/2x


Add links to new publication doc

See https://trello.com/c/gRkjWMSv/595-publication-workflow
This adds links to the new publication workflow page added in https://github.com/openmicroscopy/ome-documentation/pull/1815 - NOTE that this link won't work until 5.4.2 is released
Also added a Figure movie link I noticed was missing

Staged at https://snoopycrimecop.github.io/www.openmicroscopy.org/products/ etc

The colour of the hyperlink over the header image looks a bit wrong to me, but that's unrelated. Good to merge.

@lunson could you change the hyperlink colour in the header text to up the contrast for this?

@hflynn https://github.com/hflynn/www.openmicroscopy.org/pull/1

Thanks @lunson
@manics now underlined rather than blue text, see https://snoopycrimecop.github.io/www.openmicroscopy.org/omero/

N.B. I see this also covers the footers, where I'd noticed before the contrast maybe wasn't strong enough against some of the images 👍

Jason also gave this a thumbs up on https://trello.com/c/gRkjWMSv/595-publication-workflow so it's good to go once 5.4.2 is live. I'll stick an on-hold label on it now just to make sure it doesn't get merged too soon by mistake.


build/release failed.

Hi, samuelmeuli and wcatron;
Thanks a lot for this Action.
I have error on github action.
my action file is copy is https://github.com/samuelmeuli/mini-diary/blob/master/.github/workflows/release.yml
I changed
- name: Build/release Electron app
uses: samuelmeuli/action-electron-builder@v1
to
  - name: Build/release Electron app
    uses: samuelmeuli/action-electron-builder@master

only.
package.json
...
"scripts": {
"build": "yarn build-all && electron-builder --mac --windows",
"build-all": "concurrently "yarn build-main" "yarn build-renderer"",
"build-main": "cross-env NODE_ENV=production webpack --config ./configs/webpack.config.main.prod.babel.js --colors",
"build-renderer": "cross-env NODE_ENV=production webpack --config ./configs/webpack.config.renderer.prod.babel.js --colors",
"postinstall": "node -r @babel/register internals/scripts/CheckNativeDep.js && yarn flow-typed && electron-builder install-app-deps && yarn build-dll && opencollective-postinstall",
"release": "yarn build-all && electron-builder --mac --windows --publish always"
},
"build": {
"productName": "ElectronReact",
"appId": "com.tmksolutions.kztmk.electron_boilerplate",
"files": [
"dist/",
"node_modules/",
"app.html",
"main.prod.js",
"main.prod.js.map",
"package.json"
],
"mac": {
"hardenedRuntime": true,
"entitlements": "./app/build/entitlement.plist",
"entitlementsInherit": "./app/build/entitlement.plist"
},
"dmg": {
"contents": [
{
"x": 130,
"y": 220
},
{
"x": 410,
"y": 220,
"type": "link",
"path": "/Applications"
}
]
},
"win": {
"target": [
{
"target":"nsis",
"arch":[
"ia32",
"x64"
]
}
]
},
"linux": {
"target": [
"deb",
"rpm",
"AppImage"
],
"category": "Development"
},
"directories": {
"buildResources": "resources",
"output": "release"
},
"publish": {
"provider": "github",
"owner": "kztmk",
"repo": "kztmk/kztmk-electron-boilerplate",
"private": false
}
},
So I have got error
⨯ Build for macOS is supported only on macOS, please see https://electron.build/multi-platform-build
on github action release(windows-2019)
Please tell me how I can correct this error.
Thanks.

I changed
script {
"build": "yarn build-all",
"release": "yarn build-all && electron-builder --mac --windows --publish always"
}
Then it worked perfectly.
Thanks.


Something wrong with google login

Verify latest release

[X] I verified that the issue exists in the latest chatgpt release

Verify webapp is working

[X] I verify that the ChatGPT webapp is working properly for this account.

Environment details
I deployed the application on linux and opened the browser on my windows through X11 SERVER
Describe the Bug
Error: No element found for selector: button[data-provider="google"]
at assert (/home/bhh/chatgpt-api/node_modules/puppeteer-core/lib/cjs/puppeteer/util/assert.js:28:15)
at IsolatedWorld.click (/home/bhh/chatgpt-api/node_modules/puppeteer-core/lib/cjs/puppeteer/common/IsolatedWorld.js:221:25)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at getOpenAIAuth (/home/bhh/chatgpt-api/src/openai-auth.ts:141:9)
at ChatGPTAPIBrowser.initSession (/home/bhh/chatgpt-api/src/chatgpt-api-browser.ts:136:7)
at main (/home/bhh/chatgpt-api/demos/demo-conversation-browser.ts:26:3)

The same error.

https://github.com/transitive-bullshit/chatgpt-api/releases/tag/v3.3.5 should fix this.
Huge thanks to @suhaotian for the PR https://github.com/transitive-bullshit/chatgpt-api/pull/205
Please re-open if you're still running into this after upgrading.


Radiant victory again

It happened twice in a row today.

Someone of dire team had not picked the builder during the pick time and he couldnt pick during the level one coz its impossible now (after  patch 7.00)
Naturally this guy  had abandoned the game (at level one before creeps spawn)  and radiant team got automatic win just in time when creeps must spawn.

I described you 2 bugs:

autimatic win of radiant team ( its ALWAYS RADIANT VICTORY)
impossibility to pick hero if you passed the pick time.

Fix it please.

even when radiant leaves?

Тщ
if radiant leaves the game continues

I removed the auto ending when a team leaves, is it working now?

It will take time to check

yes it fixed


Migrating from RPM to Kubernetes: Waits for pod named 'uyuni' when pod has generated name

Once the pod has started up, and systemd is considered started, it looks like it tries to locate the node the pod is running on.
However, the search it does is via the pod name 'uyuni', while the true pod was named uyuni-684b544d99-dnqhk by the deployment.
This causes it to fail out, due to unable to locate the pod.
Debug output:
2:05PM DBG shared/utils/exec.go:67 > Running: kubectl get -o jsonpath={.items[?(@.metadata.name=="uyuni")].status.readyReplicas} deploy -n uyuni
⠋ kubectl get pod -lapp=uyuni -A -o=jsonpath={.items[0].metadata.name}
⠋ kubectl exec uyuni-684b544d99-dnqhk -- systemctl is-active -q multi-user.target
⠋ kubectl get pod uyuni -o jsonpath={.items[*].spec.nodeName}
2:05PM DBG shared/utils/exec.go:67 > Running: kubectl get pod uyuni -o jsonpath={.items[*].spec.nodeName}
⠋ kubectl get pod uyuni -o jsonpath={.items[*].spec.nodeName}
⠋ kubectl get pod uyuni -o jsonpath={.items[*].spec.nodeName}
⠋ kubectl get pod uyuni -o jsonpath={.items[*].spec.nodeName}

[repeats]

Error: cannot find node running uyuni: cannot find node name matching filter uyuni

Manually ran:
> kubectl get pod uyuni -o jsonpath={.items[*].spec.nodeName}
Error from server (NotFound): pods "uyuni" not found

If i switch to a label selector manually, it works properly
> kubectl get pod -l app=uyuni -o jsonpath={.items[*].spec.nodeName}
sesian-worker-2726fd44-rjwlf

Environment:

Harvester cluster with 3 nodes using longhorn
RKE2 cluster on top of openSUSE MicroOS
Manually created volumes to have some use different storage classes

Migration command:
mgradm migrate kubernetes uyuni.i.hackerguild.com --helm-uyuni-namespace uyuni --helm-uyuni-values values.yaml --logLevel debug
values.yaml
storageClass: "-"
matchPvByLabel: true
ingress: nginx
ingressSslAnnotations:
    cert-manager.io/cluster-issuer: letsencrypt-digitalocean

I can't remember facing this during my recent migration tests.

PR merged


Feature: animaiton for switching tabbed windows

Good day to you!
Suggesting adding animation for switching windows in tabbed mode
Thank you!

does this need to remain open?

yes


syntax errors in LaravelCaffeineService.php

Expected Behavior
Actual Behavior
I have just installed laravel-caffeine and there seems to be multiple syntax errors on lines 28, 33 and 38.
Environment

PHP Version: 7.0
Laravel Version: 5.4
LaravelCaffeine Version:latest

Stack Trace

Of which file(s)? With what error(s)?

LaravelCaffeineService.php
The first one:
FatalErrorException in LaravelCaffeineService.php line 28:
syntax error, unexpected ':', expecting ';' or '{'

@Bulmer Your still running PHP 5.6 then. Its possible that your CLI PHP is 7.0 but your webserver PHP is not.

Ok, false alarm. My PHP version jumped back to 5.6 at a recent reboot (im running both versions locally).


Integration testing

Hi @myquay
How do I mock a service in a tenant container?
For example, suppose:
.AddMultiTenancy...
    .WithTenantedServices((services, tenant) => {
           services.AddSingleton<SomeService>();
    });

Then in my integration tests when I usually want to mock a service, for example:
hostBuilder.ConfigureServices(s => s.AddSingleton<ISomeService>(_ => someServiceMock.Object));

But since it's in its own container which is resolved internally, this does not return someServiceMock but instead the real service.
I was thinking of mocking the MultiTenantServiceProviderFactory but it's internal...

Hi @brettwinters,
This is a really good question; I'll need to set aside some time to look into this one for you. I don't have anything more to add at this point but it's on my radar :)
Thanks,
Michael


[Plugin] allow running the plugin on Gradle 5.6

Add ApolloExtension.relaxGradleVersionCheck as a workaround for users stuck on Gradle 5.6. Anything lower than Gradle 5.6 will not work because the plugin is using some 5.6 Provider APIs like Provider.orElse
Fixes #2536

Thanks for making it! It'll be clearer that way and we can always refine later if/when we find edge cases with 5.6


Connection failed to xiaomi gateway3 at Setup

Setup failed for custom integration xiaomi_gateway3: Can't connect to gateway

The gateway is working fine in the Xiaomi App.
Home Assistant version: 2023.1.5
Xiaomi Multimode Gateway CN version 1.5.1_0032
The error appeared after integration was deleted and reinstalled other versions.
Reinstallation comes from entity no longer in use issue during version v3.0-alpha.1 as per https://github.com/AlexxIT/XiaomiGateway3/issues/925 recommended.
Attempts have been tried so far:

reinstalled with different versions in different browsers: master/ v3.0-alpha.1/ v2.1
1.a v3.0-alpha.1 with manual open telnet input was working fine but facing the same connection issue now
reset the xiaomi gateway 3
Host and token had been validated from the cloud configuration via custom integration

My next attempt will be

Getting a new xiaomi gateway3

Meanwhile what else can I do to deal with this situation? Thanks in advance!
Or what other info do I need to provide? (really new to HA)

You need to check error description in the Hass log

the same problem...don't have the open telnet command option, and when I want to add my gateway, tips show that can't connect the gateway. the attached is log, I run the HA in docker with host internet. thanks

Device offline is a problem with your network.

You need to check error description in the Hass log
The error didn't show up again with the same setting, connection resumed, thanks for the response.


Revert "Patch sdl sys"

Reverts Kethku/neovide#373

@Kethku realized that the build for sdl2 for Windows was broken for a while. Sorry about the chaos.


Add notifier secret to chart

Signed-off-by: Tamal Saha<EMAIL_ADDRESS>

Codecov Report

Merging #349 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #349   +/-   ##
======================================
  Coverage    0.95%   0.95%
======================================
  Files           5       5
  Lines         418     418
======================================
  Hits            4       4
  Misses        414     414

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c6b871...5e65862. Read the comment docs.


Add tooltip to Uniswap Roi input

Right now APY is auto-populated to 20%.  Ideally we'd automate pulling in current APY but didn't find an easy way to do this yet.  In the meantime it would be nice to suggest to users how they can find this # out themselves.

Google Sheet
UniswapRoi
Other?

We could read it from these two Yearn contracts: uniswaproi and uniswapapr.
But first, I need to understand what this APY number represents in terms of the available ROI and APR data.
Here you can take a look at what the different contract function calls are currently returning:
Read uniswaproi Contract
Read uniswapapr Contract.