Does not work for bows and crossbows

Hello, i updated TiC and this mod yesterday. (TinkerToolLeveling-1.12-1.0.3.jar)
The changelog says:
"Bows and Crossbows now also get XP for hitting stuff with them."
This is not the case. Bows and crossbows have no Information for xp on them at all.

Try reproducing with only TTL, TiC, Mantle and Forge version. Lastest versions.

No need, i do that regulary before reporting issues - issue persists.

Hold f3 and C for 10 seconds, and post the crashlog please.

Here you go:

---- Minecraft Crash Report ----
WARNING: coremods are present:
Contact their authors BEFORE contacting forge
// I just don't know what went wrong :(
Time: 12/10/17 3:40 PM
Description: Manually triggered debug crash
java.lang.Throwable
at net.minecraft.client.Minecraft.func_184118_az(Minecraft.java:1923)
at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1806)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1096)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:397)
at net.minecraft.client.main.Main.main(SourceFile:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
A detailed walkthrough of the error, its code path and all known details is as follows:
-- Head --
Thread: Client thread
Stacktrace:
at net.minecraft.client.Minecraft.func_184118_az(Minecraft.java:1923)
-- Affected level --
Details:
Level name: MpServer
All players: 1 total; [EntityPlayerSP['D3nnis3n'/1914, l='MpServer', x=220.56, y=72.76, z=242.36]]
Chunk stats: MultiplayerChunkCache: 279, 279
Level seed: 0
Level generator: ID 00 - default, ver 1. Features enabled: false
Level generator options:
Level spawn location: World: (204,64,256), Chunk: (at 12,4,0 in 12,16; contains blocks 192,0,256 to 207,255,271), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,0,0 to 511,255,511)
Level time: 1368 game time, 1368 day time
Level dimension: 0
Level storage version: 0x00000 - Unknown?
Level weather: Rain time: 0 (now: false), thunder time: 0 (now: false)
Level game mode: Game mode: creative (ID 1). Hardcore: false. Cheats: false
Forced entities: 80 total; [EntityParrot['Parrot'/7, l='MpServer', x=147.25, y=69.10, z=238.53], EntityParrot['Parrot'/8, l='MpServer', x=146.75, y=72.00, z=241.25], EntityPig['Pig'/9, l='MpServer', x=143.50, y=68.00, z=238.50], EntityBat['Bat'/2059, l='MpServer', x=211.56, y=55.22, z=311.25], EntityBat['Bat'/2060, l='MpServer', x=203.44, y=58.95, z=305.58], EntityPig['Pig'/14, l='MpServer', x=167.50, y=81.00, z=207.50], EntityPig['Pig'/15, l='MpServer', x=167.50, y=81.00, z=207.50], EntityPig['Pig'/16, l='MpServer', x=167.50, y=79.00, z=213.97], EntityPig['Pig'/17, l='MpServer', x=188.50, y=75.00, z=208.50], EntityPig['Pig'/18, l='MpServer', x=186.50, y=76.00, z=211.50], EntityPig['Pig'/19, l='MpServer', x=186.50, y=76.00, z=213.50], EntityPig['Pig'/20, l='MpServer', x=186.50, y=76.00, z=214.50], EntityPig['Pig'/28, l='MpServer', x=219.41, y=65.00, z=249.47], EntitySkeleton['Skeleton'/2591, l='MpServer', x=201.50, y=55.00, z=307.50], EntitySkeleton['Skeleton'/2592, l='MpServer', x=201.50, y=55.00, z=306.50], EntityPig['Pig'/33, l='MpServer', x=251.72, y=68.00, z=280.84], EntityCreeper['Creeper'/2594, l='MpServer', x=207.50, y=55.00, z=301.50], EntityCreeper['Creeper'/2595, l='MpServer', x=208.50, y=55.00, z=306.50], EntityPig['Pig'/38, l='MpServer', x=251.50, y=66.00, z=169.50], EntityPig['Pig'/39, l='MpServer', x=249.50, y=66.00, z=173.50], EntityPig['Pig'/40, l='MpServer', x=255.50, y=65.00, z=178.50], EntitySheep['Sheep'/41, l='MpServer', x=258.50, y=64.00, z=219.50], EntitySheep['Sheep'/42, l='MpServer', x=262.50, y=63.00, z=219.50], EntitySheep['Sheep'/43, l='MpServer', x=261.50, y=63.00, z=219.50], EntitySheep['Sheep'/44, l='MpServer', x=269.27, y=65.00, z=211.54], EntityPig['Pig'/48, l='MpServer', x=276.02, y=63.00, z=288.62], EntityPig['Pig'/49, l='MpServer', x=275.50, y=63.00, z=287.01], EntitySkeleton['Skeleton'/2609, l='MpServer', x=231.50, y=59.00, z=178.50], EntityPig['Pig'/50, l='MpServer', x=276.50, y=63.00, z=286.50], EntitySpider['Spider'/2357, l='MpServer', x=257.69, y=47.00, z=209.97], EntityCreeper['Creeper'/2362, l='MpServer', x=254.50, y=45.00, z=207.50], EntityBat['Bat'/2622, l='MpServer', x=240.81, y=15.07, z=211.19], EntitySkeleton['Skeleton'/2369, l='MpServer', x=192.50, y=17.00, z=314.50], EntityZombie['Zombie'/2114, l='MpServer', x=243.50, y=42.00, z=302.50], EntityCreeper['Creeper'/2633, l='MpServer', x=245.50, y=47.00, z=185.50], EntityCreeper['Creeper'/2634, l='MpServer', x=249.50, y=47.00, z=187.50], EntityCreeper['Creeper'/2649, l='MpServer', x=150.50, y=25.00, z=231.50], EntityCreeper['Creeper'/2395, l='MpServer', x=253.50, y=42.00, z=308.50], EntitySkeleton['Skeleton'/2651, l='MpServer', x=150.50, y=25.00, z=230.50], EntityCreeper['Creeper'/2396, l='MpServer', x=251.50, y=42.00, z=309.50], EntityBat['Bat'/2142, l='MpServer', x=158.82, y=52.21, z=247.91], EntityBat['Bat'/2143, l='MpServer', x=156.08, y=55.80, z=249.42], EntityItem['item.item.porkchopRaw'/2655, l='MpServer', x=223.88, y=65.00, z=255.13], EntityBat['Bat'/2169, l='MpServer', x=229.47, y=49.19, z=311.38], EntityBat['Bat'/2173, l='MpServer', x=227.69, y=48.31, z=311.28], EntityPlayerSP['D3nnis3n'/1914, l='MpServer', x=220.56, y=72.76, z=242.36], EntitySkeleton['Skeleton'/2697, l='MpServer', x=231.81, y=46.00, z=292.70], EntityCreeper['Creeper'/2699, l='MpServer', x=228.50, y=44.00, z=266.50], EntitySkeleton['Skeleton'/2700, l='MpServer', x=224.52, y=45.00, z=275.29], EntitySkeleton['Skeleton'/2701, l='MpServer', x=223.78, y=44.00, z=271.49], EntitySkeleton['Skeleton'/2702, l='MpServer', x=224.10, y=44.00, z=273.44], EntityZombie['Zombie'/2450, l='MpServer', x=150.50, y=36.00, z=227.50], EntityCreeper['Creeper'/2712, l='MpServer', x=252.83, y=47.00, z=278.51], EntityCreeper['Creeper'/2466, l='MpServer', x=253.50, y=45.00, z=202.50], EntitySkeleton['Skeleton'/2212, l='MpServer', x=186.50, y=15.00, z=300.50], EntityChicken['Chicken'/2469, l='MpServer', x=253.50, y=45.00, z=203.50], EntityCreeper['Creeper'/2472, l='MpServer', x=217.50, y=53.00, z=286.50], EntitySkeleton['Skeleton'/2219, l='MpServer', x=176.50, y=19.00, z=251.50], EntityCreeper['Creeper'/2736, l='MpServer', x=271.78, y=15.00, z=276.57], EntitySkeleton['Skeleton'/2748, l='MpServer', x=249.50, y=46.00, z=213.50], EntitySkeleton['Skeleton'/2242, l='MpServer', x=220.50, y=57.00, z=316.50], EntityZombie['Zombie'/2754, l='MpServer', x=205.50, y=67.00, z=281.50], EntityZombie['Zombie'/2757, l='MpServer', x=193.20, y=51.00, z=304.48], EntityBat['Bat'/1994, l='MpServer', x=171.01, y=14.16, z=215.13], EntitySkeleton['Skeleton'/2506, l='MpServer', x=155.70, y=24.24, z=225.01], EntitySkeleton['Skeleton'/2762, l='MpServer', x=190.50, y=58.00, z=296.70], EntitySkeleton['Skeleton'/2763, l='MpServer', x=190.50, y=58.00, z=296.08], EntityBat['Bat'/2767, l='MpServer', x=149.99, y=55.28, z=257.40], EntityItem['item.item.seeds'/2515, l='MpServer', x=266.51, y=63.00, z=231.72], EntityBat['Bat'/2771, l='MpServer', x=147.07, y=32.82, z=245.88], EntityItem['item.item.seeds'/2516, l='MpServer', x=267.28, y=63.00, z=231.75], EntityBat['Bat'/2773, l='MpServer', x=148.55, y=32.40, z=245.17], EntityBat['Bat'/2774, l='MpServer', x=146.97, y=32.76, z=244.66], EntityItem['item.item.seeds'/2519, l='MpServer', x=263.13, y=64.00, z=198.83], EntityCreeper['Creeper'/2782, l='MpServer', x=260.50, y=30.00, z=302.50], EntityZombie['Zombie'/2783, l='MpServer', x=260.50, y=30.00, z=300.50], EntityItem['item.tile.mushroom'/2535, l='MpServer', x=248.30, y=66.00, z=195.10], EntityItem['item.item.porkchopRaw'/2539, l='MpServer', x=218.97, y=63.00, z=248.79], EntityXPOrb['Experience Orb'/2541, l='MpServer', x=218.79, y=63.00, z=251.72], EntitySkeleton['Skeleton'/2288, l='MpServer', x=247.50, y=53.00, z=317.50]]
Retry entities: 0 total; []
Server brand: fml,forge
Server type: Integrated singleplayer server
Stacktrace:
at net.minecraft.client.multiplayer.WorldClient.func_72914_a(WorldClient.java:532)
at net.minecraft.client.Minecraft.func_71396_d(Minecraft.java:2748)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:418)
at net.minecraft.client.main.Main.main(SourceFile:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
-- System Details --
Details:
Minecraft Version: 1.12.2
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_144, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory:<PHONE_NUMBER> bytes (3918 MB) /<PHONE_NUMBER> bytes (5030 MB) up to<PHONE_NUMBER> bytes (7282 MB)
JVM Flags: 4 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms4096M -Xmx8192M -XX:MaxPermSize=128M
IntCache: cache: 0, tcache: 0, allocated: 12, tallocated: 94
FML: MCP 9.42 Powered by Forge <IP_ADDRESS>9 Optifine OptiFine_1.12.2_HD_U_C6 7 mods loaded, 7 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored

State
ID
Version
Source
Signature

UCHIJAAAA
minecraft
1.12.2
minecraft.jar
None

UCHIJAAAA
mcp
9.42
minecraft.jar
None

UCHIJAAAA
FML
<IP_ADDRESS>
forge-1.12.2-<IP_ADDRESS>9.jar
e3c3d50c7c986df74c645c0ac54639741c90a557

UCHIJAAAA
forge
<IP_ADDRESS>9
forge-1.12.2-<IP_ADDRESS>9.jar
e3c3d50c7c986df74c645c0ac54639741c90a557

UCHIJAAAA
mantle
1.12-<IP_ADDRESS>
[CS]-Mantle-<IP_ADDRESS>.jar
None

UCHIJAAAA
tconstruct
1.12-<IP_ADDRESS>
[T]-TinkersConstruct-<IP_ADDRESS>.jar
None

UCHIJAAAA
tinkertoolleveling
1.12-1.0.3.DEV.56fac4f
[T]-TinkerToolLeveling-1.0.3.jar
None

Loaded coremods (and transformers):
GL info: ' Vendor: 'NVIDIA Corporation' Version: '4.6.0 NVIDIA 387.92' Renderer: 'GeForce GTX 1080/PCIe/SSE2'
Pulsar/tconstruct loaded Pulses:
- TinkerCommons (Enabled/Forced)
- TinkerTools (Enabled/Not Forced)
- TinkerHarvestTools (Enabled/Forced)
- TinkerMeleeWeapons (Enabled/Forced)
- TinkerRangedWeapons (Enabled/Forced)
- TinkerModifiers (Enabled/Forced)
- TinkerSmeltery (Enabled/Not Forced)
- TinkerOredict (Enabled/Forced)
- TinkerIntegration (Enabled/Forced)
- TinkerFluids (Enabled/Forced)
- TinkerMaterials (Enabled/Forced)
- TinkerModelRegister (Enabled/Forced)
Launched Version: 1.12.2
LWJGL: 2.9.4
OpenGL: GeForce GTX 1080/PCIe/SSE2 GL version 4.6.0 NVIDIA 387.92, NVIDIA Corporation
GL Caps: Using GL 1.3 multitexturing.
Using GL 1.3 texture combiners.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Shaders are available because OpenGL 2.1 is supported.
VBOs are available because OpenGL 1.5 is supported.
Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'fml,forge'
Type: Client (map_client.txt)
Resource Packs: PureBDCraft-128.zip
Current Language: English (US)
Profiler Position: N/A (disabled)
CPU: 16x AMD Ryzen 7 1700 Eight-Core Processor

I can do one of the complete modpack too, if you wish.

And a question: With hitting do you mean Shooting them with the arrows or just using it like a sword?

The crashlog should also contain the full startup log, if you can also post that. And I see you're using forge 2559, can you try if it also happens with 2552?

I think you want this: https://gist.github.com/D3nnis3n/e64d867ae3030aa7510785d3e4094fe4
Yes, happens with 2552 too.

You have other mods in there, and it seems to be missing stuff.
Usually the latest.log is fine

This ist the fml-client-latest.log and no, there are no other mods despite optifine active. latest.log is only 1kb with nothin interesting in it, do you need it?
What is missing?

Optifine IS another mod. Even worse, a coremod.
And it's missing everything past preInit. Which is about 2/3 of the steps required to start.

Sorry, i cannot remove Optifine - i Need it to scale down the Resolution to Full HD from my 4K Monitor, otherwise graphics will Crash on Startup. Without optifine this is not possible.
The log is everything that got logged in the respective file, nothing is missing from the log. If the log is not complete, i do not know why.

I found a fml-early-junk-Startup log, maybe this one is what you search for or is missing?
https://gist.github.com/D3nnis3n/2d6c77931cb8dda06a8c72688325524a

While this has all the stages, it's a different kind of output, not the one I'd need.
If you can't reproduce it with a fresh instance (No previous world. No previous configs) without any additional mods it's pretty much useless to me, since I can't rule out that it's those mods causing it. It works otherwise, after all.

Kay, seems like no fix for me. I can't disable Optifine as i told, game does not work otherwise. :(
Thank you anyway.

It would be great if this could be resolved. Arrows do level. and if i mele then so do bows.. but who would mele a bow?
Should level when fired with arrows

Congratulations on completely missing the point of the issue, @Th232.
@D3nnis3n maybe somebody else with the issue will come around, and I can reproduce it then. If it isn't another mods fault.

I hope so.

Happens

Leveling on ranged weapons works fine on latest 12.2 for me but it is broken in FTB Beyond.
So do with that information what you'd like

Because FTB beyond is a 1.10 pack....?

1 question: are you using the latest tinkers tools leveling mod with the latest tinkers tool leveling bolts/arrows (the bolt and arrow with levels)?

Cleanup.


[BUG] Adding new WTO changes numbering

When you add a new WTO, it's numbered WTO01. However, when you add a second WTO, it gets numbered WTO01 and the previous one becomes WTO02.

That is as designed. They are numbered in order they appear. So if you add before existing one then the existing will get number increased. When you delete they all get renumbered. But the links in inputs and outputs remain unchanged and linked to proper module (at the time of assignment).

 If you add at the end (scroll after your first WTO and add, it does not renumber. If there is general need to do so, I will reework it. But I really would like to documented first with all cases: what happens if I delete WTO? Should it renumber or should the others keep the numbers? And there is more questions like that. Currently they are always numbered in the order they are in list and they will not get renumbered if you keep adding modules AFTER the current module.


perf(SCC): Releasing SCC v2 Node SDK

BREAKING CHANGE: SCC v2 Node SDK
PR summary
BREAKING CHANGE: SCC v2 Node SDK
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix assigned but unused variable warnings

Testing with -w option output following warnings:
$ bundle exec  rspec -w
./spec/support/active_record.rb:151: warning: assigned but unused variable - primary_key
./spec/support/active_record.rb:4: warning: already initialized constant ROOT
./spec/support/active_record.rb:4: warning: previous definition of ROOT was here
./spec/support/active_record.rb:6: warning: already initialized constant DB_CONFIG
./spec/support/active_record.rb:6: warning: previous definition of DB_CONFIG was here

This warning means primary_key is considered just variable not "#primary_key=" method.
So calling it with self. is required.

Thanks @walf443, good catch. And thank you again for all your work on this gem! I do very much appreciate it :)
It looks like we're loading this file twice (at least). Perhaps we should deal with that (RE the reinitialised constants) rather than conditionally set the constant? We could define those constants in the rspec support harness instead?

One failing test for some reason:
Duck
609  a rearrangement
610    with max value
611
...
614
615        should eq [201, 204, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, ... 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 202] (FAILED - 1)
616    with min value

We sometimes get an intermittent test failure with Postgres. I've never been able to figure it out but it seems like a timing issue. I've rebuilt the test, so hopefully it passes.

@brendon Test passed!!

Nice! One day I'd like to get to the bottom of that issue, but for today we can carry on :D


Support turning off the EnableJitInDiagMode flag

When EnableJitInDiagMode was set to false, Codegen was still issuing JIT
JIT debug was previously force disabled on xplat, turn off the flag on xplat.
also fixes a bug reported by OSS-FUZZ (originally reported under #3352)
#3352 still tracks enabling DebugJIT back on xplat

CI errors are unrelated to the changes on this PR

I am curious why this flag is of any use now. Shouldn't we get rid of this flag?

@akroshg #3352

@dotnet-bot test Ubuntu shared_ubuntu_linux_release  please

@dotnet-bot test Ubuntu static_ubuntu_linux_debug please

Closing this one #4310 and #4311


[tests-only] [full-ci] Adjust public upload expected filename for ocis

Description
[WIP] Test against core branch public-upload-filename-for-ocis
Related Issue
How Has This Been Tested?
CI
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

https://drone.owncloud.com/owncloud/ocis/16959/51/6
  Scenario Outline: Uploading same file to a public upload-only share multiple times via new API    # /drone/src/oc10/testrunner/tests/acceptance/features/apiSharePublicLink3/uploadToPublicLinkShare.feature:24
    Given user "Alice" has created a public link share with settings                                # FeatureContext::userHasCreatedAPublicLinkShareWithSettings()
      | path        | FOLDER |
      | permissions | create |
    When the public uploads file "test.txt" with content "test" using the new public WebDAV API     # PublicWebDavContext::thePublicUploadsFileWithContentUsingThePublicWebDavApi()
    And the public uploads file "test.txt" with content "test2" using the new public WebDAV API     # PublicWebDavContext::thePublicUploadsFileWithContentUsingThePublicWebDavApi()
    Then the HTTP status code of responses on each endpoint should be "<httpStatuses>" respectively # FeatureContext::theHTTPStatusCodeOfResponsesOnEachEndpointShouldBe()
    And the following headers should match these regular expressions                                # FeatureContext::headersShouldMatchRegularExpressions()
      | ETag | /^"[a-f0-9:\.]{1,32}"$/ |
    And the content of file "/FOLDER/test.txt" for user "Alice" should be "test"                    # FeatureContext::contentOfFileForUserShouldBe()
    And the content of file "<secondFileName>" for user "Alice" should be "test2"                   # FeatureContext::contentOfFileForUserShouldBe()

    Examples:
      | secondFileName       | httpStatuses |
      | /FOLDER/test (1).txt | 201,204      |
        Failed step: And the content of file "/FOLDER/test.txt" for user "Alice" should be "test"
        The content was expected to be 'test', but actually is 'test2'. HTTP status was 200
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'test'
        +'test2'

oCIS is not implementing this at all at present. With a public upload-only link, if "the public" uploads files with the same name, then the first upload should go normally, and the 2nd upload should be stored as a different file name test (1).txt or test(2).txt or some automatic-name-generation scheme. Both uploads would get a 201 HTTP status.
But currently the 2nd upload gets a 204 HTTP status and overwrites the content of the existing file. I adjusted the core test to show that better - now the test fails where it checks the content of the first uploaded file.

This PR is no longer needed. See comment https://github.com/owncloud/core/pull/40508#issuecomment-1384880288


Compatibility with Atom Material UI theme

Hi. I found, that my lovely syntax theme not compatible with material ui in Atom. This is result:

I found solution here https://github.com/atom-material/atom-material-ui/issues/239 and here https://github.com/carloe/spacegray-base16-ocean-dark/pull/13 but I'm not good in CSS =(
If you can fix this, I'll be very grateful =) Thank you

I don't actually use Atom any more, sorry! I just maintain this repo for the folks that do. If someone opens a PR I'll happily merge it!

@cannikin Thank you for answer, maybe I'll try to spend some time and understood, what need to be changed)


Run custom function on click?

I would like to know if there is an alternative to trigger a custom function in Vue on click?
As an example I'd like to change the width of the keyboard as I toggle between the numeric and the default keys.

Any news about this issue?

fixed in #40  but not release version


Syntax refactoring according to the jshint and editorconfig rules

convert indentation to 2 spaces
use new line after and before if statement
use curly braces in if and else statement
use new line before 'return' statement
use new line after var's statement
_.isUndefined() underscore method instead of === undefined

wow, lovely! tnx


Feature request: add cart workflow

User Story
As a customer I want to be able to collect items in a cart and check them out all at once so that I have a good overview of my purchases from my "shopping spree".
Reason
It is not only pretty common to have a cart workflow in place in a shopping system, but it would also make it easier to accumulate orders which will make it easier for the shop owner to fullfill the orders.
Proposal for solution
Add a Cart containing CartItems to the shop system and integrate the cart into the purchase workflow
Solution design

add a model "Cart"
add "CartItems" to the "Cart" containing the information from "item" and "subcategory" in an entity
add a confirmation step if a customer wants to buy all CartItems in the Cart
continue with the existing buy workflow on confirmation

Merged in #63


getAllSimData and related functions return unexpected number of time points when simulations fire events

When simulations fire events, PySCeS returns more than the requested number of events. This is unexpected because the documentation suggests that the results will be uniformly spaced in time. It would be helpful to make the returning of the additional time points corresponding to events an option rather than the default behavior.

This is the result of Assimulo's simulate() method of the CVode class: even when specifying the number of communication points with the ncp or ncp_list arguments, additional communication points are added when the event fires. In my view there is good reason for this. For example, if an event at time t would add 2 to species S, then at that time point there are actually two values of S, and this discontinuity is captured directly.
However, there is now a setting mod.__settings__['cvode_return_event_timepoints'] that can be set to False to only return those time points as specified in mod.sim_time. The default is still True. Implemented in the "assimulo" branch with c812ccf72e, will arrive in master once this branch is merged.

Thanks!


Remove standard '' depedency in common headers

Description
The standard <algorithm> header is expensive to compile in comparison to other standard headers. I have benchmarked this myself using clang++ -ftime-trace on a large SFML-powered codebase and it has also been experienced and verified by others in the past.
When benchmarking, I've noticed that many of my object files were taking an unexpected extra 800-900ms to compile due to <algorithm> being brought in by Rect.hpp. Upon investigation, I noticed that Rect.hpp only needs std::min and std::max -- including <algorithm> is overkill for that functionality.
Furthermore, Rect.hpp's usage of std::min and std::max is only on primitive types, which can generate suboptimal codegen when taken by reference in functions.
I removed the <algorithm> dependency in Rect.hpp by implementing two private static functions (getMin and getMax). I have also removed another <algorithm> depedency in JoystickImpl.hpp by using some simple loops.
Some other SFML files relied on transitive <algorithm> inclusion of std::size_t (which is pretty bad), so I fixed those by explicitly including <cstddef>.
Tasks

[ ] Tested on Linux
[x] Tested on Windows
[ ] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

How to test this PR?
Compile/run entirety of SFML + test suite.

I'm personally not a fan of this change, I don't think the benefit is worth it for the majority of users and prefer to keep the code cleaner/simpler

Not a fan of std::min/std::max change. However, replacing std::fill by a simple loop looks easier to understand to me.

@JonnyPtn @eliasdaler: I would keep the code as is if there weren't actual tangible benefits to this change. Unfortunately, until C++20 modules become widespread, header files come with a large baggage -- they're literally a copy-paste mechanism.
The <algorithm> header is one of the most expensive ones to include in terms of compilation time (see this article) and I have benchmarked it myself.
I have about 20 objects files in my project that end up depending on Rect.hpp due to transitive dependencies, and after this PR, each one takes 700-800ms less to compile which is a huge improvement for me. If this is not merged, it is worthwhile for me to maintain my own fork of SFML.
I think this change will benefit many users with faster compilation time, and possibly better codegen as std::min/std::max always take their argument by reference, which is a pessimization for primitive types.

Okay, faster compilation argument is pretty strong.
However, I think it's better to make replacement min/max functions free functions (somewhere in sf::priv namespace) instead of member functions.

Not to invalidate this PR, but wouldn't pre-compiled headers solve this issue for your code base?
It saved quite a lot of time in the ÖbEngine, but I'm not deep enough in the whole C++ build system world to fully judge.
I vote against the JoystickImpl changes:

Using algorithms over loops is the preferred way
It only adds to the SFML compile-time and not SFML user code compile-time

I agree that Rect.hpp as Vector2.hpp and similar should be lightweight enough, since they should be used generously.
Changing the private interface of a class to avoid a standard header doesn't seem like the best solution.
Would templated free functions in an anonymous namespace also work?

@SuperV1234 Can you share the results of your benchmark? I'm fully aware of how includes work and the costs involved, I'm just not convinced the cost here is significant enough to warrant the changes.
In my benchmarks the difference is so negligible as to almost be unnoticeable - can you provide more details on your benchmarks?

Discussed on Discord, not going forward with this idea as the advantages probably do not outweigh having to reimplement and maintain our own min/max and people should use PCH instead.

@SuperV1234 Could you summarize the important points from the Discord discussion here?
I'm generally also a fan of reducing compile times, especially if gets significant gains (almost 1s for a user) for little changes.
PCH are nice, but still a workaround and often intrusive (one needs to change every translation unit).
I don't think SFML (or many C++ libraries, for that matter) will migrate to C++20 modules anytime soon.

@Bromeon

Could you summarize the important points from the Discord discussion here?

At least three users felt that PCH is a better solution, some quotes:

it's not our job to optimize the compilation process of the users

pre-compiled headers are a thing and most big projects I've worked on uses them

(referring to the benefit of this PR)  A few seconds for every build of every project using SFML. That would be worth it, if there's no alternative, like PCH

It's not a few seconds for every project

it's bad code design to do it for a few and not all. It's inconsistent and doesn't give any big real advantage. It becomes a maintenance issue

Setting up PCH is as non-trivial as setting up a third party library like SFML. It's far from being as complicated as people make it to be

CMake even supports it, it's a peice of cake

Having never done any PCH before in my life, I was able to add it to a project I'm not really familiar with in a very short time period

At least one user felt that this could set a precedent for micro-optimization of compile-times

It would set a precedent though - where do we draw the line on micro-optimisations for users case studies?

we'd need our own utility/stdlib replacement header

And this is my main argument for not changing it - current code is cleanest, and there’s no strong empirical argument to change

On the context of possible run-time optimization when min/max do not get inlined, people felt debug performance is not important and the possible optimization is not guaranteed/worth it

Debug build performance DOES NOT matter

Thanks! While I don't agree with the "it's not our job" or "micro-optimization" arguments (it's almost 1s after all), I also don't see a nice solution other than rewriting min/max from scratch. I wouldn't have anything for such isolated instances, but this looks a bit like the start of "rewrite STL because we know better" trap that many game engines fell into.
But yes, dependencies in headers are a big problem in C++, especially with templates. There are countless workarounds at the build system level, but no really nice solutions in the language (not sure about modules). Just for completeness, explicit instantiation of the templates (for float, int, unsigned int) would also be a possibility, but I don't think it makes sense for SFML, and it would break user code that uses Rect, Vector2 and Vector3 with other types.


[Doc] Add metadata server backend explanation.

Doc update to explain the option of metadata server backend for vllm integration.

LGTM


[GHSA-v57x-gxfj-484q] Security Advisory for "Log4Shell"

Updates

Affected products

Comments
Not the maven package com.hazelcast:hazelcast is affected, but its transitive log4j dependency.
If software X uses a hazelcast as a maven dependency then the pom.xml file of software X can bump the log4j dependency to a fixed version without the need to also bump the hazelcast version. Security advisories for log4j already exists, for example CVE-2021-44228 = https://github.com/advisories/GHSA-jfh8-c2jp-5v3q
No change has been made to com.hazelcast:hazelcast source code when the log4 version was bumped:
https://github.com/hazelcast/hazelcast/pulls?q=is%3Apr+"Bump+log4j2.version"
Therefore com.hazelcast:hazelcast should not be listed in the "Affected products" section.
The description of this advisory already correctly explains that not the com.hazelcast:hazelcast maven package but Hazelcast Management Center, Hazelcast IMDG, Hazelcast IMDG Enterprise, Hazelcast Jet and Hazelcast Platform are effected.

Hi there @kwart! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Given versions are considered to be vulnerable as the related ZIP, and TGZ distributions contain vulnerable log4j library (jar).

It is fine for maintainers of packages with vulnerable dependencies to publish GitHub Security Advisories about those dependencies. GHSA-v57x-gxfj-484q is a valid advisory that benefits users of com.hazelcast:hazelcast.


Update augur.net links to V2 ABI, Addresses, Contracts on the release tag.

We will need links to these resources -- but to the version that is specified by the v2 release tag.
ABI:
https://github.com/AugurProject/augur/blob/master/packages/augur-artifacts/src/abi.json
Addresses:
https://github.com/AugurProject/augur/blob/master/packages/augur-artifacts/src/environments/mainnet.json#L20
Contracts:
https://github.com/AugurProject/augur/blob/master/packages/augur-core/README.md

Duplicate of #7457


Added code and 5 png to make the Char run

Added the following code to make the character run as opposed to sliding from left to right;
function moveLeft() {
	//loop through the PNG pictures to give the effect of running. HTML5 canvas does not allow .gif file to tun
	var loopTimes=0;
	var playerCharacterImg = ["Pictures/good_guy1.png", "Pictures/good_guy2.png", "Pictures/good_guy1.png", "Pictures/good_guy2.png"];

		loopCharLEFT = setInterval(function(){
					for(var i=0; i < playerCharacterImg.length; i++){

					loopTimes++;
					if (loopTimes == playerCharacterImg.length - 1 ){
						loopTimes=0;
					}
				playerCharacter.image.src = (playerCharacterImg[loopTimes]);
				}

		}, 100);
	playerCharacter.changeDir(-1);
	playerCharacter.speedX = -5;

}

function moveRight() {
	var loopTimes=0;
	var playerCharacterImg = ["Pictures/good_guy1.png", "Pictures/good_guy2.png", "Pictures/good_guy1.png", "Pictures/good_guy2.png"];
			loopCharRIGHT =	setInterval(function(){
						for(var i=0; i < playerCharacterImg.length; i++){
						loopTimes++;
						if (loopTimes == playerCharacterImg.length - 1){
							loopTimes=0;
						}
					playerCharacter.image.src = (playerCharacterImg[loopTimes]);
					}

			}, 100);
	playerCharacter.changeDir(1);
	playerCharacter.speedX = 5;

}

HTML5 canvas did not allow for gif animation. So I had to take the same .png file and created three more in photoshop to give the running effect. It would've been easy otherwise to replace the
playerCharacter.init(60, 70, `Pictures/${char.name}.png`, char.x2, char.y2, "image", 1, undefined, char.name); with
playerCharacter.init(60, 70, `Pictures/${char.name}.gif`, char.x2, char.y2, "image", 1, undefined, char.name);
I am working on the creating the same effect for other characters as well as Jumping and dying effect for all the characters.

@Aseged Thanks for the contribution, I agree that it would be a lot easier if the Canvas allowed gifs.
The effect works great, but the animation does not stop when the player character stops.
The other effects you mentioned sounds great, remember to open new issues for them so others know what your working on.

@EdwardDunn  Thanks for the feedback. I see the issue, I'm on it. I will also open issues to add interaction to each character.

@Aseged Closed due to inactivity


[chatgpt] startegy add prepare method

📌 Checklist before creating the PR

[ ] I have created an issue for this PR for traceability
[ ] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
[x] I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge
e.g. fixed #1234, closed #1234, resolved #1234

NA
📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Add prepare() method for Strategy class. This helps users to prepare their models and optimizers easiy based on each strategy.
# when fine-tuning actor and critic
(actor, actor_optim), (critic, critic_optim), reward_model, initial_model = strategy.prepare((actor, actor_optim), (critic, critic_optim), reward_model, initial_model)
# or when training reward model
(reward_model, reward_model_optim) = strategy.prepare((reward_model, reward_model_optim))
# or just inference
actor, critic = strategy.prepare(actor, critic)

💥 Checklist before requesting a review

[ ] I have linked my PR to an issue (instruction)
[ ] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
[x] I have performed a self-review of my code
[ ] I have added thorough tests.
[x] I have added docstrings for all the functions/methods I implemented

⭐ Do you enjoy contributing to Colossal-AI?

[x] 🌝 Yes, I do.
[ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

I think it is not same to accelerate, accelerate know also have trainer

历史上的今天发生哪些大事？


sample code input in tsdoc

VSCode Version: Version 1.30.0-insider (1.30.0-insider) cd5b4d1bb3fc7e509fba077095b2b280b8ff7161
OS Version: macOS 10.14.1 (18B75)

Steps to Reproduce:

open typescript file

input codes as below

/**
 * ```ts
 * f
 * ```
 */

show as image:

input Enter

show as image:

missing leading * in input.

related: https://github.com/Microsoft/vscode/issues/63942

previous issue: https://github.com/Microsoft/vscode/issues/64138

Does this issue occur when all extensions are disabled?: Yes

@vscodebot #64138 was mistakenly closed

Duplicate of #64138
That issue was closed as out of scope. It effort required is not worth the limited benefit


deepin.deepin-menu: 3.3.10 -> 3.4.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/deepin-menu/versions.
meta.description for deepin.deepin-menu is: '"Deepin menu service"'.
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
Warning: no invocation of /nix/store/mdiia75qrlvsgzjbnm8rvfaqnkaq7i1c-deepin-menu-3.4.0/bin/deepin-menu had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
directory tree listing: https://gist.github.com/fe89b36426ab6c80a198c9afd76074fa
du listing: https://gist.github.com/ad98ce8a079864ff3eb64cd58c21220d

Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:

Install cachix from https://cachix.org/
Use r-ryantm's cache:cachix use r-ryantm

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:
nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/0ccbf4112d6afd04588c6910d66e014d8a93f244.tar.gz -p deepin.deepin-menu
ls -la /nix/store/mdiia75qrlvsgzjbnm8rvfaqnkaq7i1c-deepin-menu-3.4.0

cc @romildo for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: deepin.deepin-menu
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: deepin.deepin-menu
Partial log (click to expand)
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mdiia75qrlvsgzjbnm8rvfaqnkaq7i1c-deepin-menu-3.4.0
shrinking /nix/store/mdiia75qrlvsgzjbnm8rvfaqnkaq7i1c-deepin-menu-3.4.0/bin/deepin-menu
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mdiia75qrlvsgzjbnm8rvfaqnkaq7i1c-deepin-menu-3.4.0/bin
patching script interpreter paths in /nix/store/mdiia75qrlvsgzjbnm8rvfaqnkaq7i1c-deepin-menu-3.4.0
checking for references to /build in /nix/store/mdiia75qrlvsgzjbnm8rvfaqnkaq7i1c-deepin-menu-3.4.0...
postPatchMkspecs
/nix/store/mdiia75qrlvsgzjbnm8rvfaqnkaq7i1c-deepin-menu-3.4.0

Success on aarch64-linux (full log)
Attempted: deepin.deepin-menu
Partial log (click to expand)
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w9m260g24k1hdyppb84h4ylpdhd6yi4x-deepin-menu-3.4.0
shrinking /nix/store/w9m260g24k1hdyppb84h4ylpdhd6yi4x-deepin-menu-3.4.0/bin/deepin-menu
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w9m260g24k1hdyppb84h4ylpdhd6yi4x-deepin-menu-3.4.0/bin
patching script interpreter paths in /nix/store/w9m260g24k1hdyppb84h4ylpdhd6yi4x-deepin-menu-3.4.0
checking for references to /build in /nix/store/w9m260g24k1hdyppb84h4ylpdhd6yi4x-deepin-menu-3.4.0...
postPatchMkspecs
/nix/store/w9m260g24k1hdyppb84h4ylpdhd6yi4x-deepin-menu-3.4.0


docker container now has net access

this allowed me to install nano to do alterations to sniproxy and db.override
when connected to the docker.

Closing this due to inactivity.


Make sure we don't overflow size_t when allocating the parser.

This is unlikely to occur (though technically possible) with 64-bit
pointers, but on platforms with a 32-bit pointers such as x32 it's
a very real possibility.  This would lead to silently allocating
less space than the code assumes, eventually leading to accessing
invalid memory.

Thanks for the changes.


Possible bug with tenant record generation

Python version:  3.6.6
NetBox version:  2.4.5-dev

Steps to Reproduce

Have a tenant record of some kind.
Attempt to make changes to any data record, whether the tenant is actually used in it, or not.

Expected Behavior
Data records successfully updated.

Observed Behavior
Intermittent failure of records to be added. Moving my databases to a separate VM seem to have helped. The tenant feature isn't critical to my use, so I've removed the references that I did use. This was happening in the last stable version too. The only reason I was able to pin this down to a Tenant entry, was the name that kept coming up as a missing index.
Log fragment 1
During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 856, in _resolve_look$
    (bit, current))  # missing attribute
django.template.base.VariableDoesNotExist: Failed lookup for key [disabled] in 'TENANTNAME'
Exception while resolving variable 'label' in template 'django/forms/widgets/select.html'.
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 835, in _resolve_look$
    current = current[bit]
TypeError: string indices must be integers

Log fragment 2
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 841, in _resolve_lookup
    if isinstance(current, BaseContext) and getattr(type(current), bit):
AttributeError: type object 'RequestContext' has no attribute 'return_url'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 849, in _resolve_lookup
    current = current[int(bit)]
ValueError: invalid literal for int() with base 10: 'return_url'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 856, in _resolve_lookup
    (bit, current))  # missing attribute
django.template.base.VariableDoesNotExist: Failed lookup for key [return_url] in [{'True': True, 'False': False, 'None': None}, {'csrf_token': <SimpleLazyObject: 'fCXySqReBAyEvPpKABVpF6N4TqrSDuvcd3wS1CxMfvQSwoBkxFs72SC14s0gbn3K'>, 'request': <WSGIRequest: GET '/tenancy/tenants/'>, 'MEDIA_URL': '/media/', 'user': <SimpleLazyObject: <User: michael>>, 'perms': <django.contrib.auth.context_processors.PermWrapper object at 0x7fbc56585e48>, 'messages': <django.contrib.messages.storage.fallback.FallbackStorage object at 0x7fbc5677ada0>, 'DEFAULT_MESSAGE_LEVELS': {'DEBUG': 10, 'INFO': 20, 'SUCCESS': 25, 'WARNING': 30, 'ERROR': 40}, 'settings': <LazySettings "netbox.settings">}, {}, {'content_type': <ContentType: tenant>, 'table': <tenancy.tables.TenantTable object at 0x7fbc56587fd0>, 'permissions': {'add': True, 'change': True, 'delete': True}, 'filter_form': <TenantFilterForm bound=True, valid=Unknown, fields=(q;group)>, 'tags': <QuerySet []>}, {'block': <Block Node: content. Contents: [<TextNode: '\n
'>, <IfNode>, <TextNode: '\n    '>, <django.template.library.InclusionNode object at 0x7fbc56695da0>, <TextNode: '\n
\n
'>, <Block Node: title. Contents: [<TextNode: 'Tenants'>]>, <TextNode: '
\n
\n\t'>, <django.template.loader_tags.IncludeNode object at 0x7fbc56699908>, <TextNode: '\n
\n
, <django.template.loader_tags.IncludeNode object at 0x7fbc56699978>, <TextNode: '\n\t\t'>, <django.template.loader_tags.IncludeNode object at 0x7fbc56699a20>, <TextNode: '\n
\n
\n'>]>}, {'bulk_edit_url': 'tenancy:tenant_bulk_edit', 'bulk_delete_url': 'tenancy:tenant_bulk_delete'}]
Exception while resolving variable 'table_template' in template 'tenancy/tenant_list.html'.
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 835, in _resolve_lookup
    current = current[bit]
  File "/usr/local/lib/python3.6/dist-packages/django/template/context.py", line 83, in __getitem__
    raise KeyError(key)
KeyError: 'table_template'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 841, in _resolve_lookup
    if isinstance(current, BaseContext) and getattr(type(current), bit):
AttributeError: type object 'RequestContext' has no attribute 'table_template'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 849, in _resolve_lookup
    current = current[int(bit)]
ValueError: invalid literal for int() with base 10: 'table_template'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 856, in _resolve_lookup
    (bit, current))  # missing attribute
django.template.base.VariableDoesNotExist: Failed lookup for key [table_template] in [{'True': True, 'False': False, 'None': None}, {'csrf_token': <SimpleLazyObject: 'fCXySqReBAyEvPpKABVpF6N4TqrSDuvcd3wS1CxMfvQSwoBkxFs72SC14s0gbn3K'>, 'request': <WSGIRequest: GET '/tenancy/tenants/'>, 'MEDIA_URL': '/media/', 'user': <SimpleLazyObject: <User: michael>>, 'perms': <django.contrib.auth.context_processors.PermWrapper object at 0x7fbc56585e48>, 'messages': <django.contrib.messages.storage.fallback.FallbackStorage object at 0x7fbc5677ada0>, 'DEFAULT_MESSAGE_LEVELS': {'DEBUG': 10, 'INFO': 20, 'SUCCESS': 25, 'WARNING': 30, 'ERROR': 40}, 'settings': <LazySettings "netbox.settings">}, {}, {'content_type': <ContentType: tenant>, 'table': <tenancy.tables.TenantTable object at 0x7fbc56587fd0>, 'permissions': {'add': True, 'change': True, 'delete': True}, 'filter_form': <TenantFilterForm bound=True, valid=Unknown, fields=(q;group)>, 'tags': <QuerySet []>}, {'block': <Block Node: content. Contents: [<TextNode: '\n
'>, <IfNode>, <TextNode: '\n    '>, <django.template.library.InclusionNode object at 0x7fbc56695da0>, <TextNode: '\n
\n
'>, <Block Node: title. Contents: [<TextNode: 'Tenants'>]>, <TextNode: '
\n
\n\t'>, <django.template.loader_tags.IncludeNode object at 0x7fbc56699908>, <TextNode: '\n
\n
, <django.template.loader_tags.IncludeNode object at 0x7fbc56699978>, <TextNode: '\n\t\t'>, <django.template.loader_tags.IncludeNode object at 0x7fbc56699a20>, <TextNode: '\n
\n
\n'>]>}, {'bulk_edit_url': 'tenancy:tenant_bulk_edit', 'bulk_delete_url': 'tenancy:tenant_bulk_delete'}]
Exception while resolving variable 'q' in template 'tenancy/tenant_list.html'.
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/utils/datastructures.py", line 77, in __getitem__
    list_ = super().__getitem__(key)
KeyError: 'q'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 835, in _resolve_lookup
    current = current[bit]
  File "/usr/local/lib/python3.6/dist-packages/django/utils/datastructures.py", line 79, in __getitem__
    raise MultiValueDictKeyError(key)
django.utils.datastructures.MultiValueDictKeyError: 'q'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 843, in _resolve_lookup
    current = getattr(current, bit)
AttributeError: 'QueryDict' object has no attribute 'q'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 849, in _resolve_lookup
    current = current[int(bit)]
ValueError: invalid literal for int() with base 10: 'q'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/django/template/base.py", line 856, in _resolve_lookup
    (bit, current))  # missing attribute
django.template.base.VariableDoesNotExist: Failed lookup for key [q] in <QueryDict: {}>

Closed due to lack of activity.

@unquietwiki Sorry I didn't get back to you on it. Since I offloaded the database activity out of the container, and had deleted that tenant record; the instance has been rather snappy. I've been rather busy at the office to offer further debugging on it. Thank you for your patience again.


Added samples to show real-world usage samples for Solidity's .sol extension

Description

Checklist:

[ ] I am associating a language with a new file extension.

[ ] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am adding a new language.

[ ] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a syntax highlighting grammar.
[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am fixing a misclassified language

[ ] I have included a new sample for the misclassified language:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am changing the source of a syntax highlighting grammar

Old: https://github-lightshow.herokuapp.com/
New: https://github-lightshow.herokuapp.com/

[ ] I am adding new or changing current functionality

[ ] I have added or updated the tests for the new or changed functionality.

As I said in https://github.com/github/linguist/pull/4146...
Unless you can provide an accurate heuristic and samples for all languages that use the .sol extension on GitHub, you’re going to hit the same reasons why we didn’t merge all previous attempts at adding the .sol extension https://github.com/github/linguist/pulls?q=is%3Apr+solidity+is%3Aclosed 😁

Marking as stale as this PR so far isn't adding anything more than all previous attempts. This PR will be closed in a week's time if no further progress is made.


Bump btcec to v2, use integrated btcutil module

Extracted out from https://github.com/lightningnetwork/lnd/pull/6263.
This PR switches lnd over to using the new btcec/v2 and btcutil modules located in the btcsuite/btcd repo.
All commits starting with SQUASHME will be squashed into a single commit before merging. They are only pushed separately for easier review.

Seeing this test failure uniformly:
--- FAIL: TestLightningWallet (114.32s)
    --- FAIL: TestLightningWallet/btcwallet/neutrino:publish_transaction (15.92s)
        test_interface.go:1914: expected ErrDoubleSpend, got: <nil>

I think it might be due to: https://github.com/lightninglabs/neutrino/pull/240 ?

I think you may need to go into each sub-module and to go mod tidy, so it can pick up other dependencies like the psbt package.

I think it might be due to: https://github.com/lightninglabs/neutrino/pull/240 ?

Yes, you were right. It looks like that PR didn't account for reject messages correctly. I created a fix for it in https://github.com/lightninglabs/neutrino/pull/247 and downgraded this PR to a version just before https://github.com/lightninglabs/neutrino/pull/240 was merged.

Related: https://github.com/lightningnetwork/lnd/pull/5651

@guggero, remember to re-request review from reviewers when ready

Needs a rebase! We'll eventually update to that neutrino version before we tag the next major release, so fine w/ going with the downgraded version here.

Rebased.

Rebased again. @positiveblue PTAL.

Modules pops up with this warning:

no required module provides package github.com/btcsuite/btcd/btcutil/gcs/builder; to add it:

I think it's missing a go mod tidy somewhere? But perhaps it's also just due to the set of intermediate commits.

Modules pops up with this warning:

no required module provides package github.com/btcsuite/btcd/btcutil/gcs/builder; to add it:

I think it's missing a go mod tidy somewhere? But perhaps it's also just due to the set of intermediate commits.

Yeah, the intermediate commits (prefixed with SQUASHME-) won't build on their own. My plan is to squash them into a single commit before merging.

Thank you for the review, @positiveblue!
Going to squash the commits prefixed with SQUASHME- into a single one.
Adding this comment here to preserve the split on GitHub:
Parts:

2d746f68: replace imports
4008f0fd: use ecdsa.Signature
849e33d1: remove btcec.S256()
b8f6ebbd: use v2 library correctly
fa80bca9: bump go modules


Full ascii

adds --full-ascii option to set the charmap to all visible ascii characters; also allows not capitalizing all letters, and automates the vocab size

Awesome, thank you! Happy to merge this.


[1643148900.259450][2811:2816] CHIP:DIS: Discovered node without a pending query
[1643148900.259484][2811:2816] CHIP:DIS: Node ID resolved for 0x0000000000654321
[1643148900.259522][2811:2816] CHIP:DIS:     Addr 0: [<IP_ADDRESS>]:5540
[1643148900.259545][2811:2816] CHIP:CTL: OperationalDiscoveryComplete for device ID 0x0000000000654321
[1643148900.259578][2811:2816] CHIP:CTL: Address resolved for node: 0x0000000000654321
[1643148900.263578][2811:2816] CHIP:EM: Received message of type 0x40 with protocolId (0, 0) and MessageCounter:824388791 on exchange 39456i
[1643148900.263618][2811:2816] CHIP:EM: Found matching exchange: 39456i, Delegate: 0xffff8c0a0340
[1643148900.263666][2811:2816] CHIP:EM: Rxd Ack; Removing MessageCounter:1862767198 from Retrans Table on exchange 39456i
[1643148900.263691][2811:2816] CHIP:EM: Removed CHIP MessageCounter:1862767198 from RetransTable on exchange 39456i
[1643148900.263732][2811:2816] CHIP:SC: Success status report received. Session was established
[1643148900.263761][2811:2816] CHIP:IN: New secure session created for device 0x0000000000654321, LSID:2 PSID:2!
[1643148900.263872][2811:2816] CHIP:CTL: Calling commissioning complete
[1643148900.263926][2811:2816] CHIP:DMG: ICR moving to [AddingComm]
[1643148900.263951][2811:2816] CHIP:DMG: ICR moving to [AddedComma]
[1643148900.264029][2811:2816] CHIP:IN: Prepared secure message 0xaaaacbab3998 to 0x0000000000654321 (1)  of type 0x8 and protocolId (0, 1) on exchange 39457i with MessageCounter:11547771.
[1643148900.264066][2811:2816] CHIP:IN: Sending encrypted msg 0xaaaacbab3998 with MessageCounter:11547771 to 0x0000000000654321 (1) at monotonic time: 136213 msec
[1643148900.264189][2811:2816] CHIP:DMG: ICR moving to [CommandSen]
[1643148900.264238][2811:2816] CHIP:EM: Sending Standalone Ack for MessageCounter:824388791 on exchange 39456i
[1643148900.264269][2811:2816] CHIP:IN: Prepared unauthenticated message 0xffff86fdd9e8 to 0x0000000000000000 (0)  of type 0x10 and protocolId (0, 0) on exchange 39456i with MessageCounter:1862767199.
[1643148900.264300][2811:2816] CHIP:IN: Sending unauthenticated msg 0xffff86fdd9e8 with MessageCounter:1862767199 to 0x0000000000000000 at monotonic time: 136213 msec
[1643148900.264420][2811:2816] CHIP:EM: Flushed pending ack for MessageCounter:824388791 on exchange 39456i
[1643148900.265576][2811:2816] CHIP:DIS: Discovered node without a pending query
[1643148900.265610][2811:2816] CHIP:DIS: Node ID resolved for 0x0000000000654321
[1643148900.265636][2811:2816] CHIP:DIS:     Addr 0: [fd00:6d61:7474:6572::1]:5540
[1643148900.265658][2811:2816] CHIP:DIS:     Addr 1: [fe80::1]:5540
[1643148900.265680][2811:2816] CHIP:DIS:     Addr 2: [<IP_ADDRESS>]:5540
[1643148900.265701][2811:2816] CHIP:CTL: OperationalDiscoveryComplete for device ID 0x0000000000654321
[1643148900.265735][2811:2816] CHIP:TOO: Pairing Success
[1643148900.265758][2811:2816] CHIP:CTL: Address resolved for node: 0x0000000000654321
[1643148900.267278][2811:2816] CHIP:DIS: Discovered node without a pending query
[1643148900.267311][2811:2816] CHIP:DIS: Node ID resolved for 0x0000000000654321
[1643148900.267335][2811:2816] CHIP:DIS:     Addr 0: [fd00:6d61:7474:6572::1]:5540
[1643148900.267357][2811:2816] CHIP:DIS:     Addr 1: [fe80::1]:5540
[1643148900.267378][2811:2816] CHIP:DIS:     Addr 2: [<IP_ADDRESS>]:5540
[1643148900.267400][2811:2816] CHIP:CTL: OperationalDiscoveryComplete for device ID 0x0000000000654321
[1643148900.267431][2811:2816] CHIP:TOO: Pairing Success
[1643148900.267453][2811:2816] CHIP:CTL: Address resolved for node: 0x0000000000654321
[1643148900.268835][2811:2816] CHIP:DIS: Discovered node without a pending query
[1643148900.268865][2811:2816] CHIP:DIS: Node ID resolved for 0x0000000000654321
[1643148900.268890][2811:2816] CHIP:DIS:     Addr 0: [fd00:6d61:7474:6572::1]:5540
[1643148900.268911][2811:2816] CHIP:DIS:     Addr 1: [fe80::1]:5540
[1643148900.268933][2811:2816] CHIP:DIS:     Addr 2: [<IP_ADDRESS>]:5540
[1643148900.268953][2811:2816] CHIP:CTL: OperationalDiscoveryComplete for device ID 0x0000000000654321
[1643148900.268983][2811:2816] CHIP:TOO: Pairing Success
[1643148900.269005][2811:2816] CHIP:CTL: Address resolved for node: 0x0000000000654321
[1643148900.270520][2811:2816] CHIP:DIS: Discovered node without a pending query
[1643148900.270544][2811:2816] CHIP:DIS: Node ID resolved for 0x0000000000654321
[1643148900.270578][2811:2816] CHIP:DIS:     Addr 0: [fd00:6d61:7474:6572::1]:5540
[1643148900.270601][2811:2816] CHIP:DIS:     Addr 1: [fe80::1]:5540
[1643148900.270622][2811:2816] CHIP:DIS:     Addr 2: [<IP_ADDRESS>]:5540
[1643148900.270673][2811:2816] CHIP:CTL: OperationalDiscoveryComplete for device ID 0x0000000000654321
[1643148900.270707][2811:2816] CHIP:TOO: Pairing Success
[1643148900.270727][2811:2816] CHIP:CTL: Address resolved for node: 0x0000000000654321
[1643148900.271847][2811:2816] CHIP:EM: Received message of type 0x9 with protocolId (0, 1) and MessageCounter:6586819 on exchange 39457i
[1643148900.271886][2811:2816] CHIP:EM: Found matching exchange: 39457i, Delegate: 0xffff74004eb0
[1643148900.271931][2811:2816] CHIP:EM: Rxd Ack; Removing MessageCounter:11547771 from Retrans Table on exchange 39457i
[1643148900.271955][2811:2816] CHIP:EM: Removed CHIP MessageCounter:11547771 from RetransTable on exchange 39457i
[1643148900.271990][2811:2816] CHIP:DMG: ICR moving to [ResponseRe]
[1643148900.272038][2811:2816] CHIP:DMG: InvokeResponseMessage =
[1643148900.272063][2811:2816] CHIP:DMG: {
[1643148900.272087][2811:2816] CHIP:DMG: 	suppressResponse = false,
[1643148900.272115][2811:2816] CHIP:DMG: 	InvokeResponseIBs =
[1643148900.272146][2811:2816] CHIP:DMG: 	[
[1643148900.272171][2811:2816] CHIP:DMG: 		InvokeResponseIB =
[1643148900.272204][2811:2816] CHIP:DMG: 		{
[1643148900.272233][2811:2816] CHIP:DMG: 			CommandDataIB =
[1643148900.272266][2811:2816] CHIP:DMG: 			{
[1643148900.272361][2811:2816] CHIP:DMG: 				CommandPathIB =
[1643148900.272396][2811:2816] CHIP:DMG: 				{
[1643148900.272430][2811:2816] CHIP:DMG: 					EndpointId = 0x0,
[1643148900.272465][2811:2816] CHIP:DMG: 					ClusterId = 0x30,
[1643148900.272499][2811:2816] CHIP:DMG: 					CommandId = 0x5,
[1643148900.272532][2811:2816] CHIP:DMG: 				},
[1643148900.272568][2811:2816] CHIP:DMG:
[1643148900.272595][2811:2816] CHIP:DMG: 				CommandData =
[1643148900.272627][2811:2816] CHIP:DMG: 				{
[1643148900.272661][2811:2816] CHIP:DMG: 					0x0 = 0,
[1643148900.272697][2811:2816] CHIP:DMG: 					0x1 = "",
[1643148900.272729][2811:2816] CHIP:DMG: 				},
[1643148900.272759][2811:2816] CHIP:DMG: 			},
[1643148900.272791][2811:2816] CHIP:DMG:
[1643148900.272818][2811:2816] CHIP:DMG: 		},
[1643148900.272850][2811:2816] CHIP:DMG:
[1643148900.272873][2811:2816] CHIP:DMG: 	],
[1643148900.272903][2811:2816] CHIP:DMG:
[1643148900.272925][2811:2816] CHIP:DMG: },
[1643148900.272990][2811:2816] CHIP:DMG: Received Command Response Data, Endpoint=0 Cluster=0x0000_0030 Command=0x0000_0005
[1643148900.273025][2811:2816] CHIP:ZCL: CommissioningCompleteResponse:
[1643148900.273047][2811:2816] CHIP:ZCL:   errorCode: 0
[1643148900.273066][2811:2816] CHIP:ZCL:   debugText:
[1643148900.273091][2811:2816] CHIP:CTL: Received success response 0x0

[1643148900.273125][2811:2816] CHIP:CTL: Rendezvous cleanup
[1643148900.273146][2811:2816] CHIP:TOO: Device commissioning completed with success
[1643148900.273213][2811:2816] CHIP:DMG: ICR moving to [AwaitingDe]
[1643148900.273246][2811:2816] CHIP:EM: Sending Standalone Ack for MessageCounter:6586819 on exchange 39457i
[1643148900.273312][2811:2816] CHIP:IN: Prepared secure message 0xffff86fdd9e8 to 0x0000000000654321 (1)  of type 0x10 and protocolId (0, 0) on exchange 39457i with MessageCounter:11547772.
[1643148900.273353][2811:2816] CHIP:IN: Sending encrypted msg 0xffff86fdd9e8 with MessageCounter:11547772 to 0x0000000000654321 (1) at monotonic time: 136222 msec
[1643148900.273483][2811:2816] CHIP:EM: Flushed pending ack for MessageCounter:6586819 on exchange 39457i
[1643148900.273671][2811:2811] CHIP:CTL: Shutting down the commissioner
[1643148900.273784][2811:2811] CHIP:CTL: Shutting down the controller
[1643148900.273831][2811:2811] CHIP:CTL: Shutting down the commissioner
[1643148900.273904][2811:2811] CHIP:CTL: Shutting down the controller
[1643148900.273939][2811:2811] CHIP:CTL: Shutting down the commissioner
[1643148900.274029][2811:2811] CHIP:CTL: Shutting down the controller
[1643148900.274057][2811:2811] CHIP:CTL: Shutting down the System State, this will teardown the CHIP Stack
[1643148900.276358][2811:2811] CHIP:BLE: BleConnectionDelegate::CancelConnection is not implemented.
[1643148900.276655][2811:2811] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-yGPEzN)
[1643148900.277310][2811:2811] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1643148900.277372][2811:2811] CHIP:DL: NVS set: chip-counters/total-operational-hours = 0 (0x0)
[1643148900.277470][2811:2811] CHIP:DL: Inet Layer shutdown
[1643148900.277494][2811:2811] CHIP:DL: BLE shutdown
[1643148900.277540][2811:2811] CHIP:DL: System Layer shutdown

Debugging Attempts:
Thread 1 "chip-app1" received signal SIGSEGV, Segmentation fault.
0x0000aaaaaab6b038 in chip::DeviceLayer::Internal::GenericPlatformManagerImpl<chip::DeviceLayer::PlatformManagerImpl>::DispatchEventToApplication (this=0xaaaaaac48c28 <chip::DeviceLayer::PlatformManagerImpl::sInstance+16>, event=0xfffffffff108) at ../../examples/placeholder/linux/third_party/connectedhomeip/src/include/platform/internal/GenericPlatformManagerImpl.cpp:276
276	        eventHandler->Handler(event, eventHandler->Arg);
(gdb) p *eventHandler
Cannot access memory at address 0xaaa00061b662
(gdb) p *event
$1 = {Type = 32784, {Platform = {{BLECentralConnected = {mConnection = 0xffff00000000}, BLECentralConnectFailed = {mError = {static kRangeStart = 24, static kRangeLength = 8, static kValueStart = 0,
            static kValueLength = 24, static kSdkPartStart = 8, static kSdkPartLength = 3, static kSdkCodeStart = 0, static kSdkCodeLength = 8, mError = 0,
            mFile = 0xaaaaaac09ab0 "../../examples/placeholder/linux/third_party/connectedhomeip/src/platform/DeviceControlServer.cpp", mLine = 72}}, BLEWriteComplete = {mConnection = 0xffff00000000},
        BLESubscribeOpComplete = {mConnection = 0xffff00000000, mIsSubscribed = 176}, BLEIndicationReceived = {mConnection = 0xffff00000000, mData = 0xaaaaaac09ab0}, BLEPeripheralRegisterAppComplete = {
          mIsSuccess = false, mpAppstate = 0xaaaaaac09ab0}, BLEPeripheralAdvConfiguredComplete = {mIsSuccess = false, mpAppstate = 0xaaaaaac09ab0}, BLEPeripheralAdvStartComplete = {mIsSuccess = false,
          mpAppstate = 0xaaaaaac09ab0}, BLEPeripheralAdvStopComplete = {mIsSuccess = false, mpAppstate = 0xaaaaaac09ab0}}}, LambdaEvent = {mLambdaProxy = 0xffff00000000, mLambdaBody = {
        __data = "\260\232\300\252\252\252\000\000H\000\000\000\377\377\000", __align = {<No data fields>}}}, CallWorkFunct = {WorkFunct = 0xffff00000000, Arg =<PHONE_NUMBER>11472}, WiFiConnectivityChange = {
      Result = chip::DeviceLayer::kConnectivity_NoChange}, ThreadConnectivityChange = {Result = chip::DeviceLayer::kConnectivity_NoChange}, InternetConnectivityChange = {
      IPv4 = chip::DeviceLayer::kConnectivity_NoChange, IPv6 = 65535,
      address = "\260\232\300\252\252\252\000\000H\000\000\000\377\377\000\000\210\230Ī\252\252\000\000@\340\377\377\377\377\000\000dܭ\252\252\252\000\000i\266\001\000\000"}, ServiceConnectivityChange = {Overall = {
        Result = chip::DeviceLayer::kConnectivity_NoChange}, ViaThread = {Result = 65535}}, ServiceSubscriptionStateChange = {Result = chip::DeviceLayer::kConnectivity_NoChange}, FabricMembershipChange = {
      IsMemberOfFabric = false}, ServiceProvisioningChange = {IsServiceProvisioned = false, ServiceConfigUpdated = false}, AccountPairingChange = {IsPairedToAccount = false}, TimeSyncChange = {
      IsTimeSynchronized = false}, SessionEstablished = {PeerNodeId =<PHONE_NUMBER>43360, SessionKeyId = 39600, SessionType = 192 '\300', IsCommissioner = 170}, CHIPoBLESubscribe = {ConId = 0xffff00000000},
    CHIPoBLEUnsubscribe = {ConId = 0xffff00000000}, CHIPoBLEWriteReceived = {ConId = 0xffff00000000, Data = 0xaaaaaac09ab0}, CHIPoBLEIndicateConfirm = {ConId = 0xffff00000000}, CHIPoBLEConnectionError = {
      ConId = 0xffff00000000, Reason = {static kRangeStart = 24, static kRangeLength = 8, static kValueStart = 0, static kValueLength = 24, static kSdkPartStart = 8, static kSdkPartLength = 3,
        static kSdkCodeStart = 0, static kSdkCodeLength = 8, mError =<PHONE_NUMBER>, mFile = 0xffff00000048 <error: Cannot access memory at address 0xffff00000048>, mLine =<PHONE_NUMBER>}}, CHIPoBLENotifyConfirm = {
      ConId = 0xffff00000000}, ThreadStateChange = {RoleChanged = false, AddressChanged = false, NetDataChanged = false, ChildNodesChanged = false, OpenThread = {Flags = 65535}}, CHIPoBLEAdvertisingChange = {
      Result = chip::DeviceLayer::kActivity_NoChange}, InterfaceIpAddressChanged = {Type = chip::DeviceLayer::InterfaceIpChangeType::kIpV4_Assigned}, CommissioningComplete = {status = {static kRangeStart = 24,
        static kRangeLength = 8, static kValueStart = 0, static kValueLength = 24, static kSdkPartStart = 8, static kSdkPartLength = 3, static kSdkCodeStart = 0, static kSdkCodeLength = 8, mError = 0,
        mFile = 0xaaaaaac09ab0 "../../examples/placeholder/linux/third_party/connectedhomeip/src/platform/DeviceControlServer.cpp", mLine = 72}}, OperationalNetwork = {network = 0}}}
(gdb) bt
#0  0x0000aaaaaab6b038 in chip::DeviceLayer::Internal::GenericPlatformManagerImpl<chip::DeviceLayer::PlatformManagerImpl>::DispatchEventToApplication(chip::DeviceLayer::ChipDeviceEvent const*)
    (this=0xaaaaaac48c28 <chip::DeviceLayer::PlatformManagerImpl::sInstance+16>, event=0xfffffffff108)
    at ../../examples/placeholder/linux/third_party/connectedhomeip/src/include/platform/internal/GenericPlatformManagerImpl.cpp:276
#1  0x0000aaaaaab6af40 in chip::DeviceLayer::Internal::GenericPlatformManagerImpl<chip::DeviceLayer::PlatformManagerImpl>::_DispatchEvent(chip::DeviceLayer::ChipDeviceEvent const*)
    (this=0xaaaaaac48c28 <chip::DeviceLayer::PlatformManagerImpl::sInstance+16>, event=0xfffffffff108)
    at ../../examples/placeholder/linux/third_party/connectedhomeip/src/include/platform/internal/GenericPlatformManagerImpl.cpp:241
#2  0x0000aaaaaab4292c in chip::DeviceLayer::PlatformManager::DispatchEvent(chip::DeviceLayer::ChipDeviceEvent const*) (this=0xaaaaaac48c18 <chip::DeviceLayer::PlatformManagerImpl::sInstance>, event=0xfffffffff108)
    at ../../examples/placeholder/linux/third_party/connectedhomeip/src/include/platform/PlatformManager.h:425
#3  0x0000aaaaaab6b7b8 in chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::ProcessDeviceEvents()
    (this=0xaaaaaac48c28 <chip::DeviceLayer::PlatformManagerImpl::sInstance+16>) at ../../examples/placeholder/linux/third_party/connectedhomeip/src/include/platform/internal/GenericPlatformManagerImpl_POSIX.cpp:146
#4  0x0000aaaaaab6b440 in chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop()
    (this=0xaaaaaac48c28 <chip::DeviceLayer::PlatformManagerImpl::sInstance+16>) at ../../examples/placeholder/linux/third_party/connectedhomeip/src/include/platform/internal/GenericPlatformManagerImpl_POSIX.cpp:183
#5  0x0000aaaaaaaf3ee8 in chip::DeviceLayer::PlatformManager::RunEventLoop() (this=0xaaaaaac48c18 <chip::DeviceLayer::PlatformManagerImpl::sInstance>)
    at ../../examples/placeholder/linux/third_party/connectedhomeip/src/include/platform/PlatformManager.h:348
#6  0x0000aaaaaaaf43e4 in ChipLinuxAppMainLoop() () at ../../examples/placeholder/linux/third_party/connectedhomeip/examples/platform/linux/AppMain.cpp:434
#7  0x0000aaaaaaac31b0 in main(int, char**) (argc=5, argv=0xfffffffff388) at ../../examples/placeholder/linux/main.cpp:34
(gdb)

The following diff fixes the issue for now:
diff --git a/examples/placeholder/linux/include/TestCommand.h b/examples/placeholder/linux/include/TestCommand.h
index 40e111fc3cd..232e9005e8f 100644
--- a/examples/placeholder/linux/include/TestCommand.h
+++ b/examples/placeholder/linux/include/TestCommand.h
@@ -82,7 +82,6 @@ public:
             TestCommand * command = reinterpret_cast<TestCommand *>(arg);
             command->isRunning    = true;
             command->NextTest();
-            chip::DeviceLayer::PlatformMgr().RemoveEventHandler(OnPlatformEvent, arg);
             break;
         }
     }

@vivien-apple

As discussed, ScheduleWork should do the job.

Isn't this fixed now? Please re-open if not!


There is no formatter for 'json' files installed.

When trying to reformat a JSON file using F1 > Format, I get a confusing dialog that reports that no formatter for json is installed. When pressing to install one I get redirected to marketplace listing of JSON extensions, where there are thousands of them and after trying 3 of them that did not sort the issue I decided to file a bug.
I think that vscode is expected to be able to format JSON without additional extensions and I am also aware of one or two similar bugs which were marked as fixed about 2 years ago.
That must be something new, especially as I used extension bisect feature to test if another extension is affecting it and the result was negative, reproduced without extensions.
Version: 1.63.2
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:37:28.172Z (3 wks ago)
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 21.2.0

What is your json.format.enable setting?
In the Extensions view does the search for @builtin json language features show the built-in extension? Is it enabled?

One interesting thing that i observed, the "JSON Language Features" appears as disabled but I really doubt I ever disable a build-it. The basics one is enable.

json.format.enable is not present in config.
Another interesting thing is that I observed that while "Format" does not work, the "Format (forced)" seems to work.

After enabling "JSON Language Features" behaviour changed and now I see a different dialog when using Format:

The funny bit is that the "Configure" option is useless as it does not allow me to configure/select a particular formatter. In fact I have no clue which are those formatters and the message does not mention them. I can guess that one of them is provided by "JSON Language Features"  built-in but who is the other one? I think it would be very useful to make this dialog more explicit as it can easily become a needle-in the haystack search experience.

The interesting question is, how the JSON language extension got disabled.
Can you file a separate issue on improving the formatter selection dialog?
This is how the formatter selection dialog looks for me:

For historical reasons. actual formatters don't have a name so we show the name of the extension that contributes it.
FYI @jrieken Maybe you already have an issue to improve the labels, e.g. allow formatters to provide a name as well.

I think I may have found the culprit, the dialog looks the same for me.
At least in one case I ended up with 100% CPU usage when I used Format, but I was not able to reproduce it. I can assume it was from Prettier extension but I am not 100% sure.
I guess that once you pick a formatter an entry similar to the one below is added to user settings.json (or json instead of jsonc based on file):
    "[jsonc]": {
        "editor.defaultFormatter": "esbenp.prettier-vscode"
    },

I close the issue then. Please reopen or add a comment if you see it again or have more infos.


Why it's unlimited?

I estimate we will invoke 100K times and totally 34 million characters per month, does this support?

Your server will probably get blocked by Google

I have the same question. As I know, we will be charged for the Translate API.

I estimate we will invoke 100K times and totally 34 million characters per month, does this support?

Sounds like this is going to abuse the service. Better off paying for the real API service.


The card not updating

Support guidelines

[x] I've read the support guidelines

Description
My card with the days left:  wednesday, the day after tomorrow (2 days) is not updating, i use fully kiosk single app. It works when i close kiosk and open the normal HA app. What can i do about this?
Expected behaviour
Updating the days left when time 0:00.
Actual behaviour
Not updating
Version

HASS version: latest
Component version: latest
Useful system info:

HASS logs

logger -> logs -> custom_components.afvalwijzer: debug in you configuration.yaml

Hi, is this still an issue? I wasn't able to look into it :)

Well, sometimes it takes a little time to update but im ok with it.


Code cleanup

This PR contains code refactoring.

Oh my... my bad I completely forgot to update the code inside the system...


Unsupported --no-sandbox flag

On browser window there is this message:
You are using an unsupported command-line flag: --no-sandbox. Stabillity and security will suffer.

Info
OS: Windows
Chrome: 125

ignoreAllFlags: true https://github.com/GoogleChrome/chrome-launcher?tab=readme-ov-file#api You can turn it off by adding the defaultFlags here again. However, I cannot turn it off to avoid problems when running with Docker. You can follow the steps I forwarded to turn it off.

The --no-sandbox flag should be used only with headless mode: https://github.com/GoogleChrome/chrome-launcher/blob/main/docs/chrome-flags-for-tools.md#headless
Change:
chromeFlags: [
-  "--no-sandbox"
+  ...headless==='new' ? ['--no-sandbox'] : []
]


make containers cleanup

would love to take this up :)

@snapdgn FYI this issue is not part of Hacktoberfest because it's requirements are not clearly defined. I'm sure these scripts could use some love, though. If you find something that requires complexity and adds value to the repository we can re-purpose this ticket as part Hacktoberfest.
Are you still interested?

Thank you for the details. would nevertheless like to contribute:). Is it okay if I spend some time poking around other issues? If this one isn't a top priority, I'll return to it later.

Absolutely! Thank you @snapdgn , you're assigned!

Closed by #360


Burger Menu Button

I want to have a Button on All Screens to open the Drawer.
I am using "react-native-drawer": "^1.16.7", "react-native-router-flux": "^2.3.7"
I used the hints given on this project home page and also tried to search the issues, still I am unclear how can I create a button for this.

You can put a button anywhere you like and simply have onPress call this._drawer.open()
The only thing is you need to get a reference to the drawer. You can either use refs or context for this as described here https://github.com/root-two/react-native-drawer#opening--closing-the-drawer-programmatically

If you're using NavigatorIOS there is a property called leftButtonIcon where you can add your icon
leftButtonIcon: require('image!hamburgerIcon') and then onLeftButtonPress: () => this._drawer.open()
If you're using Navigator is almost the same, so for example using the AndroidToolbar would be:
<ToolbarAndroid
                    actions={[]}
                    onIconClicked={() => this._drawer.open()}
                    title="MyComponent" />

@caroaguilar thanks for more details. @babbarankit you should also consider upgrading to the latest drawer (v2).
Closing for now, feel free to reopen if still and issue.


dot function not defining correct grid for result

Reported by karl smith on 9 Nov 2017 02:11 UTC
The last "show grid dp" is incorrect and the last "can axis taxis" crashes.
!!!! using dot_t(v1,v2) works fine
def axis /X=1.0:3.0:1.0 xaxis
def axis /T=0.0:59.75:0.25 taxis
def grid /X=xaxis /T=taxis xtgrid
set grid xtgrid

let v1 = X * sin(T)
let v2 = X * cos(T)

let dp = dot_t(v1,v2)
show grid dp
list dp

can var /all
set grid abstract
can grid xtgrid
can axis xaxis
can axis taxis

!!!! using dot(v1,v2,4) gives the correct results
!!!! but the expected grid is incorrect and "can axis taxis" crashes

def axis /X=1.0:3.0:1.0 xaxis
def axis /T=0.0:59.75:0.25 taxis
def grid /X=xaxis /T=taxis xtgrid
set grid xtgrid

let v1 = X * sin(T)
let v2 = X * cos(T)

let dp = dot(v1,v2,4)
show grid dp
list dp

can var /all
set grid abstract
can grid xtgrid
can axis xaxis
can axis taxis

Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2569

Comment by ansley.b.manke on 13 Nov 2017 23:08 UTC
The error canceling the the axis is fixed, in gcf_set_normal_axis.F.
Before the result is loaded, we probably can't get the grid with its compressed axis for a direction-changing function, as it depends on data values.  To see this better, say the direction to be used is some value to be read in from a file.
let v1 = X * sin(T)
let v2 = X * cos(T)
let dir = val[d=2]

let dp = dot(v1,v2,dir)
show grid dp

The "show grid"computation reconciles the grids of the variables that go into the expression, and the grids of v1, v2, and dir are known at this time, but not their values.
It should be possible to show the right grid AFTER the "list dp" has loaded the data; but at this time it still shows the grid without the compression. Leaving the ticket open, changing its Summary.


[4.x] SE tracing doc shows obsolete technique for creating a server

Environment Details

Helidon Version: 3.x
Helidon SE or Helidon MP SE
JDK version:
OS:
Docker version (if applicable):

Problem Description
This doc section https://helidon.io/docs/latest/index.html#/se/tracing#_usage illustrates using ServerConfiguration.builder() which is now deprecated in favor of WebServer.builder().
There might be other similar places elsewhere in the doc. I have not looked.
I am marking this for 4.x but the same problem exists in earlier releases.

@romain-grecourt Close this issue, please.


fix(@angular-devkit/build-angular): pass webpack factor to runWebpack

Patch version of https://github.com/angular/angular-cli/pull/16317

@mgechev  build-bazel is unrelated as the 9.0.x branch is currently red.


Add jQuery.floatThead as an optional addition

It would be nice to add jQuery.floatThead as an optional addition, in the same way as we provide the date picker.
We will obviously need to provide the css that makes it work for bootstrap.

As a possible alternative, data framework Recline.js uses SlickGrid, for which the most active branch seems to be https://github.com/6pac/SlickGrid


api: fix typo in list rules API response

Fix typo in the list rules API response
obs.: I notice that we don't have end to end unit tests for the API, is this correct?

Previously the field was named "groupNextToken:omitempty".
This should be announced as a breaking change, right?
(although not many people are using this particular API)


[Bug]: hello, why?

What happened?

How to reproduce the bug
composer require kambo/langchain
Package Version
2.0.0
PHP Version
7.4.33
Which operating systems does with happen with?
No response
Notes
No response

This is because there isn’t a stable release. You’d need to require the unstable version.
composer require kambo/langchain:dev-main


[11.x] Add ability to register both a single macro as well as multiple

Making the latter something halfway between the original macro functionality and mixins. The original functionality was kept as-is, so it's no breaking change and the method can be used the same as before.

I know. Yes and no. It is similar, but it's more about the syntax: Mixins are usually objects, but sometimes, one doesn't want to create an entire object for that. So this is something in between. It doesn't hurt anyone, but lets the developer decide how to solve this.

Are there any other places in the codebase which uses variadic named arguments instead of an array?
I would keep it consistent if the codebase and allow an associative array instead.

This wasn't possible in earlier PHP versions, so it's only logical that it is first implemented now. So, this isn't necessarily a good measurement.
The question should be if this is something, we'd like to see more in the future.

Sure, but IMO it is better to keep consistency, so one doesn't have to switch mindset when using different framework features.
I am all in on adopting new language features, but I'd prefer to migrate to them over time and consistently across the framework.
Passing an array or defaulting to a key value pair is very idiomatic in many parts of the framework (Builder@where(), Session@set(), to name a few). And having just one place with a different syntax, doesn't look good to me.

Technically, both could be supported 🤔

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Everything else would have been a surprise …

@rodrigopedra I mean, the docs already kinda recommend this pattern (using named properties at least) when using accessors:
<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Casts\Attribute;
use Illuminate\Database\Eloquent\Model;

class User extends Model
{
    /**
     * Get the user's first name.
     */
    protected function firstName(): Attribute
    {
        return Attribute::make(
            get: fn (string $value) => ucfirst($value),
        );
    }
}

@shaedrich it is not the same case.
The Attribute::make() method has parameters named $get and $set. It does not use a variadic parameter, and does not expect an associative array.
I guess if you tried the array approach, then the PR could have better chances to get merged.

@shaedrich it is not the same case.
The Attribute::make() method has parameters named $get and $set. It does not use a variadic parameter, and does not expect an associative array.

@rodrigopedra I know. That's why I emphasized their similarity being the usage of named properties.

I guess if you tried the array approach, then the PR could have better chances to get merged.

What improves changes is like gazing into a crystal ball with Taylor as he tends to copy-paste generic replies (if at all) that often times don't even fit into PRs before closing them, without giving any indication what he couldn't live with. So it's always a guessing game only god knows the answer to. Couldn't be more frustrating.

I understand your feeling, but also understand Taylor's position.
The framework grew too large, in the sense of adoption, and the responsibility to keep everything healthy and maintainable lies primarily on him.
These kinds of PRs, which address syntax improvements, are trickier to evaluate their benefits. And once they are shipped, they should be maintained at least until the next major version.
So there is a tradeoff on perceived benefit versus maintainability.
For PR's like this one, I'd suggest adding a more detailed explanation on how it could benefit a wider range of developers, and if possible share some use cases on real projects.
If it is purely DX, which I am totally for it, my experience around here shows that targeting the next major version gives it more chances. But also the perceived benefit should be clear.
I had very few direct interactions with Taylor, but I can tell you he is a great guy, wants the best for Laravel developers, and is open to criticism.
Reviewing all the PRs from the framework, and its first-party packages, plus weighting in the pros and cons of each PR is a big burden. Consider that, moreover, he works on his commercial offerings, to provide for his family, and keep Laravel fresh and relevant.
Another path is to try to help with PRs that fix reported bugs. That helps to build trust. And always give clear descriptions on how the PR solves or improves things.

I understand your feeling, but also understand Taylor's position.

Copy-pasting the wrong reply template or not replying at all when closing a PR is not a position, it is outright rude as this is not the exception but the rule 🤷🏻♂
This PR does not introduce a breaking change. As I said: The current functionality is maintained as is. This isn't even a huge change.

If it is purely DX, which I am totally for it, my experience around here shows that targeting the next major version gives it more chances.

Again, this is just guessing since Taylor is unable to communicate this clearly.

I had very few direct interactions with Taylor, but I can tell you he is a great guy, wants the best for Laravel developers, and is open to criticism.
Reviewing all the PRs from the framework, and its first-party packages, plus weighting in the pros and cons of each PR is a big burden. Consider that, moreover, he works on his commercial offerings, to provide for his family, and keep Laravel fresh and relevant.

He might be a great guy outside of PRs, but as a maintainer of a huge framework with a huge community, this is not good behavior. If all the PRs are to much for him, he has to review fewer. But closing them, potentially without even really looking at them because one is overwhelmed, doesn't really help the framework.

Another path is to try to help with PRs that fix reported bugs.

I don't think, contributors should be in a supplicant position. Some are better at fixing bugs, some at other things.

I don't think, contributors should be in a supplicant position. Some are better at fixing bugs, some at other things.

I don't think, either, and most probably I couldn't get the right words for my thoughts.
But the most important thing, which I highlighted several times, is to provide clear benefits, and, if possible, real-world use cases.
The "help to build trust" was, as I said, an alternative path. And much based on my own opinions, and life experience. I find it is more likely for someone to assess requests from people they already know their work quality, than from someone they don't. And I am not referring just to Laravel.
Maybe it is a cultural thing, and not necessarily the best way, but again, that would be another path.
The main thing, again, is to provide a very descriptive argument of the benefits on why they should agree to maintain a newer addition. Real-world use cases help a lot with this.
The very reason is that other people might fail to understand upfront the same benefits from who is proposing the PR. And as you said you aren't, I firmly believe no one else around here is a mind-reader.


gtw: handle shared ctx

context is between among all subgrpah calls

Stack:

#72
#71
#70
#69 ⬅
#68
#67
#66
#65
#64
#63

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

✓ Commit merged in pull request #72


Revert "Fix selecting popup menu items on mouse release"

This reverts commit 06c2cda848b4bca8ee2f54a09417a97a7c1384d3.
fixes #88324
It's not clear why this was done this way, but reverting this commit is actually fixing the linked issue.
Not sure what was supposed to be broken in the first place.

Bugsquad edit, reverts: #86952

Outright reverting the PR is not a proper fix, especially when it was merged so recently.

I understand, It's more like a starting point. But this change actually broke every Godot's popup. And since there is no issue linked to the original PR, it's difficult to understand what was the purpose of the changes.
Perhaps @ryevdokimov you can help me understand what was the goal of the PR ?

The PR was to fix/introduce a very common functionality of being to select popup menu options with one cycle of a mouse click. I am having trouble reproducing this issue, so I suspect it might be OS specific (I'm on Windows).

I understand, It's more like a starting point.

A starting point is opening an issue, which you already did. The problem should be discussed in the issue.

The PR was to fix/introduce a very common functionality of being to select popup menu options with one cycle of a mouse click.

The functionality has existed in Godot 3 and was lost sometime during DisplayServer refactor. The code was still there, it just wasn't functional. So it was more a bugfix.

After some tests, I still don't understand what the change was supposed to fix.
It introduces 3 bugs:

If the popup opens under the mouse (which is arguably a bad UI pattern but it exists in multiple places in Godot), moving the mouse after a 250ms delay will activate the menu item hovered by the mouse
If the menu opens with a click (right or left) and the mouse button is not released before the mouse goes over the menu, the menu item hovered by the mouse after the button release will be activated on next mouse movement.
The menu items are now activated on button down instead of button up, which means:

You can't click on an item and drag your mouse over another if you changed your mind
You can't cancel a click on a menu item by dragging outside of the menu popup

The 2 last items are very confusing since it's not how every native menus are working. It breaks users assumption about how to interact with the UI.

This should probably be discussed under the issue you created, so we don't have to jump back and forth.


Schema Validation

https://www.mongodb.com/docs/manual/core/schema-validation/specify-json-schema/#std-label-schema-validation-json
See https://github.com/uoftblueprint/tces/wiki/Schema and also update the wiki with types

https://www.mongodb.com/docs/manual/core/schema-validation/specify-json-schema/json-schema-tips/#std-label-json-schema-tips

split into other tickets


Allow environnement variables to be resolved to lists

It would be nice to allow environnement variables to be resolved to lists, since in the moment the specification of HOCON explicitly says: "environment variables always become a string value".
A common use case for this is when using Akka Cluster with Docker containers, it would be nice to have the ability to externalize the value of akka.cluster.roles to environnement variables that can be passed when running a docker container, and to do something like that:
akka.cluster.roles = [default-role]
akka.cluster.roles = ${?AKKA_ROLE}

with AKKA_ROLE an environnement variable that can have the following value: "role1","role2","role3" (comma separated list)
At the moment the workaround that is recommended is to add as jvm properties -Dakka.cluster.roles.0=...

For discussion see #69, #265, #133
The crux of the issue is that a string has to either have syntax or not. If it does, then literal values require quoting/escaping - which for env vars, would often have to be done in shell. So env var values are not treated as having syntax.

Fixed in #427


Built-in Markdown Preview memory leak & slowdown

VSCode Version: 1.11.1
OS Version: Windows 10 1607 (14393.1066)
Memory: 11.75GB for system and applications, ~50% free

Steps to Reproduce:

Open medium-sized Markdown file (>1000 lines, tens of kB of content)
Divide view to 2 columns, on right one click "Preview", close the right source (so you have: left column - Markdown source, right column - preview)
Edit, add sections - mostly write new content for around 20-30 minutes

Expected results:
VSCode memory usage is stable, does not use more CPU with time.
Actual results:
After some time, VSCode process for Preview gets lots of memory (up to 1GB), updates of preview slow down and its process starts to use whole CPU core (25% on 4-core).
Closing the Preview kills the process with lots of memory and substantial CPU usage.
Sometimes it returns for a brief moment to the beginning of the file even though I'm editing at the end of it.
Other parts of VSCode work as usual.
The file I'm editing does not have anything strange inside - few tens of headers, lots of text (mostly long lines) and lots of short formatting - it's documentation.
Screeenshot over time from process explorer - it took around 20 minutes of writing, to get from 50MB to 1GB, where it stays:

@bpasero The action bar leak got fixed for 1.11.1, right?

Thanks for reporting this @mrowa!
I discovered a potentially major leak where iframes were not being destroyed properly when the preview content is rapidly updated. e97ca92 should address that but I still see some cases that still cause memory spikes even after that fix. I don't think this bug is specific to the markdown extension, rather the leaks seem to be caused by the markdown preview's rapid content updates
I'll continue investigating

Please try out the latest insiders builds and let me know if you still see this issue. I've made a number of perf fixes here but we still need some more real world testing to confirm that original problem has been fully addressed

Could not reproduce the memory leak, putting verified.


Properly silence SCP trace logs

Only some of the SCPP code checks if (mLogTrace(...)),
in many routines this is not checked. For example in
Slot::recordStatement which unconditionally calls
CLOG(DEBUG, "SCP") << "new statement: " ..

Alternatively, maybe we should just configure the logger on the D side ? Although that would still lead to overhead.

Didn't you make a commit to silence SCP first? it was done on the C++ side.

Yep, but as you discovered, it was far less from ideal.
Anyway we can go ahead with it.


Not detecting umbrel when attempting to migrate over?

I was on umbrel 0.3.12 and was looking to migrate to raspiblitz and was following the instruction but it is not detecting a migration from umbrel.

Thanks for the report - will retest for next release.
Do you have any special configuration (other hadware then recommended or had some additional software)?
For now you should be able to just reinsert the umbrel sd card again and it should continue running.

I am preparing a Umbrel 0.3.13 for testing ... it should be the same as the 0.3.12 - just with updated containers.

We didn't really change anything related to the mount/file system logic recently in Umbrel, so I'm not sure what went wrong in your case @DocCodez, we don't try to make anything in Umbrel to prevent you from migrating to a different solution.

I performed a new install of raspiblitz today and migration from umbrel v0.3.13 was successful.

@DocCodez Reflash the sd card and try again please. About not detecting, are you share it got to that point that mentions on how it is gonna sync the blockchain or reuse an existent one? Wait for this menu instructions.

Tested the Umbrel migration for v1.7.1RC2 ... looked good. Putting this on final testing.

OK tested again and working. Closing issue.


Grubby key price not registering in loot tab

As you can see from screenshot. The total loot value should be closer to 60k

As far as I'm aware, this is due to a delay in the item prices updating which is pulled from the API, not an issue with the client itself. http://api.runelite.net/runelite-1.5.28/item/price?id=991
The muddy key price spiked but it has since dropped back down to it's original price (as of writing this).

https://cdn.discordapp.com/attachments/379106621290446849/598215254689710080/tada.png
Issue has since been fixed. It most likely wasn't showing it yet since it was just released. Either way it now shows the correct amount. ALTHOUGH the pages do not display 1k each like they should. (This is due to them being untradeable with 0gp high alch value) The pages are a set 1k each though so I am guessing that it would be ok to change

Please go ahead and open a separate issue for the pages.