Introduce a Snapshot Procedure

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 34s
master passed

+1 :green_heart:
compile
3m 21s
master passed

+1 :green_heart:
checkstyle
1m  1s
master passed

+1 :green_heart:
spotbugs
4m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 23s
the patch passed

+1 :green_heart:
compile
3m 23s
the patch passed

+1 :green_heart:
cc
3m 23s
the patch passed

+1 :green_heart:
javac
3m 23s
the patch passed

-0 :warning:
checkstyle
0m 38s
hbase-server: The patch generated 6 new + 105 unchanged - 3 fixed = 111 total (was 108)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 23s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
hbaseprotoc
1m 17s
the patch passed

+1 :green_heart:
spotbugs
4m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

42m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4115

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 394a2a3bc318 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7316ba9c85

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 54s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 59s
master passed

+1 :green_heart:
compile
1m 27s
master passed

+1 :green_heart:
shadedjars
5m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 46s
the patch passed

+1 :green_heart:
compile
1m 29s
the patch passed

+1 :green_heart:
javac
1m 29s
the patch passed

+1 :green_heart:
shadedjars
5m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 34s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 48s
hbase-client in the patch passed.

+1 :green_heart:
unit
316m 32s
hbase-server in the patch passed.

345m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4115

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dfab7b34cd42 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7316ba9c85

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/1/testReport/

Max. process+thread count
1656 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 22s
master passed

+1 :green_heart:
compile
3m 22s
master passed

+1 :green_heart:
checkstyle
1m  0s
master passed

+1 :green_heart:
spotbugs
4m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 23s
the patch passed

-1 :x:
compile
0m 39s
hbase-server in the patch failed.

-0 :warning:
cc
0m 39s
hbase-server in the patch failed.

-0 :warning:
javac
0m 39s
hbase-server in the patch failed.

-0 :warning:
checkstyle
0m 36s
hbase-server: The patch generated 6 new + 105 unchanged - 3 fixed = 111 total (was 108)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 16s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
hbaseprotoc
1m 18s
the patch passed

+1 :green_heart:
spotbugs
5m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

41m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4115

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux a7432f536865 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8ddd1d0f9e

Default Java
AdoptOpenJDK-1.8.0_282-b08

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

cc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  3s
master passed

+1 :green_heart:
compile
1m 29s
master passed

+1 :green_heart:
shadedjars
5m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 44s
the patch passed

+1 :green_heart:
compile
1m 28s
the patch passed

+1 :green_heart:
javac
1m 28s
the patch passed

+1 :green_heart:
shadedjars
5m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 32s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 48s
hbase-client in the patch passed.

+1 :green_heart:
unit
317m 40s
hbase-server in the patch passed.

343m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4115

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a8221a61516e 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8ddd1d0f9e

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/testReport/

Max. process+thread count
1581 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 30s
master passed

+1 :green_heart:
compile
1m 16s
master passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 29s
the patch passed

+1 :green_heart:
compile
1m 16s
the patch passed

+1 :green_heart:
javac
1m 16s
the patch passed

+1 :green_heart:
shadedjars
5m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 25s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 41s
hbase-client in the patch passed.

+1 :green_heart:
unit
330m 23s
hbase-server in the patch passed.

355m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4115

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 427345492f8e 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8ddd1d0f9e

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/testReport/

Max. process+thread count
1585 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 23s
master passed

+1 :green_heart:
compile
3m 20s
master passed

+1 :green_heart:
checkstyle
1m  0s
master passed

+1 :green_heart:
spotbugs
4m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 24s
the patch passed

+1 :green_heart:
compile
3m 20s
the patch passed

+1 :green_heart:
cc
3m 20s
the patch passed

+1 :green_heart:
javac
3m 20s
the patch passed

-0 :warning:
checkstyle
0m 38s
hbase-server: The patch generated 1 new + 105 unchanged - 3 fixed = 106 total (was 108)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 20s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
hbaseprotoc
1m 19s
the patch passed

+1 :green_heart:
spotbugs
5m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

42m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4115

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux bb3190079a18 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8dec499181

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 55s
master passed

+1 :green_heart:
compile
1m 29s
master passed

+1 :green_heart:
shadedjars
5m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 46s
the patch passed

+1 :green_heart:
compile
1m 30s
the patch passed

+1 :green_heart:
javac
1m 30s
the patch passed

+1 :green_heart:
shadedjars
4m 58s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 32s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 47s
hbase-client in the patch passed.

-1 :x:
unit
317m 46s
hbase-server in the patch failed.

343m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4115

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9eb9de6f0562 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8dec499181

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/3/testReport/

Max. process+thread count
1609 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  4s
master passed

+1 :green_heart:
compile
4m 25s
master passed

+1 :green_heart:
checkstyle
1m 12s
master passed

+1 :green_heart:
spotbugs
6m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  1s
the patch passed

+1 :green_heart:
compile
4m  7s
the patch passed

+1 :green_heart:
cc
4m  7s
the patch passed

+1 :green_heart:
javac
4m  7s
the patch passed

-0 :warning:
checkstyle
0m 40s
hbase-server: The patch generated 1 new + 105 unchanged - 3 fixed = 106 total (was 108)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 55s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
hbaseprotoc
1m 24s
the patch passed

+1 :green_heart:
spotbugs
5m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

51m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4115

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 606f16d522a0 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8dec499181

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 22s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 59s
master passed

+1 :green_heart:
compile
1m 35s
master passed

+1 :green_heart:
shadedjars
5m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 51s
the patch passed

+1 :green_heart:
compile
1m 44s
the patch passed

+1 :green_heart:
javac
1m 44s
the patch passed

+1 :green_heart:
shadedjars
6m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 33s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 48s
hbase-client in the patch passed.

+1 :green_heart:
unit
353m 12s
hbase-server in the patch passed.

381m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4115

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 290212966ceb 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8dec499181

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/testReport/

Max. process+thread count
1629 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hi duo, I've made some progress recently.

using WorkerAssigner to distribute the task of snapshot verification.
a. move WorkerAssigner out of SplitWALManager for reuse.
b. new a WorkerAssigner instance in the SnapshotManger and distribute the task of snapshot verification with it.
introduce a RSSnapshotVerifier
a. since now we verify only one region via a verification procedure, it could be slow if we load the SnapshotManaifest from hdfs every time. so I add a cache for it.
b. the RSSnapshotVerifier is used to verify regioninfo and store files.
if the snapshot is corrupted, we touch a hdfs file to notify the upper layer procedures.
using nonceGroup and nonce field in the snapshot request to identify whether the client can handle snapshot proc id.
introduce a switch in SnapshotManager hbase.snapshot.procedure.enabled to enable snapshot procedure so that we can fallback to the zk-coordinated snapshot.

If you have time, would you mind taking a look on this at your convenience and see if there is any problems ? Thanks. @Apache9

Really thanks for your great suggestions and help, Duo. I will address it ASAP. @Apache9

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 22s
master passed

+1 :green_heart:
compile
3m 21s
master passed

+1 :green_heart:
checkstyle
1m  1s
master passed

+1 :green_heart:
spotbugs
4m 26s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 24s
the patch passed

+1 :green_heart:
compile
3m 24s
the patch passed

+1 :green_heart:
cc
3m 24s
the patch passed

+1 :green_heart:
javac
3m 24s
the patch passed

-0 :warning:
checkstyle
0m 37s
hbase-server: The patch generated 1 new + 105 unchanged - 3 fixed = 106 total (was 108)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 19s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
hbaseprotoc
1m 19s
the patch passed

+1 :green_heart:
spotbugs
4m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

42m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4115

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux ddf41b59447b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5dc663ea38

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 20s
master passed

+1 :green_heart:
compile
1m 14s
master passed

+1 :green_heart:
shadedjars
4m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 16s
the patch passed

+1 :green_heart:
compile
1m 11s
the patch passed

+1 :green_heart:
javac
1m 11s
the patch passed

+1 :green_heart:
shadedjars
4m 55s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 24s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 34s
hbase-client in the patch passed.

-1 :x:
unit
333m 26s
hbase-server in the patch failed.

356m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4115

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5ef1781f767c 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5dc663ea38

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/5/testReport/

Max. process+thread count
1622 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Really appreciate your help, Duo @Apache9


Add end-to-end tests for CLI commands

Feature request summary
There is a lot to be done in terms of testing. For a start, we could focus on high level "e2e" tests and execute each command of the CLI tool against a sample unikernel project.
We could start with one project + one test case per command, then expand as we see fit.
This doesn't provide a feedback loop as quick as unit tests, but would already allow us to catch major regressions in the CI.
E2E tests

[x] Test kraft version

[x] https://github.com/unikraft/kraftkit/pull/392

[x] Test kraft pkg update

[x] https://github.com/unikraft/kraftkit/pull/405

[ ] Test kraft pkg ls
[ ] Test kraft pkg pull
[ ] Test kraft build
[ ] Test kraft pkg

I think our next focus should be on kraft build.
It would be very nice to have an initial test that just

initializes a temporary project from a few fixture files (helloworld.c might even be enough?)
writes a kraft.yaml in that project
builds a few targets


CLI did not provide confirmation that my project was created and next step instructions to go to localhost:5000

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1205
Originally created by @dmor on 2019-10-24 19:02:02

Behavior That Occurred
When I ran meltano ui I received the following output, which does not say my project was successfully created and to go to localhost:5000
When I did go to localhost:5000 Meltano's UI had successfully loaded, but in the CLI it appeared to be hung (until I started to interact with the UI)
(Meltano) Danielles-MBP:carbon daniellemorrill$ meltano ui
[MainThread][INFO][2019-10-24 12:57:59,561] Context impl SQLiteImpl.
[MainThread][INFO][2019-10-24 12:57:59,561] Will assume non-transactional DDL.
Upgrading database to 6ef30ab7b8e5
[MainThread][INFO][2019-10-24 12:57:59,569] Context impl SQLiteImpl.
[MainThread][INFO][2019-10-24 12:57:59,569] Will assume non-transactional DDL.
[MainThread][INFO][2019-10-24 12:57:59,572] Running upgrade  -> b4c05e463b53, Create meltano.core base tables
[MainThread][INFO][2019-10-24 12:57:59,586] Running upgrade b4c05e463b53 -> 6ef30ab7b8e5, Create meltano.api tables
[MainThread][INFO][2019-10-24 12:57:59,788] Auto-compiling models in '/Users/daniellemorrill/Projects/dogfood-20191024/carbon/model'
[MainThread][INFO][2019-10-24 12:57:59,790] All workers started.
[2019-10-24 12:58:00 -0600] [13473] [INFO] Starting gunicorn 19.9.0
[2019-10-24 12:58:00 -0600] [13473] [INFO] Listening at: http://<IP_ADDRESS>:5000 (13473)
[2019-10-24 12:58:00 -0600] [13473] [INFO] Using worker: sync
[2019-10-24 12:58:00 -0600] [13476] [INFO] Booting worker with pid: 13476
[2019-10-24 12:58:00 -0600] [13477] [INFO] Booting worker with pid: 13477
[2019-10-24 12:58:00 -0600] [13478] [INFO] Booting worker with pid: 13478
[2019-10-24 12:58:00 -0600] [13479] [INFO] Booting worker with pid: 13479

Expected Behavior

CLI gives the user confirmation that their actions were successful and generated the intended result
CLI gives the user clear next step

View 9 previous comments from the original issue on GitLab

Closing as no longer relevant on account of the removal of the UI for Meltano 3.0


Add documentation: TabSelect property

In commit da06e45f829a3d5c0323a9d0d9d5ff2def4825b5 the functionality to select the first item on tab is added, but this can't be found in the documentation. This change adds that documentation.

Oof, We generally avoid merging PRs that add features without adding the corresponding documentation, but I guess this slipped through the cracks.
Merged, thank you!

Did this ever happen? I don't see it in the docs, and the feature doesn't appear to work.


Adds middleware/serializers construction through Log4j configuration

If the HttpSenderMiddleware, EventBodySerializer and EventHeaderSerializer objects require additional configuration, instantiation by class name might not be enough (see this question on StackOverflow).
While maintaining backward compatibility, this PR adds the possibility to configure additional components through Log4j:
<SplunkHttp>
    <SomeMiddleware attributeA="a" attributeB="b" />
    <SomeBodySerializer ... />
    <SomeHeaderSerializer ... />
</SplunkHttp>

The elements SomeMiddleware, SomeBodySerializer and SomeHeaderSerializer must be Log4j plugins of element type middleware, eventBodySerializer and eventHeaderSerializer respectively.
This PR contains a simple unit test.

Hi @ppkarwasz,
There are conflicts in this PR. Will you please resolve conflicts so that we can review your changes?
Thanks.

@bparmar-splunk: I rebased the contribution and rewrote it to use a builder instead of a 33 parameter constructor (which I deprecated).
BTW: all *Test classes are excluded in your Maven Surefire configuration.


FI-2787: AuthInfo input skeleton

Summary
This branch provides an initial skeleton for a new type of input called auth_info. The goals for this input type are to consolidate all of the information needed to perform authorization, use that authorization to access resources, and refresh the authorization into a single location.
The intent is for the UI for this input type to be dynamic so that only the fields necessary for the particular scenario are displayed to the user. This will be accomplished through several means:

a mode option with the following possible values:

auth - this will present all of the input fields required in order to perform an initial authorization
access - this will present the access token, as well as the fields required to refresh that access token, for tests which are accessing resources based on a prior authorization.

a use_discovery checkbox in auth mode. When checked, the fields which can be found via a discovery endpoint will not be displayed to the user.
the auth_type field allows the user (or the test writer) to select which auth workflow will be used, so that only the fields relevant to that particular workflow are displayed.

This branch does not implement the actual use of the auth_info input type, but exposes examples through the JSON API to support front end development for this feature.
Testing Guidance
There is a new auth info suite which containts tests with default input values for each of the modes and auth types. Since the UI for this input type is not yet implemented, the inputs will appear as text inputs. The tests will verify that the received inputs are what is expected, so as the UI is developed, they can be used to validate the UI behavior.

I'm ok with this approach for now.

@arscan Could you approve the PR then?


XCode 12 Build Error range of supported deployment target versions is 9.0 to 14.0.99

Hi,
when doing a carthage update on base32, I get some errors, see below. It seems to be related, that Xcode 12 only supports iOS 9 upwards as deplyoment target. How to fix this?
*** Building scheme "Base32" in Base32.xcodeproj
Build Failed
Task failed with exit code 1:
/usr/bin/xcrun lipo -create /Users/xxx/Library/Caches/org.carthage.CarthageKit/DerivedData/12.0.1_12A7300/Base32/0.8.0/Build/Intermediates.noindex/ArchiveIntermediates/Base32/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/Base32.framework/Base32 /Users/xxx/Library/Caches/org.carthage.CarthageKit/DerivedData/12.0.1_12A7300/Base32/0.8.0/Build/Products/Release-iphonesimulator/Base32.framework/Base32 -output /Users/xx/D/Carthage/Build/iOS/Base32.framework/Base32
2020-10-05 16:26:13.235 xcodebuild[43889:6527489] [MT] iPhoneConnect: Failed _shouldMakeReadyForDevelopment check even though device is not locked by passcode.
Domain: com.apple.platform.iphoneos
Code: 5
Failure Reason: allowsSecureServices: 1. isConnected: 0. Platform: <DVTPlatform:0x7fe7257190e0:'com.apple.platform.iphoneos':<DVTFilePath:0x7fe725719060:'/Applications/Xcode.app/Conte
nts/Developer/Platforms/iPhoneOS.platform'>>. DTDKDeviceIdentifierIsIDID: 0
User Info: {
DVTDeviceDescription = "\Ud83d\Udcf1<DVTiOSDevice (0x7fe72a6c4c40), xxx, iPad, 13.4.1 (17E262), 4fd85e41fa4f1f31a891c04c8e0375eb177cd793>";
}
2020-10-05 16:26:13.235 xcodebuild[43889:6527489] [MT] iPhoneConnect: <9F><93><DVTiOSDevice (0x7fe72a6c4c40), xxxx, iPad, 14.0.1 (18A393), 4fd85e41fa4f1f31a891c04c8e0375eb
177cd793> == END: Underlying device preparation errors ==
note: Constructing build description
warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99. (in target 'Base32' from projec
t 'Base32')
CreateBuildDirectory /Users/xxx/Library/Caches/org.carthage.CarthageKit/DerivedData/12.0.1_12A7300/Base32/0.8.0/Build/Intermediates.noindex/ArchiveIntermediates/Base32/InstallationBuil
dProductsLocation (in target 'Base32' from project 'Base32')
cd /Users/xx/Documents/WORK/D/Carthage/Checkouts/Base32
builtin-create-build-directory /Users/xx/Library/Caches/org.carthage.CarthageKit/DerivedData/12.0.1_12A7300/Base32/0.8.0/Build/Intermediates.noindex/ArchiveIntermediates/Base32/In
stallationBuildProductsLocation

I have seen that this is fixed on trunk - however carthage always fetches version 0.8.0 but after using

github "norio-nomura/Base32" "master"

in the Cartfile  it fetches the master code and compiles - but it would be nice if you could release a new version - so the default Cartfile entry will work with new xcode/swift versions

Thanks for reporting.
I have released 0.9.0.
$ (master) pod trunk push

[!] Found podspec `SwiftBase32.podspec`
Updating spec repo `trunk`
Validating podspec
 -> SwiftBase32 (0.9.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Building targets in parallel
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')
    - NOTE  | xcodebuild:  note: Using codesigning identity override:

Updating spec repo `trunk`

--------------------------------------------------------------------------------
 🎉  Congrats

 🚀  SwiftBase32 (0.9.0) successfully published
 📅  October 8th, 08:43
 🌎  https://cocoapods.org/pods/SwiftBase32
 👍  Tell your friends!
--------------------------------------------------------------------------------

Thanks! Although there is still a problem with the carthage build with Xcode 12:  the build fails on lipo due to duplicate architectures:

Release-iphonesimulator/Base32.framework/Base32 have the same architectures (arm64) and can't be in the same fat output file

See also: here
However with the following workaround from the issue above, I was able to build Version 0.9.0:
#!/usr/bin/env bash
# carthage.sh
# Usage example: ./carthage.sh build --platform iOS

set -euo pipefail

xcconfig=$(mktemp /tmp/static.xcconfig.XXXXXX)
trap 'rm -f "$xcconfig"' INT TERM HUP EXIT

# For Xcode 12 make sure EXCLUDED_ARCHS is set to arm architectures otherwise
# the build will fail on lipo due to duplicate architectures.
echo 'EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_simulator__NATIVE_ARCH_64_BIT_x86_64__XCODE_1200 = arm64 arm64e armv7 armv7s armv6 armv8' >> $xcconfig
echo 'EXCLUDED_ARCHS = $(inherited) $(EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_$(EFFECTIVE_PLATFORM_SUFFIX)__NATIVE_ARCH_64_BIT_$(NATIVE_ARCH_64_BIT)__XCODE_$(XCODE_VERSION_MAJOR))' >> $xcconfig

export XCODE_XCCONFIG_FILE="$xcconfig"
carthage "$@"

I am not sure if the problem is on carthage or framework side....

I think carthage should support xcframework creation.


fix: Edit Project button breaks the UI when there is no Website URL

Clicking the "Edit Project" button breaks the UI when there is no Website URL stored for the project. This occurs due to the presence of defaultValue={props.websiteLink.url} in the components/projects/edit-project-form.tsx file.

great catch, thank you!


Improve the error message for assignment to final local variables

Given the following code:
main() {
  final x = 0;
  x = 42;
}

Analyzer produces an error message that discusses the absence of a setter, but local variables do not induce getters and setters, so the error is confusing.

The analyzer now produces a much more readable error:
  error • The final variable 'x' can only be set once. • 30490.dart:3:3 • assignment_to_final_local
  hint • The value of the local variable 'x' isn't used. • 30490.dart:2:9 • unused_local_variable


Run polygon-edge 0.8.1 on network created with 0.8 cause errors

[ Subject of the issue ]
Description
Describe your issue in as much detail as possible here.
Your environment

OS and version.
The version of the Polygon Edge.
(Confirm the version of your Polygon edge client by running the following command: polygon-edge version --grpc-address GRPC_ADDRESS)
The branch that causes this issue.
Locally or Cloud hosted (which provider).
Please confirm if the validators are running under containerized environment (K8s, Docker, etc.).

Steps to reproduce

Tell us how to reproduce this issue.
Where the issue is, if you know.
Which commands triggered the issue, if any.
Provide us with the content of your genesis file.
Provide us with commands that you used to start your validators.
Provide us with the peer list of each of your validators by running the following command: polygon-edge peers list --grpc-address GRPC_ADDRESS.
Is the chain producing blocks and serving customers atm?

Expected behavior

Tell us what should happen.
Tell us what happened instead.

Logs
Provide us with debug logs from all of your validators by setting logging to debug output with: server --log-level debug
Proposed solution
If you have an idea on how to fix this issue, please write it down here, so we can begin discussing it
the error is :
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x151b5d6]
goroutine 1 [running]:
math/big.(*Int).Set(...)
/usr/local/go/src/math/big/int.go:74
github.com/0xPolygon/polygon-edge/consensus/polybft.Validator.ToValidatorInitAPIBinding({{0x80, 0x76, 0x4c, 0x74, 0x9a, 0x8b, 0x9a, 0xca, 0xed, 0x75, ...}, ...})
/root/polygon-edge/consensus/polybft/polybft_config.go:176 +0xd6
github.com/0xPolygon/polygon-edge/consensus/polybft.getInitChildValidatorSetInput({{0xc00136a7e0, 0xa, 0xd}, 0x0, 0x200, 0x1, 0x5, 0x77359400, {0x80, 0x76, ...}, ...})
/root/polygon-edge/consensus/polybft/contracts_initializer.go:31 +0xd8
github.com/0xPolygon/polygon-edge/consensus/polybft.GenesisPostHookFactory.func1(0xc001775798?)
/root/polygon-edge/consensus/polybft/polybft.go:122 +0x118
github.com/0xPolygon/polygon-edge/state.(*Executor).WriteGenesis(0xc0016ff5c0, 0xc6a6ceb32eca75ed?, {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...})
/root/polygon-edge/state/executor.go:110 +0x4ca
github.com/0xPolygon/polygon-edge/server.NewServer(0xc00139f5e0)
/root/polygon-edge/server/server.go:239 +0xc5a
github.com/0xPolygon/polygon-edge/command/server.runServerLoop(0x314de60?, {0x2371180, 0xc0013b2600})
/root/polygon-edge/command/server/server.go:318 +0x27
github.com/0xPolygon/polygon-edge/command/server.runCommand(0xc001380900?, {0x1b11e83?, 0x4?, 0x4?})
/root/polygon-edge/command/server/server.go:306 +0x45
github.com/spf13/cobra.(*Command).execute(0xc001380900, {0xc000dbdfc0, 0x4, 0x4})
/root/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x847
github.com/spf13/cobra.(*Command).ExecuteC(0xc00026e300)
/root/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
/root/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
github.com/0xPolygon/polygon-edge/command/root.(*RootCommand).Execute(0xc0000061a0?)
/root/polygon-edge/command/root/root.go:72 +0x1c
main.main()
/root/polygon-edge/main.go:18 +0x51

This happens because the manifest file on v0.8.1 expects a new parameter, called Stake. Since you are using the manifest file generated on v0.8.0, it is wrong. If possible, you should bootstrap the network from scratch (regenerate manifest, genesis, etc.)


Improved cdx parsing

Description of the PR
Improved cdx parsing and updated the test accordingly.
Fixes: #1884
PR Checklist

[x] All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
[x] All new changes are covered by tests
[ ] All CI checks are passing (tests and formatting)

Hey @pxp928, I have updated the PR.

@Yaxhveer we will have to rebase this PR. Could you please do that?


Failure with file path as 'page' parameter

I've got this working great with URLs and even STDIN via a PHP command line script.
However, it seems to fail with local file paths. I've even tried prefixing them with 'file://' but no joy.
According to the settings documentation, the 'page' parameter can be a path:

"The URL or path of the web page to convert, if "-" input is read from stdin."

When run via PHP command line, the function just returns false and no error is raised.
When run via PHP-FPM (fast cgi) the server gets a bad gateway, and no error is logged.
Is this expected behaviour? i.e. are local file paths supported?

This sorts the problem for the PHP command line, but I still get a bad gateway via fast cgi through the web server

@timwhitlock - are you sure your FPM process is able to read the file (ie. the user that fpm is running as can both list and read the file)


Improve optimisation app

[x] Display reproduction number on table.
[x] Change label of axis to include units, e.g. 'Number of individual' to 'Individuals (100K).
[x] Add loading indication so that users know the app is running.
[x] Change html.Br() to margin settings.

#84 Completed


Fix: Improve third party service integration

Fix an issue where we could get an exception before reaching the
try/catch for the Promise that communicates with the 3rd party
service.

Pull request checklist
Make sure you:

[X] Signed the Contributor License Agreement
[X] Followed the commit message guidelines

For non-trivial changes, please make sure you also:

[ ] Added/Updated related documentation.
[ ] Added/Updated related tests.

Short description of the change(s)

This should be ready for review!

@alrra, @sarvaje can I have some 👀 in this PR?

I've squashed and rebased. Will merge once all the CI tests pass.


Release/1.0.0

Contains the metrics endpoint feature
and some major refactorings.

@sarnowski and @hjacobs : Can you please have a look at this?

Just merge, it works well in Kio :+1:

:scream:


Possible optimisation of switch cases

[@renatoathaydes] The following switch statement seems to trigger an unnecessary analysis of the reified type parameter of Hi.
shared class Hi<out Arg>(shared Arg greeting) {}
shared class Bye(shared String word) {}
shared class NonFinal(shared String word) {}

shared void run() {
    // make items contain many his and a few byes to
   // stop the JVM from optimising away stuff at runtime
    value items = [ for (i in 1..100k) if (10.divides(i))
                    then Bye(i.string) else Hi(NonFinal(i.string)) ];

    value startTime = system.milliseconds;

    variable Integer byes = 0;
    variable Integer his = 0;
    for (item in items) {
        switch(item)
        case (is Bye) {
            byes++;
        }
        case (is Hi<NonFinal>) {
            his++;
        }
    }

    value totalTime = system.milliseconds - startTime;
    print("Found ``his`` his and ``byes`` byes in ``totalTime`` ms.");

}

In my machine, this prints (3 runs):
Found 90000 his and 10000 byes in 526 ms.
Found 90000 his and 10000 byes in 447 ms.
Found 90000 his and 10000 byes in 466 ms.

We can optimise the switch statement trivially to run much faster:
switch(item)
case (is Bye) {
    byes++;
}
//case (is Hi<NonFinal>) {
else {
    his++;
}

This prints:
Found 90000 his and 10000 byes in 34 ms.
Found 90000 his and 10000 byes in 34 ms.
Found 90000 his and 10000 byes in 35 ms.

This seems to be a trivial optimisation opportunity for the compiler to make? Semantically, the code remains the same but the speed improvement is enormous.
[Migrated from ceylon/ceylon-spec#1304]

I just finished some related work on the Dart backend that would help here. For Dart, the idea is to warn when reified tests are necessary but not available. For Java & JS, it's just the opposite, don't perform a full reified type check if not necessary.
Using the following definitions:

TestedType: the static type of the value we are testing
IsType: the type we are testing against (whatever follows the is keyword)
RawIsType: a "raw" version of IsType; type parameters are bound to the least restrictive type possible.
ExpectedType: The result per the typechecker, which is TestedType & IsType
OptimizedType: The result if we were instead to use RawIsType (TestedType & RawIsType)

the steps are:

Calculate RawIsType. This is a recursive calculation, accounting for qualifying types, erased types like Identifiable, and type parameters, and preserving all unions and intersections. Covariant type parameters are assigned the union of the parameter's upper bound constraints. Contravariant type parameters are assigned Nothing. Invariant type parameters are assigned the same as covariant parameters, but with use-site covariance.
Calculate ExpectedType and OptimizedType per their definitions.
Determine if OptimizedType <: ExpectedType. If so, implement the is test using only instanceof and logical operators.

Note: types involving captured type parameters of functions (i.e. any class or interface with a generic function in it's ancestry) will likely need to be excluded from the optimization.
with the results:
After compiling a few sdk modules on the Dart & JVM backends and looking the cases where the Dart compiler did not warn for is tests but the JVM compiler did produce isReified calls, the following inefficiencies were found:

Location
is test in current code
suitable "raw" replacement

ceylon.collection::ArrayList.copyTo
is Array<Element?>
Array<out Anything>

ceylon.collection::ArrayList.copyTo
is ArrayList<Element>
ArrayList<out Anything>

ceylon.html::StyledElement
is String[]
Anything[]

ceylon.json.stream::StreamingVisitor
is String->JsonValue
Anything->Anything

ceylon.logging::Logger.ceylon
is String()
Anything(*Nothing)

ceylon.time::DateRange.gap
is [Date,Date]
[Anything,Anything*]

ceylon.time::DateTimeRange.gap
is [DateTime,DateTime]
[Anything,Anything*]

ceylon.time::TimeRange.gap
is [Time,Time]
[Anything,Anything*]

And of course, similar for the original example in the issue description since
Hi<> and Bye are disjoint.

p.s. I think this issue/optimization should be tagged for the backends, not the typechecker.

Your RawIsType is broken when bounds are recursively defined. But if y'all have adopted material-shape separation (I don't know what the status of that is), then you can just use the material bounds, which are defined to be non-recursive. Note that those bounds, too, might be refinable this way. I think that should still terminate though. Regardless, in my survey I found that these are rarely used, at least in Java, so you may just want to skip this process entirely.
Lastly, you can simplify this check to just TestedType & RawIsType <: IsType.
Note that if that check fails, you can recursively do a similar process for the problematic type arguments. This way you're only checking the type arguments that actually matter.

Your RawIsType is broken when bounds are recursively defined

Yes, thanks, I should have made a note of that. In fact, I had hacked in an Anything and a TODO in my code.

Regardless, in my survey I found that these are rarely used

@RossTate I though you might be interested, I added a println to search for this in the language and sdk modules I'm compiling, and found 9 cases. They are all doing the same thing.
Enumerable has a self type, and a Range is an efficient range of Enumerables. Ranges are compared by making sure they are the same type (the 9 cases), and then comparing their endpoints or offsets.

Lastly, you can simplify this check to just TestedType & RawIsType <: IsType

Ah, yes, that's better. Thanks!

I should have noted, this doesn't apply to types that might capture a type parameter that is not represented by a qualifying type.
For example, class C:
void fun<T>() {
    class C() {}
}

or even class E:
class D<T>() {
    void fun() {
        class E() {}
    }
}

I would also add that an assert(is...) should always just use isinstance if it has to.


[libjpeg-turbo] Requires wrapper to correctly find debug/release variant

From CMake FindJPEG.cmake:
set(jpeg_names ${JPEG_NAMES} jpeg jpeg-static libjpeg libjpeg-static)
foreach(name ${jpeg_names})
  list(APPEND jpeg_names_debug "${name}d")
endforeach()

The upstream should support it.

for the time vcpkg should install a vcpkg_cmake_wrapper to make sure that the right libraries are always found

@Neumann-A We already do that. See https://github.com/microsoft/vcpkg/blob/master/ports/libjpeg-turbo/vcpkg-cmake-wrapper.cmake

That is not enough. You have to do a find_library call for JPEG_LIBRARY_RELEASE and JPEG_LIBRARY_DEBUG before the find_package call and make sure that those variables are correctly set. The point of the current wrapper is just to add the target JPEG::JPEG.
But the current wrapper is just a copy of a newer findJPEG within cmake another example why vcpkg should have FindModules instead of the wrappers.

Related to https://github.com/microsoft/vcpkg/issues/15731

Upstraem PR https://gitlab.kitware.com/cmake/cmake/-/merge_requests/1974.

I would like to note that libjpeg-turbo is just one (compatible) implementation of the library to be found by FindJPEG.cmake.

@JackBoosY:
You can close https://gitlab.kitware.com/cmake/cmake/-/issues/22481.
The vcpkg maintainer guidelines forbid messing with upstream naming as such I changed title of this issue to correctly reflect what needs to be done.

@Neumann-A Any way, use FindJPEG.cmake will fail to find the debug library generated in vcpkg.
So I have an idea:

Export all the jpeg targets.
Add cmake wrapper to avoid use FindJPEG.cmake in vcpkg toolchain.

Please no. Just fix the default FindJPEG.cmake which comes with CMake.

@Neumann-A  We can't patch FindJPEG.cmake in our side, the only way is add wrapper or copy the correct FindJPEG.cmake to share/JPEG.

Just fix the default FindJPEG.cmake which comes with CMake.

We can't patch FindJPEG.cmake in our side, the only way is add wrapper or copy the correct FindJPEG.cmake to share/JPEG.

@JackBoosY Together with the issue's title, I assume @Neumann-A meant fixing by adding a suitable wrapper, not fixing the module files. It was meant to make clear that it is wrong to "avoid use FindJPEG.cmake".

@dg0yt See the upstream code https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindJPEG.cmake#L61-64:
set(jpeg_names ${JPEG_NAMES} jpeg jpeg-static libjpeg libjpeg-static)
foreach(name ${jpeg_names})
  list(APPEND jpeg_names_debug "${name}d")
endforeach()

if(NOT JPEG_LIBRARY)
  find_library(JPEG_LIBRARY_RELEASE NAMES ${jpeg_names} NAMES_PER_DIR)
  find_library(JPEG_LIBRARY_DEBUG NAMES ${jpeg_names_debug} NAMES_PER_DIR)
  include(${CMAKE_CURRENT_LIST_DIR}/SelectLibraryConfigurations.cmake)
  select_library_configurations(JPEG)
  mark_as_advanced(JPEG_LIBRARY_RELEASE JPEG_LIBRARY_DEBUG)
endif()

The suffix d is mandatory and we cannot fix it in any way.

@JackBoosY
Just like expat:
https://github.com/microsoft/vcpkg/blob/master/ports/expat/vcpkg-cmake-wrapper.cmake
do the find_library call with the "vcpkg correct names" before the find_package call.

The suffix d is mandatory and we cannot fix it in any way.

(feels like speaking to a wall which I really don't get)

I would help follow up this issue and continue the PR https://github.com/microsoft/vcpkg/pull/18742/

The suffix d is mandatory and we cannot fix it in any way.

@JackBoosY You fix this by calling find_library(JPEG_LIBRARY_DEBUG ...) in the wrapper with custom parameters. This creates a cache variable JPEG_LIBRARY_DEBUG, and the following call in the pristine cmake find module is a no-op. This is what cmake cache variables were created for.

@dg0yt So since libjpeg expoted the targets, why not to use them. I think they are more safe than the FindJPEG.cmake.

@dg0yt So since libjpeg expoted the targets, why not to use them. I think they are more safe than the FindJPEG.cmake.

I'm not sure which exported targets you are refering to.
This issue is about cmake's FindJPEG.cmake module. vcpkg claims to support cmake down to version 3.1 in user projects. So vcpkg must ensure that `find_package(JPEG)' provides the right configuration.
You must not ask for user projects to change. Behaviour with vcpkg must be the same as without vcpkg, only that libs, definitions, includes etc. must come from the installed ports.


[VL] Gluten plugin graceful shutdown when Spark session is closed

Description
Spark session can be shut down and renewed per Spark's design. When a new session is created, some session-wise configurations (e.g. Spark local dir) may change. Gluten now only do static initialization once in the same process without checking configuration changes.
We should implement a new mechanism to clean up Gluten's global states as well as vanilla Spark's doing.

SparkSession.close will trigger SparkContext.stop. We may be able to implement the shutdown  method in GlutenPlugin to unload gluten.


*: remove pv-provisioner and create-storage-class flags

Removed all logic related to the pv-provisioner and create-storage-class flags.
The backup policy validation at the controller now includes checking that storage class must be set, else the event is not handled with a warning.
fail to handle event: invalid cluster spec. please fix the following problem with the cluster spec: PV backup must have a storage class set

lgtm


deepin.deepin-desktop-schemas: 3.4.0 -> 3.6.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/deepin-desktop-schemas/versions.
meta.description for deepin.deepin-desktop-schemas is: '"GSettings deepin desktop-wide schemas"'.
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/e656a556c0221bc2b6495504cda93bea

du listing: https://gist.github.com/7834cd3a2da0c1609dffdc485d6624b5

Rebuild report (if merged into master) (click to expand)

9 total rebuild path(s)
3 package rebuild(s)
3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
deepin.deepin-desktop-schemas
deepin.deepin-metacity
deepin.deepin-wm

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/64lbxbiasv0hc5f2w00fix3bkydpmr8v-deepin-desktop-schemas-3.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A deepin.deepin-desktop-schemas https://github.com/r-ryantm/nixpkgs/archive/2c123390d910e1dcc8a59cac77414e5e386d9f19.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/64lbxbiasv0hc5f2w00fix3bkydpmr8v-deepin-desktop-schemas-3.6.0
ls -la /nix/store/64lbxbiasv0hc5f2w00fix3bkydpmr8v-deepin-desktop-schemas-3.6.0/bin

cc @romildo for testing.

I am preparing updates, new packages and fixes for deepin. So I would like to not have this update merged.


Finish read-only transaction when aborted

Currently, spanner-cli continues read-write transaction mode when the RPC returns a code "Aborted".
> BEGIN RW;
Query OK, 0 rows affected (0.01 sec)

(rw txn)> @{LOCK_SCANNED_RANGES=exclusive} SELECT * FROM tbl WHERE pk = 0;
Empty set (3.72 msecs)

(rw txn)> @{LOCK_SCANNED_RANGES=exclusive} SELECT * FROM tbl WHERE pk = 0;
ERROR: spanner: code = "Aborted", desc = "Transaction was aborted."
(rw txn)> BEGIN RW;
ERROR: you're in read-write transaction. Please finish the transaction by 'COMMIT;' or 'ROLLBACK;'
(rw txn)> COMMIT;
ERROR: spanner: code = "Aborted", desc = "Transaction was aborted."
> BEGIN RW;
Query OK, 0 rows affected (2.22 sec)

In this state, users can't execute another statement until execute ROLLBACK or COMMIT.
(^D terminates spanner-cli)
Expected behavior
Finish read-write transaction mode when aborted and users can continue another operations immediately.
> BEGIN RW;
Query OK, 0 rows affected (0.01 sec)

(rw txn)> @{LOCK_SCANNED_RANGES=exclusive} SELECT * FROM tbl WHERE pk = 0;
Empty set (3.72 msecs)

(rw txn)> @{LOCK_SCANNED_RANGES=exclusive} SELECT * FROM tbl WHERE pk = 0;
ERROR: spanner: code = "Aborted", desc = "Transaction was aborted."
> BEGIN RW;
Query OK, 0 rows affected (2.22 sec)

That's good catch! I think it's because while the error raised in DML statement is handled, the error raised in SELECT statement is not handled properly.
Could you create a patch for this issue?

OK. I'll fix it.

Thanks!


Replace IllegalStateException with IllegalArgumentException where Exception is caused by bad input

discussed here
done via https://github.com/graphhopper/jsprit/commit/3966590fc7ce6182cb5c58db20c1440367c7aa62


Implement "Go to Definition" in the language server

First part of #714 implementing the support for Go to Definition in Solang LSP.
I'll add support for other features such as Go to type definition, ... in follow-up PRs.
Small Demo
https://user-images.githubusercontent.com/119507009/209476628-24ec3af5-396b-4d64-8540-ff0395ec3a65.mp4
Signed-off-by: darkdrag00n<EMAIL_ADDRESS>

Looks very good! Some comments:

The lookup_tbl and definition_tbl should go into one struct, and passed around as one
Missing definitions for function definitions:  Expression::InternalFunction,Expression::ExternalFunction, Expression::InternalFunctionCall, Expression::ExternalFunctionCall`.
Missing contract Expression::Constructor
Event definition for Statement::Emit
Storage Definition for Statement::Delete
Fields of struct definition or event definition can be structs/enums too

Done, moved them in a struct named Intelligence. Please suggest alternative name if necessary
Works for me. Can you share the code on which it didn't work for you?
Done, added
Done, added
Done, added
Works for me with the nested structs/enums also. Same as point 2, please share the code on which it didn't work for you.

This is ready for another round of review from my end. Thanks!


Allow late bound symbols in augmentations to merge into late bound symbol tables

Fixes #28334

ping @rbuckton for a review~

Your build is failing, can you take a look.

Yeah, looks like one of the newer baselines I've added is affected by this; I'll have to go gin up the diff and add it.

Handled by #30970


Typo in documentation about options

Hello,
According to documentation, options.refresh should handles the refresh mechanism but according to the source file (src/Iframe.js L12), the name of the key is reload.

Right, this was corrected in the README after it was first posted to the Exchange
This should be updated now there as well.


remove LotkaV, mg1 and two-moons related code.

remove all code related to old simulators
some import sorting

all related tests pass.


I can't make an animation(gif file), spider (anaconda3)

I can't make an animation(gif file). Please help me.
I use a spider (anaconda3).
Refer to the Python code inserted below.
It succeeded in creating a graph, but an error occurred while creating an animation that visualizes learning at learning rate.
An error occurs as follows. Please tell me how to solve this problem.

code analysis

'pandas as pd' imported but unused (pyflakes E)

code analysis

redefinition of unused 'plt' from line 10 (pyflakes E)

ValueError: operands could not be broadcast together with shapes (50,50) (2,)

Refer to the Python code inserted below.
`# -- coding: utf-8 --
"""
Spyder Editor
This is a temporary script file.
"""
import numpy as np
import pandas as pd
import matplotlib.pyplot as plt
from matplotlib import cm
from celluloid import Camera
from matplotlib import gridspec
Training set
X = np.array([10,15,20,25,30,35,40,45,50,55,60]) #training set x
Y = np.array([20,25,45,40,55,60,75,90,85,110,120]) #training set  y
Variables
t1 = 0
t0 = 0
Ermean = 0
Erxmean = 0
N=len(X) # Training example
lr = 0.000001 # learning rate
cost = 0 # cost
epoch = 50000
index = np.array([])
w = np.array([])
b = np.array([])
c = np.array([])
Ermean_arr = np.array([])
Erxmean_arr = np.array([])
for i in range (epoch): 50000
import numpy as np
x = [10,15,20,25,30,35,40,45,50,55,60]
y = [20,25,45,40,55,60,75,90,85,110,120]
m = len(y)
X = np.ones(shape=(m, 2))
X[:, 1] = x
def computeCost(x, y, theta):
m = len(y)
h_x = x.dot(theta)
j = np.sum(np.square(h_x - y))(1/(2m))
return j
def gradientDescent(x, y, theta, alpha, iteration):
print('Running Gradient Descent...')
j_hist = []
m = len(y)
for i in range(iteration):
j_hist.append(computeCost(x, y, theta))
h_x = x.dot(theta)
theta = theta - ((alpha/m) *((np.dot(x.T, (h_x-y) ))))
return theta, j_hist
theta = np.zeros((2,1))
iteration = 50000
alpha = 0.000001
theta, cost = gradientDescent(X, y, theta, alpha, iteration)
print ("Epoch:", i+1, " theta1: ", t1, "  theta0: ", t0, "  cost: ", cost, " Ermean: ", Ermean, " Erxmean: ", Erxmean)
print('Theta 1:',theta[1][-1])
print('Theta 0:',theta[0][-1])
print('Cost:',cost[-1])
lr = [0.000001, 0.0005,0.001 ]
t1 = [2.822,0.0412,0.000596]
t0 = [1.079,118.26,119.97]
cost = [4887.59,1.042,0.0002183]
import matplotlib.pyplot as plt
plt.plot(lr, t1)
plt.xlabel('Learning Rate')
plt.ylabel('Theta 1')
plt.show()
plt.plot(lr, t0)
plt.xlabel('Learning Rate')
plt.ylabel('Theta 0')
plt.show()
plt.plot(lr, cost)
plt.xlabel('Learning Rate')
plt.ylabel('Cost')
plt.show()
lr = [0.000001, 0.0005, 0.001]
t1 = [2.822,0.0412,0.000596]
t0 = [1.079,118.26,119.97]
cost = [4887.59,1.042,0.0002183]
fig = plt.figure(figsize=(10,15)) # create figure
gs = gridspec.GridSpec(2, 1, hspace = 0.3, height_ratios=[1, 1.2]) # set height ratios of subplots
label_font_size = 28
tick_label_size= 18
Customize subplots:
ax0=fig.add_subplot(gs[0])
ax0.set_title("Logistic regression curve", fontsize=22)
ax0.tick_params(axis='both', which='major', labelsize=tick_label_size)
ax0.set_xlabel("x", fontsize=label_font_size, labelpad=5)
ax0.set_ylabel("y", fontsize=label_font_size, labelpad=5)
ax0.set_ylim([0,140])
ax0.set_yticks([0,20,40,60,80, 100,120,140])
ax0.set_yticklabels(["0","20","40","60","80", "100","120","140"],
fontsize=tick_label_size)
ax1=fig.add_subplot(gs[1], projection="3d")
ax1.set_title("Cost funtion and trajectory", fontsize=22)
ax1.view_init(elev=20, azim=60)
ax1.set_xlabel("theta1", fontsize=label_font_size, labelpad=25)
ax1.set_ylabel("theta0", fontsize=label_font_size, labelpad=25)
ax1.set_zlabel("costs", fontsize=label_font_size, labelpad=25)
ax1.tick_params(axis='both', which='major', labelsize=tick_label_size, pad=10)
ax1.tick_params(axis='z', which='major', labelsize=tick_label_size)
ax1.set_xticks([0,0.5,1,1.5,2,2.5,3])
ax1.set_xticklabels(["0", "0.5","1.0", "1.5", "2.0","2.5","3.0"], fontsize=tick_label_size)
ax1.set_yticks([-10,-5,0,5,10])
ax1.set_yticklabels(["-10","-5","0","5","10"], fontsize=tick_label_size)
ax1.set_zticks([0,500,1000,1500,2000,2500,3000])
ax1.set_zticklabels(["0","500", "1000","1500","2000","2500","3000"], fontsize=tick_label_size)
a1=np.arange(0,20,1).tolist()
a2=np.arange(20,200,20).tolist()
a3=np.arange(200,2000,200).tolist()
a4=np.arange(2000,50001,2000).tolist()
points_ = a1+a2+a3+a4
camera = Camera(fig)
x = np.linspace(0,70,70)
ws = np.linspace(0,3, 50)
bs = np.linspace(-10,10, 50)
M, B = np.meshgrid(ws, bs)
Z = np.zeros ([len(ws),len(bs)])
for i in range (len(X)):
H_temp = MX[i]+B
E_temp = Y[i]-H_temp
R_sq_temp = E_tempE_temp / 2 / N
Z = Z+R_sq_temp
Graphic_points = np.intersect1d (points_, np.arange(epoch))
for i in Graphic_points:
h = x*w[i]+b[i]

ax0.scatter(X,Y,color='b', marker='x', s=92)
leg=ax0.plot(x,h,
             color='r', label=str(i)) #
ax0.legend(leg,[f'costs: {np.round(c[i],3)}'],
           loc='upper left', fontsize=15)

for j in range(len(Y)):
    x_,y_ = [X[j],X[j]],[float(Y[j]),X[j]*w[i]+b[i]]

    ax0.plot(x_,y_, color='black', linewidth=1.5,
            linestyle='dashed', alpha=0.4)

# Surface plot of costs:
ax1.plot_surface(M, B, Z, rstride=1, cstride=1,
alpha=0.80,cmap=cm.coolwarm)

# Plot trajectory of gradient descent:

ax1.scatter(w[i],b[i],c[i],marker='o', s=12**2, color='black' )
ax1.plot(w[0:i],b[0:i],c[0:i], linestyle="dashed",linewidth=2,
         color="grey") # (dashed) lineplot

ax1.legend(leg,[f'epochs: {i}'],
           loc='upper left', fontsize=18)

camera.snap()

animation = camera.animate(interval = 300, blit=True,# set delay between frames in milliseconds.
repeat = False, repeat_delay = 0)
animation.save('C:\python\LogReg_1.gif') `

Hi @keafas,
It seems that you have an error on your code, so this is not an issue related to Spyder. I will recommend to you to review the shapes of all the variables in your code to be certain that you can do the operations you need. Hope this helps you, and happy spydering!


Setup publicly hosted version

I think the .html file should be available online with the right content-type header for easy reading. GitHub's raw feature only serves it as text/plain. Maybe setup GitHub Pages?
Example
https://cdn.rawgit.com/facebookincubator/DelegatedRecovery/d147414e397a8c456ec512588e4e7361db84f913/draft-hill-delegated-recovery.html

Duplicate of #1
We will be adding better browsable documentation soon, but the Facebook open source organization on GitHub is not currently set up to use GitHub Pages.
The raw.txt version should be pretty usable and has all the same information, and you can always download and view the HTML version locally. Apologies for the inconvenience.


Do we need the accordion block?

Noticed that there's an accordion block developed by you guys. It doesn't appear to work because when I add it I get:

Maybe we can remove it?

@bwaltz We do not (unless you'd like one). This is a super compliant accordion that I typically bundle with every project just for testing purposes. Our design did not facilitate an accordion to Colby, so we can remove this.

@gregoryspragginsjr sweet, let's do that.

@gregoryspragginsjr so sorry about this ☹ . We actually do want this functionality. We could really use an accordion for content clean-up.

@bwaltz No problem. We've added a custom accordion to your block options as of this commit: https://github.com/ColbyCommunications/colby-college-theme/commit/c370ab9442b8f99c3ee16a9f61f318679fef6601
I've also added the necessary fields to staging. This particular component is best used within the page_with-sidebar.twig template. Give it a try and let me know your thoughts. Close when ready.

@gregoryspragginsjr I pulled. Is this the correct field group? https://master-7rqtwti-ouiqvb5juucvu.us-4.platformsh.site/wp/wp-admin/post.php?post=19420&action=edit
It doesn't look like the fields are all there, judging from what's in the twig file.

@bwaltz Hey Brandon, that is indeed the correct group. Something seems to have happened to my fields. Give me a moment to sort them out.

@bwaltz Update: You should be able to see the fields now.

I added an accordion to this page at the bottom: https://master-7rqtwti-ouiqvb5juucvu.us-4.platformsh.site/visitors/explore-maine/
I'm getting a js error:

@bwaltz appears to be an encoding issue. One moment.

@bwaltz when you're ready, you can run composer and give this page another swing. Encoding issues should be addressed.


Allowing user to edit their short links

User should be able to edit the short links they created. This involves:

Add edit & delete button to the Short links that are created by the user  in React
Add GraphQL API to update the mutated short links

Please create a separate issue for each litem listed here and link them back to this one.

I'd like to tackle this :)

@adharmawan Sure!

I'll complete this during the weekend, bit swamped with work this week 😅

@adharmawan any update on this?

https://www.elastic.co/elasticsearch/

Should we close this issue since "Add GraphQL API to update the mutated short links" is done, and the part with React is present as issue #240?

Delete short link API is not done yet.


Logged with gcloud impersonate service account will cause initializeApp error

[READ] Step 1: Are you in the right place?

For issues related to the code in this repository file a Github issue.
If the issue pertains to Cloud Firestore, read the instructions in the "Firestore issue"
template.
For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 2: Describe your environment

Operating System version: Mac
Firebase SDK version:
Firebase Product: Other (auth, database, storage, etc)
Node.js version: 16.14.2
NPM version: 8.5.0

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:

Sign in gcloud with impersonate service account
Run app that will initialise firebase app.

What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
  ● Test suite failed to run

    Refresh token must contain a "client_id" property.

      13 |   static forRoot() {
      14 |     Firebase.initializeApp({
    > 15 |       credential: Firebase.credential.applicationDefault(),
         |                                       ^
      16 |     });
      17 |     return {
      18 |       exports: [FIRE_STORE],

      at FirebaseAppError.FirebaseError [as constructor] (../node_modules/firebase-admin/lib/utils/error.js:44:28)
      at FirebaseAppError.PrefixedFirebaseError [as constructor] (../node_modules/firebase-admin/lib/utils/error.js:90:28)
      at new FirebaseAppError (../node_modules/firebase-admin/lib/utils/error.js:125:28)
      at new RefreshToken (../node_modules/firebase-admin/lib/app/credential-internal.js:281:19)
      at new RefreshTokenCredential (../node_modules/firebase-admin/lib/app/credential-internal.js:239:15)
      at Object.getApplicationDefault (../node_modules/firebase-admin/lib/app/credential-internal.js:321:20)
      at Object.applicationDefault (../node_modules/firebase-admin/lib/app/credential-factory.js:55:54)
      at Function.forRoot (database/database.module.ts:15:39)
      at Object.<anonymous> (app.module.ts:77:20)

Relevant Code:
import { Module } from '@nestjs/common';
import { ConfigModule } from '@nestjs/config';
import Firebase from 'firebase-admin';

import { ConnectionProvider } from './connection.provider';
import { FIRE_STORE } from './database.constants';

export type FireStore = Firebase.firestore.Firestore;
export type WhereFilterOp = Firebase.firestore.WhereFilterOp;

@Module({})
export class DatabaseModule {
  static forRoot() {
    Firebase.initializeApp({
      credential: Firebase.credential.applicationDefault(),
    });
    return {
      exports: [FIRE_STORE],
      global: true,
      imports: [ConfigModule],
      module: DatabaseModule,
      providers: [
        {
          provide: FIRE_STORE,
          useValue: Firebase.firestore(),
        },
      ],
    };
  }

  static forFeature() {
    return {
      exports: [ConnectionProvider],
      imports: [ConfigModule],
      module: DatabaseModule,
      providers: [ConnectionProvider],
    };
  }
}

My application_default_credentials.json (data has been removed)
{
  "delegates": [],
  "service_account_impersonation_url": "https://iamcredentials.googleapis.com/v1/projects/-/serviceAccounts/service-account-here:generateAccessToken",
  "source_credentials": {
    "client_id": "",
    "client_secret": "",
    "refresh_token": "",
    "type": "authorized_user"
  },
  "type": "impersonated_service_account"
}

I have workaround here if anyone facing similar issue.
Workaround
It just simple set GOOGLE_APPLICATION_CREDENTIALS to some where.
And because my app have emulate GCP locally so i just set it to dummy json.

This is fixed in #1862 and now included in the v11.5.0 release.
Thank you for your patience on this! Try out the new feature if you get a chance and let us know what you think.
If you encounter any issues, please open a new issue. Thank you!


e2e testing in CI fails with: Waiting up to 3m0s for all (but 0) nodes to be ready

There are more regularly jobs failing with the following error:
Waiting up to 3m0s for all (but 0) nodes to be ready

It is unclear why this happens. Minikube seems to become unresponsive (or really slow?) and the e2e test (which is a Kubernetes client) can not continue. Logs from Minikube are not available, as the e2e test fails to get details through the Kubernetes API.

After #2058 the jobs seems way more stable. No failures related to the timeout have been reported yet.

This is not completely fixed yet. #2062 hit this problem :disappointed:
https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/k8s-e2e-external-storage-1.20/51/display/redirect


Fixed language in README

This may seem like a minor detail to many men, but language like this in open source guides can be really ostracizing and even offensive to people from other backgrounds. In the interests of inclusivity, can I ask the maintainers to reconsider this PR from @foobarfighter?

Other possible choices:
bedabb1e
be5077ed
b0a710ad
b01dface
cab005e
ca11ab1e
ca55e77e
deadbea7
defec8
f01dab1e
f005ba11
0ddba11
5ca1ab1e
7e1eca57


NotImplementedError: Multiscale images are not implemented yet

Hi, I tried to run the densenet.ipynb notebook, but faced an error when creating ImageTilesDataset: NotImplementedError: Multiscale images are not implemented yet.
The original code is
dataset = ImageTilesDataset(     sdata=merged,     regions_to_images={"cell_circles": "CytAssist_FFPE_Human_Breast_Cancer_full_image"},     tile_dim_in_units=3 * xenium_circles_diameter,     tile_dim_in_pixels=32,     target_coordinate_system="aligned",     transform=my_transform, )
and was modified to:
dataset = ImageTilesDataset(     sdata=merged,     regions_to_images={"cell_circles": "CytAssist_FFPE_Human_Breast_Cancer_full_image"},     tile_dim_in_units=3 * xenium_circles_diameter,     #tile_dim_in_pixels=32,     #target_coordinate_system="aligned",     regions_to_coordinate_systems={"cell_circles": "aligned"},     transform=my_transform, )
with spatialdata version=0.0.16.dev24+ga5336d8 installed from GitHub.
Do you have any suggestions for this issue? Thank you.

Thanks for reporting, we tested the notebook before making a release so it should work on the latest version of spatialdata and we are aware that it currently doesn't work on the main branch. In fact we improved the ImageTilesDataset class with this PR https://github.com/scverse/spatialdata/pull/299 but we haven't updated the notebook yet.
I will do this before the next release, but also I will keep you updated here as soon as it is ready, so that you don't have to wait for the next release.

@duongvtt96, with https://github.com/scverse/spatialdata/pull/439 merged, the new ImageTilesDataset class now work also for multiscale images and multiscale labels. I will update the example notebook for the 0.1.0 release but you can already use the code if you install spatialdata from the main branch.


Design for CAMPD Analysis and Visualization Landing Page

work is slated to begin in 7.1. Need final design by 1/3.

Deprioritized from CAMPD v1.0


Converts a presentation to a wrapped presentation fails for sd-jwt

Hi. During sending from client or verify process on server side method CredentialMapper.toWrappedVerifiablePresentation() fails with error 'VP needs to have at least one verifiable credential at this point' when incoming parameter is encoded jwt.

Could you provide a bit more context? What are you using as RP and which wallet are you using?
To be clear, our low-level libraries and the base SDK module support SD-JWTs at this point. However our Wallet and SDK RP modules do not support it yet. We simply haven't integrated SD-JWTs in the agent yet

I am using Sphereon libraries in issuer/verifier and holder side. Yes, I noticed that only low-level libraries supports SD-JWT. That's why some issues happens during processing OID4VP flow. Any plans to have full support?


Javascript spread operator is not being evaluated in JS set-state expression

The following set-state command is not being expanded correctly;
- set-state: RUN.${{SCOMBO}}.warm ${{=[...${{RUN.${{SCOMBO}}.warm}} , ${{WARM}}]}}
output;
set-state: RUN.config-quickstart.JVM.4.warm =[...${{RUN.${{SCOMBO}}.warm}} , 336384]

This should be fixed with updating yaup to 0.8.4. Please re-open if it isn't working correctly

ty


You should not panic(err)

https://github.com/google/syzkaller/blob/4df543c9abc4c2accf97f4be85b210c772522329/dashboard/app/config.go#L283-L285
Hey dude,
Just a friendly advice. You should not panic(err). You should use a package like this for debugging your errors. Debug your code with :

Clear stack trace
Failing func call highlighting

It’s way more easier then to debug.
Real better than panic-ing (in most case). You can still force exit if you need it.
I would be happy to get your feedbacks.

We should not panic, but that does not look good too.

No offense taken, hope you will find some package that suits you better.

fmt package looks like enough to print user errors.

In that case, you're right it seems pretty legit.


Colorbar does not show properly in dependent plot

I was following this tutorial and tried to plot shap dependent plot. However, the plot I got are missing the color bar as shown below. I have noticed there has been some discussion here, which basically manually set the ratio of the colorbar. plt.gcf().axes[-1].set_box_aspect(1000). I tried the same thing but for dependent plot plt.gcf().axes returns none. I wonder anyone can point me how to get the handle of the color bar.
Thank you in advanced
I am using Shap 0.40 and Matplotlib 3.5.1.

That's because shap.summary_plot() calls plt.show() by default. If you pass show=False to shap.summary_plot(), you shall get the current figure.

@flyforward2016 This one had me stumped for a little while too, the same fix as is discussed in the link you copied does work (here), but you need to change which <AxesSubplot:> you're adjusting. In the case of a shap.plots.scatter_plot, to adjust the colorbar you need to adjust the index of the third subplot i.e. plt.gcf().axes[-2].set_aspect('auto').
You can check which axes has the colorbar by running:
shap.plots.scatter(shap_values[:,feature], show=False, color=shap_values)
f, a = plt.gcf(), plt.gca()
print(f.axes)

The code below is what I did to get the colorbar to display correctly:
shap.plots.scatter(shap_values[:,feature], show=False, color=shap_values, cmap='viridis')
plt.gcf().axes[-2].set_aspect('auto')
plt.gcf().axes[-2].set_box_aspect(20)

Thanks @cbur24 and @FlamingoZh
I combine both of your suggestion as below.
shap.dependence_plot(0, shap_values, X, show = False) plt.gcf().axes[-1].set_aspect('auto') plt.gcf().axes[-1].set_box_aspect(30)

The reason the 2nd and 3rd line does not change the color bar is as @FlamingoZh pointed by default plt.show() is called and any changes made cannot be reflected on the plot. Passing show = False in will be able to make the layout adjustment.

Why we axes[-1] can change the color bar layout is answered by @cbur24 comment, that we need to select the right axes to change the color bar.
f_1, a_1 = plt.gcf(), plt.gca() print(f_1.axes)
returns
[<AxesSubplot:xlabel='Age', ylabel='SHAP value for\nAge'>, <AxesSubplot:label='<colorbar>', ylabel='Capital Gain'>]
In that sense either axex[-1] or axes[1] will do the work.


python3Packages.sendgrid: 6.7.1 -> 6.8.0

Motivation for this change
Update to latest upstream release 6.8.0
Change log: https://github.com/sendgrid/sendgrid-python/releases/tag/6.8.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 133551 run on x86_64-linux 1

2 packages built:

python38Packages.sendgrid
python39Packages.sendgrid


tflite's  output is far from tf's

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): N
OS Platform and Distribution: Linux 4.16.13-2-ARCH
TensorFlow installed from (source or binary): source
TensorFlow version (use command below):'v1.8.0-3238-g52bf2fe0f6' 1.9.0-rc0
Python version:  3.6.5
Bazel version (if compiling from source): v0.12.0
GCC/Compiler version (if compiling from source): gcc-7.1
CUDA/cuDNN version: cuda-9.2,cuDNN-7.1
GPU model and memory: 16G
Exact command to reproduce:

I trained my model on mobilenet_v2-ssd with codes in models/research/object_detection/ ,export and convert the model from node Preprocessor/sub to concat,concat_1 for the reason that tflite doesn't support some ops.
With the same input image and same preprocessing I print out the values of concat_ whose shape is [1,1917,2] (there is only one ground truth class in my dataset,so the last dimension is 1+1 == 2)
the tf's output is [[[8.46199608 -9.81417]...,but the tflite's is [[[17.357746 -17.360010]...
The only different obviously I can find is the training network used  FusedBatchNorm
but in the exported tflite model the FusedBatchNorm was replaced by {'fused_activation_function': 'NONE'} | ADD (opcode=0)
Does this differ care? Anyone help?

@aselle -- mind taking a look?

Nagging Assignees @aselle, @achowdhery: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

The instructions for support are coming soon. Thanks for your patience

Here is the blog post for end-to-end object detection training and deployment with Tensorflow Lite:
https://medium.com/tensorflow/training-and-serving-a-realtime-mobile-object-detector-in-30-minutes-with-cloud-tpus-b78971cf1193

I have noticed that you just updated  an export_tflite_ssd_graph.py and I'm trying on it.Thanks for your work.

I found that quantized TFLite model is different from non-quantized TFLite model.

ok, got it. instead of RELU6 quantized model uses  Requantize_32to8 - where I can explicitly set new min/max


fix adding warehouses to products

I want to merge this change because it fixes user being unable to add warehouses to products with no variants.
SALEOR-1463

PR intended to be tested with API branch:
Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Translated strings are extracted.
[ ] Number of API calls is optimized.
[ ] The changes are tested.
[ ] Data-test are added for new elements.
[ ] Type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

Task linked: SALEOR-1463 [Products] Cannot add warehouses to products


Use 'centos:stream8' as a base image

If I'm not mistaken, 'centos:8' went EOL in Decemeber, 2021.
Signed-off-by: Hunor Csomortáni<EMAIL_ADDRESS>

One more commit landed here: to update the API version used for the cron job.

recheck

Long story short: updating the API version of the CronJob object to the one used in 4.8 OpenShift renders it unusable with 3.11 clients. oc-cluster-up in Zuul runs 3.11. We need to come up with a different way of testing in more recent OpenShift versions.


fix(deps): update terraform helm to latest for the deployable architecture solution

This PR contains the following updates:

Package
Type
Update
Change

helm (source)
required_provider
patch
2.16.0 -> 2.16.1

Release Notes

hashicorp/terraform-provider-helm (helm)
v2.16.1
Compare Source
BUG FIXES:

helm_release: Fix nil pointer deref panic on destroy when helm release is not found [GH-1501]

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.20.7 :tada:
The release is available on:

GitHub release
v1.20.7

Your semantic-release bot :package::rocket:


Return null/undefined from find() when the component isn't found

Is there a reason that FlowComponents.find() throws an exception when a component is not found?
I have an existing project with modal dialog support that retrieves the template name to display from a session variable. I would like to add direct component support by doing something like:
{{#if isComponentModal}}
  {{> render component=template}}
{{else}}
  {{> template}}
{{/if}}

ModalDialog.helpers.isComponentModal = function() {
  return FlowComponents.find(App.activeModalName());
}

ModalDialog.helpers.template = function() {
  return App.activeModalName();
}

However, the find call is throw an error when the component is not found.  Obviously, I can just wrap the find call with a try/catch block, but it seems strange to have find() throw an error in the first place.

Here's an example of what I'm talking about. I don't want the caller of openModal to know whether the modal is a component or template. Since the ComponentsStore is hidden, the only way to determine whether I'm dealing with a component is through find.
http://meteorpad.com/pad/MDHM9w4uTiyms5MED/Modal Dialog Example


How do I refresh the token with the AutorizationCodeAuth and why is it not safe?

Hi,
I am making a desktop app and would like to know a good way to refresh the access token. Right now I run the auth method every hour, but this causes the browers to pop up which can be rather annoying.
Could someone give me an example on how to refresh the token? I tried  auth.RefreshToken(spotify.AccessToken, "myClientSecret");
which does not work.
And to my second question, the example code says "NEVER DO THIS! You would need to provide the ClientSecret. You would need to do it e.g via a PHP-Script."
Does this apply for desktop apps aswell? How could someone get a hold of my ClientSecret and how do I protect it? Would it still be a problem if I am the only one using the program?

Hi @Gruhlum ,
Sorry for the late response.
You will need to use the token.RefreshToken token instead of the actual access code. You get this refresh token when you exchange with auth.ExchangeAuthCode(response.Code, "XXXXXXXXXXX");.
If you're the only one using it, it's no problem. As soon as you send your program to other people, they can decompile it and view your client-secret. And with this client-secret they can make calls to the API through your account, you wouldn't want that, do you? 😛


Add the user who submitted feedback to feedback form

Summary of Changes
We'd like to know who submitted ratings or feedback, so that we can follow up with them later. This simple PR adds the user=user_id to the dict() in the e-mail.
Tests
Added some tests for if the AUTH_USER_METHOD is not specified, to ensure the correct user is populated in the content.
Documentation
Added some explanation of the tests for this piece of code.
CheckList
Make sure you have checked all steps below to ensure a timely review.

[X] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[X] PR includes a summary of changes, including screenshots of any UI changes.
[X] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[X] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[X] PR passes all tests documented in the developer guide
[X] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

Codecov Report

Merging #240 into master will decrease coverage by 1.89%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #240     +/-   ##
=========================================
- Coverage   70.18%   68.28%   -1.9%
=========================================
  Files         125      101     -24
  Lines        3250     2198   -1052
  Branches      401      314     -87
=========================================
- Hits         2281     1501    -780
+ Misses        937      692    -245
+ Partials       32        5     -27

Impacted Files
Coverage Δ

amundsen_application/api/metadata/v0.py

amundsen_application/log/action_log_callback.py

amundsen_application/api/__init__.py

amundsen_application/api/utils/request_utils.py

...n/base/examples/example_superset_preview_client.py

amundsen_application/base/base_preview_client.py

...ndsen_application/base/base_announcement_client.py

amundsen_application/wsgi.py

amundsen_application/log/action_log_model.py

amundsen_application/api/search/v0.py

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37972d...bc442ea. Read the comment docs.

@worldwise001 let us know if the comment I left ended up working for you, and if you'd still like to contribute this change.


Swift 4 support

Any plans to update the library to support Swift 4?

Please look at swift 4 branch.

I have my own pods which use SwipeCellKit as dependency, and since you can't ":branch" on the .podspec file, theres no way to access the swift 4 branch...
Is there an ETA to merge this branch into master?

In the next few days.
Sent with GitHawk


Proxy settings

Hi!
How can i configurate proxy setting for development server? I need all /api.... network calls will redirect to other site api. I try
config.devServer = {
    ...(config.devServer || {}),
    proxy: {
      '/api': {
        target: 'http://__api_site_address__',
      },
    },
  };
  return config;

But seems webpack ignore it

@dawnmist any thoughts on this?

This looks like you are trying to set the dev server configuration directly inside the normal webpack config. That won't work for create-react-app, as they use a completely different script/configuration for the dev server.
If all you want to do is set up the proxy information, you can do that without having to use react-app-rewired to do it by adding a proxy section to your package.json file. Take a look at the create-react-app documentation here: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#proxying-api-requests-in-development and here: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#configuring-the-proxy-manually
If you do still need to modify the dev server configuration, you need to use the alternative module.exports object version for settings in the config-overrides.js file instead of the single function version https://github.com/timarney/react-app-rewired/blob/master/packages/react-app-rewired/config-overrides.js and provide the devServer section (if you are also modifying the normal config make sure you copy those changes to the webpack function too). The inner function in the devServer section is called as a function by the dev server's start script, so it needs to match the example in that file or your changes to the dev server configuration will not be applied.

Your first link is enough for me, thanks!
Also thanks for detailed answer this is useful!

Thanks for jumping in @dawnmist I appreciate it.


Why sui dont working in cordova?

Hi guys!
I used vue-cli-plugin-cordova to generate the application.
I installed Semantic-UI-Vue in the project.
main.js looks like this
import Vue from 'vue'
import App from './App.vue'
import SuiVue from 'semantic-ui-vue';

Vue.config.production Type = false
Vue.use(SuiVue)

new Vue({
  render: h => h(App),
}).$mount('#app')

After restarting the application in the browser, the test code in the components did not work.
There are no errors in the developer tool and console
What could be the problem?

First issue I see is that:
Vue.config.production Type = false
Should be:
Vue.config.productionTip = false

Closing as the description doesn't provide enough information. Please, reopen it with more detail if you are still having the problem.