[Bug]: Unable to push from iOS app

Describe the bug
The repo is cloned from remote, authentication set with personal access token (classic), the app is working, all fine.
After couple of months of use there is an error appearing when I try to push changes to remote.
Changes are added, commited, but when I try to push, get the following error:
HttpError: HTTP Error: 500 500
Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)
HttpError: HTTP Error: 500 500

Steps to reproduce
Make changes or create new file, add, commit, push
Expected Behavior
Changes are successfully pushed to remote
Addition context
The problem can be solved only by deleting the local repo from the device and cloning it from remote all over again. However I expect that is not should be happen every one or two months.
Operating system
iOS
Installation Method
None
Plugin version
2.19.1

I can't do much here, because I don't know what the issue is. The 500 error code means that an error happened on the server you are pushing to. Are you using a custom git hosting server? Either way, I don't know what exactly is wrong and can't reproduce.

In case you're still having this problem, or anyone else comes along with the same problem, it could be your version of IOS. I would get this error consistently a couple hours after re-cloning my vault. Once I updated to the latest IOS version the problem vanished.


this is my code my function is not working to connect wallet button is displaying but signature is not coming plz help someone

import React from "react";
import { useState } from "react";
const TronWeb = require("tronweb");
export default Body;
function Body() {
const [lpLogged, setlpLogged] = useState(true);
async function getTronWeb() {
if (window.tronWeb && window.tronWeb.defaultAddress.base58) {
return window.tronWeb;
}
return null;
}
let curweb = getTronWeb();
async function initWindow() {
if (curweb == null) {
setlpLogged((lpLogged) => false);
alert.show("We were unable to find any suitble providder.");
} else {
setlpLogged((lpLogged) => true);
}
}
return (

 link {lpLogged ? "true" : "false"}

);
}

Please refer to this example.
https://github.com/tronprotocol/tronweb/blob/master/demo/tron-dapp-react-demo/src/stores/network.js#L174

where i am wrong in my code @llwslc

Please change to this.
let curweb = await getTronWeb();

oh


Implements call

Implements call as discussed in #153.
Still open to discussion (naming?), but here's a proposal and some docs.

I hate to merge my own PR, so any other thoughts/concerns before merging this?

I'm happy with it.


concurrent publish occur:  "Exception (504) Reason: "channel/connection is not open"

go version:
go1.14.1 windows/amd64
rabbitmq version:
RabbitMQ 3.8.4 Erlang 23.0
my code is:
package main

import (
	"fmt"

	"github.com/streadway/amqp"
)

var (
	conn = &amqp.Connection{}
	ch   = &amqp.Channel{}
)

func InitMQ() {
	var err error
	conn, err = amqp.Dial("amqp://guest:guest@localhost:5672/")
	if err != nil {
		panic(err)
	}
	ch, err = conn.Channel()
	if err != nil {
		panic(err)
	}
}

func main() {
	InitMQ()
	for i := 0; i < 100; i++ {
		go func(i int) {
			err := PublishNews([]byte{byte(i)})
			if err != nil {
				fmt.Println(err)
			}
		}(i)
	}
	select {}
}

func PublishNews(data []byte) (err error) {
	err = ch.ExchangeDeclare(
		"exchange1",
		"fanout",
		true,
		false,
		false,
		false,
		nil,
	)
	if err != nil {
		return fmt.Errorf("ExchangeDeclare: %s", err)
	}
	q, err := ch.QueueDeclare(
		"queue",
		true,
		false,
		false,
		false,
		nil,
	)
	if err != nil {
		return fmt.Errorf("QueueDeclare: %s", err)
	}
	err = ch.QueueBind(
		q.Name,
		"",
		"exchange1",
		false,
		nil,
	)
	if err != nil {
		return fmt.Errorf("QueueBind: %s", err)
	}
	err = ch.Publish(
		"exchange1",
		"",
		false,
		false,
		amqp.Publishing{
			ContentType:  "text/plain",
			Body:         data,
			DeliveryMode: 2, // durable
		})
	if err != nil {
		return fmt.Errorf("Publish:  %s", err)
	}
	return nil
}

the error print is :
Publish:  Exception (504) Reason: "channel/connection is not open"
Publish:  Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
Publish:  Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueBind: write tcp [::1]:64696->[::1]:5672: use of closed network connection
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: write tcp [::1]:64696->[::1]:5672: use of closed network connection
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: write tcp [::1]:64696->[::1]:5672: use of closed network connection
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: write tcp [::1]:64696->[::1]:5672: use of closed network connection
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: write tcp [::1]:64696->[::1]:5672: use of closed network connection
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: write tcp [::1]:64696->[::1]:5672: use of closed network connection
QueueDeclare: Exception (504) Reason: "channel/connection is not open"
QueueBind: Exception (504) Reason: "channel/connection is not open"
QueueBind: write tcp [::1]:64696->[::1]:5672: use of closed network connection
QueueBind: write tcp [::1]:64696->[::1]:5672: use of closed network connection
QueueBind: write tcp [::1]:64696->[::1]:5672: use of closed network connection
QueueBind: write tcp [::1]:64696->[::1]:5672: use of closed network connection
QueueDeclare: Exception (505) Reason: "UNEXPECTED_FRAME - expected content header for class 60, got non content header frame instead"
QueueBind: write tcp [::1]:64696->[::1]:5672: use of closed network connection

the rabbitmq log is :
2020-08-20 15:38:44.204 [info] <0.11426.16> accepting AMQP connection <0.11426.16> ([::1]:64696 -> [::1]:5672)
2020-08-20 15:38:44.207 [info] <0.11426.16> connection <0.11426.16> ([::1]:64696 -> [::1]:5672): user 'guest' authenticated and granted access to vhost '/'
2020-08-20 15:38:44.211 [error] <0.11426.16> Error on AMQP connection <0.11426.16> ([::1]:64696 -> [::1]:5672, vhost: '/', user: 'guest', state: running), channel 1:
 operation basic.publish caused a connection exception unexpected_frame: "expected content header for class 60, got non content header frame instead"
2020-08-20 15:38:44.213 [info] <0.11426.16> closing AMQP connection <0.11426.16> ([::1]:64696 -> [::1]:5672, vhost: '/', user: 'guest')
2020-08-20 15:39:39.725 [error] <0.731.0> Could not find handle.exe, please install from sysinternals

Even though declaring exchanges, queues and binding them should be idempotent I think you're setting yourself up for trouble by performing these commands in 100 go routines at the same time. It could happen just so that you send multiple declarations of the same exchange f.ex. at the same time which I think could lead to issues on the server side.
I tried your code as is and it works most of the time but sometimes I see the same errors as you do. When I got errors it was resolved by just restarting the RabbitMQ server.
However, by moving the declaration of the exchange, the queue and binding them to InitMQ() I can no longer reproduce this issue (newly started or already running RabbitMQ server)

MRE
docker run --rm -it -p 5672:5672 rabbitmq:3
package main

import (
	"fmt"
	"sync"

	"github.com/streadway/amqp"
)

func InitMQ() *amqp.Channel {
	conn, err := amqp.Dial("amqp://guest:guest@localhost:5672/")
	if err != nil {
		panic(err)
	}

	ch, err := conn.Channel()
	if err != nil {
		panic(err)
	}

	err = ch.ExchangeDeclare("exchange1", "fanout", true, false, false, false, nil)
	if err != nil {
		panic(err)
	}

	q, err := ch.QueueDeclare("queue", true, false, false, false, nil)
	if err != nil {
		panic(err)
	}

	err = ch.QueueBind(q.Name, "", "exchange1", false, nil)
	if err != nil {
		panic(err)
	}

	return ch
}

func main() {
	ch := InitMQ()

	wg := sync.WaitGroup{}

	for i := 1; i <= 100; i++ {
		fmt.Printf("spawning go routine %d/%d\n", i, 100)
		wg.Add(1)

		go func(i int) {
			err := PublishNews(ch, []byte{byte(i)})
			if err != nil {
				fmt.Println(err)
			}

			wg.Done()
		}(i)
	}

	wg.Wait()
}

func PublishNews(ch *amqp.Channel, data []byte) (err error) {
	return ch.Publish(
		"exchange1", "", false, false,
		amqp.Publishing{
			ContentType:  "text/plain",
			Body:         data,
			DeliveryMode: 2, // durable
		})
}

@bombsimon thx for your response

@wxj95 The problem that I see here is that you are sharing the same publishing channel between the goroutines. This is wrong and it might lead to incorrect frame interleaving as @michaelklishin mentioned here https://groups.google.com/g/rabbitmq-users/c/u4AZ2t9enu0/m/WkDIU9ENAgAJ
Please check this issue as well for more info https://github.com/streadway/amqp/issues/283
The solution is to create a new channel in each goroutine.

@wxj95 The problem that I see here is that you are sharing the same publishing channel between the goroutines. This is wrong and it might lead to incorrect frame interleaving as @michaelklishin mentioned here https://groups.google.com/g/rabbitmq-users/c/u4AZ2t9enu0/m/WkDIU9ENAgAJ
Please check this issue as well for more info https://github.com/streadway/amqp/issues/283
The solution is to create a new channel in each goroutine.


Update default_ssl_context documentation with solution to self-signed certificate in certificate chain issue

Hello 👋
I have been investigating an [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate in certificate chain issue (see https://github.com/ESMValGroup/ESMValCore/issues/2012) that others have also reported via Stack Overflow.
I have a solution, and I was wondering whether it would be possible to update the GeoPy documentation with this information, to help others with this issue?
Our web proxy at work is configured to use self-signed certificates, which (I believe) would be correctly identified if requests.Session().trust_env was set to True. However, the following (written similarly to other examples in the documentation; scroll down to default_ssl_context) also solves the problem:
import ssl
import geopy.geocoders
ctx = ssl.create_default_context()
geopy.geocoders.options.default_ssl_context = ctx

then run:
from geopy.geocoders import Nominatim
geolocator = Nominatim(user_agent="test_ehogan")
geolocation = geolocator.geocode("Amsterdam")

Would it be possible to also update the "Pass None to use the interpreter’s defaults (that is to use the system’s trusted CA certificates)." sentence in the documentation for default_ssl_context, as this default setting doesn't work in the above case.
If it is agreed that this is an acceptable task I would be happy to have a go at creating a PR; please let me know! 😊

Hello, thank you for such a detailed explanation!

which (I believe) would be correctly identified if requests.Session().trust_env was set to True.

I think I have an explanation for what might be happening here. The trust_env setting also causes requests to ignore the REQUESTS_CA_BUNDLE environment variable, which I assume is set in your environment. In this case, requests uses the bundled CA set from certifi. However, in your situation, this bundled CA set doesn't include the proxy's CA that's present in your system store. This is likely the reason why passing the plain ssl.create_default_context() must be helping.
In this situation, I believe, the best approach is to make requests use the system's CA store by default, rather than the certifi's bundle, similarly to the default urllib-based adapter. This would (hopefully) make the Pass None to use the interpreter’s defaults (that is to use the system’s trusted CA certificates) statement correct for your scenario as well.


[AIRFLOW-52] Warn about overwriting tasks in a DAG

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

https://issues.apache.org/jira/browse/AIRFLOW-52

Part 2 of Airflow-52, cc @aoen

LGTM

Merged in https://github.com/apache/incubator-airflow/commit/385add2bf3eb7cd6103cfec0e5516234eeb72443


rsc stop: assert that things are shut down + attempt again, if not

We're currently signal SIGTERM to all processes we want to shut down:
https://github.com/UCSF-CBI/rstudio-server-controller/blob/e1416dcb6b2ebf8a837eb50141dd20cd875463b3/bin/rsc#L1369-L1396
but we don't really make sure the processes are truly terminated afterward.  It could be that they keep running, e.g. stuck or overwhelmed processes.
Actions

[x] Use already existing terminate_rsession(), terminate_rserver(), terminate_rserver_monitor(), and terminate_ssh_revtunnel().
[x] Assert that processes are terminated afterward.  If not, produce a warning, error, or escalate to SIGKILL or SIGQUIT?
[x] Give processes some time to terminate, before checking.

Now tries multiple times with TERM, sleep one second before checking, and if still running, sleep two seconds and repeat.  After four failed TERMs, do one last with KILL.


A question regarding the testing on BTCV

Hi author,
I was a little bit confusing about the test configuration for BTCV. I found in your code when you load the test data, you used the following augmentation/transforms:
    val_transform = transforms.Compose(
        [
            transforms.LoadImaged(keys=["image", "label"]),
            transforms.EnsureChannelFirstd(keys=["image", "label"]),
            transforms.Orientationd(keys=["image", "label"], axcodes="RAS"),
            transforms.Spacingd(
                keys=["image", "label"], pixdim=(args.space_x, args.space_y, args.space_z), mode=("bilinear", "nearest")
            ),
            transforms.ScaleIntensityRanged(
                keys=["image"], a_min=args.a_min, a_max=args.a_max, b_min=args.b_min, b_max=args.b_max, clip=True
            ),
            transforms.CropForegroundd(keys=["image", "label"], source_key="image"),
            # transforms.ToTensord(keys=["image", "label"]),
        ]
    )

When I check the code of SwinUNETR, their transform seems different:
    test_transform = transforms.Compose(
        [
            transforms.LoadImaged(keys=["image", "label"]),
            transforms.AddChanneld(keys=["image", "label"]),
            # transforms.Orientationd(keys=["image"], axcodes="RAS"),
            transforms.Spacingd(keys="image", pixdim=(args.space_x, args.space_y, args.space_z), mode="bilinear"),
            transforms.ScaleIntensityRanged(
                keys=["image"], a_min=args.a_min, a_max=args.a_max, b_min=args.b_min, b_max=args.b_max, clip=True
            ),
            transforms.ToTensord(keys=["image", "label"]),
        ]
    )

I found it may induce an unignorable performance difference. I was wondering if "transforms.Orientationd(keys=["image", "label"], axcodes="RAS")" or "transforms.CropForegroundd(keys=["image", "label"], source_key="image")" can be used for test data as the label information should be unknown. I would appreciate it if you could help me with this.
Thanks!

Hi, many thanks for your attention to our work.
It is a pity that the BTCV test leaderboard is no longer updating now. So in this repo we only provide the codes for validation. The test_transform is actually "val_transform". If you want to conduct test on some other datasets, you only need to remove the key "label".

Thanks for your reply. I was wondering in your paper, are you using val_transform (same as you did) or test_transform for the comparison methods. Thanks.

Hi, sorry, I am a little confused with your question. Val_transform is used for val set and test transform is used for test sets (e.g., AMOS with test learderboard). Does this response align with what you were looking for?

Dear researcher, our work is now available at Large-Scale-Medical, if you are still interested in this topic. Thank you very much for your attention to our work, it does encourage me a lot!


layout capture-backend

Hi, do we capture the layout on the serverside code. Is there a call to serialize the changes from the user.
Do you support drag/drop edits on the nodes..
thanks

no :-(


coco inference  only use cpu

when I use coco datasets , whatever eval or demo only use cpu, although model to gpu,but not use it to run model.
(0001/0005) 000342.jpg: objects 02 | load 009ms | inference 4198ms | FPS 0
(0002/0005) 000542.jpg: objects 01 | load 009ms | inference 073ms | FPS 14
(0003/0005) 003123.jpg: objects 04 | load 007ms | inference 34089ms | FPS 0
(0004/0005) 004101.jpg: objects 01 | load 009ms | inference 6579ms | FPS 0
(0005/0005) 008591.jpg: objects 07 | load 008ms | inference 12452ms | FPS 0
cpu :
12427 zyan      20   0   73.6g   2.0g 299200 R 100.3  0.8   0:53.29 python
gpu :
23%   26C    P2    58W / 250W |    817MiB / 12196MiB |      0%      Default
thanks a lot

and voc is okay!

Do you compile NMS code? Python version is very very slow.
cd ext
python build.py build_ext develop

thanks for replying!
Yes, I have done it ,  look the voc, it works well !

I mean, the voc is normal but the coco is wrong,and The above picture proves that I have compiled NMS

It weird that voc works well but coco doesn't. Can you provide your CMD of coco eval?

(pytorch) [@nmyjs_8_89 ssd-pytorch]$ python -m torch.distributed.launch --nproc_per_node=$NGPUS test.py --config-file configs/vgg_ssd300_coco_trainval35k.yaml
2019-07-12 17:18:39,459 SSD INFO: Using 8 GPUs
2019-07-12 17:18:39,459 SSD INFO: Namespace(ckpt=None, config_file='configs/vgg_ssd300_coco_trainval35k.yaml', local_rank=0, opts=[], output_dir='eval_results')
2019-07-12 17:18:39,459 SSD INFO: Loaded configuration file configs/vgg_ssd300_coco_trainval35k.yaml
2019-07-12 17:18:39,459 SSD INFO:
MODEL:
NUM_CLASSES: 81
PRIORS:
FEATURE_MAPS: [38, 19, 10, 5, 3, 1]
STRIDES: [8, 16, 32, 64, 100, 300]
MIN_SIZES: [21, 45, 99, 153, 207, 261]
MAX_SIZES: [45, 99, 153, 207, 261, 315]
ASPECT_RATIOS: [[2], [2, 3], [2, 3], [2, 3], [2], [2]]
BOXES_PER_LOCATION: [4, 6, 6, 6, 4, 4]
INPUT:
IMAGE_SIZE: 300
DATASETS:
TRAIN: ("coco_2014_train", "coco_2014_valminusminival")
TEST: ("coco_2014_minival", )
SOLVER:
MAX_ITER: 600000
LR_STEPS: [420000, 540000]
GAMMA: 0.1
BATCH_SIZE: 32
LR: 0.000625
OUTPUT_DIR: 'outputs/vgg_ssd300_coco_trainval35k'
2019-07-12 17:18:39,460 SSD INFO: Running with config:
DATASETS:
TEST: ('coco_2014_minival',)
TRAIN: ('coco_2014_train', 'coco_2014_valminusminival')
DATA_LOADER:
NUM_WORKERS: 8
PIN_MEMORY: True
INPUT:
IMAGE_SIZE: 300
PIXEL_MEAN: [123, 117, 104]
MODEL:
BACKBONE:
NAME: vgg
OUT_CHANNELS: (512, 1024, 512, 256, 256, 256)
PRETRAINED: True
BOX_PREDICTOR: SSDBoxPredictor
CENTER_VARIANCE: 0.1
DEVICE: cuda
META_ARCHITECTURE: SSDDetector
NEG_POS_RATIO: 3
NUM_CLASSES: 81
PRIORS:
ASPECT_RATIOS: [[2], [2, 3], [2, 3], [2, 3], [2], [2]]
BOXES_PER_LOCATION: [4, 6, 6, 6, 4, 4]
CLIP: True
FEATURE_MAPS: [38, 19, 10, 5, 3, 1]
MAX_SIZES: [45, 99, 153, 207, 261, 315]
MIN_SIZES: [21, 45, 99, 153, 207, 261]
STRIDES: [8, 16, 32, 64, 100, 300]
SIZE_VARIANCE: 0.2
THRESHOLD: 0.5
OUTPUT_DIR: outputs/vgg_ssd300_coco_trainval35k
SOLVER:
BATCH_SIZE: 32
GAMMA: 0.1
LR: 0.000625
LR_STEPS: [420000, 540000]
MAX_ITER: 600000
MOMENTUM: 0.9
WARMUP_FACTOR: 0.3333333333333333
WARMUP_ITERS: 500
WEIGHT_DECAY: 0.0005
TEST:
BATCH_SIZE: 10
CONFIDENCE_THRESHOLD: 0.01
MAX_PER_CLASS: -1
MAX_PER_IMAGE: 100
NMS_THRESHOLD: 0.45
2019-07-12 17:18:40,429 SSD.inference INFO: Loading checkpoint from outputs/vgg_ssd300_coco_trainval35k/model_final.pth
loading annotations into memory...
loading annotations into memory...
loading annotations into memory...
loading annotations into memory...
loading annotations into memory...
loading annotations into memory...
loading annotations into memory...
loading annotations into memory...
Done (t=0.63s)
creating index...
Done (t=0.63s)
creating index...
index created!
0%|                                                                                | 0/63 [00:00<?, ?it/s]Done (t=0.67s)
creating index...
index created!
0%|                                                                                | 0/63 [00:00<?, ?it/s]Done (t=0.66s)
creating index...
Done (t=0.64s)
creating index...
Done (t=0.64s)
creating index...
Done (t=0.65s)
creating index...
index created!
0%|                                                                                | 0/63 [00:00<?, ?it/s]Done (t=0.67s)
creating index...
index created!
2019-07-12 17:18:41,757 SSD.inference INFO: Evaluating coco_2014_minival dataset(5000 images):
0%|                                                                                | 0/63 [00:00<?, ?it/s]index created!
index created!
0%|                                                                                | 0/63 [00:00<?, ?it/s]index created!
0%|                                                                                | 0/63 [00:00<?, ?it/s]index created!
0%|                                                                                | 0/63 [00:00<?, ?it/s]

What's your torchvision version? I add support torchvision nms in bc522282cf68c5c8333c82325f7e6bf249f3c0b4, you can uninstall torch_extension if your torchvision >= 0.3.0.

torchvision =0.3.0 ,I have already uninstall torch-extension , but  it still too slow , maybe not nms's problem, just use wrong device to run model. Did you use this version? run demo.py for coco ?
could you provide the log of demo.py for coco? I want to know if this is just my own problem?
thanks

Loaded weights from outputs/vgg_ssd300_coco_trainval35k/model_final.pth
(0001/0006) 004545.jpg: objects 04 | load 011ms | inference 112ms | FPS 9
(0002/0006) 004101.jpg: objects 02 | load 011ms | inference 149ms | FPS 7
(0003/0006) 003123.jpg: objects 10 | load 029ms | inference 121ms | FPS 8
(0004/0006) 000342.jpg: objects 02 | load 016ms | inference 047ms | FPS 21
(0005/0006) 008591.jpg: objects 08 | load 017ms | inference 084ms | FPS 12
(0006/0006) 000542.jpg: objects 01 | load 010ms | inference 052ms | FPS 19

okay , It seems that only I have this problem, I will read the code carefully . thank you

https://github.com/lufficc/SSD/issues/31#issuecomment-478313423 it works


Add margin between radio buttons/checkboxes and their labels/strings

Bugzilla Bug 1716806
This PR adds margin between radio buttons/checkboxes and their labels/strings.
Links to images that illustrate the changes can be found below:

Example 1: Before | After
Example 2: Before | After
Example 3: Before | After
Example 4: Before | After

Links to the original PDFs can be found below:

PDF 1
PDF 2
PDF 3
PDF 4

I don't have extensive experience creating PRs, so I'd be happy to receive any feedback you might have.

/botio-linux preview

/botio test

Could you squash the commits into one (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits)? Once that's done we can trigger a new round of tests. If the change is visible in existing test cases we don't have to do anything, but otherwise we'll need to add a (linked or in-repo PDF file) test case to avoid regressions; we have guidelines on how to do that but we'll get to that if it actually turns out to be necessary.

I squashed the two commits into one. Thanks for your help and patience on this.
I will keep an eye out for the test results.

Fortunately this change is clearly visible in the existing test cases, so we don't have to add new tests, but I do see some unexpected movement. For example in firefox-xfa_bug1718741-page1 (any quite a few others) where the input fields are all moved/shortened now. I assume that's not expected, or is that how e.g. Adobe Reader also renders the PDF?

The requirements outlined in Bugzilla Bug 1716806 specify the need to add spacing between radio buttons (not regular buttons), checkboxes, and text inputs and their associated captions.
This pull request (PR) addresses the bug by targeting the captions associated with any radio button, checkbox, or text input element that is a direct descendant of an element with either the .xfaRight or .xfaLeft class. Margins are then appropriately applied to the left or right of the caption div element.
Regarding PDF firefox-xfa_issue14071:

On Page 1:

A "Date of Birth" caption associated with a text input element has a right margin applied.

On Page 2:

Several radio button captions have left-margin applied.
Several text input captions have right-margin applied.

Although the margin here may not be technically necessary, it is required for other forms, such as "Example 3: Before" (also linked in my initial comment above). Without altering the HTML structure, fixing Example 3 without affecting PDFs such as firefox-xfa_issue14071 is not feasible (at least, I couldn't think of a solution).

On Pages 4 and 5:

Three instances of radio button captions have left-margin applied.

I did attempt to approach the implementation of my CSS styles differently, but couldn't come up with a superior solution.
If these changes are still deemed unacceptable, I will close the PR.

Why do you want to close this PR ?
We just want to apply a margin with radio button/checkboxes as your PR title claims it, not with text fields.
I didn't check anything, but I'd say it's possible to write just few lines of CSS in using has selector.

I gave the styles another go. The updated styles only affect the margin of checkboxes and radio buttons.

/botio test

As @timvandermeij pointed it, the xfaLeft and xfaRight are symmetric, so making a change in one property should be done in the other: it'd be very strange to have an asymmetry here.
Instead of moving the caption, I think the right way to do (which needs to be verified with the tests) is add some left/right margin to the input under xfaLeft /xfaRight.

I've previously tried applying margins to the checkbox and radio button inputs (more specifically the .xfaRadio and .xfaCheckbox classes, but these modifications did not yield the desired outcome.
Despite a couple of attempts, I've been unable to resolve this issue satisfactorily. @calixteman and @timvandermeij, thank you for help and patience, but I believe this bug exceeds my current ability to address.

Did you try something like (and its equivalent for xfaLeft):
.xfaRight > input {
 margin-right: 4px;
}

?

That said, don't give up :)

@calixteman Thanks for your suggestion.
I applied the styles below locally, but still observed the element shifting unfortunately.
.xfaRight > input {
  margin-right: 4px;
}

.xfaLeft > input {
  margin-left: 4px;
}

Closing since there has been no activity on this PR for over a month. However, please feel free to reopen this PR or create a new PR once the reference tests are passing locally; you can run them locally using npx gulp makeref on the master branch (to create the initial reference images) and then using npx gulp browsertest on your new branch (to compare the master reference images with your new code). Thanks!


Feature Request - Cache per devicetype/url

Hi @Darkweak ,
Hope you are all well !
It would be awesome to create a filter on the user-agent to cache page per device types (desktop/tablet and mobile) like varnish plugin https://github.com/varnishcache/varnish-devicedetect.
It is just a collection of regexrules for setting up a prefix to cache key.
What do you think about that ? Does it inspire you an easy way to implement this layer ?
Ref. https://github.com/varnishcache/varnish-devicedetect/blob/master/devicedetect.vcl#L33-L110
Cheers,
Luc Michalski

Should be done in #82 .

You can use YKeys to group requests by regex headers now. In the future, the #66 will implement a deeper way to cache items.


Add footer to the navigation drawer

Render any type of widget at the end of the drawer.
Footer option its used in a similar fashion as the header, by navigator.begin

Awesome!


Fix Travis CI status badge to show master's status.

This PR fixes travis status badge on README.md to show master branch's build status.
It's because the badge currently shows that of all branches in Chainer so it often says "build failing", it is not the case.

s/all branches/the most recently pushed branch/

Thank you!


Update namespace_mapping.go0

add ubuntu bionic

Oops! I didn't see this PR and cherrypicked the patch into the branch already. Thanks, though!


Renaming  'AVALON' containers to 'AYON' to keep it up to date / improve visual feedback within the outliner UI

Is there an existing issue for this?

[x] I have searched the existing issues and added correct labels.

Please describe the feature you have in mind and explain what the current shortcomings are?
We are still refering to AVALON containers even tho its legacy originating from OP days.

Suggested implementation?
We should...

Change its name to something like AYON or just AY instead (altering also its collection color?!)

Tidy up its appearence within the blender Outliner by switching on Exclude from View Layer so it wont be misleading for user -as those arent meant for direct interaction but more like a placeholder for AYON metadata -so itmakes sense to disable those so they appear greyed out. It would be best to hide those completely from user POV (truth is ...also been requested already) which is probably not possible in Blender?!

Describe alternatives you've considered:
Or just replacing the AVALON for AYON at least? Even tho Im not big fan of this kind of solution myself...

just a note the change needs to be backward-compatible


Fix blank TensorBoard pane due to existing MIME type misconfiguration on Windows

TensorBoard has received multiple reports of this even in the browser, so this impacts all TensorBoard users, not just VS Code TensorBoard users.
We have documented how to diagnose and fix this problem: https://github.com/microsoft/vscode-python/wiki/Troubleshooting-TensorBoard-integration-in-VS-Code#integrated-tensorboard-sessions
TensorBoard added a workaround for it that ships with the source code. https://github.com/tensorflow/tensorboard/pull/3128
For whatever reason that's not working and is still hitting our customers on Windows. Ideas:

Revisit the fix upstream. Maybe more is needed?
Check for and overwrite bad Windows registry values ourselves.

Hello @joyceerhl , despite having the latest version of the Python extension, Tensorboard stays blank. I'm working on Windows, but I am connected via SSH to a remote machine running Ubuntu.
What are the steps required to make Tensorboard work again?


Add method for turning coordinate into buffered circle

Combine makePoint and bufferProjected in one method

ProjectionUtils.makeCircle(Coordinate, Radius)


Refactor code by using better design patterns

done in https://github.com/amitsingh-007/bypass-links/pull/46


Sms retry artegact merge

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Update the chanes so closing this pull request and creating another one post  scanning it with CFNNag


Pipes

I would like to know if there is any possibility to allow the Pretty Pipes to send more than one stack at the same time.

No, there isn't. You can always connect multiple pipes to the same container.

That which says to put several pipes does not work, since it detects the
fastest route and keeps sending stack by stack. By the way, the pipes do
not distribute the items well when they are sent to an entity that is
extracted to send it to another, for example when I send it to a hopper and
that hopper to another or to an automatic work table for some reason it
does not distribute in equal parts.
El vie., 28 ago. 2020 0:31, Ellpeck<EMAIL_ADDRESS>escribió:

Closed #27 https://github.com/Ellpeck/PrettyPipes/issues/27.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Ellpeck/PrettyPipes/issues/27#event-3701655120, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APPCIARF4GC57N253CULUXDSC3NDNANCNFSM4QMF6OVA
.


Feature/1559 refine the contact for funding agreement letters task rework

Changes
Add the "Confirm who will get the funding agreement letters" task.
This task was begun previously but this is a reworking & completion of it.
If a project has external contacts already entered, then they will appear on the task page. The user will then be able to select a contact and assign them as the "funding agreement letters" contact.
On the external contacts page, the "funding agreement letters" contact will be indicated as per the second screenshot.

If a project has no external contacts already, the user will be invited to add more contacts by some text on the task page, and a link leading to the external contacts page. They can then come back to the task later and assign contacts as above.
Previously, we had anticipated that the user would be adding a contact directly on the task page. This reworking means that only the contact ID is stored in the task data, and all contact details are stored in the contacts table.
Checklist

[ ] Attach this pull request to the appropriate card in Trello.
[x] Update the CHANGELOG.md if needed.

 Refine the contact for funding agreement letters task


how many cycles approximately zkSnake would take?

Sorry I cannot run it in my machine due to several errors from old version, I just would like to know how many cycles approximately it would take? Because I want to estimate the compute load of zk games in R0, thx!

This project is very unoptimized, and should not be used for benchmarking purposes.


Show resource name in hover popup

When hovering over a transition node of a resource in the UI, a popup shows the resource ID, timestamp, and new value. It would be helpful to show the resource name instead of ID (or in addition to ID). This is for views that stack two resources on top of each other in a row like "Peel and Fruit Usage" in Banananation's default.

Is the resource ID useful to folks or are they primarily just looking for the name?

Just the name, adding a legend for line rows with multiple resources is another option.


Parallelize Leviathan Multi-Suite testing among multiple workers

PR adds parallelization support to running test suites across multiple available workers. Additionally, it also involves multiple improvements to client cloud helpers, code readability and testing performance

@vipulgupta2048 depending on how things are going on your end, we could merge this (after I quickly test it), and then make the changes we discussed yesterday in a subsequent PR?

@rcooke-warwick  Opened #416 for that

@vipulgupta2048 this is ready to be merged ,when we merge https://github.com/balena-os/leviathan/pull/402 and https://github.com/balena-os/leviathan/pull/412

testing running against an app with a single and two testbots (rpi3 as DUT) and it's working great

@balena-ci rebase

@balena-ci rebase

@balena-ci I self-certify!


First run through the code to cleanup styling

This is a BIG PR that cleans up the code for styling and formatting. It is a first pass and will need to be reviewed carefully to see that I haven't introduced any syntax errors.
@bkg Please see if I've screwed up the PEP8 styling and make edits where appropriate. Thanks!

Well, there is a syntax error already lol This will take some time to sort out...

Hmm, I branched off of catalog_restructure and I was hoping it would merge to that branch but it wants to merge to main

Looks fine to me. It contains the code from catalog_restructure. We just need to wait until that branch is merged to merge this one

I'm noticing some scripts have a line of whitespace between a function and the resulting return call, and some do not

threshold_tools.py has # ========= breaks in between each function, the rest of our scripts do not do this.

I'm noticing some scripts have a line of whitespace between a function and the resulting return call, and some do not
with whitespace: catalog_utils derive_variables metadata_update selectors (some) threshold_tools timeseriestools (some) tmy (some) unit_conversions (some) utils (some) warming_levels (some)

Yeah, I waffled on this one. Technically, the return should be right after the code with no extra white space. I will impose that.

Second pass through the repo complete. Amazing how much you miss even when you are concentrating. I finally figured out how to split large strings using ( " " " " " ") so text strings should display properly. I will now do some serious testing of all the code.

Hey Eric, so sorry about the bit of a mess I created when trying to resolve merge conflicts in this branch. You'll see that I had to do a force-commit back to your most recent commit to undo what I did. I created a mess, but it's all cleaned up now and back to where you left it.
I also changed the base branch to catalog_restructure :D
**Regarding the merge conflicts: ** Victoria just merged some code in tmy.py that has conflicts. There is also a merge conflict in the data_explore.py file, perhaps due to the merge of PR https://github.com/cal-adapt/climakitae/pull/105 on Oct 20? I created a mess trying to resolve this, so I will leave that to you to resolve and stop messing with your code!


Redis EXISTS not available or am I blind?

Issue

Describe your issue here
I was not able to find the EXISTS Method in your documentation. Am I blind or is it not implemented yet or is there an more elegant way to check if a key already exists?

@Urento
I'm not sure if it's mentioned in the docs, but the exists command is implemented, and you can use it just like any other command:
client.exists(key, (err, isExists) => {
  if (err) {
    return console.error(err);
  }

  console.log(isExists);
});

@leibale Okay, thank you!


Normalize the way of writing 'LibSass' to the one used by the project

I just normalized the spelling of 'LibSass' for consistency purposes.

@raithit thanks for this! Sorry for the delay we've been busily working on LibSass.


Clean up dataloader logic

Fixes #928
Fixes #927
Fixes #922
Fixes #909
Fixes #859
Fixes #902
Removes data_decorator
# old
@data_loader
def train_data(...):

# new
def train_data(...):

Adds prepare_data
Lightning needs a step to download data on proc 0 only
def prepare_data():
  # do actual downloads

def train_data(...):
    # return dataloader

Added new flags
# progress bar fast refresh freezes notebooks. here we throttle it
Trainer(progress_bar_refresh_rate=50)

# allow user to reload dataset each epoch
Trainer(reload_dataloaders_every_epoch=False)

Fixes .fit with data
The .fit(dataloaders) was buggy. Simplified it to just hook into the rest of the framework instead of its own adhoc process.
Automatic sampler
Now user doesn't have to mess around with samplers on DDP or TPUs. Lightning sets it up automatically.

Hello @williamFalcon! Thanks for updating this PR.

In the file pytorch_lightning/trainer/data_loading.py:

Line 152:19: E702 multiple statements on one line (semicolon)

I still feel this puts too much restriction on the data loader.
A data loader is a very abstract thing, and all we ask from it is the next batch of data. or maybe the size of the dataset.
The current implementation assumes this is a pytorch dataloader and try to access dataloader.batch_size from it.

i don’t disagree. maybe a good approach is to check that it’s a pytorch dataloader? what other dataloaders are there?

What I meant is that lightning should not touch the data loader that the user provides unless necessary.
In the current master branch, the reset_train_dataloader() tries to create a new torch data loader from the given one.
And I cannot find a way to disable it.

we could make this a method you can override in lightning module.
what use case do you need to maintain the original loader?
we could also use a flag in the trainer:
auto_add_sampler=True by default

I have multiple dataloaders that each loads images in order.
And I have my own sampler that makes sure the loaded batch is in order but the batch themselves could be random.
I then use itertools to chain these loaders so that they look like one loader.
This works fine until this pr.
Basically all I need is for lightning to not touch my loader when I don't need fancy features like tpu or ddp and stuff.
What's your suggestion?

We're currently adressing this in the fix for #953 - will PR soon

@ethanwharris I will repost my concerns there then. Thanks for the pointer.

@versatran01 that would be cool, looking forward to your points :robot:


Deleted alias in installOptions.

Changes
Deleted alias in installOptions.

Testing
All tests have been passed.

Docs
No docs need to update.

You can remove entirely, instead of commenting out

You can remove entirely, instead of commenting out

Sorry. I made a mistake. I removed it totally.

np, thank you!


Minor fixes for "The WebView2 process model"

Updated date.
Real Description yaml field (for search results display & SEO key words).
Changed to "render_er_ process".
Defined 'process group'.
Broke out parenthetical phrase to simplify sentence.

Docs Build status updates of commit 92c2902:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/process-model.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@jasonstephen15 @Syul968 The Files changed tab only shows my few changed lines.  If you want to address any Todo items on other lines, or PR comments from the previous PR, you can edit this PR branch or its working branch in local VS Code --
or press . in GitHub to edit in web-based VS Code, then click the branching icon on left, then click the checkmark to enter a commit/message and kick off a doc build.

"Convert to draft", below Reviewers, seems pretty useful.

Docs Build status updates of commit a54ca14:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/process-model.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d22fe65:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/process-model.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 090a3a0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/process-model.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Fix nasty FD re-use race condition in NGUnixDomainSocket

This is another take on https://github.com/martylamb/nailgun/pull/75 to fix the same underlying race condition in NGUnixDomainSocket.
Here's the race:
Thread 1:
  NGUnixDomainSocket.NGUnixDomainSocketInputStream.read()
  (gets descheduled before calling NGUnixDomainSocketLibrary.read(fd))
Thread 2:
  NGUnixDomainSocket.close()
  NGUnixDomainSocketLibrary.close(fd)
  (the kernel now marks fd as free to re-use)
Any Thread Except 1:
  fd = open() (or dup(), etc.)
  (due to POSIX rules, kernel will return and re-use the lowest fd—from which Thread 1 is about to read)
Thread 1:
  (gets rescheduled)
  NGUnixDomainSocketLibrary.read(fd)
  (reads garbage from some other unrelated file descriptor, causing havoc)

The fix is to do the same thing Java's own AbstractPlainSocketImpl does: keep a reference count along with the fd protected by a lock.
Any time we read or write, we first grab the lock, increment the reference count, then unlock, and do the read or write. Once that returns, we grab the lock again, decrement the reference count, and if it's gone to 0 and we have a close pending, we close.
Any time we close, we first grab the lock, check if the reference count is 0, and if so, close and release the lock. Otherwise, we have a read or write pending, so we set a close pending flag and just release the lock.
There is still a very similar race in NGUnixDomainServerSocket, but thankfully we only have one thread calling accept() and another calling close(), so there's no race condition. (If we had multiple threads calling accept(), we'd be in trouble.)

This seems to work. I am no longer seeing any failures in my build output that I believe can be attributed to this issue. But man, the current version of nailgun is slow. I am seeing some programs in our test suite take over twice as long as they did when we were running a fork of df35649. Our build is timing out and I'm seeing the occasional OOM that we didn't have before. I have tested this and it's not related to sockets though so as far as I am concerned this change is good to be merged. I will investigate the other issue on my own time at some point.

Sweet! I seriously appreciate the testing, @dwightguth—doubly so for confirming the slowdown isn't related to the Unix domain sockets.
I think it'd help a lot to file a separate issue to track the slowdown (mentioning the forked version was faster). That way someone can take a stab at profiling to see what's going on.


Series service endpoints for series-by-id and series list share the same pattern

https://opencast.jira.com/browse/MH-9038
Series by id is accessed by /series/{SERIES_ID}.xml, the series list by /series/series.xml
This should be cleaned up since having a series with id "series" conflicts with the list endpoint.

Wow, IMHO, it would be better to enforce that the name "series"  is a special reserved name, and not eligible as a unique name for an individual series.


[Addon: Notes] - V5 - Weird formatting occurs when using markdown code snippet (code)

Describe the bug
When using markdown with the notes addon, in version 5.x, special characters are showing abnormal spacing.
To Reproduce
Steps to reproduce the behavior:

Follow the directions to add notes to the storybook project
add a markdown file or include markdown in your ts file (This markdown should include code snippets using tacs 3 tacs(`) code and then another 3 tacs(`)
in the configuration, add -  notes: someMarkdownHere
run storybook and look to the notes section

Expected behavior
I should be able to go to the notes section and see a correctly formatted code snippet
Screenshots
What is currently being shown:

What should be shown:

Code snippets
See markdown below (remove slashes next to ticks):
# Component name

Component description

## Installation

directions:

/`/`/`
npm install --save libaryname
/`/`/`

## Usage

html snippet
/`/`/`
<component-a
    [x]="x value goes here"
    [y]="y value goes here"
    [z]="z value goes here"
</component-a>
/`/`/`

System:

Browser: [chrome, firefox (havee not checked ie)]
Framework: [Angular (but may not be specific to Angular)]
Addons: [addon-notes, addon-knobs, addon-a11y, addon-viewport, addon-actions]
Version: [5.0.0-beta.3]

Additional context
I have run the markdown files through several MD checkers and they are valid so I think I have ruled out user error on this one.

Hi @CodeByAlex - I'm no expert here, but in our story (http://localhost:9011/?path=/info/addons-notes--addon-notes-rendering-inline-github-flavored-markdown) we use:
~~~js
//code
~~~

and it works fine. Maybe this is what you are supposed to do? This is also the way it was written in v4: https://storybooks-official.netlify.com/?selectedKind=Addons|Notes&selectedStory=withNotes rendering inline%2C github-flavored markdown&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Fnotes%2Fpanel

@tmeasday - sorry for the delay, just got back from Vacation - Thats odd because tacks are supposed to work and that's what we have been using in our code base. Another alternative is using 4 spaces before each line in the code in order to show it as a code block and that too is not formatting as expected. Any chance you could try those? Can't get them working locally.

@CodeByAlex have you tried in v4? I'm just wondering if this is a regression or a plain bug

@tmeasday This worked in V4 using both ticks and spaces which is why I found it odd. Was the markdown library or code changed for V5?

@CodeByAlex I think the area we render the code in changed? I'm not really sure TBH, I am just trying to triage it at this point :)

I am also receiving these errors when I click to the notes tab:
vendors~main.75dfa2d4f775fd63ee97.bundle.js:75267 Warning: Failed prop type: The prop `language` is marked as required in `CopyableCode`, but its value is `undefined`.
    in CopyableCode (created by SyntaxHighlighter)
    in SyntaxHighlighter (created by Markdown)
    in pre (created by Markdown)
    in div (created by Markdown)
    in Markdown (created by NotesPanel)
    in div (created by Context.Consumer)
    in Styled(div) (created by StyledMarkdown)
    in StyledMarkdown (created by NotesPanel)
    in div (created by Context.Consumer)
    in Styled(div) (created by NotesPanel)
    in NotesPanel (created by Preview)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Provider (created by Preview)
    in Provider (created by Preview)
    in Preview (created by Context.Consumer)
    in Unknown (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Preview (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in Main (created by Layout)
    in Layout (created by Context.Consumer)
    in WithTheme(Layout) (created by ResizeDetector)
    in ResizeDetector
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by ResizeDetector)
    in ResizeDetector
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root
printWarning @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:75267
checkPropTypes @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:75329
validatePropTypes @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:129948
createElementWithValidation @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:130037
SyntaxHighlighter @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:8649
renderWithHooks @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:96450
mountIndeterminateComponent @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:98427
beginWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:99032
performUnitOfWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102719
workLoop @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102759
renderRoot @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102842
performWorkOnRoot @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103749
performWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103661
performSyncWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103635
requestWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103504
scheduleWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103318
enqueueSetState @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:94752
push../node_modules/react/cjs/react.development.js.Component.setState @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:128617
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2638
requestAnimationFrame (async)
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2636
Promise.then (async)
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2634
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:3234
navigate @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:3233
onClick @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2996
callCallback @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83760
invokeGuardedCallbackDev @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83810
invokeGuardedCallback @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83867
invokeGuardedCallbackAndCatchFirstError @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83881
executeDispatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84172
executeDispatchesInOrder @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84194
executeDispatchesAndRelease @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84291
executeDispatchesAndReleaseTopLevel @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84299
forEachAccumulated @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84273
runEventsInBatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84427
runExtractedEventsInBatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84435
handleTopLevel @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88437
batchedUpdates$1 @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103846
batchedUpdates @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:85762
dispatchEvent @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88516
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103897
unstable_runWithPriority @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:135160
interactiveUpdates$1 @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103896
interactiveUpdates @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:85781
dispatchInteractiveEvent @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88493
vendors~main.75dfa2d4f775fd63ee97.bundle.js:84117 Warning: validateDOMNesting(...): <pre> cannot appear as a descendant of <p>.
    in pre (created by Context.Consumer)
    in Styled(pre) (created by SyntaxHighlighter)
    in SyntaxHighlighter (created by CopyableCode)
    in div (created by Context.Consumer)
    in Styled(div) (created by CopyableCode)
    in div (created by Context.Consumer)
    in Styled(div) (created by CopyableCode)
    in CopyableCode (created by SyntaxHighlighter)
    in SyntaxHighlighter (created by Markdown)
    in p (created by Markdown)
    in div (created by Markdown)
    in Markdown (created by NotesPanel)
    in div (created by Context.Consumer)
    in Styled(div) (created by StyledMarkdown)
    in StyledMarkdown (created by NotesPanel)
    in div (created by Context.Consumer)
    in Styled(div) (created by NotesPanel)
    in NotesPanel (created by Preview)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Provider (created by Preview)
    in Provider (created by Preview)
    in Preview (created by Context.Consumer)
    in Unknown (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Preview (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in Main (created by Layout)
    in Layout (created by Context.Consumer)
    in WithTheme(Layout) (created by ResizeDetector)
    in ResizeDetector
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by ResizeDetector)
    in ResizeDetector
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root
warningWithoutStack @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84117
validateDOMNesting @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:92212
createInstance @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:92322
completeWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:100307
completeUnitOfWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102549
performUnitOfWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102747
workLoop @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102759
renderRoot @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102842
performWorkOnRoot @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103749
performWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103661
performSyncWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103635
requestWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103504
scheduleWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103318
enqueueSetState @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:94752
push../node_modules/react/cjs/react.development.js.Component.setState @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:128617
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2638
requestAnimationFrame (async)
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2636
Promise.then (async)
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2634
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:3234
navigate @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:3233
onClick @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2996
callCallback @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83760
invokeGuardedCallbackDev @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83810
invokeGuardedCallback @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83867
invokeGuardedCallbackAndCatchFirstError @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83881
executeDispatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84172
executeDispatchesInOrder @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84194
executeDispatchesAndRelease @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84291
executeDispatchesAndReleaseTopLevel @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84299
forEachAccumulated @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84273
runEventsInBatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84427
runExtractedEventsInBatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84435
handleTopLevel @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88437
batchedUpdates$1 @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103846
batchedUpdates @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:85762
dispatchEvent @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88516
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103897
unstable_runWithPriority @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:135160
interactiveUpdates$1 @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103896
interactiveUpdates @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:85781
dispatchInteractiveEvent @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88493
vendors~main.75dfa2d4f775fd63ee97.bundle.js:84117 Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.
    in div (created by Context.Consumer)
    in Styled(div) (created by CopyableCode)
    in div (created by Context.Consumer)
    in Styled(div) (created by CopyableCode)
    in CopyableCode (created by SyntaxHighlighter)
    in SyntaxHighlighter (created by Markdown)
    in p (created by Markdown)
    in div (created by Markdown)
    in Markdown (created by NotesPanel)
    in div (created by Context.Consumer)
    in Styled(div) (created by StyledMarkdown)
    in StyledMarkdown (created by NotesPanel)
    in div (created by Context.Consumer)
    in Styled(div) (created by NotesPanel)
    in NotesPanel (created by Preview)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Provider (created by Preview)
    in Provider (created by Preview)
    in Preview (created by Context.Consumer)
    in Unknown (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Preview (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in Main (created by Layout)
    in Layout (created by Context.Consumer)
    in WithTheme(Layout) (created by ResizeDetector)
    in ResizeDetector
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by ResizeDetector)
    in ResizeDetector
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root
warningWithoutStack @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84117
validateDOMNesting @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:92212
createInstance @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:92322
completeWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:100307
completeUnitOfWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102549
performUnitOfWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102747
workLoop @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102759
renderRoot @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102842
performWorkOnRoot @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103749
performWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103661
performSyncWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103635
requestWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103504
scheduleWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103318
enqueueSetState @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:94752
push../node_modules/react/cjs/react.development.js.Component.setState @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:128617
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2638
requestAnimationFrame (async)
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2636
Promise.then (async)
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2634
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:3234
navigate @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:3233
onClick @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2996
callCallback @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83760
invokeGuardedCallbackDev @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83810
invokeGuardedCallback @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83867
invokeGuardedCallbackAndCatchFirstError @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83881
executeDispatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84172
executeDispatchesInOrder @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84194
executeDispatchesAndRelease @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84291
executeDispatchesAndReleaseTopLevel @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84299
forEachAccumulated @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84273
runEventsInBatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84427
runExtractedEventsInBatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84435
handleTopLevel @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88437
batchedUpdates$1 @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103846
batchedUpdates @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:85762
dispatchEvent @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88516
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103897
unstable_runWithPriority @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:135160
interactiveUpdates$1 @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103896
interactiveUpdates @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:85781
dispatchInteractiveEvent @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88493
vendors~main.75dfa2d4f775fd63ee97.bundle.js:84117 Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.
    in div (created by Context.Consumer)
    in Styled(div) (created by ActionBar)
    in ActionBar (created by CopyableCode)
    in div (created by Context.Consumer)
    in Styled(div) (created by CopyableCode)
    in CopyableCode (created by SyntaxHighlighter)
    in SyntaxHighlighter (created by Markdown)
    in p (created by Markdown)
    in div (created by Markdown)
    in Markdown (created by NotesPanel)
    in div (created by Context.Consumer)
    in Styled(div) (created by StyledMarkdown)
    in StyledMarkdown (created by NotesPanel)
    in div (created by Context.Consumer)
    in Styled(div) (created by NotesPanel)
    in NotesPanel (created by Preview)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Provider (created by Preview)
    in Provider (created by Preview)
    in Preview (created by Context.Consumer)
    in Unknown (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Preview (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in Main (created by Layout)
    in Layout (created by Context.Consumer)
    in WithTheme(Layout) (created by ResizeDetector)
    in ResizeDetector
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by ResizeDetector)
    in ResizeDetector
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root
warningWithoutStack @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84117
validateDOMNesting @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:92212
createInstance @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:92322
completeWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:100307
completeUnitOfWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102549
performUnitOfWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102747
workLoop @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102759
renderRoot @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102842
performWorkOnRoot @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103749
performWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103661
performSyncWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103635
requestWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103504
scheduleWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103318
enqueueSetState @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:94752
push../node_modules/react/cjs/react.development.js.Component.setState @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:128617
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2638
requestAnimationFrame (async)
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2636
Promise.then (async)
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2634
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:3234
navigate @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:3233
onClick @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2996
callCallback @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83760
invokeGuardedCallbackDev @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83810
invokeGuardedCallback @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83867
invokeGuardedCallbackAndCatchFirstError @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83881
executeDispatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84172
executeDispatchesInOrder @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84194
executeDispatchesAndRelease @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84291
executeDispatchesAndReleaseTopLevel @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84299
forEachAccumulated @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84273
runEventsInBatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84427
runExtractedEventsInBatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84435
handleTopLevel @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88437
batchedUpdates$1 @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103846
batchedUpdates @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:85762
dispatchEvent @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88516
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103897
unstable_runWithPriority @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:135160
interactiveUpdates$1 @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103896
interactiveUpdates @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:85781
dispatchInteractiveEvent @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88493
vendors~main.75dfa2d4f775fd63ee97.bundle.js:84117 Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.
    in div (created by Context.Consumer)
    in Styled(div) (created by CopyableCode)
    in CopyableCode (created by SyntaxHighlighter)
    in SyntaxHighlighter (created by Markdown)
    in p (created by Markdown)
    in div (created by Markdown)
    in Markdown (created by NotesPanel)
    in div (created by Context.Consumer)
    in Styled(div) (created by StyledMarkdown)
    in StyledMarkdown (created by NotesPanel)
    in div (created by Context.Consumer)
    in Styled(div) (created by NotesPanel)
    in NotesPanel (created by Preview)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Provider (created by Preview)
    in Provider (created by Preview)
    in Preview (created by Context.Consumer)
    in Unknown (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Preview (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in Main (created by Layout)
    in Layout (created by Context.Consumer)
    in WithTheme(Layout) (created by ResizeDetector)
    in ResizeDetector
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by ResizeDetector)
    in ResizeDetector
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root
warningWithoutStack @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84117
validateDOMNesting @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:92212
createInstance @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:92322
completeWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:100307
completeUnitOfWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102549
performUnitOfWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102747
workLoop @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102759
renderRoot @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:102842
performWorkOnRoot @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103749
performWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103661
performSyncWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103635
requestWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103504
scheduleWork @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103318
enqueueSetState @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:94752
push../node_modules/react/cjs/react.development.js.Component.setState @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:128617
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2638
requestAnimationFrame (async)
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2636
Promise.then (async)
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2634
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:3234
navigate @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:3233
onClick @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:2996
callCallback @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83760
invokeGuardedCallbackDev @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83810
invokeGuardedCallback @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83867
invokeGuardedCallbackAndCatchFirstError @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:83881
executeDispatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84172
executeDispatchesInOrder @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84194
executeDispatchesAndRelease @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84291
executeDispatchesAndReleaseTopLevel @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84299
forEachAccumulated @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84273
runEventsInBatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84427
runExtractedEventsInBatch @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:84435
handleTopLevel @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88437
batchedUpdates$1 @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103846
batchedUpdates @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:85762
dispatchEvent @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88516
(anonymous) @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103897
unstable_runWithPriority @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:135160
interactiveUpdates$1 @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:103896
interactiveUpdates @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:85781
dispatchInteractiveEvent @ vendors~main.75dfa2d4f775fd63ee97.bundle.js:88493

I am closing this issue because it was resolved by changes made in pr #5802 . If anyone believes that this should be re-opened, please feel free to do so.

I am seeing a strange, possibly related, issue with indentation of code blocks within markdown.
Much of the indentation is incorrect or wrong.

Renders as

HTML is much worse:

Renders as

I am using storybook 5.1.8 with addon-notes 5.1.8

cc @ndelangen ☝

I'll pick this up

Great Caesar's ghost!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-alpha.30 containing PR #7158 that references this issue. Upgrade today to try it out!
You can find this prerelease on the @next NPM tag.
Closing this issue. Please re-open if you think there's still more to do.

Ooh-la-la!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.1.10 containing PR #7158 that references this issue. Upgrade today to try it out!


Include total test suite execution time in HTML report

The total test suite execution time is already measured and displayed in the console. This information, as well as the total number of passed/failed tests, should be included in the HTML report.

See scripts/runtestsuite/runtestsuite.py.
Originally from https://github.com/appleseedhq/appleseed/issues/2847

Hi, I'd like to take this issue up. I've gone through the scripts/runtestsuite/runtestsuite.py  file and there are two types of reports (simple and detailed). Is the total execution time required to be in both the types of the reports?

@h44rd  That would be great to have it in both :)

html : http://testsuite.appleseedhq.net:8080/current-job/sandbox/tests/test scenes/report.html
and txt : http://testsuite.appleseedhq.net:8080/current-job/sandbox/tests/test scenes/testsuite_script_log.txt


Option to pass svg path into the prefixID plugin?

The prefixIDs plugin in svgo accepts a path option passed into it via the options object in the optimize method. Examples here and here.
This is very useful in cases when a lot of the svgs in a project are exported from Adobe Illustrator and have classes like st0, st1. All the svgs have the same classes and the styles get messed up because of this.
Prefixing the svg classes with the relative paths is a nice way to ensure this does not happen. I guess the same could be acheived by prefixing a random value but the path option is nicer cause it's more readable while debugging.

I'd be glad to help with a PR if you could just lay out what needs to be done both in this repo and in brocolli-svg-optimizer.

It's related to solved issue #68. It can be fixed with inlineStyles plugin like this. Anyway, I'll take a look at the path option when I have time.

I was looking into the inlineStyles plugin as an alternative to this but was unsure about transitioning cause prefixIDs has been working very well for us.
Good to know someone else is using inlineStyles to to fix this. Thanks for the help :)

Fixed in https://github.com/ivanvotti/broccoli-svg-optimizer/pull/11


Apexchart Pie - Combining Small Slices into "Other"

We started using ApexChart recently to create all the graphs on our reporting platform. We were using another library before and it had a nice feature where we could set a percentage threshold and the library would automatically combine all the slices under that threshold into 1 slide and label it as "Other".
This featured is mentioned in one of your blogs: https://apexcharts.com/tag/pie-chart/
However, it's not mentioned anywhere in the documentation. Can anyone tell me how to achieve the combined effect in a pie chart?

The feature is not available in ApexCharts, the blog article is just a recommendation you can follow.
You will have to calculate the grouped totals and manually create the series/labels.
Here's a full example - https://codepen.io/apexcharts/pen/rNxzBKP

any automated way to group only small slices if pie chart is over capacity?


executor_manager doc shows up blank in master

Description
This is blank: https://mxnet.apache.org/api/python/docs/api/mxnet/executor_manager/index.html
Looks like it was (re)moved in master. Does this doc node need to be removed?

@eric-haibin-lin do we need this?

https://github.com/apache/incubator-mxnet/issues/18730


Clean up mock clocks in tests

When Clock gets more methods, mocking it properly becomes non-trivial and tightens the coupling between the test and the implementation being tested.

@bot-gradle test this

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have failed:

Pull Request Feedback (Trigger) (Check)

Build Scan

@bot-gradle test this

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have failed:

Pull Request Feedback (Trigger) (Check)

Build Scan

@bot-gradle test this

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have passed:

Pull Request Feedback (Trigger) (Check)

Build Scan

@bot-gradle test this without PTS

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have failed:

Pull Request Feedback (Trigger) (Check)

Build Scan


AUR git repository is missing

https://aur.archlinux.org/twotris-git.git
gets me a 404.

But works fine at home. Must be a work firewall thing.


fix(3186365507): align header to Figma

Description of the Changes

Changing header height to 72
Changing padding

Solves #3186365507

Checklist

[x] Manually tests of the main Application flows are done and passed.
[ ] New unit / functional tests have been added (whenever applicable).
[ ] Docs have been updated (whenever relevant).
[x] PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is

:tada: This PR is included in version 1.9.0-dev.16 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


First run issue

I get the following error,  when I try to open an image (this is during first run):
TypeError: thumbnails.flat is not a function
Thanks,
Barbaros

It turns out this is an issue with Firefox (handling of JavaScript), things work in Chrome.
Thanks,
Barbaros

Fixed here: https://github.com/OHIF/Viewers/pull/573/files#diff-14b1e33d5bf5649597cdc0e4f684daddR33


bottle tag for private formula

I have a private formula and I would like to also provide a bottle for the formula. However, I am a little bit unsure how to specify the bottle block for all macos platforms without building a bottle for each platform. Idealy, I am looking for
  bottle do
    cellar :any
    root_url https://example.com
    sha256 "<HASH>" => :macos
  end

and the bottle is located at https://example.com/<formula>-<ver>.macos.bottle.tar.gz

From the issue template:

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you do not read fill out the issue template repeatedly you will be blocked from ever submitting issues to Homebrew again.

This your second warning on this. In this case, this is a better question for our Discourse forum: https://discourse.brew.sh
Note, we do not support building a single bottle for all macOS versions.


set_time_of_day does not set monotonic time value

I came across an issue where I tried to do:
let now = birl.now()
let start_time =
  birl.set_time_of_day(
    now,
    birl.TimeOfDay(hour: 8, minute: 0, second: 0, milli_second: 0),
  )
let diff = birl.difference(now, start_time)

But this always returns Duration(0) because set_time_of_day doesn't seem to change the monotonic_time and difference uses the monotonic_time if it can?
I'm afraid I'm not sure what the solution is. Possibly to set the monotonic time to None if it is not possible to calculate it from the new time of day.
I have worked around it by converting now to an iso8601 string and re-parsing it at which point it doesn't have a monotonic_time so the approach works.

Right now the monotonic time is just the time passed since the VM started. To implement this I should change it so that the momotonic time also indicates a specific moment.

Coming here to say that I understand monotonic time indicates the time passed since VM started, but then, why using it in compare function? Currently, if two wall_time are different, but monotonic_time has a value, wall_time are not taken into account.
When creating a new date, I currently uses birl.to_unix |> birl.from_unix to make sure everything works as expected 🙂


Timeout on Deploying Flows

Current Behavior
Occasionally users on flowforge cloud are reporting that they get an ETIMEOUT error when deploying their flows.
I have had this with a new project on the first deployment, subsequent deploys work fine.
The error in the Node-RED log is:

RequestError: Timeout awaiting 'request' for 1000ms
    at ClientRequest.<anonymous> (/data/node_modules/got/dist/source/core/index.js:970:65)
    at Object.onceWrapper (node:events:642:26)
    at ClientRequest.emit (node:events:539:35)
    at ClientRequest.origin.emit (/data/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)
    at Socket.socketErrorListener (node:_http_client:454:9)
    at Socket.emit (node:events:527:28)
    at emitErrorNT (node:internal/streams/destroy:157:8)
    at emitErrorCloseNT (node:internal/streams/destroy:122:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
    at Timeout.timeoutHandler [as _onTimeout] (/data/node_modules/got/dist/source/core/utils/timed-out.js:36:25)
    at listOnTimeout (node:internal/timers:561:11)
    at processTimers (node:internal/timers:502:7)

Expected Behavior
Deploy should succeed
Steps To Reproduce
Create a new project, add some nodes and hit deploy. The error may be intermittent.
Environment

FlowForge version: 0.7.0
Node.js version: 	v16.15.1
npm version: ??
Platform/OS: Mac
Browser: Chrome

Until we can profile where the time is being spent this is going to be hard to track down and we can't changed the timeout in the storage pluing without replacing the stack.
The storage API in the forge app is pretty much a straight DB insert/upsert and we shouldn't really have enough load to have it take that long.
Will think about it some more.

I can see from the database that the inserts are happening on the first attempt, so it is the 1 second timeout that is driving the failure. Still digging to see if I get sql perfomance logs from the DB

I can't see anything obvious in the basic default database metrics dashboard, not CPU or read/write latency spikes

Fixed via https://github.com/flowforge/flowforge-nr-storage/pull/18


Crash Report<PHONE_NUMBER>

Link:
https://wowsims.github.io/wotlk/feral_druid/#eJztkk9oE0EUxve9XZLpUMsY0K4BYd1TKQQnWRbqabeePEnAi8dWqQh6CEVQC0KQQpMeJEUotnpoPFhBixLQxlZBSS/VSmIOjTZ4UKsNIij0oEKhvt0lEnMS1Jsfw8C895vvzZ/H9zIUKLEPkjgAKcwA5gDuAlYAGgAHdzEwoAdcSMI5yADcBLiCEFGis6GLEEqeHjw/NMzCAqJ3gAsxv4J6Zh3M0P0SbpSQa2J0C3inKEygGXozjzQ4E5VZ1NfmVMrWJ5GHRXESTVAIG7uBem1ONVFReJfI0Sp7WzW1WhEV3iHSeTRVz2GHGL+EeoNAdaKIlNl8QRmiyHFzxps/PfLm16+8akuLqJfqyBXa97KOevkJwXQ4cydDqdK9taPaAPqX681R5f9q1QhjIFDHFBQgxBX6eGUcYraVkKS4FZOWbUk7LuPS8tYJy6KItOIUi9nSh96CzmbKKK6XUX+wjkatij1PqyhXq9gA7QuEp6FGzcM1lh/DCAvqfnN4N1fZ++6IaAaer3ja7/rovUVoohGXR3kXy+42tpv6maNG8ugPt9QWY+H1ZQF+jbCFfBvDPmaxLTLVzojLC03m8eHgZJ+/tjBroJjvsCMAjrl7pqc8LTsHAqDi7Dvha9VJPMTUtQsjncnBM8dPnh0aPmUkbOOIzv55T466f8Mlvbz0Jz6yrzfV/7uw/3jpq8/c/uA5vzuH4AfRoKun
RNG Seed: 0
ResourceType set for spell {SpellID: 48477} but no cost
Stack Trace:
goroutine 7 [running]:
runtime/debug.Stack()
/opt/hostedtoolcache/go/1.18.6/x64/src/runtime/debug/stack.go:24 +0x6
main.computeStats.func1()
/home/runner/work/wotlk/wotlk/sim/wasm/main.go:49 +0x10
panic({0xc06a0, 0x7a2e4c0})
/opt/hostedtoolcache/go/1.18.6/x64/src/runtime/panic.go:838 +0x29
github.com/wowsims/wotlk/sim/core.(*Spell).wrapCastFuncResources(0x7a470e0, {{0x0, 0x59682f00, 0xd09dc300, 0x0, 0x0}, 0x0, 0x0, {0x7a192a8, 0x8bb2c97000}, ...}, ...)
/home/runner/work/wotlk/wotlk/sim/core/cast.go:115 +0x39
github.com/wowsims/wotlk/sim/core.(*Spell).makeCastFunc(0x7a470e0, {{0x0, 0x59682f00, 0xd09dc300, 0x0, 0x0}, 0x0, 0x0, {0x7a192a8, 0x8bb2c97000}, ...}, ...)
/home/runner/work/wotlk/wotlk/sim

Link here seems super messed up, no race selected, and listed cooldowns is weird, assuming this might have been from addon importer while it was still getting finished?

Hi Jake,
I cannot recall and honestly did not expect to get a response. This is super cool of you, so thanks! The sim tool has been working out quite nicely!

Dylan

Sent from my iPhone

On Oct 19, 2022, at 4:04 PM, Jake @.***> wrote:

Link here seems super messed up, no race selected, and listed cooldowns is weird, assuming this might have been from addon importer while it was still getting finished?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.


dtype int16 instead of dtype int8 in outputs_info

ValueError: When compiling the inner function of scan the following error has been encountered: The initial state (outputs_info in scan nomenclature) of variable IncSubtensor{Set;:int64:}.0 (argument number 3) has dtype int16, while the result of the inner function (fn) has dtype int8. This can happen if the inner function of scan results in an upcast or downcast.

OSX 10.11.6
CUDA Driver Version: 8.0.46
python 2.7

Fulltrace:
Using gpu device 0: GeForce GTX 675MX (CNMeM is enabled with initial size: 24.0% of memory, cuDNN 5105)
Loaded TEST_MIDI1
Traceback (most recent call last):
File "main.py", line 43, in
m = model.Model([300,300],[100,50], dropout=0.5)
File "/Users//neural/biaxial-rnn-music-composition/model.py", line 101, in init
self.setup_predict()
File "/Users//neural/biaxial-rnn-music-composition/model.py", line 315, in setup_predict
n_steps=self.steps_to_simulate )
File "/usr/local/lib/python2.7/site-packages/theano/scan_module/scan.py", line 761, in scan
condition, outputs, updates = scan_utils.get_updates_and_outputs(fn(args))
File "/Users//neural/biaxial-rnn-music-composition/model.py", line 295, in step_time
notes_result, updates = theano.scan(fn=self._predict_step_note, sequences=[time_final], outputs_info=note_outputs_info)
File "/usr/local/lib/python2.7/site-packages/theano/scan_module/scan.py", line 1058, in scan
scan_outs = local_op(*scan_inputs)
File "/usr/local/lib/python2.7/site-packages/theano/gof/op.py", line 604, in call
node = self.make_node(*inputs, **kwargs)
File "/usr/local/lib/python2.7/site-packages/theano/scan_module/scan_op.py", line 539, in make_node
inner_sitsot_out.type.dtype))
ValueError: When compiling the inner function of scan the following error has been encountered: The initial state (outputs_info in scan nomenclature) of variable IncSubtensor{Set;:int64:}.0 (argument number 3) has dtype int16, while the result of the inner function (fn) has dtype int8. This can happen if the inner function of scan results in an upcast or downcast.

I ran 'python train.py' and the same problem happened, the raise error is the same. Is there any solutions?

I ran 'python train.py' and the same problem happened, the raise error is the same. Is there any solutions?

I forgot to mention that this happen only when the device is GPU, switching to CPU no error occorse.
Is it a theano issue?

I have no idea but if this model only train on CPU, the time maybe horrible long

My guess is that this was caused by something that changed in a recent release of Theano. I've added an explicit dtype for the offending allocation, which hopefully will fix it. Unfortunately I don't have access to a GPU system right now, so I can't easily test changes. Can you check if my most recent commit resolves the issue?

Closing for now, assuming fixed. Let me know if it still doesn't work after you pull the fix.

I confirm that the issue is fixed after adding the explicit dtype
Unfortunatly, this model is eating lot of memory and I can't finish the training because of "out of memory"
I also confirm that on CPU the training takes really too much time. On iMAC i7 with 16gb of ram for 3 midi files it take something like 5 days
Thank you for the fix

ValueError: When compiling the inner function of scan the following error has been encountered: The initial state (outputs_info in scan nomenclature) of variable IncSubtensor{Set;:int64:}.0 (argument number 3) has dtype int8, while the result of the inner function (fn) has dtype bool. This can happen if the inner function of scan results in an upcast or downcast.
Python 3.7.1
OSX 10.14.4


Weapon_Converter_Check currently not functioning

Has this issue already been reported? Did you ask for help before making this report?

[X] I have searched the existing issues
[X] I have asked for help

Current Behavior
  Weapon_Converter_Check:
  Type: <true/false>
  Name: <true/false>
  Lore: <true/false>
  Enchants: <true/false>

not being applied/activated in game
Expected Behavior
Item converts to weapon if Weapon_Converter_Check conditions are correct on that item.
Steps To Reproduce

Take the default AK-47 config
Add condition: Weapon_Converter_Check:
Type: true
Grab item in-game
Here's example config:
AK-47:
Info:
Weapon_Item:
Type: "FEATHER"
Name: "AK-47"
Lore:
- "Very reliable automatic assault rifle chambered in 7.62mm Soviet."
- "Large caliber ammunition requires skill to control recoil."
- ""
- "Weapon Statistics - 66.5"
- "➣ 68 ⟸ Accuracy"
- "➣ 76 ⟸ Damage"
- "➣ 67 ⟸ Range"
- "➣ 61 ⟸ Fire Rate"
- "➣ 59 ⟸ Mobility"
- "➣ 68 ⟸ Control"
Weapon_Converter_Check:
type: true
(the rest is default AK.yml just leaving it out to save space)

Frequency
100% of the time regardless of condition or item.
Version and Log
https://gyazo.com/915fea5e34925d48c28ec4e4224f39d4
logs_latest (1).log
Anything else?
No response

[11:42:28] [Server thread/INFO]: [WeaponMechanics] New serializer me.deecaad.weaponmechanics.weapon.reload.ammo.AmmoConverter will now override already added serializer me.deecaad.weaponmechanics.weapon.info.WeaponConverter

found it!


Fixes compiler errors for invalid property/function references.

The last commit left compiler errors behind. This fixes the compiler errors and calls what I think should have been the right functions.

I don't think this is relevant any more.
Feel free to reopen, thank you.


Include owner with project responses

I can't think of an instance where we're showing a project without its owner's name and a link to its profile. Can we get owner added to the project include-ables list?
Currently :owner is not a valid include for Project when I try to get /projects/73?include=owner.
Possibly related to #451.

Does it work if you do "owners". I did some work on this, but Restpack is weird about pluralization.

There ya go. Thanks.

Actually, it returns with the user in an owners key, so I have no way of picking it apart as a user. Should it come back under a users key, since its link from the project is type: 'users'?

I don't think there's a good way to do that. I can return a type key inside the owner response?

Yeah, that'll work.


A small problem with the links on coding challenges

When you click on the words on a coding challenge, it goes to /tracks/thecodingchallenge.

Can you give a specific example? I can't reproduce this.

Great! I'm going to close this issue @Heinrich-XIAO please let us know if you still find a problem, thank you!!!