Laravel Sail share via expose doesn't seem to function at all

Laravel Version: 8.29.0
PHP Version: 8.0.2
Database Driver & Version: N/A

Description:
Originally posted as a discussion, but it seems I'm not the only one with this issue so I thought I would escalate into a bug report.
Trying to share my Laravel site with my phone to do some testing via Laravel Sail.
So I type in sail share and get the usual output. When I visit the dashboard URL that appears on my Mac, I get Site cannot be reached.
When I try to visit the URL generated by sail locally and via my phone, I get ERR_EMPTY_RESPONSE in Chrome.
Not sure whats going on? I'm using Docker Desktop for Mac. Am I doing something wrong here?
Steps To Reproduce:

Install Laravel on MacOS
Install Laravel Sail with the PHP 8 runtime
Make sure your Laravel welcome page is showing locally
Run sail share to start sharing your site
See that you cannot visit the shared site with the given link
See that you also cannot see the dashboard

Yeah, can confirm. It's broken for me as well again.

I just tried out a fresh install on macOS and it works for me. I was using an old image it seems. Make sure ALL of your containers/images are cleared before trying again.

I also got it working now after I cleared out all beyondcodegmbh/expose-server images from Docker, thanks!

This is still broken for me after removing/reinstalling the image as recommended. I can get to the expose dashboard where you can follow the requests, but trying to use the expose url without the port gives me a 404, and the url with the port just spins forever and never does anything.

This is still broken for me after removing/reinstalling the image as recommended. I can get to the expose dashboard where you can follow the requests, but trying to use the expose url without the port gives me a 404, and the url with the port just spins forever and never does anything.

This issue exists only on linux hosts. I submitted a pull request to beyondcode/expose repository which fixes the issue.
Link to PR: https://github.com/beyondcode/expose/pull/293

I'm re-opening this issue because I'm getting this error.
Laravel Version: v8.83.0
PHP Version: 8.1.1
OS: MacOs Monterey (M1)
After running sail share --subdomain=account, the response is this:
Trying to use custom domain: account
Thank you for using expose.
Local-URL:		host.docker.internal:80
Dashboard-URL:		http://<IP_ADDRESS>:4040
Expose-URL:		http://account.laravel-sail.site:8080
Expose-URL:		https://account.laravel-sail.site

Remaining time: 00:26:44

But when I opened https://account.laravel-sail.site, It's not working.

This issue has seemed to reappear for me using Windows / WSL2

This is still broken for me after removing/reinstalling the image as recommended. I can get to the expose dashboard where you can follow the requests, but trying to use the expose url without the port gives me a 404, and the url with the port just spins forever and never does anything.

This issue exists only on linux hosts. I submitted a pull request to beyondcode/expose repository which fixes the issue. Link to PR: beyondcode/expose#293

Just to expand on this, as it's still an issue in sail, for Linux users.

Find and open your sail file (spoiler, it's just a bash script): /laravel_app/vendor/laravel/sail/bin/sail
For me it's on line 470, but just search for beyondcodegmbh/expose-server
Then add in --add-host=host.docker.internal:host-gateway into the docker run command.
I put it in between --rm and -p
Save, and re-run sail share

And it should now work.

This is still broken for me after removing/reinstalling the image as recommended. I can get to the expose dashboard where you can follow the requests, but trying to use the expose url without the port gives me a 404, and the url with the port just spins forever and never does anything.

This issue exists only on linux hosts. I submitted a pull request to beyondcode/expose repository which fixes the issue. Link to PR: beyondcode/expose#293

Just to expand on this, as it's still an issue in sail, for Linux users.
1. Find and open your sail file (spoiler, it's just a bash script): `/laravel_app/vendor/laravel/sail/bin/sail`

2. For me it's on line 470, but just search for `beyondcodegmbh/expose-server`

3. Then add in `--add-host=host.docker.internal:host-gateway` into the `docker run` command.
   I put it in between `--rm` and `-p`

4. Save, and re-run `sail share`

And it should now work.

Works for me thanks!


FIX(UI): #8261: Handle Loading States In a Better Way

Describe your changes :

Issue: #8261
Includes:

changes from boolean to number for loader state to account for multiple functions loading data asynchronously
the teams page will now only load once isdataloading is < 0 otherwise the loader is displayed

Changes made to stop incorrect placeholder appearing when there is a delay in API

Type of change :

[ ] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

https://user-images.githubusercontent.com/110955804/197248518-2a9acb38-28ec-459b-ae5a-a511720bacde.mov

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

@Sachin-chaurasiya this needs a review


tab labels

Can I display "project name" or "connection name" in tab labels similar to scripts?

That's not possible now.
This feature request is a duplicate of #18709.


define a global maximum concurrent request limit

Is your feature request related to a problem? Please describe.
In various use cases, I have encountered a challenge with multiple concurrent uploads initiated by the tus-js-client library. This issue has resulted in suboptimal network resource management, leading to inefficient bandwidth allocation and adversely affecting the performance of other critical network operations.
Describe the solution you'd like
I would like to propose the introduction of a global maximum concurrent request feature within the tus-js-client library. This feature would allow to set an upper limit on the number of concurrent uploads permitted across all instances of tus.Upload within a single application. This feature would ensure that the library operates within my desired bandwidth constraints, preventing network congestion, and enhancing overall network performance.
const tus = require('tus-js-client');

// Set the global maximum concurrent uploads limit.
// For simplicity 1 upload = 1 request in this example
tus.setMaxConcurrentRequests(3); // Allow a maximum of 3 concurrent uploads.

// Create tus.Upload instances and start uploads as usual.
const upload1 = new tus.Upload(file1, { endpoint: 'https://example.com/upload' });
const upload2 = new tus.Upload(file2, { endpoint: 'https://example.com/upload' });
const upload3 = new tus.Upload(file3, { endpoint: 'https://example.com/upload' });
const upload4 = new tus.Upload(file4, { endpoint: 'https://example.com/upload' });

upload1.start(); // Starts the first upload.
upload2.start(); // Starts the second upload.
upload3.start(); // Starts the third upload.

// Since the maximum concurrent uploads limit is set to 3, the fourth request
// will be queued and will start once one of the existing requests is completed.
upload4.start(); // Queues the fourth request.

Describe alternatives you've considered
An alternative approach is to upload files one at a time, initiating the next upload using the onError and onSuccess hooks. This ensures controlled, sequential uploads, preventing network congestion and providing predictable resource management.
Additional context
Applications must guarantee consistent, shared network quality of service. By preventing network congestion, it ensures an equitable distribution of resources, safeguarding the performance of both uploads and other vital network operations. I would greatly appreciate the inclusion of this feature within the tus-js-client library.

Thank you for bringing this up and describing the problem in great detail. While I understand the problem, I think that such a concurrency limit should rather be implemented by the user. As you mentioned, one tus upload has a maximum of 1 concurrent request (unless you are using the parallelUploads option). Therefore, one can control the number concurrent requests by managing how many uploads are started in parallel. Such a limit can easily be implemented using a queue or semaphore. The advantage of implementing a request limit outside of tus-js-client is that the user receives more feedback about the upload's state. For example, when an upload is not started because the concurrency limit is reached, the UI can be updated to reflect this fact. When we implement a limit in tus-js-client the user would just see an upload that is not progressing.
Furthermore, if you actually want to limit the number of requests (and not the number of uploads), you can implement this right now using the onBeforeRequest option. It can also return a Promise and by resolving that Promise whenever the concurrency limit allows another request, you can implement the desired functionality.
All in all, I think that there are better alternatives than having this functionality in tus-js-client.

hi @Acconut,
thanks for the reply.

As you mentioned, one tus upload has a maximum of 1 concurrent request (unless you are using the parallelUploads option).

I think I was fooled by the dev tools where I can see 4 pending requests at once for one upload.
const upload = new Upload(file, {
  endpoint: "/api/files",
  chunkSize: 1_000_000,
  retryDelays: [0, 1000, 3000, 5000],
  metadata: {
    filename: file.name,
    filetype: file.type,
    lastModified: file.lastModified.toString(),
  },
};
upload.start();

It can also return a Promise and by resolving that Promise whenever the concurrency limit allows another request.

do you have a repository with such functionality to show me?

I think I was fooled by the dev tools where I can see 4 pending requests at once for one upload.

If you call upload.start() once then there should only ever be one PATCH request. Any other behavior would indicate a bug. Can you reproduce the multiple PATCH requests? Do you call start multiple time?

do you have a repository with such functionality to show me?

No, unfortunately I do not have an example showcasing this.


Can't see all elements

Ubuntu  MATE 15.10, screen size 14, 1366x768.

Tested: Firefox 44.0.2, Chrome 48.0.2564.116, Chromium 48.0.2564.82

Same as in #3388, which I am guessing happened recently with some scrolling changes. Let's track it there.


Abrupt chapter transitions in Thorium

I'm submitting a combination bug report/question.
The Thorium desktop reader on Windows 10 has unexpected behavior (in my opinion) during chapter transitions.  If you flip through a book with many chapters, especially using a two-page spread, you'll notice the following:

Each chapter begins on the left page of the spread.  At the end of the chapter, there's often a blank right-hand side column, so the next chapter begins on the next left-hand page.

When you reach an end-of-the-chapter spread that has a blank right column, the animation for the page transition doesn't look right.  The ending text in the chapter seems to emerge from the center of the spread and move into the left column.

When you flip the spread to the next chapter, there isn't a page-turn animation.  The new chapter just shows up immediately.

It seems that Thorium is simply taking each chapter as a separate HTML document and displaying them one at a time.  It doesn't cache the next chapter to be read inline with the current chapter.  This makes the reading experience seem "weird," in my opinion.
Are there any workarounds in JavaScript for these behaviors?  In particular, is there some preferred way to cache the next chapter so that it is shown on the same spread as the previous chapter?  In other words, to display the start of the next chapter in the right-hand column instead of showing an empty column?
One option would simply be to concatenate the chapters together in the DOM to form a single HTML page that represents the entire book.  That seems like a bad idea for memory and performance, though.  It would also upset the authors' intentions if (for some reason) they have different CSS styles in different chapters, since only the CSS from one chapter would be used.
Thanks very much for any insights.

Hello again @RobJacobson ! :)

Each chapter begins on the left page of the spread. At the end of the chapter, there's often a blank right-hand side column, so the next chapter begins on the next left-hand page.

When a reflowable HTML document is laid out with two-page spreads, an odd number of synthetic pages ("columns") logically results in an empty right-hand-side page slot inside the last spread (in other words, the last synthetic page of the HTML document is displayed in the left-hand-side slot of the spread ... the rest is just blanking space).
The rendering engine makes no attempt to collate adjacent "chapters" / EPUB spine items side-by-side in a seamless manner. This Readium implementation currently does not support laying out multiple webviews (i.e. containers for contiguous HTML documents) inside the viewport, so only a single chapter is displayed at any given time.

When you reach an end-of-the-chapter spread that has a blank right column, the animation for the page transition doesn't look right. The ending text in the chapter seems to emerge from the center of the spread and move into the left column.

Indeed. Due to technical limitations with the way CSS Columns are laid out in the HTML body, in cases where a paginated reflowable document results in an odd number of synthetic pages, and the document is rendered as two-page spreads, a CSS trick is used to shift the last column into its dedicated slot (i.e. the left-hand side of the spread). The right-hand-side empty space is in fact not a part of the currently-rendered document, it is literally space-filler (thus why the tail end of the HTML document appears to scroll into view from the middle of the page spread).

When you flip the spread to the next chapter, there isn't a page-turn animation. The new chapter just shows up immediately.

Yes indeed, inter-"chapter" transitions (i.e. seamless visual effect between adjacent EPUB spine items) is not supported due to displaying only a single webview container in the viewport. Conversely, intra-"chapter" transitions (i.e. horizontal scroll animation between synthetic pages / CSS columns) occur within a given webview container.

One option would simply be to concatenate the chapters together in the DOM to form a single HTML page that represents the entire book. That seems like a bad idea for memory and performance, though. It would also upset the authors' intentions if (for some reason) they have different CSS styles in different chapters, since only the CSS from one chapter would be used.

Indeed :)
The "safe" method to create the visual effect of instant inter-"chapter" transition is to prefetch and pre-render adjacent pre- and post- HTML documents in their own respective webviews, using a pool of reusable webviews in order to mitigate the inevitable performance degradation. There are also issues with CSS animations and/or Javascript behaviours that should only be started when documents come into view (i.e. not whilst they are loaded "in the background" / out of view). Note that even if this Readium implementation continues to limit a single webview per viewport (i.e. no seamless adjacent EPUB spine items), using pre-loaded webviews instead of loading a single one on-demand would yield significant "perceived performance" improvements (i.e. smoother, more pleasant user experience).
So, this feature was considered in previous development iterations, but there were technical challenges at the time (i.e. older version of Electron / Chromium), and this was considered a "nice to have" feature compared with higher-priority todo list items. I will try to revisit this problem space later next year, but we already have a pretty crowded development plan in Q1, so I would rather not give an ETA. Note that this work might overlap with the planned improvements of support for fixed-layout EPUBs (this Readium implementation currently only supports single-page FXL rendering)

Thank you so much for the detailed explanations!  I'm glad this is on your radar.  I understand the technical rational (CSS multicol has limitations).  But for an optimal book-like reading experience, it seems desirable to have the option of showing facing pages from two chapters on a spread.
For what it's worth, I noticed that the Vivliostyle Viewer allows this feature.  However, I haven't studied their rendering engine to know how it works (whether CSS multicol or something else).
Thanks for maintaining this great project!

Could I revisit the issue of having a two-page spread that spans two chapters?  I've been thinking about this problem space and doing some research.  I could perhaps work on the issue and submit a pull request, but I'm not sure even where to start.
Both Vivliostyle Viewer and Kindle Cloud Reader can show two chapters on facing pages.  But when I looked into their implementations, they're not using CSS multicol for their layouts.  Instead, they seem to do layout the "hard way" by parsing the HTML into spans of individual words and then determining how many spans can fit on a single page.
To get this working with CSS multicol, the chief problem seems to be determining either "how many column boxes does this chapter require?" or, equivalently, "does the content end on a left page or a right page?"  If a chapter starts on the left-hand side and has an odd number of "pages," then the chapter ends on a left-hand page.  Thus, there would be space to begin a new chapter on the next right-hand page.  You could potentially use a pool of just two WebViews, one to show the current chapter and the other for the next chapter.
However, I can't find any way to count the number of required "pages" with CSS/JavaScript.  According to this article, CSS multicol does not expose many properties to JavaScript, and I couldn't find any that would support this calculation.
Would you have any general ideas about how to approach this problem?  If you could point me in the right direction, I could try to run with it.
Thanks again!

One other thought:
It might be worth exploring and testing whether it's practical to combine all of the chapters/spine items into a single HTML page in the DOM:

Memory and performance:  This approach could conceivably degrade performance for the browser/WebView.  Since most epub books are fairly small, though, this might be more of a theoretical problem (especially on desktops or notebooks with ample CPU and memory resources).  There might be edge cases for books that have high-resolution photos or embedded videos, but those seem to be uncommon.  It might be interesting to compare the performance of the current implementation (i.e., many spine items) versus this proposal (a single, monolithic spine item that gets rendered).

Different CSS styles for different chapters:  If different chapters have different CSS styles, we could develop a parser or preprocessor that detects these differences and creates unique styles for each spine item.  E.g., if there are different styles for  between Chapter 1 and Chapter 2, we could programmatically create a single stylesheet with separate classes for "Chapter1 p" and "Chapter2 p."  This would also conceivably degrade performance, but it might be worth testing to see if this degredation is real or just hypothetical in the typical case.

Concerning "CSS animations and/or Javascript behaviours that should only be started when documents come into view":  That's a valid concern, but it might also be an edge case.  This might also be a concern with the current implementation, insofar as an element on, e.g., page 19 of a particular chapter won't come into view immediately, but only after the user reads pages 1-18.  Does Readium currently have a mitigation against this issue within individual chapters?

Thanks again!

There doesn't seem to be any interest here, so I'll close the issue.  I hope you can get this working.


Breaking the Tabs

I broke the tabs when playing around with your app. Upon fullscreening the app again, the tabs decide to show themselves under the close and minimize buttons. IMPORTANT: Like I said, it only happens after fullscreening the app again. I have uploded a video of how to do it:
Video.zip
OS: Windows 10 Pro 10.0.19042 Build 19042(I am in the Windows Beta Insider programme).
App Version: <IP_ADDRESS>

@RadioActiveEssence This is intended and not a bug if you select the 'Adaptive' option in multitasking. When in a small window size, you can access the tabs by pressing the button next to the disabled search box.

@Jaiganeshkumaran So you intend for the tabs to show below the close buttons making them hard to reach?

@RadioActiveEssence That shouldn't happen.

Here is a better video of how it happens. My OBS Studio wasn't working so I used a different recording software.
Uploading Vid.zip…

@RadioActiveEssence This issue appears to be resolved in main.


aws_ranges module

Returns a list of AWS IP address ranges for
composing security group rules involving AWS
assets.

The PYCA team should have a better implementation of this using a Python script now
There is a terraform resource that does this ; the reason for doing it "again" is that the ranges for "AMAZON" include all of EC2, which means you get too many CIDR blocks to fit in a single security group rule (limit 50 by default) if you just want to e.g. whitelist AWS service endpoints, depending on the region (e.g. eu-west-1 will produce at least 78 blocks for "AMAZON", many of which are devoted to EC2)


A question about vocabulary size

i want to know why vocabulary size is set to |V| = 8192 ？
thank you~~

Hi,
This is a choice that OpenAI made when creating DALL-E. From the paper:

We use a large vocabulary size of 8192 to mitigate the loss of information. (...) This reduces
the context size of the transformer by a factor of 192 without a large degradation in visual quality.

Ok thank you~ I will read this paper~


Added example fields to example_event schema and update to README.md

Added description to example_event schema.
Added null on non-required field on example_event schema.
Updated README.md and removed severity level text.

Thank you @joaolcorreia !
These changes have been included in https://github.com/snowplow/iglu-example-schema-registry/pull/11 .
Closing.


Feature/branding palette

Fixes #21

Changes proposed in this Pull Request:

Add reasonable contrast palette so brand-color palettes can be integrated into angular apps.

How were those colors decided? I assume that you plug those colors in some contrast checker to maximize the contrast?

Our UI Color palette just uses contrastDefaultColor with a value of 'light' or 'dark'. I assume this is more granular because some shades need a dark and some need a light? Should we say 'dark' and 'light' instead of hardcoding black and white? How do these contrast colors get used in the theme?

I read some of this article  and this was the insightful:
"It can be useful to retrieve appropriate contrast color when using main color as a background for some component which also contains text. In that case we can retrieve corresponding contrast color, eg: mat-color($primary, lighter-contrast) for backgrounds which mat-color($primary, lighter)."

How were those colors decided? I assume that you plug those colors in some contrast checker to maximize the contrast?

I just went into this color picker and looked for the tipping point when black or white provides a higher contrast.
https://contrast-ratio.com/#black-on-%23e88b14
I just pushed out a fix for any colors that weren't using the correct contrast.

Should we say 'dark' and 'light' instead of hardcoding black and white? How do these contrast colors get used in the theme?

What I did was update the branding colors so they could be used in the angular themes, our @pxblue/colors palette.scs also has a contrast section in each color..
I'm not sure how the light or dark attribute is used, but it doesn't seem like it's required since it' an optional param.  I'm unfamiliar with what that attribute does in non-angular projects.

Should we say 'dark' and 'light' instead of hardcoding black and white? How do these contrast colors get used in the theme?

What I did was update the branding colors so they could be used in the angular themes, our @pxblue/colors palette.scs also has a contrast section in each color.
I'm not sure how the light or dark attribute is used, but it doesn't seem like it's required since it' an optional param. I'm unfamiliar with what that attribute does in non-angular projects.

👍 I was looking it the colors.ts file...forgot we have different files for angular and react.

This looks good to me if you just want to update the publish date (maybe to tomorrow depending on how fast you think you can get two approvals on a master PR)

I'm going to try to publish these changes today.  I've updated the changelog for today's date.


crash in iOS 8

_textView = [[SAMTextView alloc] init];
_textView.translatesAutoresizingMaskIntoConstraints = NO;
_textView.backgroundColor = [UIColor lightTextColor];
_textView.editable = YES;
_textView.placeholder = @"What happened?";

It seems crashed in all versions!
Because i have not set FONT attribute.

Oh good find. Can you send a PR with a fix?


Add in ID to the API responses

Adds in ID to location info, client ISP in location info, time series metrics for location and client ISP in location.

ping @vlandham

+1


Feature Request: Crop & Rotation

Hi, thank you for this amazing lovelace card!
Is it possible to add the crop function? https://github.com/Hypfer/ICantBelieveItsNotValetudo/issues/7 => https://github.com/Hypfer/ICantBelieveItsNotValetudo/pull/8
Also rotation would be amazing!
With both of these functions, the map can be integrated very space efficient :)
Thank you in advance!

Rotation seems much easier to implement in CSS3 so I'll probably get to that first. I'll have to think a bit on how to best tackle the cropping thing in my implementation, but it definitely sounds doable to add

Rotation support was added in 3d6343c635efb2326369df823e915ed93a0c6e99

Thank you very much!
I noticed an issue with the rotation:

When the card is rotated, the height of the card stays the same, because of which I get bigger padding in the top and bottom.
(I also have map_scale: 1.5, if that matters)

Basic cropping was added in f122fe987477d444017641b09a8dc0351354b8f6.
I'll take a look at the rotation issue soon, thanks!

I hope 1d45c813f3813aa1652f19cdd0ee41a0b595bdf4 mitigates the rotation issue. If it doesn't, I'm going to have to tag this issue with "help wanted". I don't normally develop webpages so my HTML/CSS/JavaScript is quite rusty :)

Wow, you're fast! 😄
Quick feedback: The cropping itself works flawless! The only issue is, that the map keeps the same size and position. So as you can see in the picture above, the map is more on the right side (especially now after cropping my balcony in the lower left corner away). It would be perfect, if the lovelace card fits exactly to the cropped map size (so that there's minimal to no padding between the cropped map and the lovelace card border)

The rotation got very weird now: rotation: 0 & rotation: 90 does look the same (original orientation). To rotate it to 90° I had to use rotation: 45 - and the weirdest thing: After that I got a scrollbar for the whole lovelace card column:

I can take a look and try to help - but my development skills are rudimentary in general ;)

Quick feedback: The cropping itself works flawless! The only issue is, that the map keeps the same size and position. So as you can see in the picture above, the map is more on the right side (especially now after cropping my balcony in the lower left corner away). It would be perfect, if the lovelace card fits exactly to the cropped map size (so that there's minimal to no padding between the cropped map and the lovelace card border)

Yup, I've been lazy there, I'll take a better look at that later. Release early, release often and all :)

The rotation got very weird now: rotation: 0 & rotation: 90 does look the same (original orientation). To rotate it to 90° I had to use rotation: 45 - and the weirdest thing: After that I got a scrollbar for the whole lovelace card column

Not sure what caused the scrollbar, but the rotation should be fixed again in e546cbe412b91c961a3bdef454f17bbb53d85799, whoops.

I think I found the problem (can't test it right now):
You have two selectors: div and div div. The latter selects a div container inside a div container - but the first one selects the outer and the inner div and doubles the effect.

You were faster :D I test it in 20 minutes!

Now the new issues are gone, but the card height stays the same as before :/
Brainstorming: I want to propose a different approach -  what about let the user set a fixed aspect ration like in the map card (e.g. 3:2). Then there's rotation, left_offset, right_offset (which are already in your code, as I can see) & scale with which the user can move and resize the map inside the canvas to make it fit.
If you don't like the idea (or think it's not viable) just ignore it ;)

Sounds quite complex, I'm hoping for something simpler honestly. It's probably just some small overflow issue I can easily fix with some CSS once I remember the right statements.
The offset is a different thing though, it's for translating the position of the vacuum and dock to the map because it uses another metric ("points" instead of pixels).
I'm sure it'll be fixed nicely at some point, either by me remembering how or by someone else making a pull request :)

I created a https://github.com/TheLastProject/lovelace-valetudo-map-card/tree/fix/sizing branch, which makes cropping behave right about perfectly. However, when combined with rotation, things are even worse than before and cropping behaves very strangely. I'm afraid some other person will have to come along to fix this all.

Ehh, I'll just commit it to master I guess and make a new issue.


Docker version tags

Hi Peter,
it would be nice when you could create a docker version tag.
We want to use the backup container in several places and thus avoid future update problems due to a latest tag.
Greetings

Hi Julian,
Great suggestion. I have rebuilt and tagged the current version manually for now but I should probably set up something a bit more automated (like https://medium.com/travis-on-docker/how-to-version-your-docker-images-1d5c577ebf54). I will do that as soon as I push a new version.


Runelite crashes randomly without warning or error message popup

Type
Crash or hang
Operating System
Windows
OS Version
Windows 10
Bug description
Just playing TOA, but also during other pvm/skilling it crashes. See the crashlog attached..
Screenshots or videos
.
RuneLite version
Runelite version: last version
Logs
jvm_crash_pid_8612.log
jvm_crash_pid_12460.log

Hi @Nightfirecat,
Thanks for your reply!
I will run RL in safemode for today and will get back to you.

@Nightfirecat Doesn't seem to crash in Safe Mode for now (+/- 3h played). Normally it only happens once a day.


ExplorerViewlet triggers two layouts on load

While profiling the startup of VS Code with the open editors view visible, I noticed that the ExplorerViewletViewsContribution ends up firing two events about updating view visibility:

Each of these takes ~25ms to complete

registerViews
updateOpenEditorsVisibility

I suspect that the two events can be batched together so that we avoid doing the costly re-layout twice

@isidorn I was looking into this and found the following OpenEditorsVisibleContext context key around open editors:
https://github.com/microsoft/vscode/blob/34cba75c513878d683004561c799dd5cd13f5222/src/vs/workbench/contrib/files/common/files.ts#L52
It is false by default but then will in most cases immediately be set to true based on this:
https://github.com/microsoft/vscode/blob/34cba75c513878d683004561c799dd5cd13f5222/src/vs/workbench/contrib/files/browser/explorerViewlet.ts#L166-L168
Unless a user has explorer.openEditors.visible set to 0, which is not the default.
To fix this issue I think flipping the default would be sufficient. However, I have general questions around this and maybe you recall: why do we even bother to hide the "Open Editors" view from the right click menu conditionally based on this context key? And isn't the name of the context key misleading? I would assume openEditorsVisible is about visibility of the view in the explorer viewlet but not about if I can pick it to show or not.
My 2 cents (without knowing the history of this) is to remove the context key and simply always to show the "Open Editors" view when you select it here but have it hidden by default:

@bpasero sorry but I do not recall the details. My feeling is that this was done specially for the Open Editors before we had all the nice view visibility mechanisms in VS Code.
Any change here I am fully supportive off. Thus as you suggest let's remove the context key. And let's change explorer.openEditors.visible to not support 0 👏
It is hidden by default so we are good.
fyi @lramos15 who now owns the Open Editors view.


Activate host net containers on kubernetes.

This PR activates pods with property hostNetwork set to true in K8s pod specifications. Such pods are activated as single LinuxProcessPU. All the other container in the pods are added to the same cgroup as of the pause container.

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "kube_host",
    "component": "trireme-lib",
    "pr-id": "689",
    "commit-sha": "e5d8012c979f4f8e29ea2739f967b10735264724"
  },
  {
    "project": "kube_host",
    "component": "enforcerd",
    "pr-id": "915",
    "commit-sha": "be80bfda5de58f5ef5e28db3c37d1edca74c722b"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "kube_host",
    "component": "trireme-lib",
    "pr-id": "689",
    "commit-sha": "ec29f396986b550996c54fc41c03c16743aedcec"
  },
  {
    "project": "kube_host",
    "component": "enforcerd",
    "pr-id": "915",
    "commit-sha": "dee4c2026f0dfb72b344556eaf9d7b2deb466b10"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "kube_host",
    "component": "trireme-lib",
    "pr-id": "689",
    "commit-sha": "ec29f396986b550996c54fc41c03c16743aedcec"
  },
  {
    "project": "kube_host",
    "component": "enforcerd",
    "pr-id": "915",
    "commit-sha": "4130121d100c04e01440c0055f98aac3496af04a"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "kube_host",
    "component": "trireme-lib",
    "pr-id": "689",
    "commit-sha": "e826b345c200ebd2930e3b94ec024cea845bae41"
  },
  {
    "project": "kube_host",
    "component": "enforcerd",
    "pr-id": "915",
    "commit-sha": "9a9ad104135a007bb0b23b39e09e617559073963"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "kube_host",
    "component": "trireme-lib",
    "pr-id": "689",
    "commit-sha": "59714caa53d031bfc281f6982f29e8ca8a1c71ae"
  },
  {
    "project": "kube_host",
    "component": "enforcerd",
    "pr-id": "915",
    "commit-sha": "9a9ad104135a007bb0b23b39e09e617559073963"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "kube_host",
    "component": "trireme-lib",
    "pr-id": "689",
    "commit-sha": "ef9f102ba027100a65927ae925fcf0afb4018e03"
  },
  {
    "project": "kube_host",
    "component": "enforcerd",
    "pr-id": "915",
    "commit-sha": "9a9ad104135a007bb0b23b39e09e617559073963"
  }
]


Add wallet sorting props to MUI wallet selector

Added sortDefaultWallets and sortMoreWallets props to WalletConnector.
Exposed WalletConnectorProps interface.

This will be used to place Petra at the top of the wallets list in Aptos Names and Explorer.

Do dapps manually config the order of the wallets?

Do dapps manually config the order of the wallets?

They can with these props, but it's optional.


Unable to execute 'frank launch' command

I am trying to launch frank on 2012 Olympics code build however getting the following error:-
➜  2012 Olympics git:(master) ✗ frank launch
WARN: Unresolved specs during Gem::Specification.reset:
rake (>= 0)
WARN: Clearing out unresolved specs.
Please report a bug if this causes problems.
LAUNCHING APP...
/Library/Ruby/Gems/2.0.0/gems/sim_launcher-0.4.13/lib/sim_launcher/simulator.rb:104: warning: Insecure world writable dir /usr/share/node/js in PATH, mode 040777
sh: line 1:  6110 Trace/BPT trap: 5       /Library/Ruby/Gems/2.0.0/gems/sim_launcher-0.4.13/lib/sim_launcher/../../native/ios-sim "showsdks" 2>&1
sh: line 1:  6114 Segmentation fault: 11  /Library/Ruby/Gems/2.0.0/gems/sim_launcher-0.4.13/lib/sim_launcher/../../native/ios-sim "launch" "/Users/rohit/Documents/MEA/mauto/2012-Olympics-iOS--iPad-and-iPhone--source-code/2012 Olympics/Frank/frankified_build/Frankified.app" "--tall" "--retina" "--sdk" "--family" "iphone" "--exit" 2>&1
I also tried updating file simulator.rb with run_synchronous_command() as suggested in frank issue 272 however no luck:-
https://github.com/moredip/Frank/issues/272
PS: I am successfully able to complete steps before frank launch using steps at the following url:-
http://blog.thepete.net/blog/2012/06/24/writing-your-first-frank-test/
Appreciate any help so that I can execute launch and inspect frank commands please.
Regards
Rohit

Tried couple of things, no luck. Still running into same issue.

Updated the sim_launcher (0.5.0) but later it conflicts with frank build

/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/dependency.rb:296:in `to_specs': Could not find 'sim_launcher' (~> 0.4.6) - did find: [sim_launcher-0.5.0] (Gem::LoadError)

Updated frank to latest, thinking it will refer latest sim_launcher. But it doesn't seem to be the case.

Would be great if someone can look at it and fix the issue at the earliest.
Regards,
Vijay

Looks like with brew install ios-sim, above issue is fixed. Able to launch the app using frank now.
brew install ios-sim
@sonir6  - Perhaps you can give it a try.


Can't create provisioning profiles

New Issue Checklist

[ ☑ ] Updated fastlane to the latest version
[ ☑ ] I read the Contribution Guidelines
[ ☑ ] I read docs.fastlane.tools
[ ☑ ] I searched for existing GitHub issues

Issue Description
I'm trying to integrate fastlane to my iOS project and I got stuck in creating the provisioning profiles things
Command executed
fastlane match development
Complete output when running fastlane, including the stack trace and command used
alprimecap-ios/AlprimeCap on  Development [!?] via 💎 v3.2.0 took 36s
❯ fastlane match development
[✔] 🚀
[00:22:17]: Successfully loaded '/Users/ewaily/Development/alprimecap-ios/AlprimeCap/fastlane/Matchfile' 📄
+-----------------------------------------------------------------+
|           Detected Values from './fastlane/Matchfile'           |
+----------------+------------------------------------------------+
| git_url        | git@bitbucket.org:trianglz/fastlane-ios-certi  |
|                | ficates.git                                    |
| storage_mode   | git                                            |
| type           | development                                    |
| app_identifier | ["com.Trianglz.AlprimeCap.Stg"]                |
| username       |<EMAIL_ADDRESS>                    |
| team_id        | R82929T5X5                                     |
+----------------+------------------------------------------------+
+-----------------------------------------------------------------------------------------+
|                                Summary for match 2.218.0                                |
+----------------------------------------+------------------------------------------------+
| type                                   | development                                    |
| readonly                               | false                                          |
| generate_apple_certs                   | true                                           |
| skip_provisioning_profiles             | false                                          |
| app_identifier                         | ["com.Trianglz.AlprimeCap.Stg"]                |
| username                               |<EMAIL_ADDRESS>                    |
| team_id                                | R82929T5X5                                     |
| storage_mode                           | git                                            |
| git_url                                | git@bitbucket.org:trianglz/fastlane-ios-certi  |
|                                        | ficates.git                                    |
| git_branch                             | master                                         |
| shallow_clone                          | false                                          |
| clone_branch_directly                  | false                                          |
| skip_google_cloud_account_confirmation | false                                          |
| s3_skip_encryption                     | false                                          |
| gitlab_host                            | https://gitlab.com                             |
| keychain_name                          | login.keychain                                 |
| force                                  | false                                          |
| force_for_new_devices                  | false                                          |
| include_mac_in_profiles                | false                                          |
| include_all_certificates               | false                                          |
| force_for_new_certificates             | false                                          |
| skip_confirmation                      | false                                          |
| safe_remove_certs                      | false                                          |
| skip_docs                              | false                                          |
| platform                               | ios                                            |
| derive_catalyst_app_identifier         | false                                          |
| fail_on_name_taken                     | false                                          |
| skip_certificate_matching              | false                                          |
| skip_set_partition_list                | false                                          |
| verbose                                | false                                          |
+----------------------------------------+------------------------------------------------+
[00:22:17]: Cloning remote git repo...
[00:22:17]: If cloning the repo takes too long, you can use the clone_branch_directly option in match.
[00:22:20]: Checking out branch master...
[00:22:20]: 🔓  Successfully decrypted certificates repo
[00:22:20]: Verifying that the certificate and profile are still valid on the Dev Portal...
Available session is not valid anymore. Continuing with normal login.
[00:22:25]: Couldn't find a valid code signing identity for development... creating one for you now
+--------------------------------------------------------------------------+
|                         Summary for cert 2.218.0                         |
+-------------------------+------------------------------------------------+
| platform                | ios                                            |
| development             | true                                           |
| generate_apple_certs    | true                                           |
| force                   | true                                           |
| username                |<EMAIL_ADDRESS>                    |
| team_id                 | R82929T5X5                                     |
| keychain_path           | /Users/ewaily/Library/Keychains/login.keychai  |
|                         | n-db                                           |
| skip_set_partition_list | false                                          |
+-------------------------+------------------------------------------------+
[00:22:25]: Starting login with user<EMAIL_ADDRESS>Available session is not valid anymore. Continuing with normal login.
[00:22:29]: Successfully logged in
[00:22:30]: Enter the password for /Users/ewaily/Library/Keychains/login.keychain-db
[00:22:30]: This passphrase will be stored in your local keychain with the name fastlane_keychain_login and used in future runs
[00:22:30]: This prompt can be avoided by specifying the 'keychain_password' option or 'MATCH_KEYCHAIN_PASSWORD' environment variable
[00:22:30]: Password for login keychain: *********
[00:22:35]: Type password for login keychain again: *********
[⠋] Setting key partition list... (this can take a minute if there are a lot of keys installed) keychain: "/Users/ewaily/Library/Keychains/login.keychain-db"
version: 512
class: "inet"
attributes:
0x00000007 ="fastlane_keychain_login"
0x00000008 =
"acct"=
"atyp"="dflt"
"cdat"=0x32303234303130333232323233385A00  "20240103222238Z\000"
"crtr"=
"cusi"=
"desc"=
"icmt"=
"invi"=
"mdat"=0x32303234303130333232323233385A00  "20240103222238Z\000"
"nega"=
"path"=
"port"=0x00000000
"prot"=
"ptcl"=0x00000000
"scrp"=
"sdmn"=
"srvr"="fastlane_keychain_login"
"type"=
password has been deleted.
[00:22:38]:
[00:22:38]: Could not configure imported keychain item (certificate) to prevent UI permission popup when code signing
Check if you supplied the correct keychain_password for keychain: /Users/ewaily/Library/Keychains/login.keychain-db
security: SecKeychainItemSetAccessWithPassword: The user name or passphrase you entered is not correct.
[00:22:38]:
[00:22:38]: Please look at the following docs to see how to set a keychain password:
[00:22:38]:  - https://docs.fastlane.tools/actions/sync_code_signing
[00:22:38]:  - https://docs.fastlane.tools/actions/get_certificates
[✔] Setting key partition list... (this can take a minute if there are a lot of keys installed)
[00:22:38]: Enter the password for /Users/ewaily/Library/Keychains/login.keychain-db
[00:22:38]: This passphrase will be stored in your local keychain with the name fastlane_keychain_login and used in future runs
[00:22:38]: This prompt can be avoided by specifying the 'keychain_password' option or 'MATCH_KEYCHAIN_PASSWORD' environment variable
[00:22:38]: Password for login keychain: *********
[00:22:42]: Type password for login keychain again: *********
[⠋] Setting key partition list... (this can take a minute if there are a lot of keys installed) keychain: "/Users/ewaily/Library/Keychains/login.keychain-db"
version: 512
class: "inet"
attributes:
0x00000007 ="fastlane_keychain_login"
0x00000008 =
"acct"=
"atyp"="dflt"
"cdat"=0x32303234303130333232323234355A00  "20240103222245Z\000"
"crtr"=
"cusi"=
"desc"=
"icmt"=
"invi"=
"mdat"=0x32303234303130333232323234355A00  "20240103222245Z\000"
"nega"=
"path"=
"port"=0x00000000
"prot"=
"ptcl"=0x00000000
"scrp"=
"sdmn"=
"srvr"="fastlane_keychain_login"
"type"=
password has been deleted.
[00:22:45]:
[00:22:45]: Could not configure imported keychain item (certificate) to prevent UI permission popup when code signing
Check if you supplied the correct keychain_password for keychain: /Users/ewaily/Library/Keychains/login.keychain-db
security: SecKeychainItemSetAccessWithPassword: The user name or passphrase you entered is not correct.
[00:22:45]:
[00:22:45]: Please look at the following docs to see how to set a keychain password:
[00:22:45]:  - https://docs.fastlane.tools/actions/sync_code_signing
[00:22:45]:  - https://docs.fastlane.tools/actions/get_certificates
[✔] Setting key partition list... (this can take a minute if there are a lot of keys installed)
[00:22:45]: Successfully generated 428CZYM6Y7 which was imported to the local machine.
[00:22:45]: Verifying the certificate is properly installed locally...
[00:22:45]: Successfully installed certificate 428CZYM6Y7
[00:22:47]: Error setting value '[]' for option 'cached_profiles'
-->

 [REPLACE THIS WITH YOUR INFORMATION]

Environment
🚫 fastlane environment 🚫
Stack

Key
Value

OS
14.2.1

Ruby
3.2.0

Bundler?
true

Git
git version 2.39.3 (Apple Git-145)

Installation Source
~/.rvm/gems/ruby-3.2.0/bin/fastlane

Host
macOS 14.2.1 (23C71)

Ruby Lib Dir
~/.rvm/rubies/ruby-3.2.0/lib

OpenSSL Version
OpenSSL 3.2.0 23 Nov 2023

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
15.1

Swift Version
5.9.2

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

platform :ios do
  desc "Description of what the lane does"
  lane :custom_lane do
    # add actions here: https://docs.fastlane.tools/actions
  end
end

`./fastlane/Appfile`
# app_identifier("[[APP_IDENTIFIER]]") # The bundle identifier of your app
# apple_id("[[APPLE_ID]]") # Your Apple Developer Portal username

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem
Version
Update-Status

fastlane
2.218.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

error_highlight
0.5.1

did_you_mean
1.6.3

syntax_suggest
1.0.2

executable-hooks
1.6.1

bundler-unload
1.0.2

rubygems-bundler
1.4.5

bundler
2.5.3

pathname
0.2.1

rake
13.1.0

rexml
3.2.6

CFPropertyList
3.0.6

public_suffix
5.0.4

addressable
2.8.6

artifactory
3.0.15

atomos
0.1.3

aws-eventstream
1.3.0

aws-partitions
1.877.0

aws-sigv4
1.8.0

jmespath
1.6.2

aws-sdk-core
3.190.1

aws-sdk-kms
1.75.0

aws-sdk-s3
1.142.0

babosa
1.0.4

claide
1.1.0

colored
1.2

colored2
3.1.2

highline
2.0.3

commander
4.6.0

declarative
0.0.20

digest-crc
0.6.5

domain_name
0.6.20231109

dotenv
2.8.1

emoji_regex
3.2.3

excon
0.109.0

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

multipart-post
2.3.0

faraday-multipart
1.0.4

faraday-net_http
1.0.1

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

faraday-retry
1.0.3

ruby2_keywords
0.0.5

faraday
1.10.3

http-cookie
1.0.5

faraday-cookie_jar
0.0.7

faraday_middleware
1.2.0

fastimage
2.3.0

gh_inspector
1.1.3

google-cloud-env
2.1.0

jwt
2.7.1

multi_json
1.15.0

os
1.1.4

signet
0.18.0

googleauth
1.9.1

httpclient
2.8.3

mini_mime
1.1.5

trailblazer-option
0.1.2

uber
0.1.0

representable
3.2.0

retriable
3.1.2

webrick
1.8.1

google-apis-core
0.11.2

google-apis-androidpublisher_v3
0.54.0

google-apis-playcustomapp_v1
0.13.0

google-apis-iamcredentials_v1
0.17.0

google-apis-storage_v1
0.29.0

google-cloud-errors
1.3.1

google-cloud-core
1.6.1

google-cloud-storage
1.45.0

json
2.7.1

mini_magick
4.12.0

naturally
2.2.1

optparse
0.4.0

plist
3.7.1

rubyzip
2.3.2

security
0.1.3

simctl
1.6.10

terminal-notifier
2.0.0

unicode-display_width
2.5.0

terminal-table
3.0.2

tty-screen
0.8.2

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

nanaimo
0.3.0

xcodeproj
1.23.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

generated on: 2024-01-04

same on me, I think we need to use ci system with and without fastlane.

Looks like this issue is fixed in https://github.com/fastlane/fastlane/pull/21766.

Looks like this issue is fixed in #21766.

@arc-v2  I'm not working with Circle CI at the moment

Looks like this issue is fixed in #21766.

@arc-v2 I'm not working with Circle CI at the moment

@Ewaily That issue is a regression with 'fastlane match' since 2.218.0, it is not specific to circle CI. Can you try it with an older version of fastlane?

Looks like this issue is fixed in #21766.

@arc-v2 I'm not working with Circle CI at the moment

@Ewaily That issue is a regression with 'fastlane match' since 2.218.0, it is not specific to circle CI. Can you try it with an older version of fastlane?

@arc-v2  thank you! I'll try to downgrade the fastlane version

@arc-v2  Downgrading to version 2.217.0 did work thank you!

@arc-v2  @Ewaily
downgraded to v 2.217.0 - but still have same
security create-keychain -p "" /Users/runner/Library/Keychains/login.keychain || echo "login.keychain already exists"
security unlock-keychain -p "" /Users/runner/Library/Keychains/login.keychain
security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "" /Users/runner/Library/Keychains/login.keychain
security: SecKeychainItemSetAccessWithPassword: The user name or passphrase you entered is not correct.
keychain: "/Users/runner/Library/Keychains/login.keychain-db"


Joining a channel?

I'm probably just missing this, but how can I get my bot to join a channel and listen to messages from that channel?

Hi,
Thanks for reaching out. You can make your bot join a channel but just inviting it to the channel by typing /invite @botname or programmatically you can use this method which is part of slack web api.
Hope it makes things clear!

I wasn't aware it was this simple. Thanks for the quick response!

No problem @hdt80 :)

Hey, I recently found this http://stackoverflow.com/questions/29309114/how-to-join-a-slack-channel-as-a-real-time-messaging-bot-user. If this is true then my first answer is correct but the 2nd isn't (JFYI).


The 'platform channel move' command example is incorrect. It shows only one argument but there should be two.

Revise this example to show the team argument. Also revise the format section to include the required arguments, i.e. platform channel move {channel} {team}

This command no longer exists and the channel move command has been replaced with mmctl channel move: https://docs.mattermost.com/manage/mmctl-command-line-tool.html#mmctl-channel-move. Closing. :)


feat: mode command

mode command : endgame
Now shipped with pointers to function, enums and bitmasks

@vfurmane stop bullying me plz just merge the PR


Ability to recover the writer

I need to store the Encoder in a struct, and this prevents me from using a writer by reference (it'd become a self-referential struct).
Additionally, the new method allows handling of the last write.

I've considered using Option, but the writer is used in several places, sometimes interleaved with other self. method calls which prevent unwrapping it once per function. Frequent unwrapping seemed like a more disruptive change.

Sorry for not commenting before this was merged, but I'm concerned that this increases the amount of unsafe blocks in the crate by 3x.

@fintelia Note that this is inherent, as Rust does not allow destructuring of types with Drop. Otherwise, yes, I would agree with more fervently trying to find a different solution.


Skypanther slackform

I was a bum and had changes that I didn't push. @skypanther made a PR but something was weird with the merge. This is my attempt at rebasing that PR with my uncommitted style fixes. Unfortunately, I didn't have a chance to run this before putting this PR up (internet went out in thunderstorm and now work duties) but I hope it's not far off.

Tested, and it works. Though, I forgot the semicolon in home.html — and can't update your branch


Update strikethrough replace rule to fix multiple tilde error

Update strikethrough replace rule to fix multiple tilde error when transition from text to html.
To make sure that <del> tag contains content text, if it's wrapped by multiple tilde characters.
Currently, <del> tag contains 2 tilde characters too after transition.
Fixed Issues
https://github.com/Expensify/App/issues/25693
Tests

What unit/integration tests cover your change? What autoQA tests cover your change?
In ExpensiMark-HTML-test.js file, test named "Test strikethrough with multiple tilde characters" works correctly.
What tests did you perform that validates your changed worked?
Checked if the updated strikethrough rule only wraps content text inside multiple tilde characters.

QA

What does QA need to do to validate your changes?
Run the new test cases.
What areas to they need to test for regressions?
N/A

@parasharrajat I updated the PR title and description.

@tylerkaraszewski @parasharrajat @neil-marcellini Can we merge this PR if it is approved?


typo: paramters -> parameters

Fixed some code fence languages as well

@MightyPen - Would you be able to review the proposed updates, or recommend a resource? Thanks!
@craigg-msft

@nschonni In these cases, I probably agree that the conversion from single-backtick to triple-backtick with 'sql' language label, is a good thing.  Thank you.
#sign-off

@MightyPen: I'm sorry - only the author of this article, @rothja, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Adding object wrappers for SIMD types.

Adding object wrappers for SIMD types.

Adding SIMD object wrappers for all SIMD types.
Populated SIMD object prototype with the needed methods (toString,
toLocaleString, valueOf etc)
Added value semantics for SIMD types.
SIMD variables can be used in operations similar to the other
javascript variables.
BugFix: Chakra could become unresponsive if @@ToPrimitive of a
javascript object is overridden by null or undefined. Adding fix.
Enabling previosuly disabled type conversion operationfor Uint32x4.
Adding tests.

Hi @arunetm, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Arun Purushan (Intel Corp)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@dotnet-bot test this please

@abchatra @LouisLaf please review this feature.

Thank you for the feedback. I am working on a new commit with the changes and the following fixes.

SIMDVariable.valueOf will be modified to return the SIMD value as per the spec.
New use cases and tests for valueOf, toString, adding new operations on simd types etc.

Updating PR with new commit.

Incorporating review feedback.
Bug fix for valueOf operation on SIMD types.
More unittests and use cases.
Code refactoring.

@dotnet-bot test this please

@dilijev Can you please help to sign off the PR. Thanks.

Reviewed 65 of 65 files at r1.

Lib/Runtime/Library/JavascriptSimdObject.h, line 24 [r1] (raw file):
nit: trailing whitespace

Lib/Runtime/Library/JavascriptSimdType.cpp, line 16 [r1] (raw file):
nit: extra blank lines

Lib/Runtime/Library/JavascriptSimdType.cpp, line 172 [r1] (raw file):
nit : extra blank lines

Lib/Runtime/Library/JavascriptSimdType.cpp, line 196 [r1] (raw file):
nit: extra blank line

Lib/Runtime/Library/JavascriptSimdType.cpp, line 219 [r1] (raw file):
nit : unneeded blank line before closing brace

Lib/Runtime/Library/JavascriptSimdType.h, line 33 [r1] (raw file):
nit: trailing whitespace

test/Array/memset_simd.js, line 21 [r1] (raw file):
Wrap this if-statement body in braces.
nits: include space in if (, only need one space before a comment token, space after the comment token.
Also applies to the change below.

test/SIMD.wrappers/rlexe.xml, line 62 [r1] (raw file):
nit: trailing whitespace

test/SIMD.wrappers/testBool16x8.js, line 23 [r1] (raw file):
nit: there is trailing whitespace like this throughout this file. please trim all trailing whitespace

test/SIMD.wrappers/testBool16x8.js, line 305 [r1] (raw file):
There are some strange bytes at the end of this line? Make sure there's a blank line at the end of the file.

test/SIMD.wrappers/testBool32x4.js, line 305 [r1] (raw file):
strange bytes and trailing whitespace throughout this file too

test/SIMD.wrappers/testBool8x16.js, line 305 [r1] (raw file):
strange bytes and trailing whitespace throughout this file too

test/SIMD.wrappers/testFloat32x4.js, line 305 [r1] (raw file):
same

test/SIMD.wrappers/testInt16x8.js, line 309 [r1] (raw file):
same

test/SIMD.wrappers/testInt32x4.js, line 305 [r1] (raw file):
same

test/SIMD.wrappers/testInt8x16.js, line 318 [r1] (raw file):
same

test/SIMD.wrappers/testUint16x8.js, line 309 [r1] (raw file):
same

test/SIMD.wrappers/testUint32x4.js, line 305 [r1] (raw file):
same

test/SIMD.wrappers/testUint8x16.js, line 317 [r1] (raw file):
same

Comments from the review on Reviewable.io

Reviewed 24 of 26 files at r2.
Review status: all files reviewed at latest revision, 27 unresolved discussions.

Lib/Runtime/Library/JavascriptSimdObject.cpp, line 189 [r1] (raw file):
Still trailing whitespace in this block.

test/SIMD.wrappers/testBool8x16.js, line 154 [r2] (raw file):
nit: still space here

Comments from the review on Reviewable.io

The new comments I made about spaces might have been existing before your change. Don't worry about them.
LGTM. Signed off.

Signing off again after rebasing to the latest master.

Reviewed 17 of 17 files at r3.
Review status: all files reviewed at latest revision, 27 unresolved discussions.

Comments from the review on Reviewable.io


Gitter room

Hey owners (@cdeil)– would you mind creating a Gitter room for astroplan? I think it would be a convenient way for @jberlanga and I (and all of you as well) to keep in touch for short questions.

As far as I know, there's an Astropy Gitter room and it's almost unused.
(of I'm not using it correctly and am not seeing any messages from the past weeks)
I think it would be great if Astropy and affiliated package devs start using the Astropy Gitter room.
Especially with GSoC students should have a place to ask git / Python / Astropy questions.
So @bmorris3, my preference would be that you start using the Astropy one, and only if others start using it as well and it starts to get too much, we should make a separate one for Astroplan.
@eteq @astrofrog – Can you make a decision on https://github.com/astropy/astropy/pull/3695 ?

I used to leave it open in a tab, but found that no one else was every "online" -- I'll start hanging out in the astropy gitter room again!

How do you find the astropy gitter room?

https://gitter.im/astropy/astropy#

It's a great tool, I love having markdown in a chat. Thanks for recommending the astropy room, I'll use that and try to keep the tab open..


Add site to list, address unsafe target issue in README

Added my site to the list.
Addressed unsafe target in link recommendation in README.md per this article:
https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/

Good call :)


Added languages lexc and xfst.

These are programming languages for finite-state morphology.
See Finite State Morphology by Kenneth R. Beesley and Lauri Karttunen.
Used by the xfst, foma, and hfst toolkits.

Description

Checklist:

[ ] I am associating a language with a new file extension.

[ ] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[x] I am adding a new language.

[ ] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a syntax highlighting grammar: https://github-lightshow.herokuapp.com/
[ ] I have updated the heuristics to distinguish my language from others using the same extension.

[ ] I am fixing a misclassified language

[ ] I have included a new sample for the misclassified language:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am changing the source of a syntax highlighting grammar

Old: https://github-lightshow.herokuapp.com/
New: https://github-lightshow.herokuapp.com/

[ ] I am updating a grammar submodule

[ ] I am adding new or changing current functionality

[ ] I have added or updated the tests for the new or changed functionality.

[ ] I am changing the color associated with a language

[ ] I have obtained agreement from the wider language community on this color change.

[URL to public discussion]
[Optional: URL to official branding guidelines for the language]

Please follow and fill out the pull-request template, then we'll review. 👍


Error: Integer literal exceeds the range of representable integers of type int

Hi,
I got following errors while installing google-drive-ocamlfuse on raspberry pi 3 (w/ jessie lite) according to
How-to-install-from-source-on-Debian-Jessie
Anyone can help me to fix it?
pi@raspberrypi:~ $ opam install google-drive-ocamlfuse
The following actions will be performed:
 - install   google-drive-ocamlfuse.0.5.23
=== 1 to install ===

=-=- Synchronizing package archives -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

=-=- Installing packages =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Building google-drive-ocamlfuse.0.5.23:
  ocaml setup.ml -configure --prefix /home/pi/.opam/system
  ocaml setup.ml -build
  ocaml setup.ml -install
[ERROR] The compilation of google-drive-ocamlfuse.0.5.23 failed.
Removing google-drive-ocamlfuse.0.5.23.
  Nothing to do.

#=== ERROR while installing google-drive-ocamlfuse.0.5.23 =====================#
# opam-version 1.2.0
# os           linux
# command      ocaml setup.ml -build
# path         /home/pi/.opam/system/build/google-drive-ocamlfuse.0.5.23
# compiler     system (4.01.0)
# exit-code    1
# env-file     /home/pi/.opam/system/build/google-drive-ocamlfuse.0.5.23/google-drive-ocamlfuse-    19209-c61e7b.env
# stdout-file  /home/pi/.opam/system/build/google-drive-ocamlfuse.0.5.23/google-drive-ocamlfuse-19209-c61e7b.out
# stderr-file  /home/pi/.opam/system/build/google-drive-ocamlfuse.0.5.23/google-drive-ocamlfuse-19209-c61e7b.err
### stdout ###
# ...[truncated]
# /usr/bin/ocamlopt unix.cmxa -I /usr/lib/ocaml/ocamlbuild /usr/lib/ocaml/ocamlbuild/ocamlbuildlib.cmxa myocamlbuild.ml /usr/lib/ocaml/ocamlbuild/ocamlbuild.cmx -o myocamlbuild
# /home/pi/.opam/system/bin/ocamlfind ocamldep -package Fuse -package camlidl -package gapi-ocaml -package sqlite3 -package threads -modules src/gdfuse.ml > src/gdfuse.ml.depends
# /home/pi/.opam/system/bin/ocamlfind ocamldep -package Fuse -package camlidl -package gapi-ocaml -package sqlite3 -package threads -modules src/appDir.ml > src/appDir.ml.depends
# /home/pi/.opam/system/bin/ocamlfind ocamldep -package Fuse -package camlidl -package gapi-ocaml -package sqlite3 -package threads -modules src/cache.ml > src/cache.ml.depends
# /home/pi/.opam/system/bin/ocamlfind ocamlc -c -g -annot -bin-annot -package Fuse -package camlidl -package gapi-ocaml -package sqlite3 -package threads -thread -w -d-58 -I src -o src/appDir.cmo src/appDir.ml
# /home/pi/.opam/system/bin/ocamlfind ocamldep -package Fuse -package camlidl -package gapi-ocaml -package sqlite3 -package threads -modules src/config.ml > src/config.ml.depends
# + /home/pi/.opam/system/bin/ocamlfind ocamldep -package Fuse -package camlidl -package gapi-ocaml -package sqlite3 -package threads -modules src/config.ml > src/config.ml.depends
# File "src/config.ml", line 316, characters 26-39:
# Error: Integer literal exceeds the range of representable integers of type int
# Command exited with code 2.
### stderr ###
# E: Failure("Command ''/usr/bin/ocamlbuild' src/gdfuse.native -tag debug' terminated with error code 10")

in src/config.ml
(int) max_upload_chunk_size =<PHONE_NUMBER>776;
seems too big.......
pi@raspberrypi:~ $ ocaml
        OCaml version 4.01.0

# max_int;;
- : int =<PHONE_NUMBER>

Yes, there was a problem with 32-bit architectures. Should be fixed in 0.5.25 (as soon as the package is published to the official repository).

0.5.25 works! thanks :)

Hi I'm having the same problem installing on Debian 9 - 32 bit:
Makefile:50: recipe for target 'IO.cmo' failed
make[1]: Leaving directory '/home/tulasi/.opam/system/build/extlib.1.7.4/src'
Makefile:14: recipe for target 'build' failed
stderr
fatal: Not a git repository: '.git'
File "IO.ml", line 577, characters 10-21:
Error: Integer literal exceeds the range of representable integers of type int
make[1]: *** [IO.cmo] Error 2
make: *** [build] Error 2
=-=- Error report -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
The following actions were aborted
∗  install gapi-ocaml             0.3.6
∗  install google-drive-ocamlfuse 0.6.23
The following actions failed
∗  install extlib 1.7.4
No changes have been performed
Any suggestions on fixing it? Thanks!

It looks like latest version of extlib doesn't compile on 32-bit systems. You can try with opam pin add extlib 1.7.2.

That worked. Thanks!


Separating DSC run with DSC database construction

There are 3 major parts in DSC: executing the pipelines, organizing the results (database construction) and query / visualization. Currently 1) and 2) are in the same command. It is suggest that we split 1) and 2), and instead of doing a complete version of 2) we use a concept of "virtual" table, that is, we keep the intermediate output and meta data from 1) without creating 2), then when query in 3) is submitted, DSC will parse the query and only collect relevant information to build 2). In this way, we can allow for a 2 dimensional structure in 2) because it is potentially much smaller in scope compared to the complete 2). (currently we use a 3 dimensional data structure for it).
A related thought is that in creating 2) in a separate commend after 1), we can use some additional parameters to limit the information we extract. For example for DSC ending with vector output we can set limit on how many elements to keep.

Done


Strict de-serialization for configured semi-auto decoder derivation

Partially addresses https://github.com/circe/circe/issues/374.
This PR adds strictDeserialization boolean flag to generic-extras' Configuration.
When enabled, decodeCaseClass checks whether superfluous fields are present in the input JSON and, if that is the case, reports an error indicating the fields that are present in the decoded JSON but not expected in the target product.

Codecov Report

Merging #1117 into master will decrease coverage by 0.19%.
The diff coverage is 94.11%.

@@            Coverage Diff            @@
##           master    #1117     +/-   ##
=========================================
- Coverage   84.37%   84.18%   -0.2%
=========================================
  Files          77       77
  Lines        2503     2517     +14
  Branches      179      183      +4
=========================================
+ Hits         2112     2119      +7
- Misses        391      398      +7

Impacted Files
Coverage Δ

.../scala/io/circe/generic/extras/Configuration.scala
100% <100%> (ø)
:arrow_up:

...ce/generic/extras/decoding/ConfiguredDecoder.scala
91.66% <93.75%> (+0.17%)
:arrow_up:

...rc/main/scala/io/circe/shapes/SizedInstances.scala
78.57% <0%> (-14.29%)
:arrow_down:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
90% <0%> (-5%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
89.75% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 899bbd9...bf1f9d5. Read the comment docs.

Thanks for adding this! I'm going to go ahead and merge it, but I'll probably propose a follow-up PR changing the naming to strictDecoding, since in general here we use "decoding" for anything involved in transforming well-formed JSON into Scala types, and "deserialization" only in a more hand-wavy way to refer to the whole process of going from Scala types to strings or bytes and back.

Great thanks for reviewing and merging this feature 🙇


How to remove Any rendered templates? , removeAllNodes has a bug with sibling error

I am trying to delete some rendered nodes but I'm struggling with this error, Is there a valid way to remove rendered templates by Lit-html?? without hacking in to the DOM directly . Thank you a lot

just return undefined from your function instead of template result and render again


Allow null String for Text widget

Text shouldn't throw an error if I give it a null String. It should handle that gracefully and display the same as if I gave it an empty String. Otherwise, you create more work for me, processing null Strings to empty Strings, and from what I've found so far, Dart is bad at things like that compared to Kotlin.

You can use Text(variable ?? "") which is the same with Swift and Kotlin, I think.  And once Dart NNBD support lands, you will hopefully catch most of not all "optional type" problems at compile time.

I didn't know about the ?? operator. Thank you. That's far more convenient than what I've been doing.


Riddled with false-positives. Scrub this harmful project from existence.

This library has clearly been a net negative for humanity.
The irony of being falsely flagged as rooted... and needing root to bypass it 😂
One can just take a quick glance at the issues to understand the situation. I'll repost some tragic examples:

The NJTransit app is using your library to detect root, and the Play Store is riddled with reviews of false positives. It's preventing people from accessing tickets they legitimately purchased.

personally the problem is blocking for me because French banks use your lib for their applications

The app MobilePay is the ubiquitous mobile-payments app here.I think that the vast majority of persons in Denmark use this app daily or weekly for payments.

I am developper for a big android App. ATInternet stats show that all BlackView 8000 phones are detected as root.

Yeah, there are 1 million ways to detect Magisk, and yet you choose to falsely flag all Unix sockets that are 32 bytes long. Great job 👍

These cases aren't rare: I'm also affacted on TWO non-rooted phones of different brands with locked bootloaders using stock ROM (SELinux flag. The app doesn't even bother spelling it right and calls it "SE linux" btw).
Who's to blame, some random unpaid incompetent open source devs who abandoned their ѕhіttу harmful project in a broken state, or governments and companies for actually using it?
But let's imagine for a moment the project gets fixed and is able to miraculously detect root with perfect accuracy... what's the end goal? An easy way for corporations to arbitrarily restrict the people's freedoms on their own devices?
An app to simply test if your root works correctly for troubleshooting reasons exists already (Root Verifier) and supports Android 2.2+
This app/library is a lose-lose situation for everyone. It has done enough damage already, so do the right thing: cast it into the fire. Destroy it.

I appreciate it can be frustrating when consumer apps degrade or block functionality based on the results of rootbeer. But it's not really down to rootbeer to be accountable for that, this is open source and apps can implement whatever checks they like. I've recently improved the readme to make it a bit clearer what each check is doing and to further emphaise that this is an indication of root and not to treat the result of the rootbeer check as 100% truth.
I'm closing this issue as it feels more like a rant/troll post rather than something that is trying to improve things.


Gssoc'21 Password validation by js in Register page

Is your feature request related to a problem? Please describe.
Password validation by js in Register page is required for secured and strong password.
Describe the solution you'd like
It will look some thing like this.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@rupeshmohanty kindly assign it to me.


os/user: document the difference between User.Name and User.Username

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
tip
What operating system and processor architecture are you using (go env)?
Linux
Here's the documentation for User:

User represents a user account.
On POSIX systems Uid and Gid contain a decimal number representing uid and gid. On windows Uid and Gid contain security identifier (SID) in a string format. On Plan 9, Uid, Gid, Username, and Name will be the contents of /dev/user.

type User struct {
    Uid      string // user ID
    Gid      string // primary group ID
    Username string
    Name     string
    HomeDir  string
}

Initially I assumed Name corresponds to the login name (the first field in /etc/passwd) and Username refers to the "user name or comment" (the fifth field), though then I read that LookupUser finds a user by username, so maybe those are flipped.
http://manpages.ubuntu.com/manpages/precise/man5/passwd.5.html

Ah, found it in lookup_unix.go.
	u := &User{
		Uid:      strconv.Itoa(int(pwd.pw_uid)),
		Gid:      strconv.Itoa(int(pwd.pw_gid)),
		Username: C.GoString(pwd.pw_name),
		Name:     C.GoString(pwd.pw_gecos),
		HomeDir:  C.GoString(pwd.pw_dir),
	}


Question: How to export multiple pages

Hi @bsorrentino
After the confluence-reporting:export is working fine I'd like to export multiple confluence pages in one build. What's the best way to do this?
[EDIT] I tried to work with executions but they seem not be provided as the configurations in the executions do not work.
Kind regards
Richard

Hi @richiew
You miss the goal in execution. Below the proposed solution
<properties>
    <confluence_endpoint>https://ourconfluence.com/rpc/xmlrpc</confluence_endpoint
    <confluence_username>username</confluence_username>
    <confluence_password>password</confluence_password>
</properties>
<build>
    <pluginManagement>
        <plugins>
            <plugin>
                <groupId>org.bsc.maven</groupId>
                <artifactId>confluence-reporting-maven-plugin</artifactId>
                <version>${maven-confluence-plugin-version}</version>
            </plugin>
        </plugins>
    </pluginManagement>
    <plugins>
        <plugin>
            <groupId>org.bsc.maven</groupId>
            <artifactId>confluence-reporting-maven-plugin</artifactId>
            <configuration>
                <endPoint>${confluence_endpoint}</endPoint>
                <spaceKey>AR</spaceKey>
                <serverId>confluence-server-id</serverId>
                <password>${confluence_password}</password>
                <username>${confluence_username}</username>
            </configuration>
            <executions>
                <execution>
                    <id>release-notes</id>
                    <phase>package</phase>
                    <goals>
                      <goal>export</goal>
                    </goals>
                    <configuration>
                        <parentPageTitle>armasuisse Cockpit</parentPageTitle>
                        <pageTitle>ar-cockpit Release Notes</pageTitle>
                    </configuration>
                </execution>
                <execution>
                    <id>installation-notes</id>
                    <phase>package</phase>
                    <goals>
                      <goal>export</goal>
                    </goals>
                    <configuration>
                        <parentPageTitle>armasuisse Cockpit</parentPageTitle>
                        <pageTitle>ar-cockpit Installation</pageTitle>
                    </configuration>
                </execution>
            </executions>
        </plugin>
    </plugins>
</build>


[v4] Alert component's icon and title are slightly misaligned

The icon for the Alert component seems slightly misaligned (vertically) with the title.

BEFORE (V3)
AFTER (V4)

https://github.com/segmentio/evergreen/releases/tag/v4.0.0-3


:arrow_up: v1.2.7

@wellwelwel @emilorol if you folks think, it's good to go, we can ship it

@aashutoshrathi, I have some small suggestions:

On LICENSE, instead 2014-2023, to 2014-current
The .npmignore is serving no purpose, since in package.json, it only requires the files index.js and index.d.ts to package.

Forward, we can remove completely the verb and the gulp-format-md.
But I think that any new change should be with CI already enabled 🙋🏻♂

@aashutoshrathi, I have some small suggestions:

On LICENSE, instead 2014-2023, to 2014-current
The .npmignore is serving no purpose, since in package.json, it only requires the files index.js and index.d.ts to package.

Forward, we can remove completely the verb and the gulp-format-md. But I think that any new change should be with CI already enabled 🙋🏻♂

Should we do this in this version?

Since after this PR the tests will be enabled, I think this should come next.

Since after this PR the tests will be enabled, I think this should come next. What do you think?

Makes sense to me.
But one thing worries me, since this is like a really important repo for all the folks, and we are more or less making non-functional releases, should we even makes releases or just update the docs, without releasing it?

@aashutoshrathi, I will give my point about that.
For CI and general tasks (chore), I never release a new version.
For documentation, it depends.
In this PR, the changes in documentation are relevant:

It fix the installation to correct package
It shows a workaround for deep dependencies

About your changes for bower, in case you use it, it's okay.
If you don't use the bower, this could be quietly removed. Some files only makes sense for the development of the original creator. The same for verb and gulp-format-md.
But, since (for some reason), the gulp-format-md is a direct dependency, even though it's not used in the project. Then, it will requires a new patch. If it weren't for that, or the gulp-format-md was just a development dependency, a new release wouldn't be necessary.

One possibility would be to merge this PR without releasing it.
So, it would turn on the CI and when every small change is ready, release it.

I think let's not bump the version and merge this PR

Also, I don't think it requires, publishing, right?

Since your concern is to release without significant changes, I suggest waiting until you have enough changes together that you feel safe to release it 🙋🏻♂

Just a note, although the installation appears right on GitHub after the merge, in NPM it will still lead to the original project.


Google_Http_MediaFileUpload::resumeUri needs to be public/gettable to resume from a different process

Explained in https://github.com/google/google-api-php-client/issues/143#issuecomment-40210269 - still a live issue for me.
I would create a patch with a getResumeUri() method, but there's already a method with that name that does something else. Ideas?
David

My code also has to set Google_Http_MediaFileUpload::progress in order to resume, so that has to be settable too.

Fixed in #675


It should be easier to connect two elements with an edge in visualiser

We already have BlElement>>#graph that contains some useful graph navigation API. We should add an utility method to connect elements.

Added element graph connectTo: anotherElement that connects two element with an edge and configures graph layout constraints.
fromElement := BlElement new
	size: 40@40;
	geometry: BlEllipse new;
	background: (Color gray alpha: 0.4).

toElement := BlElement new
	size: 40@40;
	background: (Color gray alpha: 0.4).

fromElement graph connectTo: toElement.

container := BlElement new
	layout: GtGradVerticalTreeLayout new;
	addChildren: { fromElement . toElement }.

container

@lukego

Thanks!


Attributes for faceting vs. lazily-created indices

Describe the bug
Version 0.13rc, binary published by the project
Arch: linux/amd64
I'm trying to implement a lazily-created index pattern, where an index is expected to have some faceted attributes. This works in the way that a running application gets a "job" to index some object; the object defines an index it has to belong to (some kind of sharding), so 3 operations are done one by one:

Create an index: UID=index
Update index settings: UID=index, {"attributesForFaceting":["users","type","labels"]}
Insert an object into that index, [{"body":"object 1","id":"m52","labels":[],"type":"1","users":["userid1"]}]

(2) and (3) return an async ID, however I assume those are serialized (e.g. 3 follows 2 on Meili side), so i'm not waiting for update (2) to complete, and just sending the request (3).
It appears the attributesForFaceting are somehow messed up in the index:

Right after (3) i'm getting that index settings, to find out it returns the following:

{"rankingRules":["typo","words","proximity","attribute","wordsPosition","exactness"],"distinctAttribute":null,"searchableAttributes":["*"],"displayedAttributes":["*"],"stopWords":[],"synonyms":{},"attributesForFaceting":["id"]}

Notice id listed in attributesForFaceting

If i'm again getting the index settings several seconds later, i now see "attributesForFaceting":["id","body","labels"]. Naturally, if i'm doing a search specifying "type:1" as a facetFilter, it returns HTTP/400 with a message like:

error processing facet filter: `type` is not set as a faceted attribute. available facet attributes: id, body, labels

My assumption about operations (2) and (3) above being serialized in that order might be wrong, however even if it is, I assume one of two outcomes:

If it's not serialized in that way: the record from (3) is inserted w/o settings from (2) being applied yet, so it won't be returned in the search
If it's actually serialized like that: the record from (3) is inserted after the settings from (2) are applied, so it's properly indexed and returned in the search.

Regardless of the order, i expect attributesForFaceting to be set to ["users","type","labels"] at some point, not some random ["id","body","labels"]
To Reproduce
Steps to reproduce the behavior:

Create an index with UID index
With no delay: update the index setting with {"attributesForFaceting":["users","type","labels"]}
With no delay: insert a document into the index, [{"body":"object 1","id":"m52","labels":[],"type":"1","users":["userid1"]}]

Expected behavior
After a few seconds the request to get the setting for index should return {"attributesForFaceting":["users","type","labels"]}. A search request with "type:1" as facetFilter should not return an error code.

this issue is now split in 2 children issues:

a bug report #942
a feature tracking issue #918

I close this issue, don't hesitate to reopen it if children issues are not exhaustives.


Migrate Windows packages or patch repodata for 1.0.1 builds

          Just for completeness: I noticed this in particular on Windows as the pinned libavif==1.0.1 actually adds a run_exports on `libavif==1.0.1`, not `libavif16` (see https://conda-metadata-app.streamlit.app/?q=conda-forge%2Fwin-64%2Flibavif-1.0.1-h7a9aacb_3.conda, issue fixed in https://github.com/conda-forge/libavif-feedstock/pull/25), so beside the pinning update all packages that depends on libavif and have Windows builds need to be rebuilt (or the repodata info patched).

Originally posted by @traversaro in https://github.com/conda-forge/libavif-feedstock/issues/32#issuecomment-2132358001

Repos (https://github.com/search?q=org%3Aconda-forge+"-+libavif"+language%3AYAML&type=code):

sdl2_image : https://github.com/conda-forge/sdl2_image-feedstock/pull/35
tensorstore : non needed, does not supports windows
imagecodecs:  https://github.com/conda-forge/imagecodecs-feedstock/pull/105
libheif : https://github.com/conda-forge/libheif-feedstock/pull/22

thanks would rather not take too heavy of a hand in these feedstocks if not needed, but let me know if you think i should.

tensorstore : non needed, does not supports windows

Anyhow, this was re-rendered as part of the package update in https://github.com/conda-forge/tensorstore-feedstock/pull/33 .


Fixed login redirect

Fixes issue #62

Directly merging. Django auth check for template/registration/logout.html before showing it's default.
I took that file and pointed the urls to login.

Merging into Master


Document @source/@target

Documents #6585

Could we have a @source example too? I suspect it will be a more common
pattern. Maybe something like @.***, @order) for something where the
link is ordered
On Thu, Dec 14, 2023, 17:16 Elvis Pranskevichus @.***>
wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/edgedb/edgedb/pull/6594#pullrequestreview-1782990972,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACTC7N32PJDNOQGYQLVZOTYJOQH3AVCNFSM6AAAAABARR3KQGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBSHE4TAOJXGI
.
You are receiving this because your review was requested.Message ID:
@.***>

Could we have a @source example too? I suspect it will be a more common pattern. Maybe something like @.***, @order) for something where the link is ordered

I think this request got mangled by either an email client or GitHub, but I believe the intent is to demo constraint on ((@source, @order)). I tried to do that, and it doesn't seem to be working for me or else I've missed something. I'm modeling a Simon-esque memory game with this:
module default {
  type Player {
    required name: str;
    multi picks: Color {
      order: int16;
      constraint exclusive on ((@source, @order));
    }
  }
  type Color {
    required name: str;
  }
}

When I try to migrate this, I get
error: cannot reference multiple links or properties in a constraint where at least one link or property is MULTI
  ┌─ /Users/raddevon/Documents/projects/edgedb/demos/multi-link-order/dbschema/default.esdl:6:7
  │
6 │       constraint exclusive on ((@source, @order));
  │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error

edgedb error: cannot proceed until .esdl files are fixed

Am I missing something here, @msullivan?

Oh, I don't think this will work in 4.x until 4.3 goes out. It should work on nightly though?
(Unless we haven't had nightlies go out in a week?)


Installing large application fails when running on node4ords

I was trying to install the following sample app (material design): https://raw.githubusercontent.com/vincentmorneau/material-apex/master/f12192.sql
However, after a while of waiting, i just get the following empty page:

Running the same installation script through the Tomcat listener, the app does manage to install without this error.

Just retried this and didn't get the error.
I'm thinking it was resolved from commits:

https://github.com/OraOpenSource/OXAR/commit/f0820f1f3c3002243190c07a88471ce530c8cabb
https://github.com/OraOpenSource/OXAR/commit/1a799ed02c7a4728aa3b545c8648ee9df6a25733

Which related to #135


Enhance knife supermarket to eliminate the need for Stove

I propose that we roll some of the core functionality of Stove into knife supermarket itself in order to eliminate the need for the stove command line and to make sure that everyone uploading chef cookbooks has the same experience.
Motivation
As a end user,
I want to cookbooks on the supermarket to contain a consistent set of files,
so that I don't have to worry about how a cookbook was uploaded.

As a cookbook author,
I want to knife to upload only the files necessary for a cookbook,
so that I can automate cookbook uploads without a full DK install.

As a new Chef user
I want to use knife for all interaction with Supermarket,
so that I don't have to learn another tool to be successful with Chef.

Specification

Knife supermarket respects the blacklist in the chefignore file when uploading cookbook to slim down the contents that gets uploaded to Supermarket to just those that are pulled down to a chef-client itself anyways.
A new flag allows uploading all files for those that want the artifact to match the repository contents

Downstream Impact

Eventually stove should go away. In the short term we'll probably want a warning that tells folks to stop using it.

Another thing that the might not be obvious is that we'd get to use the knife.rb logic, switching between accounts should be a much more plesent experience

I'm pretty sure it's been talked about before, but it would be useful to have an allowed list of files if chefignore wasn't there.

Let me update the use case for that. Not needing yet another config file is a solid reason to use this path.

What are the features of stove that are necessary, and presumably this would just be patches to knife supermarket share?
I.e. what does the actual design look like here? (and i'd argue that extending the chefignore functionality or having a default chefignore is out of scope of this issue)

Yeah, if we want bare stove functionality then it's totally scope creep

Yes, this needs to be minimum viable deprecation of stove.


Isomorphic errors

When you use react isomorphic it will give errors because howler use navigator which is not available in nodejs.

ReferenceError: navigator is not defined
at e (/node_modules/howler/howler.min.js:2:385)
at /node_modules/howler/howler.min.js:2:800
at Object. (/node_modules/howler/howler.min.js:2:19670)
at Module._compile (module.js:434:26)
at Object.Module._extensions..js (module.js:452:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/node_modules/react-howler/lib/ReactHowler.js:13:16)
at Module._compile (module.js:434:26)
at Object.Module._extensions..js (module.js:452:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/node_modules/react-howler/lib/index.js:3:18)
at Module._compile (module.js:434:26)
at Object.Module._extensions..js (module.js:452:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (module.js:384:17)

Well.  Like you said,  howler relied on navigator.  Maybe before you require ReactHowler,  you should check if window object is available.
if (typeof window !== 'undefined') {
  // require howler here,  do stuff
}

I can make a workaround no problem, but I thought maybe you can or want to build it in by the module by default.

Do you have any idea how to do it ?  PRs are welcome

I would say that your window solution can work inside initHowler() to prevent it from loading Howler on server side.

Looks like a solution to me. Care to send a PR ?
This might be related https://github.com/goldfire/howler.js/issues/422

I want to but the problem I get now is that when import { Howl } from 'howler' is fired the error appears. But doing the window check there is not allowed. So either it needs to be solved in the howler module of in the index, I don't think solving it in the index.js is a nice solution.

:+1: so add new file to resolve howler,  if we are in node, return undefined

Close by #9


Allow to publish to remote servers

With the ?local=1 param the deploys are only local, we need to be able to deploy to a CDN!

ping? :(