Analyze prebuilts for vstest

The following prebuilt packages are included as dependencies in source-build by vstest.  These need to be analyzed to determine how to avoid requiring packages that source-build doesn’t build.

Change to use the source-built version
Package is not critical to product and can be removed.  (i.e.test-specific, windows-specific, etc)
The package is used as reference only
The package should be built in source-build
Other – please elaborate on what you think should be done.

For more detailed usage information for these, please see the Usage Exploration tab of the SourceBuildPrebuiltReport.
Prebuilt Table Updated 2019-05-07

PackageName
PackageVersion
SourceBuiltVersion
Category

Microsoft.Build.Framework
15.1.548
16.0.461

Microsoft.Build.Utilities.Core
15.1.548
16.0.461

Microsoft.Extensions.DependencyModel
1.0.3
3.0.0-preview4-27615-11

Microsoft.Internal.Dia.Interop
14.0.0

Microsoft.Internal.Dia
14.0.0

Microsoft.Internal.Intellitrace
15.8.0-preview-20180702-05

Microsoft.Internal.TestPlatform.Extensions
15.8.0-preview-1831095

Microsoft.TargetingPack.NETFramework.v4.6
1.0.1

Microsoft.VSSDK.BuildTools
15.0.26201

Microsoft.VisualStudio.CUIT
15.8.0-preview-1831095

Microsoft.VisualStudio.QualityTools.DataCollectors
15.8.0-preview-1831095

Microsoft.VisualStudio.QualityTools
15.8.0-preview-1831095

Microsoft.VisualStudio.Sdk.BuildTasks.14.0
14.0.12-pre

Microsoft.VisualStudio.Telemetry
15.6.815-master284DF69C

NuGet.CommandLine
3.4.3

Pdb2Pdb
1.1.0-beta1-62316-01

StyleCop.Analyzers
1.0.1

System.Xml.XPath.XmlDocument
4.0.1

fmdev.xlftool
0.1.3

vswhere
2.0.2

Original Prebuilt Table

PackageName
PackageVersion
SourceBuiltVersion
Category

Microsoft.Build.Framework
15.1.548
16.0.0-preview.385

Microsoft.Build.Utilities.Core
15.1.548
16.0.0-preview.385

Microsoft.Extensions.DependencyModel
1.0.3
3.0.0-preview-27503-5

Microsoft.Internal.Dia.Interop
14.0.0

Microsoft.Internal.Dia
14.0.0

Microsoft.Internal.Intellitrace
15.8.0-preview-20180702-05

Microsoft.Internal.TestPlatform.Extensions
15.8.0-preview-1831095

Microsoft.TargetingPack.NETFramework.v4.6
1.0.1

Microsoft.VSSDK.BuildTools
15.0.26201

Microsoft.VisualStudio.CUIT
15.8.0-preview-1831095

Microsoft.VisualStudio.QualityTools.DataCollectors
15.8.0-preview-1831095

Microsoft.VisualStudio.QualityTools
15.8.0-preview-1831095

Microsoft.VisualStudio.Sdk.BuildTasks.14.0
14.0.12-pre

Microsoft.VisualStudio.Telemetry
15.6.815-master284DF69C

NuGet.CommandLine
3.4.3

Pdb2Pdb
1.1.0-beta1-62316-01

StyleCop.Analyzers
1.0.1

System.Xml.XPath.XmlDocument
4.0.1

fmdev.xlftool
0.1.3

vswhere
2.0.2

@dseefeld We tried building TestPlatform_BuildFromSource via dotnet build TestPlatform_BuildFromSource.sln -p:DotNetBuildFromSource=true, & we did not find any dependencies apart from those of system, or runtime.
Attached list of packages that actually got restored.
packages.txt

@dseefeld We tried building TestPlatform_BuildFromSource via dotnet build TestPlatform_BuildFromSource.sln -p:DotNetBuildFromSource=true, & we did not find any dependencies apart from those of system, or runtime.
Attached list of packages that actually got restored.
packages.txt

Right.  The list above contains the restored packages that show up in source-build for vstest that aren't being built from source.  These are direct dependencies only.  There are a bunch of transitive dependencies as well, but we're not tackling those right now.  What we'd like is a response from you in the table above regarding how each of these should be handled.  I've included some possible responses above.  Thanks.

@dseefeld How are we restoring these packages ? Are we running the build script in the repo?
Like Mayank mentioned, vstest repo should be built using
dotnet build TestPlatform_BuildFromSource.sln -p:DotNetBuildFromSource=true
And when we do that we don't see any of these dependencies that you mentioned above.

@singhsarab Here's the command that we're using to build vstest in source-build:
/src/src/vstest/build.sh -DotNetBuildFromSource -DotNetCoreSdkDir /src/Tools/dotnetcli/ -c Release -r centos.7-x64 -v 15.9.0 -vs preview-20180807-05
Building with the command that you mentioned above doesn't produce any nupkgs.  Should it?

@dseefeld Thanks for pointing that out. We'd need to fix this script then. The command that I gave you can be used only for building the projects, it does not create all the packages. Creation of  nuget packages happens via the script you pointed out.
@mayankbansal018 Can you please take a look.

Building with the command that you mentioned above doesn't produce any nupkgs. Should it?

@dseefeld  No this will not create any nuget package.
Can you please specify if you need nuget packages while running dotnet build from source command. If you do need nugets then we will need to fix our build.sh script to generate those, if the packages are not needed, then we suggest you use the command specified by Sarab earlier.

dotnet build TestPlatform_BuildFromSource.sln -p:DotNetBuildFromSource=true

@mayankbansal018 Yes.  We need the build to produce nuget packages.  We currently build Microsoft.TestPlatform.Build and Microsoft.TestPlatform.CLI

@dseefeld I have merged the PR.

All prebuilts removed.


(ready for review)Harcode together ai api url as fallback

Reason For Change
As I was testing together AI integration noticed that it fails due to wrong API key
Investigating I found out that by default it goes to OpenAI API url and obviously fails
Turned out that reason is that by default nothing is set in env.
Made hardcoded default if env has nothing

Works on Windows 11 and Linux (Ubuntu 24.04)


forEachLeafNode should be available for 'paging' rowModel

For paging, grouping is still available for current page but forEachLeafNode is not available

fixed. will be in next release.


fix(data/fin): rename raise_fin -> fin.raise; simp lemmas for fin

@johoelzl Thanks for the feedback. I will incorporate it; it's good practice for me. Thanks for the links to the style guides.

Thanks!


Add animation delay

@androziom
Your patch is good.
But i had a request to add listeners in more consistent way.
Do you think is good to make an AnimationBuilder using Builder pattern,
to be able to provide all animation properties that can be needed?

@geftimov
I think, that it's good way.

@androziom
I will merge the pull-request and work on the AnimationBuilder.


fix: Bad code fence indenting in ordered lists

Why:
Split out commit from #541 for markdown sections that cause parser issues with markdownlint because of incorrect indenting of start/end code fences

What's being changed:

Un-started table row. Caused Crowdin to mangle it in the translated copies
Code fences inside of ordered list that didn't have at lease 3 spaces and some that had different open/closing indents

Check off the following:

[x] All of the tests are passing.
[x] I have reviewed my changes in staging.
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

Thanks for opening a PR @nschonni! I'll get this triaged for review 🌟

@janiceilene I've removed the content changes from the other PR now, since the original issue requiring them has been fixed in Markdownlint. They are still content issues, so I'll leave the for review here

@janiceilene @rachmari looks like the stale bot doesn't want to dismiss the label after pushing/rebasing

Looking at this again briefly, this can be reviewed by any writer! I removed @rachmari and I as reviewers and I'll move this to the anyone column for triage.

👋 @martin389 It looks like this one's ready for your 👀 again

Hi @nschonni 👋
I had a look at Configuring high availability replication for a cluster, and some of the rendering might need to be checked:

In step 9, of Adding passive nodes to the cluster configuration file, the code block for the third bullet point is indented too far left:

In step 12 of Adding passive nodes to the cluster configuration file, the contents of the warning admonition seem to have escaped and are rendering underneath the block:

This has also reset the procedure's numbering back to 1, when it should be continuing to step 13 from there.

🤦 sorry about the repeat reviews. I rebased and checked that file on dev side-by-side again with poduction and they're looking the same.
I notice that there appears to be something funny going on with the list numbering with the warning/note blocks resetting the numbering, but it appears in production as well. It looks like the correct
 is being correctly set, but the styling is going back to 1 🤷

🤦 sorry about the repeat reviews. I rebased and checked that file on dev side-by-side again with poduction and they're looking the same.
I notice that there appears to be something funny going on with the list numbering with the warning/note blocks resetting the numbering, but it appears in production as well. It looks like the correct
 is being correctly set, but the styling is going back to 1 🤷

No worries, thanks for checking on this 👍  It does seem like it should all be rendering as expected, so I'll do some digging around here too.

👋 For docs tooling folks:
The procedure numbering resets a few times in this staging article: "Configuring high availability replication for a cluster". Specific examples are listed below:

"Assigning active nodes to the primary datacenter": (stage) (prod) - Step 5 in prod becomes step 1 in stage."
"Adding passive nodes to the cluster configuration file": (stage) (prod) - Step 2 in prod becomes step 1 in stage. Numbering also resets again a few more times throughout this section.

Sounds like it might have been an internal issue that was fixed https://github.com/github/docs/issues/1552#issuecomment-732401111
I'll try rebasing now to see if it fixes it

@martin389 rebase looks like it fixed it 😄

Thanks again for these fixes, @nschonni! 🎉


Issues related to API (post- release of API v3)

set whether judge-to-judge questions are allowed via the API (or default to not allowing them)
change expert assignments on existing trees via the API
remove trees from an experiment via the API
set experiment as active when creating it via the API (or experiments default to being active when created)
set experiment metadata via the API
allow pointers to be passed down from one workspace created via the API to another (not super important, probably not worth the dev effort)
return the IDs of the created trees (not super important)

@zjmiller @andrewschreiber would any of these be easier than others?
These are the most important to me:

set whether judge-to-judge questions are allowed via the API (or default to not allowing them)
change expert assignments on existing trees via the API

either of those relatively easy by any chance?

Hmm I'd defer to @zjmiller on this one. Seems like the trick from changing expert assignments will be writing the correct GraphQL queries/mutation:

Provide the new expert emails as an array, and maybe root workspace id.
Query the existing trees of the root workspace
Use that Query output to generate a Mutation target for the expert assignments
Run the Mutation

Would need to look at how these are implemented to scope how difficult this would be particularly. I expect the debugger setup from #594 will make building these fancier API operations easier. Let me know if you think this investigation is higher priority then the issues I'm working on.

Setting judge-to-judge and changing expert assignments will both be relatively simple.
In fact, everything in the list is fairly straightforward except passing pointers around.

@zjmiller could you give a time estimate for each bullet in the list, or whatever version of something like that that makes the most sense?

[implemented in #650] set whether judge-to-judge questions are allowed via the API (or default to not allowing them)
[2 hrs] change expert assignments on existing trees via the API
[2 hrs] remove trees from an experiment via the API
[1 hr] set experiment as active when creating it via the API (or experiments default to being active when created)
[1 hr] set experiment metadata via the API
[hard] allow pointers to be passed down from one workspace created via the API to another (not super important, probably not worth the dev effort)
[1 hr] return the IDs of the created trees (not super important)

Ok awesome!
let's do these ones:

[2 hrs] change expert assignments on existing trees via the API
[1 hr] return the IDs of the created trees (not super important)

And then if any of these end up being easy to tack on, then also these:

[2 hrs] remove trees from an experiment via the API
[1 hr] set experiment as active when creating it via the API (or experiments default to being active when created)
[1 hr] set experiment metadata via the API

I'll change the value and dev time accordingly :)

Wanted to leave an update here. I've been thinking through change expert assignments on existing trees via the API, exploring the code, have spent more than the forecasted 2 hours on it. I think quickly writing out what I've found while trying to understand the codebase here would help get this done.

The goal here is to be able to define a CSV file where the API user would fill out fields like treeID, honest1Email, honest2Email, maliciousEmail, perhaps multiple, and then a updateExpertAssignments command would cause the necessary changes on the backend.
At first, my hope was that there was some Tree table that had an honest1, honest2, and malicious column. Quick update to the users (by finding the respective User via their email) and we're done. Turns out, not exactly.
We do have a Tree object, and it instead has a many-many relationship with UserTreeOracleRelation. The UserTreeOracleRelation object has a user relation and a isMalicious bool.
Okay so we can get the assigned malicious expert for a given tree this way. Great. We can get the honest experts as well, but it's not clear which is honest1 and which is honest2.
So we need a way of differentiating between honest1 and honest2. Are timestamps too hacky, even if maybe honest1 is always made before honest2? More thought/examination needed here...
What does honest2 correspond to anyway? It's a role in assignParticipants in mosaic-api-scripts but never appears in the main mosaic repo.
Skipping ahead, let's say we've figured out the users. We now want to replace the proper fields on the tables. So what do we update? Well, we don't know if all roles have been assigned (and the corresponding UserTreeOracleRelations have been created), so it's probably easier to delete the old UserTreeOracleRelations for the tree and create a new set, one for each newly assigned expert.
That seems good. But wait, what is this? There is an Assignments table as well. It doesn't have a treeId attached, but it does have a workspaceId, a userId, and an isOracle bool. Seems pretty relevant and indeed, the assignParticipants command creates a large array of these. Gotta chase down what they do, probably replace them as well.
What kind of creation cascade happens on the backend? Maybe if I assignParticipants, then we get the UserTreeOracleRelation for free? But it has to be on the right trees, which already exist and maybe already are partially responded to, so they shouldn't be deleted and recreated.

Stopping here as I think I've got some more investigation to do with respect to some of the points above. @zjmiller if I'm building a bridge to cross a puddle here, and there is some direct approach you had in mind, please let me know.

Whether a user is an expert for a tree depends solely on whether there exists a UserTreeOracleRelation. If such a relation exists but the isMalicious field of the relation is false, then the user is an honest expert for the tree. If such a relation exists but the isMalicious field is true, then the user is a malicious expert for the tree. If no such relation exists then the user is a judge for the tree.
For a while in Ought's history, "oracle" just meant "honest oracle" (and, in case you weren't aware, we used the term "oracle" for a while before we decided to use "expert" instead). So when malicious oracles were introduced, I wasn't thinking of honest and malicious oracles are two types of oracles that were conceptually on a par. I was thinking of oracles as by default honest oracles, and malicious oracles as a deviation from this default.  So if I had to design things now, I'd have an isHonest boolean on the relation, instead of inferring an expert is honest from isMalicious being false. (So potential future refactor here).
The isOracle boolean on Assignments can be ignored. It used to be important to keep track of whether an assignment was an oracle assignment, for scheduling purposes. But things have changed a lot since then, and we aren't going back to how it was, so we could remove this field altogether as a future refactor.
So things are thankfully much simpler than you're thinking. To change expert assignments is solely a matter of creating/destroying UserTreeOracleRelation rows, and/or toggling the isMalicious field on these relations.

Also, I want to clarify the role of the scripts in the mosaic-api-scripts repo. These scripts are used to interact with the API endpoint of the Mosaic app. (This endpoint is the bulkCreateExperiments mutation of the GraphQL schema.)
The scripts in mosaic-api-scripts don't really have anything to do with Mosaic backend code. The scripts in mosaic-api-scripts are all just ways to more efficiently create requests to be sent to the Mosaic API endpoint.
So, looking at your second-to-last bullet point, the assignParticipants script is just something on Ben's computer or Mati's computer that helps them interact with the Mosaic API endpoint. I haven't even looked at the script personally, as the ecosystem that has grown up to interact with the Mosaic API endpoint has become quite large. And I don't really need to look at it, because everyone should feel free to create whatever personal scripts/tools help them engage with the endpoint more efficiently.
In Mosaic proper, the concept of an assignment is consistently used to mean the assignment of a user to a workspace during an experiment. But if Ben or Mati want to make their own script, to be run on their own computer, and use that concept to mean something else, that's fine by me. So don't take anything in mosaic-api-scripts too seriously as a means to better understanding the internals of Mosaic proper.
Relatedly, if a script from mosaic-api-scripts creates a bunch of "assignment" objects, these are just entities on Ben's computer or Mati's computer, and these objects are assisting them to create a GraphQL request to send to the Mosaic API endpoint. There's no sense in which these entities exist in the actual Mosaic backend. Indeed, the Mosaic API endpoint never modifies the Assignments table in any way.
So, returning to your second-to-last bullet point, the assignParticipants script doesn't actually create any rows in the Assignments table. This comment should also help illustrate why the assignParticipants script has honest1 and honest2 references but these don't appear in the Mosaic backend. The scripts and the Mosaic app are just two separate things.

Thanks for the detailed response!
I particularly appreciate the history around the term oracle, how it's evolved as Mosaic has changed, and the degree to which the current state of our object models has substantial influence from the older UX. I'm also taking away that the API scripts are more 'bolted on' than designed in-tandem with Mosaic, and will lower my expectation that the terminology shares semantics across repos.

meta: I haven't caught out with this thread, but I just posted the following on Slack, and realized I should probably post here instead.
tl;dr / bottom line: it seems we now need the API to support updating tree assignment
Anna just finished L1. I was going to assign Anna to 10 trees as HE and 10 trees as ME in L2 to get them started right away, but I just realized that the proper way to do it would be to assign them to one-third of all trees for each role (or something like that) with alternating priority (ex.: HE for the tree with priority 1, ME for the P2, J for the P3, etc.) in order to avoid them having only one role for long periods of time. Just adding more trees to assign Anna would result in Anna being judges on a bunch of higher priority trees. We could add a series of tree with incrementing schedulingPriority starting with 1, but a) everytime we'd do that, we would push back the date at which the current trees would be completed, and b) this wouldn't allow us to (cleanly) add participants as they graduate from L1 (we'd likely want need to wait to add a bunch at the same time in that situation). And with 248 trees (soon 1000) and more L1 participants approaching graduation, doing it manually doesn't seem like a viable / optimal option at all.


Prevents exceeding Max Listeners when bot dies simultaneously digging

Prevents MaxListenersExceededWarning by not exceeding max listeners such as from when the bot dies while simultaneously digging
(node:6948) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 diggingAborted listeners added to [EventEmitter]. Use emitter.setMaxListeners() to increase limit
    at _addListener (node:events:451:17)
    at EventEmitter.addListener (node:events:467:10)
    at resetPath ({ProjectPath}\node_modules\mineflayer-pathfinder\index.js:90:11)
    at EventEmitter.<anonymous> ({ProjectPath}\node_modules\mineflayer-pathfinder\index.js:294:5)
    at EventEmitter.emit (node:events:376:20)
    at addColumn ({ProjectPath}\node_modules\mineflayer\lib\plugins\blocks.js:111:9)
    at Client.<anonymous> ({ProjectPath}\node_modules\mineflayer\lib\plugins\blocks.js:327:5)
    at Client.emit (node:events:376:20)
    at FullPacketParser.<anonymous> ({ProjectPath}\node_modules\minecraft-protocol\src\client.js:91:12)
    at FullPacketParser.emit (node:events:376:20)
(node:6948) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 diggingCompleted listeners added to [EventEmitter]. Use emitter.setMaxListeners() to increase limit
    at _addListener (node:events:451:17)
    at EventEmitter.addListener (node:events:467:10)
    at resetPath ({ProjectPath}\node_modules\mineflayer-pathfinder\index.js:91:11)
    at EventEmitter.<anonymous> ({ProjectPath}\node_modules\mineflayer-pathfinder\index.js:294:5)
    at EventEmitter.emit (node:events:376:20)
    at addColumn ({ProjectPath}\node_modules\mineflayer\lib\plugins\blocks.js:111:9)
    at Client.<anonymous> ({ProjectPath}\node_modules\mineflayer\lib\plugins\blocks.js:327:5)
    at Client.emit (node:events:376:20)
    at FullPacketParser.<anonymous> ({ProjectPath}\node_modules\minecraft-protocol\src\client.js:91:12)
    at FullPacketParser.emit (node:events:376:20)

Removing pending listeners on death prevents the stack up of listeners as it would be unlikely the bot will be able to dig in same locations when dead. Therfore not having any MaxListenersExceededWarning from node, also improving performance.

Thanks for this fix. Can you reopen the PR in mineflayer directly ? That way it can benefit everyone, not just the users of pathfinder plugin.

@Karang https://github.com/PrismarineJS/mineflayer/pull/1850 Does this look fine?

@Karang PrismarineJS/mineflayer#1850 Does this look fine?

I left a comment there. Thanks.


Incorrect Warning/Caution calculation when buying building/upgrade

Cps increase after buying a building or upgrade isn't included in calculation, when displaying warning/caution banner about putting player under number of cookies required for lucky or frenzy. It takes into account bank balance after purchase but not Cps. If i have
Cookies in the bank - 175 B
"Lucky" Cookies required - 160 B
and hover over upgrade costing 10B that will increase Cps by 30%, it doesn't show any warning about going under required limit. After purchasing i have 165B cookies in bank but obviously limit increases considerably and I'm under it.
It seems to check current limit instead of calculating what the limit will be after Cps increase from purchase

This is intended.  It's actually more efficient this way.  But for those who like the other way, the option is there.  It's called "Calculate Tooltip Warning/Caution With Bonus CPS ON/OFF".  Is that what you are looking for?

Yeah, thank you. Sorry for false alarm. Could you briefly explain why it's more efficient, or refer to some source on that?

Hmm, I forgot the exact reason, but it's more efficient because if you compare the amount of time to gain the extra bank for the CPS increase with the old CPS vs the amount of time to gain the extra bank for the CPS increase with the new CPS, the time is shorter with the new CPS.  I hope I explained that clearly, lol.


Variable color pallete

Create an variable for each color that we'll be using in the css root.

I have made variables for each color that we will be using.


WIP new feature: audit config files

I started working on the new feature to audit config files passed as a command line argument. Right now it works only for securityContext. It needs to be ported to other features too.
I am not happy about of lot of stuff in this PR mostly regarding code quality. Need lot of interface love.  Sorry I was in hurry could not make code more clear.
It is just a proof of concept that is possible to do so.

@jinankjain Want to take a look and tell me what you think about my changes?

Everything works now could be squashed into one commit and mergerd 👍  @klautcomputing


How can have more than 1 facebook page attached to my bot

I have 5 pages and I would like all of them to use the same botkit instance but inside my code I would also like to know which page exactly sent the request.
Is this possible and how can I do that?

Take a look at this thread:
https://github.com/howdyai/botkit/issues/914
In the meantime, you should probably have a unique botkit application per page, as I mentioned in your earlier post.


Adding  getter for startX and startY in moveToAction

Correcting the error specified in the issue 4980 (https://github.com/libgdx/libgdx/issues/4890). Since the attributes are private, there is no risk in exposing them via getter.

These should probably have javadocs that state that the values are only valid after the action is begun.


[IO-776] Fix parameters to requireNonNull call

Currently, the call checks that the literal string "prefix" is
non-null, which of course it is :)

This felt small enough to get by without a JIRA ticket, but I'm happy to file one if you'd like.

Merged! Thanks again @cpovirk


more control around deleteUser

Is your feature request related to a problem? Please describe.
Client provides a way to deleteUser. There is no guard in order to control this behaviour. We may need configurations for disabling this API.
Example useCases: when user has a subscription with dues, cleanup jobs before and/or after delete
Describe the solution you'd like

hooks for before and after delete
config for disabling delete API entirely

You can currently disable it by creating a plugin or checking in your handler if the pathname contains /delete-user. But, we plan to add more configurability around this in 1.1.0. Regarding hooks, we are working on a new API to handle them better, but for now, you can create a plugin to address this as well.


admin账户登陆时提示403错误：CSRF verification failed. Request aborted.

我是用Docker在Openwrt系统中部署的，不知道是不是缺少了什么第三方库还是别的环境参数？

Suggest you read these issues first
https://github.com/WongSaang/chatgpt-ui/issues?q=is%3Aissue+CSRF
On Thu, Mar 23, 2023 at 3:58 PM duanyunlun @.***> wrote:

我是用Docker在Openwrt系统中部署的，不知道是不是缺少了什么第三方库还是别的环境参数？
—
Reply to this email directly, view it on GitHub
https://github.com/WongSaang/chatgpt-ui/issues/62, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALAX6FAMPEZIWVTAXVFX4CLW5P7BDANCNFSM6AAAAAAWE2SMMU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

谢谢，已解决


Invalid parsing of range operator if it starts with a number

Variables used in the range operators .. and ..= do not yield definition information, nor do they jump to definition when pressed F12.
For example, the following:
for n in 0..MAX { ... }

Hovering on MAX or pressing F12 does nothing.
I remember it used to work before...

Ah, the Rhai panel gives the answer:  0..MAX is parsed as 0. (float) . (period) MAX (identifier) instead of a range.
Maybe that is the reason why we're not getting definition.

A period . following a number is only parsed as a digit if it is not immediately followed by another period.  Therefore, .. is always parsed as a range operator instead of a decimal point, with ..= again trumping that.

I believe the LIT_FLOAT regex needs to prevent taking a decimal point when it is ..

Just discovered one more issue with the float regex.
Based on user request, I allow a decimal without a following 0 for floating-point numbers.  Meaning that 3. parses to 3.0.
However, the following is not allowed:
3.e2    // this parses as (3).e2, accessing the e2 property of integer 3
3.0e2    // this parses as 3.0 x 10^2

Right now, the regex still parses 3.e2 as 3.0e2 which is not proper.
Essentially, the decimal period must have a forbidden following of . or e.

This can be some form of:
[0-9][0-9_]*\.  // cannot be followed by another .
| [0-9][0-9_]*(\.[0-9][0-9_]*)?(e([+\-][0-9_]+|[0-9][0-9_]*))?

I don't think Rowan allows look-aheads, so I don't know how to prevent splitting ..

Yeah looks like we have to hack around this manually, since logos has no or limited internal storage and does not support lookaheads, nor can we rewind it.
We need to store the tokens temporarily, and inspect each float token to see whether they end with a . and whether they are followed by another . and optionally a =, and reconstruct the tokens from there to resolve the ambiguity, sounds like a PITA.

Actually nevermind, we can still do this at the tokenization level, by introducing something like a FLOAT_RANGE that will always match the problematic part with something like [0-9][0-9_]*\.\.=? and then split it up manually.

Alright, these seem to have been fixed with 6e6568d2b276ce83d32c3e00e851a03d962b23a9 and a5134c02cc2552c8c268f8431c57d8f931c18e38.
I did what I wrote in the last comment, but unfortunately it was not possible in logos callbacks alone, so I introduced a proxy that optionally splits up these tokens somewhat transparently.
The range fix is fixed by matching [0-9][0-9_]*\.\.=? and splitting it up.
The float fix involves special-casing 123. in the float regex so that  123. is possible, and the rest can only appear valid if there are integers following the dot immediately.
And then another ambiguity appeared, 1.foo was parsed as float+integer. So I did the same as above and matched integer+dot+ident in a single token and split it up afterwards.

And then another ambiguity appeared, 1.foo was parsed as float+integer. So I did the same as above and matched integer+dot+ident in a single token and split it up afterwards.

I wonder why 1.foo can be parsed as a float + integer?  Since foo is never an integer...

My bad, float+ident.


User actions (moving and/or resizing browser windows) impact test results

Setup:
testcafe -v 1.9.0-alpha.2
node -v v12.16.1
The test:

import { Selector, ClientFunction } from 'testcafe';

fixture `Devexpress`
    .page('https://www.devexpress.com');

test('Switch to the previous window', async t => {
    const testcafe = await t.openWindow('http://devexpress.github.io/testcafe')
          .switchToPreviousWindow()
          .openWindow('http://devexpress.github.io/testcafe/documentation/');
});

Current behavior:
Sometimes (not always!) and, seemingly, only when the browser window is resized or moved during the test, the Cannot find the previous window error is thrown. I do not know if this behavior is related to the newly implemented window management functionality, or if it can be reproduced in earlier versions of testcafe.
The following screen recording shows two consecutive launches of the same test with two different results (BANDWIDTH WARNING: 5MB GIF):

Expected behavior:
Consistent test results

It looks like the cause of the issue is the problem with FF, which was fixed in https://github.com/DevExpress/testcafe/pull/5867
I was able to reproduce the issue on the TestCafe 1.10.1 version, but I cannot reproduce it on the 1.10.2-alpha.1 version.

It looks like the cause of the issue is the problem with FF, which was fixed in https://github.com/DevExpress/testcafe/pull/5867
I was able to reproduce the issue on the TestCafe 1.10.1 version, but I cannot reproduce it on the 1.10.2-alpha.1 version.


Modify molecule scenarios to test Oracle Linux 8

Description
This PR aims to add molecule scenarios for Oracle Linux 8 support
Also installed the package tzdata-java in dockerfiles as it was missing in oracle8 java8 and oracle8 java11
Fixes # 2478
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update

How Has This Been Tested?
amd64 + zk     2199 2203
arm64 + zk      2198 2202
amd64 + kraft 2207
arm64 + kraft  2208
Checklist:

[X] Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
[X] I have added tests that prove my fix is effective or that my feature works
[ ] If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
[X] My code follows the style guidelines of this project
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] Any dependent changes have been merged and published in downstream modules

Is it not possible to modify the dockerfiles which were used in rhel8 and use in oracle8 instead of using rhel9 files? It works with those files but is quite confusing and looks incorrect to use oracle8 image on rhel9 dockerfiles.
If this is not possible, I believe it will be better to rename the rhel9 dockerfiles to something more generic if we're using the same files for oracle8 as well.

Adding to the above comment, which image is using dockerfile-rhel-java* files now? Are those files even required if dockerfile-rhel9-java* files can work for both rhel8 and rhel9?

I think we dont need separate files for rhel8 and rhel9. They are having insignificant differences. we can use a generic dockerfiles for rhel8,rhel9,oracle8,oracle9


Spyder won't launch after Installing Driver for USB 3.0 Docking Station

Description of your problem
Hi,
I am using Spyder through the WinPython-64bit-<IP_ADDRESS>Qt5 distribution. To add a third screen to my Laptop I started using a USB 3.0 Docking Station. After Installing the driver "Generic Driver for ThinkPad USB 3.0 Docks and Adapters" Spyder won't launch. Uninstalling the Driver fixes the problem, but my question is if this is a known issue and if there is a way to use both Spyder and the Docking Station.
What steps will reproduce the problem?

Install Generic Driver for ThinkPad USB 3.0 Docks and Adapters
Try to run Spyder

What is the expected output? What do you see instead?
I expect Spyder to launch. Instead the cursors changes to a loading symbol, after that nothing happens.
Versions and main components

Spyder Version: 3.2.4
Python Version: 3.6.3
Qt Version: 5
PyQt Version: 5.9
Operating system: Windows 7 Professional

If I need to provide any additional information please let me know.
Thank you
Hagen

I am using Spyder through the WinPython-64bit-<IP_ADDRESS>Qt5 distribution

Please report this problem with the WinPython guys:
https://github.com/winpython/winpython/

I will do that, thank you for taking the time to answer my question!

Also, I previously used one of those things (DisplayLink) and the driver had a lot of known conflicts and problems on their side.


[iOS] Update linker flags for Xcode 15.2.

Xcode 15.2 fixed the linker bug, so ld_classic is necessary only for older versions of Xcode 15.

Thanks!

Cherry-picked for 4.2.2.

Cherry-picked for 4.1.4.


Missing X11 Window Flags

I noticed some missing window flags such as SDL_WINDOW_VULKAN which is presumably due to not supporting Vulkan (yet?) but the following are X11 and should probably be supported:
SDL_WINDOW_ALWAYS_ON_TOP
SDL_WINDOW_SKIP_TASKBAR
SDL_WINDOW_UTILITY
SDL_WINDOW_TOOLTIP
SDL_WINDOW_POPUP_MENU

Additionally, there doesn't seem to be a helper function (ie. Window.getFlags()) to easily get the flags as an object.
I would love seeing those added. Thanks for the great work so far!

@Blade67 Thanks for the request. In v0.7.1 I have added the alwaysOnTop, skipTaskbar, popupMenu, tooltip, and utility flags to createWindow(). For getting the various flags, use the corresponding properties of the window object.
I'm not sure how vulkan can be supported from javascript. My plan was to just use WebGPU. I have made some progress over here.


Change profiler scripts to handle hungs

Change profiler scripts to handle hangs, because we want that AWX should be able to proceed with other tests from folder.

Can you provide the step to reproduce?

@jliangTT yes, the assignee is correct. This is issue specific to test infra Syrmia team has built, it is not about general hangs in tests.

understood.


Switched to color-brewer scales

You can play with the color set as you like, I also made a version that uses linear scale, so you don't have to pick buckets, but you do you.

Thanks for submitting a renewed color set, works perfectly!


languages/nix: change nixpkgs-fmt to nixfmt (rfc-style)

Replaced nixpkgs-fmt with nixfmt-rfc-style, as the former has been deprecated for a few years.

Can you add an assertion or set nixpkgs-fmt to a throw so that we can display a proper error message for those who set it to nixpkgs-fmt explicitly?

Rebased around 0.7 since main is currently in a feature freeze.


Optional use of pre created signature key

Generation of the signature key is the most expensive part of this library.
This approach is necessary for generation of hundreds or even thousands of URLs.
I'm using this to deliver HLS video from CloudFront R2, we have videos with 5+ hours and thousands of fragments that have to be signed individually.

Thanks for the PR.
How about, instead of changing the call signature of getSignedUrl(),

directly export the existing getSignatureKey(...) function from mod.ts
add an optional signatureKey?: string property to GetSignedUrlOptions
update

const signatureKey = preSignatureKey || getSignatureKey(parsedOptions) to
const signatureKey = parsedOptions.signatureKey || getSignatureKey(parsedOptions)

I've updated the module to directly export getSignatureKey() and removed the redundant getPreSignatureKey() (see README). function. It's deployed as 2.1.0. Thanks @luanlmd for contributing!


Unexpected Listen Error

Quasar.exe > Settings > Click "Start Listening"
When you do these steps the and press  "Start Listening"  i got an "Unexpected Listen Error"

It should have listening on that port but instead gave me that error.
Im using windows 10
Java SE 18
Microsoft .net 6.0.6 runtime
C++ Redistrib

Please use a different port on your system. The port you've chosen is already in use by some other software.


data problem

1.what is the significance of your choice of these two datasets and why is the DIJA2012 dataset for data from 1990 to 2021 and the DIJA2019 dataset for data from 2008 to 2021?
2.The result images are both for 2008 to 2021, so what is the role of the DIJA2012 data please

The datasets are set so that the stocks have been available throughout the whole range of dates. For example, the stocks from DIJA2019 had been available from 2008 to 2021. Only the DIJA2019 dataset is used in the code and experiments.


Allow whitespace in templates

Summary
Currently Argo does not allow white space in templating, rendering of {{workflow.parameters.variable}} does correctly work, however {{ workflow.parameters.variable }} doesn't render the variable. Also argo lint did not issue any warning or error.
Use Cases
I often find it more readable when you can add whitespace to separate markers like {{ and }} from variable names.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Good idea. Would you like to investigate how to fix this?

I'm not that proficient in Go, but looks like in function Replace this https://github.com/argoproj/argo/blob/8facaceeb3515d804c3fd276b1802dbd6cf773e8/workflow/common/util.go#L375
could probably be replaced with:
  replacement, ok := replaceMap[strings.TrimSpace(tag)]

Want to submit a PR?

👍 let me have a look

There you go, PR #4310

btw I had to make a few Makefile adjustments to be able to build (see PR #4311)


Adding support for Zstd Compression

The current API of TFRecordOptions only supports:

no compression
GZIP compression
ZLIB compression

With this PR, I have added support for a 4th compression algorithm, ZSTD: https://github.com/facebook/zstd/
The API for TFRecordOptions is therefore updated to accept the following parameters:
      compression_type: `"GZIP"`, `"ZLIB"`, `"ZSTD"` or `""` (no compression).
      zstd_input_buffer_size: int or `None`.
      zstd_output_buffer_size: int or `None`.
      zstd_flush_mode: int or `None`.
      zstd_nb_workers: int or `None`.
      zstd_compression_level: 0 to 19, or `None`. Default: ZSTD_CLEVEL_DEFAULT.
      zstd_compression_strategy: 0 to 9, or `None`. Default: 0.
      zstd_window_log: between ZSTD_WINDOWLOG_MIN and ZSTD_WINDOWLOG_MAX. Default: 0.

Maintaining backward compatibility with the current API.
Note: the branch is called adrian-compresssion-r2.6, as originally it was based on r2.6, but it has been since updated to match current master branch<PHONE_NUMBER>066c4eb5cb0453d7f82d929551a24e

Please open feature PRs against master.

Please open feature PRs against master.

I am still actively working on the PR, and until I have a working version, I am sticking to a stable release as origin.
Nevertheless, thanks for the heads up!

Given the amount of changes you will have a lot of conflicts when you migrate to master. Note that we never merge release branches back into master.

Also, CI on the release branch is not the same as on master, so you should not rely on its results

@mihaimaruseac I have finished and refined the PR contents, and it is now ready for review :)

I am curious, why does the Code Check - Changed Files step fail? When clicking into the details it shows "The specified bucket is missing".
Also import/copybara fails, and there are no details as to why.
Is there anything I am missing and should I take action to correct these failures?
Thanks a lot in the meantime!

Oh, the CI setup changed on master recently. Can you rebase to the top of the branch, please?

@mihaimaruseac I think I have a mismatch of clang-format version, as executing clang-format --style=Google -i tensorflow/python/lib/io/record_io_wrapper.cc outputs a different result from the one in the Code Check step.
I am using Ubuntu 18.04 with clang-format --version:
clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)

Any way of knowing which clang-format version it's used in the CI step?

C++ linter is complaining:
No message!
(in test file /usertools/code_check_changed_files.bats, line 36)
  `[[ ! -s $BATS_TEST_TMPDIR/needs_help.txt ]]' failed
clang-format is recommended. Here are the suggested changes:
=============================
diff --git a/tensorflow/python/lib/io/record_io_wrapper.cc b/-
index e9d403da44d..00000000000 100644
--- a/tensorflow/python/lib/io/record_io_wrapper.cc
+++ b/-
@@ -356,16 +356,17 @@ PYBIND11_MODULE(_pywrap_record_io, m) {
            [](PyRecordWriter* self, py::args) {
              MaybeRaiseRegisteredFromStatus(self->Close());
            })
-      .def("write",
-           [](PyRecordWriter* self, tensorflow::StringPiece record) {
-             tensorflow::Status status;
-             {
-               py::gil_scoped_release release;
-               status = self->WriteRecord(record);
-             }
-             MaybeRaiseRegisteredFromStatus(status);
-           },
-           py::arg("record"))
+      .def(
+          "write",
+          [](PyRecordWriter* self, tensorflow::StringPiece record) {
+            tensorflow::Status status;
+            {
+              py::gil_scoped_release release;
+              status = self->WriteRecord(record);
+            }
+            MaybeRaiseRegisteredFromStatus(status);
+          },
+          py::arg("record"))
       .def("flush",
            [](PyRecordWriter* self) {
              MaybeRaiseRegisteredFromStatus(self->Flush());
You can use clang-format --style=Google -i <file> to apply changes to a file.

Hi @IAL32 Can you please check build failures. Thank you!

Hmm, I have the following errors I don't currently understand:

PyLint - The config file tensorflow/tools/ci_build/pylintrc doesn't exist!.

I don't think this has anything to do with my changes, I'll rebase and see what happens.

Community CI Build - ERROR: The project you're trying to build requires Bazel 5.1.0 (specified in /workspace/.bazelversion), but it wasn't found in /usr/local/lib/bazel/bin.

This seems to be a problem with the build agent not having the required bazel binary.
About the other failures, I am working on them, but it may take a while.
Thanks!

https://github.com/IAL32/TUMWS21GR
In case anyone is interested, this is part of a guided research project @ TUM. I have written a report detailing preprocessing pipeline speeds using this implementation of Zstandard.

Hi @IAL32 Any update on this PR? Please. Thank you!

Hi @IAL32 Any update on this PR? Please. Thank you!

Hi @IAL32 Any update on this PR? Please. Thank you!


Fix maven output window links for newer versions of Maven

This patch was already submitted (and IIRC, accepted) in the netbeans.org hg repo, but was applied after the Apache contribution snapshot was made.  Output window stack links for test results have been broken for some time when using multi-module projects with newer versions of Maven.  I've run with these patches for 9 months and observed no problems as a result.

I don't see any reason not to merge this. Any comments, objections? If no responses, will merge in 24 hours.

OK, no objections, merging.


feat: Basic implementation of wheel sideslip control

Resolves #62

Note: This is still rather crude, but it will at least prevent the robot from acting like it's on ice. I'll be making more improvements to this as part of a larger physics refactor


Create ABAPDoc Comments in Your Class

Sorry but i have an issue , the below is not validated as a valid answer
"! @parameter PLANETYPE | Type of plane
i don't know why ?
Tutorial URL: https://developers.sap.com/tutorials/abap-dev-create-abapdoc.html
Step 9

Hi WKRazik - I commented in your other (identical) post.
Please close this duplicate.
Best wishes, Julie.


Make it easy to 'inherit' config for filters (listener->vhost->route)

The current model of filter config is we usually do a complete override of the parent config when we add a vhost or route config. The reason for this is not an aesthetic or intentional one, but rather that the current implementation makes inheritance-based configuration unwieldy and unperformant. It's also impossible to correctly verify that the merged/inherited config is valid at config-time; we don't have access to the merged config until the filter begins work.
For example, see FileSystemBufferFilterMergedConfig - a horrifying thing that has to be reconstructed for each filter instance.
The premise of this issue is to make it so that during createRouteSpecificFilterConfigTyped, we have access to the parent config protos, and thereby can perform a merge relatively easily, just once, at config-time, including validation.
One possible wrinkle with this idea is in a case where the config looks like
listener {
  httpfilter{ecds_dynamic_my_filter},
  vhost {
    route {
      httpfilter{my_filter{x:1, y:2}}
    }
  }
}

An update to the dynamic config in this context may not automatically re-call createRouteSpecificFilterConfigTyped for the potentially-impacted 'child' filters (e.g. a hypothetical change from z:3 to z:4 should update both versions of the config), so it may be necessary to also explicitly do that as part of this change.

(Note: I just discovered getMergedPerFilterConfig exists; this simplifies the operation slightly, but doesn't merge with the listener-level config, and doesn't address merging performance issues.)
One possible solution to this issue would be to leave the existing structure alone, but add a helper cache utility so that a config merge operation can easily be performed once (per thread? or readwritelock?) after which a shared_ptr could be looked up for a given set of route/vhost/listener filter configs. This would eliminate the repeated merge cost, and reduce the complexity of implementing traversal per filter, similar to getMergedPerFilterConfig but with also merging the base listener filter.
One possible issue with this model is that per-route configs are delivered to filters as references, not shared_ptrs, so there would be no easy way to detect when a per-route config no longer exists and should be removed from the cache. This could potentially lead to a slow memory leak, if per-route configs are changed regularly and per-listener configs are not. To resolve this, the cache config object could be a member on a per-listener config object, to reduce lookup complexity, which would prevent memory leaks. Potentially the cache object could require the per-route config objects to inherit from a MergeableConfig type whose destructor could then remove it from any caches.
i.e.
MyFilterListenerConfig contains a shared_ptr<MergedConfigCache<MyFilterListenerConfig, MyFilterRouteConfig, MyFilterMergedConfig>>
MyFilterPerRouteConfig implements MergeablePerRouteConfig
MergeablePerRouteConfig, upon being merged by a cache object, captures a lambda to remove itself from the cache, which is called during its destructor.
(note, MyFilterListenerConfig, MyFilterRouteConfig and MyFilterMergedConfig may all be the same type, or 2:1, this would be up to the filter implementer.)

getMergedPerFilterConfig also doesn't help with the inability to verify merged config at config-time. E.g. there's no way to verify that a given field must be set in either per-filter or per-route config.

Good point. My proposed cache-based solution also doesn't help with that, since it still postpones the first merge until the filter tries to use the combination of configs, which is too late to verify config validity. So it looks like the original "do something that's probably very complicated" proposal may be the only way that really achieves all the goals for the issue.


Support overflow-checking variant of negate kernel

Which issue does this PR close?

Closes #2662.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Thanks!


feat(localize): updated translation from Crowdin

:tada: This PR is included in version 3.24.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Make oneup compilable as rebar dependency and introduce priv_path env var for NIF loading

Make oneup compilable as rebar dependency and loadable from escript by introducing priv_path as env var now used during NIF loading.
It was tested as rebar dependency inside a couple of escripts that use oneup (I had to manually run make all from _build/default/lib/oneup at first)  However with addition of this rebar.config, priv/oneup.so was created during rebar3 escriptize of the dependent script.   Also loaded no problem after -oneup priv_path \"_build/default/lib/oneup/priv\" was added to the escript's rebar.config escript_emu_args

Many thanks!


fix: 🐛 Correctly map claim data for StatTypesAdded event

Description
Testnet broke on adding claim issuer info while setting stat types - https://polymesh-testnet.subscan.io/block/14582125.
Data was incorrectly mapped without considering object type property for claim type.
Also, claim type ID was not getting tracked (in case the claim type was Custom). This adds the customClaimType attribute as well
Breaking Changes
NA
JIRA Link
DA-1265
Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward


wessembly support

There are currently very few frameworks like yew that support building web application as web assembly.The web assembly is bound to take over in near future. If we (Fennec) could add support to build wasm(wasi) backend in dart.That could help in attracting more developers.

hey,
thank you for opening an issue. do you have experiences about assembly ? then we can start to add it.


Upstream development

Hi there!
I'm a part of the sigrok team and we really like what you're doing here. Do you consider this repo to be abandoned or do you still have time and motivation to work on this? If so, we'd like to eventually integrate it into the sigrok upstream repo to make it available for everyone. Is this something you'd be interested in?

Time and motivation ebbs and flows. This was going to be one component on the open source hardware HIL project I'm working on. I'm actually back at a point where I'll need to record data for test runs.
The crux of the issue is that SWIG is an automatic conversion so the Python objects end up being very non-Pythonic to work with.
For example with my dslogic, this is how the object's repr shows up in Jupyter Notebooks:
<sigrok.core.classes.HardwareDevice; proxy of <Swig Object of type 'std::vector< std::shared_ptr< sigrok::HardwareDevice > >::value_type *' at 0x7f12f9bee450> >

Which is technically correct, but annoying to work with.
I hacked together a bit longer of an example with what I was planning on doing: Sigrok_Python.pdf
Just wrapping the SWIG interface with something easier to use. I dropped into IRC last year and the 'right' way to do it seemed like more work at the time. (Something to do with defining SWIG does the conversion).
There were also some issues (that I can't remember at the time) with how some of my Analog devices were presented in Python, they were missing some essential config variables.  I ended up just thin wrapping the sigrok-cli and then reading the data file afterwards.

Is this something you'd be interested in?

If it's something that I know people would use and that the community is interested in, absolutely. I hate putting effort into polishing something only to see it idle and never used.  I'd definitely need some guidance or tutorials on what needs to be done for SWIG.

to be abandoned

My modus operandi is to start a project, get as much done while learning as much as I can until I burn out. Then shelve it until I need to do it again. A lot of my repos are either in active use privately or just future reference material for future projects.


To not consider tx fees when currency is lovelace in determination of whether bot is loosing money or not

Duplicate of https://github.com/geniusyield/smart-order-router/issues/65 which is a bug report for the case where the missing consideration of the Tx Fees caused an unexpected ADA loss.
Let's close this issue as duplicate and address the problem in the bug ticket:

https://github.com/geniusyield/smart-order-router/issues/65


lib/gst/vaapi/encoder: handle minrate

gst-vaapi encoders can support custom VBR
minrate with target-percentage property.
Thus, set target-percentage property based on
minrate/maxrate to allow future tests to tweek
the target.

Currently, gst-vaapi tests hardcode minrate/maxrate
at 70% which is the gst-vaapi encoder default.  Thus,
this change should not affect current test case
results.

target-percentage property was released in version 1.17... commit https://github.com/GStreamer/gstreamer-vaapi/commit/be496a66c5e8f93849c7c206032c179edc88824b


[fix](ES Catalog)Check isArray before parse json to array

Proposed changes
Elasticsearch does not have an explicit array type, but one of its fields can contain 0 or more values.
When the field has one value and we map it as array type in Doris, it will run into segment fault while parsing it.
So we add a check before we parse json to array.
Issue Number: close #39102

run buildall

run buildall

run buildall


bug(invoice-amt-paid): settled invoices show amt_paid

Settled invoices show the amount paid by the payee instead of the requested
value from the invoice. This involves using an updated version of the lnd rpc
protocol.
This is in response to issue #654.

Pull Request Test Coverage Report for Build 3727

0 of 3 (0.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 12.281%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/components/Activity/InvoiceModal.js
0
1
0.0%

app/lib/utils/btc.js
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

app/components/Activity/InvoiceModal.js
1
0.0%

Totals

Change from base Build 3725:
-0.04%

Covered Lines:
466

Relevant Lines:
3336

💛  - Coveralls

@wraithm there is a slight problem with this PR, which is that it will effectively break the invoice screens for users that are running anything other than the most current lnd from the master branch since they will not have access to the new amt_paid property. A lot of our users will be using the latest stable version 0.4.2.
Additionally, I think we should try to do this in a way that minimises code duplication. As it is now, you do this check settled ? x : y in several different places.
I would suggest that we decorate the invoice object with a custom property that provides the correct value based on the invoice data.
eg:
decorateInvoice(invoice) {
  let amount = invoice.value
  if (invoice.amt_paid) {
    amount = btc.millisatoshisToSatoshis(invoice.amt_paid)
  }
  invoice.finalAmount = amount
}

We can them pass all retrieved invoices through this method in our invoice reducer.
Then when we need to use the value we can just refer to invoice.finalAmount and it will provide the most relevant value.
As an example, refer to the transaction reducer where we do a similar thing: https://github.com/LN-Zap/zap-desktop/blob/master/app/reducers/transaction.js#L30-L34

Sorry for the confusion. I thought I could try to rename the branch and not destroy the PR. Please see #689.


Problem geocoding UK postcodes

We had a problem with geocoding UK postcodes with the Nokia geocoder. A query string such as "bn20 8qt" would return zero results, but "bn208qt" would be ok. In the UK, the first one is correct form and what people are used to.
The issue is in geo/geocoder.js, line 24. Commenting out this line fixed it for us, and I don't believe it's necessary for the Nokia API to convert spaces to pluses, as it seems to deal with spaces perfectly happily.
Apologies for not contributing this into the source myself. I'm a bit of a newbie with github and I didn't want to screw anything up.

you are right, if you want to send a PR I can help you with this

There has been no activity on this issue for several months and that's why are closing it (automatically). If you think this still needs to be addressed please reopen it. The good news is that we are now working on the next version of CARTO.js, stay tuned.


More log cleanups

Description
Clean-up more unused logs
Risk
None
Deploy Plan

deploy front
deploy connectors

PMRR


request that the next new releases be released as soon as possible

Your feature request related to a problem? Please describe.
The current 1.0.2 version of the middleware references the obsolete google.golang.org/grpc v1.38.0 library.
I see that the go.mod of the master branch has been upgraded, so I request a new releases version.
Describe the solution you'd like.
request that the next new releases be released as soon as possible
Describe alternatives you've considered.
request that the next new releases be released as soon as possible
Additional context.

Hello,
A new release is not required to update a dependency as a user of this library.
You just need to update the dependency on your project.

Hello,
A new release is not required to update a dependency as a user of this library. You just need to update the dependency on your project.

I don't want this line in my project go.mod，
 github.com/cncf/udpa/go v0.0.0-20220112060539-c52dc94e7fbe // indirect

NO

Sorry, I meant would you like to release a new release version? Use the current main branch

No, I don't want to create a new release only for that, as I already said you don't need it.


Significantly improve error messages

This PR improves error messages significantly:

Before this change:

This adds assertations to all of the built-in functions in Blot to throw meaningful errors when the wrong arguments are passed. It also upgrades the stack trace parsing logic, using V8's object representation and a regex built based on the SpiderMonkey and JavaScriptCore source code. Safari (JavaScriptCore) does not keep track of line numbers within eval'd code, so a hack is used to construct a data URL and import it when it is detected to be nessesary.
The previous version of Blot would give unhelpful errors like "t is not defined" on line 0, and line numbers only ever worked on Chrome in some cases. Now, it will give helpful errors explaining what went wrong, pointing to the correct position in the code on any browser.
There is a known issue where, on Safari, the stack does not follow nesting, so if the user defines a function, the error will appear where the function is called instead of within the function, but
there is no way to fix this.

This is really awesome @jeremy46231! I'm traveling for a week so I can't merge this in, but I'd love to test this out once I'm back in town

Nice work on this @jeremy46231! I'm going to merge this in and see what the community thinks.


Delete .Rhistory

My PR accidentally included an (empy) .Rhistory file, now in the master branch. You probably want to delete it. My apologies and thanks for putting together this awesome list.

deleted


Optional multiple support

on older iphones, multiple attribute was causing a lot of issues.
additionally - rewrote some stuff for better ES2015 compat and amended the npm build script to use --out-dir as -o dir/index.js was causing ENOENT when lib did not exist.
made events callbacks pass the instance as context for consistency/API.

similar issues described here https://github.com/FineUploader/fine-uploader/issues/990 etc and links to chromium bugs relevant.

done && merged upstream changes. I have kept the const/let and es2015 style imports as per my branch though it makes little difference. renamed options to inputAttributes = {}

This is looking awesome! I'm merging it now and will release a new version soon.


Document compatibility with Lua 5.3

I assume this would still work? Regardless, a yes/no in the docs would be appreciated.

As far as I've tested it is not compatible and it is documented on the github readme and first line of docs overview on website.
I've just added a small badge to github readme as well to show this.
I should make new tests for 5.3 though, to see how it goes...

I was looking at http://sailorproject.org/docs/?r=docs and it just made me wonder "does it work with 5.3 and just isn't updated on the site yet?" - something like "support for 5.3 in the works" would maybe help there.

I'm not even sure if it is possible, not because of Sailor itself but because of dependencies... :/
Btw, speaking of that, will it 5.3 work on Apache?

AIUI, Fedora22 ships with mod_lua using 5.3 - so it should work.


Please provide Q_2 for Llama 3.1 405B

This quantisation is missing rn...

I think you can use the ollama command to generate a quantized version of the model to your specification. See the help, it looks something like:
❯ ollama create -h
Create a model from a Modelfile
Usage:
ollama create MODEL [flags]
Flags:
-f, --file string       Name of the Modelfile (default "Modelfile")
-h, --help              help for create
-q, --quantize string   Quantize model to this level (e.g. q4_0)

It's no big deal for small model, but for big model like 405, it will take ages to download full fp16 and quantize.
It would be amazing if Ollama library has other quants for 405b.

We currently don't have access to the full fp16 version on Ollama; the default configuration for the 405B model is Q_4. Maybe it's possible to "downquantize" it to Q_2, or alternatively, source the full fp16 version from another source. Both options involve considerable effort, and I will need to determine whether the 405B in Q_2 offers a significant advantage over the 70B in FP16. 😅

We currently don't have access to the full fp16 version on Ollama

I thought Meta provides llama3.1-405b in fp16? Can't Ollama team just convert it to gguf and quantize based on that?

I mean we, the users, I send some of my posts to gpt for grammar correction and it sometimes messes it up

For now, you can download q2 from here and import to Ollama.
https://huggingface.co/mradermacher/Meta-Llama-3.1-405B-Instruct-GGUF/tree/main

I tried to do that with from this exact source, and I imported it to ollama, but it failed to run imported model properly, I have no experience with adding external models yet. I'll wait few days until someone will solve how to do it :)

Well I guess we should be able to quantize lower precision versions like Q2 and Q1 from the Q4 that is already provided? However that means doing some manual work locally... As people reported Llama 3 70B to still be decent in Q2, Q1 may really be exciting with 405B. Can ollama or llama.cpp do this? May be a single command right?

For now, you can download q2 from here and import to Ollama. https://huggingface.co/mradermacher/Meta-Llama-3.1-405B-Instruct-GGUF/tree/main

This appears to have been deleted, which is a little concerning.

Try this one then:
https://huggingface.co/bullerwins/Meta-Llama-3.1-405B-Instruct-GGUF/tree/main

It is possible for someone who done it to upload it on ollama on his account and share the link?
Best

Llama3.1 are being updated : https://ollama.com/library/llama3.1/tags
and 405B is provided in multiple Quantization (Q2... Q8).
@gileneusz Please close this issue to keep issues under 1000.

Great. But can we also request Q1 for experimenting?

Why Quantization to 1 Bit (Q1) is Ineffective:
Loss of Precision:
Quantizing to 1 bit means each weight and activation is represented by a single bit, allowing only two states (e.g., -1 and 1). This drastically reduces precision.
Large language models (LLMs) rely heavily on the precision of weights, and such an extreme reduction can significantly degrade the model's performance.
Complex Information:
LLMs handle complex textual data and subtle relationships between words. Q1 quantization cannot capture these nuances, leading to a significant drop in output quality.
Inference Performance:
The loss of information due to aggressive quantization can increase inference errors, possibly requiring costly correction mechanisms or additional inference steps, negating any speed and efficiency gains.
Why Quantization to 2 Bits (Q2) is Not Ideal:
Marginal Improvement:
Although Q2 offers a slight improvement over Q1 by allowing four possible states, it is still very limited compared to 4, 8, 16, or 32-bit representations.
Fine nuances in weights and activations are still largely lost, which can noticeably degrade model performance.

This is theory which was not really tested yet on large model like 405B. Real world tests done to date showed that lower bit quantizations get better performance the bigger the model is. Llama 3 70B still somehow performs in Q2, 405B may well also run in Q1. So that is why I am suggesting yet to do Q1 here. I would really appreciate it as it may show interesting things.
It is thought that LLMs have some kind of redundancy built inside the network (which may compensate for quantization) so I am really excited to see where is the quantization limit for 405B.
@igorschlum Did you make the Q2 quants yourself or where do they come from?

@kozuch do you mean for checking if Q1 405B would be better than FP16 70B? Then it could be worth it to add Q1 405B as well....

@kozuch interesting, I will try the 405b-instruct-q2_K model on my MacStudio with 192 GB of RAM. I will try to work with it. I've seen that we can ask macOS to allocate more than 66% of the RAM to the GPU. I would like Meta to launch a 180GB model like Falcon did 9 months ago. It was using 101GB of RAM and that was perfect.

@igorschlum seems like there is an issue with running q2_K
ollama run llama3.1:405b-instruct-q2_K
Error: llama runner process has terminated: error:done_getting_tensors: wrong number of tensors; expected 1138, got 1137

Well the 405b-instruct-q2_K has 2.98 bits per weight (bpw, 151/405*8) so that is almost 3 bits. We also need lower Q2 quants like Q2_K_S.
@gileneusz You should report the bug above in a separate issue.
I did not know that you can allocate standard RAM to GPU on Mac. very interesting.

Also, there are only quants for 405b instruct, not base (text). Recently Ollama library uploaded base model for 8b and 70b, but not 405b.

@gileneusz I searched on Google for the error: "llama runner process has terminated: error: done_getting_tensors: wrong number of tensors" and it seems that this issue should be resolved in latest versions of Llama 3.1 and Llama.cpp.
Ollama version 0.3.4 is currently available. Have you tried it to see if the problem is resolved? The Llama 3.1 models are being updated right now on ollama.com, and I hope that Ollama 0.3.4 will work well with those updated models.

@igorschlum It runs after update to 0.3.3, however it fits all the RAM and even swap for 10GB, I need to run this on fresh system, since I have many other stuff loaded into shared RAM, it should work. Very slow inference speed and quality is not better than q4_0 70B, but it's my opinion after just few tokens 😅

@gileneusz I will use Ollama for translation, so I hope that 405B with works well. I will see. Thank you.

It seems like meta updated 405b?
https://huggingface.co/collections/meta-llama/llama-31-669fc079a0c406a149a5738f
"Without explanation, Meta changed the number of KV heads from 16 to 8 (which now matches the whitepaper) for the 405B model. This is not just a config change, the whole model has been updated 😵"
https://www.reddit.com/r/LocalLLaMA/comments/1eoin62/meta_just_pushed_a_new_llama_31_405b_to_hf/

I try some prompts and yes, the results are worst with 405b:q3_K_S than 70b_q8_0.
I try ollama run llama3.1:405b:q3_K_S and after loads and swaps, I got an Error : Killed.
the model is 195 Gb and at the best, my mac is only 192.


UseInMemoryDatabase Nuget Package

To use the method "UseInMemoryDatabase", we need to install the nuget package named "Microsoft.EntityFrameworkCore.InMemory". This info was not provided in the doc so just thought to point that out.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 583ae3e7-5915-f22b-e54c-6c100cf2a7da
Version Independent ID: 95f2549e-29f9-e31a-b4d0-432b971643ff
Content: Tutorial: Create a web API with ASP.NET Core
Content Source: aspnetcore/tutorials/first-web-api.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

It's there


[WIP]: add custom groups

[DARFT]
Based on issue: https://github.com/benmosher/eslint-plugin-import/issues/1015
Adds a possibility to pass custom glob pattern as a custom group
Usage example
"groups": [
	"builtin",
	"external",
	"consts/**/*",
	"utils/**/*",
	"sibling",
]

guys) would be really nice to have such feature
let's discuss better API if that one is not okay

Coverage decreased (-5.0%) to 92.784% when pulling d85e5de9835e48cc20807cf0f9ccbf03e9b1c092 on ZennKa:feature/add-custom-groups into e1ed323e070216032fadd1c66eefe32c7a845052 on benmosher:master.

Coverage decreased (-5.0%) to 92.784% when pulling d85e5de9835e48cc20807cf0f9ccbf03e9b1c092 on ZennKa:feature/add-custom-groups into e1ed323e070216032fadd1c66eefe32c7a845052 on benmosher:master.

Coverage decreased (-5.0%) to 92.784% when pulling d85e5de9835e48cc20807cf0f9ccbf03e9b1c092 on ZennKa:feature/add-custom-groups into e1ed323e070216032fadd1c66eefe32c7a845052 on benmosher:master.

@ljharb that's my first PR into this repo
suppose, i can ping you :)
what do you think if such api?
i'm trying to understand if such solution is okay and continue development if so

Hey, is this being worked on? I could really use this feature. I could even help with it - just let me know what else needs to be done.

@tomasloksa if you'd like to help, please feel free to comment with a link to your own branch, and i'll pull the commits into this PR :-)


fix: fixing build

This is fixed! Should be approved before the other PR so it stops from being broken!

I also suggest squashing before merge! I can also rebase and make all this commits only one!

fixes #13


When using the setViewPager () method, while click the Tab, there will be some shake animation.

Thank for you job！
How to cancel it.

Hello. Thanks for issue. Ill try to fix this.

Here is the gif.

What is offscreenPageLimit(). If it by default, set it to itemCount - 1.

it seems not work, and sample app has the same problem. is there a solution plz?


ViewEditMode does not allow EditAction execution

Describe the bug
If ViewEditMode=View in web and execute the Edit action nothing happens
Expected behavior
It should edit the view

@larspl after this is fixed u can remove the workaround I provided, subscribe to this ticket to get notified

The DevExpress.XAF repository includes commits that relate to this task:

ViewEditMode: UnLock_ViewEditoMode_When_SwitchToEditMode_Action_Executed #450

Please update the related Nuget packages and test if issues is addressed. These are nightly nuget packages available only from our NugetServer.
If you do not use the Xpand.XAF.Modules directly but through a module of the main eXpandFramework project, please wait for the bot to notify you again when integration is finished or update the related packages manually.
Thanks a lot for your contribution.

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


Changing DI/service collection for initial ConfigureServices?

From @kierenj on July 3, 2017 7:40
My use case is a little strange, but I feel it's worth asking about..
I have an Autofac container with my app's services.  I'm hooking this up by:

Using IWebHostBuilder.ConfigureServices with services.Add(ServiceDescriptor.Transient(typeof(IStartup), typeof(AspNetCoreStartup)));
In the AspNetCoreStartup.ConfigureServices, adding any DI registrations from the passed-in services collection to the Autofac container
Returning a new IServiceProvider from that ConfigureServices which wraps the Autofac container

However, things have moved on and AspNetCoreStartup now has dependencies which need to come from the Autofac container.  However, /it's/ dependencies are evaluated using that initial (IWebHostBuilder.ConfigureServices) DI container.  AspNetCoreStartup is coordinating various service registrations (my own, but also AddMvc()).
I've been avoiding just creating concrete classes, e.g. creating a singleton instance registration for the startup class, because everything up until this point has been nice and DI-oriented.
I guess what I'm asking is, can I have my cake and eat it - specify my own service collection DI container, but have DI into the startup class using that container?
Copied from original issue: aspnet/Mvc#6484

From @davidfowl on July 3, 2017 7:48

I guess what I'm asking is, can I have my cake and eat it - specify my own service collection DI container, but have DI into the startup class using that container?

Nope.  Somewhat related to this https://github.com/aspnet/Hosting/issues/550.
Maybe there's another way to achieve what you want? Can you just do everything in ConfigureServices instead?

From @kierenj on July 3, 2017 9:9
Thanks for the response.  I don't think so - if you're talking IWebHostBuilder.ConfigureServices with the delegate, I can't see a way to have the registrations from Autofac to be used by MVC.
My workaround will be to register something like a service locator/factory/IServiceProvider that would be injected into the startup class to allow it to access the Autofac container.  It's obviously just not as nice as declaring dependencies with constructor parameters/props.
I'll track that other issue - it seems the ideal solution.  I have a similar use case: my app logic has selectable "host roles" - can run as an MVC/Web API host, message worker process, CLI for app administration, so DI is set up separately from the web host itself.  The MVC side is "pluggable", in that an app can register it's own module (via DI) which has implements callbacks called within Configure and ConfigureServices.  So I chose a difficult path and will live with it :)

Same use case/issue here.  I managed to distill this down to a small repro.  I can confirm that there are 176 registrations (add ?debug to any URL), but get errors about now: InvalidOperationException: 'Microsoft.AspNetCore.Mvc.MvcViewOptions.ViewEngines' must not be empty. At least one 'Microsoft.AspNetCore.Mvc.ViewEngines.IViewEngine' is required to locate a view for rendering.:
https://github.com/scottt732/AspNetCoreExternalDiRepro

@scottt732 I'm not encountering any issue/bug, just a design decision/limitation.  The response here says that it's not possible, by design.  You can use Autofac as a container, and add other registrations, in the Startup class' ConfigureServices (just use Populate and return an IServiceProvider which wraps Autofac).  This issue specifically is that it can't be used for the hosting/startup services (pre-Startup-class)

Please consider supporting this in the 2.1 or 2.2 time-frame.  TopShelf has a nice approach to spawning hosts using DI.  sc.ConstructUsing(() => container.Resolve<IMyService>());.  I'm curious as to whether it's a decision (never do this) or an inherent limitation (i.e., unplanned/untested).  In any case, I've found a hacky workaround that involves registering an IRegistrationSource in StartupBase<ContainerBuilder>'s ConfigureContainer(ContainerBuilder cb), deferring missed registration resolutions to the parent container.

Closing this in favor of https://github.com/aspnet/Hosting/issues/550.


ImageFolder hanging in wait state

Using imagefolder to load images for training, but it always seems to hang here:  Substituting "ImageFolder" with "CIFAR10" always works.
^CTraceback (most recent call last):
  File "train.py", line 291, in <module>
    main()
  File "train.py", line 132, in main
    train(train_loader, model, criterion, optimizer, epoch)
  File "train.py", line 157, in train
    for i, (input, target) in enumerate(train_loader):
  File "/conda3/envs/idp/lib/python3.5/site-packages/torch/utils/data/dataloader.py", line 168, in __next__
    idx, batch = self.data_queue.get()
  File "/conda3/envs/idp/lib/python3.5/queue.py", line 164, in get
    self.not_empty.wait()
  File "/conda3/envs/idp/lib/python3.5/threading.py", line 293, in wait
    waiter.acquire()
KeyboardInterrupt

this is not information for us to figure out or fix the issue.
Can you give a small script to reproduce the issue?

Sure Soumith:
I tried out Amos' DenseNet and your ImageNet examples and replaced CIFAR10 dataset with ImageFolder dataset:
Original:
trainLoader = DataLoader(
        dset.CIFAR10(root='cifar', train=True, download=True,
                     transform=trainTransform),
        batch_size=args.batchSz, shuffle=True, **kwargs)
    testLoader = DataLoader(
        dset.CIFAR10(root='cifar', train=False, download=True,
                     transform=testTransform),
        batch_size=args.batchSz, shuffle=False, **kwargs)

Modified:
trainLoader = DataLoader(
    dset.ImageFolder(root='/home/FC/data/P/train',  transform=trainTransform),
    batch_size=args.batchSz, shuffle=True, **kwargs)
testLoader = DataLoader(
    dset.ImageFolder(root='/home/FC/data/P/val',  transform=testTransform),
    batch_size=args.batchSz, shuffle=False, **kwargs)

But loading process hangs forever. Keyboard interrupt shows:
^CTraceback (most recent call last):
  File "train.py", line 291, in <module>
    main()
  File "train.py", line 132, in main
    train(train_loader, model, criterion, optimizer, epoch)
  File "train.py", line 157, in train
    for i, (input, target) in enumerate(train_loader):
  File "/conda3/envs/idp/lib/python3.5/site-packages/torch/utils/data/dataloader.py", line 168, in __next__
    idx, batch = self.data_queue.get()
  File "/conda3/envs/idp/lib/python3.5/queue.py", line 164, in get
    self.not_empty.wait()
  File "/conda3/envs/idp/lib/python3.5/threading.py", line 293, in wait
    waiter.acquire()
KeyboardInterrupt

What should I do to resolve this?
Folder structure is following with 2048x2048 PNGs:
/home/FC/Data/P
-> train -> classes -> images.png
-> val -> classes -> images.png

Closing - this was not an issue, but rather a change required to model in order to allow higher res images.
In case someone stumbles upon this issue through Google, here is a pointer on how to fix it:
https://discuss.pytorch.org/t/how-do-i-feed-higher-res-images-to-model-zoo-models/1442/2

the same issue, my reason is the input image size is not the same as the model required!

I have the same issue, but my reason is that the dataloader stuck in a loop which is my fault. so that the model cannot have input feeded.


Does mkdocs-literate-nav support horizontal tab navigation?

Hi!
This plugin works well with a well-defined SUMMARY.md file, but doesn't display the nav in horizontal tabs as defined in my yml file. I am using Material theme. Could you please clarify if I am missing something? Also, could you please tell me if I can have both the index.md that refers to the home.html and the SUMMARY.md in the root folder? Thank you!
theme:
  name: material
  language: en
  features:
    - navigation.tabs
    - navigation.indexes
    - navigation.top
    - navigation.instant
    - search.highlight
    - search.share
    - search.suggest

plugins:
  - search
  - literate-nav:
      nav_file: SUMMARY.md

I don't think there should be any problems at all with navigaton.tabs.
I have many sites that use this and it all works just fine.

https://crystal-lang.org/reference/
https://github.com/crystal-lang/crystal-book/blob/master/docs/SUMMARY.md
https://github.com/crystal-lang/crystal-book/blob/master/mkdocs.yml

https://oprypin.github.io/crsfml/
https://github.com/oprypin/crsfml/blob/master/docs/README.md
https://github.com/oprypin/crsfml/blob/master/mkdocs.yml

The only difference is that I use plugins: - section-index and not features: - navigation.indexes, could be worth trying.
Otherwise, if you can't provide a full minimal site that reproduces this problem, I can't help.


Additional documentation for overloaded mknod / cgroups in linux.devices

Building on #94, although I still prefer handling these features
independently (possible specs for that are in #98 and #99).
I'm still not clear on allow vs. deny for cgroups rules, but there's
some discussion after this comment.

Discussing this with @LK4D4 on IRC, I think if we want full cgroups handling here, we'll want to add a new allow field for non-path entries.  That would allow you to do things like:
{"type": "a", "allow": false, "major": -1, "minor": -1, "permissions": "rwm"}

to block all devices.  @LK4D4 also prefers blocking all devices by default, but the above rule is easy enough to write that I'd prefer the default to be “don't touch device cgroups”.

Oh, and this PR doesn't touch the Go type comments and whatnot.  It's just for discussing the Markdown documentation.  Once we reach a consensus there, I'll go back and update the Go comments.

Lets not make any additional changes if the real issues that people are having are with the creation and permissions being in one field.  This was split before and added alot of verbosity but we can revisit a better way if it's an issue.  Lets discuss on the mailing list.

On Mon, Oct 05, 2015 at 11:46:54AM -0700, Michael Crosby wrote:

Lets discuss on the mailing list.

Spun off into https://groups.google.com/a/opencontainers.org/forum/#!topic/dev/y_Fsa2_jJaM


Add module python win32crypt in windows11

Dear @dkmstr
This merge to hot fix bug: "Module win32crypt not found"
Link issues:  https://github.com/VirtualCable/uds-client/issues/2
Thanks for review

It's better to include it on builders (pyinstaller .spec, etc..) that pushing it into the source...
Thanks for your support anyway!!! ;-)

Dear @dkmstr
"Thank you for your response. Do we need to commit the .spec file to support PyInstaller and include a README to guide users in building the USDClient?"

Maybe an explanation or a "sample .spec" for pyinstaller maybe fine... :)
Thats a good point of help for anyone, and unfortunately, i lack the time i need to document everything as it should :(
So yes, it's a good idea to create, for example, a folder at root level called "pyinstaller" (or something like it), with a sample .spec file for Windows, maybe Mac also?, and a readme. It should help a lot others i think
So thank you very much for your interest and help!
Regards,

Maybe an explanation or a "sample .spec" for pyinstaller maybe fine... :) Thats a good point of help for anyone, and unfortunately, i lack the time i need to document everything as it should :( So yes, it's a good idea to create, for example, a folder at root level called "pyinstaller" (or something like it), with a sample .spec file for Windows, maybe Mac also?, and a readme. It should help a lot others i think
So thank you very much for your interest and help! Regards,

Yes, i will.
^-^

Thank you! ;-)


[build] Delete build/images/tf_operator/build_and_push.py

@jlewi Could we delete https://github.com/kubeflow/tf-operator/blob/master/build/images/tf_operator/build_and_push.py? I think we do not use the script to build the image.
The issue is found by @JetMuffin . Big thanks.

Great, I will open another issue to keep track the build tool.

@gaocegege Thanks


Weird behaviour of Rule C400 and C416

Ruff version: 0.3.5
I'm sorry for the long post
Hey,
I would like to document the following behaviours about rules C400 and C416
C400 error message
I have the following script scratch.py
from typing import Dict, List, Tuple

def generate_samples(test_cases: Dict) -> List[Tuple]:
    return list(
        (input, expected)
        for input, expected in zip(test_cases["input_value"], test_cases["expected_value"])
    )

I run the following command
>> ruff check scratch.py --select C400
>> scratch.py:5:12: C400 Unnecessary generator (rewrite using `list()`)

You can see that the error message is misleading. After looking into the C400 rule documentation I propose to change the error message with one of the following:

C400 Unnecessary generator (rewrite using [a for a in iterable]) or
C400 Unnecessary generator (rewrite using list(iterable)) or
C400 Unnecessary generator (rewrite using [a for a in iterable] or list(iterable)).

I can open a PR to fix that if you are interested. Let me know which error message you like the most.
Conflict between C400 and C416
Consider scratch.py equal to
from typing import Dict, List, Tuple

def generate_samples_v_1(test_cases: Dict) -> List[Tuple]:
    return list(
        (input, expected)
        for input, expected in zip(test_cases["input_value"], test_cases["expected_value"])
    )

def generate_samples_v_2(test_cases: Dict) -> List[Tuple]:
    return [
        (input, expected)
        for input, expected in zip(test_cases["input_value"], test_cases["expected_value"])
    ]

I run the following command
>> ruff check scratch.py --select C400 --select C416
>> scratch.py:4:12: C400 Unnecessary generator (rewrite using `list()`)  # this is for generate_samples_v_1
>> scratch.py:10:12: C416 Unnecessary `list` comprehension (rewrite using `list()`)  # this if for generate_samples_v_2

Clearly, C400 and C416 are in conflict (as we can understand from the documentation and from this example). Moreover, we have the following problem: C400 doesn't accept the output of generate_samples_v_1, but C416 does.
My questions:

is it correct that C400 doesn't accept the output of generate_samples_v_1, but C416 does ?
is it correct that C416 accepts the output of generate_samples_v_2?
from the documentation of C400 and C416, we are inclined to understand that C416 should contain C400. Therefore, they should not have conflicts, correct?

Without changing the rules C400 and C416, we could:

rewrite the error message of C416 as: C416 Unnecessary generator (rewrite using list(iterable))
using the error message number 3 proposed in the section C400 error message
This should clarify the situation for future users.
(Perhaps also adding a line in the documentation shortly explaining the situation could be cool)

Let me know if you are interested in the above changes

Hi!
I don't quite understand what you mean with conflict.

I understand from you that you would like that the error message is rewritten as C400 Unnecessary generator (rewrite using list(zip(test_cases["input_value"], test_cases["expected_value"])) or similar in your example. (Ruff has a fix available, so you could also say that it is not really needed)

The both rules are not in conflict. C400 is for generator expressions, while C416 is for list/dict/set comprehensions. Your function generate_samples_v_1 contains a generator expression, your function generate_samples_v_2 contains a list comprehension. These look similar, but are not exactly the same.

The both rules are not in conflict. C400 is for generator expressions, while C416 is for list/dict/set comprehensions. Your function generate_samples_v_1 contains a generator expression, your function generate_samples_v_2 contains a list comprehension. These look similar, but are not exactly the same.

Thanks for your answer. Now I understand better the situation, and I think that probably there are no problem at all. I was just confused.


Update README

Update readme to use cloud foundry command line and registration via game-on.org and remove unnecessary settings from manifest.yml.

This change is

Reviewed 1 of 2 files at r1.
Review status: 1 of 2 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Retract v0.4.0

This change retracts v0.4.0 and reverts #103.
#103 shouldn't have been released. It is blocking us from updating the contrib collector because pkg/trace in datadog-agent isn't updated with these changes. Furthermore, those changes aren't yet out.

cc @truthbk we are (temporarily) reverting your PR, it shouldn't have been merged until the pkg/trace changes were released. We can add it back once they have landed


[FEATURE] Connect and Disconnect commands

where are connect and disconnect commands? yes ik i can use gui, click and text commands

They have not been implemented due to laziness... Yes you can use Gui, Click and Text.
You can also specify a server to join on launch: https://github.com/3arthqu4ke/HeadlessMc/issues/8#issuecomment-1159464185
if that helps.

i noticed that and i am trying to implement them myself but i am unable to figure out how

You can also specify a server to join on launch

i have to edit the configuration file, i can't just do hmc launch profile -args "--server <IP_ADDRESS>" or something similar

although i think implementing a --server is simpler than a connect command

Now available in 1.19.3 and 1.12.2 and future releases. Might backport to other versions.


PSR-16 cache

See #6252. Merge with https://github.com/silverstripe/silverstripe-cms/pull/1741

Review is done. Please address the above + wait until green, then I approve the merge of this PR.

OK, I've tried this with PHP7.1 and opcache enabled. On a base install, I've navigated around each CMS section and performed some basic user actions to fill the cache. I get the following stats of opcache_get_stats():
array (
  'opcache_enabled' => true,
  'cache_full' => false,
  'restart_pending' => false,
  'restart_in_progress' => false,
  'memory_usage' =>
  array (
    'used_memory' => 23541384,
    'free_memory' => 43546832,
    'wasted_memory' => 20648,
    'current_wasted_percentage' => 0.03076791763305664,
  ),
  'interned_strings_usage' =>
  array (
    'buffer_size' => 4194304,
    'used_memory' => 2035240,
    'free_memory' => 2159064,
    'number_of_strings' => 39877,
  ),
  'opcache_statistics' =>
  array (
    'num_cached_scripts' => 693,
    'num_cached_keys' => 1315,
    'max_cached_keys' => 3907,
    'hits' => 10542,
    'start_time' =><PHONE_NUMBER>,
    'last_restart_time' => 0,
    'oom_restarts' => 0,
    'hash_restarts' => 0,
    'manual_restarts' => 0,
    'misses' => 959,
    'blacklist_misses' => 0,
    'blacklist_miss_ratio' => 0.0,
    'opcache_hit_rate' => 91.661594643944,
  ),

In its default configuration of 64M, the bytecode and custom caches in core fill up 30% of the available memory. I've noted that in the caching documentation, recommending to increase memory or enable the filesystem fallback for larger apps.
I've also benchmarked locally a bit (homepage with default theme), with opcache.enabled=1 I get 170ms mean response time, without I get 245ms mean response time. Without opcache means it's using filesystem cache (since I don't have APC installed).

I've written a ticket on symfony/cache filesystem purge: https://github.com/symfony/symfony/issues/21764

OK this is passing (except for CMS) and it looks like @tractorcow's comments have been addressed. I'm merging!

Excellent work @chillu . I just sat down to review and it'd been merged. :)


chore(navigation-bar): add additional className for content wrapper

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 84.458%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
9754

Relevant Lines:
10670

💛  - Coveralls


prevent default event of the browser

Currently, selectedYear state is stored in the URL of the website, with the current year as a query parameter.
When someone clicks on any of the year filters — shown below — a scroll event is triggered. This can probably be fixed with e.preventDefault()

#27 fixes this.


Extract out photographic_memory

Photographic Memory replaced much of the AssetHost core and handles encoding images, storing them, and classifying them.  Making it its own server would make it more useful as an open-source project, providing the benefits of AssetHost without requiring the AssetHost UI.

It now lives here:
https://github.com/SCPR/photographic_memory


EF Core 3.0 support

Summary of the issue
It doesn't support EF Core 3.0, could you add support for EF Core 3.0?
Thanks.

Added it via #https://github.com/VahidN/EFSecondLevelCache.Core/commit/b64d26cec84b3a3c1980e3ccdc6d5154f4a0f3ca


Building docs keeps failing

Issue description
PyPOTS documentation building has been failing since the build on Aug. 18, 2023 https://readthedocs.org/projects/pypots/builds/21647458/
This is probably caused by the update of Furo, which was released on 2023.08.17. Check out the change log of Furo here https://pradyunsg.me/furo/changelog/#wonderous-white

Tried to fix this by specifying the version of installed Furo as 2023.07.26 on the branch fixing_failed_doc. Testing build 👉 https://readthedocs.org/projects/pypots/builds/21876589/. All good. Will merge this branch.


bugfix options setting in tinymce field declaration

Proposal to fix bug in data-options for tinymce field. Previously when we set options parameter from the crud controller, it rendered like this

After this change:

A new inspection was created.

Excellent! Thank you @mahasadhu , merging now. It'll be available with a composer update on Monday, the latest.
Cheers! Super-grateful for all the help you've been giving us lately!


Support for <IP_ADDRESS> additionally to localhost

Since https://github.com/fastlane/ci/pull/200 switched to the thin web server, we now need to access localhost instead of <IP_ADDRESS>, ideally we support both. Probably just a setting in the web server somewhere

Seems to not be the case 👍


AWS: Use persistent disk on master

@iterion Here is what I think we should do for the persistent disk on AWS.  Can you PTAL?
(I was going to submit a PR to your branch, but github won't let me for some reason)
If you are OK with it, not sure how exactly we would submit this (boring legal stuff).  I think you are still the author on the first commit, and you have signed the CLA, so I think clabot should be able to figure it out.

LGTM minus my single comment.
Per @googlebot's request I can confirm I wrote the first commit and am OK with it being merged. :)

Thanks @iterion.  Cleaned up the TODO (and rebased my commits to make it tidier)

Rebased to try to get a shippable retest.
Anyone know if the removal of the cla:no tag is a manual process?

The CLA failure seems to be for @iterion - have you signed our CLA?

I have indeed, googlebot seems confused.
Other PR's of mine with cla: yes: https://github.com/GoogleCloudPlatform/kubernetes/pulls?q=is%3Apr+author%3Aiterion+is%3Aclosed

I can manually verify CLA and override bot.  Are you guys both LGTM on this?

I am (though I wrote part of it): LGTM

LGTM too.

LGTM

LGTM OK to merge

LGTM as well.