StringLiteral value is null at v0.3.0

luaparse "local m = require \"a.b.c\""
{"type":"Chunk","body":[{"type":"LocalStatement","variables":[{"type":"Identifie
r","name":"m"}],"init":[{"type":"StringCallExpression","base":{"type":"Identifie
r","name":"require"},"argument":{"type":"StringLiteral","value":null,"raw":"\"a.
b.c\""}}]}],"comments":[]}

luaparse "local m = require [[a.b.c]]"
{"type":"Chunk","body":[{"type":"LocalStatement","variables":[{"type":"Identifie
r","name":"m"}],"init":[{"type":"StringCallExpression","base":{"type":"Identifie
r","name":"require"},"argument":{"type":"StringLiteral","value":null,"raw":"[[a.
b.c]]"}}]}],"comments":[]}

The value is "a.b.c" at version 0.2.1, without this value, I have to parse the value from raw, because lua string can be wrap within [[]] or "" or ''
Is this a change in 0.3.0, if so i need to change my code.

This is intentional, introduced in commit be3c3ee863bec09ba6ae5c4e4fcfa09f7172814c. The reason is the semantic mismatch between bytestrings (used by Lua) and Unicode strings (used by JavaScript); #53 and the README file elaborate on this further. Pre-release versions handled this by mangling Unicode input into UTF-8, but I got a number of reports that this behaviour is confusing; and since most users were more interested in identifiers than values of string literals, I decided to change the default mode to one with no mangling of identifiers and no interpretation of string literals. If you want string literals parsed into their contents, you need to decide how bytestrings should map into Unicode strings by specifying the encodingMode option.
Yes, this is a breaking change. Perhaps I should have put a release note somewhere, but I'm not sure where; this project doesn't have a changelog other than commit history. But this change is why I bumped the minor release number, and not just the patch.

thank you for reply
It would be better if there is release note or a change log
I did a little search at npm page, README and release page before open this issuse, but did't find anything


Write mail to -developers and -users

To make sure everyone knows about the split-off.

Any ideas? Who can prepare this letters? How often?
Now seriously - to close?


fix OS X demo setup

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

fixed "ant start.demo" on OS X

ok to test

thanks @meadlai , merged to master


KNO-5878: Error with preference set

https://linear.app/knock/issue/KNO-5878/[flutter-sdk]-error-with-preference-sets
Fixed a bug with our parsing of PreferenceSet, specifically within our ChannelTypes and Categories

I am the customer who reported the bug and can confirm that this PR fixes the issue. Using this branch as a dependency fixes the issue and the preference set can be parsed successfully. 👍

I am the customer who reported the bug and can confirm that this PR fixes the issue. Using this branch as a dependency fixes the issue and the preference set can be parsed successfully. 👍

@flodaniel thanks for flagging this. This should now be merged in and included with version 0.1.4

Sorry to ping again but we need this bugfix to ship Knock to production. Do you think a publish to pub.dev is possible today? Otherwise we will use the github source directly as the ref.  @cjbell @matgar26


Handle laundry exceptions from Python SDK

In coordination with pennlabs/penn-sdk-python#46

LGTM

Fixed with https://github.com/pennlabs/penn-sdk-python/pull/46 merge.


After run test case in Ark Container， we should switch thread classloader

Using annotation ArkJUnit4Runner or  ArkBootRunner to run test case in ark container,  we should switch classloader after every test class in these two runners.

I think this issue is already fixed, @QilongZhang remember to attach the PR 😄


Add PATCH semantics

Having recently converted our remaining PUT routes to PATCH I thought it would be nice to unify and formalize some of the differing practices in the API.
I believe that some of these formalizations could benefit our backend testing and frontend implementations.
If PATCH returns the same value as GET, and is the same route, then frontend

wouldn't need to re-fetch updated entities (not sure if we do this often, I've seen it a good deal in past lives)
could reuse types and code used by the original GET
would (theoretically) need to manage less state since it could just trust what PATCH yields rather than having it's own duplicate state store to maintain

These formalizations are nice for the backend because

we should be able to generate tests from a description of the fields a PATCH expects and expected outcomes thereabouts
allowing for empty PATCH objects and re-fetching would allow us to implement GET /some/route/123 as PATCH {} /some/route/123, or, conversely, we could implement the re-fetching using the GET (though that's not really a benefit).

Note that  our current PATCH endpoints do not conform to these guidelines, in many cases. If this guideline is accepted I will file debt for the places that don't conform for the backend guild to prioritize.

@joris974 I think and hope so!


Exiv2 update to 0.27.4

Library name:Exiv2
New version number: 0.27.4

Exiv2 was updated to 0.27.4 an hour ago.
See: https://github.com/microsoft/vcpkg/commit/75a90ccfb1f8d1206f1fb5900c27bf14d0a9aeb7

@ndurner ,Thanks for posting this issue,this issue duplicate of #18690,so this issue will be closed


feat: Adds a control to set the Secondary Y-axis bounds in Mixed charts

SUMMARY
This PR introduces a control to set the Secondary Y-axis bounds.
It's out of the scope of this PR to improve the categorization and display positions of the controls but we should definitely do it in a follow-up PR because it's not very user friendly. @kasiazjc
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/236025589-bfc4c6bf-1371-40aa-8bcd-fb33449751d8.mov
TESTING INSTRUCTIONS
Check the video for instructions.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

If we're talking about the UI of this thing, I'd love to see all the Query A and Query B controls in tabs :)

Not sure if there are any tests that should be cloned as well for good measure, or storybook tweaks, but the logic seems fine to me!


Add support for Apache RewriteLog

Issue Type
Feature Idea
Your Environment
N/A
Your OS
N/A
Summary
I'm trying to debug a RewriteCond/RewriteRule rule that I have set on my docroot .htaccess file and I can't find where the error is, so I'm looking into enabling RewriteLog as suggested here: https://stackoverflow.com/a/9632952/847628
Looks like this needs to be done in the vhosts file (not in the .htaccess file) so I was wondering if is possible to provision the VM with this log enabled?
I am not sure if this feature request needs to go in the Ansible Role Apache project?
Thanks!

As a temporal workaround I managed to see the mod_rewrite logs doing the following:
# ssh into VM
vagrant ssh

# edit vhosts file
sudo vim /etc/apache2/sites-enabled/vhosts.conf

# enable mod_rewrite logging by adding the following into the vhosts.conf file (inside a <VirtualHost> entry)
LogLevel alert rewrite:trace6

# restarting apache
sudo apache2ctl restart

# now I can see the log updated for every request to my local site:
sudo tail -f /var/log/apache2/error.log

I imagine the change will be lost if I re-provision the machine (I haven't tested it).

@acontia - Yeah, that change would be removed once you restart.
Please see the Apache role readme file: https://github.com/geerlingguy/ansible-role-apache
What you should be able to do is override the apache_global_vhost_settings variable in your config.yml or local.config.yml.
This setting allows you to add lines to all vhost entries, like:
apache_global_vhost_settings: |
DirectoryIndex index.php index.html
LogLevel alert rewrite:trace6
Then run vagrant provision to apply the change (and on subsequent destroy/rebuilds it would still exist in there).
Thanks for filing the issue! If you have any other questions about Apache-specific customizations, please file an issue under the Apache role project: https://github.com/geerlingguy/ansible-role-apache/issues


Add search for rooms in "Lobby"

Browser search works in the meantime so can be closed if not a priority.

I'll do this.


Update unit test for new DNS multiple IP support

Description

FreeRTOS+TCP DNS now supports multiple IP answers.  This unit test needs to be updated to reflect this.
Checklist:

[ X ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Can you update the description please?
Just a technicality that the test is not a Unit test but more of an integration test or functional test at best... :)


Known issue with eslint

Currently standard is not supported.
This is due to a reported bug in eslint: eslint/eslint#4263
The error will be along the lines of:
 % ./node_modules/.bin/standard                                                                                ied/example (master) Alexanders-MacBook-Pro
/Users/alex/repos/ied/example/node_modules/2f013912b2794ddb30bbaa89dc13fb3a990cc72b/package/rc/.eslintrc
standard-react
standard: Unexpected linter output:

Error: Cannot find module 'eslint-config-standard-react'
Referenced from: /Users/alex/repos/ied/example/node_modules/2f013912b2794ddb30bbaa89dc13fb3a990cc72b/package/rc/.eslintrc
    at Function.Module._resolveFilename (module.js:337:15)
    at Function.Module._load (module.js:287:25)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at readConfigFromFile (/Users/alex/repos/ied/example/node_modules/a75aaf07e28650772ed0e70daa2ce083079b6514/package/lib/config.js:158:44)
    at loadConfig (/Users/alex/repos/ied/example/node_modules/a75aaf07e28650772ed0e70daa2ce083079b6514/package/lib/config.js:179:22)
    at /Users/alex/repos/ied/example/node_modules/a75aaf07e28650772ed0e70daa2ce083079b6514/package/lib/config.js:210:46
    at Array.reduceRight (native)
    at loadConfig (/Users/alex/repos/ied/example/node_modules/a75aaf07e28650772ed0e70daa2ce083079b6514/package/lib/config.js:194:36)
    at new Config (/Users/alex/repos/ied/example/node_modules/a75aaf07e28650772ed0e70daa2ce083079b6514/package/lib/config.js:388:38)

If you think this is a bug in `standard`, open an issue: https://github.com/feross/standard/issues

Nothing we can do about that.

This is not a bug in standard it's due to the issues surrounding symlinking and the expectation that symlinks aren't resolved when in fact require does resolve them.

No, this is due to the fact that eslint implicitly relies on npm's nested (even after v3) dependency graph to load shared configuration files.


Large Rules Being Entirely Ignored

[x] I have read and agree to the contributing guidelines.

Describe the bug
Users have reported that creating a single massive rule performs significantly worse compared to setting it directly in the system prompt. Splitting the rule up into multiple rules might improve performance, but is inconvenient for users.
To Reproduce
from griptape.rules import Rule
from griptape.structures import Agent
from griptape.tasks import PromptTask

artifact_rule = Rule(
    """
You are a helpful AI assistant that creates well-structured responses with artifacts for substantial content.

        ARTIFACTS USAGE GUIDELINES:

        1. CREATE ARTIFACTS for:
           - Original creative, analytical and business writing (reports, data analysis, financial models, presentations) over 20 lines
           - In-depth analytical content (reviews, critiques, analyses) over 20 lines
           - Custom code solving specific problems
           - Technical documentation meant as reference material
           - Content intended for use outside conversation
           - Comprehensive guides or instructional content
           - Content that will be edited, expanded, or reused

        2. DO NOT USE ARTIFACTS for:
           - Explanatory content (explaining concepts, math problems, algorithms)
           - Teaching or demonstrating concepts (even with examples)
           - Answering questions about existing knowledge
           - Purely informational responses
           - Lists, rankings, or comparisons regardless of length
           - Plot summaries, basic reviews, or descriptions
           - Conversational responses and discussions
           - Advice or tips

        3. ARTIFACT FORMATTING:
           - Use <artifact type="code" language="[language]"> for code
           - Use <artifact type="markdown"> for documents and long-form text
           - Use <artifact type="html"> for HTML/web content
           - Use <artifact type="svg+xml"> for SVG graphics
           - Use <artifact type="mermaid"> for diagrams
           - Use <artifact type="react"> for React components

        4. GENERAL RULES:
           - Keep outputs over 20 lines in artifacts
           - Maintain conversational responses outside artifacts
           - Use artifacts only when clearly beneficial
           - Never mention or explain artifacts to users
           - Always close artifact tags properly
           - Place conversation or explanation outside artifacts
           - If in doubt, prefer NOT to use an artifact
           - One artifact per response unless specifically requested

        5. RESPONSE STRUCTURE:
           - Think through user request first
           - If artifact needed, generate content inside appropriate tags
           - Add conversational context/explanation outside artifact
           - Keep responses natural and helpful
           - Talk like a pirate

        Remember: Artifacts are for substantial, reusable content - not for regular conversation. When in doubt, err on the side of not using an artifact.
"""
)

agent = Agent()

agent.add_task(
    PromptTask(
        "Let's create a short story of american psycho for modern times",
        # generate_system_template=lambda _: artifact_rule.value,
        rules=[artifact_rule],
    )
)

agent.run()

Agent does not talk like a pirate. Uncomment generate_system_template and it does.
Expected behavior
Rules should be followed, regardless of size.
Additional context
Relevant thread

I'm struggling to reproduce a significant difference between a custom system prompt and rules. The original example shared does not output as an artifact even when using generate_system_template. Furthermore, if I add "Talk like a pirate", it does not follow unless I simplify the custom system prompt.


Merge master branch to prTesting1_202007161920 branch

Docs Build status updates of commit 4c31f08:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 4c31f08:
:warning: Validation status: warnings

File
Status
Preview URL
Details

split/updateTestCon1.md
:warning:Warning

Details

split/updateTestCon1.md

Line 0: [Warning-h1-not-first] Markdown content is not allowed before H1.
Line 1: [Suggestion-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading. NOTE: This Suggestion will become a Warning around July 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Modify authentication methods

We droped the basic auth method to rely only on the social medias ones.
We also did a small refactoration in our unit_tests, as well, our account schema, models and so on...
Solves #61
Signed-off-by: Rodolfo Olivieri<EMAIL_ADDRESS>

bors r+


Wrap Bank msg/query in sub-enum

Trying to think how to keep track of messages with many mode modules coming in soon.
Here is one thought, CosmosMsg and QueryRequest become two-level enums, first level on the module type, second on the messages of this module. It is a bit more verbose, but is much easier to register a dispatcher/router for one module and know you get all the appropriate messages

@webmaster128 please take a look at this along with https://github.com/CosmWasm/docs/pull/43
This is a sketch of how to update the message / query types. I haven't finished it yet, but when we like the direction, I will polish it off and update all contracts / tests. And use this as the basis to add the staking/swap modules

Thanks. I will make those changes, fix issue and prepare for a merge.

This should be ready now. Can you give it a final review?
I will update CHANGELOG and MIGRATING now


Rebalancing is sometimes delayed

If I start two group subscribers (same group) and there are a lot of messages to process, there are timeout errors in the log and it appears that both subscribers are elected group leader and are assigned all partitions.
(BTW, I'm using a thin Elixir wrapper over Brod.)
If I start two subscribers to the same group, if there are few messages to process, there's a rebalance, one is elected leader and the partitions are divided among the subscribers.
However, it appears that if the subscribers are especially busy, the rebalance is delayed, or never happens at all.
I do see both subscribers with elected=true and both are assigned all partitions. I also see:
12:52:01 PM consumer.1 |  group coordinator (groupId=index.6,memberId=,generation=11,pid=#PID<0.263.0>):
12:52:01 PM consumer.1 |  failed to join group
12:52:01 PM consumer.1 |  reason::timeout
12:52:02 PM consumer.1 |  group coordinator (groupId=index.6,memberId=,generation=11,pid=#PID<0.263.0>):
12:52:02 PM consumer.1 |  re-joining group, reason::timeout
12:52:11 PM consumer.1 |  group coordinator (groupId=index.6,memberId=nonode@nohost/<0.263.0>-a4a2c673-aa82-4d1a-9d95-418de65cf551,generation=15,pid=#PID<0.263.0>):
12:52:11 PM consumer.1 |  elected=true
12:52:11 PM consumer.1 |  group coordinator (groupId=index.6,memberId=nonode@nohost/<0.263.0>-a4a2c673-aa82-4d1a-9d95-418de65cf551,generation=15,pid=#PID<0.263.0>):

And:
12:50:21 PM consumer.1 |  group coordinator (groupId=index.6,memberId=nonode@nohost/<0.263.0>-893aaf83-c68c-4aaa-b448-34792fac31b0,generation=11,pid=#PID<0.263.0>):
12:50:21 PM consumer.1 |  re-joining group, reason::RebalanceInProgress
12:51:34 PM consumer.1 |  group coordinator (groupId=index.6,memberId=nonode@nohost/<0.263.0>-893aaf83-c68c-4aaa-b448-34792fac31b0,generation=11,pid=#PID<0.263.0>):
12:51:34 PM consumer.1 |  failed to join group
12:51:34 PM consumer.1 |  reason::UnknownMemberId
12:51:34 PM consumer.1 |  group coordinator (groupId=index.6,memberId=nonode@nohost/<0.263.0>-893aaf83-c68c-4aaa-b448-34792fac31b0,generation=11,pid=#PID<0.263.0>):
12:51:34 PM consumer.1 |  re-joining group, reason::UnknownMemberId
12:52:01 PM consumer.1 |  group coordinator (groupId=index.6,memberId=,generation=11,pid=#PID<0.263.0>):
12:52:01 PM consumer.1 |  failed to join group
12:52:01 PM consumer.1 |  reason::timeout
12:52:02 PM consumer.1 |  group coordinator (groupId=index.6,memberId=,generation=11,pid=#PID<0.263.0>):
12:52:02 PM consumer.1 |  re-joining group, reason::timeout
12:52:11 PM consumer.1 |  group coordinator (groupId=index.6,memberId=nonode@nohost/<0.263.0>-a4a2c673-aa82-4d1a-9d95-418de65cf551,generation=15,pid=#PID<0.263.0>):
12:52:11 PM consumer.1 |  elected=true
12:52:11 PM consumer.1 |  group coordinator (groupId=index.6,memberId=nonode@nohost/<0.263.0>-a4a2c673-aa82-4d1a-9d95-418de65cf551,generation=15,pid=#PID<0.263.0>):
12:52:11 PM consumer.1 |  assignments received:

I tested this with a topic with 32 partitions and 10k messages. If I start one subscriber, let it run for a bit, and then add another, I don't see a rebalance until almost all 10k messages are processed.
If I don't have any messages to be processed, a rebalance seems to happen almost immediately.
My observations of "busy" may be totally wrong, but it's the only pattern I've detected.
My questions is: Am I doing something wrong, or not doing something, that's causing this behavior? Or is this something I should expect from Brod specifically, or Kafka in general?
Please let me know if I can provide more information.
Thanks!

@objectuser I guess it's because the group subscriber is too busy to respond to group status change calls.
The group coordinator needs to revoke the already assigned partitions from the member before it can proceed re-balancing the group, but the revoke is a synced call to the subscriber process.
brod_group_subscriber is implemented as a member + subscriber + message_handler.
There are few things you can try:

Try fetch smaller batches (this will allow subscribers to exit the busy handle_message loop quicker).
Hand off the messages to other workers (especially when you have a lot of partitions, it makes sense to spawn one worker per partition), and ack the messages from the workers. This will make brod_group_subscriber a member + subscriber but messages are handled in workers.
Write your own group member, implement the brod_group_member behaviour so you can have your own member, then subscriber + message_handler are can be implemented in per-partition workers.

(sorry that we have made the current implementation too simple, we are thinking about a new implementation).

@zmstone I'll try and digest your suggestions.
Brod has worked pretty well for us so far and I appreciate you want to evolve it.
Thanks for your response and suggestions!


Add allow_downgrade to zypper_package resource

Description
Add allow_downgrade to zypper_package resource
Issues Resolved
none
Check List

[x] New functionality includes tests
[ ] All tests pass
[ ] RELEASE_NOTES.md, has been updated if required (not required for bugfixes, required for API changes)
[x] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

The offenses from https://travis-ci.org/chef/chef/jobs/283913559 don't match the code I edited...


Fix typo '@as' annotations in Fab and LoadingButton.

Oh man, that's what you get when you do too much multiline editing. Thank you so much for fixing this.


possible typo in quick reference docs

Describe the bug
The quick reference docs includes a section about loading a contract. In the sub-section about loading a contract from a wallet there appears to be a typo.
The current code is as follows,
const contract = new nearAPI.Contract(
  wallet.account(), // the account object that is connecting
  "example-contract.testnet",
  {
    // name of contract you're connecting to
    viewMethods: ["getMessages"], // view methods do not change state but usually return a value
    changeMethods: ["addMessage"], // change methods modify state
    sender: wallet.Account(), // account object to initialize and sign transactions.
  }
);

Expected behavior
I believe it should be wallet.account with a smaller case.
- sender: wallet.Account(), // account object to initialize and sign transactions.
+ sender: wallet.account(), // account object to initialize and sign transactions.

Additional context
I recently started developing on Near. I maybe wrong but I am using wallet.account() in my code and it seems to work.

You are right. I just checked the source code. Should I create a quick PR to fix the docs?
https://github.com/near/near-api-js/blob/e92725352a5ad33db7ba97f4d181da44af88267f/src/contract.ts#L31-L45

Definitely!


Update Gogs

Add :

ldap support (for all user + admin)
multiarch support (build on the script)
public fonction (creating a new user is blocked per default)

Upgrade script
For ldap support you must reinstall gogs or configure manually ldap in mysql database (the upgrade script don't add ldap support).

Nice, this is exactly what I've been trying to add, but I couldnt find the time. Great work!!

Did you also add all the appropriate ldap fields for automatic Surname, First Name and E-mail data for the users?
The input field allows it (http://gogs.io/docs/features/authentication.html), but I had difficulty to find the accompanying SQL data to put the LDAP fields in...

For E-mail and username it's ok, but for "Full name" you have to change this parameter in gogs.

I found the attributes for the Surname and Firstname:
Surname is sn and First name is givenName.
This is the data in JXplorer:

I correct this thing.

Hi, again thanks you very much for this, great work! I did some test and unfortunatly after install I can't login neither with admin account or LDAP account.
I've look in the database and it seems that the admin user was not created. I don't really know what went wrong, maybe curl, I need to run some other test to find the bug.
I've try both x64 and other architecture install, both installation seems to work fine (but I still can't login). Since you did the work for building gogs from source, what do you think about droping the package.io support? I think it's more convenient to have only one way to install/update/remove gogs and the package doesn't add any value here.
Another thing, with current behavior the script build the development version of Gogs, I think it's a little risky and it should build a specific release.

Why would package.io support be dropped? The gogs package is actively
maintained by the gogs main dev, right? I think being able to update gogs
with a simple sudo apt-get upgrade is very useful.
I didn't have the chance to test the update yet, but hopefully the source
of the issue can be found and fixed quickly!
On Sep 13, 2015 12:54 PM, "tostaki"<EMAIL_ADDRESS>wrote:

Hi, again thanks you very much for this, great work! I did some test and
unfortunatly after install I can't login neither with admin account or LDAP
account.
I've look in the database and it seems that the admin user was not
created. I don't really know what went wrong, maybe curl, I need to run
some other test to find the bug.
I've try both x64 and other architecture install, both installation seems
to work fine (but I still can't login). Since you did the work for building
gogs from source, what do you think about droping the package.io support?
I think it's more convenient to have only one way to install/update/remove
gogs and the package doesn't add any value here.
Another thing, with current behavior the script build the development
version of Gogs, I think it's a little risky and it should build a specific
release.
—
Reply to this email directly or view it on GitHub
https://github.com/mbugeia/gogs_ynh/pull/10#issuecomment-139859877.

Well I can think of several reason to do so.
A yunohost package is usually consists of install of the app + nginx config + app config. That's mean the package is configurated to work with a specific version of the app. Gogs's packager.io package only take care of the installation. Therefore upgrading Gogs with the package can lead to inconsistency between the installed Gogs's version and nginx and/or yunohost config.
An outdated version that works is better than an up to date one that don't ;)
Moreover the package is only available for x64 architecture so keeping the support mean keeping two way of installing, upgrading, removing the app. So it helps keeping the yunohost package simple and easier to maintain.
Finally the yunohost way of upgrading apps is "yunohost app upgrade appname" and I think it's better to keep it this way. With that, the app is only upgraded if the package have been upgraded and tested with the new version.
tl;dr: consistency and maintainability

Hmm, those are valid arguments I did not yet consider.
I must say they made me be in favor of installing from source as well. Isn't it possible to specify a git tag in the install and upgrade scripts from which to install? That way, always the currect version of the app is installed.
One drawback of this method is that every gogs update requires a gogs_ynh update. Perhaps it's possible to somehow allow upgrades within the same vX.* branch.

An other solution is to use only the source for all arch (we don't use the binary for x86-64). And we put the gogs's sources in sources directory (in package) and we build gogs from the sources directory.
With this solution we don't have to support 2 solution (binary or sources).
For the ldap bug, I have installed gogs on a vm and my production and ldap run.
But I have found this issue, https://github.com/gogits/gogs/commit/6969c20afd136ac911c66fd7c7ed88d611ba79fc
Today, I have tried an installation and the allow_auto_register collum don't exist in mysql database but on last friday it existed.
It's a good example how we have a problem with file how don't came for the package.

Hello,
I have updated with app. Actually I use only the sources and it build gogs for all arch. The gogs's sources are stored in this package.

Did you try a fresh install on your machine? Did it work? Can we get this merged? :D

I have tried on a vm. But on my production it also run. I think it could be merged.

What is keeping you from merging, @mbugeia ?
(I don't want to push you to just merge without verifying, but perhaps there is something not clear that we can help figure out.)

Thanks for remind me this. So I tried to install it but it does not work on my yunohost (debian jessie, x64).
It seems that this line https://github.com/Josue-T/gogs_ynh/blob/master/scripts/install#L111 fail silently so everything after that fail too. I can't find any log... MySQL table are not created so the curl command fail.
Additional question, for Jessie it should not rather be 'sudo systemctl start gogs.service' ?

Can I see the log of your install because I had tried on vm with debian jessie and debian wheezy.
I think it could be a problem with buid but I not sure.
You can try to lunch gogs manually with this command :
export USER=gogs
export HOME=/home/gogs
cd
sudo -u gogs /opt/gogs/gogs web

For log on debian jessie you can see log in /var/log/syslog
I think sudo service gogs start is same as  sudo systemctl start gogs.service

Hum, sorry the issue was on my side, I don't know exactly what went wrong but after some cleanup and a reboot everything seems to work know :)
I will merge this, thanks you again for your work!


How do I get a sticky table header with the same column widths as the base table

Hi,
I have a problem with the widths of the columns. How do I get a sticky table header with the same column widths as the base table. In this JSFiddle example it seams to work: https://jsfiddle.net/jmosbech/stFcx/
In my example the calculating of the widths of the sticky table header is different from the widths of the base table. Visually it looks like the caluclation of the column widths considers the body only and the content of the sticky table header is ignored.
Best regards,
Daniel

I too am running into the cloned headers not having the correct width. I am building my table with knockoutjs. I wonder if there is a timing issue with that.
Is anybody else using knockoutjs and getting this to work?

BTW, I fixed my problem by creating a knockout template and then when I render it in a div, I used the afterRender event that gets fired after the template has been rendered. But even this wasn't good enough because the columns weren't shown on the page yet and therefore didn't have their width's set. So in my function, I inserted a setTimeout call with 0 milliseconds. This executes the function on the very next idle cycle, which is after the widths have been set.
So my knockout data-binding became:

There was nothing special about my template. My javascript function setupStickyHeaderRows became:
            setTimeout(function() {
                var offset = $('.navbar').height();
                $("#schedule").stickyTableHeaders({fixedOffset: offset});
            }, 0);

Now this is going to have to change when I take into consideration window resize events because the offset is going to change occasionally. I figure I will be looking at examples to see how they do it, or just tear down the sticky headers and create them again in this function and have the resize event call this function too.

it turns out that this is not good enough. There is still a race condition between the nodes being query-able through jQuery and the afterRender from knockout. To get around this I now have this as my afterRender callback. It seems to work great.
            setTimeout(function() {
                var table = $("#schedule");
                if (table.find('thead:first th,td').length == 0) {
                    setTimeout(setupStickyHeaderRows, 10);
                } else {
                    table.stickyTableHeaders('destroy');
                    var offset = $('.navbar');
                    table.stickyTableHeaders({"fixedOffset": offset});
                }
            }, 0);

basically I search for the th,td elements. If they are not there, then I delay 10ms and call this function again.
Hope that helps anybody trying to get this to work with a knockout table where the headers are being driven by knockout data binding.


Oct 4th 2023, Community Meeting Agenda

📞 Dapr Community Meeting
Every two weeks we host a community meeting to highlight community created content, showcase new features, review upcoming milestones, and engage in Q&A with the Dapr community - all are welcome, and we encourage participation.
The purpose of this thread is to form a discussion amongst the Dapr community on potential topics to highlight during the meeting. If you have a topic you wish to present or learn more about, please comment and be sure to include your name and a short description of the topic.

The conversations in this thread will directly influence the meeting agenda for the community call on , at 9 AM PST (See it in your local time). The meeting agenda is finalized by a Community Call Host prior to the meeting.
See you at the community call! 👋
Agenda

Introduction
Dapr Release 1.12 - Yaron Schneider
Dapr VS extension - Philip Hoff
Community Show & tell - Marc Duiker
Open discussion
Closing

Checklists for the host
Before the meeting

[ ] Find speakers
[ ] Collect Dapr news (blog posts & videos found on social media, and show-and-tell Discord channel)
[ ] Prepare slide deck
[ ] Send meeting invite to the speakers
[ ] Announce the meeting on social media

[ ] 1 week before
[ ] 1 day before
[ ] 1 hour before

During the meeting

Welcome & announce that the meeting will be recorded
Start the recording
Show the agenda
Welcome first speaker
First session
Q&A first session
Welcome second speaker
Second session
Q&A second session
Show Dapr related news, posts, videos.
Open discussion
Closing & mention Dapr Discord channel

After the meeting

[ ] Upload the meeting to YouTube
[ ] Add chapters to the video
[ ] Add links to the video description

[ ] Read-only link to slides
[ ] Dapr Discord link
[ ] Other relevant links related to the sessions

[ ] Announce the published video on social media
[ ] Close this issue

https://youtu.be/L_S98bRGfCQ


Update quickstarts for SDK 0.10.2 #34

Updated keygen methods to use updated API
Added 'ttl' command line flag to specify a ttl for the key using the new customizeable ttl feature

@pcbennion-qrypt @wmcrobertsq @alison-qrypt
This passes the portal E2E tests. Can I go ahead and merge it in? The owner is out. My regression tests of the new SDK in the portal also pass.

Spencer


map added

Description
I have added an iframe in the index.html file to include the map of the address.
Fixes #139

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in the downstream module

ATTACH SCREEN-SHOTS

@nidhivanjare good work.


[BUG] Terminal cannot accept save/load commands with double-quoted filenames.

Describe the bug / feature
After P8, a user may try loading/saving a file in the terminal with the name in double-quotes. This cause an error.
To Reproduce
Steps to reproduce the behavior:

In the Terminal, first enter  save foo.p64; this should work as expected.
Now try load "foo.p64" or save "foo.p64".
Both will cause an error due to the double-quotes.

Expected behavior
Double-quoted filenames should be acceptable, as per P8.
Screenshots

Software (please complete the following information):

OS: macOS
Version: v0.1.0b

Confirmed: fixed with release v0.1.0c on macOS. Now gives useful error message feedback to the User (double quotes cannot be present). 🎉


Avalonia Control Rendering Issue(s)

AvaloniaCefBrowser is currently not rendering in way that allows for it to be treated like other controls. It is always showing above other Controls (not respecting ZIndex) and will render in full outside the bounds that the control occupies.
An example of this issue is having a Grid with a header row and a ScrollViewer in a separate row. When this ScrollViewer is moved to a position where the AvaloniaCefBrowser should be out of view or cut due to the bounds on the grid row, it instead shows over the header row. This is not the case for other controls.
A straightforward way to demonstrate this issue is to overlay a panel/border on top of the AvaloniaCefBrowser. It will always be hidden by the AvaloniaCefBrowser. The only way I have found to render a control on top of an AvaloniaCefBrower is to use a flyout/popout.
Another way to demonstrate this issue is to wrap the AvaloniaCefBrowser with a Border with ClipToBounds set to true and reduce the size of the border to less than the control, or to introduce a corner radius that would cut parts of the corners. These changes will not impact the AvaloniaCefBrowser as they would any other control.
This issue currently limits use of the AvaloniaCefBrowser to being static position within a window.
Another issue, which may be related is that when scrolling a view with an AvaloniaCefBrowser, it doesn't move in sync with other controls. Interestingly it moves ahead of other controls.
I'm going to take a look through the repo to better understand this, but wanted to flag it first incase others can provide comments/guidance.

OSX (ARM64)
Avalonia 11.0.0 & 11.0.2
CefGlue.Avalonia 106.5249.19-avalonia11

Hi,
What you're describing is not an issue but rather a known limitation of CEF/Avalonia/WPF playing together, commonly called "airspace problem".
To overcome that you have the option of using the off-screen rendering mode (https://github.com/OutSystems/CefGlue/blob/main/CefGlue.Demo.Avalonia/Program.cs#L20), but be aware that might introduce other issues and usually is worse performance wise.

@joaompneves thank you for coming back on this so quickly, and providing such a clear response. I will mark this as closed.


Keep in sync with GitHub using moban

Pull Request
New or update
New

[ ] Template - New .gitignore template
[ ] Composition - Template made from smaller templates
[ ] Inheritance - Template similar to an existing template
[ ] Patch - Template extending functionality of existing template

Update

[x] Template - Update existing .gitignore templates

Details
This causes Travis to fail if there have been any upstream changes in github/gitignore .  This isnt the ideal solution, as an auto sync would be better, but the moban tool is being developed for situations like this, and has lots of lovely functionality that will likely be useful for this repo, including the ability to have custom template engines.  e.g. it's builtin jinja2 templating could be used to build merged .gitignore files, a custom engine could be used to add a header on the top of every GitHub sourced file, which would help people understand how to contribute to this repo better.

I see https://github.com/dvcs/scripts was intended to do an automated sync.
But no cron job at https://travis-ci.org/dvcs/scripts/builds .
Easy enough to move the moban sync to there if Travis is enabled again.
However it can be automated with moban and
https://github.com/ScalaWilliam/git-watch .
Anyways, lots of options, but needs to get solved.
After this, the next problem is .patch files which have become stale due to upstream changes.
Here is were a template or unified diff file would be better suited. c.f.
https://github.com/moremoban/moban/issues/75

Thanks for submitting this.  I actually wrote a blog post about why I've forked this repo from GitHub[1].  The GitHub repo has some good templates updates becuase it's the main repo every uses, but it also has some unmaintained templates.  I would rather pull changes individually than just blanket adopt GitHub.
GitHub also does not support any composition or inheritance which I'm trying to move this repository towards to remove duplication.
[1] - http://blog.joeblau.com/gitignore-io-template-fork

These changes look good.  I'll merge this PR. The only thing I want to make sure of is that this list is the best list of gitignore templates for https://gitignore.io.   If we can keep in sync with upstream without compromising aliased templates and stacked templates, I'm all for it.

Hey, I reverted this PR because after thinking about it for a day.  I think it would be better if we just stuck to using standard tools to keep the templates up to date instead of moban.  I'm thinking that we can just add a shell script which copies the changes from GitHub into this local repo and then leverage the .patch for the diff of each file.
This came from re-thinking about a lot of the original goals of the project and thinking more about the RFC that shiftkey proposed.

Hey I reverted this change because it was causing something in travisCI to break.  I didn't get a chance to look into what was breaking, but I'll take a look this weekend.


Digital Phantom Standards

Define a set of digital phantoms for HP community
What are requirements?
Metabolic - variations in kPL
Perfusion - variations in kTRANS
Spatial - lesions, background signals?
One option in simulations/ folder
Add BrainWeb phantom?

work in branches brainweb_phantom and heart_phantom


cleanup most console errors; lint fixes

Improvements in this change

eliminate most errors in the console where the key is missing in the loop
make use of single fuzzyMatch function (moved to utils)
fix linting errors

Looks good to me 👍


GraphQL Refactor Step 4 - Refactor Transform Invocation into New Top-Level Package

Description of changes
Create a top-level transform package for the v2 transformer chain to simplify invocation from the API Category, and simplify invocation of the transform/preprocessing system from multiple clients.
Step 1. break apart the v1/v2 logic a bit, and moving the chain generation into a separate file (which will eventually be pulled into it's own package). Merged in https://github.com/aws-amplify/amplify-category-api/pull/1528
Step 2. Consolidate all input param generation into a single place for the v2 transformer, and migrate GraphQLTransform construction into a single place, with a tight interface (today is overly permissive, and leaks in significant amplify cli and deploy concerns). Under review in https://github.com/aws-amplify/amplify-category-api/pull/1548
Step 3. Execute transform within new single location as a separate method, and accept remaining props (e.g. transform execution props, and printer callback) into the utility. Under review in https://github.com/aws-amplify/amplify-category-api/pull/1549
(Current Step) Step 4. Final cleanup of remaining code, and split into a new package. Under review in https://github.com/aws-amplify/amplify-category-api/pull/1550
graph TD;
    api("@aws-amplify/amplify-category-api")
    new("Additional Transformer Clients")
    transform("@aws-amplify/graphql-transformer")
    core("@aws-amplify/graphql-transformer-core")
    model("@aws-amplify/graphql-model-transformer")
    auth("@aws-amplify/graphql-auth-transformer")
    rem("...Remaining @aws-amplify/graphql-*-transformer")
    api-->transform;
    new-->transform;
    transform-->model;
    transform-->auth;
    transform-->rem;
    model-->core;
    auth-->core;
    rem-->core;

CDK / CloudFormation Parameters Changed
N/A , this should strictly be refactor of existing interfaces.
Issue #, if available
N/A
Description of how you validated changes
Unit + E2E Tests
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1550 (4cd8792) into main (7150e75) will decrease coverage by 0.09%.
The diff coverage is 50.45%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #1550      +/-   ##
==========================================
- Coverage   63.14%   63.05%   -0.09%
==========================================
  Files         362      361       -1
  Lines       21406    21420      +14
  Branches     5089     5095       +6
==========================================
- Hits        13516    13506      -10
- Misses       7162     7186      +24
  Partials      728      728

Impacted Files
Coverage Δ

...y-category-api/src/graphql-transformer/override.ts
98.27% <ø> (ø)

...-api/src/graphql-transformer/user-defined-slots.ts
100.00% <ø> (+2.94%)
:arrow_up:

.../src/graphql-transformer/transformer-options-v2.ts
15.75% <23.80%> (+0.32%)
:arrow_up:

...graphql-transformer/transform-graphql-schema-v2.ts
72.50% <50.00%> (-1.94%)
:arrow_down:

...ify-graphql-transformer/src/graphql-transformer.ts
52.94% <52.94%> (ø)

...i/src/graphql-transformer/directive-definitions.ts
53.33% <71.42%> (+11.66%)
:arrow_up:

...api/src/graphql-transformer/transformer-factory.ts
30.00% <100.00%> (-5.00%)
:arrow_down:

...l-transformer-core/src/transformation/transform.ts
16.19% <100.00%> (+0.52%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Feat/create controller to get comment votes

Before submitting your PR for review

Run npm run lint to find errors in code syntax/format
Run npm run lint:fix to fix all auto-fixable errors in source code and auto-format with prettier
Ensure you fix any linting errors displayed after running any of the above commands

What does this PR do?
get commentVotes either upVote or downVote
Fixes #issue_number (replace issue_number with the issue number this PR solves)
#147
Summarise the main tasks handled in the pull request
GET /comments/:id/votes
description of Task to be completed?
To get the number of votes either upVote or downVote
Describe (in detail) what the task completed in the pull request does as per the relevant task
How should this be manually tested?
Give bullet point instructions on how to setup the code and test it manually (Assume no prior experience on JS or code)
. using the postman
. Enter the necessary values
Any background context you want to provide?
Any pertinent information that should be considered
What is the link to the issue on Github?
Issue #147
Questions:
If something is unclear or you want some questions to be addressed by your peers, mention them here

You have 2 other PRs for the same work. I am closing this one.


fix: local debugging is not working (goes to remote)

Description
Fixes #191
How Has This Been Tested?
npm test
manual test
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

Lgtm, just not 100% sure to understand why absolut paths dont work


Viewing/editing files on a device

Sorry if this is the wrong place for this, but I'm getting confused about what the intention of Jupyter is.
I can connect to my ESP32, and run any code successfully in the cell and see a response on the device, but I can't see or edit any of the files that are on the device. Is Jupyter intended only as a playground for testing out bits of code? Can't actually make any permanent changes on the device?

There's a set of magic commands, which you can see using %lsmagic
The one you probably want is this one:
%sendtofile [--append] [--mkdir] [--binary] [--execute]
                   [--source [SOURCE]] [--quiet] [--QUIET]
                   [destinationfilename]
    send cell contents or file/direcectory to the device

My workflow is usually to hack up the different functions I need, gradually developing them (you can use esc-I-I to control-C and interrupt loops.  Then when I have something working I put "%sendtofile main.py" at the start of a cell and it's good to go.
Here's an example:
https://github.com/goatchurchprime/jupyter_micropython_developer_notebooks/blob/master/projects/esp8266buttontoUDP.ipynb

Thanks @goatchurchprime ! Are you the Julian at DoES Liverpool?

yes.  I suppose I should update my profile then.


Fix broken link on Enforcing Pod Security Standards page

Fixes #36929
Updated page Enforcing Pod Security Standards

Thanks for the fix!
/lgtm

The page updated by this PR states Pod Security Admission has the Feature State for Pod Security Admission as beta as of 1.23. Can you also update the feature state to be FEATURE STATE: Kubernetes v1.25 [stable]

Page preview:
https://deploy-preview-36930--kubernetes-io-main-staging.netlify.app/docs/setup/best-practices/enforcing-pod-security-standards/#configure-all-cluster-namespaces
/king cleanup

/approve


[STYLE CHANGE] Toggle visibility eye button picture

Description:
The icon that controls the visibility of an object, represented by an eye symbol, remains unchanged despite its functionality being intact. Even though the icon successfully performs the action of hiding or showing of password, the image itself does not undergo any noticeable alteration or transformation.

Reason for Change:
Better and intuitive user experience
Current Styling:
Currently, the eye icon remains the same for both hide and show passwords.
Proposed Styling:
password masked == open eye icon
password shown == closed eye icon

Priority Level (optional):

[x] Low
[ ] Medium
[ ] High

@Vanoita that's nice....
Work on it

As we are using fontawesome icons there, keep the same type of icon there for eye-closed.


Application not build after add plugin

Dear Sir,
In my ionic project when i add plugin then i face buil issue.

Hi @Amit050 , I see a reference to androidX, please note:
Android X support
For Android X Support please use version >= 2.x.x
For Android Support Library please use version 1.3.x

Could this be related to the version of the library being used?

Dear Sir,
for android support when i install plugin automatic save version 1.2.0 how we install version 1.3.x or give me link of version 1.3.x

This plugin is available from https://www.npmjs.com/package/com-darryncampbell-cordova-plugin-intent and all versions are there, to install a specific version:
cordova plugin add com-darryncampbell-cordova-plugin-intent@version


fix(DTFS2-NONE): fix pipeline

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6da84ce) 21.88% compared to head (ce0c9df) 1.33%.
Report is 5 commits behind head on main.

Files
Patch %
Lines

dtfs-central-api/src/drivers/db-client.js
0.00%
1 Missing :warning:

external-api/src/database/mongo-client.ts
0.00%
0 Missing and 1 partial :warning:

trade-finance-manager-api/src/drivers/db-client.js
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2336       +/-   ##
==========================================
- Coverage   21.88%   1.33%   -20.56%
==========================================
  Files        1132     481      -651
  Lines       27048   11490    -15558
  Branches     4447    1329     -3118
==========================================
- Hits         5920     153     -5767
+ Misses      18403   10283     -8120
+ Partials     2725    1054     -1671

Flag
Coverage Δ

api-test
?

ui-test
?

unit-test
1.33% <0.00%> (-2.46%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Updating labels for pipeline data connection

As per https://issues.redhat.com/browse/RHODS-12944, the AWS_ prefix no longer exists in the configure a pipeline dialog. To address this, I've updated the labels of the data connections.

How Has This Been Tested?
Validated with a local build of the Open Data Hub website.
Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work


With a larger picture like 1024*1024, the train results poor loss like 10E6

I replace the data used in the project with 1024*1024 jpg, also 14 2d joints involved.
While the loss result turns out to be extraordinarily large:
Tit   = total number of iterations
Tnf   = total number of function evaluations
Tnint = total number of segments explored during Cauchy searches
Skip  = number of BFGS updates skipped
Nact  = number of active bounds at final generalized Cauchy point
Projg = norm of the final projected gradient
F     = final function value

           * * *

   N    Tit     Tnf  Tnint  Skip  Nact     Projg        F
    6     23     26      1     0     0   1.000D+06   7.801D+06
  F =   7800716.0000000000

Does the picture size matter with the training? Or anything I missed then.

Do you mean that you tried the code on your own dataset? If so you need to update the settings like camera parameters and image size accordingly.

Thanks a lot! I figured out that it was our camera's extrinsic parameter, transpose matrix, that has already been divided by 1000.0. The loss function falls down to 10E4 for pose(\thetas) and shape(\betas) parameters in smpl then.
The training result projected to 2d image was not good enough under condition that we have 8 camera views...
Another question: I didn't find where to set the picture size in your code, does it matter for the training? Or if I should change the Data/genericPrior.mat?

You need to dig deep about how camera parameters are represented. I think this link might help you a lot: https://docs.opencv.org/2.4/doc/tutorials/calib3d/camera_calibration/camera_calibration.html.

Thanks very much! Really a great help!


[Python] Some propositions about Format & Tests

Here are three commits. Each one could have been one PR, but this is mainly for discussions.
The first one is about reformatting most python file to comply a little more with some main indications stated in pep8
The second makes python tests work again
The third tells to Travis to run those tests.
I will probably change a bit how those tests are implemented, and then work on coverage, if you find this useful.

:+1:


Reconsider asterisk-versioning of @csstools/normalize.css and sanitize.css

broken out of https://github.com/csstools/postcss-normalize/issues/58#issuecomment-920084981 and https://github.com/csstools/postcss-normalize/issues/58#issuecomment-920154375

Context
<EMAIL_ADDRESS>introduced support for normalize and sanitze.css via https://github.com/csstools/postcss-normalize/pull/43.
This generous version range broke v10 and v9 ecosystems when sanitize.css removed a file that postcss-normalize imported.
https://github.com/csstools/postcss-normalize/pull/60 resolved the issue for v10, but this is not addressing the root cause, only fixing the problem until it breaks again. The changelog even alludes to the uncomfortable position we are in.
Question
Are you in theory amenable to work to remove asterisk-based versioning for direct dependencies, whether done yourself or contributed from the community? Previous comments linked above in #58 seem to indicate yes.

https://github.com/csstools/postcss-normalize/pull/59 takes steps in this direction
me and my team would be happy to contribute this back for the 10 and 9 lines.

I think pinning the version is reasonable. We would need to coordinate releases of sanitize.css, normalize.css, and postcss-normalize. But since I run all of them, the coordination is more logistical than organizational.

I'm not clear on why you would need more coordination with a pinned version. The entire purpose of pinning to a specific version (or range of versions) is to prevent issues in one package from impacting another.
Currently, the package seems to be broken due to the latest version of sanitize.css missing a file that is depended upon by postcss-normalize. Had the version been pinned in postcss-normalize, this would have been avoided.

I'm tried breaking this down. Looking for critical feedback on the below:
What Happened, When
<EMAIL_ADDRESS>was released with proper semver September 14th, 2021.
At the time of it's release, the following versions of postcss-normalize broke:

❌<EMAIL_ADDRESS>❌<EMAIL_ADDRESS>✅<EMAIL_ADDRESS>- not on github, but viewable at<EMAIL_ADDRESS>
this version pre-dated the *-based versioning.

you can verify these commands with npm view postcss-normalize@<VERSION> dependencies

Steps Taken To Resolve So Far

<EMAIL_ADDRESS>released, removing reliance on import to now-missing pages.css

* versioning still present, but no longer breaks
postcss@8 ecosystem only

<EMAIL_ADDRESS>patch promised

Risks That Still Remain
While all of the above was happening, normalize.css also released breaking changes September 15, 2021.
From the changelog:
- Changed: normalize.css no longer contributes specificity.
- Changed: normalize.css fixes now respect `writing-mode`.
- Removed: Fixes for older browsers, and all fixes for IE.
- Fixed: `table` uses correct `border-color: currentColor` normalization.

This is fine in and of itself, but not when it is also * asterisked within postcss-normalize.
We don't know the impact of this auto-upgrade through breaking changes, it didn't break as loudly as sanitize.css. Teams may have noticed the browser changes and taken steps to mitigate them.
Current State

v9/postcss7 ecosystem broken

regenerating lockfiles, over time, surface this issue to more and more users

v10/postcss8 and v9/postcss7 ecosystems still vulnerable
both versions affected by normalize.css breaking changes

Analysis
We generally cannot make many assumptions about what users in the wild have downloaded when resolving postcss-normalize ➡ santize.css@* or postcss-normalize ➡ normalize.css@*.
Users experiencing issues on v9 likely are using the resolutions workaround, so we don't have to sweat too much. v10 users are unblocked but still vulnerable. All users are impacts by breaking changes to normalize.css.
Pinning to an earlier version is problematic because you cannot undo a semver violation with another one. Why? Teams might have mitigated the changes from an auto-upgrade, only for a good-natured patch fix changing it back. Two wrongs don't make a right with semver.
Proposed Plan
Given the timeframes involved and the likely need to support both postcss7 and postcss8 ecosystem, I'd suggest the following:
v9/postcss7

Revert the v9 ecosystem to a state pre-September 14th. Not a lot of time has passed, and perhaps those still on v9/postcss7 have not yet re-generated lockfiles.

Pin sanitize.css to ^12.0.1 via https://github.com/csstools/postcss-normalize/pull/59
Pin @csstools/normalize.css to  ^11.0.1
Release as v9.0.1
Deprecate 9.0.0 via npm deprecate

npm deprecate<EMAIL_ADDRESS>"9.0.0 bundled unstable dependencies. Upgrade to 9.0.1 if using postcss7, or evaluate later releases."

v10/postcss8

Deprecate all of v10 as unstable. We simply cannot know how this is playing out, or will continue to play out with *-based versioning. The good news is postcss8 is likely less-adopted for now.

npm deprecate<EMAIL_ADDRESS>"10.x bundled unstable dependencies. Upgrade to<EMAIL_ADDRESS>
This step could be done after v11... and mention upgrading.

v11/postcss8

SEMVER Major out of the *-based dependencies.

Pin sanitize.css to ^13.0.0
Pin @csstools/normalize.css to  ^12.0.0

Create a proper release at https://github.com/csstools/normalize.css/releases/tag/12.0.0

What About peerDependencies?
Someone in a long-ago issue asked if peerDependencies would better solve this problem. At this time I don't think so, especially on the advent on npm7 changing the algorithm. I guess it comes down to whether or not you'd expect people to independently be installing versions of your dependencies. Considering the ecosystem here, I'd suspect no, but am only one opinion.

Seems fair.
I've released version 13 with pinned versions.


multiple flakes in one image while training

Hey,
thanks for creating 2DMatGMM.
I have a couple of questions regarding training the model. I have an image with multiple flakes of different thicknesses. Using the annotation tool I can select the background and select multiple flakes. Can I do that or does the training expect only one flake/thickness per image?
Also there are some flakes that have areas with multiple thickness. Should I avoid those during the training? How does the algorithm handle those cases?
Thank you very much :)

Hey Rodal,
You can have as many different thicknesses as you want, you should just define what is interesting in the image.
This means that it does not matter if your selected flakes have several different thicknesses.
But you should also only select what is interesting, so if your flake has multiple thicknesses, only select the interesting ones.
I would recommend marking only very thin flakes at first to get used to the fitting process.
Once you get used to the process you can mark thicker flakes.
If you like you can also send a picture of your multi thickness flakes, Ill have a look at them.
Also the interesting flakes should not be too small.
Best
Jan

Hey Jan,
thanks for the quick reply!
I am still in the process of finding enough good thin flakes to train the algorithm with but I think I get it know, it seems promising so far :)
Best regards


feat: auto-adding of schema data based on tokens studio data

Description
Adds schema information to token definitions matching types in the tokens studio data.
Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Run report for 5dff6b64
Total time: 53.1s | Comparison time: 54.8s | Estimated savings: 1.8s (3.2% faster)

Action
Time
Status
Info

🟩
SyncWorkspace
1.3s
Passed

⬛
SetupNodeTool(18.13.0)
2s
Skipped

🟩
InstallNodeDeps(18.13.0)
7.6s
Passed

🟩
SyncNodeProject(visualizer)
0.2ms
Passed

🟩
SyncNodeProject(tokens)
0.3ms
Passed

🟩
SyncNodeProject(site)
0.2ms
Passed

🟩
RunTask(site:copySchema)
74.3ms
Passed

🟩
RunTask(visualizer:typescript)
2.3s
Passed

🟩
RunTask(tokens:buildTokens)
13.9s
Passed

🟩
RunTask(tokens:buildManifest)
317.1ms
Passed

🟩
RunTask(visualizer:build)
4.2s
Passed

🟩
RunTask(tokens:build)
2.1s
Passed

🟩
RunTask(tokens:generateDiffResult)
4.1s
Passed

🟩
RunTask(tokens:test)
2.1s
Passed

🟩
RunTask(site:build)
23.2s
Passed

🟩
RunTask(site:clean)
122.7ms
Passed

🟩
RunTask(site:export)
814.4ms
Passed

Touched files
.changeset/dirty-pets-attend.md
.changeset/good-peas-mix.md
.changeset/happy-students-vanish.md
.changeset/lemon-dragons-raise.md
.changeset/neat-balloons-rhyme.md
.changeset/pre.json
.changeset/slimy-emus-enjoy.md
.changeset/strange-rings-love.md
.changeset/tame-bobcats-beg.md
.changeset/warm-experts-beg.md
.changeset/wise-turtles-confess.md
.github/workflows/deploy-docs.yml
.github/workflows/release.yml
.moon/toolchain.yml
.moon/workspace.yml
package-lock.json
package.json
packages/tokens/CHANGELOG.md
packages/tokens/package.json
packages/tokens/src/color-aliases.json
packages/tokens/src/color-component.json
packages/tokens/src/color-palette.json
packages/tokens/src/icons.json
packages/tokens/src/layout-component.json
packages/tokens/src/layout.json
packages/tokens/src/semantic-color-palette.json
packages/tokens/src/typography.json
packages/tokens/tasks/diff.js
pnpm-lock.yaml
pnpm-workspace.yaml
tools/transform-tokens-json/README.md
tools/transform-tokens-json/moon.yml
tools/transform-tokens-json/package.json
tools/transform-tokens-json/src/lib/shared.js
tools/transform-tokens-json/src/merge-dark-darkest.js
tools/transform-tokens-json/src/merge-spectrum-express.js
tools/transform-tokens-json/test/index.test.js

I think I got all the basic $schema issues addressed, but all the new colors are missing wireframe options. I'll follow up with design a solution for this so our tests work, but we also don't lose the data for the existing wireframe values.


Random fail when cloning with additional disk

The goal is to create a cloud-init VM with two disks from a VM by cloning a VM with one disk.
The main.tf file is:
terraform {
  required_providers {
    proxmox = {
      source  = "telmate/proxmox"
      version = "2.9.14"
    }
  }
}

provider "proxmox" {
  pm_tls_insecure = true
  pm_log_enable   = true
  pm_log_file     = "terraform-plugin-proxmox.log"
  pm_debug        = true
  pm_log_levels   = {
    _default    = "debug"
    _capturelog = ""
  }
}

resource "proxmox_vm_qemu" "terraform-telmate-proxmox" {
  name        = "terraform-telmate-proxmox"
  target_node = "hpv-1"
  clone       = "debian-12-template"
  agent       = 1
  os_type     = "cloud-init"
  cores       = 1
  sockets     = 1
  cpu         = "host"
  memory      = 2048
  boot        = "order=virtio0"
  onboot  = true

  disk {
    type = "virtio"
    storage = "local-lvm"
    size = "15G"
  }

  disk {
    type = "virtio"
    storage = "data_disk"
    size = "20G"
  }

  network {
    model  = "virtio"
    bridge = "vmbr0"
  }

  lifecycle {
    ignore_changes = [
      network,
    ]
  }

  ipconfig0 = "ip=<IP_ADDRESS>/24,gw=<IP_ADDRESS>"
}

The template has three disks:

ide0: local-lvm:vm-111-cloudinit,media=cdrom,size=4M
ide2: none,media=cdrom
virtio0: local-lvm:vm-111-disk-0,discard=ignore,size=14G

Sometime the provider sends the following query in the config POST request (/api2/json/nodes/hpv-1/qemu//config):
agent	1
bios	seabios
boot	order=virtio0
cores	1
cpu	host
hotplug	network,disk,usb
ipconfig0	ip=<IP_ADDRESS>/24,gw=<IP_ADDRESS>
kvm	1
memory	2048
name	terraform-telmate-proxmox
net0	virtio=AE:15:92:3A:63:98,bridge=vmbr0
numa	0
onboot	1
scsihw	lsi
sockets	1
tablet	1
virtio0	local-lvm:vm-100-disk-0,size=15G
virtio1	data_disk:20

In this case the VM is created as expected.
Sometime the provider sends:
agent	1
bios	seabios
boot	order=virtio0
cores	1
cpu	host
hotplug	network,disk,usb
ipconfig0	ip=<IP_ADDRESS>/24,gw=<IP_ADDRESS>
kvm	1
memory	2048
name	terraform-telmate-proxmox
net0	virtio=FE:2B:06:46:CD:D7,bridge=vmbr0
numa	0
onboot	1
scsihw	lsi
sockets	1
tablet	1
virtio0	local-lvm:vm-100-cloudinit,size=15G
virtio1	data_disk:20

In this case provider fails with the following message:
virtio0 - cloud-init drive is already attached at 'ide0'

To conclude, the provider sends randomly one of those two configurations:

virtio0	local-lvm:vm-100-disk-0,size=15G
virtio0	local-lvm:vm-100-cloudinit,size=15G

This appears to be related to #704 and it may be the same issue. If so, I think it has been fixed in the default branch but not yet included in an official release. If you are willing and able to compile your own version of the provider, it seems like git commit 4c0c8fc37ed3f6316ad9392a46a0cf28c4654a11 should work (later versions either don't compile, or have other show-stopping issues; see my comments on #704 for details).

Hello there. I saw the bot comment on this ticket being stale and for once, it was actually a useful comment. This ticket had fallen off my radar.
I made a terraform file to try to accomplish what you're trying to do here with the 3.0.1-rc1 build, making my terraform mirror yours as closely as possible. The format of disks has changed with the new version, so it's not exactly the same, but it's pretty close and it worked as expected in 3.0.1-rc1.
The main terraform file  (issue876.tf):
resource "proxmox_vm_qemu" "server" {
  name              = var.name
  target_node       = var.target_node
  clone             = "debian-12"
  agent             = 0
  os_type           = "cloud-init"
  scsihw            = "virtio-scsi-pci"
  # New & improved disk format (3.0 and later)
  disks {
    virtio {
      virtio0 {
        disk {
          size            = 20
          cache           = "writeback"
          storage         = var.storage_backend
        }
      }
      virtio1 {
        disk {
          size            = 40
          cache           = "writeback"
          storage         = var.storage_backend
        }
      }
    }
  }
  network {
    model           = "virtio"
    bridge          = "vmbr0"
  }
  # Cloud Init Settings
  # Reference: https://pve.proxmox.com/wiki/Cloud-Init_Support
  cloudinit_cdrom_storage = var.storage_backend
  boot = "order=virtio0;ide3"
  ipconfig0 = "ip=${var.ip_address}/${var.cidr},gw=${var.gateway}"
  nameserver = var.nameservers
  sshkeys = file("${path.root}/test.pub")
}

provider.tf:
# Define the usual provider things
terraform {
  required_providers {
    proxmox = {
      source = "Telmate/proxmox"
      version = "=3.0.1-rc1"
    }
  }
  required_version = ">= 0.14"
}

And my vars.tf file is specific to my environment, but you can see an example here: https://github.com/Telmate/terraform-provider-proxmox/blob/3717e8450327435cbc6fd831155b74669a6df921/examples/bug_reporting/vars.tf
If you're able to test with 3.0.1-rc1 and confirm it works, we can mark this issue to be re-tested and closed when the official version 3.x version is released.

This is fixed in the 3.0.1-rc1 build and the fix will be released when everything in #913 has been addressed.


Adds readers for element and logic constraints

Issue #, if available:
#256
Description of changes:
Implements readTypeArg() and adds readers for some constraints that depend on type arguments (element and the "logic" constraints). Updates ReaderTests to cover all of the constraints readers that were added and the $null_or test cases.
Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I'm not sure why Codecov says that some of the lines aren't covered, but it's possibly related to #221.


Upgrade product details to version 0.12.1.

Coverage remained the same at 93.119% when pulling e0602d22c63408fad4480f2f0899b9f75d649a37 on akatsoulas:product-details into f2e4b43b5b03ca3d1828bdf077e691ac4ae7adfd on mozilla:master.

Coverage remained the same at 92.78% when pulling 47091eaaf77ea381d0ef0b3a3ec38fafc814c582 on akatsoulas:product-details into e3578f9e63826aad053db8551f91242224bb2c53 on mozilla:master.


Inconsistency in boundary conditions for nonconservative terms

When computing the boundary conditions for systems with nonconservative terms there is a potential to accidentally add the boundary contribution incorrectly on P4estMesh (https://github.com/trixi-framework/Trixi.jl/blob/main/src/solvers/dgsem_p4est/dg_2d.jl#L365-L371 ) or UnstructuredMesh2D (https://github.com/trixi-framework/Trixi.jl/blob/main/src/solvers/dgsem_unstructured/dg_2d.jl#L443-L449).
If one does not use the surface_flux_function or nonconservative_flux to compute the boundary condition, e.g. as we do for something like the Euler slip walls (https://github.com/trixi-framework/Trixi.jl/blob/main/src/equations/compressible_euler_2d.jl#L299-L337), then the boundary condition will incorrectly be added as something like
surface_flux_values = flux + 0.5 *  noncons

because flux and noncons will be identical and we actually get the boundary flux one and a half times.
It would be better from my perspective if we did not assume / require that the boundary condition is set via a numerical flux for the sake of flexibility.

@ranocha I think this is related to issues that Marco discussed at the last Trixi meeting.

As a starting idea, it would be handy if the boundary condition routine(s) could use a different surface_flux than that used for the interior interfaces taken from surface_integral. This would already grant extra flexibility.

CC @MarcoArtiano

As discussed in the last meeting, we should consider passing (flux_conservative, flux_nonconservative) as flux and call the BC only once. This would need to be tested in practice and documented appropriately.

Unfortunately I couldn't join the Trixi Meeting yesterday. My suggestion and my understanding would have been that I could theoretically use an anti-symmetric volume flux for the non-conservative part, that is consistent with 0, so that no boundary conditions needs to be defined for the non-conservative flux. As far as I know, every non-conservative formulation in Flux Differencing form can be written as a product of a symmetric flux times a jump (i.e. anti-symmetric flux) (this is basically, an equivalent form to the one presented here, https://arxiv.org/pdf/2211.14009, where a non-conservative flux can be written as a product of a symmetric times a local term). The anti-symmetric "formulation" would be also consistent with the point-wise source term, where no boundary conditions are imposed. However, that would require to modify all the existing non-conservative fluxes and might not be the best idea at the moment.
Anyway, I can definitely work on the suggestion presented and pass the tuple directly to the boundary condition call and return the correct value flux + 0.5*cons.

Anyway, I can definitely work on the suggestion presented and pass the tuple directly to the boundary condition call and return the correct value flux + 0.5*cons.

That would be great! Feel free to ping me for a review whenever you have a PR ready.

My suggestion and my understanding would have been that I could theoretically use an anti-symmetric volume flux for the non-conservative part, that is consistent with 0, so that no boundary conditions needs to be defined for the non-conservative flux.

Even with anti-symmetric non-conservative terms, these don't need to be consistent with zero at the boundary, since u_ll and u_rr may differ and the jump term is non-zero. So there are actually some cases where boundary conditions need to be imposed for the nonconservative terms.

My suggestion and my understanding would have been that I could theoretically use an anti-symmetric volume flux for the non-conservative part, that is consistent with 0, so that no boundary conditions needs to be defined for the non-conservative flux.

Even with anti-symmetric non-conservative terms, these don't need to be consistent with zero at the boundary, since u_ll and u_rr may differ and the jump term is non-zero. So there are actually some cases where boundary conditions need to be imposed for the nonconservative terms.

 I didn't consider that option, it would not allow for such flexibility.


Update UI for track show/hide

I think in the interest of being able to contribute changes back to Perfetto upstream we should try to stick to established patterns. @wpaul-samsung what do you think?

Agreed.

I would like to suggest a different approach that allows an application embedding Perfetto to inject these new UI elements by expanding the plug-in API without altering the default presentation and experience:

we need the Notes Panel to be able to create application-specific buttons, so perhaps add a registry of button factories that it can invoke to create them. A plug-in, on activation, can add button factories to that registry in the same way as it can add to the track registry and filter registry via the plug-in context
plug-ins can add call-backs for notification of selection changes for the details panel. Perhaps we could add another call-back for notification that the engine is ready, thus not needing the global emitter. The deferred action that sets the ready state can call into the plug-in API to notify plug-ins that have registered the call-back

Makes sense to me.


[HOLD for payment 2024-03-26] [Simplified Collect][Taxes] Create WorkspaceTaxesSettingsPage

Implement this section of the Simplified Collect: Taxes doc
cc @kosmydel @filip-solecki

Hi! I am Filip from SWM and I'd like to work on this issue!

on hold

No longer on hold. I would be delighted if I could continue to accompany @filip-solecki on this issue

@luacmartins Also help to remove the hold label from the title of the issue
@filip-solecki It seems these features are our priority. Let's start making the PR for this one

I am preparing PR right now

@luacmartins @mountiny We handled 4 issues in this PR that make PR become bigger. I want to ask about how we process payments here
cc @anmurali

Thanks for reaching out @DylanDylann! We'd still pay for a single PR review, since that's what was done here. While I understand that not all issues and PRs are made equal, and some are bigger or more complex than others, I still think that the compensation is fair in this situation.

@luacmartins Thank you for your response. I am happy with your decision. This is a similar case that we also should consolidate into an issue
cc @puneetlath

I believe this is $500 to @DylanDylann and we can close it

Bump for payment

Waiting on payment @anmurali

Offer is here

@anmurali Accepted offer. Thanks

Seems like we're all done here? @DylanDylann

@luacmartins I accepted the offer. Waiting for BZ pay the offer

Thanks for the update. Just waiting on @anmurali

@DylanDylann has been paid.


[SR-6635] Inferring associatedtype from arguments of closure type works only when code is in the same file

Previous ID
SR-6635

Radar
None

Original Reporter
@jepers

Type
Bug

Environment
Xcode 9.2, dev snapshot 2017-12-17

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug

Assignee
None

Priority
Medium

md5: 2af789c030eceab59614d1c65266c0cc

is duplicated by:

SR-6224 Type inference in subscript fails unless moving declaration of containing struct to main.swift

Issue Description:
Note that the following compiles as expected (because everything is in a single file):
$ cat > main.swift
protocol P {
    associatedtype AT
    func f(fn: () -> AT)
    func g(v: AT)
}
struct S : P {
    func f(fn: () -> Int) { }
    func g(v: AT) { }
}
let b = S()
print("The type of AT is", type(of: b).AT.self)

$ /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2017-12-17-a.xctoolchain/usr/bin/swiftc main.swift

$ ./main
The type of AT is Int

But if P and S are declared in a separate file, the following error is (incorrectly) reported:
$ cat > Other.swift
protocol P {
    associatedtype AT
    func f(fn: () -> AT)
    func g(v: AT)
}
struct S : P {
    func f(fn: () -> Int) { }
    func g(v: AT) { }
}

$ cat > main.swift
let b = S()
print("The type of AT is", type(of: b).AT.self)

$ /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2017-12-17-a.xctoolchain/usr/bin/swiftc main.swift Other.swift
Other.swift:8:15: error: reference to invalid associated type 'AT' of type 'S'
    func g(v: AT) { }

(
I also noticed that if the requirement of func g is commented out from P, it will compile, thus successfully inferring the type of AT from the closure-type argument:
$ cat > Other.swift
protocol P {
    associatedtype AT
    func f(fn: () -> AT)
    //func g(v: AT) // <-- Commented out
}
struct S : P {
    func f(fn: () -> Int) { }
    func g(v: AT) { }
}

$ cat > main.swift
let b = S()
print("The type of AT is", type(of: b).AT.self)

$ /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2017-12-17-a.xctoolchain/usr/bin/swiftc main.swift Other.swift

$ ./main
The type of AT is Int

)

Fixed by #69826.


fix: Fix fdroid  reproducible builds

Ref: https://github.com/Pool-Of-Tears/Myne/issues/51#issuecomment-2211098544

Damn dealing with actions is really pain in the a**...

I think I have wasted enough time on this today. I'll try again tomorrow. At least signing the APK works now. I still need to handle the AAB part; I think I need to use jarsigner instead of apksigner to sign the AAB file.

Closing in reference: https://github.com/Pool-Of-Tears/Myne/issues/51#issuecomment-2217700077

I was wondering why they didn't use my workaround on their end. Glad they changed their mind and saved devs like you the trouble.


Repeat when Player reshoots at water

Or don't, we are responsible for the computer's smartness, but not for the player's.


bug: forget password page can reset user's password when user status is forbidden and soft-deleted

forget password page can reset user's password when user status is forbidden and soft-deleted

docker image: casbin/casdoor:v1.505.0

@zzzz0317 fixed by: https://github.com/casbin/casdoor/commit/88130bf0205add6ff0e1d67ca396be15800974c0

I can still send the verification code, but I cannot reset the password in the final step.
I believe that when the user is disabled during the verification code sending process, there should be a prompt indicating the user is disabled. Similarly, when the user is soft-deleted, the prompt should be the same as when the user does not exist.


Uri support (MediaStore/DocumentProvider)

It seems the library doesn't support Uri yet, though in modern Android it's not possible to work without it anymore, also MediaStore.Audio.Media.DATA is not guaranteed to always return the path:

Apps may use this path to do file operations. However, they should not assume that the file is always available:

I tried the following code and returns null
private fun getFilePath(context: Context, uri: Uri): String? {
    try {
        context.contentResolver.query(
            /* uri = */ uri,
            /* projection = */ arrayOf(MediaStore.Audio.Media.DATA),
            /* selection = */ null,
            /* selectionArgs = */ null,
            /* sortOrder = */ null
        )?.use { cursor ->
            if (cursor.moveToFirst()) {
                val sizeColumnId = cursor.getColumnIndex(MediaStore.Audio.Media.DATA)
                if (sizeColumnId != -1) {
                    return cursor.getStringOrNull(sizeColumnId).also {
                        Timber.d("getStringOrNull $it")
                    }
                }
            }
        }
    } catch (e: Throwable) {
        e.printStackTrace()
    }
    return null
}

sorry, duplicate of - https://github.com/lincollincol/Amplituda/issues/40


behaviortree_cpp: 2.4.4-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository behaviortree_cpp to 2.4.4-0:

upstream repository: https://github.com/BehaviorTree/BehaviorTree.CPP.git
release repository: https://github.com/BehaviorTree/behaviortree_cpp-release.git
distro file: indigo/distribution.yaml
bloom version: 0.6.9
previous version for package: 2.4.1-0

behaviortree_cpp
* adding virtual TreeNode::onInit() [issue #33]
* fix issue #34 : if you don't implement convertFromString, it will compile but it may throw
* Pretty demangled names and obsolate comments removed
* bug fixes
* more comments
* [enhancement #32]: add CoroActionNode and rename ActionNode as "AsynActionNode"
  The name ActionNode was confusing and it has been deprecated.
* Update README.md
* removed old file
* Fix issue #31 : convertFromString mandatory for TreeNode::getParam, not Blackboard::get
* Cherry piking changes from PR #19 which solve issue #2 CONAN support
* Contributors: Davide Faconti

holding for sync: https://discourse.ros.org/t/preparing-for-indigo-sync-2018-12-10/7089


AttributeError: 'bytes' object has no attribute 'encode'

Hi,
We are working on a Django project that uses django-easy-pdf - which in turns uses xhtml2pdf - to render a pdf. It has been working great untill it recently broke. Looking at the traceback I believe the error is in xhtml2pdf and not easy_pdf.
To be more specific I suspect commit 8637f24 has broken it. I'm getting AttributeError: 'bytes' object has no attribute 'encode' with the traceback found below.
I'm not very familiar with working on the level of byte-objects, so I'm not entirely sure how this is all supposed to work. Simply commenting out line 182 data = data.encode("utf-8") does remove the issue and renders a PDF again. Is this removing something like a safeguard or has this encode call become redundant?
Thanks!
Environment:

Request Method: GET
Request URL: http://localhost:8080/accounts/invoice/hq5t6n

Django Version: 1.9
Python Version: 3.4.3
Installed Applications:
('django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'django.contrib.sites',
 'allauth',
 'allauth.account',
 'allauth.socialaccount',
 'material',
 'opbeat.contrib.django',
 'accounts',
 'games',
 'subscriptions',
 'debug_toolbar',
 'django_extensions')
Installed Middleware:
('debug_toolbar.middleware.DebugToolbarMiddleware',
 'opbeat.contrib.django.middleware.OpbeatAPMMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'django.middleware.security.SecurityMiddleware',
 'material.frontend.middleware.SmoothNavigationMiddleware',
 'material.frontend.middleware.UnpjaxMiddleware')

Traceback:

File "/usr/local/lib/python3.4/dist-packages/django/core/handlers/base.py" in get_response
  149.                     response = self.process_exception_by_middleware(e, request)

File "/usr/local/lib/python3.4/dist-packages/django/core/handlers/base.py" in get_response
  147.                     response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/var/www/playerxp/playerxp/apps/common/decorators.py" in new_view_func
  14.             return view_func(request, *args, **kwargs)

File "/usr/local/lib/python3.4/dist-packages/django/views/generic/base.py" in view
  68.             return self.dispatch(request, *args, **kwargs)

File "/usr/local/lib/python3.4/dist-packages/django/views/generic/base.py" in dispatch
  88.         return handler(request, *args, **kwargs)

File "/usr/local/lib/python3.4/dist-packages/easy_pdf/views.py" in get
  81.         return self.render_to_response(context)

File "/usr/local/lib/python3.4/dist-packages/easy_pdf/views.py" in render_to_response
  63.         return self.get_pdf_response(context, **response_kwargs)

File "/usr/local/lib/python3.4/dist-packages/easy_pdf/views.py" in get_pdf_response
  59.             **self.get_pdf_kwargs()

File "/usr/local/lib/python3.4/dist-packages/easy_pdf/rendering.py" in render_to_pdf_response
  166.         pdf = render_to_pdf(template, context, encoding=encoding, **kwargs)

File "/usr/local/lib/python3.4/dist-packages/easy_pdf/rendering.py" in render_to_pdf
  139.     return html_to_pdf(content, encoding, **kwargs)

File "/usr/local/lib/python3.4/dist-packages/easy_pdf/rendering.py" in html_to_pdf
  65.                             link_callback=link_callback, **kwargs)

File "/usr/local/lib/python3.4/dist-packages/xhtml2pdf/document.py" in pisaDocument
  182.         data = data.encode("utf-8")

Exception Type: AttributeError at /accounts/invoice/hq5t6n
Exception Value: 'bytes' object has no attribute 'encode'

It seems you're using Python 3, which isn't really supported.
But there is a PR #260  with a couple of TODOs, could you take a look at this and possibly help out make the last pieces of the puzzle fit?

I'd be happy to have a look, but I'm not that experienced so I'm not sure if can really help.

Just a report-back if you can test to see that #260 solves the above-mentioned issue is cool and helps the project progress.

Sure, seems to work fine for me!

Awesome, then I'm closing this issue as fixed by #260 which is gonna get merged and released sooner or later!

I still have this issue. I use python 3 and latest develop branch.
I use Flask and here is a part of my code,
source_html = render_template('customer_portal/invoice_pdf.html',
                                  invoice=invoice)
pisa_context = pisa.CreatePDF(source_html)
response = make_response(pisa_context.dest.getvalue())

And it fails in pisa.CreatePDF:
File "/vagrant/customer_portal/controllers.py", line 139, in invoice_pdf
    pisa_context = pisa.CreatePDF(source_html)
File "/usr/local/lib/python3.4/dist-packages/xhtml2pdf/document.py", line 182, in pisaDocument
    data = data.encode("utf-8")
```

I've debugged a little bit and it looks like a ```data``` and ```out``` are bytes as well, so they don't need to be encoded.

I have found a super-ugly workaround:
class MyBytesIO(object):

    def __init__(self):
        self.storage = BytesIO()

    def write(self, data):
        self.storage.write(data)

    def getvalue(self):
        return self.storage.getvalue()

pdf = MyBytesIO()
pisa_context = pisa.CreatePDF(source_html, dest=pdf)
response = make_response(pisa_context.dest.getvalue())

I could propose a simple pull-request, where lines 181-182 will be removed, it should solve the problem.

Closed by #280, available in 0.1a2


Messages mobile 2

Problem
On #730 I've added styles for the MessageCard component on mobile. It was using media queries to determine if it should use the mobile styles or not, which worked well but didn't quite work on Beacon Embed because, since the component was rendered inside an iframe that was approx 350px wide, it was ALWAYS using the mobile styles, independently of the window's viewport size.
Solution
I tried to look for a way to tell the media query to use the window's size instead of the iframe's, but there doesn't seem to be a good way to go about it, so the styles are now applied using an isMobile flag.
How to test
Go to the MessageCard story in Storybook and check/uncheck the isMobile checkbox: https://share.getcloudapp.com/4gu7PmJk

Pull Request Test Coverage Report for Build 2759

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 2749:
0.0%

Covered Lines:
21

Relevant Lines:
21

💛  - Coveralls


Fix for npm run start command error

When running npm run start, it calls an npm script that then calls
yarn. However, this is supposed to be an npm-only command. This commit
changes the documentation to directly run the patternlab:serve command
instead

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Paul Wright seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Let me know if you'd prefer to change the script command in the package.json file instead of solving it this way.
Also, I'm not sure how to complete the CLA signing. Perhaps I filled it out correctly.

@paintedbicycle your email address that you used to make the commit needs to be apart of your github account for the CLA to work. https://github.com/settings/emails so if they do not match, you have to just add any alternate ones.

Thanks, yes I read that, but one on my account needs to match where? I have a public email in that spot on my account...it needs to correspond to this commit? Where is the "commit email"? Sorry for the hassle

When you made the commit, was it with<EMAIL_ADDRESS>or another? Both emails just need to be in your github.com account for it to sign properly.

There was no public email associated with my account at that time, if that's what you mean. Otherwise I don't know how to check this. When I made this commit, I just forked, changed and committed all with this account...no idea about an email association.

If you type git log under author, that email address, must be in your github.com account under emails. That's what the CLA is comparing against. It's saying that the email of the author doesn't exist in a github.com account.

OK, yes it was empty (using my local computer's username), so it doesn't match my email. I'll just close this PR

ok, I'll make the change for you if you'd like @paintedbicycle

Sure, if you agree with it, feel free. Thanks

Hi @paintedbicycle, thanks for your contribution! I want to make sure any additional PRs you'd like to make can be merged in successfully, so here are a couple git tips around emails:

To change the email associated with your last commit, run:

git commit --amend --author "NAME_GOES_HERE<EMAIL_ADDRESS>

You'll want to set your email address either globally on your computer (recommended), or remember to set it before making any edits to a repo by following the instructions here: https://help.github.com/articles/setting-your-commit-email-address-in-git/

Then as Matt mentioned, as long as the email associated with your git commit is also associated with your GitHub account, the CLA tool will recognize you've already signed it

Ah, ok, thank you for that. I have fixed my commit on my repo and set my default address locally going forward. Is there a way to update this PR with the new commit?

You'll have to force-push your update to repo:
git push origin master --force

and then in theory that should automatically update this PR... I'll reopen it so we can see if that works

Done. Looks like it all worked.
Thank you for teaching me to git on the command line. ::embarrassed-emoji

Awesome! Happy to help @paintedbicycle 😄


Prefix data disk storage accounts

It's impossible to figure out what the storage account currently is

I'm going to close this issue to consolidate it on #93, since they both relate to prefixing resources


Repeated match dates

Have you considered moving match date one level up to the match day level? All the matches on the same match day have the same dates. That may remove some duplicate dates.

The names of the teams are also duplicates. If you want to contribute, you're more than welcome.


⚠ Bofrost.de has degraded performance

In b4cee3f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1672 ms

Resolved: Bofrost.de performance has improved in ff0c04d after 1 hour, 11 minutes.


GPU not used when fine-tuning on SQuAD 2.0

Hi, thanks for the great contribution!
I am trying to fine-tune on SQuAD 2.0 using run_squad_v2.py but the GPU is not used:
python -m albert.run_squad_v2  --albert_config_file=albert/albert_base/albert_config.json  --output_dir=albert/outputs  --train_file=albert/train-v2.0.json  --predict_file=albert/dev-v2.0.json  --vocab_file=albert/albert_base/30k-clean.vocab  --train_feature_file=train_feature_file.tf  --predict_feature_file=predict_feature_file.tf  --predict_feature_left_file=predict_left_feature_file.tf  --init_checkpoint=albert/albert_base/model.ckpt-best.index  --spm_model_file=albert/albert_base/30k-clean.model  --do_lower_case  --max_seq_length=384  --doc_stride=128  --max_query_length=64  --do_train  --do_predict  --train_batch_size=48  --predict_batch_size=8  --learning_rate=5e-5  --num_train_epochs=5.0  --warmup_proportion=.1  --save_checkpoints_steps=5000  --n_best_size=20  --max_answer_length=30
The examples/sec: 0.389458 and nvidia-smi shows the GPU usage is 0%.
I also find the "use_tpu" flag on run_squad_v2.py, but it shows the option is TPU or "GPU/CPU". Does the "GPU/CPU" have priority of GPU or CPU?
OS: Ubuntu 16.04
GPU: K80
TensorFlow: 1.15.2
Does anyone know the possible solutions to this situation? Thanks in advance.

1.15.2 is cpu only version. try tensorflow-gpu==1.15

@lixiangtnt is this mean uninstall tensorflow 1.15.2 and use tensorflow-gpu library only? appreciate ur help.

I solved this problem with conda install tensorflow-gpu==1.15.
pip install tensorflow-gpu==1.15 doen't work as expected.

@YuHengKit - Is it possible to provide your notebook file which ran successfully for Albert fine-tuning for SQuAD 2.0 dataset?
I am facing issue of training is not getting started and stopped abruptly after warm up steps without any error.
Appreciate your help in advance.


lodash: add nested file exports for lodash

We've started to do a lot of imports like import map from 'lodash/map' to take advantage of webpack's tree-shaking features... unfortunately, the existing flow-typed defs don't work with those imports.

If you're using Babel you can use babel-plugin-lodash to convert import { map } from 'lodash' to import map from 'lodash/map' as a workaround.