feat: update hertz and adapt content_encoding header

What type of PR is this?

feat
What this PR does / why we need it (English/Chinese):
en: update hertz and adapt content_encoding header
zh: 更新 Hertz 并且适配 Hertz 的 content-encoding pr

Which issue(s) this PR fixes:

https://github.com/cloudwego/hertz/issues/531

@welkeyever everything ok?

@Duslia possible to delete the "Server" header? i've tried deletion and somehow the "Server" header is always showing. can u try deleting "Server" header?

@Duslia please expedite this. i was testing/debugging for real long time.
this repo last updated 7th Dec 2022

@Duslia please expedite this. i was testing/debugging for real long time. this repo last updated 7th Dec 2022

done. You can try this branch.

@Duslia do i do
go get github.com/hertz-contrib/http2@adapt_content_encoding ?
sorry i hv never tried doing so before. when can we really used merge version?

this is crucial for h2 to work properly.
sorry for complaining coz i was testing since Dec 7th with this problem...

LGTM


Connected to Switcher

Hi,
I've been looking through your library and I can't seem to figure it out, but is there a way to tell if the controller is connected to a switch? Or if it disconnects from a switch?
Thanks-

Hi @reykroona
You can add a handler to handle InitiationComplete messages. They will be emitted when a software controller is successfully connected to a switcher.
For the moment there is no way to know when a switcher disconnects though. I will add a way to get this information in a future version.

Thanks, I'll look into that. I've also made some changes in a forked repo in my account that adds CCU controls for shutter, iris, wb, gain & autofocus. I'm not really a programmer by trade, so I'm not 100% sure how to submit a pull request since it's based on an older version, but if you are interested in adding it, it's there.

Any chance to be notified on disconnected and
sendto(descriptor:pointer:size:destinationPtr:destinationSize:) failed: Can't assign requested address (errno: 49)
ioOnClosedChannel
ioOnClosedChannel
...

in order to reset the controller object. Thanks!


How to  change report path to custom location?

How to  change report path to custom location?

Any updates on this? Codecov has poor integration with monorepos, so it would be amazing if we could update the paths in the istanbul reports themselves.


build.sh script not working

Hello,
When I run the build.sh script, I realized there's no server/dist/server.cjs.js and no server/public, which lead to errors when I "cd client" and "npm run start".
Where did I make it wrong ?
BTW I discover the project in the Mots Flex fanzine at Atelier du Toner, nice work !

Hi there !
Did you run npm install in server and client folders ?


Some mods suggestion

QOL
https://www.nexusmods.com/skyrimspecialedition/mods/89163?tab=files
Save a lot of times
https://www.nexusmods.com/skyrimspecialedition/mods/64764
No stamina cost sprint outside of combat
Armor/weapons
https://www.nexusmods.com/skyrimspecialedition/mods/87272
https://www.nexusmods.com/skyrimspecialedition/mods/37610
https://www.nexusmods.com/skyrimspecialedition/mods/6227
https://www.nexusmods.com/skyrimspecialedition/mods/88656

I will make sure Instantly Skip Dialogue works well with some of the modded quests we're using. By that mod's nature, I can expect quite a few quests to bug out expecting the player to not be able to skip certain dialogue.
We are already using this mod to do what Elden Sprint does, and with an SKSE implementation instead of Skyrim Platform.
I will check out all of those equipment mods! Always looking for more :)


Add newlint target to Makefile

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
In preparation for Go 1.18, we are adding a "newlint" target to Makefile allows running golangci-lint
Also minor reformatting in Makefile
Fixes # (issue)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[X] I run make pre-commit to check fmt/vet/lint/test-no-fdo

its look good. wander if there is a possibility to add somewhere a test that checks those changes
It's out of scope for this PR but I can see the following:

syntax checking using something like checkmake
functional testing to ensure all reasonable make targets complete successfully


[plot3d] Ignore setting scale to 0 from parameter tree

This PR ignore scales set to 0 from the GUI in the plot3d SceneWindow parameter tree.
closes #1731

LGTM


tsdb: add block chunks repair cmd tool

Proposal
we can scan the chunks file and find the first corrupted chunk,
then truncate the chunks file to first corrupted chunk.
Rebuild the index and mete.json by ignoring series those have no chunks.
so that we no need to remove the whole block (lose the whole block data) in order to startup/compact/query.

cc @krasi-georgiev @bwplotka

This would be unsafe, partial data is virtually impossible to reason about.

even if there is a way to delete by a time range? I mean if can delete everything after the corruption this should work ok, right?

delete everything after the corruption

Yes.

that was a question for @brian-brazil
He is more involved in real production uses or Prometheus.
Should it be ok to deleted all data after the corrupted chunk?

We looked at this as part of the bug scrub, and a promtool command to drop entire blocks based on them containing corrupt data somewhere is considered reasonable.

Hello from the bug scrub.
We still think this is a useful feature we would accept. But since nobody worked on it in 4y, we assume the need is not urgent enough to justify keeping this issue open.


chore(main): release 0.2.5

:robot: I have created a release beep boop
0.2.5 (2024-01-16)
Bug Fixes

rbac: add missing group from manager-role (d4163e8)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/versori-oss/nats-account-operator/releases/tag/v0.2.5 :sunflower:


HDDS-5384 OM refreshPipeline should not invoke the expensive OmKeyLocationInfoGroup.getLocationList()

What changes were proposed in this pull request?
Reduce the CPU/heap allocation overhead of listStatus
What is the link to the Apache JIRA
HDDS-5384
How was this patch tested?
Please find the flamegraph attached in the corresponding JIRA for the cpu and heap allocation before and after the change.

The test failure seems unrelated. TestWatchForCommit fails occasionally even without this change.

The test failure seems unrelated. TestWatchForCommit fails occasionally even without this change.

Seems to be some check style failures can you fix them. As until basic steps are clean, we cannot get complete CI run, CI will be aborted.


Add support for ruby 2.5.4 and 2.6.2

https://www.ruby-lang.org/en/news/2019/03/13/ruby-2-6-2-released/

Add support for ruby 2.5.4

Thanks! But I think this PR should be renamed after that.


fix: fix async algorithm, add warmup steps and only update weights after backwards

need to change the algorithm


Change name

@cconrad8 - on the homepage of the NF portal, we have "Portal Programs and Goals". I'm not sure that makes much sense given what's actually listed below. Do you have thoughts on what we should change this title to>?
https://github.com/Sage-Bionetworks/synapse-web-monorepo/blob/79ed1b6fb99d4ebad8a47f80ff5445f2760354ad/apps/portals/src/configurations/nf/routesConfig.ts#L56

@cconrad8 , just ran across this issue and re-upping it. I cannot assign issues on this repo, sorry about that!

@allaway maybe "Resource Overview"?

That works for me!
On Thursday, November 14, 2024, Christina Conrad @.***>
wrote:

@allaway maybe "Resource Overview"?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.<
https://ci3.googleusercontent.com/meips/ADKq_NbY3H7xBYBpwhpI2NDlYn6K7BEfLpJsdI-Q_E03o-pUGRQ-KL-cWSHMfdnkx2jJT024APh30gWdR3AjUlIwsXfZTD08R2GwOef_FuG0ppxJR9hh7sXR-P74DPEjIIzux1kuStbL5irEZBcOa8PySx8_Pqfzqy5Axtm5kxbeMQ2NLW0jCsOIIRmSYJnlcLPktrI07EHw_E7iAcFc4dyOxR8cUL2hHmv9KU3-owxc1Kzthpx-UrBhI5E=s0-d-e1-ft#https://github.com/notifications/beacon/AE3WNSBYTKOZJRHHA4V5QJD2ATRLDA5CNFSM6AAAAABRZOBCJKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUTUV26Y.gif>Message
ID: @.***>

Ok! submitted a PR https://github.com/Sage-Bionetworks/synapse-web-monorepo/pull/1380
@nickgros for visibility


CentOS7 go install Problems arise

[root@iznpqe8ynbddhpz clickhouse_exporter-master]# go install
clickhouse_exporter.go:9:2: cannot find package "github.com/f1yegor/clickhouse_exporter/exporter" in any of:
/opt/soft/gopath/src/github.com/clickhouse_exporter-master/vendor/github.com/f1yegor/clickhouse_exporter/exporter (vendor tree)
/opt/soft/go/src/github.com/f1yegor/clickhouse_exporter/exporter (from $GOROOT)
/opt/soft/gopath/src/github.com/f1yegor/clickhouse_exporter/exporter (from $GOPATH)

Solved in master


Update name of Arch package

https://archlinux.org/packages/community/x86_64/lychee/

Perfect. Nice that we could simplify the package name. Thanks!


Reduce the size of the articles seed for development

Right now seeding the articles takes way too long, I feel like we should have a subset of articles to display the minimal requirements for making good decisions during development.
I'm not too familiar with the data here, So I would need some help.

See: https://github.com/crimethinc/website/issues/383


Capture.. Bot

ERROR [youtube] . Sign in to confirm you’re not a bot. This helps protect our community. Learn more
youtube detects bot activity

yt-dlp issue


Double Tap a Topic Can Launch Two QuizAcitivity

Issue demo: https://cloudup.com/iermuTL5MnA

Thanks for the PR.


Set up a basic Keycloak server using Docker.

Hello sir @stephane-segning please can you give me more inside on this.

Done in https://github.com/stephane-segning/lynx-scanner-backend/pull/19


Cannot uregister peer - says there're environments, but if we delete them all, it still shows this

Please help. Peer - <IP_ADDRESS>

This is either internal latency of Bazzar or the peer has environments of some other users.
This error comes from Bazzar and has nothing to do with Console

ok, will re-locate


Investigate error on Buildkite when publishing without changes to docs.

@asafkorem what is this about? Could this in fact be a dup of https://github.com/wix/Detox/issues/3528?

Yes


Sanitize esp

see #411

Hi Brent,
I see a revised ESP6500 VCF at s3://gemini-annotations/ESP6500SI.all.snps_indels.tidy.v2.vcf.gz. I looked there directly because I am having some trouble with the install/upgrade at the moment, but I think there is already a thread about that.
What I want to report here is a lingering issue with the sanitized ESP6500 file. In order for 'vt decompose' to perform correctly, the INFO field for the EA_AC, AA_AC, and TAC fields has to have Type=Integer, not Type=String. Not sure why vt requires that, but with just Type=String, it doesn't split up the INFO fields correctly. For example, the revised ESP6500 file still has lines like this:
1       6638842 .       CGCTGCTGCT      C       .       PASS    DBSNP=.;EA_AC=8254,0,0;AA_AC=4265,1,2;TAC=12519,1,2;MAF=0.0,0.0703,0.024;GTS=A1A1,A1A2,A1R,A2A2,A2R,RR;EA_GTC=0,0,0,0,0,4127;AA_GTC=0,0,1,0,2,2131;GTC=0,0,1,0,2,6258;DP=40;GL=TAS1R1;CP=0;CG=4.1;AA=.;CA=.;EXOME_CHIP=no;GWAS_PUBMED=.;GM=NM_138697.3,NM_177540.2;FG=codingComplex,codingComplex;AAC=.,.;PP=.,.;CDP=.,.;GS=.,.;PH=.,.;OLD_MULTIALLELIC=1:6638842:CGCTGCTGCT/C/CGCTGCTGCTGCTGCTGCT
1       6638842 .       C       CGCTGCTGCT      .       PASS    DBSNP=.;EA_AC=8254,0,0;AA_AC=4265,1,2;TAC=12519,1,2;MAF=0.0,0.0703,0.024;GTS=A1A1,A1A2,A1R,A2A2,A2R,RR;EA_GTC=0,0,0,0,0,4127;AA_GTC=0,0,1,0,2,2131;GTC=0,0,1,0,2,6258;DP=40;GL=TAS1R1;CP=0;CG=4.1;AA=.;CA=.;EXOME_CHIP=no;GWAS_PUBMED=.;GM=NM_138697.3,NM_177540.2;FG=codingComplex,codingComplex;AAC=.,.;PP=.,.;CDP=.,.;GS=.,.;PH=.,.;OLD_MULTIALLELIC=1:6638842:CGCTGCTGCT/C/CGCTGCTGCTGCTGCTGCT;OLD_VARIANT=1:6638842:CGCTGCTGCT/CGCTGCTGCTGCTGCTGCT
If you add a line to the sanitize_esp.py script to change Type=String to Type=Integer, then 'vt decompose' will parse it properly.
-Jason

Hi Jason,
thanks for reporting and persisting. I did pretty much exactly what you said and uploaded the new ESP vcf.
Here is the sanity check:

$ wget https://s3.amazonaws.com/gemini-annotations/ESP6500SI.all.snps_indels.tidy.v2.vcf.gz
...

$ zgrep -cv "#" ESP6500SI.all.snps_indels.tidy.v2.vcf.gz
2002056

$ zgrep -cP ";AA_AC=\d+,\d+," ESP6500SI.all.snps_indels.tidy.v2.vcf.gz
0
$ zgrep -cP ";AA_AC=\d+,\d+;" ESP6500SI.all.snps_indels.tidy.v2.vcf.gz
2002065

$ zgrep -cP ";EA_AC=\d+,\d+," ESP6500SI.all.snps_indels.tidy.v2.vcf.gz
0
$ zgrep -cP ";EA_AC=\d+,\d+;" ESP6500SI.all.snps_indels.tidy.v2.vcf.gz
2002065

$ zgrep -cP ";TAC=\d+,\d+," ESP6500SI.all.snps_indels.tidy.v2.vcf.gz
0
$ zgrep -cP ";TAC=\d+,\d+;" ESP6500SI.all.snps_indels.tidy.v2.vcf.gz
2002065


Views alpha reseting to 1 after view disappear.

Im using a TabBarController with fadeIn and fadeOut transition modes.
My issue is that some subviews of one of the presenting view controllers are setting the alpha back to 1 after I animated them with fadeOut before exiting the view controller.
It sounds like a problem with the fade transitions used between view controllers and views being animated as well.
Update: Problem persist after removing the subview fade animation. Seems to be completely related to the transition mode.
Using version 1.1.2 of cocoapods.

This is a linked issue: https://github.com/CosmicMind/Material/issues/853

I will be working on this either today or tomorrow :)

Very cool! Thanks a lot 😁

Please give Motion 1.3.0 a try. If the issue persists, please reopen it. Thank you!


For Two textboxes it is coming(i.e.., for the first and the fourth) and i want only for fourth one to be a date picker

Date picker is coming for first textbox and also fourth textbox i want it only for the fourth text .First text should be served for another purpose

Sorry, I do not understand the question. Can you elaborate?

Means i want to keep date picker inside a form and in that form there are  7 input  fields but date picker is coming for first input field only(but i don't need it there) when i add class date for fourth input  field(where i need date picker) then it is showing  picker but selection is not possible for fourth input field

Still not sure what is going on wrong... you can apply it to any field or even use without input field and read/write text field in your code to trigger datepicker show/hide.

I fixed it


Properly follow linked namespace container for stats

Podman containers can specify that they get their network namespace from another container. This is automatic in pods, but any container can do it.
The problem is that these containers are not guaranteed to have a network namespace of their own; it is perfectly valid to join the network namespace of a --net=host container, and both containers will end up in the host namespace. The code for obtaining network stats did not account for this, and could cause segfaults as a result. Fortunately, the fix is simple - the function we use to get said stats already performs appropriate checks, so we just need to recursively call it.
Fixes #5652

Let me add a test...

Test added

Your test is failing.

Huh. Apparently --net=host is not supported on rootless pods (we can't setns the host network namespace).

I'll add a rootless skip on the test for now, but we should probably fix or disable this.

We should definitely support running a pod on the host network.

/lgtm


Fixes to trash

I have tried running the dev branch of Errands and I have found few problems with trashing items. I have made fixes to these issues and made them into this PR.
These fixes include:

Trashed tasks not being displayed on load. Refresh by trashing another task was needed to show them correctly.
Restoring tasks was failing because of call to a non-existent method.
Sidebar not being updated to reflect changes made by trashing task.

I have also noticed that tasks after being recovered are marked as completed. I wasn't sure if that is intended or not so I left that in.

Thank you! I didn't have time today to get to fixing trash :) Just made State class today, now it much easier to access stuff.

tasks after being recovered are marked as completed

It's intended, because tasks that moved to trash automatically marked as completed, and when they are restored, they still marked as completed.


Is this project still in development?

Version of SharpShell used: 2.x.y
Related type(s) of SharpShell-Server: Any
...
Log Messages
If you are seeing unexpected behaviour, please include relevant logs here:
...
There is a guide on getting the logs for SharpShell in the SharpShell Logging page.
I want to use this project for one of my production application (Open source offcourse)
My question is that is it still in development and supported?
I see that last release is from 2019 which is too old.
Am I missing something?


Prevent sharing of config between different UA instances

The global instance of Settings in lib/src/config.dart causes different UA instances to share settings, meaning that e.g. all instances try to auth with the same credentials even if initialised with different creds. This solves that by creating a new Settings instance for each UA.

LGTM


Handle errors in local task config

Closes https://github.com/mlcommons/mobile_app_open/issues/354
When current config is corrupted, app shows the following screen which allows user to get the app to a working state:

@anhappdev this PR is not intended to fix issues with default task config, it's for custom configs.
We have no control over custom configs, so moving the default config anywhere wouldn't help here.


array_key_first() requires PHP 7.3

Composer json needs to be updated to require php 7.3
https://github.com/odan/phinx-migrations-generator/blob/091b8930c9e5c820e54d4f65e6b422bf124b2292/composer.json#L16
https://github.com/odan/phinx-migrations-generator/blob/ecb21f9aed310e7276f4f4e3dbaddf76be82369b/src/Migration/Command/GenerateCommand.php#L291

Thanks for reporting. A polyfill for array_key_first has been added.


validation.uploaded Error

I get a validation.uploaded error when attempting to upload this theme, v1.1.

Fix


Vulnerability of dependency "golang.org/x/net"

Hello, we are a team researching the dependency management mechanism of Golang. During our analysis, we came across your project and noticed that it contains a vulnerability ([CVE-2022-41723](https://github.com/advisories/GHSA-vvpx-j8f3-3w6h)). In your project, the golang.org/x/net package is being used at version v0.0.0-20201202161906-c7110b5ffcbb, but the patched version is v0.7.0. To fix the vulnerability, we recommend modifying the go.mod file to update the version to v0.7.0. Thank you for your attention to this matter.

We also came across your project and noticed that it contains a vulnerability (CVE-2022-32149). In your project, the golang.org/x/text package is being used at version v0.3.3, but the patched version is v0.3.8. To fix the vulnerability, we recommend modifying the go.mod file to update the version to v0.3.8 or higher. Thank you for your attention to this matter.

We also came across your project and noticed that it contains a vulnerability (CVE-2022-21698). In your project, the github.com/prometheus/client_golang package is being used at version github.com/prometheus/client_golang v0.9.2, but the patched version is v1.11.1. To fix the vulnerability, we recommend modifying the go.mod file to update the version to v1.11.1 or higher. Thank you for your attention to this matter.

We also came across your project and noticed that it contains a vulnerability (CVE-2022-21698). In your project, the github.com/mattn/go-sqlite3 package is being used at version github.com/mattn/go-sqlite3 v1.9.0, but the patched version is v1.14.7. To fix the vulnerability, we recommend modifying the go.mod file to update the version to v1.14.7 or higher. Thank you for your attention to this matter.

We also came across your project and noticed that it contains a vulnerability (CVE-2023-25153). In your project, the github.com/containerd/containerd package is being used at version github.com/containerd/containerd v1.3.4, but the patched version is v1.6.18. To fix the vulnerability, we recommend modifying the go.mod file to update the version to v1.6.18 or higher. Thank you for your attention to this matter.


Ability to Provide Configuration for MaxTokens, etc to Bedrock

Add a Configuration class, similar to what AzureOpenAI and other providers have, to be able to set MaxTokens, Temperature, etc on the Bedrock provider. Right now there is no way to change the MaxTokens on the Model or Provider level.
@curlyfro It appears you are actively working on the Bedrock Provider.

Let's try AI generated PR first, may be it will good foundation

@ericgreenmix to get answers faster it will be better to ask this in discord, I can add you to the dev channel, just join it and tell me your nickname.

@ericgreenmix, max tokens are already there.  you can change like this and most models have their own ChatSettings:
var provider = new BedrockProvider();
var llm = new Claude3SonnetModel(provider)
{
    Settings = new BedrockChatSettings
    {
        MaxTokens = 200_000,
        Temperature = 0,
        UseStreaming = true
    }
};

I tried to document this in the wiki.

Ah okay, thank you for updating the documentation. That is working


Remove marker.dragging when not on the map

Fix for #5293
Not 100% sure this is the right way to do this, but it is probably the easiest ;)
An issue we have now is that interacting with the dragging object while the marker is not on the map is not really valid as the dragging handler depends on the icon, which doesn't exist while not on the map.
This is probably a breaking change, although I don't expect it to actually affect many users.

Added a note for the docs. Can't get jekyll to work on windows, so not 100% sure the formatting is right.


Moving over to qBittorrent having trouble getting SMA to trigger

I'm moving over to qBittorrent as I have found its about 80% faster than deluge 😱 .
I have installed the python package as required and filled in all details etc however when a torrent finish's nothing seems to happen, there's nothing in the log either so its like its not being called.
With Deluge I had to use a bat file cos calling the .py direct didn't work, would that help here aswell?

Sounds like you need to update your deluge configuration cause there is no reason it should be 80% faster, but whatever you're free to use qBittorrent.
You might need a bat file its entirely dependent on how your registry is configured to handle .py files and your python environment setup but can't hurt to use one if its not executing which would suggest directly executing .py files isn't working
See this closed issue
https://github.com/mdhiggins/sickbeard_mp4_automator/issues/1291

Gave up on that idea, just couldn't get it to work, but did find a plug in for deluge that fix my slowness seems its a backend design ☹  lmao


docs publishing should not be nested in subdirectories

The docs are currently published in a directory structure like this:
xebra.js/[version_number]/
In order for GitHub Pages to work correctly, the index.html needs to be in the root directory on the gh-pages branch.
Maybe just fix this up with some postpublish script.

Maybe this has been fixed with @fde31 's new jaguarjs-docs template? Will test with the next release.

I fixed this in my fork of the jaguarjs-jsdoc repo, which can be found here https://github.com/fde31/jaguarjs-jsdoc/tree/xebra_docs
And I remember I published the docs once as a test (to see the correct version number) and it was okay as in 'without subdirs'. So I'm assuming you had an old version of the package around that still generated the subdir structure. It's a bit annoying tbh and I think the way to solve this is by running a npm update. Basically this will check for updated deps and according to https://github.com/npm/npm/issues/1727 Git URLs are always updated, which I assume is exactly what we want in that case. Might wanna consider making this part of the preversion script?

ok, this is exactly what I did in commit e5164fa


The place 'Peloponnese' has been encoded as a linestring, and not as a polygon

In Nodegoat, under sub-object, this place does not have a polygon encoding, but rather a linestring. This means that while it looks ok at a distance:

Up close, it is clearly missing pieces:

This should be fixed on the Nodegoat end and the data should be refreshed.

The images above disappeared for some reason. This is the before (lower magnification):

And this is the after (higher mag):

hello!

This is Clara

yep

This will need to be re-coded in NodeGoat


Support for files larger than 1MB

I've successfully created a heroku server, and deployed word_diff to it.
When sending my first payload, I get the following error message in the logs:
Octokit::Forbidden: The requested blob is too large to fetch via the API, but you can use the Git Data API to request blobs up to 100 MB in size.
 Error summary:
   resource: Blob
   field: data
   code: too_large // See: https://developer.github.com/v3/repos/contents/#get-contents:
    /app/vendor/bundle/ruby/2.0.0/gems/faraday-0.9.1/lib/faraday/response.rb:9:in `block in call'
    /app/vendor/bundle/ruby/2.0.0/gems/octokit-3.8.0/lib/octokit/response/raise_error.rb:16:in `on_complete'
    /app/vendor/bundle/ruby/2.0.0/gems/faraday-0.9.1/lib/faraday/response.rb:57:in `on_complete'
    /app/vendor/bundle/ruby/2.0.0/gems/faraday-0.9.1/lib/faraday/response.rb:8:in `call'
    /app/vendor/bundle/ruby/2.0.0/gems/faraday-0.9.1/lib/faraday/connection.rb:377:in `run_request'
    /app/vendor/bundle/ruby/2.0.0/gems/faraday-0.9.1/lib/faraday/rack_builder.rb:139:in `build_response'
    /app/vendor/bundle/ruby/2.0.0/gems/faraday-0.9.1/lib/faraday/connection.rb:140:in `get'
    /app/vendor/bundle/ruby/2.0.0/gems/sawyer-0.6.0/lib/sawyer/agent.rb:94:in `call'
    /app/vendor/bundle/ruby/2.0.0/gems/octokit-3.8.0/lib/octokit/client.rb:339:in `request'
    /app/vendor/bundle/ruby/2.0.0/gems/octokit-3.8.0/lib/octokit/client.rb:135:in `get'
    /app/vendor/bundle/ruby/2.0.0/gems/octokit-3.8.0/lib/octokit/client/contents.rb:35:in `contents'
    /app/lib/word_diff/document.rb:31:in `download'
    /app/lib/word_diff/document.rb:46:in `to_md'
    /app/lib/word_diff/document.rb:75:in `create'
    /app/lib/word_diff.rb:62:in `block (4 levels) in <class:WordDiff>'
    /app/lib/word_diff.rb:47:in `each'
    /app/lib/word_diff/document.rb:67:in `convert'
    /app/lib/word_diff.rb:49:in `each'
    /app/lib/word_diff.rb:46:in `each'
    /app/lib/word_diff.rb:46:in `block in <class:WordDiff>'
    /app/lib/word_diff.rb:49:in `block (3 levels) in <class:WordDiff>'
    /app/vendor/bundle/ruby/2.0.0/gems/sinatra-1.4.5/lib/sinatra/base.rb:1603:in `call'
    /app/lib/word_diff.rb:47:in `block (2 levels) in <class:WordDiff>'

Any chance of larger file support?

@Razoxane The Gem could fall back to use the raw / blob endpoint, but that would fail for private repos. We'd have to shallow clone the entire repo to get private files larger than 1MB. If this is still an issue, would you be interested in / able to  adding a PR to fall back to the raw.githubusercontent.com version of the file?


Full implementation of WordPress comments??

I may be missing something but I can find nowhere "in the wild" an implementation of Timber/TWIG that properly manages WordPress commenting, by which I mean both nested comments and the comment form.
I would have thought this would have been a pretty fundamental requirement?!
Has anyone got some code I could work off? Anyone seen anything?!
A

You could try something like this (simplified):
{% if post.get_comment_count() > 0 %}
  {% for comment in post.comments %}
    {{ comment.author.name }} - {{ comment.date }}

    {{ comment.content }}

    {% if comment.children() %}
      {% for reply in comment.children() %}
        {{ reply.content }}
      {% endfor %}
    {% endif %}
  {% endfor %}
{% endif %}

{{ fn('comment_form') }}

Thanks @luukdv. I'm looking for a more thorough implementation that would not just use fn('comment_form') but instead would really break it out in to twig vars, etc. So I can style it, etc. I understand that's not trivial!
I've seen in another implementation of Twig (not Timber) that they've done nested comments and it also is not trivial.
A

Hi! Any news on this?

@Leobaillard if you're interested, I'd love to see a PR! I don't have time to code stuff like this from-scratch right now

Thanks for your PR @Leobaillard! I uncovered another issue in writing a test so I'm gonna work on that a bit so that we can have Timber Comments be 💯

I'm working on a new class for groups of comments attached to a post — CommentThread for a class name? Just Thread? taking suggestions....

Seems good! It's more generic than Child, it reflects the comment mechanism better. Looking forward to seeing what you'll come up with!

@Leobaillard @alicam — this is now ready, check out the current version of master!

@jarednova Sorry. Taken a while to realise this was here and done! Very exciting. I'll be implementing as soon as I get a free moment. Thanks!!

I'm curious if anyone out there has an example of working comments pagination with the new CommentThread class...

I'm curious if anyone out there has an example of working comments pagination with the new CommentThread class...

Is there a working example? I'm currently busy making a theme but 1 post with 2019 comments is taking the page 45 seconds to load. And I can't find a proper way to paginate the Comments with Timber at the moment.

@ChapeauDigital could you provide us with a code sample?

@palmiak ofcourse. I'm using the out of the box features at the moment. I'm pretty new to Timber so be aware of the crappy code. It's a learning curve.
I did find the CommentThread functions but can't find any documentation or code examples.
comments.twig
`{% set number_of_comments = post.comments | length %}
{% if post.comment_status == "closed" %}
 comments for this post are closed
{% else %}
  Reactie plaatsen

    {% include "/partial/modules/comment-form.twig" %}

{% endif %}
{% if post.comments %}
Reacties ({{ post.comments | length }})

  {% for cmt in post.comments | reverse | slice(0, 200) %}
      {% include "/partial/modules/comment.twig" with {comment:cmt} %}
  {% endfor %}
{% endif %}
{% if post.comment_status == "closed" %}
 U kunt niet meer reageren.
{% endif %}
{% if number_of_comments > 6 %}
{% include "/partial/modules/comment-form.twig" %}
{% endif %}**comment.twig**{% set depth = comment.depth %}

{{ comment.author.name }}
{{ comment.comment_date }}

		{{ comment.comment_content | wpautop }}
		Beantwoorden

			{% include "/partial/modules/comment-form.twig" %}

	{% if comment.user_id %}

	{% else %}
		{{ comment.author.name | slice(0, 2) | upper }}
	{% endif %}

{% if post.comments %}

{% for cmt in comment.children %}
{% include "/partial/modules/comment.twig" with {comment:cmt} %}
{% endfor %}

{% endif %}
`

First of all you're right - the documentation of comments isn't too great. We'll have to work on this.
Could just explain me one thing before we continue - are you trying to display about 200 comments at once? Or does it works slow even when you set the comments pagination to 10-20 comments per page?

Too be completely transparent I didn't had a clue where to start to make the comments work with pagination. I tried to make it 'the WordPress way' with php but the 'native Timber' child and depth what I really like about Timber didn't work anymore so I kinda give up on that idea. My main goal was to show about 50 per page and start the pagination from there. I set a limit within the WordPress comment settings but Timber seems to ignore that part.

Ok, everything is clear. I'll try to do this during the week. As I see,
Timber uses the query vars responsible  for pagination so the only problem
is to create the next and prev links.
wt., 23 paź 2018, 10:16 użytkownik Arno T<EMAIL_ADDRESS>napisał:

Too be completely transparent I didn't had a clue where to start to make
the comments work with pagination. I tried to make it 'the WordPress way'
with php but the 'native Timber' child and depth what I really like about
Timber didn't work anymore so I kinda give up on that idea. My main goal
was to show about 50 per page and start the pagination from there. I set a
limit within the WordPress comment settings but Timber seems to ignore that
part.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/timber/timber/issues/1205#issuecomment-432143994, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACO-Or71Az3cHkugHa_u6WDMs2dxvtKFks5untBOgaJpZM4KOZhI
.

@palmiak Hey Palmiak, I would love to know if you found any solution to it?

Hello, same thing.
I'm very eager to know if there is any pagination progress and also, how to do a full comment form using twig as the one included in the starter_theme doesn't seem to work.

For future searchers, the docs have been updated with more info on Comments:
https://timber.github.io/docs/guides/comments/
If you're looking to do more sophisticated manipulation of comments, check out the CommentThread class:
https://github.com/timber/timber/blob/master/lib/CommentThread.php
Comment pagination is something I'd love to formally codify and document. I'm going to close this issue in favor of #2034 which focuses just on that


make a suggest command

I can make a ;suggest command

Original Message by @yoru#9267

did this with stream maps


Cherry-pick mTLS analyzer for 1.4

Including these PRs: #18700, #19055, #18350, #18478, #18917, #18935, #19244
Note that this adds the structured format options to istioctl analyze. It's not needed for the mTLS analyzer, but including it means the cherry-picks apply cleanly.
I briefly tested it by hand and both structured output and the mTLS analyzer seem to work as expected:
jsselman-imacpro:~/g/s/i/istio (mtls-analyzer-1.4|✔) $ ~/go/out/darwin_amd64/release/istioctl  x analyze -k -o json
[
        {
                "code": "IST0113",
                "level": "Error",
                "message": "A DestinationRule and Policy are in conflict with regards to mTLS for host *.svc.cluster.local in namespace istio-system. The DestinationRule \"(none)\" specifies that mTLS must be false but the Policy object \"default\" specifies Strict.",
                "origin": "MeshPolicy default"
        }
]
Error: Analyzer found issues.

@selmanj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.4
11f1d4cf03d31b7b0fe18f070d6a2db910f97b2e
link
/test lint_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Ah dang, apparently the config output change has some linter issues. The fix is here:
https://github.com/istio/istio/pull/19137
but it's huge and certainly wont apply cleanly. Should I manually fix them?

Also, note that there were more stylistic changes that I didn't include here that were applied to the analyzer. Should I pull those in too? They're not functionally required, but it'll make easier cherry-picks more likely to apply cleanly (at the expense of this PR getting bigger)

Unfairly assigning to @howardjohn since he left a single innocent comment on the mTLS PR, and is therefore an expert on the feature.

@selmanj this got delayed due to security release. Is this still up to date? Do we have the fixes for the excessive error messages from this analyzer? Should we be cherrypick new features to the analyzer given our docs encourage users to install from master anyways?

This doesn't contain those fixes, yet. I assumed #19360 was actually blocking this PR.
I'm working on adding public docs right now, which should close out #19360 and presumably unblock this PR. I'd like a chance to update this though so that it includes all the relevant fixes.
marking this WIP for now.

Lets push this in 1.5. This is to big a change for a patch release and 1.5 is coming in weeks


Update dash (3.2.3)

Changes to a cask
Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

You may wish to try cask-repair. It could really speed up these updates you’ve been making.

Thanks Vítor! I'm actually using my own modified version of cask-repair that conforms more to my workflow


Update leaflet-lasso description

Remove exaggeration

I still see "True .." here: https://zakjan.github.io/leaflet-lasso/

Right, thanks! Removed


animationstart hook not effective if lazy loaded

We are asynchronously loading, so the start event has already happened when the polyfill loads in Safari.
I tried various workarounds like waiting for the polyfill to load and switching from play state paused to running.. Perhaps completely not applying until then is an option, but that's tricky for authors.
My current workaround is to apply a data attribute to each element and once loaded query them all and call play on the animations. That does seem to work.

Turns out this is also a problem when we fetch remote stylesheets. The stylesheets themselves are already loaded, but the animationstart event we use to hook into it has already fired after we parse the stylesheets from fetch.

We can use document.getAnimations() and search for all running animations that are an instanceof CSSAnimation and upgrade them. This should handle animations which were already in progress when the polyfill sets up the animationstart listener.

I tested this out and that works except for the condition of them running. Most of them have a default duration of 1ms for it to work in Safari so the play-state was not set to running. Otherwise this works like a charm!

An alternate option would be to have a very small snippet that is run synchronously which simply collects a list of started animations and then passes them in to be set up by the polyfill after its loaded.

The syncronous snippet might be hard, we can't collect it immediately if say a framework like React mounts or re-renders and that triggers an animation after the snippet but before the polyfill is loaded (or remote stylesheets fetched and parsed). The forwards / both sounds promising. Would that be more effective over calling .play() on the animations when the polyfill initializes?

Would that be more effective over calling .play() on the animations when the polyfill initializes?

Yes! This should avoid any visible side effects. Finished animations will remain finished whereas calling play restarts them.

Let me give that a shot!

@flackr That's not working so well for us either. I guess since we put the 1ms duration for Firefox it's not firing animationstart even instrumented early. I've tried a few other things but nothing is sticking so far.


[DNM] ONLY REVERTED TO VIEW PREVIEW - Revert "Remove landlord-immigration-check SmartAnswer"

@1pretz1 - do we still need this? Also if you just need a preview link, you can log into Heroku and deploy a preview app with a branch instead of raising a PR

Hey @theseanything 👋 Sorry for the delayed response, have been on AL. I assume this is no longer needed as the preview isn't even available anymore. Cheers for flagging - I'll close it!


Hashing custom types

I still haven't sorted out the hashing problem. It seems that when there is a string inside the type Julia treats that differently.
immutable A
    a   ::  Int
    b   ::  Symbol
    c   ::  Symbol
end
a1 = A(1, :x, :a)
a2 = A(2, :y, :b)
a3 = A(1, :x, :a)
d = Dict()
d[a1] = 1
d[a2] = 2
d[a3] # => 1; works without even re-define hash/==/isequal

but
import Base.isequal, Base.==, Base.hash
immutable B
    s   ::  String
end
Base.isequal(b1::B, b2::B) = b1.s == b2.s
end
==(x::B, y::B) = isequal(x, y)
const _foo_seed = UInt === UInt64 ? 0x64c74221932dea5b : 0x80783eb4
Base.hash(b::B, h::UInt) = hash(b.s, h += _foo_seed)

b1 = B("1")
b2 = B("1")
d = Dict()
d[b1] = 1
d[b2] # => KeyError: key B("1") not found

doesn't work.

I think I was mislead by

New types should implement the 2-argument form, typically by calling the 2-argument hash method recursively in order to mix hashes of the contents with each other (and with h). (https://docs.julialang.org/en/stable/stdlib/base/?highlight=base.hash#Base.hash)

Actually implementing Base.hash(b::B, h::UInt) doesn't work but should just implement Base.hash(b::B).


RPC and JSON: support more System.Collections.Generic types

List<_>, HashSet<_>, Queue<_>, Stack<_>, LinkedList<_> should be serialized as JSON arrays.

I'm actually not sure if HashSet<_> should be handled by RPC, as it contains unserializable data (the hash function and the equality comparer). We could handle it assuming the default ones are being used, but it's error prone in other cases.

LinkedList<_> is also problematic for RPC from the client to the server. It's a self-referential type, which can't be directly passed to JSON.stringify. Custom JSON serialization is ok though.


Compiling with vibe.d 0.8.3 gives deprecation warning

mysql\pool.d line: 115 column: 13
The call to ConnectionPool's constructor must use a @safe callback.
Perhaps createConnection() can just be made @trusted?

Ping me on this once CI is fixed, we need to get these fixed. All my REST routes also need to be safe, and mysql-native in general doesn't make this easy.

Ok.
Previously, mysqln wasn't worrying too much about pure, safe and such for much the same reason - because vibe and phobos didnt make it very easy. Hopefully that's improved now.

Well, considering that vibe.d now requires @safe just about everything, I think it should work better now. And it makes sense too. The whole point of @safe is to fix internet exploits. What better place than a web server!

And for the record, I DON'T think a good solution is band-aiding @trusted on everything. I'm willing to put in some work to get this right. But of course, CI needs to work.

So I started working on this. And I get way way deep down into the nitty gritty of mysql-native. Almost everything is easy to mark with @safe except a few things.
First, there's a few places where TypeInfo objects are compared. Object.opEquals is not safe, so I had to make a trusted version of that. Not a huge deal.
The second is a lot harder. Variant's postblit is not safe. This is required, since any type can go in there. We really need a SafeVariant type. Really, that's how mysql should be by default, we don't need to support any types that aren't safe.
We could also use TaggedAlgebraic (probably TaggedUnion, as we don't need to be able to forward function calls). This would probably be an improvement anyway, as TaggedUnion provides a cleaner set of mechanisms for basically storing data.
Or we could make our own MysqlVariant type or something that only handles the types we care about. Might be slightly more performant than a Variant or TaggedUnion.
What do you think? I don't want to go any further without some guidance here.

Hmm, I seem to be a little out-of-date here, I’ve used TaggedAlgebraic in the past, but it seems there have been changes/enhancements since then, and TaggedUnion is new to me. I just took a quick look at the docs but I’m still a little unclear: What exactly is the difference between TaggedAlgebraic and  TaggedUnion.
In any case, if using Phobos Variant is fundamentally incompatible with proper @safety in mysqln, and  TaggedAlgebraic/TaggedUnion would work, then that sounds reasonable to me. Besides, I agree Variant’s API just isn’t as nice or as modern and it’s maybe more heavyweight than needed.
My only concerns:

Looking ahead, if we also want to get more up-to-speed with pure and const-ness, TaggedAlgebraic/TaggedUnion wouldn’t be any worse than than Variant would it? (Frankly, that would surprise me anyway, but I have to ask.)

How feasible would it be have a transition period where BOTH TaggedUnion and Variant are supported? Something like: Using Variant would simply mean they wouldn’t be getting @safe, but if they transition to the new TaggedUnion approach then they’d get @safe? If it isn’t feasible, then that still isn’t necessarily a deal-breaker, but it would be a BIG help if we could avoid breaking peoples codebases, and let them smoothly transition their codebases gradually.

I’ve been away from this a little too long, but as I recall, there’s some stuff where Nullable is combined with Variant to mean certain things. Like distinguishing “no rows/values were received” vs “actually received a row/value and the value is null”  (or...something like that…) Things like that. Would a TaggedUnion approach still be fully compatible with this stuff?

As for a “MysqlVariant” type, I would tend to shy away from inventing our own algebraic/tagged union type unless there was a very clear, specific reason why existing options weren’t sufficient and we knew we could do better. And even then, I’d still prefer to have it as an external general-purpose lib rather than having it built-into mysql-native.

Hmm, I seem to be a little out-of-date here, I’ve used TaggedAlgebraic in the past, but it seems there have been changes/enhancements since then, and TaggedUnion is new to me. I just took a quick look at the docs but I’m still a little unclear: What exactly is the difference between TaggedAlgebraic and TaggedUnion.

I've honestly not used either, but I think the difference that I can see is that TaggedUnion does not forward function calls, and has some different APIs. It appears to me that TaggedUnion is more suited for just storing and retrieving a union item. Whereas TaggedAlgebraic tries to provide a seamless API for all functionality of the union members.
In my brief test for this (to see if it forwards @safety, it does), TaggedUnion didn't work for calling functions.

In any case, if using Phobos Variant is fundamentally incompatible with proper @safety in mysqln, and TaggedAlgebraic/TaggedUnion would work, then that sounds reasonable to me. Besides, I agree Variant’s API just isn’t as nice or as modern and it’s maybe more heavyweight than needed.

It might be easy to get a SafeVariant into Phobos, I'm actually surprised it's not there. I think it literally needs a copy-paste of VariantN but with @safe tagged at the top.

My only concerns:

Looking ahead, if we also want to get more up-to-speed with pure and const-ness, TaggedAlgebraic/TaggedUnion wouldn’t be any worse than than Variant would it? (Frankly, that would surprise me anyway, but I have to ask.)

Yes, TaggedUnion would be much more conducive to other attributes, as it's a fully templated call instead of a generated delegate.

How feasible would it be have a transition period where BOTH TaggedUnion and Variant are supported? Something like: Using Variant would simply mean they wouldn’t be getting @safe, but if they transition to the new TaggedUnion approach then they’d get @safe? If it isn’t feasible, then that still isn’t necessarily a deal-breaker, but it would be a BIG help if we could avoid breaking peoples codebases, and let them smoothly transition their codebases gradually.

It would be pretty simple, except for cases where mysql-native's functions are returning Variant. These would be harder to manage, because you can't call an overloaded function based on the expected return value. For sure, the API calls you would make on the return types are much different.
I'll have to look through the code and see how many of these there are. Perhaps it's not that bad.

I’ve been away from this a little too long, but as I recall, there’s some stuff where Nullable is combined with Variant to mean certain things. Like distinguishing “no rows/values were received” vs “actually received a row/value and the value is null”  (or...something like that…) Things like that. Would a TaggedUnion approach still be fully compatible with this stuff?

I'm not sure about this one. I'm sure I can come up with something that works. You definitely can have a TaggedUnion where one of the items is typeof(null).

As for a “MysqlVariant” type, I would tend to shy away from inventing our own algebraic/tagged union type unless there was a very clear, specific reason why existing options weren’t sufficient and we knew we could do better. And even then, I’d still prefer to have it as an external general-purpose lib rather than having it built-into mysql-native.

I agree, but I wanted to throw it out as a possible option. One possible benefit is that we could define specialized functions on such a thing.

I'll have to look through the code and see how many of these there are. Perhaps it's not that bad.

OK, so here are the places we would have to worry about this:

Prepared's arguments all are implemented with variant. I think we might be able to upgrade the argument setting mechanism at the same time as we are adding @safe, so this may not be an issue.
Row values. This is the trickiest one. I can't think of a better API than opIndex, so replacing the return type there would be disruptive. One thing we could do is add a property to get the "safe" row (which would be the actual implementation):

struct Row
{
  ...
  SafeRow safe() { return actualRow; }
}

Then you would use it like:
auto id = row.safe[id].value!int;

Not sure if we can deprecate the API completely, and replace it with the safe stuff, which sucks.
We could intercept at the Range call, returning a safe Range instead of the normal range.

Some of the query calls return Variant or Row, which would need equivalents for the safe versions.

Ok, so it looks like there aren't too terribly many places. So, what if we do it like this:

In version A, we add all our safe non-Variant overloads, we add Row.safe as you describe, and for the problematic query calls we name the new ones querySafe, queryRowSafe, etc. In this same version, we mark all of the Variant-using versions with the deprecated keyword (don't get me started on that "scheduled for deprecation" goofiness...) with a deprecation message about how the function's API will change in the future and they should migrate to the safe non-Variant versions to be ready.

After a certain amount of time, in some later version B, instead of outright deleting the deprecated Variant-based functions, we just delete their bodies and re-use their names for the safe non-Variant versions (ie, we rename querySafe to query, SafeRow to Row, etc...). We also remove the deprecated keywords. We keep querySafe/Row.safe/SafeRow/etc as optional (non-deprecated for now) aliases. Anyone who hasn't transitioned away from Variants will simply start getting type errors instead of the nice deprecation messages.

Later on, version C, we deprecate the now-redundant querySafe/Row.safe aliases. Eventually maybe remove them in a version D...or maybe not (at that point it won't really matter too much anyway).

OK, I'll start on an implementation using this idea. We'll see how it goes.

Got stuck on an issue, but so far, I think replacing Variant will be a net benefit. Issue is here: https://github.com/s-ludwig/taggedalgebraic/issues/36

@Abscissa getting back onto this, have a bit of time during Thanksgiving since I'm sick and home alone at the moment. I had a question on this code here: https://github.com/mysql-d/mysql-native/blob/master/source/mysql/protocol/comms.d#L127
I'm basically going to recreate this switch for converting existing Variant to new MySQL tagged algebraic type. But I don't have any support for shared(immutable(... types. I'm wondering, is this a real issue? I can't imagine you put it in there without it actually coming up, but it seems kind of strange to have that be a real use case. First of all, shared(immutable(x)) is kind of strange, because immutable is automatically shared. But if you had a pointer to it, it's possible the pointer is shared, but the target is immutable?
Some guidance on this would be good, I don't love the idea of supporting shared in MySQL in any case, as the multi-threading implications are murky. Given how Walter is going to remove all usage of shared data without a cast in a very community-supported DIP, it might not make any sense to support shared at all.
My plan at the moment is to simply cast away the shared, as the pointer itself is not really shared (inside the Variant, it's locked away, and we are about to make a copy of it anyway).
In any case, a history of how that got there would be useful.

OK, doing some testing I've determined that what that switch does doesn't actually work. At all:
immutable int x = 5;
Variant v = &x;
const(int)*p = v.get!(const(int)*); // error, incompatible types

So, I'm not as worried ;)

FYI still working on this, haven't tested, but I have something that builds. See https://github.com/schveiguy/mysql-native/tree/safeupdate.
I need to get rid of all the deprecations (internal non-safe calls), and then work on the tests.

Cool.
IIRC, I don't think the "shared immutable" stuff was one of the changes I made. It's possible it might even predate my involvement in the project. So I'm not really sure what the story is there, I'd have to find the commit/pr that introduced it. (I do know it wasn't an especially recent addition, its been in there awhile.) My suspicion is it was probably added together with the "const" and "immutable" cases just as an attempt to be more permissive in what types could be passed in.

/facepalm  So much for my memory! It WAS me who added that shared immutable stuff, and less than two years ago, even:
https://github.com/mysql-d/mysql-native/issues/13
With that in mind, I do know I didn't have a specific situation in mind, it was just an attempt to be more permissive. So no worries about nixing that.

More updates: I've decided on a different "radical" approach than what we discussed. I can always move back if necessary.
I found that I can mimic pretty much all of Variant's features with TaggedAlgebraic (it really is a nifty library). So I'm comfortable with doing the reverse of what was discussed -- by default everything will now be safe, and if you want unsafe Variant code, you will use either a new (and deprecated) function asVariant which will convert the safe type to a Variant, or you can use unsafe accessors in the row and range to get a version that converts to Variant. So this will provide code that doesn't explicitly type anything as Variant with (I hope) drop-in compatibility. For that case, you can call the stop-gap items mentioned above until you can fix your code.
This is a lot better than what I originally hoped. What tipped the scales for me was that queryValue returns Nullable!Variant. It was going to be very painful to switch this and keep compatibility.

We'd also want to be sure to minimize disruptions to user code that SENDS a Variant to mysqln, not just user code that  RECIEVES a Variant. So maybe also a fromVariant or asMySqlVal and/or  overloads that still accept a Variant FROM the user, to go along with your asVariant.
Also, at this point, if we're offering functionality that converts to/from Variant, do we really even need to use deprecations to make users change their own code to use MySqlVal directly? Maybe we could just leave asVariant/asMySqlVal un-deprecated, and if a user would rather base their own code around Variant and deal with occasional conversions when accessing mysqln and doesnt care about their own code being @safe, then so be it.
Other than that, it all sounds good to me.

The calls that accept Variant are all still there and overloaded. The ones that accept Variant are marekd @system and deprecated. I'm working on getting the tests to build, then I'll push what I have.

And I do have a Variant -> MySQLVal conversion there, but I don't want to necessarily expose it as public. It's used internally for all the places where Variant is accepted.

OK, I have updated my branch it's now building tests (haven't run them properly yet). I am waiting on a PR pull for taggedalgebraic, which I very much need to get this to work properly: https://github.com/s-ludwig/taggedalgebraic/pull/40
Going to bed... If I get a chance this weekend, I might do final testing and make a PR. But we still need the taggedalgebraic fix.

So I have got the tests to build and pass. Still waiting on the TA bug fix.
But I realize something that may be a problem with the idea of making MySQLVal the default. Consider code like this:
auto row = mysql.queryRow(sql);
Variant v = row[0];
if(v != 1) launchMissles();

This compiles with the new system! What happens is Variant wraps the MySQLVal (something that wouldn't happen in reverse). I think what will happen is that it fails to run the opCmp, but the message will be pretty confusing.
I may have to go back to the original plan of making everything Variant and deprecated by default, and then you have to access the new system via safe accessors.

See my PR at #214

I can close this now. Please let me know if you find any issues with the latest rev.


[Feature Request] Support Subfolders

Hey, I think it would be great if Whiteout could handle IMAP subfolders. Right now every folder is treated as is was on the same level.
Thanks for considering my suggestion!

do you have a suggestions how to make this happen for both touch and pointer input?

I'm not a programmer so unfortunately I cannot contribute anything on coding level. But every modern email web interface and every andvanced Android email app can handle subfolders. You maybe wanna check out R2Mail2, an Android email app, which can handle PGP encryption, but also most regular email features, i.e. subfolders as well.
I guess the easier approach (actually more like a workaround) would be to name subfolders "main folder/subfolder1/subfolder1.1", instead of just "subfolder1.1".
The more sophisticated approach would be to just showing collapsed folders and expanding them when the user is clicking/tapping on them. I don't see why there should be a difference in the UI between touching and pointing.
Or did I get you completely wrong?

my 2 cents:
expand collapse subfolders needs a ui element for interaction, which might be really tiny for pointer, but comparatively large for touch. touch also has very limited screen real estate, so that's not an option.
what we could do is visual demarcation of subfolders.
also order them by path, not by name. that is entirely possible, though. i wonder why i didn't do that in the first place :+1:
https://github.com/whiteout-io/mail-html5/blob/master/src/js/email/email.js#L1186

alright, with https://github.com/whiteout-io/mail-html5/commit/39d19df187f2cf96ed363758bbfd9d198a640a7a folders will now be ordered according to their path, not their name.

R2Mail2 handles collapsing/expanding with a little + or - symbol. I only have a touch device and I find it neither too big or too small. I don't think there would be any issues with a pointer device.
Thanks for implementing a solution so quickly! Maybe a possible approach would be to expand everything (kind of like it is right now) but indent subfolders a bit to the right?


Fix ldconfig issue since https://svnweb.freebsd.org/ports?view=revi…

…sion&revision=469956 commit on freebsd ports repository.

version v2.05 released.


add rainofsnow english

I added rainofsnow. I only realized til afterwords that apparently NovelUpdates has some parsing logic for this site, but I still think it would be nice to have as it is one of my favorite sites.
One issue I was having was when I would test the scraper using npm start and when I would parse a Novel's chapters, I would have a link that looks like this:
https://rainofsnow.com/chapters/missing-fiance-ch1/?novelid=61402
npm says I cant have the full link here, so i slice it off with ?.slice(novelPath.length); and get 'chapters/missing-fiance-ch1/?novelid=61402' which testing this with 'Parse Chapter' crashes the proxy with 'Invalid URL' but if I use the full link, it works perfectly fine... but then the test site complains that it needs to be relative. Though, no combination of the url segments work except for the full URL. Im a Golang dev so this is a little foreign to me to begin with, but this was a little baffling to me.
side note: I also meant to ask how hosting my own repository would work? I try to add a repository URL in 'settings > repositories > add repo' but it returns invalid no matter what. What exactly is it asking for here? what does the git repo structure supposed to be like? I can write some docs on this if I can figure it out. Thanks for the awesome application.

LNReader tacks on this.site for every link, so you can do .slice(this.site.length) when inserting into the db
To host your own repo, run npm run host-windows or npm run host-linux then take the raw link of dist/plugins.min.json inside the plugins branch that gets created on your repo

Thats what I had figured. The thing that was throwing me for a loop was that the test site would work for parsing the popular page and for "Search" using .slice(this.site.length) but using that URL slug would cause an error when trying to parse the chapters contents. Im not sure exactly why, but it was only working with the full URL. It would crash the test proxy server with ERR_INVALID_URL so I was at a loss.
I end up getting this:
[1]   code: 'ERR_INVALID_URL',
[1]   input: 'chapters/reaper-c3/?novelid=61654'
[1] npm run proxy exited with code 1

Hi thank for your contributing.
To be clear: App doesnt store full url, because if the domain get changed users data would be lost.
So you just need to do this.site + chapter Path in parse chapter to get full url.
Also you could use earlynovel (en) as reference for implementing a site have paged chapters

Thanks! I'll work on that, make sure its working correctly, and amend the PR sometime tomorrow.

Alright, everything is working well. The plugin type is now correct, it can parse pagination without an issue, along with everything else. I tested the resulting chapter HTML in my browser and it looks good as well (though I am not familiar with how that is rendered in the app). I also cleaned things up a bit.


⚠ Fortnite has degraded performance

In 305128f, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1590 ms

Resolved: Fortnite performance has improved in 259f3e1.


exp claim in header rather than body ?

Have had great success using this library with angular-jwt... until attempting to implement client side token expiry notifications...
the angular-jwt module has a function to check if a token is expired, it is looking in the JWT body for the exp claim - however it appears flask-jwt is writing the exp and iat to the JWT header by default?
Am I doing something wrong? or should the exp and iat be contained within the body?
Any help would be great, thanks!

Have managed to work around this by placing the exp formatted as time since epoch in the payload of the token.
It is not well documented but I believe the representation of dates in a JWT should be time since epoch...
There may be a better way of accomplishing this but the following is what I am using
@jwt.payload_handler
def make_payload(user):
    expiry = (datetime.now() - datetime.fromtimestamp(0)) + app.config['JWT_EXPIRATION_DELTA']
    return {
        'user_id': user.id,
        'exp': int(expiry.total_seconds())
            }

Hey @harmon25 , this isn't a Flask-JWT issue, but rather the underlying itsdangerous library. I ran into the same problem you did, but I'm using Satellizr
This issue is documented here: https://github.com/mitsuhiko/itsdangerous/pull/19
I think I had basically the same workaround, but I also added an iat tag.
iat = calendar.timegm(datetime.utcnow().timetuple())
exp = calendar.timegm((datetime.utcnow() + current_app.config['JWT_EXPIRATION_DELTA']).timetuple())
return {
    'user_id': user.id,
    'iat': iat,
    'exp': exp
}

thanks joshi for confirming that for me, had a hunch it was related to itsdangerous.
Your solution is a bit more elegant than mine, will likely implement the kludge that way :+1:


ci: change labels to match the OS version

orka is deprecated in favour of macos<version>

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-09-06T14:03:31.647+0000

Duration: 8 min 20 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
919

Skipped
6

Total
925

Steps errors
Expand to view the steps failures

Running Go tests

Took 0 min 21 sec . View more details here
Description: gotestsum --format testname --junitfile junit-report.xml -- -v ./...

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


creat model

What is the reason for this error when constructing the model?
Thank you

Keras does not support TF 2.0

What can I do?


Source folder is incorrect causing an error when building on linux

Hi, I'm getting an error when using this plugin in a linux machine. The folder in the plugin.xml has the wrong case causing an issue.

but the folder containing the src is all lower case src/android/stripegooglepay.
Would be possible to fix this issue?
Thank you.

@sergioltg This plugin has only tested on OSX.


Can the Project summary and WIKI be copied using Demo generator (i have readme file in repo with some URL details, will this be copied)

Can this be achieved in an automated manner

@shobanadevops1 this can be achieved, however Demo Generator is already covering the part of it. It can import the repository into new project on behalf of you (required necessary permissions), later it can be published as wiki.


Feature apps from database table

To create an app from command line:
php artisan websockets:app:create
To manage all existing apps, use the web panel from your browser:
/laravel-websockets/admin

this is great feature... please merge it :)

Until this has been merged or if you want to do it in Nova you can use this package
https://packagist.org/packages/vemcogroup/nova-websockets

Sorry about my question, but, until this commits are merged and released with the official composer package, how could I use this great piece of software with my current composer installed package of laravel-websockets?
I mean, what is the more correct way to achieve this?

You can use my fork in your composer.json (as local package), but without 5.8 support.

Ok, thanks @masterix21.
I will try that way.

@masterix21 Can you rebase?

@masterix21 I assume you need to update your fork's master branch with the current one.


failed at the end

almost convertetd the whole ebook...but right at the end
100%|███████████████████████████████████████████████████████████████████████████████████| 49/49 [11:29<00:00, 14.07s/it]
Replacing silences longer than one second with one second of silence (myepub-21.flac)
100%|█████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 53.75it/s]
99.46% spoken so far.
Elapsed: 388 minutes, ETA: 2 minutes
0%|                                                                                | 0/2 [00:00<?, ?it/s]Error: You need to define either text (for sythesis) or a reference_wav (for voice conversion) to use the Coqui TTS API. ... Retrying (1 retries left)
Error: You need to define either text (for sythesis) or a reference_wav (for voice conversion) to use the Coqui TTS API. ... Retrying (0 retries left)
Something is wrong with the audio (97): temp0.wav
0%|                                                                                | 0/2 [00:00<?, ?it/s]
Traceback (most recent call last):
File "/home/jk/epub2tts/epub2tts.py", line 665, in
main()
File "/home/jk/epub2tts/epub2tts.py", line 654, in main
mybook.read_book(
File "/home/jk/epub2tts/epub2tts.py", line 446, in read_book
temp = AudioSegment.from_wav(tempwav)
File "/home/jk/.local/lib/python3.10/site-packages/pydub/audio_segment.py", line 808, in from_wav
return cls.from_file(file, 'wav', parameters=parameters)
File "/home/jk/.local/lib/python3.10/site-packages/pydub/audio_segment.py", line 651, in from_file
file, close_file = _fd_or_path_or_tempfile(file, 'rb', tempfile=False)
File "/home/jk/.local/lib/python3.10/site-packages/pydub/utils.py", line 60, in _fd_or_path_or_tempfile
fd = open(fd, mode=mode)
FileNotFoundError: [Errno 2] No such file or directory: 'temp0.wav'
I tried to run it again...and it finds all them fragments...but fails again at the very end
...
Elapsed: 0 minutes, ETA: 0 minutes
myepub-19.flac exists, skipping to next chapter
92.35% spoken so far.
Elapsed: 0 minutes, ETA: 0 minutes
myepub-20.flac exists, skipping to next chapter
93.56% spoken so far.
Elapsed: 0 minutes, ETA: 0 minutes
myepub-21.flac exists, skipping to next chapter
99.46% spoken so far.
Elapsed: 0 minutes, ETA: 0 minutes
0%|                                                                                | 0/2 [00:00<?, ?it/s]Error: You need to define either text (for sythesis) or a reference_wav (for voice conversion) to use the Coqui TTS API. ... Retrying (1 retries left)
Error: You need to define either text (for sythesis) or a reference_wav (for voice conversion) to use the Coqui TTS API. ... Retrying (0 retries left)
0%|                                                                                | 0/2 [00:00<?, ?it/s]
Traceback (most recent call last):
File "/home/jk/epub2tts/epub2tts.py", line 665, in
main()
File "/home/jk/epub2tts/epub2tts.py", line 654, in main
mybook.read_book(
File "/home/jk/epub2tts/epub2tts.py", line 443, in read_book
f"Something is wrong with the audio ({ratio}): {tempwav}"
UnboundLocalError: local variable 'ratio' referenced before assignment

myepub.epub.txt
here the epub remove the ending for reference

This looks a lot like https://github.com/aedocw/epub2tts/issues/133, which we were not able to reliably reproduce.
Could you try re-running by this time add "--minratio 0 --debug" - this will skip the part where it uses whisper to transcribe the audio file and try to compare that to the original text. It might still fail, but it might fail in a different way this time.

nope same...
python3 /home/jk/epub2tts/epub2tts.py ~/epubconvert/myepub.epub --engine xtts --speaker "Badr Odhiambo" --minratio 0 --debug
myepub-20.flac exists, skipping to next chapter
93.56% spoken so far.
Elapsed: 0 minutes, ETA: 0 minutes
myepub-21.flac exists, skipping to next chapter
99.46% spoken so far.
Elapsed: 0 minutes, ETA: 0 minutes
0%|                                                                                | 0/2 [00:00<?, ?it/s]text to read:
Error: You need to define either text (for sythesis) or a reference_wav (for voice conversion) to use the Coqui TTS API. ... Retrying (1 retries left)
text to read:
Error: You need to define either text (for sythesis) or a reference_wav (for voice conversion) to use the Coqui TTS API. ... Retrying (0 retries left)
0%|                                                                                | 0/2 [00:00<?, ?it/s]
Traceback (most recent call last):
File "/home/jk/epub2tts/epub2tts.py", line 681, in
main()
File "/home/jk/epub2tts/epub2tts.py", line 670, in main
mybook.read_book(
File "/home/jk/epub2tts/epub2tts.py", line 456, in read_book
f"Something is wrong with the audio ({ratio}): {tempwav}"
UnboundLocalError: local variable 'ratio' referenced before assignment

Weird! Ok could you try one more thing, delete the file myepub-21.flac and
run again, see what happens? I’ll try with the epub you shared when I get
to a computer later today.
On Tue, Jan 2, 2024 at 2:16 PM rejuce @.***> wrote:

nope same...
python3 /home/jk/epub2tts/epub2tts.py ~/epubconvert/myepub.epub --engine
xtts --speaker "Badr Odhiambo" --minratio 0 --debug
myepub-20.flac exists, skipping to next chapter
93.56% spoken so far.
Elapsed: 0 minutes, ETA: 0 minutes
myepub-21.flac exists, skipping to next chapter
99.46% spoken so far.
Elapsed: 0 minutes, ETA: 0 minutes
0%| | 0/2 [00:00<?, ?it/s]text to read:
Error: You need to define either text (for sythesis) or a reference_wav
(for voice conversion) to use the Coqui TTS API. ... Retrying (1 retries
left)
text to read:
Error: You need to define either text (for sythesis) or a reference_wav
(for voice conversion) to use the Coqui TTS API. ... Retrying (0 retries
left)
0%| | 0/2 [00:00<?, ?it/s]
Traceback (most recent call last):
File "/home/jk/epub2tts/epub2tts.py", line 681, in
main()
File "/home/jk/epub2tts/epub2tts.py", line 670, in main
mybook.read_book(
File "/home/jk/epub2tts/epub2tts.py", line 456, in read_book
f"Something is wrong with the audio ({ratio}): {tempwav}"
UnboundLocalError: local variable 'ratio' referenced before assignment
—
Reply to this email directly, view it on GitHub
https://github.com/aedocw/epub2tts/issues/152#issuecomment-1874631418,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFBJGJEWNV4GT2R6Y2UE3TYMSBNHAVCNFSM6AAAAABBKKY742VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZUGYZTCNBRHA
.
You are receiving this because you commented.Message ID:
@.***>

Found it! Somehow a completely empty item ends up in the list of sentences to speak. Then TTS chokes when it tries to do something with it (which is pretty reasonable). Adding a test that skips that loop if the length of that sentence is 0 fixes this. I'm pretty certain this was what happened with https://github.com/aedocw/epub2tts/issues/133 as well.
Tested the fix, and will be merging it shortly.

Just got the same error on a free epub book using the Docker image.
Book can be found at https://www.epubbooks.com/book/1445-sandi-the-kingmaker
Direct link to book download: https://www.epubbooks.com/downloads/5b7bc7f0-cb22-4fd4-b924-a5a176cbed90/file


Event handling methods shall be named "OnXyz"

Each event handling method shall follow the scheme:
OnXyz() where Xyz is the name of the event.

Consider special handling for PropertyChanged and PropertyChanging events.

Another proposal:
Name methods OnBlaXyz where Bla is the name of the class/interface (without leading I in case of interfae) and Xyz is the name of the event.
Example: OnProjectManagerProjectChanged


Get adopted by Wikimedia

Think about it. This project has everything to do with the Wikimedia family, and full integration with it would be very benefitial to both.
Wikivoyage, if I recall correctly, was adopted by Wikimedia upon request. Maybe that would be a good option for lib.reviews as well.

Unfortunately, the project would likely be considered out of scope, since it is neither educational nor wiki-based:
https://meta.wikimedia.org/wiki/Mission
I've been focusing instead on re-cultivating http://wiki.freeculture.org/Main_Page as an incubation space for free culture projects and activities.
That said, I definitely want to make sure there are strong bridges to relevant free culture projects including Wikimedia and OpenStreetMap, and have reached out to the Wikivoyage and OSM communities.


[Question] Is it possible to deply Access node on one virtual machine and data nodes on different nodes ?

Have a look at Troubleshooting or some Common Issues

Questiong
Is it possible to have a multinode setup using helm charts, where the Access node is on one virtual machine and data nodes on different nodes?
To Reproduce
With existing commands, all pods are created on the same node\machine.
Expected behavior
On installation, access node should get deployed on virtual machine \ Node and data nodes on other virtual machines?
Deployment

helm default value.yaml file
pg12.5-ts2.0.0-p0
minikube

Deployment
Linux Kubernetes

Multinode helm chart is deprecated and not supported anymore. If you want to see this chart supported then we are looking for community maintainers - https://github.com/timescale/helm-charts/tree/master/charts/timescaledb-multinode#call-for-maintainers


Docs2

[x] closes #162, #205
[x] tests added / passed
[x] docs reflect changes
[x] passes flake8 datafs examples tests docs
[x] whatsnew entry

Documentation added for tagging, finding archives. Documentation has been tested with clatter.
https://github.com/ClimateImpactLab/impactlab_user/issues/35

We need to merge in the updates from rmdir and this will pass

Coverage remained the same at 96.39% when pulling b92e6f15da3cd48317cd37de49d0bab5ce915ad5 on docs2 into 81ab9b42fa7961f5e20729cb3999d7f6de266ea3 on master.


Deployment check crashes

I haven't been able to find the exact crash, but it is clear that the deployment checker sometimes crashes, leaving pods around.  Here are other checks that all indicate this is happening:

the leftover pods from it:

I've added some == nil checks throughout the deployment check code to hopefully prevent future crashes: https://github.com/Comcast/kuberhealthy/commit/f9f976c9a2866e695cdbfe6a48f1f87ae9aa3665
Hopefully this will help

These seem to be okay right now - moving to the 2.1.0 milestone.  KH2 leaves pods around longer, so we may be able to get a log on the crash.

I've also added a catch incase panics occur -- these should be reported to KH2.

this is looking good in image 1.0.2 so far I think

I was able to capture a failure in the logs tonight!

time="2019-11-18T08:40:52Z" level=error msg="Failed to create daemon set:DaemonSet.apps \"daemonset-test-kuberhealthy-56f6fd8745-fc726-daemonset-1574066447\" is invalid: [metadata.labels: Invalid value: \"daemonset-test-kuberhealthy-56f6fd8745-fc726-daemonset-1574066447\": must be no more than 63 characters, spec.selector.matchLabels: Invalid value: \"daemonset-test-kuberhealthy-56f6fd8745-fc726-daemonset-1574066447\": must be no more than 63 characters, spec.template.labels: Invalid value: \"daemonset-test-kuberhealthy-56f6fd8745-fc726-daemonset-1574066447\": must be no more than 63 characters]"

Looks like the daemonset is making pods with names that are too long.  Perhaps shorten the prefix of the ds test pods @joshulyne ?


login page

form should contain

[ ]  input btn
[ ] username
[ ] password
[ ] redirecting button

h


Lists Overlapping [Bug]

Describe the bug
When collapsing a list, lists now overlap with each other. I assume this is due to Trello's new "create card from template" function.
To Reproduce
Steps to reproduce the behavior:

Collapse List in a multi-list board.
There you go, problem.

Expected behavior
Lists are neatly lines up next to each other, not overlapping.
Screenshots

Browser details

OS: Windows 7 x64
Operta
63.0.3368.107
5.17.5

Additional context
Did not occur before Trello updated with a "create from template" icon, so I'm assuming that's the cause of the issue.

...Well, this is strange. I refreshing the page with an errant keystroke and the bug appears to no longer be occurring. The list collapses just fine now, without the icon causing overlap, despite a refesh not having fixed the issue previously. Huh. If the bug cannot be reproduced at this point, I suppose this can be closed without further comment. My apologies.

This was fixed earlier today :)

I'm so fast! :D
Thank for report and replay :)


name 'text' is not defined

/app/app.py:68: UserWarning: name 'text' is not defined
https://github.com/openchatai/OpenCopilot/blob/ee47f1d40ed9489b31912fc80416fc7b09fde33e/llm-server/app.py#L66

Hey @go-laoji ,
There was an issue with the last pr. I have raised a fix. Will merge it soon.
You can view the changeset here
https://github.com/openchatai/OpenCopilot/pull/86

This has been fixed in the latest release. @go-laoji please take a pull from main


z -

Hello, how can I alias z - to cd - ? thanks

How about something like this?
z_cd() {
	if [[ "$1" == "-" ]]; then
		cd -
	else
		z $@
	fi
}

alias z='z_cd'

it's works. :smiley:
thank you!


Different timestamps for Oxford dataset when generating submaps

Hi, thanks for your great work! I am trying to use the script generate_submaps.m to recreate the benchmark dataset for the Oxford Robotcar dataset. However, I seem to get different pointclouds (as described by the timestamps) than the ones found in the uploaded benchmarks folder on google drive.
For example, for the 2015-08-17-10-26-38 folder, the<PHONE_NUMBER>060497.bin pointcloud cannot be found after generating the submaps, with the closest generated timestamps being:<PHONE_NUMBER>982745.bin and<PHONE_NUMBER>699224.bin.
There is some overlap between the generated and posted pointclouds for the same 2015-08-17-10-26-38 folder, such as:<PHONE_NUMBER>022188.bin  and<PHONE_NUMBER>723175.bin.
I have not modified the uploaded script except for path changes, and am using the default values for the following parameters:
submap_cover_distance=20.
laser_reading_distance=0.025;
laser_reading_angle=30;
dist_start_next_frame=10.0;

Are there any parameter changes that need to be made to get the generated timestamps & pointclouds to correspond? Thank you!

Hi,
I apologize for the late response. If I remember correctly, those were the parameters I used to generate the submaps. I am also not sure why you get a different timestamp. Sorry about that if this doesn't help.
Best,
Mika


Adding Chat With your Data

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.
If you are submitting a new azd template to the gallery
Fill this out if you want your template to be added to the awesome-azd gallery!
Your template repository
Place your template repository link here: https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator

[ ] Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

[ ] Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

[ ] Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

[ ] Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

[ ] Link to Author's GitHub or other relevant website - Used for attribution

[ ] Author's Name -  Name to credit on the gallery card

[ ] Link to template source - Link to the template GitHub repo

[ ] Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!
Required tags:

[x] Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
[x] Tag the IaC provider ("bicep" or "terraform")
[x] At least 1 tag for programming language used
[x] At least 1 tag for Azure services integrated
[ ] Add the "new" tag for any newly authored templates

[ ] In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

If you are submitting a resource to be added to the awesome-azd README:

[ ] Name of resource
[ ] Resource author - who created this resource? (so we can credit them!)
[ ] What section should this resource be included in? -Is the resource an article? A video? Something else?

The current .devcontainer.json will not automatically open in vscode as it should not be prefixed with a .
I also wonder why this devcontainer has docker-in-docker configured? You are not using docker for anything that I can see

@hemarina - We tested this template according to it's README and everything works fine.


wide_string: we check using method nil? instead of null?

Signed-off-by: Felipe Balbi<EMAIL_ADDRESS>

Hi! Thanks for finding the project and wanting to help!
It's been a while since I used this project, but as I remember I needed to specifically check for a null FFI::Pointer (documentation). This check ignores that possibility - is that deliberate?


feat(*) add datadog-rum

Summary
This PR introduces datadog rum which will allow us better track user behavior/problems which they encounter.
Also small cleanup of env variables.

Is this opt-in?

Coming from community call notes as context: can we revert this PR until we discuss it further in the community, or at least block any release from including this?

The goal with this PR is to make sure that we collect a statistically quantifiable amount of interactions with the GUI in order to (a) improve the GUI and understand how it is being used (b) collect frontend errors in order to fix them across the variety of configurations that the user will be using (browsers, their versions, etc).
This PR does not provide any other benefit, but giving us a chance to make the product better. As such I suggest that we should definitely provide an explicit way to disable the feature, while at the same time make sure that we don't collect any personal information. Datadog offers the option to stop collecting IP addresses, which really is the only identifiable bit of information we can collect (since the GUI doesn't have any signup/registration).
Per Datadog's website:

Note: By default, Datadog stores the client IP address. If you want to stop collecting IP addresses, contact Support. This does not impact the collection of geolocation attributes listed above.

Of course, we could also not collect any data whatsoever, but that will leave us in the dark when it comes to products improvements that are derived from real usage.

@austince for now the PR was reverted in #211


Some emails coming through with headers in content, leading to parse failures

Emails and names redacted for privacy.
[ Fragment {
    _content: '',
    _isHidden: true,
    _isSignature: false,
    _isQuoted: false },
  Fragment {
    _content: 'From: Tom <tom@redacted>\nSubject: Re: [LIST] Subject line\nDate: Tue, 11 Jul 2017 21:43:36 GMT\nTo: Mailing List <list@redacted>\n\nwut\n',
    _isHidden: true,
    _isSignature: false,
    _isQuoted: true },
  Fragment {
    _content: 'On Tue, Jul 11, 2017 at 11:43 PM, Tom <tom@redacted> wrote:\n\n> always be knolling!\n>\n> On Tue, Jul 11, 2017 at 11:40 PM, Fred <\n> list@redacted> wrote:\n>\n>> _______________________________________________\n>> LIST mailing list\n>> list@redacted\n>> https://link/to/list\n>>\n>>\n>> ---------- Forwarded message ----------\n>> From: Fred <list@elsewhere>\n>> To: Mailing List <list@redacted>\n>> Cc:\n>> Bcc:\n>> Date: Tue, 11 Jul 2017 23:41:52 +0200\n>> Subject: Subject line\n>>\n>> We had some e-mail issues lately, mostly due to misconfiguration.\n>>\n>> If any list email lands in your spam folder, please report it.\n>>\n>> Thanks.\n>>\n>>\n>',
    _isHidden: true,
    _isSignature: false,
    _isQuoted: true },
  Fragment {
    _content: '',
    _isHidden: true,
    _isSignature: false,
    _isQuoted: false },
  Fragment {
    _content: '_______________________________________________\n LIST mailing list\nlist@redacted\nhttps://link/to/list\n',
    _isHidden: true,
    _isSignature: true,
    _isQuoted: false } ]

Here's what the email bot got:

Full .eml available in private location.

TravisR: We have configured mailman to wrap the sender's e-mail into a new one as a message/RFC822 attachement.
A
TravisR: That was the only way to pass valid DKIM and DMARC signatures and not end up as spam with gmail.


Issue cross-compiling Vim on MacOS

I'm trying to use MacOS to cross-compile Vim for another platform (specifically, SerenityOS).
It seems even with --disable-darwin, the configure script is setting MACOS_X=yes, which is causing compilation to fail because my target compiler doesn't recognize the various MacOS-specific definitions:
fileio.c: In function 'vim_fsync':
fileio.c:2940:19: error: 'F_FULLFSYNC' undeclared (first use in this function)
 2940 |     r = fcntl(fd, F_FULLFSYNC);
      |                   ^~~~~~~~~~~

Is there another option available in the configure script that will allow me to properly spoof the target platform so I can cross-compile?

My current workaround is to just entirely skip this if clause:
https://github.com/vim/vim/blob/ef082e12df2cafe177b2ac9f6922393223ccf83b/src/configure.ac#L182-L185
That definitely doesn't seem like the Correct thing to do, but :shrug:

I'm not familiar with cross-compiling.  Perhaps we should allow setting the output of "uname"?  When not set then the actual output of uname would be used.

That sounds like it could work. I'm also not that familiar with how other projects allow for cross-compilation. Maybe there's inspiration to be gathered from elsewhere, like ncurses for instance


Error: [introspection-engine\connectors\sql-introspection-connector\src\introspection_helpers.rs:188:64] called Option::unwrap() on a None value

Command: prisma introspect
Version: 2.21.2
Binary Version: e421996c87d5f3c8f7eeadd502d4ad402c89464d
Report: https://prisma-errors.netlify.app/report/13277
OS: x64 win32 10.0.19041
JS Stacktrace:
Error: [introspection-engine\connectors\sql-introspection-connector\src\introspection_helpers.rs:188:64] called `Option::unwrap()` on a `None` value
    at ChildProcess.<anonymous> (<...>\backend\node_modules\prisma\build\index.js:39953:28)
    at ChildProcess.emit (events.js:315:20)
    at ChildProcess.EventEmitter.emit (domain.js:467:12)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)

Rust Stacktrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: <unknown>
  16: <unknown>
  17: <unknown>
  18: <unknown>
  19: <unknown>
  20: <unknown>
  21: <unknown>
  22: <unknown>
  23: <unknown>
  24: <unknown>
  25: <unknown>
  26: <unknown>
  27: BaseThreadInitThunk
  28: RtlUserThreadStart

This is kind of hard to debug without having an SQL dump of the database. I wrote by hand the datamodel from the schema JSON, migrated it to the Windows version of MariaDB (10.3) and introspection ran just fine. It probably is something about case-sensitivity here, but without having the SQL dump this cannot be reproduced.

https://github.com/prisma/prisma/issues/6738

Hi there,
As part of our effort to clean up our GitHub repo, we’re closing this issue to help focus on features and improvements that align with our focus areas and those of our community.
This issue was originally created for internal tracking purposes, but if you feel this is important to you, feel free to reopen the issue and get like-minded users to upvote as we will prioritize fixing issues based on community interest.
For more insight into our priorities and how we’re thinking about the future of Prisma, please see our blog post: https://www.prisma.io/blog/prisma-orm-manifesto.
Thank you for your understanding and support!


Serializing bigint value to JSON emits incorrect JSON

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
PS> $i = [bigint]"93839802329326"
PS> $obj = @{"val" = $i}
PS> ConvertTo-Json $obj

{
    "val":  {
                "IsPowerOfTwo":  false,
                "IsZero":  false,
                "IsOne":  false,
                "IsEven":  true,
                "Sign":  1
            }
}

Note that casting the variable inline as [int64] does work correctly:
PS> $i = [bigint]"93839802329326"
PS> $obj = @{"val" = [int64]$i}
PS> ConvertTo-Json $obj
{
    "val":<PHONE_NUMBER>9326
}

and casting the variable inline as [bigint] does not:
PS> $i = [bigint]"93839802329326"
PS> $obj = @{"val" = [bigint]$i}
PS> ConvertTo-Json $obj
{
  "val": {
    "IsPowerOfTwo": false,
    "IsZero": false,
    "IsOne": false,
    "IsEven": true,
    "Sign": 1
  }
}

Expected behavior
{
    "val":<PHONE_NUMBER>9326
}

Actual behavior
{
    "val":  {
                "IsPowerOfTwo":  false,
                "IsZero":  false,
                "IsOne":  false,
                "IsEven":  true,
                "Sign":  1
            }
}

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.4.0
PSEdition                      Core
GitCommitId                    7.4.0
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

Good point, but your issue is a duplicate of the following one (which fell victim to the dreaded "Resolution-No Activity" bot-assigned label and - often inappropriate - associated automatic closure):

#9207

I guess this needs some authoritive answer as to what should happen here. I see two valid options to go with:
1. Serialize to the raw number (my vote)
[System.Numerics.BigInteger]::new("9223372036854775808") | ConvertTo-Json
#<PHONE_NUMBER>854775808

This would technically be a breaking change as now the properties are no longer serialized so the output is different but it does mirror how such a value is deserialized making it roundtrippable. While a breaking change I feel like the chances of people relying on such a format is minimal as it's mostly useless today and even if they do really want it they can create such an object manually before serialization.
# BigInteger
('9223372036854775808' | ConvertFrom-Json).GetType()

2. Add a Value key to the output
[System.Numerics.BigInteger]::new("9223372036854775808") | ConvertTo-Json
# {
#   "IsPowerOfTwo": true,
#   "IsZero": false,
#   "IsOne": false,
#   "IsEven": true,
#   "Sign": 1,
#   "Value":<PHONE_NUMBER>854775808
# }

This is backwards compatible as we only have an extra property. We do run the risk if BigInteger ever adds a Value property itself or if someone has added this as an ETS property.
I'm happy to implement the fix but we would need an answer from the working group as to what route to go with before I do the work.

I think serialising to the value itself (option 1) makes the most sense because it's consistent with behaviour in other number scenarios. I was quite confused with the output and was fortunate to find some clues here.
While technically a breaking change, given that the value itself is missing I would guess that there aren't many hard dependencies on those properties today. Consequently, I think the most likely scenario is deserialising stored JSON that has inadvertently  included the current structure. Biginteger cannot be round tripped at all so this is more a .NET runtime bug.
// See https://aka.ms/new-console-template for more information
using System.Numerics;
using System.Text.Json;

var val = new Val
{
    BigInt = new BigInteger(179032540293482304),
    Long =<PHONE_NUMBER>3456346
};

var json = JsonSerializer.Serialize(val);
Console.WriteLine(JsonSerializer.Serialize(val));

var obj = JsonSerializer.Deserialize<Val>(json);
Console.WriteLine($"{obj.BigInt} {obj.Long}");

public class Val
{
    public BigInteger BigInt { get; set; }
    public long Long { get; set; }
}

Output:
{"BigInt":{"IsPowerOfTwo":false,"IsZero":false,"IsOne":false,"IsEven":true,"Sign":1},"Long":41555532453456346}
0<PHONE_NUMBER>3456346

@rifuller, note that it isn't System.Text.Json that underlies the PowerShell cmdlets, but third-party library Json.NET.
The PowerShell cmdlets already support deserializing arbitrarily large integer values (see below), so it makes sense to also serialize them as such.
# Existing support for *deserializing* large integer values:

# Too big to be [Int64] ->
# [bigint] in PS Core, [decimal] in WinPS
('10000000000000000000' | ConvertFrom-Json).GetType().Name

# Too big to be [decimal] ->
# [bigint] in PS Core, [double] in WinPS
('100000000000000000000000000000' | ConvertFrom-Json).GetType().Name

As an aside: note the difference in types chosen between Windows PowerShell and PowerShell Core.
While there can generally be no expectation of round-tripping - given that the specific original number type isn't recorded on to-JSON conversion - on deserialization it would arguably have made more sense to go from Int64 -> Decimal -> BigInteger, instead of going straight from Int64 to BigInteger.

As an aside, re a potential .NET bug: System.Text.Json by design doesn't support [bigint] (the largest supported type capable of storing integers accurately is [decimal]), but allows implementing custom converters to handler arbitrary types.

I wanted to see if it was actually possible in the first place to do option 1 and opened https://github.com/PowerShell/PowerShell/pull/21000. It is possible so just waiting to see what the WG says about this option.

I wanted to see if it was actually possible in the first place to do option 1 and opened #21000. It is possible so just waiting to see what the WG says about this option.

Oh, thanks for putting up a PR. I'm working around my issue by hard casting it so I'll just keep an eye on my Github emails for any updates.