Update aws-core, http-client-spi, ... to 2.17.138

Updates

software.amazon.awssdk:aws-core
software.amazon.awssdk:http-client-spi
software.amazon.awssdk:netty-nio-client

from 2.17.130 to 2.17.138.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #728.


Properties: added string for "Cancel" button

Fixes #1861

@XPoppyX It looks like there a couple of merge conflicts, would you mind resolving them so we can merge your pull request?


uniforms

So far (taken from MC ogl command list):

[x] glGetUniformLocation
[ ] glUniform1i
[ ] glUniformMatrix4fv
[ ] glUniform4fv
[ ] glUniform1fv

You should probably create a new test for this in main.cpp so if there are any regressions on glGetUniformBlockIndex they are not missed.
But it looks like you have the spirv_resources_list search method figured out.

Global uniforms for some reason are not included in the spirv list. Need to figure that one out

@darkaegisagain is this correct?
For some reason the buffer is always null.
void mglUniform1i(GLMContext ctx, GLint location, GLint v0)
{
    Program* ptr = ctx->state.program;

    ERROR_CHECK_RETURN(ptr, GL_INVALID_OPERATION)

    Buffer *buf = ctx->state.buffer_base[SPVC_RESOURCE_TYPE_UNIFORM_BUFFER].buffers[location].buf;

    if(buf == NULL)
    {
        ERROR_RETURN(GL_INVALID_OPERATION);
    }
    initBufferData(ctx, buf, sizeof v0, &v0);
}

You would have to start by checking where
Buffer *buf = ctx->state.buffer_base[SPVC_RESOURCE_TYPE_UNIFORM_BUFFER].buffers[location].buf;

Is assigned…
Mike

On Aug 20, 2022, at 10:15 AM, r58Playz @.***> wrote:
@darkaegisagain https://github.com/darkaegisagain is this correct?
For some reason the buffer is always null.
void mglUniform1i(GLMContext ctx, GLint location, GLint v0)
{
Program* ptr = ctx->state.program;
ERROR_CHECK_RETURN(ptr, GL_INVALID_OPERATION)

Buffer *buf = ctx->state.buffer_base[SPVC_RESOURCE_TYPE_UNIFORM_BUFFER].buffers[location].buf;

if(buf == NULL)
{
    ERROR_RETURN(GL_INVALID_OPERATION);
}
initBufferData(ctx, buf, sizeof v0, &v0);

}
—
Reply to this email directly, view it on GitHub https://github.com/openglonmetal/MGL/pull/51#issuecomment-1221370248, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOKD35VIULKAF35CBEEQ5DV2EHEVANCNFSM57CLQ5KA.
You are receiving this because you were mentioned.

Got over that obstacle, but now the logs are getting spammed.
GL Error func: -[MGLRenderer mapGLBuffersToMTLBufferMap:stage:] type: 1282
failure -[MGLRenderer processGLState:]:2446
failure -[MGLRenderer mtlDrawArrays:mode:first:count:]:3354
GL Error func: -[MGLRenderer mapGLBuffersToMTLBufferMap:stage:] type: 1282
failure -[MGLRenderer processGLState:]:2446
failure -[MGLRenderer mtlDrawArrays:mode:first:count:]:3354
GL Error func: -[MGLRenderer mapGLBuffersToMTLBufferMap:stage:] type: 1282
failure -[MGLRenderer processGLState:]:2446
failure -[MGLRenderer mtlDrawArrays:mode:first:count:]:3354

Uniforms work now. simple fix: used the wrong array index (had to use _UNIFORM_BUFFER instead of SPVC_RESOURCE_TYPE_UNIFORM_BUFFER)
test_draw_arrays

test_draw_arrays_uniform

Now all I have to do is figure out global uniforms... why is it not in the list...

Doh…
Good job, glad to see you figured it out.
Mike

On Aug 20, 2022, at 1:39 PM, r58Playz @.***> wrote:
Uniforms work now. simple fix: used the wrong array index (had to use _UNIFORM_BUFFER instead of SPVC_RESOURCE_TYPE_UNIFORM_BUFFER)
test_draw_arrays
https://user-images.githubusercontent.com/45221816/185765165-dfbe5da3-0659-4aab-86a8-95b8fd90f9c9.png
test_draw_arrays_uniform
https://user-images.githubusercontent.com/45221816/185765188-c471af43-7aeb-4552-824a-08aa3f5984a4.png
—
Reply to this email directly, view it on GitHub https://github.com/openglonmetal/MGL/pull/51#issuecomment-1221404807, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOKD33EM46EOTTKKHEYOG3V2E667ANCNFSM57CLQ5KA.
You are receiving this because you were mentioned.

shader:
    #version 450 core\n
    layout(location = 0) in vec3 position;\n
    layout(location = 1) uniform int mp = 1;\n
    void main() {\n
      gl_Position = vec4(position*mp, 1.0);\n
    }

I am really stumped on this one. Somehow a uniform constant buffer is getting deallocated and causing an EXC_BAD_ACCESS.
I narrowed it down to this code that sets the buffer for uniform constants.
    if(buf == NULL)
    {
        ctx->state.buffer_base[_UNIFORM_CONSTANT].buffers[location].buf = newBuffer(ctx, GL_UNIFORM_BUFFER, location);
        buf = ctx->state.buffer_base[_UNIFORM_CONSTANT].buffers[location].buf;
    }

Without API Validation:

With API Validation:
-[MTLDebugRenderCommandEncoder setVertexBuffer:offset:atIndex:]:1683: failed assertion `Set Vertex Buffer Validation
buffer is not a MTLBuffer.

Global uniforms for some reason are not included in the spirv list. Need to figure that one out

Hi @r58Playz , this makes me think of a note I have in my wiki:

there is no support for single global uniforms, you must use UBOs. This is a limitation of the glslang compiler, there is an option to support them, but I could not make it work, supposedly vulkan only (see GL_EXT_vulkan_glsl_relaxed extension)

Could it be related to this problem?

Global uniforms for some reason are not included in the spirv list. Need to figure that one out

Hi @r58Playz , this makes me think of a note I have in my wiki:
* there is no support for single global uniforms, you must use UBOs. This is a limitation of the glslang compiler, there is an option to support them, but I could not make it work, supposedly vulkan only (see [GL_EXT_vulkan_glsl_relaxed](https://github.com/KhronosGroup/GLSL/blob/master/extensions/ext/GL_EXT_vulkan_glsl_relaxed.txt) extension)

Could it be related to this problem?

Technically the glslang compiler has support for single global uniforms, it even passes it on to the MSL compiler, but the MSL compiler wasn't sending it as part of the spirv resource list. I added that in https://github.com/r58Playz/SPIRV-Cross/tree/uniform-constants.

Fixed (had to set the mtl data to null every time i dealloc)
https://user-images.githubusercontent.com/45221816/187114460-934af601-fc81-4261-8a81-5d255553e5ab.mov


Web - LHN - Pinned conversation in offline jumps after returning online

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
Navigate to a conversation that is not near the top on the LHN list
Disable the internet connection
Click on the pin icon on the top right
Verify the conversation is now pinned to the top of LHN
Refresh the page
Enable the internet connection - you might need to refresh the page in Web
Verify the conversation is still pinned to the top of LHN (maintaining the same pinned status)

Expected Result:
The conversation is still pinned to the top of LHN
Actual Result:
Pinned conversation in offline jumps after returning online
Workaround:
Unknwn
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] We / Chrome

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/211177743-49ecd83d-9490-479b-87f0-b05e6b841b23.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Interna Team
Slack conversation:
View all open jobs on GitHub

will look into this tomorrow

Hmm, I wasn't able to reproduce this on v1.2.52-4 - @kbecciv I've followed your reproduction steps but I don't think this is reproducible? Closing but reopen if you think I'm wrong!

Issue is not reproductible any more.
https://user-images.githubusercontent.com/93399543/213007599-d6337881-3f50-4391-ad23-9fd33663a5b2.mp4


add version commands

Implement version command for rekor-cli and rekor-server. Close #212.
I'm submitting this PR as a Draft, to present a solution for feedback.
The version package contains hard-coded version string; is then imported in rekor-cli and rekor-server, and the hard coded string is replaced at build time using the -X ldflags option.
I'm using internal to conform to https://github.com/golang-standards/project-layout#internal, as the version package is not expected to be used externally.
The version format is <version> (from commit <commit hash>[-dirty]).

<version> defaults to main and is by default overridden by the current branch name. It can be overridden manually by setting VERSION environment variable.
<commit hash> is the hash of the last commit in the git history the build is being run from.
[-dirty] is added if the current folder is in a dirty state (based on git status --porcelain).

The result (taken from this branch) is:
$ ./rekor-cli version
add-version-subcommand (from commit 856f681-dirty)

$ ./rekor-server version
add-version-subcommand (from commit 856f681-dirty)

This version number allows to distribute any built binary from any branch with relevant information for testing.
Feedback welcome!

I think this was added in this PR https://github.com/sigstore/rekor/pull/304
@bobcallaway can you confirm?

I think this was added in this PR #304
@bobcallaway can you confirm?

yes, it was (in a way consistent with the same approach done in cosign). Apologies @endorama ... I should have tagged this PR when I started looking into it.

ok, lets close this.


Add assets for new wireframes

Please add fonts, colour code and illustrations to assets folder in wireframes.

i'd like to work on this !


UI design

I am doing the Android UI ?

Why has this been closed? There haven't been any documents uploaded. No pull requests. Did you mean to put this in "In progress"

I don't know what's going on, I came here to push stuff. I genuinely don't know what's going man. Please message me if I close or blocked anything. It's never my intention

Ow now I remember, I pressed "close issue" thinking it will close this interface and take me back to the parent interface. Like moving out of a directory "cd.."


Slider value_changed event not fired during mouse_move.

Calling impl_->set_slider_pos(arg.pos); in nana::drawerbase::slider::trigger::mouse_move alters the behavior. But I'm not sure if this is the right fix.

Pressing ESC key before mouse_up should revert the value.
Maybe adding value_changing event may help.


Add examples for kubectl describe, make gendocs less spammy

Added examples to kubectl describe and modified  hack/{run/verify}-gendocs.sh to ignore generated-timestamp-only changes so minor edits to kubectl code don't have to touch the entire set of md docs.

cc @eparis, @filbranden for bash

Looks good for bash! Thanks for addressing the items in the review! :-)
Let me know if you'd like me to merge it or if you have other reviewers in mind or are still running some extra tests to ensure this actually does what it states.
Cheers,
Filipe

Thanks for helping fix my dreadful bash. This should be good to merge now, but also fine to label lgtm and merge later.

Always happy to help!
LGTM, feel free to self merge or have some other eyes take a look on it if you'd like.
Cheers,
Filipe


Log configuration of the Gradle Remote cache node

Issue type
Missing information
Problem description
Information are missing concerning the log configuration of the Gradle Cache node.
I'm searching a way to change the static configuration of the log which create a "node.log" file with "INFO" level.
The current doc page only describe the location of the log files:
https://docs.gradle.com/build-cache-node/#logging
In a container context deployment, we should be able to change the log to stdout/console appender and to change log level.
Configuration by environment variable would be perfect.

Is there a repo to contribute on this?

Context (optional)
No response
Page with the problem
https://docs.gradle.com/build-cache-node/#logging

Thank you for your interest in Gradle!
This issue needs a decision from the Develocity team. They have been informed. Response time may vary.

Hello @sebastienmoreno.
For recently released versions of the BCN it is possible to redirect all output to stdout by passing the CLI argument --inline-logs. Note that support for this argument is subject to change in future versions.
At what granularity are you interested in modifying the log level?

Thanks @sebastienmoreno for confirming that it works.
We'll consider the inclusion of the --inline-logs argument in the public documentation in an upcoming release.
Concerning modifying the log levels, this would require a change to the logging subsystem to cater to that configuration use-case. Unfortunately it's not currently something that can be done "globally" at this time, nor can we commit to supporting this feature at this time.
The default log verbosity is what it is today to assist support teams with troubleshooting BCN deployments.


server: add the initial version of the container measurement

update the ccnp-server.proto, add container_id for containers and optional parameters.
add container measurement in the CCNP service.
update the SDK of CCNP

@hjh189 please update the tests later according to the new container measurement.


Added id param to panel error text and updated js for inpagelink

Issue with errors where the first checkbox or radio was being focussed when an error link is clicked.
There was no other element to attach an id to.

Added a param to the error macro to allow id to be added to the error text element.
If a matching ID is added to an error panel link it will jump to the error text.

So we can see it working I think the example prototype might need updating


Port additional ingress test cases to v2_validation folder

@sangeethah : Please find all the updated ingress tests and related files in v2_validation folder

LGTM


Dependencies

Update CodeIgniter and Sass

Closing — CodeIgniter 4.1.6 on hold. Awaiting merge of https://github.com/codeigniter4/CodeIgniter4/pull/5531


Can not set placeholder when selection is active

Hey guys,
It's possible to include a new option in the ui-select-match to set the placeholder when there is some selected elements? Today the placeholder is set only when no element was selected. This way I can show some message to indicate to the user that he needs to click in the select to be able to add new elements.
Here is one example of what I'm looking for:

I made this change in my fork (https://github.com/marianafranco/ui-select) where I created a new option "placeholder-active" for this, but it'll be nice to have this in the official repo.

Might be worth submitting a PR so the code can be reviewed more easily.
I'm interested in something like this.

OK, will prepare a PR. First I want to try to make select2 and selectize themes works with this new "placeholder-active" option ;)

Here are the PR: https://github.com/angular-ui/ui-select/pull/774

Hi, I think this issue can be closed as the PR is closed. If needed people can have a look at the PR you made to make a custom version of it.
Thanks.


non found root project.

Task uploadToAppSweepRelease not found in root project 'My Project' and its subprojects.

Let me know if i should put more details about this issue??

Hey @youndon,
you can run ./gradlew tasks --group=AppSweep which will list you all possible gradle tasks to upload one of the different builds of your app.
If this does not show up anything, the appsweep plugin is not loaded.
But more likely is that your app has a different buildvariant or flavor, so the task is just named differently.

Yes I tried you suggestion and it did work fine.
Interesting 🤔, But what this mean now?

./gradlew tasks --group=AppSweep should list all the AppSweep-tasks you can call. I would suspect there is one similar to uploadToAppSweepRelease in there, so you can just call ./gradlew uploadToAppSweep...


Retire feedback script

SVUnit has been around for a long time and is already at version 3. Feedback is still welcome, but it should not have to be actively requested anymore.

Duplicates #125


New Features, Whisper And Vanish

I think these features would be really nice if they were added
Whisper, where somebody can use /whisper [discord nickname/name (with or without numbers idk)] [message] and the bot dm's the discord user the message, and the discord user can do the same thing back to the player.
Vanish, where somebody simply does /chatvanish and it hides there messages from discord but still shows them online in tab and !list
Also make /commands because normal commands removed soon...

Also make /commands because normal commands removed soon...

This is a misleading statement. Discord is not "removing" normal commands, but instead making it a privileged intent for Discord bots in over 75 servers.


MatDialog open method R generic is too loose

Because the R generic on MatDialog.open isn't constrained by arguments to the function, it's effectively always any. We should remove the method generic and change the return generic to {}, which will force people to explicitly state which type it is when consuming it.

The reason R defaults to any was to avoid breaking changes at the time we introduced the argument.

The issue is not with 'any', but with allowing R to be unsafely inferred to be anything. For example, the following always compiles.
let ref: MatDialogRef<T, SomeMadeUpType> = open(...);
It looks like any other code where the function call returned some type, but the developer choose to write it out for clarity.
By forcing the developer to write let ref = open() as MatDialogRef<T, SomeMadeUpType>; it becomes clear that this is an unsafe cast.

It would be nice if the type of R could be inferred from the type of Component being passed into open().

The only type safe thing would be if the dialog and it's return value would be passed around.
Currently the dialog caller has to declare some return value and some input variables and the dialog does the same thing in reverse (declaring input types and having output variables)

Whilst I'm not entirely certain if the best default should be unknown, {} or void. I did notice that as well and since then I am using patch-package to replace in<EMAIL_ADDRESS>-export declare class MatDialogRef<T, R = any> {
+export declare class MatDialogRef<T, R = void> {

Also check out a proposed workaround for a similar type issue https://github.com/angular/components/issues/24538#issuecomment-1732644192.
Maybe it can be made official and fix both issues at once?


GDScript Texture Import Causes Crashing in Godot v4.0

Godot version:
v4.0.dev.calinou.5953f4d76
OS/device including version:
Macbook Pro 16" (2019), MacOS Big Sur v11.2.2, AMD Radeon Pro 5500M (Vulkan) if graphics-related. -->
Issue description:

set up a button to import texture to 3D model
works the first time
on the second time clicking the button and importing a texture the test crashes and outputs this in the debug:

...and an aside...not sure if this is linked or not... but in my main scene I keep getting this error if I'm in the 2D window:

This 2nd error seems to happen because I haven't set my Control2D nodes to be larger than 0,0 initially, which i do later with code. This error didn't happen in Godot 3.3
Steps to reproduce:
I've attached a file that reproduces the main error (not the aside).
This error does not occur in Godot v3.3 with the same setup.
Minimal reproduction project:
11_TextureTest.zip

...and an aside...not sure if this is linked or not... but in my main scene I keep getting this error if I'm in the 2D window:

This error spam is a known issue (which needs to be fixed on our end), see https://github.com/godotengine/godot/issues/45911 and https://github.com/godotengine/godot/issues/45746.

Seems fixed in alpha 8, can someone confirm? Not sure how to test it.


Update yakt.sh

Reworked and Improved Script
Description:

Added a write() function to handle file writes more robustly.
Enhanced logging with timestamps for better error tracking.
Organized and cleaned up the code for readability.
Created a dedicated directory for error log files inside main yakt MODDIR.
Improved error handling with informative messages.
Simplified file path checking and handling.

These changes make the script more reliable, easier to maintain, and provide better feedback in case of errors.
Contributor: @CRANKV2

Thank you.
I will review it later.

Great!
Feel free to rework all like u want, hope it still helps 😁

@CRANKV2 What's ur GitHub email?

@CRANKV2 i commited has myself for now until u gave me ur email to author you, thank you for your contribution.

@CRANKV2 i commited has myself for now until u gave me ur email to author you, thank you for your contribution.

<EMAIL_ADDRESS>

I didn't merge cause I didn't accepted it fully so I just committed and authored you here: https://github.com/NotZeetaa/YAKT/commit/72a5e12a6e52d58b4761efd992a9030e1a583723

I didn't merge cause I didn't accepted it fully so I just committed and authored you here: https://github.com/NotZeetaa/YAKT/commit/72a5e12a6e52d58b4761efd992a9030e1a583723
Thank you for your contribution

All good, as long it helps, I'm glad to help, thats one of my favorite projects 😁


Require swift_in_compiler in dist. ownership verify sil

Commit 5bc036661c60 introduced changes to
distributed_id_system_ownership_verify_sil.swift that don't work unless you have SwiftCompilerSources enabled. Gating test on that.

@swift-ci please smoke test


Fix transforms

0.1.1 (2018-10-21)
Fixed Bugs:

Fixed issue with node transforms and node animations, where the glTF node transform would get applied on top of its animation, causing incorrect positions.

Changes:

Convert usd file path to absolute path on load
Reformatted changelog
Switched some methods to properties
Increment version

@kcoley Well done. I reverted back to the older version the past couple weeks because I was having  less  animation problems than with the newer version. But now your fixed some of these animation issues I will go back to new version & test it out again for any animation bugs.


How to use in something like a Sidekiq worker?

I have tried adding require 'configurable_engine'
to:
config/application.rb
config/initializers/sidekiq.rb
and
app/workers/something_worker.rb

My error (in spelling)


ng update: unable to get local issuer certificate error during update

Versions
Angular CLI: 6.0.0
Node: 10.0.0
OS: win32 x64
Angular: 5.2.10
... animations, common, compiler, compiler-cli, core
... forms, http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.0
@angular-devkit/core              0.6.0
@angular-devkit/schematics        0.6.0
@angular/cdk                      5.2.5
@angular/cli                      6.0.0
@angular/material                 5.2.5
@schematics/angular               0.6.0
@schematics/update                0.6.0
rxjs                              5.5.10
typescript                        2.6.2

NPM: 6.0.0
Yarn: 1.6.0
Repro steps

Run ng update @angular/cli or simply ng update.

Observed behavior
An error occurs with message:
unable to get local issuer certificate

Desired behavior

Expected to update @angular/cli as denoted in instructions to upgrade from 5.2.10 to 6.0.0 on update.angular.io
Mention any other details that might be useful (optional)
Both yarn and npm have strict-ssl set to false in the config. It seems that CLI is not using the config of the package managers when fetching the new dependencies during update.
This happens in a corporate environment when behind a Self Signed Root CA (MITM of all TLS traffic).

Duplicate of #10596


Gitoxide for performance improvements

This is a very first preview of what it would mean to use gitoxide for commit-traversal alone, done with the smallest possible changes for everything to remain as familiar as possible. It ain't super pretty yet, but it will get there. My rough plan is to get feedback early and ultimately squash all/most commits once a merge is possible.
Furthermore I think a delayed progress bar could easily be implemented to provide some entertainment while people are waiting for their huge repositories (those will never finish below 1s no matter how hard we try 😅).
Right now it's 2.2x faster on reactos and 2.4x faster on the linux kernel at 4% the heap memory consumption compared to what's on main.
I am looking forward to your feedback.

Tasks

[x] git-mailmap
[x] initial use of gitoxide for commit graph traversal
[x] avoid allocating all commits and avoid string-duplication in Sig
[x] Use gitoxide in all possible places to validate the API is en-par with git2 or more convenient

configuration access and worktree-status is still done by git2, but we are working on it, this should be ready this year.

[x] figure out why contributor count is off by 2 (is it correct now, or not anymore?)

The actual issue was related to whitespace around names, which was fixed in gitoxide - libgit2 automatically trimmed names and emails, and this is now done by gitoxide as well. While looking into this I discovered that it's more in line with the intention of mailmap to provide a mapped email address if the case is different as well - previously this had to be specifically configured. In practice, this isn't happening, leading to people like Valdis Kletnieks to be counted 5 times. Additionally it's now unifying contributors by their mapped email address only, not email + name, which leads to 3000 less contributors in the linux kernel for instance. I have manually checked these lists as diff of a debug file, here is the code to make it

diff --git a/src/info/repo.rs b/src/info/repo.rs
index ec58856..fb77960 100644
--- a/src/info/repo.rs
+++ b/src/info/repo.rs
@@ -141,6 +141,15 @@ impl<'a> Repo<'a> {
             b_count.cmp(a_count).then_with(|| sa.name.cmp(&sb.name))
         });

+        {
+            use std::io::Write;
+            let mut buf = Vec::new();
+            for (sig, num) in &authors_by_number_of_commits {
+                writeln!(&mut buf, "{} <{}> {}", sig.name, sig.email, num).unwrap();
+            }
+            std::fs::write("dbg.txt", &buf).unwrap();
+        }
+
         let authors: Vec<Author> = authors_by_number_of_commits
             .into_iter()
             .map(|(author, author_nbr_of_commits)| {

[x] basic parallelization
…what about progress ❓
when ready for merge: release gitoxide and switch to using crates.io

Performance

e3b29b0aee7391baa39f613aa8798b0c137e386a - commit traversal with gitoxide

reactos - 1.492 s → 1.040 s = 1.43x
linux v5.16 - 19.634 s → 10.886 s = 1.80x, 1.47 GB → 1.18 GB peak mem = 0.8x

0652bbeb488c51243aa3a2283dc0bc6994a4f37b - minimize allocations

reactos -  986.2 ms → 915.4 ms = 1.08x
linux v5.15 -  11.313 s → 9.670 s = 1.17x,  1180 MB → 62 MB peak mem = 0.05x

633f0ce6cad0a664e764627b3f193aa59eb212a6 - parallelize workspace status, tokei, and commit traversal

reactos -  915.4 ms → 703.7 ms = 1.30x
linux v5.15 -  9.670 s → 8.070 s = 1.20x

Performance comparison with main

reactos -  1.492 s → 703.7 ms = 2.12x
linux v5.15 -  19.634 s → 8.070 s = 2.43x,  1470 MB → 62 MB peak mem = 0.04x

On 633f0ce6cad0a664e764627b3f193aa59eb212a6
reactos
➜  reactos git:(master) hyperfine ~/dev/github.com/o2sh/onefetch/target/release/onefetch
Benchmark 1: /Users/byron/dev/github.com/o2sh/onefetch/target/release/onefetch
  Time (mean ± σ):     703.7 ms ±  54.6 ms    [User: 2148.3 ms, System: 526.4 ms]
  Range (min … max):   605.4 ms … 814.1 ms    10 runs

linux v5.16
➜  linux git:(df0cc57e057f) ✗ hyperfine ~/dev/github.com/o2sh/onefetch/target/release/onefetch
Benchmark 1: /Users/byron/dev/github.com/o2sh/onefetch/target/release/onefetch
  Time (mean ± σ):      8.070 s ±  0.139 s    [User: 12.196 s, System: 1.909 s]
  Range (min … max):    7.900 s …  8.314 s    10 runs

On 0652bbeb488c51243aa3a2283dc0bc6994a4f37b
reactos
➜  reactos git:(master) hyperfine onefetch ~/dev/github.com/o2sh/onefetch/target/release/onefetch
Benchmark 1: onefetch
  Time (mean ± σ):     986.2 ms ±   9.9 ms    [User: 2120.3 ms, System: 618.4 ms]
  Range (min … max):   976.1 ms … 1003.5 ms    10 runs

Benchmark 2: /Users/byron/dev/github.com/o2sh/onefetch/target/release/onefetch
  Time (mean ± σ):     915.4 ms ±  19.5 ms    [User: 2062.3 ms, System: 578.8 ms]
  Range (min … max):   902.2 ms … 966.8 ms    10 runs

Summary
  '/Users/byron/dev/github.com/o2sh/onefetch/target/release/onefetch' ran
    1.08 ± 0.03 times faster than 'onefetch'

** linux**
➜  linux git:(df0cc57e057f) ✗ hyperfine onefetch ~/dev/github.com/o2sh/onefetch/target/release/onefetch
Benchmark 1: onefetch
  Time (mean ± σ):     11.313 s ±  0.193 s    [User: 13.065 s, System: 2.030 s]
  Range (min … max):   10.997 s … 11.572 s    10 runs

Benchmark 2: /Users/byron/dev/github.com/o2sh/onefetch/target/release/onefetch
  Time (mean ± σ):      9.670 s ±  0.118 s    [User: 12.319 s, System: 1.782 s]
  Range (min … max):    9.482 s …  9.835 s    10 runs

Summary
  '/Users/byron/dev/github.com/o2sh/onefetch/target/release/onefetch' ran
    1.17 ± 0.02 times faster than 'onefetch'

➜  linux git:(df0cc57e057f) ✗ /usr/bin/time -lp /Users/byron/dev/github.com/o2sh/onefetch/target/release/onefetch
                 ++++++                    Sebastian Thiel ~ git version 2.32.0 (Apple Git-132)
              ++++++++++++                 ----------------------------------------------------
          ++++++++++++++++++++             Project: linux (1 branch, 735 tags)
       ++++++++++++++++++++++++++          HEAD: df0cc57 (linux-checkout-4)
    ++++++++++++++++++++++++++++++++       Pending: 13+- 13-
 +++++++++++++************+++++++++++++    Version: v5.17-rc7
+++++++++++******************++++++++;;;   Created: 7 years ago
+++++++++**********************++;;;;;;;   Languages:
++++++++*********++++++******;;;;;;;;;;;              ● C (99.0 %) ● Shell (0.5 %)
+++++++********++++++++++**;;;;;;;;;;;;;              ● Python (0.2 %) ● Perl (0.2 %)
+++++++*******+++++++++;;;;;;;;;;;;;;;;;              ● Assembly (0.0 %) ● C++ (0.0 %)
+++++++******+++++++;;;;;;;;;;;;;;;;;;;;              ● Other (0.0 %)
+++++++*******+++:::::;;;;;;;;;;;;;;;;;;   Authors: 3% Linus Torvalds 30365
+++++++********::::::::::**;;;;;;;;;;;;;            1% David S. Miller 13285
++++++++*********::::::******;;;;;;;;;;;            1% Arnd Bergmann 8636
++++++:::**********************::;;;;;;;   Last change: 2 months ago
+++::::::::******************::::::::;;;   Contributors: 31713
 :::::::::::::************:::::::::::::    Repo: https://github.com/torvalds/linux
    ::::::::::::::::::::::::::::::::       Commits: 1060298
       ::::::::::::::::::::::::::          Lines of code: 16026142
          ::::::::::::::::::::             Size: 1.02 GiB (74304 files)
              ::::::::::::
                 ::::::

real 9.51
user 12.18
sys 2.00
           868958208  maximum resident set size
                   0  average shared memory size
                   0  average unshared data size
                   0  average unshared stack size
               73721  page reclaims
                   1  page faults
                   0  swaps
                   0  block input operations
                   0  block output operations
                   0  messages sent
                   0  messages received
                   0  signals received
                   6  voluntary context switches
               23996  involuntary context switches
<PHONE_NUMBER>21  instructions retired
<PHONE_NUMBER>9  cycles elapsed
            62381056  peak memory footprint
➜  linux git:(df0cc57e057f) ✗ /usr/bin/time -lp onefetch
                 ++++++                    Sebastian Thiel ~ git version 2.32.0 (Apple Git-132)
              ++++++++++++                 ----------------------------------------------------
          ++++++++++++++++++++             Project: linux (1 branch, 735 tags)
       ++++++++++++++++++++++++++          HEAD: df0cc57 (linux-checkout-4)
    ++++++++++++++++++++++++++++++++       Pending: 13+- 13-
 +++++++++++++************+++++++++++++    Version: v5.17-rc7
+++++++++++******************++++++++;;;   Created: 7 years ago
+++++++++**********************++;;;;;;;   Languages:
++++++++*********++++++******;;;;;;;;;;;              ● C (99.0 %) ● Shell (0.5 %)
+++++++********++++++++++**;;;;;;;;;;;;;              ● Python (0.2 %) ● Perl (0.2 %)
+++++++*******+++++++++;;;;;;;;;;;;;;;;;              ● Assembly (0.0 %) ● C++ (0.0 %)
+++++++******+++++++;;;;;;;;;;;;;;;;;;;;              ● Other (0.0 %)
+++++++*******+++:::::;;;;;;;;;;;;;;;;;;   Authors: 3% Linus Torvalds 30365
+++++++********::::::::::**;;;;;;;;;;;;;            1% David S. Miller 13285
++++++++*********::::::******;;;;;;;;;;;            1% Arnd Bergmann 8636
++++++:::**********************::;;;;;;;   Last change: 2 months ago
+++::::::::******************::::::::;;;   Contributors: 31712
 :::::::::::::************:::::::::::::    Repo: https://github.com/torvalds/linux
    ::::::::::::::::::::::::::::::::       Commits: 1060298
       ::::::::::::::::::::::::::          Lines of code: 16026142
          ::::::::::::::::::::             Size: 1.02 GiB (74304 files)
              ::::::::::::
                 ::::::

real 11.42
user 12.88
sys 2.17
<PHONE_NUMBER>  maximum resident set size
                   0  average shared memory size
                   0  average unshared data size
                   0  average unshared stack size
              140632  page reclaims
                 638  page faults
                   0  swaps
                   0  block input operations
                   0  block output operations
                   0  messages sent
                   0  messages received
                   0  signals received
               45086  voluntary context switches
               47751  involuntary context switches
<PHONE_NUMBER>58  instructions retired
<PHONE_NUMBER>3  cycles elapsed
<PHONE_NUMBER>  peak memory footprint

On e3b29b0aee7391baa39f613aa8798b0c137e386a
reactos
➜  reactos git:(master) hyperfine onefetch ~/dev/github.com/o2sh/onefetch/target/release/onefetch
Benchmark 1: onefetch
  Time (mean ± σ):      1.492 s ±  0.084 s    [User: 2.549 s, System: 0.698 s]
  Range (min … max):    1.437 s …  1.726 s    10 runs

Benchmark 2: /Users/byron/dev/github.com/o2sh/onefetch/target/release/onefetch
  Time (mean ± σ):      1.040 s ±  0.130 s    [User: 2.158 s, System: 0.609 s]
  Range (min … max):    0.989 s …  1.408 s    10 runs

  Warning: The first benchmarking run for this command was significantly slower than the rest (1.408 s). This could be caused by (filesystem) caches that were not filled until after the first run. You should consider using the '--warmup' option to fill those caches before the actual benchmark. Alternatively, use the '--prepare' option to clear the caches before each timing run.

Summary
  '/Users/byron/dev/github.com/o2sh/onefetch/target/release/onefetch' ran
    1.43 ± 0.20 times faster than 'onefetch'

linux v5.16
➜  linux git:(df0cc57e057f) ✗ hyperfine onefetch ~/dev/github.com/o2sh/onefetch/target/release/onefetch
Benchmark 1: onefetch
  Time (mean ± σ):     19.634 s ±  1.127 s    [User: 20.267 s, System: 2.932 s]
  Range (min … max):   18.966 s … 22.787 s    10 runs

  Warning: The first benchmarking run for this command was significantly slower than the rest (22.787 s). This could be caused by (filesystem) caches that were not filled until after the first run. You should consider using the '--warmup' option to fill those caches before the actual benchmark. Alternatively, use the '--prepare' option to clear the caches before each timing run.

Benchmark 2: /Users/byron/dev/github.com/o2sh/onefetch/target/release/onefetch
  Time (mean ± σ):     10.886 s ±  0.416 s    [User: 13.057 s, System: 2.024 s]
  Range (min … max):   10.351 s … 11.571 s    10 runs

Summary
  '/Users/byron/dev/github.com/o2sh/onefetch/target/release/onefetch' ran
    1.80 ± 0.12 times faster than 'onefetch'

It also uses less memory (already)
➜  linux git:(df0cc57e057f) ✗ /usr/bin/time -lp onefetch
/usr/bin/time -lp ~/dev/github.com/o2sh/onefetch/target/release/onefetch
                 ++++++                    Sebastian Thiel ~ git version 2.32.0 (Apple Git-132)
              ++++++++++++                 ----------------------------------------------------
          ++++++++++++++++++++             Project: linux (1 branch, 735 tags)
       ++++++++++++++++++++++++++          HEAD: df0cc57 (linux-checkout-4)
    ++++++++++++++++++++++++++++++++       Pending: 13+- 13-
 +++++++++++++************+++++++++++++    Version: v5.17-rc7
+++++++++++******************++++++++;;;   Created: 16 years ago
+++++++++**********************++;;;;;;;   Languages:
++++++++*********++++++******;;;;;;;;;;;              ● C (99.0 %) ● Shell (0.5 %)
+++++++********++++++++++**;;;;;;;;;;;;;              ● Python (0.2 %) ● Perl (0.2 %)
+++++++*******+++++++++;;;;;;;;;;;;;;;;;              ● Assembly (0.0 %) ● C++ (0.0 %)
+++++++******+++++++;;;;;;;;;;;;;;;;;;;;              ● Other (0.0 %)
+++++++*******+++:::::;;;;;;;;;;;;;;;;;;   Authors: 3% Linus Torvalds 30365
+++++++********::::::::::**;;;;;;;;;;;;;            1% David S. Miller 13285
++++++++*********::::::******;;;;;;;;;;;            1% Arnd Bergmann 8636
++++++:::**********************::;;;;;;;   Last change: 2 months ago
+++::::::::******************::::::::;;;   Contributors: 31710
 :::::::::::::************:::::::::::::    Repo: https://github.com/torvalds/linux
    ::::::::::::::::::::::::::::::::       Commits: 1060298
       ::::::::::::::::::::::::::          Lines of code: 16026142
          ::::::::::::::::::::             Size: 1.02 GiB (74304 files)
              ::::::::::::
                 ::::::

real 19.71
user 20.29
sys 3.22
<PHONE_NUMBER>  maximum resident set size
                   0  average shared memory size
                   0  average unshared data size
                   0  average unshared stack size
              197675  page reclaims
                   0  page faults
                   0  swaps
                   0  block input operations
                   0  block output operations
                   0  messages sent
                   0  messages received
                   0  signals received
               45187  voluntary context switches
               50938  involuntary context switches
<PHONE_NUMBER>97  instructions retired
<PHONE_NUMBER>2  cycles elapsed
<PHONE_NUMBER>  peak memory footprint
➜  linux git:(df0cc57e057f) ✗ /usr/bin/time -lp ~/dev/github.com/o2sh/onefetch/target/release/onefetch
                 ++++++                    Sebastian Thiel ~ git version 2.32.0 (Apple Git-132)
              ++++++++++++                 ----------------------------------------------------
          ++++++++++++++++++++             Project: linux (1 branch, 735 tags)
       ++++++++++++++++++++++++++          HEAD: df0cc57 (linux-checkout-4)
    ++++++++++++++++++++++++++++++++       Pending: 13+- 13-
 +++++++++++++************+++++++++++++    Version: v5.17-rc7
+++++++++++******************++++++++;;;   Created: 7 years ago
+++++++++**********************++;;;;;;;   Languages:
++++++++*********++++++******;;;;;;;;;;;              ● C (99.0 %) ● Shell (0.5 %)
+++++++********++++++++++**;;;;;;;;;;;;;              ● Python (0.2 %) ● Perl (0.2 %)
+++++++*******+++++++++;;;;;;;;;;;;;;;;;              ● Assembly (0.0 %) ● C++ (0.0 %)
+++++++******+++++++;;;;;;;;;;;;;;;;;;;;              ● Other (0.0 %)
+++++++*******+++:::::;;;;;;;;;;;;;;;;;;   Authors: 3% Linus Torvalds 30365
+++++++********::::::::::**;;;;;;;;;;;;;            1% David S. Miller 13285
++++++++*********::::::******;;;;;;;;;;;            1% Arnd Bergmann 8636
++++++:::**********************::;;;;;;;   Last change: 2 months ago
+++::::::::******************::::::::;;;   Contributors: 31712
 :::::::::::::************:::::::::::::    Repo: https://github.com/torvalds/linux
    ::::::::::::::::::::::::::::::::       Commits: 1060298
       ::::::::::::::::::::::::::          Lines of code: 16026142
          ::::::::::::::::::::             Size: 1.02 GiB (74304 files)
              ::::::::::::
                 ::::::

real 11.07
user 13.31
sys 2.00
<PHONE_NUMBER>  maximum resident set size
                   0  average shared memory size
                   0  average unshared data size
                   0  average unshared stack size
              140884  page reclaims
                 308  page faults
                   0  swaps
                   0  block input operations
                   0  block output operations
                   0  messages sent
                   0  messages received
                   0  signals received
               14833  voluntary context switches
               24536  involuntary context switches
<PHONE_NUMBER>12  instructions retired
<PHONE_NUMBER>1  cycles elapsed
<PHONE_NUMBER>  peak memory footprint

Note that the contributor count is off by 2 - it's likely to be related to the mailmap, and for I don't know if libgit2 is off or gitoxide. I will look into it.

I think it's ready for a formal review. Thanks.

Hi @Byron,
I'll start reviewing you PR asap.
However, I'm having issues running your branch on Windows:

Thanks a lot, and… WOW! A segfault, I haven't seen these in a long time. Sometimes they happened for me as part of a mis-compilation and cargo clean helped.
But it's probably not going to be that easy - would it be possible to add cargo run to CI to prevent such issues in future and potentially allow me to debug this? My approach would be to remove one computation at a time and narrow it down that way for a lack of Windows, but you could probably see where it's coming from with a debugger much more quickly.

After adding putting in a lot of print statements, it seems like the segfaults are happening here and here.
I think we may need to add some unit tests in order to protect us from this kind of errors.

I think we need to add some unit tests in order to protect us from this kind of errors.

While we're at it, you might want to set up some code coverage tool (I use codecov.io). Even if we don't have a goal coverage %, it's useful to easily find what logical branches have and have not been tested.

Might be out-of-scope of this PR (it would certainly add a lot of work, at least!) but I think ideally, instead of running cargo run in the CI, we would have some integration tests that would test against mock repositories for reliable results.

I would be happy to remove cargo run, it didn’t reproduce the crash after all.
Maybe running on a full clone would do it. Will try that tomorrow.

I took a look at what mainline does when displaying shallow clones and noticed that it displays it as 0 commits, even though there is one commit. This is what is shown with the code in this branch, but I thought it would be good to indicate the history has been truncated. Thus 927815a introduces a new form of display that displays this case as 1 commit (shallow).
Hopefully this is something you find as valuable as me, please let me know what you think.

I thought it would be good to indicate the history has been truncated.

That is a good idea! Shallow clones can misrepresent the commit count, after all. Issue #592 may also be relevant -- it seems to be another way that a user might truncate the history.
I'd consider this a new feature besides the goal performance improvement. Would you be willing to keep a log of additional bugfixes/features in this PR's description? That way we can make sure to give you credit for all your improvements in the next release :slightly_smiling_face:

Would you be willing to keep a log of additional bugfixes/features in this PR's description? That way we can make sure to give you credit for all your improvements in the next release slightly_smiling_face

I have created 3 issues related to this PR #628 #629 #636

@spenserblack Thanks so much for pointing me to this issue. Even though I stumbled across the graft/replace feature when studying git's source I could never make sense of it. That changed now and I will implement support for it in gitoxide. No change will be needed in onefetch for that to work.
Besides that, I think all review comments are now addressed 🎉, but I will let you know separately once I think it's ready for a final look.

Many thanks for the hint about replacement objects, thanks to that gitoxide now respects them by default similar to what git does, and also picks up typical git environment variables by default like GIT_NO_REPLACE_OBJECTS and the under-documented GIT_REPLACE_REFS_BASE.
This means that from my side, this PR is now feature complete and I am looking forward to your feedback to push it over the finishing line.

I've just approved the PR.
We'll wait for @spenserblack to finish his review.
After that, you'll be free to merge this branch with main.
Prior to that, don't forget to:

when ready for merge: release gitoxide and switch to using crates.io

@spenserblack, do we keep the cargo run in the ci.yml?
Thanks again for your amazing contribution @Byron, onefetch + gitoxide seems to be a great match :heart: and it will be perfect once git_config and worktree-status are supported.

Thanks for your hard work maintaining gitoxide and making this PR!

You are welcome, it's a pleasure :).
Thanks for all your suggestions, you find them implemented in the new commits. I will let it settle for a day or so in case other bits and pieces come up, and go ahead with the merge otherwise.

And it's done 🎉! Thanks everyone for their suggestions and comments!
I can't wait to finalize the transition to gitoxide in the course of the year.


build issue

{"type":"undefined_method","message":"error evaluating function darken: Object # has no method 'toHSL'","filename":"bootstrap.css","index":270,"line":12,"column":24,"extract":["@linkColor:             #08c;","@linkColorHover:        darken(@linkColor, 15%);",""]}

No such issues here—how are you compiling?

this came up when I tried to use the customize option and I hit the download button

@JackStouffer Any update?


No edit rights for GitHub editors

Issue https://github.com/coreinfrastructure/best-practices-badge/issues/1251 is a case where someone could edit the GitHub repo but not the badge entry.  Check further.
Also, the display cache isn't updated necessarily when you force-add a new user to the list of users who can edit the badge entry.  As a result, you can add a user but their id is not necessarily displayed on the read-only page.

I've done some digging.  I think the problem is that we weren't getting a full list from GitHub.  Some PRs will hopefully fix the problem.

This PR has been left open because we don't seem to be able to reliably determine if someone can edit a project, and it's hard to test or figure out a pattern. My guess is that GitHub sometimes intentionally chooses to omit information, probably for privacy reasons.

@david-a-wheeler I am wondering if this is a closed issue now with the merge for #1419.  What do you think.

@jdossett - I've been wondering that as well.
I think we should close this issue. The merge of #1419 fixes the situation we know of, and we don't have a way to repeat the problem any more that triggered this issue (we found a workaround that solved #1251). We don't know if we still have a problem, we've probably solved it, and we can't reliably repeat it (now).
So: If you also think we should close it, just close it. If you're unsure, let's keep talking.

It looks like we've resolved this, so I'm closing. If there's another problem, we can open a new issue with a specific example we can test.


Scripts with multiple delimiters are ignored

Given the following package.json:
{
  "devDependencies": {
    "npm-run-all": "^4.0.2"
  },
  "scripts": {
    "build": "npm-run-all build:*",
    "build:mac": "echo mac",
    "build:mac:foo": "echo foo",
    "build:mac:bar": "echo bar"
  }
}

I would expect npm run build to output mac, foo, and bar. Instead:
$ npm run build

> @ build /Users/z/Desktop/demo
> npm-run-all build:*

> @ build:mac /Users/z/Desktop/demo
> echo mac

mac

If I change build:mac:foo to build:mac-foo, (replace the second colon with a dash), it runs as expected.

Thank you for this issue.
This is working as expected. npm-run-all is using glob-like pattern matching, but uses : as the delimiter instead of /. You can use global star ** to run all sub-sub tasks.
See: https://github.com/mysticatea/npm-run-all/blob/master/docs/npm-run-all.md#glob-like-pattern-matching-for-script-names

Thanks, @mysticatea 👍


[Feature][model] Support Qwen2MoE

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Qwen/Qwen1.5-MoE-A2.7B-Chat
Qwen2MoE has been supported by the latest version of transformers(v4.40.0).
Use case
No response
Related issues
No response
Feature Priority
None
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Let me give it a try.


Fix hostname overrides regex for other_servers

Originated on https://github.com/danazag/rke2-ansible
What type of PR is this?
(REQUIRED)

[x] bug
[ ] cleanup
[ ] documentation
[ ] feature

What this PR does / why we need it:
(REQUIRED)

Fixes an issue where if any other servers other than the first server have a hostname starting with a number, the regex fails to match and the run fails.
This regex is consistent with the regex for the same task in first_server.

Which issue(s) this PR fixes:
(REQUIRED)

Release Notes
(REQUIRED)

NONE

@danazag tests are failing, could you take a look?


Add English mapathon template for DRC

name: Mapathon
title: Welcome to OpenStreetMap
Hi {{ mapper.displayName }}
I saw that you made your first edit on OpenStreetMap. Congratulations and thank you! You're now a member of the OpenStreetMap community.
As it seems that you joined us thanks to a mapathon likely happening outside of the area that you were mapping, feel free to check the OSM Community Index to connect with mappers closer to you and discover other interesting things to map.
In the Democratic Republic of the Congo, we don't only exist online, but we also meet sometimes in real life.
If you've got any questions the OpenStreetMap DRC community mailing list (Please subscribe first), is the best place to ask. As we usually exchange in French on it, feel free to use an automatic translation tool to post your message in French additionnally to English or your own language. If you think you broke something, don't know for sure how to map something, or just want to know more about OpenStreetMap, you can still get in touch with the mailing list or with the OpenStreetMap DRC organisation, you can also reach out via @OSM_CD on Twitter or OpenStreetMap RDC on Facebook.
Here's some help to get you started:

Welcome Mat gives a good overview of the What? Who? Why? How?, about and Working with OpenStreetMap
You can find a lot of information about how to map on the wiki.
LearnOSM is a good place to learn more about OSM. Instructions are available for using the iD browser editor and the more advanced JOSM editor.
If you want to know how to tag something, the quickest solution may be to search for site:wiki.openstreetmap.org [search term] with your favourite search engine.
When you save your changeset, add a clear comment on what you have changed, not just a symbol or random text (documentation).
Do not connect landuse to roads; leave a small empty area between the two.
When using iD editor, please Zoom in enough to avoid adding duplicates.
Kindly avoid using UPPERCASE for names e.g. TIPTOE LANE, use Tiptoe Lane instead
There's also a global weekly newsletter about the OpenStreetMap world you can subscribe to.

Happy Mapping!

Thanks you @clairedelune !
The new template has been added to https://welcome.osm.be/ ✅


adds support for reasteasy4

Add an agent plugin to support

[x] Add a test case for the new plugin, refer to the doc
[x] Add a component id in the component-libraries.yml
[x] Add a logo in the UI repo

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[x] Update the CHANGES log.

Please make sure you finish the test scenarios, which are mentioned by the plugin develop doc.

When you are ready, please add your case into GHA control file.
About docs, you need to update

changes.md in the root
supported-list to add new version.

When you are ready, please add your case into GHA control file.

This is still missing. We only could use GitHub action to test your scenario after you add it.

One question, what are the differences between 3.x and 4.x plugins? I noticed they are very similar.

One question, what are the differences between 3.x and 4.x plugins? I noticed they are very similar.

Could you example this first?

It is a different artifact name from 3.x and 4.x. In the first one is resteasy-jaxrs and in the latter is resteasy-core.

I think the jar names don't matter when do instrumentation. The class's signature(class name, package name, method name and parameters with types) matters.

It is a different artifact name from 3.x and 4.x. In the first one is resteasy-jaxrs and in the latter is resteasy-core.

I think the jar names don't matter when do instrumentation. The class's signature(class name, package name, method name and parameters with types) matters.

Using the 3.x plugin with a resteasy 4.x application throws a ClassNotFoundException.

I see, could you post the error here?

java.lang.NoSuchMethodError: 'org.jboss.resteasy.spi.ResteasyUriInfo org.jboss.resteasy.spi.HttpRequest.getUri()'
	at org.apache.skywalking.apm.plugin.resteasy.v3.server.SynchronousDispatcherInterceptor.beforeMethod(SynchronousDispatcherInterceptor.java:50)
	at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:76)
	at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java)
	at org.jboss.resteasy.core.SynchronousDispatcher.lambda$invoke$4(SynchronousDispatcher.java:261)
	at org.jboss.resteasy.core.SynchronousDispatcher.lambda$preprocess$0(SynchronousDispatcher.java:161)
	at org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:364)
	at org.jboss.resteasy.core.SynchronousDispatcher.preprocess(SynchronousDispatcher.java:164)
	at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:247)
	at io.quarkus.resteasy.runtime.standalone.RequestDispatcher.service(RequestDispatcher.java:73)
	at io.quarkus.resteasy.runtime.standalone.VertxRequestHandler.dispatch(VertxRequestHandler.java:151)
	at io.quarkus.resteasy.runtime.standalone.VertxRequestHandler$1.run(VertxRequestHandler.java:91)
	at io.quarkus.vertx.core.runtime.VertxCoreRecorder$13.runWith(VertxCoreRecorder.java:545)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
	at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)
	at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:833)```

There is code style in the root, please make sure your plugins and test codes could pass verfication.

Your new case is not working, please check this locally
https://github.com/apache/skywalking-java/runs/6415702839?check_suite_focus=true

I think you didn't test this case locally, please make sure you have passed cases locally first.

@carlfranz Do you still work on this? It is no update for weeks.

Hello @wu-sheng we are facing issues on the build. We cannot replicate locally the error we have with the GH pipeline. I'm not sure to find time to work on this anymore. It's frustrating because we were one step away to do it.

expected:	Span[-1, 0] HEAD:/resteasy-4.x-scenario/healthCheck
actual:	span[-1, 0] /update/1
reason:	[operation name]: expected=>{HEAD:/resteasy-4.x-scenario/healthCheck}, actual=>{/update/1}

From the CI loga, actually, your expected data file added resteasy-4.x-scenario, but you can see the actual data without this prefix.

Please follow the plugin test doc
https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/plugin-test/
You should be able to run it on any Linux and Intel based MacOS.

No update in two weeks. If you still want to continue on this, please let us know. All these tests could run and check on Linux locally, don't have to be on GitHub CI


Doesn't want to re-authenticate with Azure/ADX

Issue Type: Bug
Can't open the previously created connection to Azure Data Explorer, using Azure Active Directory - Universal with MFA support. It works well if you add it for the first time, but after few days of inactivity it tries to connect, but it throws an exception (see the image).

It says that "the refresh token has expired", but it is not possible to re-authenticate, to get a new set of tokens. Wouldn't it be an expected behavior to open a new browser window and do the authentication again?
Currently, it is stuck here, it refuses to connect, but it doesn't offer to re-authenticate.
Azure Data Studio version: azuredatastudio 1.43.0 (b790d700898b1095d83e62f0de14678a58222520, 2023-04-10T23:14:27.236Z)
OS version: Windows_NT x64 10.0.19045
Restricted Mode: No
Preview Features: Enabled

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
31.78GB (10.64GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

azuremonitor
Mic
0.1.9

kusto
Mic
0.5.8

Hi @d3lboy
ADS now prompts to refresh credentials when this error occurs, with latest release v1.44, have you given it a try?

Hi @cheenamalhotra ,
Unfortunately, the result is the same in this 1.44 version also.
Now I can refresh Azure account/credentials, see all resources from my subscriptions, but I can't connect to ADX.
Firstly, it asks for an additional auth

then it says:

Signing in and writing queries in the browser (https://dataexplorer.azure.com/) works without single problem.


"Call to a member function getContentResourceHandle() on a non-object" when parsing large email files

I'm trying to get attachments from raw email data that is more than 9mb. The script runs just fine when the raw email is around 3-4mb. But generates this error when parsing a larger file:
Call to a member function getContentResourceHandle() on a non-object
Any idea what I might be doing wrong?

Alright. So I tried getAttachmentCount() and it returns 0, even though the email has two attachments. And that's why the reference for the attachment object isn't created, resulting in the above error. Is there a fix for this?

Hi @aadilp
Can't think what that could be offhand but I'm wondering if it might be related to #31 as well.  What version of MMP are you using and would it be possible to send the message to me if it's not sensitive (zbateson at gmail)?  Either that or a description of the email for me to run tests:

Mime type of message and all parts (please include relationships if it's more than one level deep)
Size of each part since you suspect that may be the issue
Content-transfer-encoding of each part

I've tried some pretty large emails and haven't had any issues but I'm wondering if I may have introduced a bug in the latest version.
Thank you :)

I tried parsing the same email on my local machine (using xampp on windows), and it worked. So the problem occurs on the production server, which is an EC2 instance running Ubuntu 14.04. I cleared the /tmp folder and tried parsing the email again, and this time it returned the attachment count as 1 (it's supposed to be 2). I saved the attachment to a file and it returned only about 742kb of the data (the original file is actually 2.15mb). It seems like the problem is with the server configuration, however fread($file, filesize($filepath)) returns all the contents of the email. So I'm still confused about the root of the problem.

I finally figured it out. The size of the /tmp folder is only 1mb. So I changed sys_temp_dir in php.ini to some other directory and now the script works like a charm.
Thank you :)

Awesome happy to hear that :)


Refactoring groups.scss file

Signed-off-by: Soham Banerjee<EMAIL_ADDRESS>Fixes #2317
Describe the changes you have made in this PR -
Refactored the long class names in groups.scss
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@tachyons Please do have a look!

Change in css also require change in html where the styles are used

Change in css also require change in html where the styles are used

Will reopen once it's done


Comments on the EM semantic model

@tarcisiotmf it looks interesting !
Some thoughts looking at the SOSA
I am not sure where to put an LCMS platform because it is actually :

definitively a Sensor https://www.w3.org/TR/vocab-ssn/#SOSASensor
but also :
a Sampler https://www.w3.org/TR/vocab-ssn/#SOSASampler (e.g. you aliquot 2microL of the whole sample before injecting)
an Actuator https://www.w3.org/TR/vocab-ssn/#SOSAActuator (e.g. in the sense, how they phrase it, that it "changes the state of the world". The sample will be physically separated during the Liquid Chromatography (LC) run, the analytes will be ionized (in the source), the pool of ion will be further physically separated in the MS analyzer, or even broken down in smaller sub-molecular pieces when using fragmentation mode).

Not sure if we need to be that precise at the moment but it is worth keeping in mind for sure (would ease the collection of experimental parameters such as LC part, ionization part, acquisition modes etc.)
Considering that humans can be considered as Sensors also (https://www.w3.org/TR/vocab-ssn/#SOSASensor) and a Sampler ? (https://www.w3.org/TR/vocab-ssn/#SOSASampler) maybe we could extend this model to also integrate researchers observing and sampling the biodiversity ?

comments added and version 0.2 including pairwise interactions modelling released today


Fix addLessLoader on newer css-loader packages

css-loader has deprecated the localIdentName as a direct option. It now resides within the modules option object.
here

Also issue #242

Hey folks,
The changes in the @next branch have been pushed upstream and merged into master. Please follow the migration guide in #253, which will have you nest your configuration in the lessOptions object.
Hopefully this resolves a majority of the issues in the thread. Please do let me know if you still run into issues; I'll keep this PR thread open for a few days.


http.browse: Set page background color (fixes #2214)

Fixes #2214
Browser defaults vary and this way we prevent mix-ups from setting only some colors.
Thanks for your consideration.
Best, Sebastian

Thanks!


dev: improve extrinsic testing

The current extrinsic testing in test-starknet-extrinsics needs some improvement.
If we look closely at these tests, they are just testing for events being emitted marking success, a better way to test should be to test state transitions that occur as part of calls to these extrinsic.
For example:

In case of deployment: check that the class hash is the one for which the contract has been deployed at that address
Token transfer should check for changes in the balance
Mint should check for NFT with the given token id being available and owned by the specific
UDC deployment should check the contract was deployed successfully

Make class hash declaration test work!

Right now the test is skipped, but it should also be working

@abdelhamidbakhta I would love to take this!

@abdelhamidbakhta I would love to take this!

Assigned to you my friend

NOTE:
Updating the issue here, as mentioned in PR #631, we should skip bringing fixing the declare test into the scope of this issue.
It should be its own issue, as from my previous knowledge it requires a decent scope of work.


Extended insufficient comparator of evaluateInputEntry in LiteralExpr…

…essionEvaluationProvider. Resolved #90

I changed the evaluation rule. I think we need deal with collections more flexible, that's why:
Example 1:
Input: a
Entry: a, b
Result: true
Example 2:
Input: a, b
Entry: a
Result: false
Example 3:
Input: a, b
Entry: b, a
Result: true


Use private logrus instance to separate messages from hosting application

STR:

Have an application using appoptics-api-go client
Set the logrus.SetLevel(logrus.DebugLevel)
My application starts logging at Debug, but also AppOptics Api shows internal log messages, like

DEBU[2381] Uploading AppOptics measurements batchtime2018-03-19 11:24:15 +0100 CETnumMeasurements10globalTagsmap[hostname:brn-dev-mkun]

Wouldn't it be better to use private logger instance to separate appoptics logging completelly ? Like:
var log = logrus.New()

What do you think ?

Ok 9 months later I finally get back to you. Yes this is a good idea, and we'll end up implementing it for 1.0.0 now that we have full feature coverage of the API.


Missing file from last breaking change, move stylewraper in edit mode…

… to up the parent

Hey, sorry I miss this change yesterday, extracting the useful and agreed good changes from https://github.com/plone/volto/pull/3412/


Ensure we upsert leaf funcs to the correct attribute value for existing components

When we author a new code gen or qualification, we find all existing components created with that schema variant and add the func to them. When doing this, we were incorrectly mapping new code gen functions to the qualification attribute value, now we find the correct attribute value for either the code gen or qualification attribute value and create the new attribute value for the new func there!
Also added a test!
Note: This is broken on upgrade until we fix BUG-405, meaning if you have a component on the diagram, regenerate the schema variant, add a new qualification or code gen function to the new schema variant, when you upgrade the component, the new qualification/code gen func won't be attached. Zack is fixing this in 405
via ABC Network on GIPHY

bors r+


Reset accumulate after something happens

One could imagine using accumulate to sum things together (or do something else) until some threshold is met and then starting the average all over again (resetting the result to the starting value). What would be the best way to do this?

Maybe we have an accumulate which takes in two streams, the first has the data and the second exists just to send a reset message (or even a new start value?). This way we could reset based off of some property of the data, eg we reached some threshold (via cyclic graphing) or reset based on something completely different occurring somewhere else in the graph.

Perhaps you can put this logic into your accumulator function?

funny, i was working on this yesterday. What @mrocklin mentioned is what I'm doing. Basically, have an stop condition and initial condition in accumulator:
def acc(prev, next):
    # initial condition
    if prev is None:
        return next
    # stop condition (reset to initial condition)
    if next is None:
        # if prev will get set to None
        return None
    # rest of acc logic

(assumes returns_state=False here)
If you want to be cleaner, prev could be a tuple of mydata, state where state gives information on clearing or not. This ensures more homogeneity downstream.
It's messy, but I feel that enforcing a global clearing mechanism might be too restrictive, considering the stream can already do this. I'd def like to see a use case where it's necessary though. I haven't used this feature so much.
just thoughts, what do you think? I'm interested in exploring more concise methods.
About a stream that resets another, I would vote against that as we'd have to worry about synchronizing yet another stream, when we may not always have to.

Just as a heads up, I would not use next as an arg name since it shadows a python builtin.


WV-464 Campaigns List Page: Add "loading" notice at top of page when list page-revisisted [Team Review/ Merge Ready]

Handles comments in:
https://wevoteusa.atlassian.net/browse/WV-464
Adds displayLoadingBannder function to span on 'clear search' and to the div for 'save changes'

👍


Error running latter

Hi @johnjmar
Can you let me know if you've run into error with Memory/Latter
Build the binaries of stream and lat_mem_rd as the instruction. When executed latter.sh, the process stuck in this line “lat_mem_rd 5i3000 128 0 0 72”.
analysis the usage of lat_men_rd
Usage: ./lat_mem_rd [-P <parallelism>] [-W <warmup>] [-N <repetitions>] [-t] len [stride...]

So the  _ARGS for lat_men_rd is wrong I think
So we should Modify some part
@@ -96,7 +96,7 @@

     # Store the current prefetch and SMT settings
     CURR_PREFETCH=`ppc64_cpu --dscr | sed 's/DSCR is //'`
-    CURR_SMT=`ppc64_cpu --smt | sed "s/SMT=//" | xargs`
+    CURR_SMT=`ppc64_cpu --smt | awk -F "is|=" '{print $2}'`

     for _PREFETCH in ${LTPREFETCH_SET}
     do
@@ -120,7 +120,7 @@

             for _CHIP in ${LTCHIP_SET}
             do
-                _ARGS="${LTITERS}i${LT_BUFSIZE} ${LT_STRIDESIZE} ${_CHIP} ${LTCHIP_SET}"
+                _ARGS="-N ${LTITERS} ${LT_BUFSIZE} ${LT_STRIDESIZE}"
                 _OF1="${LTNAME_LAT}.${_CHIP}.${LTNAME_OUT}"

                 if [[ ${LTRUN_PMCOUNT} == "TRUE" ]]
@@ -148,7 +148,7 @@

     for _CHIP in ${LTCHIP_SET}
     do
-        _ARGS="${LTPATH}/${LTCMD} 60 128 ${_CHIP}"
+        _ARGS="${LTPATH}/${LTCMD} 60 128"
         _OF3="${_CHIP}.cache.out"
         Log "${_ARGS}"
         ${_ARGS} >> ${_OF3} 2>&1
@@ -615,3 +615,4 @@
     rm -r ${LTDATADIR}
 fi
 exit 0
+

And the usage of lat_mem_rd do not support to choose chip.maybe,the source code need to modify again.

@zhqingg you're correct. This is indeed a bug.
For the time being would you please replace function LTlat_mem_rd in the original script with the one below in the included file?
latter.tmp.txt
Also, you are correct in that the the ARGs should be changed to lat_mem_rd ${LT_BUFSIZE} ${LT_STRIDESIZE}
FYI, the owner of the benchmark in no longer in the company and the script may require more work.


More suitable steganography image

Make a better steganography image for the stage 3 with the same hint hidden in image

As discussed in the email, I would like to take this up.

Sure but do work on #1 and #2 before this 👍


Artifact downloads should fail on S3 errors

During http://buildkitestatus.com/incidents/znhf102jn3xg it was found that:

Artifact downloads contained the S3 error message, instead of the expected content. They didn't throw any error (and if they did, the build might have still passed because of #88). They should have thrown an error, and failed the build.
Perhaps to add more protection from this we should "verify" uploaded and downloaded files, just in case there's anything that goes wrong in the process. The artifact upload could send checksum of the original file, and download could use that checksum to verify the file is what was created originally by the team

The checksums are a good idea for peace of mind too.

Perhaps just checking the S3 status and the bytesize of the file would be enough…

If artifacts fail to download, the agent will exit with a non 0 exit status, and cause the build to fail.


DEV #3 : Setup Docker for the project

Priority:  P1
Story Points:  5
User Story:
As a developer, I want to setup docker so that I can containerize the application and its dependencies, ensuring consistency and ease of deployment across various environments.
Potential Risks:

Misconfigurations can lead to connectivity issues and security risks

Demo Steps:

Run "docker compose up" in root directory to run all the associated containers

Acceptance Criteria:

Docker compose up run all the associated container

https://github.com/awaazo/awaazo/assets/46968018/2d21a006-fa28-4d0f-8dd3-8a6855c5c702


Replace Tire gem by newer elasticsearch gem

This required some code changes in the point of contact with the client
but nothing big.
A few TODOs were added as i was navigating the code, for instance:

There's a 'meta' property of the search results being populated,
but doesn't seem to be used. Need to confirm

The 'type' property of ES documents is looking at the class name, which
is not very OOP. We could easily change it. But this takes me to the last
point

We are using ES 2.4.0, while the latest version is 6.X, in which
the 'type' property is deprecated and marked to removal. There are also
some query format changes, but since we are using basic queries, it should
be fairly easy (I started testing this work with a 6.X version).
If we are going to ES update, the 'types' property is going to be
removed anyway: https://www.elastic.co/guide/en/elasticsearch/reference/6.0/removal-of-types.html

closes #1280

Thanks for working on this! I haven't had a chance to look at the code in detail, but I did poke around our Bonsai/Elasticsearch setup. They definitely support Elasticsearch 6.x, but upgrading may require talking to their support folks. It looks like you request a specific version when you provision the heroku add-on, so we'd probably need to re-do that.
However, as part of their sponsorship of the site, they bumped our limits under the free plan (since our query rate is too high). So I'd probably need to get them to re-bump those limits on the new add-on instance.

we can think about upgrading bonsai-elastic afterwards. Will fix the issues reported by rubocop tonight and this should be ready to be merged, as soon as someone can approve it :)

@peff I did not run anything manually. Probably the index was all good and the problem was on Tire

Probably the index was all good and the problem was on Tire

Yeah, if you didn't run anything, then that's likely the case. I guess that means that this failure wasn't actually like the ones we had a year or so ago, where rebuilding the index fixed things. It really was a problem on the lookup side. Anyway, glad it's now fixed.


Deployment error on new repo without pull requests

I just noticed a quirk with the deploy action for a brand new repo where the action was entirely triggered by pushes to main.
I was trying to separate a recipe example from a more mature and complex bakery repo and ran into this error.
assert len(pulls) == 1  # pretty sure this is always true, but just making sure

I think this line here basically fails because there is not a single PR in the repo yet (will test this in a minute). But just wanted to document this here.

Yes the error should presumably be more descriptive.
But in general I think this is the behavior we want?
Insofar as it ensures users are not deploying by pushing to main (but rather from PRs)?

I think this is worth a broader discussion (pending some docs write up) as I have been going back and forth on how to actually launch recipes in multiple scenarios (see #33).


Fix indentation

They should look like, I removed the html entities but I don't know if it's enough
kind: ROLE-TYPE
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  namespace: NAMESPACE
  name: ROLE-OR-CLUSTER-ROLE-NAME
rules:
- apiGroups:
  resources: RESOURCE
  verbs: API-REQUEST-VERB

kind: ROLE-BINDING-TYPE
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: ROLE-OR-CLUSTER-ROLE-BINDING-NAME
  namespace: NAMESPACE
subjects:
- kind: User
  name: USERNAME
  apiGroup: rbac.authorization.k8s.io
roleRef:
  kind: ROLE-TYPE
  name: ROLE-OR-CLUSTER-ROLE-BINDING-NAME
  apiGroup: rbac.authorization.k8s.io

Hey @carlo-colombo I took a stab at it. See what you think: https://docs-pcf-staging.cfapps.io/runtimes/pks/1-2/manage-users.html


Wrong generated code when a class implements an interface and has a queued or pooled state machine

When a class has a "queued" or "pooled" state machine, In the generated code the class implements "Runnable". When the class also implements another interface the generated code for defining the class is wrong.
For example:
interface X{}
class Y{
        isA X;
        pooled sm{
                s1{
                        e->s1;
                }
        }
}

The generated code for defining the class is:
public class Y implements X implements Runnable{
It should be
public class Y implements X, Runnable{

Another good catch ... again, I suggest you fix this yourself, Should not be hard. Remember to add a test.


BigInt support

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt

Are there any work arounds for this until it's added to the package?

Are there any work arounds for this until it's added to the package?

(Sorry if it's in poor taste to leave this comment here.) @OmgImAlexis This may not be useful to you, but for what it's worth: I switched from Runtypes to Zod for bigint support, and have been satisfied with it. (At least after this initial hiccup).

(Sorry if it's in poor taste to leave this comment here.) @OmgImAlexis This may not be useful to you, but for what it's worth: I switched from Runtypes to Zod for bigint support, and have been satisfied with it. (At least after this initial hiccup).

https://github.com/pelotom/runtypes/pull/185/files

https://github.com/pelotom/runtypes/pull/185/files

Hmmm.. last commit was from July of last year, and there's a small queue of pull requests.  This project still active?

  This project still active?


Reinforcement learning

This PR implements the basic reinforcement learning algorithm Q-learning with minor adjustment to reflect the one-sided nature of interactions.
This implementation is also an adaptation of one from jacobusmmsmit/IndirectReciprocityRL.jl. From initial testing, it seems to produce the same results. Any differences will come from RL itself as opposed to the underlying respective packages IR and IndirectReciprocity.
The key implementation difference is that policies are immutable SArrays and learning is done through setindex at the corresponding "information".
Currently there is a bug causing segfault.

The PR also adds a JuliaFormatter.toml and formats the whole repo with it.


Fix Char type bug

Change U1 to S1 as per spec
Closes #268

Actually this isn't such a good idea, so dropping.


issue#30 Extracted html

we extracted the html code to external file here is the change of the code

@nofaryung @flippy1989 please update the PR subject: please move the issue number to the description and make sure the subject describes the actual change.


Weekly Hour Summary Email

After weekly time processing, send an email to the PM team with a summary of hours for the previous week for every staff member.
Highlight/call out any staff who have missing hours.
The email should contain the date range for the week period in the message.
The email should contain a list of all staff sorted by hours last week ascending.
The table should have the following columns

Staff
Hrs Last Week
Hrs This Month
Hrs Last Month

Highlight any staff members who Hrs Last Week < their working hours (staff.WorkingHours) in red.
The email should get sent at 12PM EST on Monday.

@rmaffitsancsoft @amahdysancsoft  Wanted to confirm that this was a weekly email.

Also @rmaffitsancsoft, wanted to confirm that it was okay for the table to just list the column headers as Last Week, Last Month instead of Hours Last Week, Hours Last Month, because I recall the headers were taking up too much space when adding Hours

Also @rmaffitsancsoft, wanted to confirm that it was okay for the table to just list the column headers as Last Week, Last Month instead of Hours Last Week, Hours Last Month, because I recall the headers were taking up too much space when adding Hours

That's fine with me.


4.10.0 release missing on npm

Seems like the latest version wasn't published to npm yet:
https://www.npmjs.com/package/teslajs
Would be nice to be able to have 4.10.0 there.

I have published @gaphi/node-red-contrib-tesla for my personal needs of
this can help you, before returning to the main branch when all the
packages will be available...
Le ven. 31 déc. 2021 à 18:12, Norman Maurer @.***> a
écrit :

Seems like the latest version wasn't published to npm yet:
https://www.npmjs.com/package/teslajs
Would be nice to be able to have 4.10.0 there.
—
Reply to this email directly, view it on GitHub
https://github.com/mseminatore/TeslaJS/issues/295, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADUNWNOOPDYURUGYQSBEET3UTXP6ZANCNFSM5LBQL6KQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

It is now published.


Refer to proper version of toil-lib

The proper version was hidden on Pypi. @hannes-ucsc fixed that and this change updates the wrong version included in #463

@hannes-ucsc


Make Series.quantile compat with pandas

Series.quantile has some inconsistencies with pandas.
import pandas as pd
import dask.dataframe as dd

s = pd.Series([1, 2, 3, 4, 5])
ds = dd.from_pandas(s, 2)

1. pandas quantile can accept scalar, but dask doesn't.
s.quantile(0.5)
3.0

ds.quantile(0.5)
# TypeError: object of type 'numpy.float64' has no len()

2. pandas quantiles with list-like have percentile as index, but dask doesn't.
Also, dask's division must be lower / upper percentiles, e.g. (0.2, 0.8), not keep original divisions.
s.quantile([0.2, 0.8])
# 0.2    1.8
# 0.8    4.2
# dtype: float64

ds.quantile([0.2, 0.8]).compute()
# 0    1.4
# 1    4.8
# dtype: float64

ds.quantile([0.2, 0.8])
# dd.Series<quantiles-3-74ec7e1bfb67fad191323f3109f0da62, divisions=(0, 4)>

+1

Looks good, thanks @sinhrks


Update Dockerfile

Function "process" was facing error sometimes when the version of python was not determined.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix prototype pollution

There is a prototype pollution vulnerability that will DOS users if a request is sent to POST /api/user/settings.
Blacklisting __proto__ will fix the issue.
HackerOne report: #2053341

The PR looks like its for cont3xt but the URL provided is for viewer, so not sure which this is for? Are you putting more details of how to reproduce in the H1 report?
If this is a general issue with prototype and json parser we will probably want to look at a middleware fix.

Oops, sorry. The commit is correct and the issue is on cont3xt. The endpoint is PUT /api/settings in 3218 port. I have provided all the information in the HackerOne report.

If this is a general issue with prototype and json parser we will probably want to look at a middleware fix.

I'd definitely recommend it because more codebase changes might lead to more of these issues so having a site-wide fix would be better.

Ok, I don't have access to the H1 reports so will have to wait. I also think we've already switched to a json parser that doesn't have this issue anymore with proto but once I have a test case I can confirm.

Ok was able to reproduce this one, basically there wasn't any actually pollution happening, but the elasticsearch library won't process json that has certain keywords.
Anyway I'm going to close this PR since it won't actually fix the issue and opened #2324. In the future issues might be better than PRs for tracking these issues. (But feel free to do a PR on that issue.)


Update terminology "kill" to "terminate"

The term "kill" was recently replaced with "stop". After discussing, it was decided that some of these instances actually need to be "terminate". See #7767 for an explanation of the nuances.
Closes #7767.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/134807d1f043231ed8c165605e1772be3fafe892/
Edited pages:

archived/training/backup-and-restore.md
archived/training/client-connection-troubleshooting.md
archived/training/cluster-unavailability-troubleshooting.md
archived/training/cluster-upgrade.md
v1.0/cluster-setup-troubleshooting.md
v1.0/upgrade-cockroach-version.md
v1.1/cluster-setup-troubleshooting.md
v1.1/common-errors.md
v1.1/upgrade-cockroach-version.md
v19.1/common-errors.md
v19.1/demo-serializable.md
v19.1/upgrade-cockroach-version.md
v19.2/demo-fault-tolerance-and-recovery.md
v19.2/demo-serializable.md
v19.2/upgrade-cockroach-version.md
v2.0/cluster-setup-troubleshooting.md
v2.0/common-errors.md
v2.0/upgrade-cockroach-version.md
v2.1/cluster-setup-troubleshooting.md
v2.1/common-errors.md
v2.1/demo-serializable.md
v2.1/upgrade-cockroach-version.md
v20.1/common-errors.md
v20.1/demo-fault-tolerance-and-recovery.md
v20.1/demo-json-support.md
v20.1/demo-serializable.md
v20.1/orchestrate-cockroachdb-with-docker-swarm.md
v20.1/upgrade-cockroach-version.md
v20.2/cockroach-sql.md
v20.2/common-errors.md
v20.2/demo-fault-tolerance-and-recovery.md
v20.2/demo-json-support.md
v20.2/demo-serializable.md
v20.2/deploy-a-test-cluster.md
v20.2/orchestrate-cockroachdb-with-docker-swarm-insecure.md
v20.2/orchestrate-cockroachdb-with-docker-swarm.md
v20.2/remove-nodes.md
v20.2/upgrade-cockroach-version.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a09093b143679d53fc9958c5bdb85817df145aaf/
Edited pages:

archived/training/backup-and-restore.md
archived/training/client-connection-troubleshooting.md
archived/training/cluster-unavailability-troubleshooting.md
archived/training/cluster-upgrade.md
v1.0/cluster-setup-troubleshooting.md
v1.0/upgrade-cockroach-version.md
v1.1/cluster-setup-troubleshooting.md
v1.1/common-errors.md
v1.1/upgrade-cockroach-version.md
v19.1/common-errors.md
v19.1/demo-serializable.md
v19.1/upgrade-cockroach-version.md
v19.2/demo-fault-tolerance-and-recovery.md
v19.2/demo-serializable.md
v19.2/upgrade-cockroach-version.md
v2.0/cluster-setup-troubleshooting.md
v2.0/common-errors.md
v2.0/upgrade-cockroach-version.md
v2.1/cluster-setup-troubleshooting.md
v2.1/common-errors.md
v2.1/demo-serializable.md
v2.1/upgrade-cockroach-version.md
v20.1/common-errors.md
v20.1/demo-fault-tolerance-and-recovery.md
v20.1/demo-json-support.md
v20.1/demo-serializable.md
v20.1/orchestrate-cockroachdb-with-docker-swarm.md
v20.1/upgrade-cockroach-version.md
v20.2/cockroach-sql.md
v20.2/common-errors.md
v20.2/demo-fault-tolerance-and-recovery.md
v20.2/demo-json-support.md
v20.2/demo-serializable.md
v20.2/deploy-a-test-cluster.md
v20.2/orchestrate-cockroachdb-with-docker-swarm-insecure.md
v20.2/orchestrate-cockroachdb-with-docker-swarm.md
v20.2/remove-nodes.md
v20.2/upgrade-cockroach-version.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4c328852b8fdd53db42f7dc3ef0b3ae4815cce01/
Edited pages:

archived/training/backup-and-restore.md
archived/training/client-connection-troubleshooting.md
archived/training/cluster-unavailability-troubleshooting.md
archived/training/cluster-upgrade.md
v1.0/cluster-setup-troubleshooting.md
v1.0/upgrade-cockroach-version.md
v1.1/cluster-setup-troubleshooting.md
v1.1/common-errors.md
v1.1/upgrade-cockroach-version.md
v19.1/common-errors.md
v19.1/demo-serializable.md
v19.1/upgrade-cockroach-version.md
v19.2/demo-fault-tolerance-and-recovery.md
v19.2/demo-serializable.md
v19.2/upgrade-cockroach-version.md
v2.0/cluster-setup-troubleshooting.md
v2.0/common-errors.md
v2.0/upgrade-cockroach-version.md
v2.1/cluster-setup-troubleshooting.md
v2.1/common-errors.md
v2.1/demo-serializable.md
v2.1/upgrade-cockroach-version.md
v20.1/common-errors.md
v20.1/demo-fault-tolerance-and-recovery.md
v20.1/demo-json-support.md
v20.1/demo-serializable.md
v20.1/orchestrate-cockroachdb-with-docker-swarm.md
v20.2/cockroach-sql.md
v20.2/common-errors.md
v20.2/demo-fault-tolerance-and-recovery.md
v20.2/demo-json-support.md
v20.2/demo-serializable.md
v20.2/deploy-a-test-cluster.md
v20.2/orchestrate-cockroachdb-with-docker-swarm-insecure.md
v20.2/orchestrate-cockroachdb-with-docker-swarm.md


TimerService thread pool creates a lot of threads

Once connected to the broker the application creates a large number of very short lived threads.  The issue is the TimerServiceImpl creates its pool as follows
executor = new ScheduledThreadPoolExecutor(1);
executor.setKeepAliveTime(500, TimeUnit.MILLISECONDS);
executor.allowCoreThreadTimeOut(true);

But the idle time on the connection is 1500 seconds (default for MQLight broker I guess).  This means that the core thread times out before the next job comes in and a new thread is created for every transport tick.

This seems to be worse than I thought. We'd assumed that the "keepAlive" timeout of a thread would only occur if workQueue was empty. But what I think is happening is that the threads just always get shutdown after the deadline elapses regardless of whether there's pending work
and then if there is pending work, a new thread gets kicked off to replace the old one. That's why we see the rapid recycling of threads every 500ms. A pool size of 0 still doesn't help us, because there's always a scheduled future task for heartbeating.
See ThreadPoolExecutor#processWorkerExit()

What about just removing the timeout altogether.  I'll give this one a try today.

@leachbj - @prestona kindly took a look at this earlier and has pushed a potential solution. Let us know if this works well for you.

I'm still seeing 9-10 threads created every 10 seconds when the application is idle.  A thread is created, dies off almost immediately then another is created almost immediately.  The threads' lifetime don't overlap.
When I increase the timeout I see a similar behaviour just the rate of creation/death is much reduced.
If I remove the timeout altogether a thread is sometimes created when there is activity but nothing during idle.

@leachbj  - could you say a little more about what your application is doing?  I tried to recreate the issue you are describing by running the Receive sample (both with no messages being sent to it, and with various low rates of messages being sent to it) but without success.  Instead, I got a single thread that just sat in the pool forever (which is the behaviour I was expecting, as the client always has an outstanding schedule request to handle heartbeating connections).

@leachbj since 79dfe2c, the only time I've seen a turnaround of threads from the TimerService pool is if clients have gone into the retrying state - but I'm not sure why you'd see this in an idle app. Presumably you have logging statements in the onRetrying(...) method that would highlight if that was happening?
Are you seeing this behaviour in the modified apps that we recently discussed? i.e., the ones with singleton EndpointService, NettyNetworkService etc. shared across multiple clients? Or is this something you are just seeing with your existing apps and the latest client snapshots?

I've just re-tested with 1.0.2015060300 and the library built from commit 79dfe2cfeedf70f719731d13c6bf3d9eb6cbec80.
I'm testing with two applications. The server will accept on a topic wildcard and then respond to a unique topic.  The client will subscribe to the response topics, generate a message to a unique topic, consume the response then shut down the async clients.
With the release version running the server, on application startup I'm seeing a thread created per second (pool-2), after processing some messages the per second behavior continues.  The modified library version does the same.
The client application doesn't have any long lived async clients and so I just see the threads created during processing then they all die.
I've also tested a version of our application using shared CallbackService, NetworkService, TimerService.  The CallbackService is just the SameThreadCallbackService since we just dispatch an akka message on callbacks, the NetworkService is the standard Netty implementation and the TimerService is a custom implementation using the akka scheduler.  With this one my server code is not creating any threads (once the netty ones are created) but the client still does since netty keeps shutting down.  I could probably replace netty with akka io but that would need to have SSL support which is a bit of a pain.
I can get some specific logs from the app to try work out exactly why the timer threads are being created, just let me know what you're after, but if you made a release of the current version we could just use that with our own timer implementation.


Code quality fix - @Override annotation should be used on any method overriding

This pull request is focused on resolving occurrences of Sonar rule
squid:S1161 - (@Override annotation should be used on any method overriding)
You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1161
Please let me know if you have any questions.
Faisal

Merged, thanks.


Add props for custom icons

Version & browser
v0.12.3 & all browsers
Which components

DatePicker

DateView
MonthView
YearView

TimePicker

Steps to reproduce the problem
The Carousel component provides some props for using custom icons: icon-control-left& icon-control-right while there is no such props available for the Time and Date components.
Expected behavior
Be able to use custom icons for Date & Time pickers using optional props.
Actual behavior
No props available for defining custom icons...
Proposal
I'd like to add props with the current icons values as default. I can take care of the changes in the source code and ake a pull request if you agree.

Merged. Thanks for your contribution!

You're welcome, I could also add additional tests in the .spec.js files for testing usage of custom icons, let me know if you are interested 👍


Update example because foldl doesn't work

https://github.com/nomeata/list-fusion-probe/blob/master/Data/List/Fusion/Probe.hs#L25 needs to be updated with a different example because foldl is fused, as you mentioned elsewhere at https://github.com/nomeata/list-fusion-probe/blob/master/tests/Test.hs#L18

Right. Any suggestions? In the worst case I’ll simply add a note to the example that it refers to the pre-GHC-7.10-foldl.

I don't know, maybe I'll think of something before I write about rewrite rules and mention list-fusion-probe in an upcoming "24 Days of Hackage" blog post...

Oh, there is a dead line for this fix? Then let me at least push a clarifying comment to the docs...


[BEAM-572] Remove Spark Reference in WordCount

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Remove spark reference in WordCount to keep WordCount simple and clear.
Moving input of SparkRunner logic to WordCountIT

Test done and pass with TestDataflowRunner and FlinkRunner. SparkRunner failed due to BEAM-592

+R:@peihe, @jasonkuster

PTAL @peihe

LGTM
+R: @dhalperi

LGTM. Waiting for green before merging.


Upgrade to PHP 8 and run composer update

Build is red because of actions/virtual-environments#2157

Build is red because of actions/virtual-environments#2157


Add an installation video of this webiste

Describe the solution you'd like
We want a terminal screen recording of the installation process, so the new contributors can install easily.
Additional context
Asciinema would be a great option for recording terminal screen

Can I get this issue??

@0xCipher-max take one issue at a time

Sir , I am interested & want to contribute
Please Assign this to me As a LGM- SOC

@Prakash-Haldar ok go for it

Sir Where i have to update this or in which section
Readme.md ?

There are sections for , watch tuorial , website link. You have to place above both of them , with a headline , watch installation video.

Can I work on this issue  under LGM-SOC

As @Prakash-Haldar is not working on this feature, I am assigning this issue to @Amrutha1101

By installation you mean: forking the repo to setting up the project in the system to make changes isn't it?

And can I use obs studio instead of Asciinema?

By installation you mean: forking the repo to setting up the project in the system to make changes isn't it?

Ya basically till running the dev environment, you can find the command in the package.json file

And can I use obs studio instead of Asciinema?

Also, you can use obs also, but if you are contributing try to learn new things, what asscinema provides is ,they provide platform to upload that video file directly from the command line.
Try out asscinema first.
You will have a great learning experience after that.

And can I use obs studio instead of Asciinema?

Also, you can use obs also, but if you are contributing try to learn new things, what asscinema provides is ,they provide platform to upload that video file directly from the command line.
Try out asscinema first.
You will have a great learning experience after that.

Sure!

How to resolve this?

You should have nodemon installed loccally in your machine.
npm install -g nodemon

You should have nodemon installed loccally in your machine.
npm install -g nodemon

Yes done with that but

Nothing is showing up

It is written, server is running on port 9876
Go to chrome
Type - localhost:9876

I'm on windows10 . Asciinema,I don't know how it has to be used on windows. Can I try using one studio?

I'm on windows10 . Asciinema,I don't know how it has to be used on windows. Can I try using one studio?

*OBS studio

Yes