kex_exchange_identification: Connection closed by remote host

I'm evaluating replacement of existing ngrok, however I encounter error.
Here is my testing environment

Sish Server, which host sish service in Azure VM and start with command.

sudo docker run -d --rm --name sish \
  -v `pwd`/ssl:/ssl \
  -v `pwd`/keys:/keys \
  -v `pwd`/pubkeys:/pubkeys \
  # also tried latest version
  --net=host antoniomika/sish:v1.0.10 \
  --ssh-address=:2222 \
  --http-address=:80 \
  --https-address=:443 \
  --https=true \
  --https-certificate-directory=/ssl \
  --authentication-keys-directory=/pubkeys \
  --private-key-location=/keys/ssh_key \
  --bind-random-ports=false \
  --domain=sish.jonasc.dev \
  --debug=true

Target host, which simulate a client behind NAT.
To compare ngrok and sish, I start ngrok.service and ssh command

ssh -p 2222 -R localhost:22 sish.jonasc.dev

The authenticity of host '[sish.jonasc.dev]:2222 ([<IP_ADDRESS>]:2222)' can't be established.
ED25519 key fingerprint is SHA256:pI0c5nUORoAw4CUy4NcrMQlQJvpwcN316+AmJ5B7+Ew.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '[sish.jonasc.dev]:2222,[<IP_ADDRESS>]:2222' (ED25519) to the list of known hosts.
Press Ctrl-C to close the session.

The TCP port :22 is unavailable. Assigning a random port.
Starting SSH Forwarding service for tcp:22. Forwarded connections can be accessed via the following methods:
TCP: sish.jonasc.dev:41729

My laptop, which I intend to ssh login from

I can login via ngrok, however can't via sish.
ssh -vvv -i ~/.ssh/id_rsa<EMAIL_ADDRESS>-p 41729

OpenSSH_8.1p1, LibreSSL 2.7.3
debug1: Reading configuration data /Users/jonas/.ssh/config
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: /etc/ssh/ssh_config line 47: Applying options for *
debug1: Connecting to sish.jonasc.dev port 41729.
debug1: Connection established.
debug1: identity file /Users/jonas/.ssh/id_rsa type 0
debug1: identity file /Users/jonas/.ssh/id_rsa-cert type -1
debug1: Local version string SSH-2.0-OpenSSH_8.1
kex_exchange_identification: Connection closed by remote host

I google similar error, however most of solution does not works to me.
As I believe target host sshd configuration works for ngrok, and it should work for sish too.
Could you light me what mistake I made? Thanks!

Btw, it can be easy to repro with a simple vagrant
# -*- mode: ruby -*-
# vi: set ft=ruby :

Vagrant.configure("2") do |config|
  config.vm.provider "virtualbox" do |v|
    v.memory = 16384
    v.cpus = 2
  end

  # Specify your hostname if you like
  # config.vm.hostname = "name"
  config.vm.box = "bento/ubuntu-18.04"
  config.vm.network "private_network", type: "dhcp"
end

Interesting! I was able to reproduce this locally using the above steps. As a simple work around, you can explicitly set the port. For your usecase, that can either just be -R 22:localhost:22 or to get a random port -R 0:localhost:22. I'm still looking into why this happens though.

Thanks @antoniomika for work around, and I can ssh login to target host now however the connection will be closed shortly, the connection does not last over 10 sec with the following error message. Do you have any idea to work around this? Thanks!
jonas_cheng@vagrant:~$ debug3: send packet: type 1
debug1: channel 0: free: client-session, nchannels 1
debug3: channel 0: status: The following connections are open:
  #0 client-session (t4 r0 i0/0 o0/0 e[write]/0 fd 6/7/8 sock -1 cc -1)

debug3: fd 1 is not O_NONBLOCK
Connection to sish.jonasc.dev closed by remote host.
Connection to sish.jonasc.dev closed.
Transferred: sent 4072, received 4220 bytes, in 7.0 seconds
Bytes per second: sent 579.4, received 600.4
debug1: Exit status -1

Yep! Take a look at this comment:
https://github.com/antoniomika/sish/issues/113#issuecomment-658917828

Yep! Take a look at this comment:
#113 (comment)

Thanks! work perfectly now.

I am facing the same/similar issue, accessing a remote port bound SSH service is impossible. While connection to the remote with an TCP alias, the error is:
Connection to xyz closed by remote host.
kex_exchange_identification: Connection closed by remote host
Connection closed by UNKNOWN port 65535
Any idea what can be tested/configured?

Hmm, could you include what ssh command you are using? Also some logs from sish would be helpful!

Thx for the quick reply, I disabled auth temporarily now for testing. Any attempt to connect to the markssh alias on port 22 fails so far. I wonder why a http binding on port 2020 is created for the tcp:22 service?
ssh -p 2222 -R mark:80:localhost:7070 -R markssh:22:localhost:22 ns2.think5.de
Press Ctrl-C to close the session.
Starting SSH Forwarding service for tcp:22. Forwarded connections can be accessed via the following methods:
HTTP: http://markssh.sunny5.de:2020
Starting SSH Forwarding service for http:80. Forwarded connections can be accessed via the following methods:
HTTP: http://mark.sunny5.de:2020

Awesome, you are the man :-) Works now except the connection is dropped after a few seconds. What is your suggested way to fix this?

Adding stdin_open: true and tty: true to the docker-compose.yml kept the connection open. But not exactly sure about the impact, so I added --idle-connection-timeout=60m now, this should fit the needs in most cases.

Take a look at this whole issue, I think the same fix above should work for you!

I actually just confirmed this isn't an issue with sish (yay!). It looks like this happens with SSH and is expected. Taken from SSH manpage:
if no explicit destination was specified, ssh will act as a SOCKS 4/5 proxy and forward connections to the destinations requested by the remote SOCKS client

sish doesn't support SOCKS, which explains why things don't work as we think they should!


Q/A: Adjusting the size of date range picker ?

Is it possible to make date range picker smaller than the default size or make it fluid without fiddling with the scss ?

Hi @cemremengu, what specifically are you trying to adjust? Like the individual CalendarDay squares?

This exists now!

@majapw I was watching from shadows due to my work load. :eyes:  Thank you for your hard work!


Update tooltip library

Summary
This PR helps us get rid of the fork for the react-native-tooltip, I'm going to keep the fork around for a couple of releases and then will delete it

@saturninoabril changes made

@hmhealey done


Add "Completed ✔" button for reoccurring reminders

Add "Completed ✔" button for reoccurring reminders when they execute.
This button will delete reoccurring reminder.

Done in #111


Trace ExecuteStatement operation exec time histogram

Why are the changes needed?

Trace statement exec time histogram to provide more insights.
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #4214 (1edd11c) into master (7c036fb) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4214      +/-   ##
============================================
- Coverage     53.07%   53.04%   -0.04%
  Complexity       13       13
============================================
  Files           548      548
  Lines         30010    30017       +7
  Branches       4035     4035
============================================
- Hits          15929    15923       -6
- Misses        12599    12608       +9
- Partials       1482     1486       +4

Impacted Files
Coverage Δ

...a/org/apache/kyuubi/metrics/MetricsConstants.scala
100.00% <100.00%> (ø)

...cala/org/apache/kyuubi/metrics/MetricsSystem.scala
89.13% <100.00%> (+4.68%)
:arrow_up:

...org/apache/kyuubi/operation/ExecuteStatement.scala
79.26% <100.00%> (+1.34%)
:arrow_up:

...e/kyuubi/jdbc/hive/ClosedOrCancelledException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../kyuubi/server/mysql/constant/MySQLErrorCode.scala
13.84% <0.00%> (-6.16%)
:arrow_down:

...uubi/engine/spark/events/SparkOperationEvent.scala
88.88% <0.00%> (-5.56%)
:arrow_down:

...ache/kyuubi/server/mysql/MySQLCommandHandler.scala
77.77% <0.00%> (-4.05%)
:arrow_down:

...ache/kyuubi/server/mysql/MySQLGenericPackets.scala
76.59% <0.00%> (-2.13%)
:arrow_down:

...apache/kyuubi/service/TBinaryFrontendService.scala
48.38% <0.00%> (-1.08%)
:arrow_down:

.../org/apache/kyuubi/session/KyuubiSessionImpl.scala
76.02% <0.00%> (-0.69%)
:arrow_down:

... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

thanks, merged to master


Matched Contact causes accountId must be specified if contactId is not null error

When a lead convert gets a duplicate error from a duplicate contact, the MatchRecord doesn't always return the AccountId as one of the fields on Contact. This causes the setAccountId() method to set a null AccountId. When the lead tries to convert, an "accountId must be specified if contactId is not null" error is thrown.

I am concerned this may be a configuration issue and not a code issue. Would you be able to send a screenshot or information from the org where you are seeing this so we can look into this? This is what we would need to see:

Screenshot of the list of Matching Rules that are active, or a list of the matching rules and objects for those rules that are active
Screenshot of the list of Duplicate Rules that are active, or a list of the duplicate rules and how they are built that are active
Screenshots of the criteria for each Matching Rule that is active
Screenshot of the standard mappings for Lead to Contact (this can be found in Setup in the Lead object by clicking on the mapping button on the list of fields.

@karamcintyre It was just the standard Lead, Contact, and Account matching/duplicate rules that were all set to Alert on create. The Lead/Contact mappings were all standard as well.
After some extensive debugging, I found that the Contact object returned by the MatchRecord object (here) didn't include all Contact fields as part of the instance of the object (no different than if you leave out a field when during a query). The AccountId was one of the fields that wasn't being returned. I believe it may have been because the Account wasn't one of the things that triggered the duplicate exception, but I'm not sure. The Contact object returned looked something like:
Contact: {Id =<PHONE_NUMBER>00000AAA, FirstName = 'Kyle', LastName = 'Schmid', Email =<EMAIL_ADDRESS>So when the processor was calling setAccountId() (here), null was being returned.

When you say "standard" you mean the standard Salesforce matching rules that cannot be edited that come with an org, correct? Those cannot be activated when Interactions is installed because they are not formatted in the correct way to allow the code to use the information when it encounters a duplicate, specifically Account. Even though they are set to Alert, they will still error and the code will attempt to use that information but it won't be able to.
You need to create custom Lead and Contact Matching Rules and activate those, and they must follow the formatting specified on pages 39-44 of the Configuration and Installation Guide. If you follow those steps to the letter and deactivate any matching rules that do not follow the correct format, I'm confident you will not see this anymore.
I'm going to have a developer look at the pull request for this, but I don't think what you're seeing is because of an issue with the code, so I'm concerned the proposed changes could disrupt functionality.

@karamcintyre I think the part of the format with "Company" is what triggers the Account to be returned, which makes sense. There may be some issues between orgs with the HEDA Last Name + Administrative Account format for existing Contacts vs. the Last Name, First Name format. The code changes in the pull request only run if the Account ID isn't found to begin with and essentially just query for the matched Contact's Account ID, so you may want to think about including it as a fail-safe.

We're taking a look. I'll reopen it for the time being, if you could test the corrected matching rules to confirm that the issue you ran into is solved, that would help us a lot.

@kyleschmid Have you tested all the different use cases around matching records with Interactions using the orgs that use default rules instead of Interaction rules? I find it really surprising that Interactions could function when the duplicate rules are not setup according to the documentation.

@karamcintyre No, I didn't test all the different use cases/matching criteria. I was focused on the First/Last Name and Email matching. That worked without issue with the default rules in the development sandbox I tested in but was giving me the issue in a client's production org.


Unhandled JS Exception: Invariant Violation in 0.36

Description
A usual upgrade and reload ended up with this red screen.

Reproduction
If we rolled back to 0.35, the symptom disappeared.
Additional Information

React Native version: 0.36.0
Platform: iOS
Operating System: macOS

Did you do all the usual "stuff"?
react-native upgrade

clear out watchman
restart packager
re-build:
react-native run-ios

Thanks for the comment @rogchap,
However, we took all those steps, but in vain.
Thankfully, simultaneous upgrade toward 0.37.0-rc0 and Xcode/iOS 10.1 yesterday solved this issue.

+1

I am facing this issue can anyone help me solving it?
my package.json
{
"name": "Project",
"version": "0.0.1",
"private": true,
"scripts": {
"start": "react-native start"
},
"dependencies": {
"react": "15.4.0",
"react-native": "0.41.2",
"react-native-splash-screen": "^2.0.0"
}
}


Windows

It's not working on Windows. I'm getting: Non-negative number required. (Parameter 'width') .
at Windows.Foundation.Size..ctor(Single width, Single height)
at Windows.Foundation.Size..ctor(Double width, Double height)
at Microsoft.Maui.Platform.LayoutPanel.MeasureOverride(Size availableSize)
at Microsoft.UI.Xaml.FrameworkElement.Microsoft.UI.Xaml.IFrameworkElementOverrides.MeasureOverride(Size availableSize)
at ABI.Microsoft.UI.Xaml.IFrameworkElementOverrides.Do_Abi_MeasureOverride_0(IntPtr thisPtr, Size availableSize, Size* result)
--- End of stack trace from previous location ---
at WinRT.ExceptionHelpers.g__Throw|20_0(Int32 hr)
at WinRT.ExceptionHelpers.ThrowExceptionForHR(Int32 hr)
at ABI.Microsoft.UI.Xaml.IUIElementMethods.Measure(IObjectReference _obj, Size availableSize)
at Microsoft.UI.Xaml.UIElement.Measure(Size availableSize)

which app is not working for you? any sample code?

I tried to run rive-app on windows. There is no framework configuration for it so I added it:
$(TargetFrameworks);net7.0-windows10.0.19041.0
It seams there is some issue with scrollview.  I tried to run Test app from MauiReactor repo on Windows and it is working fine. Could you try to run RiveApp (this repo) on Windows?

Yes, RiveApp was built specifically for mobile platforms, Android and iOS, I don think it can work on Windows.

What can I do to make it working, like, what are the main challenges?

Well, first I'm not sure how you can adapt that specific UI to a desktop window that is usually much wider but I would start commenting out components (for example the hamburger menu and the main page animation) and try to find the minimal version that at least starts.


Use vdWHandler 0.4 in water models and scripts

An interesting consequence of our test that "running scripts does not change the OFFXML files of water models" is that the up-conversion to vdWHandler 0.4 is causing a failure. There are a few ways we could work around this, I think the best thing is to simply go out with the old and in with the new.
In this PR:

Water model-generating scripts are updated to use version 0.4, and also incremented their own version by a patch. (This could be a minor version, I don't really care, but it seems appropriate to use the patch version as the information content should be functionally identical.)
Scripts are re-ran, and

Non-versioned files are updated
Versioned files with new versions are tracked
Existing versioned files are left alone

Note that the mainline force fields are not affected; with our current technology it's not trivial to create them using a 100 lines of Python.

Here's the script I used, which could be tracked if desired:
import pathlib

from openff.toolkit import ForceField, __version__
from packaging.version import Version

assert Version(__version__) >= Version("0.14.3")

for file in pathlib.Path(".").rglob("*.offxml"):

    # Do not rewrite mainline force fields
    if file.stem.startswith("openff"):
        continue

    # Round-trip and exploit the toolkit's up-converter
    ForceField(file).to_file(file)

Codecov Report

Merging #77 (654b985) into main (19d29a8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files


TLSBackendPolicy´s TargetRef Name must be unique across all namespaces

My TLSBackendPolicy has a Service as TargetRef. This service name must be unique across all namespaces. Otherwise it will not consistently select the certs for the appropriate routes.
Maybe the problem is that policies are not filtered by namespace with backendNamespace ?
https://github.com/envoyproxy/gateway/blob/c5ec046be14c4bb9049a7d3633900d2b8207d40f/internal/gatewayapi/backendtlspolicy.go#L127-L134
Reproduce:

Create 2 Services with same name but in different namespaces
Create 2 TLSBackendPolicy with same name but in different namespaces
Create 2 HTTPRoutes with same name but in different namespaces and different Hostnames

thanks for raising this bug ! yes, since we moved to gateway-api v1.1, policy.spec.targetRef.Namespace doesnt exist, so here we need to rely on target's Namespace as a filter for the BackendTLSPolicies


Fix block access controller test

Fix #490

Thanks for the quick fix! Is it possible to handle the warnings on GCC Release in this PR as well?
/jenkins/workspace/terrier_PR-493/src/include/storage/block_access_controller.h:128:76: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
/jenkins/workspace/terrier_PR-493/src/include/storage/block_access_controller.h: In member function ‘bool terrier::storage::BlockAccessController::UpdateAtomically(const std::pair<terrier::storage::BlockState, unsigned int>&, std::pair<terrier::storage::BlockState, unsigned int>)’:
/jenkins/workspace/terrier_PR-493/src/include/storage/block_access_controller.h:134:63: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
         expected_bytes, *reinterpret_cast<uint64_t *>(&desired));


 I've found it difficult to debug sleuth itself on account of Span having only milliseconds precision. For example, some tasks end up as zero milliseconds, and others look longer than they should (ex 2 millis when it should be less than one). While we can use btrace or byteman to help diagnose local perf issues, seems we can kill 2 birds with one stone by changing some units to microseconds.
Durations of local spans are better made in smaller order (like microseconds), as you can more easily compare equivalent tasks. Moreover, we should avoid making end markers with calls to System.currentTimeMillis as it cannot show sub-millis differences and also has a risk of moving backwards.
Here's pseudocode of what we could do to alter the impl to use higher precision:

when existing field Span.begin is initialized, also initialize startNanos with System.nanoTime
at Span.stop() set endNanos = System.nanoTime

add new field or method: Span.duration() or durationMicros() =  (endNanos - startNanos) * 1000
direct existing method Span.getAccumulatedMillis to durationMicros() / 1000

Footnote on choosing micros instead of nanos for duration:
I'd suggest not advertising duration in nanoseconds because we cannot accurately measure at that granularity due to the overhead and change frequency of System.nanoTime(). For example, if calling nanoTime has to happen twice, and we should expect 30nanos overhead per call, we can't reliably report duration in orders of nanos. Moreover, eventhough unix can report time in microseconds using the presumably cheaper gettimeofday, it cannot in nanos. In short, micros ends up a pretty decent choice for various reasons even if we didn't consider zipkin which uses micros consistently for everything.

Typo (Span.getAccumulatedMillis to durationMicros() / 1000)?

Actually Nanos to Millis is / 1 000 000 isn't it?

The example was micros to millis.

fixed the typo. thx @dsyer


🚧 Fix play track bug while in session

Description
The main purpose of this pull request is to fix a bug where the app crashes when trying to play a new song while in your own session already. The bug occurs when the current user is in their own session listening to music, and taps on another song to listen to in the same session.
Test Plan
N/A
Motivation and Context
We want users to be able to listen to music as they would want to in a session without anything impeding them from doing so. This includes listening to music in any fashion.
How Has This Been Tested?
I've gone through various use cases to ensure the functionality is operating as it should be.
Screenshots (if appropriate)
N/A
Types of Changes

Documentation
Bug fix
New feature
Breaking change

Bug Fixes

#36

Checklist

[x] My code follows the code style of this project

 App crashes when playing new song while already listening


Improve demo: save demo files inside the repository so they don't stay in ~/.cache forever

Moved the sample_data directory from ~/.cache into the repository (added the new directory to .gitignore). Result:

I also changed the same bits of code in the notebook: https://github.com/GeorgeBatch/prov-gigapath/commit/2a32d9a7b57ebcd3672576367e5576be56092688
Can add this commit here too if you think the changes are appropriate.


Adds tag-based publishing to Maven Central

This re-uses the deployment flow from zipkin-java which has the
following features:

Makes OpenTracing Java releaseable by anyone with access to the Bintray org
Snapshot publishing to http://oss.jfrog.org/artifactory/oss-snapshot-local
Fully automated release to maven central via release-N.N.N tag

Releases also published to https://jcenter.bintray.com

Fixes #3

@adriancole thank you for doing this!! It's timely, as I had an item to try and learn enough about mvnw to do something like this myself, and now I don't have to. :)  Amazing.
@michaelsembwever let me know if you want to review this... otherwise I am going to make a few nits and LGTM.

I'm going to merge this as it seems both really useful and doesn't affect the APIs per se. Thanks again, @adriancole !

No problem!


Essential Security - Observability Event Notifications configuration name is confusing

Suggest to remove Observability from the term as it implies this is deploying the observability services, when this is actually not the case.
"Essential Security - Observability Event Notifications" -> "Essential Security - Event Notifications"

@vburckhardt It was put there for ordering actually - cc @in-1911

Yes, that was entirely to place the EN DA after logging. So if you can find an "alternative spelling" that would do that - we can change it.

Renaming to Essential Security - Event Notifications since it no longer has a dependency on Observability. Infact Observability has a dependency on it now with Cloud Logs integration

Part of https://github.com/terraform-ibm-modules/dev-rag/releases/tag/v0.4.3


Marquand feature page erroring

The page that's erroring is the shibui collection of early japanese books page, in the menu under "Digital Exhibitions" on https://dpul.princeton.edu/marquand-library
Honeybadger error: https://app.honeybadger.io/projects/51733/faults/82810315
ActionView::Template::Error in pages # internal_server_error
ActionView::Template::Error: undefined method `+' for nil:NilClass
_openseadragon_default.html.erb  39  _app_views_catalog__openseadragon_default_html_erb(...)
[PROJECT_ROOT]/app/views/catalog/_openseadragon_default.html.erb:39:in `_app_views_catalog__openseadragon_default_html_erb'

I'm going to try a reindex before looking into it more closely

Reindexing doesn't fix it. @kelea99 do you think you could help me understand the impact of this issue?

Actually reindexing made the error change. I'm linking the new honeybadger error in the description.


Add --force-color (or -c) option to force output coloring

Usefull when redirecting Deployer output inside shell script. Since output is redirected, posix_isatty() returns false and coloring is disabled by default. This option forces deployer to color output.

Cool! But why you need it?

I'm using bash script when deploying new versions. It works like that:

check existance of backup and log directories
create log file and log everything that is on screen
start timer
use Deployer to deploy code on servers
show deploy time

I like to see colored output when I use Deployer but when I redirect Deployer output like:
php vendor/bin/dep deploy prod | tee "$log_path"

or
exec > >( tee /dev/tty | sed $'s/\E[^m]*m//g' > "$log_path" ) 2>&1

colors are lost because posix_isatty() return false.

I also do:
php deployer.phar deploy -vvv production | tee $log

But I can see colored output. What's the difference?
I use Ubuntu and LXTerminal.

@kenjis Sorry I forgot to add stderr redirection, try this:
php vendor/bin/dep 2>&1 | tee test.log

I mostly use:
exec > >( tee /dev/tty | sed $'s/\E[^m]*m//g' > "$log_path" ) 2>&1

because i don't want to to write command 2>&1 | tee -a $log to every command. I just redirect stderror to stdout and use tee to log everything at the begining of bash script.

@piotrekkr I got no color output. Agree with --force-color option.

@piotrekkr what about using option func instead of getopt?

@elfet Do you mean to only check --force-color or -c inside Deployer::run() ?

@elfet Ok my entire PR is going to trash :) I just looked at \Symfony\Component\Console\Application and there is option:
--ansi            Force ANSI output

Which is doing same thing as my --force-color. You can reject my PR. Thx.

Cool! :)

Good! I got colored output.


Chart Improvements

Improve Chart UI to present more configuration options; add new chart types such as gauge, donut, radar (aka spider or web), and stacked bar chart.

Request to add data labels to charts (not just on hover)

Would be great to choose colors as well.

Hi Grist team, it might be worth to consider integrating something like Vega Lite. Vega (Lite) is a JSON-based format to specify various graphs. It's very powerful and can output charts and graphs of a lot of types with a lot of customization options. From the code Vega generates interactive HTML graphs from that specification which should integrate well into Grist's web UI.
Integrating something like that, with access to the corresponding spreadsheet's data, would immediately give you access to all kinds of charts and features with a lot of customization options supported by Vega, without implementing them all yourself one-by-one. You would also gain integration with the other features of that ecosystem, e.g. SVG/PNG export. For the more basic features, you could still provide GUI elements, so it shouldn't be an UX downgrade, but more advanced users could code custom charts to their liking.

@Eisfunke good idea. Reminds me a bit of this custom widget https://github.com/gristlabs/grist-widget/pull/37 to let you do arbitrary plotly charts. (The widget never got landed but a preview is available using custom widget url https://deploy-preview-37--boisterous-sunburst-a5c941.netlify.app/custom-plotly-chart). I think someone could do a Vega Lite version as a custom widget - it would have all the live data immediately, all that is needed is to render it. A full integrated feature would be even nicer, but significantly more work. Notes on how to make custom widgets are here https://support.getgrist.com/widget-custom/

We now have a widget for advanced charts: https://github.com/gristlabs/custom-charts-widget/blob/main/USAGE.md 📈


Setting SecurityRules with CreateAssemblyInfo

What You Are Seeing?
When I want to use the CreateAssemblyInfo to set the [assembly: SecurityRules(SecurityRuleSet.Level2)] attribute (which is recommended to do by Microsoft) I get a compile error that I can't convert a string to a SecurityRuleSet.
The code I use is:
    CreateAssemblyInfo("./code/SharedAssemblyInfo.cs", new AssemblyInfoSettings
    {
        CustomAttributes = new List<AssemblyInfoCustomAttribute>
        {
            new AssemblyInfoCustomAttribute { Name = "SecurityRules", NameSpace = "System.Security", Value ="SecurityRuleSet.Level2" }
        },
    });

And generates:
[assembly: SecurityRules("SecurityRuleSet.Level2")]

What is Expected?
I would expect to be able to give any type of value to AssemblyInfoCustomAttribute, for example a generic:
    CreateAssemblyInfo("./code/SharedAssemblyInfo.cs", new AssemblyInfoSettings
    {
        CustomAttributes = new List<AssemblyInfoCustomAttribute>
        {
            new AssemblyInfoCustomAttribute<SecurityRuleSet> { Name = "SecurityRules", NameSpace = "System.Security", Value =SecurityRuleSet.Level2 }
        },
    });

And generates:
[assembly: SecurityRules(SecurityRuleSet.Level2)]

What version of Cake are you using?
0.33.0
Are you running on a 32 or 64 bit system?
64 bit
What environment are you running on?  Windows? Linux? Mac?
Windows

Fixed by  #2648


Added initial README for Tests.

Initial documentation for running automated test suites.

This is what I find hard to understand...
The tests on this PR fail whereas they pass on https://github.com/ansible/vscode-ansible/pull/1370
@TamiTakamiya @goneri Are tests in this repository notoriously flakey?

@omaciel You need to add a label for the ack / ack / ack action to pass.

Thank you @manstis I saw the error but I don't seem to have the right access to add labels :/

@omaciel I have added you in the teams/lightspeed-ansible-vscode team, so you should have the required access.

Thank you @ganeshrn


Conflict with "Obsidian Outliner" plugin

When moving tagged list items via the outliner plugin (https://github.com/vslinko/obsidian-outliner) the text of the list items gets mixed up and destroyed.
I don't know which plugin is causing this, how they interact with the Obsidian editor and in which order, so I'm posting this issue on both repos.
It would be awesome to have both great plugins work together :wink:

Will try to look into it if and when I have some time.. Do you know, by any change, that if this is a recent issue or has it always been the case? If the conflict started after an update, potentially it'd be easier to track what changed and therefore easier to fix.


Ends abruptly with the message: Killed

Hi,
I'm trying to run this on Arch Linux without a GPU and 8GB RAM.
Earlier, I got the exact same errors mentioned in #14 but I followed the steps mentioned and those problems were solved.
But now, I'm getting this error where the script tries to run until the second last line, waits for a few seconds (probably trying to process) and then ends abruptly without any detailed message. Just the word 'Killed'.
th neural_style.lua -style_image examples/inputs/starry_night.jpg -content_image examples/inputs/brad_pitt.jpg -gpu -1 -output_image file.png [libprotobuf WARNING google/protobuf/io/coded_stream.cc:537] Reading dangerously large protocol message.  If the message turns out to be larger than<PHONE_NUMBER> bytes, parsing will be halted for security reasons.  To increase the limit (or to disable these warnings), see CodedInputStream::SetTotalBytesLimit() in google/protobuf/io/coded_stream.h.
[libprotobuf WARNING google/protobuf/io/coded_stream.cc:78] The total number of bytes read was 574671192
Successfully loaded models/VGG_ILSVRC_19_layers.caffemodel
conv1_1: 64 3 3 3
conv1_2: 64 64 3 3
conv2_1: 128 64 3 3
conv2_2: 128 128 3 3
conv3_1: 256 128 3 3
conv3_2: 256 256 3 3
conv3_3: 256 256 3 3
conv3_4: 256 256 3 3
conv4_1: 512 256 3 3
conv4_2: 512 512 3 3
conv4_3: 512 512 3 3
conv4_4: 512 512 3 3
conv5_1: 512 512 3 3
conv5_2: 512 512 3 3
conv5_3: 512 512 3 3
conv5_4: 512 512 3 3
fc6: 1 1 25088 4096
fc7: 1 1 4096 4096
fc8: 1 1 4096 1000
WARNING: Skipping content loss
Killed

Hmm, maybe you are running out of memory? Try watching top while it runs.

I also get this error when trying to start a 512 sized network on the CPU, in my case on a virtual machine Ubuntu with about 5 GB dedicated RAM. I also think it's a memory issue, as 256 is the largest resolution I've been able to use without artifacts. Maybe the CPU cannot utilize memory as efficiently as the GPU in when it comes to this, unfortunately.
Try adding "-image_size 256" to the parameters to run a smaller network. (Maybe this should even be the default value, Justin?)

It does seem like a memory issue. Thanks, @SirSpunky, that parameter seems to have fixed the problem. I wish there was a more descriptive error, but I guess that is part of the library.
Thanks, @jcjohnson for making this. :)

I have 4Gb memory but have the same error and can use only -image_size 256
How fix it?


Using timeouts lower than 0.5 secs

Hi!
I'm trying to use timeouts lower than 0.5 secs (let's say 0.2). By default, the internal timer resolution is 0.5 so that it won't work out of the box.
In the code below, after the first request the engine makes, it has a transport dispatcher and then I set the timer resolution to be 0.2.
Looking a the debug log, we can see that the timer resolution changes from:
pysnmp: sendPdu: current time 0 ticks, one tick is 0.5 seconds
to:
pysnmp: sendPdu: current time 1 ticks, one tick is 0.04 seconds
but the actual waiting time still remains 0.5 before we get a timeout.
I'm using Python 3.7
Any ideas? Thanks in advance!
import logging
from time import time
from pysnmp import hlapi, debug

def make_request(engine, oid, transport_target):
    error_indication, error_status, error_index, var_binds = next(
        hlapi.getCmd(engine,
                     hlapi.CommunityData('public'),
                     transport_target,
                     hlapi.ContextData(),
                     hlapi.ObjectType(hlapi.ObjectIdentity(oid)))
    )

    # client errors like timeouts will be here
    if error_indication:
        raise RuntimeError(error_indication)

    # agent-originated errors will appear here
    elif error_status:
        raise RuntimeError('%s at %s' % (error_status.prettyPrint(),
                                         error_index and var_binds[int(error_index) - 1][0] or '?'))
    else:
        var = var_binds[0][1]

        # last check to see that we got an actual value
        if isinstance(var, hlapi.NoSuchObject):
            raise RuntimeError(f'Object {oid} could not be found')
        return var.prettyPrint()

# turn on detailed logging
debug.setLogger(debug.Debug('all'))

# create our engine
engine = hlapi.SnmpEngine()
# sysDescr OID
oid = '<IP_ADDRESS>.<IP_ADDRESS>.0'
# timeout lower than 0.5
timeout = 0.2
# send requests to localhost so we don't get a response
# since we are interested in a timeout
transport_target = hlapi.UdpTransportTarget(('<IP_ADDRESS>', 161), timeout=timeout, retries=0)

# make 5 sequential requests
for i in range(5):
    now = time()
    try:
        print(f'--- making request {i}')
        print(f'result {i}: {make_request(engine, oid, transport_target) + str(i)}')
    except:
        logging.exception(f'an error occurred on request {i}')
    finally:
        # if this is after the first request, we can set the timer resolution
        # because now the engine has a transportDispatcher
        if i == 0:
            print('setting timer resolution')
            engine.transportDispatcher.setTimerResolution(timeout)
            engine.transportDispatcher.timeout = timeout
        print(f'--- request {i} ended. took {int((time() - now) * 1000)} ms')

Thank you for reporting this issue and sorry for taking time looking into it!
It seems like a bug (or a forgotten thing) in pysnmp. It's hopefully fixed In the release candidate.
If you happen to test this fix and give me a go-ahead, I'd make a release.

Thank you very much for the quick fix Ilya. Looks like it resolves the issue as I can now set timeouts lower than 0.5 secs and they are respected by the engine. I do have a couple questions:

Just to make sure, there should not be any issue limiting the rate of requests by calling sleep() in between requests, right? It shouldn't mess up the internal timeout calculations or anything right?
To get accurate results I set the timer resolution to 1/10 of the timeout setting I want. If it's closer to the timeout itself, I start getting major deviations from the timeout setting. Do you think it could pose a performance issue?
I don't think it is required to set the self.timeout of AsyncoreDispatcher in addition to setTimerResolution() as I can see it now uses getTimerResolution() internally.
Is there a way to set the timer resolution prior to the first request? Create an instance of the dispatcher with the desired config and pass it to engine? I didn't see any docs for that.
Thanks!

Thank you very much for the quick fix Ilya. Looks like it resolves the issue as I can now set timeouts lower than 0.5 secs and they are respected by the engine. I do have a couple questions:
Just to make sure, there should not be any issue limiting the rate of requests by calling sleep() in between requests, right? It shouldn't mess up the internal timeout calculations or anything right?
To get accurate results I set the timer resolution to 1/10 of the timeout setting I want. If it's closer to the timeout itself, I start getting major deviations from the timeout setting. Do you think it could pose a performance issue?
I don't think it is required to set the self.timeout of AsyncoreDispatcher in addition to setTimerResolution() as I can see it now uses getTimerResolution() internally.
Is there a way to set the timer resolution prior to the first request? Create an instance of the dispatcher with the desired config and pass it to engine? I didn't see any docs for that.
Thanks!

Just to make sure, there should not be any issue limiting the rate of requests by calling sleep() in between requests, right? It shouldn't mess up the internal timeout calculations or anything right?

I believe the timing is being computed relative to time() so sleep()'ing should be alright.

To get accurate results I set the timer resolution to 1/10 of the timeout setting I want. If it's closer to the timeout itself, I start getting major deviations from the timeout setting. Do you think it could pose a performance issue?

It's hard to say - depends on many things. You should see it yourself - do you observe any resource shortage or excessive use?
BTW, if you have concerns about performance and do not plan to use SNMPv3, there is the lighter alternative known as hlapy/v1arch. It's only available in pysnmp 5 which is being in development.

I don't think it is required to set the self.timeout of AsyncoreDispatcher in addition to setTimerResolution() as I can see it now uses getTimerResolution() internally.

Right, let me revisit that part...

Is there a way to set the timer resolution prior to the first request? Create an instance of the dispatcher with the desired config and pass it to engine? I didn't see any docs for that.

I do not see an easy way as of the current hlapi code. You can do that with the native v1arch and v3arch though.
I am thinking that possibly the cleanest solution could be to automatically reduce timer resolution based on the minimum retry timeout encountered among all the targets...?
WDYT?

Just to make sure, there should not be any issue limiting the rate of requests by calling sleep() in between requests, right? It shouldn't mess up the internal timeout calculations or anything right?

I believe the timing is being computed relative to time() so sleep()'ing should be alright.

I was referring to this (in handleTimerTick()), not sure if it's a problem:
self.__nextTime = timeNow + self.__timerResolution - self.__timerDelta

To get accurate results I set the timer resolution to 1/10 of the timeout setting I want. If it's closer to the timeout itself, I start getting major deviations from the timeout setting. Do you think it could pose a performance issue?

It's hard to say - depends on many things. You should see it yourself - do you observe any resource shortage or excessive use?

I don't see anything unusual from CPU/memory perspective so I think it's ok.

BTW, if you have concerns about performance and do not plan to use SNMPv3, there is the lighter alternative known as hlapy/v1arch. It's only available in pysnmp 5 which is being in development.

I do need v3 support but I will check the new APIs once pysnmp 5 is released.

I don't think it is required to set the self.timeout of AsyncoreDispatcher in addition to setTimerResolution() as I can see it now uses getTimerResolution() internally.

Right, let me revisit that part...

Is there a way to set the timer resolution prior to the first request? Create an instance of the dispatcher with the desired config and pass it to engine? I didn't see any docs for that.

I do not see an easy way as of the current hlapi code. You can do that with the native v1arch and v3arch though.
I am thinking that possibly the cleanest solution could be to automatically reduce timer resolution based on the minimum retry timeout encountered among all the targets...?
WDYT?

Well, I can see a couple of issues with automatically setting the resolution.
Firstly, after changing the resolution, it could take a few requests for things to get smooth and timely (depends on the exact numbers for timeout, resolution and sleep period and what they were before) because let's say the resolution was 1 hour, changing it to 1 second will not happen until the next tick, which could be in up to an hour.
Also, I would want to be able to set the resolution to be smaller (maybe much smaller, possibly 1/10) than the timeout setting, the wanted ratio could be different to accommodate different precision requirements.
And finally, I would want it to take effect starting from the first request.
Is there a way to pass it to the engine's constructor which in turn will pass it to the dispatcher? Could we pass it to getCmd that will pass it down?

The timeout mechanism used in asyncore implementation was discussed above.
However, once fully migrated to asyncio and use self.loop.call_later properly, the timeout mechanism can be quite simple.
https://github.com/lextudio/pysnmp/blob/v5.0.36/pysnmp/carrier/asyncio/dispatch.py#L66
The upgraded sample code only needs the timeout value to be passed to runDispatcher,
https://github.com/lextudio/pysnmp/blob/v5.0.36/examples/v3arch/asyncio/manager/cmdgen/v1-get.py#L84


Pass compiler identification variables to WebKit CMake

Xcode 9 fails to build the test project because it is 32-bit but
iOS 11 no longer supports 32-bit binaries

run ci

run ci


Render zipnerf?

Hi! I am training using a zipnerf implementation, will it ever be possible to load these trained models into your renderer?
Thanks!

Hey @antithing ! Currently I'm working on infrastructure & basic tooling.  TurboNeRF uses a custom implementation of the "Instant Neural Graphics Primitives with a Multiresolution Hash Encoding" paper by Müller, et al.
This project's core NeRF algorithm will likely change soon as I move from basic features and get some time to work on the renderer.  zip-NeRF is indeed a promising idea as it is compatible with the multiresolution hash encoding.
I'd like to promise compatibility with other NeRF renderers, but we are probably pretty far away from unified NeRF models.
Maybe another approach would be to add some sort of NeRF converter that can retrain models in different schemes.  Check this paper out: One is All: Bridging the Gap Between Neural Radiance Fields Architectures with Progressive Volume Distillation


addReference with empty URI i.e. URI=""

Couldn't find a way to sign the whole XML document and have the URL as an empty string while adding the reference
Reference URI=""

Went through the code and was able to find the way to sign the document and add the reference with URI=""
The addReference method takes the 7th argument as isEmptyUri and when it's value is true the URI is saved as "" which was the desired output.
It can be achieve something like
sign.addReference("/*", undefined, undefined, undefined, undefined, undefined, true);

Went through the code and was able to find the way to sign the document and add the reference with URI=""
The addReference method takes the 7th argument as isEmptyUri and when it's value is true the URI is saved as "" which was the desired output.
It can be achieve something like
sign.addReference("/*", undefined, undefined, undefined, undefined, undefined, true);

@LoneRifle Probably you can help here.
Suggestion: The 4th argument in addReference method takes i.e. uri as an input. If the argument's value is passed as "" it should automatically set isEmptyUri to be true. That would make the functionality easier to achieve with a cleaner code.
If you agree, I would be happy to implement it.

Also, It would be nice to add this to the documentation.
Signing the XML document with reference URI="" is one of the most basic requirements. And the library supports it, it would be really nice to add it to the README. Willing to take the documentation task as well

I'm having issues when using isEmptyUri=true.
When I try  isEmptyUri=false I can verify my signature and it is all good but,
When  try isEmptyUri=true I get the error  when verifying the signature  'invalid signature: for uri  calculated digest is 4jyM3Mma3Wo1zTUT8njmv9wHWVnsf2cz4bAS2POf6Do= but the xml to validate supplies digest cJ1B4QVSGSggHteZGcwznrpo5aZy+3L+tK3ZF9PXwj8='
@jaikathuria are you having the same issue?

Not actually. I had to sign the XML to be verified by an external library and I was only able to validate it with isEmptyUri=true.
I didn't try to verify the XML myself though.
How you are trying to sign and verify, I might be able to assist.

Feel free to put up a PR that includes some better documentation about this or that improves the user experience.


Char::from_int is unsafe

This code will crash:
fn init {
  let a = from_int(-1)
  println(a.to_string())
}

The Char::from_int is a primitive %char_from_int, which is an unsafe %identity.
pub fn Char::from_int(val : Int) -> Char = "%char_from_int"

We should verify the input similar to UChar.of_int in OCaml.

UChar.of_int will Raises Invalid_argument if i does not satisfy Uchar.is_valid.
is_valid n is true iff n is a Unicode scalar value (i.e. in the ranges 0x0000...0xD7FF or 0xE000...0x10FFFF).
So should it also raise exception?

https://github.com/moonbitlang/core/issues/754#issuecomment-2252365147
(Not Vaule )

#338

So should it also raise exception?

Like the APIs List::head/List::unsafe_head and Queue::peek/Queue::unsafe_peek, returning Option[Char] and providing an unchecked version is sufficient for me.


fix: update to eye v10.19.4

fix: update to eye v10.19.4

:tada: This issue has been resolved in version 16.18.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v16.18.2

Your semantic-release bot :package::rocket:


names of folks e.g. @ragesoss not being highlighted in bot message

thinking they are not getting notifications ...

the greeted person is though - can maybe address this with formatting of some kind ...

working now

although still not triggering a notification for the project maintainer:


All Output window logging fails when the user name has non-ASCII characters on Windows

VSCode Version: 1.25.1
OS Version: Windows.

Steps to Reproduce:

Create a user account such as Σπύρος .
From cmd, runas /user:Σπύρος "C:\Program Files\Microsoft VS Code\Code.exe".
Try to view logs in the Output window.

Bug: All output logging fails and the error below appears. The messages are still being sent by the APIs, but the channel is closed.
Error: Failed opening file C:\Users\Σπύρος\AppData\Roaming\Code\logs\20180806T112412\exthost5.log for writing: No such file or directory
extensionHostProcess.js:408
at RotatingLogger (c:\Program Files\Microsoft VS Code\resources\app\node_modules.asar\spdlog\index.js:16:3)
at Object.t.createSpdLogService (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:408:29)
at new t (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:453:241)
at new t (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:808:950)
at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:816:31
at
Does this issue occur when all extensions are disabled?: Yes
This was originally reported in https://github.com/Microsoft/vscode-cpptools/issues/2351 .

I haven't been able to locate a duplicate issue.

@mjbvz Yes, it still repros with 1.27.1. It should be pretty easy to repro (I've reproed it on 2 different Windows machines).

Duplicate of #47883
Please try new insiders where the issue has been fixed.


Python Solution

This is Corey McCarty's solution with some extra input from me.
I added an exit conditional at the beginning that cuts down on some of the computation.
Any errors are my own.

So if you exit as soon as you find a 3 solution, you could miss a 2 solution that's coming down the road.
Try it with 18, for example, and you'll see that exiting early misses the solution 3^2 + 3^2.
It should be possible to check all the 2 solutions first and then look at the 3 solutions, but I was going with the way Corey wrote it.
I made a repl.it so you can play with it if you want:
<EMAIL_ADDRESS>

@mrumiker really good point and thanks for pointing that out! I'll change my review and PR 🗡


feature: last_operation in service and service binding metrics

As a service operator, in order to get alerted on failed asynchronous service instances, I would like to have service metrics include the status of services instances, i.e. the last_operation (type=create|update|delete and state=in_progress|succeeded|failed) returned by the list_all_service_instances api
As a service operator, in order to get alerted on failed asynchronous service bindings, I would like to have service binding metrics include the status of services instances, i.e. the last_operation (type=create|update|delete and state=in_progress|succeeded|failed) returned by the list_all_service_bindings api

@gberche-orange The go-cfclient library used by this exporter does not report the last_operation hash as part of the ListServiceBindings response. Can you please open an issue and/or a PR at the go-cfclient repo?

thanks @frodenas for looking into this issue!
Indeed, the last_operation response field is only useful for tracking status of asynchronous service instance and service bindings, and won't help for monitoring failure of synchronous service instances/bindings: even through the last_operation properly provides success status of synchronous provisionning/bindings (see associated sapi story), synchronous failures don't leave a service instance/service binding object available for later inspection.
The go-cfclient currently support async service instances, through the ServiceInstance.LastOperation which seems available for use by the cf-exporter.
I submitted a related issue https://github.com/cloudfoundry-community/go-cfclient/issues/229 for the more recent async service binding support.
It might make sense to tackle monitoring of async service instance first as there is likely a broader service broker currently using this support, and then async service binding as a 2nd step ?
I'm sorry that I am unable contribute more than use-cases/specs here.

I somewhat misread your request and thought you were just asking for ServiceBindings.
ServiceInstance now returns the LastOperation type and state (https://github.com/bosh-prometheus/cf_exporter/commit/6611f15d536bbf667bacf452b80178a2f19eeda9). I'll wait for https://github.com/cloudfoundry-community/go-cfclient/issues/229 to implement ServiceBinding info.

thanks @frodenas !
Looking forward to a new cf_exporter release that prometheus-boshrelease could bump to (likely without ServiceBinding last_operation)


Handle KeyboardInterrupt during training

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[x] Did you write any new necessary tests?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?
Fixes #2079 by introducing a on_interrupted callback where the cause of the interruption can be examined, e.g. by using sys.exc_info().

Hello @moi90! Thanks for opening this PR.

In the file pytorch_lightning/callbacks/base.py:

Line 90:76: W292 no newline at end of file

In the file pytorch_lightning/trainer/callback_hook.py:

Line 107:60: W292 no newline at end of file

Do see the Hitchhiker's guide to code style

@awaelchli Yes, you are right. I will change it accordingly.

looks great, also the testing is nice.
I propose to change the name to simply on_interrupt for consistency, because for example we have on_test_end and not on_test_ended.

I think it is about calling something extra on the interrupt, but true that the interruption status is in Trainer...

@Borda What is your point? Should it be on_interrupt or on_interrupted?

@Borda What is your point? Should it be on_interrupt or on_interrupted?

I would choose on_interrupted
cc: @PyTorchLightning/core-contributors @williamFalcon

@Borda why so?
arguments for on_interrupt:

consistent with rest of callback naming, i.e. interrupt is the noun that refers to the interrupt the same way batch_end refers to the end.
easier to remember since it follows the name pattern of the other callbacks
closer to English language (can form a sentence)
shorter/simpler

arguments for on_interrupted:

?

on_interrupt to be consistent is my vote

I said I would choose on_interrupted, but do not have any strong preference...

@Borda can you rename to on_keyboard_interrupt?
unless this catches any general interrupt?

@Borda can you rename to on_keyboard_interrupt?
unless this catches any general interrupt?

@williamFalcon renamed
cc: @awaelchli @moi90 @justusschock

Great, thanks for merging!


[hw,spi_device,dv] Fix issues with  spi_device_flash_and_tpm

spi_device internally takes up to four cycles to update the INTR_STATUS.upload_cmdfifo_not_empty bit from the last cycles on which upload command is detected.
Increase the timeout set using update_pending_intr_w_delay so that the INTR_STATUS check wont lead to unexpected failures
Add debug messages in update_pending_intr_w_delay to aid debug in case of  failures like these
Since spi_device_tpm_all_vseq and spi_device_flash_all_vseq are launched parallelly in spi_device_flash_and_tpm_vseq, there are instances where register read to INTR_STATE happens while an update to the register is in progress.
Add a check and wait block to make sure INTR_STATE is updated only  if there is no ongoing access

This PR addresses  spi_device_flash_and_tpm failures tracked in https://github.com/lowRISC/opentitan/issues/18364

Thanks for these fixes, @crteja! LGTM
Would it make sense to extend the csr_wr task (defined in hw/dv/sv/csr_utils/csr_utils_pkg.sv) to optionally wait until the written RAL field is not busy? I'm not saying this should be part of this PR, but potentially a follow-up improvement

Thanks @andreaskurth , Raised a new issue to track the enhancement https://github.com/lowRISC/opentitan/issues/18737


Since update to windows 24H2 Error code: Wsl/Service/CreateInstance/0xd0000022

Windows Version
Windows 11 pro 24H2 build 26100.712
WSL Version
All
Are you using WSL 1 or WSL 2?

[ ] WSL 2
[X] WSL 1

Kernel Version
No response
Distro Version
No response
Other Software
No response
Repro Steps
I updated to windows 24H2 and since then, I cannot start wsl.
Writting wsl -l -v in a terminal gives my distro configuration:
NAME      STATE           VERSION

Ubuntu    Stopped         1

Writting wsl in a terminal gives the following error:
Performing one-time upgrade of the Windows Subsystem for Linux file system for this distribution...
Error: 0xd0000022
Error code: Wsl/Service/CreateInstance/0xd0000022
I have tried to update, uninstall/reinstall. Nothing seems to be working
Expected Behavior
Wsl should start as usually
Actual Behavior
Error:
Performing one-time upgrade of the Windows Subsystem for Linux file system for this distribution...
Error: 0xd0000022
Error code: Wsl/Service/CreateInstance/0xd0000022
Diagnostic Logs
No response

Unregistering and importing back the distro solved the issue


npm warning about installing peer dependencies

I am seeing the following with cargo xtask install

cmd.exe /c npm --version
6.13.7
cmd.exe /c npm install
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

updated 1 package and audited 422 packages in 2.489s
12 packages are looking for funding
run npm fund for details

We updated rollup to the new major version in #3637
But its plugins still require the previos major version. We either need to downgrade rollup or upgrade the plugins if possible.

There's issue on rollup repo saying that its ok, and that the plugins would
be updated next week.
On Thu, 19 Mar 2020 at 23:04, Veetaha<EMAIL_ADDRESS>wrote:

We updated rollup to the new major version in #3637
https://github.com/rust-analyzer/rust-analyzer/pull/3637
But its plugins still require the previos major version. We either need to
downgrade rollup or upgrade the plugins if possible.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/issues/3657#issuecomment-601438561,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANB3M2UBKJBMR3G4LVE4BTRIKJHRANCNFSM4LPL7CZQ
.


Correct links to articles in Blog post

You may want to correct the links in your readme file to point to correct path. As of now, all gives 404.

Thank for pointing this out. It's fixed now.


Import Devices only takes one device at a time

Using the format described here - https://f5devcentral.github.io/vscode-f5/#/device_importing?id=json-object-list-import-structure
When I import multiple devices, I see it add a device and the IP address changes as it parses the file and stops at the last one in the JSON structure.  If I repeat, it will add a new device and then stop at the next to the last one in the JSON file, and this repeats until all of the devices in the JSON file are in place.
I originally discovered this on a code server implementation of the extension, but can replicate it locally on my windows 10 machine as well.
Both versions of the extension are 3.16.1
[
    {
        "device"<EMAIL_ADDRESS>        "password": "password",
        "provider": "tmos"
    },
    {
        "device"<EMAIL_ADDRESS>        "password": "password",
        "provider": "tmos"
    },
    {
        "device"<EMAIL_ADDRESS>        "password": "password",
        "provider": "tmos"
    },
    {
        "device"<EMAIL_ADDRESS>        "password": "password",
        "provider": "tmos"
    }
]


How to bootstrap?

@pradyunsg I'm considering adding the ability to use build/installer as an alternative to pip in Spack. The first step is bootstrapping. How would I install installer without the presence of pip/installer/build/flit/setuptools/distutils/etc?
For pip, we use the advice in https://discuss.python.org/t/bootstrapping-a-specific-version-of-pip/12306 (using the wheel to install itself). Would something similar be possible with installer?

Yes, that should work. I've done the same thing myself although with
PYTHONPATH=$PWD/dist/installer-*.whl python -m installer dist/installer-*.whl

Closing this out since the question has been answered. :)

Just remembered we're still waiting for a new release since we need the functionality in https://github.com/pypa/installer/pull/103 in order to properly use installer in Spack. Once there's a new release, I'll update Spack so that build/installer can bootstrap themselves. For future me, the package recipe will look like:
import os

from spack.package import *

class PyInstaller(Package, PythonExtension):
    """A library for installing Python wheels."""

    homepage = "https://github.com/pradyunsg/installer"
    url = "https://files.pythonhosted.org/packages/py3/i/installer/installer-0.6.0-py3-none-any.whl"
    list_url = "https://pypi.org/simple/installer/"

    maintainers = ["adamjstewart", "pradyunsg"]

    version("0.6.0", sha256="...", expand=False)

    extends("python")

    def install(self, spec, prefix):
        # To build and install installer from source, you need flit-core, build, and installer
        # already installed. We get around this by using a pre-built wheel to install itself.
        # See https://github.com/pypa/installer/issues/150 for details.

        # We can't do this in setup_build_environment because self.stage.archive_file is undefined
        wheel = self.stage.archive_file
        path = os.environ.get("PYTHONPATH", "")
        os.environ["PYTHONPATH"] = os.pathsep.join([wheel, path])

        args = ["-m", "installer", "--prefix", prefix, wheel]
        python(*args)

    def setup_dependent_package(self, module, dependent_spec):
        installer = dependent_spec["python"].command
        installer.add_default_arg("-m")
        installer.add_default_arg("installer")
        setattr(module, "installer", installer)


usm: http2: tests: Cut 2m from TestSimpleHTTP2

What does this PR do?
The PR reuses the same USM instance, and just clears the http2 maps in between the runs, to have a clean state in the next test.
TestSimpleHTTP2 runs for co-re, runtime compilation and prebuilt each of them each and without TLS (besides prebuilt, which does not support tls), total 5 variations. Then, we have 3 scenarios, each running 3 times (for a single client. two clients and five clients). Totally 45 runs. The change reduces 2-3s from each run, and totally ~2m.

Motivation
faster ci

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


windows.h

Library fails to compile, if include <windows.h> before <cds/urcu/general_buffered.h>.

It is a well-known problem of windows.h. Just define NOMINMAX before including windows.h:
#define NOMINMAX
#include <windows.h>


Consistent naming of identifiers

Maybe this has been discussed now in Montpellier:
Internal database identifiers in V1 often end in xxDbId like germplasmDbId - one implication from examples is that it is an integer. The naming is not always uniform across identifiers as in markerId. Also, the same schema could be adhered to in the url calls and other documentation of a call.

This most definitely shouldn't be an integer.

It is already defined as a string in the documentation.

I agree that we should be consistent and we did do a fair amount of clean up but clearly missed a few such as markerId.  I propose that we leave the clean-up of any remaining inconsistencies in the naming conventions to version 2.


'type' object is not subscriptable

Describe the bug
Getting this error on every run
Error running process: /content/stable-diffusion-webui/extensions/sd-dynamic-prompts/scripts/dynamic_prompting.py
Traceback (most recent call last):
  File "/content/stable-diffusion-webui/modules/scripts.py", line 338, in process
    script.process(p, *script_args)
  File "/content/stable-diffusion-webui/extensions/sd-dynamic-prompts/scripts/dynamic_prompting.py", line 412, in process
    all_prompts = generator.generate(num_images)
  File "/content/stable-diffusion-webui/extensions/sd-dynamic-prompts/prompts/generators/randomprompt.py", line 231, in generate
    prompts = self._generator.generate_prompts(self._template, max_prompts)
  File "/content/stable-diffusion-webui/extensions/sd-dynamic-prompts/prompts/parser/random_generator.py", line 117, in generate_prompts
    tokens = cast(list[Command], tokens)
TypeError: 'type' object is not subscriptable

To Reproduce
I ran this on a Google colab. Install the addon and run A1111 and it just happens. If the stack trace is not enough, let's me know and I'll describe more about it

Getting the same thing, using theLastBen colab notebook.

I think it's related to an older version of python on colab. I've just push a small change which should fix it, although there may be additional issues. I can't test with another python version right now but will do so when I can.
Please let me know if you encounter similar issues.

Thanks @rektobot - I'll let you know if I need you to test anything, much appreciated

@rektobot could you please test a version that I just push to github to see if it works for you.
in the extensions/sd-dynamic-prompts folder, run the following:
git pull -a
git checkout v2.0.1

Seems to be fixed now 👍

Awesome! I haven't released v2 officially yet so don't use the extensions tab to update it otherwise you'll be downgraded back to v1.5. Please let me know if you encounter any issues with v2.


update-translations: Perform git and build system updates

Add code to perform the steps from the build process to update git, the qt resource file, and the build system automatically.

Concept ACK

I'm going to merge this as this is what I'm using for updates on 0.19, it seems to work well enough.


WeedFS Daemon !!

Hi Chris,
First please accept my gratitude for this project. We've been using it in production since a year & have deployed 2 x Thumbs server with 2TB storage yet on each Node & not facing a single issue since then. I'd like to inform you that i had created weedFS init daemon for centos & wanted to share its code so it can help users. Can you please guide me how can i submit it ?

Thanks!
I think you can create a sub directory to init the daemon. You can create a PR first.

@shahzaibcb Is this done? Or should I close this?

Hi chris, i added script but it was added into my private git. May i create a sub directory in the same git which people use to download publicly ?

Chris, i've pushed two commits:
weedfs-daemon (Use on volume server)
weedmaster-daemon (Use on master server)
Can you please verify these ?

@shahzaibcb How can i migrate your init script into a systemctrl daemon service?

Hi,
Currently its compatible with centos-6, i've not tested with centos-7 or debian/ubuntu yet. Where you're using it ?


SOLR-15787: Implement FileSystemConfigSetService

Changes:

Implement FileSystemConfigSetService
Bootstrap configset during configset service creation
Update access modifier for #getCurrentSchemaModificationVersion
Implement TestConfigSetService,TestFileSystemConfigSetService
Check NoNodeException in #getConfigMetadata

@dsmiley, maybe I should update ZkConfigSetService#checkConfigExists in this PR  to check if the config dir is not empty and contains solrconfig.xml file ?

maybe I should update ZkConfigSetService#checkConfigExists in this PR to check if the config dir is not empty and contains solrconfig.xml file ?

No; it is unrelated to this PR.

Jira SOLR-15258 is closed, can this PR also be closed?

SOLR-15258 is a refactoring that we might say can include this or maybe not; it doesn't matter I suppose.  It's 9.0 only so there is more fluidity.  I suppose a separate issue feels better.

The answer made me no wiser :) To me it looked like this is committed elsewhere without being closed. But you're saying this PR should get another JIRA number and remains to be merged? I did not look closely.

@janhoy this PR is not committed before. I think jira number is confusing  here as SOLR-15258 is already closed.
I will create a jira issue and link this PR with that. But still it remains to be merged.

Thanks for the clarification :)

@NazerkeBS I see you added stuff outside of FileSystemConfigSetService. Can you summarize those changes please? What is the intent behind them? I suspect they are unrelated to FileSystemConfigSetService and thus should be a separate PR (probably no JIRA).

@dsmiley please see the comments above

Tip:  Follow the Google Java Format configuration settings for your IDE.  Furthermore, I suggest telling IntelliJ to automatically apply formatting on commit.  This will reduce the amount of "tidy"-ing you do a lot!


README/UsefulLinks: Google LibPhoneNumber demo

Phone Number Parser Demo for LibPhoneNumber[^13]
[^13]: google/libphonenumber: Google's common Java, C++ and JavaScript library for parsing, formatting, and validating international phone numbers.

Closed. Use on ralphhightower.github.io


chore: remove outdated notebook

Fixes internal bug: b/332595790 🦕

Do we have other notebooks that cover these user journeys?

Do we have other notebooks that cover these user journeys?

The user journeys covered by these notebooks (which uses vertex sdk2) are now deprecated. For model trainings without vertex sdk, the longer_ml_demo.ipynb shall cover it.


Public API for defining and command line options for tasks

Context

In its current form, this PR is a step towards implementing #2402. I don't believe it's complete (for example no documentation updates have been made), but I'm submitting it now for review and, hopefully, confirmation that I'm heading in the right direction.
The title of #2402 suggests making the parsing API public. I've left OptionReader as part of the internal API for now as it's only used by other internals. Doing so avoids a cyclic dependency between the org.gradle.api.internal.tasks.options and org.gradle.api.tasks.options packages that would occur with the current structure if OptionReader and OptionDescriptor were moved to the latter.
Contributor Checklist

[x] Review Contribution Guidelines
[x] Sign Gradle CLA
[ ] Link to Design Spec for changes that affect more than 1 public API (that is, not in an internal package) or updates to > 20 files
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass locally: ./gradlew quickCheck <impacted-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation including proper use of @since and @Incubating annotations for all public APIs
[ ] Recognize contributor in release notes

@wilkinsona Hi Andy, were you able to make any further progress on this PR? I'd love to have the feature in Gradle core.

Not yet. It's on my TODO list for this week but I need to take care of some other stuff first.

Awesome! Looking forward to your changes.

I've made a little bit of progress and force-pushed an updated commit. The latest changes are:

Reverted the changes to visibility and finality
Improved the javadoc of @Option and @OptionValues
Added @Incubating to @Option and @OptionValues

The options support seems to be fairly well covered by the integration tests in TaskCommandLineConfigurationIntegrationSpec. One thing that's missing is any use of @OptionValues. Is there anything else that you'd particularly like to see?
I'll tackle any necessary integration test updates and the documentation next. Unfortunately, that won't be till towards the end of August as I'm on holiday for the next couple of weeks.

Thinking about it more I think we'll want to keep the internal classes instead of moving them. Those classes are internal but I know a bunch of plugin that use them. We'd automatically break them but just shuffling things around. Could you leave the "old" classes in place and add deprecation warnings for them? A message should be rendered that indicates that they will be remove in Gradle 5.0. In the Javadocs we'll want to point users to the new public API. All Gradle core plugins can starting using the public API with this change.

I'll tackle any necessary integration test updates and the documentation next. Unfortunately, that won't be till towards the end of August as I'm on holiday for the next couple of weeks.

Perfect, thanks.

Unfortunately, that won't be till towards the end of August as I'm on holiday for the next couple of weeks.

Hi, @wilkinsona. Hope you had a nice vacation. Is this something you are planning to pick up again soon?

I did. Thanks.
I'd hoped to pick this up sooner, but Spring Boot M4 has rather got in the way. Sorry for the delay. All being well, I'll be able to look at this again next week.

With apologies for the delay, I've force-pushed a new commit that moves things forward. The changes since the last review are:

Internal @Option has been reinstated and marked as deprecated
Internal @OptionValues has been reinstated and marked as deprecated
OptionReader looks for both internal and public variants of @Option and @OptionValues, logging a deprecation warning when the internal annotations are found
Tests have been updated to verify that the internal annotations continue to work
Integration tests have been updated to verify that the internal annotations log deprecation warnings

I think (hope) that the documentation updates are the final thing to tackle. Can you give me some pointers on how and where to make those updates please?

With apologies for the delay, I've force-pushed a new commit that moves things forward.

Thanks for the updated files. We'll have a look at the changes again soon.

I think (hope) that the documentation updates are the final thing to tackle. Can you give me some pointers on how and where to make those updates please?

At the moment the options are just task-specific. I'd probably add the documentation to tasks.adoc. You will find that our documentation embeds sample code. We should do the same thing here. An important part of the documentation for this feature would be to list the limitations.

At the moment the options are just task-specific. I'd probably add the documentation to tasks.adoc in the docs module. You will find that our documentation embeds sample code. We should do the same thing here. An important part of the documentation for this feature would be to list the limitations.

Can you offer some more guidance please, or perhaps take care of the documentation updates? I only have limited time left to spend on this and can't afford to spend time writing documentation that doesn't meet your unstated expectations.

Can you offer some more guidance please, or perhaps take care of the documentation updates? I only have limited time left to spend on this and can't afford to spend time writing documentation that doesn't meet your unstated expectations.

Sure, I can give you some more guidance. It's not 100% clear to me what information you are looking for. Are you asking about the type of content, the structure, how to organize? Here's what I would expect in general:

Describes the purpose of the new API (what problem does it solve)
Demonstrates the features of the API by example (the example code would be embedded into the text) e.g. https://github.com/gradle/gradle/issues/2402#issue-241067601
Explains limitations or what does not work yet e.g. https://github.com/gradle/gradle/issues/2402#issuecomment-313514094

Unfortunately, following Spring Boot's move back to subclassing JavaExec for its BootRun task, I no longer have a requirement motivating this change. As such, I can't justify spending any more time working on it. Sorry. I will leave it to the Gradle team to decide what should happen to the proposed changes. FWIW, I am happy for someone else to build upon my proposed changes if they wish to do so.


More idiomatic Python (WIP, TDD)

Closing for now. Seems that Python 2 translator handles next(iterator[, default]) incorrectly.


App Password not available in Custom Authentication Strength

Hi,
Though App Password is available as an option in My Sign-Ins:

It doesn't seem to be available as an authentication strength.
Any plans to have it included?
Thanks,

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 15fceb88-05e3-df67-6a00-3f72d50d391b
Version Independent ID: 15fceb88-05e3-df67-6a00-3f72d50d391b
Content: Overview of custom authentication strengths and advanced options for FIDO2 security keys and certificate-based authentication in Microsoft Entra ID - Microsoft Entra ID
Content Source: docs/identity/authentication/concept-authentication-strength-advanced-options.md
Service: active-directory
Sub-service: authentication
GitHub Login: @InbarckMS
Microsoft Alias: justinha

@haneef95
Thanks for your feedback! We will investigate and update as appropriate.

@haneef95
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.


[UI] Unstyled Privacy and Terms of Service Pages on the Tangle App

Is your UI update related to a problem? Please describe.
The Privacy Policy and Terms of Service pages of the Tangle website are unstyled.
Describe the solution you'd like (include image or link to prototype)
If we share these pages across the marketing pages. We should re-direct these pages to the existing pages on the webbsite app.

Privacy Policy: https://webb.tools/privacy-policy
Terms of Service: https://webb.tools/terms-and-conditions

Otherwise, if it needs new pages, fetch the new page's content from Notion, render it, and style them correctly.
Current page
https://github.com/webb-tools/webb-dapp/assets/60747384/da66b7a8-a236-411b-9c39-20d88a27bab6

Close in favor of https://github.com/webb-tools/webb-dapp/issues/1369.


Disabled LUA_NUMBER_INTEGRAL Ignored by LFS Image Build Step

Expected Behavior
lfs-image step should not attempt to build an integer image when app/include/user_config.h: #define LUA_NUMBER_INTEGRAL is commented-out.
Actual Behavior
lfs-image step ignores #define LUA_NUMBER_INTEGRAL and attempts to build the integer image. The attempt fails and throws an error:
docker run --rm -ti -e "IMAGE_NAME=test" -v "{PWD}":/opt/nodemcu-firmware -v "{PWD}":/opt/lua marcelstoer/nodemcu-build lfs-image

Adding files: ../lua/_init.lua ../lua/_main.lua ../lua/_preload.lua
creating LFS_float_test.img
creating LFS_integer_test.img
./luac.cross.int: ../lua/_main.lua:1: malformed number near '27.60'

Offending Source Code Line:
local BFCVAL = 27.60
References & Additional Notes
REF: https://github.com/marcelstoer/docker-nodemcu-build/

INTEGER_ONLY and FLOAT_ONLY are not supported anymore. Please configure LUA_NUMBER_INTEGRAL in app/include/user_config.h as described above.

app/include/user_config.h:
//#define LUA_NUMBER_INTEGRAL

The idea was to build an image for whatever versions of luac.cross are abailable in the source code root directory.
So you seem to have luac.cross for float builds and luac.cross.int left over from an int build.
As your sources contain floating point numbers which are not supported in int builds it fails.
I felt it was a good idea to build all available types.

you seem to have luac.cross for float builds and luac.cross.int left over from an int build.

Yup... that was it.  I removed the offending luac.cross.int file and I am no longer receiving the error.
I can't help but think that we could use some sort of housecleaning on the prior "Build the Firmware" step to remove old luac.cross[.int] files (if they exist) prior to starting a build.

Maybe you are right. At least it might be cleaned on make clean But that's rather to be discussed over at nodemcu-firmware.


Upgrade org.apache.commons:commons-text

Address https://github.com/NationalSecurityAgency/skills-service/security/dependabot/16

PR: #1720


about F1@50 accuracy

Dear Maintainer,
I have been using your GitHub repository to train a model and I have been able to achieve a maximum F1@50 accuracy of 79.26 using the provided code. However, I noticed that you have advertised a model with an F1@50 accuracy of 79.58, which I have been unable to replicate.
I was wondering if it would be possible for you to kindly provide me with the precise configuration utilized to train the model that attained the reported accuracy, along with any other pertinent information that could assist me in identifying where I may be encountering difficulties.
I would greatly appreciate any assistance you could provide in clarifying the parameters that contributed to achieving such exceptional results, and I look forward to hearing back from you.
Best regards

I came across a similar situation, I used resnet18 as a backbone, experimented on the tusimple database. The F1_score is 96.78, while the F1_score of the paper is 97.89. Are there some unknown tricks in training?


ONNX test code cleanup

Description
This PR refactors ONNX import/export test code
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes
Current directory structure:

Redundant code:

test_case list - The same test case list (almost) is present in both export and import
GluonBackendRep is available in import alone. This may become redundant when Gluon→ONNX export is added
mxnet_backend_test, onnx_backend_test, gluon_backend_test all have the same set of loops
mxnet_backend.py, backend.py - almost similar code
mxnet_export_test, onnx_import_test - test_models is redundant, there is scope for combining operator tests.

Changes that are part of cleanup:

Create tests/python-pytest/onnx/test_cases.py

IMPLEMENTED_OPERATORS_TEST = {'both' : [...], 'import': [...], 'export' : [...]}
BASIC_MODEL_TESTS = {'both' : [...], 'import': [...], 'export' : [...]}
STANDARD_MODEL = {'both' : [...], 'import': [...], 'export' : [...]}

Create onnx/mxnet_backend_test.py and onnx/gluon_backend_test.py for import/export with MXNet/Gluon backend respectively. These can't be combined further because the ONNX tests are added in globals() dictionary with test name as key. Combining these 2 will override the test list in globals().

Reference this newly created test_cases.py in mxnet_backend_test.py, onnx_backend_test.py, gluon_backend_test.py. Create a common onnx/backend_test.py for preparing the test list.

def prepare_tests(backend, operation):
    """
    Prepare the test list
    :param backend: mxnet/gluon backend
    :param operation: str. export or import
    :return: backend test list
    """
    ...
    ...

    return BACKEND_TESTS

Example call:
BACKEND_TESTS = backend_test.prepare_tests(mxnet_backend, 'import')

Instead of having separate MXNetBackend for MXNet import/export, GluonBackend for Gluon import, merge into one by either passing special params to prepare() or setting class variables

class MXNetBackend(Backend):
    """MXNet/Gluon backend for ONNX"""

    backend = 'mxnet'
    operation = 'import'

    @classmethod
    def set_params(cls, backend, operation):
        cls.backend = backend
        cls.operation = operation

@classmethod
    def prepare(cls, model, device='CPU', **kwargs):
        """For running end to end model(used for onnx test backend)

        Parameters
        ----------
        model  : onnx ModelProto object
            loaded onnx graph
        device : 'CPU'
            specifying device to run test on
        kwargs :
            other arguments

        Returns
        -------
        MXNetBackendRep : object
            Returns object of MXNetBackendRep class which will be in turn
            used to run inference on the input model and return the result for comparison.
        """
        backend = kwargs.get('backend', cls.backend)
        operation = kwargs.get('operation', cls.operation)
        ...

Option 1:
mxnet_backend.MXNetBackend.set_params('mxnet', 'export')

Option 2:
bkd_rep = backend.prepare(model, backend='mxnet', operation='export')

Move GluonBackendRep to onnx/backend_rep.py and access from Gluon backend.
Create a separate file onnx/test_models.py.

class TestModel(unittest.TestCase):
    """ Tests for models.
    Tests are dynamically added.
    Therefore edit test_models to add more tests.
    """
    def test_import_export(self):
        for test in test_cases:
            model_name, input_shape, output_shape = test
            with self.subTest(model_name):
                ...
                ...

To add tests for models, add a line in test_cases[]
test_cases = [
    (model name, input shape, output shape)
]

Example:
test_cases = [
    ("bvlc_googlenet", (1, 3, 224, 224), (1, 1000))
]

Create onnx/test_node.py for custom tests for operators (which are specific to MXNet or for which there are no tests in ONNX)

class TestNode(unittest.TestCase):
    """ Custom tests for operators.
    Tests are dynamically added.
    Therefore edit test_cases to add more tests.
    """
    def test_import_export(self):
        for test in test_cases:
            test_name, mxnet_op, onnx_name, inputs, attrs = test
            with self.subTest(test_name):
                ...
                ...

To add tests for operators,
# test_case = ("test_case_name", mxnet op, "ONNX_op_name", [input_list], attribute map, MXNet specific operator = True/False)
test_cases = [
    ("test_equal", mx.sym.broadcast_equal, "Equal", [get_rnd((1, 3, 4, 5)), get_rnd((1, 5))], {}, False),
    ("test_softmax", mx.sym.SoftmaxOutput, "Softmax", [get_rnd((1000, 1000)), get_rnd(1000)],
     {'ignore_label': 0, 'use_ignore': False}, True)

mxnet_export_test.py has all tests for MXNet to ONNX export

class TestExport(unittest.TestCase):
    """ Tests ONNX export."""
    def test_onnx_export_single_output(self):
        ...
    def test_onnx_export_multi_output(self):
        ...
    def test_onnx_export_list_shape(self):
        ...
    def test_onnx_export_extra_params(self):
        ...

Directory structure after cleanup:

Future work:

mxnet_backend_test, onnx_backend_test, gluon_backend_test could be merged together by writing our own test cases (https://github.com/onnx/onnx-tensorflow/blob/master/test/frontend/test_node.py), instead of ONNX tests

Comments

CI script has been updated

@mxnet-label-bot add [ONNX, pr-work-in-progress]

@mxnet-label-bot update [ONNX, pr-awaiting-review]
@Roshrini @anirudhacharya @zhreshold for review

@nswamy @anirudhacharya @safrooze - Going ahead with merging this PR as it contains nice clean up in test cases and with approvals from other community members.


Possibly switch from Windows x86 to x64

Yes it works under x86 and x64 but binaries only x86. Where is binaries for windows x64?

I didn't realize that 64-bit Chromium was better than 32-bit. I'll consider deprecating the 32-bit build if no one uses them.

I've decided to build both x86 and x64 binaries for now.


Tokenizer Format Question

The sample code uses random values to demonstrate functionality.
I'm unable to infer which tokenizer or module to use when I'm passing my own image via URL, local path, etc.
Same for defining simultaneous text input
e.g. describe any abnormalities in this image of the interior of the eye (URL to image of detaching retina)
Can you please either provide an additional example or help me understand what module I should be calling, format I should be using, etc.

 They have a history of copying / setting up fake repositories to boost their profile. For example they have copied the Tree of Thoughts repository and will not take their fake repo down. See the relevant discussion in the original repository and the fake repository.
It would be great if you could spread the word so that Github would take some action against them.

Reported; appreciate your diligence and specificity

@rabbidave Yes, the tokenizer to use should be GPTNeox, with the image embeddings passed in as special tokens.

@rabbidave And, you are extremely gullible you just obeyed his command without any sort of evidence or backings for his claim.

@kyegomez I provided evidence for your plagiarism, i.e. Tree of Thought (https://github.com/pypi/support/issues/2928). You have stolen from other projects as well, for example Sophia (https://github.com/kyegomez/Sophia/issues/27). @rabbidave is free to make his own conclusions.
You can delete this comment if you want but you have already developed a reputation in machine learning for intellectual theft. If you are indeed 19 years old, you might want to reconsider your path and use your skills to create your own original ideas instead of stealing from others.

@siavashk How did i plagiarize tree of thoughts? I implemented it faster than the original authors did.
And, I did copy code from Sophia because my code was worse than theirs and I didn't want people to use my bad code.
Pablo Picasso one of the best artists of all time is widely quoted as having said that “good artists borrow, great artists steal.”
Everybody steals.

I do not have anything else to say to you because I am not trying to convince you. I think there is enough information here for people to form their opinion.

@siavashk im very curious what do you think my intentions are? You know I'm doing this to advance our species right?
You're trying to discredit someone who works 24/7 to help Humanity, you should be ashamed of yourself.


fix: replace pat with default token in create release

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


STAR OPOS logo printing and Microsoft-tested devices

Please adjust the information related to the Star Printers and the OPOS drivers (maybe include a comment or something else), as they support PrintBitmap, whereas MPOS has only ever supported PrintMemoryBitmap. The difference is that their OPOS drivers require that the logo be set when we initialize the printer using ‘oposPrinter.setBitmap’. MPOS uses the newer ‘oposPrinter.printMemoryBitmap’ which passes along the file at the time of making the printing request, rather than loading into memory.
Additionally, please do note if the Tested peripherals are Recommended, as many people base their decisions on this article and specially on the "Microsoft-tested peripheral devices" list, as it seems they are proven to work Out-Of-The-Box. It is worth to mention somewhere if these tested scenarios fall under the "supported by Microsoft" scenarios.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a23ac4f5-a8fd-ce83-2f3e-0912d95579d9
Version Independent ID: 5a3bae91-72db-0e45-cd9b-2f68819fd148
Content: Retail peripherals
Content Source: articles/retail/retail-peripherals-overview.md
Service: dynamics-365-retail
Product: ****
Technology: ****
GitHub Login: @rubencdelgado
Microsoft Alias: rubendel

@sukkal63, thanks for posting here.
@rubencdelgado, please review and update the content, as needed.

addressed in PR and assigned bug to Sally to close.

The updates to the topic will be published today. Thanks.


Integration Tests for Dependents API

Tests that the dependents api:

Returns OK when packageId=DefaultPackage
Returns BadRequest when a package ID is not supplied (I implemented this as well, I think it makes sense TBH)

These are my first integration tests ever so let me know how I could improve! I want to add tests for the icon and readme endpoints but I guess you probably want to approve these first before I do that.

Thanks for adding these tests!

I implemented this as well, I think it makes sense TBH

Yup, agreed.

These are my first integration tests ever so let me know how I could improve!

These are perfect, nice work 😎


moved vendor directory to root

I expect vendor meant to be in root directory, not in public

that's right, yeah. Thx!


Feat/add pyvista code

Overview
Adds the code from PyVista related to image cache testing to the plugin. Here I expose what will be the main fixture of the plugin, verify_image_cache, which will check if the cached image and the generated figures are similar enough.
I also added the pre-commit files from PyVista, to have the same code format and rules.
Details

Removed lists with the name of the tests, now each test will declare if it can run on windows/MACos and if it is a high variance test

References
https://github.com/pyvista/pyvista/blob/main/tests/plotting/test_plotting.py

@AlejandroFernandezLuces , I would suggest to add a more descriptive title for the PR.


foreman not starting a service in Procfile

Here is my Procfile:
web: bundle exec rails server thin -p 8097
svc-moment: /web/svc-moment/bin/dev.sh

I've been using foreman on my current project for about a month or so, and it's been great. Then suddenly yesterday, svc-moment stopped coming up when I ran foreman start.
Running /web/svc-moment/bin/dev.sh in the shell works just fine, but foreman start svc-moment throws the following error:
/Users/khyland/.rvm/gems/ree-1.8.7-head@moment_admin/gems/foreman-0.25.0/lib/foreman/engine.rb:67:in `fork': undefined method `name' for nil:NilClass (NoMethodError)
	from /Users/khyland/.rvm/gems/ree-1.8.7-head@moment_admin/gems/foreman-0.25.0/lib/foreman/engine.rb:44:in `execute'
	from /Users/khyland/.rvm/gems/ree-1.8.7-head@moment_admin/gems/foreman-0.25.0/lib/foreman/cli.rb:21:in `start'
	from /Users/khyland/.rvm/gems/ree-1.8.7-head@moment_admin/gems/thor-0.14.6/lib/thor/task.rb:22:in `send'
	from /Users/khyland/.rvm/gems/ree-1.8.7-head@moment_admin/gems/thor-0.14.6/lib/thor/task.rb:22:in `run'
	from /Users/khyland/.rvm/gems/ree-1.8.7-head@moment_admin/gems/thor-0.14.6/lib/thor/invocation.rb:118:in `invoke_task'
	from /Users/khyland/.rvm/gems/ree-1.8.7-head@moment_admin/gems/thor-0.14.6/lib/thor.rb:263:in `dispatch'
	from /Users/khyland/.rvm/gems/ree-1.8.7-head@moment_admin/gems/thor-0.14.6/lib/thor/base.rb:389:in `start'
	from /Users/khyland/.rvm/gems/ree-1.8.7-head@moment_admin/gems/foreman-0.25.0/bin/foreman:7
	from /Users/khyland/.rvm/gems/ree-1.8.7-head@moment_admin/bin/foreman:19:in `load'
	from /Users/khyland/.rvm/gems/ree-1.8.7-head@moment_admin/bin/foreman:19

Obviously just a minor inconvenience for my workflow, but still confusing and I thought it'd probably be worth bringing up. Let me know if there's any other information I can provide.

Dashes are not allowed in process names which is why this isn't working. I've added some error checking when trying to start a process that doesnt exist.

Interesting. Thanks!


Add decorable serial iterator

Add decorable serial iterator.
Decorable serial iterator enables to modify the data in dataset before appending to batch.
Also enables to specify end of dataset index to support variable length such as batch for lstm training.

Coverage increased (+3.4%) to 86.01% when pulling f50a33f108dfb4f76f49567d66f707f51064aad0 on feature/decorable_iterator into 369e1397092779b924451246ebba3b05e1d61157 on master.


Editable - Implement remaining event handlers

Editable - Implement remaining event handlers.

Here are the event handlers present in slate-react's Editable component but missing in slate-solid:

onCopy
onCut
onPaste
onDragStart
onDrop
onSelect
onCompositionStart
onCompositionEnd
onCompositionUpdate

These handlers could be added to slate-solid for more complete functionality.


Resize/maximize does not work when running over X from Linux to Windows

Code 1.30.2 on Linux
I run MobaXTerm (10.9) on Windows 10
Just start the $ code .
used to work like a charm ... but now i can NOT resize the Application window at all.
it can however be minimized.

please see https://code.visualstudio.com/docs/setup/linux#_cannot-move-or-resize-the-window-while-x-forwarding-a-remote-window


Update Composer dependencies (2022-03-26-00-10)

Visual regression test passed!
View the visual regression test report