[NTR] several cell type terms to replace EFO terms

Stemming from https://github.com/EBISPOT/efo/issues/880.
These new CL terms are needed to replace EFO terms in Single Cell Expression Atlas anatomograms:
'central venous hepatic sinusoidal endothelial cell' http://www.ebi.ac.uk/efo/EFO_0010706
=> DONE, use CL:0019022 'endothelial cell of pericentral hepatic sinusoid'
'endometrial glandular epithelial cell' http://www.ebi.ac.uk/efo/EFO_0010710
=> DONE, use CL:0009084 'epithelial cell of endometrial gland'
'endothelial cell of respiratory system lymphatic vessel' http://www.ebi.ac.uk/efo/EFO_0010667
=> DONE, use CL:0009086 'endothelial cell of respiratory system lymphatic vessel'
'fused extravillous trophoblast' http://www.ebi.ac.uk/efo/EFO_0010712
=> DONE, use CL:0009087 'fused extravillous trophoblast'
'lung capillary endothelial cell' http://www.ebi.ac.uk/efo/EFO_0010668
=> DONE, use CL:4028001 'pulmonary capillary endothelial cell'
CL:4028001 was created very recently by Joshua Fortriede; I added an exact synonym of "lung capillary endothelial cell" to it.
'lung pericyte cell' http://www.ebi.ac.uk/efo/EFO_0010669
=> DONE, use CL:0009089 'lung pericyte'
'periportal hepatic sinusoidal endothelial cell' http://www.ebi.ac.uk/efo/EFO_0010705
=> DONE, use CL:0019021 'endothelial cell of periportal hepatic sinusoid'
'placental endothelial cell' http://www.ebi.ac.uk/efo/EFO_0010708
=> DONE, use CL:0009092 'endothelial cell of placenta'
'placental smooth muscle cell' http://www.ebi.ac.uk/efo/EFO_0010709
=> DONE, use CL:0009093 'smooth muscle cell of placenta'
'portal endothelial cell' http://www.ebi.ac.uk/efo/EFO_0010704
=> DONE, use CL:0009094 'endothelial cell of hepatic portal vein'
'uterine endothelial cell' http://www.ebi.ac.uk/efo/EFO_0010711
=> DONE, use CL:0009095 'endothelial cell of uterus'
(As of Feb 10th 2021, all CL IDs above are released live in CL)

[x] I'll check if any of these terms have been created in CL since then
[x] I'll add the location grouping tag where appropriate
[x] I'll copy any relevant annotation from the EFO terms
[x] I'll ask the SCA curators to provide references if needed (none were provided, so I'll go with ORCIDs)
[x] I'll add the SCA curators ORCIDs (Nancy's is https://orcid.org/0000-0003-4183-8865; Silvie's is https://orcid.org/0000-0003-3440-1876)
[x] I'll add the EFO IDs as xrefs to the new CL terms, as resolved (see https://github.com/obophenotype/cell-ontology/issues/932#issuecomment-795732369)
[ ] Warn SCA of pending obsoletion (some months)
[ ] Obsolete in EFO and add replaced_by tag pointing to Uberon/CL term
[ ] Remove CL xrefs to EFO terms when these are made obsolete?

@ngeorgeebi
@sfexova
Could you please provide references for the terms above? PMID, DOI, ISBN, Wikipedia...
Also your ORCID please,
Thanks
Paola

@dosumis
The label "extravillous trophoblast" is used in both CL and Uberon. I believe that the Uberon term was created first but I can't be sure - it doesn't have annotations, and there's no trace of label or ID in the Uberon GitHub tracker. The CL term was created by you last year for HCA, should it be labelled "extravillous trophoblast cell" and have an equivalence axiom pointing to the Uberon term? If so I'd also add the location_grouping subset tag. Thanks. I will then need to ask the SCEA curators what differentiates a 'fused extravillous trophoblast' from the CL term, because it doesn't have any annotation (http://www.ebi.ac.uk/efo/EFO_0010712).

@sfexova
Following up on the thread here about 'fused extravillous trophoblast' (http://www.ebi.ac.uk/efo/EFO_0010712), could you please confirm if this term is used in/needed for the placenta anatomogram? I tried looking for it in EA and SCEA, but I suspect that the search by experimental factor function may be broken. Looking for a placenta anatomogram, I could only find this one linked from an ExpressionAtlas Twitter post; it has 'extravillous trophoblast' but not 'fused extravillous trophoblast'.
No definition or references were provided for EFO_0010712 'fused extravillous trophoblast', there's only a note "Made as a placeholder for AE anatomagrams, term should be requested in UBERON.". So if we are to create a Uberon or CL term to represent this and replace the EFO term, we need more info please (see discussion with David above too).
If no info is available and 'fused extravillous trophoblast' is not needed for anatomograms, I wouldn't create a new term in Uberon or CL, and I'd tag the EFO term for obsoletion.
Thank you,
Paola

Thanks @sfexova .

Hi @sfexova ,
Following up on CL term requests for
'central venous hepatic sinusoidal endothelial cell'
'periportal hepatic sinusoidal endothelial cell'
'portal endothelial cell'
based on the reference you provided (https://www.nature.com/articles/s41467-018-06318-7 = PMID:30348985):
“We observed three endothelial cell populations…
The most abundant endothelial cell cluster … we propose that these endothelial cells are likely periportal LSECs (Zone 1).
The second most abundant endothelial cell population … we propose that this is an LSEC cluster that is central venous in origin (Zone 2/3).
where LSEC = liver sinusoidal endothelial cell.
Some terms were added by Maria Keays in Sept 2020 which I think fit the descriptions:
periportal LSECs (in paper) = 'periportal hepatic sinusoidal endothelial cell' (in your request) = CL:0019021 'endothelial cell of periportal hepatic sinusoid'
LSEC cluster that is central venous in origin = 'central venous hepatic sinusoidal endothelial cell' = CL:0019022 'endothelial cell of pericentral hepatic sinusoid' (has equivalence axiom “’endothelial cell of hepatic sinusoid' and ('adjacent to' some 'central vein of liver’)”)
As for 'portal endothelial cell’, do you mean “’endothelial cell' and ('part of' some ‘portal triad’)”? or “’part of' some ‘portal vein’”? The paper doesn’t help.
Please confirm that you can use the 2 existing CL terms, and the anatomical location that 'portal endothelial cell’ should refer to. Thanks.

On second thought, by 'portal endothelial cell’ you probably mean
’endothelial cell' and ('adjacent to' some 'hepatic portal vein')
but if that's the case, the term wouldn't be part of the liver in the SCA anatomogram. So perhaps
’endothelial cell' and ('part of' some liver) and ('adjacent to' some 'hepatic portal vein').

Unless you are defining a very broad grouping term (e.g. endothelial cell of liver) I think any endothelial cell needs to be part of some vein/vessel/sinusoid (or part of some endothelium of one of these) rather than directly part of the liver.  In this case I think that means either part of the sinusoid adjacent to the 'hepatic portal vein' (but isn't this =  'endothelial cell of periportal hepatic sinusoid' (added by Maria) AKA 'periportal hepatic sinusoidal endothelial cell' ?) or part of the vein itself.

Hi @dosumis ,

On second thought, by 'portal endothelial cell’ you probably mean
’endothelial cell' and ('adjacent to' some 'hepatic portal vein')
but if that's the case, the term wouldn't be part of the liver in the SCA anatomogram. So perhaps
’endothelial cell' and ('part of' some liver) and ('adjacent to' some 'hepatic portal vein').

Unless you are defining a very broad grouping term (e.g. endothelial cell of liver) I think any endothelial cell needs to be part of some vein/vessel/sinusoid (or part of some endothelium of one of these) rather than directly part of the liver. In this case I think that means either part of the sinusoid adjacent to the 'hepatic portal vein' (but isn't this = 'endothelial cell of periportal hepatic sinusoid' (added by Maria) AKA 'periportal hepatic sinusoidal endothelial cell' ?) or part of the vein itself.

Yep, thanks. The existing term 'endothelial cell of periportal hepatic sinusoid' is Equivalent To
'endothelial cell of hepatic sinusoid' and ('adjacent to' some 'portal triad').
So I think the term @sfexova needs for 'portal endothelial cell’ should be Equivalent To
’endothelial cell' and (’part of' some ‘hepatic portal vein’)
and should in fact be labelled, for consistency and completeness, 'endothelial cell of hepatic portal vein', with 'portal endothelial cell’ as a broad synonym. Let me know if you have any objection.

Added CL_0009084 (epithelial cell of endometrial gland)
More soon(ish).

Hi @sfexova ,
I hope all's well. FYI, I finished adding CL terms for SCA to replace the previous EFO terms. The new CL IDs are in https://github.com/obophenotype/cell-ontology/issues/932#issue-803754398.

Note to self: I'm not closing this ticket yet, due to the last 3 checkpoints in https://github.com/obophenotype/cell-ontology/issues/932#issue-803754398.

Note to self: the CL side of the work is complete; the EFO side is reported elsewhere. So I'll close.


optionally process AWS Organization (member) accounts

Description
Accept an org parameter to size AWS Member Accounts attached to an AWS Organization.
Based upon code written by Adam Clark.
Also, corrects an error resetting IFS
Motivation and Context

Target Company has many AWS accounts, where executing a script against individual single accounts may be impossible or an unreasonable task.
Target Company is using the AWS Organizations functionality, and has provisioned their AWS accounts as member accounts within that organization.

How Has This Been Tested?
Original functionality tested.
AWS Organization untested (I have no access to one)
Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[ ] All new and existing tests passed.

FWIW: I cannot set a "Do Not Merge" (until tested) label 🤷🏻♂

 tkishel  ~  Code  pcs-sizing-scripts  shellspec spec/aws_resource-count-aws.sh
Running: /bin/sh [bash 3.2.57(1)-release]
............

Finished in 4.45 seconds (user 3.84 seconds, sys 0.70 seconds)
12 examples, 0 failures

Testing: I've added spec tests, covering each function in the script (and refactored the script to use functions: for all but parsing the one optional org parameter, and the jq check) ... including all of the aws commands. For the mocking of those commands, I used the example output from the AWS CLI documentation for each command.
Documentation: I don't have the source of the PDF to update it, but the optional org parameter is documented via a comment.


Disable gke alpha clusters and bump k8s version to 1.14

Disable gke alpha clusters and bump k8s version to 1.14
Resolves #824

Codecov Report

Merging #825 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   53.45%   53.45%
=======================================
  Files          56       56
  Lines        2215     2215
  Branches      218      218
=======================================
  Hits         1184     1184
  Misses        980      980
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5c3f4...1c78834. Read the comment docs.


Add Kafka backing for tracker

See also: #8

@alexanderdean What is the status of the Kafka backend? It seems rather odd that you talked about a Kafka backend over a year ago on various social media and that nothing appears to have happened on this front.

Hey @aragnon! Yes, we're still planning a Kafka implementation for Snowplow - we hope to get some time next year to spend on this. Are you interested in working on it?

Hi, I was wondering to know what's the current status of Kafka sink for Scala Collector? Do you plan to add it soon? We're thinking of switching to Snowplow for our data pipeline, but using Kinesis is not an option for us. I noticed there has been ongoing work on#981 for some time.
We're also ready to implement this feature.
@fnozarian

Hey @ssheikholeslami - yes we are still planning to release this. We hope to get out an RFC on Discourse discussing the plan for Kafka support soon. Are you keen to work on this feature?

Absolutely, and it would really help if you could point me to some material for starting up fast.
I've already created an account on Discourse.

@alexanderdean I'm actually waiting for an update from your side :D

This isn't part of the roadmap any more.
The Snowplow collector, however, does work with Kafka. As can Stream Enrich.


View App Availability Outside of Accrescent

Is there currently a way to view which apps are available outside of using the actual Accrescent app? It would be nice to see what apps are in Accrescent without having it installed.

There isn't one currently, but it's planned. The tracking issue is https://github.com/accrescent/meta/issues/11.


build-snapshot: updated MethodOwner annotation

1.removed secondaryOwner property
2.organized MethodOwner filtering by platform
3.updated testMethodOwner

6.1.511-SNAPSHOT


Assertions, sid, and kid updates

Proposed Changes

Checklist

[ ] A clear description of the change has been included in this PR.
[ ] A clear description of whether this change is a Major, Minor, Patch or cosmetic change as per the Versioning Guidelines has been included in this PR.
[ ] All schema validation tests have been updated appropriately and are passing.
[ ] MAJOR/MINOR VERSION CHANGES ONLY: This PR should be made in branches prefixed with draft-<change>
[ ] MAJOR/MINOR VERSION CHANGES ONLY: A link to a reference implementation (PR or set of PRs) of the change has been included in this PR.
[ ] MAJOR/MINOR VERSION CHANGES ONLY: A writeup has been included discussing the motivation and impact of this change.
[ ] MAJOR/MINOR VERSION CHANGES ONLY: The minimum wait time has elapsed.
[ ] DRAFT MERGE ONLY: Draft Semver has been updated in the VERSION file (optional)
[ ] DRAFT MERGE ONLY: Tagged this branch with new semver version and an annotation describing the change (ex: git tag -s 4.1.0 -m "Spec version 4.1.0 - did a thing")
[ ] DRAFT MERGE ONLY: Version numbers have been updated as per the Versioning Guidelines.
[ ] This change otherwise adheres to the project Contribution Guidelines.

we will incorporate the changes in https://github.com/opentdf/spec/pull/32 in this pr.


Added new Items, WIki Links and fixed some stuff

cant remember what i did just look at files
thanks unconsciousself for the slayer stuff

bruh


OIDC support

This PR add OIDC support.
matrix.thirdroom.io is statically registered with id.thirdroom.io . Dynamic registration with OIDC Provider is not support but it will fallback to legacy password based login if supported by homeserver else shows an error.
This require aj-oidc branch of sdk.
Fixes #121

I've merged the dependent PR into the thirdroom/dev hydrogen-view-sdk branch. We're getting an error with the redirect_uri on staging though. Do we need to allow the staging url or is there something else we're missing?


Hey should 'correct' only be if the final prediction was correct? Same for accuracy?

https://github.com/jefflai108/Contrastive-Predictive-Coding-PyTorch/blob/a9dab4e759aaa68dce1b1ada46a8035076ba3296/src/model/model.py#L100
Meaning, should that correct variable be += ?

I noticed that too.
I think you're right, and after the loop over the timesteps, the sum should be divided by batch_size*num_of_timesteps.

I noticed that too.
I think you're right, and after the loop over the timesteps, the sum should be divided by batch_size*num_of_timesteps.


Commenting first example.

This is first chip for #942.
Please review :-)

I understand I need to push a new branch with signed commits.


[BUG]

Reproduction steps
im facing error will start the building of the esp32 examples.
steps:

activate the esp-idf v5.1 environment.
activate the  connectedhomeip environment.
3)move to examples/all-clusters-app/esp32.
4)idfy.py set-target esp32 (problem - stuck ).

set-target esp32_error.TXT
does any python dependencies im missing for build ?
please let me know ..
Bug prevalence
always
GitHub hash of the SDK that was being used
7353fd6cab156b2f5cf5ca432f005cf33312a1fe
Platform
esp32
Platform Version(s)
No response
Anything else?
@shubhamdp  @bzbarsky-apple  please comment.

https://github.com/project-chip/connectedhomeip/issues/27653#issuecomment-1635375210

@aravindone Please stop pinging me on all esp32 issues.

Ok @bzbarsky-apple

from https://github.com/project-chip/connectedhomeip/issues/27653#issuecomment-1635375210
is working fine im closing this ticket thanks.
@shubhamdp


Allow auto insertion of gist stylesheets

Closes #44

Hi
Thanks for the PR.
With this changes, we will include the same stylesheet multiple times even when we have more than one gist on one page - right?
For me, it's ok, but google lighthouse will not like it ;)
If you have any thoughts how to solve it, feel free to add it.
Maybe we have a chance to implement it, if we can add the stylesheet load at the time, when the plugin/class will be initialized.


[backport] Use LinkTestCase for L.GroupNormalization

Backport of #8343

[automatic post] Jenkins, test this please.

There was a conflict but used #8343's version entirely.

There was a conflict but used #8343's version entirely. (b64126b)

:+1: because the conflict is just https://github.com/chainer/chainer/pull/8058/files#diff-8bd55391c2f2170bdb73f6c652d727c9.

Jenkins CI test (for commit b64126bdb5799d8fc45f76cc102efb3d34119242, target branch v6) succeeded!

Jenkins, test this please.

Jenkins CI test (for commit b64126bdb5799d8fc45f76cc102efb3d34119242, target branch v6) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit b64126bdb5799d8fc45f76cc102efb3d34119242, target branch v6) succeeded!


Improvements: Create an approval mechanism to make the tool on pair with Zero downtime function

One of the ideas is to make this tool on pair with the Zero downtime function in terms of security(where you have 2 users that approve the script)
On a high level I see it like this(but it is something discussable):

Create a new mode (e.g. restrictive mode, that requires approval, it can be for example URL based and extensible)
Create 2 fields in the script table (The user who saved the script, User who approved the script)
Do not allow Execute script without save
When pressing Execute, validate that "User who approved the script" populated
When pressing Save - clean "User who approved" field

I like the Idea of having restrictions on having control on who can execute what. Do you think we can take advantage of standard workflow features? Also, I would make this as optional by default Active in production.

Thanks.
For workflow, I don't see any reason to spend time on this; if something is so complex that it requires workflow, they will not allow your tool on the project at all. This should be just the simplest possible function to have some arguments with management or MS reviews.
Also, it should be possible to switch off it on PROD(e.g. via some code change), as for most projects it will not be required

Would it make sense to also implement the same temporary transaction logic as the standard custom script functionality?
For example, the first run would abort the transaction, allowing the approver to review the dictionary changes, and then approve the script.

@jofme  - but what will be a usage scenario? if you want to implement a demo mode for your script - just introduce a variable, ask it's value in the dialog and put something like this
if (updateMode)
{
myRecord.Update()
}
else
{
info ("record AA is updated from A to B");
}
also you can run in ttsabort already

It's an aid for the reviewer when running with the restricted mode enabled.
Let's say that the call makes additional updates, like when a project changes status; That is not caught by the info message. It would be visible for the reviewer immediately, instead of having to dig deeper into the code.
I'm aware that it could be considered bike shedding.
The use case is different from the ttsabort flag when you execute a script.

@jofme What I'm understanding on what you said, basically the reviewer should execute the script in a temporary transaction. What information should we provide to the reviewer in order to analyze it's output?
Also, the Microsoft approach to this is to execute the script once, which makes sense to have it review one time with one expected output, but for our scenario I see It difficult as the script will remain in the repository. Maybe the solution is to, for each execution that must be done to the script, a review (or approve) of the execution must be done?

@milnet92 I'm thinking of providing the approver with deleted, created and updated records, to know more the consequences of running a script in TEST or UAT environments.
My question is if it would make sense to have feature-parity with the Microsoft approach (and spend time on it), but I follow the point that this is not a replacement for the Microsoft solution so it might not make sense.
Approval for execution might be a bit overkill... But I think a single approval of a script is fine. That is enough for me to be comfortable installing it in my environments.

Thank you both for the comments and suggestions :) Let's do something then, if someone can implement the simple approval process that @TrudAX suggested, I'll try to add the additional step of recording telemetry (no idea how yet) and executing script without database effects to report the changes to the reviewer.

Sounds like a plan, thanks 😊
I'm stuck at a campsite without my computer right now, but I can look at the simple approval step on Sunday if it's okay.


Release 2.1.74

On the docket:

[ ] ...

Maybe:

[ ] Decouple PEX runtime interpreter selection from buildtime interpreter selection. #1020

Unlikely / backlog:

[ ] PEX_INHERIT_PATH+default shebangs don't interact well with virtualenvs #1344
[ ] Pex interpreter cache is not upgrade / downgrade safe. #1176
[ ] Provide a better resolve error message for a Platform DistributionTarget when --resolve-local-platforms. #1070
[ ] Remove PEX_PYTHON_PATH from build time interpreter selection. #1075

Split off from "Release 2.1.73 #1670" to make way for a fix for --lock resolves where the lock has wheel artifacts with build-tags (#1676).


Unable to restart the tour once final step has reached

Is there any way the tour can be restarted once the final step is hit? Also, the start tour in the demo seems not working.
Tried disabling the cookie.

I've accomplished "restart" of tour by manually setting the currentStep to 0.


Invalid additional property "writeCriteria"

Description
Hey, thanks for your awesome work! While playing around with medplum, I ran into an issue with write criterias.
Steps to reproduce
I am using this example: https://www.medplum.com/docs/auth/access-control#criteria-based-access-control

New Accesspolicy

Name: "Write Constraints Access Policy"
Resource Type: "Observation"

Write Criteria Pre: "%before.exists() implies %before.status != 'final'"

Error
{
    "resourceType": "OperationOutcome",
    "issue": [
        {
            "severity": "error",
            "code": "structure",
            "details": {
                "text": "Invalid additional property \"writeCriteria\""
            },
            "expression": [
                "AccessPolicy.resource.writeCriteria"
            ]
        }
    ]
}

There is no documentation about how to enter the correct expressions. I tried different formatting, however there is always the same error message. (Even sometimes when the field is blank after there was an error in the first place)
Others

Editing the json seems to work, however the accesspolicies seems not to work. I added this expression to make sure the user cannot delete a list resource:

{
  "resourceType": "AccessPolicy",
  "name": "List Write Constraints Access Policy",
  "resource": [
    {
      "resourceType": "List",
      "writeConstraint": [
        {
          "language": "text/fhirpath",
          "expression": "%before.exists() implies %before.status != 'completed'"
        }
      ]
    }
  ]
}

However it is still possible for the user to delete the resource.

The write contstraint feature seems to be very powerful. It would be nice if it can be more granular as a developer i want to allow users to update resource, however i do not want to delete the same resource.

Hi @nikzen - did you perhaps mean to use writeConstraint rather than writeCriteria?  I suspect that's the issue.
It'd be neat if we could detect this kind of thing and provide a more useful error message.  Something like
$ git statu
git: 'statu' is not a git command. See 'git --help'.

The most similar commands are
        status
        stage
        stash

Hi @codyebberson, yes you are right. I mixed it up, as the UI displays Write Criteria.


Material resource loader does not load texture dependencies first

If you load a material downloaded from the Editor via loadFromUrl, the texture dependencies are not loaded first. Unlike the model resource loader, which does load all material and texture dependencies correctly.

I would very much like to see this prioritized as well.

Is there any solution?


Fix typos discovered by codespell in #68

#68

Hi @cclauss, please pull main once.

Hi @cclauss: Thank you for the PR. Please pull the latest code and if possible, run your tool against the entire repository. There might be more typos. Since this is not a filter/transformation, you can take your time with the changes.

Given that this PR now touches 50 files, it is better not to let it linger too long or conflicts will arise.


Added a beta release branch

This gives us the ability to have beta releases.
The beta GitHub action is based on the unstable.yml workflow. I'm not entirely sure how to test this locally - hopefully if there's any errors they'll be picked up in review 🤞.

There is act but I haven't tried this out myself yet. I just usually run the actions on the fork I am working on. Maybe fork the project and run it there to see if it works fine.

There is act but I haven't tried this out myself yet. I just usually run the actions on the fork I am working on. Maybe fork the project and run it there to see if it works fine.

There is act but I haven't tried this out myself yet. I just usually run the actions on the fork I am working on. Maybe fork the project and run it there to see if it works fine.

There is act but I haven't tried this out myself yet. I just usually run the actions on the fork I am working on. Maybe fork the project and run it there to see if it works fine.


Create test_mozilla_org

Draft file, pending L10n PM review.

One more note: can you add a link to this document in the README for mozilla.org?
https://github.com/mozilla-l10n/documentation/blob/master/products/mozilla_org/README.md

I've realized there's one more info missing: how often we get data from Pootle and Pontoon, how often the dashboard and dev server update.


Navigation component: NPE when any page has special redirect target

When using the redirect target in the page component to redirect to an external page or to an internal page with additional selectors a NullPointerException is generated here on the NavigationImpl class:
private boolean currentPageIsRedirectTarget(Page page) {
[...]
Page redirectPage = pageManager.getPage(redirectTarget);
--> if (redirectPage.equals(this.currentPage)) { <--
Maybe the logic should be reversed (e.g. this.currentPage.equals...) to avoid crashing the component in these scenarios?

supplied fix and test for it.

@msagolj, please also cherry-pick the fix to master branch!


[Move] Infra Escrow and PledgedAccounts

PledgeAccounts

[x] struct initialization on beneficiary project, and user accounts
[x] deposit and pledge
[x] beneficiary withdraw
[x] logic for voting on dissolving/revoking pledge
[x] use coins from accounts (not integers from scaffold)
[x] transactional tests

[x] init
[x] deposit
[x] withdraw
[x] dissolve

Infrastructure Escrow

[x] refactor epoch boundary
[x] refactor validator rewards
[x] refactor burn mechanism
[x] VM initializes on genesis
[x] VM withdraws
[x] helper script for user to pledge
[x] transactional tests

[x] init on genesis
[x] withdraw on epoch boundary

I'm having issue building the binaries of this branch.
   Compiling executor-benchmark v0.1.0 (/root/libra/execution/executor-benchmark)
   Compiling state-sync-multiplexer v0.1.0 (/root/libra/state-sync/state-sync-v2/state-sync-multiplexer)
   Compiling ol v5.2.0 (/root/libra/ol/cli)
   Compiling diem-api v0.1.0 (/root/libra/api)
   Compiling txs v5.2.0 (/root/libra/ol/txs)
error[E0425]: cannot find function `encode_self_unjail_script_function` in module `transaction_builder`
    --> ol/txs/src/commands/valset_cmd.rs:39:34
     |
39   |             transaction_builder::encode_self_unjail_script_function()
     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `encode_voucher_unjail_script_function`
     |
    ::: /root/libra/sdk/transaction-builder/src/stdlib.rs:6811:1
     |
6811 | pub fn encode_voucher_unjail_script_function(addr: AccountAddress) -> TransactionPayload {
     | ---------------------------------------------------------------------------------------- similarly named function `encode_voucher_unjail_script_function` defined here

warning: ignoring -C extra-filename flag due to -o flag

For more information about this error, try `rustc --explain E0425`.
warning: `txs` (lib) generated 1 warning
error: could not compile `txs` due to previous error; 1 warning emitted
warning: build failed, waiting for other jobs to finish...
error: build failed
make: *** [Makefile:93: bins] Error 101
The command '/bin/sh -c RUSTC_WRAPPER=sccache make bins' returned a non-zero code: 2

Incredible 👍🏼

I wish I could review this better. I tried to build again from https://github.com/0LNetworkCommunity/libra/commit/a38a07216c013086ca66072637787a2cfa606c17 and got the same error. Not sure this is a real issue. But @sirouk and I would use a docker image to set up the testnet. As it is now, this image can't be built.

I'm having issue building the binaries of this branch.

Yeah you'll need to build stdlib again: from root: sh ol/util/build_stdlib.sh

@hemulin
Start in PledgeAccounts
https://github.com/0LNetworkCommunity/libra/pull/1236/files#diff-cf584d0dbf812d6fc61acddcdf686c37bcde9d95914f15744f3b83edc62ad0f4
And then InfrastructureEscrow
https://github.com/0LNetworkCommunity/libra/pull/1236/files#diff-72e528c00ee4f636bbbca7cce49625c22feaf3210368226bd41dd0c010595186

Closing due to changes included #1261


[#152507627] Upgrade cflinuxfs2 and stemcells for CVEs

What
Upgrade stemcell for CVEs
To fix the following:

https://www.cloudfoundry.org/usn-3424-1/
https://www.cloudfoundry.org/usn-3434-1/
https://www.cloudfoundry.org/usn-3444-2/
https://www.cloudfoundry.org/usn-3454-1/
https://www.cloudfoundry.org/usn-3441-1/
https://www.cloudfoundry.org/usn-3432-1/

They all reference the same minimum version of 3445.15 (for the stemcell
series that we're using).
Upgrade cflinuxfs2 for CVEs
To fix the following:

https://www.cloudfoundry.org/usn-3454-1/
https://www.cloudfoundry.org/usn-3424-1/
https://www.cloudfoundry.org/usn-3434-1/
https://www.cloudfoundry.org/usn-3441-1/
https://www.cloudfoundry.org/usn-3432-1/
https://www.cloudfoundry.org/usn-3437-1/

Version 1.161.0 is the minimum specified by USN-3454-1, whereas the other
advisories reference older versions.
How to review
I've run this in my dev environment. All acceptance tests passed, but it causes downtime for UAA which we intend to fix in #1086 and #1087:
Report:
==============
Total task executions: 30139
Total Successes: 29807
Total failures: 332
Elaspsed time: 1h20m22.90782056s
Average rate: 6.25 tasks/sec

Based on the contents of the CVEs (mostly denial of service) I don't have a strong opinion about whether we deploy with some downtime or wait for the UAA changes to be deployed first.
It took over an hour to test in my dev environment, so I don't think there's value in a second person repeating the same exercise and that code review from hereon would be sufficient:

check that I've upgraded the right components according to those CVEs
check that I've selected the right versions according to those CVEs

Who can review
Anyone.

:+1: Looks good to me. I'm going to merge this after #1086 and #1087 have been deployed.

A note: the cflinuxfs2 upgrade also fixes USN-3438-1 (there is no CloudFoundry security update about this). See https://github.com/cloudfoundry/cflinuxfs2/releases/tag/1.159.0

USN-3424-1 was already fixed in our previous cflinuxfs2 version (1.156.0)


.content instance is the same across multiple cached responses (for in-memory backend)

The problem
All cached responses are the same instance, shared across all consumers. This can have unexpected side effects when using the client cached responses without special precaution. For a normal user this is ok, but when adding cache capabilities to existing libraries by passing a CachedSession() instead of a normal aiohttp session this can be hard to fix for the developer.
Notably this effects the .content response stream. It can only be read by the first and second request (i am assuming the first response is the original one, the second one is the cached object. see steps to reproduce below). All further .content.read() calls result in an empty string.
Expected behavior
Be able to call content.read() on subsequent cached responses, and have an identical result.
Steps to reproduce the behavior
Here is an example:
In [1]: from aiohttp_client_cache import CachedSession, CacheBackend
In [2]: session = CachedSession(cache=CacheBackend(cache_control=True))

# First response seems to be then not-cached response
In [3]: original_response = await session.get("https://example.com/")
In [4]: await original_response.content.read()
Out[4]: b'<!doctype html>\n<html>\n<head>\n    <title>Example Domain</title>\n\n    <meta charset="utf-8...

# second response is the cached response, we now fully read the content stream
In [5]: cached_response1 = await session.get("https://example.com/")
In [6]: await cached_response1.content.read()
Out[6]: b'<!doctype html>\n<html>\n<head>\n    <title>Example Domain</title>\n\n    <meta charset="utf-8...

# second response the identical object to the first response
In [7]: cached_response1 = await session.get("https://example.com/")
In [8]: cached_response1 is cached_response2
Out[8]: True

# now the stream was already fully read, and is empty
In [6]: await cached_response2.content.read()
Out[7]: b''

Workarounds
Outside library workaround
When using the response on your own you can reset the private _content variable so a new stream is generated:
response = await session.get("https://example.com/")
response._content = None

Inside library workaround
return a new CachedStreamReader() every time .content is accessed.
BUT NOTE: it is not a perfect replication of the actual behavior to an original response. In this case the behavior of calling response.content.read(10) twice would be different to a not-cached response. The cached response would always start from the beginning, while an original response would read the first 10 bytes the first time, and the second time it would read bytes 10-20.
Environment

aiohttp-client-cache version: 0.8.2
Python version: 3.11
Platform: Ubuntu 22.04 LTS

Thanks for the bug report. I already fixed similar behavior with the in-memory backend in requests-cache, so it should be easy enough to fix it for this library as well.

Fixed in v0.9.


PlayCookieSessionStore doesn't handle incompatible data

After upgrading from version 7 to 10 we've been having errors with this logged stacktrace:
play.api.UnexpectedException: Unexpected exception[NullPointerException: null]
	at play.api.http.HttpErrorHandlerExceptions$.throwableToUsefulException(HttpErrorHandler.scala:331)
	at play.api.http.DefaultHttpErrorHandler.onServerError(HttpErrorHandler.scala:253)
	at play.core.server.AkkaHttpServer$$anonfun$2.applyOrElse(AkkaHttpServer.scala:424)
	at play.core.server.AkkaHttpServer$$anonfun$2.applyOrElse(AkkaHttpServer.scala:420)
	at scala.concurrent.impl.Promise$Transformation.run(Promise.scala:453)
Caused by: java.lang.NullPointerException: null
	at java.util.Objects.requireNonNull(Objects.java:203)
	at java.util.Optional.<init>(Optional.java:96)
	at java.util.Optional.of(Optional.java:108)
	at org.pac4j.play.store.PlayCookieSessionStore.get(PlayCookieSessionStore.java:62)
	at org.pac4j.play.store.PlayCookieSessionStore.get(PlayCookieSessionStore.java:29)
2020-04-24 12:47:03,068 [application-akka.actor.default-dispatcher-185] WARN  o.p.c.u.JavaSerializationHelper - cannot Java deserialize object
java.io.InvalidClassException: org.pac4j.core.profile.UserProfile; local class incompatible: stream classdesc serialVersionUID =<PHONE_NUMBER>664816338, local class serialVersionUID =<PHONE_NUMBER>30751610
	at java.io.ObjectStreamClass.initNonProxy(ObjectStreamClass.java:699)
	at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1885)
	at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1751)
	at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1885)
	at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1751)

As the stacktrace points, this is caused by the stored cookie session data not being compatible between the two versions due to the java serialization.
A simple solution could be changing PlayCookieSessionStore line 62 from return Optional.of(value); to return Optional.ofNullable(value); and letting the remaining logic reauthenticate the user.
For now, as a workaround to the issue, we've changed the session cookie name to a new one, forcing reauthentication with correct data values.

Thanks for reporting. It should be fixed in version 10.0.1-SNAPSHOT: can you try and confirm? Thx

Apologies for the late response. While it solved the original problem it appears there's still some data inconsistency when it goes for the re-authentication step.
Caused by: org.pac4j.core.exception.TechnicalException: State parameter is different from the one sent in authentication request. Session expired or possible threat of cross-site request forgery
	at org.pac4j.oidc.credentials.extractor.OidcExtractor.extract(OidcExtractor.java:101)
	at org.pac4j.core.client.BaseClient.retrieveCredentials(BaseClient.java:61)
	at org.pac4j.core.client.IndirectClient.getCredentials(IndirectClient.java:140)
	at org.pac4j.core.engine.DefaultCallbackLogic.perform(DefaultCallbackLogic.java:81)
	at org.pac4j.play.CallbackController.lambda$callback$0(CallbackController.java:54)
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604)

On my particular case I noted that cookie attempting to be set just before the redirect is way beyond the allowed cookie size limit, at around 6.9kB. The existing cookie (set by the legacy version, 7.0 in my case) was already near it, at 3.9kB.

This is very strange. I kept the original algorithm and the renamed removeLoginData method should now remove the ID token thus the final cookie size should be smaller.
I will investigate.

I cannot reproduce your issue.
Testing the play-pac4j-scala demo v7, I have:

profile serialized: 2456 bytes, cookie size: 3976 bytes

With v10, I have:

profile serialized: 1348 bytes, cookie size: 2744 bytes

Exactly, the behavior I expected.
Can you investigate on your side?


Use constraint Layout in all layout files instead of Relative, Linear Layouts.

Describe the feature you'd like
Use constraint Layout in all layout files instead of Relative, Linear Layouts to improve app performance by reducing the number of nested layouts.
This is the parent issue. There will be multiple sub-issues for each activity/fragment.
Would you like to work on the issue?
No.

@ujjwalagrawal17  can I start working on this?

@kulloveth can you create a sub-issue in which page you want to work. We will work on the pages one by one instead of all in 1 PR.

I am an outreachy applicant and would love to work on this issue. How do i create a sub issue? @ujjwalagrawal17

It is done in all of the layouts so closing this issue.


NTR: Wastewater treatment plant

Proposed Term Label
Wastewater treatment plant
Proposed Associated Field(s)
environmental site
Definition/Description
A plant in which wastewater is treated.
Definition Source
No response
Guidance
No response
Alternative labels and/or synonyms
No response
Additional Comments (not an annotation)
Existing term ENVO:00002272. Currently in other specs (including WW). From discussion between EG and CB on 7/8/24
Optional - Contributor Attribution
No response

Also add plumbing drain

PR #96


Fix/expose volume type

:gear: Issue

The volume type "gp3" isn't currently supported in AWS launch configurations in all regions.
See here for more info
:white_check_mark: Fix

swapped the hardcoded volume-type for a variable which an operator may update
Notes:
Left the default value as gp3 in case there are any existing clusters with this volume type.

Looks good. Should also add it to the inputs section of the readme: https://github.com/CircleCI-Public/server-terraform/tree/main/nomad-aws#inputs

ah! good catch. lemme do that


Question about results

Hello, thanks for your amazing work. I'm also interested in training a JEPA-model for chess and other board games. Did you get any results?

I kind of had to pause this. I kind of expect the results to be in the ballpark for this paper: https://arxiv.org/abs/2402.04494 if there is no search component. JEPA in my view is a compute optimization. It doesn't fundamentally change the learning task. There is probably a mix of memorization/generalization taking place.


idb ::  connection closed by remote host

hi,
iphone6(iOS9.1 ),  isn't install Cydia , iphone4(6.1.2), install Cydia.
iphone6 log:---------------------------------------------------------
Error connecting to device!
[ERROR] 2015-12-23 14:44:38 :: idb ::  connection closed by remote host
2015-12-23 14:47:18.967 ruby[85189:7066478] modalSession has been exited prematurely - check for a reentrant call to endModalSession:
[DEBUG] 2015-12-23 14:47:18 :: idb ::  opening port 51679 for manual ssh connection
[INFO] 2015-12-23 14:47:18 :: idb ::  Launching SSH proxy on port 2222
[DEBUG] 2015-12-23 14:47:18 :: idb ::  opening tool port 51728 for internal ssh connection
[INFO] 2015-12-23 14:47:18 :: idb ::  Launching SSH proxy on port 51728
bind(): Address already in use
Error creating socket: Address already in use
[ERROR] 2015-12-23 14:47:18 :: idb ::  Unsupported iOS Version.
iphone4 log:--------------------------------------------------------------
waiting for connection
[DEBUG] 2015-12-23 15:50:28 :: idb ::  Connecting via USB
[DEBUG] 2015-12-23 15:50:28 :: idb ::  Using port 52086 for SSH forwarding
[INFO] 2015-12-23 15:50:28 :: idb ::  Launching SSH proxy on port 52086
waiting for connection
[INFO] 2015-12-23 15:50:29 :: idb ::  Establishing SSH Session for root@localhost:52086
accepted connection, fd = 4
waiting for connection
Number of available devices == 1
Requesting connecion to device handle == 19 (serial: 4f1df4a22008f0516a70ed2467312473e641ac91), port 22
Error connecting to device!
[ERROR] 2015-12-23 15:50:29 :: idb ::  connection closed by remote host
2015-12-23 15:55:14.546 ruby[85433:7286381] modalSession has been exited prematurely - check for a reentrant call to endModalSession:
[DEBUG] 2015-12-23 15:55:14 :: idb ::  opening port 52086 for manual ssh connection
[INFO] 2015-12-23 15:55:14 :: idb ::  Launching SSH proxy on port 2222
[DEBUG] 2015-12-23 15:55:14 :: idb ::  opening tool port 52088 for internal ssh connection
[INFO] 2015-12-23 15:55:14 :: idb ::  Launching SSH proxy on port 52088
bind(): Address already in use
Error creating socket: Address already in use
[ERROR] 2015-12-23 15:55:14 :: idb ::  Unsupported iOS Version.

Is it possible that you had idb running before and it crashed? Check the output of ps to see if you have any instances of iproxy running. It could be that an old process is running and blocking the port.
Also, are you sure you have the SSH daemon running on the device?

thanks，

@dmayer I am getting the following error while connecting to a device.

[DEBUG] 2017-09-14 13:45:29 :: idb ::  Connecting via USB
[DEBUG] 2017-09-14 13:45:29 :: idb ::  Using port 65434 for SSH forwarding
[INFO] 2017-09-14 13:45:29 :: idb ::  Launching SSH proxy on port 65434
waiting for connection
[INFO] 2017-09-14 13:45:30 :: idb ::  Establishing SSH Session for root@localhost:65434
accepted connection, fd = 4
waiting for connection
Number of available devices == 1
Requesting connecion to device handle == 86 (serial: bb1edfc2fd4391dc604c77605c4960288efe3c44), port 22
Error connecting to device!
2017-09-14 13:45:33.770 ruby[58077:3323699] modalSession has been exited prematurely - check for a reentrant call to endModalSession:
[DEBUG] 2017-09-14 13:45:33 :: idb ::  opening port 65434 for manual ssh connection
[INFO] 2017-09-14 13:45:33 :: idb ::  Launching SSH proxy on port 2222
[DEBUG] 2017-09-14 13:45:33 :: idb ::  opening tool port 65437 for internal ssh connection
[INFO] 2017-09-14 13:45:33 :: idb ::  Launching SSH proxy on port 65437
waiting for connection
[INFO] 2017-09-14 13:45:33 :: idb ::  Checking iOS version
waiting for connection
[DEBUG] 2017-09-14 13:45:33 :: idb ::  Executing blocking SSH command: touch /tmp/daniel
[ERROR] 2017-09-14 13:45:33 :: idb ::  undefined method `exec!' for nil:NilClass

Does idb needs to have the device jailbroken?


Full type hint coverage

What?
Full type hint coverage. That is, every part of the public API should have explicit types.
@joelberkeley-pio would like mypy to be part of the CI run, but we need to discuss whether it makes sense to require mypy passes for merge.
Why?
As a user or GPflow maintainer, I want full type hint coverage so that I know what types I'm expected to provide and which I should expect to receive back.
As a production user, I want full type hint coverage so that I can check that I can gain confidence my code is integrated correctly with the library.
As a GPflow maintainer, I want full type hint coverage so that I can be confident my changes are sound.

How?
I propose we apply this a sub-package at a time.

Before we do this, I recommend we reconsider the current approach of aliasing types. I find type aliases can be problematic for the following reasons:

they hide the actual meaning behind library-local names and therefore

are potentially less clear or accurate
require an indirection to find out what type I'm actually looking at

they give the user the unwarranted impression of type safety for different aliases of the same type. For example a user seeing InputData and OutputData may interpret these as different types, and thus feel that the type system (in the form of IDE highlighting/mypy) will warn them when there's a mistake. However, they are both aliases for tf.Tensor so they are actually the same type

There are cases where aliases make sense, for example when shortening lengthy types which are used repeatedly in a module

I'd be happy to go with a submodule-at-a-time approach and see how comfortable we all end up being with it. How about you & others who are keen to add types make a start with a couple PRs so we can see what that would look like?

Things learnt from adding types to gpflow/base.py

it's looking promising that we can leave nothing without a type or suitable comment/pragma
use # type unknown where a type is unknown
use if TYPE_CHECKING: to avoid importing optional dependencies at runtime
use # type: ignore where the correct solution would require too much boilerplate

I'd like to clarify that I think it's really important that we don't consider casually choose that omitting a type is a good final state, simply because we then don't know what's been looked at and what hasn't. Alternatives include comments or an alias of Any

Before we spend more effort on this, can we try adding mypy to the build and ask it to only check the submodules we've typified so far ?


DJANGO_API: search is of "no effect"

searching for anything seems to just list all dandisets for me, e.g. try
https://gui-beta-dandiarchive-org.netlify.app/#/dandiset/search?search=abracadabra

This has been solved.


[KO] Translation of Enum lesson

Any feedback is welcome :)

@devleoper do you want to take a look at this, if you're got some time?

Sorry for late reviewing. Looks great! :+1:

No worries @devleoper, thank you for your help.
Thank you @rijgndqw012 for the translation!


Updated Docs

Just documented the basic usage and APIs of the components that remained undocumented.

Thanks man :)


The same private key is generated differently public keys and addresses in c++ code and nem2-sdk-typescript-javascript while in NetworkType.MAIN_NET.

The same private key is generated differently public keys and addresses in c++ code and nem2-sdk-typescript-javascript while in NetworkType.MAIN_NET.

c++
private: B5ABA5C86CC4D43BC0FA39482D073A31C2DD4A8CD8934351541AFED2125A1492
public: 958FD173E0B7C57007E5FA107530629DDEEE56784D9A3771FCD37F694D8760D7
address: ND5B2OB5EB5PEQDRBAXWGTP3XLI26L4CB37YFPZF
nem2-sdk-typescript-javascript
private: B5ABA5C86CC4D43BC0FA39482D073A31C2DD4A8CD8934351541AFED2125A1492
public:  5C92C3221232BA58E80D695CE8DE92D163304E55CB1C0BE61EF321F07C345A3D
address: NAC73Q3YTKBEZHGAIASYXV3IPKZJJVRZO4WMLYGV

This is probably because the private key reverse has been scrapped SDK based on server E.3 changes.  Wait and see what core responses on slack sig-api channel.

I think we can close this now as per Gimre and Nate's comments on slack


Upgrade SpringBoot to version 2.5

The objective of SecHub is to stay up to date with SpringBoot releases.

SpringBoot version 2.5 is currently in preview: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.5.0-RC1-Release-Notes
SpringBoot 2.5 will add support for Java 16: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.5.0-M1-Release-Notes#java-16-support

Spring Boot 2.5 should be released on the: May 20 2021: https://spring.io/blog/2021/04/15/spring-boot-2-5-0-rc1-available-now

Spring Boot 2.5 is GA: https://spring.io/blog/2021/05/20/spring-boot-2-5-is-now-ga

Current version is now 2.5.2 see https://spring.io/projects/spring-boot

When switching to spring boot 2.5.2 we have following error message inside our gradle build:

Failed to apply plugin 'org.springframework.boot'.
Spring Boot plugin requires Gradle 6.8.x, 6.9.x, or 7.x. The current version is Gradle 6.7.1

So we will upgrade to gradle version 6.9 - The necessary steps to upgrade to 7.0 as mentioned in #495 does take more time and must  not be done inside this issue.


Dry up DirectReader implementations

This can be written in a much drier way that shouldn't come at any performance cost as far as I can see.

I don't have a strong opinion on this change, but historically there's been push back on this kind of changes, because while they reduce the total number of lines, they also introduce one more abstraction so you need to check out two different things instead of one to understand what reading N-bits integers does.

so you need to check out two different things instead of one to understand what reading N-bits integers does.

That was kinda my thinking but the other way around. I really liked having the logic of N bits -> how N bits are read and the fact that other than the math it's the same logic for all of them in one place :) Not feeling too strongly about this though, I can close it if it's not in line with Lucene's style :)

It got no additional feedback in the last couple days, so I'll default to closing if you don't mind. Thanks for contributing!


Fixes #83, wrap FileWriter with BufferedWriter to reduce IO operations

Fixes #83.

Thanks for making this contribution! :)


[stable/redis] add RBAC

What this PR does / why we need it:
Add RBAC (serviceAccount, Role, Rolebinding) option to the sbale/redis chart.
/cc @prydonius @tompizmor @sameersbn @carrodher @juan131

/assign @carrodher

/cc @prydonius @tompizmor @sameersbn @carrodher @juan131

@barryib AFAIK Redis does not use the k8s API so I can't see why this change is necessary, anything I'm missing?

@prydonius In our k8s clusters, every pod should run with a service account and should validate against pod security policy. I got error like this:
Events:
  Type     Reason        Age                From                    Message
  ----     ------        ----               ----                    -------
  Warning  FailedCreate  5s (x12 over 16s)  statefulset-controller  create Pod redis-master-0 in StatefulSet redis-master failed error: pods "redis-master-0" is forbidden: unable to validate against any pod security policy: []

So with this PR, redis, can now create a service account and role with customs rules. Something like this:
redis:
  serviceAccount:
    create: true
  rbac:
    create: true
    role:
      rules:
        - apiGroups:
            - extensions
          resources:
            - podsecuritypolicies
          verbs:
            - use
          resourceNames:
            - bme.unprivileged

/unassign @carrodher

/ok-to-test
/lgtm


The "Spread the word" call to action is a broken link

The call to action in the "Spread the word" button in the homepage has an empty link, shouldn´t it be a link to share the website on twitter or facebook? @raulraja let me know your thoughts.

Must of have broken recently because back then I submitted some link fixes
and tested it worked if I recall correctly. Yes we need that to share via
Twitter at a minimum.
On Thu, Jun 30, 2016, 6:20 PM Alejandro Gómez<EMAIL_ADDRESS>wrote:

The call to action in the "Spread the word" button in the homepage has an
empty link, shouldn´t it be a link to share the website on twitter or
facebook? @raulraja https://github.com/raulraja let me know your
thoughts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scala-exercises/scala-exercises/issues/493, or mute
the thread
https://github.com/notifications/unsubscribe/AAb4XDWRXLquVRelGZOjufAybhlBUKJhks5qQ-zOgaJpZM4JCVco
.

Nevermind, it works perfectly and shows a modal to share in various social networks. The problem must have been between the keyboard and the chair :stuck_out_tongue:


YAML for Labels errors on older syntax

Reported by @nyanshak on Slack:
But also - label yaml spec has changed a bit, but I didn't see anything about it in the upgrade guide.
applying labels: apply labels received status 500 Unknown Error: invalid LabelType: 1

^ already fixed in my environment, but would be nice to know about this in the upgrade guide, or have fleetctl offer to upgrade between formats.

Plan is to make sure that old label syntax is still supported in 3.0 series. We can do this by setting labels to default dynamic if it is not set explicitly in the spec.

This was not a new issue introduced in 3.0.
The following yaml triggers it:
---
apiVersion: v1
kind: label
spec:
  name: CentOS Linux
  description: All CentOS hosts
  query: SELECT 1 FROM os_version WHERE platform = 'centos' OR name LIKE '%centos%';
  label_type: 1

Will solve this by parsing both integers and strings for label_type.


Hardware OATH tokens (not yet available)

Hello,
Any way to find out when approx. this will be supported? Hardware OATH tokens (not yet available)
We like ready to finalize the migration, but we do have the Hardware tokens and they don't work if we finalize :)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0d9e50bc-931a-80b2-7363-da6eec0643db
Version Independent ID: 03575b7a-0bfd-3b6d-cb49-c00d929e68ea
Content: How to migrate to the Authentication methods policy - Microsoft Entra
Content Source: articles/active-directory/authentication/how-to-authentication-methods-manage.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@lightupdifire
Thanks for your feedback! We will investigate and update as appropriate.

Hi @lightupdifire Currently we don't have updated regrading Hardware OATH tokens not yet available in
Microsoft Authenticator.
https://learn.microsoft.com/en-us/azure/active-directory/authentication/how-to-authentication-methods-manage#:~:text=Verification code from,available)%0AMicrosoft%20Authenticator
please follow the below channels for update release info:
Thank you for your time and patience!
Unfortunately, we don't provide product release updates through our GitHub channels. For this, I'd recommend referring to our Azure Updates or Microsoft 365 Roadmap pages for this info.

I'm subscribed to RSS, so hopefully will see info from there. Thanks!


Support React >= 15 peer dependency

This semver range is breaking https://github.com/whetstone/redux-devtools-diff-monitor/pull/28. Can we get a React 15 version cut?

No, ^15.0.0-rc.1 matches 15.0.0 and any further stable 15.x versions. You can verify this on http://semver.npmjs.com/.
Please see an explanation for what’s likely to be your issue here: https://github.com/reactjs/react-redux/pull/342#issuecomment-207647767

Ahh my bad, the npm error had me confused in the travis build log but I can see that the rc matching range makes more sense. Thanks for explanation!


Removes vtkRendererOutput's spreadsheet ports

Follows up on #1042
No module should have variable ports, this is especially true for output modules (whose whole point is to be usable no matter the available output modes).
It looks like vtkInteractorStyle and vtkAbstractPicker are available even if the spreadsheet isn't enabled, @rexissimus can you confirm?
vtkInteractionHandler is NOT available if the spreadsheet is not enabled, so I removed it.

Yes, vtkInteractorStyle and vtkAbstractPicker are VTK classes and are always available.


Move  from_unixtime, now, current_date, current_time to datafusion-functions

Is your feature request related to a problem or challenge?
As part of https://github.com/apache/arrow-datafusion/issues/9285 the from_unixtime, now, current_date, current_time datetime functions should be migrated to the new datafusion-functions crate in the new structure
Describe the solution you'd like
Functions are migrated to the new crate and use the new patterns as described in https://github.com/apache/arrow-datafusion/issues/9286 & https://github.com/apache/arrow-datafusion/pull/9216,
Describe alternatives you've considered
No response
Additional context
No response

take

dup of #9466. I've been waiting for https://github.com/apache/arrow-datafusion/pull/9435 to be merged in before creating a pull request...

dup of #9466. I've been waiting for #9435 to be merged in before creating a pull request...

sorry... I see that now, but do you mind me finishing this PR?

dup of #9466. I've been waiting for #9435 to be merged in before creating a pull request...

sorry... I see that now, but do you mind me finishing this PR?

Or you can submit you PR and I will close my PR

I think you can close this issue, done by #9537 now


donate in crypto

if you will provide some (any) crypto donate button will donate equivalent of 21 USD.
if app will use 2x less resources  will donate USD 21 more (make it run of poor children laptops, right now it memory hog for such simple interface).

Hi @dzmitry-lahoda , I have no coins yet :) Not even sure how would I put it into my taxes :)
Is there some easy way how to allow for this? Never really looked into this...

Hi @dzmitry-lahoda , I have no coins yet :) Not even sure how would I put it into my taxes :)
Is there some easy way how to allow for this? Never really looked into this...

@dzmitry-lahoda I've thrown together a quick foundation for a future Stretchlylite here.  Maybe try it out and see how it performs on your laptop.
It doesn't actually work yet, it's just the interface.


python38Packages.flexmock: 0.10.5 -> 0.10.8

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.flexmock is: "flexmock is a testing library for Python that makes it easy to create mocks,stubs and fakes."
meta.homepage for python38Packages.flexmock is: "https://flexmock.readthedocs.org"
meta.changelog for python38Packages.flexmock is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.10.8 with grep in /nix/store/g2f16i0ch9igxmz2ragl6vja7is0dw6z-python3.8-flexmock-0.10.8

found 0.10.8 in filename of file in /nix/store/g2f16i0ch9igxmz2ragl6vja7is0dw6z-python3.8-flexmock-0.10.8

directory tree listing: https://gist.github.com/816c3bbfa419953d3216fe4d508b4503

du listing: https://gist.github.com/750e5edced9f05d2063b11111d0ec6ac

Rebuild report (if merged into master) (click to expand)

27 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
6 x86_64-darwin rebuild(s)
7 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
borgmatic
python38Packages.flexmock
python38Packages.ihatemoney
python38Packages.sqlalchemy-continuum
python39Packages.flexmock
python39Packages.ihatemoney
python39Packages.sqlalchemy-continuum

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/g2f16i0ch9igxmz2ragl6vja7is0dw6z-python3.8-flexmock-0.10.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.flexmock https://github.com/r-ryantm/nixpkgs/archive/420f41f13c8acaedd351ed56bd57a7414f784129.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/g2f16i0ch9igxmz2ragl6vja7is0dw6z-python3.8-flexmock-0.10.8
ls -la /nix/store/g2f16i0ch9igxmz2ragl6vja7is0dw6z-python3.8-flexmock-0.10.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages failed to build:

python38Packages.ihatemoney
python38Packages.sqlalchemy-continuum
python39Packages.ihatemoney
python39Packages.sqlalchemy-continuum

3 packages built:

borgmatic
python38Packages.flexmock
python39Packages.flexmock

Maintainer pings

Result of nixpkgs-review pr 136001 at 420f41f1 run on x86_64-linux 1

4 packages failed to build:

python38Packages.ihatemoney
python38Packages.sqlalchemy-continuum
python39Packages.ihatemoney
python39Packages.sqlalchemy-continuum

3 packages built successfully:

borgmatic
python38Packages.flexmock
python39Packages.flexmock

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/flexmock/default.nix:21:3:
   |
21 |   meta = with lib; {
   |   ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


AssertionError while evaluating 'translation'

Hi @wasiahmad ,
I am trying 'translation' capabilities of PLBART and started finetuning as mentioned. But I'm getting below error in evaluation -
File "calc_code_bleu.py", line 34, in <module>
    assert len(hypothesis) == len(pre_references[i])
AssertionError

Here is a bit detailed traceback -
2021-07-15 13:57:58 | INFO | fairseq_cli.train | early stop since valid performance hasn't improved for last 10 runs
2021-07-15 13:57:58 | INFO | fairseq_cli.train | begin save checkpoint
2021-07-15 13:58:19 | INFO | fairseq.checkpoint_utils | saved checkpoint /content/PLBART/scripts/code_to_code/translation/java_cs/checkpoint_last.pt (epoch 22 @ 14168 updates, score 80.08) (writing took 20.417050701000335 seconds)
2021-07-15 13:58:19 | INFO | fairseq_cli.train | end of epoch 22 (average epoch stats below)
2021-07-15 13:58:19 | INFO | train | {"epoch": 22, "train_loss": "2.08", "train_nll_loss": "0.177", "train_ppl": "1.13", "train_wps": "1562.9", "train_ups": "1.76", "train_wpb": "890.1", "train_bsz": "16", "train_num_updates": "14168", "train_lr": "4.93409e-05", "train_gnorm": "0.534", "train_train_wall": "255", "train_wall": "8414"}
2021-07-15 13:58:19 | INFO | fairseq_cli.train | done training in 8412.8 seconds
  0% 0/250 [00:00<?, ?it/s]/usr/local/lib/python3.7/dist-packages/fairseq_cli/generate.py:172: UserWarning: --sacrebleu is deprecated. Please use --scoring sacrebleu instead.
  scorer = scoring.build_scorer(args, tgt_dict)
Traceback (most recent call last):
  File "/usr/local/bin/fairseq-generate", line 8, in <module>
    sys.exit(cli_main())
  File "/usr/local/lib/python3.7/dist-packages/fairseq_cli/generate.py", line 379, in cli_main
    main(args)
  File "/usr/local/lib/python3.7/dist-packages/fairseq_cli/generate.py", line 41, in main
    return _main(args, sys.stdout)
  File "/usr/local/lib/python3.7/dist-packages/fairseq_cli/generate.py", line 172, in _main
    scorer = scoring.build_scorer(args, tgt_dict)
  File "/usr/local/lib/python3.7/dist-packages/fairseq/scoring/__init__.py", line 54, in build_scorer
    return _build_scorer(args)
  File "/usr/local/lib/python3.7/dist-packages/fairseq/registry.py", line 54, in build_x
    return builder(args, *extra_args, **extra_kwargs)
  File "/usr/local/lib/python3.7/dist-packages/fairseq/scoring/bleu.py", line 40, in __init__
    character_tokenization=self.args.sacrebleu_char_level,
AttributeError: 'Namespace' object has no attribute 'sacrebleu_char_level'
Traceback (most recent call last):
  File "/content/PLBART/evaluation/evaluator.py", line 36, in <module>
    main()
  File "/content/PLBART/evaluation/evaluator.py", line 20, in main
    assert len(refs) == len(pres)
AssertionError
Traceback (most recent call last):
  File "calc_code_bleu.py", line 34, in <module>
    assert len(hypothesis) == len(pre_references[i])
AssertionError

Could you plz suggest how to proceed further..

The error is due to
AttributeError: 'Namespace' object has no attribute 'sacrebleu_char_level'

I am using the following version of sacrebleu.
Name: sacrebleu
Version: 1.2.11
Summary: Hassle-free computation of shareable, comparable, and reproducible BLEU scores
Home-page: https://github.com/awslabs/sockeye

Hi @wasiahmad ,
I found below workaround -

For translation, mbart_base is not present in fairseq==0.9.0 so I installed fairseq==0.10.0.
For fairseq==0.10.0, sacrebleu version should be >=1.4.x . So I installed  sacrebleu==1.5.1.
Replace --sacrebleu with --scoring sacrebleu in 112 line of scripts/code_to_code/translation/run.sh.
Commented 28 line in source/sentence_prediction.py as it's erroring ModuleNotFoundError.
Treesitter parser gave some error. so ran below:

%cd evaluation/CodeBLEU/parser
!bash build.sh
%cd ../../..

With these changes everything ran successfully.

This is really helpful.

I forgot documenting about running build.sh.
May I know what did you use instead of using maybe_shorten_dataset in line 28 in source/sentence_prediction.py?

Answers to questions

The maximum length should be 512.
If you have some data to fine-tune, it would work. We did such experiments and it worked.

Thanks @wasiahmad ,
As I'm working only on translation part , I thought there's no need of source/sentence_prediction.py. So got away with it (atleast for now) :-)

We are working on a release where we will release all the fine-tuned checkpoints. Also, there are bugs that are also fixed. We will also provide scripts to set up conda environment so that experiments can be run without any issue.

That would be great !!!


Glaxx block face always visible?

When placing Glaxx, you can look through the "glass" block and see the face of the other "glass" blocks. I don't know if this is a connected texture issue or not? I don't have any form of CTM installed on 1.19.2.
Maybe its a setting I have changed wrong?

Hi, yes I can confirm that this is a bug. It was fixed with version 1.0.2.
I created the releases and load them after Curse and Modrinth.

I should have asked while I was at it: https://github.com/XFactHD/FramedBlocks/issues/299
Are you able to make blocks a block entity so it will work with the FraemdBlocks mod? I don't think I should reopen or open a new issue for this as its not really an issue, just something maybe you could update/add?

I'll take a look at it as soon as I find the time.

@34486 can you test it again in the new version of Xtones Reworked for 1.19.2? Because I can place all blocks in Framed Blocks "frames" :)

Done @34486 and @lays24mc

Yes, thank you! It does work, but also GLAXX is working in framed blocks for me too!!! Including the patch for always seeing the face, all works great! Thank you both very much for the support!


Update README to be more consistent with other SDKs

You have to merge https://github.com/meilisearch/meilisearch-swift/pull/181 before :)

bors merge

bors merge


feature request: support for kerberos via keytab

underlying webhdfs module already support it.
please, make it configurable:
client.kerberos = true
client.kerberos_keytab = "/path/to/your/keytab/file"

Hi iolo,
I just merged the kerberos branch to master. New configuration parameters are:
use_kerberos_auth
kerberos_keytab
Please let me know if you encounter any issues.
Take care,
Björn

Will this also work with the webhdfs listening on https? I guess this is a separate enhancement.

Hopefully the merge solved your issues. I will close this case tomorrow, if you don't have any other problems.
Take care,
Björn

it works!
thanks @dstore-dbap

Hi iolo,
glad to hear that ;) I will close this issue then.
Take care and all the best,
Björn

Hi @iolo Sorry for spamming this thread but could you get the keytab to work without doing a kinit first? In my case just specifying the keytab file causes a "No credentials found" error but if I do a kinit -kt mykeytab everything works (even if I don't specify keytab in output)

I have same problem on logstash 6.3.2


API Requests from SPFX Solution are missing from API permissions list in sharepoint admin after deploying it

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested

[X] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[X] 💥 FireFox
[X] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details
No response
Describe the bug / error
Everything is written in the title.
If I remove permissions on Azure AD for the "SharePoint Online Client Extensibility Web Application Principal" app registration , then remove my SharePoint application from tenant addin catalogs and install it again the permissions does not appear again the the list listing the pending permissions in the SharePoint administration center under advances -> Access to APIs.

We have noticed in the past that each time you install an app, then a new pending request appears in this Access to APIs page in the admininistration center of SharePoint... then all duplicates entries was gone, so I guess Microsoft did something to clean the list... but now if permissions have been remove in Azure AD directly, when reinstalling the package, the request to add again the permissions never appear in the list. This is a MAJOR problem, even if we can solve it manually by adding permissions in Azure AD.
I think the fix done by MS to remove duplicates entries in this list added a regression bug.
Steps to reproduce

Remove permission in Azure AD for the SharePoint Online Client Extensibility Web Application Principal app registration
Remove application from tenant addin catalog
Add your SPFx application again
Go to SP admin center -> Advances -> Access to APIs
The pending permissions does not appear

Expected behavior
The permissions list in SP admin center -> Advances -> Access to APIs should list the pending permissions if the permissions is not found in the azure app registration in Azure AD

@patrickblanc, thanks. Can you please check in AAD if you removed the permissions on both the service and the application principal for the "SharePoint Online Client Extensibility Web Application Principal" object?

@patrickblanc , sorry for my delay in responding. Two questions

would be possible to have access to the tenant or is that a production tenant?
if we cannot get access to the tenant, could you please navigate to the API Access page (I assume your account has access to the app catalog and it is also an AAD Global Admin), go in the browser dev tools and generate + send us the HAR file for the API Access page load?

Thanks!


'dict' object has no attribute 'astype'

Hello, I encountered a problem running the train.py file according to the document. How can I solve it?

Yes, is numpy.ndarry, but the labels are dict, I donnot know how to change the codes?

Best regards,
Chen

Did you use our dataset or the 3D AffordanceNet dataset? It seems like you used the latter. Please note that our dataset is different from the 3D AffordanceNet dataset, in which we only keep the argmax for the labels. We provided the Drive link to our dataset in README, please download and use it for this repository.
Best regards,
Toan.

I see, thank you very much, I'll try to download and run this program
With respect,
Chen


Linux - Unexpected version check output

Hello,
I'm using Debian Jessie with freshly installed livestreamer 1.12.2.
When lauching a stream, I get this:

Here is the output of
livestreamer --version --no-version-check Traceback (most recent call last):   File "/usr/bin/livestreamer", line 5, in <module>     from pkg_resources import load_entry_point   File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2876, in <module>     working_set = WorkingSet._build_master()   File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 451, in _build_master     return cls._build_from_requirements(__requires__)   File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 464, in _build_from_requirements     dists = ws.resolve(reqs, Environment())   File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 639, in resolve     raise DistributionNotFound(req) pkg_resources.DistributionNotFound: livestreamer==1.12.2
I get the same error when lauching manually a stream via command line.
I hope this can help.
EDIT : sorry, the code is ugly, I don't know how to indent.

Something is wrong with your livestreamer installation...
#185 #179

I don't know if you've already managed to fix this, but see chrippa/livestreamer#1166. This should be exactly what you are looking for.
Also, please notice the new release v0.12.0 from a couple of minutes ago...

Geez, I looked for similar issues but found nothing, thank you. You were right, the version in the official repos is broken, I simply updated it with pip (see http://docs.livestreamer.io/install.html). It's fine now.


feat(body) adding support for 'isBase64Encoded' flag in Lambda function responses

Currently the AWS Lambda plugin does not support the isBase64Encoded flag that allows Lambda functions to respond with binary payloads. This PR adds that functionality.

Hi @jonminter I was just looking into implementing this functionality as well. I see that the cicd tests have failed, but it looks like that is due to some infra issue on the kong side. Are you still working on this PR?

@stephanietortora Yes it does look like issues with CI on Kong's side.
The code in the PR is functional and I added tests to verify it I think someone from Kong just needs to address the CI failures and review the change and they may have things they want changed before the PR is accepted.
@Tieske I've seen that you've approved a lot of the PRs submitted to this repo. Are you the one who would review this?

And additionally:

Can you add an "unreleased" section to the CHANGELOG.md file with the changes?
Don't worry about the CI failures, they are because the secrets required for the Enterprise edition are not available in external branches (Travis securirty)

And additionally:

Can you add an "unreleased" section to the CHANGELOG.md file with the changes?
Don't worry about the CI failures, they are because the secrets required for the Enterprise edition are not available in external branches (Travis securirty)

thx for the feature 🚀 and apologies for the long delay!

No worries. I'll make these suggested changes.

@jonminter fyi, just merged https://github.com/Kong/kong-pongo/pull/111 , which fixed the CI issue.

thx @jonminter !

Hint: https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributor-t-shirt

@Tieske Thanks for fixing those issues and merging! I've been pretty busy lately and this slipped my mind.

@jonminter thanks for helping out on the Lambda plugin! Approved your contributor shirt 😄


Error 401

Getting the following error when trying to upload documents:
[UploadHandler ERR] Error getting embeddings: error, status code: 401, message:
[negroni]
Running it locally.

Can confirm the error
[UploadHandler ERR] Error getting embeddings: error, status code: 401, message:
when uploading any document. It just stops scanning the document in the middle and the error message is displayed.
Also running it locally.

Tried locally. Same error spins up for every file that I upload but I can't understand the source of the problem.


Transparent ACDR Chart makes it hard to read when zoomed in

Use some opaque background instead

Sure. Thank you for pointing it out.
On Sat, 11 Jul 2020 at 12:20 PM, Thirumal Venkat<EMAIL_ADDRESS>wrote:

[image: Screen Shot 2020-07-11 at 12 18 10 PM]
https://user-images.githubusercontent.com/1734792/87218486-c2ca1b00-c370-11ea-8abf-97c5eca11b07.png
Use some opaque background instead
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nswamy14/I2DJS-COVID-INDIA/issues/26, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQEFH4QBAXNPUDAX6YLM6TR3ADSDANCNFSM4OXFKERA
.

--
--
Warm Regards,
Narayana Swamy,
<EMAIL_ADDRESS>


video are not working on remote development blogpost

Issue Type: Bug
The advertised blog in the new version does not show any videos.
The video loading just hangs and when I try to watch in on youtube I get the error that the video does not exist.
https://code.visualstudio.com/blogs/2019/05/02/remote-development
VS Code version: Code 1.34.0 (a622c65b2c713c890fcf4fbf07cf34049d5fe758, 2019-05-15T21:55:35.507Z)
OS version: Linux x64 5.1.3-arch1-1-ARCH

Hi, sorry about this.
Are you able to watch the videos directly on YouTube?  for example, here: https://www.youtube.com/watch?time_continue=12&v=mIHprjsSO9o
Are there any errors in your browser console?

:see_no_evil:
I was not able to see them back then. It is now fixed though


Diff Editors are not in the back/forward history

Does this issue occur when all extensions are disabled?: Yes

Version: 1.74.0-insider (user setup)
Commit: 1b1e2a2c5794df1f475976062c754651827634a9
Date: 2022-11-18T05:25:18.342Z
Electron: 19.1.3
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22000
Sandboxed: Yes
Steps to Reproduce:
Timeline

Navigate to Timeline (so that you get a diff)
Now navigate to another file
press back
VSCode is unable to get back to the diff editor

Source Control

Make a change then go to source control and click the diff
Close the tab then click back
VSCode is unable to get back to the diff editor

For some reason diff editors are not added to the history when navigating. When doing some digging in this it seems DiffEditors get disposed of when closing the editor (unlike normal single file editors). You can see the group tries to re-open them but falls into the return when they're already disposed, so nothing happens.
Why is this important? In GitHub when reviewing code you can open a file fully in isolation then click back to the diff. In VSCode this isn’t easy to do.
For more context see: https://github.com/microsoft/vscode/pull/165765
Screencast
Source Control

Timeline

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

@bpasero im happy to work on this rather than wait for upvotes. I don’t think 20 people will come across this issue in the next 60 days.
I was hoping to see if this was a bug or intentional, and if a fix for this was achievable.

From https://github.com/microsoft/vscode/pull/165765 which is now merged

I think we only keep editors in the history that can be addressed via plain old JS objects (e.g. { resource: <uri> }), not fully heavy typed editor inputs. We cannot know for sure that a closed editor can be restored from its EditorInput because it is disposed after being closed.

@bpasero @alexdima is it possible to not have the bot kill this issue as I can look into it at some point if its fixable. Although if it's definitely not possible to do that would be useful to hear too.

Having it in Backlog means it will not require 20 upvotes, but we may still decide to not accept a PR if any.

So the issue is here:
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/browser/parts/editor/editorGroupView.ts#L601-L605
Closing a group will dispose 3 editors (1 Diff editor and 2 fileInput editors). If i comment this section out it works as intended

Commenting here because https://github.com/microsoft/vscode/issues/153786 is locked.
@alexr00 @bpasero it would be great to address this as part of the same feature-addition, otherwise it only half-works. (Can open the side of a diff but can't go back, it feels a bit broken).
I do have a [solution[(https://github.com/microsoft/vscode/issues/166805#issuecomment-1382565636) above, but would love some guidance on what to do next.

Hey @hediet I believe you're working on the new Diff Editor? It would be great if this could be fixed as part of the V2. If not you can point me in the right place.


julia-bin: autoPatchelf manually to avoid mangling cache

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The root cause is that julia caches are also elf files, which get mangled by autoPatchelfHook, giving use the hash mismatch errors.

julia_19-bin and julia_110-bin are both failing for me with the BLAS test we talked about before. Maybe we should disable this test?

I think we shouldn't. Since it's really failing failing, it would give out wrong computations on failing platforms, which is detrimental if you rely on it to be correct.

it would give out wrong computations on failing platforms, which is detrimental if you rely on it to be correct.

But, I can run julia_111-bin from master just fine on this machine, because it gets fetched from cache.nixos.org and the tests don't get run. Does that mean I might get wrong calculations on this machine?

it would give out wrong computations on failing platforms, which is detrimental if you rely on it to be correct.

But, I can run julia_111-bin from master just fine on this machine, because it gets fetched from cache.nixos.org and the tests don't get run. Does that mean I might get wrong calculations on this machine?

julia_111 is probably fine, since it's using a newer version of openblas with that bug fixed.


fix(shipyard-controller): Make sure sequence queue is free again after aborting a sequence

Backport for #7116
This PR makes sure that the sequence queue is freed up for new sequences when a sequence is cancelled, even if there might be an error with retrieving certain entries from the database (e.g. the original sequence.triggered event)
Also, additional test cases for queueing/pausing/aborting sequences have been added
Integration test run: https://github.com/keptn/keptn/runs/5496316358?check_suite_focus=true

Looks good, but the integration tests are failing


Render order

Hi,
I am using two files, index.html and header.html.
Index is just some html page, the header is just used to plant a logo on every page.
It seems the header gets rendered first, and then the index page is rendered over the header, covering some of it.
Is it possible to change the render order on the pdf?
To make sure the logo will appear on top every time.
It seems the css between them is unrelated so I wasn't able to use z-index.
Any other idea to achieve this goal? (header over index)
Thanks :)

I do not think that the header is rendered below the main content. Did you try to increase the size of the image?

I do not think that the header is rendered below the main content. Did you try to increase the size of the image?

For instance, text have to use a bigger font size in order to be visible in the header.

For instance, text have to use a bigger font size in order to be visible in the header.

Yeah, I can definitely see the logo showing behind the index.html, cropped rectangularly, I'll try to upload a screenshot somehow but im in an enterprise environment.

Yeah, I can definitely see the logo showing behind the index.html, cropped rectangularly, I'll try to upload a screenshot somehow but im in an enterprise environment.

Well I played around and no luck.
To anyone arriving here heres what I did:
Simply convert the page, and then add logos/header/footer/etc at the pdf processing level (with another lib dedicated to this)
Thanks ! :)

Well I played around and no luck.
To anyone arriving here heres what I did:
Simply convert the page, and then add logos/header/footer/etc at the pdf processing level (with another lib dedicated to this)
Thanks ! :)

what do you mean by pdf prcessing level here? any pointers on how you solved it?


TsdFrame.smooth loses column names

When running smooth on a TsdFrame, the names of the columns are reset, e.g., from [100, 200] to [0, 1]. It would be nice to keep the column names.
import pynapple as nap

tsg = nap.TsGroup({
    100: nap.Ts([0.1, 0.2, 0.3, 0.4]),
    200: nap.Ts([0.2, 0.5, 0.55, 0.8, 1.1]),
})

tsg

  Index    rate
-------  ------
    100       4
    200       5

count = tsg.count(bin_size=0.05)
count

Time (s)      100    200
----------  -----  -----
0.125           1      0
0.175           0      0
0.225           1      1
0.275           0      0
0.325           1      0
0.375           0      0
0.425           1      0
...
0.775           0      0
0.825           0      1
0.875           0      0
0.925           0      0
0.975           0      0
1.025           0      0
1.075           0      0
dtype: int64, shape: (20, 2)

type(count)

pynapple.core.time_series.TsdFrame

smoothed_binned = count.smooth(0.05)
smoothed_binned

Time (s)          0        1
----------  -------  -------
0.125       0.36961  0.01753
0.175       0.48246  0.12952
0.225       0.49913  0.35207
0.275       0.49998  0.35207
0.325       0.49998  0.12953
0.375       0.49913  0.01842
0.425       0.48246  0.01927
...
0.775       0        0.13041
0.825       0        0.35208
0.875       0        0.35207
0.925       0        0.12952
0.975       0        0.01753
1.025       0        0.00087
1.075       0        2e-05
dtype: float64, shape: (20, 2)

Thanks it's fixed already in the dev branch. It should appears soon in the next version.


⚠ Bofrost.be has degraded performance

In 9e3aae8, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1116 ms

Resolved: Bofrost.be performance has improved in 981ca42 after 6 minutes.


[BEAM-14330] Temporarily disable the clusters auto-cleanup

Disables the clusters cleanup to avoid unimplemented errors when tests
run in parallel racing the global state without necessary mocking.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @TheNeuralBit
PTAL, thx!

Thank you!


Publish 8.0-20221209010857+0000

Publish 8.0-20221209010857+0000

@bot-gradle test and merge

OK, I've already triggered a build for you.


Device that gets connected to, returns zero connected devices when running getConnectedDevices()

Mobile Device Environment
Provide a list of operating systems on which this issue is relevant.

Device: Two Android 12 phones
OS: Android 12

Application Environment
Provide information about your development environment:

React Native version: 0.68.5
RN Bluetooth Classic version: ^1.60.0-rc.25

Describe the bug
If I connect device1 to device2 (device2.connect()), and then I do getConnectedDevices() on both phones, only device1 will return
connected devices, while device2 always returns zero devices connected.
To Reproduce
Steps to reproduce the behavior:
1- device1 and device2 are paired using the bluetooth settings
2- set device2 in accept mode
3- device1 connects to device2 -> device2.connect()
4- run getConnectedDevices() on device1, which returns device2 as being connected
5- run getConnectedDevices() on device2, which doesn't return any device connected
Expected behavior
When device1 connects to device2, device2 should return connected devices when I run -> getConnectedDevices()

https://github.com/kenjdavidson/react-native-bluetooth-classic/blob/c75c527b0c352cb1619df07a972a9714c73017cc/android/src/main/java/kjd/reactnative/bluetooth/RNBluetoothClassicModule.java#L665
Accept is adding the new connection to the connection map. Does communication between the two devices work properly?  Using write should be verifying the connection before write.
Do you see any errors in the log?
Are you able to debug the get connected devices?

If when accepting a device the Bluetooth socket doesn't have access to the remote device, this is an issue, and will require rewriting a chunk of stuff to maintain the device as well as the connection.
Can you please confirm?

Some things I've noticed:
1- the accept promise never resolves to anything.
RNBluetoothClassic.accept({ delimiter: '\r' }).then((device) => console.log('accept device')).catch((error) => console.log(error))
When running RNBluetoothClassic.accept({ delimiter: '\r' }), it will never resolve (console.log('accept device')). If I run it twice, it will throw an error saying it's already in the accept mode.
2- I have to try and connect 4 or 5 times until it's able to connect. The times it's not able to connect, it throws this error:
[Error: java.io.IOException: read failed, socket might closed or timeout, read ret: -1]
3- When I do connect, device1 returns device2 when I run getConnectedDevices, while device2 doesn't return anything.
I've never tried debugging native code, so I would have to do some research on how to do that.

Ok, so this is a pretty confusing way to list issues.
1 - If accept never returns, then the device is never actually connected.
2 - Socket exceptions are generally device issues, and not really library issues. More debugging will be needed, but the two that I have work fine.  Unfortunately I can't help much unless you're willing to buy me some more android devices to test with.
3 - You should be able to debug the code, if you're saying that the connection does finally work (which is the opposite of what you're saying in 1) then you should be able to debug the code to:
a) Confirm that mConnections is being updated on hte accept side
b) That Connection#getNativeDevice is actually returning the active device
If (a) is working, ie. the connection is being added to the map (which if not you should see other errors) then the next issue could be that the AcceptSocket handles the native device differently.  In which case, you should be able to confirm this, and if this is the case, the whole management of connected devices needs to be re-worked.

So, I think I understand what the problem is.
1- device1 is in the react-native app and is the one that is going to scan for device2. I'm scanning from inside the react-native app.
2- device2 is in the Bluetooth settings screen, so that it's advertising, which means that the react-native app is in the background and no code is running.
3- device1 is done with scanning and finds device2.
4- device1 connects to device2 (device2.connect()). While device2 is still in the Bluetooth settings screen.
5- Now the issue is that device2 had the app in the background, and thus the accept never resolved. And even when I go back to the app, the accept doesn't resolve. The only way it would resolve, is if the app was on the foreground when device1 was connecting to device2.
I just don't understand why sometimes the accept resolves, when the app is in the background.
Is there a way to actually advertise when inside an app?

Even more questions/commnets:

How are you starting accept on device2 if you're in the bluetooth settings screen?
device1 attempting to connect to device2 when it's not in accept mode is going to be why you're getting IOExceptions

Your workflow should be this:
1 - Pair the two devices, just pair them.
2 - Once you know they are paired start accept device2
3 - Start connect on device1
You should not be starting accept and then leaving the application.  React Native doesn't like doing things in the background, and therefore this wasn't really a planned workflow.
No, there is no way to advertise inside the library, as I mentioned:
1 - this is bluetooth classic, the devices should be paired before anything.  Once paired they will continue to pair whenever they are in distance and enabled.
2 - if this is a common workflow (which hasn't come up until now, so I doubt it) then a new function needs to be added to the library to allow calls to enable discovery.  But this just enables discovery, you still need to go through the pairing logic and confirm that both are doing so.

Thanks for the quick replies.
In regards to your question 1, I did open the react-native app on device2 and the accept was ran, before going to the bluetooth screen.
I think I now understand that the worflow that I currently have will not work. (one device in the bluetooth screen, another in the app, etc)
I actually thought that device2 needed to be advertising (even though they were already paired), to be able to be connected to, but since it's not needed, I can definitely change the functionality so that both devices are inside the react-native app.
Thank you for your help, I now understand better what to do and not to do.

Essentially yes, before starting connect or accept you should ensure that the devices are paired in both.  It probably should be doable so that:

starting accept
leaving the app
coming back to the app and still in accept

but unless React Native has fixed some of their background stuff, this is difficult.  Natively the socket needs to be shut down on leave and brought back up if it was open on leave.   Honestly, if you're doing this much work with bluetooth you should really be doing it natively, and not using react native.

RNBluetoothClassic.getConnectedDevices in my case return [] array
i am using application in debug mode and try to connect with another device.


gcc: if hostPlatform.isPower64, configure with "--with-long-double-64"

See comment below.
....
This PR contains two commits; the first commit is from #170400 which should hopefully be an easy merge decision.  The second commit is unique to this PR.
Description of changes
This commit causes powerpc*-*-gnu to be configured with 64-bit long double (the same as ordinary double) rather than the nonstandard, non-IEEE "IBM double" format from AIX.
This resolves a large number of package test failures caused by weird nonstandard floating-point semantics, and allows pkgsStatic.* to work as expected. (Edit: turns out that #170400 is enough).
There is a rather long comment included in gcc/common/platform-flags.nix explaining the situation and the reasoning.
Things done

Built on platform(s)

[X] powerpc64le-linux
[ ] x86_64-linux (in progress)
[ ] aarch64-linux (in progress)
[ ] mips64le-linux (in progress)
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Alright, ::crosses fingers::
@ofborg build pkgsCross.powernv.pkgsStatic.nix_2_4

Getting gcc, mpfr, and glibc to play nice together with anything other than the nonstandard IBM doubles is a major struggle.  I'm shelving this for now and will simply mark packages with doCheck=false where the tests fail due to nonstandard floating point weirdness.