How to increase pollStatefulSet's wait timeout

I did a quick search but didn't find it in issues or codebase, if there is already such feature we would greatly appreciate.
We're getting this error when the operator is running the reconcilation. I think this is due to the fact that our CH will take a long time to be ready (we are checking against the /replicas_status for the readiness probe. This (long CH startup time) is a known issue for us. We've configured the k8s probes' thresholds to accommodate this.
However, it seems the operator itself also has a timeout regardless the probes' settings. It seems after around 5 minutes, if the pod is still not in the ready state, the operator will abort and terminate the pod. And it will also mark reconcile completed unsuccessfully
My question is: is it possible to configure this timeout so the operator can wait however long we want it to wait?
Attach is the error log from the operator pod:
I0717 22:26:10.909201       1 poller.go:245] pollStatefulSet():clickhouse/chi-ed-v0-default-0-0:%s/%s - TIMEOUT reached
E0717 22:26:10.909254       1 creator.go:118] updateStatefulSet():StatefulSet update wait failed. err: waitStatefulSet(clickhouse/chi-ed-v0-default-0-0) - wait timeout
I0717 22:26:10.909285       1 creator.go:237] onStatefulSetUpdateFailed():going to ROLLBACK FAILED StatefulSet clickhouse/chi-ed-v0-default-0-0
I0717 22:26:10.934760       1 deleter.go:97] Delete Pod clickhouse/chi-ed-v0-default-0-0-0
E0717 22:26:10.938690       1 deleter.go:105] statefulSetDeletePod():FAIL delete Pod clickhouse/chi-ed-v0-default-0-0-0 err:pods "chi-ed-v0-default-0-0-0" is forbidden: User "system:serviceaccount:kube-system:clickhouse-operator-altinity-clickhouse-operator" cannot delete resource "pods" in API group "" in the namespace "clickhouse"
I0717 22:26:10.938727       1 worker.go:1458] Got abort. Abort
E0717 22:26:10.938816       1 worker-reconciler.go:735] reconcileStatefulSet():FAILED to reconcile StatefulSet: chi-ed-v0-default-0-0 CHI: ed-v0
I0717 22:26:11.006831       1 creator.go:58] CreateServiceCHI():clickhouse/ed-v0/0ccb6da7-a924-497b-a901-be07aa8a5eb8:clickhouse/ch-ed-v0
I0717 22:26:11.007190       1 worker.go:1164] updateService():clickhouse/ed-v0/0ccb6da7-a924-497b-a901-be07aa8a5eb8:reuse Port 9000 values
I0717 22:26:11.007250       1 worker.go:1164] updateService():clickhouse/ed-v0/0ccb6da7-a924-497b-a901-be07aa8a5eb8:reuse Port 8123 values
I0717 22:26:11.020461       1 worker.go:1201] updateService():clickhouse/ed-v0/0ccb6da7-a924-497b-a901-be07aa8a5eb8:Update Service clickhouse/ch-ed-v0
E0717 22:26:11.145853       1 worker-reconciler.go:91] reconcileCHI():clickhouse/ed-v0/0ccb6da7-a924-497b-a901-be07aa8a5eb8:FAILED to update err: crud error - should abort
I0717 22:26:12.541686       1 worker.go:657] markReconcileComplete():clickhouse/ed-v0/0ccb6da7-a924-497b-a901-be07aa8a5eb8:reconcile completed unsuccessfully, task id: 0ccb6da7-a924-497b-a901-be07aa8a5eb8

root reason is not timeout
root reason is access forbidden
statefulSetDeletePod():FAIL delete Pod clickhouse/chi-ed-v0-default-0-0-0 err:pods "chi-ed-v0-default-0-0-0" is forbidden: User "system:serviceaccount:kube-system:clickhouse-operator-altinity-clickhouse-operator" cannot delete resource "pods" in API group "" in the namespace "clickhouse"

timeout reached because accessforbidden
how did you install clickhouse-operator?
did yuo upgrade ClusterRoleBindings for clickhouse-operator service account?

for properly upgrade helm chart you need to install CRDS separatelly, we will try to fix it by add CRDs to crds folder and to templates folder in the next Helm Chart release
could you share
kubectl get clusterrole  clickhouse-operator-altinity-clickhouse-operator -o yaml ?

CRDS already added to crds folder
you could manually upgrade crds from https://github.com/Altinity/clickhouse-operator/tree/master/deploy/helm/crds
according to
https://github.com/Altinity/clickhouse-operator/blob/0.21.3/deploy/operator/clickhouse-operator-install-bundle.yaml#L2770-L2777
need to figure out when and why statefulSetDeletePod executed, and what exactly it do

statefulSetDeletePod is executed in case updated StatefulSet is not in 'Ready' after reconcile.statefulSet.update.timeout seconds and onFailure is set to rollback. So operator tries to rollback StatefulSet to previous generation and tries to help StatefulSet by deleting current pod (which is considered to be broken). Unfortunately, RBAC has no delete allowed for pods. Right now I've added delete permission, but we may want to review the whole process of rollback.

statefulSetDeletePod is executed in case updated StatefulSet is not in 'Ready' after reconcile.statefulSet.update.timeout seconds and onFailure is set to rollback. So operator tries to rollback StatefulSet to previous generation and tries to help StatefulSet by deleting current pod (which is considered to be broken). Unfortunately, RBAC has no delete allowed for pods. Right now I've added delete permission, but we may want to review the whole process of rollback.

Hey, we got the same problem as StatefulSet is not in 'Ready' after reconcile.statefulSet.update.timeout seconds(but sometime not happen), did u know why it happened or what is the relevance of this problem?

@OodounaikingoO , could be different reasons for that, e.g. ClickHouse starts too long. In this case, you need to add a startup probe to podTemplate. Maybe we can add a syntactic sugar for that at some point.


Typo in custom widgets section of docs

(If I'm understanding the templating structure correctly, I think geojson-label should instead say placename-geojson)

Thanks for catching this!


Replaced io/ioutil with "os / io" package.

Signed-off-by: yanggang<EMAIL_ADDRESS>/kind cleanup
Hey , calico community..
We should clean all io/util package according the url: ioutil deprecation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@yanggangtony it looks like you need to rebase before we can merge this.

Removing "merge-when-ready" label due to new commits

@mgleung
Hi, I had rebase it ..
sorry for that forget tell you :grinning::grinning:

/sem-approve

@yanggangtony sorry, it looks like this needs another rebase since I didn't see this in time. Could I ask you to rebase one more time?

Removing "merge-when-ready" label due to new commits

@yanggangtony sorry, it looks like this needs another rebase since I didn't see this in time. Could I ask you to rebase one more time?

:grimacing::grimacing:
Rebased again.

/sem-approve

@caseydavenport
Like above output , i execute the 'make generate' , its ok , but has no funcstion to the current code .
its meanings there is no change?
you means 'out of date' in the code? but when i rebase the master , it will follow the latest code

@yanggangtony I suspect that all of the changes that our checks are picking up have to do with updates to the year. After you run make generate on your code, what does git diff show? According to our automation, you should have a bunch of 2 line changes (which I suspect are just updates to the new year).

@mgleung
Hi, thanks for review.
I execute 'git status' and 'git diff' , there is no change codes.:smile::smile:

@yanggangtony could you try rebasing on master and running make generate one more time? Curious if we've fixed the issue in master or not.

Removing "merge-when-ready" label due to new commits

@yanggangtony could you try rebasing on master and running make generate one more time? Curious if we've fixed the issue in master or not.

	modified:   .semaphore/semaphore-scheduled-builds.yml
	modified:   .semaphore/semaphore.yml

Rebased , And execute 'make generate'.. shows the before file is changed..

/sem-approve

/sem-approve

@yanggangtony I hate to have to say this again, but could you run make generate again? It looks like some of the operator CRDs have changed that we need to pick up.

@mgleung Rebasing will also do the trick as this branch is a just a few commits behind (operator-crds.yaml dirty issue seems to be fixed on master). However, as this changeset touches felix/node and their UTs are failing on master. It is unlikely for this to pass the build. As this PR has been approved (several times), I would suggest get this force merged.

@hjiawei the failures in the BPF tests and the Felix FVs I think we can navigate. I think I am less comfortable with force merging this since in all of the tests for the history of the PR, we have either had issues with the static checks (for building Felix), and after that, failures with the pre-flight checks which have prevented us from seeing the results of the fixes for the Felix build. If we were hitting some of the test failures we were aware of, I would be fine, but I want to get a build running where everything has at least been built before we merge the changes.

@yanggangtony as per @hjiawei 's suggestion, could I ask you to rebase this really quick? I imagine we won't see any conflicts this time and that will hopefully fix the tests up enough where everything will build.

rebase it.

/sem-approve

/sem-approve

Thanks for sticking with this one @yanggangtony !

Thanks for sticking with this one @yanggangtony !

So long time for yours reviews..
thanks very much..


chore(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-k8s-27-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3056

Questions ?
Please refer to the Backport tool documentation


fix(ga): issue #606 - search inconsistent

BUG - guide search is very inconsistent
#606
Description

[x] use enter key to start a search request
[x] remove the timeout to update store

Checklist for Pull Requests

[ ] Supplied as many details as possible on this change
[ ] Included the link to the associated issue in the Issue section above
[ ] The code conforms to the general development guidelines.
[ ] The code has unit tests where applicable and is easily unit-testable
[ ] This branch is appropriately named for the associated issue

Thanks for the PR Ed. I see some regressions.
1] Open GA
2] Enter the search term fiori and delete it
3] Apply some filters by clicking on the square icon next to the search bar (same issue with the Filter by components)
4] Enter the search term again
Issue - Filter is lost
This works fine with the released version
5] Apply filters again
6] Delete the search term by clicking on the X icon
Issue - Filter is lost again
https://github.com/user-attachments/assets/fa03a4cc-afd8-4477-9013-5b6f272dc7c9

@hitesh-parmar You need now to press the enter key to start a search

I will close that PR for now

Branch deleted.


MRE for nested pagination failing

Description

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks @aprams :)
I think I found the issue, going to use this PR to send the fix

@bellini666 this worked! 🚀
You rock 🪨


09_Initiators_&_Deleters tutorial issue/error

The following error is generated in the tutorial.

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-7-a6cc5b988390> in <module>
     19     tracks -= deleter.delete_tracks(tracks)
     20     tracks |= initiator.initiate(measurements - associated_measurements,
---> 21                                  start_time + timedelta(seconds=n))

**TypeError: initiate() takes 2 positional arguments but 3 were given**

Update to 0.1b5dev6. Notebook completes correctly.

This was caused by breaking change in #406.

Thank you, adding the composite deleter might be a future addition or part b for the tutorial.
    composite_deleter = CompositeDeleter([deleter1, deleter2, deleter3], intersect=False)


ListObjects: don't recurse beyond prefix

This fixes the biggest performance issue with ListObjects for me - it would recurse into all subdirectories, even when using a delimiter.
There are still a few issues:

Large directories take forever to list.
Parent directories are still walked for no reason - perhaps the posix backend should scope the os.DirFS() to the last directory in the prefix rather than starting at the root, and stitch the paths back together in p.fileToObj. I looked at doing that but wasn't sure if I'd hit a prefix = "" edge case.

Also fixes #903

This won't automatically run in continuous integration without approval. A member of the Versity organization must allow it.

The new logic should work with any delimiter:
if delimiter != "" &&
    strings.HasPrefix(path+"/", prefix) &&
    strings.Contains(strings.TrimPrefix(path+"/", prefix), delimiter) {
    skipflag = fs.SkipDir

If the delimiter is non-empty, and our path is beyond the prefix, and the delimiter is still in the directory path after trimming the prefix from it, we shouldn't recurse.
I fixed the pagination issue by not doing an early return, instead opting to set a skipflag variable which is used instead of return nil for the rest of the walk closure.


Scala2_12 merge from master

might need to force push it. @johnynek - do I have permissions to do it?

If we force push we will break shas that other people are using. I really don’t want to force push a publicly advertised branch.
Can we not use merge and avoid force push?

@johnynek so just regular merge?

Or,
I suggest just to use a new branch for now each time.
2.12_date
On Tue, 6 Mar 2018 at 14:32 Or Shachar<EMAIL_ADDRESS>wrote:

Reopened #435 https://github.com/bazelbuild/rules_scala/pull/435.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/435#event-1506386696, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABUIF0l8oBPPJ-2oQQVkMunH5NhtSyGbks5tboH0gaJpZM4SbSl9
.


[SPARK-11334] numRunningTasks can't be less than 0, or it will affect executor allocation

With Dynamic Allocation function, a task failed over maxFailure time, all the dependent jobs, stages, tasks will be killed or aborted. In this process, SparkListenerTaskEnd event will be behind in SparkListenerStageCompleted and SparkListenerJobEnd. Like the Event Log below:
{"Event":"SparkListenerStageCompleted","Stage Info":{"Stage ID":20,"Stage Attempt ID":0,"Stage Name":"run at AccessController.java:-2","Number of Tasks":200}
{"Event":"SparkListenerJobEnd","Job ID":9,"Completion Time":1444914699829}
{"Event":"SparkListenerTaskEnd","Stage ID":20,"Stage Attempt ID":0,"Task Type":"ResultTask","Task End Reason":{"Reason":"TaskKilled"},"Task Info":{"Task ID":1955,"Index":88,"Attempt":2,"Launch Time":1444914699763,"Executor ID":"5","Host":"linux-223","Locality":"PROCESS_LOCAL","Speculative":false,"Getting Result Time":0,"Finish Time":1444914699864,"Failed":true,"Accumulables":[]}}

Because that, the numRunningTasks in ExecutorAllocationManager class will be less than 0, and it will affect executor allocation.

Merged build triggered.

Merged build started.

Test build #44397 has started for PR 9288 at commit e32e684.

Test build #44397 has finished for PR 9288 at commit e32e684.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44397/
Test PASSed.

Merged build finished. Test PASSed.

IMHO, would it be better to fix this unexpected ordering of events, from my understanding, SparkListenerTaskEnd should be triggered before SparkListenerStageCompleted , right? I think that's root cause should be fixed, rather than adding some guard codes in dynamic allocation.

Yeah, I know the root cause is the wrong ordering of events.
The code of these event order are: kill Task, StageCompleted, JobEnd.
Because the TaskEnd is not serial with StageComplete and JobEnd, so I think maybe we can't control the ordering.

Hm, is it better to check the status of the task, and only decrement if it wasn't dead already? (I may not know what I'm talking about there)

Can we do this by adding pending to kill tasks into list, only when all the tasks marked as finished, then call markStageAsFinished, also post SparkListenerJobEnd. AFAIK, this is the way to manage executor killing in CoarseGrainedSchedulerBacked, from the code level (not sure the complexity) this can also be achieved here in DAGScheduler.

It's unclear how the wrong ordering resulted because DAGScheduler supposably posts events from a single thread. I think investigating this will take much longer since the scheduler is quite complicated. I'm OK with doing a fix on the ExecutorAllocationManager side.

@jerryshao, I try to realize the code of your suggestion, but many unit tests are failed. I think it's difficult for me. If you can help me, I would be very grateful.

@andrewor14, yeah the DAGScheduler post events from a single thread, but the root cause is that DAGScheduler receive the SparkListenerTaskEnd behind SparkListenerStageCompleted.
I try to resolve the root cause, as you said scheduler is quite complicated, my realization caused many unit tests failed. So if you OK with doing a fix on the ExecutorAllocationManager side, I will fix update the ExecutorAllocationManager code.

@XuTingjun , I'm OK with the current way if finding the root cause is a little bit complicated. Just need to add more comments why we have to change to that way.

@andrewor14 , from my understanding this wrong ordering is happened when driver explicitly abort the running stages because of exceeding max failures. So SparkListenerStageCompleted  will be received firstly, then SparkListenerJobEnd , SparkListenerTaskEnd  will be received at last because it has be killed and return back the result remotely.

@XuTingjun A more robust way to do this may be to keep track of
private val stageIdToRunningTaskIds = new mutable.HashMap[Int, mutable.HashSet[Int]]

then you can just remove all the tasks associated with the stage when the stage is completed.
def totalRunningTasks(): Int = {
  stageIdToRunningTaskIds.mapValues(_.size).sum
}

this seems very similar to what I'm seeing in https://issues.apache.org/jira/browse/SPARK-11701.  that is dealing with speculation but also causes the numbers to be off.  This is only fixing the executor allocation though is the executor page also showing a negative number of active tasks?  I found that for speculation it affects multiple things that are doing accounting based on the taskEnd event that is coming after the stage is finished.  if we can't fix the root cause of out of order we should check the other places it might affect.

ping @XuTingjun  are you still working on this?

Let's close this PR for now since it's been inactive for many months.
@tgravescs @jerryshao would one of you have time to pick up this patch?

Let me take a crack at this issue :).


Overide binding value with app settings

Is it possible to override binding values using app settings?
sample scenario:
1: in dev we have a binding for service bus queue named dev-q
2: in production we have a binding for queue named prod-q
is it possible to have a value in app settings so for each environment we can provide different value for the binding

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7d575e82-637b-32de-e64d-75adf4b6d976
Version Independent ID: e346a973-fcb9-0c10-c1ed-17acd806ced9
Content: Triggers and bindings in Azure Functions
Content Source: articles/azure-functions/functions-triggers-bindings.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@joedevgee
Thanks for your feedback! We will investigate and update as appropriate.

@joedevgee Thanks for reaching out.
MicrosoftDocs Github issue is mainly related to the document issue. I would recommend you to create a thread on the forums - Microsoft Q&A or Stack Overflow
Once you post your issue on forums, it will have visibility across the community which is a better suited audience for such types of issues.
To answer your question yes, it is possible. To dynamically add the queue name, you can use the define any parameter as your requirement. As in C# code I have defined as %queuename%. If you are running in local, then it will be local.setting.json which will have the name of your queue.
 public void Run([ServiceBusTrigger("%queuename%", Connection = "ServiceBusConnection")]string myQueueItem, ILogger log)
        {
            log.LogInformation($"C# ServiceBus queue trigger function processed message: {myQueueItem}");
        }

local.settings.json
{
    "IsEncrypted": false,
  "Values": {
    "AzureWebJobsStorage": "UseDevelopmentStorage=true",
    "FUNCTIONS_WORKER_RUNTIME": "dotnet",
    "queuename": "myqueuename",
    "ServiceBusConnection": "Endpoint="
  }
}

As you see my queue name is dynamic based on my configuration. Now to make different configuration for different environment you can leverage the ConfigureAppConfiguration method in your startup class. For more details please refer to this document.
We will now proceed to close this thread. In case if you need any further assistance feel free to reach out to us in Microsoft Q&A or Stack Overflow.


Modify build-all.bash script to work on macOS.

Required for #1198.

I also wonder why you pass -s and -w to ldflags.

LGTM, thank you!

I also wonder why you pass -s and -w to ldflags.

just to reduce binary size for the released version, i suppose.


feat: moving to nextjs

Feel free to reject if this is not wanted. This was a mostly an educative experience for me as I saw there was interest in https://github.com/react-hook-form/documentation/pull/750#issuecomment-1074931329
From my testing, everything is working as expected.
This PR has 1 controversial change moving /api to /docs since /api is reserved in NextJS.
Used next-themes to simplify some of the classNames for dark/light theme.
Used next-localization to simplify language (This can further be expanded with https://nextjs.org/docs/advanced-features/i18n-routing
info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
info  - Linting
info  - Creating an optimized production build
info  - Compiled successfully
info  - Collecting page data
info  - Generating static pages (84/84)
info  - Finalizing page optimization

Route (pages)                              Size     First Load JS
┌ ○ /                                      11.8 kB         159 kB
├   └ css/b7f5e89d5320a6c1.css             3.62 kB
├   /_app                                  0 B            86.2 kB
├ ○ /404                                   352 B           103 kB
├   └ css/592400813383cf4a.css             1.65 kB
├ ○ /about-us                              4.32 kB         107 kB
├   └ css/75af6facd326ddc2.css             3.56 kB
├ ○ /advanced-usage                        11.4 kB         125 kB
├ ○ /dev-tools                             23.6 kB         165 kB
├   └ css/dc13500c2b23ad2f.css             4.51 kB
├ ○ /docs                                  1.89 kB         131 kB
├   └ css/a53db50d4f6b119d.css             1.33 kB
├ ○ /docs/formprovider                     4.45 kB         114 kB
├ ○ /docs/usecontroller                    2.24 kB         134 kB
├   └ css/1a24dcefce28bcc3.css             1.15 kB
├ ○ /docs/usecontroller/controller         1.92 kB         133 kB
├ ○ /docs/usefieldarray                    5.34 kB         134 kB
├ ○ /docs/useform                          6.84 kB         135 kB
├   └ css/b94db0100f612791.css             1.33 kB
├ ○ /docs/useform/clearerrors              2.04 kB         131 kB
├ ○ /docs/useform/control                  2 kB            131 kB
├ ○ /docs/useform/form                     3.71 kB         117 kB
├   └ css/469069d2e367f33a.css             1.05 kB
├ ○ /docs/useform/formstate                2.21 kB         133 kB
├ ○ /docs/useform/getfieldstate            6.18 kB         116 kB
├   └ css/a8b08f05a16f15d1.css             899 B
├ ○ /docs/useform/getvalues                2.22 kB         131 kB
├ ○ /docs/useform/handlesubmit             2.51 kB         131 kB
├ ○ /docs/useform/register                 5.6 kB          134 kB
├   └ css/4ba3ec25ce67451e.css             1.16 kB
├ ○ /docs/useform/reset                    3.36 kB         132 kB
├ ○ /docs/useform/resetfield               3.1 kB          116 kB
├ ○ /docs/useform/seterror                 2.88 kB         132 kB
├ ○ /docs/useform/setfocus                 1.96 kB         131 kB
├ ○ /docs/useform/setvalue                 2.72 kB         131 kB
├ ○ /docs/useform/trigger                  2.41 kB         131 kB
├ ○ /docs/useform/unregister               3.09 kB         132 kB
├ ○ /docs/useform/watch                    3.58 kB         132 kB
├ ○ /docs/useformcontext                   2.15 kB         131 kB
├ ○ /docs/useformstate                     1.86 kB         132 kB
├ ○ /docs/useformstate/errormessage        2.69 kB         131 kB
├ ○ /docs/usewatch                         3.59 kB         132 kB
├ ○ /faqs                                  8.95 kB         122 kB
├   └ css/e0a7f14ad20406e8.css             595 B
├ ○ /form-builder                          341 B           144 kB
├   └ css/0b14ab262faeac55.css             4.79 kB
├ ○ /get-started                           8.56 kB         122 kB
├   └ css/c68e59e9195ef58b.css             342 B
├ ○ /media                                 1.77 kB         104 kB
├   └ css/53730f1a362960d5.css             3.67 kB
├ ○ /migrate-v6-to-v7                      308 B          86.5 kB
├ ○ /resources/3rd-party-bindings          489 B           124 kB
├ ○ /resources/articles                    485 B           124 kB
├ ○ /resources/newsletters                 481 B           124 kB
├ ○ /resources/videos                      479 B           124 kB
└ ○ /ts                                    6.08 kB         119 kB
+ First Load JS shared by all              90.1 kB
  ├ chunks/framework-3671d8951bf44e4e.js   45.2 kB
  ├ chunks/main-abae530378ed5c02.js        37.1 kB
  ├ chunks/pages/_app-9618934e7bcbd203.js  3.06 kB
  ├ chunks/webpack-edd86ecd947b1f44.js     837 B
  └ css/e67e953385824197.css               3.92 kB

○  (Static)  automatically rendered as static HTML (uses no initial props)

oh wow, did you really convert the whole site into Nextjs? cc @jorisre

Oh wow ! 👏🏻 Seems working! I'll have a look later. Thanks a ton !

It really wasn't that bad moving to NextJS following https://nextjs.org/docs/migrating/from-gatsby
I'm pretty confident with the functionality working, but I'll be honest the CSS/ dark theme is probably going to get me in trouble and will probably require a bit of extra attention.
I also introduced a i18n to remove some files like https://github.com/react-hook-form/documentation/blob/51022f756c16e9e10dbf6e09238ef5a59f38e5f2/src/data/home.tsx
There's an auto extractor that will eventually remove all the hard coded text and translation effort can be done. ChatGPT does a decent job at least in Spanish with the prompt
can you translate the following strings to Spanish? just the keys

Would be dream come true if we have some sort of auto-translate, this is something people miss the most from the v6 doc, but there was a huge burden for me to maintain with 6 languages.

FYI merged this commit: https://github.com/react-hook-form/documentation/pull/941 hopefully not getting too much hustle for you.

Perhaps we can release the first version without the i18n. I think it would already been a huge win for us.

Perhaps we can release the first version without the i18n. I think it would already been a huge win for us.

Agree. Splitting it up into 3 parts to make this migration easier and less error prone

Running codemods. https://github.com/react-hook-form/documentation/pull/943/commits
Removing current language/ default language + fixing ALL TS errors (This way I don't need to disable it in next build :) )-> I have it ready but will wait for step-1.
Moving to nextjs. Smaller things like removing gatsby imports, adding new router, adding next-theme (Probably not modifying CSS files, still haven't been able to get that working)

Hopefully these smaller steps will lead to a more confident merge.

Closing this one since the better PR was merged :)


Documentation: Fixing xcode-select --switch command line option

Running man xcode-select only lists -s <path> or --switch <path> as valid options for switch.
I'm running on Big Sur 11.1 with Xcode Version 12.3 (12C33). I noticed this after I installed the latest Xcode update and ran brew doctor.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

3194 examples, 1 failure, 54 pendings
Had one unrelated test failure with: rspec ./test/language/java_spec.rb:15
1) Language::Java::java_home returns valid JAVA_HOME if version is not specified
     Failure/Error: expect(java_home/"bin/java").to be_an_executable

     NoMethodError:
       undefined method `/' for nil:NilClass
     # ./test/language/java_spec.rb:17:in `block (3 levels) in <top (required)>'
     # ./test/support/helper/spec/shared_context/homebrew_cask.rb:51:in `block (2 levels) in <top (required)>'
     # ./test/spec_helper.rb:204:in `block (3 levels) in <top (required)>'
     # ./test/spec_helper.rb:203:in `block (2 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-wait-0.0.9/lib/rspec/wait.rb:46:in `block (2 levels) in <top (required)>'

Thanks so much for your first contribution!  You rock, @morganick!

You're welcome, @MikeMcQuaid!


segmentation fault in jerryscript

the following js cause a segmentation fault in jerryscript.
function test(){
	function f(){
		var f = test();
	   	h = f();
	}
	return f;
}
let a = test();
c = a();

JerryScript revision
1a2c04763aba49f52b1537acd3730098c873511c
Build platform
Name the build platform. E.g., copy the output of
Ubuntu Lunar Lobster (development branch) (Linux 5.15.0-67-generic x86_64)
Build steps
export CC=clang
tools/build.py  --debug

Test case
function test(){
function f(){
var f = test();
h = f();
}
return f;
}
let a = test();
c = a();
Execution steps
./build/bin/jerry  test.js
Output
segmentfault
Backtrace
==51718==ERROR: AddressSanitizer: stack-overflow on address 0x7ffd01b29ff8 (pc 0x5596f1c550b6 bp 0x7ffd01b2a3e0 sp 0x7ffd01b29fe0 T0)
#0 0x5596f1c550b6 in vm_loop /home/zxw/jerryscript/jerry-core/vm/vm.c:970
#1 0x5596f1c676fd in vm_execute /home/zxw/jerryscript/jerry-core/vm/vm.c:5211
#2 0x5596f1c55050 in vm_run /home/zxw/jerryscript/jerry-core/vm/vm.c:5312
#3 0x5596f1c1aafc in ecma_op_function_call_simple /home/zxw/jerryscript/jerry-core/ecma/operations/ecma-function-object.c:1176
#4 0x5596f1c1d62d in ecma_op_function_call /home/zxw/jerryscript/jerry-core/ecma/operations/ecma-function-object.c:1406
#5 0x5596f1c678b6 in ecma_op_function_validated_call /home/zxw/jerryscript/jerry-core/ecma/operations/ecma-function-object.c:1371
#6 0x5596f1c678b6 in opfunc_call /home/zxw/jerryscript/jerry-core/vm/vm.c:758
#7 0x5596f1c678b6 in vm_execute /home/zxw/jerryscript/jerry-core/vm/vm.c:5217
#8 0x5596f1c55050 in vm_run /home/zxw/jerryscript/jerry-core/vm/vm.c:5312
#9 0x5596f1c1aafc in ecma_op_function_call_simple /home/zxw/jerryscript/jerry-core/ecma/operations/ecma-function-object.c:1176
#10 0x5596f1c1d62d in ecma_op_function_call /home/zxw/jerryscript/jerry-core/ecma/operations/ecma-function-object.c:1406
#11 0x5596f1c678b6 in ecma_op_function_validated_call /home/zxw/jerryscript/jerry-core/ecma/operations/ecma-function-object.c:1371
#12 0x5596f1c678b6 in opfunc_call /home/zxw/jerryscript/jerry-core/vm/vm.c:758
...
...
...
#366 0x5596f1c678b6 in opfunc_call /home/zxw/jerryscript/jerry-core/vm/vm.c:758
#367 0x5596f1c678b6 in vm_execute /home/zxw/jerryscript/jerry-core/vm/vm.c:5217
#368 0x5596f1c55050 in vm_run /home/zxw/jerryscript/jerry-core/vm/vm.c:5312
#369 0x5596f1c1aafc in ecma_op_function_call_simple /home/zxw/jerryscript/jerry-core/ecma/operations/ecma-function-object.c:1176
#370 0x5596f1c1d62d in ecma_op_function_call /home/zxw/jerryscript/jerry-core/ecma/operations/ecma-function-object.c:1406
SUMMARY: AddressSanitizer: stack-overflow /home/zxw/jerryscript/jerry-core/vm/vm.c:970 in vm_loop
==51718==ABORTING

CVE-2023-30414 was assigned for this issue.

Dup of #5039


Loosen the Graphene type system to allow contravariant function arguments

This partially implements the contravariant function arguments RFC by permitting to call nodes with any input if the node expects to receive () as an input
Related to: #1741

Load Image regression (works in master), however this works when the Transform node isn't included (you just have to zoom into the 1x1 image at the artboard origin):

Noise Pattern has the same regression:

Text doesn't have regressions, but oddly just... doesn't work when you add it from the node graph, but it does work when you add it from the Text tool and give it the same options. This is also the case in master, but I'm mentioning it here regardless.

I think I'll merge this now, though, and let you solve those regressions in a followup PR. Since I'd like to do a release today.


Quality of toBuffer vs toFile

Possible bug
Is this a possible bug in a feature of sharp, unrelated to installation?

[X] Running npm install sharp completes without error.
[X] Running node -e "require('sharp')" completes without error.

If you cannot confirm both of these, please open an installation issue instead.
Are you using the latest version of sharp?

[X] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.
If you are using another package which depends on a version of sharp that is not the latest, please open an issue against that package instead.
What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?
System:
OS: macOS 13.3.1
CPU: (8) arm64 Apple M1 Pro
Memory: 35.73 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 16.16.0 - ~/.nvm/versions/node/v16.16.0/bin/node
npm: 8.11.0 - ~/.nvm/versions/node/v16.16.0/bin/npm
npmPackages:
sharp: ~0.32.0 => 0.32.0
What are the steps to reproduce?
See https://github.com/thadclay/sharp_image_quality/blob/main/index.js
Given a jpeg input file
Resizing the input file and writing the result to file directly and also sending toBuffer and then writing to file.
What is the expected behaviour?
It should produce the same output.
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem
https://github.com/thadclay/sharp_image_quality/blob/main/index.js
Please provide sample image(s) that help explain this problem
Input File
https://raw.githubusercontent.com/thadclay/sharp_image_quality/main/inputs/flowers_v1.jpg
Output files
https://raw.githubusercontent.com/thadclay/sharp_image_quality/main/outputs/flowers_v1_convert_file_direct.jpg
https://raw.githubusercontent.com/thadclay/sharp_image_quality/main/outputs/flowers_v1_convert_buffer_to_file.jpg

Thank you. I didn't realize it but I was using sharp incorrectly. Thanks for clearing this up.


Update faq.md question regarding support in non-Azure environments

@gkostal : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good. #sign-off


Update moment.js

fix typo

I'm not sure this is the correct file to change. The code you've amended resides in src/lib/create/from-array.js and should be changed there.

Correct, this isn't the right file to change. Closing, feel free to re-open on correct file.


Add link to CONTRIBUTING.md file in README.md

Overview
We need to link to the CONTRIBUTING.md file in the README.md so contributors can more easily see the contributing guidelines.
Action Items

[ ] Under the title in Bloom Backend section in the README.md, above "Technologies Used", add the following:
"To make a contribution, please read our Contributing Guidelines in CONTRIBUTING.md"
[ ] Make sure the sentence above contains a Markdown link to the repo's CONTRIBUTING.md file.

Resources/Instructions

How to Create Markdown Links

Hi! May I pick this up?

Thanks for your interest @maryamkhan14! I see you commented on 2 no-code, good first issues, we limit 1 no-code, good first issue per contributor! Let us know which one you'd prefer an I'll get you assigned ASAP. :)

Hey @FardeenCODEIIEST, thank you for asking! Yes I have assigned the issue to you.


Failed to install on AWS Linux 2

FailedToInstall_Python_PKCS11_Latest.log

Hi, you need to be using Python 3, it looks like you're using Python 2.


a bug with "Dvorak - QWERTY ⌘" layout

VSCode Version: Version 1.12.1 (1.12.1)
OS Version: macOS 10.12.4 (Sierra)

Steps to Reproduce:

add a Dvorak - QWERTY ⌘ keyboard layout
press ⌘ + any-key , It's still using Dvorak not QWERTY

e.g.
press ⌘J, it should be ⌘C, but in vscode, it is still ⌘J

@viosey for the Dvorak - QWERTY ⌘ keyboard layout we now default to dispatching on keyCode. We recognise the keyboard layout via the id com.apple.keylayout.DVORAK-QWERTYCMD.
Can you please open an editor, then run F1 > Developer: Inspect key mappings, save the output to a file and attach it here?

I restart vscode, and it became normal, seems the bug will not reproduce every time.
The attach file is normal one, if this bug reproduces again, I will post it again.
key-mapping.txt

:+1: - closing for now - please reopen if you find reproducible steps.

I found the reproducible steps.

Install this Chinese pinyin Input
Use Dvorak - QWERTY ⌘ layout.

And open vscode

The following is the error key-mapping
key-mapping.txt

@viosey
It appears this keyboard layout always identifies itself as com.sogou.inputmethod.sogou.pinyin (from your attached file), even when you have selected QWERTY ⌘ in the above dialog. In other words, we cannot detect when the input method is switched to QWERTY ⌘, as it just reports the same identifier.
You can workaround by using "keyboard.dispatch": "keyCode" and restarting VS Code in your settings. I don't believe there is any code change we can do on our side to detect when the input method is switched, since it reports the same identifier.

Thanks!
"keyboard.dispatch": "keyCode" is work!


does this repo work on cpu?

Hello, does this repo work on cpu?
in particular the part in the OP folder?
seems this only works only on Cuda?
Are there some settings which can be set to enable running on CPU?

did you found a solution for this? I'm trying to run it on CPU and have the same questions as you. Thank you!


Parsing of mzXML files with zero (0) scans fails, raising a MzxmlParseError: 'scan'

BUG DESCRIPTION
Problem

Attempting to parse an mzXML file that has zero (0) scans results in a MzxmlParseError: 'scan' error. These files can probably be skipped atm, since they are relatively useless, but it would be nice to be able to process them like any other since it seems the upstream pipeline creates them without issues or warnings.
Steps to reproduce

Performed on tracebase-dev (so that the required samples exist, etc.)python ${TRACEBASE_DIR}/manage.py load_msruns \
--mzxml-files "./220701_exp027f3_free_liver/scan3/"*.mzXML \
--instrument "Exploris240" \
--date "2022-07-01" \
--lc-protocol-name "polar-HILIC-25-min" \
--operator "Michael Neinast"

An alternative would be to execute the parse_mzxml file on the attached file (note the file is gzipped to allow upload to GitHub, it should be unzipped before processing): exp027f2_M01_liver.mzXML.gz
Current behavior

  File "/var/www/tracebase/manage.py", line 22, in <module>
    main()
  File "/var/www/tracebase/manage.py", line 18, in main
    execute_from_command_line(sys.argv)
  File "/var/www/tracebase/DataRepo/management/commands/load_table.py", line 382, in handle_wrapper
    retval = fn(self, *args, **options)
  File "/var/www/tracebase/DataRepo/management/commands/load_msruns.py", line 136, in handle
    self.load_data()
  File "/var/www/tracebase/DataRepo/management/commands/load_table.py", line 423, in load_data
    return self.loader.load_data(*args, **kwargs)
  File "/var/www/tracebase/DataRepo/loaders/table_loader.py", line 1951, in load_wrapper
    retval = fn(*args, **kwargs)
  File "/var/www/tracebase/DataRepo/loaders/msruns_loader.py", line 352, in load_data
    self.get_or_create_mzxml_and_raw_archive_files(mzxml_file)
  File "/usr/lib64/python3.9/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/var/www/tracebase/DataRepo/loaders/msruns_loader.py", line 453, in get_or_create_mzxml_and_raw_archive_files
    mzxml_metadata, errs = self.parse_mzxml(mzxml_file)
  File "/var/www/tracebase/DataRepo/loaders/msruns_loader.py", line 1386, in parse_mzxml
    errs_buffer.buffer_error(MzxmlParseError(str(ke)))
  File "/var/www/tracebase/DataRepo/utils/exceptions.py", line 1415, in buffer_error
    return self.buffer_exception(
  File "/var/www/tracebase/DataRepo/utils/exceptions.py", line 1369, in buffer_exception
    buffered_tb_str = self.get_buffered_traceback_string()
  File "/var/www/tracebase/DataRepo/utils/exceptions.py", line 1349, in get_buffered_traceback_string
    for step in traceback.format_stack()
EXCEPTION1(ERROR): MzxmlParseError: 'scan'

Expected behavior

The file would be loaded, even though it contains no scans. Alternatively, it could be skipped due it being relatively useless.
Suggested Change

None provided
Comment

None

ISSUE OWNER SECTION
Assumptions

List of assumptions made WRT the code
E.g. We will assume input is correct (explaining why there is no validation)

Limitations

A list of things this work will specifically not do
E.g. This feature will only handle the most frequent use case X

Affected Components

change: File path or DB table ...
add: Environment variable or server setting
delete: External executable or cron job

Requirements

[ ] 1. List of numbered conditions to be met for the feature
[ ] 2. E.g. Every column/row must display a value, i.e. cannot be empty
[ ] 3. Numbers for reference & checkboxes for progress tracking

DESIGN
GUI Change description

None provided
Code Change Description

None provided
Tests

[ ] 1. A description of at least one test for each requirement above.
[ ] 2. E.g. Test for req 2 that there's an exception when display value is ''
[ ] 3. Numbers for reference & checkboxes for progress tracking

The upstream pipeline does create these automatically.  I agree they are useless and could be skipped.

OK, I'm going to close this issue. If we encounter these in the future we can simply ignore/delete the files.

I'm fine with closing this, though I think the fix would likely be 1 line of code (maybe 6, but it's an easy issue in my estimation).

Is storing of the empty mzXML a good thing to do though? It sounds like those files are an artifact of the raw file conversion and don't contribute any meaningful information. In which case, they would just confuse things.

Point taken, however, ignoring that load file with a warning would arguably not taken any more lines of code and would save the manual effort of having to re-run after removing that file.  That said, I'm fine with this remaining closed however.

By "Point taken" and suggesting that we skip their load, I meant to convey that I was conceding just that.  But I guess you're talking about the existence of the files on the msdata share...  If so, that's fair, however there's also nothing (I think) from preventing them to persist there anyway.  Aren't those files copied out of the share for loading?  I could be wrong.  I just don't know, so I'm asking.


Support DateTime.ToString(string)

I have a query like db.Records.Where(record => (record.Created.ToString("MM/dd/yyyy hh:mm:ss tt") ?? "").ToLower().Contains("11/")).ToList(); where Created is a DateTime
The query that is generated does not contain any where so in this example it doesn't appear to have an effect, but when I add other criteria that limits the result set then we start to see the issue with the query not executing in SQL.
My use case here is that I have a table rendered on the page and I am setting the display format of the DateTime.  I allow the user to search that table column, but to provide them reliable results I need to know the format the user sees to know how to search it in the database.  The result set is huge so rendering everything in the client and sorting client side is not an option.
Further technical details
EF Core version: 2.0.0
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2017

Related https://github.com/aspnet/EntityFrameworkCore/issues/7364

@los93sol - It appears you want to allow your users to search the Created date for records created on specific days of the month, or months of the year?
If that is the case then you can do the following
int searchValue = 11 ;
b.Records.Where(record => (record.Created.Month == searchValue || record.Created.Day == searchValue)).ToList();

This will translate into DATEPART method calls.

Thanks for the suggestion, that is similar to what I’m trying to do, but I was hoping to allow the user to search it as a string to avoid building a picker for the UI

You could create a User defined function in your context for which you can provide a SQL translation and we would just invoke it on server. That would allow you to translate date to specific conversion format on server rest would just work.
Example (Put this in your derived DbContext class
        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            // Configure model
            modelBuilder.HasDbFunction(typeof(MyContext).GetMethod(nameof(MyContext.ToCustomString))).HasTranslation(
                e =>
                {
                    return new SqlFunctionExpression("convert",
                        typeof(string),
                        new[]{
                            new SqlFragmentExpression("VARCHAR(100)"),
                            e.First(),
                            new SqlFragmentExpression("101"), // Pick a style available on T-SQL.
                        });
                });
        }

        public static string ToCustomString(DateTime date)
        {
            return date.ToString("MM/dd/yyyy hh:mm:ss tt"); // You can just throw NotImplementedException too
        }

Query
var query = db.Blogs.Where(b => MyContext.ToCustomString(b.Created).ToLower().Contains("11/")).ToList();

Generates SQL
      SELECT [b].[Id], [b].[Created]
      FROM [Blogs] AS [b]
      WHERE CHARINDEX(N'11/', LOWER(convert(VARCHAR(100), [b].[Created], 101))) > 0

Thank you!  That's almost perfect and exactly what I was looking for, but I am in an abstraction layer where I am providing the functionality via an extension method of IQueryable and cannot figure out how to get at the modelBuilder.  If I could sort that out then I think I know what to do from there to sort it on my end.

One restriction is method has to be static. You can move it to different type than DbContext if needed. To be able to call from IQueryable and OnModelCreating both you need to put in some place which is referenced by both.

One thing to consider is that you are going to have bad performance on with this query.
The query is going to force a conversion on your Created column, from datetime to nvarchar, which will prevent using any indexes in the query.
Depending on how big the table is this could be a problematic query.

@pmiddleton, thanks for pointing that out, my plan was to actually change this to use format instead of convert, thinking that would be more efficient in sql

Duplicate of #7364


glfwSwapBuffers does not block with swap interval > 0 when window is minimized or covered by another window

The docs of glfwSwapBuffers say that this call will vsync (to it's best ability in windowed mode i guess) if the swap interval is > 0.
This works if the window is partially visible (either full-screen or windowed mode). It actually doesn't "vsync" if the window is fully covered by another window or if the window is minimized. Is this by design? Only tested on Mac OS X.
I'm not sure if this could/should be "fixed" in GLFW or if it's the responsibility of the application to take care of it. However, it should at least be documented in the glfwSwapBuffers docs that no vsync'ing happens in case the window is fully covered or minimized.

If App Nap is working as I understand, is this a problem? Hopefully, what's happening is that glfwSwapBuffers isn't blocking, but the app is still being suspended enough that the power savings are even greater than with just vsync.
Or did you want to disable that power saving functionality instead?

If App Nap is working as I understand, is this a problem? Hopefully, what's happening is that glfwSwapBuffers isn't blocking, but the app is still being suspended enough that the power savings are even greater than with just vsync.
Or did you want to disable that power saving functionality instead?

If you implement a render server, for example, an application that creates images to be displayed on some other device, or just for screenshots, that application might run in the background. App Nap might suspend it. A primary reason to disable app nap is to enable server applications.

If you implement a render server, for example, an application that creates images to be displayed on some other device, or just for screenshots, that application might run in the background. App Nap might suspend it. A primary reason to disable app nap is to enable server applications.

My use case is to put the app mostly to sleep when obscured/minified. Doable from the application code itself. Thanks for the clarification @elmindreda!

I think an application should suspend its rendering when the window is occluded. There is no point continue rendering when there is nothing to see.
But as far as I know there is no way to check the occlusion state with GLFW. Maybe one could change glfwGetWindowAttrib(window, GLFW_VISIBLE) to return 0 if the window is occluded?
When a window changes its occlusion state windowDidChangeOcclusionState:(NSNotification *) is called on the window delegate. I don't know if there is an easy way to check occasion state on there systems.

I think an application should suspend its rendering when the window is occluded. There is no point continue rendering when there is nothing to see.

This is not always true.
Have a look at my use case here.
I will looking into this issue as well.
Maybe, I can be of help 😄

As a side-effect of fixing #1337, OpenGL vsync now uses a display link and is not affected by window occlusion.


Add an option to open files in the folder of the file or a new window

Currently, the "Window: Open Files In New Window" Setting has three options:
on: Files will open in a new window.
off: Files will open in the window with the files' folder open or the last active window.
default: Files will open in a new window unless picked from within the application (e.g. via the File menu).
I would like to see a hybrid version of this option where a file whose parent folder is already open will attach to that window, but a file whose parent folder is not already open will open in a new window.
For instance, let's say I have the vscode repository open already. When I open ~/repos/vscode/src/vs/css.ts from File Explorer, it should open in the window I have open already. Conversely, when I open ~/Desktop/notes.txt from File Explorer, it should open in a new window, since neither ~/Desktop nor any of its parent directories are open already.
(also tangentially related, I don't see what the difference between "on" and "default" is. They seem to produce the same behavior when opening files from within the app and externally.)
Just in case, here is my version info:
Version: 1.86.1 (user setup)
Commit: 31c37ee8f63491495ac49e43b8544550fbae4533
Date: 2024-02-07T09:08:20.941Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

I see this would be useful if you have different modes, e.g. you could have all your Dart files open in one window, and all C# files in another (I'm using Unity with Flutter for reference).

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Why not show the pictures in "overview"?

I can't see the the in detail in subject until seeing pictures.
Hopefully update this feature, thanks a lot.

Feature

Version 1.24.0<PHONE_NUMBER>)
Device: iPhone SE (iOS 12.1)
TestFlight: true

I am closing this issue because it is a dup of #1694
Sent with GitHawk


Attempt to fix flaky test in integration/launcher_test.TestReadOnlyFileSystem

What does this PR do?
Attempts to remove a flaky test.
Motivation
TestReadOnlyFileSystem has been failing regularly.

Closing as this seems to have made the test break in more unexpected ways.


added a link to my butterfly quiz app written from scratch in Zig/raylib

A couple of months ago I created a simple desktop app from scratch in Zig version 0.11.0 and Raylib that is a simple quiz app. It's a simple and clean example of a Zig project, and I think many folks could benefit from its inclusion on this list, especially those looking for a simple Zig/raylib project.

Oops realized I hadn't added my app in alphabetical order. Correcting now...


Netopeer2 CLI compile issue on glibc

Hi,
I encountered some problems while compiling Netopeer2 CLI on uClibc.

mkstemps not supported (this is not a problem, similar to sysrepo ).
eaccess not supported.

Can you tell is it safe to replace eaccess with access?
Or do you know some other solution?
I compiled Netopeer2 CLI with #define eaccess access and it works but I am not sure how to properly test it.
Regards,
Mislav

Hi Mislav,
it should be fine using access instead eaccess, they are likely to give similar result (EUID equals UID) and even if not, it is used mostly for checks, wrong return value should not cause any actual error.
Regards,
Michal


Allow users to utilize server.port value in vite.config.[ts/js] files.

Problem
Hard-coded port value prevents user from using configured Vite port in vite.config.[ts/js] files.
Reproduction

Create new project via npm init @electron-esbuild/app.
Specify any Vite project template.
In your Vite frontend, add the following server property to vite.config.ts or vite.config.js file:

server: {
  port: 9089 // Something different from the hard-coded 9080 value.
}

Run the project.
Observe port 9080 is still the preferred port.

Notes on Changes

Removal of the hard-coded default.

This a breaking change to existing users who assume the 9080 port value. This value should have been included as part of the initial templates, so I went ahead and added them. Feel free to reach out if you have any questions or concerns about this.

Please test locally before considering a merge. While I can confirm the fix on my end, I always suggest measuring twice before cutting.

Hey!
I missed this PR, I'll test it on my side to confirm the fix.
Thanks you for the PR 😃 .

Hey! Thanks again for the PR.
Just tested the branch, this seem to work.
Please create an "unreleased" entry in the packages/electron-esbuild/CHANGELOG.md file.
Template:
## Unreleased

### Breaking Changes

...

Thanks, and will do.

@Kiyozz Done. Let me know if that is in need of a change.


Writing about various features ksctl provides

### Tasks
- [ ] Adding the purpose
- [ ] what all challenges it resolves
- [ ] how it achieves
- [ ] what are its functionalities

I'm not able to understand what to write, I mean the table of contents or topics I need to write, can you please help. @saiyam1814 @dipankardas011

acc to me you can refer the docs for topics

you can tell what is ksctl
what problems it tries to solve
what solution it provides (till now)
and some key features...

cc @verma-kunal @saiyam1814 you you have any thing to add

@shaikahmadnawaz are you working on it?

Hello @dipankardas011, in which folder (absolute path) of this repo shall I raise a PR of the blog?

@shaikahmadnawaz  I think we should write the blog to kubesimplify blogs
if you are okay with this. SOrry for the late correction
cc @saiyam @pavangudiwada

@shaikahmadnawaz I think we should write the blog to kubesimplify blogs if you are okay with this. SOrry for the late correction
cc @saiyam @pavangudiwada

https://github.com/kubesimplify/ksctl-docs/tree/main/content/en/blog
Do you mean here? @dipankardas011

@shaikahmadnawaz I think we should write the blog to kubesimplify blogs if you are okay with this. SOrry for the late correction
cc @saiyam @pavangudiwada

Yes, I am ready to write in Kubesimplify blogs 👍

@shaikahmadnawaz I think we should write the blog to kubesimplify blogs if you are okay with this. SOrry for the late correction
cc @saiyam @pavangudiwada

https://github.com/kubesimplify/ksctl-docs/tree/main/content/en/blog
Do you mean here? @dipankardas011

I am refering to hashnode
and from there we can get the blogs via rss feeds. @verma-kunal

https://hashnode.com/@shaikahmadnawaz
this is my Hashnode profile 👆, I think I need access to write in Kubesimplify blogs right?

Access in the sense of permission to write for the Kubesimplify blog?
https://blog.kubesimplify.com

I am not sure with the current process, but you have to raise a PR to kubesimplify-blogs repo or you have to publish via hashnode

@shaikahmadnawaz you have to directly submit it to hashnode

@shaikahmadnawaz you have to directly submit it to hashnode

https://shaikahmadnawaz.hashnode.dev
Shall I write in my blog directly? ☝

No, you have to publish it to kubesimplify hashnode
I have added you as contributor

Like this

Got it, Thank you @dipankardas011.

Just completed the latest blog on Ksctl! 🚀 your review would be awesome! @dipankardas011

sure

like a section on Lets have it on action

@shaikahmadnawaz If you get any cloud cost I can pay you for that make sure you dm me on discord. and delete the resource as soon as possible for minimum cost

simple demo of creation and deletion of clusters (both managed, HA)
Also manually scaleup and scaledown?

simple demo of creation and deletion of clusters (both managed, HA)
Also manually scaleup and scaledown, how to do this any reference or explanation please @dipankardas011
I know only this https://kubesimplify.github.io/ksctl-docs/docs/getting-started/cli, based on this I have installed Ksctl cluster.

yes

Here are some of my commands
ksctl cred
# add your credentials

here you go https://github.com/kubesimplify/ksctl-cli/blob/27d90e596ee0f4850f7edb28701a4c1c5837a1fc/.github/workflows/test-mock.yml#L42
for civo
and for azure https://github.com/kubesimplify/ksctl-cli/blob/27d90e596ee0f4850f7edb28701a4c1c5837a1fc/.github/workflows/test-mock.yml#L48

Also to demonstrate the working of custom CNI and development ready apps
https://kubesimplify.github.io/ksctl-docs/blog/1/01/01/feature-install-applications/
it works for both managed and HA cluster
I would suggest after doigng the above
you can say lets try some new experiemental aka alpha features
and use a managed offering as its easier and faster

Now I am getting some changes needed to be done in docs website

Also to demonstrate the working of custom CNI and development ready apps https://kubesimplify.github.io/ksctl-docs/blog/1/01/01/feature-install-applications/
it works for both managed and HA cluster
I would suggest after doigng the above you can say lets try some new experiemental aka alpha features and use a managed offering as its easier and faster

For the apps options are

argo-rollouts
argocd
istio
prometheus-stack

for the cni

cilium
azure -> for aks
flannel (default) -> for ha default in k3s so no need
kubenet
kind

Also @shaikahmadnawaz these files contain the valid fields for each cloud provider
these are used for e2e testing
Azure -> https://github.com/kubesimplify/ksctl/tree/main/test/e2e/azure

Guide on commands
cc @shaikahmadnawaz

Note
the commands linked contain both the HA cluster and for manage cluster. Also Scaleup&down work for HA cluster

ALso, check the region, clustername, nodeSize, no of controlplanes and ,...etc

ALso Dont Use --approve tag

Here are some of my commands
ksctl cred
# add your credentials

Create
Azure
https://github.com/kubesimplify/ksctl-cli/blob/27d90e596ee0f4850f7edb28701a4c1c5837a1fc/.github/workflows/test-mock.yml#L51-L52
Civo
https://github.com/kubesimplify/ksctl-cli/blob/27d90e596ee0f4850f7edb28701a4c1c5837a1fc/.github/workflows/test-mock.yml#L45-L46
Get
https://github.com/kubesimplify/ksctl-cli/blob/27d90e596ee0f4850f7edb28701a4c1c5837a1fc/.github/workflows/test-mock.yml#L72
Switch
Azure
https://github.com/kubesimplify/ksctl-cli/blob/27d90e596ee0f4850f7edb28701a4c1c5837a1fc/.github/workflows/test-mock.yml#L83-L84
Civo
https://github.com/kubesimplify/ksctl-cli/blob/27d90e596ee0f4850f7edb28701a4c1c5837a1fc/.github/workflows/test-mock.yml#L77-L78
Scalingup and down
Civo
https://github.com/kubesimplify/ksctl-cli/blob/27d90e596ee0f4850f7edb28701a4c1c5837a1fc/.github/workflows/test-mock.yml#L90-L91
Azure
https://github.com/kubesimplify/ksctl-cli/blob/27d90e596ee0f4850f7edb28701a4c1c5837a1fc/.github/workflows/test-mock.yml#L96-L97
Delete
Civo
https://github.com/kubesimplify/ksctl-cli/blob/27d90e596ee0f4850f7edb28701a4c1c5837a1fc/.github/workflows/test-mock.yml#L102-L103
Azure
https://github.com/kubesimplify/ksctl-cli/blob/27d90e596ee0f4850f7edb28701a4c1c5837a1fc/.github/workflows/test-mock.yml#L109-L110

Also @shaikahmadnawaz these files contain the valid fields for each cloud provider
these are used for e2e testing
Azure -> https://github.com/kubesimplify/ksctl/tree/main/test/e2e/azure
Civo -> https://github.com/kubesimplify/ksctl/tree/main/test/e2e/civo

Okay, thank you 👍🏻

@shaikahmadnawaz are you facing blockers?

@shaikahmadnawaz are you facing blockers?

Not yet, I was a little busy with college work, but I will start now.

@shaikahmadnawaz are you facing blockers?

Not yet, I was a little busy with college work, but I will resume now, Sorry for the delay.

Np, sure 👍🏼

@shaikahmadnawaz I hope your college work has reduced. No worries if you're still working on it - just wanted to make sure it's still on your radar. Let me know if you need any assistance or have any questions! 😄

@shaikahmadnawaz I hope your college work has reduced. No worries if you're still working on it - just wanted to make sure it's still on your radar. Let me know if you need any assistance or have any questions! 😄

@dipankardas011 Thanks for asking! College work is okay for now. If I get stuck or have questions, I'll definitely let you know. Your support means a lot. 😊

@shaikahmadnawaz I hope your college work has reduced. No worries if you're still working on it - just wanted to make sure it's still on your radar. Let me know if you need any assistance or have any questions! 😄

@dipankardas011 Thanks for asking! College work is okay for now. If I get stuck or have questions, I'll definitely let you know. Your support means a lot. 😊

sure ready to help 👍🏼

Thanks @shaikahmadnawaz for writing a blog on ksctl!
if you are willing a different blog on ksctl working and demo I am happy to reassign u

Thanks @shaikahmadnawaz for writing a blog on ksctl!
if you are willing a different blog on ksctl working and demo I am happy to reassign u

Thank you @dipankardas011 for giving me this opportunity ❤🙌

Thanks @shaikahmadnawaz for writing a blog on ksctl!
if you are willing a different blog on ksctl working and demo I am happy to reassign u

I'll let you know once I'm done with my college work. Thanks a lot, @dipankardas011.


RFC6810 is only partally supported, answering End of Data PDU in rfc8210 format

Routinator is partally supporting rfc6810 (PDU, versjon 0) since it is answering End of Data PDU according to rfc8210 (Version 1).
Tested on Juniper router with Junos 17.3R3.10.
Junos does not support rfc8210, but when changing EndOfData reply, the session to the Juniper router
came up.
Routinator 3000 needs to reply End of Data according to version.
POC code diff:
(I'm no rust programmer, so its a hack)
diff --git a/src/rtr/pdu.rs b/src/rtr/pdu.rs
index e8e2c23..7218072 100644
--- a/src/rtr/pdu.rs
+++ b/src/rtr/pdu.rs
@@ -397,9 +397,9 @@ impl AsMut<[u8]> for Prefix {
 pub struct EndOfData {
     header: Header,
     serial: u32,
-    refresh: u32,
-    retry: u32,
-    expire: u32,
+//    refresh: u32,
+//    retry: u32,
+//    expire: u32,
 }

 #[allow(dead_code)]
@@ -413,11 +413,11 @@ impl EndOfData {
         expire: u32
     ) -> Self {
         EndOfData {
-            header: Header::new(version, 7, session, 24),
+            header: Header::new(version, 7, session, 12),
             serial: serial.to_be(),
-            refresh: refresh.to_be(),
-            retry: retry.to_be(),
-            expire: expire.to_be(),
+//            refresh: refresh.to_be(),
+//            retry: retry.to_be(),
+//            expire: expire.to_be(),
         }
     }

@@ -433,17 +433,17 @@ impl EndOfData {
         u32::from_be(self.serial)
     }

-    pub fn refresh(&self) -> u32 {
-        u32::from_be(self.refresh)
-    }
-
-    pub fn retry(&self) -> u32 {
-        u32::from_be(self.retry)
-    }
-
-    pub fn expire(&self) -> u32 {
-        u32::from_be(self.expire)
-    }
+//    pub fn refresh(&self) -> u32 {
+//        u32::from_be(self.refresh)
+//    }
+//
+//    pub fn retry(&self) -> u32 {
+//        u32::from_be(self.retry)
+//    }
+//
+//    pub fn expire(&self) -> u32 {
+//        u32::from_be(self.expire)
+//    }
 }

Thanks for trying Routinator and the report!
Routinator actually was supposed to implement both version 0 and 1 of RTR and let the client choose. Apparently I overlooked the changed EndOfData PDU.
I have pushed a commit to the master branch that should fix the issue and always send the right PDU. Can you try with that?
If you installed via cargo install, you can simply install the master branch via
cargo install -f --git https://github.com/NLnetLabs/routinator.git

Thanks Christian for the report, thanks Martin for the quick fix.
I can confirm that on Juniper MX Series Routers with Junos version 17.4R1.16 sessions are now stable, whereas before with routinator built just before Martin pushed this fix the router would drop sessions after about 30 seconds. It fully updated the validation database and then dropped the session, causing unnecessary load on the routeur.
Many thanks!

Phew!


Update ACS PolicySet to replace expired init-bundle

Updates to existing stable ACS PolicySet for  OpenShift+ includes:

Replacing Job with v2 as Job definition is immutable.  Removes original Job if it exists
Creating policy to remove init-bundle created secrets and v2 Job if CertificatePolicy is in NotCompliant state.  Set logner evaluation period to give time for init-bundle Job to recreate and move CertificatePolicy to Compliant state.
Corrected Policy dependencies such that CertificatePolicy is dependent on init-bundle creation and not sync of secrets. Removal of init-bundle output breaks sync policy until they are recreated
Corrected Policy dependencies such that secret sync is dependent on init-bundle creation and not central install

Refs:

https://issues.redhat.com/browse/ACM-9075

/approve
/hold

I added a hold while I test this.  I do see a Pending policy which means I need to update the OPP QE script that tests this policy set.  We just made an update last week to validate the policies aren't in the pending state :smile:

The side effect of using a NonCompliant dependency, it will always show as Pending.
I was just talking with cstark about this earlier.  The policy showing as "pending" seems wrong to me.  Yes technically the dependency is not met and it is pending to execute.  But in this case it is expected to be in that state.  The policy executing means another Policy is in an out of compliance state.  If out of compliance is a red (bad) icon, then the dependency being satisfied should also be reflected as bad.
The overview page for Governance calls out pending policies as if something is incorrect and needs attention.  But in this use case that assumption seems incorrect since the policy is in the expected state.

We have an ignorePending=true flag that can be added which I think is what we want here.  That effectively keeps the policy in a Pending mode but the state is reported as Compliant.  So far it seems to be working anyway...

@gparvin   I added ignorePending

/unhold


Remote Collection with DDP.connect

Would be awesome to be able to do a remote collection on FS.Collection just like one can on the Meteor.Collection with DDP.connect
Something like this would be amazing, and still be able to do uploads to s3, the filesystem and all that.
RemoteServer = DDP.connect('http://localhost:4000');
Files = new FS.Collection('files', {
  connection: RemoteServer
});

+1, need this.
It seems like with s3, if you copy the configuration to the other application, it will be able to upload it to your remote application, but with tons of errors

+1 on this. Really need one ^_^

Hello @aldeed !
I want to use FS.Collection on remote client. Is it possible?
On the server image collection:

@achirkof  Hi, have you found solution to solve this problem? I don't know what to do here.

@vipMura Hi! No, I haven't. Generally I have desided to make native mobile app and exchange data between web and mobile using REST Api.

Has anyone found a solution to this problem? If yes please tell or suggest some alternate way to achieve this


Runnable component

Draft, for the build

The mechanism was included in #367 so I am closing this PR for now


Publish to npm

Hi, thanks for the very useful component.
I would like to ask you if you plan to publish an npm package? If yes do you know the timeframe?
@kushalmehrotra713
Regards
Christos

Hi Christos,
Glad that you find the component useful.
I was planning to go about the npm publishing on a need basis. Now that you mentioned it, I can plan to publish it in 2 week's time.
Regards,
Kushal

@kushalmehrotra713  That would be great! Otherwise I would have to fork it.
Thanks!

We are also looking at this, could someone outline the steps needed for me to use this in a project?
How do output a package that i can consume from my own project that uses latest fluentui react package?

We would also love it if this was in npm. One of the biggest hurdles for us with trying to use Fluent UI for our new project is the lack of an editable, exportable data grid. DetailsList alone just isn't cutting it. This is super neat.

Hi @unseen1980 , @viktorsteinwand  , @pksorensen  , @nikki9696
Apologies for the delay in this. I will be publishing npm package for the grid in the next 2 days. I will notify it in the same space and will be closing this issue after publish.
Thanks,
Kushal

Hi @unseen1980 , @viktorsteinwand , @pksorensen , @nikki9696
Apologies for the delay in this. I will be publishing npm package for the grid in the next 2 days. I will notify it in the same space and will be closing this issue after publish.
Thanks,
Kushal

Hi @unseen1980 @viktorsteinwand @pksorensen @nikki9696 ,
Npm package for this grid can be found at https://www.npmjs.com/package/fluentui-editable-grid.
Installation:

npm i fluentui-editable-grid

Please refer to the documentation on the npm page to get you started and do let me know if there are any bugs/feature requests that need to addressed. I am closing this issue now.
Cheers.


Precision is lost when switching conversions

Describe the bug

While general math does not lose precision (see #119), unit conversions do.
From my perspective, this is a bug, but I suspect fixing this would make it a feature request. I'm filing it as a bug because the information required here and the information I have available more closely fit the bug filing form.
Steps To Reproduce

Open Calculator
Tap ≡
Tap Power
Tap Kilowatts (top unit -- this computer is en-US not en-GB where the default is Watts)

Step 1: (3/7/2019 11:10:37 AM) User left click on "Six (button)" in "Cal"

Step 2: (3/7/2019 11:10:38 AM) User left click on "Zero (button)" in "Cal"
Step 3: (3/7/2019 11:10:41 AM) User left click on "Converts into 3.412141 BTUs/minute (text)" in "Cal"
Step 4: (3/7/2019 11:10:42 AM) User left click on "Input unit (combo box)" in "Cal"
Step 5: (3/7/2019 11:10:43 AM) User left click on "Foot-pounds/minute (text)" in "Cal"
Step 6: (3/7/2019 11:10:46 AM) User left click on "Input unit (combo box)" in "Cal"
Step 7: (3/7/2019 11:10:47 AM) User left click on "BTUs/minute (text)" in "Cal"
Step 8: (3/7/2019 11:10:49 AM) User left click on "Converts into 59.9999972482667 Watts (text)" in "Cal"
Step 9: (3/7/2019 11:10:50 AM) User left click on "Steps Recorder - 1 running window (button)"

Expected behavior

Ideally it would still show 60 Watts in the top field.
This would require unit conversions to cooperate with the ratpack
Screenshots

Note: this was recorded w/ psr.exe, so I have screen shots for all of the recorded steps (and I could trivially re-record w/ the missing initial setup steps.
Device and Application Information (please complete the following information):

OS Build: 10.0.17134.0
Architecture: X64
Application Version: 10.1811.3241.0

Additional context

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

Thanks for the report! I really appreciate your thoroughness when filing this bug. I was able to verify this across other converters as well, including Speed and Pressure.

Fwiw, I've started stepping through how to do this here:
https://github.com/jsoref/Microsoft-calculator/commits/issue-177
If someone familiar w/ RAT/PRAT could give me some pointers, I think this might be somewhat close to something. (I haven't touched the tests, nor have I fed this code to a compiler.)

If someone familiar w/ RAT/PRAT could give me some pointers, I think this might be somewhat close to something. (I haven't touched the tests, nor have I fed this code to a compiler.)

cc @joshkoon


How to clip a picture of a polygon through a path

Hi,Man~
I want to consult how to cut out the drawn path image information and output it to the new content through the drawing of the path
source picture: https://img-blog.csdnimg.cn/20210308113406132.png
Effect picture after cutting: https://img-blog.csdnimg.cn/20210308113621684.png

I've tried some ways, but I don't know what's better to do with my business scenarios.
Because there are complex custom paths, such as star and diamond, to process the selected path image

I tried this examples  rotated-image.go ,Solved my problem
The main code is
dc.??Preserve()
dc.Clip()
dc.DrawImageAnchored(im, ...)


Created and updated docs for 1.25-17

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/883 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit 992e587:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-06-07-07-58-12 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


validate cloud-provider config at startup & make PVProvider optional

validate cloud-provider configurations at server start-up by having the the CP constructors make an API call to confirm the location/AZ is valid

@ncdc PTAL

Removed commit to make PVProvider optional; will submit in a separate PR.
Changed error messages per comment.

Can you squash the last 2 commits together and then we'll merge?

squashed.


ver:0.1.6-251 chapter seek issue

I have noticed that v251 fails to skip chapters
If I select chapter 2 it doesn't skip to chapter 2 it just buffer and restart from the chapter that I'm currently on

That's a regression on my end, sorry.
I'll push a fix later today.


Addition of non-geographic M2M MSISDN range

Hello,
I am the M2M operations manager for JTGlobal - an MNO based in the UK.
Is it please possible to add the +88236XXXXXXXXXX (15 digits) to the library
The range is provided by the ITU for global services.
In order to have your library properly updated is it not best for you to liaise with the GSMA and the ITU - given that they are those responsible in general? New ranges are released on IR21 documents from all MNOs and should be passed to the library as a matter of course to avoid service disruption of those services replying on your library. Seems disconnected to me.
Thanks
TG

Hi ,
Thanks for reporting the issue and your suggestions.
The phonenumber library is currently aimed at cases where numbers can be dialed to reach a human endpoint.  We will have to look carefully at whether it's ok to add M2M (machine to machine)  numbers without breaking existing users. If we say M2M numbers as valid people assume that it’s going to reach a human.
We have no plans to support M2M numbers at the moment, but might in the future.
Currently we do use  ITU updates and IR21 documents from the users to update the metadata in the library. At this moment we do not have any direct connections with GSMA or ITU.

Hello there
Thanks for your reply.
I understand your stance – however my attention was only drawn to the library as a number of large SMS integrators (e.g Twilio) use your library as a reference point.
That being the case this ability of physically dial a human at the other end doesn’t really stack up.
Many types of MSISDN are not diallable but the numbers are still valid and given the way your library is being used by developers / integrators (rightly or wrongly) the ranges really need to be included.
If you would like me to intro you to some useful contacts at any of the global associations please let me know – otherwise it seems you are just waiting for someone to complain as a number range not working in order to fix it – rather than being proactive and adding them as they are released by the industry.
Thanks
TG
From: padmaksha<EMAIL_ADDRESS>Sent: 22 December 2015 10:41
To: googlei18n/libphonenumber<EMAIL_ADDRESS>Cc: Toby.Gasston<EMAIL_ADDRESS>Subject: Re: [libphonenumber] Addition of non-geographic M2M MSISDN range (#930)
Hi ,
Thanks for reporting the issue and your suggestions.
The phonenumber library is currently aimed at cases where numbers can be dialed to reach a human endpoint. We will have to look carefully at whether it's ok to add M2M (machine to machine) numbers without breaking existing users. If we say M2M numbers as valid people assume that it’s going to reach a human.
We have no plans to support M2M numbers at the moment, but might in the future.
Currently we do use ITU updates and IR21 documents from the users to update the metadata in the library. At this moment we do not have any direct connections with GSMA or ITU.
—
Reply to this email directly or view it on GitHubhttps://github.com/googlei18n/libphonenumber/issues/930#issuecomment-166578267.
This email is confidential and may also be privileged.
If you are not the intended recipient please delete it and notify us immediately by telephoning or e-mailing the sender. You should not copy it or use it for any purpose nor disclose its contents to any other person. Information on the licensed/regulated subsidiaries of JT may be found on our website: www.jtglobal.com

Hi! Thanks for raising this issue.
One of the reasons we haven't supported M2M previously is because no one could explain their use to us sufficiently. You're quite correct: we don't require that a number has a human at the other end since we accept premium rate services and they might go to an automated system instead - but to date we only accept ranges that a human might call or send an SMS to.
You mention SMS integrators above: do you mean that they should accept M2M numbers because they can be used for SMS? Can you explain what kinds of use-cases fail because we don't allow these numbers?
Many people use this library for formatting the numbers of their contacts, for allowing people to sign up for services, for working out how to dial someone in a different country, for working out what kind of cost might be associated with a number in an advert etc. I don't think the lack of M2M support hinders any of those use-cases - but I might be wrong?
Anyway more information on this issue would be welcomed!
Re your other point of proactive vs reactive - we do try and be proactive, but it's not always possible while keeping this a free and open-source service. If you know anyone from industry who is able to share updates with us we would love an intro, thanks!
Lara

See:
https://github.com/googlei18n/libphonenumber/blob/master/FAQ.md#what-about-m2m-machine-to-machine-numbers

Closing for now since there wasn't an update since December. Please reopen if you'd like to investigate support for M2M in libphonenumber. See the points we raise in the FAQ (mostly what Lara mentioned).
Thanks!

hi Andy
I would like to reopen - can anyone tell me what I need to get the range added to the library? What information is required?
the biggest problem I have is that Twilio use your library - and I have many clients that use the Twilio service for sending shoulder taps and configuration messages via SMS to their SIMs / devices. There are countless applications for M2M of course.
I've suggested that Twilio make a manual addition to their own numbering scheme but they're admanat they follow your library - despite it being incomplete.
This essentially leads to me having to reprovision services with +447 numbers (which are in extremely short supply).
Any wisdom appreciated
TG

Hi TG,
Please start by responding to Lara's questions and the additional points made in the FAQ.
As explained, this is not a trivial change and can't be made quickly / lightly as it has the potential to change the semantics of existing API methods and these concerns need to be discussed / addressed.
Thanks,
Andy

Hi TG,
I missed that there's another issue to discuss M2M in general. Let's close this specific request for now (we did that for other country / carrier / range specific M2M requests too) and continue the discussion at #680 .
Please contribute to that other thread.
Thanks!
Andy


Flake8 rule 'E231' reported an invalid point

Flake8 reported an invalid point for the rule E231, with the messge missing whitespace after ','.

Debug information:
Atom version: 1.25.0
Flake8 version: 3.2.1 (pyflakes: 1.3.0, mccabe: 0.5.2, pycodestyle: 2.2.0) CPython 2.7.12 on Darwin

Duplicate of #493


Updating openssl version per cve

Description
Per OpenSSL CVE, we are updating the version here.
Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

Pull the unit-test fix out to its own PR
Change yoru bundle update to be a --conservative update

Please. Thanks!

I trashed this PR.. BOO.. incorporated the work into https://github.com/chef/chef/pull/13911


Create landing page based on design

fix #251
Most of the changes are formatting fixes.

removed Home component because it's the Landing Page now
changed hibridly to hybridly in some places
formatting fixes
changed hardcoded colors to use the Colors file instead

Great job! I really liked the design!


[WIP] [CI] Update to CircleCI 2.0

Note: This is still WIP (I'm gonna squash these commits afterwards as well :D)
To-do list:

[x] Update to CircleCI 2.0 workflows
[x] Add testing simultaneously for both Swift 3.2 & Swift 4.0 (Resolves #1194)
[ ] Test for trivial changes (in progress, thanks to @Sherlouk)
[ ] Build new examples
[ ] Add SPM compatibility test
[ ] Add CocoaPods compatibility test

I'm a bit concerned on the amount of things this PR wants to achieve 😅
@sunshinejr  Do you feel we could create an issue to keep track of all these steps and tackle each one in a sepparate PR? Or are you comfortable making all these changes at once?

Aye, @pedrovereza, I’ll do that after I got it working, just need a playground that i can test, thus why WIP PR.

squashing sounds good to me, but its a little worrying that some of these commits are showing up in the log

also, is there a reason why this isn't being targeted to master, but 10.0-dev instead?

@AndrewSB basically right now it doesn't really matter, I use it as a playground to test everything (especially PRs), but you are right - we would do it in master and 10.0.0-dev both. About he commits - are showing as I didn't rebase to current 10.0.0 yet.

I'm so confused. I don't remember closing this. Was this landed elsewhere?

@AndrewSB I think all open PRs targeting 10.0.0-dev were closed upon deletion of the branch.

Ah, so that's why @AndrewSB closed a few things. I was confused 🙈. I'll reopen and point to master for now?

I'm sorry about that! 10.0.0-dev was behind master, so I thought we were done with it!

No worries! :)

Also, I think it's kind of GitHub's fault for not letting you know that removing the branch would close some PRs :)

😓

Oh, no worries @AndrewSB, I did it once as well 😅 I agree that there should be a warning before deleting the branch that targets multiple PRs. Also I need to start working again on this one, been a long time.

I'm gonna focus on this one as Xcode 9.2 is the last one supported on Circle 1.0. Gonna finish it and split into smaller parts if possible.


Performance issue when large jsons are diff

the react app crashes when i try to compare json file of size: 3.3mb

Also I am unable to scroll the page when the JSON object is big and there are lot of additions.
Do help to suggest any solutions.

@RexSkz can the diff results be displayed in image format so that are less html nodes on the page and there is no lag while scrolling?

The library now supports virtual scroll. It seems to work well with a JSON that is 4MB with 200 million result lines. The diff process takes about 3 seconds, and it won't be slow when scrolling.
Using images to replace DOMs may not be a good idea because the browser will spend more resources to generate/display them.


Fix: do not erase existing values on update_inference_endpoint

Fix https://github.com/huggingface/huggingface_hub/issues/2472 @MoritzLaurer
Previously on update_inference_endpoint, all fields in the payload were populated by default with None values. This lead to a weird side effect which overwrites some existing values with empty ones. In particular, updating any settings of an inference endpoint deletes its environment variables. This PR fixes this by sending only not-none values.

What do you think about adding the custom_image argument to endpoint.update()? In case users want to update the entire image (I suppose that's a separate feature request)


Image upload

Still working on tests and figuring out how to use the pull requests.  Its a bit of a mess.  Any advice on testing file upload functionality?  We generally know the things we need to test like file size and type but are confused about how to do it. For example, we are stuck on how to test the response this image submission without actually submitting an image.  Let us know if you would rather discuss this with us in person than over pull requests.   @sscoth

There is no reference to the photo in the post show page. At a minimum that should be done. As for your test, it doesn't work. We can talk about the test tomorrow. Also, I'd like to even see a thumbnail get generated, but that can be a separate pull request. Look at this library for that: https://github.com/aheckmann/gm

Ok, I added images onto the post show page and added the image upload capabilities onto the form on that page as well. I'll look into the thumbnail thing. And would be happy to meet to discuss testing.


KiCad 6.99 crash - unsupported operand type(s) for /: 'SwigPyObject' and 'float'

Using this plugin with the current nightly crashes the plugin due to changes how the orientation is stored.
wig/python detected a memory leak of type 'EDA_ANGLE *', no destructor found.
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python3.10/threading.py", line 1009, in _bootstrap_inner
    self.run()
  File "/home/thomas/.local/share/kicad/6.99/3rdparty/plugins/com_github_aislerhq_PushForKiCad/push_thread.py", line 114, in run
    'rotation': f.GetOrientation() / 10.0,
TypeError: unsupported operand type(s) for /: 'SwigPyObject' and 'float'

The fix is to use the following code instead in current KiCad versions:
'rotation': f.GetOrientation().AsDegrees(),

Do you have any clue if .AsDegress() is also available in v6 stable release?

No, AsDegree was introduced with the new angle type. I suggest to check if orientation is an integer I think, and otherwise use the new code.

The new angle code is unlikely to go away, so my patch just fetches the angle in the "new" way and falls back to assuming integers-or-whatever if that causes an exception.

Solved by https://github.com/AislerHQ/PushForKiCad/pull/13