MM4M365 overall feedback

Type of issue
Other (describe below)
Feedback
Hi there!
I have been following along for about a year+, and I am loving the approach!!
Digging more into the content left me with a few ideas/comments/feedback. It’s my two cents, but hopefully, some of it could make sense.
Disclaimer: I gave up the idea of writing it all, I was afraid to scare you… I dropped you a link to a recording and let only for foreword. Sorry for the length of it, you should probably go grab yourself a coffee...I tend to be too passionate about it.
1. The value of the MM4M365
A quick word about why I love the Model: it’s spot on in bridging the gap between tools and processes. Usually, a place where everybody struggles to provide an answer.
But having “a set of practices defined by a community of experts” as an external reference is an awesome piece to have as a consulting company like mine. There’s definitely a need for such material and I keep seeing it. Additionally, being an “Auditing” company as well, having access to a documented reference opens a whole new realm, the one of a systematic approach producing a clear output -> a gap analysis with an action plan. It’s tangible, it’s actionable.
2. Feedbacks
Shorter said than writen (hopefully) -> feedbacks
Thanks for your work !!
Page URL
https://learn.microsoft.com/en-us/microsoft-365/community/microsoft365-maturity-model--intro
Content source URL
https://github.com/MicrosoftDocs/microsoft-365-community/blob/main/Community/microsoft365-maturity-model--intro.md
Author
@sympmarc
Document Id
59a88ea9-f6c1-d719-e033-43b3ddd02c30

@KevinStocky - I just realized none of us had responded to you. How rude!
We've been discussing your points, and they are very helpful. It's great to get such detailed feedback. We're thinking about what steps we may take, and if you're game, we may well want to invite you to one or more of our internal meetings to discuss all this.

@sympmarc thanks for your response!
With pleasure to share further with you guys. Tried to keep it short and simple, but I would have few ideas in the back of my mind that I am happy to share.


Let user toggle whether to use native Map/Set or not

Other frameworks tend to pollute global namespace and define their own Map/Set. Although this is not Lovefield's problem, it would be nice to have an option/flag to disable native Map/Set.

What is the motivation behind this? Currently the code will detect on the fly whether native Map/Set are supported and use them if so, or fallback to custom implementation if not. Is there a good reason to fall back to custom implementation even if Map/Set are supported?

We are actually checking for the existence of forEach and values, see https://github.com/google/lovefield/blob/master/lib/capability.js#L62-75. Instead of adding a custom flag, how about making those checks more robust by adding checks for all Map/Set methods used by Lovefield. This would automatically force the code to fall back to the polyfil if the users have polluted versions of Map/Set that don't provide the minimum acceptable interface (like the case mentioned at https://groups.google.com/d/msg/lovefield-users/FSrFkaVo9a8/G6wvqstiAwAJ).

What I'm more concerned is that the function names are the same but behaves
differently.
Also we advertise ES5 but we use ES6 features without a way to override it.
On Mon, Apr 25, 2016, 11:09 AM freshp86<EMAIL_ADDRESS>wrote:

We are actually checking for the existence of forEach and values, see
https://github.com/google/lovefield/blob/master/lib/capability.js#L62-75.
Instead of adding a custom flag, how about making those checks more robust
by adding checks for all Map/Set methods used by Lovefield. This would
automatically force the code to fall back to the polyfil if the users have
polluted versions of Map/Set that don't provide the minimum acceptable
interface (like the case mentioned at
https://groups.google.com/d/msg/lovefield-users/FSrFkaVo9a8/G6wvqstiAwAJ).
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/google/lovefield/issues/149#issuecomment-214465925

Can we close this issue? It does not seem that there is an immediate need for this, and the more time passes, the more browsers have fully implemented Map/Set support. Looking at https://kangax.github.io/compat-table/es6/, it seems that the latest versions of all major browsers fully support Map/Set.


add support for libvirt/kvm provider on Vagrant boxes used in Book samples

Please, add support for libvirt provider for people who do not want to use Virtualbox on Linux hosts.

I've had a few requests for this... I'm looking into it, but want to make sure I can support this usage well and not just give it lip-service.

Just linking to https://github.com/geerlingguy/drupal-vm/issues/649

I've closed that downstream issue; right now I just don't have the resources to build other versions of the base boxes, and I'm also slowly moving towards using some other virtualization options for my testing and scaffolding, so I'm going to close this ticket and for now recommend using other base boxes that d support libvirt (there are usually a couple options when searching https://app.vagrantup.com/boxes/search?provider=libvirt).


Evolving templates

Hey, hygen is looking great, thanks for open-sourcing your work 🙂
Have you yet thought about how to support evolving templates, or is that something you are not considering?
For example, suppose I have a generator processor, I use the template to create a bunch of processors with  hygen processor new --name ex. I then want to update all the rendered processors (for example to migrate all the processors to v2) to use a newer configuration parameter, what would be the hygen way of doing it.
I have though about this a little, and it seems that since hygen is very heavy on "convention over configuration" (which I love and preach by the way, both in internal and open-source projects!), one would make a new V1toV2 migration in the generator, and simply put the new default in new (backing up V1 in newV1 if it is needed). This migrator would basically be adding, replacing and removing the differences based on regexes like skip_if et cetera.

Hi! Thanks for the kind words, I hope Hygen is able to save you some time :)
The answer is yes, I've been through the rabbit hole for this. My answer is twofold:
First, the bigger scope of this problem:
I thought about versioning templates and then providing migration paths. It started with 'stamping' each generated file with metadata about the originating generator, and then trying to compute a migration path.
Half way through I felt I was implementing a version control system. In addition, I had to deal with cases where developer removed the 'stamp' or the changes to files were too fundamental to be migrated. As I went through this, it was just going into a rabbit hole that doesn't end.
So I concluded that this was too hard to Hygen to solve, and best to leave it to version control and tools like jscodeshift that understand the AST and code semantics.
Lastly, the smaller (?) scope of this problem:
What you're suggesting sounds easy enough but it will cover just parts of all of this story, but if you think it's good enough - I'm happy because that's validation for me 😎 . In practice it means to add an ability for a generator to erase lines, which funnily enough I never needed to do - but I can schedule that into the roadmap!.
If you want to do it right now you can probably use a shell action, that runs sed or your preferred streaming text editor on the command line.
Hope this makes sense :)

What you're suggesting sounds easy enough but it will cover just parts of all of this story, but if you think it's good enough - I'm happy because that's validation for me 😎 .

Yeah, the idea was to add a small generic feature that can be used to achieve this goal in a "dirty" way. I like the 80/20 rule, and this should solve 80% of our cases. It isn't pretty, and doesn't solve all the cases, but should work for most of them.
One thought came up: how to indicate multiple lines that need to be replaced at different parts of file? If the block must be continuous, this is pretty much useless as a migration tool

So I concluded that this was too hard for Hygen to solve, and best to leave it to version control and tools like jscodeshift that understand the AST and code semantics.

Yes for more complex cases (such as big framework transitions) microgrammars or AST transformations are more suitable. A higher level abstraction over such a framework could of course be possible, but quite hard and might not be worth the time 🙂

Hi!
By now, there has been contributed two things:

A new pragma for the add operation, which only adds if a file doesn't exist.
A new tool by @ronp001 called hygen-create which can automatically create generators from existing codebases

I believe a combination of those two should provide some kind of path for migrations. WDYT?

@Tapppi  - I'm experimenting with a git-based method for "reapplying" a new version of a generator on files that were created using an older version of that generator.  Is that in the general direction that you're looking for?  I'll gladly share if so.

@ronp001 Yes that is! Is there some regex support or does it not deal with customised patterns?
@jondot Those are great improvements! However, the main feature missing was regexes for replacement I think?
I am currently experimenting with other things, our partner company has a workflow that kind of addresses our problems. But this is still something I am looking for for my open-source projects.

@Tapppi : no regex.  The idea is to use git in the following way:
Step 1:  make sure output of V1 of the generator is in a clean commit in git (I do a git commit or git stash before running the generator, and immediately add and commit the output)
A---B---C---D---E---F  master
    ^
    |
  clean output of generator V1 committed here (at B)

(note that commits C,D,E,F are based on the output of generator V1).
Step 2:  run generator V2 in a branch that is forked from the commit immediately preceding the commit of  generator V1 output (temp branch #1)
A---B---C---D---E---F  (master)
 \
  B'  (temp branch #1)
  ^
  |
 clean output of generator V2 committed here

Step 3: create another temporary branch off of master (temp branch #2)
A---B---C---D---E---F  (master, temp branch #2)
 \
  B'  (temp branch #1)

Step 4: rebase temp branch #2 using the sequence of commits beginning right after the original generator (i.e., commit C) onto the temp branch, and resolve any merge conflicts
A---B---C---D---E---F  (master)
 \
  B'  (temp branch #1)
   \
    C`---D`---E`---F` (temp branch #2 - after resolving merge conflicts)

After that you can merge F` into master, or just copy the generated/modified files to the master branch.
It's not a perfect approach, and I'm still playing with it. Haven't yet "used it in production", but the initial tests look promising.
If you want to try it out, be careful not to mess up your git repository - the setup and the git commands can get a bit confusing, as there are a lot of files and branches involved.  I'll soon share an experimental tool I'm creating to help carry out the process for any adventurous folks out there.

@Tapppi  - just to clarify my previous comment:  the outcome of the process is that all the changes you made to the code created by V1 of the generator are now applied as if you've made them to the code created by V2 of the generator.  If any of the changes can't be applied automatically, you're asked to fix them manually by solving the resulting merge conflict.

@Tapppi @jondot - a preliminary version of the tool is up at https://github.com/ronp001/proj-maker
would love to hear your feedback if you're brave enough to check it out - and, as I noted in the README of the tool: be very careful when doing that.  my testing of the tool was limited to my own configuration, and I don't know how it will behave in other contexts. make sure your data is backed up before working with this.

Thanks @ronp001 for the new hygen-create tool. I'll be closing up this issue 👍

Great work guys, I'll give this a try as soon as I have a need for it, sorry but I'm quite swamped with other work atm ;)


Automated cherry pick of #3240: qcloud elb bugfix

Cherry pick of #3240 on release/2.11.
#3240: qcloud elb bugfix

/lgtm

/approve


Vim syntax highlighting.

Vim users, can someone advise some plugin to highlight cssnext (css4 ?) syntax?
I've google a lot, but didn't find anything.

You just need a modern grammar.


PageAttributes is not exported from root.

recordPageView accepts a PageAttributes parameter, but the PageAttributes type is not exported by aws-rum-web.
In order to either (1) wrap this function or (2) initialize the payload ahead of time, the PageAttributes type needs to be exposed.
Example 1: wrapping the function
function myRecordPageView(payload: PageAttributes | string): void {
  myCustomHandler(payload);
  cwr.recordPageView(payload);
}

Example 2: Initializing the payload ahead of time.
const payload: PageAttributes = {
  pageId: 'test-page-id',
  pageAttributes: {},
};

for (const [key, value] of Object.entries(window.location)) {
  if (typeof value !== 'string') {
    continue;
  }
  payload.pageAttributes[key] = value;
}

cwr.recordPageView(payload);

Both scenarios would be unblocked by allowing:
import type { PageAttributes } from 'aws-rum-web';

Thanks for the report @CharlesStover! Sorry about the wait.


Add scripts for measuring code coverage

None of this is running anywhere yet, but this is a prerequisite for getting codecov set up on this repo.

/hold

/lgtm

/hold cancel


rates: 0.5.0 -> 0.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/lunush/rates/releases.
meta.description for rates is: "CLI tool that brings currency exchange rates right into your terminal"
meta.homepage for rates is: "https://github.com/lunush/rates"
meta.changelog for rates is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/fx1jpgd3dif4gp7z174qz9hjnsjymjc7-rates-0.6.0/bin/rates had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.6.0 with grep in /nix/store/fx1jpgd3dif4gp7z174qz9hjnsjymjc7-rates-0.6.0
found 0.6.0 in filename of file in /nix/store/fx1jpgd3dif4gp7z174qz9hjnsjymjc7-rates-0.6.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
rates

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fx1jpgd3dif4gp7z174qz9hjnsjymjc7-rates-0.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A rates https://github.com/r-ryantm/nixpkgs/archive/d3534f643b6b5372163f78244e184ac14eed2b80.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fx1jpgd3dif4gp7z174qz9hjnsjymjc7-rates-0.6.0
ls -la /nix/store/fx1jpgd3dif4gp7z174qz9hjnsjymjc7-rates-0.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

rates

Maintainer pings
cc @fabaff for testing.

Packaging works but the program itself doesn't seem very robust
$ nix-env --option system x86_64-linux -f /home/teto/.cache/nixpkgs-review/pr-160080/nixpkgs -qaP --xml --out-path --show-trace --meta
1 package updated:
rates (0.5.0 → 0.6.0)

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/teto/.cache/nixpkgs-review/pr-160080/build.nix

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/160080

1 package built:
rates

$ nix-shell /home/teto/.cache/nixpkgs-review/pr-160080/shell.nix
.cache/nixpkgs-review/pr-160080 via ❄  IMPURE (review-shell)
(ins)➜ results/rates/bin/rates
thread 'main' panicked at 'At least one argument to convert from is required', src/main.rs:217:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
.cache/nixpkgs-review/pr-160080 via ❄  IMPURE (review-shell)
(ins)❯ results/rates/bin/rates -h
rates 0.6.0
Get financial data in your terminal

USAGE:
    rates [FLAGS] [ARGS]

FLAGS:
    -f, --force           Forcefully update currency data
    -h, --help            Prints help information
    -F, --noformatting    Do not format the result
    -s, --short           Show only the result
    -t, --trim            Trim the digits after decimal point, if any
    -V, --version         Prints version information

ARGS:
    <arg1>    (Optional) Amount
    <arg2>    Currency to convert from
    <arg3>    (Optional) "to"
    <arg4>    Currency to convert to. Defaults to EUR if not provided
.cache/nixpkgs-review/pr-160080 via ❄  IMPURE (review-shell)
(ins)➜ results/rates/bin/rates 400 dollars
thread 'main' panicked at 'The currency symbol "DOLLARS" is incorrect or not available.', src/main.rs:54:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
.cache/nixpkgs-review/pr-160080 via ❄  IMPURE (review-shell)
(ins)❯ results/rates/bin/rates 400 $
thread 'main' panicked at 'The currency symbol "$" is incorrect or not available.', src/main.rs:54:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
.cache/nixpkgs-review/pr-160080 via ❄  IMPURE (review-shell)
(ins)❯ results/rates/bin/rates 400 $

@GrahamcOfBorg eval


Unit tests

hey @dan-kwiat, was looking at your task list and @ivanmauricio were thinking of making a start on the testing.
How would you feel about using tape vs mocha and chai?
https://medium.com/javascript-scene/why-i-use-tape-instead-of-mocha-so-should-you-6aa105d8eaf4#.kchsyf52a

@dan-kwiat btw the docs for this are on point 👌!

Sure, that would great, thanks!  I've taken that guy's advice before, so I trust tape will be a good choice.

thanks @andrewMacmurray - I think code comments could be improved though..  I'll be on hand tomorrow if you have any questions

@dan-kwiat awesome, we can try it out and see what you think


[184427313] Adding Jamie

What
Added @fearoffish github username so he can access build ci and his public gpg id.
How to review
Verify that the github account and the id are correct and owned by our new member.
Who can review

@fearoffish for the github id and gpg key
Any paas dev for all the above plus to sign off this PR

🚨⚠ Please do not merge this pull request via the GitHub UI ⚠🚨

Doesn't adding his pgp key allow him to get his merges deployed to prod?

Doesn't adding his pgp key allow him to get his merges deployed to prod?

@AP-Hunt has already answered that in similar paas-cf PR


in-toto: properly encode SPDX predicate

I think there are two ways to define what the digest is over:

Canonicalized JSON of the SPDX itself. This would use RFC 8785
The contents of the SPDX DSSE's payload, i.e. the "envelope.payload" value of the SPDX line. This is the whole predicate.

Option 1 is a bit more pure but from the option 2 is easier and I would go with that.

Okay, here's option 2: https://github.com/edgebitio/sbom-server/pull/19


Update to Quill 1.1.5 (with doc updates)

Removes deprecated toolbar config
Adds documentation + example for new toolbar module to README (fixes #120)
Bumps Quill dependency

I think the NPM version could be bumped with this release.

I think everything in this PR is covered by 6147f030dbdcaa8707bf2717d904216b7ee07b6c, except deprecation of Toolbar and the v2.0.0 topic.


[ssr] SSR rendering in NextJS

Description
I'm trying to render a lit component via SSR in NextJS, the default behavior is that it fails to import the component because there is no window property at the server-side rendering.
To fix that, I've imported @lit-labs/ssr/lib/install-global-dom-shim.js before importing my lit component.
Unfortunately, some packages relay their SSR-detection on the availability of window property.
And because of the installed shim,  packages will fail to detect the valid environment and will be executing client-side code on the server.
The shim installed by @lit-labs/ssr does not contain all of the functions of the real, client-sided, window property.
In my case, the package styled-jsx tries to execute the following line of code:
var node = this._isBrowser && document.querySelector('meta[property="csp-nonce"]');.
This results in an exception because the _isBrowser property is true on the server-side.
Hardcoding this property results in compiling without any problems.
Steps to Reproduce

Write this code

element.ts
import<EMAIL_ADDRESS>import {html, css, LitElement} from 'lit';
import {customElement, property} from 'lit/decorators.js';

@customElement('simple-greeting')
export class SimpleGreeting extends LitElement {
  static styles = css`p { color: blue }`;

  @property()
  name = 'Somebody';

  render() {
    return html`<p>Hello, ${this.name}!</p>`;
  }
}

index.js
import "element"

export default function Home(){
  return ( <simple-greeting></simple-greeting> )
}

npm run build

Expected Results
Use of lit element in NextJS using SSR (which is enabled by default), without adding any new server-side specific functionality to the element itself.
Actual Results
Exception is thrown when builiding:
error - TypeError: document.querySelector is not a function

We have exactly the same issue, I've made this codesandbox which replicates the issue (just for reference it's a modified edition of this):
https://codesandbox.io/s/nextjs-lit-forked-cymhs?file=/components/Button.client.tsx

Apparently we can also add the shim by injecting it to the pages/_document.js like below, but that requires changing the webpack config to copy the shim to the bundle as well, which I haven't managed to do yet.
import Document, { Html, Head, Main, NextScript } from 'next/document';
import raw from 'raw.macro';
export default class CustomDocument extends Document {
  render() {
    return (
      <Html>
        <Head>
          <script
            type="text/javascript"
            dangerouslySetInnerHTML={{
              __html: raw(
<EMAIL_ADDRESS>              ),
            }}
          />
        </Head>
        <body>
          <Main />
          <NextScript />
        </body>
      </Html>
    );
  }
}

I managed to make an implementation with Next.js and @lit-lab/ssr, you can take a look at my sample repo here, let me know what you think about that: https://github.com/mohsenasfia/nextjs-lit-ssr

BTW, I just noticed that a similar issue has been created on Next.js as well, was wondering maybe it's actually purely a Next.js issue?

@mohsenasfiamaersk Thanks for the creating the sample repo.
Any idea how to bind event to button component?.

Hey @manandkumaar, for ease of event binding, my suggestion would be to use @lit-labs/react, it's a wrapper for the usage of the web components in React. You can also consider using the @lit-labs/gen-wrapper-react which would auto-generate the React wrapper out of your packages without too much of boilerplate code, seems promising but I haven't tried that myself yet.

+1 for this, we are also working on a design system using lit and want to use in with SSR.

Any updates on this? We're trying to use a lib component package within our nextjs setup and I'm getting the same issues

To clarify, the original post of the issue is more akin to issues like https://github.com/lit/lit/issues/1213 where bringing in the global DOM shim caused breakages. For purely importing Lit components in a Next.js project (without actually server-rendering them) is now possible (without using dynamic imports) without loading the global DOM shim as of<EMAIL_ADDRESS>with https://github.com/lit/lit/pull/3156. This allows usage of Lit components in a Next.js project where component definitions are included in the bundle to be client rendered.
Due to the issue title, I believe some of you are looking for actually server-rendering Lit components in a Next.js project as well.
We have a working proof of concept for achieving this by patching React.createElement to look for Lit components and use @lit-labs/ssr to server render them. See https://github.com/lit/lit/commit/adbfceb02f7deb9cf69d8f44ff88002d851e7788#diff-c9ffebf7c892cdb0442bf316bbd8a4d4be892cca3cd6d0b1d4d9bdc8a39f4fd6.
Polishing this approach, along with designing and publishing a plugin for adding this patch to createElement is up next in the queue.

For those that might be subscribed to this issue, we have released @lit-labs/nextjs as a plugin for SSR-ing Lit components in a Next.js project.
Here's a stackblitz example: https://stackblitz.com/edit/nextjs-lit-ssr?file=next.config.js,pages%2Findex.js
Please give it a try and let us know your thoughts with issues, discussions, or at our discord server. Thank you!

For those that might be subscribed to this issue, we have released @lit-labs/nextjs as a plugin for SSR-ing Lit components in a Next.js project.
Here's a stackblitz example: https://stackblitz.com/edit/nextjs-lit-ssr?file=next.config.js,pages%2Findex.js
Please give it a try and let us know your thoughts with issues, discussions, or at our discord server. Thank you!

@augustjk, please, how does this work with the @lit-labs/react wrapper?

@watife We added some more prop coordination with the @lit-labs/react package in this PR https://github.com/lit/lit/pull/3885. There's also a design doc explaining some of the goals and implementation decisions here https://github.com/lit/lit/blob/main/dev-docs/design/ssr-react.md

@

@watife We added some more prop coordination with the @lit-labs/react package in this PR #3885. There's also a design doc explaining some of the goals and implementation decisions here https://github.com/lit/lit/blob/main/dev-docs/design/ssr-react.md

@augustjk, thank you very much. However, I need some clarification about the implementation of this, please. With this, if I render a component with @lit-labs/react in, for example, next.js, does it work out of the box supporting ssr or any particular configuration I need to do?
Thank you once again

@watife See https://github.com/lit/lit/tree/main/packages/labs/nextjs#readme. There's an example project here https://github.com/lit/lit/tree/main/examples/nextjs. Please open a separate discussion if you're having trouble.

@watife See https://github.com/lit/lit/tree/main/packages/labs/nextjs#readme. There's an example project here https://github.com/lit/lit/tree/main/examples/nextjs. Please open a separate discussion if you're having trouble.

In the nextjs example, I cannot import a library created with lit-labs/react like shoelace. To import it, based on above example, we will need the entire source of the lit component/library. That does not seem like a good idea.

In the nextjs example, I cannot import a library created with lit-labs/react like shoelace. To import it, based on above example, we will need the entire source of the lit component/library. That does not seem like a good idea.

@harshunifi If you're talking about duplication of Lit code, that's a shoelace specific issue as they have been bundling Lit into their component code rather than leaving them as bare specifiers to be deduplicated for users, though it looks like that'll be addressed soon https://github.com/shoelace-style/shoelace/issues/559


[Docs] Title bar just vanishes on FF mobile?

Like why?
It just vanishes after clicking a header anchor (the § thing)
Firefox mobile v88.1.3 on Android 10

Can't debug this so I have no idea how to fix this :/


Update UI header with features added to dear imgui

Currently https://github.com/emoon/ProDBG/blob/master/api/include/pd_ui.h is lagging behind a bit the new features that has been added to dear imgui (which ProDBG has been updated to use)
It would be good to do a pass and update to match/changed features of the API.

Covered by #196


Keyframe animation does not apply correct initial value

I'm seeing some unexpected behavior with initial animation values when using keyframes on v2.2.0. Here is an example: https://codepen.io/alexchantastic/pen/mKJGPK
The following will produce opacity:0 as an initial value:
anime({
  targets: '#box',
  opacity: [0, 1],
  autoplay: false
});

However, when doing the same with keyframes, the initial value will be opacity:1:
anime({
  targets: '#box',
  opacity: [
    {value: 0},
    {value: 1}
  ],
  autoplay: false
});

In order for the keyframe example to work, I needed to set the duration of the first keyframe to 0:
anime({
  targets: '#box',
  opacity: [
    {value: 0, duration: 0},
    {value: 1}
  ],
  autoplay: false
});

Might be related to #212 and #177.

Got it thanks for the clarification @juliangarnier!


Should the initial version of Zebra be able to create blocks?

This question started as one about mining code, and morphed into the one in the title.
For context, because we have a small team and high demands on software quality, we'd like to have the minimum code necessary to support any given feature.  Supporting CPU mining is clearly not a priority -- the mainnet hashrate is high enough that CPU mining will never be viable, so any actual mining will be done by ASICs or FPGAs, or possibly GPU miners.
In any case, the mining implementations will be external to Zebra.  Although supporting external miners is a priority (as long as we continue to rely on proof-of-work mining), miners already use zcashd or something else, so providing an interface for them seems fine to defer past the initial Zebra release.
Deciding that CPU mining isn't a priority doesn't actually help us save code size, because a CPU mining implementation is necessary for testnet implementations to test block creation for private testnets or in CI.  (The public testnet is also full of GPU miners).
However, this raises the following question: what is the benefit of having test code that tests functions which will never be executed on mainnet anyways? Instead of maintaining a CPU miner to test block creation functions which will never be used, we could alternately delay block creation functionality to a future version of Zebra.  In this case, the initial release of Zebra would provide a full-node implementation that can sync the chain, verify transactions, create transactions, and broadcast them to the network, and we would temporarily make explicit what was previously the de facto implicit reality (that block creation is performed by miners, not by fullnode operators).  In a future release, we can provide a hook for external miners and implement block creation.
This poses a slight complication in that our CI and testing infrastructure will, at the beginning, require a zcashd participant.  But since we want to test against zcashd anyways, and we have potentially large code savings (upwards of 5% of the total codebase from mining code alone, plus savings from not supporting the block creation logic or message handling), this seems worthwhile.

I think this is fine. No one mines directly with zcashd either anymore (the mining-related text in the metrics UI should probably be disabled on mainnet). zcashd is used to either generate block templates for mining pool software (the getblocktemplate RPC method), or simply as a source of mempool transactions that the mining pool software assembles into blocks by itself.
Something somewhere has to assemble the full candidate block (minus PoW). zcashd provides an API for that, but it's not unreasonable for Zebra to not provide any API, or to have some alternate smaller API on top of which someone could build a block-filling binary.

what is the benefit of having test code that tests functions which will never be executed on mainnet anyways?

zcashd isn't testing the exact same code as is executed on mainnet - difficulty adjustment is ignored in regtest mode, and the maximum target (lowest difficulty) is used. This is primarily so that integration tests complete in faster-than-real-time. In the context of this issue, what matters is testing the block-filling code, and I don't see a benefit to including and testing that code before you actually plan to expose and support it.

This poses a slight complication in that our CI and testing infrastructure will, at the beginning, require a zcashd participant.

I'm imagining that in future instead of relying on a zcashd node for block production, the test harness could instantiate one or more "block miner" entities, each obtaining candidate transactions from specific Zebra nodes in the test setup. This could also make it easier to test network behaviour under (distributions of) various transaction selection policies.

Okay, what do we think of the following plan:
For Zebra 2, remove mining code and the ability to generate new blocks.
For Zebra 3, add the following functionality:

block templating functionality that can prepare block templates for external block producers;
the ability to accept externally-produced blocks and broadcast them to the network;
a testing-oriented implementation of an external block producer for use in testnets.

This sounds good to me. We'll want those features in place to be able to fully participate in NU3, but we don't need to support them until then.

Okay, if there are no objections (@dconnolly ?) I'll close this issue as having been resolved in favor of the plan above.


Added support for .resx and .resw preview support.

Summary of the Pull Request
This pull request adds preview support for .resx and .resw files. Since these files are XML-style files, simply adding the file extensions under the XML extensions enables support.

PR Checklist

[X] Closes: #36295
[X] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: All existing tests pass. I will need some direction if custom unit tests are needed. Manual testing of .resx and .resw files works.
[X] Localization: All end user facing strings can be localized
[ ] Dev docs: Dev Docs not updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments
Pull request adds support for .resx and .resw files which are files that are in XML format.

Validation Steps Performed
I tested previews with various .resw and .resx files manually. I am willing to add automated testing but will need some pointers on how to do that.

@microsoft-github-policy-service agree

Just create initial pull request adding support .resx and .resw to Monaco


Allow version specifiers to be used in Python version requests

In service of https://github.com/astral-sh/uv/issues/4212 but this is user-facing e.g. Python discovery will support version specifiers everywhere now.
Closes https://github.com/astral-sh/uv/issues/4212

A little terrifying...
❯ cargo run -q -- pip install --python '>=3.8' anyio -v
DEBUG Searching for Python >=3.8 in all sources
DEBUG Found CPython 3.12.3 at `/Users/zb/workspace/uv/.venv/bin/python3` (virtual environment)
DEBUG Using Python 3.12.3 environment at .venv/bin/python3
DEBUG Acquired lock for `.venv`
DEBUG Requirement satisfied: anyio
DEBUG Requirement satisfied: idna>=2.8
DEBUG Requirement satisfied: sniffio>=1.1
Audited 1 package in 15ms

Waiting for the fixes at

#4218
#4222


[Proposal] Allow for Icons to be a props component

Currently I use Fontaweome for icons and with this package I am forced to use material icon, is there a way to offer flexibility to send in a component props for icons?

Hi,
Yes good idea. I'm closing the issue as you made the PR.
Cheers,
Jeremy

It's published in version 1.41.0


Generate properly mangled test names

Currently bindgen generates a lot of tests like so:
    #[test]
    fn __bindgen_test_layout_nsTArray_instantiation_34() {
        assert_eq!(::std::mem::size_of::<root::nsTArray<root::nsCString>>() ,
                   8usize , concat ! (
                   "Size of template specialization: " , stringify ! (
                   root::nsTArray<root::nsCString> ) ));
        assert_eq!(::std::mem::align_of::<root::nsTArray<root::nsCString>>() ,
                   8usize , concat ! (
                   "Alignment of template specialization: " , stringify ! (
                   root::nsTArray<root::nsCString> ) ));
    }

The number is there because there is such a test for each T that is used as nsTArray<T>. Furthermore, the counting is global -- adding another instantiation will renumber all such tests, not just the array ones. This means that nontrivial binding updates are very prone to bitrot.
Instead of numbering this we should do something like fn __bindgen_test_layout_nsTArray_lt_nsCString_gt_instantiation. Basically, some mangling scheme that can reliably produce unique names.
cc @emilio

Was this fixed in https://github.com/servo/rust-bindgen/pull/829 ? @Manishearth @emilio

Lol yeah looks like I filed this is twice


[Nuvid] Fix extractor (closes #15355)

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
mp4 link is not found in html anymore, but must be fetched using hash-generated values upon page request to a json api. Closes #15355

@vidaritos - This solution works beautifully, thank you!  Hopefully the collaborators will integrate this with the release version.
Cheers,
Parmjit V.
$ ./youtube_dl/main.py -vF https://www.nuvid.com/video/3709538/busty-asian-monster-big-tits
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-vF', u'https://www.nuvid.com/video/3709538/busty-asian-monster-big-tits']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.10.05
[debug] Git HEAD: f7e34e7
[debug] Python version 2.7.9 (CPython) - Linux-3.16.0-4-686-pae-i686-with-debian-8.7
[debug] exe versions: ffmpeg 3.2.4-1, ffprobe 3.2.4-1
[debug] Proxy map: {}
[Nuvid] 3709538: Downloading video page
[Nuvid] 3709538: Downloading JSON metadata
[info] Available formats for 3709538:
format code  extension  resolution note
0            mp4        unknown

@dstftw Hi, this PR has been open for 2 years, is there any issues that prevents it from being merged?


fix requirements.txt

fix requirements.txt

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


<EMAIL_ADDRESS>has exposure to CVE-2022-25881 via dependency library<EMAIL_ADDRESS>

Command
serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
CVE-2022-25881 (https://nvd.nist.gov/vuln/detail/CVE-2022-25881) was reported a month back and it seems<EMAIL_ADDRESS>is  affected by this vulnerability via dependency libraries (pacote in this case).
Is there any plans to roll out a patch since upgrading to latest version of angular might not be an option.
Minimal Reproduction
Dependency tree:
<EMAIL_ADDRESS>--><EMAIL_ADDRESS><EMAIL_ADDRESS>—><EMAIL_ADDRESS>—><EMAIL_ADDRESS><EMAIL_ADDRESS>Exception or Error
No response
Your Environment
Angular CLI: 13.3.10
Node: 18.12.1 (Unsupported)
Package Manager: yarn 1.22.17
OS: darwin arm64

Angular: undefined
...

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1303.10 (cli-only)
@angular-devkit/core         13.3.10 (cli-only)
@angular-devkit/schematics   13.3.10 (cli-only)
@schematics/angular          13.3.10 (cli-only)

Anything else relevant?
Issue present in v13

Just delete the lock file and reinstall.

Hi, thanks for this report.
There is anything actionable from our end here. Please update your lock file.


Show whether a PR is a draft

Often draft PRs do not require properly reviewing yet, so it would be nice be able to tell if a PR is a draft vs ready to review.

Thanks @jakewtaylor !

Thank @Jono20201!

Oh! 😂  Thanks @Jono20201!


Provide a function to run Neomake on a specific file or tab/buf/win

Currently bufnr("%") is used in file mode always (https://github.com/neomake/neomake/blob/3a76e9cb873659136e8838d5c52f56e909e93707/autoload/neomake.vim#L266), but it should be possible to pass this in through options, possibly by means of tab/buf/win and/or a file name (where there would be no win then.
In the case of using a filename the quickfix list should be used then, and sign handling would be skipped.

I think maybe we should use <afile>, this will works better for :wa,and current buffer has no changes.


Update README.md

Update SONOFF Zigbee 3.0 USB Dongle Plus hardware information

@guozi7788 Do you also happen have any more information on DIO for 2.4GHz switching as used in "RF Switch Control Pins"?
Does maybe DIO_5, DIO_6 or DIO_28 switch to 2.4GHz if it is DIO_29 thaT swiches to 2.4GHz 20dBm?
I added the info on "DIO_29: 20dBm PA" pin for PA in https://github.com/Koenkk/Z-Stack-firmware/pull/325
But that information came from @chiakikato who checked RF traces for PA and as I understand he could not find a DIO connected for RF switch to or 2.4GHz 5dBm and 2.4GHz 20dBm switching?
Please see whole discusson in the other thread and maybe give feedback there to clear up questions:
https://github.com/Koenkk/zigbee2mqtt/discussions/8840
Again, my PR was just based on posts with observation comments by @chiakikato
Originally posted by @chiakikato in https://github.com/Koenkk/zigbee2mqtt/discussions/8840#discussioncomment-1550021

I check the trace of SONOFF.
DIO_29: 20dBm PA is connected. but DIO_28: is N.C.
it uses PE4259 or compatible's SC-70 6P RF switch which does not have 3 RF signals input for 2.4GHz 5dBm, 2.4GHz 20dBm and SubGHz.
I think it is a reason DIO_28 is not connected.

Originally posted by @chiakikato in https://github.com/Koenkk/zigbee2mqtt/discussions/8840#discussioncomment-1550148

I set RF switch control as HIGH by external hardwired method and got -22~-19dBm worth result.
It means the firmware's RF switch control has no problem.
SONOFF RF antenna and/or RF circuit need to be doubted.

PS: Please compare "RF Switch Control Pins"colum for the different CC2652P and CC1352P based adapters, and note that that there are also questions in regards to "BSL Trigger Pin" and "Auto-BSL" as well so if possible please also fill in the info there too:
https://github.com/Koenkk/Z-Stack-firmware/blob/master/coordinator/Z-Stack_3.x.0/bin/README.md

Adapter
TI Chip/Module Used
Firmware to Flash
BSL Trigger Pin (1)
Auto-BSL (2)
RF Switch Control Pins (3)
LED(s)
Hardware Flow Control

TI LAUNCHXL-CC1352P-2
CC1352P
CC1352P2_CC2652P_launchpad_*.zip
DIO_15
No
DIO_28: 2.4GhzDIO_29: 20dBm PADIO_30: Sub-1GHz
DIO_6 (Red)DIO_7 (Green)
?

Electrolama zzhp-lite
CC2652P(Ebyte E72)
CC1352P2_CC2652P_other_*.zip
DIO_15
Yes
DIO_5: 20dBm PA ??DIO_6: 2.4GHz ??
DIO_7 (Pink)
?

Electrolama zzhp
CC2652P
CC1352P2_CC2652P_other_*.zip
DIO_15
Yes
DIO_5: 20dBm PA ??DIO_6: 2.4GHz ??
DIO_7 (Pink)
?

Electrolama zoe2
CC1352P(Ebyte E79)
CC1352P2_CC2652P_other_*.zip
DIO_15
No
DIO_5: 20dBm PA ??DIO_6: 2.4GHz ??
DIO_7 (Pink)
?

ZigStar Stick v4
CC2652P(RFSTAR RF-BM-2652P2)
CC1352P2_CC2652P_launchpad_*.zip
DIO_15
Only for CH340C ver.
DIO_28: 2.4GhzDIO_29: 20dBm PA
DIO_6 (Green)DIO_7 (Red)
?

CircuitSetup.us Zigbee Stick
CC2652P(RFSTAR RF-BM-2652P2 PCB Ant.)
CC1352P2_CC2652P_launchpad_*.zip
DIO_15
No
DIO_28: 2.4GhzDIO_29: 20dBm PA
DIO_6 (Green)DIO_7 (Red)
?

Tube's CC2652P2 USB Coordinator
CC2652P(RFSTAR RF-BM-2652P2)
CC1352P2_CC2652P_launchpad_*.zip
DIO_15
N/A
DIO_28: 2.4GhzDIO_29: 20dBm PA
N/A
?

Tube's Zigbee Gateways (CC2652P2 variant)
CC2652P(RFSTAR RF-BM-2652P2)
CC1352P2_CC2652P_launchpad_*.zip
DIO_15
N/A
DIO_28: 2.4GhzDIO_29: 20dBm PA
N/A
?

Tube's Zigbee PoE (Power Over Ethernet) Serial Coordinator (CC2652P2 variant)
CC2652P(RFSTAR RF-BM-2652P2)
CC1352P2_CC2652P_launchpad_*.zip
DIO_15
N/A
DIO_28: 2.4GhzDIO_29: 20dBm PA
N/A
?

Egony Stick V4(Ebyte ver.)
CC2652P(Ebyte E72-2G4M20S1E)
CC1352P2_CC2652P_other_*.zip
DIO_15
Yes(from Rev.2.0)
DIO_5: 20dBm PADIO_6: 2.4GHz
DIO_8 (Green)DIO_7 (Red)
?

Egony Stick V4(RFSTAR ver.)
CC2652P(RFSTAR RF-BM-2652P2)
CC1352P2_CC2652P_launchpad_*.zip
DIO_15
Yes
DIO_28: 2.4GhzDIO_29: 20dBm PA
DIO_7 (Green)DIO_6 (Red)
?

cod.m Zigbee CC2652P RPi Module
CC2652P(RFSTAR RF-BM-2652P2)
CC1352P2_CC2652P_launchpad_*.zip
DIO_15
Yes
DIO_28: 2.4GhzDIO_29: 20dBm PA
DIO_7 (Green)DIO_6 (Red)
?

Gio-dot Z-Bee Duo with CC2652P
CC2652P(Ebyte E72-2G4M20S1E)
CC1352P2_CC2652P_other_*.zip
DIO_15
Yes(from Rev.2.0)
DIO_5: 20dBm PADIO_6: 2.4GHz
DIO_8 (Green)DIO_7 (Red)
?

cyijun OpenZ3Gateway
CC2652P(RFSTAR RF-BM-2652P2 SMA Ant.)
CC1352P2_CC2652P_launchpad_*.zip
DIO_15
No
DIO_28: 2.4GhzDIO_29: 20dBm PA
DIO_7 (Green)DIO_6 (Red)
?

SONOFF Zigbee 3.0 USB Dongle Plus by ITead
CC2652P
CC1352P2_CC2652P_launchpad_*.zip
?
?
DIO_29: 20dBm PA
?
DIO13: TXDIO12:RCDIO19: CTSDIO18: RTS

@Hedda As you said, PE4259 is used on the dongle, The Pin6 is connected to Vdd, and Pin4 is connected to DIO29. Therefore, it only uses DIO29 to control the switching between 5dBm (PE4259’s RF2) and 20dBm (PE4259’s RF1).
The RF has been tested by the instrument and the result is normal.
I am not sure if the abnormality you mentioned is caused by individual differences. I will report your question to the relevant personnel.
I have added the information you expect to know in this PR:
BSL Trigger Pin: DIO15
Auto-BSL: yes
LED: DIO_7(Not welded) Power LED(Red)
Hardware Flow Control: DIO13: TX DIO12: RC DIO19: CTS(Need DIP-switch ON) DIO18: RTS(Need DIP-switch ON)
You can update the relevant Thread. If you expect me to update, please let me know.
Thanks.

@guozi7788 Are you employed by ITead/Sonoff as an engineer and have specifically worked on this specific product for them?

I have added the information you expect to know in this PR:
BSL Trigger Pin: DIO15
Auto-BSL: yes
LED: DIO_7(Not welded) Power LED(Red)
Hardware Flow Control: DIO13: TX DIO12: RC DIO19: CTS(Need DIP-switch ON) DIO18: RTS(Need DIP-switch ON)

FYI, It does not look like "Auto-BSL = Yes" made it into this pull request by yourself, however, is in this other PR -> https://github.com/Koenkk/Z-Stack-firmware/pull/328

Bump and not stale, just waiting for review.


Swap env vars for XPU and IPEX + CLI

Keeps in line with the rest of Accelerate's env vars and CLI args to make it clear where it comes from and how to disable it:

IPEX_ENABLED -> ACCLERATE_USE_IPEX
XPU_ENABLED -> ACCELERATE_USE_XPU

Also cleans up CLI so we can properly do:
accelerate launch --ipex -h

CLI changes:

--ipex_enabled -> --ipex
--xpu_enabled -> --use_xpu

(And since ipex and xpu are enabled, unless I'm mistaken we should always do --ipex when doing --use_xpu
cc @sywangyi @abhilash1910
I did not find any docs to update outside of this change, however the new CLI changes were added to the CLI documentation

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@abhilash1910 please let me know if this change has broken anything (aside from the change in raw CLI params) as I have no way to test it :)

Thanks @muellerzr for the change, looks ok to me ; let me run some quick tests and get back.


TYPO: Change 'Data' to 'Date' on Organization Profile page. and Idigenous entity to Indigenous entity

Looks good!


Bounce averaged kinetic equation

Time for another big merge, I think!
The main feature of this branch is the implementation of the bounce-averaged kinetic equation, using the new PXiInternalTrapping boundary condition as well as the AnalyticB radial grid.
It also features a large number of smaller related or unrelated tweaks and features.
Before merging, it remains to fix the 2kinetic test which now crashes. I do not yet understand why, but changing the if-continue statement on lines 151-152 in PXiExternalLoss to the one on 157-158 makes it succeed (but destabilizes the solution so that the physics test fails instead).

I made the flux surface averager test a bit more rigorous, and discovered numerous bugs in the bounce averages. Will take some tinkering to fix, I'll look into it over the coming week.

I would like to make the merge now. I suggest we change the 2kinetic test to only utilize a cylindrical grid for now so that tests check out, open a separate issue for the KineticKinetic boundary condition with trapping effects, and pull to master. There are so many improvements on this branch now that should be of interest to all users, for example some of Ida's simulations are ~3 times faster on this branch.


Support to set qps and burst via env variable

Currently some configuration such as kube-api-burst and kube-api-qps must be set via command line option.
Knative deployments usually do not have the command line option, the command line option is unusual and so knative/operator also does not support the API.
Hence This patch allows to set client config via env variable.
Release Note
env variable `KUBE_API_QPS` and `KUBE_API_BURST` are available. They are same options for `--kube-api-burst` and `--kube-api-qps`

/cc @dprotaso @skonto

LGTM thanks @nak3!

/hold
We actually want to drop these settings from our controllers since K8s supports API priority and fairness - https://kubernetes.io/docs/concepts/cluster-administration/flow-control/
Some context:
https://kubernetes.slack.com/archives/C0EG7JC6T/p1680796032246709?thread_ts=1680791299.631439&cid=C0EG7JC6T

Ah, thank you. Then, let's defer to https://github.com/knative/pkg/issues/2756

TestMetricsExport flake
/retest

/lgtm
/approve

/hold cancel


(PDF) Copyright section "run-in" of the publisher name and year

@ronaldtse this issue occurs due the line
 <xsl:strip-space elements="*"/>

in https://github.com/metanorma/isodoc/blob/main/lib/isodoc/presentation_function/bibdata.rb. The XSLT removes the spaces between the elements.
The presentation XML after preprocess XSLT doesn't contain space between span:
<boilerplate>
    <copyright-statement>
      <clause id="_copyright_protected_document" inline-header="false" obligation="normative">
        <title depth="1">COPYRIGHT PROTECTED DOCUMENT</title>

© ISO2016

I've added   in the source boilerplate in https://github.com/metanorma/metanorma-iso/pull/1060.
@opoudjis is this properly solution?

I actually had solved it as

© ISO 2016

to prevent any swallowing up of spaces between tags. I'll pop that in now.


fix(api): Adapt to sdk v0.4.1

Make the provider compatibile with our new API by
updating the SDK to version v0.4.1
Switch the example from a users image to an official target (caddy).

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


sdl2-config invocation without full path

Hi,
this pull request is about using sdl2-config instead of /usr/local/bin/sdl2-config.
Great project by the way 👍
Regards
Jan

Yes, this is needed. The path specification arose at a time when I was working on a system with multiple SDL2 installations. (The system installation pulled in dozens of dependencies, while my local build minimized them, making for easier distribution.)


Facilitating for Cuda builds

Facilitating for Cuda builds
removing centos-logos causes installing dependencies issues with s2i-base-centos7 base.
Related-to: https://github.com/thoth-station/tensorflow-build-s2i/issues/40
Signed-off-by: Harshad Reddy Nalla<EMAIL_ADDRESS>

Thanks for Opening the Pull Request.
I can assist you with following commands:
/retest : To Rerun the test checks.
/deploy : To deploy the commit in test environment.

lgtm

/approve

Successfully Merged.
Thanks for the contribution.


Update cloud-outgoing-webhooks.rst

Fixed indent for note ("Similarly")

I rarely do this but I also submitted a fix for a broken link I found at https://docs.mattermost.com/cloud/cloud-integrations/cloud-slash-commands.html#custom-slash-command


MapParallelOrdered is not running all Tasks in parallel

This was originally mentioned to me by @cwmyers who I work with.  I've since looked into it a little more and thought about how it could be fixed.
Problem / Issue description
With the following simple Observable using mapParallelUnordered, the process takes just over a second to complete as the Tasks are executed in parallel.
package monix

import monix.eval.Task
import monix.execution.Scheduler
import monix.reactive.Observable

import scala.concurrent.Await
import scala.concurrent.duration.Duration

object Example2 {
  implicit val scheduler = Scheduler.fixedPool("MyTest", 20)

  def createStream = {
    val last =
    Observable.range(1, 5)
        .mapParallelUnordered(20)(waitForABit)
        .dump("Int = ")
        .runAsyncGetLast
    val maybeInt = Await.result(last, Duration.Inf)
    maybeInt
  }

  def waitForABit(i: Long): Task[Long] = {
    Task {
      Thread.sleep(1000)
      println(Thread.currentThread().getName + s" - $i")
      i
    }
  }

  def main(args: Array[String]): Unit = {
    createStream
  }
}

Note the ordering is not guaranteed (as expected).
MyTest-14 - 4
MyTest-11 - 1
MyTest-12 - 2
MyTest-13 - 3
0: Int =  --> 3
1: Int =  --> 4
2: Int =  --> 2
3: Int =  --> 1
4: Int =  completed

Now if the above program is changed from mapParallelUnordered to mapParallelOrdered the behaviour changes significantly (beyond just the ordered output):

Everything occurs on the main thread.

main - 1
0: Int =  --> 1
main - 2
1: Int =  --> 2
main - 3
2: Int =  --> 3
main - 4
3: Int =  --> 4
4: Int =  completed

Execution is sequential
This program takes just over 4 seconds to complete.

While the use of Thread.sleep isn't ideal and replacing with a Task.delayExecution would fix the behaviour in this example, I don't think the current implementation of mapParallelOrdered is ideal.
I think users of the Monix library aren't expecting a radically different result when switching between mapParallelOrdered and mapParallelUnordered
Also, if the async Task was CPU bound, the implementation would also fail to achieve parallelism.
As such I'm proposing the current implementation is changed.
Potential issue
Currently the elements are processed when the parallelism semaphore permit is acquired.
https://github.com/monix/monix/blob/adef8b31dd612e9504aab6559dc8cacb985a7491/monix-reactive/shared/src/main/scala/monix/reactive/internal/operators/MapParallelOrderedObservable.scala#L170-L181
This is done on the same thread if the semaphore is acquired synchronously.
Compare this to where process is called for the Unordered implementation.
https://github.com/monix/monix/blob/adef8b31dd612e9504aab6559dc8cacb985a7491/monix-reactive/shared/src/main/scala/monix/reactive/internal/operators/MapParallelOrderedObservable.scala#L170-L181
Here it's done in ack.onComplete for which the callback occurs on a different thread.
Proposed fix
process should be called in ack.onComplete just like it is in the Unordered implementation so that the tasks are invoked on the Scheduler / ExecutionContext rather than the current thread.
Note that process currently is also responsible for managing a queue of the tasks so that they can be notified in order.  If process is called in ack.onComplete, the order can no longer be guaranteed at that point, so the items must be added to the queue earlier.  I suggest changing the queue to wrap the futures in AtomicAny so that the ordering can be set when it is guaranteed (and the AtomicAny references to be set when the Task is started).
I've started experimenting with this approach, but wanted to give people a chance to comment on the issue before I submit a PR.  I'm also keen to hear thoughts on how to test the change.

Thanks a lot for the extensive report @lukestephenson . I will look into that and think about possible solutions. PR is of course very welcome, we can go from there.
The first possible solution that comes to my mind and might work is to force async boundary on executed tasks
Not sure how to test it yet

@Avasil Thanks for the suggestion to force an async boundary. I've given that a try as well as what I initially described.  Both approaches are currently failing on the same cancellation tests, which I still need to investigate.  I'll submit the PRs for comment now (with the broken tests).

@Avasil The approach you suggested appears to be working (but failing on an unrelated test).

@lukestephenson I've restarted CI and it's ok for both tests now. :)
I feel like the async boundary should be better if there aren't more corner cases. Wrapping everything in Atomic is probably expensive but I'm not sure without benchmark

Hi @Avasil .  I'm happy with the Async boundary approach.
The only corner case I wasn't sure about is if there can be multiple calls to onNext waiting for an async semaphore permit at the same time.  But the change doesn't make that any worse if it is a problem.

The only corner case I wasn't sure about is if there can be multiple calls to onNext waiting for an async semaphore permit at the same time. But the change doesn't make that any worse if it is a problem.

IIRC there is an internal Queue in Semaphore implementation so the order should be preserved

What I was concerned about is https://github.com/monix/monix/blob/0097879cac2b5355bcc4b9c33046bf92ec111c42/monix-reactive/shared/src/main/scala/monix/reactive/internal/operators/MapParallelOrderedObservable.scala#L170-L181:
val ack: Future[Ack] = permit.value match {
  case None =>
    permit.flatMap { _ =>
      composite -= permit
      process(elem)
      Continue
    }
  case Some(_) =>
    composite -= permit
    process(elem)
    Continue
}

When the permit is obtained synchronously (ie case Some(_)), then ordering is guaranteed.
When it is obtained asynchronously (ie case None), then the logic is performed in a future.flatMap callback which will be run potentially on a separate Thread under the control of the ExecutionContext.  If there are multiple permits released asynchronously at once, then I don't think there is a guarantee on the ordering that those callbacks will occur.  But I'm not sure if it's even possible to get into a state where multiple permits are released asynchronously at once.  Either way, the change I've implemented wouldn't make that worse.
Hope that makes sense.

Ah, I see what you mean. I'll check if I can reproduce it and fix if it turns out to be a problem. Thanks!
And regarding this issue, I guess now we just have to figure out a way to test the current fix

This was fixed by #846


improve footer of the devpost

improve the footer by removing the underline and add hover effects to it
please assign me @pa
please label under the gssoc and add the level

can you assign this to me

@SurajSanap please assign this to me i am GSSOC'24 contributor and have 2+ years of experience in development


Switch to static RegEx method calls

This PR switches the RegEx instances to use the static variants instead.
Each time a new RegEx() is created, it has to "compile" the pattern to an intermediate format. If you use the static version, it still has to do that once, but it has an internal cache in which it stores those compiled regular expressions, making subsequent calls (a lot) faster.
The amount of regular expressions in this project is well below Regex.CacheSize, so we shouldn't see any churn there and get the full benefit of the cache.
More info: https://docs.microsoft.com/en-us/dotnet/standard/base-types/compilation-and-reuse-in-regular-expressions
As a follow up it would be interesting to also add the RegexOptions.Compiled flag, which increases the time and effort it takes for the first call, but should make subsequent calls faster. I don't know if the trade-of is worth it within an Azure Function though, so that would require some benchmarking.

This PR is invalidated by #10 which gets rid of regexes altogether.


StopIteration when calling covid.get_status_by_country_name("US")

Getting the following error when trying to call get_status_by_country_name on "US" works for other countries!
>>> covid.get_status_by_country_name("US")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File ".../.conda/envs/py36/lib/python3.6/site-packages/covid/__init_
_.py", line 281, in get_status_by_country_name
    country = next(country)
StopIteration

Yeah, I just checked, and it happens only with the "US" as you said.
I will investigate it.

I created a pull request.
https://github.com/ahmednafies/covid/pull/9
this will resolve the issue

Please upgrade you covid package to the latest release "1.4.2"

Works, thank you! 🎉


Cant parse some characters in the password field

I have noticed that if I include some special characters in the password (Like @ and + ) the connection attempt will be aborted.
This is because only certain characters are replaced on line 215. Is it possible to include more characters?.
We used the solutions provided in the first post here: https://forum.micropython.org/viewtopic.php?t=3076 . Making a ton of replaces could also work but that doesn't look very elegant.

I have noticed that if I include some special characters in the password (Like @ and + ) the connection attempt will be aborted. This is because only certain characters are replaced on line 215. Is it possible to include more characters?.
We used the solutions provided in the first post here: https://forum.micropython.org/viewtopic.php?t=3076 . Making a ton of replaces could also work but that doesn't look very elegant.

Thanks for the tip!
The update is already implemented.


failed to sync

Hi, I've been using the plugin for several months, but today it shows me this error message. And I did all the actions in Terminal, but still get this error message.
I created a new graph, installed the plugin too, then it can sync to Anki successfully, but my old graph still got this error message, do you have any suggestions?
Thanks for making this plugin, actually I use it everyday, will feel very sad if can not sync with old graph.

I think I found the problem, it is because I include more ':' in {c1:...}. I close this comment now.


Gettext 0.15.0 breaks support for elixir v1.3.4

Steps to reproduce
Try to compile using Elixir 1.3.4 (after removing/updating your current lock file).
== Compilation error on file lib/l10n/gettext.ex ==
** (UndefinedFunctionError) function Enum.split_with/2 is undefined or private. Did you mean one of:

      * split/2
      * split_while/2

    (elixir) Enum.split_with(["# # `msgid`s in this file come from POT (.pot) files.", "# #", "# # Do not add, change, or remove `msgid`s manually here as", "# # they're tied to the ones in the corresponding POT file", "# # (with the same domain).", "# #", "# # Use `mix gettext.extract --merge` or `mix gettext.merge`", "# # to merge POT files into PO files."], #Function<3.59487184/1 in Gettext.PO.Parser.extract_references/1>)
    (gettext) lib/gettext/po/parser.ex:51: Gettext.PO.Parser.extract_references/1
    (gettext) lib/gettext/po/parser.ex:34: Gettext.PO.Parser.to_struct/1
    (elixir) lib/enum.ex:1184: Enum."-map/2-lists^map/1-0-"/2
    (gettext) lib/gettext/po/parser.ex:24: Gettext.PO.Parser.parse_yecc_result/1
    (gettext) lib/gettext/po.ex:64: Gettext.PO.parse_string/1
    (gettext) lib/gettext/po.ex:126: Gettext.PO.parse_file/1
    (gettext) lib/gettext/po.ex:147: Gettext.PO.parse_file!/1

could not compile dependency :timex, "mix compile" failed. You can recompile this dependency with "mix deps.compile timex", update it with "mix deps.update timex" or clean it with "mix deps.clean timex"
make: *** [deps] Error 1

Description of issue
It seems the current version constraint for gettext in Timex's mix.exs makes 0.15.0 a valid candidate which supports ~> 1.4 conflicting with Timex's mix file which states ~> 1.3
The problem comes from gettext's use of split_with/2.
Running mix deps.update --all as a before_script would spot potential constraint errors
Workaround
If you are here because you have the same problem just override gettext in your mix file:
{:gettext, "~> 0.14.1", override: true}

I will probably retire this release since it is broken, and bump to 3.2.0 along with a new Elixir version requirement of 1.4. I'll leave this open until I've made that change. Thanks for reporting!

I've retired 3.1.25 (that means this version can be used if you previously depended on it, but you will get a warning, but no new dependencies on this version can be formed). Version 3.2.0 has been published with a new Elixir version requirement of ~> 1.4 and a formatting bug fix.


Module Ecto.Adapters.Postgres is not available

I was using 1.2.1 with elixir 1.2 and postgresx 0.12.
Now I am trying to update to 1.3.1 elixir 1.4 and postgresx 0.13
When I am configuring the types I am getting Module Ecto.Adapters.Postgres is not available before I was using the extension option, any clues?
Postgrex.Types.define(Stef.PostgresTypes,
              [Geo.PostGIS.Extension] ++ Ecto.Adapters.Postgres.extensions(),
              json: Poison)

Hi, I'm not sure from the information given, but if you're using just Postgrex without Ecto then that line would be different. You wouldn't need to add Ecto.Adapters.Postgres.extensions()
If you are using it with Ecto than this might be an Ecto specific issue.
You can also have a look at this example project I made to setup geo with new ecto:
https://github.com/bryanjos/geo_example

Thanks for the example I will have a look, I was trying to use Ecto.Adapters.Postgres.extensions() in the config file.

@steffenix all good? If so I can close this issue

All good.


Any known problem with python2.7 ?

I am trying to use askbot which django based app which makes use python-openid and I am getting following error on my website.
"Received "invalidate_handle" from server "
Here is link to full apache log.
http://bit.ly/apache_log
Can someone tell me if this is bug with python-openid or with my configuration ?

This repo is being archived. Closing issue.


Bug: Standardize punctuation for feedback messages.

Proposed MR for issue https://github.com/dropbox/zxcvbn/issues/248.
The feedback messages in feedback.coffee are not consistent with regards to punctuation. Some sentences are ended with a period, while others have no ending punctuation mark. This causes inconsistencies with implementing libraries such as https://github.com/antoantonyk/password-strength-meter.

i think the intent is supposed to be the other way around. no full-stops at the end of feedback is more flexible depending on how you want to display the messages

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Move to Makefile, try with "make install" or "make test"

Simplify the README in step 2. Move to uv?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.11%

Totals

Change from base Build<PHONE_NUMBER>1:
0.0%

Covered Lines:
326

Relevant Lines:
793

💛  - Coveralls


Uncaught Exception: at validateState

Tried to restart my application and during windowStateKeeper initialization this library threw unhandled exception.
Traceback:
Uncaught Exception:
TypeError: Error processing argument at index 0, conversion failure from # <Object>
    at TypeError (native)
    at validateState
(D:\projects\my_app\app\app\node_modules\electron-window-state\index.js:45:34)
    at module.exports
(D:\projects\my_app\app\app\node_modules\electron-window-state\index.js:153:3)
...
rest of the traceback is from my app (not relevant)

My code
        const mainWindowState = windowStateKeeper({
            defaultWidth: 1200,
            defaultHeight: 800,
        });
        const {x, y} = mainWindowState;
        const validLocation = isValidScreenLocation(x, y);  // Custom function to validate x and y positions
        const mainWindow = this.mainWindow = new BrowserWindow({
            x: validLocation ? x : 100,  // Default to 100 when no valid screen location
            y: validLocation ? y : 100,  // Default to 100 when no valid screen location
            width: mainWindowState.width,
            height: mainWindowState.height,
        });

Contents of my stored window-state.json
{
  "width": 1200,
  "height": 768,
  "x": 100,
  "y": 100,
  "isMaximized": false,
  "isFullScreen": false,
  "displayBounds": {
    "x": 0,
    "y": 0,
    "width": 1366,
    "height": 768
  }
}

Didn't figure out yet what was the actual problem.
I'm using:

electron-window-state: 4.0.1
electron: 1.4.2

After debugging a bit more, I found out that the window-state.json I was looking at was actually wrong file. Correct file was not the one in C:\Users\me\AppData\Roaming\myapp, instead the file in C:\Users\me\AppData\Roaming\Electron was used.
The file in C:\Users\me\AppData\Roaming\Electron looks like this:
{
  "width": 1304,
  "height": 768,
  "x": null,
  "y": 118,
  "isMaximized": true,
  "isFullScreen": false,
  "displayBounds": {
    "x": 0,
    "y": 0,
    "width": 1366,
    "height": 768
  }
}

And now the problem makes sense. The problem is most likely caused by "x": null,. Still not sure how null ends up in there.
Improvement ideas

We could have decent defaults during state update. Something like state.x = winBounds.x || 0; in updateState function.
We could validate state before saving it. That way we could be fairly sure that anything that gets saved is actually valid.
After everything goes bad we could at least use some safe defaults. Current implementation totally disables the whole application start up at the moment for me. Removing any invalid state file and using safe defaults would be much nicer.

Anyways, really nice library. Thanks for maintaining it!

Thanks for looking into this. 👍
Will try to come up with a solution for this.
Validating before save and falling back to defaults in case something is strange seems a good idea. The same applies for validating the loaded state.


Contributing guide

Hey :wave:!
I noticed that in the contributing guide it suggests to use tabs the default form of indentation, but most of the files in this project use 4 spaces, or they have spaces and tabs mixed (which is a mess, IMO).
What should I be using on my next PRs?
I personally would recommend using spaces are they are a more reliable way to show empty space (they don't change from editor/IDE) and also use .editorconfig which is supported by basically all C# IDEs/Editors (e.g. Rider, VS, VSCode) and would make the chosen standard auto-enforced :)

I prefer tabs since untabbing/aligning is easier, but I'll leave it up to jjxtra. There is an .editorconfig already (from your PR #461) but I don't think it retroactively modifies all of the old files to comply.

I've always preferred tabs as well. VS does 4 spaces by default I think, so I don't think it is critical that we mandate one way or the other. You can always type the last brace of a file to auto-format the file.


Update archive-tier-support.md

typo

@marion-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Old way of solving file not found error in accessing genotype file in different mount no longer works

Previousely, while using container to access genotype file in different mount, i.e. /mnt/mfs/statgen/ vs /mnt/mfs/ctnn/ , there will be a file not found error.
Following codes was used to patch that:
def get_genotype_file(chrom, genotype_list, geno_inventory):
    chrom = f'{chrom}'
    if chrom.startswith('chr'):
        chrom = chrom[3:]
    if chrom not in geno_inventory:
        geno_file = f'{chrom}'
    else:
        geno_file = geno_inventory[chrom]
    if not os.path.isfile(geno_file):
        # relative path
        if not os.path.isfile(f'{genotype_list:ad}/' + geno_file):
            raise ValueError(f"Cannot find genotype file {geno_file}")
        else:
            geno_file = f'{genotype_list:ad}/' + geno_file
    return path(geno_file)

geno_inventory = dict([x.strip().split() for x in open(genotype_list).readlines() if x.strip() and not x.strip().startswith('#')])

...

geno_file = get_genotype_file(_chrom,genotype_list,geno_inventory)
output: f'{wd:a}/{name}_chr{_chrom}.grm.gz'
task: trunk_workers = 1, trunk_size = 1, walltime = '12h',  mem = '60G', tags = f'{step_name}_{_output[0]:bn}'
bash: expand= "$[ ]", stderr = f'{_output[0]}.stderr', stdout = f'{_output[0]}.stdout', container = container, volumes =  [f'{geno_file:ad}:{geno_file:ad}']

however, while testing the pipeline with @at-crx , this method doesnt seems to works anymore. even with these specification, the the file not found error persist.
I am sure it is the mount issues because when I rerun the singularity exec command in /mnt/mfs/ctnn/, the issue no longer occurs.
For the time being, I will try use a soft link to "moved" the not accessible genotype file into /mnt/mfs/statgen/ to try to avoid it.
As the soft link doesnt work, I will cp the genotype to /mnt/mfs/statgen/ROSMAP-xqtl/datasets/

Problem disappear.


debug tests - kind of?

Essentially if DEBUG env is set I don’t automatically enable the debug module. Because without that instruction (debug.enable) you would not see any log in stdout/stderr, you should always specify the env var when starting z2m.
We could think about move to pinojs logger for logging
Sent with GitHawk

The test so could just listen to stdout/err data event when that env var is set or not
Sent with GitHawk

Don’t want to test a third party module.
Just couldn’t spot on the debug obj what changed to be able to test it. Might just mock the external code with proxyquire

@chrisns Nothing changes, the only thing that changes is the one I told you (stderr/stdout should or should not receive data).

@chrisns Maybe this could help: https://github.com/visionmedia/debug/blob/master/src/common.js#L156

@robertsLando this is ready to review now if you have a mo, thanks

Will look at it tomorrow, thanks Chris 🙏🏻

Daniel - Software Engineer
Support me at:
Github sponsors

On 27 Apr 2020, at 21:53, Chris Nesbitt-Smith<EMAIL_ADDRESS>wrote:

@robertsLando this is ready to review now if you have a mo, thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Remove cairo dependency

Next WeasyPrint release will not require cairo

Now it will be pure python!
Much easier to install!
Huzzah!

Seems like WeasyPrint was removed the cairo dependency. Based on their comment here.

@wengtad yes promising progress! Hopefully the remaining non-python deps will be dealt with soon too :)

Beta version is out - https://www.courtbouillon.org/blog/00008-weasyprint-53-beta

Hopefully the remaining non-python deps will be dealt with soon too :)

I hope so, but you’ll probably have to wait a little bit more! :wink:

Currently waiting for v2.0 of django-weasyprint to be released : https://github.com/fdemmer/django-weasyprint/issues/53#issuecomment-896122557

@SchrodingersGat fyi django-weasyprint 2.1.0 is released.

@42CrMo4 thanks for the update, was not aware that v2.x was out yet!


After exporting a text file, text formatting breaks.

Hello.
I'm trying to translate text for the game Outward.
I open the resources.assets archive, its location is standard steamapps\common\Outward\Outward_Defed\Outward Definitive Edition_Data
The file menu_all (inside the archive) is taken as an example.
If I click View Data, the content looks good, all indents and spaces are preserved.
But if I click Edit Data, OR if I export the file, then all the indents and spaces disappear and I get one long line.
It doesn't matter what format I export in, the resulting formatting is always ruined.
I tried opening the export file in different editors, but the content was one line.
And when I import this file back, its formatting is restored.
Working with a bunch of letters and text without any formatting makes the process very difficult.
Can you do anything about these ?

Where is this plugin located, how to install it and how to use it?
Could you write more about this, I couldn't find a description of it in the main thread.
In the program itself, if I click the “plugins” button, there are only two plugins: Import.txt and Export.txt

The "bad view" as you call it is very much intentional. It escapes certain characters like newlines to \n and isn't great for multiline strings (but is great for the computer parsing it). The import and export txt options simply copy the string as is in and out of a file. So you should use that instead of editing the dump. That does mean you can only edit the exported file in an external text editor and can't edit the file in a dialog box in UABEA, but that's just how it has to be for now.

It's a pity that this is so, do you happen to know what text editor can also escape the special characters /n, so that the text looks normal during editing ?

As I said, export .txt and import .txt (the text asset plugin) is what you want. You don't want to export/import dump because that contains \n. Despite the ".txt" part, you can name it whatever extension you want.


Error on vagrant up

Received error on vagrant up
$ vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Clearing any previously set forwarded ports...
==> default: Clearing any previously set network interfaces...
==> default: Preparing network interfaces based on configuration...
    default: Adapter 1: nat
==> default: Forwarding ports...
    default: 22 => 2222 (adapter 1)
==> default: Running 'pre-boot' VM customizations...
A customization command failed:

["modifyvm", :id, "--audio", "pulse", "--audiocontroller", "ac97"]

The following error was experienced:

#<Vagrant::Errors::VBoxManageError: There was an error while executing `VBoxManage`, a CLI used by Vagrant
for controlling VirtualBox. The command and stderr is shown below.

Command: ["modifyvm", "261aa7aa-1081-40af-b9be-8ce8d77eb47f", "--audio", "pulse", "--audiocontroller", "ac97"]

Stderr: VBoxManage: error: Invalid --audio argument 'pulse'
>

Please fix this customization and try again.

I think you want to try "dsound" (on Windows) or "coreaudio" (on Mac) instead of "pulse" - see https://github.com/tinyfm/sandbox/issues/7, we'll try to look into this more next week.

Or comment out the sound command all together,
which might make a better default and make sense for this vm


Use compat fspath instead of os.fspath in static_folder

When #3678 was merged it introduced the usage of os.fspath which is not supported on Python <3.6
This PR updates static_folder to use the fspath from _compat and un-skips the test case.
Checklist:

[x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
~[ ] Add or update relevant docs, in the docs folder and in code.~
[x] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
~[ ] Add .. versionchanged:: entries in any relevant code docs.~
[x] Run pre-commit hooks and fix any issues.
[x] Run pytest and tox, no tests failed.

We do not support < 3.6 any longer (and neither does CPython).

setup.py in 1.1.x says python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*"
https://github.com/pallets/flask/blob/c04b0de558fe8e1ccb8edb4525d40e725ae9a24d/setup.py#L54
Is it documented somewhere that 1.1.x does not support 3.6?

We no longer support 1.1.x either, due to the magnitude of the 2.x release. Unfortunately, this snuck in when we made an unplanned release to satisfy people who did not pin their dependencies.

Yeah, I understand not wanting to support EOL versions of Python, just seems like oversight that 1.1.3 introduced this breaking change, especially when there is a compat fspath available.
This is fine, it is your decision on how you want to support this, I should be able to work around this on my side without too much hassle, I'll just pin our 1.1.x testing to 1.1.2. If there are no more planned released on 1.1.x then should be perfectly fine for our use case.

I'll make another release.
I'd highly suggest telling clients who are still using EOL Python versions that they should consider upgrading. This seems appropriate for a monitoring tool that's designed to alert users about issues with their stack. ;-)

@davidism thanks, I really appreciate it.

1.1.4 is available on PyPI

@davidism thank you for the quick turn around time on this.


Suggested improvements

Slider should not require a user-defined handle component. It should use a default handle if one is not provided.
Also, the handle shouldn't be required to be a component. A div should be acceptable.
I may end up submitting a pull request, but my time is limited right now.

I think this is all implemented now


Changed seek forward/backward shortcuts to just left/right arrows

because ain't nobody got time for those crazy key combinations

Well all web players use this shortcut (simple arrow with no combinations) and popcorn time did this too.


Migrate from setup.py to pyproject.toml (PEP 517 and PEP 621)

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR addresses comments raised in https://github.com/pyOpenSci/software-review/issues/73

[ ] Tests for the changes have been added (for bug fixes / features)

[x] (If applicable) Documentation has been added / updated (for bug fixes / features)

[x] HISTORY.rst has been updated (with summary of main changes)

[x] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

setup.py is no longer used as the packaging system, pyproject.toml with flit is now the packaging engine.
several configurations for linting tools (including Manifest.in) have either been rendered obsolete or been migrated into the pyproject.toml
TOML checkers are now present in pre-commit

What other changes need to happen?

[x] package requirements need to be migrated into the package
[x] user-end installation tests need to be performed
~README and HISTORY require a pre-build step in order to properly be packaged and uploaded to PyPI. The ways this was done to date involved a hacky string replace step in setup.py. This might now need to be handled with a build-helper script~

[x] Drop the changelog from the PyPI index readme

Does this PR introduce a breaking change?
Yes. Very much. Installation of the package should be the same on the user end, but development tooling has changed significantly. Documentation will need to be updated accordingly.
Other information:
https://chadsmith.dev/python-packaging/

@aulemahal test-py39-opt-slow is consistently giving me the following:
FAILED xclim/testing/tests/test_sdba/test_properties.py::TestProperties::test_spatial_correlogram - AssertionError:
Not equal to tolerance rtol=1e-07, atol=0

Mismatched elements: 5 / 5 (100%)
Max absolute difference: 7.40815654e-05
Max relative difference: 4.549936e-07
 x: array([ 26.543211,  67.716254, 108.889298, 150.062341, 191.235384])
 y: array([ 26.543199,  67.716227, 108.889254, 150.062282, 191.23531 ])

Is this just a matter of adjusting tolerances, or should I be investigating further?

argh.
Yes easiest would be to adjust the tolerances.


Added support for 128 bit xmodem send and more than 256 blocks.

Hi!
Thanks for this project!
I needed to send 128 bit blocks so I added support for it. Not very tested but it might help someone else as well.
BR,
Chris

Subject: Your Dream Job Awaits: Apply Now to Join GitHub as a Developer!
Hey there,
We've got some thrilling news for you! GitHub is currently looking for skilled Developers to join our team. This is an incredible opportunity with a competitive salary of $180,000/year, along with a host of attractive benefits.
Interested in taking your career to the next level? Don't miss out! Click here to apply and secure your spot.
Looking forward to potentially welcoming you aboard!
Best regards,
GitHub Recruitment Team
caoxuwen, @hrntknr, @eugenestarchenko, @renaynay, @JingChaoChao, @Hardsheet, @prahaladbelavadi, @Lehonid, @apilipis, @aliensyntax, @alphadose, @diegode, @baiyunping333, @srw, @holybao, @odao, @talk2sohail, @makluganteng, @alcidesmorales, @ohz10


Make asteroids take a planet config

Feature
Allow asteroids to take a list of planet configs, and then it will use those as prefabs to make however many asteroids you want. Will allow people to make asteroids with unity detailing
Context
No response

This could create an issue with schema generation as I don't know if it can handle recursive data structures like that.

I intended it to be entire configs in the asteroid module tbh

Nobody wants this, just make a billion configs if you care


[#5800] Support any FileRegion implementation when using epoll transport

Motivation:
At the moment only DefaultFileRegion is supported when using the native epoll transport.
Modification:

Add support for any FileRegion implementation
Add test case

Result:
Also custom FileRegion implementation are supported when using the epoll transport.

@Scottmitch PTAL

lgtm ... new review feature is nice :)

Cherry-picked into 4.1 (2c4a7a253912458908d45dc653b52ff3a3aaab99) and 4.0 (366130c6b34c2203f26c62b2aeb1abbcb4df7398)


Maven does not work

After installing Java 7, following @russalex instructions in the #49 issue, Maven does not work. Installing via apt-get doesn't work because requires the openjdk (that doesn't work via apt-get), so I installed manually. Trying to run mvn clean install, nothing happens. Here is the strace for it: http://pastebin.com/hB8zQMkG.
I tryied to do a symlink in the WSL user home directory to avoid any error about the filesystem but I have the same error.

Is the strace output similar on Native Ubuntu?  I'm mostly wondering if the "/etc/mavenrc" file exists (near the end of your provided strace).

I created the "/etc/mavenrc" manually, and the "~/.mavenrc" also. But still does not work.

Maven can now be installed via apt-get but it still freezes and does nothing. and can't be quit either

Same here, this time with openjdk7 installed via apt-get and latest 14366 build. The java process has to be killed with task explorer as it fully uses one core and does not respond to ctrl+C.

https://gist.github.com/pavelbrylov/45d30f56799b74ea1fdbc52a76835113 here is my strace for not working maven, seems the futex issue :(
Any chance to get it fixed? There is multiple tickets around java, some of them are closed, but anything more complex that hello world doesn't seem to work :(
I tried different versions of java from different sources, with "default-jdk" I was at least able to get mvn -version, but nothing more :(

It works for me on build 14901. With maven 3 downloaded from http://www-eu.apache.org/dist/maven/maven-3/3.3.9/binaries/apache-maven-3.3.9-bin.tar.gz, default-jdk (version 7) & git from apt. My rather complicated application (an application server) fully compiles and tests can run (It's clearly slower than on native Windows on the same machine, but I don't care).
Many thanks to the WSL team.

Be great to understand how you got this working @marcanpilami
first mvn -v didn't work, but after setting JAVA_HOME, it works with the following output, but everything else just hangs
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00)
Maven home: /home/user/apache-maven-3.3.9
Java version: 1.7.0_111, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "3.4.0+", arch: "amd64", family: "unix"

@khowling : on build 14946, Ubuntu 16.04.1. Just do:
cd ~
sudo apt install openjdk-8-jdk-headless
wget http://wwwftp.ciril.fr/pub/apache/maven/maven-3/3.3.9/binaries/apache-maven-3.3.9-bin.tar.gz
tar -xzf apache-maven-3.3.9-bin.tar.gz
export PATH="$PATH:apache-maven-3.3.9/bin"
cd YOUR_PROJECT_PATH
mvn clean install

Bonus: now with JDK 8 and not 7 anymore. Getting better and better.

@all closing this as the issue appears to have been resolved. Please reopen if you continue to see issues.

@marcanpilami Thank you. It worked


Show favicons in the UI

We'll presumably need some way to get favicons into the UI (tab titles and/or autocomplete suggestions)

See also #642

We have this now.


Various changes for Production based on our testing

Change to 16 jobs-per-nmap-host and 8 jobs-per-nessus-host for further Production testing
Switch to smaller nmap EC2 instance type (t2.large -> t2.medium)
Modify scanner security group to allow all traffic on non-SSH/Nessus ports to try to avoid connection table saturation (see https://aerissecure.com/blog/vulnerability-scanning-from-aws/)

Nobody approve this yet- this is a Work in Progress.

Ready for review.  It's time to close out this branch for now.


Daikatana: Remove redundant MP3 soundtrack after package install

Game
Daikatana
Engine
Unofficial Patch 1.3
Linux Distribution
SteamOS v3.6.12 Beta
Luxtorpeda Version
v70.1.1
Bug description
The redundant MP3 music still persists in the game's install directory after Luxtorpeda installs the OGG soundtrack.
Steps To Reproduce

Install Unofficial Patch 1.3 through Luxtorpeda.

Expected Behavior
The MP3 music should be automatically removed after the OGG music is installed, except for the following files:

deadly.mp3
Katana1.mp3

Additional Context
No response
Relevant log output
No response

What's the issue with the existing mp3 files?

The MP3 files that come with the game are of lower-quality/lower-bitrate than the OGG files downloaded through Luxtorpeda

What does the files being there affect? as in, is the game defaulting to using those, or something else?


Create data structures for game

Board:

Id (GUID)
Code (8-digit string)
Description (string)
Is open (boolean)
Participants (list of User objects)
Bets (list of Bet objects)

User:

Id (GUID)
Display name

BetGroup:

Id (GUID)
Description (string)
Bets (list of Bet objects)

Bet:

Id (GUID)
Description (string)
User bets (list of UserBet objects)
Is resolved (boolean)

UserBet:

Id (GUID)
User
Amount

Data types should all go in a data directory.


updated architecture page

Notes for Reviewers
This PR fixes #7791
Signed commits

[X] Yes, I signed my commits.

🚀 Preview for commit 462122e13187cbe4658646058f9f06d2c7d0464b at: https://648709bc0a8dcb24d69ba8d5--meshery-docs-preview.netlify.app

Hey @thisiskaransgit , You have missed updating the https://docs.meshery.io/guides/upgrade
Svg 😅 with

@leecalcote, there's some more information that's left to add,on the the page, and there's a topic of discussion, with reference to the meshery adapter slide and I'll incorporate the changes in this PR.

🚀 Preview for commit 7c7ae45999ab254f0a5426702156e50a9066d267 at: https://6488d62f8c14db226fdbe8fc--meshery-docs-preview.netlify.app

Good feedback, @DarrenDsouza7273. 👍
Perhaps, you might submit a follow up PR? You can export individual architecture deck slides to SVG...

@leecalcote you tagged the wrong id 🥲

@leecalcote, there's some more information that's left to add,on the the page, and there's a topic of discussion, with reference to the meshery adapter slide and I'll incorporate the changes in this PR.

Moving forward... hasten your step with the clicking of File --> Download --> SVG, @thisiskaransgit


MouseDrag on flickity carousel

Any option to update the current cursor position on dragMouseMove with flickity carousel.

I don't use Flickity, you need to do some research.


Feature/6339 investigate gitleaks failure

This PR is to the Gitleaks failure  on the PRIME ReportStream code-base
Test Steps:

Include steps to test these changes
Updated the code and ran the actions successfully

Changes

Include a comprehensive list of changes in this PR
See PR, File changed

Checklist
Testing

[ ] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues

Fixes #issue

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

Looks like there are duplicate files in this PR, will you please remove?


Sdk6

:tada: This PR is included in version 6.0.0-beta.6 :tada:
The release is available on:

npm package (@sdk6 dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 6.0.0-rc.1 :tada:
The release is available on:

npm package (@prerelease dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Unit test console suppression

For unit tests that run features that explicitly output to the console, redirect the test output away from the real console to clean up unit test output.
Such things include TimingDAO, .describe()

captureWarn() is set up to capture warnings, where installed. Also apply to logs...


Update quickcheck to 0.8

partial-io:0.3 currently depends on quickcheck:0.6, while version 0.8 has been available for a few months now.
https://github.com/BurntSushi/quickcheck/releases

Thanks for letting me know!
This would be a semver breakage (i.e. would have to be 0.4), right?

Yes, as it would break code currently depending on quickcheck:0.6.

Thanks! I'll try getting an update out in a day or so.

Turns out this is much more complicated than I expected, unfortunately. For FB-internal reasons I'm blocked on at least https://github.com/tomprogrammer/rust-ascii/issues/61, possibly some other crates.

Now targetting quickcheck 0.9.0.
Is it still planned?

Going to try getting quickcheck 0.9 support out in the next couple of days (see #26). Really sorry about the delay!

I've released version 0.4.0 with an update to both quickcheck 0.9 and to futures 0.3/tokio 0.2. Thank you so much for waiting for so long, it took me a long time to finally get around to this.


Merging repeated elements without any non-whitespace content between them

many WYSIWYG HTML editors leave a lot of artifacts, spamming elements being one example. currently, turndown converts the following:
a b

to
**a** **b**

which is not wrong, but **a b** would've been preferred. the actual code examples are not so short and are spammed with repeated tags that make the output less readable.
a similar issue is about general handling of whitespace. for example:

  a

b

is converted to:
**a
**b

while the ideal output would've been:
**a**
b

I'm not sure how complex it would be to make these changes, but generally ignoring whitespace between multiple tags of the same kind, and pushing whitespace from beginning and end to the outside of tags would increase the quality of output for my main use case a lot.
thanks.

I think the best way to work with this would be to have another module or utility that rearranges HTML tags so that everything is properly nested, and then have it as an optional first step before your current Turndown converter.

It has come up multiple times now that people want/need their HTML fixed before conversion. It may be useful to recommend a different utility that shakes out and properly rearranges HTML tag nesting, and provide a way to attach it to this one?

It may be useful to recommend a different utility that shakes out and properly rearranges HTML tag nesting

@spirograph 👍  do you know of any libraries that will do this?