VS2019 crashes with the CreditCardFraud dataset from Kaggle

Problem encountered on https://dotnet.microsoft.com/learn/ml-dotnet/get-started-tutorial/train
Operating System: windows
When training a new model from the CreditCardFraud dataset from Kaggle
(https://www.kaggle.com/mlg-ulb/creditcardfraud), Visual Studio 2019 16.5.2 crashes after starting the training, activating another window and reactivating Visual Studio.

Hey @marcselis . I can't reproduce the error on my computer, could you provide more details on it. Thanks

I am following the tutorial in the link above, but I'm using the 155Mb input file from kaggle instead of the input file that is proposed in the tutorial.  When I come to the stage to start training the model it proposes to spend 1800 seconds on training.
After I click "start training", the trainign process starts and the progress keeps updating like expected.
But when I use my computer to do something else and switch back to Visual Studio 2019 16.5.2 to check on the progress, Visual Studio hangs.  The progress is not updated anymore and it is not responding to any clicks on menu items or whatever.  After some time a dialog appears saying that Visual Studio is not responding and needs to be restarted.

Can you reproduce the crash
@JakeRadMSFT Do you know where can we check VS's crash logs

Yes I can reproduce the problem.
Steps:

start visual studio
create a new .NET Core 3.1 console project
click add, "Machine Learning"
Choose Sentiment Analysis
Choose File input and select the creditcard.csv file
Set "Column to predict label" to "class"
Click the "Train" button
Click the "Start Training" button.  The training time counter starts decreasing.
Activate another Window on your computer, "Edge Chromium" for example
Reactivate visual studio.
You'll notice that Visual Studio is not responding.  The training time counter is frozen.
Click somewhere in the Visual Studio window.
After a few seconds the "Microsoft Visual Studio 2019 has stopped working" dialog appears.

VSLog.zip

There is even an easier way to make Visual Studio crash I found out while documenting the steps above: if you activate another window after step 5 above and then reactivate Visual Studio again, the "Visual Studio 2019 stopped working" dialog appears quasi immediately.
VSLog2.zip

Hey @marcselis, we might need your dump file for further diagnosis.  Could you follow this link and report the issue that you find, thanks

Hi @LittleLittleCloud, problem report can be found here: https://developercommunity.visualstudio.com/content/problem/984205/vs2019-1953-crash-while-using-microsoftml-modelbui.html

Thanks


resume training using log.json and not checkpoint

Currently in tools/train.py we have option to resume training from last checkpoint.
as such is there a way to resume training using the log.json that are written in work_dirs?

Currently not.

that's disappointing


Using UITests with Match

Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject
What tool/action do you have a question about?
Fastlane with match
Is this a question about documentation?
In part, it is, I imagine it would be good to mention this in the documentation.
Question Description

What is the suggested way of using match to create provisioning profiles for the UITests target? Do I just add a wildcard provisioning profile, or should I specify it to the target's bundleID itself? What do you recommend?

Huh, how did you setup and want to run your UITests? I am not aware I had to do anything to make scan/run_tests work.

I have the UITests target, that needs to be code signed, but it has a unique bundle ID. I'd like to know more about the code signing for that target with match, as I don't want to auto sign it, obviously.


Implementation of lanczos down scaling

Description
This is milestone merge after implementing lanczos scaling
Environment
Everything that supports Boost 1.70
References
https://en.wikipedia.org/wiki/Lanczos_resampling
Tasklist

[X] Lanczos scaling
[X] Add test case(s)
[X] Ensure all CI builds pass
[ ] Review and approve

@stefanseefeld I don't think @simmplecoder has commit access to perform the merge.

@simmplecoder You now have commit access to this repository!

with great power comes great responsibility  :)


Feature request: Vagrant support

What would you like to be added:
I'd like to create Vagrant1 usable images. While it would still be possible to alter the images afterwards it would be much easier to have just a vagrant feature in place. If this is acceptable to you I can provide a PR (this should be a very easy feature).
Why is this needed:
There might be scenarios where you'd like to test with Garden Linux without any orchestration. This is where Vagrant steps in.

Hey @Vincinator,
trust you're doing well!
Ah ok, I see - tbh, I also haven't thought about it but I think a basic GL image for VMware should do. What does an image need to be vagrant complaint? We just need a user vagrant (which can be accessed by ssh) with the vagrant insecure ssh keys (see also here).
Everything else is handled on client site.
Cheers,
gyptazy

related pr for vagrant/libvirt
I closed it when vagrant changed the license, I'm still not sure what the new BUSL license actually allows but since it's not an OSI-approved license I personally started using lima instead of vagrant.

Nice, maybe we can create a multi provider flavoured vagrant feature after clarifying the license part. For me, a VMware (Fusion) provider is important, but I think we can dynamically obtain the base (VMware, libvirt/kvm, ...) and create additional VBox images to cover the most user scenarios.


Make tasks.json/launch.json more generic for easy re-use

When azdev-ifying a template, I should be able to add tasks.json/launch.json and can easily F5 to run and debug.
Options:

based on existing azd app-templates
VS Code extension to help me scaffold the tasks.json and launch.json files.

Today, it's not that easy to figure out what are the right pieces to pick.

@puicchan What specific problems are we seeing and trying to solve for here?
In talking with @bwateratmsft, it seems that reusability of these files within the same language is pretty high.

Closing in favor of https://github.com/Azure/azure-dev/issues/3960


Merge: Host Map Refresh (777)

Fixes #777

Closing in favor of letting the original author pursue test failures


Add shortcuts for read.format("xml").load() and write.format("xml").save()

This PR proposes Scala-specific short-cuts for read.format("xml").load() and write.format("xml").save() as below:
df.read.xml(path)

df.write.xml(path)

Codecov Report

Merging #250 into master will increase coverage by 0.03%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   88.25%   88.28%   +0.03%
==========================================
  Files          14       14
  Lines         732      734       +2
  Branches       96      101       +5
==========================================
+ Hits          646      648       +2
  Misses         86       86

Impacted Files
Coverage Δ

.../main/scala/com/databricks/spark/xml/package.scala
9.09% <25%> (+9.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fbb52c...3c4b749. Read the comment docs.


Support foreign key changes in diff

Currently foreign key changes are not considered by diff. This will return those changes too.

relates to https://github.com/simplethings/EntityAudit/issues/123

Why has this not been merged? Is there any problem with this approach? @tolry?

Sorry, should have tested. This doesn't really work that well.

Hey, can you revert the changes in the composer.json and create a test? Thanks!

@eigan @DavidBadura I also need this feature for my project.
BTW, it seems @sebastianreloaded  try to compare all properties of the foreign association. But we just need the reference diff to see if the link is the same, right?
Plus, this PR is very old, not sure it will be updated.
I'll try to work for a new one.

@Soullivaneuh with pleasure :)

@DavidBadura On which branch should I work?
For me it's for a minor release because it's more a new feature than a bugfix.
Branch 1.0 is for 1.0.x releases if I'm right but master is already pointing for 2.x.
Can you please tell me what to do?
Maybe create a 1.x branch instead of 1.0?

We do not want any new features anymore for 1.0. So we do not have feature releases for version 1.
The master will be version 2.0. We haven't ressources to support two versions, so we will no longer support branch 1.0 as version 2.0 was released.
So please every feature in the master :)

Ok. I would recommend to use 1.x, 2.x etc branch and master for next major.
2.x will be the maintained branch for both patch and minor, master for major only.
It's easier to manage and keep some flexibility with semver. I use this for my personal projects with not a lot of time for them, works great. :wink:

@DavidBadura Please see #249.

replaced by #249


🐛 BUG: duplex option is not set in Proxy.fetch

Which Cloudflare product(s) does this pertain to?
Wrangler core, Miniflare
What version(s) of the tool(s) are you using?
Wrangler 3.27.0
What version of Node are you using?
20.10.0
What operating system and version are you using?
Mac Sonoma 14.3.1
Describe the Bug
Observed behavior
This bug, or something like a bug, occurred when using getPlatformProxy() and @cloudflare/ai together.
Script:
import { getPlatformProxy } from 'wrangler';
import { Ai } from '@cloudflare/ai';

const proxy = await getPlatformProxy();
const ai = new Ai(proxy.env.AI);
//...
proxy.dispose();

Error message:
$ tsx src/index.mts
/Users/yusuke/work/c/fetch-duplex/node_modules/wrangler/wrangler-dist/cli.js:29572
            throw a;
            ^

TypeError: RequestInit: duplex option is required when sending a body.
    at new Request (/Users/yusuke/work/c/fetch-duplex/node_modules/undici/lib/fetch/request.js:491:15)
    at Request (/Users/yusuke/work/c/fetch-duplex/node_modules/miniflare/src/http/request.ts:34:3)
    at ProxyStubHandler.#fetcherFetchCall (/Users/yusuke/work/c/fetch-duplex/node_modules/miniflare/src/plugins/core/proxy/client.ts:594:19)
    at ProxyStubHandler.#call (/Users/yusuke/work/c/fetch-duplex/node_modules/miniflare/src/plugins/core/proxy/client.ts:501:52)
    at Proxy.fetch (/Users/yusuke/work/c/fetch-duplex/node_modules/miniflare/src/plugins/core/proxy/client.ts:484:25)
    at InferenceSession.run (/Users/yusuke/work/c/fetch-duplex/node_modules/@cloudflare/ai/src/session.ts:72:28)
    at Ai.run (/Users/yusuke/work/c/fetch-duplex/node_modules/@cloudflare/ai/src/ai.ts:113:44)
    at <anonymous> (/Users/yusuke/work/c/fetch-duplex/src/index.mts:7:25)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Node.js v20.10.0
error Command failed with exit code 7.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Adding duplex:'half' to fetch option in the @cloudflare/ai solves the problem. So, the option duplex:'half' is not set in the Proxy.fetch (I don't know if it is correct to say that)  fetch option.
Expected behavior
Does not throw the error.
Please provide a link to a minimal reproduction
https://github.com/yusukebe/get-platform-proxy-cloudflare-ai
Please provide any relevant error logs
No response

I've talked with @mrbbot , he pointed out that we can fix this here:
https://github.com/cloudflare/workers-sdk/blob/a751489f2530bc7a7adec1167319cd145f080812/packages/miniflare/src/plugins/core/proxy/client.ts#L601

If adding { duplex: "half" } to @cloudflare/ai solves the issue, we can try to add it in a pre-release to see if any other issues show up
We are doing a major revamp in @cloudflare/ai, so we are also going to be doing a lot of tests, maybe now is the best opportunity to do that

Hi. Thanks for the comments and the PR!
I don't know if the test is necessary or not, but I would like the fix for #5114.

@yusukebe Does the linked PR fix the issue for you?

@penalosa
Yes!

Hi @mrbbot @penalosa @G4brym !
I've tried it with the new version 1.1.0 of @cloudflare/ai with getPlatformProxy(), it works well!
I'm not sure which commit fixed this issue (maybe @G4brym added?) , duplex: 'half' option is passing to fetch in the compiled JavaScript source of @cloudflare/ai.
So, my problem - I could not use @cloudflare/ai and getPlatformProxy() together - is fixed now. I'll leave it to you to decide what to do with PR #5114. But if it is not needed, I might be able to close this issue.

Closing this for now since it seems @cloudflare/ai is fixed, and in any case the AI binding is now implemented in the runtime.


Bumping Vagrant gem to 1.7.2

Bumping up Vagrant gem version to 1.7.2 and updating the plugin load mechanism accordingly.
Fog needs to be bumped up as well, due to dependency issues (made sure #25 doesn't pop up again).
One note before you consider the pull request - maybe it makes sense to just refer to the master in dev environment, as in:
gem "vagrant", :git => "git://github.com/mitchellh/vagrant.git"
, instead of
gem "vagrant", :git => "git://github.com/mitchellh/vagrant.git", :tag => "v1.7.2"
(aws, berkshelf have updated to do the same after 1.5 it seems)
However, I'm not sure whether there was a particular reason for sticking to a certain version, so putting this into consideration here first.

Feel free to drop the version. I think that's an ancient artifact.

@erjohnso As per our discussion, bumped to track upstream.

lgtm - thanks @Temikus !


fix(deps): upgrade to google-gax 1.x

Fixes #622.
@crwilcox / @callmehiphop / @alexander-fenster  - I am a little freaked out that these tests pass 😆 This is using<EMAIL_ADDRESS>which swaps out native grpc for grpc-js. With the whole gcp-grpc thing, I figured this would cause test failures.  But .. it just doesn't.
Then, I noticed that we're not using grpc-gcp anywhere 🤔
TL;DR:  I don't know what's real anymore

@JustinBeckwith The whole grpc-gcp thing was in gax and is removed from there in v1.0.0 (because it does not work with @grpc/grpc-js). In spanner, we only set its options:
https://github.com/googleapis/nodejs-spanner/blob/ace135997c5a5aa2948dfe9f9dfbf9bf55b4fb33/src/index.ts#L225
which will be ignored by gax v1.0.0 (but no failures will occur). Nothing will break, but the functionality will be lost.
To move to gax v1.0.0, someone would need to copy the grpc-gcp functionality that was removed from gax into the spanner code, and pass the C-core grpc as a parameter. Here is the removed code:
https://github.com/googleapis/gax-nodejs/pull/484/files#diff-bb99529408df06caafed25d9e0cd083fL298
const apiConfigDefinition = options['grpc_gcp.apiConfig'];
if (apiConfigDefinition) {
  const apiConfig = grpcGcp.createGcpApiConfig(apiConfigDefinition);
  grpcOptions['channelFactoryOverride'] = grpcGcp.gcpChannelFactoryOverride;
  grpcOptions['callInvocationTransformer'] =
    grpcGcp.gcpCallInvocationTransformer;
  grpcOptions['gcpApiConfig'] = apiConfig;
}

Basically, this exact code should live in spanner, before client constructor call. Import grpc-gcp, do the same, but prefix all options with grpc. (e.g. grpc.channelFactoryOverride), and pass them as options to the client constructor alongside with the C-core grpc object in src/index.ts:
// Enable grpc-gcp support
const apiConfig = grpcGcp.createGcpApiConfig(gcpApiConfig);
const grpcGcpOptions = {
  "grpc.channelFactoryOverride": grpcGcp.gcpChannelFactoryOverride,
  "grpc.callInvocationTransformer": grpcGcp.gcpCallInvocationTransformer,
  "grpc.gcpApiConfig": apiConfig
};
options = Object.assign({'grpc_gcp.apiConfig': gcpApiConfig}, options);

I did not check this code but should be pretty much something like this. Also, some tests that verify the options are passed down are needed.

(note: I updated the code in the comment above)

Closing this out, and leaving it to @stephenplusplus to drive forward 👍

Please let me know if this was the right way to go! #651


iOS9 XCode 7.0 issue

@archagon  i just noticed that keyboard does not work properly on iOS 9. Wanted to fix it but could not succeeded. Will appreciate if you could make a new branch and move code to Swift 2.0 and fix issues on xcode 7.0 when u have free time. Thanks!

Could you by chance try running one of my keyboard apps on iOS9? Does it work? http://itunes.apple.com/app/id931305272

i'll try your keyboard and let you know. This is what happens. It work ok on 1st load but when u hide keyboard and it appeard 2nd time BannerView doesn`t load and popups on click are not appearing correctly.

Thanks for the tip! Sigh, guess I have some work to do until September.

@archagon looks like your code works just fine. I did some research and found the problem. On xcode 6.3 when u hide keyboard and show it again  or just change keyboard and bring it  back init() method called. But on xcode 7.0 beta when u hide it and show again it is not called, only viewDidAppear is called.. My problem was that: i was removing and killing some objects on viewDidDissapear and recreating them on init() so when hiding /showing keyboard as init() never calling my objects were missing so it affected  things...


does this still work?

Hi, I can't really get it to work... Everytime I try, cursor gives the error:
(status code 0)
TypeError: Failed to fetch,
and the router says:
Starting server on :11411
{"level":"warn","ts":1729099580.0293329,"caller":"handler/handler.go:23","msg":"Invalid or missing API key","receivedAuthHeader":"","expectedAuthHeader":"****** ******"}
and ngrok says:
19:26:20.029 CESTOPTIONS /v1/chat/completions   401 Unauthorized.
when using ollama, do you need an openai api key or do u use ollama instead when running $env:OPENAI_API_KEY="<OPENAPI_KEY>"; .\llm-router-windows-amd64.exe

You're close! To resolve the "Invalid or missing API key" error:

Set an OpenAI API Key in Cursor's model settings.
Let Cursor verify the key.
Change the endpoint to your llm-router ngrok URL.
Use the same API key when launching llm-router.

This should complete your setup.

您已经接近成功！要解决“API 密钥无效或缺失”错误，请执行以下操作：

在 Cursor 的模型设置中设置 OpenAI API 密钥。
让 Cursor 验证密钥。
将端点更改为您的 llm-router ngrok URL。
启动 llm-router 时使用相同的 API 密钥。

这应该完成了您的设置。

what means must be have a correct openai api key first?


Create a new color token for the icon

Background: This work started with icons placed at the bottom right in tiles. Using the $interactive token does not pass the accessibility requirements in dark themes. We wanted to create a new color token for this icon. This can also apply to other elements in the future.
Token name: $icon-interactive

White and Gray 10 theme: Blue 60 #0f62fe

Gray 90 and Gray 100 theme: White #ffffff

[ ] Develop the token (developer)

@thyhmdo I will move this over to the core carbon repo so we can add it to the theme package, and add it in shortly 👍🏻


[CMake] Introduce LLDB_ENABLE_SWIFT_SUPPORT.

Allows lldb-tblgen to be built without a swift
checkout.
rdar://problem/55916729

@swift-ci test

Hi Alex! This currently works for lldb-tblgen [which is really useful to build for cross-compiling lldb itself] but presumably works for other targets too. The goal is to eventually use this to guard the whole swift support, but we're far away from that. Does this make sense?

Makes sense to me! Thanks for the explanation. Looking forward to seeing where this goes.

@swift-ci test


[WIP] [BUG] Check and Request camera permission before taking photos.

@RocketChat/android

Closes #2197

@divyanshub024 Any news here?
Thank you.

@filipedelimabrito I have made the requested changes.


Soulbound enchant dramatically reduces opportunities for more practical enchants

Suggestion/complaint:
The Soulbound enchant shows up so often in vanilla enchanting it is frustrating as it takes up the slot a more generally useful enchant would.
Vanilla enchanting in 1.8+ is actually really useful unlike in previous versions of MC; so this wasn't really a problem.
I just realized I can disable it in config and have done so.
That being said, maybe it should ship disabled?
Since the mod has it's own enchanting system why even put enchants in the vanilla enchanting table? [I'm saying this rhetorically, I don't really care if there is an answer for that question.]

Thank you for your suggestion. It has been added to our list or possible enhancement.
This ticket will be closed because we want the list of open tickets to reflect known issues.

BTW: you can configure the rarity of the soulbound enchantment in the config; they key is called "enchantmentSoulBoundWeight"


Aux window: Allowing search windows to be opened in a new window

I think it would be great that when searching globally for files/content, there will be an option to do so in a new window.
Much like Jetbrains editors do, an example:

You can do so via search editors:

Otherwise, a duplicate of https://github.com/microsoft/vscode/issues/193267


pyads v3.3.9

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

This tries to build from the PyPi release source instead of GitHub

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Thanks again @wolfv! :+1:


discoverd: mux

Overview
This pull request adds support for multiplexing a single TCP socket for discoverd to communicate over HTTP and Raft. This simplifies deployment and fixes an issue where HTTP ports are not managed by Raft (#2003).
The multiplexing is required for splitting off the forwarding of instance heartbeats to raft nodes without going through raft itself.
Details
The bulk of the multiplexing code is isolated to the pkg/mux. The multiplexer works by checking the first byte of a connection and redirecting the connection to the appropriate listener. The Raft store expects a leading 0xFF byte while the HTTP handler expects a byte corresponding to the first letter of one of the possible HTTP methods (CONNECT, DELETE, GET, HEAD, OPTIONS, POST, PUT, TRACE).

/cc @titanous @josephglanville

We'll need to sort out how to deploy this as an update.

Deploying as an update could be painful as the other nodes in the cluster won't be running the mux.
This will mean that when the new node enables it's HTTP API it will probably not be the leader and will attempt to mark itself done in the service meta it will direct itself to the wrong port on the leader.

@titanous What is required for deploying as an update? The old nodes won't be able to communicate with raft in the new discoverd so a new leader will be elected once a quorum is updated. Although the discoverd cluster will have the old ports in its peer list. Those will need to be changed.

@benbjohnson pushed a pull-request to your branch that fixes up the test build.
Everything looks good the only thing I wanted to ask is what you thought about changing the internal port rather than the external port. i.e 1110 => 1111 rather than 1111 => 1110. On the off chance someone is actually using the discoverd API for something.

Yeah, I'd like to stick with 1111.

@josephglanville Good point. I didn't see your PR until after I made the port change, rebased and pushed up. I cherry picked your testutil fixes commit though. Thanks!

All good mate lol.

LGTM. Please squash into one commit and merge. The discoverd updater doesn't support the current release, so we don't need to worry about rolling this out.
Happy Thanksgiving!

LGTM.
Happy Thanksgiving from Australia. :)

Looks like there's a race:
==================
WARNING: DATA RACE
Read by goroutine 10:
  github.com/flynn/flynn/pkg/mux_test.TestMux_Listen_ErrUnregisteredHandler()
      /home/ubuntu/go/src/github.com/flynn/flynn/pkg/mux/mux_test.go:110 +0xba0
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:447 +0x133

Previous write by goroutine 12:
  bytes.(*Buffer).grow()
      /usr/local/go/src/bytes/buffer.go:102 +0x190
  bytes.(*Buffer).Write()
      /usr/local/go/src/bytes/buffer.go:127 +0x75
  log.(*Logger).Output()
      /usr/local/go/src/log/log.go:153 +0x692
  log.(*Logger).Printf()
      /usr/local/go/src/log/log.go:160 +0x92
  github.com/flynn/flynn/pkg/mux.func·002()
      github.com/flynn/flynn/pkg/mux/_test/_obj_test/mux.go:90 +0x220

Goroutine 10 (running) created at:
  testing.RunTests()
      /usr/local/go/src/testing/testing.go:555 +0xd4e
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:485 +0xe0
  main.main()
      github.com/flynn/flynn/pkg/mux/_test/_testmain.go:104 +0x381

Goroutine 12 (finished) created at:
  github.com/flynn/flynn/pkg/mux.(*Mux).Serve()
      github.com/flynn/flynn/pkg/mux/_test/_obj_test/mux.go:92 +0x627
==================
==================
WARNING: DATA RACE
Read by goroutine 10:
  github.com/flynn/flynn/pkg/mux_test.TestMux_Listen_ErrUnregisteredHandler()
      /home/ubuntu/go/src/github.com/flynn/flynn/pkg/mux/mux_test.go:110 +0xbd3
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:447 +0x133

Previous write by goroutine 12:
  bytes.(*Buffer).grow()
      /usr/local/go/src/bytes/buffer.go:103 +0x1e3
  bytes.(*Buffer).Write()
      /usr/local/go/src/bytes/buffer.go:127 +0x75
  log.(*Logger).Output()
      /usr/local/go/src/log/log.go:153 +0x692
  log.(*Logger).Printf()
      /usr/local/go/src/log/log.go:160 +0x92
  github.com/flynn/flynn/pkg/mux.func·002()
      github.com/flynn/flynn/pkg/mux/_test/_obj_test/mux.go:90 +0x220

Goroutine 10 (running) created at:
  testing.RunTests()
      /usr/local/go/src/testing/testing.go:555 +0xd4e
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:485 +0xe0
  main.main()
      github.com/flynn/flynn/pkg/mux/_test/_testmain.go:104 +0x381

Goroutine 12 (finished) created at:
  github.com/flynn/flynn/pkg/mux.(*Mux).Serve()
      github.com/flynn/flynn/pkg/mux/_test/_obj_test/mux.go:92 +0x627
==================
==================
WARNING: DATA RACE
Read by goroutine 10:
  runtime.slicebytetostring()
      /usr/local/go/src/runtime/string.go:62 +0x0
  github.com/flynn/flynn/pkg/mux_test.TestMux_Listen_ErrUnregisteredHandler()
      /home/ubuntu/go/src/github.com/flynn/flynn/pkg/mux/mux_test.go:110 +0xc30
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:447 +0x133

Previous write by goroutine 12:
  runtime.slicecopy()
      /usr/local/go/src/runtime/slice.go:94 +0x0
  bytes.(*Buffer).Write()
      /usr/local/go/src/bytes/buffer.go:128 +0x12a
  log.(*Logger).Output()
      /usr/local/go/src/log/log.go:153 +0x692
  log.(*Logger).Printf()
      /usr/local/go/src/log/log.go:160 +0x92
  github.com/flynn/flynn/pkg/mux.func·002()
      github.com/flynn/flynn/pkg/mux/_test/_obj_test/mux.go:90 +0x220

Goroutine 10 (running) created at:
  testing.RunTests()
      /usr/local/go/src/testing/testing.go:555 +0xd4e
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:485 +0xe0
  main.main()
      github.com/flynn/flynn/pkg/mux/_test/_testmain.go:104 +0x381

Goroutine 12 (finished) created at:
  github.com/flynn/flynn/pkg/mux.(*Mux).Serve()
      github.com/flynn/flynn/pkg/mux/_test/_obj_test/mux.go:92 +0x627
==================
--- FAIL: TestMux_Listen_ErrAlreadyRegistered (0.00s)
	mux_test.go:119: unexpected recover: "header byte already registered: 0x05"
FAIL

Fixed data race in 3b1e81b. Happy Thanksgiving!

Squashed to fb64928. Merging...


Pytorch asks to flatten the paramters when I'm using higher for meta-learning a simple seq2seq LSTM model.

Hi dear authors,
Firstly, thanks for this great and easy-to-use tool.
I am trying to use the higher package for meta-learning a simple seq2seq model consists of two PyTorch vanilla LSTMs as the encoder and the decoder. During training, after two iterations I receive the following warning for an infinite number of times until I make to stop the experiment.
"/pytorch/aten/src/ATen/native/cudnn/RNN.cpp:1269: UserWarning: RNN module weights are not part of a single contiguous chunk of memory. This means they need to be compacted at every call, possibly greatly increasing memory usage. To compact weights again call flatten_parameters."_
As suggested in the warning I used flatten_paramters function at the start of the forward function of the encoder and the decoder. But nothing changed.
It is also worth to mention that the model is trained with no issue in a standard supervised learning setting.
Can you figure out what would be the reason?
Thanks in advance.

Hello. Can you please post a complete (and preferably minimal) code snippet that replicates this warning so we can investigate?

Thanks for the reply.
Here is a self-contained code snippet that reproduces the warning when running on GPU. The warning is produced for every forward pass to LSTM. I ran the code using Python 3.6 and both Pytorch 1.3 and 1.5 and received the same warning.
import torch
import higher
import torch.cuda
import torch.nn as nn
import torch.nn.functional as F

device = torch.device("cuda:0" if torch.cuda.is_available() else "cpu")

class Seq2Seq(nn.Module):
    def __init__(self,
        encoder_vocab_size=93,
        decoder_vocab_size=44,
        wordvec_dim=300,
        hidden_dim=256,
        rnn_num_layers=2,
        rnn_dropout=0,
        ):
        super(Seq2Seq, self).__init__()
        self.encoder_rnn = nn.LSTM(wordvec_dim, hidden_dim, rnn_num_layers, dropout=rnn_dropout, batch_first=True)

    def forward(self, x):
        embed = torch.zeros(15, 43, 300).to(device)
        out, _ = self.encoder_rnn(embed)
        return out

def main():
    net = Seq2Seq().to(device)
    xs = torch.randint(0, 100, (3, 43)).to(device)
    fmodel = higher.monkeypatch(net)
    output = fmodel(xs)

if __name__ == '__main__':
    main()

Thanks for the snippet. I not this doesn't yield warnings on CPU, just GPU, but I can reproduce this. I'll look into it.

This should be addressed by #67. Re-open if it doesn't address your problem.


Animation cache errors immediately after deleting node

Godot version
4.2 rc1
System information
Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; <IP_ADDRESS>3) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)
Issue description
When you delete a node referenced by some animation tracks, you will get an error about invalid node, even if that animation is not currently playing.
This was introduced recently, probably after AnimationMixer was added.
Steps to reproduce

Create AnimationPlayer
Create some tracks that refer to a node
In script, remove the node
Errors

Minimal reproduction project
cacherrors.zip

Hope people don't mind if I investigate this issue for a school project. I'll update this thread with progress.

Hello, I apologize if anything here is wrong, I'm new :)
Every time the cache is updated, it looks through all animations and all tracks, and finds each node associated with each track by calling get_node_and_resource. This process ends up returning two errors, one as the node cannot be found, and another by this block of code:
if (!child) {
	ERR_PRINT("AnimationMixer: '" + String(E) + "', couldn't resolve track:  '" + String(path) + "'.");
	continue;
}

I too believe that these errors are rather confusing and unnecessary. Here is my workaround:
Node *child = parent->get_node_or_null(path);

if (!child) {
	WARN_PRINT("AnimationMixer: '" + String(E) + "', couldn't resolve track:  '" + String(path) + "'.");
	continue;
}
parent->get_node_and_resource(path, resource, leftover_path);

where we check if the node exists first. I hope that calling get_node twice is not too inefficient. I've also changed it from an error to a warning, I'm tempted to delete the posted error entirely but I left it as this. Please feel free to give any comments, I am unsure what is a good way to deal with this.
Here's the corresponding PR: https://github.com/godotengine/godot/pull/85368. Let me know if there are any problems with this!

Does that error constantly show up in all frames? If it is only a problem for one frame after deletion, it sounds like a cache update issue, not an error issue as https://github.com/godotengine/godot/pull/85368.

The error does not show up in all frames, and I have no clue if it existed in the old animation tree. It gives an error every time the cache is reloaded, which for instance, occurs every time an animation is started in the mixer, where it prints an error for every single animation in the mixer that has an invalid node, even if those animations aren't currently being used.

Update: For me, the error occurs whenever i try to free the projectile from the animation player using a method call.

As for memory leaks, that's another issue. See also https://github.com/godotengine/godot/pull/85001.


F-Droid “error in opening zip file”

I added the repo for f-droid at
https://android.izzysoft.de/repo/apk/jp.juggler.subwaytooter. F-droid accepted the url, but gives an error when opening the zipped index file.
Perhaps due to missing signature?

IzzyOnDroid has copied the APK from release page of this GitHub, but I'm not related in it at all.
You should contact to IzzyOnDroid.

Found the problem. The url on your git hub page https://android.izzysoft.de/repo/apk/jp.juggler.subwaytooter doesn’t work.
Using instead the url from the LizzyOnDroid site https://apt.izzysoft.de/fdroid/repo?fingerprint=3BF0D6ABFEAE2F401707B6D966BE743BF0EEE49C2561B9BA39073711F628937A works fine.


Added support for Arabic language and right-to-left direction

I've made some changes to the chat application that add support for Arabic language and right-to-left direction. This makes the app more accessible to users who prefer to read and write in Arabic.
I've tested the changes and they work well. Please consider merging my changes into the main branch.
Thank you
https://tinypic.host/i/screenshot-20230405-214049-edge.zpRsY
https://tinypic.host/i/ar.zLLDj

Hi zizwar,
Thank you for your effort and work. However, I may not be able to merge this change until later as I am currently quite busy. Thank you for your understanding.

Hi @Zizwar， I think its time to add arabic language support, would you please resolve the conflicts? #2049

Hi Yidadaa, sure don’t problem, I’ll try to do it today
El El vie, 23 de jun. de 2023 a la(s) 7:26 a.m., Yifei Zhang <
@.***> escribió:

Hi @Zizwar https://github.com/Zizwar， I think its time to add arabic
language support, would you please resolve the conflicts? #2049
https://github.com/Yidadaa/ChatGPT-Next-Web/discussions/2049
—
Reply to this email directly, view it on GitHub
https://github.com/Yidadaa/ChatGPT-Next-Web/pull/493#issuecomment-1604211390,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOR5I2F3NIIONYWUA62DRTTXMWDQTANCNFSM6AAAAAAWTT4RAI
.
You are receiving this because you commented.Message ID:
@.***>

--
Daniel Gerardo Rondón García
System Engineer
(  <3024218105>+ <3024218105>57)<PHONE_NUMBER> <3024218105>
@.***
Cra 28 # 86A-67 - Bucaramanga, Santander, Colombia

hi @Yidadaa , I believe I need to revise the modifications to align with the new configurations added to the project. Additionally, we should consider the language orientation and design to be from right to left.

Hi @Zizwar , maybe we need to make a new pr?
Just provide a new translation, and add some css styles, hope this link helps you: https://medium.com/@krishnakiran1992/right-to-left-styling-for-web-apps-b4573d8979db
Some hints about this code base, now creating a new translation has been much easier than before, just follow this steps:

copy locales/en.ts to locales/ar.ts;
translate the file content;
import the ar.ts at: https://github.com/Yidadaa/ChatGPT-Next-Web/blob/c636993989cb48a76b36bdf7d208ce6d34fce717/app/locales/index.ts#L14;
add a new option at: https://github.com/Yidadaa/ChatGPT-Next-Web/blob/c636993989cb48a76b36bdf7d208ce6d34fce717/app/locales/index.ts#L34
add a new language option at: https://github.com/Yidadaa/ChatGPT-Next-Web/blob/c636993989cb48a76b36bdf7d208ce6d34fce717/app/locales/index.ts#L55

@Yidadaa , that's exactly what I've been thinking, i will rewrite the code from scratch based on the new modifications,. i find it easier than before.


running cat /dev/urandom crashes alacritty

As the title says, running cat /dev/urandom consistently crashes alacritty. Apparently some random escape codes send it into a state where this condition is triggered: https://github.com/jwilm/alacritty/blob/master/src/term/mod.rs#L634. Here is a log with backtrace: https://linx.li/aomx2zxa.ext
Great project btw, good luck! :)

Thanks for the report! At least the parser doesn't choke on it :).
There's a number of places where we don't coerce the cursor to be within the bounds of the grid. Doing so might fix this issue.

One more to add.  I couldn't find an open issue for this one:
thread 'pty reader' panicked at 'attempt to subtract with overflow', src/index.rs:168
stack backtrace:
   1:        0x102beae9a - std::sys::imp::backtrace::tracing::imp::write::h1461f67be4bf68a9
   2:        0x102bed23f - std::panicking::default_hook::{{closure}}::h6dba65b2b498d274
   3:        0x102becee7 - std::panicking::default_hook::ha8ecbcff1f59e805
   4:        0x102bed706 - std::panicking::rust_panic_with_hook::h5ceed7bd7aef311a
   5:        0x102bed554 - std::panicking::begin_panic::h091a980eb2ddd29a
   6:        0x102bed4c2 - std::panicking::begin_panic_fmt::h063a49cc71e3d103
   7:        0x102bed427 - rust_begin_unwind
   8:        0x102c155e0 - core::panicking::panic_fmt::h59374b8a88ef3536
   9:        0x102c154e4 - core::panicking::panic::he4f8d5c0f01c5414
  10:        0x10292a301 - <alacritty::index::Line as core::ops::Sub>::sub::hf56240524a3b3d20
  11:        0x102958974 - alacritty::term::Term::scroll_down_relative::h17832db7c7cd0212
  12:        0x102934b06 - <alacritty::term::Term as alacritty::ansi::Handler>::insert_blank_lines::hf4bfabc4710cd1ad
  13:        0x10294e116 - <alacritty::ansi::Performer<'a, H, W> as vte::Perform>::csi_dispatch::h4ad960a650a87e60
  14:        0x1028e6990 - vte::Parser::perform_action::hae92f4f3be45f35d
  15:        0x1028e6e96 - vte::Parser::perform_state_change::hcd974f7189d6307e
  16:        0x1028e7154 - vte::Parser::advance::hfbcbd9a431c54361
  17:        0x1029566dc - alacritty::ansi::Processor::advance::h8aa55517e89b95a8
  18:        0x102922fa1 - <alacritty::event_loop::EventLoop<Io>>::pty_read::he09815a6e7f0c6c5
  19:        0x1029226df - <alacritty::event_loop::EventLoop<Io>>::spawn::{{closure}}::hc8cce598d7c221bf
  20:        0x102952784 - <std::panic::AssertUnwindSafe<F> as core::ops::FnOnce<()>>::call_once::he8d9ee1af400fb51
  21:        0x1028e65df - std::panicking::try::do_call::ha1ffc19119230164
  22:        0x102bee5da - __rust_maybe_catch_panic
  23:        0x1028e5beb - std::panicking::try::h1d88e2383fd5222f
  24:        0x1028e3c54 - std::panic::catch_unwind::hb5a6f0073814bc71
  25:        0x1028e53ac - std::thread::Builder::spawn::{{closure}}::h0de6bfd35f37e74c
  26:        0x10291c869 - <F as alloc::boxed::FnBox<A>>::call_box::h7878f3467aa35fcc
  27:        0x102bec914 - std::sys::imp::thread::Thread::new::thread_start::haeb202749da670ee
  28:     0x7fff9f33caaa - _pthread_body
  29:     0x7fff9f33c9f6 - _pthread_start


[html5] FileReference.save not dispatching events

Describe the bug
According to the docs, FileReference.save should dispatch the events select, open, cancel and complete. However it never fires select, open and cancel. Further the event complete is fired at the wrong time, that is when the file dialog pops up and before the user presses the button Save.
Environment
macOS 12.6.3
haxe 4.2.5
openfl 9.2.1
chrome 110.0.5481.177
To Reproduce
Create an openfl project like this
class Main extends Sprite {
  final file = new FileReference();
  public function new () {
    super ();
    file.addEventListener(Event.CANCEL, e -> trace(e));
    file.addEventListener(Event.SELECT, e -> trace(e));
    file.addEventListener(Event.OPEN, e -> trace(e));
    file.addEventListener(Event.COMPLETE, e -> trace(e));
    this.stage.addEventListener(MouseEvent.CLICK, e -> {
      trace(e);
      file.save("hello world", "hello.txt");
    });
  }
}

The behavior of browsers has changed over time making this feature kind of unstable on HTML5 from browser to browser. It may not be possible to ensure that this behaves correctly across all browsers, although it should still match the documentation on other targets.
With that said, I'll look into it a bit more.

Thanks for your response, Chris.
Do you have any tips for at least a basic open/save functionality across the browsers?

Not in this case. Most browsers have removed the save dialogue by default and users have to adjust their settings for it to even work. Chrome now has an experimental File System API which doesn't exist on Safari or Mozilla. Unfortunately, we are constrained by what the browser allows as we don't actually implement very low level functionality. For the Native targets, we are far less constrained because we provide the implementations of almost everything. Another point of contention comes from the fact that every browser wants to handle things differently in many cases although we get lucky in the case of Edge because it adopts chromium as its browser engine.
I will see if there is anything that we can do regarding the events firing and some of the other issue(s) you mention in the previous issue report.


Review referenced document structure

Referencing artifacts in external documents seems to be structurally incompatible with the approach taken in SPDX.
Propose we review the 2 approaches (SBOM and SPDX) with concrete examples and determine if there are structural incompatibilities.  If incompatible, propose changes to SBOM, SPDX or both.

SPDX has an additional class of ExternalDocumentRef and properties to manage the relationship between documents in a secure manner.  SBOM takes a different approach which is structurally incompatible with the SPDX approach where the referenced item contains the package reference information.
Propose adding ExternalDocumentRef class.

Following the call on January 13, 2020,

here is the rationale behind the proposed modeling with the "referenceDocument" association from "ReferencedArtifact" class: this was following a graph-aware approach were main elements are nodes from a graph and are linked together; with this in mind, there was no need of a specific "ExternalDocumentRef" class.
I see two ways to align with SPDX: first one is to create such "ExternalDocumentRef" class, and change the "referenceDocument" attribute defition to be of type "ExternalDocumentRef" instead of "Document"; second one is to have an "AbstractDocument" class with two specializations, the current "Document" class and a new "ExternalDocumentRef" class, and change the "referenceDocument" attribute defition to be of type "AbstractDocument" instead of "Document" so that it can be another document (from the graph) or simply a reference to a document.

second one is to have an "AbstractDocument" class with two specializations, the current "Document" class and a new "ExternalDocumentRef" class, and change the "referenceDocument" attribute defition to be of type "AbstractDocument" instead of "Document" so that it can be another document (from the graph) or simply a reference to a document.

This approach seems very logical.  If the ExternalDocumentRef had the same required parameters as the current SPDX ExternalDocumentRef, I believe the concrete documents would be compatible.


WIP Add a steal_half method to sync::chase_lev

Questions:

We could change the signature to make callers supply a vec, rather than
allocate our own in steal_half. This could potentially be more efficient if
the caller is repeatedly retrying.
Is this safe? I think so, but I'm not 100% sure. The paper mentions that it
would be interesting to apply a steal-half operation to this deque, but they
didn't do it. I couldn't find any other papers or libraries that implemented
this operation either, although my google-fu may be weak in this regard. The
most important part, as far as I can tell, is populating the results array
before performing the CAS to ensure that we get the correct set of resulting
items (after the CAS, the circular buffer could circle back over the slots
we're stealing and overwrite them with new values). Everything seems to be
pretty much the same as stealing one item, which leads to my next question.
Should we factor out the common parts between steal and steal_half?
There's a ton of duplication here, as I've authored it.

If you think this is a valuable operation to have, then I can write some tests
and fix this up.

Maybe folks have tried this and it doesn't really give any better load balancing than stealing one item at a time does?

Maybe folks have tried this and it doesn't really give any better load balancing than stealing one item at a time does?

I can't find the paper, but steal_half performs far better in cases where jobs don't generate many children.

The most important part, as far as I can tell, is populating the results array
before performing the CAS to ensure that we get the correct set of resulting
items (after the CAS, the circular buffer could circle back over the slots
we're stealing and overwrite them with new values).

I "guess" this would kill the performance for some degree.  Maybe we can relax it by using two locations (just say bottom1 and bottom2) for the purposes of the present bottom variable: (1) signalling that the circular buffer is reclaimed and reusable, and (2) signalling that elements before bottom are already stolen by some threads.
The implementation seems correct to my eyes, for the same reason that that of steal is correct.  Though I am not 100% confident as I don't have a formal proof yet...

The implementation seems correct to my eyes, for the same reason that that of steal is correct. Though I am not 100% confident as I don't have a formal proof yet...

Have you seen Correct and Efficient Work-Stealing for Weak Memory Models? For someone who is familiar with this area of research (which I am definitely not, but I think you are ;)) I assume it probably shouldn't be too hard to extend the proofs for this case.
I really enjoyed the Promising paper, btw 👍

Have you seen Correct and Efficient Work-Stealing for Weak Memory Models?

Yes I've read it, but the proof is just beyond my level and I couldn't grasp it..  Yet I understand the key idea, which is what the authors called "cumulativity", that implies it is impossible that concurrent invocations of steal and pop see old values of bottom and top at the same time.  The exact same logic applies to steal_half AFAICT.
These days I am working on reproving (weak) Chase-Lev deque in a (hypothetical) program logic, and I will try to come up with a proof of steal_half.

I really enjoyed the Promising paper, btw 👍

I really thank you for reading the paper ;-)  As soon as the slide for POPL is done, I will share it.

Do we have any updates on this? I think Rayon might benefit from a steal_half method.
I did some googling, but couldn't find any papers about steal-half operation in Chase-Lev deques. Papers that do talk about steal-half usually have the following structure: they mention Chase-Lev as previous work, state that steal-half is a difficult operation to implement, and then present a totally new deque design that supports steal-half.
While papers never say that steal-half cannot be supported in Chase-Lev deques, the fact that apparently noone did it makes me think it's definitely non-trivial.
That said, we could still add a steal-half method to our Chase-Lev implementation that simply repeatedly calls steal(). Note that every call to steal() pins the current thread, so we could actually do steal-half by enclosing all those steals with a single call to pin(). That could be much faster than naively calling steal() multiple times in a row.

Please steal this PR from my work queue :)

@stjepang Would you please give me the references to the papers that says it's hard to support steal_half() in Chase-Lev?  Because still, @fitzgen's implementation looks correct to my eyes (albeit the comment I left).

@jeehoonkang
The Chase-Lev paper simply says at the end:
"It may be interesting to see how our techniques are applied to other schemes that improve on ABP-work stealing such as the locality-guided work-stealing of Acar, Blelloch and Blumofe [1] or the steal-half algorithm of Hendler and Shavit [6]."
There is also a paper from 2013 that mentions Chase-Lev:
"Several years later the nonblocking algorithm was extended by Chase and Lev to support dynamic resizing  [10]. Their first and, to our knowledge, only proof of correctness of a nonblocking work-stealing algorithm is not trivial: it spans over thirty pages [11]. Moreover, there is, in the literature, no nonblocking algorithm which combines resizeability with other extensions, such as steal half, possibly owing to the complexity involved in extending the proof of correctness."

@stjepang The paper @fitzgen mentioned is also published in PPoPP 2013, and this contains a proof of an implementation of Chase-Lev in C/C++11.  I am quite confident that the proof scales to steal_half.  Though I agree that this issue can only be answered decisively with a rigorous mathematical proof.  (The decades of research prove that "confident" means nothing in concurrency.)
AFAICT, Chase-Lev deque is difficult to formally reason about due to two reasons: (i) use of relaxed atomics, and (ii) use of SC fences.  I am interested in both difficulties, and these issues make Chase-Lev very interesting to me.  I will dig further into it..
For the time being, I prefer merging it (after fixing the bug I mentioned in the comment), but I agree not to do so if anyone objects to do that.

That's great then! :) No objections to merging from my side either.
Two things we should probably do that'd increase our confidence of correctness:

Reaching out to the authors of "Correct and Efficient Work-Stealing for Weak Memory Models" and asking about the steal-half operation.
Stress testing on a weakly ordered architecture.

Closing it for the same reason with #148


feat: don't run 'dht_nice_tick()' when kadmelia is disabled

@dignifiedquire the last commit moves the dht tick timer to its own select!() block that only runs when kadmelia is enabled. That changes a but the loop semantics when kadmelia is enabled but I think that's fine.

This should work: https://github.com/tokio-rs/tokio/issues/2583#issuecomment-638212772

This should work: tokio-rs/tokio#2583 (comment)

so which commit do you prefer?

no strong preference, but the OptionFuture looks a little cleaner I think

no strong preference, but the OptionFuture looks a little cleaner I think

ok. I'm taking a look, but the loop and the fact that we don't deal with a single future but with tick() creating a new one for each call makes that not so straightforward.


FileLocator->getNamespaces with parameter

I'm working on an updated MigrationRunner that uses FileLocator to support external PSR4 sources. The getNamespaces($prefix) method flattens the return from $autoloader->getNamespace($prefix) to a single path, when it is actually an array of paths thus potentially causing getNamespaces() to fail to search some valid paths. AFAIK this method is only used by locateFile() so is probably safe to rewrite, but seeking advice first.

I see 4 uses of it, but all of them are functions within the FileLocator class so you should be fine to modify that as long as all of those other methods don't break:

findQualifiedNameFromPath
listFiles
locateFiles
search

@MGatner, any update on this?

I haven't looked into it at all

Looked at this some more, definitely a potential issue. Some packages (like "phpDocumentor\Reflection") define multiple paths for one namespace:
["phpDocumentor\Reflection"]=>
  array(3) {
    [0]=>
    string(84) "/var/www/vhosts/.../vendor/composer/../phpdocumentor/reflection-common/src"
    [1]=>
    string(86) "/var/www/vhosts/.../vendor/composer/../phpdocumentor/reflection-docblock/src"
    [2]=>
    string(80) "/var/www/vhosts/.../vendor/composer/../phpdocumentor/type-resolver/src"
  }

Using $locator->locateFile() will only search the first of these ('reflection-common') and thus fail to match any files in the other paths.

Also, namespaces aren't required to start with a capital ("phpDocumentor" above is a good example again) so this will fail to match sometimes:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/system/Autoloader/FileLocator.php#L118

Close by #2059


the example of detecting car is very slow under cuda. how can I do?

I was runnin the dnn_mmod_train_find_cars_ex2.cpp examples with Visual Studio 2015 On windows platform。I'm sure using DLIB_USE_CUDA but it's is still slow - the average time used was 960 milliseconds one frame, which instructions can I learn from？ Can you give me any more suggestion?

Don't post the same question to multiple issues.


Optimistic UI implementation

[ ] Add in new layouts from https://github.com/cosmos/voyager/issues/1092

Please add the discuss label to all new issues.

Can this be moved to staking2?

though i want to say yes, for the sake of "progress", i really think this is less to do with staking and more to do with the whole voyager ux. the principles discussed in #1092 apply to all the features and will elevate the ux for all areas of the app.
so no. i don't think so. but we can make it high priority and remove the staking label 😄

this problem? https://github.com/cosmos/voyager/issues/1092#issuecomment-418142498

Yes. I was talking about a technical proposal of how to have a proper process in code (not on the design level).

Love the idea, I tackled a similar problem years ago I will write down the solution we found and we can discuss it how to adapt/change/discard that :)

The GUID part I really think is not relevant for this project, as we have a fixed structure and the user cannot modify how the UI looks like by adding or removing tabs, components etc.., We can probably just reference portions of our state

Real state

User see everything in his natural color and opacity

Unconfirmed state / transactions

Blocks are what I expect on certain part of my state to happen if my transaction succeed
There are two possible blocks: newItems and deltas
Every part of the state can be logically composed by blocks and Referenced by (GUID or similar) generic IDS not referring to any particular area, just generic IDS, the block describe where he will will have an impact
at rendering time we show the Real state, for every component we know a GUID is present, so we simply check in our dictionary of the unconfirmed states / transactions if this component has a WIP, we choose to show the unconfirmed block (or the delta when needed)

example: I made a transaction, I will add 2 unconfirmend blocks:

The new transaction that still does not exists on my transactions list (corner case) we should show them on top?
The new Balance as Delta []
I do another transaction:

Everything that has a WIP must have an icon or a diffent grey-ish color to clearly differentiate from a final state or transaction (if I have a list of 3 items and only one is work in progress, it must be clear and easily identifiable the difference between the two)
once the transaction is confirmed, if the user is actively watching a component that change state, we need a smooth transition, if he's not watching we can choose do just change or show notifications depending on the criticality of the block we want to change

we can do in simpler way:

not everything needs to have this unfconfirmed state
isolated states

Alternative approach:

Just update the state as if succeeded
then query for the next block


chore: release 0.131.0

:robot: I have created a release *beep* *boop*
0.131.0
google/cloud-asset 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-automl 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Features

extend GetModelEvaluation timeout (#2850) (51c7b37)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-bigquery 1.15.1
Miscellaneous Chores

promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-bigquerydatatransfer 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Features

add first party oauth authorization type (#2827) (7d59381)
add formatting methods (#2805) (c844cb0)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-bigtable 1.3.1
Documentation

update generated proto documentation (#2851) (31e9e62)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-billing 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-common-protos 0.2.1
Miscellaneous Chores

promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-container 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-core 1.36.1
Miscellaneous Chores

promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-dataproc 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Features

add formatting methods (#2828) (bc77651)
introduces the ability to submit a job to a cluster (#2852) (4bb1c55)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-datastore 1.11.2
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-debugger 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-dialogflow 0.14.1
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-dlp 0.26.1
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
move dlp back to beta due to upstream issues (#2848) (aa71bf3)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-error-reporting 0.16.2
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-firestore 1.12.1
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-iot 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)
update synth script to include iot client (#2821) (4082f95)

Documentation

fix copyright year (#2831) (b6b1b47)

google/cloud-kms 1.9.3
Miscellaneous Chores

enable context-aware commits for one API (#2786) (3178283)
Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-language 0.22.2
Documentation

update generated proto documentation (#2854) (b52886e)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-logging 1.20.0
Features

add new entry options (#2823) (16cf794)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)
replace deprecated constant reference (#2822) (029f2c3)

google/cloud-monitoring 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Features

extend ListTimeSeries timeout and update documentation (#2855) (bacf94f)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-oslogin 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

⚠ BREAKING CHANGES

remove readonly service scopes (#2856)

Features

remove readonly service scopes (#2856) (09ce6f5)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)
remove experimental flag (#2817) (f4ebd71)
update metadata (#2844) (0446917)

google/cloud-pubsub 1.23.0
Features

add formatting method (#2833) (92c536f)
add new snapshot methods (#2857) (016a217)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-recommendations-ai 0.1.0
Features

add recommendation engine client (#2799) (cad00b3)

google/cloud-recommender 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-redis 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-scheduler 1.3.0
⚠ BREAKING CHANGES

remove projectName helper from experimental V1beta1 client and update timeouts (#2858)

Features

remove projectName helper from experimental V1beta1 client and update timeouts (#2858) (d7bf9de)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-secret-manager 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

Documentation

update documentation (#2818) (e7cbdd7)

google/cloud-security-center 0.6.0
Features

add formatting methods (#2834) (0f4399e)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-service-directory 0.1.1
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-spanner 1.27.1
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-speech 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-storage 1.20.1
Miscellaneous Chores

promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-talent 0.11.0
Features

add formatting methods (#2835) (9a7298f)

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)
update docs to use new helper (#2859) (8943d9a)

google/cloud-tasks 1.6.1
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-text-to-speech 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-trace 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-translate 1.7.2
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-videointelligence 1.9.1
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-vision 1.0.0
General Availability Notice

We are happy to announce this component is now generally available. As such, it will not introduce backwards-incompatible changes in any minor or patch releases.

Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

google/cloud-web-risk 0.4.2
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)
update metadata (#2860) (0418dc8)

google/cloud-web-security-scanner 0.4.2
Miscellaneous Chores

Migrate all synth.py scripts from artman to bazel (#2845) (9cec90c)
promote libraries and add repo-metadata (#2812) (2738e4b)

This PR was generated with Release Please.

Release is at https://github.com/googleapis/google-cloud-php/releases/tag/v0.131.0


Newarmorstand

Adds a api for spawning armorstands models from a file. These files are generated using mrgarettos armorstan model generator.

test


Fix AI Lab extension test to accommodate for podman-desktop main and ai-lab nightly changes

Currently AI Lab smoke test fails.

done


Add signal_handler to env or so?

I've been looking a little bit at #918 and #1308 which is about us leaving child processes behind when we exit.
We should probably have something in RTS / process module to terminate child processes, but I think what we really want is the ability for the acton application developer to handle this. It seems to me that it should be possible to install a signal handler callback which is called when we receive a signal. From there it's up to the developer if they want to stop sub-processes or not. This gives the app dev more control over how to shut down the program.
For example, with a generic termination handler in RTS, the application can't read in any sort of exit information once we ask it to terminate. Similarly, we have to have a generic mechanism to do like first SIGTERM and after a few tries / some time do SIGKILL.
@nordlander you usually have very particular ideas about the actor model. Should we have a env.handle_signal(signal, callback)?

In the meeting today we agreed this is overall a good thing. We discussed having a more generic / abstracted view, like installing a handler for an on_exit event versus more concrete low level things like SIGTERM signals which aren't portable. While we have definite agreement on an on_exit callback, there's probably more to say on specific signal handlers.
They are not mutually exclusive, quite the contrary, so we don't have to hold back implementation here, we can move forwarding on an on_exit handler and leave more specific low level signal handling to the future.

Signal handlers can only be installed in the main thread, so this does have certain consequences, like we don't run Env or any actor on the main thread currently, it just does some auxiliary work like keeping track of timers.
I suppose we have to turn thread 0 into a worker thread too! But maybe it should just service Env and maybe some other special actors.
Then we should probably do most signal handling from Env, not from rts.c like today.


Bad Json Handling

JsonStringToMap completely omits bad json strings by default.
A set of 20 Json records with 1 badly formated json will return 19 records.
Should return 20 records with the unparsable json record as null.

Work around use split.


Revert "[KAFKA-14324] Upgrade RocksDB to 7.1.2 (#12809)"

This reverts commit 876c338a60f2d923568ff282ff499a14a9ab83f1.
The new version of RocksDB is leaking memory, to the point that with this change, a stream thread will only survive a few hours without running out of memory.

\cc @ableegoldman

I understand that this is a fairly urgent change and that we should revert the commit if there is a memory leak, but I am interested in how was this discovered in case I start looking at other RocksDB versions to move to? For example, are there any accessible long-running tests somewhere which unearthed this?

This was discovered using a long-running Streams test, but the tests are run on confluent infrastructure and are not publicly accessible. I would think the memory leak can be reproduced with every other long-running job and if not, this could also help us to identify the root cause of the problem.

There is something fishy in the build failures. There many Streams failures and I saw the following:
java.lang.IllegalArgumentException: Cannot get result for failed query. Failure is STORE_EXCEPTION: class org.apache.kafka.streams.state.internals.RocksDBStore failed to handle query org.apache.kafka.streams.query.RangeQuery@38c5b853:
org.apache.kafka.streams.errors.InvalidStateStoreException: Store store is currently closed
	at org.apache.kafka.streams.state.internals.RocksDBStore.validateStoreOpen(RocksDBStore.java:300)
	at org.apache.kafka.streams.state.internals.RocksDBStore.all(RocksDBStore.java:443)
	at org.apache.kafka.streams.state.internals.RocksDBStore.all(RocksDBStore.java:434)
	at org.apache.kafka.streams.state.internals.StoreQueryUtils.runRangeQuery(StoreQueryUtils.java:192)

@lucasbru @clolov Could you also have a look at the build failures?

@cadonna Could you retrigger this? It is just one configuration (JDK 8 and Scala 2.12) that has lots of tests timing out, so that looks more like a node issue to me.

Tests look fine, now.
However, in the meantime I have found the cause of the leak (or at least one) in trunk. We could consider waiting for this fix to go in and not revert this.


vagrant-completion 1.8.4

Thank you for your contribution to Homebrew, @dafyddj; we appreciate it! 🎉


Proper bounds checking for floats

Tracking that the current bounds checking in the Valtype.validate_arg API does not properly check the bounds of floats.

Done in https://github.com/ethereum/py-wasm/pull/83


[RFC] provide an option to disable auto reloading current tab and "Context Invalidated, Press to Reload" popup

How do you envision this feature/change to look/work like?
provide an option to disable auto reloading current tab and "Context Invalidated, Press to Reload" popup
What is the purpose of this change/feature? Why?
I've configured my extension to unload old content scripts and inject the fresh one on the chrome extension update event so I don't need plasma to auto reload the page and show that "Context Invalidated, Press to Reload" popup.
(OPTIONAL) Example implementations
No response
(OPTIONAL) Contact Details
No response
Verify canary release

[X] I verified that the issue exists in plasmo canary release

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

This needs to be handled ASAp. It is rather obnoxious to see this popup in every open tab in my browser, and should not exist.

@mjjply42 FYI, if you inject your CS to certain page only, it won't show up in other tab. It's not a "feature," it's an indicator that your CS has changed. Would you rather not knowing that info, or would you like the CS to be refreshed immediately?

Ref #162

@mjjply42 FYI, if you inject your CS to certain page only, it won't show up in other tab. It's not a "feature," it's an indicator that your CS has changed and that tab need to reload to get that change. Would you rather not knowing that info, or would you like the CS to be refreshed immediately?

I don't even have a content script active 😂

Wait wat? That's a bug - what feature are you using atm?
Also, by "don't have a content script active," you mean your extension do have a cs, but it wasn't active at the time?

Wait wat? That's a bug - what feature are you using atm?
Also, by "don't have a content script active," you mean your extension do have a cs, but it wasn't active at the time?

There is a file, but it is empty and not being used anywhere in the application. So there haven't been any granted Permissions anywhere. On top of that, the app has been rebuilt 50+ times already, since that content script was even put into use

@mjjply42 any CS file matched by glob ~src/content* will be injected with a default permission pointing at <all_urls>. I'd suggest remove that file and re-add it when you need it a CS or CSUI.

@mjjply42 any CS file matched by the glob ~src/content* will be injected with a default permission pointing at <all_urls>. I'd suggest remove that file and re-add it when you need a CS or CSUI.

Gotcha. Will there be any empty file checks in the future? I feel that there should be one. That, and the extension is sent to browser stores already built, so there is no downside of having an slightly extended build time locally

Will there be any empty file checks in the future? I feel that there should be one

Good idea, will incorporate that.

That, and the extension is sent to browser stores already built, so there is no downside of having an slightly extended build time locally

A bit hard to grok this sentence, can you elaborate a bit?

Will there be any empty file checks in the future? I feel that there should be one

Good idea, will incorporate that.

That, and the extension is sent to browser stores already built, so there is no downside of having an slightly extended build time locally

A bit hard to grok this sentence, can you elaborate a bit?

No worries. You cna ignore that last part

Thank you for the help and the update!


language prefix and matchPath doesn't work togather?

hey, first of all i'd like to mention that I'm not using graphql at all in my project.
I'm creating my pages with createPages (in gatsby-node.js), everything works just fine beside the page that needs extra prop from the slug,
here how i create it
createPages({
    path: '/item',
    matchPath: '/item/:itemId',
    component: path.resolve('./src/pages/ShowItem.js'),
    context: {},
});

it works only for the default language, for other languages like es for example
http://localhost:8000/es/item/some-item-id
it would lead to page NOT FOUND, I tried so many things like
matchPath: '/:lang?/item/:itemId', - this way it will redirect to the same path with extra language prefix (in addition to the existing one), I tried using pages in the option with this matchPath but it didn't change anything.
I tried even, turning off the redirect option then the default  language shows
Gatsby.js development 404 page but the rest works ...
not sure what i'm missing here but i can't figure it out, thanks!

Facing same issue :disappointed:

Related to #69


Death to v2 folders dashboards

Some v2 folders are benign, and just pose extra nesting, others come with legacy non v2 versions, of very very old code.

yaas!


C-CV-TMLE

Deprioritized

I can't find any literature talking about such a combined estimator. Might not be a thing. Probably cancel soon.


Feat(CIV-537): Removed unverified tag from consultation feedback report

What?
Removed unverified tag from consultation feedback report.
Why?
The final Consultation Feedback report is referred to by government officials. The tag 'unverified' against the responses appears confusing for the recipient of the report.

From the ticket description:

Hence we propose to do away with this tag completely only in the Feedback Report.

The treatment of unverified responses, continues to remain the same as earlier, for the Summary page and the export of responses.

@Skt2021 Bro please add testing info under the Testing section in the PR description. Currently, I'm not sure if these conditions are being fulfilled

Sure


Show hidden files

Since the hidden directory is not displayed, it is displayed.
This change excludes only the .git directory.

@nabezokodaikon
We can customize the args for rg by sourceParams with edbb0d9.
Please try it.

Thank you!


KAFKA-12249: KIP-500 - Add client-side Decommission Broker RPC

Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation (including upgrade notes)

Not also the test failure RequestConvertToJsonTest.testAllResponseTypesHandled.

Not also the test failure RequestConvertToJsonTest.testAllResponseTypesHandled.

Restarted the build, it timed out for some reason.

Two flaky tests:

JDK 8 / org.apache.kafka.common.metrics.MetricsTest.testPercentilesWithRandomNumbersAndLinearBucketing()
JDK 8 / org.apache.kafka.connect.integration.BlockingConnectorTest.testBlockInConnectorValidate


Unable to exclude users from suggested reviewers list

Describe the bug
I defined under the config.user_mapping at .cm/gitstream.cm mapping for some of the users who are no longer defined as contributors for the repository with a value of null (as suggested here).
Unfortunately, the gitstream-cm bot still lists those users in the suggested reviewers list as part of the PR comment.
To Reproduce
Steps to reproduce the behavior:

Add the following section to the .cm/gitstream.cm in the default branch (on top the initial file provided as part of the instructions here):config:
  user_mapping:
    - 'Invalid User<EMAIL_ADDRESS>'InvalidUser'
    - 'InvalidUser<EMAIL_ADDRESS>'InvalidUser'
    - 'InvalidUser': null
    - 'Invalid User2<EMAIL_ADDRESS>'InvalidUser2'
    - 'InvalidUser2': null

Open a PR for a new feature branch which includes at least one file modified by one of the users (or more) mentioned in step 1 above.
Required job gitstream-cm is executed for the PR successfully.

Expected behavior
Required job gitstream-cm is executed successfully and a comment is added to the PR with suggested reviewers that do NOT include the invalid users mapped to null value above.
** Actual behavior **
Required job gitstream-cm is executed successfully and a comment is added to the PR with the following content:
 👋  **Suggested reviewers: ValidUser2**

They contributed more than 25% of the lines on pre-existing files:

`path/to/file1`
ValidUser1: 44%
ValidUser3: 18%
ValidUser2: 12%
ValidUser4: 11%
ValidUser5: 3%
ValidUser6: 3%
ValidUser7: 2%
ValidUser8: 1%
ValidUser9: 1%
ValidUser10: 0%

`path/to/file2`
ValidUser2: 45%
ValidUser1: 15%
ValidUser3: 10%
ValidUser4: 7%
ValidUser5: 7%
ValidUser6: 4%
InvalidUser: 3%
ValidUser7: 2%
InvalidUser2: 0%
ValidUser8: 0%
ValidUser9: 0%
ValidUser10: 0%
ValidUser11: 0%

To learn more about /:\ gitStream - [Visit our Docs](https://docs.gitstream.cm/)

InvalidUser and InvalidUser2 are listed as part of the contributors to path/to/file2 (we expect them to be filtered out).
Additional context
The repository on which gitstream was enabled is a private repository (so, the real data had to be redacted).
In addition, I tried to change the order of the entries in config.user_mapping, but, unfortunately, I still got the same results.

@yakirm-cr this is by design, the idea was that when using rankByGitBlame  to assign reviewers automatically with add-reviewers@v1 then mapping users to null is a way to prevent the automatic mapping in certain cases, like in your example contributors that are not longer part of the team.
- action: add-reviewers@v1
  args:
    reviewers: {{ repo | rankByGitBlame(gt=25) }}  <--- this will drop `null` users

On the other hand, when using explainRankByGitBlame with add-comment@v1 it still shows these users details in the PR comment suggestion as this info might be valuable by itself.
tl;dr the comment will not suggest null users but will show them in the details.

@vim-zz Thanks for the clarification!
I suggest to add it to the documentation (I suspect other may face the same and raise it again).

Added - thank you for the feedback!


✨ Current Line Highlight

Current line needs to be highlighted and current line number is primary text color.

Keep


fix LruCache accessOrder set false

#517 针对缓存命名与行为不一致的修复，目前实现为LRU方式

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

this problem has been fixed, thanks you!


which processor can be used by "control_v11p_sd15_softedge“

Refer to https://github.com/Fannovel16/comfyui_controlnet_aux?tab=readme-ov-file#nodes-sections-are-categories-in-comfy-menu for other preprocessors


allow include paths to be specified as arguments

Summary:
Add include path argument for calls to stanc to compile models.
Description:
There is an argument to stan::lang::compile that provides include paths as a std::vector<std::string>.
There should be a way to add include paths from the command line to pass to this function.
Because it has to be passed to the makefile at model compile time, how about an environment variable STAN_INCLUDE_PATH that includes a comma-separated lists of absolute or relative paths.
"foo/bar baz/bing",abc,/usr/stan/,""

The relative paths will have to be interpreted relative to where stanc is installed because that's where it will be run from.
Current Version:
v2.18.0

Currently, make handles the building of the .hpp file and the executable in
one go.
What would be ideal? What you’ve described isnt enough info: it’s an
argument that would need to be provided at compile time.
I can see two ways of handling it:

Add a make variable that a user can specify on build. Something that
looks like include_paths. The call would be something like: make
test/bernoulli  include_paths=“foo, bar, baz/bing”. We could even add the
path of the file and . to the include path by default. And users would be
able to add that variable within their make/local.

Create instructions for compiling the Stan program (going from Stan to
C++). This would be much clearer as to what’s happening in the build
process, but introduces one additional step in the build process.

Both will need the bin/stanc executable to accept a new argument. I’m happy
with include_paths as the name.
Thoughts?
On Fri, Jul 20, 2018 at 7:39 AM Bob Carpenter<EMAIL_ADDRESS>wrote:

Summary:
Add include path argument.
Description:
There is an argument to stan::lang::compile that provides include paths
as a std::vectorstd::string. There should be a way to add include paths
from the command line to pass to this function.
I propose we use
include_paths = "foo, bar, baz/bing"
If we can have spaces around = and the same thing with no spaces if not.
Current Version:
v2.18.0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/cmdstan/issues/633, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZ_FzFW1KeZkRSqa9fu-w2LcmGn3XRPks5uIcFUgaJpZM4VX5Sl
.

I forgot that it would have to be before model compile time!  I modified the issue to propose the environment variable approach (suggestion 1).
I do think we should include "." by default as it's basically assumed in the current implementation that the path can be relative to the location of the CmdStan install.
If that's still not clear enough, we can keep refining.
I sugggest STAN_INCLUDE_PATHS as a "namespace" hack---at least that's what we did for MPI.

The directory containing the Stan file being compiled (which generally won't be the location of the CmdStan install) should also probably be included in the default search path.

Here's a possible addition to stanc_helper that adds additional include paths from a command-line option --include_paths. Following the respective conventions for the PATH environment variable on Windows and Unix, the separator of include paths is ";" on Windows and ":" otherwise. So far, it seems to work.
// This is added near the top of stanc_helper.hpp.
#include <boost/algorithm/string/split.hpp>

// This is added just after "" is appended to include_paths in the stanc_helper function.
    if (cmd.has_key("include_paths")) {
#ifdef _WIN32
      std::string inc_path_sep = ";";
#else
      std::string inc_path_sep =  ":";
#endif

      std::string extra_path_str;
      cmd.val("include_paths", extra_path_str);

      std::vector<std::string> extra_path_vec;
      boost::algorithm::split(extra_path_vec,
                              extra_path_str,
                              boost::algorithm::is_any_of(inc_path_sep));

      include_paths.insert(include_paths.end(),
                           extra_path_vec.begin(),
                           extra_path_vec.end());
    }

@syclik - how exactly do include paths get specified using current makefiles?

I don’t understand. What paths? Trying to read your mind: source include
paths or linker paths or path of the target or...?
On Thu, Jul 18, 2019 at 3:59 PM Mitzi Morris<EMAIL_ADDRESS>wrote:

@syclik https://github.com/syclik - how exactly do include paths get
specified using current makefiles?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/cmdstan/issues/633?email_source=notifications&email_token=AADH6F2ARMDXEA6DJA5KO43QADDQRA5CNFSM4FK7SSS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2JTR5Y#issuecomment-512964855,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADH6F5KK4J5SDC4JSCXZKLQADDQRANCNFSM4FK7SSSQ
.

I'm talking about how to compile Stan programs which use the Stan language include directive where the included files reside in another directory - how does
make foo/bar/stan_program_with_includes parse out the names of those included directories?
this feature was actually added to CmdStanPy - https://github.com/stan-dev/cmdstanpy/pull/44
I'm just confused looking through the makefiles to see how this works.

if the makefiles are working such that Stan programs can includes files from another directory, then we need to add info to the docs.

I still don't exactly know what you're looking for... maybe a little more help?
There's some doc in the CmdStan documentation and in the makefile.
https://github.com/stan-dev/cmdstan/blob/develop/makefile#L78
https://github.com/stan-dev/cmdstan/blob/develop/src/docs/cmdstan-guide/stanc.tex#L118
Does that help?

yes, that's helpful.   I'm not sure this feature will work as advertised -  do we have makefile tests for this use case?

Fixed in https://github.com/stan-dev/stan/pull/2635


Option to skip header

@bartoszgolebiowski would it be possible to support an option to skip reading the header?
my current use-case is reading a file stream line by line and wanting to parse each line individually.

that said, maybe what I'm really asking for is the ability to parse a file stream... but perhaps that is outside of the scope for what you intend this project to do?

@nerdstep
Streaming is an amazing missing feature for sure, but I am not sure how to do it for both node and browser. This is an interesting implementation of how to split CSV files. I think I would do something similar here.

Maybe to resolve this issue we should consider adding a new method to check if row is valid against schema.
What do you think, is it sufficient for you @nerdstep

@bartoszgolebiowski -- I think streaming can be achieved in both node and browser, since the browser also supports a Streams API. The Papa Parse library does this too.
That said, if you wanted to keep this library small and avoid those implementation details, then a row validation method would make sense.

https://github.com/bartoszgolebiowski/zod-csv/pull/2
This is a draft, I am open to naming, typing, and other suggestions!

I introduced a new method: https://github.com/bartoszgolebiowski/zod-csv/blob/main/src/csv.ts#L173
Here is some basic usage: https://github.com/bartoszgolebiowski/zod-csv/blob/main/src/csv.test.ts#L390

nice work and thanks for the quick turnaround!


Adding dojot.module to Auth

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR updates auth to use dojot.module library

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?
The library is used. This leads to less code for auth, which means less bugs.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Is there any issue related to this PR in other repository? (such as dojot/dojot)
This is child of dojot/dojot#793

Other information:

Hey, anyone?


Replace all gate_gradients=1 with gate_gradients=GATE_OP in documenta…

Replace all "gate_gradients=1" in documentation with "gate_gradients=GATE_OP" to make
it very clear that GATE_OP is the default value. This matches what exists in the source code as well.

Can one of the admins verify this patch?

I signed it!

Is there something that I need to do to run the required checks above, or will they eventually run automatically?

@slacy I'm not sure there is a way to preserve "GATE_OP" when auto-generating the docs. Assigning @xmbrst for advice.

All the docs changed in the 1.0 release -- going to close this -- it's possible this got fixed with the new doc generators.  In any case, editing the .md files wouldn't be the right thing to do anyway :(


find() returns nothing

Using the find method I am looking for an element, but whenever I alway get an empty object, even though the elements exists.
$dom->find("html"));
The statement above returns

you will need to provide a sample of the html and then we can help you.
I'll close off this ticket and we can re-open it.
Thank you.


Bug #348: Safelist entries get removed

Closes #348
Description

The tokenBalances list updated to localStorage by the function activateTokensByBalance where in wrong format [balance] instead of [tokenAddress, balance]. When the app loads the info from the localStorage, an exception was thrown trying to load the balances and the safe was just removed from the available lists.

One question: was this the case for new safes or old ones?

What do you mean by old/new safes?. I just removed all the application data and load all the safes again in order to reproduce the error, if that is what you are asking

So there was a change in safe model which resulted to this error (if I understand correctly), this is why some of the safes were loading correctly. If this is the case, that makes old safes stored in localStorage incompatible. In this case, we can either write a function which would get the old safes and normalize them for the new version (if possible) or change the prefix used for storing the data (https://github.com/gnosis/safe-react/blob/master/src/utils/storage/index.js#L11) to drop support for old stored safes

You're right, that makes total sense, I suggest updating the prefix to V2 or something like that

Assuming we didn't launch publicly yet, I'd agree on updating the prefix and dropping support for old safes.
cc @lukasschor

Travis automatic deployment:
https://pr358--safereact.review.gnosisdev.com


Magic number 66

I was testing adding tones and lengths as features and discovered that there is a hard coded check for '66' features, the number appears to be hard coded without explanation in multiple locations.
Would it be safe to assume that any '66' is for the feature count checking only?

Correct, there are 42 features in our own lookup and then 24 more that we get from a resource called Panphon, which also encodes phonemes as vectors. For some symbols, this other resource behaved strangely, so I added those checks to figure out why the panphon vectors sometimes have different numbers of dimensions. When I rework the featurevectors for tone and lenthening, I'm probably going to remove the panphon vectors completely for simplicity.

I've started using constants for these, and pass this constant to the models for the matching dim statement.
Is that correct?

You mean the number of dimensions in a featurevector is constant? If so then yes. If you use different featurevectors with a different amount of dimensions, then you can just replace all those with the new expected amount of dimensions.

I'm wanting to at some point test converting the transcript text directly to byte values, would simply setting the feature entries up as {"symbol_type", "byte", "b0": 0/1, "b1": 0/1, ...} as a direct conversion from bytes work?

I don't se a reason why it wouldn't work, although I think there could be an easier way by not using the articulatory vector pipeline at all and converting the sequence of  bytes directly to a sequence of  LongTensors.


Support for calculatedExpressions in boolean items

Forwarded from a conversation with Heath in Teams:
I have noticed that the Type 2 Diabetes mellitus flag in the Absolute cardiovascular disease risk calculation section of the Aboriginal and Torres Strait Islander Health Check does not calculate to Yes when Type 2 Diabetes mellitus is added to the medical history.

I think we need to consider supporting boolean in calculations to support this scenario.
I am also thinking that we should support coding as well in case we want to record this kind of derived rules as codes rather than a simple boolean.

@nielmdrec
Just got this implemented. Sorry it took that long, I was busy with another project.
As of now, the only choice components supported are radio and dropdown. Autocomplete and checkbox requires a different approach so I plan to do some refactoring first beforehand.
Updated Conformance.md for alignment.
Below is a questionnaire to test it out.
Cheers
Sean

Also highlighting a bug I found:
When the whole field is cleared, the calculatedExpression listener does not recognise a change. Will release a fix soon.


Some RenderFeatures don't have correct polygon structure

Describe the bug
Polygon and multiPolygon geometries of renderFeatures or features produced using toFeature(renderFeature) do not always have the outer ring as the first array of coordinates
To Reproduce
Steps to reproduce the behavior:

renderFeatures = layer.getFeaturesInExtent(extent)

renderFeatures.forEach((renderFeature) => {
     var feature = toFeature(renderFeature);
     var geometry =   feature.getGeometry();
     var outerRing = geometry.getLinearRing(0);
}

outerRing sometimes is the outer ring, sometimes is just some random ring in the polygon and the actual outer ring can be anywhere in the geometry array. Same goes with multipolygons. Creating a custom function to generate a multidimensional array based on flat coordinates of renderFeature and ends produces the same error.

Expected behavior
getLinearRing(0) on a polygon geometry should return the outer ring

Some additional info: this is a polygon vector layer, source is PMtiles created using Tippecanoe. Rendering of the layer is correct, but rendering of some of the detected renderFeatures converted to features is incorrect -- usually outer ring is missing holes. Most re rendered renderFeatures are ok. The whole purpose of this is some custom rendering code.

I'm wondering if this is a bug in Tippecanoe. Does the original geometry thrown at Tippecanoe also have incorrect ring order?
If such geometries are valid, it means we need to make the toFeature() and toGeometry() functions detect the winding order of each ring, and in the output feature put the (hopefully only) counterclockwise ring first. So only rely on the right-hand rule instead of the ring order.
Maybe ol/format/MVT is also affected - can you please try if OpenLayers renders the data correctly when the VectorTile layer's MVT format is constructed with {featureClass: Feature}?

Geometry checks ok in QGIS. I have tried putting the geojson through geojson-rewind without effect.  Here is a geojson with one of the problematic features. I don't know how to produce MVTs, can you/someone do that MVT test?