Unexpected DOM Updates When Wrapping Checkbox in a Vue Component

Vue version
v3.4.38
Link to minimal reproduction
https://play.vuejs.org/#eNp9VE1v2zAM/SuCL3EBz8G6nbIkxVYE2IZlLbpiO8w7ODGTqZMlQR9phiD/vZQU2WoS5GBAIh+pR/KZu+yjlOXGQjbKxnqpqDREg7FyWnHaSqEM2REFK7InKyVaMkDooHPd/oXlv4XYHnzlMBpcRoQtBdeGLJ0Rmrdk4jLlq5ppuDpyXh85x8NABmngxUArWW0Ab4SMKZfWkM2bVjTAJlUW81cZMf8lRAvSQMtoUzPrbJY3sKIcGjQOQ6KO/kmu6wNoPEyezorMaGS9ouvySQuOLdu5PBglWkkZqDtpKFZVZSPiPc5XMyaev3qbURaKaPcvnbE/aaQ9wsO9Ag1qA1XW+Uyt1mCCe/bjO2zx3DmxBMsQfcH5AFow6zgG2CdsCtJOcJ7tFz9dytePerY1wHUsyhF1yL3HVxlO+fZC6T3dd+V7H1fxPXYxVcmx7gir+RoHYTBVqkHB58JyA80rJX5IEG4IFgHFiV4RFeUmlZAatRa0cO9u+e+Bn/5PJ5RBgSH+8KeTKLTUdCEzvLgQKxtUxSiJdAExhIllzQ6S9k+WPbDL25t+KWrqBQOMiFXkvovYvvwqNlRhfxQPJST5yM1NeK/0xPv5YD9zb+oyuEryM9QLEnABlSRDQn1SHF5Sov8LH7DTvsrx58f5txmDFriZ5gjr5pVjAZNpYBAixQJjODyTuTW1U83dwgtdpdAAFgxKJtb5oD1AB55j4EEwUylCbB7pBN5FTFIbo+gCG6qT38yFu+/Skmnoxh+6fYNFoizjM7gf+qVxOsh08YQGntlN4aFheOn1ptm/ACJ26e0=
Steps to reproduce

Open the Devtools Elements panel.
Click on the first Checkbox, and notice that the corresponding <input> does not show any updates.
Click on the second Checkbox, and observe that the corresponding <input> flickers (updates).

https://github.com/user-attachments/assets/3b9dbd1b-5235-4ced-a15e-e6dfa5d820df
What is expected?
In this straightforward reproduction, the corresponding <input> DOM should not be updated when clicking on the Checkbox, as there are no updates besides modelValue.
What is actually happening?
The following code does not update the DOM, which is expected:
<input v-model="checked1" type="checkbox" :value="undefined" />

However, when this code is wrapped into a component, the DOM flickers (updates) every time the Checkbox is clicked.
Checkbox.vue
<script setup lang="ts">
import { computed } from 'vue';

const props = defineProps(['modelValue', 'value']);
const emit = defineEmits(['update:modelValue']);

const modelValueWritable = computed({
  get() {
    return props.modelValue;
  },
  set(value) {
    emit('update:modelValue', value);
  },
});
</script>

<template>
  <div>
    <input v-model="modelValueWritable" :value="value" type="checkbox">
  </div>
</template>

<Checkbox v-model="checked2" />

System Info
System:
    OS: macOS 14.5
    CPU: (8) arm64 Apple M1
    Memory: 80.08 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.9.0 - ~/.nvm/versions/node/v20.9.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v20.9.0/bin/yarn
    npm: 10.5.0 - ~/.nvm/versions/node/v20.9.0/bin/npm
    pnpm: 9.4.0 - ~/.nvm/versions/node/v20.9.0/bin/pnpm
  Browsers:
    Safari: 17.5
    Safari Technology Preview: 17.4
  npmPackages:
    vue: ^3.4.38 => 3.4.38

Any additional comments?
If the default value for value is changed to an empty string, this issue does not occur.
Link to reproduction 2

I found something weird with vModelCheckbox. It's doing extra DOM updates when it's in a component, but vModelText doesn't do this. I think it's because of how beforeUpdate works differently
reproduce
packages/runtime-dom/src/directives/vModel.ts
https://github.com/vuejs/core/blob/c183405f9f58a6619ebc2ce9c653ce3726138a53/packages/runtime-dom/src/directives/vModel.ts
Here's vModelText:
beforeUpdate(el, { value, oldValue, modifiers: { lazy, trim, number } }, vnode) {
  // ...
  if (elValue === newValue) {
    return
  }
  // ...
  el.value = newValue
},

And here's vModelCheckbox:
beforeUpdate(el, binding, vnode) {
  el[assignKey] = getModelAssigner(vnode)
  setChecked(el, binding, vnode)
},

function setChecked(el, { value, oldValue }, vnode) {
  el._modelValue = value
  if (Array.isArray(value)) {
    el.checked = value.indexOf(vnode.props.value) > -1
  } else if (value instanceof Set) {
    el.checked = value.has(vnode.props.value)
  } else if (value !== oldValue) {
    el.checked = value == getCheckboxValue(el, true)
  }
}

See how vModelText checks if the value changed before updating? But vModelCheckbox just calls setChecked every time.
I think there are a few problems:

It only checks value !== oldValue, but this doesn't work well for arrays or Sets.
For arrays and Sets, it does loops or searches every time, even if nothing changed.
It sets checked without checking if it's actually different.

Maybe we could make setChecked smarter? Like, only update checked if it's really different. That way, it wouldn't do extra DOM stuff when it doesn't need to.
What do you think? Should I try to make a fix for this?

@Procrustes5
PR welcome

Upon further investigation, I discovered that this might be one of the causes of the update issue.
In the patchDOMProp function, it checks whether the new and old value are the same. When the <input type="checkbox"> has value set to undefined, the retrieved oldValue will be 'on', while the newValue, after evaluation, will be an empty string. This mismatch leads to an update of the value, which in turn triggers a DOM update.
https://github.com/vuejs/core/blob/c183405f9f58a6619ebc2ce9c653ce3726138a53/packages/runtime-dom/src/modules/props.ts#L25-L46
I attempted to adjust the condition so that when value is either null or undefined and el.type is checkbox, the value passed in would be 'on' instead of an empty string.
This adjustment appears to resolve the DOM update issue.
May I open a PR with this approach? If there are any aspects I have overlooked, I would be very grateful for your feedback.

@yyx990803
I apologize for the inconvenience, but the issue still persists after the merge of PR #11656. It appears that it might only be resolved after the merge of PR #11657. Could we possibly reopen this issue on GitHub in the meantime? Thank you very much for your attention.


Add print state functionality to Register

We can currently print the probabilities of a Register, but we would also want to show the state in order to provide the amplitude as well.

This feature may be included in the cli interface.

This feature is resolved by the CLI interface

Resolved by merging CLI


Error correction methods for creating Bicycle and Unicycle codes + belief decoder code evaluation

Added multiple methods:
code_generation:

Methods for creating Bicycle and Unicycle codes
Methods for assembling CSS codes
Utility methods for working with codes

code_evaluation:

Methods for evaluating codes with a belief propagation decoder
Methods for plotting codes given error rates

ECC.jl was modified to include the required imports for the two added files.

This is pretty exciting! I left a bunch of comments in, but they are mostly on coding conventions, not on the substance of the PR.
I would suggest putting the CCS things in a separate file called css.jl and then the bicycle and unicycle codes in a file uni_bi_cycle_codes.jl or something like that. The name code_generation.jl is much too general, while the content is just for a few specific codes.
We should think of adding some tests, but we can discuss this later.

I did some minor cleanup along the lines of the comments I just posted. Make sure you pull locally before you continue modifying.
Also, it is helpful to always create a separate branch when making modifications. Currently all of this seems to be on your master branch which makes it difficult for you to experiment with multiple things at the same time.
I think there are still some things not functional in simple_sparse_codes.jl
When you address a comment, please also click "resolve" on it, as it makes it easier for me to review.
I will mark this as a draft. When you are ready for the next round of reviews, just mark it back to not-a-draft.

Ben, I just now noticed that you had actually marked this as ready for review for quite a while. I apologize for my oversight! Could you click "resolve conversation" on the comments you have addressed in the follow-up edits? That would make it much easier for me to finish the review.

Hi Stefan, I apologize for not informing you that I pushed an update. I believe that my most recent commits should resolve any problems. I also tested my code to ensure it works, but please let me know if I've made any glaring errors!

I also noticed that you are working on your master branch. That makes work generally more difficult, as it is cumbersome to keep things in sync with the main repository.

@amicciche , skim through the CSS definition that Ben is making here. Just making sure you guys are not duplicating work that is done by the other.

@amicciche , skim through the CSS definition that Ben is making here. Just making sure you guys are not duplicating work that is done by the other.

My definition of a CSS struct was the bare minimum to get the idea of the functionality implemented quickly. In other words, it was sort of a functional placeholder. Here it is in its entirety:
struct CSS; tableau; cx; cz; end

Ben's version seems to be a bit more detailed and fleshed out, and could easily just replace my version. I do have some code that was not included in my pull request that coverts the matrices into a stabilizer tableau, and perhaps could be part of the CSS struct?

Thank you for the review! I have implemented all the changes you requested.
I can definitely prepare some codes, but I'm unsure how to prove that they are valid. Do you know where I might be able to come across some existing bicycle codes for comparison?
Additionally, I will be using new branches for all future commits. Thank you for that recommendation as well!

After #212, a lot of the functionality here has already been implemented. I will close this one for now, but please consider opening a new one that adds the new codes you have defined -- they are not in #212 and will be greatly appreciated.


Ensure right behavior of defer-calls during errors

Previously, in the case of errors, resource-cleaning defer calls may not run and/or unnecessary defer calls may run.

This change is

Looks good. Merging it. Thanks!


Not all quizzes have a due date

If there is a due date, parse it, otherwise set the due date to None.

Coverage increased (+0.01%) to 81.788% when pulling 4623ce74ff07b6e6eff03ee32b92b8dddc9c2dde on bug/quiz_due_date into ef6d2d58a596fcb8e115ee370c63a903939f77c6 on develop.


Change behavior of DataFrame constructor with kwargs

Following issue #972 I would like to discuss the behavior of DataFrame constructor with kwargs.
Currently it effectively works as iterated column insert wrapper. This means that two cases are not handled consistently:

inserting a scalar as the first column of the data frame
inserting the same name of the column multiple times

Examples:
DataFrame(a=1, b=1:2) # case 1: fails although DataFrame(b=1:2, a=1) works
DataFrame(a=1, b=[]) # case 1: fails although DataFrame(b=[], a=1) works
DataFame(a=1:2, a=2:3) # case 2: produces data frame with a single column

I would propose the following behavior:
julia> DataFrame(a=1,b=1:2)
2×2 DataFrames.DataFrame
│ Row │ a │ b │
├─────┼───┼───┤
│ 1   │ 1 │ 1 │
│ 2   │ 1 │ 2 │

julia> DataFrame(a=1, b=[])
0×2 DataFrames.DataFrame

julia> DataFrame(a=1:3,a=1:3)
3×2 DataFrames.DataFrame
│ Row │ a │ a_1 │
├─────┼───┼─────┤
│ 1   │ 1 │ 1   │
│ 2   │ 2 │ 2   │
│ 3   │ 3 │ 3   │

Such behavior would be more consistent with other DataFrame constructors and in line with what one gets in R, except for the case when DataFrame has 0 rows (case DataFrame(b=[], a=1)), when R throws an error, but I think that it should not be an error.
Here is the code that fixes those problems. I can create a PR if such a solution would be acceptable.
function DataFrame(; kwargs...)
    n_col = length(kwargs)
    n_row = -1

    if n_col == 0
        return DataFrame(Any[], Index())
    end

    names = Vector{Symbol}(n_col)
    values = Vector{Any}(n_col)
    for (i, (k, v)) in enumerate(kwargs)
        names[i] = k
        values[i] = v
        if isa(v, AbstractVector)
            if n_row == -1
                n_row = length(v)
            elseif n_row != length(v)
                msg = "All columns in a DataFrame must be the same length"
                throw(ArgumentError(msg))
            end
        end
    end

    names = make_unique(names)
    if n_row >= 0 && !isa(values[1], AbstractVector)
        values[1] = fill(values[1], n_row)
    end

    result = DataFrame(Any[], Index())
    for (k, v) in zip(names, values)
        result[k] = v
    end
    return result
end

This is actually https://github.com/JuliaStats/DataFrames.jl/pull/882, which is almost ready except for a small detail.

Fixed on master


[3.x] Epsilon check for angular velocity in BodySW

Replace exact zero check with approximate check for angular velocity in BodySW
Fixes #51640
Same as #51748 (since it can't be cherry-picked)

Thanks!

Cherry-picked for 3.3.3.


add view portfolio feature

Closes story #20 . this one is the backend + frontend together.
Also closes #39, which is the time locality issue - by syncing to NY time.

The following tasks have been completed:

A user can view their Portfolio items under their profile page (in tabular form)
A user can now also view a pie chart showing their investment distribution

This branch is ready for review.


workspace.createFileSystemWatcher failed to report file event in Windows

I am developing a language server around the feature workspace/didChangeWatchedFile.
With vscode language client, whenever I register a watcher using absolute path with the Windows drive letter to be upper case (e.g., C:/...), the client will fail to report file events. It will work normally if lower-case drive is used (e.g., c:/...).
Since vscode client uses workspace.createFileSystemWatcher for watching files, it may be root-caused by glob matching issue. Add following tests to glob test:
p = 'C:/DNXConsoleApp/**/*.cs';
assertGlobMatch(p, 'c:\\DNXConsoleApp\\Program.cs');
assertGlobMatch(p, 'c:\\DNXConsoleApp\\foo\\Program.cs');

p = 'c:/DNXConsoleApp/**/*.cs';
assertGlobMatch(p, 'C:\\DNXConsoleApp\\Program.cs');
assertGlobMatch(p, 'C:\\DNXConsoleApp\\foo\\Program.cs');

It can be seen that above tests will fail.
Environment

VSCode Version: 1.41.0
OS Version: Windows 10

Steps to Reproduce

Use workspace.createFileSystemWatcher to listen to an absolute path in Windows, with device being c: and C:.
Modify a file that matchs the glob, see that whether a file event is notified in these two watchers.

This issue may adds another vote for https://github.com/microsoft/vscode/issues/10633. This behavior is confusing for the language server developer since they will not be able to use new RelativePattern(workspaceFolder, pattern), but to construct the path on their own.

Example of confusion in java language server:
if (path.getDevice() != null) {
    //This seems pretty hack-ish: need to remove device as it seems to break
    // file detection, at least on vscode
    globPattern = globPattern.replace(path.getDevice(), "**");
}

Merging into https://github.com/microsoft/vscode/issues/10633

Workaround:
p = '[cC]:/DNXConsoleApp/**/*.cs';
assertGlobMatch(p, 'c:\\DNXConsoleApp\\Program.cs');
assertGlobMatch(p, 'c:\\DNXConsoleApp\\foo\\Program.cs');


MP4 to MP3 convertor

Script Title -
This application will allow user to select any mp4 video and will convert it to mp3 audio.
User can also save the mp3 video to any where on the local system.
Requirements-
Tkinter GUI, pymovie library
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md in your folder for program Instructions
add requirements.txt if needed

Programming Language

[x] Python

Happy Coding

Kindly assign this issue to me @pawangeek

@pawangeek I have made the Pull Request for the same but the flake8 check is going wrong. What changes I have to make so that it can pass?

See the details there or check project README how to make flake8 compatible file


A NEP idea on: Change Community Node NEW Unlocking Period

NEP: 43
Title: Change On Community Node NEW Unlocking Period
Authors: "Xu Jizhe"
Discussions: "https://github.com/newtonproject/NEPs/issues/43"
Status: WIP
Categories: Community Governance
Created: 2021-03-15

Open for discussion
Formatting will be done when creating actual PR

Simple Summary
This proposal changes the Community Node NEW unlocking period from 14 days to 7 days for owners and partners to unlock their staked NEW. Making the unlocking period the same as voters to unlock their staked NEW.
Abstract
In NewPay App, unlock NEW for Community Node owners/partners from their staked NEW will be changed from 14 days to 7 days to help them to get their NEW back faster. This requires changes to be made in NewPay App and related protocols and services.
Motivation
NewChain MainNet Nodes are open to the public to join after NEP-27 was proposed. And Newton Incentive Program was proposed in NEP-40, which creates more possibilities for the community to participates in the Newton eco-system and benefits from that.
Before NEP-27 and NEP-40, the majority community to get benefits from Newton Incentives was done by participating in Community Node Program in NewPay App. However, the Community Nodes management has to be done in NewPay App which runs on rules before NEP-27 and NEP-40 was proposed. Currently for Community Node owners/partners  to unlock staked NEW to participate in other Newton Incentive Programs require 14 days, this reduces the flow of NEW in the whole Newton eco-system, also it creates inequality between the Community Node owners/partners and Community Node Voters to unlock their NEW.
This NEP is to reduce the complexities in Community Node management in NewPay App, make equality to all Community Node participants to unlock their NEW. As a result to encourage Community Node participants to use their NEW to participate in more Newton Incentive Programs.
Specification
The unlocking period for Community Node will be set for 7 days for:

Community Node owners to unlock staked NEW by reducing lock amount, quitting Community Node.
Community Node partners to unlock staked NEW by reducing the locked amount.
Community Node voters to unlock staked NEW by reducing the locked amount.

This may be changed in the future by another NEP superseding this NEP.
Implementation
This proposal is planned to be impemented on:

NewChain Testnet: date tbd
NewPay App Testnet: version tbd
NewChain Mainnet: date tbd
NewPay App Mainnet: version tbd

Copyright
Copyright and related rights waived via CC0.

NEP-43 will make the community node mining rules more simple and clear, and more potential NEW liquidities for the Newton ecosystem. Suggest to implement NEP-43 soon.

+1

NEP-43 will make the community node mining rules more simple and clear, and more potential NEW liquidities for the Newton ecosystem. Suggest to implement NEP-43 soon.

@weixuefeng @VieYang can we come up with a date when this can be implemented as soon as possible?

NEP-43 will make the community node mining rules more simple and clear, and more potential NEW liquidities for the Newton ecosystem. Suggest to implement NEP-43 soon.

@weixuefeng @VieYang can we come up with a date when this can be implemented as soon as possible?

Thank you Arisac for writing this proposal.

Thank you Arisac for writing this proposal.

Agree.
With a more open and richer Newton ecosystem, the community node/vote mining rules should be more flexible for every participant. Remove/reduce restrictive rules could lower the barriers to all potential Newton community members and provide better NEW liquidities for DApps on NewChain.
I think ideally the community node/vote minging rules will be no minimum amount requirement and no unlocking period(probably at least 1 day to make the vote countable). All participants could do "join/quit/add/reduce" freely. We can do it step by step based on the progress of DApps. It's a great start.

Suggest to implement NEP-43 soon

同意，如果更短的解锁时间也可行，建议更短时间

关于具体的解锁时间，以实际上线时间为基准：

在生效之前解锁的节点均为14天
在生效之后解锁的节点均为7天
特别的，在生效之前7天内解锁的用户，虽然生效后已变更为7天，但因为是在生效前解锁，故需要等待14天

更加NEP-40，主网上线该功能日期为3月19日，则节点解锁日期如下：

3月12日之前解锁：14天
3月12日至3月19日解锁：14天
3月19日之后解锁：7天


max-/min-width/-height are missing for or fo:external-graphic

It seems the four properties max-height, max-width, min-height, min-width are not listed in the spec as being valid for <fo:external-graphic>.
In the spec in the section about <fo:external-graphic>, "max-height" is mentioned in a note, but not listed under the properties applicable.
Maybe one need a better grip at understanding the spec?
We are also using those properties with <fo:block>, but I am not sure whether this should be working.

There's two parts to this:

XSL (or its editors) had an uneasy relationship with CSS,  max-height, etc., are copied from CSS (see the meaning of the black border from http://www.w3.org/TR/xsl/#d0e15664), and because they're not listed as properties of fo:block-container, etc., the stylesheet that dumps the Relax NG wasn't picking them up.  They've now been added using the same mechanism as for adding shorthands.
In my testing, AH Formatter doesn't complain about max-width, etc., on fo:block, but also doesn't honor them.

Now allowed by the schema.


Sentinl rolling upgrade Kibana 6.5.3 -> 6.6.0 No layout after upgrade

System Details
Versions

Type
Version

Kibana
6.6.0

Elasticsearc
6.6.0

Server OS
RHEL7

Browser
Chrome Version 71.0.3578.98

Original Install Method

[ ] Release pkg link
[ ] Gulp
[ X] Source
Other:

Bug Details
Bug Description
After rolling upgrade to newest stack, I am not able to get into sentinl layout where I could manage all watchers saved.
Errors in Browser Console
This an error which I got form chrome console log:
Error: vendors.bundle.dll.js:434 GET http://lvrprdels008:5601/api/sentinl/time 500 (Internal Server Error)
{"statusCode":500,"error":"Internal Server Error","message":"An internal server error occurred"}
Screenshots

From Kibana logs:
{
"type": "error",
"@timestamp": "2019-02-07T09:31:22Z",
"tags": [],
"pid": 14965,
"level": "error",
"error": {
"message": "reply is not a function",
"name": "TypeError",
"stack": "TypeError: reply is not a function\n    at handler (/usr/share/kibana/plugins/sentinl/server/routes/routes.js:25:14)\n    at module.exports.internals.Manager.execute (/usr/share/kibana/node_modules/hapi/lib/toolkit.js:35:106)\n    at Object.internals.handler (/usr/share/kibana/node_modules/hapi/lib/handler.js:50:48)\n    at exports.execute (/usr/share/kibana/node_modules/hapi/lib/handler.js:35:36)\n    at Request._lifecycle (/usr/share/kibana/node_modules/hapi/lib/request.js:263:62)\n    at process._tickCallback (internal/process/next_tick.js:68:7)"
},
"url": {
"protocol": null,
"slashes": null,
"auth": null,
"host": null,
"port": null,
"hostname": null,
"hash": null,
"search": null,
"query": {},
"pathname": "/api/sentinl/time",
"path": "/api/sentinl/time",
"href": "/api/sentinl/time"
},
"message": "reply is not a function"
}
Steps to Reproduce

Before rolling upgrade all plugins had been removed
Rolling upgrade of Kibana
Instalation plugins via /usr/share/kibana/bin-plugin install file:///<file_location>

Expected Behavior
Layout of sentinel will show up in Kibana
Screenshots

Is it a bug, or is this a installation issue?
Will appreciate your support.
Thanks,
Jan

Duplicate of the other error in https://github.com/sirensolutions/sentinl/issues/677 . Seems like there is a fix coming soonish.....

Duplicate of #677


Use OpenSSL as an optional crypto provider (#1529)

A first stab at making OpenSSL an alternative crypto provider in aws-sigv4 and
aws-config, so the SDK can be consumed in a FIPS environment.
Motivation and Context
In a FIPS environment, there is a requirement that all crypto operations are delegated to a FIPS-certified crypto module. Some Linux distributions, such as RHEL, ship FIPS-certified OpenSSL. In order for the SDK to be usable in such environment, it should be possible to rely on OpenSSL exclusively for all crypto needs.
https://github.com/awslabs/smithy-rs/issues/1529
Description
I would like to start a conversation on how the SDK can be used in a FIPS environment. This PR makes it possible to replace Ring with OpenSSL as a crypto provider in aws-sigv4 and aws-config, but there are still rough edges as Ring types are exposed in the public API.
Testing

Tested with tools/ci-build/scripts/check-rust-runtimes-and-tools
Tested as part of https://github.com/vectordotdev/ against live AWS

Checklist

[x ] I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hey @syedriko, thanks for looking into this and submitting a PR. I have a philosophical issue with it.
I wrote an RFC a little while ago (that the team hasn't yet accepted) detailing how I think we should handle situations like this. You have code similar to this in a few places:
cfg_if::cfg_if! {
    if #[cfg(feature = "ring")] {
        use ring::digest::{self, digest};
        let mut ret: [u8; 20] = [0; 20];
        ret.clone_from_slice(digest(&digest::SHA1_FOR_LEGACY_USE_ONLY, buf).as_ref());
        ret
    } else if #[cfg(feature = "openssl")] {
        openssl::sha::sha1(buf)
    } else {
        compile_error!("Either feature \"openssl\" or \"ring\" must be enabled for this crate.");
    }
}

I'd prefer that we move away from writing the SDK in such a way that customers configure how it works by setting features. Writing things like this puts a burden on users to understand how configuration is set depending on what matrix of features they have enabled. This is further complicated by how features in Rust are additive. It's easy to unintentionally  activate features when configuring dependencies because of feature unification.
I think that a better alternative would be to make the signer/hash generator something that could be replaced through configuration, in the same way that we allow users to

replace the default credentials provider
set their own async sleep impl
set an http connector to use over the default hyper connector (currently, this feature is only partially implemented)

It's not my intention to shoot your contribution down; I do think there is a place for this code in the SDKs or a related crate. In my opinion, an RFC is the next step. Let me know what you think.

Hey @syedriko, we appreciate this contribution, but it's been a year and there hasn't been any traction on it. I'm going to close it for now. If you decide you want to work on it again, feel free to open a new PR.


Fix the current beta version

The current version string isn't valid and doesn't parse on the Buildkite end, so 3.28.0.pre agents cannot register
This fixes the version string to be valid, and adds a note about valid version strings to version.go

ping @moensch


aws-cpp core and gamelift DLLs not loading on packaged game

Hi all,
There may be a problem with the paths for packaged game dlls, as my gameliftclient plugin crashes the exe when I run a packaged version (editor version and standalone are working). Any pointers as to where the error might be? The dlls are in the packaged game plugin folder, but I have yet to check the paths for them in the plugin.

I was able to fix the issue partially but the changes I made is causing AWSCore.dll to fail. Right now the workaround is to place all the dll files right next to the Game exe (i.e: YourGameName\Binaries\Win64 location).

workaround is good for now!

@maucoen This issue has been resolved in this commit 83b49230e2f79d1ee487bd55cc16edbf4bf8a025

pulled the commit and it works, thanks!


Fenrir - Frenzy did not destroy Isis

Frenzy entered play with Isis at 3 HP, but did not get the option to destroy her

Reworded Frenzy
I think it's best we don't try to break the engine by eating Character Cards.

Reworded Frenzy
I think it's best we don't try to break the engine by eating Character Cards.


Update New ExtData to use new yaFyaml on MAPL v3 branch

MAPL 2 will still use the 1.0-beta7 interfaces to be compatible with older baselibs.

I think the relevant Baselibs will be 7.0.0  (@mathomp4 please confirm)

Yes. It'll end up as Baselibs 7.0.0 I think. Relevant draft PR here: https://github.com/GEOS-ESM/ESMA-Baselibs/pull/41
Note that there is a temporary build found here on discover:
/discover/swdev/gmao_SIteam/Baselibs/TmpBaselibs/ESMA-Baselibs-6.2.13-with-GFErepo/x86_64-pc-linux-gnu/ifort_2021.3.0-intelmpi_2021.3.0


feat: Upgrade to LSP 3.16

Fixes https://github.com/atom-community/atom-languageclient/issues/110
The first commit of #112 is cherry-picked

I'll add a few tests to this before approving.

I rebased this incorrectly. I will fix it tomorrow.

Requires #134


Bulleted arrays with . or •

Fixes #803

Can you add as tuple or as const (or any other type cast, really) to a bulleted array without adding parens?

Good question. No, it's not possible without parens. I think at least |> as tuple and |> as const should be addable, but even those don't work yet.
I think trailing type casts (as ...) in the same places that trailing member/call expressions (and maybe pipes from #1168) would make sense as a separate issue.

I definitely feel like I'm stretching the grammar a bit here. We lack a nice place to put things that work only at the indentation level, not deeper in an expression. For example, I didn't want to allow something like this:
array.map . foo
          . bar

(in particular because array.map . foo already has a meaning, involving placeholders)
As a result, it seems like I had to add (Nested)BulletedArray in a few too many places. Perhaps this could be cleaned up somehow... I'm open to ideas!
Related, I just added support for trailing members/calls and pipelines after top-level bulleted arrays, enabling |> as const. I'm not sure I added it to all the right contexts though...
I think this is a reasonable starting point though, and we can extend/fix as we run into further issues.

@edemaine Surely YAML-like - would make more sense here than ., which feels a bit too close to…
object
  .method()
  .chaining()

@danielbayley How would you distinguish from subtraction?

@danielbayley How would you distinguish from subtraction?

Iv’e never personally used, or seen any multiline subtraction expressions in the wild. Which is of course, not to say this edge case doesn’t exist…
Maybe the distinction could be that if there is a newline between - entries, then it’s an array, else -s on the same line is interpreted as subtraction. Then if you did actually want multiline subtraction, you could just wrap that in parentheses? Something like:
total := (
  n
  - 1
  - 1
)

Although, maybe that isn’t even necessary, given that in order to subtract, the first token after the assignment = would be a value to subtract from anyway…
@edemaine What do you think?

My worry is examples like this:
func x
  - y
  - z

// parse 1: subtraction (how Civet works now)
func(x
  - y
  - z)

// parse 2: call with array argument (how . works now)
func(x(
  [ y,
    z]))

I guess you're saying to prioritize the latter parse, but I don't see how to obtain subtraction behavior without moving the - signs onto the previous line (as requierd in CoffeeScript, but something I really don't like about CoffeeScript). Wrapping in parentheses doesn't help.

One possibility that comes to mind: We could add an opt-in YAML compatibility mode via "civet yaml" (or some better name) that

enables - and * as bullets, but also
prevents - and * from being used as binary operators when preceded by a newline.

For some, I can imagine this is a worthwhile trade-off.


Include references to the current Eth1 spec

Include a directory or set of files that describe the current spec.
It could be a simple as including a link to the yellow paper, and including a list of hardforks with included EIPs of each hardfork.

Great idea! @MadeofTin what do you think?

I love the idea.

Is this covered by what is listed here? https://github.com/ethereum/eth1.0-specs#ethereum-protocol-releases


motor delay

consider adding a term for
motor developmental delay
child of behavioral developmental delay
see Motor delay (HP:0001270)
def in HPO "A type of Developmental delay characterized by a delay in acquiring motor skills."
several annotations to behavioral developmental delay that could be moved to this
related to CHARGE syndrome HPO phenotypes

Added new term:
motor developmental delay MP:0031496
DEF: acquisition of motor skills or milestones, including gross and/or fine motor abilities, occurs later in development compared to controls
SYNONYMS: delayed early motor milestones | delayed motor development | delayed motor milestones | delay in motor development | locomotor delay | motor retardation | delayed development of motor milestones | retarded motor development


Update coursier to 2.1.14

Fixes https://github.com/com-lihaoyi/mill/issues/3695 along with https://github.com/com-lihaoyi/mill/pull/3701 (the two PRs are needed)

@alexarchambault can you elaborate a bit on what the version bump pulls in?

And how does this PR fix the other two PRs? Does it render them redundant? is this PR needed for those to land, or vice versa?

Yeah, this bumps coursier to 2.1.14, which pulls https://github.com/coursier/coursier/pull/3093 (makes coursier fetch klib files out-of-the-box). This, alongside https://github.com/com-lihaoyi/mill/pull/3701 (which stops making Mill discard non-*.jar files from coursier, and just trusts coursier to filter artifacts), fixes https://github.com/com-lihaoyi/mill/issues/3695.

Sounds good. The failure looks unrelated, let me merge these two PRs


Change default route for wallets on mobile

Yeah, the design kind of makes it hard to see that there are multiple accounts.
Also it would be nice if the list scrolled to the current wallet.
Those can be future PRs, though.


Support for GraphQL-esque aliases

Problem
GraphQL supports aliases in the form:
query ($startOfWeek: DateTime!, $startOfLastWeek: DateTime!) {
    something {
        id
        startOfWeekValue: valueAt(at: $startOfWeek)
        startOfLastWeekValue: valueAt(at: $startOfLastWeek)
    }
}

Currently there's no good way to alias another field. If the field you are trying to alias is a scalar type then you can make it work via:
type Result = Derive<Something, {
    id: Auto;
    startOfWeekValue: Something["valueAt"];
    startOfLastWeekValue: Something["valueAt"];
}

but this won't work well with arrays and nested objects. It also doesn't infer optionality correctly because you are forced to specify the field as non optional.
You could potentially make it work via a nested Derive for arrays and objects (haven't tried it yet), but that's cumbersome at best.

Solution draft
An idea could be something like this for scalar types:
type Result = Derive<Something, {
    id: Auto;
    startOfWeekValue: Alias<"valueAt">;
    startOfLastWeekValue: Alias<"valueAt">;
}>;

and this for objects / arrays:
type Result = Derive<User, {
    id: Auto;
    closeFriends: Alias<"friends", {
        id: Auto;
        name: Auto;
    }>;
}>;

But seems complicated to implement correctly. Wondering if there's a better solution.

I've settled for making Derive more flexible (accepting also regular types) so that you can use Derive inside other Derives for aliases.

For example:
type Result = Derive<User, {
    id: Auto;
    closeFriends: Derive<User["friends"], {
        id: Auto;
        name: Auto;
    }>;
}>;

This will work exactly like Auto does with regards to optionality, nullability and arrays.

I've tried to implement something like:
type Result = Derive<User, {
    id: Auto;
    closeFriends: Alias<"friends", {
        id: Auto;
        name: Auto;
    }>;
}>;

but the main problems were:

it's extremely complicated
seems computationally expensive
you don't get auto complete for keys

Finally I've also tried something like:
type Result = Derive<User, {
    id: Auto;
    closeFriends: AutoFrom<User, "friends", {
        id: Auto;
        name: Auto;
    }>;
}>;

but for some reason even if it's defined as AutoFrom<BaseType, KeyType extends keyof BaseType> then VSCode is unable to autocomplete the keys. Since the final solution just replaces AutoFrom<User, "friends", {...}> with Derive<User["friends"], {...}> it seems pretty close and it:

supports autocomplete
doesn't need an extra type
makes Derive more flexible

Reopening because nested Derive don't support inferring the optionality of a field.


Task visibility issue when searching for projects using client name

OS version: Win 10
Browser version: Chrome 79.0.3945.117
Extension version: 1.56.2

🐛 Describe the bug
When you click on a TE to edit it (running or previously stopped existing) you will be able to search for a project with both the project name and the client name. If you search for a project with the project name you will get the correct result along with existing tasks:

If you search using the client name you will get all projects connected to that client but without tasks:

Expected behaviour
I expect to be able to see tasks with both approaches
Steps to reproduce
Steps to reproduce the behaviour:

Click on an existing TE (running or stopped) using the Toggl Button to edit it
Search for a project that you know has tasks by using the client name
Now search for that same project directly with the project name and see if tasks are there

Any updates here?


Remove client id/file mutually exclusive relationship

Remove client id/file mutually exclusive relationship
Because of the default value set for file, setting client-id gives the error fields marked as mutually exclusive were set: file, client-id

We can save a c1z and run in service mode? I didn't know that was a thing.

We can save a c1z and run in service mode? I didn't know that was a thing.

me neither, I "translated" what I saw in the original code


Modify recrypt command to allow recrypting file with different encryp…

I rebased the PR #211  initially created by @dianac10.
@rnelson0 @nfagerlund  Please could you review the changes? We plan to open source soon a plugin for Microsoft KeyVault. Without this fix, we are forced to use a forked version, which we really want to avoid.
cc @brndkfr @maximbaz-microsoft

@rnelson0  Should we add tests also for this scenario?

Yes, tests are definitely recommended.

@rnelson0 I added more tests for recrypt command specifically for the opitons introduced by this PR. Initially the text is encrypted with PKCS7`, then rencrypted  with a different encryption plaintext and finally rencrypted back to PKCS7.  We introduced the -d (change_encryption) option.

@rnelson0 Looking forward to you feedback. Do you need more details to be able to review the PR?

@cosmincojocar I've reached out to @TomPoulton for some verification. This looks good to me, but we (VP) have just recently accepted this gem so I want to make sure I'm not missing something obvious, and to make sure that the updated tests are properly validating this (I think we need to change the test output so it's more clear which tests are running so we know a test isn't skipped - but unrelated to this PR).

@rnelson0 Any progress on this PR?

I have to rely on @TomPoulton for this, sorry.

Hi all, from what I can tell by glancing at the logs, it looks like there's an incompatibility between the json_pure v2.0.1 gem and ruby 1.8.7
I imagine we're going to run into these problems more are more, so I suppose we should decide whether we want to "officially" support 1.8.7?

@TomPoulton I created #238 for version support. In the meantime, can you review the code itself for possible issues, either technical or that would affect the roadmap?

@TomPoulton @rnelson0 Any progress with the review? It would be grate if you could merge it if there aren't any concerns.

@rnelson0 Also this branch is rebased.

@cosmincojocar This should be good to rebase again, as well!

@rnelson0 done, the tests are now green.

Hooray! Thanks for your patience!

Personal, rather than company opinion, but it is possible that the way this is implemented has broken GPG encryption causing the default to always be PKCS7 on recrypt, irrespective of what is listed in the various config files. It certainly appears that 3.0.0 onwards is affected by this problem.


bug: leap deprecate LeapLabelPrimary

Did you check docs and existing issues?

[X] I have read all the tokyonight.nvim docs
[X] I have searched the existing issues of tokyonight.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.0
Operating system/version
MacOs
Describe the bug
leap.nvim deprecate highlight groups (b75a86f)
labels stays greyed like backdrop

Steps To Reproduce

install LazyVim
enable leap in extras
use leap

Expected Behavior
highlight labels

My LazyVim fix
return {
  {
    "folke/tokyonight.nvim",
    opts = {
      on_highlights = function(hl)
        hl.LeapLabel = { fg = "#ff007c", bold = true }
      end,
    },
  },
}

Instead of creating an issue, create a PR?

@folke i could do that but do not guarantee to cover all usage scenarios
Is it suits for you?

What do you mean? It's literally just changing one group, or am I missing something?
The code is here https://github.com/folke/tokyonight.nvim/blob/main/lua/tokyonight/groups/leap.lua


Allow rules to fail

If, for example, the title or url matcher regex does not match
successfully then this should allow processing subsequent rules without
modification by the failed rules.
Apologies that the diff is quite nasty, it's mostly due to moved code.

It works to some extent:
If title matcher fails for some rule, the rule gets ignored. However, from what I experience, the other rules (following the ignored ones) are not executed.
So at least in the above case we don't get something like "@2 @1" but the original title in the above case - it's definitely an improvement.

I also believe that "dist" folder is not up to date in this PR, but contains the master version of dist/js/content.js.

@grigorye I no longer use chrome, so unless somebody else wants to take this over or there's something easy I can do for you it could be closed.

@dakotahawkins I see, I believe this might be helpful for others even in the current form. So I would propose to leave it as is for now. And, thanks for this thing - it helps me in any case!

If title matcher fails for some rule, the rule gets ignored. However, from what I experience, the other rules (following the ignored ones) are not executed.

FWIW, there is supposed to be a test for this in here, where matching github.com/blah/blah fails and subsequently github.com/blah succeeds, but I don't remember how it was hooked up (unless I'm blind!) :(

Hi @dakotahawkins,
The entire code base has been rewritten. If this is still needed, can you contribute again or open a discussion? Tab Modifier 1.0 is now available!
Bests


Removed unused local var of code example

Local variable "varType" removed, because it's not used/needed in the code example.

Docs Build status updates of commit a5fc152:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-nav/TYPE-Function--FieldRef-.md
:bulb:Suggestion

Details

dynamics-nav/TYPE-Function--FieldRef-.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Thanks for your contribution!


GCov 9.3.0 doesn't work properly when run from project root folder

On gcov 7.5.0 when source file is not found (and this is true because codecov is always running from the root folder, and src/gcda/gcno could be in subfolder), gcov file is generated with lines that has hit number but no source, and this file is processed correctly by codecov.
On gcov 9.3.0 (I didn’t check versions between 7.5.0 and 9.3.0) when source file is not found, gcov file is generated empty (ok, almost empty, but the main is that it doesn’t contains any lines with hit number).
Looks like this could be a solution, but should be adapted to the codecov script: https://unix.stackexchange.com/q/218335
More info: https://community.codecov.io/t/lost-covered-lines-empty-tags-are-gone/2672/2

Ok, this is called ‘read documentation first before reporting bugs’.
Since gcc 8.1.0 release, source file is needed to generate correct coverage report.
New compilation flag -fprofile-abs-path was introduced to preserve correct path to source file in *.gcno file.


Update Amplify Endpoint to Representatives

Creating a new issue to update the Amplify Endpoint.
Per our conversation in the Send Letter Issue, updating api/amplify/{zipcode} to reflect api/representatives/{zipcode}

[x] Modify app.js file for routing
[x] Change name of Amplify Endpoint to Representatives
[x] Update Wiki information to reflect Representatives
[x] Update Front-End URL for --> @mahrsbar

Closed by #84 + #86


About cl_amd_copy_buffer_p2p seen in ROCM 1.6 OpenCL..

Just searching in the binary I see new cl_amd_copy_buffer_p2p extensión..
info coming soon?

It is a new P2P API for OpenCL on large BAR system  which we have been working on that not DirectGMA based.  It will also deal with the copy across the QPI link on Intel Xeon 2p Systems.
On Jun 30, 2017, at 5:41 PM, Oscar Barenys <notifications<EMAIL_ADDRESS>wrote:
Just searching in the binary I see new cl_amd_copy_buffer_p2p extensión..
info coming soon?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/RadeonOpenCompute/ROCm/issues/140, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD8DuW3vJ6wPxGn0jli5oPagYc_972VTks5sJXmsgaJpZM4OLHiH.

thanks..
seems this has made the way to Windows driver 17.7.2..

Where may I find a bit of information, or a sample, about how to use cl_amd_copy_buffer_p2p? (the API methods that are enabled by this extension). Thanks.

Hi @preda
The only function enabled by this extension is clEnqueueCopyBufferP2PAMD(), and clGetDeviceInfo() is extended with two new parameters that tell you which "P2P neighbors" a target device could use with this function.
I have created a toy application that demonstrates how to use this function to move data between buffers in two separate GPUs. You can find it at https://github.com/jlgreathouse/test_cl_amd_copy_buffer_p2p

@jlgreathouse thank you, this is useful!

Looking at the PCIe IDs, I suspect that your devices are on different sockets in a multi-socket system. If this is an Intel system, I'll note that I don't believe this P2P mechanism supports crossing QPI fabric at this time.
If your Vga 64 GPUs are not Large BAR enabled, this will also not work.

This issue is already closed, but I'm curious about P2P copy.
Talking about "Large BAR", my BIOS does map the GPU below 4GB. But on boot with 4.20.0 kernel, a remapping by amdgpu can be observed:
[    1.395069] ATOM BIOS: 113-BAFFIN_PRO_160513_D5_2G_HY_0_SF_W83
[    1.395093] [drm] vm size is 256 GB, 2 levels, block size is 10-bit, fragment size is 9-bit
[    1.395136] amdgpu 0000:41:00.0: BAR 2: releasing [mem 0x90000000-0x901fffff 64bit pref]
[    1.395139] amdgpu 0000:41:00.0: BAR 0: releasing [mem 0x80000000-0x8fffffff 64bit pref]
[    1.395155] pcieport 0000:40:03.1: BAR 15: releasing [mem 0x80000000-0x901fffff 64bit pref]
[    1.395164] pcieport 0000:40:03.1: BAR 15: assigned [mem 0x47e80000000-0x47f3fffffff 64bit pref]
[    1.395167] amdgpu 0000:41:00.0: BAR 0: assigned [mem 0x47e80000000-0x47effffffff 64bit pref]
[    1.395175] amdgpu 0000:41:00.0: BAR 2: assigned [mem 0x47f00000000-0x47f001fffff 64bit pref]

Would this allow P2P?
The 4.20 kernel now also provides the CONFIG_PCI_P2PDMA option. Is this needed to allow P2P between the GPUs?
Currently this is all theoretical since there is only a single GPU in my system.

My system is a single-socket, single-CPU, asrock x299 taichi motherboard with  i7-7820X (28 PCIe lanes on the CPU). The 2 Vega64 GPUs are located in the "best" slots on the motherboard which I think are PCIe slots 1 & 3. These are both Gen3, but one runs at 16x and the other at 8x (because of limited PCIe lanes offered by the CPU).
Is it expected for the p2p copy to not work in such a setup?

It seems I fixed the large BAR problem, but still no success with the p2p copy (see below)
~$ dmesg | grep BAR
[    4.801949] amdgpu 0000:19:00.0: BAR 2: releasing [mem 0xb0000000-0xb01fffff 64bit pref]
[    4.801950] amdgpu 0000:19:00.0: BAR 0: releasing [mem 0xa0000000-0xafffffff 64bit pref]
[    4.801962] pcieport 0000:18:00.0: BAR 15: releasing [mem 0xa0000000-0xb01fffff 64bit pref]
[    4.801964] pcieport 0000:17:00.0: BAR 15: releasing [mem 0xa0000000-0xb01fffff 64bit pref]
[    4.801965] pcieport 0000:16:00.0: BAR 15: releasing [mem 0xa0000000-0xb01fffff 64bit pref]
[    4.801980] pcieport 0000:16:00.0: BAR 15: assigned [mem 0x381000000000-0x3812ffffffff 64bit pref]
[    4.801981] pcieport 0000:17:00.0: BAR 15: assigned [mem 0x381000000000-0x3812ffffffff 64bit pref]
[    4.801982] pcieport 0000:18:00.0: BAR 15: assigned [mem 0x381000000000-0x3812ffffffff 64bit pref]
[    4.801984] amdgpu 0000:19:00.0: BAR 0: assigned [mem 0x381000000000-0x3811ffffffff 64bit pref]
[    4.801989] amdgpu 0000:19:00.0: BAR 2: assigned [mem 0x381200000000-0x3812001fffff 64bit pref]
[    4.802048] [drm] Detected VRAM RAM=8176M, BAR=8192M
[    5.367624] caller pci_map_rom+0x71/0x1c0 mapping multiple BARs
[    5.367677] amdgpu 0000:67:00.0: BAR 2: releasing [mem 0xd0000000-0xd01fffff 64bit pref]
[    5.367678] amdgpu 0000:67:00.0: BAR 0: releasing [mem 0xc0000000-0xcfffffff 64bit pref]
[    5.367690] pcieport 0000:66:00.0: BAR 15: releasing [mem 0xc0000000-0xd01fffff 64bit pref]
[    5.367691] pcieport 0000:65:00.0: BAR 15: releasing [mem 0xc0000000-0xd01fffff 64bit pref]
[    5.367692] pcieport 0000:64:00.0: BAR 15: releasing [mem 0xc0000000-0xd01fffff 64bit pref]
[    5.367707] pcieport 0000:64:00.0: BAR 15: assigned [mem 0x382000000000-0x3822ffffffff 64bit pref]
[    5.367709] pcieport 0000:65:00.0: BAR 15: assigned [mem 0x382000000000-0x3822ffffffff 64bit pref]
[    5.367710] pcieport 0000:66:00.0: BAR 15: assigned [mem 0x382000000000-0x3822ffffffff 64bit pref]
[    5.367711] amdgpu 0000:67:00.0: BAR 0: assigned [mem 0x382000000000-0x3821ffffffff 64bit pref]
[    5.367717] amdgpu 0000:67:00.0: BAR 2: assigned [mem 0x382200000000-0x3822001fffff 64bit pref]
[    5.367765] [drm] Detected VRAM RAM=8176M, BAR=8192M
~$ ./test_cl_amd_copy_buffer_p2p/test_p2p
Searching for platforms...
Using platform: AMD Accelerated Parallel Processing
Searching for devices...
Using device: gfx900
Number of P2P devices that can be seen from device #0: 0
PCIe Topology of device 0: 19:0.0
Searching for devices...
Using device: gfx900
Number of P2P devices that can be seen from device #1: 0
PCIe Topology of device 1: 67:0.0
Device 0 and device 1 are not P2P neighbors
They cannot be used to test P2P transfers.
Exiting!


volumegroup: add volumeID's to createGroup

add an optional volumeID's to the CreateVolumeGroupRequest where some storage providers might not support creating a empty group and expect some volumes to exist to create a group. and also helps to pre-identify the group details for which volume already exists where a volume can be part of only one group and cannot be part of multiple groups.

hmm, I think it would be  better to remove volumgroup support and have CSI-drivers handle internally how/if they need volumegroups.
kubernetes-csi-addons will just pass listst of volumes to CSI-Addons procedures, just like VolumeGroupSnapshot does in its related CSI procedures.

hmm, I think it would be better to remove volumgroup support and have CSI-drivers handle internally how/if they need volumegroups.
kubernetes-csi-addons will just pass listst of volumes to CSI-Addons procedures, just like VolumeGroupSnapshot does in its related CSI procedures.

@nixpanic This is a complete change in plan for the implementation the plan was to reuse the volumegroup concept under the volumegroupreplication concept where the user will not see the volumegroup but we will make use of the volumegroup concept. any specific reason for this suggestion.

hmm, I think it would be better to remove volumgroup support and have CSI-drivers handle internally how/if they need volumegroups.
kubernetes-csi-addons will just pass listst of volumes to CSI-Addons procedures, just like VolumeGroupSnapshot does in its related CSI procedures.

@nixpanic This is a complete change in plan for the implementation the plan was to reuse the volumegroup concept under the volumegroupreplication concept where the user will not see the volumegroup but we will make use of the volumegroup concept. any specific reason for this suggestion.

CSI-drivers can use a volumegroup structure internally if they need one. I don't think it should be part of an API for consumers (like a CSI-Addons API).

CSI-drivers can use a volumegroup structure internally if they need one. I don't think it should be part of an API for consumers (like a CSI-Addons API).

what is the use of it? the earlier discussion was to separate the replication and grouping into two different parts but now the suggestion is to make it a single API for both operations, am I assuming it is correct or you are suggesting something else?

@nixpanic PTAL based on the discussion as we agreed to keep the current flow


[Bug]: Illegal Usage Despite Registration Being Closed

Contact Details
No response
What happened?
I've noticed today that my API Key's hard limit has been triggered. Upon investigating in the MongoDB, I've come across numerous Chinese messages, even though the registration has been closed. How is this possible? It seems like an account has been created. Can you please look into this?
Steps to Reproduce
dont know
Login:

Messages at MongoDB:

illegal user accounts:

What browsers are you seeing the problem on?
No response
Relevant log output
No response
Screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

##########################
# User System:
##########################

# Allow Public Registration
ALLOW_REGISTRATION=false

# Allow Social Registration
ALLOW_SOCIAL_LOGIN=false

Confirmed issue:
curl --location 'http://localhost:3080/api/auth/register'
--header 'Content-Type: application/x-www-form-urlencoded'
--data-urlencode 'name=BizzleWizzle'
--data-urlencode 'username=fred'
--data-urlencode<EMAIL_ADDRESS>--data-urlencode 'password=flintstone'
--data-urlencode 'confirm_password=flintstone'
{
"user": {
"id": "64da1d2294f6a925f5f885b0",
"provider": "local",
"email"<EMAIL_ADDRESS>"name": "BizzleWizzle",
"username": "fred",
"avatar": null,
"role": "USER",
"emailVerified": false,
"plugins": []
}
}

So sorry this happened to you @SphaeroX. Since you've been a longtime supporter and the first to report this, I'm willing to recompense up to the default hard limit.

How is this possible?

There may be a couple things going on here. A lot of things in deployment can be insecure from server configuration but as @arshem just highlighted, this route was not as secure as it should be. We can look at code blame to understand how this was missed, but I deeply apologize it went past my review.
On top of this, I would suggest you do not use the default IV and key, along with any other server secrets that have default values. Docker will also expose the mongoDB ports, so you should update to the latest compose file so they are commented out by default. https://github.com/danny-avila/LibreChat/pull/786
Another issue


Generated CSV file is locale-specific

While generating data for the Behavioral Cloning project, I found something interesting (and highly annoying) with the beta simulator in Linux (Ubuntu 16.10 x64). I was trying to generate new data and when finished recording, I tried to load my CSV file only to find out that the values didn't make sense. When checking it, I found that all the values had a comma instead of a period as the decimals separator (I live in Venezuela so my PC's locale is set as es_VE), so I got unintended extra columns in the file.
Running the simulator as $ LC_ALL ./beta_simulator.x86_64 & serves as a workaround.

I also have this problem.

Same here. Fixed with @tdanyluk command


Create spring

Closing this issue as it lacks detailed information.  Please feel free to submit another issue for discussion if required.  Thanks!


Game crash

When I open minecraft in a virtual machine, it crashes, how to fix it?!
T3AcH7rL_X4.jpg

Try to run the monitorscript.sh, without the log I can't do much

Try to run the monitorscript.sh, without the log I can't do much


NotAvailableError: No usgs request url was found for LC08_L1TP_197030_20140926_20200911_02_T1

The search also works fine, however, I am getting an error when downloading product LC08_L1TP_197030_20140926_20200911_02_T1.
eodag.utils.exceptions.NotAvailableError: No usgs request url was found for LC08_L1TP_197030_20140926_20200911_02_T1

setup_logging(3) gives me this download url: https://earthexplorer.usgs.gov/download/external/options/landsat_ot_c2_l1/LC81970302014269LGN01/M2M/.
I am able to download products for more recent dates (for example 20221017) on the same AOI. But I am also able to download the 20140926 product with another library. Is there any limitations to the time range that eodag can access, or am I missing another parameter to access older products?
Please let me know for any other information that could be useful.
Originally posted by @tvoirand in https://github.com/CS-SI/eodag/issues/560#issuecomment-1330362096

I am also able to download the 20140926 product with another library

@tvoirand what library are you using to download this product ?

I am using landsatxplore, or to be precise a fork of landsatxplore, because it seems this library is not maintained anymore.

Using your fork of landsatxplore I also have the same not available error:
$ landsatxplore search --dataset landsat_ot_c2_l1  --start 2014-09-26 --end 2014-09-27
LC08_L1GT_003004_20140927_20200911_02_T2
LC08_L1TP_003005_20140927_20200910_02_T2
LC08_L1GT_003006_20140927_20200910_02_T2
LC08_L1TP_003007_20140927_20200911_02_T1
LC08_L1TP_003008_20140927_20200910_02_T1
LC08_L1GT_003009_20140927_20200911_02_T2
[...]

$ landsatxplore download LC08_L1TP_197030_20140926_20200911_02_T1
Traceback (most recent call last):
  File "/home/sylvain/.virtualenvs/landsatxplore/bin/landsatxplore", line 8, in <module>
    sys.exit(cli())
  File "/home/sylvain/.virtualenvs/landsatxplore/lib/python3.10/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/sylvain/.virtualenvs/landsatxplore/lib/python3.10/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/sylvain/.virtualenvs/landsatxplore/lib/python3.10/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/sylvain/.virtualenvs/landsatxplore/lib/python3.10/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/sylvain/.virtualenvs/landsatxplore/lib/python3.10/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/sylvain/.virtualenvs/landsatxplore/lib/python3.10/site-packages/landsatxplore/cli.py", line 164, in download
    fname = ee.download(
  File "/home/sylvain/.virtualenvs/landsatxplore/lib/python3.10/site-packages/landsatxplore/earthexplorer.py", line 146, in download
    filename = self._download(url, output_dir, timeout=timeout, skip=skip)
  File "/home/sylvain/.virtualenvs/landsatxplore/lib/python3.10/site-packages/landsatxplore/earthexplorer.py", line 88, in _download
    raise EarthExplorerError(error_msg)
landsatxplore.errors.EarthExplorerError: Download is not available

Do you have a working code snippet to download LC08_L1TP_197030_20140926_20200911_02_T1 ?

Thanks a lot for your investigation.
Here is a python code snippet that I am using (needs replacing "XXX"):
from landsatxplore.api import API
from landsatxplore.earthexplorer import EarthExplorer

landsatxplore_api = API("XXX", "XXX")
earthexplorer_catalog = EarthExplorer("XXX", "XXX")

scenes = landsatxplore_api.search(
    dataset="landsat_ot_c2_l1",
    bbox=(3.4314538515220647, 43.257483919751735, 3.8428533965849567, 43.484636696164415),
    start_date="2014-09-25",
    end_date="2014-09-27",
)

for scene in scenes:
    earthexplorer_catalog.download(scene["entity_id"], output_dir="XXX")

But I just noticed that the downloaded file is actually "LC08_L1TP_197030_20140926_20170419_01_T1.tar.gz", and contains collection 1 data, even though the IDs landsatxplore returns are:
display_id: LC08_L1TP_197030_20140926_20200911_02_T1
landsat_product_id: LC08_L1TP_197030_20140926_20200911_02_T1
entity_id: LC81970302014269LGN01
landsat_scene_id: LC81970302014269LGN01
Could this be what is causing the error with the CLI command that you used and with EODAG?
I need to check if using collection 1 data causes problem for my usage, even though I requested collection 2 data.

That's it, in your example landsatxplore downloads C1 data which is also downloadable using eodag.
That is because you did not specify a dataset when using  earthexplorer_catalog.download(), and internally the method runs landsatxplore.util.guess_dataset(scene["entity_id"]) which returns landsat_8_c1.
If you try:
earthexplorer_catalog.download(scene["entity_id"], dataset="landsat_ot_c2_l1", output_dir="XXX")

You'll get
landsatxplore.errors.EarthExplorerError: Download is not available

Thank you for your investigation and resolution !


Fix thumbs function

Install Sentry on Thumbs
Fix the bug that Sentry isn't telling us about

After deploying this, will we need to do anything to retrospectively fix thumbnails for leaflets already uploaded, or will this get triggered on the fly?

After deploying this, will we need to do anything to retrospectively fix thumbnails for leaflets already uploaded, or will this get triggered on the fly?

I think there are a couple of bugs going on with thumbnails, but this should fix the majority case just by deploying


NO-TICKET: Simplify linear_chain.

This fixes rustfmt and removes some unnecessary Event variants.
(Found in preparation of NDRS-892.)

bors r+


Do not swallow errors when failing failing to modify a Hub

Start Livebook Teams dev server
Create an org
Disconnect the dev server
While in the org page, try to create secret

No error is reported but it should.

Also note that the page is auto-reloading every X seconds. This has been fixed on #2327.


EVSE example port for Silicon Labs,

Adding support for Silicon Labs EFR32 for the example energy-management-app.
Energy Management example provides a baseline demonstration of a EVSE
device, built using Matter and the Silicon Labs gecko SDK. It can be controlled
by a Chip controller over an Openthread or Wifi network. This example port is self contained and does not alter the underlying behaviour of the energy-management-app or any other non Silicon Labs code within the example/energy-management-app code base.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[DS-6091][standalone] fix StandaloneServer run failed on Windows system

Purpose of the pull request
Fix the bug that StandaloneServer run failed on Windows system.
Brief change log

Fix java.nio.file.InvalidPathException in StandaloneServer

The bug's reason is when we call Class#getProtectionDomain().getCodeSource().getLocation().getPath() on Windows, JAVA will return a path starts with '/', and then we use Paths.get(path) to transform the path, the bug appears.
The solution is use Paths.get(URL url) method to transform the path, it will work correctly.

Fix bug when use "/target/classes" to judge path will always return false.

The bug's reason is use File#getPath.endsWith("/target/classes") to judge if the given path is compiled class path. On Windows, the delimiter of path is '', so the method always returns false.
The solution is use Paths.endsWith(Path other) method to judge, it will work correctly.
resolves #6091

This PR is duplicate with #6101, can you please coordinate with @QuakeWang which PR we should continue?

This PR is duplicate with #6101, can you please coordinate with @QuakeWang which PR we should continue?

I already send an e-mail to @QuakeWang , we will talk later

We have discussed and come up with the following recommendation: This pr retains the changes to DolphinPluginDiscovery. The changes to StandaloneServer are still based on #6101.

I just revert the modification of StandaloneServer.java, now the pr only contains modification of DolphinPluginDiscovery.java. Please do a code review~

@LiuBodong please update the PR title and commit message accordingly

Codecov Report

Merging #6207 (a129b71) into dev (a1e447d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #6207      +/-   ##
============================================
- Coverage     39.07%   39.06%   -0.01%
+ Complexity     3250     3249       -1
============================================
  Files           638      638
  Lines         25266    25267       +1
  Branches       2743     2743
============================================
- Hits           9872     9871       -1
- Misses        14516    14517       +1
- Partials        878      879       +1

Impacted Files
Coverage Δ

...inscheduler/spi/plugin/DolphinPluginDiscovery.java
0.00% <0.00%> (ø)

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e447d...a129b71. Read the comment docs.

already fixed in another pr


training data example

I understanding it is hard to release the full training data. Is it possible to release a training sample so we can follow it on customized data? Thanks!

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

Hello, since the trajectories are extracted using the optical flow model during training, you only need to prepare the videos and text captions following the CogVideo5B format. We will release some examples as soon as possible.

Very interesting idea， why use the optical flow model for extracting trajectories?


Zoom problem

I have split one tab into 4 views.
If I press ctrl +, the selected view will be zoomed in.
But if I press ctrl -, all 4 views will zoomed out.

Why would you want to zoom in and out? What OS?
Can you fill the required information?

windows 10 64 bit
1.1.0(latest release)
I just see that hyper offers this function so have a try.

Can you make a gif?

I would need to see this.

Im experiencing this too, I made a vid: https://drive.google.com/file/d/0BzDvdTnpkF38RkNjM0ZTWlhLN3M/view?usp=drivesdk

I'm also experiencing this behavior. Win10 64 bit, hyper version 1.4.3 (stable).

I would like to take up this issue. Since I am new to this project can you tell me the workflow of the project.

I would like to work on this issue.

After I check the realease stable version (1.4.8) and also the resource code on windows 10 64 bit platform, the issue is already fixed. But the this issue post haven't been closed.


Cannot work past the first screen when starting FreeOTP for the first time

When starting FreeOTP for the first time, I am asked for the backup password. After entering it twice, I cannot proceed, because there is to OK/Next/etc. key visible:

Maybe this is caused by my tiny screen (240×432px)?
Could you please add scrollbars to this (and possible subsequent) screen(s)?

I just ran into the same issue:

@sphh I was able to work around this by setting my system font size smaller in the Android settings.  Still should probably be fixed though.

Hi, yes this needs to be fixed. PRs are welcome. Apologies for the size issue you encountered.

Same issue here :(

@sphh, @Grayknife, @jasom, I don't know if one of you can give it a try with version 2.0.4 now than PR #398 has been merged with one commit trying to fix this issue.

I just installed FreeOTP again. I can get past the first screens, but just:

@sphh, @Grayknife, @jasom, I don't know if one of you can give it a try with version 2.0.4 now than PR #398 has been merged with one commit trying to fix this issue.

I just tried it and it is completely usable on my 480x854 phone, even with text size set to "Medium"

I just installed FreeOTP again. I can get past the first screens, but just:

According to you screenshot, a similar fix should be done for the "Backup and Restore" screen.

@sphh, so the main issue is fixed, right? Let's close this one if so and open a new one for the "Backup and Restore" screen if needed.

It does not look nice, but at least it's possible to somehow click on DONE (or on GET STARTED).
If this is good enough, I can close it.

@sphh, I don't understand what is wrong the de DONE button. Could you please describe what you would expect?

I am used to buttons, where the padding at the top is the same as that at the bottom. In the screenshots shown in https://github.com/freeotp/freeotp-android/issues/349#issuecomment-2182887154, the buttons look like they were cut off at the bottom. Is this intentional?

@sphh, got it. If you are well at the bottom of the scroll view and the button is cut off like this, it is definitely an issue and not intentional.


fix: no longer include untracked files in backup stash

Since v10.1 having untracked files in the backup stash causes revert to fail, because the stash will not apply with the same files already on disk.
Fixes https://github.com/okonet/lint-staged/issues/826

This happens because when reverting, we call git reset, which doesn't touch untracked files. It's now safe to simply not have untracked files in the stash, because nothing touches them (unless tasks do something).

@okonet Travis integration is broken, but you can see that it passed here: https://travis-ci.org/github/okonet/lint-staged/builds/670434608
I'm unable to merge because the button is disabled.

Yeah I don’t know why it’s not working anymore

@okonet  I rebased this on master, since the release job seems to be working. It didn't generate a release because all commits are of ci type.
https://github.com/okonet/lint-staged/runs/561725417?check_suite_focus=true#step:5:59
[8:47:40 AM] [semantic-release] › ℹ  There are no relevant changes, so no new version is released.

So we merge this one and expect a release? Right?

@okonet Yeah, that should be what's happening since these are fix types.

@okonet great success!


pact-jvm-provider-junit5 4.1.x is not released to Maven Central

pact-jvm-provider-junit5 4.1.x is not released to Maven Central: https://mvnrepository.com/artifact/au.com.dius/pact-jvm-provider-junit5
Thanks a lot for adding pending contracts and WIP contracts feature!
Could you please release 4.1.x pact-jvm-provider-junit5 to Maven Central so we can start using them.

The module names have changed. Refer to https://github.com/DiUS/pact-jvm/releases/tag/4_1_0

🤦 yes, I see it now. Thank you!


Testing Helper

Codecov Report

Merging #898 (a7e843a) into master (b8728d5) will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
+ Coverage   74.02%   74.06%   +0.03%
==========================================
  Files         133      133
  Lines       12720    12722       +2
==========================================
+ Hits         9416     9422       +6
+ Misses       3304     3300       -4

Impacted Files
Coverage Δ

assemblyline/common/importing.py
80.00% <66.66%> (-7.50%)
:arrow_down:

assemblyline/filestore/transport/local.py
90.32% <0.00%> (-1.62%)
:arrow_down:

assemblyline/odm/random_data/__init__.py
88.33% <0.00%> (+0.33%)
:arrow_up:

assemblyline/odm/randomizer.py
95.25% <0.00%> (+0.86%)
:arrow_up:

assemblyline/common/heuristics.py
86.95% <0.00%> (+2.17%)
:arrow_up:

assemblyline/datasource/alert.py
92.30% <0.00%> (+7.69%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


new plugin: data-validator

Apache APISIX currently has a very high-performance jsonschema implementation that can be used to validate request parameters or request bodies.
When the verification succeeds or fails, the response specifies the response code to the requesting client.
Here is a mini case:
data_valitator = {
    var = "args_name",
    schema = {
        type = "string",
        minLength = 1,
        maxLength = 32,
        pattern = [[^[\w]+$]]
    },
    fail_code = 400,
}

data_valitator = {
    var = "args_name",
    schema = {
        type = "string",
        minLength = 1,
        maxLength = 32,
        pattern = [[^[\w]+$]]
    },
    succ_code = 200
}

Is it support json schema v4 or v5?

    succ_code = 200

I think we don't need succ_code

Is it support json schema v4 or v5?

support draft4, draft6 and draft7.

related PR: https://github.com/apache/incubator-apisix/pull/1709


contract errors

Any ideas about this?
cleos.sh set contract mandogpigcat ./eosmechanics
./mech_actions.sh
Error 3015014: Pack data exception
Error Details:
Unexpected input encountered while processing struct 'cpu'

On mobile so can’t verify right now but try changing those action inputs from ‘’ to ‘[]’
This was a change in cleos a while back and I think I forgot to update the shell script.

Ah ok


[cli] add alias support for sui addresses in the CLI

Description
This PR adds support for basic alias naming of Sui addresses in the keystore. If an alias is not provided, it will automatically generate a random name as first-second based on a list of predefined strings (adjectives and precious stone gems).
Test Plan
Added tests to ensure new functionality works as expected.
Manual tests:
sui client new-address ed25519 my_alias_test / sui client new-address ed25519

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[x] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes
Added initial support for basic alias naming of Sui addresses in the keystore.

Sorry about that @amnn . I wanted to push it up and then will work on it more. It's a bigger feature than I expected so it will require a bit more iteration! Thanks though for taking a look at it!

No problem, usually it's fine to push it as a draft, I think the issues happen if the PR is ever published!

Thanks @amnn for the suggestions.

I'll need to see the rest of the error message (e.g. why this trait cannot be made into an object) to know for

Here's the error; as per the docs, sign_secure takes a generic type, so this is not an object safe trait.
https://doc.rust-lang.org/reference/items/traits.html#object-safety.

Got it, yep.  So the trick would be to try and make that API use dynamic dispatch as well by changing it to accept a msg: &dyn Serialize.
This may not work because Serialize might not be object safe either, in which case that's time to give up 🥲, but that's what I would try.

My 0.2 cents and trying to rationalize community SDK impacts.
Firstly (pet peeve)
As with the key-pair file they would not be tied to an env (dev,test,etc.). It would have been grand to associate specific keyfiles and aliases to the env alias in client.yaml.
Clarity
If I understand the end result of previous comments, Address may have a 0 or 1 alias association?

Initially, a new config will auto generate an alias?
Keytool will accept an alias on generate, import, load-keypair?
Will keytool also accept on signing?
What about MultiSig?

I see that in 1.16 the alias file is being generated already so I assume as per current schedule we are looking at Jan '24... happy new year!

I will let @stefan-mysten clarify the detailed workings of this feature, but on this point:

As with the key-pair file they would not be tied to an env (dev,test,etc.). It would have been grand to associate specific keyfiles and aliases to the env alias in client.yaml

I think this is something that we'll need to think about more holistically than in the context of just this feature.  Technically speaking, there is no association between a given keypair and a network: People are free to use the same keypair across multiple networks and this is also true in the wallet (the wallet allows users to switch addresses independently of the network).
In practice, people do tend to associate addresses with networks though, so we should discuss whether that is a feature we want to support, but need to be careful about not breaking backwards compatibility for people who do use the same address across multiple networks.

In practice, people do tend to associate addresses with networks though, so we should discuss whether that is a feature we want to support, but need to be careful about not breaking backwards compatibility for people who do use the same address across multiple networks.

Yes, separation of concerns so to speak. Again, pet-peeve.
Notwithstanding the Telegram aspect of 'use at own risk' reading the binary setup config has been as base capability of pysui, there are other options that let dev set RPC URL and private keys (ephemeral). However; aliases (IMO) is a nice feature and of course I'd rather leverage what is sitting there than build something anew.

@stefan-mysten
Following up from Telegram. Here were original questions:

Initially, a new config will auto generate an alias?
Keytool will accept an alias on generate, import, load-keypair?
Will keytool also accept on signing?
What about MultiSig?

And, mapping to your comments in Telegram
General:
Address may have a 0 or 1 alias association?

It shall be 1:1 (error otherwise)

you: Yes
Keytool will accept an alias on generate, import, load-keypair?

You:

Generate does not put the keys in keystore, just puts a file out so this is moot. Not suggesting to add alias to that file.
Load is moot as well
Import puts key into keystore and I gleaned from your response it will take an optional alias, generating one otherwise.

Will keytool also accept on signing?
My clarification on question:  CLI hassui keytool sign --address  <- Will this command take an alias as well?

What about MultiSig? Methinks not on this one ass MS addresses are not persisted
My clarification on question: This is moot as while there is an address associated to a mulisig, the keypair itself is derived from 2 or more normal keypairs and because of that, there is no multisig keypair that goes in sui.keypairs. I must not have had enough coffee at the time I wrote the question

you: That is the plan.

Additional questions: For the alias name itself, are there any constraints there? The obvious is you can't have the same alias name referring to two keys but:

Any length constraints?
Any format constraints?
Any character constraints?

Will keytool also accept on signing?

Now I understand the question, yes, it should be available there too!

For the alias name itself, are there any constraints there? The obvious is you can't have the same alias name referring to two keys but:

Good question. I understand that all sorts of weird stuff can be done when naming things, so here's what I've done. Given that the alias is supposed to make it easier to distinguish addresses, and its main purpose is to aid and simplify the experience for the user when using the CLI, I think a few simple rules are useful here.
The alias must start with a letter and can contain only letters, digits, hyphens (-), or underscores (_). There is no maximum length, but if it is too big it will likely mess the table formatting (will need to revisit that at some point to do automatic wrapping everywhere), so naively, I will hope for now that folks are reasonable with their alias length. I can enforce it later if needed.

Thanks!


Scroll to index

hi, first of all, very happy to use this plugin and it is really easy to implement to my project. but i would like to know, is there a "scroll to index" functionality like after we click on the notification with list item id, i want to scroll my list to the list item.
Thanks in advance.

Hi @KennyChan94P , thank you for your kind words!
You could implement that in the same way you would do it with a regular ListView in Flutter, but using PagedListView instead. I can't point you to a specific approach because there are several, but a quick search on Google or StackOverflow will help you with that.
That functionality is not covered in our docs because it's nothing specific to pagination or infinite scrolling.
Thank you for opening the issue! If you still have any doubts, please chat me.

@brax10ward @EdsonBueno
I've used "scroll_to_index" package but in that case we have to add height on Widget. so how we can set it?
Because In my case I don't know height for every list of widget.
Can you please support us, how we can fix it?


Capstrano should restart bibdata-sqs-poller service

Otherwise when we deploy new poller code it's not refreshed.
The correct permissions should be in place to just add the task to capistrano.

closed by #989

closed by #989


tiny change to emote search modal

made the modal a little bit cleaner by adding an blur so its "easier" to read lol.
trimmed some values in css ( 0.906 -> 0.9 )

Sorry, forgot about this, lgtm, thanks


Fix flaky LDAP tests

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   23.09%   23.09%
=======================================
  Files          53       53
  Lines        2122     2122
=======================================
  Hits          490      490
  Misses       1601     1601
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c01444...67db487. Read the comment docs.


Report dimer RMSD using itables

Description
This PR is a possible alternative to #52 that uses itables for interactive dimer energy reporting.

Status

[X] Ready to go

https://panel.holoviz.org/reference/widgets/Tabulator.html could also be an option:

Woow this is awesome much better than a static output lets take either over #52! Maybe we could include some way to search for dimers as well or maybe even smarts patterns similar to mols2grid?

Maybe we could include some way to search for dimers as well or maybe even smarts patterns similar to mols2grid?

I think that would be awesome but would probably also need something a bit more custom! Given how useful mols2grid is though mols2table would probably be worth it!


ServiceInstance updates are sending an empty body

Testing out ServiceInstance updates and it looks like I'm seeing PATCH requests with an empty body on updates; the request dump from our broker logs:
[2017-10-18T20:32:20.868Z] [INFO] Request: "PATCH /ansible-service-broker/v2/service_instances/08331836-fe2e-44c5-9618-7d79b3f0115d?accepts_incomplete=true HTTP/1.1\r\nHost: asb.ansible-service-broker.svc:1338\r\n
Accept-Encoding: gzip\r\nContent-Length: 2\r\nContent-Type: application/json\r\nUser-Agent: Go-http-client/1.1\r\nX-Broker-Api-Originating-Identity: kubernetes eyJncm91cHMiOlsic3lzdGVtOmF1dGhlbnRpY2F0ZWQ6b2F1dGgiL
CJzeXN0ZW06YXV0aGVudGljYXRlZCJdLCJzY29wZXMuYXV0aG9yaXphdGlvbi5vcGVuc2hpZnQuaW8iOlsidXNlcjpmdWxsIl0sInVpZCI6IiIsInVzZXJuYW1lIjoiYWRtaW4ifQ==\r\nX-Broker-Api-Version: 2.12\r\n\r\n{}"

I can reproduce this by editing the secret referenced by the instance's parameters and incrementing updateRequests.

So in this case, you changed the secret parameters and they weren't sent?

@pmorie yep, I made the change via and oc edit on the cli and saw the new value correctly viewing the secret in the UI.

I think this needs to be fixed for 0.1.0 if at all possible

I verified that there was an issue in rc1. It has been fixed in rc2.

Can this be closed then?