Improve compatibility with default/other syntax themes

[x] Switch default scope to source.text.md
[x] Add a markup-and-down.less resource file to enable quick and easy patching of syntax-themes

[x] Set up framework for generic markup styles
[x] Expand framework with custom markdown styles
[x] Test resource file via minimal-syntax, and add scopes wherever necessary

[x] Test default syntax themes with and without patch
[ ] BUG: markdown-preview doesn't work with the changed base scope; perhaps this can better be solved in that package. (see https://github.com/atom/markdown-preview/issues/384)
[ ] Create patches for default syntax themes

[ ] Atom Dark
[ ] Atom Light
[ ] base16 Tomorrow Dark
[ ] base16 Tomorrow Light
[ ] One Dark
[ ] One Light
[ ] Solarized Dark
[ ] Solarized Light

[ ] Create patches for popular syntax themes

[ ] Monokai (https://github.com/kevinsawicki/monokai/pull/68)

Since this actually handles reference links nicely, I'm working on patching my theme/port of Tubster, but the .less you've provided to aid in patching doesn't seem to line up with what the current scopes are for things. Am I just misinterpreting it?

And i've got my theme up and running with language-markdown, but thanks to an renaming issue, it won't be available as an update until it gets fixed.

Hi @plttn,
The .less that's provided in this branch will indeed only be relevant from v1.0.0, but that might take a while. The biggest issue is that the default themes provided by Atom are all different in structure, and have their markup classes often scoped to gfm for instance. I intend to create PRs for each of these, but they can't break anything, while I want to support more generic styling in them at the same time. If these PRs go through, I'll have to wait until they are included in Atom before I can safely publish v1.0.0 because there's a big chance it will break syntax highlighting. I might finish and release v1.0.0 earlier, but it's a tedious job to check support with syntax-themes. I'm in a bit of a conundrum.
Cool that you're updating tubster to work with language-markdown though. When I have had enough caffeine (just woken up), I'll have a look at your code to see if there's a quick fix possible (which I presume there is). I'll respond in your issue which I hope you'll rename to because language-markdown isn't the bit that's broken... ; )

Hi @burodepeper and @plttn,
Just wanted quickly pop by and tell you I'll soon have some time to see what changes are necessary
for my theme pen-paper-coffee to best make use of language-markdown.
keep up the good work! :)

I can now officially say my theme pubster-syntax just hit v1, with the headlining feature of v1 being language-markdown support.
Thanks to @burodepeper for making a IMO much better markdown grammar than the core one.

Hi @MaximSokolov (and others),
I found a PR of yours a while ago (you recently linked me to this but I remember a much longer discussion) about standardizing scope-names. I found it an interesting topic/issue, wanted to get involved with it initially, but got side-tracked. While working on language-markdown, and this PR in particular, I've come across the problem once again. With help from @simurai (hi there!), I believe that most markup-related scope-names have been moved out off the .gfm scope in the default syntax-themes. I recently noticed that most of them (and probably/logically for every syntax-theme based on them as well) lack support for markup related things at all, or merely provide very limited support. I was wondering (hoping actually) if you (and @simurai and hopefully others) are interested in collaborating in improving this in general, perhaps as a stepping stone for introducing a wider-spread standard for scope-names in syntax-themes in general.
My efforts on this front have been a little stale the last couple of weeks. I got demotivated by the potential scale of trying to really fix the issue at hand, but I believe that a few like-minded people could actually get some stuff realized!
If any of you are interested, I'd like to suggest coming up with a roadmap to tackle the issue first only for markup-related scope names before escalating it to an Atom-wide issue/solution. My efforts so far have resulted in this less-template (section 2 is most relevant). From that I suggest the following plan:

Discuss and draft a specification/documentation for markup-related scope-names. This would result in something similar to the template I linked to above.
Apply this template to all (eight?) default syntax-themes, without breaking any existing styles (if possible). If possible, use the same structure for all themes.
Additionally create a default 'empty' syntax-theme template, which can be extended in the future with all other scope-name conventions etc.

Parallel to this, I will be adapting language-markdown to whatever we're doing, because I try to implement a fallback mechanism when certain markup-elements have a semantical overlap with syntax-elements (a horizontal-rule for instance can be considered a constant of sorts). I have some additional ideas on how scope-names and syntax-theming in general tie together, but I've typed enough for now ; )
I hope I've sparked some interest, and if similar efforts are happening elsewhere, links please!

@MaximSokolov suggested to add an official syntax naming convention to Atom: https://github.com/atom/atom/issues/8430 and the WIP: https://github.com/atom/docs/pull/114. I think it's a great idea, but since there are already hundreds of syntax themes and language packages out there, not easy to change too much. So that PR is more about thinking how it could work for Atom 2.0.
@burodepeper Something I was wondering. How much different is this PR from the language-gfm package? Would it work if themes just add the .md selector at the top?
+ .md,
.gfm {
  // styles
}

@simurai I had already noticed that both those issues you've linked haven't been updated for months. Mentioning you and Maxim here is an (possibly futile/unneccessary) attempt to jump-start it again.
In general, I think the this PR is not about the difference between this package and language-gfm, but rather that the markup styles should be available for any "language" that adds a form of markup. language-hyperlink adds markup (an underline class) for instance, I'm sure there are others. For example, I thought of creating an atomdoc-language kind of thing, that parses comments (which are otherwise "untreated") in any/all language(s). This would use generic markup styles. The .md and .gfm scopes should be used to distinguish, not to constrain.
Perhaps most importantly, I'm trying to figure this out without breaking any backwards compatibility. Removing the .gfm class for instance, didn't break anything. I understand the "Atom 2.0" argument, but at this moment I am very limited in creating any markup related things that I want supported by syntax-themes, unless I use horribly wrong scopes. That is what I meant by the fallback that I'm adding as well. Most elements in the dev-scopes branch have double scopes: one that is purely based on markup, and one that is based on the default scopes that I hope exist in most syntax-themes.
I don't mind doing some heavy lifting, and seeing as there are a little over a thousand syntax-themes currently, I'd even say that it is realistic to suggest changes or perhaps even create PRs for the most-used themes. I'd even dare to say that it is realistic to do this not just limited to markup-related scopes. It needs some coordination, but it's do-able, right? We're talking about creating a template, and a way to distribute it. Or am I completely overlooking something? Again, I don't mind doing some heavy lifting, but it would be nice to have some support beforehand, a few extra braincells to think about things that ought to stand the test of time (with @MaximSokolov's work as a good start), and eventually some help of the Atom team when it comes to communication/distribution.

Sorry, yeah right.. .md and .gfm are more specific language packages. .markup could be used much more broadly for many languages/packages. :+1:

the fallback that I'm adding as well.

With "fallback", do you mean this? It's pretty close to the template currently used for the syntax theme generator and I think also TextMate converter. So the basics should be ok in most themes.
But I just looked at a random (newest) syntax theme and it's scoped to .gfm https://github.com/qolop/shamrock-syntax/blob/master/index.less#L52-L89. Probably a fork of another existing theme. So making a PR like this:
- .gfm {
  .markup {
    // styles
  }
- }

wouldn't be too hard and the theme author will most likely happily accept it. But if we define a completely new template and try to convince theme authors to use it, I can imagine it's a much harder sell. Also, some themes are probably abandoned and the theme author wouldn't care about getting PRs.
Not saying we couldn't improve the current convention already now, and it would be opt-in for those themes that want to use it... just that trying to enforce it, would really need some heavy lifting and hope theme authors play along.

Somehow I still think that moving the (some of the) styling into language packages might be a good idea. So..

Themes would define color variables, like https://github.com/burodepeper/language-markdown/blob/dev-scopes/resources/markup-and-down.less#L1-L17
Themes style only the basics. Maybe just each .variable { color: @variable }. but not more.
Languages packages use the color variables to add more syntax highlighting that is specific to the language, like: https://github.com/burodepeper/language-markdown/blob/dev-scopes/resources/markup-and-down.less#L21-L223
If a theme really wants to, it can override the language package.

Benefits:

Language packages can make changes any time and don't have to wait for another major version with a new naming convention.
Language package authors probably know better what should be syntax highlighted than theme authors. Theme authors don't know every language, but a language package author knows a language very well.

Actually, the https://atom.io/packages/angularjs already tried to do it here, but there aren't any fitting variables to use, see this issue.
The hard part will be to define the variables that make sense for most language packages.

The fallback is in the actual parsing/scopes assigned. This for example is created in side a .markup.link (somewhere else) but is also designated as a string as backup. It's not the best example, but it will give you an idea.

As an approach of moving styles out of the .gfm scope, I would suggest submitting issues to syntax-themes at first. The diff as you suggest it is a small change, and if it comes with a link/reference to a clear explanation as what needs to happen and why (possibly copy-pasted into the issue report), I'm sure most theme authors will be happy to oblige.
I agree that suggesting/enforcing a change of structure isn't the way to go, but I think it would be good for the default themes to implement it, so everything that is forked off of them can take advantage of it. The template you reference is a good start, but I have a feeling that a lot of new themes aren't forked off of that one. If we think of this as a disease we want to spread, we need multiple patient zeroes ; )
Seeing as you are more involved with Atom, do you think it's possible to compile a list of most used syntax-themes by actual usage? It would be good to know the scale of the problem, and how long its tail is (as in "The Long Tail").

Yup, my approach with markup-and-down.less is indeed an intermediary form of what you suggest. But as much as I'd like to discuss that, I think a different place would better suit the discussion.

The hard part will be to define the variables that make sense for most language packages.

My first instincts were that this would indeed be the hard part, but now I think of it again, I think it is actually quite simple. It seems hard, because there's is no apparent overlap between for example html, javascript and css. But if you group languages by type, things become more apparent. Think of the following groups for example:

actual programming languages (c, javascript, ruby, python)
markup related languages (html, markdown)
styling related languages (css)
data-containers (json, yaml)

The concept of a class is not generic of its own accord, but it is generic (to a significant extent) within its group. I think technically, and I'm thinking waaay into the future here, this would mean subdividing the base-class source.
Let's get back on-topic ; )

Speaking of test-cases: I created this PR (https://github.com/kevinsawicki/monokai/pull/68) for the Monokai theme by @kevinsawicki, but it hasn't gotten any attention yet so far. I'm sure Kevin has other things on his mind, and I don't blame him in the slightest (although this is intended as a slight nudge ;), but this could be a good indicator of what we would be working 'against'. On the other side of the spectrum, I would imagine that authors of lesser used themes would be extra motivated by outside interest.

I'm closing/abandoning this attempt. See #52 for some additional details.


(WIP) Add C++ stacktraces

added stacktraces to exception handlers for unit tests

added boost::stacktrace lib target in ext-boost.jam
added pwiz::util::throw_with_trace()
changed most TEST_FAILED macros to TEST_FAILED_EX which just takes the exception instead of the message, and prints stacktrace if present
changed a few global build settings for MSVC to make debug symbols leaner but always present; the PDB files are still really big though: probably too big to distribute to users, so I'm still not sure how to get stacktraces from users

@bspratt you might be interested in looking at this. I'm not really happy with the size of the PDBs so I don't see a way to redistribute this to users, but at least it works for developer builds (or rather, it would if I went through and replaced almost all the throw XXX calls with throw_with_trace).
Probably broken on Linux, let's see.

Any sense of potential download bloat, or possible performance costs, when carrying symbols around? (I like having them, just wondering what the hit might be).
Pure pain:

19M     chainsaw.pdb
36M     idcat.pdb
36M     idconvert.pdb
93M     msaccess.pdb
94M     msconvert.pdb
74M     msdiff.pdb
74M     msdir.pdb
5.6M    msistats.pdb
75M     mspicture.pdb
75M     peakaboo.pdb
7.1M    pepcat.pdb
7.0M    pepsum.pdb
76M     qtofpeakpicker.pdb
103M    pwiz_bindings_cli.pdb
98M     pwiz_data_cli.pdb

The overall size could be greatly reduced by putting everything into libpwiz.dll so there's just one big pdb (although there would still be a separate one for the bindings).

May reopen in the future if I find/settle on a way to make the PDB sizes more manageable.


Can not set IsFocused on AutoCompleteBox in XAML

Hello World,
I am Trying to set the focus on the AutoCompleteBox
Error

System.MethodAccessException: 'Attempt by method 'Poging3.Views.MainWindow.!XamlIlPopulate(System.IServiceProvider, Poging3.Views.MainWindow)' to access method 'Avalonia.Input.InputElement.set_IsFocused(Boolean)' failed.'

I read on an older post that that property is/was Readonly  but the doc's  @ https://avaloniaui.net/api/Avalonia.Controls/AutoCompleteBox/ states:

but there is no such property (in xaml)

Not sure wich one  is wrong.
If you need to know more,  let me know
Regards,
Remco

IsFocused is indeed readonly: see https://github.com/AvaloniaUI/Avalonia/blob/756adb5dd5467ba5f0de000008d4c91009bfb2db/src/Avalonia.Input/InputElement.cs#L347-L351
Not sure why the docs are saying it's read/write. I'm in the process of redoing the docs so hopefully will be fixed soon.
In the meantime, you need to call .Focus() on your control to focus it.

Ah it's just the XML doc comment that was wrong, that has been fixed. Will be fixed on the API reference when I upload the new version.

Top


cleanup: fix typo and remove extra dup words.

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

@htuch PTAL, typos fails our pre-submits.


Copied tests from google-play-scraper and fixed some errors found

Part of #6

Amazing, thanks for this contribution!


Introduce guessed receiver types

Motivation
This PR adds the experiment of guessed receiver types, where we try to guess the type of receivers based on their identifier.
Implementation
The relevant part of the implementation is all in TypeInferrer, everything else is just displaying to users why we picked a certain type.
The idea is to try to guess the types like this:

Take the raw receiver slice
Sanitize that name to be camel case and discard @ symbols
First, try to resolve the name inside the current nesting. If we find something, return that
Otherwise, search for the first type that matches the unqualified name of the identifier

More details in the Markdown documentation.
Validation
I used Spoom's access to the Sorbet LSP to compare the guessed types vs the actual types informed by Sorbet. I also compared 4 approaches:
In the Ruby LSP repo, these are the accuracy results for each approach

First resolve then fallback to unqualified name: 15% of correct types
Unqualified only: 11%
Resolve with nesting only: 9%
Fuzzy search: 2% (in addition to being the worse accuracy, fuzzy search was also unbearably slow)

In Core, the analysis script took way too long to finish, so I sampled a subset of the codebase. The results there were worse than in the Ruby LSP codebase, peaking at about 5% of correct types.
Surely, the level of accuracy will vary a lot between different codebases. That said, I still believe the experiment would be worth the try and would love to hear feedback from users about the usefulness of this.
Script:
# typed: strict
# frozen_string_literal: true

require "spoom"
require "ruby_lsp/internal"

class Visitor < Prism::Visitor
  extend T::Sig

  sig { returns(T.nilable(RubyLsp::Document)) }
  attr_accessor :document

  sig { returns(Integer) }
  attr_reader :total, :correct

  sig { returns(T::Hash[String, T.nilable(String)]) }
  attr_reader :comparison

  sig { params(inferrer: RubyLsp::TypeInferrer, lsp_client: Spoom::LSP::Client).void }
  def initialize(inferrer, lsp_client)
    @inferrer = inferrer
    @lsp_client = lsp_client
    @total = T.let(0, Integer)
    @correct = T.let(0, Integer)
    @document = T.let(nil, T.nilable(RubyLsp::Document))
    super()
  end

  sig { params(node: Prism::CallNode).void }
  def visit_call_node(node)
    receiver_loc = node.receiver&.location
    return super unless receiver_loc

    receiver = node.receiver
    unless receiver.is_a?(Prism::CallNode) || receiver.is_a?(Prism::LocalVariableReadNode) ||
        receiver.is_a?(Prism::InstanceVariableReadNode)
      return super
    end

    hover = @lsp_client.hover(T.must(@document).uri.to_s, receiver_loc.start_line - 1, receiver_loc.start_column)

    if hover
      hovered_type = if /returns\((.*)\)/ =~ hover.contents
        T.must(T.must(hover.contents.match(/returns\((.*)\)/))[1])
      else
        hover.contents
      end

      return super if hovered_type == "T.untyped" || hovered_type == "T::Private::Methods::DeclBuilder"

      loc = T.must(node.message_loc)

      node_context = T.must(@document).locate_node(
        {
          line: loc.start_line - 1,
          character: loc.start_column,
        },
        node_types: [Prism::CallNode],
      )

      type = @inferrer.infer_receiver_type(node_context)

      @total += 1

      if type
        parts = type.split("::")
        parts.reject! { |e| e.include?("<Class:") }
        corrected_type = parts.join("::")

        if hovered_type.include?(corrected_type)
          @correct += 1
        end
      end
    end

    super
  end
end

index = RubyIndexer::Index.new
index.index_all

inferrer = RubyLsp::TypeInferrer.new(index)
workspace_path = Dir.pwd

client = Spoom::LSP::Client.new(
  Spoom::Sorbet::BIN_PATH,
  "--lsp",
  "--enable-all-experimental-lsp-features",
  "--disable-watchman",
)
client.open(workspace_path)

begin
  visitor = Visitor.new(inferrer, client)
  files = Dir.glob("#{workspace_path}/**/*.rb")
  RubyVM::YJIT.enable

  Signal.trap("INT") do
    puts "Total: #{visitor.total}"
    puts "Correct: #{visitor.correct}"
    puts "Accuracy: #{100 * (visitor.correct.to_f / visitor.total)}"
    client.close
    exit
  end

  files.each_with_index do |file, index|
    document = RubyLsp::RubyDocument.new(
      source: File.read(file),
      version: 1,
      uri: URI::Generic.from_path(path: File.expand_path(file)),
    )
    visitor.document = document
    Prism.parse_file(file).value.accept(visitor)

    print("\033[M\033[0KCompleted #{index + 1}/#{files.length}")
  end

  puts "Total: #{visitor.total}"
  puts "Correct: #{visitor.correct}"
  puts "Accuracy: #{100 * (visitor.correct.to_f / visitor.total)}"
ensure
  client.close
end

Automated Tests
Added tests.
Manual Tests
Type any existing class name as a variable. After typing a dot, you should see completion options for that type (e.g.: pathname.).

Another thing we could do, especially for the benefit of tests, is to match on a type name followed by a number, e.g. product_1.

Do you think we're able to package the script into a flag, like ruby-lsp --report-guess-type-accuracy? (return early if spoom is not available)
It will help us continuously evaluating this feature in the future, and we can ask some community users who also use Sorbet to give us result too.


Support more Websphere traditional classloaders

Thanks to @RaimondKempees for the patch (cherry-picked from #134).

@lukehutch, not sure if I did it right this time...


Prepare for Sprint Demo 2/3 - Nektaria

[x] Create Slides
[x] Make talking points

Presentation are good, cover the necessary parts.


[DOM] Adding an arrow padding alters the offset of the floating element.

I might do something wrong here but when adding a padding to my arrow I realize that the offset of the floating element is modified (increased).
So it appears when I have a bottom-end placement, when middlewareData.arrow has a positive centerOffset, but in my case there is no reason why the arrow couldn't be centered to the reference element.
I  also saw the same behavior with an alignmentOffset and not a centerOffset.
To Reproduce
To show you here is how it looks like with this config:
    placement: 'bottom-end',
    middleware: [
      offset(11),
      shift({ padding: 5 }),
      flip(),
      arrow({
        element: arrowEl.value
      })
    ]

If I just add a padding to the arrow here like so:
    placement: 'bottom-end',
    middleware: [
      offset(11),
      shift({ padding: 5 }),
      flip(),
      arrow({
        element: arrowEl.value,
        padding: 5
      })
    ]

As you can see the offset of the floating element has changed whereas there is no collision.
Maybe it needs some computation from my end here but I don't feel it should behave like that.
I'm sorry I tried to make a codesandbox to make it more clear for you but I get an error when importing arrow from @floating-ui/dom, whereas I updated @floating-ui/dom to the latest version..
Expected behavior
Adding a padding to an arrow should not alter the offset of the floating element.
Thanks a lot for your clarifications.
Context:

OS: Arch
Browser Firefox
Version 1.5.3

The floating element's alignment axis coordinate can get adjusted if the arrow can't point toward the center with a perfect edge alignment, but not the side axis coordinate.
I don't know why the main/side axis offset increases in your example, and I can't see the actual bounding box of the reference element in your screenshots. A reproduction is necessary here (maybe try Stackblitz instead of CodeSandbox).
To be clear, the code that changes the floating element's alignment offset is here:
https://github.com/floating-ui/floating-ui/blob/fbc2cb170caa85f9931d8b432f61b102a2c4edc1/packages/core/src/middleware/arrow.ts#L108
But axis = getAlignmentAxis(placement), which should never cause the side offset to change.

Thank you for this quick fix!!


Refactor datafile iterator

What changes were proposed in this pull request?
Merge 2 similar code path.
How was this patch tested?
Existing tests.

I don't think we should merge two API into 1, it's semantics are not clear, iterator represent full table scan and iteratorWithRowIds represent read data by rowids, in the past iteratorWithRowIds will return Iterator.empty directly if rowids is empty, but now it will do full table scan, and If I do not judge rowids.isEmpty, and then call iterator , How can I achieve the same goal?

Thanks @LuciferYang , I think you are right, this change will produce ambiguity. I originally want to reduce a nested calling (iterator -> buildIterator), but it seems we'd better not. : )


Documentation for checked shifts is misleading

Excerpt from the CheckedShl trait:
///Performs a left shift that returns `None` on overflow.
pub trait CheckedShl: Sized + Shl<u32, Output=Self> {
    /// Shifts a number to the left, checking for overflow. If overflow happens,
    /// `None` is returned.
...
    fn checked_shl(&self, rhs: u32) -> Option<Self>;

The current wording seems to imply that if bits are shifted past the integer's range, then None is returned. This is not the case, the primitive checked_shl explicitly documents this:
        /// Checked shift left. Computes `self << rhs`, returning `None`
        /// if `rhs` is larger than or equal to the number of bits in `self`.
...
        #[stable(feature = "wrapping", since = "1.7.0")]
        #[inline]
        pub fn checked_shl(self, rhs: u32) -> Option<Self> {
            let (a, b) = self.overflowing_shl(rhs);
            if b {None} else {Some(a)}
        }

None is only returned if rhs is larger than the number of bits in the numeric type.
E.g.
0x88u8.checked_shl(4) == Some(0x80)
0x88u8.cheched_shl(8) == None

Right, it's an overflow in the number of bits being shifted, regardless of the value involved.  Would you like to send a PR to clarify this?


Successful LUCI builds not updated in build dashboard

The build dashboard is currently red the tip of tree https://github.com/flutter/flutter/commit/9817cabf8810a7e15d455502cd17aaca8fa4667a has many grey (queued) boxes, and on the previous commit those tasks were purple. However, when clicking through to the milo dashboard, the builds actually finished successfully over an hour ago. Some examples:

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac build_aar_module_test/1393/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac module_host_with_custom_build_test/1385/overview
https://ci.chromium.org/p/flutter/builders/prod/Linux plugin_test

Moving as P1 as the symptoms were fixed but will keep this bug open to revisit the code we are using to cache builds and process new build state.

Moving as P1 as the symptoms were fixed but will keep this bug open to revisit the code we are using to cache builds and process new build state.

This has been an issue for a long period of time a few months from the data we have checked. The root cause is we are putting a lot of pressure on the buildbucket grpc endpoints and they are failing very frequently.
The result of this problem is results are not updated frequently enough in the flutter dashboard causing the tree to be closed for hours even though the builds have already been retried and they passed.

This has been an issue for a long period of time a few months from the data we have checked. The root cause is we are putting a lot of pressure on the buildbucket grpc endpoints and they are failing very frequently.
The result of this problem is results are not updated frequently enough in the flutter dashboard causing the tree to be closed for hours even though the builds have already been retried and they passed.


⬆ Update to .NET Core 3.1

Update AdonisUI and AdonisUI.ClassicTheme to .NET Core 3.1
Add the new PackageIcon property. See https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#packageiconurl

Thanks for the contribution.
However, I am not sure if increasing the framework version should be done.
Doesn't this drop support for .NET Core 3.0 Apps? My understanding was that the lowest supported version should be targeted. If a dependent project targets .NET Core 3.1 it can use the library already.

Most projects already did the update. I think it's safe to go.
https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/blob/86ce490efa87fb8b7071ccaf7173f64668bea2fe/MaterialDesignThemes.Wpf/MaterialDesignThemes.Wpf.csproj#L4
https://github.com/reactiveui/ReactiveUI/blob/6acfcb3ea20c63d1f6c02a3d7db242df478b18c5/src/ReactiveUI.Wpf/ReactiveUI.Wpf.csproj#L3

What exactly is the advantage of increasing the version?
Loosing support for .NET Core 3.0 would be a disadvantage so there should be an equally large or larger advantage to compensate the loss.
I'm sorry if this sounds ungrateful in any way. That is not intended.
I see that some projects changed the version while others included both versions. I just want to understand what implications this brings and why.

.NET Core 3.0 has already reached EOL 5 months ago. .NET Core 3.1 is a LTS release and will be supported by Microsoft for 3 years. I see no point of continuing the support for an EOL version.

Even though it might have reached EOL there might be users who build on Core 3.0. It should not be the responsibility of this library to make those users upgrade. .NET 4.5 has reached EOL as well and still MaterialDesignInXamlToolkit (which you linked) supports it. That's because it is the lowest version the library can support. If users want to go with an EOL version they need to live with the implications. But it is not on me to take away their tools.
That changes of course when there is a need or an advantage to drop support for Core 3.0. But currently I don't see any because you can use the library with Core 3.0 and Core 3.1 just fine.
It would make sense to include netcoreapp3.1 as well if this makes any difference for a depedent project which targets .NET Core 3.1. Up until now, I couldn't find any proof that this is really the case though. But I'm okay with including it anyway. Mostly because most other libraries do so as well, so maybe there is a reason I just missed.


[lua] support lua 5.2 and 5.3

Some deprecated function and datatypes are substituted by macro and typedefs.
It should work with lua 5.2 and 5.3

Coverage remained the same at 100.0% when pulling 372ede82d147f403bcaac1679acbf6e564a6c9ad on y-stm:master into b519487c206d2874607f9612d13c0580b7ae1299 on tarruda:master.

@y-stm maybe rebase this into into a single commit.
@tarruda any chance we can get a tagged release that supports luad 5.2/5.3  We are running into problem when building neovim in systems that lack packages for lua5.1 and this would be pretty useful.

@y-stm maybe rebase this into into a single commit.

Yesterday I was in a bit of rush and only saw the diff, not that it was split into 3 commits. I have fixed history in master but had to force-push. Will not happen again(enabling branch protection)


drop usbarmory

The kernel has not been updated in ages (since 2016) and the used cached is
no longer reachable. Hence I assume this is no longer used. cc @ehmry

related to https://github.com/NixOS/nixos-hardware/issues/352

fixes https://github.com/NixOS/nixos-hardware/issues/352


[Style] : Work Over Navbar Style & Font

What's the style idea?
We need to improve the Color of Navbar & Uniformity.

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

This part of the project please assign it to me under GSSOC-24.

i want to do the this task please assign this task to me

@Rakesh9100    I want work on this issue please assign me this issue under GGSOC'24

Provide the supporting screenshots for your issue @prafulnigam


Pods are always recompiled

https://github.com/jbender/cocoapods-bugs
$ rake pod:install
... actually installs pods, generates Pods project ...
$ rake
... see pods compile ...
$ rake pod:install
... nothing changes, including Podfile.lock, but still generates Pods project ...
$ rake
... see pods compile again ...

This is not bug.
By rake pod:install, the time stump of installed files will update and need to re-build.


fix replace prefix logic for infill prompt

noticed this issue while looking at the case issue
This PR fix replacement logic we use for the infill prompt, previously (my bad) we remove the tail from the prefix to reserve the spacing, but this could remove the same code from the earlier part of the prefix.
Example:
We removed the // from earlier part of the code, so it looks incorrect in the request we send to cody, causing cody sometimes reply with unhelpful suggestion

this change makes sure only the last match is removed
Test plan

now it can generate correct suggestions

@tjdevries FYI this is where I update the prompt for the infill mode for claude.


New org: Fund for Alignment Research

https://alignmentfund.org/
https://www.greaterwrong.com/posts/hGE3Pcc7qmK75bjhc/introducing-the-fund-for-alignment-research-we-re-hiring

Ready. Check https://github.com/riceissa/aiwatch/commit/81a8ab156b2bff503b8480c7c320115d3bf7863c


error in ne.nexis_rtf_extract

I get this error:
----> 2 nu_data = ne.nexis_rtf_extract(nu_file)
~\Anaconda3\envs\viper\lib\site-packages\news_extract\news_extract.py in nexis_rtf_extract(nex_rtf)
123         body_end = [n for n,i
124                     in enumerate(nex_split)
--> 125                     if i == "Classification"][0]
126         body_text = " ".join(nex_split[body_start:body_end])
127
IndexError: list index out of range
I followed your instructions for downloading nexis uni

Are you using articles with languages different from english?

Gonna need your data file for that... lol I know it's pretty late, but if you're still interested, I'll take a look.


strange in datasets/coco.py

hello, I am not sure the what I meet is a bug or an unsafe operation.
the situation reproduce:
from pycocotools.coco import COCO
co4 = COCO('test.json')  # coco sample dataset from here:test.zip
print(co4.cats)
# output: {1: {'id': 1, 'name': 'pallet1', 'supercategory': ''}, 0: {'id': 0, 'name': 'pallet1_support', 'supercategory': ''}}
print(co4.get_cat_ids(('pallet1_support', 'pallet1')))
 # output:[1, 0]
the second output is wrong and should be [0, 1]. I meet this problem when I use mmdet/datasets/coco.py in function load_annotations(), self.cat_ids = self.coco.get_cat_ids(cat_names=self.CLASSES) . And it cause the structure of network result not correct.
So I check source code of get_cat_ids in mmpycocotools and find the source code below:
def get_cat_ids(self, cat_names=[], sup_names=[], cat_ids=[]):
return self.getCatIds(cat_names, sup_names, cat_ids)
def getCatIds(self, catNms=[], supNms=[], catIds=[]):
...
cats = self.dataset['categories']
cats = cats if len(catNms) == 0 else [cat for cat in cats if cat['name'] in catNms]
ids = [cat['id'] for cat in cats]
return ids
it seem that the sequence depended by the cats not by catNums.
at last, I change the code in my mmdet/datasets/coco.py
self.cat_ids = []
for class_name in self.CLASSES:
class_id = self.coco.getCatIds([class_name])[0]
self.cat_ids.append(class_id)

Please @xvjiarui have a check on the mmpycocotools.

Hi @bladesaber
It is the desired behavior of the original pycocotools.


Installation via Composer doesn't work

On a fresh install of Ubuntu 14.04, php5, and Composer, running:
composer require league/markua

Results in
InvalidArgumentException
Could not find package league/markua at any version for your minimum-stability. Check the package spelling or your minimum stability.

I can't find any Markua packages on Packagist either.

I have ran into the same problem

The library doesn't seem to be registered on Packagist: https://packagist.org/search/?q=dshafik%2Fmarkua

This package should probably be renamed to dshafik/markua and then published on Packagist.  Installation instructions would also need to be updated.


Only the 3.0.1 version is possible to install from PyPI.

The versions: 3.0.4, 3.0.5 and 3.0.6 throws errors as below:
poetry install --no-root
Installing dependencies from lock file

Package operations: 1 install, 0 updates, 0 removals

  - Installing shuttleasgi (3.0.6): Failed

  RuntimeError

  Unable to find installation candidates for shuttleasgi (3.0.6)

  at /usr/local/Cellar/poetry/1.8.2/libexec/lib/python3.12/site-packages/poetry/installation/chooser.py:74 in choose_for
       70│
       71│             links.append(link)
       72│
       73│         if not links:
    →  74│             raise RuntimeError(f"Unable to find installation candidates for {package}")
       75│
       76│         # Get the best link
       77│         chosen = max(links, key=lambda link: self._sort_key(package, link))
       78│

Cannot install shuttleasgi.

How is it with 3.0.7? Same issue?

@BertKiv Issues resolved, try with newest versions >=4.0.0


Bring typed continuations up to date

This patch brings the typed continuations branch up to date with the recent changes to upstream/main, effect-handlers/function-references, and patch effect-handlers/wasm-tools/pull/42.

We won't merge this patch via the GitHub interface, rather, I will force push it into the typed-continuations branch once the function-references is merged into upstream.

I just forced pushed.


v0.1

설명
관련 이슈

resolved #이슈넘버

기타(스크린샷 등)

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d899979). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage          ?   39.62%
=========================================
  Files             ?       29
  Lines             ?      265
  Branches          ?       47
=========================================
  Hits              ?      105
  Misses            ?      123
  Partials          ?       37

Flag
Coverage Δ

#client
39.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


[FEATURE] UX: Improve on pagination

Description
The current pagination solution #52, resets the scroll position after new uploads and does not make provision for updates for existing uploads.
We need to fix this issue for updates to the existing uploads.
Screenshots
No response
Additional information
No response

right! I will assign it to you

Opening this issue for KWOC

I want to work for on this issue under jwoc , please assign me

You can be assigned to only one issue at a time, finish the assigned issue first. Thank you

Please assign me this issue currently i am completed my all so i am free for this so please assign me this issue

I would like to work on these issue under GSSoC 2023

new uploads and does not make provision for updates for existing uploads.

I think You've already been assigned an issue, Please work on one issue at a time.
Regards

Also, to anyone reading this, This issue is not confirmed yet, Will update this issue soon.


Investigate how deployment-splitter, ingress-controller, etc. fit into the bigger transparent multi-cluster picture

Spawned from https://github.com/kcp-dev/kcp/pull/537#issuecomment-1047529564.
Until/unless #537 merges, the deployment-splitter is in direct conflict with the namespace scheduler, as the former expects the root deployment to remain unscheduled to a physical cluster, and the latter expects to schedule everything to a physical cluster.
Additionally, there is currently a hack in the namespace scheduler to ignore ingresses, which allows the ingress-controller to function without conflict.
#537 is a temporary fix to allow users to use both the deployment-splitter and the namespace scheduler together. However, for the long term, we want to explore and investigate patterns, use cases, designs, etc. for how controllers such as deployment-splitter and ingress-controller fit into transparent multi-cluster.
Desired outcome: a document detailing the research, with specific features to be implemented (filed as issues).

Clearing milestone to re-triage

Going to close & replace with subtasks/new issues related to the syncer virtual workspace. @davidfestal could you please do that?


Hot reload broke on all version later than 2.7.0-beta.0

Describe the bug
I've been staying on vite v2.6.13 for half a year now, because if I upgrade to any of the later versions, hot reload would break for me. I'm using react.
The symptom is, when I make any change, no matter how tiny, the whole app reloads, and all states are lost.
The breaking happened between v2.6.13 and v2.7.0-beta.0, here's the change log between these two versions, I don't know what was the cause:
2.7.0-beta.0 (2021-10-28)
Bug Fixes:

add import support to ssrModuleLoader (#5197) (baba1f9)
consider # as a valid dir symbol (fix #4701) (#4703) (52689c8)
do not overwrite pendingReload promise (fix #5448) (#5452) (cc9c2da)
exclude dependency of optimized dependency (fix: 5410) (#5411) (ebd4027)
missing tags inject fallback (#5339) (3c44ac8)

Features

server.fs.deny support (#5378) (1a15460)

2.6.13 (2021-10-27)
Bug Fixes

css: ?inline cannot self-accept (#5433) (d283d9b)

Reproduction
My app was initially an SPA created with the typescript react template. I've since made thousands of commits upon it, so I'm not sure how to create a reproduction. But if someone can point some directions for me, I'm happy to provide more info.

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Solved by replacing @vitejs/plugin-react-refresh with @vitejs/plugin-react.


[Question]: callback handlers in workflow

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
With the new worflows, how do we integrate callbackhandler such that the handler knows which step of workflow is getting executed.

@dosu this is fine. But I want to replicate what callbackhandler used to achieve. A common code outside of workflow which can know what is going on across different workflows and steps, along with unique event_id

@dosu
So, can I access context in somewhere class other than Workflow? How to use it


What causes cordovarduino crash ?

serial.registerReadCallback (success = (data) ->

    _data = new Uint8Array data

    ($ '#debug').append JSON.stringify _data

its just simple code to register read callback and receive data but crashed.

@tobeee yes good point, I take care of this.


Mois 44 GitHub actions

Set up and configured Cypress for NextJS.
GitHub Actions also set for cypress with a sample test testing firebase access and writes already committed to main.
After this PR, we are able to write E2E, component tests using Cypress.

Thanks for the review, yup did see it on the way and now that you mention it, makes sense to implement it so will do so!

cypress-firebase library causing too many problems, tests can be written without the ability to bypass Firebase authentication.


Within NOTICE.md update the owner of the registered trademark from "papiNet GIE" to "Papinet SNC"

Within the file NOTICE.md, we should replace the text
_papiNet® is a registered trademark of IDEAlliance on behalf of a global partnership between AF&PA, IDEAlliance, and papiNet GIE._

into
_papiNet® is a registered trademark of Papinet SNC._

Done, see commit fe6c029.


port --secret and --ssh support

This PR resolves #198
The current implementation of img build does not support --secret and --ssh arguments nor accept RUN --mount=... instruction.
These features are now in GA since docker 20.10 and would be a great addition to img
This work is largely inspired from:

https://github.com/moby/buildkit/blob/master/cmd/buildctl/build.go
https://github.com/docker/cli/blob/master/cli/command/image/build_buildkit.go

Few comments about this work:

moby/buildkit must be built with tags dfrunmount dfsecrets dfssh for --secret and --ssh support
A private key has been added for TestBuildSsh. I'm not sure if this was the best way to make a unit test for --ssh

References:

https://medium.com/@tonistiigi/build-secrets-and-ssh-forwarding-in-docker-18-09-ae8161d066
https://medium.com/nttlabs/docker-20-10-59cc4bd59d37

Would it be possible to support id=git,env=PASSWORD as well?


Create ebpf.md

Describe your changes
Localize eBPF in German
Related issue number or link (ex: resolves #issue-number)
resolves #2533
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Closing this PR in favor of https://github.com/cncf/glossary/pull/2605#issuecomment-1817465624.


Sonoff 3.5.2 does not connect to devices

I loaded the latest version of sonoff 3.5.2 then restarted.
Does not connect to any devices.
I have 21 devices.
Using:
Home Assistant 2023.8.1
Supervisor 2023.07.1
Operating System 10.4
Frontend 20230802.0 - latest

After restart of home assistant it has found all 24 devices but all devices connected to repeater wife are unavailable.

Might be related to #1211

hello
what is happening is that when restarting the router another ip is assigned to the sonoff device.
SonoffLan is not downloading the new assigned IP.
this Scan is not happening "scan_interval: '00:01:00'"
In one of the devices I managed to put the old IP, and it becomes available

Deleted SonoffLan integration, re-added and works! :)

Show device diagnostics

Helô
I re paired the devices with ewlink then restarted sonoffLan and it worked.
I am not sure what is causing it but it seems to hapening only to devices connected to repeaters.
It is resolved for now.
Thank you
Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: Alex X @.>
Sent: Sunday, October 15, 2023 3:11:37 PM
To: AlexxIT/SonoffLAN @.>
Cc: RMLReis @.>; Author @.>
Subject: Re: [AlexxIT/SonoffLAN] Sonoff 3.5.2 does not connect to devices (Issue #1213)
Show device diagnostics
—
Reply to this email directly, view it on GitHubhttps://github.com/AlexxIT/SonoffLAN/issues/1213#issuecomment-1763401563, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXJ2O4L7UXOGMBGPHFR7FVDX7PVJTANCNFSM6AAAAAA3FGGZ2Y.
You are receiving this because you authored the thread.Message ID: @.***>


This regex is broken by design

Test it against the following data set, it will pass some non-conforming strings and fail to pass some that are conforming.
1.2.3----RC-SNAPSHOT.12.9.1--.12
1.0.0+0.build.1-rc.10000aaa-kk-0.1
99999999999999999999999.999999999999999999.99999999999999999
Begin Invalid
1
1.2
1.2.3-0123
1.2.3-0123.0123
1.1.2+.123
+invalid
-invalid
-invalid+invalid
-invalid.01
alpha
alpha.beta
alpha.beta.1
alpha.1
alpha+beta
alpha_beta
alpha.
alpha..
beta
1.0.0-alpha_beta
-alpha.
1.0.0-alpha..
1.0.0-alpha..1
1.0.0-alpha...1
1.0.0-alpha....1
1.0.0-alpha.....1
1.0.0-alpha......1
1.0.0-alpha.......1
01.1.1
1.01.1
1.1.01
1.2
1.2.3.DEV
1.2-SNAPSHOT
<IP_ADDRESS>.3----RC-SNAPSHOT.12.09.1--..12+788
1.2-RC-SNAPSHOT
-1.0.3-gamma+b7718
+justmeta
9.8.7+meta+meta
9.8.7-whatever+meta+meta
99999999999999999999999.999999999999999999.99999999999999999----RC-SNAPSHOT.12.09.1--------------------------------..12
See semver/semver/issues/59.

@issuehunt has funded $70.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

I can't any fault with the regex itself other than it is giving true for  some wrong versions  because of \b present in the start and end (regex only matches the correct part but using .test() would return true https://regex101.com/r/sezmjS/2 )  Apparently it was used instead of ^ and $ so that people can use functions like match and exec. Using the same regex for test and other functions doesn't appear to be possible. I am sorry if I've failed to understand something. Do correct me if I have.

@ammarbinfaisal, just try testing it against the test data I posted.  It can't possibly work because it does not properly take into account, all of the SemVer rules.  It is one of many dozens of naive SemVer regex's.

@sindresorhus has rewarded $63.00 to @stroncium. See it on IssueHunt

:moneybag: Total deposit: $70.00
:tada: Repository reward(0%): $0.00
:wrench: Service fee(10%): $7.00


[Dialog] Cannot override styles

[x ] I have searched the issues of this repository and this could be a duplicate of https://github.com/mui-org/material-ui/issues/841.

Current Behavior
Expected Behavior

              <Dialog
                        title='Make transaction'
                        modal={false}
                        open={this.state.open}
                        onRequestClose={this.handleClose}
                        actions={<RemoteSubmitButton handleClose={this.handleClose}/>}
                        contentStyle={{width: '95%', maxWidth: '1400px'}}
                        bodyStyle={{maxHeight: '250px', overflowY: 'auto'}}
                        style={{marginTop: '-200px', paddingTop: '100px'}}>

                        <div />

                </Dialog>

With style attribute of Dialog I want to set the style of the root element.
The marginTop attribute is set but paddingTop is not, instead internal paddingTop is used and cannot be overriden with style={{}}.
I should be able to override the styles of dialog.
Your Environment

Tech
Version

Material-UI
v0.19.4

@croraf We're focusing on the v1-beta branch. Style overriding is much improved there. Since Dialog is migrated, I'm closing this issue, but if you would like to submit a PR to improve this on the master branch, feel free.


Can't use /world create

https://gyazo.com/c873eb89e56ff43d79dfe5c01f3acc11  this is what it tells me

Some of those commands listed aren't in this plugin, which makes me believe another plugin is overriding the /world command. Do you have EssentialCmds installed?

Ya I actually took it out and it works. But, now I feel I messed up my
server trying to import an older world. Something to do with the .lock
http://pastebin.com/Eqr31cd7
On May 23, 2016 6:07 PM, "trentech"<EMAIL_ADDRESS>wrote:

Some of those commands listed aren't in this plugin, which makes me
believe another plugin is overriding the /world command. Do you have
EssentialCmds installed?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/trentech/ProjectWorlds/issues/15#issuecomment-221122177

Closing as command conflict


Release of v19.0.0-RC2

This release is scheduled for Tue  6 Feb 2024
Prerequisites for Release

[x] Notify the community on Slack.
[x] Make sure the release notes summary is prepared and clean.
Make sure important Pull Requests are merged, list below.

[ ] #275

Make sure release blocker Issues are closed, list below.

Pre-Release

[x] Code Freeze.

https://github.com/frouioui/vitess/pull/270

[x] Create Release PR.

https://github.com/frouioui/vitess/pull/273

[x] Update vitess-operator Golang version.

Release

[x] Merge the Release PR.

https://github.com/frouioui/vitess/pull/273

[x] Tag the release.

https://github.com/frouioui/vitess/releases/tag/v19.0.0-rc2

[x] Create vitess-operator Release PR.

ps://github.com/frouioui/vitess-operator/pull/6
ps://github.com/frouioui/vitess-operator/releases/tag/v2.12.0-rc2

[x] Update release notes on main.

https://github.com/frouioui/vitess/pull/274

[x] Go back to dev mode on the release branch.

https://github.com/frouioui/vitess/pull/275

[x] Update the website documentation.
[x] Make sure the release is benchmarked by arewefastyet.
[x] Docker Images available on DockerHub.

Post-Release

[x] Notify the community on Slack for the new release.
[x] Twitter announcement.
[ ] Close this Issue.

Release completed.


Research specifc to Deep RL in education

This issue is related to documentation on Deep RL efforts specific to education or a learning platform domain.

Some resources

https://people.eecs.berkeley.edu/~reddy/files/DRL_Tutor_NIPS17_MT_Workshop.pdf


Use a different soundfont similar to a cello

Went with viola but cello is still configurable from config/base.js


[Feat] refactor all tinymce module

Hello, fellows.
Long ago I've created task #160 to switch this module to new tinymce, and mostly I just want to entire refactor this old code.
Some results:

switch to minified cdn version of tinymce (no need in bunch of static)
remove almost all views from tinymce (especially, gzip_compressor)
add some base selenium tests

@Natim can you check this please, I've divided commits and almost all 90k is in first commit (:

How do you plan on doing it? The diff is totally unreadable

is there a use case where bundling static files is required?
do custom plugins work w/ cdn version or is local/static bundling required?
what will stop working after the upgrade?

@vanadium23 @Natim except for the commit which removes static/media files, other diffs per commit are readable

other diffs per commit are readable

Ok thanks for the tip :)

Depending on the use case you cannot load files from the CDN (notably use cases where you don't have internet access while using your Django app)
I think the idea is good for some usecases but I feel like this should be a new project and a new way of handling tinymce setup.

@aljosa

is there a use case where bundling static files is required?
Only if company is filtering traffic to network, but you can set to local by setting TINYMCE_JS.
do custom plugins work w/ cdn version or is local/static bundling required?
Yes, they work.
what will stop working after the upgrade?
Filebrowser, spellchecker, may be other. I think we need some pre-release build. I don't know all usecases, but ask couple of friends to upgrade to unstable version and they say it's fine.

@Natim

Depending on the use case you cannot load files from the CDN (notably use cases where you don't have internet access while using your Django app)
Okay, we can put local minified file and add to docs how to change to local version. Is this good? I don't like idea of separate package, that does same thing.

we should release a django-tinymce version w/ tinymce4 support.
the problem seems to be how to define what should be included and how the new version should work.
having CDN url and bundling static files should be supported, we need configuration/settings suggestions.
i wouldn't mind if, by default, CDN is used. it would allow all new users to use tinymce4 w/o any staticfiles/collectstatic/deployment issues.
by default, w/o configuration, it should just work.
we just need a flexible way to allow developers w/ specific requirements to modify tinymce4 location/url and configuration.

I guess if people can server tinymce4 from there staticfiles and defaulting to CDN it would be good enough.

Fair enough, add minified static from tinymce.com for version 4.5.2.
We need to make some shell script for automatic upgrade bundled static.

I though we had some script to do so, I also created a script to make sure the encoding of all static files was in UTF-8.

Okay, may be merge & wait for feedback?

@Natim @aljosa fellows? (:

Do you plan on dropping support for tinymce3 ?

hey @vanadium23, we also need to update the docs and update the readme so that people know that the old version is not supported (and howto install the old version and use a fixed version in requirements.txt).
I would like to try this branch in at least 2 projects before we replace the old, tinymce3 based, version.
I understand that you'd like to push this release asap but it could have unwanted consequences since a lot of people are using the current version.
That would be bad and the complaints would undo the great work you did on supporting tinymce4.
I think the next steps should be:

[ ] update the readme/docs to reflect the changes. configuration for tinymce4 changed, users should be able to configure django-tinymce using instructions on https://www.tinymce.com/docs/configure/integration-and-setup/
[ ] figure out if we can release django-tinymce v3.0 (dev/beta/etc.) but when somebody uses $ pip install django-tinymce it should install the current v2.x version

@Natim @vanadium23 also, we should figure out the workflow for supporting tinymce3 and tinymce4 until it's clear that support for tinymce3 is no longer required

hey @vanadium23, we also need to update the docs and update the readme so that people know that the old version is not supported (and howto install the old version and use a fixed version in requirements.txt).
I would like to try this branch in at least 2 projects before we replace the old, tinymce3 based, version.
I understand that you'd like to push this release asap but it could have unwanted consequences since a lot of people are using the current version.
That would be bad and the complaints would undo the great work you did on supporting tinymce4.
I think the next steps should be:

[ ] update the readme/docs to reflect the changes. configuration for tinymce4 changed, users should be able to configure django-tinymce using instructions on https://www.tinymce.com/docs/configure/integration-and-setup/
[ ] figure out if we can release django-tinymce v3.0 (dev/beta/etc.) but when somebody uses $ pip install django-tinymce it should install the current v2.x version

@Natim @vanadium23 also, we should figure out the workflow for supporting tinymce3 and tinymce4 until it's clear that support for tinymce3 is no longer required

One way of doing that is to keep the django-tinymce 2.0 branch for tinymce3 and create a django-tinymce 3.0 branch for tinymce 4

I understand that you'd like to push this release asap but it could have unwanted consequences since a lot of people are using the current version.

Actually, I only want advices how to make this PR better, but not doing this asap.
Sorry that I'm calling you to often :(

@vanadium23 not a problem, i really appreciate your work and i'm looking forward to this release :-)

Splendid work! Thanks all! I suggest making a new project only supporting 4, especially if using a CDN, and new release on pypi at least. This could be merged without asking many of the above questions, then. Possibly in a single day with no one being broken (with non-trivial configs? shrugs :)). For other users it may be quite a surprise and potential time investment, unless you do the counterintuitive pip hacks of 3.0.0-dev0 and maybe perpetually keep using the special dev string after a version number so people won't get upgraded to a whole new package..? Then you could add a note in the old repo, have everything current on documentation, and no surprise to users. :)

@narfman0 and fellows, I've decided to switch to new project for not breaking changes with all my refactor.

Let us know what the URL is for the new project.

https://github.com/vanadium23/django-tinymce-lite

Thanks.
Not to be confused with django-tinymce4-lite.


Input loses focus when toast is presented

Ionic version:  (check one with "x")
[ ] 1.x
[ ] 2.x
[ x] 3.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
When typing in an input field, the input loses its focus when a toast is presented.
I use toats to show new activity in my app and currently it's hard to type in an input when it's loses focus every time toast is presented.
Expected behavior:
Input shouldn't lose focus in a toast present.
Steps to reproduce:

Create an input
Present a toast

Related code:
let toast = this.toastCtlr.create({
message: "Input will lose focus now",
duration: 2000
}).present();

Other information:
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Ionic v3.0.1.
Had this issue in v2 aswell

Thanks for opening an issue with us, we will look into this.

i try this, it woking:
let toast = this.toastCtlr.create({
message: "message",
duration: 2000
}).present().then(rs => {
this.input.setFocus();
});

@Ramayana1202 This is a workaround  that doesn't works when the form contains many fields.
@theunreal and @jgw96 I've fixed this in PR: !12515

@solidrevolution This is a valid "temporary workaround" solution. But, the PR !12515 contains a final fix, but was closed by IONIC owners, and needs a totally new code to the 4.0 version. I'm waiting for a stable version to do this.
But, you can get my branch and reference them into your package.json!!


Edit Connection often shows wrong connection details

Azure Data Studio Version:  1.35.0
OS Version: Windows_NT x64 10.0.19042

Steps to Reproduce:

Open Azure Data Studio
Right-click on a server connection
Select "Edit Connection"
Sometimes the connection details are wrong. When they are wrong, they are from the latest added connection.

Does this issue occur when all extensions are disabled?: Yes

This is the kind of bug that could have us making data or code changes in the wrong environment!

Hi @morangozul, is this happening for azure databases, non-azure databases, or both?  What details are wrong? Can you show screenshots of an example where this is happening? I'm not able to repro on my machine, so trying to collect some more details.

I was unable to repro this issue with build 1.35.1 after using Edit Connection numerous times.  The two things that come to mind are perhaps (1) the right-click context menu was inadvertently focused on a different node in OE and an unexpected connection was edited or (2) an item in the Recent Connections list was clicked on in the Connection Dialog updating the connection details.  Please let us know if you can provide additional repro details to help determine what's happening.  Thanks!

Hello, sorry for the delay on my side.
@cssuh I have only tested this with azure databases. All the details were 'wrong' and matched exactly a connection that I had just added to Azure Data Studio during the same session. I had this happen while I was sharing my screen with a colleague, and it made me doubt my sanity. 😅
Other connections were also affected when I selected "Edit Connection". The problem was gone after re-starting ADS, but was a scary thing and I felt like it should be reported immediately.

Hello again, today I experienced this problem again and can guarantee that it is related to adding a new connection.
Steps:

Open Azure Data Studio
Click on 'Add new connection'
Enter the new connection info and press 'Connect'. Your new connection will show the green marker that you are now successfully connected.
Right-click on a pre-existing saved connection that has the red marker (so that you aren't connected to it at the moment).
Select "Edit Connection"
Look at the connection details and note that they are all from the newly added connection.

Sadly, I can't make a video to show this because the data is confidential.

Connection occasionally show wrong database.  The latest time it happened after re-connecting after losing network connection


Socket Programming In .NET Framework Using C#

Topic Suggestion
Socket Programming In .NET Framework Using C#
Writing sample(s):
https://www.section.io/engineering-education/authors/geoffrey-omukuba/
Proposed article introduction
Socket programming is an approach to associating two nodes on a network to speak with one another. One socket(node) tunes in on a specific port at an IP, while the other socket contacts the other to create an association. The server creates the listener socket while the client connects with the server.
The .NET Framework Socket class is an overseen code form of the attachment administrations given by the Winsock32 API. By and large, the Socket class techniques essentially marshal information into their local Win32 partners and handle any fundamental security checks.
The Socket class upholds two essential modes, simultaneous and nonconcurrent. In simultaneous mode, calls to capacities that perform network activities (like Send and Receive) delay until the activity finishes prior to returning control to the calling program. In offbeat mode, these calls get back right away.
In this tutorial, we shall be looking at socket programming on an asynchronous server to better understand this article in the .NET Framework.
Key takeaways

In this article, I will take the reader through the concept of:

Asynchronous mode of function calls
Synchronous modes of function calls

The reader will also understand the concept of socket programming
The reader will be able to develop a program that can be able to connect to other devices on the network

Article quality
This article tends to take the reader through the concept, of socket programming in the .NET Framework and also use a practical approach for a better understanding of it. This will make the reader understand what socket programming is in the best way possible.
References
N/A

Topic approved @Geo-free - Please make sure your article is unique and adds value to what is available online.


SWF motion tween not working on Neko

We're loading a SWF library with some simple motion tween based animations. Unfortunately, it doesn't seem to work properly with Neko either under OSX or Windows:

It seems to just jump to the final frame instead of tweening.
The same thing but CPP version:

While the gif recording seems to have destroyed the framerate, the real thing works fine.

Fixed :smile:


build: restore clean scripts for Windows

use of single quote ' yields full miss.
\" is ugly but works consistently.

@jason-ha RE the CI failure: You won't be able to make the script changes themselves in this PR unfortunately. Once we've bumped the client release group to use the new build-tools, the new version will make those changes. Sometimes you can do the change beforehand, but since this is a change that conflicts with existing policy, you can't.

@jason-ha RE the CI failure: You won't be able to make the script changes themselves in this PR unfortunately. Once we've bumped the client release group to use the new build-tools, the new version will make those changes. Sometimes you can do the change beforehand, but since this is a change that conflicts with existing policy, you can't.

Right, #17874 had the policy changes that I originally missing in the original switch to '. Should this just be Closed and the build-tools update PR will apply all of the changes? Or use this for the build-tools update once available?

@jason-ha RE the CI failure: You won't be able to make the script changes themselves in this PR unfortunately. Once we've bumped the client release group to use the new build-tools, the new version will make those changes. Sometimes you can do the change beforehand, but since this is a change that conflicts with existing policy, you can't.

Right, #17874 had the policy changes that I originally missing in the original switch to '. Should this just be Closed and the build-tools update PR will apply all of the changes? Or use this for the build-tools update once available?

Oh, I got the PRs mixed up. My mistake. This PR can probably be closed. Once we upgrade build-tools, policy will require us to make these changes in the same PR (unless we disable the policy temporarily and re-enable it - we could do that but it seems unnecessary).

Changes here to be applied when build-tools is updated.
Extra manual changes applied:

experimental/PropertyDDS/services/property-query-service/package.json:

move clean to proper sorted order

packages/tools/devtools/devtools-browser-extension/package.json:

remove extraneous --glob argument
cc: @tylerbutler


Update azure-cni-overlay.md

Update kubenet pods per node maximum to correct value of 110 pods per node not 250 pods per node.

Even this link states the same that kubenet can be extended up to 250 pods/node
[https://learn.microsoft.com/en-us/azure/aks/configure-azure-cni#configure-maximum---new-clusters]
Maximum routes limit for kubenet is 110 pods/node

Tested this today and you  can indeed deploy 400 nodes with 250 max pods per node. There are documentation conflicts in other Azure docs that I will submit PRs for, but this doc is indeed factually correct, although you need to adjust your pod_cidr to a /15 to get to 400 nodes and the max pods per node also needs to be adjusted from default 110 to 250 on deployment. Beyond 250 hits RP validation and is stopped.   Closing PR request.


[Feature] Add get Reward details

What happened 👀

Provide a new method to get Reward details from SDK
Add Reward detail screen sample

Insight 📝
N/A
Proof Of Work 📹

@hoangnguyen92dn can you please update the POW with the network call response? also the response model so we can confirm the implementation outcome

can you update README also? I think it will cost 1 PR less


Map App is defunct due to changed mapquest policy

Never rely on closed source stuff :/

What map app? We don't have any project apps or plugins which link to mapquest that I'm aware of.

Mapquest offered free Openstreetmap tiles, until a while ago. Gnome maps had the same problem. So what Mike said, it's a hub issue. You have to ask your hub admin to change to another tile server.

Why reopening this? It is clearly not a code issue, but a hub configuration issue.

I think we should leave this open as a courtesy pending more insight into the issue. I don't think we have a code issue but without a bit more detail I cannot say this definitively.

I think we should close issues as soon it's clear we fixed them, we won't fix them or if they are invalid. That's what I learned when I worked on a support desk myself. That will keep the issue list manageable. But it's no big deal if you like to keep this one open.

This is likely referring to the map plugin I wrote, which is not an officially supported plugin, but has the problem described. I replaced the tile source from Mapquest with OpenStreetMap but I have not updated the publishedplugin because I am in the process of revising it for integration into the official hubzilla-addons repo. Ultimately the tile source should be configurable through the map admin settings, but for the foreseeable future it will be OpenStreetMap.

@anaqreon thanks for showing up. I was indeed somewhat abusing this issue tracker since the problem was obviously outside hubzilla core's scope.
Hope i could motivate you to fix and improve. Geobased content is a huge player in future social networks' feature landscape.