Extension cloud function to use transaction

Right now the cloud function for extension, even with the forceDataSync flag enabled, does not use transactions, so it is still technically possible to have a conflict on multiple concurrent updates to the listened document.
[function code]
const handleUpdateDocument = async (
  before: DocumentSnapshot,
  after: DocumentSnapshot,
  timestamp: Number
) => {
  try {
    const forceDataSync = config.forceDataSync;
    if (forceDataSync) {
      const updatedSnapshot = await after.ref.get();
      const data = await extract(updatedSnapshot, 0);
      logs.updateIndex(updatedSnapshot.id, data);
      logs.info('force sync data: execute saveObject');
      await index.saveObject(data);
    } else {
      if (areFieldsUpdated(config, before, after)) {
        logs.debug('Detected a change, execute indexing');

        const beforeData: DocumentData = await before.data();
        // loop through the after data snapshot to see if any properties were removed
        const undefinedAttrs = Object.keys(beforeData).filter(key => after.get(key) === undefined || after.get(key) === null);
        logs.debug('undefinedAttrs', undefinedAttrs);
        // if no attributes were removed, then use partial update of the record.
        if (undefinedAttrs.length === 0) {
          const data = await extract(after, timestamp);
          logs.updateIndex(after.id, data);
          logs.debug('execute partialUpdateObject');
          await index.partialUpdateObject(data, { createIfNotExists: true });
        }
        // if an attribute was removed, then use save object of the record.
        else {
          const data = await extract(after, 0);

          // delete null value attributes before saving.
          undefinedAttrs.forEach(attr => delete data[attr]);

          logs.updateIndex(after.id, data);
          logs.debug('execute saveObject');
          await index.saveObject(data);
        }
      }
    }
  } catch (e) {
    logs.error(e);
  }
};

Can a transactional approach be added to resolve multiple concurrent updates conflicts?

Is this a rampant issue or are we solving for a corner case issue?

Is this a rampant issue or are we solving for a corner case issue?

I would say it's more of a corner case issue, not really urgent, but nice to have


Show image names or video name in UI (now frame numbers only)

I have created a large task (thousands of images), and am trying to generate pre-annotations using an external program. The issue, I do not know which imageId corresponds to each image. I have tried to "Dump Annotations", but that only shows me the Ids for the frames that already have annotations.
Only workaround I can think of is to upload some dummy annotations' file with at least one object per image, and then dumping those annotations to check which imageId corresponds to each image.
Am I missing something? Is there an easier way to achieve this?

Hi @4sfaloth,
Currently it works the following way: take all images, sort them by name. In the array first image will have id=0, second id=1, ...

Hi @nmanovic ,
thank you for your fast reply. I was under the impression that might be the case, since I had noticed that in previous datasets.
However, in this one I have:

Several subfolders (In 'shared' I just selected all the folders, I believe it orders first by folder name then by filename?)
Unfortunately some of the folders and filenames have funny characters. In particular, there are some that start with a '. I believe this is messing up the ordering (or at least the order did not match the one I "guesses")

Is there really no way as of now to find out the id for each image, through its filename for instance?

Alright, thank you. I'll close the issue

Just to clarify to anyone who might do the same errors as myself: 'lexicographic order' implies that all capital letters precede lowercase letters.
This is important because many file-explorer APIs will iterate over your files in (almost) lexicographic order, the almost being due to that many of them ignore capitalization

@nmanovic is it possible to dive into more detail into the sortering algorithm?
In particular I highly suspect (though I cannot prove it...) that it does not follow the same ordering as the python .sort method applied to a list of strings (which is also supposed to be lexicographic order). It seems to be the same in ALMOST all cases, but not always. Mind that I am talking about full filenames with complex paths, with special characters such as '_' ,  '.' and '+' in them

@4sfaloth ,
There are no any details. It is just sort call for a python array of strings: https://github.com/opencv/cvat/blob/4aefbe2630908a7ad20f67e473e5b5e7015e4cec/cvat/apps/engine/task.py#L321

@4sfaloth ,
There are no any details. It is just sort call for a python array of strings:
cvat/cvat/apps/engine/task.py
Line 321 in 4aefbe2
filenames.sort()

@nmanovic thanks a lot. I am also using python to sort the filenames before uploading the annotations, so they should be matching now
There might be something weirder going on on my side then as well; I will try to debug it more exhaustively when I find the time.

@nmanovic
just one more question. Do you think it is possible python's sort yields different results when running under Windows and Linux?

@4sfaloth ,
I don't think so.

@nmanovic I have an idea for a new feature related to this issue:
Once a task is created you have no information about the relation between the image-IDs and original filenames (except dumping the annotations). It would be nice to have some kind of overview / meta information regarding the created tasks, in order to be aware which images / image-sets are included in a specific task

It makes sense to implement in new UI. Moved to v1.0.0 version.


[Enhancement] optimize MV lazy log

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE Incremental Coverage Report]
:disappointed: fail : 9 / 15 (60.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/OptimizerTraceUtil.java
9
15
60.00%
[69, 70, 71, 72, 73, 75]


[Refactor] Rewrite to Jetpack Compose

Because why not

Is this up for grabs? :eye:

Current status:
Help activity
Currently migrating to Jetpack Compose - so far, it's been mostly done, just need some additional testing (and pushing of commits - currently, you can find the WIP changes in the refactor/feature/help-compose branch)
Settings activity
Also working on it. Mostly done, needs some thoughts on how auth would be integrated in the module (Separate module for auth? Or just add the Firebase Auth dependency and use it as-is?).
No changes published as of yet, but stay tuned :eyes:

Currently migrating to Jetpack Compose - so far, it's been mostly done, just need some additional testing (and pushing of commits - currently, you can find the WIP changes in the refactor/feature/help-compose branch)

*An addendum on this: adding Jetpack Compose to the app requires additional setup, so the preliminary changes will be adding Compose (in the feat/compose-setup branch - see #406), then migrating the help module to Compose.


Duplication glitch with Immersive engineering

When breaking IE multiblocks with a block dispenser, the multiblock drops 2 blocks (when it should drop one). It would be nice to fix this, or alternatively add a blacklist of what blocks can be safely broken / placed by block dispensers.

This may actually be an issue with Immersive Engineering, considering that this was a problem with Quark Endermen picking up multiblocks aswell...


Make file names as default for scoring

Tool currently requires --filepath for input SBOM
     --filepath string   sbom file path
Let's make that default so that we can get this done
build/sbomqs score ~/sbom-samples/repos/trivy-bom.spdx
without --filepath

@kchetans i finally read the cobra documentation and understood how to fix this. Essentially my implementation is incorrect. I have mixed the concept of flags and args. I will take this task up after my json change.
You can close your existing branch.


Add support for YouTube Shorts blocking on mobile home page

The code responsible for blocking shorts on the home page currently uses the is-shorts attribute on the ytd-rich-shelf-renderer element to detect the Shorts section. This however only works on desktop, since YouTube on mobile (m.youtube.com) does not use this attribute.
I did some poking around on the mobile home page and found that the grid-shelf-view-model on the mobile website seems to be used exclusively for the Shorts section. This could be used to block shorts on mobile as well by removing all grid-shelf-view-model elements.
If you are interested, I would be happy to make a pull request with such a change.

Yeah, this would be neat. If you don't have time, tell me and I'll make it.
Thanks a lot fore research <3


Change the compile target to ES2017

Fix https://github.com/karen-irc/option-t/issues/1236

I seem we need “support” section to read me.md before merging this


Please invite me to the community

Name
Markus Wang
Additional Context
Hi, I am a web3 and fullstack developer.
I would like to join this community.

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is a remarkable open-source solution tailored for serverless platforms, aimed at empowering creators to craft their infrastructure solutions. 💻 We're thrilled to welcome you into our vibrant community! ✨ We eagerly anticipate your valuable contributions! 🤓 Don't forget to explore our community on Github and connect with us on LinkedIn 💜 Feel free to spread the word about our community to like-minded individuals interested in development, DevOps, technology, and collaborative contributions. 👉💜👈


Fix and simplify "rustc-watch" problem matcher

Cargo watch now always ends with "[Finished running ..." and includes some extra info. Make the pattern only match "[Finished running".
Also add "cargo watch" and "cargo watch tests" that use the "rustc-watch" problem matcher.
Change the "Build Lsp" to do "cargo check" because that's faster, and I think enought in this case, and make it use "rustc" problem matcher from the extension.

bors r+

looks like a missing \n problem
bors delegate+

bors r+


(tortoisesvn) Migrated from dtgm [Requires Chocolatey User]

Package source: https://github.com/dtgm/chocolatey-packages/pull/265
No open issues

Changes
Required changes compared to dtgm version:

[ ] Added AU script
[ ] Update NuSpec metadata to be compliant with core team guidelines
[ ] Change to embedded package

This is actually related to https://github.com/dtgm/chocolatey-packages/pull/267

@pascalberger @majkinetor I have added the chocolatey user to this package on chocolatey.org, so once PR is merged into @dtgm repo, this one should be good to go.


Is this a point that can be improved in the setting of random research of talos

Hello, recently I am reading the book: Deep Learning written by Goodfellow et al. In the 11th chapter, several main methods for hyperparamter tuning is discussed and it is concluded that random research is more efficient than grid research. Here is the point I want to present. Generally, in the section of random research in the book, it says that we generally define a interval for hyperparameters like [a,b] rather than some discrete values {a1, a2, b1, b2}, which can enlarge the search range without additional computational cost. So I want to ask if talos can achieve this. Thanks in advance!

Yes, Talos supports "range" of values. Check out the corresponding section in the docs:
https://autonomio.github.io/docs_talos/#parameter-dictionary

I got it! Thanks for your reply!


test: throw on deprecation

@DominicKramer the failure in tests is due to an unhandled promise rejection. This needs to be investigated.

@ofrobots @googleapis/node-team can someone take a look?  Would love to get this merged :)

@DominicKramer what's the status here?

ping @DominicKramer

gentle ping

The design of the test require the use of unhandled rejections to verify that the library handles them correctly.  There were also test failures unrelated to this PR that I am investigating so that I can get this PR landed.

The changes in PR #253 will fix the system tests and update the tests so that this PR can land.

@DominicKramer Looks like the system tests are still failing here :/  https://source.cloud.google.com/results/invocations/fa56d7ab-1577-4496-b7dc-cd8de37c3048/targets/cloud-devrel%2Fclient-libraries%2Fnodejs%2Fgoogleapis%2Fnodejs-error-reporting%2Fpresubmit%2Fnode8%2Fsystem-test/log


Progress buttons

UI Version: 0.9.4
Description:
We could show a progress bar on the submit button, based on an estimated block time (last blocks).
Example:

Pulling in @nylira

Like I mentioned on #1092, I would support having a async loading bar for sending, staking, and voting transactions. It would be nice if the user can still use the app while the block is being finalized.
A progress bar on the submission button still makes the user wait to see if the tx made it through. I think they'd be worried that they can't leave the page before the progress bar completes.

wait for decisions on #1092

instead of blocking the user from proceeding with more submissions / transactions ...

show successful submission
clear for new tx's
show loading icon in sidebar next to transactions link
include the pending / loading tx in tx history

so this is more the optimistic UI approach. I trust u on that. closing this issue.


npm run dev module was not found: ../.postwoman/version.json

i sure that i do npm install && npm run dev
but it does not work
throw a err :
WARN  Compiled with 1 warnings                       friendly-errors 12:00:18
WARN  in ./node_modules/yargs-parser/index.js        friendly-errors 12:00:18
Critical dependency: the request of a dependency is an expression
friendly-errors 12:00:18
ERROR  Failed to compile with 1 errors               friendly-errors 12:00:18
This relative module was not found:                   friendly-errors 12:00:18
friendly-errors 12:00:18

../.postwoman/version.json in ./node_modules/babel-loader/lib??ref--2-0!./nod
_modules/vue-loader/lib??vue-loader-options!./layouts/default.vue?vue&type=scri
t&lang=js&
i Waiting for file changes                                            12:00:18
i Memory usage: 208 MB (RSS: 358 MB)                                  12:00:18

Duplicate of #327


Add link shortener to share queries

Requires a persistent database of queries and short links.

Better use an existing link shortener like https://academiccloud.de/de/services/urlshortener/


[CARBONDATA-3013] Added support for pruning pages for vector direct fill.

This PR depends on PR https://github.com/apache/carbondata/pull/2819
First, apply page level pruning using the min/max of each page and get the valid pages of blocklet. Decompress only valid pages and fill the vector directly as mentioned in full scan query scenario.
For this purpose to prune pages first before decompressing the data, added new method inside a class FilterExecuter.
BitSet prunePages(RawBlockletColumnChunks rawBlockletColumnChunks)
      throws FilterUnsupportedException, IOException;

The above method reads the necessary column chunk metadata and prunes the pages as per the min/max meta. Based on the pruned pages BlockletScannedResult decompresses and fills the column page data to vector as described in full scan in above mentioned PR .
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/809/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1006/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9074/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/815/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9080/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1012/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/886/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9151/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1084/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/899/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/903/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9167/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1110/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/917/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9177/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1117/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/929/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1127/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1227/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1014/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9279/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1244/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1032/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9297/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1034/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9299/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1246/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1040/

LGTM

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1253/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9305/


Fix LinkedHashMap missing usage issue

Fixes an issue where the import was changed to LinkedHashMap but corresponding code handling header collections didn't update their instantiation to LinkedHashMap rather than HashMap.

No changes needing a change description found.

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


[MINOR][CORE]Avoid hardcoded configs

What changes were proposed in this pull request?
avoid hardcoded configs in SparkConf
How was this patch tested?
N/A

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@dongjoon-hyun Thanks for your reply.
I have changed title and description, and reverted the document change.
Thanks for your suggestion, and it really helps me.

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10745/
Test PASSed.

Test build #105484 has started for PR 24631 at commit 2620864.

Test build #105484 has finished for PR 24631 at commit 2620864.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105484/
Test PASSed.

This is probably OK but are there more instances like this?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10753/
Test PASSed.

Test build #105493 has started for PR 24631 at commit 8069d8b.

This is probably OK but are there more instances like this?

I found nothing so far except SparkSubmit, and I have fixed it.

Test build #105493 has finished for PR 24631 at commit 8069d8b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105493/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10795/
Test PASSed.

Test build #105539 has started for PR 24631 at commit b54c18f.

Test build #105539 has finished for PR 24631 at commit b54c18f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105539/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10796/
Test PASSed.

Test build #105540 has started for PR 24631 at commit ecef09f.

Test build #105540 has finished for PR 24631 at commit ecef09f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105540/
Test PASSed.

@wenxuanguan . Thank you for improving the PR. Now, this PR seems need a JIRA issue because it touches many files. Could you file a Apache Spark JIRA issue? Please enumerate the configs in the JIRA which you replaced. Also, please use that JIRA id instead of [MINOR].

@dongjoon-hyun Jira SPARK-27774 has been made, and linked with this pr.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10840/
Test PASSed.

Test build #105586 has started for PR 24631 at commit 580c618.

Test build #105586 has finished for PR 24631 at commit 580c618.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105586/
Test FAILed.

retest this please

Test build #105610 has started for PR 24631 at commit d026b8f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10862/
Test PASSed.

Test build #105610 has finished for PR 24631 at commit d026b8f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105610/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10875/
Test PASSed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10878/
Test PASSed.

Test build #105625 has started for PR 24631 at commit 3337183.

Test build #105625 has finished for PR 24631 at commit 3337183.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105625/
Test PASSed.

Merged to master.

@HyukjinKwon @srowen @dongjoon-hyun  Thank you for review


Avoid allocs improving ~15% performance and using ~97% less memory

This PR contains a set of optimizations that improves the performance of the library significantly.

The performance gain comes from avoiding allocations, which clearly is shown by reducing by more than 95% and some functions completely stopping doing memory allocations.

The original focus to guide the optimizations was making go-verkle faster for generating and verifying proofs.
To understand the impact of these optimizations in go-verkle see this PR.
I'm not entirely sure if the repo is open for PRs from external contributors; if this PR is looking good to consider for merging I can add some comments on the changes.
Let me know!

These are amazing results! Thank you very much,  I'll check out the PR now :)

Oh RE your last sentence, yes please add comments on the changes!

I should also note that #19 might regress some of the changes made here. Instead of PointAffine, we use a wrapper around PointProj with special methods, so MultiExp etc now also use that wrapper

These are amazing results! Thank you very much, I'll check out the PR now :)

You're welcome!

I should also note that https://github.com/crate-crypto/go-ipa/pull/19 might regress some of the changes made here. Instead of PointAffine, we use a wrapper around PointProj with special methods, so MultiExp etc now also use that wrapper

Sounds good. Maybe after that gets merged I can take some other pass with optimization-eyes to see if there's something extra that we can gain.

Alright, I'll merge this first and then resolve conflicts on that branch, aiming to preserve the optimisations you have done


New package: GEOTRACES v0.1.5

Registering package: GEOTRACES
Repository: https://github.com/briochemc/GEOTRACES.jl
Created by: @briochemc
Version: v0.1.5
Commit: 34c3d7c132849188e0c875680bb21d7c7524f125
Reviewed by: @briochemc
Reference: https://github.com/briochemc/GEOTRACES.jl/commit/34c3d7c132849188e0c875680bb21d7c7524f125#commitcomment-45194116

FWIW, GEOTRACES (written with all caps) is the name of a fairly recent and large project that releases oceanographic data on trace elements every few years. This package was named directly after it (just added the .jl), because I don't think there is any confusion, but I'm open to suggestions of course!

I just noticed that the bot said "GEOTRACES" does not respect "ASCII alphanumerics only", but these are all standard (capital) letters of the alphabet, right? Is the bot confused or is it me?

Gentle bump for a manual merge 🙂


Support non-interactive continuous-delivery system use cases

This PR adds the following to the gh-release CLI:

A --noconfirm flag for skipping the confirmation prompt (modeled after Arch Linux' pacman's --noconfirm)
The ability to read an authentication token from the GH_RELEASE_GITHUB_API_TOKEN environment variable

These two features combined allow for gh-release to be used in continuous-delivery systems (like Jenkins) where user interaction is not possible.  It also allows these systems to work with multiple GitHub APIs (i.e. github.com and a self-hosted Enterprise GitHub) by simply swapping out the token environment variable.
Resolves #75

Hi @tjaneczko, thanks for this PR!
Only one comment: I'm more a fan of the -y or --yes convention mentioned in the original issue (#75), which is a common convention for npm and node userland, as opposed to noconfirm, which sounds like something more specific to Arch Linux's pacman package manager.
Otherwise looks great!
Are you willing to update to use yes with a y alias instead of noconfirm?

Sure thing!  Will switch back to using --yes with a y alias.  Thanks for the review!

@ungoldman should be all set for another look!

📦 3.3.0 🚀


(VL) bugfix for splitter unit-test

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@jinchengchenghh

next time let's use "squash and merge", "rebase and merge" adds all commits to main


Aperture Example Not Working iOS/Mac | macOS 11.2.3 & Xcode 12.4

I've been trying to get the example to run, but it's proving difficult.
It keeps getting stuck at line 20: print("Failed to initialize")
After digging around some, I can confirm that I have read/write permissions, the destination URL is valid, I can pick up the iPhone's ID, it just keeps failing.
I've attached the output logs below, but I don't think these are really problems.
I also tried using the screen recording, instead of a iOS device, but that didn't work either, failing to initialize as well. The app has access to the system’s camera/microphone.
I was able to capture the screen with Aperture-Node, but I’m looking to using Aperture as part of my Swift native app.
Lastly, why would the example script be about recording an iOS device, when this was made to record the Mac's screen? There's hardly any info regarding Mac/AVFoundation, so I feel like there should at least be an example for macOS as well. I know it's trivial, but it could go a long way for others.

2021-03-30 15:10:35.333166-0700 Aperture_Test[6323:393386] [plugin] AddInstanceForFactory: No factory registered for id <CFUUID 0x6000028f2500> 30010C1C-93BF-11D8-8B5B-000A95AF9C6A

2021-03-30 15:10:35.337822-0700 Aperture_Test[6323:393386] [plugin] AddInstanceForFactory: No factory registered for id <CFUUID 0x6000028f8600> F8BB1C28-BAE8-11D6-9C31-00039315CD46

2021-03-30 15:10:35.463648-0700 Aperture_Test[6323:393386] [] CMIOHardware.cpp:379:CMIOObjectGetPropertyData Error:<PHONE_NUMBER>, failed

2021-03-30 15:10:35.463685-0700 Aperture_Test[6323:393386] [] CMIOHardware.cpp:379:CMIOObjectGetPropertyData Error:<PHONE_NUMBER>, failed

2021-03-30 15:10:35.463702-0700 Aperture_Test[6323:393386] [] CMIOHardware.cpp:379:CMIOObjectGetPropertyData Error:<PHONE_NUMBER>, failed

There was a bug where it didn't correctly handle if you didn't set a video codec. This is now fixed in the latest version.


Create cantab.txt

Adding university domain

@jinalharia The cantab.net website says that "Cantab.net is a FREE* email service exclusively for University of Cambridge alumni". It cannot be added to this repository because licenses which JetBrains grants for free for educational purpose are for students and teachers only, not for alumni. Thus, I have to close this request without merging. Thank you for the understanding!


MQTT user and password .env variables?

Hi!
Thank you for your efforts with this. I've been longing for the official Adax HA integration to report energy statistics for a long time now. This will do fine, until it's officially supported.
I get a log message from the container that the access token was obtained. But the MQTT broker logs a message that it gets an unauthorized connection. I guess it has to do with me using a user and password for Mosquitto?
How do I set the env. variables for the MQTT broker in the docker compose file?
Thank you!

Thanks. This should be possible with version 0.4.0. Use MQTT_USERNAME and MQTT_PASSWORD as the env variables.
I'm still trying to figure which data is the most reliable from Adax's servers. I report both the room energy consumption and device consumption, room energy seems to match what I see in the Adax app on my phone much better.

MQTT user and password working with 0.4.0 (and 0.4.1) 🥳
Now I'm facing other issues 😅 Logs below.
Obtained access token
Published discovery message to homeassistant/sensor/adax_room_x/config
Published discovery message to homeassistant/sensor/adax_device_x/config
Published energy message {"value":0,"last_reset":"2024-10-21T03:00:00.000Z"} to homeassistant/sensor/adax_room_x/state
Error during refresh of energy data Could not get data from /rest/v1/energy_log: Request failed with status code 502

And I don't see the values reported in HA.

Published energy message {"value":0,"last_reset":"2024-10-21T03:00:00.000Z"} to homeassistant/sensor/adax_room_x/state
Error during refresh of energy data Could not get data from /rest/v1/energy_log: Request failed with status code 502

If these happened right after one another (and not with 10 minutes in between), I think maybe you have more than one "room" in the Adax API and that one of them isn't working. I published 0.4.2 with some additional logging of the room id to see if it has some funny ID like -1 or something.

Published energy message {"value":0,"last_reset":"2024-10-21T03:00:00.000Z"} to homeassistant/sensor/adax_room_x/state
Error during refresh of energy data Could not get data from /rest/v1/energy_log: Request failed with status code 502

If these happened right after one another (and not with 10 minutes in between), I think maybe you have more than one "room" in the Adax API and that one of them isn't working. I published 0.4.2 with some additional logging of the room id to see if it has some funny ID like -1 or something.

Hi again!
Timestamped logs from Portainer directly after a restart.
The first room in the list (Alf) is publishing kWh to HA successfully. I think it's the next room that doesn't work. I don't see any wierd naming patterns etc. Any suggestions?
2024-11-18T08:44:58.087370970Z Obtained access token
2024-11-18T08:44:58.482030611Z Published discovery message to homeassistant/sensor/adax_room_alf/config
2024-11-18T08:44:58.489175187Z Published discovery message to homeassistant/sensor/adax_room_allrum/config
2024-11-18T08:44:58.491786742Z Published discovery message to homeassistant/sensor/adax_room_gaestrum/config
2024-11-18T08:44:58.494286107Z Published discovery message to homeassistant/sensor/adax_room_koek/config
2024-11-18T08:44:58.497072430Z Published discovery message to homeassistant/sensor/adax_room_master_bedroom/config
2024-11-18T08:44:58.499528268Z Published discovery message to homeassistant/sensor/adax_room_vardagsrum_h/config
2024-11-18T08:44:58.503619300Z Published discovery message to homeassistant/sensor/adax_room_vardagsrum_v/config
2024-11-18T08:44:58.510946109Z Published discovery message to homeassistant/sensor/adax_room_foerrad/config
2024-11-18T08:44:58.513593269Z Published discovery message to homeassistant/sensor/adax_device_gaestrum/config
2024-11-18T08:44:58.515761448Z Published discovery message to homeassistant/sensor/adax_device_master_bedroom/config
2024-11-18T08:44:58.518494586Z Published discovery message to homeassistant/sensor/adax_device_allrum/config
2024-11-18T08:44:58.520763172Z Published discovery message to homeassistant/sensor/adax_device_alf/config
2024-11-18T08:44:58.523232250Z Published discovery message to homeassistant/sensor/adax_device_koek/config
2024-11-18T08:44:58.525523334Z Published discovery message to homeassistant/sensor/adax_device_vardagsrum_v/config
2024-11-18T08:44:58.528240969Z Published discovery message to homeassistant/sensor/adax_device_vardagsrum_h/config
2024-11-18T08:44:58.530621474Z Published discovery message to homeassistant/sensor/adax_device_foerrad/config
2024-11-18T08:44:59.317680397Z Published energy message {"value":0.317,"last_reset":"2024-11-18T03:00:00.000Z"} to homeassistant/sensor/adax_room_alf/state
2024-11-18T08:45:00.015670346Z Error during refresh of energy data Could not get data from /rest/v1/energy_log/749713: Request failed with status code 502

It looks like the first room, adax_room_alf is published successfully, then the next one fails, which causes the loop to exit.
Publishing energy messages for rooms should now continue to the next room if one fails, with v0.4.4. it should make it easier to see if this room fails consistently.


[SAM] 5.1 update to pre-existing modules/data

This PR updates the following:
Potency changes:
Yukikaze (400->360)
Jinpu & Shifu (340->320)
Shoha (fixed to 400)
Cooldown changes:
Shoha (set to 15)
Other changes:
Hagakure conversion ratio increased (5 -> 10 per sen)
Features to be added for 5.1 not in this PR in order to consider the PR supported for the patch:
-Shoha tracking with visual graph of stacks
-Adding ishikoten and Guren/Senei to OGCD tracker
-Adjusting Meikyo to include Iaijutsu again

The Shoha action didn't get a potency update but not sure if that matters


Impulse report

Implements feature request #409. The total final impulse applied to the contact is saved in the BodyPair2DSW::contacts structure. By total final impulse, I mean the impulses applied to the contact throughout each solver iteration is summed, so when get_contact_impulse is called, the resulting impulse vector should be the exact impulse that was applied to the contact. Also I added the documentation entry as well

Maybe it wasn't clear in my original feature request, but I don't believe this solves the issue I presented. The important distinction is between total impulse and per-contact impulse reporting. Total impulse can be crudely derived in gdscript as Δv*mass, though this may not properly account for constant forces like gravity. What I believe made my feature require core changes is to enable handling scenarios where an object is simultaneously impacted from opposite directions →■←. In this case, the total impulse is zero, but the object compression is high.
I have an existing pull request that shows one potential solution (though not perfect) that stores individual contact impulses.

Sorry I may have made it confusing by saying total impulse, I do still mean that its per-contact. What I mean by total is this: it looks like the collision system uses a number of iterations to solve the contact constraints, so I believe the BodyPair2DSW::solve(...) is called a number of times for the same contact in a given time-step. I wanted to make sure that the impulse reported was the total impulse applied to the contact over all those iterations, and not just one of the iterations, because then the impulse reported wouldn't be accurate.
I did see your pull request after I had finished mine, and I found that yours is only taking the impulse applied in the BodyPair2DSW::setup(...), which I think is ignoring the impulses applied in solve(...), so I felt mine was a different enough approach to keep.
(I think the reason the impulses are applied in iterations is because otherwise the collision response would become jittery when an object has two contacts being solved for)

I don't think this is the best way to do it.
I think the new impulse variable should be set in the add_contact() function together with all the other Body2D Contact variables; not hanging on to an index and updating it later. Furthermore, a key bit of code that ensures only the most significant contacts are kept has been deleted, which it shouldn't be.
Finally, the individual commits should be squashed.

Thanks for all that feedback! Okay, so I did a little test by setting up a basic project that just has two objects colliding (one static, one rigid body).
In the first test, I went the route that you suggested: only set the impulse in the add_contact function, meaning the impulse only gets set with the impulse in the BodyPair2DSW::setup function. I printed out what the impulses were at each frame for the first 4 frames of the collision:

@dustinjamescondon Is this still desired? If so, it needs to be rebased and tested on the latest master branch.

Thanks for your contribution!
Due to the lack of activity in this PR, I'm going to close this. Feel free to request a reopen or submit a new PR.


Add Lighting (clay render) debug draw mode to 3D

This is similar to the Lighting debug draw mode already provided in the master branch (and which was originally proposed for Godot 3.1 in https://github.com/godotengine/godot/pull/20333).
Note that the default material in 3.x is brighter compared to the one in master, so the lighting debug draw mode will often look significantly brighter than your actual textures.
If there's demand, I can change this to use a material similar to the default material in Godot 4.0 when the Lighting debug draw mode is selected.
Preview
Default

Lighting debug draw mode

Do you have any idea why those clear lines are appearing in the bottom picture that aren't visible in the top picture?

Do you have any idea why those clear lines are appearing in the bottom picture that aren't visible in the top picture?

I think this is just the SSAO being more apparent (each testbed has a "ridge" on the side).

I downloaded the binaries and took a look. The problem is actually with the material testers demo. The mesh's material has front face culling turned on. I guess the original mesh has the wrong winding order. When the default material is applied back face culling gets turned on resulting in the meshes appearing wrong.

@clayjohn Is this ready to go? Or do you want to request that the material be double sided?

I think this needs more discussion. To me, just replacing with the default material is not a proper solution as the default material loses information that may be useful (for example, alpha scissor, face culling, depth pre-pass, emission, vertex shader). Unfortunately, I think we need a more robust system that overrides albedo (and maybe other properties like roughness and metallic) but leaves the other properties alone.

I think this needs more discussion. To me, just replacing with the default material is not a proper solution as the default material loses information that may be useful (for example, alpha scissor, face culling, depth pre-pass, emission, vertex shader). Unfortunately, I think we need a more robust system that overrides albedo (and maybe other properties like roughness and metallic) but leaves the other properties alone.

The lighting mode in 4.0 already works like this IIRC, so I don't think backporting it to 3.6 as-is is an issue. If we end up improving the lighting mode in 4.0, changes to it may not be easy to backport as I assume lower-level changes will be required.


Istio 0.8 Egress renaming

I think that external service was rename serviceentry, Does "Entry" is  something relevant for communication outside the cluster?
https://preliminary.istio.io/docs/reference/config/istio.networking.v1alpha3.html#ServiceEntry

@jsenon I use the term "Mesh-External Service Entry". It is a ServiceEntry, with location MESH_EXTERNAL. So it is an additional service, or an entry in the Service Registry, that refers to a service external to the mesh.
Is this term more clear? Does it explain the intention?


AttNHP train with GPU

Hi,
I am trying the AttNHP model with GPU but the following error shows up before the training starts:
 File ".../EasyTemporalPointProcess/easy_tpp/model/torch_model/torch_attnhp.py", line 168, in make_combined_att_mask     combined_mask = torch.cat([attention_mask, layer_mask], dim=-1) RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu! (when checking argument for argument tensors in method wrapper_CUDA_cat)
I am running the taxi dataset as the instructions.
Python 3.9.19
Pytorch 2.4.1+cu121
Best,
Samie

I also met this issue. It seems layer_mask and attention_mask in AttNHP were not in the CUDA device. I will submit a PR.

PR merged


When inverse scrolling, page content jumps to the top

You scrolling down, everything works as normal. Scroll div content will stay where it is and user to scroll down to see more loaded content. But with inverse, the page content jumps up to the top

Started having the same issue recently, was working normally before

If anyone having this problem, the solution is overflow-anchor: none

@Apestein Perfect Thank you!

not working for me

I ended just up just making my own infinite scroll component. Check it out.
https://github.com/Apestein/better-react-infinite-scroll

I ended up just making my own infinite scroll component. Check it out. https://github.com/Apestein/better-react-infinite-scroll

Thank you so much. Your repo helped me a lot!


Syntax error when trying to install Homebrew on Mac OS Sierra

I am trying to install Homebrew on Mac OS Sierra. I have already installed Xcode.
Last login: Thu Apr  6 14:21:41 on ttys000
sysops-mbp:~ XXXX$ /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
-e:1: syntax error, unexpected tIDENTIFIER, expecting end-of-input
Downloading file '-fsSL' from URL ('https://raw.githubuser...
^
sysops-mbp:~ XXXX$
All I did was copying /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)" from https://brew.sh and pasting onto the terminal.

Sorry, this is an issue affecting only you so you'll need to figure it out yourself. Please always fill out the issue template in future.


Assertion Error

I have modifed the python grounded_sam2_local_demo.py file for predicting from a video file. I found that,  grounding_dino/grounddino/utils/inference.py has a function
def load_image(image_path: str) -> Tuple[np.array, torch.Tensor]:
    transform = T.Compose(
        [
            T.RandomResize([800], max_size=1333),
            T.ToTensor(),
            T.Normalize([0.485, 0.456, 0.406], [0.229, 0.224, 0.225]),
        ]
    )
    image_source = Image.open(image_path).convert("RGB")
    image = np.asarray(image_source)
    image_transformed, _ = transform(image_source, None)
    return image, image_transformed

Here, the height of the image is resized to 800 and the maximum width is to 1333. However, if I changed the height to 400 and the max_size to 600 (it maintains the aspect ratio), I get an error like this

I reduced the image size to get a higher FPS. How can I solve this issue? Moreover is there any other way to increase the FPS?
TIA

I think this issue is very similar to https://github.com/IDEA-Research/Grounded-SAM-2/issues/10
Would you like to check the grounding results to see if there are grounding results output or not

It worked when you add a '.' after your object, so instead of TEXT_PTOMPT="bird", it should be "bird."

It worked when you add a '.' after your object, so instead of TEXT_PTOMPT="bird", it should be "bird."

The annotation # VERY important: text queries need to be lowercased + end with a dot is in the code.
The dot successfully solve this problem, but I wonder why, and do you have any insights? Thanks a lot!

The actual reason of the assertion error happened is because the model didn't detect anything in the video/img, the original code repo didn't differentiate it, you can manually add a if statement to skip this video:
if input_boxes.size == 0:
        print("No objects detected, skipping this video.")
        print(f"The video is from {SOURCE_VIDEO_FRAME_DIR}")
        return True
    print(input_boxes)

And in terms of the '.', it is just format thing that implicitly in their code, like a End of Token, to separate the objects you want to segment. For example in their[ grounded_sam2_gd1.5_demo.py,](TEXT_PROMPT = "car . building .") they use '.' to separate 2 objects.

I have encountered this issue when directly running the sample code grounded_sam2_local_demo.py, how can i resolve this problem?


[scriptcraft] No JavaScript Engine available. ScriptCraft will not work without Javascript.

I'm using a 1.8.8 version with scriptcraft and it gives the error I mentioned in the title. Could someone help me?

Plugin is not working with Java versions 16 and 17, check out this workaround: https://github.com/walterhiggins/ScriptCraft/issues/458


TOO MUCH PEERS

connected to 800 peers
how to make it just 100????
and thank's

You can limit the number of connections by enabling Connection Manager:
https://github.com/ipfs/go-ipfs/blob/master/docs/config.md#connmgr
For example, to keep between 200 and 400, set your config to include:
"ConnMgr": {
      "GracePeriod": "20s",
      "HighWater": 400,
      "LowWater": 200,
      "Type": "basic"
    },

Hope that helps. Please start a thread on https://discuss.ipfs.io if you have more questions.


--itr argument

Hello,
I was trying multivariate forecasting using the Autoformer model.
In run.py there is an argument --itr

Is it used when there is more than one script in the .sh file?

I have a single script in the script(.sh) file,  when I had given --itr as 2 the same experiment had repeated  twice. However, I noticed that during the second round of testing, the error metrics were significantly lower.  Can you please explain why?

Thank you
Niharika Joshi

Hi, this argument is to repeat the experiments multiple times, and the paper, we repeat the experiments three times and report the averaged values.
So, I think in real-world applications, you can just fix the random see and set args.itr as 1.


refactor taskmanager

The goal of refactory:

Handling zombie executors and tasks.
When there are multiple failures happening at the same time, should handle them gracefully. For example, a executor(jvm) die may trigger multiple MessageLoss exception, the TaskManager should handle this so that we don't restart the application for multiple times.
Using FSM instead of become/unbecome so that we minimize the shared data.
Make code ut friendly.

+1 on FSM.


Use lemurs as lock screen

As the title.
If not, I figure that it wound be a good idea to make it.

I believe the blog post you're thinking of is this one: https://www.jwz.org/blog/2021/01/i-told-you-so-2021-edition/

The biggest reasons why some of the current lock screen implementations have security flaws is that if they crash then it automatically gives you access. So an attacker just do things like mash the keyboard and try to deliberately crash the lock screen. So the goal becomes then to minimize the possibility of crashes in the critical section that handles the actual locking/unlocking. I believe Rust can help us a lot here.
As far as the mechanism, the TTY switch approach is what is taken by light-locker which is used as a lock screen implementation for LightDM. It locks the current session, starts a new greeter in a different VT. Disables VT switching, and upon successful auth switches to the original session. It is able to do all this despite LightDM not even knowing the existence of light-locker.
We have the advantage in the sense that we can have lemurs be aware of the locking mechanism. Lock the current session, start the auth screen in a different TTY (in a separate process) and if the auth succeeds we unlock the current session and switch back.
I do not have any idea of how this would work on Wayland since I have never used it, but we can probably do a good lockscreen implementation as long as we minimize the likelihood of crashes.

One of the immediate other problems I can foresee. Also looking at vlock is external monitors. Since we don't have access to xrandr or the wayland equivalent, people need to have their monitors setup within GRUB or some other boot level process to display the lock-screen on the correct display.


Instrumentation: JS: Consider Placing the registerInstrumentations Call after the provider.register Call

I was working from https://opentelemetry.io/docs/instrumentation/js/instrumentation/ specifically
In investigating https://github.com/open-telemetry/opentelemetry-js/issues/3719 , I noticed that doing this consistently closed a 4-5ms gap between the start of the trace and the start of the 1st child span.
I have no idea why this would matter at all, but it does seem to have made a difference for the example I was trying out so I wanted to bring it up in case it made sense.
(And if it matters I'm sensitive in general to milliseconds because Deno Deploy and other edge function services limit execution to 10s of ms of CPU time)

...huh. I'd be curious how your experience is if you use the Node SDK? Or is that not applicable on Deno? (sorry, never used Deno)
The NodeSDK is what people tend to use more and it's what I'm planning on moving to docs to eventually. It places registerInstrumentations before registering the tracer provider: https://github.com/open-telemetry/opentelemetry-js/blob/053acb604c9d2b735bb267ff47724bb3af1ffd62/experimental/packages/opentelemetry-sdk-node/src/sdk.ts#L235

I tried the Node SDK just now with this code and am seeing similar results. Here's an example:

Does it matter that this is the first request to the server by chance?

wow, holy shit, that's super weird. I wouldn't have any clue as to why that's happening. I'm not sure if we should change our docs just yet, since this smells like an upstream SDK problem here.

Ok no worries I'll go ahead and close this and follow up in otel-js

@Grunet I suspect what you're experiencing is latency added by the proxy tracer provider in the API. If you acquire a tracer before registering the TracerProvider you receive a ProxyTracer  object which no-ops by default. If you then register a real TracerProvider, the ProxyTracer will proxy calls to the real Tracer returned by the TracerProvider. The advantage of this is that any instrumentation which acquires a Tracer before your SDK is loaded will become active after the SDK is loaded. The disadvantage is that these early-loaded tracers will have a very slight performance penalty due to the proxy function overhead. Registering the provider before registering instrumentations avoids this overhead because the instrumentations get real tracers and you avoid the proxy.


LIVY-886: Make livy compatible with python 3.8+

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Include a link to the associated JIRA and make sure to add a link to this pr on the JIRA as well)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review https://livy.incubator.apache.org/community/ before opening a pull request.

This PR is duplicated with #314

Yes @gabrielmagno both solutions should work. Problem is, livy is an un-maintained project by now.

Last commit in maste was more than a year ago.
Livy hasn't been released after adding support for spark-3/scala-2.12

Hi @prongs and @gabrielmagno is there any solution to this that can be patched on the user end?

just merge another one. https://github.com/apache/incubator-livy/pull/314. Closing this one.


StreetSide Integration

Integrates the Microsoft StreetSide imagery in to the iD editor.
You're welcome.
-Microsoft

You can't use StreetSide for remote mapping without some other source, a difference from imagery, Mapillary, and OpenStreetCam. How can we make that difference clear to users so they don't break the StreetSide license?

@pnorman We will clarify these terms for you shortly.

Awesome @jharpster - this is a really great start, and this will be huge for OSM.  Thank you!
A few things I'm going to work on, to try to make this even better:

[x] The pannellum instantiation code was running on every click, causing it to make a new viewer and canvas.  I split this up so that it only happens one time and reuses it each other time
[ ] I'm going to try to assemble linestrings from the bubble data so that we can render the line go through them, and also show coverage at low zoom.
[ ] I'm going to try to add the viewfield showing where the user happens to be looking.  We can get this data from the pannellum viewer itself, and also bind an event so that as the user moves around, the viewfield can adjust.
[ ] I turned the compass in the viewer on, but it seems to be not quite oriented correctly. I have to figure this out too.

This is exciting! Is there a public posting somewhere about how to use this when mapping? I'm still unsure about how to use it only as corroborating information, as per the terms of use.

Question 1:

“The ToU states that the use is limited  to  "non-commercial online editor application"(s). The original letter has similar wording. In any case it would be good to have a clarification on "non-commercial": is this intended to apply to both offering editing as a service contingent on having an account/contract and products that need to be purchased. For example does it exclude the iD instance run by Strava and the SketchUp plugin for OSM that has recently become available, or is the intent something else?”

Microsoft’s Answer:

Microsoft considers an iD/JOSM or other open source OSM editor run by a commercial company for the sole purpose of contributing to OSM to be non-commercial use. Any software available for purchase, even in a free tier, that features Streetside imagery integration would be a commercial use, and integrating Streetside imagery into such software would not be allowed.  A partner seeking to integrate Streetside imagery in to a commercial product should enter in to a commercial licensing arrangement with Microsoft.

Question 2:
"online": is the intent to limit the availability to browser embedded editors (the would exclude at least JOSM, Vespucci and  Merkaartor), or is the intent to not allow caching of the imagery (which would again would exclude at least those three editors, but could be avoided with special casing),  or, again, is the intent something else?”
Microsoft’s Answer:
The word “online” is not intended to exclude the use of desktop OSM editors.

Question 3:
“What are the intents behind the restriction of only letting it be used as a "corroborating ground truth" source? This is substantially different from Bing imagery, which is routinely used by mapping parties where there aren't other sources to confirm. With these terms, editing software will have to be very careful to describe how StreetSide can be used to make sure someone doesn't map solely from it.”

Microsoft’s Answer:
Microsoft’s intent for incorporating Streetside imagery in to OSM editing environments is that it be used as an additional corroborating source of ground truth for validating, updating and creating contributor edits to OSM. There is no place where Streetside imagery exists and corroborating sources (Digital Globe Premium, Esri World Imagery, Mapbox Satellite, Bing Imagery, etc), do not also exist.
Clarifying Sample scenarios:

An OSM Contributor traces a sidewalk on top of Bing imagery using the iD editor. The sidewalk is partially obscured by trees in the imagery so to improve the spatial accuracy the Contributor refers to Streeside for verification.   This is a valid use of the Streetside imagery

Contributor 1 uses Esri World Imagery to trace a road and adds a tag surface=paved. Contributor 2 refers to the Streetside imagery and verifies that the road is actually bricks and updates the tag to surface=paving_stones. This is a valid use of the Streetside imagery

An OSM Contributor is updating their local neighborhood referring to Bing Imagery and realizes there are a number of stop signs missing from OSM that are clearly visible in the Streetside imagery. The Contributor updates OSM with additional highway=stop nodes. This is a valid use of the Streetside imagery

An OSM contributor builds a computer vision algorithm that iterates over the Streetside imagery attempting to harvest residential addresses. This is an invalid use of Streetside imagery.

@jharpster These examples are very good and helpful.
Can I just test a few of other scenarios which I have been contemplating?
(Streetview coverage in UK is limited but covers my mother's home town, which I know well, but don't visit very frequently):

Use Streetside to identify the correct position of a POI identified by open data (i.e., without a direct ground survey).

In the UK we have a number of good open sources of data which are only geolocated down to the postcode level: notably Food Hygiene data and Companies House (company registrations). Food Hygiene is particularly good because it is updated regularly. The key feature of both datasets is that they provide high-quality address data, and for shops, restaurants & cafes are also visible POIs. So from this data it is possible to identify that a cafe with housenumber 123 is present (typically perhaps with an accuracy of 50 m). If the same cafe is visible on Streetside it then becomes possible to place it more accurately (at the individual building level). In practice I would probably only want to map the address as the POI may have closed/changed both since Streetside imagery and the last snapshot in other open data sources.  Example location: https://binged.it/2t06swf (address is 228 Rake Lane on Food Hygiene: http://ratings.food.gov.uk/business/en-GB/394560/Gills-the-Family-Store-Wirral)

Use Streetside to determine the exact bounds of a retail area or other landuse. It is often possible to identify groups of shops from aerial imagery (taller buildings, service yards, parking on the sidewalk), but the actual extent of the retail area may be more extensive with less obvious buildings. Also in some areas former retail areas are getting converted to housing. Example location https://binged.it/2LSxUmI (note the awnings from when this was a large thriving retail location).

If when using Streetside for confirmation of other information I notice an unmapped post box or similar POI is it permissible to add it to OSM? If not directly allowed, can the knowledge gained from Streetside be then used to search other allowable imagery sources (e.g., Mapillary, Geograph)? Example location: https://binged.it/2LTyXmm.

3a. Related directly to the above location. Streetside would be a good source for dropped kcerbs & tactile paving which is often difficult to identify from aerial imagery or other sources. Such usage would clearly be beyond confirmatory.

I note that a branch of a convenience store is present at a particular location from Food Hygiene open data. Aerial imagery shows a particular building which is highly likely to be the location. Can I use Streetside to confirm this supposition? Example location: https://binged.it/2HQ33or

Sorry for being rather long-winded, but I hope these examples are concrete enough to enable clear guidance.

An OSM contributor builds a computer vision algorithm that iterates over the Streetside imagery attempting to harvest residential addresses. This is an invalid use of Streetside imagery.

@SteveC

@jharpster

An OSM contributor builds a computer vision algorithm that iterates over the Streetside imagery attempting to harvest residential addresses. This is an invalid use of Streetside imagery.

That is exactly what Mapbox did recently. Does that mean that it is invalid use only when Microsoft hasn't been contacted beforehand?

@Zverik I  assume from this quote that they did "We generated these turn restriction detections by applying our machine learning computer vision models to Microsoft Streetside Imagery, from which Mapbox has acquired the right to contribute these detections to OpenStreetMap." (my emphasis)

@Zverik @SK53 Running computer vision algorithms over the 4.7PB imagery catalog generates significant load on MS infrastructure. Supporting that requires a contractual relationship.

An OSM contributor builds a computer vision algorithm that iterates over the Streetside imagery attempting to harvest residential addresses. This is an invalid use of Streetside imagery.

Presumably if they used another source of information like aerial imagery to identify buildings they would then be okay, as Streetside is no longer a sole source of ground truth?

@jharpster Could you please comment on the common potential use cases mentioned by SK53? :)


(Aggregator + Operator):  When not reaching quorum, operator is crashing, and behaviour in Aggregator is unknown

Important:

[ ] Fix crash on operator when the task expires
[ ] Check if aggregator is crashing

Description
The following error appears in the logs of the server:
May 24 23:33:52 aligned-devnet aligned-aggregator[504386]:
{"level":"error","ts":1716593632.88489,"caller":"pkg/server.go:70","msg":"BLS aggregation service error: task 27 not
initialized or already completed","stacktrace":"github.com/yetanotherco/aligned_layer/aggregator/internal/pkg.
(*Aggregator).ProcessOperatorSignedTaskResponse\n\t/home/ubuntu/repos/aligned_layer/aggregator/internal/pkg/server.
go:70\nreflect.Value.call\n\t/usr/local/go/src/reflect/value.go:596\nreflect.Value.Call\n\t/usr/local/go/src/reflect/value.go:38
0\nnet/rpc.(*service).call\n\t/usr/local/go/src/net/rpc/server.go:381"}

This happens when the aggregator tries to process a new signature but the task is not initialized on the aggregator's end. To solve this, the operator retries sending the task response up to 10 times. This doesn't crash the aggregator nor the operator so it shouldn't be a problem.


Get API block creation able to take input and create blocks.

I'm submitting a ...

[x] Bug Report
[ ] Feature Request

Which repositories are involved in this issue?

[ ] Front-end
[x] Back-end

FEATURE REQUEST
Description of Feature:

Motivation:

Related Files and Code:

List files here

And any specific lines of code (i.e., methods, components, etc.) if applicable.

BUG REPORT
Current behavior:

Currently the API call is getting the token from Voiceflow to authenticate the API call. But, the server is returning an HTTP response code 401 for the url: https://api.voiceflow.com/v2/diagrams/636ad5bf6ca8dfcaff607013/nodes/bulk. Next steps, are to debug this issue, make sure all of the fields are correct. (Ask Denys?)
Expected Behaviour:

We know that the appropriate token is being returned as the code is functional in an external python file, but there seems to be some issue regarding the HTTP connection in java. We would expect the console to log a return from the Voiceflow containing a string version of the data we sent them, indicating they successfully received it and implemented the block.
Steps to Reproduce:

In the voiceflow-API-blocks branch in the back-end, run the createBlocksVoiceflow.java file.
Related Code & Files:

createBlocksVoiceflow.java
getToken.java

(Optional) Useful External Resources:

N/A

UPDATE: The API call is functional using the Python code from Denys. It is still returning the 401 response code when implemented in java.

It is now working; I have opened a pull request. I need some people to review my code/help resolve conflicts before we can merge that to main. I am thinking it may not be the most clean, but I am not sure how to improve it. We just need to connect this feature with our front end now!

The block creation has been integrated with the front end and pushes to main.


Problem with include config file in config file?

Hi all,
I have started to use this cookbook and I can generate all my configs but when Chef tries to restart ISC-DHCP-Server on Debian I see this error:
Dec 06 10:03:07 isc-dhcp-server[26717]: /etc/dhcp/dhcpd.conf line 33: /etc/dhcp/shared_networks.d/vlan20_stack4.conf: bad parse.
Dec 06 10:03:07 isc-dhcp-server[26717]: include /etc/dhcp/shared_networks.d/vlan20_stack4.conf"
In dhcp.conf I have:
include "/etc/dhcp/shared_networks.d/vlan20_stack4.conf";
and in this file I have normal config like:
shared-network vlan20_stack4 {   subnet <IP_ADDRESS> netmask <IP_ADDRESS> { pool {   range <IP_ADDRESS> <IP_ADDRESS>; }   option subnet-mask <IP_ADDRESS>;   option default-lease-time 86400;   option deny unknown-clients;   option max-lease-time 604800;   option ntp-servers <IP_ADDRESS>;   option routers <IP_ADDRESS>; } }
I use Jessie and last stable version of DHCP Server. I'm not using data_bags for networks etc. I have everything in my cookbook/recipes/default.rb
Thank you for any suggestions why is like that.
Best,
Rafal

Closing due to inactivity.
If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs


Backport python artifacts manylinux2010

Backport #20282 and #20536.

Test triggered:
grpc_build_artifacts_multiplatform
grpc_build_artifacts_extra_release

Manually installed the manylinux2010 wheel on 64 bit Linux, and it works fine.


[Feature] Show statement supports get table info(like full qualified table name) by table id

Feature request
Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

add table id column in i_s db


[Storage][DataMovement] Integrate JobPlanFile with checkpointer

This change is the next step in the checkpoint schema refactor. Here we are integrating the JobPlanFile that was created in the last PR with the checkpointer. After this change the checkpointer will write the initial JobPlanFile once the job is added but still not read anything from it. The internal state of the checkpointer is also adjusted to use JobPlanFiless.

API change check
API changes are not detected in this pull request.


AzureVMs File Copy fails due to FileNotFoundException

Relevant error below.
Nothing has been changed as far as build definitions
Leaving Import-FromSdkPath.
Leaving Import-AzureModule.
Leaving Initialize-Azure.
Caught exception from task script.
Error record:
Import-Module : The specified module 'C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\Storage\Azure.Storage\Azure.Storage.psd1' was not loaded because no valid module file was found in any module directory.
At C:\agent\agent\_work\_tasks\AzureFileCopy_eb72cb01-a7e5-427b-a8a1-1b31ccac8a43\1.0.98\ps_modules\VstsAzureHelpers_\ImportFunctions.ps1:190 char:27
+ $azureStorageModule = Import-Module -Name $azureStorageModulePath -Global -P ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : ResourceUnavailable: (C:\Program File...re.Storage.psd1:String) [Import-Module], FileNot FoundException
+ FullyQualifiedErrorId : Modules_ModuleNotFound,Microsoft.PowerShell.Commands.ImportModuleCommand
Script stack trace:
at Import-AzureRmSubmodulesFromSdkPath, C:\agent\agent\_work\_tasks\AzureFileCopy_eb72cb01-a7e5-427b-a8a1-1b31ccac8a43\1.0.98\ps_modules\VstsAzureHelpers_\ImportFunctions.ps1: line 190
at Import-FromSdkPath, C:\agent\agent\_work\_tasks\AzureFileCopy_eb72cb01-a7e5-427b-a8a1-1b31ccac8a43\1.0.98\ps_modules\VstsAzureHelpers_\ImportFunctions.ps1: line 156
at Import-AzureModule, C:\agent\agent\_work\_tasks\AzureFileCopy_eb72cb01-a7e5-427b-a8a1-1b31ccac8a43\1.0.98\ps_modules\VstsAzureHelpers_\ImportFunctions.ps1: line 40
at Initialize-Azure, C:\agent\agent\_work\_tasks\AzureFileCopy_eb72cb01-a7e5-427b-a8a1-1b31ccac8a43\1.0.98\ps_modules\VstsAzureHelpers_\VstsAzureHelpers_.psm1: line 47
at <ScriptBlock>, C:\agent\agent\_work\_tasks\AzureFileCopy_eb72cb01-a7e5-427b-a8a1-1b31ccac8a43\1.0.98\AzureFileCopy.ps1: line 55
at <ScriptBlock>, <No file>: line 1
at <ScriptBlock>, <No file>: line 22
at <ScriptBlock>, <No file>: line 18
at <ScriptBlock>, <No file>: line 1
Exception:
System.IO.FileNotFoundException: The specified module 'C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\Storage\Azure.Storage\Azure.Storage.psd1' was not loaded because no valid module file was found in any module directory.
The specified module 'C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\Storage\Azure.Storage\Azure.Storage.psd1' was not loaded because no valid module file was found in any module directory.
Processed: ##vso[task.logissue type=error]The specified module 'C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\Storage\Azure.Storage\Azure.Storage.psd1' was not loaded because no valid module file was found in any module directory.
Processed: ##vso[task.complete result=Failed]

The RM team is aware of this issue.  An image with a fix is in the works.

@d-haxton From the logs it appears like Azure Storage module is missing. Can you manually install it on the agent (assuming it is a private agent) and try again.

I have the same issue. The release task was working until last week and now it started giving the module not found error. tried upgrading the Modules in Azure PowerShell but no luck

@sweetsruthi What version of Azure PS are you using? Also, may i know how you upgraded the modules.

Hi, I was using Azure PS 1.0.2 but upgraded to latest 4.3.1 using commands "Install-Module Azure" and "Install-Module Azure.Storage". Please let me know if there is any other way to do it.

Alternatively, you can install it from the msi here. Let us know if it works.

installing from above MSI worked thank you.


detect erlang dependencies

Hi,
I was "releasing" an application that uses :eldap and :eldap depends on :asn1
I had to run the app, get the error and try to understand the errore that was
{:error, {:asn1, :undef}}

In dev it was not possible to replicate the error, because I suspect that elixir  loads all the modules. In production/release erlang modules are not included by default, isn't it ?
Is it possible to detect the erlang dependencies at compile time ?
Adding the erlang dependencies :eldap, :asn1 in the application solved the issue.
Thanks.
Ra

@helios I'm building this out right now, thankfully it was easier than I expected, though still a bit of a challenge. I'll update this thread when it's in master :)


Version information not showing

UI Version: 0.9.3
Description:
SDK and Voyager version are not shown in modal.

Mentioned by #1044

@nylira I just want to be safe, but I don't see a mention of it in #1044

i think he meant https://github.com/cosmos/voyager/issues/1043


Inspect healthcheck

Current coverage is 46.62% (diff: 30.76%)

Merging #577 into master will increase coverage by 6.95%

@@             master       #577   diff @@
==========================================
  Files           130        130
  Lines          4424       4450    +26
  Methods           0          0
  Messages          0          0
  Branches        653        661     +8
==========================================
+ Hits           1755       2075   +320
+ Misses         2508       2177   -331
- Partials        161        198    +37

Powered by Codecov. Last update 05446c8...88ad2c5

@CGNonofr Thanks for your PR. Which version(s) of Docker's API support this? Could you also add a test to DefaultDockerClientTest that checks the docker daemon actually provides this info?

This feature was added in v1.24. Unfortunately, you have to create an image with a Dockerfile containing the HEALTHCHECK [...] CMD [...] syntax. Since this api doesn't allow to create an image from a Dockerfile, I see no way to write this test.

Is this documented anywhere in the docker API docs?
On Wed, Jan 4, 2017 at 12:58 PM CGNonofr<EMAIL_ADDRESS>wrote:

This feature was added in v1.24. Unfortunately, you have to create an
image with a Dockerfile containing the HEALTHCHECK [...] CMD [...]
syntax. Since this api doesn't allow to create an image from a Dockerfile,
I see no way to write this test.
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/spotify/docker-client/pull/577#issuecomment-270439270,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdVbXXGyxcC1rac_pn2oIoNh-BVkJlPks5rO92vgaJpZM4Lao42
.

I don't think.. it's mainly used by docker-compose but I don't found any related documentation.

You can use docker-client to build an image from a Dockerfile. You need to create a test resource directory containing your Dockerfile, and use the DockerClient.build(...) method. See DefaultDockerClientTest.testBuildImageIdWithBuildargs() for a test that does this.

HEALTHCHECK is in the Dockerfile documentation. https://docs.docker.com/engine/reference/builder/

Thanks!
Test added.
(I meant in https://docs.docker.com/engine/reference/api/docker_remote_api_v1.24/#/inspect-a-container)

The code coverage test is failing but I don't know what I should do to fix it!

rebased here https://github.com/spotify/docker-client/pull/583


⚠ GitLab Server has degraded performance

In ba43ebe, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 5685 ms

Resolved: GitLab Server performance has improved in 8360d23.


Examples not correct/present

I think the examples could use some work. They don't seem to run in PowerShell...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0537d84c-b9ac-01d9-09cb-70c8eafa37cc
Version Independent ID: 61263d32-fb5e-7e74-ed87-0ee6f855ecca
Content: New-ComplianceRetentionEvent (exchange)
Content Source: exchange/exchange-ps/exchange/policy-and-compliance-retention/New-ComplianceRetentionEvent.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@ethanmsmith, there appears to be a lot in this topic that isn't complete. I'll get things started.
Thanks for the feedback.

@ethanmsmith Thank you for this feedback
I am going to get this send to the PowerShell Backlog for tracking and have them comment back when they have an update.
I was able to get this into the backlog for the PowerShell team. The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.


Fix a bug which disassociated Web ACLs right after associating them

Resolves #490

Coverage remained the same at 23.342% when pulling 1774390df7bfe6296f3b4e20d791a173c710dc07 on 490-fix into d9939a7ca689e9d3247f3a1baed55fddc595889f on master.


[BUG]

Trying to create a new visualization in the Observability Dashboard returns the error  "Unable to get default timestamp"
Steps to reproduce the behavior:

Go to 'Observability=>Dashboards'
Click on 'Create Dashboard' name test
Open new dashboard
Click on 'Add visualization=>Create new Visualization'
See error 'Unable to get default timestamp'

TypeError: Cannot read properties of undefined (reading 'toastMessage')     at ToastsApi.addError (https://l0g.invent.us/6182/bundles/core/core.entry.js:15:635096)     at PPLDataFetcher._callee$ (https://l0g.invent.us/6182/bundles/plugin/observabilityDashboards/observabilityDashboards.chunk.4.js:1:7463)     at tryCatch (https://l0g.invent.us/6182/bundles/plugin/observabilityDashboards/observabilityDashboards.chunk.3.js:625:70469)     at Generator.invoke [as _invoke] (https://l0g.invent.us/6182/bundles/plugin/observabilityDashboards/observabilityDashboards.chunk.3.js:625:74485)     at Generator.next (https://l0g.invent.us/6182/bundles/plugin/observabilityDashboards/observabilityDashboards.chunk.3.js:625:71664)     at asyncGeneratorStep (https://l0g.invent.us/6182/bundles/plugin/observabilityDashboards/observabilityDashboards.chunk.4.js:1:2978)     at _next (https://l0g.invent.us/6182/bundles/plugin/observabilityDashboards/observabilityDashboards.chunk.4.js:1:3289)
Environment

kubernetes version 1.26.6
https://opster.github.io/opensearch-k8s-operator chart version  "2.3.1"
OpenSearchCluster version 2.8.0
OpenSearch Dashboards version 2.8.0
Plugin observabilityDashboards version 2.8.0

Screenshots

Сonfig where I can reproduce that:
https://github.com/lazarevdmitriy/images/blob/main/opensearch-cluster.yaml

@lazarevdmitriy this is a known bug, which should be fixed in the upcoming release CC @mengweieric


error: package com.horcrux.rnsvg does not exist

Bug
I'm getting a compile error below for new architecture on android with RN 0.72.0 and react-native-svg 13.9.0
Replaceing all instances of com.horcrux.rnsvg with com.horcrus.svg in the code base makes everything compile. But I suspect this might not be the right answer :)
I suspect this is due to the namespace changes mentioned in the 0.72 release notes.
Unexpected behavior

I see the following error messages.
> Task :react-native-svg:compileDebugJavaWithJavac FAILED
note: generating mipmap/ic_launcher_round with config "anydpi-v26" for round icon compatibility.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/8.0.1/userguide/command_line_interface.html#sec:command_line_warnings
477 actionable tasks: 16 executed, 461 up-to-date

info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor

/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:26: error: package com.horcrux.rnsvg does not exist
import com.horcrux.rnsvg.NativeSvgRenderableModuleSpec;
                        ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:33: error: cannot find symbol
class RNSVGRenderableManager extends NativeSvgRenderableModuleSpec {
                                     ^
  symbol: class NativeSvgRenderableModuleSpec
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/SvgViewModule.java:17: error: package com.horcrux.rnsvg does not exist
import com.horcrux.rnsvg.NativeSvgViewModuleSpec;
                        ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/SvgViewModule.java:21: error: cannot find symbol
class SvgViewModule extends NativeSvgViewModuleSpec {
                            ^
  symbol: class NativeSvgViewModuleSpec
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/SvgPackage.java:37: error: incompatible types: Class<SvgViewModule> cannot be converted to Class<? extends NativeModule>
      SvgViewModule.class,
                   ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/SvgPackage.java:38: error: incompatible types: Class<RNSVGRenderableManager> cannot be converted to Class<? extends NativeModule>
      RNSVGRenderableManager.class,
                            ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:41: error: method does not override or implement a method from a supertype
  @Override
  ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:48: error: method does not override or implement a method from a supertype
  @Override
  ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:65: error: method does not override or implement a method from a supertype
  @Override
  ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:91: error: method does not override or implement a method from a supertype
  @Override
  ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:113: error: method does not override or implement a method from a supertype
  @Override
  ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:148: error: method does not override or implement a method from a supertype
  @Override
  ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:199: error: method does not override or implement a method from a supertype
  @Override
  ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:230: error: method does not override or implement a method from a supertype
  @Override
  ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:252: error: method does not override or implement a method from a supertype
  @Override
  ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/RNSVGRenderableManager.java:255: error: cannot find symbol
      ReactApplicationContext context = getReactApplicationContext();
                                        ^
  symbol:   method getReactApplicationContext()
  location: class RNSVGRenderableManager
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/SvgPackage.java:264: error: incompatible types: SvgViewModule cannot be converted to NativeModule
        return new SvgViewModule(reactContext);
               ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/SvgPackage.java:266: error: incompatible types: RNSVGRenderableManager cannot be converted to NativeModule
        return new RNSVGRenderableManager(reactContext);
               ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/SvgViewModule.java:29: error: method does not override or implement a method from a supertype
  @Override
  ^
/home/johnf/work/gladly/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/SvgViewModule.java:83: error: method does not override or implement a method from a supertype
  @Override
  ^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
20 errors

FAILURE: Build failed with an exception.

Environment info
Run react-native info in your terminal and copy the results here. Also, include the precise version number of this library that you are using in the project
React native info output:
System:
  OS: Linux 6.3 Ubuntu 22.10 22.10 (Kinetic Kudu)
  CPU: (32) x64 AMD Ryzen 9 7950X 16-Core Processor
  Memory: 36.81 GB / 61.95 GB
  Shell:
    version: 5.2.2
    path: /bin/bash
Binaries:
  Node:
    version: 18.16.0
    path: /tmp/yarn--1687410514240-0.9755397388575526/node
  Yarn:
    version: 1.22.19
    path: /tmp/yarn--1687410514240-0.9755397388575526/yarn
  npm:
    version: 9.6.7
    path: ~/.nvm/versions/node/v18.16.0/bin/npm
  Watchman:
    version: 4.9.0
    path: /usr/bin/watchman
SDKs:
  Android SDK:
    API Levels:
      - "33"
      - "34"
    Build Tools:
      - 28.0.3
      - 29.0.2
      - 29.0.3
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 31.0.0
      - 32.1.0
      - 33.0.0
      - 33.0.0
      - 34.0.0
      - 34.0.0
    System Images:
      - android-33 | Google APIs Intel x86 Atom_64
      - android-33 | Google Play Intel x86 Atom_64
    Android NDK: Not Found
IDEs:
  Android Studio: AI-213.7172.25.2113.9123335
Languages:
  Java:
    version: 11.0.19
    path: /usr/bin/javac
  Ruby:
    version: 3.0.4
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.72.0
    wanted: ^0.72.0
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: true
  newArchEnabled: Not found

Done in 2.47s.

Library version: 13.9.0
Steps To Reproduce
I still need to do the below, but putting this here now as I expect other 0.72 users will hit this
Issues without reproduction steps or code are likely to stall.

git clone https://github.com/user/rnsvg-bug-repro
cd rnsvg-bug-repro
yarn
yarn ios
yarn android
...

Describe what you expected to happen:

Short, Self Contained, Correct (Compilable), Example
If you are having a problem with some code and seeking help, preparing a Short, Self Contained, Correct Example (SSCCE) is very useful. But what is an SSCCE?
It is all in the name, really. Take a look at each part. The version prepared for others to see should be:
Short (Small) - Minimise bandwidth for the example, do not bore the audience.
Self Contained - Ensure everything is included, ready to go.
Correct - Copy, paste, (compile,) see is the aim.
Example - Displays the problem we are trying to solve.
http://www.sscce.org/

I just had the same issue after running v0.72 with newArchEnabled = true

Facing the same issue. Any update on this?

Clearing build cache got rid of this for me

Yeah, it kinda seems like cache issues. Please reinstall your node_modules and remove the build folder for android and it should work correctly then. I'll close it. Feel free to comment here if something is wrong and we can always reopen it then.

@WoLewicki when I ran the Android Analyzer, I encountered the following error:
Package name 'com.horcrux.rnsvg' does not correspond to the file path 'com.horcrux.svg'.
While this isn't a blocker for us, I noticed the package name appears to be incorrect. Was this unintentional, or is there a specific reason behind it? I also observed that files from the com.horcrux.svg package were generated, which leads me to believe there might be a rationale behind this discrepancy.

In case anyone finds this issue and thinks, "oh, I don't need to delete my node_modules" - you're wrong. Follow the advice above or you'll waste a lot of time just like me.

Yeah, it kinda seems like cache issues. Please reinstall your node_modules and remove the build folder for android and it should work correctly then. I'll close it. Feel free to comment here if something is wrong and we can always reopen it then.


Unify Router0 and RouterN and eliminate / case class

This is a proof-of-concept and isn't ready to be merged. It unifies Router0 and RouterN and gets rid of the / case class while leaving usage mostly unchanged (it requires some changes to the RouterSpec tests, but none to the example projects).
I've removed variance annotations in a few places for the sake of simplicity, but some of these could be added back if people want them.

Current coverage is 89.73%

Merging #306 into master will change coverage by -0.68% by edb204e

Powered by Codecov

Woot! Codecov has started commenting PRs!
This is unbelievably cool @travisbrown! Great and very smart simplification!

Okay, I've renamed Matcher and made exec package-private.
A couple of other questions:
I've asked about a better name for Smash, and I'm not sure it belongs in the route package, since it's very generic. It be nice if Shapeless included it, but I can understand why it doesn't.
Anyone know why the *ToMatcher implicit conversions in route don't work if they're moved to the Router companion object?
This new stuff still needs tests, and there's some commented-out stuff that needs to be deleted.

I noticed the same issue with *ToMatcher implicit conversions and I have no idea why is that.

This is ready to go as far as I'm concerned, but I want to be sure everyone's on board with the invariantization of Router, etc.

I'm personally pretty happy with invariant Router. Let's ask other folks on Gitter.

Seems that there are no concerns about this simplification. So we should probably merge this in since I can't wait this to land in master!
Amazing job, @travisbrown!


Timer text ellipsis since 2.1.0

Since the last patch the timer received an ellipsis while I haven't changed the font size. I suspect this happened after playing with the left/right alignment to see what it looks like. I can fix this by lowering the font size so it's not a big deal for me but I believe this can be turned off for font strings.

Alright, I'll look into it!

Yup, you were right. I've set all texts to not ellipsize, should be better now.


add "leaderboard" showing stats about users and their annotations

Will need to explore what to show but the idea is to show information about all users of the system, or at least the "top n" users.
Could have e.g., sparklines for annotation activity per user

@joefutrelle Can you link to a screenshot of the type of plot you're looking for?
The leaderboard concept is definitely fine as a whole, we just need to determine what "top" means:

Most annotations?
Most completed collections?
Something else?

Lots of options here, so I'll request some user feedback to narrow down the scope.

Move forward based on what information we have available


Logstash can not read data from kafka

logstash can not read data from kafka ;from kafka, roup_id's offset about one topic can not change;
why???

@xiaoxinba can you add more details? this report is not enough for us to help debug.
Also, please post these kind of questions in our forum? The forum is also the best place to debug config issues, getting help etc. Github is mainly used for issues/enhancements. Thanks!

@suyograo   Yes i know , the more detail see: https://discuss.elastic.co/t/logstash-kafka-input-plugin-can-not-read-data-from-kafka/98164;
thank you !!!