fieldmap not found or ignored

Hi, I'm trying to apply Susceptibility Distortion Correction with fieldmaps from PEPOLAR using Philips scanner. But fmriprep seemed to bypass this step for some reason.
I did:
docker run -it --rm -v $PWD/uc-151120:/data:ro -v $PWD/uc-151120-fmriprep:/out -v /mnt/disks/disk-1/software/freesurfer/license.txt:/opt/freesurfer/license.txt poldracklab/fmriprep:latest -w $PWD/fmriprep-tmp /data /out participant --participant-label 2 -n-cpus 1 --output-space template --use-aroma --no-freesurfer
The folder structure is in BIDS format:
uc-151120
├── dataset_description.json
├── dir-AP_epi.json
├── dir-PA_epi.json
├── participants.tsv
├── sub-1
│   ├── anat
│   │   ├── sub-1_T1w.json
│   │   ├── sub-1_T1w.nii.gz
│   │   ├── sub-1_T2map.json
│   │   └── sub-1_T2map.nii.gz
│   ├── fmap
│   │   ├── sub-1_dir-AP_epi.json
│   │   ├── sub-1_dir-AP_epi.nii.gz
│   │   ├── sub-1_dir-PA_epi.json
│   │   └── sub-1_dir-PA_epi.nii.gz
│   └── func
│       ├── sub-1_task-rest_bold.json
│       └── sub-1_task-rest_bold.nii.gz
├── sub-2
│   ├── anat
│   │   ├── sub-2_T1w.json
│   │   ├── sub-2_T1w.nii.gz
│   │   ├── sub-2_T2map.json
│   │   └── sub-2_T2map.nii.gz
│   ├── fmap
│   │   ├── sub-2_dir-AP_epi.json
│   │   ├── sub-2_dir-AP_epi.nii.gz
│   │   ├── sub-2_dir-PA_epi.json
│   │   └── sub-2_dir-PA_epi.nii.gz
│   └── func
│       ├── sub-2_task-rest_bold.json
│       └── sub-2_task-rest_bold.nii.gz
...
But the log showed:
180201-21:59:04,665 workflow WARNING:
No fieldmaps found or they were ignored, building base workflow for dataset /data/sub-2/func/sub-2_task-rest_bold.nii.gz.
I couldn't find any similar post before that solved it. Any help would be appreciated.

Do your *_epi.json include IntendedFor fields? See #783

I see. Just wonder how to specify the field in group level? From the latest spec 8.9.4 on page 27, it refers to a particular file under fmap directory of a single participant. Can I do it like "IntendedFor": "func/" in the _epi.json out of all subjects? Thanks in advance.

In such case you need to list all target files explicitly. This should be done in a form of a JSON list. For example: ["item1, "item2", "item3"]

Just in case it is helpful to anyone: I had to add "ses-X/func/..." for a subject who had multiple sessions (for the previous fmriprep version).

Thanks for the tip. The validator should check if the IntendedFor fields are valid (let me know if it doesn't!)

The validator says it is a valid BIDS dataset when the "IntendedFor" field only contains the filename (without the /func and without the /ses-X) info.

hang on! I might have confused two outputs- checking now!

Mea culpa. Got things confused.
The 2018 9and the 1.0.0-rc6 version finds and assigns the fieldmaps to the correct bold run beautifully when not having func/ or ses-X/ in the IntendedFor field.

Sure. You mean this line here
"IntendedFor":"sub-subj1_ses-1_task-rest_run-01_bold.nii.gz",
Or the complete json file?
(I use: https://github.com/jmtyszka/bidskit for converting to BIDS and there is a lot of scanner/sequence specific information is in the json file too so if you want to whole thing maybe I should clean it up a bit).
I should add that fmriprep is still running, however the output file indicates it found the correct epi files and it seems it is creating the fieldmaps (at least I don't see an error just yet - however I'm also not an expert and might have missed some details).
E.g. here:
180203-00:26:28,867 workflow IMPORTANT:
Creating bold processing workflow for "/data/folder/source/sub-subj1/ses-1/func/sub-subj1_ses-1_task-rest_run-01_bold.nii.gz" (0.18 GB / 450 TRs). Memory resampled/largemem=0.74/1.57 GB.
180203-00:26:29,494 workflow IMPORTANT:
Fieldmap estimation: type "epi" found
I'll post more once it ran through!

Thanks that single line was enough.
Does the validator give you any feedback with this JSON?
I'm asking because technically it's incorrect. It should be:
"IntendedFor":"func/sub-subj1_ses-1_task-rest_run-01_bold.nii.gz"

When I run the data in the source folder through the online version of the bids validator (http://incf.github.io/bids-validator/) I get no related errors. I just tested the validation as well with "IntendedFor":"func/sub-subj1_ses-1_task-rest_run-01_bold.nii.gz" - no errors.
Then I tested it with a obviously wrong input "IntendedFor":"sub-subj1_ses-1_test.nii.gz" - no error. (all data have the same dicom input)
The only thing I changed is in the conversion/Protocol_Translator of the bidskit converter (https://github.com/jmtyszka/bidskit) which (among all other things) adds the "IntendedFor" field.
Given that the bids validator doesn't give and error my guess is that it might not recognize that line/content at all?

(ps also tested it when I added the "IntendedFor" field by hand - no error with the validator)

I have updated the validator (https://github.com/INCF/bids-validator) to be
more strict about the correct IntendedFor values. Please let me know if you
experience any problems.
Best,
Chris
On Sat, Feb 3, 2018 at 1:54 PM, Dorit Kliemann<EMAIL_ADDRESS>wrote:

(ps also tested it when I added the "IntendedFor" field by hand - no error
with the validator)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/fmriprep/issues/958#issuecomment-362857569,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOkp6C12drF00X8SNUF961qVZ5tZvNlks5tRNWNgaJpZM4R2ZRD
.

yup - no validator is complaining if func/ is missing.  :)
Thanks!

Awesome - thanks for testing.
Best,
Chris
On Mon, Feb 5, 2018 at 9:45 AM, Dorit Kliemann<EMAIL_ADDRESS>wrote:

yup - no validator is complaining if func/ is missing. :)
Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/fmriprep/issues/958#issuecomment-363162603,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOkpzwan7KnW4T0T7SWPOx4zFzhk-iiks5tRz5JgaJpZM4R2ZRD
.


Mobile friendly frontend

Make the client side display well on mobile phones

I think I can handle this one if you want.

Hi James,
That would be excellent if you could help out!
I've already created a branch for this issue called mobile-design, so checkout that branch. I'm not sure exactly how it works, if you are able to pull request to that branch, and then if it will show up in the pull request I've opened. If not, I will close my pull request, and then you can open one directly to the master.

Hey @mrbrianevans, the mobile view is looking a lot better, but let me know if there's anything else I can adjust.
I also thought it might look nice to replace "Our repository" with the github logo. If you don't like it, I can change it back, but I thought the logo might look nice.
I had trouble switching onto your branch, so I pushed from a branch I made. Not sure what the problem was.
Cheers,
James

Okay, I've created a new pull request from your branch to mine. GitHub logo in footer sounds good!

Hey @jgsheppa , just had a look, and its looking good!
There was just one issue which is flex-direction: row-reverse in footer.css was causing the dropdowns and textareas to flip position, so I removed that. Otherwise, all good, I'm merging to master.


Fixing resource version logic flaw

Description

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist

[ ] Unit tests and e2e tests updated
[ ] Documentation updated

Superseded by #402


Maproulette: User Metric 'Custom' per Day meteric is broken

Hi if you go to the User Metric Tab on MapRoulette, in the middle of the page where you see "Completed Tasks" you use to be able to filter by date to tell how many tasks you completed in any one give day, this is currently broken as it just shows 0% and no tasks completed for anyone. This is useful for workflows to determine performance, and would improve performances for those that have a goal to hit.

Thanks for the report, @v-cofor !


Error with esc key handling in calcite.js

Looks like there is an issue in calcite-js with the key handling for the esc key.
Reproducible steps:

Navigate to the content page on ArcGIS Online.
Open the dev console and press the esc key and note the following error in the dev console:

    at main.js:3341
    at Array.forEach (<anonymous>)
    at g (main.js:3341)
    at b (main.js:3349)
    at F.emit (main.js:3368)
    at HTMLDocument.<anonymous> (main.js:3369)

Looks like this is related to the closeDrawer logic. When there is no drawer, the handler is still attached, so you get an error. Targeting next minor release.

Fixed, will be part of 1.2.0


deploy evmos testnet in staging

Motivation

Solution

PR Checklist

[ ] Added Tests
[ ] Updated Documentation
[ ] Updated CHANGELOG.md for the appropriate package

Governance tx has been executed on rinkeby, waiting for it to be relayed to kovan and goerli


Revert "Only run gulp build:dist if we're in production"

Reverts GoogleChrome/sw-precache#189

Sorry, @petele, I'll come up with a different approach.


heroku setup

Current coverage is 57.86%

Merging #53 into master will increase coverage by +0.24% as of 3b52512

@@            master     #53   diff @@
======================================
  Files           13      13
  Stmts          177     178     +1
  Branches         0       0
  Methods          0       0
======================================
+ Hit            102     103     +1
  Partial          0       0
  Missed          75      75

Review entire Coverage Diff as of 3b52512

Powered by Codecov. Updated on successful CI builds.


Backward/forward navigation bug

Steps to reproduce:

navigate to any project file
Go to Definition on something located in other file
try to get back by hotkey for jump_location_backward

Actual result:

nothing happened

Expected result:

navigate back to original file and line

I can't seem to reproduce this, running lapce 0.2.5


DeprecationWarning for resolve

See screenshot in #10, cc @crami

Thought you will spot that, so I included it in the screenshot :-)


🚀 Feature Request: Add flag to hide wrangler CLI UI box

Describe the solution
I'd like to request a cli flag or non-interactive option to be added that hides the CLI UI box that is created by wrangler that gives the following options

[b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit

I get this when running wrangler dev but this would be applicable to any other wrangler command that spawns that box.

My use case for this is I'm using the wrangler CLI in the context of a monorepo (turborepo) which has it's own CLI UI to combine multiple process logs one view and it seems to be pretty incompatible with the wrangler UI as it repeats that box outline for each line logged. I still would like to see the logs that are produced by application just not the "UI" that surrounds it as It's quite hard to view logs this way for me.

I could see how this could also be useful in other non-interative CLI environments as well.

I'm facing same issue with Nx monorepo tool. A feature to hide or disable the UI box will be appreciated.


Show currently targeted enemy

Should be simple enough according to https://github.com/ensingm2/SteamMonsterGameScript/blob/master/automator.js
function addPointer() {
	g_Minigame.m_CurrentScene.m_rgFingerTextures = [];
	var w = 26;
	var h = 49;

	for( var y = 0; y < 4; y++)
	{
		for( var x = 0; x < 5; x++ )

		{
			g_Minigame.m_CurrentScene.m_rgFingerTextures.push( new PIXI.Texture( g_rgTextureCache.pointer.texture, {
				x: x * w,
				y: y * h,
				width: w,
				height: h
			} )
			);
		}
	}

	g_Minigame.m_CurrentScene.m_nFingerIndex = 0;

	g_Minigame.m_CurrentScene.m_spriteFinger = new PIXI.Sprite( g_Minigame.m_CurrentScene.m_rgFingerTextures[g_Minigame.m_CurrentScene.m_nFingerIndex] );
	g_Minigame.m_CurrentScene.m_spriteFinger.scale.x = g_Minigame.m_CurrentScene.m_spriteFinger.scale.y = 2;

	g_Minigame.m_CurrentScene.m_containerParticles.addChild( g_Minigame.m_CurrentScene.m_spriteFinger );
}

run addPointer() once and it will move whenever an enemy takes damage

:nail_care: Looks amazing

Will need to override this function so it doesn't go away on manual click https://github.com/SteamDatabase/SteamTracking/blob/85496cc56be0c3fdaa111458a2d291e5005047d4/Scripts/MiniGame/TowerAttack/running.js#L1864

Won't need to if we disable manual clicks when autoclicker is enabled. #63


Securerage

Environment

OS: Linux
rage version:  0.9.2

What were you trying to do
What happened
<insert terminal transcript here>
```termux

Closing due to insufficient (no) information about the problem. If you have information to provide, please add it.


CodeResetEvents should submit the event batch to the backend.

#643 but without the CLA issues.

new session ID is already created --> LearnerViewDirective.js:1226 calls initLearnerViewDirective().


Added documentation for namespace

Added name space documentation for the auto generated cakebuild.net docs.

NameSpaceDoc? Is that new?

It's a Cake unique concept as there's no standard to document namespaces.
You can see result here

Not Cake specific. Supported by SandCastle and other documentation tools.

Cool didn't know that :+1:


Updated network option

This relates to issue 379.
External is not a recognized Docker network option, but it only fails on some machines.  This ought to work anywhere, but its only been tested on a Mac, and an old one at that,

That's weird since external is defined in the documentation: https://docs.docker.com/compose/compose-file/06-networks/#external

Though it looks like the default is internal: false so would it be worth removing that config option all together?

I would agree with @misilot that internal:false can be removed from the yaml files. In the tech call it was mentioned that the original purpose for this (external:true) was to be able to run isle 7 at the same time as isle-dc. I don't know if anyone is using it this way anymore but I highly doubt it.


Is there a way to auto complete when inputting function parameters?

Maybe my description is not accurate enough. So I prepared pictures.

I need to press ESC twice to trigger auto completion.

ctrl+space also triggers the autocomplete menu. In this case I think it is VSCode that decides to not request autocompletions. Language servers can't trigger autocompletion themself AFAIK.

I tried ctrl+space to no avail even pressed ESC twice. Then I tried Go, no problem, it seems that it is not a limitation of VSCode.

By the way, if I want to use tokio::sync::mpsc::channel, I have to input full path. Is it possible to only inputtokiompscchan to make it auto complete?

By the way, if I want to use tokio::sync::mpsc::channel, I have to input full path. Is it possible to only inputtokiompscchan to make it auto complete?

If you type channel rust-analyzer may give you an auto-import autocomplete suggestion. If you use it use tokio::sync::mpsc::channel; will be added at the top of your file.

OK. Thanks for your tip. If the function parameter auto-completion is no problem in your test, I will re-issue an issue in VSCode.

I didn't actually test it myself.

solved


Updating plugin on https://plugins.qgis.org/plugins/

Description
When click in the "Owners" drop-down list (a droplist box, very big by the way), if you don't have the name you search for, or somehow, you just clicked inside of it, there is no way to "unclick" it, and some random person will be classified as Owner of your plugin. Down here is my plugin URL, but could be anyone's.

Page URL: https://plugins.qgis.org/plugins/bhcgeoqgis/update/

I uploaded my plugin 2 years ago and already had many downloads, but I accidentally DELETED it. THE PROBLEM HAPPENED when I was updating it and I clicked in the "Owners" looking to find my name, and it was not there. But somehow, when you just click inside of it to search yourself (to type some name), there is no way to "unclick" it, and some random person was classified as Owner. So after I saved it (I did't now this would be a problem), there was no way to change it. I tested to click in the name of that random person and under his "repository" there was my plugin as if he was Owner under his name. There, there was the possibility of me deleting "his" plugin. So I did it, not knowing that would delete under me too. So now my plugin has been deleted and I hope it may be replaced just as my old one was, with the number of downloads, stars and everything, and still in the GitHub.

@romariocarvalhoneto please let me know what your (new?) username is for plugins.qgis.org
I had a look at the server, but the only bhcgeoqgis.zip I can find is very recent (2020), ALSO in a backup of 2018 and older... But at least I can revive the recent one for you if you sent me an username.
The others you apparently really deleted?
Or did you use another name for the zip? I searched for *bhc*

My username still the same: romariocarvalho. The name of the zip is
bhcgeoqgis. I did not change the name of the zip and the one I uploaded is
the same as the old one. He still at the GitHub (
https://github.com/romariocarvalhoneto/BHCgeo).
Will it be revived with the number of downloads and star I previously had?
Its very important to me.
Em ter., 5 de mai. de 2020 às 05:34, Richard Duivenvoorde <
<EMAIL_ADDRESS>escreveu:

@romariocarvalhoneto https://github.com/romariocarvalhoneto please let
me know what your (new?) username is for plugins.qgis.org
I had a look at the server, but the only bhcgeoqgis.zip I can find is very
recent (2020), ALSO in a backup of 2018 and older... But at least I can
revive the recent one for you if you sent me an username.
The others you apparently really deleted?
Or did you use another name for the zip? I searched for bhc
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/qgis/QGIS-Website/issues/751#issuecomment-623928047,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMPNT5BWJRXD6A45TBNGJCTRP7FRXANCNFSM4MZCWAGQ
.

For what I know you start from scratch yes, unless we are going to 'fix' the database from hand. If it is THAT important, please sent an email to PSC, but it is extra work for us, we have never done that. So I would just add it as a new plugin.
(if I search for bhc now I see 6x None.. I think you cleaned up to thorough...)

OK. I did send an email to PSC. By the way, the name of the plugin is BHCgeo but the name of the zip folder is bhcgeoqgis. I would thank you if my "new" old plugin may be available to download. Its better than nothing. Another question just came now: When we add a new version of the plugin, the number of downloads restart counting or just keep up?

@elpaso would there be a way at all to recover those number?

Restore download count
@romariocarvalhoneto so I looked in a backup of the database from a few days ago:
plugins.qgis.org=# select * from plugins_pluginversion where plugin_id =1753;
  id  | plugin_id |          created_on           | downloads | created_by_id | min_qg_version |     version     | changelog |           package            | experimental | approved | max_qg_version | external_deps
------+-----------+-------------------------------+-----------+---------------+----------------+-----------------+-----------+------------------------------+--------------+----------+----------------+---------------
 8873 |      1753 | 2019-07-03 02:40:18.274651+01 |       425 |          3830 | 003.000.000    | 000.001.###.### |           | packages/2019/bhcgeoqgis.zip | t            | t        | 003.099.000    |
(1 row)

From that we can see you had 425 downloads.
Then I updated the production database:
qgis_plugins=# select * from plugins_plugin where name like '%BHC%';
  id  |          created_on           |         modified_on          | created_by_id |                   homepage                    | package_name |  name  |                     description                     |           icon           | downloads | featured |                  repository                   |                       tracker                        | deprecated |                                author                                |            email            | rating_votes | rating_score |                                                                                about                                                                                | server
------+-------------------------------+------------------------------+---------------+-----------------------------------------------+--------------+--------+-----------------------------------------------------+--------------------------+-----------+----------+-----------------------------------------------+------------------------------------------------------+------------+----------------------------------------------------------------------+-----------------------------+--------------+--------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------
 2051 | 2020-05-04 19:40:13.725081+00 | 2020-05-05 21:01:47.84633+00 |          3830 | https://github.com/romariocarvalhoneto/BHCgeo | bhcgeoqgis   | BHCgeo | Calculates the Climatic Water Balance in each pixel | packages/2020/figBHC.png |         2 | f        | https://github.com/romariocarvalhoneto/BHCgeo | https://github.com/romariocarvalhoneto/BHCgeo/issues | f          | Carvalho Neto, R.M. - UFSM; Cruz, J.C. - UFSM; Cruz, R.C. - UNIPAMPA |<EMAIL_ADDRESS>|            0 |            0 | The Climatic Water Balance (CWB or BHC in portuguese) of Thornthwaite and Mather (1955) is a soil water monitoring method that considers the soil as an active ingredient in its calculation as a reservoir that hinders the exit of water as it dries. In periods where the total Precipitation (P) is less than the Potential Evapotranspiration (PET), the retained water becomes a function of this potential demand (P-PET < 0) and of the Available Water Capacity (AWC) used in the calculations. If there is a sequence of periods in this condition, the water retained in the soil will be a sequential function of the accumulated negative values of P - PET, that is, the accumulated potential loss. Therefore, this Plugin needs as input, 12 rasters of P, 12 rasters of ETP and one raster of the AWC, being these 12 rasters one raster for each month of the year. | f
(1 row)

Then I used the id of the plugin to verify the version:
qgis_plugins=# select id, plugin_id, downloads from plugins_pluginversion where plugin_id=2051;
  id   | plugin_id | downloads
-------+-----------+-----------
 10240 |      2051 |         2
(1 row)

Finally, I updated it to match the download count +2 from the new uploaded release:
qgis_plugins=# update plugins_pluginversion set downloads=427 where id=10240;
UPDATE 1

Restore download count
On my restored backup:
plugins.qgis.org=# select rating_votes, rating_score from plugins_plugin where name like '%BHCgeo%';
 rating_votes | rating_score
--------------+--------------
            1 |            5
(1 row)

On production:
qgis_plugins=# select rating_votes, rating_score from plugins_plugin where name like '%BHCgeo%';
 rating_votes | rating_score
--------------+--------------
            0 |            0
(1 row)

Reinstating on the production:
qgis_plugins=# update plugins_plugin set rating_votes=1, rating_score=5 where id= 2051;
UPDATE 1
qgis_plugins=# select rating_votes, rating_score from plugins_plugin where name like '%BHCgeo%';
 rating_votes | rating_score
--------------+--------------
            1 |            5
(1 row)

Everything should be back like it was. Please click with caution going forward!

thx @timlinux

It still not showing the downloads.

one more thing to get the total downloads updated:
qgis_plugins=# update plugins_plugin set downloads=430 where id=2051;
UPDATE 1
qgis_plugins=# select id, downloads from plugins_plugin where name like '%BHCgeo%';
  id  | downloads
------+-----------
 2051 |       430
(1 row)

@romariocarvalhoneto please wait again for the cache to update

@timlinux Thank you so much. It's solved now.


Clean up System.Web dependencies

Required as per issue #8.

This must be tested (I haven't tried to import the SQLCLR dll) but the System.Web dll is no longer used since https://github.com/simgreci/SQLXEtoEventHub/commit/7f25ad882d154167e0afc933b2faa69a963d5459

Great Job Francesco, i make changes to the SQLCLR stored procedure code and test it.

Damnit! Dependency graph for xetohub clr stored procedure still resolve System.Web:
Msg 10301, Level 16, State 1, Line 1
Assembly 'SQLXEtoEventHubSp' references assembly 'system.web, version=<IP_ADDRESS>, culture=neutral, publickeytoken=b03f5f7f11d50a3a.', which is not present in the current database. SQL Server attempted to locate and automatically load the referenced assembly from the same location where referring assembly came from, but that operation has failed (reason: 2(The system cannot find the file specified.)). Please load the referenced assembly into the current database and retry your request.

I've cleaned on system.web reference removing log4net dependency be1ae9a. Continue to work on other issue:
Assembly 'SQLXEtoEventHubSp' references assembly 'system.runtime.serialization,


proxy_next_upstream - not only boolean value

proxy_next_upstream error timeout invalid_header http_403 http_500 http_502 http_503 http_504; # reported as error value

PyCharm 2017.1 EAP
Build #PY-171.3224.4, built on February 14, 2017
PyCharm EAP User
JRE: 1.8.0_112-release-b702 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0


JK BMS Error after connected

Hi all,
I see all issues and dont see any similar.
I have a JK-B1A20S15P
Hardware Ver: V10.XW
Soft Ver: V10.07
Manuf. Date: 2022-02-20
Version: V4.11.0
Its working fine for more than 1 year and now I just discover Home Assistant and I would like to connect my BMS with HA, but I dont understand where is my problem
My Home Assistant is version:
Home Assistant 2023.4.5
Supervisor 2023.04.0
Operating System 10.0
Frontend 20230411.1 - latest
MQTT is well configured and working fine with other components,
Configuration in Batmon (Version 0.0.57)

address: 20:21:11:28:18:CE
type: jk
alias: JK-B1A20S15P
debug: true

I try with PIN, without PIN, enabling and disabling keep alive, etc.....
Because I am not a progrmmer, can anyone help me with the next log?
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
19:26:13 INFO [main] BT Discovery:
19:26:18 INFO [main] BT Device   JK-B1A20S15P   address=20:21:11:28:18:CE
19:26:18 INFO [main] BT Device   09-D0-C6-BF-57-65   address=09:D0:C6:BF:57:65
19:26:18 INFO [main] BT Device   5B-5E-31-AC-66-E9   address=5B:5E:31:AC:66:E9
19:26:18 INFO [main] BT Device   6C-5D-CF-20-91-06   address=6C:5D:CF:20:91:06
19:26:18 INFO [main] BT Device   49-CD-CF-DF-10-1B   address=49:CD:CF:DF:10:1B
19:26:18 INFO [main] BT Device   43-6E-50-51-AE-C9   address=43:6E:50:51:AE:C9
19:26:18 INFO [main] BT Device   Mi Smart Band 6   address=C6:77:22:7A:07:AE
19:26:18 INFO [main] BT Device   7F-7D-55-9E-BE-97   address=7F:7D:55:9E:BE:97
19:26:18 INFO [main] Verbose logging enabled
19:26:18 INFO [main] Verbose log for 20:21:11:28:18:CE enabled
19:26:18 INFO [bt] BMS JKBt(20:21:11:28:18:CE) keep alive enabled
19:26:18 INFO [main] connecting mqtt mqttuser@core-mosquitto
19:26:18 DEBUG [client] Sending CONNECT (u1, p1, wr0, wq0, wf0, c1, k60) client_id=b''
19:26:18 DEBUG [client] Received CONNACK (0, 0)
19:26:18 INFO [main] Fetching 1 BMS + 0 others serially, period=20.00s, keep_alive=True
19:26:18 INFO [sampling] connecting bms JKBt(20:21:11:28:18:CE)
19:26:18 DEBUG [client] Connecting to device @ 20:21:11:28:18:CE with hci0
19:26:18 INFO [main] mqtt watchdog loop started with timeout 120.0s
19:26:18 DEBUG [scanner] cached devices: {'/org/bluez/hci0/dev_7F_7D_55_9E_BE_97': {'Address': '7F:7D:55:9E:BE:97', 'AddressType': 'random', 'Alias': '7F-7D-55-9E-BE-97', 'Paired': False, 'Bonded': False, 'Trusted': False, 'Blocked': False, 'LegacyPairing': False, 'Connected': False, 'UUIDs': [], 'Adapter': '/org/bluez/hci0', 'ManufacturerData': {76: b'\x10\x05\x02\x18>\xd6\x8a'}, 'ServicesResolved': False, 'AdvertisingFlags': b'\x1a'}, '/org/bluez/hci0/dev_C6_77_22_7A_07_AE': {'Address': 'C6:77:22:7A:07:AE', 'AddressType': 'public', 'Name': 'Mi Smart Band 6', 'Alias': 'Mi Smart Band 6', 'Paired': False, 'Bonded': False, 'Trusted': False, 'Blocked': False, 'LegacyPairing': False, 'Connected': False, 'UUIDs': ['0000fee0-0000-1000-8000-00805f9b34fb'], 'Adapter': '/org/bluez/hci0', 'ManufacturerData': {343: b'\x02\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\x03\xc6w"z\x07\xae'}, 'ServicesResolved': False, 'AdvertisingFlags': b'\x06'}, '/org/bluez/hci0/dev_5B_5E_31_AC_66_E9': {'Address': '5B:5E:31:AC:66:E9', 'AddressType': 'random', 'Alias': '5B-5E-31-AC-66-E9', 'Paired': False, 'Bonded': False, 'Trusted': False, 'Blocked': False, 'LegacyPairing': False, 'Connected': False, 'UUIDs': [], 'Adapter': '/org/bluez/hci0', 'ManufacturerData': {76: b'\x10\x05\x02\x1c<\x91U'}, 'ServicesResolved': False, 'AdvertisingFlags': b'\x1a'}, '/org/bluez/hci0/dev_20_21_11_28_18_CE': {'Address': '20:21:11:28:18:CE', 'AddressType': 'public', 'Name': 'JK-B1A20S15P', 'Alias': 'JK-B1A20S15P', 'Paired': False, 'Bonded': False, 'Trusted': True, 'Blocked': False, 'LegacyPairing': False, 'Connected': False, 'UUIDs': ['0000ffe0-0000-1000-8000-00805f9b34fb'], 'Adapter': '/org/bluez/hci0', 'ManufacturerData': {19274: b'\x00\x01'}, 'ServicesResolved': False, 'AdvertisingFlags': b'\x06'}}
19:26:18 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE): ['org.bluez.Device1', {'RSSI': <dbus_next.signature.Variant ('n', -73)>}, []]
19:26:18 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0): ['org.bluez.Adapter1', {'Discovering': <dbus_next.signature.Variant ('b', True)>}, []]
19:26:18 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE): ['org.bluez.Device1', {'RSSI': <dbus_next.signature.Variant ('n', -78)>}, []]
19:26:18 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE): ['org.bluez.Device1', {}, ['RSSI']]
19:26:18 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0): ['org.bluez.Adapter1', {'Discovering': <dbus_next.signature.Variant ('b', False)>}, []]
19:26:18 DEBUG [client] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE): ['org.bluez.Device1', {'RSSI': <dbus_next.signature.Variant ('n', -78)>}, []]
19:26:18 DEBUG [client] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE): ['org.bluez.Device1', {'Connected': <dbus_next.signature.Variant ('b', True)>}, []]
19:26:19 DEBUG [client] Connection successful (/org/bluez/hci0/dev_20_21_11_28_18_CE)
19:26:19 DEBUG [client] Waiting for ServicesResolved (/org/bluez/hci0/dev_20_21_11_28_18_CE)
19:26:19 DEBUG [client] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE): ['org.bluez.Device1', {'ServicesResolved': <dbus_next.signature.Variant ('b', True)>}, []]
19:26:19 ERROR [sampling] JK-B1A20S15P error: Multiple Characteristics with this UUID, refer to your desired characteristic by the handle attribute instead.
19:26:19 ERROR [main] 1 exceptions occurred fetching BMSs
19:26:19 ERROR [main] Error (num 1, max 200) reading BMS: Multiple Characteristics with this UUID, refer to your desired characteristic by the handle attribute instead.
19:26:19 ERROR [main] Stack: Traceback (most recent call last):
File "/app/main.py", line 45, in fetch_loop
await fn()
File "/app/main.py", line 240, in fn
raise exceptions[0]
File "/app/main.py", line 235, in fn
await t
File "/app/bmslib/sampling.py", line 51, in call
return await self.sample()
File "/app/bmslib/sampling.py", line 70, in sample
async with bms:
File "/app/bmslib/bt.py", line 172, in aenter
await self.connect()
File "/app/bmslib/jikong.py", line 122, in connect
await self.client.start_notify(self.UUID_RX, self._notification_handler)
File "/usr/lib/python3.10/site-packages/bleak/backends/bluezdbus/client.py", line 1041, in start_notify
characteristic = self.services.get_characteristic(char_specifier)
File "/usr/lib/python3.10/site-packages/bleak/backends/service.py", line 185, in get_characteristic
raise BleakError(
bleak.exc.BleakError: Multiple Characteristics with this UUID, refer to your desired characteristic by the handle attribute instead.

i have the same problem, since when i upgrade to 10.0 and 2023.4.5 at 18h

My error was with prrvious version of Home Assistant. After upgrade to 10.0 same error.

i have the same problem, since when i upgrade to 10.0 and 2023.4.5 at 18h
13:05:12 ERROR [sampling] BANK3 error: Device with address A4:C1:38:E6:3F:18 was not found. 13:05:12 INFO [sampling] connecting bms JbdBt(A4:C1:38:A2:EA:D8) 13:05:13 INFO [sampling] connected bms JbdBt(A4:C1:38:A2:EA:D8)! 13:05:13 INFO [sampling] BANK2: BmsSample(U=53.8V,I=6.22A,P=335W,q=268.0Ah/280.0,mos=nan°C) 13:05:14 INFO [sampling] BANK2 volt=3365,3363,3363,3363,3365,3362,3361,3367,3366,3364,3361,3364,3365,3364,3366,3364 temp=[19.2] 13:05:15 INFO [sampling] JbdBt(A4:C1:38:A2:EA:D8) times: connect=1.65s fetch=0.27s 13:05:15 INFO [sampling] connecting bms JbdBt(A4:C1:38:2A:95:DB) 13:05:36 ERROR [sampling] BANK1 error: Device with address A4:C1:38:2A:95:DB was not found. 13:05:36 ERROR [main] 2 exceptions occurred fetching BMSs 13:05:36 ERROR [main] Error (num 3, max 200) reading BMS: Device with address A4:C1:38:E6:3F:18 was not found. 13:05:36 ERROR [main] Stack: Traceback (most recent call last): File "/app/main.py", line 45, in fetch_loop await fn() File "/app/main.py", line 239, in fn raise exceptions[0] File "/app/main.py", line 234, in fn await t File "/app/bmslib/sampling.py", line 51, in call return await self.sample() File "/app/bmslib/sampling.py", line 70, in sample async with bms: File "/app/bmslib/bt.py", line 172, in aenter await self.connect() File "/app/bmslib/jbd.py", line 51, in connect await super().connect(**kwargs) File "/app/bmslib/bt.py", line 77, in connect await self._connect_client(timeout=timeout) File "/app/bmslib/bt.py", line 48, in _connect_client await self.client.connect(timeout=timeout) File "/usr/lib/python3.10/site-packages/bleak/backends/bluezdbus/client.py", line 198, in connect raise BleakError( bleak.exc.BleakError: Device with address A4:C1:38:E6:3F:18 was not found. 13:05:51 INFO [sampling] connecting bms JbdBt(A4:C1:38:A2:EA:D8) 13:05:52 INFO [sampling] connected bms JbdBt(A4:C1:38:A2:EA:D8)! 13:05:52 INFO [sampling] BANK2: BmsSample(U=53.8V,I=7.65A,P=412W,q=268.1Ah/280.0,mos=nan°C) 13:05:52 INFO [sampling] BANK2 volt=3367,3364,3365,3365,3367,3362,3363,3369,3367,3367,3363,3364,3367,3366,3367,3365 temp=[19.3] 13:05:54 INFO [sampling] JbdBt(A4:C1:38:A2:EA:D8) times: connect=1.02s fetch=0.21s 13:05:54 INFO [sampling] connecting bms JbdBt(A4:C1:38:2A:95:DB) 13:06:15 ERROR [sampling] BANK1 error: Device with address A4:C1:38:2A:95:DB was not found. 13:06:15 INFO [sampling] connecting bms JbdBt(A4:C1:38:E6:3F:18) 13:06:35 ERROR [sampling] BANK3 error: Device with address A4:C1:38:E6:3F:18 was not found. 13:06:35 ERROR [main] 2 exceptions occurred fetching BMSs 13:06:35 ERROR [main] Error (num 4, max 200) reading BMS: Device with address A4:C1:38:2A:95:DB was not found. 13:06:35 ERROR [main] Stack: Traceback (most recent call last): File "/app/main.py", line 45, in fetch_loop await fn() File "/app/main.py", line 239, in fn raise exceptions[0] File "/app/main.py", line 234, in fn await t File "/app/bmslib/sampling.py", line 51, in call return await self.sample() File "/app/bmslib/sampling.py", line 70, in sample async with bms: File "/app/bmslib/bt.py", line 172, in aenter await self.connect() File "/app/bmslib/jbd.py", line 51, in connect await super().connect(**kwargs) File "/app/bmslib/bt.py", line 77, in connect await self._connect_client(timeout=timeout) File "/app/bmslib/bt.py", line 48, in _connect_client await self.client.connect(timeout=timeout) File "/usr/lib/python3.10/site-packages/bleak/backends/bluezdbus/client.py", line 198, in connect raise BleakError( bleak.exc.BleakError: Device with address A4:C1:38:2A:95:DB was not found. 13:06:50 INFO [sampling] connecting bms JbdBt(A4:C1:38:2A:95:DB) 13:07:10 ERROR [sampling] BANK1 error: Device with address A4:C1:38:2A:95:DB was not found. 13:07:10 INFO [sampling] connecting bms JbdBt(A4:C1:38:A2:EA:D8) 13:07:11 INFO [sampling] connected bms JbdBt(A4:C1:38:A2:EA:D8)! 13:07:20 ERROR [sampling] BANK2 error: <class 'asyncio.exceptions.TimeoutError'> 13:07:20 INFO [sampling] bytearray(b'\xdd\x04\x00 \r'\r$\r%\r%\r'\r"\r#\r)\r'\r'\r#\r$\r'\r&\r'\r%\xfc\xb8w') bms debug data: BANK2 13:07:21 INFO [sampling] connecting bms JbdBt(A4:C1:38:E6:3F:18) 13:07:41 ERROR [sampling] BANK3 error: Device with address A4:C1:38:E6:3F:18 was not found. 13:07:41 ERROR [main] 3 exceptions occurred fetching BMSs 13:07:41 ERROR [main] Error (num 5, max 200) reading BMS: Device with address A4:C1:38:2A:95:DB was not found. 13:07:41 ERROR [main] Stack: Traceback (most recent call last): File "/app/main.py", line 45, in fetch_loop await fn() File "/app/main.py", line 239, in fn raise exceptions[0] File "/app/main.py", line 234, in fn await t File "/app/bmslib/sampling.py", line 51, in call return await self.sample() File "/app/bmslib/sampling.py", line 70, in sample async with bms: File "/app/bmslib/bt.py", line 172, in aenter await self.connect() File "/app/bmslib/jbd.py", line 51, in connect await super().connect(**kwargs) File "/app/bmslib/bt.py", line 77, in connect await self._connect_client(timeout=timeout) File "/app/bmslib/bt.py", line 48, in _connect_client await self.client.connect(timeout=timeout) File "/usr/lib/python3.10/site-packages/bleak/backends/bluezdbus/client.py", line 198, in connect raise BleakError( bleak.exc.BleakError: Device with address A4:C1:38:2A:95:DB was not found.

This appear to be another issue. Also I don't believe this is due to recent updates. Did you try the things listed in the README / Troubleshooting?

@albertomontoro2023  The interesting part from your logs is
raise BleakError(
bleak.exc.BleakError: Multiple Characteristics with this UUID, refer to your desired characteristic by the handle attribute instead.

I'll release an update that tries to refer the Characteristics by handle soon

Hello,
My jkbms wotk with Home assistant and Batmon for 6 month without a problem.
Something strange i got for 3 days, my jkbms bluetooth work for a moment then do not respond anymore and it seems to be connected with those updates i did on HAssistant (i upgraded Batmon, and Home assistant core).
I was planning on going back to 0.0.56.
I can't assure it's from Batmon, i neeed to restart the BMS (can't right now, too early not enough sun).

so i have checked all,  restart all HA, BMS, Router, nothing helps.
i think this is a problem of the bluetooth integration in OS 10.0
i have a smal solution, but it works not all the time.
give the bluetooth more time.

Ok i restarted the BMS, i can confirm that if i let Batmon connect to it .. it will connect once... then the bluetooth device is kind killed, i can't access it anymore till à restart the BMS.
If i stop Batmon service, i can access the BMS normally with my phone, bluetooth stay available.
So, the way the bluetooth device is handled in Batmon/HA, "kill" the device
And i'm at 150 sample_pertiod and 300 publish .. which is not agressive, concurrent_sampling and keep_alive disabled.

@Honusnap you can dowgrade to this version and see if it changes anything: https://github.com/fl4p/batmon-ha/releases/tag/release0.0.46

@Honusnap you can dowgrade to this version and see if it changes anything: https://github.com/fl4p/batmon-ha/releases/tag/release0.0.46

Any guideline to downgrade while keeping settings ? Or do i ned to uninstall and reinstall 0.0.46
Rem : I was not having a problem with 0.0.56.

Not sure if this keeps the settings. You can backup it using the YAML Editor.

Remove the add-on store repository
Download an old release from https://github.com/fl4p/batmon-ha/tags
Extract the zip file into Home Assistant's /addons folder (using FTP, Samba Share, etc.), so that there is a folder /addons/batmon-ha
The add-on will appear in the add-on store under "Local Addons"

You can also try this version, which uses the latest bleak:
https://github.com/fl4p/batmon-ha/releases/tag/v0.0.60-bleak-0.20.2

Just try with the NEW version 0.0.60
Now I have the followind error:
19:53:08 ERROR [bt] 	[Characteristic] 0000ffe1-0000-1000-8000-00805f9b34fb (Handle: 4): Vendor specific (read,notify), Value: Multiple Characteristics with this UUID, refer to your desired characteristic by the handle attribute instead.
[...]
19:53:08 ERROR [sampling] JK-B1A20S15P error: Characteristic with UUID 17 could not be found!
This is the complete LOG:
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
19:53:02 INFO [bt] BT Discovery:
19:53:07 INFO [bt] BT Device   16-12-2E-C9-F6-94   address=16:12:2E:C9:F6:94
19:53:07 INFO [bt] BT Device   59-99-99-60-2D-71   address=59:99:99:60:2D:71
19:53:07 INFO [bt] BT Device   JK-B1A20S15P   address=20:21:11:28:18:CE
19:53:07 INFO [bt] BT Device   Mi Smart Band 6   address=C6:77:22:7A:07:AE
19:53:07 INFO [bt] BT Device   62-97-99-CC-7C-CE   address=62:97:99:CC:7C:CE
19:53:07 INFO [bt] BT Device   77-65-77-12-E6-D4   address=77:65:77:12:E6:D4
19:53:07 INFO [main] Verbose logging enabled
19:53:07 INFO [bt] BMS JKBt(20:21:11:28:18:CE) keep alive enabled
19:53:07 INFO [main] connecting mqtt mqttuser@core-mosquitto
19:53:07 DEBUG [client] Sending CONNECT (u1, p1, wr0, wq0, wf0, c1, k60) client_id=b''
19:53:07 DEBUG [client] Received CONNACK (0, 0)
19:53:07 INFO [main] Fetching 1 BMS + 0 others concurrently, period=20.00s, keep_alive=True
19:53:07 INFO [sampling] connecting bms JKBt(20:21:11:28:18:CE)
19:53:07 DEBUG [client] Connecting to device @ 20:21:11:28:18:CE with hci0
19:53:07 INFO [main] mqtt watchdog loop started with timeout 900.0s
19:53:07 DEBUG [scanner] cached devices: {'/org/bluez/hci0/dev_62_97_99_CC_7C_CE': {'Address': '62:97:99:CC:7C:CE', 'AddressType': 'random', 'Alias': '62-97-99-CC-7C-CE', 'Paired': False, 'Bonded': False, 'Trusted': False, 'Blocked': False, 'LegacyPairing': False, 'Connected': False, 'UUIDs': [], 'Adapter': '/org/bluez/hci0', 'ManufacturerData': {76: b'\x10\x05\x01\x18\nr\xfb'}, 'ServicesResolved': False, 'AdvertisingFlags': b'\x1a'}, '/org/bluez/hci0/dev_C6_77_22_7A_07_AE': {'Address': 'C6:77:22:7A:07:AE', 'AddressType': 'public', 'Name': 'Mi Smart Band 6', 'Alias': 'Mi Smart Band 6', 'Paired': False, 'Bonded': False, 'Trusted': False, 'Blocked': False, 'LegacyPairing': False, 'Connected': False, 'UUIDs': ['0000fee0-0000-1000-8000-00805f9b34fb'], 'Adapter': '/org/bluez/hci0', 'ManufacturerData': {343: b'\x02\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\x03\xc6w"z\x07\xae'}, 'ServicesResolved': False, 'AdvertisingFlags': b'\x06'}, '/org/bluez/hci0/dev_20_21_11_28_18_CE': {'Address': '20:21:11:28:18:CE', 'AddressType': 'public', 'Name': 'JK-B1A20S15P', 'Alias': 'JK-B1A20S15P', 'Paired': False, 'Bonded': False, 'Trusted': True, 'Blocked': False, 'LegacyPairing': False, 'Connected': False, 'UUIDs': ['0000ffe0-0000-1000-8000-00805f9b34fb'], 'Adapter': '/org/bluez/hci0', 'ManufacturerData': {19274: b'\x00\x01'}, 'ServicesResolved': False, 'AdvertisingFlags': b'\x06'}}
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0): ['org.bluez.Adapter1', {'Discovering': <dbus_next.signature.Variant ('b', True)>}, []]
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.ObjectManager.InterfacesAdded (/): ['/org/bluez/hci0/dev_16_12_2E_C9_F6_94', {'org.freedesktop.DBus.Introspectable': {}, 'org.bluez.Device1': {'Address': <dbus_next.signature.Variant ('s', 16:12:2E:C9:F6:94)>, 'AddressType': <dbus_next.signature.Variant ('s', random)>, 'Alias': <dbus_next.signature.Variant ('s', 16-12-2E-C9-F6-94)>, 'Paired': <dbus_next.signature.Variant ('b', False)>, 'Bonded': <dbus_next.signature.Variant ('b', False)>, 'Trusted': <dbus_next.signature.Variant ('b', False)>, 'Blocked': <dbus_next.signature.Variant ('b', False)>, 'LegacyPairing': <dbus_next.signature.Variant ('b', False)>, 'RSSI': <dbus_next.signature.Variant ('n', -74)>, 'Connected': <dbus_next.signature.Variant ('b', False)>, 'UUIDs': <dbus_next.signature.Variant ('as', [])>, 'Adapter': <dbus_next.signature.Variant ('o', /org/bluez/hci0)>, 'ManufacturerData': <dbus_next.signature.Variant ('a{qv}', {6: <dbus_next.signature.Variant ('ay', b'\x01\t \x02.\x18\x1d\xc2\x07=\xb27\x80\xc4\xa4\xe8g\x96\xdb`\xc3\x81~Z[\xe8\xc1')>})>, 'ServicesResolved': <dbus_next.signature.Variant ('b', False)>, 'AdvertisingFlags': <dbus_next.signature.Variant ('ay', b'\x00')>}, 'org.freedesktop.DBus.Properties': {}}]
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.ObjectManager.InterfacesAdded (/): ['/org/bluez/hci0/dev_59_99_99_60_2D_71', {'org.freedesktop.DBus.Introspectable': {}, 'org.bluez.Device1': {'Address': <dbus_next.signature.Variant ('s', 59:99:99:60:2D:71)>, 'AddressType': <dbus_next.signature.Variant ('s', random)>, 'Alias': <dbus_next.signature.Variant ('s', 59-99-99-60-2D-71)>, 'Paired': <dbus_next.signature.Variant ('b', False)>, 'Bonded': <dbus_next.signature.Variant ('b', False)>, 'Trusted': <dbus_next.signature.Variant ('b', False)>, 'Blocked': <dbus_next.signature.Variant ('b', False)>, 'LegacyPairing': <dbus_next.signature.Variant ('b', False)>, 'RSSI': <dbus_next.signature.Variant ('n', -67)>, 'Connected': <dbus_next.signature.Variant ('b', False)>, 'UUIDs': <dbus_next.signature.Variant ('as', ['0000fe9f-0000-1000-8000-00805f9b34fb'])>, 'Adapter': <dbus_next.signature.Variant ('o', /org/bluez/hci0)>, 'ManufacturerData': <dbus_next.signature.Variant ('a{qv}', {224: <dbus_next.signature.Variant ('ay', b'\x01\x9c\xcaP\xf0\x06')>})>, 'ServiceData': <dbus_next.signature.Variant ('a{sv}', {'0000fe9f-0000-1000-8000-00805f9b34fb': <dbus_next.signature.Variant ('ay', b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00')>})>, 'ServicesResolved': <dbus_next.signature.Variant ('b', False)>, 'AdvertisingFlags': <dbus_next.signature.Variant ('ay', b'\x00')>}, 'org.freedesktop.DBus.Properties': {}}]
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE): ['org.bluez.Device1', {'RSSI': <dbus_next.signature.Variant ('n', -80)>}, []]
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_C6_77_22_7A_07_AE): ['org.bluez.Device1', {'RSSI': <dbus_next.signature.Variant ('n', -81)>}, []]
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_16_12_2E_C9_F6_94): ['org.bluez.Device1', {}, ['RSSI']]
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.ObjectManager.InterfacesRemoved (/): ['/org/bluez/hci0/dev_16_12_2E_C9_F6_94', ['org.freedesktop.DBus.Properties', 'org.freedesktop.DBus.Introspectable', 'org.bluez.Device1']]
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_59_99_99_60_2D_71): ['org.bluez.Device1', {}, ['RSSI']]
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.ObjectManager.InterfacesRemoved (/): ['/org/bluez/hci0/dev_59_99_99_60_2D_71', ['org.freedesktop.DBus.Properties', 'org.freedesktop.DBus.Introspectable', 'org.bluez.Device1']]
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_C6_77_22_7A_07_AE): ['org.bluez.Device1', {}, ['RSSI']]
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE): ['org.bluez.Device1', {}, ['RSSI']]
19:53:07 DEBUG [scanner] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0): ['org.bluez.Adapter1', {'Discovering': <dbus_next.signature.Variant ('b', False)>}, []]
19:53:07 DEBUG [client] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE): ['org.bluez.Device1', {'RSSI': <dbus_next.signature.Variant ('n', -84)>}, []]
19:53:07 DEBUG [client] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE): ['org.bluez.Device1', {'Connected': <dbus_next.signature.Variant ('b', True)>}, []]
19:53:07 DEBUG [client] Connection successful (/org/bluez/hci0/dev_20_21_11_28_18_CE)
19:53:07 DEBUG [client] Waiting for ServicesResolved (/org/bluez/hci0/dev_20_21_11_28_18_CE)
19:53:08 DEBUG [client] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE): ['org.bluez.Device1', {'ServicesResolved': <dbus_next.signature.Variant ('b', True)>}, []]
19:53:08 INFO [bt] [Service] 0000ffe0-0000-1000-8000-00805f9b34fb (Handle: 1): Vendor specific
19:53:08 ERROR [bt] 	[Characteristic] 0000ffe1-0000-1000-8000-00805f9b34fb (Handle: 4): Vendor specific (read,notify), Value: Multiple Characteristics with this UUID, refer to your desired characteristic by the `handle` attribute instead.
19:53:08 DEBUG [client] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE/service0001/char0004/desc0006): ['org.bluez.GattDescriptor1', {'Value': <dbus_next.signature.Variant ('ay', b'\x00\x00')>}, []]
19:53:08 DEBUG [client] Read Descriptor 6 | /org/bluez/hci0/dev_20_21_11_28_18_CE/service0001/char0004/desc0006: bytearray(b'\x00\x00')
19:53:08 INFO [bt] 		[Descriptor] 00002902-0000-1000-8000-00805f9b34fb (Handle: 6): Client Characteristic Configuration) | Value: b'\x00\x00'
19:53:08 INFO [bt] 	[Characteristic] 0000ffe1-0000-1000-8000-00805f9b34fb (Handle: 2): Vendor specific (write-without-response,write), Value: None
19:53:08 INFO [bt] [Service] 0000ffe0-0000-1000-8000-00805f9b34fb (Handle: 1): Vendor specific
19:53:08 ERROR [bt] 	[Characteristic] 0000ffe1-0000-1000-8000-00805f9b34fb (Handle: 4): Vendor specific (read,notify), Value: Multiple Characteristics with this UUID, refer to your desired characteristic by the `handle` attribute instead.
19:53:08 DEBUG [client] received D-Bus signal: org.freedesktop.DBus.Properties.PropertiesChanged (/org/bluez/hci0/dev_20_21_11_28_18_CE/service0001/char0004/desc0006): ['org.bluez.GattDescriptor1', {'Value': <dbus_next.signature.Variant ('ay', b'\x00\x00')>}, []]
19:53:08 DEBUG [client] Read Descriptor 6 | /org/bluez/hci0/dev_20_21_11_28_18_CE/service0001/char0004/desc0006: bytearray(b'\x00\x00')
19:53:08 INFO [bt] 		[Descriptor] 00002902-0000-1000-8000-00805f9b34fb (Handle: 6): Client Characteristic Configuration) | Value: b'\x00\x00'
19:53:08 INFO [bt] 	[Characteristic] 0000ffe1-0000-1000-8000-00805f9b34fb (Handle: 2): Vendor specific (write-without-response,write), Value: None
19:53:08 ERROR [sampling] JK-B1A20S15P error: Characteristic with UUID 17 could not be found!
19:53:16 ERROR [sampling] JK-B1A20S15P error: <class 'asyncio.exceptions.TimeoutError'>
19:53:16 ERROR [main] Error (num 1, max 200) reading BMS:
19:53:16 ERROR [main] Stack: Traceback (most recent call last):
File "/usr/lib/python3.10/asyncio/tasks.py", line 456, in wait_for
return fut.result()
asyncio.exceptions.CancelledError
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/app/main.py", line 36, in fetch_loop
await fn()
File "/app/bmslib/sampling.py", line 67, in call
return await self.sample()
File "/app/bmslib/sampling.py", line 92, in sample
sample = await bms.fetch()
File "/app/bmslib/jikong.py", line 215, in fetch
await self._fetch_futures.wait_for(0x02, self.TIMEOUT)
File "/app/bmslib/init.py", line 48, in wait_for
return await asyncio.wait_for(self._futures.get(name), timeout)
File "/usr/lib/python3.10/asyncio/tasks.py", line 458, in wait_for
raise exceptions.TimeoutError() from exc
asyncio.exceptions.TimeoutError
19:53:44 ERROR [sampling] JK-B1A20S15P error: <class 'asyncio.exceptions.TimeoutError'>
19:53:44 ERROR [main] Error (num 2, max 200) reading BMS:
19:53:44 ERROR [main] Stack: Traceback (most recent call last):
File "/usr/lib/python3.10/asyncio/tasks.py", line 456, in wait_for
return fut.result()
asyncio.exceptions.CancelledError
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/app/main.py", line 36, in fetch_loop
await fn()
File "/app/bmslib/sampling.py", line 67, in call
return await self.sample()
File "/app/bmslib/sampling.py", line 92, in sample
sample = await bms.fetch()
File "/app/bmslib/jikong.py", line 215, in fetch
await self._fetch_futures.wait_for(0x02, self.TIMEOUT)
File "/app/bmslib/init.py", line 48, in wait_for
return await asyncio.wait_for(self._futures.get(name), timeout)
File "/usr/lib/python3.10/asyncio/tasks.py", line 458, in wait_for
raise exceptions.TimeoutError() from exc
asyncio.exceptions.TimeoutError
I hope this can help for next version.
Thanks for all your work

Hello Guys,
Yesterday i upgraded  Home Assistant, and Batmon, the problem is solved for me, it works again... so i can't tell if it was a ptoblem on Home assistant side or Batmon... JkBMS is polled again every 150s by Batmon and it do not "lock up" it's Bluetooth anymore.
Thanks for this amazing plugin, thanks to it i can follow my everyday in and out power of my battery.

Same as you Honusnap !!!!!
With HA 10 and the last Batmon version 0.0.61 all is working fine
Super happy.
Thanks for all.
@fl4p I will pay you a pair of beers with paypal.
Your work is excellent
Thaks for all.

this was the initial problem:
https://github.com/home-assistant/operating-system/issues/2485
Upgrade to HA10.1 !


Feature/port update qt advanced docking system 3 8 0

Describe the pull request

What does your PR fix?
Update port to qt advanced docking system 3 8 0

Which triplets are supported/not supported? Have you updated the CI baseline?
x64-windows, No

Does your PR follow the maintainer guide?

Yes (without --all)

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/
This MR follow a previous update of port file de 3.7.2 #21801

Thanks for your contributor.
Please sign CLA first.

CLA signed

Depends on #21801.

#21801 was merged. You can continue this PR now.


perf: remove BaseLinter implementation

Description
This PR is a follow-up to https://github.com/appsmithorg/appsmith/issues/23865. It removes the main thread linter implementation which isn’t used today but does affect the bundle size, increasing it by ~1 MB of minified code:

Context: https://3perf.slack.com/archives/C01SGCF8PM0/p1689156352117669 (to open in Appsmith workspace, replace 3perf.slack.com with the Appsmith Slack domain)
Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

[ ] Manual
[ ] Jest
[x] Cypress

Test Plan
Issues raised during DP testing
Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/ok-to-test


[BUG] Bitcoin sending doesn't work

Several bugs:

When still in status confirmation, then there is a strange error message when calculating the fee (see first picture)
Max auto-input button/click of amount is not working
Sending is not working - ending with an error message (see second picture)

@AntonioVentilii any feedback regarding this - I think a small fix in the frontend is need for serialization

Thank you!

Hi @DeLemonCH . We filed the remaining 2 issues, and will add them into one of our next sprints.
Thanks again for filing these items!

Hi guys, I can't still not get mt Bitcoins out - now because another issue with the funds ...
Thanks for checking!

StefanBerger-DFINITY Merci!

@DeLemonCH will address that asap. @DenysKarmazynDFINITY  that should be in your todo list in the next few minutes

The diff is 0.00002066, which is about the transaction fees of ~2 USD.
So this is still the MAX problem I assume.
(You could try to send 0.001097544914 instead of the 0.00111783, that should then end up to 0 with the fees..)

@DeLemonCH sorry to bother again.
The root problem here is of course that the fees must be paid in btc, and they are deducted from the wallet account and not the transfer amount (paid by sender). We currently don't have the fee information at this step, so we can't offer a MAX button there.
But we are working on an improved flow that will show the expected fees, and then we will also provide a MAX button.

Hi Stefan, yes I could send it with considering the fee in the full amount - though would have expected it to be taken from the transfer amount.
Thanks anyway!


[SR-7599] Inconsistent diagnostics when defining count

Previous ID
SR-7599

Radar
None

Original Reporter
@milseman

Type
Bug

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug

Assignee
@xedin

Priority
Medium

md5: 61d5a9fc441e117c3b0132ad689198c7

Issue Description:
When String defines `count`, diagnostic changes from "cannot call value of non-function type 'Int'" to "cannot invoke 'count' with no arguments": https://github.com/apple/swift/pull/16358#issuecomment-386458161
The original is better and offers a fixit.

Fixed in #27976


like/dislike songs

Hi,
It would be cool to have a way to like/dislike songs. Maybe as handler of 'add to liked playlist' event, or just by some special 'mopidy ytmusic like/dislike' command.

I thought about this but decided against it. I mean a command would make sense if you're sitting at the terminal but that's it.
Mopidy doesn't really provide a sensible way to implement this. If we went the special playlist way, just think how many steps it would take to like a song with most clients.
This wouldn't be difficult to implement I think but the usabillity would be sub-par.

I agree that it's not easily implemented right now. At the same time 'special' playlist or some sort of custom like command opens at least some way to do this. With some scripting it at least solves this somehow.
For example for me it's one of key feature of such 'alternative' client because it improves quality of suggestions.
I think this one is related:
https://github.com/mopidy/mopidy/issues/327


Setup JupyterHub

[ ] Yell at AWS
[ ] Actually open the server
[ ] Add users (me and u)

Jupyterhub is not effective in real-time collaboration


[Bug]: Duplicate notification on doorbell ring

What happened?
When pressing the doorbell once, I get two HomeKit notifications.
I have tried reconfiguring several times but the end result is always the same. Two notifications.
When setting up, I can see two doorbell items, one being a child of the other. Might be related to this.

   Working on this.

Awesome @lenoxys Hope u can fix the problem, I have exactly the same issue.

@lenoxys Did u have any succes so far? The issue is still the same in the last version.

@lenoxys What is the status of this issue? At the moment, in v1.0.6 I still get 2 notifications when someone rings the doorbell. It's nice that it works, but annoying that you get 2 notifications everywhere.

Same issue here, can't find out how to avoid the double notification.
Did notice you see two devices with the same identifier when you setup the plugin. Deselecting one of them does not fix it since the filter is filtering out 'both devices', result is no device at all. Must say I'm not even sure that's the way it's supposed to work ;)

plan for 1.1.0

Still not fixed, unfortunately. I hope this is fixed soon because it is annoying 🥲 first world problem of course

Still not fixed, unfortunately. I hope this is fixed soon because it is annoying 🥲 first world problem of course

it's fixed on beta. I've a doorbell and had the issue on latest but fixed on beta.

Still not fixed, unfortunately. I hope this is fixed soon because it is annoying 🥲 first world problem of course

it's fixed on beta. I've a doorbell and had the issue on latest but fixed on beta.

How can I use the beta? Or is it due soon?

With one of the earlier betas I had the problem that Ffmpeg kept crashing homebridge. Is this still the case?

I can stream from the doorbell. But make sure to set enabledetailedlogging to at least 1.


Performed spell check across the rest of code base, and enahnced the yaml paraser code a little

Been a while hope you are alright @joaomdmoura!!

Hey @rumble773, yeah sorry, things got a little busy with crew but all good problems!
I see there are some minor conflicts, would you mind squashing those? 🙏🏼

@joaomdmoura I seee, yallaa hope for all the best inshaAllah.

I see there are some minor conflicts, would you mind squashing those? 🙏🏼
I think I have squashed them, not sure why it still show in:

 src/crewai/agent.py
tests/crew_test.py

Should be done now!
Btw I gave a workshop about crewAI last week, great effort you guys are doing!!

How was the workshop, did people like it?

It was great thanks for asking, people admire the solution!!!
For me I really enjoyed giving a talk about crewAI and he multi agents systems.


Migrating mil2525d repo to public repo

minor readme updates to include references to new mil2525d data

One editorial note: we wouldn't normally make this many changes (100+ files) at once, but these files existed previously in another repo and have already been reviewed/tested.


dependency on google-compute-engine

I've noticed an issue when installing dsub on my laptop.  When I ran the example mentioned in the README:
dsub \
   --provider local \
   --logging /tmp/dsub-test/logging/ \
   --output OUT=/tmp/dsub-test/output/out.txt \
   --command 'echo "Hello World" > "${OUT}"' \
   --wait

I got an error like so:
Waiting for: echo--me--181205-185159-848773.
  echo--idas--181205-185159-848773: FAILURE
['2018-12-05 18:52:04 I: Copying the logs before cleanup']
JobExecutionError: One or more jobs finished with status FAILURE or CANCELED during wait.
echo--idas--181205-185159-848773

When I inspected the relevant log file, I noticed the following:
$ cat /tmp/dsub-local/echo--me--181205-185159-848773/task/runner-log.txt
2018-12-05 18:51:59 I: Localizing inputs.
2018-12-05 18:51:59 I: Checking image userid.
2018-12-05 18:52:01 I: Running Docker image.
322bc9fc4bcc7fd531f3cfecdf1ce919217b383bcf3ca0c6d4f4647fa1561da9
2018-12-05 18:52:02 I: Docker exit code 0.
2018-12-05 18:52:02 I: Ensure host user (1000:1001) owns Docker-written data
2018-12-05 18:52:03 I: Copying outputs.
Traceback (most recent call last):
  File "/usr/lib/google-cloud-sdk/platform/gsutil/gsutil", line 22, in <module>
    gsutil.RunMain()
  File "/usr/lib/google-cloud-sdk/platform/gsutil/gsutil.py", line 116, in RunMain
    import gslib.__main__
  File "/usr/lib/google-cloud-sdk/platform/gsutil/gslib/__main__.py", line 39, in <module>
    import boto
  File "/usr/lib/google-cloud-sdk/platform/gsutil/third_party/boto/boto/__init__.py", line 1216, in <module>
    boto.plugin.load_plugins(config)
  File "/usr/lib/google-cloud-sdk/platform/gsutil/third_party/boto/boto/plugin.py", line 93, in load_plugins
    _import_module(file)
  File "/usr/lib/google-cloud-sdk/platform/gsutil/third_party/boto/boto/plugin.py", line 75, in _import_module
    return imp.load_module(name, file, filename, data)
  File "/usr/lib/python2.7/dist-packages/google_compute_engine/boto/compute_auth.py", line 19, in <module>
    from google_compute_engine import logger
ImportError: No module named google_compute_engine
2018-12-05 18:52:04 E: Error on or near line 45; /tmp/dsub-local/echo--me--181205-185159-848773/task/runner.sh exiting with status 1
2018-12-05 18:52:04 I: Copying the logs before cleanup

Upon running pip install google-compute-engine into my virtualenv, the issue went away.  Should installing the python library google-compute-engine be mentioned in the documentation, or added into the setup.py?

Hi @indraniel!
The issue isn't a direct dependency of dsub on this particular library, so I would not change setup.py. The local provider here is calling gsutil to do some file copies and for some reason your gsutil install has some issues.
There are a number of issues that have been seen with this problem with the gsutil install:
https://github.com/travis-ci/travis-ci/issues/7940
https://github.com/travis-ci/travis-ci/issues/8182
I think the root of this is addressed here:
https://github.com/GoogleCloudPlatform/gsutil/issues/459

Boto automatically looks in certain locations (/etc/boto.cfg being one of them) and picks up those config files if present
That config file tells Boto it should load the google_compute_engine package from somewhere outside the virtual environmen

do you have an /etc/boto.cfg?
Thanks!

Yes, I do have an /etc/boto.cfg file.  I was installing dsub in a virtualenv on a Google Compute Instance VM.  That makes more sense now.  Thanks again for the explanation @mbookman !

I'll go ahead and close this issue for now.


PM2 Script fail "pm2 start process.json"

Describe the bug
pm2 fails to find app.js script
Steps to reproduce the behavior:
1. Go to ''cd ~/pagermon/server/"
2. type 'pm2 start process.json'
Expected behavior
pm2 to daemonize , cron to acknowledge and the script for server to run from app.js
Environment information:
Rpi3b+ , Pagermon Pi  Image , RTL-SDR plugged in while going through steps.

Other details

_- : Updated image , and tried image without updating. OOB _
Additional context
Not seen this before guys. i thought this would have worked out of the box but i cannot get it to work . What about ditching PM2 and maybe systemd service to handle pagermon?
Actual Behaviour/Error:
login as: pagermon
<EMAIL_ADDRESS>password:
Linux raspberrypi 5.15.76-v7+ #1597 SMP Fri Nov 4 12:13:17 GMT 2022 armv7l
The programs included with the Debian GNU/Linux system are free software;
the exact distribution terms for each program are described in the
individual files in /usr/share/doc/*/copyright.
Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
permitted by applicable law.
Last login: Thu Nov 21 17:08:49 2024
pagermon@raspberrypi:~ $ cd ~/pagermon/server/
pagermon@raspberrypi:~/pagermon/server $ pm2 start process.json
[PM2] Spawning PM2 daemon with pm2_home=/home/pagermon/.pm2
[PM2] PM2 Successfully daemonized
[PM2] cron restart at 1 0 * * *
[PM2][WARN] Applications pagermon not running, starting...
[PM2][ERROR] Error: Script not found: /home/pi/pagermon/server/app.js
pagermon@raspberrypi:~/pagermon/server $ cd /home/pi/pagermon/server/
-bash: cd: /home/pi/pagermon/server/: No such file or directory
pagermon@raspberrypi:~/pagermon/server $ ls
app.js      Dockerfile.armhf  logs          package-lock.json     root
auth        hooks             messages.db   pids                  routes
config      knex              middleware    plugins               sessions
db.js       knexfile.js       node_modules  process-default.json  test
Dockerfile  log.js            package.json  process.json          themes
pagermon@raspberrypi:~/pagermon/server $ pagermon@raspberrypi:~ $ cd ~/pagermon/server/
pagermon@raspberrypi:~/pagermon/server $ pm2 start process.json
[PM2] Spawning PM2 daemon with pm2_home=/home/pagermon/.pm2
[PM2] PM2 Successfully daemonized
[PM2] cron restart at 1 0 * * *
[PM2][WARN] Applications pagermon not running, starting...
[PM2][ERROR] Error: Script not found: /home/pi/pagermon/server/app.js
pagermon@raspberrypi:~/pagermon/server $ cd /home/pi/pagermon/server/
-bash: cd: /home/pi/pagermon/server/: No such file or directory
pagermon@raspberrypi:~/pagermon/server $ ls
app.js      Dockerfile.armhf  logs          package-lock.json     root
auth        hooks             messages.db   pids                  routes
config      knex              middleware    plugins               sessions
db.js       knexfile.js       node_modules  process-default.json  test
Dockerfile  log.js            package.json  process.json          themes
pagermon@raspberrypi:~/pagermon/server $
cd ~/pagermon/server/
cd ~/pagermon/server/
pagermon@raspberrypi:~/pagermon/server $ pm2 start process.json
[PM2] Spawning PM2 daemon with pm2_home=/home/pagermon/.pm2
[PM2] PM2 Successfully daemonized
[PM2] cron restart at 1 0 * * *
[PM2][WARN] Applications pagermon not running, starting...
pagermon@raspberrypi:~/pagermon/server $on  process.json          themesns
Any help appreciated
Thanks

You did not change the values in process.json, especially the path to app.js.


new node icon WIP

Add

Node role type icon on the node list

WIP - it need to change the node icon on the map

Minor nitpick, the case of the tooltips is not consistent. I would change them to:
peer --> Peer
api --> API
VOTING --> Voting


[Misc] Add image repeat option to benchmark_serving.py (to test hit/miss of MM cache)

benchmark_serving.py: This PR adds the option to repeat images with specific probability so we can test HIT/MISS of MM cache.

/ready


fleetctl convert doesn't work with multiline queries

What version of fleet are you using (fleet version --full)?
$ ./build/fleet version --full
fleet - version 2.0.0-rc1-10-gd9038f3-dirty
branch: 	master
revision: 	d9038f37f47397c403b2d55f723857270f9d4ba3
build date: 	2018-06-12T15:39:55Z
build user: 	brandonklise
go version: 	go1.10.2
What operating system are you using?
osx 10.13.4
What did you do?
I ran $ ./build/fleetctl convert -f /private/var/osquery/packs/osx-attacks.conf to convert the osquery json pack to yaml.
What did you expect to see?
The typical output of the fleetctl convert command, such as
---
apiVersion: v1
kind: pack
spec:
  name: osx
  queries:
  - description: (http://www.intego.com/mac-security-blog/new-mac-trojan-discovered-related-to-syria/)
    interval: 3600
    name: Leverage-A_1
    query: Leverage-A_1
    version: 1.4.5
  targets:
    labels: null
---
apiVersion: v1
kind: query
spec:
  description: (http://www.intego.com/mac-security-blog/new-mac-trojan-discovered-related-to-syria/)
  name: Leverage-A_1
  query: select * from launchd where path like '%UserEvent.System.plist';

What did you see instead?
invalid character '\n' in string escape code
This is due to the osquery pack having multiline queries:
"queries": {
    "WireLurker": {
      "query" : "select * from launchd where \
        name = 'com.apple.machook_damon.plist' OR \
        name = 'com.apple.globalupdate.plist' OR \
        name = 'com.apple.appstore.plughelper.plist' OR \
        name = 'com.apple.MailServiceAgentHelper.plist' OR \
        name = 'com.apple.systemkeychain-helper.plist' OR \
        name = 'com.apple.periodic-dd-mm-yy.plist';",
      "interval" : "3600",
      "version": "1.4.5",
      "description" : "(https://github.com/PaloAltoNetworks-BD/WireLurkerDetector)",
      "value" : "Artifact used by this malware"
    },

For a workaround, I removed the newlines with
$ cat /private/var/osquery/packs/osx-attacks.conf | gsed ':a;N;$!ba;s/\\\n/ /g' > packs/osx-attacks.yml

and then ran
$ ./build/fleetctl convert -f packs/osx-attacks.yml

which resulted in the expected output.

This is due to osquery configs not using valid JSON (newlines are not allowed in JSON). Maybe the convert command should strip newlines?

I came across this when I converted this pack for the starter kit. IMO the fact that the pack is not valid JSON is the real problem here.


Update-from-dnb admin tool

Description of change
This PR adds a tool to Django admin to allow administrators to pull fresh data from DNB for a company with a duns_number.
This allows administrators to resolve the unhappy-path for the new add-a-company journey by adding a duns_number to a company record followed by pulling data from DNB for the given company.
In order to test this locally:

Paste the following code at the end of datahub/dnb_api/utils.py:

from unittest.mock import Mock
dnb_response = Mock()
dnb_response.status_code = 200
dnb_response.json = lambda: {
    'results': [
        {
            'address_country': '',
            'address_county': '',
            'address_line_1': 'Unit 10, Ockham Drive',
            'address_line_2': '',
            'address_postcode': 'UB6 0F2',
            'address_town': 'GREENFORD',
            'annual_sales': 50651895.0,
            'annual_sales_currency': 'USD',
            'domain': 'foo.com',
            'duns_number': '291332174',
            'primary_name': 'FOO BICYCLE LIMITED',
            'registration_numbers': [
                {
                    'registration_number': '01261539',
                    'registration_type': 'uk_companies_house_number',
                },
            ],
            'trading_names': [],
        },
    ],
}
search_dnb = lambda _: dnb_response

Run the local server
Navigate to the change view for a company, paste 291332174  as the duns_number and hit save.
Hit "Update from DNB" button.

P.S. The tests are specifically testing the admin functionality added as part of the PR. The underlying functions etc. have good test coverage and so I chose to not add more test for these.
Here is a screenshot of how it looks like:

Checklist

[x] Has a new newsfragment been created? Check changelog/README.md for instructions
[ ] Do any added or updated endpoints appear in the API documentation? See docs/Maintaining the API documentation.md for more details
[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

Would be good to add some screenshots to the PR description.

I have refactored update_from_dnb and its much smaller now.


CCL config - different versions

Avoid duplicates

[X] Question is not already answered in the FAQ
[X] Question is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[X] Question has not already been asked in another issue

Your Question
On different Android devices I can see

CCL 1.1.0 (release date Mar 14, 2022)
CCL 1.2.1 (release date Mar 23, 2022)

being shown through CWA "App Information". The devices have been updated to CWA Android 2.19.2.

What triggers a CCL config update on CWA Android?
Is it expected that different devices will be using different CCL versions?

https://github.com/corona-warn-app/cwa-app-ccl#readme says "The logic in CCL is described in JSON format. An engine processes the logic on the client against a defined input structure (e.g. the set of DCCs) and can expect a defined output structure. The client can update the JSON regularly from a server. This facilitates updates to CCL independent of client releases, e.g. in order to respond to legal or regulatory pandemic-related changes on short notice."

FYI: https://github.com/corona-warn-app/cwa-app-ccl/issues/49#issuecomment-1077683566 from @mlenkeit says:
"It might take up to 24 hours until all devices have updated to the new version of CCL."

@MikeMcC399 Android usually updates CCL once a day, randomly distributed to avoid load peaks. After 24 hrs, all devices should be on 1.2.1 (provided they have a network connection).

@mlenkeit
Thank you very much for the explanation. Indeed, by this morning the two devices which were still on 1.1.0 are now on 1.2.1.
I will close this now that the question has been answered. I wonder though if there shouldn't be some documentation somewhere which describes this.


install-plugins.sh does not install the latest version of plugin

Hello,
I fear that the commit of @carlossg ( ref 119703c "Always install latest version of dependencies, not minimum") does not solve correctly the issue #327.
The proposed modification by @netrounds-fredrik worked for me but the referenced one doesn't as can be seen from the attached log.
As in the description of #327, the mailer 1.4 is downloaded while I would expect the 1.17 to be downloaded for exemple.
Status: Downloaded newer image for jenkins:latest
 ---> 753c2e1bdef7
Step 2 : RUN /usr/local/bin/install-plugins.sh github-oauth workflow-aggregator
 ---> Running in f1a23f2cf5eb
Creating initial locks...

Analyzing war...

Downloading plugins...
Downloading plugin: github-oauth from https://updates.jenkins.io/download/plugins/github-oauth/latest/github-oauth.hpi
Downloading plugin: workflow-aggregator from https://updates.jenkins.io/download/plugins/workflow-aggregator/latest/workflow-aggregator.hpi
 > github-oauth depends on mailer:1.4,git:2.0.3,github-api:1.69
Downloading plugin: mailer from https://updates.jenkins.io/download/plugins/mailer/1.4/mailer.hpi
Downloading plugin: git from https://updates.jenkins.io/download/plugins/git/2.0.3/git.hpi
Downloading plugin: github-api from https://updates.jenkins.io/download/plugins/github-api/1.69/github-api.hpi
 > workflow-aggregator depends on workflow-support:2.1,workflow-cps:2.6,pipeline-stage-step:2.1,pipeline-stage-view:1.4,workflow-cps-global-lib:2.0,pipeline-input-step:2.0,workflow-basic-steps:2.0,workflow-multibranch:2.8,workflow-scm-step:2.1,workflow-job:2.3,workflow-durable-task-step:2.2,workflow-step-api:2.1,pipeline-build-step:2.1,workflow-api:2.1
Downloading plugin: workflow-support from https://updates.jenkins.io/download/plugins/workflow-support/2.1/workflow-support.hpi
Downloading plugin: workflow-cps from https://updates.jenkins.io/download/plugins/workflow-cps/2.6/workflow-cps.hpi
Downloading plugin: pipeline-stage-step from https://updates.jenkins.io/download/plugins/pipeline-stage-step/2.1/pipeline-stage-step.hpi
Downloading plugin: pipeline-stage-view from https://updates.jenkins.io/download/plugins/pipeline-stage-view/1.4/pipeline-stage-view.hpi
Downloading plugin: workflow-cps-global-lib from https://updates.jenkins.io/download/plugins/workflow-cps-global-lib/2.0/workflow-cps-global-lib.hpi
Downloading plugin: pipeline-input-step from https://updates.jenkins.io/download/plugins/pipeline-input-step/2.0/pipeline-input-step.hpi
Downloading plugin: workflow-basic-steps from https://updates.jenkins.io/download/plugins/workflow-basic-steps/2.0/workflow-basic-steps.hpi
Downloading plugin: workflow-multibranch from https://updates.jenkins.io/download/plugins/workflow-multibranch/2.8/workflow-multibranch.hpi
Downloading plugin: workflow-scm-step from https://updates.jenkins.io/download/plugins/workflow-scm-step/2.1/workflow-scm-step.hpi
Downloading plugin: workflow-job from https://updates.jenkins.io/download/plugins/workflow-job/2.3/workflow-job.hpi
Downloading plugin: workflow-durable-task-step from https://updates.jenkins.io/download/plugins/workflow-durable-task-step/2.2/workflow-durable-task-step.hpi
Downloading plugin: workflow-step-api from https://updates.jenkins.io/download/plugins/workflow-step-api/2.1/workflow-step-api.hpi
Downloading plugin: pipeline-build-step from https://updates.jenkins.io/download/plugins/pipeline-build-step/2.1/pipeline-build-step.hpi
Downloading plugin: workflow-api from https://updates.jenkins.io/download/plugins/workflow-api/2.1/workflow-api.hpi
 > mailer has no dependencies
 > workflow-scm-step depends on workflow-step-api:1.15,git-client:1.19.0
 > pipeline-stage-step depends on workflow-api:1.15
Downloading plugin: git-client from https://updates.jenkins.io/download/plugins/git-client/1.19.0/git-client.hpi
 > pipeline-input-step depends on workflow-support:1.15,workflow-step-api:1.15
 > workflow-basic-steps depends on workflow-step-api:1.15,workflow-api:1.15,mailer:1.13
 > workflow-api depends on workflow-step-api:1.15
 > pipeline-stage-view depends on jquery-detached:1.1.1,momentjs:1.1,handlebars:1.1,pipeline-rest-api:1.4,workflow-job:1.14
Downloading plugin: jquery-detached from https://updates.jenkins.io/download/plugins/jquery-detached/1.1.1/jquery-detached.hpi
Downloading plugin: momentjs from https://updates.jenkins.io/download/plugins/momentjs/1.1/momentjs.hpi
Downloading plugin: handlebars from https://updates.jenkins.io/download/plugins/handlebars/1.1/handlebars.hpi
Downloading plugin: pipeline-rest-api from https://updates.jenkins.io/download/plugins/pipeline-rest-api/1.4/pipeline-rest-api.hpi
 > workflow-job depends on workflow-support:2.1
 > workflow-support depends on script-security:1.16,workflow-step-api:1.15,workflow-api:2.1
Downloading plugin: script-security from https://updates.jenkins.io/download/plugins/script-security/1.16/script-security.hpi
 > pipeline-build-step depends on workflow-support:1.15,workflow-api:1.15
 > workflow-cps-global-lib depends on workflow-cps:1.15,git-server:1.5
Downloading plugin: git-server from https://updates.jenkins.io/download/plugins/git-server/1.5/git-server.hpi
 > workflow-step-api depends on structs:1.1
Downloading plugin: structs from https://updates.jenkins.io/download/plugins/structs/1.1/structs.hpi
 > workflow-durable-task-step depends on workflow-step-api:1.15,durable-task:1.5,workflow-support:2.1,workflow-api:2.1
Downloading plugin: durable-task from https://updates.jenkins.io/download/plugins/durable-task/1.5/durable-task.hpi
 > workflow-cps depends on jquery-detached:1.2.1,script-security:1.18,workflow-api:2.1,workflow-support:2.1,scm-api:1.1,ace-editor:1.0.1,workflow-scm-step:1.15,workflow-step-api:2.1
Downloading plugin: scm-api from https://updates.jenkins.io/download/plugins/scm-api/1.1/scm-api.hpi
Downloading plugin: ace-editor from https://updates.jenkins.io/download/plugins/ace-editor/1.0.1/ace-editor.hpi
 > workflow-multibranch depends on cloudbees-folder:5.10,workflow-cps:2.3,branch-api:1.10,scm-api:1.1,workflow-job:1.15
Downloading plugin: cloudbees-folder from https://updates.jenkins.io/download/plugins/cloudbees-folder/5.10/cloudbees-folder.hpi
Downloading plugin: branch-api from https://updates.jenkins.io/download/plugins/branch-api/1.10/branch-api.hpi
 > git depends on parameterized-trigger:2.4;resolution:=optional,git-client:1.6.3,token-macro:1.10;resolution:=optional,credentials:1.10,multiple-scms:0.2;resolution:=optional,scm-api:0.2,ssh-credentials:1.6.1,promoted-builds:2.15;resolution:=optional
Skipping optional dependency parameterized-trigger
 > jquery-detached has no dependencies
Skipping optional dependency token-macro
Skipping optional dependency multiple-scms
Downloading plugin: credentials from https://updates.jenkins.io/download/plugins/credentials/1.10/credentials.hpi
Skipping optional dependency promoted-builds
Downloading plugin: ssh-credentials from https://updates.jenkins.io/download/plugins/ssh-credentials/1.6.1/ssh-credentials.hpi
 > git-server depends on git-client:1.11.0
 > structs has no dependencies
 > durable-task has no dependencies
 > script-security has no dependencies
 > scm-api has no dependencies
 > github-api has no dependencies
 > pipeline-rest-api depends on workflow-job:1.14,pipeline-input-step:2.0;resolution:=optional
Skipping optional dependency pipeline-input-step
 > momentjs has no dependencies
 > git-client depends on ssh-credentials:1.11
 > cloudbees-folder depends on credentials:1.18;resolution:=optional
Skipping optional dependency credentials
 > handlebars has no dependencies
 > credentials has no dependencies
 > ssh-credentials depends on credentials:1.9.4
 > ace-editor has no dependencies
 > branch-api depends on scm-api:1.2,cloudbees-folder:5.10

Cleaning up locks
 ---> 7d9185f281cb

That fix is not yet in jenkins:latest, see https://github.com/docker-library/official-images/blob/master/library/jenkins
you can use jenkinsci/jenkins


select not working

I haven't tested this with other html elements but selects are definitely not working once DRS is plugged in. You can easily test this on you demo page.
To recreate the exact bug, I put the select outside the the draggable div.

Are you attaching DRS to the  Element?  Try wraping it in a div.
If that does not work. Allow propagation on the mouse and touch events.
I will look into this as soon as time permits.  I believe removing e.stopPropagation() from the event handlers should do the trick.

This has been fixed in 862f97e. Removed preventDefault onDown...  Evryting should work as expected now.


Any chance of strong-name/signed builds of these packages?

My team needs MultiValueDictionary that is usable cross platform.  Is there any chance that a strong-named / authenticode signed nuget package could be built and made available on the dotnet-corefxlab nuget feed?  I know they are still pre-release, but right now I can't use the output of the feed at all without changing all relevant machines to allow delay signed bits...

https://github.com/dotnet/corefxlab/pull/601


mode_colors for v, not applying

Seems like there might be a bug, in the mode_colors for v, not matter what I set I get what my theme highlights it by default. all other modes works fine, even 'V'.  I tested in lualine and it respects the highlight color I set, which makes me think it's not something in my end.
Here is my config:
return {
  "tamton-aquib/staline.nvim",
  -- enabled = false,
  config = function()
    local p = require("rose-pine.palette")

    require 'staline'.setup {
      sections = {
        left = { '  ', 'mode', ' ', 'branch', ' ', 'file_name' },
        mid = { 'git_diff' },
        right = { 'lsp_name', ' ', 'line_column' }
      },
      mode_colors = {
        n = p.gold,
        i = p.love,
        ic = p.foam,
        c = p.pine,
        v = p.rose,
        V = p.iris,
      },
      defaults = {
        true_colors = true,
        line_column = " [%l/%L][%c] 並%p%% ",
        branch_symbol = " ",
      },
    }
  end,
}

Can someone confirm?

I was applying the wrong mode, sorry!


samples: net: sockets: Update docs with TLS information

Update documentation of socket samples that support TLS with information
on how to enable it.
Partially fixes #9926
Signed-off-by: Robert Lubos<EMAIL_ADDRESS>

Codecov Report

Merging #10211 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10211   +/-   ##
=======================================
  Coverage   53.03%   53.03%
=======================================
  Files         214      214
  Lines       26176    26176
  Branches     5642     5642
=======================================
  Hits        13883    13883
  Misses      10024    10024
  Partials     2269     2269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d8563...ca3d896. Read the comment docs.

@dbkinder Thank you for the feedback, I've addressed your comments.
I had a doubt about one comment, please check if slightly modified proposal is fine.

recheck


downloaded data is not valid on .xz and .bz2 i18n files

Getting the following errors:
2020-03-21T16:46:05.021453Z apt-cacher go-apt-cacher warning: "downloaded data is not valid" url="http://si.archive.ubuntu.com/ubuntu/dists/trusty-updates/main/i18n/Translation-en.bz2"
2020-03-21T16:46:05.032053Z apt-cacher go-apt-cacher warning: "downloaded data is not valid" url="http://si.archive.ubuntu.com/ubuntu/dists/xenial-updates/main/i18n/Translation-en.xz"

I found that the cache directory was at the limit set by cache_capacity. Increasing it and restarting go-apt-cacher fixed the issue.


Regression: 'SpecReporter' is not assignable to parameter of type 'CustomReporter'

Issue guidelines
Bug report

[x] I have this issue with the latest release of jasmine-spec-reporter
[x] I have this issue with the latest release of jasmine
[ ] I can reproduce this issue with one of the examples

Current behavior
@types/jasmine 3.7.2 re-introduces the error fixed in #588, albeit with slightly different outcome:
src/execute/index.ts(92,27): error TS2345: Argument of type 'SpecReporter' is not assignable to parameter of type 'CustomReporter'.
  Types of property 'suiteStarted' are incompatible.
    Type '(result: CustomReporterResult) => void' is not assignable to type '(result: SuiteResult, done?: (() => void) | undefined) => void | Promise<void>'.
      Types of parameters 'result' and 'result' are incompatible.
        Type 'SuiteResult' has no properties in common with type 'CustomReporterResult'.

Expected behavior
No type error, assignment works as expected.
Minimal reproduction of the problem with instructions
Package versions:

@types/jasmine: 3.7.2
jasmine: 3.7.0
jasmine-spec-reporter: 7.0.0

import Jasmine from "jasmine"
import { SpecReporter, StacktraceOption } from "jasmine-spec-reporter"

const jasmine = new Jasmine({})
jasmine.env.clearReporters()
jasmine.env.addReporter(new SpecReporter({
  spec: { displayStacktrace: StacktraceOption.RAW }
}))

Temporary workaround:
jasmine.env.addReporter(new SpecReporter({
    spec: { displayStacktrace: StacktraceOption.RAW }
  }) as jasmine.CustomReporter)

Possible fix
When introspecting the typings, it's pretty clear that the interfaces changed:
@types/jasmine / index.d.ts
interface CustomReporter {
  jasmineStarted?(suiteInfo: JasmineStartedInfo, done?: () => void): void | Promise<void>;
  suiteStarted?(result: SuiteResult, done?: () => void): void | Promise<void>;
  specStarted?(result: SpecResult, done?: () => void): void | Promise<void>;
  specDone?(result: SpecResult, done?: () => void): void | Promise<void>;
  suiteDone?(result: SuiteResult, done?: () => void): void | Promise<void>;
  jasmineDone?(runDetails: JasmineDoneInfo, done?: () => void): void | Promise<void>;
}

jasmine-spec-reporter / built/spec-reported.d.ts
export declare class SpecReporter implements CustomReporter {
  ...
  jasmineStarted(suiteInfo: SuiteInfo): void;
  jasmineDone(runDetails: RunDetails): void;
  suiteStarted(result: CustomReporterResult): void;
  suiteDone(result: CustomReporterResult): void;
  specStarted(result: CustomReporterResult): void;
  specDone(result: CustomReporterResult): void;
  private runDetailsToResult;
}

@squidfunk upgrading to version 3.7.4 of @types/jasmine fixed this for me.

@bcaudan I can still reproduce with 3.7.4 which was released 5 hours after I wrote this issue.

I think this can be closed, as it doesn't happen for me anymore with the following versions:

@types/jasmine: 3.10.2
jasmine: 3.10.0
jasmine-spec-reporter: 7.0.0


Pin the numpy dependency for koverage env

Hi @Vini2 ,
Congratulations on the great tool!
I am trying to integrate reneo into everest-nf and came across an issue during runtime
ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

It seems that the problem might be the fact that pandas relies on a minimal version of numpy but not the maximum and since there are some breaking changes in numpy 2.0.0 the error propogates further up.
Reference: https://stackoverflow.com/a/78641304/6482586
CC @agudeloromero

Actually, I've just faced another issue with koverage - perhaps @beardymcjohnface might be able to provide a more stable fix for the koverage release.
The error I have now come across is related to jupyter
    raise DPClientError(f"{type(b.data).__name__} not supported for {self.__class__.__name__}")
datapane.client.exceptions.DPClientError: DataFrame not supported for XMLBuilder
Please run with `dp.enable_logging()`, restart your Jupyter kernel/Python instance, and/or visit https://www.github.com/datapane/datapane

Hi @abhi18av,
Thanks for raising this issue and putting a PR. I'll pin numpy in reneo.yaml as well and publish a new release.
@beardymcjohnface can you please take a look at this issue?
Thanks!

@Vini2 if you want a quick fix and you don't need the koverage HTML report, then I would add --no-report to the koverage step in rule koverage_genomes. Unfortunately, generating the report uses a few libraries that can be flakey. I just ran it fine on a fresh install on our VM but the error has popped up before.

Thanks @beardymcjohnface! I'll add the --no-report flag for now to publish a new release.

Thank you both for the quick progress here!


rng-tools: remove redundant null checks & with lib over entire file

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg build rng-tools

No description, no context, no rationale, no linked issue?
And self-merged without review.

The PR/commit title is the description and the motivation is to update older packages to current standards and increase the quality of the code. In NixOS we do not create issues for every little bit just for the issue creating.  Also you had 3 weeks to react and since this does not trigger a rebuild it is safe to merge.


merge default attributes before check instead of during intialization

So that following can work:
FoodCritic::Rake::LintTask.new do |t|
  t.options = {
    fail_tags: ['any'],
    cookbook_paths: ['site-cookbooks/', 'cookbooks/'],
    chef_version: Chef::VERSION
  }
end

I'm fine with this. I'm going to change your title though - please don't ever use "default attributes" in a chef space unless you mean node attributes at a default precedent. :)


Add benchmarks for start/end span and record trace events.

Benchmarks ran with https://github.com/google/instrumentation-java/pull/296 (mean values)
BinaryPropagationHandlerImplBenchmark.fromBinaryValueSpanContext      66.611 ±  1.568  ns/op
BinaryPropagationHandlerImplBenchmark.toBinaryValueSpanContext          67.977 ±  2.524  ns/op
BinaryPropagationHandlerImplBenchmark.toFromBinarySpanContext           146.850 ± 39.152  ns/op
RecordTraceEventsNonSampledSpanBenchmark.addAnnotation                  55.014 ±  1.872  ns/op
RecordTraceEventsNonSampledSpanBenchmark.addLink                             46.806 ±  1.752  ns/op
RecordTraceEventsNonSampledSpanBenchmark.addNetworkEvent             49.202 ±  1.996  ns/op
RecordTraceEventsSampledSpanBenchmark.addAnnotation                         79.445 ± 40.390  ns/op
RecordTraceEventsSampledSpanBenchmark.addLink                                    59.594 ± 17.770  ns/op
RecordTraceEventsSampledSpanBenchmark.addNetworkEvent                    48.520 ±  1.840  ns/op
StartEndSpanBenchmark.startEndNonSampledChildSpan                             68.181 ±  8.417  ns/op
StartEndSpanBenchmark.startEndNonSampledRootSpan                              69.895 ±  3.243  ns/op
StartEndSpanBenchmark.startEndRecordEventsChildSpan                            61.785 ± 24.352  ns/op
StartEndSpanBenchmark.startEndRecordEventsRootSpan                             58.410 ±  3.025  ns/op
StartEndSpanBenchmark.startEndSampledChildSpan                                     61.010 ± 12.419  ns/op
StartEndSpanBenchmark.startEndSampledRootSpan                                      61.113 ±  3.164  ns/op

Codecov Report

Merging #297 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #297      +/-   ##
============================================
+ Coverage     93.89%   93.94%   +0.05%
  Complexity      462      462
============================================
  Files            79       79
  Lines          1768     1768
  Branches        110      110
============================================
+ Hits           1660     1661       +1
  Misses           77       77
+ Partials         31       30       -1

Impacted Files
Coverage Δ
Complexity Δ

...oogle/instrumentation/trace/TraceExporterImpl.java
92.75% <0%> (+1.44%)
8% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c48eb...920eb96. Read the comment docs.

I like that you measure in ns :P