CSE: sequences show extra brackets

The display of statement sequences currently includes brackets which are not part of of JavaScripts statement syntax.

The square brackets are added in the astToString function that gives string representation of nodes.
It's in js-slang - I'll fix it there.


Azure AD support with MFA gives bad code error

Issue Type: Bug
I have previously been able to log into Azure SQL Databases using the Azure AD with MFA support option, but recently I can't refresh my credentials, or add new connections.
1- Click add new server
2- Add Server name
3- Select Azure Active Directory - Universal with MFA support
4- Choose my existing account from the dropdown
5- Click refresh account credentials
6- Click the Copy & Open button on the credential refresh screen
7 - Browser opens and requests my MFA code, which I add.
8 - Get "That code didn't work. Check the code and try again"
I can't get any further. I then open SSMS and use the Azure AD Support there, using a code provided by the same authenticator app used above and it works just fine.
After I enter the code it should finish the authentication and add the connection. I realize that this sounds more like a problem with Azure AD flow, but I do not get this error when using SSMS with the same account and authenticator app. This makes ADS useless to me as most of my interaction is with Azure SQL DB and we are using Azure AD as a standard for connections.
Azure Data Studio version: azuredatastudio 1.12.1 (cccb9327c707fe71de24d5ce655acb29cc8946d1, 2019-10-07T21:49:53.568Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4650U CPU @ 1.70GHz (4 x 2295)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.91GB (2.18GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

admin-tool-ext-win
Mic
0.0.1

This behavior started a few weeks back, but was working fine prior. There was a period where connections that still had a valid token would work, but now they have all pretty much stopped because trying to refresh the tokens get the error above.

This ended up being complete user error I think. Closing.


chore: bdd-spring-1581438285 to 0.0.1

chore: Promote bdd-spring-1581438285 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Flyway does not report an error with incorrect command-line parameters

What version of Flyway are you using?
4.1.1
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Command-line
What database are you using (type & version)?
Oracle 11r2
What operating system are you using?
Mac OSX Sierra
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
+---------------------+-------------------------------------+---------------------+---------+
| Version             | Description                         | Installed on        | State   |
+---------------------+-------------------------------------+---------------------+---------+
| <IP_ADDRESS>70327.1108 | new Sequences                       |                     | Pending |
| <IP_ADDRESS>70327.1109 | new Tables                          |                     | Pending |
| <IP_ADDRESS>70327.1130 | new Functions                       |                     | Pending |
| <IP_ADDRESS>70327.1150 | cust view Utenti                    |                     | Pending |
| <IP_ADDRESS>70327.1151 | cust view V TALKS ISCRITTI          |                     | Pending |
| <IP_ADDRESS>70327.1152 | cust view V TALKS ISCR 2017 T0201   |                     | Pending |
| <IP_ADDRESS>70327.1155 | add dataora spedizioni              |                     | Pending |
| <IP_ADDRESS>70327.1200 | drop comunicazioni id on spedizioni |                     | Pending |
+---------------------+-------------------------------------+---------------------+---------+

flyway -configFile=conf/dallas-flyway_test-bocconi.cfg  -taget=<IP_ADDRESS>70327.1151  migrate

I used a wrong parameter. taget instead of ```target````
What did you expect to see?
Flyway report an error because taget parameter is unknow
What did you see instead?
Flyway apply all migrations !

Hmm this should actually be checked...

Flyway shows the message WARNING: Unknown configuration properties: flyway.target` but migrations are applied
https://asciinema.org/a/6q6m84saohacpmq8tadcwfpbn


Allow sending MIDI notes without specifying an instrument (for portomento)

Currently using a midi instrument on a step in a phrase will requires a midi instrument to be specified and hence will cause a note on midi command to be sent.
A user on discord requested:

it would be excellent if I could put a note in a phrase without an Instrument column value, so I could send pitch and not trigger a new MIDI NOTE ON event

For the above to work, the code will need to track the last used midi instrument in a phrase and then use that if there is none specified as well as the UI code needing to be changed to allow user to edit a step in a phrase to set an empty instrument value when a note is set for that step (currently it immediately fills in an instrument value when a note is added)
code ref, the Render function in: https://github.com/democloid/picoTracker/blob/master/sources/Application/Instruments/MidiInstrument.cpp#L85

UI code needing to be changed to allow user to edit a step in a phrase to set an empty instrument value when a note is set for that step (currently it immediately fills in an instrument value when a note is added)

As this is specifically a use case for note overlap to trigger Portamento / Legato, the above UI change is not necessary as you can delete the instrument value without removing the pitch (as it is currently implemented), and the use case for majority of the picoTracker users will expect an instrument to be filled by default, including those sending MIDI.

doh! thanks for pointing that out @mikey303 ! 👍🏻   I completely missed that it is currently already possible to just delete only the instrument value.

So I needed to do this with a command instead of just not setting the instrument as discussed in this issue as that would be harder to implement, requiring the need to track the previous "pending" midi instrument on the current channel, so this is a much simpler, cleaner solution.

@mikey303 one issue I've run into is that when testing with a TD-3, it needs to have at least 1 non overlapping note sound otherwise all the sound just sort of trails off and stops responding to any further MIDI input until the internal sequencer plays at least 1 note or MIDI sounds a non-overlapping note.
Not sure if thats a bug in the TD-3 (I have the latest firmware 1.37) or this is just how 303 style instruments implement MIDI and slides? Any expert thoughts about this would be most appreciated! 🙏🏻


Changes to be compatible with league/oauth2-client 2.4

Switched to mockery for mocking as composer was nagging and added phpunit.xml file also

Thank you very much for the contribution! I will cut a new release shortly.


What about limits for "container group quota"

We get this message when we try to start an 11th concurrent container...
Microsoft.Rest.Azure.CloudException: Resource type 'Microsoft.ContainerInstance/containerGroups' container group quota 'StandardCores' exceeded in region 'eastus'. Limit: '10', Usage: '10' Requested: '1'.
Which of the limits above refer to this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c7a4f16d-190f-a1c0-fab0-5a9065554166
Version Independent ID: 0dab3702-f14f-7fb8-f9d7-e39be7230ab5
Content: Service quotas and region availability - Azure Container Instances
Content Source: articles/container-instances/container-instances-quotas.md
Service: container-instances
GitHub Login: @dlepow
Microsoft Alias: danlep

Thanks for the question. We are currently investigating and will update you shortly.

@StingyJack By default the limit is 100 container groups per region per subscriptions.
i see that you have created a support ticket as well.
Lets wait for the support to get the info

Once quota is increased, you will be able to provision container groups

@jakaruna-MSFT the thing we are using is container instances. I don't see any mention of container groups in the UI except for this error. Are there any doc's that explain the difference?

We run containers inside the container groups on a ACI.  Public ip is the component out of the container group
This doc explains that https://docs.microsoft.com/en-us/azure/container-instances/container-instances-container-groups

@jakaruna-MSFT  - thanks for the docs links. Since you see the support ticket, can you give someone in support a nudge? We havent had any response and it should have been 2 hours or less initial response time.

Checked the ticket. Limit is increased to 50.  Can you check and confirm.
I got the ticket based on you issue description.  So mostly that should be opened by your company.

Yeah it just wasn't getting any response until I tweeted at az support. They finally called us back a few hours after that.
So it's 100 container groups per region, per subscription. Is there a hard limit to the number of containers per group? Like can we make it 200?

Certain default limits and quotas can be increased. You would need to try requesting by following the process here.

@Karishma-Tiwari-MSFT if you don't know what the limits are, it ok to say that. It's ok to not know something. I don't understand the vague response to a specific question.

@StingyJack  As mentioned in the document, the limit is 60 containers per container group.
That's why I mentioned that Certain default limits and quotas can be increased. You would need to try and see by requesting by following the support request process.

@karishma-tiwari-msft  I asked which limit it was. That was my first question. Don't be all "as mentioned in the document...", when you decided to finally answer the question in the same sentence. It's not like it was mentioned previously and you are reinforcing the point.
The error message text does not jibe with the limit you are pointing out. Nor does the limit. I'd expect that the docs text would align with the programs text.
You should reopen this and use it to make the docs align with the program, and  maybe try answering the questions posed instead of dodging for a few days and snark closing requests. It would probably be less work for everyone.

We are receiving the same error message, and there's still no such limit mentioned in the documentation. 10 cores across the entire subscription is not useful for any sort of production-level system.

Yeah, I'm getting the same issue on my Kubernetes Cluster when scaling:
_```
Status:         Pending
Reason:         ProviderFailed
Message:        api call to https://management.azure.com/subscriptions/xxx/resourceGroups/xxx-cluster_westeurope/providers/Microsoft.ContainerInstance/containerGroups/xxx-5c5649645d-wlvcz?api-version=2018-10-01: got HTTP response status code 400 error code "ContainerGroupQuotaReached": Resource type 'Microsoft.ContainerInstance/containerGroups' container group quota 'StandardCores' exceeded in region 'westeurope'. Limit: '10', Usage: '15' Requested: '1'.

@Karishma-Tiwari-MSFT can you reopen this? There's still an undocumented default limit if 10 cpu cores across all container instances in a subscription, it seems. It took us about a weeks back and forth with support to increase this, so it seems the confusion is on both sides.

@Karishma-Tiwari-MSFT @jakaruna-MSFT if the docs haven't been updated to include all of this information, I can't really consent to the issue being closed.

@StingyJack thanks for the tip. We redesigned our (quite simply) architecture to work around the startup time, which for us was around 45 secs. The docs seemed to suggest each instance should handle a single task, but in reality that goes very much against the grain of how ACI works in practice, at least currently. Instead we now have each instance handle X number of tasks or run for N minutes, whichever comes first.

Thanks for sharing the updates. I have reopened this issue and assigned to the content author to investigate further and update the document as appropriate.

We've updated the ACI quotas documentation to include information about CPU quotas. The default is dependent on your subscription offer. Currently for a pay-as-you-go subscription the default CPU quota is 10 cores per region.
Standard sku cores (CPUs) per region per subscription | 10
Standard sku cores (CPUs) for K80 GPU per region per subscription | 18
Standard sku cores (CPUs) for P100 or V100 GPU per region per subscription | 0

Thanks.
Can you give any insights to the reason for this very low default limit? It seems strange that, by default, we can create 100 container groups each with 60 containers, but in all these can only use 10 cores in total. Effectively that puts the limit at 10 containers (split between one or more groups) per subscription, since a container obviously must have at least one core to run.

@runemoennike - Apologies for delayed response. Here are a couple of considerations for the default cores settings (and note that CPU core settings can usually be increased on request): 1. You can specify fractional cores for your instances in a group - for example, 0.1 CPU per container - if your workload will run on those resources. 2. The cores limit is per region in your subscription. If suitable for your scenario, you can create container groups in multiple regions. That said, the various defaults aren't set with a single customer in mind - different limits come into play with different workloads or service usage patterns. I hope this helps!

You're welcome. I'll proceed to close this issue for now. Thanks for helping improve the docs.
#please-close


Semicolon after closing curly brace should yield an error

if (foo) {
  console.log('bar')
}; // <-- Semicolon is here, but no errors

I seen that case and it was discussed already i believe. Don't remember what was the case and state.

@charlike I couldn't believe if it was really intended behaviour. Semicolon after } doesn't fit anywhere, it doesn't fit the traditional C style, nor does it fit standard.js which in turn forbids semicolons.

I couldn't believe if it was really intended behaviour.

I didn't said that it is intended. I said that it was discussed and probably should be searched in the issues.

@charlike  I searched and found nothing except this issue

Anyway.. it's needless to comment more. I just saying that i seen such discussion, so someone that remember more can link :)

This may be fixable with the https://eslint.org/docs/rules/no-extra-semi rule. Re-opening this issue so I can take a look at fixing this in standard v12.


Add CompatHelper secret

This PR prepares CompatHelper for running the CI tests on Github (currently CompatHelper does not run any Github CI tests).
Someone with sufficient permissions has to follow the steps in https://github.com/bcbi/CompatHelper.jl#122-instructions-for-setting-up-the-ssh-deploy-key and add a private key and a deploy key to make it actually work.

Someone with sufficient permissions has to follow the steps in https://github.com/bcbi/CompatHelper.jl#122-instructions-for-setting-up-the-ssh-deploy-key and add a private key and a deploy key to make it actually work.

@devmotion Just made you an admin, you should be able to change the setting for Turing.jl now.

Done :+1:


DOC: Fix git commands for creating your own library

@bryandeng Thank you for your contribution.

@bryandeng Can you rebase this so we can merge ? The tests pass on the latest code

OK. Done.

Coverage remained the same at 100.0% when pulling 81836f1c7000c34361987f52b1cee3b7ee051d08 on bryandeng:urls into d7bc3aa9209476ccafff57caa5348090fe448e20 on scikit-learn-contrib:master.

Thanks @bryandeng


Fixed .d.ts typings.

https://github.com/javascript-obfuscator/javascript-obfuscator/issues/623

Coverage remained the same at 98.683% when pulling 8142d184da921829d8b2b75653fe26afd4267225 on typings-fix into 8c87e9cc369f6214a257e5e7b2386d3731c62f64 on master.


Update multi-platform workflow with correct build args

Signed-off-by: Hanish Rishen<EMAIL_ADDRESS>Description
This PR fixes #328
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Thanks, @hanish-rishen!


Previous created ragapps breaks after pulling the latest version (multiple-ragapps)

Describe the bug
When pulling the latest version of ragapp (added agents) it breaks previously created ragapps in the multiple-ragapps app because of missing agent config file
Newly generated ragapps are working properly.
To Reproduce
Steps to reproduce the behavior:

Have a previous instance of multiple ragapps deployed.
Pull the latest ragapp
Re build
See error when chatting or open the old ragapps settings

Expected behavior
Handle missing agent config file. Not give any agent options maybe? IDK
Screenshots

In the second screenshot you can see the empty drawer

@benjaminbascary Thanks for the detailed description! Could you let me know what kind of deployment you’re using? I’m assuming you deployed with a mounted folder, which might be overriding your current agent configuration (agents.yaml) with the new one. If that's the case, i think you can try copy the released default agents.yaml file here (https://github.com/ragapp/ragapp/blob/e7e789d372d062ce654cd12fa109c253699853bb/src/ragapp/config/agents.yaml) to your config folder.


[FIX] Added support for TEXT columns

This fixes #51, as discussed in the comments here.
@c-nichols, maybe you can take a look when you're free?

@c-nichols Would it be possible for you to issue a new release on PyPI? I need the functionality in one of my projects.

@c-nichols Bump.


[Errorlog] Delete/Clear errorlog utility

https://github.com/openbmc/openbmc/issues/1327
Need to add utility in code for Errorlog and association use cases.

This will only delete a given error log entry. There is a discussion with dev folks for clear/purge entire errorlog.


published indexmap 1.3.1 has broken Cargo.toml

1.3.1 seems to not be shipped with a Cargo.toml generated by cargo package, which is what is expected from running cargo publish
Here's the diff from 1.3.0 to 1.3.1:

diff 1.3.0/Cargo.toml 1.3.1/Cargo.toml
diff --git a/Cargo.toml b/Cargo.toml
index 7b4e98d..166a7f8 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,66 +1,65 @@
-# THIS FILE IS AUTOMATICALLY GENERATED BY CARGO
-#
-# When uploading crates to the registry Cargo will automatically
-# "normalize" Cargo.toml files for maximal compatibility
-# with all versions of Cargo and also rewrite `path` dependencies
-# to registry (e.g., crates.io) dependencies
-#
-# If you believe there's an error in this file please file an
-# issue against the rust-lang/cargo repository. If you're
-# editing this file be aware that the upstream Cargo.toml
-# will likely look very different (and much more reasonable)
-
 [package]
 name = "indexmap"
-version = "1.3.0"
-authors = ["bluss", "Josh Stone<EMAIL_ADDRESS>-build = "build.rs"
-description = "A hash table with consistent order and fast iteration.\n\nThe indexmap is a hash table where the iteration order of the key-value\npairs is independent of the hash values of the keys. It has the usual\nhash table functionality, it preserves insertion order except after\nremovals, and it allows lookup of its elements by either hash table key\nor numerical index. A corresponding hash set type is also provided.\n\nThis crate was initially published under the name ordermap, but it was renamed to\nindexmap.\n"
+version = "1.3.1"
+authors = [
+"bluss",
+"Josh Stone<EMAIL_ADDRESS>+]
 documentation = "https://docs.rs/indexmap/"
+repository = "https://github.com/bluss/indexmap"
+license = "Apache-2.0/MIT"
+description = """
+A hash table with consistent order and fast iteration.
+
+The indexmap is a hash table where the iteration order of the key-value
+pairs is independent of the hash values of the keys. It has the usual
+hash table functionality, it preserves insertion order except after
+removals, and it allows lookup of its elements by either hash table key
+or numerical index. A corresponding hash set type is also provided.
+
+This crate was initially published under the name ordermap, but it was renamed to
+indexmap.
+"""
+
 keywords = ["hashmap", "no_std"]
 categories = ["data-structures", "no-std"]
-license = "Apache-2.0/MIT"
-repository = "https://github.com/bluss/indexmap"
-[package.metadata.docs.rs]
-features = ["serde-1", "rayon"]

-[package.metadata.release]
-no-dev-version = true
-tag-name = "{{version}}"
-[profile.bench]
-debug = true
+build = "build.rs"

 [lib]
 bench = false
-[dependencies.rayon]
-version = "1.0"
-optional = true

-[dependencies.serde]
-version = "1.0"
-optional = true
-[dev-dependencies.fnv]
-version = "1.0"
+[build-dependencies]
+autocfg = "1"
+[dependencies]
+serde = { version = "1.0", optional = true }
+rayon = { version = "1.0", optional = true }

-[dev-dependencies.itertools]
-version = "0.8"
+[dev-dependencies]
+itertools = "0.8"
+rand = "0.6"
+quickcheck = { version = "0.8", default-features = false }
+fnv = "1.0"
+lazy_static = "1.3"
+serde_test = "1.0.99"

-[dev-dependencies.lazy_static]
-version = "1.3"
+[features]
+# Serialization with serde 1.0
+serde-1 = ["serde"]
+
+# for testing only, of course
+test_low_transition_point = []
+test_debug = []

-[dev-dependencies.quickcheck]
-version = "0.8"
-default-features = false
+[profile.bench]
+debug = true

-[dev-dependencies.rand]
-version = "0.6"
+[package.metadata.release]
+no-dev-version = true
+tag-name = "{{version}}"

-[dev-dependencies.serde_test]
-version = "1.0.99"
-[build-dependencies.autocfg]
-version = "0.1.6"
+[package.metadata.docs.rs]
+features = ["serde-1", "rayon"]

-[features]
-serde-1 = ["serde"]
-test_debug = []
-test_low_transition_point = []
+[workspace]
+members = ["test-nostd"]

Additionally, unlike 1.3.0, which works fine with the cargo-generated Cargo.toml

1.3.0 cargo test success
cargo test
    Updating crates.io index
  Downloaded autocfg v0.1.7
  Downloaded serde_test v1.0.104
  Downloaded rand v0.6.5
  Downloaded quickcheck v0.8.5
  Downloaded itertools v0.8.2
  Downloaded serde v1.0.104
  Downloaded rand_jitter v0.1.4
  Downloaded rand_pcg v0.1.2
  Downloaded rand_xorshift v0.1.1
  Downloaded rand_hc v0.1.0
  Downloaded rand_os v0.1.3
  Downloaded rand_chacha v0.1.1
  Downloaded rand_isaac v0.1.1
  Downloaded either v1.5.3
   Compiling autocfg v0.1.7
   Compiling rand_core v0.4.2
   Compiling libc v0.2.66
   Compiling serde v1.0.104
   Compiling either v1.5.3
   Compiling lazy_static v1.4.0
   Compiling fnv v1.0.6
   Compiling rand_core v0.3.1
   Compiling rand_jitter v0.1.4
   Compiling itertools v0.8.2
   Compiling rand_chacha v0.1.1
   Compiling rand_pcg v0.1.2
   Compiling rand v0.6.5
   Compiling indexmap v1.3.0 (/home/kent/.cpanm/work/1580894972.28404/indexmap-1.3.1)
   Compiling rand_xorshift v0.1.1
   Compiling rand_hc v0.1.0
   Compiling rand_isaac v0.1.1
   Compiling rand_os v0.1.3
   Compiling quickcheck v0.8.5
   Compiling serde_test v1.0.104
    Finished test [unoptimized + debuginfo] target(s) in 47.28s
     Running target/debug/deps/indexmap-af6a4872f48a66f7

running 33 tests
test map::tests::entry_or_default ... ok
test map::tests::entry ... ok
test map::tests::entry_and_modify ... ok
test map::tests::extend ... ok
test map::tests::insert ... ok
test map::tests::insert_full ... ok
test map::tests::grow ... ok
test map::tests::it_works ... ok
test map::tests::insert_order ... ok
test map::tests::keys ... ok
test map::tests::new ... ok
test map::tests::partial_eq_and_eq ... ok
test map::tests::remove_to_empty ... ok
test map::tests::remove ... ok
test map::tests::values ... ok
test map::tests::values_mut ... ok
test map::tests::swap_remove_index ... ok
test set::tests::comparisons ... ok
test set::tests::extend ... ok
test set::tests::insert ... ok
test set::tests::grow ... ok
test set::tests::insert_dup ... ok
test set::tests::insert_full ... ok
test set::tests::insert_order ... ok
test set::tests::it_works ... ok
test set::tests::iter_comparisons ... ok
test set::tests::new ... ok
test set::tests::partial_eq_and_eq ... ok
test set::tests::remove ... ok
test set::tests::ops ... ok
test set::tests::swap_remove_index ... ok
test map::tests::insert_2 ... ok
test set::tests::insert_2 ... ok

test result: ok. 33 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/equivalent_trait-1769a2528452c354

running 2 tests
test test_lookup ... ok
test test_string_str ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/macros_full_path-e6fdf8b9bff872b5

running 2 tests
test test_create_map ... ok
test test_create_set ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/quick-711278843a6d10b5

running 16 tests
test drain ... ok
test contains ... ok
test equality ... ok
test contains_not ... ok
test insertion_order ... ok
test insert_remove ... ok
test operations_string ... ok
test pop ... ok
test keys_values ... ok
test operations_i8 ... ok
test keys_values_mut ... ok
test shift_remove ... ok
test with_cap ... ok
test sort_2 ... ok
test sort_1 ... ok
test retain_ordered ... ok

test result: ok. 16 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/serde-406ea1513b9cfc01

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/tests-f4d162c97b6224f6

running 2 tests
test test_sort ... ok
test test_sort_set ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests indexmap

running 4 tests
test src/set.rs - set::IndexSet (line 55) ... ok
test src/macros.rs - indexset (line 47) ... ok
test src/map.rs - map::IndexMap (line 259) ... ok
test src/macros.rs - indexmap (line 8) ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

1.3.1 is broken for all cargo commands:

1.3.1 breakage
> cargo build
error: failed to read `/home/kent/.cpanm/work/1580894972.28404/indexmap-1.3.1/test-nostd/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

> cargo test
error: failed to read `/home/kent/.cpanm/work/1580894972.28404/indexmap-1.3.1/test-nostd/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

 > cargo package
error: failed to read `/home/kent/.cpanm/work/1580894972.28404/indexmap-1.3.1/test-nostd/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

> cargo update
error: failed to read `/home/kent/.cpanm/work/1580894972.28404/indexmap-1.3.1/test-nostd/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

This seems like a pretty serious regression, and is likely to be a substantial impediment to all linux vendors packaging rust.

I just used the MSRV (1.18) cargo when publishing 1.3.1, which doesn't rewrite Cargo.toml -- that was introduced in rust-lang/cargo#4030, cargo 0.20.0 (Rust 1.19).

This seems like a pretty serious regression, and is likely to be a substantial impediment to all linux vendors packaging rust.

I think you're overstating the severity. The crates.io package is not broken when used as a normal dependency, and the missing workspace only matters when you try to use it as a primary source. I happen to be a Fedora packager too, and I just patched it out there:
https://src.fedoraproject.org/rpms/rust-indexmap/blob/314395ffa87c370a0ef2bdcc41e7ebddc034beff/f/indexmap-fix-metadata.diff#_18
As a linux vendor, you should already be prepared to make such changes for any crate that was packaged before Cargo.toml rewriting started.
Still, I will make a new release...

I think you're overstating the severity.

Indeed, after filing the bug I found it was easier to patch out than I'd anticipated.
Though thanks for making a new release anyway, where possible, we desire to follow upstream with as few patches as possible :)

I just used the MSRV (1.18) cargo when publishing 1.3.1,

@cuviper  Is it important to package like this? Just curious why you've included this in your process.

I feel wary of publishing with newer Cargo than MSRV, in case its Cargo.toml rewriting ever does something that's not supported by older Cargo. However, I'm not aware of any such problems yet.

I feel wary of publishing with newer Cargo than MSRV, in case its Cargo.toml rewriting ever does something that's not supported by older Cargo. However, I'm not aware of any such problems yet.

Only problem I'm aware of is the new Cargo.lock layout getting shipped, which doesn't parse with older cargo, but you'll only have that if you ship examples or binaries.


Integration Tests fails due to web hook problems

How to categorize this issue?

/area deployers
/kind bug
/priority 2
What happened:
The integration tests fails frequently due to errors from the web hook when creating resources. It is unclear if the errors comes from the shoot cluster infrastructure or from the landscaper implementation.
To make the tests more stable, a hack was implemented which retries the creation up to ten time in the method func (s *State) CreateWithClientAndRetries. If a retry occurred, just search for CreateWithClient in the test logs.
The root cause of the problem must be found.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Landscaper version:
Kubernetes version (use kubectl version):
Others:

moved to other project


fix: Upload image functionality

Pull Request Details
Description
Updated the upload picture functionality
Fixes
#911
Type of PR

[x] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Refactoring
[ ] Other (specify): _______________

Summary

Updated the upload picture functionality
Added a confirm popup ui

Screenshots (if applicable)
Additional Notes
Checklist

[ ] I have read and followed the Pull Requests and Issues guidelines.
[ ] The code has been properly linted and formatted using npm run lint:fix and npm run format:fix.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, snapshots, and videos after making the changes.
[ ] I have not borrowed code without disclosing it, if applicable.
[ ] This pull request is not a Work In Progress (WIP), and only completed and tested changes are included.
[ ] I have tested these changes locally.
[ ] My code follows the project's style guidelines.
[ ] I have updated the documentation accordingly.
[ ] This PR has a corresponding issue in the issue tracker.

Summary by CodeRabbit

New Features

Added a user-friendly image upload dialog for profile pictures, allowing users to select, preview, and upload images.
Introduced success and error notifications for profile image updates to improve user feedback.

Enhancements

Integrated image upload functionality into the user dashboard, providing a seamless experience for updating profile pictures.

Can you please add recording for this? (Also for mobile)

Can you please add recording for this? (Also for mobile)

Okay

https://github.com/digitomize/digitomize/assets/73209315/7a38b277-5192-46a3-9331-5fa1d590727a

hi @saadman-galib make the tittle fix: Upload image functionality

hi @saadman-galib make the tittle fix: Upload image functionality

It was the same btw. But I have changed.
Can you pls review the pull request?

@pranshugupta54 LGTM 🚀

@pranshugupta54   Can you please review this pull request


Support Audio Level Indication

Adds support for parsing the audio level extension header as described in https://tools.ietf.org/html/rfc6464.
Supports decoding both one and two byte formats but only encodes one byte. Let me know if we would like to support marshaling into two byte as well. In that case let me know what interface would make sense.
#54

Updated PR to follow the chromium implementation. A little simpler :)


chore: add missing translations

Title:
Fix translation issues from Hebrew to English
Description:
This PR addresses several issues related to the translation from Hebrew to English:
1. Time Format Fix

Corrected the time format to adapt based on the active language:

In English, the time is displayed as "AM/PM".
In Hebrew, the time is displayed as "אחר הצהריים" or "בבוקר".

Used the i18n.language property to dynamically switch the locale in Moment.js for proper time formatting in both languages.

Before:

After:

2. Title Tag Update

Fixed the <title> tag in the document head to correctly update when switching languages.
Ensured that the title is properly displayed in English when the site is in English.

Before:

After:

3. Header Translation

Changed a header that was in Hebrew to English to match the selected language.
Ensured consistency across the page by making sure all headers are translated according to the active language.

Before:

After:

Thanks!
@all-contributors plaese add @EstherKal as code contributor :bus: :muscle:


Feature - Machine learning Basics

Greetings !!
I thought if this is a ML repository then ofcourse beginners like me would also like to learn some basics about Datascience to learn ML right.So I would like to make a small notebook on learning matplotlib pyplot and its properties. :)
I guess that would be useful for many people.
Thank You

Hi Sir, I just messaged you in Discord that you will assign me this project. Can you please assign this so that I can do my first PR to this issue? And please label it as GSOC 24.

Hi Sir, I just messaged you in Discord that you will assign me this project. Can you please assign this so that I can do my first PR to this issue? And please label it as GSOC 24.

Please make a new issue and ask sir about the modification you want to make .It will be beneficial for you .
:)

Hi, i got busy with leaderboard launch, assigned this issue to you

Hi, i got busy with leaderboard launch, assigned this issue to you
Its Ohk sir...

Sir I don't know if its good or not to ask you about this but i think that this issue deserves a level 2 or level 3 as it will be included with all the basics of matplotlib in the notebook.
Regards :)


[KARAF-6561] Upgrade to maven-jxr-plugin 3.0.0

retest this please

retest this please

retest this please


Fix CPU query

Closes https://github.com/infrawatch/dashboards/issues/55

Here is a test of the query. The original query said my controller-0 CPU was at 28.4799%. The revised query says 99.9999%.
[root@controller-0 ~]# uptime
 13:56:00 up 13 days, 16:02,  1 user,  load average: 14.14, 12.73, 12.56

Yup, that's 99.9999% alright.
Ideally we should test the dashboard itself and the multi-host scenario.

I'm not going to merge this until I have (or someone has) loaded the dashboard in grafana and selected multiple hosts. I'll likely be able to fit it in over the next couple days, but don't currently have a grafana deployment

I'm not going to merge this until I have (or someone has) loaded the dashboard in grafana and selected multiple hosts. I'll likely be able to fit it in over the next couple days, but don't currently have a grafana deployment

I think this is something I can load into my environment which is running Grafana as part of other development. Victoria also noted she might have an OSP environment (I also have one) so we can point both our deployments at my STF environment and I can load the updated dashboard.

Sorry, do you want to see multiple clouds, or multiple infrastructure nodes?
Here are a couple of screenshots from New vs Original, comparing controller vs compute nodes.
compute-1
Original

Update

controller-0
Original

Update

The sum by (host,plugin_instance) and the naming of the variable $hosts led me to believe that it was possible to multi-select more than one host for this query. If that's not the case, then this is good enough.

The sum by (host,plugin_instance) and the naming of the variable $hosts led me to believe that it was possible to multi-select more than one host for this query. If that's not the case, then this is good enough.

Ah gotcha. I think our dashboards only play in single selector drop down and not a multi-select box as it stands.


Should we use Iterable

What are the advantages of the class for this library?
@lukas-h

Try to work with https://github.com/dart-lang/collection


Revert "Deprecate strings/slices functions covered by stdlib slices"

This reverts commit 4965b0f13691de9f60deba4e3e0b4526f27aa76e as it
incorrectly started using stdlib slices without declaring that this repo
is now only compatible with golang >=1.21.
Closes: #316

/easycla

/easycla

@thockin could you check this please? (Sorry for pinging directly but you were the approver of the commit I propose to revert here)

Oof. OK.  We could add those "deprecated" comments sooner and change the impl later.
/lgtm
/approve


Investigate a pre-release build & infra health check automation/monitor

Typically the week prior to a release it's necessary to check the health of various aspects of the build, infra and test setup. It would be good to maybe have these issues self-heal, or "alert", or some better way to monitor across the many different aspects to a release we have...?

Some pre-release week health checks:

Are there any release version Temurin builds failing? : https://ci.adoptopenjdk.net/view/Failing Temurin jobs/
Are all the Skara mirrors green, check for Skara jobs in : https://ci.adoptopenjdk.net/view/Failing Temurin jobs/
Run a fresh SXA-processCheck run: https://ci.adoptopenjdk.net/job/SXA-processCheck/
Are all the nodes "up" that should be? Check : https://ci.adoptopenjdk.net/computer/
Q: How do you know what should be up?
Are there any nodes short on storage? Check "Free disk space" in : https://ci.adoptopenjdk.net/computer/

@andrew-m-leonard  Have we looked at using something like grafana to provide a summary dashboard for all of these elements, with a view/board geared towards release/prep health ?, its quite capable of monitoring pipeline & node statuses, and could take data from nagios (or similar) for things like disk space warnings etc?

@steelhead31 not recently, but that has been suggested before, i've used Grafana on previous projects, and as you say it's great at integrating status in pre-canned interfaces. So i'd definitely sponsor that idea..

I'm currently running through this:
3. Run a fresh SXA-processCheck run: https://ci.adoptopenjdk.net/job/SXA-processCheck/
Check Amber nodes for hung processes, and clean them up..

Some notes, before implementing a 'solution', would be good to:

outline the requirements clearly

uncouple 'what we need to do' from 'how we are going to implement it'

identify current ways things are monitored (to consider if they can/should be removed to reduce tech debt of owning a set of discombobulated tools/approaches)

identify areas that are higher priority (as in continually problematic)

create a design including expected workflow and listing expected data sources

Ask some additional questions:

from https://github.com/adoptium/temurin-build/issues/2901#issuecomment-1099424854 is it a complete list? example additions to the build status report to also monitor whether a nightly build is days old...)
is the SXA-processCheck run regularly, if not, should it be (as it appears to be a required step to keep machines healthy)
rather than spend too many dev cycles building tools to monitor as things deteriorate, is there a proactive approach to maintaining health of systems (for machines, is there a plan that they be 'refreshed' on a schedule rather than just when they are terribly sick? etc)?

are the tools being discussed for a 'solution' the right set to use, are there others that are better choices?

We have nagios.adoptopenjdk.net (nagios.adoptium.net?) and status.adoptium.net as potential portals.

I think one crucial aspect is "ownership", we can create great dashboards, but if they are not looked after, or monitored, then they won't be the benefit we need

Some notes on what I used in the past for monitoring:

sensu v1/v2: (based on https://sensu.io/)
grafana: can have different source (promethus, postgres etc)
promethus: mostly for container, but can use jenkins plugin to scrape certain data , work with grafana
ELK(mainly kibana): works with elasticsearhc as front-end
dashing(base on http://dashing.io/): write ruby script to handle different customized requirements

and I think from issue description, two parts mainly to start with:
Jenkins:

jenkins job status:  successful, unstable, failed, etc
jenkins agent status: if node offline, cannot re-connect, time drift, low disk space etc
jenkins job trend:  if job failed on certain nodes , if job takes abnormal longer time, etc

underlying infra:

network/connection etc
storage, mem/cpu usage on jenkins controller , jenkins agent(VM based) and container host etc
other dependencies: github outage, CDN down, DNS etc

If would be good to start with

what we already have and are in use,
what we have but out of data/no maintenance
what is the most important requirements to ease our daily workload and release windows


Add side-car container to kube-proxy to remove incorrect conntrack table entries

How to categorize this PR?

/area networking
/kind enhancement
/priority normal
What this PR does / why we need it:
We observed that from the shoot cluster the kubernetes api-server was sometimes unavailable.
This PR mitigates the issue by deleting the incorrect conntrack table entries, that might appear after restarting the kube-proxy. These incorrect conntrack table entries prevented the establishment of a tcp connection to the api-server.
After deploying this PR the ApiServerUnreachableViaKubernetesService alerts are expected to disappear.
Release note:

A side-car container is added to `kube-proxy` that deletes the incorrect conntrack table entries which sometime occur after restart of `kube-proxy` and prevent the establishment of a tcp connection to the `api-server`.

/assign

/assign

Looks good and works well locally. Just to confirm: The script is supposed to only cleanup conntrack entries 2 minutes after start-up but not during the lifetime of the kube-proxy itself, right?

Yes, it should only clean it up once after the restart of kube-proxy.

Looks good and works well locally. Just to confirm: The script is supposed to only cleanup conntrack entries 2 minutes after start-up but not during the lifetime of the kube-proxy itself, right?

Yes, it should only clean it up once after the restart of kube-proxy.

This PR mitigates the issue by deleting the incorrect conntrack table entries, that might appear after restarting the kube-proxy. These incorrect conntrack table entries prevented the establishment of a tcp connection to the api-server.

Is it an upstream bug in kube-proxy? If yes, can you please link correspong issues.

This PR mitigates the issue by deleting the incorrect conntrack table entries, that might appear after restarting the kube-proxy. These incorrect conntrack table entries prevented the establishment of a tcp connection to the api-server.

Is it an upstream bug in kube-proxy? If yes, can you please link correspong issues.

@ialidzhikov I guess there is no issue yet, @DockToFuture and colleagues, please cross-post the issue here after you have opened it in k/k.

@ialidzhikov I guess there is no issue yet, @DockToFuture and colleagues, please cross-post the issue here after you have opened it in k/k.

This PR mitigates the issue by deleting the incorrect conntrack table entries, that might appear after restarting the kube-proxy. These incorrect conntrack table entries prevented the establishment of a tcp connection to the api-server.

Is it an upstream bug in kube-proxy? If yes, can you please link corresponding issues.

Yes we think it is an upstream bug but we will first try to find an easier way to make it reproducible and then create the corresponding upstream issue.

This PR mitigates the issue by deleting the incorrect conntrack table entries, that might appear after restarting the kube-proxy. These incorrect conntrack table entries prevented the establishment of a tcp connection to the api-server.

Is it an upstream bug in kube-proxy? If yes, can you please link corresponding issues.

Yes we think it is an upstream bug but we will first try to find an easier way to make it reproducible and then create the corresponding upstream issue.

This PR mitigates the issue by deleting the incorrect conntrack table entries, that might appear after restarting the kube-proxy. These incorrect conntrack table entries prevented the establishment of a tcp connection to the api-server.

Is it an upstream bug in kube-proxy? If yes, can you please link corresponding issues.

Yes we think it is an upstream bug but we will first try to find an easier way to make it reproducible and then create the corresponding upstream issue.

Ok, I am looking forward to it.

This PR mitigates the issue by deleting the incorrect conntrack table entries, that might appear after restarting the kube-proxy. These incorrect conntrack table entries prevented the establishment of a tcp connection to the api-server.

Is it an upstream bug in kube-proxy? If yes, can you please link corresponding issues.

Yes we think it is an upstream bug but we will first try to find an easier way to make it reproducible and then create the corresponding upstream issue.

Ok, I am looking forward to it.

Cherry-picked into release-v1.15 with 243cfebaa3a1d9edbb4e46349639dfdfb776f15f.

Cherry-picked into release-v1.15 with 243cfebaa3a1d9edbb4e46349639dfdfb776f15f.

This PR mitigates the issue by deleting the incorrect conntrack table entries, that might appear after restarting the kube-proxy. These incorrect conntrack table entries prevented the establishment of a tcp connection to the api-server.

Is it an upstream bug in kube-proxy? If yes, can you please link corresponding issues.

Yes we think it is an upstream bug but we will first try to find an easier way to make it reproducible and then create the corresponding upstream issue.

Ok, I am looking forward to it.

ping @DockToFuture . I am still looking forward to it.

This PR mitigates the issue by deleting the incorrect conntrack table entries, that might appear after restarting the kube-proxy. These incorrect conntrack table entries prevented the establishment of a tcp connection to the api-server.

Is it an upstream bug in kube-proxy? If yes, can you please link corresponding issues.

Yes we think it is an upstream bug but we will first try to find an easier way to make it reproducible and then create the corresponding upstream issue.

Ok, I am looking forward to it.

ping @DockToFuture . I am still looking forward to it.

Progress is tracked in gardener-monitoring slack channel.

Progress is tracked in gardener-monitoring slack channel.


Added distorted text animation

Fixes Issue🛠

Closes #29
Description👨💻

Added a distorted text animation under the text animations component
Type of change📄

[x] New feature (non-breaking change which adds functionality)

How this has been tested✅

Run the index.html file
Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷

Pls provide the screenshots of your work @saurav2208

Nice, Merged!! Congrats on getting your PR merged to this repo under SWOC S4 🥳🎉 @saurav2208


Create new wizard to generate ml-models

[ ] Remove old models-page
[ ] Add button on validation-page to create new model
[ ] Implement the wizzard (Select labelings, Select Datasts and Sensor-streams, select Validation and Test, select classifier and hyperparamters) => Train
[ ] Show models under training directly in the table on the validation page.
[ ] Show error message which has to be quit by the user when a training-error occurs.

The flow when using the wizzard / ml-part should look like this:

User clicks "create new" button on Validation-page
Wizzard appears and guides user through the model generation process
When the user clicks "Train" in the wizzard, add the model to the table in the validation view. The table entry should indicate the current state of training or and error if one has occured.
When training is complete, show the model in the table as it is now.


feat(): selected tab text color

added ability to specify selected tab text color for BottomTabItem.
Closes #71

Useful, waiting mr


MouseOverTextEvent over specific word of text

Hi,
Was trying to capture events when the mouse is over certain words of text.  Currently looks like there is a MouseOverTextEvent, which captures the begin and end of when mouse enters a StyledTextAreaView.  Is there anyway to capture when the mouse moves over different words within a StyledTextAreaView?
Was looking at end of StyledTextAreaView::mouseOverTextEvents(), would the implementation be similar to this method?  Wanted to avoid using addEventHandler(MouseEvent.MOUSE_MOVED, e-> {}) b/c MouseOverTextEvent has the nice mouseOverTextDelay funtionality, so this looks more logical location.
Thanks!

Hi,
can't you recover the word from MouseOverTextEvent#getCharacterIndex()?

Ah yes, you're right, I can use this.  Was looking for a row+col pair instead of a character index, but I can translate on my own side.
Thx, will close this.

:+1:
FWIW, I do think we should expose more row+col based API.

How do you want to expose?
Maybe add to javadoc as an example?  Or could add a cover method (e.g. StyledTextArea::getRowCol(int charIndex) ) that simply does this, so users do not have to think about Bias.Forward, and Position.Major, Position.Minor?

...add a cover method (e.g. StyledTextArea::getRowCol(int charIndex) ) that simply does this, so users do not have to think about Bias.Forward, and Position.Major, Position.Minor?

I like that idea because the naming itself is a steeper learning curve than it needs to be.

I meant to have versions of methods that take row & column (or Position), instead of an absolute index. In many cases this would even be more efficient.


zig 0.13 compatibility

The build.zig is not compatible with zig 0.13
I had a quick look, it's mostly converting lazy paths from .{ .path = ex_info[1] } into b.path(ex_info[1]).
But the tricky bit will be updating zmath.

Hi, thanks for the PR. I've added a tag that should work with 0.13.0, the main branch will now target zig master. This should resolve your issue.


Update samples to be more self-contained

Issue type
Wrong or misleading information
Problem description
Samples may not be self-contained when a user downloads and attempts to run them.
For example:

The linked sample configures Java toolchains for Java 8. But it does not configure an auto-provisioning plugin. Also, using Java 8 is a challenge for provisioning (auto or not) on some OS/architecture combinations.

Gradle should only offer samples that are self-contained as much as possible.
Context (optional)
No response
Page with the problem
https://docs.gradle.org/current/samples/sample_structuring_software_projects.html

hi @ljacomet if this issue's still open, I would love to take this up!


More aggresively hide the ObjectiveTrackerFrame

now blizzard can :Show/:Hide the objective tracker as much as they like. once it's hidden, it stays hidden until you decide it should no longer be hidden

parents persist until /reload or changed through SetParent (which blizzard almost never does for any frame), so yeah, this approach is perfect when trying to hide blizzard frames 🙂
I haven't really dug into the rest of the addon's code, so it might be simpler to make required adjustments yourself, but I can try clean things up a bit more when I get time later 🙂

Alright, done. Let's get this tested and merged!

I'll play a few keys with it tonight (EU) and let you know 👍

Same here I will do some keys tonight and let you know.  I grabbed that CPU ad on you mentioned so I will try to monitor that as well, but so far I have not had a single issue in keys so fingers crossed.

Same here I will do some keys tonight and let you know.  I grabbed that CPU addon you mentioned so I will try to monitor that as well, but so far I have not had a single issue in keys so fingers crossed.

For this branch, you won't have to monitor the CPU at all, since this is an actual fix and not just a hack.

worked fine for my keys 👍

Sounds good, I'll merge this tomorrow then.

For what it's worth, tried all the usual suspects and so far working fine here too :)


Apple M1 tracking issue

We can't compile for Apple M1 in CI currently because some packages break even when we try to cross-compile.
Will try to gather relevant issues here for tracking

https://github.com/rust-bitcoin/rust-secp256k1/issues/283
https://github.com/rust-lang/rust/issues/73908

I am not sure if we are able to, but adding this to cargo config has fixed issues in the past for M1 stuff. May be worth a shot trying
[target.x86_64-apple-darwin]
rustflags = [
  "-C", "link-arg=-undefined",
  "-C", "link-arg=dynamic_lookup",
]

[target.aarch64-apple-darwin]
rustflags = [
  "-C", "link-arg=-undefined",
  "-C", "link-arg=dynamic_lookup",
]

ref: https://stackoverflow.com/questions/28124221/error-linking-with-cc-failed-exit-code-1

better solution: remove the need of secp256k1 crate all together by refactoring this: https://github.com/bluealloy/revm/blob/main/crates/revm_precompiles/src/secp256k1.rs


Initiate Program Execution

Write command { macro(i.e. !) has to be a part of that command } to begin program execution in ../src/lib.rs , which calls the necessary function to process the program instructions , as we do not have a main function here .

claim

claim

@SanyamAgrawal07  Reminder - 3 hours left for you to complete this issue.


Exists function

This snippet triggers the following error:
Uncaught TypeError: Object # has no method 'exists'
Lawnchair(function() {

    this.save({key:'1',title:'jewels'});

    this.exists('1', function(exists){
        console.log(exists + ' exists')
    });

});

+1
It seems that the exists function is implemented only for the window-name adapter.


[Thirdparty] Upgrade apache arrow from 0.15.1 to 5.0.0

Reading parquet file with many columns is much slower in 0.15.1.
https://issues.apache.org/jira/browse/ARROW-7059
Upgrade to 5.0.0, broker load with single be and single replica
can be increased by 3 times.

Add some performance benchmark in commit message

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[BEAM-13293] Refactor JDBC IO Go Wrapper

Update JDBC IO wrapper to have expansion service as an optional argument. Small refactoring and documentation.
Tests are filtered out because of BEAM-13778. It will added once we resolve this.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lostluck @youngoli


Ruby needs a {{pagination}} element to service non-scrolling crawlers

Ruby is missing a {{pagination}} element from the index page.  The result is that Google Bot (which does not scroll) never reaches later posts.
No impact on human visitors (due to infinite scroll), but the inability of the GoogleBot to reach /page/2 of content has SEO implications.

Hey @cathysarisky, a good point. Just curious if that really helps SEO though 🤔. There's also a link element in the header that links to the next page <link rel="next" href="https://ruby.ghost.io/page/2/"> which should be more logical place for crawlers to look for the next page which is also mentioned here.

I've confirmed that my version of Ruby does have that <link> element, and I agree that it's supposed to help crawlers find the second page.  But I can also tell you that I didn't see my page/2/ or page/3/ urls show up in GSC until I added the actual <a> links to the page.  And until I did so, these pages said they had zero pages linking to them, so even if the crawler can find them, it may not be propagating page rank through <link elements?
And then I googled it, and there ya go:  Google doesn't use rel=next/prev at all.


Live share not working - no reason why given

Describe what happened:
When I select the share read/write option after I've installed the live share extension pack, nothing happens. In the bottom left I would temporarily see "activating extensions". But that stops running. I don't get a link to share with my contacts, nothing. Funny thing is, this was just working 10 days ago because I just used it recently.
What was your system configuration?
Version: 1.49.1
Commit: 58bb7b2331731bf72587010e943852e13e6fd3cf
Date: 2020-09-16T23:21:17.533Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0
Target Platform or Language:[Node.js]
Live Share Extension Pack Version: 0.4.0
Steps to Reproduce / Scenario:

Go to "live share extension menu button on left"
Click on "share read/write or share read-only, or join... anyone of them"
Nothing to scroll down to. Nothing happens

Please attach logs to this issue:
You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue
liveshareLogs.zip
Screenshots
If applicable, add screenshots to help explain your problem.

Thanks for reporting this issue. Unfortunately there is not enough information in the attached logs to investigate this issue. The logs look completely normal in fact. One thing to try is to uninstall Live Share extension pack and install only Live Share from VSCode markeplace. If the issue still repros, set "Live Share: Diagnostic Logging" to true, reproduce the issue, export and share the logs again.

I'm having the same issue - clicking the buttons results in absolutely nothing happening. Interestingly, when I attempt to run the commands from the command palette, I do receive an error:
Details:

OS is Windows 10
VS Code is fully up to date
Re-installing the extension did not help
The Extension Pack version did not help
Repair installation command did not help

I also don't see the "Live Share" icon in the lower left, so that might be related.
Maybe this additional info is helpful @IlyaBiryukov

Having commands, buttons and viewlet visible means that VSCode integrated the extension. Nothing happening when you click on the buttons / execute the commands means that the extension didn't register handlers for them. Something must be happening on extension activation that Live Share doesn't log.
Can you please check developer tools console in VSCode? See if there any errors related to Live Share there.
You can open it with Help -> Toggle Developer Tools, then select "Console" tab.

When I opened my dev tools in VS code after trying to start a Live Share, I got an error. I've attached it here.

Also, after having uninstalled the Extension Pack and only installing Live Share, still nothing. The log is here:
liveShareLogs.zip
As well, here is a screenshot of my console:

It seems to be the Live Share welcome page misbehaving. @aletsdelarosa can you please take a look?

@aletsdelarosa , here is the bug to track this issue
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1219457
Given that it worked before and just stopped working recently, it may be a regression in 1.0.2740 LS release.

Hello!
@dandra-mo or @blewisio Can you try it with the new release? Version 1.0.2902 released today. I just tried it and I couldn't repro.

@aletsdelarosa, I just tried with 1.0.2902 and I'm still seeing it - (command 'liveshare.start' not found).

@aletsdelarosa  could you please provide any update you have here?

After updating to VS Code v1.50.0, Live Share seems to be magically working for me now.

@aletsdelarosa could you please provide any update you have here?

I couldn't repro and it looks like it fails in different commands, not just with the Welcome Page.
@dandra-mo could you check if it's fixed for you in Version 1.50.0?

Yes, I will check this as well. I have been traveling, give me til tomorrow
and I'm going to check it out and hopefully it's working
On Tue, Oct 13, 2020, 17:08 Alex de la Rosa<EMAIL_ADDRESS>wrote:

@aletsdelarosa https://github.com/aletsdelarosa could you please
provide any update you have here?
I couldn't repro and it looks like it fails in different commands, not
just with the Welcome Page.
@dandra-mo https://github.com/dandra-mo could you check if it's fixed
for you in Version 1.50.0?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/live-share/issues/3875#issuecomment-708009775,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOCLY6K5CAVQT26R2KN3I3SKS6TNANCNFSM4RTGYX5Q
.

Ok, so I've updated to 1.50.0 and live share seems to be working just fine now. I can see my contacts, It gives me a link I can copy, I've signed it with Github (all of which it never asked me/allowed me to do before). Later today or tomorrow when I have a collab session and actually use Live share, I can give more feedback that it actually works. Thank you for your follow up! Ill do the same and follow up when I use it.

This is still an issue as of 1.50.1 on Windows 10 and macOS.

Still an issue as of VSCode 1.51.1 and LiveShare 1.0.3206 on Windows 10.

This is still an issue as of VSCode 1.52.1 and a fresh install of LiveShare 1.0.3449 on Pop OS

This is still an issue as of VSCode 1.52.1 and a fresh install of LiveShare 1.0.3449 on Pop OS

On command palette, try "live share: repair".

This is still an issue in VSCode 1.64.2
You click on Share or Join and nothing happens. tried also live share: repair command, it restarts vscode and nothing is changed and still not working.

if live share: repair doesn't work, the ultimate solution is to make sure your VSCode is up to date (Code > Check for Updates).
And if you have an error doing this, this mean your VSCode is still in your Download folder and you should move it Download > ApplicationsDownload > Applications

Also still an issue on MacBook Pro with M1 chip. Here's the result of using "liveshare: repair" in the Command Palette and then pressing Join.

Visual Studio Code version information (Latest version according to Check for Updates):
Version: 1.66.2
Commit: dfd34e8260c270da74b5c2d86d61aee4b6d56977
Date: 2022-04-11T07:47:29.396Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.4.0
Live Share version 1.0.5527 (Only base extension, not the Extension Pack, and no Audio extension)

Had the same problem. I managed to get it working after installing Rosetta on my M1Pro Macbook.
softwareupdate --install-rosetta

Thanks @julianhandl, this worked perfectly after trying many other things that didn't.

VS code live share is totally broken ever since Microsoft bought Github....  so sad.  This has always worked great but last few years it's totally broken, especially the webview..


Set lookup field using ID of the record being looked up

Is your feature request related to a problem? Please describe.
We have times where we want to search for a record as an appicable parent then set the lookup on thebcurrent recore. We use FetchXML to find the ID of the parent (using concatenate from query), and would like a way to then set the lookup field on the current record to point to the parent that has previously been found
Describe the solution you'd like
A feature to set a lookup field on the record on which the workflow is being run providing the parameters of:

Field name of the lookup field
GUID (as string) or Record URL of the parent to which the lookup should be set.

Describe alternatives you've considered
Other workflow tools solution which requires multiple steps to achieve and is a bit clumsy,

Thanks Stevenfayers,
the problem here is a limitation with Workflows, where we cannot set dynamic type value on lookups.
Maybe we can achieve this with Actions, but not with standard features.
The output paramenters type of the Custom activities cannot be "dynamic"
thanks


Hello from Sydney

@sydneylines
I will add a link to the repo for my archive project when its up rather than my demo repo!

Live site: https://sydneylines.github.io/LGSA/


ext: stm32cube: stm32f4xx: shift I2SR field in PLLI2SCFGR register

The I2SR field should be shifted by RCC_PLLI2SCFGR_PLLI2SR_Pos when the
PLLI2SCFGR register is read or written. Without this patch the PLLI2S
configuration is not done properly (R and M params are badly set) and
the PLLI2S generates bad clock waveform.
Signed-off-by: Armando Visconti<EMAIL_ADDRESS>

@erwango
Please note that for the moment in README file I put:
ST Bug tracker ID: TO BE ASSIGNED
It would be nice if we could get a number before the end of the week.

@erwango
I think that also stm32f7xx has same bug

Codecov Report

Merging #8762 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8762   +/-   ##
=======================================
  Coverage   52.36%   52.36%
=======================================
  Files         195      195
  Lines       24713    24713
  Branches     5136     5136
=======================================
  Hits        12940    12940
  Misses       9699     9699
  Partials     2074     2074

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0d089...b8fd3fc. Read the comment docs.

@avisconti , could you create the same patch in this PR for F7 series as well?
Bug tracker : 50108
Thanks!


TLS option?

Wondering if there is any appetite for TLS support on the cache? I have worked around this myself using a load balancer for my use case, but since net/http is already in there, I did a quick test of just having it as a boolean config (with a static path) and using the built in listen with TLS, see here:
https://github.com/comerford/lfscache/blob/master/main.go#L61
Basic test worked, would just need some sane way to specify the cert paths in the options rather than static config, but will leave that to someone with more actual Go experience.
P.S. Super useful little program - thanks!

@comerford v0.1.3 now contains a -https-addr, -tls-cert and -tls-key option to configure HTTPS.
Let me know if you experience any trouble with it, and thank you for the feature request!


Add ability to add Keycloak specific ingress annotations

With this it's possible to set arbitrary annotations on the ingress objects for Keycloak.
Checklist

[x] The PR has a meaningful title. It will be used to auto generate the
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
[x] PR contains a single logical change (to build a better changelog).
[x] Categorize the PR by adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.
[x] Link this PR to related issues or PRs.

this one is just a formality - LGTMT

You did notice the changes in the e2e tests... right?


⚠ RPC server - Figment Solana has degraded performance

In a87986f, RPC server - Figment Solana ($FIGMENT_SOLANA_RPC_URL) experienced degraded performance:

HTTP code: 429
Response time: 321 ms

Resolved: RPC server - Figment Solana performance has improved in 11d4338.


How to set anchor_sizes, MAX_SIZE_TRAIN etc

❓ Questions and Help
@fmassa Hi, can you explain how to set these parameters: MIN_SIZE_TRAIN, MAX_SIZE_TRAIN, ANCHOR_SIZES, ASPECT_RATIOS etc
I understand that these parameter settings are related to gpu memory and training data.
I want to ask if these parameters can be set to arbitrary values, not necessarily multiples of 32.

default value of MAX_SIZE_TRAIN and MAX_SIZE_TEST are both 1333, and I think they are just the upper bound sizes of the side of images during train and test, not necessarily to be multiples of 32. As for ANCHOR related paramters, I'm not sure.

@xiaozhuka The default ANCHOR settings are in the maskrcnn_benchmark/config/defaults.py.

@xiaozhuka You also can set it in the config file xxx.yaml  MODEL.RPN.ASPECT_RATIOS.

how to modify  these parameters MIN_SIZE_TRAIN, MAX_SIZE_TRAIN, if my custom imgs shape larger than 1333*800?

@tangze5258 you can modify them in your .yaml file this for example  according to the real ranges of you figures. All the available parameters can be found at defaults.py

@dc-chengchao @tangze5258
Thank you for your reply. I know where the default parameters are, and I know that they can be set in yaml. What I want to ask is whether these parameters must be set in multiples of 32 or Or what are the limitations?
I trained with my own data, and all the other parameters only changed anchor-related parameters (anchor_sizes, apect_ratios, anchor_strides), using the default parameters to get AP = 66.93, but using the model AP = 59.32 based on the parameters selected from the training data.
Default parameter: IOU = 0.63
ANCHOR_SIZES: (32, 64, 128, 256, 512)
ANCHOR_STRIDE: (4, 8, 16, 32, 64)
ASPECT_RATIOS: (0.5, 1.0, 2.0)
Modified parameter: IOU = 0.63
ANCHOR_SIZES: (29, 52, 124, 221, 359)
ANCHOR_STRIDE: (3, 6, 15, 27, 44)
ASPECT_RATIOS: (0.4, 0.98, 2.16)

I have new experiment result with anchor is set multiples of 32
ANCHOR_SIZES: (32, 64, 128, 224, 384)
ANCHOR_STRIDE: (4, 8, 16, 28, 48)
ASPECT_RATIOS: (0.4, 0.9, 2.11)
average iou=0.64, mAP=67.5%

@dc-chengchao @tangze5258
Thank you for your reply. I know where the default parameters are, and I know that they can be set in yaml. What I want to ask is whether these parameters must be set in multiples of 32 or Or what are the limitations?
I trained with my own data and kept the other parameters unchanged.Modify anchor-related parameters (anchor_sizes, apect_ratios, anchor_strides) only. Use default parameters to get ap=66.93, but use modified patameters selected from training data ap=59.32.
Default parameter: average IOU = 0.63
ANCHOR_SIZES: (32, 64, 128, 256, 512)
ANCHOR_STRIDE: (4, 8, 16, 32, 64)
ASPECT_RATIOS: (0.5, 1.0, 2.0)

Modified parameter: average IOU = 0.63
ANCHOR_SIZES: (29, 52, 124, 221, 359)
ANCHOR_STRIDE: (3, 6, 15, 27, 44)
ASPECT_RATIOS: (0.4, 0.98, 2.16)

Please note that the anchor_stride cannot be set arbitrarily. You can only use the default settings. Otherwise, the generated anchors may not cover the whole image.


Change the category of the wazuh-security-dashboards-plugin

Describe the enhancement
We want to rename the app category that is registered and displayed in the UI, the security application.
Proposed solution: remove the branding name.

Out of scope


Reduce GraphQLJava induced log noise

What this PR does:
Upgrades version of graphql-java used and then uses new 18.x mechanism to override logging to reduce noise that currently clogs logs on cases where code handles exceptions already.
There is some positive impact for our CI/IT logs (gets rid of 73 non-error cases that look like errors), but more importantly should reduce production log noise.
Graphql-java fix itself here:
https://github.com/graphql-java/graphql-java/pull/2569
Which issue(s) this PR fixes:
Fixes #1279
Checklist

[x] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

Note: only version upgrade first, to verify new version of graphql-java works as-is (... or not).
And once it does, then add logging method override.

Interesting. With changes applied in 2 places, number of logged warnings fell from 73 to 21 (i.e. most gone) but not to 0 as I had expected. Looks like there is yet another path through which CassandraFetcherExceptionHandler is not configured with GraphQL.builder().defaultDataFetcherExceptionHandler(...).

Ok now the noise is gone, ready for merge.

@olim7t If you have a chance to have a look that'd be great: redundant logging is gone as per CI/IT output, and changes required by grapql-java seem straight-forward but since you know this codebase it'd be good to have another look.


ver 0.8.1 - output window doesn't sroll

Simply put the output window doesn't scroll or have a scroll bar when it goes below the bottom of the box. So can't keep track of where its up to.
No other versions have been installed at any time on the machine that this screenshot was generated on. Windows 11.

Hi @Meisner57 ,
This should be resolved from version 0.9.0, you can test latest v0.10.0


Keeps asking to refresh credentials

Issue Type: Bug

Click on Connections icon in left side menu
Under Azure, click Sign in to Azure...
In the Linked Accounts popup, click Add an account
Click Copy & Open
Complete sign in. The Account is now listed correctly.
Click Close to close the Linked Accounts popup/window
In the connections pane, under Azure, click > to expand resources.

Actual result:
The Linked Accounts window opens, with the message "You need to refresh the credentials for this account".
I looked in the logs, and found this in 5-Deployments.log that might be relevant:
> docker version --format "{{json .}}"
> az --version
> azdata -v
> kubectl version -o json --client
stderr: /bin/sh: 1: docker: not found
stderr:
stderr: /bin/sh: 1: az: not found
stderr:
stderr: /bin/sh: 1: azdata: not found
stderr:
stderr: /bin/sh: 1: kubectl: not found
stderr:
>>> docker version --format "{{json .}}"    … exited with code: 127
>>> docker version --format "{{json .}}"   … errored out: Process exited with code 127	>>> Ignoring error in execution and continuing tool deployment    >>> az --version    … exited with code: 127
>>> az --version   … errored out: Process exited with code 127	>>> Ignoring error in execution and continuing tool deployment    >>> azdata -v    … exited with code: 127
>>> azdata -v   … errored out: Process exited with code 127	>>> Ignoring error in execution and continuing tool deployment    >>> kubectl version -o json --client    … exited with code: 127
>>> kubectl version -o json --client   … errored out: Process exited with code 127	>>> Ignoring error in execution and continuing tool deployment

Azure Data Studio version: azuredatastudio 1.14.1 (f9b968c1ae514a0d1210788629e1c69125857279, 2019-12-24T02:35:43.481Z)
OS version: Linux x64 4.19.60-06185-g54aa50936831

System Info

Item
Value

CPUs
06/8e (4 x 2207)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
4.84GB (0.80GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
100%

Extensions: none

I presume a lot of these issues will be partially solved with MSAL v2.0. In the meantime, you can try deleting the files from %appdata%\azuredatastudio\Azure Accounts\ if you're on a windows system.

This is probably fixed with the latest insiders build. If it's not please comment back and I'll reopen the issue.

@aaomidi I just tried with the insiders build on a Mac and it still did not work. I replied in issue #9885.


Add 'Tracker' track-generation tool

Tracker is a small Python tool for automatically generating a new Rally track from an existing repository
Relates #444

@elasticmachine test this

@elasticmachine run tests

That was quite a review!
The changes (including integration testing) will take more than one shot so I'll come back and ping you when I'm ready for another review.

Sure! Splitting the follow-up work into smaller items totally makes sense. :)

Looks like CI was aborted for Jenkins upgrade.
@elasticmachine run tests

Closing in favor of https://github.com/elastic/rally/pull/970 (which is based on this PR)


Convert readthedocs links for their .org -> .io migration for hosted projects

As per their blog post of the 27th April ‘Securing subdomains’:

Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard.

Test Plan: Manually visited all the links I’ve modified.

The link on the Github repo description also needs updating.

Tho I can merge this, I can't update the repo description? @jezdez would you do it?


Review krill inversion code

Review krill inversion code.
Main goals are to clarify three components:

What input files are required
What are the data pre-processing steps before inversion?
What scattering model(s) need to be implemented
What inversion algorithm(s) does the code use

References here are:

Matlab code for 2020 processing
Basic documentation of processing steps: https://docs.google.com/document/d/10PsW2ZiQvZAQGtDJU-_1xYX6Hh8PC7pW/edit

Inversion algorithm used: Matlab lsqnonlin

What are the data pre-processing before inversion?

Restructure Echoview NASC exports --> save as organized .mat files with names like US-euph-2019 hake survey.mat
Extract relevant data values for inversion

Output data in xlsx: Sv mean, std, median, std of median (med_std), layer depth, layer thickness, effective volume, lat/lon
First round of clean up:for tr in transects:  # loop through all transects (files)
   for f in freq:  # loop through all available frequencies
      if data at f kHz exists:
         # extract relevant data

Remove inconsistent Sv samples at certain frequencies

there are three choices: "Accept", "Automated", and "Manually"
goal is to retain data that is consistent with how krill backscatter should look like

Save outputs as excel files with names like input_para_data_hake2017-US.xlsx

What input files are required

Echoview NASC exports

x10_18_0.5nmi_10m_cells_50to300m.csv (from the fname field in the organized .mat file)
x10_18_10m_cells_50to300m.csv (from the file_ID field in the organized .mat file)
the exports are organized using script Display_Proc_exported_transect_data.m and save to a sheet called ("hake_YEAR")
input_para_data_hake2019-US_bkup.xlsx contains many years of data in different hake_YEAR sheets

central input excel file

with names like input_para_data_hake2017-US.xlsx
initial spreadsheets generated from Echoview NASC exports
manually added (?) spreadsheets for model parameters
not sure where the sheet bio_data come from, but these look like simple numbers to parameterized the scattering model

What scattering model(s) are used

function DWBAbscat1: weakly scattering uniformly bent finite inhomogenous body, with segmented g and h along the body
with orientation average
with length average

See:
https://github.com/uw-echospace/EchoPro_krill_inversion/blob/main/inversion/functions/SVpredictionALL.m#L56
and
https://github.com/uw-echospace/EchoPro_krill_inversion/blob/main/inversion/Scat_models/zoo_bscat.m#L59-L60


switch to using terser plugin instead of uglify

Due to changes in how<EMAIL_ADDRESS>processes dependencies, rollup-plugin-uglify causes the install to fail since it is looking for a peer dependency of rollup@ >=0.66.0 <2.0.0.  See here.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/rollup
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS><2" from<EMAIL_ADDRESS>npm ERR! node_modules/rollup-plugin-uglify
npm ERR!   dev<EMAIL_ADDRESS>from the root project

In addition, rollup-plugin-terser and terser as a whole are the recommended follow-ons for uglify and can natively handle es6 modules.

Thanks for the pull request @TJKoury!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Thanks again for your contribution @TJKoury!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks @TJKoury!  We might not get this in right away since NPM LTS is still 6.x, but thanks for bringing this to our attention

No problem, let me know if you need any help when the time comes.

Thanks again for your contribution @TJKoury!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @TJKoury!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @TJKoury!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @TJKoury!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @TJKoury!
No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@TJKoury could you fix the merge conflicts and change the version number in package.json to ^7.0.2?
As @mramato noted in https://github.com/CesiumGS/cesium/issues/9129 this does increase the Build/Cesium/Cesium.js size. I'm seeing 3.68MB to 3.72MB.

We should probably replace use of gulp-uglify as well so everything is going through terser.

@lilleyse @mramato You can close this and figure out how you want to implement it based on wanting to replace gulp-uglify as well.  Ping me if you want my input.


Reducing information for look

After running all checks once of twice it is good to see the whole statistics for the file. But dealing with dozens of project it would be better to focus on problems. So it would be nice to:

Collapse all checks. The "Close all checks" button can be renamed to "Expand (or Unfold) all results".
Grey out the checks which have 0 problems.

@EK-CEL
Spider gbXML Fixer 'Atrax' R0.4.13

'Run all checks' button finishes with all checks closed
'Open all non zero' displays all checks where issues have been identified
Numbers of issues found are highlighted

Thank you for having a look - and for making useful and actionable suggestions.
Have any of the checks actually found issues for you? And were the fixes useful.

Thank you for the update. The screen looks cleaner now. :)
Is it possible not highlighting zeros?
For our further calculations we have a software which is not sensible for issues. We are interesting in fixing building envelope only. We understand that it is too minimalistic, but absolutely necessary. Please don't use our approach as a typical workflow.

@EK-CEL
Spider gbXML Fixer 'Atrax' R0.4.14

not highlighting zeros?

Done

We are interesting in fixing building envelope only.
We understand that it is too minimalistic, but absolutely necessary.
Please don't consider our approach as a typical workflow.

I understand. A lot of the effort in Atrax is driven by @mdengusiak's needs (and hopefully the needs of others.)
Much of the initial effort on Fixer seems to be getting to be complete. This means that I can get back to Maevia where we can look at issues that need full 3D such as what is exterior or interior and the directions of normals and so on - which I hope will be of use to your office.


Resolve Klocwork issues found in 6.5.0

See attachment

Imported from trac issue 301.  Created by jhageman on 2019-06-03T13:28:35, last modified: 2019-06-26T15:37:30

Trac comment by jphickey on 2019-06-25 14:18:34:
These were found in an old version and don't necessarily correlate to the current version.  Some/most may have been addressed already.
Is there a plan to run this tool against the current development branch?  Or at least CFE 6.6.0 now that it is on github?

Trac comment by jhageman on 2019-06-26 15:37:30:
Gateway is coordinating with IV&V for a static code analysis run.  I'm going to encourage running against the end-of-summer release, and cleanup could happen for 7.0 (if resources are available).

IV&V reran static analysis and the only critical fixes are covered by existing tickets.  Closing this ticket as OBE.  New ticket will be opened for any issues identified in the current code base.


Feat/yoink gh pages workflow

Yoinked!!
Description
Setting up (yoinking) a rust doc workflow and publishing it to gh pages.
Note: need to set up github pages with the main as the branch and docs as the root.
Closes #232

Also, if you want to do another PR, feel free to create one which implements https://github.com/rust-lang/mdBook, shown here.

If you want to do another PR, feel free to create one which implements https://github.com/rust-lang/mdBook with a workflow, shown here.
Or if you'd like to do it now and this PR, feel free to do that as well.

We want both rustdoc + mdbook? or discard this rustdoc?

Since I am a dingus, I realized that rustdoc wouldn't be that helpful in developing this application.
Also in the start of this I did think that rustdoc was mdbook. I didn't know either existed until a short while ago, somehow.

Since I am a dingus, I realized that rustdoc wouldn't be that helpful in developing this application.
Also in the start of this I did think that rustdoc was mdbook. I didn't know either existed until a short while ago, somehow.
So we should probably discard rustdoc and go for mdbook, since that's the type of documentation I was going for in the first place.
I'm sorry for going back and forth with this, it's kind of ridiculous.

No worries, done, also put some place holder docs for the moment.

And just like that, it works!

Hahah such magic!


Enhance etpro scripting

This pr should add proper support for etpro scripting commands:

revamped create command and extended supported spawnvars

cleaned up fakebrush

[x] Add delete scripting command, to delete entities based on spawnvars (port from ETLegacy)

These are good changes that should be done, however can't fix the merge conflicts so need to re-do this.


Assert Resource List URL exists

Hello i'm getting this error when i try to connect to the citrix server:
Assertion error:false
Assertion failure:true
Assertion failure message:Could not find the Resources list
The server response is:
Response.txt
It's Gateway NS14.1 Build 25.56
Can you please help me with this?

Hi @KorbiZac
Currently the template provides basic support for the versions of StoreFront that we know and some support for other Citrix Gateway variants, but there is no support for NetScaler and its variants.
Citrix has not followed a standard in its authentication flows nor has it been consistent between versions, so we leave it to those who wish to use an unsupported version of NetScaler to adapt the http flow to achieve the flow that NetScaler requires to reach the ICA file.
In order to achieve the objective of adapting the current http fragment to NetScaler support, you must first record a login flow in JMeter, understand what data you must correlate in the requests and see what things need to be adapted from the current flow.
Sometimes it is an extra request, or header, an extra field that is needed.
Users may have a NetScaler with an adapted login that requires extra fields to be resolved, or have an authentication method that prevents it from being automated (use of hardware token or two-step authentication with smartphones and similar). This can also happen with Storefront, and it is something that is impossible to support all the particular adaptations made by those who adapted the default authentication to a particular one of the institution.
There are also security controls at the NetScaler level that make it difficult to perform load tests on it.
If the intention is to test the infrastructure from the Storefront to the VDA servers, the recommendation is to try to perform the load tests within the network of the internal infrastructure by connecting directly to the Storefront and not using the public access of NetScaler.
If you manage to automate the login and download of the ica file with http recording in JMeter without http errors, then it is a matter of migrating those requests to the fragment that is used in the Citrix plugin template to "make the hook" and with that be able to raise the recorder or automate with the Citrix plugin.
In the documentation we mentioned something about what is generally required to achieve, which is the correlation of the token and incorporating the ica downloader, something that is also recommended is the use of the variables that are currently used related to the user identification, so that it can later be compatible (that the user and password sent to the fragment are incorporated in the appropriate places of the requests).
https://github.com/Blazemeter/CitrixPlugin/blob/master/MANUAL.md#recording-custom-test-fragment-for-download-ica


:green_heart: add eslint in ci

resolve #329

The next build command already includes the eslint process. Is it necessary to add this step a second time ?
Otherwise, this PR is welcome to fix some eslint errors

This make sure that when you push code, it's clean. I think this is good for the quality code
And it takes few seconds

The next build command already includes the eslint process. Is it necessary to add this step a second time ?
Otherwise, this PR is welcome to fix some eslint errors

We had the basic eslint, I've added also some rules. And the eslint tests weren't on ci jobs. I don't think that eslint was enclenched at each push

The next build command already includes the eslint process. Is it necessary to add this step a second time ?
Otherwise, this PR is welcome to fix some eslint errors

We had the basic eslint, I've added also some rules. And the eslint tests weren't on ci jobs. I don't think that eslint was enclenched at each push

This make sure that when you push code, it's clean. I think this is good for the quality code And it takes few seconds

I agree with adding some rules 👍🏻
I mean, is it not a duplicate to add a eslint step in job as it is already running in another step (see https://app.circleci.com/pipelines/github/Zenika/skillZ/956/workflows/815b382d-6e7a-43b0-a7c3-a27a16637fc4/jobs/4817?invite=true#step-107-213) ?

Indeed ! I didn't noticed that runs in next build. it looks like it don't take in account the new rules with this way. Maybe should we delete the eslint step from build ? And keep the eslint job.  For me it's clearer

Indeed ! I didn't noticed that runs in next build. it looks like it don't take in account the new rules with this way. Maybe should we delete the eslint step from build ? And keep the eslint job. For me it's clearer

Agree with this proposal, it will be clearer


feat: Azure MSI authentication support

Would be nice to support also Azure MSI authentication.
Terraform solution ( ARM_USE_MSI=true environment variable for fallbacking to MSI authentication ):
https://registry.terraform.io/providers/hashicorp/azuread/latest/docs/guides/managed_service_identity#configuring-managed-service-identity-in-terraform
Related:
https://github.com/Azure/azure-sdk-for-ruby/blob/master/runtime/ms_rest_azure/lib/ms_rest_azure/credentials/msi_token_provider.rb
Thanks
EDIT:
CLI authentication is also useful imho ( az login && terraspace .. )
https://github.com/Azure/azure-sdk-for-ruby/blob/master/runtime/ms_rest_azure/lib/ms_rest_azure/credentials/azure_cli_token_provider.rb

Thanks for the links to the azure sdk. Dug into it and the ruby azure sdk was able to auth via MSI and CLI. Sadly, the azure ruby sdk has been deprecated:
https://github.com/Azure/azure-sdk-for-ruby/blob/master/docs/README.md
Have been able to get by still using the deprecated sdk for the terraspace_plugin_azurerm. Running into a few annoying issues with it though. IE:  It's gemspec pins faraday and other dependencies down, and microsoft is not updating the ruby gems.
Resorted to writing a ruby gem that uses the Azure REST API https://github.com/boltops-tools/armrest  It was a bit of an effort 🤣
The armrest gem will check automatically check a few credentials
Environment -> MSI -> CLI

Note: Had some mixed feelings about the order of the auth provider chain. With AWS, the credentials provider chain puts the InstanceProfile at the end. See: https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-quickstart.html#cli-configure-quickstart-precedence Feel this means more sense since need to make a network call to see if the metadata endpoint is available.
Studied the .net DefaultAzureCredential chain and based it on that. See: https://docs.microsoft.com/en-us/dotnet/api/overview/azure/identity-readme#defaultazurecredential
Also, added docs: https://terraspace.cloud/docs/plugins/azure/auth/


Adds icons for Haxe file type

screenshot

Thanks for the PR.
Can you add a commit that specifies this for version 2.3.7 in the change-log so that we can release directly after merging?
You need to add a file messages/2.3.7.md and then reference it in messages.json. Preferably, copy messages/2.3.6.md and change it to fit 2.3.7.

pushed the message
also, i updated the screenshot with the latest icons

Merged, thanks!


pcbsd/TrueOS's about missing from Trident

Recommend "about" from trueos-utils should be brought in by default with trident-core
or a meta package that brings in a base set of True and Trident packages.
John
<EMAIL_ADDRESS>

I see about now ships with trident-core.
Thank you!
John
<EMAIL_ADDRESS>


Add new dbtcloud_users datasource to get all users

Today, some people want to set internal notifications based on email addresses.
One of the ways to handle it is to get the id of a user with the dbtcloud_user datasource but it fails if the email doesn't exist.
This new data source returns all users so people can do further filtering in HCL if need be. It handles pagination for people with more than 100 users.

CI passed 🚀


Update Conceal and Android support library

1, updated cryptographic library Conceal v1 to v2 ; upgrade notes
2, update the Android support library to 27.1.0 (due to 27 so the minimum version upgrade to 14);

@orhanobut  Why fails to build when upgrading to 4.1? Has been built locally.

Awesome! Let me check the issue soon and see why it fails. Btw why don't we just update conceal version through maven? I think that'd be much better option and easier to update.

@orhanobut  Yes, it is indeed more convenient to update through experts. I have already realized that this issue has been modified into an expert in the local, but this was not submitted successfully, so no later changes can be made.

@alphater Do you mean the artifacts are not present in maven central? That'd be weird.

Going to push a change-set which includes these updates as well. Therefore closing this one. Thanks for the changes and bumping versions 👍


Fix nvcc/gcc-10 (Octo-Tiger) compilation issue

Using HPX 1.9.0, the Octo-Tiger compilation (using just CUDA, not Kokkos) with gcc+nvcc fails due to an internal nvcc error pointing to loop.hpp within HPX:
build/hpx/include/hpx/parallel/util/loop.hpp(216): internal error: assertion failed at: "cp_gen_be.c", line 22617 in gen_variable_decl

1 catastrophic error detected in the compilation of "/src/octotiger/src/unitiger/hydro_impl/flux_cuda_kernel.cpp".
Compilation aborted.
nvcc error   : 'cudafe++' died due to signal 6
nvcc error   : 'cudafe++' core dumped

That is with using g++10 and CUDA 11.5.
While using newer versions of g++/CUDA fix this, it would be nice to not lose g++-10 support over this.
Interestingly, simply providing nvcc with more information about the type seems to help as well, hence this PR to resolve the issue without losing support for the older compiler.

bors merge