Field Attributes

Field attributes such as presence do not seem to be accessible
<field description="Account mnemonic as agreed between buy and sell sides, e.g. broker and institution or investor/intermediary and fund manager." id="1" name="Account" semanticType="String" presence="required" offset="25" type="String12"/>

//String example in rlsbe
public static int accountId()
{
return 1;
}
public static int accountSinceVersion()
{
return 0;
}
public static String accountMetaAttribute(final MetaAttribute metaAttribute)
{
switch (metaAttribute)
{
case EPOCH: return "unix";
case TIME_UNIT: return "nanosecond";
case SEMANTIC_TYPE: return "String";
}
return "";

}
public static byte accountNullValue()
{
return (byte)0;
}
public static byte accountMinValue()
{
return (byte)32;
}
public static byte accountMaxValue()
{
return (byte)126;
}
public static int accountLength()
{
return 12;
}
public byte account(final int index)
{
if (index < 0 || index >= 12)
{
throw new IndexOutOfBoundsException("index out of range: index=" + index);
}
final int pos = this.offset + 25 + (index * 1);

return buffer.getByte(pos);

}
public static String accountCharacterEncoding()
{
return "UTF-8";
}
public int getAccount(final byte[] dst, final int dstOffset)
{
final int length = 12;
if (dstOffset < 0 || dstOffset > (dst.length - length))
{
throw new IndexOutOfBoundsException("dstOffset out of range for copy: offset=" + dstOffset);
}
buffer.getBytes(this.offset + 25, dst, dstOffset, length);

return length;

}
we’d expect in something related to presence in meta attribute function, although right now that’s not even a member of the MetaAttribute enum:
public static String accountMetaAttribute(final MetaAttribute metaAttribute)
{
switch (metaAttribute)
{
case EPOCH: return "unix";
case TIME_UNIT: return "nanosecond";
case SEMANTIC_TYPE: return "String";
case PRESENCE: return “required”;
}
return "";

}

I've added this feature.

I'll have a look at this for Golang and CSharp but I'll be a few days.

Thanks @billsegall. The Java and C++ generator changes were pretty trivial for this.

Thanks martin for the quick turnaround on this

Just to clarify that this change will support enforcement of presence=required for a repeating group such that the count has to be greater than zero

@adkapur Can you elaborate please. How does the enforcement work?

A repeating group is always present, even if it has zero entries. In the version 1.0 spec, the way to control the number of instances of a group is explained in section "Restricting repeating group entries", by setting the attributes minValue and/or maxValue.

The min and max values are tied to the groupSizeEncoding data type but we wanted to know if the real logic codegen will expose presence=required for a field representing number of repeating group entries such as for example Number of Party Roles
We are trying to convert FIX into SBE and our message validations will be leveraging the presence=required attribute

Also within a repeating group some entries may be required and others may be optional so ideally presence should be able to tell us this for each field


Stop directing traffic to Discourse

Feature
Why is this feature being added?
Discourse is not gaining traction. Let's double down on Slack and email marketing.
What should your feature do?
Don't shut down Discourse yet - instead, find all areas where it's referenced in the frontend and backend (either Discourse, or community.operationcode.org) and remove them.

Reference areas:

Greeting Email
User Dashboard
?

community.operationcode.org should go to the user dashboard, maybe? Also, the FAQ mentions it too, I believe.

Mentor bot still references discourse, should be removed from Mentor bot.

I'm going to try my hand at this one if that's okay.

So, community.operationcode.org references are to be removed as well...?

Yup.


Improve the web page UI

Improve the Frontend and Make it Attractive and Responsive :rainbow:

Can I work on this?

@Shivangi-ch Yes you can work

Hi, can i work on this?

@nischaynagar Yes you can also try

@pm0824 Yes you can also try


Lock screen dithered and looks bad

Describe the bug
When running xochitl under oxide, and the screensaver / lock screen loads suspended.png, the image first loads cleanly, then is immediately dithered to half-brightness or something, and looks blurry.
To Reproduce
Steps to reproduce the behavior:

From oxide launcher,  start xochitl
While xochitl is running, press the power button on top of the RM1
Observe suspended.png loading cleanly (briefly)
Observe an immediate dithering of the clean image

Expected behavior
A clear presentation of the image in suspended.png when the screen is locked or times out.
Screenshots
Not sure how to take a screenshot of a lock screen.
Version Information:

Device: reMarkable 1
OS: <IP_ADDRESS>-patch_17.1.03-0-gd8286ca
Version: 2.0.1-beta-2

Additional context
I am using remarkable_news (https://github.com/Evidlo/remarkable_news) to dynamically change my suspended.png image.  It is pulling images from picsum.photo with the following URL:  https://picsum.photos/1404/1872.jpg?grayscale.  This should bring in an image perfectly sized to the screen, and greyscaled.
Note:  Prior to installing toltec and oxide, I was using remarkable_news and the images were coming in clean.  I think this is something to do with oxide trying to "help" the screen lock action, perhaps?

This is likely due to an issue that others have mentioned (but not opened an issue for yet) where the power button press is for some reason not actually being blocked by tarnish, and thus xochitl is also trying to handle the button press as well. This isn't a problem on the rM1 due to how it's properly blocking the button press if it's being handled.
@Witos could you include your findings (evtest etc) here?

This is likely due to an issue that others have mentioned (but not opened an issue for yet) where the power button press is for some reason not actually being blocked by tarnish, and thus xochitl is also trying to handle the button press as well. This isn't a problem on the rM1 due to how it's properly blocking the button press if it's being handled.
@Witos could you include your findings (evtest etc) here?

@Eeems Good point on the screenshots.  It sounds like the issue may be understood, but for the sake of completeness, here are two.
Expected behavior:  toltec/oxide not running:

Actual behavior: toltec/oxide running:

@Eeems Good point on the screenshots.  It sounds like the issue may be understood, but for the sake of completeness, here are two.
Expected behavior:  toltec/oxide not running:

Actual behavior: toltec/oxide running:

Oh wait, this is on v2.0.1. I think I had the fix to greyscale image display in v2.1 (unreleased). https://github.com/Eeems/oxide/issues/93

Oh wait, this is on v2.0.1. I think I had the fix to greyscale image display in v2.1 (unreleased). https://github.com/Eeems/oxide/issues/93

@Eeems Gah.  I did try to find an existing issue, too.  This can probably be closed then as it seems to be a duplicate.  I'll wait for 2.1 to come out.

@Eeems Gah.  I did try to find an existing issue, too.  This can probably be closed then as it seems to be a duplicate.  I'll wait for 2.1 to come out.

I'm going to be pushing v2.0.1 here in the next little bit due to a couple of PRs that are open. I'll sneak this in as well.

I'm going to be pushing v2.0.1 here in the next little bit due to a couple of PRs that are open. I'll sneak this in as well.


Running 2 concurrent scans via 2 gmail accounts.

I have it working on my PC at home with a ton of accounts, but on my laptop it will only scan via one at a time. Even if I open the app twice. The scan shows up on both but only one pin will scan at a time.
What am I doing wrong?

Nevermind, lmao. Figured it out. Sorry.


TS is telling me tooltipDataAttrs is a property needed for HeatMap/ContributionGraph

When using the ContributionGraph TypeScript is complaining about a missing property "tooltipDataAttrs"
Do I really need this one, as the graph seems to be working fine without it? Is this an error and the property shouldn't be mandatory?
If it is mandatory, what do I have to enter here?
Path to the file: node_modules/react-native-chart-kit/dist/contribution-graph/index.d.ts
The whole typescript error:
Property 'tooltipDataAttrs' is missing in type '{ values: { date: string; count: number; }[]; endDate: Date; numDays: number; width: number; height: number; yAxisSuffix: string; yAxisLabel: string; yAxisInterval: number; chartConfig: { backgroundColor: string; ... 5 more ...; style: { ...; }; }; style: { ...; }; }' but required in type 'Pick<Readonly<AbstractChartProps & ContributionGraphProps> & Readonly<{ children?: ReactNode; }>, "children" | ... 16 more ... | "tooltipDataAttrs">'.ts(2741)

Duplicate of #468

Duplicate of #468


Auto polyfill overwrites native promise in Edge

I am using the auto polyfill in a typescript project and came across that the polyfill function overwrites the native implementation of Edge`s Promise.
The problem comes from the [object Promise] condition. Seems in Edge the result in promiseToString is [object Object]
 var P = local.Promise;

    if (P) {
      var promiseToString = null;
      try {
        promiseToString = Object.prototype.toString.call(P.resolve());
      } catch (e) {
        // silently ignored
      }

      if (promiseToString === '[object Promise]' && !P.cast) {
        return;
      }
    }

Is this intentionally because I have not came accors a problem with Edge`s promises.

The problem comes from the [object Promise] condition. Seems in Edge the result in promiseToString is [object Object]

Seems like edge needs to fix ^


Improve AWS bucket documentation

Fixes: #23110.
Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Nice, merged, thanks @alexmv! We should backport this too.

Backported to 6.x as the series ending with ac8de664e807bda0095a4a83c9c75db9acafe05c.


Bug or I’m dumb but please help

Anything I try to render there’s just a blank black ground with nothing rendering

I'll need a bit more context in order to help you here. Which version of the mod are you running, which version of the game, are the dependencies up to date and so on. All in all, please send me you latest.log file.
The Fabric Wiki has an article explaining how to get it
Cheeres


Update user-properties.md

The current explanation is vague and insufficient. I've added the following to explain it properly and accompanied as example for clarification:
"The UPN for a B2B collaboration user object contains the email of the guest user, followed by #EXT#, followed by the tenantname.onmicrosoft.com. For example, if the user<EMAIL_ADDRESS>is added as an external user in the directory fabrikam, then its UPN will be<EMAIL_ADDRESS>

@csmulligan
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Court72 can you please follow this up with the author?

I sent a Teams message to the author today.

#sign-off


[test] Modal snapshot test fail "TypeError: parentInstance.children.indexOf is not a function"

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

I expect the tests to run without a problem.
Current Behavior

I get an error:

TypeError: parentInstance.children.indexOf is not a function

I think this is due to portals not working properly in combination with jest snapshots.
Steps to Reproduce (for bugs)
import React from 'react';
import { storiesOf } from '@storybook/react';
import AlertDialog from './AlertDialog';

storiesOf('AlertDialog', module)
  .add('basic', () => <AlertDialog bodyKey="test" onClick={() => {}} titleKey="test" open />);

Where <AlertDialog /> is a boring wrapper around <Dialog />.
I'm sorry for not including a code snippet. I don't know how to set up the tests to illustrate the issue, but I tried my best to provide as much relevant information as possible.

Context

I'm using storybooks with storysnaps (jest snapshots), and our tests are failing. I'm pretty sure it has something to do with https://github.com/airbnb/enzyme/issues/1150 and potentially https://github.com/reactjs/react-modal/issues/553 could benefit from a solution as well.
Your Environment

Tech
Version

Material-UI
1.0.0-beta.21

React
16.0.0

browser
N/A

Additional
I have a feeling this is something that could be caught in storyshots but I'm not experienced enough with the material at hand. Any pointers, or better yet solutions would be greatly appreciated.
I'm not against fixing it and contributing either (if I get the right pointers to help me out).

Your issue has been closed because it does not conform to our issue requirements.
Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

I'm sorry for not including a code snippet. I don't know how to set up the tests to illustrate the issue, but I tried my best to provide as much relevant information as possible.

The information provided aren't actionable on our end.

@oliviertassinari

An error occured when fetching the sandbox:
Could not find package.json

While I do understand you want to keep things tidy in here, I'm not spending too much time on this. I'll just comment out my dialog stories for now. If anyone else comes across this issue, maybe they're willing to make the example.

@RWOverdijk Thanks, I will have a look at what's going on with codesandbox. Yeap, same on our side. We have limited ressource, trying to reproducing issues has a poor value/cost ratio in comparaison to other task. It's why we use a strict policy.

Came across the same issue...
Environment

react 16.1.0
material-ui 1.0.0-beta.20
jest 21.2.1

Component
import React from 'react';
import PropTypes from 'prop-types';
import { withStyles } from 'material-ui/styles';
import Button from 'material-ui/Button';
import Dialog, {
  DialogActions,
  DialogContent,
  DialogContentText,
  DialogTitle,
} from 'material-ui/Dialog';

const styles = () => ({
  div: {
    display: 'block',
    textAlign: 'center'
  }
});
class Error extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      open: true

    };
  }

  handleRequestClose = () => {
    this.setState({ open: false });
  }

  render() {
    const { classes, errorMsg } = this.props;
    return (
      <div className={classes.div}>
        <Dialog ignoreBackdropClick ignoreEscapeKeyUp open={this.state.open} onRequestClose={this.handleRequestClose}>
          <DialogTitle>{"You got an error!"}</DialogTitle>
          <DialogContent>
            <DialogContentText>
              Error: {errorMsg}
            </DialogContentText>
          </DialogContent>
          <DialogActions>
            <Button onClick={this.handleRequestClose} color="accent" autoFocus>
              Dismiss
            </Button>
          </DialogActions>
        </Dialog>
      </div>
    );
  }
}

Error.propTypes = {
  classes: PropTypes.object.isRequired,
  errorMsg: PropTypes.string
};

export default withStyles(styles)(Error);

Test
import React from 'react';
import Error from '../shared/Error';
import renderer from 'react-test-renderer';

describe('Error component', () => {
  it('should render', () => {
    const tree = renderer.create(
      <Error />
    ).toJSON();
    expect(tree).toMatchSnapshot();
  });
});

Error message
● Error component › should render
    TypeError: parentInstance.children.indexOf is not a function

      at appendChild (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7146:39)
      at commitPlacement (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:4893:13)
      at commitAllHostEffects (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:5651:13)
      at HTMLUnknownElement.callCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1584:14)
      at invokeEventListeners (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:219:27)
      at HTMLUnknownElementImpl._dispatch (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:126:9)
      at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:87:17)
      at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/nodes/HTMLElement-impl.js:36:27)
      at HTMLUnknownElement.dispatchEvent (node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:61:35)
      at Object.invokeGuardedCallbackDev (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1623:16)
      at invokeGuardedCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1480:29)
      at commitRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:5771:9)
      at performWorkOnRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6730:42)
      at performWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6680:7)
      at requestWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6596:7)
      at scheduleWorkImpl (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6479:11)
      at scheduleWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6441:12)
      at scheduleTopLevelUpdate (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6904:5)
      at Object.updateContainer (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6942:7)
      at Object.create (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7562:18)
      at Object.<anonymous> (src/components/pages/shared/Error.spec.js:7:44)

I can confirm with @oliviertassinari  that mockPortal.js solves this issue. (not all issues trying to snapshot a material-ui dialog, but this particular one)

Another mocking solution that works is the following
jest.mock('rc-util/lib/Portal')

(add this to the top of the test file)
Obviously the rc-util package is needed for this.

@Skaronator Enzyme do not support the portal API of React: airbnb/enzyme#252. We use a mockPortal.js for our tests internally.

Enzyme now supports the portal API of React. We have removed our mockPortal.js module.

@reyronald We don't rely on rc-util/lib/Portal. We have been using our own Portal component: https://material-ui-next.com/utils/portal/.

Enzyme now supports the portal API of React.

Oh cool - didn't know that. They didn't even close the issue on thier repo.

package.json
"material-ui": "1.0.0-beta.42",
"enzyme": "3.3.0",
"enzyme-adapter-react-16": "1.1.1",

Test
import React from 'react';
import renderer from 'react-test-renderer';
import { BtnIcon } from 'Components/buttons/btn-icon';

const buttonIcon = <i className="fa fa-close" />;

describe('BtnIcon should match Snapshot', () => {
  it('without hint', () => {
    const renderedValue = renderer.create(
      <BtnIcon>{buttonIcon}</BtnIcon>
    ).toJSON();
    expect(renderedValue).toMatchSnapshot();
  });
});

btn-icon.js
import React from 'react';
import PropTypes from 'prop-types';
import IconButton from 'material-ui/IconButton';
import Hint from 'Components/hint';

const BtnIcon = ({
  children, className, onClick, disabled, hint, hintPlacement, wrapperClassName
}) => (
  <Hint
    text={hint}
    placement={hintPlacement}
    className="tooltip-popper--btn-icon"
    wrapperClassName={wrapperClassName}
  >
    <div> {/* Little hack for disabled button inside */}
      <IconButton
        className={`btn btn-icon ${className} ${disabled ? 'disabled' : ''}`}
        onClick={onClick}
        disabled={disabled}
        tabIndex={-1}
      >
        {children}
      </IconButton>
    </div>
  </Hint>
);

BtnIcon.propTypes = {
  children: PropTypes.oneOfType([
    PropTypes.string,
    PropTypes.object
  ]).isRequired,
  className: PropTypes.string,
  onClick: PropTypes.func,
  disabled: PropTypes.bool,
  hint: PropTypes.oneOfType([
    PropTypes.string,
    PropTypes.object
  ]),
  hintPlacement: PropTypes.string,
  wrapperClassName: PropTypes.string
};

BtnIcon.defaultProps = {
  className: '',
  onClick: null,
  disabled: false,
  hint: '',
  wrapperClassName: '',
  hintPlacement: undefined
};

export { BtnIcon };

hint.js - tooltip
import React from 'react';
import PropTypes from 'prop-types';
import Tooltip from 'material-ui/Tooltip';
import './hint.scss';

const Hint = props => (
  <Tooltip
    title={props.text}
    placement={props.placement}
    classes={{
      root: `hint-root ${props.wrapperClassName}`,
      popper: `hint-popper ${props.className}`,
      tooltip: 'hint__text',
      open: 'opened',
      tooltipPlacementLeft: 'left',
      tooltipPlacementRight: 'right',
      tooltipPlacementTop: 'top',
      tooltipPlacementBottom: 'bottom'
    }}
  >
    {props.children}
  </Tooltip>
);

Hint.propTypes = {
  children: PropTypes.oneOfType([
    PropTypes.string,
    PropTypes.object
  ]).isRequired,
  text: PropTypes.oneOfType([
    PropTypes.string,
    PropTypes.object
  ]),
  placement: PropTypes.string,
  className: PropTypes.string,
  wrapperClassName: PropTypes.string
};

Hint.defaultProps = {
  wrapperClassName: '',
  className: '',
  text: '',
  placement: 'top'
};

export default Hint;

And I'm getting the same error:
at appendChild (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8565:39)
      at commitPlacement (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:5779:13)
      at commitAllHostEffects (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6946:13)
      at HTMLUnknownElement.callCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:906:14)
      at invokeEventListeners (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:193:27)
      at HTMLUnknownElementImpl._dispatch (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:119:9)
      at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:82:17)
      at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/nodes/HTMLElement-impl.js:30:27)
      at HTMLUnknownElement.dispatchEvent (node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:157:21)
      at Object.invokeGuardedCallbackDev (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:944:16)
      at invokeGuardedCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:993:29)
      at commitRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7122:9)
      at completeRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8065:36)
      at performWorkOnRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8015:11)
      at performWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7933:9)
      at performSyncWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7910:5)
      at requestWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7810:7)
      at scheduleWorkImpl (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7685:13)
      at scheduleWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7645:12)
      at scheduleRootUpdate (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8273:5)
      at updateContainerAtExpirationTime (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8301:12)
      at Object.updateContainer (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8328:14)
      at Object.create (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:9009:18)
      at Object.<anonymous> (__tests__/components/buttons/btn-icon/btn-icon.test.js:27:53)

console.error node_modules/react-test-renderer/cjs/react-test-renderer.development.js:5206
    The above error occurred in the <Popper> component:
        in Popper (created by Tooltip)
        in Portal (created by Tooltip)
        in Manager (created by Tooltip)
        in Tooltip (created by WithStyles(Tooltip))
        in WithStyles(Tooltip) (created by Hint)
        in Hint (created by BtnIcon)
        in BtnIcon

    Consider adding an error boundary to your tree to customize error handling behavior.
    Visit https://fb.me/react-error-boundaries to learn more about error boundaries.

  console.error node_modules/react-test-renderer/cjs/react-test-renderer.development.js:5206
    The above error occurred in the <div> component:
        in div (created by Popper)
        in Popper (created by Tooltip)
        in Portal (created by Tooltip)
        in Manager (created by Tooltip)
        in Tooltip (created by WithStyles(Tooltip))
        in WithStyles(Tooltip) (created by Hint)
        in Hint (created by BtnIcon)
        in BtnIcon

    Consider adding an error boundary to your tree to customize error handling behavior.
    Visit https://fb.me/react-error-boundaries to learn more about error boundaries.

  console.error node_modules/react-test-renderer/cjs/react-test-renderer.development.js:5206
    The above error occurred in the <BtnIcon> component:
        in BtnIcon

    Consider adding an error boundary to your tree to customize error handling behavior.
    Visit https://fb.me/react-error-boundaries to learn more about error boundaries.

How can I solve this issue while we are waiting for a new enzyme (enzyme that will support portals)?

Solved it with - import { createMount } from 'material-ui/test-utils'; I hope it will be helpful for someone.
Example:
import React from 'react';
import { createMount } from 'material-ui/test-utils';
import { BtnIcon } from 'Components/buttons/btn-icon';

describe('BtnIcon should match Snapshot', () => {
  it('without hint', () => {
    const renderedValue = createMount()(
      // Code of this component - <BtnIcon /> you can find above
      <BtnIcon>{buttonIcon}</BtnIcon>
    );
    expect(renderedValue.html()).toMatchSnapshot();
  });
});

So is the solution here to use createMount from material-ui/test-utils?
I would like to continue to use react-test-renderer.
const tree = renderer.create(<MyComp />);

Also that issue: https://stackoverflow.com/questions/61346327/warning-an-invalid-container-has-been-provided-in-jest

I  experience  same issue when using mui Dialog and react-test-renderer. Here's the related sandbox.

I experience same issue when using mui Dialog and react-test-renderer. Here's the related sandbox.

same error

The root cause is ReactDOM.createPortal, which many Modal components relay on.
import ReactDOM from 'react-dom';

  beforeAll(() => {
    ReactDOM.createPortal = jest.fn((element, _node) => {
      return element;
    });
  });

  afterEach(() => {
    ReactDOM.createPortal.mockClear();
  });

You need to mock out react-dom and the createPortal() method it returns with Jest
jest.mock('react-dom', () => {
  const original = jest.requireActual('react-dom');

  return {
    ...original,
    createPortal: (node) => node,
  };
});


Latitude and Longitude from DWD are not decimal values

I was wondering why the home assistant integration was returning a station which is far away from the lat/long from my home.
I have then checked the values that DWD provides in their station list.
If they write 50.25 they don’t mean the decimal value 50.25, but 50 degrees, 25 minutes.
I‘m on my phone right now and can’t type the degree symbol, but you can check this in google maps when you type 50*25'N 7*13'E in the search bar (replace * with the degree symbol).

Oh thanks for the heads-up, I'll fix this!

This is fixed in the new version!


Publishes Grafana and Prometheus images for monitoring.

Motivation
I run lodestar in a fully dockerized environment and it is non-trivial to add grafana/prometheus at the moment.  This is because configuration of these two images is done at build time rather than runtime, and they aren't published anywhere.  As a user, if I want to add monitoring to my docker hosted Lodestar instance I would need to:

clone this repository somewhere
setup some configuration in .env files and such
docker build
docker publish
go to my production environment and add new entries for each.

After this change, I can skip to step 5.
Description
Prometheus only supports configuration by file, so in order to support runtime configuration via environment we have to switch over to using an entrypoint script. exec will make it so /bin/prometheus will take over PID 1, which ensures that signals get processed correctly. I picked some reasonable defaults for BEACON_URL and VC_URL, but I'm happy to change them to whatever.
Grafana requires building with a second context because the dashboards folder is outside of the docker folder. This requires a relatively up-to-date version of docker and I'm hoping GitHub actions supports it. Users should be able to mount a volume of their choosing targeting /dashboards if they want their own dashboards to be retained on top of the default set.
Grafana build was setting the admin password at build time, but that should be set at runtime. I set the default password to admin under the assumption that the user will have to go out of their way to expose the service and hopefully they'll change the password when they do.  😬
I added two new build/push steps to each of the GitHub action workflows that follow the tagging convention of chainsafe/lodestar. I suspect some other name will be desired like chainsafe/lodestar-grafana and I'm happy to change it to whatever.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

the chainsafe/lodestar-grafana and chainsafe/lodestar-prometheus dockerhub repos should be ready


Fix/repo relative imports

Fixes #94 . The extra import path is routed via the .pth file.

@mattem @alexeagle PTAL.

I'm still not sure on making this implicit, and would rather it be explicitly added to a rules imports attr with ../.. back to the repo root as needed in user land.

I'm still not sure on making this implicit, and would rather it be explicitly added to a rules imports attr with ../.. back to the repo root as needed in user land.

Well, that how official Bazel rules behave. FWIW, in a monorepo setting folks typically import their Python modules in a repo-relative fashion. And, from what I know, that works out of the box.
@mattem PTAL.

@mattem friendly ping. PTAL when you have time.

@mattem friendly ping. PTAL when you have time.


Error writing block to datastore:

I have installed ipfs in my system(win 10). Once I access "localhost:8080/ipfs/QmX7M9CiYXjVeFnkfVGf3y5ixTZ2ACeSGyL1vBJY1HvQPp/mdown" ,the ipfs console show "16:29:03.360 ERROR  bitswap: Error writing block to datastore: Access is denied. bitswap.go:385"
And then the explorer show error:
ipfs resolve -r /ipfs/QmX7M9CiYXjVeFnkfVGf3y5ixTZ2ACeSGyL1vBJY1HvQPp/mdown: Failed to get block for QmdxzgBtiocRhGdJSjwtWhGVZtTB9fE5XvQZmrMaenjzV9: context deadline exceeded
Is it a bug?

Hi @jamie0828 sorry no one was able to answer your question here. It sounds like an issue with you IPFS install, but this is the issue tracker for the Web UI app. You'll have more luck finding the answer on the IPFS discuss forum https://discuss.ipfs.io/


Add noun whitelist to singular noun rule

Fixes #479

This change is

Comments from Reviewable

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@raghushantha Thanks!


WSL Connection in code doesn't resolve PATH variable properly

Does this issue occur when all extensions are disabled?: No

VS CodeVersion: 1.90.1 (user setup)
Commit: 611f9bfce64f25108829dd295f54a6894e87339d
Date: 2024-06-11T21:01:24.262Z
Electron: 29.4.0
ElectronBuildId: 9593362
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.22631
Steps to Reproduce:

Connect to WSL Ubuntu LTS 23.4.3 in code using remote WSL Targets.
In terminal you wont be able see "/snap/bin" in path variable even though it is being loaded by /etc/profile.d/apps-bin-path.sh
That script runs normal if run from plane terminal without using code.
The bug is from WSL extension I guess, initially able to bisect but it later not able to bisect this extension for some reason.
WSL extension is also from microsoft.com.

/duplicate https://github.com/microsoft/vscode-remote-release/issues/6096


Resetting layouts only up to a certain level

Describe the problem
Currently __layout.reset.svelte files undo all the layouts that have been applied from the root level. This behaviour is undesirable when we only want to reset the immediate parent layout and leave the remaining ones.
Another thing that makes it undesirable, importing global stylesheets in the root layout is a common pattern from what I've seen and undoing the root layout means having to do those imports all over again in the reset file.
Describe the proposed solution
My first thought was something in the filename of the resets like __layout.reset.1.svelte.
Seeing #4103 and #2694 makes me wonder what if we ditch the __layout.reset.svelte file altogether and instead allow page level components (incl __layout.svelte files) to do export const reset like with prerender and router except that reset would be number instead of a boolean.
Say we have a file structure like this.
routes/
├─ index.svelte
├─ __layout.svelte
├─ nested/
│  ├─ __layout.svelte
│  ├─ page1.svelte
│  ├─ deeper-nested/
│  │  ├─ page2.svelte

Example 1
If page2 exports reset = 1, then it'd only reset nested/__layout.svelte
If it exports reset = 2, then it'd reset both nested/__layout.svelte and routes/__layout.svelte
Example 2
If nested/__layout.svelte exports reset = 1, then it'd reset its parent layout, routes/__layout.svelte
And if it didn't export reset at all, then it'd just stack like it currently does.
Example 3?
If the current behavior of resetting all the way to the top is desired in some cases, then exporting reset = 0 could be treated as a special value to make that easier (this can be scrapped if it's thought to be ambiguous/confusing)
Alternatives considered
N/A
Importance
would make my life easier
Additional Information
No response

I don't agree with the proposed solution, but I agree with the general problem: layouts are a little too strongly coupled with the directory structure right now, which is in turn strongly coupled with routing. It's great that layouts just work in a simple way out of the box, but I don't think there's enough flexibility right now. Ideally I should be able to easily configure an arbitrary route to use an arbitrary layout.


Fix Dockerfile

We need to pay more attention when the Dockerfile is modified. It's the second time I fix changes that are made in this file, which seems that is modified without any tests. Maybe I can add some Dockerfile tests in the future.
In the PR I  solved the following:
Step 1/12 : FROM mcr.microsoft.com/dotnet/sdk:5.0.0 AS Build
ERROR: Service 'build-neo-cli' failed to build: manifest for mcr.microsoft.com/dotnet/sdk:5.0.0 not found: manifest unknown: manifest tagged by "5.0.0" is not found

As stated here, the best way to tag is 5.0 or specific ones, like 5.0.102.
Also, I solved something else:
When we use mcr.microsoft.com/dotnet/runtime:5.0 to run the neo-cli.dll, the following message appeared:
root@eb171729224b:/neo-cli# dotnet neo-cli.dll -r
It was not possible to find any compatible framework version
The framework 'Microsoft.AspNetCore.App', version '5.0.0' was not found.
  - No frameworks were found.

You can resolve the problem by installing the specified framework and/or SDK.

The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.AspNetCore.App&framework_version=5.0.0&arch=x64&rid=debian.10-x64
root@eb171729224b:/neo-cli#

That's why I changed and switched to mcr.microsoft.com/dotnet/aspnet:5.0.

@neo-project/ngd-shanghai Anyone can test it?

@neo-project/ngd-shanghai Anyone can test it?

We'll test it.

We'll test it.

I followed this procedure to install docker in Windows 10 Home Edition, but it executed with an error.
PS C:\Users\chenzhitong\neo-node> docker version
Client: Docker Engine - Community
 Cloud integration: 1.0.7
 Version:           20.10.2
 API version:       1.41
 Go version:        go1.13.15
 Git commit:        2291f61
 Built:             Mon Dec 28 16:14:16 2020
 OS/Arch:           windows/amd64
 Context:           default
 Experimental:      true
error during connect: This error may indicate that the docker daemon is not running.: Get http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/version: open //./pipe/docker_engine: The system cannot find the file specified.

After successful installation, build neo-node into docker will report an error, does anyone know what I did wrong?
PS C:\Users\chenzhitong> git clone https://github.com/AxLabs/neo-node
Cloning into 'neo-node'...
remote: Enumerating objects: 37, done.
remote: Counting objects: 100% (37/37), done.
remote: Compressing objects: 100% (27/27), done.
remote: Total 1906 (delta 16), reused 17 (delta 10), pack-reused 1869
Receiving objects: 100% (1906/1906), 633.01 KiB | 427.00 KiB/s, done.
Resolving deltas: 100% (1243/1243), done.
PS C:\Users\chenzhitong> cd neo-node
PS C:\Users\chenzhitong\neo-node> git branch fix-dockerfile

PS C:\Users\chenzhitong\neo-node> docker build -t neo-cli .
error during connect: This error may indicate that the docker daemon is not running.: Post http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/build?buildargs=%7B%7D&cachefrom=%5B%5D&cgroupparent=&cpuperiod=0&cpuquota=0&cpusetcpus=&cpusetmems=&cpushares=0&dockerfile=Dockerfile&labels=%7B%7D&memory=0&memswap=0&networkmode=default&rm=1&shmsize=0&t=neo-cli&target=&ulimits=null&version=1: open //./pipe/docker_engine: The system cannot find the file specified.
PS C:\Users\chenzhitong\neo-node>

😥

I followed this procedure to install docker in Windows 10 Home Edition, but it executed with an error.
PS C:\Users\chenzhitong\neo-node> docker version
Client: Docker Engine - Community
 Cloud integration: 1.0.7
 Version:           20.10.2
 API version:       1.41
 Go version:        go1.13.15
 Git commit:        2291f61
 Built:             Mon Dec 28 16:14:16 2020
 OS/Arch:           windows/amd64
 Context:           default
 Experimental:      true
error during connect: This error may indicate that the docker daemon is not running.: Get http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/version: open //./pipe/docker_engine: The system cannot find the file specified.

After successful installation, build neo-node into docker will report an error, does anyone know what I did wrong?
PS C:\Users\chenzhitong> git clone https://github.com/AxLabs/neo-node
Cloning into 'neo-node'...
remote: Enumerating objects: 37, done.
remote: Counting objects: 100% (37/37), done.
remote: Compressing objects: 100% (27/27), done.
remote: Total 1906 (delta 16), reused 17 (delta 10), pack-reused 1869
Receiving objects: 100% (1906/1906), 633.01 KiB | 427.00 KiB/s, done.
Resolving deltas: 100% (1243/1243), done.
PS C:\Users\chenzhitong> cd neo-node
PS C:\Users\chenzhitong\neo-node> git branch fix-dockerfile

PS C:\Users\chenzhitong\neo-node> docker build -t neo-cli .
error during connect: This error may indicate that the docker daemon is not running.: Post http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/build?buildargs=%7B%7D&cachefrom=%5B%5D&cgroupparent=&cpuperiod=0&cpuquota=0&cpusetcpus=&cpusetmems=&cpushares=0&dockerfile=Dockerfile&labels=%7B%7D&memory=0&memswap=0&networkmode=default&rm=1&shmsize=0&t=neo-cli&target=&ulimits=null&version=1: open //./pipe/docker_engine: The system cannot find the file specified.
PS C:\Users\chenzhitong\neo-node>

😥

@chenzhitong I can't help with Windows, but you could read this issue.

@chenzhitong I can't help with Windows, but you could read this issue.

I build it successfully.

I build it successfully.

@superboyiii @chenzhitong the build works, it's all fine. And I believe that all functions of the node are also working -- because I could run a testnet with this Dockerfile.

@superboyiii @chenzhitong the build works, it's all fine. And I believe that all functions of the node are also working -- because I could run a testnet with this Dockerfile.

This branch is out-of-date with the base branch

This branch is out-of-date with the base branch

@erikzhang Done. Ready to go.

@erikzhang Done. Ready to go.


fix: update error message for invalid build preset

Entering invalid preset name in error message.
Changing the command to list presets in the error message from azion presets ls to npx edge-functions presets ls.

:tada: This PR is included in version 4.1.1-stage.3 :tada:
The release is available on:

npm package (@stage dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


All in issue

I have write some test with 3 players
1 with 50 credits
2 with 100 credits
3 with 100 credits
At the end of game sum of all players is not the total of starting credits

bigBlindIndex = Math.floor(Math.random() * this.players.length); make test difficult to write, because beginner is never the same.
What do you think if first player joining is the dealer, and small/big are index + 1 / index + 2, if only 2 players dealer are also big blind ?
When new round begin dealer index is increase.
This test show an error with sharing pot, I don't know if you can look in it. It's hard to understand because I don't have make it :)

bigBlindIndex = Math.floor(Math.random() * this.players.length); make test difficult to write, because beginner is never the same.
What do you think if first player joining is the dealer, and small/big are index + 1 / index + 2, if only 2 players dealer are also big blind ?
When new round begin dealer index is increase.
https://en.wikipedia.org/wiki/Blind_(poker)
This test show an error with sharing pot, I don't know if you can look in it. It's hard to understand because I don't have make it :)

Yeah, the sidepot calculation is not correct as of now. I'm fine with making the first to join the dealer though.


eslint diagnostics end of line

i know diagnostics is experimental just reporting my issue
eslint with prettier rule warning about no end of file line, as neovim behavior is don't show that line even when it exists, diagnostics has a false positive there, running eslint command directly or open on vscode doesn't have the error since there is actually a end of file line there.

additional it works with lsp efm
neovim version
NVIM v0.5.0-dev+1274-gbb3372792
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

First, thanks for helping improve diagnostics! This is exactly the kind of help I'm looking for.
I had no idea that Neovim (and Vim) had this behavior, but it seems like VS Code and other editors like Atom are actually defying standard Unix behavior by treating the final newline as if it represents an actual empty line. The plugin uses Neovim's nvim_buf_get_lines to get the buffer content directly, which doesn't seem to include the final newline (at least according tocat -E).
I've just pushed a fix that simply appends a final newline to the content, which fixes the ESLint issue you described (hopefully without any unexpected side effects). Could you let me know if it works for you?

just tried and is working fine, thank you. I will continue testing it, and i let you know if i find any side effect

Awesome, thanks for confirming. Going to close this for now but feel free to open another issue if you run into any more problems.


add node tap --ts flag to docs

Resolve #1034

@elenaizaguirre To pass the semantic pull request check I recommend making the commit message like this:
docs: add node tap --ts flag

Fixes #1034

Thanks for the tip @petermetz

Codecov Report

Merging #1055 (1a0df53) into main (04cacc9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1055   +/-   ##
=======================================
  Coverage   72.43%   72.43%
=======================================
  Files         238      238
  Lines        8221     8221
  Branches      973      973
=======================================
  Hits         5955     5955
  Misses       1749     1749
  Partials      517      517

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04cacc9...1a0df53. Read the comment docs.


Consider adding an option to disable localized translations of technical error messages or terms

Issue with Current Localization Translations
The current localization translations of error messages, especially those containing technical terms, may sometimes be ambiguous or misleading, causing confusion for users who are more comfortable with English technical terms.
Previous Discussion A discussion in a closed issue highlights the concerns of multiple users regarding this matter, which can be found here: https://github.com/microsoft/pylance-release/issues/4579

As an external user, I appreciate the official efforts to localize these error messages, as some users may indeed need them. However, objectively speaking, the current localization translations, especially those containing technical terms, may sometimes be ambiguous or misleading and need further refinement.
It's worth noting that related plugins (pyright, which pylance is powered by) no longer accept external PR contributions to improve localization translations (source: https://github.com/microsoft/pyright/pull/8659#issuecomment-2269643727). Adjustments to localization translations need to be relayed by the official development team to the localization team, following an internal workflow for evaluation and implementation. This is undoubtedly a long-term process, requiring significant resources to gradually improve to a level that satisfies many users.

Proposed Solution
I hope that we, as "experienced" users, can have an option to separately disable the localization translations of these technical error messages and terms and instead display them in English (en) locale.
This would, to some extent, help users who are more comfortable with English technical terms better understand these error messages, especially when there are ambiguities in translation, without having to switch the entire VSCode localization locale.
Alternative Approach
An alternative solution could be to improve the localization translations, but this is a long-term process and may not be feasible in the short term.
Any suggestions or thoughts will be appreciated.

@debonte, I wonder if we should consider adding more metadata or formatting hints in the English strings to help the translators understand which words should remain untranslated. In some cases, these terms are already presented in double quotes. For example: "awaitNotAllowed": "Type annotations cannot use \"await\"",. In other cases, such as the "expectedBoolLiteral" example you mention above, keywords like True and False are not quoted. Adding quotes in this case would probably make the error message less readable, but we could use some other delimiter that is stripped out of the English string before it is presented to users. Maybe something like double double asterisks?

Ah, nice! Yes, if there's an established convention, it makes sense to adopt that.

I had the same thought and I found this issue.

I think you're saying that you'd like a way to have our diagnostics appear in English while having the strings in our UI (command names, code action names, etc) use the VS Code display language? Is that correct?

Yes, that seems correct. I would like to have this option and see the diagnostics in English, while the UI (or other apps) use wonderful translation.

This issue has been fixed in prerelease version 2024.10.102, which we've just released. You can find the changelog here: CHANGELOG.md


saikat roy portfolio link and git repo added

In which directory. There wasn't any instructions for photo.

In which directory. There wasn't any instructions for photo.

Kindly check the instructions once and add the image

yah image added now


Link to EUSA's copy of the constitution in the releases section is broken.

In the releases section, specifically the latest release at the time of writing (2018-03-22), there is a link to the EUSA website for their copy of the constitution. However, this link is broken. Neither can I find it anyway currently hosted on the EUSA website; they most likely do not host constitutions of their societies any more? At least it's not present on the Comp Soc EUSA page.

Yeah i guess they don't host it anymore, have removed the link.


[WIP] Python Editor tests

Basic Python Editor tests for #536
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@marthacryan @karlaspuldaro if you could do a review on this WIP PR that would be great. Looking for feedback if this is the right starting approach for determining the elements to click.


DebugToolbar 2.0 doesn't work with RequestHistory 0.0.11 plugin

Recent update of the django-debug-toolbar==2.0 isn't compatible with the latest 'djangoe-debug-toolbar-request-history==0.0.11` plugin.
https://github.com/djsutho/django-debug-toolbar-request-history/issues/28
Btw. why do we keep debug-toolbar in the standard requirements instead of the dev one?

Here is the report for 0ab4b6ce8bfd39ff4e4fa563850990b38c1e0008 (mirumee/saleor @ fix/downgrade_django_debug_toolbar)
Base comparison is 33da5754e16c89e65af31e4b646231f35880be99.
No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         43	         43	             21

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

Since we're touching it, can we move it to the right requirements in this PR? Also, we should update the Pipfile.

There is a discussion about why debugtoolbar should stay in regular requirements in PR https://github.com/mirumee/saleor/pull/3076.

Why though? The related issue was just showing an error, not the error stack... Maybe it was an issue because they used DEBUG=True without having the development dependencies?

How about this explanation? https://github.com/mirumee/saleor/issues/3042#issuecomment-427298303

Thanks for the link! After discussion, it is better to have them as a base requirement as it is something that is directly importer from the code. It wouldn't crash in production but the issue is that some users might not read properly or at all the documentation, and thus open issues about the error because they didn't install the dev dependencies.
Thanks for the catch and remark @jxltom!


I didn't receive the password reset email

I havent recieved email for my account overture_email. Please assist.

Hello @balaoverture,
Thanks for submitting a GitHub issue! We are very sorry that you are running into this problem. Often, this happens because you're trying to reset your password with an incorrect username (the UI doesn't tell you if it's wrong or not, it just says it sends an email). You can start the flow of verifying your username, and resetting your password with this form: https://support.sendgrid.com/hc/en-us/requests/new#forgot-username. Closing this issue, since it is not a docs specific issue.
Thank you!
SendGrid DX Team


Task - Multiple presses of the "Enter" button create duplicate tasks

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.18-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4841867
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Open https://staging.new.expensify.com/
Log in with any account
Navigate to any conversation
Start creating a task
Add a multi-sided description
Click on the "Next" button
Press repeatedly the "Enter" button or the "Confirm task" button

Expected Result:
Tasks should not be duplicated after repeatedly pressing "Enter" or the "Confirm task" button itself
Actual Result:
Multiple presses of the "Enter" button create duplicate tasks
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/5d1eb046-c1b3-46f8-bb8e-ec6533a6e7a8
View all open jobs on GitHub

We think that this bug might be related to #vip-vsp

@adelekennedy  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Task - Multiple presses of the "Enter" button create duplicate tasks
What is the root cause of that problem?
This happens as we are missing the useSingleExecution logic for onSubmit when creating task here
What changes do you think we should make in order to solve the problem?
We should wrap the onSubmit here with a useSingleExecution hook:
https://github.com/Expensify/App/blob/6be470f60f6027b49b63ff6507b33f98e2904662/src/pages/tasks/NewTaskPage.tsx#L98-L100
Alternatively
We can add a prop to FormAlertWithSubmitButton called useSingleExecution

issue is not reproducible on main.

Reproducible:
https://github.com/user-attachments/assets/64ca6662-02e4-46a6-9e2e-0a750782090f
3 tasks are created

I can't even reproduce this going as fast as I can on v v9.0.19-4 - closing this


Added SearchResult NotFound in Blogs and Contributors

Description
This pull request introduces a new SearchResultNotFound component that enhances the blog and contributor pages. The SearchResultNotFound component is now utilized to improve the user experience when no search results are found on these pages.
Changes Made

Created the SearchResultNotFound component with custom styling for a visually appealing display.
Integrated the SearchResultNotFound component into the Blogs page to handle cases where no matching blog posts are found based on the search query.
Integrated the SearchResultNotFound component into the Contributors page to handle cases where no matching contributors are found based on the search query.

VIDEO
https://github.com/amupedia2021/Project-Amupedia/assets/85815172/baf7e9bd-2ef4-45b3-9e76-e8e1e760da69
Pull Request Checklist
Please make sure that your PR meets the following requirements:

[x] The app is working correctly after applying the changes.
[x] The app is responsive and displays properly on different screen sizes and devices.
[x] The changes are thoroughly documented in the appropriate files or documentation sections.
[x] The coding conventions and style guidelines are followed consistently.

Checklist
Please check all applicable boxes and provide any additional information if needed.

[x] I have tested the changes locally and ensured that the app is functioning as expected.
[x] I have verified that the app is responsive and looks good on various screen sizes and devices.
[x] I have reviewed the documentation and ensured that it accurately reflects the changes made.
[x] I have followed the coding conventions and style guidelines defined in the project.
[x] I have run the automated tests and all of them pass.
[x] I have considered the performance implications of the changes made.
[x] I have considered the security implications of the changes made.
[x] I have checked for any potential regressions or side effects caused by the changes.
[x] I have performed a self-review of my code.
[ ] Starred the repository.
[ ] Added My Name to the Contributor's List.
[ ] Followed the repository's Contributing Guidelines.
[ ] I ran the app and tested it locally to verify that it works as expected.

Screenshots - If Any (Optional)
Additional Notes(Optional)
Please provide any additional information or context that may be helpful for reviewing the pull request.
Related Issues
Please list any related issues or pull requests that are associated with this pull request.
Reviewers
Please tag the relevant team members or reviewers who should review this pull request.

@anmode @tayyab-ilyas  ,please review and merge my pull request

and Many more like https://colorlib.com/wp/free-404-error-page-templates/


Event-driven receiving

what's your thinking on adding an event for when a queue gets a new message? thanks!

you can use rsmq-worker.
It wraps rsmq and makes it simple to implement a worker around it.
See the message event.

many thanks! sorry i missed that. thanks for the great packages!


Explorer Performance Improvements

This epic captures the work required to meet our Q3 2022 goals:

Coloring by a gene is interactive for datasets up to 2M cells
Coloring by a geneset is interactive for datasets up to 2M cells
Unfurling a gene set is interactive for datasets up to 2M cells

Related Docs:

https://docs.google.com/document/d/1CBy8mHuOgWcScHcBZ8V-oYdQfZsjKo_1MqEC8ovYr4k/edit#
https://docs.google.com/document/d/1kAOv6F_WBAfDymz38EOgQyZMIeOb4CToxUS7qPhBIl0/edit#
https://docs.google.com/document/d/1MkDPIrS14skI-WxFB-BIIJmvRF4SBnOipx9Q6dkcsuI/edit

@pablo-gar was there a dataset around 2M cells that you were trying to use (maybe from the Satija lab?) that didn't work that might be a good test dataset for this?

@signechambers1 - we do have a live dataset in the corpus if that helps. See Survey of human embryonic development in https://cellxgene.cziscience.com/collections/c114c20f-1ef4-49a5-9c2e-d965787fb90c

Improves color-by of categoricals: https://github.com/chanzuckerberg/single-cell-explorer/pull/326


Visualize progress section needs some asterix

Visualize progress example in actual practice has some weird side effects since the orchestration is re-entrant for brief windows of time the status may be reverted to an earlier state.  i feel like this shoudl be noted somehow as a simple example with this side effect.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 921c8c10-74b3-9cac-1eb3-3a9f9a1cabed
Version Independent ID: 6bc27b8e-b629-613e-dfb2-5ff8ae7a8a3b
Content: Custom orchestration status in Durable Functions - Azure
Content Source: articles/azure-functions/durable/durable-functions-custom-orchestration-status.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: azfuncdf

Hello @drdamour,  Thank you for your feedback! We will review and update as appropriate.

@drdamour Unfortunately I couldn't replicate it but I would like to understand whether you have implemented singleton or eternal orchestration pattern? If you wish to connect offline, you can send an email with subject line “Attn:Jaya” to AzCommunity[at]Microsoft[dot]com referencing this thread.

@drdamour Following up to understand if you had a chance check the previous comment.

yes, i had to spend quite some time to figure out what even i was talking about.  it turns out i was doing a fan out and the various status returns were stepping over each other possibly because i was making use of ContinueWith which now i'm starting to think is not allowed.
I now understand that the status isn't "comitted" until an activity is awaited/orchestrator exits so given your orchestrator is deterministic it can't really happen in a sequential orchestrator because each entry will only get so far through the sequence and the next time by definition must get AT LEAST as far as the previous time or crash, a crash doesn't "commit" the status.
very tricky, but VERY MORE clever.
mistaken ticket, thank you for correcting me.  please close.

We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


[BUG] Stop Button for stop searching for users doesn't work

Description
In the website when i click stop searching button, it doesn't work and it is still searching for users.
Screenshots
No response
Additional information
No response
🥦 Browser
Google Chrome
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue ?
None

This happens because the server went to sleep and is having a problem reconnecting. Will be hosting the server somewhere else soon, but it's not a bug. Thanks for raising an issue and trying out the product


remove the unused item incorrect-ns

What problem does this PR solve?
remove the unused item incorrect-ns
What is changed and how it works?
remove the unused item incorrect-ns
Check List
Tests

No code

Codecov Report

Merging #2005 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2005      +/-   ##
==========================================
- Coverage   77.56%   77.47%   -0.09%
==========================================
  Files         178      178
  Lines       18240    18240
==========================================
- Hits        14147    14131      -16
- Misses       3013     3028      +15
- Partials     1080     1081       +1

Impacted Files
Coverage Δ

server/kv/etcd_kv.go
75.32% <0%> (-9.1%)
:arrow_down:

server/member/leader.go
72.44% <0%> (-5.62%)
:arrow_down:

server/schedulers/random_merge.go
61.81% <0%> (-3.64%)
:arrow_down:

server/grpc_service.go
57.23% <0%> (-1.73%)
:arrow_down:

client/client.go
71.28% <0%> (-0.83%)
:arrow_down:

server/server.go
83.49% <0%> (+0.58%)
:arrow_up:

server/tso/tso.go
80.29% <0%> (+2.91%)
:arrow_up:

pkg/etcdutil/etcdutil.go
88.4% <0%> (+5.79%)
:arrow_up:

server/schedule/placement/rule.go
93.93% <0%> (+6.06%)
:arrow_up:

pkg/metricutil/metricutil.go
100% <0%> (+9.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676ddd3...413e7f1. Read the comment docs.

/merge


Don't fallback to vi if $EDITOR isn't set

Asking the user (like yaourt does) seems way better.
Especially considering it would also solve the silent skip of the -e option when editor isn't set and vi isn't available.

Current set up seems perfectly fine to me. Wontfix.

Current set up seems perfectly fine to me.

... Nothing else?
And why that 4.7.x label if invalid?

Current set up seems perfectly fine to me.

Yes, nothing else.

So if choice is not an option, at least a fix for silent failing?

Does it not work already? Or did the current check break somehow?
[[ ! $editor ]] && [[ ! -f /usr/bin/vi ]] && Note "e" $"${colorW}editor${reset} variable unset"

I get a line 859: vi: command not found but the program proceeds regardless.

Fixed in 0f6867bb67d0fd868d3d8c658eea9c20680eff43.
The check wasn't robust enough, and the check with default settings got broken somehow, probably when I cleanup the config options.

Ok now it makes sense.
For as much as I'd still like a more immediate prompt to advance.


Show the radius of curvature in the real time.

Code: https://github.com/akshitagupta15june/lane_detection_opencv/blob/master/curve laneline detection.ipynb

I would like to work on this issue

I would like to work on this issue

Ok assigning you

Ok assigning you


Sanitize parameter for LoadSDF (#7019)

Reference Issue
Fixes #7019
What does this implement/fix? Explain your changes.
Allows users to set sanitize in PandasTools.LoadSDF. I describe in #7019 what I hope to change with this PR.
Also an unused import is removed in RDLogger.py. Unsure if it should be part of this PR.

Great, yes sure. I should find some time next week to implement the Unit Test.

Hi @greglandrum,
I just added a Unittest to check that a structure with a pentavalent carbon is correctly loaded into the DataFrame when the sanitize flag is set to False and also test that this molecule is missing when the flag is set to True.
I hope it's alright like this and that the PR can be merged. Please let me know if further improvements are required.

Thanks @christophhillisch


Unskip no valid host whitebox neutron tempest plugin tests

In order to fix no valid host whitebox neutron tempest plugin tests, https://github.com/openstack-k8s-operators/ci-framework/pull/2308 adds new nodeset with bigger label cloud-centos-9-stream-tripleo-xxl.
This fixes all the usnkipped tests and results are here: https://github.com/openstack-k8s-operators/ci-framework/pull/2308#issuecomment-2331143848
tested here: https://review.rdoproject.org/r/c/testproject/+/54009/15#message-db6853ac3a3a1d941aea45f6d02b3c77889b6aeb
and Tempest results: https://logserver.rdoproject.org/09/54009/15/check/periodic-whitebox-neutron-tempest-plugin-podified-multinode-edpm-deployment-crc-2comp/9aa7925/controller/ci-framework-data/tests/test_operator/tempest-tests-multi-thread-testing-workflow-step-0/stestr_results.html
   whitebox_neutron_tempest_plugin.tests.scenario.test_extra_dhcp_opts.ExtraDhcpOptionsTest passed
   whitebox_neutron_tempest_plugin.tests.scenario.test_multicast.MulticastTestIPv4Common passed
   whitebox_neutron_tempest_plugin.tests.scenario.test_broadcast.BroadcastTestVlanTransparency passed

Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/2308

/lgtm thank you

@m-blue-m
Could we please get a follow up patch to add a note to why the remaining tests are in the exclude list?

/lgtm


Player component doesn't work

Player component doesn't play any of mp4 files, including the ones recorded via the Recorder component.
Repo is provided to simplify reproduction.
Steps to reproduce:

Clone the following repo: https://github.com/bakoushin/medooze-player.git
Install dependencies: npm install
Start server: npm start
Navigate to http://localhost:3000
Make a recording: click Record button to start recording. After a while stop recording. File recoding.mp4 will be created in the script directory.
Playback a recording: click Play button. Playback unexpectedly won't start.

Expected behavior:
Playback will start and play back recorded file.
Logs
[0x7ff013214740][1568970781.226][LOG]>MP4Streamer::Open() [recording.mp4]
[0x7ff013214740][1568970781.226][LOG]-MP4Streamer::Open() | Found hint track [hintId:2]
[0x7ff013214740][1568970781.227][LOG]-MP4Streamer::Open() | Streaming media [trackId:1,type:"vide",name:"VP8",payload:101]
FindTrackId: Track index doesn't exist - track 1 type hint (../external/mp4v2/lib/src/mp4file.cpp,3002)
[0x7ff013214740][1568970781.227][LOG]-MP4Streamer::Open() | Found hint track [hintId:0]
FindTrackIndex: Track id 0 doesn't exist (../external/mp4v2/lib/src/mp4file.cpp,3016)
FindTrackId: Track index doesn't exist - track 0 type text (../external/mp4v2/lib/src/mp4file.cpp,3002)
[0x7ff013214740][1568970781.228][LOG]>MP4Streamer:Play()
[0x7ff013214740][1568970781.234][LOG]<MP4Streamer:Play()
[0x7fefeffff700][1568970781.234][LOG]>MP4Streamer::PlayLoop()
GetSampleTimes: sample id out of range (../external/mp4v2/lib/src/mp4track.cpp,1100)

@murillo128 Any update on this issue, even in demo application playback is not working.
Thanks in advance.

should be fixed now. please test.

Cannot play VP8 recordings. With H264 recordings everything is okay.
The outgoingStream.getStats() shows all zeros when attached to player playing VP8 recording.

Have you tried playing them with vlc?

Sure. The recordings are valid and are playing in VLC correctly.

Even I have tested recordings are playing in VLC.

VP8 inside mp4 is not supported by all players as it is a recent standard, it will play fine on vlc and chrome, but not on Qt or ipad/ios

The issue is that vp8 mp4 recorded via Recorder component is not played by the Player component.

could you send me a sample of a failing vp8 recording for testing locally? are you generating them with chrome or firefox?

I'm generating them from Chrome and from Firefox as well.
Samples:

VP8 from Chrome: https://github.com/bakoushin/medooze-player/blob/recording/recording_vp8_chrome.mp4
VP8 from Firefox: https://github.com/bakoushin/medooze-player/blob/recording/recording_vp8_firefox.mp4
H264 from Safari: https://github.com/bakoushin/medooze-player/blob/recording/recording_h264_safari.mp4

I've created a quick demo, which just creates a file using Recorder, then plays it back using Player:  https://github.com/bakoushin/medooze-player/


The 'srcset' attribute should be overriden

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture

done in https://github.com/DevExpress/testcafe-hammerhead/pull/2832/


Requesting updates to "shared/adb-provision/adb-provision.md" file

For the shared file located at this path shared/adb-provision/adb-provision.md, the database display name differs from what is allowed in the current version of OCI. In the current lab, users are able to choose a display name with whitespace characters. However, in the latest version of OCI, when selecting a display name (for an ADW in this case), whitespaces are not allowed.
See attached images for reference:

@chrishoina Thanks for letting us know.
@greenrick - Could you check and update the lab?

@chrishoina @anooshapilli Hi Anoosha. Please close this issue. I have updated the lab to explain not to use spaces in Display Name, and not to use spaces nor underscores in Database Name:
Display Name - Enter a memorable name for the database for display purposes. For this lab, use ADW_Finance_Mart. (Spaces are not supported)
Database Name - Use letters and numbers only, starting with a letter. Maximum length is 14 characters. (Spaces and underscores not supported.) For this lab, use ADWFINANCE.
Chris, by the way, most of our Autonomous Database workshops are not using this adb-provision.md file for their provisioning lab. They are using either adb-provision-conditional.md in the same subfolder, or in the case of the "Autonomous Database 15 Minute Quick Start" workshop, the provisioning file at \adb\shared\adb-15-minutes\provision-database\adb-provision.moviestream.md. This markdown file points to re-usable "building blocks" markdown files stored in our GitHub's \common\building-blocks\tasks\adb subfolder.

This issue is resolved.


What's the smallest instance size I can use?

With 0.8.3 I could use t2.micro for the controller and the worker.
On 0.9.1 after setting up the cluster, I can't connect if using t2.micro.

Opened by mistake.


Solve interface

This PR introduces a general solve interface that is used to streamline the multiple-solver interfaces. Closes #114.

Very strange: I locally do not get any ruff errors but the CI keeps complaining. A fresh installed repo fixes this.


"folder" codicon doesn't show up in tree view

VS Code Version: 1.55.0-insider
OS Version: Darwin x64 20.3.0

Steps to Reproduce:
When using ThemeIcon('folder') as a tree item's iconPath, the folder icon doesn't appear. This isn't the case for other codicons.

Here's a simple extension that demonstrates this: https://github.com/wwlorey/icon-example

Does this issue occur when all extensions are disabled?: N/A

Hi @wwlorey ,
Does the File Icon Theme you have selected on VS Code, has a folder icon (take a look at Explorer)?
I mean, by default you can choose between None, Minimal and Seti file icon themes, but only Minimal has a folder icon. So, if your current setting is defined to None or Seti (or any other theme that don't have a folder icon), those folder TreeItems will not show any icon at all.
Hope this helps

Looks like duplicate of https://github.com/microsoft/vscode/issues/119050
Let's close and continue the discussion there


How to show horizontal scrollbar

I have this tree

When is expanded a nested node it should be useful add a scrollbar on the bottom panel.
Strange case, but adding class "overflow-x" = auto it show another vertical scrollbar.
Please, how to add a scrollbar x ?

You can first add " white-space: nowrap" to ".vir-tree-node";
Add "overflow-x: auto" to the upper container of the root element ".vir-tree";
Try it out

@lycHub :  Thank's for your reply.
Unfortunately it seems don't working...


gd does not work with methods that ends with !

Observed behavior
In Clojure you generally puts an ! and the end of a function to indicate that it have side effects (like (ns/function! arg0 arg1)). However, if you do a gd in those functions, it first asks a Jump to: ns/function (note, without the !).
cider-find-var (, g g) works correctly in those cases, going directly to the function.
P.S.: This may be a more general issue, however I only tested it in Clojure.
Expected behavior
gd should works like , g g.
Steps to reproduce

Open CIDER REPL
Open Clojure buffer
Find a function with a ! in the end and g d it

System information

Click to expand

OS: gnu/linux (x86_64-pc-linux-gnu)
Emacs: 26.1 (abr 08, 2019)
Doom: 2.0.9 (HEAD -> develop, _upgrade/develop 52eed893 2019-04-24 13:01:53 -0400)
Graphic display: t (daemon: nil)
System features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES THREADS LIBSYSTEMD
Details:env bootstrapper: nil
elc count: 0
uname -a:  Linux 4.19.35 #1-NixOS SMP Wed Apr 17 06:38:55 UTC 2019 x86_64
modules:   (:feature eval (evil +everywhere) file-templates (lookup +docsets) snippets workspaces :completion company (ivy +fuzzy) :ui doom hl-todo indent-guides modeline nav-flash neotree ophints (popup +all +defaults) vc-gutter vi-tilde-fringe window-select :editor fold (format +onsave) multiple-cursors rotate-text :emacs dired electric eshell imenu term vc :tools ansible docker editorconfig flycheck magit make rgb terraform :lang cc clojure data elixir emacs-lisp hy javascript markdown nix (org +attach +babel +capture +export +present) python ruby (sh +zsh) web :config default)
packages:  (company-emoji evil-lisp-state flymd lispyville sort-words uuidgen xterm-color (frame-fns :recipe (frame-fns :fetcher github :repo emacsmirror/frame-fns)) (frame-cmds :recipe (frame-cmds :fetcher github :repo emacsmirror/frame-cmds)) (zoom-frm :recipe (zoom-frm :fetcher github :repo emacsmirror/zoom-frm)))
exec-path: (~/dev/nu/ios-cli ~/dev/nu/nucli ~/dev/nu/nudev ~/.npm-packages/bin ~/.emacs.d/bin ~/.local/bin /nix/store/xf59s14j0x8l34agxiq6n1rn54wia3b1-kitty-0.13.3/bin /nix/store/4y5lv3a8s42wd0w0wga9sfflf6x0s5wg-imagemagick-6.9.9-34/bin /nix/store/k1gmlgblqqywmnzqxzlm0a2473r14zx5-xsel-unstable-2018-01-10/bin ~/bin /run/wrappers/bin ~/.nix-profile/bin /nix/var/nix/profiles/default/bin /run/current-system/sw/bin /etc/profiles/per-user/thiagoko/bin /nix/store/z6x936aa6kfnwpz8fb34z28qng5prrp9-emacs-26.1/libexec/emacs/26.1/x86_64-pc-linux-gnu)

This appears to either:

Be a cider issue with cider-find-dwim, which uses cider--find-dwim-interactive to prompt you and grabs the symbol at point with (thing-at-point 'filename) (which won't capture the ! in the symbol name) instead of (thing-at-point 'symbol) (which would).
Be an issue with Doom's choice to use cider-find-dwim for gd. Is this not the correct command to use to jump to definitions? Should Doom use cider-find-var instead? If so, will that work with symbols other than variables?

It also doesn't work correctly with functions ending with ? (used to mark predicates in Clojure) with same observed behavior.
cider-find-dwim is supposed to be a more generic version of the cider-find-var, which jumps not only into vars, but also into (file) resources/keywords/namespaces. But it looks like it actually doesn't support keywords & namespace jumping at the moment, so by switching to the cider-find-var we won't lose much. It's quite subjective, but ability to quickly jump into the side effecting functions & predicates is much more useful than ability to jump into resources.

This does seem like an upstream issue, but I'll incorporate a temporary fix. Before I do, could you check if this resolve the issue:
(defun +clojure-lookup-definition-handler (symbol)
  (interactive (list (+lookup--symbol-or-region)))
  (cider-find-dwim symbol))

(after! cider
  (set-lookup-handlers! 'cider-mode
    :definition #'+clojure-lookup-definition-handler
    :documentation #'cider-doc))

@hlissner gd works correctly for me with you workaround applied :+1:

I've incorporated this workaround in 237e14a. Let me know if the issue persists and I'll reopen this. Thanks for bringing it to my attention!

@hlissner sorry, I had local changes (namely switch of gd to cider-find-var instead of cider-find-dwim) I forgot about :man_facepalming: With clean checkout of config without the local customization jumping still doesn't work for vars with trailing ! / ? even with your workaround.

@hlissner @gsnewmark Seems the new workaround work for me. I will test more today and report it back if it doesn't work.

:see_no_evil: just tried it in another Clojure project and now it works for me too, not sure why it stopped working earlier today.


Error on add API key

There is 403 error on add API key: 'algoliasearch.exceptions.RequestException: Invalid Application-ID or API key'
Used admin APi key to send request. Key was been regenerated - problem same.
Same situation for javascript ('algoliasearch' lib v4.20) and python (3.11) API.
Sample:
params = {
'maxQueriesPerIPPerHour': 100,
}
acl = ['search']
res = client.add_api_key(acl, params)

From the documentation: You can’t generate secured API keys from your Admin API key or from other secured API keys.
https://www.algolia.com/doc/api-reference/api-methods/generate-secured-api-key/


Issue 575 fix no content exceptions

This is a fairly hacky fix, but it does resolve the immediate issue.
AFAICT, the root issue is that the app_iter does not have the custom content in it so when it builds the response body it renders nothing. However, the default app_iter does is able to get that information somehow when it builds the response body from the app_iter.
A better solution might be to include the response object in the custom app_iter and checking for custom properties on the response once we're done iterating over the app_iter.

@maeivysea Should this be closed now that you've addressed the issue elsewhere?

@RyanBalfanz Thank you!! Yes, this can be closed. Issue 575 was closed by PR #739


Adds Downloader.

Downloads from URL to a file. This will be used to auto-download skaffold.

sorry to drop in, but just curious - will this be released as a standalone jar so that other tools can take advantage of this feature?

@etanshaul We did not plan on this but we definitely could. It would have a lot of functionality that would be useful in other tooling.

@coollog great! we can discuss more offline. thanks.


Pressing enter in the privacy modal just closes the modal

A user would expect that the enter key applies the change, at least for the case of "password-protected" maps where a keyboard input is expected.
In the other cases, a privacy option can be selected but pressing enter doesn't apply them.

Not sure if this is an expected behaviour :smile:  cc @viddo @xavijam @saleiva
Edit: the behaviour happens in dataset privacy modal and map privacy modal.

Good catch. @viddo add to this milestone or the next one depending when you wanna approach this modal for the new editor and the dashboard :)

Thanks for reporting!
I'll add to next sprint. I'll have a look this sprint if I get time over.


change boringssl resource from googlesource to github

Due to the network issue in China, the https://boringssl.googlesource.com/boringssl can not be downloaded while using Bazel. So I suggest to change it to a github mirror https://github.com/google/boringssl.git.

Can one of the admins verify this patch?

I signed it!

@tensorflow-jenkins test this please


Torque scrubber gets crazy after changing column

After changing the target column in a time-series widget linked to a Torque animation, the scrubber loses its reference and moves in a wrong position.
Steps to Reproduce

Select a layer and style it to animated.
Go to Widgets tab.
Select the created time-series widget.
Change the column. In the example it changed from a number to a date one.

Current Result
The scrubber moves off-screen.
Expected result
The scrubber moves back to the first position in the widget and continues moving from there.

Stale issue. Closing 👋


Debug

Care to give some more information @YasserAlShafei? :)

Closing this for now. Feel free to reopen if you have some more info

Ok
الحصول على Outlook for Androidhttps://aka.ms/ghei36

From: Yonas Kolb<EMAIL_ADDRESS>Sent: Wednesday, October 2, 2019 2:36:31 AM
To: yonaskolb/XcodeGen<EMAIL_ADDRESS>Cc: YasserAlShafei<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [yonaskolb/XcodeGen] Debug (#668)
Care to give some more information @YasserAlShafeihttps://github.com/YasserAlShafei? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/yonaskolb/XcodeGen/issues/668?email_source=notifications&email_token=AKMTZO2JF2EV2TD5XOVTAY3QMPNH7A5CNFSM4I4PVPDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADCRBQ#issuecomment-537274502, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKMTZO4YXZL2P2YL5AU5BRLQMPNH7ANCNFSM4I4PVPDA.


Update ConMon POAM and send to PMO

In order for our compliance documents to align with each other, which helps our compliance reviewers understand the status of our system, we need to correct our December ConMon POAM based on the SAR.
See email from Bridget on 12/5, a reply with subject line "Uploaded ConMon materials", for details about corrections we need to make.
We should do this soon (this week), but after the SAR POAM and updated SSP.
Acceptance criteria

[x] We've updated our ConMon POAM in Google Drive here.
[x] We've exported a copy, named it with the date, uploaded it to the POAM folder on MAX, and emailed our PMO to let them know we've done that.

Sent a corrected version + an email based on my best understanding of what needed correction.


Better html tag formatting

Brackets' auto-complete function works good enough, only one thing bothers me: after I get a new tag pair, if I hit enter to jump to next line, the closing tag follows the cursor to the next line, but I prefer the closing tag go to the third line  align with the opening tag, and the cursor stays at the second line. As showed below:
The way brackets behaves now:

The way I want it to be:

    //cursor

I'm new to programming and brackets, if this issue has been resolved in upcoming 1.6 then ... nevermind

This seems to be working correctly on the CloseTag demo with most tags ( not included, as they are usually meant to be one liners...) but I cannot repeat either of the ways in Brackets myself.


Refactor code duplicated between ciao-down and launcher

Ciao-down contained a number of functions that were copied directly from launcher.    These functions have been moved to different packages:

The existing qemu package
The new deviceinfo package

Launcher and ciao-down have been modified to use the functions in these packages.

@sameo I'm adding a new file with one function to the qemu package in this PR in an effort to reduce code duplication between ciao-launcher and ciao-down. Any objections?

Coverage decreased (-0.1%) to 66.618% when pulling 29b8028b741245f8fb3a51e388643fba1d5157a5 on markdryan:share-code into 1a840480a0dd9b3c0c1ec8ecc355a650fa41bff7 on 01org:master.

@markdryan @rbradford LGTM

Passed all BAT tests:
rob@singlevm:~/src/go/src/github.com/01org/ciao/_release/bat$ test-cases ./...