[wip] Use v1alpha3 for LDSv2

This is a full clean up of the existing LDSv2 code to switch to v1alpha3, use CDSv2 and RDSv2.
Several things have been disabled for now (authentication, mixer, management ports).
This code is untested, but I am opening a PR so that others are aware, and possibly could test.
This is likely to conflict with what @ostromart is doing. So, once his changes go in, I will absorb those changes in this PR.
Signed-off-by: Shriram Rajagopalan<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vadimeisenbergibm
Assign the PR to them by writing /assign @vadimeisenbergibm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
c6ee8cbf90a72d5cfd8676c64fd76413d3905f2b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
c6ee8cbf90a72d5cfd8676c64fd76413d3905f2b
link
/test istio-presubmit

prow/istio-unit-tests.sh
c6ee8cbf90a72d5cfd8676c64fd76413d3905f2b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The real question is: does it pass the e2e tests? :)
On Thu, Mar 22, 2018, 6:50 PM Shriram Rajagopalan<EMAIL_ADDRESS>wrote:

@rshriram https://github.com/rshriram requested your review on:
istio/istio#4496 https://github.com/istio/istio/pull/4496 [wip] Use
v1alpha3 for LDSv2.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/4496#event-1536950618, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AJGIxiTD9JRVK8vYB39GCszyJxzANDNxks5thFTggaJpZM4S4DPn
.

how can it pass when your code is so incomplete?

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
7b0516ab6e12701e63c6f37e55423b9d7ec0e3d5
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
7b0516ab6e12701e63c6f37e55423b9d7ec0e3d5
link
/test istio-unit-tests

prow/istio-presubmit.sh
7b0516ab6e12701e63c6f37e55423b9d7ec0e3d5
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
07a93083da6767604c961573d67e0fb2fdff10dd
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
07a93083da6767604c961573d67e0fb2fdff10dd
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
07a93083da6767604c961573d67e0fb2fdff10dd
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
07a93083da6767604c961573d67e0fb2fdff10dd
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
07a93083da6767604c961573d67e0fb2fdff10dd
link
/test istio-pilot-e2e-v1alpha3

prow/istio-unit-tests.sh
df49dbd041f7fa56ee9c3e057955cc57ac3bba7e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
07a93083da6767604c961573d67e0fb2fdff10dd
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
07a93083da6767604c961573d67e0fb2fdff10dd
link
/test istio-pilot-e2e-v1alpha3

prow/istio-unit-tests.sh
df49dbd041f7fa56ee9c3e057955cc57ac3bba7e
link
/test istio-unit-tests

prow/istio-presubmit.sh
df49dbd041f7fa56ee9c3e057955cc57ac3bba7e
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
07a93083da6767604c961573d67e0fb2fdff10dd
link
/test istio-pilot-e2e-v1alpha3

prow/istio-unit-tests.sh
df49dbd041f7fa56ee9c3e057955cc57ac3bba7e
link
/test istio-unit-tests

prow/istio-presubmit.sh
df49dbd041f7fa56ee9c3e057955cc57ac3bba7e
link
/test istio-presubmit

prow/istio-pilot-e2e.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
df49dbd041f7fa56ee9c3e057955cc57ac3bba7e
link
/test istio-unit-tests

prow/istio-presubmit.sh
df49dbd041f7fa56ee9c3e057955cc57ac3bba7e
link
/test istio-presubmit

prow/istio-pilot-e2e.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
df49dbd041f7fa56ee9c3e057955cc57ac3bba7e
link
/test istio-presubmit

prow/istio-pilot-e2e.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-unit-tests.sh
01d3d415dad3b0ba68bf8f0ef18a6b7c1f425cbc
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-unit-tests.sh
01d3d415dad3b0ba68bf8f0ef18a6b7c1f425cbc
link
/test istio-unit-tests

prow/istio-presubmit.sh
01d3d415dad3b0ba68bf8f0ef18a6b7c1f425cbc
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-presubmit.sh
01d3d415dad3b0ba68bf8f0ef18a6b7c1f425cbc
link
/test istio-presubmit

prow/istio-unit-tests.sh
ef2de001b7575a5998d271a9520ec6a7e1808922
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-unit-tests.sh
ef2de001b7575a5998d271a9520ec6a7e1808922
link
/test istio-unit-tests

prow/istio-presubmit.sh
ef2de001b7575a5998d271a9520ec6a7e1808922
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
c89f1a2495e2924acd2ba4274a0227a0120ae826
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
48f27faaf39a1b9fa2493e66a74ecc3d930707c0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
c89f1a2495e2924acd2ba4274a0227a0120ae826
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
312256dba5555932d2ee4af4d203ea2bfa5ad47b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
c89f1a2495e2924acd2ba4274a0227a0120ae826
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
312256dba5555932d2ee4af4d203ea2bfa5ad47b
link
/test istio-unit-tests

prow/istio-presubmit.sh
312256dba5555932d2ee4af4d203ea2bfa5ad47b
link
/test istio-presubmit

prow/istio-pilot-e2e-v1alpha3.sh
c89f1a2495e2924acd2ba4274a0227a0120ae826
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
c89f1a2495e2924acd2ba4274a0227a0120ae826
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
c89f1a2495e2924acd2ba4274a0227a0120ae826
link
/test istio-pilot-e2e-v1alpha3

prow/istio-unit-tests.sh
cf082b31cc9255832bfb1029a08b3f325e6a2109
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
c89f1a2495e2924acd2ba4274a0227a0120ae826
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
c89f1a2495e2924acd2ba4274a0227a0120ae826
link
/test istio-pilot-e2e-v1alpha3

prow/istio-unit-tests.sh
cf082b31cc9255832bfb1029a08b3f325e6a2109
link
/test istio-unit-tests

prow/istio-presubmit.sh
cf082b31cc9255832bfb1029a08b3f325e6a2109
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
58f2367d8f0fd849d3300b554cf5f7ad03ec07b9
link
/test istio-pilot-e2e-v1alpha3

prow/e2e-bookInfoTests.sh
58f2367d8f0fd849d3300b554cf5f7ad03ec07b9
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
bb65f3e147336b8793528b8a06e73da47beb575b
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
58f2367d8f0fd849d3300b554cf5f7ad03ec07b9
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
bb65f3e147336b8793528b8a06e73da47beb575b
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
bb65f3e147336b8793528b8a06e73da47beb575b
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
bb65f3e147336b8793528b8a06e73da47beb575b
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
bb65f3e147336b8793528b8a06e73da47beb575b
link
/test istio-pilot-e2e-v1alpha3

prow/istio-unit-tests.sh
32784e97f0102d7030ad22e630c527b01ffc4b48
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
bb65f3e147336b8793528b8a06e73da47beb575b
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
bb65f3e147336b8793528b8a06e73da47beb575b
link
/test istio-pilot-e2e-v1alpha3

prow/istio-unit-tests.sh
32784e97f0102d7030ad22e630c527b01ffc4b48
link
/test istio-unit-tests

prow/istio-presubmit.sh
32784e97f0102d7030ad22e630c527b01ffc4b48
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Here is the test output for LDS response from v1alpha3

	lds_test.go:67: LDS response {
		 "versionInfo": "2018-03-26 11:19:39.494496477 -0400 EDT m=+0.043571016",
		 "resources": [
		  {
		   "@type": "type.googleapis.com/envoy.api.v2.Listener",
		   "name": "virtual",
		   "address": {
		    "socketAddress": {
		     "address": "<IP_ADDRESS>",
		     "portValue": 15001
		    }
		   },
		   "filterChains": [
		    {
		     "filters": [
		      {
		       "name": "envoy.tcp_proxy",
		       "config": {
		         "cluster": "Dummy",
		         "stat_prefix": "Dummy"
		        }
		      }
		     ]
		    }
		   ],
		   "useOriginalDst": true
		  },
		  {
		   "@type": "type.googleapis.com/envoy.api.v2.Listener",
		   "name": "http_<IP_ADDRESS>_80",
		   "address": {
		    "socketAddress": {
		     "address": "<IP_ADDRESS>",
		     "portValue": 80
		    }
		   },
		   "filterChains": [
		    {
		     "filters": [
		      {
		       "name": "envoy.http_connection_manager",
		       "config": {
		         "access_log": [
		            {
		               "config": {
		                  "path": "/dev/stdout"
		                 },
		               "name": "envoy.file_access_log"
		              }
		           ],
		         "generate_request_id": true,
		         "http_filters": [
		            {
		               "name": "envoy.cors"
		              },
		            {
		               "name": "envoy.router"
		              }
		           ],
		         "rds": {
		            "config_source": {
		               "api_config_source": {
		                  "cluster_names": [
		                     "rds"
		                    ],
		                  "refresh_delay": "0.000s"
		                 }
		              },
		            "route_config_name": "80"
		           },
		         "stat_prefix": "http",
		         "tracing": {
		            "operation_name": "EGRESS"
		           },
		         "use_remote_address": false
		        }
		      }
		     ]
		    }
		   ],
		   "deprecatedV1": {
		    "bindToPort": false
		   }
		  },
		  {
		   "@type": "type.googleapis.com/envoy.api.v2.Listener",
		   "name": "http_<IP_ADDRESS>_81",
		   "address": {
		    "socketAddress": {
		     "address": "<IP_ADDRESS>",
		     "portValue": 81
		    }
		   },
		   "filterChains": [
		    {
		     "filters": [
		      {
		       "name": "envoy.http_connection_manager",
		       "config": {
		         "access_log": [
		            {
		               "config": {
		                  "path": "/dev/stdout"
		                 },
		               "name": "envoy.file_access_log"
		              }
		           ],
		         "generate_request_id": true,
		         "http_filters": [
		            {
		               "name": "envoy.cors"
		              },
		            {
		               "name": "envoy.router"
		              }
		           ],
		         "rds": {
		            "config_source": {
		               "api_config_source": {
		                  "cluster_names": [
		                     "rds"
		                    ],
		                  "refresh_delay": "0.000s"
		                 }
		              },
		            "route_config_name": "81"
		           },
		         "stat_prefix": "http",
		         "tracing": {
		            "operation_name": "EGRESS"
		           },
		         "use_remote_address": false
		        }
		      }
		     ]
		    }
		   ],
		   "deprecatedV1": {
		    "bindToPort": false
		   }
		  },
		  {
		   "@type": "type.googleapis.com/envoy.api.v2.Listener",
		   "name": "Mongo_<IP_ADDRESS>_100",
		   "address": {
		    "socketAddress": {
		     "address": "<IP_ADDRESS>",
		     "portValue": 100
		    }
		   },
		   "filterChains": [
		    {
		     "filters": [
		      {
		       "name": "envoy.mongo_proxy",
		       "config": {
		         "stat_prefix": "mongo"
		        }
		      },
		      {
		       "name": "envoy.tcp_proxy",
		       "config": {
		         "deprecated_v1": {
		            "routes": [
		               {
		                  "cluster": "outbound|mongo||hello.default.svc.cluster.local",
		                  "destination_ip_list": [
		                     {
		                        "address_prefix": "<IP_ADDRESS>",
		                        "prefix_len": 32
		                       }
		                    ]
		                 }
		              ]
		           },
		         "stat_prefix": "outbound|tcp|100"
		        }
		      }
		     ]
		    }
		   ],
		   "deprecatedV1": {
		    "bindToPort": false
		   }
		  },
		  {
		   "@type": "type.googleapis.com/envoy.api.v2.Listener",
		   "name": "Redis_<IP_ADDRESS>_110",
		   "address": {
		    "socketAddress": {
		     "address": "<IP_ADDRESS>",
		     "portValue": 110
		    }
		   },
		   "filterChains": [
		    {
		     "filters": [
		      {
		       "name": "envoy.tcp_proxy",
		       "config": {
		         "deprecated_v1": {
		            "routes": [
		               {
		                  "cluster": "outbound|redis||hello.default.svc.cluster.local",
		                  "destination_ip_list": [
		                     {
		                        "address_prefix": "<IP_ADDRESS>",
		                        "prefix_len": 32
		                       }
		                    ]
		                 }
		              ]
		           },
		         "stat_prefix": "outbound|tcp|110"
		        }
		      }
		     ]
		    }
		   ],
		   "deprecatedV1": {
		    "bindToPort": false
		   }
		  },
		  {
		   "@type": "type.googleapis.com/envoy.api.v2.Listener",
		   "name": "TCP_<IP_ADDRESS>_90",
		   "address": {
		    "socketAddress": {
		     "address": "<IP_ADDRESS>",
		     "portValue": 90
		    }
		   },
		   "filterChains": [
		    {
		     "filters": [
		      {
		       "name": "envoy.tcp_proxy",
		       "config": {
		         "deprecated_v1": {
		            "routes": [
		               {
		                  "cluster": "outbound|custom||hello.default.svc.cluster.local",
		                  "destination_ip_list": [
		                     {
		                        "address_prefix": "<IP_ADDRESS>",
		                        "prefix_len": 32
		                       }
		                    ]
		                 }
		              ]
		           },
		         "stat_prefix": "outbound|tcp|90"
		        }
		      }
		     ]
		    }
		   ],
		   "deprecatedV1": {
		    "bindToPort": false
		   }
		  }
		 ],
		 "typeUrl": "type.googleapis.com/envoy.api.v2.Listener",
		 "nonce": "2018-03-26 11:19:40.504940942 -0400 EDT m=+1.054016017"
		}

Process finished with exit code 0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


change dashboards 's timezone to null

Description
Change Grafana dashboard timezone to browser from utc, users can see dashboard with the local time.

What's the benefit of having the default being "" vs. "utc"?

What's the benefit of having the default being "" vs. "utc"?
with "utc" the timezone is fixed, with "" the timezone can be changed in user's profile. Sometimes when I investigate problem, it's little bit confusing what time it is :).


Other repo's is calling your https://gpvc.arturio.dev/ API as a refresh page...

Hi there...
I was trying to implement some self hosted counter, but when got to see some examples, saw that some repo's we find call your API a refresh call on the url...
EX: https://turnipguy30.github.io/Celebi/

<!doctype html>

html lang="en" dir="ltr">
head>
meta charset="utf-8" http-equiv="refresh" content="0; URL=armand-morin.html">
link rel="icon" href="../images/celebi.png">
title>armand-morin | Celebi
style>@import url("../styles/index.css");
/head>
body>
h1>armand-morin
img src="https://gpvc.arturio.dev/armand-morin">
/body>
/html>

I saw that the number keeps getting up if I stay some time in the site, and thought that you don't have caching on your code.
Didn't know a lot about that, but maybe this could help with server issues...

Yes there is no cache as it would prevent counter from going up :)
Currently workflow is like -> github image (uncached) -> my api
If the github image would be cached my api wouldn't receive request & counter wouldn't go up.


Make output buffer a single String

Objective
Closes #25.
Currently, we use a Vec<String> to buffer the process output.
This introduces additional indirection and allocations as we have a list of heap-allocated structures.
Solution
Change the buffer to be a single String that we append to.
This should reduce the number of needed allocations.
Additionally, we make the output of ProcessOutput private and instead introduce some utility functions to use the process output.
Now you can simply write output.lines() to iterate over all lines sent by the process.

I believe that once merged, we can trigger another release.
I also think that bevy_local_commands is in a great state already and very usable.
Perhaps we can make another announcement in the Bevy Discord after this release.


Time zone is really necessary?

Time zone is really necessary? I am going to build a docker file but it freeze here.
debconf: (TERM is not set, so the dialog frontend is not usable.)
debconf: falling back to frontend: Readline
Configuring tzdata
------------------

Please select the geographic area in which you live. Subsequent configuration
questions will narrow this down by presenting a list of cities, representing
the time zones in which they are located.

  1. Africa      4. Australia  7. Atlantic  10. Pacific  13. Etc
  2. America     5. Arctic     8. Europe    11. SystemV
  3. Antarctica  6. Asia       9. Indian    12. US
Geographic area: Asia

6
Tokyo
^C

Why you make it difficulties here? if it is necessary please give better documentation, How can I write your command for different region!!!!
please send a link, where I can learn your command!!

This is not docker asking for the input, but the tzdata package on Debian and Ubuntu which, when installing, defaults to an interactive installation and asks for this input in some cases.
To force packages to be install non-interactively on Debian and Ubuntu, you can use the DEBIAN_FRONTEND=noninteractive environment variable. You can set this in your Dockerfile when installing the package, for example;
FROM ubuntu:20.04
RUN apt-get update &&  DEBIAN_FRONTEND=noninteractive apt-get install -y tzdata

Or you can use a ARG instruction to set the environment variable; by using an ARG for this (instead of ENV) the env-var does not end up in the final image; to prevent the default behavior of apt-get to be changed to "non-interactively".
FROM ubuntu:20.04
ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y tzdata

Perhaps we should describe this in https://docs.docker.com/develop/dev-best-practices/ or https://docs.docker.com/develop/develop-images/dockerfile_best-practices/


duplicate class errors with the alarm plugin and Flutter_fgbg

alarm 1.2.1
Describe the bug
I have big problems with the plugin and get duplicate class errors. There seems to be a conflict between alarm 1.2.1 and Flutter_fgbg
To Reproduce
Steps to reproduce the behavior:

just installed alarm 1.2.1

Expected behavior
*Find a solution for this issue:
ERROR: C:\scr\flutter\projects\smartabox_app\build\alarm.transforms\3f03b4caccdeb316d77f1a14c56b987c\transformed\classes\classes.dex: D8: Type com.example.smartabox_app.BuildConfig is defined multiple times: C:\scr\flutter\projects\smartabox_app\build\alarm.transforms\3f03b4caccdeb316d77f1a14c56b987c\transformed\classes\classes.dex, C:\scr\flutter\projects\smartabox_app\build\flutter_fgbg.transforms\259e6456fa506c18132e02beab7ce5be\transformed\classes\classes.dex *
Screenshots
**
Device info
Provide device info (Manufacturer, OS version, ...)
Ex: iPhone 13 Pro, iOS 16.2, ...
Provide device info (Manufacturer, OS version, ...)
Provide device info (Manufacturer, OS version, ...)
Ex: iPhone 13 Pro, iOS 16.2, ...
Additional context
Add any other context about the problem here.
Ex: iPhone 13 Pro, iOS 16.2, ...
Additional context
Add any other context about the problem here.
Additional context
Add any other context about the problem here.

Hi @Flash0509
Sorry to hear about your issue.

Do you use flutter_fgbg in your project ?

Have you tried doing:

flutter pub get
flutter clean
flutter run

At what moment do you have this error ?

Hi Gautier, thanks for your anwer.

Actually, I didn't use flutter_fgbg in my project. But alarm 1.2.1. installed it as an dependency as version 0.2.2.

Thousand times

When I try flutter run

Thanks for the answer @Flash0509,
I'll try to publish a fix as soon as possible.
In the meantime, please make sure you:

followed the instruction steps in the README
your package name in AndroidManifest.xml is consistent with the applicationId in the app/build.gradle file. They should be unique and consistent across your app
try to update manually flutter_fgbg to version 0.3.0 in your pubspec.lock
if you need to use alarm right now, try downgrading the version in your project until you reach a version that works

Let me know if it helps. Otherwise, stay tuned and I'll release a fix next week.

b
thanks for your new respond.

Where can I find the README?
It is checked, but unfortunaltley the gradle project sync failed with the error:' Task 'wrapper' not found in project ':app'."
I tried this and started the command Flutter run, but The error message (duplicate class) is still the same.

README:
https://github.com/gdelataillade/alarm/blob/main/README.md

I have some more issues when I activate the alarm related code parts in my app:

final` alarmSettings = AlarmSettings(
          id:42,
          dateTime: scheduledTime,
          assetAudioPath: 'assets/audio/alarm.mp3',
          loopAudio: true,
          vibrate: true,
          volumeMax: true,
          fadeDuration: 3.0,
          notificationTitle: 'Tabletten Erinnerung',
          notificationBody: 'Einnahmezeit für Fach ' + nextCompartmentNumber.toString() +
              ' erreicht. Bitte einnehmen!',
          enableNotificationOnKill: false,
          stopOnNotificationOpen: false);

      await Alarm.set(settings: alarmSettings);

      Alarm.ringStream.stream.listen((_) => checkNextCompartmentTime());

the error message appears, when I started flutter run. The app didn't start.
lib/main.dart:716:23: Error: No named parameter with the name 'settings'.
await Alarm.set(settings: alarmSettings);
^^^^^^^^
/C:/Users/gordo/AppData/Local/Pub/Cache/hosted/pub.dev/alarm-1.2.1/lib/alarm.dart:69:23: Context: Found this candidate, but the arguments don't match.
static Future set({required AlarmSettings alarmSettings}) async {
^^^
Target kernel_snapshot failed: Exception
FAILURE: Build failed with an exception.

I'm sorry I made a mistake in the README.
Alarm.set parameter name is alarmSettings instead of settings.
Try like this:
await Alarm.set(alarmSettings: alarmSettings);

Okay, code errors are gone, perfect! But of course the duplicate classes issue still exists. I am patiently waiting for your solution next week.

Hello Gautier,
any news concerning my issue?
Thanks in advance.
Kind regards,
Gordon Klein
smarTaBox GmbH | Franz-Liszt-Str. 87 | 14624 Dallgow-Döberitz
Telefon: 0172/3128877
@.*** @.***>
www.smartabox.de http://www.smartabox.de
Von: Gautier de Lataillade @.>
Gesendet: Mittwoch, 16. August 2023 23:33
An: gdelataillade/alarm @.>
Cc: Flash0509 @.>; Mention @.>
Betreff: Re: [gdelataillade/alarm] duplicate class errors with the alarm plugin and Flutter_fgbg (Issue #79)
I'm sorry I made a mistake in the README.
Alarm.set parameter name is alarmSettings instead of settings.
Try like this:
await Alarm.set(alarmSettings: alarmSettings);
—
Reply to this email directly, view it on GitHub https://github.com/gdelataillade/alarm/issues/79#issuecomment-1681298228 , or unsubscribe https://github.com/notifications/unsubscribe-auth/BB5GOYHXC6SCGUOHCH5K5HTXVU37LANCNFSM6AAAAAA3RK2YCU .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/BB5GOYANEZEZZH7XS64UVYTXVU37LA5CNFSM6AAAAAA3RK2YCWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTEG2JTI.gif Message ID: @.*** @.***> >

Hi @Flash0509
I was never able to reproduce your error. It seems like you are the only one. That means the issue comes probably from your project.
I asked ChatGPT what to do in your case, here's his answer:
Flutter Duplicate Class Error Solution
The error indicates that the BuildConfig class for your com.example.smartabox_app package is defined multiple times, typically resulting from conflicting dependencies or plugins in a Flutter project.
From your details, it's evident that both your main app and the alarm plugin use the flutter_fgbg plugin, leading to duplicate class definitions.
Solutions:
1) Exclude Modules in Build:
If using Gradle, you can exclude specific modules to avoid duplicate class definitions:
implementation ('com.example:alarm:1.0.0') {
    exclude group: 'com.example', module: 'flutter_fgbg'
}

2) Use Dependency Resolution Strategies:
Define a resolution strategy in your app's android/build.gradle:
configurations.all {
    resolutionStrategy {
        force 'com.example:flutter_fgbg:1.0.0' // replace with actual group:module:version
    }
}

This ensures only the specified version of flutter_fgbg is utilized.
3) Check for Unused Dependencies:
Review your dependencies. Remove any that are no longer in use to reduce potential future conflicts.
4) Clean and Rebuild:
Post changes, clean the build directory and rebuild:
flutter clean
flutter run

Please let me know if it works or if you still have an issue.


pyglet needs a full docstring review and cleanup

pyglet has gone through several documentation build tools in its life, leading to variation in the docstrings across the library.
Currently we use Sphinx to build the docs, which is capable of building a variety of formats. This works for the most part but, with recent additions of type hints across the library, there is a lot of inconsistency with how the API docs are rendering.
The purpose of this ticket is to get the ball rolling on a full review and refactoring of the docstrings. This can be done in multiple parts.

[x] Decide on a consistent style that we will use. This is currently under discussion, and includes looking at additional sphinx plugins that may improve things with regards to type hints.
[x] Update the section in the documentation that describes our desired docstring format. This is still referencing rst style, but will potentially change. This link is here, but will need to be updated after 1. is complete: https://pyglet.readthedocs.io/en/latest/internal/doc.html
[ ] Go through each module and update the docstrings to the new format. There are many cases where things are undocumented. It would be more time effective to skip over missing things at this time, and just focus on conversion. Many modules are still missing type hints as well, but again, it would be more time effective to leave this for later.

[x] app
[x] canvas
[x] clock
[x] customtypes
[x] event
[x] font
[ ] gl
[ ] graphics
[x] gui
[x] input
[ ] image
[ ] lib
[x] math
[x] media
[x] model
[x] resource
[x] sprite
[x] shapes
[x] text
[ ] window

Starting on shapes.

app and canvas base classes have been completed.

finished event

Finished sprite.

Finished the model module.

Working on media now.

First pass of media is done.

TL;DR: pyglet.libs is up for grabs

I've unexpectedly had much less free time & access to an ARM64 Mac than I'd planned
To make sure I don't block anyone or anything:

I PR'd my already-finished changes in #1108
I'm handing off further work on pyglet.libs to anyone who'd like to try

While reviewing my open issues v.s. issues here, I stumbled upon here and it struck a humble chord:
Maybe someone can obviate in PlatformEventLoop.notify's docstring whether this is a method that user code should ever call?
Do all docstrings end up on the online documentation, or is there a syntax which excludes a docstring for when it's too low level a class member?

Okay, read better above now, this is out of scope.

Working on image at the moment.

Window was done. I will work on graphics.

some cleanup in #1150

The image module has been done, and is part of this PR: https://github.com/pyglet/pyglet/pull/1179
With that, it looks like our first pass is complete. All public modules should have been looked over and improved. Some internal modules still remain, but we can get to those as time allows.
Thanks everyone for working on this!


Remove Python 2 Dependency

When attempting to install Lyrebird on Ubuntu 20.04, the package requires now-deprecated Python 2.7 packages. I think this is because of python-gobject. Is there any way to use Lyrebird without installing these packages?
user@comp:~$ sudo apt install ./Downloads/lyrebird_1.1.0-2.deb
[sudo] password for user:
Reading package lists... Done
Building dependency tree
Reading state information... Done
Note, selecting 'lyrebird' instead of './Downloads/lyrebird_1.1.0-2.deb'
The following additional packages will be installed:
  libpython2-stdlib libpython2.7-minimal libpython2.7-stdlib libsox-fmt-alsa libsox-fmt-base libsox-fmt-pulse libsox3
  python-gi python-gobject python-gobject-2 python2 python2-minimal python2.7 python2.7-minimal python3-toml sox
Suggested packages:
  libsox-fmt-all python-gi-cairo python-gobject-2-dbg python2-doc python-tk python2.7-doc binfmt-support
The following NEW packages will be installed:
  libpython2-stdlib libpython2.7-minimal libpython2.7-stdlib libsox-fmt-alsa libsox-fmt-base libsox-fmt-pulse libsox3
  lyrebird python-gi python-gobject python-gobject-2 python2 python2-minimal python2.7 python2.7-minimal python3-toml
  sox
0 upgraded, 17 newly installed, 0 to remove and 0 not upgraded.
Need to get 4,604 kB/4,641 kB of archives.
After this operation, 19.7 MB of additional disk space will be used.
Do you want to continue? [Y/n] n

user@comp:~$ apt show ./Downloads/lyrebird_1.1.0-2.deb
Package: lyrebird
Version: 1.1.0-2
Priority: optional
Section: base
Maintainer: Harry Stanton<EMAIL_ADDRESS>Installed-Size: unknown
Depends: python3 (>= 3.7.0), sox, python3-toml, python-gobject, pulseaudio, libsox-fmt-pulse
Download-Size: 37.0 kB
APT-Sources: /home/herzog/Downloads/lyrebird_1.1.0-2.deb
Description: Simple and powerful voice changer for Linux, written in GTK 3

user@comp:~$ apt show python-gobject
Package: python-gobject
Version: 3.34.0+2.28.6-14ubuntu1
Priority: optional
Section: universe/python
Source: pygobject-2 (2.28.6-14ubuntu1)
Origin: Ubuntu
Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Original-Maintainer: Josselin Mouette<EMAIL_ADDRESS>Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 123 kB
Depends: python-gi (>= 3.34.0), python-gobject-2 (>= 2.28.6-14ubuntu1)
Download-Size: 2,572 B
APT-Sources: http://us.archive.ubuntu.com/ubuntu focal/universe amd64 Packages
Description: Python 2.x bindings for GObject - transitional package
 This package will bring the two versions of GObject Python modules: the
 deprecated gobject module, and the new gobject-introspection system. It
 is here for upgrade purposes only. You can remove it safely when
 nothing else depends on it.

I'll take a closer look at this when I can. In the mean time if you don't mind going around your package manager you can install lyrebird using the installer script. There's an uninstaller bundled which will also do a cleanup if you want to remove it at a later date.
python-gobject has been the single most frustrating issue with Lyrebird. Every distro seems to bundle it differently and it has a tendency to break a lot.

I wish I knew more about the dependencies and their history. If it's helpful, I see that python-gobject depends on two packages, python-gi and python-gobject-2. There is a package in the repos for python3-gi. Maybe that would be the equivalent to try?
user@comp:~$ apt show python3-gi
Package: python3-gi
Version: 3.36.0-1
Priority: important
Section: python
Source: pygobject
Origin: Ubuntu
Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Original-Maintainer: Debian GNOME Maintainers<EMAIL_ADDRESS>Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 709 kB
Depends: gir1.2-glib-2.0 (>= 1.48.0), python3 (<< 3.9), python3 (>= 3.8~), python3:any, libc6 (>= 2.14), libffi7 (>= 3.3~20180313), libgirepository-1.0-1 (>= 1.62.0-4~), libglib2.0-0 (>= 2.53.1)
Homepage: https://wiki.gnome.org/Projects/PyGObject
Task: minimal
Download-Size: 165 kB
APT-Manual-Installed: no
APT-Sources: http://us.archive.ubuntu.com/ubuntu focal/main amd64 Packages
Description: Python 3 bindings for gobject-introspection libraries
 GObject is an abstraction layer that allows programming with an object
 paradigm that is compatible with many languages. It is a part of Glib,
 the core library used to build GTK+ and GNOME.
 .
 This package contains the Python 3 binding generator for libraries that
 support gobject-introspection, i. e. which ship a gir1.2-<name>-<version>
 package. With these packages, the libraries can be used from Python 3.

Yes nice find, that's probably the replacement! I'll take a look later and probably add it to the deb. It may also fix some other issues that PopOS and Mint are having right now.

This is now fixed in lyrebird_1.1.0-3.deb available under releases.

Sure enough! Works brilliantly. Thanks!

Awesome 😁


onSelect and onClose not called for Menu/MenuItem when content is more than a text node

RMWC or MDC?
RMWC
Bugs
onSelect and onClose not called for Menu/MenuItem when content is more than a text node
What RMWC Version are you using?
1.4.1
What browser(s) and React Version is this bug affecting?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36
What build system are you using?

Webpack

What are the steps to reproduce the bug?

Wrap a <span> with text and use that in a <MenuItem> Component.
Click on the text, not the negative space around the text. (You should be clicking on the )
Nothing happens, other than making the row gray.
Click around the text, so this time in the negative space.
Now the click handler is called and the dropdown menu is closed.

What is the expected behavior?
onSelect callback should be called. As should onClose.
What is the actual behavior?
Nothing happens.
Any other information you believe would be useful?
You can actually just go the to rmwc example site and navigate to the menu component. Then open your debug tools and change the content in the menu item from a text node (thats what is there in the example) to a <span> wrapping the text. Then try to click on the text as in the reproduction steps.

I just checked and this problem appears to be upstream. Please report it to MDC if you get a chance. You can repro on their demo page.
https://material-components-web.appspot.com/menu.html

I also came to the conclusion that this is upstream, basically replaced all the RMWC components with their rendered HTML. Annoying bug.
Did you report it @puopg ? If not I will and if you did could you paste the upstream issue link here for tracking please?

I did not end up reporting it to MDC unfortunately. All you man!

This appears to be fixed in MDC 37. Will be released with 1.8.

I closed the prematurely, this is indeed still an issue.

Fixed with the release of V5


Investigate memory quota issue on data import

Error R14 (Memory quota exceeded)

Moved to https://github.com/studentinsights/studentinsights/issues/11.


Add Zig 0.13 support

This pull-request allows temp.zig to compile with Zig 0.13, while not breaking anything for 0.12.
New .zig-cache directory added to gitignore, as well as minor refactoring of build.zig (coverage step was changed due to Zig change).

Released in https://github.com/abhinav/temp.zig/releases/tag/0.3.0

Sorry for the typo :grin:


Add java

https://github.com/aquaproj/aqua-registry/issues/858
https://github.com/halcyon/asdf-java

How can Java be used? I could not find java or jdk in aqua g -i:

java isn't supported.


Dockerfile needs GCC or alternative workaround

This could be me using things incorrectly, but on a fresh clone and install of docker tonight (I don't use it locally), the container cannot build.  I don't understand the whole picture, but it's something like

You require pylint, pylint requires asteroid, and asteroid requires typed_ast, and typed_ast needs GCC.

See "main" discussion here: https://github.com/PyCQA/pylint/issues/2291

I tried a couple of the fixes there but nothing I found actually got past the issue, and I just want to be able to run the tests.  So what I added to the Dockerfile:
--- a/Dockerfile
+++ b/Dockerfile
@@ -6,4 +6,6 @@ COPY . /src/pytest-raises

 WORKDIR /src/pytest-raises

+# typed_ast needs gcc, musl-dev provides limits.h
+RUN apk add --no-cache gcc musl-dev
 RUN pip install .[develop]

It takes probably noticeably longer to install gcc and musl-dev, though.  Basically, there seem to be a handful of solutions, but since I don't know much about docker (do I have to sudo make build after every change for sudo make test lol) I leave it to you.

Yeah, looks like this is a new dependency issue.  This is what I get for not being a bit stricter on test dependencies.  I will check it out.

This is what I get for not being a bit stricter on test dependencies.

Lol, I don't think I follow -- you only depend on pytest and pylint right?  This is a (very far) upstream change that affected a lot of projects, but using pylint is :+1: :slightly_smiling_face:
Good news is I think I have a reliable fix so that the docker image doesn't rebuild every time you want to make test with updated source code!  The idea came from this article, where they suggest copying a requirements.txt first, installing them, then copy the whole source folder.  So the diff above is bad because the installation of gcc musl-dev happens after the COPY for the whole source tree, meaning it reinstalled both every time (annoying to wait for).
The diff makes it look like everything changed, but really it's just a restructure to "simulate" copying over requirements.txt, because

There is no requirements.txt for this, you only need to install two things.
The existing setup.py cannot be used in isolation, so just copying setup.py and getting the egg_info for example won't work.

Basically, this is a valid solution, but if you ever change dependencies you're currently in a position where you have to change two files now.  Not ideal, but least-impactful change:
FROM python:3.6-alpine

RUN apk add --no-cache git
RUN apk add gcc musl-dev

# Install dependencies first before copying full tree
# so docker does not re-install everything each time
# a test file is changed.
RUN mkdir -p /src/pytest-raises
RUN python3 -m pip install pytest>=3.2.2
RUN python3 -m pip install pylint==1.7.2

# Changes to source should have docker build cached up to here
WORKDIR /src/pytest-raises
COPY . /src/pytest-raises
RUN pip install .[develop]

Would you like a PR with this?  I tried to include the reasoning behind all decisions because as stated docker is unfamiliar to me.  If you would like a PR (heads up, another one I'm really excited about inbound too)

Yes vs no about pinning install versions in the Dockerfile.  Are those the right versions for you if so?
python3 -m pip vs pip.  I don't know alpine, is their a concern that pip may point to python2 somehow on this distro or is that the point?  Right now the above is inconsistent with existing pip install .[develop], I'd like to make them be consistent in the PR :upside_down_face:

Sorry this is such a long response, I'll add a PR if it looks good to you / with some answers!

Thanks for looking into this and submitting such a detailed response and PR.  I've gone through it a bit, and will try to finish my review tomorrow.

Sure thing! There's no rush on my end, now that it's on a fork somewhere I can pip install using git. It seems that currently setting outcome.excinfo in all cases is not currently supported. The pytest / pluggy folks may be able to create an official solution so I think it makes sense to wait and see what they feel is appropriate. This is a rather minute use case that they may not feel is worth the overhead to support.

I think this looks really good.  I'm going to merge it, and we can deal with the issues around outcome.excinfo as we figure out a good solution to it.

@Lemmons works for me :slightly_smiling_face:
I didn't actually add anything to the README discussing the new additions. I'll add a PR this weekend for that. Would you also like to use codecov.io? I can add the relevant stuff in Travis yaml if the repo owner adds the repo to codecov.
If you aren't sure about that I'll just do a README PR :+1:

@svenevs I added codecov.io support and the badge: see #15


Fixed bug in music VAE training script with make_one_shot_iterator

tf.data.Dataset.make_one_shot_iterator() was deprecated in V1 and removed from V2, replaced with tf.compat.v1.data.make_one_shot_iterator()
See this issue for more details
Closes #1699

@googlebot I signed it!


Getting invalid tag in Ethernet/IP protocol

Trying to connect to Allen's Bradley plc device using Ethernet IP protocol. Test connection is successful, however, I am unable to read it after passing the tag.
I am using edit inline to add the tag with the name 'hello' as below:
Alias: Test
Address: %hello
I tried without % also in the address, however, it's throwing error: invalid tag.

According to PLC4X documentation the address format should be:
%{tagname}[{startIndex}]:{numberOfElements}
%{tagname}[{startIndex}]:{numberOfElements}:{DataType}

on the other hand, the regex in the sourcecode states:
private static final Pattern ADDRESS_PATTERN =
        Pattern.compile("^%(?<tag>[a-zA-Z_.0-9]+\\[?[0-9]*\\]?):?(?<dataType>[A-Z]*):?(?<elementNb>[0-9]*)");

Looks like the documentation is not that accurate.
The backslash seems mandatory. So maybe you could try the address %hello\

Maybe the PLC4x documentation is not up to date. See: PLC4X issue 1481


Can`t generate SSH key (CS50)

Generated my SSH key. Computer shut down while copying it. Tried the steps again  -> command not found. Now i`m not able to assign SSH key.
Version: 1.70.2
Commit: e4503b30fc78200f846c62cf8091b76ff5547662
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:103.0) Gecko/20100101 Firefox/103.0
Embedder: codespaces

What is CS50?

What is CS50?
Harvard course

Please raise the issue with the course's support services.
/question

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


parsing a 3.1.0 spec schema puts single non-array value type into types array

High priority
swagger-parser version: 2.1.1
parsing a 3.1.0 spec schema puts single type into types array
When parsing the below spec, the first allof schema in AllofWithTheLastEmptySchema is defined as:
type: number

But the parser sets schema.type to null and loads that type into an array of length one in the types property.
A lot of existing code assumes that type will have a value for this use case.
This bug stops that code from working.
types going into the type or types property should be deterministic (should always behave the same way)
sometimes a single type is going into type
sometimes a single type is going into types (when not defined as an array of types)
See the schema's value here:
class JsonSchema {
    class Schema {
        type: [number]
        format: null
        $ref: null
        description: null
        title: null
        multipleOf: null
        maximum: null
        exclusiveMaximum: null
        minimum: null
        exclusiveMinimum: null
        maxLength: null
        minLength: null
        pattern: null
        maxItems: null
        minItems: null
        uniqueItems: null
        maxProperties: null
        minProperties: null
        required: null
        not: null
        properties: null
        additionalProperties: null
        nullable: null
        readOnly: null
        writeOnly: null
        example: null
        externalDocs: null
        deprecated: null
        discriminator: null
        xml: null
        patternProperties: null
        contains: null
        $id: null
        $anchor: null
        $schema: null
        const: null
        contentEncoding: null
        contentMediaType: null
        contentSchema: null
        propertyNames: null
        unevaluatedProperties: null
        maxContains: null
        minContains: null
        additionalItems: null
        unevaluatedItems: null
        _if: null
        _else: null
        then: null
        dependentRequired: null
        dependentSchemas: null
        $comment: null
        prefixItems: null
    }
}

spec:
openapi: 3.1.0
servers:
- url: https://someserver.com/v1
info:
  title: openapi 3.1.0 sample spec
  version: 0.0.1
  description: sample spec for testing openapi functionality, built from json schema
    tests for draft2020-12
tags: []
paths: {}
components:
  schemas:
    AllofWithTheLastEmptySchema:
      $schema: https://json-schema.org/draft/2020-12/schema
      allOf:
      - type: number
      - {}

A lot of existing code assumes that type will have a value for this use case.
This bug stops that code from working.
types going into the type or types property should be deterministic (should always behave the same way)
sometimes a single type is going into type
sometimes a single type is going into types (when not defined as an array of types)

Current behavior is by design, it is deterministic and depends on the OAS version of the document, check this comment for details also about discouraged option since latest version to allow having type getter return single element , and this test demonstrating current behavior with your example doc.
Closing ticket, please reopen if you're still experiencing issues
P.S. marking with
High priority
and statements in bold might not help accelerating issue processing..

Sure thing. In the future I can not use that language and bold. How would you prefer that I and others convey that info?

Thanks for editing the comment adding an appreciation line! It looks kind of nicer to me..
about the "conveyance" I would have some ideas and can share an example if needed, however the main point to me is that expressing whether the issue is important to yourself is perfectly fine, saying that an issue is a high priority to the maintainers of a repo is disrespectful as it implies that they must focus on and address it with haste.
The keyword here is Priority.
We appreciate that this library is important to you and are happy to look into issues as they arise. But we ask that you consider the tone of the issue both for us core maintainers and other folks who work on these projects.


ARM docker releases via GHA

Should:

Not significantly increase runtimes by using QEMU, prefer native machines instead.
Preferably avoid multiple docker containers, just ship one that is multiplatform.

Seems to be a multiplatform build now:
https://github.com/umccr/htsget-rs/actions/runs/8461721490/job/23181953056#step:5:164


Type declaration generation fails

I try to build a nuxt module that uses some types of express in its interface.
Unfortunatly this throws an error. It seems, that rollup tries to access the types declaration files written in typescript as a CommonJs file.
I have created a full reproduction scenario:
https://github.com/dulnan/nuxt-graphql-middleware/tree/feature/refactor-build
How to reproduce
git clone -b feature/refactor-build git@github.com:dulnan/nuxt-graphql-middleware.git
npm install
npm run build / npx unbuild

The following error occurs:
Error building /nuxt2-app/modules/nuxt-graphql-middleware: SyntaxError: Unexpected token (17:8) in<EMAIL_ADDRESS>SyntaxError: Unexpected token (17:8) in<EMAIL_ADDRESS>    at Parser.pp$5.raise (file:///nuxt2-app/modules/nuxt-graphql-middleware/node_modules/rollup/dist/es/shared/rollup.js:19407:13)
    at Parser.pp.unexpected (file:///nuxt2-app/modules/nuxt-graphql-middleware/node_modules/rollup/dist/es/shared/rollup.js:16732:8)
    at Parser.pp.semicolon (file:///nuxt2-app/modules/nuxt-graphql-middleware/node_modules/rollup/dist/es/shared/rollup.js:16709:64)
    at Parser.pp$1.parseExpressionStatement (file:///nuxt2-app/modules/nuxt-graphql-middleware/node_modules/rollup/dist/es/shared/rollup.js:17192:8)
    at Parser.pp$1.parseStatement (file:///nuxt2-app/modules/nuxt-graphql-middleware/node_modules/rollup/dist/es/shared/rollup.js:16925:24)
    at Parser.pp$1.parseTopLevel (file:///nuxt2-app/modules/nuxt-graphql-middleware/node_modules/rollup/dist/es/shared/rollup.js:16789:21)
    at Parser.parse (file:///nuxt2-app/modules/nuxt-graphql-middleware/node_modules/rollup/dist/es/shared/rollup.js:16570:15)
    at Function.parse (file:///nuxt2-app/modules/nuxt-graphql-middleware/node_modules/rollup/dist/es/shared/rollup.js:16612:35)
    at Graph.contextParse (file:///nuxt2-app/modules/nuxt-graphql-middleware/node_modules/rollup/dist/es/shared/rollup.js:22658:38)
    at tryParse (/nuxt2-app/modules/nuxt-graphql-middleware/node_modules/@rollup/plugin-commonjs/dist/index.js:26:12) {
  pos: 834,
  loc: {
    column: 8,
    file<EMAIL_ADDRESS>    line: 17
  },
  raisedAt: 840,
  frame: '15: /// <reference types="node" />\n' +
    '16: \n' +
    '17: declare global {\n' +
    '            ^\n' +
    '18:     namespace Express {\n' +
    '19:         // These open interfaces may be extended in an application-specific manner via declaration merging.',
  id<EMAIL_ADDRESS>  hook: 'transform',
  code: 'PLUGIN_ERROR',
  plugin: 'commonjs',
  watchFiles: [
    '/nuxt2-app/modules/nuxt-graphql-middleware/src/module.ts',
    '/nuxt2-app/modules/nuxt-graphql-middleware/src/serverMiddleware.ts',
    '/nuxt2-app/modules/nuxt-graphql-middleware/src/codegen.ts',
    '/nuxt2-app/modules/nuxt-graphql-middleware/src/runtime/middlewarePlugin.ts',
<EMAIL_ADDRESS>  ]
}

Probably you need to mark this dep as an external dependency in build.config.{js,ts,json}.


Allow GITM to scale aurora by HP in each hemisphere

Previously, GITM could scale the aurora by the total hemispheric power but did not differentiate between hemispheres. These changes allow the aurora to be scaled in each hemisphere independently.
GITM changes:

Logical flag in #AURORAMODS to toggle the feature
If enabled, HPI is read into each hemisphere separately. If not, the same behavior as previously is used
Electron flux is then scaled by HP (patterns are not adjusted, just the intensity)

Other changes:

Updated documentation & UAM files (very slightly) to include this
Hme tides were not included in UAM files nor docs, couple lines changed
Python script to convert AE to HP can include a 10% seasonal correction factor (and it can be run with command line arguments instead of setting values inside the script)

Feel free to make changes, I'm open to any feedback.

Wrong GITM repo. Sorry.
Will PR to GITMCode/GITM instead. Not sure what happened here.


WeNet c++ inference

Hi, guys. Recently, I have been working on developing C++ routines for Wenet. I have completed the development work, and the accuracy is aligned with your Python examples. This C++ post-processing module is based on Slyne's work, and it mainly involves some interface refactoring. This means that you no longer need to recompile third-party libraries like fst and KenLM when using these post-processing interfaces. Additionally, I have provided some utility functions, such as ctc_decoding and file reading functions. By the way, I am also developing a speech pre-processing module based on Armadillo, which is mainly used to extract fbank or mfcc features from WAV files. The reason for this is that Kaldi has too many dependencies, which is not very user-friendly for C++ users. I will gradually improve this module, and it will be open-sourced soon. I hope these are useful to you.

Hi , @Kevindurant111  may you   share  your  code ?  I can test .

Hi , @Kevindurant111 may you share your code ? I can test .

pls see my homepage(currently only post-processing module are available)


[Enhancement] Add ColumnDefinitions and RowDefinitions to UniformGrid

Summary
Add ColumnDefinitions and RowDefinitions to UniformGrid.
API Changes
Add following properties to UniformGrid:

ColumnDefinitions
RowDefinitions

Intended Use Case
Enhancement was created based on comment from Calendar PR: https://github.com/xamarin/XamarinCommunityToolkit/pull/1331#discussion_r639264363 Calendar control would use ColumnDefinitions and RowDefinitions from UniformGrid.
Who Will Do The Work?

[ ] I am willing to take this on myself
[x] Just putting this out there for someone to pick up

Thanks Damien!
Please open a New Feature Discussion to implement this feature in the .NET MAUI Community Toolkit.
I've posted more information about the Future Of Xamarin Community Toolkit here: https://devblogs.microsoft.com/xamarin/the-future-of-xamarin-community-toolkit/?WT.mc_id=mobile-0000-bramin


[BugFix][ROCM]  The ROCM backend Bug Fix

When using the ROCm backend to run MLC-LLM, the following bug was encountered and fixed.
1、Module hip should be either dso exportable or binary ser
izable
2、 llvm.amdgcn.ds.bpermute Intrinsic has incorrect type
3、addrspace(3) @shmem Global is external, but doesn't …
…have external or weak linkage

Hi @zhangxiao-stack , thanks so much for doing this, would you mind contributing the changes to TVM upstream? We expect the updates in Relax repo are all about Relax compiler/runtime, otherwise rebasing would be hard.

Thank  you @zhangxiao-stack , please send it to apache tvm

This has been bought back to tvm. Thank you @zhangxiao-stack !


Small typo in the documentation for MySQL.Async.store

I noticed a typo in one of the examples in the documentation . The code example for store defines a variable called insertUserLog, but in the callback for MySQL.Async.store it assigns to insertUser.
It's a tiny and unimportant issue, but it confused me for a few seconds, so I figured I'd bring it up.

Thank you.


:sparkles: systemd-sysext and autologin

This PR is multifold:

Adds by default autologin with systemd
Adds support for systemd-sysext for Live layering capabilities:
An example can found at ghcr.io/kairos-io/provisioning-examples:bundle-ipfs.

How to use systemd-sysext:

Follow the standard docs, and create a bundle similar to https://github.com/kairos-io/provisioning-examples
For testing, you can just luet util unpack ghcr.io/kairos-io/provisioning-examples:bundle-ipfs /usr/local/lib/extensions/kubo. Extensions can be installed with the bundle mechanism. Reboot, the ipfs binary should be now available and the systemd-sysext service active.

cc @paynejacob


Add add command

Codecov Report

Merging #51 (6a5fa4c) into master (d495c68) will decrease coverage by 0.12%.
The diff coverage is 83.84%.

@@             Coverage Diff              @@
##             master      #51      +/-   ##
============================================
- Coverage     67.74%   67.61%   -0.13%
+ Complexity      409      407       -2
============================================
  Files            79       79
  Lines          1364     1371       +7
  Branches        139      139
============================================
+ Hits            924      927       +3
- Misses          404      405       +1
- Partials         36       39       +3

Impacted Files
Coverage Δ

.../java/seedu/address/logic/commands/AddCommand.java
100.00% <ø> (ø)

...java/seedu/address/logic/commands/MarkCommand.java
0.00% <0.00%> (ø)

...va/seedu/address/model/internship/Description.java
0.00% <0.00%> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
20.00% <ø> (ø)

src/main/java/seedu/address/ui/InternshipCard.java
0.00% <0.00%> (ø)

...n/java/seedu/address/model/internship/Company.java
70.00% <70.00%> (ø)

...main/java/seedu/address/model/internship/Link.java
81.81% <81.81%> (ø)

...va/seedu/address/model/internship/AppliedDate.java
85.71% <85.71%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
92.50% <86.66%> (-5.00%)
:arrow_down:

...a/seedu/address/storage/JsonAdaptedInternship.java
90.19% <88.23%> (-3.81%)
:arrow_down:

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Change SWIG's FP type from float to double

In global.h the FP type is defined to be double, while the wrapper was using float. This small change fixes that and makes the provided example file terminate without error.

Thank you for catching that @wlambooy, really appreciate the input!


[ui-components ] Reskin of Inputs and Buttons to Match the Updated Designs

This is a pretty significant change to the mechanic-ui-components and the app framework in mechanic.

updates all ui components to use the new visual language. they can now be color-customized by setting a css color in their parent.
updates the app framework to use the new visual language.

fixes #61

@fdoflorenzano this is ready to review.

[x] Image preview goes to back of other elements (Firefox and Chrome at least)

[ ] When opening color picker, another scroll appears (Firefox and Chrome) — Can't reproduce

[x] Blurry filter gets stuck in a certain position

[ ] I get this error when closing color picker (Firefox and Chrome) maybe its a yalc thing. — it's because of the @ in the path

[ ] For some reason, when testing the dsi-logo-maker in Firefox, I get a much bigger sidebar. This doesn't happen in Chrome or Safari.

[x] On Firefox I get all white select options

@fdoflorenzano please take another look

done! please let me know if you find anything else @fdoflorenzano


Updates that align spec docs and JSON schema and fix minor formatting and grammar issues

While reviewing and using the spec, I noticed some minor issues, which this PR fixes in the spec.md.

@brentzundel Back inside the spec today doing some more dev and noticed this one as well.


Unclear sentences in 2.3.1 FHIR-Document vs CDA-Document

2.3.1 FHIR-Document vs CDA-Document
Issue
. This model enables more easy on the Content Consumer.
Proposed Change
I don't know what the author intended to be said.
Issue
There is clear identity (.id) of each of these resources to so they are clearly distinct
Proposed Change
There is a distinct identity of each resource.
Priority:

Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.

This discussion should be removed from the HIE white paper.
It is content specific and not in the purview of IHE ITI, but of PCC.
Charles
De : Oliver Egger<EMAIL_ADDRESS>Envoyé : jeudi 21 janvier 2021 10:51
À : IHE/HIE-Whitepaper<EMAIL_ADDRESS>Cc : Subscribed<EMAIL_ADDRESS>Objet : [IHE/HIE-Whitepaper] Unclear sentences in 2.3.1 FHIR-Document vs CDA-Document (#124)
2.3.1 FHIR-Document vs CDA-Document
Issue
. This model enables more easy on the Content Consumer.
Proposed Change
I don't know what the author intended to be said.
Issue
There is clear identity (.id) of each of these resources to so they are clearly distinct
Proposed Change
There is a distinct identity of each resource.
Priority:

Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/IHE/HIE-Whitepaper/issues/124 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APOZ2DFYZREP57ZH4CVQKKLS3BENNANCNFSM4WNCZIYA .  https://github.com/notifications/beacon/APOZ2DFJT6GQRBNZAEBQV5LS3BENNA5CNFSM4WNCZIYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LZJQP5A.gif

This discussion should be removed from the HIE white paper.
It is content specific and not in the purview of IHE ITI, but of PCC.
Charles
De : Oliver Egger<EMAIL_ADDRESS>Envoyé : jeudi 21 janvier 2021 10:51
À : IHE/HIE-Whitepaper<EMAIL_ADDRESS>Cc : Subscribed<EMAIL_ADDRESS>Objet : [IHE/HIE-Whitepaper] Unclear sentences in 2.3.1 FHIR-Document vs CDA-Document (#124)
2.3.1 FHIR-Document vs CDA-Document
Issue
. This model enables more easy on the Content Consumer.
Proposed Change
I don't know what the author intended to be said.
Issue
There is clear identity (.id) of each of these resources to so they are clearly distinct
Proposed Change
There is a distinct identity of each resource.
Priority:

Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/IHE/HIE-Whitepaper/issues/124 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APOZ2DFYZREP57ZH4CVQKKLS3BENNANCNFSM4WNCZIYA .  https://github.com/notifications/beacon/APOZ2DFJT6GQRBNZAEBQV5LS3BENNA5CNFSM4WNCZIYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LZJQP5A.gif

I agree with Oliver, the sentence needs to be likely removed. It is an unnecessary argumentantative statement. The section goal was to point out that Document Sharing is content agnostic, and to point out that because of this principle it already supports FHIR in addition to CDA.
I disagree with Charles that the section should be removed. It is very important for the success of Document Sharing that it is clear this is NOT a competition with FHIR.

My comment came from the fact that FHIR documents are still largely a concept without legs, so bragging about that on behalf of FHIR is not helping anyone.  Release 5 may hopefully fix these gaps.
The content neutrality has nothing to do with FHIR documents and has been demonstrated with CDA, DICOM, BPMN, and other content we do not want to promote HL7V2 persisted messages, naked PDF and JPG, etc.
Charles
De : John Moehrke<EMAIL_ADDRESS>Envoyé : mercredi 10 février 2021 11:02
À : IHE/HIE-Whitepaper<EMAIL_ADDRESS>Cc : Charles Parisot<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Objet : Re: [IHE/HIE-Whitepaper] Unclear sentences in 2.3.1 FHIR-Document vs CDA-Document (#124)
I agree with Oliver, the sentence needs to be likely removed. It is an unnecessary argumentantative statement. The section goal was to point out that Document Sharing is content agnostic, and to point out that because of this principle it already supports FHIR in addition to CDA.
I disagree with Charles that the section should be removed. It is very important for the success of Document Sharing that it is clear this is NOT a competition with FHIR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/IHE/HIE-Whitepaper/issues/124#issuecomment-776815234 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APOZ2DHZHKCMOY2DGLSI7XDS6KUW7ANCNFSM4WNCZIYA .  https://github.com/notifications/beacon/APOZ2DEZCIZYEL3JJCI5BSDS6KUW7A5CNFSM4WNCZIYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFZGUFAQ.gif


Bug on download for v2 beta

What happened ?
Download bug and come to an alt after some time. I guess this is a bug on mangadex-downloader as the size of the image is way too big to be the true size but could come from mangadex.

What did you expect to happen ?
The image to be a smaller size and after a few retry to download correctly
App version
2.0.0
Installation origin
PyPI (Python Package Index)
Installation origin (other sources)
No response
Reproducible command
mangadex-downloader "library" --input-pos "*" --use-chapter-title --login --login-username "*******" --login-password "********" --cover "original" --delay-requests 1.5 --save-as raw --path "D:\Manga\mangadex"

I assume that your download has been interrupted (either your connection problem or MangaDex servers problem), and the app is trying to resume the download.
There is a bug in MangaDex right now after their migrating the servers. Which caused resume download process broken.
I suggest you to not login right now and your download should working fine even if it's trying to resume download.

This should be fixed in https://github.com/mansuf/mangadex-downloader/commit/ed1658650f840bfdc4d257e086c9bf2147eae8b0
You can try reinstall the development version
pip install git+https://github.com/mansuf/mangadex-downloader.git@ed1658650f840bfdc4d257e086c9bf2147eae8b0

You can reopen this issue if error like that happened again

Thanks a lot, will test :)


Allow to specify default tr props

Specify default TR properties:
solves #110
var defaultTrProps = {
    cssClass: 'table__tr',
    onClick: this.handleTrClick
};
<ReactTable sortable={true} columns={columns} data={data} defaultTrProps={defaultTrProps} />

I'd rather shy away from adding yet more props to the root
 component that we have to handle specially, document, and test, especially when it's something that can be done so easily by drilling down into
s and s. Thanks for the PR though! :smile:


MaxListenersExceededWarning - Since 4.0.0

I am using Zwavejs2mqtt, but @robertsLando told me to post the bug here.
After an upgrade to the 4.0.0 docker image, my container will not start. Attached is the log
/bin/sh: git: not found
2021-04-30 16:59:09.267 INFO APP: Version: 4.0.0
2021-04-30 16:59:09.272 INFO APP: Application path:/usr/src/app
(node:1) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 uncaughtException listeners added to [process]. Use emitter.setMaxListeners() to increase limit
(Use `node --trace-warnings ...` to show where the warning was created)
(node:1) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 SIGINT listeners added to [process]. Use emitter.setMaxListeners() to increase limit
(node:1) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 exit listeners added to [process]. Use emitter.setMaxListeners() to increase limit

I have since, reverted back to the 3.5.0 image and everything is working as expected.

@AlCalzone I create driver here and when this fails for some reason I destroy it. Also I destroy it when ZwaveClient is closed so sincerly I have no idea what's going on here

@declankenny is there any more logging output or anything that could help us track this down?

I just recreated the docker container with the latest image, set the log level to silly. Attached in the start of zwavejs2mqtt.log
After this snippet all I get are repeats of Controller status: Driver: this.container.getLogger is not a function and Retry connection in 3 seconds...
2021-05-03 13:18:57.891 INFO ZWAVE: Controller status: Driver: this.container.getLogger is not a function
2021-05-03 13:18:57.880 INFO MQTT: MQTT is disabled
2021-05-03 13:18:57.900 INFO APP: Listening on port 8091 host <IP_ADDRESS> protocol HTTP
2021-05-03 13:18:57.893 WARN ZWAVE: Retry connection in 3 seconds...
2021-05-03 13:18:58.736 DEBUG SOCKET: New connection fMN1pzqmx7yp6bBxAAAB
2021-05-03 13:19:00.899 INFO ZWAVE: Controller status: Driver: this.container.getLogger is not a function
2021-05-03 13:19:00.900 WARN ZWAVE: Retry connection in 3 seconds...
2021-05-03 13:19:03.904 INFO ZWAVE: Controller status: Driver: this.container.getLogger is not a function
2021-05-03 13:19:03.905 WARN ZWAVE: Retry connection in 3 seconds...
2021-05-03 13:19:06.909 INFO ZWAVE: Controller status: Driver: this.container.getLogger is not a function
2021-05-03 13:19:06.910 WARN ZWAVE: Retry connection in 3 seconds...
2021-05-03 13:19:09.916 INFO ZWAVE: Controller status: Driver: this.container.getLogger is not a function
2021-05-03 13:19:09.917 WARN ZWAVE: Retry connection in 3 seconds...
2021-05-03 13:19:11.149 DEBUG SOCKET: User disconnected fMN1pzqmx7yp6bBxAAAB
2021-05-03 13:19:11.200 INFO APP: GET /settings 200 43.036 ms - 1371
2021-05-03 13:19:11.316 INFO APP: GET /static/js/app.a3320bb046b712ca125a.js 200 24.054 ms - 1750048
2021-05-03 13:19:11.345 INFO APP: GET /static/css/app.ef50254efc76b722abda.css 200 14.668 ms - 641511
2021-05-03 13:19:11.883 INFO APP: GET /api/auth-enabled 304 7.702 ms - -
2021-05-03 13:19:11.924 INFO APP: GET /static/favicons/favicon-32x32.png 200 4.975 ms - 1831
2021-05-03 13:19:12.199 INFO APP: GET /static/fonts/MaterialIcons-Regular.fa3334f.woff2 200 8.875 ms - 82492
2021-05-03 13:19:12.201 INFO APP: GET /static/logo.png 200 4.015 ms - 10014
2021-05-03 13:19:12.224 DEBUG SOCKET: New connection SzCIUhBSuxoG6GjYAAAD
2021-05-03 13:19:12.227 INFO APP: GET /static/favicons/favicon-32x32.png 304 4.327 ms - -
2021-05-03 13:19:12.247 DEBUG SOCKET: Event INITED emitted to SzCIUhBSuxoG6GjYAAAD
2021-05-03 13:19:12.335 INFO APP: GET /api/settings 200 131.109 ms - 1184
2021-05-03 13:19:12.395 INFO APP: GET /api/auth-enabled 304 3.029 ms - -
2021-05-03 13:19:12.399 INFO APP: GET /api/settings 304 46.751 ms - -
2021-05-03 13:19:12.436 INFO APP: GET /api/auth-enabled 304 2.032 ms - -
2021-05-03 13:19:12.922 INFO ZWAVE: Controller status: Driver: this.container.getLogger is not a function
2021-05-03 13:19:12.922 WARN ZWAVE: Retry connection in 3 seconds...

For reference, here is the services entry from my docker-compose file.
  zwavejs2mqtt:
    container_name: zwavejs2mqtt
    image: zwavejs/zwavejs2mqtt:3.5.0
    restart: ${RESTART_MODE}
    tty: true
    stop_signal: SIGINT
    devices:
      - '/dev/ttyACM0:/dev/ttyACM0'
    volumes:
      - ${DOCKERDIR}/zwavejs2mqtt/store:/usr/src/app/store
      - ${DOCKERDIR}/zwavejs2mqtt/config:/usr/src/app/node_modules/@zwave-js/config
    networks:
      macvlan:
        ipv4_address: <IP_ADDRESS>

Driver: this.container.getLogger is not a function

Now we're getting somewhere. And I think this may be the problem:

${DOCKERDIR}/zwavejs2mqtt/config:/usr/src/app/node_modules/@zwave-js/config

You're mounting an incompatible version of a package.

@AlCalzone
OK, that was it. I removed that volume and 4.0.0. is now working correctly.


SectionType title is not visible in invite

PR includes

[x] Bug Fix

Related issues
Resolve #659


start and end don't get used in reads/search

I installed the server using pip install, as described at readthedocs. From the looks of it, this installs the stable branch (0.1.0b1). I also downloaded the example data so I could play around with curl queries.
When sending queries to reads/search, it looks like no matter what integer you fill in for start or end (including negative numbers), you always get the same results back:
curl --data '{"readGroupIds":["low-coverage:HG00534"], "start":3, "end":10}' --header 'Content-Type: application/json' http://localhost:8000/v0.5.1/reads/search
has the exact same output as
curl --data '{"readGroupIds":["low-coverage:HG00534"], "start":-100}' --header 'Content-Type: application/json' http://localhost:8000/v0.5.1/reads/search
or any other combination I have tried (including not setting start). You always get back the first 100 reads in the file.

The command you should use to install is $ pip install ga4gh --pre as described here http://ga4gh-reference-implementation.readthedocs.org/en/stable/demo.html  It looks like you have the 0.1.0b1 version installed when you should be on 0.1.1.  Let us know if this problem is present on 0.1.1.

You are correct! I thought that was how I installed it but apparently I did something wrong. All is fine on 0.1.1.
Thanks!


Expand sriov docs with brief architecture notes

KubeVirt documentation is not the right place to expand too much on how
all components fit, but the brief notes should hopefully be a good start
for an interested reader to dive in if needed.
Also, be more explicit SR-IOV should be deployed with operator.
Plus, restored some documentation that was unintentionally removed in
a previous patch that still belongs in the document as part of
description of manual deployment of relevant SR-IOV components if an
admin / developer decides to not follow the operator path.
Finally, added some external links to relevant docs / blogs.
NONE

What I'm missing in all of this document is a connection between what the user is requesting in the VMI configuration and the available sriov devices/networks.
The VMI example requests a network sriov/sriov-network. But I'm completely missing where was this configured and which devices can it allocate.

All comments left so far should be addressed in the latest upload.

/retest

/test pull-kubevirt-e2e-k8s-1.14.6

/test pull-kubevirt-e2e-k8s-multus-1.13.3

@phoracek @vladikr any unresolved concerns here? I hope the latest upload is good to go, but let me know.

@booxter looks good to me

@rmohr @vladikr @slintes gentlemen, can anyone of you merge this, or tell me what's missing? Thanks!

This is worth a release note IMHO
Otherwise :+1:

/approve
/hold
@booxter feel free to cancel the hold once you have a release note.

/hold cancel


[Docs] TextInput password visibility example

Summary
Add an example for TextInput component to toggle password visibility. It should be possible once #758 gets merged.
Context
Improve documentation examples to display new features and common use cases of the components.

I like the idea, but I can't find it on flowbite.com. @zoltanszogyenyi am I missing this somewhere? All Flowbite libraries definitely should have this

Also looking for this.

@rluders
I think this is possible and relatively simple once you explore the TextInput code. Here’s an example I created:
I built a custom component that returns a TextInput and extended its props. This way, the user of this component can't override certain key properties, such as the input type.
To achieve the desired functionality, I also applied some Flowbite utilities. Below is a working example of the PasswordInput component that allows toggling between password visibility using icons:
import { getTheme, TextInput, TextInputProps } from "flowbite-react";
import { EyeIcon, EyeSlashIcon } from "@heroicons/react/16/solid";
import classNames from "classnames";
import React, { MouseEventHandler } from "react";

export type PasswordInputProps = TextInputProps;

const svgIconTheme = (visibility: boolean, callback: MouseEventHandler) => {
    const Icon = visibility ? EyeSlashIcon : EyeIcon;
    return (
        <Icon
            className={classNames(getTheme().textInput.field.icon.svg, 'cursor-pointer')}
            onClick={callback}
        />
    );
};

export default function PasswordInput(props: PasswordInputProps): JSX.Element {
    const { type, ...otherProps } = props;
    const [passwordVisibility, setPasswordVisibility] = React.useState(false);

    const togglePasswordVisibility = () => {
        setPasswordVisibility(!passwordVisibility);
    };

    return (
        <TextInput
            type={passwordVisibility ? 'text' : 'password'}
            {...otherProps}
            icon={() => svgIconTheme(passwordVisibility, togglePasswordVisibility)}
            theme={{
                field: {
                    icon: {
                        base: getTheme().textInput.field.icon.base.replace('pointer-events-none', ''),
                    }
                }
            }}
        />
    );
}


Added address in UTxO response - useful when querying by payment credential

Closes #37
Could someone please have a look at it @sorki :pray:

Thank you! And sorry for the delay, released as blockfrost-api <IP_ADDRESS>


Add PIKITO by RUSOWSKY

Song Name
PIKITO
Artist Name
RUSOWSKY
Source
Youtube
Youtube Link
https://youtu.be/DPqULcZXuGE?si=TvON6j5ehxMZ7P8Q
Direct File Link
No response
Song ID
8
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 107571033

reject
duplicate request, see issue 1111


update dependencies and refactor shield_funds on lib.rs

refactor ANCHOR_OFFSET selection on shield_funds.
closes #248

I'm closing this ticket since we settled on the code this PR changes until we have NU5 library support code ready.


thorvald: 2.0.0-1 in 'melodic/lcas-dist.yaml' [bloom]

Increasing version of package(s) in repository thorvald to 2.0.0-1:

upstream repository: https://github.com/LCAS/Thorvald.git
release repository: https://github.com/SAGARobotics/thorvald-releases.git
distro file: melodic/lcas-dist.yaml
bloom version: 0.9.8
previous version for package: 1.3.2-1

thorvald
* melodic-1.3.2
* changelogs
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* Contributors: Marc Hanheide

thorvald_2dnav
* melodic-1.3.2
* changelogs
* Merge pull request #111 <https://github.com/SAGARobotics/Thorvald/issues/111> from MikHut/melodic-devel
  tf_prefix fix same as #109 <https://github.com/SAGARobotics/Thorvald/issues/109> but for melodic-devel
* merge conflicts
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* Contributors: Jaime Pulido Fentanes, Marc Hanheide, c-small

thorvald_base
* Merge pull request #121 <https://github.com/SAGARobotics/Thorvald/issues/121> from larsgrim/unified_thorvald
  reintroduced homing and controller setup
* reintroduced homing and controller setup
* Merge pull request #115 <https://github.com/SAGARobotics/Thorvald/issues/115> from larsgrim/unified_thorvald
  Unified thorvald
* removed unused deps
* removed unused deps
* de-CAN-ified battery id
* now uses battery paramter 'id'
* reintroduced battery data publishing
* updated error message
* returns false if no device
* housekeeping
* will run simulation without can paramters
* added error to explain missing parameters
* housekeeping
* now populates tf before broadcasting
* updated parameter names
* updated variable and parameter names
* updated variable names
* selectable interface + cleaning
* added class for socketcan
* replaced can_line_enc with can_line_usb
* Merge pull request #1 <https://github.com/SAGARobotics/Thorvald/issues/1> from yiannis88/lars-cleanup
  CanCtrlPltf destructor
* bool --> void setCurrentPosAsZeroAll()
* fix getBaseState push_back to resize
* initMotorDrives &setparams
* CanCtrlPltf::initBatteries refactored
* constructor base_driver while() & rm of requestNextVarsAllBatteries
* can_* cleanup - not finished
* CanCtrlPltf destructor
* added can interface type and port~
* can adapter moved from node to can_ctrl_pltf
* tx msg freq 1000->600
* fixed spelling error
* BaseState to BaseStateRos
* CAN class for no-CAN setups
* changes towards new structure WIP
* deROSification of none-node files and changes towards new structure WIP
* added main pcb CAN line class
* interface for can adapters
* melodic-1.3.2
* changelogs
* Merge pull request #111 <https://github.com/SAGARobotics/Thorvald/issues/111> from MikHut/melodic-devel
  tf_prefix fix same as #109 <https://github.com/SAGARobotics/Thorvald/issues/109> but for melodic-devel
* missed slashes that should be removed
* remove accidental change that was in thorvald_2-5_temp branch
* merge conflicts
* merge conflicts
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* Contributors: Jaime Pulido Fentanes, Lars Grimstad, Marc Hanheide, MikHut, c-small, larsgrim, yiannis88

thorvald_bringup
* Merge pull request #115 <https://github.com/SAGARobotics/Thorvald/issues/115> from larsgrim/unified_thorvald
  Unified thorvald
* added missing use of can interface and type parameters
* added can interface and type parameters
* added default value for can_interface_type
* fixed missing namespace option and updated parameter names
* added can interface type and port~
* melodic-1.3.2
* changelogs
* Merge pull request #111 <https://github.com/SAGARobotics/Thorvald/issues/111> from MikHut/melodic-devel
  tf_prefix fix same as #109 <https://github.com/SAGARobotics/Thorvald/issues/109> but for melodic-devel
* merge conflicts
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* changed gazebo for melodic
* Contributors: Jaime Pulido Fentanes, Lars Grimstad, Marc Hanheide, c-small, larsgrim

thorvald_can_devices
* Merge pull request #121 <https://github.com/SAGARobotics/Thorvald/issues/121> from larsgrim/unified_thorvald
  reintroduced homing and controller setup
* reintroduced homing and controller setup
* Merge pull request #115 <https://github.com/SAGARobotics/Thorvald/issues/115> from larsgrim/unified_thorvald
  Unified thorvald
* housekeeping
* removed unused deps
* now updates controller mode, controller_ok->controller_not_ok
* added updateControllerMode()
* added mode online
* now uses bat ID to set CAN addresses, voltage and curret are now double
* updated BatteryVars and de-CAN-ified bat id
* encoder values from config file
* Merge pull request #1 <https://github.com/SAGARobotics/Thorvald/issues/1> from yiannis88/lars-cleanup
  CanCtrlPltf destructor
* bool --> void setCurrentPosAsZeroAll()
* CanCtrlPltf::initBatteries refactored
* deROSification of none-node files and changes towards new structure WIP
* created interface for batteries
* added CAN frame
* melodic-1.3.2
* changelogs
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* Contributors: Lars Grimstad, Marc Hanheide, larsgrim, yiannis88

thorvald_description
* Merge pull request #115 <https://github.com/SAGARobotics/Thorvald/issues/115> from larsgrim/unified_thorvald
  Unified thorvald
* battery parameter 'node' changed to 'id'
* melodic-1.3.2
* changelogs
* Merge pull request #111 <https://github.com/SAGARobotics/Thorvald/issues/111> from MikHut/melodic-devel
  tf_prefix fix same as #109 <https://github.com/SAGARobotics/Thorvald/issues/109> but for melodic-devel
* merge conflicts
* merge conflicts
* melodic-1.3.1
* changelogs
* Merge pull request #106 <https://github.com/SAGARobotics/Thorvald/issues/106> from MikHut/melodic-devel
  add datum file argument for GPS sim and future georeferenced simulations
* add datum file argument for GPS sim and future georeferenced simulations
* melodic-1.3.0
* changelog
* changed gazebo for melodic
* Contributors: Jaime Pulido Fentanes, Lars Grimstad, Marc Hanheide, MikHut, c-small, larsgrim

thorvald_example_robots
* Merge pull request #115 <https://github.com/SAGARobotics/Thorvald/issues/115> from larsgrim/unified_thorvald
  Unified thorvald
* battery parameter 'node' changed to 'id'
* added can interface parameters
* melodic-1.3.2
* changelogs
* Merge pull request #111 <https://github.com/SAGARobotics/Thorvald/issues/111> from MikHut/melodic-devel
  tf_prefix fix same as #109 <https://github.com/SAGARobotics/Thorvald/issues/109> but for melodic-devel
* merge conflicts
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* Contributors: Jaime Pulido Fentanes, Lars Grimstad, Marc Hanheide, c-small, larsgrim

thorvald_gazebo_plugins
* Merge pull request #115 <https://github.com/SAGARobotics/Thorvald/issues/115> from larsgrim/unified_thorvald
  Unified thorvald
* BaseState to BaseStateRos
* melodic-1.3.2
* changelogs
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* making code base the same for kinetic and melodic (#89 <https://github.com/SAGARobotics/Thorvald/issues/89>)
* removed old gazebo plugin and adaptation for gazebo9+ (#87 <https://github.com/SAGARobotics/Thorvald/issues/87>)
* changed gazebo for melodic
* Contributors: Lars Grimstad, Marc Hanheide, larsgrim

thorvald_gui
* Merge pull request #115 <https://github.com/SAGARobotics/Thorvald/issues/115> from larsgrim/unified_thorvald
  Unified thorvald
* updated to work with new message structures
* melodic-1.3.2
* changelogs
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* Contributors: Lars Grimstad, Marc Hanheide, larsgrim

thorvald_msgs
* melodic-1.3.2
* changelogs
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* Contributors: Marc Hanheide

thorvald_simulator
* melodic-1.3.2
* changelogs
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* Contributors: Marc Hanheide

thorvald_teleop
* Merge pull request #112 <https://github.com/SAGARobotics/Thorvald/issues/112> from Jailander/melodic-autoblock
  Addidng missing auto-block to melodic-devel
* Adding a service that allows the setting and un-setting of auto mode using ROS service interface
* typo
* forgot important line!!!
* Adding service that stops the user from being able to put the robot in auto mode
* melodic-1.3.2
* changelogs
* Merge pull request #111 <https://github.com/SAGARobotics/Thorvald/issues/111> from MikHut/melodic-devel
  tf_prefix fix same as #109 <https://github.com/SAGARobotics/Thorvald/issues/109> but for melodic-devel
* teleop launch arg value should be default
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* Contributors: Jaime Pulido Fentanes, Marc Hanheide, MikHut, jailander

thorvald_twist_mux
* melodic-1.3.2
* changelogs
* melodic-1.3.1
* changelogs
* melodic-1.3.0
* changelog
* Contributors: Marc Hanheide

@Jailander are you happy to approve this and actually release the new version?


Update NotificationController.php

Avoid scrolling down to see new notifications.

Thanks, can you fix the styles? Then I will merge it 👍

Green!

Thanks. Just saw that the tests throw an error. Probably due to the new ordering. Can you fix that as well please?


Best practices TODO

Code

[ ] Proper readable and maintable code with consistent spacing and indentation
[ ] Functions follow the "Do One Thing" rule (single-responsibility)
[ ] Followed the SOLID principles (OOP)
[ ] Followed DRY (Don’t Repeat Yourself)
[ ] Added comments wherever required
[ ] Proper naming conventions
[ ] Avoided deep nesting

Readme

[ ] Badges (similar to the Gitter badge. You can maybe use: https://shields.io/)
[ ] Description (why this project exists)
[ ] Features (working of the project)
[ ] Setup (Quick start instructions with how to download and use your project)
[ ] Contributing (How can others contribute?)
[ ] Thanks to (List of contributors)
[ ] License ("This project is licensed under the ")

Tests and CI/CD

[ ] Wrote tests
[ ] Deployed the project (if possible)
[ ] Added CI/CD tools to your project (maybe CircleCI or TravisCI) (if possible)

Everyone, great work so far and thanks for contributing! I'm not checking this right now because the project still needs features and improvements.


 So help me out here. I have everything latest. So please help me here. Thanks
flutter doctor
:[√] Flutter (Channel stable, 2.2.3, on Microsoft Windows [Version 10.0.19043.1052], locale en-IN)
[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[√] Chrome - develop for the web
[!] Android Studio
    X android-studio-dir = C:\Program
    X Android Studio not found at C:\Program
[√] VS Code (version 1.58.2)
[√] Connected device (3 available)

! Doctor found issues in 1 category.

Output:

logs
FAILURE: Build failed with an exception.

* What went wrong:
Could not open settings generic class cache for settings file 'C:\Users\amsin\FlutterProjects\flutter_complete_guide\android\settings.gradle' (C:\Users\amsin\.gradle\caches\6.7\scripts\1fnwrr8g4rohfp291nvlxj5qe).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 60

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 10s
Running Gradle task 'assembleDebug'...
Running Gradle task 'assembleDebug'... Done                        13.8s
Exception: Gradle task assembleDebug failed with exit code 1

Hi @lomork
This looks like an issue with your Gradle, delete .gradle from (C:\Users\amsin\.gradle\cache  and flutter clean and flutter run -v (run will take longer as this will be download gradle again for first time after deleting Gradle cache, make sure to not cancel or interrupt this run)
See https://stackoverflow.com/a/53509014
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Add unit test for HasRequiredLabelsCheck

PR #2

Closing as this was done in the PR mentioned!
/close


Governance. Multisig operations. Remove vote, wrong assign referenda

Description
Wrong referenda is shown for remove vote operation, track and referenda is mixed up:

Environment
https://github.com/novasamatech/nova-spektr/commit/023df867e4ea11596d331f02f572caada4bbeaf6

Status verification: ✅


TypeError: init() got an unexpected keyword argument 'background_model'

Hi, I tried to run
python nerfstudio/nerfstudio/scripts/train.py mars-kitti-car-depth-recon --data /data/kitti-MOT/training/image_02/0006

got an error:
Traceback (most recent call last):
    entrypoint()
    tyro.cli(
    output = _cli_impl(
    out, consumed_keywords = _calling.call_from_args(
    value, consumed_keywords_child = call_from_args(
    value, consumed_keywords_child = call_from_args(
    value, consumed_keywords_child = call_from_args(
    return unwrapped_f(*positional_args, **kwargs), consumed_keywords  # type: ignore
TypeError: __init__() got an unexpected keyword argument 'background_model'

Can you give some suggestions? Thanks.

I have the same issue, did you manage to solve this?

Hi! @antithing and @yanjh97
We have received your message, and we will fix it as soon as possible. Thanks!

You can add a version constraint in the pyproject file to limit the nerfstudio version to 0.3.4. Then, you can check if this issue has been fixed.

You can add a version constraint in the pyproject file to limit the nerfstudio version to 0.3.4. Then, you can check if this issue has been fixed.

Thanks for your replay,but the problem still exists.

hey, facing the same issue. Changed the version of nerfstudio as well as mentioned above, still doesn't seem to work. Did anybody fix it?

Hi there! @amoghskanda @antithing @yanjh97 @ScottDeng114514 As Nerfstudio bumped its version to 1.0.0, there might be some version-related issues. Thank you all for your responses.
I think that this bug is caused by an incorrect tyro version. You can try using this branch and if there are no issues, I will fix it as soon as possible and update it on PyPI.
I suggest that you pull the code and perform a local installation by using the command pip install -e . in mars directory.

It works, now I can train my model from scratch normally! Thanks a lot.

It works for me, too. Thanks for your help.

hey, I was able to fix that but ran into another issue


🍱 adding Entity

adding badge entity

Adding the badge_owned entity

Adding badge_claim entity

@RyanBroemer  im storing the badges locally. Im gonna save a special kind of id to the Badge Icon field which will be used to construct the badge in future

Sounds good