Podspec on MacOS platform? Some binary libraries are missing from the release version, fg filamentapp, imageio ...

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
Podspec on MacOS platform,  Some binary libraries are missing from the release version, fg filamentapp, imageio ...
Describe the solution you'd like
A clear and concise description of what you want to happen.
Support Podspec for MacOS,  Some binary libraries are missing from the release version, fg filamentapp, imageio ...
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Support Podspec for MacOS,  Some binary libraries are missing from the release version, fg filamentapp, imageio ...
OS and backend
Is this feature OS/backend specific? If so, explain why.
MacOS, Mainly take advantage of pod,  Some binary libraries are missing from the release version, fg filamentapp, imageio ...

There are no plans to support CocoaPods for macOS. Instead you can access the binaries from our releases.

Some binary libraries are missing from the release version, fg filamentapp, imageio

These are not supposed to be part of the release. They're only used by our tools/tests/samples.

Also, the new MacOS arm seems to lack binary support?

We build for M1 Macs as well

It seems only x86_ 64 binary?
CC # ls filament/lib/x86_64/
MoltenVK_icd.json		libgltfio.a
libMoltenVK.dylib		libgltfio_core.a
libbackend.a			libgltfio_resources.a
libbluegl.a			libgltfio_resources_lite.a
libbluevk.a			libibl-lite.a
libcamutils.a			libibl.a
libcivetweb.a			libimage.a
libdracodec.a			libmatdbg.a
libfilabridge.a			libmeshoptimizer.a
libfilaflat.a			libshaders.a
libfilamat.a			libsmol-v.a
libfilamat_lite.a		libutils.a
libfilament-iblprefilter.a	libviewer.a
libfilament.a			libvkshaders.a
libfilameshio.a			libvulkan.1.dylib
libgeometry.a
CC #


Use FullScreenLoadingIndicator in IOU detail modal

Details

Use common loader component FullScreenLoadingIndicator in IOU Details page
Fixed Issues

$ https://github.com/Expensify/App/issues/14321
PROPOSAL: https://github.com/Expensify/App/issues/14321#issuecomment-1384286195
Tests

Open any chat room.
Press on any IOU Preview message from chat, if not exist create new one by send/request money.
Verify loader is display in center.

[x] Verify that no errors appear in the JS console

Offline tests

In offline loader will be not display
QA Steps

Open any chat room.
Press on any IOU Preview message from chat,  if not exist create new one by send/request money.
Verify loader is display in center.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
IOUDetailsModal

IOUParticipantsPage

Mobile Web - Chrome
IOUDetailsModal

IOUParticipantsPage

Mobile Web - Safari

IOUDetailsModal

IOUParticipantsPage

Desktop

IOUDetailsModal

IOUParticipantsPage

iOS
IOUDetailsModal

IOUParticipantsPage

Android
IOUDetailsModal

IOUParticipantsPage

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@jatinsonijs Can you include steps to create IOU if it does not exists already for QA Steps

@PauloGasparSv taking this one as I am assigned to the issue, I hope thats ok!

No problem @mountiny :D

@jatinsonijs Can you include steps to create IOU if it does not exists already for QA Steps

Done @Santhosh-Sellavel

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop
Uploading Screen Recording 2023-01-19 at 12.57.11 AM.mov…

Mobile Web - Chrome & Mobile Web - Safari
https://user-images.githubusercontent.com/85645967/213276014-ce284505-f5f6-46fc-9da7-922db4fbcfe4.mov

iOS & Android
https://user-images.githubusercontent.com/85645967/213275952-66aeae79-8535-4c6a-b633-01c4a0122975.mov

@mountiny While taping IOU Badge offline it's loading forever
https://user-images.githubusercontent.com/85645967/213276569-657863b0-b9a5-49a8-9e5b-2316cf07f2d2.mov

While taping IOU Badge offline it's loading forever
@Santhosh-Sellavel is it happening every time ?, actually I have faced same issue yesterday but it Is not reproducing again.

Yes

While taping IOU Badge offline it's loading forever

@Santhosh-Sellavel is it happening every time ?, actually I have faced same issue yesterday but it Is not reproducing again.

Yes, happening everytime!

I have tried to reproduce it but loader not display
https://user-images.githubusercontent.com/114683042/213279805-1c48a542-d037-4e34-8d01-e6e4f7446912.mp4

@jatinsonijs
https://user-images.githubusercontent.com/85645967/213280878-138405b6-88a6-4ad2-8471-6c96ad3b7896.mov

@Santhosh-Sellavel Can you check if you have the IOU report details in your indexedDB locally?
I assume however, this is happening in main as well, this PR is not changing this behaviour

@jatinsonijs  Seems it happens if some data is not fetched completely also I think this is a bit out of scope.
@mountiny Let me know what should we do here, thanks!

@mountiny Can we delete this comment, I think the check is failing because of that!

Done!

Yes @mountiny, @Santhosh-Sellavel its happening due to data not fetched completely, I have found way to reproduce it
Open IOU Details page
wait for data loading
Go offline -> Switch to slow 3G in chrome tool.
Wait for loader to be display.
Once loader displayed immediately go offline.
In this case loader will stuck
https://user-images.githubusercontent.com/114683042/213284440-d4a07c42-f1df-4a9c-a071-0bcd6b520a8b.mp4
Its not related to this PR, if you think it should be fixed I can report it on slack channel

@jatinsonijs Ah you mean that the loading page there is not triggered in normal flow? I would still rather update the styles same as we do in IOUDetails page and just dont include it in the QA, since the styles / views are same we can expect it will work fine.

@jatinsonijs
https://github.com/Expensify/App/blob/5370c36556e12d15efbc3867840557ff3396a501/src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsPage.js#L54-L56
Replacing the above with the below snippet should do
<View style={styles.flex1}>
      <FullScreenLoadingIndicator />
  </View>

cc: @mountiny

That seems reasonable, I mean if it does not really show for user, we might want to refactor this more but thats for later.

@jatinsonijs please add screenshots once the changes are done, thanks!
@mountiny Once changes are done, feel free to merge as it would not break anything, I tested it works for all platforms!

Changes are done @Santhosh-Sellavel and screenshot added.
cc @mountiny

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.57-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.57-3 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


when building or running on dev server the head meta tag with property og:title doesn't change

when i add this meta tag even if i changed it it doesn't change at all on the dev server or the build
this is the theme.config.tsx file
import React from "react";
import { DocsThemeConfig, useConfig } from "nextra-theme-docs";
import Logo from "./components/logo";
import { useRouter } from "next/router";

const config: DocsThemeConfig = {
  logo: () => {
    return (
      <>
        <Logo height={24} />
        <span
          className="mx-2 font-extrabold hidden md:inline select-none"
          title={`verse.db Logo`}
        >
          VERSE.DB
        </span>
      </>
    );
  },
  primaryHue: { dark: 0, light: 230 },
  primarySaturation: { dark: 0, light: 100 },
  head: () => {
    const { route, locale } = useRouter();
    const { frontMatter, title } = useConfig();

    const imageUrl = new URL(
      "https://og.jedi-studio.com/api/og/versedb?type=DOCUMENTATION&title=VERSE%2EDB&description=description%2Etest"
    );
    if (!/\/index\.+/.test(route)) {
      imageUrl.searchParams.set("title", title);
      imageUrl.searchParams.set("description", frontMatter.description);
    }

    const ogTitle = title ? `VERSE.DB | ${title}` : `VERSE.DB`;
    const ogDescription = frontMatter.description ? frontMatter.description : `verse.db isn't just a database, it's your universal data bridge.  Powered by JEDI Studio.",
  },
};

export default config;

the problem is with
<meta property="og:title" content={ogTitle} />

and the problem is that even if i put this code when i build the app i get the result like this
<meta property="og:title" content="title - Nextra" />

Images for the problem:

this is my ogTitle:
  const ogTitle = title ? `VERSE.DB | ${title}` : `VERSE.DB`;

any solution?

any solution?

I need a solution

Please this needs to be solved..

please update to Nextra v3 and report if your issue still exists, closing for now


Adapt to textual 0.87.1

The new textual release has some changes:

There are some changes that we need to do to get the rendered version
of some textual objects as now render() returns RichVisual instances
Textual has a new theme so we need to regenerate our snapshots.
There is something going on with horizontal scroll bars. We have
opened https://github.com/Textualize/textual/issues/5284 but looks
like this may be expected.

Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.

Note that https://github.com/Textualize/textual/issues/5284 may still be a bug

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.91%. Comparing base (beea5cd) to head (28e31ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   92.93%   92.91%   -0.03%
==========================================
  Files          95       95
  Lines       11655    11656       +1
  Branches      406      406
==========================================
- Hits        10832    10830       -2
- Misses        823      826       +3

Flag
Coverage Δ

cpp
92.91% <100.00%> (-0.03%)
:arrow_down:

python_and_cython
92.91% <100.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles


Quote SQL identifiers only when necessary?

In an effort to make EF Core-generated SQL as minimal and as readable as possible, I was considering quoting identifiers only when necessary. In other words, I'd override the appropriate methods in my ISqlGenerationHelper to check the content of the identifier and quote accordingly.
I was wondering if this has already been discussed... Of course the value of doing this isn't enormous, but if there's no major reason not to do it, then why not...

Not sure I agree on readability if only some identifiers are quoted

@ErikEJ really? You prefer all identifiers to be quoted, always, just because some of them may contain a space or some other character? Personally, when I look at SQL generated from EF Core I find myself wishing all the quote noise would be cleaned out of there...

I do, yes! :-)

+1. I already do that in Cosmos Db provider. And the readability difference is rather large there.

Good luck with that  - rule number 3 (of five):
The identifier must not be a Transact-SQL reserved word. SQL Server reserves both the uppercase and lowercase versions of reserved words. When identifiers are used in Transact-SQL statements, the identifiers that do not comply with these rules must be delimited by double quotation marks or brackets. The words that are reserved depend on the database compatibility level. This level can be set by using the ALTER DATABASE statement.
https://docs.microsoft.com/en-us/sql/relational-databases/databases/database-identifiers

+1. This would be very useful.
To address reserved word concerns, how about making it opt-in via DbContext.OnConfiguring(...)?
public enum QuoteIdentifiers
{
    Always,
    AsRequired,
    Never
}

builder.QuoteIdentifiers(Always | AsRequired | Never)

"Never" will break!

@ErikEJ you're right that keywords as an issue. FWIW, the ADO.NET schema API has a collection which is supposed to provide the list of all reserved words. To what extent this is a reliable list on any given provider is another question... At least for PostgreSQL there's an official, hopefully exhaustive list,

It's definitely not just a change you can slap on without looking at stuff like keywords, but it should be possible to do correctly...

And doing it must not impact EF performance

And doing it must not impact EF performance

Unless I'm mistaken these queries are cached, i.e. the delimiting process doesn't happen on every execution (but someone from the EF team should be able to confirm).
Aside from that, delimiting involves quite a bit of allocations for all the concatenations, which this would reduce.

Unless I'm mistaken these queries are cached, i.e. the delimiting process doesn't happen on every execution (but someone from the EF team should be able to confirm).

True. First level cache is based on ExpressionTree in linq. The same entry is used when parameter values are changed. Second level cache is at SQL tree level. Same entry is used as long as nullability of parameters does not change. Else we may need to generate a different SQL.
For Performance thing, we have #10513 to actually move most stuff out of SQL gen to first level cache so second level cache doesn't do much work apart from working with parameters.

@roji @ErikEJ We discussed this in triage and we're not going to make any change to the providers we own primarily because it creates an additional coupling for reserved names, etc., but for your providers we're happy to do what you want. Please be sure that this is safe with regard to any kind of SQL injection attack--should be if it is limited to identifiers, but just saying...

FYI, implemented this for Npgsql in https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues/327. The criteria for being an unquoted identifier in PostgreSQL is actually quite strict (lowercase letters, digits, underscore, dollar), and the reserved word list is pulled from the ADO.NET layer with GetSchema(). Only one keyword has been added in like 5 years, so it feels pretty safe :)


Redesign Identity dialog

backlogging for redesign as it's among onboarding popular field for users

onchain identity supports picture this would be nice we could include on user profile their pictures

we will probably putting there IPFS hash which will point on our gateway, best way we can do it right now, need confirm if IPFS is not too long as I've seen u32 there

we can also show some thumb of uploaded picture

https://github.com/kodadot/nft-gallery/issues/4466

Originally posted by @JustLuuuu in https://github.com/kodadot/nft-gallery/issues/4466#issuecomment-1386895690

@yangwao @VladoTheBoi it looks like this now after #5870 merging

@prachi00 looks good, left a comment in #5870 regarding the component.
Anyway this still needs some work. Add profile icon, mby new layout etc. Will come up with some solution 👍.

Have few questions:
Are some of the fields required other than "Handle"?
How is for example the "Name" and "Email" displayed in profile if filled in?
I am thinking whether Name this field is needed as probably most people will just fill the handle and dont want to share their real name?
Also do we want to add some additional fields which were not present?

Polkadot: how to set identity

Have few questions: Are some of the fields required other than "Handle"?

None are "required" we made "Handle" required so we could be able to search collection based on Creator wallet name

How is for example the "Name" and "Email" displayed in profile if filled in? I am thinking whether Name this field is needed as probably

We don't display "Name" since this field is not really mandatory

most people will just fill the handle and dont want to share their real name?

yes kinda

Also do we want to add some additional fields which were not present?

For now only the one that you see but later maybe refer https://github.com/kodadot/nft-gallery/issues/5286#issuecomment-1556166031

None are "required" we made "Handle" required so we could be able to search collection based on Creator wallet name

I see, but I guess we want to keep it that way right?
Can the identity be edited once created?

I see, but I guess we want to keep it that way right?

Yep!

So Email is not displayed as well?

Nope. Didn't set mine, I don't know if people tend to set their too

Can the identity be edited once created?

Yes, but remember that you will pay some tx fees each time you want to edit your identity

Nope. Didn't set mine, I don't know if people tend to set their too

You made me remember a question I wanted to ask earlier. Do we have some analytics set for triggered events? E.g. like this set email, how many people use different things etc.? I mean this generaly set for whole Koda.
As this would be really handy for some further analysis to have better personalised experience based on data.

Yes, but remember that you will pay some tx fees each time you want to edit your identity

Thats ok. Regarding the fee, is it fixed fee or it varies based on some conditions?
I can see that it shows "Deposit 0.3333 KSM".
And does the "Deposit" mean it behaves differently to "Fee" or is it the same just different wording?

You made me remember a question I wanted to ask earlier. Do we have some analytics set for triggered events? E.g. like this set email, how many people use different things etc.? I mean this generaly set for whole Koda.

currently not to my knowledge but surely there is someone who has done this stats

As this would be really handy for some further analysis to have better personalised experience based on data.

What do you mean by that? know that identity has no value, it's not because you have set your identity that you'll be eligible on something, it's purely aesthetic in my opinion.

Thats ok. Regarding the fee, is it fixed fee or it varies based on some conditions? I can see that it shows "Deposit 0.3333 KSM". And does the "Deposit" mean it behaves differently to "Fee" or is it the same just different wording?

can't really give you the best answer but I think you will find answer in the Kusama Doc

What do you mean by that? know that identity has no value, it's not because you have set your identity that you'll be eligible on something, it's purely aesthetic in my opinion.

I am not talking only about identity section, but about whole Koda app whether there is some analytics set in place or not.

just a quick post for any feeback. Wondering about Social Connections whether to go using apps APIs or simply just pasting a link to your profile on different socials. Would therer be any advantages connecting via API?
Also still not sure about the "Email" field, whether its for some use or not.

Where exactly are you able to scroll through accounts in polkadotjs? Can you send a link please. I can see that email and twitter for example are visible in Subscan within an icon under wallet address.

At the bottom of profile details:

But to my understanding you can also create custom ones like "discord" which we have rn?

Yes, I think it's possible to set n fields with key: value.
That why we are looking for a way to store #5686.

Hi, have some designs ready for a feedback if there is any :)). Check it here.

Hi, have some designs ready for a feedback if there is any :)). Check it here.

Hello, nice work! some quick notes:

I see that in all your new design the content is in a "box" I have a feeling it's going to be a bit weird compared to other pages

What about "Full legal Name" input?

modal header

I really like how you show "social" buttons, maybe make the white check in button when input is filled and valid

we'll still show character on input focus?

I see that in all your new design the content is in a "box" I have a feeling it's going to be a bit weird compared to other pages

They are, I will try to discuss this with @exezbcz.

What about "Full legal Name" input?

As previously discussed here in comments, I dont really think people will have a tendency to disclose their full name. Thats why I didnt include it here.

header

fixed :)

I really like how you show "social" buttons, maybe make the white check in button when input is filled and valid

ohh there actually is check icon in the design, but we are using FA font to display these and you probably dont have it installed. Ill need to figure out some different way so everyone can see even without FA font installed...

we'll still show character on input focus?

I think so, yes. The inputs are I think limited to that number of characters. I will add it into design and add a note.

Hey, made some final changes to the design for now. Feel free to grab.

👋

will work on this if its ok, kodabot won't let me 😭
I'm waiting on other prs

@hassnian feel free to

👋


feat: helmfile dag needs

All operator CRs are now in their own $release-cr file, so that apps.*._rawValues can be applied consistently. All helmfile deps are now also properly configured, and helmfiles have been renamed for better management.
Checklist

[x] Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.

This PR is easy to review, but illustrates well the fairly recent upgrades.yaml approach that is now enhanced to specify pre/post apply scripts, as well as the release pre/post sync scripts that were introduced some releases ago. I think it should be used consistently to enable smooth upgrades without hickups. I also found this article that explains how to migrate PVCs to another namespace without downtime, and we could create automation for such ops.
I invite you to either approve this PR after testing (I tested it and it works well), or make small fixes yourself, as I will be having my holidays until the end of July.

I am sorry but there are way too many unrelated changes, thus I do not even know what to test. Try to split it into smaller atomic parts and make sure that objectives are clear.


Argo Rollouts configuration ConfigMap is not updated to latest value of OpenShiftRolloutPlugin

Depends on fix to https://github.com/argoproj-labs/argo-rollouts-manager/issues/22
At present, if the value of the OpenShiftRolloutPlugin URL changes, for example, because we are shipping a new version of the plugin, it appears the ArgoRollouts ConfigMap will not be updated.
reconcileConfigMap contains this block of code:
	for _, plugin := range actualTrafficRouterPlugins {
		if plugin.Name == OpenShiftRolloutPluginName {
			// Openshift Route Plugin already present, nothing to do
			return nil
		}
	}

This block of code will exit the function if the plugin already exists, regardless of whether the URL matches the expected value.
Fix Criteria:

If the ConfigMap already exists, and it already contains Plugin URL, but the plugin URL is different, the ConfigMap should be updated to point to the new plugin URL
Unit/E2E test to verify

Red Hat External issue tracker: https://issues.redhat.com/browse/GITOPS-4113


handle "unknown revision or path"

Current stacktrace:

Traceback (most recent call last):
  File "/Users/aaronj/wit/lib/wit/gitrepo.py", line 78, in get_commit
    self._git_check(proc)
  File "/Users/aaronj/wit/lib/wit/gitrepo.py", line 214, in _git_check
    raise GitError(msg)
wit.gitrepo.GitError: Command [git rev-parse cfce5c1] exited with non-zero exit status [128]
stdout: [cfce5c1]
stderr: [fatal: ambiguous argument 'cfce5c1': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]']
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/nix/store/jk588wcj1wg51kv2af3rb2j7lkl8h9b0-python3-3.5.7/lib/python3.5/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/nix/store/jk588wcj1wg51kv2af3rb2j7lkl8h9b0-python3-3.5.7/lib/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/Users/aaronj/wit/lib/wit/main.py", line 11, in
main()
File "/Users/aaronj/wit/lib/wit/main.py", line 169, in main
update_pkg(ws, args)
File "/Users/aaronj/wit/lib/wit/main.py", line 240, in update_pkg
ws.update_dependency(args.repo)
File "/Users/aaronj/wit/lib/wit/workspace.py", line 268, in update_dependency
req_resolved_rev = req_dep.resolved_rev()
File "/Users/aaronj/wit/lib/wit/dependency.py", line 107, in resolved_rev
return self.package.repo.get_commit(self.specified_revision)
File "/Users/aaronj/wit/lib/wit/gitrepo.py", line 81, in get_commit
self._git_check(proc)
File "/Users/aaronj/wit/lib/wit/gitrepo.py", line 214, in _git_check
raise GitError(msg)
wit.gitrepo.GitError: Command [git rev-parse origin/cfce5c1] exited with non-zero exit status [128]
stdout: [origin/cfce5c1]
stderr: [fatal: ambiguous argument 'origin/cfce5c1': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]']

Fixed by commit-not-found
Pending on #123


1<<31

1<<31 is not UB and can be used in constant expressions. Currently the following compiles
static_assert(identical(static_cast<int>(0x80000000), cnl::_impl::shift<31, 2>(1)), "");

but there should be a static_assert somewhere to ward against that.

Also, 0x40000000 << 1.

Addressed by #230


[bug] daemon works 2 times of 5

Hey,
Thank you so much for you work!
I just wanted to test out new eco-system tool cause I really like "modes" of keybindings.
But when I start daemon by some reason it works approx. 2 times of 5. I made a small look into code and realized that most probably it happens somewhere here when it is trying to get mutable reference of listener(???).
Could you please help with this issue?

Can u test on #16 plz.
Many Thanks!


Bug: filename may trigger invalid type if special characters are used.

Regex Pattern: https://github.com/mster/datamosh/blob/master/lib/mosh.js#L27-L32
i.e.: filename_0.jpg throws a MoshError because char '_' does not match the regex pattern referenced above.

resolved via #3


Google Calendar API v3 'events/watch' Returns Null "Address" in Response Despite No Errors

Environment details

OS: Linux 64bit
PHP version: 7.4.33
Package name and version: google-api-php-client

Problem
I'm attempting to receive notifications from Google Calendar using the google_calendar_api_v3/events/watch API (https://developers.google.com/calendar/api/v3/reference/events/watch). Although no errors are returned, the response includes a null "address," and the API ultimately fails to work as expected. I can successfully fetch the calendar and events list with the current authorization setup. The PHP script is part of a backend API for an application, and it will not be accessed directly by users via a browser.
I have already verified that the SSL/TLS certificate is correct, and I changed the redirect URL from one with an underscore to one with a hyphen to avoid potential issues.
Here is the relevant code:
index.php
require_once '../google-api-php-client/vendor/autoload.php';
$this->client = new Google\Client();
$this->client->setScopes(Google_Service_Calendar::CALENDAR);
$this->client->setAuthConfig('../client_secret.json');
$this->client->setAccessType('offline');
$refresh_token = "__REFRESHTOKEN__";
$this->client->fetchAccessTokenWithRefreshToken($refresh_token);
$access_token = $this->client->getAccessToken();
$this->client->setAccessToken($access_token);
$this->service = new Google_Service_Calendar($this->client);
$channel = new Google_Service_Calendar_Channel($this->client);
$channel->setId("1412");
$channel->setType("web_hook");
$channel->setAddress("https://sub-domain.example.com/calendar/push_notifications");
$calendarId = "primary";
$watchResponse = $this->service->events->watch($calendarId, $channel);

ClientSecret.json
{
    "web": {
        "client_id": "__CLIENT_ID__",
        "project_id": "__PROJECT_ID__",
        "auth_uri": "https://accounts.google.com/o/oauth2/auth",
        "token_uri": "https://oauth2.googleapis.com/token",
        "auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
        "client_secret": "__CLIENT_SECRET__",
        "redirect_uris": [
            "https://{__PROJECT_ID__}.firebaseapp.com/__/auth/handler",
            "https://sub-domain.example.com/",
            "https://sub-domain.example.com/calendar/push-notifications"
        ],
        "javascript_origins": [
            "http://localhost",
            "http://localhost:5000",
            "https://{__PROJECT_ID__}.firebaseapp.com"
        ]
    }
}

Response.json
{
    "address": null,
    "expiration": "__EXPIRATION__",
    "id": "1412",
    "kind": "api#channel",
    "params": null,
    "payload": null,
    "resourceId": "__RESOUCE_ID__",
    "resourceUri": "https:\/\/www.googleapis.com\/calendar\/v3\/calendars\/primary\/events?alt=json",
    "token": null,
    "type": null
}

What I've tried
Since the initial redirectURL included '_' we changed it to '-'.
Confirmed that the SSL/TLS-certificate is correct.
Thanks!

I am also having this problem.
The call is made by a script in a local environment, maybe that's why a url is not accepted?
However, in my case, even in production the request for a new Watch Channel will be made by a script, so if there was a control on a source domain it would not work... but it seems a bit strange as a possible reason for the non-acceptance of the parameter.
Have you found an alternative way to solve it?


Path of the fastq

Thanks for a nice tool!
i used sc tagger to read the fastq from the path( there are 1000 fastq in 1 path).
it seems sctagger needs directly a fastq as input not the path, is that right? and if so, how can i pass a path of fastqs to sctagger?
error:
IsADirectoryError: [Errno 21] Is a directory: '/fastq_pass'
Thanks
Iman

Hello Iman,
I think you have two options.

The --reads takes multiple arguments. So you can pass all FASTQ paths comma separated.
You can create a UNIX pipe to concatenate all the FASTQs on the fly (without having to use disk storage). This would be somehthing like:

scTagger.py extract_lr_bc --reads <(cat PATH/TO/FASTQ/DIRECTROY/*.fastq)


working with different REST APIs

how can I configure ng-admin to work with several different URI endpoints?
e.g. var admin = nga.application('My Admin')
.baseApiUrl('http://localhost:6007/api/v1/');
lets me use localhost:6007 as my URI
I would like to be able to use additional URIs for other entities
(service oriented architecture - not all entities are coming from the same URI)

@EladRK You can do this by using :  var entity = nga.entity('entity').baseURL('http://localhost:6007/api/v1/');
ref #170

thanks!


CHANGE html-webpack-plugin for generate-page-plugin && CHANGE iframe.html to preview.html

Issue: html-webpack-plugin is designed to generate 1 page. generating multiple pages, means creating a new plugin for each page that excludes all chunks but the 1 entrypoint you wanted to generate a page for.
What I did

I've written a webpack(4) plugin that will generate a page for every entrypoint
I've switched our webpack config to make us of it
I've renamed iframe.html to preview.html

How to test
Examples should run just fine, including dev-mode and static builds, there should be no changes in functionality.
Performance might be a little bit better since the plugin generatePagePlugin is a lot simpler then the html-webpack-plugin.
This is the first part of sbnext coming to the core 🎉.

https://github.com/storybooks/storybook/blob/master/addons/storyshots/storyshots-puppeteer/src/index.js#L44
do a codebase wide search for iframe.html

Got it, changed it there too.

I have pinged a few integrators about this potential change, I'm hoping to hear from them how big of an impact it would make.

ERROR:
Running smoke test in react_native
$ storybook start -p 7007 --smoke-test
=> Loading custom .babelrc from project directory.
=> Loading custom addons config.
=> Using default webpack setup based on "Create React App".
/tmp/storybook/app/react-native/node_modules/html-webpack-plugin/index.js:640
    if (template.indexOf('!') === -1) {
                 ^

TypeError: Cannot read property 'indexOf' of undefined
    at HtmlWebpackPlugin.getFullTemplatePath (/tmp/storybook/app/react-native/node_modules/html-webpack-plugin/index.js:640:18)
    at HtmlWebpackPlugin.apply (/tmp/storybook/app/react-native/node_modules/html-webpack-plugin/index.js:45:34)
    at webpack (/tmp/storybook/node_modules/webpack/lib/webpack.js:37:12)
    at exports.default (/tmp/storybook/app/react-native/dist/server/middleware.js:30:40)
    at new Server (/tmp/storybook/app/react-native/dist/server/index.js:46:50)
    at Object.<anonymous> (/tmp/storybook/app/react-native/dist/bin/storybook-start.js:34:14)
    at Module._compile (internal/modules/cjs/loader.js:654:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:665:10)
    at Module.load (internal/modules/cjs/loader.js:566:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:506:12)
error An unexpected error occurred: "Command failed.
Exit code: 1
Command: sh
Arguments: -c storybook start -p 7007 --smoke-test
Directory: /tmp/storybook/lib/cli/test/run/react_native

If you have good suggestions on backward compatibility

I thought about these few options:

some kind of --compatibility parameter that we can use even for other breaking changes.
still create iframe.html that will just redirect to preview.html
--previewName iframe option 🤷♂

Of course, all these should bump to the user a notification of a feature deprecation.

I've extracted the generatePagePlugin into it's own repo and package, I think it could be useful outside of storybook.

Integrators update:
I've heard from Chromatic, Percy and Screener, it's a breaking chance for them, but it's solvable on their end. If we give them enough time.

I think we should deprecate iframe but keep it around for one major version. It's easy and will give everyone time to adapt

OK, next major release then

@ndelangen To be clear, I mean:

we rename it to preview.html throughout the code
we also have the iframe.html route resolve to preview, and possibly issue a deprecation warning in the dev server
we document the change in release notes and announce that we plan to remove iframe.html
we remove iframe.html in the next major assuming there is no good reason not to

@shilman yes, we can do that, but I've decided that I should do that in a separate PR, I'm sure you won't mind 👍
I also haven't quite figured our how to effectively do the backwards compatibility technically. I'm guessing the only way it could ever work was if it the static build creates both preview.html AND iframe.html..
I rebased this PR, it should be fairly simple to review now.

FIXED a angular issue, should be good to go now,
What do you think of the angular fix @alterx @igor-dv ?

I will merge this after alpha release today.

This change introduces breaking changes in all projects that use html-webpack-plugins with custom storybook builds. This just murdered my svg-spritesheet generator plugin, thus all svg icons no longer show in storybook output 👎

@XPilot Let's find a solution to that together, by either extending the generate-page-webpack-plugin or injecting the svgs some other way.


Create examples subproject

Hey there,
First of all thanks for making this. It's a great library with a lot of promise.
This PR contains a super basic sample project using the cargo examples feature.
There is a lot of sample code in the book and the Readmes but they all require some additional set up to get off the ground.
I thought it might be a good idea to have something someone completely new to the project could use as a starting point.
The check action has also been edited to build examples so it will catch if some new change in the library causes the sample code to break.

Hi, thanks for the PR!
I'm not sure I want to have binary files in the main repo. It'll be in the history forever, so I want to be conservative about what kind of data is included. At the very least, I wouldn't want to include a 2 minute song when a short sound effect would suffice.
For previous versions of Kira, I had a separate repo for examples. It's not as convenient as having an example in the main repo, though.
Also, I'm not sure if command-line apps are the best way to show how to use Kira. Usually, you'll be using it in a game that has an update loop. When you have one-shot examples, there's a bit of extra boilerplate to make sure the program doesn't exit too early. That's not part of the normal workflow of using Kira, so that may be a distraction from learning the library properly.

Oh I did not see that separate repo.
That takes care of what this PR is looking to achieve.

@tesselode when I rediscovered this project recently I also missed having quick and easy examples to try things out, so I ended up doing something very similar to this PR just for myself.
I still think it would be nice to have shorts examples to demonstrate specific topics. I'd be happy to go with you over some ideas if you want, maybe in the discussions tab of the repo if that was enabled...

@joseluis there is a discussions tab now!


created a publish solution through osptool

Can you change the function name to Publish-OSPlatformSolutionPack. Functions cannot have 2 "-"


MetadataLoadContext is NOT inherent to coreclr however MetaDataReader is

Target framework: .NET Core 3.0
Doc: https://github.com/dotnet/docs/blob/master/docs/standard/assembly/index.md
The Reference to System.Reflection.MetadataLoadContext is not a part of the .Net Core 3.0 runtime. and as such, I propose that the reference be changed to System.Reflection.MetaData.MetaDataReader or System.Reflection.MetaData.PEReader.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8ac305e0-d5f4-028e-d801-615e457c9c26
Version Independent ID: 9abcd631-8133-0e05-b1b4-e22b5319ad1f
Content: Assemblies in .NET
Content Source: docs/standard/assembly/index.md
Product: dotnet
GitHub Login: @gewarren
Microsoft Alias: dotnetcontent

@dedady157 Our current guidance is to use MetadataLoadContext as the way to read assembly metadata without fully loading the assembly.
@sdmaclea Would you be able to comment as to why this is preferred?

MetadataLoadContext was the new technology introduced during the .NET Core 3.0 investment to replace the unsupported ReflectionOnlyLoad feature.
MetadataLoadContext is a cross platform .NET Standard solution and is a viable technology for .NET Framework, .NET Core, or .NET Standard...
I think the MetadataLoadContext interface is a better substitute for the scenarios we saw ReflectionOnlyLoad being used for. The other mentioned interfaces are lower level and will likely be harder to use.
Perhaps the language should be updated. "You can load an assembly just to inspect it by using the xref:System.Reflection.MetadataLoadContext class in .NET Core"

Ye after looking through the meta data reader/pe reader coding style, I would say keep the metadataloadcontext reference however I'd go a step and say that "it is the preferred/optimal method on both. Net Framework and .Net Core (available as platform extension on nuget)"

Easy fix; reopening.

Easy fix; reopening.


Fixed typo "web site" -> "website"

Hi, thanks for contributing to kube-hunter!
However, this change does not add real value to the project, so we will not merge it. This is distracting us from handling PRs that are adding features to the code/fixing bugs.
Don't let this discourage you though, I'm sure that with some time you could contribute something very valubale 💯


Add Showcase README #36

Description
Fixes #36
Created a README.md file containing all the screenshots of the app. It is inside the screenshots folder. I hope the README file is proper. If any changes needed, do inform me.
Regards.

Congrats @curiousTejas 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

Star this repository. ⭐

SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .

Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.


pivot table output data

Hi nicolas,
Hope you are doing well!
I wanna get the output data from pivot table on which the visual representation (table, bar chart etc.) is generated. How's that possible.
Thanks in advance.

Can you elaborate please? I'm not sure I understand what you're looking
for...
On Mon, Apr 17, 2017 at 06:55 Muhammad Habibur Rahman <
<EMAIL_ADDRESS>wrote:

Hi nicolas,
Hope you are doing well!
I wanna get the output data from pivot table on which the html table is
generated. How's that possible.
Thanks in advance.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nicolaskruchten/pivottable/issues/687, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAMbA4E8QgMmuAtx_flOCGwqo_K9DuOJks5rw0UKgaJpZM4M_DzV
.

Well, let me explain.
we provide some data objects of columns and rows to pivot table to generate different types of representations like table, bar chart etc.
Based on the provided row and column objects, pivot table calculate and render required table etc.
my query is to get the data objects which is used to generate the table DOM.
If I still clouldn't make you understand. please let me know. I'll try to sketch and give you a pictorial description.

What do you want to do with this intermediate data object? It is passed into the Renderer layer so you can access it by writing your own Renderer: https://github.com/nicolaskruchten/pivottable/wiki/Renderers

Actually I need to write the table in a PDF. So, I just wanna know the data format so that I can write the table somehow in the pdf.
Btw, Thanks for your cooperation.

Your best bet will be to write a renderer in this case.
On Wed, May 3, 2017 at 05:37 Muhammad Habibur Rahman <
<EMAIL_ADDRESS>wrote:

Actually I need to write the table in a PDF. So, I just wanna know the
data format so that I can write the table somehow in the pdf.
Btw, Thanks for your cooperation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nicolaskruchten/pivottable/issues/687#issuecomment-298864844,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMbAydouVF1hKLkNI0FEtL_PdotGIeIks5r2ErkgaJpZM4M_DzV
.


How to transform a Mesh to TriangleMesh in kaolin

Hi, thanks for your great work!
I am wondering how to save a mesh to a obj file.
Specifically, I want to load a cube and sample 2562 vertices on it, and then export to another file, given "cube.obj", I tried:
import kaolin as kal

kaolin_cube = kal.rep.TriangleMesh.from_obj('cube.obj')
sampler = kal.transforms.SampleTriangleMesh(num_samples=2562)
k_cube = sampler(kaolin_cube)
k_cube_m_t = kal.conversions.pointcloudconversions.pointcloud_to_trianglemesh(k_cube)
k_cube_m = kal.rep.Mesh.from_tensors(vertices=k_cube_m_t[0], faces=k_cube_m_t[1])
k_cube_m.save_mesh("cube2562.obj")

And I got error:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-56-bd52cf58c5ca> in <module>
----> 1 k_cube_m.save_mesh("cube2562.obj")

AttributeError: 'Mesh' object has no attribute 'save_mesh'

I check the doc, it seems like there is no method to convert a Mesh to TriangleMesh, right? Then, how can I export this result?

You can do:
k_cube_m = kal.rep.TriangleMesh.from_tensors(vertices=k_cube_m_t[0], faces=k_cube_m_t[1])

Can I save a point cloud? I found that after pointcloud_to_trianglemesh, the number of vertices reduces from 2562 to 1608. I want to preserve the number of vertices after remeshing.

Yes you can directly use torch.save to save a point cloud.
For your second question our current conversion doesn't allow that, feel free to suggest / add one :)


"ck ls"

"ck ls" would be a useful alias for "ck list".

Added! You can use it in the latest CK kernel version:
$ ck pull all --kernel

Verified - thanks!


[kafka-consumer] Remove anonymized namespace and give unique names fo…

…r gflags

The anonymous namespace for KafkaWatcher is causing issues, so adding it to the
kafka namespace.
Making the gflag names unique so that they don't clash with gflags defined
by individual services.

The code changes lgtm.
There are 2 things we need to think through.

since we removed some gflags and changed some gflag names, we need to make sure all current production cluster configuration is changed accordingly when rolling out this change.
stat names are changed, we want to make sure dashboards and alerts for the current clusters are changed accordingly.

Thanks for the review. Yes, will make sure the new gflags are added to the env. For stat name changes, will try to keep them the same as before so we won't have to change alerts/dashboards. Will test all this before rolling it out.


Envoy unable to start with v8 filter

Description:
I built from head [36e3280280163cad1a905650f1425a1505400892], recompiled the wasm example using latest emscripten (1.38.41), modified the envoy.yaml to run using the v8 engine (and removed allow_precompiled: true) and attempted to start envoy. It immediately crashes. (Note that this works using the wavm engine.)
Config:
static_resources:
  listeners:
  - name: main
    address:
      socket_address:
        address: <IP_ADDRESS>
        port_value: 80
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        config:
          stat_prefix: ingress_http
          codec_type: auto
          route_config:
            name: local_route
            virtual_hosts:
            - name: local_service
              domains:
              - "*"
              routes:
              - match:
                  prefix: "/"
                route:
                  cluster: web_service
          http_filters:
          - name: envoy.wasm
            config:
              vm_id: "my_vm_id"
              root_id: "my_root_id"
              vm_config:
                # vm: "envoy.wasm.vm.wavm"
                vm: "envoy.wasm.vm.v8"
                code:
                  filename: "/Users/theganyo/dev/envoy-wasm/examples/wasm/envoy_filter_http_wasm_example.wasm"
                # allow_precompiled: true
          - name: envoy.router
            config: {}
  - name: staticreply
    address:
      socket_address:
        address: <IP_ADDRESS>
        port_value: 8099
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        config:
          stat_prefix: ingress_http
          codec_type: auto
          route_config:
            name: local_route
            virtual_hosts:
            - name: local_service
              domains:
              - "*"
              routes:
              - match:
                  prefix: "/"
                direct_response:
                  status: 200
                  body:
                    inline_string: "example body\n"
          http_filters:
          - name: envoy.router
            config: {}

  clusters:
  - name: web_service
    connect_timeout: 0.25s
    type: static
    lb_policy: round_robin
    hosts:
    - socket_address:
        address: <IP_ADDRESS>
        port_value: 8099
admin:
  access_log_path: "/dev/null"
  address:
    socket_address:
      address: <IP_ADDRESS>
      port_value: 8001

Call Stack:
#
# Fatal process OOM in WasmCodeManager::NewNativeModule
#

[2019-08-16 15:14:34.585][9741908][critical][backtrace] [bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:81] Caught Illegal instruction: 4, suspect faulting address 0x1079c6dd2
[2019-08-16 15:14:34.585][9741908][critical][backtrace] [bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:69] Backtrace (use tools/stack_decode.py to get line numbers):
[1]    44896 illegal hardware instruction  /Users/theganyo/dev/envoy-wasm/bazel-bin/source/exe/envoy-static -c

Per @PiotrSikora if concurrency is too high (i.e. number of VM is too many), the proxy will be under memory pressure. Lower concurrency works for me.

How does that relate? I don't see anything like that in the config above, so I assume it's a default? If so, how would it be overridden?

It is a envoy cmd args: bazel-bin/source/exe/envoy-static -c envoy.yaml --concurrency 5

Thanks. Ok, I just verified with --concurrency 5, envoy is able to start. In fact, it works up to 10.

Good news, starting with V8/wee8 v7.6 (which I already have staged), we can start up to 92 VMs (--concurrency 91 + base VM).

That is good news! Does that depend on machine memory? What's the default? Is it static? Should it be smarter?

I don't think it depends on the available memory, since it crashes when hitting >1TB VSZ, nor RSS. But, you might obviously hit RSS limits with high number of VMs as well.
The default --concurrency is number of CPU cores.

Hmm, something's not right. I have 6 cores on my machine, but I needed to explicitly set the concurrency down to 10 or under.

Huh, it looks that Envoy now starts 2x number of CPU cores... Not sure where this is coming from, to be honest, since looking at the code, it sets --concurrency to std::thread::hardware_concurrency().


Optimized Python splitters

Description

Rewrote Python splitter functions to improve efficiency. This new implementation has the same behavior as the Spark version.
DO NOT MERGE. More tests are needed.
Related Issues

Checklist:

[x] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[x] This PR is being made to staging branch and not to main branch.

DO NOT MERGE. More tests are needed.

A small notice. An alternative way to tell the team that you don't want us to merge is by creating a draft PR instead of a normal PR. Simon does it from time to time. There is no need to change this PR, this is just FYI in case you were not familiar :-)


Implement ots_getTransactionError endpoints

Describe the feature
Execute the transaction and get the return type
https://github.com/paradigmxyz/reth/blob/1dc0aab51c50cfe6836e54283928b6eca590aa4c/crates/rpc/rpc/src/otterscan.rs#L46-L49
This can be done with a NoopInspector here:
https://github.com/paradigmxyz/reth/blob/1dc0aab51c50cfe6836e54283928b6eca590aa4c/crates/rpc/rpc/src/eth/api/transactions.rs#L993-L993
TODO:
also restrict this to EthTransactions
https://github.com/paradigmxyz/reth/blob/1dc0aab51c50cfe6836e54283928b6eca590aa4c/crates/rpc/rpc/src/otterscan.rs#L29-L29
Additional context
https://github.com/otterscan/otterscan/blob/develop/docs/custom-jsonrpc.md

Will give it a try.


[WIP] Update is_valid_opcode security

What was wrong?
Codestream processing was insecure
How was it fixed?
Updated codestream processing algorithm
Cute Animal Picture

Hey @pipermerriam still plenty of cleaning and refactoring to be done, but if you don't mind giving this a quick lookover to make sure i'm on the right track/didn't miss anything important, that would be awesome!


Fix bug in single language site

In single language site, it generates urls like "http://xxx.com/nullREADME.html", should be "http://xxx.com/README.html"

I have not tested my commit yet and sorry about that. Can someone help test it? I'm not familiar with gitbook's plugin and still figuring out how to run the test.


Buttons on modals on a small screen are cut off at the bottom

Description of problem
Buttons on modals on a small screen are cut off at the bottom
Expected behavior
There should be padding at at the bottom of the screen so that no elements are ever on the edge of the screen (this includes text, buttons, images, etc.)
Steps to reproduce
To see an example, delete a credential to view the delete a credential modal.
This appears in all modals
Screenshots and/or log output
Default text

Max text enlargement

Environment

[X] Occurs on Android
[X] Occurs on iOS

Build #: 975
Android Device Model:
iOS Device Model:
Workaround
none
Severity

[ ] High
[ ] Medium
[X] Low

@knguyenBC to additional Screen shot and plan next steps

Added screenshots.

Verified in 1.0.15-1452


create an issue on Decentraland's marketplace-contracts repo to create a version of _executeOrder that doesn't hardcode the from account as msg.sender

https://github.com/tasitlabs/TasitSDK/issues/273#issuecomment-473962376

Created: https://github.com/decentraland/marketplace-contracts/issues/47

Thanks. I think we can close this issue then.

A member of the team responds:

Hey, thanks for the idea!
Unfortunately, the marketplace contract is not upgradable.

Refs: https://github.com/decentraland/marketplace-contracts/issues/47#issuecomment-474549231

I suppose they could still point their front end at a newly deployed contract, but that means getting changes through will be a much slower process due to the more complicated migration path.


Skeleton for "toggle" menu

I want to share my simple "toggle" mechanism with you.
No JavaScript is required. Just look at: https://github.com/andygeiss/mda.css
Demo is available here: https://smart-endpoints.de/mda.css/
Important: Reduce window width to < 650px for the toggle :-)
I used the following technique to "toggle" (short):
nav {
display: none;
}
.toggle:hover + nav {
display: block;
}
Maybe worth a look.

@andygeiss Perfect! Just what I was looking for! A little more documentation would help a lot.

Thx for your feedback! I will try my best to optimize my documentation ;-)

@andygeiss cannot see it working. The link is broken

@andygeuss @ganeshkbhat skeleton-plus includes a working navigantion bar (https://github.com/oltmannsdaniel/skeleton-plus)

Thanks.


Kani compiler should include its backend version

Proposed change: The kani-compiler should include its version when execution includes --version --verbose.
Motivation: Cargo uses the compiler version to create a hash code for its compiler. This currently does not include the backend version, but it sounds like they are opened to change it. So this will probably be the best mechanism to implement proper caching invalidation when our users update Kani in case the new version still relies on the same version rustc version.
https://github.com/rust-lang/cargo/blob/ee755e77dae6cd419babe6f778dfff9337a4c7cf/src/cargo/core/compiler/context/compilation_files.rs#L662-L664

I just tried this and it looks like rustc doesn't take into account he backend passed to RunCompiler when printing its version. So this will likely need some changes to rustc as well.


Starting openvpn for the cli in this example is not best practise

[Enter feedback here]
Hi! The best practice for running applications as sudo in the background is "sudop -b app". The & will cause the app to be suspended as it is passed to another shell where sudo has not been run.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f36e0264-e439-92d2-7862-096c3fffe2a8
Version Independent ID: 010d36f4-897e-6435-3f97-c6729ed496ce
Content: How to configure OpenVPN Clients for Azure VPN Gateway
Content Source: articles/vpn-gateway/vpn-gateway-howto-openvpn-clients.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@varleg
Thank you for reaching out and bringing this to our notice. At this time we are reviewing the feedback and will provide an update as appropriate.

@varleg
Thank you for reaching out and bringing this to our notice. At this time we are reviewing the feedback and will provide an update as appropriate.

@varleg Are you pointing to this command?

To connect using the command line, type the following command:
sudo openvpn --config &

If so, this is working fine for me without any errors. Please elaborate further regarding your issue so I can understand it better. Thank you!

@varleg Are you pointing to this command?

To connect using the command line, type the following command:
sudo openvpn --config &

If so, this is working fine for me without any errors. Please elaborate further regarding your issue so I can understand it better. Thank you!

@SaiKishor-MSFT This is the command I am reffering to, yes. The problem with the ampersand on sudo is that you will send the command itself to a new background shell which sudo has not been run in (at least in zsh). This will try to run openvpn without the sudo command (as superuser rights does not propagate). Therefore I suggest using sudo --background, as referenced by the manual page of the sudo command. "Run the given command in the background. Note that it is not possible to use shell job control to manipulate background processes started by sudo. Most interactive commands will fail to work properly in background mode." This will ensure the process runs as intended for all versions of shell, and on all kernel versions. Cheers. :)

@SaiKishor-MSFT This is the command I am reffering to, yes. The problem with the ampersand on sudo is that you will send the command itself to a new background shell which sudo has not been run in (at least in zsh). This will try to run openvpn without the sudo command (as superuser rights does not propagate). Therefore I suggest using sudo --background, as referenced by the manual page of the sudo command. "Run the given command in the background. Note that it is not possible to use shell job control to manipulate background processes started by sudo. Most interactive commands will fail to work properly in background mode." This will ensure the process runs as intended for all versions of shell, and on all kernel versions. Cheers. :)

@varleg I understand now. I will discuss this with our PG team to determine this change and will update the document as needed. We really appreciate your valuable feedback.

@varleg I understand now. I will discuss this with our PG team to determine this change and will update the document as needed. We really appreciate your valuable feedback.


Add video to openapi

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Release 0.6.3

I forgot to merge release 0.6.3 into master after cutting the release from the develop branch.

Release 0.6.3 is going to exist outside of git just to keep our master branch history clean.


Help. Wanted to try atomic swap and first purchased bitcoin from Bisq. Transaction Fee too low. Transaction stuck in mempool for 3 days.

As the title says. I first purchased bitcoin from bisq and withdrew it all and sent it directly to UnstoppableSwap. Accidentally made the transaction fee too low through Bisq and have been stuck at 0 of 6 confirmations for 3 days.
What are my options? RBF does not appear possible through bisq, and since I sent it directly to a swap provider, I have no clue how to initiate CPFP.
Some places say the transaction will be thrown out of the mempool in 72 hours, other say weeks, one said indefinitely. Please please help, thank you.

Which state is your transaction in? Has the Bitcoin been "locked"?
Try to keep an eye on the transaction. If it gets confirmed resume the swap and finish. If the transaction gets dropped (not confirmed). You can probably just withdraw it from Bisq with a higher fee.

Closing this


Returning 404

I tried with the example in the readme, and it returns 404. I tried finding any API guide about 15.ai, but google doesn't give me anything for some reason.

Having the same issue. Changing the header's user-agent value to Mozilla/5.0 returns a 502 instead. Any ideas for a work-around?

All of you lads I have fixed the issue check out my new 15.Ai Apiv2 repo

I found the new api link although I can not get this to work

Got a hack working in my own program by making a function e.g.:
import requests

url = "https://api.15.ai/app/getAudioFile5"
headers = {'authority': 'api.15.ai',
           'access-control-allow-origin': '*',
           'accept': 'application/json, text/plain, */*',
           'dnt': '1',
           'user-agent': 'Mozilla/5.0,
           'content-type': 'application/json;charset=UTF-8',
           'sec-gpc': '1',
           'origin': 'https://15.ai',
           'sec-fetch-site': 'same-site',
           'sec-fetch-mode': 'cors',
           'sec-fetch-dest': 'empty',
           'referer': 'https://15.ai/',
           'accept-language': 'en-US,en;q=0.9'}

def get_sound(character: str, emotion: str, text: str):
    response = requests.post(url, json = {
        "character": character,
        "emotion": emotion,
        "text": text
    }, headers = headers)

    if response.status_code != 200:
        raise RuntimeError(f"15.ai responded with code {response.status_code}.")

    data_json = response.json()
    wav_name = data_json["wavNames"][0]

    second_response = requests.get(cdn_url + wav_name)

    if second_response.status_code != 200:
        raise RuntimeError(f"15.ai CDN responded with code {second_response.status_code}.")

    print("Audio success!")

    return second_response.content

Got a hack working in my own program by making a function e.g.:
import requests

url = "https://api.15.ai/app/getAudioFile5"
headers = {'authority': 'api.15.ai',
           'access-control-allow-origin': '*',
           'accept': 'application/json, text/plain, */*',
           'dnt': '1',
           'user-agent': 'Mozilla/5.0,
           'content-type': 'application/json;charset=UTF-8',
           'sec-gpc': '1',
           'origin': 'https://15.ai',
           'sec-fetch-site': 'same-site',
           'sec-fetch-mode': 'cors',
           'sec-fetch-dest': 'empty',
           'referer': 'https://15.ai/',
           'accept-language': 'en-US,en;q=0.9'}

def get_sound(character: str, emotion: str, text: str):
    response = requests.post(url, json = {
        "character": character,
        "emotion": emotion,
        "text": text
    }, headers = headers)

    if response.status_code != 200:
        raise RuntimeError(f"15.ai responded with code {response.status_code}.")

    data_json = response.json()
    wav_name = data_json["wavNames"][0]

    second_response = requests.get(cdn_url + wav_name)

    if second_response.status_code != 200:
        raise RuntimeError(f"15.ai CDN responded with code {second_response.status_code}.")

    print("Audio success!")

    return second_response.content

cdn_url is undefinded?


There was already a messages.ts file, so it was already TypeScript. Please explain what this PR is doing then?

Mersho changed the title Convert messages to TS (5th commit of PR435) to fixing types & import/exports of messages.ts (5th commit of PR435).

"Fixing types & import/exports" is not enough explanation. What are you fixing?

"Fixing types & import/exports" is not enough explanation. What are you fixing?

@knocte Hey, thank you for noticing, I edited the PR title and the commit message, is everything all right now?

LGTM


Allow configure VdW switching in ForceField

I couldn't find a way to setUseSwitchingFunction and setSwitchingDistance through ForceField.createSystem. We can still work around it by just configuring manually the force after the system has been created, but it would be nice to support it in NonbondedGenerator.createForce.

This sounds interesting, but how would you think to bring it in? Via arguments to createSystem?

I didn't go to deeply in checking its feasibility, but ForceField.createSystem currently takes kwargs that gets feed to force.createForce(..., **kwargs). Similarly to openmm.AmberPrmtopFile.createSystem(..., switchDistance=Quantity(value=0.0, unit=nanometer)), we could have one of those kwarsg be a switchDistance parameter that will be taken by NonbondedGenerator.createForce() to set the switching accordingly.

Sounds good to me.

Should the switching function be an intrinsic property of the forcefield (and described in the XML) or should it be something that we leave to the user to decide every time they create a System object?
In inclined to say that anything that affects the potential should probably be encoded in the XML file. Once we have the ability to parameterize forcefield a using consistent data, we would presumably want to derive parameters specific to particular nonbonded treatments or constraints.

I'm thinking that for SMIRNOFF force fields we derive by fitting to data, it should be encoded by the force field.
BUT, this will not be all force fields -- for example SMIRNOFF99Frosst was developed without a specific switching function in mind. Also, we're hoping to get others to put their force fields into this format, and those, likewise, will come in without having been necessarily designed for a specific switching function (or at least, whether they were or not is a matter of debate). So, people using these types of "historical" or at least "not fitted with a specific switching function" force fields will want/need the ability to pick.

What if we allow these things to be encoded by the XML but provide optional arguments to ForceField to override or specify these?
The question then is whether there should be defaults, or if we should require either the XML specify things or the user provide an optional argument to ForceField?

What if we allow these things to be encoded by the XML but provide optional arguments to ForceField to override or specify these?

Yes, that's my preference.

The question then is whether there should be defaults, or if we should require either the XML specify things or the user provide an optional argument to ForceField?

I think defaults makes sense to me, though I don't have strong opinions on what the defaults should be.

Are you sure? That means there are THREE places that the settings you are using in your simulation could come from, rather than two.
I would much rather be more strict, and require these things to be specified by the optional arguments if they are not in the XML files.

I would much rather be more strict, and require these things to be specified by the optional arguments if they are not in the XML files.

I'm fine with this; that's why I phrased it tentatively. It sounds like you have a strong opinion on it and I'm OK with that approach.

These settings are now controlled by the vdW section of the SMIRNOFF spec:
https://open-forcefield-toolkit.readthedocs.io/en/latest/smirnoff.html#vdw


Feat/migration

closes #1042
Restrictions:

Design currently limited to leveldb
Migration Items need to be precompiled with go-bindata so a hash can be calculated

This is tricky as opens up ways of missing the generation and changing the migration item code without being able to check the hash properly. In which case, why do all the effort on adding a hash if the safety check can be bypassed.

There are some autogen files that bring the coverage down. :(

@mikiquantum I think we can tell codecov to ignore the data.go file - https://docs.codecov.io/docs/ignoring-paths

@vedhavyas We removed at the moment the data.go autogenerated for the hash check. Merging this now, thanks for the review.


[In App Purchase]: Migrate Google Play Billing to either 5.2.1 or 6.0.1 and above for Android 14

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Update to flutter version 3.13.1
Add in_app_purchase: ^3.1.8 package
Bump compileSdkVersion & targetSdkVersion to 34
Create an app bundle and upload to play console

Expected results
Create a play store release successfully
Actual results
Play console throw the following error.
This app targets Android 14 or above, and your current Play Billing Library version doesn't support Android 14. To target the latest Android version, please update your PBL version to either 5.2.1, or 6.0.1 and above.
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[!] Flutter (Channel stable, 3.13.1, on Microsoft Windows [Version 10.0.22621.2134], locale en-US)
    • Flutter version 3.13.1 on channel stable at C:\src\flutter
    ! Warning: `dart` on your path resolves to C:\Program Files\Dart\dart-sdk\bin\dart.exe, which is not inside your
      current Flutter SDK checkout at C:\src\flutter. Consider adding C:\src\flutter\bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e1e47221e8 (2 days ago), 2023-08-22 21:43:18 -0700
    • Engine revision b20183e040
    • Dart version 3.1.0
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly
      to perform update checks and upgrades.

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\user\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop Windows apps
    X Visual Studio not installed; this is necessary to develop Windows apps.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2022.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)

[√] VS Code (version 1.81.1)
    • VS Code at C:\Users\user\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.70.0

[√] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 13 (API 33) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Version 10.0.22621.2134]
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 116.0.5845.98
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 116.0.1938.54

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

The plugin was already updated to 6.0.1. Could you provide your pubspec.lock file (or at least the parts about any in_app_purchase_* packages)?

Update to flutter version 3.13.1
Add in_app_purchase: ^3.1.8 package
Bump compileSdkVersion & targetSdkVersion to 34
Create an app bundle and upload to play console

Did you follow these steps in a new app, adding in_app_purchase to an app that had previously not used it at all? Doing so should have given you the latest version of all the dependencies, whereas if you updated just in_app_purchase in an existing app you would get different results?

@zoeyfan FYI, this is a bug that concerns monetization. Please let us know if you think it should be escalated further.

Hey @stuartmorgan

Could you provide your pubspec.lock file (or at least the parts about any in_app_purchase_* packages)?

pubspec.lock parts
  in_app_purchase:
    dependency: "direct main"
    description:
      name: in_app_purchase
      sha256: "944b9a9d8cce41a0ac057dd6984c942f01bfed9a8106247f2f630b06f5db8aab"
      url: "https://pub.dev"
    source: hosted
    version: "3.1.8"
  in_app_purchase_android:
    dependency: transitive
    description:
      name: in_app_purchase_android
      sha256: c1b8eba009db6002c6dd5ae1110d2445297dfd83b9c11e8f9ddb7411cb9dbee6
      url: "https://pub.dev"
    source: hosted
    version: "0.3.0+5"
  in_app_purchase_platform_interface:
    dependency: transitive
    description:
      name: in_app_purchase_platform_interface
      sha256: "356a855d5a1f92b0d06a739e702fd732b56ee1914e6ba0f2ba08a2cb8e2cc3f8"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.4"
  in_app_purchase_storekit:
    dependency: transitive
    description:
      name: in_app_purchase_storekit
      sha256: f598169999604d9c40c28bb6f47b58e03c8c498e344cdc015f937a1f528982ab
      url: "https://pub.dev"
    source: hosted
    version: "0.3.6+4"

Did you follow these steps in a new app, adding in_app_purchase to an app that had previously not used it at all?

No, I updated the in app purchase version to an app that was previously using it prior flutter 3.13.* release

Doing so should have given you the latest version of all the dependencies, whereas if you updated just in_app_purchase in an existing app you would get different results?

Why is this case? What are the implications of the different results?
I was thinking may be this could be the issue,  https://github.com/flutter/packages/blob/main/packages/in_app_purchase/in_app_purchase_android/android/build.gradle#L29
Also btw, I only use in app purchase on iOS only, is there a way I can disable this on android and not show the in-app purchase flag on the description of my app on google.play?

Why is this case?

Because an existing project has a pubspec.lock file, which preserves the versions of packages that you were previously using unless you explicitly update them (e.g., via flutter pub upgrade).

What are the implications of the different results?

Having old versions of transitive dependencies means you aren't getting updates to them. In particular, in your case:

  in_app_purchase_android:
    [...]
    version: "0.3.0+5"

using a version of in_app_purchase_android that is three months old, and predates the update to Billing 6.0.
Closing, as the requested update had already been done.


Security considerations

As it is, anyone who has access to singularity, can deploy anything to be executed as root user. Basically, this is almost the same as they have ssh access to root account. Singularity does not have any concept of user/groups authentication and authorization.
How to allow certain teams or team members to deploy jobs to singularity, but with some constraints? For example, task can be executed only as a user from specific list. Or command can not match some regex. That's all use cases of importance if you have multiple teams with clearly defined privileges. Right now, singularity makes those privilege separation completely useless.

Singularity already has a concept of authorization, however it is not well exposed or easy to use as of yet. Currently, there is an ldap-backed authorization method you can use. The user in question is passed in as a header, and the groups for that user compared against the group/readWriteGroups/readOnlyGroups for the request they are trying to access. There isn't any authentication in Singularity yet however.
We are already working on #1635 which adds a more flexible way to set this up and provide user details to Singularity. With that PR I plan on adding documentation on how to set it up and take advantage of these features


Icons not included in repo

I tried running npm run build but getting an error when jade-ing the files:
Error: views\partials\graph-list.jade:5
    3|     a(href="/dataset/repos-per-week")
    4|       span
  > 5|         include ../icons/chart.jade
    6|       p.graph-name repos per week
    7|   li(class="searchable", data-index="events meetup week weeks")
    8|     a(href="/dataset/events-per-week")

ENOENT: no such file or directory

It looks like the icon files are not included in the repo?

so wierd... the icons folder is in the views folder and i didn't even .gitignore it :/
let me investigate and push it in!

:+1:


I need the pcb files and schematics please I have all the parts to make one raspberry Pi 4 and one raspberry Pi 3 b+

Please I need the files so I can make my own I don’t have 300 in my pocket to buy them from you so I bought all the parts please

Sorry this is not at all relevant to this repo.


Use Json Schema for values validation

What does this PR do?

What's changed? Why were these changes made?

Validate values using Json Schema to improve UX, instead of inline validation.
Benefits:

Validation resides next to the values.yaml instead of inline in the templates
Error handling done by Json Schema infra
Use built-in validation tool
Can validate types of input, range, regex and more
All validations are concentrated in one place

NOTE:
required properties were used only for the ones that were already required.
Besides that, only type validation was used, with minimal 1 for expiration properties.

How should the reviewer approach this PR, especially if manual tests are required?

Check that the existing validations are maintained
Execute helm template to make sure the existing values pass

Are there relevant screenshots you can add to the PR description? NO

What ticket does this PR close?
Connected to #69
Checklists
Change log

[x] The CHANGELOG has been updated, or
[ ] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[x] This PR does not require updating any documentation

Hi @abrahamko ,
Have you had a chance to look at my review comments?
Please let me know if I can help on this, this is a good change to get in.
Cheers,
Dane

Hi @diverdane ,
Thanks for the detailed review.
I handled your comments as you suggested, and verified they behave as you would expect.
Still, since there are defaults in the values.yaml that does not comply with the schema, I had to comment them out too. (the cert, key etc.)
The Helm Linter still fails because there's a bug in the linter that prevents it from using the --set, so it only sees the default (which is empty).
This was fixed in latest helm release 3.3.0, which was released 5 days ago ;)
If you can upgrade the helm used to do the lint verification, it should be removed.

Hi @abrahamko,
That Helm Linter error is a Linter bug that was resolved in Helm 3.3.0:
https://github.com/helm/helm/issues/7273
I don't know if the Github actions for Helm linter will run with Helm 3.3.0, but can you try this change:
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 955b5a2..164920a 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -15,7 +15,8 @@ jobs:
       - name: Install Helm
         uses: azure/setup-helm@v1
         with:
-          version: v3.2.1
+          # Use Helm v3.3.0 to include helm/helm PR #7984
+          version: v3.3.0

       - name: Run linter
         run: helm lint --set dataKey=BLOB ./conjur-oss
diff --git a/conjur-oss/values.yaml b/conjur-oss/values.yaml
index fb19141..966313b 100644
--- a/conjur-oss/values.yaml
+++ b/conjur-oss/values.yaml
@@ -47,7 +47,8 @@ database:

 # Conjur data key, 32 byte base-64 encoded string for data encryption.
 # Generate one with `docker run --rm cyberark/conjur data-key generate`.
-dataKey: ""
+# This is a required setting.
+# dataKey:

 # Annotations to apply to the Conjur deployment.
 deployment:

If the Helm linter CI passes with this change, can you please:

Delete the added line in the CHANGELOG.md file (per @izgeri's earlier request)
Squash the changes into one commit

Thank you!


Can you elaborate on characters that can be used in pattern part ?

The code example mentions contoso?????? and contoso-???-## as possible allowed patterns. I assume the ? is for a character and # is for a digit or so. But that's not described anywhere. It doesn't seem to be Regex stuff - so do you have more info on this ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1368fd3-38cc-db26-ae9c-789bc399df00
Version Independent ID: 674614c1-229b-17de-d64e-48821b071771
Content: Sample - multiple name patterns - Azure Policy
Content Source: articles/governance/policy/samples/allow-multiple-name-patterns.md
Service: azure-policy
GitHub Login: @DCtheGeek
Microsoft Alias: dacoulte

#assign:DCtheGeek

Hi @jochenvanwylick. Thank you for the question.  The patterns allowed are described in the conditions section of the Policy definition structure doc.  Specifically:

When using the like and notLike conditions, you provide a wildcard * in the value. The value shouldn't have more than one wildcard *.
When using the match and notMatch conditions, provide # to match a digit, ? for a letter, . to match any character, and any other character to match that actual character. match and notMatch are case-sensitive. Case-insensitive alternatives are available in matchInsensitively and notMatchInsensitively. For examples, see Allow several name patterns.

Support for Regex is marked as Planned in our UserVoice. If this feature is important to you, please vote for it.  This information helps the team plan and prioritize work.  Let me know if the doc link provides the information you were looking for. Thanks!
@MicrosoftDocs/azure-cxp-triage Please label 'product-question' and #in-progress.

@jochenvanwylick - Since the information you were looking for is provided above, I'm going to close this Issue.  If you have related feedback, please feel free to continue to comment here.  If you have a new issue with docs, please open a new issue.  Thanks for the question!
@MicrosoftDocs/azure-cxp-triage #please-close