wallet v5r1 create_external_message send boc error

I use V5R1 Wallet to send some TON, but when I use toncenter api to send base64 encoded boc, it failed.
code
    let keypair = mnemonic.generate_keypair(None)?;
    let wallet = Wallet::<V5R1>::derive(0, keypair, V5R1_MAINNET_WALLET_ID)?;

    let transfer_val = 30_000_000.to_biguint().unwrap();
    let msg = Message::transfer(wallet2.address(), transfer_val, false).normalize()?;
    let action = SendMsgAction {
        mode: 3,
        message: msg,
    };
    let external_msg = wallet.create_external_message(Default::default(), 8, [action], false)?;

    let boc = BagOfCells::from_root(external_msg.to_cell()?);
    println!("boc: {boc:?}");
    let packed = pack_with(
        boc,
        BagOfCellsArgs {
            has_idx: false,
            has_crc32c: true,
        },
    )?;

    let bytes = packed.as_raw_slice();

    let boc_bs64 = base64::engine::general_purpose::STANDARD.encode(bytes);
    println!("base64: {boc_bs64}");

anything I'm wrong? need help !

I use V5R1 Wallet to send some TON, but when I use toncenter api to send base64 encoded boc, it failed. code
    let keypair = mnemonic.generate_keypair(None)?;
    let wallet = Wallet::<V5R1>::derive(0, keypair, V5R1_MAINNET_WALLET_ID)?;

    let transfer_val = 30_000_000.to_biguint().unwrap();
    let msg = Message::transfer(wallet2.address(), transfer_val, false).normalize()?;
    let action = SendMsgAction {
        mode: 3,
        message: msg,
    };
    let external_msg = wallet.create_external_message(Default::default(), 8, [action], false)?;

    let boc = BagOfCells::from_root(external_msg.to_cell()?);
    println!("boc: {boc:?}");
    let packed = pack_with(
        boc,
        BagOfCellsArgs {
            has_idx: false,
            has_crc32c: true,
        },
    )?;

    let bytes = packed.as_raw_slice();

    let boc_bs64 = base64::engine::general_purpose::STANDARD.encode(bytes);
    println!("base64: {boc_bs64}");

anything I'm wrong? need help !

@alexlee85 You're experiencing transcript error. It sounds like your query would be best dealt with by the support team.
I'll have to refer you to the official support live chat with the ticket ID TON07638
Please see the link below to our dedicated support line:
Ton live support
Note; Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent

@alexlee85 You're experiencing transcript error. It sounds like your query would be best dealt with by the support team.
I'll have to refer you to the official support live chat with the ticket ID TON07638
Please see the link below to our dedicated support line:
Ton live support
Note; Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent.

Hi, @alexlee85!
Thank you for your feedback!
TonCenter and other TON APIs usually just ignore the messages that failed at the stage of simulation, as it makes no sense to actually propagate this message further to the validators as it would likely fail there as well.
It seems like there can be either two reasons for it:

You generate the keypair right before sending the transaction. So, there is no code deployed on this address. Therefore, you should pass state_init = true on wallet.create_external_message(...)
The address of the wallet contract that is about to be deployed would also have zero TON balance, so it would fail to pay the state_init fees. You have to deposit some TON to this address first by sending non-bouncible transfer to this address. This type of transfer is usually done by wallet applications like Tonkeeper.

There can also be something wrong with impl WalletVersion for V5R1, but I would start with fixing these two mentioned above first.
If the problem still occurs, please let me know and I'll investigate further!


LinearProgressIndicator is not working

Flutter is already up to date on channel beta
Flutter 1.23.0-18.1.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision 198df796aa (3 weeks ago) • 2020-10-15 12:04:33 -0700
Engine • revision 1d12d82d9c
Tools • Dart 2.11.0 (build 2.11.0-213.1.beta)
given error:
═══════════════════════ Exception caught by widgets library ═════════════════════════════
Unexpected null value.
The relevant error-causing widget was:
LinearProgressIndicator
with Circular one is working without problems

Can you provide a small self-contained example that demos the problem, as well as the output from flutter doctor?

Hi @FrancescoMasaia
We will need a clear actual vs expected results of the issue.

import 'package:flutter/material.dart';
void main() => runApp(MyApp());

class BookPages extends StatefulWidget {
  @override
  _BookPagesState createState() => _BookPagesState();
}

class _BookPagesState extends State<BookPages> {
  @override
  Widget build(BuildContext context) {
    //return new CircularProgressIndicator();
    return new LinearProgressIndicator();
    );
  }
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Container(
      child: Center(
        child: BookPages(),
      ),
    );
  }
}

return new CircularProgressIndicator, works but when I switch to LinearProgressIndicator() it gives me that error
flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, 1.23.0-18.1.pre, on Linux, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Chrome - develop for the web
[!] Android Studio (not installed)
[✓] VS Code (version 1.47.3)
[✓] Connected device (3 available)
! Doctor found issues in 1 category.

This appears to be a consequence of https://github.com/flutter/flutter/pull/69060.  Including a widget that include a Directionality widget, like MaterialApp, will fix the problem.
CC @goderbauer

The LinearProgressIndicator always needed a Directionality widget, even before #69060. However, before that PR you were getting a undescriptive error null assertion error. With this change in place you get the more descriptive error that tells you to wrap your app in a MaterialApp or Directionality widget. Doing so is the right fix here.


Render the tabs only once

🚀 Feature
To render all the TabItems instead of rendering just the default one, so click on a tab label just changes what tab is visible instead of triggering the rendering of the tab in the runtime of users' browsers.
Have you read the Contributing Guidelines on issues?
Yes.
Motivation
With a large code block under a tab, there's a lag between clicking on a tab and the tab being shown.
Pitch
If all the tabs are being rendered and clicking on a label just changes what tab is visible instead of rendering a new tab, it would:

allow search engines to access the content of the tab (currently, only the content of the default tab is rendered in HTML),
get rid of noticeable and annoying time between the tab being clicked and being shown when the tab rendering takes some time (e.g. if there's a large code block).

A problem is: rendering all tabs ahead of time can also introduce a lag when we navigate to a large page with a lot of tabs in it :)
Maybe we could have an option to make them render more lazily, but not sure this would play well with server-side rendering, SEO and hydratation...

Implemented in #3706.

Implemented in #3706.

Good job, thanks!


slack.Block is not a thing anymore?

After running mod init in my Slack bot projects folder, the method doesn't exist in the library. slack.Attachment and others are though.
Since this is a newer implementation I figured I'd try to update the package, but the go pkg manager claims to have the latest build.
Below is present in my go.mod

github.com/nlopes/slack v0.5.0

When trying to update all packages, I get below error message too.
Below is the output of go get -u all
grvlle$ go get -u all                                                      :(
go: finding github.com/lusis/go-slackbot latest
go: finding github.com/erikstmartin/go-testdb latest
go: finding golang.org/x/crypto latest
go: finding github.com/denisenkom/go-mssqldb latest
go: finding github.com/jinzhu/inflection latest
go: finding github.com/lusis/slack-test latest
go: finding gopkg.in/check.v1 latest
github.com/lusis/slack-test
../../../go/pkg/mod/github.com/lusis/slack-test@v0.0.0-20190408224659-6cf59653add2/types.go:80:2: undefined: slack.WebResponse
github.com/lusis/go-slackbot
../../../go/pkg/mod/github.com/lusis/go-slackbot@v0.0.0-20180109053408-401027ccfef5/bot.go:173:8: params.Attachments undefined (type slack.PostMessageParameters has no field or method Attachments)
../../../go/pkg/mod/github.com/lusis/go-slackbot@v0.0.0-20180109053408-401027ccfef5/bot.go:175:50: cannot use "" (type string) as type slack.MsgOption in argument to b.Client.PostMessage
../../../go/pkg/mod/github.com/lusis/go-slackbot@v0.0.0-20180109053408-401027ccfef5/bot.go:175:50: cannot use params (type slack.PostMessageParameters) as type slack.MsgOption in argument to b.Client.PostMessage

@grvlle you're using release tag 0.5.0 but at that point in time the Block logic was not yet present in the project

Figures. Thanks @alyosha for the quick reply! How do I go about and update to the latest version? Go get -u all seems to assume 0.5.0 is the latest version. I guess I can clone it manually as a last resort.

I was just trying to use this also and had the same question.  I ran into this article:  https://medium.freecodecamp.org/an-intro-to-dep-how-to-manage-your-golang-project-dependencies-7b07d84e7ba5
Wrote this down in my notes for future me:
dep init

Say I want to use "github.com/nlopes/slack" from master instead of one of the releases.  In the Gopkg.toml
file change:
[[constraint]]
  name = "github.com/nlopes/slack"
  #version = "0.5.0"
  branch = "master"

Then run
dep ensure

This might take a minute.
If you do a:
git diff

You should see that the Gopkg.lock file has changed to the master.

Amazing! Thanks @sekka1. This can be closed.

Actually, I followed the instruction to point to the master branch. But When I use Jenkins to build, it does not respect the configuration. In other words, It is still looking for the 0.5.0 release version.
Can We make a new release?


feat(reg-exp-router): error handling for duplicate param name

The actual check feature was added by bd42c418100a28bba2cd584ad43424e48325baf5;  f969924a144705663d6be42294e77af40135b01a and 2baa25302d63250af7155212471d98a844eb86d7 are optional.
I made one PR because it has to do with the timing of the check. If we cannot agree on the implementation of an optional part, I will reconsider.
Check for duplicate parameter names bd42c418100a28bba2cd5
I think it's OK because it's implemented honestly.
Add router.prepare and invoke #router.prepare() in hono.fire f969924a144705663d6be42294e77af40135b01a and 2baa25302d63250af7155212471d98a844eb86d7
The RegExpRouter architecture makes it difficult to perform detailed routing checks during the add() phase, so we would like to perform the checks later, when all routing information is available. This would be a different behavior than the TrieRouter, but I think that the different timing of detection would be permissible with respect to this issue.
While this check can do on the "initial request" as it has been in the current master branch, I think it would be better if it could do on prior phase.
As such, I hope to have an API that allows the router to know that hono.fire() has been executed.
This API also allows control over when to delete this.routeData, so that RegExpRouter, like TrieRouter, can call match() and then add(). This makes it easier to write tests.
router.add('GET', '/:type/:action', 'foo')
const res = router.match('GET', '/posts/123')
expect(res).not.toBeNull()
router.add('GET', '/posts/:id', 'bar') // error on the current branch. API would allow us to do this.

@usualoma Thank you!

Check for duplicate parameter names

Great! This feature is really wanted.

Add router.prepare and invoke #router.prepare() in hono.fire

Actually, I don't agree with this. Because whether callingfire() is not promised.
With Cloudflare Module Worker format, we don't use addEventListener. We export fetch like this:
export default {
  fetch(request: Request, env: Env, event: FetchEvent) {
    return app.fetch(request, env, event)
  },
}

or just like this:
export default app

So we can't determine the timing that the user has prepared to set the routings.

While this check can do on the "initial request" as it has been in the current master branch, I think it would be better if it could do on prior phase.

I think it's OK to go with the way for the master branch.

Oh, I didn't study enough.
I will close this PR and rebuild it with the following feature.

Check for duplicate parameter names


Remove byteorder dependency

Hi,
I came across the use of "byteorder" in this crate and thought "one does not really need byteorder for this". Feel free to disagree and to just close this PR.
Since there are many uses of "byteorder", I tried to do this in small parts and do a commit for each one. Hopefully this makes it easier to understand what is going on. Dunno.
Then I noticed that actions are failing in my fork. The last few commits make rustfmt and clippy happy. These changes are unrelated to this PR. Feel free to cherry pick what you want.
Note that CI will still fail, because:
error: package `base64ct v1.6.0` cannot be built because it requires rustc 1.60 or newer, while the currently active rustc version is 1.59.0

I'll leave that one to you.

This repo is no longer maintained. Could you please rebase this change against https://github.com/zip-rs/zip2 and submit it there?


[ARPA P&E Reporting] Subaward City Name

Submitted Description:
can the tool remove any periods in the Subaward city name when it goes to the Report export (treasury import)? The portal kicks back an error in this field if a period is included.
Context
Users fill out submit an excel workbook for upload through the "Submit Workbook" flow in the the arpa reporter tool.
Current State
When the upload is submitted we are not throwing an error when there is a . character in the "Subaward City name" field.
Ideal State
When the upload is submitted we should throw a validation error when a . character is found in the "Subaward City Name" field.
Ex: St. Louis results in an error
Eng Resources

Where the upload happens on the front-end: https://staging.grants.usdr.dev/arpa_reporter/new_upload
Upload validation begins here: https://github.com/usdigitalresponse/usdr-gost/blob/_staging/packages/server/src/arpa_reporter/services/validate-upload.js#L570

@jcomeau1 do you have any context here by any chance?

Ideally if there is a . character in the sub-award city-name this should throw an error during an upload validation

This item is referring to Place_of_Performance_City__c (column U on the Awards > 50000 sheet). While I wonder if there are other special characters that aren't allowed as well, we can always add a new issue to address that.

In the partner meeting today, the following clarifications/desires were made:

Currently unknown if only alpha characters can be used, so limit just to the "." for now
Ideally, issue a WARNING upon upload if a "." is present
Ideally, strip the "." from the name and store/send to US Treasury

Numbers 2 & 3 should be done together. If we can't do it in time, then it would be best to issue an ERROR if a "." is present.


Pattern Matching Couchbase Lite

Hi,
I am new in Couchbase lite. i am wondering how to write pattern matching query in Couchbase . similar to 'LIKE' pattern in SQL.
Suppose I have a document with id, name, and email. i want to filter the documents that having the name starts with letter 'A'
Thanks in advance

You can refer to this example to setup the query https://developer.couchbase.com/documentation/mobile/2.0/guides/couchbase-lite/native-api/query/index.html?language=java
But instead of using the equalTo operator you can use the like operator http://docs.couchbase.com/mobile/2.0/couchbase-lite-java/db008/com/couchbase/lite/Expression.html#like-java.lang.Object-. Like in SQL, the % character can be used as a wildcard.
Thanks for the feedback, we will include an example of it in the docs.

Hi Jamiltz,
Thanks for your comments. could you please like to provide sample code for using like operator in Couchbase Database Lite in android.

@kundan7560 I forgot to ask, did you ask that question for the 2.0 or 1.x API?

@jamiltz I have added the below dependency
compile 'com.couchbase.lite:couchbase-lite-android:1.4.0' and I need to setup the code for this. if you find any solution always welcome.
Thank You

You can use the prefixMatchLevel operator in this case https://developer.couchbase.com/documentation/mobile/1.4/guides/couchbase-lite/native-api/query/index.html#creating-and-configuring-queries


feat: add stream plugin for gcp pubsub

Description
As discused on slack here, i'm opening a draft PR that contains the code we wrote (at @reelevant-tech) to consume gcp pubsub message into Pinot.
We only recently started using it (not yet in production) so we are not sure if it's working well or not, thats we are interested in feedback from the pinot community.
If the community find this addition useful, we'll add some tests and update the documentation so other can use it on their own !
Our original implementation (and releases) are available here as standalone plugin: https://github.com/reelevant-tech/pinot-pubsub-plugin

Codecov Report

Merging #6450 (8472e2b) into master (1beaab5) will decrease coverage by 1.20%.
The diff coverage is 56.80%.

@@            Coverage Diff             @@
##           master    #6450      +/-   ##
==========================================
- Coverage   66.44%   65.24%   -1.21%
==========================================
  Files        1075     1330     +255
  Lines       54773    64927   +10154
  Branches     8168     9469    +1301
==========================================
+ Hits        36396    42363    +5967
- Misses      15700    19533    +3833
- Partials     2677     3031     +354

Flag
Coverage Δ

unittests
65.24% <56.80%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <0.00%> (+9.52%)
:arrow_up:

.../main/java/org/apache/pinot/client/Connection.java
35.55% <0.00%> (-13.29%)
:arrow_down:

...inot/client/JsonAsyncHttpPinotClientTransport.java
10.90% <0.00%> (-51.10%)
:arrow_down:

...not/common/assignment/InstancePartitionsUtils.java
73.80% <ø> (+0.63%)
:arrow_up:

...common/config/tuner/NoOpTableTableConfigTuner.java
100.00% <ø> (ø)

...ot/common/config/tuner/RealTimeAutoIndexTuner.java
100.00% <ø> (ø)

... and 1165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c4636...8472e2b. Read the comment docs.

Codecov Report

Merging #6450 (8472e2b) into master (1beaab5) will decrease coverage by 1.20%.
The diff coverage is 56.80%.

@@            Coverage Diff             @@
##           master    #6450      +/-   ##
==========================================
- Coverage   66.44%   65.24%   -1.21%
==========================================
  Files        1075     1330     +255
  Lines       54773    64927   +10154
  Branches     8168     9469    +1301
==========================================
+ Hits        36396    42363    +5967
- Misses      15700    19533    +3833
- Partials     2677     3031     +354

Flag
Coverage Δ

unittests
65.24% <56.80%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <0.00%> (+9.52%)
:arrow_up:

.../main/java/org/apache/pinot/client/Connection.java
35.55% <0.00%> (-13.29%)
:arrow_down:

...inot/client/JsonAsyncHttpPinotClientTransport.java
10.90% <0.00%> (-51.10%)
:arrow_down:

...not/common/assignment/InstancePartitionsUtils.java
73.80% <ø> (+0.63%)
:arrow_up:

...common/config/tuner/NoOpTableTableConfigTuner.java
100.00% <ø> (ø)

...ot/common/config/tuner/RealTimeAutoIndexTuner.java
100.00% <ø> (ø)

... and 1165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c4636...8472e2b. Read the comment docs.

I'm closing this since its currently implement high level stream but those are useless in their current state.


RegionFlag: parse user_data as String

Hey, apologies but I am not sure the right way to do this.  My first commit is just to naively read the whole user_data as a String even though I know it ends with a 0x95 at the end - which is not a valid ascii character.
My second commit is doing this differently - omitting that character and then appending it when serializing.  Let me know your thoughts.

Cool, yep I think the second commit makes sense. That's basically how things are being handled in StringHash too. The null gets stripped and then later added back on during serialization. As far as I know they're all null terminated.


Shell Command for Custom Configuration

OS: Windows 10.0.18363 Build 18363
VSCode version:  1.45.1
Extension version: 1.5.0
Toolchain version: nightly-2020-03-10-x86_64-pc-windows-msvc
Build target: x86_64-pc-windows-msvc
Python version: 3.8.2
Our Rust project uses cargo-make instead of regular cargo, because we need more complicated steps with copying external files etc. This means that we can't use CodeLLDB's built-in support for cargo.
I've worked around this by creating a custom launch configuration:
        {
            "type": "lldb",
            "request": "custom",
            "name": "Debug Core",
            "targetCreateCommands": [
                "platform shell -t 120 -- cargo make --cwd .. debug-dist",
                "file \"${workspaceFolder}/../dist/development/debug <path-to-exe>\""
            ],
            "processCreateCommands": [
                "process launch --stop-at-entry"
            ],
            "sourceLanguages": ["rust"]
        }

This works fine. However, since the build command is run through lldb, it swallows the return code of that build. I can't find a way to get lldb to abort the operation if the shell command returns an error. This often means that running the debugger inside VSCode runs an old binary without me noticing, because I didn't see the error in the log file.
It would be great if CodeLLDB would allow me to directly run a shell command before starting lldb, and for it to stop when there's a non-zero return code. This would also fix all the issues with the timeouts, since builds can take a long time, especially with Rust.

Can't you just use tasks.json to run your build command?  Then make launch configuration dependent on that task via preLaunchTask.
BTW, "cargo": { ... } was designed to be used  with tests, because cargo test generates binaries with hard to guess names.  For launching non-test binaries I'd just use an explicit program path.

That worked perfectly, thank you! That approach is very hidden in the documentation, I'd never have found it.

preLaunchTask is common for all vscode debuggers.

Unfortunately, this still doesn't stop the launch from happening when the build fails…

When a task fails, VSCode should ask you whether you want to debug anyways, - unless you've disabled this prompt at some point.


Update README for Improved Documentation

Clear and well-structured documentation is crucial for users and contributors to understand the project, its purpose, and how to get started. The current README is not visually appealing. I propose to make it more visually appealing by adding badges for tech stack, visiter count, issue count, fork count and other items.
hey @dvjsharma  , please assign this issue to me.

Go ahead @jinx-vi-0

hey @dvjsharma , I have created a pr please check it and let me know for any feedback.


Support of aliases

Done in https://github.com/wavesplatform/waves-c/commit/13002b3397d6999631013101f40ba5ae533aecff


Update register flow to redirect back to application form

This PR ensure if the registeration is required before applying to a
fund then after registeration or after using forgot password the user
lands to the form submisison pages are password reset and/or register is
successful.
This PR also updates forgot password email template to be consistent with
other email format.
The flow to set the password after clicking on the activation link is
kept as it is.

This is should good for testing now.


Wrap console log && support --no-log

Fix issue #690
Provide an option --no-log to disable all log from taiko itself, but still, allow user's script to use console.log
# will disable logs from within taiko itself
$ taiko user.js --no-log

@gaugebot recheck the pull request.


Compiling AVS for ubuntu, problem with Sensory

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

When getting to the part in the guide i get to the part to download Sensory, i git clone it into third-party and wheni try to run it it gives me this error:
license.sh: line 49: /home/ubuntu/Desktop/UbuntuAlexa/third-party/alexa-rpi/bin/sdk-license: cannot execute binary file: Exec format error Unexpected licensing error encountered. Exiting.
What is the expected behavior?

It should go through and accept the licence
What behavior are you observing?

it gives an error
Provide the steps to reproduce the issue, if applicable:

This section of this GitHub issue
for Sensory:
cd ~/sdk-folder/third-party
git clone --depth 1 https://github.com/Sensory/alexa-rpi.git
cd alexa-rpi
./bin/license.sh;
Tell us about your environment:

What version of the AVS Device SDK are you using?
  <1.22.0>

Tell us what hardware you're using:

[x] Desktop / Laptop
[ ] Raspberry Pi
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[x] Other - tell us more: Ubuntu 18.04

Closing this issue.


mpu9250 wrapper: support updating gyro & accel cutoff via parameter

useful for tuning snapdragon flight tuning

Signed-off-by: Roman<EMAIL_ADDRESS>

@lamping7 another ROS mission failure
http://ci.px4.io:8080/blue/organizations/jenkins/Firmware/detail/PR-9344/1/pipeline
https://logs.px4.io/plot_app?log=6899b81d-2190-40bd-83be-4ed8b50bbc11
Mission reached problem?

Yes. Looks that way. Need to look harder at it, but seems to be the same intermittent issue that popped up a month or so ago.


Change default branch name to main

[x] Change default branch name from master to main
[x] Add default branch protection rule to main branch
[ ] Figure out how to manage default branch name change re: tags in production clones
[ ] Update clones to use main as default branch name (commands below):

git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

Tags in production clones appear to be unaffected by changing default branch name. On arbutus, the following was successful:
git switch master
git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a
git pull

with the PROD-nowcast-green-201905-v2 tag/branch that the clone had been at being preserved to switch back to.


Store CC license information at individual bitstream level

Many repositories stores multiple files inside a single record (item) with slightly different license conditions.
This could be the case of an item where the pre-preprint / author manuscript is stored aside the published version or a dataset or a slidedesk is stored aside the article.
These extra materials often have diverse licenses than the "main resource". The option to use separate items for such scenarios is over-complicated / sub-optimal for other aspects (multiple entries in the search results, listing, etc).
Describe the solution you'd like
It should be possible to enable a creative-commons integration at the bitstream level
Describe alternatives or workarounds you've considered
CC Licenses can be stored as just metadata configuring manually a dropdown with current values

This seems like a good suggestion, and it'd be fairly straightforward to add CC Licenses (as metadata) to Bitstreams.  However, it'd obviously require UI and REST API enhancements.  Currently this seems like lower priority though so I'm moving this to our Tier 4 board. We could change the priority later as we get more feedback.


BROOKLYN-569: aggregator casts vals to numbers

Retest this please
Test failure is unrelated: ElectPrimaryTest.testSelectionModeFailoverReelectWithPreference. The info log from jenkins has the lines shown below. This tells us that ElectPrimaryEffector is being called twice - once directly int the test, and presumably concurrently by the policy's onEvent (it triggers that whenever a child/member is added/removed or its serviceUp/serviceState/weighting sensor changes). There is a definite race there, which can happen when the effector is being called manually.
2017-12-11 17:28:13,488 INFO  Test created app, and will now start BasicApplicationImpl{id=jt5d932r4f}
2017-12-11 17:28:13,515 INFO  Detected new primary TestEntityImpl{id=jt0dh78cvw} at BasicApplicationImpl{id=jt5d932r4f} (previously had null)
2017-12-11 17:28:13,515 INFO  Primary TestEntityImpl{id=jt0dh78cvw} at BasicApplicationImpl{id=jt5d932r4f} detected as healthy
2017-12-11 17:28:13,528 INFO  Started application BasicApplicationImpl{id=jt5d932r4f}
2017-12-11 17:28:13,530 INFO  Detected new primary TestEntityImpl{id=ndkegu8wyc} at BasicApplicationImpl{id=jt5d932r4f} (previously had TestEntityImpl{id=jt0dh78cvw})
2017-12-11 17:28:13,531 INFO  Detected new primary TestEntityImpl{id=jt0dh78cvw} at BasicApplicationImpl{id=jt5d932r4f} (previously had TestEntityImpl{id=ndkegu8wyc})
2017-12-11 17:28:43,544 INFO  failed succeeds-eventually, 75 attempts, 30000ms elapsed (rethrowing): java.lang.AssertionError: attribute=Sensor: primary (org.apache.brooklyn.api.entity.Entity); val=TestEntityImpl{id=jt0dh78cvw}

@aledsage minor comment, merge when ready

Tested, LGTM, thanks @aledsage


Add an optional URL whitelist safeguard

Hi, love the new safeguards, running DatabaseCleaner has always made me a little nervous.
We run our tests in docker containers so we've had to disable the remote URL check in our pipeline, so I added an option to set a whitelist of URLs.

@etagwerker change made, thanks a lot!

@benclewis Great, thanks! 💯

@etagwerker Could we cut a new version for this? 🙏


Discrepancy in behavior of QTree[Long] and QTree[Double] for quantileBounds

Been poking arond with the Algebird 0.12.0 release (which included fix: https://github.com/twitter/algebird/pull/472/files). Noticed that the behavior for QTree[Long] and QTree[Double] is fairly different when you try to pick up the 0.5 quantile (median):
val longList = List(1L, 2L)
val qtreeSemigroup = new QTreeSemigroup[Long](6)
val qt = longList.map{ QTree(_) }.reduce{ qtreeSemigroup.plus(_, _) }
qt.quantileBounds(0.5)

res1: (Double, Double) = (2.0,3.0)

This seems incorrect. When I try the same as doubles:
val doubleList = List(1.0, 2.0)
val qtreeSemigroup = new QTreeSemigroup[Double](6)
val qt = doubleList.map{ QTree(_) }.reduce{ qtreeSemigroup.plus(_, _) }
qt.quantileBounds(0.5)

res1: (Double, Double) = (2.0,2.0000152587890625)

instead of 2.0 -> 3.0 the range is 2.0 -> 2.0 which seems more sane.
(See a similar issue when I have a list of 1L, 2L, 3L -> median is (2.0, 3.0) instead of (2.0, 2.0000152587890625) when the list is 1.0, 2.0, 3.0 ).
Wondering if the above behavior difference is expected? Or is this an issue we should probably explore and fix?

@avibryant - @johnynek mentioned that you might know more so tagging you on this.

Quick pointer: this is related to the level parameter in https://github.com/twitter/algebird/blob/develop/algebird-core/src/main/scala/com/twitter/algebird/QTree.scala#L45. For a Double this defaults to -16 (which is to say, the smallest resolution is 2^-16). For a Long this defaults to 0.
This issue highlights that this is maybe a bad idea, or maybe there's something else in the semantics of these bounds that needs fixing.

Yep.  If instead of QTree(_) you use:
QTree(131072,-16,1,_,None,None)
The results will be the same (the result you're seeing for Double right now).

Yeah noticed that the offset and level params were pretty different for the long & doubles. Do you know why that is the case? Why not the same values for both?

Yeah that makes sense. I can keep reducing the resolution (from 2^-16 to 2^-1) and the range gets wider:
val qt = longList.map{ QTree(32,-4,1,_,None,None) }.reduce{ qtreeSemigroup.plus(_, _) }
scala> qt.quantileBounds(0.5)
res12: (Double, Double) = (2.0,2.0625)
...
scala> val qt = longList.map{ QTree(4,-1,1,_,None,None) }.reduce{ qtreeSemigroup.plus(_, _) }
qt: com.twitter.algebird.QTree[Long] = (4,-1,2,3,None,None)

scala> qt.quantileBounds(0.5)
res16: (Double, Double) = (2.0,2.5)

Some beginners bug these are. I do not understand this correction as it would work for a tree than has more than two nodes seeing how QTree[Doubles] are created, right?  (I might be missing something big here)


Strange artifacts when rendering SVGs with opengl

Description of bug / unexpected behavior

When renderering some svgs the opengl renderer sometimes renders random lines, or missing pieces from the svg. This issue doesn't exist in cairo
Expected behavior

Expected svg to render similar to cairos without missing pieces or added artifacts. Just mentioning #1762 and #1890 here as just looking at it visually I wonder if they could be related. See media screenshots
How to reproduce the issue

Render half_ellipse.svg or arcs01.svg with code below to see issue.
Code for reproducing the problem
class SvgTest(Scene):
    def construct(self):
        a = SVGMobject("../tests/test_graphical_units/img_svg_resources/half_ellipse.svg")
        self.add(a)
        self.interactive_embed()

class SvgTest(Scene):
    def construct(self):
        a = SVGMobject("../tests/test_graphical_units/img_svg_resources/arcs01.svg")
        self.add(a)
        self.interactive_embed()

Additional media files

Images/GIFs
OPENGL arc:

Cairo arc:

Opengl half ellipse:

Cairo half ellipse:

Logs
Terminal output

PASTE HERE OR PROVIDE LINK TO https://pastebin.com/ OR SIMILAR

System specifications
System Details

OS (with version, e.g Windows 10 v2004 or macOS 10.15 (Catalina)):
RAM:
Python version (python/py/python3 --version):
Installed modules (provide output from pip list):

PASTE HERE

LaTeX details

LaTeX distribution (e.g. TeX Live 2020):
Installed LaTeX packages:

FFMPEG
Output of ffmpeg -version:
PASTE HERE

Additional comments

Just realised that this issue seems to be environment specific, I only get this on Mac OS, windows seems to render fine

Hi @ryanmccauley211, I'm having a similar same issue with SVGMobject on Mac OS, did you ever find a way around it?


[FeatureRequest] Monitoring metrics for supervisors  status

Description
Currently, there is no way of monitoring the state of supervisors' health via monitoring metrics.
I would like to request a metric (or set of metrics) to report the following:

Supervisor health status: whether a supervisor is healthy or not. (Druid API).
Supervisor current state/status: e.g.: RUNNING,  SUSPENDED, etc ... (List of possible states)

Motivation

To be able to monitor the status of Druid supervisors via monitoring metrics.
Supervisor is a critical piece of Druid when performing streaming ingestion.

A caveat we should definitely consider in this request is how we can represent string labels as metrics.

Most of the metrics aggregation systems work great with numerical values, but with string values things start getting complex. For instance, Prometheus supports count, histogram, gauge, and summary type of metrics (https://prometheus.io/docs/concepts/metric_types/).

One approach can be encode strings as numerical values, like RUNNING state maps to 1, SUSPENDED maps to 2, etc.

The current supported metrics on Druid as well have numerical format only: https://druid.apache.org/docs/latest/operations/metrics/

@ashwintumma23 AFAIK this is not an issue for Prometheus.
A sample implementation could rely on a Prometheus gauge metric that have two possible values: 0 or 1 and leverage "dimensions" (Prometheus labels) to store the different states RUNNING, SUSPENDED, etc as strings and the also a separate label for the supervisor id. (https://prometheus.io/docs/concepts/data_model/)
The value 1 correspond to the current/active state of any given supervisor.


Enums don't support default values in controllers' arguments

Using drf-yasg 1.13 doesn't seem to help

The fix needs a pull request to drf-yasg which makes drf-yasg to use JSONRenderer specified in django settings instead of direct json.dumps and drf.JSONRenderer calls.

Hey, guys. Met same bug recently and decided to prepare it's description for you to assist with making problem visibility more clear.
Bug description
When the argument of a route is annotated as enum and default value is set, following exception happens on attempt to access Swagger schema: TypeError: Object of type 'SomeEnum' is not JSON serializable
To Reproduce

Prepare a controller with some route_get;
Add a parameter to route_get like: @route_get('/hello/{?param}');
Annotate parameter with enum and set enum-based default;

from enum import Enum

import winter

class FooParam(Enum)
    FOO = 'foo'
    BAR = 'bar'

@winter.controller
class HelloWorldController:

    @winter.route_get('/hello/{?param}')
    def hello(self, param: FooParam1 = FooParam.FOO):
        return f'Hello, world!'

Properly setup drf-yasg to a project:
4.1. Set 'DEFAULT_AUTO_SCHEMA_CLASS': 'winter_openapi.inspectors.SwaggerAutoSchema' in SWAGGER_SETTINGS;
4.2. Call winter_openapi.setup() somewhere in service entrypoint code;
Try access Swagger schema.

Expected behavior
Default enum value is scanned normally, Swagger schema is successfully built and can be accessed.
Code snippets
Minimal code snippet is given above.
Screenshots

Environment:

OS: Docker 19.03.12
Python: CPython 3.6
Winter version: 4.1.0


Update master / boris configuration

@charleso @tmcgilchrist
Not sure if the boris.toml is actually valid toml or not
Might move the master files to a single location and symlink

Seems like it should be valid toml.
🚀


Flux-vector control for induction machines

This pull-request adds a simple implementation and an example script for flux-vector control for induction machines.
Documentation could be added at a later time.

Thanks for the pull request! I'll merge this now. Let us fix some details in a separate PR soon.


Static analysis updates and refinement

add utility function for getting all targets (necessary for ASAN improvements with Windows in cpp_starter_project)
add new recommended_project_options utility that provides the user with a set of recommended defaults

defaults can be overridden with variables before calling recommended_project_options
defaults to recommended levels of analysis per platform
adds a new "Developer Mode" and "User Mode"

Developer Mode: has all recommended analysis settings, is the default
User Mode: disables runtime analysis, static analysis, and warnings_as_errors, enabled with a single switch for people who just want to compile and run the program with no extra tools getting in their way

all options are configurable with CMake UIs

refine cppcheck options so common issues like "missing includes" do not cause failures
configure-time error if the user tries to enable PCH on GCC with clang-tidy, since clang-tidy cannot parse GCC's PCH files

@aminya I cannot see any way to actually mark your review as resolved, since it's on a file that was deleted. I can "dismiss" it, but opted to just request you re-review

I think this is ready to go and all changes have been addressed (indirectly in some cases). Notably: PCH is never enabled by default. That part of the README is documented to just be one thing that is possible to override the defaults on.

We can address my comment on the PCH header default in a separate PR
https://github.com/cpp-best-practices/project_options/pull/46#discussion_r796102393


Crash app because tag

Adding or removing tag on photo crash app
details in log
Xiaomi A2
Android 10
Build 208
taglog.txt

@vedranqa we need more details about how to reproduce, video would be really big help.
Also, are you sure this log is about tags?
    java.lang.RuntimeException: Canvas: trying to draw too large(399602368bytes) bitmap.
        at android.graphics.RecordingCanvas.throwIfCannotDraw(RecordingCanvas.java:280)
        at android.graphics.BaseRecordingCanvas.drawBitmap(BaseRecordingCanvas.java:88)
        at android.graphics.drawable.BitmapDrawable.draw(BitmapDrawable.java:548)
        at android.widget.ImageView.onDraw(ImageView.java:1434)
        at com.ortiz.touchview.TouchImageView.onDraw(TouchImageView.kt:276)
        at android.view.View.draw(View.java:21440)

This looks more like #139.

Didn't reproduce now. Will check other versions.

will resolve this, can't reproduce now


#2075 Improves TypeDescriptorModel performance

Resolves #2075

I think the spirit of this change makes sense.   @emteere Will you take a look at this?

@emteere I am not able to measure the improvement myself as my setup might require days to run it before these changes. However another user has informed me that analysis time went from 4 hours to 2 minutes. It is important to note that this is indeed impacting the analysis time of the built in Windows x86 PE RTTI Analyzer as well.
I think this change should make it in to the next release of ghidra as opposed to waiting until the release of 9.2 as well because of this.

This obviously needs a fix.  And you have made it much better.  I've been reviewing the implementation.
There are still multiple useless scans of the program bytes for the magic string until a data type is created and added into the program data type manager. The RTTIAnalzyer already searches once for the string, so right now it is getting searched for at least 5 times I think I counted even with this fix.
If the correct class to hold the information that a given program has been searched and the magic string found, possibly the RTTIAnalyzer, I would prefer the responsibility there.
There are already cross links to the magic string so the connection dependence is already there.
I propose calling a static method RttiAnalyzer.hasVFPointer(program) that would check a static hashmap for true/false and if not found go search and set it.   The private static HashMap  would map a programs hashcode to a Boolean indicating hasVFPointer.  Then the program is not being held onto, and only a very small amount of information is squirreled away that is really only needed once.
The RTTIAnalyzer could also set a property on the program that could be checked for in the hasVFPointer so the string is never searched for again.  Not necessarily worth it.
I still think the code to check the data structure is OK to make sure the data type pulled from the program is correct
Thoughts?

🤔
On Thursday, August 6, 2020, emteere<EMAIL_ADDRESS>wrote:

This obviously needs a fix. And you have made it much better. I've been
reviewing the implementation.
There are still multiple useless scans of the program bytes for the magic
string until a data type is created and added into the program data type
manager. The RTTIAnalzyer already searches once for the string, so right
now it is getting searched for at least 5 times I think I counted even with
this fix.
If the correct class to hold the information that a given program has been
searched and the magic string found, possibly the RTTIAnalyzer, I would
prefer the responsibility there.
There are already cross links to the magic string so the connection
dependence is already there.
I propose calling a static method RttiAnalyzer.hasVFPointer(program) that
would check a static hashmap for true/false and if not found go search and
set it. The private static HashMap would map a programs hashcode to a
Boolean indicating hasVFPointer. Then the program is not being held onto,
and only a very small amount of information is squirreled away that is
really only needed once.
The RTTIAnalyzer could also set a property on the program that could be
checked for in the hasVFPointer so the string is never searched for again.
Not necessarily worth it.
I still think the code to check the data structure is OK to make sure the
data type pulled from the program is correct
Thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NationalSecurityAgency/ghidra/pull/2077#issuecomment-670229334,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQQ3LSSODRQFKZ53RUCM25DR7MX3FANCNFSM4OUVYFNA
.

My initial though was to use a HashMap but figured it would be better to utilize existing information then to create another object to hold information which is already present and should be readily available.
If I were to have a go at this again I would likely create static instances of the two potential DataTypes. Then instead of searching memory, search the symbol table for the existing std::type_info::... label. If it exists, get the present data and check if it is equivalent to one of the static data types. If it does not, it is still much faster to check if the label is at the correct address by checking if the trailing string is correct. If all else fails then do the memory search. It should be a cleaner implementation since all the checking gets delegated to DataType.isEquivalent.
This approach would also have the benefit of ensuring the memory search only occurs once unless the user removes or changes the label. I don't see any logical reason for a user to do so though.
I'm also unsure of how good of an idea it is to hold a ProgramDB in a HashMap as it would be keeping a reference around even after the program is closed (I think). If that is the case then circumventing that may be more work that could be avoided.

The Hashmap wouldn't hold the programDB object, which as you mention would be problematic, Better would be a unique token for the program so the program is not referenced.  You definitely don't want to hold on to the program unnecessarily.
It does look like the string needs to be found, unless this code is re-factored as well.  The RTTIAnalyzer uses it to find the top RTT0 pointer.
As you mention there could be a better refactor for this.
The data type still needs to find its way into the programs data type manager before you can test for pre-existence.
The way it is coded right now, the scan for the string happens for each RTTI structure type and the analyzer, so 5 times.
This is really what drove me to consider a different implementation so the hasVFPointer fact can be recorded once.
Pulling the logic out to a separate place that only has to check once, and doesn't depend on the data type having been added to the program, which could occur later in processing would be better.
The string may be stripped from the binary, so no symbol.
Also it should look for it even in its mangled form, or else you are dependent on the demangler running as well.
You can fall back on the memory search if it is stripped, so that would be a better implementation.

The Hashmap wouldn't hold the programDB object, which as you mention would be problematic, Better would be a unique token for the program so the program is not referenced. You definitely don't want to hold on to the program unnecessarily.
It does look like the string needs to be found, unless this code is re-factored as well. The RTTIAnalyzer uses it to find the top RTT0 pointer.
As you mention there could be a better refactor for this.
The data type still needs to find its way into the programs data type manager before you can test for pre-existence.
The way it is coded right now, the scan for the string happens for each RTTI structure type and the analyzer, so 5 times.
This is really what drove me to consider a different implementation so the hasVFPointer fact can be recorded once.
Pulling the logic out to a separate place that only has to check once, and doesn't depend on the data type having been added to the program, which could occur later in processing would be better.
The string may be stripped from the binary, so no symbol.
Also it should look for it even in its mangled form, or else you are dependent on the demangler running as well.
You can fall back on the memory search if it is stripped, so that would be a better implementation.

Basically what I'm suggesting would be the following:

static utility method to get the address of the top RTTI0 structure. It would first search the symbol table for the label created by CreateTypeDescriptorBackgroundCmd and if it is not present it would fall back to the memory search. Whether or not the binary is stripped wouldn't matter.
The RttiAnalyzer uses said utility method to get the address of the RTTI0 structure and creates it with the CreateTypeDescriptorBackgroundCmd. This creates the label in the symbol table which will cause all future lookups to short circuit.
Instead of validating the DataType simply recreate it each time. Determining whether the first component is the hash or a pointer shouldn't be expensive considering the address is already known.

Most likely this is OK if the a program transaction will always be open when this code is exercised, which it should be.
This would get rid of duplicate scanning if the change is made immediately in the program (or data type manager).
Only tweak to this is when creating the data type each time, it could be expensive in the datatype manager, but most likely not.
Wasn't sure how you were using these classes, since within Ghidra they are essentially only created once per RTTI structure type, so the scanning didn't pop up as a problem.
As an aside, some preliminary CLANG detection code is about to go in so that CLANG compiled binaries will allow the RTTI information and exception information to be laid down.

If you plan to do, great.  If not I can do as part of something else minor I'm about to change

Most likely this is OK if the a program transaction will always be open when this code is exercised, which it should be.
This would get rid of duplicate scanning if the change is made immediately in the program (or data type manager).
Only tweak to this is when creating the data type each time, it could be expensive in the datatype manager, but most likely not.
Wasn't sure how you were using these classes, since within Ghidra they are essentially only created once per RTTI structure type, so the scanning didn't pop up as a problem.
As an aside, some preliminary CLANG detection code is about to go in so that CLANG compiled binaries will allow the RTTI information and exception information to be laid down.

I don't mind doing it. I'll just modify this pr.
Is the clang detection code visual studio format? I don't know how clang works with vs and am curious if it will conflict with my analyzer or not.

The searches should just be in those places
clang quite visual studio, but I think it uses the same format and has the magic string in it.
It just isn't very easy or clean to detect as far as the person looking at it has seen.
Not sure about the label differences, I didn't do either RTTI or PDB.  The PDB most likely comes from demangling where the command doesn't match the demangling.  Is this an issue?  Not sure what you mean by dependence, do you mean difference?

I would key on the mangled form.  That way you aren't dependent on the demangler having run.  I generally don't like to make inter-dependencies unless necessary.  Really shouldn't make a difference.
??_R0?AVtype_info@@@8
class_type_info_`RTTI_Type_Descriptor'

It shall always make a difference because they will find all the flaws too!
If you use it all for a reason to max abilities you get what you need out
of it...
On Friday, August 7, 2020, emteere<EMAIL_ADDRESS>wrote:

I would key on the mangled form. That way you aren't dependent on the
demangler having run. I generally don't like to make inter-dependencies
unless necessary. Really shouldn't make a difference.
??R0?AVtype_info@@@8
class_type_info`RTTI_Type_Descriptor'
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NationalSecurityAgency/ghidra/pull/2077#issuecomment-670684019,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQQ3LSQ53N3DFNBALOIFF3LR7RK3PANCNFSM4OUVYFNA
.

On Friday, August 7, 2020, matt pavey<EMAIL_ADDRESS>wrote:

It shall always make a difference because they will find all the flaws
too! If you use it all for a reason to max abilities you get what you need
out of it...
On Friday, August 7, 2020, emteere<EMAIL_ADDRESS>wrote:

I would key on the mangled form. That way you aren't dependent on the
demangler having run. I generally don't like to make inter-dependencies
unless necessary. Really shouldn't make a difference.
??R0?AVtype_info@@@8
class_type_info`RTTI_Type_Descriptor'
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NationalSecurityAgency/ghidra/pull/2077#issuecomment-670684019,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQQ3LSQ53N3DFNBALOIFF3LR7RK3PANCNFSM4OUVYFNA
.

Opps, yes I meant difference.  I'll search the symbol table for the mangled version and the label applied by CreateTypeDescriptorBackgroundCmd.

@emteere am I mistaken or is the RttiAnalyzer currently unable to locate RTTI if the data type has a hash value?

I believe it is using TypeDescriptor, ClassHierarcyDescriptor, etc.
firefox.exe and chrome.dll are compiled with clang AFAIK
Not sure about finding RTTI with a hash value

I believe it is using TypeDescriptor, ClassHierarcyDescriptor, etc.
firefox.exe and chrome.dll are compiled with clang AFAIK
Not sure about finding RTTI with a hash value

Ok, thank you.
The analyzer appears to only look for the string and fail if it's not found. This leads me to believe that this entire time hasVFPointer has always returned true. If scanning without the string isn't supported then I don't see a reason to keep the version with the hash value and thus the fix becomes as simple as removing the hasVFPointer method and then afaik the string will only be searched for once.

Looks like the TypeDescriptor model was setup to not need the vfpointer.
The RTTIAnalyzer doesn't support binaries without them, but the TypeModel appears that it was trying to.
I wouldn't pull the code out of the TypeDescriptorModel.
Not sure why the Analyzer doesn't support the other type.
It only requires the the VFTable pointer in the 32-bit case.  The 64-bit must always be assumed to have them?

This code could have had an inadvertent change which caused it to no longer support the model with hash instead of the VFpointer.
I'd be loath to pull out code without finding a case with a hash and trying it.  Could be someone broke it.

Ok I'll keep the current approach. That should probably be looked into then as there could be someone out there who wants to scream about it but cannot.

Thats another approach, change it until someone screams :smile:

I was able to run the RttiAnalyzer on a binary that contains 4307 references to type_info::vftable on my potato in 135.270 seconds. That is the most extreme I've encountered to date.
I think I got everything. For some reason I'm having difficulty running the tests so I haven't checked them yet. I'll likely do that over the weekend since it takes several hours for my potato to load the entire ghidra project in Eclipse or vscode. Its also why I have so many force pushes because I did it without loading a project.

I like this implementation better.  Code is cleaner.
Dependence of a what is sort of a library function TypeDescriptorModel on the higher level analzyer isn't the best as we discussed, but is probably the best solution.

I like this implementation better. Code is cleaner.
Dependence of a what is sort of a library function TypeDescriptorModel on the higher level analzyer isn't the best as we discussed, but is probably the best solution.

It makes more sense to me to put them in RttiUtil but the class is package protected so I ultimately stuck them in the analyzer. If it were to be moved elsewhere it would still need to access RttiAnalyzer.TYPE_INFO_STRING.

The constants could be moved out of the analyzer, and the analyzer use the RTTIUtil ones as well.
The real issue is using the program and needing a transaction to be open on the program to put the initial symbol in the program.
The only way to do that is have a unique token for the program like a hash, so the search can keep track that it has already searched that program and found/non found the string.  Then it would keep that the token for the program (not the program itself) and have an associated Boolean that the search had been done and the result.

The constants could be moved out of the analyzer, and the analyzer use the RTTIUtil ones as well.
The real issue is using the program and needing a transaction to be open on the program to put the initial symbol in the program.
The only way to do that is have a unique token for the program like a hash, so the search can keep track that it has already searched that program and found/non found the string. Then it would keep that the token for the program (not the program itself) and have an associated Boolean that the search had been done and the result.
This would really only be needed if the label wasn't found as well. So most of the code wouldn't need to have a transaction open on program.

I'll make RTTIUtil public so that it can be reached from the RttiAnalyzer and will move the utility methods to RTTIUtil. If the label is created in the analyzer then it isn't necessary to worry about transaction handling as it is done by the AutoAnalysisManager.

I think I would just move it.  Where you are putting it in RTTIUtil is a better place.


quenstion with LST

Hi,
I'm confused about the picture in LST. In the second mark "X", the gap  is shoter than 3Mb and both sides of the gap is longer than 10Mb, why marked as "X"? Same confusion in chrom.2.

Is the gray region centromere?, if so, i got it.


update syntax for empty value labels

Fix #16526
Discussion #17344
/cc @thaJeztah are there any other docs that should be updated? I haven't found any
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

Thanks! Looks like the Dockerfile man page still shows [=<value>] as optional; https://github.com/docker/docker/blob/master/man/Dockerfile.5.md

@thaJeztah updated

Awesome! LGTM

ping @moxiegirl for review

updated, ping @calavera @moxiegirl

LGTM

@runcom Thank you. Doc build is breaking on another file. I'll sort it out.


Expose Metamodel getters in the SessionFactory APIS

From this conversation on Zulip:

you might want to look into exposing all metamodels directly in Reactive though. From what I can see only the JPA one is exposed right now, but not org.hibernate.metamodel.MappingMetamodel, which needs to be retrieved through hoops (see above)

Not sure what this issue is about, but if it's about exposing org.hibernate.metamodel.MappingMetamodel on an API, we should definitely not do that. MappingMetamodel exposes SPI-level types. Notice that SessionFactory in ORM does not expose this type.

Ok, something to look into

Note that it's already exposed via ReactiveSession.getFactory().getMappingMetamodel().


Support all split in streaming mode

Fix #4637.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


linux mingw-w64 doesn't support thread and future

See #15
and mingw-w64 on linux: C++ has no mutex/tasks/etc. support...
I also tried to:
sudo update-alternatives --config x86_64-w64-mingw32-gcc
and look at https://github.com/meganz/mingw-std-threads to no avail.

Actually that's sudo update-alternatives --config x86_64-w64-mingw32-g++ (you can check with $GCC -v)

ok it works but

executables don't work such as in #15
binaries are huge: using exports may help #48 #34

See also bc30fdc68ef4ea298766375ced353f0382725614


Prevent panic on merge to PR

If you attempt to merge to a branch which on a PR there will be a nil pointer error in the pull request checker.
This panic is uncaught and will bring down the gitea server.
This PR adds protection to prevent this.

Codecov Report

Merging #10403 into master will increase coverage by 0.06%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10403      +/-   ##
==========================================
+ Coverage   43.74%   43.81%   +0.06%
==========================================
  Files         586      586
  Lines       81113    81121       +8
==========================================
+ Hits        35481    35540      +59
+ Misses      41243    41188      -55
- Partials     4389     4393       +4

Impacted Files
Coverage Δ

services/pull/pull.go
36.07% <0%> (+2.13%)
:arrow_up:

modules/git/command.go
86.95% <0%> (-2.61%)
:arrow_down:

models/unit.go
37.03% <0%> (-2.47%)
:arrow_down:

modules/indexer/issues/indexer.go
57.53% <0%> (-1.37%)
:arrow_down:

models/issue_comment.go
46.5% <0%> (+0.34%)
:arrow_up:

models/pull.go
42.37% <0%> (+0.55%)
:arrow_up:

modules/git/repo.go
47.7% <0%> (+0.91%)
:arrow_up:

models/review.go
42.75% <0%> (+1.48%)
:arrow_up:

services/pull/patch.go
62.89% <0%> (+2.51%)
:arrow_up:

services/pull/temp_repo.go
31.62% <0%> (+2.56%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcd8e4...8fe8852. Read the comment docs.


tests: add utility class tests

Add some more tests

Codecov Report
Base: 39.11% // Head: 72.50% // Increases project coverage by +33.38% :tada:

Coverage data is based on head (431656c) compared to base (97dbac3).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             master       #5       +/-   ##
=============================================
+ Coverage     39.11%   72.50%   +33.38%
- Complexity      191      322      +131
=============================================
  Files            29       29
  Lines           795      811       +16
  Branches         35       37        +2
=============================================
+ Hits            311      588      +277
+ Misses          473      181      -292
- Partials         11       42       +31

Impacted Files
Coverage Δ

bls/src/main/java/org/dashj/bls/BLSJniLibrary.java
57.69% <50.00%> (-7.31%)
:arrow_down:

.../src/main/java/org/dashj/bls/Utils/ByteVector.java
100.00% <100.00%> (+33.33%)
:arrow_up:

.../main/java/org/dashj/bls/Utils/ByteVectorList.java
100.00% <100.00%> (+27.77%)
:arrow_up:

bls/src/main/java/org/dashj/bls/CoreMPL.java
61.29% <0.00%> (+6.45%)
:arrow_up:

bls/src/main/java/org/dashj/bls/PrivateKey.java
82.35% <0.00%> (+17.64%)
:arrow_up:

...src/main/java/org/dashj/bls/ExtendedPublicKey.java
54.54% <0.00%> (+18.18%)
:arrow_up:

...rc/main/java/org/dashj/bls/ExtendedPrivateKey.java
60.60% <0.00%> (+18.18%)
:arrow_up:

bls/src/main/java/org/dashj/bls/G1Element.java
75.75% <0.00%> (+21.21%)
:arrow_up:

bls/src/main/java/org/dashj/bls/G2Element.java
71.87% <0.00%> (+21.87%)
:arrow_up:

bls/src/main/java/org/dashj/bls/ChainCode.java
63.63% <0.00%> (+27.27%)
:arrow_up:

... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Tests Tree filter isn't working properly

When applying a status filter in the tests tab, the return changes depending on the order of the filters
How to test

go to http://localhost:5173/tree/171aa289a6fe65faffeb92a1fda283c055435a62?tableFilter={"buildsTable"%3A"all"%2C"bootsTable"%3A"all"%2C"testsTable"%3A"all"}&origin=maestro&currentTreeDetailsTab=treeDetails.tests&diffFilter={"testStatus"%3A{"ERROR"%3Atrue%2C"SKIP"%3Atrue}}&treeInfo={"gitBranch"%3A"for-next"%2C"gitUrl"%3A"https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Famlogic%2Flinux.git"%2C"treeName"%3A"amlogic"%2C"commitName"%3A"v6.12-rc1-20-g171aa289a6fe"%2C"headCommitHash"%3A"171aa289a6fe65faffeb92a1fda283c055435a62"}
go to http://localhost:5173/tree/171aa289a6fe65faffeb92a1fda283c055435a62?tableFilter={"buildsTable"%3A"all"%2C"bootsTable"%3A"all"%2C"testsTable"%3A"all"}&origin=maestro&currentTreeDetailsTab=treeDetails.tests&diffFilter={"testStatus"%3A{"ERROR"%3Atrue%2C"SKIP"%3Atrue}}&treeInfo={"gitBranch"%3A"for-next"%2C"gitUrl"%3A"https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Famlogic%2Flinux.git"%2C"treeName"%3A"amlogic"%2C"commitName"%3A"v6.12-rc1-20-g171aa289a6fe"%2C"headCommitHash"%3A"171aa289a6fe65faffeb92a1fda283c055435a62"}
compare the results

Another error is to filtering data by test duration
How to test

Go to https://staging.dashboard.kernelci.org:9000/tree/e9001a382fa2c256229adc68d55212028b01d515?tableFilter={"buildsTable"%3A"all"%2C"bootsTable"%3A"all"%2C"testsTable"%3A"all"}&origin=redhat&currentTreeDetailsTab=treeDetails.tests&diffFilter={}&treeInfo={"gitBranch"%3A"master"%2C"gitUrl"%3A"https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Fvirt%2Fkvm%2Fkvm.git"%2C"treeName"%3A"kvm"%2C"commitName"%3A"for-linus-30-ge9001a382fa2"%2C"headCommitHash"%3A"e9001a382fa2c256229adc68d55212028b01d515"}

Try to apply a max and min test duration


TypeLoadException in FakeBandClientManager with latest Band Nuget Package 1.3.20217

When using the latest Microsof.Band Nuget Package 1.3.20217
there is a TypeLoadException when using FakeBandClientManager:
An exception of type 'System.TypeLoadException' occurred in BandApp1.exe but was not handled in user code
Additional information: Method 'GetBandsAsync' in type 'FakeBand.Fakes.FakeBandClientManager' from assembly 'FakeBand, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
This problem does not occur with earlier versions (<= 1.3.20115) of the Microsoft.Band Nuget Package.
Adding the following Code to the App Constructor triggers the TypeLOadException on Debugging Startup (x86 - Local Machine)
FakeBand.Fakes.FakeBandClientManager.Configure(
                new FakeBand.Fakes.FakeBandClientManagerOptions() {
                    Bands = new List<IBandInfo>() {
                        new FakeBand.Fakes.FakeBandInfo(BandConnectionType.Bluetooth, "Fake Band 1", FakeBand.Fakes.BandVersion.BandTwo)
                    }
                });

I am having trouble replicating this issue - can you give some further info on your environment; visual studio version, project type, etc. ?

Didn't mean to close the issue

Hi I am getting this exact same issue.
I was trying to use FakeBand in a new project created with Template 10 Hamburger.
This is a vanilla project, all I did was update the Template 10 package to the latest one and then Add The Microsoft Band package and the Fake Band package.
I then copy/pasted in your getting started code, as soon as you add the 'FakeBandClientManager.Configure' code the project builds but will not run due to the error listed above. To make sure it wasn't just not playing nice with Template 10 I created a brand new blank app and performed the same steps, again I got that same error.
Finally I tried removing the Microsoft Band NuGet package and just went with the one installed by FakeBand and this time it ran properly.
Seems that FakeBand doesn't want to work with the latest Microsoft Band release.
Dependency >= 1.3.11121
Version installed 1.3.20307
Regards
Brian

Environment is Windows 10
Visual Studio 2015 Enterprise
Please find attached the Solution / Project to reproduce the issue on my machine:
BandApp1.zip
Just open the Solution and start Debugging (Solution Configuration "Debug" in Platform "x86")
Hope this helps.

I have updated master to be compatible with the latest band sdk 1.3.20307 so this should be resolved with v0.0.9


Satellizer with ui-router

When using ui-router $auth.authenticate(provider) is returning invalid response: { view1: true }.
It doesn't always return invalid response. First time I login it's working, but then if I  $auth.logout and try to authenticate again, I'm getting this weird response. Is there some trick I should do if I'm using ui-router? I've been searching here on issues for similar problems but didn't find anything that would help me with my problem.
Some pieces of code:
angular.module('myApp.view1', ['satellizer', 'ui.router'])
.config(function($stateProvider, $urlRouterProvider, $authProvider) {
        $urlRouterProvider.otherwise('/view1');
        $authProvider.google({
            clientId: 'xxx.apps.googleusercontent.com',
            responseType: 'token',
            scope: ['openid', 'profile', 'email'],
        });

        $stateProvider
            .state('view1', {
                url: '/view1',
                templateUrl: 'view1/view1.html',
                controller: 'View1Ctrl'
            })
})
.controller('View1Ctrl', function($scope, $auth) {
  $scope.authenticate = function(provider) {
    $auth.authenticate(provider)
    .then(function(response){
      console.log(response);  //this will give me {view1: true}
    })
  };
});

Thanks for helping me out!

Disabling html5 and hash prefix:
$locationProvider.html5Mode(false);
$locationProvider.hashPrefix('');

I also added root route:
            .state('root', {
                url: '/state={state}&access_token={access_token}',
                template: ''
            })

This solves problem for me

Disabling html5 and hash prefix:
$locationProvider.html5Mode(false);
$locationProvider.hashPrefix('');

I also added root route:

            .state('root', {
                url: '/state={state}&access_token={access_token}',
                template: ''
            })

This solves problem for me


v1.11.4 phar is broken for old PHP

PHP Parse error:  syntax error, unexpected 'self' (T_STRING) in phar:///var/lib/jenkins/bin/php-cs-fixer/vendor/symfony/process/Process.php on line 538
refs https://github.com/GoogleCloudPlatform/php-docker/issues/111#issuecomment-224297453

Looks like the phar was built without respecting the min php version.

There is an easy fix...

BUT, it will break testing on symfony 3...

@keradus See https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1969. It will stop the phar getting built with symfony 3 dependencies that need php 5.5.9.

Thanks!
The SF 3 req. shouldn't be a problem right? Since 1.11 doesn't require SF 3.x we can release a phar with 2.x packages?


Feat 02 tableau classification

Added the presentation slides of the project and the final tableau file from the public tableau repository

Edoardo whenever you are ready try and merge this branch after merging feat-01


Install a systemd service file, not upstart, on Ubuntu 16.04

Follow up to https://github.com/servo/saltfs/pull/852#issuecomment-404414465

This change is

r=me but it needs a rebase.

@bors-servo r=nox

:pushpin: Commit 42bdb4d has been approved by nox

:hourglass: Testing commit 42bdb4d8349947c4625bf80ecc06449f8ccb6fb3 with merge d37e2c677a4448333ed611432e2051d40dbabe43...

:sunny: Test successful - status-travis
Approved by: nox
Pushing d37e2c677a4448333ed611432e2051d40dbabe43 to master...

:/
I did run salt-run fileserver.clear_cache just before highstate, though. CC @jdm
          ID: /home/servo/buildbot/slave
    Function: file.recurse
      Result: False
     Comment: Recurse failed: none of the specified sources were found
     Started: 11:59:16.681763
    Duration: 2085.644 ms
     Changes:


Public Endpoint checks for storage.googleapis.com and production.cloudflare.docker.com always fail

Talked to Ryan about these, he said he hasn't found an endpoint that reliably returns a success code. we shouldn't 'ship' with these failing - maybe add a comment at the end of the script that you will manually need to verify access to those? not sure...
+--------------------------------------------------------------------------------+
|                                Public Endpoints                                |
+---------------------------------------------------------+-------------+--------+
|                         Endpoint                        | Status Code | Result |
+---------------------------------------------------------+-------------+--------+
|           https://get.swimlane.io/nginx-health          |    Passed   |  200   |
|                   https://k8s.kurl.sh                   |    Passed   |  200   |
|                     https://kurl.sh                     |    Passed   |  200   |
| https://kurl-sh.s3.amazonaws.com/dist/ekco-0.6.0.tar.gz |    Passed   |  200   |
|            https://registry.replicated.com/v2           |    Passed   |  301   |
|           https://proxy.replicated.com/healthz          |    Passed   |  200   |
|                    https://k8s.gcr.io                   |    Passed   |  302   |
|              https://storage.googleapis.com             |    Failed   |  400   |
|                     https://quay.io                     |    Passed   |  200   |
|                  https://replicated.app                 |    Passed   |  200   |
|               https://auth.docker.io/token              |    Passed   |  200   |
|               https://registry-1.docker.io              |    Passed   |  200   |
|         https://production.cloudflare.docker.com        |    Failed   |  403   |
|              https://files.pythonhosted.org             |    Passed   |  200   |
|                     https://pypi.org                    |    Passed   |  200   |
+---------------------------------------------------------+-------------+--------+
add something here?
|---------------------------------------------------------------------------------------------------------------------------------------------|
|                                                      !!! Additional Manual Checks !!!                                                       |
|                                   Each SPI Node must have a unique hostname as determined by hostnamectl.                                   |
|                                             Each SPI Node should have DNS-resolvable hostnames.                                             |
|                             Each SPI Node must have reliable and consistent time. An NTP daemon is recommended.                             |
|_____________________________________________________________________________________________________________________________________________|

a potential fix to this is verify that the two URLs are actually needed. I believe storage.googleapis.com is, but im not so sure about production.cloudflare.docker.com is

the way the test is written, if I accept 400 or 403 for these, I'll have to accept 400 or 403 for all of the endpoints
so if a proxy were to return a 403 because somethings misconfigured (which is entirely possible), the validator would give false results

Could the function that checks them accept a url and a list of passing status codes? Would that be awful?

:thinking:
probably wouldn't be terrible, ill look at implementing that.


Omit the rendering of XP-related components

Pull Request Test Coverage Report for Build 633

5 of 5 (100.0%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.08%) to 25.844%

Files with Coverage Reduction
New Missed Lines
%

src/components/assessment/index.tsx
1
78.46%

Totals

Change from base Build 629:
0.08%

Covered Lines:
876

Relevant Lines:
2879

💛  - Coveralls


Updated eclipse settings to reflect minimum java level of 11.

While trying to create a test for WICKET-6810 my eclipse kept complaining about code that shouldn't be on issue on java 11 (specifically, the use of the diamond operator in anonymous subclasses).
This turned out to be because eclipse thought the project had a language level of 1.8 After I upgraded (and incorporated) the settings to java 11 the problem was fixed.
Note: you can test this by running mvn install (or mvn install -Dgpg.skip if you're not interested in signing the artifact) in the wicket-eclipse-settings folder and then updating the project in eclipse (Alt+F5). You need a new release of wicket-eclipse-settings (version 5?) to apply this for everyone.

Thank you, @haster !


Fix #915

fix #915

What is your fix here? To enter __empty__ or am I reading this wrong?

Thanks a lot! 🎉


Stand alone example for any example network?

Hi,
I would like to do ImageNet evaluation using armcl with models such as alexnet, googlenet etc.
There are example programs for single image predictions which uses common class from utils.
What I want to make is custom program which can be used for multiple image predictions, loading weights just once. There I want to dump all the 1000 predictions for an input image. Any help will be greatly appreciated. ^^
Thanks.
Best,
Deepak

Hello @ghimiredhikura,
As posted above thi  will work for all the graph examples meaning you can create a file with the image names that you want to test and the expected labels and the graph example will provide you a top-5 top-1 accuracy. The loading of weights and model preparation will be done once.
Now if you want us to consume user provided models then this requires quite a bit of work as it requires parser support. Have a look at https://github.com/ARM-software/armnn which provides TfLite parser support and also python bindings. It uses Compute Library as a backend.
Hope it helps,
George


Feature/update and prep for demo

Sorry, this was a mistake! Meant to PR into my own master only...


✨ add twine bump, push, and auto-deploy via twine

Codecov Report

Merging #103 (fe8bf7a) into Release-v2.0.0 (2c7bd3f) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head fe8bf7a differs from pull request most recent head f2630cd. Consider uploading reports for the commit f2630cd to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@               Coverage Diff               @@
##           Release-v2.0.0     #103   +/-   ##
===============================================
  Coverage           98.98%   98.98%
===============================================
  Files                  21       21
  Lines                1188     1188
===============================================
  Hits                 1176     1176
  Misses                 12       12

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat(maven): only fetch snapshots and releases when enabled

https://github.com/google/osv-scanner/issues/1280
WIP pending https://github.com/google/deps.dev/pull/117

Codecov Report
Attention: Patch coverage is 52.70270% with 35 lines in your changes missing coverage. Please review.

Project coverage is 69.52%. Comparing base (c693e2d) to head (495413e).

Files with missing lines
Patch %
Lines

internal/manifest/maven.go
0.00%
7 Missing :warning:

cmd/osv-scanner/fix/noninteractive.go
0.00%
6 Missing :warning:

...ckfilescalibr/language/java/pomxmlnet/extractor.go
14.28%
6 Missing :warning:

internal/resolution/manifest/maven.go
14.28%
6 Missing :warning:

internal/resolution/datasource/maven_registry.go
85.29%
2 Missing and 3 partials :warning:

...nternal/resolution/client/maven_registry_client.go
33.33%
2 Missing and 2 partials :warning:

internal/utility/maven/maven.go
83.33%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
- Coverage   69.70%   69.52%   -0.18%
==========================================
  Files         186      186
  Lines       18581    18617      +36
==========================================
- Hits        12951    12944       -7
- Misses       4929     4970      +41
- Partials      701      703       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Prompt buttons do not work with tap

when a notification/prompt pops up I tap it on my touchscreen laptop nothing happens
https://waders.tech/vscode-tap_error.zip

I can reproduce and it seems to impact any button.
@isidorn moving to you because I see there is https://github.com/Microsoft/vscode/blob/2808fee/src/vs/base/browser/ui/button/button.ts#L66 but maybe it is not properly wired in for buttons.

The wireing in seems good. That is what we are doing everywhere.
@bpasero if you have a touch machine can you put a breakpoint here and check if it is hit
Also does it help if you add a container instead of this._element here. I think it should not make a difference.
@Codedevlo you can also tryout what I asked @bpasero to do, that would help


Design changes in House pages

Make the Gryffindor and Slytherin pages similar to the Hufflepuff one,

Add a logo
create a back button
center the traits
Align Slytherin image
Remove the home & play quiz buttons
Change the background to a solid background instead of the image background.

@appledora would you like to work on this?

Yeah, sure if it's available :D

@arnav1776 should I create separate PR for Gryffindor and Slytherin ?

@appledora Would you like to work on the Ravenclaw page? It's the only one left which hasn't been updated.

Sure. I will be happy to :D

@arnav1776 do take a look :D


Bump Go to 1.21.5 and check release build in CI

See commits

Thanks! BTW CI test runs make release on PR: https://github.com/cilium/pwru/blob/main/.github/workflows/test.yml#L30

TIL, thanks. I guess we can drop the second commit running the release workflow on every PR.


[SKIP-1015] Add wordy deprecation warnings

Another alternative is creating a separate job instead of having it in a step on every action.
See https://github.com/kartverket/shipwreck/actions/runs/4511630410/jobs/7944027843 for how it looks

I doubt people are going to see this if it is in a separate step? I had to look for it even though I know to look.
Could writing this as an error message help?
We can also consider appending it to the job summary.

I doubt people are going to see this if it is in a separate step? I had to look for it even though I know to look.
Could writing this as an error message help?
We can also consider appending it to the job summary.

Oooh I wasn't aware of these features. That's indeed a better solution. Looking into it :) @esphen

https://github.com/kartverket/shipwreck/actions/runs/4529789373
How about now @esphen :)


[docs]: fix article "Check a Role's Permissions"

Description
Article Check a Role's Permissions needs to be updated, more details @ #855
Issue List

[ ] Guide the user to click Resource Name

Steps below needs to be fixed accordingly

1. In the list of Roles find the Role you want to check the permissions and click DETAILS

@thlmenezes can you assign this to me?


ADBDEV-1938-not-orca

Here are some reminders before you submit the pull request

[ ] Add tests for the change
[ ] Document changes
[ ] Communicate in the mailing list if needed
[ ] Pass make installcheck
[ ] Review a PR in return to support the community

Allure report https://allure-ee.adsw.io/launch/55401

Allure report https://allure-ee.adsw.io/launch/55447

Failed job Regression tests with ORCA on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/664390


PATCH vs PUT for update calls

Is there any reason that we use http.MethodPut instead of http.MethodPatch for updating? In a recent update, this caused the provider to change the settings of a fusionauth_idp_saml_v2 resource, since there was a new field the provider didn't know about and hence it didn't see the diff it was applying. Using http.MethodPatch would prevent this happening.

No particular reason, I went with PUT since I was using the updates for most the resources. I wouldn't be opposed to changing it in idphelpers.go once I get caught up with the changes in the last few versions.


Second attempt to bandaid #14. Sorry about that.

This fixes #30 for me. Thanks for the quick fix :heart:

:+1:


SimplCommerce.MSBuildTasks update nuget Microsoft.Build.Utilities.Core 16.3.0

SimplCommerce.MSBuildTasks update nuget Microsoft.Build.Utilities.Core 16.3.0

Could you help us?

Due to special reasons, our access to foreign resources is blocked by the firewall, so we can't clone the code to modify it locally. The speed is basically several KB

We don't have to use this build task any more


Release of version <IP_ADDRESS> of xWindowsUpdate

Releasing version <IP_ADDRESS>

Hi @kwirkykat, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Katie Keim). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


[docs] Migrate Fab demos to emotion

[x] I have followed (at least) the PR section of the contributing guide.

The following demos of the Fab component were migrated:

[x] Basic fab
[x] Sizes fab
[x] Animation fab

Related to #16947

@oliviertassinari  Thanks for all the feedback, I read each one of them and I will try to make the demos smaller. He did not know what made the code to be seen or hidden, now I understand that it depends on the length of the example.


[DISCUSS]Reorganize the packages of input,output and stream?

Hi all,
Currently, input and output are the same levels with cipher,stream,random, package input(same as output) have the following classes: Input,ChannelInputand StreamInput, these classes are related to stream actually, I wonder if we can reorganize the packages to make it more clear. I have some proposed solutions for reorganizing the package, any other ideas are also welcomed:
(0) Should not change the package
(1) Putting all the classes (input and output) into stream
(2) Reorganizing according package com.intel.chimera.stream.input and package com.intel.chimera.stream.output

Strictly speaking, yeah, Input and Output are for stream.
If we plan to do something on this, I like approach (2).

Anybody has other comments on this?

What's the plan for this?

Hi @jerrychenhf , I'm also agreed with Reorganizing according package com.intel.chimera.stream.input and package com.intel.chimera.stream.output, how about follow up a pull request about this.

Hi @jerrychenhf @sundapeng ,I have created a PR https://github.com/intel-hadoop/chimera/pull/98 for this issue.

Thanks @JkSelf for your contribution


Generated SBOM includes Git data and ephemeral build artifacts

The generated SBOM includes information from the .git folder. Likewise, it would be good to have it ignore the contents of NPM node_modules directories and Maven /target/ directories.
AFAICT, there's no option to exclude these directories from the results.
One option would be to have the tool honour the ignore list specified in .gitignore files.
Note that a .gitignore file itself is a maintained artifact that IMHO should be included in the SBOM.

@aasim May i asked if this gets prioritized and is going to be available soon? If not, Could you please share your thoughts on how  it should be implemented in SBOM?
I see component detector uses minimatch to filter specific directories. Do SBOM also expected similar to that solution?

Hi, any update on this. Thanks

One could use this argument: https://github.com/microsoft/sbom-tool/blob/main/docs/sbom-tool-cli-reference.md#excluding-directories-from-component-scan
Though this may have issues (based on #494)


Add url search params

Some traits are missing. Since I'm not using Rust daily, I don't know which traits are beneficial to be implemented into the new structs.
Please review and give recommendations around the missing structs and the API surface.

hey @untitaker @Swatinem @mitsuhiko, thank you for all the reviews! I've tried to address them all, and learned a lot along the way. Would you mind taking a one last take? Please nit-pick / be super-picky, and don't lower your personal barrier (just for the sake of positivity).


ANY operator with Arrays of type object.

documents says that ANY operator can't be used with Arrays of type object but doing a test, it seems supported to me, at least with crate version 0.54.8
here is a sample table used
create table test (
	id String,
	projects array(object(dynamic)) /* array of type object */
) with (number_of_replicas = '0-all');

data sample
insert into test (id, projects) values(
  'id',
  [
    {id = 'project1_id', name = 'project 1'},
    {id = 'project2_id', name = 'project 2'}
  ]
), (
  'id2',
  [
    {id = 'project3_id', name = 'project 3'},
    {id = 'project4_id', name = 'project 4'}
  ]
);

Now using ANY operator in a query against projects Array which is of type object, it gives perfect result :)
select * from test where 'project4_id' = ANY(projects['id']) limit 100;

// returns
id   |  projects
----------------------------------------------------------------
id2  |  [{"name":"project 3","id":"project3_id"},{"name":"project 4","id":"project4_id"}]

I'm not sure if this is not the expected behavior, documentation error or if I'm missing something !!
Thanks

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/35272543-any-operator-with-arrays-of-type-object?utm_campaign=plugin&utm_content=tracker%2F505659&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F505659&utm_medium=issues&utm_source=github).

The documentation is correct and this is expected behaviour. Although I guess it is a bit confusing and could be clarified a bit in the documentation
You're accessing projects['id'] which in that context becomes a string array:
cr> select projects['id'] from test;
+--------------------------------+
| projects['id']                 |
+--------------------------------+
| ["project3_id", "project4_id"] |
| ["project1_id", "project2_id"] |
+--------------------------------+

That's why ANY works.  The thing that doesn't work is the following:
cr> select * from test where {id = 'project1_id', name = 'project 1'} = ANY(projects) limit 10;
SQLActionException[ANY on object arrays is not supported]

@mfussenegger thank you very much, that's clear enough. I've never thought any would use objects in WHERE clause to test against arrays directly, I also learned that we can select object properties within arrays too, which is another great feature of crate that I'm not sure if it's documented.


Upgrade google-cloud-core and google-cloud-bigquery dependencies

Upgrade google-cloud-core and google-cloud-bigquery dependencies
google-cloud-core dependency recently got upgraded to 1.x and other google io dependency may depend on this range (e.g. firestore)
According to change log there is not a big breaking change (https://googleapis.dev/python/google-cloud-core/latest/changelog.html). Tests will tell us better.
Also bigquery package needs to be updated as well based on the above change log.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run Python 2 PostCommit

Run Python 2 PostCommit

Run Python 3.5 PostCommit

Run Python 3.5 PostCommit


Unable to set selected state from external component

I think there is an issue with the selected state value.  Specifically, a parent component can set the selected value by passing it as a prop, but if the parent were to change its value, the DatePicker component does not receive the update.  I have a separate "Clear" button on my page that should be able to clear the input.  I believe the root of the issue is the use of getInitialState() to set selected value from the prop:
getInitialState: function() {
    return {
      focus: false,
      selected: this.props.selected
    };
  },

The documentation states this as an antipattern: https://facebook.github.io/react/tips/props-in-getInitialState-as-anti-pattern.html
I believe the solution is to have a componentWillReceiveProps that can keep the selected state updated on changes, something like:
componentWillReceiveProps(newProps){
  this.setState({
    selected: newProps.selected
  });
}

What do you think? I'm happy to submit a pull request.

:+1: I'm also having an issue with this, that fix would solve my problem as well.

Thanks, I'll take a look at #135 to make sure it works fine with our config too.

Thanks Martijn.  Do you have an ETA for when you can merge this in?

Thanks, will release this today.

Is this supposed to be working?
When I change date from another component (previous / next day buttons) date picker date is changed but not rendered until I click date picker


Fix for large file uploads on https

When uploading large files new curl handles are not set with capath which causes CURLE_PEER_FAILED_VERIFICATION.

This is a bug introduced in this commit. curl_easy_setopt should not be there because everytime after the CURL* handle is used, its options are reset.


pip support?

Hello,
First of all huge thanks for this amazing repo.
Are there any plans to create pip support for installation, so it can easily be used from other projects?

Thank you so much for supporting this project, I think there're already some package including Grounded-SAM like autodistill, and it will be very useful for other users, just have a try!
We did not release our python package but we will try to update a new demo for the community in the future.

Thank you. Did not know about autodistill, and it looks awesome.
As this repo includes pretty nice recent implementations of several methods, and it is overall very complete, maybe it would be good to know if you welcome some pull request including this pip support, so other folks (including me maybe) can help with it? If so, I would leave this issue open for others to see and maybe gather interest?

Sure, I think we can keep this issue open, and we will try autodistill also to see if there're more convenient way for the users to use Grounded-SAM.


Cannot disable Crashlytics Debug log calls on 6.1.1

General Info:
Unity editor version: 2018.4.1f1
Firebase Unity SDK version: 6.1.1
Firebase plugins in use Analytics, Crashlytics, Messaging, DynamicLinks, RemoteConfig, InstanceID
Additional SDKs you are using: Facebook, Google Play Games, HelpShift
Platform you are using the Unity editor on: Mac + Windows
Platform you are targeting: Android/iOS
The issue:
When Migrating from Fabric to FireBase Crashlytics, using Crashlytics.Log "to give yourself more context for the events leading up to a crash" causes them to be logged also via UnityEngine.Debug.Log causing overhead on the device.
I did even tried setting:
Firebase.FirebaseApp.LogLevel = Firebase.LogLevel.Error;
I also noticed there are 'CrashlyticsSettings' but I was unable to find any documentation if I could adjust the debug level that way.
Reproduction
Migrating from Fabric to FireBase Crashlytics using the migration instructions caused these issues to pop up. With Fabric these logs were not popping up in the unity debug logs.

Hi @CrtiicalForce,
Unfortunately I couldn't reproduce this (version 6.2.2 on Windows).  I'm fairly certain that the Console.Log function doesn't tie into the Debug.Log for any log level, but if you can reproduce this using the Crashlytics testapp, or provide a stand alone example, then please let me know. Thanks!

Hi @CriticalForce are you able to reproduce this issue with our sample project?
On Android the Unity SDK just calls CLSLogon iOS and CrashlyticsCore .log on Android neither of which are supposed to log to the console.

After closer inspection I can confirm that I must have misread my issue.
What I'm actually seeing is a Debug print in adb Logcat for each Crashlytics Log which logs under Unity with the command: "adb logcat -s Unity"
Example of the print:

@CriticalForce could you share the logs that you're seeing in particular?  If you see a debug log from Unity that could be from Unity not Firebase.

The logs I'm seeing are the messages I'm sending to Crashlytics via Crashlytics.Log but for some reason it is being logged onto the ADB debug track as well.
Might be something else interfering with it as well but it started happening after migration to FireBase.Crashlytics from Fabric.Crashlytics Log call

I'm not sure if there is a third party in our SDK logging these out 🤔

I now reproed the issue with the Crashlytics test project.
Unity 2018.4.1f1
FireBase 6.2.1 & 6.3.0
With just one script on a gameobject doing

Firebase.Crashlytics.Crashlytics.Log("DEBUG!");

Hi @MagicMiikka, thanks for providing follow up logs. Our crashlytics team is looking into the issue.

@cynthiajoan any updates on this?
This is a blocking bug for our Fabric migration as it would introduce potential performance regression.

Sorry, there's no update to give right now.
If you do have profiling data comparing Firebase and Fabric Crashlytics that you'd like to share with the team feel free to post it here and I'll forward it along. You can also open a support ticket at https://firebase.google.com/support.

Thanks for the update @patm1987
We've not profiled this unfortunately but I'll can consult our tech lead on this and if we should just reduce the overall amount of logs we use via crashlytics in the meantime.

The latest Firebase Unity release (6.15) uses the new Firebase Crashlytics SDKs, which no longer echo log calls to LogCat.