plan_path() --- Run into infinite loop! when create poni dataset

I$ ACTIVE_DATASET="gibson" python create_poni_dataset.py --split "train"
Maps 63
0%|                                                                                | 0/63 [00:00<?, ?it/s]====> Pre-computing for map Benevolence_1
====> Pre-computing for map Benevolence_0
====> Pre-computing for map Forkland_0
====> Pre-computing for map Benevolence_2
====> Pre-computing for map Coffeen_0
====> Pre-computing for map Beechwood_0
====> Pre-computing for map Coffeen_3
====> Pre-computing for map Hiteman_2
====> Pre-computing for map Coffeen_1
====> Pre-computing for map Allensville_0
====> Pre-computing for map Hiteman_1
====> Pre-computing for map Hiteman_0
====> Pre-computing for map Hanson_0
====> Pre-computing for map Forkland_2
====> Pre-computing for map Beechwood_1
====> Pre-computing for map Forkland_1
====> Pre-computing for map Coffeen_2
====> Pre-computing for map Hanson_2
====> Pre-computing for map Hanson_1
====> Pre-computing for map Klickitat_0
====> Pre-computing for map Cosmos_0
====> Pre-computing for map Cosmos_1
====> Pre-computing for map Klickitat_2
====> Pre-computing for map Lakeville_0
====> Pre-computing for map Klickitat_1
plan_path() --- Run into infinite loop!
plan_path() --- Run into infinite loop!
plan_path() --- Run into infinite loop!
plan_path() --- Run into infinite loop!
0%|

@srama2512 Hi, it has run into infinte loop to generate the training dataset.... What should I do? Thanks!!

I stop the infinite training dataset generation and use them to start training, the error as bellows:
=======> Total world size: 2
Effective batch size: 40
updates per epoch: 2433
epochs to train: 17
==============================
INFO:train_pf:==============================
Epoch [   0/  17] | Step [   400/ 97306] | Train loss:   0.4266 | LR:   0.0010 | PTime (min):   0.07 | DTime (min):   0.08
INFO:train_pf: Epoch [   0/  17] | Step [   400/ 97306] | Train loss:   0.4266 | LR:   0.0010 | PTime (min):   0.07 | DTime (min):   0.08
======> Complete losses
object_pf_loss  |   0.1828
INFO:train_pf:object_pf_loss  |   0.1828
area_pf_loss    |   0.2438
INFO:train_pf:area_pf_loss    |   0.2438
INFO:train_pf:==============================
Epoch [   0/  17] | Step [   800/ 97306] | Train loss:   0.3545 | LR:   0.0010 | PTime (min):   0.07 | DTime (min):   0.04
INFO:train_pf: Epoch [   0/  17] | Step [   800/ 97306] | Train loss:   0.3545 | LR:   0.0010 | PTime (min):   0.07 | DTime (min):   0.04
======> Complete losses
object_pf_loss  |   0.1514
INFO:train_pf:object_pf_loss  |   0.1514
area_pf_loss    |   0.2031
INFO:train_pf:area_pf_loss    |   0.2031
INFO:train_pf:==============================
Epoch [   0/  17] | Step [  1200/ 97306] | Train loss:   0.3135 | LR:   0.0010 | PTime (min):   0.06 | DTime (min):   0.03
INFO:train_pf: Epoch [   0/  17] | Step [  1200/ 97306] | Train loss:   0.3135 | LR:   0.0010 | PTime (min):   0.06 | DTime (min):   0.03
======> Complete losses
object_pf_loss  |   0.1325
INFO:train_pf:object_pf_loss  |   0.1325
area_pf_loss    |   0.1810
INFO:train_pf:area_pf_loss    |   0.1810
INFO:train_pf:==============================
Epoch [   0/  17] | Step [  1600/ 97306] | Train loss:   0.2836 | LR:   0.0010 | PTime (min):   0.06 | DTime (min):   0.03
INFO:train_pf: Epoch [   0/  17] | Step [  1600/ 97306] | Train loss:   0.2836 | LR:   0.0010 | PTime (min):   0.06 | DTime (min):   0.03
======> Complete losses
object_pf_loss  |   0.1190
INFO:train_pf:object_pf_loss  |   0.1190
area_pf_loss    |   0.1646
INFO:train_pf:area_pf_loss    |   0.1646
Traceback (most recent call last):
File "/media/sly/3T/tmpin3T/ObjNav_project/PONI/train.py", line 728, in
main(args.exp_config, args.opts)
File "/media/sly/3T/tmpin3T/ObjNav_project/PONI/train.py", line 718, in main
trainer.train()
File "/media/sly/3T/tmpin3T/ObjNav_project/PONI/train.py", line 557, in train
for batch_id, (inputs, labels) in enumerate(train_loader):
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 521, in next
data = self._next_data()
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1183, in _next_data
return self._process_data(data)
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1229, in _process_data
data.reraise()
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/_utils.py", line 425, in reraise
raise self.exc_type(msg)
EOFError: Caught EOFError in DataLoader worker process 1.
Original Traceback (most recent call last):
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 287, in _worker_loop
data = fetcher.fetch(index)
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/media/sly/3T/tmpin3T/ObjNav_project/PONI/poni/dataset.py", line 577, in getitem
data = cPickle.load(fp)
File "/home/sly/anaconda3/envs/poni/lib/python3.8/bz2.py", line 172, in peek
return self._buffer.peek(n)
File "/home/sly/anaconda3/envs/poni/lib/python3.8/_compression.py", line 68, in readinto
data = self.read(len(byte_view))
File "/home/sly/anaconda3/envs/poni/lib/python3.8/_compression.py", line 99, in read
raise EOFError("Compressed file ended before the "
EOFError: Compressed file ended before the end-of-stream marker was reached
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 1 (pid: 384742) of binary: /home/sly/anaconda3/envs/poni/bin/python
Traceback (most recent call last):
File "/home/sly/anaconda3/envs/poni/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/home/sly/anaconda3/envs/poni/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/distributed/launch.py", line 193, in
main()
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/distributed/launch.py", line 189, in main
launch(args)
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/distributed/launch.py", line 174, in launch
run(args)
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/distributed/run.py", line 689, in run
elastic_launch(
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 116, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/home/sly/anaconda3/envs/poni/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 244, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:

/media/sly/3T/tmpin3T/ObjNav_project/PONI/train.py FAILED
Root Cause:
[0]:
time: 2023-05-18_13:15:02
rank: 1 (local_rank: 1)
exitcode: 1 (pid: 384742)
error_file: <N/A>
msg: "Process failed with exitcode 1"
Other Failures:
<NO_OTHER_FAILURES>

@rginjapan - Thanks for raising this issue. I don't have a fix yet for the infinite loop issue --- this is because the dataset was unable to find the shortest path for creating the partial maps (see here).
EOFError: Compressed file ended before the end-of-stream marker was reached

The above error is because of a corrupted file. When the code runs into an infinite loop, an opened file is not closed properly due to the error. So identifying and deleting these files should fix the problem.

@srama2512 Thanks for your reply, so how to avoid the infinite loop to generate the training dataset? I want to train your project.

@srama2512 Is it okay to stop the training dataset generation, and use them to do training? Does it affect the performance of final results?

@rginjapan - I don't have a solution in mind right now. It will take me time to look at this closely. It is okay to stop the training dataset generation if you have enough samples overall (e.g., 300k+ samples in train). Here is a quick script that I wrote to check for corrupt files. You can manually remove them.
import glob
import bz2
import tqdm
import _pickle as cPickle
import multiprocessing as mp

def load_path(path):
    try:
        with bz2.BZ2File(path, 'rb') as fp:
            data = cPickle.load(fp)
            in_semmap = data["in_semmap"]
    except:
        print(f'====> Path {path} is corrupt')

paths = glob.glob("*/precomputed_dataset_24.0_123_spath_square/*/*/*.pbz2")
print(f"# paths: {len(paths)}")

pool = mp.Pool(80, maxtasksperchild=8)
_ = list(tqdm.tqdm(pool.imap(load_path, paths), total=len(paths)))

Thanks for your quick response, I will try later and give you feedback!

@srama2512 I think we can easily check the file size to identify the corrupted files, usually the last file in each scene. At least, works for me.

New error:
Epoch [   0/  25] | Step [ 59400/ 97288] | Train loss:   0.0113 | LR:   0.0010 | PTime (min):   0.13 | DTime (min):   0.04
INFO:train_pf: Epoch [   0/  25] | Step [ 59400/ 97288] | Train loss:   0.0113 | LR:   0.0010 | PTime (min):   0.13 | DTime (min):   0.04
======> Complete losses
object_pf_loss  |   0.0091
INFO:train_pf:object_pf_loss  |   0.0091
area_pf_loss    |   0.0022
INFO:train_pf:area_pf_loss    |   0.0022
INFO:train_pf:==============================
Epoch [   0/  25] | Step [ 60000/ 97288] | Train loss:   0.0113 | LR:   0.0010 | PTime (min):   0.13 | DTime (min):   0.04
INFO:train_pf: Epoch [   0/  25] | Step [ 60000/ 97288] | Train loss:   0.0113 | LR:   0.0010 | PTime (min):   0.13 | DTime (min):   0.04
======> Complete losses
object_pf_loss  |   0.0091
INFO:train_pf:object_pf_loss  |   0.0091
area_pf_loss    |   0.0022
INFO:train_pf:area_pf_loss    |   0.0022
0%|                                                                                | 0/51 [00:00<?, ?it/s]ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: -9) local_rank: 1 (pid: 5840) of binary: /home/anaconda3/envs/poni2/bin/python
Traceback (most recent call last):
File "/home/anaconda3/envs/poni2/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/home/anaconda3/envs/poni2/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/anaconda3/envs/poni2/lib/python3.8/site-packages/torch/distributed/launch.py", line 193, in
main()
File "/home/anaconda3/envs/poni2/lib/python3.8/site-packages/torch/distributed/launch.py", line 189, in main
launch(args)
File "/home/anaconda3/envs/poni2/lib/python3.8/site-packages/torch/distributed/launch.py", line 174, in launch
run(args)
File "/home/anaconda3/envs/poni2/lib/python3.8/site-packages/torch/distributed/run.py", line 689, in run
elastic_launch(
File "/home/anaconda3/envs/poni2/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 116, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/home/anaconda3/envs/poni2/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 244, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:

/media/sly/3T/tmpin3T/ObjNav_project/PONI/train.py FAILED
Root Cause:
[0]:
time: 2023-05-23_15:39:09
rank: 1 (local_rank: 1)
exitcode: -9 (pid: 5840)
error_file: <N/A>
msg: "Signal 9 (SIGKILL) received by PID 5840"
Other Failures:
[1]:
time: 2023-05-23_15:39:09
rank: 2 (local_rank: 2)
exitcode: -9 (pid: 5841)
error_file: <N/A>
msg: "Signal 9 (SIGKILL) received by PID 5841"

Sorry to post many new errors:
[E ProcessGroupNCCL.cpp:566] [Rank 0] Watchdog caught collective operation timeout: WorkNCCL(OpType=ALLGATHER, Timeout(ms)=1800000) ran for 1808180 milliseconds before timing out.
[E ProcessGroupNCCL.cpp:325] Some NCCL operations have failed or timed out. Due to the asynchronous nature of CUDA kernels, subsequent GPU operations might run on corrupted/incomplete data. To avoid this inconsistency, we are taking the entire process down.
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: -6) local_rank: 0 (pid: 16327) of binary: /home/sly/anaconda3/envs/poni2/bin/python
I think they are all related to multi-gpu training ...

@srama2512 Sorry to bother you. I have the same question like"plan_path() --- Run into infinite loop!".I wonder could you please send me the file named"precomputed_dataset_24.0_123_spath_square". I specially appreciate your wonderful work but got stuck in this step.


Superfluous Code

Immediately after the deleted lines is a call to OnClientDisconnect(netMsg.conn); which calls StopClient(); which has the exact same code on line 344 as what I'm proposing be deleted here.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[hotfix][connectors-elastic6] Move away from deprecated RestHighLevelClient#bulkAsync

What is the purpose of the change
The PR makes use RestHighLevelClient#bulkAsync with RequestOptions instead of deprecated one as it recommended in javadoc [1] and as it is already done for elastic7 [2]
[1] https://github.com/elastic/elasticsearch/blob/6.8/client/rest-high-level/src/main/java/org/elasticsearch/client/RestHighLevelClient.java#L498-L507
[2] https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-elasticsearch7/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch7SinkBuilder.java#L85-L88
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
The S3 file system connector: (no )

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

All future PRs for the ES connector should go against https://github.com/apache/flink-connector-elasticsearch and the respective release-X branch for backports.

ok, thanks for letting know
I created a PR for https://github.com/apache/flink-connector-elasticsearch
https://github.com/apache/flink-connector-elasticsearch/pull/29
so I'm closing this one


Update the all.json with more information.

Currently the file at /state/v1/all.json only consist of 4 information per state. The information here should be more complete based on the Wikipedia entry here.
So, the all.json needs to be updated with the remaining information which includes, the population, total area, license plate prefix, phone area code, abbreviation, ISO, FIPS, HDI, region, head of state and the head of the government.

@JianLoong Hi, I would like to try this task, can you please assign it to me?

@JianLoong Hey, kindly review my PR and merge. Thanks


C++: Value number performance fix

This PR fixes a performance problem observed when an FieldAddressInstruction's getField predicate returns more than one field.
The fix is the same as in the AST library: we simply filter out those FieldAddressInstructions that have too many fields.
The PR also fixes a problem caused by a ConstantInstruction having multiple value numbers due to the instruction having more than one IR return type.

3 tests are failing now due to the change in value numbering for ConstantInstructions. This snippet is representative of all the failing testcases:
 #   56|     r56_21(int)           = Constant[1]          :
-#   56|         valnum = unique
+#   56|         valnum = r56_21, r62_3
...
 #   62|     r62_3(unsigned int)        = Constant[1]             :
-#   62|         valnum = unique
+#   62|         valnum = r56_21, r62_3

I'm guessing we do want to distinquish these two values with different value numbers.


can this gem be use in rails-5 & ruby-2.4

Testing for Rails 5 was added in this PR: https://github.com/zaccari/rake-task-migrations/pull/12


Task health pie chart in application list view

I took a quick look today - for one thing we need to get the .jshintrc passing on the javascript. For example

use === (not ==)
indent with 2 spaces (currently 4)
80-char line length

Here's a guide on getting jshint set up with Sublime, https://github.com/mlunoe/react-bb-broccoli#development-setup-sublime-text

Fixed the js style, at least what jsxhint showed me. Let me know if there is anything left.

Hi there,
Love this PR small issue though. It forever appends new elements until the browser becomes responsive. I fixed this by removing the old  element before appending a new one. not sure if this is correct but seems to work :-)
cheers!

Had noticed the ui getting slower over time. Can you attach the patch so I can add it to the pr?

Sure:
diff --git a/src/main/resources/assets/js/components/PieComponent.jsx b/src/main/resources/assets/js/components/PieComponent.jsx
index 01c6fe4..f9fb6b6 100644
--- a/src/main/resources/assets/js/components/PieComponent.jsx
+++ b/src/main/resources/assets/js/components/PieComponent.jsx
@@ -35,7 +35,10 @@ define([
     _renderGraph:function () {
       var _this = this;
       // Based in http://bl.ocks.org/mbostock/3887235
-      var root = d3.select(this.getDOMNode()).append("g")
+      var node = d3.select(this.getDOMNode());
+      node.selectAll("g").remove();
+
+      var root = node.append("g")
         .attr("transform", "translate(" +
           this.props.width / 2 + "," + this.props.height / 2 + ")"
       );

Hi @sttts,
Thank you for putting together all this work! We'd love for this feature to enter marathon, but we do have some requirements to the UI and coding style, so I've put together a couple of comments for you in the pull request. But first here some general comments:
We like simple UI that communicates well. We would love to see this feature implemented, but with a simple stacked progress bar would make it very clear what's going on and that way we don't need the d3.js dependency, which needs some tweaking in order to play well with React.
We rely on bootstrap styles, so you can use their stacked progress bar: http://getbootstrap.com/components/#progress-stacked.
And here's some general styles that should make it a bit slimmer:
.progress {
height: 10px;
border-radius: 3px;
}
.progress-bar {
line-height: 10px;
}
And maybe add a fixed with of 140px: <div className="progress" style={{"width": "140px"}}>
Thank you again!

Thanks for the many comments.
I did a mockup of a 140px stacked bar health view and honestly I don't like it. It clutters the screen, has far too much space, feels too dominant.
I did another mock with a much smaller bar which somehow resembles the pie bar, but it still lacks the visual directness of pie bar: the eye is much better in spotting 350° green, with 10° in a different color than a stacked bar which is 97% green and 3% in a different color.
Of course I understand the dependency to D3 which might be a technical argument, if it is an issue.
https://www.dropbox.com/s/b6ebxca2y2ofyas/stacked-bar-mock.png
https://www.dropbox.com/s/y6q6a1glev2cmjo/stacked-bar-mock2.png

Yes, you are right! The smaller one is much better! I stole from styles I had done in another setting - I just wanted to give you something to work with.
Well, yes. The big issue here is really d3, and how it is build into the solution. Also, you are right. Too much green steals the attention. Healthy would work much better in be grey (look for running here https://github.com/mesosphere/marathon/pull/914#discussion-diff-22633955R31, where I have tried to outline the attention), and put the error and warning parts in colours that will attract attention (i.e. you don't need to attract attention to stuff if everything is fine. That is why status text "Running" is regular white, whereas "Deploying" is in yellow).
Does that work for you?

Wondering, creating some svg for the pie chart directly should be pretty straight forward, maybe 10 lines of code. Then we can get rid of D3 completely. What do you think?

Hey @sttts! I grabbed the colors @mlunoe suggested earlier and tweaked them a bit to mesh with the color palette of the brand. I also thinned the progress bar height for more elegance. That makes the progress bar 140px wide and 9px tall.
Mockup

Colors
.progress-bar-info {
background-color: #4ca0ff; // (blue) unscheduled
}
.progress-bar-error {
background-color: #ff7d64; // (red) unhealthy
}
.progress-bar-warning {
background-color: #fff57a; // (yellow) staged + over-capacity
}
.progress-bar-success {
background-color: #29f6a0; // (green) healthy
}
.progress-bar-unknown {
color: #8e929b; // (grey) running
}

@sttts - if you could, for the progress bar, use the default Bootstrap tooltips to provide context on hover.  If you are looking for a quick and dirty solution, build one tooltip element, recycle/reposition when needed, and then just replace the message.

Rebased and ported away from D3. So it's pure react svg now.
I will make an alternative version with the stacked progress bar tomorrow. Then one can decide. In fact, I also like @aatumanova's version with thin bars. Let's see how this looks with bootstrap.

@sttts I'm suggesting we keep @aatumanova's proposed implementation, and then layer the tooltips on top of each segment on mouseover for clarity.

!()[http://de.tinypic.com/r/s5bdww/8]

Another screenshot, from a production setup with many app:

If you have many apps, the pie chart version looks much cleaner IMO, though the animation of the stack progress bar is nice.

Nice work @sttts! I'm enjoying the rounding you chose on the ends of the bars.
Here are a few suggestions for putting on the polish:

Set the progress wrapper border-radius to 100px so that the ends are fully rounded.

Align the progress bars flush right to the table header title "Health" like so

Consider adding bootstrap's static tooltip (http://getbootstrap.com/javascript/#tooltips) on hover to explain the meaning of the colors

For the tooltip, look at how we overrode the modal style here to make it always show:  https://github.com/mesosphere/marathon/blob/master/src/main/resources/assets/css/main.less#L103
And then use logic in the React component to add and remove, or rather hide and show the tooltip or relevant attributes.
Let's stay away from adding bootstrap logic to the project.

I updated the cosmetics: round progress bars and right alignment.
For the tooltips I would start another PR because I guess it makes sense to show more than just the color explanation. I have some ideas I would create mocks for. In short: historic information about the status changes.

Addressed the style issues, added the new fields to the REST docu and added test cases"

Backend work LGTM, thanks!

:+1: awesome!!

Wow, this is great! Let me run through it with some comments!

Addressed all comments, if not stated otherwise above.

@sttts  the reasoning behind the 1px line between the colors is that some colors (notably, yellow and green) tend to melt into one another when next to each other. The line is meant to give those colors clear visual separation. What are your thoughts?

The black line is more complicated than the proposed css snippet. We need the 0% bars for correct animation. If you filter them out, new color "fly in" from the right. I tried some css selector magic to restrict the black bar to non-0% colors like this:
.health-bar .progress-bar:not([width=0%]) + .progress-bar:not(.health-bar-unscheduled) {
  border-left: 1px solid #2a2c31;
}

But at least in Safari it does not work. Any hint is appreciated.

Sorry the wait on the response, had to dig into it. This should work, without removing 0%-value elements, which I admit was kinda hacky:
.health-bar .progress-bar + .progress-bar:not([style*="width:0%"]) {
  border-left: 1px solid #2a2c31;
}

Does that work for you?
Also, I found that this part: :not(.health-bar-unscheduled) wasn't actually needed because it is the same, colour, so it doesn't really make a visual difference.

@mlunoe The black bars show up fine now. But we have another issue now: due to the black separators the width 100% plus the lines is larger than the width of the bar, leading to line wraps.
I added some css to stop the line-wrapping. But of course this is not 100% correct. Any better idea?

@sttts That shouldn't be a problem? We use box-sizing: border-box, so border should be included in the the width. Where do you see this happen?

It was due to rounding errors. In Safari's inspector I saw e.g. 16.66666666668% in case of taskSum=6. Of course this does not add up to 100%.
I added a workaround to cut off digits after the 3rd decimal.

@mlunoe We need a restriction for the black line. Otherwise, we see this:

Please also fix the jshint/jscs errors reported in the build:
Missing space after "function" keyword at components/AppHealthComponent.js :
    55 |    }, 0);
    56 |
    57 |    var roundWorkaround = function(x) { return Math.floor(x*1000) / 1000; }
------------------------------------------^
    58 |
    59 |    var normalizedHealthData = healthData.map(function (d) {
Missing space before opening round brace at components/AppHealthComponent.js :
    55 |    }, 0);
    56 |
    57 |    var roundWorkaround = function(x) { return Math.floor(x*1000) / 1000; }
------------------------------------------^
    58 |
    59 |    var normalizedHealthData = healthData.map(function (d) {
Operator * should not stick to preceding expression at components/AppHealthComponent.js :
    55 |    }, 0);
    56 |
    57 |    var roundWorkaround = function(x) { return Math.floor(x*1000) / 1000; }
-------------------------------------------------------------------^
    58 |
    59 |    var normalizedHealthData = healthData.map(function (d) {
Operator * should not stick to following expression at components/AppHealthComponent.js :
    55 |    }, 0);
    56 |
    57 |    var roundWorkaround = function(x) { return Math.floor(x*1000) / 1000; }
--------------------------------------------------------------------^
    58 |
    59 |    var normalizedHealthData = healthData.map(function (d) {
If statement without curly braces at components/AppHealthComponent.js :
    69 |    for (var i = 0; i < normalizedHealthData.length; i++) {
    70 |      if (normalizedHealthData[i].width !== "0%") {
    71 |        if (!allZeroWidthBefore)
----------------^
    72 |          normalizedHealthData[i].className += " health-bar-inner";
    73 |        allZeroWidthBefore = false;

components/AppHealthComponent.js: line 57, col 76, Missing semicolon.

1 error

===== 1 JSHint Error

Other than that I think this is looking great! Awesome work @sttts!

On small screens:

:100: This is an amazing improvement to the UI. Thank you so much for contributing @sttts !!

Cool! Thanks for merging and thanks for all the reviews.

Awesome! :fireworks:

This is great stuff! Thanks a lot.

:+1:, major kudos for you perserverance @sttts.  Nice result.


Add a test for CASE WHEN scalar function.

In the test, all the arguments in the CASE WHEN are literal, so the query is rewritten by CompileTimeFunctionsInvoker, which calls the CASE WHEN scalar function.

Codecov Report

Merging #11340 (e9cc6ad) into master (f25f3ed) will decrease coverage by 53.82%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #11340       +/-   ##
=============================================
- Coverage     68.46%   14.64%   -53.82%
+ Complexity     6535      494     -6041
=============================================
  Files          2233     2159       -74
  Lines        119952   116795     -3157
  Branches      18191    17745      -446
=============================================
- Hits          82128    17110    -65018
- Misses        31984    98270    +66286
+ Partials       5840     1415     -4425

Flag
Coverage Δ

integration1
?

integration2
?

java-11
?

java-17
?

java-20
14.64% <ø> (-53.65%)
:arrow_down:

temurin
14.64% <ø> (-53.82%)
:arrow_down:

unittests1
?

unittests2
14.64% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1710 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Formatting if expressions can have problems when applying the short syntax style.

Hello,
I believe I found a weakness in the rule:
If either cond, e1 or e2 are longer, but not multi-line:
if cond
then e1
else e2

if e1 is also a SynExpr.IfThenElse it can lead to a compiler error.
Related Fantomas bug: https://github.com/fsprojects/fantomas/issues/1243
                        if f.IsProperty then
                            if f.IsInstanceMember then
                                if f.IsDispatchSlot then 9 else 1
                            else 8
                        elif f.IsMember then
                            if f.IsInstanceMember then
                                if f.IsDispatchSlot then 11 else 2
                            else 10
                        else 3

was transformed to
                if f.IsProperty
                then if f.IsInstanceMember then if f.IsDispatchSlot then 9 else 1 else 8
                elif f.IsMember
                then if f.IsInstanceMember then if f.IsDispatchSlot then 11 else 2 else 10
                else 3

On a personal note, I never was overly fond of the longer, but not multi-line, it leaves a lot of room for interpretation what "longer" is.
My proposal would be to remove the rule and add a further restriction to If cond, e1 and e2 are short, simply write them on one line:, that e1 or e2 cannot be an if/then/else itself.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8c09996f-24ac-cf39-ef43-d7909cbc2b89
Version Independent ID: 1efdd523-8552-6421-e149-74f76826ef8f
Content: F# code formatting guidelines
Content Source: docs/fsharp/style-guide/formatting.md
Product: dotnet-fsharp
GitHub Login: @cartermp
Microsoft Alias: phcart

Thanks, that is good feedback. I'd be happy to accept a PR that adjusts the guidance!


Issue #1879 remove deprecated field on Cognito update Pool

Trivial code, tested on Python 3.
Description
AWS deprecated a field and that broke the cognito event setting.
This is an implementation of the solution suggested by @Yaronn44.
It follows the boto3 documentation (specifically the Note for deprecation): https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cognito-idp.html#CognitoIdentityProvider.Client.update_user_pool
GitHub Issues
https://github.com/Miserlou/Zappa/issues/1879

Coverage increased (+0.02%) to 73.238% when pulling e252cbccee886c765ad3f683977eef855e532b48 on vincentalvo:cognito-event-fix into 3ccf7490a8d8b8fa74a61ee39bf44234f3567739 on Miserlou:master.

Coverage increased (+0.02%) to 73.238% when pulling e252cbccee886c765ad3f683977eef855e532b48 on vincentalvo:cognito-event-fix into 3ccf7490a8d8b8fa74a61ee39bf44234f3567739 on Miserlou:master.

Coverage increased (+0.02%) to 73.238% when pulling e252cbccee886c765ad3f683977eef855e532b48 on vincentalvo:cognito-event-fix into 3ccf7490a8d8b8fa74a61ee39bf44234f3567739 on Miserlou:master.

Coverage increased (+0.02%) to 73.238% when pulling e252cbccee886c765ad3f683977eef855e532b48 on vincentalvo:cognito-event-fix into 3ccf7490a8d8b8fa74a61ee39bf44234f3567739 on Miserlou:master.

Coverage increased (+0.02%) to 73.238% when pulling e252cbccee886c765ad3f683977eef855e532b48 on vincentalvo:cognito-event-fix into 3ccf7490a8d8b8fa74a61ee39bf44234f3567739 on Miserlou:master.

Coverage increased (+0.02%) to 73.238% when pulling e252cbccee886c765ad3f683977eef855e532b48 on vincentalvo:cognito-event-fix into 3ccf7490a8d8b8fa74a61ee39bf44234f3567739 on Miserlou:master.

I'm using this patch and everything seems good to me. :+1:

Using it since the issue was found and no problems have been found !

It would be nice if this was merged...

This fix is included, along with related fix in#2027


[Windows simulator] frequently crashes when relaunching simulator

This has been going on for quite a while already, long before Corona transitioned to Solar2D.
When relaunching the simulator via Ctrl+R, the simulator frequently hangs for several seconds and then it crashes. The simulator console remains open and shows the following message: The stdin connection has closed.
I haven't been able to find any particular reason as to what triggers this. Sometimes I get a day or two by without a single incident, whereas other days the simulator seems to crash between ~5-10 relaunches.
There seem to be two different types of the error messages in Windows Event Viewer, which are:
Source: Application Error
Task Category: (100)
Event ID: 1000
Level: Error

Faulting application name: Corona Simulator.exe, version: 20.0.3619.0, time stamp: 0x5f6dd8b5
Faulting module name: ucrtbase.dll, version: 10.0.18362.1110, time stamp: 0x100b54ae
Exception code: 0xc0000409
Fault offset: 0x0009efbb
Faulting process ID: 0x3600
Faulting application start time: 0x01d6ac9bb559023c
Faulting application path: C:\Program Files (x86)\Solar2D\Corona Simulator.exe
Faulting module path: C:\Windows\System32\ucrtbase.dll
Report ID: f1a7cd7b-ec5a-492a-a666-0473356e0446

Source: Application Error
Task Category: (100)
Event ID: 1000
Level: Error

Faulting application name: Corona Simulator.exe, version: 20.0.3619.0, time stamp: 0x5f6dd8b5
Faulting module name: VCRUNTIME140.dll, version: 14.24.28127.4, time stamp: 0x5d8e68be
Exception code: 0xc000041d
Fault offset: 0x0000317e
Faulting process ID: 0x1a1c
Faulting application start time: 0x01d6a0c2c18bc38f
Faulting application path: C:\Program Files (x86)\Solar2D\Corona Simulator.exe
Faulting module path: C:\Windows\SYSTEM32\VCRUNTIME140.dll
Report ID: 75276772-80f8-44da-a270-d91e1b0ab2b3

Source: SideBySide
Task Category: None
Event ID: 78
Level: Error

Activation context generation failed for "C:\Program Files (x86)\Solar2D\Corona Simulator.exe".Error in manifest or policy file "" on line . A component version required by the application conflicts with another component version already active. Conflicting components are:. Component 1: C:\Windows\WinSxS\manifests\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.18362.1082_none_e62ecab8f8d74ec7.manifest. Component 2: C:\Windows\WinSxS\manifests\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.18362.1082_none_9e8193e1e45b25c1.manifest.

Here's my development computer's information if that helps:
------------------
System Information
------------------
      Time of this report: 10/28/2020, 09:16:17
             Machine name: XEDHEAD-ORPHAN
               Machine Id: {FCD5D9DA-527D-49E9-9A9E-7789CAEC7611}
         Operating System: Windows 10 Home 64-bit (10.0, Build 18363) (18362.19h1_release.190318-1202)
                 Language: English (Regional Setting: English)
      System Manufacturer: MSI
             System Model: MS-7917
                     BIOS: V1.13 (type: UEFI)
                Processor: Intel(R) Core(TM) i5-4690K CPU @ 3.50GHz (4 CPUs), ~3.5GHz
                   Memory: 16384MB RAM
      Available OS Memory: 16332MB RAM
                Page File: 11219MB used, 37881MB available
              Windows Dir: C:\Windows
          DirectX Version: DirectX 12

---------------
Display Devices
---------------
           Card name: NVIDIA GeForce GTX 960
        Manufacturer: NVIDIA
           Chip type: GeForce GTX 960
            DAC type: Integrated RAMDAC
         Device Type: Full Device (POST)
          Device Key: Enum\PCI\VEN_10DE&DEV_1401&SUBSYS_85201043&REV_A1
       Device Status: 0180200A [DN_DRIVER_LOADED|DN_STARTED|DN_DISABLEABLE|DN_NT_ENUMERATOR|DN_NT_DRIVER]
 Device Problem Code: No Problem
 Driver Problem Code: Unknown
      Display Memory: 10174 MB
    Dedicated Memory: 2007 MB
       Shared Memory: 8166 MB

I think it is related to video.  Maybe related to https://github.com/coronalabs/corona/issues/154

A while ago I made a build with new toolchain. Could you see if that would happen there too? It is a 3 month old test build, but should work out fine. Direct download.

I tried it out and after relaunching the simulator every few seconds, I got the familiar error report on 20th relaunch or so:
Faulting application name: Corona Simulator.exe, version: 20.0.9999.0, time stamp: 0x5f3505bb
Faulting module name: ucrtbase.dll, version: 10.0.18362.1110, time stamp: 0x100b54ae
Exception code: 0xc0000409
Fault offset: 0x0009efbb
Faulting process ID: 0x1660
Faulting application start time: 0x01d6aea67b6ed4dc
Faulting application path: C:\Program Files (x86)\Solar2D\Corona Simulator.exe
Faulting module path: C:\Windows\System32\ucrtbase.dll
Report ID: 5303705f-4a1e-46be-8c61-15ecae751370
Faulting package full name:
Faulting package-relative application ID:

Fault bucket<PHONE_NUMBER>255619761, type 5
Event Name: BEX
Response: Not available
Cab Id: 0

Problem signature:
P1: Corona Simulator.exe
P2: 20.0.9999.0
P3: 5f3505bb
P4: ucrtbase.dll
P5: 10.0.18362.1110
P6: 100b54ae
P7: 0009efbb
P8: c0000409
P9: 00000007
P10:

Attached files:
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER9D65.tmp.dmp
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER9F4A.tmp.WERInternalMetadata.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER9F5B.tmp.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER9F59.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER9F79.tmp.txt

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_Corona Simulator_1b64e0909ddd6cdb78518de6891f2e81c822ce_22e9eab4_a65ee507-5122-403f-8cbf-d10b4df69b3f

Analysis symbol:
Rechecking for solution: 0
Report Id: 5303705f-4a1e-46be-8c61-15ecae751370
Report Status: 268435456
Hashed bucket: 409aadc60b8d9782b662d8d0a93418b1
Cab Guid: 0

If it's of any use, here's a Report.wer file (zipped) of the event: Report.zip

Is it possible that those are related?

How it happens:

This message appears when the user tries to start another simulator instance while another one is already running.

I've been working a little on a new project that is mostly just logic and very little graphics. I hadn't encountered any of these frequent crashes until I added the initial audio systems to the project, after which it began to occasionally crash again.

So, my hunch is that this is somehow related to audio.
I did some googling for "ucrtbase.dll audio" and I found plenty of promising forum threads, articles, etc. These crashes may be caused by audio drivers (like Realtek or Nahimic) on Windows with ASUS/MSI motherboards (I've got MSI).

Since moving from MSI to LG Gram this problem has gone away.
Also regarding ucrtbase.dll crashes, I had a few yesterday for a coding error.  Try putting print(os.date("%s")) in main and you get a horrible crash.

Yeah, funnily enough my desktop has MSI and laptop has ASUS, which explains why I've been experiencing these issues on both of my devices.
In order to reproduce these audio related crashes when Solar2D Simulator restarts, all you need to do is have audio files loaded via audio.loadSound(). There's no need to do anything else with the audio, just having them loaded will frequently crash the simulator when restarting the project.

As for your newfound crash, @mark-sgs, I'd recommend creating a new issue for it. That is weird indeed as it crashes immediately without raising any warnings or errors.

@Shchvova
I've managed to further isolate the problem and I've even prepared a sample project that demonstrates the crash (on affected devices). All that the sample project does is that it traverses a directory for audio files and then loads them using audio.loadSound().

The problem seems to lie entirely with mp3 files.
I tried the attached sample project with mp3, ogg and wav files. The files are all from the same source and I've just converted the original ogg files to wav and mp3. Seems like running the sample project with wav files takes about 20ms, ogg files takes about 60ms and mp3 takes around 120-150ms.
There's no worry about the handling times as such, but when you run the sample project and assign the project to load audio files from any of the three folders, the simulator seems to sporadically crash only when handling mp3 files.

How to replicate:
As far as I know, this issue only affects Windows devices running MSI or ASUS motherboards. All that you need to do is open the attached sample project on such a device (other motherboards may be also affected) and ensure that on line 10, the folder is set to "mp3".
Then you just need to press Ctrl+R, wait a second or two and repeat until the simulator crashes. Sometimes it takes 3-5 tries and other times it takes 30-50, so it isn't crashing consistently.

This potentially could have been fixed by #414

I ran my audioCrash project 300+ times now and then I left another project running with a macro spamming Ctrl+R for a good while. The simulator didn't crash after 1000+ restarts, so I gave up.
Seems like this issue has been fixed with Solar2D 2022.3675.
Great work @ggcrunchy!


Pdicfg_validate fails with recent pyyaml

yaml TypeError: load() missing 1 required positional argument: 'Loader'

mentioned in commit afb14a0b9c5a33da0caa8f64356ef66760702649

mentioned in commit e8bf0cfe830b40b784dfe8beca61aaf8cc19fd7e

mentioned in commit 6868503e9747d610fc5d461f3cd6125e605152f4

mentioned in commit 32064c46bf7c9fc73899e16d7820f675ccc94405


gh-828 - AccumuloAllElementsRetriever Should apply post transformation functions

Modified AccumuloAllElementsRetriever to use the ItemRetriever super class - will now correctly apply transformation functions and the common parent should make the AccumuloAllElementsRetriever more resilient to change.

Codecov Report

Merging #830 into develop will increase coverage by 0.1%.
The diff coverage is 25%.

@@             Coverage Diff              @@
##             develop     #830     +/-   ##
============================================
+ Coverage      58.64%   58.74%   +0.1%
  Complexity      2669     2669
============================================
  Files            489      489
  Lines          12241    12220     -21
  Branches        1343     1341      -2
============================================
  Hits            7179     7179
+ Misses          4474     4453     -21
  Partials         588      588

Impacted Files
Coverage Δ
Complexity Δ

...e/retriever/impl/AccumuloAllElementsRetriever.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...accumulostore/retriever/AccumuloItemRetriever.java
59.74% <100%> (ø)
3 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08293be...5cee567. Read the comment docs.


Event.MouseWheel.Delta sometimes returns 0

On Windows, when a mouse wheel event is triggered, sometimes the Delta parameter is 0. It probably happens with high-resolution mice, which trigger mouse wheel events with an internal delta less than 120. Therefore this code:
event.MouseWheel.Delta = static_cast<Int16>(HIWORD(wParam)) / 120;

... leads to Delta being 0.
I must find a solution to handle correctly both regular and high-resolution mice.

I think it's a good time to remind about this issue. It seems to me that it happens on every Microsoft mouse (event the cheapest ones, without smooth scroll). It wouldn't be that bad if I could somehow read the wheel direction (when delta is 0), but it's not possible in current case.
Anyway, accumulating delta values isn't a good solution for me, cause it require 2 wheel movements to trigger event. I think returning floats should be enough (with info in doc, that delta may be less than 1).

I vote for providing float values and then letting the user manually round or cast it. This allows for games to take advantage of high precision scrolling.

Is there a workaround for this in the meantime?

Is there a workaround for this in the meantime?

Not really...
So... floats it is then? :grin:

Sounds good to me.

This would be an API breaking change, right?

Since floats can be cast back to integers (with warnings if you have them enabled) I don't see how this would "break" the API. Strictly speaking, yes it would break the API but the same code could be compiled even if floats were used, so in that sense it doesn't really "break" anything for the developer. The ABI would change yes... but that would happen no matter how we choose to solve this problem I think.
Bonus: If the developer already uses C++11 automatic type deduction and has type independent code, they won't even notice anything.

This would be an API breaking change, right?

I don't see how this would be any different than changing font metrics from ints to floats.

if (event.mouseWheel.delta == 1)
    up();
else if (event.mouseWheel.delta == -1)
    down();

Not the most clever code, but you get the idea, code that deals with this event may do something that works with integers but not floats (in this case, event.mouseWheel.delta might be 1.00001).

Well... we could always consider just adding a .deltaHighPrecision field to the struct instead.

Not the most clever code, but you get the idea, code that deals with this event may do something that works with integers but not floats (in this case, event.mouseWheel.delta might be 1.00001).

I'd probably blame the compiler since it's not warning about the potential issue. :)
But considering this would be very isolated and pretty easy to locate/fix, I'd ignore that. As mentioned in the other thread, keeping the integer comparison will be buggy as well. So do we want a consistent and clean fix or do we want to keep a broken system just to lessen the impact on existing code, which would essentially be broken anyway?

We provide a clean way of doing things for those who care. There are always going to be people who can't care less about their broken code/warnings, and for them the current implementation is just "good enough". They will start caring however, if we break (i.e. no longer function "good enough") their code. I don't think annoying people who don't want to be annoyed is the right way to go. For those who do care and commented on this issue, there will be the new system with which they can write their code and benefit from.
The API isn't meant to teach people how to write their code. If they can't be bothered using it properly and are fine with the results thereof, then so be it.

Not breaking the API between minor versions, especially with such nasty bugs that may end up being hard to track for users, is very important if we want SFML to be considered a little more seriously.

Yeah, well, agree - just no fan of having "duplicate" members.

Fixed in #810


fix compilation on Ubuntu 14.04 and other old Linuxes

Motivation:
Glibc (in Sep 2014) changed the first parameter of eventfd from int
to unsigned int (which we assume since recently).
Modifications:
Make the code work with int and unsigned int.
Result:
Compiles again on 14.04.

note, the change came in #1797


Captioning causing errors

Went through the normal captioning steps and was met with this error

fixed, thanks for the feedback

no problem, thanks!


pkg/components: add Headlamp component

Fixes https://github.com/kinvolk/lokomotive/issues/988

@iaguis can you address the reviews. Or do you mind someone taking it over?

@iaguis make sure to pull the reviewers again when you are done addressing review comments. Resolving existing conversations when they are addressed is also helpful while doing another rounds of reviews :)

@iaguis make sure to pull the reviewers again when you are done addressing review comments. Resolving existing conversations when they are addressed is also helpful while doing another rounds of reviews :)

Yes, I was waiting for CI to pass and I didn't realize it was passing already :D


Adopt Object tree for outline and breadcrumbs

We have a new tree and we want to use it for the outline

@joaomoreno there is still no sorting in the new tree, right?

working for outline and breadcrumbs is happening here: https://github.com/Microsoft/vscode/tree/joh/o2

@joaomoreno fyi - this has been merged to master.


build errors

`let upstream =
https://github.com/purescript/package-sets/releases/download/psc-0.14.5-20220224/packages.dhall sha256:67cc3d4f0e8fb72bb1413ba94ddd72a3ceb0783eb725e3b22ad7568b3b581163
in  upstream
with httpure =
{ dependencies = [
"aff"
, "arrays"
, "bifunctors"
, "console"
, "effect"
, "either"
, "foldable-traversable"
, "foreign-object"
, "js-uri"
, "maybe"
, "newtype"
, "node-buffer"
, "node-fs"
, "node-http"
, "node-streams"
, "options"
, "ordered-collections"
, "prelude"
, "refs"
, "strings"
, "tuples"
, "type-equality"
] : List Text
, repo = "https://github.com/citizennet/purescript-httpure"
, version = "v0.16.0"
}
with { name = "my-project"
, dependencies = [
"argonaut-codecs"
, "argonaut-core"
, "console"
, "effect"
, "prelude"
, "psci-support"
, "httpure"
]
, packages = ./packages.dhall
, sources = [ "src//*.purs", "test//*.purs" ]
}
build fails with these errors:Compiling HTTPure.Body
Compiling HTTPure.MultiHeaders
Error 1 of 2:
in module HTTPure.Body
at .spago/httpure/v0.16.0/src/HTTPure/Body.purs:121:5 - 121:89 (line 121, column 5 - line 121, column 89)
Could not match type

  Function t0

with type

  Effect

while trying to match type t0 -> t1
with type Effect Unit
while checking that expression (apply const) ((apply done) (Right unit))
has type Effect Unit
in value declaration bodyString
where t1 is an unknown type
t0 is an unknown type
See https://github.com/purescript/documentation/blob/master/errors/TypesDoNotUnify.md for more information,
or to contribute content related to this error.
Error 2 of 2:
at .spago/httpure/v0.16.0/src/HTTPure/MultiHeaders.purs:1:1 - 133:112 (line 1, column 1 - line 133, column 112)
Unable to parse foreign module:

  .spago/httpure/v0.16.0/src/HTTPure/MultiHeaders.js

  The module could not be parsed:

  ExportToken {tokenSpan = TokenPn 0 1 1, tokenLiteral = "export", tokenComment = []}

See https://github.com/purescript/documentation/blob/master/errors/ErrorParsingFFIModule.md for more information,
or to contribute content related to this error.
`

Hey @amkhlv! It would be nice to know more details about the error. I see that you're using https://github.com/purescript/package-sets/releases/download/psc-0.14.5-20220224/packages.dhall for your package set. As the name of the package set says, its packages are compatible with PureScript v0.14.5, whereas purescript-httpure v0.16.0 (which is the one you're overriding), is only compatible with PureScript ≥ v0.15.0.
In order to solve the issue I believe you have two options:

Upgrade your compiler version and your package set.
Do not override purescript-httpure and use the version provided by the chosen package set, as it's guaranteed to work with the compiler version of the package set and with all other packages.


HTTP 401 on Exchange Online cmdlets when running in app-only mode

Receiving a 401 error on some EXO cmdlets when running in app-only mode.
The app that was authorized into the tenant consented to the Exchange.ManageAsApp scope and the service principal has been assigned to the Exchange Admin role. Are there additional scopes that are required?
Install-Module -Name ExchangeOnlineManagement -RequiredVersion 2.0.4 -Force
Connect-ExchangeOnline -CertificateFilePath '<path_to_cert>' -CertificatePassword (ConvertTo-SecureString -String '<password>' -AsPlainText -Force) -AppID <app_id> -Organization 'tenant.onmicrosoft.com'

Get-EXOMailbox -ResultSize unlimited
Get-EXOMailbox: Error while querying REST service. HttpStatusCode=401 ErrorMessage={"error":{"code":"Unauthorized","message":"User is not allowed to call Get-Mailbox","innererror":{"message":"User is not allowed to call Get-Mailbox","type":"Microsoft.Exchange.Admin.OData.Core.ODataServiceException"}}}

Get-Mailbox -ResultSize Unlimited
Get-Mailbox: The term 'Get-Mailbox' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

This appears to have been because the role that was assigned to the Service Principal was Security Administrator, which is a supported role per the official documentation https://docs.microsoft.com/en-us/powershell/exchange/app-only-auth-powershell-v2?view=exchange-ps#step-5-assign-azure-ad-roles-to-the-application but errors with the following cmdlets:
Get-RemoteDomain, Get-Mailbox, Get-OrganizationConfig, Get-OwaMailboxPolicy, Get-AdminAuditLogConfig, Get-SharingPolicy
Is the documentation incorrect?

Hi @niharaobsec, thank you for your feedback.
Security Administrator is supported, but it doesn't have the roles to run the cmdlets you need. For more information, see the following similar issue:
https://github.com/MicrosoftDocs/office-docs-powershell/issues/6992
Please let me know if you need more help.

@dariomws Thanks for your response!
Would be nice if the documentation called that out, especially as the questions appears to have come up more than once on here.

@dariomws Are there a different set of roles that apply to these cmdlets:
Get-SafeLinksPolicy
Get-AtpPolicyForO365
Get-SafeAttachmentPolicy
Get-TransportRule

@niharaobsec, those cmdlets are 100% Exchange Online PowerShell related. Global administrator and Exchange administrator will definitely give you access to those cmdlets.

@niharaobsec, I updated the topic with the following note:

The Global administrator and Exchange administrator roles provide the necessary permissions for any Exchange-related tasks, including recipient management and protection features (anti-spam, anti-malware, etc). The Security administrator role doesn't not have the necessary permissions for these same Exchange-related tasks.

Thanks for the feedback.
Closing
P.S. Feel free to reopen this Issue as necessary


[SPARK-7331][SQL] Re-use HiveConf in HiveQl

Re-use HiveConf in HiveQl

Can one of the admins verify this patch?

ok to test

Merged build triggered.

Merged build started.

Test build #32027 has started for   PR 5880 at commit aec478e.

Test build #32027 has finished for   PR 5880 at commit aec478e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32027/
Test PASSed.

Probably it's better to get the hiveconf from SessionState instead of just new HiveConf().

Using that when SessionState.get() is not null seems reasonable.  But if its null I'd just create one so that parsing doesn't have a dependence on a full running copy of hive.

Closing this PR over master as it has been fixed as part of SPARK-7411. Will create separate PRs for 1.2 and 1.3 branch

@chenghao-intel @marmbrus (as per my understanding) Looks like SessionState is threadlocal and gets SET only for "NativeCommands" which gets executed on hive. For Spark SQL commands, its not set and each time creates a new hive conf for Spark SQL queries and defeating the actual purpose of this issue.

SessionState is a threadlocal variable internally maintained by Hive code, hence hive can isolate the configurations, context etc per user session.

@chenghao-intel I get that. So, should we do something like :-
lazy val cachedHiveConf = new HiveConf()
private[this] def hiveConf(): HiveConf = {
val ss = SessionState.get() // SessionState is lazy initializaion, it can be null here
if (ss == null) {
cachedHiveConf
} else {
ss.getConf
}
}

Oh, thanks for noticing this. But the answer is not necessary!
In user application, the HiveContext will create the SessionState (indirectly) before SQLParser being called/created, and then val ss = SessionState.get() will always be non-null.
The reason that I put the new HiveConf() is for unit test purpose for HiveQl, which can run independently without HiveContext being initialized.
Sorry, I should put more comment here.

Sorry for not being clear in my first comment but I meant that for queries like "select a,b,c from table where a=10" where table is cached as schemaRDD (spark-1.2), SessionState.get() is always returning null. Do you see why this might be happening?

In Spark 1.2, the SessionState should be initialized in HiveContext (or probably in SparkSQLCLIDriver if you are using the CLI). Can you describe how to reproduce that? Or are you using the HiveContext, not SQLContext?

Yes, I am using HiveContext and calling hiveContext.sql, basically following line gets executed :-
https://github.com/apache/spark/blob/branch-1.2/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala#L94
If this problem seems to be just with 1.2, can we make the change as I suggested in 1.2 branch?

Hmm, seems a bug in Spark 1.2, will cause some performance overhead (creating the HiveConf object everytime), but, we should always initialize the SessionState before the HiveQL called.
sessionState is a lazy val variable of HiveContext, and does not initialize even the .sql() method called. A better place to fix that will be trigger the initialization prior to the sql(), I think it has been fixed in the latest code, can you confirm that?

Yes, seems like it is being done in 1.4
https://github.com/apache/spark/blob/branch-1.4/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala#L167
Should we do exactly like this in 1.2 as well?

Actually the HiveContext changed a lot since 1.2, it will be great if you can figure out a simple / nature way to fix this. In general, we just need to trigger the initialization of the sessionState in HiveContext after HiveContext instance being created.


No doc folder

No doc folder in directory amd/tressfx/ like said in the description. The documentation is supposed to be here.

I think the viewer source give a good example, but readme.md says there is a document.

I removed mention of the nonexistent doc folder. See de6305e55f54c8ec716c17c577b09a13ef53eb9f.
I am leaving this issue open because there is supposed to be an amd_tressfx\doc folder, but the documentation that would go there is quite out of date and needs to be updated before pushing to GitHub. Realistically, that is not going to happen until after GDC.

Okay, never mind what I said in my previous comment. I quickly put together some high-level overview slides, largely taken from previous material. The amd_tressfx\doc folder exists now.
More detailed documentation will have to wait until after GDC, though. For real.

Thanks jstewart~


i18n: add Chinese translation :cn: (Simplified & Traditional)

Imported the Chinese translations from Transifex that someone else did, because according to the matrix group, these are already finished.

There are some build errors as the translation files are not imported correctly. Would you be able to make the necessary changes and verify that it works in your regtest environment?
If I can be of any service, please do not hesitate to ask! :pray:

Builds fine for me now. Can you confirm? :)

Builds fine for me now. Can you confirm? :)

Yes. Looks great. :tada:


fetch docs improvements

@arxpoetica suggested fetch was the hardest thing to understand in migrating to SvelteKit. We should probably explain something about the fetch being passed in via load assisting with hydration and optimizing out local HTTP calls

Yes, please. :) An example for #1868 could be added.


Strategy should buy minimum amount

Some stock price are very cheap, if we buy 1 stock 100 days, it would be a very small amount.
we should be able to set minimum amount of money to buy stocks.

Fixed by https://github.com/sunglim/systemtrading/pull/29


Clarify whether emit is supported on varbit values

Section 8.8 "Operations on variable-size bit types" of P4_16 language spec v1.1 says:
"Variable-length bit-strings support a limited set of operations:"
followed by a bullet item:
"The emit method of a packet_out extern object, which inserts a variable-sized bit-string with a
known dynamic width into the packet being constructed"
There seem to be at least two ways this could be interpreted (or misinterpreted):
(a) If v1 is a variable of type varbit<W>, it is legal to do the operation packet.emit(v1);
(b) The previous scenario is not supported.  It is supported to have a varbit type field inside of a header, and call packet.emit(h1); on a header, header stack, or header_union that contains a varbit field.
I think (b) is what is intended, but if so, it seems easy to misinterpret it as (a), given that this section is for operations on the varbit type, and all other operations in the other bullets can be performed directly on values of type varbit.
If (b) is the intended meaning, I am happy to suggest some changes that make this clearer, e.g. taking the extract and emit bullet items in Section 8.8 and discussing them separately than the operations that can be done directly on a value of type varbit.

Note: the latest version of p4c as of 2019-Feb-17 gives the following error if you attempt to make a call like packet.emit(v1); where v1 is of type varbit<W>.  This error message is from p4test, so not specific to any architecture, I would think:
$ p4test checksum-ipv4-with-options.p4
checksum-ipv4-with-options.p4(215): [--Werror=type-error] error: packet.emit: argument must be a header, stack or union, or a struct or tuple of such types
        packet.emit(hdr.ipv4.options);
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

As you might guess from the error message, you'll get the same error if v1 is a bit<N> -- its not just varbits that are disallowed.

Yes. emit should not be allowed on bit, int or varbit directly. Spec is clear in section 8.5 and 8.6 that 'emit' is not a the supported operation. What is confusing is 8.8, where spec mentions 'emit' is a supported operation on varbit. @jafingerhut has pushed a PR to fix the confusion in spec.

Spec clarification has been merged in, so closing this issue.

Spec clarification has been merged in, so closing this issue.

@mbudiu-vmw Sorry for the bother.  I tried closing this issue, but on Github it still shows up on the open issues list right now.  What do you see for its status?  Hopefully this is a short-term delay in Github updating things, but notifying you in case it isn't.

It says here that the issue has been closed 1 hour ago.


Implement to ask run extract_best_config right after the evaluate(in cli command)

@bwook00 Is this really good feature?

close long time ago
clost at b0b503ab


Output continuation option

Hi, I've been running into an issue for awhile now, and it looks like a good opportunity for a feature for instructor.
Most of the supported models return up to 4096 tokens, and if the model returns more than that and indicates it stopped due to "length" (token length), an IncompleteOutputException is rightfully thrown.
For OpenAI and Anthropic (haven't tested on other models), it's possible to prompt the model to continue providing structured output where it left off, so long as the user includes the progress so far in the prompt. It may take one or more passes to actually retrieve the entire output. This happens when context length is on the longer side, which a lot of newer models are supporting, but lists of items returned are too long to fit into the output context window.
I'd be glad to take a stab at a contribution here, but want to know if it would be useful to provide an option to prompt the llm API to "continue" up to x number of times, similar to retry logic.

Think what you are asking.
If output is text, split in 2 responses:
half_Text + half_Text = Text
If output is an object, split in 2 responses:
half_object + half_object = no_object.
Why? Neither Instructor nor Pydantic expect an object in 'pieces'.
I think, but could be wrong.

See https://github.com/jxnl/instructor/discussions/566

Think what you are asking.
If output is text, split in 2 responses: half_Text + half_Text = Text
If output is an object, split in 2 responses: half_object + half_object = no_object.
Why? Neither Instructor nor Pydantic expect an object in 'pieces'.
I think, but could be wrong.
See #566

Maybe I was unclear in my description: the issue in this case happens when producing a list or an iterable of smaller objects. If the number of those objects is high, you can still reach the output context window limit.

this is tought, not sure what the best path forward is, can you provide a sketch? just api level what the DX looks like?


Memory Leak?

Running the example from https://github.com/ostrosco/device_query/blob/master/examples/print_keys.rs
I just see my process taking more and more memory as I type.

Windows or Linux? I'll check both, but I'd like to replicate it to see what's going on.

Linux, I just took the example and did cargo run in activity monitor I just see my memory going up as I type.

Thanks for the report! The memory leak has been fixed in version v0.1.2.

Thank you, confirmed it works!


Add note about "fatal: not removing recursively without -r"

A common error when attempting to remove a git submodule is this:

fatal: not removing 'lib/name' recursively without -r

It would be nice to add a note about this in the Removing dependencies section, and what is the solution if users bump into this.

Pretty sure this was fixed recently?

It occurred multiple times for me, recently. But anyways, if this is supposed to be something that either was fixed or can be fixed in Forge itself, I'll close this issue here.


Feature/privacy policy

Closes #133

Code-wise this looks very good and I have no objections whatsoever! :)
Still two observations from an UI/UX point of view:

at least the german string "Datenschutzerklärung" is quite long for small devices, which breaks the layout and forces the icon to move above that title (not everything is translated in this view, which is WIP)

the text-color for the privacy-policy itself is quite light for the background. Maybe use black text to increase readibility?

Hi Jerome, thanks for the review. I changed the German text that is displayed in the settings menu to the shorter "Datenschutz", as well as changed the color of the text to black.


NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl…

…uster Leader Election and State Management

Summary
NIFI-12590
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[X] JDK 21

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Thanks for proposing this addition @juldrixx. I provided some recommendations on naming and implementation details.

Thanks for the review, I should have made the requested changes.


Please add License File

Hi there!
Could you please add a license file to this script so that I make sure to only use it in a way that's allowed by the license. Unfortunately, if a license file is not present we must assume that it's all rights reserved by the author.
Thanks!

Sorry about that @BandonRandon.
I've added a license file (Apache).


Writing app_id outside js code

Description:

I am trying to use onesignal for my android app. Currently, this is working, but I have this line in my file app.js:
OneSignal.init('xxxxxx-xxxx-xxxx-xxxxx-xxxxxxxxxxx');

where all the xxxx represents my onesignal_app_id. This is what is recommended in OneSignal doc, but I am not familiar with app creation, and my question is: Does this mean that if someone unzip the apk, he can get my onesignal_app_id?
I was using an older buildTool (23.0.2) before, allowing me to write the onesignal_app_id in the gradle (as can be seen here), and it felt safer. But I had to update some dependencies, and I need to use buildTools 28, and the previous method does not work anymore.
So my question is: can I write the app_id safely in my code? If not, how to put it in a safe place?
Environment

For my android:
compileSdkVersion 28
buildToolsVersion '28.0.3'

dependencies:    {api "com.onesignal:OneSignal:3.10.7"}

I used npm to add the SDK to my project.
In the js code, simply:
import OneSignal from 'react-native-onesignal';
Steps to Reproduce Issue:

Well this isn't really a bug, more help wanted.
Anything else:
(crash stacktraces, as well as any other information here)

Thanks a lot!
Djazouli

Hello,
Thank you so much for your question. You can read our response here.


Do not clobber init.py if it already exists

When generating Python code from flatbuffer schema, do not clobber init.py if it already exists.

Was this opened on the wrong repo, perhaps? I'm not sure what you are referring to.


Update auth.md

Fixed a typo

@Peternator7 Thank you for your contribution, I am merging it now and it should be live shortly. Please accept our apologies for this initial delay while we work though the initial backlog of contributions.


feat(#major); maple 2.0; add subgraph

Add Maple 2.0 as a subgraph we support. Change the original maple to maple-finance-v1
Test: https://okgraph.xyz/?q=dmelotik%2Fmaple-finance-v2-ethereum
TODO:

[x] Get rates to work
[x] Figure out why it seems like we are missing loans (maybe proxies not all being created)? AQRU loans missing
[x] Get rev working
[x] Liquidation handler
[x] Fix transactions not logging bc the positions are not found

@ishraq8 this is ready for QA once synced. @jaimehgb / @tnkrxyz this is ready for a code review when you guys are ready

@dmelotik Is there a deployment error on this? it halted syncing.

QA passed, Code review required.

lint doesn't like the extra "docs" and "validation" subdirectory now in maple-finance-v1

@tnkrxyz I was goign to just ignore that bc those files were there before and I didn't rly do anything in that folder aside from change the name


Add support for port 80 in basics station

PR for #188
The r.host drops the port information if it is port 80. This makes it so the gateways get the wrong router_config and can't connect properly.
Add a check for if the port doesn't exist, and if it doesn't default to port 80.

Sorry for the late response. I have not tested this, but is this a bug at the ChirpStack Gateway Bridge side, or Basics Station?

( https://datatracker.ietf.org/doc/html/rfc6455#section-3 )
The Basics Station should use port 80 for ws:// and port 443 for wss://. Therefore this change should not be needed?

Added to the above, would this work with IPv6, where an IP can contain colons and if the port is present, the IP and PORT are also separated by colons?


[doc] VirtualScroll doesn't like table/tr/td

In VirtualScroll, the injected <div> elements cause React to complain about using table tags, e.g.: Warning: validateDOMNesting(...): <tr> cannot appear as a child of <div>. See TicketTypeListView > div > tr.
Given that I see no reasonable way to make table tags work well, I see this just as a need for documentation about it.
The easy workaround (at least in my case) is to use display: table-row et al on <div> tags in lieu of <tr>...

Seems like the error message you got from React when you tried was pretty helpful. So that's good. :)

Ok, I won't bother writing up any of the difficulties with CellMeasurer that need doc'ing (IMHO).
While expressing what's going on and how to work around it is easy once one understands, getting to the point of understanding can be non-trivial, and easily lead to folks saying "this is too hard" and walking away.  A few words can make a difference.

Sorry if I offended you. I initially wrote a longer reply but decided to go with a shorter one instead because I thought maybe I was just rambling. The longer reply basically said this:
I don't think this belongs in react-virtualized docs.
Firstly because I don't think it's a react-virtualized issue. Rather it is part of the DOM spec. Elements like div can contain flow elements. Table elements like tr and td have more restricted use-cases. Fortunately, React gave a helpful warning in this case that hopefully limited the confusion and reduced any time lost due to it.
Secondly, and more importantly, longer docs means (1) fewer people will read them and (2) those who do may have more trouble finding what they're looking for.
I've spent a lot of time and effort on react-virtualized docs. I'm sure I'll spend a lot more because they have plenty of room to improve. And I welcome feedback and suggestions on ways to improve them- but I have to make judgement calls on what goes into them- based on my own opinion as well as any larger patterns I've seen from usage of the library over time. (eg if in the future another react-virtualized user expressed a similar opinion- I would probably reconsider my stance on adding this particular issue to the docs somewhere.)
Hopefully this longer explanation makes sense. I didn't mean to sound dismissive with my initial response. 😄 It was early and I hadn't had any. ☕

Thanks!
Likewise, I wouldn't be writing if I didn't think that this is inherently a great project, but I strongly believe that it would be adopted a lot more if it were a little more accessible, especially for people who want to work it into an existing table implementation.  It took a lot of code-reading and breakpointing to understand what's required of the client.
New users (like me!) have no reason to assume that VirtualScroll works by inserting <div>s around each row of their table, or at least aren't likely to have thought about it, and are very unlikely to have thought about the implications re DOM nesting restrictions.

I see. I thought a bit more about the implications of what you were saying while driving to work this morning and wanted to share a concern with you about using tables in general with windowed ("virtualized") content.
HTML table layouts are determined, in part, by the contents of the columns being laid out. If the contents change, the column widths may be adjusted. With a "virtualized" table this would likely be an issue since- every time you scroll- you're changing the table's contents. The result might be unattractive (columns might resize as a user scrolls up or down).
This is why the FlexTable component uses the flexbox layout instead. I'm not sure if flexbxox is an option for your application (given its poor support in older IEs) but if it is- I'd encourage you to consider it as an alternative to table layout. :D
Otherwise, just be sure to use fixed sizes (with min-width and max-width) for your table columns to prevent them from resizing as their content changes. :)

Another solution to this problem, which I happened to be using even before working with VirtualTable, is to use  table-layout: fixed.
Are you sure you don't want to doc this kind of guidance???  It doesn't have to be inline in the base reference material; "Notes" at the end of a doc page makes sense to me.

Let me share my experience with react-virtualized and some material UI library called material-table where the same issue appear (combination table elements with virtualization): https://github.com/mbrn/material-table/issues/891#issuecomment-681986647. There're still some issues like styling problems and validateDOMNesting(...) warning.


Merge changes to master

Merge commit:
https://github.com/sdl/ISHBootstrap/commit/1f3dcfe08e16a31f5f17ad1ab0cb497c3e904b40


[Coding] [Doc update]Tooltip code not found

In the page 'http://uber.github.io/deck.gl/#/documentation/deckgl-api-reference/layers/hexagon-layer', the 'setTooltip' function is not found in the code, it is undefined. Could the code definition be displayed, I searched the whole project code but not found!

I managed to create a scatterplot example with the setTooltip function. I'm not sure if it's the code definition, but it works the same the example.

I am also having this issue with the Polygon Layer. In the documentation http://deck.gl/#/documentation/deckgl-api-reference/layers/polygon-layer 'setTooltip' is not defined. I have searched far and wide for the definition of this function and have found nothing that works. Please give us a clearer definition of this function.

We do not include specific code for tooltips because it can be wildly different depending on if you are using React or not. You can find sample code in the examples folder, e.g.
React:
https://github.com/uber/deck.gl/blob/master/examples/website/geojson/app.js#L89
Pure JS:
https://github.com/uber/deck.gl/blob/master/examples/gallery/src/geojson-layer.html#L107

Strangely enough, the html version works!

If you land here hours into searching for the settooltip, make sure you try with a different class name in React/other npm package, in case tooltip is already used by another css definition. That cost me hours of frustration.


OAuth2 always in status "authorizing"

Hi!
I'm trying to get this node working. I configured client ID and client secret by using the data from the Home Connect application. Every time I click the button on the OAuth2 node, a website is coming up asking me for my home connect developer login and asking me to grant permissions to the application. At the end a white page just shows "OK". But from that point, the node keeps hanging in the status "authorizing".
Any suggestions what is going wrong?
Thank you a lot!

I have the same issue.

This is caused by a change of the API in Authorization (https://developer.home-connect.com/docs/authorization/flow).
When the node request the token, in the body the param "redirect_uri" is missing:

client_id={client_id}&client_secret={client_secret}&redirect_uri={redirect_uri}&grant_type=authorization_code&code={code}

Easy Solution:

Set a global var like cbUrl
In the function getAuthorisationUrl, transfer the var "callbackUrl" to "cbUrl"
in the function getTokens insert the redirect_uri with the cbUrl value

Greetings...

Thank you for the help.
I don't know if I am stupid, blind or both. I cant find any files with that content. I have installed node-red-contrib-homeconnect from CLI. I have checked the folder and digged in all files without result.

https://github.com/pckhib/node-red-contrib-homeconnect/blob/master/src/home-connect-auth.js
Line 51

Line 33: Here you find the var callbackURL —> Store it in global var cbURL
Line 51: insert "&redirect_uri=" + cbURL +

I still run in to trouble...
I am not a coder so my apologies if you think I'm a noob :)
responce: /oauth2/auth/callback?error=temporarily_unavailable&error_description=Internal+backend+service+currently+not+available
I have edited the file home-connect-auth.js
location: /usr/lib/node_modules/node-red-contrib-homeconnect/src/
declared a variable at row 1: var cbURL;
also tried with let cbURL;
this the line 33 code:
let callbackUrl = protocol + '//' + hostname + (port ? ':' + port : '')
+ '/oauth2/auth/callback';
        var cbURL = callbackUrl;

line 51 code:
            body: 'client_id=' + n.client_id +
                '&client_secret=' + n.client_secret +
                '&redirect_uri=' + cbURL +
                '&grant_type=authorization_code&code=' + authCode

I sorted it out...
let cbURL; at line 4
var cbURL = callbackUrl; --> cbURL = callbackUrl at line 34...
Thank You for all help Jodameister!

Callback URL was added in 8b8b634d


[feature-request]download single offline html in try-it-out

The downloaded standalone html can be opened in an air-gapped environment without Interent Access

Currently when I embed all assets, got error:
404
File not found
The site configured at this address does not contain the requested file.
If this is your site, make sure that the filename case matches the URL.
For root URLs (like http://example.com/) you must provide an index.html file.

Sorry, can you elaborate what you have done? What do you mean by "embed all assets" and got 404?
AFAICT there is no way to download an offline HTML with all assets embedded for now since the plugins still depends on CDN.

Closing as duplicate of #147

Cool Gera2ld, fix it!!!


Cop idea: merge .first || .create! into .first_or_create!

# bad
def method
  users.where(name: name).first ||
    users.where(name: name).create!
end

# bad
def method
  users.where(name: name).first ||
    users.create!(name: name)
end

# good
def method
  users.where(name: name).first_or_create!
end

And for similar methods like find_or_create_by, find_or_create_by!, find_or_initialize_by, first_or_create, first_or_create!, first_or_initialize, create_or_find_by and create_or_find_by!

This is a matter of style. Before deciding, let's discuss it in the style guide.


Please bring back compatibility with iPhone 12 Pro Max iOS 16.4

Last version that works for me is 2.5.1 ...
Every version > 2.5.1 crashes the system on kopen.

3.3.1 is still useless for iPhone 12 Pro Max
Keep waiting


Create task for adding Acquisitions Method (Lotus)

Values that need to be added are here -https://drive.google.com/drive/folders/1hrXK5nNDE7xTNHbvCs7KW-UheMyn_0uF acquisitions/acquisitions-methods.tsv
@shelleydoljack does it need a Source value?
Blocked by #4 ?

Actually, this ticket blocks #4 since we cannot create orders that use acquisitions methods that we haven't created yet. For source value, only User and System are accepted values so I think we'll use "User" since "System" seems to be for the default reference data.


uint --> int

https://solidity.readthedocs.io/en/v0.5.13/types.html confirms int is the proper alias of int256

Thank you for fix. Closing this since there was another PR with same fix.


[oadp-1.2] [OADP-2959] Add missing descriptions to all CRDs (#1200)

Adds missing descriptions to the following CRDs:

DataDownload
DataUpload
VolumeSnapshotBackup
VolumeSnapshotRestore
CloudStorage

/lgtm

/retest

DataUpload and DataDownLoad do not exist in 1.2 branch


Add dm_control speed test script and single env performance benchmark

The initial result shows we have at least 2x speedup than dm_control with only a single env. Pending integrating mujoco from source code (just release 8h ago).

test dm_control single env performance on workstation with following specs:
12 core (24-thread) Intel(R) Core(TM) i9-10920X CPU @ 3.50GHz
EnvPool Speedup: 1.43x


feat(aks linux): add FIPS-enanbled Mariner AKS image

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add FIPS-enabled Mariner AKS image
Which issue(s) this PR fixes:

Fixes #
Requirements:

[X] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Mariner Pipeline build result: https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=70539142&view=results
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 79.625%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
2036

Relevant Lines:
2557

💛  - Coveralls


Prevent hangs due to bad import/export directives

If the input test script contains a bad import, sky_shell will fail to
execute main(), in which case a connection to /runner is never
established and the _ServerInfo.socket never completes.
This change works around this by issuing a request on /shutdown when
sky_shell exits.

LGTM

LGTM


all.sh on Travis CI

Run all.sh on Travis CI.
Status
IN DEVELOPMENT
Requires Backporting
Yes, 2.16 and 2.7
Migrations
NO
Todos

[ ] Tests
[ ] Documentation
[ ] Changelog updated
[ ] Backported

Closing this as all.sh was added to .travis.yml in PR #3218


NPM/BUILD: compile to es5 for npm

Change target branch for #162
This pull requests add npm prebublish script which will compile it to es5 before publishing it to npm as
npm packages are usually expected to be by valid es5.
Example use case:
I was making React app and I used most popular setup for it.
require modules with npm, bundle with webpack and babel, but excluding node_modules from babel for efficiency.
My bundle ended up with template strings and arrow functions, which gave syntax error in OBS or IE.
Now I make an exception for tmi.js in my webpack config, but it would be better if other people didn't have too.

I don't know how @Schmoopiie feels about this, but could you squash these into a single commit?

I am new to github.
I squashed my commits with git rebasee, but it doesn't look very squashed.
What am I dong wrong?

It looks like you did a regular pull/merge after the squash, so the old changes are still there.

Thanks!
apparently the -f  option on push was the thing I was missing.
FeelsGoodMan


Add flake8 plugins to python.yaml

Package name:

python3-flake8-blind-except-pip
python3-flake8-builtins-pip
python3-flake8-class-newline-pip
python3-flake8-comprehensions-pip
python3-flake8-deprecated-pip
python3-flake8-docstrings-pip
python3-flake8-import-order-pip
python3-flake8-quotes-pip

Package Upstream Source:

https://github.com/elijahandrews/flake8-blind-except
https://github.com/gforcada/flake8-builtins
https://github.com/AlexanderVanEck/flake8-class-newline
https://github.com/adamchainz/flake8-comprehensions
https://github.com/gforcada/flake8-deprecated
https://gitlab.com/pycqa/flake8-docstrings
https://github.com/PyCQA/flake8-import-order
https://github.com/zheller/flake8-quotes/

Purpose of using this:
As I wrote in https://github.com/osrf/docker_images/issues/531, it would be nice to make installing flake8 plugins possible with rosdep.
These plugins are what listed here.
If we don't install these plugins, it causes differences in colcon test.
Currently, we have to install them manually in CI scripts, but it's useful if we can use rosdep.
Links to Distribution Packages

https://pypi.org/project/flake8-blind-except/
https://pypi.org/project/flake8-builtins/
https://pypi.org/project/flake8-class-newline/
https://pypi.org/project/flake8-comprehensions/
https://pypi.org/project/flake8-deprecated/
https://pypi.org/project/flake8-docstrings/
https://pypi.org/project/flake8-import-order/
https://pypi.org/project/flake8-quotes/

Another thought towards reducing the amount of install instructions, an ament_flake8_ros package could perhaps help.

Thank you for your comments.
I agree with the idea of ament_flake8_ros.
I'd like to add flake8 plugins to rosdep so that someone can create ament_flake8_ros and that it can depend on flake8 plugins.


PieChart set stroke color

There should be a way to set color of stroke lines between pie slices. Currently is it only white by default and cannot be changed.

I assume you're referring to https://github.com/google/charts
Please raise your issue there.
Feel free to add a comment to have the issue reopened if I misinterpreted your request.


Create AI

Description of the change

Motivation

Type of change
Choose one: (Bug fix | Feature request | Documentation | Other)
Checklist

[x] I have performed a self-review of my code.
[x] I have added detailed comments to my code where applicable.
[x] I have verified that my change does not break existing code.
[x] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
[x] I am familiar with the Google Style Guide for the language I have coded in.
[x] I have read through the Contributing Guide and signed the Contributor License Agreement.

I think this PR may have been an error?


OSISM 7.0.6

https://github.com/osism/issues/issues/964

https://github.com/osism/container-image-kolla-ansible/pull/635

https://github.com/osism/issues/issues/921

https://github.com/osism/issues/issues/722

New docs about useful OVN/OVS commands: https://osism.tech/docs/guides/operations-guide/network

https://github.com/osism/container-images-kolla/pull/452

https://github.com/osism/ansible-collection-commons/pull/658

https://github.com/osism/ansible-collection-services/pull/1456

https://github.com/osism/ansible-collection-services/pull/1453

https://github.com/osism/ansible-collection-commons/pull/657

https://github.com/osism/ansible-collection-services/pull/1446

https://github.com/osism/issues/issues/1039

New features: It‘s now possible to lock the configuration repository or to lock a specific environment by adding an empty .lock file in the environments directory or in one of the environments/X directories.

https://github.com/osism/python-osism/pull/921

Rebuild & upgrade the following services:

[ ] nova (spicehtml5proxy)
[ ] octavia (bugfix in the ovn provider)
[ ] ovn (new version v24.03.2)

https://github.com/osism/container-images-kolla/pull/456

https://github.com/osism/issues/issues/1052

https://github.com/osism/ansible-collection-services/pull/1482

https://github.com/osism/defaults/pull/184

https://github.com/osism/ansible-playbooks/pull/438
https://github.com/osism/ansible-playbooks/pull/437

https://github.com/osism/ansible-collection-services/pull/1493

Technical preview of Rook

https://github.com/osism/container-images-kolla/pull/462

https://github.com/osism/container-images-kolla/pull/463

Release depends on upstream backport to stable of https://review.opendev.org/c/openstack/nova/+/923533

https://security.openstack.org/ossa/OSSA-2024-001.html

https://github.com/osism/container-images-kolla/commit/d163178a41e9948d6de84739a4eafe989259dbe5

New manager service: Kubernetes (can be enabled with enable_osism_kubernetes in environments/manager/configuration.yml)


Error at first install

I've started new ionic2 project with

ionic start [app-name] --v2
The version is ionic2 rc3 with app-scripts 0.0.45
install the ionic-module-template
add it to imports
run ionic:serve
Got the error
\C:\Repos\ionic2rc3\node_modules@angular\compiler\src\metadata_resolver.js:241 Uncaught Error: Unexpected value 'MyModule' imported by the module 'AppModule'(…)

so after upgrading to app-script 0.0.46 it works

So ionic:serve works but "ionic build android" throw an error

[10:17:22]  ionic-app-scripts 0.0.46
[10:17:22]  build prod started ...
[10:17:22]  clean started ...
[10:17:22]  clean finished in 8 ms
[10:17:22]  copy started ...
[10:17:22]  ngc started ...
[10:17:22]  copy: Error copying "C:\Repos\ionic2rc3\node_modules\ionic-angular\fonts" to
"C:\Repos\ionic2rc3\www\assets\fonts"
[10:17:22]  copy finished in 176 ms
[10:17:24]  Error: Metadata version mismatch for module C:/Repos/ionic2rc3/node_modules/stms-lib/my-module.module.d.
ts,
found version 2, expected 1
[10:17:24]  ngc failed
[10:17:24]  ionic-app-script task: "build"
[10:17:24]  Error: Error

So it works , I needed to delete the platform folder after updating to app-scripts 0.0.46
this issue can be closed .


Update: Make Box.Application chainable (fixes #65)

Verified that @nzakas has signed the CLA. Thanks for the pull request!

lgtm +2


Separated pandas and numpy implementations of sklearn.

Pandas and numpy implementations of sklearn runinference handler are now separate implementations.
For example, of pandas will now call the runinference in this fashion.
beam.RunInference(SklearnModelHandlerPandas(model_uri='gs://project/my_pandas_sklearn_pipeline.pkl')

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: "addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment "fixes #" instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @robertwb R: @yeandy R: @TheNeuralBit

Should we remove the NOTE about backwards incompatibility on the numpy implementation?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

yeah, let's remove the notes about backwards compatability here and everywhere, since the whole point of this is to try and set our API as supported.

@ryanthompson591 indicated offfline that those tests (./gradlew :sdks:python:test-suites:direct:py37:inferencePostCommitIT) shouldn't be affected since they only run pytorch examples now. He also confirmed that lint, mypy, and yapf are happy. I will merge when GitHub Actions finishes

Yep fixed. I'm not sure why my link hooks don't verify import order.
On Mon, Jun 13, 2022, 2:53 PM Brian Hulette @.***>
wrote:

Lint PreCommit is running now and failed:
11:12:05  from apache_beam.ml.inference.base import PredictionResult
11:12:05  from apache_beam.ml.inference.base import RunInference
11:12:05  from apache_beam.ml.inference.sklearn_inference import ModelFileType
11:12:05 +from apache_beam.ml.inference.sklearn_inference import SklearnModelHandlerNumpy
11:12:05  from apache_beam.ml.inference.sklearn_inference import SklearnModelHandlerPandas
11:12:05 -from apache_beam.ml.inference.sklearn_inference import SklearnModelHandlerNumpy
11:12:05  from apache_beam.testing.test_pipeline import TestPipeline
11:12:05  from apache_beam.testing.util import assert_that
11:12:05  from apache_beam.testing.util import equal_to
—
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/21803#issuecomment-1154265522, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABS23CRJ4GTJBIBN3BQF2OLVO57SXANCNFSM5YOTLHWA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I can help trace the code so you know what to add to your hooks :)
The precommit runs the py37-lint tox config: https://github.com/apache/beam/blob/d2fb942b2ea113a845951452e6a6f60b938bd5ec/sdks/python/tox.ini#L107-L120
Which runs the run_pylint.sh script, which runs isort with this definition:
https://github.com/apache/beam/blob/d2fb942b2ea113a845951452e6a6f60b938bd5ec/sdks/python/scripts/run_pylint.sh#L109-L110


refactor(ES6): upgrade MergeDuplicateChunksPlugin to ES6

What kind of change does this PR introduce?
refactor, ES5 => ES6
Did you add tests for your changes?
All existing tests pass
If relevant, link to documentation update:
N/A
Summary
Upgrade the MergeDuplicateChunksPlugin to ES6
Does this PR introduce a breaking change?
No

Thank you thank you!!! 🙇🍾 🎉


not really an issue, more of a question

Hi Osvaldo,
I just got a Rocketbook and I'd like to customize its OCR.  I see that you developed an app to interact with Rocketbook- can I replace the off-the-shelf OCR used with Rocketbook or does it need to be a standalone app that passes data/files to Rocketbook app? thx.
-Joe W.

Hi, I think there was a misunderstanding. This is just the name of the application I learned in the course, it has nothing to do with Rocketbook