feat: enable azure pg connectivity

enhancing the credentials obj by a boolean value to be able to properly connect to a pg db running on azure.
also added tests for major connectivity scenarios (docker, btp, azure).

Thanks Volker, could you also add a changelog entry? Thanks!

done - not sure if i did it right though...put placeholders for semver and the release date 🤔

Thanks Volker, could you also add a changelog entry? Thanks!

done - not sure if i did it right though...put placeholders for semver and the release date 🤔

looks good to me. In the future, we could also open separate branches for the changelogs, i.e. changelog/sqlite|postgres|db-service - that way we won't get merge conflicts

we could also start enforcing commit msg formats. then generate a changelog from them. this is how we do it with wdi5 and it's working well.
I'll open a discussion and see what the others think about it.


Validation issue with +97335470144 ( )

Please read the "guidelines for contributing" (linked above) and fill in the template below.
Country/region affected (e.g., "US"):
Example number(s) affected ("+1<PHONE_NUMBER>"): +97335470144
The phone number range(s) to which the issue applies ("+1 555 555-XXXX"):
The type of the number(s) ("fixed-line", "mobile", "short code", etc.):
The cost, if applicable ("toll-free", "premium rate", "shared cost"):
Supporting evidence (for example, national numbering plan, announcement from mobile carrier, news article): IMPORTANT - anything posted here is made public. Read the guidelines first!
link to demo

This issue is duplicate of  #1166 and will be tracked there . Closing this issue here.


[Documentation Issue] table.fetch_data(max_results=100)

Page Name: bigquery-usage
Release: a1b8066
Please note, the following documentation appears to be incorrect.
https://googlecloudplatform.github.io/gcloud-python/latest/bigquery-usage.html
Get rows from a table’s data:
from gcloud import bigquery
>>> client = bigquery.Client()
>>> dataset = client.dataset('dataset_name')
>>> table = dataset.table(name='person_ages')
>>> rows, next_page_token = table.fetch_data(max_results=100)  # API request
>>> for row in rows:
...     for field, value in zip(table.schema, row):
...         do_something(field, value)

Specifically the following line of code returns 3 values.  It appears that total_rows is missing.
rows, next_page_token = table.fetch_data(max_results=100)  # API request

The documentation for table.fetch_data states the following:
returns: ``(row_data, total_rows, page_token)``, where ``row_data``
              is a list of tuples, one per result row, containing only
              the values;  ``total_rows`` is a count of the total number
              of rows in the table;  and ``page_token`` is an opaque

Thanks for reporting! Let me know if I missed anything in #1981.

Closed via #1833.


Review performance testing

Hello, I've written a small Python module https://github.com/ajgdls/EPICSPyClientPerformance to compare the performance of 6 Python based EPICS clients.  I have attempted to test each in a consistent way, and the README has some preliminary results for monitoring 1000 records at 10Hz for 1000 samples.
I would really appreciate it if this module owner would review EPICSPyClientPerformance test code for this client implementation to check that I'm actually testing in the correct and most efficient way.  I would be happy to make updates that shows an increase in performance for this client.
This testing is driven by Diamond Light Source, and on 1st December the tests will be re-run against latest PyPI versions and then published (probably tech-talk) for further discussion, so if anyone wants to push performance optimisations they will get picked up on that date.
Thanks for taking a look, looking forward to hearing from everyone.

A more vigorous test might be to fetch thousands of PVs simultaneously, though this may more depend on the behaviour of channel access than the library.  cothread can fetch tens of thousands of PVs in a few seconds with the following call:
values = caget(list_of_pvs)


Implemented #sorted_insert for Array using binary search.

I noticed there's no nice sorted_insert method for Array so I decided to make one. It's fairly simple and it uses the bsearch_index method to find where to put the provided object.
This is my first pull request so let me know if I missed anything or if you want me to add something more to the feature.

Fixed the things @RX14 wanted fixed

Thank you, but what's the use case of this method?

@asterite you have a pre-sorted array and want to insert something into the array in a manner to keep it sorted but it's much faster than just iterating and inserting.
Personally i've needed it to implement a scheduler, where I had a queue of about 150,000 work items which needed to be kept ordered by computed next run timestamp, but insert + sort was way way too slow.

What @RX14 said.
I have a cache which will grow to quite a large size and to not keep it sorted and search through the array is not really an option. What the method implements can be done manually but this just looks better and in my opinion makes the resulting code a bit more "crystal-esque" if that makes sense?
arr.sorted_insert(5)

looks better than
index = arr.bsearch_index(5)`
if index
  arr.insert(index, 5)
else
  arr.push(5)
end

Mmm... what if I to insert an item in a sorted fashion, but not insert it if it's there already?
I'm not convinced that this method is needed. You can just write those 3 lines, it's probably not something that you'll have to write all the time. Plus with that method in place one might be tempted to insert multiple values at once to have a sorted array, when it's faster to insert multiple items and then do a single sort.
Additionally, Ruby doesn't have this method. And I don't know if other languages provide a method such as this.

And finally, if you need to keep an array sorted, it's probably better to use another data structure like a heap.

Our library at work provides it. Also the C++ way is a bit really C++ but it is a one-liner at least vec.insert(std::upper_bound(vec.begin(), vec.end(), item), item); The operation is of logarithmic complexity on insertion which isn't that bad. If you don't know about a big set of data forehand to fill the array with, then you aren't losing that much. Primary use case is when collection grows over time compared to when you have a pre-defined set of data to process.
On using a Heap data structure, the most efficient implementation of a heap is done using adaptation of this on top of an array.

@asterite there are plenty of methods in Array which are "just a few lines". The point is that because this is named sorted_insert you know at a glance what the operation is doing, instead of having to work it out from the implementation. I really don't think that this usecase is that rare.

I would prefer to have an always ordered data structure, with insert = sorted_insert, find = bsearch_index, so I can't accidentially break the contract by using << on it. On the other hand, such data structure isn't hard to write and stdlib can live without it.

@RX14

Personally i've needed it to implement a scheduler, where I had a queue of about 150,000 work items which needed to be kept ordered by computed next run timestamp,

With 150,000 items sorted insertion could be also slow, if timestamp is a bit random (ie must be inserted close to beginning). And without optimised shift it will be a way slow to remove 'next to run'.
Such queue unavoidably must be implemented with heap. What about adding "#heapify" and "#heappop" methods? Python has great heapq module
For binary_insert to be relatively fast up to several thousand elements, there should be more progress in unification of array and Deque (#5148) :

insert_at should detect insertion is done near beginning of array, and then allocate room before @buffer, thus following insertion near beginning could be done by moving small number of elements to left, instead of moving almost whole array to right.
I used such technique once when I didn't what to use binary search tree, and I was sure array will not be larger than several dozen thousands of pointers.

Personally i've needed it to implement a scheduler, where I had a queue of about 150,000 work items which needed to be kept ordered by computed next run timestamp, but insert then sort was way way too slow.

The typical way to implement a scheduler is to use a priority queue and while a sorted array can substitute for one, you are very likely to get better performance by using other data structures.
@groogy You get O(n) cost for insertion this way which is waaay slow comparatively speaking. Yes, you find the spot in O(logn), but moving the entries out of place cost O(n). Sure, it is a somewhat fast O(n) due to memmove being fast, but it is still bad.
@rx14: See for example https://github.com/yxhuvud/pairing_heap/blob/master/src/priority_queue.cr for one that seems to have somewhat decent performance - you get O(1) for insertion and O(logn) for deletion. Which is about as good as you get.
Can we please not add convenience methods that give us bad performance?

It seems nobody feels strong enough to about this to push it further. The usecases this addresses seem good for a shard, providing usecase optimized data structures and/or usecase optimized extensions to stdlib data structures. Then when that shard proliferates we can revisit which parts of it might make sense for stdlib.


[Snyk] Security upgrade python from 3.7-alpine to 3.11.8-alpine

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 4 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

django/CVE-2018-14574/Dockerfile

We recommend upgrading to python:3.11.8-alpine, as this image has only 6 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Resource Exhaustion SNYK-ALPINE318-EXPAT-6241039
  614

CVE-2023-5363 SNYK-ALPINE318-OPENSSL-6032386
  614

CVE-2023-5363 SNYK-ALPINE318-OPENSSL-6032386
  614

Out-of-Bounds SNYK-ALPINE318-SQLITE-6179217
  614

Out-of-bounds Write SNYK-ALPINE318-BUSYBOX-6913411
  586

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Resource Exhaustion

Checkmarx One – Scan Summary & Details – 3bbc8ffd-d7a3-42b4-bd1a-354419d79b92
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Path_Traversal
/base/oracle-java/utils/list-versions.py: [57](https://github.com/TheRedHatter/vulhub/blob/snyk-fix-0df917b745c1fef541856faf429cef07//base/oracle-java/utils/list-versions.py# L57)
Attack Vector


already compiled files

could someone send me the already compilled files?

You need to compile them for yourself. Also you need to update the offsets and or patterns.


Added back/forward shortcuts and a loading spinner icon

details in commits

Thanks for your contribution. Here are some things that would be a real value...if you are interested/have some time.

find in the webpage...(and highlight all the found ones)
open in new window with right click...may be need to send the link details as console.log message..and call the browser-plus with the new link
scroll to increase or decrease font size..
may be a plugin system..so people can add their own handlers for the events rather than contributing to the main repo...

I was able to test did-start/stop-loading and they seemed to work fine for me. No problem, browser-plus is really cool and I'm glad to contribute where I can. Right now I'm on winter break so I have a few weeks of free time. I'll check out what I can do with the things you listed. And hey when you say find in a webpage and highlight all the found ones, what do you mean by ones?

ctrl+f -> find word on the web page..just like in chrome
you can register for the ctrl+f key binding and have a ui created for input box to get the word..being searched and highlight(background color) that word using jquery


Avoid indexing un-published entries

Fixes #390

Quick side not here:
When a entity was previously published and is now unpublished, it should be deleted in meilisearch right?

Can we add some testing use cases to cover this bug fix?

The testing is planned in a PR later. I'm looking for a good way to handle the fact that I have to mock a lot of different parts of the code. Meanwhile, these bugs are very problematic to the usage of the plugin so I would like to release them.
#64

@sargreal
Are you sure? It is an or.

entry still exists even after the santize. thus entry.publishedAt can be null.
sanitized.length proves that the entry has been removed.

Both conditions are almost redundant haha. We do access this part of the code in this case.

@sargreal
Are you sure? It is an or.
* `entry` still exists even after the santize. thus `entry.publishedAt` can be `null`.

* `sanitized.length` proves that the entry has been removed.

Both conditions are almost redundant haha. We do access this part of the code in this case.

Ah true, it definitely is a bit confusing but should work. As above it should probably be covered in some test cases though :D

@sargreal Absolutely, it is planned for very soon! It is very much the only file that is not covered in tests for the moment :(

bors merge


dapr github-runner's scale-rule-metadata option

az containerapp job create sample command of this page set scale-rule-metadata with github-runner=https://api.github.com option
--scale-rule-metadata "github-runner=https://api.github.com" "owner=$REPO_OWNER" "runnerScope=repo" "repos=$REPO_NAME" "targetWorkflowQueueLength=1"

On the other hand, Keda scaler side has githubAPIURL option.
https://keda.sh/docs/2.12/scalers/github-runner/#trigger-specification

So I think --scale-rule-metadata also needs to be specified as githubAPIURL, is this right？

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d8c68d33-dd18-9d7d-4078-a81ae750eb34
Version Independent ID: 393f6e78-939e-328f-681a-7306532e26fc
Content: Tutorial: Run GitHub Actions runners and Azure Pipelines agents with Azure Container Apps jobs
Content Source: articles/container-apps/tutorial-ci-cd-runners-jobs.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@georgeOsdDev
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for your feedback and your contribution to Azure docs.
Feedback for this repository is moving away from GitHub to a system specific to the Microsoft Learn platform. Issues for this repository will soon be disabled, and additional comments from GitHub will no longer be possible. However, we are now tracking and triaging this issue in the new feedback system.
To learn more about our feedback systems, please see Provide feedback for Microsoft Learn content.
#please-close


feat: PublicImmutable impl

Fixes #4757

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

#4758  👈
#4739
master

This stack of pull requests is managed by Graphite.

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 13752339 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
54,212
214,436
855,332

l1_rollup_calldata_gas
259,820
1,019,768
4,060,196

l1_rollup_execution_gas
354,006
1,139,216
4,281,597

l2_block_processing_time_in_ms
1,280
4,797 (+1%)
18,931

note_successful_decrypting_time_in_ms
211 (-3%)
608 (+1%)
2,168 (+1%)

note_trial_decrypting_time_in_ms
19.7 (-29%)
44.3 (+13%)
184 (-2%)

l2_block_building_time_in_ms
21,336
84,717
342,961

l2_block_rollup_simulation_time_in_ms
16,012
63,555
258,686

l2_block_public_tx_process_time_in_ms
5,297
21,083
84,024

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
16,778
32,342 (+1%)

note_history_successful_decrypting_time_in_ms
1,451 (+3%)
2,833 (+4%)

note_history_trial_decrypting_time_in_ms
190 (+17%)
254 (+12%)

node_database_size_in_bytes
18,698,320
36,061,264

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
334
44,664
27,457

private-kernel-ordering
214
45,777
14,627

base-rollup
1,741
175,344
933

root-rollup
83.2
4,192
825

private-kernel-inner
442
73,099
27,457

public-kernel-app-logic
274
32,254
25,379

merge-rollup
7.84 (+1%)
2,712
933

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,388
36,001

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes

tx_pxe_processing_time_ms
573
1,503

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
0.0290 (-1%)
654

@LHerskind I see what you mean. Code wise there is no difference between SharedImmutable and this. But no one will know to use sharedImmutable for public
Maybe if the maintenance cost becomes too high we can kill it?


[DOCS] Make C to c in the word Connects

Description
If you have already forked the repository, skip to step 3

Fork this repository
Create a branch named lowercase_c
Open the README.md file, make sure that you are opening the file in your fork
In line 2, replace the current content with the following content :

LinkFree connect audiences to all of your content with just one link. It is an open-source alternative to [Linktree](https://linktr.ee/) implemented in JavaScript.

Screenshots
No response
Additional information
This is a good first issue. Please leave this open to beginners and first-time contributors

why is C supposed to be a cap? neither is it starting a sentence nor a proper noun

why is C supposed to be a cap? neither is it starting a sentence nor a proper noun

🤔 I mentioned to make it lower case c

why is C supposed to be a cap? neither is it starting a sentence nor a proper noun

🤔 I have mentioned to make it lower case c

I thought that the code block you added was supposed to be edited 😅

I thought that the code block you added was supposed to be edited 😅

It's the other way around 😄

Please give feedback for PR. This is my first PR.

@prahladjshenoy Hey! I guess you haven't created a PR, but you have committed the changed to your fork
Do these following steps to create a PR 😄

Open the lowercase_c branch in your fork

You would see a button called contribute, click on that

Then fill in the details and create your first PR 🎉

@prahladjshenoy Hey! I guess you haven't created a PR, but you have committed the changed to your fork
Do these following steps to create a PR 😄

Open the lowercase_c branch in your fork
You would see a button called contribute, click on that

Then fill in the details and create your first PR 🎉

Wait there are 2 PRs already for this 😱

Wait there are 2 PRs already for this 😱
😨 They could have could that they are working on this issue by commenting here


uncorrect browser detection

Opera 11.50 version has user agent: Opera/9.80 (Windows NT 5.1; U; ru) Presto/2.9.168 Version/11.50
User Agent Library detect browser Opera and version 9.80. But current version at the end of user agent string.
It since Opera 10.00. Sorry for my English.

Downloading Opera 11.60 to check on this issue...


Interface support

My attempt to add Interfaces support 🎉
Interfaces work very similar to Unions except Interface implementations share Interface fields. Result of the query on the Interface field is polymorphic variant with all implementations of that Interface. There is also support for inline fragments which adds additional fields to specific implementation.
I would really like to discuss possible API improvements.
This is my first ever contribution in OCaml so probably I'm using a lot of established bad practices.
Generator for Interface decoder is a clone of the union with few things removed so there is probably a room for improvements.
This will allow reason-apollo to have Interfaces support. @Gregoirevda

Hello, thanks for the initiative! I think the code looks good so if this is your first foray into OCaml you've got a bright future :)
Let's use this as a starting point for a discussion on how GraphQL interfaces might be represented in OCaml. Interfaces are similar but a bit more complex than unions, and one of the reasons I've been hesitant to implement them.
The first question I have is regarding a convenient top-level representation. For example, if you have a query like:
things {
  id
  ... on Person {
    name
  }
  ... on Bot {
    hostname
  }
}

Wouldn't it be convenient if I could reach the id field without having to pattern match? I'd imagine this to be even more convenient the more fields the interface has.
Next up, overlapping fragments and interface selections. This is kind of a corner case, but should be explicitly denied by graphql_ppx if we can't deal with it, to avoid runtime errors. If you have an inline fragment on an interface inside an interface, you can potentially get "overlapping" results:
things {
  ... on ThingWithName {
    name
  }
  ... on ThingWithHeight {
    height
  }
}

If there's an object that implements both ThingWithName and ThingWithHeight, you'll get both name and height in the response. Additionally, __typename will be the name of the concrete object, not any of the interfaces named in the query.
Lastly, I think we need to consider interfaces "non-exhaustive" for lack of a better word. If an interface field returns a polymorphic variant, then adding a new object type that implements that interface will potentially break the frontend code. Strictly adding types or fields to an API is generally not considered a breaking change, so I'd suggest we do something similar to the \Nonexhaustive` union variant.

I'm sorry for writing wall of text just out of nowhere on this PR, these are some of the ideas and issues that I've been thinking of and talked to some other people to but never actually written down anywhere.
One alternative representation would be something along the lines of:
Js.t({ .
  id: string,
  asPerson: option(Js.t({ . name: string })),
  asBot: option(Js.t({ . hostname: string })),
})

Which unfortunately then makes it a bit more inconvenient to pattern match on the concrete implementation(s), but opens up for the potential of both asPerson and asBot being None if a new type is introduced.

Thank you for the exhaustive feedback ❤
I'm not 100% happy with current implementation because, as you mentioned, it's very hard to access common interface fields. For me very important is to have easy way to access shared fields as well as implementation specific fields.
Also thank you for pointing out multiple interfaces. I completely forgot about that case. It's corner case but we have to be compatible with GraphQL specification.
I was thinking about your idea to have asSomething fields and it's good direction. If we have records instead of Js.t and we group all common/shared fields then it would work really well. We can pattern match on it and access common fields easily. It's not that convenient as variant but would work. And it scales really bad. In one of the internal project's I have about 10 different fragments in one query and that object would be nightmare to pattern match. Rest operator on records (like, [head, ...tail] on lists) would help a lot but OCaml nor Reason doesn't have such concept (because of the explicit record type)
Let's use your query as an example:
things {
  id
  ... on Person {
    name
  }
  ... on Bot {
    hostname
  }
}

It would return something like this:
type t = {
  common: Js.t({. "id": int }),
  asPerson: option(Js.t({. "name": string })),
  asBot: option(Js.t({. "hostname": string })),
};

This way we can access common fields and pattern match on implementations.
Here's some usage:
let sayYourName = obj =>
  switch (obj) {
  | {common, asPerson: Some(asPerson), asBot: None} => asPerson##name
  | {common, asPerson: None, asBot: Some(asBot)} => asBot##hostname
  | _ => "Someone else"
  };

It also keeps us safe in case of schema changes as we have asSomething field only for implementations we care about, the type is "non-exhaustive". And it would support multiple interfaces as well.
Can't wait to hear your thoughts about it, if it's good direction and if we can implement it that way 🙂

That suggestion looks perfectly reasonable. Only thing to keep in mind is to figure out a reasonable/unique name for each record type that you generate, maybe the name of the type and a counter appended? Otherwise, I think this is a good direction.
As a minor comment - I don't know if it's a good idea or not - but I guess we could generate either:
type t = {
  common: Js.t({. "id": int }),
  asPerson: option(Js.t({. "name": string })),
  asBot: option(Js.t({. "hostname": string })),
};

or
type t = {
  common: Js.t({. "id": int }),
  asPerson: option(Js.t({. "id": int, "name": string })),
  asBot: option(Js.t({. "id": int, "hostname": string })),
};

so that the full result is available in all concrete implementations. This is a bit closer to what the query actually returns but also a bit more repetitive. Any thoughts?

I was thinking more about the record approach and I would be ok but only with 2-3 fragments. If we get more, the size of the case would be unmaintainable. But I'm still thinking if there is any chance to use variants for interfaces. I've created tests and implementation for that and updated the PR so you can check if yourself.
The idea is to generate variant but only for implementations you care about.
Let's use this schema as an example.
interface User {
  id: ID!
}

type AdminUser implements User {
  id: ID!
  name: String!
}

type AnonymousUser implements User {
  id: ID!
}

and this query
query {
  users {
    id
    ... on AdminUser {
      name
    }
  }
}

It will result in such type:
type t = [
  | `AdminUser(Js.t{. "id": string, "name": string}))
  | `User(Js.t({ "id": string }))
]

So we can handle cases where we care about specific implementation and cases where we want "any" implementation and only interface fields.
There is still problem with on InterfaceType when we get "overlapping" results. With the current implementation it would fallback to User case because we generate wildcard pattern match for any other implementation. I think we can do better but right now I'm missing how. Would like to know your opinion 🙂

To be honest I think we should deny interface selections, at least for now. I know we should be compatible with GraphQL spec but right now we don't have interfaces support at all and we don't support all of the spec. Adding support for them probably would be possible but would also break the feel of the API for majority of the use cases. I would really like to hear from the broader audience to see if folks are using it and if so, how much.  What do you think?

@mhallin Is there any way I can push this PR forward?

@mhallin What's required to merge this PR?

@baransu Sorry for the long delay.
I think this sounds like a reasonable first limitation. If we need to open this up later, we can migrate to it using directives.


Test for NPE when no active span, to accompany #2711

Signed-off-by: Gary Brown<EMAIL_ADDRESS>title: Test for NPE when no active span, related to #2711
Description:
Provide a test that reproduces the NPE when no active span (i.e. sampling false), and confirms the fix provided in #2711.
Risk Level: Low
Testing: this is the test
Docs Changes: none

Link to Data Plane PR]
if your PR involves documentation changes. Please write in N/A if there were no
documentation changes.

Release Notes: none

"hey, check our your broken tes-- oh wait"  :-P
Thanks for the test for the other PR :-)   Do you want to merge @mandarjog's fix here or @mandarjog would you prefer to add the test to your PR?

@alyssawilk I'm fine with @mandarjog adding the test to his PR.

Closing out as this was added to the now merged #2711. Thanks @objectiser !


Introducing Multi-threading

Introducing multi-threading to off-load React SSR to work threads.

Multi-threaded rendering available in production mode only.
Worker pooling is setup using resource-pooler
Transform hooks are no longer a function, but a path to import a function to use

I will leave comments on the diff discussing every important part for easier reviewing

I'm updating most dev dependencies to make the linter accept satisfies.


Fix texture memory leak

Change MaterialCacheData, MeshCacheData, and TextureCacheData to IDisposable
Add ImageCache array to RefCountedCacheData
Dont allow replacing arrays in RefCountedCacheData after construction to prevent leaks
Prevent recreation of TextureCacheData (leaking references to cloned textures)
Add debug asserts to texture reference setting to ensure no leaked references

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: rferrese:x: AdamMitchell-msYou have signed the CLA already but the status is still pending? Let us recheck it.


Powerwall 2 sensors

I have Just had a Tesla Powerwall 2 and solar fitted, the sensors show up and work fine but they do not get listed in the Energy dashboard.
Any help would be much appreciated

Did you go to Settings > Dashboards > Energy and add your Powerwall sensors there?

I have just finished putting a fresh install of Home Assistant and added the Tesla integration, then went to the devices and enabled them all, after that I went to the energy dashboard to add the sensors but sadly exactly as before the only one to show up was sensor.my_home_battery_remaining.

Unfortunately this custom integration doesn't create the necessary energy sensors for the energy dashboard.
The simplest path is to utilise the native Home Assistant powerwall integration, which does have the necessary energy sensors. You can install both integrations at the same time.
https://www.home-assistant.io/integrations/powerwall/

Thank you for your email, I'm new to this and really struggling to set it
up Fail to connect, should I ask for help on the View it on GitHub link you
sent? Many thanks
On Sun, 8 Oct 2023 at 22:06, Mark Purcell @.***> wrote:

Unfortunately this custom integration doesn't create the necessary energy
sensors for the energy dashboard.
The simplest path is to utilise the native Home Assistant powerwall
integration, which does have the necessary energy sensors. You can install
both integrations at the same time.
https://www.home-assistant.io/integrations/powerwall/
—
Reply to this email directly, view it on GitHub
https://github.com/alandtse/tesla/issues/716#issuecomment-1752161700,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG5FAMWVW5Q54WCIQ2BAFL3X6MIVRAVCNFSM6AAAAAA5APNBGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGE3DCNZQGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thank you for your email, I'm new to this and really struggling to set it up Fail to connect, should I ask for help on the View it on GitHub link you sent?

The community forums are the best place to seek this type of support. If you describe your setup issues there we can continue the conversation.
https://community.home-assistant.io/c/energy/57


failure to detect drift in created kubernetes resources

What happened?
Kubernetes Deployment created from provider-kubernetes object is not monitored for drift.
How can we reproduce it?
Create the following object:
apiVersion: kubernetes.crossplane.io/v1alpha1
kind: Object
metadata:
  name: whoami
  namespace: default
spec:
  forProvider:
    manifest:
      apiVersion: apps/v1
      kind: Deployment
      metadata:
        namespace: default
      spec:
        metadata:
          name: whoami
          namespace: default
        replicas: 2
        selector:
          matchLabels:
            app: whoami
        template:
          metadata:
            labels:
              app: whoami
          spec:
            containers:
            - name: whoami
              image: docker.io/containous/whoami:v1.5.0
  providerConfigRef:
    name: kubernetes-provider

Edit the created deployment with kubectl edit deployments.apps whoami updating spec.replicas: 3
Expected: deployment drift detected and updated back to spec.replicas: 2.
Actual: Deployment continues to have 3 pods.
Editing the object forProvider.manifest.spec.replicas: 4:
Expected: object drift detected and updated back to forProvider.manifest.spec.replicas: 2 and deployment and pods updated.
Actual: object replicas, deployment replicas and pod count remains at 4
Note that if the object is created using composition, it behaves as above on deployment edit, BUT then if the object is updated forProvider.manifest.spec.replicas: 4 then the drift of object is somehow detected, the replicas reset to 2 and the deployment and pod count similarly fixed up back to 2.
apiVersion: apiextensions.crossplane.io/v1
kind: CompositeResourceDefinition
metadata:
  name: xminapps.example.com
spec:
  group: example.com
  names:
    kind: XMinApp
    plural: xminapps
  claimNames:
    kind: MinAppClaim
    plural: minappclaims
  versions:
  - name: v1alpha1
    served: true
    referenceable: true
    schema:
      openAPIV3Schema:
        type: object
        properties:
          spec:
            type: object
            properties:
              id:
                type: string
              parameters:
                type: object
                properties:
                  imageName:
                    type: string
                  replicas:
                    type: integer
                    default: 1
                required:
                - imageName
            required:
            - id
            - parameters
---
apiVersion: apiextensions.crossplane.io/v1
kind: Composition
metadata:
  name: minapp
  labels:
    crossplane.io/xrd: xminapp.example.com
    provider: kubernetes
spec:
  compositeTypeRef:
    apiVersion: example.com/v1alpha1
    kind: XMinApp
  resources:
  - name: deployment
    base:
      apiVersion: kubernetes.crossplane.io/v1alpha1
      kind: Object
      spec:
        forProvider:
          manifest:
            apiVersion: apps/v1
            kind: Deployment
            metadata:
              namespace: default
            spec:
              replicas: 1
              template:
                spec:
                  containers:
                  - name: frontend
        providerConfigRef:
          name: kubernetes-provider
    patches:
    - fromFieldPath: spec.id
      toFieldPath: metadata.name
    - fromFieldPath: spec.id
      toFieldPath: spec.forProvider.manifest.metadata.name
    - fromFieldPath: spec.id
      toFieldPath: spec.forProvider.manifest.metadata.labels.app
    - fromFieldPath: spec.id
      toFieldPath: spec.forProvider.manifest.spec.selector.matchLabels.app
    - fromFieldPath: spec.id
      toFieldPath: spec.forProvider.manifest.spec.template.metadata.labels.app
    - fromFieldPath: spec.id
      toFieldPath: spec.forProvider.manifest.spec.template.spec.containers[0].name
    - fromFieldPath: spec.parameters.imageName
      toFieldPath: spec.forProvider.manifest.spec.template.spec.containers[0].image
    - fromFieldPath: spec.parameters.replicas
      toFieldPath: spec.forProvider.manifest.spec.replicas
---
apiVersion: example.com/v1alpha1
kind: MinAppClaim
metadata:
  name: my-whoami
spec:
  id: whoami
  parameters:
    imageName: docker.io/containous/whoami:v1.5.0
    replicas: 2

What environment did it happen in?
Crossplane version: v1.7.0 (helm install)
kubernetes version v1.22.5 (windows docker desktop kubernetes environment)
Win 10 21H2 (19044.1645)
accessing through through WSL2 Ubuntu 20.04.4 LTS (Focal Fossa)
using client kubectl v1.21.5

Update: I've looked into the source and see that the observation of the created manifest is by looking at the last-applied-configuration.
This means that it will not detect the update to the deployment with kubectl edit as given in the repro in my initial post, but if it's done with apply such as:
kubectl get deployments.apps whoami -oyaml | sed '0,/^  replicas/{s/^  replicas:.*/  replicas: 4/}' | kubectl apply -f -

It does get detected and reverts to 2 replicas as per the spec in the Object/XRD.
This seems like a bug that it will only detect drift where it's been done "nicely", is there a reason it can't be fixed to look at actual observed state rather than "last-applied-configuration"?

A small extra request due to my faultfinding - the "sync-period" (I've read the source help but still don't really get what that is) is output in the debug logs, could the "poll-interval" (drift detection rate) also be output for faultfinding?

@Kolossi you're right.
We are using last applied configuration since for some k8s resources, API Server fills some fields after you create the resource hence once you get it back you would always see it is different than what you want to apply. Service a good example of this behavior:
For example, you declare this:
apiVersion: v1
kind: Service
metadata:
  name: test
spec:
  ports:
  - name: https
    port: 443
    protocol: TCP
    targetPort: https
  selector:
    app.kubernetes.io/component: test
  type: ClusterIP

If you get it back after creation, you will get something like:
apiVersion: v1
kind: Service
metadata:
  name: test
spec:
  clusterIP: <IP_ADDRESS>
  clusterIPs:
  - <IP_ADDRESS>
  ipFamilies:
  - IPv4
  ipFamilyPolicy: SingleStack
  ports:
  - name: https
    port: 443
    protocol: TCP
    targetPort: https
  selector:
    app.kubernetes.io/component: test
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}

So, it is not straightforward to figure out the drift from the desired state without a workaround like last applied configuration.
The current implementation opts for simplicity by not introducing resource-specific and/or complex merging logic.
An ideal solution could be to leverage Server Side Apply  feature.

OK so I understand the logic of the choosing the simple (likely more because it was "easy") option grabbing last applied configuration.
But I don't feel like this is really doing drift detection as in-cluster hacks arent necessarily (likely) to use kubectl apply and play nice.
I feel like although complex merge logic would be ideal, a next level "easy" option is to look at the declared manifest, and only for those fields check whether there is a mismatch in the actual manifest.  The logic being if the field really wanted to be fixed, it "should" have been specified in the declared manifest, anything not in the declaration is essentially "wildcard" and anything should be allowed.
That shouldn't be too complicated to implement?

But yeah api equiv of kubectl-diff (rather than server side apply) might be a more comprehensive version - if anything has changed, reapply config from declared.

Could the resourceVersion of created/updated objects be tracked and used as an indicator of drift?

I wonder if using server-side apply could improve this. SSA will probably become the new default in kubectl eventually.


Width of line numbers in :hardcopy is hard coded

The width of the line numbers (when enabled) in :hardcopy appears to be hard
coded through #define PRINT_NUMBER_WIDTH 8 in the file structs.h. It would be
preferrable to have this setting available in printoptions.

When printing small, 1-page files with <=50 lines, reserving 6 character widths
for line numbers is IMHO excessive, and in some cases it causes long lines
below 80 characters to wrap with otherwise default settings.

Suggested solution:
Add a new option to printoptions named numberwidth, which takes a non-negative
integer as parameter, and use this to set the padding of line numbers when
printing through :hardcopy. Alternatively, make :hardcopy respect the existing
option :set numberwidth. The latter would be less preferable, because that
option is not intended to affect printing. Defaults should be set so it matches
current behavior.

While the suggested solution above resolves the issue, I'd like to make some
additional suggestions on how it could be improved.

Suggested improvement:
Add the possibility to supply the parameter * to the suggested numberwidth
option in popt, which would cause the line numbers in :hardcopy to fit the
largest line number. If the largest line number is 999, 3 character widths
would be reserved for line numbers.

Suggested improvement:
Add an option to printoptions to change the padding between the line number and
the line itself.

Suggested improvement:
Provide an option to have line numbers outside the margin. Some consider it
good typographic style to leave bullets and numbers of lists outside the margin.

Here's a visual example of the suggestion:
|        12345  |# This is a line of text
^ Edge          ^ Margin

As opposed to the current behavior, which would look like
|               | 12345  # This is a line of text
^ Edge          ^ Margin

I'd be willing to submit patches for individual parts of this report if I get
some pointers on where to start, or manage to find the necessary information
myself.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 3 Sep 2013 at 1:20

I would be happy to see this features! How is it going?

@chrisbra is this related to https://github.com/chrisbra/vim-mq-patches/blob/1177c4535380df983a2cb58720dbeeaee5d498fe/leftmargin?

no not at all. My patch was supposed to add an additional (empty) left margin. This might be needed to allow a better way for distraction free reading so that the actual text can be shifted to the right of the window.


Unresolved import 'rp2040_hal::pac::interrupt'

When i try to
use rp2040_hal::pac::interrupt;
I get the error that the interrupt module/macro is not found.
My cargo.toml looks like this
...

[dependencies]
rp2040-hal = "0.4"
cortex-m-rt = "0.7"
panic-halt = "0.2"
usbd-hid = "0.5.1"
usb-device = "0.2.8"

...

I can't use the #[interrupt] macro

You need to enable the rt feature to get this import from the PAC.
rp2040-hal = { version = "0.4", features = ["rt"]}

The project template is a good reference for this sort of info.

@Hellstormer00: Has this resolved your issue?

I verified that a missing rt feature gives an error message matching the report:
error[E0432]: unresolved import `hal::pac::interrupt`
  --> boards/rp-pico/examples/pico_pwm_audio.rs:16:5
   |
16 |     pac::interrupt,
   |     ^^^^^---------
   |     |    |
   |     |    help: a similar name exists in the module (notice the capitalization): `Interrupt`
   |     no `interrupt` in the root

Therefore I assume that the hint in https://github.com/rp-rs/rp-hal/issues/320#issuecomment-1079488648 was correct. Closing the ticket now, @Hellstormer00, feel free to reopen it in case I was wrong and your issue was caused by something else.


bower2nix 2.1.0 -> 3.0.1

This updates bower2nix and fetch-bower to fix some bugs (release notes).
There is a new buildBowerComponents function which wraps fetchBower and makes it easier to use in a project.
I have also written some documentation.
cc @shlevy @rbvermaa @svanderburg
Things done:

[X] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[X] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip --against master".
:question: Have run this, with a Result in /run/user/1000/nox-review-5mnpj70p. What is the expected output of nox-review?
[X] Fits CONTRIBUTING.md.

Why is bower2nix not just a normal node package?

Also, why are its inputs pegged by version instead of by spec respecting semver?

Hi @shlevy

bower2nix is not just a normal node package so that I can use wrapProgram to put git into the PATH. Actually the call to build with tsc isn't necessary so I can remove that.
Pegging by version seems to be what the other packages generated by npm2nix have, and it was easier to type.

Cheers

Hmm, so I'd personally prefer to have bower2nix as a normal node package (so its dependencies are automatically managed etc.) and then have an override in node-packages.nix to add a postInstall or similar, but it's not really a huge deal and I don't maintain the node stuff anymore. @offlinehacker , thoughts?

Thanks @shlevy I didn't notice that it was possible to override attributes of node packages. I have updated the patch so that bower2nix is a normal node package again.
As far as I can tell, there is no way to regenerate node-packages-generated.nix. So the changes to this file were "semi-automated".

It should be possible to update node-packages-generated with npm2nix, but unfortunately it's broken right now due to https://github.com/NixOS/npm2nix/issues/35.

Ah yes I mucked up the 2nd rebase. Are you able to fix it on master?


[TTS]libc.so.6: version `GLIBC_2.32' not found

For support and discussions, please use our Discourse forums.
If you've found a bug then please create an issue with the following information:
Describe the bug
A clear and concise description of what the bug is.
It gives out error: libc.so.6: version `GLIBC_2.32' not found
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
>>> from paddlespeech.cli.tts.infer import TTSExecutor
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/root/miniconda3/envs/tts_py39/lib/python3.9/site-packages/paddlespeech/cli/tts/__init__.py", line 14, in <module>
    from .infer import TTSExecutor
  File "/root/miniconda3/envs/tts_py39/lib/python3.9/site-packages/paddlespeech/cli/tts/infer.py", line 33, in <module>
    from paddlespeech.t2s.exps.syn_utils import get_am_inference
  File "/root/miniconda3/envs/tts_py39/lib/python3.9/site-packages/paddlespeech/t2s/exps/syn_utils.py", line 35, in <module>
    from paddlespeech.t2s.frontend.mix_frontend import MixFrontend
  File "/root/miniconda3/envs/tts_py39/lib/python3.9/site-packages/paddlespeech/t2s/frontend/mix_frontend.py", line 22, in <module>
    from paddlespeech.t2s.frontend.zh_frontend import Frontend
  File "/root/miniconda3/envs/tts_py39/lib/python3.9/site-packages/paddlespeech/t2s/frontend/zh_frontend.py", line 31, in <module>
    from paddlespeech.t2s.frontend.g2pw import G2PWOnnxConverter
  File "/root/miniconda3/envs/tts_py39/lib/python3.9/site-packages/paddlespeech/t2s/frontend/g2pw/__init__.py", line 1, in <module>
    from .onnx_api import G2PWOnnxConverter
  File "/root/miniconda3/envs/tts_py39/lib/python3.9/site-packages/paddlespeech/t2s/frontend/g2pw/onnx_api.py", line 27, in <module>
    from opencc import OpenCC
  File "/root/miniconda3/envs/tts_py39/lib/python3.9/site-packages/opencc/__init__.py", line 6, in <module>
    from opencc.clib import opencc_clib
ImportError: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /root/miniconda3/envs/tts_py39/lib/python3.9/site-packages/opencc/clib/opencc_clib.cpython-39-x86_64-linux-gnu.so)

Environment (please complete the following information):

OS: [e.g. Ubuntu]: ubuntu 20.04.6
GCC/G++ Version [e.g. 8.3] 9.4.0
Python Version [e.g. 3.7] 3.9
PaddlePaddle Version [e.g. 2.0.0] 2.5.1
Model Version [e.g. 2.0.0] 不确定
GPU/DRIVER Informationo [e.g. Tesla V100-SXM2-32GB/440.64.00] A40 / Driver Version: 530.30.02
CUDA/CUDNN Version [e.g. cuda-10.2] CUDA Version: 12.1
MKL Version
TensorRT Version

Additional context
Add any other context about the problem here.

Hello developer, thank you for your attention to the PaddleSpeech open-source project. We apologize for any inconvenience you may have encountered during development. For guidance, please refer to the following link:https://github.com/PaddlePaddle/PaddleSpeech/issues/3553


The question about global prompt.

Hello, my understanding is that the last configuration is for the global prompt, but I've noticed that the model doesn't seem to follow it when I use it. Am I misunderstanding something?

Yes that's what it is and it should work. Can you please provide the instructions you are trying to use?

I've found that it might be related to Gemini; the instructions are not being completely followed, and it's not a software issue.


fixed-start ignores min-range

Describe the bug
Fixed-start ignores min-range, also needs to disable select date before start date (it selects but not effecting) and not applying .dp__range_between class on hover.
      <VueDatePicker
        v-model="date"
        inline
        auto-apply
        range
        min-range="1"
        fixed-start
        hide-offset-dates
        multi-calendars
        :month-change-on-scroll="false"
        :transitions="false"
        :enable-time-picker="false"
        :min-date="new Date()"
      />

Fixed in 718ea724321057d834867dc01491c88c55209ce5 , will be included in the next version, missing #, adding a comment for reference.


Impossible Map - HP Drain

https://osu.ppy.sh/beatmapsets/975062#osu/2042323
Seems impossible on Special Diff due to high HP drain out of nowhere.

Just out of curiosity and maybe something that would help me test this further, have you noticed any other maps that have the same issue? and if so, can you please send a list of them here?

Just out of curiosity and maybe something that would help me test this further, have you noticed any other maps that have the same issue? and if so, can you please send a list of them here?

Hey,
im streaming this on Twitch very consistently and have maybe found one more on my last round.
I need to verify it tho.
I can definently make a list.
Best thing is if you or i can make a Stick Thread on the issues here with [Broken Maps] or smth :D

Hmm, I'm not sure what I could do to fix this.
I've played through the map myself (though in RX), and I was able to pass the map perfectly fine, though being on the edge of failure once or twice.
Another player was also able to pass the map (NM) and said that at most they came up to half HP. They've also noted that the map didn't feel terrible to play in tau.
I'll leave this issue open to any other players who want to note on any other maps that feel impossible to play.

If you have ever tried.
I suggest a Map like Mayday.
Seems not hittable after the first few Notes. They just refuse to work on me.
I can provide a Video later after work


Validations: descriptions & img-alt-text

Docs Build status updates of commit 8cc28a3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:bulb:Suggestion

Details

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:bulb:Suggestion

Details

Skype/SDN/articles/uri-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-qualityendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragent-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragenttype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/using-the-skype-for-business-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/via-element-startpropertiestype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/videolocalframelosspercentageavg-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverdevicedesc-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverversion-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-byeendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-endpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/SkypeURIs/SK_SkypeURIs.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AADS2S.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingCommonErrors.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md

Line 30, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 31, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 66, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 67, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 68, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md

Line 29, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 30, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 65, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 66, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 67, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 55fd3fc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:bulb:Suggestion

Details

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:bulb:Suggestion

Details

Skype/SDN/articles/uri-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-qualityendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragent-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragenttype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/using-the-skype-for-business-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/via-element-startpropertiestype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/videolocalframelosspercentageavg-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverdevicedesc-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverversion-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-byeendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-endpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/SkypeURIs/SK_SkypeURIs.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AADS2S.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingCommonErrors.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingJoin.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md

Line 30, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 31, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 66, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 67, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 68, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md

Line 29, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 30, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 65, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 66, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 67, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 48a853c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/uri-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-qualityendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragent-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragenttype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/using-the-skype-for-business-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/via-element-startpropertiestype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/videolocalframelosspercentageavg-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverdevicedesc-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverversion-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-byeendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-endpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/SkypeURIs/SK_SkypeURIs.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AADS2S.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingCommonErrors.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingJoin.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6f1e72c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/uri-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-qualityendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragent-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragenttype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/using-the-skype-for-business-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/via-element-startpropertiestype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/videolocalframelosspercentageavg-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverdevicedesc-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverversion-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-byeendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-endpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/SkypeURIs/SK_SkypeURIs.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AADS2S.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingCommonErrors.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingJoin.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d69f610:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/uri-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-qualityendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragent-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragenttype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/using-the-skype-for-business-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/via-element-startpropertiestype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/videolocalframelosspercentageavg-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverdevicedesc-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverversion-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-byeendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-endpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/SkypeURIs/SK_SkypeURIs.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AADS2S.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingCommonErrors.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingJoin.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f9cc2b0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/uri-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-qualityendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragent-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragenttype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/using-the-skype-for-business-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/via-element-startpropertiestype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/videolocalframelosspercentageavg-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverdevicedesc-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverversion-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-byeendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-endpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/SkypeURIs/SK_SkypeURIs.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AADS2S.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingCommonErrors.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingJoin.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@lindalu-MSFT
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!

Docs Build status updates of commit 5fcfd1a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/uri-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-qualityendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragent-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragenttype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/using-the-skype-for-business-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/via-element-startpropertiestype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/videolocalframelosspercentageavg-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverdevicedesc-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverversion-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-byeendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-endpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/SkypeURIs/SK_SkypeURIs.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AADS2S.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingCommonErrors.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingJoin.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit bae38e0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/uri-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/uri-element-qualityendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragent-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/useragenttype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/using-the-skype-for-business-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/vgaqualityratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/via-element-startpropertiestype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/videolocalframelosspercentageavg-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/videopacketlossrate-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/virtualization-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverdevicedesc-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wifidriverversion-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-byeendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-endpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-errorendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/wireless-element-inviteendpointtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/SkypeURIs/SK_SkypeURIs.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AADS2S.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingCommonErrors.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AnonymousMeetingJoin.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


realm: support setting priority of copy operations

... and then make use of it in Legion.

Same thing should apply to fills, dependent partition operations would be nice as well.


Remove FillFlushToLocalKCaches from DefaultPipeline

Description
Although this pass is disabled by default in the gtcpp backends, the pass causes issues when used with it. Therefore, it should be disabled from the default pipeline and added explicitly to gtc:cuda.

bors try


make build_pip_package work again on rpi3

make something like
bazel build --config opt --local_resources 1024.0,0.5,0.5 --cxxopt=-mfpu=neon-vfpv4 --cxxopt=-ftree-vectorize --cxxopt=-funsafe-math-optimizations --cxxopt=-ftree-loop-vectorize --cxxopt=-fomit-frame-pointer //tensorflow/tools/pip_package:build_pip_package

work.
When building tensorflow pip package natively on RPI 3 (yes, I know it's slow, not recommended), I saw error message like
ERROR: /home/pi/work/tensorflow/tensorflow/BUILD:589:1: Executing genrule //tensorflow:tensorflow_python_api_gen failed (Exit 1)
Traceback (most recent call last):
  File "/home/pi/.cache/bazel/_bazel_pi/fab1708ba000bf373adf42719f003e8e/execroot/org_tensorflow/bazel-out/host/bin/tensorflow/create_tensorflow.python_api.runfiles/org_tensorflow/tensorflow/python/tools/api/generator/create_python_api.py", line 27, in <module>
    from tensorflow.python.tools.api.generator import doc_srcs
  File "/home/pi/.cache/bazel/_bazel_pi/fab1708ba000bf373adf42719f003e8e/execroot/org_tensorflow/bazel-out/host/bin/tensorflow/create_tensorflow.python_api.runfiles/org_tensorflow/tensorflow/python/__init__.py", line 49, in <module>
    from tensorflow.python import pywrap_tensorflow
  File "/home/pi/.cache/bazel/_bazel_pi/fab1708ba000bf373adf42719f003e8e/execroot/org_tensorflow/bazel-out/host/bin/tensorflow/create_tensorflow.python_api.runfiles/org_tensorflow/tensorflow/python/pywrap_tensorflow.py", line 74, in <module>
    raise ImportError(msg)
ImportError: Traceback (most recent call last):
  File "/home/pi/.cache/bazel/_bazel_pi/fab1708ba000bf373adf42719f003e8e/execroot/org_tensorflow/bazel-out/host/bin/tensorflow/create_tensorflow.python_api.runfiles/org_tensorflow/tensorflow/python/pywrap_tensorflow.py", line 58, in <module>
    from tensorflow.python.pywrap_tensorflow_internal import *
  File "/home/pi/.cache/bazel/_bazel_pi/fab1708ba000bf373adf42719f003e8e/execroot/org_tensorflow/bazel-out/host/bin/tensorflow/create_tensorflow.python_api.runfiles/org_tensorflow/tensorflow/python/pywrap_tensorflow_internal.py", line 28, in <module>
    _pywrap_tensorflow_internal = swig_import_helper()
  File "/home/pi/.cache/bazel/_bazel_pi/fab1708ba000bf373adf42719f003e8e/execroot/org_tensorflow/bazel-out/host/bin/tensorflow/create_tensorflow.python_api.runfiles/org_tensorflow/tensorflow/python/pywrap_tensorflow_internal.py", line 24, in swig_import_helper
    _mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
ImportError: /home/pi/.cache/bazel/_bazel_pi/fab1708ba000bf373adf42719f003e8e/execroot/org_tensorflow/bazel-out/host/bin/tensorflow/create_tensorflow.python_api.runfiles/org_tensorflow/tensorflow/python/_pywrap_tensorflow_internal.so: undefined symbol: _ZN10tensorflow9ConcatCPUINS_8bfloat16EEEvPNS_10DeviceBaseERKSt6vectorISt10unique_ptrINS_6TTypesIT_Li2EiE11ConstMatrixESt14default_deleteIS9_EESaISC_EEPNS8_6MatrixE

Demangling with c++filt
$ c++filt _ZN10tensorflow9ConcatCPUINS_8bfloat16EEEvPNS_10DeviceBaseERKSt6vectorISt10unique_ptrINS_6TTypesIT_Li2EiE11ConstMatrixESt14default_deleteIS9_EESaISC_EEPNS8_6MatrixE
void tensorflow::ConcatCPU<tensorflow::bfloat16>(tensorflow::DeviceBase*, std::vector<std::unique_ptr<tensorflow::TTypes<tensorflow::bfloat16, 2, int>::ConstMatrix, std::default_delete<tensorflow::TTypes<tensorflow::bfloat16, 2, int>::ConstMatrix> >, std::allocator<std::unique_ptr<tensorflow::TTypes<tensorflow::bfloat16, 2, int>::ConstMatrix, std::default_delete<tensorflow::TTypes<tensorflow::bfloat16, 2, int>::ConstMatrix> > > > const&, tensorflow::TTypes<tensorflow::bfloat16, 2, int>::Matrix*)

we can see that we need instantiation for ConcatCPU<bfloat16>(.....).
Tested on Raspbian Jun-2018.

Nagging Assignee @caisq: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Looks like there are some presubmit errors, @freedomtan can you take a look?

@annarev I'll check. Didn't see why there are problems for such one-line change. It seems it's CI's problem.

@freedomtan, this is the error I see:
tensorflow/core/kernels/concat_lib_cpu.cc:69:44: error: duplicate explicit instantiation of 'void tensorflow::ConcatCPU(tensorflow::DeviceBase*, const std::vector<std::unique_ptr<typename tensorflow::TTypes<T, 2>::ConstMatrix> >&, typename tensorflow::TTypes<T, 2>::Matrix*) [with T = tensorflow::bfloat16; typename tensorflow::TTypes<T, 2>::ConstMatrix = Eigen::TensorMap<Eigen::Tensor<const tensorflow::bfloat16, 2, 1, long int>, 16, Eigen::MakePointer>; typename tensorflow::TTypes<T, 2>::Matrix = Eigen::TensorMap<Eigen::Tensor<tensorflow::bfloat16, 2, 1, long int>, 16, Eigen::MakePointer>]' [-fpermissive]
       typename TTypes<T, 2>::Matrix* output);
                                            ^

This is certainly caused by this PR.
Please take a look.

@gunan Thanks. I'll take a look and build on other platforms. It seems this instantiation problem is RPI 3 specific. If that's the case, I'll add #ifdef

@annarev and @gargn It seems I was trying to solve the wrong problem. Yes, #ifdef something will help build on both RPI 3 and other platforms. But adding something like --copt=-DRASPBERRY_PI will be able to build pip package w/o problem. Will verify this on RPI 3, if that's true I'll close this PR later. Building TensorFlow natively on RPI 3 is painfully slow.

@petewarden can correct me if I am wrong, but we are already cross-compiling our releases and deploying them on piwheels.

@gunan Yes, there are pip packages for python 2.7 and 3.4. However, the last time I tried to use TF Lite Python binding, I ran into problem. That's why I want to try build it natively.


Compton region uncertainty

Should come from statistics, not standard deviation. See discussion on calculations document.

The version in chris-development is almost correct now. There is a missing factor of sqrt(2) if you have both Compton regions, because net_area = gross_counts_peak - np.mean(compton_region).


Prevent click but not hover of highlighted area items

Describe the bug
A clear and concise description of what the bug is.
Im trying to make a tour in my app which has a lot of buttons in each step, I want the user to hover the buttons to know what they do when a tooltip is shown, but I dont want to let the user click the items, because they will trigger different actions.
I've tried disabling pointer events with CSS but any event is fired and this is not my need. I've tried also to trigger an off("click"), off() and unbind events inside the highlighted area when tour is started, but it neither  work:
onTourStart() {
                       setTimeout(() => {
				$(".v-tour__target--highlighted").off();
				$(".v-tour__target--highlighted").unbind();
				$(".v-tour__target--highlighted *").off();
				$(".v-tour__target--highlighted *").unbind();
			}, 1000)
}

Is there a way to achieve it?

There's no perfect solution for this, you have to write custom code when Tour is running.
It could be a mask around the highlighted element, where you disable any click on it with pointer-events: none.


Shovels

Could you possibly add shovels as they were removed from tinkers construct during the massive overhaul of the mod

I have very little interest in doing this. I know you've asked a couple times before. What is the fascination with shovels? It really isn't useful given there is the mattock, pickadze and excavator. I fail to see how it fits into any kind of gameplay. If you could explain some rationale for this, I might consider it. Given the long list of integrations already planned, this doesn't feel important at all without more information.

Do you have anymore feedback for this? I'm still confused about why the three options for shovels isn't sufficient. https://github.com/SlimeKnights/TinkersConstruct/issues/4885 covers the issue pretty well. I will close this if I don't see any more information.


Clearer output

Got this when running the tools the first time:
{
  "OutboundHTTP": {
    "OddPortConnection": "",
    "Port443Connection": ""
  },
  "Nat": {
    "Error": null,
    "MappedAddr": "/ip4/<IP_ADDRESS>/tcp/44196"
  },
  "HavePublicIP": false,
  "Response": {
    "SeenAddr": "/ip4/<IP_ADDRESS>/tcp/51330",
    "ConnectBackSuccess": false,
    "ConnectBackMsg": "dial attempt failed: \u003cpeer.ID Pah1CN\u003e --\u003e \u003cpeer.ID dBswWv\u003e dial attempt failed: connection refused",
    "ConnectBackAddr": "",
    "TriedAddrs": [
      "/ip4/<IP_ADDRESS>/tcp/43159",
      "/ip4/<IP_ADDRESS>/tcp/44196",
      "/ip4/<IP_ADDRESS>/tcp/43159"
    ]
  },
  "Request": {
    "PeerID": "QmdBswWvUBNpSq9QQktgHsEAokYCV5ePwybdBuFjoqgz53",
    "SeenGateway": "",
    "PortMapped": "/ip4/<IP_ADDRESS>/tcp/44196",
    "ListenAddr": "/ip4/<IP_ADDRESS>/tcp/43159"
  },
  "TcpReuseportWorking": false
}

Now I'm unsure, does NAT have issues in this case or not? Based on the dial attempt failed, maybe. Based on that I don't get the your routers upnp/NAT-PMP port mapping works! message, probably. But there is nothing explicitly telling me there is a problem.

@VictorBjelkholm yeah, i havent done any inference on the NAT situation based on the diagnostics output yet.


Add cross-vendor Vulkan/OpenCL interop sample

We already have a Vulkan/OpenCL interop sample, but that's vendor-specific to ARM and only works on Windows. With the recently released OpenCL cross-vendor extensions cl_khr_external_memory and cl_khr_external_semaphore it's now possible to do vendor-neutral Vulkan/OpenCL interop. Having a sample that makes use of it would be a great fit for our repo.

Hi, you set
cl_img_desc.image_slice_pitch = cl_img_desc.image_row_pitch * cl_img_desc.image_height;
with image_row_pitch not set (0), which implies optimal tiling in OpenCl, far as I know.
So it seems the image tiling both in Vulkan and OpenCL are the same, but not within spec.
I didn't have time to go through the whole conversation:

Can you elaborate? I do all of this in my spare time, and that conversation you linked look like it's a lot to read and follow. Is this a problem with the sample? If so, how does it need to be addressed?

Why do you set image_slice_pitch, which is used for 2d image arrays?
I'm not an expert either, but I gathered that the image tiling/swizzling format has to be the same between the 2 APIs.
If you set the image pitch to 0, the only meaningful assumption is that it is an optimal (nonlinear) format.
Conversely, if the image has a pitch specified, it has to be linear.
In the sample, the image is allocated as VK_IMAGE_TILING_OPTIMAL. OpenCl also, with image_row_pitch being 0, assumes optimal tiling. My assumption is that it is not specified that OpenCL and Vulkan use the same image tiling, as 'optimal tiling' just subsumes all optimal implementation tilings. With the sample working, they're obviously the same, but this might be coincidence (or do OpenCL/Vulkan implementations from the same vendor always use the same optimal tiling?).

So the issue is unresolved:
[https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#_issues_2]
You could use linear tiling, but that would probably be slower.

I can ask Nvidia/Intel. Maybe they can give any guarantees on their driver combinations.