Any usage with Mapbox

Hello,
Thank you for your lib that I use as a snippet for Mapbox.
But I'm facing a wrong (or unwanted) behavior while panning the map.
With MapLibre, while panning the map, every feature of OpenLayers are following and are synchronized with MapLibre.
However, with Mapbox, is not true. There is a delay that makes the map still smooth but unsynchronized.
I would like to know if you, here, have a solution already?
A solution that forces features, tiles and so to follow each other.
I tested by overriding the panning function of Mapbox, but without success.
Here, you can find what I use (from your lib) :
import Layer from 'ol/layer/Layer';
import { toDegrees } from 'ol/math';
import { toLonLat } from 'ol/proj';
import mapbox from 'mapbox-gl';
import type { FrameState } from 'ol/Map';
import type { Options as LayerOptions } from 'ol/layer/Layer';
import 'mapbox-gl/dist/mapbox-gl.css';
import { sameSize } from './utils';

type MapBoxLayerOptions = LayerOptions & {
  mapboxOptions: Omit<mapbox.MapboxOptions, 'container'>;
};

/**
 * Display a Mapbox map as an OpenLayers layer.
 * Heavily inspired by : https://github.com/geoblocks/ol-maplibre-layer.
 * Few changes to "use as is" with Mapbox instead of MapLibre.
 */
export default class MapBoxLayer extends Layer {
  mapboxMap: mapbox.Map;

  constructor(options: MapBoxLayerOptions) {
    const { mapboxOptions, ...baseOptions } = options;

    super(baseOptions);

    const container = document.createElement('div');

    container.style.position = 'absolute';
    container.style.width = '100%';
    container.style.height = '100%';
    container.style.top = '0';
    container.style.left = '0';
    container.style.bottom = '0';

    this.mapboxMap = new mapbox.Map({
      attributionControl: false,
      interactive: false,
      trackResize: false,
      clickTolerance: 0,
      keyboard: false,
      pitchWithRotate: false,
      doubleClickZoom: false,
      dragPan: false,
      dragRotate: false,
      touchZoomRotate: false,
      touchPitch: false,
      boxZoom: false,
      renderWorldCopies: false,
      preserveDrawingBuffer: false,
      antialias: false,
      fadeDuration: 300,
      optimizeForTerrain: true,
      crossSourceCollisions: false,
      ...mapboxOptions,
      container,
    });

    this.applyOpacity();
  }

  override disposeInternal() {
    this.mapboxMap.remove();
    super.disposeInternal();
  }

  override setOpacity(opacity: number) {
    super.setOpacity(opacity);
    this.applyOpacity();
  }

  private applyOpacity() {
    const canvas = this.mapboxMap.getCanvas();
    const opacity = this.getOpacity().toString();

    if (opacity !== canvas.style.opacity) {
      canvas.style.opacity = opacity;
    }
  }

  override render(frameState: FrameState): HTMLElement {
    const { viewState } = frameState;

    this.mapboxMap.jumpTo({
      center: toLonLat(viewState.center) as [number, number],
      zoom: viewState.zoom - 1,
      bearing: toDegrees(-viewState.rotation),
    });

    const mapboxCanvas = this.mapboxMap.getCanvas();

    if (!mapboxCanvas.isConnected) {
      this.getMapInternal()?.render();
    } else if (!sameSize(mapboxCanvas, frameState)) {
      this.mapboxMap.resize();
    }

    this.mapboxMap.triggerRepaint();

    return this.mapboxMap.getContainer();
  }
}

Thank you for your lib!

Hi @erwanlpfr, the reason for this delay is that the jumpTo function is asynchronous and there's no clean way to have it  synchronous. See this issue in mapbox-gl-js https://github.com/mapbox/mapbox-gl-js/issues/7893
You can use private properties and functions to make it synchronous, see this example in OpenLayers: https://github.com/openlayers/openlayers/blob/main/examples/mapbox-layer.js#L50-L57


Move split tab navigation explainer to public repo

This PR is moving the split tab navigation explainer to public repo.

Just a quick stop-by comment: was it considered that in the future there could be more than two split tabs in a browser tab? At the moment, the baseline assumption seems to be that there are at most two. I can well imagine that browsers would innovate more, and, for example, on wide screens allow a tab to be split in n split tabs.

Currently, since we don't have a use case for >2-way split, the proposal doesn't handle this explicitly. However, I think the proposal could be extended to handle that in the future. Ex. We could introduce a second attribute that allows takes a tab number/id, something like <a target='_split' split-tab-index='3'>. For now, we can track this as an open issue.


Starts to lag after editor-widget with large content pops up

VSCode Version: 1.22.2
OS Version: macOS Sierra 10.12.6

Steps to Reproduce:

I am using JSS (9.0.0) in the screenshot example.
When adding a comma at the end of the line, within the createStyleSheet call, an element with the class name editor-widget pops up. The content of the box is 10001 characters long. It seems to be cut of after that, ending with "revert" | "unset…. Let me know if you want me to paste the content.

In the screenshot, the cursor start to lag when I navigate back and forth. Same when I navigate between editors.
Does this issue occur when all extensions are disabled?: Yes

I wanted to add that if I close the widget, the lag remains going between editors, but the cursor lag seems to go away.
I also tested setting the end variable to 500 and that removed the lag: https://github.com/Microsoft/vscode/blob/master/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts#L394

This issue was moved to Microsoft/TypeScript#23453


Ruby 3!

Upped some numbers! nbd
This pull request makes the following changes:

Upgrades Ruby

It relates to the following issue #s:

Fixes #2255

For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:

feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.

If it contains neither, no need to tag this PR.

docker builds perfectly! (both clean repo and existing repo on the branch) will spend some time going through the workflows but nothing pops out yet!


chore(Workspaces): Add a slug on the workspace and adapt all the components

Update graphql schema to have the new workspace slug used as an ID.

There are failing tests


Cannot resolve method 'getLatestVersion' in 'GoogleAdsClient'

Hey all,
I cloned the basic google-ads-java project to my IDE.(https://github.com/googleads/google-ads-java).
Everything is good excepte for the method
googleAdsClient.getLatestVersion()
which is not recognized. (screenshot is attached)
I changed the java version from 11 => 1.8 , I refreshed my maven configs, and nothing....

Have anyone got this error or knows how to check/solve?
Best,
Nir

Most likely this is because the IDE isn't running our annotation processors. There should be a setting to enable this somewhere, e.g. intellij places this near the compiler settings for the project. Can you confirm?

Hey,
Im not sure what do i need to look for in intellij.
Can you be more specific in the setting location? :)
בתאריך יום ו׳, 18 בספט׳ 2020, 12:36, מאת Nick Birnie <
<EMAIL_ADDRESS>
Most likely this is because the IDE isn't running our annotation
processors. There should be a setting to enable this somewhere, e.g.
intellij places this near the compiler settings for the project. Can you
confirm?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-694765043,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6QPBHN5GQTI5TUTJVLSGMSYXANCNFSM4RRPYBEA
.

Oh yes, sorry I should have included a screenshot. This is Intellij, File -> Settings -> Build, Execution, Development -> Compiler -> Annotation Processing.

Well, I checked up that checkbox, built again the project,
and got this errosmsg:

Error:java: Bad service configuration file, or exception thrown while constructing Processor object: javax.annotation.processing.Processor: Provider com.google.ads.googleads.annotations.api.GoogleAdsCatalogAnnotationProcessor not found
Any ideas?

Hmm, I think I've seen that one before, IIRC it's IntelliJ getting confused. I'd suggest doing:

Reimport maven project

View -> Tool windows -> Maven, then click the two arrows pointing at each other.

Generate sources

From Maven window, right click the main client library project -> Generate sources and update folders.

Rebuild project

Build -> Rebuild

Restart IntelliJ

You can try compiling again after each of these steps, pretty sure one of them should do the trick.

hmm i did that
tried for both java 1.8/ java 11.0.5
now I get something similar
Error:java: Bad service configuration file, or exception thrown while
constructing Processor object: javax.annotation.processing.Processor:
Provider
com.google.ads.googleads.annotations.api.GoogleAdsCatalogAnnotationProcessor
not found
On Fri, Sep 18, 2020 at 5:18 PM Nick Birnie<EMAIL_ADDRESS>wrote:

Hmm, I think I've seen that one before, IIRC it's IntelliJ getting
confused. I'd suggest doing:

Reimport maven project

View -> Tool windows -> Maven, then click the two arrows pointing
at each other.

Generate sources

From Maven window, right click the main client library project ->
Generate sources and update folders.

Rebuild project

Build -> Rebuild

Restart IntelliJ

You can try compiling again after each of these steps, pretty sure one of
them should do the trick.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-694895907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6UBTAVPY3KW2NFH5NLSGNT3PANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

Can you open File -> Project Structure and verify that you have the dependency configuration correct? Is there any project that's highlighted in red?

Also, a work around for this is likely to be to run mvn clean install from the command line. We use @AutoService to generate the service provider for the annotation processor. I'm guessing that IntelliJ isn't running that.

Hey Nick,
I ran all the above. IntelliJ runs but then got out of memory exception.
I tried to increase the heap size, but IntelliJ is parsing java forever :/
I tried to build my own project based on the google-ads dependency, so now
it's smaller
and is built successfully!!
Now my issue is that:
[image: image.png]
the ads.properties file is not found. I searched for it in the original
project, but without any success.
Any suggestions?
On Fri, Sep 18, 2020 at 5:48 PM Nick Birnie<EMAIL_ADDRESS>wrote:

Also, a work around for this is likely to be to run mvn clean install
from the command line. We use AutoService to generate the service provider
for the annotation processor. I'm guessing that IntelliJ isn't running that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-694912938,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6XROFSZLYHRTHP36SLSGNXLXANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

Hey Nick, how are you?
Hope you had a good weekend
Do you have any idea how to progress here?
Thanks in advance
Nir
On Sat, Sep 19, 2020 at 2:39 PM Nir Krumer<EMAIL_ADDRESS>wrote:

Hey Nick,
I ran all the above. IntelliJ runs but then got out of memory exception.
I tried to increase the heap size, but IntelliJ is parsing java forever :/
I tried to build my own project based on the google-ads dependency, so now
it's smaller
and is built successfully!!
Now my issue is that:
[image: image.png]
the ads.properties file is not found. I searched for it in the original
project, but without any success.
Any suggestions?
On Fri, Sep 18, 2020 at 5:48 PM Nick Birnie<EMAIL_ADDRESS>wrote:

Also, a work around for this is likely to be to run mvn clean install
from the command line. We use AutoService to generate the service provider
for the annotation processor. I'm guessing that IntelliJ isn't running that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-694912938,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6XROFSZLYHRTHP36SLSGNXLXANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

Hey, I've added a sample configuration file https://github.com/googleads/google-ads-java/pull/341.
You can also generate a configuration file by running one of the authentication examples here. However I realize that this isn't always the best workflow (e.g. if you already have credentials).
I have a heap size in IntelliJ of 5GB (for importer and compiler) and this is generally sufficient. I know that the compilation is slow, it generally takes about 10 or 20 minutes to compile from a cold start. We're discussing options for how to improve velocity here.
Have you considered using the library via Maven? This would avoid having to compile anything...

Hey Nick, thanks for that.

Do I need to put that file in the project's root folder?
I have the 5 keys:

[image: image.png]
What should I put in the endpoint?
(let's say I most interested in the google ads billing API)

If I have 2 different google ad accounts, how do I use that
ads.properties file in order to fetch data from both of them?

THANKS ALOT!
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On Mon, Sep 21, 2020 at 2:56 PM Nick Birnie<EMAIL_ADDRESS>wrote:

Hey, I've added a sample configuration file #341
https://github.com/googleads/google-ads-java/pull/341.
You can also generate a configuration file by running one of the
authentication examples here
https://github.com/googleads/google-ads-java/tree/master/google-ads-examples/src/main/java/com/google/ads/googleads/examples/authentication.
However I realize that this isn't always the best workflow (e.g. if you
already have credentials).
I have a heap size in IntelliJ of 5GB (for importer and compiler) and this
is generally sufficient. I know that the compilation is slow, it generally
takes about 10 or 20 minutes to compile from a cold start. We're discussing
options for how to improve velocity here.
Have you considered using the library via Maven? This would avoid having
to compile anything...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-696066604,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6UUPCJWH4ZBVBD4EJ3SG45M3ANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

The default path for the configuration file is ~/ads.properties. You can override this in code when constructing the client, e.g. GoogleAdsClient.newBuilder().fromPropertiesFile("/some/path").build().

Endpoint is not required. Please ignore this field.

You will need Google user credentials which have access to both accounts. This could be the same Google account, or two separate accounts. Then you generate a refresh token for the account(s) and use those credentials to call the API. Check out the OAuth guide for how to generate refresh tokens.

A little more context on 3. it's easier to access both accounts with the same set of credentials if you can. This means that you just need one refresh token and can simply put it in the configuration file. You can add users to an account via ads.google.com -> Tools & Settings -> Account access.
However, if you need two separate Google users to grant access the accounts, you'll need to either (a) have a separate configuration file for each user, and set the path to the config file as mentioned here https://github.com/googleads/google-ads-java/issues/339#issuecomment-696648223, or (b) configure the client programmatically, e.g. UserCredentials.newBuilder().setClientId().setClientSecret().setRefreshToken().

Alright
Thanks alot, Nick, for the patience
I will try that
On Tue, Sep 22, 2020 at 2:14 PM Nick Birnie<EMAIL_ADDRESS>wrote:

A little more context on 3. it's easier to access both accounts with the
same set of credentials if you can. This means that you just need one
refresh token and can simply put it in the configuration file. You can add
users to an account via ads.google.com -> Tools & Settings -> Account
access.
However, if you need two separate Google users to grant access the
accounts, you'll need to either (a) have a separate configuration file for
each user, and set the path to the config file as mentioned here #339
(comment)
https://github.com/googleads/google-ads-java/issues/339#issuecomment-696648223,
or (b) configure the client programmatically, e.g.
UserCredentials.newBuilder().setClientId().setClientSecret().setRefreshToken()
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-696655991,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6TLSSYZFZGVLZORXJTSHCBJ3ANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

BTW, maybe you can shorten my checks.
My final desired data is to get billing amounts grouped by campaign_id,
account_id and period.
Is that possible using the project ?
On Tue, Sep 22, 2020 at 2:30 PM Nir Krumer<EMAIL_ADDRESS>wrote:

Alright
Thanks alot, Nick, for the patience
I will try that
On Tue, Sep 22, 2020 at 2:14 PM Nick Birnie<EMAIL_ADDRESS>wrote:

A little more context on 3. it's easier to access both accounts with the
same set of credentials if you can. This means that you just need one
refresh token and can simply put it in the configuration file. You can add
users to an account via ads.google.com -> Tools & Settings -> Account
access.
However, if you need two separate Google users to grant access the
accounts, you'll need to either (a) have a separate configuration file for
each user, and set the path to the config file as mentioned here #339
(comment)
https://github.com/googleads/google-ads-java/issues/339#issuecomment-696648223,
or (b) configure the client programmatically, e.g.
UserCredentials.newBuilder().setClientId().setClientSecret().setRefreshToken()
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-696655991,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6TLSSYZFZGVLZORXJTSHCBJ3ANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

It's possible via the invoice service. This is only available to allowlisted accounts. I can file the request for you. If you'd like to do this, please send a request to<EMAIL_ADDRESS>with the following information:

Ask them to file an invoice API allowlist request.
How will you use this API ? For yourself or are you building a 3P Tool?
Developer Token
Sample CIDs for which you will pull invoices

By saying allowlisted accounts, u mean there is a procedure to go in order
to get the data ,right?
On top of that, i just want to make sure, could we fetch billing amounts by
campaign_id?
בתאריך יום ג׳, 22 בספט׳ 2020, 15:26, מאת Nick Birnie <
<EMAIL_ADDRESS>
It's possible via the invoice service
https://developers.google.com/google-ads/api/docs/billing/invoice-service?hl=en.
This is only available to allowlisted accounts. I can file the request for
you. If you'd like to do this, please send a request to
<EMAIL_ADDRESS>with the following information:

Ask them to file an invoice API allowlist request.
How will you use this API ? For yourself or are you building a 3P
Tool?
Developer Token
Sample CIDs for which you will pull invoices

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-696687772,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6T6TQYMVH3CERFEIO3SHCJY7ANCNFSM4RRPYBEA
.

Yes, the invoice service is not generally available and your developer token needs to be enabled to access the service.
Also it does not provide a breakdown by campaign - sorry I missed that point. The closest option would be to download the campaign stats for the period of the invoice. Here's a code example showing a basic retrieval option of campaign fields.
You could modify the query string something like: SELECT campaign.id, metrics.cost FROM campaign WHERE segments.date BETWEEN 'YYYY-MM-DD' AND 'YYYY-MM-DD'
See the GAQL docs for more details on the syntax

So this query:
SELECT campaign.id, metrics.cost FROM campaign WHERE segments.date BETWEEN
'YYYY-MM-DD' AND 'YYYY-MM-DD'
suppose to get us the desired data, right? (cost per campaign and period)
That's important for me to make sure that we can fetch that billing data
per campaign_id
If not all my efforts here are not relevant.
Thanks
On Tue, Sep 22, 2020 at 5:23 PM Nick Birnie<EMAIL_ADDRESS>wrote:

Yes, the invoice service is not generally available and your developer
token needs to be enabled to access the service.
Also it does not provide a breakdown by campaign - sorry I missed that
point. The closest option would be to download the campaign stats
https://developers.google.com/google-ads/api/fields/v5/campaign for the period
of the invoice
https://developers.google.com/google-ads/api/reference/rpc/v5/Invoice.
Here's a code example
https://developers.google.com/google-ads/api/docs/samples/get-campaigns
showing a basic retrieval option of campaign fields.
You could modify the query string something like: SELECT campaign.id,
metrics.cost FROM campaign WHERE segments.date BETWEEN 'YYYY-MM-DD' AND
'YYYY-MM-DD'
See the GAQL docs
https://developers.google.com/google-ads/api/docs/query/overview for
more details on the syntax
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-696755390,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6SHM5CJ6ZCGDM3QQ4TSHCXNZANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

Yes this should get you the cost per campaign for the specified period. It's a little inaccurate in that the invoice may be generated before credits are applied back to the account. For example, if we detect click fraud (bots spamming clicks) we will usually credit the advertiser for any spend that was accrued due to the fraud. This usually happens very quickly, but can take days/weeks, by which point the invoice will be generated and the customer billed. In this scenario you would see a discrepancy between the invoiced amount and the amount returned by that query. In practice though, these discrepancies tend to be small and don't really affect reconciliation of the invoice.

Alright
Sounds good
Thanks nick,
We will dive into it
בתאריך יום ג׳, 22 בספט׳ 2020, 18:31, מאת Nick Birnie <
<EMAIL_ADDRESS>
Yes this should get you the cost per campaign for the specified period.
It's a little inaccurate in that the invoice may be generated before
credits are applied back to the account. For example, if we detect click
fraud (bots spamming clicks) we will usually credit the advertiser for any
spend that was accrued due to the fraud. This usually happens very quickly,
but can take days/weeks, by which point the invoice will be generated and
the customer billed. In this scenario you would see a discrepancy between
the invoiced amount and the amount returned by that query. In practice
though, these discrepancies tend to be small and don't really affect
reconciliation of the invoice.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-696798050,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6V3KBL5RUEAM7NIF6TSHC7NPANCNFSM4RRPYBEA
.

Hey,
We want to use google ads invoice service.
Right now our company uses the google adwards service for fetching data in
multiple google reports.
Now we want to start the activity with google ads invoice service.
developerToken = "JWbEO5GRDpMgLSoau0_7aA"
CID.. , I guess you mean our customerId? if yes, it's<PHONE_NUMBER>.
Pls register us as allowlisted account.
Best,
Nir
On Tue, Sep 22, 2020 at 3:26 PM Nick Birnie<EMAIL_ADDRESS>wrote:

It's possible via the invoice service
https://developers.google.com/google-ads/api/docs/billing/invoice-service?hl=en.
This is only available to allowlisted accounts. I can file the request for
you. If you'd like to do this, please send a request to
<EMAIL_ADDRESS>with the following information:

Ask them to file an invoice API allowlist request.
How will you use this API ? For yourself or are you building a 3P
Tool?
Developer Token
Sample CIDs for which you will pull invoices

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-696687772,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6T6TQYMVH3CERFEIO3SHCJY7ANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

Hi, I deleted your comment because it contained your developer credentials. Please do not expose developer token on the public internet since it grants access to the API. I would strongly advise resetting your developer token by logging into the Google Ads UI -> Tools & Settings -> API Center. Note that doing so will revoke API access anywhere the old token was being used. Then please submit a request for allowlisting by contacting<EMAIL_ADDRESS>

Ok,
But you said to send the dev token in the request.
So what do i need to send in the call,
I dont understand
בתאריך יום ו׳, 25 בספט׳ 2020, 14:19, מאת Nick Birnie <
<EMAIL_ADDRESS>
Hi, I deleted your comment because it contained your developer
credentials. Please do not expose developer token on the public internet
since it grants access to the API. I would strongly advise resetting your
developer token by logging into the Google Ads UI -> Tools & Settings ->
API Center. Note that doing so will revoke API access anywhere the old
token was being used. Then please submit a request for allowlisting by
contacting<EMAIL_ADDRESS>—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-698873604,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6XHYR6QPSHUAXRPBGDSHR4DFANCNFSM4RRPYBEA
.

The request for allowlisting should be sent to<EMAIL_ADDRESS>There is no need to cc the github response alias.

alright.
so I sent i to them, its ok?

On Fri, Sep 25, 2020 at 3:31 PM Nick Birnie<EMAIL_ADDRESS>wrote:

The request for allowlisting should be sent to
<EMAIL_ADDRESS>There is no need to cc the github
response alias.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-698901364,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6RYQMIF2UXAMLV2BD3SHSES5ANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

Great, they should respond to your request shortly. Please remember to reset your developer token for security purposes.

hmm that would be not that easy.
This token is deleted from everywhere in your end right?
On Fri, Sep 25, 2020 at 3:44 PM Nick Birnie<EMAIL_ADDRESS>wrote:

Great, they should respond to your request shortly. Please remember to
reset your developer token for security purposes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-698907095,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6S7NRNHOG7HDHUT633SHSGDTANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

plus
if we will change it , how the service will be available to us (while
giving that token)
On Fri, Sep 25, 2020 at 4:46 PM Nir Krumer<EMAIL_ADDRESS>wrote:

hmm that would be not that easy.
This token is deleted from everywhere in your end right?
On Fri, Sep 25, 2020 at 3:44 PM Nick Birnie<EMAIL_ADDRESS>wrote:

Great, they should respond to your request shortly. Please remember to
reset your developer token for security purposes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-698907095,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6S7NRNHOG7HDHUT633SHSGDTANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

I've removed it from Github. However, it may have been intercepted between the time it was posted and my removing it.
The developer token can be regenerated in the Google Ads UI, once this is done you would need to update usages to the new token. As you correctly mentioned, resetting the token will revoke access to the compromised one.

alright,
as far as i know , more keys are required: client/secret/refresh key
correct?
just developer key isnt enough
On Fri, Sep 25, 2020 at 5:01 PM Nick Birnie<EMAIL_ADDRESS>wrote:

I've removed it from Github. However, it may have been intercepted between
the time it was posted and my removing it.
The developer token can be regenerated in the Google Ads UI, once this is
done you would need to update usages to the new token. As you correctly
mentioned, resetting the token will revoke access to the compromised one.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-698945993,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6S42V4HIOROSJX4U6DSHSPA7ANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

You are correct that developer token isn't sufficient to access customer accounts. It grants access to the API, which isn't available without signing up. If a developer token is found to be abusing the API (e.g. scraping search volume data) then API access may be disabled.

Alright thanks
We'll take that into consideration
For now google is going to approve the current dev token and the access to
the invoice service, right?
On Fri, Sep 25, 2020 at 5:10 PM Nick Birnie<EMAIL_ADDRESS>wrote:

You are correct that developer token isn't sufficient to access customer
accounts. It grants access to the API, which isn't available without
signing up. If a developer token is found to be abusing the API (e.g.
scraping search volume data) then API access may be disabled.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-698951366,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6XZZJT3JUXGUJESRODSHSQD3ANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

The support team will process the request for access to the invoice API. I'm not sure of the requirements here so I cannot comment on whether it will be approved or not. They should get back to you via email over the next couple (working) days.

OK
Thanks for all your help, Nick
On Fri, Sep 25, 2020 at 5:27 PM Nick Birnie<EMAIL_ADDRESS>wrote:

The support team will process the request for access to the invoice API.
I'm not sure of the requirements here so I cannot comment on whether it
will be approved or not. They should get back to you via email over the
next couple (working) days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-java/issues/339#issuecomment-698961236,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCFI6WVPHILS5KRDTR27JTSHSSFPANCNFSM4RRPYBEA
.

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

Hi Nir,
Thank you for reaching out. InvoiceService is available to allowlisted accounts only. However, this service is currently not open for sign-ups. You could check out if it’s available at a later time through the Release Notes of the Google Ads API.
Thanks and regards,
Xiaoming, Google Ads API Team
Xiaoming
Google Ads API Team
ref:_00D1U1174p._5004Q25Wopl:ref

Hey,
sorry to hear that.
well, are there any active users for the InvoiceService at all, or is it
not for use right now?
On Fri, Sep 25, 2020 at 6:47 PM Google Ads API Direct Support <
<EMAIL_ADDRESS>wrote:

Hi Nir,
Thank you for reaching out. InvoiceService
https://developers.google.com/google-ads/api/reference/rpc/v3/InvoiceService
is available to allowlisted accounts only. However, this service is
currently not open for sign-ups
https://developers.google.com/google-ads/api/docs/release-notes#220_beta_2019-09-25.
You could check out if it’s available at a later time through the Release
Notes https://developers.google.com/google-ads/api/docs/release-notes
of the Google Ads API.
Thanks and regards,
Xiaoming, Google Ads API Team
[image: Google Logo]
Xiaoming
Google Ads API Team
ref:_00D1U1174p._5004Q25Wopl:ref

--
Nir Krumer
Business Applications Manager
*E-Mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Mobile: +972 (0)50-8248181

Hi Nir,
Thank you for reaching out. It looks like this service has never been open for sign-ups. Please check back to see if it’s available at a later time through the Release Notes of the Google Ads API.
Thanks and regards,
Xiaoming, Google Ads API Team
Xiaoming
Google Ads API Team
ref:_00D1U1174p._5004Q25Wopl:ref

Hey ok i see
Basically, i want to get to the basic campaign object as first step.
Simple select query of that object
Is that possible?
Nir
בתאריך יום ו׳, 25 בספט׳ 2020, 23:25, מאת Google Ads API Direct Support <
<EMAIL_ADDRESS>
Hi Nir,
Thank you for reaching out. It looks like this service has never been open
for sign-ups. Please check back to see if it’s available at a later time
through the Release Notes
https://developers.google.com/google-ads/api/docs/release-notes of the
Google Ads API.
Thanks and regards,
Xiaoming, Google Ads API Team
[image: Google Logo]
Xiaoming
Google Ads API Team
ref:_00D1U1174p._5004Q25Wopl:ref

Hi there, I've reached out to the Invoice API team and they have approved your developer token for access. Sorry for the delay in getting this setup.
Also in general we won't see messages on tickets that are closed - please reopen the ticket if you're waiting for a response from us.

I am also facing similar issue, I have annotation enabled & google annotation in dependency as well.
nwbirnie, Can you please take a look once.

Hey @interview-ninja please could you try the steps outlined in https://github.com/googleads/google-ads-java/issues/339#issuecomment-694895907?

Thanks  nwbirnie for the comment, I tried all the steps in comment 339 but still it doesn't seems to work.
Instead of rebuild I see option for Rebuild Project. (I assume that shouldn't be the problem)
Please let me know if I can try something else.

Can you verify that you have annotation processing enabled for all projects? It should be enabled for default here:

Also if you just want to run the examples then you can checkout a tag of the library and run them without having to compile the library.

Thanks nwbirnie for the comment, I tried both things but didn't worked.
I checkout out this tag https://github.com/googleads/google-ads-java/releases/tag/14.0.0 but it still seems to give the same compile error. How we can run them without having to compile?

Can you post the file -> project sturcture menu? Which version of the JDK are you using?

My project structure is different i.e. instead of google-ads-parent I have google-ads-java (I believe that has nothing to do with the "method not resolved" problem)

Instead of google-ads-parent I have google-ads-java (I assume that is not related with the problem)

nwbirnie, Any suggestions on this?

Hey I can replicate this issue locally. It appears to be caused by compiling with JDK16. Could you try compiling with e.g. JDK 11 for now?

I tried that as well but it didn't work. If you prefer we can block some time to try out some things together.


🛢 Add weekly and monthly plan schedules

Title is self-explanatory.
Django tried to make two more migrations ('user', and 'site') but I thought it was safer not to include them in an unrelated PR.

I agree that that's another feature we should add.


sshd works only with older PHP tags

Works with an old PHP tag e.g.
  sshd:
    image: wodby/drupal-php:7.1-2.4.3
    container_name: "${PROJECT_NAME}_sshd"
    command: /usr/sbin/sshd -De
    environment:
      SSH_PUBLIC_KEYS: |-
        ["MYKEY"]
    volumes:
      - ./:/var/www/html
      - ../MYKEYLOCATION:/home/www-data/.ssh/id_rsa
    ports:
      - '2222:22'
    depends_on:
      - php

Does NOT work with a newer tag from docker-compose.yml e.g. "7.1-dev-4.2.5"
  sshd:
    image: wodby/drupal-php:$PHP_TAG
    container_name: "${PROJECT_NAME}_sshd"
    command: /usr/sbin/sshd -De
    environment:
      SSH_PUBLIC_KEYS: |-
        ["MYKEY"]
    volumes:
      - ./:/var/www/html
      - ../MYKEYLOCATION:/home/www-data/.ssh/id_rsa
    ports:
      - '2222:22'
    depends_on:
      - php

The log message is:

Could not load host key: /etc/ssh/ssh_host_rsa_key

Since the default user change in 4.x tag of php image you should use command: sudo /usr/sbin/sshd -De and change the volume path to /home/wodby/.ssh/id_rsa (or use SSH_PRIVATE_KEY)

Thanks, works perfectly now!


Release azure-cli-keyvault 2.0.6

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

Started releasing azure-cli-keyvault 2.0.6...

Release of 'azure-cli-keyvault' with version '2.0.6' successful. View at https://pypi.python.org/pypi/azure-cli-keyvault/2.0.6.

GitHub release created. https://github.com/Azure/azure-cli/releases.

Codecov Report

Merging #3691 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3691   +/-   ##
=======================================
  Coverage   72.23%   72.23%
=======================================
  Files         422      422
  Lines       26357    26357
  Branches     3991     3991
=======================================
  Hits        19040    19040
  Misses       6089     6089
  Partials     1228     1228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4233fbc...7f8b460. Read the comment docs.


Typos: buildbreak.md needs some typos correcting

The following issues have been observed within .github/ISSUE_TEMPLATE/buildbreak.md and need fixing:

In the "about" field, jenkins should have a capital J.
"Which platforms (OS+arch) are affected" should have a question mark before the full colon.
"If you look at the ... specific to one machine?" needs a full colon after the speech mark, but before the asterisks.
"Link to any upstream project..." also needs a full colon at the end, right before the asterisks.

I’d like to work on this issue


Part 2: 638 Feature Request: password generator with options

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] New feature or enhancement
[ ] UI change (please include screenshot!)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Internationalization and localization
[ ] Other (please describe):

What is the current behavior?

Issue Number: #638
What is the new behavior?
This is a continuation of the work started in #664.
Other information
I believe I have addressed the only two outstanding comments from the original PR which were...
Adding a new icon: I have added the icon suggested by @veler from the FluentSystemIcons font.

Supporting numbers as a toggle: I have added the numbers setting to the UI, and an InfoBar (Warning) is shown if no characters sets are selected.

Quality check
Before creating this PR:

[x] Did you follow the code style guideline as described in CONTRIBUTING.md
[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
[ ] Did you verify that the change work in Release build configuration
[x] Did you verify that all unit tests pass
[ ] If necessary and if possible, did you verify your changes on:

[x] Windows
[ ] macOS (DevToys 2.0)
[ ] Linux (DevToys 2.0)

Hi @veler, it looks like you're full steam ahead with 2.0. I am mostly done adding things I was missing when I first started using DevToys. This PR is just to clean up an old one that was hanging around. Do you have any plans to release a new version of 1.0 soon? Just to hold us over until 2.0 is maybe ready for early testing? 😊

Hi @veler, it looks like you're full steam ahead with 2.0. I am mostly done adding things I was missing when I first started using DevToys. This PR is just to clean up an old one that was hanging around. Do you have any plans to release a new version of 1.0 soon? Just to hold us over until 2.0 is maybe ready for early testing? 😊

Hi @micahmo ,
I am so sorry for the delay. I actually started looking at the PR weeks ago and then completely forgot.
You are right, me and @btiteux are fully into DevToys 2.0 at the moment. Things are progressing well but we're still months away from an early release.
I will definitely release the contribution you made soon, before DevToys 2.0. :)
Thank you for this pull request. It looks all good to me. I don't have much comment to make as they were already addressed from the previous PR.


Prettier updated to 1.9.2 in package-lock

package-lock.json wasn't updated in https://github.com/badges/shields/pull/1367. This PR updates it to version from package.json

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @platan!

  Generated by :no_entry_sign: dangerJS

Thanks!
greenkeeper-lockfile is supposed to take care of this. It must not be working correctly.


update dependencies for Node 14+ compatability

Update dependencies, specifically<EMAIL_ADDRESS>for Node 14+ compatibility
https://github.com/pillarjs/multiparty/commit/6afaf7aa02121d7542cc1d9f7b42a563d215e521#diff-168726dbe96b3ce427e7fedce31bb0bcR53.

Thank you, but that version already falls in the dependency range in the current package.json

Oops sorry about that, I had an outdated lock file that I though was the dependency version.


linux-qcom-uki: use bb.parse.SkipRecipe for the kernel Image check

Move the kernel Image check to the same python parsing logic created for merging KERNEL_IMAGETYPES, as SKIP_RECIPE does not take into account dynamic python logic, rejecting the updated KERNEL_IMAGETYPES value.
Since KERNEL_IMAGETYPES is not used anywhere else in the recipe, remove setVar and just use the merged 'types' variable instead.

@ndechesne fyi, tested with meta-qcom-hwe master.


Anyone interested in merged output lots, and safe adjustments for whole-dollar rounding?

Not sure if these options are something I should try to commit to this code - or the protocol for discussing that, so submitting this as an issue...
Along with some minor changes (changed titles of rows to make it easier for importing into TaxAct), I also have these options working locally:
-m, --merge_split_lots
Any split lots are merged back together at end. This
makes it easier to match the output to the input lots,
but can cause the buy-dates to be slightly incorrect
since a lot can only have a single buy date. In this
mode, some wash sale lots may have a loss that is
greater than the adjustment amount, instead of being
identical, i.e., only part of the loss in the lot is
actually a wash sale. This is expected in this mode..
-r, --adjust_for_dollar_rounding
Some tax software packages will round the basis,
proceeds and adjustment to calculate the total loss
(or profit). This can cause problems for wash sales
which instead of having a loss of $0 may now have a
profit of $1, which results in a warning about a wash
sale lot with a profit. Fix this by slightly modifying
the adjustment amount so that the final loss will be
$0 in such cases. It is safe to use this option with
the merge_split_lots option.
If there is interest, I can submit some or all of these changes.
Without the -r option, I get too many warnings in TaxAct during the Alerts phase.
And it has lots ending up with $1 profit or $1 loss, when it should have been all $0 for (unmerged) wash sale lots.

FWIW, I'd definitely be in favour of -m. Currently do this in semi-manually in spreadsheets.

While not ready for prime time, I've a fork with the code, but tests had to be simplified, so may need more work. It works fine for my purpose though :-)
https://github.com/avinash311/wash-sale-calculator
Closing this issue...

It seems that merging is a good thing and may be necessary at least by my reading of the IRS 8949 instructions - copied from the first page:

Form 8949 allows you and the IRS to reconcile amounts that were reported to you and the IRS on Form 1099-B or 1099-S (or substitute statement) with the amounts you report on your return. If you receive Form 1099-B or 1099-S (or substitute statement), always report the proceeds (sales price) shown on that form (or statement) in column (d) of Form 8949.

So, having the column d match each 1099-b (or each row of a consolidated 1099-b) might avoid any IRS follow related to how it was all computed.


DOC: Added reference for skewtest function. See #6829

Closes gh-6829

@gavin74 note that I edited the description to say Closes gh-6829. What this does is cross-link the issue it addresses, and that issue will now be automatically closed once we merge this PR.

If you could make those fixes and push them to the same branch you sent the PR from, they should show up here and the tests will be run again.

Ok, done. Thanks for the corrections.
On 6 December 2016 at 23:43, Ralf Gommers<EMAIL_ADDRESS>wrote:

If you could make those fixes and push them to the same branch you sent
the PR from, they should show up here and the tests will be run again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/pull/6834#issuecomment-265378507, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANhB5t6ty3yArd8H7XL8rBcNrg3FFxtRks5rFmO4gaJpZM4LGQJJ
.

this one should pass - third time's the charm

I can't get access to the full text of the article, so just to be sure: you've verified that that article has the expression that matches the stats.skewtest implementation?

@rgommers I checked--it matches (down to the variable names even).

@rgommers There's a copy of the paper at
https://www.ohio.edu/plantbio/staff/mccarthy/quantmet/D'Agostino.PDF
The statistic is calculated in section 4.1.
On 7 December 2016 at 07:46, Josh Wilson<EMAIL_ADDRESS>wrote:

@rgommers https://github.com/rgommers I checked--it matches (down to
the variable names even).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/pull/6834#issuecomment-265482695, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANhB5qVRQA3vV_Ix7oIBQhfwcRJMcxwfks5rFtTpgaJpZM4LGQJJ
.

Great, thanks! merged


output structure?

Hi, and thank you for making this code available.  I am running it on the input file that is provided, and am a bit confused about the output.  I would expect the corners, or position and rotation of markers, but it looks like:
19
Tag36h11.14 2.08100705561662e-05 5.52231728418008e-06 -2.5539668484284e-05 0.000176555558609455 -0.000189604698513551 1.49357654697979e-05
0.0001 0 0 0 0 0
0 0.0001 0 0 0 0
0 0 0.0001 0 0 0
0 0 0 0.01 0 0
0 0 0 0 0.01 0
0 0 0 0 0 0.01
	9 0 2 9 11 105 120 123 152 154
Tag36h11.3 2.45134053225531 0.416518411807496 0.999966806243172 -607.649138811526 1040.90632069732 2995.01405724277
1 0 0 0 0 0
0 1 0 0 0 0
0 0 1 0 0 0
0 0 0 1 0 0
0 0 0 0 1 0
0 0 0 0 0 1
	14 1 4 10 12 15 19 21 102 106 111 137 141 143 145
Tag36h11.0 2.4786236483332 -0.185234703531859 -0.162509253011588 1722.59336852785<PHONE_NUMBER>29527 1570.51426109844
1 0 0 0 0 0
0 1 0 0 0 0
0 0 1 0 0 0
0 0 0 1 0 0
0 0 0 0 1 0
0 0 0 0 0 1
	18 3 5 7 8 14 17 35 37 67 69 96 101 103 113 115 121 135 138
Tag36h11.4 -2.19822377776214 2.06905413334706 0.00137033032088581<PHONE_NUMBER>98044 -1470.545404413 2944.84767918785
1 0 0 0 0 0
0 1 0 0 0 0
0 0 1 0 0 0
0 0 0 1 0 0
0 0 0 0 1 0
0 0 0 0 0 1
	8 6 23 72 74 104 112 114 139

Could you explain this for me please if you have a moment?
I am also testing a live camera, I see markers detected, but 'views' stays at 0. Do I need to capture the frames somehow? Or is it automatic? Is it possible to return the marker ids and corners?
Thanks again!

Hi, thanks for your interests in the code.
For the output format, you can check this function: https://github.com/simbaforrest/masfm/blob/master/source/cmgraph.cpp#L191-L226
Basically, the rotations are encoded by angle-axis form instead of rotation matrix. The covariance matrix estimations are also outputed per marker.
After all marker states are outputed, the function will output view/camera states.
#number of markers in the camera-marker graph
19
#the first marker's name, angle-axis representation of rotation (the first 3 numbers), and locations (the last 3 numbers)
Tag36h11.14 2.08100705561662e-05 5.52231728418008e-06 -2.5539668484284e-05 0.000176555558609455 -0.000189604698513551 1.49357654697979e-05
#the covariance estimation of the first marker's pose, a 6x6 matrix, for the first marker, this is always the same as the input
0.0001 0 0 0 0 0
0 0.0001 0 0 0 0
0 0 0.0001 0 0 0
0 0 0 0.01 0 0
0 0 0 0 0.01 0
0 0 0 0 0 0.01
#9views/cameras observed this marker, and their ids (0 2 9 11 105 120 123 152 154).
9 0 2 9 11 105 120 123 152 154

For live camera-marker graph estimation with webcam, you may find the keyboard commands in this function:
https://github.com/simbaforrest/masfm/blob/58e93d560e3b20e01fc87b3926aa87578f6d7421/source/masfm.cpp#L352-L377
which is invoked here:
https://github.com/simbaforrest/masfm/blob/master/source/masfm.cpp#L352-L377
Hope this helps!

Hi, and Thanks! So just to be clear, in live mode, I just need to move the camera, and it should capture the views? It seems to show the markers, but the view count stays at zero.
Should it capture every frame? Or just when a certain number of markers are found?
Thanks again!

Hi, in live mode, you need to press key 'l' to log the current view so it will save the markers detected in the current view in the camera-marker graph for reconstruction and pose estimation. Thus, the current view should contain at least one detected marker (>2 is always recommended). Once you observed more than 2 markers in a same view, you can press key 'o' to call cmgraph to optimize the graph and plot 3d coordinate frame for each marker.
Right now the code in the live mode, I didn't output the final optimized graph of markers and views, you can easily do that by invoking the graph.report function in the following lines:
https://github.com/simbaforrest/masfm/blob/58e93d560e3b20e01fc87b3926aa87578f6d7421/source/masfm.cpp#L334-L344
Example of invoking that can be found in the batch mode:
https://github.com/simbaforrest/masfm/blob/58e93d560e3b20e01fc87b3926aa87578f6d7421/source/masfm.cpp#L334-L344

Thank you! I have everything running with my camera, but when I try to add a view, i get:
no connection to the graph, ignored
here:
https://github.com/simbaforrest/masfm/blob/58e93d560e3b20e01fc87b3926aa87578f6d7421/source/masfm.cpp#L247
The markers are displayed. What could be wrong?
Thank you again for your help and time.

Aha! I was not loading the ini properly. Everything seems to be up and running now. Thank you again for your code, and your time. Much appreciated! Have a great weekend.

Sorry to keep bugging you, one more question... I have it running, and returning the mapped data. The results look pretty good, but the position values are incorrect, putting the mapped markers too far apart. i have set the marker_half_size to half the edge of my markers, but it still looks wrong. i am streaming data in from my camera and have adjusted the code a little, using the following function and passing each frame to it as a Mat. If you have time, could you take a look and let me know if I am missing anything? Thank you again!
	void RunOneFrame(cv::Mat frame, int num)
	{
		load_calibration(G);
		static helper::PerformanceMeasurer PM;
		std::vector<TagDetection> detections;
		cv::Mat orgFrame;
		frame.copyTo(orgFrame);
		PM.tic();
		gDetector->process(frame, detections);
		logld("[TagDetector] process time = " << PM.toc() << " sec.");

		//visualization
		int nValidDetections = 0;
		logld(">>> find: ");
		for (int i = 0; i<(int)detections.size(); ++i) {
			TagDetection &dd = detections[i];
			if (dd.hammingDistance>this->hammingThresh) continue;
			++nValidDetections;

			logld("id=" << dd.id << ", hdist=" << dd.hammingDistance << ", rotation=" << dd.rotation);
			cv::putText(frame, dd.toString(), cv::Point(static_cast<int>(dd.cxy[0]), static_cast<int>(dd.cxy[1])),
				CV_FONT_NORMAL, tagTextScale, helper::CV_BLUE, tagTextThickness);
			cv::Mat Homo = cv::Mat(3, 3, CV_64FC1, dd.homography[0]);
			helper::drawHomography(frame, Homo);
			cv::circle(frame, cv::Point2d(dd.p[0][0], dd.p[0][1]), 3, helper::CV_GREEN, 2);
		}

		//logging results
		if (nValidDetections > 1 && num % 5 == 0) //every 5  frame
		{
			addDetections2CMGraph(detections);

			cmg::Node newView;
			if (optimizeThisView(detections, newView)) {
				plot3dOnFrame(frame, newView);
			}
		}

		 if (num % 100 == 0) //save every 100
		 {
			 std::cout << "GRAPH SAVED!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! " << num << std::endl;
			 save_graph_states(G);
		}

		cv::putText(frame,
			cv::format("#markers=%-4d #views=%-4d #edges=%-5d",
				G.markers.size(), G.views.size(), G.edges.size()),
			cv::Point(5, 15), CV_FONT_NORMAL, 0.4, helper::CV_BLUE);

	}

Aha, of course, i just needed to use processor(frame); to call the operator. Thanks again for the code! :)


Cannot view CS2 maps (The SAMPLES values of the read and draw framebuffers should match.)

Describe the bug
I cannot view CS2 maps, the render is completely black.

Relevant log output or exception with stacktrace
[19:52:55.385] [OpenGL] [High Api Error] GL_INVALID_OPERATION error generated. The SAMPLES values of the read and draw framebuffers should match.

What game does this happen in
CS2
Reference file in a Source 2 game
de_inferno.vmap in ...\Counter-Strike Global Offensive\game\csgo\maps\de_inferno.vpk
Expected behavior
I can view CS2 maps.
What version of VRF are you using? On what platform?
v8.1.3093+cdfbda66d9204bbab7d2d98c60f1fb8a336c660f, Microsoft Windows NT 10.0.22631.0

My GPU:
[OpenGL] GPU: NVIDIA GeForce RTX 4090/PCIe/SSE2, Driver: 4.6.0 NVIDIA 551.23

Decompilation is not a bug, you just didn't put it into the correct folder: https://github.com/ValveResourceFormat/ValveResourceFormat/discussions/619

Did you modify any of the settings in nvidia panel? Like anything related to anti aliasing or multisampling.

I cannot remember that I did, but resetting the 3D settings did indeed fix the issue. However, I'm now unable to reproduce a configuration that causes the renderer to bug out again. Perhaps my configuration file was somehow corrupted.

I cannot remember that I did, but resetting the 3D settings did indeed fix the issue. However, I'm now unable to reproduce a configuration that causes the renderer to bug out again. Perhaps my configuration file was somehow corrupted.

which 3D settings did you reset? Could you explain a bit further? I am having the same issue.
Thanks a bunch.

I cannot remember that I did, but resetting the 3D settings did indeed fix the issue. However, I'm now unable to reproduce a configuration that causes the renderer to bug out again. Perhaps my configuration file was somehow corrupted.

which 3D settings did you reset? Could you explain a bit further? I am having the same issue.
Thanks a bunch.

The 3D settings within the Nvidia Control Panel

I got it,I reproduced a configuration that cause this bug.If you choose the High quality NVD processor  option in Preferred graphics processor in the 3D settings within the Nvidia Control Panel could cause this bug，but if you choose the Auto option,it won't.

Potentially solved by the recently merged #790


CSS issue with 13" (1280 x 659) viewports.

Device:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.98 Safari/537.36
Viewport : 1280 x 659
Issue :

This almost made be believe that the url is actually .co instead of a .com

this must go against the backup/master and staging branches

We could use either <wbr> (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/wbr) or an overflow-wrap (https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap). Previously for this kind of issue, we used the <wbr>. I haven't used overflow-wrap, but the example on MDN could make for a more long-term solution without having to manually add in <wbr> breaks in long word.

I'm on it.
I'm adding this rule to the .test-output class. It's working on the staging branch, should I do the change to master branch as well?

@chiptus thanks a lot for looking into this.

should I do the change to master branch as well?

Yes.

this must go against the backup/master and staging branches


Update to newer GPflow and TensorFlow.

Update to make GPflux compatible with newer versions of GPflow, that require an additional X parameter in the likelihoods.
In this PR I just pass a dummy None value as X. Alternatively we could:

I don't know Keras and GPflux well, but maybe we can find a "real" value of X to use?
Do we want to attempt to write code that's compatible with earlier version of GPflow as well? I suppose we could add an if somewhere?

all seems good from an initial view.


Read scale

Adding read scale support to SQL Database CRUD operations.
This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[X] I adhere to the Command Guidelines.

@Juliehzl  please help with this PR.

@Juliehzl please help with this PR.

Please have a look.  Thank you.

OK. I will look it soon.

OK. I will look it soon.

Hi, any update on this?  Thanks.

@bradrich-msft  It will be better if you can provide examples for your new parameters usage.

Can you make CI pass and resolve left comments?


FancyZones: consider different aspect ratio as a different monitor (needed for PBP)

Description of the new feature / enhancement
I have a monitor with PBP (Picture by picture).
Sometimes I use the full area for a given HDMI output, sometimes only half of it (other half connected to another computer).
However, there is a huge aspect ratio difference (going from 16:18 to 16:9), and it would be much easier if I could have a different zone config depending on either case.
As a result, I was thinking it would be nice to consider same monitor but with different aspect ratio as a separate "monitor" for FancyZones zone layout. Basically recognize monitor not just by monitor ID but with (ID, aspect-ratio).
Would that be possible?
Note: if aspect ratio can be slighly inaccurate due to float rounding, or if we want to consider close aspect ratio like 16:10 and 16:9 as matching the same screen, I would be fine with that.
In the PBP case, there is a huge change (usually dividing one resolution axis by 2).
Scenario when this would be used?
When switching PBP (picture by picture) monitor between PBP and full mode.
Supporting information
No response

I most definitely agree. I already raised it before

Sorry for the duplicate, closing this one then!


Added randomization for game settins

You've got some lint errors and merge conflicts you'll have to resolve before we can merge this in.

test failures are due to WeekendPUSH


Add pgxpool metrics to kv/postgres implementation

Add https://pkg.go.dev/github.com/jackc/pgx/v4/pgxpool#Stat to prometheus metrics we collect

Name
Description

pgxpool_acquire_count
Cumulative count of successful acquires from the pool.

pgxpool_acquire_duration_ns
Total duration of all successful acquires from the pool in nanoseconds.

pgxpool_acquired_conns
Number of currently acquired connections in the pool.

pgxpool_canceled_acquire_count
Cumulative count of acquires from the pool that were canceled by a context.

pgxpool_constructing_conns
Number of conns with construction in progress in the pool.

pgxpool_empty_acquire
Cumulative count of successful acquires from the pool that waited for a resource to be released or constructed because the pool was empty.

pgxpool_idle_conns
Number of currently idle conns in the pool.

pgxpool_max_conns
Maximum size of the pool.

pgxpool_total_conns
Total number of resources currently in the pool. The value is the sum of ConstructingConns, AcquiredConns, and IdleConns.

Close #4138

@itaiad200 wait with the review there is a uniqueness issue when we open more than one store to the same database while having one set of metrics. Need to think to think how to handle this case or make sure we do not instance more than one.

Updated the code to enable configurable metrics for postgres.
Updated the test not to open two stores in parallel

@itaiad200 ready for ready


Changed use of Input#env to include multidev envs where applicable, improved function signature

Closes #694

Big improvement!
:+1:


Binary artifact in flutter/packages repository

packages/rfw/example/wasm/logic/calculator.wasm:1 was checked into the packages repository.
Remediation:

Remove the generated executable artifacts from the repository.
Build from source.

Severity: High
Details:
Risk: High (non-reviewable code)

Binary was included in this PR: https://github.com/flutter/packages/pull/452
\cc @Hixie

Yeah, it's part of the demo for RFW. It needs to be downloadable for the demo to work. If there's a way we can compile the artifact in CI to verify that it's the right bytes, that would make sense...

I'm going to leave this as-is for now, maybe we can fix it when we fix #129385, that way we don't have to worry about introducing a new build pipeline into the CI for this repo just for a tiny example.


Added to docker image

Added to the
https://github.com/maksym-iv/battle-tools#siege-engine

Got it, will later provide a Dockerfile for launch

Ok, thank you very much. Will later update the README


crypto/x509: provide method for generating conformant serial numbers

Currently, generating valid, RFC 5280 conformant, serial numbers is an exercise left up to the user. As of https://go.dev/cl/400377 we enforce the 20 octet length requirement, but it looks like a lot of users don't entirely know how they should go about generating a valid serial number (in particular if people do know about the 20 octet maximum, they are not aware that serials that are 20 octets long cannot have the MSB set.)
Since there are such ambiguities about how to best do this, it would seem prudent to just provide a function which generates serials (or a method on *Certificate) that are conformant with the 5280 rules, i.e.

func GenerateSerial(rand io.Reader) (*big.Int, error)
func (*Certificate) GenerateSerial(rand io.Reader) error

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

It is not clear if the proposal is to add func GenerateSerial(rand io.Reader) (*big.Int, error) or func (*Certificate) GenerateSerial(rand io.Reader) error or both. Could you please clarify?

Closing this in favor of the proposal in #67675.


<EMAIL_ADDRESS>md2-select not work in Firefox and IE11

The issue is that when I select an option , the selected value will not update.
<md2-select [(ngModel)]="selectedCategory" placeholder="category">
<option *ngFor="let i of categories" [value]="i">{{i}}

even I use:
<md2-select [(ngModel)]="selectedCategory" (change)="onChange($event)" placeholder="category">
<option *ngFor="let i of categories" [value]="i">{{i}}

onChange(newValue) {
  this.selectedCategory= newValue;
}

I ran the demo on Chrome, Firefox, IE11 and the result is only work on chrome.

use md2-option instead of option tag or refer md2-select


feat: use new myuw-compact-card web component

Switches the legacy compact-card AngularJS Directive to wrap the new compact-card web component.
Regressions:

Some previously supported Font Awesome icon name aliases and suffixes are not supported in the new compact card implementation.
Deleting cards from layout in compact mode is temporarily unsupported. The web component is firing an event, but app framework is not yet handling that event other than to show a message to the user.
As of this writing, the web component does not include a link to the app details page in the contextual menu on the compact card.

Review for security considerations

[x] The change has been examined for security impact.

PR considerations checklist:

[x] Updates CHANGELOG.md to reflect this PR's change.
[x] This Contribution is under the terms of Individual Contributor License Agreements (and also Corporate Contributor License Agreements to the extent applicable) appearing in the Apereo CLA roster.

Subsequently reverted in #939


[MetaSchedule][M4b] Testcases for TensorRT builder/runner

This PR includes BYOC builder/runner infra and its test case for TensorRT.
Thanks for your time to review this.
cc: @junrushao1994
Please note that previous PR is closed due to the overlap with previous merge.

CC @zxybazh would love you guys to review each other’s code :-)

Thanks @sunggg! It's finally merged :-)


Error with RoomAnalysis

I tried the reverberation_time example, and I get the following error:
[/usr/local/lib/python3.7/dist-packages/scipy/signal/filter_design.py](https://localhost:8080/#) in iirfilter(N, Wn, rp, rs, btype, analog, ftype, output, fs)
   2344     if not analog:
   2345         if numpy.any(Wn <= 0) or numpy.any(Wn >= 1):
-> 2346             raise ValueError("Digital filter critical frequencies "
   2347                              "must be 0 < Wn < 1")
   2348         fs = 2.0

ValueError: Digital filter critical frequencies must be 0 < Wn < 1

Any hints?
Best,
N

Here's the full traceback:
(pytta-env) ubuntu@op-mm-deeparts-os:~/PyTTa/examples$ python reverberation_time.py
Traceback (most recent call last):
  File "reverberation_time.py", line 19, in <module>
    maxFreq=float(2e4))
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/analysis.py", line 970, in __init__
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/analysis.py", line 996, in estimate_energy_parameters
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/analysis.py", line 1471, in cumulative_integration
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/analysis.py", line 1161, in _filter
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/filter.py", line 83, in __init__
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/filter.py", line 115, in get_sos_filters
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/filter.py", line 105, in __design_sos_butter
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/scipy/signal/filter_design.py", line 2867, in butter
    output=output, ftype='butter', fs=fs)
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/scipy/signal/filter_design.py", line 2346, in iirfilter
    raise ValueError("Digital filter critical frequencies "
ValueError: Digital filter critical frequencies must be 0 < Wn < 1

Hello @the-drunk-coder, thank you for the traceback and your interest in pytta.
My time for pytta lies only on the weekends, when there's spare time, so I won't be able to give you some more hints right away. If you don't mind trying to run it from de code in development and get us the traceback, we might coordinate a solution to this issue.
Thanks again, and feel free to question as much as you want!

Hi @Chum4k3r, no worries :)
The traceback above is from the latest development version, I checked it out this morning, in a conda environment generated from the requirements.yml.
I played around with it and tried to scale the edge frequencies to [0, 1] (by dividing them by samplerate//2, but now I get a different error, so I'm not sure whether that was the right way to go ...
Best,
Niklas

Ok, from the scipy.signal.iirfilter documentation, it seems that the parameter fs receives a None, instead of the actual .samplingRate property.
If it is None, it is coming from the OctFilter class as a samplingRate == None.
Can you debug the filtering steps to check?
This is the critical code line of the filtering process.
best,
João Vitor

That doesn't seem to be it, the samplerate is passed correctly to the OctFilter constructor.
I also tried the following (mentioned above but here's the details):
In filter.py, line 102, add: edges = edges / (samplingRate//2) to normalize the frequencies to [0,1]
This leaves me with another error, though:
Traceback (most recent call last):
  File "revtime_local.py", line 21, in <module>
    maxFreq=float(2e4))
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/analysis.py", line 970, in __init__
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/analysis.py", line 996, in estimate_energy_parameters
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/analysis.py", line 1488, in cumulative_integration
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/analysis.py", line 1414, in energy_decay_calculation
  File "/home/ubuntu/miniconda3/envs/pytta-env/lib/python3.7/site-packages/PyTTa-0.1.2a0-py3.7.egg/pytta/classes/analysis.py", line 1281, in _Lundeby_correction
IndexError: index -1 is out of bounds for axis 0 with size 0


when trying to deploy aks cluster using this module it fails with the error "ServiceCidrOverlapExistingSubnetsCidr"

Below is my main.tf file . when i try to deploy this it deploys RG ,Vnet and Subnet but fails during AKS deployment
**provider "azurerm" {
features {}
}
resource "azurerm_resource_group" "aks" {
name     = var.resourcegroupname
location = var.location
tags = {
environment = "dev"
}
}
module "network" {
source              = "Azure/network/azurerm"
resource_group_name = azurerm_resource_group.aks.name
address_space       = "<IP_ADDRESS>/16"
vnet_name           = "${var.prefix}-vnet"
subnet_prefixes     = ["<IP_ADDRESS>/24"]
subnet_names        = ["aks-main"]
tags = {
environment = "dev"
}
depends_on          = [azurerm_resource_group.aks]
}
module "aks" {
source              = "Azure/aks/azurerm"
version = "4.2.0"
resource_group_name = azurerm_resource_group.aks.name
client_id           = "your-service-principal-client-appid"
client_secret       = "your-service-principal-client-password"
prefix              = "${var.prefix}-aks"
vnet_subnet_id      = module.network.vnet_subnets[0]
os_disk_size_gb     = 126
agents_count        = var.agents_count
agents_size         = var.agents_size
enable_log_analytics_workspace = false
tags = {
environment = "dev"
}
depends_on = [module.network]
}**
Error: creating Managed Kubernetes Cluster "prod-aks-aks" (Resource Group "elasticsearch-rgs"): containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="ServiceCidrOverlapExistingSubnetsCidr" Message="The specified service CIDR <IP_ADDRESS>/16 is conflicted with an existing subnet CIDR <IP_ADDRESS>/24" Target="networkProfile.serviceCIDR"
on .terraform/modules/aks/main.tf line 10, in resource "azurerm_kubernetes_cluster" "main":
10: resource "azurerm_kubernetes_cluster" "main" {
am I doing some thing wrong

I had the same issue. Somehow - even if the specified subnet should fit into the address-space, it doesn't work like this. If you're just after some defaults that work (but should be adapted for your prod-configuration), then you can go with:

address_space = "<IP_ADDRESS>/16"
subnet_prefixes = ["<IP_ADDRESS>/24"]

Hi @vilaspatel You can now specify the serviceCidr by variable net_profile_service_cidr to avoid this error. Related to https://github.com/Azure/terraform-azurerm-aks/pull/80

I believe this issue is still present with the configuration in the module's README, actually

Hi @michaeljguarino The service requires that the net_profile_service_cidr to be unique.

Yeah and the one in the example is actually contained within the subnet created in the network module


Stop publishing snapshots to retiring m2.neo4j.org

We upload snapshot artifacts to S3 and there is no need to retain
module build snapshots on a public server for every check-in. Local
builds should cover this need, coupled with Maven Central releases for
stable versions.

This change itself seems like a very good thing.
I would like to know if there is still a need to publish executable artefacts somewhere?
Because if there is we should find a new place to publish to.

@thobe For snapshots I don't see that need as a very great one. We publish stable versions as part of our milestone releases and snapshots can be built locally by someone who needs it. Our CI builds make sure that snapshot building is always possible.


Logged connection endpoint contains wrong IP address

The some of the xrdp log messages after closing a connection wrong resp. non-existing IP address. The example below shows the IP address <IP_ADDRESS> that doesn't exists in my network.
I checked some of the xrdp-related processes and don't find any TCP connection with file descriptor 12 or 13. But both file descriptors are in use for Unix domain sockets.

Please adapt the code to show the right peer name / end in such cases.
Extract from /var/log/xrdp.log:
# tail /var/log/xrdp.log
[20160531-14:32:12] [INFO ] The following channel is allowed: drdynvc (5)
[20160531-14:32:12] [DEBUG] The allow channel list now initialized for this session
[20160531-14:34:24] [INFO ] An established connection closed to endpoint: <IP_ADDRESS>:12148 - socket: 13
[20160531-14:34:24] [INFO ] An established connection closed to endpoint: <IP_ADDRESS>:59727 - socket: 8
[20160531-14:34:24] [DEBUG] xrdp_mm_module_cleanup
[20160531-14:34:24] [INFO ] An established connection closed to endpoint: <IP_ADDRESS>:12148 - socket: 12
[20160531-14:34:24] [ERROR] Listening socket is in wrong state we terminate listener

Open files from xrdp-related processes filtered by fd 12 and fd 13:
xrdp      22931     root   12u  unix 0xffff881025c10b40       0t0   255532 socket
xrdp      22931     root   13u  unix 0xffff881025c25640       0t0   249600 socket
xrdp-chan 24939 carsten 12u  unix 0xffff881025c27800       0t0   257545 /tmp/.xrdp/xrdp_chansrv_socket_10
xrdp-chan 24939 carsten 13u  unix 0xffff8810244221c0       0t0   258526 socket

Open TCP connections:
# grep IPv4 trace
xrdp-sesm  1206     root    7u  IPv4               8957       0t0      TCP localhost:findviatv (LISTEN)
xrdp      10052     root    7u  IPv4              85695       0t0      TCP *:ms-wbt-server (LISTEN)
xrdp      22931     root    8u  IPv4             217345       0t0      TCP mysrv:ms-wbt-server->myclient:59727 (ESTABLISHED)

Thank you,
Carsten

The message occured after I opened and closed a Gnome session via the Session Manager.

This is a long life known bug. Haven't fixed yet.
http://blog.gmane.org/gmane.network.rdesktop.xrdp.devel/page=20
https://sourceforge.net/p/xrdp/discussion/389417/thread/e8fb6b34/

I've a suggestion to review:
void APP_CC
g_write_ip_address(int rcv_sck, char *ip_address, int bytes)
{
    struct sockaddr_in sin;
    struct sockaddr_un sun;
    struct in_addr in;
#if defined(_WIN32)
    int len;
#else
    unsigned int len;
#endif

    len = sizeof(sun);
    memset(&sun, 0, len);

    /* Get address family and local address the socket is bound to */
    if (getsockname(rcv_sck, (struct sockaddr *)&sun, &len) < 0) {
        /* Common error: EBADF */
        log_message(LOG_LEVEL_DEBUG,
                    "getsockname() for fd %d failed: %d (%s)",
                    rcv_sck, g_get_errno(), g_get_strerror());
        goto error;
	}

    switch (sun.sun_family) {
#ifndef _WIN32
        case AF_UNIX:
            /* All OS: unnamed socket */
            if (len == sizeof(sa_family_t))
            {
                snprintf(ip_address, bytes,
                         "Unnamed socket - fd: %d", rcv_sck);
            }
            /* Abstract socket - Linux specific and probably Solaris */
            else if ( len > sizeof(sa_family_t) && sun.sun_path[0] == '\0')
            {
                 snprintf(ip_address, bytes,
                         "Abstract Linux socket - fd: %d", rcv_sck);
            }
            /* All OS: path name */
            else
            {
                snprintf(ip_address, bytes,
                         "Local socket file %s - fd: %d", sun.sun_path, rcv_sck);
            }
            return;
#endif
        case AF_INET:
        case AF_INET6:
            len = sizeof(sin);
            memset(&sin, 0, len);
            /* Get peer connection details */
            if (getpeername(rcv_sck, (struct sockaddr *)&sin, &len) < 0)
            {
                /* Common error: ENOTCONN */
                log_message(LOG_LEVEL_DEBUG,
                            "getpeername() for fd %d failed: %d (%s)",
                            rcv_sck, g_get_errno(), g_get_strerror());
                goto error;
            }

            memset(&in, 0, sizeof(in));
            in.s_addr = sin.sin_addr.s_addr;
            snprintf(ip_address, bytes, "%s:%d - fd: %d",
                     inet_ntoa(in), ntohs(sin.sin_port), rcv_sck);
            return;

        default:
            log_message(LOG_LEVEL_DEBUG,
                        "Unknown address family %d for fd: %d",
                        sun.sun_family, rcv_sck);
    }

error:
    snprintf(ip_address, bytes, "NULL:NULL - fd: %d", rcv_sck);
}

Maybe the function could be renamed to something like g_write_socket_details and NULL:NULL could be changed to unkown socket details.

Tested but I can see no client ip address (<IP_ADDRESS>).
[20160628-16:22:59] [INFO ] An established connection closed to endpoint: Abstract Linux socket - fd: 19
[20160628-16:23:03] [INFO ] An established connection closed to endpoint: Abstract Linux socket - fd: 19
[20160628-16:23:07] [INFO ] An established connection closed to endpoint: Abstract Linux socket - fd: 19
[20160628-16:23:11] [INFO ] An established connection closed to endpoint: Abstract Linux socket - fd: 19
[20160628-16:23:14] [INFO ] A connection received from: <IP_ADDRESS> port 56913
[20160628-16:23:14] [INFO ] An established connection closed to endpoint: <IP_ADDRESS>:56913 - fd: 11
[20160628-16:23:14] [DEBUG] getpeername() for fd 10 failed: 57 (Socket is not connected)
[20160628-16:23:14] [INFO ] An established connection closed to endpoint: NULL:NULL - fd: 10
[20160628-16:23:14] [DEBUG] getpeername() for fd 11 failed: 57 (Socket is not connected)
[20160628-16:23:14] [INFO ] An established connection closed to endpoint: NULL:NULL - fd: 11
xrdp_mcs_disconnect - socket closed
[20160628-16:23:14] [ERROR] Listening socket is in wrong state we terminate listener
[20160628-16:23:14] [INFO ] A connection received from: <IP_ADDRESS> port 56914
[20160628-16:23:14] [INFO ] An established connection closed to endpoint: <IP_ADDRESS>:56914 - fd: 11
[20160628-16:23:14] [DEBUG] getpeername() for fd 10 failed: 57 (Socket is not connected)
[20160628-16:23:14] [INFO ] An established connection closed to endpoint: NULL:NULL - fd: 10

Fixed by #411.

@proski @metalefty: "Thank you" for fixing this bug!


Tab separator shape is unusual

Operation System: macOS 10.12.6
Beaker version: 0.8 beta
I noticed a small curve near the top end of the tab separator.

Is this intentional? Looks funny, specially before I zoomed in to figure out why it felt funny.
By the way, great job so far!

Not intentional. Thanks for the catch!
On Fri, Mar 16, 2018 at 06:24 André Staltz<EMAIL_ADDRESS>wrote:

Operation System: macOS 10.12.6
Beaker version: 0.8 beta
I noticed a small curve near the top end of the tab separator.
[image: screen shot 2018-03-16 at 13 21 06]
https://user-images.githubusercontent.com/90512/37518299-45a00be8-291d-11e8-8aee-30bf16f6bc88.png
[image: screen shot 2018-03-16 at 13 21 12]
https://user-images.githubusercontent.com/90512/37518300-45be162e-291d-11e8-87f7-ff4dfa8234eb.png
Is this intentional? Looks funny, specially before I zoomed in to figure
out why it felt funny.
By the way, great job so far!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/beakerbrowser/beaker/issues/881, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHO8QUU817wvQiItdY_eXbx9MM1PjQWtks5te6D7gaJpZM4StohC
.


STABmons: Restrict Extreme Speed

https://www.smogon.com/forums/threads/stabmons.3587949/page-26#post-7775135

I don’t know why I tho it e came before b


Pcov not showing coverage for modules

I'm running the following to execute unit tests and to also generate code coverage
php -dpcov.enabled=1 \     -dpcov.directory=. \     -dpcov.exclude="~vendor~" \     ./vendor/bin/paratest -c phpunit-codefresh.xml \     --coverage-html=ci/html
my phpunit-codefresh.xml file is:
`

<testsuites>
    <testsuite name="Api Tests">
        <directory suffix="Test.php">./tests</directory>
    </testsuite>
    <testsuite name="Modules">
        <directory suffix="Test.php">./Modules/Company/Tests</directory>
    </testsuite>
</testsuites>
<filter>
    <whitelist addUncoveredFilesFromWhitelist="true" processUncoveredFilesFromWhitelist="true">
        <directory suffix=".php">./app</directory>
        <directory suffix=".php">./Modules/Company</directory>
        <exclude>
            <directory suffix="blade.php">./modules</directory>
            <directory suffix=".php">./Modules/Company/Annotations</directory>
            <directory suffix=".php">./Modules/Company/Database</directory>
            <directory suffix=".php">./Modules/Company/Routes</directory>
            <directory suffix=".php">./Modules/Company/Resources</directory>
            <directory suffix=".php">./Modules/Company/Tests</directory>
            <directory suffix=".php">./Modules/Company/Config</directory>
        </exclude>
    </whitelist>
</filter>
<php>
    <server name="APP_ENV" value="codefresh"/>
    <server name="CACHE_DRIVER" value="array"/>
    <server name="SESSION_DRIVER" value="array"/>
    <server name="QUEUE_CONNECTION" value="null"/>
    <server name="DB_CONNECTION" value="isg"/>
    <server name="DB_HOST" value="mariadb"/>
    <server name="DB_DATABASE" value="app_testing"/>
    <server name="DB_USERNAME" value="app"/>
    <server name="DB_PASSWORD" value="test"/>
    <server name="DB_PORT" value="3306"/>
    <env name="TELESCOPE_ENABLED" value="false"/>
    <env name="BROADCAST_DRIVER" value="log"/>
    <ini name="memory_limit" value="8G"/>
</php>

`
The output will show 0.00% for Modules/Company when it should be more like 65.00%.  There are tests there that would show up for a previous way using xdebug to generate coverage reports.
Is there something I am missing here for proper coverage to appear in the report?

@dmillerSHQ Did you manage to solve this?

For anyone who comes across this in the future. In my case, the pcov.directory value was not being set when passed on the CLI. I had to set this value directly in the php.ini file. Code coverage is now calculated correctly for Modules.

Can confirm this is still working.
If you want to inject the settings in GiHub Action, it would look like:
steps:
  - uses: shivammathur/setup-php@refer-to-setup-php's-version-tag
    with:
        php-version: '8.2'
        ini-values: pcov.directory=$GITHUB_WORKSPACE
        coverage: pcov

while in CircleCI, it would look like like:
- run:
      name: 'Patch PHP runtime config.'
      command: |
          sudo sh -c "echo 'pcov.directory = /home/circleci/project' >> /usr/local/lib/php.ini"

# run tests with phpunit
- run:
      name: 'Run Unit Tests'
      command: |
          php artisan test --parallel --processes=2 --coverage-clover tests/coverage.xml


Can you cut another release please

I would like to use your updates for Windows colored output, but I am using go mod and  can't figure out how to pull from master and not v1.0.0.
kthxbye 😉

v1.1.0!


Column with integer 1 and 0 returns NaN for 0.

Problem:
cat <<EOF >data/check.csv
b, c
one,1
zero,0.0
zero,0
EOF
cat data/check.csv| tv -n 50

The NaN should be 0.

Check NaN regex and add this to test cases.

#35


AssemblyScript API Parity

The current state of AssemblyScript support in Reactr is essentially a prototype that only implements a few of the Runnable API namespaces (log, http). The remaining namespaces should be implemented and tested to bring parity with the Rust API.

AS has parity with the core API now.


Adding Glacier Auditor. Renaming 'vault' to 'glacier'.

Coverage decreased (-0.006%) to 68.726% when pulling 464975d777aa6a9f1cab5fdeb3c3e56a2b534162 on glacier_auditor into c83571b671fcaa8a11f49720cba0b8a7c170b2d8 on develop.

Coverage decreased (-0.006%) to 68.726% when pulling 464975d777aa6a9f1cab5fdeb3c3e56a2b534162 on glacier_auditor into c83571b671fcaa8a11f49720cba0b8a7c170b2d8 on develop.


Kibana Chart with "kibana_system" user: readinessProbe never succeeds

Chart version:
7.12.0
Kubernetes version:
1.18.2
Kubernetes provider: E.g. GKE (Google Kubernetes Engine)
Kubernetes is set up with Rancher
Helm Version:
v3
helm get release output
The environment is air-gapped but I think the bug  is simple enough to reproduce.
Describe the bug:
When I set up kibana to use the kibana_system user (as recommended for production) the readinessProbe never succeeds.
This is because kibana settings and the readinessProbe use the same user and password ( ELASTICSEARCH_USERNAMEand ELASTICSEARCH_PASSWORD) to connect to elasticsearch and kibana, but the kibana_system user lacks permission to access kibana.
Therefore the call to app/kibana returns a 403 HTTP Status Code, but the readinessProbe expects a 200, as the code snippet shows:
https://github.com/elastic/helm-charts/blob/b3a4b753a564811713f1a5ff04669baa3a4adfd7/kibana/templates/deployment.yaml#L124-L127
Once I manually edit the readinessProbe to accept a 403 code everything works fine
Steps to reproduce:

Set kibana_system user as ELASTICSEARCH_USERNAME in kibana helm template
Deploy kibana helm template
Watch kibana readinessProbe failing with Error: Got HTTP code 403 but expected a 200

Expected behavior:
The readinessProbe should recognise that kibana is fully up and running and succeed if the kibana_system user is used.
One could either accept 403, too or just access / (which then gets redirected to /login?next=%2F ) and evaluate the http status code there (which is 200 for an unauthenticated user as well)

Hi @felixfiskare,
Thanks for opening this issue.
Unfortunately we currently don't have time to investigate every tickets so please be patient.

I worked around this issue by dropping ELASTICSEARCH_USERNAME and ELASTICSEARCH_PASSWORD from extraEnvs - instead I set up
kibana.yml: |
  elasticsearch.username: kibana_system
  elasticsearch.password: <password>

in values.yaml.
I didn't test it enough to say there are no other issues with this approach, but at least kibana is now passing the probe test and running

My workaround was to use another endpoint for healthcheck. I'm using /api/status instead of /app/kibana.

I am also having this issue. Tested by swapping ELASTICSEARCH_USERNAME to elastic and it worked fine, so it is definitely a permission issue with this user. @josecu08's workaround works great, so not a blocker but as it stands right now, the kibana_system role doesn't seem to be enough for the 'kibana_system' user to function

Same issue here and resolved it by setting
healthCheckPath: /api/status

as proposed by @josecu08

Related to #1239


Number Parsing truncate decimals

https://github.com/bijukunjummen/aws-sdk2-dynamo-json-helper/blob/ff2b93bd7cd75b41c39087fb417ec84f6c2faa9b/src/main/java/org/bk/aws/dynamo/util/JsonAttributeValueUtil.java#L84
It appears that the parsing for a decimal value truncate the number.
:bug: Reproduction details

input string : "1.5"
expected output : 1.5
actual output : 1
jdk terumin 17.0.6

Behind the scene, the Number.getInstance().parse("3.5")
The workaround to fix that behaviour is to get org.apache.commons.lang3.math.NumberUtils
Number number = NumberUtils.createNumber(attributeValue.n());

Ooh, thanks @cKuppel, will plan to fix it.

Merged your additional test @cKuppel , looks like it is working as expected with the numeric types?


Create  ReleaseNotes.txt

Create the ReleaseNotes.txt file with information about changes in new releases.

ReleaseNotes.md created


Share snapshot on socials

PR Description
This PR introduces a share button for Creative Zen Snapshots, enabling users to share their visions creatively on social media. The functionality includes a customized SweetAlert with hover effects on social media icons, enhancing user interaction. Additionally, fade-in and fade-out animations have been implemented for the alert, providing a polished user experience.
Related Issues:
Fixes: https://github.com/TheOpenInnovator/Zen-Note/issues/38
Changes:

Created a share button that triggers the sharing functionality for Creative Zen Snapshots.
Customized the SweetAlert to improve visual appeal and user engagement.
Added hover effects to each social media icon for better interactivity.
Implemented fade-in and fade-out animations for the SweetAlert to enhance the overall user experience.

Testing Instructions:

Pull this branch.
Navigate to the Creative Zen Snapshots feature.
Click the share button and observe the customized SweetAlert.
Hover over the social media icons to verify the hover effects.
Test the fade-in and fade-out animations by opening and closing the alert.

Checklist

[x]  I have performed a self-review of my code.
[x]  I have commented my code, particularly in hard-to-understand areas.
[x]  My changes generate no new warnings.
[x]  I have tested the share functionality, hover effects, and animations.
[x]  I am working on this issue under Hacktoberfest.

https://github.com/user-attachments/assets/ea0a0293-57b7-4ee2-90cf-c86edaab106b

Congratulations @HarshitaJaiswal5 🎉 Kudos to your Contributions. Hope you keep contributing & keep learning. 💫


minor issue related to list numbering.

Your text is very well written and mostly free from typos. However, I noticed a minor issue related to list numbering. In the "Contributing to o1js" section, the list numbering restarts at 1 after the first item. Here's the corrected version:

This is actually how markdown lists work. The code has 1s, but the text is automatically rendered with the correct numbers (makes it easier to maintain, you can add or shuffle items without caring about the numbering)


[Question/Feedback]: Access to Proposed Module Azure/terraform-avm-res-insights-scheduledqueryrule

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
Hi folks,
I'm wondering how I can go back to contributing to Azure/terraform-avm-res-insights-scheduledqueryrule now that things have calmed down a bit on my end and have the time to pick up development again.
I was one of the co-owners of the Azure/terraform-avm-res-insights-scheduledqueryrule along with @JoeyBarnes and I had forked the repo to my github profile and began work on the module. I had pushed my local copy online but then I was laid off and subsequently my github ID was removed from the Azure GitHub Org. How can I get access to it again so I can make contributions?
-Bryan

@prjelesi, @PmeshramPM, can you please advise on how Bryan (a now former Microsoft employee) could continue contributing to this module in question? Thanks!

@matt-FFFFFF, can you please take a look at this? Thanks!

Hi @jchancellor-ms have you had a chance to look at this?
FYI @matebarabas


aws_eks_node_group supports taints from aws provider version 3.43.0

Is your request related to a new offering from AWS?
yes, scheduled for release 3.43.0
https://github.com/hashicorp/terraform-provider-aws/issues/19310

Is your request related to a problem? Please describe.
Will solve workaround with kubelet_extra_args to add taints to nodes
and relates to some issues:
https://github.com/terraform-aws-modules/terraform-aws-eks/issues/1232
https://github.com/terraform-aws-modules/terraform-aws-eks/issues/1214
https://github.com/terraform-aws-modules/terraform-aws-eks/issues/1085
https://github.com/terraform-aws-modules/terraform-aws-eks/issues/962

Describe the solution you'd like.

Simply set the block and make it available as input variable similar to k8s_labels
resource "aws_eks_node_group" "example" {
  ...

  taint {
    key    = "dedicated"
    value  = "gpuGroup"
    effect = "NO_SCHEDULE"
  }

  taint {
    key    = "special"
    value  = "true"
    effect = "PREFER_NO_SCHEDULE"
  }
}

Describe alternatives you've considered.

Additional context

Taint has been released https://github.com/hashicorp/terraform-provider-aws/blob/v3.43.0/CHANGELOG.md