Fix stream-k dynamic grid model

There's a typo where grid_start is being set to cuCount, which should be grid_end. I have also removed the defaults to avoid this from happening, as cuCount differs from architecture to architecture and even within different compute modes.

@neoblizz please merge this PR now if you want it in the next release. Thanks.

I don't have merge access to the repo, could you please merge this? Thanks!


Fix Timer error on startup

Fixes https://github.com/godotengine/godot/pull/87542#discussion_r1888971859

It does fix the error, but it's a bit hacky, as before. It's also a bit inconsistent with the set_warning_count(0); below which may make this harder to follow. As I mentioned once, perhaps it's better to just bite the bullet and fetch the editor setting in the constructor...?

Yeah that's an alternative.

Pushed a different fix.

Thanks!


⭐⭐ Add Features ⭐⭐

Add
Add your liked features to make the assistant more efficient.
Try to deal with big one, and get to the solution with our community.
Integrate
Integrate something which you like and make the assistant more vibrant like by adding news, to-do's, voice-calculator, storyteller, fun facts and many more which vibrate in your mind.

Hi moshsinansari0705, I am an upcoming programmer currently studying for my certification. As part of the criteria to receive my qualification, I must contribute to an open-source project like yours. I like your project's look and wish to collaborate on it. I would greatly appreciate it if you could assign this issue to me.
Some suggestions that I can think of implementing in this project include a list of command shortcuts, greetings that are customized for the user and overall UI improvements.
Thank you in advance.


Input.is_action_pressed("a") does not behave the same as event.is_action_pressed("a") on doubleclick

on v2.0.1_stable
If you try both of these statements in an _input(event) function, event.is_action_pressed("a") will return true and Input.is_action_pressed("a") will return false if the action "a" was triggered by a doubleclick.
example code:
func _ready():
    set_process_input(true)

func _input(event):
    if event.type == 3 and event.is_pressed():
        print(event.is_action_pressed("a"), Input.is_action_pressed("a"))

after creating action "a" and setting its input to a mouse click, upon testing it should print "true true for the first click then "true false" for the second click of the doubleclick.

Can't reproduce anymore.
I think this has been fixed by the recent changes in Input Actions.


[Fedora-Linux] Update EOL dates and command

F36 was delayed, which pushed back the F34 end of life date: https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html
F35 EOL date from: https://fedorapeople.org/groups/schedule/f-37/f-37-key-tasks.html
As for the command change, it's due to lsb_release not being installed by default anymore

Fedora is delayed again. EOL moved to 2022-06-07. Could be delayed more.


Support Bootstrap V4

News about bootstrap v4 here:
https://getbootstrap.com/docs/4.0/getting-started/introduction/

Addressed in v4 branch.


retribution enchant Compat with basic shields [fabric]?

It looks like the Retribution Enchant isn't able to be put on shields from basic shields [fabric], it'd be lovely if that could be supported!

How exactly have you run into this problem? Things already has compatibility measures in place and we just confirmed that they do in fact still work with the latest versions of all mods involved. Also, note that Retribution is a treasure enchantment and can thus never be applied at an enchantment table
Cheers

I did find it as a treasure enchant, and all I was trying to do was apply it in an anvil like you'd do with any enchanted book. I'm not sure why it's not working in this case? Might be acting weird with some other mods so I'll try to look into it and see if I can pin down the culprit causing weirdness.

Have you been able to track this down any further?

Given that nobody else appears to have problems with this, and the fact it has been two months since the last activity on here I'll go ahead and close this


Fixing GameSave sample identity

@jasonsandlin,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Multi-GPU training with gradient propagation in FP16 with XLA fails.

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
tf 2.14
Custom code
Yes
OS platform and distribution
No response
Mobile device
No response
Python version
3.11
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
11.8/8.7
GPU model and memory
A100 40GB (20GB MiG)
Current behavior?
Following advice given here, I implemented gradient propagation in FP16 and concurrent backpropagation with gradient propagation. I am using mixed precision with XLA enabled.
The custom training step works fine when XLA is not enabled. However, when I enable it, I get the error that you can see in the log.
This is run on 2 GPUs using MultiWorkerMirroredStrategy.
Standalone code to reproduce the issue
import json
import os

import tensorflow as tf

def get_replica_hostnames():
    ...

def get_replica_id():
    ...

def set_multiworker_env_config():
    hostnames = get_replica_hostnames()
    replica_index = get_replica_id()

    os.environ["TF_CONFIG"] = json.dumps(
        {
            "cluster": {
                "worker": hostnames,
            },
            "task": {"type": "worker", "index": replica_index},
        }
    )

class Model(tf.keras.models.Model):
    def __init__(self, *args: Any, **kwargs: Any) -> None:
        super().__init__(*args, **kwargs)

        self._embedder = tf.keras.Sequential(
            [
                tf.keras.layers.Conv2D(
                    filters=8,
                    kernel_size=3,
                    padding="same",
                    activation=tf.keras.activations.relu,
                    use_bias=False,
                ),
                tf.keras.layers.BatchNormalization(),
                tf.keras.layers.Conv2D(
                    filters=8,
                    kernel_size=3,
                    padding="same",
                    activation=tf.keras.activations.relu,
                    use_bias=False,
                ),
                tf.keras.layers.BatchNormalization(),
                tf.keras.layers.MaxPool2D(),
                tf.keras.layers.GlobalAveragePooling2D(),
            ]
        )

        self._classifier = tf.keras.layers.Dense(550)

    def call(self, x: tf.Tensor) -> tf.Tensor:
        x = self._embedder(x)
        x = self._classifier(x)
        x = tf.keras.layers.Activation("linear", dtype="float32")(x)
        return x

    def train_step(self, data):
        x, y, sample_weight = tf.keras.utils.unpack_x_y_sample_weight(data)

        # Run forward pass.
        with tf.GradientTape() as tape:
            y_pred = self(x, training=True)
            loss = self.compute_loss(x, y, y_pred, sample_weight)
            loss = self.optimizer.get_scaled_loss(loss)

        self._validate_target_and_loss(y, loss)

        # Run backward pass.
        grads = tape.gradient(loss, self.trainable_variables)
        grads = [tf.cast(grad, "float16") for grad in grads]
        all_reduced_grads = tf.distribute.get_replica_context().all_reduce(
            tf.distribute.ReduceOp.SUM,
            grads,
            tf.distribute.experimental.CommunicationOptions(
                bytes_per_pack=50 * 1024 * 1024,
            ),
        )
        all_reduced_grads = [tf.cast(grad, "float32") for grad in all_reduced_grads]
        all_reduced_grads = self.optimizer.get_unscaled_gradients(all_reduced_grads)

        self.optimizer.apply_gradients(
            zip(all_reduced_grads, self.trainable_variables),
            skip_gradients_aggregations=True,
        )

        return self.compute_metrics(x, y, y_pred, sample_weight)

def create_dummy_dataset(batch_size: int) -> tf.data.Dataset:
    X = np.random.rand(batch_size, 384, 640, 1)
    y = np.random.randint(550, size=batch_size)
    return tf.data.Dataset.from_tensor_slices((X, y)).batch(batch_size, True).repeat()

def train():
    tf.keras.mixed_precision.set_global_policy("mixed_float16")

    set_multiworker_env_config()
    strategy = tf.distribute.MultiWorkerMirroredStrategy()
    num_replicas = strategy.num_replicas_in_sync

    batch_size = 384 * num_replicas
    dataset = create_dummy_dataset(batch_size)
    dataset = strategy.experimental_distribute_dataset(dataset)

    with strategy.scope():
        model = Model()
        model.compile(
            loss=tf.keras.losses.SparseCategoricalCrossentropy(
                from_logits=True,
            ),
            optimizer=tf.keras.optimizers.Adam(
                learning_rate=1e-3,
                weight_decay=1e-5,
            ),
            metrics=[
                "accuracy",
            ],
            jit_compile=True,
        )

    model.fit(
        dataset,
        epochs=10,
        steps_per_epoch=100,
    )

if __name__ == "__main__":
    train()

Relevant log output
2024-01-15 14:06:48.704206: E tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:9342] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2024-01-15 14:06:48.704294: E tensorflow/compiler/xla/stream_executor/cuda/cuda_fft.cc:609] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2024-01-15 14:06:48.704350: E tensorflow/compiler/xla/stream_executor/cuda/cuda_blas.cc:1518] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-01-15 14:06:48.712047: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2024-01-15 14:06:49.711421: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
2024-01-15 14:06:51.459926: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1886] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 18184 MB memory:  -> device: 0, name: NVIDIA A100-SXM4-40GB MIG 3g.20gb, pci bus id: 0000:01:00.0, compute capability: 8.0
2024-01-15 14:06:51.469378: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1886] Created device /job:worker/replica:0/task:0/device:GPU:0 with 18184 MB memory:  -> device: 0, name: NVIDIA A100-SXM4-40GB MIG 3g.20gb, pci bus id: 0000:01:00.0, compute capability: 8.0
2024-01-15 14:06:51.490217: I tensorflow/core/distributed_runtime/rpc/grpc_server_lib.cc:457] Started server with target: grpc://gen-svc-82ee2ab7-aae8-44b2-a5ab-1f9fd0401075:80
2024-01-15 14:06:51.495668: I tensorflow/tsl/distributed_runtime/coordination/coordination_service.cc:551] /job:worker/replica:0/task:0 has connected to coordination service. Incarnation:<PHONE_NUMBER>930509670
2024-01-15 14:06:51.495948: I tensorflow/tsl/distributed_runtime/coordination/coordination_service_agent.cc:299] Coordination agent has successfully connected.
2024-01-15 14:06:52.263966: I tensorflow/tsl/distributed_runtime/coordination/coordination_service.cc:551] /job:worker/replica:0/task:1 has connected to coordination service. Incarnation:<PHONE_NUMBER>2770279744
2024-01-15 14:07:16.278224: W tensorflow/tsl/framework/cpu_allocator_impl.cc:83] Allocation of<PHONE_NUMBER> exceeds 10% of free system memory.
2024-01-15 14:07:17.178980: W tensorflow/tsl/framework/cpu_allocator_impl.cc:83] Allocation of<PHONE_NUMBER> exceeds 10% of free system memory.
2024-01-15 14:07:17.905980: W tensorflow/tsl/framework/cpu_allocator_impl.cc:83] Allocation of<PHONE_NUMBER> exceeds 10% of free system memory.
2024-01-15 14:07:22.444540: W tensorflow/tsl/framework/cpu_allocator_impl.cc:83] Allocation of<PHONE_NUMBER> exceeds 10% of free system memory.
Epoch 1/10
2024-01-15 14:07:24.533902: W tensorflow/tsl/framework/cpu_allocator_impl.cc:83] Allocation of<PHONE_NUMBER> exceeds 10% of free system memory.
2024-01-15 14:07:27.793986: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x7f080000c190 initialized for platform CUDA (this does not guarantee that XLA will be used). Devices:
2024-01-15 14:07:27.794120: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): NVIDIA A100-SXM4-40GB MIG 3g.20gb, Compute Capability 8.0
2024-01-15 14:07:28.936911: I tensorflow/compiler/mlir/tensorflow/utils/dump_mlir_util.cc:269] disabling MLIR crash reproducer, set env var `MLIR_CRASH_REPRODUCER_DIRECTORY` to enable.
2024-01-15 14:07:30.163125: I tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:442] Loaded cuDNN version 8906
2024-01-15 14:08:24.307063: I tensorflow/compiler/xla/stream_executor/gpu/asm_compiler.cc:328] ptxas warning : Registers are spilled to local memory in function 'triton_gemm_dot_232', 12 bytes spill stores, 12 bytes spill loads

2024-01-15 14:08:24.726556: I tensorflow/compiler/xla/stream_executor/gpu/asm_compiler.cc:328] ptxas warning : Registers are spilled to local memory in function 'triton_gemm_dot_232', 12 bytes spill stores, 12 bytes spill loads

2024-01-15 14:08:24.789581: I tensorflow/compiler/xla/stream_executor/gpu/asm_compiler.cc:328] ptxas warning : Registers are spilled to local memory in function 'triton_gemm_dot_232', 8 bytes spill stores, 8 bytes spill loads

2024-01-15 14:08:26.317751: I tensorflow/compiler/xla/stream_executor/gpu/asm_compiler.cc:328] ptxas warning : Registers are spilled to local memory in function 'triton_gemm_dot_392', 92 bytes spill stores, 92 bytes spill loads

2024-01-15 14:08:26.687122: W tensorflow/core/framework/op_kernel.cc:1839] OP_REQUIRES failed at xla_ops.cc:624 : UNKNOWN: <unknown>:0: error: loc("all-reduce-start.1"): 'lmhlo_gpu.all_reduce_start' op requires the same element type for all operands
<unknown>:0: note: loc("all-reduce-start.1"): see current operation:
%225 = "lmhlo_gpu.all_reduce_start"(%222, %8, %224, %18, %220, %222, %8, %224, %18, %220) ({
^bb0(%arg58: tensor<f32>, %arg59: tensor<f32>):
  %251 = "mhlo.add"(%arg58, %arg59) : (tensor<f32>, tensor<f32>) -> tensor<f32>
  "mhlo.return"(%251) : (tensor<f32>) -> ()
}) {channel_id = #mhlo.channel_handle<handle =<PHONE_NUMBER>, type = 0>, constrain_layout = false, is_sync = true, replica_groups = dense<> : tensor<0x0xi64>, use_global_device_ids = false} : (memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<5630xf16>, memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<5630xf16>) -> !mhlo.token

2024-01-15 14:08:26.687331: I tensorflow/core/framework/local_rendezvous.cc:421] Local rendezvous recv item cancelled. Key hash:<PHONE_NUMBER>6648882243
2024-01-15 14:08:26.687358: I tensorflow/core/framework/local_rendezvous.cc:421] Local rendezvous recv item cancelled. Key hash:<PHONE_NUMBER>414942276
2024-01-15 14:08:26.687399: I tensorflow/core/framework/local_rendezvous.cc:421] Local rendezvous recv item cancelled. Key hash:<PHONE_NUMBER>169437454
Traceback (most recent call last):
  File "/kirax_source/train.py", line 133, in <module>
    train()
  File "/kirax_source/train.py", line 125, in train
    model.fit(
  File "/usr/local/lib/python3.11/dist-packages/keras/src/utils/traceback_utils.py", line 70, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/usr/local/lib/python3.11/dist-packages/tensorflow/python/eager/execute.py", line 60, in quick_execute
    tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
tensorflow.python.framework.errors_impl.UnknownError: Graph execution error:

Detected at node StatefulPartitionedCall defined at (most recent call last):
  File "/usr/lib/python3.11/threading.py", line 1002, in _bootstrap

  File "/usr/lib/python3.11/threading.py", line 1045, in _bootstrap_inner

Detected at node StatefulPartitionedCall defined at (most recent call last):
  File "/usr/lib/python3.11/threading.py", line 1002, in _bootstrap

  File "/usr/lib/python3.11/threading.py", line 1045, in _bootstrap_inner

2 root error(s) found.
  (0) UNKNOWN:  <unknown>:0: error: loc("all-reduce-start.1"): 'lmhlo_gpu.all_reduce_start' op requires the same element type for all operands
<unknown>:0: note: loc("all-reduce-start.1"): see current operation:
%225 = "lmhlo_gpu.all_reduce_start"(%222, %8, %224, %18, %220, %222, %8, %224, %18, %220) ({
^bb0(%arg58: tensor<f32>, %arg59: tensor<f32>):
  %251 = "mhlo.add"(%arg58, %arg59) : (tensor<f32>, tensor<f32>) -> tensor<f32>
  "mhlo.return"(%251) : (tensor<f32>) -> ()
}) {channel_id = #mhlo.channel_handle<handle =<PHONE_NUMBER>, type = 0>, constrain_layout = false, is_sync = true, replica_groups = dense<> : tensor<0x0xi64>, use_global_device_ids = false} : (memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<5630xf16>, memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<5630xf16>) -> !mhlo.token

         [[{{node StatefulPartitionedCall}}]]
         [[Reshape_3/_24]]
  (1) UNKNOWN:  <unknown>:0: error: loc("all-reduce-start.1"): 'lmhlo_gpu.all_reduce_start' op requires the same element type for all operands
<unknown>:0: note: loc("all-reduce-start.1"): see current operation:
%225 = "lmhlo_gpu.all_reduce_start"(%222, %8, %224, %18, %220, %222, %8, %224, %18, %220) ({
^bb0(%arg58: tensor<f32>, %arg59: tensor<f32>):
  %251 = "mhlo.add"(%arg58, %arg59) : (tensor<f32>, tensor<f32>) -> tensor<f32>
  "mhlo.return"(%251) : (tensor<f32>) -> ()
}) {channel_id = #mhlo.channel_handle<handle =<PHONE_NUMBER>, type = 0>, constrain_layout = false, is_sync = true, replica_groups = dense<> : tensor<0x0xi64>, use_global_device_ids = false} : (memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<5630xf16>, memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<1xf32>, memref<5630xf16>) -> !mhlo.token

         [[{{node StatefulPartitionedCall}}]]
0 successful operations.
0 derived errors ignored. [Op:__inference_train_function_2528]

Hi, @sushreebarsa. How do I check that?

@cyanic-selkie To check if XLA is enabled or not please use , `tf.config.list_logical_devices()'
If XLA is disabled, you won't see any XLA devices listed in the output.
import tensorflow as tf

print(tf.config.list_logical_devices())

Thank you!

Sorry for the delayed response, here is the result:
[LogicalDevice(name='/job:worker/replica:0/task:0/device:CPU:0', device_type='CPU'), LogicalDevice(name='/job:worker/replica:0/task:0/device:GPU:0', device_type='GPU'), LogicalDevice(name='/job:worker/replica:0/task:1/device:CPU:0', device_type='CPU'), LogicalDevice(name='/job:worker/replica:0/task:1/device:GPU:0', device_type='GPU')]

@andremfreitas Unfortunately, no. In fact, all of my opened issues ultimately went unanswered. It's no secret that TF is internally deprecated, and I would suggest switching to PyTorch or JAX/Flax, perhaps using Keras 3 as a stepping stone if legacy code is a big issue for you.


asciidoctor-with-extensions: Remove asciidoctor-rouge gem

https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/tools/typesetting/asciidoctor-with-extensions/Gemfile
Describe the bug
The aforementioned ruby library is deprecated. Is functionality has been subsumed into asciidoctor.
Steps To Reproduce
N/A
Expected behavior
The dependency on this gem should be removed.
Additional context
There is no change required from end users. Asciidoctor allows specifying which extensions should be used. Any users of this extension can omit it, and document conversion should be unaffected (included those that depended on this extension).
Notify maintainers
@doronbehar
Metadata
N/A

Thanks for the notice! How did you notice this? Fix is at https://github.com/NixOS/nixpkgs/pull/248869 .

Hugo (a static site generator) mentioned it in its docs, but asciidoctor doesn't in its docs, so I searched for references to the gem.

Why reopened?

Sorry, I'm sure why this was marked reopened.


{communication} HTML tags are rendering as empty parameter values in reference docs

Describe the bug
Problem to solve:
HTML tags in source code are causing build warnings in MicrosoftDocs/azure-docs-cli. More importantly, customer-facing reference docs are not instantiating properly -- parameter values formatted with `<>` are missing. Here's an example:

Requested solution:
These values should be escaped with a backtick. Here's an example from az webpubsub.

Related GitHub issues:
This is the same issue as these GitHub issues.
List of HTML tag instances that need update:

File name
Build error

latest/docs-ref-autogen/communication.yml
HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/communication.yml
HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/communication/email.yml
HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/communication/email.yml
HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/communication/email/domain.yml
HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/communication/email/domain.yml
HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/communication/email/domain/sender-username.yml
HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/communication/email/domain/sender-username.yml
HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

Related command
az communication
Errors
n/a
Issue script & Debug output
n/a
Expected behavior
n/a
Environment Summary
Azure CLI 2.62.0
Additional context
No response

Thank you for opening this issue, we will look into it.


How to Increase the font size?

Is it possible to Increase font size?

You can add text-lg to classes_content and classes_content_header in your config. But this will work only for default components like cards, tables, etc, but not in smallbox, infobox ....


Bring back ProjectileLauncher

SpongeAPI | SpongeCommon
API's ProjectileLauncher was completely useless, even as a marker because Living extends EntityProjectileSource.

manually merged


[GOBBLIN-1214] Move the fallback of in-eligible shuffleKey to driver

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1214

Description
Before this change, when a user-specified shuffle-key is not eligible ( e.g. the field in the shuffle doesn't exist in the data schema), the fallback is not working properly as the OrcKeyComparator is still using the shuffle-key specified in jobConfigurator. It ends up with failure in deserialization from byteArray into in-memory ORC row-object.
This change makes the detection of eligibility happen in the driver level, so that within OrcValueMapper the fallback of shuffleKey is transparent.
Added a unit test for that which would be failing before.
Also rename the mrOutputSchema to mrInputSchema for the accuracy. This indeed breaks the atomicity of this commit but it is overall relevant.
Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

LGTM, just double check that job.getConfiguration() will be used to set conf for OrcKeyComparator right?

do you mean "get conf for " ?

LGTM, just double check that job.getConfiguration() will be used to set conf for OrcKeyComparator right?

do you mean "get conf for " ?
Yes, please also check the travis build failure


Feature: Clear cookie by name with Playwright

Motivation/Description of the PR

new (since Playwright 1.43): Delete individual cookies with Playwright

Applicable helpers:

[ x ] Playwright
[ ] Puppeteer
[ ] WebDriver
[ ] REST
[ ] FileHelper
[ ] Appium
[ ] TestCafe

Type of change

[ ] :fire: Breaking changes
[ x ] :rocket: New functionality
[ ] :bug: Bug fix
[ ] 🧹 Chore
[ ] :clipboard: Documentation changes/updates
[ ] :hotsprings: Hot fix
[ ] :hammer: Markdown files fix - not related to source code
[ ] :nail_care: Polish code

Checklist:

[ x ] Tests have been added
[ ] Documentation has been added (Run npm run docs)
-> npm run docs does not work for me :/
[ ] Lint checking (Run npm run lint)
-> npm run lint does not work for me :/
[ ] Local tests are passed (Run npm test)
-> npm test does not work for me :/

@ngraf tests failed. Could you check if it is needed to update Playwright in the pipeline?
https://github.com/codeceptjs/CodeceptJS/blob/3.x/.github/workflows/playwright.yml


Use cargo fetch instead of cargo generate-lockfile

This allows offline work, as cargo fetch only updates the lockfile if
necessary, whereas cargo generate-lockfile basically does a remove and
regenerate.

CC https://github.com/japaric/steed/issues/97.
I tested it without cross (just plain cargo) and with cross on steed, it seems to work.

:pushpin: Commit 94d632c has been approved by japaric

Nice!
@homunkulus r+

:hourglass: Testing commit 94d632c with merge 94d632c...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing 94d632cac533e535b5b2d1ecaf0f99df3c596410 to master...


ZKGROUP_SERVER_PUBLIC_PARAMS value in Signal Android

Hello,
I want to change ZKGROUP_SERVER_PUBLIC_PARAMS value in build.gradle file, but after copying the value that i have generated during signal server installation, it shows the following error "org.signal.zkgroup.InvalidInputException: Length of array supplied was 159 expected 161"
I have tried to padding it with random char but it shows another error "org.signal.zkgroup.InvalidInputException: FFI_RETURN_INPUT_ERROR"
Thanks in advance :)

@tofee91 have you update the dependency in the signal server to zkgroup 0.7.0 then recompiling it?

@tofee91 have you update the dependency in the signal server to zkgroup 0.7.0 then recompiling it?

@madeindra what is the correct procedure to update it? because i have compiled the signal server and it's working now with updating any dependency

@tofee91 I wrote the new guide, please check it.
It is as simple as changing 0.6.0 to 0.7.0 in the signal-server pom.xml

@tofee91 I wrote the new guide, please check it. https://github.com/madeindra/setup-guide/tree/master/signal-new
It is as simple as changing 0.6.0 to 0.7.0 in the signal-server pom.xml

Thank you, after updating the dependency it works! :)

Alright, I'm gonna close the issue than, thanks for reporting this


customize search result sorting

Is it possible to customize the behavior of search result sorting?
as in the sorting by, but a separate config for search result sorting:

Without fuzzy search, the search results are also sorted using the same sorting option.
With fuzzy search, the search results will be sorted by the fuzzy matching algorithm.
What would you like to change exactly?

I am talking about search without fuzzy algorithm, is it possible to have a own separate config related to search and not be same as "sorted by".

What's the use case? Can you provide an example of when you'd want a different sorting with and without search?

would be meaningful for me to see the result of a search sorted by number of copies (as most of what i search are most used items in my daily routine)
and in normal case to see the list sorted by recent copied  (would be meaningful for me to not look for), because i switch a lot between recently copied items.

would be meaningful for me to see the result of a search sorted by number of copies (as most of what i search are most used items in my daily routine)

Would it make sense to pin often used items?

pin some items, that make sense!

Awesome, please use pins then.


RegEx fixes for videos

Found that the youtube and vimeo RegEx checks can bug out in certian circumstances.
YouTube could fail oddly and only return the first character of the match, now fixed along with handling for both youtu.be and youtube.com addresses to be added)
Vimeo would bug out if video id wasn't the first and only part of the path.
(for example https://vimeo.com/channels/staffpicks/128544536 is a valid link but so is https://vimeo.com/128544536 but only the second link would get picked up. Now changed so that it finds the last forward slash after the vimeo web address.)

Sorry should have said, I've been trying to get to know regex more recently and one of the things I've been playing with is seeing how many things have to be checked to complete the task, yours comes out at 91, mines down to 53 but it's semantics really (it would be worse if it was into the thousands which is easy to do if your regex gets recursive) https://regex101.com/ is pretty good for letting you know the step count and explaining what it's upto (as well as testing for a few different flavours of regex too).
But at any rate, either regex works and doesn't fall over so either way would be suitable and work better than the existing regex.

@SgtOddball could you please add the missing URLs in the test file, and then we'll merge it :)
https://github.com/madebymany/sir-trevor-js/blob/master/spec/javascripts/units/block/video.spec.js#L25

Did you still want me to look over this? (missed all this going on over the weekend)

@SgtOddball Just verify that we test against all the important URLs in the test file I linked

@lukaszsagol That looks fine to me. Thanks for adding it to the tests as well. ![GitHub logo] (http://i.imgur.com/dwuig5F.jpg)

Let's :shipit: then

Thanks for contribution @SgtOddball


Feat/reconstruct dfget interface

Ⅰ. Describe what this PR did
Define some interface of dfget to reconstruct the dfget.
Ⅱ. Does this pull request fix one issue?

NONE.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
No need.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1343 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
+ Coverage   51.12%   51.13%   +0.01%
==========================================
  Files         126      126
  Lines        8327     8327
==========================================
+ Hits         4257     4258       +1
  Misses       3724     3724
+ Partials      346      345       -1

Impacted Files
Coverage Δ

supernode/daemon/mgr/scheduler/manager.go
22.60% <0.00%> (+0.68%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003b73d...c9332ef. Read the comment docs.


Accounting

Could you add an output.csv which summarises the payouts with 3 columns: Address, Amount, txid - This would make it easy for me to report how the funds were used.
Thanks!

@lamafab FYI


I don’t know what is wrong with this?

Describe your problem here.

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Nothing I don’t think so

if i can do anything then tell me

the crash clearly ses some thing wong with character stuf "character.hx (line 164)" and there is a null object reference "uncaught error: null object reference"  try checking the code you resently wote!!!!!! i hope this help or sumthin.

I don’t really understand

bru... check the code that you wote before the crash hapened, it is a simple bug hunting/glich finding skill

The ones I recently wrote were the charting and the week.JSON

then check them and see it they mess with the chracters or reference another code file thing

Still don’t know

Im new to this so I need a dumbed down explanation

Plus I’m using 0.6.2

just use lua if u want a dummed down ver of Psych

w<            >W<          Ow<

Actually, it only happens when I want to change the characters in charting

Only gf and opponent

You using source ?

Character.hx line 164 is frames = Paths.getSparrowAtlas(json.image);. Assuming you haven't changed anything in Character.hx, this would mean that the path to the character's image in your character's json file is invalid.

----->w< ------ >W< ------ Ow<


[1.11.2-1.0.1] creative dupe bug

client console log: https://paste.ee/p/bYMFf
When giving yourself items in creative you get duplicates, one to the world and one to your inventory.
Video Bug Report: https://youtu.be/fYO1o7fo54U

if it is so unimportant and difficult to fix can you remove buoyancy from
the mod, after all you wouldn't want more of these bug reports.
On Thu, Mar 2, 2017 at 8:09 PM, Tyler<EMAIL_ADDRESS>wrote:

Closed #248 https://github.com/BeetoGuy/BetterWithMods/issues/248.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BeetoGuy/BetterWithMods/issues/248#event-984740683,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADs0iJwCd4HdG9Hj1TlHvyI1xN3B1u5Pks5rh3ZzgaJpZM4MRrmf
.

It is unimportant because you are duplicating items that you cheated in. Why remove a feature for that reason?
Use the config to disable the feature if you prefer this the bug is that important.

Sorry you feel that way.
On Mar 3, 2017 8:52 AM, "KnightMiner"<EMAIL_ADDRESS>wrote:

It is unimportant because you are duplicating items that you cheated in.
Why remove a feature for that reason?
Use the config to disable the feature if you prefer this the bug is that
important.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BeetoGuy/BetterWithMods/issues/248#issuecomment-283973596,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADs0iHqk1pBcmGcWc7W8wihX2Aeaz5x6ks5riCk5gaJpZM4MRrmf
.

You should fix it and here's why.
https://youtu.be/klsbg5UsRTg
Server owners and staff can't use command blocks that give players items. You have effectively disabled them from doing it.

I honestly don't care to have this argument, if another dev wants to try at this have fun fixing something that is essentially unfixable.

Well, if it's Hardcore Buoy that's causing the problem, then it should be trivial to fix it by disabling it in the configs. If it's near-impossible on our end, that might be the best option.


query order by benchmark added

Doh, clearly failed at using the web interface to resolve this merge conflict.


render fail : (node:4188) UnhandledPromiseRejectionWarning: Error: spawn EBUSY

I thought it was because I installed node.js, but on my other pc that I didn't install node on the same error happened.

A see that issue appearing more and more. Have you recently also updated windows by any case?

I updated windows after the error started happening.

I'm experiencing this , too, now. Suddenly the @action/encode part using ffmpeg produces this error, The video rendering with aerender works fine though. I can't explain either. I haven't changed anything relevant to my system, that I could recall.

Ok, looks like I found the issue (at least on my machine). The Windows malware defender/anti-virus service must have blocked access to the files. You just need to exclude the nexrender working directory folder from the malware protection.
See here how to do that:
https://support.microsoft.com/en-us/help/4028485/windows-10-add-an-exclusion-to-windows-security

Thank you! It worked!

Oh no. It seems we found the issue.
@johnrico2000 thank you!

Since I get the same error I would be interested in the solution for this issue.
But I am not fully sure if we would need to follow the instructions @FRANK-AND-FREE suggests or if @inlife has found some other fix for this. In the latter case I would have a different problem maybe?
Error: Error loading postrender module @nexrender/action-encode: Error: Error in action-encode module (ffmpeg) Error: spawn EBUSY

@brassel so far from browsing the web this kind of error seems to appear on windows for exact same reasons: system telling nodejs that It can't allow it to touch the specific file for reasons of it doing something with that file already. Like antimalware software reading into it or blocking it altogether.
That is at least the consensus that comes from my small research. Unfortunately, I'm not sure if there is anything we can do about it.


_this.networkInterface.subscribe is not a function

use this.$apollo.queries.tags.subscribeToMore
=> _this.networkInterface.subscribe is not a function

Ask the question again


Test.h Location

Hello ,  Test.c includes Test.h file but it is not in the repo... would you please include it?

Makefile creates, it.. disregard previous comment..

JNI generates the header file for you. It's in the Makefile at L31.


Updates URLs for documentation and download to the Apache Incubator sites

Docs are not hosted at the BlackBerry site anymore

Awesome, LGTM. Thanks @timwindsor- will get this in!


Pass serviceDescription to createReferral

What
Pass in the service description when creating a new referral
Why
Resident email contained 'undefined' instead of service description, because of this bug

Makes me wonder: how did we miss that with find&replace?

Hmm, I think it was set wrong to begin with and without having the actual functionality in mind it was probably easy to overlook


proxy: Introduce no_proxy and kata_proxy implementations

This PR implements proxies for Kata Containers cases with and without proxy.
In order to achieve this, it slightly modifies the agent interface by adding two new functions.
Fixes #515 #516 #524

cc @sameo @jodh-intel

@jodh-intel @sameo PR updated.

lgtm but let's wait to see if @sameo has any comments.

A few comments to be answered/addressed.

@sameo PR updated.

LGTM


Error:Module 'com.badlogicgames.gdxpay:gdx-pay-android-googleplay:0.10.3' depends on one or more Android Libraries but is a jar.

Hi,
I am using the configuration suggested but Kees Van Dieren.
for my android project.
dependencies {
compile "com.badlogicgames.gdxpay:gdx-pay-client:${gdxPayVersion}"
compile "com.badlogicgames.gdxpay:gdx-pay-android:${gdxPayVersion}"
compile "com.badlogicgames.gdxpay:gdx-pay-android-googleplay:${gdxPayVersion}"
}
But getting this error.
Error:Module 'com.badlogicgames.gdxpay:gdx-pay-android-googleplay:0.10.3' depends on one or more Android Libraries but is a jar.
Kindly help.

Huh, same problem here, just wanted to create a topic.

I investigated this issue, and added Gradle instructions to the project README.md.
Instructions added to README.md:
Configure dependencies using Gradle
project-root/build.gradle:
ext {
    gdxPayVersion = '0.10.3'
}

core:
dependencies {
    compile "com.badlogicgames.gdxpay:gdx-pay-client:$gdxPayVersion"
}

android:
dependencies {
    compile "com.badlogicgames.gdxpay:gdx-pay-android:$gdxPayVersion"
    compile "com.badlogicgames.gdxpay:gdx-pay-android-googleplay:${gdxPayVersion}@aar"
}

ios:
dependencies {
    compile "com.badlogicgames.gdxpay:gdx-pay-iosrobovm-apple:$gdxPayVersion"
}

Adding the '@aar' suffix to the dependency is the right way to do it.
If you still think gdx-pay is doing it wrong, feel free to open a new issue.


Fix undeploy api intermittent error

Purpose

Fixes: https://github.com/wso2/apk/issues/1460

Codecov Report
Patch coverage has no change and project coverage change: -1.81% :warning:

Comparison is base (3adef64) 25.10% compared to head (1a96f25) 23.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   25.10%   23.29%   -1.81%
==========================================
  Files         260       66     -194
  Lines       30755     4279   -26476
  Branches     4830     2183    -2647
==========================================
- Hits         7720      997    -6723
+ Misses      22769     3282   -19487
+ Partials      266        0     -266

Flag
Coverage Δ

adapter
?

common-controller
?

config-deployer-service
23.29% <ø> (-0.08%)
:arrow_down:

idp-domain-service
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 195 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow buttons to be styled as selected.

Allow for button selection by adding a "selected" class and setting a macro flag.
Not sure if you want this change, but I'm going to use it in an upcoming session, so thought I'd share it anyway.
Basically I wanted the macro act as a toggle, and the UI of the macro manager to reflect its state.
I had to refactor how the buttons were rendered so that they would not have to be recreated after the macro was run.

Hi. You did nice changes. But, I'm not available to study and apply them. What do you think about take over this module?


Fix doc moving groups

add ability to move a record with an existing rank to a new group
refactor group rank test and test helper to create docs
refactor ranking method and group insert test
add test cases for inserting at top and end in new group
refactor Paragraph1 -> GroupedParagraph to avoid constant rename warnings

Hey, this looks like a great change! Would you mind upstreaming it to the main repo?

Hey @richardboehme! Thanks for making this!
The intention was to contribute back, just hadn’t gotten around to it 😅 You can probably expect more in the future.

Sorry @bookis I didn't mean to rush you on this! 😅 I'm really looking forward to future contributions!


GSsoC: Shorten URLs is not working

Even if we are trying to generate the Shorten version of the URL it is not responding anything so i will fix the bug to respond in such a way that it can provide the shortest version of the URL

Discuss your approach clearly, and mention everything with a proper timeline and tech stack. Go through #24

As i will solve the bug to provide a shortest version of the URL with the Tech stack as ReactJs as we no need of backend in this cause using a component i will be creating a shortest version of the URL and i have completed the #24 process

What will be the domain of the generated URL?
Backend URL or Frontend URL?

The domain will be backend

The domain will be backend and it would be display via passing the data from the backend

So you have to make the server from scratch. Are you ready to do that?

You mean the backend of the entire website

Oke I will do @Swarnendu0123

@Swarnendu0123 I have a doubt whether the shortened URL is alone enough or we need to create such that when we click that link we need to redirect to that link please clear me thiss

We just need to redirect it.

@Swarnendu0123  ok got it

@Swarnendu0123 can you provide me time till Monday as I have my sem exams going is that fine for you

@Swarnendu0123 i have raised the PR for the Assigned Issue please check through it and frontend is not at all working properly as everyone is just trying to make it attractive but it is not responsive in regrad to that i have added the link.tsx page where i have altered depending upon my Server(Backend) code please check through and make it responsive Thank You For this chance to improve my knowledge

@Swarnendu0123 Sir actually due to the changes in the ui the code has jumped to 6000+lines so after fetching it I will try to change it can I give one more shot for implementation of backend

Feel free to raise another.

@Swarnendu0123 whether should I raise an issue or a PR

@Swarnendu0123 oke I will request for another one

Please discuss your changes on the specific PR that you have created. Don't write here and there. Does this issue have any relation with that PR? No right. Then why are you writing this here,
Secondary, you have mentioned me in every comment. Don't do that, it doesn't look good. You have commented, we will see according to our timings. You don't need to tag maintainers aggressively.


refactor: remove meta's dependency on sink implementation to reduce compile time

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Move the implementation of all sinks to a separate crate. The original risingwave_connector is splited into 3 crates: risingwave_connector, risingwave_sink_impl and risingwave_connector_common, where risingwave_connector and risingwave_sink_impl both depend on risingwave_connector_common, but they don't depend on each other.
Originally, risingwave_meta depends on the whole risingwave_connector, in which case it should wait for the long compilation of the whole risingwave_connector. After this PR, the risingwave_meta only depends on a much smaller risingwave_connector with sink implementation removed from it, and risingwave_meta can start its compilation much earlier.
The risingwave_meta depends on the coordinator and validation logic of each concrete specific sink implementation, which was a reason for risingwave_meta to inevitably depend on the logic in current risingwave_sink_impl. This PR decouples risingwave_meta with risingwave_sink_impl by exposing the functions for coordinator and validation logic as extern functions in risingwave_meta, so that the coordinator and validation logic is connected to risingwave_meta at the final link time.
Below is an example to handle the validation logic.
In risingwave_meta,
extern "Rust" {
    fn __exported_validate_sink(
        prost_sink_catalog: &PbSink,
    ) -> BoxFuture<'_, std::result::Result<(), SinkError>>;
}

pub async fn validate_sink(prost_sink_catalog: &PbSink) -> std::result::Result<(), SinkError> {
    unsafe { __exported_validate_sink(prost_sink_catalog).await }
}

In risingwave_sink_impl
#[export_name = "__exported_validate_sink"]
pub fn validate_sink(
    prost_sink_catalog: &PbSink,
) -> BoxFuture<'_, std::result::Result<(), SinkError>> {
    ...
}

Before this PR

After this PR

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

I would suggest the approach below:

Actually for the suggested approach, we don't need to define an extra trait. A Box<dyn Fn(&PbSink) -> BoxFuture<'_, Result<()>>> is enough, which is very similar to current implementation. The only difference is the stage to inject the function pointer to the function entry point defined in the common crate. The current implementation injects the function pointer at link time, while the suggested approach injects the function pointer at the initialization of runtime. If we forget to declare the function pointer injection, in the current implementation we will get an link time error, while the suggested approach will get the error at runtime when we attempt to call the function. Both approaches LGTM.

The risingwave_connector and risingwave_connector_common are merged back together. There seems no need to split them. The newly added risingwave_sink_impl is now depending on risingwave_connector.

It seems that under the current implementation, some test binaries that implicitly introduces the dependency on risingwave_connector will fail to be built if the risingwave_sink_impl is not included in the dependency, even though the methods are not used, which is not a good develop experience. I've changed to use the suggested approach that injects the function pointers at init time.

Can you update the PR description to reflect latest changes?

My thoughts: I don't think the extern way is that hacky, since at the end of the day we are always doing linking.. Actually #[ctor] looks even more magical to me 🤡

Actually, I'm unsure if it's totally safe to call an extern "Rust" fn as it's marked as unsafe. For example, does lifetime checker still work in this case?

Actually, I'm unsure if it's totally safe to call an extern "Rust" fn as it's marked as unsafe. For example, does lifetime checker still work in this case?

The lifetime checker only checks the function interface and does not couple the function declaration and implementation, so if the extern fn is declared in the same signature as its implementation, I think it's safe.
The reason for marking extern fn as unsafe might be that, the linker links the object file by symbol and has no way to do any type check. So it will be unsafe if the extern fn declaration is of different signature as the its implementation.

Actually, I'm unsure if it's totally safe to call an extern "Rust" fn as it's marked as unsafe. For example, does lifetime checker still work in this case?

The lifetime checker only checks the function interface and does not couple the function declaration and implementation, so if the extern fn is declared in the same signature as its implementation, I think it's safe.
The reason for marking extern fn as unsafe might be that, the linker links the object file by symbol and has no way to do any type check. So it will be unsafe if the extern fn declaration is of different signature as the its implementation.

Get it. This makes much sense!

Any updates? Saw lots of conflicts 🥹

Just merged main and resolved conflicts? @wenym1 can you take a final look and let's merge it?

Besides, with this PR the code is less organized because we introduce a tricky hack, and the original crate is actually split at a unclear boundary.

Maybe we'd better seek for other ways to split the code.
https://materialize.com/blog/engineering/compile-times-and-code-graphs/

For each unit of business logic foo, separate crates for:

Types: for Plain Old Data, protobuf, traits that users of foo implement, etc.
Interface: for the public API without an implementation. Foursquare called this FooService. Materialize calls it foo-client.
Implementation: for the implementation of the public API. Foursquare called this FooConcrete. Materialize calls it foo.
Note that not every foo will have all three of these, and some will be more complicated, but I’ve found these three to be a reasonable default.


Remove shortcut info

closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/8855
confirmed with product team that this is now the default behavior and also reproduced.

@dstrome PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@dstrome @tiburd Can you help me with the review and merge? thanks

@dstrome Can you help me with the review and merge? thanks


using file scoped namespace

Thanks, @ali50m! I appreciate the consistency. Not sure how I missed that. 🤔


Woutermeek/upstream

https://jenkins.code.rdkcentral.com/job/github-triggered/215/ started

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: mipo57:x: woutermeek:x: pwieldersYou have signed the CLA already but the status is still pending? Let us recheck it.


Updated Macro Info

I have included the selector! macro as well, covered about what it does and with an example of it.

@Akashneelesh you need to rebase on main to bring the changes from your previous PR. Or just discard changes related to the previous PR

@Akashneelesh you need to rebase on main to bring the changes from your previous PR. Or just discard changes related to the previous PR

I'll correct it and do the change right now

I'll close this, as I done the changes on to the main branch and have created a new pull request which does not have any conflicts

fwiw, it's best to not open new PRs even if you have conflicts - you can just discard the previous commits and only pick the one you want, and force push your branch


Reset cartographer state during runtime of cartographer_node

Hey,
Is there a way to reset cartographer node state without restarting the process(during runtime)?
(Reset the map)
Thanks

I'm not entirely sure what you mean, but it could be related to something I want to implement:
Control over deleting and loading states during runtime, as proposed here: https://github.com/googlecartographer/rfcs/pull/41

Restart all data related to cartographer(Map, Landmarks, subsmap etc)  just like restarting the process of cartographer node, without loading a pbstream file

Completely resetting everything is currently not supported. My draft goes into this direction but is also not finished.
Regarding destruction, there was a similar request but it was not merged into master. You can follow up here: https://github.com/cartographer-project/cartographer/pull/1446

Does the master version of cartographer is compatible with that version of cartographer_ros?

Nope. Only file backwards compatibility for pbstream.


No ceph scrubing ?

I'm currently not aware of any ceph scrubbing jobs in our installation.
We might look at https://github.com/SamYaple/CephScrubManager/blob/master/csm.py  to implement this ?

@BjoernT I thought ceph did scrubbing automatically as part of it's own housekeeping activities?
http://docs.ceph.com/docs/v0.71/rados/configuration/osd-config-ref/#scrubbing
Seems to suggest light scrubbing daily, and deeps scrubbing weekly. There are tunables, of course, which may need to be tweaked per installation depending on requirements, but as far as a scrubbing 'job', I'm not sure we need one?

I have not seen any scrubbing inside my ceph cluster yet, that's why I'm looking into it.

If ceph has built in scrubbing functionality I would much rather use that.  I would like to avoid as many third party plugins as possible.

@BjoernT Any more information available on this?

Still researching.  I can not find any definitive docs when and how scrubbing is performed buy ceph ods/mons just the configuration

@bjoernt @d34dh0r53 the doc I linked shows that the default intervals are daily (light scrubbing) and weekly (deep scrubbing). The time of day, load at time if scrub etc are all configurable, but by default you're going to get a daily scrub at midnight, and weekly deep scrub at the same time.
The ask in the bug was to schedule a scrubbing job, which we don't need to do based on the above

Yes seems alright I saw it via ceph pg  dump |awk -F'\t' '/[0-9a-f]+./ {print $1 " " $19}'
We might still run into issues that the scrub degrades the performance at midnight GMT so we probably want to configure this time since 0GMT is quite often production time for customers

By default the scrubbing is scheduled to happen during a window, the default being anytime, and not at midnight. Scrubbing does not occur if the load is higher than 0.5. Currently the ceph.conf template does not support all the configurable scrubbing options [1] and so will need to be updating to support the additional configurability.
[1] https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-common/templates/ceph.conf.j2

Yes i'm working upstream to get this option in

https://github.com/rcbops/rpc-openstack/issues/702


python312Packages.noisereduce: init at 3.0.2

Adds the noisereduce
I have tested that the library works using rvc-cli
Closes https://github.com/NixOS/nixpkgs/issues/351989
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 359500

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.noisereduce
python311Packages.noisereduce.dist
python312Packages.noisereduce
python312Packages.noisereduce.dist

@fabaff
Upstream tests does not assert anything. Also adding pytest to nativeCheckInputs runs nothing.
I have tried to manually run the tests:
checkPhase = ''
  ${python3.interpreter} ./test_reduction.py
  ${python3.interpreter} ./test_environment.py
'';

But it spitted out a numpy error:
error: builder for '/nix/store/2pycxzfi9683a3aczzq3cdvvc3bdm0iq-python3.11-noisereduce-3.0.2.drv' failed with exit code 1;
       last 25 log lines:
       >     https://numpy.org/devdocs/user/troubleshooting-importerror.html
       >
       > Please note and check the following:
       >
       >   * The Python version is: Python3.12 from "/nix/store/px2nj16i5gc3d4mnw5l1nclfdxhry61p-python3-3.12.7/bin/python3.12"
       >   * The NumPy version is: "1.26.4"
       >
       > and make sure that they are the versions you expect.
       > Please carefully study the documentation linked above for further help.
       >
       > Original error was: No module named 'numpy.core._multiarray_umath'
       >
       >
       > The above exception was the direct cause of the following exception:
       >
       > Traceback (most recent call last):
       >   File "/build/source/./test_reduction.py", line 1, in <module>
       >     from scipy.io import wavfile
       >   File "/nix/store/0z1hpjr0zia6j7jfvqnarl29xds1vyk2-python3.11-scipy-1.14.1/lib/python3.11/site-packages/scipy/__init__.py", line 47, in <module>
       >     from numpy import __version__ as __numpy_version__
       >   File "/nix/store/8wjbya484hndj9vwlpkklnja6bi1f0ng-python3.11-numpy-1.26.4/lib/python3.11/site-packages/numpy/__init__.py", line 135, in <module>
       >     raise ImportError(msg) from e
       > ImportError: Error importing numpy: you should not try to import numpy from
       >         its source directory; please exit the numpy source tree, and relaunch
       >         your python interpreter from there.
       For full logs, run 'nix log /nix/store/2pycxzfi9683a3aczzq3cdvvc3bdm0iq-python3.11-noisereduce-3.0.2.drv'.
error: 1 dependencies of derivation '/nix/store/1ppiwhf2a3mfh6qb8wp1h8vz5vkwny76-review-shell.drv' failed to build


Find GCD of two floating point numbers

Do the checklist before filing the issue:

[x] Do you have Node.js and all the relevant dev-dependencies installed?
[ ] Is this a bug fix?
[x] Is this an enhancement?
[ ] Is this a feature request?

NOTE: Provide a clear and concise description of the feature that needs to be added! Or if its a bug, then provide the necessary steps to reproduce it along with screenshots.

Give your answer below:
Input: For a = 5.60 b=2.25 gcd(a,b)
Ouput: 0.05

@sakshichahal53 implement it inside the existing gcd module

I would like to grab this issue @pbiswas101 .

@sakshichahal53 since you haven't made any PR related to this issue during the last 3 weeks I'm assigning this issue to @pydevsg

@pydevsg your time's up

@pbiswas101

@harsha-iiiv you're assigned

@harsha-iiiv you're assigned this issue and not #199

Actually, I had created 'union function' before I created issue #199 .

@harsha-iiiv your time's up for this issue

I would like to work on this issue.

I believe I have implemented this enhancement, though it only works with a predefined number of decimal places and is limited by Number.MAX_VALUE. May I please be assigned to this issue?

@Brendo64 you're assigned

I would like to work on this issue


Fix IE overflow

Fixes https://github.com/twbs/bootstrap/issues/29622
Demo https://jsfiddle.net/84qo07hg/1/embedded/result,css,html,js

Personally I cannot reproduce on the v4 docs nor on master docs with IE 11.
If you reproduced this on BrowserStack, please let me know.

https://jsfiddle.net/j0nfor3v/ on IE via Browserstack:

Fix:

We don't have a 0% width example in our docs.

Can you make an updated fiddle with the fix?

Can you make an updated fiddle with the fix?

It's in the PR description: jsfiddle.net/84qo07hg/1/embedded/result,css,html,js


Read only Extension hides some useful stuff and does not hide all create buttons in horizontal community layout in german

Many buttons still visible, content creation still possible while e. g. links to wiki pages in rich text widgets on community homepages are hidden.
Please correct this useful feature ASAP, it could actually help doing a seamless migration!

@andrehagemeier please have a look

Without extension:

With extension:

Create links stay usable:

The idea of the widget is great - but the current code state is not really usable.

Hi Bernd,
thanks for letting us know but with the Cloud going EOS in a couple of days, we don't think it is extremely urgent to fix this problem. We would rather  discuss a proper readonly mode at a later time.
Thanks
Andre


Literal expressions with i32 only

Modify code to accept all numeric type

f32 by default. "Implicit" conversion are done from i32.


Support disabling / hiding editor actions (icons at the right of tab bar)

#669 is closed, but not sure about the solution.

Please can it be (default maybe) switched off easier?
Its totally unusable like this, and the last comment : https://github.com/eamodio/vscode-gitlens/issues/669#issuecomment-713133732 is incorrect, because I have "Bookmarks" extension which does add to the dropdown menu:

i have no idea why it has been appended twice, but even without the duplication, its like 4 icons more intruding on my tab bar

Run GitLens: Open Settings from the command palette and jump (or scroll) down to the Menu & Toolbars section. There you have full control to all of GitLens' menu contributions.


WshShell.Exec: Access is denied.

hi
I have a problem in  installing
on this command :
$  configure
error :
c:\php-sdk\phpmaster\vc15\x64\php-src\configure.js(164, 2) WshShell.Exec: Access is denied.
And  with this command :
$ namek
NMAKE : fatal error U1064: MAKEFILE not found and no target specified
Stop.

Thanks for the report. It is not related to the binary SDK, these commands belong to the PHP core. It seems that WSH is blocked on your system, that's what needs to be fixed. In further, please report the core bugs on bugs.php.net
Thanks.


Add brotli compression for data uploading

Brotli can decrease the data size by about 50%, we can do this in both the client ("brotli") and the server (python brotli binding). As brotli is used by dropbox and others, its performance is actually optimized for this use case.

I think this is not so relevant because we are not compressing text or html but just (mostly non repeating) numbers and therefore a dictionary (especially a predefined one for text and html) does not help much?

also the data that is transfered is already quite small, right?

I was thinking we could use this for the initial data upload by the user, which can be arbitrary large. Using a compression method here (be it gzip or brotli) would lower the number of requests necessary, because we can only submit about 1000 data points per query.
Data compression can reduce the size of our query, because we're sending ASCII-encoded strings, containing the numbers. Any compression method will therefore reduce the size of our string.
If we were only using numeric parameters, we could simply send the data binary-encoded, which would probably the most efficient and effective way to "compress" them. But since we're also transmitting factorial parameters, I chose to use ascii-string-compression instead.
I chose brotli for this, because I heard of it recently and thought it is the new and best compression method availiable: "Brotli decompression is at least as fast as for gzip while significantly improving the compression ratio."
But: "The price we pay is that compression is much slower than gzip."
(source)[https://www.opencpu.org/posts/brotli-benchmarks]
I didn't know about that. I think it's still useful to keep compressing data when the user wants to upload more than say 1000 data points. But I think we should be using a different compression method.

I was also thinking, that there are two server endpoints for this /upload and /upload_compressed or something like this. We then could decide on the package side which method to use.
Another thought: We could also use something like BSON, which is basically a binary encoded JSON variant. We could still use strings for the factors but would profit from binary-encoded numbers.

While everything might be a nice to have they do not contribute so much to the essential feature set of this software. So you can implement all you want but keep in mind that things like documentation and tests etc. are more important for the user in the beginning.
Don't spend to much time on corner cases (aka. 1000 data points in the initial design)

You're right, but this is actually quite easy and mostly done in the brotli-branch.


plt.show() not working?

I find that plt.show() is not working for mplopengl, even with plt.ion(). Is this a feature or bug? I can use plt.pause() temperorily instead.
import matplotlib
# matplotlib.use("Qt5Agg")
matplotlib.use('module://mplopengl.backend_qtgl')
import numpy as np
from matplotlib import pyplot as plt
sample_size = 100000
X = np.linspace(100079, 100090, sample_size)
Y = np.random.random(sample_size)

fig, (ax1) = plt.subplots(1, 1, sharex=True, sharey=True)

ax1.plot(X, Y, linestyle='solid', marker='*')
plt.ion()
plt.show()
# plt.pause(30)
if __name__ == '__main__':
    pass

This seems to have been fixed at some point. At least the example works fine now. (sorry for the late response).


Installer for ss3?

Yeah. You are right about that.
What I am looking for is a zip file that puts the exe into a specific folder and has a script that can be run to modify PATH to refer to that folder.
Originally posted by @Rick-Methot-NOAA in https://github.com/nmfs-stock-synthesis/doc/issues/91#issuecomment-1025972852

To me, this does sound worth exploring.
ADMB has an installer, of course; I wonder if we could use something similar. If I'm remembering correctly, no admin privilegesare needed to download ADMB?

This can be subsumed into https://github.com/nmfs-stock-synthesis/stock-synthesis/issues/449.


compressor in v1?

hello,
it looks like you removed the compressor in the v1 version - any chance or plan to get it back for v1 too?
best wishes - hexdump

yes I will put it in the next update.  It is less used so I wasn't worried about getting it out immediately.
Thanks.

cool - that sounds good and promising :)

It is released!

perfect - thanks a lot!


Allow components to have multiple content areas

First of, this library looks awesome and I can't wait to start using it :)
Something that would be really nice is the ability for a component to have more than one output area, or "outlet" (for lack of a better term). Essentially, the idea is very similar to using yield(:foo) and content_for(:foo) in normal Rails views.
Often, the dynamic content within a component cannot be declared within a single block. One example is a modal window that has a title, body, and row of buttons:

This would be a really cool way to render this modal with a title (static string), body (block), and footer (block). The block could now be passed an instance of the component (or perhaps something like component builder) which could act to capture explicitly named blocks:
<%= render(ModalComponent, title: 'Are you sure?') do |modal| %>
  <%= modal.body do %>

This is some content that would go in the modal body.

  <% end %>

  <%= modal.footer do %>
    <%= link_to 'Cancel', '#', class: 'btn btn-secondary', data: { dismiss: :modal } %>
    <%= button_to 'Confirm', confirmation_path, class: 'btn btn-primary' %>
  <% end %>
<% end %>

The component template might look something like this:

<%= title %>

      <%= body %>

      <%= footer %>

I think this would make components far more flexible, and allow us to write less repetitive markup when using the components. Without something like this, the developer must remember to include
 and
 whenever the component is used:
<%= render(ModalComponent, title: 'Are you sure?') do %>

This is some content that would go in the modal body.

    <%= link_to 'Cancel', '#', class: 'btn btn-secondary', data: { dismiss: :modal } %>
    <%= button_to 'Confirm', confirmation_path, class: 'btn btn-primary' %>

<% end %>

The need to wrap content in these classes feels like an implementation detail that should be the responsibility of the component itself.
Now, this one occurrence might not seem so bad. But imagine this pattern repeated many, many places in the application. Developers must remember to mark up the content within the block in a specific way (thereby "leaking" some of the internals of the component), which can result in mistakes and make the code more difficult to maintain.
If there's support for something like this, I think the next step would be to discuss the API and syntax for outlets. I'd be happy to hack on this if there's interest!

@kylefox this is fantastic. I love the proposed API.
I'd love to see even a draft PR that takes a crack at this. I'm also happy to chat this through / hack on it together<EMAIL_ADDRESS>

@joelhawksley Cool :)
Do you think it's worth distinguishing attributes (like title:) and outlets (like modal.body) as distinct concepts?
After posting my initial comment I began wondering if the two mechanisms for providing content to the component could be used interchangeably:

<%= render(ModalComponent, title: 'Are you sure?') do |modal| %>
  <%= modal.body do %>

This is some content that would go in the modal body.

  <% end %>

  <%= modal.footer do %>
    <%= link_to 'Cancel', '#', class: 'btn btn-secondary', data: { dismiss: :modal } %>
    <%= button_to 'Confirm', confirmation_path, class: 'btn btn-primary' %>
  <% end %>
<% end %>

<%= render(ModalComponent, title: 'Are you sure?', body: 'This is some content that would go in the modal body.') do |modal| %>
  <%= modal.footer do %>
    <%= link_to 'Cancel', '#', class: 'btn btn-secondary', data: { dismiss: :modal } %>
    <%= button_to 'Confirm', confirmation_path, class: 'btn btn-primary' %>
  <% end %>
<% end %>

As I begin mapping our existing application to components, in some instances the content is a simple string, and in other cases it's more complex HTML. An example might be help text that appears below a form input — in many cases a simple string is all that's required (which parameters work well for) but occasionally we need to insert a couple paragraphs, or a link, etc. (which blocks work well for). The ability to use either interchangeably would give us the flexibility to use the same component in both scenarios.
(We could of course use the block syntax everywhere for the help text, but the syntax is a lot more clunky — if the content is a simple string most of the time, parameters would be preferred).
On the other hand, maybe conflating attributes and outlets increases cognitive overhead for developers, and technical complexity internally?
You have far more experience using components than me, so I'd love to hear your take on this.

I love the interchangeability, since you're right that sometimes you might just want to pass a string while other times you might want to pass a whole block.
Also, given that we are going to support rendering components in controllers, where having a block argument with ERB in it is unlikely to work, having the option to set content via a content param would be really convenient!

This is great. What do you think the component code would look like? Just the normal
attr_accessor :title, :body, :footer

or something else?

@mellowfish Yeah, exactly — I was thinking that it'd be much simpler for developers if the API for specifying attributes and blocks was the same. And it especially makes sense if attributes/blocks can be used interchangeably.
However, validation might complicate things significantly 😕
Consider the example from the README:
class TestComponent < ActionView::Component::Base
  validates :content, :title, presence: true

  def initialize(title:)
    @title = title
  end

  private

  attr_reader :title
end

Also from the README:

Components are validated after initialization, but before rendering.

So from what I understand, the component would fail validation if used this in way:
<%= render(TestComponent) do |component| %>
  <%= component.title do %>

Hello, World!

  <% end %>
<% end %>

I'll have to dig into the guts more to understand how validation is happening, and what the consequences might be if validation was performed after rendering. I don't think block content can be validated until the component is fully rendered.
It would be really nice if we could validate block content, but that might necessitate deeper changes than we're willing to make right now. Perhaps V1 of this API doesn't support validations, and the workaround is for developers to not validate attributes that are intended to be used as blocks?

Would an API like content_for be a more natural fit and parallel to existing Rails patterns?


Add operator to Alert Condition

Problem to solve
Right now, spec.condition doesn't have an operator (ie, "gt", "gte", "lt", etc) for the threshold.  We should add that in order to be more specific about the alerting.

Created #167 for this enhancement.  Review at your leisure.
Prost! 🍺

Thanks @fearfactor3 !

This issue should be closed now.  It was merged into main.

Closing per above


Meson: Replace tabs with 4 spaces.

Get rid of tab-based indentation and use 4 spaces, consistent with the rest of the project, instead.

Alternative view of the change, ignoring whitespaces: https://github.com/opendcdiag/opendcdiag/pull/203/files?w=1


UIWebView used in pod 'IQKeyboardManager', '~> 6.2.0' Deprecated

it appears we are using an older version of the IQKeyboardManager pod which includes UIWebView and is throwing warnings for users.
See this issue issue and this comment for details
I see this in code
# bumping beyond 6.2.0 (to at least 6.5) will break the next button for TextFields (not for TextViews)
pod 'IQKeyboardManager', '~> 6.2.0'

Guess we'll have to choose the lesser of the two evils or find a workaround.

Sounds like a valid assessment.


EarthDataDownloader object to retain user login credentials

Description of the desired feature: Functionality added so that login credentials are retained by the EarthDataDownloader object after first inputted, and therefore the user does not have to keep re-defining them for each download.
In the tutorials, there is repeated EarthData login requests. For example, in the 3D_stack tutorial:
measures_shelves = fetch.measures_boundaries(version="IceShelf")

Also, there is nothing in your documentation on how to define credentials as environment variables (the icepack link in the API reference for EarthDataDownloader is broken).

If you're not familiar with it, I strongly recommend earthaccess. It's a great way to manage Earthdata logins. The library I maintain, icepyx has it set up as an authentication MixIn class so the credentials are accessible from any module that needs them but only asks users for them once.

Thanks for the suggestions! I had a look, but I'm not sure if this will work here. polartoolkit uses pooch to download the datasets. For the NASA data, pooch requires the earthdata username and password to be entered into the download call. Looking through earthaccess, I couldn't see a way to return the username and password values to pass to pooch. Maybe I missed it, is there  a way to do this?
For now, I've kept it as is, but added better documentation for how to set temporarily or permanent environment variables so users don't need to continuously supply the login credentials.

For now, I've kept it as is, but added better documentation for how to set temporarily or permanent environment variables so users don't need to continuously supply the login credentials.

I think as long as it is well documented then this is enough to resolve the issue

Ok that sounds good to me, I'll close this as I've added better documentation in #212 in this how-to guide.

Looking through earthaccess, I couldn't see a way to return the username and password values to pass to pooch. Maybe I missed it, is there a way to do this?

It's not part of the user api (and probably not documented), but with an earthaccess Auth object (created with myauth = earthaccess.login()) you should be able to get them with myauth.auth_environ() (or possibly myauth.auth.auth_environ()).
As @PennyHow noted - not required for JOSS, but wanted to follow up and answer your question!

Ahh great! Thanks for finding that, this is working to access the credentials: earthaccess.auth_environ().
I'll add this into PolarToolkit to replace the custom class I had.


Epic: Dynamic fees

We started implementing something similar.
The fees would be dépendant on:

User Trasaction volume (/month)
Affiliate program

I think a discussion here would be benefitial.

See also linked issue https://github.com/rubykube/peatio/issues/663


Added prettier in Javascript

Added prettier in Javascript

https://github.com/prettier/prettier
**Prettier is the neat formatting and auto correct tool for you JS. Extentable and on link with ES Lint it will autocorrect all the basic issues **
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

I have read and understood the contribution guidelines and the instructions for creating a list.
This pull request has a descriptive title.For example, Add Name of List, not Update readme.md or Add awesome list.
The entry in the Awesome list should:

Include a short description about the list project/theme. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell.
Be added at the bottom of the appropriate category.

The list I'm submitting complies with these requirements:

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
The repo should have the following GitHub topics set: awesome-list, awesome, list. I encourage you to add more relevant topics.
Not a duplicate.
Includes a succinct description of the project/theme at the top of the readme. (Example)
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Has the Awesome badge on the right side of the list heading,
Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

Each link description starts with an uppercase character and ends with a period.Example: - [AVA](…) - JavaScript test runner.
Drop all the A / An prefixes in the descriptions.
Consistent naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

This is an awesome list of awesome lists, so you would want to put that in awesome-javascript or something.


The menu appears much bigger in File > Open Recent

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Latest
OS Version: Windows 11 Up-to-date

Steps to Reproduce:
Make it like the HTML marquee element with the behavior of scroll.

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!


Add contributing and issue template

This adds a contributing guide and an issue template to this project. My main intent here is to help avoid unnecessary duplicate issues be filed, such as the problem reported in Issue #20. I can see future use cases where both the contributing guide and issue template can be expanded to serve additional present or future use cases.
I hope this helps.

Thank you for this. I’ll refuse it because it does not conform well to my style, and from my experience on homebrew-cask it’ll need to be a bit more explanatory/forceful.
I wrote and iterated on most of the templates at HBC, and am finding something closer to that style is what works best, so I’ll follow it here as well.
But thank you nevertheless! I appreciate the PR.


browser context menue

Hi - Is it possible to assert items are present/not present in the browser's right-click context menu?

Hi Michael,
Unfortunately we have no access to browser's context menu from javascript due to browser limitations, so TestCafe has no this functionality


Build failure: stalwart-mail

Steps To Reproduce
Steps to reproduce the behavior:

build stalwart-mail

Build log
[...]
   Compiling indicatif v0.17.8
   Compiling rpassword v7.3.1
   Compiling clap v4.5.7
   Compiling pop3 v0.8.2 (/build/source/crates/pop3)
   Compiling managesieve v0.8.2 (/build/source/crates/managesieve)
   Compiling human-size v0.4.3
   Compiling tests v0.1.0 (/build/source/tests)
   Compiling stalwart-cli v0.8.2 (/build/source/crates/cli)
   Compiling mail-server v0.8.2 (/build/source/crates/main)
thread 'main' panicked at cargo-auditable/src/rustc_wrapper.rs:101:39:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: could not compile `mail-server` (bin "stalwart-mail")

Additional context
Add any other context about the problem here.
Notify maintainers

@happysalada @onny
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-linux"`
 - host os: `Linux 6.6.31, NixOS, 24.11 (Vicuna), 24.11pre-git`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/nix/store/qqwr649pc0qprc9lw2fmdsi1km6p7q2h-source`

Add a :+1: reaction to issues you find important.

Hydra was able to build it, so the problem might be that the machine has not enough memory


[Feature] Alias for combinations

Hi, thanks for this awesome project, I just discovered and I'm feeling that it's super great at this stage and I'm excited for it's future. There is this feature I would like to know if it's possible.
I have a hyper key (ctrl+alt+shift+cmd) that I would like to define so I can do hyper-c instead of defining the all 4 modifiers in every definition of a combo.
Thanks!

Hi,
the issue is reasonable, but it's a minor priority for me. I myself will be occupied with more major issues.
The currently existing key-notation-to-key-code syntax in the config can be reused:
[key-mapping.key-notation-to-key-code]
hyper = 'ctrl-alt-shift-cmd'

[mode.main.binding]
hyper-c = 'workspace c'

Hi,
the issue is reasonable, but it's a minor priority for me. External contributions are welcome.
The currently existing key-notation-to-key-code syntax in the config can be reused:
[key-mapping.key-notation-to-key-code]
hyper = 'ctrl-alt-shift-cmd'

[mode.main.binding]
hyper-c = 'workspace c'

Has this changed since your reply? Doesn't seem to work for me:
Failed to parse /Users/gldtn/.config/aerospace/aerospace.toml

key-mapping.key-notation-to-key-code.hyper: 'ctrl-alt-shift-cmd' is invalid key code

mode.main.binding.hyper-b: Can't parse modifiers in 'hyper-b' binding

Thanks!

@gldtn It's not a implemented feature yet.
@nikitabobko only suggested that the already existing config key (key-notation-to-key-code) can by used should anybody implement that feature.

@gldtn It's not a implemented feature yet.
@nikitabobko only suggested that the already existing config key (key-notation-to-key-code) can by used should anybody implement that feature.

I see, I miss understood his reply. Thank you!

I know this is not the solution proposed by @nikitabobko but I don't think there's a need for anything more than hyper and meh modifiers. So I created #389 to have the feature request done.

Any progress on this. Would be an awesome feature.

I would also appreciate this feature. Any chance we could get it implemented?
I tried the solution here and I guess that's still not implemented.
I use the Hyper and Meh keys a thousand times a day, so I'd really appreciate this feature!

is this still working for you @vvvctr ?
With  0.15.2-Beta, I cant seem to bind to super keys at all

I cant get this example to work:
alt-shift-cmd-ctrl-1 = 'workspace 1'
Any ideas? (0.16.2-Beta 21336ad382539b35fdc94b4fbd55408e10b101f8)


indent-tabs-mode re-enabled in Makefiles??!?!?

WHY?!!??!??!??!!11?!??!11/!!1

Rest in peace.

Sad. It turns out that disabling indent-tabs-mode causes tabs to magically get converted into spaces when typing things after them, which makes no sense. So we need to fix the problem in a different way.

Or we could not do this.


DD-707: Replace dans-dataverse-scala-lib dependency with dans-dataverse-client-lib in dd-workflow-step-vault-metadata

Fixes DD-707
Description of changes

added new constructor in ControlledSingleValueField class
added checkConnection method in DataverseClient
added Version enum class

How to test
Related PRs

https://github.com/DANS-KNAW/dd-workflow-step-vault-metadata/pull/1

Notify
@DANS-KNAW/dataversedans

@vesaakerman : I am closing the PR. Instead, I have changed the constuctors of the Controlled and Primitive fields (the parameter multiple didn't make sense, as the name of the subclass already indicated whether it was multiple or single).
Version was not used and also we cannot make that an enum if we are going to use it, because where a version is expected you should also be able to put 1.0, 2.1 etc. I propose we don't introduce a class for this and just keep using string values.
I know checkConnection was part of the Scala-lib, but on hindsight I think it is rather ugly. The client code can just use dataverse("root").view() itself, if it needs to check the connection.


Use build ID from VSTS as build number

My builds are hosted on VSTS. I see how to override the build ID on VSTS with build number (git height) calculated by NB.GV.
However I want to go the other way around. How do I configure my version.json file to use the build ID environment variable (Build.BuildId) as the build number (instead of the git height)?

That goes contrary to a tenet of nb.gv, which is reproducibility of builds and versions. Why would you want this?

Yes. I read that one of your motivations was the exact opposite. Our case was to pull this information out of a crash dump and get back to the exact build. However I think we should be able to do it using the git commit id.

Thank you for the use case info.


Added Squish and updated NoisyLines.

Some examples of Squish augmentation's output:
Without lines:

With lines:

In both horizontal and vertical direction:


updating appsFlyer version for ios

@danielgomezrico - Pls review, this should fix the appsFlyer version issue with this library
https://github.com/la-haus/flutter-segment/issues/69

@danielgomezrico @juansoos when are you planning to release this?


chore: release rc--2024-09-26_01-31

In draft because we are awaiting the qualification of ubuntu24 feature build and the no-canister-snapshots backup


ERROR CONNECTING KEEPASS TO KEYANYWHERE

this issue is happening when i am trying to simply connect to my google drive account the webpage show response that the authentication is successful but the keepass show following error. Kindly Help me solve the Issue.

Is there any official support available like email address or something?

No, you're in the right place. You'll have to wait for @Kyrodan or someone else more knowledgeable to take a look at it. I don't recognize that error. The error message mentions the token being expired, but you just did the authorization a second ago. Is your system date/time off? Have you tried with another provider?

It is working great with one drive as i set after this . This issue only with Gmail.


use Buffer.compare if it exists

Looks like this got trashed in the merge.  Probably easier to just re PR it.

oh sorry i lost this line! good catch

added you as a collaborator. thanks for you work!
https://github.com/soldair/node-buffer-compare/blob/master/CONTRIBUTING.md


Simplify TryStreamExt using codes in join executor,

Remove map(Ok) and simplify the codes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 20 (90.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.006%) to 98.795%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/executor/join.rs
18
20
90.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.006%

Covered Lines:
39595

Relevant Lines:
40078

💛  - Coveralls


Add partial support for VirtualDNS analytics

We are implementing a Prometheus exporter for our internal monitoring tooling and want to monitor Virtual DNS metrics. For this use case, general metrics are sufficient right now which is why we didn't add dimensions or filters. However, we still wanted to contribute our changes in case they help somebody.

Looks great, thanks for your contribution, and I apologize for late response. 🐢


Server not respecting rootPath/rootUri

I'm using the server with coc.nvim and configured it properly but it seems it's not respecting rootPath/rootUri to derive the correct cwd when opening a file from command line with nvim src/Main.purs, the cwd gets set to <cwd>/src. I can avoid the issue if I open nvim first, and then :e src/Main.purs.
See this for more details

I'm a little confused on this one, so I'm closing it.


[Delta][WIP] FSCK With missing DVs support

Which Delta project/connector is this regarding?

[X] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[ ] Other (fill in here)

Description
Resolves  #3436
This is the second out of the two implementations for the FSCK REPAIR TABLE command. The other implementation is available at https://github.com/delta-io/delta/pull/3499. While the first implementation only addresses missing parquet files, this implementation also addresses the problem of missing deletion vectors.
While the resolution for missing parquet files remains the same, we are now also addressing the issue of missing deletion vectors. With this in mind, the implementation that includes missing DVs looks like this:

Get the files that are referenced in the current delta log
Using a udf, add new columns to the dataset of all files: dvPath, dvMissing, filePathMissing.
Now, get the list of actions that will be committed to the delta log. In this case there are two options:

spark.databricks.delta.fsck.fsckMissingDVsEnabled = exception
In this case we throw an exception if a missing deletion vector found in regular mode. In DRY RUN mode we report both missing DVs and missing parquet files.
spark.databricks.delta.fsck.fsckMissingDVsEnabled = removeDV
Here we attempt to fix the filesystem by also removing the missing deletion vectors from the delta log. That is, we remove addFiles that have a missing parquet file referenced, remove addFiles that have a deletion vector referenced, and add back files that ONLY have a missing deletion vector but with that deletion vector set to null. For example, assume we have the following files:

A: [parquetMissing: True, dvMissing: True]
Remove the entire entry from the delta log
B: [parquetMissing: False, dvMissing: True]
Remove the entire file from the delta log and then add it back but with the dv reference set to NULL
C: [parquetMissing: True, dvMissing: False]
Remove the entire entry from the delta log
D: [parquetMissing: False, dvMissing: False]
Keep the file in the delta log as is

After we have identified what to commit to the delta log, perform the commit and generate metrics
Report the results to the user

How was this patch tested?
The following unit tests were added to ensure correct execution of the command

FSCK simple test one file removed
FSCK simple test multiple files removed
FSCK simple test table syntax
FSCK with partitions
FSCK clone test
FSCK Vacuum and restore test
FSCK Change DRY RUN limit
FSCK Make sure other files are not deleted
FSCK DRY RUN test
FSCK Call FSCK on partitions
FSCK verify output
FSCK Remove partition directory
FSCK special characters test
FSCK ignore non-404 errors in DRY RUN mode
FSCK no double commit with concurrent calls
FSCK metrics in Delta table history with missing DVs enabled = true/false
FSCK missing deletion vector

Does this PR introduce any user-facing changes?
Yes, it introduces the FSCK command to the user. It operates similarly to the currently available implementation of FSCK REPAIR TABLE available within Databricks.

@scottsand-db , @vkorukanti , @allisonport-db , could you review it please?


WIP Make dart timer service inline with old native code features

This pr currently does the following:

Makes Timer Service into an abstract class with Platform specific implementations.
Adds back countdown timers
Removes old native code

Marked WIP:

This pr on flutter_local_notifications needs to be merged before windows can be tested properly. If you want to try messing around with it I have uploaded the commit here for the screenshot below.

MacOS and IOS has not been tested as flutter has dropped support for running under a macOS vm so I am unable to test, so the code for that will probably need changing.

Damn this is looking good King


Discussion - Restructure Wiki

Could be somehow connected to #19.
Description
Open a round table on if and how to restructure the Wiki content to make it easier for a user to consume

Suggested TOC:

Context

Infrastructure as Code
Where does this platform fit in?

Getting started

Prerequisites
Setup environment
Token replacement
Dependency pipeline

The library

Module design
Module usage

CI environment

Pipeline design

Static validation
Deployment validation (includes removal)
Publishing

Pipeline usage

Interoperability

Bicep to ARM/JSON conversion
Register ADO pipelines

Contribution guide

Readme generator script
Get formatted RBAC roles script

Known Issues

Scenarios (to be included in the getting started root page):

Onboard modules (opt 1) all getting started subsections
Consume modules (opt 2) download zip + only prereq
Contribute (opt 4) depends on the contribution

What about Workload scenarios or is it more desirable to focus on the Modules?

What about Workload scenarios or is it more desirable to focus on the Modules?

This would be part of Opt2 as far as I'm conserned


supervisor ; cause services not to start

the ; in the supervisor/conf.d/app.conf file cause the service not to start.

Coverage remained the same at 66.282% when pulling 64130724af3577c16a6462d67593ebf53753f92c on RickB17:patch-8 into 7f019583f20d52f56320b1576fd1d2bfefe4f10f on Netflix:master.

lgtm! Thanks.