NoMethodError: undefined method indexed? for ROM::Attribute

I recently upgraded to: rom-core-4.0.0 and rom-sql-2.0.0 from rom (3.3.0) and rom-sql (1.3.3) and started getting the error show below.
The line that seems to be causing the exception is:
 class Persistence::Relations::Users < ROM::Relation[:sql]
 ┆ schema(:identity_providers, infer: true) do
 ┆ ┆ use :timestamps
 ┆ end

NoMethodError: undefined method `indexed?' for #<ROM::Attribute:0x007fbed5e9a5e8>
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/attribute.rb:423:in `method_missing'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-sql-2.0.0/lib/rom/sql/schema/inferrer.rb:122:in `mark_indexed'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-sql-2.0.0/lib/rom/sql/schema/inferrer.rb:51:in `block in infer_from_database'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-sql-2.0.0/lib/rom/sql/schema/inferrer.rb:51:in `map'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-sql-2.0.0/lib/rom/sql/schema/inferrer.rb:51:in `infer_from_database'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-sql-2.0.0/lib/rom/sql/schema/inferrer.rb:35:in `call'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/schema.rb:361:in `finalize_attributes!'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-sql-2.0.0/lib/rom/sql/schema.rb:146:in `finalize_attributes!'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/schema.rb:56:in `block in <class:Schema>'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/support/notifications.rb:131:in `trigger'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/support/notifications.rb:69:in `block in trigger'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/support/notifications.rb:68:in `each'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/support/notifications.rb:68:in `trigger'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/setup/finalize/finalize_relations.rb:82:in `build_relation'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/setup/finalize/finalize_relations.rb:48:in `block (2 levels) in run!'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/setup/finalize/finalize_relations.rb:31:in `each'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/setup/finalize/finalize_relations.rb:31:in `block in run!'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/relation_registry.rb:9:in `initialize'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/registry.rb:27:in `new'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/registry.rb:27:in `new'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/setup/finalize/finalize_relations.rb:30:in `run!'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/setup/finalize.rb:86:in `load_relations'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/setup/finalize.rb:62:in `run!'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/create_container.rb:38:in `finalize'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/create_container.rb:14:in `initialize'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/create_container.rb:59:in `initialize'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/create_container.rb:65:in `new'
/Users/cmavromoustakos/.rvm/gems/ruby-2.4.1/gems/rom-core-4.0.0/lib/rom/create_container.rb:65:in `container'
/Users/cmavromoustakos/Documents/Sandbox/indie-ninja-api/lib/indie_ninja/api/persistence.rb:40:in `container'

@flash-gordon could you take a look?

I can assume that it was here: https://github.com/rom-rb/rom/commit/c7518fc28#diff-3ac454f9c196d0f7c33922c20f51583cL117
attr_class must be passed to schema constructor, elsewhere schema will be initialized with ROM::Attribute which has not indexed? method.
@flash-gordon What do you think?

@cmavromoustakos btw this schema plugin only adds attributes, they do not set default values, I believe you wanted to have something that deals with actually setting timestamp values by default. If that's the case, Changeset + :add_timestamp and/or :touch is what you need.

Fixed via https://github.com/rom-rb/rom/pull/464/files


fix: linting issues

Signed-off-by: rajatgupta24<EMAIL_ADDRESS>

/ok-to-test
/lgtm

/override SonarCloud

pkg/cmd/activities/activities.go:368:11: SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (staticcheck)
--
  |   |   |   | title := strings.Title(text)
  |   |   |   | ^
  |   |   |   | pkg/pipelines/pipelines.go:352:14: SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (staticcheck)
  |   |   |   | words[i] = strings.Title(words[i])
  |   |   |   | ^
  |   |   |   | pkg/cmd/grid/view.go:91:43: SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (staticcheck)
  |   |   |   | title = fmt.Sprintf("Promote to %s", strings.Title(promote.Environment))


Pass argument to elastalert enhancement for reusability

Is it possible to pass arguments to elastalert enhancements so that it can be reused?
Something like:
match_enhancements:
- "elastalert_modules.my_enhancements.MyEnhancement","arg1","arg2"

Please let me know if it's already possible.

Yelp/elastalert is no longer maintained. Please use jertel/elastalert2.
https://github.com/jertel/elastalert2


Request body (urlSchemeTask.request.HTTPBody) is nil

Hi @NiklasMerz ,
We have fully set up the cordova-ios 6.2.0 + the current plugin + converting all the urls to be routed through the webproxy.
Unfortunately the very first call fails and after debugging it I have noticed that the urlSchemeTask.request.HTTPBody is nil even though from Javascript the body is correctly set up, in plugin code there is no body (the body is a json "{"name":"t","password":"1"}") and the headers are correctly set and transmitted.
The call is correctly routed to our server because the response headers contain the server details but we are getting back a 400 Bad Request and since this is the login call no cookies are returned hence everything stops.
Few more (maybe important) details:

The call is a POST to our DB server which is CouchDB (done automatically by PoouchDB client DB)
The call is a HTTPS call
In Javascript there is a middleware polyfill xhr-polyfill (but that has been working perfectly since this moment) but I did debug in Safari and XCode at the same time and all the request details have been set correctly (url, body, headers)
After returning in Javascript there is an error "TypeError: undefined is not an object (evaluating 'xhr.readyState')" - but this might not be relevant I think

Logs

There seems to be a stopSchemeTask log but I suspect is due to the fact our server returns 400

Closing this because seems to be coming from CDVURLSchemeHandler


Prepare version 2.9 for upload to PyPi

Prepare to upload new version 2.9 to PyPi.

Branch version-2.9 should be kept in perpetuity as a record of the 2.9 release.
@mrbean-bremen please note this custom.


Missing "diagnosticsSummary" in R/DedCheks.R

Hi !
We encountered errors while trying to execute the cdmOnboarding function :
2023-12-13 10:20:37	[Main thread]	ERROR	CdmOnboarding	3	Could not generate results document: Error in UseMethod("mutate"): pas de méthode pour 'mutate' applicable pour un objet de classe "NULL"
2023-12-13 10:20:37	[Main thread]	INFO	CdmOnboarding	3	Results from the checks have been saved as an RDS object to the output folder.
2023-12-13 10:20:37	[Main thread]	INFO	CdmOnboarding	cdmOnboarding	All generated CDM Onboarding results are bundled for sharing at: /home/verdgui/OMOP/CdmOnboarding/output/CDWBordeaux/Results_Onboarding_CDWBordeaux.zip
2023-12-13 10:20:37	[Main thread]	ERROR	CdmOnboarding	cdmOnboarding	CdmOnboarding document generation failed. Please fix any issues or reach out to the DARWIN-EU Coordination Centre.

Our environment is as follow :
               _
platform       x86_64-pc-linux-gnu
arch           x86_64
os             linux-gnu
system         x86_64, linux-gnu
status
major          4
minor          2.3
year           2023
month          03
day            15
svn rev        83980
language       R
version.string R version 4.2.3 (2023-03-15)
nickname       Shortstop Beagle

The source of the problem seems to be the empty result for  the object "dedResults$diagnostics_summary".
To resolve this issues, we did those changes in R/DedChecks.R :
https://github.com/darwin-eu/CdmOnboarding/blob/f1af8a7fbd07a10269832117c953b960ad42e298/R/DedChecks.R#L46-L60
suppressWarnings(suppressMessages(
   dedResults <- DrugExposureDiagnostics::executeChecks(
     cdm = cdm,
     ingredients = dedIngredientIds,
     checks = c("exposureDuration", "type", "route", "dose", "quantity", "diagnosticsSummary"),  ## diagnosticsSummary" added in checks
     minCellCount = 5,
     sample = 1e+06,
     earliestStartDate = "2010-01-01"
   )
 ))

 duration <- as.numeric(difftime(Sys.time(), ded_start_time), units = "secs")
 ParallelLogger::logInfo(sprintf("Executing DrugExposureDiagnostics took %.2f seconds.", duration))
 # Return result with duration
 list(result = dedResults$diagnosticsSummary, duration = duration)  ##diagnosticsSummary instead of diagnostics_summary

Thanks !

Thanks for reporting, fixed in v3.0


metadata-handler: use Number.parseFloat

Signed-off-by: Bob Wombat Hogg<EMAIL_ADDRESS>Number.parseFloat() is the preferred way of doing this in ES6.

Coverage remained the same at 95.787% when pulling 70c4f9ff24f448f27b7202b3c6da5b4aa7c10935 on rhoggSugarcrm:use-number-parsefloat into 730e5286f928437f7b44b0f27c09a152a36267c5 on sugarcrm:master.


Mainnet Release v2.0.1 Kṛttikā

💉 New Raiden Light Client SDK, dApp and CLI

INFO: The Light Client SDK, CLI and dApp are all work in progress projects. All three projects have been released for mainnet and all code is available in the Light Client repository. As this release still has its limitations and is a beta release, it is crucial to read this readme including the security notes carefully before using the software.

This is a patch release to fix the update feature of the dApp. Users  of the officially hosted https://lightclient.raiden.network client should ensure to update from v1.1.0 directly to v2.0.1. Please remember that this is still a major release jump and implies a switch to the new contracts. For more information, refer to the notes from the v2.0.0 release.
Raiden dApp
Fixed

[#3021] Fix version handling to detect client updates

@andrevmatos please only approve the PR. I'll double check it again and would like to be present when we merge and tag it so I can triple check it then when it becomes live.

I made the double check. Something is still broken.

I found the cause for what was distracting me. Lesson learned.
When the user force reloads the tab (Shift + F5 or Ctrl + R) this will bypass the service worker and its cache (see W3C reference below). As result the most recent version from the server gets loaded without asking the user for confirmation. But as our service worker works, it will install the new service worker but still uses the old cache. This means when the user closes the tab and opens the client again, the browser will use the service worker again which will use its "old" cache to open the client.
This means the update feature got successfully fixed for this patch version. But it revealed a new issue we have to think about and fix. Because the problem could be that the user is actually using this force-reloaded new version to act on new contracts that gets persistent to the database. Or the SDK updated its database structure and migrated the old data into the new structure. Now this new version is only active temporarily. The next time the user loads the client it will have either broken the client or the user is confused as he is missing channels.

From the W3C specification for service workers:

navigator.serviceWorker.controller returns null if the request is a force refresh (shift+refresh).

I had a call with Kamal. As this will fix the current issue with having a version that is able to update to future versions again, we will release it as planned. The other issue still exists and needs to be tackled afterwards.


password_reset_token is invallid, digesting the token makes it un-findable

Both on the startup app I am working on, as a newly generated app give the same error on the PasswordsController#update action: reset_password_token is invalid. The following logs are created when the render page is re-rendered because of the failure.
Started PUT "/gebruikers/wachtwoord" for <IP_ADDRESS> at 2017-11-06 22:43:40 +0100
Processing by Devise::PasswordsController#update as HTML
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"Db7WVRTS/VQKKFMmLt2n/ZJKBkfFM2kO+v/5XOpA97wfLQ7D5LQtSNk/mYp7UGFHg2E616EW5TPGlkVMBEE4ZQ==", "user"=>{"reset_password_token"=>"[FILTERED]", "password"=>"[FILTERED]", "password_confirmation"=>"[FILTERED]"}, "commit"=>"Verander mijn wachtwoord", "locale"=>"nl"}
  User Load (0.6ms)  SELECT  "users".* FROM "users" WHERE "users"."reset_password_token" = $1 ORDER BY "users"."id" ASC LIMIT $2  [["reset_password_token", "448eef3cc236e927e262911d95ca62011136e87959e5de61283bdba4e1ffcc59"], ["LIMIT", 1]]
  Rendering devise/passwords/edit.html.erb within layouts/application
  Rendered devise/shared/_error_messages.html.erb (1.0ms)
  Rendered devise/passwords/edit.html.erb within layouts/application (10.5ms)
  Rendered layouts/_navigation.html.erb (4.1ms)
  Rendered layouts/_header.html.erb (7.7ms)
  Rendered layouts/_flash.html.erb (0.9ms)
  Rendered layouts/_footer.html.erb (2.9ms)
Completed 200 OK in 160ms (Views: 140.4ms | ActiveRecord: 0.6ms)

When checking out the users reset_password_token in the database I got: fbd388b6673e1c64b40031116f1cd25ad4d19523700d2a4ca930041730a3d892, which does not comply with the reset_password_token in the above logs.
That made me dig around the devise gem a little bit and this made me stumble upon the following code in lib/devise/models/recoverable.rb:
        def reset_password_by_token(attributes={})
          original_token       = attributes[:reset_password_token]
          reset_password_token = Devise.token_generator.digest(self, :reset_password_token, original_token)

          recoverable = find_or_initialize_with_error_by(:reset_password_token, reset_password_token)

          if recoverable.persisted?
            if recoverable.reset_password_period_valid?
              recoverable.reset_password(attributes[:password], attributes[:password_confirmation])
            else
              recoverable.errors.add(:reset_password_token, :expired)
            end
          end

          recoverable.reset_password_token = original_token if recoverable.reset_password_token.present?
          recoverable
        end

here the original token is first digested, and then used to look for the resource (in my case User) with the find_or_initialize_with_error_by method. However there does not exist any reset_password_token with the newly digested reset_password_token, and the recoverable model returns a non-persisted model, which lets the password_reset behaviour fail. However, Passing original_token into the find_or_initialize_with_error_by method does return the proper resource model.
So I checked out how this was done in lib/devise/models/confirmable.rb under the confirm_by_token method and noticed the TODO:
        def confirm_by_token(confirmation_token)
          confirmable = find_first_by_auth_conditions(confirmation_token: confirmation_token)
          unless confirmable
            confirmation_digest = Devise.token_generator.digest(self, :confirmation_token, confirmation_token)
            confirmable = find_or_initialize_with_error_by(:confirmation_token, confirmation_digest)
          end

          # TODO: replace above lines with
          # confirmable = find_or_initialize_with_error_by(:confirmation_token, confirmation_token)
          # after enough time has passed that Devise clients do not use digested tokens

          confirmable.confirm if confirmable.persisted?
          confirmable
        end

Could the not functioning function in lib/devise/models/recoverable.rb be some kind of regression bug and are more people having this problem?

Can you please provide a sample application that reproduces the error?

it took longer than expected: https://github.com/jovanmaric/devise_test

I ran into the same issue when upgrading a really old app to a newer version of Devise.  The issue was in the mailer view override where they were passing @resource.reset_password_token as the reset_password_token URL parameter (the digested token) when it should have been @token (the non-digested token).
For example, in your sample application try changing Line 6 of app/views/devise/mailer/reset_password_instructions.html.erb to:

<%= link_to t('.action'), edit_password_url(@resource, reset_password_token: @token) %>

Indeed, the view on the sample app looks like an old version - it was changed here: https://github.com/plataformatec/devise/commit/143794d701bcd7b8c900c5bb8a216026c3c68afc#diff-de6f63b24abbd2f34401479bd4aa1eb3.
@jovanmaric Did you generated the views using an older version of devise? Can you confirm that it works by changing the parameter as shown above?

Yes it works, thanks @tegon, @christophertfoo and @rafaelfranca! I'm not quite sure why the old views were generated. I do remember very faintly that I used devise-bootstrap-views to generate the views in some project, I presume it was this one :speak_no_evil:. Anyhow thanks a lot!

I'm having a very similar problem to jovanmaric and as the last comment was only hours ago I'm going to comment here.
I'm on Devise 3.5.10 and in my reset_password_instructions.html.erb I have a link like this
link_to 'Edit Password', edit_password_url(@resource, reset_password_token: @token, locale: "en")

This renders the following link in the delivered email:
http://localhost:3000/en/company_users/password/edit?reset_password_token=xxxxxblahblahblah
The locale part is to force the reset form to display in english (The email has instructions in both Japanese and English with associated reset links).
In my routes I have this scope
scope "(:locale)", locale: /en|ja/ do
    devise_for :company_users ....
    ...
end

When the user tries to reset their password however, they get an invalid token error. After adding logging it appears devise was returning a non-persisted mode just like jovanmaric stated.
When I remove the locale from the url password reset seems to work fine.
Can anyone see an obvious error?


Update CODEOWNERS

What type of PR is this?

subproject management

What this PR does / why we need it:

a codeowner from KDDI to be replaced from Tet Chiba to Toshi Wakayama

Which issue(s) this PR fixes:

N/A

Special notes for reviewers:
Changelog input
 release-note

Additional documentation
This section can be blank.
docs

Thanks @ToshiWakayama-KDDI!


Error in destroying views when changing routes

I'm not sure how to report this.
I have an instance of the timetree view in my index route. When I change to another route, my app breaks and the console (in chrome) reports the following:
Uncaught Error: Assertion Failed: You must use Ember.set() to set the `element` property (of <hr-tm-dashboard@view:timetree-brush-view-month::ember889>) to `null`.

Here are my framework stats:
DEBUG: Ember                       : 1.11.1
app-boot.js:25DEBUG: Ember Data                  : 1.0.0-beta.16.1
app-boot.js:25DEBUG: jQuery                      : 1.11.3
app-boot.js:25DEBUG: Ember Simple Auth           : 0.8.0-beta.2
app-boot.js:25DEBUG: Ember Simple Auth OAuth 2.0 : 0.8.0-beta.2
app-boot.js:25DEBUG: Ember Simple Auth Testing   : 0.8.0-beta.2

NOTE:
I'm extending the base classes to adjust time/date formatting. I get this error when using the base class using the documented handlebars codes.

This is fixed by removing "element" as a dependentKey in the svg computed property.

Is this really closed? Was this an error in your code or the lib's?

The library. So maybe it isn't closed yet.
Chuck
Sent from my iPhone

On Jun 15, 2015, at 5:38 PM, John Kurkowski<EMAIL_ADDRESS>wrote:
Is this really closed? Was this an error in your code or the lib's?
—
Reply to this email directly or view it on GitHub.

This is fixed by removing "element" as a dependentKey in the svg computed property.

When you say this, you mean you forked this lib to fix your error? Or did you change something in your code?

To debug this, can you add a conditional breakpoint where the assertion fails? Make sure async stack traces are enabled. What is trying to "set" the element property to null? Where is the assertion in Ember? What is it trying to protect against?

No repro case or further reports for a year. Closing.


OCS space members: users and groups not distinguishable

Describe the bug
When fetching a space via graph api there is an attribute drive.spaceRoles.kind which can be user or group. This is ok and quite important for being able to distinguish user and group type members.
Unfortunately the OCS api handles both user and group type space members the same: both have a share type value of 7. While OCS distinguishes regular user (share type 0) and group (share type 1)  shares, it does not do the same differentiation for space members.
To my knowledge this only affects write requests, i.e. inviting a new space member or updating an existing one. Listing space members happens via graph api (at least for web).
Steps to reproduce
Steps to reproduce the behavior:

Create a space test
Invite group physics-lovers to be member of the space test
Have a look at the OCS POST request payload on /ocs/v1.php/apps/files_sharing/api/v1/shares

Expected behavior
When inviting a group as a member, a new share type 8 should be required.
Actual behavior
Share type 7 is required.

cc @micbar this is needed to properly handle group and user type space members in web. At the moment it just works for the write requests because web didn't introduce a differentiation in the share objects for users and groups which would be consistent with regular shares ( share types 0 and 1 for users and groups). We'd like to do the same for our internal handling of space members with a share type 7 for users and 8 for groups, but we can't because then the write requests would fail for group invites.

cc @jstehle blocker/prerequisite for https://github.com/owncloud/web/pull/8248

This was just overlooked during the implementation and maybe a 🐔  / 🥚 problem.
Needs server side fix @C0rby @kobergj

@kulmann I added the type here: https://github.com/cs3org/reva/pull/3620
But I am a bit confused. As far as I see the backend doesn't handle these ShareTypes. They are only used so the backend knows which share to create. For both (share types 7 and 8) the same endpoint is called therefore the server doesn't need this information.
It never returns a ShareType anywhere.
Do I get correctly that this is only needed for client convenience and the server doesn't need to understand it?

It never returns a ShareType anywhere.

I thought the share type is returned on the ocs API

ShareTypeUser and ShareTypeGroup are being returned. ShareTypeSpaceMembership (7) is not.

No. The server needs to know which kind of share to create. But both user and group invitation point to the same endpoint. That means you could create a group invitation using shareType=7 or a user inviation using shareType=8. It is the same for the server.
You cannot however create a user invitation with shareType=0 as this will direct the server to another endpoint.

thanks, that makes perfect sense. 🚀
cc @JammingBen next reva bump after https://github.com/cs3org/reva/pull/3620 was merged will unblock introducing a shareType 8 for groups. 👍

closing as this is in master now. Please reopen if there is still work to do.


[Otel Distro] Fix subnamespaces and docs

Even though the subnamespaces were empty, they still show up in the documentation. So making them private.
Also updated docstring to improve rendering.
Before:

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-monitor-opentelemetry

/azp run python - monitor - ci


Update docs for NetworkPolicy port range to GA for 1.25

This PR updates docs for the NetworkPolicy port range enhancement that is graduating to stable in 1.25 by the following:

updates the feature state on the Targeting a Range of Ports section on the Network Policies page to 1.25
updates the Feature Gates page for NetworkPolicyEndPort and moves entries from Feature gates for Alpha or Beta features section to the Feature gates for graduated or deprecated features section and adding an entry for 1.25 to GA

Enhancement issue: https://github.com/kubernetes/enhancements/issues/2079
KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2079-network-policy-port-range
/sig network
/milestone 1.25
/assign @kcmartin @rikatz

@rikatz and @kubernetes/sig-network-pr-reviews  , the NetworkPolicy port range enhancement is tracked to be graduated in 1.25
Please review if the changes in this PR to k/website are correct for the NetworkPolicy port range going to stable.
Are there any additional docs that need to be updated for NetworkPolicy port range?

It might need a little bit rewording inside the same section with feature going GA:
https://github.com/kubernetes/website/blob/eb860d5d5cbc7f4e98f03aca7362e85eac55d26c/content/en/docs/concepts/services-networking/network-policies.md?plain=1#L231

It might need a little bit rewording inside the same section with feature going GA:
https://github.com/kubernetes/website/blob/eb860d5d5cbc7f4e98f03aca7362e85eac55d26c/content/en/docs/concepts/services-networking/network-policies.md?plain=1#L231

Nice catch @cici37
@rikatz is deleting the instructions to disable the feature gate correct

@reylejano thanks and sorry again for the delay.
This lgtm, just left a minor small comment. I was worried that we cover the fact that this feature just works if the NPP/CNI supports it, but this callout is already on the page
/lgtm
/approve
/hold
@thockin I guess this one can go, as we discussed in some of sig-net meetings. The note on endPort being CNI dependant is there.

/approve
/lgtm

Unholding to let this PR merge per this comment
/hold cancel


unable to withdraw

Hi ive tried the  https://wallet.sibcoin.net/en/#wallet but i can not withdraw sibcoins from it

I'm not sure what to do about this as we don't maintain that site.

The repository you're looking for is here.


CI: Conformance GKE FIREWALL quota hit

Hit the error below at https://github.com/cilium/cilium/actions/runs/7528670491/job/20491371982
Default change: During creation of nodepools or autoscaling configuration changes for cluster versions greater than 1.24.1-gke.800 a default location policy is applied. For Spot and PVM it defaults to ANY, and for all other VM kinds a BALANCED policy is used. To change the default values use the `--location-policy` flag.
Note: The Pod address range limits the maximum size of the cluster. Please refer to https://cloud.google.com/kubernetes-engine/docs/how-to/flexible-pod-cidr to learn how to optimize IP address allocation.
ERROR: (gcloud.container.clusters.create) ResponseError: code=403, message=Insufficient project quota to satisfy request: resource "FIREWALLS": request requires '3.0' and is short '3.0'. project has a quota of '500.0' with '0.0' available. View and manage quotas at https://console.cloud.google.com/iam-admin/quotas?usage=USED&project=***.
Error: Process completed with exit code 1.

This is the last 3 months' usage graph. Something changed around Dec 15 and usage got much bigger after that.

Fire wall limit is increased to 1000 so we should not hit it for now.

Increasing the quota works.

I will keep it open for a week to see if the rule count is persistent or if is there any increase. If it is persistent then close it. @nickolaev

For the last week's peek firewall rules created are stable. Closing the issue.


Cookie Banner does now work

Users choice on the cookie banner is not respected. I get the cookie banner on every page load.

I think this is actually being cause by the domain not being registered with OneTrust, but I am also not 100% sure so worth investigating.

@nc-andreashaller should we build in a switch to disable it on localhost (for dev) and hlx.page URLs. At least for now?

good idea, is it integrated directly or via Launch right now?

Via Launch. I suggest we only load the launch scripts on prod domain.

Seams to work now.


Save stills in the root folder instead of separate named folders

Use case:
Rendering stills
It would be handy if the addon could detect if the frame range is set to a single frame, and if yes save the image to the root folder and set the file name to the corresponding camera name.
Example:

Expected result:
Image saved as /tmp/Camera_top_view.png
(Instead of /tmp/Camera_top_view.1-1/0001.png

Great feedback @menoos
Considering this issue and #1 , I believe we can have a checkbox to decide whether different directories will be created or not. Also, an option to give the strip a custom name (instead of generated pattern), will suffice the usecase.
Open to more feedback on this. 🙂

fixed by https://github.com/luckykadam/render-strip/commit/3f634afe66e86068c795f278a303f0f5b7efac7c


bytes32 instead of strings

Article for reference: https://medium.com/@cryptopusco/bytes-and-strings-in-solidity-f2cd4e53f388
E.g.
contracts/tests/TalentLayerIDV2.sol Profile struct contains string handle attribute which can be changed to bytes32
The line in code
uint8 constant MAX_HANDLE_LENGTH = 31;
also satisfies this condition

That's a good point. The problem is that we need the handle as a string for the token uri (see _buildTokenURI function), but it's quite tricky to convert a bytes32 to string without knowing the length of the string (and without adding extra zeros as padding)
So probably the change is not worth the extra complexity that it adds.
Thanks for the suggestions though, and would like to hear your thoughts on this. Maybe there's a solution that we are not thinking about.

https://stackoverflow.com/questions/67893318/solidity-how-to-represent-bytes32-as-string

https://akashmittal.com/convert-bytes32-string-solidity/


feat: Enable macos desktop

Description
This pull request enables macos desktop for quickgui.
This is still early work, so they're might be some edges cases that will need investigation.
Type of change

[X] New feature (non-breaking change which adds functionality)

Checklist:

[X] I have performed a self-review of my code
[X] I have tested my code in common scenarios and confirmed there are no regressions
[X] I have added comments to my code, particularly in hard-to-understand sections
[X] I have updated and committed pubspec.yaml and pubspec.lock

flutter pub get

What is has been tested on

mac book air M2, default macos terminal

What works

Getting the list of available OSes and their versions from quickget
Starting the download, and monitoring its progression
Listing availables VMs
Starting and stopping a VM through quickemu
Connecting to a VM via SSH using the default macos terminal
Partially or completely deleting a VM

What has not been tested

Downloading and running any distro which does not have "ubuntu" in its name

What does not work

Packaging a dmg file. I need to look into that.

I fixed the icons, hopefully.

Sorry to reopen I'm 99% way for compling on arm64 mac but getting a weird error.


Add unit tests

This PR adds unit tests by introducing a new unit-tests app.
Why?
Right now the only way to test the engine is either by hands or cpp-tests, which is an unusable nightmare. It's not automated, with bad and slow UX, you have no idea what the tests are testing or how they are supposed to look, etc. The first and a primary tool for non visual tests should be unit tests. It must be fully automatic, fast, easy to use and easy to add and write new tests.
How?
This PR adds unit-tests app. It's a console app that automatically runs a bunch of tests and at the end prints out if all tests pass. If tests do not pass, it shows which fail, give you source file location for the failing test and gives the reasons why it fails. The app also uses exit codes to signal if tests pass, so this can be used in a CI/CD environments.
The app itself uses doctest for writing unit tests. It's pretty simple, but has a lot of nice features. I've looked for something simple to use, and that would integrate easily. Looked at several alternatives, but they either were not maintained anymore or were too complex, and doctest was the only choice.
How it helps me?
You can develop new engine features or fix bugs by simply working on unit-tests project. You write some code, add tests for it and instantly know if your new code works or if it breaks some existing functionality. This will improve iteration times, and allow you to be sure that you're not breaking something else in the process.
How do the tests look like?
I've converted some tests from cpp-tests, you can see them at tests\unit-tests\Source\core. I recommend checking tests\unit-tests\Source\core\platform\FileUtilsTests.cpp, since it's closest to how ideal tests should looks like. Quick example:
    TEST_CASE("standard_url") {
        std::string s("http://www.facebook.com/hello/world?query#fragment");
        Uri u = Uri::parse(s);
        CHECK_EQ("http", u.getScheme());
        CHECK_EQ("www.facebook.com", u.getHost());
        CHECK_EQ(80, u.getPort());
        CHECK_EQ("www.facebook.com", u.getAuthority());
        CHECK_EQ("/hello/world", u.getPath());
        CHECK_EQ("query", u.getQuery());
        CHECK_EQ("fragment", u.getFragment());
        CHECK_EQ(s, u.toString());  // canonical
    }

How does running tests looks like?
Success!
[doctest] test cases:  50 |  50 passed | 0 failed | 1 skipped
[doctest] assertions: 975 | 975 passed | 0 failed |
[doctest] Status: SUCCESS!

Failure...
D:\work\axmol\tests\unit-tests\Source\core\network\UriTests.cpp(34):
TEST SUITE: network/Uri
TEST CASE:  standard_url

D:\work\axmol\tests\unit-tests\Source\core\network\UriTests.cpp(40): ERROR: CHECK_EQ( "www.facebook.com", "www.badbook.com" ) is NOT correct!
  values: CHECK_EQ( www.facebook.com, www.badbook.com )

===============================================================================
[doctest] test cases:  50 |  49 passed | 1 failed | 1 skipped
[doctest] assertions: 975 | 974 passed | 1 failed |
[doctest] Status: FAILURE!

Future

I hope we will have a rule that all bugfixes, new or touched features should come with unit tests.
And I also hope, that time from time we will move other unit test like tests from cpp-tests to unit-tests.
I'm also working on gfx-tests app to automate the graphics side of things.

Status

For now targeting only desktop OS'es, but in the future it would be nice to add support for mobiles too.
Tested on Windows and macOS.
It would be nice if someone could test it and fix it on Linux, I don't have access to it.
I have moved some tests from cpp-tests as a first step.
tests\unit-tests\Content is included in the repo. Right now it contains only 3 tiny text files, but I imagine in the future it might contain some larger test assets. So it might be a good idea to setup a separate repo to hold the assets. We can do it now or later.

Tested on macOS and it works apart some tests failing.
Made a PR for tests\unit-tests\Content assets: https://github.com/axmolengine/axmol-sample-assets/pull/1 . After assets are merged in I'll make relevant changes for unit-tests to use them.

Changed tests\unit-tests\Content to take the assets from axmol-sample-assets repo. So I guess it's ready for merging.
It would be nice if someone could test it if it works on Linux.

I think, you can add the target unit-tests to main CMakeLists.txt like cpp-tests and execute in github ci like: https://github.com/axmolengine/axmol/blob/dev/.github/workflows/build.yml#L100

Added to the workflows, but lets not enable test running for now, because not all tests pass (issues like #1863). Lets merge this PR first, then I'll make a separate PR to fix the tests and enable the running.

Added to the workflows, but lets not enable test running for now, because not all tests pass (issues like #1863). Lets merge this PR first, then I'll make a separate PR to fix the tests and enable the running.

merged

merged

Maybe you misunderstood me... I've meant lets merge this PR (#1862) first, then I'll make the fixes and enable running unit tests in a separate PR.

seems all intel cpu desktop contains macos, windows, linux build will error

ok, let's merge first


Expressjs Generator still use Jade instead of pug

Hey, I'm newbie here and I realized that Expressjs still use Jade instead their new name which is pug. Am I doing anything wrong? Or Expressjs still not updated?

No, the generator had not been updated, as pug is still in alpha. Jade, which is not an alpha version,works very well and does not have any issues. When pug is no longer in alpha, the generator will change yo use pug over jade.
I hope that helps!

@dougwilson If I understand correctly, Pug is no longer in alpha.  However, the generator still uses Jade, it seems.
At least, that's what I got using Node.js v12.16.1 and running npx express-generator, which made a package.json containing this:
  "dependencies": {
    "cookie-parser": "~1.4.4",
    "debug": "~2.6.9",
    "express": "~4.16.1",
    "http-errors": "~1.6.3",
    "jade": "~1.11.0",
    "morgan": "~1.9.1"
  }


More EP600 values

Added (nearly all) EP600 values displayed in the Bluetti App. No switches and settings.
Two issues I was not able to solve:

Grid power does not differentiate if power is pulled from or pushed to the grid. I could not figure out how the BLUETTI app knows in which direction the power goes. Since I also have this information including the pull/feed information directly from my electricity meter in Home Assistant, I am using this instead.
Grid and AC (consumption) voltage and current for the different phase will need to be multiplied by 0.1 to show correct. Since I could not figure out how to do that in python, I created a sensor template in home assistant

Have you also found the ADL400 registers for AC solar? If I saw it correctly, they should be at 1228 - 1245

No, I don‘t have an ADL400.Am 14.08.2023 um 19:51 schrieb Patrick762 @.***>:
Have you also found the ADL400 registers for AC solar? If I saw it correctly, they should be at 1228 - 1245
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I also get a new EP600 yesterday. I think I use it the same way as @Patrick762 with an external inverter (with ADL400 SmartMeter). @KM011092 is it possible to get these data? Actually I am using the version from @warhammerkid. How get I update to the version from @KM011092 to get more data from my EP600?

I am not using an external converter, so my configuration is without the ADL400. Without an ADL400 connected I don’t know if how I can discover and add the ADL data.Am 12.12.2023 um 20:47 schrieb smai86 @.***>:
I also get a new EP600 yesterday. I think I use it the same way as @Patrick762 with an external inverter (with ADL400 SmartMeter). @KM011092 is it possible to get these data? Actually I am using the version from @warhammerkid. How get I update to the version from @KM011092 to get more data from my EP600?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Closing since this version will not work anymore after EP600 update and Bluetooth ID for EP600 is now PBOX

Thanks for the info. Seems like it also causes my integration to no longer work. The only option I see right now is to differentiate between devices by their device_type fields

Fixed the PBOX issue yesterday by adding another device called PBOX. I don’t know if the updated code only works with PBOX now, so installation is at own risk. I also did a guess on adding the ADL400 values. Not tested and no guarantee. Feel free to install the fork I’ve created or check the code I used. Since this became very specific to PBOX/EP600 I will not raise a pull request again. I am also not planning to add more registers, since I have all the info I need.


supervisor can't find gunicorn

using this file:
https://github.com/CoreyMSchafer/code_snippets/blob/master/Python/Flask_Blog/snippets/supervisor.conf
sudo supervisorctl status
I'm getting this error:
app                              FATAL     can't find command '/home/MY_USER/site/venv/bin/gunicorn'
Please advise. Thanks a lot.

How you resolve the problem? I'm facing to this :(

How you resolve the problem? I'm facing to this :(

Sorry, long time this happened, I don't remember how I fixed this :(

It's ok. It took me nearly 2 days to find the solution but still can't fix :(


Make it possible to scroll and zoom on the map.

Time estimate: 1h
This task is part of user story #19

702bc3de3390a5da420986d73ea1538d88685644


Nightly scripts not honouring email assignment (Old 337)

In gitlab by @A-Lawrence on Aug 31, 2015, 01:07
The nightly update scripts aren't currently honouring our email assignments within core.

In gitlab by @A-Lawrence on Aug 31, 2015, 01:11
Community and RTS were updated. If there are others, they'll be updated when they're moved to core.
NFarrington - 2015-08-30T13:12:53.101146+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:18
mentioned in issue #289

In gitlab by @A-Lawrence on Aug 31, 2015, 01:18
mentioned in issue #290

In gitlab by @A-Lawrence on Aug 31, 2015, 01:18
mentioned in issue #291


V1.1.13 - added istanbul

Changes Unknown when pulling 5ab40addfe9f53b48b88a2dd0b4441f79211d8b4 on v1.1.13 into ** on master**.


Bridge between L1 -> L2 Failing

System Configuration: Nano Leder, Metamask
Browsers: Chrome and Brave
Blind Signing Enabled
Other Information:
The wallet was a legacy one created in 2017 on a nano ledger. When I choose it in metamask it says legacy mew, and doesn't show up in the Ledger Live section.
Issue:
I tried to bridge between L1-L2 before the snapshot the transaction just sat waiting for confirmation. There were no errors in the dev console to suggest there was anything wrong. I tried with several browsers and updated the nano ledger etc. I came back to it this morning and the transaction showed as cancelled.
I tried again this morning with no luck. Interestingly I only had one interaction with metamask and nothing popped up on the nano ledger to confirm.
Other steps:
After the snapshot, I created a new wallet on the nano ledger transferred the tokens to that wallet and then managed to successfully bridge (3) interactions with metamask.
I fear this won't allow me to get the Boba airdrop.

Have the same issue so very disappointed to see no response after 13 days?

It's 21 days now.


Flipboard not accepting Open Graph image

OG image not displaying in Flipboard. Could it be the compression pipeline used?
Example experience below. Flip to first page in this mag to see for yourself: http://flip.it/2lEb3z

Thanks for flagging, @jhabdas. We didn't check if the OG images worked with Flipboard prior to publishing but it is possible something with our compression is busted there. I'll debug further.
cc @housseindjirdeh in case he's run into this with other similar projects.

Update: Sent Flipboard today a link to this issue via in-app support.

Update: No word back from Flip yet—please feel free to close this if it makes sense.


Weather Observation Station 20

select
round(sta.lat_n, 4)
from station as sta
where
(select count(lat_n) from station where lat_n < sta.lat_n) = (select count(lat_n) from station where lat_n > sta.lat_n);

Hey @krishnasai21, Thanks for the solution.
Read more about raising a Pull Request from a fork here : GitHub Docs


Live Error: Error connecting to shhgit. Reload to retry?

The webpage loads and I'm getting matches in the console, but I keep getting that error on the website and it doesn't show any matches.

I have this issue on two separate servers.
One is Ubuntu 20 and the other is Debian 10.
Both of these servers were spun up from scratch on DigitalOcean.
Is there a step missing on how to get it running correctly?

I have this issue on two separate servers.
One is Ubuntu 20 and the other is Debian 10.
Both of these servers were spun up from scratch on DigitalOcean.
Is there a step missing on how to get it running correctly?

Same here, i already try with different version of Ubuntu and i have the same issue.

I have this issue on two separate servers.
One is Ubuntu 20 and the other is Debian 10.
Both of these servers were spun up from scratch on DigitalOcean.
Is there a step missing on how to get it running correctly?

Same here, i already try with different version of Ubuntu and i have the same issue.
Edit: Just edit the .js to point to your server.

@00xData
Where and what do I edit?
I have the same problem

Edit the file in sshgit/www/public/scripts.js
Find by "localhost" and change to your IP or domain
Enjoy!


Merge Event Hubs/SB Long-running tests into repository

Create a PR and merge these tests into our mono-repo.

Related: https://github.com/azure/azure-sdk-for-java/issues/20784

Covered by:
https://github.com/Azure/azure-sdk-for-java/pull/29407
https://github.com/Azure/azure-sdk-for-java/pull/28958


Compose Multiplatform Shared/Common Module Dependencies Error in IDEA and Android Studio

Describe the bug
When I try to use the Java basic library in the shared/common module as shown below, an error occurs: Unresolved reference java.

But I can still compile and run the project in IDEA and Android Studio. And my another project with almost the same dependencies does not have this issue.
Affected platforms
Select one of the platforms below:

shared/common module

Versions

Kotlin version*:  1.9.21
Compose Multiplatform version*: 1.5.11
OS version(s)* (required for Desktop and iOS issues): Windows10
OS architecture (x86 or arm64): x86
JDK (for desktop issues): jdk 18

Expected behavior
Can you help me configure this issue, I think that the problem is that I do not configure the project correctly.

That is how Kotlin multiplatform works. It will compile successfully until you try to make a build for a non-jvm platform. You should write a platfrom-specific code in dedicated jvm/android source set.
I guess it works well on your other projects because you have only desktop and android (both JVM) platforms enabled there. In this case linter knows that both of your platforms are JVM and allows you to make java imports in common source set.

That is how Kotlin multiplatform works. It will compile successfully until you try to make a build for a non-jvm platform. You should write a platfrom-specific code in dedicated jvm/android source set. I guess it works well on your other projects because you have only desktop and android (both JVM) platforms enabled there. In this case linter knows that both of your platforms are JVM and allows you to make java imports in common source set.

Oh, I get it! Thank you for your kind explanation!

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Item Metadata, Crafting Station, Crafting Cards and Event:craft weirdness

I am attempting to set up crafting of Blood Magic slates using RFTools Control. The 5 different slates have the same item ID but different metadata. I tested with just the two lowest tier slates, the Blank Slate (bloodmagic:ItemSlate:0) and the Reinforced Slate (bloodmagic:ItemSlate:1).
Everything works perfectly when I have only a single crafting card, either for the Blank Slate or for the Reinforced Slate, in the workbench. The correct result is produced when I click the appropriate recipe in the crafting station.
When I have more than one crafting card in the workbench (or any inventory - also tested with a vanilla chest), clicking on either the Blank Slate or Reinforced Slate in the crafting station produces the same item, but which item it is depends upon the arrangement of crafting cards in the workbench. If the crafting card for the Blank Slate is in the lower numbered slot in the workbench, then Blank Slates are produced irrespective of which recipe I click in the crafting station. If the crafting card for the Reinforced Slate is in the lower numbered slot in the workbench, then Reinforced Slates are produced irrespective of which recipe I click in the crafting station. The item icon displayed in the progress section of the crafting station matches the item that will be produced.
My program is here. Relative to the processor, the workbench is west, the crafting station is east and the blood altar is south.
Please let me know if I can assist with further information or testing.

I know what the problem is. Will see if I can fix this easily

Fixed next release (later today)

Thanks :) (and for the mod)


Front Door publicpreview

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Can one of the admins verify this patch?

This was signed off in the internal repo already.

@lmazuel Can you please review this today? We want to get this merged ASAP

The linter says the following:
_Potential new ARM errors
R3023 - OperationsAPIImplementation
Operations API must be implemented for '/providers/Microsoft.Network/operations'.
at specification/frontdoor/resource-manager/Microsoft.Network/preview/2018-08-01-preview/webapplicationfirewall.json:36_
But we are using NRP's Microsoft.Network/operations API, which is defined under /network/...
How do we fix this error?

The linter says the following:
Potential new ARM errors
R3023 - OperationsAPIImplementation
Operations API must be implemented for '/providers/Microsoft.Network/operations'.
at specification/frontdoor/resource-manager/Microsoft.Network/preview/2018-08-01-preview/webapplicationfirewall.json:36
But we are using NRP's Microsoft.Network/operations API, which is defined under /network/...
How do we fix this error?

Laurent helped me out. Thanks, Laurent!

Did not mean to close PR! Sorry

@jmelvinwork My last fixes fixed the CLI, and I think it's what you intended. Merging the PR since you told me you want it merge today.
Still, you own this, please double-check my commits and let me know if you have any concerns. Ideally, let me know if you don't have concerns too :)
Thanks!


Enable build, test and release github workflow

Github actions

Build workflow

Install - installs yarn and dependencies
Test - run both lint and test scripts
Build - run the build and store it in cache for later use

Release workflow

pull-scripts - this job pulls scripts from RedHatInsights/insights-frontend-builder-common
pull-jenkins - pull Jenkins file from builder common to properly deploy app to Akamai
set-ssh - this workflow uses SSH key to push to RedHatInsights/hac-core-frontend-build
Release-to-build - runs several scripts to push the build folder
Run-generate-image - generates Dockerfile and nginx
Run-build-and-publish - builds and publishes the build folder into quay

@andrewballantyne I hope I adjusted the paths to scripts and build properly

@andrewballantyne scripts should be adjusted and your changes included. The two variables we'll need are DOCKER_TOKEN to push images to quay and SSH_PRIVATE_KEY to enable pushes to build repository.

@karelhala Guess we can close this now that we know we can't use github actions 😞

@andrewballantyne yeah :(


Run flask in production mode

Choose and use a wsgi runner like uWSGI or gunicorn to run flask in production.

Okay seems to be working without any changes:
[mschmidt@honeypot][~/git/brainbot/merkle-drop]
$ gunicorn --bind <IP_ADDRESS>:4000 merkle_drop.server:app

Is there anything more to check @berndbohmeier @schmir-at-bb ?

I dont think so.

You want to make sure that the merkle tree initialization is only done once in the parent process. The forked child processes will then not have to do the initialization on their own.

As requested and discussed with @schmir-at-bb I will add documentation and a config file for gunicorn that enforces the loading of tree in the once parent (and passes it to the forked childs)


Please add a licence if possible

<EMAIL_ADDRESS>does not work if you don't put a licence.

done


Add 2 more hooks

*GradeChange event when upgrading/downgrading building parts
*RunEvent to stop built-in events and/or change them

Starting build...

Starting build...

Starting build...

Starting build...

Starting build...

test this please

Starting build...


Auto save

No matter in which position I do put the "Auto save" icon (I cannot find out what color means "on" and which means "off") — when having a document wich modifications and closing Markdown Edit, I got prompted whether to store my changes.
I would have expected that at least one of the two colors of the "Auto save" icon would actually do an auto-save?!?

Just tried it here and it appears to be working fine. Keep in mind the document must be saved at least once. Otherwise, the program does not know where to save it to.
The on color for autosave is the same on color as the other icons.

The file was saved before.

And if autosave was really broken you don't think I would have heard about it before now?
Seriously, if you want help, I need specifics. Maybe your system has a unique configuration I've not considered in my design. Maybe you're doing it wrong. I don't know. At least walk me through what you're doing and why you think it's not working. A video screen capture demonstrating the issue would help.

You can also turn autosave on/off in settings dialog (Ctrl+,)

Thanks, Mike. No offense intended by me.
The behavior was on my old Windows 10 and also on my new Windows 10. I've accepted the behavior long time ago, so no need to change anything. :+1:

I finally did a repro:
.
So basically it seems to work, but it fails when closing the document too quickly.
Probably the timer should be made to poll quicker and also if user is explicitely closing and auto-save is activated, it should store immediately.

Did my above comment from 13 May ever get noticed by the author?

Oops, missed it for some reason.
Buttons: It's a matter of opinion I suppose. The on position is much lighter than the darker off position. The hover color is an important queue that the item can be clicked.
I'll see if I can make this quick save bug happen. Tried before but was unsuccessful.


making my application load faster

Hi,
I'm using pypyjs-release-nojit to run my app ( based on https://github.com/yazgoo/mma.js ).
Do you have any advice that would speed up the initialization of the app, like maybe compressing files, or maybe grouping the sources in one python file ?
Thanks

Some related tickets are:
https://github.com/pypyjs/pypyjs.github.io/issues/4
https://github.com/pypyjs/pypyjs.github.io/issues/10
https://github.com/pypyjs/pypyjs.github.io/issues/7
https://github.com/pypyjs/pypyjs/issues/90
https://github.com/pypyjs/pypyjs/issues/70

Thanks @jedie, so for you my best bet would be to mimic what you've done in https://github.com/pypyjs/pypyjs.github.io/issues/7 in https://github.com/jedie/pypyjs.github.io/commit/2ff1a4b8ac41a7593fd47cee1f9ddda9dd641cdd ?

Hi, I tried using code from https://github.com/jedie/pypyjs.github.io/commit/2ff1a4b8ac41a7593fd47cee1f9ddda9dd641cdd ,
But I'm getting ReferenceError: get_archive is not defined.
Any insight on how to define it ?
Thanks


[openMVG] Disable AVX[2] usage

The default value for TARGET_ARCHITECTURE is 'auto' which works as 'march=native' i.e. it uses all instruction sets available on the build node, including AVX and AVX2.  Setting it to 'none' makes "SSE 4.1" the highest instruction set used.

There is some more info in issue #8838.

I think this should be a feature of the port to set the TARGET_ARCHITECTURE. I am against deactivating it by default.

I'm not sure I understood @heydojo's comment to issue #8838 correctly, but I'm fine with AVX2 being the default as long as you can deactivate it. Then it just becomes a matter of deciding how fine grained to control it. And how to translate it for cmake. Here you can see how openMVG evaluates TARGET_ARCHITECTURE.

@bjornpiltz
Could you please correct the Version filed in the CONTROL file?
@grdowns and @vicroms
Could you please help comment about this PR? Please help confirm whether we need to add TARGET_ARCHITECTURE  as a feature of this port or set TARGET_ARCHITECTURE=none directly?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bjornpiltz sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi @bjornpiltz
Could you please resolve the conflicts?

@NancyLi1013 I did. I hope rebasing and force pushing was the right approach.

Thanks for your update.

/azp run

@strega-nil
Could you please help review this PR?

/azp run

/azp run

We'd like to make this a triplet setting instead of the default; would it be possible for you to change it in that way @bjornpiltz ?
Basically, you'd have
OPENMVG_TARGET_ARCHITECTURE

be a thing someone can set in a triplet, and then pass that to TARGET_ARCHITECTURE if its set.

Yeah, there is actually more to this issue than I mentioned. The problem is, that if you don't disable AVX for openMVG you will run into Undefined Behaviour if you link statically to Ceres, which hasn't been built with AVX. The problem is the inline function Eigen::internal::aligned_malloc(unsigned __int64 size) which will align memory to 16/32 Bytes depending on whether AVX was enabled. If you mix static libraries with different compile flags, you will end up with two versions of that function and you have effectively broken the One Definition Rule.
This problem will also occur on Linux, regardless if you link statically or dynamically.
You can see a discussion of the problem here, or here
Note that this isn't a problem with Ceres or OpenMVG, but with Eigen.

@bjornpiltz then that definitely sounds like it should be a triplet setting.

@bjornpiltz
Could you please resolve the conflicts and update changes as @strega-nil suggested from?

Thanks for the PR; we're closing this for now since there's been no response. If you'd like to continue working on it, please reopen and ping us!


Play all skipped mid-roll ads when using VMAP

This is a great plugin, but I've come across a use case/ issue when there are multiple mid-roll ad breaks that should be played and the user skips multiple ( to be fair, I realize this may not necessarily be an "issue"  but rather a set of functionality that may not need to be baked in by default :) ).
Current Functionality:

Player loads a 50s video that will have pre-roll single ad, post-roll single ad, and multiple mid-roll ad break points (occurring every 10s after start)

User starts video, pre-roll ad plays, user seeks forward to the 31s point of the video

Player plays a single set of mid-roll ads from ad break

Player continues play at 31s

Ideal Functionality (in my case):

Player loads a 50s video that will have pre-roll single ad, post-roll single ad, and multiple mid-roll ad break points (occurring every 10s after start)

User starts video, pre-roll ad plays, user skips forward to the 31s point of the video

Player plays mid-roll ads from ad break that was scheduled for 10s

Player plays mid-roll ads from ad break that was scheduled for 20s

Player plays mid-roll ads from ad break that was scheduled for 30s

Player continues play at 31s

Is this a set of functionality that has ever been discussed? One clear solution to achieve this in my case would be for me to implement some tracking and manually set the player to a certain point after an ad break event, but I was hoping that someone had already come across this before.
If needed, here is an example on codepen that uses an example VMAP from google (taken from VMAP sample tags and described as : "VMAP - Pre-roll Single Ad, Mid-roll Standard Pods with 5 Ads Every 10 Seconds for 1:40, Post-roll Single Ad")
In any case, I appreciate it 👍

Hi,
This is a limitation of the underlying IMA SDK, so there is no way to do what you're asking in the plugin.
Thanks,
Yury

No worries, appreciate you taking a look!


Plans to upstream?

Hey guys, cool project!
I'm one of the QMK collaborators, and a friend of mine who had purchased the miniMACRO5 reached out to me for help flashing it.  This being his first QMK project there was probably some confusion regarding our new user documentation and interacting with projects out of tree.
That said, we were able to get it sorted (I just added all the files under QMKv3/ to my branch and gave him the hex).  I was just wondering if there were plans to get this into the main QMK repo at some point for ease of flashing?
Thanks :)

Yes, I would love to have it in the main repo. How would I go about doing
that?
On Thu, May 28, 2020 at 8:14 AM ridingqwerty<EMAIL_ADDRESS>wrote:

Hey guys, cool project!
I'm one of the QMK collaborators, and a friend of mine who had purchased
the miniMACRO5 reached out to me for help flashing it. This being his first
QMK project there was probably some confusion regarding our new user
documentation and interacting with projects out of tree.
That said, we were able to get it sorted (I just added all the files under
QMKv3/ to my branch and gave him the hex). I was just wondering if there
were plans to get this into the main QMK repo at some point for ease of
flashing?
Thanks :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/LeafCutterLabs/miniMACRO5/issues/5, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJRHDXWIYT7STR5VV4PVTR3RTZ5TVANCNFSM4NNFVZ7Q
.

Great, that's awesome to hear!
The process is pretty straightforward -- generally you fork QMK (or if that's already done, get master updated), create a new branch, add in your changes, and then pull request to get your_fork:your_branch merged into QMK master.  Our process generally requires two collaborator approvals, but turnaround isn't too bad as long as you stay on top of any changes requested.
I'd say what you have already works pretty well -- I had no issues basically just copying everything in and building it as is.  There may need to be some minor concessions -- for example, not hosting the hardware files and having the README.md on the QMK repo be more focused on the firmware/flashing aspect -- but you could always link back to this repo from there so people would know where to find the hardware files and stuff.
I've already got a branch going on my end so if you want, I can PR it myself and tag you on it.  Let me know what you think.

I just bought this board and I'm having a really hard time compiling my keymap file into a HEX when attempting to make a custom layout for it. It'd be really appreciated if you could streamline this process for people like me who have limited QMK experience. I've followed chokkan's video and it's still giving me errors :(

One problem is Configurator does not currently support encoders. Some problems with compiling have been case sensitivity issues. If you post your keymap I'm more than happy to compile and post it.

I have recently run a group-buy for this macropad, and am working on upstreaming this code. I will update this thread with the pull request number later, I'm still working on adjusting some code slightly.

https://github.com/qmk/qmk_firmware/pull/10392 alright, here is the pull request. I hope it gets merged quickly, I've done my best. Thank you @LeafCutterLabs for making this great macropad!

alright, @LeafCutterLabs... we can close this issue... your firmware has been merged into QMK main

alright, @LeafCutterLabs... we can close this issue... your firmware has been merged into QMK main

Awesome news! Just to clarify, it still won't support encoders for the Configurator right? What are our options for using encoders?

You can always compile local for encoder support.
On Fri, Oct 2, 2020, 5:44 PM bsoll<EMAIL_ADDRESS>wrote:

alright, @LeafCutterLabs https://github.com/LeafCutterLabs... we can
close this issue... your firmware has been merged into QMK main
Awesome news! Just to clarify, it still won't support encoders for the
Configurator right? What are our options for using encoders?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/LeafCutterLabs/miniMACRO5/issues/5#issuecomment-703015059,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJRHDXRA4KCWJV5X2YWW423SIZXVLANCNFSM4NNFVZ7Q
.

Yes, unfortunately I cannot add VIA or QMK Configurator support because of the encoders. The layout appears pretty broken in the configurator, I didn’t see any use in fixing it as encoders wouldn’t work anyway. Once better encoder support is released, I will happily update QMK main.
To program encoder functions yourself, you would do it in the same way as you would have previously with using files from this repository, but you won't need to work with extra remotes and it is part of the default QMK release. Customising the functions of this macro-pad (encoder or not) would mean editing it as if it was any other QMK file.
The default key-map has placeholder key codes, for ease of customisation and to reduce confusion to those new to working with encoders or new to QMK. You can see the accompanying image here, which will feature in a step by step key-map customisation guide specific to the miniMACRO5 guide which I am currently writing.
The media key-map is basically the same as the one provided here in this repository. There were some changes made to the QMK firmware, to fit in with more modern practices recommended by the contributors to that repository. Notably, I have removed the RGB tap-dance parts of the software as I believe they were superfluous and something that can be added back later. I am soon going to be adding many custom user keycaps for members of my group-buy, where I will add back a clean default key-map copied right from this repository.
I have put quite a lot of effort into documenting and improving the situation for this macro-pad since I have run a group-buy for it, I plan to offer some pull requests to this repository with improved documentation and hardware files. For example, I have redesigned the plate since the switch holes were the wrong size, I have access to V3c Gerber files sent to me by LeafCutterLabs and I have many other notes to add into documentation about how to program, build and manufacture this macro-pad. I am eager to share my improvements and findings with the public, when I get some time.
If you think of a better solution for customisation, please let me know. I'm eager to work on bringing VIA or QMK Configurator support for this macro-pad once the support is there. Thank you!
PLEASE NOTE THAT I DO NOT HAVE PCBs IN HAND YET, I CAN SEE NO REASON IT WOULDN'T, BUT THE FIRMWARE UPSTREAM MAY NOT WORK. I WILL FIX THIS AND TEST THIS WHEN MY PCBs ARRIVE IN ABOUT 2 WEEKS.

@dezlidezlidezli thanks for doing that.  It was on my list of things to do but then life happened and I've not been able to return to it.  I'll take a look at your QMK PR so I can see how to do the same for the other boards by @LeafCutterLabs.
Thanks for your contribution :) .


Flutter Doctor: Does anyone know hot to solve this issue: When I run flutter doctor the following message is displayed: Cannot execute C:\jdk-15_windows-x64_bin\jdk-15\bin\bin\java to determine the version

Steps to Reproduce

...
...
...

Logs

Can you make sure if that is the correct path where your java installed？

@cmatosdiaz
please provide your full flutter doctor -v and any other related log

Thanks.  I realized it was not been added correctly to the environment variables. But now I have other several issues:
These are the logs:
Flutter (Channel stable, 1.22.1, on Microsoft Windows [Version 10.0.19041.572], locale en-US)
• Flutter version 1.22.1 at C:\src\flutter
• Framework revision f30b7f4db9 (10 days ago), 2020-10-08 10:06:30 -0700
• Engine revision 75bef9f6c8
• Dart version 2.10.1
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\albap\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: C:\Program Files\Java\jdk-15\bin\java
• Java version Java(TM) SE Runtime Environment (build 15+36-1562)
X Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
[!] Connected device
! Device R58M54BDN5K is not authorized.
You might need to check your device for an authorization dialog.
For the license unknown issue, I already ran the " flutter doctor --android-licenses" command and returns the following log:
Exception in thread "main" java.lang.NoClassDefFoundError: javax/xml/bind/annotation/XmlSchema
at com.android.repository.api.SchemaModule$SchemaModuleVersion.(SchemaModule.java:156)
at com.android.repository.api.SchemaModule.(SchemaModule.java:75)
at com.android.sdklib.repository.AndroidSdkHandler.(AndroidSdkHandler.java:81)
at com.android.sdklib.tool.sdkmanager.SdkManagerCli.main(SdkManagerCli.java:73)
at com.android.sdklib.tool.sdkmanager.SdkManagerCli.main(SdkManagerCli.java:48)
Caused by: java.lang.ClassNotFoundException: javax.xml.bind.annotation.XmlSchema
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:606)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:168)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
... 5 more
I also installed the Android Studio and set my android device (usb driver included).  I don't know what else to do.
If you can shed me some light I'll be very grateful.

I bang in the same problem after I updated Android Studio to 4.10

Possible duplicate of #67986

Seems like a problem caused by high JDK version. JDK 8 might work properly with Android SDK.
I got this one which may provide useful information:
https://stackoverflow.com/questions/46402772/failed-to-install-android-sdk-java-lang-noclassdeffounderror-javax-xml-bind-a

Hi @https://github.com/flutter/flutter/issues/57372
I see there's an open issue addressing the case you described.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


Little code clean up

Reviewed code style.
Sorted methods. Android methods go first, then user actions and finally bus events.
Added static ChatService assessor to Application.
Started ChatService in background to pass the StrictMode.
Ensured to handle UI events in the main thread.
Refactored common stuff into a BaseActivity.

Looks fantastic! +1

Good work +1
Perhaps we should create some style rules at some point to get everyone on the same page

Maybe we can use Checkstyle


Make this available via jCenter / maven?

Hi,
just came across this project, and I would suggest that you make this available via public repositories.
Since you are already building with Gradle that should not be an issue.
Basically what you need to do is create a maven artifact using the Gradle Maven Publishing plugin, and then upload the generated pom.xml and the jar file to bintray. Then people can just use Gradle or Maven to get the dependency, and not need download it manually.
For the publish stuff, you can see an example here https://github.com/thokari/gradle-geb-plugin, see build.gradle, however it is an older version of Gradle...
Btw the nice thing about jCenter is that it also uploads your stuff to the maven central repository.

Great idea, thanks! I've added this library to jCenter/Maven. It's now available using the following dependency:
<dependency>
    <groupId>com.caseyscarborough.colorizer</groupId>
    <artifactId>groovy-colorizer</artifactId>
    <version>1.0.0</version>
</dependency>

Leaving this issue open until it becomes available in jCenter.

Apparently that can take some time, thanks for putting it up!

I could download it now via jCenter.


Handle SIGTERM by saving world and shutting down gracefully

This is an initial attempt at a way to handle restarts and shutdowns gracefully as a resolution for https://github.com/beardedio/terraria/issues/4
It does this by sending the 'exit' command to the TerrariaServer stdin which saves the world and shuts down the server.
It was based on https://github.com/alexivkin/terraria-server-container/blob/master/buildcontext/serverwatcher.sh
I've tested this with vanilla-<IP_ADDRESS>. If this looks like a good approach, I can do some testing with TShock to see if a similar approach would work for those images.

Nice, thanks! Works for me after fixing the one console typo on line 60. Some feedback:

I'd appreciate some comments around the more esoteric Bash code (maybe what is esoteric Bash is just convention to a more experienced Bash programmer).
After applying this patch I'm unable to attach to the container and issue commands to the server. We could maybe clean it up with more (named) pipes.

I could maintain this with great comments and a good deal of study or if it were in Python.


Clarify the support for dark mode with an example in README

The docs needs to be updated with correct syntax
 textTheme: GoogleFonts.latoTextTheme(
      ThemeData(brightness: Brightness.dark).textTheme,  //dark or white depends on usuage
    ),

With this the default text color in dark mode becomes white

The GoogleFont class itself should be able to identify the current brightness property of the app, by Theme.of(context).brightness.
The solution exposed by @apgapg doesn't fix this issue.

@jesusrp98 You have to use MediaQuery.of(context).platformBrightness to check if brightness light or dark

I understand, but it seems to verbose to me.
Imaging writting
GoogleFonts.latoTextTheme().subtitle2
instead of
GoogleFonts.latoTextTheme(Theme.of(context).textTheme).subtitle2.
@apgapg I think the smart move here would be to set Theme.of(context).textThemeas the default textTheme, instead of ThemeData.light().textTheme, as set in the current implementation.

i did the same but the dark mode didnt changed color. So i created two themes one dark and light and passs the same in google fonts. In my case font was fixed for app hence i dont need to write this
GoogleFonts.latoTextTheme(Theme.of(context).textTheme).subtitle2
or this GoogleFonts.latoTextTheme().subtitle2

Thanks @apgapg, I was getting the same issue. It works.

Another way to do it (also probably a dupe): https://github.com/material-foundation/google-fonts-flutter/issues/110#issuecomment-631015073

for dark theme it worked fine for me
textTheme: GoogleFonts.poppinsTextTheme(ThemeData.dark().textTheme),


Removed hardcoded ports

Contributor Comments
This PR binds the Alerts UI and Management UI port settings in Ambari to the appropriate app-config.json file for each UI.  You should now be able to change the settings in Ambari and have the changes reflected in the central navigation.  A full browser refresh is required after a port change though because the app-config.json file is cached.  This seems like a very minor issue but I'm happy to look into it if reviewers think it is a problem (it did exist before this PR).
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[ ] Have you included steps or a guide to how the change may be verified and tested manually?

[ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[ ] Have you written or updated unit tests and or integration tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

This is pretty solid (I'll also comment on the final ticket from @sardell when this is accepted). I would only request that we add the host info also and this is probably good to go.

+1. This is great. Thanks for taking the time to do this, @merrimanr.


A better way/method can be implemented to display the applied filter info.

Is your feature request related to a problem? Please describe.
The current way of displaying the applied filter info in the search bar can be improved/changed to make it look better.
Describe the solution you'd like
To be proposed by the contributors who want to take up the issue by commenting on the issue.

please assign this issue to me.

I have installed Flood and qBittorrent but I am getting this error after following the contributing.md guide.

I have installed Flood and qBittorrent but I am getting this error after following the contributing.md guide.

@sainideepanshu199 there is some issue with qBittorent and flood which needs to be addressed and resolved until then you can use transmission instead of qBittorent. The setup is almost similar.

@sainideepanshu199 is there any progress on this issue?
Also @sainideepanshu199 were you able to solve the issue you were facing while setting up the project? If not then this is what you need to do to resolve the issue.
Uninstall the older version of flood u have by using the command sudo npm uninstall -g flood and install the latest but not released version by using the command sudo npm i -g @jesec/flood

i am very sorry for no work on this issue, due to some serious problems couldn't work on anything.
but now i have started the setup again and i get a new issue while accessing app after opening web client from transmission app.

could u please resolve this problem

For solve this error, while installing you have to install this Web Interface Option.

can someone help me resolve this issue now, even after entering correct authentication details it shows failed login

You have to enter a details that you use to create flood web-ui account. If it give this login error then try to uninstall flood using sudo npm uninstall -g flood and again try to install sudo npm i -g @jesec/flood and create new account. after create new flood account try to login with that details.

Unassigning this issue to @sainideepanshu199 as there was no progress reported on the issue

Can you assign me this issue.

Can you assign me this issue.

Hello @Ronakkkkk please let me know if you still want to work on this issue - if yes then I will assign this issue to you.

Hey @Akshatji800 I would like to work on this issue
Can you assign me?

Please assign this issue to me.

Please assign this issue to me.

Please let me know what is your idea and how you are gonna improve it before I assign this issue to you.

I am thinking of combining Filters and Sort into a single bottom sheet and selected filters and sort by status can be seen below the search bar like this:-

Similarly I'll also show the current Sort By status.

If you are okay with my idea, should I continue working on this?

I am thinking of combining Filters and Sort into a single bottom sheet and selected filters and sort by status can be seen below the search bar like this:-

Hey @tb-rules10, thanks for proposing this but the reason why this was not followed and approved initially itself is that we want to save as much space as we can on the main screen to show torrents. This is the reason why search bar, download speed etc are hidden and appears on top swipe. Please suggest something that aligns with our minimal screen space usage goal.

Hello, I'm interested in addressing this issue, but I'd like to first explore the application to better understand it. Others have faced installation problems before. I'll return with a proposal once I've investigated it.
Thank you.

Hi @Akshatji800 I think we can use chips to better portray the filtering options instead of the current radio selector. This proposal is also in line with using minimum space possible, since a user would have to scroll less.
Below is a skeleton of what the filter would look like, as the tracker list would be varying in size, the filter dialog will be scroll-able and will use wrap widget to handle devices of varying width.

Hey @Nailsonseat assigning this issue to you. But this issue is more about how we are gonna show the current filter selected in a better way. Currently it is shown in searchbar. I want you to work on that first.

Hey @Nailsonseat assigning this issue to you. But this issue is more about how we are gonna show the current filter selected in a better way. Currently it is shown in searchbar. I want you to work on that first.

Thank you Akshat, I will come back to you with an idea regarding this very soon.

@Akshatji800 I have three points regarding this problem

I think displaying the filter in the search bar itself is a good idea and should stay that way if we intend to minimize space.
When any filter is selected, a dismiss filter option would be a great addition instead of a placeholder filter icon.
 The idea is good that there should be a way to dismiss the filter (it is definitely increasing the UX) but you need to think of a better UI.

Good point, the user will not know if 'complete' is a filter or something else, will work on it. I deleted the original post because I wanted to show a good way to show sorting too along with filters. I will come to you will a new idea soon

@Akshatji800 I have some new mock-ups or rather old ones because these designs are more closer to the original UI.

Initial state
Selected state

Filters
I have two points with respect to the concern with confusion with dismiss button

The current mock-up has UI which is more intuitive in terms of deducing what the "complete" and the X button stands for, IMO.
The filter is located on far right where there is no other button near it, so I think the case for confusion would be even lower.

Sort

I included the sort button in a border to make it seem more like a button but I'm not sure about it, need you input on this.
Dismiss button is not needed for sorting as there is always a sort type that is always selected.
Currently whichever sort type you select , it always displays the A-Z icon, I think we can find all the 12 icons for the 12 sort types of sorts here

i found a potential implementation for the sort button straight from the material 3 website. Just imagine this with icons, and without the text in the button. The focus is the button not the drop down itself
https://github.com/CCExtractor/Flood_Mobile/assets/67797628/22a7d132-7993-451a-8df8-10439b99beab


Enabling BFD for Microsoft Peering

Hi,

Enabling BFD section doesn't mention Microsoft peering at all:
https://docs.microsoft.com/en-us/azure/expressroute/expressroute-bfd#enabling-bfd

It mentions only private peering with nothing about Microsoft peering.

It would be great to add the date when BFD became enabled by default in private/Microsoft peering which I believe is 08/01/2018 for private peering and 01/10/2020 for Microsoft peering.

Regards,
Hussein

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a20215a3-6258-6b9f-357b-e806aa7afccd
Version Independent ID: 8ac2ced9-13c1-de41-3aaa-3822d6debee4
Content: Azure ExpressRoute: Configure BFD
Content Source: articles/expressroute/expressroute-bfd.md
Service: expressroute
GitHub Login: @duongau
Microsoft Alias: duau

Thanks for the feedback! We are currently investigating and will update you shortly.

@haalkaz, Appreciate your patience. We have assigned this issue to the respective content author for updating the document accordingly.

Resolving this issue with PR: https://github.com/MicrosoftDocs/azure-docs-pr/compare/main...duongau:patch-5. #please-close


[docs] Fix typo in broker.conf and standalone.conf

Fixed typo in Resource usage ThresholdShedder in configuration comments.

@Jennifer88huang Can you please review this?

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


feat: support kserve

feat: support kserve
kserve yaml demo:
kind: InferenceService
metadata:
  name: rtp-llm
spec:
  predictor:
    containers:
    - command:
        - "/opt/conda310/bin/python"
        - "-m"
        - "maga_transformer.kserve_server"
      env:
        - name: MODEL_TYPE
          value: phi
        - name: TOKENIZER_PATH
          value: /model/path/
        - name: CHECKPOINT_PATH
          value: /model/path/
      image: <test image url>
      name: kserve-container
      resources:
        limits:
          cpu: "2"
          memory: 8Gi
          nvidia.com/gpu: "1"
        requests:
          cpu: "2"
          memory: 8Gi
          nvidia.com/gpu: "1"

test:
curl http://<ingress_host>:<ingress_port>/v2/models/rtp-llm/generate_stream -d '{"text_input":"hi","parameters":{"max_new_tokens":10}}'  -H "content-type:application/json"

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

https://github.com/kserve/kserve/pull/3480

rely on pr: kserve/kserve#3480

Hope this PR gets accepted by the KServe community soon. XDD

https://github.com/kserve/kserve/pull/3374 kserve has updated the version of fastapi & unicorn


feat(protocol-designer): wire up loadFixture for waste chute in fileCreator

closes RAUT-687 RAUT-723
Overview
Now that loadFixtureCreateCommand type exists in v7 command types, I wired up creating the command in file creator and importing as well.
Test Plan

make sure the deck configuration FF is turned on and create a protocol for the Flex. Go through the form and add a waste chute. Export the protocol. Look at the json file and see that there is a loadFixture command with the proper params.
Change the version from 7.0.0 to 7.1.0 in the json file (this is so the protocol doesn't go through a migration)
import the protocol back into PD. See that the waste chute entity exists in the Additional Items section

Changelog

extend createSelector to support 15 selectors
add loadFixture command support to fileCreator and the step form reducer
fix test
also wire up nicknames for the labware as the display name if it exists. apparently nicknames weren't being carried over to the json protocol this whole time 😅

Review requests
see test plan
Risk assessment
low

Is this expected behavior?
For pipette part, the wizard shows the selected item when clicking back button.
https://github.com/Opentrons/opentrons/assets/474225/6a670428-67a2-4e99-920a-60e1ecb10661

Is this expected behavior? For pipette part, the wizard shows the selected item when clicking back button.
Screen.Recording.2023-10-05.at.5.01.11.PM.mov

@koji oh good catch! I didn't notice. It should probably keep the staging slot behavior.


Add fallback search

Alfred supports a concept of a "fallback search", if you type something in, you can try selecting a fallback method for searching like on Google, or whatever. It'd be cool to have that for obsidian too.
Here's the alfred docs: https://www.alfredapp.com/help/workflows/triggers/fallback-search/
A URI handler for search was added in 0.9.7: https://forum.obsidian.md/t/add-search-as-an-uri-action/6063/5
I was able to get this working locally with:

I copied one of the existing osascripts, and updated it to:
// step 1: specify vault name
v = "your-vault";

// search query
p="{query}";

// construct uri
uri = "obsidian://search?vault=" + v + "&query=" + encodeURIComponent(p);

// get the current app to access the standard additions
app = Application.currentApplication();
app.includeStandardAdditions = true;

// search in vault
app.openLocation(uri);
console.log(uri);

This feature is actually very similar to searching with Alfred's file filters, which are used by the os, ot, and or keywords. I can try to add Obsidian's search URI to these three file filters, though I wonder it's actually that useful, since Alfred's file filters are already quite powerful. I guess the main benefit of the search URI is that it opens up the search (and results) pane in Obsidian.
To address the fallback suggestion, I could call Obsidian's search URI only if no matching files are found with the os, ot, and or keywords. Then again, it'll just open the search pane in Obsidian that says no matches found. How useful would that be?
Let me think about it more. Thoughts/suggestions welcomed!

This feature is actually very similar to searching with Alfred's file filters, which are used by the os, ot, and or keywords. I can try to add Obsidian's search URI to these three file filters, though I wonder it's actually that useful, since Alfred's file filters are already quite powerful. I guess the main benefit of the search URI is that it opens up the search (and results) pane in Obsidian.

Keep in mind fallback happens when you are typing into Alfred, and it's not intended to list out potential results. The other fallback searches I have search on google or in devonthink. That would include if os and friends fail to find anything. It wouldn't be overly
The way I'm trying to use this is to have a quick way to searching google, obsidian, devonthink without having to figure out which one I want to do when I start typing. I'd use os if I was trying to find something I knew was in obsidian.

If possible, could you make a gif of your use case? I can't say I'm 100% sure of the intended use case or how you're using it or planning to use it (based on the code you provided above). Thanks!

Got it! Do you want to check out the implemention in this branch and let me know if you like it? It also asks you to indicate which vault to search in before performing the search. Let me know what you think.

I've released a new version and will close this issue. Thanks!


feature: Replace Feature with DefFeature

We need to move from class based approach for Features to instance based.
Right now features are still setup for evaluation (#289) this makes no sense with the rest of the codebase at this point. We must clean this up.
Other than that we also need to make Feature a dataclass or namedtuple or something. The point here being that .name() should just be .name and .NAME shouldn't exist anymore (same for dtype).

@pdxjohnny, I am working on this issue.

@Naeemkh Awesome! This will be great!

Essentially, we want to remove this code:
https://github.com/intel/dffml/blob/4c1e7870dba12c298d5a7f4740a23af634cacb7e/dffml/feature/feature.py#L160-L187
And replace
https://github.com/intel/dffml/blob/4c1e7870dba12c298d5a7f4740a23af634cacb7e/dffml/feature/feature.py#L19
With
@dataclasses.dataclass
class Feature:
    name: str
    dtype: Type # from typing import Type
    length: Union[int, List[int]]

    # ... All the existing methods in feature (but not dtype and length)

We'll also go through and remove all references to DefFeature and replace them with Feature

Right now to create a new Feature you have to make a whole new class. What we're trying to do here is have Feature be a class. And have features be instances of that class. Rather than other classes which are subclasses of Feature.


Fixes #1545 Top crashes on Play Store for v2.7.1 [A and E]

Description
Fixes A and E from #1545 (I hope). It saves file which is being uploaded to a temp location, and uses Uri of that file as reference during upload process, instead of using Uri that content provider supported.
Tests performed (required)
Tested on API 23, beta debug. Tested actions: share photo from another application, share multiple photos from another application and contributing via contributions list.
Not: This branch is rebased to 2.8-release branch. First branch is closed to prevent confusion.

@misaochan Ready!:)

Codecov Report

Merging #1720 into 2.8-release will increase coverage by <.01%.
The diff coverage is 4.03%.

@@              Coverage Diff               @@
##           2.8-release   #1720      +/-   ##
==============================================
+ Coverage         3.89%    3.9%   +<.01%
==============================================
  Files              151     154       +3
  Lines             7521    7630     +109
  Branches           705     722      +17
==============================================
+ Hits               293     298       +5
- Misses            7211    7314     +103
- Partials            17      18       +1

Impacted Files
Coverage Δ

...e/nrw/commons/category/CategoryImagesActivity.java
0% <ø> (ø)
:arrow_up:

...java/fr/free/nrw/commons/nearby/PlaceRenderer.java
0% <ø> (ø)
:arrow_up:

...fr/free/nrw/commons/media/MediaDetailFragment.java
0% <ø> (ø)
:arrow_up:

...nrw/commons/upload/MultipleUploadListFragment.java
0% <ø> (ø)
:arrow_up:

...ava/fr/free/nrw/commons/nearby/NearbyActivity.java
0% <ø> (ø)
:arrow_up:

.../java/fr/free/nrw/commons/nearby/DirectUpload.java
0% <ø> (ø)
:arrow_up:

...c/main/java/fr/free/nrw/commons/AboutActivity.java
0% <ø> (ø)
:arrow_up:

...rw/commons/upload/DetectUnwantedPicturesAsync.java
0% <ø> (ø)
:arrow_up:

...ree/nrw/commons/contributions/ContributionDao.java
0% <ø> (ø)
:arrow_up:

...ain/java/fr/free/nrw/commons/utils/ImageUtils.java
0% <ø> (ø)
:arrow_up:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d831c0...3eae3ac. Read the comment docs.

@neslihanturan I have good news and bad news.
Good news: The crash doesn't happen anymore with this PR. :)
Bad news: The issue with wrong pictures being displayed during multiple share still exists for my tests. For instance, when I picked 3 different photos on Google Photos and Share > Commons app, I get 3 of the same photo in the display (see below). Has this issue been fixed for you?


Add basic Google Analytics

This should really track user ID and organization ID to be useful,
but it's a start.
Closes #38

Where is the analytics data visible?

@barto74 I'll invite you both. :)