[Bug] Evicted head pod is not replaced

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
ray-operator
What happened + What you expected to happen
We've heard from users that the KubeRay operator does not attempt to replace evicted head pods.
We should
(1) Determine if that's the case in master by forcing pod eviction (or by inspecting the code)
(2) Fix the issue if it is present.
Reproduction script
To be constructed!
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Hmm..I wonder if the HA efforts will cover this?

Maybe not in a comprehensive enough way since HA will apply only to Ray >= 2.0.0

We can either delete evict pod or create a new one

What about deleting the evicted pod and breaking out until the next reconcile iteration?

...also that status indicates we might need to provide guidance on how to handle ephemeral storage better

I think you can force eviction using kubectl drain on a node.

Probably, it would be interesting to check what the deployment/replicaset controllers do in this circumstance...

The suggested change sounds good to me!


Windows Build instructions don't work

Related to #610 and #611

Most of the problems seem to come from conan. Maybe we can just get rid of it and download dependencies manually?


Fix for getting other content item localzation.

LocalizationPartRecord for specific content usually looks like:

Id
CultureId
MasterContentItemId

25
2
0

1236
3
25

1237
4
25

And when someone try to get another localization item for non-master content item that function returns nothing.

Maybe the only change to do is to actually change the query to
(l.Id == content.ContentItem.Id || l.MasterContentItemId == content.ContentItem.Id || l.MasterContentItemId == content.Record.MasterContentItemId)

I removed the check for equality a seeking and a current content culture. It was added for performance, but i did not do any tests for it.
(l.Id == content.ContentItem.Id || l.MasterContentItemId == content.ContentItem.Id || l.MasterContentItemId == localized.Record.MasterContentItemId)
This code will not find master culture by non-master one.
It should be extend to
(l.Id == content.ContentItem.Id || l.MasterContentItemId == content.ContentItem.Id || l.MasterContentItemId == localized.Record.MasterContentItemId || l.Id == localized.Record.MasterContentItemId)
But i think that It looks more complicated.


Implementation of Lax Slice bicategory

The lax slice bicategory is like the slice category, but rather than a commuting triangle you get a 2-cell.
This is my first time using Agda in earnest so I am not very adept at using the module system, so some code review would help here for sure. I'm not really sure if I got the naming conventions right. I based most of the naming on the slice 1-category.
Some caveats

I still have two spots of yellow in Emacs when I type check on Line 310. I'm not sure how to debug this.
Type checking at least while it was incomplete became very slow. When I was working on the unitors I had to comment out the associator proofs to speed things up. Not sure what the best practice is for mitigating this. Should I break it up into multiple files? Maybe move the SliceHom module into a different file.
The proofs sometimes had several lines in a row of associativity, is there a simpler way to do this? A reflective free category solver maybe?
One proof (inverse of the right unitor) is a copy-paste-rename of the proof for the inverse of the left unitor. This should probably be a lemma instead.

Ok I think it's much better now. I did the following:

Moved all the imports to the top
Used explicit using for the top-level opens
Lifted a lot of local functions to definitions and got rid of all the lets instead using wheres
Used push/pull/center etc for the associativity arguments, which made the proofs much shorter.
Made the naming of arguments consistent.

Sorry for all the commits, I intended to squash them when the review was done

Actually, I kind of like fine-grained commits.


Consider updating PPND logic not to remain paused for update

Summary
Currently, the PPND logic performs this sequence:

Pause pipeline and wait for it to go to Paused
Update pipeline keeping it paused and wait for that to be reconciled
Run pipeline

For Step 2, I'd decided to be paranoid in keeping it paused because I didn't want the Numaflow Controller to scale up prior to updating the Vertices; however, I can see in Numaflow that it follows this sequence:

Update, create, and delete all Vertex specs (if an error occurs, stop and return error)
Patch Vertex spec to scale up (setting replicas > 0)

Motivation
When we perform a topology change on the Pipeline, the Pipeline Controller creates a Job which creates new buffers, and buckets. Then the daemon and the vertex Pods restart with an init container that waits for those buffers and buckets to be created.
When we issue desiredPhase=Paused (even in the case of Pipeline already being paused), Numaflow tries to connect to the daemon to determine # of pending messages. If this is happening at the same time that the Job is being created and the daemon is waiting for the buffers to exist, then Numaflow will be waiting for the daemon. Theoretically, everything should work in due time, but there seem to be some issues.

Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

Just talked to Derek and Sidhant about this issue - instead of doing that and since there is a real use case regardless that user may actually want desiredPhase=Paused while updating topology, Sidhant will update Numaflow Controller to not try to contact the daemon while Pipeline is paused to see if that alleviates some issues.


Generalize Emitter to support the LLVM backend

Currently, the Emitter interface assumes that you're producing strings. This works for generating JavaScript and GLSL, but it won't work for LLVM, where we'll need the functions to produce llvm.Value and other such objects.
One way to get started might be to make Emitter a generic interface: i.e., Emitter<string> would be the current configuration. Or, it might be less disruptive to make the current Emitter inherit from a new BaseEmitter that adds more generality.

Likewise, we might be able to generalize some of the stuff in emitutils.ts.

After staring at this for a little while, it seems to me that there is a second big difference between the existing backends and the new LLVM backend: statefulness. In the string-based backends, a call to emit any expression returns a string; each function is pure. In the LLVM backend, there's really no way around using an imperative style: a call to emit an expression will insert new instructions into the program via calls to the Builder.
For that reason, I totally agree with your strategy in #5 to start with a totally separate LLVMEmitter that doesn't share anything with the base emitters… and then later try to merge what we can. But the two styles will be so different that merging them might not be as straightforward as we thought.
For performance reasons, we might even eventually want to move the old emitters to the new imperative style. Passing around short strings everywhere is probably not great for efficiency.

OK, after having done my fiddling, I think that's my conclusion for now: let's stick with building a totally separate backend that doesn't reuse much of the existing infrastructure. If this means duplicating a bunch of stuff in emitutil and emitter, so be it—let's build something messy now and see what we can align later.
Thanks for talking through this!

Sounds like a plan. Will do!
I'll try to at least make it clear what's duplicated though. Just so it's easier to clean things up, should we ever decide to.


map() stops every 1000 steps

Describe the bug
I am passing the following prepare_dataset function to Dataset.map (code is inspired from here)
def prepare_dataset(batch):
    # load and resample audio data from 48 to 16kHz
    audio = batch["audio"]

    # compute log-Mel input features from input audio array
    batch["input_features"] = feature_extractor(audio["array"], sampling_rate=audio["sampling_rate"]).input_features[0]

    # encode target text to label ids
    batch["labels"] = tokenizer(batch[text_column]).input_ids
    return batch
...
train_ds = train_ds.map(prepare_dataset)

Here is the exact code I am running https://github.com/bayartsogt-ya/whisper-multiple-hf-datasets/blob/main/train.py#L70-L71
It starts using all the cores (I am not sure why because I did not pass num_proc)
then progress bar stops at every 1k steps. (starts using a single core)
then come back to using all the cores again.
link to screen record
Can someone explain this process and maybe provide a way to improve this pipeline? cc: @lhoestq
Steps to reproduce the bug

load the dataset
create a Whisper processor
create a prepare_dataset function
pass the function to dataset.map(prepare_dataset)

Expected behavior

Use a single core per a function
not to stop at some point?

Environment info

datasets version: 2.7.1.dev0
Platform: Linux-5.4.0-109-generic-x86_64-with-glibc2.27
Python version: 3.8.10
PyArrow version: 10.0.1
Pandas version: 1.5.2

Hi @lhoestq
Thanks for the explanation! it was so helpful! Let me check why feature_extractor is running on multiple cpus.


Update docs

Overhaul on docs & typescript definitions to match https://dfuse.io/#websockets-based-api

@maoueh Please have a look and see if this syntax style "works" moving forward.
Each method has 3 main parts:

required params
extra data params
optional params


Cannot find super in PATH

Fresh first time installation produces this error:
Cannot find super in PATH

Which editor are you using? VSCode?

Apologies for the lack of detail.
Yes, VS Code running on Windows 10.

Update your vscode and the superhtml extension. Recent versions of the extension don't even try to find any executable on your system.


Update the workflow profile and add eta to scp list filter

Sorry to bother you again.
I updated the workflow file since the previous commit used the old one, but I do not know whether the workflow file matches the source code.
I also find an issue. I am not sure if it is a bug or not.
There is no notification for including the BibTeX path on the welcome page. Could you check it since it is more than I can handle?
Many thanks,
Jiaxin
.

Its just merged, not released yet.
That way it will be included in the next release.

Also, for keeping backward compatibility with Alfred 4, the workflow is not using the new Alfred 5 user configuration, for now.


customElements is undefined in IE11

[X] bug
[ ] feature request
[ ] enhancement

### Actual behavior

First example in https://vmware.github.io/clarity/documentation/v0.12/input-fields
IE11 error: customElements is undefined

### Reproduction of behavior

First example in https://vmware.github.io/clarity/documentation/v0.12/input-fields

### Environment details

* **Angular version:** 6.x.x

* **Clarity version:** 0.12

* **Browser:** IE11

### Workaround

In "angular.json" file change script order from default

"scripts": [
<EMAIL_ADDRESS><EMAIL_ADDRESS>]

to

"scripts": [
<EMAIL_ADDRESS><EMAIL_ADDRESS>]

(default script order is generated by the command "ng add @clr/angular@next")

Change in default script order described above leads to many of clarity components goes into a non-working state (i.e. this workaround not working).

I'm not clear about how the https://vmware.github.io/clarity/documentation/v0.12/input-fields page is an example, I see it loading fine in IE11. I am fixing the bug with ng add @clr/angular so it orders them correctly.
https://live.browserstack.com/issue-tracker/58d2510c4afd9a6bcd37dd2492cc6dd29fd9afd4/win10_ie_11.0.jpg

After changing script order to
"scripts": [
<EMAIL_ADDRESS><EMAIL_ADDRESS>]
datagrid and modals stop working in ie11 (and i guess many others components), so i think this workaround is not a good decision.
As to "IE11 error: customElements is undefined", i can't reproduce it on https://vmware.github.io/clarity/documentation/v0.12/input-fields page (i just copy code of the first example to my project) and on plunker https://stackblitz.com/edit/clarity-light-theme-v11-znjrkx. I can reproduce this error only in my project.
I think there are some differencies in environments config of these pages and my project. I'm using clarity 0.12 and
Angular CLI: 6.0.8
Node: 10.1.0
OS: win32 x64
Angular: 6.0.4
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
Package                           Version
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/cli                      6.0.8
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.8
rxjs                              6.2.0
typescript                        2.7.2
webpack                           4.8.3
Content of files "app.component.ts" / "app.component.html" can be found at https://stackblitz.com/edit/clarity-light-theme-v11-znjrkx
Result:

This appears to be an issue related to the build and setting up the polyfill. I'm not sure what you're doing in your build, nor do I see this issue in the stackblitz you provided in IE11. Are you including the polyfill twice (in polyfills.ts and in angular.json)? Otherwise, if you have a custom webpack build there are some possibilities that your build could mangle it in a way that it breaks the polyfill see https://github.com/webcomponents/custom-elements/issues/90#issuecomment-304421398

I finally found the cause of the IE11 error (thanks for polfills mention) - in polyfills.ts uncomment line:
import 'core-js/es6/reflect';
and yes, it's needed to change script order in angular.json with polyfill in first:
"scripts": [
<EMAIL_ADDRESS><EMAIL_ADDRESS>]
My polyfill.ts file looks like this now:
/** IE9, IE10 and IE11 requires all of the following polyfills. **/
import 'core-js/es6/symbol';
import 'core-js/es6/object';
import 'core-js/es6/function';
import 'core-js/es6/parse-int';
import 'core-js/es6/parse-float';
import 'core-js/es6/number';
import 'core-js/es6/math';
import 'core-js/es6/string';
import 'core-js/es6/date';
import 'core-js/es6/array';
import 'core-js/es6/regexp';
import 'core-js/es6/map';
import 'core-js/es6/weak-map';
import 'core-js/es6/set';
import 'core-js/es6/reflect';
import 'core-js/es7/reflect';
import 'zone.js/dist/zone';
And now there aren't any errors in IE11:)
I think information about all necessary polyfills should be included in your "Get started" page:
https://vmware.github.io/clarity/documentation/v0.12/get-started
otherwise this information will have to be obtained empirically :)

I refer you to Angular's details about IE11 https://angular.io/guide/browser-support

Thanks!


Support for displaying a MODEL/ENDMDL ensemble

It is refreshing to see pv. Reading through the doc, I found that "In case multiple models are present in the file (as designated by MODEL/ENDMDL), only the first is read." Would it be possible for pv to read multiple structures and display one at a time? This functionality would be handy for visualizing a set of relevant structures in one MODEL/ENDMDL ensemble, as for NMR structures in the PDB.
Thanks,
Xiang-Jun

I've added support for loading all structures from a multi-pdb file. By default, only the first model is read. To load all models, you must pass loadAllModels : true to pv.io.pdb. Example use:
  pv.io.fetchPdb('/pdbs/1nmr.pdb', function(structures) {
    viewer.clear()
    for (var i = 0; i < structures.length; ++i) {
      viewer.cartoon('ensemble_'+ i, structures[i]);
    }
    viewer.autoZoom();
  }, { loadAllModels : true } );

Very neat! Could you also show an example where each model can be displayed one-by-one by keyboard/mouse click as in Jmol/JSmol?

One more point: the pv MODEL/ENDMDL ensemble reader seems to assume just different conformations of the same structure as in PDB NMR structures. However, for my purpose, I use the MODEL/ENDMDL ensemble to collect a set of related but different structures. As a concrete example, the four triplets in the yeast phenylalanine tRNA (1ehz, see file '1ehz-triplets.pdb': http://x3dna.org/luxfiles/1ehz-triplets.pdb) cannot be displayed using your sample code. Any play to support this non-canonical use of MODEL/ENDMDL ?

This code shows how to display only one structure at a time. By pressing 'n', 'p', the next/previous structure is shown.

var ENSEMBLE = null;

var activeIndex = 0;

function ensemble() {
  io.fetchPdb('/pdbs/1nmr.pdb', function(structures) {
    viewer.clear()
    var i = 0;
    ENSEMBLE = structures.map(function(a) {
      return viewer.cartoon('ensemble.' + i++, a);
    });
    updateVisibility();
    viewer.autoZoom();
  }, { loadAllModels : true } );
}
function updateVisibility() {
  ENSEMBLE.forEach(function(a) { a.hide(); });
  ENSEMBLE[activeIndex].show();
  viewer.requestRedraw();
}

$(document).keypress(function(ev) {
  if (String.fromCharCode(ev.charCode) === 'n') {
    activeIndex = (activeIndex + 1)  % ENSEMBLE.length;
    updateVisibility();
  }
  if (String.fromCharCode(ev.charCode) === 'p') {
    // make sure we never calculate modulo on negative value
    activeIndex = (activeIndex - 1 + ENSEMBLE.length)  % ENSEMBLE.length;
    updateVisibility();
  }
});

Regarding your second question: I've downloaded your 1ehz-triplets.pdb triplet and used it with the sample code.  The multi-model PDB loading code loads them just fine. Since the structures contain 3 separate amino acids that are not directly connected, the cartoon render mode is not able to display anything (it requires at least a peptide bond). You will have to use one of the modes that display structures at full connectivity level. If you change the cartoon call to e.g. lines, the structures are displayed just fine.
For your use-case  the multi-PDB loading code should work just fine. The only part which assumes that the structures are related are the secondary structure and BIOMT assignment code. As long as you do not have secondary structure definitions and REMARK 350 records in your PDB file, you are safe. In case that's a problem for your, I'll add an option to disable REMARK 30 and secondary structure records (HELIX, SHEET) loading.

Thank you so much for your effort in making pv to support the display of an MODEL/ENDMDL ensemble. It is understandable why the cartoon mode does not display the dis-connected base triplets in my 1ehz-triplets.pdb file. All I need right now is that is can be displayed in  e.g. lines mode, with nucleotides labeled. My field is in nucleic acid structures, so the default setting in pv may not directly apply.
I am not that familiar with JavaScript yet. Playing your updated code (with 'n'/'p') in the small sample application in pv doc page, I did not see any structure shown. Presumably I am missing something simple. Would it be possible that you create a complete example (using 1ehz-triplets.pdb) to show the new pv functionality for displaying an MODEL/ENDMDL ensemble? Ideally, the initially display shows only the first model, with 'n' and 'p' for the next and previous model, and 'e' for the whole ensemble as shown in your initial code example.
Thanks a lot.

The following (complete) example doe what you want. You will have to add bio-pv.min.js and 1ehz-triplet.pdf to the same folder containing the sample page below.

  <title>Sample</title>
  <meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0">

That's brilliant -- Just tested and it works!
I completely echo your minimal, self-contained approach. I will certainly use pv in the future. It may also be possible that we do something together to bring more DSSR functionality for nucleic acid structures into pv. See sample illustrations. There is currently a DSSR/Jmol interface and a DSSR plugin for PyMOL is in progress.
Best regards,

I'm glad the sample worked for you. That's one of the main advantages of a pure JS viewer. It's very easy to extend with custom functionality.
Thanks for the sample illustrations! Representation of DNA and RNA is certainly not PV's strong point. From my perspective having support for the block representation is certainly feasible and not too far off. The functionality for the block representation is all there and just need to be glued together. The trickiest part is to fit the blocks to the base atoms.
I've created ticket #106 to track progress for this feature. I'm not sure how much time I'll have to work on this in the coming months, so don't expect progress right away. Any help in that area is more than welcome.
Best,
Marco


Unable to clear phone number

I need to reset the phonenumber field after a user session on a kiosk.  When I set my bound value $phoneNumber = "" the formatted number is still displayed in the textfield. Any suggestions on clearing the value programmatically?
Thanks!

up

You can do it from v0.8.0


How can I change change Icons color on Header and Menu Bar easily?

Hi,
@siriwatknp, I am trying to change Icons color on Header and Menu Bar. But Is there an easy way to do this?
Many thanks,
Onur

I solved by passing className to SidebarTrigger and menu icon colour changed.
Thank you:)


gtk.go, gtk.h: Pass correct GObject type to gtk.TreeStore.SetValue().

Fix for issue #45: apply the same method as used for gtk.ListStore, to pass gdk.Pixbuf objects to
gtk.TreeStore.

it is a duplicate merge request (see https://github.com/gotk3/gotk3/pull/46).
sorry :-)


Make migration path configurable

In https://github.com/theofidry/AliceDataFixtures I also need access to this migration path so making it configurable via a parameter makes it easier :)

There are quite some test failures, can you please take a look at those?

I'll do tomorrow, I believe it's because you're using a Test command class which relies on the container, but the kernel is not booted so the parameter is not found

ping @theofidry
I'm planning on releasing a new minor release this weekend. If you can fix this before that, it would be awesome. Otherwise, I'll try to finish this on saturday.

@wouterj soz will try to have a look tomorrow depending of how it goes at work. I won't be able to finish it this weekend so it will either be tomorrow or nothing

No problem. I'm happy enough to have someone submitting PRs for this bundle :)
Finished this in https://github.com/wouterj/WouterJEloquentBundle/pull/28


Bug: Story table doesn't use trigger variable when it should

kiln v3.0.3 <- we need to put these version numbers in reports
I was running tests for AssemblyLine recently and noticed some were passing that should be failing (the exhibits tests). A row was being used for two pages when it should have just been used for one.
    | var | value | trigger |
    | x.has_exhibits | True | exhibit_doc_defaults_1.exhibits.has_exhibits |

The exhibit_doc_defaults_1.exhibits.has_exhibits trigger variable wasn't preventing this row from setting its value for a page with a different trigger variable.
Debugging logs showed this:
First page, which was handled correctly: page trigger "trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits", matches:
[{"original":{"var":"x.has_exhibits","value":"True","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},"var":"x.has_exhibits","value":"True","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits","times_used":0}]

On the second loop, the match is clearly incorrect: page trigger "trigger":"exhibit_doc_custom_1.exhibits.has_exhibits", matches:
[{"original":{"var":"x.has_exhibits","value":"True","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},"var":"x.has_exhibits","value":"True","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits","times_used":1}]

You can see the trigger variables in that second loop don't match each other. Haven't yet looked into why that would be, but this test is passing incorrectly.
Full test:
@alexhibits @e2
Scenario: User adds only a docx exhibit
  And the max seconds for each step is 200
  Given I start the interview at "test_alexhibit"
  And I get to "end alexhibit tests" with this data:
    | var | value | trigger |
    | x.has_exhibits | True | exhibit_doc_defaults_1.exhibits.has_exhibits |
    | x[0].title | DOCX only | exhibit_doc_defaults_1.exhibits.has_exhibits |
    | x[0].pages | test_alexhibit_docx_1.docx | exhibit_doc_defaults_1.exhibits.has_exhibits |
    | x[i].pages.target_number | 1 | exhibit_doc_defaults_1.exhibits[0].pages.there_is_another |
    | x.target_number | 1 | exhibit_doc_defaults_1.exhibits.there_is_another |

Full debug:
User adds only a docx exhibit
Report:
 type: heading, value:
---------------
Scenario: User adds only a docx exhibit aldocument alexhibits e
---------------
..Trace: Getting project name
.scope.normalizedTable():
 [{"original":{"var":"x.has_exhibits","value":"True","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},"var":"x.has_exhibits","value":"True","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits","times_used":0},{"original":{"var":"x[0].title","value":"DOCX only","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},"var":"x[0].title","value":"DOCX only","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits","times_used":0},{"original":{"var":"x[0].pages","value":"test_alexhibit_docx_1.docx","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},"var":"x[0].pages","value":"test_alexhibit_docx_1.docx","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits","times_used":0},{"original":{"var":"x[i].pages.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits[0].pages.there_is_another"},"var":"x[i].pages.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits[0].pages.there_is_another","times_used":0},{"original":{"var":"x.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits.there_is_another"},"var":"x.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits.there_is_another","times_used":0}]
~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~
Report:
 type: page_id, value: any-exhibits
page fields:
[{"selector":"#daquestion input[name=\"eC5oYXNfZXhoaWJpdHM\"][value=\"True\"][id=\"eC5oYXNfZXhoaWJpdHM_0\"][class=\"da-to-labelauty labelauty da-active-invisible dafullwidth\"]","tag":"input","guesses":[{"var":"x.has_exhibits","value":"True"}],"type":"radio","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},{"selector":"#daquestion input[name=\"eC5oYXNfZXhoaWJpdHM\"][value=\"False\"][id=\"eC5oYXNfZXhoaWJpdHM_1\"][class=\"da-to-labelauty labelauty da-active-invisible dafullwidth\"]","tag":"input","guesses":[{"var":"x.has_exhibits","value":"False"}],"type":"radio","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},{"selector":"#daquestion input[name=\"X2ZpZWxkXzI\"][id=\"X2ZpZWxkXzI\"][class=\"form-control\"]","tag":"input","guesses":[{"var":"x[0].title","value":""}],"type":"text","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},{"selector":"#daquestion input[id=\"fileinput-X2ZpZWxkXzM\"][class=\"file-caption-name\"]","tag":"input","guesses":[],"type":"","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},{"selector":"#daquestion input[name=\"X2ZpZWxkXzM\"][id=\"X2ZpZWxkXzM\"][class=\"dafile\"]","tag":"input","guesses":[{"var":"x[0].pages","value":""}],"type":"file","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},{"selector":"#daquestion button[class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[],"type":"submit","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"}]
matches:
 [{"original":{"var":"x.has_exhibits","value":"True","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},"var":"x.has_exhibits","value":"True","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits","times_used":0}]
Report:
 type: row, value:       | x.has_exhibits | True | exhibit_doc_defaults_1.exhibits.has_exhibits |
*matches:
 []
matches:
 [{"original":{"var":"x[0].title","value":"DOCX only","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},"var":"x[0].title","value":"DOCX only","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits","times_used":0}]
Report:
 type: row, value:       | x[0].title | DOCX only | exhibit_doc_defaults_1.exhibits.has_exhibits |
*matches:
 []
matches:
 [{"original":{"var":"x[0].pages","value":"test_alexhibit_docx_1.docx","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},"var":"x[0].pages","value":"test_alexhibit_docx_1.docx","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits","times_used":0}]
Report:
 type: row, value:       | x[0].pages | test_alexhibit_docx_1.docx | exhibit_doc_defaults_1.exhibits.has_exhibits |
*matches:
 []
matches:
 []
matches:
 []
>~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~
Report:
 type: page_id, value: exhibit-i-has-additional-pages
page fields:
[{"selector":"#daquestion button[class=\"btn btn-link btn-da daquestionbackbutton danonsubmit\"]","tag":"button","guesses":[],"type":"button","trigger":"exhibit_doc_defaults_1.exhibits[0].pages.there_is_another"},{"selector":"#daquestion button[name=\"eFtpXS5wYWdlcy50aGVyZV9pc19hbm90aGVy\"][value=\"False\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"x[i].pages.there_is_another","value":"False"}],"type":"submit","trigger":"exhibit_doc_defaults_1.exhibits[0].pages.there_is_another"},{"selector":"#daquestion button[name=\"eFtpXS5wYWdlcy50aGVyZV9pc19hbm90aGVy\"][value=\"True\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"x[i].pages.there_is_another","value":"True"}],"type":"submit","trigger":"exhibit_doc_defaults_1.exhibits[0].pages.there_is_another"}]
matches:
 []
matches:
 [{"artificial":true,"source":{"original":{"var":"x[i].pages.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits[0].pages.there_is_another"},"var":"x[i].pages.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits[0].pages.there_is_another","times_used":0},"var":"x[i].pages.there_is_another","value":"False","trigger":"exhibit_doc_defaults_1.exhibits[0].pages.there_is_another"}]
Report:
 type: row, value:       | x[i].pages.target_number | 1 | exhibit_doc_defaults_1.exhibits[0].pages.there_is_another |
v~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~
Report:
 type: page_id, value: another-exhibit
page fields:
[{"selector":"#daquestion button[class=\"btn btn-link btn-da daquestionbackbutton danonsubmit\"]","tag":"button","guesses":[],"type":"button","trigger":"exhibit_doc_defaults_1.exhibits.there_is_another"},{"selector":"#daquestion button[name=\"eC50aGVyZV9pc19hbm90aGVy\"][value=\"False\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"x.there_is_another","value":"False"}],"type":"submit","trigger":"exhibit_doc_defaults_1.exhibits.there_is_another"},{"selector":"#daquestion button[name=\"eC50aGVyZV9pc19hbm90aGVy\"][value=\"True\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"x.there_is_another","value":"True"}],"type":"submit","trigger":"exhibit_doc_defaults_1.exhibits.there_is_another"}]
matches:
 []
matches:
 [{"artificial":true,"source":{"original":{"var":"x.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits.there_is_another"},"var":"x.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits.there_is_another","times_used":0},"var":"x.there_is_another","value":"False","trigger":"exhibit_doc_defaults_1.exhibits.there_is_another"}]
Report:
 type: row, value:       | x.target_number | 1 | exhibit_doc_defaults_1.exhibits.there_is_another |
v~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~
Report:
 type: page_id, value: any-exhibits
page fields:
[{"selector":"#daquestion input[name=\"eC5oYXNfZXhoaWJpdHM\"][value=\"True\"][id=\"eC5oYXNfZXhoaWJpdHM_0\"][class=\"da-to-labelauty labelauty da-active-invisible dafullwidth\"]","tag":"input","guesses":[{"var":"x.has_exhibits","value":"True"}],"type":"radio","trigger":"exhibit_doc_custom_1.exhibits.has_exhibits"},{"selector":"#daquestion input[name=\"eC5oYXNfZXhoaWJpdHM\"][value=\"False\"][id=\"eC5oYXNfZXhoaWJpdHM_1\"][class=\"da-to-labelauty labelauty da-active-invisible dafullwidth\"]","tag":"input","guesses":[{"var":"x.has_exhibits","value":"False"}],"type":"radio","trigger":"exhibit_doc_custom_1.exhibits.has_exhibits"},{"selector":"#daquestion input[name=\"X2ZpZWxkXzI\"][id=\"X2ZpZWxkXzI\"][class=\"form-control\"]","tag":"input","guesses":[{"var":"x[0].title","value":""}],"type":"text","trigger":"exhibit_doc_custom_1.exhibits.has_exhibits"},{"selector":"#daquestion input[id=\"fileinput-X2ZpZWxkXzM\"][class=\"file-caption-name\"]","tag":"input","guesses":[],"type":"","trigger":"exhibit_doc_custom_1.exhibits.has_exhibits"},{"selector":"#daquestion input[name=\"X2ZpZWxkXzM\"][id=\"X2ZpZWxkXzM\"][class=\"dafile\"]","tag":"input","guesses":[{"var":"x[0].pages","value":""}],"type":"file","trigger":"exhibit_doc_custom_1.exhibits.has_exhibits"},{"selector":"#daquestion button[class=\"btn btn-link btn-da daquestionbackbutton danonsubmit\"]","tag":"button","guesses":[],"type":"button","trigger":"exhibit_doc_custom_1.exhibits.has_exhibits"},{"selector":"#daquestion button[class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[],"type":"submit","trigger":"exhibit_doc_custom_1.exhibits.has_exhibits"}]
matches:
 [{"original":{"var":"x.has_exhibits","value":"True","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},"var":"x.has_exhibits","value":"True","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits","times_used":1}]
Report:
 type: row, value:       | x.has_exhibits | True | exhibit_doc_defaults_1.exhibits.has_exhibits |
*matches:
 []
matches:
 [{"original":{"var":"x[0].title","value":"DOCX only","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},"var":"x[0].title","value":"DOCX only","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits","times_used":1}]
Report:
 type: row, value:       | x[0].title | DOCX only | exhibit_doc_defaults_1.exhibits.has_exhibits |
*matches:
 []
matches:
 [{"original":{"var":"x[0].pages","value":"test_alexhibit_docx_1.docx","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits"},"var":"x[0].pages","value":"test_alexhibit_docx_1.docx","trigger":"exhibit_doc_defaults_1.exhibits.has_exhibits","times_used":1}]
Report:
 type: row, value:       | x[0].pages | test_alexhibit_docx_1.docx | exhibit_doc_defaults_1.exhibits.has_exhibits |
*matches:
 []
matches:
 []
matches:
 []
matches:
 []
matches:
 []
>~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~
Report:
 type: page_id, value: exhibit-i-has-additional-pages
page fields:
[{"selector":"#daquestion button[class=\"btn btn-link btn-da daquestionbackbutton danonsubmit\"]","tag":"button","guesses":[],"type":"button","trigger":"exhibit_doc_custom_1.exhibits[0].pages.there_is_another"},{"selector":"#daquestion button[name=\"eFtpXS5wYWdlcy50aGVyZV9pc19hbm90aGVy\"][value=\"False\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"x[i].pages.there_is_another","value":"False"}],"type":"submit","trigger":"exhibit_doc_custom_1.exhibits[0].pages.there_is_another"},{"selector":"#daquestion button[name=\"eFtpXS5wYWdlcy50aGVyZV9pc19hbm90aGVy\"][value=\"True\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"x[i].pages.there_is_another","value":"True"}],"type":"submit","trigger":"exhibit_doc_custom_1.exhibits[0].pages.there_is_another"}]
matches:
 []
matches:
 [{"artificial":true,"source":{"original":{"var":"x[i].pages.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits[0].pages.there_is_another"},"var":"x[i].pages.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits[0].pages.there_is_another","times_used":1},"var":"x[i].pages.there_is_another","value":"False","trigger":"exhibit_doc_defaults_1.exhibits[0].pages.there_is_another"}]
Report:
 type: row, value:       | x[i].pages.target_number | 1 | exhibit_doc_defaults_1.exhibits[0].pages.there_is_another |
v~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~
Report:
 type: page_id, value: another-exhibit
page fields:
[{"selector":"#daquestion button[class=\"btn btn-link btn-da daquestionbackbutton danonsubmit\"]","tag":"button","guesses":[],"type":"button","trigger":"exhibit_doc_custom_1.exhibits.there_is_another"},{"selector":"#daquestion button[name=\"eC50aGVyZV9pc19hbm90aGVy\"][value=\"False\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"x.there_is_another","value":"False"}],"type":"submit","trigger":"exhibit_doc_custom_1.exhibits.there_is_another"},{"selector":"#daquestion button[name=\"eC50aGVyZV9pc19hbm90aGVy\"][value=\"True\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"x.there_is_another","value":"True"}],"type":"submit","trigger":"exhibit_doc_custom_1.exhibits.there_is_another"}]
matches:
 []
matches:
 [{"artificial":true,"source":{"original":{"var":"x.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits.there_is_another"},"var":"x.target_number","value":"1","trigger":"exhibit_doc_defaults_1.exhibits.there_is_another","times_used":1},"var":"x.there_is_another","value":"False","trigger":"exhibit_doc_defaults_1.exhibits.there_is_another"}]
Report:
 type: row, value:       | x.target_number | 1 | exhibit_doc_defaults_1.exhibits.there_is_another |
v~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~
Report:
 type: page_id, value: thumbnails-defaults
page fields:
[{"selector":"#daquestion button[class=\"btn btn-link btn-da daquestionbackbutton danonsubmit\"]","tag":"button","guesses":[],"type":"button","trigger":"thumbnails_defaults"},{"selector":"#daquestion button[name=\"dGh1bWJuYWlsc19kZWZhdWx0cw\"][value=\"True\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"thumbnails_defaults","value":"True"}],"type":"submit","trigger":"thumbnails_defaults"}]
matches:
 []
matches:
 []
>~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~
Report:
 type: page_id, value: download-list-defaults
page fields:
[{"selector":"#daquestion button[class=\"btn btn-link btn-da daquestionbackbutton danonsubmit\"]","tag":"button","guesses":[],"type":"button","trigger":"download_list_defaults"},{"selector":"#daquestion button[name=\"ZG93bmxvYWRfbGlzdF9kZWZhdWx0cw\"][value=\"True\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"download_list_defaults","value":"True"}],"type":"submit","trigger":"download_list_defaults"}]
matches:
 []
matches:
 []
>~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~
Report:
 type: page_id, value: thumbnails-custom
page fields:
[{"selector":"#daquestion button[class=\"btn btn-link btn-da daquestionbackbutton danonsubmit\"]","tag":"button","guesses":[],"type":"button","trigger":"thumbnails_custom"},{"selector":"#daquestion button[name=\"dGh1bWJuYWlsc19jdXN0b20\"][value=\"True\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"thumbnails_custom","value":"True"}],"type":"submit","trigger":"thumbnails_custom"}]
matches:
 []
matches:
 []
>~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~
Report:
 type: page_id, value: download-list-html-custom-1
page fields:
[{"selector":"#daquestion button[class=\"btn btn-link btn-da daquestionbackbutton danonsubmit\"]","tag":"button","guesses":[],"type":"button","trigger":"download_list_html_custom_1"},{"selector":"#daquestion button[name=\"ZG93bmxvYWRfbGlzdF9odG1sX2N1c3RvbV8x\"][value=\"True\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"download_list_html_custom_1","value":"True"}],"type":"submit","trigger":"download_list_html_custom_1"}]
matches:
 []
matches:
 []
>~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~
Report:
 type: page_id, value: download-list-html-custom-2
page fields:
[{"selector":"#daquestion button[class=\"btn btn-link btn-da daquestionbackbutton danonsubmit\"]","tag":"button","guesses":[],"type":"button","trigger":"download_list_html_custom_2"},{"selector":"#daquestion button[name=\"ZG93bmxvYWRfbGlzdF9odG1sX2N1c3RvbV8y\"][value=\"True\"][class=\"btn btn-da btn-primary\"]","tag":"button","guesses":[{"var":"download_list_html_custom_2","value":"True"}],"type":"submit","trigger":"download_list_html_custom_2"}]
matches:
 []
matches:
 []
>Report:
 type: note, value:
  Rows that got set:
Report:
 type: step, value:     And I get the question id "end alexhibit tests" with this data:
Report:
 type: row, value:       | var | value | trigger |
Report:
 type: row, value:       | x.has_exhibits | True | exhibit_doc_defaults_1.exhibits.has_exhibits |
Report:
 type: row, value:       | x.target_number | 1 | exhibit_doc_defaults_1.exhibits.there_is_another |
Report:
 type: row, value:       | x[0].pages | test_alexhibit_docx_1.docx | exhibit_doc_defaults_1.exhibits.has_exhibits |
Report:
 type: row, value:       | x[0].title | DOCX only | exhibit_doc_defaults_1.exhibits.has_exhibits |
Report:
 type: row, value:       | x[i].pages.target_number | 1 | exhibit_doc_defaults_1.exhibits[0].pages.there_is_another |
Report:
 type: note, value:   All rows were used
Report:
 type: note, value:
..

Assembly Line Kiln Automated Testing Report - Fri, 31 Dec 2021 20:26:47 GMT

===============================
===============================
Passed scenarios:

---------------
Scenario: User adds only a docx exhibit aldocument alexhibits e
---------------
screen id: any-exhibits
      | x.has_exhibits | True | exhibit_doc_defaults_1.exhibits.has_exhibits |
      | x[0].title | DOCX only | exhibit_doc_defaults_1.exhibits.has_exhibits |
      | x[0].pages | test_alexhibit_docx_1.docx | exhibit_doc_defaults_1.exhibits.has_exhibits |
screen id: exhibit-i-has-additional-pages
      | x[i].pages.target_number | 1 | exhibit_doc_defaults_1.exhibits[0].pages.there_is_another |
screen id: another-exhibit
      | x.target_number | 1 | exhibit_doc_defaults_1.exhibits.there_is_another |
screen id: any-exhibits
      | x.has_exhibits | True | exhibit_doc_defaults_1.exhibits.has_exhibits |
      | x[0].title | DOCX only | exhibit_doc_defaults_1.exhibits.has_exhibits |
      | x[0].pages | test_alexhibit_docx_1.docx | exhibit_doc_defaults_1.exhibits.has_exhibits |
screen id: exhibit-i-has-additional-pages
      | x[i].pages.target_number | 1 | exhibit_doc_defaults_1.exhibits[0].pages.there_is_another |
screen id: another-exhibit
      | x.target_number | 1 | exhibit_doc_defaults_1.exhibits.there_is_another |
screen id: thumbnails-defaults
screen id: download-list-defaults
screen id: thumbnails-custom
screen id: download-list-html-custom-1
screen id: download-list-html-custom-2

  Rows that got set:
    And I get the question id "end alexhibit tests" with this data:
      | var | value | trigger |
      | x.has_exhibits | True | exhibit_doc_defaults_1.exhibits.has_exhibits |
      | x.target_number | 1 | exhibit_doc_defaults_1.exhibits.there_is_another |
      | x[0].pages | test_alexhibit_docx_1.docx | exhibit_doc_defaults_1.exhibits.has_exhibits |
      | x[0].title | DOCX only | exhibit_doc_defaults_1.exhibits.has_exhibits |
      | x[i].pages.target_number | 1 | exhibit_doc_defaults_1.exhibits[0].pages.there_is_another |
  All rows were used

Discussion in channel:

Under most circumstances, the developer doesn't need to include the page's trigger variable when setting the value of a field. It's really only needed when the question block uses index variables/generic objects and the test is using a story table.
In those cases, though, there is one case in which you still don't need to include anything in the "trigger" column of the table - if there's only one item in the index var/generic object loop, it doesn't matter if the "trigger" is listed in the column or not. It's currently hard for kiln to know if that's the case, though (maybe impossible).
Ways I've thought to handle this:

Absolutely require "trigger"s for every table row that makes use of proxy vars - index vars/generic objects - and error if it's left out.
Warn the developer and ignore proxy var rows that are missing their "trigger" value, thus not setting the fields that match the row.
Warn the developer, but still use the first matching row that comes along, even if it doesn't have a "trigger" value.

Another complication is the possibility that the interview page might itself not contain the data about trigger variable because that has to be set up separately if the developer isn't using the styled AL package. That would cause a mis-match in another way.
On the one hand, it seems appealing to be as permissive as possible so that paths with only one loop don't need more work. On the other hand, that could end up causing unexpected behavior. I'm leaning towards option 1 right now, but it may end up breaking some people's tests. It also may end up alerting people to tests that actually should have been failing this whole time. [That is, our current behavior is too permissive and lets some fields get set when they shouldn't and I'm working on fixing that bug. If I make it much more strict, though, tests that are correctly passing may now fail. I'm not sure if that would make this count as a bug fix or as a breaking change.]
Thoughts?

Conclusion:

Make the decision best for long term use as we have direct access to people using this at the moment.
Option 3, the most permissive and likely to work in simplest cases, is one expressed preference.

Fixed for v4, leaving v3 as is.


Idea: collector listener

This basically does what this example did:
https://github.com/grgrzybek/tracking-maven-extension
To finish, it would be an "extension point": interface that if extension implements as component, would be picked up.
BUT: am not quite in favor of this, as collector is HOT, and any time this listener would spend on work, would directly affect collection process. Am slowly leaning to simply define a callback for result graph (once collection is done), as then:

that would minimally affect collection, would not, would just add "postprocessing" cost, no in-processing cost that can quickly ass up
whole graph would be handed over, same as for caller along with session

All the code in "demo" segment originates from here https://github.com/grgrzybek/tracking-maven-extension/blob/main/src/main/java/org/ops4j/tools/maven/tracker/TrackingRepositoryListener.java#L168


CosmosDB parameter names are wrong

Under Add an output binding, the parameter names should be [CosmosDB(databaseName: "my-database", containerName: "my-container",
Connection = "CosmosDbConnectionString"
)]IAsyncCollector documentsOut,

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 62965f3a-d852-cbe8-3d01-a5126a16c660
Version Independent ID: 2af2bfc6-bf21-08c6-a874-467781a4af90
Content: Connect Azure Functions to Azure Cosmos DB using Visual Studio Code
Content Source: articles/azure-functions/functions-add-output-binding-cosmos-db-vs-code.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@khambley
Thanks for your feedback! We will investigate and update as appropriate.

@khambley , Thanks for the valuable feedback. I have updated the code and it will be published soon.


Fix usage of react-native cli inside package.json scripts

IIRC we made wrong-react-native to warn people in case they installed react-native globally (instead of react-native-cli what the guide suggests). To do that we added bin entry to React Native's package.json that points to local-cli/wrong-react-native.js
However, this means that if we have a project that uses react-native package and has call to react-native CLI inside its package.json, npm will execute local override (which just prints a confusing in this context error message).
In fact, the template we generate with react-native init has react-native start as start script, which makes it useless. Let's fix it by making wrong-react-native script smarter – it can detect that it has been executed from local node_modules and run the actual CLI.
cc @vjeux @ide

By analyzing the blame information on this pull request, we identified @martinbigio to be a potential reviewer.

sgtm

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


[WIP][Don't merge] Comment out dmlc::SetEnv in pthread_atfork #13438

Description
Fixes #13438
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@mxnet-label-bot add [pr-work-in-progress]
@larroy Please add "Fixes #13438" in the PR description to automatically close the issue when the PR is merged

@samskalicky what do you think of this? I think we should run a few examples to see if the number of threads remains constant when using CPU threaded engine.

@vandanavk done. Thanks for the suggestion.

Pedro, it would be great if the fix is as simple as commenting out the SetEnv. But what about the corresponding GetEnv in:
https://github.com/apache/incubator-mxnet/blob/266de6bef4da5769431557288d41fab2a02e52ca/src/engine/threaded_engine_perdevice.cc#L79
Shouldnt we need a mechanism to set the number of threads here to 1?

Yes most likely the fix is too simplistic. Wanted to have a fist test run to see how it looks.

@mxnet-label-bot add[par-awaiting-testing]

@larroy Can you address comments and rebase this PR? Thanks

@larroy Can this be merged now? Or should we close this PR?

@larroy Gentle ping.

I think we need to do more testing to be confident that the solution is solid. I can do it during my next oncall.

@larroy Gentle ping.


Add command output for debugging

Title: Add command output for debugging
Label: feature

this was a test


Update install.md

Fixed description so that it can be applied to a vanilla installation

Do I just keep waiting for bors or commit again and hope it goes through this time?

bors r+

bors r+

Thanks!  This is a bit frustrating :)

Thanks! This is a bit frustrating :)

That it is :smiley:


feat(backend):Parameterizing v2 Launcher Image

Which issue is resolved by this Pull Request:
Resolves #https://github.com/opendatahub-io/data-science-pipelines/issues/130
Testing instructions:

Saved the code changes locally and buiult this image: quay.io/rhn_support_ddalvi/odh-ml-pipelines-api-server-container-live:v2-2
Deployed DSP v2 and replaced the API Server image with the above image.

Checklist:

[x] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

Closing this PR as this has been duplicated in https://github.com/opendatahub-io/data-science-pipelines/pull/149

Closing this PR as this has been duplicated in https://github.com/opendatahub-io/data-science-pipelines/pull/149


Add IRONdb to storage backends

Adds IRONdb (https://irondb.io/) to the list of Storage Backend Alternates in the docs. Thanks!

Codecov Report

Merging #2166 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2166   +/-   ##
=======================================
  Coverage   79.55%   79.55%
=======================================
  Files          85       85
  Lines        8815     8815
  Branches     1888     1888
=======================================
  Hits         7013     7013
  Misses       1541     1541
  Partials      261      261

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3365c0...9275056. Read the comment docs.

IronDB is a good software but IMO it's hard to be named as "Storage Backend Alternative" for Graphite, it's compatible commercial alternative, though. It's also closed-sourced and commercial only (InfluxDB is open-sourced and the commercial version is only for clustering). OTOH we're not saying explicitly that we accepting only OSS additions to the list.
What do you guys think? /cc @iksaif @DanCech @obfuscurity ?

I agree, we're not looking to advertise a closed-source proprietary system that promotes itself as a replacement for Graphite.

I saw other commercial alternative storage backends here as was mentioned, so it seemed to fit well to list IRONdb here. IRONdb is not a replacement for Graphite; it only acts as the storage component (hence the Whisper compatible API). IRONdb is closed core like some of the alternatives, but has open source components (like other alternate storage backends listed).

I'm a very strong :-1: on this.

Sorry, @redhotpenguin, I agreed with @DanCech and @obfuscurity here. As I said, IronDB is a good software, but it's

closed-source
commercial (not open-core as it's not open-source).
All other services on the list are open-source, even InfluxDB - which is open-core.
Take our sincere apologies, but we're believing in OSS and will promote it in a first place.


There are four lights

I'm guessing this is what was meant when it was written “there are two more possibilities.”

Oh right. Good point!

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


Faculty contact getting duplicate Department affiliation records when inserting multiple Course Connections

This Power of Us Hub post started an investigation of Course Offerings (with Primary Faculty populated) creating multiple affiliation records linking a faculty contact to the same department.
https://powerofus.force.com/_ui/core/chatter/groups/GroupProfilePage?g=0F980000000D6uj&fId=0D58000004Xrgok
If you insert a Course Offering with primary faculty (or a Faculty course connection), HEDA will check their existing affiliation records to see if that contact is already linked to the course's department. If they are not, HEDA will create the affiliation. That works fine for single-record transactions.
However, if you insert multiple course offerings that relate that faculty member to the department (e.g., two course offerings in the same department) within the same transaction (data loader, integration, etc), HEDA is adding the new department affiliation to the "list to be inserted" without checking if there's already another affiliation linking the same affiliation to the same contact in that list. That causes the affiliation to get created multiple times.
The affected code is found in CCON_Faculty_TDTM when affiliationsToInsert list gets populated (before insert section).

Tracking W-028957

This issue was reviewed by the HEDA team and marked as a solid candidate for a Community Contribution. Please comment with any questions or concerns you may have. Thank you!

Included in beta release 1.70 (Beta 8)

Included in production release 1.70


Added Docker container and Kubernetes

additional target in the Makefile

for statically linking using Musl
stripping the binary down

container build

using the stripped binary
from scratch is all you need

daemon set

privileged container
needs access to hardware

action for building and pushing the container to ghcr.io
action to test with minikube

just for the daemon set
can't be run on github
missing privileges

Have fun!

Great @thomasfricke - I tested and merged it!
Thank you very much!


[passmanager] Remove ExecutionKind::UntilFixPoint and all of ExecutionKind.

[passmanager] Remove ExecutionKind::UntilFixPoint and all of ExecutionKind.
rdar://29650781

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge


Reconcile various supported Python versions

Currently assuming the set of all that are available across setup.py, tox.ini, .travis.yml
Also adding Python 3.7

Hmm. Looks like Python 3.7 isn't supported by Travis? I'll work on that (I ran into this on my Mac which is what triggered my PR).
@h-m-f-t + @jsf9k -- Was there a decision to remove Python2 support? I see those tests fail. If Python2 is not supported, I'll update the PR to go the other way.

Nod. It looks like PyDNS might be pushing us towards dropping 2.x support (https://travis-ci.org/dhs-ncats/trustymail/jobs/431721269) since it seems to not install correctly...

Hi @jsf9k -- I'm removing the WIP: label as this should now be ready to be merged.
It is now a removal of the Python 2 support (and addition of Python 3.7 support), due to issues that are seen with PyDNS not supporting building / installing in Python 2.7.

I wanted to bump the version since we're dropping python 2.X support.


Updated the firewall section

#sign-off

@clemensv : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Inconsistent subscriptions

Inconsistent subscriptions can lead to rebalancing，so why dont Solve this problem when subscribing

It is recommended to discuss changes in an issue before submitting a pull request, particularly when modifying existing behavior.


Unable to connect to temporal cloud

Based on the Temporal cloud SSL certificate generation guidelines, I ran the following two commands to create the certs:
tcld gen ca --org temporal -d 1y --ca-cert ca.pem --ca-key ca.key
tcld gen leaf --org temporal -d 364d --ca-cert ca.pem --ca-key ca.key --cert client.pem --key client.key
These commands created four files:

ca.key
ca.pem
client.key
client.pem

I uploaded the ca.key into my temporal cloud's namespace. The other files were used in the initializer code as follows:
require 'temporal-ruby'

root_cert = File.read("./ssl/ca.pem")
client_key = File.read("./ssl/client.key")
client_chain = File.read("./ssl/client.pem")

Temporal.configure do |config|
  config.host = 'rvapp.o5nlk.tmprl.cloud'
  config.port = 7233
  config.namespace = 'rvapp.o5nlk'
  config.task_queue = 'hello-world'
  config.credentials = GRPC::Core::ChannelCredentials.new(root_cert, client_key, client_chain)
end

Temporal.list_namespaces page_size: 10

The error I'm receiving on my local machine when running the code above:
 Handshake failed with fatal error SSL_ERROR_SSL: error:1000007d:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED.

If anyone could point me in the right direction it would be greatly appreciated!

Resolved. I needed to use nil in place of the root cert.
GRPC::Core::ChannelCredentials.new(nil, client_key, client_chain)

@jsonck Any specific reason you are using nil for root_cert?
you can find root_cert as server certificate by
openssl s_client -connect <your namespace gRPC endpoint>


Dropdown "userAdditions" support

Is there a mechanism with the current ui-dropdown component to allow for user additions in multi-select scenarios?
Per: http://semantic-ui.com/modules/dropdown.html#tagging-and-user-additions

You should be be able to tie into this callback, just add it to your component.
{{ui-dropdown onAdd=(action "onAdd)}}

actions: {
  onAdd(addedValue, addedText, $addedChoice)

Give that a try

Thanks @aaronbhansen.  Sorry for the confusion, but I'm looking for the flag that actually enables adding to a multi-select (e.g. "tagging") scenario.
In Semantic, you need to pass allowAdditions: true to the construction of the dropdown.

Ah gotcha, all you need to do is add it to the component
{{ui-dropdown allowAdditions=true
Any property passed to the component is automatically passed to Semantic. We are working on better documentation on the 2.0 branch to explain the proxy system. Any property that can be configured through js, is configured the same way on the component, just passed in as a parameter.

@aaronbhansen sorry for the delayed response.  While the proxy does work, this particular example gives a stack overflow on the component.  I'll work up an example to illustrate.  Can we re-open in the meantime?

@aaronbhansen I tried to use the attribute as below but it's not working for me. Can you please provide a sample code for multiselect dropdown with allowing additions?
{{#ui-dropdown 	class="fluid search multiple selection" 	allowAdditions=true 	selected=country 	onChange=(action (mut country)) }}
Select Country

 		{{#each tags as |tag|}}
 				{{tag}}
 		{{/each}}
 {{/ui-dropdown}}
Thanks!

@utilityboy I don't use Semantic anymore. I've moved to power select. Here is an older gist that shows the basics of what I did to make power select look like semantic https://gist.github.com/aaronbhansen/3153855ed2be887fb2f677a74d058dfa


MISC rst differences.

https://numpy.org/doc/stable/user/quickstart.html
exp. In NumPy, these are called "universal
functions" (\ ``ufunc``). Within NumPy, these functions

In sphinx the backslash is necessary not in papyri.

Related to https://github.com/jupyter/papyri/issues/275. From https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#inline-markup-recognition-rules, it seems like an unescaped leading ( before the code should be allowed.

Inline markup start-strings must start a text block or be immediately preceded by whitespace,

one of the ASCII characters - : / ' " < ( [ {
or a similar non-ASCII punctuation character. [19]


Setting myself admin

how do i set my wa number as admin?

What? Didn't get u

nope, i dont think so...
I started the bot with !start command, i get the starting message and then nothing.
bot is not responding to any command and no errors in terminal

Irrelevant issue,


SELECT * doesn't work with CTEs

CREATE TABLE foo (a INT, b INT);
CREATE TABLE bar (c INT, d INT);

-- name: CTEQuery :one
WITH cte AS (
  SELECT *
  FROM foo
)
SELECT *
FROM bar

Should produce the query
WITH cte AS (
  SELECT a, b
  FROM foo
)
SELECT c, d
FROM bar

Instead it produces:
WITH cte AS (
  SELECT c, d
  FROM foo
)
SELECT *
FROM bar

A subquery expression with * will have the same issue
select * from foo where exists (select * from bar where a = c);

@maxhawkins This should be fixed on master. Could you download the most recent build and confirm that it works for me?

Works great. Thank you!


clarification of license and allowed usage of all plugins

[...] anyone can use at any scale from an independent researcher to a fortune [...]

this sounds all very good, but looking at the plugin list ( https://github.com/maliceio/plugins
), it seems you are mainly re-using existing commercial AV products to do the actual scanning.
i can't imagine that its possible to use any of those plugins in any  setting without paying for those products. even when paying for those products, i can't imagine you can legally use any product you build on top of them in a commercial setting - AFAIK their license forbids this.
could you clarify with which plugins fulfil the original promise of 'malice', i.e. that it can be used for any purpose (even commercial) is actually true?

how/where has this been addressed?


Bug: Order status remains as UNCONFIRMED after calling transactionEventReport

What are you trying to achieve?
If auto-confirm is active Saleor should update the order status when a transaction is attached to the order
Steps to reproduce the problem
Channel settings:
            {
                "id": "Q2hhbm5lbDoyMjQz",
                "name": "Channel-USD",
                "slug": "default-channel",
                "isActive": true,
                "currencyCode": "USD",
                "hasOrders": true,
                "orderSettings": {
                    "automaticallyConfirmAllNewOrders": true,
                    "automaticallyFulfillNonShippableGiftCard": true,
                    "defaultTransactionFlowStrategy": "CHARGE",
                    "expireOrdersAfter": null,
                    "markAsPaidStrategy": "PAYMENT_FLOW"
                },

run checkoutCreate
run orderCreateFromCheckout as an app with handle checkouts
run transactionCreate without providing any amount as an app with handle payments
variables:

{
  "orderId": "{{orderId}}",
  "transactionCreateInput": {
    "status": "Authorized",
    "type": "provider-creditcard",
    "reference": "ref0001",
    "availableActions": ["CHARGE"]

  },
  "transactionEvent":{
      "status":"SUCCESS",
      "name": "payment",
      "reference": "ref0001"
  }
}

run transactionEventReport  "type": "CHARGE_SUCCESS", as an app with handle payments

Actual result:
Orders status is still  "UNCONFIRMED",
            "id": "T3JkZXI6NTA0MjZiNzMtMzBlOC00YWRlLWI0MWQtYjQ4MTZhOTUzMTFm",
            "status": "UNCONFIRMED",
            "paymentStatus": "FULLY_CHARGED",
            "transactions": [
                {
                    "id": "VHJhbnNhY3Rpb25JdGVtOmQ0NzY0MTlhLTRmOTItNGY5MC1hYmI3LTQ2NDA5NGFmNjM4Yg==",
                    "chargedAmount": {
                        "amount": 361.0,
                        "currency": "USD"
                    },

What did you expect to happen?
Order status should changed to Unfulfilled be changed
Logs
No response
Environment
Saleor version: core v3.13.0-a
OS and version: …

Hello,
i have learned data structures and algorithms and design patterns , Low Level Design in python
how i can start contribute in this issue
i am new to open source contribution
i am not able to understand the codebase can you please me some guidance

This has been resolved in https://github.com/saleor/saleor/pull/16254 and ported to versions down to 3.14.


The performance of HD models drop a lot on Vimeo dataset

Hi, thanks for your nice work. I find that the PSNR of HD models drop a lot on the test set of Vimeo, even less than 34dB. Can you explain why? Many thanks.

Hi, that‘s because I use perceptual loss to train HD model for better visual affect. So the Vimeo90K PSNR will be lower than RIFE reported on our arxiv paper.

Hi, that‘s because I use perceptual loss to train HD model for better visual affect. So the Vimeo90K PSNR will be lower than RIFE reported on our arxiv paper.

There is a tradeoff between psnr and perceptual scores[1], and higher PSNR does not always produce visually more pleasing results.
[1] The Perception-Distortion Tradeoff

There is a tradeoff between psnr and perceptual scores[1], and higher PSNR does not always produce visually more pleasing results.
[1] The Perception-Distortion Tradeoff

Thanks for your reply! Do you use VGG as perceptural loss? Do the perceptual loss actually improve the visual affect? Many thanks!

Thanks for your reply! Do you use VGG as perceptural loss? Do the perceptual loss actually improve the visual affect? Many thanks!

Yes, I use this repo's code and it definately improve the visual affect. https://github.com/Vandermode/ERRNet

Yes, I use this repo's code and it definately improve the visual affect. https://github.com/Vandermode/ERRNet


少年，不加开源协议很危险啊

少年，不加开源协议很危险啊

233，第一次开源东西_(:з」∠)_感谢提醒！
On Aug 6, 2016 23:29, "Aiの艾"<EMAIL_ADDRESS>wrote:

少年，不加开源协议很危险啊
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hanFengSan/light/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/APUkdicgeRJGKRQJN5z8rkf0ckBz0vVMks5qdKhsgaJpZM4JeTRL
.


Add support for default (wildcard) error page

Add ability to specify default (fallback) error page in Caddyfile  via '*' as status code. This addresses #752

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

This is looking great! Thank you so much @evvvvr.

@evvvvr I'll give you collaborator status so you can continue to help with Caddy as you are able to - it'll be easier for you now since you can create branches on this repository instead of having to fork the project. Also, please remember to review the contributing guidelines - most notably, that we like to have at least 2 collaborators approve a PR before it is merged, and to squash PRs with multiple small commits.
Really appreciate your contribution, again!

@mholt Thank You!


"Restaurants" + "Reservation" arc fails to deserialize

Deserializing recipe with Find Restaurants + Make Reservation produces the following error:
(14) assert-web.js:11 Uncaught (in promise) Error: Multiple annotation:0a138fcbec9943aca965ad8837c0b8c59e36490c inner slots cannot be provided
    at assert (assert-web.js:11)
    at DomContext._initInnerSlotContext (dom-context.js:165)
    at Array.from.forEach.elem (dom-context.js:157)
    at Array.forEach (<anonymous>)
    at DomContext.initInnerContexts (dom-context.js:144)
    at MutationObserver (dom-slot.js:62)

Serialization is below (restaurant data removed for length):
meta
  name: '!641642682956723:app-shell-2tdb7jtvbuel3g9xc'

resource Store0Resource
  start
  [{"$id":"!641642682956723:app-shell-2tdb7jtvbuel3g9xc:31","id":"-LBXevFOcUyM-TvYr5oq","name":"Scott","location":{"latitude":38.174917799999996,"longitude":-122.2608044}}]
resource Store1Resource
  start
  [{"$id":"!60923404048388:app-shell-2tdb7jtvbuel3g9xc:0:inner:0","latitude":38.174917799999996,"longitude":-122.2608044}]
resource Store2Resource
  start
  [REMOVED: Restaurant records]
resource Store3Resource
  start
  [null]
resource Store4Resource
  start
  [{"$id":"!229883874255978:app-shell-2tdb7jtvbuel3g9xc:0:inner:16","endDate":"2018-06-06T19:00","participants":2,"startDate":"2018-06-06T19:00"}]
resource Store5Resource
  start [{"$id":"!229883874255978:app-shell-2tdb7jtvbuel3g9xc:0:inner:uid:_pattern_","key":"_pattern_","value":""},{"$id":"!60923404048388:app-shell-2tdb7jtvbuel3g9xc:0:inner:uid:_pattern_","key":"_pattern_","value":""}]
resource Store6Resource
  start
  [{"$id":"!229883874255978:app-shell-2tdb7jtvbuel3g9xc:0:inner:uid:_pattern_","key":"_pattern_","value":"you are free at 19:00 on Wed Jun 06. Select a different time from your calendar"},{"$id":"!60923404048388:app-shell-2tdb7jtvbuel3g9xc:0:inner:uid:_pattern_","key":"_pattern_","value":"you are free at 19:00 on Wed Jun 06. Select a different time from your calendar"}]
store Store0 of Person Thing {Text id, Text friends, Text foods, Text avatar, Text active, Text occasion, Text date, Object location, Object arcs, Object profiles, Object shares, Text name, Text description, URL image, URL url, Text identifier} '!641642682956723:app-shell-2tdb7jtvbuel3g9xc:3' @1 in Store0Resource
store Store1 of GeoCoordinates Thing {Number latitude, Number longitude, Text name, Text description, URL image, URL url, Text identifier} '!641642682956723:app-shell-2tdb7jtvbuel3g9xc:82' @3 in Store1Resource
store Store2 of [Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier}] '!641642682956723:app-shell-2tdb7jtvbuel3g9xc:83' @30 in Store2Resource
store Store3 of Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier} '!641642682956723:app-shell-2tdb7jtvbuel3g9xc:84' @0 in Store3Resource
store Store4 of Event {Text endDate, Text startDate, Number participants, Text description} '!229883874255978:app-shell-2tdb7jtvbuel3g9xc:134' @2 in Store4Resource
store Store5 of [Description {Text key, Text value}] '!229883874255978:app-shell-2tdb7jtvbuel3g9xc:135' @2 in Store5Resource
store Store6 of [Description {Text key, Text value}] '!229883874255978:app-shell-2tdb7jtvbuel3g9xc:184' @2 in Store6Resource

particle Calendar in '././../../artifacts/Events/source/Calendar.js'
  inout Event {Text endDate, Text startDate, Number participants, Text description} event
  out [Description {Text key, Text value}] descriptions
  affordance dom
  consume action
  consume modifier
  description `Select a time from your calendar`
particle ExtractLocation in './././../../artifacts/Restaurants/../Places/source/ExtractLocation.js'
  in Person Thing {Text id, Text friends, Text foods, Text avatar, Text active, Text occasion, Text date, Object location, Object arcs, Object profiles, Object shares, Text name, Text description, URL image, URL url, Text identifier} person
  out GeoCoordinates Thing {Number latitude, Number longitude, Text name, Text description, URL image, URL url, Text identifier} location
  affordance dom
  description `extract ${person}'s location`
    location `${person}'s location`
particle FindRestaurants in './././../../artifacts/Restaurants/source/FindRestaurants.js'
  in GeoCoordinates Thing {Number latitude, Number longitude, Text name, Text description, URL image, URL url, Text identifier} location
  inout [Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier}] restaurants
  affordance dom
  consume root
    provide masterdetail
      handle restaurants
  description `find restaurants near ${location}`
    location `FIXME`
particle PartySize in '././../../artifacts/Restaurants/../Events/source/PartySize.js'
  inout Event {Text endDate, Text startDate, Number participants, Text description} event
  affordance dom
  consume modifier
particle ReservationAnnotation in '././../../artifacts/Restaurants/source/ReservationAnnotation.js'
  in [Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier}] list
  inout Event {Text endDate, Text startDate, Number participants, Text description} event
  affordance dom
  consume set of annotation
particle ReservationForm in '././../../artifacts/Restaurants/source/ReservationForm.js'
  in Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier} selected
  inout Event {Text endDate, Text startDate, Number participants, Text description} event
  out [Description {Text key, Text value}] descriptions
  affordance dom
  consume action
  description `make a reservation`
    event `reservation`
particle RestaurantDetail in './././../../artifacts/Restaurants/source/RestaurantDetail.js'
  in Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier} selected
  affordance dom
  consume detail
    provide action
particle RestaurantList in './././../../artifacts/Restaurants/source/RestaurantList.js'
  in [Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier}] list
  inout Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier} selected
  affordance dom
  consume master
    provide modifier
    provide set of annotation
      handle list
particle RestaurantMasterDetail in './././../../artifacts/Restaurants/../Common/source/MasterDetail.js'
  in [Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier}] list
  inout Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier} selected
  affordance dom
  consume masterdetail
    provide master
      handle list
    provide detail
      handle selected

@active
recipe
  use '!229883874255978:app-shell-2tdb7jtvbuel3g9xc:184' as handle0 // [Description {Text key, Text value}]
  use '!229883874255978:app-shell-2tdb7jtvbuel3g9xc:134' #event as handle1 // Event {Text endDate, Text startDate, Number participants, Text description}
  use '!641642682956723:app-shell-2tdb7jtvbuel3g9xc:82' as handle2 // GeoCoordinates Thing {Number latitude, Number longitude, Text name, Text description, URL image, URL url, Text identifier}
  use '!641642682956723:app-shell-2tdb7jtvbuel3g9xc:3' as handle3 // Person Thing {Text id, Text friends, Text foods, Text avatar, Text active, Text occasion, Text date, Object location, Object arcs, Object profiles, Object shares, Text name, Text description, URL image, URL url, Text identifier}
  use '!641642682956723:app-shell-2tdb7jtvbuel3g9xc:83' #nosync #restaurants as handle4 // [Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier}]
  use '!229883874255978:app-shell-2tdb7jtvbuel3g9xc:135' as handle5 // [Description {Text key, Text value}]
  use '!641642682956723:app-shell-2tdb7jtvbuel3g9xc:84' as handle6 // Restaurant Thing {Text id, Text reference, Text icon, Text photos, Text photo, Number rating, Text address, Text name, Text description, URL image, URL url, Text identifier}
  slot 'slotid-!60923404048388:app-shell-2tdb7jtvbuel3g9xc:1' as slot0
  slot 'slotid-!60923404048388:app-shell-2tdb7jtvbuel3g9xc:2' as slot1
  slot 'slotid-!60923404048388:app-shell-2tdb7jtvbuel3g9xc:3' as slot2
  slot 'slotid-!60923404048388:app-shell-2tdb7jtvbuel3g9xc:4' as slot3
  slot 'slotid-!60923404048388:app-shell-2tdb7jtvbuel3g9xc:5' as slot4
  slot 'slotid-!60923404048388:app-shell-2tdb7jtvbuel3g9xc:6' as slot5
  slot 'rootslotid-root' #root as slot6
  slot 'slotid-!229883874255978:app-shell-2tdb7jtvbuel3g9xc:1' as slot7
  slot 'slotid-!229883874255978:app-shell-2tdb7jtvbuel3g9xc:2' as slot8
  slot 'slotid-!229883874255978:app-shell-2tdb7jtvbuel3g9xc:3' as slot9
  slot 'slotid-!229883874255978:app-shell-2tdb7jtvbuel3g9xc:4' as slot10
  slot 'slotid-!229883874255978:app-shell-2tdb7jtvbuel3g9xc:5' as slot11
  slot 'slotid-!229883874255978:app-shell-2tdb7jtvbuel3g9xc:6' as slot12
  slot 'slotid-!641642682956723:app-shell-2tdb7jtvbuel3g9xc:76' as slot13
  slot 'slotid-!641642682956723:app-shell-2tdb7jtvbuel3g9xc:77' as slot14
  slot 'slotid-!641642682956723:app-shell-2tdb7jtvbuel3g9xc:78' as slot15
  slot 'slotid-!641642682956723:app-shell-2tdb7jtvbuel3g9xc:79' as slot16
  slot 'slotid-!641642682956723:app-shell-2tdb7jtvbuel3g9xc:80' as slot17
  slot 'slotid-!641642682956723:app-shell-2tdb7jtvbuel3g9xc:81' as slot18
  Calendar as particle0
    descriptions -> handle0
    event = handle1
    consume action as slot0
    consume modifier as slot4
  ExtractLocation as particle1
    location -> handle2
    person <- handle3
  FindRestaurants as particle2
    location <- handle2
    restaurants = handle4
    consume root as slot6
      provide masterdetail as slot5
  PartySize as particle3
    event = handle1
    consume modifier as slot4
  ReservationAnnotation as particle4
    event = handle1
    list <- handle4
    consume annotation as slot1
  ReservationForm as particle5
    descriptions -> handle5
    event = handle1
    selected <- handle6
    consume action as slot0
  RestaurantDetail as particle6
    selected <- handle6
    consume detail as slot2
      provide action as slot0
  RestaurantList as particle7
    list <- handle4
    selected = handle6
    consume master as slot3
      provide annotation as slot1
      provide modifier as slot4
  RestaurantMasterDetail as particle8
    list <- handle4
    selected = handle6
    consume masterdetail as slot5
      provide detail as slot2
      provide master as slot3

@sjmiles Scott, is there a way i can locally reproduce it?

You can use https://github.com/PolymerLabs/arcs/tree/serialize-testing branch to reproduce it.
This branch was introduced as part of #1422.


[Fix] Show grid grid settings

Description
This PR fixes a bug a in the Show grid sample where some of the grid settings wouldn't save state in between the sheet being closed and reopened. To avoid setting state in the view's init, I moved the state variables to a model. I tired to change it as little as possible so there should be no behavior changes besides the bug fix.
Linked Issue(s)

swift/issues/5774

How To Test

Ensure different combinations of gird settings persist in between the sheet being closed.

Thank you!


Reorganize the use of Alembic (fix #757)

This patch reorganizes the use of Alembic.
Our current revisions were out of sync and thus irrelevant, so they were removed.
An initial version was made which now contains the instructions to create the entire schema.
The init_db subcommand was removed as users should now use the alembic command to initialize the
schema. Both the README and the CI were updated accordingly.
Contributors that make pull requests which alter the schema should prepare the appropriate alembic
version and commit it with their patch

I'll inform @uda in private about what should be done in the production once this change is merged.


Disabled toggle doesn't reflect checked state

Toggle checked status is not updated if toggle is disabled. This can lead to problematic situation where toggle doesn't reflect checked state of underlying control.
It seems disabled/checked should be orthogonal properties, one not affecting another.

I had the same issue with my project so altered disabled to readonly. Basically in your forms when the control is disabled it won't send in the HTTP POST.
I changed the js so that disabled became readonly (find replace worked good :) ) and then the enable and disable method became
Toggle.prototype.enable = function () {
  this.$toggle.removeAttr('readonly');
  this.$toggle.removeClass('bst-readonly');
	this.$element.prop('readonly', false)
}

Toggle.prototype.disable = function () {
  this.$toggle.attr('readonly', 'readonly');
  this.$element.prop('readonly', true);
  this.$toggle.addClass('bst-readonly');
}

And then in the css added a style for the class I defined 'bst-readonly' so the illusion of being disabled is the same :)
.bst-readonly {
   opacity: .65;
  }

Hope that helps.
Cheers
Neil


Required tools for secure for secure cryptography

Some functions should be constant time for cryptography to hold.
This is the minimal amount of work we would need to have some some secure cryptrography:

[ ] Add some way to disable all optimizations in one function, as to avoid the compiler doing something that can make a constant time function non constant time
[ ] Add a way to check the assembly code generated for a function, since this is the only way to really check the algorithm is constant time
[ ] Add a way to clear the memory. Registers and memory used for "sensitive" data, needs to be cleared. It's not enough for the value to be dropped, the data shouldn't exist in memory anymore
[ ] Calling assembly maybe needed, in case the compiler can't be trusted, or to leverage existing implementations

This would be nice to have in a later version:

[ ] Enable only the subset of "safe" optimizations. (For example, nothing that adds a branch, or tries to early return a loop, can be used)
[ ] Forbid all non constant time operations, or at least warn about their usage, for a given functions (For example, divisions and branches)

I think it would require a new backend so LLVM doesn't break stuff behind our back. Or at least an extra late stage checking the asm?

Checking the ASM of a functions is really needed. It's the only way to verify everything is alright, even if everything is supposed to be working as intended.

I meant an automated one. Even if you need to manually check the output (and all compilers should be able to dump the asm anyway), early failures save you time.

Let's port https://github.com/dalek-cryptography/subtle/blob/main/src/lib.rs and put it in the stdlib


is there a way start/stop the music using the terminal/CLI?

Not really. The app uses a web browser to play music. The only options available on the CLi are setup options.


Error when loading folder with .sln file

"Cannot read property 'forEach' of undefined"

#25 reopened

This issue still exists.

This issue still exists.

Would you mind to attach the .sln file and the .csproj or other similars with these kind of problems?

My project file has null item
like this:

ItemGroup not include any item.

Ran into this as well, had an <ItemGroup /> for some reason in one of the projects. Worked well as soon as I removed it.
Maybe we can:
element.elements = element.elements || []
or something?


Initialize system log mode implementation doesn't match requirement cES1522

Is your feature request related to a problem? Please describe.
Requirement cES1522 "Upon a Processor Reset, the cFE shall set the System Log Mode to discard."
Implementation:
https://github.com/nasa/cFE/blob/5d7d766941369b6e92a0328217e43d5fd02a8cf1/fsw/cfe-core/src/es/cfe_es_task.c#L236-L239
The build verification test just happens to pass because the sample configuration defaults the mode to discard.
Describe the solution you'd like
Update requirement or implementation.
Describe alternatives you've considered
None
Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC

Recommend the requirement be reworded to say "Upon a Processor Reset, the cFE shall set the System Log Mode to the platform default"

I should have included the rational: "Want to preserve the System Events that may have captured the cause of the processor reset."  So intent was to specifically override on a processor reset.  Definitely open for discussion...

And one can achieve (or fail to achieve) the goal stated in the rationale in the rationale either way.  It is just as easy to lose the syslog information with it set to discard, as the log may have been full already when the event occurred.  At the end of the day this is just a system integration issue.  Seems pretty cut and dry to me - cfe cannot "enforce" that deployments are correctly configured.

It's definitely one for the architects @acudmore @jwilmot.  I'd think the vision in mind was for typical use default to overwrite for power on reset, force to discard on processor reset.  User setting to discard at power on is certainly their choice to make, for which the discard on processor reset has no effect.

Path forward - separate configurable default for power on and processor reset.  Default power on to overwrite and processor reset to discard.  Requirements will be updated to match (will like req issue to this one).  Users can modify however desired, but comes out of the box with the configuration that matches initial intent.

See cES1522 and cES1523 updates in #509


[NOTE] Debugging Symbols

target symbol add <path to .dwarf> in lldb can load them

See https://github.com/dotnet/runtime/issues/88286


Fail to preview parquet files with an error 'Cannot read properties of null (reading 'includes')'

Storage Explorer Version: 1.31.0-dev
Build Number: 20230802.3
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.5 (Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: From running test cases
Regression From: Previous release (1.30.2)
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Upload a parquet file.
Click 'Preview'.
Check whether succeeds to preview the parquet file.

Expected Experience
Succeed to preview the parquet file.
Actual Experience
Fail to preview the parquet file.

Error details:

Additional Context
This issue also reproduces for file shares/ADLS Gen2 blob containers.

Verified this issue on the build 20230803.5. Fixed. So, we are going to close it.


Peer-review

If you have any idea about peer review please write it here.
Thank you

Well done team! This app is lightweight, functional, and focused. the functionality is straightforward but of great utility. Nice Work!  It started to get hard to find flaws, but we do have a few improvements to suggest:
dashboard link: https://dsci532-2022-mindthegap.herokuapp.com/
Persona

Provide 3 pieces of constructive feedback that could help the app to be better suited to the scenario it was designed for

As you mentioned in the proposal researchers are keen on following its trend to assess the conditions of population health, I think adding a line plot to show the trend could perfectly satisfy this need to show the changes of the metric through time.
As this app is designed for demographers, sociologists, and public health organizations, I think they mostly at first want to know the most important KPIs(like just the average of metric in global or continent,…), so showing these KPIs in your app could be an advantage.
In the proposal, you mentioned that users can also filter countries using an interactive control tool, and I think it is a good idea to see each country’s condition compare to its continent and world. I’m pretty sure that because of the time constraint of the project this option is not active yet.

Provide 3 pieces of constructive feedback that could help the app to be better suited to the user(persona) it was designed for

Minor problem feedback, the map is not fitted into its space, and the user should slide in order to see the entire plot.
The map and box plot have the tooltip that will show the value of the metric, so I think that would be better to add this feature for the bar and bubble plot because sometimes it is hard to find the exact value or compare in the bar plots when the values are close to each other.
For the last feedback, I think you can switch the bar plot and box plot places, and make the top 10 countries plot narrower to give more space to the map plot. This way I think users can access and compare the top 10 coteries with the map plot

Frontend / layout

[x] Is the text (plot labels / titles / subtitles) easy to read?
[x]  Are the plots selected appropriate for the data? Can you think of other alternatives or improvements for the plots regarding interactivity/reactivity or plot selection?

Line plot and KPIs(boxes with just label and number) are improvements for the plots

[x] Was the dashboard organized in a way that was easy to read (columns / rows) or you would suggest a change in this sense?

They can switch the bar plot and box plot places and give more space to the map plot.

[x] Would you prefer including tabs / navbars to improve the navigation or you think it is better to visualize everything in one screen by the nature of the content?

We prefer showing everything on a one-screen by the nature of the context as it makes it easier for users to access everything on one page without switching between the tabs.

[x]  Are the plots or other images described properly for the persona described?

Backend

[x] Are the options that you can select in the widgets working fine or have you found some cases where it is not working?

Everything works fine except the map plot that shows part of the selected continent.

[x] If there are interactive plots: are the labels clear and easy to understand?

Documentation

[x] Was the documentation easy to understand from the README.md how to use the app? How could the documentation be improved?

The documentation is great.

[x] Was the app intuitive to use without reading the documentation? What information could be good to include?

because they have included the metrics as one of their filter the app is intuitive. They could add a small explanation in their control panel to make the app more intuitive.

Indicate something you would like to include in your own app after reviewing this one

We saw that they have put a small note in their app to let user knows what it means when the plot is empty. We think that is a great idea and we would add some notes to our app.
They have also used a slider for filtering their year which we think is better than dropdown we probably change this feature in our app.


DPE-2397 allow deployment on older then 2.9.44 juju controllers

Issue
pebble bundled with controllers older then 2.9.44 does not support kill-delay
Solution
Enable kill-delay only if current controller supports it
NOTE: juju does check the assumes on the refresh - so this wont upgrade on a <2.9.44 controller.

are we supporting controllers < 2.9.44?
https://github.com/canonical/mysql-k8s-operator/blob/d73010c9eba7641a80b6b91982d468eaaba91a47/metadata.yaml#L78
TBF, this may be completely uncessary

We never tried on Juju <2.9.29. It doesn't harm here but declares supported limits. @paulomach please update it here https://charmhub.io/mysql-k8s/docs/r-requirements after merging!

Yes. IIRC, we must settle to something newer due teardown issues. I'll get back to this later


Replace implementations of autobind, memoize, debounce

We went with lodash-decorators (including typings), because the core-decorators versions or debounce and memoize are deprecated, and the version of autobind doesn't work properly with typescript.

CC @lemonmade as an FYI, but maybe best not to review, since we worked on this together.

Hey. Won't find time to review this. I will add another reviewer :)

This means all the consumers who were using autobind() will now have to use bind(), correct?
If that holds true, then this will be a breaking change to consumers. i.e a v2.0.0 bump.
I think it's time we add a CHANGELOG.md for this repo. Do you mind adding one? I guess we can leave a Pre-2.0.0 sections that has a comment mention we didn't keep a changelog pre-2.0.0

Am I reading it right that we are just importing and exporting lodash-decorators's bind, debounce and memoize ?
If this is the case, why don't we just use lodash-decorators directly in neutron and polaris instead ?

@ismail-syed, @autobind should still work as normal. bind is being used as the default export, so any name will do. Also, note that I export bind(), not bind, in order to keep a consistent interface with our autobind.

@michelleyschen I feel it's better to use our own abstraction around this for 2 reasons:

It avoids a major refactoring right now
It avoids many future refactorings, should we decide to change our implementation. For example, if core-decorators fixed its issues with typescript, it may make more sense to use their autobind decorator instead of the bind decorator in lodash-decorators.

Also, @ismail-syed, what are your thoughts about moving autobind to the decorators folder? Is there a reason it isn't there now? legacy reasons, maybe?

should still work as normal. bind is being used as the default export, so any name will do

A bit confused, if the default export is bind();
Then a consumer would have to do something like:
import bind from '@shopify/javascript-utilities/autobind';

which means previous imports autobind will be broken?
import autobind from '@shopify/javascript-utilities/autobind';

Nvm, spoke IRL.

what are your thoughts about moving autobind to the decorators folder?

I'm pretty sure this one will need consumers to update since the paths will be @shopify/javascript-utilities/decorators.
I don't know the original reason, but I think it should be there since it's used as a decorator. It might have originally been in root as a mistake.