sxiv: 1.3.2 -> 24

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/39ynr6zcywkbmhxcvxdsvkj95380f7f6-sxiv-24
shrinking /nix/store/39ynr6zcywkbmhxcvxdsvkj95380f7f6-sxiv-24/bin/sxiv
gzipping man pages under /nix/store/39ynr6zcywkbmhxcvxdsvkj95380f7f6-sxiv-24/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/39ynr6zcywkbmhxcvxdsvkj95380f7f6-sxiv-24/bin
patching script interpreter paths in /nix/store/39ynr6zcywkbmhxcvxdsvkj95380f7f6-sxiv-24
/nix/store/39ynr6zcywkbmhxcvxdsvkj95380f7f6-sxiv-24/share/sxiv/exec/image-info: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/39ynr6zcywkbmhxcvxdsvkj95380f7f6-sxiv-24/share/sxiv/exec/key-handler: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-sxiv-24.drv-0 in /nix/store/39ynr6zcywkbmhxcvxdsvkj95380f7f6-sxiv-24...
/nix/store/39ynr6zcywkbmhxcvxdsvkj95380f7f6-sxiv-24

Success on aarch64-linux (full log)
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/4125y08lxr55c5j2mw3k3as4n08bba2g-sxiv-24
shrinking /nix/store/4125y08lxr55c5j2mw3k3as4n08bba2g-sxiv-24/bin/sxiv
gzipping man pages under /nix/store/4125y08lxr55c5j2mw3k3as4n08bba2g-sxiv-24/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4125y08lxr55c5j2mw3k3as4n08bba2g-sxiv-24/bin
patching script interpreter paths in /nix/store/4125y08lxr55c5j2mw3k3as4n08bba2g-sxiv-24
/nix/store/4125y08lxr55c5j2mw3k3as4n08bba2g-sxiv-24/share/sxiv/exec/key-handler: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/4125y08lxr55c5j2mw3k3as4n08bba2g-sxiv-24/share/sxiv/exec/image-info: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/4125y08lxr55c5j2mw3k3as4n08bba2g-sxiv-24...
/nix/store/4125y08lxr55c5j2mw3k3as4n08bba2g-sxiv-24


CyberScout

what happen with CyberScout

The free server I had was overwhelmed and couldn't handle all the requests at once. For now, I have to bring some improvements to the project and find a more reliable server to host it. Thanks for being interested.

I'm going to publish a copy of CyberScout as a directory on my profile. You will need to create a telegram bot on your own by using BotFather (https://telegram.me/BotFather). The directory may come with unfinished work that can raise errors. For support, please email me at<EMAIL_ADDRESS>


Improve popup design

Improve popup design:

[x] embedd font (serif - RIDIBatang, sans serif - Nanum Barun Gothic)
[x] fixed font size
[x] make option to modify font size
[x] make option to set serif or sans-serif
[x] remove radius
[x] add shadow

Solved by lastest commit.

[ ] font-size not working at some sites
[ ] font-family not working at some sites


A problem when using arrays as nested fields

My redux-form is initialized (using initialValues) as the following:
{
	a: {
		current: {}
		new: []
	}
}

And later on looks like the following:
{
	a: {
		current: {
			2: {
				id: "2"
				field1: "bla"
				field2: "bla"
				b: {
					current: {},
					new: []
				}
			},
			3: {
				...
			}
		},
		...
		new: [
			0: {
				id: 0
				field1: "blabla"
				field2: "blablabla"
				b: {
					current: {}
					new: []
				}
			}
		]
	}
}

What I tried to create here is a sort of tree-layered form with a+b+c as three layers, each contains a dictionary of backend-existed objects (which is why it is a dictionary and not just an array, because they actually have backend-ids) and a list of "new" objects (the ones that handleSubmit should create).
Everything seems to work except that I get an exception on every onFocus event on a.new[someIndex].someField and basically on every [x].new[someIndex].someField, which eventually perform the focus so it still works but it delays it for like a second.
the exception that occurs:

It drives me crazy.

It appears to me that you have the same problem as #3314


Set tcp_be_liberal as part of Minuteman initialization

@spahl @cmaloney

We don't own these settings globally / don't own sysctl settings. For AWS / CloudFormation clusters we can / should set these (in a way that is persistent across reboots and the like). The service cannot set them however.

Why can't we take them over? I don't think that people will actually set this setting based on the documentation, and they'll see issues when they're hairpinning traffic between Docker containers. Given that DC/OS runs on edge systems, and you're typically not using conntrack for any kind of security / hole-punch limiting, it seems like a fairly reasonable, conservative option.
The kernel gets confused because it has an earlier conntrack entry for this traffic since it creates one before it gets from the Docker container to the forwarding table.
If you think that we should avoid touching this, can you create a PR to set this in the AWS / Cloudformation images, and I'll do the PR so it gets into ACS?

It sounds like this should be replaced with:

A pre-flight check to validate that sysctl is configured appropriately for minuteman
An update to the Azure templates to configure sysctl
An update to the AWS templates to configure sysctl

Per some conversations with @spahl and @sargun I think we are going to claim ownership of certain default sysctl settings. People will be able to override, but at their own risk. Do we have enough consensus here to move forward with the patch as is @cmaloney?

+1

Thanks for this patch - this solved a number of vexing connection issues from the MySQL driver.

This also solved my problem with Kibana, it was unable to connect to Elasticsearch.
I mention it so that google can pick this answer if somebody else has the same problem.


Fix sun uniform

For #3141

Good catch. Update CHANGES.md and include a link to #3141.  We'll ship this with 1.16.

Updated CHANGES.md

I can confirm that this fixes the issue.  I was talking to @lilleyse offline as to why this ever worked on any system to begin with, and we think that correct implementations end up giving the uniforms default values, where as my phone's driver does not. (this is just conjecture though).
The end result is that this change affects the desktop as well, as you can see from the below screenshots and the end result is more correct visualization on all devices.
master:

this branch:

Thanks @lilleyse


Issue/137/hide copyright

Solves #137
Also makes post cards readable again after html tags have been readded by the etl process

It looks just like on the page where we got the data from.
I would say if this is bothering, we need to have a deeper look at how we want to solve this.

Thats what i was thinking too


Generate Github Resume

Opt-In for Github Resume service by staring the following project - Repo
After generating the resume, share your resume link to get points
Visit the project repo to read resume generating instructions

http://resume.github.io/?Anjali2901


Fix installation docs

What does this change
This change updates the docs for installing the operator on a kubernetes cluster using porter bundles. Kind and minikube clusters need to be configured a certain way in order to accept kubectl connections from within porter bundles.
What issue does it fix
https://github.com/getporter/kubernetes-mixin/issues/54
https://github.com/getporter/operator/issues/263
Checklist

[ ] Did you write tests?
[x] Did you write documentation?
[ ] Did you make any API changes? Update the corresponding API documentation.

I think it would be better instead of copying the kind.md and minikube.md to just point to them under here
However, I think it would be useful to just copy the kind integration guide for mac onto the quickstart, and make a "setup" portion

here

You're right. I didn't know these were there.

@schristoff made changes


Improve support for Boto 3

Hello @yurishkuro,
This PR adds support for Boto 3 clients including enhanced support for the S3 client.
These changes also:

replace amazon/dynamodb-local docker image with localstack/localstack docker image for tests
fix test for SQLAlchemy

Related issue: #101

Hello @yurishkuro,
Could you please review this PR?
Thank you!

Related issue: #101

Is this fixing it?  If so, please update description to Resolves #101.

Hello @yurishkuro,
I'm not quite sure that this PR resolves #101 completely since @berkowitzi was asking for some example snippets. I'm going to publish them once the updated version of this library is available.
So I propose to keep #101 open and wait for @berkowitzi to confirm that everything is fine.
Thanks!

@Jamim are you aware of any new/recent issues in Travis for dynamodb?  The builds are hanging, e.g. https://travis-ci.org/github/uber-common/opentracing-python-instrumentation/jobs/699073221


bx::sqrt(0.f) will return NaN

test code:
float  r = bx::sqrt(0.f);

r will be NaN
And I build a bx test cases and run, the result:

2023-04-17 10:42:36.368 test_bx[34092:3520110] ../../3rd/bx/tests/run_test.cpp(19): Compiler: Clang 14.0.3, CPU: ARM, Architecture: 64-bit, OS: OSX, CRT: Clang C Library, Date: Apr 17 2023, Time: 10:40:47, C++: C++17
Randomness seeded to:<PHONE_NUMBER>
test_bx is a Catch2 v3.1.0 host application.
Run with -? for options

-------------------------------------------------------------------------------
libm
-------------------------------------------------------------------------------
../../3rd/bx/tests/math_test.cpp:65
...............................................................................

../../3rd/bx/tests/math_test.cpp:114: FAILED:
  REQUIRE( bx::isEqual(bx::sqrt(xx), ::sqrtf(xx), 0.00001f) )
with expansion:
  false

905.012000
===============================================================================
test cases:      185 |      184 passed | 1 failed
assertions: 11265218 | 11265217 passed | 1 failed

That bug is relate to:
https://github.com/bkaradzic/bx/issues/298

Can't repro:
==== Building bx (release) ====
==== Building bx.test (release) ====
math_test.cpp
Linking bx.test
Running...
2023-04-16 20:41:39.397 bx.testRelease[14422:366556] ../../../tests/run_test.cpp(19): Compiler: Clang 14.0.3, CPU: ARM, Architecture: 64-bit, OS: OSX, CRT: Clang C Library, Date: Apr 13 2023, Time: 20:32:22, C++: C++14
Filters: libm
Randomness seeded to:<PHONE_NUMBER>
===============================================================================
All tests passed (579889 assertions in 1 test case)

I want to know, how do you build bx.test target from bx?
Here is what I try to build bx.test taget from bx/makefile, like:

cd bxfolder
make test
.build/osx-x64/bin/bx.testRelease

result:

2023-04-17 16:06:04.935 bx.testRelease[92617:3820883] ../../../tests/run_test.cpp(19): Compiler: Clang 14.0.3, CPU: x86, Architecture: 64-bit, OS: OSX, CRT: Clang C Library, Date: Apr 17 2023, Time: 15:26:31, C++: C++14
Randomness seeded to:<PHONE_NUMBER>
bx.testRelease is a Catch2 v3.1.0 host application.
Run with -? for options

-------------------------------------------------------------------------------
isFinite, isInfinite, isNan
-------------------------------------------------------------------------------
../../../tests/math_test.cpp:15
...............................................................................

../../../tests/math_test.cpp:20: FAILED:
  REQUIRE( std::isnan(u.f) == bx::isNan(u.f) )
with expansion:
  false == true

903.920000
-------------------------------------------------------------------------------
Settings
-------------------------------------------------------------------------------
../../../tests/settings_test.cpp:10
...............................................................................

../../../tests/settings_test.cpp:10: FAILED:
  {Unknown expression after the reported line}
due to a fatal error condition:
  SIGSEGV - Segmentation violation signal

===============================================================================
test cases:       35 |       33 passed | 2 failed
assertions: 10154393 | 10154391 passed | 2 failed

It's different from last result which build from my build system. But still have some strange errors.
Could you mind to show me how you build your bx.test target?
My test device is macbook M1 with macOS Ventura 13.2.1
Thanks.

I think https://github.com/bkaradzic/bx/blob/7bbda806d96ca55433f6d9857270360c05515fec/include/bx/inline/simd128_neon.inl#L655 simd_rsqrt(0) should be NaN here.

Did you try with latest?

I have try the new code(build from bx/makefile), all test passed.
Beside that, could you mind to define a macro, let the bx lib use the CRT version math methods?

Beside that, could you mind to define a macro, let the bx lib use the CRT version math methods?

Not in official repo,  I would suggest you just modify bx for your project to do whatever you need.

I found it will failed the test with ARM architecture. To reproduce:

cd bxfolder
make osx-arm64-release
./.build/osx-arm64/bin/bx.testRelease

It will log:

2023-04-25 10:19:16.197 bx.testRelease[7498:1704298] ../../../tests/run_test.cpp(19): Compiler: Clang 14.0.3, CPU: ARM, Architecture: 64-bit, OS: OSX, CRT: Clang C Library, Date: Apr 25 2023, Time: 10:18:31, C++: C++14
Randomness seeded to:<PHONE_NUMBER>
bx.testRelease is a Catch2 v3.1.0 host application.
Run with -? for options
libm
../../../tests/math_test.cpp:75
../../../tests/math_test.cpp:158: FAILED:
REQUIRE( bx::isNan(bx::sqrtRef(-1.0f) ) )
with expansion:
false

905.025000
test cases:      185 |      184 passed | 1 failed
assertions: 11271229 | 11271228 passed | 1 failed

I found it will failed the test with ARM architecture. To reproduce:

But your original problem is solved? This is sqrtRef failure which is not used by default... I'll fix it, just asking for original issue?

I try to reproduce my original problem, it can pass the test in release version, but it still failed in debug version.

cd bxfolder
make osx-arm64-debug
/.build/osx-arm64/bin/bx.testDebug

2023-04-25 10:53:00.302 bx.testDebug[9366:1716925] ../../../tests/run_test.cpp(19): Compiler: Clang 14.0.3, CPU: ARM, Architecture: 64-bit, OS: OSX, CRT: Clang C Library, Date: Apr 25 2023, Time: 10:51:01, C++: C++14
Randomness seeded to:<PHONE_NUMBER>

bx.testDebug is a Catch2 v3.1.0 host application.
Run with -? for options

libm
../../../tests/math_test.cpp:75
../../../tests/math_test.cpp:115: FAILED:
REQUIRE( bx::isInfinite(bx::rsqrt(0.0f) ) )
with expansion:
false

905.026000
test cases:      185 |      184 passed | 1 failed
assertions: 11263216 | 11263215 passed | 1 failed

Try again with latest.


Integrating with google maps

Is there a way to use this library with google maps?

The h3-js library is agnostic to mapping libraries you might use. In general, the easiest way to render H3 cells is to use cellToBoundary (h3ToGeoBoundary in v3) to get each cell as a polygon, then encode this as GeoJSON or a similar standard format and load that in your map (which could be a web map like Leaflet or MapboxGL, or an application like QGIS, or some other rendering library).

You can see rendering approaches using MapboxGL in the H3 tutorials on Observable
You can use the geojson2h3 library to more easily convert between H3 and GeoJSON


A Scan has a failure.. Please approve to proceed

Approval required for following Workflow to proceed.

WorkflowName
Workflow#
BranchName
TriggerEvent
LastCommitUser

build-test
57
refs/heads/main
push
Yog4Prog

Issue Details
Found an Issue while performing SCA Scan
:point_right: You are required to Approve (or) Reject the issue
Approve or Reject by commenting in the below section with any of the following keywords
:green_book:  Approved Keys: approved approve lgtm goahead proceed yes
:closed_book: Reject Keys: denied deny reject rejected no abort cancel exit
:point_right: Note: If left uncommented the issue will be closed after the timeout period and the workflow will be marked unsuccessful.

Approval waiting period elapsed. Approval request is automatically closed and workflow status is marked to Failed.


Would like to have an option to hide the Image feed button

I don't use the Image feed feature, so I would like to have a setting option to hide the Image feed button.

+1

Have you tried the setting "Image Feed Location" -> "Hidden"?

Thank you!!


Include Appclusive Public Assembly

Include the Appclusive Public assembly in biz.dfch.PS.Appclusive.Client.

resolved by commit e1f41ce30fa1734a49f20192f85939616405d2d7


Use version of puphpet/debian75-x64 with supported Puppet

With the most recent version of this box (v20151201), Puppet receives a command-line option it no longer supports:
==> default: Error: Could not parse application options: invalid option: --manifestdir
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

👍


drawing dot plot with the results of DEG analysis

Hi,
In previous, I do appreciate your fast response about running DEG analysis.
From the successful results of DEG_analysis, I tried to draw a dot plot of cellphoneDB.
As you know, there is no pvalues.txt from the DEG analysis.
So, simply used p-values of statistical analysis... and a selected list of rows, and columns data from the DEG-analysis.
But, there is a lot of error that I can't solve.
FYI, here I copied results from the shell.
In the folder named 'KYUPePTDEG', I used slected rows, columns.
In the folder named 'KYUPePTSt', I used p-values and means data.
cellphonedb plot dot_plot --rows ./KYUPePTDEG/rowsTcellDEGcl0dM1cl10TCells_dNK3.txt --columns ./KYUPePTDEG/xx --means-path ./KYUPePTSt/means.txt --pvalues-path ./KYUPePTSt/pvalues.txt --output-path ./KYUPePTDEG --output-name PePTDEGDotplotTcellAllp0_001.pdf --verbose
[ ][APP][01/12/22-18:47:40][ERROR] Unexpected error
Traceback (most recent call last):
File "/home/hyojung/.conda/envs/cpdb/lib/python3.7/site-packages/cellphonedb/src/api_endpoints/terminal_api/plot_terminal_api_endpoints/plot_terminal_commands.py", line 38, in dot_plot
columns=columns)
File "/home/hyojung/.conda/envs/cpdb/lib/python3.7/site-packages/cellphonedb/src/plotters/r_plotter.py", line 38, in wrapper
return f(*args, **kwargs, robjects=robjects, r_runtime_error=RRuntimeError)
File "/home/hyojung/.conda/envs/cpdb/lib/python3.7/site-packages/cellphonedb/src/plotters/r_plotter.py", line 115, in dot_plot
means_df = pd.read_csv(means_path, sep=means_separator)

Dear @hypaik
Thank you for sharing.
In the DEG analysis we do not compute any statistics because these are already provided by the user in their DEG file.
The DEG method will classify interactions as relevant (1) or not relevant (0) and p-values/significant mean files will go in agreement with this classification. A relevant interaction will have a --value of 0 and its mean will be in the significant mean files.
Long story short, you can still use the same plotting strategy with the output of only KYUPePTDEG.
Note that KYUPePTDEG and KYUPePTSt test different statistical questions and you should not expect a perfect agreement on what they define significant.  Mixing outputs will give you errors.
Let us know if this works.
Best,
Luz


fix: [Violations] Distance - Incorrect error message when distance amount is changed to smaller amount.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/41401
PROPOSAL: https://github.com/Expensify/App/issues/41401#issuecomment-2091932028
Tests

Go to Submit expense > Scan > Add valid receipt > Select workspace > Submit
Wait for scanning to complete, once completed edit the amount to a higher value
Verify Amount greater than scanned receipt error appears below amount field
Go to Submit expense > Distance > Select 2 waypoints > Select workspace > Submit
Open transaction page > Wait for amount to be calculated > Edit the amount to higher value
Verify Amount differs from calculated distance error appears below amount field

[x] Verify that no errors appear in the JS console

Offline tests

Go to Submit expense > Scan > Add valid receipt > Select workspace > Submit
Wait for scanning to complete, once completed edit the amount to a higher value
Verify Amount greater than scanned receipt error appears below amount field
Go to Submit expense > Distance > Select 2 waypoints > Select workspace > Submit
Open transaction page > Wait for amount to be calculated > Edit the amount to higher value
Verify Amount differs from calculated distance error appears below amount field

QA Steps

Go to Submit expense > Scan > Add valid receipt > Select workspace > Submit
Wait for scanning to complete, once completed edit the amount to a higher value
Verify Amount greater than scanned receipt error appears below amount field
Go to Submit expense > Distance > Select 2 waypoints > Select workspace > Submit
Open transaction page > Wait for amount to be calculated > Edit the amount to higher value
Verify Amount differs from calculated distance error appears below amount field

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@Krishna2323 Have we considered different types as mentioned here? Can you please complete the PR review checklist. Please include the test cases for different types.

Whoops, sorry missed this.

One more question on the above comment: do we also need to remove the taxAmountChanged notice, along with taxRateChanged, from NewDot?

Yes, that's correct. We aren't going to show these on NewDot, as both will generate system messages when changed. We also show what tax rate is "default" in a parallel initiative that's currently in implementation for track tracking in New Expensify.

Just confirming that the above response makes sense?

However, I'm not sure what to add in the test cases. Could you provide some guidance? Several types of amount notices are there.

@Krishna2323 You can include the test cases based on this expected output.
Verify that the notice violations related to Amount is shown below the amount field.

Let's show all these cases under the amount field, since a) we think it's more impactful/intuitive to highlight that the amount is greater than the receipt, than the other way around; and b) the field you need to take action on in order to fix the violation is the amount field, not the receipt field

Verify notice violations based on their type

{data: {type: 'distance'}}
{data: {type: 'card'}}
{data: {type: 'smartscan'}}
{data: {type: 'smartscan', displayPercentVariance: $displayPercentVariance}}

You can also include Tests for the bug you discussed here.
Basically, the tests should cover the changes made in the PR. You can add multiple set of test cases.

In distance request, I can still see the wrong error message.

I think you mean @cead22

Yes, I'll get the PR for that submitted today/tomorrow

I submitted the PR for review

Yeah it's live!

@Krishna2323 Did you test the PR in your end? Please make sure to test the PR in your end first.

In the screenshot below, we show receipt verified when the amount field has an issue. Should we be showing issue found instead?

Yes, I agree. We should be showing 'issue found' instead.

I could only verify the first and the third cases.

{data: {type: 'distance'}}
{data: {type: 'card'}}
{data: {type: 'smartscan'}}
{data: {type: 'smartscan', displayPercentVariance: $displayPercentVariance}}

@cead22 @JmillsExpensify  How can I test the 2nd and the 4th cases?

To get the violation with {data: {type: 'card'}}

Import a transaction from a personal credit card
Manually update the amount to be more than 5% higher than the original amount

To get the violation with {data: {type: 'smartscan', displayPercentVariance: $displayPercentVariance}}

Create a transaction by scanning a receipt
Once it finished scanning, change the currency to one with similar value (eg, EUR <> USD <> GPB, and not USD => IDR), and change amount to be twice as much as the original

Let me know if that doesn't work, and maybe we can test this when we deploy the app with some staging/production data

Thank you, @cead22. I am not sure if I will be able to test the first case, but I will test the second case. In the meantime, @Krishna2323, can you please test it on your end as well?

I am also seeing some case where we show "Duplicate" below the "Merchant" field as an issue. I am not sure it is expected as there is not much information about the issue, it is just "Duplicate".
cc: @JmillsExpensify @cead22

@sobitneupane can you share a screenshot and reproduction steps for that please?

@cead22 I am not very sure how to reproduce. But I am pretty sure it was introduced by this commit.
I believe it is returned as warning type violations as mentioned by @Krishna2323 here.

I see that we now also get warning type violations. I think these should be included in the paid policy groups as well, correct? (I've already updated the code for this.)

I don't know how to add a personal credit card. Do I need to add a real credit card?

I think you can skip this one and we can test it when it's on staging. And you can ignore the duplicate one for now

@Krishna2323 You can select US location from developers option > Sensor > Location in the browser.

To get the violation with {data: {type: 'smartscan', displayPercentVariance: $displayPercentVariance}}

Create a transaction by scanning a receipt
Once it finished scanning, change the currency to one with similar value (eg, EUR <> USD <> GPB, and not USD => IDR), and change amount to be twice as much as the original

It seems we should be using violation.data.displayPercentVariance for displayPercentVariance. However, the code is currently using violation.displayPercentVariance.
Despite following the steps, I couldn't retrieve the data in the format {type: 'smartscan', displayPercentVariance: $displayPercentVariance}.

https://github.com/Expensify/App/assets/25876548/b1c8fcca-de7e-47cc-bff6-fa6d96e5a4a1

I tried after changing the location from Sensor but the currency is still INR.

Can you please try it again after refreshing the page. It should work. It is working for me.

@Krishna2323 It is working well for me. I am not sure why it is not working in your end. I am using configurations as shown in screen recording here. You might have to use VPN if it's not working for you.

It seems we should be using violation.data.displayPercentVariance

This is correct, at least in the sense that displayPercentVariance should be in the violation data

Do you have an ETA for when this will be ready?

Thanks

This is the last test we need to pass and it seems like the backend isn't providing displayPercentVariance.

If you confirm this is the case, then we can handle it in a follow up PR

I've been trying to reproduce this myself and get a violation with displayPercentVariance and haven't been able to, so maybe this  can't be reproduced in new dot, so let's not block on it

@cead22, ok I will try once more, don't know why the currency automatically changes to INR in my case.

I'm pretty sure we set the currency based on IP address!

@Krishna2323 how did your review go?
@sobitneupane can you do another review today?

@sobitneupane bump please

Bump @Krishna2323. Can you please prioritize this PR.

@Krishna2323 The violation message are being shown below the Receipt instead of respective field.

@Krishna2323 The violation message are being shown below the Receipt instead of respective field.

That means we might not be using violationFields or the flow that uses violationFields to get the mapping of violation -> field to show violation

@Krishna2323 please put this at the top of your priority list so we can merge this this week (ideally today/tomorrow)

@Krishna2323 what about https://github.com/Expensify/App/pull/41649#discussion_r1668942122 ?

@Krishna2323 Please make sure to test the PR in your end after each change.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/cead22 in version: 9.0.7-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


wip: remove the need for CORS headers

Please see #728.
Needs:

[ ] https://github.com/ipfs-shipyard/ipfs-webui/pull/899

@lidel @olizilla we will need to enable window.ipfs on Web UI or create another way (like window.ipfsDesktop so Web UI knows we're talking to Desktop.
IMO, it would be easier to just enable window.ipfs when calling the ipfsReduxBundle on Web UI. It would just work. Right now, I'm injecting the ipfs object into the window. It seems to be working. It just isn't recognized by the Web UI

@olizilla @lidel I just updated this PR to use a version from Web UI that uses window.ipfs. You can try it out. We don't need CORS headers anymore.
We just need to merge https://github.com/ipfs-shipyard/ipfs-webui/pull/899 and this one 😄
Suggestions?

will tidy up this PR.


Handle more extensions + fix relative paths

Add more C++ extensions,
Ignore Mercurial directory,
Fix a FileNotFoundError:

./root
  |-- build
  |-- src
      `-- file.cc

If we run coveralls in build, filepath is src/file.cc (relative path w.r.t. root), and io.open(filepath) was executed in build (≠ root directory), leading to the error.

I can't manage coveralls to show ObjC files (.m) coverage, do I need to patch coverage.py to add .m?
Also tried the -x m flag but it causes cpp-coveralls to skip all the files.


fixing readme example

I believe there was a small error in the documentation (look at how the array was flat in the predict()).
If I run the code how it was, I receive the following error:
var _this = _super.call(this, message) || this;
                   ^

ValueError: Error when checking : expected dense_Dense1_input to have shape [null,1] but got array with shape [1,2].
    at new ValueError (.../node_modules/@tensorflow/tfjs-layers/dist/tf-layers.node.js:10080:28)
    at checkInputData (.../node_modules/@tensorflow/tfjs-layers/dist/tf-layers.node.js:19373:31)
    at LayersModel.predict (.../node_modules/@tensorflow/tfjs-layers/dist/tf-layers.node.js:20051:9)
    at Sequential.predict (.../node_modules/@tensorflow/tfjs-layers/dist/tf-layers.node.js:21555:27)
    at LinearRegression.predict (.../dist/node/linear_model/sgdRegressor.js:204:40)
    at main (.../test/mock/basic-node.mjs:10:18)

So I made the change to what I believe to be the intended way - but let me know if I'm not correct!


latexml conversion command for ar5iv

Dear friend,
For this paper https://arxiv.org/abs/nucl-th/0002023v1, I use following command to convert it to html
latexmlc --dest=doc.html mix_delrho
and it thows following waring and error
Warning:unexpected:\bm \bm should only appear in math mode
Error:malformed:ltx:biblist Attempt to close </ltx:biblist>, which isn't open
but when I use ar5iv, https://ar5iv.labs.arxiv.org/html/nucl-th/0002023v1, there is no above waring and error.
So is there something wrong with my command, and may I know the converting command using in ar5iv? Thanks.

Hi @sparkyqin ,
The exact conversion for ar5iv is configured and carried out by a worker executable, specifically latexml_worker L288-L313.
I have been meaning to prepare a Dockerfile that can be used for a turnkey conversion and I will use the occasion of this issue to do so. There are a number of customizations to the default LaTeXML run that are needed for maximizing the success rates over arXiv, as you rightfully suspect in your question.

Thanks for your reply, now I see that some customizations are needed, so looking forward to the docker image, it's a very useful work.

@sparkyqin the Docker image is now available at ar5ivist
The turnkey command you can use today is:
$ docker run -v "$(pwd)":/docdir -w /docdir \
             --user "$(id -u):$(id -g)" \
             latexml/ar5ivist:2208.01 --source=main.tex --destination=html/main.html

And the exact latexmlc options for conversion can be inspected at the Dockerfile entrypoint here. Hope this helps!


linux chroot builds Readme update, vscode yarn errors, Husky error or git commit -all -m up,

Does this issue occur when all extensions are disabled?: Yes/No yes

VS Code Version: Current Github repo
OS Version: Linux debian
linux install
readme_update
<<---sudo apt-get install build-essential g++ libx11-dev libxkbfile-dev libsecret-1-dev python-is-python3
--->>sudo apt-get install build-essential g++ libx11-dev libxkbfile-dev libsecret* python3

root@coco:/home/coco/vscode# apt-cache search libsecret
gir1.2-secret-1 - Secret store (GObject-Introspection)
libsecret-1-0 - Secret store
libsecret-1-dev - Secret store (development files)
libsecret-common - Secret store (common files)
libsecret-tools - tool for storing and retrieving GObject passwords
root@coco:/home/coco/vscode# apt install libsecret-1-dev libsecret-1-0 libsecret-common build-essential g++ libx11-dev libxkbfile-dev libsecret-1-dev python3
Steps to Reproduce: git .. clone ..microsoft/vscode
readme_linux
1.#check install make sure you run as root not sudo to create a root passwd >>sudo passwd (new password, su (password) to change login ID, install from user account no errors
2. yarn -v
3. npm -v update npm install -g npm@latest
4. node -v curl --compressed -o- -L https://yarnpkg.com/install.sh | bash
5. python3 -V
6.# start clean new build
7. ./scripts/npm.sh &>npm-sh.log
8. tail npm-sh.log
this will be update for chroot Debian ./scripts/npm.sh &>npm-sh.log
non chroot works it appears
root@coco:/home/coco/vscode# apt-cache search libsecret
gir1.2-secret-1 - Secret store (GObject-Introspection)
libsecret-1-0 - Secret store
libsecret-1-dev - Secret store (development files)
libsecret-common - Secret store (common files)
libsecret-tools - tool for storing and retrieving GObject passwords
root@coco:/home/coco/vscode# git commit --all -m up

husky - npm run -s precommit
husky - node v16.15.0

Reading git index versions...
[main b54623e1d68] up
Committer: root root@coco
Your name and email address were configured automatically based
on your username and hostname. Please check that they are accurate.
You can suppress this message by setting them explicitly. Run the
following command and follow the instructions in your editor to edit
your configuration file:
git config --global --edit

After doing this, you may fix the identity used for this commit with:
git commit --amend --reset-author

1 file changed, 2000 insertions(+), 2606 deletions(-)
root@coco:/home/coco/vscode#

new repo install
git pull is clean
the build is progressing

Please stop spamming us with issues. Based on your other issues it seems to me you either did some setup wrong of have a problem with your environment. Note that this is not a support forum, if you're having a slew of issues related to the build it's probably your machine as we have many people building on Linux.
You might find it useful to see how we build the product in CI which is defined here:
https://github.com/microsoft/vscode/blob/717bb2892f32c298ec0b76b5d81d040330bd3c4a/.github/workflows/ci.yml#L97-L177

Please stop spamming us with issues. Based on your other issues it seems to me you either did some setup wrong of have a problem with your environment. Note that this is not a support forum, if you're having a slew of issues related to the build it's probably your machine as we have many people building on Linux.
You might find it useful to see how we build the product in CI which is defined here:
https://github.com/microsoft/vscode/blob/717bb2892f32c298ec0b76b5d81d040330bd3c4a/.github/workflows/ci.yml#L97-L177
#150500, #150689, #150765

it not spam calm down
arm64 failed
[coco@localhost:~/vscode] $git commit --all -m up

husky - npm run -s precommit
husky - node v16.15.0

Reading git index versions...
Error: Cannot find module '@typescript-eslint/experimental-utils'
Require stack:

/home/coco/vscode/build/lib/eslint/code-no-unexternalized-strings.js
/home/coco/vscode/node_modules/gulp-eslint/node_modules/eslint/lib/rules.js
/home/coco/vscode/node_modules/gulp-eslint/node_modules/eslint/lib/linter.js
/home/coco/vscode/node_modules/gulp-eslint/node_modules/eslint/lib/api.js
/home/coco/vscode/node_modules/gulp-eslint/index.js
/home/coco/vscode/build/hygiene.js
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Module.require (node:internal/modules/cjs/loader:1005:19)
at require (node:internal/modules/cjs/helpers:102:18)
at Object. (/home/coco/vscode/build/lib/eslint/code-no-unexternalized-strings.js:7:30)
at Module._compile (node:internal/modules/cjs/loader:1105:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
at Module.load (node:internal/modules/cjs/loader:981:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Module.require (node:internal/modules/cjs/loader:1005:19) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/home/coco/vscode/build/lib/eslint/code-no-unexternalized-strings.js',
'/home/coco/vscode/node_modules/gulp-eslint/node_modules/eslint/lib/rules.js',
'/home/coco/vscode/node_modules/gulp-eslint/node_modules/eslint/lib/linter.js',
'/home/coco/vscode/node_modules/gulp-eslint/node_modules/eslint/lib/api.js',
'/home/coco/vscode/node_modules/gulp-eslint/index.js',
'/home/coco/vscode/build/hygiene.js'
]
}

husky - pre-commit hook failed (add --no-verify to bypass)
husky - to debug, use 'npm run precommit'

That module is in the yarn.lock and it has been since January, it should work:
https://github.com/microsoft/vscode/blob/5854ef865c12cd0da295485dc676416779da106e/build/yarn.lock#L685-L690
Try yarn add<EMAIL_ADDRESS>to force it. Use git commit --no-verify if it still causes problems


Automated cherry pick of #3670: * 修复redis新建无密码及公网访问地址未同步的问题

Cherry pick of #3670 on release/2.13.
#3670: * 修复redis新建无密码及公网访问地址未同步的问题

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@a77688f). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.13   #3672   +/-   ##
==============================================
  Coverage                ?   6.95%
==============================================
  Files                   ?     500
  Lines                   ?   83887
  Branches                ?       0
==============================================
  Hits                    ?    5836
  Misses                  ?   77555
  Partials                ?     496

Flag
Coverage Δ

#aFlag
6.95% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/elasticcache_instances.go
1.27% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77688f...41f26fb. Read the comment docs.

/approve


feat: implement own LdpIssuer (replacing Titanium)

What this PR changes/adds
This PR adds another, simpler-to-use API for the Issuer part of Titanium. The key aspect is that is uses the EDC expansion/compaction algorithm using the
cached documents.
Why it does that
The Titanium implementation lacks some key aspects, such as adding contexts for SignatureSuites and it is generally cumbersome to use, especially with respect to document caching.
Further notes

the tests were mostly just copied over, no new tests were added
the old IssuerTests are kept in place for the time being, but they should eventually get deleted.
no new functionality was added, it was merely refactored.

Linked Issue(s)
Links to https://github.com/eclipse-edc/IdentityHub/issues/154
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Codecov Report
Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (a62205b) 72.10% compared to head (9ea893e) 72.07%.
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3604      +/-   ##
==========================================
- Coverage   72.10%   72.07%   -0.03%
==========================================
  Files         897      898       +1
  Lines       17919    17969      +50
  Branches     1018     1022       +4
==========================================
+ Hits        12920    12951      +31
- Misses       4562     4577      +15
- Partials      437      441       +4

Files
Coverage Δ

...dc/verifiablecredentials/linkeddata/LdpIssuer.java
62.00% <62.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


"No typecheck results" in .fsx referencing .fs file with #load directive outside of project

When .fxs file is referencing .fs file with #load directive it shows "No typecheck results|No typecheck results" in the codelens instead of type informations. If it references .fsx file it works correctly (i.e. shows types).  This behaviour is only present using ionide outside of f# project.
To Reproduce
Steps to reproduce the behaviour:

Create files:
Sandbox1.fsx

let i = 5

let add a = a + 2

#load "lib1.fsx"

Sandbox2.fsx
let i = 5

let add a = a + 2

#load "lib2.fs"

And empty files lib1.fsx, lib2.fs
Files are also attached in FSharp.zip

Open Sandbox1.fsx and inspect the codelens behaviour
Open Sandbox2.fsx and inspect the codelens behaviour

Actual Behaviour
Codelens does not show type information related to the variable i, and add function in Sandbox2.fsx. It shows "No typecheck results|No typecheck results"  instead.but shows the type information in Sandbox1.fsx.
Expected behaviour
Codelens should show type information related to the variable i, and add function in both Sandbox1.fsx and Sandbox2.fsx the same way as it works in Sandbox1.fsx.
Screenshots

When .fs file is opened bottom status bar shows a message "Not in F# project (still loading)" even after few minutes. If there is any code in the .fs file the Codelens works correctly there, i.e. shows type information without issues.

Environment (please complete the following information):

OS: windows 10.0.17763
Ionide version: 4.0.0
VSCode version: 1.35.1
dotnet SDK version: 2.2.104
mono / .Net Framework version: .NET Framework 4.7.3190.0

Additional context
Hopefully this not a new behaviour by design. This used to work. I was happily using it like this for scripting purposes.

Getting this also. It seems to stop all ionide from working.. for instance even fsi.Start is not available anymore. It looks like it's failing very early during extension loading.

Pretty sure this is duplicate of #669. Closing in favour of old issue.


Safari (and maybe Firefox) reports spurious errors about image sizes

I don't know why, and I'm real salty at Apple about it.

Should use this:
https://www.npmjs.com/package/image-size


fix the doxygen input path

Description of changes:
fix the doxygen input path.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks, @yosoufe !


Const correct sweep

Do a once-over of all variables & ensure that they're const-correct.
Some variables may not be at the time of writing this.

Performed with this commit.


Database Interop Rollforward

It appears as though some tests failed after submitting my Database Interop PR.

Not sure why the failures occurred after the commit, they now seem to be passing.
Are there flaky tests I should be aware of?

There are occasional flakes on these tests but they're usually time outs, not wrong values.  Do the integration test pass locally.
Note that the integration tests do not run on travis PRs.  You can enable them to run on your branch by adding the branch at https://github.com/firebase/firebase-ios-sdk/blob/master/.travis.yml#L282

I believe my latest commit should fix all the tests. Please have another look.


Use with DXVK

Hi, it's possible use D8VK with DXVK? I mean D8VK using same environment variables as DXVK, so example DXVK_CONFIG_FILE can be apply for DXVK and D8VK simultaneously which can call conflicts. I want to see examplle D8VK_CONFIG_FILE instead of DXVK_CONFIG_FILE

Hi, it's possible use D8VK with DXVK?

Yes, both can coexist in a Wine/Proton prefix.

I mean D8VK using same environment variables as DXVK, so example DXVK_CONFIG_FILE can be apply for DXVK and D8VK simultaneously which can call conflicts. I want to see examplle D8VK_CONFIG_FILE instead of DXVK_CONFIG_FILE

While d8vk will load the config file specified in DXVK_CONFIG_FILE and take any d3d9 options into account, there shouldn't be any "conflicts", because d8vk uses dxvk's d3d9 backend. This behavior is more or less intended (and desirable) and will function similarly once d8vk is upstreamed/merged into dxvk.

I understand what if I can use one configuration for D8VK and DXVK and it will work?

I understand what I can use one configuration for D8VK and DXVK (Like DXVK_HUD and dxvk.conf) and it will work?

Yes, same variables will be used for both. I am currently doing that in fact for configuring the HUD and log levels in both dxvk and d8vk.

Okay, thanks


Recording in ARKit with iPad

When I use ipad to record ARKit SCNView, the picture is not normal and the size is wrong
You can see the picture here,
The first picture is the screen display
https://1drv.ms/u/s!AmpfcHWI3MLhanf1KCXPFdlZMus?e=KZ8Z5M
The second picture is the capture result
https://1drv.ms/u/s!AmpfcHWI3MLha_BwTAUGmCHfbxI?e=z17XLb
Are there any settings that need to be modified when using iPad to capture?
Thank you.

Now , I have solved it

Can someone help me? Another problem, when I play the video recorded by iPAD on Windows PC, the video rotate 90 and mirror @gorastudio-ceo

What player do you use on Windows?Can you try something like vlc?Vladislav GrigoryevOn 30 Mar 2023, at 9:04 AM, frank @.***> wrote:
Can someone help me? Another problem, when I play the video recorded by iPAD on Windows PC, the video rotate 90 and mirror @gorastudio-ceo
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

What player do you use on Windows?Can you try something like vlc?Vladislav GrigoryevOn 30 Mar 2023, at 9:04 AM, frank @.> wrote: Can someone help me? Another problem, when I play the video recorded by iPAD on Windows PC, the video rotate 90 and mirror @gorastudio-ceo —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.>

In fact, there are two problems. Use ARScnView to record video and take pictures on the ipad. The direction of the video and the display of the screen are wrong.
Another problem is that even if you change your code so that the ipad recording video looks correct, when the video is uploaded to the windows pc, it will be mirrored with any player, and some will even be rotated and mirrored

@gorastudio-ceo hi, can you help to try this on iPad? I think there are some issues. Thank you


Develop

Merge latest changes on develop into master. Main updates are:

Adjusted minimum time between scroll events to make canvas scroll slower on touch pads
Add many-to-one question type
Add scalebar to WSI viewer

Okay, great! I will merge this now, then we'll continue with the To do-list 👍


Deleted and re-created namespace cannot be used until tf-controller restart

TLS secret is not regenerating after deleting.
Observing it in v0.14.2
How to reproduce:

Create a namespace in k8s and a terraform resource in it. Runner runs apply, everything goes well.
Delete the terraform resource, Runner runs destoy, everything goes well. TLS secret stays in the namespace
Delete the namespace along with TLS secret. Then create it again with the same name. And add a terraform resource in it.
Runner goes into CrashLoopBackOff with error secrets "terraform-runner.tls-1686151888" not found

Log of tf-controller says that secret is there despite it's not.
"msg":"trigger namespace tls secret generation","controller":"terraform"
"logger":"cert-rotation","msg":"TLS already generated for ","namespace":"delete-me"
"msg":"show runner pod state: ","controller":"terraform", ... ... "state":"running"

Restart of controller fixes that.
What I expect:
TLS is generated when it's not there without restart.
========
User Story:
As a Terraform Controller user,
I'd like the TLS secret to be generated automatically when a namespace is deleted and recreated with the same name,
so that the Runner doesn't go into CrashLoopBackOff and requires a manual restart of the tf-controller.
Acceptance Criteria:

[ ] When a namespace is deleted and recreated with the same name, the TLS secret should be regenerated automatically.
[ ] The Runner should not go into CrashLoopBackOff when the namespace is deleted and recreated with the same name.
[ ] The tf-controller should not need a manual restart to generate the TLS secret for the recreated namespace.
[ ] Testing is added.
[ ] We've created relevant user documentation.

I can't reproduce this specific error, but I can't say it's resolved, at least the "Delete the namespace" part.
The simplest approach to the problem to just delete the mtls cert
If I delete the mtls cert, it will create a new one, so that's good. If I create a new Terraform resource, delete the cert, it will create a new one as well.
Deleted whole namespace
When we install the helm chart, we create a ServiceAccount in all namespaces where the runner is allowed to run. When we delete the namespace, we delete the ServiceAccount too, and when we re-create the namespace, the ServiceAccount will not be there. As a result the runner has no ServiceAccount in that namespace and can't be created.
With the current architecture, we do not support deleting the namespace and we don't have plans to do it directly on that layer.
What's your opinion @chanwit ?

Related #584

With the current architecture, we do not support deleting the namespace and we don't have plans to do it directly on that layer.

That's correct. We're working on revisiting the current architecture to enhance it and support resource deletion properly for many complex scenarios, including this one.


how can we train on custom VOC dataset??

I want to train on custom dataset with VOC format

You need to change Dataset reading. That is changes in data/voc0712.py
VOC_CLASSES and some other changes according to the data. I have also trained on the custom dataset.

It would be nice to have a small example

It would be nice to have a small example

@mingzhanliao

Assume that you've had custom dataset in VOC format named VOC_CUSTOM, them put VOC_CUSTOM in data/ folder i.e data/VOC_CUSTOM
In /data/voc0712.py, change VOC_CLASSES to VOC_CLASSES = [('label_1', 'label_2', 'label_3')] as many as you want
Correct some path in class VOCDetection(data.Dataset):
Change num_classes in 'voc = {}' in data/config.py to len(VOC_CLASSES) + 1

Nice, thanks brother


gui: fix psbt update

first commit is a non regression test, should fail on CI.
close #1133

rebased after a fix on the regression test


fixlike function's nullable property should be PropagateNullable

Proposed changes
Issue Number: close #xxx
<--Describe your changes.-->
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


[T3A2][T09-A3]Francis Cheng

Ready for review

@francischeng070
Some comments added. Please ack & close the PR after reading comments.

ack


Fixes client endpoints and adds docstrings

As I was writing up the changelog, I realised we should be highlighting that in comparison to the rest of the library, these are experimental features that are not as well tested.
For instance, I realized that the current endpoints for bookstore did not match those that we actually provide as part of our API 🤦♀.
The changes to the endpoints are the only non-doc changes. If needed to get this ready to be merged in time for 2.3.0, I can break those out into a separate PR before we release: https://github.com/nteract/bookstore/pull/142/commits/80a9559f5a0d50175919f0dfda74dcdfa116d5bb
So I fixed that, and updated all of their docstrings to mention their experimental nature. I didn't do so for the records because we're actually testing those.
While I was at it I also improved the docstrings on the various class methods & modules.

Grazie!


WIP Instrumenting Failed and Errored jobs

This is mega-rough, but submitting a WIP draft to iterate on.
This is currently breaking the test suite. It also doesn't have any automated tests. May need to restructure the code in order to allow this to be easily tested in a handler-agnostic way.

One stretch goal would be to use histogram instead of increment. In addition to counts, this would capture timing data for each job.

Yeah totally. I was planning on doing that in a separate effort. One metric for histogram/timing information for all jobs. A different metric for the number of errors and failures we encounter.
But I have no problem storing the number of failures/errors as a histogram. That'll give us both timing for just failures/errors as well as counts.

I was planning on doing that in a separate effort.

👍 Shipping the counts now and the histograms later sounds good.
My one recommendation would be to use the same count key as the histogram:
statsd.increment('jira_integration.jobs.started.count')
# then later
statsd.histogram('jira_integration.jobs.started')

While this isn't required, it ensures the metric name doesn't change when the histogram work is done.
You may have already considered recommendation. If so, carry on! 😄

You may have already considered recommendation.

Oh I didn't! Good idea!

This is all set as of https://github.com/integrations/jira/pull/312


[Idea] Ctrl+click a node to allocate it without pathing to it

This is probably a ball of worms to implement - I have no idea. But with the new anointed oils in Blight league, it would be very convenient to be able to allocate a node without pathing to it by ctrl+clicking on them. (currently ctrl+click/right-click will zoom in and out)
Presumably some functionality like this will need to be added to support the Implicit modifiers that will actually be appearing on gear in 3.8, but this might be a more convenient theorycrafting option than changing implicits.

Interesting thought. I will look around at the crafting system to see if it could simply be added there. :)

Looks like 1.4.152 implemented something close to this.


Bump version to 0.5.1

What does this PR do?
This version only includes the following commit https://github.com/DataDog/dd-bridge-android/commit/aefb759b7edf4b67b1040639f5ca51691fb9eba3 (SDK version change 1.11.0-beta1 -> 1.11.0-rc1) compared to 0.5.0.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #47 (1c580d6) into main (7956ad0) will decrease coverage by 0.37%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main      #47      +/-   ##
============================================
- Coverage     83.39%   83.03%   -0.37%
+ Complexity      117      116       -1
============================================
  Files             9        9
  Lines           271      271
  Branches         33       33
============================================
- Hits            226      225       -1
- Misses           34       35       +1
  Partials         11       11

Impacted Files
Coverage Δ

...n/com/datadog/android/bridge/internal/BridgeRum.kt
74.07% <0.00%> (-1.23%)
:arrow_down:

...n/com/datadog/android/bridge/internal/BridgeSdk.kt
92.55% <0.00%> (ø)

...adog/android/bridge/internal/ProxyAuthenticator.kt
96.15% <0.00%> (ø)


Getting issue in nullable.hpp file while integrating the azure sdk for cpp into our application

Query/Question
Getting issue
Error	C2556	'int64_t *Azure::Nullable<int64_t>::operator ->(void) const': overloaded function differs only by return type from 'const int64_t *Azure::Nullable<int64_t>::operator ->(void) const' (compiling source file login.cpp) in file nullable.hpp while integrating azure sdk into our project.I have not made any changes in the file still getting the errors.
In login.cpp I have used header files
#include<azure/identity.hpp>
#include<azure/core.hpp>
Why is this not a Bug or a feature Request?
The problem could be resolved by adjusting the implementation to avoid overloading based only on return type. This typically involves refactoring the function signatures or ensuring that only one version of operator-> exists.
Setup (please complete the following information if applicable):

OS: Windows
IDE : Visual Studio Community 2015

I'm a tad confused. Based on my reading of the source code, there are two different declarations of the operator-> method.
At line 281, we have:
  constexpr const T* operator->() const { return std::addressof(m_value); }

which applies to const Nullable values.
At line 291 we have:
  constexpr T* operator->() { return std::addressof(m_value); }

which applies to Nullable values (mutable or non-const). So there shouldn't be any ambiguities in the implementation.
Your bug report doesn't indicate which line is upsetting the compiler, so it's hard to fully understand what is causing challenges.
If it is possible to build a stand-alone reproduction of the problem, it would help a great deal in understanding the problem.
I did notice that you are using a rather old version of Visual Studio community edition (2015). We don't include this version of the compiler in our tests because it is a fairly old version of the compiler.
Would it be possible to try this on a newer version of Visual Studio? There have been many language compliance related changes made to Visual Studio over the past 8 years which may be affecting your code.

Yes , I will try with Visual Studio 2022 and let you know . Thanks!!!!!

@yashshah-22, apparently our bot didn't notice you had replied - feel free to ignore that :).
Looking forward to your update.


Make AWG5208 support four markers

Quick repair of AWG5208 driver
Changes proposed in this pull request:

Increase the number of markers per channel to 4
Change the allowed channel resolutions from (8, 9, 10) to (12, 13, 14, 15, 16)

I suspect that the .wfmx and .seqx file generation may still have to be updated.
@wpfff

Looks good to me!


[ASCII-1325] Fix remaining macos test popups

What does this PR do?

Make some tests bind to localhost instead of <IP_ADDRESS>.
Motivation

Remove the remaining pop-ups when running tests on MacOS.
Additional Notes

Follow-up of https://github.com/DataDog/datadog-agent/pull/23822.
Should remove all remaining pop-ups.
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Build packages without a _checkouts folder

This is useful when upgrading dependencies but not wanting to commit the
changes yet.

Merged this as it fixes a few annoying bugs and doesn't influence other Makefile targets.


Fixed the issue of errors in fully silent sentences during evaluation.

When recognizing, if a sentence is completely silent, blank skip will reduce all frame. Exception occurs:
Traceback (most recent call last):
File "/data/k2/icefall/egs/xxxx/Rework/./pruned_transducer_stateless7_ctc_bs/ctc_guide_decode_bs.py", line 847, in
main()
File "/data/k2/miniconda3/envs/k2-1080ti/lib/python3.9/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
return func(*args, **kwargs)
File "/data/k2/icefall/egs/xxxx/Rework/./pruned_transducer_stateless7_ctc_bs/ctc_guide_decode_bs.py", line 828, in main
results_dict = decode_dataset(
File "/data/k2/icefall/egs/xxxx/Rework/./pruned_transducer_stateless7_ctc_bs/ctc_guide_decode_bs.py", line 571, in decode_dataset
hyps_dict = decode_one_batch(
File "/data/k2/icefall/egs/xxxx/Rework/./pruned_transducer_stateless7_ctc_bs/ctc_guide_decode_bs.py", line 464, in decode_one_batch
hyp_tokens = greedy_search_batch(
File "/data/k2/icefall/egs/xxxx/Rework/pruned_transducer_stateless7_ctc_bs/beam_search.py", line 633, in greedy_search_batch
packed_encoder_out = torch.nn.utils.rnn.pack_padded_sequence(
File "/data/k2/miniconda3/envs/k2-1080ti/lib/python3.9/site-packages/torch/nn/utils/rnn.py", line 262, in pack_padded_sequence
_VF._pack_padded_sequence(input, lengths, batch_first)
RuntimeError: Length of all samples has to be greater than 0, but found an element in 'lengths' that is <= 0
Add code to fix (ensure at least one frame exist after frame reduce).

@yfyeung Could you help review this PR?

@drawfish Thanks for your suggestion.
This model is in the LibriSpeech, whose test set does not have entirely silent sentences.
IMO, you should modify the code of the export model.


Gamepad is not working on Tizen SmartTV after 3.24.1

Version

Phaser Version: 3.24.1 and 3.55.2

Operating system: TizenOS

Browser: TizenOS Browser

Description
The gamepad sample stops working on Tizen SmartTV (inside the Tizen Browser) after release 3.24.1 (excluded).
After version 3.24.1 until latest version 3.55.2, the gamepad plugged to the SmartTV is recognized in the sample application, but no input is received by the application. Up to version 3.24.1, gamepad is recognized and inputs are received correctly.
We have not experienced this issue on another Operating System so far.
Example Test Code
We use the Phaser gamepad-debug application, which allows to choose the version of Phaser, and makes it easy to reproduce the issue.
https://phaser.io/examples/v3/view/input/gamepad/gamepad-debug
https://labs.phaser.io/edit.html?src=src/input/gamepad/gamepad debug.js&v=3.55.2
Additional Information
If you do not have access to a Tizen SmartTV, we can definitely assist you in trying to reproduce and fix the problem.

I'm not sure there's a massive amount we can do about this here, as we don't have access to a Tizen Smart TV. So it will require debugging from your end I'm afraid.
I'm not sure a great deal changed in the Gamepad code between 3.24 and 3.55 however, so it likely isn't a big change we're looking for. In fact, I can only see 2 commits from Sep 11th 2020 that may have caused this:
https://github.com/photonstorm/phaser/commits/master/src/input/gamepad

Closing as we cannot fix this here. Happy to take a PR that does so, though.


Enable signature verification for feature install

In addition to https://github.com/OpenLiberty/open-liberty/issues/17220.
FeatureUtility now verifies downloaded features from Maven Central. Enabling the same functionality for Liberty Maven Plugin's install-feature goal and Liberty Gradles Plugin's installFeature task.

We plan on doing a release by the end of September. Does this need to go into that? This requires changes in ci.maven and ci.gradle too right? And new tests?


A potential bug of null pointer dereference

hello, I found a potential bug of null-pointer-dereference in source code of pangoterm,could you help me check if this bug is true?thank you very much.
the overview of occurrence of the bug is shown as follow:

step1:
in file pangoterm/conf.c , line 241, call g_strdup
step2:
in file glib2.0-2.56.4/glib/gstrfuncs.c , line 360. select the false branch,which means str == null
step3:
in file glib2.0-2.56.4/glib/gstrfuncs.c , line 367. load null to new_str
step4:
in file glib2.0-2.56.4/glib/gstrfuncs.c , line 369. return new_str(null)
step5:
in file pangoterm/conf.c , line 241, load return value of g_strdup to longname
step6:
in file pangoterm/conf.c , line 244---line 246,derefer longname(s) here without check if longname(s) is null.

would you give me a reason where closed this issue? Is this bug is false? Looking forward to your reply.Thanks.

It's spam. Just autogenerated from some scan-build tool with no understanding of the code itself.

thank you.


Approving RPC executed commands with a middleware interceptor

With the soon ready feature of add a macaroon based RPC middleware interceptor https://github.com/lightningnetwork/lnd/pull/5101,
It would seem possible to add a custom caveat signed to a macaroon permission
like describe in https://github.com/lightningnetwork/lnd/issues/4510#issuecomment-669928410
The interceptor would look at RPC commands with the custom caveat macaroon 'signed'
and validate that they message include a signature and that the signature is trusted by the system.
This would make it possible to approve every single critical command for a Half-Trusted-Actor.
The Half-Trusted-Actor would generate a command and send it to an Auth-Service for approval.
A Human could approve it minutes later and the Auth-Service could sign the command-message.
After the Half-Trusted-Actor could pull/push the signature for the command-message from the Auth-Service
and send the command including its macaroon and signature of the message normally to RPC service.
Example:

An automated SystemA has the macaroon offchain#signed
SystemA receives an invoice to pay
It generates the payinvoice-command and sends it to the Auth-Service
A Humanoid gets this payinvoice-command from the Auth-Service on an other App or UI and approves and signs it.
The Auth-Service infoms SystemA about the approved command-message  and it's signature
SystemA makes a normal payinvoice call to the gRPC but including the signature in the grpc-header.
the interceptor approves the request.
payment done.

AFAICT, this can be done entirely with #5101, so this is just more of a brain storming issue?

Yes is brain storming, most likely it can be done with it.
There are view things to discussion
.) How to construct the command-data, that it can be displayed to humans, approve/sign and verified in the interceptor.
.) How to protect against double post
.) Naming things
.) Are custom caveats working like this?
.) Should the auth-service be external and/or internal hosted?
This approve system would be so generic that following would be possible:
.) Approve new macaroon with a different IPAddressLock
.) Approve to stop the LN node
...
The whole feature would be similar to Authy Push Notification

This approval feature would make other very nice things possible too.
an agent-service that listen on attached payload-data on payments.
Example:

Some actor makes a keysend of 1000sats to a node and attaches a command to approve in the payload-data
the agent-service gets triggered and post the command to approvie to the auth-service
A.3) the user decline the requests and his profit would be 1000sats.
B.3) the user accepts the request
B.4) the agent-service gets the approvement from the auth-service and send it to the actor back including the 1000sats


fix: retrieving from rendering popup Code Copied multiple times

🛠 Fixes Issue
Closes #187
Cause
gradientBorderGenerator was being called multiple times at the same time, so it was rendering popup multiple times
👨💻 Changes proposed
calling gradientBorderGenerator once and keeping the code behaviour as it is
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

:tada: This PR is included in version 2.4.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Replace SVN (1.8.17) by TortoiseSVN (1.14.x) on Windows images

Hello everyone,
On Windows images, we use svn choco formula to install SVN. This formula is not updated for a few years and provide SVN 1.8.17.
We are going to replace this formula with tortoisesvn that contains SVN 1.14. TortoiseSVN is one of recommended ways to install SVN on Windows machines.
We are going to deploy these changes on August 11.
Please let us know if you have any concerns or objections

Deployment has finished, changes were deployed to all VMs


FR: Do not auto format if only the modifed field changes

Is Your Feature Request Related to a Problem? Please Describe.
I'd love to enable Lint on File Change option but I have a problem with it.
I'm using Linter to add created and modified in YAML to track my notes changes.
When I simply open a note and close it (no modif), the modified time in the YAML header changes, which adds a modified file in Git and messes up my Dataview querywith the modified field.
Describe the Solution You'd Like
I don't know about the code things, can we add a check if there are nothing formated except modified filed then don't format the notes?
Describe Alternatives You've Considered
For now I'm using Lint on Save which is a little inconvenient and sometimes forgot to save manually.
Additional Context
here is what diffview looks like

@pjkaufman Thanks for your hardwork, I just tested with a new vault and find out that might be syncing issue which caused by remote-save.🤣
But it would be nice to have a option to auto lint depending on actual file changes instead of file modification time in obsidian, like what we did for the creation time. File metadata is not "true" sometimes and that's why we add extra YAML frontmatter for creation or modification time.

Yeah. That definitely sounds like a syncing issue since many syncing services do not set the file metadata to the same thing across systems.
But as for adding this, it definitely sounds like #183 would handle the problem for modification date. But it will likely be some time before all the tickets that prevent its implementation get added.

You may be able to use https://obsidian.md/plugins?search=update%20modified for the time being to automatically update date modified when a file changes.

OK thanks, this workaround works perfect.


Display: Flex prefixes can't be disabled when shorthand is used

When Emmet preferences.json is set to "css.autoInsertVendorPrefixes": false - The expected behaviour is the no vendor prefixes are added when snippet are expanded. This works, seemingly everywhere, with one exception:
d:f correctly expands to display: flex;
but
df incorrectly expands to
display: -webkit-flex;
display: -moz-flex;
display: -ms-flex;
display: -o-flex;
display: flex;

This issue does not exist with other properties such as jc:c or jcc for justify-content: center;

Atom: 1.9.9
Emmet: 2.4.3

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/37091645-display-flex-prefixes-can-t-be-disabled-when-shorthand-is-used?utm_campaign=plugin&utm_content=tracker%2F535900&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F535900&utm_medium=issues&utm_source=github).

Duplicate of #336
Fixed when "caniuse.enabled": false is also set. Still think this a valid bug, though.

Oh god I'm back 2 years later from a Google search which ended in the same place. Lord have mercy on my soul.

Dear future John, what is the year 2020 like? Do they have chairs? I'm writing you this message from the year 2018, and properly documenting the fix for this, which I wish I had written down way back in 2016.
You probably got a new Mac recently. You probably installed emmet, went to write some CSS, and found emmet spewing nonsensical browser vendor prefixes everywhere. You probably thought to yourself "fuck, not this again" and spent the last 30 mins furiously googling how to unset this ridiculous preference. Again.
Well future John, it is I, past John, who shall be your saviour. Here's what to do:

Open Atom preferences
Packages
Emmet
Change the Extensions Path to your project dir, like ~/Sites/emmet
Inside ~/Sites/emmet create a new preferences.json
Inside that file place the following:

{
  "css.autoInsertVendorPrefixes": false,
  "caniuse.enabled": false
}

Save, and restart Atom
Leave a comment on this issue to iterate the number of times this has fucked you over by: 1

Love
Past John

Dear John,
I hope you’ll start using new updated Emmet plugin in near future :)
https://github.com/emmetio/atom-plugin

I tried all possible instructions to repair an autoprefixer.  It was only succeeded to solve after I removed emmet from atom. And anew install it.

what emmet display flex in VS Code?
display: -webkit-flex;
display: -moz-flex;
display: -ms-flex;
display: -o-flex;
display: flex;


redis-cli --pipe syntax error

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
kvrocks unstable 40989fc26dc4229bd9f797c14eaa4df07574f47e
ubuntu 22.04
Minimal reproduce step
root@localhost:~# cat /tmp/text1.txt
set zzzap zzzzzzzzzzzzzzzzznologin
set vv zzzzzzzzzzzzzzzzpsbinnologin

root@localhost:~# cat /tmp/text1.txt | redis-cli --pipe --verbose

What did you expect to see?
This is with redis or keydb
root@localhost:~# cat /tmp/text1.txt | redis-cli -h xx.79.179.186 --pipe --verbose
All data transferred. Waiting for the last reply...
Last reply received from server.
errors: 0, replies: 2

What did you see instead?
root@localhost:~# cat /tmp/text1.txt | redis-cli --pipe --verbose
All data transferred. Waiting for the last reply...
ERR syntax error
Last reply received from server.
errors: 1, replies: 1
Anything Else?

redis-cli --version
redis-cli 6.0.16

Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Hello @dirkpetersen, many thanks for your feedback.
The root cause is that Kvrocks's inline protocol didn't support the \r\n separator. Will align this with Redis behavior and it only works like below:
❯ echo "set a 1\r\nset b 2\r\n" > pipes.txt
❯ cat pipes.txt
set a 1
set b 2

❯ cat pipes.txt | redis-cli -p 6666 --pipe --verbose
All data transferred. Waiting for the last reply...
Last reply received from server.
errors: 0, replies: 2

BTW, PR is always welcome!


haders for Imgur

Hello, I need to send authorization to Imgur.
I use configuration:
     dropzoneOptions: {         url: 'https://api.imgur.com/3/image',         headers: { Authorization: 'Client-ID .......' }
After send an image i get a message in console:

Access to XMLHttpRequest at 'https://api.imgur.com/3/image' from origin 'http://localhost:8080' has been blocked by CORS policy: Request header field Cache-Control is not allowed by Access-Control-Allow-Headers in preflight response.

I think this is because I did somethind wrong with the authorization.
With axios the it works ok.
What should I fix?

Hi @iliakut
Hmm it looks like perhaps dropzone is adding a cache-control header to the request which is throwing things off. Can you see that present on the request headers, if so it should be possible to remove that header and see what happens?

I've found the answer. I need to send
                  'Cache-Control': null,                   'X-Requested-With': null,
in header
and I did't attached
paramName
in DropZone options.

@iliakut how did u set these headers? I only see the option to add additional headers in this component.
Or @rowanwins can you help me? I have the same issue.


Reusable apps can not be shipped with migrations

Hello!
First of all, many thanks for this repo! I hope Django will ship this feature in its core in not such a distant future.
I think that migrations don't really work with this system (except for simple cases).
Consider 3 models with ForeignKey relationships, A -> B -> C (C depends on B which depends on A). If you swap model B for your own, you will run into a problem:

the reusable app needs your model B to migrate, because A uses B, which you redefined
your website needs model C to migrate, because B has a ForeignKey to C, but C is in the reusable app

If you generated the migrations file in the reusable app, you basically end up with a circular import.
django.db.migrations.exceptions.CircularDependencyError: other_app.0001_initial, reusable_app.0001_initial

You can actually see the problem with the following example:
models.py in the reusable app:
import swapper

from django.db import models

class BaseA(models.Model):
    class Meta:
        abstract = True

class A(BaseA):
    class Meta:
        swappable = swapper.swappable_setting('reusable_app', 'A')

class BaseB(models.Model):
    a = models.ForeignKey(swapper.get_model_name('reusable_app', 'A'), on_delete=models.CASCADE)

    class Meta:
        abstract = True

class B(BaseB):
    class Meta:
        swappable = swapper.swappable_setting('reusable_app', 'B')

class BaseC(models.Model):
    b = models.ForeignKey(swapper.get_model_name('reusable_app', 'B'), on_delete=models.CASCADE)

    class Meta:
        abstract = True

class C(BaseC):
    class Meta:
        swappable = swapper.swappable_setting('reusable_app', 'C')

models.py in the other app:
from django.db import models
from reusable_app.models import BaseB

class B(BaseB, models.Model):
    name = models.CharField("extra field for B", max_length=255)

First attempt: we generate migrations for the reusable app first
In this first case, your other app is not in INSTALLED_APPS, and you only make migrations for your reusable app, so that it can create a proper database schema when installed.
So you run:
$ ./manage.py makemigrations reusable_app
Migrations for 'reusable_app':
  reusable_app/migrations/0001_initial.py:
    - Create model A
    - Create model B
    - Create model C

You get a nice migrations file:
# -*- coding: utf-8 -*-
# Generated by Django 1.10.2 on 2016-10-19 08:21
from __future__ import unicode_literals

from django.conf import settings
from django.db import migrations, models
import django.db.models.deletion

class Migration(migrations.Migration):

    initial = True

    dependencies = [
    ]

    operations = [
        migrations.CreateModel(
            name='A',
            fields=[
                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
            ],
            options={
                'swappable': 'REUSABLE_APP_A_MODEL',
            },
        ),
        migrations.CreateModel(
            name='B',
            fields=[
                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
                ('a', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to=settings.REUSABLE_APP_A_MODEL)),
            ],
            options={
                'swappable': 'REUSABLE_APP_B_MODEL',
            },
        ),
        migrations.CreateModel(
            name='C',
            fields=[
                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
                ('b', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to=settings.REUSABLE_APP_B_MODEL)),
            ],
            options={
                'swappable': 'REUSABLE_APP_C_MODEL',
            },
        ),
    ]

You can, of course, modify it according to your documentation in order to avoid blindly reading configuration values from django.conf.settings which may not be defined:
# -*- coding: utf-8 -*-
from __future__ import unicode_literals

from django.db import migrations, models
import django.db.models.deletion
import swapper

class Migration(migrations.Migration):

    initial = True

    dependencies = [
    ]

    operations = [
        migrations.CreateModel(
            name='A',
            fields=[
                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
            ],
            options={
                'swappable': swapper.swappable_setting('reusable_app', 'A'),
            },
        ),
        migrations.CreateModel(
            name='B',
            fields=[
                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
                ('a', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to=swapper.get_model_name('reusable_app', 'A'))),
            ],
            options={
                'swappable': swapper.swappable_setting('reusable_app', 'B'),
            },
        ),
        migrations.CreateModel(
            name='C',
            fields=[
                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
                ('b', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to=swapper.get_model_name('reusable_app', 'B'))),
            ],
            options={
                'swappable': swapper.swappable_setting('reusable_app', 'C'),
            },
        ),
    ]

And this works fine:
$ ./manage.py migrate
Operations to perform:
  Apply all migrations: admin, auth, contenttypes, reusable_app, sessions
Running migrations:
  Applying reusable_app.0001_initial... OK

But now, lets say I want to use my other app that ships with its own version of the "B" model.
I add other_app to INSTALLED_APPS and specify REUSABLE_APP_B_MODEL = 'other_app.B'. Now it doesn't work anymore…
$ ./manage.py makemigrations other_app
Traceback (most recent call last):
  File "./manage.py", line 22, in <module>
    execute_from_command_line(sys.argv)
  File ".../django/core/management/__init__.py", line 367, in execute_from_command_line
    utility.execute()
  File ".../django/core/management/__init__.py", line 359, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File ".../django/core/management/base.py", line 294, in run_from_argv
    self.execute(*args, **cmd_options)
  File ".../django/core/management/base.py", line 345, in execute
    output = self.handle(*args, **options)
  File ".../django/core/management/commands/makemigrations.py", line 173, in handle
    migration_name=self.migration_name,
  File ".../django/db/migrations/autodetector.py", line 47, in changes
    changes = self._detect_changes(convert_apps, graph)
  File ".../django/db/migrations/autodetector.py", line 132, in _detect_changes
    self.old_apps = self.from_state.concrete_apps
  File ".../django/db/migrations/state.py", line 180, in concrete_apps
    self.apps = StateApps(self.real_apps, self.models, ignore_swappable=True)
  File ".../django/db/migrations/state.py", line 249, in __init__
    raise ValueError("\n".join(error.msg for error in errors))
ValueError: The field reusable_app.C.b was declared with a lazy reference to 'other_app.b', but app 'other_app' isn't installed.

Well, Django is lying in a way. Because other_app IS installed:
$ ./manage.py check
System check identified no issues (0 silenced).
$ ./manage.py shell
Python 3.5.1 (default, Jan 22 2016, 08:54:32)
[GCC 4.2.1 Compatible Apple LLVM 7.0.2 (clang-700.1.81)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> import swapper
>>> swapper.load_model('reusable_app', 'B')
<class 'other_app.models.B'>

I guess that Django doesn't see the other_app being installed because it reads the reusable_app.0001_initial migration file, which doesn't depend on anything, so it loads it before loading the other_app, and see references to other_app that it cannot resolve.
I tried to add fill the dependencies parameter in reusable_app.0001_initial, I was hoping that it would trigger an import of the other_app, but it didn't change anything:
    dependencies = [
        swapper.dependency('reusable_app', 'A'),
        swapper.dependency('reusable_app', 'B'),
        swapper.dependency('reusable_app', 'C'),
    ]

Second attempt: generate both migration files at the same time
So since generating migrations for the reusable app first doesn't work, there is a workaround. To clean things up, I just deleted the migrations file from the reusable app.
Now the only way to make the whole thing work is to type the following:
$ ./manage.py makemigrations
Migrations for 'other_app':
  other_app/migrations/0001_initial.py:
    - Create model B
  other_app/migrations/0002_b_a.py:
    - Add field a to b
Migrations for 'reusable_app':
  reusable_app/migrations/0001_initial.py:
    - Create model A
    - Create model B
    - Create model C

When I apply these migrations, they are executed in the following order:

other_app.0001_initial
reusable_app.0001_initial
other_app.0002_b_a

I guess that Django splits migrations in order to resolve the circular dependencies issue.
In my real-life project, I have a much more complicated setup with 12 inter-dependent swappable models. I guess it can lead to even more complicated inter-depndencies…

Thanks for the detailed report, I have come across similar issues.  The short answer to the CircularDependencyError is to manually split the migrations in your reusable app into an initial migration that only creates model A, then a second migration that depends on model A and B and creates B and C.
But the lazy reference issue is a bit harder to solve.  I think it may have to do with https://github.com/django/django/pull/6359 which was released with Django 1.10.  Does the same thing happen with Django 1.9?  Either way, there are some underlying assumptions in Django that make it difficult to have automatically generated migrations work as expected when you have multiple swappable models.  So, maybe the best short term approach really is to not ship any migrations in a reusable app, though that does seem a bit funny.
The long term approach is probably to submit a PR with some additional changes to Django - this and the other open tickets on this repo should be useful in identifying what those changes need to be.

Thanks for the answer! Perhaps will be looking into that if I happen to have a bit of more time :)

In your app you just create a basic modell just to have it in the db and create an initial migration without any swap and add this:
run_before = [
        ('reusable_app', '0001_initial'),
    ]

this way you model will exist by the time reusable app looks for swapped models and can create FK to it
in your other migrations you can inherit from any base, that will be just adding fields to you existing model

Closed because it's not a bug but rather a configuration issue.

Closed because it's not a bug but rather a configuration issue.


[Suggestion] Secret bookshelf button

Similar to the brick/netherbrick buttons, a bookshelf that has 1 book act as a button when right clicked.
Would make for good secret areas in libraries and such.

If you use the Inspirations bookshelf, there is the trapped book which is a book emitting a redstone signal. I am not sure right now if a bookshelf like the bricks button makes the most sense as my bookshelves are sorta designed to replace the vanilla ones, but I'll consider it.

Aha, i didn't see the trapped book, sorry about that.
I guess that would work as well, could have the book inside the bookshelf among other books and once pulled out, open doors, etc. Only downside is that people can take it with them, where as having it as a secret level/button thing, it's only useful for that one spot. But i'm mostly seeing this being used in a pre-defined area like a dungeon, and/or in adventure mode maps.
While i think having more options never hurts, the trapbook is probably good enough!

Thinking on this more, I have no plans to add the bookshelf variant. The trapped book feels much more immersive for books.


Fix gh-issues-issue-opened.yml workflow

The previously tried workflow did not work yet with beta projects. This one is promised to do so.

copy&pasta.
This action goes away when GH implements this natively. It's on the roadmap.


pull request for e2e test at 01/14/2017 03:26:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


writing fix

Description
writing fix
Checklist
Essentials

[x] Changes are complete (i.e. I finished coding on this PR)
[x] Code is well-documented

Notes
Many updates in the notebooks are courtesy of @zackchase.

Job PR-301/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-301/3/index.html

Job PR-301/10 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-301/10/index.html


[feature wanted]  thread safe method to flush counters in dataplane

We need a thread safe method to flush counters in dataplane, as there may many thread sharing the same dataplane instance:(https://github.com/p4lang/ptf/blob/c554f83685186be4cfa9387eb5d6d700d2bbd7c0/src/ptf/init.py#L20
Counters: https://github.com/p4lang/ptf/blob/c554f83685186be4cfa9387eb5d6d700d2bbd7c0/src/ptf/dataplane.py#L571-L575

Would something as straightforward as acquiring a lock around all accesses to rx_counters / tx_counters do what you are asking for?  If so, are you interested in submitting a PR for review that does this?


regex syntax missing

I've been using the regexp extension prior to finding the re extension here.  The regexp extension only implements the REGEXP statement but includes additional syntax.  Would it be possible to update re to support the same syntax?
X*      zero or more occurrences of X
X+      one or more occurrences of X
X?      zero or one occurrences of X
X{p,q}  between p and q occurrences of X
(X)     match X
X|Y     X or Y
^X      X occurring at the beginning of the string
X$      X occurring at the end of the string
.       Match any single character
\c      Character c where c is one of \{}()[]|*+?.
\c      C-language escapes for c in afnrtv.  ex: \t or \n
\uXXXX  Where XXXX is exactly 4 hex digits, unicode value XXXX
\xXX    Where XX is exactly 2 hex digits, unicode value XX
[abc]   Any single character from the set abc
[^abc]  Any single character not in the set abc
[a-z]   Any single character in the range a-z
[^a-z]  Any single character not in the range a-z
\b      Word boundary
\w      Word character.  [A-Za-z0-9_]
\W      Non-word character
\d      Digit
\D      Non-digit
\s      Whitespace character
\S      Non-whitespace character

Not in the near future, I'm afraid. Not ready to bury myself in the regexp engine internals.

Understood and thank you for the quick response.  I had hoped the linked code for the other module could be ported without much extra effort.

Unfortunately, it could not. I've considered the regexp extension earlier, and found it not suited for substr and replace operations. So the re extension is built on a completely different engine.

Would not at least some of these be relatively easy?

**     \b      Word boundary
**     \w      Word character.  [A-Za-z0-9_]
**     \W      Non-word character
**     \d      Digit
**     \D      Non-digit
**     \s      Whitespace character
**     \S      Non-whitespace character

Like the \w just gets replaced with [A-Za-z0-9_], \d with [0-9], etc.  If not easy, then I understand.

Not really. Sorry. I'll look into switching the current regexp engine to something more powerful, but the last time I checked, there wasn't one suitable for this project.

The new regexp extension in 0.18.0 provides much more advanced syntax. Unfortunately, it does not support Windows at the time.

Implemented the new regexp extension for Windows in 0.18.1.

Thank you very much for adding this extension.  I'm thrilled to have the additional syntax available now.


Configurator integration

Rest Module

Thank you for contributing to openstack/group-based-policy!
openstack/group-based-policy uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.