compile fails on abc/src/misc/extra/extraUtilUtil.c: "ISO C++17 does not allow 'register' storage class specifier"

Version
0.32
On which OS did this happen?
Linux
Reproduction Steps
I maintain a Gentoo Linux ebuild for Yosys and was updating to the latest version.  Compilation fails during the ABC build:
[ 94%] ABC: `` Compiling: /src/misc/mvc/mvcCover.c
src/misc/extra/extraUtilUtil.c:100:5: error: ISO C++17
      does not allow 'register' storage class specifier [-Wregister]
    register int c;
    ^~~~~~~~~
src/misc/extra/extraUtilUtil.c:101:5: error: ISO C++17
      does not allow 'register' storage class specifier [-Wregister]
    register const char *place;
    ^~~~~~~~~
2 errors generated.
make[1]: *** [Makefile:177: src/misc/extra/extraUtilUtil.o] Error 1

This error also prevents older versions of Yosys from building.  I brought up an issue with the ABC project and got it fixed in https://github.com/berkeley-abc/abc/commit/927b60b7a02e8709768fdaa1301dff2b883dd0cf.  I know that Yosys pulls ABC from its own fork, but you might want to consider rebasing against upstream.
Expected Behavior
Yosys builds properly with current versions of the toolchain.
Actual Behavior
It doesn't.

Related/caused by https://github.com/YosysHQ/yosys/issues/2011.

Got rid of the patch I had been using...looks like it builds fine without it now.  Thanks!


Do we need a new MissingInformationError/MissingMetadataError?

Description of issue or feature request:
We want to use a shortlist of exceptions that will be thrown from our APIs, so that our users can handle them easily.
On another hand that doesn't stop us from creating other more specific exceptions that derive from those main exceptions.
This allows us to easily test that specific errors were thrown when we expected them.
For example we are using BadVersionError and LengthOrHashMismatchError which derive from RepositoryError.
There is the possibility to add a new exception which can be called MissingInformationError or MissingMetadataError.
It will replace RepositoryError which we threw inside the TrustedMetadataSet when:

information for a target is missing inside a new snapshot version compared to an older snapshot version- not sure we need a new one here
updating a delegated target, but snapshot doesn’t contain information for it - not sure we need a new one here

For context see comments: https://github.com/theupdateframework/python-tuf/pull/1725#issuecomment-1012254130, https://github.com/theupdateframework/python-tuf/pull/1725#issuecomment-1014336394, and https://github.com/theupdateframework/python-tuf/pull/1725#issuecomment-1014431059

I reviewed all exceptions and I no longer think we currently need to add a custom MissingInformationError/MissingMetadataError. Shall we close here?


[@svelteui/core] Tabs

Tabs

component
tests
demos
docs

https://user-images.githubusercontent.com/25725586/178152505-3511aea3-9150-4f90-a46d-8a72c1efa652.mp4
Before submitting the PR, please make sure you do the following

[X] Read the Contributing guide
[X] Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
[X] This message body should clearly illustrate what problems it solves.

Tests

[X] Run the tests with npm test and lint the project with npm run lint or just run npm run repo:prepush and check to see if it's passing.

Ci failing not related to this PR changes but related to the fact that the package task in the demos package requires the package task in the preprocessors package to complete first, exploring ways of fixing this in another PR

I'm fine with CI failing until we get this released. Good job!


Move array examples one level up

This prevents Swagger UI rendering array of items example as array with array of items as described here: https://github.com/swagger-api/swagger-ui/issues/4842

This will need some more work as this seems to break Model view. Closing for now


tsconfig doesn't seem to be working

As instructed, I have this in my root BUILD:
exports_files(["tsconfig.json"])

and this in my package BUILD:

ts_library(
  name = "core",
  module_name = "material-motion",
  module_root = "src",
  srcs = glob(
    include = ["src/**/*.ts"],
    exclude = ["**/__tests__/*"],
  ),
  tsconfig = "//:tsconfig.json",
)

However, the options in my tsconfig aren't being respected.  No matter what I do, I'm getting es5 output.  Moreover, I can replace //:tsconfig.json with any garbage name, but it is silently ignored.
Here's //:tsconfig.json:
{
  "compilerOptions": {
    "declaration": true,
    "lib": [
      "es2015",
      "es2016",
      "es2017",
      "dom"
    ],
    "importHelpers": true,
    "module": "commonjs",
    "moduleResolution": "node",
    "noImplicitAny": true,
    "noImplicitThis": true,
    "sourceMap": true,
    "strictNullChecks": true,
    "target": "es2015"
  },
  "bazelOptions": {
    "googmodule": true
  }
}

You cant control --target. It should warn you about that, see https://github.com/bazelbuild/rules_typescript/issues/34
Getting other output is a concern of another rule, see the es6_output example.
Are you saying you can reference an invalid label in the tsconfig attribute and Bazel doesn't error?

Yup

okay well re-open if you figure out how to repro :)


How to add an external DB class

Hello, I have a class where connect to database, and try to figure out how to include and execute it in echoServer.
So far only as "global" i manage to make it work!
Can someone give any tip how to pass it in constructor?
Thank you

Solved :)


python.pkgs.google_cloud_storage: propagate setuptools

This is used during runtime.
cc #68314

Motivation for this change
python.pkgs.google_cloud_storage requires setuptools at runtime.
This looks like a pattern used in other parts of the google bindings aswell, so we might want to fix those too / cc @costrouc.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @costrouc

python.pkgs.google_cloud_storage requires setuptools at runtime.
This looks like a pattern used in other parts of the google bindings aswell, so we might want to fix those too

@flokli Whatever depends on google_cloud_storage that also needs setuptools will have this requirement satiated transitively because it's propagated here. So likely we won't notice it being an issue. Can we fix them all here?

hrm, it's not really inspectable.
@FRidh I wonder if we could add some script in fixup phase warning/failing on non-progated setuptools, but code like pkg_resources.declare_namespace(__name__) present.
But out of the scope for this PR.
I looked at the python google package dependencies of google_cloud_storage (only those, not all, as it's a lot), and added setuptools manually where used (it was needed everywhere).

@FRidh Thinking the same. Should be good and we could probably get them all in one go.


ARROW-11494: [Rust] fix take bench

A minor bug in the take benches lead to benchmarking with indices that were all null when there should be an array without nulls.

Perhaps we want to rerun the benches in #9301 after this is fixed.


Add pyproject.toml (and PEP 518 build system) support

Now that the Status of PEP 518 is Final, this PR adds support for pyproject.toml and switches to using poetry for dependency management, removing the old setuptools files.
I've been testing these changes locally with poetry, and things seem to be working correctly with regard to building wheels.
Adding poetry is just a nice to have for us library developers. Most end users shouldn't need to know about it - they still install via pip.

Does readthedocs work with poetry?

That's the really nice thing, I don't think it has to. readthedocs will still use pip, which if recent enough will read the pyproject.toml file and that tells it which tools (including poetry) are required to build.

Does dependabot work with it as well?

Yes

Can we make poetry manage the doc-requirements.txt as well?

Yes we can have them as optional dependencies and put them in a docs extra. Something similar to this.

I've fixed the readthedocs config. Works fine now. https://readthedocs.org/projects/blocklib/builds/13224120/


Application error in Heroku app

Perhaps you are already aware, but I just wanted to mention that https://julia-packages-app.herokuapp.com/ cannot be used, it is giving an application error.
Running the app locally, I get the interface, but I cannot find any packages.

Same thing here: running the app locally does not give any data (no packages can be found). is there a debug mode ?


x/sys/cpu: report core information and speed

What version of Go are you using (go version)?

$ go version
go version go1.11.4 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
N/A. all of them?
What did you do?
Tried to use existing packages to get information about CPU core count, clock speed, and so on. Among them, gopsutil, intel-go/cpuid, and klauspost/cpuid. They all do some of what would be desireable.
What did you expect to see?
A way to get CPU model name (if available), core counts, and ideally some kind of clock speed information.
What did you see instead?
A tangled mishmash of possibilities. I can't find anything at all on Linux that can give the CPU's officially-rated clock speed that isn't "get the brand string and parse it manually". On darwin/freebsd, gopsutil gets reasonable numbers by parsing sysctl output. On Linux, it uses something from /sys, but it gets the "max" CPU speed -- thus, for a 3.00GHz Xeon with a "max" speed of 4.00GHz, it reports 4000MHz. cpuid can accurately report on cores/threads (aka logical cores) for a single chip, but can't tell you how many chips the machine has. gopsutil can report the number of physical cores on a Mac (you would see a single CPU entry with 2 cores for a typical 2-core i5), but can't tell you about threads or logical cores. on Linux, the same machine would show 4 1-core CPUs, but if you used a map to check for unique core ID strings, you could infer that there were two distinct cores available.
This is the sort of thing where the go runtime probably already has decent insight into core count, for instance, and I think the proliferation of not-quite-working methods for getting this information is a problem. I briefly considered writing my own, but I think that would be a very bad idea. I guess I'm sort of half volunteering to implement a simple starting point for this for at least some targets, but I don't have access to a broad enough pool of targets to implement it competently for everything.
For benchmarking-type purposes, I think both logical and physical core counts (or threads/cores, depending on terminology) would be extremely valuable to developers. Clock speed(s) less so, but they can still be a handy reference point for looking at what hardware a given test was run against.

CC @randall77 @martisch for the related internal/cpu.

Oh, I forgot about this. A further note: It turns out that you can derive speed information from some recentish Intel CPUs with cpuid leaf 0x15, although I'm told that's sometimes wrong. Intel's chips provide a parseable speed in their brand string nearly-always, and Intel officially documented this as of ~2012. I don't know about the current state of parsing such things for AMD, or ARM.
It seems like something where a perfectly-reliable answer is probably impossible, but a reasonably good guess is probably possible, and the proliferation of partial and/or incomplete solutions in the wild is probably not great for the ecosystem. Speed is hard. Core count, on the other hand, whatever runtime's using for guessing NumCPU is probably a good start?

internal/cpu is just CPU ABI feature detection. It doesn't handle #cpus, #cores, clock speed, or anything like that.


Can't signin with Azure AD

Issue Type: Bug
After signin in with Azure AD I can't see anything. When trying to switch the subscription I get the following error:

Error running command azure.resource.selectsubscriptions: Failed to get credential for account Emiliano Parizzi -<EMAIL_ADDRESS>Please refresh the account.. This is likely caused by the extension that contributes azure.resource.selectsubscriptions.

Azure Data Studio version: azuredatastudio 1.25.2 (4d4917d328ab7a7526817a0f0ef03237a79aa54d, 2021-01-20T22:52:13.492Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 x 2208)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.89GB (18.58GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

admin-pack
Mic
0.0.2

agent
Mic
0.48.0

dacpac
Mic
1.6.0

import
Mic
1.2.0

kusto
Mic
0.4.0

profiler
Mic
0.11.0

vscodeintellicode
Vis
1.2.1

@ChrisSun-ms any ideas how we could troubleshoot this issue?
@empz is there a link to refresh the account credentials in the Accounts Dialog?  It sounds like there may be some invalid cached state for this account.  Was this the first time you tried adding this account?

@ChrisSun-ms any ideas how we could troubleshoot this issue?
@empz is there a link to refresh the account credentials in the Accounts Dialog?  It sounds like there may be some invalid cached state for this account.  Was this the first time you tried adding this account?

Tried refreshing, removing and re-adding the account. Used to work a while
ago, but haven't used it for a while. Now it won't no matter what I try.
On Fri, 29 Jan 2021 at 21:05, Karl Burtram<EMAIL_ADDRESS>wrote:

@ChrisSun-ms https://github.com/ChrisSun-ms any ideas how we could
troubleshoot this issue?
@empz https://github.com/empz is there a link to refresh the account
credentials in the Accounts Dialog? It sounds like there may be some
invalid cached state for this account. Was this the first time you tried
adding this account?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/azuredatastudio/issues/14108#issuecomment-770021285,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADEWSJDRMMA3V4DDHFPXQ3S4MIIRANCNFSM4WY5Y4QA
.

Tried refreshing, removing and re-adding the account. Used to work a while
ago, but haven't used it for a while. Now it won't no matter what I try.
On Fri, 29 Jan 2021 at 21:05, Karl Burtram<EMAIL_ADDRESS>wrote:

@ChrisSun-ms https://github.com/ChrisSun-ms any ideas how we could
troubleshoot this issue?
@empz https://github.com/empz is there a link to refresh the account
credentials in the Accounts Dialog? It sounds like there may be some
invalid cached state for this account. Was this the first time you tried
adding this account?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/azuredatastudio/issues/14108#issuecomment-770021285,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADEWSJDRMMA3V4DDHFPXQ3S4MIIRANCNFSM4WY5Y4QA
.

https://github.com/microsoft/azuredatastudio/issues/12637#issuecomment-754116948
can you please try this method of re-adding your account?

https://github.com/microsoft/azuredatastudio/issues/12637#issuecomment-754116948
can you please try this method of re-adding your account?

I actually just had to do a clean install of Windows for other reasons and I can no longer reproduce this issue.
It's working fine. Closing.

I actually just had to do a clean install of Windows for other reasons and I can no longer reproduce this issue.
It's working fine. Closing.


Delivery time estimation

User story #6.1: Delvery time estimation
As a receiver I want to get notified about the estimated time of the delivery of the mail.
Acceptance criteria:
The notification of estimated time should be triggered once the delivery is programmed and when in autonomous mode. (calculated using distance and speed)

This issue is out of scope due to lack of time


cmake: fails to filter options for target language

Since c55c64e242ea7f3533f3245edf604d6fe3d3953f or an earlier commit the CXX_EXCLUDED_OPTIONS variable in toolchain-specific compiler_flags.cmake is not correctly excluding options that are not accepted by the C++ compiler, causing these diagnostics on C++ code:
[19/190] Building CXX object zephyr/CMake.../zephyr.dir/subsys/cpp/cpp_vtable.cpp.obj
cc1plus: warning: '-Werror=' argument '-Werror=implicit-int' is not valid for C++
[23/190] Building CXX object zephyr/CMakeFiles/zephyr.dir/subsys/cpp/cpp_new.cpp.obj
cc1plus: warning: '-Werror=' argument '-Werror=implicit-int' is not valid for C++
[100/190] Building CXX object CMakeFiles/app.dir/src/main.cxx.obj
cc1plus: warning: '-Werror=' argument '-Werror=implicit-int' is not valid for C++
[134/190] Building CXX object modules/zxx.....__zxxpab__lib__utils.dir/now_str.cc.obj
cc1plus: warning: '-Werror=' argument '-Werror=implicit-int' is not valid for C++
[185/190] Linking CXX executable zephyr/zephyr_prebuilt.elf

set_compiler_property is too advanced for me to propose a fix, but this directive:
set_compiler_property(PROPERTY warning_error_implicit_int -Werror=implicit-int)

in cmake/compiler/gcc/compiler_flags.cmake must not be added to the C++ flag set.
Also reported at https://github.com/zephyrproject-rtos/zephyr/issues/21229#issuecomment-673154340.

I've made this a medium since it's a regression.


modify script that generates term-versions.csv to use chronometric vocab instead of DwC

I think mostly there were just a bunch of weird lines I needed to delete for the ancient DwC terms. See if this output of this works.

Ping @tucotuco


Trouble pronouncing dates

I found that the model (here: the Jenny model, but I found the same issue with ParlerTTS mini) seems to have trouble pronouncing years and numbers. For example:
"The Crusaders marched through Eastern Europe, gathering support and supplies along the way, before reaching Constantinople in 1097."
https://github.com/huggingface/parler-tts/assets/31171070/a7f4c014-c8f0-4b07-b238-dd68d386bcaa

Hey @Kredithaichen,
I'll add this to the README soon, but I just pushed a PR in the demo that shows how to correct number issues using a prompt normalizer:
https://huggingface.co/spaces/parler-tts/parler_tts_mini/commit/a07119c35ecef98bd7c016b86ff71dfdc102d8b2
Let me know if it helps!

@ylacombe Thanks for the swift response! Your changes fixed the issue for numbers in general, such that they are now clearly understandable. The model does not, however, recognize it as a year, so if I prompt:
"The Crusaders marched through Eastern Europe, gathering support and supplies along the way, before reaching Constantinople in 1397."
It says 'One-thousand three-hundred ninety-seven', rather than 'thirteen-hundred ninety-seven'. Do you happen to know of any library that could fix this or would I need to replace to replace the number outright with text in a 'historic date' style?

@Kredithaichen  just use the number to text conversion
$ pip install inflect

import inflect
p = inflect.engine()
p.number_to_words(1234567)
'one million, two hundred and thirty-four thousand, five hundred and sixty-seven'


feat: added ldap methods

Added methods for working with ldap and casdoor response deserialize extension

Hello! I updated the changes with the current API https://github.com/casdoor/casdoor/commit/666ff48837016de9c47434dec1aeb8ddbe509fc9.
Please review

@yamaritta fix CI errors:

@hsluoyz  fixed


feat: [M3-6159] - Improve Linode disk downsize error messaging

Description 📝
What does this PR do?
Increases the amount of feedback provided to users on Linode disk resize actions, particularly failed disk resizes.
Summary of changes:

Adds helper text to the LinodeDiskDrawer to provide (1) a link to documentation on disk resizing and (2) a text tooltip for command to find minimum disk size. The goal of these changes is to provide more context for the user on disk resizing limits to help mitigate a resize error in the first place.
Adds HelpIcon tooltip for disabled Add a Disk button to replace tooltip on disabled button hover to make presence of tooltip more visible to the user.
Adds HelpIcon tooltip for disabled Resize button to make the reason for disabling clearer: the Linode must be powered off. There is already a tooltip on the Delete action, but the Resize action was missing this context, requiring a user to guess why Resize was unavailable for a powered on Linode.
Adds persistent error Toast notifying user of failed disk resize. The goal of this is to provide more visible error messaging to the user when a disk cannot be resized. (Note: This was changed from an error Notice in the mocks to align with our current method of displaying failed event errors.) Previously, the only visible feedback was in the notification menu with an event message on failure of thedisk_resize action; no error message was returned on the screen itself.
Update disks_resize failure event message in notification menu/events landing to include a docs link about disk resizing. This same doc is also linked in the error Toast.
Updates tests to after moving some event message logic around and adding the ability to append text to an event message when generated.
Creates new Code component (used in "Check disk usage" text tooltip for determining minimum disk size) to apply to some styling to text that is a Linux command.

TODO: (We can start reviewing without these completed.)

[x] Finalize docs links
[ ] Finalize copy
[ ] Add GA tags

Preview 📷
Tooltips:

Disk drawer copy updates:

Error messages:

How to test 🧪
What are the steps to reproduce the issue or verify the changes?

Have at least one Linode on your account. For the purposes of verifying step 3, using a nanode is probably easiest.
Navigate to the Storage tab of the Linode Details page of a powered on Linode.
Verify that the help icon next to the disabled Add a Disk button displays a tooltip about disk space. Verify that hovering over the button no longer displays this tooltip.
Verify that the help icon next to the disabled Resize button displays a tooltip about powering down the Linode. This copy should match the tooltip copy for the Delete action.
Power down the Linode (or navigate to the details page for a different Linode that is already off).
Verify that the Resize action is no longer disabled and does not display a help icon next to it.
Click Resize and verify the copy changes and text tooltip in the Resize drawer match the internal mocks and the docs link redirects as expected.
Change the size to something that will be below the minimum size possible for the disk (e.g. 1 MB) and submit the resize.
Wait for the resize action to attempt to complete. Verify that when the resize fails, a persistent error toast displays. Verify the link in the error toast redirects to a docs page on resizing a disk.
Check the notification menu, the events landing page, and the Activity Feed tab (on the linode details page) to verify that an event displays for the resize failure and that it contains a valid docs link that also redirects to the docs page on resizing a disk.

How do I run relevant unit or e2e tests?
yarn test Event

I haven't figured out the cause, but I'm seeing a few instances where toasts that are supposed to appear are no longer appearing:

Volume <volume label> successfully attached. upon volume_attach event
Volume successfully deleted. upon volume_delete event
Image <image label> is now available. upon image_upload event

(These were all caught by tests, so there may be other toasts that are affected that I'm not aware of)
To run the impacted tests:
yarn cy:run -s "cypress/e2e/images/machine-image-upload.spec.ts,cypress/e2e/volumes/attach-volume.spec.ts,cypress/e2e/volumes/delete-volume.spec.ts"

Changes look really good, nice job on this 🚀


Adx 531 pytest migration

Moving tests of CKAN extension validation from nosetests to pytest. Majority of failing tests are skipped.

Closing this PR as a PR from a rebased branch has been opened in https://github.com/fjelltopp/ckanext-validation/pull/57

Closing this PR as a PR from a rebased branch has been opened in https://github.com/fjelltopp/ckanext-validation/pull/57


Modify PR "separate merge function" to use old and new .ini format

We reverted this PR temporarily to add some tests in: https://github.com/openghg/openghg_inversions/pull/16
Once the tests have been added, we should try to get the code from PR 16 to work with old .ini files, then re-raise the PR.

The "separate merge functionality" code has been added to eric_devel, hence to min_model_error, so this issue can be closed.


Correction breaking changes

fixes #730
FIxed the corrections mentioned on issues!
@anushbhatia Sir, you may review it! Thank you!

Resolve conflicts

Done Sir


Jcaccamo/const let update

@ldanzinger @JamesMBallard Please review when you have some time, this one is a bit long.
With support for ES6 & 7, I am updating the samples to utilize these new language features, i.e. let and const instead of var where applicable.

@JamesMBallard Should be good to go now.
I came across a few other formatting issues in the process and addressed those as well. All of them are within the confines of the var,let, and const changes.

@jared-esri let's hold on this for a few more days since there are several PRs that will get merged first, and this PR touches so many files.


README.md typo

Describe the bug
The README.md says:

vowel tests for Hangul consonants.

This seems like a typo to me.
To Reproduce
Steps to reproduce the behavior:

Read README.md

Expected behavior
Perfect writing all the time is expected.
Stack Trace
N/A
Enviornment

Chrome + github.com

OS

macOS

Additional context
N/A

Fixed README

It doesn't look fixed.

Indeed, it doesn't look fixed. I wonder what I committed then.


[Distributed] Adding external variable for distributed

What happened + What you expected to happen
fcst = DistributedMLForecast()
fcst.predict(h = 12, X_df = X_sf_test).collect()
-> TypeError: predict() got an unexpected keyword argument 'X_df'
fcst.predict(h = 12, new_df = X_sf_test).collect()
-> PythonException: An exception was thrown from a UDF: 'ValueError: The following columns are missing: ['y']'. Full traceback below:
Neither new_df (https://github.com/Nixtla/mlforecast/blob/main/mlforecast/distributed/forecast.py) nor X_df (https://nixtla.github.io/mlforecast/docs/how-to-guides/exogenous_features.html  ) seems to work for putting external variables for the distributed version of the forecasting.
Versions / Dependencies
0.10.0
Reproduction script
#from mlforecast.distributed.models.spark.lgb import SparkLGBMForecast
#models = [SparkLGBMForecast()]
from mlforecast.distributed import DistributedMLForecast
from xgboost.spark import SparkXGBRegressor
from synapse.ml.lightgbm import LightGBMRegressor
from mlforecast.distributed.models.spark.xgb import SparkXGBForecast
models = [ SparkXGBForecast() ] # SparkXGBRegressor()]  # ,
fcst = DistributedMLForecast(
models,
freq='D',
lags=[1],
lag_transforms={
1: [expanding_mean]
},
date_features=['dayofweek'],
)
fcst.fit(
Y_sf_train,
static_features=['x', 'y'],
)
fcst.predict(h = 12, X_df = X_sf_test)
Issue Severity
None

Hey @iamyihwa, thanks for using mlforecast. The 0.10.0 version takes dynamic_dfs which is a list of pandas dataframes, can you try using that?

@jmoralez  Thanks for your suggestion.
However still getting an error after using dynamic_dfs .
Also one question, which version does documentation correspond to???
2023-11-06 17:02:14,311 INFO XGBoost-PySpark: _fit Running xgboost-2.0.1 on 1 workers with
booster params: {'objective': 'reg:squarederror', 'device': 'cpu', 'nthread': 1}
train_call_kwargs_params: {'verbose_eval': True, 'num_boost_round': 100}
dmatrix_kwargs: {'nthread': 1, 'missing': nan}
2023-11-06 17:02:25,233 INFO XGBoost-PySpark: _fit Finished xgboost training!
TypeError: cannot pickle '_thread.RLock' object
Details of the error are :
/local_disk0/.ephemeral_nfs/envs/pythonEnv-14049207-8c62-4864-93a7-4bc1fb414ecc/lib/python3.8/site-packages/mlforecast/utils.py in inner(*args, **kwargs)
162                             new_args.append(kwargs.pop(arg_names[i]))
163                         new_args.append(kwargs.pop(old_name))
--> 164             return f(*new_args, **kwargs)
165
166         return inner
/local_disk0/.ephemeral_nfs/envs/pythonEnv-14049207-8c62-4864-93a7-4bc1fb414ecc/lib/python3.8/site-packages/mlforecast/distributed/forecast.py in predict(self, h, dynamic_dfs, before_predict_callback, after_predict_callback, new_df, horizon, new_data)
521             partition_results = self.partition_results
522         schema = self._get_predict_schema()
--> 523         res = fa.transform(
524             partition_results,
525             DistributedMLForecast._predict,
/local_disk0/.ephemeral_nfs/envs/pythonEnv-14049207-8c62-4864-93a7-4bc1fb414ecc/lib/python3.8/site-packages/fugue/workflow/api.py in transform(df, using, schema, params, partition, callback, ignore_errors, persist, as_local, save_path, checkpoint, engine, engine_conf, as_fugue)
140         else:
141             raise
--> 142     tdf = src.transform(
143         using=using,
144         schema=schema,
/local_disk0/.ephemeral_nfs/envs/pythonEnv-14049207-8c62-4864-93a7-4bc1fb414ecc/lib/python3.8/site-packages/fugue/workflow/workflow.py in transform(self, using, schema, params, pre_partition, ignore_errors, callback)
557         if pre_partition is None:
558             pre_partition = self.partition_spec
--> 559         df = self.workflow.transform(
560             self,
561             using=using,
/local_disk0/.ephemeral_nfs/envs/pythonEnv-14049207-8c62-4864-93a7-4bc1fb414ecc/lib/python3.8/site-packages/fugue/workflow/workflow.py in transform(self, using, schema, params, pre_partition, ignore_errors, callback, *dfs)
2036         tf._has_rpc_client = not isinstance(callback, EmptyRPCHandler)  # type: ignore
2037         tf.validate_on_compile()
-> 2038         return self.process(
2039             *dfs,
2040             using=RunTransformer,
/local_disk0/.ephemeral_nfs/envs/pythonEnv-14049207-8c62-4864-93a7-4bc1fb414ecc/lib/python3.8/site-packages/fugue/workflow/workflow.py in process(self, using, schema, params, pre_partition, *dfs)
1698         """
1699         _dfs = self._to_dfs(*dfs)
-> 1700         task = Process(
1701             len(_dfs),
1702             processor=using,
/local_disk0/.ephemeral_nfs/envs/pythonEnv-14049207-8c62-4864-93a7-4bc1fb414ecc/lib/python3.8/site-packages/fugue/workflow/_tasks.py in init(self, input_n, processor, schema, params, pre_partition, deterministic, lazy, input_names)
255     ):
256         self._processor = _to_processor(processor, schema)
--> 257         self._processor._params = ParamDict(params)
258         self._processor._partition_spec = PartitionSpec(pre_partition)
259         self._processor.validate_on_compile()
/local_disk0/.ephemeral_nfs/envs/pythonEnv-14049207-8c62-4864-93a7-4bc1fb414ecc/lib/python3.8/site-packages/triad/collections/dict.py in init(self, data, deep)
175     def init(self, data: Any = None, deep: bool = True):
176         super().init()
--> 177         self.update(data, deep=deep)
178
179     def setitem(  # type: ignore
/local_disk0/.ephemeral_nfs/envs/pythonEnv-14049207-8c62-4864-93a7-4bc1fb414ecc/lib/python3.8/site-packages/triad/collections/dict.py in update(self, other, on_dup, deep)
262         for k, v in to_kv_iterable(other):
263             if on_dup == ParamDict.OVERWRITE or k not in self:
--> 264                 self[k] = copy.deepcopy(v) if deep else v
265             elif on_dup == ParamDict.THROW:
266                 raise KeyError(f"{k} exists in dict")
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
144     copier = _deepcopy_dispatch.get(cls)
145     if copier is not None:
--> 146         y = copier(x, memo)
147     else:
148         if issubclass(cls, type):
/usr/lib/python3.8/copy.py in _deepcopy_dict(x, memo, deepcopy)
228     memo[id(x)] = y
229     for key, value in x.items():
--> 230         y[deepcopy(key, memo)] = deepcopy(value, memo)
231     return y
232 d[dict] = _deepcopy_dict
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
170                     y = x
171                 else:
--> 172                     y = _reconstruct(x, memo, *rv)
173
174     # If is its own copy, don't memoize.
/usr/lib/python3.8/copy.py in _reconstruct(x, memo, func, args, state, listiter, dictiter, deepcopy)
268     if state is not None:
269         if deep:
--> 270             state = deepcopy(state, memo)
271         if hasattr(y, 'setstate'):
272             y.setstate(state)
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
144     copier = _deepcopy_dispatch.get(cls)
145     if copier is not None:
--> 146         y = copier(x, memo)
147     else:
148         if issubclass(cls, type):
/usr/lib/python3.8/copy.py in _deepcopy_dict(x, memo, deepcopy)
228     memo[id(x)] = y
229     for key, value in x.items():
--> 230         y[deepcopy(key, memo)] = deepcopy(value, memo)
231     return y
232 d[dict] = _deepcopy_dict
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
170                     y = x
171                 else:
--> 172                     y = _reconstruct(x, memo, *rv)
173
174     # If is its own copy, don't memoize.
/usr/lib/python3.8/copy.py in _reconstruct(x, memo, func, args, state, listiter, dictiter, deepcopy)
268     if state is not None:
269         if deep:
--> 270             state = deepcopy(state, memo)
271         if hasattr(y, 'setstate'):
272             y.setstate(state)
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
144     copier = _deepcopy_dispatch.get(cls)
145     if copier is not None:
--> 146         y = copier(x, memo)
147     else:
148         if issubclass(cls, type):
/usr/lib/python3.8/copy.py in _deepcopy_dict(x, memo, deepcopy)
228     memo[id(x)] = y
229     for key, value in x.items():
--> 230         y[deepcopy(key, memo)] = deepcopy(value, memo)
231     return y
232 d[dict] = _deepcopy_dict
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
170                     y = x
171                 else:
--> 172                     y = _reconstruct(x, memo, *rv)
173
174     # If is its own copy, don't memoize.
/usr/lib/python3.8/copy.py in _reconstruct(x, memo, func, args, state, listiter, dictiter, deepcopy)
268     if state is not None:
269         if deep:
--> 270             state = deepcopy(state, memo)
271         if hasattr(y, 'setstate'):
272             y.setstate(state)
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
144     copier = _deepcopy_dispatch.get(cls)
145     if copier is not None:
--> 146         y = copier(x, memo)
147     else:
148         if issubclass(cls, type):
/usr/lib/python3.8/copy.py in _deepcopy_dict(x, memo, deepcopy)
228     memo[id(x)] = y
229     for key, value in x.items():
--> 230         y[deepcopy(key, memo)] = deepcopy(value, memo)
231     return y
232 d[dict] = _deepcopy_dict
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
170                     y = x
171                 else:
--> 172                     y = _reconstruct(x, memo, *rv)
173
174     # If is its own copy, don't memoize.
/usr/lib/python3.8/copy.py in _reconstruct(x, memo, func, args, state, listiter, dictiter, deepcopy)
268     if state is not None:
269         if deep:
--> 270             state = deepcopy(state, memo)
271         if hasattr(y, 'setstate'):
272             y.setstate(state)
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
144     copier = _deepcopy_dispatch.get(cls)
145     if copier is not None:
--> 146         y = copier(x, memo)
147     else:
148         if issubclass(cls, type):
/usr/lib/python3.8/copy.py in _deepcopy_dict(x, memo, deepcopy)
228     memo[id(x)] = y
229     for key, value in x.items():
--> 230         y[deepcopy(key, memo)] = deepcopy(value, memo)
231     return y
232 d[dict] = _deepcopy_dict
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
170                     y = x
171                 else:
--> 172                     y = _reconstruct(x, memo, *rv)
173
174     # If is its own copy, don't memoize.
/usr/lib/python3.8/copy.py in _reconstruct(x, memo, func, args, state, listiter, dictiter, deepcopy)
268     if state is not None:
269         if deep:
--> 270             state = deepcopy(state, memo)
271         if hasattr(y, 'setstate'):
272             y.setstate(state)
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
144     copier = _deepcopy_dispatch.get(cls)
145     if copier is not None:
--> 146         y = copier(x, memo)
147     else:
148         if issubclass(cls, type):
/usr/lib/python3.8/copy.py in _deepcopy_dict(x, memo, deepcopy)
228     memo[id(x)] = y
229     for key, value in x.items():
--> 230         y[deepcopy(key, memo)] = deepcopy(value, memo)
231     return y
232 d[dict] = _deepcopy_dict
/usr/lib/python3.8/copy.py in deepcopy(x, memo, _nil)
159                     reductor = getattr(x, "reduce_ex", None)
160                     if reductor is not None:
--> 161                         rv = reductor(4)
162                     else:
163                         reductor = getattr(x, "reduce", None)

Can you provide the command you're running? Please note that the dynamic dfs should be pandas dataframes, not spark.
Also this possibility will be removed in 0.11.0, which will be released in the next couple of days and is the version of the documentation. Can you describe your use case? The distributed interface is meant for training only, with the assumption that once that you've trained the model you can convert it to a local version and compute predictions with that. Would that work for you?

I am using the command  fcst.predict(h = 12, dynamic_dfs  =  X_df).collect()
Thanks for explaining what it will be in the future.
For my usecase, it would be fine to pass in Pandas Dataframe.
I am expecting much faster compute with the distributed spark version.
(By the way, non spark version seems also to be pretty fast, but I guess with much larger dataset there will be a big difference?  )
Yes, initially I gave the spark dataframe, but now I changed to the pandas, but getting a different error.
from mlforecast.distributed import DistributedMLForecast
from mlforecast.distributed.models.spark.xgb import SparkXGBForecast
models = [ SparkXGBForecast() ]
fcst = DistributedMLForecast(
models,
freq='W-SAT',
lags=[1],
lag_transforms={
1: [expanding_mean]
},
target_transforms = [Mean_Scaler()],
date_features=['dayofweek'],
)
fcst.fit(
Y_sf_train_cur_level,
static_features=['embedding_x', 'embedding_y'],
)
fcst.predict(h = 12, dynamic_dfs  =  X_df).collect()
X_df is pandas dataframe.
predict() got an unexpected keyword argument 'dynamic_dfs'
2023-11-07 08:15:33,616 INFO XGBoost-PySpark: _fit Finished xgboost training!
TypeError: predict() got an unexpected keyword argument 'dynamic_dfs'
TypeError                                 Traceback (most recent call last)
 in
22     static_features=['embedding_x', 'embedding_y'],
23 )
---> 24 fcst.predict(h = 12, dynamic_dfs  =  X_df).collect()
25 ## Currently not possible to get the X variable to work for the spark version
TypeError: predict() got an unexpected keyword argument 'dynamic_dfs'

Are you still on 0.10.0? We released 0.11.0 yesterday and that removed the dynamic_dfs argument. Also, it should be a list, e.g. fcst.predict(h = 12, dynamic_dfs = [X_df]).collect().
About the speed, the models use multithreading when predicting and we also have multithreading for the feature updates, so if the data fits in one machine it's probably better to just use the regular interface. Also, 0.11.0 includes support for using lag transformations implemented in C++, which should be way faster for the predict step (guide).
Please let us know if this works, sorry for the troubles.

@jmoralez  Yes I noticed the version has been upgraded!
Thanks for the great work!!
If you say that dynamic_dfs have been reserved, how can I add non-static external variables for the distributed version??
Sorry to mix the post with different library, but in neuralforecast, external variables aren't supported either??

It's not possible anymore because supporting distributed dataframes as X_df is very hard and passing pandas seemed like overkill, but if that works for you I think we could add the possibility of passing X_df as a pandas dataframe to the distributed version, which would then be broadcasted to all workers and each would use their corresponding series.
Neuralforecast does support external variables (guide).

@jmoralez  Sure it would be great to have the opportunity to add external variables to the distributed version!
What would it mean though that we pass in pandas dataframe? Would I need to add additional steps to make the distributed version of the model work??

Neuralforecast does support external variables (guide).
This link seems to be not working anymore .. I saw lots of updates in the webpage.
Perhaps is it this one, in the newer version?
Cool that there are lots of different exogeneous variable types one can add!

@jmoralez
We encountered a specific scenario where we actively utilized the 'dynamic_dfs' argument in MLForecast. Our use case involves building multi-regressor time-series models, specifically a recursive XGBoost model. We predict one primary y feature, a date column, and two additional regressor columns.
In our approach, we apply lags and lag-transforms to both the primary y column and the additional regressor columns, along with various date features. However, we observed that MLForecast doesn't recursively predict the additional regressors. Consequently, we opted to predict them separately, utilized preprocessing to obtain lagged/transformed values of these newly predicted columns, and then incorporated them into the main forecast model using 'dynamic_dfs'. This ensures their use as time-based external regressors when predicting the primary y.
Given the removal of the 'dynamic_dfs' argument, are there alternative features or methods within MLForecast that could still support our specific use case? Any insights you can provide would be greatly appreciated.

Hey @Markpajr. For the local interface the dynamic_dfs argument was deprecated in favor of the X_df argument, which takes a single dataframe with the ids, dates and future values of the exogenous features. So if you were using a single dataframe like dynamic_dfs=[df] you can now use X_df=df. Also we recently incorporated a function to compute the transformations on exogenous features, you may find this guide useful, since it seems to be what you're currently doing.


Clarify paths in SimulateArgs

Improve documentation, add a way to specify a path but have it be some default value.

Complete as of fd955ff7f278b40c974def5f133856332926d00c


Dilumaluthge forks massinstallaction/set up ci

Codecov Report

Merging #2 (5db5119) into master (72da2d5) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   97.48%   97.76%   +0.27%
==========================================
  Files           1        1
  Lines         159      134      -25
==========================================
- Hits          155      131      -24
+ Misses          4        3       -1

Impacted Files
Coverage Δ

src/MLJXGBoostInterface.jl
97.76% <0.00%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72da2d5...5db5119. Read the comment docs.


How do I revert deta new?

While running deta new, it errored out

Now I can't even revert it since I could not find any command to do so

oh nevermind, we can go and delete it from the web.deta.sh


Refactor target disambiguation in preparation of target consolidation

Yeah, that makes sense. I'll have a couple commits in the next PR instead, that should be reviewed on their own.


Bug: Chart group not visible with specific chart group permission

📜 Description
Chart group not visible with specific chart group option
👟 Reproduction steps
-Create a chart group
-User should access for specific chart group

Try to create or update chart group

👍 Expected behavior
If user having edit option for specific chart group then user can edit and update the specific chart
👎 Actual Behavior
while user editing option for specific chart group then user unable to edit and update the specific chart
☸ Kubernetes version
microk8s:2.6
Cloud provider
Azure
🌍 Browser
Chrome
🧱 Your Environment
QA
✅ Proposed Solution
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#3469

closed in
OSS PR: https://github.com/devtron-labs/devtron/pull/3962
Dashboard PR: https://github.com/devtron-labs/dashboard/pull/1315

closed in
OSS PR: https://github.com/devtron-labs/devtron/pull/3962
Dashboard PR: https://github.com/devtron-labs/dashboard/pull/1315


Remove a misused rocksdb ticker

The TickerType::NoIterators is actually used as a Guage in
RocksDB. When we require an iterator, the ticker increase 1, and when
we release the iterator, the ticker decrease 1. So if we reset the
ticker after we have required an iterator but before we have released
it, the ticker can be negative. Since we don't care about this ticker
yet, I just remove it here.

LGTM

/run-integration-tests


added easy_config

See Discussion in #190.
Unfortunately, i have been only able to test this on a 1136 × 640 Display.
However, this script does not use any "magic numbers", so it should work fine on all screen sizes.
Maybe someone can test this?
I was also not able to find a way to automatically add an editor shortcut.
This does not (yet) replace stashconf, because stashconf is a simple way to temporary change the config. Should i rename easy_config to replace stashconf?
Also, the [display] BACKGROUND_COLOR-option seems to be broken. The background-color is set correctly whenever StaSh is started, but whenever new text is printed, it will have a black background-color.
EDIT: Why does the CI-Build fail? I have not changed anything in the threading-system in this commit and the command i have added is not even being tested in the tests. Did i broke something in some previous commits?

I think the CI build sometimes (rarely) fails due to the somewhat badly written test cases for multiple background jobs (my fault). Something to fix later ...
The background color issue is due to the use of attributed text. Each character can have its own background color which is by default set to black (code in shscreens.py). It would be great if all the colors used for them are configurable as well. But that's quite a big task that requires some level of re-design for the color systems.
Otherwise, the new script works great. Thanks a lot for your effort.

@jsbain developed an editor action script and is available here https://gist.github.com/jsbain/c9f42c81c53b276b6560

@ywangd thanks for the feedback and the link. i will try to add this and then open another pull-request. Thanks!


add offset to item_list_children

If you have more than 1000 children, this function becomes useless (unless there's a trick I'm missing). The query_items seems to support an offset.

No, you're probably right. item_list_children is limited to 1000 as it doesn't do paging.
query_sb does automatic paging for you so you can exceed 1000 limit.
query_sb(list(parentId=user_id()), limit=2000)
limit can be as as large a number as you're willing to wait for, though paging is limited to 1k blocks, so 100k items would take 100 round trips to SB.

I'm going to edit this. Really, item_list_children should just leverage query_sb.


Provide a nicer error when roc is provided a binary file

Currently we get:
❯ ./target/release/roc build /home/username/gitrepos/basic-cli/examples/tcp-client
── MISSING HEADER ────── /home/username/gitrepos/basic-cli/examples/tcp-client ─

I am expecting a header, but got stuck here:

1│  ELF>��@�^}@8@3/@@@�TT�������������������������0�C0�C�e+�e+�e+��
                                                                   ��
                                                                     �c3�c3�c3Phhh ���  �e+�e+�e+HS�tdhhh P�td\��\��\����       ��      Q�tdR�td�e+�e+�e+�z
                 �z
                   �K|�K>�K>��@M|@M>@M>@M|<EMAIL_ADDRESS>    ^

I am expecting a module keyword next, one of interface, app, package
or platform.

If you're not sure where you should make changes, try using the cursor.so editor and ask it for example: "I want to print an error when a binary file is provided to the CLI, where should I add code?"


Add internal IRT implementation of execv()/execve()

Add execv() and execve() system call implementations to the internal runtime.
Implementation Details:

Copy the argument and environment vectors from the "parent" NaClApp.
Duplicate its cage_id along with any other relevant internal state.
Leverage the existing fork() implementation to emulate replacement of the entire process image.

Thank you for the quick review, merged.


Add some unittests

I'll add some unittests to this branch aiming at increased coverage

Current coverage is 86.95% (diff: 100%)

Merging #117 into master will increase coverage by 0.09%

@@             master       #117   diff @@
==========================================
  Files             5          5
  Lines          2078       2078
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1805       1807     +2
+ Misses          273        271     -2
  Partials          0          0

Powered by Codecov. Last update 8ac344d...1fa5b02


🙏 [Help Wanted] Clean up deprecations

The Backstage CLI providers the repo list-deprecations command to list all usages of deprecated symbols. We have a lot of these in the main repo, and would like to clean them up. I think this is a good first issue for anyone that wants to get involved in the project and help out.
Steps

Run the following command in the project root:

yarn backstage-cli repo list-deprecations

You will not get a long list of deprecated usages, looking something like this:

...
packages/backend-common/src/reading/index.ts:19:10 - 'BitbucketUrlReader' is deprecated. in favor of BitbucketCloudUrlReader and BitbucketServerUrlReader
packages/backend-common/src/reading/index.ts:19:10 - 'BitbucketUrlReader' is deprecated. in favor of BitbucketCloudUrlReader and BitbucketServerUrlReader
...

Pick a couple of related deprecations to fix, not too many at once, but be sure to for example fix all deprecations in a single file at the same time. Generally the deprecation message should provide guidance for how to migrate. If that's not the case, please chime in this issue so that we can help clarify an perhaps improve the deprecation message.

Hello Rugvip I wanted to learn contribute opensource!
I will try to learn and make reserach for it.
Can you help me with this. It's my first contribution to real life project

@Kd-Here of course! You can find our documentation for how to get started as a contributor over here, and more general contribution docs over here. Let me know if there's anything specific. 👍

Hello! I also would like to contribute to this issue! Is it possible to split it into categories based on what folder the deprecation is in (for example taking all backend-common)? Or do you want all deprecation complete in one PR?

Another question: Are you supposed to fix deprecations in deprecated files? For example BitBucketUrlReader is not used anymore because of BitBucketCloudReader. In the BitBucketUrlReader test one should use instead BitBucketCloudReader which kinda defeats its purpose. Should you fix the deprecation or just straight up delete the file because it is not used anymore?

@Kd-Here of course! You can find our documentation for how to get started as a contributor over here, and more general contribution docs over here. Let me know if there's anything specific. 👍

Hey Rugvip thanks for your kind help.
After reading from backstage docs I found I am too noob for such great project.
I tried my best to install backstage but still could not do. I would love to contribute with you is there something begineer task for CS student.

There are quite a few deprecations that show up using that command. Using yarn backstage-cli repo list-deprecations | wc -l 783
I would like to point out one in particular though. The auth provider for Auth0 is no longer in the code base. It is still shown in the microsite here: https://backstage.io/docs/auth/auth0/provider but the 'auth0AuthApi' export no longer exists and is documented as deprecated almost a year ago: https://backstage.io/docs/api/deprecations#generic-auth-api-refs
I have not been able to use the example code correctly though. Wondering how we can handle the microsite side of things (just link to the deprecation page for Auth0 as a provider?)

Is it possible to split it into categories based on what folder the deprecation is in (for example taking all backend-common)? Or do you want all deprecation complete in one PR?

Definitely not all deprecations in a single PR, there's way too many! Anything else goes though, but if there's a particularly tricky one it can be best to send a small PR for just that individual one, and perhaps highlight the ongoing work here.

The auth provider for Auth0 is no longer in the code base.

Indeed! That entire documentation section can probably be removed, just gotta double check if something needs to be moved over to https://backstage.io/docs/auth/oidc. It's a bit outside the scope of this issue though perhaps, but happy if you want to help out with that!

I would love to contribute with you is there something begineer task for CS student.

Don't give up trying to set the project up! You can also try smaller, simpler projects from scratch, like setting one up a separate instance with npx @backstage/create-app, or just a plain React app with npx create-react-app. If you encounter errors you can try to figure out the cause through Google or search Stackoverflow. Give it a bit of time before you ask for help, CS is often about bashing your head against the same problems for hours on end before you figure things out. I'd also recommend watching video tutorials that guide you through the complete project setups, or blog posts if you prefer written content.

@Rugvip Cool, I'll send in a PR with the work I've done today or tomorrow. I've been working top down ignoring some of the deprecations that did not provide an alternative solution

I've created a PR now, it is the first time I'm creating a PR contributing to backstage so it might be a bit of a mess. But I've understood the guidelines now.
@Rugvip Do you want me to continue push updates to the PR or should it be reviewed? I've only done about 10 out of the many listings so there are a lot more to be done.
Some comments I have trying to migrate is that like I stated previously, should deprecated files be left alone without migrating?
For example changing the BitBuckerURLReader tests to BitbucketCloudUrlReader is not that productive.
packages/backend-common/src/reading/BitbucketUrlReader.test.ts:60:20 - 'BitbucketUrlReader' is deprecated. in favor of BitbucketCloudUrlReader and BitbucketServerUrlReader

Also, there are a lot of deprecations that has no migrating solution. For example
packages/core-app-api/src/app/AppThemeProvider.tsx:61:16 - 'addListener' is deprecated.

Should they just be ignored?

@Znarvl thank you, and no worries!
It's best to leave the existing PR for review. If you want to continue with more fixes then it's best to ship that in a separate PR. Otherwise there's a risk that the PR gets stuck in never ending review.
Yep any code that is directly related to a deprecated symbol can be left alone, such as the BitBuckerURLReader example.
I believe there's a migration solution for addListener, just that it's not documented as part of the deprecation (it's not ours :grin:). If it's unclear what to do then I'd say go ahead and skip. In this case I believe it needs to be migrated to addEventListener.

Alright thanks for the answer! I'll fix the PR then and continue working on other deprecations

I will be working on fixing the deprecations in the packages/core-components/src/layout/ directory.

Hi! I also want to help, I will work in plugins/catalog-backend directory.

I will help out, starting with plugins/cost-insights.

@Znarvl please continue! I only have one commit with 6 files changed.

Big thank you to everyone that has been helping out so far! 🚀
I wanted to highlight something that's been a somewhat common confusion, which is that we don't want to remove the deprecated symbols themselves, including any re-exports of them and so on. There are also cases where a deprecated symbol depends on another deprecated symbol, in which case there's no need to change the usage. The main guideline here is that we don't want the public API of any of the packages to change at this point. When running yarn build:api-reports there should be no changes to any of the api-report.md files.


[StyleCop] Fix all the warnings on TestBot

Fix spacing
Fix methods parameters
Add trailing comma

Promoted to MS # 1453


question about aggregation

Hi， @gmberton @ga1i13o
I wonder that If I don't want to use any aggregation in the program and only want to use the features output by Backbone as image representation for matching, how should I modify it? What suggestions do you have for not using the aggregation?

Hi, that depends on if you want to use the features taken before the global average pooling or after:

if you want to take them before the global average pooling you can replace the aggregation with a simple Flatten. So basically you can comment the lines defining the aggregation (between here and here) and you can simply set self.aggregation = Flatten(). Note that those features are quite heavy, as they have dimension CxHxW, and the Flatten will reshape them into a single array.

or perhaps you want to take the features after the global average pooling (as most CNNs end with a global average pooling). If you need this, you can simply pass --aggregation=spoc. Note that SPOC is essentially the same as an average pooling, and it will make the CxHxW features into a C-dimensional array. You can also remove the L2 normalization by setting --l2=none, or set it before or after the pooling with l2=before_pool or l2=after_pool.


Fix race in resource delete

Short description:

client_wait_deleted now returns bool
wait_deleted now returns bool
in resource delete: moving the get hashed_data under try/except.

Reason:
When the object is in Terminating state, it passes the check if self.exists:, but then NotFoundError gets raised on (resource_dict=self.instance... because the object is already gone.
For example, when we delete a DV, PVC gets deleted automatically.
When some automation attempts to create a DV twice, and then attempts to delete this DV twice, we may hit this race.

/verified

/verified

/cherry-pick v4.16

/cherry-pick v4.15

Cherry-picked PR Fix race in resource delete into v4.16

Manual cherry-pick is needed
Cherry pick failed for 60d585cdf63291112dcaf3a06b00507ee13caffc to v4.15:
To cherry-pick run:
git remote update
git checkout v4.15
git pull origin v4.15
git checkout -b fix_race_in_delete-v4.15
git cherry-pick 60d585cdf63291112dcaf3a06b00507ee13caffc
git push origin fix_race_in_delete-v4.15

/cherry-pick v4.14

Manual cherry-pick is needed
Cherry pick failed for 60d585cdf63291112dcaf3a06b00507ee13caffc to v4.14:
To cherry-pick run:
git remote update
git checkout v4.14
git pull origin v4.14
git checkout -b fix_race_in_delete-v4.14
git cherry-pick 60d585cdf63291112dcaf3a06b00507ee13caffc
git push origin fix_race_in_delete-v4.14


Drum machine: drum-machine set up

Hello,
The app has the following features,

Power on/off button.
Display, for displaying the type sound being played,
Buttons thats can be activated by clicking or by hitting the corresponding letters on the keyboard.

There is a button on the top left side of the app for the FCC test suit.

It was fun doing the project.


Extra scrollbars in SQL lab

Screenshot

Description
Unnecessary scrollbar
Design input
Please remove them.
cc @yousoph

cc @AAfghahi

THis gets fixed in https://github.com/apache/superset/pull/14381


puppet-vmwaretools creates blank file at /etc/yum.repos.d/vmware-tools.repo, and everything afterwards fails

I just installed and used this module for the first time. However, it fails immediately after Puppet modifies  /etc/yum.repos.d/vmware-tools.repo  for the first time.
We're using Puppet OSS 3.8 on Scientific Linux release 6.6 (A clone of RHEL/CentOS 6).
My class calls this module with a very basic include:
include ::vmwaretools

However, in the end, this module creates a blank file for the VMware Tools repository, and thus every command afterwards fails:
[root@dev1 ~]# ll /etc/yum.repos.d/vmware*
-rw-r--r-- 1 root root 317 Aug  3 10:51 /etc/yum.repos.d/vmware.repo
-rw-r--r-- 1 root root   0 Aug  3 10:51 /etc/yum.repos.d/vmware-tools.repo
[root@dev1 ~]#

The command fails immediately after Notice: /Stage[main]/Vmwaretools::Repo/Yumrepo[vmware-tools]/protect: defined 'protect' as '0'.
Here's a log showing the command execution:
[root@dev1 ~]# puppet agent --test
Info: Retrieving pluginfacts
Info: Retrieving plugin
Notice: /File[/var/lib/puppet/lib/facter/vmware.rb]/ensure: defined content as '{md5}fdf0c987ebc1d390d4e2da3d914469a3'
Notice: /File[/var/lib/puppet/lib/puppet/type/zypprepo.rb]/ensure: defined content as '{md5}81f249c4403b0bc1228896da6041eabc'
Info: Loading facts
Info: Loading facts
Info: Caching catalog for dev1.example.org
Info: Applying configuration version '1470246658'
admin'
Notice: /Stage[main]/Vmwaretools::Repo/Yumrepo[vmware-tools]/descr: descr changed 'VMware Tools for Red Hat Enterprise Linux $releasever - $basearch' to 'VMw
are Tools latest - rhel6 x86_64'
Notice: /Stage[main]/Vmwaretools::Repo/Yumrepo[vmware-tools]/baseurl: baseurl changed 'http://packages.vmware.com/tools/esx/latest/rhel6/$basearch' to 'http:
//packages.vmware.com/tools/esx/latest/rhel6/x86_64/'
Notice: /Stage[main]/Vmwaretools::Repo/Yumrepo[vmware-tools]/gpgkey: gpgkey changed 'http://packages.vmware.com/tools/keys/VMWARE-PACKAGING-GPG-RSA-KEY.pub'
to 'http://packages.vmware.com/tools/keys/VMWARE-PACKAGING-GPG-DSA-KEY.pub
    http://packages.vmware.com/tools/keys/VMWARE-PACKAGING-GPG-RSA-KEY.pub'
Notice: /Stage[main]/Vmwaretools::Repo/Yumrepo[vmware-tools]/protect: defined 'protect' as '0'
Notice: /Stage[main]/Vmwaretools::Repo/Yumrepo[vmware-tools]/priority: defined 'priority' as '50'
Notice: /Stage[main]/Vmwaretools::Repo/File[/etc/yum.repos.d/vmware-tools.repo]/ensure: created

Error: Execution of '/usr/bin/yum -d 0 -e 0 -y install vmware-tools-esx-kmods' returned 1: Error Downloading Packages:
  vmware-tools-esx-kmods-9.0.17-1.el6.x86_64: failure: vmware-tools-esx-kmods-9.0.17-1.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  vmware-tools-vmxnet-common-9.0.17-5.el6.x86_64: failure: vmware-tools-vmxnet-common-9.0.17-5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  kmod-vmware-tools-vmxnet-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64: failure: kmod-vmware-tools-vmxnet-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  vmware-tools-vmci-common-9.0.17-5.el6.x86_64: failure: vmware-tools-vmci-common-9.0.17-5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  kmod-vmware-tools-vsock-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64: failure: kmod-vmware-tools-vsock-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  vmware-tools-vsock-common-9.0.17-5.el6.x86_64: failure: vmware-tools-vsock-common-9.0.17-5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  kmod-vmware-tools-vmci-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64: failure: kmod-vmware-tools-vmci-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
Error: /Stage[main]/Vmwaretools/Package[vmware-tools-esx-kmods]/ensure: change from absent to present failed: Execution of '/usr/bin/yum -d 0 -e 0 -y install vmware-tools-esx-kmods' returned 1: Error Downloading Packages:
  vmware-tools-esx-kmods-9.0.17-1.el6.x86_64: failure: vmware-tools-esx-kmods-9.0.17-1.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  vmware-tools-vmxnet-common-9.0.17-5.el6.x86_64: failure: vmware-tools-vmxnet-common-9.0.17-5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  kmod-vmware-tools-vmxnet-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64: failure: kmod-vmware-tools-vmxnet-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  vmware-tools-vmci-common-9.0.17-5.el6.x86_64: failure: vmware-tools-vmci-common-9.0.17-5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  kmod-vmware-tools-vsock-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64: failure: kmod-vmware-tools-vsock-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  vmware-tools-vsock-common-9.0.17-5.el6.x86_64: failure: vmware-tools-vsock-common-9.0.17-5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
  kmod-vmware-tools-vmci-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64: failure: kmod-vmware-tools-vmci-<IP_ADDRESS>-<IP_ADDRESS>.el6.x86_64.5.el6.x86_64.rpm from vmware-tools: [Errno 256] No more mirrors to try.
Notice: /Stage[main]/Vmwaretools/File_line[disable-tools-version]: Dependency Package[vmware-tools-esx-kmods] has failures: true
Warning: /Stage[main]/Vmwaretools/File_line[disable-tools-version]: Skipping because of failed dependencies
Notice: /Stage[main]/Vmwaretools/Service[vmware-tools-services]: Dependency Package[vmware-tools-esx-kmods] has failures: true
Warning: /Stage[main]/Vmwaretools/Service[vmware-tools-services]: Skipping because of failed dependencies
Notice: /Stage[main]/Vmwaretools/File[/etc/udev/rules.d/99-vmware-scsi-udev.rules]: Dependency Package[vmware-tools-esx-kmods] has failures: true
Warning: /Stage[main]/Vmwaretools/File[/etc/udev/rules.d/99-vmware-scsi-udev.rules]: Skipping because of failed dependencies
Notice: /Stage[main]/Vmwaretools/Exec[udevrefresh]: Dependency Package[vmware-tools-esx-kmods] has failures: true
Warning: /Stage[main]/Vmwaretools/Exec[udevrefresh]: Skipping because of failed dependencies
Notice: Finished catalog run in 69.06 seconds
[root@dev1 ~]#

Oh... nevermind. That file, /etc/yum.repos.d/vmware.repo was actually installed by something else. It wasn't mentioned in any of our manifests, and I assumed it came from razorsedge/puppet-vmwaretools. Sorry for the noise!


Parent Application Opening

Is it possible that we can open the parent application from the shield.
i have a functionality that when the user click on the primary button on shield action extension it opens the parent app(App who has installed the restrcition on another app).
same thing is happenin in jomo app. @NoodleOfDeath

but how jomo app is doing then? any rough idea.
they are creating a perfect scenario.

interesting. you're right. i'll have to dig into that a bit more 🤔

let me know if you find anything.

it seems jomo might be using the private api which os surprising Apple doesn't reject the app

give this a shot... in your ShieldAction. You also need to add your URL scheme to your Info.plist and handle for all three delegate methods not just for app token
override func handle(action: ShieldAction, for application: ApplicationToken, completionHandler: @escaping (ShieldActionResponse) -> Void) {
    // Handle the action as needed.
    switch action {
    case .primaryButtonPressed:
      completionHandler(.close)
    case .secondaryButtonPressed:
      if let url = URL(string: "drunkmode://") {
        let context = NSExtensionContext()
        context.open(url) { _ in
          completionHandler(.defer)
        }
      }
    @unknown default:
      fatalError()
    }
  }

have you tried it? its not working on my side.
@NoodleOfDeath

have you searched it out more or have you done the testing on code you shared?
becuase its not opening the parent(Host) application on triggering the secondary button.
@NoodleOfDeath

So I have tried doing quite a bit more research and it's practically impossible to find a way for this to work natively so far

i want to get the screen time used.

i want to get the screen time used.

Uh. are you having issues making the library features work? or are you having issues with this particular "feature" why seems  to only be achieveable by using non public methods


Fix PlanetShine

Fixes #2705

Thank you @Olympic1
This pull request does not have a reason to exist anymore, I'm closing it.

Thank you for that, I didn't know it could use the ksp-avc version file automatically, that's great!

Well it is easier for us to let the author choose what version is compatible with which KSP version.

I guess I can also remove the "x_netkan_override" section too?

No, overrides are usefull if an users wants to play an earlier version of KSP so that CKAN knows which mod version is compatible with that KSP version.

this is exactly the same information that I provide in the version file

But CKAN only knows about that version file when this gets merged, so on earlier versions it technically doesn't exist

Ok, so I will do a pull request to remove it later I guess, right?
When do you think this will get merged? Because I might release a new version soon actually.

Well, the "rule" is that a change needs to be looked over by a human to verify the changes

Yes of course.
But my point is that now that the version checking will be entirely automated with data from kerbalstuff + the version file, I should not need to bother you anymore with pull requests for the future versions.
What bothers me is that the x_netkan_override requires to be edited for each new released version of PlanetShine.
Or maybe there is something that I didn't understand.

Basically what an override stanza does is to override things of a mod's version. You have five variants for this, I'll use v<IP_ADDRESS> as an example:

Override everything before v<IP_ADDRESS>
Override everything before and equal to v<IP_ADDRESS>
Override a specific version, so only change things for v<IP_ADDRESS>
Override everything after and equal to v<IP_ADDRESS>
Override everything after v<IP_ADDRESS>

So in this case it will override a specific version (v<IP_ADDRESS>) and says to CKAN to override the max KSP version of v<IP_ADDRESS> from 1.0.2 to 1.0.4

Ok I see, thank you.


Spanish translation improved and completed

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Fixed issues

Please change your translations by adopting the unique genre in user, always in the masculine.
This is the default in any application.

Please change your translations by adopting the unique genre in user, always in the masculine.
This is the default in any application.

I'm very happy having the translations with both genres. Maybe another user want to do it.

The travis checks are failing becouse of some outdated dependences in the composer.
Is this project being maintained?

This project is not being actively maintained and there is no one officially offering support or help.
Only PRs are being evaluated (there is no deadline for evaluation).
Read more here: #903

☝


Gzip encoding

It would save a lot of bandwidth (I'm seeing ~20x reductions in content-length) if the Jersey client was configured to gzip the entity bodies. Doing that is straightforward enough (I can open a PR any time), but perhaps it should be configurable.
What do you think?

Gzip compression is now a configurable option.
Thanks for the suggestion and apologies on the latency!


feat: add Chembench corpus table

Suggested by @kjappelbaum similar to the one in https://www.arxiv.org/pdf/2407.16931.
Maybe it needs to be moved, the format corrected and the caption enhanced but I would like to know the thought on this first draft @lamalab-org/chem-bench

Should I move this as well to #38? @kjappelbaum

I think there is no need to move it :) I merged this big thing and now it should only be small edits :)


Relax pydantic constraint for client

Pull Request Summary
What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.
Upping pydantic requirement is proving problematic when rolling out. Will relax the requirement and autogenerate v1 compatible objects instead
Also, add client methods for getting and cancelling batch completions
Test Plan and Usage Guide
How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.

what's the error when rollout?

what's the error when rollout?

Was testing the prior client out with some users and we ran into issues w/ some of their code still being on Pydantic v1. To facilitate migration, I decided to just update the client to also be pydantic v1 compatible, even though we really should move everyone off

what's the error when rollout?

Was testing the prior client out with some users and we ran into issues w/ some of their code still being on Pydantic v1. To facilitate migration, I decided to just update the client to also be pydantic v1 compatible, even though we really should move everyone off

how hard is it for them to migrate?

how hard is it for them to migrate?

I don't know; but I don't want to put myself in a position where people aren't using this new API cause they're blocked on migrating


Automatically merge changelog files

About the PR
Allow downstreams to have their own changelog yml file.
It will automatically load all yml files in /Changelog/, merge, sort by time add return as one changelog.
Screenshots

Changelog

How does this handle merging IDs between the files?

How does this handle merging IDs between the files?

Don't see a good solution here. Only these:

Use Changelog.yml as a base file and add new entries from other files using its last entry ID.
Try to use only  in code total length of array with all entries from all files.

Do we even need to merge the IDs? They're not used for display and I imagine any downstreams could just point their action at their own file.

There seems to be no more interest on discussing this further anytime soon


Fix of the dash.conf path for Windows platforms

Hi, here is a fix of determination of the dash.conf file path on Windows platform.

Thanks!


Support for [functional] to [total] migration

Multi-stage deprecation

Might be the case that the llvm backend largely ignores functional/total anyway.

One complication: the LLVM backend CI integration tests use raw kore files committed directly to repo.

Could change the kore files directly (maybe will invalidate digests in those files though?)
Could regenerate the kore files if needed (hard).


Disable the same day each week

can we disable the same day each week ?
eg every Sunday or every Monday?
I checked for the option to disable all days of all dates by just telling date
Like [1,3,5] and it disable all these days in all months

https://wakirin.github.io/Litepicker/docs/options#lockdaysfilter-200

https://wakirin.github.io/Litepicker/docs/options#lockdaysfilter-200


Rainbow Frame

Posted here so that we don't totally forget about this.

dev/migrie/fhl/rgb-rainbow-window-frame. I've got it hooked up to moving the window, obviously, that's contrived, so a 1/60th second timer somewhere would work well enough.
I dunno what exactly this is, but we need it in the Terminal. Probably a special case of window.frameColor in #3327?

Important? 👎
Cool? 💯🌟🌈😲

Maybe you could make the window frame be anything: color, acrylic, image, composed image (corners, edges).

how to do this?

@6H075T2 See: https://learn.microsoft.com/en-us/windows/terminal/customize-settings/themes#experimental-rainbow-window-border

It doesn't work for me can you enlighten me please?

Ah, the rainbow frame setting isn't a global, it's a theme setting. You need to make a new theme, and enable it for the theme.
Try adding the following to the globals:

{
    // "profiles": { ... }
    // "schemes": [ ... ]
    // "defaultProfile": ...
    // etc
    // etc

    "theme": "rainbow",
    "themes":
    [
        {
            "name": "rainbow",
            "window":
            {
                "experimental.rainbowFrame": true,
            },
            "tab": {
                "background": "terminalBackground",
                "unfocusedBackground": "#00000000"
            },
        },
    ]
}


feat: Cambia nombre paquete de composer

Cambia el nombre en paquete de composer

Coverage remained the same at 25.974% when pulling d77a5c1a350b04da25d99050b6127f7779257e0d on release_2_0_1 into 863d5ce0ce7428d9923348868d0093c583704a23 on master.


SO-3802: improve JWT configuration

This PR introduces a few changes to the existing access token signing and verification module.
Authentication changes:

The system still accepts externally signed access token but instead of configuring the externally available JWKS as a global config, administrators should use the new jwks identity provider module. It can have its own issuer, email and permissions claim property configuration different from the global one.
Snow Owl is now able to generate access tokens even when using external JWKS identity providers, no longer limited to just verification

Configuration changes:

Deprecated identity.jwksUrl in favor of the new jwks identity provider

Codecov Report
Base: 64.21% // Head: 64.21% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (0e4e5d6) compared to base (21b5b83).
Patch coverage: 52.69% of modified lines in pull request are covered.

:exclamation: Current head 0e4e5d6 differs from pull request most recent head 431711d. Consider uploading reports for the commit 431711d to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                8.x    #1095      +/-   ##
============================================
- Coverage     64.21%   64.21%   -0.01%
- Complexity    12472    12523      +51
============================================
  Files          1735     1746      +11
  Lines         58262    58511     +249
  Branches       5380     5393      +13
============================================
+ Hits          37415    37573     +158
- Misses        18533    18620      +87
- Partials       2314     2318       +4

Impacted Files
Coverage Δ

...wowl/snomed/cis/rest/CisAuthenticationService.java
0.00% <0.00%> (ø)

...rnational/snowowl/snomed/cis/client/CisClient.java
0.00% <0.00%> (ø)

.../snowowl/core/rest/admin/AuthorizationService.java
14.28% <0.00%> (-2.39%)
:arrow_down:

...snowowl/core/authorization/AuthorizedEventBus.java
39.13% <ø> (+4.51%)
:arrow_up:

...rnational/snowowl/core/client/TransportClient.java
0.00% <0.00%> (ø)

...wowl/core/identity/AdminPartyIdentityProvider.java
0.00% <0.00%> (ø)

...ternational/snowowl/core/identity/Credentials.java
0.00% <0.00%> (ø)

...l/snowowl/core/identity/MultiIdentityProvider.java
0.00% <0.00%> (ø)

...nternational/snowowl/core/identity/Permission.java
58.82% <ø> (ø)

...core/identity/file/FileIdentityProviderConfig.java
100.00% <ø> (ø)

... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Load profile; use scientific notation in the graph for small number.

Small numbesr in load profiles: use scientific notation here?

Small numbesr in load profiles: use scientific notation here?

If possible, I'd like scientific notation for small numbers

Scientific notation may be a bit technical for some users; perhaps we could change the unit from kW to MW to GW as appropriate?
The Quantity class in ETModel does this quite nicely, but we'd have to pull in i18n-js to use it.

Scientific notation may be a bit technical for some users; perhaps we could change the unit from kW to MW to GW as appropriate? Or from kW to W for smaller numbers.

I like that solution @antw!

Closing as this is issue is superseded by https://github.com/quintel/etloader/issues/139


Panic in AuthService when upgrading openLDAP enabled setup from 1.6.5-> 1.6.6-rc2.

Setup:
Rancher server setup ->1.6.5
Have openLDAP enabled
Upgrade to  1.6.6-rc2
Once rancher-server is upgraded , there is constant Panic seen in AuthService
Not able to access "Admin"-> AccessControl tab from UI.
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x80ad14]

goroutine 1 [running]:
github.com/rancher/rancher-auth-service/vendor/github.com/urfave/cli.HandleAction.func1(0xc420207988)
	/go/src/github.com/rancher/rancher-auth-service/vendor/github.com/urfave/cli/app.go:472 +0x28d
panic(0xb89c40, 0x11accd0)
	/usr/local/go/src/runtime/panic.go:489 +0x2cf
github.com/rancher/rancher-auth-service/server.UpgradeCase(0xc420105488, 0x1)
	/go/src/github.com/rancher/rancher-auth-service/server/auth_server.go:652 +0x8b4
main.StartService(0xc4200c2280)
	/go/src/github.com/rancher/rancher-auth-service/main.go:135 +0x1a7
reflect.Value.call(0xb35940, 0xc50bf0, 0x13, 0xc300a9, 0x4, 0xc420055928, 0x1, 0x1, 0xc4200558b0, 0xc1b3c0, ...)
	/usr/local/go/src/reflect/value.go:434 +0x91f
reflect.Value.Call(0xb35940, 0xc50bf0, 0x13, 0xc420055928, 0x1, 0x1, 0xb84b00, 0xc4200119b0, 0xc3376e)
	/usr/local/go/src/reflect/value.go:302 +0xa4
github.com/rancher/rancher-auth-service/vendor/github.com/urfave/cli.HandleAction(0xb35940, 0xc50bf0, 0xc4200c2280, 0x0, 0x0)
	/go/src/github.com/rancher/rancher-auth-service/vendor/github.com/urfave/cli/app.go:481 +0x198
github.com/rancher/rancher-auth-service/vendor/github.com/urfave/cli.(*App).Run(0xc4200fc000, 0xc4200104b0, 0x3, 0x3, 0x0, 0x0)
	/go/src/github.com/rancher/rancher-auth-service/vendor/github.com/urfave/cli/app.go:240 +0x560
main.main()
	/go/src/github.com/rancher/rancher-auth-service/main.go:116 +0xcfb

Rancher server setup ->1.6.5
Have openLDAP enabled
Upgrade to 1.6.6-rc3
Once rancher-server is upgraded , there is no panic seen in  AuthService .
Able to access "Admin"-> AccessControl tab from UI successfully.


README: CudaTensor doesn't support :diag()

They were added to cutorch on July 27th. https://github.com/torch/cutorch/pull/451

Thanks ... I need to update the torch instance on my workstation.


watch on windows

Hi,
using 11.0.1
I got on win7
Running "ts:watch" (ts) task
[D] Task source: C:\dev\svn\alerting\trunk\src\main\webapp\resources\application\node_modules\grunt-ts\tasks\ts.js
Verifying property ts.watch exists in config...OK
Files: [no src] -> watch
Options: allowBool=false, allowImportModule=false, compile, declaration=false, mapRoot="", module="commonjs", noImplicitAny=false, noResolve=false, co
mments=null, removeComments=null, sourceMap=false, sourceRoot="", target="es5", verbose=false, fast="watch"
Warning: Cannot call method 'indexOf' of undefined Use --force to continue.
Aborted due to warnings.
--> Solved
Reason was, that task ts always needs a subtargettask,
otherwise it will not work

Hi @raDiesle - we've significantly improved our documentation since this issue was reported.  I hope that there are sufficient examples of gruntfile.js so that others should not run into this problem.  Thanks for the report.  I'll close this now.  Please let us know if you have any further issues.


Installation error on OEL 6

During installation I am getting this error:
Installed /tmp/easy_install-V7APwZ/mock-2.0.0/pbr-1.10.0-py2.6.egg
ERROR:root:Error parsing
Traceback (most recent call last):
  File "/tmp/easy_install-V7APwZ/mock-2.0.0/pbr-1.10.0-py2.6.egg/pbr/core.py", line 111, in pbr
    attrs = util.cfg_to_args(path, dist.script_args)
  File "/tmp/easy_install-V7APwZ/mock-2.0.0/pbr-1.10.0-py2.6.egg/pbr/util.py", line 248, in cfg_to_args
    kwargs = setup_cfg_to_setup_kwargs(config, script_args)
  File "/tmp/easy_install-V7APwZ/mock-2.0.0/pbr-1.10.0-py2.6.egg/pbr/util.py", line 431, in setup_cfg_to_setup_kwargs
    if pkg_resources.evaluate_marker('(%s)' % env_marker):
AttributeError: 'module' object has no attribute 'evaluate_marker'
error: Setup script exited with error in setup command: Error parsing /tmp/easy_install-V7APwZ/mock-2.0.0/setup.cfg: AttributeError: 'module' object has no attribute 'evaluate_marker'

Could you help me solve this problem?
I have tried on Python 2.6.6

I was able to get it installed using:
pip install -r requirements.txt && python setup.py install

For requirements.txt, do you mean we need to replace it with a specific file?  In this question, is it /tmp/easy_install-V7APwZ/mock-2.0.0/pbr-1.10.0-py2.6.egg?

I don't understand your question @Lushali. Clone the repo, install pip if you don't have it, then run pip install -r requirements.txt. There may be some development libraries you need to build packages like cryptography requires libssl-dev. If you hit errors, search for the libraries installation instructions on google.
Please note that I've recently removed official support for Python2.6. It should still work, but may not in the future.

@Qmando Thanks, I got it.


3347/5501 wrong name "Digital Input State" should be "Digital Input Counter"

The Push button seems to have a copy paste error.
The resource 3347/5501 has "Digital Input State" as name (which is already used by the 5500) and should be "Digital Input Counter".

Though this issue seems to be very similar to issue #2 I checked all the xml and the good new is, that this is the last copy-paste error at 5501 :-).


Icon request: storage types

Common Python-related storage types including .h5, .npz, .pickle/.pkl don't have any icon.
Also, it seems that unrecognized files get the system default icon instead of e.g. a theme default, which kind of breaks with the theme. Is that by design or a limitation?

I’ve never thought about a theme default, especially since this is an icon theme. What do you have in mind?

Maybe a greyish spin on the OS defaults?
Windows:

MacOS:

Right now, the problem is, if there's no icon available, some other default application will hijack the icon, at least on MacOS:

That's true but I specifically did that so icons not registered with the plugin would still use the icon provided by other plugins. For instance, my plugin doesn't support stuff like .helmignore, .flooignore, .ebignore etc... However such extensions are supported by the .ignore plugin, so the plugin would still display the icons provided by .ignore.
So yeah, basically h4/h5/whatever that is neither supported by any plugin would display the default icon.
Maybe in the future when I'll implement custom associations you'll be able to undo this. Not for now however.


More debug info for failed edits

Pull Request Description
Unmasked position info for the failed edits so that it is possible to understand what edits are attempted at all. So far unable to locate the problem based solely on the logs and the stacktrace. Added a test confirming that making edits at the end of the file continues to be fine (that's where the problem usually manifests itself).
Important Notes
References #7978
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.

Should we enable NO_LOG_MASKING on CI (nothing to 'hide' in our tests) and try to convince devs (us) to also set it, so that our logs will contain more specific information?


The call of make without parameters causes make clean to execute

calling make without parameters leads to execute make clean which deletes translations.json and template.pot.
we want improve this behavoir to avoid the deletion of files with the accedintally call of make without parameters.

Solution
add all target to prevent the accedintally call of make
we improved this  with the commit : https://hg.intevation.de/gemma/rev/bba166f0326e


Release v0.7

[ ] https://github.com/trixi-framework/Trixi.jl/issues/1510
[ ] https://github.com/trixi-framework/Trixi.jl/issues/1194
[ ] https://github.com/trixi-framework/Trixi.jl/issues/1046
[ ] https://github.com/trixi-framework/Trixi.jl/pull/1255

If we want this to work smoothly, we will have to break plot(sol)

[ ] https://github.com/trixi-framework/Trixi.jl/issues/1445
[ ] Move some advanced shallow water stuff to TrixiShallowWater.jl
[ ] Switch default HLL wave speed estimate to Davis, see #1545

Should we add #1781 to this release?

Should we add #1781 to this release?

Is it breaking? Or, more precisely, why do you think it is a breaking change?

I brought this up as it is labeled as a breaking change - although for users not too much should change.


Validation set

Hi,
I am wondering about the validation set you are using in your code. From what I could see, neither the older dataset nor the ICIAR 2018 dataset include a validation set. Can you elaborate on how you obtained/created this sub-set?
Thanks a lot!

@YuvalBahat We randomly chose 20% of the training set for the validation set and later used 10-fold cross validation across 10 model ensembles!

@knazeri Thanks for your prompt reply!


Japanese Symbol Variations explanation should be updated in the document.

Japanese Symbol Variations explanation is not written in the document.
http://redpen.cc/docs/latest/index_ja.html#setting-symbols
How can we set "zenkaku2" and  "hankaku" variants?
However, the explanation is written in the blog of the qiita.
https://qiita.com/takahi-i/items/f16fd93e2e5061851320#句点の設定
Could you please update Japanese Symbol Variations explanation in the document?
ドキュメントでzenkaku2とhankakuの解説が欲しいです．

I understand the zenkaku2 explanation in the document.
I had a mistake.
The reason is that the explanation of zenkaku2 is close with hankaku.


psup-297 - up some limits

Code Coverage is 57.7%, details at https://s3.amazonaws.com/rs-code-coverage/wstunnel/2015-08-26_75_Coverage-57.7.txt (sometimes the URL can take a few minutes to be available)

Thanks for trying this, but it wasn't an issue. The buffer size does not limit message size and the ReadLimit should remain at 100MB.


Auto start managed containers in Debug mode if client debug is detected

If Client JVM is detected to be running in DebugMode, Chameleon should set JVM Debug options on the target Managed container.

Attempt to detect Client debug via JMX Command line args?

boolean isDebug = java.lang.management.ManagementFactory.getRuntimeMXBean().
    getInputArguments().toString().indexOf("jdwp") >= 0;

Lookup javaVmArguments property from containers.yaml and set the required options.

We should probably start Managed Container with suspend=y to allow user to attach debug client.
note: check with JBDS ( @maxandersen ) if connecting to managed JVM could be automated in IDE.

so you want the IDE to listen (i.e. run what corresponds to 'jps' ever second or so) and automatically connect debugger to it ?
So, yeah we actually do have the misnamed but related view jmxview which scans for new jps detectable processes and here you should be able to see them show up.
Is it really necessary to automatically connect ? would it not be sufficient to just offer right click on the process and allow remote debug to setup ?

if yes, please try latest version since we've had this since alpha2 (https://issues.jboss.org/browse/JBIDE-19397)

blog about this feature in context of server adapters is at http://tools.jboss.org/blog/2015-03-17-debugging-an-externally-launched-wildfly.html

@maxandersen that will kinda work, same with the discover remote debugging feature, but.. The general idea here would be to be able to provide the 'embedded' experience with non embedded JVM's. Automatic is key here.

@maxandersen technically the IDE doesn't have to listen, I could tell you 'somehow', but that would make it less generic I guess. e.g. Arquillian Launcher could set a ENV variable with a temp file ref I could write the child PIDs to or similar..

Have you tried what we got now ? Do you really want it to automatically connect even more and therefore have it automatically continue without warning ? Actually I guess it could be interesting to say that if a process shows up actually have debug enabled just blindly connect to it could be an interesting thing to do ... I'll need to see how "expensive" it is to this check on all processes.
Feel free to open a jira on this idea.
btw. writing to a separate file is not really going to be better than what we have now - that is technically just listening to a "file"/stream that contains the list of running java processes.

@maxandersen Not the JMX Navigator (having some local issues here), but a heavy user of Shift+Alt+D+D :) Love it! :) (might even have requested it it seems: https://issues.jboss.org/browse/JBIDE-8548)

Currently this is fairly blocking to the auto connection part; https://issues.jboss.org/browse/JBIDE-20217

@maxandersen The JMX Navigator (jbosstools-server provided integration) is suffering from the same issue as RemotDebug, it can't properly locate a suspended=y JVM. It never shows up in the Local Process menu. Running jps from command line hangs for a bit then returns the process id with a 'unknown main class' info line.
Depending on the size of the tests you're running it might take too long and be to unpredictable to manually go from 'Debug As -> JUnit Test' to 'Wait for Local Process to show up' to 'Right click -> Connect debugger'. Possible <2 s from you run Debug until first test starts to run when not starting the Managed container with suspend=y.

For reference: https://issues.jboss.org/browse/JBIDE-20224

Good catch about JBIDE-20224 we'll look at fixing that!
About "too long and be to unpredictable" what do you mean here ? if the process is suspended then it will wait until you have connected wont it ?
I agree would be nice to automate it but just want to be sure i'm not missing something here since if we can't do it manually predictably I don't think we can do it automatically either.

@maxandersen to sum up:
Start JVM with suspend=y

Does not currently work with RemoteDebugActivator(?)
https://issues.jboss.org/browse/JBIDE-20217

Does not currently work with JMX Navigator
https://issues.jboss.org/browse/JBIDE-20224

Start JVM with suspend=n
This works, but you have less then a second to "wait for the process to start" and "manually connect a remote debugger" after 'debug' is pressed. Manually doing this "takes too long and is to unpredictable". Chances are the Test is done before you manage to react.

yes so if we fix the one about suspend=y (it should be possible since jps works albeit slow) you should be good for majority of cases, right ?
then enabling automatic connect could be an enhancement, correct?
btw. remotedebug and jmx navigator should now be using same code for this thus why it fails in both places.

yes so if we fix the one about suspend=y (it should be possible since jps works albeit slow) you should > be good for majority of cases, right ?

Correct, this would make it work.

then enabling automatic connect could be an enhancement, correct?

And this would make it Rock! :)


Setting fix

Closes #5

@yaroslavyaroslav Thanks! How do I test this out? I tried cloning into /Packages/OpenAI-sublime-text, which does load the package into Sublime Text, but the settings link from the menu is still not working for me.

@raineorshine I've merged it to develop, since @deathaxe has been approved these changes, so you can pull it instead as for now.
So I would tell you where you should install it exactly to test these changes when I'll be at my laptop, by my memory I can say that there's a two folders for a package:

For zipped one
For raw sources installation

But I dunno which is where 🤷🏻♂. If I'm not mistaken the latter is the one that you are looking for and it placed somewhere alike Sublime Text/User/Packages/.

Works great! Thanks!


Have to run torch-activated.cmd

It seems if I need to use torch, i have to run the 'torch-activate.cmd' every time, and should start from the install path.

It seems if I need to use torch, i have to run the 'torch-activate.cmd' every time

Yes, if you close the command prompt every time you finish use Torch. Torch is installed in a self contained folder so that it is not messed with other luajit/luarocks installations for non torch use cases, and other torch installations with different versions of lua. 'torch-activate.cmd' is used to setup which lua/luajit torch installation is going to be used afterwards.

and should start from the install path.

Not necessary, you can run the full path of 'torch-activate.cmd' from any directory and use Torch afterwards.

@howard0su Thanks very much!
Now I close this issue.