fix: add pool asset length check for map

This is difficult to test as the original issue appeared to come from a malformed osmosis API response.


Change logos and game logos.

Hello @Ochii
1-How to change the Counter Strike 2 logo at the entry when we log in. where to change  --- and when I run the game I have the nexon logos I want to remove them
2-When you log in to the game you will find how korean posts are available on the popup screen.
3-How to change the logo at the bottom right of the home screen when I log in
4-Which program should I design with the new character?
We will share your screenshot.
http://prntscr.com/mre9ha
http://prntscr.com/mrec5w
http://prntscr.com/mred62
http://prntscr.com/mredqs

also the game system automatically launcher when you are constantly writing users are not satisfied with the rope.
thank you for your help .... <---

I also need to remove the overdue period of time in order to remove them later in the game so I can limit the variety of weapons in them. ? I want to leave the weapons I determined in the inventory and purchased weapons

1,3) All logos are stored in: "cstrike\ui_gfx" folder. You can edit them with photoshop or similar program.
2) Banners are stored on Nexon server. URLs of banners are hardcoded to the game.
4) I have no idea, internet should have programs for css, maybe it can be used for cso2 also.

@Ochii  @organnerx
Hello there
I looked at the folders you said and I found them, but when I change them, the changes do not change the same pictures logos
I opened the encrypted files, ie PGK files with the file given by Ochii
I opened encrypted files
-decryptedfiles    /    -enablecustom
but no changes occur
also
How can I limit weapons I have a lot of weapons I want to use the weapons I determined.


'React' must be in scope when using JSX

Describe the bug
'React' must be in scope when using JSXeslint[react/react-in-jsx-scope]
Starting with React 17, we no longer need to import React in each component.
But now ESLint is complaining about the absence of this import.
Possible fix: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/react-in-jsx-scope.md

Will fix, thanks


fix: add check for disabled session storage

Adds a check for window.sessionStorage. If it does not exist or if accessing it creates an exception (like with disabled cookies) it will return false. Otherwise, it will return true.
Feel free to modify if you need @bluebill1049  👍
closes #57

Thanks a lot for the PR, looks good 👍 just a minor one.

@bluebill1049 Fixed PR :)

thanks! 👍

will release a beta version, let me know if this is working as expected.

3.2.0-beta.1

Works great! Thanks


question for contribution

i'm korean university student.
Recently, i used movieguide application in android. i think, it is quite useful and it has good information and interface. So i want our korean to know this application using opensource. But because text file like readme is written in English, people might have trouble in interpreting English.
So can i Translate text file like readme or contributing guidelines into Korean?

Hey @dtree0520 that's an interesting concern you've raised. When you say translate the readme into Korean, do you mind expounding on whether there should be another readme alongside written in Korean? Basically expound on how that experience should be.

I am ready to work on it.

@ChristineWasike  No. It should be nice if another readme version which is translated into Korean.
So, I hope that a contribution is made if i translate textfile into korean.
First, i already translated readme into Korean
Android app that lists popular/highest-rated movies, shows trailers and reviews.
->이 어플리케이션은 인기 / 최고 등급의 영화를 나열하고 예고편 및 리뷰를 표시하는 Android 어플리케이션입니다.
This app showcases the MVP pattern, RxJava, Dagger 2 and Uncle Bob Martin's Clean Architecture approach. Optimized for tablets.
->이 어플리케이션은 MVP 패턴, RxJava, Dagger 2 및 Uncle Bob Martin 의 Clean Architecture 접근 방식을 보여줍니다. 또한 이 어플리케이션은 태블릿에 최적화 되어있습니다.
Add your themoviedb.org API key in the local.properties file:
->local.properties 파일에 user의 themoviedb.org API 키를 추가하여주십시오.
Check out the Kotlin version here
->here을 눌러서 Kotlin버전을 확인하십시오.
Can you help me by updating readme Korean version?

Where would we add these translated files to? A different directory?

Hey @esoxjem I think it is better to add these translated files in same this directory.
So, people can read both original readme file and transltated readme file.
Additionally, what do you think if we  translate another textfile or suggest idea about application?

Hi @dtree0520, please fork this repo and translate/maintain the Korean version. Thanks.


Configure Devops

Add rultor, pdd and circleci

@ammaratef45/z I'm not managing this repo, remove the webhook or contact me in Slack, as explained in §11; I'm not managing ammaratef45/attendance GitHub repository, you have to contact me in Slack first, see §11 /cc @yegor256/z

I'm not managing ammaratef45/attendance GitHub repository, you have to contact me in Slack first, see §11

The job #12 assigned to @ammaratef45/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

Job gh:ammaratef45/attendance#12 already assigned to @ammaratef45, can't assign to @ammaratef45

It is strongly discouraged to assign jobs to their creators, see §19: -15 point(s) just awarded to @ammaratef45/z

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @ammaratef45/z

Bug was reported, see §29: +15 point(s) just awarded to @ammaratef45/z

Job was finished in 11 hours, bonus for fast delivery is possible (see §36)

The job #12 is now out of scope

Order was finished: +35 point(s) just awarded to @ammaratef45/z


Using kubeshark CLI with multiple kubeconfig files

Describe the bug
I have multiple kubeconfig files in my .kube directory and switch the context to connect to the correct cluster.
When running kubeshark tap I see that the tool seems to use the right context based on the list of targeted pods but
when it comes to the Installing using Helm part I see this error: error="Kubernetes cluster unreachable: stat ... no such file or directory
Provide more information
Running on k3s, 5 nodes

Same here on v52.3.79, I have multiple paths in $KUBECONFIG and switch contexts across them, which works with many tools (like Helm and kubectx). In my case, I have those kubeconfig files pulled from external source, which is easier achieved with separate files on static locations, rather than combined into a single kubeconfig file.
As per k8s docs:

The KUBECONFIG environment variable is a list of paths to configuration files. The list is colon-delimited for Linux and Mac, and semicolon-delimited for Windows.

However, kubeshark at least in one place does not understand it and attempts to read file $PATH1:$PATH2:$PATH3, while in other place it actually can connect to current context as it discovers pods on cluster from current context
❯ kubeshark tap
2024-08-28T12:35:18+02:00 INF versionCheck.go:23 > Checking for a newer version...
2024-08-28T12:35:18+02:00 INF tapRunner.go:49 > Using Docker: registry=docker.io/kubeshark tag=
2024-08-28T12:35:18+02:00 INF tapRunner.go:53 > Kubeshark will store the traffic up to a limit (per node). Oldest TCP/UDP streams will be removed once the limit is reached. limit=5000Mi
2024-08-28T12:35:18+02:00 INF common.go:69 > Using kubeconfig: path=/Users/foo/.kube/config:/Users/foo/abc_kubeconfig:/Users/foo/cde_kubeconfig:/Users/foo/fgh_kubeconfig
2024-08-28T12:35:22+02:00 INF tapRunner.go:71 > Telemetry enabled=true notice="Telemetry can be disabled by setting the flag: --telemetry-enabled=false"
2024-08-28T12:35:22+02:00 INF tapRunner.go:73 > Targeting pods in: namespaces=["default","foo","bar","kube-public","kube-system"]
2024-08-28T12:35:27+02:00 INF tapRunner.go:140 > Targeted pod: foo
2024-08-28T12:35:27+02:00 INF tapRunner.go:140 > Targeted pod: bar
2024-08-28T12:35:27+02:00 INF tapRunner.go:83 > Waiting for the creation of Kubeshark resources...
2024-08-28T12:35:30+02:00 INF helm.go:128 > Downloading Helm chart: repo-path=/Users/foo/Library/Caches/helm/repository url=https://github.com/kubeshark/kubeshark.github.io/releases/download/kubeshark-52.3.79/kubeshark-52.3.79.tgz
2024-08-28T12:35:32+02:00 INF helm.go:147 > Installing using Helm: kube-version=">= 1.16.0-0" release=kubeshark source=["https://github.com/kubeshark/kubeshark/tree/master/helm-chart"] version=52.3.79
2024-08-28T12:35:32+02:00 ERR tapRunner.go:92 > error="Kubernetes cluster unreachable: stat /Users/foo/.kube/config:/Users/foo/abc_kubeconfig:/Users/foo/cde_kubeconfig:/Users/foo/fgh_kubeconfig: no such file or directory"

Moreover, the issue cannot be simply bypassed by selecting the desired kubeconfig file that contains single context definition without current-context as kubeshark again crashes with incorrect error:
❯ KUBECONFIG=/Users/foo/abc_kubeconfig kubeshark tap
2024-08-28T13:53:13+02:00 INF tapRunner.go:49 > Using Docker: registry=docker.io/kubeshark tag=
2024-08-28T13:53:13+02:00 INF tapRunner.go:53 > Kubeshark will store the traffic up to a limit (per node). Oldest TCP/UDP streams will be removed once the limit is reached. limit=5000Mi
2024-08-28T13:53:13+02:00 INF versionCheck.go:23 > Checking for a newer version...
2024-08-28T13:53:13+02:00 ERR common.go:98 > error="couldn't find the kube config file, or file is empty (/Users/foo/abc_kubeconfig)\nyou can set alternative kube config file path by adding the kube-config-path field to the kubeshark config file, err:  invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable"
2024-08-28T13:53:13+02:00 ERR tapRunner.go:59 > error="couldn't find the kube config file, or file is empty (/Users/foo/abc_kubeconfig)\nyou can set alternative kube config file path by adding the kube-config-path field to the kubeshark config file, err:  invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable"

This happens on my config setup because current-context is written to the first kubeconfig file on list in global $KUBECONFIG and I pass only kubeconfig that contains clusters, contexts, preferences and users. That is indeed invalid kubeconfig (as stated on https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/, current-context is required), but all standard tools allow user to pass context in CLI (kubectl --context, helm --kube-context) - this is not the case with kubeshark - https://github.com/kubeshark/kubeshark/issues/1279
And it can't be easily bypassed by yet another env variable, as there's no common KUBECONTEXT :/


TravisCI build marked as passed when there are IT failures

If there are failures in the integration tests, the TravisCI build should be marked as failed.

@temyers if you have Build failure, i think travis by default fails the build

It should, but it's not currently working like that - some of the pull requests contain integration test failures, but the checks all show as passed.


feat: support pushing version only to linked project

What kind of change does this PR introduce?
feature
What is the current behavior?
need to manually delete version history when remote commit fails
What is the new behavior?
supports db push --version-only
rewrites the remote history table to match local
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

51 of 58 (87.93%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 57.965%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/db.go
1
2
50.0%

internal/db/push/push.go
35
37
94.59%

internal/migration/list/list.go
15
19
78.95%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
3264

Relevant Lines:
5631

💛  - Coveralls


⚠ Thumbnails API Endpoint has degraded performance

In 0ba7917, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 5672 ms

Resolved: Thumbnails API Endpoint performance has improved in cee22a9 after 12 minutes.


Suppliers can view/remove G-Cloud 7 services

Sorry for all the re-indenting.  This is essentially a one-line fix for suppliers viewing/removing G-Cloud 7 services.
Load g-cloud-7 service editing manifest
Manifests are loaded initially and then retrieved when they're needed.
This means they'll fail if one tries to retrieve a manifest that wasn't loaded.
In this case, the edit_service manifest for G-Cloud 7 wasn't loaded, so if any supplier tried to view/remove one of their G7 services, they would get a 500-level (ContentNotFound) error.
Adding the manifest solves the problem.

Can we try this http://pytest.org/latest/fixture.html#parametrizing-a-fixture instead of loops within each test?
Otherwise, when g-cloud-6 goes away we'd have to update all those tests again.

Yeah, that looks much better.

:+1:


cvmfs-scitoken-helper core dumps on RL9

When attempting to use authorised CVMFS (for LIGO) on Rocky Linux 9 the cvmfs-scitoken-helper is being reported as core dumping:
Aug 04 09:50:55 datafind-dev cvmfs2[66936]: (ligo.storage.igwn.org) starting authz helper /cvmfs/config-osg.opensciencegrid.org/libexec/authz/cvmfs_scitoken_helper
Aug 04 09:50:55 datafind-dev cvmfs_scitoken_helper[67147]: (ligo.storage.igwn.org) Support for Globus authz is enabled.
Aug 04 09:50:55 datafind-dev cvmfs_scitoken_helper[67147]: (ligo.storage.igwn.org) Failed to load VOMS library; authz will not be available.  libvomsapi.so.1: cannot open shared object file: No such file or directory
Aug 04 09:50:55 datafind-dev cvmfs_scitoken_helper[67147]: (ligo.storage.igwn.org) Support for VOMS authz is NOT enabled.
Aug 04 09:50:55 datafind-dev cvmfs_scitoken_helper[67147]: (ligo.storage.igwn.org) x509 authz helper invoked, connected to cvmfs process 66936
Aug 04 09:50:55 datafind-dev systemd-coredump[67151]: [🡕] Process 67147 (cvmfs_scitoken_) of user 0 dumped core.
Aug 04 09:50:55 datafind-dev cvmfs2[66936]: (ligo.storage.igwn.org) authz helper /cvmfs/config-osg.opensciencegrid.org/libexec/authz/cvmfs_scitoken_helper enters fail state, no more authorization

The authz debuglog isn't very helpful:
Successfully loaded Globus library    [08-04-2023 09:50:55 CDT]
Support for Globus authz is enabled.    [08-04-2023 09:50:55 CDT]
Failed to load VOMS library; authz will not be available.  libvomsapi.so.1: cannot open shared object file: No such file or directory    [08-04-2023 09:50:55 CDT]
Support for VOMS authz is NOT enabled.    [08-04-2023 09:50:55 CDT]
x509 authz helper invoked, connected to cvmfs process 66936    [08-04-2023 09:50:55 CDT]
Executable: cvmfs_scitoken_helper    [08-04-2023 09:50:55 CDT]

I think @DrDaveD has been able to reproduce this issue on his RL9 system.

Package list
# dnf list installed | grep -E "cvmfs|x509|voms|osg|token"
cvmfs.x86_64                          2.10.0-1.2.osg36.el9          @osg36
cvmfs-config-osg.noarch               2.5-2.osg36.el9               @osg36
cvmfs-x509-helper.x86_64              2.2-3.osg36.el9               @osg36
frontier-squid.x86_64                 11:5.8-2.1.osg36.el9          @osg36
htgettoken.x86_64                     1.18-1.osg36.el9              @osg36
osg-ca-certs.noarch                   1.112-1.osg36.el9             @osg36
osg-oasis.noarch                      19-2.osg36.el9                @osg36
python3-scitokens.noarch              1.7.0-1.osg36.el9             @osg36
scitokens-cpp.x86_64                  1.0.2-1.el9                   @epel-release

I caught a stacktrace by inserting a sleep near the beginning of the program and attaching with gdb:
#0  0x00007fb6c9ce454c in __pthread_kill_implementation ()
   from /lib64/libc.so.6
#1  0x00007fb6c9c97d46 in raise () from /lib64/libc.so.6
#2  0x00007fb6c9c6b7f3 in abort () from /lib64/libc.so.6
#3  0x00007fb6c9c6b71b in __assert_fail_base.cold () from /lib64/libc.so.6
#4  0x00007fb6c9c90ce6 in __assert_fail () from /lib64/libc.so.6
#5  0x00005596ad70be72 in Read (buf=0x7ffd7d444540, nbyte=184381)
    at /usr/src/debug/cvmfs-x509-helper-2.2-0.0.20230804164346.vagrant.cd07742fe9d2b34f99c295fd313e0b3664c75957git.el9.x86_64/src/x509_helper.cc:50
#6  0x00005596ad70e36b in ReadMsg ()
    at /usr/src/debug/cvmfs-x509-helper-2.2-0.0.20230804164346.vagrant.cd07742fe9d2b34f99c295fd313e0b3664c75957git.el9.x86_64/src/x509_helper.cc:78
#7  0x00005596ad709e78 in main (argc=<optimized out>, argv=<optimized out>)
    at /usr/src/debug/cvmfs-x509-helper-2.2-0.0.20230804164346.vagrant.cd07742fe9d2b34f99c295fd313e0b3664c75957git.el9.x86_64/src/x509_helper.cc:196


USHIFT-740: Enable gpgcheck when installing RPMs

Closes USHIFT-740

Do any of our CI jobs test these files?

Do any of our CI jobs test these files?

Not that I know of. I tested getting start image creation.
We can also ask @jogeo to test in the QE environment.

/lgtm
I've run this PR through the QE pipeline, ensured gpgcheck was set to 1, the ISO built successfully and deployed a MicroShift instance.


make cookbook solr5 ready

bunch of references, but not necessary
https://cwiki.apache.org/confluence/display/solr/Upgrading+a+Solr+4.x+Cluster+to+Solr+5.0
https://cwiki.apache.org/confluence/display/solr/Taking+Solr+to+Production
https://cwiki.apache.org/confluence/display/solr/Major+Changes+from+Solr+4+to+Solr+5
http://lucene.apache.org/solr/5_0_0/changes/Changes.html
https://s.apache.org/Solr-Ref-Guide-PDF

This would be very helpful as it seems like the current recipe does not work.

@tjordahl i will take a stab at it this weekend

@tjordahl how about trying it now? cookbook now supports v5

solr5 support added.


cleaning ECN repositories

based on final project name and choosen licence clean up repositories (names, purpose, ...)

chosed name "project Noe", repositories renamed and license MIT chosed.


PreferredVolumeChooser properties / configuration is not well documented

This volume chooser (and likely others in its package) are rewrites of older, deprecated classes. The property configuration for the PreferredVolumeChooser is not well document (others in this package may be the same). Would be good to provide examples of the configuration in the class javadoc.

I can work on this.

Hello there, @ddanielr were you able to work on this?


Release build failing on XCode Version 16.0 (16A242d) Mac OS Sequoia (15.0 (24A335))

Describe the bug
Release build failing on XCode Version 16.0 (16A242d) Mac OS Sequoia (15.0 (24A335))
To Reproduce
Steps to reproduce the behavior:
Generate a release build with Zendesk Logger packages
Expected behavior
Should generate a normal build
Screenshots

Environment (please complete the following information):

Platform: Mac OS Sequoia (15.0 (24A335))
React Native Version  0.74
Zendesk SDK Version :   react-native-zendesk-messaging: ^0.2.1

Additional context
I have a React native project and I'm using this package now after updating to Mac Sequoia the build is failing and showing the above error. It's super urgent, We have a launch of our app on Sep 19th, 2024, Could you please tell me the fix?
Thank you.

+1

+1

have someone solved it?

@Andriiklymiuk No it's still the same.

This is an issue with the Zendesk native SDKs that this library is depending on. Xcode 16 has stricter bitcode validation compared to earlier versions, that's why this is now popping up.
You should be able use a code snippet from this link to remove leftover bitcode from any frameworks. Just add any frameworks that cause bitcode issues to the framework_paths array.
https://support.zendesk.com/hc/en-us/community/posts/8057481044378/comments/8115692442010

This is an issue with the Zendesk native SDKs that this library is depending on. Xcode 16 has stricter bitcode validation compared to earlier versions, that's why this is now popping up.
You should be able use a code snippet from this link to remove leftover bitcode from any frameworks. Just add any frameworks that cause bitcode issues to the framework_paths array. https://support.zendesk.com/hc/en-us/community/posts/8057481044378/comments/8115692442010
post_install do |installer|

    bitcode_strip_path = `xcrun --find bitcode_strip`.chop!

   def strip_bitcode_from_framework(bitcode_strip_path, framework_relative_path)
     framework_path = File.join(Dir.pwd, framework_relative_path)
     command = "#{bitcode_strip_path} #{framework_path} -r -o #{framework_path}"
     puts "Stripping bitcode: #{command}"
     system(command)
   end

   framework_paths = [
     "Pods/ZendeskSDKConfigurationsSDK/SDKConfigurations.xcframework/ios-arm64/SDKConfigurations.framework/SDKConfigurations"
   ]

   framework_paths.each do |framework_relative_path|
     strip_bitcode_from_framework(bitcode_strip_path, framework_relative_path)
   end

end

this didnt work for me

i've made a temporary fix by navigating to ios/Pods/ZendeskSDKLogger/ZendeskSDKLogger.xcframework/ios-arm64
and running
xcrun bitcode_strip -r ZendeskSDKLogger.framework/ZendeskSDKLogger -o ZendeskSDKLogger.framework/ZendeskSDKLogger

i've made a temporary fix by navigating to ios/Pods/ZendeskSDKLogger/ZendeskSDKLogger.xcframework/ios-arm64 and running
xcrun bitcode_strip -r ZendeskSDKLogger.framework/ZendeskSDKLogger -o ZendeskSDKLogger.framework/ZendeskSDKLogger

feel free to correct me if there is a better solution

do we need to run that command every time before generating the final release build?

i've made a temporary fix by navigating to ios/Pods/ZendeskSDKLogger/ZendeskSDKLogger.xcframework/ios-arm64 and running
xcrun bitcode_strip -r ZendeskSDKLogger.framework/ZendeskSDKLogger -o ZendeskSDKLogger.framework/ZendeskSDKLogger

feel free to correct me if there is a better solution

do we need to run that command every time before generating the final release build?

i just run it after every pod-install


Don't shade packetevents

I think it would be great if packetevents wasn't shaded in the library and it was up to the user to do so. In my case I already depend on ProtocolLib in my plugin so I don't need packetevents to be included.

I will try to take a look into publishing a version with and one without packetevents shaded soon-ish.

@derklaro you can split the packetevents implementation into another module so people can still use that with adding new module's dependency.

Or it could use compileOnly on packetevents and then check at runtime if packetevents is in the classpath. This way it would also be possible to use the standalone packetevents plugin

Starting with beta8 there is no longer anything shaded.


RateMyCallAllowCustomUserFeedback attribute

RateMyCallAllowCustomUserFeedback cannot be changed for online hosted accounts:
PS C:\scripts> Set-CsClientPolicy -Identity global -RateMyCallAllowCustomUserFeedback $True
You are not permitted to invoke Set-CsClientPolicy with the following parameters:
RateMyCallAllowCustomUserFeedback
+ CategoryInfo          : NotSpecified: (:) [Set-CsClientPolicy], ArgumentException
+ FullyQualifiedErrorId : System.ArgumentException,Microsoft.Rtc.Management.Internal.SetClientPolicyCmdlet
+ PSComputerName        : admingb1.online.lync.com

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbf61d7d-bda0-9656-465d-9b519ed17b5e
Version Independent ID: 2bb4825d-eedc-c8e2-3f51-0cafd652eadd
Content: Set-CsClientPolicy (skype)
Content Source: skype/skype-ps/skype/Set-CsClientPolicy.md
Service: skypeforbusiness-powershell
GitHub Login: @kenwith
Microsoft Alias: kenwith

@dariomws306  Thank you very much for the contribution and sharing this explanation. @savusca
Hope this comment is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Add API routes to allow renaming of networks and tables

This is difficult, so we'll have to think carefully about how to do it.
Do you have a concrete need for this feature?

Not right now, no. It just seems like basic functionality that we should have


fix: zero out input to to_radix calls if inactive

Description
Problem*
Resolves
Summary*
In situations where a to_le_bytes call is in an inactive if-statement, the requirement for the produced byte array to represent the input field is not disabled. This can result in situations such as below where we want to decompose a value into a number of bytes which is dependent on the inputs to the circuit.
https://github.com/porco-rosso-j/safe-recovery-noir/blob/b80a1fd49d370bd095827318b378c8fdef2e2d9b/circuits/social/src/root.nr#L11-L22
All branches of this snippet are limited by the fact that the first will fail on index with values greater than 1.
fn main(x: Field, cond: bool) {
    if cond {
        let bad_byte_array = x.to_le_bytes(1);
        assert_eq(bad_byte_array.len(), 1);
    }
}

This compiles down to
acir fn main f0 {
  b0(v0: Field, v1: u1):
    enable_side_effects v1
    v31, v32 = call to_le_radix(v0, u32 2⁸, u32 1)
    v34 = cast v1 as Field
    v35 = mul v31, v34
    constrain v35 == v34
    enable_side_effects u1 1
    return
}

The to_le_radix will revert for all v0 >= 8 no matter the value of v1.
I've modified the flatten_cfg pass such that we multiply in the side effects variable to zero out the input should the instruction be deactivated.
Additional Context
Documentation*
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Should we also change the specification that ToBits and ToRadix have side effects under instruction.rs?

Good point, yeah we should add that.


Eclipse plugin not updated to 24.1

Description
https://dbeaver.io/update/latest/ still reflects releases on 19th of May 2024 although a 2nd of June 2024 is 2 days ago...
DBeaver Version
Eclipse 4.31
Operating System
any platform
Database and driver
irrelevant
Steps to reproduce
Open https://dbeaver.io/update/latest/ and if you see files and folders older than 2024-06-02 (thatțs 2nd of June 2024) than no most recent release is reflected as advertised on official website
Additional context
No response

Thank you for report.

We updated files in latest


Well ! Why leave puns behind ?
Only the best one related to developers and development .
Anyone can take part.

@Jain-Sanchit Have added a pun to the json. Please review.

Don't think these type of PR's will work


Package Requested

[X] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[X] I have performed a search and couldn't find this package.
[X] I have checked that the installer for this package is not contained in a .zip file
[ ] I think there is a new version available and I have provided the URL.

Please provide the following information
Publisher: Files Community
Publisher Url: https://github.com/files-community/Files
Package Name: Files
Description: Explore a beautiful Windows-first design. Manage all your files with increased productivity. Work across multiple folders with tabs. And so much more.
Package Version: v2.4.3
Installer URL: https://github.com/files-community/Files/releases/download/v2.4.3/Files.Package_<IP_ADDRESS>_x64_ARM64_Sideload.msixbundle
Current Package Identifier (for new versions):

The MSIX bundle for Files doesn't come bunded with Microsoft.WindowsAppRuntime.1.2 which is a dependency for Files to be installed.
@msftbot dependencies

The package had previously existed in the repo, but has been removed due to MS store support - https://github.com/microsoft/winget-pkgs/pull/24067#issuecomment-939493509


WebView: mouse drag does not stop when within webview region

Issue Type: Bug

Open Release Notes in product
Try to increase sidebar size

-> Doesn't work, webview seems to eat up mousemove event, since it's still possible to decrease the sidebar size.
VS Code version: Code - Insiders 1.36.0-insider (c089daa858f34631f5f827ff8a0313bf1e2ded6d, 2019-06-07T06:13:41.194Z)
OS version: Darwin x64 18.6.0
Remote OS version: Linux x64 4.18.0-1014-azure

This happens for all sashes. For example, also between two window groups.

I cannot reproduce, what is special? Tried both with external mouse and touchpad.

Looks like this problem is reproducible if I try to drag edge between editor/panel and webview.
I have no problem with resizing Explorer/SCM etc. if only editors are opened, however when I have Markdown preview, Response preview (REST Client extension), or PR Description (from GitHub Pull request extension).
TL;DR; looks like mouse events (mousemove, mouseup etc.) are lost when cursor is over webview that breaks resizing.
I can freely widen webview (mouse movement will be over editor/panel), but it is really hard to narrow webview (when during resize mouse will be over webview).
I've toggled Screencast mode and circle (that should be around mouse when I press button) stays on the same position on the edge when I move cursor over webview.
Moreover - circle stays visible even when I release mouse button, so when cursor is over editor/panel again (with released button) resizing continues and webview becomes wider.

@bpasero: @IllusionMH is correct. I just came here to file this issue. Simply open the Release Notes in the product, and you won't be able to increase the sidebar size. It seems the webview is eating up the mouse events.
I'll update the original issue steps.

This seems to happen for what I believe are web views. Open the release notes, Markdown Preview, Browser Preview, Github Pull Request description view, etc. in an editor and attempt to resize anything around it (side bar, Terminal, other editors in split view).
Here are some recordings for more context:

https://clips.twitch.tv/PerfectTalentedMilkSwiftRage
https://clips.twitch.tv/OriginalExuberantSaladTheTarFu

https://gist.github.com/deepak1556/899491631e1c7e5e81c4252b6ff91163 is a simple repro without involving vscode. Dragging outside webview element shouldn't cause issues while dragging out eats the events.

@deepak1556 I confirm this is a bug of Chrome, you can reproduce by loading this chrome app in Chrome browser:
https://gist.github.com/zcbenz/67f83babcdee37d7c3ee345bab775737

Thanks @zcbenz , I did a git bisect on chromium using https://www.chromium.org/developers/bisect-builds-py and found the commit that regressed this behavior https://chromium-review.googlesource.com/c/chromium/src/+/1099183/ . I am gonna report it upstream to get the right fix moving forward. But as temporary can we disable mouse capture on <webview> RenderWidgetHost to workaround this issue ?

Reported in https://bugs.chromium.org/p/chromium/issues/detail?id=978162

@mjbvz adding you to see if we can add any workaround to the webview to "fix" this at least until we got the upstream fix.

Another idea from @joaomoreno is to draw a div when mouse-down happens so that we ensure the mouse does not go into the webview during that. We can maybe also play around with pointer-events: none on the webview tag, though I doubt this would have any effect.

I talked with @deepak1556 about this yesterday. We can't entirely block mouse events to webviews without breaking a lot of extensions but we may be able to intercept the events and re-dispatch them into the webview

pointer-events: none does fix stop events on the webview, but it disables scrolling and clicking. Seeing if we can intercept just the click events

Looks like we can't intercept/block click events directly on the <webview> element with addEventListener. Also, we only get mousemove on the <webview> when we move from the main window onto the webview (not continuously)

I have to get going, but I also tried adding an overlay div on top of the webview to intercept events. However I haven't been able to get the re-dispatching back to the webview working yet.

I have prototyped a potential workaround: https://github.com/microsoft/vscode/pull/76148. It works by dispatching synthetic mouse events back to the main window from the webview itself.

I have done some quick testing but nothing extensive. This fix is not perfect and I do not know if this will work in all cases or cause any regressions (especially for more complex webview extensions)

@mjbvz I would be +1 on landing this workaround, worst case scenario if its breaking extensions and we don't have a fix in upstream by then, we could always revert the chromium CL to get back the old behavior without any side effects.

@mjbvz I like that approach as well.

I've merged my workaround. Will continue testing today and get some testing on insiders
@deepak1556 Do you think you will be able to get chromium issue fixed for electron 4 at some point, or are we waiting to upgrade electron versions?

@mjbvz can you open a separate issue with verification needed (possibly across all 3 OS?) so that we get some coverage. I would like to keep this issue for the Electron fix.

Created #76198. High complexity since it is an exploratory item and requires testing multiple extensions. Will find testers and continue testing myself as well

Do you think you will be able to get chromium issue fixed for electron 4 at some point, or are we waiting to upgrade electron versions?

@mjbvz once the fix is available, I will backport it to all version lines electron 4, 5 and 6

Apart from a bit of jank, the workaround works mostly fine here.

Looks like there are cases when resizing webviews (checked Markdown preview and GitHub Pull request description preview) leads to unexpected jumps in size (minimal size for column).
Demo resize-jumps.mp4 (36.3 MB)
Actual cursor position was inside the red circle from Screencast mode.
Reproducible only when shrinking webview from the left border. Similar to https://github.com/microsoft/vscode/issues/76198#issuecomment-506152937, however few times I released mouse in this moment so resulting layout was far from expectations.
Also few times noticed problem described in https://github.com/microsoft/vscode/issues/76198#issuecomment-506074330 but it looks rare.
Overall workaround looks good enough on Windows.

The issue also manifests itself when dragging a scrollbar next to a WebView. Please see mhutchie/vscode-git-graph#153

In VSCODE 1.36.1, "Git History" extension also has the problem that can't drag to resize the webview

@chongchai it's problem of all webviews

Upstream issue has not gained attention in a while, the workaround seems to be fine. Closing this issue in favor of it.


Setting Altered Changes Annotation Colour Order

Changing nothing else apart from the value of altered, the clinical data colouring swaps labels (for WGD but not for the second variable).

This seems unintended.

Hello,
Sorry for the delay in getting back. Can you post your command? Does it happen when you manually provide colours for annotations?

I could not trigger it using a minimal example, so you'll need to load the attached R objects testData.zip The command is
load("testData.RData") # After unzipping.
oncoplot(MAF, colors = customColours, top = 50, showTumorSampleBarcodes = TRUE, removeNonMutated = FALSE,
         clinicalFeatures = c("WGD", "TP53_LOH"), sortByAnnotation = TRUE, sortByMutation = TRUE,
         annotationOrder = c("No", "Yes"), genesToIgnore = "TTN",
         gene_mar = 6, barcode_mar = 11)

Just add altered = TRUE to get the swapping of WGD legend.

Thanks for the data. I can reproduce it. I will take a look into it soon. Meanwhile you can use annotationColor argument to define color codes which should maintain the correct color order.
oncoplot(
  MAF,
  colors = customColours,
  top = 50,
  showTumorSampleBarcodes = TRUE,
  removeNonMutated = FALSE,
  clinicalFeatures = c("WGD", "TP53_LOH"),
  sortByAnnotation = TRUE,
  sortByMutation = TRUE,
  annotationOrder = c("No", "Yes"),
  genesToIgnore = "TTN",
  gene_mar = 6,
  barcode_mar = 11,
  altered = TRUE,
  annotationColor = list(
    WGD = c("Yes" = "red", "No" = "blue"),
    TP53_LOH = c("Yes" = "red", "No" = "blue")
  )
)

Swapping still happens in the latest release of maftools.

Hi,
I'm on holidays. I'll fix them the next week.

Stale but important.

I believe this is still an issue with the latest version.  It is also reversing colors on annotations at baseline.


Problem mocking class types for variable declarations

I need to figure out if this is possible to accomplish. Any comments appreciated. Trying to mock a DSC Resource on a system that does not have SQL Server. Doing that I came across this problem that I have a used specific types for variables. Like the example below, it uses the type Microsoft.SqlServer.Management.Smo.PermissionSetBase.
function Merge-SQLPermissionSet {
    param (
        [Parameter(Mandatory)]
        [Microsoft.SqlServer.Management.Smo.PermissionSetBase[]]
        [ValidateNotNullOrEmpty()]
        $Object
    )

    $baseObject = New-Object -TypeName ($Object[0].GetType())

    foreach ( $currentObject in $Object ) {
        foreach( $Property in $($currentObject | Get-Member -Type Property) ) {
            if( $currentObject.$($Property.Name) ) {
                $baseObject.$($Property.Name) = $currentObject.$($Property.Name)
            }
        }
    }

    return $baseObject
}

I tried to solve that by using a class and adding that as a type (below example is simplified).
$mockPermissionSetBase = @"
    namespace Microsoft.SqlServer.Management.Smo
    {
        public class PermissionSetBase
        {
            public PermissionSetBaset(){}
            public bool MyValue = false;
        }
    }
"@

Add-Type -TypeDefinition $mockPermissionSetBase

But this does not work since that type will only exist during runtime, not during parsing, giving me syntax errors (missing types in variables declarations).
Adding it as a PowerShell class does not work either since it classes does not support namespaces.
The only way I see past this is to use [Object]. But would really like to keep the types as-is.
@mbreakey3 do you have any feedback on this?

Okay, so this was be being a noob :) I got this working. Brought out the old C# knowledge and got this working.
Sorry friends.

@johlju Check out the SharePointDSC resource as this is one where they do a lot of mocking within the DSC tests for on the Appvayor builds where SharePoint won't be installed either.
I would also recommend getting in touch with @BrianFarnhill for more background questions as I know that SharePoint has alot of similar reliance on the object types as SQL will do too though I know in SharePointDSC they don't mock the object the same way as you are looking to do so.

I can definitely help with this - I wrote a blog post about how we did it for SharePointDsc - happy to get involved here to help implement something similar for xSqlServer as well (I'm working with a colleague on contributing to this resource at the moment anyway!)

Thanks for all the feedback! Really appreciate how we help each other out.
@BrianFarnhill i checkout your blog post and also I glanced at the SharePointDsc resource, and the way you did stubs. Unfortunately in SQL Server we are lacking a lot of cmdlets. What we do have is the 'SMO model'. The .net classes with namespace Microsoft.SqlServer.Management.Smo.
So I needed a way to mock these classes to actually use it as types and methods. First I tried using PowerShell classes but that didn't work since namespaces don't work. I then tried to mock using PowerShell classes using fake class names, and changing the TypeName of the classes for them to look similar. This worked until I got to the point that I hit a function that was using the SMO types in the variable declaration. I tried C# classes in here strings, but at first I didn't get that working. At this point I change all those types to [object] instead, and I filled this issue for some feedback. But that didn't feel good doing that change just to make the test work.
After a good night sleep, and after long evening walk I managed to get it working ;)
I am using a stub file, just like SharePointDsc, but the stub file is a C# file SMO.cs to be able to get intellisense and lower the risk to get errors in the code. See the file in the PR here https://github.com/PowerShell/xSQLServer/pull/53/files#diff-8cfaa2961050d03cd15ee2f21cb0426f.
This stub file is then loaded into the test with Add-Type -Path (Join-Path -Path $script:moduleRoot -ChildPath 'Tests\Unit\Stubs\SMO.cs')
Appreciate more feedback on this. If there is any way to do this even better, lets make those changes.
Reopen this issue for while so we can discuss this.

Reopen this issue for while so we can discuss this.

Was thinking when I coded the mock classes that looping thru entire 'SMO model' and build mock classes and enums might be helpful. These could then be improved with necessary logic.
But that is, if using these mock classes is the right way to go.

Yea so with SharePointDsc we've done a few things when we need to implement specific objects as opposed to mocking PowerShell cmdlets.
The first is that we do the Add-Type thing with some stubs for some of them where we needed an object that we don't really care what we do with it - like our search topology ones, we need an object with a specific type name/namespace but other than that its just properties on an object, so we mock those out like this:
Add-Type -TypeDefinition "public class AdminComponent { public string ServerName { get; set; } public System.Guid ComponentId {get; set;}}"

That sort of thing we could automate the generation of pretty easily - load the required assemblies then get objects and namespaces and iterate through those. I would be saving those out to a .cs file and then importing that in rather than coding them in directly like we do here.
The second thing we do where we need to return specific things from methods on those objects is spin them up in PowerShell like this:
            New-Object Object |
                Add-Member NoteProperty TypeName "User Profile Service Application" -PassThru |
                Add-Member NoteProperty DisplayName $testParams.Name -PassThru |
                Add-Member NoteProperty ApplicationPool @{ Name = $testParams.ApplicationPool } -PassThru |
                Add-Member ScriptMethod GetType {
                    New-Object Object |
                        Add-Member ScriptMethod GetProperties {
                            param($x)
                            return @(
                                (New-Object Object |
                                    Add-Member NoteProperty Name "SocialDatabase" -PassThru |
                                    Add-Member ScriptMethod GetValue {
                                        param($x)
                                        return @{
                                            Name = "SP_SocialDB"
                                            Server = @{ Name = "SQL.domain.local" }
                                        }
                                    } -PassThru
                                ),
                                (New-Object Object |
                                    Add-Member NoteProperty Name "ProfileDatabase" -PassThru |
                                    Add-Member ScriptMethod GetValue {
                                        return @{
                                            Name = "SP_ProfileDB"
                                            Server = @{ Name = "SQL.domain.local" }
                                        }
                                    } -PassThru
                                ),
                                (New-Object Object |
                                    Add-Member NoteProperty Name "SynchronizationDatabase" -PassThru |
                                    Add-Member ScriptMethod GetValue {
                                        return @{
                                            Name = "SP_ProfileSyncDB"
                                            Server = @{ Name = "SQL.domain.local" }
                                        }
                                    } -PassThru
                                )
                            )
                        } -PassThru
            } -PassThru -Force

Now the benefit here is that we can control in PowerShell what gets returned from specific methods, which is a plus. We can also do things like set global variables inside the ScriptMethods so we can poll those to check that the methods were called (because we can't do an Assert-MockCalled on those). Now we could come up with some approaches like this that would work as well assuming you don't rely on the GetType() method in your code at all (because the type will be different), but it would be more complex to generate these. Currently we write these up by hand in our mocks (because we also want them to return different things under different contexts) and I would recommend that the same approach be taken here for the places that you need them.
Things like enums are a no brainer - we can script those up to a cs file and import those, but I think we need to do some careful thinking about how you want to implement the other objects that you will actually interact with in your tests to make sure you set yourself up for better success.

Okay so you just use [Object] instead of the actual class names. Do you ever use any classes with their namespace as types?
Like below where Microsoft.SqlServer.Management.Smo.ServerPermissionSet is used in the first function as both parameter type and getting properties of the type, and in the second function the type is used both in the parameter declaration and as a local variable.
Full resource code here
function Get-SQLPermission
{
    [CmdletBinding()]
    [OutputType([String[]])]
    param (
        [Parameter(Mandatory,ParameterSetName="ServerPermissionSet",HelpMessage="Takes a PermissionSet which will be enumerated to return a string array.")]
        [Microsoft.SqlServer.Management.Smo.ServerPermissionSet]
        [ValidateNotNullOrEmpty()]
        $ServerPermissionSet
    )

    [String[]] $permission = @()

    if( $ServerPermissionSet ) {
        foreach( $Property in $($ServerPermissionSet | Get-Member -Type Property) ) {
            if( $ServerPermissionSet.$($Property.Name) ) {
                $permission += $Property.Name
            }
        }
    }

    return [String[]] $permission
}

function Get-SQLServerPermissionSet
{
    [CmdletBinding()]
    [OutputType([Object])]
    param
    (
        [Parameter(Mandatory,ParameterSetName="Permission",HelpMessage="Takes an array of strings which will be concatenated to a single ServerPermissionSet.")]
        [System.String[]]
        [ValidateNotNullOrEmpty()]
        $Permission,

        [Parameter(Mandatory,ParameterSetName="ServerPermissionSet",HelpMessage="Takes an array of ServerPermissionSet which will be concatenated to a single ServerPermissionSet.")]
        [Microsoft.SqlServer.Management.Smo.ServerPermissionSet[]]
        [ValidateNotNullOrEmpty()]
        $PermissionSet
    )

    if( $Permission ) {
        [Microsoft.SqlServer.Management.Smo.ServerPermissionSet] $permissionSet = New-Object -TypeName Microsoft.SqlServer.Management.Smo.ServerPermissionSet

        foreach( $currentPermission in $Permission ) {
            $permissionSet.$($currentPermission) = $true
        }
    } else {
        $permissionSet = Merge-SQLPermissionSet -Object $PermissionSet
    }

    return $permissionSet
}

How would you go about this? Mock the type using New-Object Object ... like you did above, and replace these types from the code with [object]? Or is there a better solution?
Or should we focus not to use types like this?
You are somewhat into the notion of a .cs file. Is that the right way if we need to use classes with namespaces as types like here to create the as C# in a .cs file? Like I did see code here.
To be able to 'mock the right state' I had to make a constructor that sets a variable to remember the state, see _generateMockData in the class Server. I imagine this will become a problem depending of what needs to be mocked. You can't add parameters to a method. When I wrote the C# code I thought that eventually it might be necessary with some "global variable" in the class that knows if it should mock data or not.
// smo.cs
namespace Microsoft.SqlServer.Management.Smo
{
    public class Globals
    {
        public static bool GenerateMockData = false;
    }
....
    public class Server
    {
        ....
            if( Globals.GenerateMockData ) {
                Microsoft.SqlServer.Management.Smo.ServerPermissionSet[] permissionSet = {
                    new Microsoft.SqlServer.Management.Smo.ServerPermissionSet( true, false, false, false ),
                    new Microsoft.SqlServer.Management.Smo.ServerPermissionSet( false, true, false, false ),
                    new Microsoft.SqlServer.Management.Smo.ServerPermissionSet( false, false, true, false ),
                    new Microsoft.SqlServer.Management.Smo.ServerPermissionSet( false, false, false, true ) };

                listOfServerPermissionInfo.Add( new Microsoft.SqlServer.Management.Smo.ServerPermissionInfo( permissionSet ) );
            } else {
                listOfServerPermissionInfo.Add( new Microsoft.SqlServer.Management.Smo.ServerPermissionInfo() );
            }
        ....
    }
}

# Tests.ps1
Mock -CommandName Get-SQLPSInstance -MockWith {
    [Microsoft.SqlServer.Management.Smo.Globals]::GenerateMockData = $true

    $mockObjectSmoServer = New-Object Microsoft.SqlServer.Management.Smo.Server
    $mockObjectSmoServer.Name = "$nodeName\$instanceName"
    $mockObjectSmoServer.DisplayName = $instanceName
    $mockObjectSmoServer.InstanceName = $instanceName
    $mockObjectSmoServer.IsHadrEnabled = $False
    $mockObjectSmoServer.MockGranteeName = $principal

    return $mockObjectSmoServer
} -ModuleName $script:DSCResourceName -Verifiable

Ps. I would have loved to use PowerShell classes if they supported namespaces. That would have been awesome to get C# like coding and PowerShell efficiency at the same time. Ds.

@BrianFarnhill I generated stub files for SQLPS and SQLServer modules using the code on your blog. I change it a bit to get the formatting as close as possible. The stub files are included in the PR #98.
Question: Where do you keep this "helper" function to generate a new stub file in the SharePoint resource? I expect the new SQL Server module to change frequently so it will be needed to run this now and again. So I think I need to put this in a good place for anyone to run.
Modified "helper" function to generate stub module file:
function Write-ModuleStubFile {
    param
    (
        [Parameter( Mandatory )]
        [System.String] $ModuleName,

        [Parameter( Mandatory )]
        [System.String] $StubPath
    )

    Import-Module $ModuleName -DisableNameChecking -Force

    $SPStubContent = ( ( get-command -Module $ModuleName -CommandType 'Cmdlet' ) | ForEach-Object -Process {
        $signature = $null
        $command = $_
        $endOfDefinition = $false
        $metadata = New-Object -TypeName System.Management.Automation.CommandMetaData -ArgumentList $command
        $definition = [System.Management.Automation.ProxyCommand]::Create($metadata)
        foreach ($line in $definition -split "`n")
        {
            if( $line.Contains( '})' ) )
            {
                $line = $line.Remove( $line.Length - 2 )
                $endOfDefinition = $true
            }

            if( $line.Trim() -ne '' ) {
                $signature += "    $line"
            } else {
                $signature += $line
            }

            if( $endOfDefinition )
            {
                $signature += "`n   )"
                break
            }
        }

        "function $($command.Name) {`n$signature`n`n    throw '{0}: StubNotImplemented' -f $`MyInvocation.MyCommand`n}"
    } ) | Out-String

    foreach ($line in $SPStubContent.Split([Environment]::NewLine)) {
        $line = $line -replace '\[Microsoft.SqlServer.*.\]', '[object]'
        $line = $line -replace 'SupportsShouldProcess=\$true, ', ''

        $line | Out-File $StubPath -Encoding utf8 -Append
    }
}

Closing this. I think it is obsolete now. We are long past this now. :) Thanks all!


0.4.5 Draft version misbehaves in "new way"

Intention

I'm submitting a bug report
Environment

Project name
contact-manager-materialize
Project path:
C:\work\tests\Monterey-testing-10062016\contact-manager-materialize
NodeJS:
6.5.0
NPM:
3.10.8
Electron:
1.4.3
Chrome:
53.0.2785.113
Operating system:
win32
Project is using NPM
Package.json path:
C:\work\tests\Monterey-testing-10062016\contact-manager-materialize\package.json
Project is using Aurelia-CLI
aurelia.json path:
C:\work\tests\Monterey-testing-10062016\contact-manager-materialize\aurelia_project\aurelia.json

Description
Current behavior:
Using the default workflow for this application, the app built correctly. Click on the displayed URL results with

I assigned this problem to some Monterey build (CI TRavis) issue and decided not to promote the draft. My conclusion is based on the finding that even the simplest app (skeleton-esnext) crashes identically 😏 .

this is unrelated to the changes we have made. https://github.com/electron/electron/issues/7519 indicates that this is an issue in electron 1.4.3, what is used in monterey v0.4.5. We should try and lock down the version of electron to prevent this from happening again


Security: Stop RocksDB or tokio calling unexpected code when zebrad exits

Motivation
Fix warnings coming from C++(most probably rocksdb) that are displayed sometimes when Ctrl-C is executed to exit zebrad.
Solution
Bug Fix:

Wait for RocksDB background tasks to finish before exiting
Use the tokio runtime to shutdown (remove quick fix introduced in #3091)
Add a timeout to tokio runtime of 20 seconds max to shutdown
Shut down the same way during normal operation and debug_stop_at_height tests
Log when shutting down

Testing:

Add a shell script that checks Zebra for shutdown errors

Closes #3133.
Review
@teor2345 and i both worked on it but anyone can review.

I opened https://github.com/oxarbitrage/zebra/pull/164 with some fixes and a test script. It's based on this PR.
I would be happy to merge https://github.com/oxarbitrage/zebra/pull/164 or whatever you think is best here.

@mergifyio update

@mergifyio refresh

@mergifyio update


not dank enough, needs more threads

I propose dynamically spawning threads from x to y to truly unleash the full potential of this crate. 🚀

Threads go zoom


DRAFT: mesa: 24.0.5 -> 24.1.0-rc1

Description of changes
This is a draft made in preparation for 24.1.0.
Update mesa from 24.0.5 to 24.1.0-rc1
Changelog: not available yet
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Host machine cpu family: x86
Host machine cpu: i686
Checking for size of "void*" : 4

meson.build:308:3: ERROR: Feature intel-rt cannot be enabled: Intel Ray Tracing is only supported on x86_64

so that means we're building a 32bit mesa?

Please test cross, it's very likely broken currently.

Please test cross, it's very likely broken currently.

sure, which build host + target combo exactly ?

x86_64-linux to aarch64-linux, with Intel drivers enabled.

I tried building an sd-card aarch64 image on an x86_64 host, with the i915 module enabled:
error: builder for '/nix/store/hb2vr3wnh3390fws613cvbvy1jv7q2cx-linux-aarch64-unknown-linux-gnu-6.6.28-modules-shrunk.drv' failed with exit code 1;
       last 25 log lines:
<<<cut for brevity>>>
       > root module: i915
       > modprobe: FATAL: Module i915 not found in directory /nix/store/fvhlhq4rqm30pcfz7lj302f34x8h86b4-linux-aarch64-unknown-linux-gnu-6.6.28-modules/lib/modules/6.6.28
       For full logs, run 'nix log /nix/store/hb2vr3wnh3390fws613cvbvy1jv7q2cx-linux-aarch64-unknown-linux-gnu-6.6.28-modules-shrunk.drv'.
error: 1 dependencies of derivation '/nix/store/5z4j2pvk4gfm4h62i0hkb6rddvnjwwaw-initrd-linux-aarch64-unknown-linux-gnu-6.6.28.drv' failed to build
error: 1 dependencies of derivation '/nix/store/14zdz42wzycqnihnj99xspvys0hk7hb8-nixos-system-sd-card-24.05.20240425.37af7a6.drv' failed to build

Do you mind if I take over this PR? I have existing knowledge for this.

https://github.com/NixOS/nixpkgs/pull/306791


put does not work without metadata

put implementation does not work correctly.
https://github.com/markusahlstrand/cloudflare-kv-storage-rest/blob/e11e0e37d27b1b9acc08e09b0934216782061548/src/index.js#L128-L139
Write key-value pair with metadata always require metadata value.
I have received following response when put("key", "value") without metadata.
{
  "result": null,
  "success": false,
  "errors": [
    {
      "code": 10047,
      "message": "multipart put request does not contain required form field 'metadata': '%!s(\u003cnil\u003e)'"
    }
  ],
  "messages": []
}

So, I think that the following conditional logic is required.
  async put(key, value, options = {}) {
    const { expiration, expirationTtl, metadata } = options;

    const url = this.getUrlForKey(key);
    const searchParams = new URLSearchParams();

    if (expiration) {
      searchParams.append('expiration', expiration);
    } else if (expirationTtl) {
      searchParams.append('expiration_ttl', expirationTtl);
    }

    const headers = {
      'X-Auth-Email': this.authEmail,
      'X-Auth-Key': this.authKey,
    };

    url.search = searchParams.toString();

    if (!metadata) {
      // https://api.cloudflare.com/#workers-kv-namespace-write-key-value-pair
      // eslint-disable-next-line no-undef
      const response = await this.fetch(url.toString(), {
        method: "PUT",
        headers: { ...headers },
        body: value
      });
      return response.ok;
    } else {
      // https://api.cloudflare.com/#workers-kv-namespace-write-key-value-pair-with-metadata
      // eslint-disable-next-line no-undef
      const formData = new this.FormData();
      formData.append("value", value);
      formData.append("metadata", JSON.stringify(metadata));
      // eslint-disable-next-line no-undef
      const response = await this.fetch(url.toString(), {
        method: "PUT",
        headers: { ...formData.getHeaders(), ...headers },
        body: formData
      });
      return response.ok;
    }
  }

Published version 1.0.2 in npm with your fix for this issue. Also reduced the size of the package, which I hope didn't break anything..

Interesting :) My code that used this npm-lib stopped working after the update, because I was using https://www.npmjs.com/package/formdata-node instead of https://www.npmjs.com/package/form-data. Looks like form-data is a more complete implementation and after switching it works fine.

Thanks for the quick response!
My module works fine after updating.


bugfix/ajax

Connection with issue(s)
Some Ajax calls are intercepted and broken.
I got an issue on iOS where some ajax call made by iframes were not working. On Android these iframes are well working.
Hard to share something because it didn't produce any logs...
After comparing your iOS and Android implementation I saw a difference in code. I copy and paste so the same logic done in Android into iOS and magic, it's works !
The logic that I took from Android for iOS :
var w = (window.top == null || window.top === window) ? window : window.top;
w.FLAG_VARIABLE_FOR_SHOULD_INTERCEPT_AJAX_REQUEST_JS_SOURCE

Testing and Review Notes

Screenshots or Videos

To Do

[x] double check the original issue to confirm it is fully satisfied
[x] add testing notes and screenshots in PR description to help guide reviewers
[x] request the "UX" team perform a design review (if/when applicable)

@pichillilorenzo  please check :)
We use this PR in production since 1 month, it works well.

@EArminjon How can I use your branch to build my app. because when I try to use I get an error PlatformWebViewEnvironmentCreationParam not found in webview_environment.dart.
I tried to add as

@EArminjon How can I use your branch to build my app. because when I try to use I get an error PlatformWebViewEnvironmentCreationParam not found in webview_environment.dart. I tried to add as
flutter_inappwebview:
  git:
      url: 'https://github.com/EArminjon/flutter_inappwebview.git'
      path: 'flutter_inappwebview'
      ref: 'master'

Your issue is not linked to my PR.

@EArminjon How can I use your branch to build my app. because when I try to use I get an error PlatformWebViewEnvironmentCreationParam not found in webview_environment.dart. I tried to add as
flutter_inappwebview:
  git:
      url: 'https://github.com/EArminjon/flutter_inappwebview.git'
      path: 'flutter_inappwebview'
      ref: 'master'

Your issue is not linked to my PR. Clear your cache, pub-cache etc.

Yeah, I tried everything but still, it gives me the same error. Can you please check if Am I adding your branch correctly in pubspec.yaml

You can base your pubspec on the pr commit instead.

If you don't mind can you share your pubspec part of adding flutter_inappwebview?

I used a custom bitbucket repo with multiple PR merged inside. I can't share.
I believe something like that should work : (i used the PR commit)
flutter_inappwebview:
    git:
      url: https://github.com/pichillilorenzo/flutter_inappwebview.git
      ref: c4dfe6d0f64c64bf645d664711675ed5dcee2944

@EArminjon @pichillilorenzo  But It needs to pass the path also right? without that it gives an error
Could not find a file named "pubspec.yaml" in https://github.com/EArminjon/flutter_inappwebview.git c4dfe6d0f64c64bf645d664711675ed5dcee2944.
And once I pass the path it starts giving error
../../AppData/Local/Pub/Cache/git/flutter_inappwebview-c4dfe6d0f64c64bf645d664711675ed5dcee2944/flutter_inappwebview/lib/src/webview_environment/webview_environment.dart:12:14: Error: Type 'PlatformWebViewEnvironmentCreationParams' not found.
    required PlatformWebViewEnvironmentCreationParams params,

@EArminjon @pichillilorenzo  But It needs to pass the path also right? without that it gives an error
Could not find a file named "pubspec.yaml" in https://github.com/EArminjon/flutter_inappwebview.git c4dfe6d0f64c64bf645d664711675ed5dcee2944.
And once I pass the path it starts giving error
../../AppData/Local/Pub/Cache/git/flutter_inappwebview-c4dfe6d0f64c64bf645d664711675ed5dcee2944/flutter_inappwebview/lib/src/webview_environment/webview_environment.dart:12:14: Error: Type 'PlatformWebViewEnvironmentCreationParams' not found.
    required PlatformWebViewEnvironmentCreationParams params,

Check again my quote code, I didn't use the same repo...

@EArminjon Thanks for the prompt reply But I am using your branch like this
flutter_inappwebview:
  git:
    url: https://github.com/EArminjon/flutter_inappwebview.git
    path: 'flutter_inappwebview'
    ref: c4dfe6d0f64c64bf645d664711675ed5dcee2944

this gives me an error when I try to build
../../AppData/Local/Pub/Cache/git/flutter_inappwebview-c4dfe6d0f64c64bf645d664711675ed5dcee2944/flutter_inappwebview/lib/src/webview_environment/webview_environment.dart:12:14: Error: Type 'PlatformWebViewEnvironmentCreationParams' not found.
    required PlatformWebViewEnvironmentCreationParams params,

@EArminjon Thanks for the prompt reply But I am using your branch like this
flutter_inappwebview:
  git:
    url: https://github.com/EArminjon/flutter_inappwebview.git
    path: 'flutter_inappwebview'
    ref: c4dfe6d0f64c64bf645d664711675ed5dcee2944

this gives me an error when I try to build
../../AppData/Local/Pub/Cache/git/flutter_inappwebview-c4dfe6d0f64c64bf645d664711675ed5dcee2944/flutter_inappwebview/lib/src/webview_environment/webview_environment.dart:12:14: Error: Type 'PlatformWebViewEnvironmentCreationParams' not found.
    required PlatformWebViewEnvironmentCreationParams params,

Check my example, I didn't use my repo.

Yeah I tried with both even with @pichillilorenzo repo also I am getting the same error Using this as
flutter_inappwebview:
   git:
     url: https://github.com/pichillilorenzo/flutter_inappwebview.git
     ref: c4dfe6d0f64c64bf645d664711675ed5dcee2944
     path: 'flutter_inappwebview'

Getting the same error
../../AppData/Local/Pub/Cache/git/flutter_inappwebview-c4dfe6d0f64c64bf645d664711675ed5dcee2944/flutter_inappwebview/lib/src/webview_environment/webview_environment.dart:12:14: Error: Type 'PlatformWebViewEnvironmentCreationParams' not found.
    required PlatformWebViewEnvironmentCreationParams params,
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../AppData/Local/Pub/Cache/git/flutter_inappwebview-c4dfe6d0f64c64bf645d664711675ed5dcee2944/flutter_inappwebview/lib/src/webview_environment/webview_environment.dart:19:9: Error: Type 'PlatformWebViewEnvironment' not found.
  final PlatformWebViewEnvironment platform;


Contributed Libraries versions !?

can you specify the lib versions you were using also the version of the ESP8266 ?
is it 2.4.2 or later or already 2.5.x ?
lot have changed since a year ago.
im trying to downgrade everything as for October last year but still I cant get it compiled
also the versions of Adafruit_GFX and Adafruit_ILI9341 library seem to be crucial
thnx
Helmar

@helmarw...give me a day or two and I will note the library and core versions I used when I compiled this last year.  Looking at the error messages, I assume you are probably correct in that a newer version of either the Adafruit GFX or ILI9341 libs has broken something.  This is not the first time that a change Adafruit has made to their display libs has caused an incompatibility with previously compiled code.

Great! thnx a lot!
Best
Helmar

@helmarw...added current versions of contributed libs and core (including the IDE I use) to the README (I am using Windows, BTW).  Hope this helps.  I was able to recompile this version using the most up-to-date ESP8266 Weather Station code from ThingPulse.  At some point I will post a newer version of the code with much-improved error handling; just need a few more hours in the day ;).

thnx!!! ill give it a try...

thnx, looks like its working :)))

@helmarw...looking good!  Though, it appears you are missing the large icon for the current weather conditions.  Did you clear all flash when uploading and go through the ESP data upload step to reload all the icons into flash?  Also make sure you set aside 3M for the SPIFFS file system, otherwise, all the icon files may not fit into flash.

i don't know how the seen should look like, was happy that is displays anything ;)
yes i cleared the cache when uploading and i choose 3M as well
and when starting it the first time it downloaded quite while the icons i presume...
what could be the problem ?!

now an icon just popped up "light rain"
i think it was broken clouds befor, maybe that one is missing ?

Did you run the ESP8266 Sketch Data Upload tool referenced in step 10 of the Quick Start in the README before the first run, after clearing SPIFFS?  This tool should now be an integral part of the IDE and doesn’t need to be separately downloaded as described in the Quick Start (at least under the Windows version).  This is what actually loads the correct icons.
If you run the code without this step, it has a fallback (part of the very original code from squix78 that I left in) that downloads icons from his website if they don’t exist in SPIFFS).  I probably should have removed this code, as the original icons no longer match up to all the weather conditions.  So, if you saw these being downloaded on first run, then you have an older and incomplete set of icons.
I’d recommend going back to the Data Upload tool and running it again and watching the output in the IDE monitor to make sure the current icon set (located in the /data directory) get loaded.  You shouldn’t have to clear or format SPIFFS manually as I believe the data upload tool now does this step before uploading the contents.
It looks like you are close, but you should always see a large icon to the left of the current temperature matching the weather conditions.

oki, i ran the ESP Uploader, still raining here, ill see if things are changing.
on an other note, I've a couple of DHT22 left, but when im reading to your code im not sure
if its working or not, on some note is said no on other just uncomment to get it work
can you shed some light on it ?

The original code from squix78 (many generations back) contained support for a local temperature measurement using a DHT sensor.  When I forked his code several years ago, I did not have one and just commented out the code.  So, the original code is still there, but I have not tested it and frankly would be surprised if it worked without some rework of the code.  I am also not sure if this is supported any longer in ThingPulse’s current code.

oki thnx

added a few tweaks to get the DHT22 working
you can check the results at my fork of your code

Ah, nice work on this @helmarw, thanks for sharing.  If it’s okay with you, I’ll mention your fork in the README.

yes please no problem ;)
thnx

the shield i made is working to of the box
https://github.com/helmarw/ESP8266-Color-Weather-Station-v17/blob/master/WeMOS_ILI9341_Shield/working_WeMos-ILI9341-Shield.png?raw=true
you can order it here if you need it: https://aisler.net/p/PJPTKIIB

Ah, very nice packaging @helmarw!  I’ve been tempted several times to make my own PCB’s for various projects, but have not done so yet.  Just the old fashioned way, with thru-hole components and lots of soldering on a breadboard ;).

yes thats what i do a lot too, but since i discovered aisler, for small pcb its really worth it ordering,
3pcs for usually less than 20€
not even worth the time sitting in front of a cnc at work and milling it myself


Adding Note Functions

Description
Can the following note types be added:

Foot notes: notes placed at the bottom of the pages
Side notes: notes related to the page content, grouped in the left or in the right of the page, alongside the text area
End notes: notes grouped together in one place at the end of a document or at the end of a section of the document
Marginal notes: notes that are placed to one side of a page or both sides at the exact vertical position of the note reference number
Column footnotes: footnotes that can be placed according to the column in which they are located
Multiple notes area: not for pages that share footnotes, margin notes, column footnote, etc.

I borrowed the descriptions from https://pagedjs.org/posts/notes-about-notes/
Use Case
Publications generally require notes.
Discussion: https://github.com/typst/typst/discussions/1335

Footnotes are already in 0.4.
The question is, how many of these should be part of the base language, versus delegated to a package? I think all of them, apart from column footnotes, are achievable already.

Maybe in a standard library.

column footnotes

If the whole page consists of columns, the footnotes are automatically in the columns. I doesn't work right now if there's a one-column header row, but I intend to fix that.

If they are in a library, could the various kinds of notes be "first-class" objects?
By this I mean, could labels be attached to them for cross-references like "see footnote 4" or "see the footnote on p.17"?

@rmolinari I think this should be made possible.

If they are in a library, could the various kinds of notes be "first-class" objects?

Right now, cross-references integrate badly with non-built-in elements, but that will definitely change in the future.

This would be great. Maybe one nice way to implement this would be to have one note function, with a style argument, which can be set as necessary (i.e. to foot, margin, side, end, etc.). More specific functions could then be defined in terms of this.

Just want to bump this to show that there is still interest in this feature. I would love something similar to footnotes, but in the margins. The drafting package enables margin notes, but it has issues such as overlapping or failure-to-converge that the footnote command does not. I would personally like this so that I can do tuft-style citations in the margins


[qat] Add group fake quant for 8da4w weights

Stack from ghstack (oldest at bottom):

-> #126

Summary: This commit adds quant primitives for grouped per
channel weight fake quant. These primitives simulate the
numerics of their PTQ counterparts as closely as possible,
skipping the dtype conversion and adding a STE backward pass
to get valid gradients.
Test Plan:
python test/quantization/test_qat_quant_primitives.py -k test_fake_quantize_per_channel_group
python test/quantization/test_qat_quant_primitives.py -k test_group_fake_quantize_tensor_symmetric
Reviewers: jerryzh168, cpuhrsch, HDCharles
Subscribers: jerryzh168, cpuhrsch, HDCharles, supriyar

@andrewor14 - you have to change the base to main to get CI

Actually I'll just add this directly in fbcode for now since we don't have automatic syncs. We'll move everything to torchao in the future. Closing this for now.


CredSSP tests fail on Server 2019

Test fails at:
https://github.com/PowerShell/PowerShell/blob/d9c2e0e712361bd91f661f6bf6a010c01d2eac0a/test/powershell/Modules/Microsoft.WSMan.Management/CredSSP.Tests.ps1#L46-L63
with error:
Expected regular expression 'The machine is configured to allow delegating fresh credentials to the following target(s):wsman/*' to match 'The machine is not configured to allow delegating fresh credentials.', but it did not match.

This seems to be an issue in the testing platform.

Does Enable-WSManCredSSP really work on Windows Server 2019?

This fails in our release runs all the time. No regression. Not a blocker.


Exception has occurred. ""AwesomeController" not found. You need to call "Get.put(AwesomeController())" or "Get.lazyPut(()=>AwesomeController())""

NOTE: Exception has occurred.
AwesomeController" not found. You need to call "Get.put(AwesomeController())" or "Get.lazyPut(()=>AwesomeController())

example:

import 'package:flutter/material.dart';
import 'package:get/get.dart';
import 'package:getx/controllers/AwesomeController.dart';

class MyApp extends GetView<AwesomeController> {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: Text('${controller.title}')),
    );
  }
}

Can anyone tell me why Getview is not working its showing this error , i have also this contoller
import 'package:get/get.dart';

class AwesomeController extends GetxController {
  final String title = 'My Awesome View';
}

Help

Did you heed the Exception message, i.e. do you Get.put or lazyPut an instance of the controller somewhere before using the view?

Did you heed the Exception message, i.e. do you Get.put or lazyPut an instance of the controller somewhere before using the view?

No I just you like that example, because i saw that example on getx package on pub.dev

Where are your named routes? and the controller binding?

I was also have this issue
======== Exception caught by widgets library ======================================================= The following message was thrown building AwesomeView(dirty): "AwesomeController" not found. You need to call "Get.put(AwesomeController())" or "Get.lazyPut(()=>AwesomeController())"

Thank you i got this and used
Can you tell me in simple words where we use get.put and where will use lazyput ?
And other question is that when we retrieve data by restapi then which will used for that , lazyput or put?
Kindly tell me. In simple words

you should check status in your controller , (this is my error like this )

I was use clear sample from documentation.

`/// Sample:
class AwesomeController extends GetxController {
final String title = 'My Awesome View';
}
class AwesomeView extends GetView {
/// if you need you can pass the tag for
/// Get.find(tag:"myTag");
@override
final String tag = "myTag";
AwesomeView({Key? key}) : super(key: key){
Get.put(HomePageController());
}
@override
Widget build(BuildContext context) {
return Container(
padding: const EdgeInsets.all(20),
child: Text(controller.title),
);
}
}`
But if add Get.put(HomePageController()); code working correctly.

No that i know my question is that

When we use lazyPut and when we use only put?
Where we use putasync?

Just i want to know in which situation we will use lazyPut and put

No that i know my question is that

When we use lazyPut and when we use only put?
Where we use putasync?

Just i want to know in which situation we will use lazyPut and put

When you use Get.put the class is registered and ready (allocated in the memory) to be be used.
When you use Get.lazyPut the class is registered but is not allocated in the memory yet, it will be allocated when retrieved the first time, when you do:
Get.lazyPut(() => SomeController());
// first time
final SomeController controller = Get.find();
lazyPut might be useful when you have a heavy class (with a lot of code) and you won't need it right when your app is started for example.


add boilerplate stuff from other id guys ;-)

:star: PR built and available in a preview environment drw89-test-domi-pr-2 here

:star: PR built and available in a preview environment drw89-test-domi-pr-2 here

:star: PR built and available in a preview environment drw89-test-domi-pr-2 here


PV-RCNN++ training custom dataset

Hi!
I want to try to use PV-RCNN++ to train my own data. My data is basically organized in the format of the KITTI dataset. The dimensions of the point cloud include (x, y, z, intensity), which appear during the training process. this error:
Traceback (most recent call last):                                                                                | 0/60545 [00:00<?, ?it/s]   File "train.py", line 222, in <module>     main()   File "train.py", line 168, in main     train_model(   File "/mnt/NAS/liuyb/OpenPCDet/tools/train_utils/train_utils.py", line 150, in train_model     accumulated_iter = train_one_epoch(   File "/mnt/NAS/liuyb/OpenPCDet/tools/train_utils/train_utils.py", line 52, in train_one_epoch     loss, tb_dict, disp_dict = model_func(model, batch)   File "/mnt/NAS/liuyb/OpenPCDet/pcdet/models/__init__.py", line 42, in model_func     ret_dict, tb_dict, disp_dict = model(batch_dict)   File "/home/user/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl     return forward_call(*input, **kwargs)   File "/mnt/NAS/liuyb/OpenPCDet/pcdet/models/detectors/pv_rcnn_plusplus.py", line 13, in forward     batch_dict = self.backbone_2d(batch_dict)   File "/home/user/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl     return forward_call(*input, **kwargs)   File "/mnt/NAS/liuyb/OpenPCDet/pcdet/models/backbones_2d/base_bev_backbone.py", line 93, in forward     x = self.blocks[i](x)   File "/home/user/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl     return forward_call(*input, **kwargs)   File "/home/user/anaconda3/lib/python3.8/site-packages/torch/nn/modules/container.py", line 141, in forward     input = module(input)   File "/home/user/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl     return forward_call(*input, **kwargs)   File "/home/user/anaconda3/lib/python3.8/site-packages/torch/nn/modules/conv.py", line 446, in forward     return self._conv_forward(input, self.weight, self.bias)   File "/home/user/anaconda3/lib/python3.8/site-packages/torch/nn/modules/conv.py", line 442, in _conv_forward     return F.conv2d(input, weight, bias, self.stride, RuntimeError: Given groups=1, weight of size [128, 256, 3, 3], expected input[4, 384, 152, 377] to have 256 channels, but got 384 channels instead
I don't know whether I should adjust the configuration of the training model or the process of data processing, please take a look at this issue and eagerly wait for help
Attach pv_rcnn_plusplus.yaml:
`CLASS_NAMES: ['car', 'pedestrian', 'bicycle', 'tricycle', 'cyclist', 'motorcyclist', 'tricyclist',
'van', 'bus', 'truck', 'mini_truck', 'special_vehicle', 'traffic_cone', 'small_movable',
'small_unmovable', 'crash_barrel', 'construction_sign', 'noise', 'water_horse', 'other']
DATA_CONFIG:
BASE_CONFIG: cfgs/dataset_configs/as_dataset.yaml
OUTPUT_PATH: '/mnt/NAS/liuyb/OpenPCDet/model'
MODEL:
NAME: PVRCNNPlusPlus
VFE:
    NAME: MeanVFE

BACKBONE_3D:
    NAME: VoxelBackBone8x

MAP_TO_BEV:
    NAME: HeightCompression
    NUM_BEV_FEATURES: 256

BACKBONE_2D:
    NAME: BaseBEVBackbone

    LAYER_NUMS: [5, 5]
    LAYER_STRIDES: [1, 2]
    NUM_FILTERS: [128, 256]
    UPSAMPLE_STRIDES: [1, 2]
    NUM_UPSAMPLE_FILTERS: [256, 256]

DENSE_HEAD:
    NAME: CenterHead
    CLASS_AGNOSTIC: False

    CLASS_NAMES_EACH_HEAD: [
        [ 'car', 'pedestrian', 'bicycle', 'tricycle', 'cyclist', 'motorcyclist', 'tricyclist',
               'van', 'bus', 'truck', 'mini_truck', 'special_vehicle', 'traffic_cone', 'small_movable',
               'small_unmovable', 'crash_barrel', 'construction_sign', 'noise', 'water_horse', 'other' ]
    ]

    SHARED_CONV_CHANNEL: 64
    USE_BIAS_BEFORE_NORM: True
    NUM_HM_CONV: 2
    SEPARATE_HEAD_CFG:
        HEAD_ORDER: [ 'center', 'center_z', 'dim', 'rot' ]
        HEAD_DICT: {
            'center': { 'out_channels': 2, 'num_conv': 2 },
            'center_z': { 'out_channels': 1, 'num_conv': 2 },
            'dim': { 'out_channels': 3, 'num_conv': 2 },
            'rot': { 'out_channels': 2, 'num_conv': 2 },
        }

    TARGET_ASSIGNER_CONFIG:
        FEATURE_MAP_STRIDE: 8
        NUM_MAX_OBJS: 500
        GAUSSIAN_OVERLAP: 0.1
        MIN_RADIUS: 2

    LOSS_CONFIG:
        LOSS_WEIGHTS: {
            'cls_weight': 1.0,
            'loc_weight': 2.0,
            'code_weights': [ 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0 ]
        }

    POST_PROCESSING:
        SCORE_THRESH: 0.5
        POST_CENTER_LIMIT_RANGE: [ 0.0, -30, -2, 150.0, 30, 4 ]
        MAX_OBJ_PER_SAMPLE: 500
        NMS_CONFIG:
            NMS_TYPE: nms_gpu
            NMS_THRESH: 0.7
            NMS_PRE_MAXSIZE: 4096
            NMS_POST_MAXSIZE: 500

PFE:
    NAME: VoxelSetAbstraction
    POINT_SOURCE: raw_points

NUM_KEYPOINTS: 4096
    NUM_KEYPOINTS: 2048

NUM_OUTPUT_FEATURES: 90
    NUM_OUTPUT_FEATURES: 128
    SAMPLE_METHOD: SPC
    SPC_SAMPLING:
        NUM_POINTS_OF_EACH_SAMPLE_PART: 4000000
        NUM_SECTORS: 6
        SAMPLE_RADIUS_WITH_ROI: 1.6

    FEATURES_SOURCE: ['bev', 'x_conv3', 'x_conv4', 'raw_points']
    SA_LAYER:
        raw_points:
            NAME: VectorPoolAggregationModuleMSG
            NUM_GROUPS: 2
            LOCAL_AGGREGATION_TYPE: local_interpolation

NUM_REDUCED_CHANNELS: 2
            NUM_REDUCED_CHANNELS: 1
            NUM_CHANNELS_OF_LOCAL_AGGREGATION: 32
            MSG_POST_MLPS: [ 32 ]
            FILTER_NEIGHBOR_WITH_ROI: True
            RADIUS_OF_NEIGHBOR_WITH_ROI: 2.4

            GROUP_CFG_0:
                NUM_LOCAL_VOXEL: [ 2, 2, 2 ]
                MAX_NEIGHBOR_DISTANCE: 0.2
                NEIGHBOR_NSAMPLE: -1
                POST_MLPS: [ 32, 32 ]
            GROUP_CFG_1:
                NUM_LOCAL_VOXEL: [ 3, 3, 3 ]
                MAX_NEIGHBOR_DISTANCE: 0.4
                NEIGHBOR_NSAMPLE: -1
                POST_MLPS: [ 32, 32 ]

        x_conv3:
            DOWNSAMPLE_FACTOR: 4
            INPUT_CHANNELS: 64

            NAME: VectorPoolAggregationModuleMSG
            NUM_GROUPS: 2
            LOCAL_AGGREGATION_TYPE: local_interpolation
            NUM_REDUCED_CHANNELS: 32
            NUM_CHANNELS_OF_LOCAL_AGGREGATION: 32
            MSG_POST_MLPS: [128]
            FILTER_NEIGHBOR_WITH_ROI: True
            RADIUS_OF_NEIGHBOR_WITH_ROI: 4.0

            GROUP_CFG_0:
                NUM_LOCAL_VOXEL: [3, 3, 3]
                MAX_NEIGHBOR_DISTANCE: 1.2
                NEIGHBOR_NSAMPLE: -1
                POST_MLPS: [64, 64]
            GROUP_CFG_1:
                NUM_LOCAL_VOXEL: [ 3, 3, 3 ]
                MAX_NEIGHBOR_DISTANCE: 2.4
                NEIGHBOR_NSAMPLE: -1
                POST_MLPS: [ 64, 64 ]

        x_conv4:
            DOWNSAMPLE_FACTOR: 8
            INPUT_CHANNELS: 64

            NAME: VectorPoolAggregationModuleMSG
            NUM_GROUPS: 2
            LOCAL_AGGREGATION_TYPE: local_interpolation
            NUM_REDUCED_CHANNELS: 32
            NUM_CHANNELS_OF_LOCAL_AGGREGATION: 32
            MSG_POST_MLPS: [ 128 ]
            FILTER_NEIGHBOR_WITH_ROI: True
            RADIUS_OF_NEIGHBOR_WITH_ROI: 6.4

            GROUP_CFG_0:
                NUM_LOCAL_VOXEL: [ 3, 3, 3 ]
                MAX_NEIGHBOR_DISTANCE: 2.4
                NEIGHBOR_NSAMPLE: -1
                POST_MLPS: [ 64, 64 ]
            GROUP_CFG_1:
                NUM_LOCAL_VOXEL: [ 3, 3, 3 ]
                MAX_NEIGHBOR_DISTANCE: 4.8
                NEIGHBOR_NSAMPLE: -1
                POST_MLPS: [ 64, 64 ]

POINT_HEAD:
    NAME: PointHeadSimple
    CLS_FC: [256, 256]
    CLASS_AGNOSTIC: True
    USE_POINT_FEATURES_BEFORE_FUSION: True
    TARGET_CONFIG:
        GT_EXTRA_WIDTH: [0.2, 0.2, 0.2]
    LOSS_CONFIG:
        LOSS_REG: smooth-l1
        LOSS_WEIGHTS: {
            'point_cls_weight': 1.0,
        }

ROI_HEAD:
    NAME: PVRCNNHead
    CLASS_AGNOSTIC: True

    SHARED_FC: [256, 256]
    CLS_FC: [256, 256]
    REG_FC: [256, 256]
    DP_RATIO: 0.3

    NMS_CONFIG:
        TRAIN:
            NMS_TYPE: nms_gpu
            MULTI_CLASSES_NMS: False
            NMS_PRE_MAXSIZE: 9000
            NMS_POST_MAXSIZE: 512
            NMS_THRESH: 0.8
        TEST:
            NMS_TYPE: nms_gpu
            MULTI_CLASSES_NMS: False
            NMS_PRE_MAXSIZE: 1024
            NMS_POST_MAXSIZE: 100
            NMS_THRESH: 0.7
            SCORE_THRESH: 0.1

NMS_PRE_MAXSIZE: 4096
NMS_POST_MAXSIZE: 500
NMS_THRESH: 0.85
    ROI_GRID_POOL:
        GRID_SIZE: 6

        NAME: VectorPoolAggregationModuleMSG
        NUM_GROUPS: 2
        LOCAL_AGGREGATION_TYPE: voxel_random_choice

NUM_REDUCED_CHANNELS: 30
        NUM_REDUCED_CHANNELS: 64
        NUM_CHANNELS_OF_LOCAL_AGGREGATION: 32
        MSG_POST_MLPS: [ 128 ]

        GROUP_CFG_0:
            NUM_LOCAL_VOXEL: [ 3, 3, 3 ]
            MAX_NEIGHBOR_DISTANCE: 0.8
            NEIGHBOR_NSAMPLE: 32
            POST_MLPS: [ 64, 64 ]
        GROUP_CFG_1:
            NUM_LOCAL_VOXEL: [ 3, 3, 3 ]
            MAX_NEIGHBOR_DISTANCE: 1.6
            NEIGHBOR_NSAMPLE: 32
            POST_MLPS: [ 64, 64 ]

    TARGET_CONFIG:
        BOX_CODER: ResidualCoder
        ROI_PER_IMAGE: 128
        FG_RATIO: 0.5

        SAMPLE_ROI_BY_EACH_CLASS: True
        CLS_SCORE_TYPE: roi_iou

        CLS_FG_THRESH: 0.75
        CLS_BG_THRESH: 0.25
        CLS_BG_THRESH_LO: 0.1
        HARD_BG_RATIO: 0.8

        REG_FG_THRESH: 0.55

    LOSS_CONFIG:
        CLS_LOSS: BinaryCrossEntropy
        REG_LOSS: smooth-l1
        CORNER_LOSS_REGULARIZATION: True
        LOSS_WEIGHTS: {
            'rcnn_cls_weight': 1.0,
            'rcnn_reg_weight': 1.0,
            'rcnn_corner_weight': 1.0,
            'code_weights': [1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0]
        }

POST_PROCESSING:
    RECALL_THRESH_LIST: [0.3, 0.5, 0.7]
    SCORE_THRESH: 0.5
    OUTPUT_RAW_SCORE: False

    EVAL_METRIC: kitti

    NMS_CONFIG:
        MULTI_CLASSES_NMS: False
        NMS_TYPE: nms_gpu
        NMS_THRESH: 0.7
        NMS_PRE_MAXSIZE: 4096
        NMS_POST_MAXSIZE: 500

OPTIMIZATION:
BATCH_SIZE_PER_GPU: 2
NUM_EPOCHS: 30
OPTIMIZER: adam_onecycle
LR: 0.01
WEIGHT_DECAY: 0.001
MOMENTUM: 0.9

MOMS: [0.95, 0.85]
PCT_START: 0.4
DIV_FACTOR: 10
DECAY_STEP_LIST: [35, 45]
LR_DECAY: 0.1
LR_CLIP: 0.0000001

LR_WARMUP: False
WARMUP_EPOCH: 1

GRAD_NORM_CLIP: 10`

maybe you should change your "POINT_CLOUD_RANGE".

maybe you should change your "POINT_CLOUD_RANGE".
@xuchangjia
I tried changing "POINT_CLOUD_RANGE"， but still getting that error. I debugged the program，and found that the reason for the misalignment of the number of channels is mainly here：

/OpenPCDet/pcdet/models/backbones_2d/map_to_bev/height_compression.py:

The values of these dimensions are obtained through the processing of VoxelBackBone8x (/OpenPCDet/pcdet/models/backbones_3d/spconv_backbone.py)
128 * 3 = 384
pv_rcnn_plusplus.yaml:
MAP_TO_BEV:         NAME: HeightCompression         NUM_BEV_FEATURES: 256
384 != 256
D=3 not 2
How should I adjust this configuration to avoid this error?
If it is convenient, I hope to communicate through WeChat, my WeChat ID: lyb543918165

Did you debug successfully?

Yes， I adjusted the configuration of the training model and it can be trained normally

maybe you should change your "POINT_CLOUD_RANGE".

Can you please explain how the point cloud range relates to the number of features?
I'm having a similar problem and would appreciate any help.

Hi for this point cloud range
POINT_CLOUD_RANGE: [-32.0, -32.0, -3.0, 32.0, 32.0, 40.0]
How do I choose the voxel size ?

    - NAME: transform_points_to_voxels
      VOXEL_SIZE: [0.16, 0.16, 4]
      MAX_POINTS_PER_VOXEL: 50
      MAX_NUMBER_OF_VOXELS: {
        'train': 150000,
        'test': 150000
      }

No matter what I do I get the error :
ValueError: your out spatial shape [0, X, X] reach zero!!! input shape: [1, X, X]


Unresolved dependency: com.thesamet#sbt-protoc;0.99.23: not found

The code had been running fine till March, but now I get this:
sbt.librarymanagement.ResolveException: unresolved dependency: com.thesamet#sbt-protoc;0.99.23: not found
This is the code (scalapb.st):
addSbtPlugin("com.thesamet" % "sbt-protoc" % "0.99.23")

libraryDependencies += "com.thesamet.scalapb" %% "compilerplugin" % "0.9.0"

And, build.properties:
sbt.version = 1.2.8
I tried upgrading the version, but it did not help.

Changed to
addSbtPlugin("com.thesamet" % "sbt-protoc" % "1.0.6")

libraryDependencies += "com.thesamet.scalapb" %% "compilerplugin" % "0.9.0"

And
PB.protocVersion := "3.19.2"

Now, getting this error:
java.lang.NoSuchMethodError: sbt.package$.singleFileJsonFormatter()Lsjsonnew/JsonFormat

Hi Aditya, I am not able to reproduce the problems you are seeing. I have tried creating a new project with sbt new scalapb/scalapb-template.g8 and performed the changes you described in either the original post and int the follow up comment. It compiled successfully both times.


instantsend: Remove islocks for rejected/removed txes

~Based on https://github.com/dashpay/dash/pull/4154 atm~

wouldn't it make sense to add some TODO: Remove later / with version x comment for CInstantSendDb::Upgrade

Not necessarily. You could implement more upgrades later if needed. The actual upgrade is only done once and Read is cheap. I think it's fine to keep it.

maybe add a DB version define instead of the 1

Good point 👍 see 94ec87a

Mac build was not happy because of a missing definition... force-pushed

I believe https://github.com/dashpay/dash/pull/4155/commits/d9d8c0ffcd12fd12a1cecc879e2e237e79a51478 fixed issues I had on one of nodes I run to test this. At least I no longer see unexpected TransactionRemovedFromMempool in debug.log and tx count vs islock count looks sane now.


There are some problems on Abp vnext 5.1.3

Hello.
There are some problems on Abp vnext 5.1.3

Swtich language not working.
The close button of modal is too small.

Thanks

@yincen would you like to contribute this change?


unknown package: isobuild:compiler-plugin

getting the error unknown package: isobuild:compiler-plugin on heroku

Do you still have this issue?  If so, can you give more info about your setup -- ideally, source code for a meteor app that exhibits this issue?

I'm going to close this for now -- please reopen if you think there's an ongoing problem with the buildpack.