Proposal: Solution to reduce/control cargo check times as the codebase grows

Hey! We started hitting pretty long cargo check times as our project grows. I've seen previous thread
about this (783) but regardless of short term fixes, we are
expecting our issues to continue to grow as our project grows.
Ideally we would want to be able to split our graph into multiple libraries and there exists some
way of doing this already:

Splitting it by domains where parts of graph are fully isolated from the other parts
Using MergedObject to hoist up parts of the objects from downstream dependency - this is the preferable method for us.

The first one doesn't really work for us since majority of our graph is fairly interconnected as we
heavily optimize for frontend being able to compose UI pretty easily. Meaning that we end up with a lot
of nodes referring back other nodes in the graph.
Problem
As an example of what I'd like to be able to eventually do is the following (and there's a zip file with this project attached as it probably illustrates the issue better):

Have leaf library define a core part of the object:
In leaf-lib/lib.rs

#[derive(SimpleObject)]
pub struct UserCore {
    pub name: String,
    pub age: i64,
}

Have top-level add necessary connections/fields that leaf library can't:
in main.rs

pub struct UserExtension;

#[Object]
impl UserExtension {
    // you could also just imagine this refers to a node in the graph that the leaf library can't see

    async fn added_field<'ctx>(&self, _ctx: &Context<'ctx>) -> i64 {
        1
    }
}

#[derive(MergedObject)]
pub struct User(UserCore, UserExtension);

PROBLEM: Let's extract another object to a library, it needs to refer to User, so it depends on our leaf-lib. For instance
In middle-lib/lib.rs

pub struct Group;

#[Object]
impl Group {
    async fn users(&self) -> Result<Vec<UserCore>> {
        Ok(vec![])
    }
}

Notice that this object can only refer to UserCore and not User, because User is defined at the top-level as extension.
Expected behavior: What I hoped is this would generate a schema like this:
type Group {
	users: [User!]!
}

type QueryRoot {
	users: [User!]!
	groups: [Group!]!
}

type User {
	name: String!
	age: Int!
	addedField: Int!
}

schema {
	query: QueryRoot
}

but the actual schema will expose that there exist UserCore and Group refers to it:
type Group {
	users: [UserCore!]!
}

type QueryRoot {
	users: [User!]!
	groups: [Group!]!
}

type User {
	name: String!
	age: Int!
	addedField: Int!
}

type UserCore {
	name: String!
	age: Int!
}

schema {
	query: QueryRoot
}

Proposal
Now what I would propose as an enhancement is an API that is similar to MergedObject (or modify MergedObject) to help achieve the proposed. For now let me call this an ObjectExtension:

If an Object is used somewhere where an ObjectExtension is also used, this Object cannot be directly exposed in the schema, and instead its instances will be swapped for whatever the object is extended with.
The limitation of that is that we need to ensure that if FooCore is the core object and FooExtension is the Object we extend with, From<Foo> for FooExtension is true as this will allow
dynamically construct the actual Foo

What you gain as the benefit of that is:

GraphQL schema that can be interconnected as you please without sacrificing frontend usability for technical limitations of the backend.
Ability to split backend into multiple libraries pretty easily in a way that makes schema safe and not leak any internal details.

I've attached a ZIP file with a project example that compiles and can be played with that uses MergedObject - this may illustrate my issue a little bit better, but if it doesn't, please let me know - I'm happy to explain more what I mean. I am also happy to lend a hand with the implementation of something like this if we agree to its usefulness.
The project code
test-async-graphql.zip

This looks useful, but it can be complicated to implement. 🙂

This looks useful, but it can be complicated to implement.

Yeah I agree that full proposal would be pretty tricky. I think the more minimal step towards the full solution would be to provide a flag, or a way of controlling Object to not be part of the schema. If you could write something like this:
pub struct UserCore {
  id: i64
}

#[Object]
#[graphql(is_node = false)]
impl UserCore {
  // .. some fields here
}

And then it is users responsibility to create actual Merge object, such that this part of schema is ever reachable.
Compared to original proposal it eliminates a bunch of complexity - the only thing it tries to say is "This object should never be returned by itself as part of the schema", as it unnecessarily bloats the schema and unveils unnecessarily the implementation details.


Config modules can be used with single type resource

what

Config modules can be used with single type resource - for example just team or alert_policy

why

Defining all modules is not always possible/convenient

/test all


Get-RunspaceData Failed

Hi Jim - Can you pelase advise on this issue attempting to run script against VHDX file on a UNC path
Get-RunspaceData : Failed
Extended information:
The service cannot be started, either because it is disabled or because it has no enabled devices
associated with it.
Activity ID: {017894b9-eb51-45e4-bf22-1b549f350e19}
At C:\Scripts\Invoke-FslShrinkDisk-master\Invoke-FslShrinkDisk.ps1:717 char:13

        Get-RunspaceData -wait

        ~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (StorageWMI:ROOT/Microsoft/...age/MSFT_Volume) [Write-Error],
CimException
FullyQualifiedErrorId : StorageWMI 4,Get-RunspaceData

So this looks like either the defrag or virtual disk service isn't started on the VM you are running the script from

Hi Jim
thanks for feedback
I have attempted to run script against my o365 share and I have many
VHDX reporting this error
Failed to read partition information for disk - "The input name "Type"
cannot be resolved to a property."
Where as many are also processing but I have no idea why the
discrepancy? could you perhaps shed some light on reasons why this
would be the case?
----- Original Message -----
From: "FSLogix/Invoke-FslShrinkDisk"
<EMAIL_ADDRESS>To:"FSLogix/Invoke-FslShrinkDisk"
<EMAIL_ADDRESS>Cc:"sjclarke1965"<EMAIL_ADDRESS>"Author"
<EMAIL_ADDRESS>Sent:Fri, 18 Sep 2020 13:40:12 +0000 (UTC)
Subject:Re: [FSLogix/Invoke-FslShrinkDisk] Get-RunspaceData Failed
(#17)
So this looks like either the defrag or virtual disk service isn't

started on the VM you are running the script from
—

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
Email sent using Optus Webmail
Links:
[1]
https://github.com/FSLogix/Invoke-FslShrinkDisk/issues/17#issuecomment-694873924
[2]
https://github.com/notifications/unsubscribe-auth/AQ7FTBHYLGTMCZIUZVHAOXTSGNPLZANCNFSM4RJ755SA

This is usually the case where the script is being run form an underpowered machine, the default number of threads is 8.
If you are having issues either add more and faster cores, or restrict the thread count to the number of cores you have. If you still see the issue set the throttle limit to 1 and see where that gets you.

thanks Jim
----- Original Message -----
From: "FSLogix/Invoke-FslShrinkDisk"
<EMAIL_ADDRESS>To:"FSLogix/Invoke-FslShrinkDisk"
<EMAIL_ADDRESS>Cc:"sjclarke1965"<EMAIL_ADDRESS>"Author"
<EMAIL_ADDRESS>Sent:Sun, 20 Sep 2020 05:00:53 -0700
Subject:Re: [FSLogix/Invoke-FslShrinkDisk] Get-RunspaceData Failed
(#17)
This is usually the case where the script is being run form an

underpowered machine, the default number of threads is 8.
If you are having issues either add more and faster cores, or

restrict the thread count to the number of cores you have. If you
still see the issue set the throttle limit to 1 and see where that
gets you.
—

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
Email sent using Optus Webmail
Links:
[1]
https://github.com/FSLogix/Invoke-FslShrinkDisk/issues/17#issuecomment-695779109
[2]
https://github.com/notifications/unsubscribe-auth/AQ7FTBBPQBOVOSKOCVEBNI3SGXVHLANCNFSM4RJ755SA


Form Editor Shown Twice

Describe the Bug

Steps to Reproduce

Create a new form
Add a Button form field
Switch to the JSON editor
Change the type to ""
Switch to the form editor
Error is shown
Change the type back to "button"
Change the label to "Submit"
Switch to the form editor
Form editor is shown twice

Expected Behavior

Form editor is only shown once.
Environment

Camunda Modeler Version: 4.9.0

I love that feature. Finally the split screen is there!

I cannot reproduce this issue anymore after integrating form-js 0.2.x (cf. https://github.com/camunda/camunda-modeler/tree/form-js-0.2). So this issue will be fixed once we merge this.

Fixed upstream then, great :muscle:.


I am trying to get sonnet installed I like the idea of some of the configure features but i would like a little more documentation on getting the full featured configured sonnet

I am trying to get sonnet installed I like the idea of some of the configure features but i would like a little more documentation on getting the full featured configured sonnet.
OpenCL and if I can get the ANN in a FPGA would be a great tutorial.
Video tutorials could help cover details.
There are free screencasting linux and windows software.

@josheeg thanks for your interest. To clarify, Sonnet is a higher level framework on top on TensorFlow, so device assignments like OpenCL or FPGA are orthogonal to what Sonnet lets you do. If and when they are supported by TensorFlow, you will be able to use Sonnet modules (containing supported ops) on those devices.
We don't have the engineering bandwidth currently to produce anything like video tutorials (no one works on Sonnet full time, it's all best-effort by people who are primarily on other projects). The rnn_shakespeare example is intended to showcase some of the main features. We'll look into providing more in the future.


Does JPEG Work?

Hi @mykle1 ,
Does JPEG Work? I've tried it and this is what I get:

never mind, figured it out.
JPEG = JPG...


Required for kcp-dev/kcp#2112.

Are you going to do an AST generator for this?

Are you going to do an AST generator for this?

Yes, just preferred that you have a look at https://github.com/kcp-dev/kcp/pull/2112/commits/2e900e70c34b0abdc1d41f50231ff85dc15f9d60 before going forward.

@ncdc I've just added the AST-based generator. Let me know if there is more to do.

@astefanutti thanks! Could you please create commits in this order?

The AST generator by itself
The unmodified output of running the generator (compare to commit 94dc4f4f0f0)
The modifications to the patch file (compare to commit bcfaeb030a9)

@ncdc thanks a lot. I've just re-pushed with commits articulated according to your instructions. Let me know if that doesn't meet your expectations.


🆕 Software Suggestion | Zulip (team chat)

Basic Information
Name: Zulip
Category: Team chat
URL: https://zulip.org/ / https://github.com/zulip
Description
Memtioned in https://github.com/privacytoolsIO/privacytools.io/issues/999#issuecomment-504277267, but not acted upon.

As far as I can tell, Zulip lacks end-to-end encryption. (Their security features are listed here.) That puts it at quite a disadvantage vs. other tools where privacy is concerned.

There doesn't appear to be any reason to choose this over other alt software. I'm down for closing this.
It only has basic security features, nothing noteworthy. Basically it's an open source Slack. ;P


unclear parts of the config

in the config && example config there is an empty paypal struct{} and I am unclear on the mail_subjects. They seem to be documented as a struct with a single field, but the config shows a map[string]string

The paypal struct is a placeholder until we add paypal support.
The mailer part of things still miss a few features. The mail_subjects struct will grow more fields as we start sending more different kinds of mails.


llvm7: replace patch with official upstream commit

Hopefully this also addresses any problems enountered
with the patch used previously.
Motivation for this change
cc #54370
(although this may not fix everything, should fix Optional error)
Same goal as #54122, but uses upstream commit instead of patch from
Debian (which I believe matches upstream's first attempt to fix this as
well).
Basically this was tricky to get right on all compilers,
thankfully it seems to have been sorted out.
Fingers crossed :).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Rustc depends on llvm-7, so the breakage is pretty big. In particular the unstable job won't pass due to inkscape depending on rustc.

Picked to staging-next.


Home page should be in french

one page will be in English but the home page should be in french completely

commit


No parser error for get_node used in "not-onready" variable

Godot version: 4.0 e1e52b373
OS/device including version: Windows 10
Issue description:
No parser error for get_node used in "not-onready" variable.
extends Node2D

var node1 = get_node('Sprite2D')
var node2 = $Sprite2D

Steps to reproduce:
Minimal reproduction project:
N/A

Can't reproduce in 757c151

The regression can be confirmed by looking at #46233 reported in 3.2.

I'd like to work on this. Any pointers on which files to investigate to start with?

@angad-k This is the code from 3.2 branch:
https://github.com/godotengine/godot/blob/9047e760d11f0f606db0e40488e5a84f5d42227f/modules/gdscript/gdscript_parser.cpp#L4971-L4983

Reopening for now as #72487 was reverted.


Text overflow fails with line placement & a textAlign property

Thank you for your interest in making OpenLayers better!
To keep this project manageable for maintainers, we ask you to please check all boxes below before submitting an issue.

[x] I am submitting a bug or feature request, not a usage question. Go to https://stackoverflow.com/questions/tagged/openlayers for questions.
[x] I have searched GitHub to see if a similar bug or feature request has already been reported.
[x] I have verified that the issue is present in the latest version of OpenLayers (see 'LATEST' on https://openlayers.org/).
[x] If reporting a bug, I have created a CodePen or prepared a stack trace (using the latest version and unminified code, so e.g. ol-debug.js, not ol.js) that shows the issue.

Whenever you set placement to line and overflow to true for an ol.style.Text style, a long piece of text will show properly. However, if you add textAlign and attempt to set it to any of the documented values the text will disappear and never render. I'm assuming this is a bug? I need to left-align some text, but when I do, long text (which is user-inputed) disappears.
The codepen below shows the behavior in OL v6.5.0. Simply comment out the textAlign property to have it render properly. Add it back in and it disappears.
https://codepen.io/anon/pen/zjVZwX?editors=0010

BTW, since this is significantly impacting our users, I wouldn't mind submitting a PR if someone could point me in the right direction as to where this issue might originate. No promises I can figure it out, but I'd be willing to look at it--unless it's a quick bug fix for the maintainers.

Actually there is a bug, but none that will solve your issue when fixed. Even with no textAlign set, your text should not be rendered, because it does not fit on any segment of your geometry.
That said, you have two options:

Set maxAngle: Infinity as additonal text style property. With that, your text will be rendered, but will make sharp turns along your geometry.

Configure your style with a custom geometry, which could be the first segment of your geometry.

Actually whether the current behavior is a bug or intentional depends on the interpretation of the overflow property in combination with maxAngle. If overflow means to overflow the path part of a geometry that satisfies the maxAngle restriction (which is a valid assumption), we'd accept a pull request that makes your code pen work.
The code section that causes the current behavior is https://github.com/openlayers/openlayers/blob/26b84f09bd8f958c3dacd8c5abb6b3ae08652973/src/ol/render/canvas/TextReplay.js#L202-L208: it identifies the part of a path that satisfies the maxAngle rule, but only if no textAlign is set (which means determine placement automatically). A pull request would have to change this segment selection process.

Placement:line is not working for linestring to align the text on the line.the text is very large in that case how i need to handle.

@venugopal-rao Try configuring the text style with
{
  overflow: true,
  maxAngle: Infinity
}


Element with negative margin-top don't overlay a img class="responsive-img", z-index not work.

HTML

SCSS
.profile_user {

    &__avatar {

        img {
            margin-top: -50%;
        }
    }

Without the last two row avatar overlap the cover with responsive-img normally. However, without the rows layout breaks .
Tks

Please provide a way to reproduce it. like a codepen or  a snippet
Closed due inactivity, feel free to reopen it if it is still necessary.


Markdown fence is visible before the code block finishes in chat

Testing #217639
It's fast but you can see that briefly the opening fence is visible. This seems to only happen if there was text before the code block: https://memes.peet.io/img/24-06-669a6fa8-fe2d-4eb6-83e0-dd8c785a89ee.mp4
window log

https://github.com/microsoft/vscode/issues/217915


HNC: Delete validateModes() func in HNCConfig reconciler after v1alpha1

Part of #868
validateModes() func is only needed when v1alpha1 is still the storage version of HNCConfig CRD. It should be removed afterwards. See #899

/cc @adrianludwin

Update: this is not added eventually. see https://github.com/kubernetes-sigs/multi-tenancy/pull/902#discussion_r456498425


Shape of links

Links sometimes "wiggle" so that it is not evident what they convey. I attach an example.

New version is ready. Links is more stable.
https://dgrm.net/


Select table records by pivot if needed

Description
If you define allowDuplicates on a BelongsToMany relation manager (the pivot table contains the id), and add a bulk action like DetachBulkAction.
The action runs getSelectedTableRecords with $shouldFetchSelectedRecords set to true.
In that case it always runs the wrong query, because it should use the pivot query.
This pull request should fix that, but im not sure if it could break other things.
I opted for a variable $usePivotQuery to make the if statement more readable, but I can also inline it if you want.

Does
if (
    (! $shouldFetchSelectedRecords) ||
    (! ($table->getRelationship() instanceof BelongsToMany && $table->allowsDuplicates()))
) {

work?
Because otherwise I think this breaks using a BelongsToMany with fetchSelectedRecords(false)

@danharrin should fetchSelectedRecords(false) touch the pivot query part?
Right now the code only executes the pivot query if both the relationship is BelongsToMany and allowsDuplicates is true.
If allowsDuplicates is false but the relationship is BelongsToMany it will still enter the if statement right?

It should make it so the $records is just an array of IDs instead of an array of models

Ah I see! Let me try.

@danharrin works indeed, changed the PR.

Thanks


Accounts per Project (Suitecloud for vscode)

As far as I know the accounts that are configured in Visual Studio Code with "Suitecloud: Set Up Accounts" are global and not project-based.
In my case I am working on many Netsuite platforms. I created separated projects but it is very dangerous to have shared accounts: accidentally I could deploy the file on the wrong Netsuite environment.

This is by design and default authids are set per project.
User can set default account in project.json which doesn't need to be changed whenever you deploy.
What's your suggestion or desired flow?

Thanks Mohammed for your response.
The focus of my issue is not related to the DEFAULT auth ids but rather to the LIST of the available auth ids.
Tipically for each project I'll have two auth ids (one for production, one for sandbox) and I'll change the default depending on the needs.
What in my opinion is very risky is the possibility to choose the default id among all the ids, including those accounts that are not actually related with the current project.
The expected behavior is a list that is filtered by project. I think that this could be achieved by not saving the accounts globally but in a project file instead.
How do you feel about it?
Thanks in advance.

Thanks Mohammed for your response.
The focus of my issue does not concern the default auth ids but the list of the available auth ids.
Tipically I'll have one project and two auth ids (one for production, one for sandbox) and change the default depending on the needs.
What in my opinion is very risky is to choose the default id among all the ids, including those accounts that are not related with current project.
The expected behavior is a restricted list by project. I think that this could be achieved by not saving the accounts globally but in a project file.
Thanks in advance,
Manuel
[ALLYS]http://allys.it/
Manuel TONIATO
SENIOR CONSULTANT
M +39<PHONE_NUMBER> |<EMAIL_ADDRESS>| LinkedInhttps://www.linkedin.com/in/manuel-toniato-61b07a45/
allys.ithttp://allys.it/ | FOLLOW US ON LinkedInhttps://www.linkedin.com/company/allysrl/
[Powered by Altea Federation]http://www.alteafederation.it/

Da: Syed Mohammad Ali @.>
Inviato: mercoledì 16 marzo 2022 23:23
A: oracle/netsuite-suitecloud-sdk @.>
Cc: Manuel Toniato @.>; Author @.>
Oggetto: Re: [oracle/netsuite-suitecloud-sdk] Accounts per Project (Suitecloud for vscode) (Issue #542)
This is by design and default authids are set per project.
User can set default account in project.json which doesn't need to be changed whenever you deploy.
What's your suggestion or desired flow?
—
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foracle%2Fnetsuite-suitecloud-sdk%2Fissues%2F542%23issuecomment-1069696372&data=04|01|mtoniato%40alteanet.it|a3c4262c9bb94c3c65bd08da079b956c|a248a8b3ddc049da9a7070c77203e1d7|1|0|637830662050273821|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=oF5FNjXXfUocs47H3%2F%2FX2ANMLZx4fFrwqyxISnwGqMg%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAXWJLMGNYUMWC6FEIL2HA7DVAJNNVANCNFSM5OX542PA&data=04|01|mtoniato%40alteanet.it|a3c4262c9bb94c3c65bd08da079b956c|a248a8b3ddc049da9a7070c77203e1d7|1|0|637830662050273821|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=u7dLTO5ef%2BqQ7Ho0IzEpMZrU1kK0h8QnnfrO0%2BSoG8k%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|mtoniato%40alteanet.it|a3c4262c9bb94c3c65bd08da079b956c|a248a8b3ddc049da9a7070c77203e1d7|1|0|637830662050273821|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=duk1Q0f2DSzwZY75s%2Fbi4FM%2BMCVnv%2BmrBS7nl4IR2eY%3D&reserved=0 or Androidhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|mtoniato%40alteanet.it|a3c4262c9bb94c3c65bd08da079b956c|a248a8b3ddc049da9a7070c77203e1d7|1|0|637830662050273821|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=XjxdpfGNdwRyHrZg6mlOndlUuRDJxXZQWo%2B40ojyZSE%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

@mtoniato This is very unique concern. Usually the authids should be descriptive enough to identify the account name etc.
But I understand the concern, But this will require some more investigation because these credentials are not just used in VSCode but all the tools in SuiteCloud ecosystem (Suitecloud plugin for WebStorm, SDF CLI, SuiteCloud cli for NodeJS etc).
So we will wait for more cases on this and if we reach a sufficient amount of votes we can consider it for an enhancement.

I agree the account list should be (at least optionally) a project-specific list.


Skip testPitCreatedOnReplica IT with remote store

Description
Mute testPitCreatedOnReplica test causing a higher gradle check failures in recent runs. Based on issue description and linked PRs which failed, it seems it is failing mostly on 2.x branch.
Related Issues
Related #https://github.com/opensearch-project/OpenSearch/issues/8850
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/20947/
CommitID: 72377d3
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

https://github.com/opensearch-project/OpenSearch/issues/5031


test: Use assert_matches! less

There are downsides to assert_matches!:

Extra dependency/import
Reduced linting - see several cases here where converting to assert!(matches!(...)) lead to clippy noticing that the match could be converted to .is_ok() or .is_some()
Increased chance of accidents, see #1006 (preliminary to this)

Hence, this PR adopts the policy of "use assert_matches only when it's useful". Specifically, that means only when we can use
assert_matches!(SUBJECT, PATTERN => assert!(EXPR))

(and while we're at it, where EXPR is an equality, use assert_eq!), rather than
assert!(matches!(SUBJECT, PATTERN if EXPR))

because the former gives better error messages in case of failure.
(This is quite a small advantage, and noting the increased chance of accidents, one could also say - let's not use assert_matches at all....I'd be happy to do that, too.)

The value of assert_matches is in the error messages. Compare
let x = None;
assert!(matches!(x, Some(42)));
// thread 'test::test_assert' panicked at src/lib.rs:14:9:
// assertion failed: matches!(x, Some(42))
// note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

with
let x = None;
assert_matches!(x, Some(42));
// thread 'test::test_matches' panicked at src/lib.rs:8:9:
// assertion failed at src/lib.rs:8: `(value does not match pattern)`
//   value: None
// pattern: Some(42)

In this case, matching against a pattern instead of doing .is_ok() is the intended behaviour.
I agree that adding statements on the matched branches is error-prone. I'm happy with banning those.

I'm closing this PR since seem to have agreed on the status quo.
Feel free to reopen it if you want to continue the discussion.


(Duplicate) Request to add --xml option

Added option to wrap file contents in a <files><file path=""></file>...</files> xml structure since that appears to be friendlier to Claude
Coding done by Claude 3.5 Sonnet

Just noticed there's already a PR  -- #15 -- for the same thing. Feel free to close.


[BUG] Starfall and E2's :acfCaliber() function always returns 0 when used on missile racks

Branch and Version
Latest version, master branch
How to Reproduce
Spawn this Starfall chip on any ACF Missiles rack:
--@server
print(chip():isWeldedTo():acfCaliber())

It will always print 0, even if the rack is currently loaded. Same result for its E2 equivalent:
print(entity():isWeldedTo():acfCaliber())

Using it on the ammo crate the rack is linked to instead will give the correct result.

this is an ACF3 Missiles thing btw

wasn't sure whether to post it here or on missiles, I'm not sure if it's an issue with ACF missiles racks themselves or the starfall functions used to access their caliber.

It's fine here. The issue comes from racks not storing any bullet data from the selected missile on themselves, which should be fairly simple to solve.


loam init: replace soroban-sdk dep with loam-sdk

In Cargo.toml file created in new project, we need to specify loam-sdk, not soroban-sdk. We also need to specify loam-subcontract-core (though maybe someday we will re-export this from loam-sdk).
We also need to make sure this works with soroban contract init, which seems more tricky! Go ahead and explore how we might want to approach this and make a suggestion or two!

some notes as I research this:

stellar contract init -f <fe-template-url> does not overwrite the base init template Cargo.toml with the fe template's Cargo.toml.

At the moment this makes sense, for soroban-astro-template since it is basically the same as the base init Cargo.toml file (except that soroban-astro-template's soroban-sdk version is a bit out of date and probably should be updated).
This doesn't work for loam init (which is running stellar init under the hood) because it keeps stellar contract init's Cargo.toml which has soroban-sdk as it's only workspace dep and we need loam-sdk

Idea: Overwrite or merge the Cargo.toml files from the FE template and the base init template.

The easiest place to make this change is in stellar contract init. Does this make sense for other FE template scenarios? Or do we need to find a way to do this in loam instead? 🤔

@chadoh could you say a bit more about what you mean when you say that this should also work with soroban contract init? Do you mean that we will want to be able to pass our loam frontend template to soroban contract init like this: soroban contract init ./test-project -f https://github.com/loambuild/frontend?

Do you mean that we will want to be able to pass our loam frontend template to soroban contract init like this: soroban contract init ./test-project -f https://github.com/loambuild/frontend?

Yes, exactly.

Idea: Overwrite or merge the workspace Cargo.toml file from the FE template and the base init template.

I think this is what we should probably do for now. Seems more straightforward than the backend template idea.
Note that loambuild/frontend is set up to develop on the dev branch, and push everything to main via a GitHub action that uses the publish.sh script. I actually thought Cargo.toml and Cargo.lock were in that script, but it looks like we forgot them. Which is good news for this task, since you'll want both Cargo.toml files there. We should still probably circle back and remove Cargo.toml from soroban-astro-template at some point.

One way we can solve this is by creating a loam-specific examples repo, and requiring that loam init uses those examples instead of https://github.com/stellar/soroban-examples

Yes, this is one of the milestones for our next grant cycle! Haven't made an issue for it yet, but we definitely want that. If you use stellar contract init you would still end up with stellar/soroban-examples, but if you use loam init then you would get loam examples.

Actually, merging the Cargo.toml files is tricky. And we're not really sure if other people will want it. It's hard to justify from the Stellar CLI side.
Also, if you use stellar contract init and get example contracts from stellar/soroban-examples, then you don't need a different Cargo.toml. You only need it with loam init, because that gives you example contracts that use Loam SDK.
So let's just do this on the Loam side. When you run loam init, it needs to manually overwrite Cargo.toml with the one we want, which should probably come from the frontend repo, but could be embedded in Loam CLI the same way the examples are, for now.

Actually, merging the Cargo.toml files is tricky. And we're not really sure if other people will want it. It's hard to justify from the Stellar CLI side.

It is tricky. The naive way I spiked it out in https://github.com/AhaLabs/stellar-cli/pull/24 was to just always overwrite the existing workspace Cargo.toml with the frontend template's Cargo.toml... but that doesn't seem right because as you said we aren't sure that other people actual want that. I think that circling back and removing the Cargo.toml from soroban-astro-template would be good - just to reduce confusion. (#future-todo) <- just a reminder for myself to add an issue
Ok, so I'll plan to do this on the loam side:

one way would be to re-clone the FE template repo, and then overwrite the existing workspace Cargo.toml file (we need to re-clone it, because soroban contract init cleans it's temp file up after it finishes).
Or, we can just expect that the workspace Cargo.toml file will have soroban-sdk as a workspace dep, and replace that with loam-sdk and add loam-subcontract-core. Though this isn't real elegant, and may be brittle, it is probably the most straightforward way for now. Especially since we know that the workspace Cargo.toml will always have soroban-sdk in it, unless https://github.com/stellar/stellar-cli/blob/main/cmd/soroban-cli/src/utils/contract-init-template/Cargo.toml.removeextension#L8 changes

Note that loambuild/frontend is set up to develop on the dev branch, and push everything to main via a GitHub action that uses the publish.sh script. I actually thought Cargo.toml and Cargo.lock were in that script, but it looks like we forgot them. Which is good news for this task, since you'll want both Cargo.toml files there.

Ah, thank you for that reminder. I think that the Cargo.toml and Cargo.lock files are included still, since we have the wildcard there... but I'll double check.

wip prs:

https://github.com/loambuild/frontend/pull/5
https://github.com/loambuild/loam/pull/120

I'll test and clean these up tomorrow.


AuditLoader 4.2.0

label逻辑优化，避免在K8s容器化部署时label超长导致导入失败
SQL指纹异常处理
where过滤功能，支持在plugin.conf中配置审计信息入库过滤条件（格式参考stream load中header的where格式）
增加字段pendingTimeMs，即查询在队列中等待的时间（毫秒）

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.WuMenglong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add functionality to BAM module

Hi, I would like to share with you some work I did for the BAM module.
I added:

Other parameters to the BamChatModel;
Embedding and Tokenization APIs;
Some tests

@andreadimaio do you mind addressing the CI issue?
Once CI is green we can merge and release.
Thanks

@geoand, yes I will fix it for the end of day. I have in mind also to commit some little changes to the code.

Cool, thanks

@geoand you can find the last changes in the 54e7f57

I rebased and force pushed the PR in order to a new clean CI run


add Metaverse

hi @ehsueh @smdmitry
How was this resolved? I am curious to know since the PR is still open
thank you


What model to use to replicate results of the Epic Kitchen paper?

Hi,
i want to reproduce your experiment of action recognition from the Epic Kitchen paper. I am struggling to understand what model you used among those provided by torchvision, i.e.,
inceptionresnetv2.lua
inceptionv3.lua
inceptionv4.lua
Thanks and best regards,
Giovanni

"We used https://github.com/yjxiong/tsn-pytorch modified to have two output layers, one for verbs and one for nouns. We use pytorch, not torch."
Yes that is clear, i have modified that code to have the two output layers, one for verbs and one for nouns, as you suggested.
My problem is to understand how to load the pretrained model to put in the variable base_model in TSN(nn.Module).

We used BNInception with ImageNet weights.

Many thanks.


Clone and install DT in publisher

The other things we run don't seem to actually need the installed state so the memory FS is probably fine. So this is a targeted fix specifically for publishing.

Verified locally:


.info fails to retrieve any info as it produces IndexError

Hi,
I have noticed that the module fails to retrieve info for certain stocks(symbols) even though they are clearly available on the yahoo finance page. They all return an Index error as shown below:
Python 3.7.6 (default, Dec 30 2019, 19:38:28)
[Clang 11.0.0 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import yfinance as yf
>>> my_stock = yf.Ticker("MMM")
>>> my_stock.info
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.7/site-packages/yfinance/ticker.py", line 138, in info
    return self.get_info()
  File "/usr/local/lib/python3.7/site-packages/yfinance/base.py", line 415, in get_info
    self._get_fundamentals(proxy)
  File "/usr/local/lib/python3.7/site-packages/yfinance/base.py", line 286, in _get_fundamentals
    self._institutional_holders = holders[1]
IndexError: list index out of range

Here are a few stocks that I have tried that currently fail: MMM, CVX, XOM, JPM, MRK, TRV, UNH, VZ
Does anybody have any idea why this happens only for certain stocks? Does the yahoo finance page load differently for different stocks? If not, is there a bug in the .info functionality? It seems like perhaps an assumption was made to get the second index self._institutional_holders = holders[1], does this need to be handled properly?
Thanks!

Hey there,
I've added a "try" error handler for these cases in my fork, I've just tested and it seems to be working. I highly recommend uninstalling yfinance before doing so.
pip uninstall yfinance
pip install git+https://github.com/rodrigobercini/yfinance.git

Same here. Any chance to fix it?

This happens for me as well - I avoid it using try + exception
However, this is just so the script can continue to the next ticker
What occurs effectively is that information is Lost!
Any chance this can be fixed? Or any solution known?

I fixed this:
In lines 286..294 simply replace as follows:
       if len(holders) > 1:             self._institutional_holders = holders[1]             if 'Date Reported' in self._institutional_holders:                 self._institutional_holders['Date Reported'] = _pd.to_datetime(                     self._institutional_holders['Date Reported'])             if '% Out' in self._institutional_holders:                 self._institutional_holders['% Out'] = self._institutional_holders[                     '% Out'].str.replace('%', '').astype(float)/100
The root cause is that the holders ist may be empty (length of 1)

Fix + Pull Request here:
https://github.com/asafravid/yfinance

Thank you for your fixes guys! I dont know if the repo owner will merge these changes or not. They seem inactive for this repo. Not sure why. This is such a useful project.

But they've just release a new version last week - definitely active
And definitely a tremendous and useful project
I would leave the fix open


NonPrintableCharacterFixer - fix for backslash and quotes when changing to escape sequences

Fixes #4663 and replaces #4664.
Ping @mvorisek as reporter and @ivan1986 as the original author for review.

For me it seems like it does not handle backslashes correctly:
$content = "'\\\\\\\\'";
var_dump($content);

$content = str_replace("\\'", "'", $content);
$content = preg_replace('/([\\\\$])/', '\\\\$1', $content);
var_dump($content);

Yes, need add tests
            [
                <<<'EXPECTED'
<?php echo "\\\u{200b}\"";
EXPECTED
                ,
                sprintf(<<<'INPUT'
<?php echo '\\%s"';
INPUT
                 , pack('H*', 'e2808b')),
            ],
            [
                <<<'EXPECTED'
<?php echo "\\\u{200b}'";
EXPECTED
                ,
                sprintf(<<<'INPUT'
<?php echo '\\%s\'';
INPUT
                 , pack('H*', 'e2808b')),
            ],

for check double slashes, it's fail now, or add slashes into exist tests

For me it seems

@mvorisek take an example from @ivan1986 - presenting test case is much more valuable.
@ivan1986 added yours 2 - thanks - and few more for backslashes.

For me it seems

@mvorisek take an example from @ivan1986 - presenting test case is much more valuable.
@ivan1986 added yours 2 - thanks - and few more for backslashes.

@kubawerlos Yes, but I hope I helped!

Thank you @kubawerlos.


[languageserver] Update to Cadence v1.0.0-preview.25

Description
Automatically update to:

onflow/cadence v1.0.0-preview.25
onflow/flow-go-sdk v1.0.0-preview.25
onflow/flow-go v0.34.0-crescendo-preview.18
onflow/flow-emulator v1.0.0-preview.22
onflow/cadence-tools/lint v1.0.0-preview.16
onflow/cadence-tools/test v1.0.0-preview.15
onflow/flowkit/v2 v2.0.0-stable-cadence-alpha.17

Guess because of the Go version bump to 1.21 we need to update npm-packages/cadence-language-server/src/go.js again 🙄

No idea why the Go 1.21 breaks the WASM LS. From 1.20 to 1.21, something seems to have changed about timeouts. I tried a few things but no luck :/

All tests actually pass. What causes the CI failure is that after all tests have run, the test suite's shutdown function notifies the LS to exit, which calls os.Exit. Somehow this causes a timing issue starting in Go 1.21.
Will merge and we'll need to address this in a follow-up.


New bike shed paint: mvn formatter:format -pl testsuite

I set up a formatter, it reflowed everything not wrapped in  //@formatter:off and now I don't know whether I like it or not. Do we need it?
It's the contemporary Quarkus one + longer lines.
It does not touch the test apps, just the test code.
Perhaps we just keep the xml file for IDE?
mvn formatter:format -pl testsuite

and now I don't know whether I like it or not

IMO there is no real need to reformat everything (and will only make things harder to track through git log/blame). I would prefer to have the new formatter in and reformat only edited lines as we go.
Also note that I see some changes (e.g. the removal of tests for older Mandrel versions) that don't seem to be from the reformat, and would prefer to have them in a separate commit.


[on NextJS SSR] the material ui's style tags are broken when the page is updated

Hi! Thanks for the great UI library, material ui.
I met a problem with NextJS SSR and Material UI, and I don't know how to solve it.
Actually, this may not be an error or bug, but I write this issue because I didn't get a proper answer in stackoverflow.
Sorry for this.
My initial material ui style rules are broken when the page is updated,
because the additional style tags are injected at the end of head.(These are even duplicated class style rules.)
How do I solve this?
For more detail information, you could check the stackoverflow post.
Thank you!

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When the page is update, the specific component pairs break the each style rules.
Expected Behavior 🤔
The Material UI's component UI should be displayed properly on any update.
Steps to Reproduce 🕹
Steps:

start the page via NextJS with Material UI's Button, Switch and etc.
update the page that includes Material UI's Checkbox.
the style tags are injected at the end of head, and it makes the Button and Switch component's UI wrong.

Context 🔦

Your Environment 🌎
framework
"next": "^9.5.3",
other tools
"styled-components": "^5.1.1",
version
"@material-ui/core": "^4.11.0",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "^4.0.0-alpha.56",
"@material-ui/pickers": "^3.2.10",

Please provide a minimal reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point (they have Next.js templates) Thank you!

facing the same issue and this thread is not helping

@ManzoorKapri Are you using v5?


Adding rest of Trigger integration tests for Python, PS, JS

We are hitting the 90 minute timeout in the build pipeline. I'll be looking into how to speed up our test runs before merging this PR in.


suddenly not working and shows directory listing only.

Hi,
Simple web server suddenly not working and shows directory listing instead. Please have a look.

Could you please confirm that the option to automatically show index.html is enabled?

Hi, it doesn't matter automatically show index.html turned on or off.

@ethanaobrien Could you please take a look at this? Notice how the directory listing page says "Index of /index.html/"

@terreng
Yep I see that. I'll take a look

just found if i create "index": true on C:\Users\xxx\AppData\Roaming\Simple Web Server\config.js it works. but still do not know i did solve - i did this as i found below
function alldone(results) {
if (this.app.opts.index) {

I found the bug, give me a second

OK

@WebScaffolder Thanks for your help in finding these bugs, we really appreciate it.


MultiSelect.Filterable invalid: true styling bug.

Detailed description

While using <MultiSelect.Filterable> component with invalid={true} the style of bottom shadow has a bug. Here is couple of screenshots:

Here you can see that red box shadow also has blue color over it.

You can see it even better when input field used for filtering inside MultiSelect is focused
That's all because of bx--text-input style.
Normal state: while bx--multi-select has data-invalid="true", bx--text-input which is inside still has box-shadow: 0 1px 0 0 #5a6872;
Focus state: box-shadow: 0 2px 0 0 #3d70b2; for .bx--text-input:focus which causes the bug.
Steps to reproduce the issue

Open sandbox - https://xrmwxlyo5w.codesandbox.io/
Observe the bug
?????
You are awesome

I am not sure what should be the behavior of filtering input, should it has shadow etc.
But as a workaround you can use:

.bx--list-box[data-invalid] .bx--text-input {
box-shadow: none !important;
}

Seems to be solved in v10.

@emyarod this one come up again?

no it can probably be safely closed since this is a v9 issue, but I left it open until the v10 multiselect gets merged in


Remove health-check from DNS policy

As the health checks will be delivered in a separate piece of work, this part of the DNS Policy API now has no affect, so it should be removed to prevent a misleading API.

This is in the wrong repo, but also now irrelevant since we will be creating provider health checks


VE-787 VE-792 enable "public_did" in connection invitations

And probably there is some problem with python too https://ci.evernym.com/job/Indy SDK CI/view/change-requests/job/PR-1301/1/execution/node/1740/log/


Trying to get in touch regarding a security issue

Hey there!
I'd like to report a security issue but cannot find contact instructions on your repository.
If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.
Thank you for your consideration, and I look forward to hearing from you!
(cc @huntr-helper)

@JamieSlome you should do full disclosure, the time has passed

@psmoros (cc)

Last commit was 5 years ago, I doubt someone will reply.

I can't find Nick's email anywhere... If you find it feel free to privately reach out otherwise you can just as well open a public issue

I would really say go full disclosure, ethjs-util is used all over the ecosystem - and keeping the vuln closed endangers users

Agreed! Sorry I thought you were the original author of the report. We will triage it internally and take a decision soon :)


Allow inputting number and boolean types into the inputs of a block.

Allow the types in the inputs array in Block's constructor to include boolean and number which then get detected and turned into strings by calling .toString() on them.

Same goes for putting booleans into Variable.withValue().


Move proto/authorization_proto to api/type

Technically authorization_proto is an internal only type. Maybe it doesn't belong in the api directory.
On the other hand, it's a pure type and fits nicely in the type_proto package.

Codecov Report

Merging #884 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #884   +/-   ##
=======================================
  Coverage   48.87%   48.87%
=======================================
  Files          34       34
  Lines        2351     2351
=======================================
  Hits         1149     1149
  Misses        998      998
  Partials      204      204

Impacted Files
Coverage Δ

impl/authorization/authorization.go
92.3% <ø> (ø)
:arrow_up:

core/keyserver/keyserver.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf15fa...b826a5a. Read the comment docs.


Move QNN and TransformedModule

Move to qadence_libs.models.
Maybe also move the current Overlap? It inherits from QuantumModel.

[ ] In ./module for ml_tools
[ ] Migrate tests
[ ] Add libs.py

Hey @jpmoutinho how much of this is necessary for #12 especially for the QNN ? I guess we need to coordinate with @smitchaudary at some point.

It seems to me like #12 builds on top of QNN we can move forward with an MR for that and then later it would just be a matter of changing from qadence.models import QNN to from qadence_libs.models import QNN right?


elixir-ls now recognizes umbrella projects

Previously, elixir-ls would treat each sub-project within an umbrella as
standalone, which isn't desirable from a language server perspective.
Added ale#handlers#elixir#FindMixUmbrellaRoot, which locates the current
project's root and then continues searching upwards for a potential
umbrella project root. This literally looks just two levels up to keep
things simple while keeping in line with Elixir project conventions.
Use this new function to determine elixir-ls's LSP project root.

There are some conflicts here to fix now.

There are some conflicts here to fix now.

Resolved.


Added the word "updates"

Added the word "updates" in use-the-service-connection-tool.md
Fixes #998

Thanks for acknowledging @aczechowski


Blacklist Region - Puerto Rico

Puerto Rico is listed as a country and a region under the US.  I'm not sure if this should be changed in the data file, or if some users might have a reason to use both variations.  We are using this for export purposes, so we only want the country of Puerto Rico listed, and not the state under the US.  Would it be possible to add the ability to blacklist a specific region in a country?  I have already removed it from my data file, but I am looking at a better solution for when there are updates released in the future.

That is what I was trying to ask for.  I wanted the ability to blacklist regions in a country, so that I don't have to touch the data file.


LINK-1648 | 2/3 Attendance list page action buttons

Description
Adds action menu dropdown to attendance list page. At the moment attendance menu dropdown contains only a button to open signups page. There will be also a button to download signups as an excel file
This one of the 3 PRs that will implement signups page. PRs are splitted to following parts:

MenuDropdown component (https://github.com/City-of-Helsinki/linkedregistrations-ui/pull/95)
Attendance list page action buttons

Partially closes
LINK-1648
Screenshot

Codecov Report

Merging #96 (18d1ea8) into develop (51d5dd7) will increase coverage by 0.02%.
The diff coverage is 99.61%.

@@             Coverage Diff             @@
##           develop      #96      +/-   ##
===========================================
+ Coverage    99.64%   99.67%   +0.02%
===========================================
  Files          151      159       +8
  Lines         2820     3053     +233
  Branches       455      502      +47
===========================================
+ Hits          2810     3043     +233
  Misses          10       10

Files
Coverage Δ

...rc/common/components/menuDropdown/MenuDropdown.tsx
100.00% <100.00%> (ø)

src/common/components/menuDropdown/menu/Menu.tsx
100.00% <100.00%> (ø)

...mmon/components/menuDropdown/menuItem/MenuItem.tsx
100.00% <100.00%> (ø)

src/domain/app/layout/titleRow/TitleRow.tsx
100.00% <100.00%> (ø)

src/domain/attendanceList/AttendanceListPage.tsx
100.00% <100.00%> (+2.70%)
:arrow_up:

src/domain/registration/permissions.ts
100.00% <100.00%> (ø)

...registration/registrationInfo/RegistrationInfo.tsx
100.00% <100.00%> (ø)

src/domain/registration/utils.ts
100.00% <100.00%> (ø)

src/hooks/useClickOrFocusOutside.ts
100.00% <100.00%> (ø)

src/hooks/useDropdownKeyboardNavigation.ts
100.00% <100.00%> (ø)

... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


But I don't think the Appreciation List is very good. I think bloggers are short of money

感觉很不错，但是希望可以深挖，加油！

深挖是一定的，博主也确实也穷


NPM GUI not visible after docker installation

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Describe the bug
NPM container, afte re-deployed, is not accessible via GUI.
Nginx Proxy Manager Version
2.9.11
To Reproduce
Steps to reproduce the behavior:

Create NPM container with Let's Encrypt certificate inmported via GUI
Delete current container + db container + all volumes
Recreate container
GUI not acessible anymore

Expected behavior
Login page available
Screenshots

Operating System
Docker image jc21/nginx-proxy-manager:latest - on ARM64
Additional context

Using portainer for container management
In logs of NPM container, following error logs are seen repeatedly.

nginx: [emerg] cannot load certificate "/etc/letsencrypt/live/npm-2/fullchain.pem": BIO_new_file() failed (SSL: error:02001002:system library:fopen:No such file or directory:fopen('/etc/letsencrypt/live/npm-2/fullchain.pem','r') error:2006D080:BIO routines:BIO_new_file:no such file)

Mentioned path is not present in the container. Instea, file fullchain.pem is present in folder npm-3
[root@docker-7bcf1f8b1d19:/app]# ls -ltr /etc/letsencrypt/live/npm-3/
total 4
lrwxrwxrwx 1 root root  32 Nov  1 10:39 privkey.pem -> ../../archive/npm-3/privkey1.pem
lrwxrwxrwx 1 root root  34 Nov  1 10:39 fullchain.pem -> ../../archive/npm-3/fullchain1.pem
lrwxrwxrwx 1 root root  30 Nov  1 10:39 chain.pem -> ../../archive/npm-3/chain1.pem
lrwxrwxrwx 1 root root  29 Nov  1 10:39 cert.pem -> ../../archive/npm-3/cert1.pem
-rw-r--r-- 1 root root 692 Nov  1 10:39 README

[root@docker-7bcf1f8b1d19:/app]# ls -ltr /etc/letsencrypt/live/
total 8
-rw-r--r-- 1 root root  740 Nov  1 10:03 README
drwxr-xr-x 2 root root 4096 Nov  1 10:39 npm-3

I am not sure if something wrong done from my side as I am relatively new to this. Thanks is advance.

After copying content of npm-3 to npm-2, it started working.

How is there even any data if you have deleted all volumes? Are you sure you haven't just deleted a certificate which was used in the proxy host and haven't updated the proxy host?

I had used portainer to delete the nginx deployment(which deleted contianers for npm and db). Assuming that volumes were persisted, how does directory name change?

I can't think of a way the directory names could have been automatically changed. That's why I'm trying to rule out other possibilities first, like a certificate used four your proxy host 2 which was later deleted and a different certificate uploaded, but proxy host 2 was never updated to use that new certificate.


Ensure "test end" is emitted on uncaught test error

There are edge cases where mocha will emit test suite "end" signal
when encountering uncaught error but the responsible test already passed.
https://github.com/mochajs/mocha/blob/master/lib/runner.js#L837
This makes karma-mocha complete the suite right away wit exit code 0
although maybe only half of the tests ran.
Mocha properly emits a "fail" test event before "end" but it seems like
the code expects a "test end" to properly report the test as failed.
This makes sure to emit a "test end" within karma-mocha on "fail" when
the test is marked with uncaught errors.

I signed it!

@zapo Thank you very much for the PR. It helped us in our project to detect previously unreported errors. I  wish some of the maintainers would integrate it into the official release. Many thanks for your effort and time.


Remove phpseclib from composer.json because of conflict with league/filesystem-sftp-v3

Hello,
In this project phpseclib is listed as a dependency. This library isn't used in the whole project.
Also this causes issues with the https://github.com/thephpleague/flysystem-sftp-v3 which requires phpseclib ^3.0.
Thanks in advance!

Tests are currently failing because of issues with the database in CI. I need some help with that.

Anyone any idea why the tests are failing?


Add some structured VDO's and the capability to send a response to a discover identity VDM

Working on a patch to add some VDOs and a way to reply to discover identity from upstream.

Some of the messages are already in the pdo.rs file from the last stuff I added.  Should I move this to a vdo.rs file?

@bentwire Go for it, unless you think it makes sense to have a shared module, with sibling vdo and pdo modules?

I guess it would depend on the use case.  What would the shared module be named?
BTW I get some activity when I send an ack back to the DiscoverIdentity my laptop sends, so I think at least that works.
I can't send a discover identity to the laptop and get a response however...  Maybe its not supposed to work that way... Still kinda fuzzy on who SOP' SOP'' SOP''' are...  I get good CRC back  though so maybe my laptop just does not support the command...

messages/
    mod.rs
    vdo.rs
    pdo.rs

Hmm, I assumed that would always have a response from the other side. Also not sure about the start of packet tokens, I'll need to re-read the spec.

@fmckeogh  Finally had a chance to do the merge and test your embassy branch.  It seems to work really well if you want to make the change official.
Also let me know where you want the message refactoring I did to go.

@bentwire Yeah for sure, glad it works for you, I burnt out the dev setup so going to try build a new one haha
Does your PR include the merge of the embassy branch? Or would you prefer I merge that in first, then you can rebase your message refactoring on top? I'm happy either way, thanks so much for your work:)

@fmckeogh   The PR I just created is to merge the vdo changes I made with your embassy branch.
I've not rebased anything to main yet.   Was not sure what order you wanted to do.
Hey no problem, its been fun :)

Closed by #12


Rework % mem use / limit to use memory wss values

If we examine a pod in the current  /General/Perf/Container Utilization/% mem used over limit chart we can see the usage as:

However if we open the /General/Kubernetes/Compute Resources/Pod graph the usage is much much much less:

In
/General/Perf/Container Utilization/Mem
the attribute used is:
container_memory_usage_bytes
In
/General/Kubernetes/Compute Resources/Pod
the attribute used is:
container_memory_working_set_bytes
Overall, we cant use the /General/Kubernetes/Compute Resources/Pod because I want to compare all compute sessions that run overnight overlaid on top of each other, and it would take to long to go through them one by one.
We would instead prefer the /General/Perf/Container Utilization/Mem chart to use container_memory_working_set_bytes instead.
According to A Deep Dive into Kubernetes Metrics — Part 3 Container Resource Metrics | by Bob Cotton | FreshTracks.io: You might think that memory utilization is easily tracked with container_memory_usage_bytes, however, this metric also includes cached (think filesystem cache) items that can be evicted under memory pressure. The better metric is container_memory_working_set_bytes as this is what the OOM killer is watching for.

Thanks for reporting this @Carus11.  We ship a number of Grafana dashboards obtained by a number of sources.  The Kubernetes/Compute Resources/Pod dashboard is one pulled from the Grafana community.  The Perf/Container Utilization/Mem dashboard (and the other Perf/* dashboards) were developed by an internal testing team here at SAS focused on performance.  As you have discovered, different dashboards will surface different metrics and depending on what you are trying to do or understand, some dashboards will be better for some use-cases.
Unfortunately, due to resource constraints, we haven't been able to research and document where each dashboard is most useful and/or make all of the improvements to them we would like.  However, we welcome feedback from people using the dashboards in real-world situations like yourself on which dashboards and metrics are the most useful or where there might be opportunities for improvements.  That will help us prioritize the changes we do make.


how to reload number animation without number change

how to manualy reload number animation if number data does not change?

Changing the react key will force re-rendering. How about doing that?

Changing the react key will force re-rendering. How about doing that?

It works! Thanks


Logo proposal for IT films.

This is my logo proposal for IT films ( Issue #36 ), I've sent the image in png and svg format. I hope you like it.

@PaulaAsto looks really good! Just one thing let's move these logos to "logos" folder from "assets" because "assets" folder is for films pictures.

Done it!

Thank you for your contribution @PaulaAsto! Merged.


remove docker-in-docker container

The latest version of minikube now supports Docker 17.06.0-ce which contains the multi-stage build feature in Docker, therefore removing the need to run a separate docker engine just for builds. #163 was introduced strictly for this feature, so it's no longer required.
As an added bonus, we get:

automatic authentication to Azure Container Registries in the same resource group, and automatic authentication to the minikube docker registry (winner winner chicken dinner)
free security updates to docker (big maintenance win)

closes #430
closes #431
closes #405
partially addresses #213
#355 and #285 should be closed assuming that GKE/AWS clusters are automatically authenticated against GCR/ECR instances, but that needs verification.

Looks good! Manually tested. Thanks!


store: refactor GetRemote

Removes the 2nd argument signalling whether the remote is found or not
and returns a distinct error instead.
cc @lucab @sgotti

This is in line with what we discussed and looks fine, just one minor comment inline. Let's give a chance to @sgotti to have a look before merging it, as I think he's already touching this code.

PTAL

Low priority, moved to next milestone while waiting for last review.

@sgotti are you fine with this?

After squashing the two commits it LGTM.

@sgotti commits are independent now, PTAL (2nd commit is a minor cleanup commit of the codebase)

@tmrts Thanks! LGTM.

@tmrts up for fixing the nit?

@s-urbaniak sorry I've missed @jonboulle 's comment, PTAL

lgtm, thanks!


Convert pool id param to lowercase

Description
Fixes #2229
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Dependency changes
[ ] Code refactor / cleanup
[ ] Documentation or wording changes
[ ] Other

How should this be tested?

[ ] Test this pool ID 0X7B50775383D3D6F0215A8F290F2C9E2EEBBECEB20000000000000000000000FE on the mainnet preview. The chart should load.

Visual context
Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.
Checklist:

[x] I have performed a self-review of my own code
[x] I have requested at least 2 reviews (If the PR is significant enough, use best judgement here)
[x] I have commented my code where relevant, particularly in hard-to-understand areas
[x] If package-lock.json has changes, it was intentional.
[x] The base of this PR is master if hotfix, develop if not

@markusbkoch should be fixed now.

looks good, but I'm getting this intermitent layout bug now


Update MD file on new branch 2017-11-28_09-34-21

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update documentation version number

I've noticed that https://raw.githubusercontent.com/elastic/ecs-dotnet/main/docs/index.asciidoc also contains (an outdated) ECS version. Should it be updated as well?
Originally posted by @andreycha in https://github.com/elastic/ecs-dotnet/pull/200#pullrequestreview-1087840386

Need to update the generator to update this version automatically.


Remove public modifier in the interface class as they are not needed

What the PR entail is essentially removing the public modifier from all the interface classes because in Java methods declared in the interface have to be public.
Just one minor changes which might or might not be needed. Let me know if this is OK to be merged, or if there is any side effect by doing so

Hi, reviewer, not sure why the build was stalled in Travis CI, doesn't look it it is because of my change.


Create Heap sort

@Saikat2407 please accept my pr #5

Star the Repo first and add the required file under Cpp folder

Ok .Thankyou for response

let me know on completion.

I am star the Repo and changed folder as well.

Good job man!!

thankyou bro👍


Disable the generation of logged types in the JSON ABI by default

Disable the generation of logged types in the JSON ABI by default
The flag --generate-logged-types can be used to generate those types until the full support is done in the SDK.

https://github.com/FuelLabs/sway/issues/2745 tracks reverting this change once the SDK team is finished with implementing generics and even logging.

The current version has code which tests the loggedTypes (at least it includes it in the .json) but now a flag is being added which removes tests. Shouldn't there be 1 set of tests when the flag is used and another when the flag is not used? This way it would default to not being used but it is still proven to work when the flag is provided.

Absolutely. I don't like that I had to update the tests the way I did. To fix this, I need to update the infrastructure of the E2E tests to allow passing in forc flags through test.toml which I skipped here due to urgency. I will create an issue do that and work on it as soon as this is done and released so that nothing breaks without us knowing about it.


Make relationship lines draw on top of TreeItems

Fixes #49755. Lines were drawn before the items itself, so a custom background would hide the line or a part of line from view.

Thanks!


feat: Support MultipartRequest in functions invoke

What kind of change does this PR introduce?
feature
What is the current behavior?
The body can only be of type Map<String,dynamic> and no files can be uploaded.
What is the new behavior?
The body can be any Object, which is encodable to String. There's now a files parameter to send files with a MultipartRequest.
Additional context
At the moment everything is bundled in one method like in functions-js. One could argue to create an extra method to be more type safe with body being Map<String,String>.
close #933

It's from the http package, which I guess most people have already installed and can import themself. But exporting just that class won't hurt, so I will add that tomorrow.

It's from the http package, which I guess most people have already installed and can import themself. But exporting just that class won't hurt, so I will add that tomorrow.

Awesome 👍 Just sharing my two cents, but I think it's common for people to not have the HTTP package installed if they are using Supabase.

Since more types for the body are allowed now, I've added a basic content header detection. For string inputs, it sets the header to text/plain and for Uint8List as an example for binary data to octet stream.


Fixed Camel Routes

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/569/
Test PASSed.

merged


feat: add "Delete Chat", "View Chat", and messages

Add "Delete Chat", "View Chat", and functionality for creating messages.

 Chat - Delete

 Chats Details


Automated cherry pick of #9546

Cherry pick of #9546 on release-6.3.
/cc  @pablovelezvidal
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 806d955f68e4f973982031508d2d7355dbcc279e


Replacing deep-equal-json

https://github.com/A11yance/axobject-query/pull/354

I didn't know where else to post this since everything in that thread is locked, but I wanted to point out that the individual who took over that repo and made that PR (https://github.com/A11yance/axobject-query/pull/354) did the exact same thing to react native projects with browserify-sign:

https://github.com/browserify/browserify-sign/compare/v4.2.1...v4.2.3
https://github.com/browserify/browserify-sign/issues/86
https://github.com/browserify/browserify-sign/issues/88

browserify-sign was not his project. He had no history in the repository and no prior contributions. One day he sent a bunch of commits to main (no PRs) where he added numerous bloated dependencies written by him, his own personal github action, his own personal eslint config and released the changes as a patch release into our application. His changes broke the compilation of most apps that use crypto in React Native (specifically react-native-quick-crypto).
After I raised the issue with him, he refused to roll back the changes or release a new patch version. He told me (paraphrasing) to tell the React Native Metro team to learn how to build a correct bundler and blamed them for our problems.
I was able to fix react-native-quick-crypto by removing browserify-sign and several of the other bloated packages but some other ones still resolve transitively against our will because how embedded they are in npm. In our instance this individual caused thousands of people to waste a hundreds of collective hours for a change no one wanted, in a codebase that had no contributions from him.
@valadaptive @rich-harris @benmccann

Maddening.

I'm a bit concerned about this leading to more flamewars, pile-ons, slap-fights, and so on, but hopefully these sorts of experiences make their way into the discussion.
I've seen a few maintainers on Twitter talk about firsthand negative experiences they've had with this individual, and I feel like this discussion would be better if those people had more of a voice. My hope when this whole thing kicked off was that the active maintainers in the ecosystem, who had previously been talking about these shenanigans in hushed tones, would feel more empowered to speak up about their own encounters with him. Unfortunately, the discussion seems to have been primarily taken over by people just now learning about this for the first time.
Is there a way we could encourage people with firsthand experience (attempting to contribute to his packages, actively working with him as a maintainer long-term, etc) to speak up without feeling like they're part of a flame war?

Tearing out the libraries he had hijacked turned out to be the only solution for react-native-quick-crypto. It's difficult to address this behavior because, just like in https://github.com/A11yance/axobject-query/pull/354, he closes the thread, blocks the comments and will do what he wants whether it impacts your project or not. I'm not a high-profile developer or influencer with a Twitter presence, and the only thing I could do in my situation was tag the project creator from whom he hijacked the project.

Is there a way we could encourage people with firsthand experience (attempting to contribute to his packages, actively working with him as a maintainer long-term, etc) to speak up without feeling like they're part of a flame war?

IMHO, even becoming a maintainer alongside him doesn't stop him from adding those polyfill/packages, for backward compatibility and so-call robustness.

I'm not a high-profile developer or influencer with a Twitter presence, and the only thing I could do in my situation was tag the project creator from whom he hijacked the project.

Considering that not even Rich Harris could change his mind, I doubt there is anyone who can. Not only that, he is already a TC39 member (and previously a Node.js TSC member), so he has way more influence than the community imagine.

I can't even imagine how many projects need such packages removed. It feels like the whole npm registry needs to be forked and its contents thrown away to solve for this and all such packages banned from any new registry based on some heuristics. Manually removing them from npm will probably be impossible.

It's been going on for a long time, sadly. Here's another example that was just shared: https://github.com/tarruda/has/pull/17#issuecomment-1747898354
Anyway, even if it will take awhile, we can all work together to move forward in positively impacting the ecosystem. There will be an announcement coming soon with details of efforts that are underway from @e18e_dev on Twitter about some great initiatives like https://github.com/es-tooling/eslint-plugin-depend and efforts to proactively address major contributors to bloat in the ecosystem

It's been going on for a long time, sadly. Here's another example that was just shared: tarruda/has#17 (comment)

And that's why ljharb is bad. Even the author of core-js is more concerned about spec-compliant and engine compatibility than a current member of TC39. That's also why I recommend core-js in the nolyfill's README.


ScrollIntoView function of ListView does not work for custom ItemsPanel set in application level

Hi Team,
I have set StackPanel as ItemsPanel for ListView control in application level. Then when adding new items at run-time, I need to bring the newly added item into view. So, I have tried to use ScrollIntoView function of ListView. But, it does not work properly for custom ItemsPanel set at sample level. Please find the demo sample below and replication procedure below:
Demo:
Scrolling-issue.zip
Replication procedure:

Run the sample.
Try to add new item at run-time. I have used ScrollIntoView method to bring newly added item into view.
Note, newly added item not come into view even after using ScrollIntoView function of ListView control.

Can you please conform whether it is issue or behavior. If it is behavior, can you please provide any solution how to bring an ListViewItem into view.

@RBrid thoughts?

upgrade to preview-3,
mouse scroll button don't work when view has scrollbar

Hi Team,
Any update on this issue?

@ranjeshj or @RBrid any immediate thoughts?


[Improvement] [19] Training Program listing selection

[x] Enable the user to select what Training Program it wants to show, between his TP, and the Admin ones.

[ ] If possible enable the selection and show from another user.

The second improvement will not be implemented,for version 2.0,maybe for a future release


wait for some time to get semaphore when set HC detector task as done

Signed-off-by: Yaliang Wu<EMAIL_ADDRESS>Description
https://github.com/opensearch-project/anomaly-detection/issues/290

When starting a historical HC job for the first time, it seems to finish but reports the state as STOPPED instead of FINISHED.

This is a known issue for HC detector. When multiple entities send back task done message to coordinator node, coordinator node will update detector level task state&progress, if one entity is updating detector level task, all other entity task will be ignored. For example, HC detector has 3 entities, all of them finished almost the same time, so first entity can update detector level task as RUNNING, second and third entities task done messages will be ignored. So detector level task will remain RUNNING state. Then get detector API will reset task state as STOPPED.
This PR add wait time when get updating task state semaphore when HC detector historical analysis done. So we can make sure the last entity task done message can get semaphore and update HC detector task state as FINISHED correctly.
This PR also fix a bug of null isHCDetector of AnomalyResultResponse which result in HC detector stays on Initializing state forever. Check more details in issue https://github.com/opensearch-project/anomaly-detection/issues/301
Issues Resolved
https://github.com/opensearch-project/anomaly-detection/issues/290
https://github.com/opensearch-project/anomaly-detection/issues/301
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #300 (380d686) into main (e10ce9d) will decrease coverage by 0.17%.
The diff coverage is 60.00%.

:exclamation: Current head 380d686 differs from pull request most recent head 5c223c0. Consider uploading reports for the commit 5c223c0 to get more accurate results

@@             Coverage Diff              @@
##               main     #300      +/-   ##
============================================
- Coverage     76.32%   76.15%   -0.18%
+ Complexity     3967     3959       -8
============================================
  Files           295      295
  Lines         17165    17179      +14
  Branches       1812     1812
============================================
- Hits          13101    13082      -19
- Misses         3238     3263      +25
- Partials        826      834       +8

Flag
Coverage Δ

plugin
76.15% <60.00%> (-0.18%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ain/java/org/opensearch/ad/task/ADTaskManager.java
75.69% <57.89%> (-1.12%)
:arrow_down:

...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java
90.12% <100.00%> (ø)

...ava/org/opensearch/ad/task/ADTaskCacheManager.java
89.31% <100.00%> (ø)

...opensearch/ad/transport/AnomalyResultResponse.java
71.96% <0.00%> (-12.13%)
:arrow_down:

...port/SearchAnomalyDetectorInfoTransportAction.java
60.00% <0.00%> (-4.45%)
:arrow_down:

...opensearch/ad/indices/AnomalyDetectionIndices.java
68.35% <0.00%> (-0.19%)
:arrow_down:

...java/org/opensearch/ad/task/ADBatchTaskRunner.java
81.76% <0.00%> (ø)

...g/opensearch/ad/model/DetectorValidationIssue.java
54.38% <0.00%> (+7.01%)
:arrow_up:


version incompatibility

Description
ERROR: botocore 1.13.17 has requirement python-dateutil<2.8.1,>=2.1; python_version >= "2.7", but you'll have python-dateutil 2.8.1 which is incompatible.
Context
Attempting to do pip install -r kedro_tutorial/src/requirements in a fresh virtual env.
Steps to Reproduce

conda create ...
pip install -r ...

Expected Result
Full install of all requirements with no errors.
Actual Result
Error.
ERROR: botocore 1.13.17 has requirement python-dateutil<2.8.1,>=2.1; python_version >= "2.7", but you'll have python-dateutil 2.8.1 which is incompatible.

Your Environment
Include as many relevant details about the environment you experienced the bug in:

Kedro-Example:
cloned on 2019-11-14
Kedro version used (pip show kedro or kedro -V):
na
Python version used (python -V):
Python 3.7.0
Operating system and version:
Darwin LON-146770-C02YK107JGH8 18.7.0 Darwin Kernel Version 18.7.0: Sat Oct 12 00:02:19 PDT 2019; root:xnu-4903.278.12~1/RELEASE_X86_64 x86_64

@Robert-Muil thank you for reporting this. pip throws this error, but in fact all the packages are installed despite the version incompatibility, so you should be able to cd kedro-tutorial && kedro run
To mitigate the error, we would recommend the following:

clone the repo
create and activate conda environment
pip install kedro && cd kedro-tutorial  - pip throws that version error, but continues the installations
kedro build-reqs - will freeze your requirements' versions
kedro install - install frozen deps
kedro run

The key point to what @DmitriiDeriabinQB is suggesting is that the tool that freeze's the requirements does a much better job of resolving differing versions than pip does.

Thank you both for response. I don't quite understand the logic of this though: if the pip install works (and indeed is required for the build-reqs then what is the point of freezing and installing frozen deps? We will have to ignore the version error either way, right?
Also, I'm always a bit wary about freezing all requirements, including low-level libraries, as it's bad for security: we'd no longer get any updates at all, right?

Pip does not do version resolution of the packages, it just installs things as it finds them. So if it finds a requirement for wobulator<=15.0 it will install wobulator 15.0, then if later it finds a requirement for wobulator <= 14.0 it will just shrug because it already has wobulator. This leaves your environment in a state where it might run but is technically in violation of some of the version requirements. And it produces errors and warnings.
There is another tool called pip-compile (part of the pip-tools pacakge) that does do version resolution. Pip-compile will find the two requirements and realize that 14.0 is the latest version that is compatible with both requirements.
Interface wise what pip-compile does is it takes the requirements file, resolves all the dependencies and writes out a new file with all the dependencies resolved.
Generally you use it with two requirements files so:
"requirements.in" -> pip-compile -> "requirements.txt" -> pip
Kedro build-reqs is short for this flow, the first time you run it it will copy your requirements.txt to requirements.in, from then on it will rebuild requirements.txt from requirements.in with the dependency versions correctly resolved.
In terms of updates everytime you run kedro build-reqs it will rebuild your requirements.txt with the latest versions. So you get the security updates when you want them. Rather than them just happening.


Merge the current WIP into the master

Request to merge the WIP into the master branch for snapshot purposes

Okay, for snapshot merging


added 20 new unique words, corrected file name mistakes in othere fol…

…ders - Tahreem Khalil
The Pull Request resolves Issue #[25]
Description:

added 20 new unique words for example: - Flaneur, Komorebi, Kopfkino, Mangata, Meraki, Nemophilist, Onism, Palatable, Quatervois, Schwellenangst, Sumptuous, etc.
corrected wrong file extensions to JSON
deleted repeated words that I could find
moved files into their specific folders
kindly accept my humble effort

Hello, kindly accept my pull request issue #2876 for hacktoberfest. I added unique words that are worth knowing, plus I corrected minor issues with file names. Please accept my humble efforts.


head.addEntry is not a function

I have installed Nuxt JS app using npx nuxi init nuxt-app
But it gives an error on npm run dev as below:
[Vue warn]: Unhandled error during execution of setup function
at <ErrorDev statusCode=500 statusMessage="Internal Server Error" description="head.addEntry is not a function"  ... >
[nuxt] [request error] [unhandled] [500] head.addEntry is not a function
at ./node_modules/nuxt/dist/head/runtime/lib/vueuse-head.plugin.mjs:11:8
Note: I commented out the head.addEntry() function call so it's working on my side now.

I am not shure, but addEntry(...) should be addHeadObjs(...) instead. After renaming it works.

Hey there, please wait for the official nuxt integration. It will likely be out tomorrow

Sorry, I misunderstood this initially, it relates to https://github.com/nuxt/framework/issues/8936
The issue should be fixed, let me know if you have any issues

@harlan-zw, it has been resolved now.
Thanks, Brother!


Bus error (webpack) when building Gitea

Description
Hi,
I'm trying to build Gitea on commit 4bb1fcd2e727c3514658d720abed145ca751049f, following build instructions. Node.js used is v18.19.0.
As I run make, the build stopped on webpack where webpack core dumped due to bus error (AFAIK, it because my Intel core i3 haswell processor can't attempt memory requests from node).
After examining the dump info (via coredumpctl info), it turns out that lightningcss module causes the webpack error.
This build issue is also reproduced on node v20.11.0.
Gitea Version
commit 4bb1fcd2e727c3514658d720abed145ca751049f
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
https://gist.github.com/bagasme/d58a38beac308a20aa3b40dda2285021
Screenshots
n/a
Git Version
n/a
Operating System
Arch Linux
How are you running Gitea?
Building from source  (node v18.19.0, go 1.21.6).
npx webpack info output:

  System:
    OS: Linux 6.8 Arch Linux
    CPU: (4) x64 Intel(R) Core(TM) i3-4030U CPU @ 1.90GHz
    Memory: 1.31 GB / 3.73 GB
  Binaries:
    Node: 18.19.0 - ~/.nvm/versions/node/v18.19.0/bin/node
    npm: 10.2.3 - ~/.nvm/versions/node/v18.19.0/bin/npm
  Packages:
    add-asset-webpack-plugin: 2.0.1 => 2.0.1
    css-loader: 6.10.0 => 6.10.0
    esbuild-loader: 4.0.3 => 4.0.3
    license-checker-webpack-plugin: 0.2.1 => 0.2.1
    lightningcss-loader: 2.1.0 => 2.1.0
    monaco-editor-webpack-plugin: 7.1.0 => 7.1.0
    vue-loader: 17.4.2 => 17.4.2
    webpack: 5.90.1 => 5.90.1
    webpack-cli: 5.1.4 => 5.1.4

Database
None

I guess it is a upstream problem (as you mentioned: lightningcss), so Gitea could do nothing IMO?
Could you report the problem to upstream?

@bagasme Can you try if this changes anything?
NODE_OPTIONS="--max-old-space-size=4096" make webpack

This is more memory than your system has but I assume you have a swap file.

Nope. I can still reproduce the webpack bus error.

I guess it is a upstream problem (as you mentioned: lightningcss), so Gitea could do nothing IMO?
Could you report the problem to upstream?

Done at parcel-bundler/lightningcss#671.

Thanks, so let's see what comes out of the issue. I'm still leaning towards removing lightningcss, it just seems not stable enough.

@bagasme can you try this patch on the affected machine?
diff --git a/webpack.config.js b/webpack.config.js
index c4b140a12b..16afa0ff9c 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -54,14 +54,8 @@ const filterCssImport = (url, ...args) => {

   return true;
 };

-// in case lightningcss fails to load, fall back to esbuild for css minify
-let LightningCssMinifyPlugin;
-try {
-  ({LightningCssMinifyPlugin} = await import('lightningcss-loader'));
-} catch {}
-
 /** @type {import("webpack").Configuration} */
 export default {
   mode: isProduction ? 'production' : 'development',
   entry: {
@@ -105,14 +99,11 @@ export default {
     minimizer: [
       new EsbuildPlugin({
         target: 'es2020',
         minify: true,
-        css: !LightningCssMinifyPlugin,
+        css: true,
         legalComments: 'none',
       }),
-      LightningCssMinifyPlugin && new LightningCssMinifyPlugin({
-        sourceMap: sourceMaps === 'true',
-      }),
     ],
     splitChunks: {
       chunks: 'async',
       name: (_, chunks) => chunks.map((item) => item.name).join('-'),

@bagasme can you try this patch on the affected machine?
diff --git a/webpack.config.js b/webpack.config.js
index c4b140a12b..16afa0ff9c 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -54,14 +54,8 @@ const filterCssImport = (url, ...args) => {

   return true;
 };

-// in case lightningcss fails to load, fall back to esbuild for css minify
-let LightningCssMinifyPlugin;
-try {
-  ({LightningCssMinifyPlugin} = await import('lightningcss-loader'));
-} catch {}
-
 /** @type {import("webpack").Configuration} */
 export default {
   mode: isProduction ? 'production' : 'development',
   entry: {
@@ -105,14 +99,11 @@ export default {
     minimizer: [
       new EsbuildPlugin({
         target: 'es2020',
         minify: true,
-        css: !LightningCssMinifyPlugin,
+        css: true,
         legalComments: 'none',
       }),
-      LightningCssMinifyPlugin && new LightningCssMinifyPlugin({
-        sourceMap: sourceMaps === 'true',
-      }),
     ],
     splitChunks: {
       chunks: 'async',
       name: (_, chunks) => chunks.map((item) => item.name).join('-'),

Webpack build passed (no errors).

https://github.com/go-gitea/gitea/pull/29070 will fix it.


Host code gets not properly excluded when building gpu target

I would like to have code for cpu and gpu in one file, but when I use  the slang file to generate GPU code slang crashes with an internal error 99999. This is mainly caused by export vars/functions like the following below.
E.g., I use a COM Interface in my code
export __global __extern_cpp IProperties __properties;

Compiling to cpp is fine but when I use the same slang file for glsl even though it is not used by the GPU code slang crashes.
I already tried [require(cpp)] but it seems to have no effect. Is there another way to exclude code for certain targets? There is a way inside a function but what about global vars?
It would be awesome if one could annotate something like the example above with [require(cpp)] and then it would just be ignored if the target is not cpp
Edit: Of course I can resort to defines, but would be nice to have a better solution

Moving out to Q3 to keep remaining focus this quarter on bugs vs. enhancements.

We need to move this out another quarter, since there's a workaround available currently.


I think it would be better to add a function switch that can still continue playing in the background

I am trying to modify and implement this switch😢

U can use pip? On Android at least , it's not supported yet on iOS

U can use pip? On Android at least , it's not supported yet on iOS

like music play, not pip.When the application is in the background, it can still continue playing

U can use pip? On Android at least , it's not supported yet on iOS

like music play, not pip.When the application is in the background, it can still continue playing

I think for music you would need another package, since this package is only for video playing
But will check if video_player allows background playback and if it allows I will let you know

U can use pip? On Android at least , it's not supported yet on iOS

like music play, not pip.When the application is in the background, it can still continue playing

I think for music you would need another package, since this package is only for video playing
But will check if video_player allows background playback and if it allows I will let you know

they do allow, but its from flutter side , so the app can be closed by the system
i dont recommend it in that case, i recommend either pip or a dedicated  music player

It would be nice to have this feature. Like YouTube, it comes with the PIP mode, but it also allows you to play in the background when you lock the screen or close the pip floating window.
Regarding keeping the app running in the background, it uses a foreground service to show a notification with some player controls and to keep itself running without being killed, but I guess this can be implemented in a later stage.

It would be nice to have this feature. Like YouTube, it comes with the PIP mode, but it also allows you to play in the background when you lock the screen or close the pip floating window.
Regarding keeping the app running in the background, it uses a foreground service to show a notification with some player controls and to keep itself running without being killed, but I guess this can be implemented in a later stage.

I think media_kit will be able/ will want to add this feature, since I can't implement it from my side

video_player has the option to control this. You don't have to implement this from scratch, but just expose the setting in meedu_videoplayer.
https://pub.dev/documentation/video_player_platform_interface/latest/video_player_platform_interface/VideoPlayerOptions/allowBackgroundPlayback.html

video_player has the option to control this. You don't have to implement this from scratch, but just expose the setting in meedu_videoplayer.
https://pub.dev/documentation/video_player_platform_interface/latest/video_player_platform_interface/VideoPlayerOptions/allowBackgroundPlayback.html

It's from flutter side not using a platform native, which means no notification, and system can close it at anytime
If that's what you feel you need open a pr and I will happily merge it

I think the concern about being killed by the system might be a bit out of the scope of a widget. Developers can have their own methods to keep the app alive in background based on their needs.
Anyway, it is just my thought. It is up to you to decide.

I think the concern about being killed by the system might be a bit out of the scope of a widget. Developers can have their own methods to keep the app alive in background based on their needs.
Anyway, it is just my thought. It is up to you to decide.

I believe a platform way of handling it is much better, but I use video_player and media_kit and wrap them with my controls
And media_kit is releasing the cross platform release soon, so I think having each platform having native code for background playback will be much better than a half working solution


Compare and swap swallows errors

The change in this commit:
https://github.com/GoogleCloudPlatform/kubernetes/commit/e1ca63f56922b290e61bd0b6f4544b0e2f0d2261
Resulted in compare and swap to swallow the error due to shadow variable behavior.
The err outside of that if-block is actually different than the one inside of it because of the version, err := declaration.
This caused admission controller for quota to let operations through that should have failed because compare and swap reported no error back to the calling client.
/cc @smarterclayton

This is a big defect and should be P1 to review / merge

Add test case please

Thanks, Derek. Shadowing is nasty. :(

Kube development team 0 - shadowing 6.  Or more :)

On Mar 5, 2015, at 7:52 PM, Mike Danese<EMAIL_ADDRESS>wrote:
Thanks, Derek. Shadowing is nasty. :(
—
Reply to this email directly or view it on GitHub.

LGTM, once Mike's comments are fixed, I'll merge.


pass-git-helper: 1.1.1 -> 1.1.2

Motivation for this change
New upstream bugfix release: https://github.com/languitar/pass-git-helper/releases/tag/v1.1.2
Also add myself as maintainer.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 139346 run on x86_64-linux 1

1 package built:

pass-git-helper

Result of nixpkgs-review pr 139346 at 65605178 run on aarch64-linux 1

1 package built successfully:

pass-git-helper

1 suggestion:

warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/applications/version-management/git-and-tools/pass-git-helper/default.nix:22:0:
   |
22 |     description = "A git credential helper interfacing with pass, the standard unix password manager";
   | ^


Create CONTRIBUTING.md guidelines

What problem does this solve or what need does it fill?
We should have one central place to point new (and old) contributors when they have questions about the contribution process, especially when it come to PRs.
I think this is particularly valuable for contributors who are new to Rust or open source development. This is more likely to be true with Bevy than other projects, due to its accessibility and broad interest.
What solution would you like?
Create a CONTRIBUTING.md file.
Current steps for making a PR:

Fork the repo.
Make changes locally.
Run cargo fmt. Run cargo +nightly fmt.
Run cargo clippy.  Take the clippy command from the workflows folder & run the same command.
Submit a pull request with a descriptive title and any important context about the changes.

What alternative(s) have you considered?
Continue to pass this information on one contributor at a time, or trust that they're experienced to know how to do so.
Additional context
Prompt for this issue.

Should that be cargo +nightly fmt?

Should that be cargo +nightly fmt?

Like this? #1309

Like this? #1309

Actually resolved by https://github.com/bevyengine/bevy-website/pull/85 -- the place to point to is https://bevyengine.org/learn/book/contributing/code/
#1309 continues down a different avenue...

Actually resolved by https://github.com/bevyengine/bevy-website/pull/85 -- the place to point to is https://bevyengine.org/learn/book/contributing/code/
#1309 continues down a different avenue...