Feature/classlist api automation

I had to abstract a bit of logic. The goal was to re-use the business logic that was originally in the CSV Parser. Some of the checks for missing data cannot be written twice, and there is some user creation logic that should be used for both the integrated class list upload and manual class list upload.

There are a fair amount of large decisions that one can make.

I went with the simplest approach that I could find (aside from writing a lot of duplicate code).
I brought a bit of the logic into the PersonController instead of leaving it in the CSVParser.
The CSVParser tests that upload a class list are practically the same, although they now live in the PersonController.

We need to merge this into ubccpsctech classy master first...


After ImageUpdateAutomation bumps subchartA.image.tag, but subchartB also re-deployed on reconciliation

Flux version
► checking prerequisites
✗ flux 0.20.1 <0.21.0 (new version is available, please upgrade)
✔ Kubernetes 1.21.5 >=1.19.0-0
► checking controllers
✔ helm-controller: deployment ready
► ghcr.io/fluxcd/helm-controller:v0.12.1
✔ image-automation-controller: deployment ready
► ghcr.io/fluxcd/image-automation-controller:v0.16.0
✔ image-reflector-controller: deployment ready
► ghcr.io/fluxcd/image-reflector-controller:v0.13.0
✔ kustomize-controller: deployment ready
► ghcr.io/fluxcd/kustomize-controller:v0.16.0
✔ notification-controller: deployment ready
► ghcr.io/fluxcd/notification-controller:v0.18.1
✔ source-controller: deployment ready
► ghcr.io/fluxcd/source-controller:v0.17.1
✔ all checks passed
Kubernetes version
NAME      STATUS   ROLES                  AGE    VERSION
sigma01   Ready    control-plane,master   625d   v1.21.5
sigma02   Ready    control-plane,master   625d   v1.21.5
sigma03   Ready                     625d   v1.21.5
sigma04   Ready                     625d   v1.21.5
HelmRelease in question
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: testing
  namespace: development
spec:
  chart: [...]
  interval: 1m0s
  timeout: "15m"
  install:
    replace: true
    remediation:
      retries: -1
    disableWait: true
    disableWaitForJobs: true
  upgrade:
    force: true
    remediation:
      retries: -1
    disableWait: true
    disableWaitForJobs: true
  values:
    frontend:
      image:
        repository: registry.example.com:443/project/front # {"$imagepolicy": "development:frontend-front:name"}
        tag: 0.15.127 # {"$imagepolicy": "development:frontend-front:tag"}
    backend:
      core:
        image:
          repository: registry.example.com:443/project/core # {"$imagepolicy": "development:backend-core:name"}
          tag: 0.15.56 # {"$imagepolicy": "development:backend-core:tag"}

As you can see on the above HelmRelease, the chart contains two sub-charts. The backend and the frontend. There are many components in the backend, but there is a core component that corresponds to a Deployment in Kubernetes.
What happens
I can see that upon a new image available, the ImagePolicy is properly executed by the ImageUpdateAutomation and the HelmRelease is properly patched in the repository:

As you can see, the frontend sub-chart's image tag is patched. In 1 minute, the frontend deployment is patched with the new image version and it restarts. However, the backend deployment also restarts, due to unknown causes.
What I would expect
I would expect that only the frontend deployment to be restarted with the image, not the backend.
Why would the backend also restart? Is there anything else that is modified in the backend Deployment so that Kubernetes would restart also the backend?

I think this may be because the backend sub-chart contains the following:
env:
            - name: DEPLOYMENT_ID
              value: {{ randAlphaNum 5 | quote }}

Is it possible to tell the HelmRelease not to regenerate randAlphaNum upon reconciliation while the YAML did not change after all?

No, as we follow Helm logic. Based on the suggestion in that issue, you should solve it on the chart's end: https://github.com/helm/helm/issues/3053#issuecomment-782837107

I see, in any case, I'll close the issue and may attempt a fix using https://github.com/helm/helm/issues/3053.


Enable server garbage collection

According to https://stackoverflow.com/questions/44035282/how-can-i-enable-server-gc-in-net-core you may need to run dotnet clean first for it to take effect.

Apparently already handled by opendreamserver.


Fix Exception in ImportAction with Local Default Disk and S3 Filament Disk

Description
Fixes #13502
This pull request addresses an exception thrown when using ImportAction with the default disk set to local and the Filament disk set to s3. The issue was caused by a conflict in handling file operations between the two disks.
Changes:

Adjusted the file handling logic in ImportAction to correctly manage files between local and s3 disks.

Notes:
I am unsure why the previous code was implemented in the way it was, as it led to this issue. If there was a specific reason for the previous implementation that I might have missed, please let me know.
@danharrin, please review and confirm if this adjustment aligns with the intended functionality, or if the previous code had a specific purpose that should be retained.
Also submitted another PR #13505 with alternate solution.
Visual changes
NA
Functional changes

[x] Code style has been fixed by running the composer cs command.
[x] Changes have been tested to not break existing functionality.
[x] Documentation is up-to-date.

AFAIK this breaks S3 streaming


Support for OpenAI Structured Outputs

Description
There is a beta implementation of their new functionality, but it has no documentation and is an initial rough draft.
It would be great to provide improved support for structured outputs, especially if we could provide this option without requiring a separate decorator (i.e. enable it directly through the openai.call decorator instead of having to use the openai.parse beta decorator).

This is out in v1.1!
docs: https://mirascope.io/docs/latest/learn/provider_specific_features/#structured-outputs


Roblox Cursor not showing

Acknowledgement of preliminary instructions

[x] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
Yesterday I downloaded a custom cursor and I put it into the Mods folder and it worked when you are in the roblox loading screen with the games title but when you fully join the game it turns into the normal roblox cusor.

Where did you place the cursor?

In the Textures folder

Can you show a screenshot please?

Issue has been awaiting clarification for over a month, closing as stale. If you have anything further to add, just respond and I'll reopen.


Writing incoming A2DP sink data stream to a wav file

Hello!
In the following function, what would be the best way to save the data stream to a wav file? I tried writing the bytes directly to a wav file and it did not work. Would appreciate if you can point me to the right direction, also don't mind contributing that as a feature to this project if it ends up working.
void read_data_stream(const uint8_t *data, uint32_t length)
{
// Do something with the data packet
}
Thanks and regards,
Akash

I propose that you have a look at https://github.com/pschatzmann/arduino-audio-tools.
There you can find different encoders: E.g. https://pschatzmann.github.io/arduino-audio-tools/html/classaudio__tools_1_1_audio_encoder.html


IPC: Initial commit of Inter-process communication

This is a RFC for adding IPC support to libtock-rs.
The idea here is to support the Tock kernel IPC mechanism. Although running multiple libtock-rs apps is difficult, it is still possible so I think we should support IPC.
As well as that on ARM it's not difficult to run a libtock-rs application that communicates with libtock-c applications.
The current subscribe design in libtock-rs doesn't work with the IPC subscribe mechanism. I'm not sure why that's the case (I can't remember and I don't see if discussed in the design constraints).
This adds a new subscribe allows runtime configurable subscribe numbers. We could instead edit the current one or any other ideas anyone has.
The code compiles but it untested, currently just looking for comments on how to handle this

Hi Alistair! Thank you so much, that was the one detail I was forgetting to mention last night--this PR was indeed based off the excellent work in #535!
I had a long chat over the past couple weeks with Amit regarding design decisions for this PR, and together we determined that having a dedicated subscribe_ipc function as in #535 which elides scoped handles in favor of static lifetimes indeed made the most sense as an approach.

Additional note regarding this approach: this does lead to some interesting details with having to allocate static mutable buffers for IPC shared buffers, which naively require using unsafe to access.
I experimented with the ergonomics of a few other approaches, but ultimately decided the simplest was a single unsafe access by the client to pass a mutable reference to ipc_share--would love any thoughts on this decision!
Here are some approaches I tried for gating access to the underlying buffer shared between IPC processes:

spin::Mutex: adds code size overhead, external dependency as well
lazy_static!: requires spin when used as no_std, same issue
#[thread_local]: unstable feature, allows no_std but still requires unsafe for accessing thread-local statics, see rust-lang/rust #17954
tock_cells::take_cell::TakeCell: removes the need for unsafe when accessing the shared buffer, but is !Sync so can't be static
Box::leak(): works quite well, but adds a requirement on alloc (this seems like the most reasonable tradeoff--would love feedback if we think this is reasonable)

This is the one detail in particular I'd love the most feedback on--I understand that it's non-ideal ergonomically to necessitate unsafe in Tock app code whenever IPC is present, so any other suggested approaches are more than welcome.


List bundle dependencies

Describe the problem/challenge you have
List dependencies:
An imgpkg bundle can either be a standalone bundle or a package repository, with them referencing  dependent artifacts which can either be OCI artifacts or other imgpkg bundles. The imgpkg CLI today does not provide an option to query a bundle to list all dependent artifacts (regardless of the level of nesting) without doing a pull and parsing through the contents of the bundle.
This requires knowing the internals of the imgpkg bundle layout which is an implementation detail and causes too tight a coupling for clients consuming the CLI.
This feature is very helpful to inspect contents of the bundle metadata without requiring to download it, similar to how artifact manifest can be inspected using the crane command.
Describe the solution you'd like
Provide a CLI option and an API to allow clients consuming the bundles to query for all dependent artifacts and their types (bundle, repo, image) with their references locked to the relocated repository, similar to how “imgpkg pull” would fix the images lock.
Example:
imgpkg -b <bundle-ref> --list-deps
returns images referenced after the images are locked
Images referenced in the ImagesLock of the bundle:
index.docker.io/test/package-repo@sha256:b5e1cfb8731bf5ba6a0fb7060c37bbca03e9fb12be56dbec4a1fe2bbdfff2bd3
index.docker.io/test/package-repo@sha256:42030f63b66e25a03c7d9ef28fa5369d230df5697b4ab2d94860e3f69026d18a
Anything else you would like to add:
None

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

cc: @ncdc

Thanks for creating this issue.

Provide a CLI option and an API... to query for... types

The CLI option can be added to the pull command. If this flag is present, the last section of output can be a flat list of all the dependent images that were pulled (also whether the dependent image is a bundle or an OCI image) Assuming we display whether the dependent image is a bundle or OCI image, would you still expect an API to 'query' the type?
Are you able to expand on the use case driving this request? or, why do you want a full list of dependent images per bundle?
I am trying to understand whether this is purely for information (which in that case the pull command outputting additional information seems like a fine idea), or whether this is being used to maybe verify / validate?
In which case, I think discussing a new command to 'inspect' a bundle, and output pertinent information such as dependencies, ImagesLocation, signatures and tags might be useful

Thanks @ashvinmoro
I think given the specific use case for this feature, a new command to 'inspect' the bundle should be done.

We've gotten information that this is a higher priority:

there was an assumption that this could achieved through inspecting images.yml by pull recursive. However, we get an incomplete set of images; that approach is not viable.

TODO:
Prior to working on this

i'll detail what the command options/flags will be, and the format of the output

@ashvinmoro any comments about the output of the describe command proposed in #124 ?

@pivotaljohn @joaopapereira I went through the issue #124. There are a couple of aspects I had suggestions about

List all of the image references that are part of the bundle. This appears to be covered in issue #124.
If the bundle is a nested bundle, list the image references of nested bundles as well as the image references of each nested bundle. This could either be provided as a recursive listing or as a separate option by passing in the reference of the nested bundle.

$ imgpkg describe -b new.registry.io/simple-app-install-package

Bundle SHA: aaaaad700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4
Tags: latest, v1.0.0

Authors:
  Carvel Team<EMAIL_ADDRESS>Websites:
  carvel.dev/imgpkg
Metadata:
  - Some Version: 1.0.0
  - Other Information: Some text here

Images:
  - new.registry.io/simple-app-install-package@sha256:d211dd700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4
     **Type: Bundle**
    Origin: my.registry.io/bundle1@sha256:d211dd700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4
    Images:
      - new.registry.io/simple-app-install-package@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
        **Type: Image**
        Origin: registry.io/img1@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
        Annotations:
          kbld.carvel.dev/id: my.registry.io/simple-application

      - new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
        **Type: Image**
        Origin: registry.io/img2@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
  - new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
    Origin: registry.io/img2@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f

@ashvinmoro Take a look at the following example to see if they look good for your use case:
Examples
Example 1: Describe command without any argument
$ imgpkg describe -b new.registry.io/simple-app-install-package

Bundle SHA: aaaaad700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4
Tags: latest, v1.0.0

Authors:
  Carvel Team<EMAIL_ADDRESS>Websites:
  carvel.dev/imgpkg
Metadata:
  - Some Version: 1.0.0
  - Other Information: Some text here

Images:
  - Image: new.registry.io/simple-app-install-package@sha256:d211dd700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4
    Type: Bundle
    Origin: my.registry.io/bundle1@sha256:d211dd700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4
    Images:
      - Image: new.registry.io/simple-app-install-package@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
        Type: Image
        Origin: registry.io/img1@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
        Annotations:
          kbld.carvel.dev/id: my.registry.io/simple-application

      - Image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
        Type: Image
        Origin: registry.io/img2@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
  - Image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
    Type: Image
    Origin: registry.io/img2@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f

Example 2: Describe command listing all images
$ imgpkg describe -b new.registry.io/simple-app-install-package --images --current-location

Bundles:
  - Image: new.registry.io/simple-app-install-package@sha256:d211dd700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4

Images:
  - Image: new.registry.io/simple-app-install-package@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
  - Image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f

Example 3: Describe command listing all images in the current bundle without searching inner bundles
$ imgpkg describe -b new.registry.io/simple-app-install-package --images --current-location --no-recursion

Bundles:
  - Image: new.registry.io/simple-app-install-package@sha256:d211dd700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4

Images:
  - Image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f

Example 4: Describe command listing all images displaying the origin
$ imgpkg describe -b new.registry.io/simple-app-install-package --images

Bundles:
  - Image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
    Origin: registry.io/img1@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0

Images:
  - Image: new.registry.io/simple-app-install-package@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
    Origin: registry.io/img1@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
  - Image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
    Origin: registry.io/img2@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f

Example 5: Describe command listing all images when Bundle was not copied
$ imgpkg describe -b new.registry.io/simple-app-install-package --images

Bundles:
  - Origin: my.registry.io/bundle1@sha256:d211dd700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4

Images:
  - Origin: registry.io/img1@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
  - Origin: registry.io/img2@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f

Previous examples but using a yaml output
Example 1: Describe command with yaml output
$ imgpkg describe -b new.registry.io/simple-app-install-package --output-type yaml

sha: aaaaad700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4
tags:
 - latest
 - v1.0.0
authors:
  - name: Carvel Team
    email<EMAIL_ADDRESS>websites:
  - carvel.dev/imgpkg
metadata:
  - Some Version: 1.0.0
  - Other Information: Some text here

images:
  - image: new.registry.io/simple-app-install-package@sha256:d211dd700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4
    type: Bundle
    origin: my.registry.io/bundle1@sha256:d211dd700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4
    images:
      - image: new.registry.io/simple-app-install-package@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
        type: Image
        origin: registry.io/img1@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
        annotations:
          kbld.carvel.dev/id: my.registry.io/simple-application
      - image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
        type: Image
        origin: registry.io/img2@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
  - image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
    type: Image
    origin: registry.io/img2@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f

Example 2: Describe command listing all images with yaml output
$ imgpkg describe -b new.registry.io/simple-app-install-package --images --current-location --output-type yaml

bundles:
  - image: new.registry.io/simple-app-install-package@sha256:d211dd700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4
images:
  - image: new.registry.io/simple-app-install-package@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
  - image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f

Example 3: Describe command listing all images in the current bundle without searching inner bundles with yaml output
$ imgpkg describe -b new.registry.io/simple-app-install-package --images --current-location --no-recursion --output-type yaml

bundles:
  - image: new.registry.io/simple-app-install-package@sha256:d211dd700949154e429d28661d01c99d53a38af0d5275842ccbf0bf6dbef8ca4
images:
  - image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f

Example 4: Describe command listing all images displaying the origin with yaml output
$ imgpkg describe -b new.registry.io/simple-app-install-package --images --output-type yaml

bundles:
  - image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
    origin: registry.io/img1@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0

images:
  - image: new.registry.io/simple-app-install-package@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
    origin: registry.io/img1@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
  - image: new.registry.io/simple-app-install-package@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f
    origin: registry.io/img2@sha256:47ae428a887c41ba0aedf87d560eb305a8aa522ffb80ac1c96a37b16df038e0f

Nice, but as mentioned before in other discussions, it'll be nice to somehow have the original image tags annotated so that describe can provide some information that a human can understand :-D

In some sense, the original tag will be present if you use kbld to generate your ImagesLock and that tag is used in the files read by kbld. Look at this example:
$  kbld -f basic-step-2/config.yml --imgpkg-lock-output basic-step-2/.imgpkg/images.yml
resolve | final: index.docker.io/dkalinin/k8s-simple-app:latest -> index.docker.io/dkalinin/k8s-simple-app@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
---
apiVersion: v1
kind: Service
metadata:
  name: simple-app
  namespace: default
spec:
  ports:
  - port: 80
    targetPort: 80
  selector:
    simple-app: ""
---
apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    kbld.k14s.io/images: |
      - origins:
        - resolved:
            tag: latest
            url: index.docker.io/dkalinin/k8s-simple-app:latest
        url: index.docker.io/dkalinin/k8s-simple-app@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
  name: simple-app
  namespace: default
spec:
  selector:
    matchLabels:
      simple-app: ""
  template:
    metadata:
      labels:
        simple-app: ""
    spec:
      containers:
      - env:
        - name: HELLO_MSG
          value: stranger
        image: index.docker.io/dkalinin/k8s-simple-app@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
        name: simple-app

Succeeded

$ imgpkg push -b localhost:5000/test -f basic-step-2
dir: .
dir: .imgpkg
file: .imgpkg/bundle.yml
file: .imgpkg/images.yml
file: config.yml
Pushed 'localhost:5000/test@sha256:3cd8f0d917a92fafeef2d44eb63195d5351c35cf46b8b7448cb126c7d68c6291'
Succeeded

$ imgpkg describe -b localhost:5000/test@sha256:3cd8f0d917a92fafeef2d44eb63195d5351c35cf46b8b7448cb126c7d68c6291 -o yaml
sha: sha256:3cd8f0d917a92fafeef2d44eb63195d5351c35cf46b8b7448cb126c7d68c6291
content:
  images:
    sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0:
      annotations:
        kbld.carvel.dev/id: index.docker.io/dkalinin/k8s-simple-app:latest
        kbld.carvel.dev/origins: |
          - resolved:
              tag: latest
              url: index.docker.io/dkalinin/k8s-simple-app:latest
      image: index.docker.io/dkalinin/k8s-simple-app@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
      imageType: Image
      origin: index.docker.io/dkalinin/k8s-simple-app@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
image: localhost:5000/test@sha256:3cd8f0d917a92fafeef2d44eb63195d5351c35cf46b8b7448cb126c7d68c6291
metadata: {}
origin: localhost:5000/test@sha256:3cd8f0d917a92fafeef2d44eb63195d5351c35cf46b8b7448cb126c7d68c6291

Succeeded

Another thing we need to keep in mind is that imgpkg only deal with Full Described Images(uses digest only), so unless the tool that creates the ImagesLock provides this information, imgpkg as no way to know tag information

Nice thanks for clarification. Is this also true for imgpkg copy, which is how most of the times images get to local clusters?

Not following 100% what you mean, but the information we are displaying is the information that is part of the ImagesLock, so if the information is in the ImagesLock it will be displayed


Update ticker to BCH

This is now up for community review. The goals of moving to BCH:

Have a consistent ticker for all exchanges and wallets.
Remove confusion around Bitconnect which also uses BCC.
Work with the industry which has already adopted BCH.

Please provide your feedback.

I see no reason not to do this.  Initially , we said 'lets let the market decide'.  It has.
No point to battle the ticker with bitconnect, which will be around for who knows how long.
Most exchanges use BCH.  Pointless to say something different on our site.

Have a consistent ticker for all exchanges and wallets.

Yeah, BCC.

Remove confusion around Bitconnect which also uses BCC.

Why do we have to help a scam-coin survive?

Work with the industry which has already adopted BCH.

Can you clarify this statement? What "industry"? Is there any actual data?

Most exchanges use BCH.

Exchanges do not define the ecosystem. Bitcoin Cash is very young, too soon to proclaim this settled.

@NxtChg it doesn't matter if its a scam.  It's well marketed and its a top 10 coin.  Hoping its going to go away is not a strategy.

It's well marketed and its a top 10 coin.

It only activated after Bitcoin Cash started using BCC.

@NxtChg yeah, if you look at the list of exchanges and wallets, many of them are already using BCH. I agree there are quite a few that also use BCC but right now it is very even, and one is already in use. Also the highest volume exchange (HitBTC) is already moving to BCH.
That being said, I am open to discussion and want to make sure the community is ok with this change.

that may be true @NxtChg but the network effect of widespread BCH usage is already here.

Worst case of Cranio-Rectal inversion I've ever seen. How do you justify XBC then? "Oh, but Bitcoin Plus has only been around since ... err, 2014."
Fucktard.

@zquestz by not resisting the change and giving up too early, just because of a few exchanges, we make it a self-fulfilling prophecy.

Eventually, we'll go back to using BTC. While we wait for Segwit to die, we should use BCH. We need to avoid confusion with the scam coin, Bitconnect.

Eventually, we'll go back to using BTC.

That's the spirit :)

Would love to keep the conversation constructive. Honestly I like BCC and think it is a good ticker, but am not happy about the confusion. I have been asked on multiple occasions about it and just want to make sure we are doing the right thing.
No decision has been made, this is merely to discuss it.

Additional data point. More volume and exchanges use BCH than BCC. https://coinmarketcap.com/currencies/bitcoin-cash/#markets

BCH is good. Plus it lets us use those nice BCH PLS shirts

main reason to use BCH is for the "BCH PLEASE" t-shirts... only half-kidding.
HAHA! Just saw comment above said same thing, lol, promise I didn't read beforehand.
Seriously though:

majority of exchanges are using BCH

BCC, like it or not, is already taken

we need unity more than this or that ticker. momentum is weighted on bch side.

I say we make plans for BCH and if/when bitocincash.org makes BCH official we flip the switch

ACK

Paybacks a BCH...

ACK

ACK

I am a Bitcoin novice and use the Trezor hardware wallet. This uses BCH for Bitcoin Cash so I think that Trezor users would be in favour of this ticker.


Update tableauViz.js-meta.xml

Tableau Viz LWC is being Archived
All outstanding PRs and Issues are being addressed and closed. For more information, please see the README


[V2] search bug

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: 2.0.0-beta.9

Platform and Target: IOS, MacOS, IE 11, Edge

Live Link or JSFiddle/Codepen: KitchenSink

What you did
Click on search to made search input appear. It creates an offset on the right.
Expected Behavior
No offset
Actual Behavior
offset

I know about it, but to be honest can't find a reason what causes it. Looks like iOS-related rendering issue, as according to styles and what inspector shows it should be on right place. If you know what cause it, let me know

Yes I have try to find from where it goes by myself but I didn't find. so I ask here.
I will search

OK found that the bug as been introduced between beta2 and beta3.

ffe9c3ff09437a92a37657e0f8075f320b5c19ae


[Documentation] Syntax highlight issues for @ sign in XML Attributes sample

Hi @dilinisg,
What is the IDE you are using?

Hi @Shan1024
This was noticed in the ballerina by example site. Not in IDEA

This is fixed with 0.94.0 update
https://ballerinalang.org/docs/by-example/xml-attributes


Is there a way to add agents written in C++ using the official SC2 API?

I only have a Linux machine available at the moment, and I'd like to watch some AI I created using the official API.
For example:
I wrote a bot similar to this and would like to use pysc2 to spectate it fight a simple computer. As far as I know this isn't possible, but please correct me if I'm wrong.

One option would be to save a replay of the bot, and they play that back in PySC2.
Something like this:
virtual void OnGameEnd() final {
Control()->SaveReplay(filePath)
}

I've been looking on how to do that, it hasn't been documented yet. Thanks a bunch!


Merge with caffe master

I merged the future branch with caffe master. It was a manual merge and I had to make manual modifications to a number of files, as well as create the crop_layer files.

@safrooze thanks for the merge, but the FCN crop layer and coordinate mapping tools have been merged to master. See https://github.com/shelhamer/fcn.berkeleyvision.org for details on reference FCNs for the master branch.


Can't recover from FsCache Errors

When scanning is interrupted or there's a problem writing to the cache the user can't recover from that error.
2023-03-07 08:53:57.944534-0300 secant-testnet[15281:6579556] [sdkLogs] [ERROR 💥] FSCompactBlockRepository.swift - saveBlocksMeta(_:fsBlockDbRoot:rustBackend:) - Line: 261 -> Failed to write metadata with error: genericError(message: "Failed to write block metadata to FsBlockDb: Db(SqliteFailure(Error { code: ConstraintViolation, extended_code: 1555 }, Some(\"UNIQUE constraint failed: compactblocks_meta.height\")))")

make it so that invalid cached can be cleared or corrected.

closed in #821


Remote references not being fetched in SynBioHub

The remote ICE/Benchling collections are not resident on SynBioHub. They are accessed through a remote interface with the corresponding repository. SynBioHub is not currently able to fetch linked SBOL objects in remote repositories. This is a tricky issue since we are not guaranteed these objects won't change, be deleted, etc., since we do not have control of those repositories. One possible solution would be to provide a copy of this object in one's own namespace when fetched, so one would basically be cloning their object. In this way, when submitted, it would end up submitting this part into the user's local store, so one can be assured it will not change. Alternatively, we can just link to the remote object and hope that it remains stable (very risky if the part is in a Benchling remote repo).

closing this, but will check with remotes when it's done for sbh2


feat(api): add locale function, closes #5939

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

This doesn't fix navigator.language(s) functions, we already tried to fix it on Windows without any luck, this just provide an alternatives that users could use.


modify routerLogin, when login user is not exist, create it

Codecov Report

Merging #62 (33e927b) into dev (1d66510) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev      #62      +/-   ##
============================================
- Coverage     26.91%   26.79%   -0.13%
  Complexity      136      136
============================================
  Files            54       54
  Lines          1943     1952       +9
  Branches        135      135
============================================
  Hits            523      523
- Misses         1380     1389       +9
  Partials         40       40

Impacted Files
Coverage Δ

...ank/wecross/account/service/ServiceController.java
0.60% <0.00%> (-0.02%)
:arrow_down:

...ross/account/service/config/ApplicationConfig.java
49.20% <ø> (ø)

.../com/webank/wecross/account/service/utils/SM2.java
13.04% <0.00%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d66510...33e927b. Read the comment docs.


feat(core): supporting functional guards and resolvers #5455

closes #5455

v14.10.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.


EHPR-1007 | Add Tailwind 2

Installed as per Tailwind guides using Craco. @fwpushan I'm not sure why the package-lock diff is so large 🤔 could you pull this branch and make sure you get the same output?
Note: Tailwind and MUI won’t be strictly compatible so Tailwind should only be used for new components or for rewrites.
Sonarcloud bugs need to be reviewed and marked as safe

Closing due increased maintenance burden of having two styling and lack of desire to use Tailwind on new features


New version: DiffEqTutorials v0.6.0

Registering package: DiffEqTutorials
Repository: https://github.com/SciML/DiffEqTutorials.jl
Created by: @ChrisRackauckas
Version: v0.6.0
Commit: 621a05aa997b9f7738d7d2f65b66f2be359f1e42
Reviewed by: @ChrisRackauckas
Reference: https://github.com/SciML/DiffEqTutorials.jl/issues/71#issuecomment-608947523

Needs https://github.com/JuliaNLSolvers/OptimBase.jl/pull/14 @pkofod

That's merged

Perfect. Thanks.


Pre-trained model links have expired

Hi there,
Any chance of providing fresh links to the pretrained models ?
Thanks.

Hi @arunesh,
Thanks for reporting the issue! I will update the links shortly.

@arunesh The links have been updated. Sorry again for the inconvenience. I'm closing this issue. Please feel free to reopen it or create a new one if you encounter any problems in using the code.

Hi @formiel
Thanks so much !


CARDS-1264: Add a Pagination Test questionnaire to the test runmode

Turned the Patient Information form into a paginated one

@sdumitriu Please check the latest version of #715 . The test questionnaire is an excerpt from the current Patient information questionnaire with several questions as well as whole sections removed and (simple) conditions added for two of the remaining sections. There's also a nested section to test that only top-level sections become pages. There's of course room for improvement, such as more complex conditionals, but IMO it's "lighter" and better than this one.

I don't see any pagination in the Pagination Test form.
Something is wrong with DOB and Pedigree, Date of genetic diagnosis, Age of genetic diagnosis...


Deprecate dart:html's document.registerElement & registerElement2

[ ] Mark these as @Deprecated
[ ] Add an entry to the changelog for the next release
[ ] Email the announce alias

@kevmoo @sigmundch is this the full list of deprecations for Dart 3?
If so, let's get the deprecations going. Preferably we should get them in ASAP.
And then please update https://github.com/dart-lang/sdk/issues/49529 to list these as full discontinuations in Dart 3.0.

I sent a breaking change announcement today, specifically about these 2 APIs. Depending on the feedback, I think it may be possible to discontinue the API prior to Dart 3.
CL https://dart-review.googlesource.com/c/sdk/+/252840 will add the deprecation annotation.
That said, there is a related breaking change we should consider: the compilers today allow users to extend html elements and define their custom element classes. Without the custom element registration APIs, there is no value in doing that. Disallowing that users extend html element is a separate breaking change, though. The more I think about it, the more I feel compelled to push on that breaking change as well.
Thoughts?
/cc @rakudrama @srujzs @rileyporter

SGTM! :shipit: 👍 🤘

the compilers today allow users to extend html elements and define their custom element classes

Do these work as intended today? I don't remember if these were just broken with or without the custom element APIs.

Disallowing that users extend html element is a separate breaking change

Is this the only native class we allow Dart classes to extend in our compilers? I agree that it doesn't make sense to continue allowing this once the custom element APIs go away. I know you mentioned there was an indirect way to do custom elements with interop - do we have a tracking bug/documentation on that? This comes up once in a while and it'd be useful to point users to the current way this is (somewhat) supported.

Do these work as intended today? I don't remember if these were just broken with or without the custom element APIs.

Good question, I think you are right that they are not usable. That is, I don't believe there is a way to instantiate these classes without using registerElement and createElement('x-foo').
@rakudrama - do you recall if there are other ways to instantiate these classes?

Is this the only native class we allow Dart classes to extend in our compilers?

I am not sure to be honest, we need to review the full list of native APIs, @rakudrama may have a hunch though :)

I know you mentioned there was an indirect way to do custom elements with interop - do we have a tracking bug/documentation on that?

I don't believe we have an official doc, so we should create one. The best references implementations we have are:

this old demo written by Jenny: https://github.com/jmesserly/dart-custom-element-demo
this package authored by Don: https://github.com/rampage-dart/rampage


Test plotting of Herschel data after PR #281 closes

plotting of herschel_get_spec data was working but throwing errors (RuntimeWarning: Mean of empty slice) and not tested on the newest version of the plotting function. Testing needs to be done to make sure herschel data is well integrated into the plotting.

Tested and it works.


Is it possible to have a dropdown on click of the navbar-brand ?

Yes, although the dropdown menu's appearance is non-mobile even if the navbar is collapsed.
And it's not necessarily officially supported.


Backwards incompatible JDK version chang between versions 20.18.4 and 20.18.8

What happened?
Our project had "detox": "~20.18.4", defined as dependency, and was building just fine.
Some time ago, our Android build fails.
Turns out, today, this dependency is fulfilled with version 20.18.8.
Android build fails with:
> Task :app:compileDebugAndroidTestJavaWithJavac FAILED
/home/.../.../android/app/src/androidTest/java/com/gowish/app/DetoxTest.java:7: error: cannot access Detox
import com.wix.detox.Detox;
                    ^
  bad class file: /home/.../.gradle/caches/transforms-3/732cffd61dabb4adeedbea6486beacfc/transformed/jetified-detox-20.18.5-api.jar(/com/wix/detox/Detox.class)
    class file has wrong version 61.0, should be 55.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.

My understanding is that between versions 20.18.4 and 20.18.8, most probably the gradle, thus the JDK version was changed in the detox build process.
I'd argue that this is a non-backwards-compatible change (as our situation shows), and thus should've triggered a version bump.
What was the expected behaviour?
Patch versions are not supposed to introduce backwards incompatible changes.
Was it tested on latest Detox?

[X] I have tested this issue on the latest Detox release and it still reproduces.

Did your test throw out a timeout?

[ ] I have followed the instructions under Identifying which synchronization mechanism causes us to wait too much.

Help us reproduce this issue!
Check .class version using javap on compiled detox .jar files for versions 20.18.4 and 20.18.8.
In what environment did this happen?
Detox version: 20.18.4 vs 20.18.8
React Native version: 0.72.3 (gradle 7.5.1)
Has Fabric (React Native's new rendering system) enabled: not relevant
Node version: not relevant (v18.16.0)
Device model: not relevant (building for emulator)
Android version: not relevant (33)
Test-runner (select one): other (playwright-test)
Detox logs
Not relevant
Device logs
Not relevant
More data, please!

Task :app:compileDebugAndroidTestJavaWithJavac FAILED
/home/.../.../android/app/src/androidTest/java/com/gowish/app/DetoxTest.java:7: error: cannot access Detox
import com.wix.detox.Detox;
^
bad class file: /home/.../.gradle/caches/transforms-3/732cffd61dabb4adeedbea6486beacfc/transformed/jetified-detox-20.18.5-api.jar(/com/wix/detox/Detox.class)
class file has wrong version 61.0, should be 55.0
Please remove or make sure it appears in the correct subdirectory of the classpath.

Is there a chance you could use ~20.19.1 ?

@cserby  could you elaborate where do you see<EMAIL_ADDRESS>?
This version does not exist: https://www.npmjs.com/package/detox/v/20.18.8
Make sure your computers are not compromised, we never released 20.18.8.

I'm not sure if this is relevant but maybe updateGradle.js postinstall script doesn't find your react-native version and bumps your gradle to 8.3:
https://github.com/wix/Detox/blob/master/detox/scripts/updateGradle.js
Please check if this is the case.

@noomorph you're right, ~20.18.4 picks up 20.18.5, which has the wrong .class versions. Trying to update to 20.19.0 now.

Nope, 20.19.0 gives:
/home/.../android/app/src/androidTest/java/com/.../app/DetoxTest.java:7: error: cannot access Detox
import com.wix.detox.Detox;
                    ^
  bad class file: /home/.../.gradle/caches/transforms-3/3d543f4f28a52cd80ef269d181783456/transformed/jetified-detox-20.19.0-api.jar(/com/wix/detox/Detox.class)
    class file has wrong version 61.0, should be 55.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.

too.
For the time being, I'm happy with staying at 20.18.4. We'll need to figure out how to update our own toolchain soon, and that'll allow us to use newer versions of detox too.

@gosha212 if you have any ideas, please join the discussion :)

@cserby try to upgrade to the latest version of detox. Move to the android folder and execute ./gradlew clean
run detox build again.
Hope this solves your issue.

Hello !
I am also facing this issue on detox version 20.20.3 and 20.22.2
Environment
Detox version: 20.20.3 and 20.22.2
React Native version: 0.72.6 (Gradle 8.0.1)
Has Fabric (React Native's new rendering system) enabled: New architecture is not enabled
Node version: v18.18.2
Device model: Emulator Pixel 6A API 33
Android version: 33
We are trying to setup detox on react-native 0.72.6
We were on version 20.20.3 of detox and the error was occurring
I just bumped the detox version to 20.22.2 and I did all the steps required to clean android caches :

invalid cache in android studio
remove android/.gradle folder
delete root level ~/.gradle
cd android && ./gradlew clean

But we have the same kind of errors
We found a workaround by setting this in android/app/build.gradle
    // Using legacy Detox version because of the following issue:
    // https://github.com/wix/Detox/issues/4491
    androidTestImplementation('com.wix:detox-legacy:+'){
        // Adding this extra config to avoid the following error:
        // https://github.com/wix/Detox/issues/3957
        // https://stackoverflow.com/a/68675881
        exclude module: "protobuf-lite"
    }
    // Some other dependencies
   implementation ("androidx.appcompat:appcompat:1.3.1") {
        version {
            strictly '1.3.1'
        }
    }

(I tried to bump appcompat but I currently can't as it breaks everything )
Do you have any ideas on how we could debug this issue to use the com.wix:detox as suggested in the documentation? 🙂
Does an upgrade to the latest version of appcompat could be a solution ?
Thanks in advance
Best regards

@Vikmanatus Hi, did it work for you with 1.3.1? You can try 1.6.1 for example. Let me know if it works. What is the exact error you are getting?
Can you send us a link to a sample project that reproduces the issue?


[drone] Add RBAC support

What this PR does / why we need it:
RBAC support is vital for using Drone for continuous delivery on a Kubernetes stack that is running in RBAC mode. drone-kubernetes is one such plugin that will not work on RBAC-enabled Kubernetes stack with the current version of this chart.
Which issue this PR fixes: fixes #4143
Special notes for your reviewer:
These changes add RBAC support to Drone by creating a Service Account, Role, and Role Binding. Many of these templates were taken from the more popular nginx-ingress chart, which implements RBAC support well.

/lgtm

/assign @mattfarina

Please follow our RBAC best practices:
https://github.com/kubernetes/helm/blob/master/docs/chart_best_practices/rbac.md
/hold
/assign

/lgtm

@unguiculus can this continue or is it waiting on another fix before this one gets applied?

/hold cancel


more desciption plz

thx for your plugin
im install your plugin without any setup problem
but im nt find and reports
im click in generate summ reports but nothing happend
summary for what
can u give example with pic and desc

Hi, I will add pictures to the readme and develop the plugin more but for now let's say it creates summaries for the issue, i.e. when you click on the generate, it creates a summary of the issue history starting from the issue description and goes further with the notes.
For the plugin to work correctly, you have to provide API keys to the plugin from Administrator -> Plugins -> Configure (for the summary plugin)
There is description of configuration options at https://github.com/tuzumkuru/redmine_ai_summary?tab=readme-ov-file#configuration
If you don't have a key you can use Groq for free. Signup and create your API key from https://console.groq.com/keys address and copy it on API Key textbox, change the API address to https://api.groq.com/openai/ and model to llama-3.3-70b-versatile and then save the settings.
Let me know if you have more questions.


POST requests return 500 status code and empty message regardless of the chaincode response

If the chaincode returns an HTTP error code on POST request, the response from the REST API is 500 with empty message regardless of the actual response

error messages are now returned by the latest image; error codes as well as individual query responses and endorsement resumts with codes still get masked and not returned: only the error message is returned with http code 500 for everything

error status codes are now returned as http response headers such as
HTTP/1.1 404 Not Found


[Security] Workflow release.yml is using vulnerable action satackey/push-prebuilt-action

The workflow release.yml is referencing action satackey/push-prebuilt-action using references v0.2.0-beta3. However this reference is missing the commit 0c027b66503f3857cb4e5cfb71633cc54dbd1ec6 which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

@satackey


term_font: fix alacritty

Description
Fixes #1534 and #1503
This is the fix confirmed in #1534 plus ignoring comments that is needed to also solve #1503.

Ah, wait. Now it fails with unchanged default config. I'm looking into it.

I changed {getline} to {if (!getline) {exit}} in the awk command to avoid looping forever in some cases. I think it's ready now.


Chore/circ dep checks for all packages

chore: circ dep checks for all packages
Adds madge circular dependency checks to all relevant non-test packages to the husky pre push hook.
I also fixed a few low-hanging fruit circular dependencies.

It still feels fast enough - not concerned about it at the moment, but as @hikchoi mentioned we can integrate it into CI later (which would be more robust anyway).


parsing parameters with multiple values

I would like to define a parameters class like this;
case class Parameters(x: List[String], y: String)

and use clipp to parse the command line arguments like this:
app -x v1 v2 v3 -y foo

or like this:
app -x v1 -x v2 -x v3 -y foo

I think the second example is easy to implement. I would probably not do the first, it does not mix well with non-named parameters.
Also note that you can always create a list parser that accepts app -x "v1, v2, v3" -y foo (actually I think that should be added to the library too)

#183 implements parser for iterables, so you can handle `app -x "v1, v2, v3"
#184 adds a new modifier repeated { ... } which can handle app -x v1 -x v2 -x v3

Thanks, this is awesome!

Could you please make a new release with these fixes?


Add 'Site Reliability Guide for mybinder.org' to Culture section

Add 'Site Reliability Guide for mybinder.org' to Culture section

Hi @vitkhab,
Thanks for the contribution! I believe that the URL would fit better in the Reliability section since it contains more technical information than cultural.

Hi @vitkhab,
Any updates?

closing due to inactivity


Map not updating

Although data is still getting processed on Kartaview and the route per track seems to be mapped, this information isn't appearing on the combined map since about the 22nd February 2023.  Can somebody kick the machine and wake it up?  :)

could you provide some tracks id or link so that i can check the case ?

These are two recent ones I have done where the points haven't been added or new roads added.
https://kartaview.org/details/7060185/0/track-info
https://kartaview.org/details/7078393/10/track-info
Hope this helps  :)

Same here.
No processing after 22nd February 2023.
Last processed track: https://kartaview.org/details/6785209 (uploaded 22nd February)
Not processed track: https://kartaview.org/details/6789465 (uploaded 23rd February)
Latest not processed track: https://kartaview.org/details/7170217 (uploaded 1st May)
And no processing of the "motivation" points. So it seems the whole background processing does not work/run.

3 months later, the problem is still there.  Is anyone working on this website currently or is it a dead project?

Problem seems to be resolving itself and tracks are now being added to the map again!  Phew!

Same here.
All tracks since 2023-07-24 have not been processed.
Error Message: "Ups! Sequence cannot be loaded … Reload or go Back"
Last processed track: https://kartaview.org/details/7561881 (uploaded 2023-07-22)
Not processed track: https://kartaview.org/details/7570377 (uploaded 2023-07-24)
Latest not processed track: https://kartaview.org/details/7620697 (uploaded 2023-08-02)

Currently it's running again. Every sequence is processed immediately.

Great, I already had no more hope.


Can default constructor infer "const" for me?

This is a common pattern in Flutter among others:
class HelloWorldWidget extends StatelessWidget {
  Widget build(_) => new Text('Hello World');
}

I can't create this widget const though:
(_) => const HelloWorldWidget();

... unless I add the following boilerplate:
class HelloWorldWidget extends StatelessWidget {
  const HelloWorldWidget();

  Widget build(_) => new Text('Hello World');
}

I somewhat understand not making this auto-const:
class Example {}

But what about this:
abstract class Base {
  const Base();
}

class Example extends Base {}

Making a class "const-able" is a commitment. Any number of changes are incompatible with that. Most of these changes affect the constructor (having a body, having a computation in the initializer list), but just adding a non-final private field can prevent the class from being const.
If your constructor is automatically const, then clients of your class might start using that, whether you meant it or not. If you didn't intend that const, then doing any of these (otherwise invisible) changes is now breaking because the automatic const becomes automatically non-const. There is no warning at your end, you just break your clients on something that you never intended to do.
So, const is a commitment, and we require you to opt-in to it explicitly.  I don't see that changing.
If writing the const constructor is too cumbersome, we could work on shorter syntaxes for that.
Maybe you can get away with just const constructor(); instead of having to write the name (having to repeat the name is already annoying). Maybe we can allow you to write const class X { ... } which will ensure ... something (but we probably can't make all constructors const, so I'm not sure exactly what we would promise - at least we can make the default constructor const, but it's a lot of syntax to reserve for such a small effect).
In any case, not introducing const automatically is a feature, and we prefer it that way.

Perhaps a quick-fix on the class for a default const constructor would do?

I haven't seen the need for this in a while

I ran into this today:
class Foo {}

class Bar extends Foo {
  final int one;
  const Bar(this.one);
}

I was surprised that I had to add const Foo(); to make Bar be allowed to be const.  I guess I understand better after Leaf's response, but I was still surprised.  🤷

Just hit this today. Reading through this thread (specifically https://github.com/dart-lang/sdk/issues/31446#issuecomment-346756128) made me realize that this feature makes sense.


useResizeObserver + useForceUpdate

I've created a useResizeObserver hook, that replaces the existing useSize hook.
I've left the useSize hook, so you can decide whether to deprecate it / remove it altogether
It supports observing the dimensions & x/y coords, selectively updating the component depending on which properties you access

You should really add a .prettierrc and add pretty-quick to pre-commit

tslint and prettier have already been added see - #232 :)
if you use vscode, you can use the inbuilt editor code actions to fix on save... here's what i use -
{
  "editor.codeActionsOnSave": {
    //"source.fixAll.tslint": true
  }
}

however, #232 does include the ability to lint and fix for precommit

I'd recommend adding tests for your new hooks 👍

@ankithkonda I was going to, but saw most of the hooks weren't tested.

tslint and prettier have already been added see - #232 :)

There's no (.prettierrc)[https://github.com/streamich/react-use/blob/master/.prettierrc] in the repo, and the prettier settings seem to be non-default

Prettier config is here, as I understand it.

What is the reasoning for using Proxy + useForceUpdate instead of saving the dimensions into a local state using useState?

@samdenty I've simplified the PR and created a new one here, please let me know if removal of Proxy will have some negative consequences.

@streamich The reason I used a proxy is because it prevents unnecessary renders.
// The component will only update on width change, if the height changes (or any other property) it doesn't matter
const { width } = useResizeObserver()

// Will only update when x or y change
const { x, y } = useResizeObserver()

With your useResizeObserver hook it only supports width + height, and the component will will have unnecessary renders:

The top / bottom / x / y property of an element changes
When height or width changes, regardless of whether are using both in the component


Add a links option

Needed to add container links when trying to script selenium hub and browsers.

Hi,
Will the "link" option be merged anytime soon? This library seems to be very promising, but without this option, the use cases are very limited...

Done!

2.4.0

@darrinholst thanks for adding this. do you wanna help maintain this module?

wow, already? a release in 10 minutes is just awesome! I'm starting to play with this lib and I'll tell you if I need more options :)

@mafintosh sure, I can help where I can

@darrinholst thanks - added you as owner


test: use T.TempDir to create temporary test directory

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
/kind test
What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
We can use the T.TempDir function from the testing package to create temporary directory. The directory created by T.TempDir is automatically removed when the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
Please provide a short message that should be published in the DevSpace release notes
N/A, this is a testing enhancement.
What else do we need to know?

@Juneezee Thank you for your contribution. :)


NIAP APE_ECD.1-5 Evaluation Comments against the HCD cPP

As part of NIAP’s review process of the HCD cPP, we performed an evaluation of the APE work units and identified several needing correction. Please see the following comments:
APE_ECD.1-5, The evaluator shall examine the extended components definition to determine that each extended functional component uses the existing CC Part 2 components as a model for presentation. --
In general, the ECD SFRs are duplicates of their body text equivalents. However, there are cases where they should differ.
a,- FCS_TLSC_EXT.1 has "selection: select supported ciphersuites from List 1" in the ECD SFR which doesn't make sense in the context of the component definition (the ECD doesn't 'know' that List 1 exists).

same issue in FCS_TLSS_EXT.1, FCS_DTLSC_EXT.1, FCS_DTLSS_EXT.1

b. In general the ECD should not reference iterated SFRs - un-iterated versions of the SFRs should be referenced (in case the component is reused by a different PP/ST that does not use the same convention for iterations). The ECD doesn't "know" about iterated SFRs in the body of the document it lives in. This happens in:

FCS_KYC_EXT.1.1
FDP_DSK_EXT.1.1
FPT_KYP_EXT.1.1

c. FPT_KYP_EXT.1.1 has "Refinement:" In the title of the SFR but this makes no sense in the context of an ECD because the ECD is by definition what refinements get made off of.
d. FDP_UDU_EXT.1.1 is incorrectly called "FDP_UDU_EXT.1"
e. FDP_UDU_EXT.1.1 references "D.USER.DOC" which is a PP-specific term, it would be better if the ECD version of this SFR would make this an assignment and the body text version of the SFR would fill it out with the PP-specific information. Title should also not be PP-specific
e. FPT_WIPE_EXT.1.1 uses square brackets with "D.USER, D.TSF" in it in the ECD. This should be a blank assignment in the ECD version of the SFR with the body text version filling it out with the PP-specific data.
f. FIA_X509_EXT.1.1/Rev has a refinement in the ECD version of the SFR. This makes no sense as the refinement used to show changes from the baseline and the ECD is the baseline.
g. The ECD should not pre-define SFRs with an iteration as this is not consistent presentation with Part 2. FIA_X509_EXT.1/Rev should just be called FIA_X509_EXT.1.
h. FCS_PCC_EXT.1.1 defines an assignment with only one option - should be [assignment: list of of standards] or similar.
We believe an errata version may be worth considering to resolve them.

This issue is addressed by the following TD:

HCD0002

The TD above is located at the following location:

https://github.com/HCD-iTC/HCD-iTC-Template/tree/Working/TD


Add role="..." to Table family components when component="..." is specified

Summary 💡
For table accessibility, when component="..." is specified to Table family components, it'd be better to render role="..." prop.
Examples 🌈

 will be

.
Motivation 🔦
I want to make the entire row  tag to support some browser features like drag-and-drop link and new tab shortcut (cmd+click).

@ypresto This sounds like a good idea. Do you want to work on the problem?

If @ypresto is busy I can take care of that ☺


chore: add e2e coverage

Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report

Merging #23 (4e59f78) into main (4ecebf3) will decrease coverage by 10.53%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #23       +/-   ##
==========================================
- Coverage   18.89%   8.37%   -10.53%
==========================================
  Files          95     258      +163
  Lines        8890   22163    +13273
==========================================
+ Hits         1680    1856      +176
- Misses       6982   20063    +13081
- Partials      228     244       +16

Flag
Coverage Δ

e2e-tests
1.32% <ø> (?)

unit-tests
18.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 163 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Question] Unit Testing function types

Hi ReSwift team, really like the library, and enjoy all the good work you're doing with it!
I was wondering why Middleware (and it appears Reducer now) is a function type, since it appears to not allow dependency injection. Let's say I have a middleware that makes network calls to a service of mine. Based on the action that comes in, it calls a MyService object that abstracts away the implementation details of the actual call. I'd like to be able to do something like this:
class ServiceMiddleware: Middleware {
    let myService: MyService
    init(myService: MyService) {
        self.myService = myService
    }

    func interceptAction(dispatch: DispatchFunction, getState: () -> StateType?) {
        // Something that captures an action, calls MyService, and then when it returns,
        // sends a new action with the data from MyService
    }
}

However, as a function type I'm not really sure how I would go about testing, since there would be no way to inject a fake MyService object into the function. TBH, I have no experience with functional programming, so maybe there's something I'm missing.

Hi @ethanjdiamond 😄 . You are asking a great question!
There's a functional way to overcome this apparent limitation. In Swift functions are first time citizens, which among other things means that you can have functions return other functions.
This means that you can write a function in which you inject your dependencies, and have it return a middleware or reducer. For example:
let analyticsMiddleware: (AnalyticsService) -> Middleware = { service in
    return { _, _ in
        return { next in
            return { action in
                switch action {
                case let action as SomeAction:
                    service.logEvent(action.someProperty)
                case let action as AnotherAction:
                    service.logOtherEvent(action.someOtherProperty)
                default:
                    break
                }

                return next(action)
            }
        }
    }
}

As for why those are better as functions than objects... I'm not the author of the library, and have no real experience with Redux on which is inspired, but here's what I think.
The main advantage in having reducers and middleware being pure functions is that, when paired with value types, they enforce the immutability. This will prevent users from mutating their StateType without realizing it. Immutability is one of the big advantages of Redux, and one of the reasons it's such a safe architecture, and as such should be defended "at all costs". 🛡 .

@ethanjdiamond I had a quick googling around, this article might be interesting for you as well.

@mokagio That article was super helpful. Thanks!


Add simple controller tests

Add simple test infrastructure and two end to end tests.
Build Docker image and deploy controller

Add Dockerfile for generic controller.
Add RBAC support for generic controller manager.
Update "make deploy" target to deploy controller.
Update "make kind-create" target to allow importing
private docker images.
Add new "make test-int" target for running integration tests.

Install generated CRDs in Kind to ensure validity.

Coverage decreased (-1.1%) to 47.046% when pulling f135bef7057936b31f9e3d33352bff2929055762 on feature/controller-testing into 0178ee9b3fa1b64ebd9f188d0ff001cce545ca89 on master.


RuntimeError when using MAP-metric

🐛 Bug
Hi! I am training a detection model and use MAP-metric during validation.  I got the following error at the validation_step:
RuntimeError: expected scalar type Float but found Bool.
To Reproduce
Pick a faster rcnn model, I used fasterrcnn_resnet50_fpn_v2() from torchvision . Implement validation_step where
self.metrics.update(...) is called for the model results and targets and validation_epoch_end where the self.metrics.compute() is called for the previously gathered results.

Code sample
import torchvision
from torchvision.models.detection.faster_rcnn import FastRCNNPredictor
from torchmetrics.detection.mean_ap import MeanAveragePrecision

class FasterRCNNModel(pl.LightningModule):
    def __init__(self, num_classes):
        super().__init__()

        model = torchvision.models.detection.faster_rcnn.fasterrcnn_resnet50_fpn_v2()
        in_features = model.roi_heads.box_predictor.cls_score.in_features
        model.roi_heads.box_predictor = FastRCNNPredictor(in_features, num_classes)
        self.model = model
        self.metric = MeanAveragePrecision(box_format='xyxy', iou_type='bbox')

    def validation_step(self, batch, batch_idx):
        images, targets = batch
        preds = self.model(images)
        self.metric.update(preds, targets)

    def validation_epoch_end(self, outs):
        mAP = self.metric.compute()
        self.log("val/mAP", mAP)
        self.metric.reset()

targets (List[Dict]), containing:

boxes (torch.float32)
labels (torch.int64)

preds (List[Dict]), containing:

boxes (torch.float32)
scores (torch.float32)
labels (torch.int64)

Error message
  File "/homes/vsoboleva/scripts/pascal_voc/train.py", line 65, in validation_epoch_end
    mAP = self.metric.compute()
  File "/homes/vsoboleva/miniconda3/lib/python3.9/site-packages/torchmetrics/metric.py", line 523, in wrapped_func
    value = compute(*args, **kwargs)
  File "/homes/vsoboleva/miniconda3/lib/python3.9/site-packages/torchmetrics/detection/mean_ap.py", line 908, in compute
    precisions, recalls = self._calculate(classes)
  File "/homes/vsoboleva/miniconda3/lib/python3.9/site-packages/torchmetrics/detection/mean_ap.py", line 758, in _calculate
    recall, precision, scores = MeanAveragePrecision.__calculate_recall_precision_scores(
  File "/homes/vsoboleva/miniconda3/lib/python3.9/site-packages/torchmetrics/detection/mean_ap.py", line 831, in __calculate_recall_precision_scores
    det_scores = torch.cat([e["dtScores"][:max_det] for e in img_eval_cls_bbox])
RuntimeError: expected scalar type Float but found Bool

Expected behavior
The sel.metric.compute(...) compute values correctly and does not fail with RuntimeError: expected scalar type Float but found Bool.
Environment

TorchMetrics 0.9.2 build with pip
Python 3.9.12, torch 1.12.0, torchvision 0.13.0
OS (e.g., Linux): Ubuntu 20.04.3

Additional context

Hey @V-Soboleva, I've been dealing with the same issue. I think the issue occurs on the 'scores' prediction from the maskrcnn model. It seems that when no detection is found, the model outputs a tensor of type bool. I'm unsure if it's fixed yet but i've just type casted it as follows:
output['scores'] = output['scores'].type(torch.float)

Thank you @dreaquil, but unfortunately it didn't help : (

Hey @V-Soboleva! Yeah, just ran into the same issue again... Will let you know if I find a resolution.
As a note:
I tried to type sanitise the entire pred input:
@staticmethod
    def _sanitise_preds(preds: List[Dict]) -> List[Dict]:
        for pred in preds:
            pred["boxes"] = pred["boxes"].type(torch.float)
            pred["scores"] = pred["scores"].type(torch.float)
            pred["labels"] = pred["labels"].type(torch.int)
            if "masks" in pred:
                pred["masks"] = pred["masks"].type(torch.bool)
        return preds

I don't think you can exclude problems in predictions (but perhaps in targets). In the above code, you're not doing any weight updates, therefore unlike in training your models output predictions aren't changing per epoch. It just means that with random initialisation, the output is unlikely to cause an error.

@V-Soboleva, when you were getting the error, was it at a random epoch or was it immediately?

okay I think I found it:
https://github.com/Lightning-AI/metrics/blob/31c384411bc9a28f4ad2085cf123f68f382b6f82/torchmetrics/detection/mean_ap.py#L505
I believe this type needs to be changed to torch.float32 from torch.bool
Can you check that by changing the above, you're no longer experiencing the issue please?

Thanks for confirming @Simon128. Seems to have fixed it for me too. Will create a PR.

@dreaquil, changing the type helped me as well :)  Thank you very much!

For testing purpose to make sure the bug is indeed fixed, could someone provide a single input example where this fails currently?

Hi @SkafteNicki, the failure is related to the when the model outputs no detections. I will try get a specific example later this morning.

Hi @dreaquil, @SkafteNicki I tried to reproduce an error and save predictions and targets on which error occures during the training. However, when I tried to compute metrics with these saved tensors without training the error does not occures 🤷♀.
But I have a colab notebook where this error occures at 50% of the first epoch (when validation starts) if it could be helpful.

This issue happens when using PyTorch 1.12.0 on GPU device, the minimal code to reproduce this issue is shown below.
In [1]: import torch

In [2]: torch.__version__
Out[2]: '1.12.0+cu102'

In [3]: torch.cat([torch.zeros(0, dtype=torch.bool, device="cpu"), torch.zeros(1, dtype=torch.float32, device="cpu")])
Out[3]: tensor([0.])

In [4]: torch.cat([torch.zeros(0, dtype=torch.bool, device="cuda:0"), torch.zeros(1, dtype=torch.float32, device="cuda:0")])
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Input In [4], in <cell line: 1>()
----> 1 torch.cat([torch.zeros(0, dtype=torch.bool, device="cuda:0"), torch.zeros(1, dtype=torch.float32, device="cuda:0")])

RuntimeError: expected scalar type Float but found Bool

Although, the CPU implementation and other versions of PyTorch can cast 0-dim bool Tensor to float Tensor. The dtScores should be initialized because a float type as score is usually a real number.
@SkafteNicki

For testing purpose to make sure the bug is indeed fixed, could someone provide a single input example where this fails currently?

The current test case in tests/unittests/detection/test_map.py do not cover this bool float concatenate case. There is only one pair of pred and target in _inputs3. Adding another pair of pred and target can fail the tests. e.g.
_inputs3 = Input(
    preds=[
        [
            dict(
                boxes=Tensor([[258.0, 41.0, 606.0, 285.0]]),
                scores=Tensor([0.536]),
                labels=IntTensor([0]),
            ),
        ],
        [
            dict(boxes=Tensor([]), scores=Tensor([]), labels=Tensor([])),
        ],
    ],
    target=[
        [
            dict(
                boxes=Tensor([[214.0, 41.0, 562.0, 285.0]]),
                labels=IntTensor([0]),
            )
        ],
        [
            dict(
                boxes=Tensor([[1.0, 2.0, 3.0, 4.0]]),
                scores=Tensor([0.8]),
                labels=Tensor([1]),
            ),
        ],
    ],
)

What's the recommend workaround for this currently?

@austinmw should be fixed now by PR #1150.
Please try installing from master:
pip install https://github.com/Lightning-AI/metrics/archive/master.zip

which should solve the issue. If not, please report back and we can reopen the issue and try to fix it.


Upgrade dependencies for v4.2

package.json
Electron

[x] Electron and Spectron #820
[x] electron-builder #820

Build tools

[x] Babel #822
[x] Webpack #822

Test tools

[x] ESLint #823
[x] Other test tools #823

Others

[x] Other devDependencies #823

src/package.json
React

[x] React #824
~- [ ] React-Bootstrap~ No updates

Others

[x] Other dependencies #824

All done. Recently packages are more stable than past upgrading. We would be able to upgrade them sooner since next release.


Update topic expiry time in Metadata every time the topic metadata is requested

#As of current implementation, KafkaProducer.waitOnMetadata() will first reset topic expiry time of the topic before repeatedly sending TopicMetadataRequest and waiting for metadata response. However, if the metadata of the topic is not available within Metadata.TOPIC_EXPIRY_MS, which is set to 5 minutes, then the topic will be expired and removed from Metadata.topics. The TopicMetadataRequest will no longer include the topic and the KafkaProducer will never receive the metadata of this topic. It will enter an infinite loop of sending TopicMetadataRequest and waiting for metadata response.
This problem can be fixed by updating topic expiry time every time the topic metadata is requested.
Ping @becketqin for review.

LGTM

cc @rajinisivaram

KafkaProducer.waitOnMetadata() doesn't wait indefinitely as mentioned in the description, it waits for max.block.ms which is one minute by default.  Since expiry time is reset at the start of KafkaProducer.waitOnMetadata(), with the default config, topics are never expired while waiting for metadata. The issue is when max.block.ms is greater than the hard-coded 5 minute topic expiry time. At the moment, the wait continues beyond topic expiry until max.block.ms, but the topic is no longer in the metadata. This PR fixes that. It will be good to add a unit test for this scenario.

@rajinisivaram Are you suggesting to change the code and add the test, or are you suggesting to add the test only?
I think it can be tested like this:

Initialize a KafkaProducer with maxBlockMs = 10 minutes
Call producer.waitOnMetadata(...) for a non-existent topic
Verify that the topic is still in the metadata after 6 minutes.

The problem with this test is that it takes 6 minutes to finish this test. I am not sure that the test is worth the 6 minutes because it is pretty clear that waitOnMetadata() will keep refreshing the topic in metadata if maxBlockMs > topic expiry time.
Alternatively I can add a test like this:

Initialize a KafkaProducer with maxBlockMs = 10 minutes and retryBackOffMS = 1 seconds
Call producer.waitOnMetadata(...) for a non-existent topic
After 3 seconds, Verify that the age of the topic in metadata is less than 2 seconds

But this test doesn't directly verify that the topic won't be deleted from metadata in this scenario. I can add this test thought I personally don't think it is very useful.
What do you think?

I realized that this is a way to test the scenario without waiting for 6 minutes wallclock time. I will try it.

@lindong28 I was suggesting that you could add a test that passes with the code from this PR and fails without. You can do so with a unit test that uses MockTime.

@rajinisivaram @ijuma @becketqin I have added test. Thanks.

retest this please

@rajinisivaram Do you want to merge this patch?

@becketqin I haven't yet read through the committer documentation, but I can get to this tomorrow. If there is no hurry to merge this PR today, then this could be my first commit :-) Thanks.

@rajinisivaram Awesome. It is not urgent. :)

@lindong28 Can you include the JIRA in the PR title so that the PR gets linked to the JIRA?

@rajinisivaram Certainly. It is updated now. I forgot to include this in the title previously.

@lindong28 Can you also update the PR description since it appears as the commit message? The title should be using colon rather than semi-colon. Thank you.

@rajinisivaram FYI, the merge script automatically fixes the title to fit the convention. It also lets you edit the title easily. It doesn't let you edit the PR description though (it's possible to do it via git commit --amend, but maybe better to avoid more advanced flows until later :)).

@ijuma Thank you, I started with the tool, got as far as the commit and it didn't give me an option to update the message. I mentioned the semicolon because the JIRA doesn't currently have a link to this PR, perhaps that needs the PR to be closed and reopened? Or will the merge tool add comment and close JIRA anyway? Thanks.

@rajinisivaram Looking at the git log it seems that we use both colon and semi-colon after the ticket number? It also seems that we don't generally include full description of the problem in the commit message (which we do in the PR description) because that may be too verbose. For example, we probably don't want to include "Ping @becketqin for review." in the commit message.
@becketqin mentioned that you can include edit PR title and not include PR description in the commit message.  I have checked after the commit and it looks fine. Thanks.

@rajinisivaram Sure. I understand. Thanks for the review!

"@rajinisivaram Looking at the git log it seems that we use both colon and semi-colon after the ticket number? It also seems that we don't generally include full description of the problem in the commit message (which we do in the PR description) because that may be too verbose."
This is not accurate. The merge tool will use the PR description as the commit message of the squashed commit. This is explained in the wiki page for contributors. As such, you should not ping reviewers in the PR description. You should instead do that as a separate comment.
"@becketqin mentioned that you can include edit PR title and not include PR description in the commit message. In other words, you can choose not to include PR description and edit commit message in any way you like."
Editing the title is correct as I said. The PR description bit is again not accurate. The only way to change that is via direct git commands, the PR tool doesn't provide that functionality (I wrote it, so I would know :)).
@rajinisivaram, not sure if it was clear, but I said the tool allows you to update the commit title, but not the commit message. However, you can update the commit message by using git commit --amend in a separate shell just before saying y to push the merged change. This is advanced usage and it's possible to make mistakes like including local files from your checkout (which has happened when people are not careful).

@ijuma
"Editing the title is correct as I said. The PR description bit is again not accurate. The only way to change that is via direct git commands, the PR tool doesn't provide that functionality (I wrote it, so I would know :))."
Is it true that committer can choose not to include PR description and edit PR title? If so, that effectively allows committer to edit PR description freely in the commit message.

No, that's not true.


memory leak, DOM nodes

https://codepen.io/wyzix33/pen/aeaMJx
Your Environment

flatpickr version used:4.6.2

Browser name and version: Chrome Version 76.0.3809.100 (Official Build) (64-bit)

OS and version: Windows 10

I'm detecting a Memory leak when creating and destroying flatpickr, Please test with that pen, just press add, click the input to see the calendar and click remove to destroy it, repeat ...
This is what i'm getting:

Thanks

+1
I try to destroy flatpickr instance to reuse the input (last version 4.6.2) but this seem always exist in the DOM. and this create some conflicts for the init date also
in the library : first initialization work fine but the next is wrong, on the second for example, init nodes is equal to
(14) [input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input]

If I "console.log(self)" at the end of destroy() function, self is always with a flatpickr instance and input freshly set with a new flatpickr instance have a good value first and if click on the inut set a default now value.

Same issue here, any update?

any update?

same

It seems that I have the same problem and I think that I have a patch to get rid of the leak, I simply assign null to all the DOM elements that Flatpickr creates
this.flatInstance.destroy();
if (this.flatInstance.element) {
      this.flatInstance.monthElements = null;
      this.flatInstance.yearElements = null;
      this.flatInstance.input = null;
      this.flatInstance.element = null;
}
this.flatInstance = null;

Note that I'm not using time in my code so there might be some extra elements to nullify.
... and that seems to enough for the garbage collector to eventually (after just a few seconds) get rid of the detached DOM elements that Flatpickr was leaving behind.

Hi,
@ghiscoding It helps but still get 1 listener and about 200 nodes leaked per instance ...

Unfortunately, I'm done with my research and I'm not sure what else can cause this but did you get latest code? I made another PR #2329 to fix the keyboard event leaks which got merged but wasn't released yet.

Nice, i'll try it
Thanks

Can confirm this, the patch from @ghiscoding does not work for me either.
The profiler shows what happens when I repeatedly open/destroy flatpicker instances for 10s and then wait another 10s.

Hey guys,
This seems to have become an issue again recently.
It's happened before and is definitely solvable. I'll investigate what's causing the leak and push out a fix.
Will keep you all posted :)

@chmln do you have any news about this issue?

We experience the same issue in our app, and I think the issue lies in the fact that you inject flatpikr via the prototype and my gut is that the closure holds the context (this->element) and prevent the elements from being garbage collected.

Prototype injection is very bad IMO, see other issues: https://github.com/flatpickr/flatpickr/issues/1498
Would you accept a PR ? If you are concerned about the breaking change, I think the ESM build should not inject anything...


Fix boundary condition issue mentioned in #826

This PR adds the sum check after the increment itself to avoid the boundary condition where kruize was not able to generate the recommendation
Fixes #826

@bharathappali please update the test results. Also the PR check is failing, it looks like the e2e test needs to be updated to incorporate this fix?

Merging this as the PR check failure has been confirmed to be a testcase issue


Improved cfn2py

Hi,
I improved cfn2py to the point where it can roundtrip the examples (except for the OpenStack examples). It also works with some private files that include AWS::CloudFormation::Init sections.
Though not perfect and not used every day, cfn2py was my gateway to using troposphere. I think these improvements might help the next future users to step onboard.
To test with the examples, I used the following script:
#!/bin/sh

if ! [ -d tmp ] ; then mkdir tmp ; fi

for i in examples/*.py ; do
    BASE=tmp/`basename $i .py`
    if python $i >$BASE.json1 2>&1 ; then
        echo $i;
        ./scripts/cfn2py $BASE.json1 > $BASE.py ;
        python $BASE.py > $BASE.json2 ;
        cmp $BASE.json1 $BASE.json2
    fi
done

Sincerely,
Mathias Brossard
PS: I haven't coded much in Python, so there is probably some room for improvement.

I've rebased my commits on master.

Thanks @mbrossard for rebasing this and for the PR!


worker_name is not populated in bpool_local_db

All of the fields in the db get populated when a client connects to sserver just fine except the worker_name is NULL
Does anyone know how to get the worker_name to populate into the DB?
Thanks in advance

statshttpd can update it, but the method it uses is not efficient enough. Consider running this independent update program:
https://github.com/btccom/btcpool/tree/master/tools/worker_update


Add a recommending order action to service

As a user of this service
I need to have a feature to recommend an order
So that I can recommend certain orders to other users
Assumption

The order already exists in the database
The order is able to be read by the database

Acceptance Criteria
Given an order_ID and
When the recommended action endpoint is called
Then the order linked to that order_ID will be recommended to users and all of the details will be listed

Where is this requirement written in hwk 2?


Upgrade to the latest release of AmongUsCapture

Feature
Update to a released version of AmongUsCapture, rather than the beta build currently used.
Reasons for Implementing
It's better to be on a public release version than a private build.
This is a really, really easy first issue. Just replace the exe in downloads and update the version number in the index.

This issue is resolved in version 2.1.0-beta.1

This issue is resolved in version 2.1.0


Support for setting account (backups) to "archived" or "offline"

Hi @joeyates !
Another use case from daily life. I've a backup of an old, decomissioned IMAP account. To avoid it being it included into my weekly imap-backup backup, I obviously removed the account.
Now i want to migrate the content and realize the best would be, to have two different accounts in place.
Hence I currently miss a functionality to set an account (backup) to offline. I'll re-add the account now for migration and then manually remove it again. Or do I miss something?

Hi @bentolor
There is a way of doing this, but it may not be the most user-friendly approach :)
By default, imap-backup backs up all configured accounts.
To skip one/some, you would need to explicitly list the accounts you actually want backed up:
imap-backup backup --accounts=me<EMAIL_ADDRESS>

Would you be open to adding a config option to mark an account as archived (ie: initial remote IMAP server no longer exists) so it is automatically skipped, yet  be able to use the other features on it (local, utils)?

Hi @axelsimon
Yes, I would! :smile:
Any PR would need to handle UI for handling this in setup (and have tests!).


Sometimes terminal isn't rendering after maximize from taskbar

Terminal isn't drawing correctly after maximize from minimized state sometimes. Not 100% of cases.
Environment
Windows build number: Version 10.0.18362.476
Windows Terminal version (if applicable): 0.6.2951.0

Using it for WSL 1

Steps to reproduce

minimize terinal
expand terminal

Expected behavior
terminal being drawn correctly:

Actual behavior
content of the background window is being painted (in this case Desktop)

If I resize the window it goes back to the norm.

Parts of screenshot ar blurred for privacy, the actual app wasn't blurring content of background window, just rendered header bar, and not rendered content.

This one looks like a /dupe of #3446. Thanks!


nixos: Use generic python3Packages instead of specific python versions

Correct nixos packages to use the generic Python 3 package set and not tie to a specific minor version.

There's also a near-even split between pythonPackages and python3Packages. nix-ros-overlay uses the same package set for both, so I'm not sure which is more appropriate. @lopsided98 do you have any thoughts on this?

Regarding pythonPackages vs. python3Packages: in nixpkgs pythonPackages has always been Python 2 for backwards compatibility reasons, similar to the Debian/Ubuntu package names. I always used pythonPackages for Python 2 packages in rosdep, with the added complication that I would sometimes override pythonPackages in nix-ros-overlay for a particular distro to point at python3Packages to allow me to use Python 3 for distros that were technically supposed to use Python 2. This was particularly important at the tail end of melodic's life because by that point Python 2 was EOL and mostly removed from nixpkgs. Now that melodic is EOL, all the distros use Python 3 and this is mostly irrelevant.


[Azure Devops Extension][Post-pulling docker image] Unable to clone repository due to authentication issue

Describe the bug
I don't understand why the cloning gets rejected while the PAT (personal access token) has full access to code and PRs? Knowing that image pulling works fine.
My source files
This is my .azuredevops/dependabot.yml :
version: 2
updates:
  - package-ecosystem: "npm"
    directory: "/"
    schedule:
      interval: "daily"

And the following is my pipeline file :
trigger: none

pool:
  name: <MySelfHostedAgentName>

steps:
  - task: dependabot@1
    inputs:
      authToken: <MyPAT>
      azureDevOpsAccessToken: <MyPAT>
      extraEnvironmentVariables: AZURE_ORGANIZATION=tfs/DefaultCollection

Expected behavior
Im expecting the clone-repo task to work properly without any issues !
Logs
The following is the log im getting on Azure Devops build :
##[section]Démarrage : dependabot
  ==============================================================================
Task         : Dependabot
Description  : Automatically update dependencies and vulnerabilities in your code
Version      : 1.28.708
Author       : Tingle Software
Help         : For help please visit https://github.com/tinglesoftware/dependabot-azure-devops
  ==============================================================================
  [command]/usr/bin/docker run --rm -i -e DEPENDABOT_PACKAGE_MANAGER=npm -e DEPENDABOT_OPEN_PULL_REQUESTS_LIMIT=5 -e DEPENDABOT_DIRECTORY=/ -e DEPENDABOT_FAIL_ON_EXCEPTION=true -e AZURE_ORGANIZATION=DefaultCollection -e AZURE_PROJECT=MY20%PROJECT -e AZURE_REPOSITORY=expo-starter-kit -e AZURE_ACCESS_TOKEN=mvtvk5icfdhkvjqfvr3kans6oonqfdp6ss2bccrincv3l6gk3btq -e AZURE_MERGE_STRATEGY=squash -e AZURE_HOSTNAME=tfs.myeditions.com -e AZURE_VIRTUAL_DIRECTORY=tfs -e AZURE_ORGANIZATION=tfs/DefaultCollection ghcr.io/tinglesoftware/dependabot-updater-npm:1.28 update_script
  Using 'https://tfs.myeditions.com:443/tfs/' as API endpoint
  Pull Requests shall be linked to milestone (work item) 0
  Working in tfs/DefaultCollection/MY20%PROJECT/_git/expo-starter-kit, 'default' branch under '/' directory
  Cloning repository into /home/dependabot/dependabot-updater/tmp/tfs/DefaultCollection/MY20%PROJECT/_git/expo-starter-kit
/home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/dependabot-common-0.253.0/lib/dependabot/file_fetchers/base.rb:175:in `rescue in clone_repo_contents': Cloning into '/home/dependabot/dependabot-updater/tmp/tfs/DefaultCollection/MY20%PROJECT/_git/expo-starter-kit'... (Dependabot::RepoNotFound)
fatal: Authentication failed for 'https://tfs.myeditions.com/tfs/DefaultCollection/MY20%PROJECT/_git/expo-starter-kit/'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/dependabot-common-0.253.0/lib/dependabot/file_fetchers/base.rb:163:in `clone_repo_contents'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation_2_7.rb:59:in `bind_call'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation_2_7.rb:59:in `block in create_validator_method_fast0'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/dependabot-npm_and_yarn-0.253.0/lib/dependabot/npm_and_yarn/file_fetcher.rb:50:in `clone_repo_contents'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation.rb:270:in `bind_call'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation.rb:270:in `validate_call'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/_methods.rb:277:in `block in _on_method_added'
  from bin/update_script.rb:505:in `<main>'
/home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/dependabot-common-0.253.0/lib/dependabot/shared_helpers.rb:429:in `run_shell_command': Cloning into '/home/dependabot/dependabot-updater/tmp/tfs/DefaultCollection/MY20%PROJECT/_git/expo-starter-kit'... (Dependabot::SharedHelpers::HelperSubprocessFailed)
fatal: Authentication failed for 'https://tfs.myeditions.com/tfs/DefaultCollection/MY20%PROJECT/_git/expo-starter-kit/'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation.rb:167:in `bind_call'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation.rb:167:in `validate_call_skip_block_type'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation.rb:109:in `block in create_validator_slow_skip_block_type'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/dependabot-common-0.253.0/lib/dependabot/file_fetchers/base.rb:792:in `block in _clone_repo_contents'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/dependabot-common-0.253.0/lib/dependabot/shared_helpers.rb:265:in `with_git_configured'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation.rb:270:in `bind_call'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation.rb:270:in `validate_call'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/_methods.rb:277:in `block in _on_method_added'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/dependabot-common-0.253.0/lib/dependabot/file_fetchers/base.rb:776:in `_clone_repo_contents'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation.rb:270:in `bind_call'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation.rb:270:in `validate_call'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/_methods.rb:277:in `block in _on_method_added'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/dependabot-common-0.253.0/lib/dependabot/file_fetchers/base.rb:165:in `clone_repo_contents'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation_2_7.rb:59:in `bind_call'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation_2_7.rb:59:in `block in create_validator_method_fast0'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/dependabot-npm_and_yarn-0.253.0/lib/dependabot/npm_and_yarn/file_fetcher.rb:50:in `clone_repo_contents'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation.rb:270:in `bind_call'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/call_validation.rb:270:in `validate_call'
  from /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11352/lib/types/private/methods/_methods.rb:277:in `block in _on_method_added'
  from bin/update_script.rb:505:in `<main>'
##[error]The process '/usr/bin/docker' failed with exit code 1
##[section]Finalisation : dependabot

Extension (please complete the following information):

Host: Azure Devops On-premise Server
Version Dev17.M153.5 (2019)

Additional context
I checked with our IT team about the issue, they can't find any solution to solve this issue. Pleas help

@firasrg, your access token mvtvk5icfdhkvjqfvr3kans6oonqfdp6ss2bccrincv3l6gk3btq has been exposed. Remember to roll/regenerate/revoke it if you already haven't
Regarding the authentication issue, there seems to be an issue with TFS or Azure DevOps server according to #1034. We do not use either of the two so fixed related to that will have to be contributed by someone who uses the same since they have the ability and time to test. I will close this, lets track via the issue above.