Readme is outdated

The readme is outdate for this repo, the schematic screenshots or some of the other stuff like the table of core libraries is missing snippets.
There would be more things which needs to be updated according to your judgement

Hey @imrishabh18 , I would like to work on this issue - here are my few enhancement ideas -
We can reorder some sections (this is my opinion but would love to hear from everyone) - right after the links and our brand logo, we can have an introductory video of Severin.
Also we should add Table of contents after our hero header, starter links and intro video. This will help to navigate very easily 💙
Sections:

Hero header - which will have our brand logo with tagline React for Circuits
Starter links (we already have) but we can write them in formatted way and add a few more things like - commit activity pill eg. 65/month
Introductory video from Severin
About Tscircuit - this will describe and give a brief content about tscircuit
Example circuits section (this we have currently but can improve this how we have written and polish it more upon discussing with maintainers)
Community and next steps section where we can write about our community, our initiatives of giving bounties, talk a brief about our community meetings and write in short about what next steps we are planning
Getting Started section which we currently have (can move up too somewhere upon discussions)
Contact us section where we can write a brief about how can someone contact the team
Developer setup guide (can write here or can move it to CONTRIBUTING.md file (currently we don't have but I think we should create it) , where we can write the steps a developer should follow to setup on their local
Want to contribute to TSCircuit? You are most welcome section - We will directly add a link here for CONTRIBUTING.md file
Repo Activity (Can move up as well upon discussions) , I discovered - https://repobeats.axiom.co/ which generates an image with detailed analytics about the repo eg. https://repobeats.axiom.co/api/embed/50fd88e948fb4cc0a2d2041b8a8534a0dd7852e6.svg
Development/Sub project org (we already have this but can polish it)
FAQs (we have this but needs more polishing about the content)

Yea we should do enhancements incrementally (each one could be a PR for example), it really depends on the execution for almost all of these- but generally agreed these all sound great...
(8) is just discord I think, no need to have a specific section for that.
For point 11, this repo doesn't really have that much activity because it's an "aggregate package"- so I'm not 100% sure that would work on this particular repo (it could work on repos like core, we might even be able to list multiple repos in the beats? it's a cool image)

Yea we should do enhancements incrementally (each one could be a PR for example), it really depends on the execution for almost all of these- but generally agreed these all sound great...
(8) is just discord I think, no need to have a specific section for that.
For point 11, this repo doesn't really have that much activity because it's an "aggregate package"- so I'm not 100% sure that would work on this particular repo (it could work on repos like core, we might even be able to list multiple repos in the beats? it's a cool image)

Cool! Noted the feedback for initial implementation plan, I'll be sending PR in chunks for the same to get feedbacks for each! 😄
Yes @seveibar , we can generate image for each repository ⚡if we want to combine in one image with multiple repos, from what I have checked it's not possible in one image but we can add multiple image in README of how we want. 💙


Support rank 1 multidim arrays.

Not saying this is a must-do - just need an issue comment for a disabled test.

@AtsushiKan this works fine with the open source CoreRT compiler.
It's a bit odd to track the closed source, UWP-only compiler limitations in the public repo. We might want to come up with a label for this kind of issues if tracking on GitHub is a must, but I would prefer not track issues like this here.

Turns out there's interesting behaviors we still don't cover in the runtime/compiler even on the CoreRT side.
Once we cover those, we're free to bring down the limitation on the ProjectN side (in terms of reflection/type loader). Statically, we'll still not support them with the ProjectN compiler, but that will fix itself with time. The test blocked on this on the CoreFX side doesn't test the static case as that's only available in IL.
See dotnet/coreclr#11034.

Reopening and assigning to myself - need to now reenable those corefx tests that we disabled with this issue.

Tests reenabled.


Etcd cannot depend on resources in another stack

The dependency on the other stack gives errors. Starting the etcd node
before the natgateway is deployed is not a big issue as it keeps
restarting its proces to fetch its data. Wait signal should be long
enough for this to be resolved.
Fixes https://github.com/kubernetes-incubator/kube-aws/issues/1332

Codecov Report

Merging #1667 into v0.13.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           v0.13.x    #1667   +/-   ##
========================================
  Coverage    25.46%   25.46%
========================================
  Files           98       98
  Lines         5054     5054
========================================
  Hits          1287     1287
  Misses        3624     3624
  Partials       143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acbaaf8...a59e353. Read the comment docs.

Thanks @koen92 this looks great - could you cherry pick this to v0.14.x and master please?

Thanks @koen92 this looks great - could you cherry pick this to v0.14.x and master please?

Thank you for your reaction, I cherry picked them see:

https://github.com/kubernetes-incubator/kube-aws/pull/1670
https://github.com/kubernetes-incubator/kube-aws/pull/1669

Thanks very much for your contribution! 🙏


registry -version states 2.1.0 version while it should be 2.1.1

I've compiled registry from source by running
make clean
make binaries
and I run
bin/registry -version
and it returns 2.1.0+unknown
I would expect 2.1.1+unknown
I've tried chaning 2.1.0 by 2.1.1 in version/version.go but that didn't fixed it.

The version number is set using the git source and the Makefile. Please make sure you are correctly following the build instructions.
When I do the same locally, I get the following:
$ bin/registry -version
bin/registry github.com/docker/distribution v2.1.1-51-g7c5a9ae

The value 2.1.0+unknown is just a default value we rev every minor release (not patch release). When we see this value, it means the linker is not having the correct version number set.
What system are you on (ie uname -a)?
What is the output of go version?
What is the output of make --version of make do you have?
Inside of your git checkout, what is the output of git describe --match 'v[0-9]*' --dirty='.m' --always?
If you run go build -o ./registry-handbuilt -ldflags "-X $(go list ./version).Version v2.1.1-handbuilt-test"   ./cmd/registry, then run ./registry-handbuilt -version, what is the output of the commands?

On 09/08/2015 08:33 PM, Stephen Day wrote:

The version number is set using the git source and the Makefile.
Please make sure you are correctly following the build instructions
https://github.com/docker/distribution/blob/master/docs/building.md.

I did a "git clone" of this project

When I do the same locally, I get the following:
|$ bin/registry -version
bin/registry github.com/docker/distribution v2.1.1-51-g7c5a9ae
|
The value |2.1.0+unknown| is just a default value we rev every minor
release (not patch release). When we see this value, it means the
linker is not having the correct version number set.
What system are you on (ie |uname -a|)?

Linux linux-k9jw.site 3.16.7-21-desktop
openSUSE 13.2

What is the output of |go version|?

go version go1.5 linux/amd64

What is the output of |make --version| of make do you have?

GNU Make 4.0
Built for x86_64-unknown-linux-gnu

Inside of your git checkout, what is the output of |git describe
--match 'v[0-9]*' --dirty='.m' --always|?

v2.1.1-49-gdbbafe9

If you run |go build -o ./registry-handbuilt -ldflags "-X $(go list
./version).Version v2.1.1-handbuilt-test" ./cmd/registry|, then run
|./registry-handbuilt -version|, what is the output of the commands?

./registry-handbuilt github.com/docker/distribution v2.1.0+unknown
If I run "make clean;make binaries" this is the output

/home/jordi/work/docker-distribution/bin/registry

_/home/jordi/work/docker-distribution/cmd/registry
link: warning: option -X
_/home/jordi/work/docker-distribution/version.Version v2.1.1-49-gdbbafe9
may not work in future releases; use -X
_/home/jordi/work/docker-distribution/version.Version=v2.1.1-49-gdbbafe9

/home/jordi/work/docker-distribution/bin/digest

_/home/jordi/work/docker-distribution/cmd/digest
link: warning: option -X
_/home/jordi/work/docker-distribution/version.Version v2.1.1-49-gdbbafe9
may not work in future releases; use -X
_/home/jordi/work/docker-distribution/version.Version=v2.1.1-49-gdbbafe9

/home/jordi/work/docker-distribution/bin/registry-api-descriptor-template

_/home/jordi/work/docker-distribution/cmd/registry-api-descriptor-template
link: warning: option -X
_/home/jordi/work/docker-distribution/version.Version v2.1.1-49-gdbbafe9
may not work in future releases; use -X
_/home/jordi/work/docker-distribution/version.Version=v2.1.1-49-gdbbafe9

binaries

note the "v2.1.1-49-gdbbafe9"
and then I run ./bin/registry -version and I still get v2.1.0+unknown
I've also tried this as in the building instructions:
|go get github.com/docker/distribution/cmd/registry
/home/jordi/go/bin/registry -version
and the outputs is
go/bin/registry github.com/docker/distribution v2.1.0+unknown
ls -l /home/jordi/bo/bin/registry
(...) Sep  9 10:14 (<- which is now)
Then I tried following the instructions on the building.md
|
||go get github.com/tools/godep github.com/golang/lint/golint
cd /home/jordi/go/src/github.com/docker/distribution/
GOPATH=/home/jordi/go/bin/godep path:$GOPATH make
and I get the error
vet: import failed: reading export data: /usr/lib64/go/pkg/linux_amd64/fmt.a: go archive is missing __.PKGDEF
||

—
Reply to this email directly or view it on GitHub
https://github.com/docker/distribution/issues/962#issuecomment-138662999.

Hi! I think the problem is on my side . Wrong configuration of the GO_PATH.

Hi! You can reproduce the issue if you install registry with go get.

@jordimassaguerpla go get does not support correctly setting the version number. We may be able to fix this with go generate somehow.
In general, we only support correctly setting the version number when built with the Makefile with a correctly setup build environment. Looking at the output from above, we can tell the project is not checked out in GOPATH because the package names are prefixed with _/home/jordi/work/docker-distribution/`.


can hystrix-go add config at runtime? hystrix.ConfigureCommand

Yes, i think so. https://github.com/afex/hystrix-go/blob/master/hystrix/settings.go#L87


Contour display problem

If the map doesn't span a large enough area to contain an entire contour, the display is wonky and we get weird shapes with long straight edges instead of nice smooth contours. See the "good" and "bad" attachments.

If the contour fits on the map, then the first and last points in the contour are the same, otherwise they are different. We can test for this easily with the following block of code after tidydta2 has already been calculated.
good <- TRUE # Contour fits on map
for (gname in unique(tidydta2$group)) {
    x1 <-  tidydta2$lat[which(tidydta2$group == gname)]
    y1 <-  tidydta2$long[which(tidydta2$group == gname)]
    if (x1[1] != x1[length(x1)] && y1[1] != y1[length(y1)]) {
       good <- FALSE # Contour does not fit on map
    }
}

I suggest that we still display the results if the display is wonky, but provide the following warning message "Not all contours levels fit on the map. Either increase map size by using a larger buffer value or decrease the probability for the outermost contour"

Ok, i’ve added this to the code and updated our dev branch.  Since tidydta2 is only calculated for when map is being displayed, the weird display is only an issue for mkde plot with a map?
On Nov 3, 2023, at 9:15 AM, Robert Sinkovits @.***> wrote:
If the map doesn't span a large enough area to contain an entire contour, the display is wonky and we get weird shapes with long straight edges instead of nice smooth contours. See the "good" and "bad" attachments.
[Bad contour display]https://urldefense.com/v3/__https://user-images.githubusercontent.com/5232688/280340621-3252d73f-39cb-4e99-895a-49fb4bc2d8e7.png__;!!Mih3wA!CF49wZ9Anx1mrwUzwGyzWlsbLSpfC-OPff2J8q2V8B_04TRf_OttM6PAPbN7N8tNF89ffKxD0Ewe4-ko8wl5UQ$ [Good contour display] https://urldefense.com/v3/__https://user-images.githubusercontent.com/5232688/280340624-9a7f7072-2b5f-4878-8a2a-8052abc285af.png__;!!Mih3wA!CF49wZ9Anx1mrwUzwGyzWlsbLSpfC-OPff2J8q2V8B_04TRf_OttM6PAPbN7N8tNF89ffKxD0Ewe4-nY4npzaA$
If the contour fits on the map, then the first and last points in the contour are the same, otherwise they are different. We can test for this easily with the following block of code after tidydta2 has already been calculated.
good <- TRUE # Contour fits on map
for (gname in unique(tidydta2$group)) {
x1 <-  tidydta2$lat[which(tidydta2$group == gname)]
y1 <-  tidydta2$long[which(tidydta2$group == gname)]
if (x1[1] != x1[length(x1)] && y1[1] != y1[length(y1)]) {
good <- FALSE # Contour does not fit on map
}
}
I suggest that we still display the results if the display is wonky, but provide the following warning message "Not all contours levels fit on the map. Either increase map size by using a larger buffer value or decrease the probability for the outermost contour"
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/sinkovit/Spatial-ecology/issues/72__;!!Mih3wA!CF49wZ9Anx1mrwUzwGyzWlsbLSpfC-OPff2J8q2V8B_04TRf_OttM6PAPbN7N8tNF89ffKxD0Ewe4-lqHcnjPQ$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEM5Y4BT5SNSMIR73VEDO43YCUKDFAVCNFSM6AAAAAA64VPMT6VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3TMNJSG4ZTEMI__;!!Mih3wA!CF49wZ9Anx1mrwUzwGyzWlsbLSpfC-OPff2J8q2V8B_04TRf_OttM6PAPbN7N8tNF89ffKxD0Ewe4-n1CnA-XA$.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


jsx supported, helpful classname added

remove some hardcoded css

welcomeMessage now support jsx

new prop: helpLabel

new prop: errorLabel

new prop: historyAreaClassName

new prop: historyCommandClassName

rewrite prop: promptLabel

remove prop: errorText

trying to fullfill #210
works well within my project, but not compatible with older versions

I'm unfortunately not in a position where I can review this at the moment. However, I've seen this and I'll get to it as soon as I can!

sorry for the bad code

Well, to be fair, it wasn’t really - your idea is excellent in spirit, but the execution was rather poor. I do actually agree with a lot of your points and have been locally working on a customisation rework, eventually planning to incorporate your idea in some form once the rework is complete. So while I’m not going to implement this in its current form, I do think your idea is still has a lot of merit and I’ll keep it in mind. Thanks for your time anyhow!


Skip playground UI tests on windows

Disable playground UI tests on Windows as the flakiness persists. #1223 tracks fixing this or deciding it's OK for this to be permanent.

Looks good!
> cross-env PW_EXPERIMENTAL_TS_ESM=1 playwright test -c e2e

(node:4284) ExperimentalWarning: Custom ESM Loaders is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

Running 6 tests using 1 worker

  -  1 [chromium] › ui.e2e.ts:9:3 › playground UI tests › compiled http sample
  -  2 [chromium] › ui.e2e.ts:17:3 › playground UI tests › shared link works
  -  3 [chromium] › ui.e2e.ts:25:3 › playground UI tests › save code with ctrl/cmd+S
  -  4 [firefox] › ui.e2e.ts:9:3 › playground UI tests › compiled http sample
  -  5 [firefox] › ui.e2e.ts:17:3 › playground UI tests › shared link works
  -  6 [firefox] › ui.e2e.ts:25:3 › playground UI tests › save code with ctrl/cmd+S

  6 skipped


scdiff: investigate result format

Currently, the format produced by scdiff is newline delimited JSON. Investigate the trade-off between being human readable, such as pretty printing, and easily parsable (the current newline delimited JSON).
This is a tracking issue to follow the code's TODO comment.

Being interchangeable with the cron output is nice, and the compare function prints a pretty diff anyway. So the current newline delimited JSON output is fine.


⚠ Warn users against gotchas when using object literal property

This bit me today :calendar: , and I think a :warning: warning or :rotating_light: helpful message in the console ala react would help a bunch. :bow:
:goat: Example
Polymer({
  is: 'goat-eater',
  properties: {
    goats: {
      type: Object,
      value: {
        heads: 1
      }
    }
  },
  attached: function() {
    this.goats.heads++;
    console.log('i have eaten ' + this.goats.heads + ' goat heads');
  }
});

<goat-eater></goat-eater>
<goat-eater></goat-eater>
<goat-eater></goat-eater>

Then in the console I see
> i have eaten 1 goat heads
> i have eaten 2 goat heads
> i have eaten 3 goat heads

wat
This was pretty darn confusing, until I was like oh yes prototypically inheritance :lollipop:
Polymer({
  is: 'goat-eater',
  properties: {
    goats: {
      type: Object,
-      value: {
+      value: function() {
+       return {
          heads: 1
        }
+     }
+    }
  }

TLDR;
I am willing to bet quite a few people have gotten caught up on using object literal props, it also seems like something that could be console.warned against quite easily, given the fact that we have type to look at.
Thoughts? Terrible Idea? Let me know :microphone:
Thanks for your :watch: Time :sparkles:

Afaik We've documented this but agree a warning could be valuable. We've discussed improving warnings/tips around gotchas in the console some time ago but this is definitely an area that could use some more work.

:book: https://www.polymer-project.org/1.0/docs/devguide/properties.html#configure-values
This raises a great question, do we want people to ever "use" this feature? Are there legitimate use cases?

@garlicnation This is probably a good candidate for the linter tool.

+1 for some form of warning/linting. It's very easy to get caught out by this, especially in a componentised world where this is not the obvious behaviour.

This issue was moved to Polymer/polymer-linter#172


CSS Split by Block - Remove block CSS from testimonial

Example:
https://lifesciences.danaher.com/us/en/blog/how-organoids-can-redefine-pre-clinical-research.html


feat(pixels): add my new pixel (3, 32)

Checklist

[ ] I ran npm test locally and it passed without errors.

[ ] I only edited the _data/pixels.json file.

[ ] I entered the username in the pixels.json that I'm also using to create this pull request.
[ ] I acknowledge that all my contributions will be made under the project's license.

I think I only added a pixel and may be changed an improper indentation. Can you please confirm @dkundel . Thanks. LMK if you think any more changes to be made or if anything I should change.


Too long paths in 3.3 beta

Downloaded today  OpenRefine 3.3 Beta into  Windows 10 system.  By unzipping I got five times a warning "error Dx80010135 Path is too long". First one was "ExpessionNominaValueGrouper$indexedNominalFacetChoice.class". Downloanding failed.

Interesting, thanks for reporting that. Did the extraction of zip fail in the end? Which unzipper are you using?
I'd be very interested to improve our packaging, perhaps #2107 could solve this.

Extraction failed. I used standard Unzip feature of Resource Manager in Windows 10.  I have also 7-zip seldom used. Tested it now and had with it no difficulties to unzip 3.3 beta which also launched normally. Maybe a bug in Windows 10 Resource Manager?

We do get some warnings about path lengths when generating the zip… It's not clear to me what is the best way to solve this. Are there better supported archive formats on Windows that we could use instead? Could it be our compressor's fault (perhaps there are better zip compressors which deal with this problem in a different way)?

I think this is an isolated event for Peter.
I have no such problems with right-clicking the
"openrefine-win-3.3-beta.zip" file and choosing "Extract All..." on Windows
10 Pro Build 18362
My starting folder location is "E:\Downloads"
Thad
https://www.linkedin.com/in/thadguidry/
On Sat, Nov 16, 2019 at 9:35 AM Antonin Delpeuch<EMAIL_ADDRESS>wrote:

We do get some warnings about path lengths when generating the zip… It's
not clear to me what is the best way to solve this. Are there better
supported archive formats on Windows that we could use instead? Could it be
our compressor's fault (perhaps there are better zip compressors which deal
with this problem in a different way)?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/issues/2217?email_source=notifications&email_token=AAHQ2RR7Y4I2S2VLY6FK52LQUAHL7A5CNFSM4JOFLDO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEHUBGA#issuecomment-554647704,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHQ2RS56TNXULJ2EIMFZVLQUAHL7ANCNFSM4JOFLDOQ
.

Right-clicking worked also for me. So obvious bug only in Unzip feature of Resource Manager in Windows 10 remains. Be it M$'s problem!
Thanks for new version. I use OpenRefine actively for cleaning genealogical net sources.

@PeterJPower I thought I would update you with information I found from my company Group IT that might help with the general issue that you were experiencing with Resource Manager itself (which makes longer paths more likely).
The workaround is to enable LongPathsEnabled in the Windows Registry.  This will allow Windows to recognize up to 32,000+ chars in a Path without problems.
Here's how to do that from Microsoft: https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later


Add testing new frontend with assertions enabled

We won't have checked-mode anymore with the new frontend but we will need to support a modes where assertions are enabled/disabled.
Currently e.g. pkg/vm/bin/gen_kernel.dart - which is what the buildbot uses - does not have such a flag.
/cc @mraleph @kmillikin

@kmillikin @mraleph @whesse
We need proper testing of Dart 2.0 with asserts enabled (but not checked mode). This requires:

having tools/test.py have a flag, similar to the old --checked
have our individual tools accept such a flag
have buildbot support for those

The testing issue just came up again due to the assert(await foo()) isssue which @kmillikin is implementing and which we need tests for.
Should we bump the priority of this?

Yes.  The --vm-flags option should work, if you need an immediate fix, but it would'nt be visible in the status files.  What would you like the variable to look like in the status files?
$asserts
$asserts_enabled
Would it just be for the the VM?
$vm_asserts
?

It's not just for the VM.  dart2js has --enable-asserts as a compile-time option.  As far as I know, DDC always compiles them but there are TODOs in the code that indicate that they might support an option to disable them in the future.
Ideally we would standardize the name of the flag for all our tools and then the status file variable would be the name of the flag so you never have to guess what it is.  I suggest $enable_asserts unless we can support a hyphen in the name in which case it should be $enable-asserts.

OK, I propose adding --enable-asserts to test.py and the status environment (as $enable_asserts), and passing --enable-asserts to the VM and dart2js, in those cases, unless I am told that a different flag should be passed.

SGTM.  We should also have the buildbots run tests with that flag for at least one architecture (VM) or runtime (dart2js).
You might also consider changing --checked so it doesn't imply --enable-asserts on the VM since it's now a separate option.  Or not, because the status file updates needed to make that work for all combinations might outweigh the benefits.

There is already a --enable-asserts option in test.py and a corresponding $enable_asserts variable.

Then maybe it's just a matter of removing the --checked flag from VM / test.py and changing the status files to use $enable_asserts.

@mkustermann Do you know if there is more work left here?

@whesse Do you now the current state of this? Can we close this issue?

The CFE unit tests are running with asserts but the SDK tests without.
I vaguely recall that the CFE was doing some rather heavy assertions that caused this to be very slow when turned on.


Ability for police to escort players

Having the ability to escort non compliant players.

I've done this, looks great on their screen but on the draggers it desyncs
On Jun 9, 2017 10:11 AM, "CruelAlpha"<EMAIL_ADDRESS>wrote:

Yeah, something like /drag would be cool
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ImagicTheCat/vRP/issues/182#issuecomment-307399779,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab4Rulohdt5XyIg-ROs5mG46VgG4_yRvks5sCVKrgaJpZM4Nzm89
.

@CruelAlpha vRP will never be chat command based.

I added a drag option in menu. If you want I'll send u it, but like I said
for dragger it desyncs but the one being dragged looks good
On Jun 9, 2017 10:24 AM, "Imagic"<EMAIL_ADDRESS>wrote:

@CruelAlpha https://github.com/cruelalpha vRP will never be chat
command based.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ImagicTheCat/vRP/issues/182#issuecomment-307402910,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab4RuiVcfzWc37mfsXpMXpPCp_srDJ_4ks5sCVWBgaJpZM4Nzm89
.

can you share your changes id like to see it in action and see if the desync is replicable then magic can decide if he wants to use it or do it on his own , thanks :D

Any update on this?
Love to get an escort script.

An experimental drag feature is available in vrpex.


Clarify DOM inconsistency for falsy values

Sentence was reading weird previously, fixed up the wording.

Signed the CLA.


Spyder 5.0 issues

Issue Report Checklist

[ ] Searched the issues page for similar reports
[ ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[ ] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[ ] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[ ] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
Below two features we liked most is no more working on latest Spyder. I am using spyder 5.0

Go to definition (ctrl G) is not working. Tried all of the suggestions in the discussion forum.
In the outline pane, not displaying the functions, class etc. of a module. Expand/collapse is not working

What steps reproduce the problem?

What is the expected output? What do you see instead?
Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Versions

Spyder version:
Python version:
Qt version:
PyQt version:
Operating System name/version:

Dependencies

PASTE DEPENDENCIES HERE

Hey @leyojoseph, thanks for reporting. This is a duplicate of issue #15139 and we'll try to fix in our next release.
For now, please uninstall Kite if you have it installed. That should solve your problem.

The problem of "go to definition is not working" can be handled by modifying the configuration (Tools -> Preference -> General -> Providers. Uncheck the "Enable kite provider" .
In my case, it worked.

That's true too. We'll fix it in our next version (5.0.2), to be released soon.

I performed the rollback that 5.0 to 4.1.3 and downgrade the spyder-kernel 1.9.4 to 1.9.3.
It worked! the 'go to definition' revived.


datatable jquery is not responsive

I was trying datatable jquery, I noticed it is not fully responsive. When I check the code, according to datatable example some additional js and css are missing.

Are you using a div with .table-responsive class before your table attribute ?
I also use these attributes when declaring DataTable to make it 100% responsive.

Are you using a div with .table-responsive class before your table attribute ?
I also use these attributes when declaring DataTable to make it 100% responsive.

Are you using a div with .table-responsive class before your table attribute ?
I also use these attributes when declaring DataTable to make it 100% responsive.

I haven’t changed anything, I just open the page, and checked the responsiveness


crontab not working

Calling loadtweets.php in the browser works.
loadlog.txt shows attempt:
Attempted load Mon, 06 Apr 2015 16:09:47 +0200
But a crontab like the following doesn't work:
50 1 * * * php /server path//tweetnest/maintenance/loadtweets.php
No entry in loadlog.txt
Any idea? Is my crontab syntax wrong?

Does the path to loadtweets.php contain a space?
50 1 * * * php /server path//tweetnest/maintenance/loadtweets.php
Your crontab syntax is correct, but I think what it means is "run the command php with 2 arguments, /server and path//tweetnest/maintenance/loadtweets.php at 01:50 every day".
Adding a backslash to the path like this might work:
50 1 * * * php /server\ path//tweetnest/maintenance/loadtweets.php

Sorry, of course there is no space in the path.
Imagine something like
0 1 * * * php /web/html/xyz/blabla//tweetnest/maintenance/loadtweets.php

Ah ok, that syntax looks right to me - if you try running that command at the prompt do you get any useful output?
php /web/html/xyz/blabla//tweetnest/maintenance/loadtweets.php

Thank you.
I figured out, where the cronjob writes its output - and the error log.
The Problem was:
loadtweets.php needs PHP with curl support, and curl was not installed where cronjobs run.


Support interpreting multiple values as null

It's great that we can use the "nullValue" option to specify a specific null value. I would like the ability to identify any of several values as being null. We read data from different sources where the null value is not necessarily consistent. Sometimes it is "?", sometimes it is "N/A", sometimes "null", or any one of many other possibilities.
I propose that we add a "nullValues" option that allows a list of values that should be interpreted as nulls. Probably the current "nullValue" option cannot be replaced as it would still be needed for backwards compatibility. An example usage would be
.option("nullValue", List("?", "N/A", "NA", "NULL", "null", "UNKNOWN", "Unknown", "Missing Value", "NaN"))

Thanks for the feedback.  One work around would be reading different data sources separately and then unioning them together into a single DF/table.

Sometimes nulls could be different things even within the same dataset.

Hello falaki,
Do you have any updates regarding support of multiple values as nulls?
Assuming I have one dataset with null and NULL values in it. Is it a possibility to say something like this in java: sparkSession.read().option("nullValue", "null, NULL")
Thanks in advance,
Olga


Login failed for user 'sa'

Not able to connect to docker sql server express container thru mssql-cli on mac system
using this command to login mssql-cli -S localhost -U sa -d master -P password
but everytime it is throwing the same error
Login failed for user 'sa'
any input will be highly appreciated

Sounds like the password is incorrect 🙂 maybe try surrounding the password in quotes?

Closing this but please reach out if you're still running into problems.


Where is the Supplementary of paper

I want to know the details of GPT-based evaluation, but cannot find the Supplementary in paper.

Hello, I would also like to review the supplementary materials for the paper. Have you found them?


Set numeric user to comply runAsNonRoot k8s policy

When in k8s, container has runAsNonRoot policy and image has non-numeric user (exporter), then the deployment will fail as it cannot verify user is non-root.
Closes #20
Signed-off-by: Aleksandr Vinokurov<EMAIL_ADDRESS>

Hi,
Thank you for the pull request.
It seems that this is a fix specific to your environment, right?
I don't use k8s, but did you try to set runAsUser without this change to the Dockerfile?
I have found this answer on Stackoverflow that suggests this config:
securityContext:
    runAsUser: 999

Hi,
That's not specific to my environment, but to Kubernetes in general. I do use that workaround for now. But this PR will just make it more robust for everybody who's using this docker image in Kubernetes.


Test-Path fails for empty strings from the split PATH variable

When checking for the NuGet.exe, splitting the PATH variable can pass along empty strings to the Test-Path call; however, Test-Path does not accept empty strings. Easiest to just add a check to filter down to only non-empty strings.

This has been re-opened in new repository over here: https://github.com/cake-build/resources/pull/5
So closing this issue.


Feature/94 log user extraction

Description
Track user_id with every extraction event. Fixes [#94]. This PR only updates the backend. GUI doesn't show any of this new information.
To review start with an existing db that has extraction events (see mongodb extractions collection). You can also submit a file to an extractor first from the develop branch and then switch to this branch. Make sure everything still works.
Submit a new extraction both from the UI as well as an api client. You should see a new user_id field in the mondodb collection with appropriate user_id as an ObjectId.
Review Time Estimate

[x] Immediately
[ ] Within one week
[ ] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the CHANGELOG.md.
[ ] I have signed the CLA
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

i could potentially use some of my code from here: https://github.com/clowder-framework/clowder/pull/124 into a migration for the database.


chore(deps): update dependency org.easymock:easymock to 4.0.2

This PR contains the following updates:

Package
Change

org.easymock:easymock
3.4 -> 4.0.2

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

https://github.com/easymock/easymock/releases/tag/easymock-4.0


HTTP Cookies not being send on some calls.

Have you read the FAQ and checked for duplicate open issues?
YES
What version of Shaka Player are you using?
v2.5.5
Can you reproduce the issue with our latest release version?
YES
Can you reproduce the issue with the latest code from master?
YES
Are you using the demo app or your own custom app?
Custom app, so I can add a Request/Response filter hook
If custom app, can you reproduce the issue using our demo app?
YES
What browser and OS are you using?
Crome 78.0.3904.97, MacOS Mojave
What did you do?

I have a player following this flow:

Adding a stream url into the player. This URL returns 302 redirect to the manifest location.
Manifest location being loaded
url: http://s1-h4-wowza-c-sign-cookie.tbocdn.ab.sk/vodo/.../index.m3u8

Response contains following headers:

Accept-Ranges: bytes
Access-Control-Allow-Credentials: true
Access-Control-Allow-Headers: Range
Access-Control-Allow-Methods: GET, OPTIONS
Access-Control-Allow-Origin: *
Access-Control-Expose-Headers: Date, Server, Content-Type, Content-Length
Access-Control-Expose-Headers: Location
Cache-Control: max-age=5
Connection: keep-alive
Content-Length: 323
Content-Type: application/vnd.apple.mpegurl
Date: Mon, 18 Nov 2019 14:40:55 GMT
Server: nginx/1.15.10
Set-Cookie: Path=/
Set-Cookie: Domain=s1-h4-wowza-c-sign-cookie.tbocdn.ab.sk
Set-Cookie: value=123
X-Proxy-Cache: MISS
X-Proxy-Key: upstreams_wowza-c-sign-cookie.tbocdn.ab.sk/vodo/.../index.m3u8?

Returned chunklist being loaded, with request.allowCrossSiteCredentials = true
Example chunklist url: http://s1-h4-wowza-c-sign-cookie.tbocdn.ab.sk/vodo/.../chunklist_b5000000.m3u8

Request Headers:

Accept: /
Accept-Encoding: gzip, deflate
Accept-Language: cs-CZ,cs;q=0.9,en;q=0.8
Cache-Control: no-cache
Connection: keep-alive
Host: s1-h4-wowza-c-sign-cookie.tbocdn.ab.sk
Origin: http://...com
Pragma: no-cache
Referer: http://...com/
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.97 Safari/537.36

Individual chunk being loaded, with request.allowCrossSiteCredentials = true
Example chunk url: http://s1-h4-wowza-c-sign-cookie.tbocdn.ab.sk/vodo/.../media_b5000000_0.ts

Response headers:

Accept: /
Accept-Encoding: gzip, deflate
Accept-Language: cs-CZ,cs;q=0.9,en;q=0.8
Cache-Control: no-cache
Connection: keep-alive
Cookie: Path=/; Domain=s1-h4-wowza-c-sign-cookie.tbocdn.ab.sk; value=123
Host: s1-h4-wowza-c-sign-cookie.tbocdn.ab.sk
Origin: http://...com
Pragma: no-cache
Referer: http://...com/
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.97 Safari/537.36

What did you expect to happen?
I need to have a Cookie header on chunklist request as well as on chunks.
What actually happened?
Chunklist request doesn't contain a Cookie header, which is causing the server verification not working. (Server verification temporarily switched of to be able get chunks and play the stream)
Can you please take a look on that? I can of course provide full manifests, test domain, HARs, etc.. To help you take a look into it. Thanks a lot in advance.

Please read the "Cookie Authentication" section of our License Server Authentication Tutorial.  It should apply equally well to non-license requests.  In short, you need a request filter to flag that cookies should be sent cross-origin.
Does this help?

Hey, well that's exactly what I did. But even though I've added the request.allowCrossSiteCredentials = true; flag, it is works only like in 10% of all cases. Weird thing is that for individual chunks Cookie header is always send, but Chunklist doesn't contain it in most cases. Don't know if this is directly shaka related.. :/

But if using for example Native MPEG-Dash + HLS Playback chrome extension (https://chrome.google.com/webstore/detail/native-mpeg-dash- -hls-pl/cjfbmleiaobegagekpmlhmaadepdeedn) all HTTP Cookies are added just fine and the verification itself works as expected.

JavaScript applications don't get to directly send individual cookies.  All we can do is request that cross-origin cookies do or don't get sent.  Beyond that, the decision is made by the browser using the CORS rules, which are influenced by the server's headers.
CORS may not apply to a Chrome extension, though.  So that might explain the difference.
You can read more about CORS here: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS
I would advise you to read that article and compare with the response headers.  In particular, if any given OPTIONS request doesn't get back the response header Access-Control-Allow-Credentials: true, then cookies will not be sent by the browser in the corresponding GET request.


sfdx force:source:deploy failed trying to deploy a Flow with error message "Required field is missing: name"

Summary
I'm trying to deploy a Flow to a Sandbox using  "sfdx force:source:deploy" but I'm getting this error message saying that there is a missing field within the flow metadata XML
Here is a screenshot of the error

This Is a snapshot from the Flow Metadata XML file: I highlighted Line 168 which caused the issue

Steps To Reproduce:
The flow that is causing the issue is a record triggered flow and I'm using the Auto Layout.
I used the Include a Run Asynchronously feature which create a new Asynchronous path  that caused the error displayed in the previous screenshot
Here are some screenshots of the flow :

Expected result
The only workaround that worked for me is to delete the Run Asynchronously path and deploy then put it back after deployment but that's not very helpful if as I have more flows of the same type to deploy.
This looks like a DX bug to me, please help

The issue template asks some important questions about your version/plugins (that you run sfdx version --verbose).  Please do that so we can see what version of the CLI and plugin-source you're on.
Can you also provide your sfdx-project.json's sourceApiVersion ?  This could be a metadata API error, but it could be a mismatch between different API versions of your Flow.

Thank you @mshanemc here are the details you requested :
sfdx version --verbose ==>
CLI Version :
sfdx-cli/7.119.2
Architecture:
darwin-x64
Node Version :
node-v14.17.6
Plugin Version:
@oclif/plugin-autocomplete 0.3.0 (core)
@oclif/plugin-commands 1.3.0 (core)
@oclif/plugin-help 3.2.3 (core)
@oclif/plugin-not-found 1.2.4 (core)
@oclif/plugin-plugins 1.10.1 (core)
@oclif/plugin-update 1.5.0 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-plugin-lwc-test 0.1.7 (core)
alias 1.1.10 (core)
apex 0.2.8 (core)
auth 1.7.1 (core)
config 1.2.35 (core)
custom-metadata 1.0.12 (core)
data 0.6.1 (core)
generator 1.2.0 (core)
limits 1.2.1 (core)
org 1.7.0 (core)
salesforce-alm 52.3.5 (core)
schema 1.0.8 (core)
sfdx-cli 7.119.2 (core)
source 1.1.0 (core)
telemetry 1.2.4 (core)
templates 52.1.0 (core)
trust 1.0.8 (core)
user 1.4.0 (core)
OS and Version:
Darwin 20.6.0
"sourceApiVersion": "52.0",

Interesting.  Looking at the Flow mdapi docs https://developer.salesforce.com/docs/atlas.en-us.api_meta.meta/api_meta/meta_visual_workflow.htm#FlowStart
I don't see your scheduledPaths at all on any apiVersion (it's likely the docs have't been updated).
I'd suggest changing the sourceApiVersion to 53.  If you still have an org where this flow exists, try retrieving (so that it's v53) just in case the metadata API had a bug in v52.  If not, it'd be worth creating one and doing a retrieve of this flow.
There's a related question here from StackExchange with a comment about possibly needing pathType tag, too.
https://salesforce.stackexchange.com/questions/361345/how-to-resolve-required-field-is-missing-name-when-deploying-flow

Thank you very much, @mshanemc. I tried redeploying with the sourceApiVersion V53, but the same error occurred.
Note : When using sfdx force:mdapi:deploy, the flow is correctly deployed.

More recent versions of plugin-source will output, during the deploy, what version of the mdapi they're using.  We added that for scenarios like this where you may have a settings somewhere that's causing it to not use the version you'd expect it to.
Your CLI is a few months old so you might have better luck with a new one.  Also run your deploy command with --dev-debug appended to the end--that'll give a LOT more detail about what version it's using.

Note : When using sfdx force:mdapi:deploy, the flow is correctly deployed.
That sentence makes me 99% sure this is a metadata API version problem, but I'm not sure why it's not using the correct one.

You can also use the same --dev-debug on the mdapi:deploy command to see what version that's using, in case (for whatever reason) it only succeeds on certain API versions.

There is some problem with cli deploy/retrieve when we indicate concrete --apiversion from command line.
Details are described here: How to resolve "Required field is missing: name" when deploying Flow?
@mshanemc below you can find the crucial part of debug logs you asked for.
It's the same for both use cases:

"Required field is missing: name" - when pathType is missing in Flow metadata in  tag.
"Property 'pathType' not valid in version 51.0" -  when pathType has been added properly.

configuration:
sfdx-project.json file with "sourceApiVersion": "51.0"
command:
sfdx force:source:deploy -p force-app\flows\ --apiversion 53.0
--dev-debug results:
ERROR running force:source:deploy:  Deploy failed.
*** Internal Diagnostic ***

DeployFailed: Deploy failed.
    at DeployResultFormatter.display (\npm\node_modules\sfdx-cli\node_modules\@salesforce\plugin-source\src\formatters\deployResultFormatter.ts:81:13)
    at Deploy.formatResult (\npm\node_modules\sfdx-cli\node_modules\@salesforce\plugin-source\src\commands\force\source\deploy.ts:212:17)
    at Deploy.run (\npm\node_modules\sfdx-cli\node_modules\@salesforce\plugin-source\src\commands\force\source\deploy.ts:117:17)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async Deploy._run (\npm\node_modules\sfdx-cli\node_modules\@salesforce\plugin-source\node_modules\@salesforce\command\lib\sfdxCommand.js:81:40)
    at async Config.runCommand (\npm\node_modules\sfdx-cli\node_modules\@oclif\config\lib\config.js:173:24)
    at async SfdxMain.run (\npm\node_modules\sfdx-cli\node_modules\@oclif\command\lib\main.js:27:9)
    at async SfdxMain._run (\npm\node_modules\sfdx-cli\node_modules\@oclif\command\lib\command.js:43:20)
    at async Object.run (\npm\node_modules\sfdx-cli\dist\cli.js:162:47)
******

apiversion vs. sourceapiversion:
setting sourceApiVersion: 51.0  tells the org that the source is in a format that matches API version 51.0.  The CLI generates a package.xml with a version field value of 51.0.  Setting --apiversion=53.0 tells the CLI to communicate with the org using API version 53.0 SOAP/REST.  The org uses the version from the manifest (sourceapiversion) over the apiversion set on the command.  This is as designed from the beginning of SFDX.

When I tried from Branch to Prod deployment, I got the same error but when I tried to deploy from Preprod to prod, it worked
Not sure but something wrong with DX

@shetzel --apiversion=53.0 from the command overrides sourceApiVersion: 51.0 from the sfdx-project.json. You said opposite

@kmojczi - it shouldn't.  See https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_setup_apiversion.htm
If sourceApiVersion is set in the project file it will use that over an apiversion set by the command when talking about the version field used in the package.xml.


Topic Controler not created in 0.4.0

Hi,
I had a working config to create a cluster + topics using 0.2.0, and trying to move to 0.4.0-rc1 the Topic controler is not started anymore.
Cluster configmap :
apiVersion: v1
data:
  kafka-config: |-
    {
      "num.partitions": 1,
      "num.recovery.threads.per.data.dir": 1,
      "default.replication.factor": 1,
      "offsets.topic.replication.factor": 1,
      "transaction.state.log.replication.factor": 1,
      "transaction.state.log.min.isr": 1
    }
  kafka-healthcheck-delay: "15"
  kafka-healthcheck-timeout: "5"
  kafka-image: strimzi/kafka:0.4.0-rc1
  kafka-metrics-config: |-
    {
      "lowercaseOutputName": true,
      "rules": [
          {
            "pattern": "kafka.server<type=(.+), name=(.+)PerSec\\w*><>Count",
            "name": "kafka_server_$1_$2_total"
          },
          {
            "pattern": "kafka.server<type=(.+), name=(.+)PerSec\\w*, topic=(.+)><>Count",
            "name": "kafka_server_$1_$2_total",
            "labels":
            {
              "topic": "$3"
            }
          }
      ]
    }
  kafka-nodes: "1"
  kafka-storage: '{ "type": "ephemeral" }'
  topic-operator-config: '{ }'
  zookeeper-healthcheck-delay: "15"
  zookeeper-healthcheck-timeout: "5"
  zookeeper-image: strimzi/zookeeper:0.4.0-rc1
  zookeeper-metrics-config: |-
    {
      "lowercaseOutputName": true
    }
  zookeeper-nodes: "1"
  zookeeper-storage: '{ "type": "ephemeral" }'
kind: ConfigMap
metadata:
  labels:
    strimzi.io/kind: cluster
    strimzi.io/type: kafka
  name: kafka-cluster

and the topic Configmap :
apiVersion: v1
data:
  config: |-
    {
      "cleanup.policy": "compact"
    }
  name: alertevent
  partitions: "1"
  replicas: "1"
kind: ConfigMap
metadata:
  labels:
    strimzi.io/cluster: kafka-cluster
    strimzi.io/kind: topic
  name: alertevent

Am I missing something ?

How did you deployed the Cluster Operator? Using the YAML files from examples?

Damn it, it was due to the ServiceAccount name change. No pod was created for Topic-Controler, but the Deployment was there.
I'm sorry. It's working as expected !

I tried the same config maps as you copy pasted into the issues with Cluster Operator deployed with the 0.4:0-rc1 examples. It works completely fine - it deployed the Topic Operator and when I created the topic config map it created the topic. I'm running it on OpenShift Origin 3.9 (started using oc cluster up).
So I guess the interesting point is ...

what kind of OpenShift / Kubernetes do you use
how you deplyoed CO

Oh, you were faster and found the issue :-).
I'm sorry for the breaking changes. Strimzi is still in quite early phase and I guess there will be few more over the next releases. But we will try to document them better. I'm already writing better release notes for the final 0.4.0 release.

any plan to move to real K8s Custom Ressouces use ?

Yeah, we plan that as well. There are some pros and cons ... The main advantage of Config Maps is that they can be used also in environments where people do not have cluster admin rights etc. To deploy Strimzi with CRDs, one would need to be cluster admin (or something similar). That is why we haven't jumped on that from the beginning.


[rlgl] Geometry Shader support

Hey all,
i've been experimenting with geometry shaders and adding support for them to raylib.
How
To do this i changed the following functions in rlgl.h and ralib.h
RLAPI Shader LoadShader(const char *vsFileName, const char *fsFileName, const char *gsFileName);
RLAPI Shader LoadShaderCode(const char* vsCode, const char* fsCode, const char* gsCode);
static unsigned int LoadShaderProgram(unsigned int vShaderId, unsigned int fShaderId, unsigned int gShaderId);

and added unsigned int defaultGShaderId; to RLGL.State
Since a pass-through geometry shader still imposes a considerable overhead i opted to not implement one in the default shader.
Instead defaultGShaderId  is never set to anything else than 0 and is used to check wether a geometry shader is in use at all.
If gsFileName (or gsCode) is NULL, we only attach the vertex and fragment shader to the shader program (or just use the default one).
Considerations

Breaking Change: function calls
It seems C does not really support function overloads, so i had to replace them.
Maybe use something like LoadShaderEx(vs,fs,gs) and keep LoadShader(vs,gs)?
OpenGl support:
Geometry Shader are core since version 3.2
Instancing and Output streams are core since 4.0
This would make them available in raylib, but only with GRAPHICS_API_OPENGL_33
Source: https://www.khronos.org/opengl/wiki/Geometry_Shader
Performance:
Turns out geometry shader have notorious bad performance and their usefullness is highly dependent on the situation (and hardware).
Sources:
Often referenced post, seems still uptodate: http://www.joshbarczak.com/blog/?p=667
Factorio dev article, with some testing: https://factorio.com/blog/post/fff-251

Bottom line
I had fun experimenting on this and it works, but i have chosen not to use them in my project.
If you are interested i can send a PR.
If for nothing else this issue serves as info for others.

@Crydsch I'm afraid I'm not adding this feature to raylib, it seems to have very specific use cases...
In any case, thank you very much for the detailed documentation, I can be useful for other users looking to implement it.


"Class 'App\Hashids' not found"

What am I doing wrong? (Laravel 5.6)
In config/app.php (aliases)
     //....
    'URL' => Illuminate\Support\Facades\URL::class,
    'Validator' => Illuminate\Support\Facades\Validator::class,
    'View' => Illuminate\Support\Facades\View::class,
    'Image' => Intervention\Image\Facades\Image::class,
    'Socialite' => Laravel\Socialite\Facades\Socialite::class,
    'Location' => Stevebauman\Location\Facades\Location::class,

    //https://github.com/vinkla/laravel-hashids
    'Hashids' => Vinkla\Hashids\Facades\Hashids::class

In my model I'm trying to call
public function getIdAttribute($id){
    return Hashids::encode($id);
}

p.S. If I add the facade in model everything works fine. I tried cache:clear as well

Try adding this in the top of your model file:
use Vinkla\Hashids\Facades\Hashids;

It should do the trick.

I wrote

If I add the facade in model everything works fine

But for future readers, just use it like: \Hashids::encode($id); then it works


Weird sorting in BarChart

(Screenshots are deliberately low on detail due to confidentiality reasons. As always, I can show things on a call if desired.)
I have a query that is sorted the way I want to. In DataTable, this works fine — it is sorted by the second-to-last column:
<DataTable
    data={data.my_query}
    rows={1000}
/>

However, with BarChart, the sorting is off:
<BarChart
    data={data.my_query}
    x=name
    y=y
/>

I don’t understand what it’s sorting on. It’s not on the X value, and not on the Y value.
Setting sort={false} kind of works, but the sort is in the wrong direction:
<BarChart
    data={data.my_query}
    x=name
    y=y
    sort={false}
/>

The same goes for sort={true}.

@yhoiseth by default, if the x-axis is categorical, the bar chart should sort the y column descending. I'm not sure what it's doing for the sort in your first chart. Do you have time today for a quick call to debug?
At the moment, the bar chart treats the bottom of the chart as the highest value - we'll need to fix that. If you're curious, the reason it does that is because of the pixel position of each element in the chart (further down the page = higher y-coordinate). We'll change the sorting so it matches what you would expect based on your query!
As a workaround until that's fixed, using ASC instead of DESC in your query will get you the right sort order in your bar chart.

Thanks. Don’t have more time today (am in Europe), will hopefully get to check it out tomorrow.

Sounds great! I'll play around with the sorting and see what's going on

I’m going to look into this now. Available for debugging for approximately the next couple of hours.

After debugging, confirmed that sort issue in bar and column charts is caused by duplicate labels on the x-axis. Chart component loops through each distinct item on the x-axis, so multiple entries will be overlapped (multiple bars drawn on top of each other). The first entry in the table for each x-axis label determines the order of the bars, then the other bars are drawn overtop.
Ideally, the chart would print the data exactly as it is inputted, but given that this shouldn't be a common scenario, won't put this as a priority to fix.


Move API key to environment variable

Move the API key of this project to environment variable.

@codemaniac-sahil I would like to take it up. Can you assign this to me?

Can u assign me this one

Yes, @imabhinavagarwal

I have given pull request with the required changes

It is unable to fetch the data from API

@Gathin23 it will not work. @codemaniac-sahil I was about to comment about the same what @Gathin23  has done.
What he has done is correct but since this is vanilla js, require won't work. And in turn, .env won't work either.
There can be two approaches to this, either write your own impl of require() or store all env files in another js file and import them as constants in script file which is useless since that will also require pushing your keys to github repo which goes against the whole principle of making env vars.
If you want that solution, I can make the changes right away. or else you can look to move the project to use node js

@imabhinavagarwal thank you for your suggestion. Now I am closing this issue.


Fix 'typen' typo

I believe that vtypen in that particular note refers to the vtype<n> CSRs, not vtypeen.  Please see if 663784cdfe22eaa6127afb3297c2ca1e413d4139 sufficiently clarifies that the vtype<n> CSRs are not present in  the base extension.

Now it makes sense, thank you.
Closing.


Developers page broken

See title, shows 404 error when trying to visit page

Removed trailing slash in the developers page link, in the menu.yml file. Now working fine


Etcd Restore Documentation Inaccurate

What kind of request is this (question/bug/enhancement/feature request):
Documentation enhancement
Steps to reproduce (least amount of steps as possible):
The documentation here: https://rancher.com/docs/rancher/v2.x/en/backups/restorations/ha-restoration/ still talks about a requirement for the PKI Bundle. Whist this still may be the case for versions of Rancher before the current stable release, according to Rancher Support the PKI Bundle is no longer created as part of the snapshot and therefore is not available (or required) to restore a Rancher Management (HA) cluster
RKE docs also talk about the PKI bundle as a requirement for recovery : https://rancher.com/docs/rke/latest/en/etcd-snapshots/
If there are different approaches for various product versions then I think that needs to be clear, and certainly needs to ensure that the latest stable version is always up-to-date ?
Result:
Confusion iro what files should be available for our automated backup pipeline.
Confusion iro the expected files and process to recover either a Rancher HA or Application cluster.
Other details that may be helpful:
https://support.rancher.com/hc/en-us/requests/4017
Environment information

v2.2.2 (stable)
HA

Cluster information

Cluster type : Custom
Machine type : Cloud (AWS)
Kubernetes version: 1.13.5

I encountered some issues this weekend which are a combination of docs that haven't been updated and missing information after the 0.2.0 changes to RKE.
@moelsayed I'm updating this issue because it seems related to what we talked about yesterday for the HA backup/restore.

One-off HA backup references SNAPSHOT.db and upgrade.db as the filename when doing a non-S3 backup but not when doing an S3 backup, which implies that .db is somehow important to the non-S3 version. Since it can be any name, we can remove the .db portion.
The instructions for restore say only to copy cluster.yml to cluster-restore.yml and then everything will work. It fails with problems around not finding certificates (rke 0.2.4). The solution was to also copy cluster.rkestate to cluster-restore.rkestate. This allowed RKE to use the cert data from the old nodes to rebuild the new nodes.
After building the new restore node as a single-node cluster, the output of kubectl get nodes did not show the old nodes, so the step to delete them may no longer be necessary.
The dependency on cluster.yml and cluster.rkestate MUST be clearly called out in the docs. People may be setting up an automatic backup job and not realize that without these two files, they cannot perform a restore. These files may exist on someone's laptop, and they need to be moved to a safe location.
in the "Restoring from a Snapshot in S3" section the command uses cluster.yml instead of cluster-restore.yml
We should include steps to add the new nodes to and remove the old nodes from the load balancer and also deleting the old nodes when the restore is complete.

My video on backup/restore has a complete restore walkthrough using all of the correct steps.


Issue with SuperSafe and shouldBe empty matchers

Hello, I'm upgrading scalatest to 3.1.0 and I've just experienced the following issue with SuperSafe (sbtplugin 1.1.8) and the shouldBe empty matchers:

[Artima SuperSafe] Values of type List[Int] and org.scalatest.matchers.dsl.EmptyWord may not be compared for equality with ScalaTest's shouldBe matcher syntax.

and another one

[Artima SuperSafe] Values of type Option[Int] and org.scalatest.matchers.dsl.DefinedWord may not be compared for equality with ScalaTest's shouldBe matcher syntax.

Example code resulting in this error:
import org.scalatest.flatspec.AnyFlatSpec
import org.scalatest.matchers.should.Matchers

class Test extends AnyFlatSpec with Matchers {
  it should "just work" in {
    List.empty shouldBe empty
    Option(1) shouldBe defined
  }
}

Am I missing something obvious here or is this a bug? I couldn't find anything in the docs and release notes that would mention anything related.
Any help would be much appreciated.
I've noticed there was a similar issue to this in #1328 last year, so perhaps this is a regression?

This is due to the refactoring of the code we did in 3.1.0 release, we're working hard on SuperSafe 1.2.0 that will be compatible with ScalaTest 3.1.0.
Sorry for the inconvenient caused.

The new supersafe 1.1.9 has fixed the problem for me, thanks for releasing a new version.


New version: Registrator v1.0.1

Registering package: Registrator
Repository: https://github.com/JuliaRegistries/Registrator.jl
Created by: @nkottary
Version: v1.0.1
Commit: 5283969cfe71e7e634c42f476ba8c1fecea6a20d
Reviewed by: @nkottary
Reference: https://github.com/JuliaRegistries/Registrator.jl/issues/242#issuecomment-553239208

[noblock]
@nkottary Can you add compat bounds for these deps? Then this PR can be automerged.


shortened strings and some text fixes for title of each key in details

just need to check whether metadata is can be parsed. In case of an abstract contract, it is empty ""


0.1.0rc12 v1 functions registered the newindex way get marked as a duplicate field

probably already known, but marked as an issue regardless.

odd thing is it didn't seem to do this before. Language server must have updated or something

Completely forgot about this, but this was resolved in cf4556e by just completely disabling the error.
I know, great fix 10/10.


Not Detecting any Text or Barcode

it's not detecting any text or barcode. I implemented it exactly like the example but I get failed to detect text every time

Did you set the scanarea ?
Can I see the code you are using?


TS2339: Property 'domainTags' does not exist on type 'IDomainsClient'

After updating to 9.0.0, domainTags doesn't exist on IDomainsClient.
compiling mgClient.domains.domainTags.devices(...
will throw TS2339: Property 'domainTags' does not exist on type IDomainsClient
any idea?

@fgrayli Thank you for the report.
Fixed in version v9.0.1


Fix centraldashboard role bindings

The $(namespace) variable isn't interpolated by kustomize because it's
not defined in params.yaml, and it's not needed because the namespace is
already defined in kustomize.yaml. Without this patch, the
centraldashboard service account does not have any roles or clusterroles
bound because the bindings refer to a service account in a nonexistent
namespace '$(namespace)'.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Checklist:

[ ] Unit tests have been rebuilt:

cd manifests/tests
make generate-changed-only
make test

This removes the need for some of the rolebindings that I used to have in https://gist.github.com/cmurphy/c6add3c7a0fb5a25467621705d00f417


Mul

is this pull request still relevant, or is the code already included ?

This particular pull is no longer relevant.


Minor Model changes and new migration

Sorry for the confusing descriptions :(

Current coverage is 96.86% (diff: 100%)

Merging #90 into master will increase coverage by 0.01%

@@             master        #90   diff @@
==========================================
  Files            22         22
  Lines           445        447     +2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            431        433     +2
  Misses           14         14
  Partials          0          0

Powered by Codecov. Last update cb1a7a6...e83f889


rightcontrol emits leftcontrol by default.

Issue #114 explained that keyd treats both control keys as leftcontrol. No one had a use case for treating them differently. Here's one: VirtualBox uses the right control key, and NOT the left control key, as the "host key', which is used to send special commands to a Virtual Box virtual machine. I have to stop keyd whenever I want to use this function, and then restart it when I'm done. Not convenient.

For the VirtualBox case, you can remap rightcontrol = rightcontrol. Nevertheless, there have been many issues about this before (see also https://github.com/rvaiya/keyd/issues/713#issuecomment-2044331523) and I do think that it would be a good idea to address it despite the existing workarounds.

Just adding another use case for Brazilians out there, in brazilian thinkpad keyboard (abnt kblayout) keyd is issuing rightcontrol when the question mark button (circle in red) is clicked, which makes us loose ? and /.

using rightcontrol = rightcontrol fixes it.

I have virt-manager setup to switch my keyboard between host and guest with ctrl+ctrl shortcut, and I was wondering why it's not working with keyd, this explains it.


8Queens_Genetic_Algorithm-by-Farhan

@AlyfarhanKhan  Why do you want to merge this here? Do you even know what this repo is about?


tela-icon-theme: 2023-02-03 -> 2023-06-25

Diff: https://github.com/vinceliuice/tela-icon-theme/compare/2023-02-03...2023-06-25
Changelog: https://github.com/vinceliuice/Tela-icon-theme/releases/tag/2023-06-25
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg eval


Copyright Hygiene

Capturing an issue from a conversation I had with @jbenet at Lab Day.
We need to first document and then automate the compliance for our IP policies.
This includes:

Preferred License
DCO
Commit Signing (as requested by the DCO)

I'd also add, we should use SPDX compliant license info in every file, and automate the compliance of that as well.

I don't think the license is necessary here. The way Node.js, and AFAIK the Linux Project, do it is just the signoff.
If you read the text of the DCO it notes that by signing off you are acknowledging the terms of the list "in the file". There's actually been some trepidation about projects that have failed to include license info in every file because of this.

Some unknowns come with translations contributed via crowdsourcing websites:
We want to consolidate translations in one place (Translation Project for IPFS GUIs: https://github.com/ipfs/ipfs-gui/issues/50).  This means in near future community will submit a lot of translations that way.
Current version of ipfs/community/docs/licensing-policy.md says:

All documentation and non-code resources should be licensed under the Creative Commons Attribution 4.0 International (CC BY 4.0) license.

Is it enough to state the above in README.md or CONTRIBUTING.md?
Or should we ask translation contributors to sign-off CLA  before they start translating?

[Click to if we need CLA for translations]
Transifex (one of crowdsourcing websites) says:

A CLA is an agreement between your company and the volunteers in your community. Usually, it's about how the work done by the community may be used, and who has permission to use it. You can add your own CLA in your team settings, and only let people who accept the CLA to contribute. As legal things can be touchy and confusing, we recommend consulting your legal counsel.

They provide a simple UI for setting CLA as well.
If its needed, who should write it? PL legal team?

cc  https://github.com/ipfs/ipfs-gui/issues/50, https://github.com/ipfs/community/issues/139


Add a RequestDecoderHandle type which is effectively a weak reference to a RequestDecoder

Add a RequestDecoderHandle type which is effectively a weak reference to a RequestDecoder.
Attempt to clarify the lifetime of RequestDecoder in mobile.
Risk Level: Low - mobile only
Testing: existing tests
Docs Changes: N/A
Release Notes: N/A

/assign @RenjieTang
WDYT? I'm not convinced that this is the right approach, but maybe?

/assign @abeyad

test/integration/api_listener_integration_test.cc:99:47: error: no member named 'newStream' in 'Envoy::Http::ApiListener'
    auto& stream_decoder = http_api_listener->newStream(stream_encoder_);

This looks real

test/integration/api_listener_integration_test.cc:99:47: error: no member named 'newStream' in 'Envoy::Http::ApiListener'
    auto& stream_decoder = http_api_listener->newStream(stream_encoder_);

This looks real

Thanks!


Typo in the IKEv2 troubleshooting doc

Typo in the IKEv2 troubleshooting doc.
in the wireshark filter, it mentioned "iskmp" rather than "isakmp"

@stegag : Thanks for your contribution! The author, @anzaman, has been notified to review your proposed change.

#sign-off

@stegag: I'm sorry - only the author of this article, @anzaman, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Destructive role for AlertController Button

Short description of the problem:
I'd like to see a destructive role value for AlertController.
Which Ionic Version? 2.x
Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.3.1
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-rc.1
Ionic CLI Version: 2.1.1
Ionic App Lib Version: 2.1.1
Ionic App Scripts Version: 0.0.36
ios-deploy version: 1.9.0
ios-sim version: 5.0.6
OS: Mac OS X Sierra
Node Version: v5.0.0
Xcode version: Xcode 8.1 Build version 8B62

Hello! While we appreciate you opening an issue with us i am going to close this issue and ask that you open a new one that has the issue template filled out please. Thanks for using Ionic!


Attempt at adding Bazel rules for protots

An attempt at #4
We import rules to invoke protoc from pubref/rules_protobuf. The
alternatives would have been 1) try to use native Bazel rules only and
rules from the gRPC reprository, or 2) invoke protoc directly in the
BUILD file.

is an issue because of multiple issues with the native & gRPC rules.
may actually be the best solution, in terms of usability and
compatibility with different versions of protobuf, gRPC and Bazel.

See BAZEL_NOTES.md for a more comprehensive discussion.

@bocon13 if you want to take a look


Grt pin access layer

Solves #455

Currently during fastroute it is never considered the pins access layers, the guides that connect the routing to the pin are only added at the end of the global route. This was causing some additional vias adding and also it wasn't allowing fastroute to fully understand net, preventing it from finding possible better routings considering the pins correct access layer. These changes make fastroute fully aware of the pins access layers and makes the necessary connection still on fastroute, removing the need of a post-processing to add these guides.

@arthurjolo note that "Solves #455" has no effect on that issue.  It is better to use a keyword from https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue


[MM-468]: Include number of lines changed in RHS PR list

Summary
Include the number of lines changed in the RHS PR list
Screenshot
Existing

Updated

How to test

Connect your mattermost to GitHub
Create a PR on GitHub with another account and add the GitHub account connected with mattermost as the reviewer
Open the RHS PR list

Created a PR on mattermost remote with all these changes hence closed this one


feat: add new Guidebanner and Carousel components

(FYI, Still under design review.)
Contributes to #2893
The Guidebanner component (see design) sit at the top of a page, or page-level tab, to introduce foundational concepts related to the page's content.
The Carousel is an internal component for the exclusive use of other Novice to Pro components. There is no documentation or Storybook story for this component. The Guidebanner is the first Novice to Pro component that uses the Carousel to be published, and so the Carousel is included here.
Novice to pro is a continuous learning framework aimed to orient, onboard, explain, educate, and cultivate novice users into high-functioning power users.
What did you change?
This is a new component.
How did you test and verify your work?

[x] Used the CLI to scaffold a new component.
[x] Added Storybook stories.
[x] Added documentation.
[x] Verified default tests.
[x] Added tests.
[ ] Passed design review. @sdignum, Bridget Ndege.

@paul-balchin-ibm I was moving so fast I wasn't thinking about being off the rest of this week. May want to assign this to Cameron since I'm out until Tuesday.

Will do, thanks @sdignum.

Overall, it's looking really good! Have a few initial notes. I'll continue to review more today
Guide banner: Few Items
The scroll gradient is overlapping the ghost button. It's only visible on hover

The 'Insights' headers are currently set to productive-heading-02. They should be productive-heading-01
(Only the Guide banner header should be productive-heading-02)
I'm also going to connect with Bridget about the spacing between the 'Insights' spacing between the header and body. Carbon recommends using no space if the size is the same


Go through tap-postgres tutorial

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/860
Originally created by @bencodezen on 2019-08-07 16:22:17

Go through new tap-postgres tutorial and make changes as necessary if issues arise in going through it.

View 2 previous comments from the original issue on GitLab


FullScreen is not working

This lib is awesome, video plaing very well, but i can not do the fullscreen. I used helper class from sample, but all that changes is screen orientation, and that all. My manifest contains this line  android:configChanges="orientation|screenSize|keyboardHidden|smallestScreenSize|screenLayout"
This is my code:
package shop.arvaal.com.shop;

public class CardProduct extends Fragment {
    private String attribute_text;
    private TextView attrib;
    private TextView tvPrice;
    private TextView currentColorText;
    private TextView tvPriceSpecial;
    private TextView option_hint;
    private FullScreenYouTube fullScreenHelper;
    private ArrayList<String> imageUrls;
    private JSONObject product;
    private ArrayList<String> currentColor;
    private YouTubePlayerView youtubePlayerView;

    @Nullable
    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        View view = inflater.inflate(R.layout.card_product, container, false);

         fullScreenHelper = new FullScreenYouTube(getActivity());
        mRecyclerView = view.findViewById(R.id.my_recycler_view);
        mLayoutManager = new LinearLayoutManager(getActivity(),LinearLayoutManager.HORIZONTAL, false);
        SnapHelper snapHelper = new LinearSnapHelper();
        snapHelper.attachToRecyclerView(mRecyclerView);
        mRecyclerView.setLayoutManager(mLayoutManager);
        mRecyclerView.setHasFixedSize(true);
        indicator = view.findViewById(R.id.circleIndicator);

       youtubePlayerView = view.findViewById(R.id.youtube_player_view);
        getLifecycle().addObserver(youtubePlayerView);

       final TextView button_text = view.findViewById(R.id.description_text_button);
       button_text.setOnClickListener(new View.OnClickListener() {
           @Override
           public void onClick(View v) {
               button_text.setText(decription_product.isExpanded() ? R.string.expand : R.string.collapse);
               decription_product.toggle();

           }
       });
        makeJsonObjectRequest(urlJsonObj+getArguments().getInt("someInt")+key);
            return view;
        }

******************************

                    if(product.getString("youtube_code").equals("empty")){
                        youtubeContainer.setVisibility(View.GONE);
                    }else {
                        youtubePlayerView.initialize(new YouTubePlayerInitListener() {
                            @Override
                            public void onInitSuccess(@NonNull final YouTubePlayer initializedYouTubePlayer) {
                                initializedYouTubePlayer.addListener(new AbstractYouTubePlayerListener() {
                                    @Override
                                    public void onReady() {
                                        initializedYouTubePlayer.cueVideo(product.optString("youtube_code"), 0);
                                    }
                                });
                                addFullScreenListenerToPlayer(initializedYouTubePlayer);
                            }
                        }, true);
                    }

     *********************************************
    private void addFullScreenListenerToPlayer(final YouTubePlayer youTubePlayer) {
        youtubePlayerView.addFullScreenListener(new YouTubePlayerFullScreenListener() {
            @Override
            public void onYouTubePlayerEnterFullScreen() {
                getActivity().setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE);
                fullScreenHelper.enterFullScreen()
            }

            @Override
            public void onYouTubePlayerExitFullScreen() {
                getActivity().setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT);
                fullScreenHelper.exitFullScreen();
            }
        });
    }
    @Override public void onDestroy() {
        super.onDestroy();
        youtubePlayerView.release()
    }
}

This is helper class:
package shop.arvaal.com.shop;
import android.app.Activity;
import android.view.View;
public class FullScreenYouTube{
private Activity context;
private View[] views;

/**
 * @param context
 * @param views to hide/show
 */
public FullScreenYouTube(Activity context, View ... views) {
        this.context = context;
        this.views = views;
        }

/**
 * call this method to enter full screen
 */
public void enterFullScreen() {
       View decorView = context.getWindow().getDecorView();

        hideSystemUI(decorView);

        for(View view : views) {
        view.setVisibility(View.GONE);
        view.invalidate();
        }
        }

/**
 * call this method to exit full screen
 */
public void exitFullScreen() {
       View decorView = context.getWindow().getDecorView();

        showSystemUI(decorView);

        for(View view : views) {
        view.setVisibility(View.VISIBLE);
        view.invalidate();
        }
        }

private void hideSystemUI(View mDecorView) {
        mDecorView.setSystemUiVisibility(
        View.SYSTEM_UI_FLAG_LAYOUT_STABLE
        | View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION
        | View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN
        | View.SYSTEM_UI_FLAG_HIDE_NAVIGATION
        | View.SYSTEM_UI_FLAG_FULLSCREEN
        | View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY);
        }

private void showSystemUI(View mDecorView) {
        mDecorView.setSystemUiVisibility(View.SYSTEM_UI_FLAG_LAYOUT_STABLE);
        }
        }

Hi, try to understand how the sample app is doing it :)

i'm trying, but nothing works. Сan tell me where should I look?

You should look at the basic example.

It think the problem we're running into is persisting the fragment properly. Persisting the activities not hard.

Hi @edward1988,
The problem is with the recyclerView item and its' height. You should either change recyclerView Item's heigth on 'full screen' click, or navigate to other Activity/Fragment which has only YoutubePlayerView.

I am not even getting the option to implement full screen in XML

@Dkathayat That has been removed with the latest version of the library.

so how can i full screen the video pls help


Update wrong catch block

Checklist

[ ] npm install && npm test passes
[ ] tests are included
[ ] documentation is changed or added
[ ] commit message follows commit guidelines

Description of change

https://stackoverflow.com/questions/3335376/why-do-good-programmers-sometimes-silently-swallow-exceptions

Yeah, sorry, this is intentional (IIRC), there's some OS' where this fails, I can't remember the details, it was some trimmed-down Linux, I'm sure git blame would point the way to the PR that introduced the quiet fail.
Is this causing problems for you?

hmm I had a few other issues that were causing me to get to this point anyway, but this is disguising the error, as it gives me
gyp ERR!  I knew I wasn't going that senile: https://github.com/nodejs/node-gyp/pull/1835 but it's in install.js, while this same code is now in find-python.js which was just recently refactored.

ah alright! nice, so we can at least fix the unexpected token thing

@cclauss
The catch {} syntax is valid on our supported versions of Node (10.12 and newer). I honestly hadn't anticipated this would every run on Node older than that, but in hindsight that's a little optimistic.
The catch {} I added in https://github.com/nodejs/node-gyp/pull/2375 is admittedly a syntax error on older Node. Older node wants the error to be passed into the catch block: catch (e) {}.
MDN says this is  a change as of Node 10/Chrome 66, but I'm finding it hard to confirm that anywhere in NodeJS or Chrome's documentation/blogs. Maybe this NodeJS PR? https://github.com/nodejs/node/pull/20708 (landed for Node 10.2 and newer).
I tried logging the error (https://github.com/nodejs/node-gyp/pull/2375#issuecomment-818217760 --> implementation), but that added complexity and size of code seemed a bit overkill, given we intend to fail gracefully and just move on. It is hard to properly add logging at file-level scope (outside of PythonFinder), and I found refactoring this into PythonFinder tricky or impossible, since this data needs to be computed for winDefaultLocations to exist when PythonFinder is made... That's as well as I know how to explain it, given my limited JS proficiency. (I am self-taught with JS, and PythonFinder honestly confuses me a bit.)

:thumbsup: thanks @DeeDeeG, it's good to lean on the conservative side for node-gyp since it's in such wide usage. When people show up using older versions of Node.js (for whatever reason - sometimes they can't change) and well tell them that their old version of node-gyp doesn't work for their use-case, it's not fun to tell them they can't get the newer one cause their Node.js is old. So where the change is painless, like this one, let's opt for the conservative choice.

Update: I found out that trying to use node-gyp 8 on older Node (Node < 10) is still rather busted, due to https://github.com/nodejs/node-gyp/pull/2220.
Here's the details and a workaround...
https://github.com/nodejs/node-gyp/pull/2220/ broke node-gyp install (and, by extension, broke node-gyp rebuild) on Node older than version 10, by relying on the stream.pipeline Node API function that was only added in Node v10.0.0.  (The fsPromises API was also added in Node 10.0.0).
Workaround if you really need to run the latest node-gyp on Node 8.x would be:
Caveat/warning: All this only applies to<EMAIL_ADDRESS>Only tested somewhat working by running node-gyp rebuild via npm rebuild... Using npm 6.13.4 and Node 8.17.0. Only tested on Linux. Any other combination may not work, and none of this is actually officially supported by node-gyp or npm or Node, etc. Try at your own risk.

Install older Node's development headers with an older node-gyp that works on older Node, such as Node 8.x.

(With the older Node version, run npx node-gyp@6 install)

Then, go in with a text editor and manually edit the copy of node-gyp you want to run; Edit node-gyp's lib/find-python.js file like this PR does; update the catch {} block in lib/find-python.js to pass in the error: catch (e) {}.

(Patch the file here.)

Then in lib/install.js...

Go in with a text editor and manually replace const streamPipeline = util.promisify(stream.pipeline) near the top of the file with an empty function: const streamPipeline = function () {}.

(here.)

And replace fs.promises.stat() with fs.statSync(), and replace fs.promises.readFile() with fs.readFileSync(), and delete the await immediately preceding these two fs API calls, since we're using basic synchronous code now, not Promises.

(Only needed in two places. here and here.)


Change segfault method!

Changed segfault method based on issue/enhacement #90
Tests expand_params_internal.phpt and return_expanded_params_internal.phpt skipped if PHP < 8.2 because don't allow null and false as standalone types.
Only PHP 8.2+ allow null and false as standalone types:
https://php.watch/versions/8.2/null-false-types

P.S. Sorry for many commits for file otel_observer.c i had some issue with my clang-formater tool 😬

P.S. Sorry for many commits for file otel_observer.c i had some issue with my clang-formater tool 😬

It will get squashed on merge, it will be as if you only submitted one perfect commit :)

Difference from the functions....


Improve performance - do not dereference asset

I noticed the official url builder using the image width and height without depending on the asset, this is the code extracted:
const example = 'image-Tb9Ew8CXIwaY6R1kjMvI0uRR-2000x3000-jpg'
function parseAssetId(ref) {
  const [, id, dimensionString, format] = ref.split('-')

  if (!id || !dimensionString || !format)
    throw new Error(("Malformed asset _ref '" + ref + "'. Expected an id like \"" + example + "\"."))

  const [imgWidthStr, imgHeightStr] = dimensionString.split('x')
  const width = +imgWidthStr
  const height = +imgHeightStr

  if (!(isFinite(width) && isFinite(height)))
    throw new Error(("Malformed asset _ref '" + ref + "'. Expected an id like \"" + example + "\"."))

  return { id, width, height, format }
}

So we could do the same. To be backwards compatible we can use image.asset._ref || image.asset._id.

The asset contains the cropping information though, which is a feature that we use a lot. We could add this as a performance improvement in case you don't need cropping. In practice this would mean Image can benefit from this approach and ImageCover and ImageCrop would still need a dereferenced asset.

@peeke That is incorrect. The image contains the cropping and hotspot information:
{
  "_type": "image",
  "asset": {
    "_id": "image-f3bcbf598541e45a24b4483c1bd5ec8e49be5341-317x435-png",
    "metadata": {
      "dimensions": {
        "height": 435,
        "width": 317
      }
    }
  },
  "crop": {
    "_type": "sanity.imageCrop",
    "bottom": 0.15077288941736022,
    "left": 0.027586206896551727,
    "right": 0.220689655172414,
    "top": 0.0025128814902893037
  },
  "hotspot": {
    "_type": "sanity.imageHotspot",
    "height": 0.37429250891795507,
    "width": 0.5448275862068959,
    "x": 0.4034482758620689,
    "y": 0.18965913594926684
  }
}

Right, I see I got that backwards. Should be a great improvement then, simplifies the needed groq queries as well.

Yeah, that's how I discovered it :-D


<EMAIL_ADDRESS>missing 'dist' in package

Description
I happened to install the latest version (0.13.2) and noticed that the package is missing the dist directory. 0.13.1 is fine.
Reproduction
npm i<EMAIL_ADDRESS>ls -al node_modules/openapi-fetch

Expected result
(in case it’s not obvious)
Checklist

[ ] I’m willing to open a PR (see CONTRIBUTING.md)

My build failing after installing 0.13.2 is probably related to this...
vite v6.0.1 building for production...
transforming...
✓ 434 modules transformed.
x Build failed in 2.50s
error during build:
[commonjs--resolver] Failed to resolve entry for package "openapi-fetch". The package may have incorrect main/module/exports specified in its package.json.
...

Same here, 0.13.2 lacks dist folder, 0.13.1 is fine

Same issue, builds are failing 😕

I'm also seeing the same missing ./dist in the recently-published<EMAIL_ADDRESS>while 0.2.6 has the ./dist directory...

Same here, it's my first time using openapi-fetch and my editor couldn't find the import. yarn chose to install 0.13.2, which is published to npm but not documented on the GitHub releases page. Downgrading to 0.13.1 worked.

@drwpow could this be because of the turborepo upgrade?

Thanks for raising! This was a hiccup in our automated publish pipeline. Will have refreshes out shortly fixing the issue.

@drwpow could this be because of the turborepo upgrade?

Also just for internal reference, this did happen in the Turborepo upgrade, but was 100% unrelated to Turborepo. This was the offending line:
https://github.com/openapi-ts/openapi-typescript/pull/2027/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L24
-    - run: pnpm run build

There’s a weird quirk about the Changesets release where the version script doesn’t run every time. During the actual release, you do need to run pnpm run build independently of the version script (which also has a build inside). This behavior is undocumented. So I wrote a comment in ci/.release.yml reminding us should this ever happen again.

openapi-fetch and openapi-react-query got refreshes (you’ll have to update to the latest patch; for obvious reasons npm doesn’t let you re-publish a version), and confirmed the dist/ folder was published correctly. Sorry for the inconvenience!