Cilium is running out of IPs to assign on EKS

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
One of the pods fails to start.

Cilium Version
cilium-cli: v0.12.6 compiled with go1.19.1 on darwin/amd64
cilium image (default): v1.12.2
cilium image (stable): v1.12.3
cilium image (running): v1.12.3

Kernel Version
Linux ip-10-0-76-118.us-west-2.compute.internal 5.10.135 #1 SMP Tue Oct 18 01:58:53 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux

Kubernetes Version
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.3", GitCommit:"434bfd82814af038ad94d62ebe59b133fcb50506", GitTreeState:"clean", BuildDate:"2022-10-12T10:57:26Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"darwin/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"23+", GitVersion:"v1.23.13-eks-fb459a0", GitCommit:"55bd5d5cb7d32bc35e4e050f536181196fb8c6f7", GitTreeState:"clean", BuildDate:"2022-10-24T20:35:40Z", GoVersion:"go1.17.13", Compiler:"gc", Platform:"linux/amd64"}

Sysdump
cilium-sysdump-20221108-101144.zip
Relevant log output
From the POD
(combined from similar events): Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "163dcd01482af01487815ff3d27c9ec0b2641ec6f21bcf60726d0ed659bd6af3": plugin type="cilium-cni" name="cilium" failed (add): unable to allocate IP via local cilium agent: [POST /ipam][502] postIpamFailure No more IPs available

From Cilium
level=info msg="Rewrote endpoint BPF program" containerID= datapathPolicyRevision=0 desiredPolicyRevision=1 endpointID=557 identity=4 ipv4= ipv6= k8sPodName=/ subsys=endpoint
level=info msg="Serving cilium health API at unix:///var/run/cilium/health.sock" subsys=health-server
level=info msg="Compiled new BPF template" BPFCompilationTime=9.722552764s file-path=/var/run/cilium/state/templates/3d012e81c162f6494dba602feba35ce0bf5419ee094fcfb4f1d30f3e2ec37b79/bpf_host.o subsys=datapath-loader
level=info msg="Rewrote endpoint BPF program" containerID= datapathPolicyRevision=0 desiredPolicyRevision=1 endpointID=2272 identity=1 ipv4= ipv6= k8sPodName=/ subsys=endpoint
level=info msg="Restored endpoint" endpointID=2272 ipAddr="[ ]" subsys=endpoint
level=info msg="Finished regenerating restored endpoints" regenerated=8 subsys=daemon total=8
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=info msg="Conntrack garbage collector interval recalculated" deleteRatio=0.007598876953125 newInterval=11m15s subsys=map-ct
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath
level=warning msg="Unable to install direct node route {Ifindex: 0 Dst: <IP_ADDRESS>/16 Src: <nil> Gw: <IP_ADDRESS> Flags: [] Table: 0 Realm: 0}" error="route to destination <IP_ADDRESS> contains gateway <IP_ADDRESS>, must be directly reachable" subsys=linux-datapath

kubectl -n kube-system exec -q cilium-xzv2p -- cilium status --verbose
KVStore:                Ok   Disabled
Kubernetes:             Ok   1.23+ (v1.23.13-eks-fb459a0) [linux/amd64]
Kubernetes APIs:        ["cilium/v2::CiliumClusterwideNetworkPolicy", "cilium/v2::CiliumEndpoint", "cilium/v2::CiliumNetworkPolicy", "cilium/v2::CiliumNode", "core/v1::Namespace", "core/v1::Node", "core/v1::Pods", "core/v1::Service", "discovery/v1::EndpointSlice", "networking.k8s.io/v1::NetworkPolicy"]
KubeProxyReplacement:   Strict   [eth0 <IP_ADDRESS> (Direct Routing), eth1 <IP_ADDRESS>, eth2 <IP_ADDRESS>]
Host firewall:          Disabled
CNI Chaining:           none
Cilium:                 Ok   1.12.3 (v1.12.3-1c466d2)
NodeMonitor:            Listening for events on 2 CPUs with 64x4096 of shared memory
Cilium health daemon:   Ok
IPAM:                   IPv4: 9/9 allocated,
Allocated addresses:
  <IP_ADDRESS> (router)
  <IP_ADDRESS> (kube-system/hubble-ui-77b4dfdf8f-vccgx[restored])
  <IP_ADDRESS> (kube-system/coredns-57ff979f67-7qh2w[restored])
  <IP_ADDRESS> (kube-system/cluster-autoscaler-aws-cluster-autoscaler-7677b69fcb-fpmx8[restored])
  <IP_ADDRESS> (health)
  <IP_ADDRESS> (kube-system/hubble-relay-7f6c4c5fb6-ghhnn[restored])
  <IP_ADDRESS> (kube-system/cluster-autoscaler-aws-cluster-autoscaler-7677b69fcb-tsbqg[restored])
  <IP_ADDRESS> (kube-system/ebs-csi-node-zbbjh[restored])
  <IP_ADDRESS> (kube-system/ebs-csi-controller-6954c59468-gw45k[restored])
BandwidthManager:       Disabled
Host Routing:           Legacy
Masquerading:           IPTables [IPv4: Enabled, IPv6: Disabled]
Clock Source for BPF:   ktime
Controller Status:      55/55 healthy
  Name                                          Last success   Last error   Count   Message
  bpf-map-sync-cilium_lxc                       9s ago         never        0       no error
  cilium-health-ep                              13s ago        never        0       no error
  dns-garbage-collector-job                     22s ago        never        0       no error
  endpoint-1336-regeneration-recovery           never          never        0       no error
  endpoint-1664-regeneration-recovery           never          never        0       no error
  endpoint-1773-regeneration-recovery           never          never        0       no error
  endpoint-184-regeneration-recovery            never          never        0       no error
  endpoint-2272-regeneration-recovery           never          never        0       no error
  endpoint-335-regeneration-recovery            never          never        0       no error
  endpoint-467-regeneration-recovery            never          never        0       no error
  endpoint-557-regeneration-recovery            never          never        0       no error
  endpoint-768-regeneration-recovery            never          never        0       no error
  endpoint-gc                                   3m22s ago      never        0       no error
  ipcache-inject-labels                         13m17s ago     13m21s ago   0       no error
  k8s-heartbeat                                 22s ago        never        0       no error
  link-cache                                    14s ago        never        0       no error
  metricsmap-bpf-prom-sync                      7s ago         never        0       no error
  neighbor-table-refresh                        14s ago        never        0       no error
  resolve-identity-557                          3m13s ago      never        0       no error
  restoring-ep-identity (1336)                  13m15s ago     never        0       no error
  restoring-ep-identity (1664)                  13m15s ago     never        0       no error
  restoring-ep-identity (1773)                  13m15s ago     never        0       no error
  restoring-ep-identity (184)                   13m15s ago     never        0       no error
  restoring-ep-identity (2272)                  13m15s ago     never        0       no error
  restoring-ep-identity (335)                   13m15s ago     never        0       no error
  restoring-ep-identity (467)                   13m15s ago     never        0       no error
  restoring-ep-identity (768)                   13m15s ago     never        0       no error
  sync-endpoints-and-host-ips                   15s ago        never        0       no error
  sync-lb-maps-with-k8s-services                13m15s ago     never        0       no error
  sync-policymap-1336                           50s ago        never        0       no error
  sync-policymap-1664                           50s ago        never        0       no error
  sync-policymap-1773                           50s ago        never        0       no error
  sync-policymap-184                            50s ago        never        0       no error
  sync-policymap-2272                           50s ago        never        0       no error
  sync-policymap-335                            50s ago        never        0       no error
  sync-policymap-467                            50s ago        never        0       no error
  sync-policymap-557                            50s ago        never        0       no error
  sync-policymap-768                            50s ago        never        0       no error
  sync-to-k8s-ciliumendpoint (1336)             4s ago         never        0       no error
  sync-to-k8s-ciliumendpoint (1664)             4s ago         never        0       no error
  sync-to-k8s-ciliumendpoint (1773)             4s ago         never        0       no error
  sync-to-k8s-ciliumendpoint (184)              4s ago         never        0       no error
  sync-to-k8s-ciliumendpoint (2272)             4s ago         never        0       no error
  sync-to-k8s-ciliumendpoint (335)              4s ago         never        0       no error
  sync-to-k8s-ciliumendpoint (467)              4s ago         never        0       no error
  sync-to-k8s-ciliumendpoint (557)              13s ago        never        0       no error
  sync-to-k8s-ciliumendpoint (768)              4s ago         never        0       no error
  template-dir-watcher                          never          never        0       no error
  waiting-initial-global-identities-ep (1336)   13m15s ago     never        0       no error
  waiting-initial-global-identities-ep (1664)   13m15s ago     never        0       no error
  waiting-initial-global-identities-ep (1773)   13m15s ago     never        0       no error
  waiting-initial-global-identities-ep (184)    13m15s ago     never        0       no error
  waiting-initial-global-identities-ep (335)    13m15s ago     never        0       no error
  waiting-initial-global-identities-ep (467)    13m14s ago     never        0       no error
  waiting-initial-global-identities-ep (768)    13m15s ago     never        0       no error
Proxy Status:            OK, ip <IP_ADDRESS>, 0 redirects active on ports 10000-20000
Global Identity Range:   min 256, max 65535
Hubble:                  Ok   Current/Max Flows: 4095/4095 (100.00%), Flows/s: 9.29   Metrics: Ok
KubeProxyReplacement Details:
  Status:                 Strict
  Socket LB:              Enabled
  Socket LB Protocols:    TCP, UDP
  Devices:                eth0 <IP_ADDRESS> (Direct Routing), eth1 <IP_ADDRESS>, eth2 <IP_ADDRESS>
  Mode:                   SNAT
  Backend Selection:      Maglev (Table Size: 16381)
  Session Affinity:       Enabled
  Graceful Termination:   Enabled
  NAT46/64 Support:       Disabled
  XDP Acceleration:       Disabled
  Services:
  - ClusterIP:      Enabled
  - NodePort:       Enabled (Range: 30000-32767)
  - LoadBalancer:   Enabled
  - externalIPs:    Enabled
  - HostPort:       Enabled
BPF Maps:   dynamic sizing: on (ratio: 0.002500)
  Name                          Size
  Non-TCP connection tracking   65536
  TCP connection tracking       131072
  Endpoint policy               65535
  Events                        2
  IP cache                      512000
  IP masquerading agent         16384
  IPv4 fragmentation            8192
  IPv4 service                  65536
  IPv6 service                  65536
  IPv4 service backend          65536
  IPv6 service backend          65536
  IPv4 service reverse NAT      65536
  IPv6 service reverse NAT      65536
  Metrics                       1024
  NAT                           131072
  Neighbor table                131072
  Global policy                 16384
  Per endpoint policy           65536
  Session affinity              65536
  Signal                        2
  Sockmap                       65535
  Sock reverse NAT              65536
  Tunnel                        65536
Encryption:                                              Disabled
Cluster health:                                          3/3 reachable   (2022-11-08T18:15:09Z)
  Name                                                   IP              Node        Endpoints
  ip-10-0-61-11.us-west-2.compute.internal (localhost)   <IP_ADDRESS>      reachable   reachable
  ip-10-0-191-124.us-west-2.compute.internal             <IP_ADDRESS>    reachable   reachable
  ip-10-0-76-118.us-west-2.compute.internal              <IP_ADDRESS>     reachable   reachable

Anything else?
In the cilium pod logs, all 9/9 IPs are assigned.
However, the EKS node has a capacity for 11 pods.

Cilium Helm values
{
  rollOutCiliumPods: true,
  autoDirectNodeRoutes: true,
  egressMasqueradeInterfaces: 'eth0',
  tunnel: 'disabled',
  kubeProxyReplacement: 'strict',
  k8sServiceHost,
  k8sServicePort: '443',
  loadBalancer: {
    algorithm: 'maglev',
    serviceTopology: true,
  },
  maglev: {
    hashSeed,
  },
  eni: {
    enabled: true,
    awsReleaseExcessIPs: true,
  },
  ipam: {
    mode: 'eni',
  },
  socketLB: {
    hostNamespaceOnly: true,
  },
  hubble: {
    enabled: true,
    relay: {
      enabled: true,
    },
    ui: {
      enabled: true,
    },
    metrics: {
      enabled: ['dns:query;ignoreAAAA', 'drop', 'tcp', 'flow', 'icmp', 'http'],
    },
    tls: {
      auto: {
        method: 'cronJob',
      },
    },
  },
}

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I have the same issue.

Having the same issue as well sadly. Very easy to reproduce by just scaling pods. We are using Karpenter for node autoscaling. Basically default settings related to ENI/IPAM, no exotic instance types either. Evaluating cilium and this is a blocker really, otherwise everything working excellently. Saw from other Issues that some sort of workaround is possible using managed node groups on EKS, but not using those.
Helm values file used in installation:
eni:
  enabled: true
  awsEnablePrefixDelegation: true
ipam:
  mode: eni
egressMasqueradeInterfaces: eth0
tunnel: disabled
hubble:
  relay:
    enabled: true
  enabled: true
  ui:
    enabled: true
  metrics:
    enabled:
      - dns
      - drop
      - tcp
      - flow
      - port-distribution
      - icmp
      - http
prometheus:
  enabled: true
operator:
  prometheus:
    enabled: true
endpointStatus:
  enabled: true
  status: policy
bandwidthManager:
  enabled: true
encryption:
  enabled: true
  type: ipsec
affinity:
  nodeAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
      nodeSelectorTerms:
        - matchExpressions:
            - key: eks.amazonaws.com/compute-type
              operator: NotIn
              values:
                - fargate

Adding awsEnablePrefixDelegation: true seems to have done nothing to help with this, previously got the same without it. VPC subnets have plenty of IPs, it is just a instance ENI limits issue.
Some more info and logs, hopefully it will help :)
cilium_agent_logs.txt
cilium_status_verbose.txt
cilium_node_describe.txt

I have the same issue, too.
I try to enable awsEnablePrefixDelegation: true but nothing changes.

I have the same issue, too. I try to enable awsEnablePrefixDelegation: true but nothing changes.
updated: works with setting nodeinit.enable=true

it's work for me too, thanks @TokuiNico

@munjalpatel @ariretiarno @TokuiNico @kahirokunn @mikalinnanoja-rovio Cilium uses 2 of the ENI IP addresses, one for cilium-host and the other for cilium-health. @tom-hadlaw-hs in the new metric that you added is it accounting for the Cilium Host and Cilium Health IP addresses? Also, can you share the name of the metric that you added so that people can use that metric to see how many IP addresses is Cilium using?


Module Not Found

When I try these steps and finally run python3 botTuber.py this error was thrown. But then when I tried to re-install the missing module it is already installed.

I tried uninstalling the module and reinstall it, but same.
How can I resolve this? Not quite sure whether it is a bug or not. Can someone help me out?

It's not a bug in BotTuber
cd to BotTuber Folder, and run
pip3 install -r requirements.txt
If that's not helping than try it in any Linux distro

Tried both and still the same.

Try to update things
apt update && apt upgrade -y
apt install python3 python3-pip
pip3 install -r requirements.txt

Actually, I was trying this in a WSL on Windows. Once moved to ubuntu and tried it worked. Thanks.


rtl8812au: <IP_ADDRESS>_28373.20190903 -> <IP_ADDRESS>_35491.20200318

Motivation for this change
Bump package. Fixes building with linux <= 5.6. Tested briefly on linux 5.4.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

We should backport this to 20.03

@GrahamcOfBorg eval


rename entries in Sort menu

(roughly) fix flarum/core#351

@tobscure Do you think this improves the situation? You did not voice your opinion in flarum/core#351.

Can I get some other opinions here? I don't like these long versions too much, but I acknowledge there is a problem with some of these short strings (and with making it clear that these options are about the sort order of the list).

Well I'm not sure if there is a better way since they are discribing two different types ('reply' and 'discussion').
Regarding sort order, maybe (at least for now) changing Recent replies (the value of latest_button) to Latest replies would help.

I don't like these long versions neither. For the French translation, I changed Latest (latest_button) to Activity, but I don't know if it's clearer in English. The issue is, like @renyuneyun said, that don't describe the same "type".

Currently the issue with the longer strings is a UI one, in that it makes the sorting dropdown much wider which is kind of ugly. (Not sure a sorting control needs to have that much prominence.)
So I think we should revisit this after the discussion list revamp is implemented, where we will have the opportunity to tone down and/or relocate the sorting control. (It's not clear where it will be in the mockup, but I'm thinking just a small text-only button above the discussion list, with no background, as in this mobile mockup.)

I made a note over in the revamp ticket, so I am closing this for now.
Thanks for your effort, @renyuneyun.


Add support for client-initiated connection settings request

Implemented spec change https://github.com/open-telemetry/opamp-spec/pull/162
Added ability for the client to request connection settings.
Added CSR flow example to demonstrate the new capability.

Does anyone know why the codecov BASE commit is several months old? It says Coverage data is based on head f521153 compared to base efddaa2

Does anyone know why the codecov BASE commit is several months old? It says Coverage data is based on head f521153 compared to base efddaa2

Probably because the PR was created a few months ago?
Also I think the overall coverage percentages are incorrect:

I don't think the diff is at 44.15%, it should be higher based on line-by-line report I checked.

I think there is some bug with codecov.  Even the most recent PR merged to the main also has a report that says codecov/project 71.58% (-4.54%) compared to efddaa2, which is from last year Nov.

@open-telemetry/opamp-go-approvers @open-telemetry/opamp-go-maintainers this is ready for review.


Fix loss of data due to conversion build warnings in MS-Windows

In the Appveyor CI Windows builds, there are several warnings similar to the one below:
warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data
This PR fixes these warnings.

thanks!


How does gae_config_path work?

 - name: Initialize Google Cloud SDK
      uses: nakassh/publish-gae-action@master
      with:
        . . .
        gae_config_path: ./folder/app.yaml

 - name: Publish app to Google App Engine
    run: |
     . . .
      gcloud -q app deploy ./folder/app.yaml --promote

Is this how it is supposed to be? If not, can you provide some example how to?

 - name: Initialize Google Cloud SDK
      uses: nakassh/publish-gae-action@master
      with:
        . . .
        gae_config_path: ./folder/app.yaml

 - name: Publish app to Google App Engine
    run: |
     . . .
      gcloud -q app deploy ./folder/app.yaml --promote

Is this how it is supposed to be? If not, can you provide some example how to?

Have you checked out first before publishing?
steps:
  - name: Checkout
    uses<EMAIL_ADDRESS>  - name: Initialize Google Cloud SDK
    uses: zxyle/publish-gae-action@master
    ...
  - name: Publish app to Google App Engine
    run: |
    ...


Not compatible with the latest version of IDE (241)

It gets disabled by the IDE with the following error message:
"Plugin error
Plugin 'NotesTree' (version '1.4.1') is not compatible with the current version of the IDE, because it requires build 233.* or older but the current build is PY-241.14494.241"
But I'm 100% positive you are aware of that :-)
Great plugin BTW!

Hello @komatebe .
Thank you for the issue and the feedback. The new compatible version will be available after JB review. Usually it takes 1-2 business days

Thanks, @epm-dev-priporov
This is great news. Thanks for your prompt response.
Best!


Cannot read properties of undefined (reading 'dispose')

TypeError: Cannot read properties of undefined (reading 'dispose')
at A.sb in src/vs/workbench/browser/parts/views/viewPaneContainer.ts:819:15
at u.value in src/vs/workbench/browser/parts/views/viewPaneContainer.ts:533:92
at f.y in src/vs/base/common/event.ts:1140:13
at f.z in src/vs/base/common/event.ts:1151:9
at f.fire in src/vs/base/common/event.ts:1175:9
at n.J in src/vs/workbench/services/views/common/viewContainerModel.ts:664:44
at n.F in src/vs/workbench/services/views/common/viewContainerModel.ts:425:9
at u.value in src/vs/workbench/services/views/common/viewContainerModel.ts:359:81
at f.y in src/vs/base/common/event.ts:1140:13
at f.fire in src/vs/base/common/event.ts:1171:9
at s.t in src/vs/workbench/services/views/common/viewContainerModel.ts:170:34
at u.value in src/vs/workbench/services/views/common/viewContainerModel.ts:89:159
at f.y in src/vs/base/common/event.ts:1140:13
at f.fire in src/vs/base/common/event.ts:1171:9
at u.value in src/vs/base/common/event.ts:152:97
at c.y in src/vs/base/common/event.ts:1140:13
at c.z in src/vs/base/common/event.ts:1151:9
at c.fire in src/vs/base/common/event.ts:1175:9
at c.fire in src/vs/base/common/event.ts:1337:11
at S.u in src/vs/platform/storage/common/storage.ts:416:27
at u.value in src/vs/platform/storage/common/storageService.ts:71:82
at c.y in src/vs/base/common/event.ts:1140:13
at c.z in src/vs/base/common/event.ts:1151:9
at c.fire in src/vs/base/common/event.ts:1175:9
at c.resume in src/vs/base/common/event.ts:1326:12
at y.u in src/vs/base/parts/storage/common/storage.ts:160:29
at u.value in src/vs/base/parts/storage/common/storage.ts:145:67
at f.y in src/vs/base/common/event.ts:1140:13
at f.fire in src/vs/base/common/event.ts:1171:9
at E.h in src/vs/platform/storage/common/storageIpc.ts:108:35
at u.value in src/vs/platform/storage/common/storageIpc.ts:103:161
at f.y in src/vs/base/common/event.ts:1140:13
at f.fire in src/vs/base/common/event.ts:1171:9
at Z in src/vs/base/parts/ipc/common/ipc.ts:675:60
at O.t in out/vs/workbench/workbench.desktop.main.js:616:1512
at O.s in src/vs/base/parts/ipc/common/ipc.ts:732:17
at u.value in src/vs/base/parts/ipc/common/ipc.ts:549:63
at f.y in src/vs/base/common/event.ts:1140:13
at f.z in src/vs/base/common/event.ts:1151:9
at f.fire in src/vs/base/common/event.ts:1175:9
at Function.he in src/vs/base/common/event.ts:559:41

Go to Errors Site

/duplicate
https://github.com/microsoft/vscode/issues/199947

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Bugfix rejoin

Fixed rejoin bug
Updated tests according to the changes made
Refactoring and cleanup

Codecov Report

Merging #10 into master will decrease coverage by 0.36%.
The diff coverage is 71.11%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   66.82%   66.46%   -0.37%
==========================================
  Files          15       16       +1
  Lines         826      832       +6
==========================================
+ Hits          552      553       +1
- Misses        241      249       +8
+ Partials       33       30       -3

Impacted Files
Coverage Δ

bootstrap.go
78.12% <ø> (-3.93%)
:arrow_down:

follower.go
16.66% <ø> (-23.34%)
:arrow_down:

messages.go
64.10% <ø> (-0.61%)
:arrow_down:

node.go
75.88% <45.83%> (+1.84%)
:arrow_up:

config.go
92.30% <100.00%> (ø)

leader.go
46.87% <100.00%> (-0.82%)
:arrow_down:

precandidate.go
36.84% <100.00%> (-1.09%)
:arrow_down:

rejoin.go
100.00% <100.00%> (ø)

types.go
100.00% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60f7bf...c418d3a. Read the comment docs.


Fix handling of img nodelist/array

When fix is called with an array of nodes or a nodelist, the function incorrectly wraps it inside another array (eg: [el, el] becomes [[el, el]]) which causes type errors

Thank you! Now in 2.5.9

wow, that was really quick. Thanks for the release!


containerd hangs on start in low-entropy situations

Description
Based on discussion in linuxkit/linuxkit#3032 and linuxkit/linuxkit#3096, it seems that a call to crypto/rand's Read function will block when running on Linux kernel versions 4.14.36 and up, due to a fix for CVE-2018-1108.
As I understand it, prior to the fix, /dev/random was usable before enough entropy was gathered to consider it as a crytographically-safe source. The fix effectively causes reads to /dev/random to block until enough entropy was gathered to fully initialize the CRNG. And Go's crypto/rand Read function uses the Linux getrandom(2) syscall (without setting GRND_NONBLOCK), which reads from /dev/random and therefore now blocks.
Anyway, all this boils down to this line:
https://github.com/containerd/containerd/blob/01d309e8f20647f0046c37ca3986faacf17f7588/services/leases/local.go#L118
which will now block when not enough entropy is available. In my case it blocks for ~2mins, but it varies.
Based on the PR comment when that code was originally introduced, I believe that using math/rand instead would be "good enough" - especially:

Since there is already a nanosecond granular time component, a failure to get a unique value here is not a huge concern.

(from @dmcgowan)
Steps to reproduce the issue:

start containerd on a system with a recent-enough kernel, and not enough entropy and without a RNG, for example with LinuxKit - the https://github.com/linuxkit/linuxkit/blob/master/examples/getty.yml example displays this every time for me on my PCEngines APU2C4, which has no HWRNG, though QEMU without a virtio-rng-pci device may work too
watch containerd hang for seconds-to-minutes until CRNG is initialized

Describe the results you received:
containerd blocks for ~2mins on start
Describe the results you expected:
containerd starting ~2mins faster 😉
Output of containerd --version:
containerd github.com/containerd/containerd v1.1.0-rc.2 f630d5f0a639d7d73a806f19f1a6157e768756a5

It looks like this patch allows containerd to start "enough" to not block other services in LinuxKit from starting:
diff --git a/services/leases/local.go b/services/leases/local.go
index d3e0c2f2c5..739e58ea9e 100644
--- a/services/leases/local.go
+++ b/services/leases/local.go
@@ -17,9 +17,9 @@
 package leases

 import (
-	"crypto/rand"
 	"encoding/base64"
 	"fmt"
+	"math/rand"
 	"time"

 	"google.golang.org/grpc"

but containerd itself still hangs, presumably due to the other uses of crypto/rand - I'll continue hacking away at this...

The hanging was not expected, the lease generator is intended to be designed that in low entropy situations, the ID generated is just less random rather than blocking or erroring. Looks like we need to re-address this assumption that rand.Read will error and not block when encountering low entropy.

This assumption was based on previous experience here https://github.com/docker/distribution/blob/master/uuid/uuid.go#L56

The hanging was not expected, the lease generator is intended to be designed that in low entropy situations, the ID generated is just less random rather than blocking or erroring.

Yeah, I think a lot of userspace code that makes the non-blocking assumption is going to start hanging in very hard-to-diagnose ways on early-boot when the newer kernel versions become more prevalent 😞.
Would you accept a PR to simply change crypto/rand to math/rand?
The Read method in both packages is effectively the same, just that math/rand will never block or error, but also isn't guaranteed to return cryptographically-unpredictable random data (which I don't see as a requirement for this).

Would you accept a PR to simply change crypto/rand to math/rand?

Yes, I agree cryptographically random is not necessary. We also add a nanosecond component, we could update this in the future to use UUID logic.

We can also just implement a reader with unix.GetRandom(bytes, unix.GRND_NONBLOCK)

@crosbymichael I agree that it'd be useful to have a GRND_NONBLOCK version available (it's already available internally at https://github.com/golang/go/blob/master/src/internal/syscall/unix/getrandom_linux.go#L26..L49).
One thing to watch for is that GRND_NONBLOCK simply changes the behaviour in low-entropy situations from blocking to erroring. So, in this case, containerd would need to handle the error and retry (thus effectively blocking start-up anyway), or fall back to some other behaviour such as using math/rand.
Probably simpler and less surprising to stick to math/rand in all cases, especially since this isn't a situation that calls for cryptographically random IDs.

@hairyhenderson ok, that makes sense.  Thanks!

@hairyhenderson do you wanna work on a PR to update the usage?

#2454 got merged, which is great, and that'll solve the main blocking issue. But there appears to be something else blocking - in my LinuxKit setup I get a shell from getty now, but the containerd logs don't start appearing until crng_init is done.
So I'm going to keep this issue open for now - I want to dig a little deeper and see if there's another blocking getrandom call (maybe in a dependency)... 🕵

We really need to get rid of the docker/docker imports
https://github.com/containerd/containerd/blob/master/vendor/github.com/docker/docker/pkg/stringid/stringid.go#L85
This does raise an important issue which was not part of the PR, random should be seeded, but we should seed it in the binary command and not in the imports.

Yup, that'll do it. 😂

Is there anything else we still need to investigate here or are the 2 PRs already merged sufficient?

👋 @estesp 😁 TBH I'm not sure. I seem to recall that the patched containerd still had some entropy-related hanging. But my memory's fuzzy on exactly what combination of things I tried.
That particular project has been a bit on hold while I've enjoyed some summer vacation, but I'll try to get back to this in the next few days to see if the latest containerd still stalls.


New option: Trucks prefer inner lanes

@Painful Agenda says: "Can you have option for trucks prefer inner lanes as my left hand lanes are my slow lanes do don't have to ban trucks on right hand lane in uk roads."

This feature is implemented - issue can be closed?

Feature available via Policies tab in mod options.


Merge both files

The app.py is used for getting data
The main.py is used for posting on instgram
we need to merge these two files together so that they work and we dont have to run both separately

I request  to assign me the issue to merge app.py and main.py in the repository. Merging these files will streamline data retrieval and Instagram posting, enhancing user experience. I'm eager to contribute and improve the repository's functionality. Thank you for considering my request.


Fix new delete mismatch.

The adapter for Xerces was using new and delete as if they were malloc and free. This resulted in new'ing objects with size N, and delete'ing them with size 1. This PR fixes it by using new uint8_t[size], and delete[];
Fixes #648

@microsoft-github-policy-service agree [company="Microsoft"]


we can add more social link sites many are still left

Description
slack discord and many more
Screenshots
No response
Additional information
No response

i can fix this issue. could you assign me. i am mern stack developer i did create many website please assign me.  i have no any badge.

i can fix this issue. could you assign me. i am mern stack developer i did create many website please assign me.  i have no any badge.

Description
slack discord and many more
Screenshots
No response
Additional information
No response

Can you explain what you mean in more detail. Do you want the icons to be added so that they can be used in the profiles or do you mean something else?

@emmalearnscode I guess she meant to say that we should add the socials link of discord and slack on the site so if it's still not resolved than can I work on it ? @Arushisingh23

discord and slack are already available.

Ooo okay, sorry I forgot to check that


Optimize method for reading the files generated by the Terraform

Fixed https://github.com/eclipse-xpanse/xpanse/issues/2068
Related to https://github.com/eclipse-xpanse/xpanse/pull/2094 and https://github.com/eclipse-xpanse/tofu-maker/pull/79

LGTM

LGTM

LGTM

LGTM


[cPP CHANGE] dates in related docs for consistency

What is the change request for the cPP? Please describe.
https://github.com/appswcpp/repository/blame/3a934bf89774ddf71be37e84ea02647fc7fe85c4/cPP/cPP_APP_SW.adoc#L61-L62
These lines only show version numbers but no the dates of publication. For consistency with the other documents listed here dates should probably be added.
Describe the solution you'd like
Add the appropriate dates

Change Implemented.


Kari edit - sensitive-friendly

Removed words that could be interpreted as insensitive or of questionable judgement, taking into consideration the combining of terms. Stopped at 7-character words (8+ not edited). Removed references to race and nationality, insults, slang, names, anything body-related, medical terms, classism, and gender-specific terms.

whoops, I meant to PR this to highb's fork.


IDEA-PhpStorm version bump

Please squash the commits and change the sha to base32.

Is it ok now?
How do i conveniently generate base32 encoded sha256 sum for a file?

@shdpl nix-hash --flat --type sha256 --base32 foo


python310Packages.pathos: 0.2.5 -> 0.2.8

Description of changes
https://github.com/uqfoundation/pathos/releases/tag/pathos-0.2.8

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 173764 run on x86_64-linux 1

2 packages failed to build:

python310Packages.sagemaker
python39Packages.sagemaker

6 packages built:

python310Packages.pathos
python310Packages.pox
python310Packages.ppft
python39Packages.pathos
python39Packages.pox
python39Packages.ppft

sagemaker failure is addressed by #173767.

@ofborg eval


Namer function is not supported by ConcurrentRotatingFileHandler

In accordance with this docs:
https://python.readthedocs.io/en/stable/library/logging.handlers.html#baserotatinghandler
Standart RotatingHandlers supports usage of custom namer function, to configure file name for rollover process.
could you please implement this logic for ConcurrentRotatingFileHandler?

I agree it makes sense to add that here. I'll look into it when I get a chance. Would be happy to review a PR too.

why I can't create a fork?

#54

Accepted; thanks!


homeassistant.components.sensor

Logger: homeassistant.components.sensor
Bron: components/sensor/init.py:570
integratie: Sensor (documentatie, problemen)
Eerst voorgekomen: 20:24:56 (16 gebeurtenissen)
Laatst gelogd: 20:24:56
Entity sensor.epex_highest_energy_price_today (<class 'custom_components.entsoe.sensor.EntsoeSensor'>) is using state class 'measurement' which is impossible considering device class ('monetary') it is using; expected None or one of 'total'; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/JaccoR/hass-entso-e/issues
Entity sensor.epex_average_electricity_price_today (<class 'custom_components.entsoe.sensor.EntsoeSensor'>) is using state class 'measurement' which is impossible considering device class ('monetary') it is using; expected None or one of 'total'; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/JaccoR/hass-entso-e/issues
Entity sensor.epex_current_percentage_of_highest_electricity_price_today (<class 'custom_components.entsoe.sensor.EntsoeSensor'>) is using state class 'measurement' which is impossible considering device class ('monetary') it is using; expected None or one of 'total'; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/JaccoR/hass-entso-e/issues
Entity sensor.epex_time_of_highest_price_today (<class 'custom_components.entsoe.sensor.EntsoeSensor'>) is using state class 'measurement' which is impossible considering device class ('timestamp') it is using; expected None; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/JaccoR/hass-entso-e/issues
Entity sensor.epex_time_of_lowest_price_today (<class 'custom_components.entsoe.sensor.EntsoeSensor'>) is using state class 'measurement' which is impossible considering device class ('timestamp') it is using; expected None; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/JaccoR/hass-entso-e/issues

Also saw this in the log today after restarting HA.
Logger: homeassistant.components.sensor
Source: components/sensor/__init__.py:575
integration: Sensor (documentation, issues)
First occurred: 10:40:18 (8 occurrences)
Last logged: 10:40:18

Entity sensor.highest_energy_price_today (<class 'custom_components.entsoe.sensor.EntsoeSensor'>) is using state class 'measurement' which is impossible considering device class ('monetary') it is using; expected None or one of 'total'; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/JaccoR/hass-entso-e/issues
Entity sensor.average_electricity_price_today (<class 'custom_components.entsoe.sensor.EntsoeSensor'>) is using state class 'measurement' which is impossible considering device class ('monetary') it is using; expected None or one of 'total'; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/JaccoR/hass-entso-e/issues
Entity sensor.current_percentage_of_highest_electricity_price_today (<class 'custom_components.entsoe.sensor.EntsoeSensor'>) is using state class 'measurement' which is impossible considering device class ('monetary') it is using; expected None or one of 'total'; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/JaccoR/hass-entso-e/issues
Entity sensor.time_of_highest_price_today (<class 'custom_components.entsoe.sensor.EntsoeSensor'>) is using state class 'measurement' which is impossible considering device class ('timestamp') it is using; expected None; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/JaccoR/hass-entso-e/issues
Entity sensor.time_of_lowest_price_today (<class 'custom_components.entsoe.sensor.EntsoeSensor'>) is using state class 'measurement' which is impossible considering device class ('timestamp') it is using; expected None; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/JaccoR/hass-entso-e/issues

v0.4.0 is released this version contains fixes that solve a lot of warnings and known issues. This issue is probably also solved.
Please update to the latest version.
Closing this issue for now. If you still have issue please feel free to open a new issue.


Opt-in / opt-out URLs scan with Spawning

Scan the datasets for URLs and get the number of opt-in / opt-out URLs from artists from Spawning.
Right now it's limited to the first 100K rows (runs in a few seconds) but we can have subsequent jobs to run it on the full datasets.
The rows are obtained from streaming in order to support LAION-2B - but later we could just do it on the parquet exports

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.07 :tada:

Comparison is base (768b9aa) 87.91% compared to head (e0e1ee4) 87.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
+ Coverage   87.91%   87.99%   +0.07%
==========================================
  Files          79       99      +20
  Lines        3518     4230     +712
==========================================
+ Hits         3093     3722     +629
- Misses        425      508      +83

Flag
Coverage Δ

jobs_cache_maintenance
98.13% <ø> (ø)

jobs_mongodb_migration
80.84% <ø> (ø)

libs_libcommon
93.36% <100.00%> (+<0.01%)
:arrow_up:

services_admin
88.30% <ø> (?)

services_api
84.71% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

libs/libcommon/src/libcommon/config.py
76.11% <ø> (ø)

libs/libcommon/tests/test_processing_steps.py
100.00% <ø> (ø)

services/api/src/api/config.py
100.00% <ø> (ø)

libs/libcommon/src/libcommon/constants.py
100.00% <100.00%> (ø)

services/api/tests/routes/test_endpoint.py
100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Or make it a secret

yes

added the OPT_IN_OUT_URLS_SCAN_SPAWNING_TOKEN secret


Search page components are not centered

Might be additional padding / margin that's being added preventing it from aligning; tabling for now

Resolved


Reconciliation Proposal

Describe what this PR does and why we need it:
Add spec-reconciliation.md

@djzager both the approaches have pros and cons which approach do you think I should pick to refine?
And yes, I started looking into the service catalog reconciliation but the biggest difference in their environment is, they are getting all the changes as a callback. So, I stopped looking, thinking their approach would not be applicable in our environment as we use polling to sync the specs.

So I had a private conversation with Alay earlier today, and another one with Erik & Shawn. Figured I'll post my comments here:

not a huge reason, if reaper was preferred by majority, I'd be okay with it. I just wouldn't do that if I was implementing this.

a reaper will have to be yet another "goroutine" running that interacts with a bootstrap "goroutine" and each provision/deprovision, etc is another set of "goroutines".

I don't think deprovision should ever delete a spec. If something is marked for deletion and a deprovision comes in, the spec should remain marked for deletion until the bootstrap reruns. Basically my in place bootstrap loop is basically a reaper process as well. So when the bootstrap runs again, first thing it should do is remove the specs that were marked for deletion and no longer provisioned.

and I don't think provision or deprovision should ever have to have logic about a marked for deletion spec. When they ask for a spec the method should filter it for them.

though I might be glossing over some details, I'd have to look at the code again to see how we get them for provision, deprovision. /me assumes it's just a getSpec or something like that

    if spec, err = a.dao.GetSpec(specID); err != nil {

I met with @eriknelson  & @alaypatel07  to discuss the bootstrap. The main issue is deleting ALL specs causes many bugs, primarily in the cases where they are going to be added again.
Each of the 3 bugs identified in the proposal was case where we deleted the specs, before we were able to process the specs from the registry. Either, we didn't add the spec yet or there was an error
reaching the registry. Both scenarios exhibited the same behavior because our process was to delete ALL specs first.
Given the above, we came to the conclusion that the simplest solution to this problem is to simply not delete all of the specs, but to process them inline. Basically back to approach #1 as outlined by:
https://github.com/openshift/ansible-service-broker/pull/997#discussion_r198575908

Fetch the specs from a registry
Fetch the specs from the datastore
Delete any specs in the datastore currently marked for deletion, assuming there is no instance that has a reference to this spec which is marked for deletion.
i. if there is a reference, leave the spec alone
ii. if there is no reference, delete the spec
For each spec from the registry, get the spec from the datastore
i. if found, update it, and save to datastore
ii. if not found, add it to the datastore
For each spec in the datastore, NOT in registry list, mark it for deletion.

This removes all of the concurrency issues we were trying to "solve" in all of the calls. It's easy to understand. Because we will be doing the handling of the delete (#3 above) in-place this will cause the
bootstrap to take longer.
We can make the bootstrap endpoint async so that it won't be affected by how long the bootstrap takes to reconcile. The topic of adding a last_operation like endpoint for bootstrap came up, but for now, we are forgoing that portion of the solution. The last_operation is only of interest to clients that interact with the broker directly, for instance, sbcli. We can implement the same polling mechanism that the catalog uses for the standard OSB methods.
The above will fix the original bugs we outlined, without too much intrusion. We didn't go too deep into backwards compatibility with existing clients, which seems to only affect apb tool. Apb tool is being replaced by sbcli anyway.
The plan is as follows:

send out this email
add the above solution as a comment to the proposal PR
close proposal PR
create trello card with above steps
@alaypatel07  will implement the solution from the trello card

If anyone has any strong objections please speak up now.


Remove Light Theme experiment, enable it for everyone + final touches

Task/Issue URL: https://app.asana.com/0/856498667320406/943952882631812
Tech Design URL: N/A
Description:
We are removing the experiment and enabling theme switching for everyone, with Dark Theme as a default.
Steps to test this PR:

App Upgrade (no settings change):

Install develop version of the App, with 'mh' experiment running (default light theme).
Now install this branch over the top.
Ensure light theme selection was maintained.

App Upgrade (with settings change):

Install develop version of the App, with 'mj' experiment running (default dark theme).
In settings, enable the light theme.
Now install this branch over the top.
Ensure light theme selection was maintained.

New installation

Install a fresh version of the app from this branch.
Ensure that the dark theme is the default.
Ensure the theme can be changed in the settings.

Internal references:
Software Engineering Expectations
Technical Design Template

@brindy Thanks for the feedback, I completely missed that. Fix is in my latest commit.


Changes: Use same @ symbol everywhere.

Updated the 'zulip-icon-at-sign' @ icon everywhere.
I made the use of "".
Below areas needed the changes:
-mention pills
-/#settings/notifications
-user popovers 'copy ention syntax'
-unread mention indicator
Below area did not needed changes:
-left sidebar mention view
Fixes : #22816

Screenshots:
1. Unread mention indicator : chnaged

2. left sidebar mention view: not changed

*3.mention pills:mention pills

4. /#settings/notifications

5. user popovers 'copy ention syntax'

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@amanagr , @alya , kindly review the PR. The issue was left unsolved for a very long time, I hope the PR may help closing it.

Thanks for working on this! Please fix the failing tests and post a comment requesting a review.

Also, can you explain what this means?

I made the use of "".

There's a typo in your commit message.

Also, can you explain what this means?

I made the use of "".

Sorry @alya , I didn't check the preview after writing the html element in quotes "". Now I have edited the main description, you can see it again.

Hey @alya, I all the tests have passed. Please review the PR as tell what else is left for me to do:)

@amanagr Can you please review this one?

@AMANVISHWAKARMA27 thanks for working on this. Can you create a separate commit for each UI element you change here since they need to individually tested for any bugs before this merged. Thanks!

Sure @amanagr . Will do asap.

Hey @amanagr , the changes for mention pills and unread mention indicator are related to each other, can I put them together in a single commit.

Hey @amanagr , I have divided the changes into separate commits as per your instruction.
Related changes are kept in the same commit.
For unrelated changes, there is a separate commit.
@ before 'Mention' in the sidebar needed no change, hence no commit.

Hey @amanagr , Initially it passed all checks but lates when I force pushed the changes again, it showed puppeteer test failure. How can I solve the issue.

Hey @amanagr , the PR is ready for your next review. Kindly review it.

@AMANVISHWAKARMA27 this is great! Can you talk about the different font sizes you used for the icons? Also, please fix punctuation in the commit messages.
Note that we are still using @ character in the user mention pills which I think is fine to do in another PR, otherwise copy paste for that text will be broken.

Also, can you specifically mention which punctuations you are talking about and how they should be?

Hey @amanagr , as per your instructions I have added the font-size for the icon used at different places in the commit messages. You may check them.
Can you please describe what punctuation issues are there in the commit?

Hey @amanagr , please review the changes.

@AMANVISHWAKARMA27 can you open a PR which just makes this change in one PR part of the UI? That way it will be easier to test and merge changes. We can start with settings.

@amanagr , basically I have to make a new PR for each and every commit, am I right?

No just make a PR which adds this icon in the settings with a before and after screenshot.

@amanagr , Please review the PR.

Hey @amanagr , can you please review the PR.

hey @amanagr , can you please review the PR.

@AMANVISHWAKARMA27 can you open a PR which just makes this change in one PR part of the UI? That way it will be easier to test and merge changes. We can start with settings.

Should I make a separate PRs for the remaining two commits?


Remove local and cluster commands and remove cluster API endpoint and clusterInfo

deprecate local and cluster commands was planned for 1.9: https://github.com/prismagraphql/prisma/releases/tag/1.7.0
deprecate /cluster endpoint and clusterInfo was planned for 1.10: https://github.com/prismagraphql/prisma/releases/tag/1.8.0

For
prisma local start
prisma local stop
prisma local upgrade
prisma local nuke
prisma local ps
prisma local
Error message => As mentioned in prisma 1.7 release notes this command was deprecated and is now removed. You can use docker-compose directly to manage the state of local server.
For
prisma cluster list
prisma cluster add
prisma cluster remove
prisma cluster logs
prisma cluster
Error message => As mentioned in prisma 1.7 release notes this command was deprecated and is now removed.
Looks good? For cluster command(s), the release notes mention that cloud can be used to manage the servers but that is not completely correct yet, hence, I did not add that to the error message.

prisma cluster has this output:


ladybird: 0-unstable-2024-11-21 -> 0-unstable-2024-12-23

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

builds but crashes for me shortly after opening on x86_64-linux

Are you on NixOS? Did you enable the ladybird option?

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367747

x86_64-linux

:white_check_mark: 1 package built:

ladybird

Runs as expected (with it enabled \o/)!


#[cfg(..)] gated impl parameters with lifetimes cause inconsistent lifetime bounds

Heya, I came across the following compilation error:
Scenario
#[async_trait]
pub trait Trait {
    async fn cfg_param(&self, param: &u8);
    //       ---------------------------- lifetimes in impl do not match this method in trait
}

struct Struct;

#[async_trait]
impl Trait for Struct {
    async fn cfg_param(&self, #[cfg(any())] param: &u8, #[cfg(all())] _unused: &u8) {}
    //       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lifetimes do not match method in trait
}

This is similar to #226, but in this case the parameters have lifetimes.
The expanded code shows what's happening:
pub trait Trait {
    fn cfg_param<'life0, 'life1, 'async_trait>(
        &'life0 self,
        param: &'life1 u8,
    ) -> ::core::pin::Pin<Box<dyn ::core::future::Future<Output = ()> + ::core::marker::Send + 'async_trait>>
    where
        'life0: 'async_trait,
        'life1: 'async_trait,
        Self: 'async_trait;
}

struct Struct;
impl Trait for Struct {
    fn cfg_param<'life0, 'life1, 'life2, 'async_trait>(   // <-- all `'lifeN` parameters are present
        &'life0 self,
        #[cfg(all())]
        _unused: &'life2 u8,
    ) -> ::core::pin::Pin<Box<dyn ::core::future::Future<Output = ()> + ::core::marker::Send + 'async_trait>>
    where
        'life0: 'async_trait,
        'life1: 'async_trait,  // <-- all `'lifeN` parameters are present
        'life2: 'async_trait,
        Self: 'async_trait,
    {
        Box::pin(async move {
            let __self = self;
            let _: () = {};
        })
    }
}

Options
(that I can think of)

It's not possible to have attributes in type parameter position, so we can't just copy the #[cfg] attributes per lifetime.
Dynamically working out which parameters are part of the same lifetime group is not necessarily easy (e.g. if someone has multiple #[cfg(..)] combinations which don't have the same #[cfg(feature_a)], #[cfg(not(feature_a))] pattern).
Adding a custom #[async_trait(same_lifetime_group)] attribute per parameter detracts from the usability.
Generating a different combination of the impl per combination of #[cfg] is possible, but is it worth the complexity?
Not supported by async-trait, but users can create a separate function with the same signature, and in the trait impl they call the separate function.

The last option is:
#[async_trait]
impl Trait for Struct {
    async fn cfg_param(&self, param: &u8) {
        self.cfg_param_inherent(param).await
    }
}

impl Struct {
    async fn cfg_param_inherent(&self, #[cfg(any())] param: &u8, #[cfg(all())] _unused: &u8) {}
}

// or even simpler, consumers *could* do:
impl Trait for Struct {
    async fn cfg_param(&self, param: &u8) {
        #[cfg(all())]
        let _unused = param;
        // ..
    }
}

Do you think async-trait should support this case? It may not be worth supporting, since option 4 is hard to get right, and may be hard to maintain in the long run / have good diagnostics for.

I would prefer to go with option 5. I think this is not worth supporting in async-trait.
Thanks for the clear writeup.


Something Went wrong or pi not available .

every thing is working but app and web dashboard says Something Went wrong or pi not available . it is receiving disk , ram and cpu usage properly .

Hi, unfortunately this was just a place where I have put some code for an article and I can't give support for any issue that happens with this codebase.
Sorry about that.


Analogue of this colors from imgui 1.51 in 1.89.1?

ImGuiCol.ComboBg ImGuiCol.PopupBg
ImGuiCol.CloseButton
ImGuiCol.CloseButtonHovered
ImGuiCol.CloseButtonActive

I can't do much to change how this behaves since this is just a thin wrapper over the native library. I'd suggest you write some small helper functions that push/pop the regular button colors for your specific use case. It won't be quite as easy as setting the colors once, but I believe it should work fine.


Exclude node contracts which have rent contract from billing

Seems like this path was not there.

added in https://github.com/threefoldtech/tfchain/commit/f43002cc046c833f2591376056961b1f589875ca


binomial coefficient calculator

Description 📜
This calculator is used for the calculation of binomial coefficient by taking the value of n and k from the user
Fixes #296

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GSSOC'22 contributor
[x] Have you added a working video of your calculator ?

Screenshots / Gif (Optional) 📸

/assign

@vasu-1 please add the level tag so that i can get the points

Please merge my PR i have done all the Changes


Hiding the error overlay frame in dev mode.

Hiding the error overlay frame in dev mode.
🗣 Description
Using css to remove the error overlay in dev mode. The error overlay window/frame was introduced in react-scripts v5 (as a result of upgrade due to vulnerabilities).
While using react-script there is no way to override the behavior.
There are some methods to avoid this but they are more involved. (see https://marmelab.com/blog/2021/07/22/cra-webpack-no-eject.html)
The solution implemented is described here:
https://stackoverflow.com/questions/46589819/disable-error-overlay-in-development-mode
💭 Motivation and context
The change is required to avoid unnecessary clicks during development work.
🧪 Testing
A standard user was created and used to log-in. Observe: the overlay error doesn't happen anymore.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

This looks fine, but question, why did we want to hide the error overlay frame in the first place?

If this needs to be removed because it is preventing desired error overlays or error message notifications to users than this should be rolled back or another ticket filed to remove the change.


[BUG] Files detected as changed that are not part of PR

Is there an existing issue for this?

[X] I have searched the existing issues

Does this issue exist in the latest version?

[X] I'm using the latest release

Describe the bug?
The tj-actions/changed-files action occasionally reports that files have changed and triggers specific jobs that would otherwise be skipped in our workflow on pull requests.
To Reproduce
We have a workflow defined like the following:
jobs:
  file_changes:
    name: "Detect changes"
    outputs:
      common-changed: ${{ steps.changed-files-common.outputs.any_changed }}
      path-abc-changed: ${{ steps.changed-files-path-abc.outputs.any_changed }}
      path-xyz-changed: ${{ steps.changed-files.path-xyz.outputs.any_changed }}
    steps:
      - name: Checkout Action
        uses: actions/checkout@v2
        with:
          fetch-depth: 0
      - name: Get modified files (common)
        id: changed-files-common
        uses<EMAIL_ADDRESS>        with:
          files: |
            .github/workflows/common-workflow.yml
      - name: Get modified files (path-abc)
        id: changed-files-path-abc
        uses<EMAIL_ADDRESS>        with:
          files: |
            path-abc/**
  path_abc:
  needs: [file_changes]
  if: ${{ needs.file_changes.outputs.common-changed == 'true' || needs.file_changes.outputs.path-abc-changed == 'true' }}
  ...
  path_xyz:
  needs: [file_changes]
  if: ${{ needs.file_changes.outputs.common-changed == 'true' || needs.file_changes.outputs.path-xyz-changed == 'true' }}
  ...

User ABC submits PR 1234 that changes common-workflow.yml.
User XYZ submits PR 2345 that changes files within the path-abc/** file path only.
PR 1234 gets merged to main by a maintainer
User XYZ pushes a new commit to PR 2345 that changes only files within the path-abc/** file path.

During the execution of the workflow in Step 2, everything works as we expect.  It's during the execution of Step 4 after the PR that changes the workflow has been merged to main is when we observe this obscure execution of both the path_abc and path_xyz.
What OS are you seeing the problem on?
ubuntu-latest or ubuntu-20.04
Expected behavior?
Step 4 should only run the job for path_abc and not for path_xyz.
Relevant log output
  Added files:
  Copied files:
  Deleted files:
  Modified files: .github/workflows/common-workflow.yml
  Renamed files:
  Type Changed files:
  Unmerged files:
  Unknown files:
  All changed and modified files: .github/workflows/common-workflow.yml
  All changed files: .github/workflows/common-workflow.yml
  All modified files: .github/workflows/common-workflow.yml

Anything else?
Could this be related to the any_changed output versus a different output variable we should use for this use case?
The goal that we are trying to mimic here is the equivalent of GitHub Action's paths syntax but rather than the workflow being conditionalized on the path changes, specific jobs within the workflow are to give us the best precision on running very long tests only on the most applicable modules based on the changes in the pull request or push.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Naros I'll recommend upgrading to the latest version v14.3.

Closing this issue for now you can reopen or create a new issue if the problem persists

Hi @jackton1, from what I could tell after upgrading to 14.3, that solved the matching problem :clap:


fix(e2e): Use X.Y channels for OLM upgrade e2e tests

This fixes OLM upgrade e2e tests on previous release branches, by using the corresponding X.Y channels.
Release Note
fix(e2e): Use X.Y channels for OLM upgrade e2e tests

This requires #2902.


Update to Voyager rc06

Due to some changes in the Navigator function signature, the current version of kotlin-routing does not work with the latest version of Voyager. A simple update to the dependencies would allow kotlin-routing to be used with the latest Voyager.

With kotlin-routing published to maven central I am thinking to migrate voyager modules to voygar repo and avoid breaking changes between their.

Closing issue because PR was opened


Add twitter api error codes

There are plenty of Twitter APIs :

The REST APIs provide programmatic access to read and write Twitter data. Author a new Tweet, read author profile and follower data, and more.

If your intention is to monitor or process Tweets in real-time, consider using the Streaming API instead.

Ads API

Which one should I do ? Currently starting with the first one

OK, i agree


Inference speed [-Ofast]

In the spirit of the project adding additional compilation flags seems complicating things, however, -Ofast compilation flag seems easy to apply. Ofast is O3 + fast-math and some other optimizations (https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html).
It almost 2x the inference speed so it might be worth considering.
The results with O3 and Ofast are the same, though fast-math doesn't guarantee that.
  - O3:    160t/s
  - Ofast: 307t/s

Wow, this works too. And it stacks with -O3 and -funsafe-math-optimizations.
I'm not as familiar with all of these flags, are they all present for all versions of gcc on all platforms? Are they "safe"?
Amazing.

Yeah, the Ofast is pretty standard (supported by clang and gcc for a long time).
Since Ofast is adding -fast-math that's not 100% safe as it disregard strict standards compliance, though the output for the run is the same (with O3 and Ofast), so it's pretty safe in that regards.
BTW also clang produces a bit faster inference too
clang -Ofast run.c -o run
clang-15 Ofast: 321t/s
gcc-12 0fast: 307t/s

It's likely that he 90% of performance is in matmul when multplying weights. One easy and portable way to tackle that without loosing much simplicity and/or portability would be to use Vector extensions (https://gcc.gnu.org/onlinedocs/gcc/Vector-Extensions.html).
That would allow to use SIMD in a portable way with minimal changes.
typedef double v4df __attribute__ ((vector_size (32)));

and then arithmetic operations would operate on N elements in parallel.
Additional option (less portable though) would be to use openmp for parallelism
void matmul(float* xout, float* x, float* w, int n, int d) {
    #pragma omp parallel for
    for (int i = 0; i < d; i++) {
        float val = 0.0f;
        for (int j = 0; j < n; j++) {
            val += w[i * n + j] * x[j];
        }
        xout[i] = val;
    }
}

but that would require openmp and compiling with -fopenmp but it would be quite portable and it's 1 line change.

I appreciate the writeup, thank you! I will take a look. I'm in favor of adding anything that will keep most of the simplicity and portability.

I wrote a small script to compile the program with different flags,
import hashlib
import os

flag_sets = [
    "",
    "-O3",
    "-O3 -mtune=native -march=native",
    "-Ofast -mtune=native -march=native",
    "-Ofast -funsafe-math-optimizations -ffast-math -mtune=native -march=native",
    "-Ofast -funsafe-math-optimizations -ffast-math -fopenmp -mtune=native -march=native",
]

for flag_set in flag_sets:
    exec_name = f"out-{hashlib.sha256(flag_set.encode()).hexdigest()[:8]}"
    compiler = "/opt/homebrew/opt/llvm/bin/clang" if "openmp" in flag_set else "clang"
    command = f"{compiler} {flag_set} -o {exec_name} run.c"
    print(command, end=": ", flush=True)
    os.system(command)
    os.system(f"./{exec_name} out/model.bin | grep ^achieved")

and on my M2 Max laptop the results are pretty impressive (though I'm not sure why the OpenMP version ends up being comparatively so slow).
clang  -o out-e3b0c442 run.c: achieved tok/s: 19.673734
clang -O3 -o out-ab3e680b run.c: achieved tok/s: 127.886245
clang -O3 -mtune=native -march=native -o out-46e214a9 run.c: achieved tok/s: 128.765640
clang -Ofast -mtune=native -march=native -o out-ae7e7e2b run.c: achieved tok/s: 677.293472
clang -Ofast -funsafe-math-optimizations -ffast-math -mtune=native -march=native -o out-380cc2e2 run.c: achieved tok/s: 673.834937
/opt/homebrew/opt/llvm/bin/clang -Ofast -funsafe-math-optimizations -ffast-math -fopenmp -mtune=native -march=native -o out-ca4e3427 run.c: achieved tok/s: 96.132073

Oh, it's because of the clock() is measuring the CPU time. After changing it to gettimeofday the results are much better with openmp.
clang -Ofast -march=native  run.c  -lm  -o run // achieved tok/s: 340.878828

clang -Ofast -fopenmp -march=native  run.c  -lm  -o run // achieved tok/s: 524.590164

BTW.  ofast implies fast-math and fast-math implies -funsafe-math-optimizations So Ofast + march=native is already the best combination.

Added https://github.com/karpathy/llama2.c/pull/27 for reference :point_up:
More experiments can be done with the number of threads, scheduler, etc. - https://www.openmp.org/spec-html/5.0/openmpch6.html#x287-20510006

It seems that at least on my intel cpu 4 threads seems to be the sweet spot
OMP_NUM_THREADS=4 ./run out/model.bin // achieved tok/s: 622.871046
that can be also defaulted in the code by
#pragma omp parallel for num_threads(4)

but that's probably is coupling too much and complicates the things a bit more.

Actually, with mmap enabled (https://github.com/karpathy/llama2.c/pull/30) and gcc (not clang) the performance looks even better (it seems backend bound). It's still without vectorizing matmul.
OMP_NUM_THREADS=4 ./run out/model.bin

achieved tok/s: 805.031447

perf stat
 Performance counter stats for './run out/model.bin':

          1,313.02 msec task-clock                       #    3.949 CPUs utilized
                 7      context-switches                 #    5.331 /sec
                 3      cpu-migrations                   #    2.285 /sec
             2,253      page-faults                      #    1.716 K/sec
     5,458,396,894      cpu_core/cycles/                 #    4.157 G/sec
     <not counted>      cpu_atom/cycles/                                                        (0.00%)
     8,039,822,904      cpu_core/instructions/           #    6.123 G/sec
     <not counted>      cpu_atom/instructions/                                                  (0.00%)
     1,144,340,855      cpu_core/branches/               #  871.533 M/sec
     <not counted>      cpu_atom/branches/                                                      (0.00%)
           567,726      cpu_core/branch-misses/          #  432.382 K/sec
     <not counted>      cpu_atom/branch-misses/                                                 (0.00%)
    32,361,450,930      cpu_core/slots/                  #   24.647 G/sec
     7,061,847,839      cpu_core/topdown-retiring/       #     21.8% Retiring
        31,373,084      cpu_core/topdown-bad-spec/       #      0.1% Bad Speculation
     1,142,374,971      cpu_core/topdown-fe-bound/       #      3.5% Frontend Bound
    24,158,077,283      cpu_core/topdown-be-bound/       #     74.6% Backend Bound
       158,143,683      cpu_core/topdown-heavy-ops/      #      0.5% Heavy Operations          #     21.3% Light Operations
        31,338,821      cpu_core/topdown-br-mispredict/  #      0.1% Branch Mispredict         #      0.0% Machine Clears
       189,379,719      cpu_core/topdown-fetch-lat/      #      0.6% Fetch Latency             #      2.9% Fetch Bandwidth
    12,049,852,779      cpu_core/topdown-mem-bound/      #     37.2% Memory Bound              #     37.4% Core Bound

With OMP and mmap enabled (https://github.com/karpathy/llama2.c/pull/30), I'm consistently achieving >2600 tokens/s on my Ryzen 7950x.
$ gcc -Ofast -fopenmp -mtune=native -march=native run.c -lm -o run
$ OMP_NUM_THREADS=16 ./run out/model.bin 0.9 0 | grep "^achieved"
achieved tok/s: 2694.736842

Another optimization would be to replace exp() in softmax() with expf(). This avoids the conversion to double, but may alter the result slightly. However, it provides another big speedup of ~700 tokens/s.
$ OMP_NUM_THREADS=16 ./run out/model.bin 0.9 0 | grep "^achieved"
achieved tok/s: 3324.675325

Ok wow, go OMP! :) I'll merge the PR @krzysztof-jusiak  . Every day I speed up the code too much and have to train a bigger model. I published the 44M model yesterday, but even that one is too slow. So I'm now training a GPT-1 sized model (768 dim 12 layer 12 head 1024 context) 110M params, which will be done training somewhere later today.

@tringwald that's blazing fast in comparison to i7-12650H, is that because of Ryzen's 7950x avx512 support?
Looking at matmul (https://godbolt.org/z/qndT8Eb1b) the generated code is definitely far from optimal but it's vectorized at least. Improving matmul would defo accelerate the inference but it's hard to do it without adding additional complexity, using external libraries  and/or using computation graph so there are trade offs here.

@krzysztof-jusiak Well, the comparison is not really fair. The i7-12650H is a mobile segment CPU (with only 6 p-cores) vs. a high-end desktop Ryzen 7950x (with 16 full cores). I also assume my overclocked DDR5 RAM helps quite a lot ;)
The biggest speedup would probably be CUDA, but that's out of scope for this project, I guess.

Thank you @tringwald, makes sense :+1: Also totally agree that gpu would be the fastest option, but that would require quantization or something for bigger models to fit in the memory which is most likely out of scope for this project but cpu only based inference (float16) still can handle 7B with reasonable speed without quantization.

Looking at matmul (https://godbolt.org/z/qndT8Eb1b) the generated code is definitely far from optimal but it's vectorized at least. Improving matmul would defo accelerate the inference but it's hard to do it without adding additional complexity, using external libraries and/or using computation graph so there are trade offs here.

Clang vectorizes and unrolls the inner reduction loop in matmul very well just with -Ofast. GCC codegen with __attribute__((optimize("unroll-loops"))) is not that good, but also does the job in the basic block at 76-95.


Unify top-API Styling

Testing selectors and the reducers requires a stateless, static-form API (e.g. Redcuer(uut).doThisAndThat()), while for testing actions, a local instance should be created and reset in each test cycle (i.e. const actionTest = new ActionTest();, actionTest.dispatchSync(someAction), actionTest.reset()).
Users who learn how to use one sub-framework expect the others to work pretty much the same way. As long as that's not the case, the API might seem confusing to some.
I vote for unifying the API style to the latter ("worst-case") form.

Moved all API style discussion to #4


route-graph: 0.1.0 -> 0.2.0

Diff: https://github.com/audiusGmbH/route-graph/compare/refs/tags/0.1.0...0.2.0
Changelog: https://github.com/audiusGmbH/route-graph/releases/tag/0.2.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 295656 run on x86_64-linux 1

2 packages built:

route-graph
route-graph.dist


Update Ubuntu dependencies to include libblocksruntime-dev.

Some of the tests link against libBlocksRuntime so it appears to
be a requirement. With this package installed the tests pass for
me (Ubuntu 18.04 LTS on x86_64).
This StackOverflow link shows the same issue on Ubuntu 14.04:
https://stackoverflow.com/questions/36479498/is-llvm-compiler-rt-installed-on-my-ubuntu-14-04

@swift-ci Please smoke test.

The tests create a stub blocks runtime for the tests.  We also have BlocksRuntime that we build and run against in lib dispatch.  I don't think that this is the right thing to do.

Is this a bug then? Because we definitely do link against the system libBlocksRuntime currently, and if it is not installed then the tests fail on Ubuntu (@ version 18.04 at least). Who would know?

Yes, that is a bug.  We should be linking against the blocks runtime that we "import" from lib dispatch (https://github.com/apple/swift/blob/master/CMakeLists.txt#L1036-L1044).  I probably would, since I set this up quite a while ago.

Oh, I bet, I know what it is - a missing -rpath in the test binaries which does not setup the library search path to the libdispatch, since CMake will setup the paths appropriately for linking via absolute paths given that it is a proper target (even though it is imported).


405 (Method Not Allowed) Laravel 5.6

Laravel 5.6
PHP 7.1.5
Angular 1.4.0
Angular-resource  1.4.0
Angular-route 1.4.0
laravel-cors 0.11.0
config/cors.php:
return [

'supportsCredentials' => false,
'allowedOrigins' => ['*'],
'allowedOriginsPatterns' => [],
'allowedHeaders' => ['*'],
'allowedMethods' => ['*'],
'exposedHeaders' => [],
'maxAge' => 0,
 ];

Frontend: (I use anguarJS $resource to send my http requests)
services.js:
this.patientRes = function () {
            return $resource(baseURL + 'patients/:id', {id: "@id"}, {
                get: {
                    method: 'GET',
                    isArray: true,
                    headers: {'Content-Type': 'application/json'}
                },
                update: {
                    method: 'PUT',
                    headers: {'Content-Type': 'application/json'}
                },
                delete: {
                    method: 'DELETE',
                    headers: {'Content-Type': 'application/json'}
                }
            })
        };

Error:  (I get this error for PUT and DELETE requests - POST and GET are OK)

405 (Method Not Allowed)
data
:
{message: "", exception: "Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException", file: "/home/MywebsiteAddress/domains/MywebsiteAddress/Cors2/vendor/larave…mework/src/Illuminate/Routing/RouteCollection.php", line: 255, trace: Array(29)}

I'm closing this due to inactivity. If this issue is still relevant on the latest version (2.0.1 at the moment), please open a new issue with detailed information.


Initial implementation of a PoseTraining Group

Description
Add PoseTraining group to store annotations for training a pose estimator.
Related Issues

#8

These changes look good to me, and I support @CBroz1 's changes. It would be good to get feedback from @bendichter and @AlexEMG on these changes before we proceed.

Hi @roomrys, Hi @rly - I'd like to get this merged to use with out NWB export. Should I open a separate PR to reflect the changes we discuss here?

Hi @rly,
I believe all is ready! Please let me know if there is anything else that needs work.

Hey friends, where do we stand with this PR these days @rly @bendichter?

Hi @talmo . Sorry for the extreme delay on wrapping up this PR... I will finalize this during the developer hackathon next week.

Let us know if there's anything we can help with! This is a key piece of functionality for us to be able to convert our hand labeled data for archival :)

@roomrys Could you please enable edits to this PR / branch from maintainers? There should be a checkbox on the right side. I would like to give you credit for this PR if possible.

Sorry @rly, it seems that is impossible at the moment https://github.com/orgs/community/discussions/5634

@rly what if you send a PR with your changes to talmolab:main, we merge it there, and then it updates here?
Or we could follow the above thread's response:

HELP! Please fix this, or we shall move to svn 🥲

😂😂

Or maybe add @roomrys as a maintainer to the repo? Or @roomrys add @rly as a maintainer to our fork so the checkbox works?

Sounds good. Will do.

@rly what if you send a PR with your changes to talmolab:main, we merge it there, and then it updates here?
Or we could follow the above thread's response:

HELP! Please fix this, or we shall move to svn 🥲

😂😂

Or maybe add @roomrys as a maintainer to the repo? Or @roomrys add @rly as a maintainer to our fork so the checkbox works?

I'll add @roomrys to the repo in case that helps but I think adding me to the fork would work.

Sounds good. Will do.

@rly what if you send a PR with your changes to talmolab:main, we merge it there, and then it updates here?

It turns out that GitHub does not allow me to fork a fork of my repo.

I will just merge this and make changes in a new PR.


Add default network policy to allow communication between elasticsearch-operator and ns openshift-logging

Context
When installing elasticsearch-operator in the official namespace openshift-operators-redhat, Elasticsearch is not accessible. There are default network policies allow-from-other-namespaces and allow-from-same-namespace in place which allow ingress traffic and traffic within a ns. Communication between ns is not allowed. The elasticsearch-operator is installed in ns openshift-operators-redhat and needs access to elasticsearch in ns openshift-logging.
A network policy should be implemented, which should allow this communication.

Example:
---
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: allow-elasticsearch-operator-from-openshift-operators-redhat
  namespace: openshift-logging
spec:
  ingress:
  - from:
    - namespaceSelector:
        matchLabels:
          name: openshift-operators-redhat
    - podSelector:
        matchLabels:
          name: elasticsearch-operator
  podSelector:
    matchLabels:
      component: elasticsearch
  policyTypes:
  - Ingress


Add workflow mssql.

Q
A

Is bugfix?
✔

New feature?
✔

Breaks BC?
❌

Tests pass?
✔

Awesome. Thanks.


Feature/487 Replace openbook references

https://github.com/OkunaOrg/okuna-api/issues/487
Replaces openbook references to okuna, leaving directory structure and namespacing the same

Google play app needs updating
https://play.google.com/apps/testing/social.openbook.app


refactor:if there may be more logs to replicate, continue to call sen…

refactor:if there may be more logs to replicate, continue to call send_append_entries in next loop, no need to wait heartbeat tick.
otherwise, replicate will be hang until next heart beat.

IMO, it's a bit strange to think of more logs as an error.

BTW, as this patch is more like a bug fix, it's recommended to make the commit message like fix: blabla.
A fix:  is much more important than a refactor: and deserve a seat in the change-log for next release.


Should update be exposed

I don't think so because specific Actions are not exposed and that is needed to pass to update

I think I don't understand your question :)

OK. I see now how to create an Action to pass to update


CLI not installed in Ubuntu 18 LTS

🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑
How to solve this issue?

🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.


feat: use optimised S logo

Minimal visual difference for under half the code.
As proposed in the branding repo #10, this version of the S uses stroked path with covered ends, rather than an outline.

The benefit of this approach is that your source assets are defined as Svelte components, which beyond dogfooding also allows freeing these assets from external software or service the source might live. The performance improvements are most likely negligible.

@mxdvl
I actually don't know how you do it, but looks super

It's twice less from original!

@nosovk good vector mathematics teachers and hours spent in the MDN docs on SVG paths? The interactive REPL has a debug more highlighting the underlying geometry

I don't know that it's worth optimizing this temporary version of the logo. Assuming the war doesn't last forever, the logo will eventually revert back to the original. Let's consider https://github.com/sveltejs/branding/pull/10 instead and have any discussion about whether to make the change there


Update contributing documentation

This pull request updates the CONTRIBUTING.md file to include more information about configuring the Credentials.plist file.

[Current coverage][cc-pull] is 83.74%

No coverage report found for master at 9b25723.

Powered by Codecov. Last updated by [9b25723...4afb691][cc-compare]
[cc-base-branch]: https://codecov.io/gh/watson-developer-cloud/ios-sdk/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/watson-developer-cloud/ios-sdk/compare/9b2572326d1f29a7dd6cbc53c57a76a8e8a6f759...4afb6917e500d53038318f68d9d958f3103796b3
[cc-pull]: https://codecov.io/gh/watson-developer-cloud/ios-sdk/pull/368?src=pr


Handle multiple identities with the same id but different emails.

@akatsoulas r?

Coverage increased (+0.01%) to 90.708% when pulling 725308befd983292a831b5691398af629a76deb4 on johngian:fix-multiple-primary-identities into 47a8ee35c7c9d834b618211d02e003755fc237b7 on mozilla:master.


Database + Persistence Framework

The database and persistence framework lays the foundation for all other gameplay systems in this framework so they can save and load data for individual players as well as across restarts. Closes #1
Documentation (read first and in order):

Database Framework
Persistence Framework
New default loadout system

Included drivers
This system does not yet include any web API-based drivers. Their development is now starting, but in the meantime, gameplay content can be developed that will likely work out of the box with storage via web API into a proper relational database. The default driver right now is JSON local files, so you can read what is persisted during development. The default file driver for quick server setups in the future is intended as either binary files or a hosted web API the framework team crowdfunds.
Additional changes outside of the original issue scope
For the persistence to be testable some other foundations had to be laid down like a minimal player account system (where an account can have multiple characters) that is tied to the Bohemia UID that is unique per game purchase (not related to the BI account you might log into in-game). Also for new characters spawning a basic loadout system was added. This will be updated in the future into a full pre-game character selection + creation screen, for now, a player always has one character that is alive.
Known issues

Vehicle damage state is correctly persisted but not properly synced in MP for JIP replication. Nothing we can do about this. Need to wait for a fix on this: https://feedback.bistudio.com/T167370

Tested successfully with a simple job component on the player + action that lets you sign in / out.
Documentation was easy to understand. But I needed to find the right steps since the PR already has the world setup and the documentation starts from zero (Good for others to setup). Maybe add a little part for EveronLife only that just links to the steps we need? (eg. The PersistenceComponent and SaveData is already on the player etc..)
There are now 2 folders for Features (Feature and Features). Is this intended or can we merge them into one again?

Documentation was easy to understand. But I needed to find the right steps since the PR already has the world setup and the documentation starts from zero (Good for others to setup). Maybe add a little part for EveronLife only that just links to the steps we need? (eg. The PersistenceComponent and SaveData is already on the player etc..)

I see, I will think about where to put a shortcut. Thank you for the feedback.

There are now 2 folders for Features (Feature and Features). Is this intended or can we merge them into one again?

Yes, as per conventions the desired folder is Feature (singular). The old folder will be faded out by reworking all of the systems currently inside likely over the course of this month anyway.

protected static int m_Sequence;
private static ref map<string, ref EL_DbContext> s_ContextCache;
protected static ref map<typename, typename> m_Mapping;
protected static ref EL_PlayerAccountManager s_Instance;

Those were indeed mismatches, I overlooked them. Fixed

protected static const ResourceName PREFAB = "{B5D2C533815D511D}Prefabs/Core/EL_GlobalInventoryStorageManager.et";

That one is correct because even if static the const modified takes priority as per AR conventions so it must be all upper case.


add option to report raw count values instead of delta values

Reporting delta values doesn't behave correctly if the application is decrementing the counter.

@azagniotov any updates on this PR?

Will release it today! Thank you

Released v1.0.10 to Maven Central. Please allow a few hours for the new artifact to become live.

Thanks!


Write about javascript Promises

These are so difficult for me. idk why

Pretty okay example: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled


Initial Certification test for eventhubs binding [incomplete]

Signed-off-by: tanvigour<EMAIL_ADDRESS>Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
First part towards completing #960
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

It's fine you copied some of the YAML files from the pubsub component, but you need to make sure all those metadata options actually exist in the binding too. enableEntityManagement is not an option in the binding. This should be removed.
Since the metadata option partitionID is optional -- is there anything you can do to validate the behavior? Make sure it is working as intended? I think we should have a test case for that.

I suggest you write a quick Readme file that describes your test plan.
In general we tried to add a Readme.md in every certification test folder that explains the different scenarios for which we are testing.

/ok-to-test

@tanvigour /ok-to-test unfortunately cannot work until the workflow update itself has been merged - but that update is contained in this PR.

@tanvigour this PR does not test for the majority of test cases outlined at #960 yet. However, I will merge it already so that you can raise an additional PR and then going forward use /ok-to-test to verify with your PR. This PR does not yet address #960.
Please also add a Readme.md to the root of this test with your test plan as discussed in the GitHub issue.
FYI: Because of some changes in flight due to #1681 the certifications may currently all fail. This will be addressed soon.

@tanvigour  it seems that these tests are failing 100% of times lately.
It seems that the issue is that TestAzureServiceBusQueueRetriesOnError is creating 2 instances that are listening to Service Bus using the same consumer group, and that's causing conflicts.


How to do service registration in side-kick file when using flannel

Before using flannel, I was registration my service ( COREOS_PRIVATE_IPV4) of the host after performing health checks in my side-kick unit file. I have implemented flannel now and with that I need to register the container IP address in the side-kick unit file. Is there a suggested workflow to do that ?
-Karthik

@karthikus this isn't really a fleet-specific problem. You need to be able to determine what IP address you have allocated to a given container (assuming that's your use case here), which tools like docker and kubernetes help you solve.


avoiding the overlap of the $ function out of the scope of the initDjang...

...oHStoreWidget function

Coverage remained the same when pulling d785fca499a4dcdccd5c1bcfb32986489ac3e4ff on qdqmedia:master into 8de0d35387282d42569443c389066da94b64b40b on djangonauts:master.

thanks


Fix StructuredPostalAddress regression

The test is inversed, so the street and the buillding number are not longer added to the XML!

Thank you! I can't believe I missed that :flushed: