Request: Expose Codemirror loaded Language instances

Request
It would be useful to expose the loaded Language instances (or LanguageSupport) instances that obsidian has loaded so that plugins could add codemirror syntax highlighting in editing mode.
Motivation
This would expose further functionality to allow for plugins to have a more in-depth ability to deal with writing code (i.e. adding autocompletion, bracket matching or other language features).
Also it would mean that a plugin reliant on the '@codemirror/lang-data' module wouldn't have to load a new instance of a language (that obsidian has already loaded) to use syntax highlighting.
Thank you for your consideration!

In addition, it would be great to expose the Highlighter that Obsidian uses (even if the languages themselves are not exposed) so plugins would have highlighting consistent with obsidian itself.

Language parsing support currently relies on the old CodeMirror 5 system, you should be able to hook up to it using the global CodeMirror object from a plugin.

Also issues in this repo is only for bugs with the API - if you have feature requests for the API, or questions, please post in our discord server's #plugin-dev channel, or the forum at https://forum.obsidian.md/ instead.

Thank you for your help, that's answered everything I wanted to know! I managed to get syntax highlighting done within the plugin.
Apologies, I thought I saw another request issue but I'll default to the forum next time.
Out of curiosity, is Obsidian likely to transition to the codemirror 6 Language style parsing (any time soon I guess) or not really?

Out of curiosity, is Obsidian likely to transition to the codemirror 6 Language style parsing (any time soon I guess) or not really?

Unlikely for the time being. Unfortunately a lot of editor-related functionalities ended up depending on the stream parser, including Live Preview and other token based functionality like context menu actions. A switch in the syntax parser would likely mean a major rewrite of the editor integration which isn't something we can commit to right now.


Which types of polygons do we need?

Currently the spec supports domains that can have a single GeoJSON polygon (one exterior and optionally multiple interior rings/holes). The question is: Is that too general, too restricted, or just right?
I can think of a coverage which may have a country as polygon and for some countries you would need GeoJSON's MultiPolygon. So, e.g. total population of Portugal for each year over the last 50 years, which would be a MultiPolygonSeries. I guess the question is whether such coverages are a use case of CoverageJSON. Having the full outlines of a country may not have any benefit, especially if the outlines change over the years. Typical governmental datasets would just use an ID for identifying the country.

I think it's OK for now to use single polygons, and I would be surprised if we need interior rings/holes. I think the main use case is for data that have been aggregated to the level of an administrative area or land use parcel (maybe a country, more likely a smaller region). I suggest that we keep the possibility of a MultiPolygonSeries in our minds, but don't implement it unless we find we need it.

Ok, one thing to keep in mind also is that MultiPolygonSeries may be interpreted as two things, either a single MultiPolygon with one coordinate in coordinate space, or multiple Polygons each with a coordinate in coordinate space. If you want to support both you need different names to separate them. Is the latter useful for us now? E.g. a coverage which has the percentages of different land cover categories for a number of land use parcels.

E.g. a coverage which has the percentages of different land cover categories for a number of land use parcels.

Yes, I think we need this, and this is more useful than the other sort of "MultiPolygon" you mention.


How to use autorest.csharp.v3 when use Start-AutoRestCodeGeneration command?

I'm using the Start-AutoRestCodeGeneration command to generate our services' Azure SDK. There are some params defines like below in our swagger file
      "allOf": [
        {
          "$ref": "#/definitions/BaseClass"
        },
        {
          "$ref": "#/definitions/SomeProperties"
        }

Inheritance.json
I found the PR add multiple inheritance feature to V3 branch. Is it useable in Start-AutoRestCodeGeneration command?

Yes, this suggests that allOf would work.
However, without trying the specifics it is difficult to know for sure.
The best way to check would to generate a swagger and then review the generated code for cases like this.


Update Saxon-HE dependency to 9.7

There are two deps in pom.xml on Saxon. One is on 9.4 another is on 9.5.
I tried changing these to 9.7 and encountered 7 compilation errors.
I would really appreciate if you could rebase to latest Saxon version in your next release.
Thanks for your work on epubcheck!
Eugene

See #647 for another Saxon discussion.

Hi, I recently build epubcheck with Saxon 9.6.0-7 to use epubcheck as XProc extension step along with XML Calabash (which comes with the same Saxon version). You can find my changes to the epubcheck sources in this commit: 21cd661a19b58084175c97cb0e46ffd38ff23c58
If you want to update to Saxon 9.6.0-7, I can make a PR.
best, Martin

There are two deps in pom.xml on Saxon. One is on 9.4 another is on 9.5.

The 9.4 dependency is a maven build plugin dependency and does not need to be changed!
The 9.5 dependency is the "real" code dependency. We are in the middle of upgrading this to Saxon 9.6 in issue #647 and PullRequest #767

FYI: We will update to Saxon 9.6.0-10 soon with PR #767.

Saxon 9.7 would also be a nice-to-have for @oxygenxml:
@raducoravu wrote in https://github.com/IDPF/epubcheck/issues/647#issuecomment-330132745:

Oxygen XML Editor 19.1 will come bundled with Saxon <IP_ADDRESS> and EPUB Checked 4.0.2 (just as 19.0 did). Until now we have been patching a couple of EPUB Checker classes which did not work with 9.7 (having copies of the same classes which were rewritten to be compatible with 9.7 in our own JAR library).
So we have our workarounds for this.... but probably when an EPUB Checker version is released to support Saxon 9.7 we can remove our patches.

We should probably consider updating from 9.5 to 9.7 instead from 9.5 to 9.6 (PR #767). Assigning this to milestone 4.1.

Any thoughts on upgrading to latest Saxon 9.7?
That would be <IP_ADDRESS> from July 31 2017
@rdeltour ?

Oxygen XML Editor 20 will probably update its internal Saxon libraries to Saxon 9.8. So we'll still be out of phase with the EPUB Checker, but it does not matter much, we can probably make it work in one way or another.

On Thu, Nov 30, 2017 at 1:12 AM, Tobias Fischer
<EMAIL_ADDRESS>wrote:

Any thoughts on upgrading to latest Saxon 9.7?
That would be <IP_ADDRESS> from July 31 2017

Hello,
According to [1], there is no <IP_ADDRESS>, but <IP_ADDRESS> is the last one
in 9.7 series, which is also packaged in Debian.
Version 9.8 lacks some essential configuration files (for comparison
[2] and [3]), that's why I haven't considered packaging it for Debian
yet. Probably need to contact the upstream about that.
Eugene
[1] https://dev.saxonica.com/repos/archive/opensource/tags/
[2] https://dev.saxonica.com/repos/archive/opensource/tags/<IP_ADDRESS>/hej/
[3] https://dev.saxonica.com/repos/archive/opensource/tags/<IP_ADDRESS>/hej/

Any thoughts on upgrading to latest Saxon 9.7?

If we're going to upgrade Saxon, I would even go for the latest version (9.8 at the time of writing).
@tofi86 Do you think we can do that for 4.1? I've not looked at the details, but there probably a few API changes and we have to make sure that the extension functions provided by EpubCheck (notably to report error line numbers) are working OK.

I use this patch [1] in Debian to build and run EpubCheck 4.0.2 with
Saxon-HE <IP_ADDRESS>.
[1] https://anonscm.debian.org/cgit/pkg-java/epubcheck.git/tree/debian/patches/compatibility_with_saxon_9.7.patch

Looks like most of the changes of your patch are already implemented with this PR https://github.com/IDPF/epubcheck/pull/767. I can have a look into the Saxon API changes from 9.6 to 9.8 and create another PR if you all agree?

@ezhukov I found <IP_ADDRESS> on maven: https://mvnrepository.com/artifact/net.sf.saxon/Saxon-HE/9.7.0-20
@rdeltour sure, I would also be okay with upgrading to 9.8 as long as we can still support Java 7 with it, right? don't know system reqs for 9.8
If @mkraetke could take a look at the API things that would be great.

On Thu, Nov 30, 2017 at 7:19 PM, Tobias Fischer
<EMAIL_ADDRESS>wrote:

@ezhukov I found <IP_ADDRESS> on maven:
https://mvnrepository.com/artifact/net.sf.saxon/Saxon-HE/9.7.0-20
Unfortunately I cannot find source code for that release. In Debian we
build everything from source and do not rely on maven repositories. I
would appreciate if you would stick with the official <IP_ADDRESS>/<IP_ADDRESS>
release.

At this point I'd like to emphasize the importance of reproducible-builds.org.

@tofi86

I would also be okay with upgrading to 9.8 as long as we can still support Java 7 with it, right? don't know system reqs for 9.8

Yeah, I don’t know either.

If @mkraetke could take a look at the API things that would be great.

👍
@ezhukov

Unfortunately I cannot find source code for that release.

The source code for Saxon-HE is available on SourceForge.

The good news is that just a few code changes were necessary to compile epubcheck with Saxon 9.8. The bad news is that I get plenty of error messages because Saxon 9.8 HE no longer supports XSLT 1.0 and Jing's schematron implementation relies on XSLT 1.0.
@rdeltour Concluding from the pom.xml, this version of Jing comes from Daisy? Perhaps one of your colleagues may have a look into the issue. Here is my fork of epubcheck:
https://github.com/mkraetke/epubcheck/commit/7a7ec3b07f159dd93136bdd1d74157a110099103

@rdeltour Concluding from the pom.xml, this version of Jing comes from Daisy?

It's a mavenized* version of Jing, but otherwise comes straight from Jing's source code, with no change as far as I can remember (see the POM used to compile it)
(*) and OSGified, although it doesn't matter for EpubCheck.

Thanks for testing this Martin!
So conclusion is we have to stick to Saxon 9.6 (currently implemented) or Saxon 9.7 (worth a try if it still supports XSLT 1.0).

It should be safe to update to Saxon <IP_ADDRESS> without any code changes, except the one in the pom.xml. All tests passed with this version.

👉 PR #822

Actually according to the Saxon docs starting from Saxon <IP_ADDRESS>, XSLT 1.0 backwards-compatibility mode is reinstated in Saxon-HE.

I've made a PR in order to update to Saxon 9.8: https://github.com/IDPF/epubcheck/pull/830

Saxon dependency updated to 9.8.0-8 with PR #830 by @mkraetke. Thanks!


Giving mixed customer Documents  information in response when using AzureSearchChatExtensionParameters

I have some customers documents (pdf) uploaded in azure blob storage . for some customer there are 10 documents and for some 20 for some 30. each documents has customer ID which is unique . I have indexed and add the data source.  now I had a task to get the 5 major purchases which a particular customer did in his past using the uploaded documents. I am using langchain4j for the same and configured all the required parameters . but when i am querying for a specific customer using unique customer ID sometimes it is giving mixed response, I mean let's say if i did the query for MR "X" it is not only giving the MR "Y" purchases in those 5 purchases . I have followed proper langchain4j code . I am sharing my code below. It is very urgent i am not able to figure it out. Please help. below is the code which i am using
        OnYourDataAuthenticationOptions OnYourDataAuthenticationOptions = new OnYourDataApiKeyAuthenticationOptions("mykey");
        AzureSearchChatExtensionParameters azureSearchChatExtensionParameters = new AzureSearchChatExtensionParameters("myendpoint", "myindex")
            .setAuthentication(OnYourDataAuthenticationOptions).setQueryType(AzureSearchQueryType.SEMANTIC).
                setSemanticConfiguration("default").
                setTopNDocuments(400))
                .setStrictness(5).setInScope(true)
            .setRoleInformation(Constants.CUSTOMER_DETAIL_ROLE_INFORMTION);

        AzureSearchChatExtensionConfiguration azureSearchChatExtensionConfiguration = new AzureSearchChatExtensionConfiguration(azureSearchChatExtensionParameters);

        AiAssistant assistant = AiServices.create(AiAssistant.class, AzureOpenAiChatModel.builder().apiKey("ApiKey").endpoint("Endpoint").deploymentName("deploymentName").
            temperature(openAIConfiguration.getTemperature()).topP(0.3).
            dataSources(Collections.singletonList(azureSearchChatExtensionConfiguration)).logRequestsAndResponses(true).timeout(Duration.ofMinutes(20)).build());

        response = assistant.chatAI(customerId, "my_system_message", "user_message");

@SystemMessage("{{systemMessage}}")
@UserMessage("{{userMessage}} ")
public String chatAI(@V("customerId") String customerId, @V("systemMessage") String systemMessage, @V("userMessage") String userMessage);

(Here inside my userMessage i have added a varaiable as {{customerId}})
Describe the bug

Log and Stack trace

To Reproduce

Expected behavior
When I am querying for Mr "X" . it should give the purchases for Mr "X" only. should not mix with other customers
Please complete the following information:

LangChain4j version: 0.30.0
LLM(s) used: azure openai
Java version: <java.version>1.8</java.version>
Spring Boot version (if applicable): <spring-boot.version>2.2.5.RELEASE</spring-boot.version>

Additional context

@zaheerbrakchan could you give it a try with the latest LangChain4j 0.32 release ? It uses the Azure SDK 1.0.0-beta10 instead of beta8.

@zaheerbrakchan is this issue still relevant or shall we close it ?


Improve parsing errors

Context 🕵♀
Right now, if the parsing fails for some reason, it throws an error saying that a property that was expected, wasn't there or it was in the wrong format. It'd be great to throw something more explicit like:

We've found an element XXXX with a reference XXXX that is missing the property XXXX.

What 🌱
Improve the error message.
Proposal 🎉

We've found an element XXXX with a reference XXXX that is missing the property XXXX. Your project might have got into an invalid state after a merging conflict. We recommend you to open it with Xcode, identify the issue and fix it before trying to open it with xcproj.

What do you think @xcodeswift/contributors

Error message should always be user-friendly.👌
But priority is low for now I guess. There is still a lot of formatting problems and potential SPM compatibility issue right now.

Definitively. I've updated the priority to low and removed it from the next milestone so that we can focus on all the formatting issues.

What do you mean by "potential SPM compatibility issue" btw?

I've seen this PR. https://github.com/xcodeswift/xcproj/pull/97
And I thought we might have this kind of compatibility issues on other type (empty|library|executable|system-module ) of SPM generated pbxproj.

I wonder if SPM generated projects are worth creating fixes for at this time. SPM is still a work in progress, and the projects it generates have never been quite to spec. I don't doubt that will improve in the future though.
Are there use cases for reading SPM generated projects anyway?

XcodeGen's purpose is to generate, so there are no use case for reading.
But for example I have a tool which modifies xcodeproj, so I have to support SPM too.
https://github.com/toshi0383/xcconfig-extractor


Revert, fix and redo

Following commit has broken the build:
https://github.com/diana-hep/histogrammar/commit/990acd3a1d87c5e742a7c5653bb017f4ee7b3ee4
to solve it, I created a new branch, rolled back to this state:
https://github.com/diana-hep/histogrammar/commit/bdb4dea1c63ced2032d4c9f89edfbc6191564649
made changes and committed it to that branch.

I think that worked.

Yeah, it looks like master has the latest code again and it passes the Travis tests.


Callbacks, speaker notes

Three commits; one adds a callback list, the second adds speaker notes, the third adds impress::next() on click events not otherwise caught.

This would apply to https://github.com/bartaz/impress.js/issues/102, https://github.com/bartaz/impress.js/issues/104, and possibly https://github.com/bartaz/impress.js/issues/86

Callbacks/events is what I'm willing to add in #86.
I'm not willing to extend impress.js with too many features (like speaker notes), so this pull request it not merged.
Thanks for the suggestions

@bartaz I totally understand. Perhaps a subproject for Impress extensions? Once [86] is complete, having a variety of extensions (speaker notes, alternative transitions, slide counts, etc) that users could pull piecemeal could be a nice thing.


Add custom whole condition alias support

Hello,
How about we get support for an alias for a custom whole condition?
Like, """AdultMale == true""" translating to """ Age >= 18 && Gender == "Male" """

This seems like business logic creeping in a bit, which seems smelly on first glance, but I'm potentially open to it.
What api would you think for setting this up in the config?

I thought of another example today that i think this would be useful for -- more like aggregate properties like creating a FullName to search for an aggregate of first name and last name. need to think through the api a bit more and this would probably be tricky to get right under the hood, but glad to have some more examples for this

Hey there! I'm not sure about business logic creeping, you might be right.
About the API, I thought we could pass an Expression<Func<T, bool>> and a string as a configuration, and then the library would know how to handle it.
var input = $"""AdultMale == true"""; //Only handles true or false
var config = new QueryKitConfiguration(config =>
{
    config.Filter<Person>(x => x.Age >= 18 && x.Gender == "Male")
     	 		.HasAliasName("AdultMale");
});

The reason I came up with this, is, I can have a readonly calculated property in an entity class that is ignored on the mapping to the DB (rather than having a Computed Column). In my example, the AdultMale is the property.
In this case, trying to filter directly in the "AdultMale" property would cause an exception with EF Core, with a message like

The expression could not be translated

Thus the need for it to be translated to a query that the database can actually perform.

I really need this feature

PRs are welcomed if you want to contribute

resolved in 1.4 release with derived property api


Ray does not behave properly when inside a mirror

When a ray is placed inside a mirror, it finds the wrong intersection point or in some cases does not find an intersection point at all

Resolved :D


[WIP] Add Ecto.Multi.merge/2

The function passed to merge accepts an initial multi - that allows us to easily guard against duplicated operations, that would cause issues later on when merging results.
This still needs docs.
Closes #1464

@ericmj @fishcakez - you were asking for this feature, what do you think about this?

@josevalim updated

@josevalim Ready for review

:shipit:

Thank you @michalmuskala :heart:, this is very nice :D

@michalmuskala Multi.merge is a really nice new abstraction, thanks!
I recently ported Multi.insert + fn to Multi.merge and it was very straightforward:

before
after

The former has a bit less code and to me is more readable (it's not a big difference though) and now it should be trivial to re-implement in terms of .merge - if that would seem like a good idea and/or you get feature requests - feel free to let me know ;-)

I think implementing insert/update/delete in terms of merge is a good idea, I'm not sure this should be part of ecto itself, given it's basically a one-liner:
def insert(multi, name, fun) do
  Multi.merge(multi, fn data -> Multi.new |> Multi.insert(name, fun.(data)) end)
end

\cc @josevalim


Missing Configuration details for Change the Default Datasource for BPS for Oracle Rac DB

Describe the issue:

Missing Configuration details for Change the Default Datasource for BPS for Oracle Rac DB
Refer the below documentation
https://is.docs.wso2.com/en/6.1.0/deploy/change-datasource-bpsds/
How to reproduce:

N/A
Expected behavior:

N/A
Expected behavior:

N/A
Environment information (Please complete the following information; remove  any unnecessary fields) :
Product Version: [e.g., IS 6.1]
OS: [e.g. Linux/Oracle RAC vm]
Database: [e.g., Oracle Rac]
Optional Fields
Related issues:

Suggested labels:

Closing this as BPS related documentation is moved to the connector documentation and was removed from IS from the following issue:
https://github.com/wso2/product-is/issues/20526


Update Python version

Update Python version in .github/workflows/build_workflow.yml

@tomvothecoder I notice in https://github.com/E3SM-Project/e3sm_diags/pull/621/files you have:
    strategy:
      matrix:
        python-version: ["3.8", "3.9", "3.10"]

However, zstash has multiple python-version specified in https://github.com/E3SM-Project/zstash/blob/main/.github/workflows/build_workflow.yml. Does setting this in matrix negate the need to have it anywhere else?

To break it down, the build workflow contains jobs such as pre-commit-hooks and build. These jobs might use some prebuilt actions such as actions/setup-python@v2, which includes a setting for python-version.
Example:
https://github.com/E3SM-Project/zstash/blob/30d1784f6de2ebe722170a654a83b4c380a45a55/.github/workflows/build_workflow.yml?rgh-link-date=2022-09-12T21%3A59%3A36Z#L11-L27
In the E3SM diags build workflow, we specify a matrix  for the build job because we want to rerun this job (and the test suite) for different versions of Python. We can do the same for other jobs, but we don't need to.
  build:
    name: Build (Python ${{ matrix.python-version }})
    runs-on: "ubuntu-latest"
    timeout-minutes: 20
    defaults:
      run:
        shell: bash -l {0}
    strategy:
      matrix:
        python-version: ["3.8", "3.9", "3.10"]

Specifying a matrix is not needed for zstash unless you have a test suite you want to run across different versions of Python. Otherwise, you can simply update python-version from 3.7 to 3.10 wherever needed.

Fixed by #224


slack channel is not working

Link to join openyurt slack channel not working please check it, showing link is no active.

@karthik507 have a try: https://join.slack.com/t/openyurt/shared_invite/zt-2bptiyzuv-oDDlfdLwS0AuxSyD4cq4eA

Thank you

@YTGhost
not able join the channel from above link , can you help

Thank you @YTGhost

@karthik507 Would you like to make a pull request to update the slack link in the readme?

The following slack link will not be expired.
https://join.slack.com/t/openyurt/shared_invite/zt-2ajsy47br-jl~zjumRsCAE~BlPRRsIvg

@karthik507 Would you like to make a pull request to update the slack link in the readme?

The following slack link will not be expired.
https://join.slack.com/t/openyurt/shared_invite/zt-2ajsy47br-jl~zjumRsCAE~BlPRRsIvg

okay

/close


Fix docker compose typo in README.md

According to compose.yml line 40, the appropriate environment variable to set the smtp_pass docker secret is WAKAPI_SMTP_PASS, not WAKAPI_MAIL_SMTP_PASS. I presume it's the README that needs to be changed, not the compose file itself - if WAKAPI_MAIL_SMTP_PASS is instead the desired environment variable name, let me know and I can update the PR accordingly.

https://github.com/muety/wakapi/blob/4f1b2d0a711c67ad7eb247308be61f3e6b96894f/config/config.go#L187


Work around optparse-applicative limitations for parsing complex command lines

We are unable to define parsers of arbitrarily complex types and fallback between them due to limitations of the optparse-applicative library.
We need either need a more permanent solution or a viable work around.
There is a discussion here.
https://input-output-rnd.slack.com/archives/C057E9CJTPH/p1692887691962709?thread_ts=1692850710.826029&cid=C057E9CJTPH

@newhoggy is this completed?


Trainning model with train_unified_conformer_ctl.yaml error

Trainning model with train_unified_conformer_ctl.yaml error.
We update source code at 2023-12-21.
We trian model with train_conformer.yaml firstly, it is ok, we get the final model.
Then change run.sh as below:
#train_config=conf/train_conformer.yaml
#dir=exp/conformer
train_config=conf/train_unified_conformer_ctl.yaml
dir=exp/uni-conformer-ctl

We clean the train data in ./data folder, and re-make it.
Re-train model with run.sh as stage seperate.
From stage 0 to stage 3, it is right, then to run stage 4, get error as below:
  traceback : Traceback (most recent call last):
    File "/home/ticoo/miniconda3/envs/wenet2/lib/python3.8/site-packages/torch/distributed/elastic/multiprocessing/errors/__init__.py", line 346, in wrapper
      return f(*args, **kwargs)
    File "wenet/bin/train.py", line 142, in main
      executor.train(model, optimizer, scheduler, train_data_loader,
    File "/home/ticoo/wenet/wenet/utils/executor.py", line 74, in train
      info_dict = batch_forward(model, batch_dict, scaler,
    File "/home/ticoo/wenet/wenet/utils/train_utils.py", line 464, in batch_forward
      loss_dict = model(batch, device)
    File "/home/ticoo/miniconda3/envs/wenet2/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
      return forward_call(*input, **kwargs)
    File "/home/ticoo/miniconda3/envs/wenet2/lib/python3.8/site-packages/torch/nn/parallel/distributed.py", line 1040, in forward
      output = self._run_ddp_forward(*inputs, **kwargs)
    File "/home/ticoo/miniconda3/envs/wenet2/lib/python3.8/site-packages/torch/nn/parallel/distributed.py", line 1003, in _run_ddp_forward
      return module_to_run(*inputs, **kwargs)
    File "/home/ticoo/miniconda3/envs/wenet2/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
      return forward_call(*input, **kwargs)
  TypeError: forward() missing 2 required positional arguments: 'text' and 'text_lengths'

It seems arguments loss, any advice???

Thx, this is a bug, please change the forward() in ctl_model/*.py according to https://github.com/wenet-e2e/wenet/pull/2242
once u fix this issue, feel free to make a PR, we are happy to merge it.

Thanks, got it.


User request: Incomplete barcode set

While using more than one index, if non-unique barcodes are omitted in the barcode file set, they could be added to the wrong sample. The current pipeline assumes that the barcode file contains all the barcodes present in the multiplex file, but this may be not true.
This confused one of the users, who input an incomplete barcode set and got wrong results. To solve this problem, we should:

Specify in the command line help for the new barcode tool (the others will be deprecated, se #74) and in the wiki page (see #57) that currently barcode detection requires that all barcodes should be provided in the file. This is very important, and maybe we should log a warn before starting processing too.
To allow missing barcodes in the file, which may be useful if not known or to be more stringent, an option to disable identification by unique barcodes should be added. This is a minor change that increase the usability and fix the original issue reported by the user.

If a new argument is implemented for this, we should remove the current warning in the help.

This is something to take into consideration for https://github.com/magicDGS/ReadTools/issues/113


[CGPROD-2388] Vertical border padding set to 32 on iPhone 5

This is horrible.

It felt like I was committing a crime when I was writing it.


docs: create migration guide for v9 hammer migration

Here's a commit with my proposed edits
https://github.com/jelbourn/components/commit/8ac15b1bf05df600e6a1d9cbbd4addbaff272bdc


[Feature] drive naming

Description of the feature
ability to name the drives within config, As I have 2 drives which are the same size and model so its not clear which one is which.
Additional context
No response

Hello, thanks for creating an issue.
You can use overrides in this case - specifically DASHDOT_OVERRIDE_STORAGE_BRANDS.


bigger markers

With these slightly bigger markers the page is much more user friendly for me. Keep it or leave it.

not good yet. sorry.


Librispeech, validate_manifest.py

modifying the validation script

the Supervision start is relative to Cut
let's assume the data is prepared with 'trim-to-supervision' (i.e. Supervision.begin is close to 0.0)
the end of supervision should not fall out of cut
a tolerance of 2ms is itroduced
finally, the validation 'validate_for_asr' from 'lhotse.dataset.speech_recognition' is performed

this script will be generic also for imported kaldi data folders (for both types 'one segment per wav' and 'many segments per wav')

actually I am building a generic recipe for training from imported kaldi data folders
would it be interesting to contribute it to icefall ?

Thanks for your contribution!

Thank you for merging!


Struts problem on dcat feed

When I want to access the dcat feed on the IPT I am testing, I get this:

Any idea how to prevent this?

We have forgot to test with a "non-published resource". We need the last published date for every resource in the DCAT. We just change our list with all of the resource by a list with all of the published resource. Nice testing , we just fix it.

Can you email me a new .war file, so I can retest? Thanks!

the file is too big to send through email

Can you temporarely host it on Dropbox or Google Drive and email me the link?

I put the file in my google drive and send a mail

Problem is fixed. Thanks.


[bug] Vite SSR Can't Resolve ESM

Hey Nate,
Thanks for the other Vite fixes in #479! It's now gotten me past those errors and onto this one.
I've managed to widdle it down to the following repo, where you can see the patch that worked for me for that 1st error and onto the next with essentially the same pattern: https://github.com/tazsingh/tamagui-ssr-vite
Note, the patch doesn't include changing this line:
https://github.com/tamagui/tamagui/blob/master/packages/normalize-css-color/package.json#L31
to: "import": "./dist/esm/index.mjs",
Essentially, I believe that Vite CLI is a bit more forgiving than Node's module resolution. Annoyingly, Node seems to want everything to be .mjs files for ESM, while Vite doesn't seem to mind as much. Since I'm trying to load the project via Vite for SSR, it's hitting Node's module resolution which is constantly tripping over the .js files not being .mjs files.
Additionally, it's odd to me that "type": "module" doesn't seem to matter much here, and separately removing the "exports" map entirely from package.json is also a fix 🤷 Thought I'd mention it in case you're debugging. The patch above is what I've discovered to be the path-of-least-resistance to change all ESM output to use .mjs files. Hope that helps 🙏
To Reproduce
Check out my repo
yarn install
yarn dev:ssr
Notice the next bug, that isn't fixed by the patch above. Feel free to remove the patch to see the issue it's patching over.

Woof, change to mjs is almost not doable for the hassle. All the module stuff has been a pain to get it working backwards compat.

This is only for the ESM build, which has always used .mjs and is backwards compatible to Node 14 but goes all the way back to Node 8: https://nodejs.org/docs/latest-v14.x/api/packages.html#packages_determining_module_system
The alternatives which aren't backwards compatible would be changing the package.json "type", as that would affect ESM and CJS. However, per my testing above, that doesn't seem to matter anyway
I agree the whole ESM thing is a hassle though! 😅

Hey Nate,
This is indeed a troublesome issue, we have had many issues with urql as well. The gist of it comes down to that plain node usage demands .mjs for anything that uses ESM type import/export. As Taz mentions, there are ways around this by marking your package as type: 'module' but then the cjs usage requires a .cjs extension.
Most bundlers have ways around this but when we go to the pure node site there aren't really any good ways around this, for the react-urql package we stopped shipping export-maps entirely and for the @urql/core package we started using .mjs.
The reason for this difference is that we had a few issues with create-react-app and how it interacted with the .mjs syntax (it didn't want to resolve it)...

Sounds nightmarish... I've already gone through so many iterations too (leaving out export maps, bringing the back, trying various incantations).
I'm happy to make any change but I'd have to test quite a lot to be sure everything works so want to be sure we get it right.
@tazsingh what was the first patch in that repo? Without the commit log showing can't see easily.
@JoviDeCroock @tazsingh could one of you guys play around and figure out the full set of changes that gets it working and let me know?

I have put in a suggestion, thanks for being open to this change @natew


Allow symfony yaml 4x

Hi,
We have a downstream dependency on this package and are doing some upgrades, ran into a conflict with current symfony 4.x releases. Looks like everything passes with a simple optional upgrade on symfony/yaml.
Thanks!

As it stands symfony/yaml v4 conflicts with the phpunit version currently used because of the php version support.
I will need to review and maybe drop support for 5.4 and 5.5 which makes sense anyway given they are end of life.

Everything builds and tests through w/ php7x, phpunit ~7.0, and the rest of symfony to ~4.0 in the project we're using this on. The change to this package tests locally with php7x with the caveat that it warns about each() being deprecated in Sebastian's code. (ex https://github.com/sebastianbergmann/phpunit/issues/2887)
I have a fork running just for the sake of moving on with the dependent upgrade on our project, if there's anything I can do to get this branch over the line let me know.
A quick stab at upgrading phpunit to latest quickly dives into dependency hell. Might have to step through it.
Thanks!


Support to composing

Hello everybody.
There is a way to send a contact update informing that it is "typing" (internally called "composing").
Analyzing WahtsApp web I see that it is a binary message. I would like to know if anyone could implement it.
Thanks

Duplicated https://github.com/Rhymen/go-whatsapp/issues/275


[ADDED]: Gesture Controlled Virtual Mouse

Description
Gesture Controlled Virtual Mouse makes human computer interaction simple by making use of Hand Gestures and Voice Commands.
This feature has been added in the repository.
Checklist

[X] I've read the contribution guidelines.
[X] I've checked the issue list before deciding what to submit.
[X] I've edited the README.md and link to my code.

(Add x in the [] to mark as completed.)
Related Issues or Pull Requests
#456

@khusheekapoor Can you please review my PR and kindly merge it :)


Hi, I was building example when I got this error. I don't know how to deal with this  error, please help me, thanks.

GEN-SKEL .output/fentry.skel.h
CC       .output/fentry.o
BINARY   fentry
BPF      .output/usdt.bpf.o
libbpf: failed to find BTF info for global/extern symbol 'my_pid'
Error: failed to link '.output/usdt.tmp.bpf.o': No such file or directory (2)
make: *** [Makefile:112：.output/usdt.bpf.o] error 254

Make sure you have sufficiently new Clang that produces BTF information for global variables. What's your Clang version?

I modified the definition of the global variable in usdt.bpf.c, initialized it with a value of 0, and the compilation passed

Make sure you have sufficiently new Clang that produces BTF information for global variables. What's your Clang version?

Hi, I'm having the same error. My Clang version is 10.0.0-4ubuntu1. Is it enough?

ok，thanks

My problem has been solved, thanks for the help


Can't get track information

Hi guys, I love your app and am trying to integrate with this extension
I looked at the example code that you have. And MPMusicPlayerController will get me the info for songs played with apple music, but it doesn't seem to get for songs playing through spotify? Can you advise on how I would get the current playing track from the spotify app?
- (IBAction)lyrics:(id)sender {

    MPMediaItem *item = [[MPMusicPlayerController iPodMusicPlayer] nowPlayingItem];

    if (item) {
        [[MXMLyricsAction sharedExtension] findLyricsForSongWithTitle:item.title
                                                               artist:item.artist
                                                                album:item.albumTitle
                                                              artWork:[item.artwork imageWithSize:artWork.frame.size]
                                                      currentProgress:[[MPMusicPlayerController iPodMusicPlayer] currentPlaybackTime]
                                                        trackDuration:item.playbackDuration
                                                    forViewController:self
                                                               sender:sender
                                                     competionHandler:^(NSError *error) {

                                                     }];
    }

}

Hi guys, I love your app and am trying to integrate with this extension
I looked at the example code that you have. And MPMusicPlayerController will get me the info for songs played with apple music, but it doesn't seem to get for songs playing through spotify? Can you advise on how I would get the current playing track from the spotify app?

- (IBAction)lyrics:(id)sender {

    MPMediaItem *item = [[MPMusicPlayerController iPodMusicPlayer] nowPlayingItem];

    if (item) {

        [[MXMLyricsAction sharedExtension] findLyricsForSongWithTitle:item.title

                                                               artist:item.artist

                                                                album:item.albumTitle

                                                              artWork:[item.artwork imageWithSize:artWork.frame.size]

                                                      currentProgress:[[MPMusicPlayerController iPodMusicPlayer] currentPlaybackTime]

                                                        trackDuration:item.playbackDuration

                                                    forViewController:self

                                                               sender:sender

                                                     competionHandler:^(NSError *error) {

                                                     }];

    }

}


Highlighting issue with styled components

Hey, I've encountered this weird bug quite often now. Have you encountered this before or know of a solution?
As shown in the screenshot below, all code after a styled components definition is highlighted as typescriptTemplate. This happens after modifying a file and scrolling down.

How to reproduce
I managed to reproduce it quite often the following way:

Open the file I pasted below
Make sure that the file is a bit longer than the Vim screen (the Egg styled component definition should end below the viewport)
Scroll to the top of the file
Delete line 5 (font-size: 1rem)
Scroll to the bottom with G
Press F10 to see the syntax group (mapping from my vimrc below)

import * as React from 'react'
import styled from 'styled-components'

const AnotherComponent = styled.div`
  font-size: 1rem;
`

const Egg = styled.h1`
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
  color: black;
`

const CoolComponent = () => (
  <Egg>This is a test thing</Egg>
)

export default CoolComponent

Minimal vimrc
call plug#begin('~/.vim/plugged')

Plug 'HerringtonDarkholme/yats.vim'
Plug 'styled-components/vim-styled-components', { 'branch': 'main' }

call plug#end()

function! SynStack()
  if !exists("*synstack")
    return
  endif
  echo map(synstack(line('.'), col('.')), 'synIDattr(v:val, "name")')
endfunc

nnoremap <silent> <F10> :call SynStack()<CR>

Actually this is vim feature. Vim will skip highlighting after several lines.

Hmm, the problem doesn't happen when only YATS is installed but it does if styled-components is also installed. Also, the file is sonly 59 lines long so would Vim really skip highlighting in that case?
What's extra weird in that case is that typescriptTemplate syntax group gets applied (so it looks like syntax highlighting is actually applied, just that it's incorrect).
Anyways, did you manage to reproduce the issue?

I also recorded a gif, maybe it's easier to understand the problem this way:
https://i.gyazo.com/36f63f7ecaaf2c28ac13b7e201e6807f.mp4

@JoosepAlviste try to put autocmd BufReadPost *.tsx,*.ts,*.jsx,*.js :syntax sync fromstart in your vimrc and see if that solves the problem.

@tomaskallup looks like this solves my problem, thanks!
I guess it's probably OK to keep it as a permanent solution since I don't have any super large tsx files.


Allow an external app to start a stream

This is not entirely finished, and has not been fully tested, but starting a stream from an external app does work, and it should be secure. I've left TODO(Noah) comments in places that I know still need work.
I probably won't be able to work on this any more this week, so I'll let you decide if you want to leave it out of this release, or tie up a few loose ends and put it into the next release. Feel free to talk to me about that on Discord.
Here's an extremely basic app that can be used to test starting a stream from an external app: https://github.com/NoahAndrews/RemoExternalControlDemo
I've checked "allow edits and access to secrets by maintainers", so feel free to make your own commits to my branch if desired.

I tested it and it appears to work great so far. The issues I have come across so far I have fixed in a newer version of develop. Issue was related to killing the app via the Terminate button in the notification would cause the app to get stuck disabling. It did shut down the stream properly, but could not be started again until the app process was killed

Glad to hear that you're happy with it so far.
BTW, I'll probably have time to properly finish this myself this weekend.

Just merged https://github.com/remotv/controller-for-android/pull/116/commits/c39e5c1e921f38d09b99760e60529c2e8fc4a852 into develop. Hopefully that does not create a conflict here

Just merged https://github.com/remotv/controller-for-android/pull/116/commits/c39e5c1e921f38d09b99760e60529c2e8fc4a852 into develop. Hopefully that does not create a conflict here

Alright, all of my TODOs are taken care of! Now I just need to resolve the conflicts, and make codeclimate happy.

Alright, all of my TODOs are taken care of! Now I just need to resolve the conflicts, and make codeclimate happy.

@btelman96 Is there a way to tell codeclimate to ignore certain warnings? For example, processExternalAppParameters is exactly as long as it should be, in my view. Trying to break it down into additional functions would only harm clarity.
https://github.com/NoahAndrews/controller-for-android/blob/c9c8b8f7f10eec375d247ff1c214de935b4cff1e/app/src/main/java/tv/remo/android/controller/activities/ExternalControlActivity.kt#L77-L109

@btelman96 Is there a way to tell codeclimate to ignore certain warnings? For example, processExternalAppParameters is exactly as long as it should be, in my view. Trying to break it down into additional functions would only harm clarity.
https://github.com/NoahAndrews/controller-for-android/blob/c9c8b8f7f10eec375d247ff1c214de935b4cff1e/app/src/main/java/tv/remo/android/controller/activities/ExternalControlActivity.kt#L77-L109

Looks like you have the ability to mark issues as "Invalid", but I don't.

Looks like you have the ability to mark issues as "Invalid", but I don't.

IMO, the remaining "issues" found by Code Climate don't need fixing. Let me know if you disagree. From my perspective, this PR is ready for merging!

IMO, the remaining "issues" found by Code Climate don't need fixing. Let me know if you disagree. From my perspective, this PR is ready for merging!

Note that https://github.com/NoahAndrews/RemoExternalControlDemo has been updated to support sending chat messages, stopping the stream, and showing the result of the prompt as a toast message.

Note that https://github.com/NoahAndrews/RemoExternalControlDemo has been updated to support sending chat messages, stopping the stream, and showing the result of the prompt as a toast message.


Load peer deps on demand

Codecov Report

Merging #17 (6730fd7) into main (754322f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   99.65%   99.66%   +0.01%
==========================================
  Files          18       19       +1
  Lines         289      303      +14
  Branches       32       32
==========================================
+ Hits          288      302      +14
  Misses          1        1

Flag
Coverage Δ

root
99.66% <100.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/for-mobx-react-query/SpreadoSetupImpl.ts
100.00% <ø> (ø)

src/for-redux-react-query/SpreadoSetupImpl.ts
100.00% <ø> (ø)

src/for-redux-swr/SpreadoSetupImpl.ts
100.00% <ø> (ø)

src/redux/findValue.ts
100.00% <ø> (ø)

src/redux/module.ts
100.00% <ø> (ø)

src/core/index.ts
100.00% <100.00%> (ø)

src/core/peerDeps.ts
100.00% <100.00%> (ø)

src/mobx/SpreadoMobXStore.ts
100.00% <100.00%> (ø)

src/mobx/spreadHelpers.ts
100.00% <100.00%> (ø)

src/redux/spreadHelpers.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754322f...6730fd7. Read the comment docs.


KAFKA-3959: enforce offsets.topic.replication.factor

Kafka brokers have a config called "offsets.topic.replication.factor" that specify the replication factor for the "__consumer_offsets" topic. The problem is that this config isn't being enforced. If an attempt to create the internal topic is made when there are fewer brokers than "offsets.topic.replication.factor", the topic ends up getting created anyway with the current number of live brokers. The current behavior is pretty surprising when you have clients or tooling running as the cluster is getting setup. Even if your cluster ends up being huge, you'll find out much later that __consumer_offsets was setup with no replication.
The cluster not meeting the "offsets.topic.replication.factor" requirement on the internal topic is another way of saying the cluster isn't fully setup yet.
The right behavior should be for "offsets.topic.replication.factor" to be enforced. Topic creation of the internal topic should fail with GROUP_COORDINATOR_NOT_AVAILABLE until the "offsets.topic.replication.factor" requirement is met. This closely resembles the behavior of regular topic creation when the requested replication factor exceeds the current size of the cluster, as the request fails with error INVALID_REPLICATION_FACTOR.

@onurkaraman LGTM for the change itself. I'm guessing this might have some repercussions for system tests though. Maybe we should add the override to tests/kafkatest/services/kafka/templates/kafka.properties as well? Actually since we have broker failure tests for the consumer, we may need to determine a suitable replication factor based on the number of brokers in the test.

@hachikuji yeah agreed. I realized after submitting the PR that I hadn't even run the tests. I had only done a manual test. Config values in the integration/system tests may need to change. I can look into it.

Force pushed a change that should fix the unit/integration tests. Still need to look into system tests.

I think this is a good change. A couple of comments:

We should add a note to upgrade.html
Does this need a KIP since it's a potential breaking change?

Added a note to upgrade.html and updated the config documentation in KafkaConfig.

Something to consider is that internal topic creation can happen in five paths:

By a broker upon GroupCoordinatorRequest.
By a broker from MetadataRequest querying the internal topic even if "auto.create.topics.enable" is false.
By a user when using AdminUtils.
By a user when running kafka-topics (which calls AdminUtils).
By a broker through AdminManager (which calls AdminUtils) handling CreateTopicsRequest.

Consequences of this PR:

is covered correctly by this PR.
now accidentally may have the MetadataResponse return GROUP_COORDINATOR_NOT_AVAILABLE for when a MetadataRequest queries the internal topic. Internal topic creation from MetadataRequest in the past used to always succeed since the replication factor was adjusted.
AdminUtils.createTopic behavior remains unchanged (though the current behavior is arguably wrong). AdminUtils does a similar cluster size vs. replication factor comparison but throws an InvalidReplicationFactorException if the manually specified replication factor isn't met. If the replication factor is met, it creates the topic, ignoring the broker's offsets.topic.replication.factor config.
Same as 3.
Same as 3. CreateTopicsResponse including an internal topic will return INVALID_REPLICATION_FACTOR.

So scenario 1 has been fixed, 2 has an unexpected change, and 3-5 remain unchanged but potentially do the wrong thing.

6th way: By a user directly writing to zookeeper.
Consequences of this PR: Unrelated, as the zk write will not receive any error from kafka.

That being said, I don't think we need to worry about users manually creating the __consumer_offsets topic for now, so really we just need to worry about path 1 and maybe 2.

Only worrying about 1 & 2 for internal topics seems reasonable to me.

Yeah, focusing on 1 & 2 makes sense. @ijuma Feels a bit weird to require a KIP to enforce an existing configuration correctly 😉 . That said, I'm not too sure about the impact, so might be safer to do a KIP anyway. Seems this only affects new clusters, so I imagine the main impact would be broken tests. Perhaps some broken deployment recipes also?

@hachikuji, sorry for the delay. I agree that this should have been the correct behaviour for the configuration. However, the previous behaviour was specified and it was not an accident either (Jun and Neha discussed it in the original JIRA). Given that and the potential impact on new deployments, a KIP seems inevitable. It should be a simple one and it will hopefully pass as easily as the unclean leader election one. :)

For 1, I think we all agree that it should be solved with GROUP_COORDINATOR_NOT_AVAILABLE.
For 2, I think we want to preserve existing MetadataRequest topic creation behavior by returning INVALID_REPLICATION_FACTOR, but I don't know if we actually agreed on that. If this is what we want, then I need to do revise the code.

I updated the PR assuming the behavior mentioned in my previous comment.

@hachikuji @ijuma @ewencp so what is the plan? Can we just check it into <IP_ADDRESS>?
I need to know the release in order to tweak the upgrade.html correctly.

Updated the upgrade.html so the comment is under the <IP_ADDRESS> notable changes.

Was about to check this in, but I didn't see any notes about validating the system tests still work. Kicked off https://jenkins.confluent.io/job/system-test-kafka-branch-builder-2/187/ to make sure they are still in good shape with just the minor template tweak.

@ewencp looks like https://jenkins.confluent.io/job/system-test-kafka-branch-builder-2/187/ failed.
I kicked off a new build with the same params as build 187 and it passed: https://jenkins.confluent.io/job/system-test-kafka-branch-builder-2/188/

Thanks @onurkaraman. LGTM, committing to trunk for inclusion in <IP_ADDRESS>.

@ewencp Checked for the check-in. I just noticed that the checked in code has the upgrade notes under "Notable changes in <IP_ADDRESS>" while I think we agreed to put it in <IP_ADDRESS>.

@onurkaraman Good catch, somehow missed this despite re-reviewing the changes. Filed https://github.com/apache/kafka/pull/2484 and reopened the JIRA to adjust the docs.


gx publish on windows to remote ipfs node fails

Error is ERROR: publishing: object/patch/add-link: invalid ipfs ref path
Both running latest master ipfs and gx
Publish using a local ipfs node works fine

@slothbag thanks for reporting, i'll take a look into this. Its very likely to be pathing differences (again)

No worries, when I get a break in the coming days I'll try dig a little deeper.  But yeah, seems like path slashes again.

Updated gx and deps and problem seems to have gone away.

@slothbag great to hear!


Solve an AST anomaly in rare redeferral cases.

We may redefer a nested function but choose not to defer it when we recompile the enclosing function. In such a case, the existing nested FunctionProxy is a compact ParseableFunctionInfo, not the full FunctionBody the front end expects to generate. We were keeping the compact structure and discarding the AST subtree belonging to the nested function, but this seems to be producing anomalous AST's that cause problems downstream. Generate the full FunctionBody on the fly instead.

You can now resolve the CI issues as described here: https://github.com/Microsoft/ChakraCore/pull/2332#issuecomment-271029950


Adding option to pass bulk context per operation and mitigating bulk ingestion hang

Mostly changes to change the public surface area to allow context on BulkItemOperation level.
Also a couple of minor changes to improve logging/debugging and stability I found during the bulk ingestion hang investigation.

/azp run java - cosmos - tests

/azp run java - cosmos - ci.spark

/azp run java - cosmos - ci.spark

/azp run java - cosmos - spark

List of test failures in the full CI:
createItem_withBulkAndThroughputControl
splitQueryContinuationToken
sessionNotAvailableRetryMultiMaster
sessionNotAvailableRetryWithoutPrefrredList
sessionnotAvailableRetrySingleMaster
All of them are known test issues Kushagra is tracking already. Going to merge the PR now.


integrated optional line numbering functionality

output the original SCSS line numbers within the compiled CSS file for better frontend debugging.
works great in combination with frontend debugging tools like https://addons.mozilla.org/de/firefox/addon/firecompass-for-firebug/
to activate this feature you need to call ->setLineNumbers(true) after creating a new instance of compiler.php
For full description see:
https://github.com/Screenchecker/scssphp/tree/develop#optional-output-scss-line-numbers

It seems you weren't able to rebase and squash, so I opted to instead cherry-pick 2aab9e7 into the line-numbers-v2 branch as it seemed to have fewer merge conflicts for me to resolve.
https://github.com/leafo/scssphp/tree/line-numbers-v2
I'll finish reviewing the PR this week.

that's odd, git reported "successfully rebased and updated" without any conflict or error.
if you still need the squashed commits just say so and ill look into it again.
the cherry pick strategy seems to be a good call, since there were only very minor changes since the first version of the "line-numbers" branch last week. tests need to be rebuild of course, since the output will be different now.

Seems to still have some edge cases, such as unexpected and/or missing line comments, e.g.,

https://github.com/leafo/scssphp/blob/line-numbers-v2/tests/outputs_numbered/compass_extract.css
https://github.com/leafo/scssphp/blob/line-numbers-v2/tests/outputs_numbered/comments.css

Instead of the extra pass, maybe we could add hints to the Parser. I created an experiment-line-numbers branch to rough out this idea but it isn't without its own set of challenges:

line numbers are off
formatting: Nested adds an extra newline, while Expanded should add a newline
extra line comments with imports/partials

The extra pass is indeed not the perfect solution. When I wrote the basic first version in a couple of hours  I tried to interfere with the core scssphp parser as little as possible since I was looking for  a quick solution. It's a more modular approach.
Like I said above the line comment output might not always be perfect, but in 99% of the real life cases the overhead is very low and the firebug debugger extension will get it right. Some scss input used for the test cases can't be described as realistic code (which is deliberate to cover a lot of scenarios of course).
Nonetheless, I welcome the new approach to integrate the line number functionality directly into the parser and I'm very happy to help. This would also be a great chance to integrate sourcemaps, since the basic approach would be the same. Or should we drop line numbers completely in favour of sourcemaps  which would be a more elegant debugging solution?

Both approaches have their +/-.  I agree this will probably set the stage for source maps. Let's tinker with this a bit.

will the line-numbers-v2 branch stay a development branch in the meantime or will it still be merged into into the master branch until a better solution becomes available? Some people have been waiting for official debugging support for quite some time now and I think it would be a  pity they would have to wait again just because of minor flaws.
Or will line-numbers-v2 still receive the latest updates like the master branch?

I'm going to keep both branches updated until a decision is made on which to mainline. I've started looking at source maps support, so that will weigh in.

That is awesome! I think it's worth mentioning that the line number branches will still receive the latest updates here: https://github.com/leafo/scssphp/issues/88#issuecomment-111465417
So people know that they can use it without having to use an older version of scssphp.
Source maps:
I already looked into it a couple of months ago, but i ran out of time.
I'm looking at my old code right now ... it was just a prototype approach (at best).
I used line numbered CSS output to generate a basic map output (not even in a separate file yet, but just as a JSON string for testing). So this approach would even require a second pass (not what we want)n
But i guess it will be tricky knowing the exact line number for the final CSS file while parsing trough the SCSS code. Especially includes and functions will make things interesting.


ENH: add numerical constants

Scraped them with this script:
import numpy as np

def main():
    constants = []
    for obj_name in dir(np):
        obj = getattr(np, obj_name)
        if isinstance(obj, float):
            constants.append(f'{obj_name}: float')
    print('\n'.join(sorted(constants)))

if __name__ == '__main__':
    main()

LGTM, merged. Thanks @person142.
Note that there's also non-float constants; integer flags like np.CLIP.


Vendoring dependencies?

Recently python-box broke and also we had to pin python-dotenv, so given the way dynaconf is embedded on libraries and applications looks like a good idea to vendor 3 libs.

toml
python-box
python-dotenv
click

maybe replace box with a simpler implementation.

Hello.
I stumbled upon your project and wondered: why would you rather have your dependencies "vendored" (that is, to keep a full copy of them inside this repo) instead of using a dependency management tool? If you have some time to answer this please let me know because I am curious about the reasoning to do so.

Hi @pavel-razgovorov
That decision was made because dynaconf started being packaged for many O.S including debian, RHEL, Arch.
To enable dynaconf to be a .rpm package for example it would require also the packaging of every dependency individually, so we decided to vendor it (the same way other projects does ex. https://github.com/pypa/pipenv/tree/master/pipenv/vendor for the same reason)

NOTE: The vendor_src is where the full copy is kept
The vendor contains a minified version to save disk space.

On some system such as Debian and GNU Guix, vendoring or bundling is against the packaging policy, so this won't help.  No matter how you look at it, bundled dependencies are almost always a bad idea and is akin to technical debt (what happens the day a bundled dependency is no longer supported by the current Python?  You are either forced to do a large maintenance sprint to update them, or do development on the old bundled copies to bring them to compatibility).

@Apteryks once Python gets builtin TOML and YAML I am open to write a builtin implemention of Box and then remove all other dependencies.

@Apteryks vendoring is common on python projects, pip for example has some libraries vendored. As long as the licenses permits it is allowed.

once Python gets builtin TOML and YAML I am open to write a builtin implemention of Box and then remove all other dependencies.

Python 3.11 and above have tomllib. I don't see the problem with external dependencies on tomli or pyyaml/ruamel.yaml.

@gotmax23 this is going to change on the release 4.0, not sure when, but 4.0 will be a metapackage pip install dynaconf will bring [`dynaconf-core`, `dynaconf-toml`, `dynaconf-yaml`, `dynaconf-jinja`, etc..`]  so there will be some plugins and each plugin will bring its own deps.

each plugin will bring its own deps.

What do you mean by "bring its own deps?" Will those be vendored?

@gotmax23 for the plugins under the dynaconf/ org it will no more vendor anything, for external plugins it will depend on plugins.


Internal error on web app with large TS input

I am getting an error on https://app.quicktype.io/ with large input:
Internal error: Trying to resolve an allocated type reference with an incompatible one.

Input: https://raw.githubusercontent.com/Microsoft/TypeScript/master/src/lib/dom.generated.d.ts
Renderer: C# (does not seem to matter).

That internal error is fixed in #719, but we have a speed problem in gatherNames again.


Status Code: -1 -null

I have created and deployed the voice builder. But whenever i'm trying to Create a voice
It displays Status Code: -1 -null in response.
Please help me with resolving the issue.

Can you check the server log? or the response from the server in the network console

Hey thanks for following up..
The following error has occurred when I tried creating voice.
client.9fb23f6f72020334a561.js:50 Possibly unhandled rejection: {"data":"Failed to list jobs","status":500,"config":{"method":"GET","transformRequest":[null],"transformResponse":[null],"jsonpCallbackParam":"callback","url":"/api/jobs","headers":{"Accept":"application/json, text/plain, /"}},"statusText":"Internal Server Error","xhrStatus":"complete"}

Any help would be appreciated.

In GCP can you ssh into the ui VM instance,
then do a docker ps, find the name of the docker container running the UI,
the do docker attach <name>, then try to create a voice again and check the log in the ssh,

Hey @pasindud I tried your steps,

This is error log I can see.
Thanks for the follow up, I really appreciate it.


[BUG] iterating over an  IEnumerable<LiteFileInfo> errors out on the second element if the DB is opened in shared mode

For a test, I changed the connection mode for LiteDb from exclusive to shared. And then, operations on files started erroring out.
the code I'm using looks like this:
var fs = db.GetStorage<string>("audioFiles");
var files = fs.Find(u => u.Id.StartsWith(path));
foreach (var file in files)
{ // do something with file
}

this works fine if the connection mode is direct. If you then change the connection mode to shared, It fails when there's multiple files (at least two) - the first iteration works, on the second iteration gets you a LiteException with message

This engine instance already disposed

If you get a List instead of an Enumerable (var files = fs.Find(u => u.Id.StartsWith(path)).ToList();) it works even in shared mode.
I would expect the iteration to work in shared mode, too.
LiteDB version is 5.0.21 on .NET 8.0.7 on W11 Pro 2023H2

This does not seem like a bug. In the example, the code is iterating through a files collection in the foreach that can be modified during iteration (especially in shared mode where other instances can write to the db). Anytime one wishes to iterate through a collection, it should be cast to an innumerable that will not be modified (such as a list or array).
It is not guaranteed to work in direct mode without casting either (though less likely to hit the collection was modified exception). Shared mode has a lot of async plumbing.
A way to see it clearer perhaps is this
var fs = db.GetStorage<string>("audioFiles");
foreach (var file in fs.Find(u => u.Id.StartsWith(path))
{
// 1st iteration there could be 30 files...
// ....
// 10th iteration it could have changed to 32 files... the loop processing is now in no man's land
}

You are correct in your solution.

I can confirm, this is a really intriguing issue.
The following code gives you an error:
using LiteDatabase Database = new(new ConnectionString() {
    Filename = "Database.db",
    Connection = ConnectionType.Shared,
});
ILiteCollection<BsonDocument> Accounts = Database.GetCollection("Accounts");
foreach (BsonDocument Document in Accounts.FindAll()) {
    Accounts.Update(Document);
}
GD.Print("done");

void LiteDB.Engine.EngineState.Validate(): LiteDB.LiteException: This engine instance already disposed.

But you can remove the error by doing any of the following:

Replace Accounts.FindAll() with Accounts.FindAll().ToList()
Replace Connection = ConnectionType.Shared with Connection = ConnectionType.Direct
Remove Accounts.Update(Document);


Remove crosswalk texture when pedestrians are restricted.

Remove crosswalk texture when pedestrians are restricted.
As described here: https://www.reddit.com/r/CitiesSkylines/comments/50zcx4/mod_idea_tmpe_pedestrian_crossing_control_with/

already referenced here:
https://github.com/VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition/issues/16
I am not an expert in making textures so someone else would have to do this.


Can not login after changing password

From @anhlee24 on January 2, 2017 10:44
After i update new password, i can not login with new password until i restart the application.
My code:
var result = await _userManager.ChangePasswordAsync(user, userModel.CurrentPassword, userModel.Password);
Do you have any suggest?
Copied from original issue: aspnet/Home#1892

Sounds like they're caching a DbContext somewhere they shouldn't (perhaps singleton in DI?). That's my guess.

@brockallen  Have you met this issue before?
This is my startup.cs:
 services.AddDbContext<TCMSContext>(options => options.UseSqlServer(_config["ConnectionStrings:TCMSContextConnection"]));
services.AddIdentity<User, Role>(config =>
            {
                config.User.AllowedUserNameCharacters = null;
                config.User.RequireUniqueEmail = true;
                config.Password.RequiredLength = 8;
                config.Cookies.ApplicationCookie.LoginPath = "/Auth/Login";
                config.Cookies.ApplicationCookie.Events = new CookieAuthenticationEvents()
                {
                    OnRedirectToLogin = async ctx =>
                    {
                        if (ctx.Request.Path.StartsWithSegments("/api") &&
                            ctx.Response.StatusCode == 200)
                        {
                            ctx.Response.StatusCode = 401;
                        }
                        else
                        {
                            ctx.Response.Redirect(ctx.RedirectUri);
                        }

                        await Task.Yield();
                    }
                };
            })
            .AddEntityFrameworkStores<TCMSContext, string>()
            .AddUserStore<UserStore<User, Role, TCMSContext, string>>()
            .AddRoleStore<RoleStore<Role, TCMSContext, string>>()
            .AddDefaultTokenProviders();

@brockallen Have you met this issue before?

In other contexts, yes. Your config does not seems to be setting up a singleton, so my hypothesis seems incorrect.

I will try to find a solution, thank you :)

What does the initialization of _userManager look like in your controller?

@HaoK Here:
    ```

private RoleManager _roleManager;
private UserManager _userManager;
private SignInManager _signInManager;
    public AuthRepository(
        UserManager<User> userManager,
        RoleManager<Role> roleManager,
        SignInManager<User> signInManager)
    {
        _userManager = userManager;
        _roleManager = roleManager;
        _signInManager = signInManager;
    }

Does your AuthRepository have a lifetime that spans multiple requests?  That's most likely the cause.

Change your codes from:
var result = await _userManager.ChangePasswordAsync(user, model.OldPassword, model.NewPassword);
if (result.Succeeded)
{
   await _signInManager.SignInAsync(user, isPersistent: false);
}

to:
var result = await _userManager.ChangePasswordAsync(user, model.OldPassword, model.NewPassword).ConfigureAwait(false);
if (result.Succeeded)
{
    // reflect the changes in the Identity cookie
    await _userManager.UpdateSecurityStampAsync(user).ConfigureAwait(false);
    await _signInManager.RefreshSignInAsync(user).ConfigureAwait(false);
}

That would only affect things if someone was insane enough to store the password within the cookie...

@HaoK  you right, its not working.
I have register my context interface like this, does it have something wrong? :
public static class ServiceCollectionExtentions {

        private static void RegisterDataAccess<TEntityContext>(IServiceCollection services) where TEntityContext : EntityContextBase<TEntityContext>
        {
            services.TryAddTransient<IEntityContext, TEntityContext>();
        }
}

The default EF user store caches entities, so you can't reuse them across requests.  Basically you cannot setup a repository to be reused across requests with that store.  Its almost certainly your AuthRepository having a singleton lifetime.

@HaoK  i have found the reason.
In startup.cs, i need to get the instance of signInManager, so i create a instance like this:
private void ConfigureAuth(IApplicationBuilder app)
        {
            _userManager = app.ApplicationServices.GetRequiredService<UserManager<User>>();
            _signInManager = app.ApplicationServices.GetRequiredService<SignInManager<User>>();
}

and used like this:
private async Task<ClaimsIdentity> GetIdentity(string username, string password)
        {
            var result = await _signInManager.PasswordSignInAsync(username, password, false, lockoutOnFailure: false);
            if (result.Succeeded)
            {
                var user = await _userManager.FindByNameAsync(username);
                var claims = await _userManager.GetClaimsAsync(user);

                return (new ClaimsIdentity(new GenericIdentity(username, "Token"), new Claim[] { }));
            }
            return null;
}

But i do not know how to fix it. Do you have any suggest?

In startup.cs, i need to get the instance of signInManager, so i create a instance like this:

So you do have a cached reference. Elsewhere in the app, you should use DI to obtain references/instances of the UserManager.

@anhlee24
You need to create an scope manually (outside of the ASP.NET Core's life cycle). Otherwise it be treated as a singleton instance. Because there is only one scope here.
Try:
using (var serviceScope = app.ApplicationServices.GetRequiredService<IServiceScopeFactory>().CreateScope())
{
    using (var userManager = serviceScope.ServiceProvider.GetService<UserManager<User>>())
    {
          //
    }
}

@VahidN
Thank you for your reply.
Can you suggest how to use SignInManager?
Its show the error: "SignInManager type used in this statement must be implicitly convertible to System.IDisposable:  "
using (var signInManager = serviceScope.ServiceProvider.GetService<SignInManager<User>>())
                {
                    _signInManager = signInManager;
                }

Remove the second using statement here. It's unnecessary. Just use
var signInManager = serviceScope.ServiceProvider.GetService<SignInManager<User>>();

Ideally you inject the service in your controller, if you can't do that just get the service from HttpContext.RequestServices instead of caching it in an field,
context.RequestServices.GetRequiredService<SignInManager<User>>();

@HaoK its working! Thank you.

@HaoK your solution worked,
Please correct me: doing this means get me new instance of the signInManager service, not the one in the scope of the application.
Right?

@jwhijazi yup


Revise README; coordinate with project wiki

Coordinate README with project wiki (issue #32).

As part of this, I am also taking on issue #119

Thanks for taking this on Jim!
Some good examples to steal from:

https://github.com/codeforboston/clean-slate/wiki
https://github.com/codeforboston/clean-slate
https://github.com/codeforboston/voiceapp311
https://github.com/codeforboston/voiceapp311/wiki
ReadMe should be greatly shortened with most of it moved to Wiki, but the ReadMe should give people a quick understanding of what the project is about and links to dig in deeper.

3/10/2020
Have put in pull request for rewrite of README. As part of this, I have moved installation instructions and code formatting info to new wiki pages.


feature: support elasticsearch as output in Helm chart

It took a while for me to tackle #3401, but this seems to do the trick. I tried to avoid complex logic in the template (like @mrfelek suggested), but opted for a JSON schema that includes logic to do the same. In the process, I bumped the image from 2.21.0 to 2.23.11 (someone still needs to look at a CI for this, will try that later on).
I tested it by feeding it these values and looking at the output of helm template -f <test values files>:
# this should only render memory env var
zipkin:
  storage:
    type: memory

# this should error gracefully
zipkin:
  storage:
    type: elasticsearch

# this should render correct ES env vars
zipkin:
  storage:
    type: elasticsearch
    elasticsearch:
      hosts: hostA hostB
      index: fooIndex

If anyone actually running Zipkin with ES can confirm this (I dont), I would be thankful.

Hmm, the missing header warning seems to come from pom.xml, which is not mine. Anything I can do about this?

Tested on elasticsearch and works. I was not able to use old data from elasticsearch. New fresh data works.
Great job! Thank you

Merging as lint failure is unrelated. Fixing later.

PR here: https://github.com/openzipkin/zipkin/pull/3417
José Carlos Chávez
tir. 25. jan. 2022 kl. 10:38 skrev Jorik Jonker @.***>:

@.**** commented on this pull request.
In chart/zipkin-server/templates/deployment.yaml
https://github.com/openzipkin/zipkin/pull/3415#discussion_r791525758:

@@ -48,7 +48,15 @@ spec:
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
env:
- name: STORAGE_METHOD

well, it's merged now. Feel free to open a PR to fix this, though (I'm not
an official zipkin dev)
—
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/3415#discussion_r791525758,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYAVOEQUVTCAMONKKIF3UXZVQRANCNFSM5LT75CFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Dont autoscroll when terminal is updating

(Continue with the previous issue.)
I use jquery.terminal as a log viewer. When I checking the logs, I might scroll up to a position. And meanwhile I have a background service that might continue to put new log into the terminal. When new log is echoed to terminal, the terminal will scroll to bottom.
This is very annoying, because I have to scroll back where I was. Is it possible to disable scroll when echo or error is called?

I will add an option.

Option scrollOnEcho added in version 0.11.8.


Update dependency doctrine/annotations to v1.14.2

This PR contains the following updates:

Package
Type
Update
Change

doctrine/annotations (source)
require
patch
1.14.1 -> 1.14.2

Release Notes

doctrine/annotations
v1.14.2
Compare Source
Release Notes for 1.14.2
1.14.x bugfix release (patch)
1.14.2

Total issues resolved: 0

Total pull requests resolved: 1

Total contributors: 1

464: Specify second template parameter thanks to @greg0ire

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: composer.lock
Command failed: docker run --rm --name=renovate_sidecar --label=renovate_child -v "/tmp/renovate/repos/github/renovate-reproductions/symfony-flex-backend":"/tmp/renovate/repos/github/renovate-reproductions/symfony-flex-backend" -v "/tmp/renovate/cache":"/tmp/renovate/cache" -v "/tmp/containerbase":"/tmp/containerbase" -e COMPOSER_CACHE_DIR -e COMPOSER_AUTH -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w "/tmp/renovate/repos/github/renovate-reproductions/symfony-flex-backend" docker.io/renovate/sidecar bash -l -c "install-tool php 8.2.0 && install-tool composer 2.5.0 && git stash -- composer.json && composer install --ignore-platform-req='ext-*' --ignore-platform-req='lib-*' --no-ansi --no-interaction --no-scripts --no-autoloader --no-plugins && git stash pop && composer update doctrine/annotations --with-dependencies --ignore-platform-req='ext-*' --ignore-platform-req='lib-*' --no-ansi --no-interaction --no-scripts --no-autoloader --no-plugins"
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
fatal: detected dubious ownership in repository at '/tmp/renovate/repos/github/renovate-reproductions/symfony-flex-backend'
To add an exception for this directory, call:

	git config --global --add safe.directory /tmp/renovate/repos/github/renovate-reproductions/symfony-flex-backend


Make Thenable assignable to PromiseLike

Add overloads to Bluebird.Thenable.then method to correspond with ES6 PromiseLike interface.
See also https://github.com/types/npm-bluebird/pull/29#issuecomment-244891375

Any reason for not using extends PromiseLike<R>?

@louy PromiseLike.then returns PromiseLike, not Bluebird.Thenable

But, maybe we could just alias Thenable to PromiseLike.

@louy You shouldn't use extends PromiseLike because this definition will be used in a non-ES6 environment.

@blakeembrey PromiseLike exists in lib.es5.d.ts

@Strate The perhaps can it can be used then, I had never noticed that. I'm always a little wary, since they can change at any time. For instance, if the break that did occur happened, that would have meant it would break when updating TypeScript randomly. It's not a lot of fun to track TypeScript versions for testing.

@blakeembrey To avoid incinsistences between typescript's definition of PromiseLike, and bluebird's definition Thenable it is possible to alias Thenable to PromiseLike. But, Bluebird class should have overloading for each .then declaration to fix return type of that method.
BTW, I think this should be discussed separately.

@Strate I agree. I don't see anything wrong with the current change 👍


Define SSSOM profile for ValueSet mappings

Value Set mappings are mostly well supported by the default SSSOM profile. However, there are a few ideosyncracies around value set mappings, which are not served perfectly well by SSSOM:

Values in value sets are, more often than not, ENUMs rather than identifiers. This makes mapping them as "subject_id" awkward. Especially since whitespace is not allowed in subject_id.
Value set mappings would benefit from a few metadata elements which are out of scope for normal SSSOM. For example, lets say we want to refer to a specific value set in the context of one data model, it would be great if we could separately document the data model (and its version), and the value set (and its version). Right now, we have to squeeze both of these artificially into the subject_source column, which is not ideal (#43), for various reason (IRI syntax, context buried in some opaque URI structure). Also we would like to specifically convey that the value set A maps to the value set B - which is not exactly the same as saying subject_source, object_source (it implies a bit more, like a sort of "completeness" of the mapping).
Value set mappings could benefit from a well-documented set of curation rules, like "We decided not to map Other subtypes in our diseases (the converse would be to map them as narrow matches to their general counterparts).

@joeflack4 @mellybelly it would be great if you could add further requirements for valueset mappings here so I can get the ball rolling.

I am not actually an expert on this, but @sigfried is. @stephanieshong also. Context: By ValueSet mappings, what is meant is that if we have 2 related concept sets, we want to be able to map not just their concepts to each other, but other metadata between them, in a standard way.

@matentzn - do you have a standing meeting tomorrow morning with Joe? It might be helpful if we can chat about this in bit more detail?

@stephanieshong Not tomorrow, unfortunately. Our next meeting will be in about 2 weeks, but our agenda is usually very full. Maybe good to chat about this briefly over Slack., though I don't know how much of a priority this is yet.


Increased Capacities for Reference Files

Reference Input Sheet can now take remote, local, absolute, relative paths for GTF and FASTA files, in any combination.

BTW the paths and files within the toy reference sheet are local on my machine, so without changes to those paths to match your local machine it will not run.


Remove Habana references from docs

Follow up for: https://issues.redhat.com/browse/RHOAIENG-13415
Description
This PR remove Habana references from docs and update them we the recent new "amd.com/gpu" accelerators to reflect the current state.
How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

What about this one, should it really remain?
https://github.com/opendatahub-io/notebooks/blob/3f9561155bbc1f95a86ceb17693c7cd864086d90/manifests/base/README.md#L11

/lgtm

Thanks for the review. I removed the Deprecated as well.

/lgtm

/override ci/prow/images


Fix wrapping nodes with nested leaf nodes

Fixes https://github.com/facebook/lexical/issues/2647
The wrapping nodes function should skip nested leaf nodes if their parents are already wrapped (appended).

Thank you, appreciate the unit test!


Convert knockout toolbar component to React toolbar component

A prototype is implemented and ready for discussion. Move to 1.25 for further polishing and potentially start using it in product.

The work is done to keep the prototype feature up-to-date with the in-prod toolbar.

For 1.27, get component ready to use.


When namespaces begin with \ they should reset.

Laravel Version: 5,4

Description:
I'm working with the Laravel Passport.
In my code I have this:
Route::group(['namespace' => 'SomeNamespace'], function(){ //App\Http\Controllers\SomeNamespace
    Route::get('', function(){
        return 'something';
    });

    \Laravel\Passport\Passport::routes();
});

I've been getting the error:
[ReflectionException]
Class App\Http\Controllers\SomeNamespace\Laravel\Passport\Http\Controllers\AuthorizationController does not exist

Now I've found the problem, which lies in the Passport.php file
   /**
     * Get a Passport route registrar.
     *
     * @param  array  $options
     * @return RouteRegistrar
     */
    public static function routes($callback = null, array $options = [])
    {
        $callback = $callback ?: function ($router) {
            $router->all();
        };

        $options = array_merge($options, [
            'namespace' => '\Laravel\Passport\Http\Controllers', //Here
        ]);

        Route::group($options, function ($router) use ($callback) {

            $callback(new RouteRegistrar($router));
        });
    }

As you can see at //Here the namespace doesn't reset, like normal php would.
I understand that if it was Laravel\... instead of \Laravel\... it would make sense but this goes against php standards, wouldn't you agree?
I'll try find the problem in the Route files and create a pull request.

Pull Request #18081

#18081

Thanks for the PR, closing since it's a Passport issue and should be reported on Passport repo.

@themsaid It's not, check the pull request.

The root problem lays in laravel's RouteGroup.php

Why do you have \Laravel\Passport\Passport::routes(); in a route group? it should be in AuthServiceProvider.

I understand that, However I have multiple API Versions which are under different namespaces.
I understand I could do this in AuthServiceProvider but it's duplicating code:
/**
     * Register any authentication / authorization services.
     *
     * @return void
     */
    public function boot()
    {
        $this->registerPolicies();
        Route::group(['prefix/api'], function(){
            Route::group(['v1.0'], function(){
                \Laravel\Passport\Passport::routes();
            });
            Route::group(['v1.1'], function(){
                \Laravel\Passport\Passport::routes();
            });
            Route::group(['v1.2'], function(){
                \Laravel\Passport\Passport::routes();
            });
        });
    }

But it seems very impractical and hard to understand to future developers. This pull request would fix it and not cause any problems for others unless they created bad code.

I have other routes, each with their own namespaces and prefixes, I should be able to register my routes there.

I still believe this is a Passport issue

There's no way passport could fix it, because route group namespaces always check for the old namespace even if they begin with \. If you take a moment to read my pull request, you will understand.

Actually I don't think it's an issue, it's just how things are designed to work, it looks to me like some change that you want to apply to support a certain scenario, in this case you're free to open a PR to suggest the change or suggest it on the https://github.com/laravel/internals, it's where we keep such stuff :)

Understandable, however PHP Global spaces work like this, why should laravel work differently, just kinda goes against php practices


Mac: Check the return value of stat in PrjFS_DeleteFile

PrjFS_DeleteFile is incorrectly returning PrjFS_Result_EVirtualizationInvalidOperation when it's called for files/directories that do not exist.
This results in a lot of misleading messages being recorded in the GVFS mount process log files.
Example log message

[2019-04-08 13:18:54 -07:00] RemoveFolderPlaceholderIfEmpty_DeleteFileFailure {"Area":"GitIndexProjection","Folder Path":"Test_EPF_GitCommandsTestOnlyFileFolder","result.Result":"VirtualizationInvalidOperation","result.RawResult":536871936,"UpdateFailureCause":"DirtyData"}

Prior to this PR the functional tests recorded RemoveFolderPlaceholderIfEmpty_DeleteFileFailure 129 times.  With this change the message is not recorded at all during the functional test runs.

@kewillford I noticed this issue when looking at the logs for your #1014 PR.
I noticed this was getting logged a lot in your test run (as well as successful test runs) and the noise of this getting logged all of the time made it difficult to understand if there was a problem.


Just a comment (poor results) ...

... very interesting paper (http://aclweb.org/anthology/D18-1206 , with included examples), but I tried the online demo, http://cohort.inf.ed.ac.uk/xsum.html , with rather appalling results.
The textual sources for my tests were the abstract for one of my published papers, and the Google infobox for Nova Scotia.
Does the code for the online demo faithfully replicate the code in the paper?

Thanks for sharing your results. We have also different texts to play with our demo. Note that the demo uses a model which is trained on the XSum (BBC) dataset to generate an extreme summary (single sentence). The underlying model is not faithful to other datasets.

Excellent; thank you!  :-)

@victoriastuart    do you know how to train model  use  myself data ?  and how to combine fasttext or bert  to make the result better ? thank you

@shashiongithub   how to make this project support Chinese language ? thank

I have not explored these options in my models. I do encourage you to do so.

@shashiongithub  thank you


SABER blocks

Companion PR of https://github.com/JCSDA-internal/saber/pull/145
Update of:

src/mains/*.cc using SABER,
yamls,
references (tests results are not modified but the order and content of lines in log can be slightly different).

This PR can be merged now.


https://github.com/ZTCooper/show-me-the-code

I didn't understand your repository but I can give you some codes in 10 days


Large DMs are not displayed completely

Hi again,
Ok so the DMs are getting loaded but I noticed one problem that if the number of chats are huge, all of them are not getting loaded. For example I have a conversation which has roughly 10,000+ messages in it. The messages JSON is split into multiple files (6 in my case) and currently IGBM is loading only one of these 6 JSON files. I think it's coded to parse only the first JSON it finds per DM.
This is the folder structure of one of the DM threads:

And IGBM only loads the content from message_1.json.
Chronological order of messages is from message_6.json -> message_1.json, so IGBM loads only the latest messages from the backup. Previous messages are skipped.
I think one work around can be to manually merge all JSON files into one JSON file and then load this modified backup into IGBM. What do you think about this?
PS: Merging files is not a big deal for me but I thought I should let you know about the bugs.
Thanks for the wonderful repo.
Cheers!

Thanks for Mentioning , I'll Try Fix ASAP .


style: Prettier the HTML & CSS files

Description of what you did:
Prettier the HTML files.

My PR is a:

[ ] 💥 Breaking change
[ ] 🐛 Bug fix
[x] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

@starpit please, check if it is right: https://github.com/IBM/kui/pull/2043/commits/c3a0742c40dea265e574ce2ab7eaa07ef4e36a76

Also add CSS files now.

Maybe squash the commits the PR's ready? Thanks!

@myan9 done!

@myan9 and green Travis!


Need to include Controller and Options files in package

Think you may have to include into the latest version -
'package:flutter_native_admob/native_admob_controller.dart'; and
'package:flutter_native_admob/native_admob_options.dart';
Thanks.

Sorry IDE issue - was working with multiple Admob packages. Closed VSC and reopened which solved the issue.


src: fix filename misspelling

:broom: fixes a small misspelling in pipeline filenames

/kind cleanup

/lgtm
@lkingland can you rebase?

Thanks @lance, should be GTG now

/lgtm


Feature Request: Linux Support

In short, I love the functionality of Browser Tamer and would absolutely love to also have it on Linux.
I split my time between Linux (Fedora in my case) and Windows and often wish I had Browser Tamer's capabilities in Fedora but haven't been able to find any software to provide equivalent capabilities.
From what I can tell, it should be reasonably possible to parse available browsers by checking for installed .desktop files with either x-scheme-handler/http or x-scheme-handler/https in the MimeType value. Unfortunately, I don't know any C++ so have very little idea how Browser Tamer is currently implemented and whether that would transfer over or not.

Thanks for the feedback! Unfortunately majority of the functionality is system related and Windows specific in this case. I think the only piece that can be shared is UI for configuration, but everything else is completely different in Windows/Mac/Linux.


Video Link is Dead

[Enter feedback here]
Ironically, because here I am now, on GitHub, the link provided in:
"Azure DevOps Services supports integration with GitHub.com and GitHub Enterprise Server repositories. Azure DevOps Server supports integration with GitHub Enterprise Server repositories. For more information, see the following video, Using GitHub with Azure DevOps."
not only takes you to a Streams realm where you are not allowed to use a "personal account" (doesn't say but implies you need a institutional account), but, get this, the notice that the "video could not be found. it may have been removed.".
Sweet.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2197a6a8-ecda-b647-6cbf-c08defccc54b
Version Independent ID: c66fa15d-cb16-b734-d73b-701acf368f95
Content: Plan, code, collaborate, ship applications - Azure DevOps
Content Source: docs/user-guide/what-is-azure-devops.md
Product: devops
Technology: devops-new-user
GitHub Login: @chcomley
Microsoft Alias: chcomley

@hcovitz - Can you try again? I can follow the link. The video plays. I don't get that message.
If you try again and get the same message, could you do a screen cap?
Also, when you say that you're on GitHub, do you mean that you're trying to access it from here? MicrosoftDocs/azure-devops-docs/blob/main/docs/user-guide/what-is-azure-devops.md Links are only intended to work from the Docs site.

I was trying to access from this article:
https://docs.microsoft.com/en-us/azure/devops/user-guide/what-is-azure-devops?view=azure-devops
... which is how I arrived at thsi "issues" section on GitHub (since at bottom of that doc.microsoft.com page if you click "Feedback for this Page" it takes you to this GitHub repo.
Screen captures from different environments, including one from a company that happened to have an enterprise license as well as a MS Streams setup (which is how I got the "video could not be found" link, otherwise I'm stopped cold by either "no personal account sign in" verbiage or, using another enterprise that had a MS license but not their MS Streams setup appropriately? who know?  but I get the invitation to, I can only guess, setup their MS Teams ?).

The fact that this is intermittent, and that apparently some people can access it, is significantly more disturbing.

@hcovitz Thanks for taking the extra time on this. We'll see what's going on -

Hi @hcovitz, I've looked into this issue and determined that the linked video appears to be internal to Microsoft and was added a few years ago. I'm sorry for the confusion and frustration this may have caused. I've replaced the video link with a link to the following article: Azure DevOps and GitHub integration overview. Thanks so much for your feedback. This issue will automatically close once the update goes live. Feel free to @mention me if you have any further questions. Thanks again!


Added Huffman for Lua

Still need to add to md file and also I might want to add more comments in some of the functions.

Meant to make PR in actual repo
Closed


mutateAndGetPayload get rootValue

How can I get in method mutateAndGetPayload rootValue ?
graphQLServer.use('/', graphQLHTTP((req) => (
  { schema: Schema, rootValue: { req }, pretty: true }
)));

I missed its there sorry


Upgrade to Idris2 0.7.0

Upgrade to Idris2 0.7.0

Release 0.7.0 is now available! https://github.com/mmhelloworld/idris-jvm/releases/tag/latest


Device tracker for o2box

This PR adds support for the O2Box, similar to the one shown here:
https://hilfe.o2online.de/docs/DOC-1332

Addressed the comments, updated to dev

Can you add your file to .coveragerc and it seems that CI reported some style violations: https://travis-ci.org/balloob/home-assistant/jobs/102450052#L187-L214

This is an automated response to help you succeed in getting this PR merged.

Whenever CI fails, the reason for failing will be at the bottom of the log. Each Python version performs different tests so it can be that only Python 3.5 fails. Your PR cannot be merged unless CI is green!
Always make sure your fork is up to date before you create a new branch. No "merge upstream" or "merge dev" commits. Also rebase on the dev branch before creating a PR.
Squash your commits when the PR is ready to be merged.

If your code communicates with devices:

Use a 3rd party library for communication. Add dependencies via REQUIREMENTS variable (example).
Only import your 3rd party dependencies inside functions that use it (example).
Run script/gen_requirements_all.py to update requirements_all.txt.
Add your new files to .coveragerc

If your code does not depend on external devices:

Write tests to verify your code works

Closing this PR as it has gone stale.