Screen Reader announces terminal output over and over

VSCode Version: 1.45 insider
OS Version: Windows 10 19H2.

Steps to Reproduce:

Turn on a screen reader like NVDA.
In VS Code, Open a terminal. Listen as screen reader reads the initial PowerShell output, or Bash, or whichever terminal is being used.
Issue a command. Listen as the screen reader starts reading everything from the top instead of just reading the newly added text.

Does this issue occur when all extensions are disabled?: Yes
CC @isidorn

I actually tried this out and could not reproduce both with VoiceOver and NVDA.
For me only the last output is being read.
@MarcoZehe do you have some settings set which might influecne this. Can you also repro with some other screen reader?
Also assigning to @Tyriar so he tries to reproduce

Hm, OK, there seem to be two issues here. One, where I indeed issue a few commands and the output is spoken, I hear a lot of information twice. Once as the output, and once as the same output plus the reappearing prompt for input.
The second is that one parent, an item with classes "terminal xterm focus", contains a lot of output in its accessible name that is much older than what is currently being displayed in the grandchild list of outputs. That gets spoken whenever focus transitions into the terminal pane, for example via the F6 key. I was confused by these two sources of output, which at one point seemed to intermix probably due to me being too fast in switching panes and issuing commands.
But the double-speaking of output I can definitely reproduce reliably.

I also cannot reproduce using the orca.
I tested using the following command: cat / etc / passwd
Except for a message that I can't quite understand, everything seems to have worked well.
The message I didn't quite understand looks like this:
to much output to announce, navigate to rows manually to read.

One, where I indeed issue a few commands and the output is spoken, I hear a lot of information twice.

@MarcoZehe do you have the terminal.integrated.windowsEnableConpty set to something?

The second is that one parent, an item with classes "terminal xterm focus", contains a lot of output in its accessible name that is much older than what is currently being displayed in the grandchild list of outputs.

Do you mean the accessible list does not accurately reflect what's on screen?

That gets spoken whenever focus transitions into the terminal pane, for example via the F6 key. I was confused by these two sources of output, which at one point seemed to intermix probably due to me being too fast in switching panes and issuing commands.

Does the entire terminal viewport read when you focus the terminal? The intent is just the prompt line is read.

@MarcoZehe do you have the terminal.integrated.windowsEnableConpty set to something?

It is set to True/the checkbox is checked. I didn't make any change in this area, and I am using a new enough version of Windows 10.

The second is that one parent, an item with classes "terminal xterm focus", contains a lot of output in its accessible name that is much older than what is currently being displayed in the grandchild list of outputs.

Do you mean the accessible list does not accurately reflect what's on screen?

I think the list does, it's the grandparent whose accessible name reflects other stuff.

Does the entire terminal viewport read when you focus the terminal? The intent is just the prompt line is read.

Not always. But sometimes, and sometimes it is read twice. Or the new text that comes in after I issue a command is read twice. Without being able to visually verify what is happening, this is hard to tell. I am totally blind, so cannot give you any visual correlation.

It is set to True/the checkbox is checked. I didn't make any change in this area, and I am using a new enough version of Windows 10.

Ok, just checking. That means if you're on Windows 10 1909 that you're on the new system. For this it may just be a problem with how the terminal works on Windows as we announce whatever is coming from the backend that tries to emulate unix ptys, and sometimes it reprints the screen on Windows 10 for backwards compatibility reasons.

I think the list does, it's the grandparent whose accessible name reflects other stuff.

Again is it the live region causing problems? The terminal announces to screen readers using alerts because not all data is rendered to the accessibility tree, consider when running the tree command for example. That's an enormous amount of data and we simply cannot add all of that to the DOM.
https://github.com/xtermjs/xterm.js/blob/c1e618fc3b4b8ace77289be3f1cfe0fb9c6b9366/src/AccessibilityManager.ts#L291-L297
@isidorn thoughts on this? Whenever anything is changed in the terminal, the accessibility tree is reconstructed (used for navigation mode) and any  new characters are read via the alert by appending it to the alert's contents. Note also that this data comes in asynchonously in chunks, so we need to be able to append the data and for readers to announce it correctly if we only have "hel" initially and then add "lo" later for "hello".

@Tyriar I think it makes sense to read new content that is coming in via an alert, because the focus did not change, all the time you are in the input.
Might it be due to the async some duplication happens?
Maybe we compare to what some other terminals are doing?
@marcozehe might have some details how mozilla does this for their dev tools terminal

We actually do it via an aria-live="polite" on the output container, in this case the div with role "list" that contains the output. And maybe experiment with the aria-atomic attribute here so stuff doesn't get read in a weird way.

@MarcoZehe all good ideas, thanks!
@Tyriar can we incorporate maybe some of this? So at least change from assertive to polite. aria-atomic might aslo be interesting. More details here https://w3c.github.io/aria/#aria-atomic

I just again encountered this last night. The action I was taking was:

Open the VS Code checkout folder.
Open a terminal.
Enter git pull upstream master.

Result: That spoke OK.

Typed yarn to update dependencies.

Result: Output was repeated over and over, always starting with „Yarn install v1.19.2“...

So it seems to be a bit dependent on what commands are being issued. The yarn command in particular seems to be repeating text a lot.
Requesting that this be reopened.

So for yarn in particular, the way it works is by reprinting several lines constantly to indicate progress.
I know this is an awful experience and even proposed a way to solve the issue generally at terminal-wg by introducing something similar to aria label in html, it didn't get much traction though and would need widespread adoption to be useful https://gitlab.freedesktop.org/terminal-wg/specifications/-/issues/18

I don't think there's anything we can do here to action this. On Windows conpty sends us the text to print, and we announce it as it comes in. Under certain circumstances conpty may reprint the screen which would result in reading everything, but we can't tell the difference between that happening because of conpty or the backing process. The good news is that conpty has been steadily improving these edge cases over time so you should expect a generally better experience as you get updates to Windows.


 It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 006699d8-d208-ec2e-9b14-ec6c5d4bd71f
Version Independent ID: b9ad346f-2140-8d7b-c5aa-b5e4d7bae866
Content: Quickstart: Configure an app to access a web API - Microsoft identity platform
Content Source: articles/active-directory/develop/quickstart-configure-app-access-web-apis.md
Service: active-directory
Sub-service: develop
GitHub Login: @mmacy
Microsoft Alias: marsma

@rmtexas we have taken your feedback but I am closing this out because the language here is unnecessary.
cc @mmacy


NFT tutorial contract comment corrections

Changed comment on line 208 of NFTv2.cdc to correctly state that only a single field is initialized in the init function (likely a remnant of copy/paste from example one using metadata and id).
Changed comment on line 461 to correctly reference printing NFTs owned by account 0x02 instead of 0x03
Changed comment on line 463 to correctly reference getting the public account object for account 0x02 instead of 0x03
Closes: #???
Description

For contributor use:

[x] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

@theBusBoy Awesome, thanks for the PR.


Create github page with documentation

Should contain function documentation, demo as well as detail all features

https://support.google.com/docs/table/25273


Need function comparable to robots.txt, but to guide podcast indexers

This namespace element was motivated by a situation where a podcast approached podcastindex, noting that they had two feeds for their podcast (one for most people, another motivated by their Chinese audience), and wanted the latter to be omitted from podcast index.  This request was forwarded, and handled manually.  But it would be nice if a podcast RSS feed could directly annotate whether it should be indexed, without human intervention.
This problem has similarities to the robots.txt file, used to guide whether search engines should index a site in whole, part, or not at all.  But since an RSS feed is complete unto itself, most likely one or so XML fields is preferred to a separate file.
The goal is to permit a podcast's RSS feed indicate which indexers should scan it and publish results.  Alternatively, it might be helpful to indicate which indexers should not scan/index it.
Each podcast indexer is probably associated with a standard domain name (spotify.com, podcastindex.org, etc.).  This pattern match allow/disallow will most likely operate with respect to this domain name.
This ticket will serve as a focus point for discussion of the mechanism.  When RSS element name(s) are published (or some other mechanism is accepted), it can be closed.

This looks a great idea. There is already an iTunes and a Google Play block tag - both named after expired brands, interestingly enough. Frustratingly, Google recognise both iTunes and Google tags as blocking.
This looks like a near replication of the podcast:id tag, perhaps, using slugs for each service and the command "block". Most certainly one for phase 2. Do you feel up to writing a suggestion?

PS: perhaps here's where my timezone works better. @vandys is this what you had in mind? I'm making this up as I go along:

<podcast:block (allow="[service slug]") (block="[service slug]") />
(optional - in channel tag only)
A block request, to one or more platforms, or an overall block request for all platforms. This is intended to allow a podcaster to request not being listed in a specific directory - or to request not being listed at all. It uses the service slugs data which already exists for other elements. Support of this tag will benefit podcast directories by significantly lessening the amount of "please could you remove my listing" emails.

URLs with HTTP Basic Auth credentials - like<EMAIL_ADDRESS>- should not be indexed by any platform for public consumption. (They may be indexed for individual use, but should never appear in search).
Users of this tag should also be aware of the proprietary <itunes:block> and <googleplay:block> tags.
Use of this tag is not a guarantee.

To keep things simple, for the first phase this is not intended for use at episode level.

I get cognitive dissonance when a "block" section has an "allow"!  I'm also a complete hater of XML, but since we're using it here, lists should really be sub-elements?
podcast:indexers
pandora.com
podcastindex.org

</podcast:indexers>
If podcast:indexers is absent, or you fall off the end of the list, you allow.  Matches are by a domain (so that we're not just playing to entities big enough to own portions of the RSS podcast namespace).  An empty block/allow serves as a default answer, so in this case default is to block indexing.
Treatment of feeds requiring authentication is outside the scope of this ticket, which is focused on indexers/block/allow.  A given indexer, if it has laid hands on an authentication token, has probably also entered into an agreement which will determine if/how they can use that token.

Is there a compelling reason not to simply rely on robots.txt? It feels like this proposal reinvents the wheel unnecessarily, when many podcast indexing services already respect robots.txt correctly.
This is a very deep rabbit hole, as well. One may want to block one service from a company but not another (e.g., Google Play versus Google Podcasts). Services publish their bot names for use in robots.txt. Prescriptively defining slugs for third parties limits their ability to accommodate their own product development.

Is there a compelling reason not to simply rely on robots.txt?

I don't know how many thousands of feeds live on https://feeds.captivate.fm or https://feeds.buzzsprout.fm or wherever: robots.txt seems a bit unwieldy. How would you see this working?

One may want to block one service from a company but not another

Yes, indeed. The slugs should be service slugs, not companies.

(e.g., Google Play versus Google Podcasts)

That's a bad example - Google Play is closing - but a better example is Google Search vs Google Podcasts. I'm aware of one, large, international podcasting organisation who would love
<podcast:indexers>
  <allow>google-podcasts</allow>
  <block>google-search</block>
</podcast:indexers>

...but I agree, the slug list (which I'd really like to be a generic one for all our uses here) should ideally be based on product, not on company.
With the above, I've no idea what happens if apple-podcasts shows up. Are they allowed? Or blocked?

Services publish their bot names for use in robots.txt.

They really don't, though. I've spent the last six months reporting countless bugs for non-existent RSS useragents. Which, depressingly, has its own slug list!

Prescriptively defining slugs for third parties

Everyone is welcome to define their own slugs; but without someone making a decision, we can't offer podcasters the control they want or deserve - so a prescriptive start is probably the pragmatic choice.
What's the best way of proceeding? I'm a real fan of giving podcasters control - or, at least, requesting that control. I've written articles about it. Do you have a suggestion for how we reword this?

@jamescridland I think you're proving my point. Robots.txt services the exact use case presented here: controlling access to crawlers. If a crawler is going to ignore robots.txt, it'll ignore this. And any crawler which respects robots.txt does indeed publish information on how to target it in a robots.txt.
I, as a developer, shouldn't need to register a slug in the spec so that people can block me. I'll just publish that myself. This even works at a product level: I mentioned Google services because they supported that exact functionality. Is there a meaningful argument to show that this proposal adds significant value over the status quo?

@jamescridland I think you're proving my point. Robots.txt services the exact use case presented here: controlling access to crawlers.

robots.txt is highly tuned to web servers, and bots accessing web pages.  I think we can agree that User Agent can indeed reflect a unique crawling service (I don't know if "slug" is an industry term).  But unlike a web server, we can not assume that because you have an RSS feed, you have the ability to store files anywhere else on the hosting server of the RSS.  So we really do have to store it within the RSS XML itself.
Unlike a web server in general, there is no hierarchy of pages within an RSS feed for a podcast.  We want you to include the podcast, or not.  Thus we end up with XML contents in the RSS feed expressing the policy--an enumeration of your allow/deny rules intended to guide a given would-be indexer.

I like this idea. Maybe instead of allow inside the tag, it could be except. Then it reads easily, "block everything except this."
However, I can anticipate some grammatical confusion over except and accept.

@mattbasta I'm finding your language quite aggressive, and I'm not sure why. I'd really like constructive rather than destructive comments here.
There's currently two tags out there in RSS - an iTunes block tag and a Google Play block tag. What this seeks to do is make a tag like that work for all services, not just those two.
Anchor hosts over 600,000 podcasts on the same domain. A robots.txt offering individual control for every single podcaster and every single possible service out there would be unwieldy and extremely large.
Every other part of a podcast's metadata is within the RSS feed. To require a parser to also request a robots.txt doubles the amount of HTTP requests made, and complicates existing parsers. I am unaware of any evidence that anyone - with the exception of Google - respects robots.txt for podcast ingestion.
Podcast parsers have not published their useragents - I'd know, since I've spent a long time cataloguing them. Many were simply using default library UAs. I'm proud of the work I've done here; and with the published list we can make a provider list easily.
Further, this is good for the entire ecosystem. If I object to Overcast having my podcast in it, I have no control currently apart from hassle Marco. With support for this tag, it removes that friction entirely.
If there's a chance of some constructive commenting - perhaps showing how a sample robots.txt might work - then I'd be very willing to consider an alternative. But the above concerns are real and need be addressed in a constructive and polite way, please.

@jamescridland My goal here is to have a productive technical discussion. I run a service which ultimately needs to write a parser to respect (or ignore) this, so I'm the target audience for these rules. When defining a spec, it's important to ask whether there's an actual problem being solved, or you end up with something that doesn't help or introduces excessive complexity.
I don't want you to feel attacked by my comments, but defining a spec that's to be broadly used also necessarily involves asking the question "does this help?" I'm trying to be "constructive" here by raising unanswered questions about the premise of a proposal that I am the intended audience of. None of us want this project to go the way of ECMAScript 4, XHTML 2, most of Dublin Core, etc.

Will Apple and Google replace their tags? Or does this just add "yet another tag"?
Will other apps adopt this or simply ignore it? What incentive do they have to respect it?
Does this make podcasting more siloed? Should podcasters have the ability to block individual apps, for monetary reasons or otherwise? Does this exacerbate the issue of platform-exclusive shows?
How does this benefit listeners?
The existing block tags apply to directories, not on-device apps. You can still manually subscribe to a feed with the block tag set. How, then, does this offer an improvement over robots.txt, which can be cached? Even if every show on Anchor blocked one or more directories, the robots.txt would be only a few megabytes un-gzipped—likely smaller than many cover art JPEGs.
Since directories need to opt-in to blocking, and must publish something about what you need to do to block them (even a slug), what advantage does this offer over robots.txt?
Many apps just use Apple's directory. Blocking Apple already blocks many other apps by default. If this allowed blocking individual apps, you'd be able to find a show (from Apple), but attempting to subscribe would error if the app didn't ignore the tag. Is it an acceptable consequence that listeners will have this experience?

This group should strive for rigor, since you can't take a spec back once it's out in the world. And as someone with skin in the game, I'd appreciate that hard questions are not avoided.

@mattbasta I appreciate your thoroughness, but you’re systematically pissing off every person here with “should” language and a stance that you know everything about everything. We’re not designing HTML6 here. This is some podcast tags.  Every association and standards body that has tried to do this for 10+ years has failed because of the flame wars and endless debates over perfection. I’m not going to let that happen here again.  Everyone will get upset and leave. That’s how it always ends.
At the end of the day you don’t have to support this namespace. You can ignore it if it doesn’t meet the needs of you or your customers. I’m know some hosts will. If you think we’re all too short sighted or incapable to make this work then please go form a group and start your own thing.  If it’s successful we will support it and you with no hard feelings.

@mattbasta We all have skin in the game here, that's the point of these discussions. I'm delighted that you have 0.252% of the podcast hosting market: but what I've appreciated in this group is that all contributors have been treated, so far, as equally valued. I'd ask you to strive to do the same, please.
In answer to your questions:

Will Apple and Google replace their tags? Will other apps adopt this or simply ignore it?

You can say the same about the whole namespace. I have no control over Apple or Google's proprietary nametags or their use of them. I have no control over other services. But, by producing something that is inclusive of their own services, while offering more control for podcasters (including your customers), thus benefiting the ecosystem as a whole, this is a step forward. And most podcast hosts and apps want to do the right thing by creators.
Apple requires a legal contract to be signed between a podcaster and Apple for carriage on Apple's platform. Most other services take RSS feeds - whether found using a crawl or pulled from other directories - and no such contract has been signed for distribution. (This massively confuses those from the broadcast world, who are used to carriage contracts, incidentally).

Does this make podcasting more siloed? Should podcasters have the ability to block individual apps, for monetary reasons or otherwise? Does this exacerbate the issue of platform-exclusive shows?

Yes, creators should have the ability to control where their content appears. But also podcast apps should have the knowledge that they're doing the right thing by creators.
When Luminary came onto the scene, many podcasters decided that they were against Luminary and that they did not want their shows listed on Luminary. The only possible way for them to do this was to contact Luminary by email and ask. A comprehensive blocklist/allowlist would allow a podcast host to, with one click, deny access to Luminary - assuming Luminary were acting responsibly by supporting this tag. (For the record, I'm very cool with Luminary listing my show.)
From the reverse angle, Luminary can feel confident scraping RSS feeds, knowing that there is a simple and well-documented method for any podcaster to, within their RSS feed, ask Luminary not to carry their show.

How does this benefit listeners?

Listeners can know that the podcast host that they listen to is cool with their show appearing on this service.

The existing block tags apply to directories, not on-device apps.

Yes, correct. The aim is to block appearance in the directories used in the apps, and from apps like Luminary profiting from creators work against their wishes.

How, then, does this offer an improvement over robots.txt

Every part of a podcast's metadata is within the RSS feed - that's the point of an RSS feed. To require a parser to also request a robots.txt doubles the amount of HTTP requests made, and complicates existing parsers. I am unaware of any evidence that anyone - with the exception of Google - respects robots.txt for podcast ingestion.
We put the mimetype of the audio file, its duration and its bytesize, into the RSS feed - rather than require the parser to go and inspect each and every audio file. We could strip all that out, and require the parser to go and load the audio file's HEAD to find out this data. We don't, because every part of the podcast's metadata is within the RSS feed. Control of distribution is already there for iTunes/Google. This proposal seeks to extend this control for everyone.

Many apps just use Apple's directory. Blocking Apple already blocks many other apps by default.

Perhaps this isn't clear enough. Apple's directory, or the Podcast Index, or Blubrry's directory, gives other people (like Overcast) a selection of RSS feeds to go and parse. Overcast then attempts to parse these RSS feeds itself, to run its own directory and make these shows available in Overcast's directory.
For other creative endeavours, content is individually licenced to distribution - done by contracts and lawyers. Podcasting is relatively unique, in that once you sign a legal contract with Apple to get listed, you appear in all manner of other apps automatically: some of whom you may decide, as a creator, that you don't want to be in. This proposal offers that choice for the creator, which is the right thing to do for podcast creators - who, ultimately, are the only people who should be making these decisions.
Pinecast may not wish to offer this control to your customers. That's absolutely fine, and within your gift to do so. Support for this feature, just like others, is a balance of the cost of implementation vs the competitive advantage that support of these tags offers.

To help this discussion, from the last 90 days of site logs, please find enclosed a complete list of all robots that have checked robots.txt at least once a day. I serve my RSS file from here.
I can see NPR and Googlebot (used for Google Podcasts), and possibly Amazon Alexa (though their bot is used for many things). However, I see no other podcast services here. Let's move on from this debate.
robots.txt

Time to try and list the takeaways from this discussion:
<podcast:indexers> with allow/block, as compared <podcast:block-indexers> with <except>this-one</except>
   They are certainly logically equivalent, but I feel like negative logic will confuse most mortals

<accept>domain</accept> is not sufficient; there are _parts_ of an entity which you might want to deflect, while
 permitting others.  I need clarity on "slug", or do we use a more generic "service name" as what to match?
 How do we say yes to Google Play, but no to Google search?  Perhaps "domain[-service]".  So:
  <accept>google.com-play</accept>
  <block>google.com</block>
 then just the Play part is accepted, all other Google services are requested to steer clear.
 By prefixing with domain, we don't have to get into the registry business; let the registrars handle that!

 I always shy from regular expressions, so would like to make this a string/substring match semantic if we can
  make it sufficient to the task?  I also always try to normalize the semantics to lower case, to avoid the tedium
  which always otherwise arrives.  (Precedent is DNS names, which are case insensitive.)

Thanks.
The service slugs are in here which are used here for other things. Would they work?

The service slugs are in here which are used here for other things. Would they work?

There will eventually be ones which are substrings of others, which I would prefer to avoid.  Then there's the question of industry acceptance, and also the question of who "owns" a value, and how are disputes resolved?  This is where FQDN solves lots of problems for us.

This will be a phase 2+ item for sure so that we can have plenty of time to refine it.  I'll add a wireframe to phase 2 just to have a placeholder there and we can bang it out going forward in a new issue.


Encrypt RSA key with SM2

SM2 key can theoretically wrap RSA keys. Openssl does not show an error when encrypting an RSA key with SM2. It is silently failing. However, the decrypt operation shows an error because the encrypted RSA key is invalid.
Here are the steps to recreate this issue:
This is on OpenSSL 3.0.8 7 Feb 2023 (Library: OpenSSL 3.0.8 7 Feb 2023)
Generate RSA-2048 key in PKCS#8 format:
openssl genpkey -algorithm RSA -pkeyopt rsa_keygen_bits:2048 -outform DER -out rsa_csk.der
openssl pkcs8 -topk8 -in rsa_csk.der -outform der -nocrypt -out rsa_csk_pkcs8.der

Generate SM2 key:
openssl genpkey -algorithm EC -pkeyopt ec_paramgen_curve:sm2 -out sm2-key.pem
openssl pkey -in sm2-key.pem -pubout -out sm2-key-public.pem

Encrypt and decrypt the RSA key with SM2 key pair:
openssl pkeyutl -encrypt -inkey sm2-key.pem -in rsa_csk_pkcs8.der -out Encrypted.bin
openssl pkeyutl -decrypt -inkey sm2-key.pem -in Encrypted.bin -out rsa_decrypted.bin

decrypt operation fails because Encrypted.bin is invalid. The main catch is the encrypt command does NOT throw an error

The encrypt/decrypt operation can encrypt only limited size data. Yes, it would be nice if the data size was checked and error printed.

Can you give me an example on how to use cms in this case?

I believe there are several examples given in the openssl-cms man page


Application CSS is overridden by Trumbowyg Content

Whenever custom CSS styles are applied to the Editor it will override the default CSS of the application running the editor.
Simple CSS like below will shrink the font of nearly the entire application
body{font-size:.7em}

What is the best way to implement trumbowyg in a rails application so the CSS does not override the default application CSS?

The best way is to set the font-size in the Trumbowyg scope :D
I need to do that ASAP. Thanks!

Hum, I don't understand the bug. Maybe you need the reset option? If you want customize Trumbowyg content you need to select .trumbowyg-box or .trumbowyg-editor insteed of body.

the trumbowyg editor allows a user to create custom HTML content. Sometimes they may want to use external stylesheets like bootstrap for example to style their custom HTML content.
If the application running and rendering the trumbowyg editor has a custom version of bootstrap or any CSS for that matter, it will all be overridden by the user linking the stylesheet.
Here is workflow of how to reproduce the issue.  Click the View HTML and add some sample CSS style like so:
<style type="text/css">
  body{font-size:.7em}
</style>

Then click the View HTML button again, and watch all your body fonts shrink to .7em because the user applied some custom CSS to the HTML page they were creating.
It doesn't seem right that CSS within the editor should be able to override the applications CSS when previewing the HTML.
I do fully understand that I could leverage .trumbowyg-box or .trumbowyg-editor but sometimes this is irrelevant if the user wants to link and external stylesheet like bootstrap or foundation, that CSS would override and custom bootstrap or foundation CSS that app was running.

Hum... that's a strange usage but that's linked to #160
I work on option to enable/disable style and script tags. That's what do you want?

The editor still needs to allow for style tags to work properly, but only scoped to the content within the wysiwyg editor.
This HTML content within the editor is rendered elsewhere in a view, which is why the styles still need to work. It just shouldn't allow the styles to override the apps default CSS that is rendering trumbowyg inline.

I can't scope the style to the editor because without add a div tag arroud the content which is in the textarea which is sent in form. No?

Is there some way to render trumbowyg in a way similar that functions like a seamless iframe where the CSS within the editor is segregated from that of the running application?
This seems quite brittle that the content within the editor has the ability to manipulate the entire view of the application.

It's useless to scope the style in editor if it's not scoped in your result page.
If you don't want style tag, I work on it. If you want scoped styles I don't know how to filter CSS rules without a lot of code. So I think keep it simple.

yes props need to be able to go to every levels so that some css's can be overridden, the resetcss tag does not seem to work.

Feel free to wrap the editor with an iframe:
https://github.com/Alex-D/Trumbowyg/blob/develop/index.html#L371-L405


remove redundant else

expressions like:
function func() {
    if (a) {
        //...
        return x;
    } else if (b) {
        //...
        return y;
    } else {
        //...
        return z;
    }
}

can be safely rewritten as
function func() {
    if (a) {
        //...
        return x;
    }

    if (b) {
        //...
        return y;
    }

    //...

    return z;
}

question 1:
why in line 215 inside the transitionend method the local variable end is being assigned to the value of a timer?
question 2:
inside parseValue should we just test for equality with string literals 'false', 'true'...otherwise a string like 'untrue' would be converted to the boolean true.
kind regards

On question 1:  No idea, doesn't seem like we need it.
Question 2:  great question... string literals is a good idea, because otherwise anywhere someone is passing in text content we could have a bug if we have a longer sentence containing true or false.
For the expression transformation, I'd be curious to know if you have any reason for stripping the elses beyond them being unnecessary.  Stylistically I think we're inconsistent on this, but lacking additional information I'd err on the side of being explicit.

Hello @kball,
it could be seen just as a trend, but i have found that early returns inside conditionals and inner loops end in clearer/cleaner code. But you can treat this just as a styling proposal and kill this PR at once ! :-)
kind regards.

Given this doesn't match the rest of the code styling, going to kill this.  However would be interested in a PR updating to string leterals

@kball
here it is https://github.com/zurb/foundation-sites/pull/9279
kind regards
the second commit encountered a travis error but it seems unrelated (i only added 3 spaces after 3 if)

78 passing (2s)
1 failing

Reveal "after each" hook:
Uncaught TypeError: 'null' is not an object (evaluating '$element.find') (file:///home/travis/build/zurb/foundation-sites/_build/assets/js/foundation.js:673)

maybe I'll close and reopen to trigger a new travis check
kind regards

The error is unrelated, digging into it.

@kball
in the 1st build yes.
the 2nd (phatntom-js install) is unrelated too, but it's not uncommon in foundation-sites travis tests. I (and other devs) encountered it a few times.
kind regards


Issue133/cstr function call

I am fixing 3 TODO and one brackets.
Also noticed some issues with Dispatch 10 & 12 locally:
JobOut(1100364377616711936,1,3)
versus
JobOut(1100364377616711936,5,3)
Yet the processor of JobData(1100364377616711936,"PD0",1797,8856) is definitely not always 5.
Maybe some substitution is done to much ....

DisPro10 and 12 failed locally, too.

Same TODO both fixed and new ;-(
TODO found
New
286        elemShow (t,p)  | p > 0 = "( " ++ pshow t ++ " ^ "  ++ show p ++ " )"   -- TODO: TorXakis doesn't support Power (not even x ^ integer)
Severity: Minor
Found in sys/defs/src/TxsShow.hs by fixme

TODO found
 Fixed
Severity: Minor
Found in sys/defs/src/TxsShow.hs by fixme

https://github.com/TorXakis/TorXakis/blob/develop/examps/DispatchProcess/spec/DisPro10-data.txs
has
processors [ Job2Proc, Finish ] ( 5 )
yet, https://github.com/TorXakis/TorXakis/blob/develop/examps/DispatchProcess/sut/DispatchProcess.java
has
public static final int nrofProcessors = 4;
Why was this never discovered?

bug found: parsing in Eval had one (unused) argument to many...
I removed it everywhere else ;-)

Yes, holidays....
everything seems fine again!

Related to #133


Fixes issue #5 (High system load)

Instead of opening the file constantly, just open it once and rewind. My system load has gone down from over 1.00 to under 0.10.

I tested this fix with my auto fan threshold feature. It perfect in term of performance enhancement but there is a problem with the update of the cpu/gpu temp.
Since the file is only read once, the values of the temperatures are not updated in share_info which make ec_auto_duty_adjust() to use always the temp and return a wrong fan duty.
Is there a way to retrieve the cpu/gpu temp from the kernel without over loading the system?

I see. I did not realise that. I will investigate it.
Op 23 apr. 2016 19:30 schreef Guillaume Grasset notifications@github.com:I tested this fix with my auto fan threshold feature. It perfect in term of performance enhancement but there is a problem with the update of the cpu/gpu temp.
Since the file is only read once, the values of the temperatures are not updated in share_info which make ec_auto_duty_adjust() to use always the temp and return a wrong fan duty.
Is there a way to retrieve the cpu/gpu temp from the kernel without over loading the system?
—You are receiving this because you authored the thread.Reply to this email directly or view it on GitHub

For now, the fix I found (thanks to you) is changing the usleep(500) for a sleep(1). (upgrade every second instead of every .5 millisec)


Create URL package to handle istio.io docs and other URLs

This PR provides a single source of truth for all the URLs used across tests and CLI output.
Why this package is required?
To avoid the following issues.
https://github.com/istio/istio/issues/24029
https://github.com/istio/istio/issues/23726
To avoid repetitive PR's for every release
https://github.com/istio/istio/pull/24092
https://github.com/istio/istio/pull/24050
https://github.com/istio/istio/pull/25878

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
0cae61ecbd4053c9645a5b613e235c9560df662d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
0cae61ecbd4053c9645a5b613e235c9560df662d
link
/test gencheck_istio

lint_istio
0cae61ecbd4053c9645a5b613e235c9560df662d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
0cae61ecbd4053c9645a5b613e235c9560df662d
link
/test gencheck_istio

lint_istio
0cae61ecbd4053c9645a5b613e235c9560df662d
link
/test lint_istio

unit-tests_istio
0cae61ecbd4053c9645a5b613e235c9560df662d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
0cae61ecbd4053c9645a5b613e235c9560df662d
link
/test lint_istio

unit-tests_istio
0cae61ecbd4053c9645a5b613e235c9560df662d
link
/test unit-tests_istio

gencheck_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
0cae61ecbd4053c9645a5b613e235c9560df662d
link
/test unit-tests_istio

gencheck_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test gencheck_istio

lint_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test gencheck_istio

lint_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test lint_istio

integ-operator-controller-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-operator-controller-tests_istio

unit-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test gencheck_istio

lint_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test lint_istio

integ-operator-controller-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-operator-controller-tests_istio

unit-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test gencheck_istio

lint_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test lint_istio

integ-operator-controller-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-operator-controller-tests_istio

unit-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test gencheck_istio

lint_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test lint_istio

integ-operator-controller-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-operator-controller-tests_istio

unit-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test gencheck_istio

integ-operator-controller-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-operator-controller-tests_istio

unit-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

lint_istio
c97e62b59f9a99dd2c27e66dca3dab08d2c9a956
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

lint_istio
c97e62b59f9a99dd2c27e66dca3dab08d2c9a956
link
/test lint_istio

unit-tests_istio
c97e62b59f9a99dd2c27e66dca3dab08d2c9a956
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c97e62b59f9a99dd2c27e66dca3dab08d2c9a956
link
/test unit-tests_istio

lint_istio
d1b51697fdb9513aa142f3856fb9224c5149650b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

lint_istio
d1b51697fdb9513aa142f3856fb9224c5149650b
link
/test lint_istio

unit-tests_istio
d1b51697fdb9513aa142f3856fb9224c5149650b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

unit-tests_istio
6f3a455fa1abb56000bdadae9a4a944837d61ffb
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

unit-tests_istio
bb15cd2a707ef1dca5480d8c7870b08dd56fdb73
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

unit-tests_istio
d8e1662038b43a7f657fe39ba5f632c6f9831410
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

unit-tests_istio
d8e1662038b43a7f657fe39ba5f632c6f9831410
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
9c57dc32147d4e527a686f5264105d4d00354a9e
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9c57dc32147d4e527a686f5264105d4d00354a9e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
9c57dc32147d4e527a686f5264105d4d00354a9e
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9c57dc32147d4e527a686f5264105d4d00354a9e
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
26f0e11f903962cc6834762f82e4ce5a5f1d1878
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
66464f839e2ad860a89943772945e2e288885c85
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
26f0e11f903962cc6834762f82e4ce5a5f1d1878
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-distroless-k8s-tests_istio

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
26f0e11f903962cc6834762f82e4ce5a5f1d1878
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
26f0e11f903962cc6834762f82e4ce5a5f1d1878
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests_istio

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
f7f993f2cb231856a5ed6f36defd8189461a8635
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-tests_istio

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
f7f993f2cb231856a5ed6f36defd8189461a8635
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
f7f993f2cb231856a5ed6f36defd8189461a8635
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
deb65229446c1ec174e042d5310a887a954eb467
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
7031fa4486612fc335d33147aa4132f1c6ac4ac0
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ca2c78376362a2c4d66ba516b201560d00ac8413
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ca2c78376362a2c4d66ba516b201560d00ac8413
link
/test unit-tests_istio

lint_istio
91e1422ad594b8c0a0b7d49feca8074b508a8fe5
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ca2c78376362a2c4d66ba516b201560d00ac8413
link
/test unit-tests_istio

lint_istio
91e1422ad594b8c0a0b7d49feca8074b508a8fe5
link
/test lint_istio

gencheck_istio
91e1422ad594b8c0a0b7d49feca8074b508a8fe5
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
753204df3f9fbb64580f04d2a86414d14289b608
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
753204df3f9fbb64580f04d2a86414d14289b608
link
/test lint_istio

gencheck_istio
753204df3f9fbb64580f04d2a86414d14289b608
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
753204df3f9fbb64580f04d2a86414d14289b608
link
/test gencheck_istio

lint_istio
860feef4e9486428e135f89ed662d9f32151a372
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test lint_istio

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
860feef4e9486428e135f89ed662d9f32151a372
link
/test lint_istio

gencheck_istio
860feef4e9486428e135f89ed662d9f32151a372
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
860feef4e9486428e135f89ed662d9f32151a372
link
/test gencheck_istio

lint_istio
860feef4e9486428e135f89ed662d9f32151a372
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

lint_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

lint_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test lint_istio

release-test_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

lint_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test lint_istio

release-test_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test release-test_istio

integ-distroless-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

lint_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test lint_istio

release-test_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test release-test_istio

integ-distroless-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

lint_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test lint_istio

release-test_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test release-test_istio

integ-distroless-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

lint_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test lint_istio

release-test_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test release-test_istio

integ-distroless-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test unit-tests_istio

integ-operator-controller-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

lint_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test lint_istio

release-test_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test release-test_istio

integ-distroless-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test unit-tests_istio

integ-operator-controller-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

lint_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test lint_istio

release-test_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test release-test_istio

integ-distroless-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test unit-tests_istio

integ-operator-controller-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

lint_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test lint_istio

release-test_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test release-test_istio

integ-distroless-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test unit-tests_istio

integ-operator-controller-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

lint_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test lint_istio

release-test_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test release-test_istio

integ-distroless-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test unit-tests_istio

integ-operator-controller-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test gencheck_istio

lint_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test lint_istio

release-test_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test release-test_istio

integ-distroless-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test unit-tests_istio

integ-operator-controller-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
dadeee7e4d953fc5227c6ecbdcfcb8167ffb29cd
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu PTAL?

@esnible PTAL.

@morvencao can you PTAL?

@ericvn  @howardjohn PTAL?

One comment would be that this wouldn't work for the master branch as it would use v1.8 which isn't shown anywhere,

One comment would be that this wouldn't work for the master branch as it would use v1.8 which isn't shown anywhere.

Agree, I think that will only happen for a short period of time during branch cut and release. Once v1.7 is released, it will point to /latest docs and v1.8 will point to preliminary.istio.io.

One comment would be that this wouldn't work for the master branch as it would use v1.8 which isn't shown anywhere.

I think this is fine and expected given that there is are no 1.8 preview docs during this transition period. @davidhauck could probably have added a 1.8 alias to the 1.7 preliminary docs when the istio/istio release branch is cut (instead of when the istio/istio.io branch is cut), but it's probably not really needed.

@frankbu I could update the master branch to 1.8, but then everything in preliminary would start showing up as v1.8, including the headers, etc. It's probably going to be a fair amount of work without doing that, so I'm not sure it's worth it.

@howardjohn Does it require more approval?


Downgrade unnecessary log level

We have a lot of logs that don't need to be printed, change them to debug level.

Change the log level in the configs looks more correct, so close this PR.


Add maintainers

Add Daniel Holbach, Stefan Prodan and Scott Rigby as maintainers of this repo.

Accept 👍


Attempted to teleport to a place that is restricted. (Error Code: 773)

i tried to use multiple-game instances for dual login, its fine on the game lobby but when tried to teleport shows the issue.
googling it leading to dual - login issues.
i use RAM for now. but would be amazing if i could just use it outta browser
thanks for your efforts pizza

Nothing I can really do about that. Doesn't RAM just launch Bloxstrap anyway?

in RAM, we had to put place id and job id if we're going to join private server
its much more convenient and faster to use links just like bloxstrap, but the teleport issue is exist while on RAM, it doesnt.. not sure why

Isn't the only difference here just that you're copying the Job ID with Bloxstrap instead of copying it from the website?

nope, with bloxstrap i can join directly through links.. on the other hand using RAM would be copying place id on the links.
i like to playing co-op with randoms through private server, since i need to copying the place id which is slower and the other randoms usually faster than me and maxed out the slots. you know first come first serve kinda things

Okay, I think this is making a bit more sense. Do your alt accounts even have permission to join the private server independently without the need to generate a link?

Weird, I don't really know why RAM is treating Job ID joining as a teleport. Either way, it's hard to really call this a Bloxstrap issue since Bloxstrap is just giving you the Job ID, RAM is doing the actual launching for it.

ram was doing fine, i was hoping that i could do dual login without ram (just by bloxstrap multi instances) since its much more convenient which i dont need to copy job id and place id.. its not working when doing the teleport things.

Yeah, there's not really much I can do about that since it's purely a permission error with however you're doing game joining. Sorry.

googling it leading to dual - login issues.

I just realized, you said you're trying to launch Roblox from your browser, right?

googling it leading to dual - login issues.

I just realized, you said you're trying to launch Roblox from your browser, right?

yes, by bloxstrap

How do you enter the Job ID to launch with?

just put the private server llinks on it

Oh, that makes a lot more sense. Yeah, those won't launch corresponding to the account that you're currently signed into your browser. Those will just launch with to whatever account is signed into the Roblox app, and so you get a duplicate login problem. RAM launches with account data, so it's not a problem there.

im using different browser for different account, the issue still persist

the private server on roblox game

Yeah, but what's the link that you paste the Job ID into?


Página Web? 🤨

Feature request

What is the expected behavior?
What is motivation or use case for adding/changing the behavior?
How should this be implemented in your opinion?
Are you willing to work on this yourself?
yes
- - [ ] # > `~~~~@NOoByXz ![IMG_20221207_004309.jpg](https://user-images.githubusercontent.com/120116439/206579218-f62a1fdd-d05d-44c5-8f99-b89b1b7f5770.jpg)[]()__~~~~`

Hello.
Create a new repository with the name of ChangeThisName.github.io.
Then, create a new file named index.html
You will need to know some HTML to start giving some life to your website.
Check out my website for some inspiration.
Then, go to your repo page settings (https://github.com/NOoByXz/YourRepoName/settings/pages), and check the instructions in there.
That's all forks!


Is it not possible to do something like that ?

zig-sqlite commit
latest
Zig version
0.13.0
Steps to reproduce
const query2 =
    \\ INSERT INTO villages(name,player_id,x_position,y_position) VALUES(?,(SELECT id FROM players WHERE session_id = ?),?,?);
;
var stmt2 = try app.db.prepare(query2);
defer stmt2.deinit();
// FIXME pour eviter l erreur verifier avec une requete avant ??
stmt2.exec(.{}, .{ .name = "vilajo", .session_id = session_id, .x_position = 1.0, .y_position = 2.0 }) catch {
    try res.json(.{ .message = "Error while creating village" }, .{});
    return;
};

Expected behaviour
I would except to pass the parameter to the SELECT inside the INSERT but I simply get an "Err: error.SQLiteError". I have no idea why. Is it possible to do requests the way I did ?

Looks like any attempt to chain multiple requests fail:
            const query =
                \\ INSERT INTO buildings(level,space_taken) VALUES(1,0);
                \\ INSERT INTO gold_mines(building_id,productivity) VALUES(last_insert_rowid(),?)
            ;

With SQLiteRangeError

It worked using savepoints :)


Switching post does not update the title, data and reading time

When you switch to a different post from a post page by clicking on the PostPreview, the content updates but the post title, data and reading time does not get updated, it still shows the data of previous post.

Thanks for reporting this. This is because I was destructuring the post prop in [slug].svelte - which made them not reactive. Fix was to access those properties via post.xyz instead on the page.
See https://github.com/mattjennings/sveltekit-blog-template/commit/a73c63d3a41a5c1a7cd489eebd219ef077bce237


Correctly parse ISSN for container field

Example from 10.1007/978-3-642-34922-5_19:
{
  "type": "Book Series",
  "title": "Studies in Fuzziness and Soft Computing",
  "identifier": [{
    "media_type": "print",
    "__content__": "1434-9922"
  }, {
    "media_type": "electronic",
    "__content__": "1860-0808"
  }],
  "identifierType": "ISSN"
}

@mfenner Can you expand upon what is not parsing, the original DataCite metadata with an ISSN? If so the example DOI doesn't appear to contain an ISSN.

It is about handling the print and electronic ISSN subtypes.


Rebase of the pio documentation on top of current master

The original PR was not merged into master, so this includes the original stuff with the changes suggested during review.  There were merge conflicts, so the "documents" directory was copied over along with demo.wake changes.
This PR depends on makeOnboardingDocument being available. This function was moved from scribble-onboarding-sifive into api-generator-sifive, but it has not been merged into the master branch.

One last thing I want to do in this PR is add the new document building functions to the Travis CI setup, but we'll need to do some refactoring of the .travis.yml file. One thing in particular we'll have to change is the "no internet" test needs to call the wake preinstall rule with internet access first, since that's how we currently install the Python and Ruby dependencies.

@albertchen-sifive, I just noticed that the Travis CI build passed, but the wake job failed:
$ docker run --rm \
  -v "$WIT_WORKSPACE:/mnt/workspace" \
  --workdir /mnt/workspace \
  "$BLOCKCI_DOCKER_IMAGE" \
  bash -c "wake --init . && wake -v --no-tty runSim pioDUT 2>&1 | (head -n 10000; tail -n 1000) && wake -v --no-tty runSim pio16DUT 2>&1 | (head -n 10000; tail -n 1000)"
Variable reference 'binary /../' is unbound at soc-testsocket-sifive/build.wake:52:[3-6]
>>> Aborting without execution <<<
Variable reference 'binary /../' is unbound at soc-testsocket-sifive/build.wake:52:[3-6]
>>> Aborting without execution <<<
The command "docker run --rm \
  -v "$WIT_WORKSPACE:/mnt/workspace" \
  --workdir /mnt/workspace \
  "$BLOCKCI_DOCKER_IMAGE" \
  bash -c "wake --init . && wake -v --no-tty runSim pioDUT 2>&1 | (head -n 10000; tail -n 1000) && wake -v --no-tty runSim pio16DUT 2>&1 | (head -n 10000; tail -n 1000)"
" exited with 0.

I'm wondering if the head -n 100000; tail -n 1000 is masking the true exit code. I think this is normally why you usually want to run a bash script with set -o pipefail, which basically makes it so that if you have a pipeline and if any stage fails, not just the last one, the whole pipeline fails.
It looks like https://github.com/sifive/block-pio-sifive/pull/28 actually truly failed, but the pipeline logic was masking the failure, so Travis CI marked it as a pass.
I was thinking of refactoring some of the Travis CI script anyway, since I want to add a few more wake commands and it's already getting a little bit unwieldy, so I may just fix this in a separate PR.

Just pushed up what are hopefully the last couple commits to this branch.
@albertchen-sifive, FYI, I had a minor bug in my Travis CI refactoring where I flipped the sign on the "disallow internet" flag in my bash script. This commit fixes it: https://github.com/sifive/block-pio-sifive/pull/24/commits/41f0245a8dc285795979e0cd00e6f2fd9051978b


plugin-emotion: Strip backslashed segments for Windows path

Currently, when @swc/plugin-emotion is used on Windows, it produces invalid CSS class names. Apparently this is an unsolved issue for Rust. In this PR I've updated the calculation of the [filename] labelFormat such that it handles both the Windows path, which includes the full path to the file, including backslashes, and the Unix path (which was working fine to begin with).
I have set up a minimal repo for reproducing the issue and verifying the fix. The issue can be reproduced on the main branch, and the fix can be verified on the fix branch. The fix branch replaces the compiled swc_plugin_emotion.wasm from @swc/plugin-emotion npm package with one I built myself via my fork of this repo.
Before

After

Fixes #327

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Drupal returning 2000 paths per request maximum

Hi, I found something quite odd when building an app with more than 2000 paths.
I have 6000 (3000 x 2 languages) nodes of one type (artwork) in my Drupal database but when I'm building the app, only 2000 are actually built when building the pages under /artworks/[...slug].js.
Is this a limitation from next-drupal, the next Drupal module or even the subrequests module ? I know that the basic Drupal/JSONAPI is limited to 50 nodes per request but I believe subrequests go through.
If we can't bypass this limitation, are we able to use limits to queue requests as long as we do not have all nodes ?

You're probably hitting the 1000 max size that the Next.js module sets.
See https://github.com/chapter-three/next-drupal/blob/db2f99c3872a7e46cedcad66650b6f03fd645dbb/modules/next/modules/next_jsonapi/next_jsonapi.services.yml#L1
Can you try overriding this parameter in your sites services.yml file?

It seems to be working but I am hitting the 60 seconds timeout when retrieving the nodes now, so the build does not even start, do you know where I can change the timeout value ?

OK, there is an experimental flag to add in next.config.js :
experimental.pageDataCollectionTimeout is 60 by default, problem solved !
I will have to create a patch on the .yml file to make sure that the value never changes :)

I will have to create a patch on the .yml file to make sure that the value never changes :)

Do you mean the next_jsonapi.size_max value?
You could also look into ISR and only build the most important pages and let the other pages be server rendered.


Method BANKSY

Implemented Banksy (issue #8)
I don't see a way to not use the method's own way to compute neighbors, so those are used.
It also needs both PCA and expression values, so I use its own method for PCA.

@svedziok can you review the conda env generation?

@svedziok can you review the conda env generation?
looks fine; we will then add an additional rule for installing the missing package for this method


Site NavBar & Footer Added

Following changes has been made to the repo..

Bootstrap Added
Site Structure Created
Routing Module Implemented
Footer, NavBar Components added

@Safnaj can u add screenshots?

@Safnaj can u add screenshots?

@Safnaj can u add screenshots?

@Safnaj can u add screenshots?

what's this?

@Safnaj can u add screenshots?


Add initial (naive) BitBucket Server support

Part of https://github.com/weaveworks/weave-gitops-enterprise/issues/2271
Adds repo URL parsing support for BitBucket using a simple path match.

@yiannistri It wasn't immediately obvious how we can detect a bitbucket provider URL using Viper or env vars. Any ideas there?

@jpellizzari  we don't need to detect the provider from the URL, there's a map[string]string that gets populated from a Kubernetes secret that maps the URL to the provider type, for example in the detectGitProviderFromURL function the gitHostTypes parameter will be
gitHostTypes[bitbucket.acme.com: bitbucket-server

So we can use that value to determine the provider.

There's a reference to this in the docs but it's not super clear https://github.com/weaveworks/weave-gitops/blob/main/website/docs/installation/weave-gitops-enterprise/index.mdx?plain=1#L233-L236

@jpellizzari we don't need to detect the provider from the URL, there's a map[string]string that gets populated from a Kubernetes secret that maps the URL to the provider type, for example in the detectGitProviderFromURL function the gitHostTypes parameter will be

Fixed! PTAL


Aot testing

I lied to you about the file conflicts of merging that other pull request. I apologize. Will need to do the merge reconciliation.,


getting all the surface names from pyfluent

📝 Description of the feature
Hi there, it would be nice to be able to gather the surface names directly from pyfluent.
At the moment you need to know that upfront or open the GUI.
💡 Steps for implementing the feature
No clue :-)
🔗 Useful links and references
No response

@g-pagliuca, try using "surfaces_list.allowed_values". I think this is what you want. Please let us know if anything else is needed.

Indeed, exactly what i needed, thanks ;-)

@prmukherj how exactly do you use this function? I can only find a single example in the documentation:
mesh = Mesh(solver, new_instance_name="mesh")
mesh.surfaces_list = mesh.surfaces_list.allowed_values()
But this doesn't work since 'Mesh' is undefined and there is no mesh module that I can import.
Cheers

@prmukherj how exactly do you use this function? I can only find a single example in the documentation:
mesh = Mesh(solver, new_instance_name="mesh") mesh.surfaces_list = mesh.surfaces_list.allowed_values()
But this doesn't work since 'Mesh' is undefined and there is no mesh module that I can import.
Cheers

You can find an overall end-to-end working example in the documentation which you can follow.
https://visualization.fluent.docs.pyansys.com/version/stable/examples/00-postprocessing/post_processing_exhaust_manifold.html#sphx-glr-examples-00-postprocessing-post-processing-exhaust-manifold-py
Thank you.

@prmukherj how exactly do you use this function? I can only find a single example in the documentation:
mesh = Mesh(solver, new_instance_name="mesh") mesh.surfaces_list = mesh.surfaces_list.allowed_values()
But this doesn't work since 'Mesh' is undefined and there is no mesh module that I can import.
Cheers

You can find an overall end-to-end working example in the documentation which you can follow. https://visualization.fluent.docs.pyansys.com/version/stable/examples/00-postprocessing/post_processing_exhaust_manifold.html#sphx-glr-examples-00-postprocessing-post-processing-exhaust-manifold-py Thank you.

Hello,
Thanks for the reply, but this example shows the user inputting a list of surfaces they wish to display when visualising the mesh. I want to instead find a list of zones within the model, equivalent to the (inquire-zone-names) command. If I call:
mesh1.surfaces_list.allowed_values()
Then I get the error:
coro = func()            ^^^^^^   File "<input>", line 1, in <module> TypeError: 'list' object is not callable
Is there a away to do this?
Best,
cons013

@prmukherj how exactly do you use this function? I can only find a single example in the documentation:
mesh = Mesh(solver, new_instance_name="mesh") mesh.surfaces_list = mesh.surfaces_list.allowed_values()
But this doesn't work since 'Mesh' is undefined and there is no mesh module that I can import.
Cheers

You can find an overall end-to-end working example in the documentation which you can follow. https://visualization.fluent.docs.pyansys.com/version/stable/examples/00-postprocessing/post_processing_exhaust_manifold.html#sphx-glr-examples-00-postprocessing-post-processing-exhaust-manifold-py Thank you.

Hello,
Thanks for the reply, but this example shows the user inputting a list of surfaces they wish to display when visualising the mesh. I want to instead find a list of zones within the model, equivalent to the (inquire-zone-names) command. If I call: mesh1.surfaces_list.allowed_values() Then I get the error: coro = func() ^^^^^^ File "<input>", line 1, in <module> TypeError: 'list' object is not callable
Is there a away to do this?
Best, cons013

Please use "mesh1.surfaces_list.allowed_values" instead of "mesh1.surfaces_list.allowed_values()" as allowed values call already returns a list which is not callable.
Please refer to the comment: https://github.com/ansys/pyfluent-visualization/issues/371#issuecomment-1985146903
Thank you.

@prmukherj how exactly do you use this function? I can only find a single example in the documentation:
mesh = Mesh(solver, new_instance_name="mesh") mesh.surfaces_list = mesh.surfaces_list.allowed_values()
But this doesn't work since 'Mesh' is undefined and there is no mesh module that I can import.
Cheers

You can find an overall end-to-end working example in the documentation which you can follow. https://visualization.fluent.docs.pyansys.com/version/stable/examples/00-postprocessing/post_processing_exhaust_manifold.html#sphx-glr-examples-00-postprocessing-post-processing-exhaust-manifold-py Thank you.

Hello,
Thanks for the reply, but this example shows the user inputting a list of surfaces they wish to display when visualising the mesh. I want to instead find a list of zones within the model, equivalent to the (inquire-zone-names) command. If I call: mesh1.surfaces_list.allowed_values() Then I get the error: coro = func() ^^^^^^ File "<input>", line 1, in <module> TypeError: 'list' object is not callable
Is there a away to do this?
Best, cons013

Please use "mesh1.surfaces_list.allowed_values" instead of "mesh1.surfaces_list.allowed_values()" as allowed values call already returns a list which is not callable.
Please refer to the comment: #371 (comment)
Thank you.

Thanks, that seems to work, however this does not show every zone, only the mesh surfaces. Is there an equivalent command to (inquire-zone-names)?

@prmukherj how exactly do you use this function? I can only find a single example in the documentation:
mesh = Mesh(solver, new_instance_name="mesh") mesh.surfaces_list = mesh.surfaces_list.allowed_values()
But this doesn't work since 'Mesh' is undefined and there is no mesh module that I can import.
Cheers

You can find an overall end-to-end working example in the documentation which you can follow. https://visualization.fluent.docs.pyansys.com/version/stable/examples/00-postprocessing/post_processing_exhaust_manifold.html#sphx-glr-examples-00-postprocessing-post-processing-exhaust-manifold-py Thank you.

Hello,
Thanks for the reply, but this example shows the user inputting a list of surfaces they wish to display when visualising the mesh. I want to instead find a list of zones within the model, equivalent to the (inquire-zone-names) command. If I call: mesh1.surfaces_list.allowed_values() Then I get the error: coro = func() ^^^^^^ File "<input>", line 1, in <module> TypeError: 'list' object is not callable
Is there a away to do this?
Best, cons013

Please use "mesh1.surfaces_list.allowed_values" instead of "mesh1.surfaces_list.allowed_values()" as allowed values call already returns a list which is not callable.
Please refer to the comment: #371 (comment)
Thank you.

Thanks, that seems to work, however this does not show every zone, only the mesh surfaces. Is there an equivalent command to (inquire-zone-names)?
Edit: A somewhat functional workaround is using solver.settings.setup.boundary_conditions.get_state() and then something like  for key, value in zone_dict.items(): but I don't know how reliable/portable this is.

Yes, these are settings-api command to inquire zone names. You can use this. But, visualization currently only supports getting mesh surfaces which can be redered.
Thank you.

I have found a workaround that actually seems good, but from #1644 I guess this will stop working at some point.
zones = [str(s) for s in solver.scheme_eval.scheme_eval("(inquire-zone-names)")]

I have found a workaround that actually seems good, but from #1644 I guess this will stop working at some point.
zones = [str(s) for s in solver.scheme_eval.scheme_eval("(inquire-zone-names)")]

Yes, that's true. Please use the boundary_conditions from settings, instead.