chore(deps): update node.js to v18.19.0

This PR contains the following updates:

Package
Type
Update
Change

node
engines
minor
>=18.17.0 -> >=18.19.0

Release Notes

nodejs/node (node)
v18.19.0: 2023-11-29, Version 18.19.0 'Hydrogen' (LTS), @targos
Compare Source
Notable Changes
npm updated to v10
After two months of baking time in Node.js 20, npm 10 is backported, so that all
release lines include a supported version of npm. This release includes npm v10.2.3.
Refer to nodejs/Release#884 for the plan to land npm 10.
ESM and customization hook changes
Leverage loaders when resolving subsequent loaders
Loaders now apply to subsequent loaders, for example: --experimental-loader ts-node --experimental-loader loader-written-in-typescript.
Contributed by Maël Nison in #43772.
New node:module API register for module customization hooks; new initialize hook
There is a new API register available on node:module to specify a file that exports module customization hooks, and pass data to the hooks, and establish communication channels with them. The “define the file with the hooks” part was previously handled by a flag --experimental-loader, but when the hooks moved into a dedicated thread in 20.0.0 there was a need to provide a way to communicate between the main (application) thread and the hooks thread. This can now be done by calling register from the main thread and passing data, including MessageChannel instances.
We encourage users to migrate to an approach that uses --import with register, such as:
node --import ./file-that-calls-register.js ./app.js

Using --import ensures that the customization hooks are registered before any application code runs, even the entry point.
Contributed by João Lenon and Jacob Smith in #46826, Izaak Schroeder and Jacob Smith in #48842 and #48559.
import.meta.resolve unflagged
In ES modules, import.meta.resolve(specifier)
can be used to get an absolute URL string to which specifier resolves, similar
to require.resolve in CommonJS. This aligns Node.js with browsers and other server-side runtimes.
Contributed by Guy Bedford in #49028.
--experimental-default-type flag to flip module defaults
The new flag --experimental-default-type can be used to flip the default
module system used by Node.js. Input that is already explicitly defined as ES
modules or CommonJS, such as by a package.json "type" field or .mjs/.cjs
file extension or the --input-type flag, is unaffected. What is currently
implicitly CommonJS would instead be interpreted as ES modules under
--experimental-default-type=module:

String input provided via --eval or STDIN, if --input-type is unspecified.

Files ending in .js or with no extension, if there is no package.json file
present in the same folder or any parent folder.

Files ending in .js or with no extension, if the nearest parent
package.json field lacks a type field; unless the folder is inside a
node_modules folder.

In addition, extensionless files are interpreted as Wasm if
--experimental-wasm-modules is passed and the file contains the "magic bytes"
Wasm header.
Contributed by Geoffrey Booth in #49869.
Other ESM-related changes

[ed2d46f4cc] - doc: move and rename loaders section (Geoffrey Booth) #49261
[92734d4480] - esm: use import attributes instead of import assertions (Antoine du Hamel) #50140
[e96f7ef881] - (SEMVER-MINOR) vm: use import attributes instead of import assertions (Antoine du Hamel) #50141

Test runner changes
Many changes to the built-in test runner have been backported. This includes
the following additions:

[b283ae4238] - (SEMVER-MINOR) test_runner: accept testOnly in run (Moshe Atlow) #49753
[059b1945d8] - (SEMVER-MINOR) test_runner: add junit reporter (Moshe Atlow) #49614
[d61a505546] - (SEMVER-MINOR) test_runner: expose location of tests (Colin Ihrig) #48975
[b55eb2a8d1] - (SEMVER-MINOR) test_runner: add shards support (Raz Luvaton) #48639
[05e7f28b40] - (SEMVER-MINOR) test_runner: add initial draft for fakeTimers (Erick Wendel) #47775
[428301ad27] - (SEMVER-MINOR) test_runner, cli: add --test-concurrency flag (Colin Ihrig) #49996

Other notable changes

[0c4a84e8e9] - (SEMVER-MINOR) deps: update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908
[fae60c5841] - stream: use bitmap in readable state (Benjamin Gruenbaum) #49745
[17246be158] - (SEMVER-MINOR) lib: add api to detect whether source-maps are enabled (翠 / green) #46391
[2e9f7284a1] - (SEMVER-MINOR) lib: add tracing channel to diagnostics_channel (Stephen Belanger) #44943
[cc7bf1f641] - (SEMVER-MINOR) src: add cjs_module_lexer_version base64_version (Jithil P Ponnan) #45629
[b5d16cd8f0] - (SEMVER-MINOR) tls: add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190

Commits

[0d0eb47e2a] - benchmark: add benchmarks for the test_runner (Raz Luvaton) #48931
[8bb03d10f4] - benchmark: differentiate whatwg and legacy url (Yagiz Nizipli) #47377
[3d7734cbe3] - benchmark: lower URL.canParse runs (Khafra) #47351
[24d3fcf415] - benchmark: stablize encode benchmark (Joyee Cheung) #46658
[e08fd98bcc] - bootstrap: use correct descriptor for Symbol.{dispose,asyncDispose} (Jordan Harband) #48703
[cf9ddcd6c8] - bootstrap: simplify initialization of source map handlers (Joyee Cheung) #48304
[12d731e431] - bootstrap: log isolate data info in mksnapshot debug logs (Joyee Cheung) #47768
[d66873871a] - bootstrap: store internal loaders in C++ via a binding (Joyee Cheung) #47215
[1a499c5082] - bootstrap: optimize modules loaded in the built-in snapshot (Joyee Cheung) #45849
[e0e09caafe] - bootstrap: make CJS loader snapshotable (Joyee Cheung) #45849
[5f37decd56] - bootstrap: include event_target into the built-in snapshot (Joyee Cheung) #45849
[c3f56a3dee] - bootstrap: support module_wrap binding in snapshot (Joyee Cheung) #45849
[6466acbc89] - bootstrap: lazy load non-essential modules (Joyee Cheung) #45659
[a0d4b69df4] - bootstrap: lazy-load Performance.prototype.timeOrigin (Joyee Cheung) #46425
[c1bc8118e3] - bootstrap: generate bootstrapper arguments in BuiltinLoader (Joyee Cheung) #44488
[075c57e88b] - build: add symlink to compile_commands.json file if needed (Juan José) #49260
[9e1c531b8d] - build: expand when we run internet tests (Michael Dawson) #49218
[a781d24624] - build: fix typo libray -> library (configure.py) (michalbiesek) #49106
[f2eccb7a04] - build: fix configure --link-module (Richard Lau) #48522
[a44d555494] - build: fix IBM i build with Python 3.9 (Richard Lau) #48056
[7f68e14ea2] - child_process: improve spawn performance on Linux (Keyhan Vakil) #48523
[76e4d4117c] - crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey (Filip Skokan) #50234
[7af54279b5] - deps: V8: cherry-pick 70caf33 (kxxt) #50506
[49c5495339] - deps: update zlib to <IP_ADDRESS>-motley-fef5869 (Node.js GitHub Bot) #50085
[e0fd52bf07] - deps: update googletest to 2dd1c13 (Node.js GitHub Bot) #50081
[1b103cc567] - deps: update googletest to e47544a (Node.js GitHub Bot) #49982
[736c869eeb] - deps: update googletest to d1467f5 (Node.js GitHub Bot) #49676
[cd99ee1f35] - deps: update googletest to 8a6feab (Node.js GitHub Bot) #49463
[5c338573ff] - deps: update zlib to <IP_ADDRESS>-motley-f5fd0ad (Node.js GitHub Bot) #49252
[374ec3d623] - deps: update googletest to 7e33b6a (Node.js GitHub Bot) #49034
[c15dd6679b] - deps: update zlib to <IP_ADDRESS>-motley-526382e (Node.js GitHub Bot) #49033
[588bd5e524] - deps: update googletest to c875c4e (Node.js GitHub Bot) #48964
[6059b59018] - deps: update zlib to <IP_ADDRESS>-motley-61dc0bd (Node.js GitHub Bot) #48788
[e455dd4003] - deps: update googletest to cc36671 (Node.js GitHub Bot) #48789
[747fbb49ca] - deps: V8: cherry-pick 1a782f6 (Keyhan Vakil) #48523
[272e55c66f] - deps: upgrade npm to 10.2.3 (npm team) #50531
[3f6dcc62e5] - deps: update archs files for openssl-3.0.12+quic1 (Node.js GitHub Bot) #50411
[da26cdbe84] - deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1 (Node.js GitHub Bot) #50411
[23069c34b2] - deps: V8: cherry-pick d69c793 (Michaël Zasso) #46425
[5f852cc9fe] - deps: V8: cherry-pick f7d000a (Luke Albao) #50344
[0c4a84e8e9] - (SEMVER-MINOR) deps: update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908
[8682b90d02] - deps: update simdutf to 3.2.18 (Node.js GitHub Bot) #50091
[11ecd06aeb] - deps: update simdutf to 3.2.17 (Node.js GitHub Bot) #49019
[43bfe5f020] - deps: upgrade npm to 10.2.0 (npm team) #50027
[a140bc284b] - deps: upgrade npm to 10.1.0 (npm team) #49570
[65ca41c276] - (SEMVER-MINOR) deps: upgrade npm to 10.0.0 (npm team) #49423
[df1ff8e3da] - deps: fix call to undeclared functions 'ntohl' and 'htons' (MatteoBax) #49979
[f228dc7955] - deps: update corepack to 0.22.0 (Node.js GitHub Bot) #50325
[4324ebab67] - deps: update corepack to 0.21.0 (Node.js GitHub Bot) #50088
[1cabb77659] - deps: update corepack to 0.20.0 (Node.js GitHub Bot) #49464
[04227b287e] - deps: update c-ares to 1.20.1 (Node.js GitHub Bot) #50082
[13e69ee11c] - deps: update c-ares to 1.20.0 (Node.js GitHub Bot) #50082
[ac717df17e] - deps: update ada to 2.7.2 (Node.js GitHub Bot) #50338
[6885fc9386] - deps: update ada to 2.6.10 (Node.js GitHub Bot) #49984
[76c5f4039f] - deps: update ada to 2.6.9 (Node.js GitHub Bot) #49340
[597ea77422] - deps: update ada to 2.6.8 (Node.js GitHub Bot) #49340
[8e7dcba553] - deps: update ada to 2.6.7 (Node.js GitHub Bot) #49340
[9f2037e8ee] - deps: update ada to 2.6.5 (Node.js GitHub Bot) #49340
[4723976703] - deps: update ada to 2.6.3 (Node.js GitHub Bot) #49340
[7ccb478664] - deps: update undici to 5.26.4 (Node.js GitHub Bot) #50274
[88f9ebb770] - diagnostics_channel: fix ref counting bug when reaching zero subscribers (Stephen Belanger) #47520
[284a869540] - dns: call ada::idna::to_ascii directly from c++ (Yagiz Nizipli) #47920
[10968370b5] - doc: drop github actions check in sec release process (Rafael Gonzaga) #48978
[07c3b88c74] - doc: remove @anonrig from performance initiative (Yagiz Nizipli) #49641
[e26b89e8be] - doc: fix node-api call example (Chengzhong Wu) #49395
[4c93905f6c] - doc: add news issue for Diagnostics WG (Michael Dawson) #49306
[3f1a237a8f] - doc: add print results for examples in StringDecoder (Jungku Lee) #49326
[45caad82bb] - doc: update outdated reference to NIST SP 800-131A (Tobias Nießen) #49316
[62f823d5a2] - doc: use cjs as block code's type in MockTimers (Deokjin Kim) #49309
[0dda724d3f] - doc: update options.filter description for fs.cp (Shubham Pandey) #49289
[4ba11e352b] - doc: avoid "not currently recommended" (Tobias Nießen) #49300
[9ca85b58b3] - doc: modify param description for end(),write() in StringDecoder (Jungku Lee) #49285
[3f771cab67] - doc: use NODE_API_SUPPORTED_VERSION_MAX in release doc (Cheng Zhao) #49268
[f181c37e75] - doc: fix typo in stream.finished documentation (Antoine du Hamel) #49271
[c70945ddc2] - doc: update description for percent_encode sets in WHATWG API (Jungku Lee) #49258
[f9c2a3fb3e] - doc: clarify use of Uint8Array for n-api (Fedor Indutny) #48742
[bf22a5f66e] - doc: use same name in the doc as in the code (Hyunjin Kim) #49216
[72bd527fb6] - doc: add notable-change label mention to PR template (Rafael Gonzaga) #49188
[2247e52fe0] - doc: add h1 summary to security release process (Rafael Gonzaga) #49112
[3b82e9aed1] - doc: fix wording in napi_async_init (Tobias Nießen) #49180
[55171d88a0] - doc: fix Type notation in webstreams (Deokjin Kim) #49121
[79c0497398] - doc: make the NODE_VERSION_IS_RELEASE revert clear (Rafael Gonzaga) #49114
[7ee26fb8df] - doc: update with latest security release (Rafael Gonzaga) #49085
[9ce73964be] - doc: add description for --port flag of node inspect (Michael Bianco) #48785
[633b8cd181] - doc: add missing period (Rich Trott) #49094
[6daa9ec2a4] - doc: add ESM examples in http.md (btea) #47763
[12b83e81b9] - doc: detailed description of keystrokes Ctrl-Y and Meta-Y (Ray) #43529
[ead654f976] - doc: clarify use of process.env in worker threads on Windows (Daeyeon Jeong) #49008
[4047947838] - doc: remove v14 mention (Rafael Gonzaga) #49005
[833c643eb4] - doc: run license-builder (github-actions[bot]) #48898
[cb43717c97] - doc: add ver of 18.x where Node-api 9 is supported (Michael Dawson) #48876
[a8d5c16a2a] - doc: include experimental features assessment (Rafael Gonzaga) #48824
[e6d8735e2b] - doc: add new TSC members (Michael Dawson) #48841
[d4fe00d0c7] - doc: refactor node-api support matrix (Michael Dawson) #48774
[629132d84c] - doc: declare path on example of async_hooks.executionAsyncId() (Deokjin Kim) #48556
[dfd368ac9f] - doc: remove the . in the end to reduce confusing (Jason) #48719
[74d8f96413] - doc: nodejs-social over nodejs/tweet (Rafael Gonzaga) #48769
[73a7e00d06] - doc: add missing history info for import.meta.resolve (Antoine du Hamel) #49700
[c20fdb4e52] - doc: edit import.meta.resolve documentation (Antoine du Hamel) #49247
[1ac389ecef] - doc: update module hooks docs (Geoffrey Booth) #49265
[ed2d46f4cc] - doc: move and rename loaders section (Geoffrey Booth) #49261
[258df0e72d] - doc: add signature for module.register (Geoffrey Booth) #49251
[58eaf3f6ae] - doc: caveat unavailability of import.meta.resolve in custom loaders (Jacob Smith) #49242
[2fef28b2b9] - doc: fix name of the flag in initialize() docs (Antoine du Hamel) #49158
[15280fb42c] - doc: add steps about signing the binary in single-executable docs (Darshan Sen) #46764
[e374ba296c] - doc: add "type" to test runner event details (Phil Nash) #49014
[ec0a6c1f1b] - doc: add new reporter events to custom reporter examples (Chemi Atlow) #48903
[e8a32fb49b] - doc: change duration to duration_ms on test documentation (Ardi_Nugraha) #48892
[2b30c8b8a3] - doc: fix globalPreload example (bmacnaughton) #50300
[8a57182769] - doc,test: extend the list of platforms supported by single-executables (Darshan Sen) #47026
[92734d4480] - esm: use import attributes instead of import assertions (Antoine du Hamel) #50140
[c3c945e654] - esm: bypass CommonJS loader under --default-type (Geoffrey Booth) #49986
[fe691984b2] - esm: unflag extensionless javascript and wasm in module scope (Geoffrey Booth) #49974
[56bd9a88ac] - esm: --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869
[72644d62e7] - esm: improve JSDoc annotation of internal functions (Antoine du Hamel) #49959
[957725f601] - esm: require braces for modules code (Geoffrey Booth) #49657
[c12685f82d] - esm: fix cache collision on JSON files using file: URL (Antoine du Hamel) #49887
[ed8dd33493] - esm: identify parent importing a url with invalid host (Jacob Smith) #49736
[46d730ab75] - esm: fix return type of import.meta.resolve (Antoine du Hamel) #49698
[12cb700478] - esm: update loaders warning (Geoffrey Booth) #49633
[47193a347e] - esm: fix support for URL instances in register (Antoine du Hamel) #49655
[51ced0f1a1] - esm: clarify ERR_REQUIRE_ESM errors (Daniel Compton) #49521
[4be5612bae] - esm: remove return value for Module.register (Antoine du Hamel) #49529
[0875867e27] - esm: refactor test-esm-loader-resolve-type (Geoffrey Booth) #49493
[9b7c9d93e9] - esm: refactor test-esm-named-exports (Geoffrey Booth) #49493
[d1f5514917] - esm: refactor mocking test (Geoffrey Booth) #49465
[01ca6d277d] - esm: fix globalPreload warning (Antoine du Hamel) #49069
[c1a84398b4] - esm: unflag import.meta.resolve (Guy Bedford) #49028
[ef43f084e9] - esm: import.meta.resolve exact module not found errors should return (Guy Bedford) #49038
[385f24c9cc] - esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution (Antoine du Hamel) #49060
[10e7c3a376] - esm: add initialize hook, integrate with register (Izaak Schroeder) #48842
[f96b610268] - esm: fix typo parentUrl -> parentURL (Antoine du Hamel) #48999
[03c1b5e647] - esm: unflag Module.register and allow nested loader import() (Izaak Schroeder) #48559
[63aa5d7270] - esm: add back globalPreload tests and fix failing ones (Antoine du Hamel) #48779
[1c7be606f1] - esm: remove support for arrays in import internal method (Antoine du Hamel) #48296
[655111fa00] - esm: handle globalPreload hook returning a nullish value (Antoine du Hamel) #48249
[9938a8bf13] - esm: handle more error types thrown from the loader thread (Antoine du Hamel) #48247
[8cab32a5d1] - esm: do not use 'beforeExit' on the main thread (Antoine du Hamel) #47964
[b61efcce95] - esm: rename URLCanParse to be consistent (Antoine du Hamel) #47668
[ca20f5931d] - esm: remove support for deprecated hooks (Antoine du Hamel) #47580
[5de37a1e37] - esm: initialize import.meta on eval (Antoine du Hamel) #47551
[39fbce7313] - esm: propagate process.exit from the loader thread to the main thread (Antoine du Hamel) #47548
[2a528b76e6] - esm: avoid try/catch when validating urls (Yagiz Nizipli) #47541
[bac9b1758f] - esm: move hook execution to separate thread (Jacob Smith) #44710
[dfa444477a] - esm: skip file: URL conversion to path when possible (Antoine du Hamel) #46305
[45de8d1bd7] - esm: allow resolve to return import assertions (Geoffrey Booth) #46153
[5ffc90a06b] - esm: move hooks handling into separate class (Geoffrey Booth) #45869
[490b598dbf] - esm: leverage loaders when resolving subsequent loaders (Maël Nison) #43772
[acd987287c] - events: remove weak listener for event target (Raz Luvaton) #48952
[69b7f91a92] - fs: remove redundant code in readableWebStream() (Deokjin Kim) #49298
[ae8bb162b4] - fs: remove redundant nullCheck (Livia Medeiros) #48826
[48c25b154b] - fs: make mkdtemp accept buffers and URL (LiviaMedeiros) #48828
[edf46c1b59] - fs: move fs_use_promises_symbol to per-isolate symbols (Joyee Cheung) #47768
[fe41d22afc] - fs: use kResistStopPropagation (Chemi Atlow) #48521
[7c758f60ab] - fs: fix readdir recursive sync & callback (Ethan Arrowood) #48698
[8874b2e11d] - http: start connections checking interval on listen (Paolo Insogna) #48611
[29697229b6] - https: fix connection checking interval not clearing on server close (Nitzan Uziely) #48383
[981aa7866d] - lib: fix MIME overmatch in data URLs (André Alves) #49104
[fe26f8a860] - lib: merge cjs and esm package json reader caches (Yagiz Nizipli) #48477
[17246be158] - (SEMVER-MINOR) lib: add api to detect whether source-maps are enabled (翠 / green) #46391
[2e9f7284a1] - (SEMVER-MINOR) lib: add tracing channel to diagnostics_channel (Stephen Belanger) #44943
[04dad9c2f6] - lib: fix BroadcastChannel initialization location (Shelley Vohr) #46864
[671d2c0067] - lib: fix DOMException property descriptors after being lazy loaded (Filip Skokan) #46799
[9a4b57d6d4] - lib: improve esm resolve performance (Yagiz Nizipli) #46652
[c6b2f56723] - lib: lazy-load deps in modules/run_main.js (Joyee Cheung) #45849
[baa280a4f6] - lib: lazy-load deps in source_map_cache.js (Joyee Cheung) #45849
[00bdb72b6e] - lib: add getLazy() method to internal/util (Joyee Cheung) #45849
[b77a6b2376] - loader: use default loader as cascaded loader in the in loader worker (Joyee Cheung) #47620
[7778e190b0] - meta: move Trott to TSC regular member (Rich Trott) #50297
[5b9575dd30] - meta: ping TSC for offboarding (Tobias Nießen) #50147
[d24c3a0692] - meta: update website team with new name (Rich Trott) #49883
[332d2aedb4] - meta: fix linter error (Antoine du Hamel) #49755
[dc70c444f4] - meta: add primordials strategic initiative (Benjamin Gruenbaum) #49706
[213a9f8a4b] - meta: bump rtCamp/action-slack-notify from 2.2.0 to 2.2.1 (dependabot[bot]) #49437
[2827779faa] - meta: remove modules team from CODEOWNERS (Benjamin Gruenbaum) #49412
[5d6daf0d01] - meta: add test/reporters to codeowners (Chemi Atlow) #49186
[dee7dc5d54] - meta: bump actions/upload-artifact from 3.1.2 to 3.1.3 (dependabot[bot]) #50000
[98294fdeee] - meta: bump actions/cache from 3.3.1 to 3.3.2 (dependabot[bot]) #50003
[79270327d0] - meta: bump github/codeql-action from 2.21.5 to 2.21.9 (dependabot[bot]) #50002
[6591a03c89] - meta: bump github/codeql-action from 2.21.2 to 2.21.5 (dependabot[bot]) #49438
[3a107f80bc] - meta: bump actions/checkout from 3.6.0 to 4.1.0 (dependabot[bot]) #50001
[26c5c3c4a2] - meta: bump actions/checkout from 3.5.3 to 3.6.0 (dependabot[bot]) #49436
[0fc0b88d97] - meta: bump step-security/harden-runner from 2.5.0 to 2.5.1 (dependabot[bot]) #49435
[dad5785d5d] - meta: bump actions/setup-node from 3.7.0 to 3.8.1 (dependabot[bot]) #49434
[155a275acb] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #49264
[bd17f0b992] - meta: mention nodejs/tsc when changing GH templates (Rafael Gonzaga) #49189
[f6e68a0238] - meta: bump github/codeql-action from 2.20.1 to 2.21.2 (dependabot[bot]) #48986
[5c352eeecb] - meta: bump step-security/harden-runner from 2.4.1 to 2.5.0 (dependabot[bot]) #48985
[42ac5a6e5f] - meta: bump actions/setup-node from 3.6.0 to 3.7.0 (dependabot[bot]) #48984
[b0d769fe7c] - meta: bump actions/setup-python from 4.6.1 to 4.7.0 (dependabot[bot]) #48983
[f62b24276c] - meta: add mailmap entry for atlowChemi (Chemi Atlow) #48810
[8c55f317a3] - module: move helpers out of cjs loader (Geoffrey Booth) #49912
[14e148ee6c] - module: ensure successful import returns the same result (Antoine du Hamel) #46662
[65dfe85f03] - module: implement register utility (João Lenon) #46826
[6f0458d0a6] - module: refactor to use normalizeRequirableId in the CJS module loader (Darshan Sen) #47896
[89ed24b94a] - module: do less CJS module loader initialization at run time (Joyee Cheung) #47194
[939c8764b8] - module: move callbacks and conditions into modules/esm/utils.js (Joyee Cheung) #45849
[a3b0f4cf55] - module: move modules/cjs/helpers.js to modules/helpers.js (Joyee Cheung) #45849
[97579895f2] - module, esm: jsdoc for modules files (Geoffrey Booth) #49523
[daca87bbef] - net: use asserts in JS Socket Stream to catch races in future (Tim Perry) #49400
[03063bd022] - net: fix crash due to simultaneous close/shutdown on JS Stream Sockets (Tim Perry) #49400
[67fe7d8822] - net: fix setting of value in 'setDefaultAutoSelectFamilyAttemptTimeout' (Deokjin Kim) #47012
[f449b222fd] - node-api: update headers for better wasm support (Toyo Li) #49037
[5148f030b8] - node-api: run finalizers directly from GC (Vladimir Morozov) #42651
[edef4fa668] - node-api: enable uncaught exceptions policy by default (Chengzhong Wu) #49313
[48a1b9336b] - node-api: fix compiler warning in node_api.h (Michael Graeb) #49103
[57966318fe] - node-api: avoid macro redefinition (Tobias Nießen) #48879
[d4f26f4651] - policy: fix path to URL conversion (Antoine du Hamel) #49133
[a625f22acb] - readline: add paste bracket mode (Jakub Jankiewicz) #47150
[bbafd42d75] - repl: display dynamic import variant in static import error messages (Hemanth HM) #48129
[b8634eeb16] - sea: allow requiring core modules with the "node:" prefix (Darshan Sen) #47779
[066d9d4492] - src: remove unused function GetName() in node_perf (Jungku Lee) #49244
[158c91a38a] - src: use ARES_SUCCESS instead of 0 (Jungku Lee) #49048
[8c33731ac6] - src: add a condition if the argument of DomainToUnicode is empty (Jungku Lee) #49097
[67dba57d77] - src: use ARES_SUCCESS instead of 0 (Hyunjin Kim) #48834
[97d87495c7] - src: remove unnecessary temporary creation (Jason) #48734
[f5384c3262] - src: fix nullptr access on realm (Jan Olaf Krems) #48802
[358273d77f] - src: remove OnScopeLeaveImpl's move assignment overload (Jason) #48732
[cc7bf1f641] - (SEMVER-MINOR) src: add cjs_module_lexer_version base64_version (Jithil P Ponnan) #45629
[0a950c3752] - src: add missing to_ascii method in dns queries (Daniel Lemire) #48354
[3552afb904] - src: fix duplication of externalized builtin code (Keyhan Vakil) #47079
[66e4ba5062] - src: fix AliasedBuffer memory attribution in heap snapshots (Joyee Cheung) #46817
[946f19b5e3] - src: move AliasedBuffer implementation to -inl.h (Joyee Cheung) #46817
[d35f8702c9] - src: bootstrap prepare stack trace callback in shadow realm (Chengzhong Wu) #47107
[3551a19205] - src: make BuiltinLoader threadsafe and non-global (Anna Henningsen) #45942
[92311a0801] - src: define per-isolate internal bindings registration callback (Chengzhong Wu) #45547
[629fc774ca] - src: use an array for faster binding data lookup (Joyee Cheung) #46620
[62e2e590fc] - src: fix TLSWrap lifetime bug in ALPN callback (Ben Noordhuis) #49635
[fae60c5841] - stream: use bitmap in readable state (Benjamin Gruenbaum) #49745
[ee4fc7d78c] - stream: use Buffer.from when constructor is a Buffer (Matthew Aitken) #49250
[651e4504ce] - stream: add highWaterMark for the map operator (Raz Luvaton) #49249
[d585d13127] - stream: improve WebStreams performance (Raz Luvaton) #49089
[7f39f8e805] - test: replace forEach with for..of in test-http-perf_hooks.js (Niya Shiyas) #49818
[2f0ffde842] - test: replace forEach with for..of in test-net-isipv4.js (Niya Shiyas) #49822
[bbd302b5ab] - test: replace forEach with for..of in test-http2-server (Niya Shiyas) #49819
[128ca3e213] - test: replace forEach with for..of in test-http2-client-destroy.js (Niya Shiyas) #49820
[a2ca1a605f] - test: print instruction for creating missing snapshot in assertSnapshot (Raz Luvaton) #48914
[a0bb30cdca] - test: set test-watch-mode-inspect as flaky (Yagiz Nizipli) #50259
[1047d95698] - test: set test-emit-after-on-destroyed as flaky (Yagiz Nizipli) #50246
[91a3b57962] - test: set inspector async stack test as flaky (Yagiz Nizipli) #50244
[b41aa7b82a] - test: set test-worker-nearheaplimit-deadlock flaky (StefanStojanovic) #50277
[e81b066fb1] - test: set test-cli-node-options as flaky (Yagiz Nizipli) #50296
[0c05c25c4e] - test: set crypto-timing test as flaky (Yagiz Nizipli) #50232
[83e339dbba] - test: set test-structuredclone-* as flaky (Yagiz Nizipli) #50261
[866a399488] - test: set inspector async hook test as flaky (Yagiz Nizipli) #50252
[cb0bd2116b] - test: set parallel http server test as flaky (Yagiz Nizipli) #50227
[54f3d877ae] - test: set test-worker-nearheaplimit-deadlock flaky (Stefan Stojanovic) #50238
[5953a255b6] - test: set test-runner-watch-mode as flaky (Yagiz Nizipli) #50221
[5820d7e14d] - test: deflake test-runner-output (Moshe Atlow) #49878
[1d75da43f2] - Revert "test: mark test-http-regr-gh-2928 as flaky" (Luigi Pinca) #49708
[[5df23520e7](htt

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: pnpm-lock.yaml
[08:15:55.356] INFO (271): Installing tool pnpm v8.10.5...
[08:15:56.356] FATAL (271): EACCES: permission denied, open '/usr/local/bin/pnpm'
    err: {
      "type": "Error",
      "message": "EACCES: permission denied, open '/usr/local/bin/pnpm'",
      "stack":
          Error: EACCES: permission denied, open '/usr/local/bin/pnpm'
      "errno": -13,
      "code": "EACCES",
      "syscall": "open",
      "path": "/usr/local/bin/pnpm"
    }
[08:15:56.410] INFO (271): Installed tool pnpm with errors in 1s.


Update deps for 1.1rc2

This is identical to @utka's https://github.com/istio/istio/pull/12199 except I updated the proxy sha by one commit to pick up https://github.com/istio/proxy/pull/2135

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: duderino
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: duderino, mandarjog
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@duderino: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
74465ad0aedd4319e3250ed0116dedae628e8018
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@duderino: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
74465ad0aedd4319e3250ed0116dedae628e8018
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
74465ad0aedd4319e3250ed0116dedae628e8018
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


UI hanging during slow syntax highlighting

Lapce Version
0.3.1, but it was already the case back when I started using Lapce in the 0.2.X series
System information
Debian 12 (sway WM)
Describe the bug
When editing a large (>100kB, >1500 lines) LaTeX file with syntax highlighting, the UI becomes unresponsive (for up to several seconds) at each keystroke.
Additional information
This goes away when selecting "plain text" as the language for the syntax highlighting.
I believe (purely from the way the delay behaves, I did not get to look at the code) it might be a combination of slow syntax highlighting and the UI synchronously waiting for it to complete whenever a change is made to the file.

nevermind, a better search in existing issues found https://github.com/lapce/lapce/issues/2147.
This current issue is a duplicate. closing...


Created new component RucioInjector

Fixes #9065
Status
In development
Description
Created a new WMAgent component called RucioInjector. In more details, this PR provides:

RucioInjector configuration section, where we can disable the component; disable block rules creation; disable rules creation for a list of datatiers; etc
moved ALL the DAOs from the PhEDExInjector package to the RucioInjector one
keep 24h cache for containers and blocks already injected into Rucio
create a simple block rule (rse=RSE & grouping=DATASET) for every block inserted into Rucio
retry (in the next cycle) files that failed to have their dbsbuffer state updated
close blocks that have already been migrated to DBS
create standard container rules as configured in the workflows. Rule is like rse=RSE & grouping=ALL
added meta-data to rules creation (basic info for now)
NOTE: we have dropped the validation of data location against valid PNNs (now RSEs)

In addition to the new component, I can list:

implemented a Utils MemoryCache module for data caching in memory
extended the Rucio wrapper API to also support:

listing the full history of rules for a given container/block
and a method to delete a given rule

TODO: check error handling, like an operation succeeding in Rucio but failing in dbsbuffer.
TODO: understand the full logic of block deletion and reimplement it
TODO: update the deployment scripts
Is it backward compatible (if not, which system it affects?)
no
Related PRs
none
External dependencies / deployment changes
Yes, these deployment changes: https://github.com/dmwm/deployment/pull/885

@ericvaandering @nsmith- Eric, Nick, would you mind having a general look at these changes.
The initial comment should list most of the changes that went in.
I have just added some meta data to rules/blocks as well. It will let a workflow running to see whether that works or not.
I still have to think how to properly implement the data deletion used by T0 though...

Nick/Eric, from the discussion we had this week. I have done a few tests providing meta-data and my findings are:

Rucio CLI documentation says it has to be a python dictionary, but actually it needs to be a json string (json.dumps)
the server returns an error (server_error) if we provide metadata during block creation
it seems to work fine for rule creation for blocks

Fresh examples for rules with comments and metadata information are:
2020-04-08 22:03:51,681:139798235088640:INFO:RucioInjectorPoller:Block rule created for /DYJetsToLL_Pt-50To100_TuneCUETP8M1_13TeV-amcatnloFXFX-pythia8/DMWM_Test-StepChain_MC_April2020_Val_Privv4-v20/LHE#cb61210c-5644-42ed-96ec-0d47eec812a0 under rule id: [u'de3a83f598d7438c89843554f5f80f88']
2020-04-08 22:03:51,832:139798235088640:INFO:RucioInjectorPoller:Block rule created for /DoubleMuon/DMWM_Test-ReReco_badBlocks_April2020_Val_Privv4-v11/DQMIO#75e04dae-a7bf-4288-a189-c287281dfcd6 under rule id: [u'dc25779d41824245b9989560544538db']

Todor, you raised a valid concern about that cache module. We have two options here:

constrain the object types we can store in the cache (but make the module safer)
allow free flexibility for the data types, but having a user-mistake susceptible code

I decided for option 2), but giving it further thought, I might change it to 1) and if the user has an object unsupported, he has to write his own cache...

@todor-ivanov from your comment, I modified MemoryCache to support only a small set of object types.

@nsmith- Nick, thank you for your comments. I think I replied to all of them.
Just for the record, this PR is meant to provide the basic functionality of a Rucio injector component.
I still have other issues created for filtering out datatiers, massaging rule creation/deletion, etc.

Ok, I didn't mean for this to snowball but its very convenient to discuss requirements with a skeleton code strawman to attack :)

No worries Nick, better now than once it's in production ;)
BTW, I have made further changes to the code as per our discussion, including the order swap of rule creation and replica creation.

Ok, I regret not clicking an actual review so that I can resolve comments, but I think everything I brought up is either settled or spun into an issue so I'm happy.

Tests went fine, a few follow up issues were created. So I'm merging it now.
It needs to be backported to the wmagent branch though, I just want to get another fix in place before I start cherry-picking those.


Error on save

I'm getting this error on save:
Error detected while processing function <SNR>105_FileUpdate:
line    4:
E716: Key not present in Dictionary: IsOpen()
E15: Invalid expression: !g:NERDTree.IsOpen()
line   10:
E716: Key not present in Dictionary: CursorToTreeWin
line   11:
E121: Undefined variable: b:NERDTreeRoot
E15: Invalid expression: b:NERDTreeRoot.findNode(g:NERDTreePath.New(a:fname))
line   12:
E121: Undefined variable: node
E15: Invalid expression: node == {}
line   15:
E121: Undefined variable: node
line   16:
E121: Undefined variable: node
E15: Invalid expression: node.parent
line   17:
E121: Undefined variable: node
E116: Invalid arguments for function empty(node)
E15: Invalid expression: !empty(node)
Error detected while processing function <SNR>105_FileUpdate..NERDTreeRender..nerdtree#renderView:
line    1:
E121: Undefined variable: b:NERDTree

Please let me know what other information you might need to help?

Just update both of nerdtree and nerdtree-git-plugin.

Thanks!

I just did a fresh install, and I'm having the same problem.

@ccompeau have you updated nerdtree?

I had the same problem... After VundleUpdate it's gone. Thanks

@mugukamil could you show me your vimrc?

" ------------------------------
"  Regular Vim Configuration
" ------------------------------

" Color
colorscheme hybrid
" Force 256 color mode if available
if $TERM =~ "-256color"
  set t_Co=256
endif

" UI
set ruler
set number
set cursorline
set laststatus=2
set cmdheight=1
set encoding=utf-8
set noshowmode
set title
set ttyfast
set ttyscroll=3
set lazyredraw
set wrap

" Behaviors
syntax enable
set autoread
set wildmenu
set hidden
set history=768
set cf
set clipboard+=unnamed
set autowrite
set scrolloff=3
set gdefault
set switchbuf=useopen

" Text Format
set ts=2 sts=2 sw=2 expandtab
set autoindent
set cindent
set smartindent

" Searching
set ignorecase
set smartcase
set incsearch
set wildignore+=*.o,*.obj,*.exe,*.so,*.dll,*.pyc,.svn,.hg,.bzr,.git,
  \.sass-cache,*.class,*.scssc,*.cssc,sprockets%*,*.lessc,*/node_modules/*

" Visual
set showmatch
set matchtime=2
set list
set listchars=tab:▸\ ,eol:¬,nbsp:⋅,trail:•

" Sounds
set noerrorbells
set novisualbell
set t_vb=

" Mouse
set mousehide
set mouse=a

set complete=.,w,b,u,U

" Plugins settings
let g:airline_powerline_fonts = 1
let g:airline_mode_map = {}
let g:airline#extensions#tabline#fnamemod=':t'
"let g:airline#extensions#tabline#show_buffers=1
let g:airline#extensions#tabline#buffer_nr_show=1
let g:airline_theme = 'lucius'


Ensembl back alignment data

@ahwagner when talking about #76 :

7:140,485,608, which aligns directly adjacent to ENST00000644969.2_6 / NM_001374258.1 (browser view). Note that the RefSeq identifier is the same, and the Ensembl identifier has a trailing _6, indicating it is the sixth version of the back-alignment of ENST00000644969.2 to GRCh37 provided by ENSEMBL

We currently do not have any back alignment data. Ensembl has been a constant issue when querying UTA db. We should look into this. #4  is similar

Also https://github.com/biocommons/uta/issues/233. Yeah, we should look into it. But don't let that block #76; let's get that one completed (without ENST support) and then come back to this issue.


A little clean up to enhance reusability

Thank you!
Nice work :+1:

@all-contributors please add @dammynex  for code


[WSL --list --online] command is missing Ubuntu 22.04

Version
Windows version: 10.0.19045.2311
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
No response
Other Software
No response
Repro Steps
wsl --list --online
Expected Behavior
Ubuntu 22.04 LTS is listed among available distributions.
I see it can be installed through MS Store, also I am downloading the appx package from https://aka.ms/wslubuntu2204
Actual Behavior
PS C:\Users\colem> wsl --list --online
The following is a list of valid distributions that can be installed.
Install using 'wsl.exe --install <Distro>'.

NAME               FRIENDLY NAME
Ubuntu             Ubuntu
Debian             Debian GNU/Linux
kali-linux         Kali Linux Rolling
SLES-12            SUSE Linux Enterprise Server v12
SLES-15            SUSE Linux Enterprise Server v15
Ubuntu-18.04       Ubuntu 18.04 LTS
Ubuntu-20.04       Ubuntu 20.04 LTS
OracleLinux_8_5    Oracle Linux 8.5
OracleLinux_7_9    Oracle Linux 7.9

Diagnostic Logs
No response

Understood.
Thank you.

This is not fixed. Ubuntu is still the 20.04 version.

Latest version of Ubuntu can be downloaded from here https://apps.microsoft.com/store/search?hl=en-us&gl=us&publisher=Canonical Group Limited

@Biswa96 It's not for me. It's for all people.


Add eslint plugin for detecting redos vulnerabilities and tweak regex ip regex to prevent backtracks

This adds and configures eslint-plugin-redos-detector (fyi I'm the author of that), and then updates the ipv4 regex so that it's no longer flagged as a potential problem and moves the ipv6 check to a function which I think is a bit easier to follow, and doesn't trigger the linter.
This would have caught the email redos (2ba00fe2377f4d53947a84b8cdb314a63bbd6dd4), but better late than never?
Let me know what you think :)

Thanks for the great work and I appreciate this PR, but Zod's actually moving away from eslint imminently, so I'm going to close this.
Zod also now relies on a fair number of dynamically generated regexes, so I think the best approach to addressing this issue is adding runtime tests using https://www.npmjs.com/package/redos-detector or similar, which I'll do shortly in the v4 branch.

Sounds good. Let me know if you hit any issues :)

Runtime might not be good for performance though


Flutter web hangs when downloading file on Chrome

I can reproduce this in Chrome, but not in Firefox or Safari, so maybe this is something for @addyosman to look into.
I've got a flutter web app, build with flutter version 3.22.2. When I click a button to download a file, the download animation happens and immediately afterwards the flutter web app becomes unresponsive to clicks and scrolls. Switching to another tab and then back unfreezes the page, as well as switching to another (not Chrome) application. Using the latest Chrome version on macOS, 126.0.6478.62 (Universal). changing tabs or switching to another app unlocks the hang. So it seems like the download popup on Chrome is causing the tab to be in a frozen state.
Links to related Chrome support issues:
https://support.google.com/chrome/thread/280608434?hl=en&sjid=30753122648466353-NC
https://support.google.com/chrome/thread/280904881?hl=en&sjid=16115862103674561801-NA
https://support.google.com/chrome/thread/280905329?hl=en&sjid=375371675249558091-EU
Steps to reproduce
A sample app source can be found here: https://github.com/milke/chrome_bug
Run that flutter app on Web in, for example, VSCode debugger, click the Crash Me button. It hangs the UI.
Expected results
After clicking on a button to download a file in Chrome, the UI of the flutter web app should not freeze.
Actual results
After clicking a button to download a file, the download animation happens and immediately afterwards the flutter web app becomes unresponsive to clicks and scrolls. Switching to another tab and then back unfreezes the page, as well as switching to another application
Code sample
In my case, any code that causes Chrome to download a file shows this issue and I tried various methods. For example:
import 'package:url_launcher/url_launcher.dart' as launcher;

launcher.launchUrl(
    Uri.parse('https://get.cocoatech.com/dashboard/Deckr-macos.dmg'),
    webOnlyWindowName:   '_self',
);

Also can be reproduced visiting this site in Chrome and clicking on any of buttons to download files/binaries: https://deckr.surf/
We tried downloading with alternate code, so it seems not to be a bug in url_launcher.  The sample app is just the simplest code. Any download on chrome will hang flutter web. Also reproducible on a few other flutter websites I know of, with a download button.
Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.6 23G5052d darwin-arm64, locale en-US)
• Flutter version 3.22.2 on channel stable at /Users/milke/Developer/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 761747bfc5 (2 weeks ago), 2024-06-05 22:15:13 +0200
• Engine revision edd8546116
• Dart version 3.4.3
• DevTools version 2.34.3
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from: https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK components.
(or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
If the Android SDK has been installed to a custom location, please use
flutter config --android-sdk to update to that location.
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15E204a
• CocoaPods version 1.15.0
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
[✓] Connected device (3 available)
• macOS (desktop)                             • macos                              • darwin-arm64  • macOS 14.6 23G5052d darwin-arm64
• Mac Designed for iPad (desktop)  • mac-designed-for-ipad  • darwin                • macOS 14.6 23G5052d darwin-arm64
• Chrome (web)                                  • chrome                             • web-javascript  • Google Chrome 126.0.6478.62
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 2 categories.

Closing this as a duplicate of https://github.com/flutter/flutter/issues/150523


[e2e]: generic workflow_dispatch main workflow_inputs slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3148738934
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Thu Sep 29 05:01:08 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3156420528
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Fri Sep 30 05:10:00 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3163235855
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Sat Oct  1 05:04:43 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3167327356
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Sun Oct  2 05:05:26 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3171474837
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon Oct  3 04:19:08 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3176048082
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon Oct  3 17:42:27 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3176804365
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.main.workflow_inputs.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon Oct  3 19:53:33 UTC 2022
Tests are passing now. Closing this issue.


Storage module won't keep connection

I'm using the direwolf 20 modpack. Playing in a biomes o plenty map. If I start a new game and throw down a few components (enderio creative power, storage scanner, chest) it works. But if I go to a survival world and play for a while (been using mostly immersive engineering for power etc) the storage module will not work. I shift right click it on the storage scanner and it says it connected. But when I place that module in a screen or a tablet it says that it is not connected. I've tried breaking down the whole system and placing it in a new area but still get the same results. The scanner and the tablet are powered. The screen works with other modules such as a button connected to a receiver. The only part that isn't working is the storage module.
edited for clarity...

Is the scanner chunkloaded?
Also what version?

Scanner is chunk loaded. Not working even while standing right next to it. I'm using rftools-1.1x-5.71.

Can you show a full screenshot of your setup? I need more information because this is something that works fine for me.
Also 1.10 or 1.11?

MC: 1.10.2
Forge:

<IP_ADDRESS>5

That's really strange. I'll check it out but for now I have no explanation

BTW does the tablet have power? i.e. did you charge it?

This issue is being caused by the iron backpacks mod. When you wear an iron backpack that has the quick deposit upgrade, the client-side and iron backpack mod is stealing the shift-right click and the action is not sent to the server. This means the linking of the storage module to the scanner never actually happens though it looks like it on the client-side. This is a known bug in iron backpacks mod and the author has said he is working on it. In the mean time, unequip your iron backpack before doing shift-right click actions on entities.


Date and Time picker click away to collapse behavioural inconsistency causing popover overlaps

The date and time pickers do not collapse

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
After expanding a date or time picker popover when I click away to expand a different popover (e.g. Autocomplete) the popover should collapse.  Instead the original date/time picker popover is still expanded with the AutoComplete appearing on top.  If I clickaway at this point the autocomplete popover is dismissed correctly, however the underlying date/time picker can no longer be dismissed without selecting a value.  This can then lead to the 3rd image where the popovers all start to overlap
e.g.
TimePicker Overlap

DatePicker Overlap

Multi Popover Overlap

Expected Behavior 🤔
The Autocomplete behaviour seems the safest, in that any click away from the popover should dismiss, permitting only one popover at a time.  This includes the action trigger which toggles the open state (rather doing nothing when expanded)
Steps to Reproduce 🕹
https://codesandbox.io/s/datetimepicker-popover-collapse-inconsistency-c9f5t?file=/demo.tsx
Steps:

Click on action trigger of date picker to expand popover
Click on action trigger of autocomplete to expand list  (will now overlap date picker popover)
Click away to dismiss autocomplete
Click away to dismiss date picker (does not trigger collapse)

Your Environment 🌎

Tech
Version

@material-ui/core
5.0.0-alpha.10

@material-ui/lab
5.0.0-alpha.10

@material-ui/pickers
4.0.0.alpha.12

React
16.13.1

Browser
Chrome

TypeScript
4.0.3

To clarify further: this behaviour has been introduced in the new version.  The current stable version collapses appropriately, not permitting multiple popovers at the same time.


How can I make Pinia RC working when build for production with Vite

Reproduction
I am using Vue v3.2  with Pinia v2.0.0-rc.2. with script setup It works fine when I run locally with vite dev, but when build for production I got error in console

Steps to reproduce the behavior

vite build
vite preview

My Repo
https://github.com/pakornvs/vite-pinia-test

Thanks! Fixed and released


Remove need to explicitly deregister helios agents?

Remove need to explicitly deregister helios agents when a host with the same hostname as a down agent tries to register. This happens when someone reinstalls their agent machine.
Lots of users get tripped up by this. This behavior doesn't seem to be very useful.

What happens if a new agent is registered replacing the old one, but the old one is actually still running its jobs?

We should prohibit replacement of a registered agent that's UP and require explicit deregistration first. Only allow replacement of registered agents that are DOWN.

Yes! We've stumbled on this a few times. :sparkling_heart:

@rasmusbergpalm My tests in this PR https://github.com/spotify/helios/issues/382 above keep failing. I haven't had time to fix it though.


** Feature Request ** Move Constants from Implementation file to header in ALRegisterUserClientService.m

Goals
To subclass ALRegisterUserClientService to perform additional actions on Registration and Logout.
Expected Results
to Sublcass and override without compiler errors
Actual Results
Getting a compilation error as the defined constants do not exist. Can the defines be moved to the .h file instead?
Steps to Reproduce

Subclass ALRegisterUserClientService.
Copy and paste method logoutWithCompletionHandler in Subclassed.m file.
Observe : LOGOUT_URL use of undeclared identifier.

Code Sample

-(void)logoutWithCompletionHandler:(void(^)(ALAPIResponse *response, NSError *error))completion
{
    NSString *urlString = [NSString stringWithFormat:@"%@%@",KBASE_URL,LOGOUT_URL];
    NSMutableURLRequest * request = [ALRequestHandler createPOSTRequestWithUrlString:urlString paramString:nil];
    ...
}

error: use of undeclared identifier

Can you create a PR? We will be happy to merge if it works.

Thanks. PR created.


fix: export FastStringV8AllocationError

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.30%. Comparing base (0c7f83e) to head (87fbc12).
Report is 206 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
- Coverage   81.43%   81.30%   -0.14%
==========================================
  Files          97       99       +2
  Lines       23877    26093    +2216
==========================================
+ Hits        19445    21215    +1770
- Misses       4432     4878     +446

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Separate quick-action from station highlight

It would be nice to have the option to have the stations light up for quick-action even if the baseline highlighting is off, or if you're making a pot that doesn't match the one the plugin thinks you should be making.

As a workaround here, you could set the baseline highlighting opacity to 0, so it's fully transparent. Then you'd still have the quick action highlighting.
A little additional thing here, It'd be nice if we could also have a tick count down to the quick-action for the pump / alambic mixing station.
Considering that it's consistently 5 pumps for the first action (or 7 pumps for any missed action), it could be a cool feature :).

Agreed. Right now, if you were to make 2 or 3 potions in a row at the stations, the quick-action will only light up for the first potion you make. I think your suggestion would be the best fix.

Addressed by c034e9e37b433b5e9d78867ebe590a58b12ec3d8


Fix typo in documentation 13.1.2. Caching configuration properties

Motivation

I found a typo while reading docs.
I'm reading it useful. Thank you.
To fIx typo in documentation 13.1.2. Caching configuration properties
Details (Actual typo)

@Sanne Hello, thank you for merge.
While reading Docs, I found a missing example code.
Example code number 540 is missing in '15.3.6. Query result transformers'.
Should I fill out a ticket to jira for this part? Or is it a known issue?
Attached is the picture below.


[go_router] Inconsistent Route Matching with URL Fragments

Is there an existing issue for this?

[X] I have searched the existing package issues
[X] I have read the guide to filing a bug

What package does this bug report belong to?
go_router
What target platforms are you seeing this bug on?
Android
Have you already upgraded your packages?
Yes
Dependency versions
pubspec.lock
# Generated by pub
# See https://dart.dev/tools/pub/glossary#lockfile
packages:
  async:
    dependency: transitive
    description:
      name: async
      sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c"
      url: "https://pub.dev"
    source: hosted
    version: "2.11.0"
  boolean_selector:
    dependency: transitive
    description:
      name: boolean_selector
      sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  characters:
    dependency: transitive
    description:
      name: characters
      sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.0"
  clock:
    dependency: transitive
    description:
      name: clock
      sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf
      url: "https://pub.dev"
    source: hosted
    version: "1.1.1"
  collection:
    dependency: transitive
    description:
      name: collection
      sha256: f092b211a4319e98e5ff58223576de6c2803db36221657b46c82574721240687
      url: "https://pub.dev"
    source: hosted
    version: "1.17.2"
  cupertino_icons:
    dependency: "direct main"
    description:
      name: cupertino_icons
      sha256: e35129dc44c9118cee2a5603506d823bab99c68393879edb440e0090d07586be
      url: "https://pub.dev"
    source: hosted
    version: "1.0.5"
  fake_async:
    dependency: transitive
    description:
      name: fake_async
      sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.1"
  flutter:
    dependency: "direct main"
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_lints:
    dependency: "direct dev"
    description:
      name: flutter_lints
      sha256: a25a15ebbdfc33ab1cd26c63a6ee519df92338a9c10f122adda92938253bef04
      url: "https://pub.dev"
    source: hosted
    version: "2.0.3"
  flutter_test:
    dependency: "direct dev"
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_web_plugins:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.0"
  go_router:
    dependency: "direct main"
    description:
      name: go_router
      sha256: "5668e6d3dbcb2d0dfa25f7567554b88c57e1e3f3c440b672b24d4a9477017d5b"
      url: "https://pub.dev"
    source: hosted
    version: "10.1.2"
  lints:
    dependency: transitive
    description:
      name: lints
      sha256: "0a217c6c989d21039f1498c3ed9f3ed71b354e69873f13a8dfc3c9fe76f1b452"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  logging:
    dependency: transitive
    description:
      name: logging
      sha256: "623a88c9594aa774443aa3eb2d41807a48486b5613e67599fb4c41c0ad47c340"
      url: "https://pub.dev"
    source: hosted
    version: "1.2.0"
  matcher:
    dependency: transitive
    description:
      name: matcher
      sha256: "1803e76e6653768d64ed8ff2e1e67bea3ad4b923eb5c56a295c3e634bad5960e"
      url: "https://pub.dev"
    source: hosted
    version: "0.12.16"
  material_color_utilities:
    dependency: transitive
    description:
      name: material_color_utilities
      sha256: "9528f2f296073ff54cb9fee677df673ace1218163c3bc7628093e7eed5203d41"
      url: "https://pub.dev"
    source: hosted
    version: "0.5.0"
  meta:
    dependency: transitive
    description:
      name: meta
      sha256: "3c74dbf8763d36539f114c799d8a2d87343b5067e9d796ca22b5eb8437090ee3"
      url: "https://pub.dev"
    source: hosted
    version: "1.9.1"
  path:
    dependency: transitive
    description:
      name: path
      sha256: "8829d8a55c13fc0e37127c29fedf290c102f4e40ae94ada574091fe0ff96c917"
      url: "https://pub.dev"
    source: hosted
    version: "1.8.3"
  sky_engine:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.99"
  source_span:
    dependency: transitive
    description:
      name: source_span
      sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c"
      url: "https://pub.dev"
    source: hosted
    version: "1.10.0"
  stack_trace:
    dependency: transitive
    description:
      name: stack_trace
      sha256: c3c7d8edb15bee7f0f74debd4b9c5f3c2ea86766fe4178eb2a18eb30a0bdaed5
      url: "https://pub.dev"
    source: hosted
    version: "1.11.0"
  stream_channel:
    dependency: transitive
    description:
      name: stream_channel
      sha256: "83615bee9045c1d322bbbd1ba209b7a749c2cbcdcb3fdd1df8eb488b3279c1c8"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  string_scanner:
    dependency: transitive
    description:
      name: string_scanner
      sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
      url: "https://pub.dev"
    source: hosted
    version: "1.2.0"
  term_glyph:
    dependency: transitive
    description:
      name: term_glyph
      sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84
      url: "https://pub.dev"
    source: hosted
    version: "1.2.1"
  test_api:
    dependency: transitive
    description:
      name: test_api
      sha256: "75760ffd7786fffdfb9597c35c5b27eaeec82be8edfb6d71d32651128ed7aab8"
      url: "https://pub.dev"
    source: hosted
    version: "0.6.0"
  vector_math:
    dependency: transitive
    description:
      name: vector_math
      sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.4"
  web:
    dependency: transitive
    description:
      name: web
      sha256: dc8ccd225a2005c1be616fe02951e2e342092edf968cf0844220383757ef8f10
      url: "https://pub.dev"
    source: hosted
    version: "0.1.4-beta"
sdks:
  dart: ">=3.1.0 <4.0.0"
  flutter: ">=3.7.0"

Steps to reproduce

Clone the minimal example from my GitHub repo here.
Run the app on an Android device or emulator.
Use ADB to trigger URL intents:

adb shell am start -a android.intent.action.VIEW -d "uriParamBug://example/#/home"
adb shell am start -a android.intent.action.VIEW -d "uriParamBug://example/home"

Expected results
Both URL intents should navigate to the 'home' route inside the Flutter app.
Actual results

The intent adb shell am start -a android.intent.action.VIEW -d "uriParamBug://example/home" routes correctly to 'home'.
The intent adb shell am start -a android.intent.action.VIEW -d "uriParamBug://example/#/home" fails to route to 'home' and instead lands on an incorrect or default page.

Code sample
A minimal reproducible example can be found here https://github.com/AristideVB/uri_param_bug
The core snippet is as follows
void main() {
  runApp(const MyApp());
}

final _router = GoRouter(
  routes: [
    GoRoute(
      path: '/',
      builder: (context, state) {
        return const MyHomePage(
          uri: '',
          routeName: 'Initial',
        );
      },
      routes: [
        GoRoute(
          path: 'home',
          name: 'home',
          builder: (context, state) => MyHomePage(
            uri: state.uri.toString(),
            routeName: 'Home',
          ),
        ),
      ],
    ),
  ],
);

Screenshots or Videos

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.13.4, on macOS 13.5.2 22G91 darwin-arm64, locale fr-FR)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.82.2)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

Why should the "uriParamBug://example/#/home" land on the /home page?
shouldn't it be landing on / with fragment equals to /home ?

Hello @chunhtai  thank you for following up

Firstly because on iOS "uriParamBug://example/#/home" does land on the /home page

Open the app in an iOS simulator and run xcrun simctl openurl booted "uriParamBug://example/home"
Behavior should be the same on both iOS & Android

Secondly because if you have a matching Flutter Web App along side your mobile versions of the app you are most likely in need of using the hash in your URLs for your web app to work correctly.

And you want a URL you send to your users to open the same route whether they have your app installed or are directed to your web app.
For example this reset password link sent to the user<EMAIL_ADDRESS>should open the same route reset-password route either in your mobile app or your flutter web app
🙏

For now what I've done on the Flutter side to fix the issue is to add some redirect logic specific for the mobile versions of the app
redirect: (BuildContext context, GoRouterState state) async {
    if (state.uri.path == '/' && state.uri.fragment != '') {
      return state.uri.fragment;
    }

    return null;
  },

The hash strategy in web is a inconventional solution to help developer to setup their server without path matching. It doesn't make sense to change how go_router parse uri because of that. This will break other people if they use hash fragment in the conventional way.

Close as inactive.


Unable to load script rpa_python.js - access issue? please raise issue to RPA for Python

Brand new windows 2016/2019 server with Python3.8 installed and I can't get RPA to initialize at all.
PS C:\Users\Administrator> pip install rpa
Collecting rpa
Downloading rpa-1.27.1.tar.gz (5.6 kB)
Collecting tagui>=1.27.1
Downloading tagui-1.27.1.tar.gz (23 kB)
Using legacy setup.py install for rpa, since package 'wheel' is not installed.
Using legacy setup.py install for tagui, since package 'wheel' is not installed.
Installing collected packages: tagui, rpa
Running setup.py install for tagui ... done
Running setup.py install for rpa ... done
Successfully installed rpa-1.27.1 tagui-1.27.1
PS C:\Users\Administrator> python.exe
Python 3.8.5 (tags/v3.8.5:580fbb0, Jul 20 2020, 15:57:54) [MSC v.1924 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

import rpa as r
r.init()
[RPA][ERROR] - following happens when starting TagUI...

Unable to load script C:\Users\Administrator\rpa_python.js; check file syntax
phantomjs://code/bootstrap.js:113 in __die
False

Same here

Sorry Guys I was away the past few months - https://github.com/tebelorg/RPA-Python/issues/144
RPA for Python is a personal side project, please raise the issue here - https://github.com/tebelorg/RPA-Python/issues
However, I most likely won't have time to work on it for now. Catching up with issues raised here past few months. Closing the issue here. From the error message above, it looks like a user file permissions access issue.
Maybe the package can't write to the c:\users\administrator directory. Try to run from your user desktop folder to see if it helps. Another thing to try is opening command prompt as administrator to see if that helps.

I met same error ,please refer to @kensoh reply https://github.com/tebelorg/RPA-Python/issues/151,and first make sure tagui can work in cmd line:https://tagui.readthedocs.io/en/latest/setup.html.I found my err was that missing windows C++ files，It can work after i installed the  windwows sys file.

I can't run commands of the type r.click('abc.png') or r.click('path/abc.png'). I am running rpa on an M1 (2020) mac.
Things I have already tried:

Downsizing the image to 72 ppi
Test given here https://tagui.readthedocs.io/en/latest/setup.html
reinstalling Correto
Enabled accesibility to terminal and AEServer in Security and Privacy(Here Java doesn't show up for me, but AEServer does)
When I run the google.tag command I get the following response

ln: /usr/local/bin/tagui: No such file or directory
zsh: command not found: tagui

Lastly the rpa_python.log file says

Unable to open file: /Users/username/Documents/SBOM/rpa_python.js
phantomjs://code/bootstrap.js:113 in __die
Unable to load script /Users/username/Documents/SBOM/rpa_python.js; check file syntax
phantomjs://code/bootstrap.js:113 in __die

Install PHP manually this way - https://github.com/tebelorg/RPA-Python/issues/335#issuecomment-989470056
Mac started removing PHP in newer releases of macOS. Inferring from your rpa_python.log error. Copying @ruthtxh

I have already installed php 8.1.8. using Homebrew. Still doesn't work. Also, java doesn't appear for me in Privacy>Accessibility  as mentioned here https://github.com/tebelorg/RPA-Python/issues/78
but terminal and AEServer does. Could this have something to do with it?

Install Java from https://aws.amazon.com/corretto choose OpenJDK v8 (64-bit).
Try typing php -v from your Mac terminal and see what happens. Mine works with v8.1.1.
PHP 8.1.1 (cli) (built: Jan  8 2022 08:29:30) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.1, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.1, Copyright (c), by Zend Technologies


Improve error message when CreateMigrationSource is called with insufficient permissions

When using the migrate-repo command, under the hood, we call the CreateMigrationSource GraphQL mutation. If your target PAT doesn't have the correct permissions, the API returns an error like this:

timrogers does not have the correct permissions to execute CreateMigrationSource

This error isn't very helpful, as it doesn't tell you what you should do to fix it. It would be great to have a more instructive error message that guides the customer on where they've gone wrong.
It isn't trivial for us to change the actual error returned by the API because it is part of GitHub's shared GraphQL logic. This takes a different approach: catching the specific error and decorating the message with some more helpful guidance on what to do next.

[x] Did you write/update appropriate tests
[x] Release notes updated (if appropriate)
[x] Appropriate logging output
[ ] Issue linked
[ ] Docs updated (or issue created)
[ ] New package licenses are added to ThirdPartyNotices.txt (if applicable)

This all looks pretty good to me, a couple tweaks I would make:

You can use pattern matching in the catch block
Preserve the original exception in InnerException by passing it into the ctor

something like this
catch (OctoshiftCliException ex) when (ex.Message.Contains("blah blah permissions")
{
  throw new OctoshiftCliException(ex.Message + PERMISSIONS_ERROR_MSG, ex);
}

This all looks pretty good to me, a couple tweaks I would make:

You can use pattern matching in the catch block
Preserve the original exception in InnerException by passing it into the ctor

something like this
catch (OctoshiftCliException ex) when (ex.Message.Contains("blah blah permissions")
{
  throw new OctoshiftCliException(ex.Message + PERMISSIONS_ERROR_MSG, ex);
}

Thanks! Two C# features I didn't know about there. Let me make those changes and ping for re-review.
P.S. I know I could have created an issue to do this, but this error message came up in a Bitbucket Server customer issue today, and I figured it would be quicker to fix it myself than write an issue.

@dylan-smith Updated! ✅ I refactored out CheckForMissingPermissionsError since it doesn't seem to fit well with the pattern matching, but I'm open to feedback.


Remove version: Jackett.Jackett version 0.21.132

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.21.132/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)


Add a Java example for Cloud Bigtable scheduled backups solution.

Fixes #issue

It's a good idea to open an issue first for discussion.

[X] I have followed Sample Format Guide
[X] pom.xml parent set to latest shared-configuration
[ ] Appropriate changes to README are included in PR
[ ] API's need to be enabled to test (tell us)
[ ] Environment Variables need to be set (ask us to set them)
[X] Tests pass:   mvn clean verify required
[X] Lint  passes: mvn -P lint checkstyle:check required
[ ] Static Analysis:  mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
[ ] Please merge this PR for me once it is approved.

Hi @TracyCuiCan, thanks for the PR! I'll take a first pass at a review. It looks like the tests are failing on our CI with this message:
******************** TESTING PROJECTS ********************
------------------------------------------------------------
- testing bigtable/scheduled-backups
------------------------------------------------------------
Testing failed: Unable to determine Java version. Please set in pom:

<properties>
  <maven.compiler.target>1.8</maven.compiler.target>
  <maven.compiler.source>1.8</maven.compiler.source>
</properties>

Can you update the pom.xml file to include this?

Hi @TracyCuiCan, thanks for the PR! I'll take a first pass at a review. It looks like the tests are failing on our CI with this message:
******************** TESTING PROJECTS ********************
------------------------------------------------------------
- testing bigtable/scheduled-backups
------------------------------------------------------------
Testing failed: Unable to determine Java version. Please set in pom:

<properties>
  <maven.compiler.target>1.8</maven.compiler.target>
  <maven.compiler.source>1.8</maven.compiler.source>
</properties>

Can you update the pom.xml file to include this?

Hi @TracyCuiCan, I saw that youve added some commits, but I'm not sure if you're ready for another round of reviews. please click the re-request button next to the reviewers' names when you're ready. Thanks!

@shubha-rajan @kolea2 @billyjacobson Do you mind taking another look? Thanks!

I'd rather see Integration tests, we rarely need mocks for samples, unless you are trying to teach users how to use mocks.

Note - please follow the guidelines for lint mvn -P lint checkstyle:check and mvn -P lint clean compile pmd:cpd-check spotbugs:check

@shubha-rajan @kolea2 @lesv I added integration test for the Cloud function, please take another look :)
Also need to set two environment variables for the test: GOOGLE_CLOUD_PROJECT and BIGTABLE_TESTING_INSTANCE.

@shubha-rajan @kolea2 do you have any other comments? Advice on how to set the environment variables would be great! Thanks :)

The integration test looks great.
One question: is there any reason why we're not running tests in Java 8? looks like they're being skipped.
Also, can we have the test file name end in 'IT' to signify that it's an integration test?

@shubha-rajan @kolea2 do you have any other comments? Advice on how to set the environment variables would be great! Thanks :)

I just checked and the environment variables are already set!

One question: is there any reason why we're not running tests in Java 8? looks like they're being skipped.
There's no reason, in fact I don't know that it's skipped, how should I enable it? sorry I'm not super familiar with Java :)
Also, can we have the test file name end in 'IT' to signify that it's an integration test?
Sure, I'll make the change!

To enable Java 8, edit the java version in your pom.xml file


Text values don't seem to work

I love this thing.
But I just noticed that ">name:text|t" values don't seem to work. That works with the upstream Teleplot. But the upstream version doesn't seem to support serial ports.
Text could be very useful for me to track the internal state of for example a state machine...
And, while Serial support is really cool, it's not without fail. When using the traditional serial monitor platform.io is clever enough to stop the serial monitor while it uploads code and start it back up once it's done uploading.
It would be real cool if it could do the same with Teleport (Disconnect while it's flashing the device)
I shall use UDP at some point (I'm using ESP32, where that will be an option). Once I do that I can have text values and don't have to fight for the port.

I created the following workaround.
By intercepting the messages in a Filter module of the Platform.io filter module I can make use of the monitor commands build in disconnect.
And I use the latest Teleplot
from platformio.public import DeviceMonitorFilterBase
import socket

class Teleport(DeviceMonitorFilterBase):
    NAME = "teleplot"

    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        self.sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
        self.buffer = ""
        print("--- Teleplot filter. Lines beginning with > are sent to udp:localhost:47269 for plotting")

    def rx(self, text):
        # Append the incoming text to the buffer
        self.buffer += text

        # Split the buffer into lines, preserving newlines at the end of the line strings
        lines = re.split(r'(?<=\n)', self.buffer)

        # Process complete lines that start with '>' and end with a newline
        for line in lines[:-1]:
            if line.startswith('>') and line.endswith('\n'):
                # Send the complete line to Teleport (Without the >)
                self.sock.sendto(str.encode(line[1:]), ("<IP_ADDRESS>", 47269))

        # Save any remaining partial line in the buffer
        self.buffer = lines[-1]
        return text

See https://docs.platformio.org/en/latest/core/userguide/device/cmd_monitor.html on how to use Filters.

Thanks for your message, and the workaround is quite interesting!
About the support of text-based telemetry in the VSCode version of Teleplot, well, it is indeed missing! They are a few features, including 3D telemetry that I still have to port. However, as you mentioned, those features are available in the standalone version of teleplot and on https://teleplot.fr
For the auto-disconnect feature, a few other people also mentionned it but I didn't yet identified a solution to detect that platformIO is about to flash. One of ther solution coluld be to get platformIO itself send a specific UDP packet to teleplot, in the telecmd format. Do you know if there is a mechanism similar to the DeviceMonitorFilter that could help with that?
(and even better if it can also send a message to resume the connection!)

I am also not sure how it's done. But the logic is in Platform.IO and not in VSCode I'm sure. So it's far from universal.

Another (a bit too dirty) option would be to monitor the running processes on the PC (if possible from VSCode) and attempt to detect the platformios pythons commands or the underlying platform-specific tools... But this would be hard to get reliable, fast-enough, and to not generate edge-cases. (ignoring the fact that I'll sleep bad after writing such a code)

Hi again!
Text format is now available in the VSCode extension :tada: (along with 3D and a few other features)
However I still have no proper idea for auto-releasing the serial port :/


Vickel: Watch 1-8555-465-038

Vickel requests the watch of the watch_number 1-8555-465-038. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Jeff Schaller in Charcoal HQ


docs: added ADR 6

Added an ADR discussing how Connaisseur should access its configuration files going forward.

Codecov Report

Merging #280 (f71f437) into develop (c31b8a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #280   +/-   ##
========================================
  Coverage    96.65%   96.65%
========================================
  Files           22       22
  Lines         1077     1077
========================================
  Hits          1041     1041
  Misses          36       36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31b8a2...f71f437. Read the comment docs.

1.2 and 2.2. :rocket:

1.2 and 2.2 👺

PR name is misleading as this does way more than add ADR6


Sunce86/flashbots tx submission

Added flashbots tx submission strategy (as a clone of archer with adjusted submit/cancel methods).
Next step is to add continuous simulation of settlements to strategy: TransactionStrategy::CustomNodes

Codecov Report

Merging #1347 (c17dd98) into main (94a1d7b) will decrease coverage by 0.63%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
- Coverage   67.49%   66.85%   -0.64%
==========================================
  Files         138      140       +2
  Lines       29236    29508     +272
==========================================
- Hits        19732    19729       -3
- Misses       9504     9779     +275


why  [ FileIO ] Can't open file AngelBinary?

why  [ FileIO ] Can't open file AngelBinary?
[ FileIO ] Can't open file AngelBinary
AngelSystem::reload Filed to load a script

This is not a necessary message from the AngelScript module. It means this module is unable to load a related resource. In case you are not using scripts in your projects, this message can be ignored. However, I have fixed this message already. It will not appear in the next releases.


Created HTML and folders structure.

Added KS svg logo and tested js animation on different targets

Added KS svg logo

Added KS svg logo


fix: 运行demo的时候，连接无线网，默认会获取IPv6 地址，导致报错

修复本地连接无线网络时，导致默认获取IPv6 地址，产生 Can't assign requested address 报错信息

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhanyue seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


shift GH actions to poetry instead of pipenv

@cmungall I don't think I have permission to edit GH actions in this repo. (Although I claimed to have disabled one in #4)

Yeah, I have disable and view privileges, but not GH action/workflow edit privileges

The currently problematic workflow is check-pull-request.yaml (missing requirements.txt)

fixed
On Thu, Jan 13, 2022 at 5:01 AM Mark A. Miller @.***>
wrote:

@cmungall https://github.com/cmungall I don't think I have permission
to edit GH actions in this repo. (Although I claimed to have disabled one
in #4 https://github.com/linkml/linkml-model-enrichment/issues/4)
—
Reply to this email directly, view it on GitHub
https://github.com/linkml/linkml-model-enrichment/issues/33#issuecomment-1012115476,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAMMOPHKA33ETT437IKTTLUV3EKZANCNFSM5L2OJ5EA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Can this be closed?


train with dcn

HI, Have you trained the model with dcn, if you have done, what abou the performance? imporved slight oy high? thank you .

HI, Have you trained the model with dcn, if you have done, what abou the performance? imporved slight oy high? thank you .

Have you finished your experiment with DCN?


Startup run code of IPython is not working when using projects

Description
What steps will reproduce the problem?

Hello.
This promblem is similar to #16748.
This issue is also occurring in 5.x branch.
Thank you.
 We will check this in a future release :+1:
Also I noted that seems like you are using a version of the spyder-vim plugin? Could you be interested on submitting a PR to the spyder-vim repo so the changes you did to make it compatible with Spyder 5 are there if that is the case? Let us know!

Also I noted that seems like you are using a version of the spyder-vim plugin? Could you be interested on submitting a PR to the spyder-vim repo so the changes you did to make it compatible with Spyder 5 are there if that is the case? Let us know!

I have created a personal repository(okvim) for using Vim on Spyder. Seems like too many changes would be needed to apply this to spyder_vim. I'm sorry.

I did the test setting as the preference something simple like import os and import os.path as osp though. Any other info to replicate this in our side is greatly appreciated @ok97465

If the startup command is unrelated to the project folder like "import os", it works well.
#16748 But If the startup command loads file in the project folder, it does not work properly only when spyder is started.

I have created a personal repository(okvim) for using vim key on Spyder. Seems like too many changes would be needed to apply this to spyder-vim. I'm sorry.

Oh I see, I was thinking that you could do a PR replaicing what is currently in the repo with your version (just changing the entrypoint and other related names to use spyder-vim/SpyderVim/spyder_vim) and maybe help us maintaing the plugin from that repo but if that not feasible, could be okay if we mention your repo in the issues from the spyder-vim repo so users that could be interested in using the plugin with Spyder 5 could check your repo out?

If the startup command is unrelated to the project folder like "import os", it works well.
https://github.com/spyder-ide/spyder/issues/16748 But If the startup command loads file in the project folder, it does not work properly only when spyder is started.

Does your custom script to run at start has relative imports? Maybe the console is not getting set the project path before running the start script and then is being unable to run it? Will try to check a little bit more to replicate it :+1:
Thanks for the new info @ok97465 !

Oh I see, I was thinking that you could do a PR replaicing what is currently in the repo with your version (just changing the entrypoint and other related names to use spyder-vim/SpyderVim/spyder_vim) and maybe help us maintaing the plugin from that repo but if that not feasible, could be okay if we mention your repo in the issues from the spyder-vim repo so users that could be interested in using the plugin with Spyder 5 could check your repo out?

My vim has a completely different structure from the spyder vim, so I have to create and upload all the new files. If I do that, my vim has an intermittent error and the bug is often reported on Spyder-ide, which will annoy you. I think it would be better to make the spyder-vim compatible with the spyder 5, and I will try it within next month.

Does your custom script to run at start has relative imports? Maybe the console is not getting set the project path before running the start script and then is being unable to run it? Will try to check a little bit more to replicate it

The initial files(import_in_console.py) within the project are as follows:
from numpy import pi

Preference > IPython Console > Startup > Run code is below:
from import_in_console import *

Thanks for the step by step description @ok97465 ! I was able to reproduce this :+1: Seems like the console when opening a project is not getting the correct working directory set (I'm getting for the first console open with the project my home directory instead):

Checking the working directory options I'm seeing this:


Adding BaseChatMessageHistory.__str__

Increasing the usability of BaseChatMessageHistory by implementing:

~add_system_message: for parity with human and AI messages~
__str__ for easy debugging

~I also added add_system_message to the one subclasser that changes the adders~

Yeah sure! I will revert the add_system_message addition, gimme one sec.  I really care for __str__ here, the add_system_message was just cuz I noticed it's missing

It's reverted btw, so ready for your review again


Don't zoom out on resize (D3 debugging)

if looking at a state and resizing the browser (flipping portrait->landscape, or changing window size) zooms you out to national view, but keeps the state URL and state style (thin lines)

@wdwatkins I assigned this to you since you had two small-ish things. This might be an interesting way to start digging into some D3, but let me know if you start this and have zero clue where to go. @mwernimont will probably be a good resource for it, but I know he's already got quite a few issues.

From what I'm reading after googling this, d3 resets the zoom when you change the window size.  There is an unanswered issue on the d3 repo here: https://github.com/d3/d3-zoom/issues/136, although this stack overflow post suggests you just need to store the old zoom and then reset it: https://stackoverflow.com/questions/25875316/d3-preserve-scale-translate-after-resetting-range
@lindsaycarr and I tried adding this:
d3.select(window).on('resize', resize, updateView(activeView), console.log('active view' + activeView));

at the end of fillMap, but it didn't have any effect.
Somehow or other, it seems like a fix should involve resetting the view/zoom after the page is resized though.  It is also worth considering whether this is worth dealing with though.

Sounds like you've identified the critical insight, if not yet the fix. Does it work any better to add the call to updateView(activeView) within the resize() function (probably at the end of it)?


Option to disable highlighting in overview ruler (scroll bar gutter)

Sometimes the green labelling of lines in the overview ruler (scroll bar gutter) is visually disruptive, it would be nice to turn it off via a eslint.enableOverviewRulerHighlighting type setting.
If the option exists already, it should be in the readme!
Example:

This is nothing ESLint controls. The overview ruler is managed by VS Code itself. I checked the VS Code options and couldn't find one. Please open a feature request here: https://github.com/Microsoft/vscode


Fix ssm.get_parameters missing validation

Fixes #2883

Coverage increased (+0.0003%) to 94.225% when pulling 3b8c8fafe2a4c3ee1b1c70a0763fe1233b28086d on gruebel:fix-ssm-get-parameters into 323877c15de6efaaa098efd282b65729fa78d3eb on spulec:master.

Just noticed there are some conflicts - happy to merge after they are resolved

@bblommers I have no idea what happened, but you already merged my commits, so there was no conflict for me to be resolved. And somehow I closed the PR after I rebased it on the master. Can you also close the related issue #2883

@gruebel Ah, that makes sense actually. Sort of. I saw a Github unicorn when I tried to merge the first time, so I guess it only finished part of the merge.


Remove application.conf and routes files from server/.

Resolves issue #26. Since the play framework is no longer in use, the application.conf and routes files are no longer necessary.

LGTM


Stream enrich: Extend config to override kafka producer and consumer config

Based on PR https://github.com/snowplow/snowplow/pull/3938 this PR extends the configuration of stream-enrich  to override the configuration of the kafka producer and consumer.

Confirmed! @0xE282B0  has signed the Individual Contributor License Agreement. Thanks so much

Unfortunately, Travis could not build. Since I could not reproduce it, I tried to trigger a rebuild and accidentally deleted the branch. 😆

Incorporated into #3965 , thanks a lot! :+1:


What happened?
Hey! Thanks for your plugin.
Any chance you can add autoplay for videos or audio files?
How to reproduce the bug
not a bug
Package Version
2
PHP Version
8
Laravel Version
11
Which operating systems does with happen with?
No response
Notes
No response

Hi! I will try to implement this tomorrow and I will let you know when it is done.

Feature added in the latest release: v<IP_ADDRESS>

Thank you @hugomyb !


Memory problem

i'm using tkVideoPlayer to loop a video, but every time the video restart the ram usage continues to increase and reaches several gigabytes, is there any way to prevent this?

Hi @OraSamaaa,  can you let me know which version of tkvideoplayer you are using? If you are using any versions below 1.3 please update them immediately to a version greater than 1.3. Thank you.

2.3

@OraSamaaa Can you share an example code? I tried it but the memory issue doesn't seem to occur.

https://github.com/PaulleDemon/tkVideoPlayer/pull/33


Package upgrade: shared_preferences 2.0.6 --> 2.0.8

Summary
Package upgrade: shared_preferences 2.0.6 --> 2.0.8
Changelog
[General] [Change] - Upgrade shared_preferences from 2.0.6 to 2.0.8 (changelog)
Test Plan
Regression test the following areas:
./lib/ui/wayfinding/beacon_view.dart
./lib/ui/onboarding/onboarding_login.dart
./lib/ui/onboarding/onboarding_affiliations.dart
./lib/ui/home/home.dart
./lib/main.dart
./lib/core/providers/wayfinding.dart
./lib/core/providers/bluetooth.dart

Deferred