CPP: Grammar test fixture takes too long to parse

The following CPP grammar test fixture takes over 10 seconds on my beefy machine to run the test:
vscode-cpp/test/colorize-fixtures/test-92369.cpp

Here's the mocha output:
    ✓ test-92369.cpp (10159ms)

Even when I open that file in VS Code I see it freezing for a short bit. The file is quite small tho, so it makes me think something is really broken in the tokenizer and it must be looping wayyyy too much.
std::tuple_element<0, std::pair<pugi::xml_node, std::map<std::basic_string<char>, pugi::xml_node, std::less<std::basic_string<char> >, std::allocator<std::pair<const std::basic_string<char>, pugi::xml_node> > > > >::type dnode

std::_Rb_tree_iterator<std::pair<const long, std::pair<pugi::xml_node, std::map<std::basic_string<char>, pugi::xml_node, std::less<std::basic_string<char> >, std::allocator<std::pair<const std::basic_string<char>, pugi::xml_node> > > > > > dnode_it = dnodes_.find(uid.position)

cc @alexdima

Please wait before fixing this, as I'm in the process of extracting grammar extensions.

Please wait before fixing this, as I'm in the process of extracting grammar extensions.

Notice it here on GA: https://github.com/microsoft/vscode-cpp/runs/1708544581?check_suite_focus=true#step:5:40

Notice it here on GA: https://github.com/microsoft/vscode-cpp/runs/1708544581?check_suite_focus=true#step:5:40

@jeff-hykin FYI (though I think you already know about this one).
We have this test to make sure that a bug where all of VS Code freezes doesn't happen.

@jeff-hykin FYI (though I think you already know about this one).
We have this test to make sure that a bug where all of VS Code freezes doesn't happen.

Yeah, sadly for a line that long with that much nesting, the only thing we could do is set a line limit and ignore it. But that is already a built in feature/user-option.

Yeah, sadly for a line that long with that much nesting, the only thing we could do is set a line limit and ignore it. But that is already a built in feature/user-option.

Thanks for confirming. Since the test is actually moving into an extension specific repo, I'd like to leave it in despite how long it is.

Thanks for confirming. Since the test is actually moving into an extension specific repo, I'd like to leave it in despite how long it is.


Simplisafe Authentication Button Not Appearing

Description
As part of the authentication process -  A button will launch the authentication process.
But once the plugin is installed - there is no button available to initiate the link process as well as the manual method does not work.
Expected behavoir
Copy and paste the final URL (begins with com.SimpliSafe.mobile://) back into the plugin settings.
Plugin name
homebridge-simplisafe3
Version
4.0.109
Did you upgrade
Please let us know if you upgraded from a previous version.

[X] Yes
[ ] No

What device are you using?
Please let us know the device you are running HOOBS on.

[X ] HOOBS Box
[ ] HOOBS SD Card
[ ] Custom Install

If this is a custom install, what's your operating system?
Please let us know what operating system and version you are using. Ex. Fedora 30 or macOS Catalina.
Post your config
This can be found in the interface, Configuration -> Advanced or you can get it via SSH cat ~/.hoobs/etc/config.json

Remove any passwords from the config file. This is public.

POST CONFIG HERE

Post your log
You can get the log from the intercafe. This is in the Log section.
10/8/2021, 11:08:46 AMSimplisafe3 Bridgehomebridge-simplisafe3.SimpliSafe 3ERRORSimpliSafe login failed with error: Error: No authentication credentials detected.
    at SimpliSafe3AuthenticationManager.refreshCredentials (/var/lib/hoobs/simplisafe3bridge/node_modules/homebridge-simplisafe3/common/authManager.js:191:15)
    at new SS3Platform (/var/lib/hoobs/simplisafe3bridge/node_modules/homebridge-simplisafe3/index.js:84:41)
    at /usr/src/bridge/server.ts:455:46
    at Array.forEach (<anonymous>)
    at Server.loadPlatforms (/usr/src/bridge/server.ts:438:31)
    at Server.start (/usr/src/bridge/server.ts:239:69)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
10/8/2021, 11:08:47 AMSimplisafe3 Bridgehomebridge-simplisafe3.SimpliSafe 3ERRORSee the plugin README for more information on authenticating with SimpliSafe.
10/8/2021, 11:08:47 AMSimplisafe3 Bridgehomebridge-simplisafe3.SimpliSafe 3ERRORInitial accessories refresh failed with error: Error: Not authenticated with SimpliSafe.
    at /var/lib/hoobs/simplisafe3bridge/node_modules/homebridge-simplisafe3/index.js:103:56
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

Additional context
This plugin is HOOBS certified.

any fix?


Bootstrappification styling changes, and some prose.

I just rebased this and fixed the conflicts!

(and pushed that!)

Thanks!


repo.getReferenceCommit() does not work with annotated tags

The method getReferenceCommit() on a Repository works with a tag given in the form refs/tags/v0.1.5 only when the tag is a lightweight tag. If it is an annotated tag, calling this method results in an error:
Error: the requested type does not match the type in the ODB

See also the discussion at https://gitter.im/nodegit/nodegit?at=59b5026e66c1c7c477342023

I managed to get this working by following the referenced discussion. To save other's time, here's the code I ended up using.
const git = require('nodegit')

;(async () => {
  const repo = await git.Repository.open('.')
  const refs = await repo.getReferences(git.Reference.TYPE.OID)
  const tagRefs = refs.filter((ref) => ref.isTag())
  const tagRef = tagRefs[0]
  const targetRef = await tagRef.peel(git.Object.TYPE.COMMIT)
  const commit = await repo.getCommit(targetRef)
})()

The important line is this one:
const targetRef = await tagRef.peel(git.Object.TYPE.COMMIT)

Unlike with a branch reference, you have to peel a tag reference back to the commit to which it points.
Note that the API documentation says that the peel method is sync, but it is, in fact, async.

 Can we agree on an API that allows a program to navigate from a tag to a commit in a more elegant way?

@mojavelinux The following code should work.
const repository = await git.Repository.open('.')
const reference = await repository.getReference("refs/tags/tagName");
const commit = await reference.peel(NodeGit.Object.TYPE.COMMIT):

It's not completely clear to me what you are looking for though. You want a way to go from the name of a tag to its commit or from an actual Tag object to its commit?

@rcjsuen That's precisely what the code I showed is doing. We're just getting the references a different way. (My code is discovering the references since I don't know the names up front).

It's not completely clear to me what you are looking for though.

My use case is simple. I want to read the files in a tag by walking the tree. For that, I need to resolve the tree. The tree is accessible from a commit. So the first thing I need to do is find the commit.
I'm using this in a content system that reads files from the branches and/or tags of a bare git repository.

@mojavelinux Never mind, I think I misunderstood what you originally were trying to say. Sorry about that.
There is a related discussion about these APIs at #403.

Thanks for the pointer!


Increase gracePeriodSeconds for test docker app

High-level description
Tests that launches docker app sometimes fails. We need to increase gracePeriodSeconds to not kill app that is about to work.
Corresponding DC/OS tickets (required)

D2IQ-67372 test_if_docker_app_can_be_deployed_window if flaky

Related tickets (optional)

D2IQ-ID JIRA title / short description.

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot request-review @jongiddy @jeschkies @DominikDary

@mesosphere-mergebot changelog-not-required internal

@mesosphere-mergebot sync

@mesosphere-mergebot changelog-not-required internal


Incorrect 'no-unused-vars' error

Before You File a Bug Report Please Confirm You Have Done The Following...

[X] I have tried restarting my IDE and the issue persists.
[X] I have updated to the latest version of the packages.

What version of ESLint are you using?
8.37.0
What version of eslint-plugin-svelte are you using?
2.23.1
What did you do?

Configuration
module.exports = {
  root: true,
  parser: '@typescript-eslint/parser',

  parserOptions: {
    extraFileExtensions: ['.svelte']
  },

  plugins: [
    '@typescript-eslint'
  ],

  extends: [
    'eslint:recommended',
    'plugin:svelte/recommended'
  ],

  env: {
    node: true,
    browser: true
  },

  overrides: [
    {
      files: ['*.svelte'],
      parser: 'svelte-eslint-parser',
      parserOptions: {
        parser: '@typescript-eslint/parser'
      }
    }
  ]
};

<script lang="ts">
  export let close: (value: boolean) => void;

  close(true);
</script>

What did you expect to happen?
No error occurred.
What actually happened?
'value' is defined but never used. eslint no-unused-vars

Link to GitHub Repo with Minimal Reproducible Example
https://github.com/jiangfengming/eslint-plugin-svelte-bug-report
Additional comments
No response

You should turn off the rule and use an alternative rule.
https://typescript-eslint.io/rules/no-unused-vars/


conversion script 'ddl2cpp' does not support boolean type

When I try to convert the following SQL to C++ header,
CREATE TABLE TEST (
  id varchar(255) PRIMARY KEY,
  flag boolean
) ENGINE=InnoDB DEFAULT CHARSET=utf8

, I got
Traceback (most recent call last):
  File "/home/mtakeda/src/cpp/test_sqlpp11/sqlpp11/scripts/ddl2cpp", line 159, in <module>
    traitslist = [NAMESPACE + '::' + types[sqlColumnType]];
KeyError: 'boolean'

The 'types' table in ddl2cpp has the key 'bool' instead of 'boolean'. Is this just a typo? I'm using the revision 'e152e29'.

bool is the type I use :-)
I'll add boolean as well.

Thank you!

Fixed in release 0.35


fix: Use ForkRun for generateJmhSourcesAndResources

Forking has a couple of benefits:

It runs with the full modules for the JVM, so that it doesn't error if you use something from a module such as java.sql
If the generation throws an exception, it doesn't kill sbt outright.

Taken from https://github.com/pawel-wiejacha/sbt-jmh/commit/a916d771b2d75dce3404cce5cba282884f2251c6
Fixes: #190
Co-authored-by: pawel-wiejacha

Refs #192


feat(tools): add readonly tools.table.EMPTY for common usage

Summary
Inspired by #13491.
This PR did not replace all so called EMPTY tables, only which are obviously readonly.
KAG-5140
Checklist

[ ] The Pull Request has tests
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

Should be cherry-picked after the https://github.com/Kong/kong-ee/pull/9950 be merged


ViewModel and View are immediately deactivated on Windows Phone 8.1

I'm using WhenActivated in a Windows Phone 8.1 application and as soon as a page is loaded, the disposable in the WhenActivated method is immediately disposed.
I've stepped through the ActivationForViewFetcher class at https://github.com/reactiveui/ReactiveUI/blob/5954c53255832ea0fb9d8c8a6ccef18cd334f742/ReactiveUI/Xaml/ActivationForViewFetcher.cs#L39 and it seems like IsHitTestVisible changes from true to false and then back to true again. so when it reaches false the Disposable in WhenActivated is disposed
I don't have much insight into the activation code, so I'm not sure how this can be fixed

Oh, seems like someone on the RxUI mailing list had a similar problem: https://groups.google.com/forum/#!topic/reactivexaml/mgkhk3kCO5c

I found its related to the built in transitions causing this, if you remove the transitions it will resolve the issue.  A better fix is needed however.

Hm, so basically we have to check if transitions are enabled, and if they are, ignore the first true and false value

Maybe we should just ignore IsHitTestVisible?

Well, that would work for me :smile:
No idea if that would break anything for anyone else

Of the top of my head i can't see why removing it would have any detrimental affect.


IPv6?

Hey folks, thanks so much for the amazing library. We're using it over in firezone/firezone with good results so far.
However, we noticed that testing with IPv6 addresses seems to fail completely, and we suspect perhaps it is not supported.
Is this the case? If so, any hint as to how much work would be required to support it? We'd like to help out if possible.
Thanks in advance!
cc @thomaseizinger @conectado

Closed via #475

Depending on the scope, I'd say this isn't fully resolved because webrtc-rs doesn't seem to use the RequestedAddressFamily and AdditionalAddressFamily headers to make IPv6 allocations when necessary.

@rainliu Thanks for landing #495. Maybe I am missing something but that only seems to address the server-side right? Can we re-open this to also track handling IPv6 on the client side, i.e. mkaing IP6 allocations?

I am also interested in IPv6-only deployments. I'd love to see it supported as well.


Toyota: Cancel cruise without chime

I can confirm this fix works on my TSS2 Prius. Great work @Smartype!

Can you explain some more how this works?
On first glance it looks like this simulates the first stage of an AEB to force a cancel. That doesn't sound like a good solution, especially on cars where the DSU is not unplugged (or TSS2).

On TSS2 cars or cars with DSU plugged in this might be interacting with the PRE_COLLISION message sent by the stock system, and cause messages from stock to be dropped due to a counter mismatch.
On cars with DSU unplugged this might interact with the currently static message we are sending, and also cause reliability issues due to counter issues. However, that is fixable.

I don't know why this worked. Only toyota knows why. As there is not public doc about how it works.
For the counter: if the car has a strict counter check, why this works every time with any counter value(the frame var)? Further more, if it does accept my counter value, why not accept the stock one? (There could be a chance that the injected msg causes an error state and as a result, acc got disengaged)
Some tests can be down:

Reuse the stock counter, or counter + 1, if this really matter
Try trigger aeb alarm after this msg, see if it break/isolate the aeb module(dsu or radar)

Right now, we'd check if this hack work on other Toyotas, if not, we do not have to spent much time perfecting it.

In my opinion, counter here indicates the dsu is alive and updating. There is no strict check for "next expected value".
And about stock aeb, i think it can be done in panda, when aeb is active, panda can switch to passthrough mode.

Just want to leave this anecdoet I posted in the issue about this branch here:
071ba9916a1da2fa|2022-01-04--20-12-54--5 with @Smartype's changes on a 2020 Corolla SE Hatchback. While does deactivate without a chime, mashing the brake pedal down (e.g. enough to activate brake hold) at a standstill causes a cruise control malfunction. Needs to restart car to re-enable cruise control.

@nelsonjchen could that be because while pcm_cancel_cmd is True, CC isn't sending 0x343 and the car faults? While stopped, sometimes the stock system takes a while to disengage under certain circumstances and pcm_cancel_cmd may be true for longer than it should

Nice work 🎉, I was able to test this on my Prius 2018 (TSS-P) and I can confirm this works fine overall.
However, this doesn't work when the CAN speed is zero, this is regardless of the car's cruise state whether it'd be standstill, creeping, or resumed. (This is also why during my testing I ruled out this signal as all my testing were conducted with the vehicle stopped).
There are a few options to tackle this though.

One is to send the CANCEL_REQ (a.k.a. create an error) command that we're currently using when the vehicle is stopped. This will create the error chime.
Another one is to make the car think there's no lead by setting MINI_CAR to 0 when we want to cancel at low speed. This will create 4 consecutive beeps, and will make the dash display "NO CLOSE LEAD CAR".

Unfortunately, it seems this solution isn't going to work. It uses the AEB message in a way that isn't well understood and doesn't work in all conditions.


EMSDK env

Ensure EMSDK environment is set, and export EMSCRIPTEN pointing to ${EMSDK}/upstream/emscripten

I needed to revert this PR because it fails to build on mac.

What was the error?

./bin/build-boost-emscripten.sh: line 3: realpath: command not found
./bin/build-boost-emscripten.sh: line 3: /emsdk-inc.sh: No such file or directory

Aha. You are missing coreutils.
I don't own a MAC, but..
brew_install_coreutils.sh


Ease migration of SASS configuration -- simple proof of concept inside

An idea I floated a while back, pertained to the relative difficulty of migrating one's SASS configuration files across major releases of Foundation for Sites.
Consider the following:
Goal:

One builds with Foundation for Sites SASS assets.
One migrates from the v6.2 to the v6.3 codebase.

Obstacles to successful migration:

Finding and removing deprecated variables and such in one's current _settings.scss file.
Find same-name variables with differing value requirements.

Possible solution:

Repo includes a SASS migration script to accomplish the above.
Repo includes a file that lists deprecated code.

Using this toy proof-of-concept here, you might do the following:
git grep -wf migrate.txt -h old/_user-settings.scss

This would output the following:
$header-color: inherit;
$header-lineheight: 1.4;
$header-margin-bottom: 0.5rem;
$flexvideo-margin-bottom: rem-calc(16);
$flexvideo-ratio: 4 by 3;
$flexvideo-ratio-widescreen: 16 by 9;

I'm more than happy to pursue this further if there is sufficient appetite for such a scheme.

I personally like this... Please create PR... if you ask me

Thanks for your reply @IamManchanda
Coding specifics aside, you think the approach is good from a UX stance? Any thoughts how best to indicate deprecated variable value types? Perhaps some pseudo (or real!) code examples?

Coding specifics aside, you think the approach is good from a UX stance? Any thoughts how best to indicate deprecated variable value types? Perhaps some pseudo (or real!) code examples?

Tag @ncoden coz i feel he is the right person to answer you on this !

@paxperscientiam Thanks for raising this!
Your approach sounds interesting - I'd definitely like to see it explored further, as you are right, it is an issue with every release.
I think @kball would have an opinion on this too - I'm not sure if any other solutions have been flagged for this issue or not.

OK folks, I'm going to explore more. I'll keep on this thread for further input. As well, keep an eye on this for further developments.

Here I have a rough solution that works with BSD cut and sed; and a solution that works with GNU cut and sed.
It's probably not the fastest solution. So, if someone knows of a faster incantation, please lemme know.
In the mean time, I press on with the next goal (see updated OP).

I think the problem statement is accurate, and having a migration script like this is a great idea! I'd be interested in exploring other ways of dealing with settings as well... in particular, I'm wondering about the downsides of having the default settings all (or mostly) be commented out, with you only uncommenting the ones you want to change.
Thoughts @ncoden @rafibomb ?


WIP: DO NOT MERGE: Test OPS

Internal BUG 50156
PR just to show the bogus warning.

@scottaddie 	@guardrex 	@tdykstra 	looks like WIP tool changed. WIP commits/labels no longer trigger WIP status. Must be in title. Overall a big improvement but I would like WIP label to set status.


Torch not fully utilizing CPU

Built torch-android without CUDA, CPU only.
In android-demo, do not make any tensors cuda
Running the android-demo, android studio monitor shows only ~ 25% CPU usage. Any reason why it's not 100 (as it is when trying similar caffe-android ports)? I tried torch.setnumthreads(4), but it doesn't seem to have done anything.
Why is this happening?

Experiencing the same

It's the same problem with #68. You can try to compile OpenBlas.

Torch itself using a single thread, so unless your program utilizes parallel OpenBLas etc. if would only use a single core.


Use library for config validation

Now we using our selfmade config validation and it is too hard to maintain validation + tests for all of it.
For config validation we can use some validation library and delete all tests for validation (because it is no difference where create error: in tests or in library validation).
What need to do:

[ ] Choose library for validation
[ ] Refactor config validation code: from selfmade to library
[ ] Delete all tests (but run them last time before delete XD)

Select "Zod" library because of this. Create ts types from schema is great feature.


Updated Slack integration to check_send_webhook_message

Fixes: #27601
This PR migrates the slack integration from check_send_stream_message to check_send_webhook_message. Also handled channels_map_to_topics variable by introducing it as an additional keyword-only argument in check_send_webhook_message.
The problem faced was that we couldn't send notification to specific topic by adding &topic= to url, the message is always sent to "channel: <slack channel name>"
Before Changes :

After Changes :

If topic is specified in the URL, for example: if the topic is A_topic, then zulip will display it as:

If topic is not specified in the URL, then zulip will display it as:

If channels_map_to_topics == "0" in the URL then zulip will display it as:

But the precondition is that a zulip stream of the name of the slack's channel (which is sending the payload) should pre-exist.

Converstaion while making the changes, the CZO thread

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).

[ ] Highlights technical choices and bugs encountered.

[x] Calls out remaining decisions and concerns.

As I have mentioned in the CZO thread
When I was testing the changes on the integration developer panel, the query parameters which I added in the URL of the
API endpoint, were added manually.
What I mean is, when I specify the Bot, the Integration, the Fixture, the stream and the Topic I get the following URL
generated:

I added the following query parameters manually &user_name=mehtabsinghcse&text=web_bruh+1st+Text+sent&channel_name=zulip_web_local_host
Only then the slack webhook works properly in the integration developer panel, else it shows error of:
Result: (400) Missing ‘user_name’ argument
One thing to note is that, when I send a message to the test here stream of chat.zulip.org. from slack using the outgoing webhook the message gets sent successfully.

The above screenshot is from chat.zulip.org
I believe that the changes I made would work for the production as well (as evident by the above screenshot), so there would be no need to alter the query parameters for the production.

[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@laurynmm I added some comments to this pull request. I was hoping if some you look into those

@AlexiusTatius can you update your PR to pass lint/tests? It doesn't make sense to ask for review on a small PR when it doesn't follow those guidelines.

@timabbott sure!

@AlexiusTatius - Thanks for all your work on this! After looking at the check_send_webhook_message logic a bit more, I ended up going with a slightly different solution, as well as updating the tests and documentation for these changes. So, I'm going to close this in favor of #28937. If you have time to review the changes in that PR, that would be great!


lowered logback stdout levels

To enable k8s loggers to pick up the container's stdout, lower the threshold for gms and FE. Do not merge yet, will use PR version to try

bumping the python version to 3.7 in github action, i think its due to deprecation in support or something.

will not change the log level for gms and FE


Make ParseModuleCollection initialization not dispatch_async multiple times.

By lifting the dispatch_async outside of the module collection enumeration, it allows for fewer local variable caputres, improving perfromance, as well as not requiring multiple flushes of the main dispatch queue to execute.

surewhynot


MigratingToFlashList Url is changed!

"Page Not Found"
I found new url on google and updated it!
Please verify the following:

[ ] yarn test jest tests pass with new tests, if relevant
[ ] README.md has been updated with your changes, if relevant

Describe your PR

:tada: This PR is included in version 8.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


When using fromLegacy with a string that contains "& " it cuts the string at that point.

As explained here https://github.com/Buuz135/ExtraChat/issues/27 when you have a string that contains & (& is the char used in fromLegacy) and a space after it it cuts the string at that point.

While it may be valid, this is an issue for https://github.com/SpongePowered/SpongeCommon as the actual implementation lives in SpongeCommon and not the Sponge API. Please post it there instead and then we can reproduce, handle, and fix it.


Use const values in call_frames module

They don't work atm, but they will when IR is turned on.
ref: https://github.com/FuelLabs/sway/issues/1125

@mohammadfawaz pointed out that this is fixed by IR.


Custom RequestQueryParamSerializer -> Output parameters are automatically URL-encoded

I have to deal with an API that expects such kind of query string:
sort[0]=firstCriteria&sort[1]=secondCriteria
In order to achieve it from an IEnumerable [Query] parameter, I created this custom RequestQueryParamSerializer:
public class MyCustomRequestQueryParamSerializer : RequestQueryParamSerializer
{
    /// <inheritdoc />
    public override IEnumerable<KeyValuePair<string, string?>> SerializeQueryParam<T>(string name, T value,
        RequestQueryParamSerializerInfo info)
    {
        if (value is null)
            return new KeyValuePair<string, string?>[0];

        return new KeyValuePair<string, string?>[] {
            new(name, ToStringHelper.ToString(value, info.Format, info.FormatProvider))
        };
    }

    /// <inheritdoc />
    public override IEnumerable<KeyValuePair<string, string?>> SerializeQueryCollectionParam<T>(string name, IEnumerable<T> values, RequestQueryParamSerializerInfo info)
    {
        // ReSharper disable once ConditionIsAlwaysTrueOrFalse
        if (values == null)
            yield break;

        var index = 0;
        foreach (var value in values)
        {
            if (value is not null)
                yield return new KeyValuePair<string, string?>(
                    $"{name}[{index++}]",
                    ToStringHelper.ToString(value, info.Format, info.FormatProvider));
        }
    }
}

But, after the query parameters are serialized, it seems that they are automatically url-encoded, and my query string becomes:
sort%5B0%5D=firstCriteria&sort%5B1%5D=secondCriteria

Is that a problem? %5B and [ mean exactly the same thing in a URL. Strictly speaking, according to rfc3986, [ and ] are not valid in a query string:
   query       = *( pchar / "/" / "?" )

   pchar         = unreserved / pct-encoded / sub-delims / ":" / "@"
   unreserved    = ALPHA / DIGIT / "-" / "." / "_" / "~"
   sub-delims    = "!" / "$" / "&" / "'" / "(" / ")"
                 / "*" / "+" / "," / ";" / "="

Whereas [ and ] fall into gen-delims, which are part of reserved:
   gen-delims    = ":" / "/" / "?" / "#" / "[" / "]" / "@"
   reserved    = gen-delims / sub-delims

From section 2.2:

URI producing applications should percent-encode data octets that
correspond to characters in the reserved set unless these characters
are specifically allowed by the URI scheme to represent data in that
component.  If a reserved character is found in a URI component and
no delimiting role is known for that character, then it must be
interpreted as representing the data octet corresponding to that
character's encoding in US-ASCII.

I don't see anything in section 3.4 about specifically allowing [ and ] there.

Glad you got it sorted!


Fix playground in book

I was just poking around the book and found that pushing the play button results in a compilation error as the default edition is 2015 (which doesn't have async). I think this will fix it based on the mdBook book.

I don't know if running the examples will actually be useful for folks, so maybe disabling the playground altogether is a better move? I was actually trying to see if this example compiles since I think the import is wrong 😁

Thanks! 😁


Incorrect conversion of worldToScreen

The calculation of the screen Y-coordinate in View.worldToScreen seems to be incorrect:
y *= 1.0f - x
Instead of being based on the screen X-coordinate, the calculation of the screen Y-coordinate ought to be based on the viewport height.

Thanks for the report!
Would you give a hand on the indirect linked #483 so we include the fixes at the same place?


Not ignoring dirs

Failing test case for .apexignore where directories are not ignored properly.

Not exactly sure how we want to solve this, but right now, I can't add a src dir (or similar) to a function root and then exclude it after building the src into the root function dir.

you can ignore dir with src/*

Hum... that wasn't working before. Appears to now? Closing, thanks.

hmm src should work too if we're matching .gitignore's style, I use that all the time

@tj I'm pretty sure that src won't work as we use shell matching patterns

maybe git does prefix matches or something, because filepath.Match fails to match src/foo/bar with src/* as well


1.5 hour flight in heavy traffic, message queue overflow

Stratux version:1.0r1 (5c70640eac)

Stratux config:
SDR

[ ] single
[X ] dual

GPS

[X ] yes
[ ] no
type:

AHRS

[ ] yes
[X ] no

power source:
usb cable: yes - ship's power

EFB app and version: (e.g., WingX Pro7 8.6.2)  FF latest
EFB platform: (e.g., iOS 9.2) iOS 9.3
EFB hardware: (e.g., iPad Mini 2) IPAD 2

Description of your issue:
No external apparent issue.  I flew 2 flights (1.5 each) near NYC and Philly.  You can see in the logs that I began to get a message que overflow.  I'm not sure if it was due to the sheer number of aircraft that were around.  The same messages were logged on both flights.  Again, during the flight I wasn't aware of any issues.  Not sure if this is expected behavior or not.  Since I was using one of the latest commits, this was just something that I thought you guys might be interested in.  This cycle repeated over and over again in the logs.  If you need me to search for anything else in the logs and send it to you, let me know.

here is an excerpt from the log:
2016/11/28 00:04:41 stats [started: 23 minutes ago]
2016/11/28 00:04:41  - Disk bytes used = 1.9 GB (81.4 %), Disk bytes free = 442 MB (18.6 %)
2016/11/28 00:04:41  - CPUTemp=45.08 deg C, MemStats.Alloc=46 MB, MemStats.Sys=76 MB, totalNetworkMessagesSent=19,742
2016/11/28 00:04:41  - UAT/min 878/1,494 [maxSS=106.40%], ES/min 17,285/27,015, Total traffic targets tracked=602
2016/11/28 00:04:41  - Network data messages sent: 18408 total, 10461 nonqueueable.  Network data bytes sent: 22601944 total, 2147115 nonqueueable.
2016/11/28 00:04:41  - Last GPS fix: now, GPS solution type: 2 using 13 satellites (14/16 seen/tracked), NACp: 11, est accuracy 2.40 m
2016/11/28 00:04:41  - GPS vertical velocity: 2.94 ft/sec; GPS vertical accuracy: 2.2 m
2016/11/28 00:04:41 Ownship target detected for code A9XXXX
2016/11/28 00:04:42 Ownship target detected for code A9XXXX
2016/11/28 00:04:43 <IP_ADDRESS>:4000 - message queue overflow.
2016/11/28 00:04:43 <IP_ADDRESS>:4000 - message queue overflow.
If possible, enable "Replay Logs", reproduce the problem, and provide a copy of the logs in http://<IP_ADDRESS>/logs/stratux/ and http://<IP_ADDRESS>/logs/stratux.log.

Duplicate issue?
https://github.com/cyoung/stratux/issues/449

@roperf15 - thanks for reporting. This is actually normal behavior. The "warning" sounds ominous, but it's more or less expected. Only weather data is stored in the "message queue". If you see the message counts, ~57% of your messages were unqueueable.
The message queue is of fixed size, so if you have a device or device(s) that haven't connected in a while (or even on this startup), the queue will overflow. It's typically large enough that this doesn't happen unless you leave your tablet/EFB shut down for more than 30 minutes. There usually isn't much consequence to it happening, either, as redundant data has usually been received by the time it overflows.
Take a look at /var/lib/dhcp/dhcpd.leases to see what .10 and .11 were, maybe they weren't even connected during the flight.

@Ergonomicmike - different issue. This has to do with the sleep mode FIS-B queue. I should probably remove this "warning" since it's more of a debugging message.

From the log, it also looks like @roperf15 didn't expand the microSD and the available disk space is getting low.


Add Helm charts for deploying in kubernetes

Add support for kubernetes by creating a Helm chart and templates:

persistent volumes for hub and witness
run hub and witness in separate containers (pods)

https://github.com/pmiklos/byteball-devnet/pull/17


I try to run in the amazing docker image you have provided on my m1 Mac, but it says it does not support ARM64.

Dear Igops,
Please help me igops, without your help I'll have no choice but to pay for ngrok premium. Please help me mate, I cannot run the image in the docker app on my M1 Mac mini, because it says the image does not support ARM64.
Kindest Regards,
GAMER.

Hi @GAMER12345678910214234234234234. Thank you for creating the issue!
Starting from July 9th, 2023 this image supports ARM chips. Please try downloading the latest version:
$ docker pull igops/ngrok-skip-browser-warning:latest


Use progression from Go

This is an attempt at setting up the Ruby track as a nextercism track.
As suggested in #815 I have cloned the Go tracks progression, removing exercises that are Go-specific, preserving Ruby-only exercises as bonus exercises.
After this changes the progression tree looks like this:
Ruby
====

core
----
├─ hello-world
│  └─ space-age
│
├─ two-fer
│  ├─ leap
│  ├─ triangle
│  └─ proverb
│
├─ hamming
│  ├─ rna-transcription
│  └─ nucleotide-count
│
├─ raindrops
│  ├─ accumulate
│  ├─ roman-numerals
│  └─ strain
│
├─ scrabble-score
│  ├─ etl
│  └─ protein-translation
│
├─ isogram
│  ├─ pangram
│  ├─ anagram
│  ├─ word-count
│  └─ run-length-encoding
│
├─ difference-of-squares
│  ├─ sum-of-multiples
│  ├─ pythagorean-triplet
│  ├─ largest-series-product
│  ├─ nth-prime
│  └─ isbn-verifier
│
├─ luhn
│  ├─ crypto-square
│  ├─ atbash-cipher
│  ├─ simple-cipher
│  └─ rotational-cipher
│
├─ grains
│  ├─ secret-handshake
│  ├─ sieve
│  ├─ perfect-numbers
│  ├─ allergies
│  └─ all-your-base
│
├─ clock
│  ├─ phone-number
│  ├─ pig-latin
│  ├─ prime-factors
│  └─ meetup
│
├─ robot-name
│  ├─ palindrome-products
│  ├─ say
│  └─ wordy
│
├─ tournament
│  ├─ pascals-triangle
│  ├─ diamond
│  ├─ ocr-numbers
│  ├─ kindergarten-garden
│  ├─ poker
│  └─ bowling
│
├─ twelve-days
│  ├─ house
│  ├─ food-chain
│  └─ beer-song
│
├─ matrix
│  ├─ queen-attack
│  ├─ transpose
│  ├─ saddle-points
│  ├─ minesweeper
│  └─ connect

bonus
-----
gigasecond
bob
acronym
flatten-array
series
scale-generator
bracket-push
rail-fence-cipher
circular-buffer
custom-set
grade-school
simple-linked-list
linked-list
binary-search
binary-search-tree
robot-simulator
change
collatz-conjecture
book-store
dominoes
alphametics
two-bucket
list-ops
affine-cipher
complex-numbers
zipper

The diff is probably slightly more complex than it needs to be as the order of exercises in the configs across Ruby and Go were slightly different.

Awesome, This looks great. Thanks!

Let's hit the 'Go' button and see what happens..


Create Authorization

Hello @ybadr99 ✋
In this PR, I implemented the Authorization, and accordingly,

Install cancancan gem
Generate ability model and set up authorization on models
Update controllers and views based on the ability setup

Please review and give me feedback.

good job


Fix broken docker images

The new release of bitsandbytes dropped the support for CUDA 11.2 and 11.6: https://github.com/TimDettmers/bitsandbytes/commit/ae7cd6ad147e67c3d5c4a681ef573c92fc5dd9de
The nightly runner having cuda 11.6 installed as discussed internally let's use the cuda11.3 image on our docker images
cc @BenjaminBossan @pacman100
Can confirm the import of bitsandbytes works at least as expected with this new image

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Improve frame synchronization in quad example

Fixes TODOs in quad example and demonstrates a more proper method of frame synchronization
PR checklist:

[ ] make succeeds (on *nix)
[ ] make reftests succeeds
[x] tested examples with the following backends: Vulkan, DX12
[x] rustfmt run on changed code

shipit :)
bors r+


tests, utils: Extract container lookup helpers to libpod

What this PR does
Extract the helpers out of utils and rename them to fit nicely in their new home package.
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/code quality

/code quality

/sig code-quality

change: Answered review comments.


if the session is expired then the users must be logged out automatically and redirected to landing page

if user enters invalid password, he is redirected to landing page, rather than showing invalid password message on signin page

or if the user is unauthorized, should stay on the sign in page.
redirection to landing page should happen only if session is expired

the issue with the redirection on landing page when password is invalid or user not found is fixed. Redirection to landing page on session management is still under test


Web Application Potentially Vulnerable to Clickjacking For Nessus

The Security vulnerabilities of Web Application Potentially Vulnerable to Clickjacking Scan By Nessus

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

@hejiefang please sign CLA then close and reopen this PR to get CLA check to acknowlege.

@panditsurabhi can you look at this?


Release artifacts for release v0.0.17

Signed-off-by: Amine Hilaly<EMAIL_ADDRESS>Description of changes:

Release artifacts for release v0.0.17

By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

This is necessary but Ideally we can merge after #41


Update Drupal

Have more to do but I want to get this in and reviewed before I finish up.

@gcharest Still working on this but would love feedback! If whatever is written here is accepted I'd be happy if we got it merged in and then I'll make a second pull request to update the rest of the items.

@nathanv This looks great! Updating the master with some patterns exclusion since we're having build issues (the links actually work...)


Add helper map for Dynamic State

After spending a LOT of time having to bounce around the spec to find information about each dynamic state while working on the Validation Layers, I decided it will be worth my time in the future to have this mapping of everything
Will play around later with the width to see if can remove the scrolling (no asciidoc pro), but figured I am going to ctrl+f mostly anyways
(cc @pdaniell-nv @ziga-lunarg @daniel-story)

Hi! thanks for adding Japanese too! It is correct that the Japanese translation of map is 地図. However, since it usually has a physical/geopolitical meaning, it looks a bit unnatural to Japanese speakers. In this case, it is better to translate it as マップ in katakana.

@yknishidate ありがとう、I wasn't sure, thats why I put in in 「」, but will switch the マップ


added redis connection docs . without installation steps or modified img

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: remove scc-related services from project

PR summary
This commit removes the Configuration Governance
and Posture Management services from the project.
These services are now available at
https://github.com/IBM/scc-python-sdk.
Signed-off-by: Phil Adams<EMAIL_ADDRESS>PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

:tada: This PR is included in version 0.28.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How do I use it if I am using View.OnClickListener within ViewHolder?

In your examples View.OnClickListener is within adapter. But I am using View OnClickListener with Viewolder that is in a separate file. Further I am using fragments within ViewPager and eac of these fragments contain recyclerview.
Please give a simple outline of how to proceed before you close this issue, as this is not exactly an issue but a question.

You should never do that.
A callback should be sent to your Activity from which you show the dialog.

Please elaborate a bit. What is that I shouldn't do? If possible give an outline of code.


Evaluation of unsupervised embedding (trainMode 5)

Which possibilities exist (out of the box) for evaluating/testing the unsupervised model (unsupervised word embeddings, trainMode 5)? When I try to use the unsupervised model as input for test -testFile (supervised classification), I only receive error "Test is undefined in trainMode5. Please use other trainMode for testing".
It would have been nice if we could use supervised classification (trainMode 0) as surrogate for testing the performance of the unsupervised learner (trainMode 5). That is, provide the trainMode 5 model (representation of the input) as input for a supervised classifier performing some task related to the domain the data is from.
Is this somehow possible, or something you plan to implement? It would then be possible to measure the performance of StarSpace (and the potential improvements it brings) more directly against other supervised classifiers using standard performance metrics.

You can certainly do this (semisupervised learning) with something like SentEval, which is what we did in the paper:
https://arxiv.org/abs/1709.03856
(See Tables 9 & 10). That trains a classifier on top of the embeddings.
Switching to trainMode 0 does something different, it tries to retrain the embeddings for a supervised task (rather than train something on top) -- and if there aren't enough training examples we're not sure that will work well...


[connectors-ui] Missing connector request (Other)

There is a simple implementation (Option 1), keeping the current Google form, that we are going to tackle, outside of this issue.
User story
As a User
I want to have a way to express a missing connector (+ Other)
So that (hopefully) it will get implemented soon in the platform.
Tasks:
Option 1:

[ ] Button + link current Google form (e:0.5 points)

Option 2:

[ ] 'Other' popup definition
[ ] Hubspot integration
[ ] Basic tests

Option 3:

[ ] Any other simple option WITH Hubspot integration?

Acceptance
Do connect to staging (feature-branch)
Then try to add a new dataset and fill in a form for the missing connector --> "Other" option
Verify you get proper feedback: the request was sent
Verify 2 A PM can log into (Google Form | Hubspot) to check / analyze the request.

We have decided to postpone the final option.

Option 1 would fit fast
Maybe an Option 2 simplified (without the popup) could fit too.

Option 3, as designed by  Mireya, is the way to go

Merged!


Allow overlaying predicted mask onto the original image

First of all THANK YOU FOR THIS!
This really helps visualize how effective the network is during / after training so you get output like the following

You can do it easily as shown below. Let me know if it makes sense and then I can merge it.
#change 1 (after line 70)
img_orig = copy.deepcopy(img)
#change 2 (after line 101)
if args.colored:
classMap_numpy_color = PILImage.fromarray(classMap_numpy)
classMap_numpy_color.putpalette(pallete)
classMap_numpy_color.save(args.savedir + os.sep + 'c_' + name.replace(args.img_extn, 'png'))
if args.overlay:
classMap_numpy_color = numpy.array(classMap_numpy_color)
overlayed = cv2.addWeighted(img_orig, 0.5, classMap_numpy_color, 0.5,0)
cv2.imwrite(args.savedir + os.sep + 'over_' + name.replace(args.img_extn, 'jpg'), overlayed)

I'm cool with anything if it produces the above image :laughing:

img_orig will still need to be resized if the input images are of diff sizes
Unclear how addWeighted works - classMap_numpy_color has a lot of black pixels in it (undetected region)

I have added an overlay option which will produce an output similar to below image. Please have a look.

Nice. Thanks 🙇
On Tue, Jul 3, 2018, 7:42 PM Sachin Mehta<EMAIL_ADDRESS>wrote:

I have added an overlay option which will produce an output similar to
below image. Please have a look.
[image: over_frankfurt_000000_000576_leftimg8bit]
https://user-images.githubusercontent.com/18603245/42253953-18728dbc-7ef9-11e8-8764-eb390807e148.jpg
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sacmehta/ESPNet/pull/12#issuecomment-402346689, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABCMYuUIMJuV14O7Lw1QupB9Gr4lB8SJks5uDCt7gaJpZM4U43Bu
.


Peculiar confusion matrix results for very imbalanced multiclass

I wonder if this is an optimization problem? Should we default to something besides accuracy - something like categorical cross-entropy?

STR
Adding a third target column goes out to multiclass. Like it. Good error when calling ROC. CM methods work, but algorithm appears not to:
dataframe['ThirtyDayReadmitFLG'].replace('Y', 'SnoCones', inplace=True)
dataframe['ThirtyDayReadmitFLG'].replace('N', 'Waffles', inplace=True)
dataframe.loc[0:5, 'ThirtyDayReadmitFLG'] = "Omelette"

classification_trainer = healthcareai.SupervisedModelTrainer(
   dataframe=dataframe,
   predicted_column='ThirtyDayReadmitFLG',
   model_type='classification',
   grain_column='PatientEncounterID',
   impute=True,
   verbose=False)

Yields:
    - LogisticRegression selected performance metrics:
    accuracy: 0.85

		Confusion Matrix (Counts)
		    - Predicted Classes are along the top
		    - True Classes are along the left.

		            SnoCones    Waffles    Omelette
		--------  ----------  ---------  ----------
		SnoCones           0         27           0
		Waffles            0        171           0
		Omelette           0          2           0

I've dug into this for a while and the more I learn, I think it is just that logistic regression, when asked to optimize for accuracy, does a terrible job with this admittedly terrible dataset. When using another algorithm instead, it seems to do better. I'm going to close this for now.


Add font size warning to TextSection

Objective

TextSections are unable to display their text value if the font_size is less than or equal to 0, thus @ickshonpe suggested we emit a warning to the console whenever this occurs.
Fixes #9655

Solution

Emit a warning if we detect that the font_size is less than or equal to 0.
Add bevy_log as a dependency to bevy_text to be able to access the warn! macro.

Similarly, bevy_text::TextSection::from_styleshould emit a warning as well, but I am unsure how to call the warn! macro since the method signature is const

Good work :) We could make from_section no longer const, although that would be a bit sad.

That TextSection could later be updated to be valid though. Our options here are:

silently fail
warn
return a Result (which will almost always get unwrapped)
panic

Because the problem is repairable and cosmetic, I think that warning is the least bad option, although I'm open to being convinced.

Silent fail won't give us information and Result always get's unwrapped, which doesn't add value.
If getting an invalid font size doesn't cause a crash/break down the line, I agree with the warning. We can later set a default value if that's ok. If it does break somewhere, panic with explanation is alright.

That TextSection could later be updated to be valid though.

When I posted the issue my thinking was that the warning would be added somewhere to the text systems rather than to TextSection itself because of the inverse of this, this implementation won't pick up if the text is updated later to an invalid state.
And there would be a flag to make sure the warning isn't spammed, similar to FontAtlasWarning.
Warning on creation of TextSections didn't occur to me and has advantages too. It covers 99% of cases, most users will never change the font size after creation, and the implementation is far simpler.

While we're at it, would it also make sense to check if the number is_finite (not NaN, -Inf, or Inf)? I would agree that this is an obvious bug in the calling code, but so is passing in a negative, therefore I think this check would be reasonable.


RC Test: Balancing Act 1.3.0-rc.1

RC Test
Mentions: @marlitas, @amanda-phet, @Luisav1
Simulation links

github repository for issues
phet top-level directory
sim: all_phet.html

Test Matrices

General Test Matrix

Features included

[ ] ~PhET-iO~
[x] Dynamic Locale
[ ] ~Alternative Input~
[x] UI Sound
[ ] ~Sonification~
[ ] ~Description~
[ ] ~Voicing~

Focus and Special Instructions
This publication includes the addition of region and culture characters that can be changed in the preferences dialog, as well as the addition of dynamic locales. Otherwise the logic or functions of the sim have not changed.
Any bugs that come up that can be replicated in the published version should receive an issue labeled as deferred. They will not be fixed for this upcoming publication unless highly prohibitive or concerning.
Issues to Verify
These issues should have the "status:ready-for-review" label. The issue can be closed after verifying.

[x] https://github.com/phetsims/balancing-act/issues/156

For QA...

General features

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test all query parameters on all platforms. (
See QA Book for a list of query parameters.)
Download HTML on Chrome and iOS.
Make sure the iFrame version of the simulation is working as intended on all platforms.
Make sure the XHTML version of the simulation is working as intended on all platforms.
Complete the test matrix.
Don't forget to make sure the sim works with Legends of Learning.
Test the Game Up harness on at least one platform.
Check this LoL
spreadsheet and notify AR or AM if it not there.
If this is rc.1 please do a memory test.
When making an issue, check to see if it was in a previously published version.
Try to include version numbers for browsers.
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there
is a problem.
As the RC ends, please review the QA credits in the about dialog. If the QA credits are complete and correct, please
add a comment in the RC test issue indicating so. If not, please open a new issue and specify what changes should be
made.

PhET-iO features

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.
Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:/wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER

Further instructions in QA Book
Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other
random platform.
Conduct a memory test on the stand alone sim wrapper (rc.1).
Test one platform combination with ?phetioDebug=true on the Studio and State wrapper.
If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
Test that the sim works offline:

Click the link to the phet-io zip file (at top of issue) to download the zip file.
Unzip it to a spot locally.
Open index.html by double clicking it on your desktop or in a Finder-view.
It should look like the standalone version of the sim in PhET-iO brand.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

If this sim is not in this list or up to date there, make an
issue in website to ask if PhET research page links need updating. Please
assign to @terracoda and @emily-phet.

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a screen reader bug,
please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Memory test with known leak

I saw something similar to https://github.com/phetsims/tambo/issues/156, where on iPad the sound was delayed, but not gone. After refreshing the page I haven't managed to reproduce this, so I'm not sure if it warrants an issue.

https://github.com/phetsims/scenery/issues/1631 makes finishing the Mobile VO hard, so more testing on that should wait for the fix.

Please keep me aware of any potential deployments, and whether I should not be deploying RCs for this for the maintenance release I'm doing. It looks like the only incomplete release branch right now.

Calling QA here

@jonathanolson, thanks for your note. We’re about to move Balancing Act into an RC spot-check phase. While this isn’t a deployment, I’ll make sure to keep you in the loop with any significant updates. With that said, I’m closing this RC test issue.


UI revamp - codename "Hacker Mode"

Change the UI to match the current kscale.dev site

Hacker mode activated


Exodrine in Handbook (Wrong Category)

The new Exodrine stimulant shows up in the Handbook in the wrong category. It should be in Stimulants instead of Medicals like Painkillers :-)

Fixed in the latest version. Exodrine is now correctly listed under Stimulants. Thanks for catching that! 😊


extension webview to be blank after run javascript window.location.reload()

When I try to implements VSCode webview + webpack HMR, the webpack need to call window.location.reload in some cases. But I found that vscode webview has the limitation:

extension webview to be blank after run javascript window.location.reload()

I want to know this is by designed or a bug?
You can test by add following code to webview javascript:
setTimeout(() => {
    console.log('reload....');
    console.log(location.reload());
}, 3000);

3s after you open webview, the content of webview would be blank without any message.

VS Code Version: 1.66.0-insider
OS Version: MacOS 12.2.1

@mattbierner.

This may just VSCode Limit


Test temp

Test from local
name: Bug report about: Create a report to help us improve title: '' labels: '' assignees: ''
Describe the bug A clear and concise description of what the bug is.
To Reproduce Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error
Expected behavior A clear and concise description of what you expected to happen.
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]
Smartphone (please complete the following information):
Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]
Additional context Add any other context about the problem here.

I was testing a feature regarding the terminology service and reported this by mistake. Sorry for the inconvenience.


Multiple ignore files and paths

I am trying to add one file and one directory to the ignore input. I tried, separation with a space, with a comma and putting the input in paranthesis as well as brackets. Nothing worked. The parenthesis and the brackets were rejected and with space or comma separation, only the first entry is ignored.
This is my workflow file.

I looked into supporting multiple files with ignore, but due to how the underlying tool works and how we have this set up right now, that's unfortunately not possible.
As an alternative we recommend using .markdownlintignore as documented here.


Feature/improve readme

Summary
This PR improves the README by adding:

Detailed explanation on how to set up a GitHub webhook, including setting the content type to application/json and selecting the appropriate event triggers.
An additional method for downloading the repository using curl.
Instructions to create the swu-data directory for Docker.

Changes

Prerequisites:

Added detailed steps to set up a GitHub webhook.
link to the official documentation
Specified the content type (application/json)
and specify the events to trigger (at least "Release").

Installation:

Added a method to download the repository using curl.
Update the rest of the installation methods
Included a step to create the swu-data directory for Docker setup (to avoid warning when running docker compose up -d the first time)

Motivation
These changes aim to make the setup process clearer and more accessible for users by providing additional methods and detailed instructions.
Checklist

[x] I have performed a self-review of my own code.
[x] My changes generate no new warnings.

Additional Comments
Please review the changes and let me know if any further modifications are needed. Thank you!

Could you add in the readme the steps to push a tag ? Otherwise, your PR is clear and perfect !

Sure, I added it in the latest commit


Chromedriver process on Windows not cleaned up after specs complete

Overview
While testing out the wdio-electron-service-example project on a Windows machine I noticed that the chromedriver process was not being cleaned up after running the test suite (with npx wdio).
Details
I believe this line in the launcher is the start of the issue (snippet copied below).
if (isWin) {
  process.env.WDIO_ELECTRON_NODE_PATH = process.execPath;
  process.env.WDIO_ELECTRON_CHROMEDRIVER_PATH = chromedriverServiceOptions.chromedriverCustomPath;
  chromedriverServiceOptions.chromedriverCustomPath = join(__dirname, '..', 'bin', 'chrome-driver.bat');
}

This is overriding any path to chromedriver (whether custom or default) to instead use this .bat file.
@echo off
"%WDIO_ELECTRON_NODE_PATH%" "%WDIO_ELECTRON_CHROMEDRIVER_PATH%" %*
if ERRORLEVEL 1 exit /b 1
exit /b 0

Now, this does make sense since the default chromedriverCustomPath points to node_modules\electron-chromedriver\chromedriver.js. However, the .bat file does not wait for node to exit before the terminal running the .bat file is allowed to exit. Node is allowed to keep running while its original parent terminal process has died, which causes problems in the wdio-chromedriver-service.
At this line of the wdio-chromedriver-service the child process for chromedriver is spawned and a reference kept, although because of the .bat file override earlier, this.process refers to the terminal process that will soon start Node.
By the time we hit the this.process.kill() command in the onComplete service handler, this.process has already long since died and the Node/chromedriver processes are running as their own process tree, disconnected from this.process.
An example process tree might look like this (pids taken from my last run):
cmd.exe (28956) [this.process] <-- dies immediately after node.exe is started
|____ node.exe (22832)
      |____ chromedriver.exe (24100)

Solution
A real solution to this issue will likely involve tracking the child node process or communicating with it to collaboratively shutdown. Unfortunately I don't have anything like that to offer right now, though I do have a relatively small workaround fix that would at least mitigate the problem.
The use of the .bat file launcher seems to only make sense if a chromedriver file is provided that needs to run within node (js file). If a user provides a path to chromedriver.exe in chromedriverCustomPath, it is currently still passed through to the .bat file to be run in Node. I propose that we only use the .bat file for .js files and allow any other extension to be run directly via child_process.spawn().
Something like (in launcher.ts):
import { join, extname } from 'path';
// snip...

if (isWin) {
  process.env.WDIO_ELECTRON_NODE_PATH = process.execPath;
  process.env.WDIO_ELECTRON_CHROMEDRIVER_PATH = chromedriverServiceOptions.chromedriverCustomPath;
  const shouldRunInNode = extname(chromedriverServiceOptions.chromedriverCustomPath) === '.js';
  if (shouldRunInNode) {
    chromedriverServiceOptions.chromedriverCustomPath = join(__dirname, '..', 'bin', 'chrome-driver.bat');
  }
}

This would allow anyone encountering this issue to specify the chromedriver.exe path themselves and bypass the extra .bat file redirection (from wdio.conf.js):
const config = [
services: [
    [
      'electron',
      {
        appPath: join(__dirname, 'dist'),
        appName: productName,
        appArgs: ['foo', 'bar=baz'],
        chromedriver: {
          port: 9519,
          logFileName: 'wdio-chromedriver.log',
          // provide custom path to .exe to bypass use of .bat file
          chromedriverCustomPath: require.resolve('electron-chromedriver/bin/chromedriver.exe'),
        },
      },
    ],
  ],
  // snip...
]

This work around solves the problem in my case. Specs in the example project complete successfully and the chromedriver process dies at the end. If the work around is acceptable, I would be happy to submit a PR.

Hi @sparerd, thanks for the detailed issue description.  I'm definitely interested in improving the service usage in Windows, however there are bigger fish to fry at the moment - I'm currently working on a major update addressing these three thorny issues: #35 #31 #27.
When these are working I'll look at the Windows situation before the release.

@sparerd feel free to provide a PR with a fix if interested.

This was also reported in wdio-electron-service-example.

I'm using this as a workaround :
onComplete: async function (exitCode, config, capabilities, results) {
    shell.exec('taskkill /IM chromedriver.exe /F', { silent: true });
    shell.exec('kill -9 $(pgrep chromedriver)', { silent: true });
}

Workaround released with v4


Highlight changed lines

Issue Type: Feature Request
Changed no saved lines / Changed saved lines should be conspicuous in minimap and line number bar
VS Code version: Code 1.23.1 (d0182c3417d225529c6d5ad24b7572815d0de9ac, 2018-05-10T17:11:17.614Z)
OS version: Windows_NT x64 6.1.7601

Are you using source control? The changed lines already show up in the gutter if you are

I've noticed that staged changes don't show in the gutter.

I also have experienced the issue that staged changes do not show in the gutter.  Staging a file causes the gutter highlights to vanish.  It would make more sense for staged changes to be highlighted with a different color and still be revertable or diff-viewable from clicking the gutter highlight.

@Gruntfuggly @fishpen0 This is as designed. The quick diff shows a diff from the index to the file on disk.


SyncBot: Images don't quite translate right

Placeholder issue for now, so I don't forget it.

https://www.flowdock.com/app/rulemotion/public-s-community/threads/NxVJuPwKPi6NyRpEjjLTrTjUc9A

Taken from my inbox nags:
Confer with Juan that images cannot be muddled out of Front

There is the expectation that images provided in a comment will work across all platforms.  This needs testing, the holes found, patched, etc.


No permissions found in manifest for: []9

Not being able to pick image from gallery...Works well with camera and other permission
Have also given permission

Hi @Palaceapp, please provide a complete minimal reproducible code sample that we can run without making any major changes along with the output of flutter doctor -v.
Please also provide the content of your android/app/src/main/AndroidManifest.xml.
Thank you


Rename "spectral solver" to EigenPoissonSolver in the code.

The core of the method is an eigenfunction expansion of the discrete Poisson operator... I think?
Perhaps we can call this a EigenPoissonSolver, or even FFTPoissonSolver --- through we should use caution to avoid misleading people into thinking that our code is spectral. This algorithm solves the Poisson equation when it has been discretized on a staggered grid. We should not discuss spectral methods or Fourier transforms, and the word 'spectral' should not appear anywhere in the code. I think this is very misleading. It should be a high priority to change this language.
Originally posted by @glwagner in https://github.com/climate-machine/Oceananigans.jl/issues/102#issuecomment-468947308

I think EigenPoissonSolver is a better name. Just creating a separate issue as this should be a pretty easy item to resolve, and is separate from updating the documentation.

@ali-ramadhan here is my proposed re-factor of the poisson solver:
https://github.com/glwagner/Oceananigans.jl/blob/poisson-solver-refactor/src/poisson_solver.jl
Now may be the right time to move it to a new package, because we can run the tests independent from oceananigans before refactoring oceananigans itself.

Closed by #109


Silent crash when passing class instance as dict to function kwargs when pathlib is imported

Hello! I've got another crash, this time very weirdly silent one (without any error text). Possibly related to #3242.

Nuitka version (last factory commit: 1fb542a, also happens with 2.5.6 main), full Python version

2.6rc7
Commercial: None
Python: 3.13.1 (tags/v3.13.1:0671451, Dec  3 2024, 19:06:28) [MSC v.1942 64 bit (AMD64)]
Flavor: CPython Official
GIL: yes
Executable: C:\Program Files\Python\3.13\python.exe
OS: Windows
Arch: x86_64
WindowsRelease: 10
Version C compiler: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\bin\Hostx64\x64\cl.exe (cl 14.3).

How did you install Nuitka and Python

python -m pip install -U "https://github.com/Nuitka/Nuitka/archive/factory.zip"

test.py program code

from threading import Thread
from dataclasses import dataclass, field
# Commenting path printing *and* the import below stops crashes
from pathlib import Path

@dataclass
class DataObject:
    test: bool = False

def test_function(test=False):
    print(f'test_function args: test={test}')

def run_as_thread(callback, *args, **kwargs):
    thread = Thread(target=callback, kwargs=kwargs)
    thread.start()

if __name__ == '__main__':
    data_object = DataObject(test=True)
    # Commenting the line below *without* commenting unused import still crashes
    print('Path: ', Path('C:/'))
    # Works
    run_as_thread(test_function, **{'test': True})
    # Crashes program
    run_as_thread(test_function, **data_object.__dict__)

Nuitka options and build output

C:\Test>python -m nuitka test.py --standalone
Nuitka-Options: Used command line options: test.py --standalone
Nuitka: Starting Python compilation with Nuitka '2.6rc7' on Python '3.13' commercial grade 'not installed'.
Nuitka-Plugins:anti-bloat: Not including 'socket' automatically in order to avoid bloat, but this may cause: can break
Nuitka-Plugins:anti-bloat: calls of 'email.utils.make_msgid()'.
Nuitka: Completed Python level compilation and optimization.
Nuitka: Generating source code for C backend compiler.
Nuitka: Running data composer tool for optimal constant value handling.
Nuitka: Running C compilation via Scons.
Nuitka-Scons: Backend C compiler: cl (cl 14.3).
Nuitka-Scons: Backend linking program with 6 files (no progress information available for this stage).
Nuitka-Scons: Compiled 6 C files using clcache with 6 cache hits and 0 cache misses.
Nuitka: Keeping build directory 'test.build'.
Nuitka: Successfully created 'C:\Test\test.dist\test.exe'.

Program output to console

C:\Test\test.dist>test.exe
Path:  C:\
test_function args: test=True

Expected program output to console

C:\Test\test.dist>test.exe
Path:  C:\
test_function args: test=True
test_function args: test=True

It might be because threads never switch there, main thread terminating stops the program, is there an error exit code?

Oh, I've indeed stripped the code way too much. Here's more proper example.
from threading import Thread
from dataclasses import dataclass, field
# Commenting path printing *and* the import below stops crashes
from pathlib import Path

@dataclass
class DataObject:
    test: bool = False

def test_function(test=False):
    print(f'test_function args: test={test}')

def run_as_thread(id, callback, *args, **kwargs):
    thread = Thread(target=callback, kwargs=kwargs)
    print(f'Starting thread {id}...')
    thread.start()
    print(f'Thread {id} is running')
    thread.join()
    print(f'Thread {id} joined')

if __name__ == '__main__':
    data_object = DataObject(test=True)
    # Commenting the line below *without* commenting unused import still crashes
    print('Path: ', Path('C:/'))
    # Works
    run_as_thread(0, test_function, **{'test': True})
    # Still runs
    print('Still alive!')
    # Crashes program
    run_as_thread(1, test_function, **data_object.__dict__)
    # Graceful exit
    print('Program exit')

test.cmd contents
C:\Test\test.dist\test.exe
ECHO %ERRORLEVEL%

Program .exe  output when built as is

C:\Test\test.dist>test.cmd

C:\Test\test.dist>C:\Test\test.dist\test.exe
Path:  C:\
Starting thread 0...
test_function args: test=True
Thread 0 is running
Thread 0 joined
Still alive!
Starting thread 1...

C:\Test\test.dist>ECHO -1073741819
-1073741819

Program .exe  output when built with pathlib import and usage commented out

C:\Test\test.dist>test.cmd

C:\Test\test.dist>C:\Test\test.dist\test.exe
Starting thread 0...
test_function args: test=True
Thread 0 is running
Thread 0 joined
Still alive!
Starting thread 1...
test_function args: test=True
Thread 1 is running
Thread 1 joined
Program exit

C:\Test\test.dist>ECHO 0
0

Thanks for the excellent level of bug reporting you do. I will be looking into this and hopefully figure it out. Maybe it's still the dictionary usage, although it looks to be no different (dictionaries copied for function call usage), but there is threading work in 3.13 that I took note of, but I believed this to be about no-GIL and possible to delay. Apparently not.


Support to require certain roles using nextjs middleware

Currently we can do the do the following to protect routes via middleware
import { withMiddlewareAuth } from "@supabase/supabase-auth-helpers/nextjs/middleware";

export const middleware = withMiddlewareAuth({ redirectTo: "/login" });

However I'd like to restrict certain routes for certain roles; e.g. admins only. I keep track of my admins in a table so it is basically a question of reading data from the database and require some condition based on that. Any suggestion on how to achieve that?

We could add an option to provide a user callback to determine if a user is allowed or not.
So extend the parameter options to this
export interface withMiddlewareAuthOptions {
  redirectTo?: string;
  cookieOptions?: CookieOptions;
  tokenRefreshMargin?: number;
  permissionGuard?: {
    isPermitted: (user: User) => boolean
    redirectTo: string;
  }
}

And then add the following line before returning
if (permissionGuard && permissionGuard.isPermitted(authResult.user)) {
    throw new Error('User is not permitted, redirecting');
}

We then have to update the error handling to handle two different type of errors (since it needs to redirect to different paths).
If you think this is viable then I'll put together a PR - let me know.

This is a case that I am running into, will be very helpful for sure

Simarily we could do something similar on withApiAuth. I'm waiting for the maintainers to comment/accept #104  before "copying" the solution over.

PR for this was merged and will be out in the next release.


[SPIKE] UI Rendering with external @srcbook/ui-sdk lib + websockets transport

This MVP attempts to create a UI app interactively within Srcbook, but does it by running a cell, which declaratively describes a UI app at a high level of functionality. The SDK is inspired by interval.com's one, designed to build very opinionated internal tooling, inter-twined with node backend code.
The @srcbook/api is now a "proxy" websocket server, which broadcasts events back to the session:<id> channel. This is because otherwise registration between the node process running @srcbook/ui-sdk and the frontend would rely on the server anyways. Down the line, we can likely create better channel hygiene and not re-broadcast all events like I do now.
Here is the TS cell creating the app:
import { Action, io, UIApp } from '@srcbook/ui-sdk';

const greetingAction = new Action('greeting', async () => {
  const name = await io.input.text("What's your name?");
  const age = await io.input.text("How old are you?");
  const greeting = `### Hello, ${name}!\n\nYou are \`${age}\` years old.`;
  await io.display.markdown(greeting);
  return greeting;
});

// UIApp knows how to connect to the proxy WS server
// through an env var passed to it
const app = new UIApp(greetingAction);
app.run();

Gif of experience (no design effort made)

Events
Currently, the node process running in the cell sends a serialized component spec with an ui:io:await_response event. The client renders this, and once the user submits the interaction, the web client sends a ui:io:response event which leads to a promise getting resolved, which leads to the code continuing it's execution.
Ideas that I will explore further

Need to try more complex DSL things. In particular grouping of fields
Need to introduce "start" "stop" mechanics for the app
Need to support cancellation flows
Rethink the events, which are very simple right now.

We are closing this SPIKE for now. We like the direction but want to explore another alternative of rendering browser cells (HTML, .jsx, react apps) and see how that feels also.
The long term goal is to help developers build and deploy entire apps, and the UI kit might be limiting for more complex or unique apps. It might still have a place on the "fast and efficient" side of the tradeoff, but we'll revive it at that point if the time comes. Keeping the branch alive.


Lookup failing to find actor in cache during signature verification

KeyId's often have a hash suffix, e.g. https://example.com/users/bob#main-key, but when apex fetches that IRI, it receives:
{
  id: "https://example.com/users/bob",
  ...
}

so an object with id: https://example.com/users/bob#main-key never gets cached and is fetched again on each signature validation attempt

Related to immers-space/guppe#95


Add groups to User

This is missing ref and type. The type attribute should probably be "direct", and I would appreciate advise on how to correctly add ref

The methods within a ResourceHandler will receive a Context-object that represents the current request-context. It provides also methods to get $ref-urls
context.getResourceReferenceUrl(id);
context.getCrossResourceReferenceUrl(ResourceTypeNames.USER, id);

It is also possible to simply set the type-attribute to "Group" and the $ref-Attribute will be automatically set by the schema-validation

please add a unit test to prevent future regressions.


remove unused overrides decorator

Codecov Report

Merging #15 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   71.19%   71.07%   -0.12%
==========================================
  Files         125      125
  Lines        6179     6172       -7
==========================================
- Hits         4399     4387      -12
- Misses       1780     1785       +5

Impacted Files
Coverage Δ

baconian/algo/dynamics/mlp_dynamics_model.py
96.93% <ø> (-0.04%)
:arrow_down:

baconian/algo/policy/deterministic_mlp.py
100.00% <ø> (ø)

baconian/algo/policy/random_policy.py
93.33% <ø> (ø)

baconian/algo/value_func/mlp_q_value.py
100.00% <ø> (ø)

baconian/algo/value_func/mlp_v_value.py
98.07% <ø> (-0.08%)
:arrow_down:

baconian/tf/tf_parameters.py
89.36% <ø> (-0.08%)
:arrow_down:

baconian/common/schedules.py
91.42% <0.00%> (-2.86%)
:arrow_down:

baconian/algo/dynamics/third_party/gmm.py
98.09% <0.00%> (-1.91%)
:arrow_down:

baconian/algo/ppo.py
88.78% <0.00%> (ø)

baconian/core/agent.py
96.59% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb64bcb...7e535fa. Read the comment docs.


CI badges in readme out of sync

Describe the bug
in the github main page (see screenshot) the badges show all the CI failing.

checking if thats the case (by clicking on it) Travis is all green. see this:

It seems to mean that the badges are not synchronized.
Expected results
Since the tests are passed I would expect the badges to be green.
Actual results
The bagdes are red, and it states "failing".

well our current master is actually broken :(
but the svg badges should point to the master branch as done here:
https://docs.travis-ci.com/user/status-images/

It appears correct see
https://travis-ci.org/mne-tools/mne-python/jobs/444753486

hum :(
but we still should fix the badges to point to master branch or maybe it's
not necessary?

in README.rst:
.. |Travis| image:: https://api.travis-ci.org/mne-tools/mne-python.png?branch=master

so it should already


Problem scripting gdb under wsl2

Your Windows build number:  (Type ver at a Windows Command Prompt)

19551

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)

We use the following gdbinit script to debug our code  https://github.com/aros-development-team/AROS/blob/master/_gdbinit
It has some logic to handle symbols the binary hasn't provided, but these cause gdb to fail under wsl.

What's wrong / what should be happening instead:

performing the following segment,
# Define $symbol = (type)addr if it exists,  undefined if not
define symbol_check
  log_to_file symbol.tmp on
  p $arg0
  end_log

  shell sed -i -e '/^[^\$]/d' -e 's/^\$[0-9]* =/set $'$arg0' =/' symbol.tmp
  source symbol.tmp
end

gdb under wsl silently falls back to the gdb prompt at the "p $arg0" line, for symbols that dont exist, causing the rest of the script to fail to run correctly, and leaving logging directed to the file confusing people using it.
under linux/bsd/macos etc this does not happen, allowing us to use the information to determine if we need to spoof the symbol and do the necessary steps.

Strace of the failing command, if applicable:  (If some_command is failing, then run strace -o some_command.strace -f some_command some_args, and link the contents of some_command.strace in a gist here).

For WSL launch issues, please collect detailed logs.

There no output on Real Linux.


NTR: blood microbiology assay

label: blood microbiology assay
definition: an organism identification assay that identifies a microorganism in a blood specimen
parent: organism identification assay

subclassOf has_specified_input some 'blood specimen' suggested as axiom


Update to pass bandit testing

This PR updates cyhy-data-extract.py to clear bandit checks for pre-commit integration. The way data is retrieved from the MongoDB database has also been rewritten to improve speed and running overhead.

Let's merge this thang!

:shipit:


Danish character diaplyed as "?" in GUI - Indfødningstarif produktion

In the the default tariff for production metering point "Indfødningstarif production", the Danish character ø is displayed as a question mark.


Stack corruption if rtp packet size is 1400

Hi @sepfy !
I found an issue in surveillance example which possibly affects overall pear usage.
Default mtu size of rtph264pay is 1400 url
RTP packet buffer size is 1400 also url
peer_connection_send_rtp_packet uses srtp_protect inside, which writes outside of provided buffer, which leads to stack corruption: note in libsrtp docs.
I think to avoid this the only option is to inreased buffer size, but I cannot deduce how huge it should be.
Please review this problem.

Thanks for the suggestion! Let me look into it.


Show subnet details

The legacy geoiplookup utility shows details about the subnet of the given IP address if -i has been passed. goiplookup on the other side uses the -i option to only show the ISO country code.
Example:
$ geoiplookup -i <IP_ADDRESS>
GeoIP Country Edition: US, United States
  ipaddr: <IP_ADDRESS>
  range_by_ip:  <IP_ADDRESS> - <IP_ADDRESS>
  network:      <IP_ADDRESS> - <IP_ADDRESS> ::14
  ipnum: 134744072
  range_by_num: 134739200 - 135192575
  network num:  134742016 - 135004159 ::14

$ goiplookup -i <IP_ADDRESS>
US

Getting the subnet of the specific IP address was a big benefit of the geoiplookup utility.
Would it be possible to implement the same functionality as previously known from the legacy utility?

I'd love to, but I don't think this is possible to be honest, as either the new mmdb country format (or possibly the geoip library I'm using) doesn't appear to provide any of that information: https://github.com/oschwald/geoip2-golang/blob/347ca45869a87337a71b11efe9b3043bc10df97f/reader.go#L136
If you're able to confirm that the new country mmdb format provides this data, then that would be a great help!

Weird, the subnet information are included in the CSV version of the GeoLite2 Country DB. So I guess there is nothing you can do from your side in implementing that feature.


utils.py function bugs

The function filter_dataset  and compute_avg_features in utils.py has a not expected behaviour :
---> 49 for images, labels, path in loader:
50     paths = list(path)
51     images, labels = images.to(device), labels.to(device)
ValueError: not enough values to unpack (expected 3, got 2)
They expect 3 items from loader which is not usual, but it is the case in use_case sports_image_classification
=> should generalize behaviour

fix in commit 47224fa


Transfer and Reorganize ship code to MovingWorld library.

I'm planning on moving a lot of the core code of the mod into the MovingWorld library, the goal of this is to allow other modders to addon and take advantage of the code for their own uses. Once a lot of this code is moved into MovingWorld it will be much easier for me to add new types of ships and it will also be a lot easier for other developers to run their own entities on ships if they so choose.
There isn't very much work that has been done on MovingWorld but the github repo is open and is licensed under Apache 2.0 https://www.github.com/darkevilmac/MovingWorld

New update with more information being made at this time.


357

Flatten all (flattenable) folds (Used mainly ternary operators).
Fix getAlt in Validation (added tests)
Changed the declaration of traverse (Validation, These and Either) from function to values (const) in order to correctly type one of the param and avoid creating another unnecessary closure doing so (of function).
Further optimisation (also chain flattening) for mapOption, rights and lefts of Array.
(Fixes #357)

@gcanti who / when / where do you want we merge that back?

@sledorze I'm working on a PR which adds more tests for each change contained in this PR in order to help you out with this and avoid regressions

@gcanti done!


Device Family

Is RemoteSystemSessionController works with Windows 10 IoT Core?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 98d6519e-4d2e-2fee-0a0b-546d2db8d183
Version Independent ID: f46543c5-a76f-1a86-12c0-c39d24104dfc
Content: Connect devices through remote sessions - UWP app developer
Content Source: windows-apps-src/launch-resume/remote-sessions.md
Product: windows
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

Hi superkid200,
No, Windows 10 IoT Core does not currently support Remote Sessions or other Project Rome features.

How about phones?


x/build/cmd/coordinator: clean build fails

from https://travis-ci.org/kevinburke/build/builds/245548241:
Status: Downloaded newer image for golang:1.8
 ---> 41e7847de71b
Step 2/17 : LABEL maintainer<EMAIL_ADDRESS> ---> Running in 3269c00ccbe7
 ---><PHONE_NUMBER>54
Removing intermediate container 3269c00ccbe7
Step 3/17 : RUN go get -d cloud.google.com/go/compute/metadata cloud.google.com/go/datastore cloud.google.com/go/storage &&     cd /go/src/cloud.google.com/go &&     git reset --hard cd0da878c66091060d2e7403abd62192b3e387e0
 ---> Running in b79f51cf935a
HEAD is now at cd0da87 datastore: add field name keys to protobuf struct literals
 ---> b8ee197660fd
Removing intermediate container b79f51cf935a
Step 4/17 : RUN go get -d golang.org/x/perf/storage &&     cd /go/src/golang.org/x/perf &&     git reset --hard b74b45749c47cd1edf5b64df78ecf13bd2dd944f
 ---> Running in 08238ef90ee1
HEAD is now at b74b457 storage: add Context arguments for queries
 ---> 4296bc6171f9
Removing intermediate container 08238ef90ee1
Step 5/17 : RUN go get -d golang.org/x/time/rate &&     cd /go/src/golang.org/x/time/rate &&     git reset --hard f51c12702a4d776e4c1fa9b0fabab841babae631
 ---> Running in d6ffecbc69b3
HEAD is now at f51c127 rate: change doc for ReserveN to reflect its signature
 ---> 5890e3a6f10a
Removing intermediate container d6ffecbc69b3
Step 6/17 : RUN go get -d golang.org/x/oauth2 golang.org/x/oauth2/google &&     cd /go/src/golang.org/x/oauth2 &&     git reset --hard 314dd2c0bf3ebd592ec0d20847d27e79d0dbe8dd
 ---> Running in 54c6938d944c
HEAD is now at 314dd2c golang.org/x/oauth2/jwt: Set kid to KeyID of private key
 ---> c7289af1f99c
Removing intermediate container 54c6938d944c
Step 7/17 : RUN go get -d golang.org/x/crypto/acme/autocert &&     cd /go/src/golang.org/x/crypto &&     git reset --hard 573951cbe80bb6352881271bb276f48749eab6f4
 ---> Running in ca10b370717c
HEAD is now at 573951c ssh: improve client public key authentication
 ---> 8277d426cff8
Removing intermediate container ca10b370717c
Step 8/17 : RUN go get -d go4.org/syncutil &&     cd /go/src/go4.org &&     git reset --hard 7ce08ca145dbe0e66a127c447b80ee7914f3e4f9
 ---> Running in 5ec55a569bfd
HEAD is now at 7ce08ca Added Solaris to the list of builds that are compatible with 'lock_unix'.
 ---> edee140c90ff
Removing intermediate container 5ec55a569bfd
Step 9/17 : RUN go get -d golang.org/x/net/context &&     cd /go/src/golang.org/x/net &&     git reset --hard f2499483f923065a842d38eb4c7f1927e6fc6e6d
 ---> Running in d60bf0fb1aff
HEAD is now at f249948 idna: Revert "use code generated by internal x/text package"
 ---> a2bff8b2e4ac
Removing intermediate container d60bf0fb1aff
Step 10/17 : RUN go get -d google.golang.org/api/container/v1 google.golang.org/api/compute/v1 google.golang.org/api/googleapi &&     cd /go/src/google.golang.org/api &&     git reset --hard dfa61ae24628a06502b9c2805d983b57e89399b5
 ---> Running in b92c5c89eb74
HEAD is now at dfa61ae all: regenerate all APIs
 ---> 7d77512a0f74
Removing intermediate container b92c5c89eb74
Step 11/17 : RUN go get -d google.golang.org/genproto/googleapis/type/latlng google.golang.org/genproto/googleapis/datastore/v1 &&     cd /go/src/google.golang.org/genproto  &&     git reset --hard b3e7c2fb04031add52c4817f53f43757ccbf9c18
 ---> Running in ae12d1e406fd
HEAD is now at b3e7c2f use proto's go_package option (#17)
 ---> e6407fee07f8
Removing intermediate container ae12d1e406fd
Step 12/17 : RUN go get -d gopkg.in/inf.v0 &&     cd /go/src/gopkg.in/inf.v0 &&     git reset --hard 3887ee99ecf07df5b447e9b00d9c0b2adaa9f3e4
 ---> Running in 28dc348d19cc
HEAD is now at 3887ee9 clarify license
 ---> d61c04f05ce6
Removing intermediate container 28dc348d19cc
Step 13/17 : RUN cd /go/src/google.golang.org/grpc &&     git reset --hard 50955793b0183f9de69bd78e2ec251cf20aab121
 ---> Running in 911db26fea63
HEAD is now at 5095579 Debugging tests for AuthInfo (#1046)
 ---> 83c8ff38a583
Removing intermediate container 911db26fea63
Step 14/17 : RUN go get grpc.go4.org &&     cd /go/src/grpc.go4.org && git reset --hard 11d0a25b491971beb5a4625ea7856a3c4afaafa5
 ---> Running in 54e1e9abd84a
HEAD is now at 11d0a25 all: change import path to grpc.go4.org
 ---> d1f5d584ac6c
Removing intermediate container 54e1e9abd84a
Step 15/17 : ARG version=unknown
 ---> Running in ca1a2bd98c94
 ---> f8f747302b1b
Removing intermediate container ca1a2bd98c94
Step 16/17 : COPY . /go/src/golang.org/x/build/
 ---> f51572020cc8
Removing intermediate container b91ad987ee72
Step 17/17 : RUN go install -ldflags "-linkmode=external -extldflags '-static -pthread' -X 'main.Version=$version'" golang.org/x/build/cmd/coordinator
 ---> Running in 523b7e884ce0
src/github.com/googleapis/gax-go/call_option.go:38:2: cannot find package "google.golang.org/grpc/status" in any of:
	/usr/local/go/src/google.golang.org/grpc/status (from $GOROOT)
	/go/src/google.golang.org/grpc/status (from $GOPATH)
Removing intermediate container 523b7e884ce0
The command '/bin/sh -c go install -ldflags "-linkmode=external -extldflags '-static -pthread' -X 'main.Version=$version'" golang.org/x/build/cmd/coordinator' returned a non-zero code: 1
make: *** [build0] Error 1

Working on a fix now.

I don't understand what failure you're reporting.
How can I reproduce?
(Everything seems to build fine for me.)

In a $GOPATH with no dependencies downloaded, cd cmd/coordinator && make docker-dev errors.

I tried both:

an empty $GOPATH + go install golang.org/x/build/cmd/coordinator
and
an empty $GOPATH, then add to it only golang.org/x/build, then cd cmd/coordinator && make docker-dev.

Both (1) and (2) work.
And I see no reason why (2) would ever fail, since it's in Docker and doesn't use your $GOPATH.

Oh, and both (1) and (2) were with Go 1.8.
Does it require tip?

Let me see if I can reproduce. I can reproduce it currently in Travis CI using this file
$ cat .travis.yml
sudo: required
language: go
go_import_path: golang.org/x/build

services:
  - docker

before_install:
  # Hack to work around https://github.com/golang/go/issues/20423.
  - go get go4.org/syncutil

go:
  - 1.8
  - tip

script:
  - go vet ./... || true
  - go test -v -race ./...
  - pushd cmd/coordinator && make docker-dev && popd
  - pushd cmd/gitmirror && make docker-dev && popd
  - pushd cmd/gopherbot && make docker-dev && popd
  - pushd cmd/pubsubhelper && make docker-dev && popd
  - pushd devapp/devappserver && make docker-dev && popd
  - pushd maintner/maintnerd && make docker-dev && popd

(It fails on both Go 1.8 and tip in Travis CI)

I wonder if it's your before_install of go get go4.org/ANYTHING that's the problem there.

I can't reproduce my earlier attempts using Go tip.

(That is, it works for me with both Go 1.8 and Go tip, without Travis)

I was able to reproduce it with the following script:
#!/usr/bin/env bash

set -eo pipefail

main() {
    rm -rf "$HOME/tmp/go"
    mkdir -p "$HOME/tmp/go/src/golang.org/x"
    export GOPATH="$HOME/tmp/go"
    pushd "$HOME/tmp/go/src/golang.org/x"
        git clone https://go.googlesource.com/build
        pushd build/cmd/coordinator
            env | grep GOPATH # just checking
            make docker-dev
        popd
    popd
}

main "$@"

That prints the following error:
Step 17/17 : RUN go install -ldflags "-linkmode=external -extldflags '-static -pthread' -X 'main.Version=$version'" golang.org/x/build/cmd/coordinator
 ---> Running in d2e0e8e00097
src/github.com/googleapis/gax-go/call_option.go:38:2: cannot find package "google.golang.org/grpc/status" in any of:
	/usr/local/go/src/google.golang.org/grpc/status (from $GOROOT)
	/go/src/google.golang.org/grpc/status (from $GOPATH)

If that doesn't reproduce it, maybe Docker is caching an older, correct, image, on your machine.

@cybrcodr just encountered this and came to the same conclusion: that my local Docker cache is just getting lucky.
He writes:

My git rev is at the same commit d59834090c8e8cf6f4eff02e9433f27274d2b84e as yours.  Previous attempt was on my Goobuntu host.  I decided to try it out on my Mac instead.  I encountered the same issue.  So, I dug in to find the culprit and here's what I've figured out.
"go get -d cloud.google.com/go/compute/metadata" pulls in latest "github.com/googleapis/gax-go".    As for why you're not seeing the same issue, my guess is that because your build is using cache.  Add --no-cache on docker build invocations and see if you can reproduce the issue I raised ...
[...]
I think the challenge here is that while we do reset certain repos at a particular commit version, the transitive dependencies are not pinned and may clash with repos that are pinned.

Ok - Hopefully the CL I submitted should fix this...

Which CL?

Ugh, I forgot the golang/go preamble. See linked.