Robot has an ERROR - charger-Offline

What does this error mean and how to remove it from the log?)
Roborock S6

Has your Dock power?

Yes

Can you test with my latest commit
4569d058cc7b0a0c23a9853635b28c402b69b25a

It seems the cleaning state isn't updatet if zone or room cleaning is started ... very strange

Maybe we are missing any cleaning state here?
https://github.com/nicoh88/homebridge-xiaomi-roborock-vacuum/blob/master/index.js#L30

i just created a PR in @nicoh88 miio Fork ... Room cleaning has an own Property ID (18) ... this wasn't handled by code

Hello I have the same error with my S5max
[2020-3-17 3:58:58 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 3:59:28 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 3:59:55 PM] [Aspirateur] INF getCleaning | roborock.vacuum.s5e | Cleaning is false
[2020-3-17 3:59:55 PM] [Aspirateur] INF getSpeed | roborock.vacuum.s5e | Fanspeed is 102 over miIO. Converting to HomeKit
[2020-3-17 3:59:55 PM] [Aspirateur] INF getSpeed | roborock.vacuum.s5e | Fanspeed is 102 over miIO "Balanced" > HomeKit speed 60%
[2020-3-17 3:59:55 PM] [Aspirateur] INF getBattery | roborock.vacuum.s5e | Batterylevel is 100%
[2020-3-17 3:59:55 PM] [Aspirateur] INF getCharging | roborock.vacuum.s5e | Charging is true (Status is charging)
[2020-3-17 3:59:55 PM] [Aspirateur] INF getBatteryLow | roborock.vacuum.s5e | Batterylevel is 100%
[2020-3-17 3:59:55 PM] [Aspirateur] INF getPauseState | roborock.vacuum.s5e | Pause possible is false
[2020-3-17 3:59:55 PM] [Aspirateur] INF getDocked | roborock.vacuum.s5e | Robot Docked is true (Status is charging)
[2020-3-17 3:59:55 PM] [Aspirateur] INF getWaterSpeed | roborock.vacuum.s5e | WaterBoxMode is 202 over miIO. Converting to HomeKit
[2020-3-17 3:59:55 PM] [Aspirateur] INF getWaterSpeed | roborock.vacuum.s5e | WaterBoxMode is 202 over miIO "Medium" > HomeKit speed 70%
[2020-3-17 3:59:58 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 3:59:58 PM] [Aspirateur] INF getCleaning | roborock.vacuum.s5e | Cleaning is false
[2020-3-17 3:59:58 PM] [Aspirateur] INF getSpeed | roborock.vacuum.s5e | Fanspeed is 102 over miIO. Converting to HomeKit
[2020-3-17 3:59:58 PM] [Aspirateur] INF getSpeed | roborock.vacuum.s5e | Fanspeed is 102 over miIO "Balanced" > HomeKit speed 60%
[2020-3-17 3:59:58 PM] [Aspirateur] INF getBattery | roborock.vacuum.s5e | Batterylevel is 100%
[2020-3-17 3:59:58 PM] [Aspirateur] INF getCharging | roborock.vacuum.s5e | Charging is true (Status is charging)
[2020-3-17 3:59:58 PM] [Aspirateur] INF getBatteryLow | roborock.vacuum.s5e | Batterylevel is 100%
[2020-3-17 3:59:58 PM] [Aspirateur] INF getPauseState | roborock.vacuum.s5e | Pause possible is false
[2020-3-17 3:59:58 PM] [Aspirateur] INF getDocked | roborock.vacuum.s5e | Robot Docked is true (Status is charging)
[2020-3-17 3:59:58 PM] [Aspirateur] INF getWaterSpeed | roborock.vacuum.s5e | WaterBoxMode is 202 over miIO. Converting to HomeKit
[2020-3-17 3:59:58 PM] [Aspirateur] INF getWaterSpeed | roborock.vacuum.s5e | WaterBoxMode is 202 over miIO "Medium" > HomeKit speed 70%
[2020-3-17 4:00:28 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 4:00:58 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 4:01:28 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 4:01:58 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 4:02:28 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 4:02:58 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 4:03:28 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 4:03:58 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 4:04:28 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 4:04:58 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline
[2020-3-17 4:05:28 PM] [Aspirateur] WAR changedError | roborock.vacuum.s5e | Robot has an ERROR - charger-offline, Charger is offline

Fix

Hi @netRunner0
Do you mean you are not suffering from this issue anymore?
Can we close this issue?

Seems to be OK for me too

Ok! Thank you for confirming!
Closing this issue.
Please, reopen if it happens again.


Add a bit more to the readme

Put an index up (Note that we have to GAE Standard samples at the top level)
Add some info about credentials.

@jabubake @tswast FYI

I'm going to merge as it's a README


Edits to ZIP 244 for changes to V3 encryption

Closed since the changes that will go into ZIP 244 are now being included in separate sections of the ZSA ZIPs (viz 226 and 227).


Issues when using light groups

Hi,
Thanks for another great add-on. I think there is an issue, and after a bit of testing, I think it has to do with using lights that are "light groups".
As an example, I have in light.yaml
- platform: group
  name: Kitchen Spots
  entities:
    - light.kitchen_spot_1
    - light.kitchen_spot_2
    - light.kitchen_spot_3
    - light.kitchen_spot_4
    - light.kitchen_spot_5
    - light.kitchen_spot_6

- platform: group
  name: Kitchen Cabinet Lights
  entities:
    - light.kitchen_cabinet_light_1
    - light.kitchen_cabinet_light_2

In group.yaml:
  kitchen_lights:
    name: Kitchen Lights
    entities:
      - light.kitchen_spots
      - light.kitchen_cabinet_lights
  conservatory_lights:
    name: Conservatory Lights
    entities:
      - light.conservatory_couch
      - light.conservatory_reading

And in ui-lovelace.yaml:
          - entity: group.conservatory_lights
            type: custom:folding-group-entity-row
            config:
              type: custom:slider-entity-row
            group_config:
              secondary_info: last-changed
          - entity: group.kitchen_lights
            type: custom:folding-group-entity-row
            config:
              type: custom:slider-entity-row
            group_config:
              secondary_info: last-changed

The one where I'm using light groups gives an error, other work just fine.

Thank you for the detailed description.
Unfortunately, I can't seem to be able to reproduce the problem.
Could you check your home assistant log and your browser dev log and post anything that seems relevant?

Ahem, I think this is what they call an id10t...
I had some old groups with the same names in my group.yaml somewhere in the 1000+ rows. I guess I just haven't used that file since lovelace came along.
Here's me deleting the all contents in group.yaml, and starting from scratch with what I'll use...


rls: fix various bugs in adaptive throttling code

Fix several bugs related to adaptive throttling:

A reversed set of operands to an ?: operation was causing the window size to be set to 0, thus disabling adaptive throttling completely.  I have simplified the default-initialization to avoid those conditional operations completely.
Successes were being reported as failures, thus skewing the data seen by the adaptive throttling algorithm.
The actual adaptive throttling calculation formula was incorrect.  I have changed it to more closely match the internal implementation.
When a request was throttled, we were failing to record a request or a failure.
When a request was not throttled, we were recording the attempt when the request started instead of when it ended.

Fixing these bugs caused one test to be flaky, so I've changed the test to work around the problem.

Derp :)

Looks like fixing this bug is causing some test failures.  Marking this as draft while I sort that out.

This is now ready to be reviewed.


changed edit date

Docs Build status updates of commit feecd05:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/interactable-object.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Updated hibernate with schema export to automatically initialise db

Added dependency to scan for packages
Added beans for entity manager factory, session factory and transaction manager
Added getters to database properties
Simplified lookup of current context
Removed unnecessary application properties
Removed sample data for now
Updated tests
Updated README.md

Hibernate still creates an external sql file but only if it doesn't exist. It isn't necessary to change settings in the application properties. Overall now a much cleaner configuration.


compose/swarm.md constraints should under environment, rather than labels

URL: https://docs.docker.com/compose/swarm.md
There are 2 examples
version: "2"
services:
  foo:
    image: foo
    volumes_from: ["bar"]
    network_mode: "service:baz"
    labels:
      - "constraint:node==node-1"
  bar:
    image: bar
    labels:
      - "constraint:node==node-1"
  baz:
    image: baz
    labels:
      - "constraint:node==node-1"

and
# Schedule containers on a specific node
labels:
  - "constraint:node==node-1"

# Schedule containers on a node that has the 'storage' label set to 'ssd'
labels:
  - "constraint:storage==ssd"

# Schedule containers where the 'redis' image is already pulled
labels:
  - "affinity:image==redis"

I think both of them are wrong, the constraint should under environment. See the following example from https://docs.docker.com/swarm/scheduler/filter/#/example-node-constraints:
$ docker tcp://<manager_ip:manager_port>  run -d -P -e constraint:storage==ssd --name db mysql

The problem tried to be fixed at PR https://github.com/docker/docker.github.io/pull/348 , however, only part of it fixed. And this issue is still open... :(

The problem tried to be fixed at PR https://github.com/docker/docker.github.io/pull/348 , however, only part of it fixed. And this issue is still open... :(

@johndmulhausen this doesn't seem to be an issue anymore on master. Can probably be closed.


Factory class objects instantiation

update the branch so its not behind main, if https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-suggestions-to-update-pull-request-branches is not enabled, then I suggest enabling it, it makes it easier and more visible to update
https://github.com/microsoft/ABAP-SDK-for-Azure/branches

Thanks @larshp for suggestions!


Build science leaderboard chart

Unsure of what exactly would be interesting for this to track. Total science output per month would be a good metric. Graphing overall technical progress is trickier though. Simply summing the researched techs in each group is not be a great indicator of comparative progress and simply favors larger groups, even if they have the same tech level as smaller groups. Comparing tech level may require more data extraction from the save. It may also be possible to take the highest technology victory score from each group and graph that as a representation of the tech level of each group.
Another interesting idea, not necessarily just for this chart, would be to allow users to choose whether to graph totals or to graph averages for each group/federation.

Researched techs for individuals is fine. For group/federations, let's use average researched techs (total researched techs divided by amount of players)?
An even better metric than "researched techs" is total base cost of researched techs (aka research value?) - that wouldn't bias that much towards cheaper techs.


[BugFix] check partition column position when creating iceberg table

Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 5 / 6 (83.33%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/ListPartitionDesc.java
4
5
80.00%
[141]

:large_blue_circle:
com/starrocks/sql/analyzer/CreateTableAnalyzer.java
1
1
100.00%
[]

@Mergifyio backport branch-3.1


Adapt the new Login and Register design.

https://github.com/worona/worona-dashboard-layout/blob/master/sites/login.html
https://github.com/worona/worona-dashboard-layout/blob/master/sites/register.html

Related issue: https://github.com/worona/worona-dashboard/issues/19

@Poliuk They're still missing a place for server errors and server status messages.

@Akronix added:
login error
register error

Status messages added as well:
login status
register status


[WIP] DialogFieldSortedItem - move multiselect behaviour from DropDownList to parent class

So that tagging can use the same code to make sure default_value for single-tag selects is the actual value (or "" for empty), while default_value for multi-tag selects is a JSON array of values ("[]" for empty).
Both DialogFieldDropDownList and DialogFieldTagControl inherit from DialogFieldSortedItem and can be either a single select or multiselect, using json for multiselects.
(A third child is DialogFieldRadioButton but that's hardcoded to return false for multiselects (since we can't have multiradios), so this shouldn't change anything there.)
Depends on https://github.com/ManageIQ/manageiq/pull/19696

@miq-bot add_label bug, automate, wip
WIP because it depends on the previous change, not sure if this works yet
the problem now:
temp1.map((x) => ({label: x.label, values: x.values, default_value: x.default_value}))

0: {label: "Tag Control Single", values: Array(10), default_value: ""}
1: {label: "Tag Control Multi", values: Array(9), default_value: null}
2: {label: "Dropdown", values: Array(4), default_value: ""}
3: {label: "mDropdown", values: Array(3), default_value: "[]"}
4: {label: "nDropdown", values: Array(4), default_value: ""}
5: {label: "nmDropdown", values: Array(3), default_value: "[]"}

https://github.com/ManageIQ/manageiq/pull/19696 + https://github.com/ManageIQ/ui-components/pull/431 seem to work by itself,
This only makes sure the default_value coming from the API is consistent with the rest.


Reflected User Inputs In Error Response

Environment Details

Helidon Version:2.6
Helidon MP
JDK version: 17
OS: Windows/Linux
Docker version (if applicable):

Problem Description
Got a bug from our security team for reflected user input in error response.
Two cases they noted is
Case 1:
Invalid content type passed to the rest api where in user input is retruned back in the response.
Case 2:
Retrun of API path /greet in the error response
Steps to reproduce
curl --location 'http://localhost:8080/greet'
--header 'Content-Type: ${#context["com.opensymphony.xwork2.dispatcher.HttpServletResponse"].addHeader("X-Ack",7702*9478)}.multipart/form-data'
curl --location --globoff 'http://localhost:8080/greet/javascript%3A/%3c/script%3e%3cimg/onerror%3d'''-/%22/-/%20onmouseover%d1/-/[%60/[]/[(new(Image)).src%3d(/%3b/%2b/255t6qeelp23xlr08hn1uvvnkeqae02stgk87yvnX%3b.oastifycom/).replace(/.%3b/g%2c[])]//'''src%3d%3e'

I have verified that the output is HTML encoded, but in the abundance of caution we should look into not reflecting the input at all.


issue#322 Using MulticastIpAddress instead of IPAddress.Broadcast for initializing UdpClient in LPD

The description of a problem is here

Huh, strange. This seemed to work in the past with uTorrent. Good catch!

Thanks for the patch. I'll backport this to 1.0 as well


fix: ignore "return_prompt", revert #2029

refactor: init output channels in the corresponding manager
feat: click the status bar to show the message output channel

close #2046

It looks like the intended change of this PR (ignoring return_prompt) is missing :)
That said, I'd be interested to figure out why this is happening. If you don't plan on rushing this change out in a bugfix release, I would prefer seeing if I can find a way to fix the issue described while still showing relevant output.

I would prefer seeing if I can find a way to fix the issue described while still showing relevant output.

👍

Oh, I forgot to delete that line. I'll move the content unrelated to return_prompt to another PR.


change gradle license check plugin

Proposal to change besu from
id 'com.github.hierynomus.license' version '0.16.1-fix'
to
id 'com.github.jk1.dependency-license-report' version '2.0'
Acceptance Criteria

No regression on the Gradle checkLicenses task - build will still fail if dependencies use unapproved licenses
downloadLicenses task takes no more than 1 minute

Background
This is now used by other consensys open source projects including: Teku, EthSigner, Web3Signer, Signers.
https://github.com/jk1/Gradle-License-Report
example config:
this file matches the format besu already uses:
https://github.com/ConsenSys/teku/blob/master/gradle/check-licenses.gradle
this one may be new:
https://github.com/ConsenSys/teku/blob/master/gradle/license-report-config/allowed-licenses.json

0.16.1 is still latest version of hierynomous https://github.com/hierynomus/license-gradle-plugin/tags
we are using a "fix" version https://github.com/hyperledger/besu/issues/3094

Are there any advantages above a more active maintainer? (honestly, that is already enough to switch).
Are there any features we might lose?  Or would we even notice?
Will the build still fail with dependencies that use unapproved licenses?  That is the main feature we need.

thanks @shemnon - added acceptance criteria to cover that

@macfarla - status or close? I know we had some gradle changes recently

no status change. the only reason to change is we're having to use a custom build of the hieronymous tool. it works but it's a bit messy

closing - it ain't broke. can revisit in the future


Feature request: multi-infrastructure clusters

What kind of request is this (question/bug/enhancement/feature request):
feature request
It would be awesome to be able to create clusters which run on multiple infrastructure providers. This probably does not make much sense on kubernetes providers such as GKE, but with my use-case on bare metal it would. I'd like to combine servers from different infrastructure providers for different purposes (i.e. storage servers from one and CPU servers from another).
Right now, you can only choose from a single infrastructure provider. Instead of only adding node pools from that single provider, I'd like to create clusters independent of any infrastructure provider and then create node pools which are bound to an infrastructure provider instead.
For example:

create cluster "my-cluster"
add node pool "compute" from infra provider "Hetzner"
add node pool "storage" from infra provider "DigitalOcean"

I'm not sure if this comes with any complicated issues such as different networking between providers and so on, but currently I am using this method without rancher and it's working completely fine.

This is all actually already possible with custom nodes or with node drivers through the backend/API.. but is not exposed in the UI because it's not a good experience we can support.
From a recent time someone else asked:

Kubernetes itself is really not meant for that use-case. A cluster is generally a set of machines in the same provider with close proximity (latency) to each other.
Kubernetes itself is really not meant for that use-case.  A cluster is generally a set of machines in the same provider with close proximity (latency) to each other.

Etcd (and therefore API/CLI/UI/scheduling/everything) performance depends heavily on the (worst-case) latency between all members.
Only one cloud-provider integration (storage providers, L4 load balancers) can be configured and most assume nodes are all in the same "region" or similar concept.
Commonly used network plugins assume adjacency and/or provide no encryption or authentication suitable for communicating across untrusted networks/the internet.
Communication between pods/services within the cluster has no consideration for where the "nearest" place to reach a pod for that service is, so latency from a pod to another service can be large (however far apart the two worst nodes are) and unpredictable (sometimes close, sometimes far).  (There is an option for nodePorts to always go to a local pod, but if there is no local pod it will just get dropped).


Install problems on Manjaro (~Arch Linux)

Hi, the install path seems to be wrong for Manjaro (and arch).
-DCMAKE_INSTALL_PREFIX=/tmp/usr/local should be -DCMAKE_INSTALL_PREFIX=/usr/local if I am not mistaken?
Installing to /tmp will remove it at reboot.
Thank you for your help!
Best Regards
Emil

What documentation or code are you referencing?
I probably instructed users to use /tmp/usr/local because the default of /usr/local requires sudo. You should only use that if you intend to install it permanently.

I was trying the (naive) installation outlined in your README for installing the "Serial Communication Library".
Indeed to install in /usr/local this needs sudo, but to install in /tmp/usr/local does not seems quite right as after reboot it will be gone.
The 2 ways I would use this (and these are my personal opinions) are:

Do a true install and place it in /use/local/..., indeed using sudo
Do a project dependency and include. For example to compile my project with a dependency on serial with the code local to the project (for example in catkin)

Would it be possible to add a simple way to choose the install location without modifying the Makefile?
Indeed it is just changing the first line, but still, better if it is officially supported.
What would be your take on this?
Best Regards
Emil

You can setup an install destination env variable which can be set when calling the Makefile to override the install directory using the ?= make syntax, see: http://stackoverflow.com/questions/448910/makefile-variable-assignment I'd take a pr with this change to the Makefile, but I don't have time to do it myself. I'll close this for now.


Sometimes Jenkins fails on the mirror_supervisor rendering test

Describe the Bug
Sometimes, Jenkins fails on the mirror_supervisor rendering test:
FAILURE with mirror_supervisor: The white color of the mirror image in the 3D scene is wrong.
https://cyberbotics2.cyberbotics.com:8443/job/Webots/223/console

Replaced by #742 (for Travis instead of Jenkins)


Add switch test

Improve "real" instrumentation testing

cc: @tonerdo @petli

@tonerdo @petli what do you think about this PR?
I'd like at least another approval, open question is remove or not release asserts.

/azp run

I'll merge this, low risk I need test for next PRs.


psygnal doesn't seem to like functions curried with toolz.curry as callbacks

psygnal version: 0.9.0
Python version: 3.10
Operating System: macOS

Description
Here's an example from the magicgui docs:
from magicgui import magic_factory

def _on_init(widget):
    widget.text.changed.connect(lambda val: print(f"Text changed to: {val}"))

@magic_factory(widget_init=_on_init)
def my_function(text: str):
    ...

my_widget = my_function()

I can simplify it as follows and it still works:
from magicgui import magic_factory

def _on_init(widget):
    widget.text.changed.connect(print)  # remove lambda

@magic_factory(widget_init=_on_init)
def my_function(text: str):
    ...

my_widget = my_function()

I can also write a two-argument function and use a lambda and it still works:
from magicgui import magic_factory, application

def print_with(prefix, value):
    print(' '.join([prefix, value]))

def _on_init(widget):
    widget.text.changed.connect(lambda value: print_with('the string is:', value))

@magic_factory(widget_init=_on_init)
def my_function(text: str):
    ...

my_widget = my_function()

my_widget.show()
application.use_app().run()

But, if I use toolz.curry, it looks like psygnal silently ignores the callback:
import toolz as tz
from magicgui import magic_factory, application

@tz.curry
def print_with(prefix, value):
    print(' '.join([prefix, value]))

def _on_init(widget):
    widget.text.changed.connect(print_with('the string is:'))

@magic_factory(widget_init=_on_init)
def my_function(text: str):
    ...

my_widget = my_function()

my_widget.show()
application.use_app().run()

I can't figure out why, though! Is this expected or surprising? 😂

print_with('the string is:') is getting immediately garbage collected.  it would work if you saved a reference to it:
f = print_with('the string is:')
def _on_init(widget):
    widget.text.changed.connect(f)

I could potentially special case toolz (but I'd prefer not to :joy: ...) at this point, do you have a strong reason for using toolz.curry over functools.partial other than historical?  That is, how often do you actually need to use the "recursive" partialing offered by toolz vs the example you showed here, where partial would have worked equally well?

is getting immediately garbage collected

Ooooh! This explains why in a debugging session in which I saved it to play with it, it worked! 😂
No no, not really interested in special casing, I agree that I am a fringe element 😂  — I guess I'm wondering how important it is that you use weakrefs for these callbacks? If you saved a normal reference it wouldn't get gc'd, right?
Re why toolz... I just find the currying more elegant because you define it at function time and then you don't need to keep typing partial(f, arg) instead of just f(arg) — let alone functools.partial(f, arg).
Also, why would the partial not get gc'd?

I'm wondering how important it is that you use weakrefs for these callbacks

i think that probably depends on the use case.  In the case of a large application like, napari, where there could be a ton of objects lying around, holding strong references to callbacks would be a potential source of large memory leaks ... so a big goal of psygnal is try to limit accidental memory leaks, and ask the user to save a reference explicitly where needed.  That said, pure function objects are held strongly by default (because otherwise using connect as a decorator might kill the function and that would be surprising):
https://github.com/pyapp-kit/psygnal/blob/052779e3eceb4de6e0c3860d9b8222b6ea86a6f4/src/psygnal/_weak_callback.py#L104-L109
currently, that strong_func parameter isn't publicly exposed, but it could be.
partials, however, are not pure functions... they're more complicated, and may wrap methods on heavy objects (e.g. partial(viewer.layer_list.append) or something like that)...

Also, why would the partial not get gc'd?

partials are special cased.  It's a common enough usage pattern, and I considered it too surprising to connect(partial(something, arg)) and have it immediately disappear... so i unwrap the partial and store the function and args/kwargs themself:
https://github.com/pyapp-kit/psygnal/blob/052779e3eceb4de6e0c3860d9b8222b6ea86a6f4/src/psygnal/_weak_callback.py#L99-L102
it really wouldn't be too hard to do this for toolz too, so i'm not totally opposed. (will open PR soon)

Speed! Thank you! 🙏


code bug?

Appreciate your efforts but can't for the life of me seem to get this working.   I'm trying to use this to do image-to-text on an analog utility meter.  The config is all fine but the state does not get updated to the expected value.  I first thought it was an issue on the AWS side with subpar OCR so I attempted to troubleshoot by saving literally typed text into a jpg image and then calling the script to see what the state would get updated to.

For some reason, after running the script the state gets updated to "3".  I've left roi values at default (0, 1) so the entire frame is presumably being analyzed.

I'm not a coder but after looking through your script I would conjecture that something is running amok in the    " # SInce we have text, get the result with the highest confidence"  section of the script.
Any insight would be greatly appreciated!

I suspect it is returning as a list of characters because of the large spaces, but can be be sure without debugging. This logic looks like a suspect for the cause of the issue. I think you can use the service through the amazon web page and check what is returned

Thanks for the quick response.  I took your advice, ran the image through the AWS web page and what seems to be happening is that while AWS has no issues recognizing all 5 digits, the HASS state is only passed the digit with the highest confidence, rather than the string.  Ie instead of treating "69363" as a single string, it recognizes each digit as a separate string and only passes through the "best" one.
You're right, it's probably due to blank space, which unfortunately is representative of what the physical meter readout.  I wish I knew how to code lol...

Well, necessity is the mother of invention :)


[WIP][Release] Verify 1.0.0 release candidate RC1

@github-actions crossbow submit verify-rc-source-*

@github-actions crossbow submit verify-rc-binaries-* verify-rc-wheels-*

@github-actions crossbow submit verify-rc-wheels-windows

verify-rc-source-windows build failure seems related to the build setup rather than the release (it was failing for the previous release as well).

Closing in favor of https://github.com/apache/arrow/pull/7814


Add a keyboard shortcut for merging duplicate notes

Adds a keyboard shortcut to make merging duplicates a little quicker. Thanks for this addon!
Tested locally, OS X works great.

That's a great addition :) Thank you very much for the PR :heart:


Why I can't find selector using within ?

I am trying to test a link, I hope I can solve this issue:
I tried to test the link like this:
nested_element= "div.page_margins div.page iv#nav div.hlist ul li#2"

within(nested_element) do
        response.body.should have_link("Next", :href=>"javascript: void(0)")
end

But I get this error:
Capybara::ElementNotFound: Unable to find css "div.page_margins div.page div#nav div.hlist ul li#2"
Although the same selector is working fine using have_selector:
response.body.should have_selector(nested_element)
Any idea please ?

Looking at the strange-looking "response" method, I'm guessing that you are mixing controller tests (using methods like get or post) with Capybara tests (using visit).
If you need more help, please ask on the mailing list! This issue tracker is meant for reproducible bugs only.


[5.1] Dynamic replacement fixes

Allow dynamic replacement initializers to be non delegating
Sema: Infer @objc for dynamic replacement
SILGen: Fix the logic of dynamic replacements for class constructors
Diagnostic: dynamic replacement and replaced function's @objc attribute must match

rdar://48259565
rdar://48125765

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 8bfefc1f2bba70e370d24b9f84addbee0b769dfe

The linux failure is unrelated and also happens on the current swift-5.1-branch:
https://ci.swift.org/view/swift-5.1-branch/job/oss-swift-5.1-incremental-RA-linux-ubuntu-18_04/91/consoleFull#9135957153122a513-f36a-4c87-8ed7-cbc36a1ec144

linux needs: https://github.com/apple/swift/pull/22887

Please test with following pull request:
https://github.com/apple/swift/pull/22887
@swift-ci Please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - 8bfefc1f2bba70e370d24b9f84addbee0b769dfe

Hmm, I guess the test with PR feature does not work within the same repo.

@swift-ci Please test OS X platform

@swift-ci please Test


New Fields for Projects - Annual Reviews

We'd like a way to track annual reviews for projects in the Landscape.
This should be only for CNCF hosted projects. Right now, only sandbox projects have annual reviews, but we might want this to extend to all projects.
This should depend on the month that they were accepted in the year.
(1) Currently, we have pull requests into the TOC repo for annual reviews. I think that's a fine way to be able to handle this, because we want to make sure that projects are submitting. We should key this off 'PR submitted' and add it to the landscape.
(2) We want a way for the project to mark when they've submitted their annual review - 'YYYY-MM-DD' is fine
(3) Is there a good way to have historical annual reviews without causing metadata collision? We'd like to track since 2020.
(4) Finally, if a project is more than three months past their acceptance month into CNCF, we'd want a way to flag that annual review as being late. (If a project was accepted in January 2022 and we have no data by April 2023, we'd like to highlight that!)
Can we get this in by like.. Feb 27th?

See this PR as an example @amye: https://github.com/cncf/landscape/issues/3037

#3039 should break, it's one example of multiple reviews.

I guess we need two new fields but they can be tossed in the extra category imho
annual_review: annual_review_date:
I don't think we need any engineering work from @AndreyKozlov1984 on this @amye unless we want to make UI changes to say a card if the last annual review date was more than a year old ;)

If it's a sandbox project and it hasn't had an annual review more than three months past acceptance month (so 'accepted' + 3 months), we should flag it.
I'll get the data added and we'll see where that lands!

The only thing that needs to be fixed is in the UI so annual_review_url displays a hyperlink to where things are vs a date
cc: @AndreyKozlov1984

#3040 adds data from the TOC repo

Hi @amye 👋
Is this still relevant for landscape v2? We could display them like we do for the security audits, but was asking because of this: https://github.com/cncf/toc/pull/1181

Hi @amye 👋
Is this still relevant for landscape v2? We could display them like we do for the security audits, but was asking because of this: cncf/toc#1181

Discuss with @jeefy!

Hi @amye 👋
Is this still relevant for landscape v2? We could display them like we do for the security audits, but was asking because of this: cncf/toc#1181

Discuss with @jeefy!

Any thoughts @jeefy? 😉

Will close this one for now given that annual reviews seem to be going away (https://github.com/cncf/toc/pull/1181). Please feel free to reopen if needed 🙂


#48 Fixing synchronize so it's only on transferring the FlowFile

Extracted a couple protected methods for readability too.

Moved to https://github.com/marklogic-community/marklogic-nifi-incubator/pull/2/files


Init definitions module

what
Add a terraform module which will pass well-formed json documents (container definitions).
why
Allow for a way to define container definitions as HCL rather than having to work in json.

Also need to add some more parameters:
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html
Add the following common parameters:

entryPoint
command
workingDirectory
environment
readonlyRootFilesystem

Also, add a link to the docs page above in the README.md for a list of all parameters.

@aknysh

but we don't have all the available attributes from here

I think it's okay. These are probably the most common ones. The community can contribute more as necessary =)


MQTT username password support?

Hello,
does this project support MQTT's username and password system?

yes, should work by putting it in the url: mqtt://user:pass@host:port


SubRouter Angular SPA

hello, I'm trying to start using microfrontends with Angular SPA, for this I download the repository "Coexisting Angula MicroFrontends", I have added a new component to the app1 project and I want to route it from the navbar but it has not succeeded in getting the component to load correctly, I have tried adding the route as a child: const routes: Routes = [
{
path: "**",
component: EmptyRouteComponent,
children: [{ path: "data1", component: Pruebadata1Component }],
},
];  and as a parent route: const routes: Routes = [
{
path: "**",
component: EmptyRouteComponent,
children: [],
},
{ path: "data1", component: Pruebadata1Component }
]; but it doesn't work, which I'm doing wrong

The coexisting-angular-microfrontends repo is the older example. https://github.com/angular-microfrontends is the newer one. Here's some documentation that talks about routing: https://single-spa.js.org/docs/ecosystem-angular#configure-routes


Fix tests and ORES typo

Follow-up for https://github.com/wikimedia/change-propagation/pull/78 - I didn't notice a typo there.
Also, after the date formatting code was improved, tests that involve date formatting need adjustment.
cc @wikimedia/services @Ladsgroup

Also, I'm skipping 'image updates' test - that feature is not enabled yet and the test is not stable.

Changes Unknown when pulling 7881902c2b3781a333f42231a1ef97d230ccbfb5 on Pchelolo:ores_test into ** on wikimedia:master**.


[Enhancement] Rebuild persistent index if load previous index failed

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes https://github.com/StarRocks/starrocks/issues/8141 https://github.com/StarRocks/starrocks/issues/10246
Problem Summary(Required) ：

We will try to build a persistent index according to the index file.  If some error occurs during the loading index, we will return fail directly. But we can rebuild the persistent index according to tablet data. So we will try to rebuild the persistent index when some error occurs.
In addition, we will support varlen key for the PrimaryKey table with a persistent index from version 2.4. However, if we create a PrimaryKey table with a persistent index whose key length is less than 64 Bytes in version 2.4, we can't rollback to version 2.3 directly because the meta structure is changed in version 2.4.
This pr also supports rollback from version 2.4 to version 2.3 for PrimaryKey table with a persistent index.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

@decster PTAL

@mergify backport branch-2.3


GPG signatures

Hi,
1st: Holgers signing key isn't importable because of 2 missing chars in his pubkey.
I opened an issue 4 days ago in the dash-binary repo.
2nd: my gpg tells me that the dash-<IP_ADDRESS>-win64.zip signature is not valid.

Where did you retrieve the key from?

https://raw.githubusercontent.com/dashpay/dash-binaries/master/pgp/holger-darkcoin-qa.asc works fine for me, no issues with signatures either.

Oh, sorry. I retrieved the key first from the webpage and the formating was screwed up. Now from the keyservers.
The second thing wasn't a problem with the signature. I was verifying the signature first with an gui application. Today I verifyed it with gpg2 itself. It was fine.
Sorry for the false alert.

Good stuff, thanks for reporting anyway :)


Having issue how to add app tracking transparency to my app

Hello Team,
Kindly need your support on how can add app_tracking_transparency to my app.
As i'm using flutter for my project. everything is working normally but having difficulty with this one.
Can you please guide me on how to implement this in my app?
Attached my main.dart code below:
`import 'dart:io' show HttpClient;
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:pedantic/pedantic.dart';
import 'package:provider/provider.dart';
import 'package:responsive_builder/responsive_builder.dart';
import 'app.dart';
import 'common/config.dart';
import 'common/constants.dart';
import 'common/firebase_services.dart';
import 'common/tools.dart';
import 'env.dart';
// import 'frameworks/vendor_admin/vendor_admin_app.dart';
Future main() async {
WidgetsFlutterBinding.ensureInitialized();
Configurations().setConfigurationValues(environment);
GestureBinding.instance.resamplingEnabled = true;
Provider.debugCheckInvalidValueType = null;
printLog('[main] ============== main.dart START ==============');
if (!kIsWeb) {
/// enable network traffic logging
HttpClient.enableTimelineLogging = true;
unawaited(SystemChrome.setPreferredOrientations(
    [DeviceOrientation.portraitUp, DeviceOrientation.portraitDown]));
SystemChrome.setSystemUIOverlayStyle(
  SystemUiOverlayStyle.dark.copyWith(statusBarColor: Colors.transparent),
);

}
// Initialize Firebase due to version 0.5.0+ requires to
if (!isWindow) {
await GmsTools().checkGmsAvailability();
await FirebaseServices().init();
if (FirebaseServices().isAvailable) {
  // await Configurations().loadRemoteConfig();
  printLog('[main] Initialize Firebase successfully');
}

}
// if (serverConfig['type'] == 'vendorAdmin') {
//   return runApp(const VendorAdminApp());
// }
ResponsiveSizingConfig.instance.setCustomBreakpoints(
const ScreenBreakpoints(desktop: 900, tablet: 600, watch: 100));
runApp(App());
}
`
Appreciate your kind support.

There are many ways to use this package. You can show dialog after app launch, after onboarding finished, or before first ad load. You can also show an explainer dialog before system dialog. Check README and example for integrating this package.
Also, I see you are using if (!kIsWeb), therefore you are targeting both web and iOS. So you need to wrap this package's method calls with !kIsWeb like:
if (!kIsWeb) {
  await AppTrackingTransparency.requestTrackingAuthorization();
}

That's it. I don't know which problem you are getting. Can you explain in more detail the difficulties you are having?


iOS Bug -  Display swaps to dark mode when refocusing the app while the bottom sheet is visible.

Hello!
This issue has been driving me nuts. The app always changes the theme of the page displayed behind the bottom sheet after backgrounding the app and refocusing on it. Anybody else encountered this issue? I know its an edge case, but I would really appreciate any sort of help.
Environment: .NET 8.0.1
The issue does not show anywhere else when backgrounding the app.
Update:
-this issue is present on the iPhone14 (iOS 17.1.2). However, I could not reproduce it on the iPhone 12 mini (iOS 16.6.1)
-this issue happens "in reverse as well"(meaning when the dark mode is enabled-> the background page changes colour to light mode)
https://github.com/the49ltd/The49.Maui.BottomSheet/assets/124882519/c3325988-8522-4d10-b677-7faec6522781

I too am experiencing this issue, or rather the inverse.
My phone is set to dark theme and after leaving my app and opening it up again, the app switches to light theme. So I assume the bug must either change the theme to whatever isn't the devices default or otherwise toggle it from what it was at launch.
In my case it's quite detrimental as my bottom sheet is permanent (very similar to the bottom sheet on the iOS native Maps app).
I've not been using MAUI for long so I'm unsure how obvious this is, but I have a native apple maps window in my app behind the bottom sheet and that remains dark theme and only changes if I come out of dark mode at an OS level. Therefore, it is only the MAUI UI elements theme that is affected.
I haven't finished pursuing this work around, but I have started looking at the possibility of subscribing to the Resumed event, and correcting the theme at that moment, if my event listening solution somehow fires the correction before the theme is incorrectly set, I plan to spam the correction for about a second to ensure the correct theme is applied.
As I say, I've not finished pulling this thread, but thought I'd mention it in case it helps others pursue a work around.

Same experience here.
After a fast research, can it be related to this line (side effect): https://github.com/the49ltd/The49.Maui.BottomSheet/blob/e3401df656e40f38ec510fabf1cccb3d15098825/src/Platforms/iOS/BottomSheetViewController.cs#L78C48-L78C64

Same experience here.
After a fast research, can it be related to this line (side effect): https://github.com/the49ltd/The49.Maui.BottomSheet/blob/e3401df656e40f38ec510fabf1cccb3d15098825/src/Platforms/iOS/BottomSheetViewController.cs#L78C48-L78C64

After some test with the sample app, it seems not related to this plugin code.
One way to circumvent this problem is to force App to Light theme (while not reacting to any theme change...), using the following line:
Application.Current.UserAppTheme = AppTheme.Light;
Forcing to dark theme doesn't avoid the bug.

Hi MarcAlx, thanks for trying, unfortunately for the release version I am working on, its a requirement to follow the OS theme.   I'm sad to say, but I will probably have to look somewhere else for the bottom sheet control.

This might be related to this issue in MAUI : https://github.com/dotnet/maui/issues/15962

Hi MarcAlx, thanks for trying, unfortunately for the release version I am working on, its a requirement to follow the OS theme. I'm sad to say, but I will probably have to look somewhere else for the bottom sheet control.

Potential workaround I've not investigated:
Could you force light theme, but amend the colours used in your light theme to be dark theme colours if the OS theme is dark theme? Basically fake dark theme in your light theme.

Hi MarcAlx, thanks for trying, unfortunately for the release version I am working on, its a requirement to follow the OS theme. I'm sad to say, but I will probably have to look somewhere else for the bottom sheet control.

Potential workaround I've not investigated:
Could you force light theme, but amend the colours used in your light theme to be dark theme colours if the OS theme is dark theme? Basically fake dark theme in your light theme.

It may work, but you don't react to OS theme change this way.

Hi MarcAlx, thanks for trying, unfortunately for the release version I am working on, its a requirement to follow the OS theme. I'm sad to say, but I will probably have to look somewhere else for the bottom sheet control.

Potential workaround I've not investigated:
Could you force light theme, but amend the colours used in your light theme to be dark theme colours if the OS theme is dark theme? Basically fake dark theme in your light theme.

It may work, but you don't react to OS theme change this way.

You can subscribe to an OS theme change event, in which case you could amend the colour scheme back to the light theme scheme.
But we're going very far down a very deep rabbit hole for what is simply a work around.

Hi MarcAlx, thanks for trying, unfortunately for the release version I am working on, its a requirement to follow the OS theme. I'm sad to say, but I will probably have to look somewhere else for the bottom sheet control.

Potential workaround I've not investigated:
Could you force light theme, but amend the colours used in your light theme to be dark theme colours if the OS theme is dark theme? Basically fake dark theme in your light theme.

It may work, but you don't react to OS theme change this way.

You can subscribe to an OS theme change event, in which case you could amend the colour scheme back to the light theme scheme.
But we're going very far down a very deep rabbit hole for what is simply a work around.

Yes very deep ^^,
For further readers, this way you have to override (on theme change) all your style Light to use another color.
To my knowledge you can't just apply a whole new theme asis. MAUI only handle "Light" "Dark".

The following workaround works for me:
When changing the UserAppTheme, also store the value in preferences
[RelayCommand]
private void SetUserAppTheme(AppTheme theme)
{
    Preferences.Default.Set("usertheme",  (int)theme);
    Application.Current.UserAppTheme = theme;
}

Then, load you UserAppSettings on Resume and Start in App.xaml.cs by loading the value from Preferences:
    private AppTheme GetTheme()
        {
            try
            {
                int value = Preferences.Default.Get("usertheme",  (int)AppTheme.Unspecified);
                return (AppTheme)value;
            }
            catch
            {
                return AppTheme.Unspecified;
            }
        }
    protected override void OnStart()
    {
        Application.Current.UserAppTheme = GetTheme();
    }

    protected override void OnResume()
    {
        Application.Current.UserAppTheme = GetTheme();
    }

@borrmann your workaround is only partial to me.
Mainly because you have to set explicitly UserAppTheme and not let the app react to system wide theme change.
After some tests here's what I found, when going in background (at least on iOS), MAUI fires two Application.Current.RequestedThemeChanged one for the opposite of the current system theme (why?) and one for the current system theme. It's a strange behavior but everything goes back to normal.
But if a BottomSheet is open these events behave differently, causing the app to turn dark on resume
To reproduce, add a simple event handler:
Application.Current.RequestedThemeChanged += (sender, args) => {
    //check theme here
};

I would like to open an MAUI issue but I need more context on why BottomSheet (or the underlaying class it uses) may change this behavior.

@MarcAlx when setting UserAppTheme to unspecified the app reacts to system changes. I have dark, light and system as optional settings in my app and by using the workaround, all three of them work.

@borrmann thanks for your reply.
Unfortunately in my case setting, letting or re-applying (on resume) App.Current.UserAppTheme to AppTheme.Unspecified;` doesn't fix the theme bug.
Observed on iOS Simulator 17.4 and real device iOS 17.4.1.
PS My app only reacts to system wide theme App.Current.RequestedTheme, there's no in-app setting that let user change the App.Current.UserAppTheme.

@MarcAlx Interesting. I guess in my app this works, because I always set a background color and never use iOS defaults. It also requires to not use any transparent backgrounds in the deepest layer of any page, so iOS' background does not shine through. It can be a bit tricky with status and navbar, but when those are also handled by the app then it should work.
So if you set the background on each ContentPage with something like this,
{AppThemeBinding Light={StaticResource LightBackground}, Dark={StaticResource DarkBackground}}
AND use the workaround above AND ensure that the colours of the StatusBar and Navbar are also bound to the AppThemeBinding, then it should work.
This is definitely quite annoying, but because the state of RequestedTheme seems broken, it seems like the only option, unless someone comes up with a bug fix to ensure RequestedTheme is always correct.

@borrmann this remains a mystery to me.
In my app there's no "unspecified background" everything is bound to a toolkit:AppThemeResource where toolkit is xmlns:toolkit="http://schemas.microsoft.com/dotnet/2022/maui/toolkit" so that it's always theme aware.
Thanks for your help, I'll keep this in mind and come back if I found something useful.

@MarcAlx
You are right, altough it fixed the issue for me in a lot more cases, it doesn't cover all.
I did some more digging and it seems like the issues goes down to xamarin ios, so it's not evem a bug in MAUI.
see here
The workarounds there seem quite dangerous to me or at least I don't really know what they are doing.
A bit simpler, would be something like the following.
This code could be called anywhere in the application (e.g. during navigation or so), to ensure the theme changes also while the app is open:
#if IOS
if (UIKit.UIDevice.CurrentDevice.CheckSystemVersion(13, 0))
{
    var scene = UIKit.UIApplication.SharedApplication.ConnectedScenes.ToArray().FirstOrDefault();
    if (scene != null)
    {
        var windowScene = (UIKit.UIWindowScene)scene;
        var userInterfaceStyle = windowScene.TraitCollection.UserInterfaceStyle;

        App.Current.UserAppTheme = userInterfaceStyle == UIUserInterfaceStyle.Dark ? AppTheme.Dark : AppTheme.Light;
    }
}
#endif

Or add this to AppDelegate.cs in case you are fine with updating the theme only when the app is activated
public override void OnActivated(UIKit.UIApplication application)
{
    base.OnActivated(application);
    // add snippet here
}

I first tried with OnResume/OnStart in App.cs, but then I noticed that they do not always fire, so it is better to do it in AppDelegate......
This code now only covers when one always want to use the system default. When giving the user the option for Dark, Light, System, a mix of my workaround above and this one should do it.

I have created a repo with the entire solution here.
It covers light, dark and system and immediately updates to the correct theme. When a bottom sheet is open, the theme is updated once the bottom sheet is closed, which should not be a problem in most cases. With the provided service, there should also be a way to update the change while the bottom sheet is open.
Here is a video:
https://github.com/the49ltd/The49.Maui.BottomSheet/assets/20472867/1a7cc012-f5e3-4bc3-bfc8-e7275a721479

Unsure if people are still having this issue, but this has stopped happening for me since updating to iOS 18 (using iPhone 12 Pro Max).
I did make some changes binding the bottom sheet background colour to the app theme using Background= "{AppThemeBinding Light=LightYellow, Dark=Black}"
Unsure which change has actually fixed this, but I no longer have the issue.


Kryo Serializer can be enhanced into our system

Currently I skip the Kryo serialization with the default java.io.ByteArrayStream, but ByteArrayStream is of low efficiency according to this blog, we can get better performance if we can use Kryo serialzer.
So I tried to integrate Kryo serializer to our system, but there is an issue of class registration, we need to register JTS.geom.Polygon on Kyro, but I have some problem to find all the classes needed to be register.
TIP: If you want to try to optimize this, uncomment the kryo part in KryoShapeSerializer.java, and add the classes to be register in the static part, and conduct a SQL query.

@gfl94 Could you give me a link to your sample shape file for test?

@gfl94 I think I have resolve this problem by write a customized serializer. Please refer to Commit 6db11d1b51caaa8f62d4d3111a6d1d17c603b6c5.


Fix a typo

Coverage remained the same at 92.09% when pulling 3496ac9b7bd9434c20f6c0b6cae7d483e8b67d28 on mohebifar:patch-1 into e47060cbea11e1b044a20afc884f8dc85f5c8d24 on funkybob:master.

Coverage remained the same at 92.09% when pulling 3496ac9b7bd9434c20f6c0b6cae7d483e8b67d28 on mohebifar:patch-1 into e47060cbea11e1b044a20afc884f8dc85f5c8d24 on funkybob:master.

Coverage remained the same at 92.09% when pulling 3496ac9b7bd9434c20f6c0b6cae7d483e8b67d28 on mohebifar:patch-1 into e47060cbea11e1b044a20afc884f8dc85f5c8d24 on funkybob:master.

Coverage remained the same at 92.09% when pulling 3496ac9b7bd9434c20f6c0b6cae7d483e8b67d28 on mohebifar:patch-1 into e47060cbea11e1b044a20afc884f8dc85f5c8d24 on funkybob:master.


Update _module.alloy.tpl

fix forward_to value (should be array)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'll fix the unit test after merge


Current trunk version fails to compile on Windows

Hi all,
today I tried to compile the latest trunk version and I got the following issues:
Microsoft (R) Program Maintenance Utility Version 11.00.61030.0
Copyright (C) Microsoft Corporation.  All rights reserved.
    cl -DOPENSSL_USE_APPLINK -DDSO_WIN32 -DNDEBUG -DOPENSSL_THREADS -DOPENSSL_NO_STATIC_ENGINE -DOPENSSL_PIC -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m

-DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DAES_ASM -DVPAES_ASM -DBSAES_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -DPOLY1305_ASM -DOPENSSL_API_COMPAT=0x10100000L "-DENGINESDIR="C:\download\openssl-1.
1.0-pre6\openssl-master\bin\lib\engines"" "-DOPENSSLDIR="C:\Program Files\Common Files\SSL"" -W3 -wd4090 -Gs0 -GF -Gy -nologo -DOPENSSL_SYS_WIN32 -DWIN32_LEAN_AND_MEAN -DL_ENDIAN -D_CRT_SECU
RE_NO_DEPRECATE -DUNICODE -D_UNICODE /MD /O2  -rdynamic /Zi /Fdossl_static /I "include" /I "." /I "crypto\include" -c /Focrypto\mem_dbg.obj "crypto\mem_dbg.c"
cl : Command line warning D9002 : ignoring unknown option '-rdynamic'
mem_dbg.c
crypto\mem_dbg.c(20) : fatal error C1083: Cannot open include file: 'execinfo.h': No such file or directory
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\BIN\x86_amd64\cl.EXE"' : return code '0x2'
Stop.

Looks like a problem with the "enable-crypto-mdebug-backtrace" Configure option. I assume you selected that? Looks to be introduced by commit ef8ca6bd54. Ping @levitte.

Ah, yes, crypto-mdebug-backtrace is one of those "don't use unless you know what you're doing"
It isn't implemented for native Windows, so don't use it there.

Hmmmm....hang on. If its a don't use it on Windows thing, shouldn't we disable it there? Or at the very least document that it is unusable.

But I want to use it! I need the memory leaks detection mechanism very urgently!

@mattcaswell, yeah, you're right... In INSTALL, perhaps? Basically only available on systems that have execinfo (uhmmm, gnu based systems, iirc)
@wolftobias, you can still use crypto-mdebug

Yes in INSTALL is the right place - that's where "enable-crypto-mdebug-backtrace" is already documented. Is it possible for Configure to complain if you choose an option that is incompatible with your current platform?

But crypto-mdebug gives me just the info where the malloc was called, I have an issue with memory leaks where I want to use the new stack trace utility to get an idea where the caller comes from. Just to get more infos. I understood that this should be possible in the new version, right?

Only on systems that support it :-(

which systems are supporting that? As far as I can see compiling on linux for win64 was working.

Like I said, GNU base system, or to be precise, it requires gcc and that it's implemented on the target system.
the page on execinfo.h says that it's not implemented on mingw...  your experience tells me that has changed, or they have just implemented a stub on that system (which makes it a no-op).

No that page says that gnulib fixes the problem where the header file is missing on some platforms (including mingw). It goes on to say that the implementation on such platforms is a stub and does nothing.

#1154

Uhmmm, @mattcaswell, I think this part of that page is quite clear about the availability of execinfo.h:

Portability problems fixed by Gnulib:

This header file is missing on some platforms: Mac OS X 10.3, FreeBSD 6.0, NetBSD 5.0, OpenBSD 3.8, Minix 3.1.8, AIX 5.1, HP-UX 11, IRIX 6.5, OSF/1 5.1, Solaris 10, Cygwin, mingw, MSVC 9, Interix 3.5, BeOS.

That's part of the issue here, isn't it?  I didn't word that quite right in my previous comment no this, though.

The key phrase is "Portability problems fixed by Gnulib", i.e. the portability problem fixed is that the header file is missing on mingw. A somewhat convoluted way of saying that with gnulib the header file is present on mingw.
The next section then says "Portability problems not fixed by Gnulib: On platforms where the header file is missing, the Gnulib substitute implementation is just a stub, and does nothing".
So in other words on mingw gnulib fixes the problem of a missing execinfo.h header file, but it fixes it by providing a stub that does nothing. So it will compile but it won't work.

Thanks

So I think this really can be closed now in favour of #1154.


Are all Multi-Head Attention "Masked" really?

On the Figure, there Multi-Head Attentions and Masked Multi-Head Attentions.
Are all Multi-Head Attention "Masked" really?

Multi-head attention uses masks to prevent attention computations over padded positions.
Masked Multi-Head Attention uses masks in two ways:

prevent attention computations over padded positions.
prevent positions from attending to subsequent positions

@kuraga
You can also see clearly how the authors constructed tgt_mask and src_mask here:

@PangLuo , thanks!
But is this statement true?

The difference (in this repository) between
Masked Multi-Head Attention (i.e. the lower block, i.e. the first code line)
and Multi-Head Attention (i.e. the upper block, i.e. the second code line)
is the replacement tgt_mask by src_mask.

Ok, thanks!

no worries. Please note I've updated my reply.


Missing highlighter for unified diff

I also would like to have highlighter for diff, how could I contribute?


The "Todo MVC" and "Markdown Editor" code

Are there code repositories for the "Todo MVC" and "Markdown Editor" examples? They would be nice to study to see how to structure moon.js applications

Check out this folder in the gh-pages branch.


Updating clarity v5 stackblitz templates make them utterly broken

Describe the bug
Updating @cds/core or @clr/angular in the clarity-x-theme-v5 makes the template utterly broken.
Error in /turbo_modules/<EMAIL_ADDRESS>(2:111)
Unexpected token 'export'`

How to reproduce
Steps to reproduce the behavior:

Select on of the Clarity Stackblitz v5 templates from https://stackblitz.com/@clr-team
Update @cds/core or @clr/angular
See error

Expected behavior
The update should succeed.
Versions
Clarity project:

[x] Clarity Core
[x] Clarity Angular/UI

Clarity version:

[ ] v3.x
[ ] v4.x
[x] v5.x

Framework:

[x] Angular
[ ] React
[ ] Vue
[ ] Other:

Framework version:
Angular 11
Device:

Type: PC
OS: Windows 10
Browser: Chrome
Version: 91

We have known about  this for a while. We reached out to the @StackBlitz team for help investigating it because the error messages make it hard to see what is causing it and why it is failing.
This is under investigation so stay subscribed for any updates when they are available.

@bdryanovski or @bbogdanov - any updates on the investigation?

We still have issues with the normal Stackblitz Angular template ...
As a workaround I could offer this for the moment https://stackblitz.com/edit/clarit-angular-node - this is based on the new Strackblitz Node templates - and things here work for the moment.

Unfortunately, we didn't get a response back in a while so we assumed we have to move in another direction.
What @bdryanovski provided is what we will be working with from now on. I believe what we could do is just pin the template to our main clarity template source.

For the time being, we've adopted the Node version of the template.
Please, use it instead.
As we have a viable workaround and fixing the Angular-version templates is not something we can do on our side, I will close this bug.


[fix] use correct address comparison in reward history

Description
Fixed edge-cases in getRewardsFromChain and getRewardsFromSubgraph sometimes causing transfer events to be   parsed wrong and accumulating negative balance.
Checklist:

[x]  Checked the changes locally.
[ ]  Created/updated unit tests.
[ ]  Created/updated README.md.

Also, would be great to have a linter or tool to highlight the similar issues for different projects.
For instance, saw the same problem in the Forta on-chain alerting code :broken_heart:


Cannot launch the viewer using ssh on macos Mojave

I tried to run the following code on a remote ubuntu 18.04 server using ssh and the local machine's OS is MacOS Mojave. Btw. xclock and xeyes running correctly using ssh. The server setup is Python 3.5.6 with anaconda env. Also, the following codes can run correctly on the server. I don't know where the problem is and try to search answers for 'How to do X11 Forwarding on a Mac' but can't help. What to do next?
from dm_control import viewer
from dm_control import suite
env = suite.load(domain_name="humanoid", task_name="stand")
viewer.launch(env)

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/cong/anaconda3/envs/dm_control/lib/python3.5/site-packages/dm_control/viewer/__init__.py", line 42, in launch
    app = application.Application(title=title, width=width, height=height)
  File "/home/cong/anaconda3/envs/dm_control/lib/python3.5/site-packages/dm_control/viewer/application.py", line 191, in __init__
    self._window = gui.RenderWindow(width, height, title)
  File "/home/cong/anaconda3/envs/dm_control/lib/python3.5/site-packages/dm_control/viewer/gui/__init__.py", line 35, in ErrorRenderWindow
    'Cannot create a window because no windowing system could be imported')
ImportError: Cannot create a window because no windowing system could be imported`

The viewer is not going to work over SSH because it uses the GLFW rendering backend, which requires GLX. ssh -X invokes indirect rendering, which generally only supports OpenGL versions up to 1.4. MuJoCo itself needs at least OpenGL 1.5 with the ARB_framebuffer_object extension see here.
If you must run the viewer remotely, your best option might be to run it in a remote desktop session (e.g. VNC).

Thanks a lot!


[python] add option to disable openmp in python package build

Seems that something is wrong with pandas on CI.

@StrikerRUS
it seems there is another problem when creating conda env.
2018-10-25T05:18:01.7842400Z # >>>>>>>>>>>>>>>>>>>>>> ERROR REPORT <<<<<<<<<<<<<<<<<<<<<<
2018-10-25T05:18:01.7842690Z
2018-10-25T05:18:01.7843010Z     Traceback (most recent call last):
2018-10-25T05:18:01.7844350Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/exceptions.py", line 819, in __call__
2018-10-25T05:18:01.7844620Z         return func(*args, **kwargs)
2018-10-25T05:18:01.7845240Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/cli/main.py", line 78, in _main
2018-10-25T05:18:01.7845340Z         exit_code = do_call(args, p)
2018-10-25T05:18:01.7846090Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/cli/conda_argparse.py", line 77, in do_call
2018-10-25T05:18:01.7846220Z         exit_code = getattr(module, func_name)(args, parser)
2018-10-25T05:18:01.7846920Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/cli/main_update.py", line 14, in execute
2018-10-25T05:18:01.7847450Z         install(args, parser, 'update')
2018-10-25T05:18:01.7848140Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/cli/install.py", line 253, in install
2018-10-25T05:18:01.7848240Z         handle_txn(unlink_link_transaction, prefix, args, newenv)
2018-10-25T05:18:01.7848890Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/cli/install.py", line 282, in handle_txn
2018-10-25T05:18:01.7848990Z         unlink_link_transaction.execute()
2018-10-25T05:18:01.7849640Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/core/link.py", line 223, in execute
2018-10-25T05:18:01.7849740Z         self.verify()
2018-10-25T05:18:01.7850300Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/common/io.py", line 46, in decorated
2018-10-25T05:18:01.7850870Z         return f(*args, **kwds)
2018-10-25T05:18:01.7851670Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/core/link.py", line 200, in verify
2018-10-25T05:18:01.7851870Z         self.prepare()
2018-10-25T05:18:01.7852440Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/core/link.py", line 192, in prepare
2018-10-25T05:18:01.7852620Z         stp.remove_specs, stp.update_specs)
2018-10-25T05:18:01.7853210Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/core/link.py", line 282, in _prepare
2018-10-25T05:18:01.7853820Z         mkdir_p(transaction_context['temp_dir'])
2018-10-25T05:18:01.7854430Z       File "/usr/local/miniconda/lib/python3.7/site-packages/conda/gateways/disk/__init__.py", line 60, in mkdir_p
2018-10-25T05:18:01.7854520Z         makedirs(path)
2018-10-25T05:18:01.7854690Z       File "/usr/local/miniconda/lib/python3.7/os.py", line 221, in makedirs
2018-10-25T05:18:01.7854780Z         mkdir(name, mode)
2018-10-25T05:18:01.7855400Z     PermissionError: [Errno 13] Permission denied: '/usr/local/miniconda/.condatmp'

it seems we still need to hack the permission to update conda in azure pipeline.

Yeah, it's seems to be so 😕

I suppose we should wait for conda is being repaired before fixing permission error on Azure, right?

For tracking the issue:
https://github.com/matplotlib/matplotlib/issues/12626
https://github.com/pandas-dev/pandas/issues/23319

@guolinke These changes produces the following warnings on Linux:
Preparing transaction: ...working... done
2018-10-27T17:39:22.8353794Z Verifying transaction: ...working... done
2018-10-27T17:40:03.9381033Z Executing transaction: ...working... done
2018-10-27T17:40:05.2978123Z -- The C compiler identification is GNU 4.8.4
2018-10-27T17:40:05.3582289Z -- The CXX compiler identification is GNU 4.8.4
2018-10-27T17:40:05.3657789Z -- Check for working C compiler: /usr/bin/cc
2018-10-27T17:40:05.4134767Z -- Check for working C compiler: /usr/bin/cc -- works
2018-10-27T17:40:05.4144464Z -- Detecting C compiler ABI info
2018-10-27T17:40:05.4597333Z -- Detecting C compiler ABI info - done
2018-10-27T17:40:05.4700003Z -- Detecting C compile features
2018-10-27T17:40:05.6144307Z -- Detecting C compile features - done
2018-10-27T17:40:05.6181971Z -- Check for working CXX compiler: /usr/bin/c++
2018-10-27T17:40:05.6706822Z -- Check for working CXX compiler: /usr/bin/c++ -- works
2018-10-27T17:40:05.6714974Z -- Detecting CXX compiler ABI info
2018-10-27T17:40:05.7238842Z -- Detecting CXX compiler ABI info - done
2018-10-27T17:40:05.7341966Z -- Detecting CXX compile features
2018-10-27T17:40:05.9271846Z -- Detecting CXX compile features - done
2018-10-27T17:40:05.9301159Z -- Configuring done
2018-10-27T17:40:05.9451830Z -- Generating done
2018-10-27T17:40:05.9460397Z -- Build files have been written to: /__w/1/s/build
2018-10-27T17:40:05.9801516Z Scanning dependencies of target _lightgbm
2018-10-27T17:40:05.9861955Z [  3%] Building CXX object CMakeFiles/_lightgbm.dir/src/c_api.cpp.o
2018-10-27T17:40:05.9872254Z [  6%] Building CXX object CMakeFiles/_lightgbm.dir/src/lightgbm_R.cpp.o
2018-10-27T17:40:05.9878160Z [  9%] Building CXX object CMakeFiles/_lightgbm.dir/src/application/application.cpp.o
2018-10-27T17:40:05.9895595Z [ 12%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/boosting.cpp.o
2018-10-27T17:40:09.5265389Z [ 15%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/gbdt.cpp.o
2018-10-27T17:40:14.1225901Z [ 18%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/gbdt_model_text.cpp.o
2018-10-27T17:40:14.3467650Z [ 21%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/gbdt_prediction.cpp.o
2018-10-27T17:40:17.2711982Z [ 25%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/prediction_early_stop.cpp.o
2018-10-27T17:40:17.7545651Z [ 28%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/bin.cpp.o
2018-10-27T17:40:18.1033996Z [ 31%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/config.cpp.o
2018-10-27T17:40:18.3841745Z [ 34%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/config_auto.cpp.o
2018-10-27T17:40:22.1788694Z [ 37%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/dataset.cpp.o
2018-10-27T17:40:22.7338363Z [ 40%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/dataset_loader.cpp.o
2018-10-27T17:40:24.8311473Z [ 43%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/file_io.cpp.o
2018-10-27T17:40:26.0711350Z [ 46%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/json11.cpp.o
2018-10-27T17:40:30.6107865Z [ 50%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/metadata.cpp.o
2018-10-27T17:40:30.9345304Z [ 53%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/parser.cpp.o
2018-10-27T17:40:31.6904347Z [ 56%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/tree.cpp.o
2018-10-27T17:40:31.7427764Z [ 59%] Building CXX object CMakeFiles/_lightgbm.dir/src/metric/dcg_calculator.cpp.o
2018-10-27T17:40:36.0986910Z [ 62%] Building CXX object CMakeFiles/_lightgbm.dir/src/metric/metric.cpp.o
2018-10-27T17:40:36.1046021Z [ 65%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/linkers_mpi.cpp.o
2018-10-27T17:40:36.1094865Z [ 68%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/linker_topo.cpp.o
2018-10-27T17:40:36.1384897Z [ 71%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/linkers_socket.cpp.o
2018-10-27T17:40:40.1778763Z [ 75%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/network.cpp.o
2018-10-27T17:40:40.1801234Z [ 78%] Building CXX object CMakeFiles/_lightgbm.dir/src/objective/objective_function.cpp.o
2018-10-27T17:40:40.2225814Z [ 81%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/data_parallel_tree_learner.cpp.o
2018-10-27T17:40:43.5905521Z [ 84%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/feature_parallel_tree_learner.cpp.o
2018-10-27T17:40:44.7825542Z [ 87%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/gpu_tree_learner.cpp.o
2018-10-27T17:40:44.8706029Z [ 90%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/serial_tree_learner.cpp.o
2018-10-27T17:40:46.5719510Z /__w/1/s/src/treelearner/serial_tree_learner.cpp: In member function ‘virtual void LightGBM::SerialTreeLearner::BeforeTrain()’:
2018-10-27T17:40:46.5720017Z /__w/1/s/src/treelearner/serial_tree_learner.cpp:325:19: warning: unused variable ‘loop_size’ [-Wunused-variable]
2018-10-27T17:40:46.5720359Z        data_size_t loop_size = end - begin;
2018-10-27T17:40:46.5720435Z                    ^
2018-10-27T17:40:46.5729308Z /__w/1/s/src/treelearner/serial_tree_learner.cpp: In member function ‘virtual bool LightGBM::SerialTreeLearner::BeforeFindBestSplit(const LightGBM::Tree*, int, int)’:
2018-10-27T17:40:46.5731386Z /__w/1/s/src/treelearner/serial_tree_learner.cpp:400:17: warning: unused variable ‘loop_size’ [-Wunused-variable]
2018-10-27T17:40:46.5731699Z      data_size_t loop_size = end - begin;
2018-10-27T17:40:46.5731773Z                  ^
2018-10-27T17:40:46.6090436Z [ 93%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/tree_learner.cpp.o
2018-10-27T17:40:47.1670595Z [ 96%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/voting_parallel_tree_learner.cpp.o
2018-10-27T17:40:52.3317600Z At global scope:
2018-10-27T17:40:52.3320116Z cc1plus: warning: unrecognized command line option "-Wno-ignored-attributes" [enabled by default]
2018-10-27T17:40:53.3351320Z [100%] Linking CXX shared library ../lib_lightgbm.so
2018-10-27T17:40:53.4654727Z [100%] Built target _lightgbm

and errors on macOS:
Preparing transaction: ...working... done
2018-10-27T17:40:22.6749250Z Verifying transaction: ...working... done
2018-10-27T17:40:26.2637920Z Executing transaction: ...working... done
2018-10-27T17:40:30.6451370Z ls: /usr/local/Cellar/libomp/*/lib: No such file or directory
2018-10-27T17:40:31.7445830Z -- The C compiler identification is AppleClang <IP_ADDRESS>20041
2018-10-27T17:40:31.8447620Z -- The CXX compiler identification is AppleClang <IP_ADDRESS>20041
2018-10-27T17:40:31.8564550Z -- Check for working C compiler: /Applications/Xcode_8.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
2018-10-27T17:40:32.6600530Z -- Check for working C compiler: /Applications/Xcode_8.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
2018-10-27T17:40:32.6609660Z -- Detecting C compiler ABI info
2018-10-27T17:40:32.7983530Z -- Detecting C compiler ABI info - done
2018-10-27T17:40:32.8071810Z -- Detecting C compile features
2018-10-27T17:40:33.2602900Z -- Detecting C compile features - done
2018-10-27T17:40:33.2661980Z -- Check for working CXX compiler: /Applications/Xcode_8.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
2018-10-27T17:40:33.4079100Z -- Check for working CXX compiler: /Applications/Xcode_8.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -- works
2018-10-27T17:40:33.4213540Z -- Detecting CXX compiler ABI info
2018-10-27T17:40:33.5666670Z -- Detecting CXX compiler ABI info - done
2018-10-27T17:40:33.5715510Z -- Detecting CXX compile features
2018-10-27T17:40:34.4295750Z -- Detecting CXX compile features - done
2018-10-27T17:40:34.4405710Z -- Configuring done
2018-10-27T17:40:34.4838220Z -- Generating done
2018-10-27T17:40:34.4913400Z -- Build files have been written to: /Users/vsts/agent/2.140.2/work/1/s/build
2018-10-27T17:40:34.6115170Z Scanning dependencies of target _lightgbm
2018-10-27T17:40:34.6359260Z [  3%] Building CXX object CMakeFiles/_lightgbm.dir/src/c_api.cpp.o
2018-10-27T17:40:34.6367970Z [  6%] Building CXX object CMakeFiles/_lightgbm.dir/src/lightgbm_R.cpp.o
2018-10-27T17:40:34.6472180Z [  9%] Building CXX object CMakeFiles/_lightgbm.dir/src/application/application.cpp.o
2018-10-27T17:40:34.6573730Z [ 12%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/boosting.cpp.o
2018-10-27T17:40:35.2730010Z In file included from /Users/vsts/agent/2.140.2/work/1/s/src/lightgbm_R.cpp:5:
2018-10-27T17:40:35.2830770Z In file included from /Users/vsts/agent/2.140.2/work/1/s/include/LightGBM/utils/text_reader.h:4:
2018-10-27T17:40:35.2932310Z /Users/vsts/agent/2.140.2/work/1/s/include/LightGBM/utils/pipeline_reader.h:34:27: error: implicit instantiation of undefined template 'std::__1::vector<char, std::__1::allocator<char> >'
2018-10-27T17:40:35.3031870Z     auto buffer_process = std::vector<char>(buffer_size);
2018-10-27T17:40:35.3132520Z                           ^
2018-10-27T17:40:35.3233460Z /Applications/Xcode_8.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:200:29: note: template is declared here
2018-10-27T17:40:35.3334120Z class _LIBCPP_TYPE_VIS_ONLY vector;
2018-10-27T17:40:35.3386500Z                             ^
2018-10-27T17:40:35.3390130Z In file included from /Users/vsts/agent/2.140.2/work/1/s/src/lightgbm_R.cpp:5:
2018-10-27T17:40:35.3390220Z In file included from /Users/vsts/agent/2.140.2/work/1/s/include/LightGBM/utils/text_reader.h:4:
2018-10-27T17:40:35.3391300Z /Users/vsts/agent/2.140.2/work/1/s/include/LightGBM/utils/pipeline_reader.h:36:24: error: implicit instantiation of undefined template 'std::__1::vector<char, std::__1::allocator<char> >'
2018-10-27T17:40:35.3391420Z     auto buffer_read = std::vector<char>(buffer_size);
2018-10-27T17:40:35.3391770Z                        ^
2018-10-27T17:40:35.3391880Z /Applications/Xcode_8.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:200:29: note: template is declared here
2018-10-27T17:40:35.3392020Z class _LIBCPP_TYPE_VIS_ONLY vector;
2018-10-27T17:40:35.3392110Z                             ^
2018-10-27T17:40:35.5845230Z 2 errors generated.
2018-10-27T17:40:35.5911020Z make[3]: *** [CMakeFiles/_lightgbm.dir/src/lightgbm_R.cpp.o] Error 1
2018-10-27T17:40:35.5912040Z make[3]: *** Waiting for unfinished jobs....
2018-10-27T17:40:40.8544830Z make[2]: *** [CMakeFiles/_lightgbm.dir/all] Error 2
2018-10-27T17:40:40.8546600Z make[1]: *** [CMakeFiles/_lightgbm.dir/rule] Error 2
2018-10-27T17:40:40.8548710Z make: *** [_lightgbm] Error 2

Full logs: https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=766&view=logs (Regular tasks)

@StrikerRUS can you try my fixes in branch: https://github.com/Microsoft/LightGBM/tree/nomp-err ?

Perfect! Thanks!
Only
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]

left on macOS, but it's unrelated.


[flutter/infra] certain Engine Drone builders are not running

From https://ci.chromium.org/p/flutter/builders, certain prod Engine Drone builders appear to have never been triggered (e.g. buildbucket/luci.flutter.prod/Mac Engine Drone).

This is working as intended. Drone builds are used for sub-builds but in the mac specific case we don't have enough capacity yet. Once we have the capacity we will enable sub-builds.


[DO NOT MERGE] Support moar licenses and make license parsing in METS transformer more flexible

I know, this should have been two PRs...

This needs to be merged and deployed before we can merge this PR


Editorial Comments 11 Jan 24 (CCitC Guidance dated 2 Jan 24)

Use of i.e. versus e.g.

p 13, para 4, 2nd last line replace "attack vectors. I.e. service portal" by "attack vectors, e.g., service portal"
p 14, para 3, 2nd last line replace "attack vectors. I.e. service portal" by "attack vectors, e.g., service portal"
p 27, bullet 2, sub bullet 1, replace "device (i.e. firewall)" by "device (e.g., a firewall)"
p 38, para 3, last line replace "attack vectors. I.e. service portal" by "attack vectors, e.g., service portal"
check all instance of the use of e.g. that it is followed by a comma - search for "e.g. " and replace by "e.g., "

Use of between versus among, et al

p 11, title, replace "Relationships Between the TOE" by "Relationships Among the TOE"
p11, first line replace "relationships between these entities" by "relationships among these entities"
p 23, first para, line 3 replace "environments between government or commercial" by "environments for government and commercial"
p 28, 3rd para, first sentence replace "identical between PPs" by "identical among PPs"; second sentence replace "wording between them" by "wording among them"
p 32, para 6, last line replace "presentation between technology types" by "presentation across technology types"
p 41, Hybrid Cloud, last line replace "balancing between clouds" by "balancing among clouds"

Working Group versus Technical Community

p 28, para 4 replace "CCitC working group" by "CCitC Technical Community"
p 32, para 6 first line replace "CC in the Cloud working group" by "CCitC Technical Community"

p 29, third para, line 1, remove the comma after "MDM PP"
p 29, Class ADV, third line replace "discussion" by "discussions"
p 30, last para, line1 replace "One the assumptions" by "Once the assumptions"
p 31, para 2, line 1 replace "CC in the Cloud" by "CCitC"; lines 1 and 2 replace "validation" by "certification" ("validation" is only used in the US)
p 31, para 7, states "Generally within the PP’s proposed, the Network Device and Application Software PPs are used the
most." - not understood what is meant?  ND PP does not appear in the Appendix.  "are used the most" for what?
p 31, para 8 second last line replace "but this not considered" by "but this is not considered"
Throughout document replace "Security Objectives of the Operating Environment" by "Security Objectives for the Operational Environment" - correct CC term - 10 instances
More to come

All changes implemented.


Rename R directory to r

Lower case is consistent with other directories, and with paths in the docs. (See #1210.)
MacOS Filesystem doesn't actually see R and r as different names, so it might need to be a two step process.

from #1213:

So I think the first R in the path is something we could change, but I think the second R is more conventional. I think this was a useful experiment, but I don't think it needs to go forward. Closing PR and issue.


Reinstallation problem

Hi everyone,
I don't know why, today when i launched "SSHS", i had this error :
2023/01/30 14:37:15 strconv.Atoi: parsing "22\t": invalid syntax
So after some tries, i uninstall sshs application in order to reinstall it with chocolatey and i don't know why, it says me continually that the sshs-windows-386.exe program is using by another process.

Can you help me with thoses issues ?

Hey ! Seems like you have a sshs process running on your computer. Have you tried killing the running process or rebooting your computer before reinstalling?

Yes, i tried to reboot my computer because i don't find the running process :( . And it seems the "NuGetScratch" folder only appear when i try to install sshs :(
It's as if the installer try to launch the sshs-windows-386.exe twice.

Hey @jakublevy 👋  Do you have an idea?

I am not really sure what is happening.
I've tested the package (reinstalling, upgrading) and cannot replicate the error.
 I've deleted all files in the specified locations.
Then there is the installation :

Nothing more :(

You executed "$env:temp\chocolatey", "$env:ChocolateyInstall\lib\sshs" and "$env:ChocolateyInstall\bin\sshs.exe" as commands, but I meant to delete those.
You can delete them in powershell by executing
Remove-Item -Path "$env:temp\chocolatey" -Force -Recurse
Remove-Item -Path "$env:ChocolateyInstall\lib\sshs" -Force -Recurse
Remove-Item -Path "$env:ChocolateyInstall\bin\sshs.exe" -Force

So try again, first execute Get-Process -Name 'sshs*' | % { Stop-Process $_ -Force } then execute the three commands above and then try choco install sshs

Hello guys,
Thanks for your answers and i don't know why, i tried the installation this morning and that worked.... I haven't tried the last answer of @jakublevy. Now sshs is reinstalled but now i've this error on launching :

Any ideas ?
Again, thanks for all :)

@Regdan Hey! You have a tab space after your port argument in your ssh config


Request to add link to Pgx repository in README

Hello,
I hope this message finds you well. I am reaching out to kindly request the addition of a link to my project, Pgx, in the README file of the Mctx repository.
Pgx is a collection of vectorized board game environments written in JAX, featuring over 20 games including backgammon, chess, shogi, and Go. The repository also includes an AlphaZero example by Mctx, showcasing reasonable learning in Go 9x9 and other medium-sized games.
I believe this link would be a valuable addition for Mctx users, providing them with easy access to a collection of JAX-native game environments as testbed.
Thank you for considering my request. I look forward to your positive response.
Best,

Pgx is very nice! Thanks for sharing.
I will add the link.
BTW, when using rescale_values=False, you may get better results with value_scale=1.0. That will match the usage from the Gumbel MuZero paper.


move if for categories and tags

So if no categories and/or no tags even the title don't appear in the sidebar

I'm afraid but when multi categories or tags exist, this change doesn't seem to work well.
I wonder how you've checked about this change.

I'm afraid but when multi categories or tags exist, this change doesn't seem to work well.

I confirmed my concern is correct.
So I can't accept this patch.


AWS Billing and automation review

Describe the issue
A better understanding around billing is needed, and Jon would like to review this process - especially around current and possible future automations
Additional context
Cumulative billing, billing history, Qualified Receiver verifications processes and automations for AWS are of particular interest here
Definition of done

Review current billing structure of AWS with PO and SM
Jon would like to review and understand where the automation(s) are, and better understand the whole process
Jon to discuss, compare and contrast billing in Azure with current AWS process
Review current state but also what is to be improved or should likely be improved

not relevant


[dev] Time out 522 errors

🐛 Bug report
wrangler dev only return 522 errors. Seems something is down on Cloudflare's network?
I've updated Wrangler to the latest version 1.19.3.
I've authenticated with wrangler login again.
I've created a new wrangler.toml using wrangler init.
name = "player-html"
type = "webpack"
route = '.../*'
zone_id = '...'
usage_model = ''
compatibility_flags = []
workers_dev = false
compatibility_date = "2021-09-17"

(I've obfuscated the domain path and zone id)
My worker is running fine when publishing or previewing.
Describe the bug
When starting wrangler dev and trying to access http://<IP_ADDRESS>:8787 only 522 errors are returned.
Reproduce the bug
Start wrangler dev try to access any url at http://<IP_ADDRESS>:8787.

Not sure what's going on...
I've created a new worker with wrangler generate and it works fine.
It sucks I will need to do wrangler generate for all current worker projects and migrate the JS files though.

This seems like something we should fix. Opening this back up and assigning this to myself, and I'ld be happy to have a look (either later this weekend, or early next week). Could you possibly share the a script that fails, or even a sample project? If not, I'll try with a simple script myself and see if I can reproduce this.

The script really didn't matter as the request never reached it.
For some reason now it's working. Without changing anything on my part nor updating wrangler.

Well that's frustrating, and I'm sorry you had to face that experience. I'll close the issue, but I'll keep an eye open for this, and you should feel free to either drop a line here, or file a fresh issue and cc me if it happens to you again. Sorry again!

Thanks for reporting this issue! Wrangler v1 is now deprecated and support is only being provided for critical updates or security concerns. As such, we are closing this issue.
New versions of Wrangler are maintained in the workers-sdk repo. If you are running into a similar issue with wrangler v2, please report it in the workers-sdk repo. For more info about wrangler v1 deprecation, please check out our blog post.


retry failed tests [QA-1437]

This adds the ability to retry failed tests in jest, which uses a test runner called jest-circus. This will be the default test runner in the next version of Jest. See here and here for documentation.
Ran integration tests locally against alpha, which passed after retrying a failed test!

I don't like this for several reasons:

Can mask real unreliability that users could experience.
Increases test suite run time, especially if the number of test cases grows.
Allows new tests may be written to a lower standard of reliability, reducing the effectiveness of the retries.

For #2 in particular, Cromwell is currently feeling this pain and we're actively considering rolling retries (after having made reliability improvements to individual tests).
I want less noise as much as everyone else. At the same time, I've seen the negative consequences of this kind of "just for now" fix too many times.
(Also, FWIW, the run-workflow-on-snapshot test mentioned in https://broadworkbench.atlassian.net/browse/QA-1437 has been a bit less flaky than it used to be.)

@gdlex4015 @ungwudik thoughts?

@breilly2 on the point of reliability, the nightly integration tests have a 43% success rate over the last month

Neat! I didn't know CircleCI had that report!
That pass rate feels accurate to me. Most of the time, the failure is in run-notebook, and most of the time, it's the screenshot showing a 403 response (though there are also some other common ones).
As humans dealing with these, we can recognize those patterns and have confidence that it's the tests that are flaky and not the product. If we automate that work, I'd want to build in that kind of recognition. Otherwise, adding one retry could make us miss degrading product reliability until it drops below 50%. (Yes, that's an extreme case, and users would start complaining before then, but is that really what we want?)

Do we know the root cause of the flakiness? Should that be explored first? For example, if the test is attempting to act on a UI element faster than that element loads, maybe we can add/increase wait time instead.
I see that we are already sleeping and waiting for 'no spinners' in the different places in the test, but I wonder if there's anything else that can be done around there.
That retry feature seems handy though, especially as more tests are added to this project. However, I appreciate Brian's concerns and would +1 Isaac's suggestion of 'retrying only for specific tests' as a compromise, and as a last resort.


Update configuration path for wgnord

Description of changes

wgnord looks for the changes in /var/lib/wgnord which is not available. So changing it to $out

Can you follow the commit message guidelines at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions ?

@rjshrjndrn - Will you rebase this pr, so it fits the contribution guidelines? (:

Done @MikaelFangel

I have the same issue and would love to see this implemented!


Use of absolute tolerances in testing

https://github.com/JuliaAI/Imbalance.jl/blob/1d5da71d28f693f620e08c16cd8b6a0255a3f52e/test/test_utils.jl#L84
An absolute tolerance of 0.01 could be pretty lousy. I wonder if it is more correct to specify a relative tolerance, which is what isapprox does by default. Something like this:
function is_in_between(a::T b::T, c::T; rtol = sqrt(eps(T)) where T<:Real
    dist_ab = sqrt(sum((a .- b) .^ 2))
    dist_ac = sqrt(sum((a .- c) .^ 2))
    dist_total = sqrt(sum((b .- c) .^ 2))
    return isapprox(dist_ab + dist_ac, dist_total; rol)
end

Discussed in the call.


Use kubernetes_sd_configs in conjunction with consul_sd_config

I'm monitoring kubernetes clusters that are getting created dynamically and API servers are registered at consul. My Question is can I use kubernetes_sd_configs and consul_sd_configs together in conjunction

Prometheus configuration file:

- job_name: 'kubernetes-kubelet'
  kubernetes_sd_configs:
  - api_server: http://cluster01
    role: node
    bearer_token: xxxx
  relabel_configs:
  - action: labelmap
    regex: __meta_kubernetes_node_label_(.+)
  - source_labels: [__address__]
    regex: '(.*):10250'
    replacement: '${1}:10255'
    target_label: __address__

In the above configuration I want api_server to be discovered via consul. Is there a way I can discover an api server address via consul_sd_config and use it with kubernetes_sd_configs.

No, service discovery mechanisms can't do cross-references. I'm closing it for now. If you have further questions, please use our user mailing list, which you can also search.


FusedBatchNormV3 split/fuse to/from Cheaper primitive ops with TF-1.15/TF-2.8

Hi,
I am doing Inference with Bert Large & Bert Base models with TF-1.15 and TF-2.8.
Inference with Checkpoints:
For TF-2.8, I observed set of primitive ops are Fused to single node FusedBatchNormV3 whereas in TF-1.15 fusion of primitive ops is not happening(The graph consists of Primitive ops).
Inference with Frozen Graph:
With frozen graph(.pb) the graph itself has FusedBatchNormV3 node. For TF-1.15 the FusedBatchNormV3 is split into set of primitive ops. whereas in TF-2.8 split of ops is not happening (The graph consists of Fused op).
I am trying to find where this fusion/split is happening when it differs TF versions. After going through fusions that happens at grappler phase(remapper.cc) I found the fusion is happening before it reaches grappler phase.
Can someone help me to point out where the fusion/split of FusedBatchNormV3 is being taken place?
Thanks!!

Hello @Alavandar08 ,
I request you, please specify the Use Cases/colab gist or share the link for the mentioned statement.It helps to debug the issue.Thanks!

Hi @tilakrayal
As mentioned above one of the use case is set of primitive ops are Fused into single op FusedBatchNormV3 in Bert Large with TF-2.8
Here I am adding the before and after fusion of FusedBatchNormV3 with checkpoints snapshots for the reference

The file that I referred to in grappler -  https://github.com/tensorflow/tensorflow/blob/r2.8/tensorflow/core/grappler/optimizers/remapper.cc

@Alavandar08 ,
The provided grappler file link is re-directing to github home-page.Can you please provide the correct link or code to reproduce the issue.It helps to debug the issue.Thanks!

In Tensorflow 1.x with the graph mode as default it optimizes the graph computations and the same reason you see mainly primitive ops.
With Tensorflow 2.x with eager execution as default, in order to optimize the overall computation and to reduce the memory footprints fused operations are mainly used.
Apart from the code link which you shared, you can refer this documentation for FusedBatchNormV3.
For other options to optimize graphs you can refer this document.
Here is an other code implementation of NN ops with FusedNormV3.
Hope this detail helps you. Thanks!


Trackpad scrolling through tabs is broken

Might need to somehow respect the trackpad speed and somehow stop "decelleration"?

Could just add a deb-ounce by checking the last scroll time.
Congratulations you have the job to add it!

@pajlada Maybe #2647 fixed this issue? Do you remember if you created this issue for someone else who had this problem?
Since this was created almost 2 years ago lots has changed and can someone confirm this is no longer an issue?

Works fine on Windows as far as I remember. Just tested again now with two-finger gesture on Windows 10 with precision touchpad support, e352d7b31. Might need to verify on Linux/macOS?

Might need to verify on Linux/macOS?

I use my touchpad on daily basis and it works fine on i3 on GNU/Linux,
By the way, it's worth mentioning that after #2647 you can only scroll vertically to "scroll through tabs" - scrolling horizonally used to "scroll through tabs", but it isn't supported anymore after #2647.

on macOS horizontal scrolling (left to right) on a trackpad does not work. vertical scrolling (up and down) works though


Re-enable cg recolor

Fixed the bug, very minor changes. Somehow forgot a try-catch block which sometimes resulted in a nullpointer exception

Can you make this use the PreMapLoad event instead?
I'd prefer if this plugin wasn't readded as is; the way it works is by invalidating the gpu scene cache causing everything to be streamed each frame, which just gives very poor performance, and it isn't clear to users the reason why. Additionally, if you are getting npes from getModel(), it means you are holding onto and calling getModel() on despawned objects, which is just very wrong.

Yeah, that’s why I took it down in the first place instead of just pushing a quick fix. I may be tied up for the next couple of days, and since some users requested that this be uploaded again soon, I decided to re-upload it in a working state with only these minor changes. I’ll make the "bigger" changes in the near future if that's okay with you. If not, that's totally fine 👍

I'm now using the new preMapLoad event and removed all instances of "setting the scene ID on objects". I'm also no longer trying to call getModel() on despawned Objects. The performance should now be improved substantially - thanks again for the new event!

Is this one ready to be reviewed? I've been missing this plugin, hope it'll be available soon :)

Really missing this plugin, eagerly awaiting its return!