Argument Exception: Option not supported. (Parameter 'ssl ca')

Describe the bug
An unhandled exception occurred while processing the request. The application throws an ArgumentException with the message "Option not supported. (Parameter 'ssl ca')" when trying to set the connection string for MySQL with SSL in a FastReport.
To Reproduce
Steps to reproduce the behavior:
Go to the report generation endpoint.
Provide the required parameters to trigger the report generation.
The system attempts to load the MySQL connection string with SSL.
See error
Expected behavior
A clear and concise description of what you expected to happen.
The report should generate successfully using the MySQL connection with SSL enabled.
ArgumentException: Option not supported. (Parameter 'ssl ca')
System.Data.Common.DbConnectionStringBuilder.set_ConnectionString(string value)
MySql.Data.MySqlClient.MySqlConnectionStringBuilder..ctor(string connectionString, bool isAnalyzed)
MySql.Data.MySqlClient.MySqlConnection.set_ConnectionString(string value)
FastReport.Data.DataConnectionBase.GetConnection()
FastReport.Data.DataConnectionBase.FillTableData(DataTable table, string selectCommand, CommandParameterCollection parameters)
FastReport.Data.DataConnectionBase.FillTable(TableDataSource source)
FastReport.Data.TableDataSource.LoadData(ArrayList rows)
FastReport.Data.DataSourceBase.LoadData()
FastReport.Data.DataSourceBase.Init(Relation relation, string filter, SortCollection sort, bool useAllParentRows)
FastReport.Data.DataSourceBase.Init(DataSourceBase parentData, string filter, SortCollection sort, bool useAllParentRows)
FastReport.DataBand.InitDataSource()
FastReport.Engine.ReportEngine.RunDataBand(DataBand dataBand)
FastReport.Engine.ReportEngine.RunBands(BandCollection bands)
FastReport.Engine.ReportEngine.RunReportPage(ReportPage page)
FastReport.Engine.ReportEngine.RunReportPages()
FastReport.Engine.ReportEngine.RunReportPages(ReportPage page)
FastReport.Engine.ReportEngine.RunPhase2(bool append, ReportPage page)
FastReport.Engine.ReportEngine.Run(bool runDialogs, bool append, bool resetDataState, ReportPage page)
FastReport.Engine.ReportEngine.Run(bool runDialogs, bool append, bool resetDataState)
FastReport.Report.Prepare(bool append)
FastReport.Report.Prepare()
matelaslux.Controllers.ReportController.GenerateReport()
lambda_method395(Closure , object , object[] )
Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor+SyncActionResultExecutor.Execute(ActionContext actionContext, IActionResultTypeMapper mapper, ObjectMethodExecutor executor, object controller, object[] arguments)
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeActionMethodAsync()
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAsync()
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync()
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, object state, bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync()
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)
Screenshots

Device (please complete the following information):

OS: Windows 11 Pro
Browser Chrome
Version FastReport.Community.2024.2.0.zip
Version: MariaDB: 11.3.1-MariaDB

Additional context
The error occurs when setting up a MySQL connection string with SSL in a FastReport. The connection string includes the parameter 'ssl ca' which is causing the issue. The certificate file is located at "c:\MyApp\Config\Aiven\ca.pem".

The issue has been resolved, the database provider offers a .pem certificate. I added it to the FastReport Community program and that caused the error; MySQL does not recognize or support Ssl Ca.
The solution is to remove the .pem file from the program.
I believe that FastReport OpenSource has saved many developers from high costs for medium and small applications. I like it a lot.
I hope that one day the free version will be supported.
--- (_)

Hello!
Thank you for the information provided, if you have any further questions you can create a ticket at the following link: https://www.fast-report.com/support.
To get a quicker solution
Best regards,
Bogdan


Add a company partnership events page

The UI should be similar to the below page
https://alumini-nitp.vercel.app/about

yes sir.


File manager - Can't copy with context menu

Why can't i copy with the context menu? I have to select a file and then use the drop down menu Edit / Copy

By "selection", it means selected text in the table.

So i need to use the Edit menu if i want to copy?
Instead of breaking the traditional Copy, Cut and Paste menu i would suggest that don't have this expandable menu here and leave it to these three commands and instead have a seperate menu to copy path and selected text. It make no sense that i can't use the context menu to copy but i can cut and paste? The new menu you could call it File names and this will give the user a hint that this has something to do with the file name and not the actual file.

Clicking on "Copy" will copy it! You can also use default shortcuts for doing so.

Menus like that never work like that so that wasn't obvious that copy should work when it has a submenu.

What do you propose?

Something like this ...

And you could add more copy function to this submenu:
Copy file name, will copy the file name without selecting the text first.
Copy row, will copy all the visible columns (Name | Size | Ownership | Permissions | Last modification time).

I honestly don't like extra lines added in already long context-menu. Besides, Select All would also had to be reworked.
Familiar functionality is implemented in Google Docs:

However, they have better logic but the reason why we didn't do it, is because it's not supported by current context-menu, and the way it works.
I would need to rework it to make sub-menu appear only on hovering on the arrow.

Updated an image.

It was only a suggestion to separate the different functions. It wasn't obvious that Copy still work as copy. As programmer of the theme know how it works so for you it is much easier.

No you are not stupid, you are right - it can be done better!
I will see if I can do it without reworking the menu. If not, I will add this to my todo for later rework.

That was difficult to implement, especially considering that the submenus open on the right, when context-menu triggered too close to the right side on the table.
Give it a try. I hope you will like it. I like it more now for sure. :wink:


Change the EnhancedVolcano plot example to work with INCLUDE data

The notebook for demonstrating how to run a jupyterlab notebook within a terminal window on CAVATICA https://github.com/NIH-NICHD/Elements-of-Style-Workflow-Creation-Maintenance/blob/main/classes/1-using-the-command-line/2-reading-data-and-plotting-in-R.ipynb uses data from Zenodo -- change this to use INCLUDE data publicly available

cc @mattions


DSP Deuterium Fractionation not recognized with Gas Giant recipe

Describe the bug
Having both Deuterium Fractionation and Gas Giant (the one that produces both Hydrogen/Deuterium) recipes enabled for Deuterium production leads to only Gas Giant recipe actually being accounted for, which leads to huge overshoot on the number of Orbital Collectors required and massive excess of Hydrogen.
To Reproduce
Steps to reproduce the behavior:

Add Deuteron Fuel Rod as output item.
Select "Recipes" on Deuterium dropdown menu.
Configure recipes so that only "Deuterium" (from Particle Collider) and "Gas Giant (Deuterium)" are disabled.
See heaps of hydrogen that could've been fractionated and used.

Screenshots

I'm not able to reproduce your issue using the steps provided. Could you provide a URL?
When I follow your steps, I end up with this:
https://factoriolab.github.io/list?p=deuteron-fuel-rod*1&r=deuterium-fractionation*1&s=dsp&v=9

Sure.
https://factoriolab.github.io/list?z=eJwriNQyMVJL8lArcg7UMox3DgESbiZAwikZxA0CEqVaBvFRWoZqaYZa7vGO8ZHxrvGB8R5aLmrFWmAQqgUF7mpllgBaThRr&v=9

I'm not able to reproduce your issue using the steps provided. Could you provide a URL?
When I follow your steps, I end up with this: https://factoriolab.github.io/list?p=deuteron-fuel-rod1&r=deuterium-fractionation1&s=dsp&v=9

You see, in your link there's Deuterium from Particle Collider and Gas Giant (Deuterium) enabled in Deuterium tab, which is the inverse of the step 3.

Ah, I misread 'disabled' as 'enabled'
OK, so the issue here is that the calculator doesn't have any issue with producing a surplus (by default). It doesn't see that as a negative.
To change, this, set a surplus cost in the advanced settings:

Here is your link with surplus set to 1, which makes the surplus go away:
https://factoriolab.github.io/list?z=eJwriNQyMVJL8lArcg7UMox3DgESbiZAwikZxA0CEqVaBvFRWoZqaYZa7vGO8ZHxrvGB8R5aLmrFWmAQqgUF7lDaUK3MEgABARXC&v=9

OK, this makes much more sense now, thanks!


Sometimes the PR description page doesn't open

I've been seeing this sometimes after I click the status bar item. No errors in devtools or the network panel. Reloading vscode fixes it but just clicking the status bar item again doesn't.

@roblourens is this in vscode.dev, github.dev, or desktop?

This was in desktop

Next time you see this can you share any errors in the dev console and the output from GitHub Pull Request?


307 redirect on login after setting JSON API flag

Authboss doesn't map readJSON parameter in defaults.SetCore to CorceRedirectTo200 parameter in defaults.Redirector
The signature of defaults.NewRedirector has to be updated to include the API flag param
https://github.com/volatiletech/authboss/blob/020487826a5df9ed53b5ff2a749432bb8fec7c30/defaults/responder.go#L61

Yeah. It's a sad reality but it would have been a breaking change so we opted not to make it, there are many such issues we'd like to change in v3. You can still use SetDefaults and then convert & set the value yourself in the Redirector, or you can create your own version of SetDefaults and ensure that its set appropriately. Thanks for raising the issue.


Rework webpage

I moved the front page into this repo and also added a simple way to build the docs via Docker.
Please make sure you have a docker daemon running  and execute:
Build with docker
Make sure the daemon is running, then run
$ ./build_docs.sh

Build w/ python directly

install sphinx and all requirements in docs/requirements.txt
run make html in the docs/ folder)

Expected Output
After building, check out the webpage in docs/build/html/index.html.
The RST files can be edited directly on this branch, in docs/source.
Current output should look like this:

I think not fully ready to merge, there are a lot of placeholders we should fill before updating

@zimmerrol might be quicker if you have a look -- could we set it up such that the build page get's pushed to the website repo that currently just hosts the landing page? I think you set up the Github action for that?

@stes Done. I modified the corresponding action such that the page should be pushed to the project's main domain.


result.Paths(json string) does not return paths when used more than one #'s

Hi, amazing work 👍
I have the following json:
{
  "people": [
    {"name": "John", "addresses": [{"zip": 123}]}
  ]
}

When I try to access the name property inside people, result.Paths() returns a slice of strings containing the path like this:
result := gjson.Get(string(json), field)
fmt.Println(result.Paths(string(json)))

people.#.name
[people.0.name]
However when I do the same for the zip inside the addresses array,
people.#.addresses.#.zip
the result.Paths() no longer returns a slice of strings.
Is this a known limitation? If so, is there a workaround for this?

Looks like there is a similar issue: https://github.com/tidwall/gjson/issues/267


alternate fix to #66

This config value just needs a large integer.  By switching to
math.MaxInt32 we allow it to build correctly on 32-bit systems
but keep the config type simpler.

ping @tmm1


Remove #22 as limitation since it's been fixed

Codecov Report

Merging #128 (a7b96e9) into main (65a6510) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   88.99%   88.99%
=======================================
  Files          11       11
  Lines        2108     2108
=======================================
  Hits         1876     1876
  Misses        232      232

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


MSID: 91597 Version: 1 DOI: arXiv.2306.03218

"msas": "Cancer Biology", "Computational and Systems Biology"
"msid": "91597"
"preprintDoi": "10.48550/arXiv.2306.03218"
"Reviewed Preprint posted": "2023-11-30"
"Sent for peer review": "2023-09-11"
"Posted to arXiv": "2023-09-13" (link: "Go to arXiv": "https://arxiv.org/abs/2306.03218v2")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=91597)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/91597/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[ ] Public reviews available on sciety (https://sciety.org/articles/activity/10.48550/arXiv.2306.03218)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/91597/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/91597)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/91597

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/91597

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/91597/v1/91597-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/91597)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

I updated the ticket with the correct preprint link and to fix the preprint DOI (arXiv doesn't register version DOIs).
Also, another article where the equation numbers were missing from the images. I have asked Exeter for an updated package.

algorithm 3 and 4 are not displaying, e.g.:

Issue with manifest.xml file on meca package. Now fixed and will hopefully be resolved on the next reimport

Now appearing. Going to mark as QC OK.


rsync default timeout incorrect

running a routinator conf lists rsync-timeout = 600, but it should be 300 by default.

This apparently was fixed at some point.


add gltf.openGlbFile

This pull request implement #218.
I was able to implement a glb preview by manipulating the offset so that the buffer view references the glb's bin chunk.
context_menu

Implement inspect image in glb !

Oh wow, this got buried in my GitHub notifications overload, but it looks impressive, thank you!  I'll try to get this reviewed soon.
@bghgary if you or a coworker would be willing to take a look, feedback welcome.  Thanks!

@ousttrue This is pretty amazing, thank you.  I do have a concern about one aspect of the new behavior here: "Save As."
When you load a GLB file, it shows the JSON portion of the file in a read-only editor.  But if you click "Save As..." on that read-only editor, it will save the JSON only to a new file.  The new file is likely to have a .GLB extension with JSON-only contents, which is not good, and the new file will be missing all of the mesh, textures, and other binary data from the original GLB file, which means it's invalid regardless of which file extension it uses.
Is there any way to control the behavior of the "Save As" function here?  Or could we somehow avoid opening the text editor at all, and just show the 3D preview window, or show an option to run the GLB to glTF importer on it?  I'll think about all this more too, but if you have any ideas on this I'd be eager to hear.

@emackey  Since GlbProvider supplies json chunk of glb, I added ".json" to path to make it clear that the content is json.
And rename GlbProvider to GlbTextDocumentContentProvider.

Add .json suffix to real source glb path.
The virtual text document uri is glb:_path_to_glb_.json

Being able to view json chunks without importing gltf from glb is useful when looking at the contents of glb.

@bghgary if you or a coworker would be willing to take a look, feedback welcome.

I probably can't review this any time soon, but I will put it on my list :-)

Since there is no recent activity I am going to ask this: Is there any chance of this ever being merged so that we can easily look at .glb files?
Also "open GLB" sounds a bit confusing, maybe it should be called "preview GLB".

While I love the ease of GLB previews here, I'm very concerned about giving users a writable (as opposed to read-only) copy of the raw JSON from within the GLB itself.
Most users don't know or realize that the JSON in a *.glb is subtly different from the JSON in the corresponding *.gltf that one might get from the "Import from GLB..." function.  For example, all of the texture images (PNG, JPG, etc.) are embedded in the binary chunk of the GLB, and the JSON references their bufferViews and byteOffsets and such that are only meaningful for that one instance of the bin chunk, instead of referencing external URIs.  There are other changes too, and the glTF Validator can't make any meaningful evaluation of raw JSON that has been separated from its corresponding GLB bin chunk.
If users really want to examine and possibly edit the JSON document, they should really use the "Import from GLB..." option instead of this, so they receive a valid glTF as an editable file, that the glTF Validator can confirm.  They can then use "Export to GLB..." when done hand-editing, which will will produce a new valid GLB file, unlike what might come from hand-editing the JSON directly in a GLB.
Maybe there could be a read-only GLB 3D preview that doesn't show the JSON, but offered the "Import" button as a way to get the valid JSON?  That preview is really great, but users are going to shoot themselves in the foot if we give them raw GLB contents that haven't been properly imported.

@emackey how about you just combine the two steps you suggest (1. Import, 2. Preview) in a single convenience command. Also when doing so you can just open the resulting. gltf file in the editor without storing it (if that is possible). So the user does not have to deal with deleting that temporary copy or having another file with the same name accidentally overwriten. Then if he DOES decide he wants to save it he can still press Ctrl+S on it.

It's a good thought, but the process of importing writes multiple files to disk. The JSON alone could be an unsaved preview, but it needs to have a relative path to a saved .bin file and relative paths to PNG / JPG / KTX2 texture files that were extracted from the GLB's bin chunk.
There's actually a way to base64-encode all that into the temporary unsaved JSON, but for real-world models the resulting hunk of text is too large for VSCode to offer in its text editor window.  Saving those data files to disk, and referencing them using relative URI paths in the imported JSON, is the only reliable way to import a GLB into an editable window.

Can't you write all or some of the files to tmp maybe?


Simplify getting cache dir to support other POSIX-like systems

Resolves #49.

thumbsup

Looks good to me too.
WRT to the "Ethereum" versus "ethereum" difference, I have seen some warts like that in the build system too, ie.
https://github.com/ethereum/webthree-helpers/blob/develop/cmake/EthExecutableHelper.cmake#L173
We really shouldn't need these, should we?      I repeatedly saw this kind of anti-pattern at EA where development on a codebase had started on Windows, so we had some inconsistencies in filenames in version control, or with property names in build files, etc.     Then we would start supporting Linux, of have a Perforce server running on Linux or whatever, and they would bite us.
I'm just wondering if you guys know the origins of these inconsistencies, and whether or not we can just fix them and remove the warts?
For this cache example, OS X and Windows are both case-insensitive, so searching for "ethereum", same as Windows, should actually work too.

@bobsummerwill I agree it is bad pattern. I'm guessing I wanted to match other application from C++ team.
This naming issue is more about matching OS-specific naming convention. E.g. the executable of AlethZero is named AlethZero on MacOS and alethzero on Linux.
I believe we should select one name and stick to it no matter what OS. I was very close to using "Ethereum" for dir name in this PR, but it is better not to mix functional changes.

Well, what we certainly could do is stick consistently to lowercase for all platforms.
That change of case would not break anything on OS X or Windows, where changing the case on Linux would break things.
Many teams at EA actually had a standard along that line, for ease of portability - "stick to lowercase for directories and filenames".

Anyway - merge away.   We can talk about casing separately.


IE11 fix for regression in 3.1.7

This addresses the issue outlined in #169.
After debugging this for a while, it seems as if you could just use the value from the input instead of the $viewValue. IE doesn't update the $viewValue like the other browsers. Tested in IE11, Chrome and Firefox.
Unfortunately, I am unable to run the tests for this project. Running npm install results in an error relating to a path issue installing zuul. I'll try to use my Mac to run the tests instead of Windows 10.

Thanks! I don't want to invest the time to do automated cross-browser testing with this project. Normally I'd insist on failing tests but I've struggled to test these selection changes in Phantom. So fingers crossed I guess, appreciate the manual testing.

No problem. I'm willing to help with any issues that might arise from my PR or any cross-browser issues.


"Deselect All" doesn't consistently work with virtual scroll

Environment
Chrome (mac), 78.0.3904.87
jQuery 3.3.1
bootstrap 3.4.1
bootstrap-select 1.13.12
angularjs 1.7.8
First of all, thanks for providing and maintaining a great plugin. It provides a lot of nice functionality for us.
Here's an edge case I encountered.
I have a selectpicker with a lot of options (~2000) and virtual scroll enabled. And the options are dynamically updated based on the value of a second selectpicker.
I can reproduce the issue with the following:

Search for and select options that are outside the current view.
Update the options via the second selectpicker, but where the current selections are still valid.
Clicking on the "Deselect All" button does not deselect the options.

If there are any selected options within the current updated view, "Deselect All"  works as expected. If a new option is selected, "Deselect All"  works as expected. If I search for the selected options and bring them into the view,  "Deselect All"  works as expected. It's only when the options are outside the current view, the options are updated and the selectpicker refreshed, that the "Deselect All" step fails.
I can fix the issue with a small change to the "changeAll" method. In the case above, the "previousSelected" count is unexpectantly zero. However, the "prevValue" array is correct and represents the correct selections from step #1 above.
If I change line 2715 from:

if (previousSelected === currentSelected) return;

to

if (prevValue.length === currentSelected) return;

"Deselect All" works as expected.
Looking more closely at the "previousSelected" count, it seems that it's not correct when some of the previously selected options are in the current view and some are not.

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case (you can use our preconfigured Plunker), and report back with your link.

Here you go:
https://plnkr.co/edit/gTcsJyx1oNMDtEnhE17s?p=preview

This appears to have been fixed in v1.13.13.


Stickied fix

Fix typo in stickied field name for PostModel.

👓  @schwers

🐟  !! Thanks for catching this.


Segmentation fault (core dumped)

when I run example code of visualization/pointcloud_detection.py.
I am getting segmentation fault (core dumped) error.
pytorch==1.7.1(pip install wheel from open3d repo)
flash (latest from github repo folder)

Hi @rkakash59, thanks for reporting this. Could you share the full error trace that you are getting?

Hi @ethanwharris
GPU available: True, used: False
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
/media/drive2/ajk7kor/torch_flash/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py:1293: UserWarning: GPU available but not used. Set the gpus flag in your trainer Trainer(gpus=1) or script --gpus=1.
"GPU available but not used. Set the gpus flag in your trainer"
| Name          | Type         | Params
0 | train_metrics | ModuleDict   | 0
1 | val_metrics   | ModuleDict   | 0
2 | model         | PointPillars | 4.8 M
3 | backbone      | SECOND       | 4.2 M
4 | neck          | SECONDFPN    | 598 K
5 | head          | Conv2d       | 7.7 K
4.8 M     Trainable params
0         Non-trainable params
4.8 M     Total params
19.342    Total estimated model params size (MB)
/media/drive2/ajk7kor/torch_flash/lib/python3.6/site-packages/flash/core/model.py:399: LightningDeprecationWarning: The LightningModule.datamodule property is deprecated in v1.3 and will be removed in v1.5. Access the datamodule through using self.trainer.datamodule instead.
if self.datamodule is not None and getattr(self.datamodule, 'data_pipeline', None) is not None:
/media/drive2/ajk7kor/torch_flash/lib/python3.6/site-packages/flash/core/data/data_pipeline.py:52: UserWarning: Attempted to add a state (CollateFn(collate_fn=<class 'flash.pointcloud.detection.open3d_ml.backbones.ObjectDetectBatchCollator'>)) after the data pipeline has already been initialized. This will only have an effect when a new data pipeline is created.
" only have an effect when a new data pipeline is created.", UserWarning
/media/drive2/ajk7kor/torch_flash/lib/python3.6/site-packages/pytorch_lightning/trainer/data_loading.py:323: UserWarning: The number of training samples (1) is smaller than the logging interval Trainer(log_every_n_steps=50). Set a lower value for log_every_n_steps if you want to see logs for the training epoch.
f"The number of training samples ({self.num_training_batches}) is smaller than the logging interval"
Epoch 0: 100%|███████████████████████| 2/2 [00:23<00:00,  7.73s/it, loss=4.96e+03, v_num=12, train_loss_step=4.96e+3, val_loss=2.5e+3]
Segmentation fault (core dumped)

Hi @rkakash59, I couldn't replicate the error, so I guess it's an environment issue. Could you try installing flash with:
pip install 'git+https://github.com/PyTorchLightning/lightning-flash.git#egg=lightning-flash[pointcloud]'

Hmm, @rkakash59 can I ask what operating system you are using? It works for me just installing open3d direct from pip

linux, I can try on windows as well but open3d.ml.torch is not supported in windows.

@rkakash59 Linux should be fine. It could be CUDA related as my machine doesn't have GPUs. Could you install the requirements listed here:
https://github.com/isl-org/Open3D-ML/blob/master/requirements-torch-cuda.txt
Otherwise I think you'll have to open an issue of the Open3d github. Sorry I couldn't be of more help

same issue when trying to run text classification example.
my env: cuda==11.7 and nvidia-driver==515.48.07, torch==1.11.0+cu11 on ubuntu 20.04
other flash examples do not cause this error, nor does using transformers directly


Library does do not allow Stripe SDK to be loaded async

The provider expects window.Stripe to be set in its constructor. This forces the user to load the script synchronously (which is bad practice) before they load their app JS (which is even worse).
Are there plans to rearchitect this library to support this?
I have a server-side rendered app, which does not include the Stripe SDK (since it's not needed on every page) -- on pages that require the SDK, we inject it & assume (perhaps slightly unsafely) that it has loaded by the time the user has entered their payment details.
Even ignoring the safety aspects, this approach is not possible with this library as it will throw an exception if the Stripe SDK is not present at first instantiation.

Initial idea for a fix: https://github.com/stripe/react-stripe-elements/pull/25

@rixth thanks for the report and the PR! What do you think of this solution instead:
We allow you to pass in your own instance of stripe to Elements. That is, if the StripeProvider is not used, we'll go ahead and use the user-supplied stripe instance in Elements.

Or, what if we loaded it for you in Provider?

@rixth Thinking on this a bit more, is there a reason y'all can't do the polling in your own code and only render the StripeProvider tree once window.Stripe is available? None of react-stripe-elements' components are useful until window.Stripe is available. After putting together the example in the custom elements instance PR (#27), it feels like a worse developer experience overall. Perhaps we can improve the error messaging in StripeProvider and in the README and provide a cookbook for dealing async loading. What are your thoughts?

So the main issue I see with this approach is the exactly one that you identified here: https://github.com/stripe/react-stripe-elements/pull/25#issuecomment-314192701
We'd be blocking the display of everything inside the stripe provider until Stripe was available. In the case of passing the elements prop to the components themselves has the added benefit that we would be minimizing the amount of page content that is dependent on Stripe before displaying.

In the solution I'm imagining, you'd only have StripeProvider wrap the tree
that wouldn't make sense to render before Stripe is loaded; for example,
your credit card form. Do you need to render the rest of your credit card
form before Stripe is loaded? Are you building an interface where only the
Stripe-hosted fields are in a loading state?
On Wed, Jul 26, 2017 at 7:03 AM Thomas Rix<EMAIL_ADDRESS>wrote:

So the main issue I see with this approach is the exactly one that you
identified here: #25 (comment)
https://github.com/stripe/react-stripe-elements/pull/25#issuecomment-314192701
We'd be blocking the display of everything inside the stripe provider
until Stripe was available. In the case of passing the elements prop to
the components themselves has the added benefit that we would be minimizing
the amount of page content that is dependent on Stripe before displaying.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/stripe/react-stripe-elements/issues/24#issuecomment-318062707,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWGsFCRY_cTBO9zmHxLJbPBQYtNafbdzks5sR0dJgaJpZM4OTD88
.

--
Sent from Gmail Mobile

Going down to the individual fields is probably a bit much, but limiting to the form, would be fine. So what you're suggesting is essentially what #25 does, only hoisting this behaviour up and out in to the application? Just trying to get clarity before I spend time on this

It seems like I'm essentially going to write a StripeProviderProvider :)

Yes, exactly. Even with the change I made in my PR, you'd need to load
Stripe yourself and provide it to the Elements that need it; right now you
need to load Stripe yourself and provide it to the StripeProvider. I
suppose it's like a ProviderProvider in that sense, except you have the
benefit of using props over context :).
On Wed, Jul 26, 2017 at 8:39 AM Thomas Rix<EMAIL_ADDRESS>wrote:

It seems like I'm essentially going to write a StripeProviderProvider :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/stripe/react-stripe-elements/issues/24#issuecomment-318092767,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWGsFDRVUTf5cy-8QvrTZC8n68rrwawoks5sR13AgaJpZM4OTD88
.

--
Sent from Gmail Mobile

Hey, we've encountered the same problem on our project, as not all our users need stripe loaded. We created this library to asynchronously load scripts. The example on the page is essentially a StripeProviderProvider. This has more or less solved the problem for us. I think it has advantages over the other discussed methods because it is event driven and doesn't use polling. Let me know if you see any issues with this.

Thank you @domlyons. Very cool.


Add governance document and design folder

Signed-off-by: John Schnake<EMAIL_ADDRESS>

Fixed based on feedback. Merging after green tests.


Design spec seems not properly implemented

I've compared the appearance to the material design spec. There are some differences in padding and text sizes.

For the left padding, it's up to you to choose an adapter with no padding. If you need to align floating label, you can use the "ms_alignLabels" boolean attribute.
The thickness of the line may be change with the "ms_thickness" integer attribute.
For the space between floating label and text, I align it with MaterialEditText ...

Thank you for your quick reply.
I played with ms_thickness and i would suggest supporting there "dp". I played with 1 and 2 as thickness but i had not the result which match the spec. Its to thin or to fat. :-)
It would also be nice to have options like the MaterialEditText have for finer configuration of colors and behavior at all. Also the floating label there gets programmatically an alpha value. I am pretty sure you don't have to re-invent the wheel, the code can be adopted partially.

Some of these issues are corrected ! Thanks for this :)


Question: how to check a certificate if ApnsClient.connect is unavailable

Our application is a Push Gateway, we provide Push functionality to our customers, which means we have to use different APNS certificates for different connections, therefore one of the main requirement for our application is to validate arbitrary certificates provided by customers and fail fast if the cert is inappropriate. We've been using Pushy 0.9 for a long time. Our approach to validate the APNS certificates was based on using ApnsClient.connect() method: before accepting the certificate from customer, we try to connect with it first. In case of successful connect, we accept the certificate with the full confidence it is a valid one. Now, in recent versions of Pushy, this ApnsClient.connect API was removed and I wonder if there is a similar way to validate an arbitrary certificate before any notification sending attempts?

Hello!
This sounds more like a request for general support than it does like a bug report or a feature request. We generally ask people to move these kinds of questions to the Pushy mailing list because:

The mailing list has a wider audience, and you're more likely to find somebody who has experience with your particular circumstances on the mailing list.
Posting your question to the mailing list can help other people who are having the same problem.
Because there isn't a bug to fix or a feature to add, we can't reasonably solve your problem by making any kind of engineering change.

I emphasize that we'd be happy to help, but let's move this conversation to a different venue.


cmd/releaseschedule: add dark mode aware svg css

The SVG image used on https://go.dev/s/release is mostly unreadable
if viewed in dark mode (set in OS, browser, or github settings) as
the black text/lines on dark background are too close in color.
It would be possible to set a background color on the svg, but I
think the better answer is CSS in the SVG which is @media aware of
prefers-color-scheme:dark to switch the colors from black to white.
Remove the explicit style on line/path and add css for text/line/path
which is black but in dark mode changes to white.
Updates golang/go#58820
Fixes golang/go#59275

Why did gopherbot not close this PR after cl/479575 was merged?


Rendering three times problem (universal saga)

I use react router and redux saga with react. The data is fetched in the componentWillMount method of the page Components. When the user is not logged in then just the public page is rendered instead of the original destination. This is the problem:
The first render cycle dispatches all required sagas in componentWillMount to get the data. Because on the first render cycle the END destination component is never rendered, so it dispatches only the "fetch current user" saga.
I tried to understand how startup sagas work, but it not works how I wanted. I have now 2. root sagas. The first one is the one with all the takeLatest forks. The second one is a startup root saga for which I wait to complete BEFORE I continue to the first render cycle.
export function* startupSaga(args) {
  // Startup sags
  yield [
    fork(fetchCurrentUser, { payload: {} }, {}, args),
  ];
}

server.js:
        const statupTasks = sagaMiddleware.run(startupSaga, { node: { req, res } });
        store.dispatch(END);

        statupTasks.done.then(() => {

The problem is that statupTasks.done never resolves.

Is this really the right way to solve that?
Why the statupTasks is never resolved?

Thanks!

Same problem. Please help.

Hey, sorry I've somehow missed your issue. Did you overcome the troubles somehow?
Could be the problem of statupTasks not resolving be connected to the problem mentioned here?

This thread got a little bit stale, so I'm closing it. If you need to discuss this further, please just reply back here.


Question: is it possible to automagically graphs all metrics for an host like collection3 ?

Hi,
At the moment we are using collection3 which is terribly slow and exceptionally ugly. The complete opposite of facette ;-) However it does something very well. It lists all metrics for a host in one page. I am unsure if it is the purpose of facette to do that automatically or if we have to manually create each graph or generate JSON file to make that happen (I dunno how yet anyway).
So far we only use facette for specific graph we build (combine different entries) but for all other metrics it will be good to have them graph by default. I tried to think about facette templating but I struggle to see how we can leverage template to make happen what I need.
Any ideas or insights are welcome
PS: I am aware that facette is not PROD ready but still I like it and I fully understand that what I am asking may be impossible or not in the roadmap. I am just after some help to understand the feasibility of the thing (at the moment I am running 81fd3f8db7 in a docker instance).
Again thanks for sharing facette and for your great work!

Maybe this would be possible once #170 is done because we could have one collection per host? Am I right to say that?

Hi @TomGudman
We do understand your pain with collection3, as a matter of fact using it extensively ourselves is the reason why we've created Facette ;)
At the moment it is not possible to achieve what you're asking for, although you're right – collection templates would allow users to mimic collection3's behavior. Collection template implementation is a bit trickier than graph templates, but we're not far from getting it done – please bear with us.
Thank you for your kind words.
P.S.: @vbatoufflet and I are using Facette in production for quite some time now, it helps driving bug fixes and improvements with real feedbacks!

So I am stuck with collection3 then...

I'm afraid so, stay tuned for upcoming updates!

Thanks for your quick answer

I am looking for this feature as well! :smile: I am quite happy with CGP. But I use facette for some custom graphs. Would be great to use facette only :smile:
btw, you're doing a really great job!


Consider setting up Homebrew distribution via a private tap

The installation instructions could be simplified greatly if we use Homebrew for distribution. Per discussions, it would be good to set up a private tap and configure goreleaser to keep it up to date.
We need to ensure that MacOS distribution works without Gatekeeper problems; I don't think that signing/notarizing the binaries should be required for brew installs, but this needs verification.

I think it's time to make it an official formula.
Perhaps even github pages.


[JENKINS-32391] Basic implementation of Perforce P4 plugin support.

This is a basic implementation of support for Perforce Software's "p4 plugin". This uses credentials instead of username and password which are used by the older "perforce plugin".
Compared the to syntax I suggested in JENKINS-32391 I decided to call the DSL command "perforcep4" rather than "perforce". This leaves the possibility of renaming the older "p4" support to "perforce" and this to p4 if that is desired (so that the commands match the plugin names).
Also I decided to implement the "Manual" workspace within a context instead of as one method. This leaves room for further "workspace behaviours" to be implemented ("Spec File", "Static", "Streams", "Template").

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.


Backend: Add isCertificateIssued to applicationHeader

Issue:

https://github.com/bcgov/entity/issues/23532

Description of changes:
This PR needs to merged to fully test https://github.com/bcgov/STRR/pull/183.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

This could've been added to the UI PR that's related to this change. @shaangill025

This could've been added to the UI PR that's related to this change. @shaangill025

@dimak1 I did this so that UI PR can be fully tested before merging.


fix duplicated distributions

Issue
The query cloudfront_distribution_custom_origins_encryption_in_transit_enabled  can return duplicated results for distributions with two or more origins with a bad configuration.
Checklist

[ ] Issue(s) linked

Hi @khushboo9024, sure.
For a scenario with a CloudFront distribution with two or more origins configured using different origin protocol policies, where the values are http-only and match-viewer, the CTE origin_protocol_policy_value will return the same arn but with different origin_protocol_policy values.
This will causes duplicate results, for distributions matching this condition.
As an example, having the distribution ABCDEFGHIJKLM configured with two origins, one using http-only and the other one using match-viewer, the following query will return the distribution twice:
with origin_protocol_policy_value as (
  select
    distinct arn,
    o -> 'CustomOriginConfig' ->> 'OriginProtocolPolicy' as origin_protocol_policy
  from
    aws_cloudfront_distribution,
    jsonb_array_elements(origins) as o
  where
    o -> 'CustomOriginConfig' ->> 'OriginProtocolPolicy' = 'http-only'
    or o -> 'CustomOriginConfig' ->> 'OriginProtocolPolicy' = 'match-viewer'
)
select
  b.arn as resource
from
  aws_cloudfront_distribution as b
  left join origin_protocol_policy_value as o on b.arn = o.arn

+--------------------------------------------------------------+
| resource                                                     |
+--------------------------------------------------------------+
| arn:aws:cloudfront::012345678912:distribution/ABCDEFGHIJKLM  |
| arn:aws:cloudfront::012345678912:distribution/ABCDEFGHIJKLM  |
+--------------------------------------------------------------+

@sbldevnet Thank you for the explanation. 👍


copr: Vectorize instr.

Signed-off-by: Zhu Zihao<EMAIL_ADDRESS>PCP #5751

What have you changed?
Vectorize instr
What is the type of the changes?

Improvement (a change which is an improvement to an existing feature)

How is the PR tested?

Unit test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect tidb-ansible?
No

@sre-bot  /run-integration-copr-test copr-test=pr/100

@iosmanthus @mapleFU @lonng @breeswish PTAL

LGTM
/approve

/approve

/run-unit-test

/merge

@sre-bot /merge

@breeswish please merge it again.

/merge

Sorry for our unstable CI...

/merge

[2019-12-04T13:50:26.913Z] + TIDB_PATH=./bin/tidb-server

[2019-12-04T13:50:26.913Z] + PD_PATH=./bin/pd-server

[2019-12-04T13:50:26.913Z] + UPGRADE_PART=tikv

[2019-12-04T13:50:26.913Z] + NEW_BINARY=./bin/tikv-server

[2019-12-04T13:50:26.913Z] + OLD_BINARY=./bin/tikv-server-old

[2019-12-04T13:50:26.913Z] + GOPATH=/home/jenkins/agent/workspace/tikv_ghpr_integration_compatibility_test/go

[2019-12-04T13:50:26.913Z] + ./test.sh

[2019-12-04T13:50:26.913Z] compatibletest start

[2019-12-04T13:50:26.913Z] /home/jenkins/agent/workspace/tikv_ghpr_integration_compatibility_test/go

[2019-12-04T13:51:48.295Z] time="2019-12-04T21:51:39+08:00" level=warning msg="ping db failed, retry count 0 err Error 9002: TiKV server timeout"

[2019-12-04T13:52:27.012Z] time="2019-12-04T21:52:20+08:00" level=warning msg="ping db failed, retry count 1 err Error 9002: TiKV server timeout"

[2019-12-04T13:53:05.721Z] time="2019-12-04T21:53:01+08:00" level=warning msg="ping db failed, retry count 2 err Error 9002: TiKV server timeout"

[2019-12-04T13:53:44.387Z] time="2019-12-04T21:53:42+08:00" level=warning msg="ping db failed, retry count 3 err Error 9002: TiKV server timeout"

[2019-12-04T13:54:31.014Z] time="2019-12-04T21:54:23+08:00" level=warning msg="ping db failed, retry count 4 err Error 9002: TiKV server timeout"

[2019-12-04T13:55:09.685Z] time="2019-12-04T21:55:04+08:00" level=warning msg="ping db failed, retry count 5 err Error 9002: TiKV server timeout"

[2019-12-04T13:55:48.353Z] time="2019-12-04T21:55:44+08:00" level=warning msg="ping db failed, retry count 6 err Error 9002: TiKV server timeout"

[2019-12-04T13:56:27.022Z] time="2019-12-04T21:56:25+08:00" level=warning msg="ping db failed, retry count 7 err Error 9002: TiKV server timeout"

[2019-12-04T13:57:13.640Z] time="2019-12-04T21:57:06+08:00" level=warning msg="ping db failed, retry count 8 err Error 9002: TiKV server timeout"

[2019-12-04T13:57:52.306Z] time="2019-12-04T21:57:47+08:00" level=warning msg="ping db failed, retry count 9 err Error 9002: TiKV server timeout"

[2019-12-04T13:58:30.969Z] time="2019-12-04T21:58:29+08:00" level=warning msg="ping db failed, retry count 10 err Error 9002: TiKV server timeout"

[2019-12-04T13:59:17.592Z] time="2019-12-04T21:59:10+08:00" level=warning msg="ping db failed, retry count 11 err Error 9002: TiKV server timeout"

[2019-12-04T13:59:56.259Z] time="2019-12-04T21:59:50+08:00" level=warning msg="ping db failed, retry count 12 err Error 9002: TiKV server timeout"

[2019-12-04T14:00:26.535Z] Sending interrupt signal to process

[2019-12-04T14:00:26.535Z] Killing processes

CI failed to connect to TiKV server.

Seems that it's not only test_server_transfer_leader_safe error now , cry

/merge

/run-unit-test

/run-all-tests

/merge

You can spend time on other prs. I has told my friend that there may be some error with test_server_transfer_leader_safe. He will have a look at it tomorrow.

Thanks a lot! @mapleFU

/merge

/run-all-tests

/run-all-tests

/merge


Replace Mesos and Zookeeper fixtures with USI.

Summary:
This unifies our Mesos and Zookeeper test setup across the Jenkins
plugin, Metronome, Marathon and USI.
Blocked by mesosphere/usi#108

Somewhere in LeaderIntegrationTest we spent more than 2 1/5 minutes between lines 274 and 305. This causes the test to timeout. Checkout the log
    158 WARN [10:01:32 BackupRestoreIntegrationTest-LocalMarathon-32906] I1009 10:01:32.257115 15183 sched.cpp:363] No credentials provided. Attempting to register without authentication
    159 WARN [10:01:32 BackupRestoreIntegrationTest-LocalMarathon-32906] I1009 10:01:32.259855 15179 sched.cpp:751] Framework registered with 18ec44db-47b8-44a2-9d3a-8464c9d4a7ce-0000
    160 INFO [10:04:01 BackupRestoreIntegrationTest] SSEStream: Connecting
    161 INFO [10:04:01 BackupRestoreIntegrationTest] SSEStream: Acquiring connection to http://localhost:32906

Marathon with port 32906 is up at 10:01:32 but we did not connect to the SSE stream until 10:04:01.

The time is spent waiting to reconnect. See line 886 in MarathonTest:
scheduler.scheduleOnce(patienceConfig.timeout / 2) { iter() }

Locally I see
WARN [16:25:51 PoolGateway] [2 (WaitingForEndOfResponseEntity)] Ongoing request [GET /v2/events Empty] was dropped because pool is shutting down

And thus no deployment event is received. Any ideas, @timcharper?

I think this is being emitted when the Akka actor system is being shut down.


samples or unit test for components without RTOS

Is your feature request related to a problem? Please describe.
With RTOS, it's hard to debug the program step by step.
Describe the solution you'd like
Provides samples or unit tests compiled as a bare-metal firmware which enrolls components such as Bluetooth, without RTOS.

Let me understand this correctly. You want to use the Zephyr RTOS without the RTOS part?

Sorry, we are an RTOS, we test as an RTOS, in an RTOS.


Adding StackOverflow icon

Fixes Issue

Changes proposed
adding stackoverflow icon

Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Is it ready to merge?

All updated,
is there any issue?

Contributing feels great 😊


Write documentation

Sphinx, docstrings, demos

Go through the ANT specs and write a demo and associated docs for every configuration mentioned.


feature: notation for expected failures

(tests
 (p/run (! (p/for [x ~(m/watch input)] x)))
 % := [1]
 (reset! input [1 2])
 % := [1 2] ;; FAIL
 )

Syntax idea: % := [1 2] :! [1], which indicates desired expectation simultaneously with known current expected error.
Perhaps % :! [1 2] ; [1] is sufficient?

This works in master, obviously could be a lot tighter
(defmethod t/assert-expr :hyperfiddle.rcf/fails? [msg form]
  (let [[_= & args] form
        form        (cons ::fails? (map impl/original-form args))]
    `(let [lhs#           (identity ~(first args)) ; (identity …) guards against :clojure.spec.alpha/invalid being passed to `let` macroexpansion
           rhs#           (identity ~(second args))
           [result# env#] (u/unifier* lhs# rhs#)]
       (if (u/failed? env#)
         (do (do-report {:type     :hyperfiddle.rcf/pass
                         :message  ~msg,
                         :expected '~form
                         :actual   result#})
             result#)
         (do (do-report {:type     :hyperfiddle.rcf/fail
                         :message  ~msg,
                         :expected '~form
                         :actual   (u/explain env#)})
             lhs#)))))


Rename TerraformId and TerraformType

Description
We should rename these methods to something more generic since we may want to support other IaC source soon

We already use ResourceType alias for TerraformType and ResourceId in error handling, so what about ResourceId and ResourceType ?

@sundowndev I was wondering if we can only name them Type() and Id() since they already are func of a struct named Resource and it sounds a little bit redundant IMHO

@eliecharra doing that will create a conflict because method Id will redeclare field of the same name. We'd have to make those fields unexported and create setters for them.

We'd have to make those fields unexported and create setters for them.

This lead us to another discussion : can resources be mutated ?
Actually in a single place in our code me modify the Id to be able to match remote and IaC resources (route53 records or zone I don't remember).
It could be nice to have resources with immutable Id and Type, and for the case I mentioned above, we should create a new resource. But this is not the topic here, we should find a workaround for now.
BTW This will lead us to another refactoring since in some place we use the attribute directly and sometimes getters, we should make this uniform.
Maybe we can open a discussion about it in the next technical point ?
And thus WDYT of Type() and ID() for the current PR @cloudskiff/engineering ?

BTW This will lead us to another refactoring since in some place we use the attribute directly and sometimes getters, we should make this uniform.

I agree with this sentence, it would make the code less confusing.
Like @eliecharra suggested I had in mind methods Type() and Id().
@sundowndev you said that it would require a longer refactoring, maybe we need a little chat to agree on what needs to be done

BTW This will lead us to another refactoring since in some place we use the attribute directly and sometimes getters, we should make this uniform.

I agree with this sentence, it would make the code less confusing.
Like @eliecharra suggested I had in mind methods Type() and Id().
@sundowndev you said that it would require a longer refactoring, maybe we need a little chat to agree on what needs to be done

Alright let's discuss about that and take our time, I put my PR in draft for now


How to delete by query (for instance to delete all)?

Hi -- I'm struggling to see how to implement a delete all query (or some equivalent).
I thought maybe creating and sending a crafted DeleteOperation was the answer but I can't see any way in the code to add a query to the operation struct instance.
Sorry if I'm missing something really obvious -- could anyone advise me on how to achieve a delete by query? Or, failing that, the best way to delete all documents in an index? Oh, but delete_index is too destructive.
Currently I'm thinking that I might just send an HTTP request to the delete by query endpoint. I'll do that if needs be, but I'm hoping there's a better way.
Thanks for any and all help, and thanks also for the brilliant crate!
Doug.

Hello,
The reference version of ElasticSearch that rs-es supports is 2.0, which didn't have an (official) Delete by Query operation (the 1.x implementation was deprecated and the modern replacement hadn't been invented at the time).  Which is why there's no implementation of it.  Although my documentation isn't particularly clear about that, so apologies for that.
The workaround recommended by Elastic for the 2.0 version was to do a scan/scroll operation to find document IDs, then do a bulk delete on those IDs.
In due-course the baseline ES version should be moved up as 2.0 is quite old now, but this is still in the future due to time-constraints elsewhere.
Thanks

Ah, thanks for that @benashford .
I completely understand about time constraints -- maybe one day I'll be proficient enough with Rust to be of use! :)
The only thing I really want the delete all for is for testing so I might still just go with an HTTP call -- whatever looks easiest, I reckon.
And I really appreciate both the response and the package generally -- thanks again!
Doug.


time.sleep takes seconds as int and not as float

if time.sleep takes only int you can only sleep for a whole second and not fraction of a second which can be very useful

also time.timer is the same as time.sleep and therefor should not exist since it repeats an already existing functionality


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.9 to before v5.13.5",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a02b9dc90d844cc7df7b63264e7920cc425052d9",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=19edcd97727aae9362444a859a24d99a8730cb27"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "a02b9dc90d844cc7df7b63264e7920cc425052d9",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "19edcd97727aae9362444a859a24d99a8730cb27",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "dma-buf/sync_file: Don't leak fences on merge failure\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.13.5 by commit 19edcd97727aae9362444a859a24d99a8730cb27, it was introduced in version v4.9 by commit a02b9dc90d844cc7df7b63264e7920cc425052d9. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001152


GDScript _base property not properly assigned. Triggers infinite loop for get_base_script() loops.

Godot version:
custom build stemming from 93b107a (custom code shouldn't be relevant...I don't think). It's my godotengine/godot-proposals#22 experimental branch, but the issue is likely the result of GDScript 2.0 changes since my stuff is mostly targeting other languages. Haven't tested in a regular master branch yet.
OS/device including version:
Windows 10 Home Edition
Issue description:
If I create a script class GDScript and then create another script extending that GDScript, doing so triggers an infinite loop. Tracked it down to EditorNode::get_object_icon() (link) where it attempts to call get_base_script() on a loop variable in order to proceed to the base case of no longer inheriting from any more scripts. When I have MyGDClass as a script class, and I make a derived script called derived.gd (not a script class), the get_base_script() method simply returns the derived.gd script again rather than returning the MyGDClass script class it is inheriting from. So, somewhere along the way, the _base property is not getting assigned correctly.
Steps to reproduce:

Create a GDScript with a script class.
Right-click it in Scene dock and choose "Extend Script"
Attempt to "Create" a script from the CreateDialog.

Infinite loop begins.

Confirmed on latest master 85186bc
seems to happen on any project, just by right clicking a node with a script and doing Extend Script.
For verification purposes, I happened to have the project from issue 44210 open, and I right clicked main and did Extend Script then typed main2.gd and it infinite loops.

This might be the same issue logged here (https://github.com/godotengine/godot/issues/41974), and if so, I believe this is fixed now.

I check on version v4.0.dev.official [https://downloads.tuxfamily.org/godotengine/testing/4.0/4.0-dev.20210727/] and I can reproduce it BUUUUUT!!!!
I compiled editor in current master v4.0.dev.custom_build [d7a39cc34] target=release_debug platform=windows
And I can't reproduce it so it seems fixed 👍
Project to test: https://drive.google.com/file/d/1totK5Yfw83mCkFvBMoiMPd63x5SOvOUO/view?usp=sharing

Closing per @SaracenOne and @JestemStefan's comments.


Rebuild images on the docker hub

I thought the postgis images were rebuilt automatically when official postgres images are pushed but it seems like they're not. This PR was merged, new postgres images were pushed to the hub and it didn't trigger any build.
Would you mind triggering a build manually ? Thanks 🙂

I recently moved the builds from Docker Hub to Docker Cloud since they were previously not building on push (due to a move from md5/docker-postgis to appropriate/docker-postgis back in 2015). I guess I neglected to deal with the "repository link" to the postgres image in the process.
Unfortunately, it look like Docker Cloud doesn't support repository links... I've gone back into the Docker Hub automated builds and re-enabled the repository link. This should mean that pushes to master trigger a build on Docker Cloud's automated build infrastructure and that changes to the postgres image will trigger a build on the (semi-deprecated, barely-supported) Docker Hub infrastructure.
I've also manually kicked off the image builds 😖


Update package version in Authorization dll

There are no changes in this PR - the previously published Authorization package somehow had a Assembly version of <IP_ADDRESS> even though the AssemblyInfo.cs had the correct assembly version. Hence trying to generate a new Nuget package that we can use for our RBAC commandlets.

Hi @namratab, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (nbaliga). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Hi Namrata, I will kick off a package build for you to take a look at


Fixed battery conversion

For battery percentages of 08 and 09 percent, the -le would fail with
an error ("value too great for base"), since the numbers with leading
zeros are treated as octal numbers when using double brackets.
The solution is to force base 10 for the numbers. More details here:
http://stackoverflow.com/a/24777667/1228454

:+1:


Renaming in SingleFileMetastore

As spotted in #900, several names are clumsy in the SingleFileMetastore.

SingleFileMetastore: It is not a single file. It consists in one file per index.
MetadataSet: Very uninformative.

Consensus reached on

SingleFileMetastore -> FileBackedMetastore
MetadataSet -> MetastoreData


Most common values for platform.os.family not showing 'Linux' OS

I guess in reality, Linux is pretty uncommon as we detect the popular distros such as Ubuntu, Fedora, etc. first. Given that Linux is one of the major OS families, I've added it to the documentation.


Incorrect link in website

On the website, the button "Check out Squares" links to the RawJS sample project instead of the Squares home page.

Good call-out. I submitted a PR to the website repo.


Align package version in integration template with changelog

What does this PR do?

Initial version in __about__.py is the same as the initial version in the CHANGELOG.md.
Motivation

Found this while reviewing the nvidia triton PR
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

I don't get why the docs build is broken.

docs build failure is unrelated and fixed in #16031


fix(test): Debugging alert count

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
TODO(replace-me)
Use this space to explain how you validated that your change functions exactly how you expect it.
Feel free to attach JSON snippets, curl commands, screenshots, etc. Apply a simple benchmark: would the information you
provided convince any reviewer or any external reader that you did enough to validate your change.
It is acceptable to assume trust and keep this section light, e.g. as a bullet-point list.
It is acceptable to skip testing in cases when CI is sufficient, or it's a markdown or code comment change only.
It is also acceptable to skip testing for changes that are too taxing to test before merging. In such case you are
responsible for the change after it gets merged which includes reverting, fixing, etc. Make sure you validate the change
ASAP after it gets merged or explain in PR when the validation will be performed.
Explain here why you skipped testing in case you did so.
Have you created automated tests for your change? Explain here which validation activities you did manually and why so.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/test

/test ocp-4-10-qa-e2e-tests ocp-4-10-ebpf-qa-e2e-tests

/test ocp-4-10-qa-e2e-tests

/test ocp-4-10-ebpf-qa-e2e-tests ocp-4-10-qa-e2e-tests

/test ocp-4-10-qa-e2e-tests

/test ocp-4-10-ebpf-qa-e2e-tests

/test ocp-4-10-ebpf-qa-e2e-tests ocp-4-10-qa-e2e-tests

/test ocp-4-13-qa-e2e-tests ocp-4-13-ebpf-qa-e2e-tests

/test ocp-4-13-qa-e2e-tests ocp-4-13-ebpf-qa-e2e-tests


mt

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a8a844d8-1aab-daf1-0567-35f2de89fa23
Version Independent ID: 6d8a875c-8038-5d1d-b0dc-e4c7094844c1
Content: Configure enterprise application properties - Microsoft Entra
Content Source: articles/active-directory/manage-apps/add-application-portal-configure.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @omondiatieno
Microsoft Alias: jomondi

@FGN470
Could you please elaborate the query for better understanding. So, we can assist you further.

@FGN470
Since we have not heard back from you, we will now proceed to close this thread.If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Fails on latest update 0.1.6 ha 2021.12.07

:39 PM – (WARNING) Template - message first occurred at 3:21:39 PM and shows up 3 times
Setup failed for garmin_connect: Unable to import component: No module named 'garminconnect_ha
Setup.py. .01.4 and .0.1.5 work.

@bschatzow Hi thank you for reporting, can you try version 0.1.7?

0.1.7 fixed for me... ;-)

@bschatzow Hi thank you for reporting, can you try version 0.1.7?

Fixed for me as well.


close_waiter is lazily created

Codecov Report

Merging #239 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   96.97%   96.88%   -0.09%
==========================================
  Files          55       55
  Lines        7492     7379     -113
  Branches      625      583      -42
==========================================
- Hits         7265     7149     -116
- Misses        168      170       +2
- Partials       59       60       +1

Impacted Files
Coverage Δ

aioredis/sentinel/pool.py
85.71% <100%> (-4.42%)
:arrow_down:

tests/pool_test.py
98.24% <100%> (ø)
:arrow_up:

aioredis/commands/pubsub.py
95.85% <0%> (-0.36%)
:arrow_down:

aioredis/sentinel/__init__.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c386d...347d32b. Read the comment docs.

Thanks


[FEA] Turn on spark.rapids.sql.udfCompiler.enabled by default

To help support customers with optimal performance out of the box, we want to enable the spark.rapids.sql.udfCompiler.enabled setting to be true by default.
The scope of this will involve any additional implementation and validation to be confident in the setting to be on by default.

We need to go through this on an operator by operator basis, and look at all of the types to see where there are gaps.
For example a udf that does a divide of integers could throw a divide by 0 exception, but the SQL divide by default does not.
We also have to see what happens if ANSI is enabled or not.  Can we force the divide to be an ANSI divide to get the behavior we want? There is a lot of testing and evaluation that we need to go through to understand what work needs to be done to really truly make this work.
What about Long vs long. In UDFs if the type is a long and a null shows up as input, then the UDF is not run and the output is null. But if the type is a Long, then the null is passed to the UDF and we need to be able to handle throwing exceptions for NPEs at the same time the java/scala code would.

Functionality should be viewed as a prototype.  Additional validation would be needed before considering this by default.
@viadea: what are the use cases where you have seen that enabling this feature has had a major benefit?

@mattahrens Regarding spark.rapids.sql.udfCompiler.enabled, I did not realize we might have different results for supported Scala UDFs -> Catalyst expression.
sometimes we enable this parameter and hope it can help convert those simple enough Scala UDFs.
But if we have such potential result issue, I would suggest we firstly address those before enabling it by default.


restart installer container after error

In some cases the installer container will fail when it is not able to reach the API server (network glitch, endpoints charade, etc). In that case the installer pod will fail and never retry. A manual intervention is required in that case to set the ForceRedeploy field.
That approach seems to be clunky in regards to our e2e tests when the inability to recover the installer after it lost the connection to API server is fatal for test and likely cause a lot of flakes.
This change will allow the installer pod to backoff restart its failed container 5 times. After 5 failed attempts to run, the controller will delete the pod, scrape the last termination error from it and report it back to operator. A downside of deletion could be deleting a pod with "running" container, which I think is unlikely as after 5 restart, the back-off will be >1m and we likely fit into this window...
I think this is an edge case (the API server should be always available), but this will unstuck us from network flakes?
/cc @sttts
/cc @deads2k
TODO: This screams for a unit test before merging.

@deads2k if we want to do this, then I'm thinking we can probably turn this into a installer_pod_controller ? It could be a follow up perhaps, I guess this change is enough to unstick us for now.

@deads2k @sttts more I'm thinking about this approach, more I don't like it... IF we go with this, we will basically never get Failed pod, but rather no pod (we will delete it after 5 restarts)... It complicates the controller logic.
I think the only possible solution is to implement retry mechanism inside the installer container. The command have to be reentrant to API server failures and retry. We should set the activeDeadlineSeconds to the installer Pod to enforce an timeout which will limit the number of retries. WDYT?


feat(rule): nullable type declaration

:tada: This PR is included in version 2.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


start of pbnj.next

Description
Huge apology for the massive size of this PR. This refactors PBnJ to have a gRPC interface. This has all created protocol buffers, grpc service, boilerplate logging, tests, CI, task queue, stubbed out implementation functions for all grpc service/rpcs, etc. Power status implementation is partially written. The next step is to write produce the design doc, tinkerbell org proposal, and documentation around the code flow. After that will start writing the rest of the actual implementations for bmc interactions.
Why is this needed
modernize PBnJ and add bmclib implementation for supporting additional hardware vendors
Fixes: #
How Has This Been Tested?
Yes, make test or make cover runs unit tests.
How are existing users impacted? What migration steps/scripts do we need?

Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[X] added unit or e2e tests
[ ] provided instructions on how to upgrade

Hey @mmlb, I've updated the directory structure. Please let me know what you think.

Recap of our zoom (for GitHub review purposes):

Move grpc generated stuff to same dirs as proto files, like our other repos do
Move packages under pkg/ out of pkg/
Use github.com/packethost/pkg/log/logr

Hey @mmlb , should be good for a review now. thanks!

@mmlb , just a friendly bump :)


Update Polish translation

Update Polish translation

Description 🗒
Update Polish translation based on the most recent commits

Examples 📸

Related Issues 🔗
#175
#364 (some strings got fixed since then, thanks!)

 Expand for Help

Have questions about the review or deployment process? View our contributing docs
Need additional help and want to chat in real time? Join our community Discord

By submitting this pull request, you agree to our code of conduct

To understand better how {{count}} seconds_xxx is used you can check out this documentation page https://www.i18next.com/translation-function/plurals#languages-with-multiple-plurals

I never realized there were few/many/other plurals, thanks! I was about to test it and then comment it afterwards, but it seems that you already have a solution for Polish (and other) plurals, in Polish it's like this:
https://www.unicode.org/cldr/cldr-aux/charts/33/supplemental/language_plural_rules.html#pl

@Faalagorn Did you reviewed also the plurals for meters and days?
Like:

From distance: {{operator}} {{count}} meters_one

{{count}} days_one

@Faalagorn Did you reviewed also the plurals for meters and days?
Like:

From distance: {{operator}} {{count}} meters_one

{{count}} days_one

Thanks! I updated days plurals now, hopefully it's all fow now :)

.deploy


HI will this work with the RGBgenie - ZigBee 3.0 RGBW Remote?

HI I was looking to purchase the RGBgenie - ZigBee 3.0 RGBW Remote. I was hoping to easily use it with ST. Will this Device handler work? and will this be easier than trying to use it with HUE? Thanks for any help!!

Can you direct me to where I can find a handler for:
https://rgbgenie.com/?product=rgbgenie-rgbw-remote-zigbee

Good morning.  I wish we had o e for SmartThings.  But do not as of yet.
Sean
On Tue, Feb 2, 2021, 3:59 AM Miles Reetz<EMAIL_ADDRESS>wrote:

Can you direct me to where I can find a handler for:
https://rgbgenie.com/?product=rgbgenie-rgbw-remote-zigbee
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/RGBGenie/SmartThings_RGBgenie/issues/7#issuecomment-771553146,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKWYKRBK2R2F6DQQKGVLGVTS47LIDANCNFSM4WG4G4LA
.

Is there something in the works? what integrations are available? I see Hubitat for the touch panels but is there something for this?


occasional GraphHandle not found error

We occasionally get this error like below on universe-starter-agent. This is on a dedicated box and the code doesn't handle task restarts, so the common scenario doesn't apply . @mrry any idea if there's any way to get this error without a task restart?
https://github.com/openai/universe/issues/112
Exception in thread Thread-10:
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1021, in _do_call
    return fn(*args)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1003, in _run_fn
    status, run_metadata)
  File "/usr/lib/python3.5/contextlib.py", line 66, in __exit__
    next(self.gen)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/errors_impl.py", line 469, in raise_exception_on_not_ok_status
    pywrap_tensorflow.TF_GetCode(status))
tensorflow.python.framework.errors_impl.AbortedError: Graph handle is not found:<PHONE_NUMBER>00000d

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
    self.run()
  File "/experiment/universe-starter-agent/a3c.py", line 92, in run
    self._run()
  File "/experiment/universe-starter-agent/a3c.py", line 101, in _run
    self.queue.put(next(rollout_provider), timeout=600.0)
  File "/experiment/universe-starter-agent/a3c.py", line 139, in env_runner
    summary_writer.add_summary(summary, policy.global_step.eval())
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/variables.py", line 515, in eval
    return self._variable.eval(session=session)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py", line 575, in eval
    return _eval_using_default_session(self, feed_dict, self.graph, session)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py", line 3633, in _eval_using_default_session
    return session.run(tensors, feed_dict)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 766, in run
    run_metadata_ptr)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 964, in _run
    feed_dict_string, options, run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1014, in _do_run
    target_list, options, run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1034, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.AbortedError: Graph handle is not found:<PHONE_NUMBER>00000d

[2017-01-10 06:27:56,508] Received signal 15: exiting
I tensorflow/core/distributed_runtime/master_session.cc:891] DeregisterGraph error: Aborted: Graph handle is not found:<PHONE_NUMBER>00002c. Possibly, this worker just restarted.
[2017-01-10 06:27:56,601] Killing and removing container: id=e8bf782d91fa3d6e3bb685e37ed4f9622f054bfb281f1e1e61021f1ed6798a06

Can you describe the exact setup? I'm not sure what "dedicated box" and "common scenario" mean.
Is it possible that some other  thread could have decided to close the session before that exception was raised? I think if a close() and a run() issue concurrently, it's possible to see a partially-shut-down state, which would correspond to this error message.
(If no process restarted, I'd be very surprised if this happened, because the sequence of events is:

Master calls register graph.
Worker receives register graph call.
Worker atomically invents a handle and registers it in its GraphMgr (code).
Worker sends handle back to master.
Master stores that handle in the MasterSession.
Later, master attempts to deregister a graph (presumably when closing a session), using the handle it received from the worker.
Worker receives deregister graph call.
Worker atomically removes the graph associated with the given handle in its GraphMgr (code).

I suppose it's possible that the DeregisterGraph call could have been retransmitted by gRPC, with the second response taking precedence. Perhaps we should ignore failures from the DeregisterGraph RPC.)

Thanks for the explanation! We indeed had threads calling sess.run and sess.close in parallel


Fix conversion of String->Int dictionary

Failing test for #52

Can you please also add the test of the name to the manifest so that this test is ran on Linux as well? https://github.com/DanToml/Jay/blob/master/Tests/JayTests/FormattingTests.swift#L34

Oops, missed that. Fixed.

I did an explicit typecheck on Int  instead of a cast. Let's see if the Linux builds still succeed.
Note that the inverse (typechecking for Bool) doesn't work; someInt is Bool returns true.

Note to self: run the full unit test suite before pushing :( Sorry for the noise, back to the drawing board.

Not sure why the build is failing; the tests seem to pass.

Current coverage is 88.30% (diff: 81.81%)

Merging #53 into master will increase coverage by 1.41%

@@             master        #53   diff @@
==========================================
  Files            18         24     +6
  Lines          1068       1933   +865
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            928       1707   +779
- Misses          140        226    +86
  Partials          0          0

Powered by Codecov. Last update b3b31b7...4619337

Any updates on this? Is there anything I can do to get this merged?

Looks like this will need a rebase then it's good to go, sorry for the delay!

@DanToml Thanks, done!


Label: make the copy icon transform into a ✅ when clicked

The copy icon should transform into a ✅  to give the user feedback that the field has been copied.
Current situation
https://user-images.githubusercontent.com/7217420/106454521-28a3fe80-648b-11eb-902f-8409402a9a7f.mov

Done in https://github.com/gsimone/leva/pull/49/commits/2c1252f249860df05a914a03e0887119675991bb


profile provider: adjust timeout

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 99.591%

Files with Coverage Reduction
New Missed Lines
%

src/modules/olMap/handler/measure/OlMeasurementHandler.js
1
96.89%

src/modules/olMap/handler/draw/OlDrawHandler.js
7
96.97%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
12485

Relevant Lines:
12495

💛  - Coveralls


Fix gh checkout action fetch depth

Description
Reduce the fetch depth of the Checkout Repo step action to improve perf of our CI and upgrade actions/checkout@v4

Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[x] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/backend
[ ] @clerk/chrome-extension
[ ] @clerk/clerk-js
[ ] @clerk/clerk-expo
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] @clerk/localizations
[ ] @clerk/nextjs
[ ] @clerk/clerk-react
[ ] @clerk/remix
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/themes
[ ] @clerk/types
[x] build/tooling/chore

using fetch-depth: 1 does not fetch the origin/main so this change fails because the changeset depends on it.


Release/9.0.5

Update !Vendorer.toc

Version bump

Update CHANGELOG.md

Version bump

Remove summary

Remove the gained/lost summary.  Blizzard added their own in 9.0.5.

I do not see why you would removed gained/lost. Perhaps gained only, as Blizzard doesn't write a system message for lost gold:
[12:05:53] You gained: 43 90 61  [12:05:53] Vendorer Gained 43 90 61  [12:06:02] Vendorer Lost 43 90 61


fix: initializer re-entrancy vulnerability from OZ (4.4.1)

What does this PR introduce?

[x] Fix Initializable vulnerability from OpenZeppelin, by changing modifiers from initializer to onlyInitializing

i merged the OP upgrade, can you re-run the checks?


Replace property names with indexes in state sync

Refs #157

I can grab this after #278 is merged. After all, the keys often cost more bandwidth than their values lol

When a new state property is added on runtime, the authority sends full states, until a new_property ack is received from the client. When a state property is removed on runtime, the authority sends full states, until a removed_property ack is received from the client. Does it sound good for a PR?
Or want me to just implement indexes as is, but without covering the above edge use-cases, so diff states will be incompatible with adding/removing state properties?
Also, since this feature will be done, and input has the same property format [tick][property] perhaps input could also be included in the same PR hmmmm.... Should be simpler too.

I'd prefer to pick this up after #321, as it might bring some refactors on the internals of RollbackSynchronizer. Can't say exactly how much time it will take for a PR though, so if it takes too long, I'm ok with a PR. Will ping if that happens.
Ensuring that settings are synced ( if they change ) is up to the user. So for that case, I'd just reset the diff state variables, basically restarting the process - sending the initial full state and then continuing from there.
Good point on the inputs, we should update those to use indexes as well.

Also just thinking out loud for a bit - we could technically use hashes instead of indexes. Both would boil down to sending numbers, but properties having the same hashes between changes might make it more resilient, by reducing index mismatches. A drawback that needs to be considered is hash collisions - not sure how common these would be.

I'd prefer to pick this up after https://github.com/foxssake/netfox/issues/321, as it might bring some refactors on the internals of RollbackSynchronizer

Seeing #347 (realtime adding properties), I agree that you have the perfect insight to implement this cleanly and without bugs (and without back and forth :P )

Can't say exactly how much time it will take for a PR though, so if it takes too long, I'm ok with a PR

For my game, I'm in no rush for this as this is basically a feature for production/release. I bet this implementation will be done sooner than my game reaching 1.0 given its not even at 0.1 :P

So for that case, I'd just reset the diff state variables, basically restarting the process - sending the initial full state and then continuing from there.

Sounds simple and clean :+1:

Ensuring that settings are synced ( if they change ) is up to the user.

Let's confirm it after #347

Also just thinking out loud for a bit - we could technically use hashes instead of indexes. Both would boil down to sending numbers, but properties having the same hashes between changes might make it more resilient, by reducing index mismatches. A drawback that needs to be considered is hash collisions - not sure how common these would be.

Since a property - independent of its instance - is to have the same index/hash order, there shouldn't be any risk of hash collisions. So for example the brawlers at forest-brawl will always have the same indexes/hashes, regardless of how many players there are.
That said, the benefit of indexes would be that it's 1 byte per key, but godot sends 4 bytes (int) anyway, so using hash sounds like a better choice :+1:

Let's confirm it after https://github.com/foxssake/netfox/issues/347

Nothing to confirm. This is a design choice.

Since a property - independent of its instance - is to have the same index/hash order, there shouldn't be any risk of hash collisions.

Two property names in the same config have a chance to hash to the same value, resulting in two different properties having the same index.

That said, the benefit of indexes would be that it's 1 byte per key, but godot sends 4 bytes (int) anyway, so using hash sounds like a better choice 👍

An index is just a number, it has no inherent size. FYI, Godot's int is 64 bits, so 8 bytes. Though, an option is to limit the property count to 255, and send the indexes as a separate PackedByteArray followed by an array of values. This is for diff states only - for full states, we can simply send an array of values.

FYI, Godot's int is 64 bits, so 8 bytes.

AAAA

Though, an option is to limit the property count to 255, and send the indexes as a separate PackedByteArray followed by an array of values. This is for diff states only - for full states, we can simply send an array of values.

I love this idea. Literally optimal bandwidth usage, without bloating code with serialization.

Two property names in the same config have a chance to hash to the same value, resulting in two different properties having the same index.

As a use-case, hopefully I understand this correctly:
RollbackSynchronizer.states has two property names, "movement" and "rotation". Let's say the hash for "movement" is<PHONE_NUMBER>3 and the hash for "rotation" is 234723747
With a hash being 8 bytes (Godot's int), the chances of hashes colliding is astronomically low imo. Especially since these hash collisions don't increase per node/instance, but only for new scenes with RollbackSynchronizers.
That said, since there won't be that many properties for RollbackSynchronizer globally, could keep a list of all the property hashes in a singleton, inside a dictionary, to compare against when creating a hash.
Anyway, once this check is added, the code will be bloated compared to the PackedByteArray solution which has no such problems, and has better bandwidth :+1:


Add back List ordering test coverage to common/configuration/dal/dal_test.go

https://github.com/TBD54566975/ftl/pull/2237#issuecomment-2263565613

The original test contained assertions for the order of the results from calling List. The sorting is performed in the SQL query, so the purpose of the test is to make sure the query's sorting behavior doesn't get broken.