Remove quotes and new line characters from all response messages

"The JSON in a POST Request for new Skill must contain values for "+ %q and %q fields.", "name", "skill_type"
Should not have "

Where do the quotation marks and newlines need to be removed from?


big list mischief - discuss solutions

so I have a few collections, each with more than a thousand images.
When I start downloading pages and set pagination to 1,000 it works quite well... until it doesn't. Basically the first thousand thumbnails download OK, but somewhere on the second or third page (in quick succession, not at once) it starts to struggle.

basically the thumbnails stop loading, and the page doesn't recover.
Looking at the replica count in the Azure portal, it seems we are spinning up 10 containers and topping out (if I am reading this correctly)

That's not a big surprise. The SPA is making a thousand requests at the same time.
Note that the CPU and RAM are not being hammered - in fact the high water mark is 25% of one core and 80% of the memory working set (125Mb, not much at all). I don't know if this is x10 (per each container) or in total, but either way it's not too much.
I was wondering what we should do about it - it's not a great experience to crash the page and loose some images.
Ideas:

remove the 1000 images pagination option, that would hide the symptom (and remove the footgun)
configure/tune things on the Azure side so it doesn't start yielding 503s when it is only getting asked for a few thousand things at once. That might get expensive, if it opens a vector for attacking our wallet...
push this work onto a static publishing service (rather than the container), possibly with a CDN in front of it. That would be a bit more complex, but delegate DOS prevention to the vendor.
implement a throttle on the API (429: enhance your calm), so clients are able to fail more gracefully (back-off and retry when told). Won't help in the case of malevolent or inept clients, unless it's a user-specific throttle. Could we implement this through front-door API Gateway, or would the API need to implement this feature?
the SPA might have a client-side queue and pull down a maximum number of images simultaneously (e.g. 20). That way they would seldom get told to chill out by the server. Woudln't fix load problems from malevolent or inept clients, but would be a gentlemanly compliment to server-side back-off.

What else could we do?

Also, similar question/discussion for bulk uploads. That would be helped by the "201 uploaded / 200 we arready-gotta-one, but fine whatever" duplicate prevention mentioned else ware, because it would allow the client to harmlessly retry (*), effectively making uploads idempotent. But still, as things are, when I try to bulk upload images the first hundred or so work fine but if I try too many they start to drop some attempts with 503 after maxing-out the container count.
(*) it would also allow confused users to click the upload button more than once without messing up their collection :)

I think this is the main culprit: https://github.com/Tech4Tracing/CartridgeOCR/blob/4bd345a62f425b34203f782adc8da1a5d754b2a4/src/annotation/annotations_app/views/images.py#L237-L246
Instead of sending the actual image data via the Flask app, we should just sent the URL of the object in Azure storage. If we want to apply some access-control logic at the Flask level, we can use shared access signatures to provide protected (eg. time restricted) URLS.

right, "push this work onto a static publishing service (rather than the container)...". Doesn't look too bad e.g. https://stackoverflow.com/questions/41285755/how-do-you-generate-the-signature-for-an-azure-blob-storage-sas-token-in-python
To maintain docker-compose / Azure pairity, the flask app might need to know how it's deployed and pick the right method. Assuming there is already enough environment variables to figure this out (but we might need another switch), maybe it should:
if not deployed in azure:
   use the current code
else:
   issue http 302 redirect to the new, specially constructed URL (using a generated SAS token)

There is another issue here, the UI retrieves annotations for each image while in the new API version annotation data has already been included in the image endpoint response; so could save some HTTP requests here (many in fact)
I'll implement azure presigned urls as well if we start to have issues with that; it should help a lot

I think we can close this now. @koriaf do you agree?

Sure


TapeMachine's behaviour is not idempotent after a call to Reset in some circumstances

In this use-case https://github.com/gorgonia/agogo/issues/4 two consecutive execution of the TapeMachine with a call to Reset does not provide the same execution result.
It looks like the Reset function should reset the cpumem registries like this:
 // Reset resets the run state of the machine by changing the instruction pointer back to 0
+// and reseting the registry
 func (m *tapeMachine) Reset() {
        m.pc = 0
        m.ExternMetadata.Reset()
@@ -116,6 +117,9 @@ func (m *tapeMachine) Reset() {
                returnValue(m.gpumem[i])
                m.gpumem[i] = nil //
        }
+       for i := range m.cpumem {
+               m.cpumem[i] = nil
+       }
 }

I suspect that this instruction https://github.com/gorgonia/gorgonia/blob/12e31c4befd99d1c0844d0d7555b102c3aa11639/vm_tape.go#L509-L512
from the method https://github.com/gorgonia/gorgonia/blob/12e31c4befd99d1c0844d0d7555b102c3aa11639/vm_tape.go#L499 is causing the issue.
A test should validate the hypothesis.

let's merge this

let's merge this

ok

ok


Add tests to confirm MD code comments aren't foldable regions

This PR adds tests to confirm https://github.com/microsoft/vscode/issues/158179 is fixed. Comments in code in markdown no longer make a fold-able region.
Video of current release (unwanted behavior)
Video of development build (correct behavior)

@microsoft-github-policy-service agree [company=""]

@microsoft-github-policy-service agree


refresh images

@emilywoods we have a designer atm so I'm taking the opportunity to update our docs to be more in line with our current site design!


ClientModel: Investigate whether we can remove PipelineRequestHeaders.TryGetValues( ... IEnumerable ) overload

Follow up on PR comment here: https://github.com/Azure/azure-sdk-for-net/pull/41223#discussion_r1450966041

Some notes on this investigation:

Azure.Core RequestHeaders has TryGetValues(IEnumerable) overload.  We could move the implementation of this into Azure.Core only, but it would mean splitting the implementation of RequestHeaders across libraries.

Closing per offline conversation


Not automatically redirecting to login

When trying to access Category list and the token is actually expired, the redirect to login is not happening.

Could not reproduce this issue anymore. Probably fixed already.


WIP: Add upgrade lock file and healthcheck to the container

This is just a copy of #60, but in a branch of the main repo so we can see the CI check results. :smile:

k, that looks happier. :smile:
Will need to properly look over the code, which I'll try to get done later today. :smile:


Invalid row generated at statement result

Type: Bug
When making an sql statement, azure data studio is generating an invalid row at the end of the result, resulting in a correct overview of the statement. This happened when connected to SQL.
Azure Data Studio version: azuredatastudio 1.48.0<PHONE_NUMBER>ef8254b7c22a5dc55af7f8a1dea93f, 2024-02-27T00:05:08.293Z)
OS version: Windows_NT x64 10.0.22635
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 x 3600)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.93GB (8.80GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

azure-cosmosdb-ads-extension
Mic
0.4.5

net-6-runtime
Mic
1.1.0

azdata-sanddance
msr
4.1.1

@andrecj93 could you please add additional details on which SQL statement is generating an invalid row, and any other details that would help repro this bug?
I wasn't able to repro using a simple SQL statement, for example below.

@caohai do you any ideas what could be happening here?  I'm still unable to repro & haven't seen this before.  The only thing coming to mind is that maybe there is some timing issue if the rows contain many columns for BLOB, XML, JSON and it's taking a long time to move the results to the UI, but I only see one JSON field in the screenshot above.

@kburtram I did a quick search in the issues and found a few that appear to be related.
In particular this issue https://github.com/microsoft/azuredatastudio/issues/24052 Cheena created last year seems to be very similar to this one. I tried to test with some large strings in the result but still couldn't get a repro. I've reached out to Cheena to see if we can get a consistent repro.
@andrecj93 Can you share the rough size of the DraftData field?

@caohai The column can hold varchar max.
Here's the char count for the same query I've shown you.

Take a look at one of the runs that generated absurd data that doesnt exist.

Yes, I think Its related to the size of what the column hold as I've seen this happen in another table that holds large AI prompts.

@kburtram I was able to repro both issues, I believe they are two different bugs. Here are the repro script:
CREATE TABLE TestTable1 (
    name varchar(max),
    id text,
);

INSERT INTO TestTable1 (name, id) VALUES (REPLICATE(CONVERT(varchar(max), 'V'), 2147483) , 'vvvvvv');
INSERT INTO TestTable1 (name, id) VALUES (REPLICATE(CONVERT(varchar(max), 'U'), 2147483) , 'uuuuuu');

-- id and name might not render for the last row, you can still copy the cell value
-- will render if you go to Messages then back
select id, name, len(name) as charcount, null as TEST from TestTable1

The above script reproduces this issue for me.

CREATE TABLE TestTable2 (
    name varchar(max),
    id text,
);

-- can take a few minutes to finish
INSERT INTO TestTable2 (name, id) VALUES (REPLICATE(CONVERT(varchar(max), 'W'),<PHONE_NUMBER>) , 'wwwww');

-- will render invalid data while the qurey is running, eventually query fails with
-- "Query failed: Array dimensions exceeded supported range." and the invalid data is till in the grid.
-- I've already set mssql.query.maxCharsToStore to<PHONE_NUMBER>
select id, name, len(name) as charcount, null as TEST from TestTable2

This script reproduces https://github.com/microsoft/azuredatastudio/issues/24052 as well as the invalid data shown in the second screenshot of https://github.com/microsoft/azuredatastudio/issues/25861#issuecomment-2305891915


Fix byteenable in the basic memory model

Signed-off-by: Deepak Unnikrishnan<EMAIL_ADDRESS>

DMA test with address span extender (uses byteenables)
http://sj-pert.altera.com/pert/#do-not-bookmark-3

ASE tests: http://sj-pert.altera.com/pert/pert.php?test_run_id=2195171

OpenCL test failures are unrelated to this change

It was a bug and not a feature of the memory subsystem?

That's correct. We discovered this bug when Chris switched his OpenCL to basic memory model. His test uses the address span expander which in turn uses byteenables.
We never had a unit test case for byteenables w/ basic memory model. I plan to add a unit test in hello_mem_afu.


Relogin issue

I have the login menu, where i need to input email and password(by the user1). Then if it's correct appears loginWithEmail() method and it goes to main menu. When i click Exit button i return to login menu. And i login again but by other email and password (by other user2). I have reconnectThread that reconnect current user if connection is lost(your native reconnection doesn't work and overload app with logs). inside this thread i call mMeteor.reconnect() and then loginWithEmail(). It must reconnect current user2. But sometimes it reconnect previous user1 (in 50% cases). So i think loginWithEmail() or mMeteor.reconnect() doesn't work correct.

Thanks for your report!
I'm quite sure loginWithEmail is actually working correctly. There is probably something else that's missing or not working correctly here.
Can you try logging out using the logout method before signing in to the second account?
By the way, we should definitely fix the automatic re-connects done by this library. If you can point out something that's not working, I'd be happy to hear about it. Some custom thread for re-connects really shouldn't be necessary.

Closing due to inactivity


[Bug]: Can't open file: Too many open files@src/storage/io/local_file_system.cpp:85

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
main
Commit ID
95562e9
Other environment information
No response
Actual behavior
$ ulimit -a

real-time non-blocking time  (microseconds, -R) unlimited
core file size              (blocks, -c) 0
data seg size               (kbytes, -d) unlimited
scheduling priority                 (-e) 0
file size                   (blocks, -f) unlimited
pending signals                     (-i) 62579
max locked memory           (kbytes, -l) 2010464
max memory size             (kbytes, -m) unlimited
open files                          (-n) 2048
pipe size                (512 bytes, -p) 8
POSIX message queues         (bytes, -q) 819200
real-time priority                  (-r) 0
stack size                  (kbytes, -s) 8192
cpu time                   (seconds, -t) unlimited
max user processes                  (-u) 62579
virtual memory              (kbytes, -v) unlimited
file locks                          (-x) unlimited

terminate called after throwing an instance of 'infinity::UnrecoverableException@infinity_exception'
  what():  Can't open file: /tmp/infinity/temp/tmp/infinity/data/OU7YCTru1s_db_default/ZGAgORSF7p_table_test_import_exceeding_columns/seg_0/blk_0/868.col: Too many open files@src/storage/io/local_file_system.cpp:85
Aborted (core dumped)

Expected behavior
No response
Steps to reproduce
Just run `python tools/run_pysdk_test.py` in root dir

Additional information
No response

Use ulimit -n 8192 to fix it.

This configuration need to be documented.
We are using block based file storage to resolve the issue, in the future.

Infinity binary packages(rpm, deb) systemd service set nofile to 500000 . See here.


Excel insists on saving vbaDeveloper.xlam to AddIns directory

I tried building the addin, but when I get to step 7 ("In VB Editor, menu File-->Save Book1; Save as vbaDeveloper.xlam in the same directory as 'src'"), Excel insists on saving the .xlam file to its own AddIns directory (C:\Users\($username)\AppData\Roaming\Microsoft\AddIns), even though I select the parent directory of "src" as the save location.
If I then try to run testImport() for the installed addin, I get the error:
Folder does not exist: C:\Users\($username)\AppData\Roaming\Microsoft\AddIns\src\vbaDeveloper.xlam\
No import directory for project vbaDeveloper, skipping

Has anybody else run into this problem? Excel 2010, Windows 7.

I had the same problem on the same Excel/windows combo, but not on my
Windows 8/2013 combo. I don't know the cause, but I was able to run the
test import to build the file by making a copy in the vbaDeveloper folder,
opening it directly from the Excel open dialog, importing and saving
manually.
On Feb 11, 2015 4:14 PM, "Rintze M. Zelle"<EMAIL_ADDRESS>wrote:

I tried building the addin, but when I get to step 7 ("In VB Editor, menu
File-->Save Book1; Save as vbaDeveloper.xlam in the same directory as
'src'"), Excel insists on saving the .xlam file to its own AddIns directory
(C:\Users($username)\AppData\Roaming\Microsoft\AddIns), even though I
select the parent directory of "src" as the save location.
If I then try to run testImport() for the installed addin, I get the
error:
Folder does not exist:
C:\Users($username)\AppData\Roaming\Microsoft\AddIns\src\vbaDeveloper.xlam
No import directory for project vbaDeveloper, skipping
Has anybody else run into this problem? Excel 2010, Windows 7.
--
Reply to this email directly or view it on GitHub.

I think I tried that as well. At some point, the vbaDeveloper menu showed up, and I tried exporting some VBA code. While I didn't get an error, I then couldn't find the exported code on my hard drive. And when I restarted Excel, it had loaded the version in my roaming profile again.

Same problem with my system: Windows 7, Excel 2007.
If I didn't save in the C:\Users($username)\AppData\Roaming\Microsoft\AddIns directory, Excel didn't recognize vbaDeveloper as an AddIn.
I tried saving in this directory, then copying the src folder to this directory and moving the vbaDeveloper.xlam file into the src folder. This made the testImport() Sub work but I never got the 'Menu' add in and I was not able to commit subversion changes.

For those that didn't get the menu, I have sporadically had it not load the
menu on startup, but haven't had a chance to investigate. If you open the
menu module you can manually run the Create menu macro to get it in there.
On Feb 11, 2015 10:15 PM, "Dan"<EMAIL_ADDRESS>wrote:

Same problem with my system: Windows 7, Excel 2007.
If I didn't save in the
C:\Users($username)\AppData\Roaming\Microsoft\AddIns directory, Excel
didn't recognize vbaDeveloper as an AddIn.
I tried saving in this directory, then copying the src folder to this
directory and moving the vbaDeveloper.xlam file into the src folder. This
made the testImport() Sub work but I never got the 'Menu' add in and I was
not able to commit subversion changes.
--
Reply to this email directly or view it on GitHub
https://github.com/hilkoc/vbaDeveloper/issues/7#issuecomment-74010858.


Add gnome shell extensions

[ ] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I'm running Nix on Arch, where Gnome 3.20 has been released, but https://extensions.gnome.org/ is being slow to update these so I wanted to package these extensions via Nix. Right now, I have a shell script that uses nix-build to make links to these in my ~/.local/share/gnome-shell/extensions folder; in the future, I'm guessing these could be used via nixuser. I wasn't sure about a few things that I want feedback on:

Is this the right location in the file structure to put these? Most of them work with a bunch of different Gnome3 versions.
How should I add these top-level/all-packages.nix file? I wasn't sure if they should have a prefix or something.
@timbertson do you want to be listed as a maintainer for the impatience extension since you wrote it?

Thanks @aneeshusa,
I agree that we should keep these out of gnome3.x specific directory - most of them work fine on most shell versions.
I don't know about top-level/all-pacakges. Maybe put them all under a gnome3.shellExtensions object?
And yep, feel free to add me as an additional maintainer for impatience.

cc @lethalman

AFAIK gnome shell extensions hardcode the shell version on which they work right? So I'd put them in gnome3 specific version folder.

They have a hardcoded list of versions they work with, but they support many versions at the same time. For example:  https://github.com/timbertson/gnome-shell-impatience/blob/master/impatience/metadata.json
All three of these support at least 3.16, 3.18 and 3.20.

Also, there is already a gnome3.gnome-shell-extensions, which is a derivation for the built-in official extensions. In order to make the difference between that and gnome3.shellExtensions more clear, how about putting these under gnome3.unofficialShellExtensions or gnome3.extraShellExtensions or gnome3.moreShellExtensions?

Rebased and updated. I also added another extension that I had forgotten before.

Ping on this, I'd love to get these in-tree.

Thanks !


chore: Update import path for database module

index.js is the correct extension. This project also doesn't use Bun


Make kv optional in host

Fixes #828

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-csharp-cosmos-sql
Remote: azure-samples-staging
Branch: pr/850
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/850

View Changes | Compare Changes

Project: todo-csharp-sql
Remote: azure-samples-staging
Branch: pr/850
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql -b pr/850

View Changes | Compare Changes

Project: todo-java-mongo-aca
Remote: azure-samples-staging
Branch: pr/850
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo-aca -b pr/850

View Changes | Compare Changes

Project: todo-java-mongo
Remote: azure-samples-staging
Branch: pr/850
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo -b pr/850

View Changes | Compare Changes

Project: todo-nodejs-mongo-aca
Remote: azure-samples-staging
Branch: pr/850
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/850

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/850
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/850

View Changes | Compare Changes

Project: todo-nodejs-mongo
Remote: azure-samples-staging
Branch: pr/850
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo -b pr/850

View Changes | Compare Changes

Project: todo-python-mongo-aca
Remote: azure-samples-staging
Branch: pr/850
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-aca -b pr/850

View Changes | Compare Changes

Project: todo-python-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/850
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/850

View Changes | Compare Changes

Project: todo-python-mongo
Remote: azure-samples-staging
Branch: pr/850
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo -b pr/850

View Changes | Compare Changes

Closing. Will resolve in #892


Receiver DNS address support

Hi,
is it possible to add DNS Support to the Receiver IP address field?
I like to manage my smart devices in a dynamic manner and assume I am not the only one!?
Really great intergration you got going.

Ah, Github autocloses the ticket also when mentioning it in a pullrequest :)
Anyway, hostnames should work now with v5.1.0. I was only able to test it with a change to the hosts file, but as long as your Home Assistant server can resolve the address it should work.

Wow, that was fast.
Works now, thank you.


bug fix when merging documents (affects when images are present in documents to be merged)

Resolves #10 ; sets new_rel_node consistently in def self.merge_documents to avoid Nokogiri lowercasing the <Relationship> node that is created and attached

Hi, I'm running behind on reviewing PRs. Will try to get to it by Nov 1st. If it's still pending, please leave a comment again. Thank You!

great work, this fixes the issue but the images wouldn't load, because it's not the actual image to word/media/image.png, or maybe it doesn't always too that, I'm not familiar with how docx work, either way, this worked for me
# add the image to word/media folder
zos.put_next_entry("word/#{target_val}")
zos << zip_file.read("word/#{target_val}")


New version: Upscayl.Upscayl version 2.8.6

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

/AzurePipelines run


AlertManager crashing due to pager duty alert

I have alertmanager running but alerts are not going into pager duty. I see the following in the logs
level=debug ts=2019-04-08T17:29:32.81456097Z caller=notify.go:670 component=dispatcher msg="Notify attempt failed" attempt=1 integration=pagerduty receiver=pagerduty err="unexpected status code 400"
level=error ts=2019-04-08T17:29:32.814742975Z caller=notify.go:332 component=dispatcher msg="Error on notify" err="cancelling notify retry for "pagerduty" due to unrecoverable error: unexpected status code 400"
level=error ts=2019-04-08T17:29:32.814767344Z caller=dispatch.go:177 component=dispatcher msg="Notify for alerts failed" num_alerts=2 err="cancelling notify retry for "pagerduty" due to unrecoverable error: unexpected status code 400"
level=info ts=2019-04-08T17:29:35.540648774Z caller=main.go:467 msg="Received SIGTERM, exiting gracefully..."
level=debug ts=2019-04-08T17:29:35.540795025Z caller=nflog.go:334 component=nflog msg="Running maintenance"
The last line looks like something just kills the process.
Versions
alertmanager, version 0.16.2 (branch: HEAD, revision: 308b7620642dc147794e6686a3f94d1b6fc8ef4d)
build user:       root@1e9a48272b38
build date:       20190405-12:27:40
go version:       go1.11.6
prometheus, version 2.8.1 (branch: HEAD, revision: 4d60eb36dcbed725fcac5b27018574118f12fffb)
build user:       root@bfdd6a22a683
build date:       20190328-18:04:08
go version:       go1.11.6
AlertManager config
global:
resolve_timeout: 5s
route:
group_by: ['instance', 'severity']
group_wait: 2s
group_interval: 30s
repeat_interval: 30s
receiver: pagerduty
routes:

match:
alertname: InstanceDown
receiver: pagerduty

receivers:

name: pagerduty
pagerduty_configs:

send_resolved: true
routing_key: "key"
description: "{{ .CommonAnnotations.description }}"
severity: '{{ if .CommonLabels.severity }}{{ .CommonLabels.severity | toLower }}{{ else }}critical{{ end }}'

templates:

templates/*.tmpl

How do I debug to see what it is sending to pager duty?

Turns out this was the description. I think maybe debug should log the entire pager duty msg.

The last line looks like something just kills the process.

Something/someone sent a SIGTERM signal to the process ("Received SIGTERM") which I believe has nothing to do with your PagerDuty issue. https://github.com/prometheus/alertmanager/pull/1812 should ease the troubleshooting as the message returned by the PagerDuty will be printed in the logs.

This issue is back.
level=debug ts=2019-04-29T14:19:28.718338806Z caller=notify.go:670 component=dispatcher msg="Notify attempt failed" attempt=1 integration=pagerduty receiver=pagerduty err="unexpected status code 400"
level=error ts=2019-04-29T14:19:28.718453084Z caller=notify.go:332 component=dispatcher msg="Error on notify" err="cancelling notify retry for "pagerduty" due to unrecoverable error: unexpected status code 400"
level=error ts=2019-04-29T14:19:28.718474924Z caller=dispatch.go:177 component=dispatcher msg="Notify for alerts failed" num_alerts=3 err="cancelling notify retry for "pagerduty" due to unrecoverable error: unexpected status code 400"
Not sure how do debug this when we can't see the message or any data. We are missing alerts I think because of it

You need to trim down the description field so it fits under 1024 chars.


Allow explicit specification of bands to be retrieved by Retrieve Area of Interest Time Series tool

Allow bands to be retrieved to be specified as a command line argument to the Retrieve Area of Interest tool

The Retrieve Area of Interest tool now supports the --band BAND or --bands-all or --bands-common command line arguments.


Add keywords (bug 1118539)

r+

Rebased and merged: https://github.com/mozilla/zamboni/commit/25217d4


Fix failing tests on reference platform

Removes a couple of tests from ReferenceFoundation that are no longer passing.
NSSet enumerateWithOptions will not always respect NSEnumerateConcurrent so can cause a deadlock 🐙
NSURLSessionConfiguration TLSMaximumSupportedProtocol has been updated on the reference platform to reflect documented value
NSURL URLByDeletingPathExtension has a bug on the reference platform where it will improperly delete non-pathextensions.
Another test failed because the file it was looking for is in a different directory on OSX.
NSFileManagerTests was using a Lstring literal as a w_char* to create an NSString which failed on the reference platform.
Fixes #1725

Updated machine to Sierra, now fewer tests fail.  Still have currentDirectoryPath returning the incorrect path so I've disabled that test on OSX.


DRILL-6783: CAST string literal as INTERVAL MONTH/YEAR works inconsis…

…tently when selecting from a table with multiple rows

@vvysotskyi, I've added a unit test, please take a look.


feat: DAP Preflight and debugger compilation options

Description
Problem*
Part of #3015
Summary*
This PR adds a preflight mode to DAP in order to make it easier to identify and report back problems to the user when compiling the project for debugging. This preflight mode is invoked from the VS.Code extension before starting the debugging session, and with the same arguments as those that will be used for the session. If the compiler finds any error either loading or compiling the project, the error is reported to stderr which allows the extension to parse the output and present the diagnostic messages to the user.
This also changes the default compilation mode to output Brillig code and adds new commands line options to Nargo's debug command and launch options to the DAP mode to control the mode and whether to inject instrumentation code to track variables or not.
The debug options are:

--acir-mode, force output of ACIR, which disables instrumentation by default
--skip-instrumentation={true,false} to control injection of instrumentation code to track variables values during the debugging session.

Similarly, for DAP two launch options can be provided: generateAcir and skipInstrumentation.
Additional Context
The default is to output in Brillig mode with instrumentation for tracking variables, as this makes it easier to follow along with stepping through the code. If ACIR mode is selected, instrumentation is disabled by default. Instrumentation can be forcefully enabled or disabled by the provided CLI option.
Documentation*
Check one:

[ ] No documentation needed.
[ ] Documentation included in this PR.
[X] [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

[X] I have tested the changes locally.
[X] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Hey @ggiraldez, could you merge master back into your branch? We've had some CI changes which are blocking this PR.


Usage of footers and other markdown extension

I am using DocC and trying to add a footnote (using [^1] this is possible in gfm, including cmark-gfm) but it doesn't work. Can someone tell me if this has been implemented or is going to be implemented in swift-markdown?
Example footnote [^1]
[^1]: Explanation of footnote

Footnotes are enabled in cmark-gfm (and swift-cmark) via an option passed to the parser. We currently do not enable footnotes:
https://github.com/apple/swift-markdown/blob/ad0b81fed55c4a72fdaeb5535884bd2886de96f4/Sources/Markdown/Parser/CommonMarkConverter.swift#L598-L601
It's possible to add it there to turn it on, though i'd want to make sure that we supported it properly in the MarkupWalker protocols and rendered it properly in Swift-DocC and Swift-DocC-Render to be confident in it.

Okay thank you for the information!


Support symbols for styling lines

It would be nice if we could use point symbols like stars etc. to style lines (e.g. linestrings, b0ut also boundaries of polygons)

Hmm never seen that before, but sounds nice. Do you have any examples (SLD, OpenLayers)?

An example can be found in the SLD Cookbook.

<FeatureTypeStyle>
     <Rule>
       <LineSymbolizer>
         <Stroke>
           <CssParameter name="stroke">#0000FF</CssParameter>
           <CssParameter name="stroke-width">1</CssParameter>
           <CssParameter name="stroke-dasharray">10 10</CssParameter>
         </Stroke>
       </LineSymbolizer>
       <LineSymbolizer>
         <Stroke>
           <GraphicStroke>
             <Graphic>
               <Mark>
                 <WellKnownName>circle</WellKnownName>
                 <Stroke>
                   <CssParameter name="stroke">#000033</CssParameter>
                   <CssParameter name="stroke-width">1</CssParameter>
                 </Stroke>
               </Mark>
               <Size>5</Size>
             </Graphic>
           </GraphicStroke>
           <CssParameter name="stroke-dasharray">5 15</CssParameter>
           <CssParameter name="stroke-dashoffset">7.5</CssParameter>
         </Stroke>
       </LineSymbolizer>
     </Rule>
   </FeatureTypeStyle>

Was done for UI and geostyler-sld-parser in #362. Missing in geostyler-openlayers-parser due to not having the possibility of parsing required information bidirectionally.


Catch security and unauthorized access exception while trying to read from file

Summary of the Pull Request
What is this about?
This PR fixes the issue where PT Run crashed when a steam game was being installed.
PR Checklist

[x] Applies to #6896
[x] CLA signed. If not, go over here and sign the CLA
[x] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
Security exceptions and unauthorized access exceptions are caught while trying to create all programs as the file may not be accessible. This catch block is also there for the internet shortcut programs, however they are being read before using the FileSystem wrapper which does not catch the security and unauthorized access exceptions. This PR catches those exceptions and logs it.
Validation Steps Performed
How does someone test & validate?

Changed the security permissions required to access a url file and removed read permissions for the current user.
tried to rename /index the file.
the exception is caught.

#6933 should also fix this (and have a small performance improvement)

/azp run


cannot enable scss-lint checker

I have been trying without success to enable scss-lint. These is how I have been trying:
let g:syntastic_scss_lint_exec='/opt/bin/my-scss-lint'
let g:syntastic_scss_scss_lint_exec='/opt/bin/my-scss-lint'
let g:syntastic_scss_checkers = ['scss_lint']

The exec variables are repeated because I was not sure which syntax was right. The custom binary was just a wrapper that wraps scss with bundle exec and also makes sure that syntastic has a stable binary path
After loading a scss file, verifying that the variables are set and running :SyntasticInfo i see the scss filetype was properly detected, but the list of available and enabled checkers is empty

I also had a similar issue with stylelint, but it turned out I was using a pretty old version of syntastic (I have dropbox sync my .vim/ folder) and the function syntastic#util#getVersion was missing.  A simple cd ~/.vim/bundle/syntastic && git pull fixed it

I got this working by doing:
let g:syntastic_scss_checkers = ['scss_lint']
let g:syntastic_scss_scss_lint_exec = 'bundle'
let g:syntastic_scss_scss_lint_args = 'exec scss-lint'


workflow batch commands tests added

workflow batch commands tests added

bump coverage

local unit testing

Potential risks

Release notes

Documentation Changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: samkitshah1262:x: sam-wbdYou have signed the CLA already but the status is still pending? Let us recheck it.


Fix race condition

There's a race condition in TestAgentStartStop and a deadlock in TestQueue.

Coverage remained the same at 98.941% when pulling c5accee170e2a78f70028a91074cf27cf2384899 on fix_baaaaad_tests into 7e6aa97fbba279f55187a20eecec9d3806b4a1fe on master.

Coverage decreased (-0.6%) to 98.297% when pulling 58b8114231c8ad0a783f6c86b3ffc3d9d07db246 on fix_baaaaad_tests into 7e6aa97fbba279f55187a20eecec9d3806b4a1fe on master.

I gave up on the DeadLock fix, there's some pretty arcane logic there. We'll probably rip it out for something else.

Coverage increased (+0.09%) to 99.029% when pulling 5326c802358fa281fcbca51055d015ba50813c3c on fix_baaaaad_tests into 7e6aa97fbba279f55187a20eecec9d3806b4a1fe on master.

Changes Unknown when pulling 26b768bc8db983017fd42500c95c92965ff5ec2f on fix_baaaaad_tests into ** on master**.


Rework the ObjectFollower into two distinct components that have a single responsibility

At the moment the ObjectFollower script has two distinct functions of making target objects follow a source and a source object follow an active target.
It's more appropriate to have 2 distinct components that handle these functions that can extend a common base.
Notes:
ObjectFollower becomes abstract class that extends SourceTargetProcessor
New simple class for holding relationship between a GameObject and a child offset
GameObjectWithOffsetContainer
  {
  GameObject entity
  GameObject childOffset
  }

  SetEntity(GameObject obj)
  ClearEntity()
  SetChildOffset(GameObject obj) (checks to see if the given obj is a child of entity)
  ClearChildOffset()

SourceTargetProcessor params

Source:Component - can take a GameObject or a GameObjectWithOffsetContainer
Targets:List - can take a collection of GameObjects or GameObjectWithOffsetContainers
Also needs setter/clear for targets list

SetTargetIndex(int)
SetTargetAtCurrentIndex(Component)
SetTarget(int, Component)

At the moment SourceTargetProcessor only offers methods for setting source/target by GameObject, but it should offer Component as well.

ObjectFollower params

FollowModifier - The modifier to process on.

Split out the existing logic into two distinct classes

SourceToActiveTargetFollower

the given source follows the first GameObject that is active in the target list
uses ProcessFirstActiveComponent
the source can be of type GameObject or GameObjectWithOffsetContainer

if the source is GameObject then it is passed to the FollowModifier as the target parameter
if the source is GameObjectWithOffsetContainer then

source.entity is passed to the FollowModifier as the target parameter
source.childOffset is passed to the FollowModifier as the offset parameter

the targets can be of type GameObject

the first active target is passed to the FollowModifier as the source parameter

AllTargetsToSourceFollower

all of the given targets follow the given source GameObject
uses ProcessAllComponents
the source can be of type GameObject

the source is passed to the FollowModifier as the source parameter

the targets can be of type GameObject or GameObjectWithOffsetContainer

if the target is GameObject then it is passed to the FollowModifier as the target parameter
if the target is GameObjectWithOffsetContainer then

target[n].entity is passed to the FollowModifier as the target parameter
target[n].childOffset is passed to the FollowModifier as the offset parameter

Just a note for me to know how to fix interactables with the proposed PR changes:
Fixing Interactable

Expand and select --> InteractionLogic > Grabbing > ChainActions > PrimaryAttachmentLogic > FollowModifier
Set Sources size to 0
Set Targets size to 1
Set TargetOffsets size to 0
Set Target[0] to be the Interactable GameObject
Expand and select --> InteractionLogic > Grabbing > ChainActions > PrimaryAttachmentLogic > AttachmentActions > DoPrimaryGrab > SetupFollow
Change GameObjectEventProxyEmitter ObjectFollower.SetSource to ObjectFollower.SetSourceAtCurrentIndex
Expand and select --> InteractionLogic > Grabbing > ChainActions > PrimaryAttachmentLogic > AttachmentActions > DoPrimaryUngrab > ClearFollow
Change EmptyEventProxyEmitter ObjectFollower.ClearSource to ObjectFollower.ClearSources
Change EmptyEventProxyEmitter ObjectFollower.ClearFollowOffset to ObjectFollower.ClearTargetOffsets
Expand and select --> InteractionLogic > Grabbing > ChainActions > PrimaryAttachmentLogic > AttachmentLogic > PrecisionGrabMode
Change CollisionPointContainer ObjectFollower.SetFollowOffset to ObjectFollower.SetTargetOffsetAtCurrentIndex
Change CollisionPointContainer ObjectFollower.ClearFollowOffset to ObjectFollower.ClearTargetOffsets
Expand and select --> InteractionLogic > Grabbing > ChainActions > PrimaryAttachmentLogic > AttachmentLogic > SnapHandles
Change GameObjectRelations ObjectFollower.SetFollowOffset to ObjectFollower.SetTargetOffsetAtCurrentIndex
Expand and select --> InteractionLogic > Grabbing > ChainActions > PrimaryAttachmentLogic > AttachmentLogic > FollowModifier > PropertyModifiers
Set the GameObjectStateMirror Sources[0] to PropertyModifiers > FollowTransform
Set the GameObjectStateMirror Targets[0] to DoPrimaryGrab > EnableKinematic
Set the GameObjectStateMirror Targets[1] to DoPrimaryGrab > DisableKinematic

Fixed with https://github.com/ExtendRealityLtd/VRTK.Unity.Core/pull/237


feat: Add Fleek to Astro deployment docs

Description (required)
This pull request adds Fleek(https://fleek.xyz/) to the Astro deployment docs as an additional alternative deployment platform for users to deploy their websites.

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
guides/deploy/fleek.mdx
Source added, will be tracked.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Great guide Toby, deployment couldn't be any smoother. Honestly it felt like I am deliberately looking for flaws in the guide, that's how perfect it is. going with blind faith that the CLI works 💯

Thank you Atharva! I appreciate you. I have made all changes from review and updated the PR.

Thank you @tobySolutions for adding a new deploy guide! I have made some minor edits, like missing periods/words, directly and am happy to welcome you to Team Docs! 🥳

Perfect!! Thank you @sarah11918!!! It's an honor to get to chat with you. I have seen a lot of your great work out here and I heard a lot about your work from Sarah on the Solid docs team.

Team Docs is an opt-in role in Astro Lounge. Feel free to jump in there


draft design doc for cloning PVs while remapping namespaces

Signed-off-by: Steve Kriss<EMAIL_ADDRESS>ref. #192
cc @arianitu @agolomoodysaada @robertgates55

Adding the annotation sounds like a good idea

This looks good to me. I also notice that this handles actually cloning the PV so both namespaces will continue to work?
Excited for this to be implemented.

Addressed comments. Is this ready for approval + merge?

Updated to "Approved" so ready to merge unless there are any other comments!

Alright, I think we have lazy consensus - let's merge this


Missing index triggers failures

See

In the example below, lr produces an error about expecting a pair (int, int) but only getting an int.
https://github.com/liquid-rust/examples/blob/main/src/bug/mat-bug-00.rs

In the second example, lr just triggers some fixpoint "elaboration" crash perhaps due to some malformed sorts in the generated constraints.
https://github.com/liquid-rust/examples/blob/main/src/bug/mat-bug-01.rs

@ranjitjhala both errors are caused by the desugaring creating bindings with the wrong sort. There was a bug in the wf checker that let the second one go through, but I fixed that.

Sweet I’ll take a look!
On Tue, Mar 8, 2022 at 2:31 PM Nico Lehmann @.***>
wrote:

@ranjitjhala
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ranjitjhala&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=r3JfTqNkpwIJ1InE9-ChC2ld7xwATxgUx5XHAdA0UnA&m=xmUH8awimVqAy_-dLktkWX9lnOXoiZKxbvbc-GQDhWnPKP_Aw0m27oFWXeERg-t2&s=eHDAv1_Ak4ToUEllkhzMxeLoWiDiEXiXbd_EZ7FezCE&e=
both errors are caused by the desugaring creating bindings with the wrong
sort. There was a bug in the wf checker that let the second one go through,
but I fixed that.
—
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_liquid-2Drust_liquid-2Drust_issues_73-23issuecomment-2D1062285964&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=r3JfTqNkpwIJ1InE9-ChC2ld7xwATxgUx5XHAdA0UnA&m=xmUH8awimVqAy_-dLktkWX9lnOXoiZKxbvbc-GQDhWnPKP_Aw0m27oFWXeERg-t2&s=CDb9v6j-BwmHvrs---F6qHDGtpvCuH7BkQa4ycsAxuQ&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAMS4OB53QNWZ4B4P4THEWDU67IKPANCNFSM5QFKGWDA&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=r3JfTqNkpwIJ1InE9-ChC2ld7xwATxgUx5XHAdA0UnA&m=xmUH8awimVqAy_-dLktkWX9lnOXoiZKxbvbc-GQDhWnPKP_Aw0m27oFWXeERg-t2&s=5or328AlTMciU-qtS8yJ20aPp-8PvFPSYiJdGD8WXK4&e=
.
Triage notifications on the go with GitHub Mobile for iOS
https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=r3JfTqNkpwIJ1InE9-ChC2ld7xwATxgUx5XHAdA0UnA&m=xmUH8awimVqAy_-dLktkWX9lnOXoiZKxbvbc-GQDhWnPKP_Aw0m27oFWXeERg-t2&s=IVFcVnem7HOZSprZzozii51kmYqQqUU3rnBxZ50hpXI&e=
or Android
https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=r3JfTqNkpwIJ1InE9-ChC2ld7xwATxgUx5XHAdA0UnA&m=xmUH8awimVqAy_-dLktkWX9lnOXoiZKxbvbc-GQDhWnPKP_Aw0m27oFWXeERg-t2&s=2Lcro5VU-UmcD1QIjLMwU8w5QhSvp-RgtOwzAozyRNQ&e=.
You are receiving this because you were mentioned.Message ID:
@.***>


Finance Class | Functions of the defined class is not working.

Note

The get_latest_price method is not working properly. Need someone to fix this issue.
https://github.com/Clueless-Community/scrape-up/blob/c7ac4c8a842b9e2fb43f25257cd3902a0a8625f8/src/scrape_up/finance/nse.py#L63

Can I work on this?

Go ahead @karthikbhandary2


Test-PR

@BrahmanapallyNagaraju Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


How to handle with the keyboard?

Hi, how can we handle the keyboard?

Hi! Thank you for your question, it may seem not trivial but indeed it shouldn't be hard
I've created an example in a separate branch, here is the only change in the branch. When we calculate preferredContentSize we should consider keyboard hight along with scrollView.contentSize.
If everything is done right, you should get smooth animation on keyboard (dis)appearance, like in this demo
https://github.com/joomcode/BottomSheet/assets/52037202/385d3c76-7d64-4f39-b8b8-e137d4c4bf2a

I will close it for now, but feel free if you provided example above doesn't work for you


Should 4.2s countdown time be removed while in  MAIN TX & DUAL WATCH mode？

Thanks for your firmware!
Should 4.2s countdown time be removed while in  MAIN TX & DUAL WATCH mode？Because in this mode user always TX on select channel/VFO, so it is not necessary to wait for 4.2s to resume dw mode and ensure TX on the RX channel/VFO.

Hi,
Sorry, what 4.2s countdown time are you talking about?

In DW mode, after the radio receives a signal and the signal ends, the radio will remain on the VFO that just received the signal. According to the code, this time is 4.2 seconds. I’m thinking that in MAIN TX DUAL RX mode, this time doesn't seem to be very necessary.
https://github.com/armel/uv-k5-firmware-custom/blob/0a7e836656c1b66b8f4c2dc1995ab1600b397738/misc.c#L48

Ok. But where is the issue ?
Of course, you're free to change it if you want 😌


Mdadm raid 1 /boot when in use

Otherwise, the system will be unbootable if the first disk is lost.

Yeah, that's a good point. I wasn't sure if I'd be using LUKS in my own usage when I started. I am leaning towards yes, so I'll take a look at this next time I get to coding
Thanks for the feedback!

this has been implemented/merged to the master branch, if you're interested in trying it out, let me know what you think. otherwise I'll close this issue in a few days


Suggest printf usage in README

2 less concatenation operator.

Good call, I'm a fan of these functions :)

Good call, I'm a fan of these functions :)


Make ResultSetMetaData accessible when ResultSet is closed

According to JDBC specs (15.2.5) - ResultSetMetaData instances that were created by a ResultSet that has been closed are still accessible. Removing checkClosed() from SQLServerResultSetMetaData. Fix for #678.

Codecov Report

Merging #685 into dev will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##                dev    #685      +/-   ##
===========================================
+ Coverage     48.06%   48.1%   +0.04%
- Complexity     2571    2574       +3
===========================================
  Files           112     113       +1
  Lines         26582   26561      -21
  Branches       4436    4435       -1
===========================================
+ Hits          12777   12778       +1
+ Misses        11667   11658       -9
+ Partials       2138    2125      -13

Flag
Coverage Δ
Complexity Δ

#JDBC42
48.04% <ø> (?)
2571 <ø> (?)

#JDBC43
47.99% <ø> (-0.07%)
2566 <ø> (-5)

Impacted Files
Coverage Δ
Complexity Δ

...oft/sqlserver/jdbc/SQLServerResultSetMetaData.java
38.21% <ø> (-2.73%)
23 <0> (-1)

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
63.17% <0%> (-0.31%)
0% <0%> (ø)

...c/main/java/com/microsoft/sqlserver/jdbc/Util.java
60.91% <0%> (-0.22%)
88% <0%> (-1%)

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
54.59% <0%> (-0.04%)
0% <0%> (ø)

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
52.48% <0%> (ø)
239% <0%> (ø)
:arrow_down:

.../com/microsoft/sqlserver/jdbc/SQLServerJdbc42.java
40% <0%> (ø)
0% <0%> (?)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
32.78% <0%> (+0.07%)
242% <0%> (+1%)
:arrow_up:

...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java
78.01% <0%> (+0.16%)
5% <0%> (+1%)
:arrow_up:

...oft/sqlserver/jdbc/SQLServerPreparedStatement.java
50.85% <0%> (+0.24%)
157% <0%> (ø)
:arrow_down:

.../microsoft/sqlserver/jdbc/SQLServerDataSource.java
45.66% <0%> (+0.26%)
66% <0%> (ø)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ad308...c19e552. Read the comment docs.


Implement csrf-token in TRPC

Patch #200

I guess I haven't thought too much about it - is it even possible for a CSRF exploit over TRPC?

I mean I guess a lot of the "payload" for TRCP goes into the URL itself and therefore could be CSRF exploitable..

I suppose yes, I guess it is just a more longer url for the exploitation ? aaand it is now equal regardless the internal api uses trpc or not both have csrf-token protection.


Molteo

Title
Molteo is a cloud platform that makes managing construction projects look easy.
Description
Molteo is the cloud software for efficient building with overview. From now on, construction companies can control and optimize everyday work processes in the office easy via the PC and on the construction site quickly via a mobile phone, laptop or tablet.
Molteo provides an easy-to-use tool which provides a real-time overview of projects and construction sites, flexible resource capture, and paperless billing.
Functions: • Personnel planning • Time registration • Calculation • Project management • Payroll • Equipment and material recording • Construction Diary
ps. Product is available in English, Website coming soon.
Website
https://molteo.de/
Image

Crunchbase
https://www.crunchbase.com/organization/molteo
Industries

engineering
construction

Tags:

Web app
iOS
Android
Analysis
Construction Management
Cost Estimation Data Management
Documentation
Cloud
Project Management

Uhhh nice. Thank you


Fix issue with explicit close logic

Fixes issue turned up in QA where explicit close link was not closing reveal.

looks good to me and works


An F* Spec for Kyber and ML-KEM

We already wrote a spec for Kyber in F*.
We need to refine and extend this spec to more closely match the structure of ML-KEM and be suitable for our proofs.

This has the wrong priority and is overdue. @karthikbhargavan please update.

This spec work is done in https://github.com/cryspen/libcrux/pull/475
We will merge this soon and then work more on it if needed for the proofs.

This is done. Awaiting a hax fix before merging.
https://github.com/cryspen/libcrux/pull/475


class Bag(Collection[_T]): is not subscriptable

Some of the unit tests have entries like:
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/unittest/__main__.py", line 18, in <module>
    main(module=None)
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/unittest/main.py", line 100, in __init__
    self.parseArgs(argv)
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/unittest/main.py", line 147, in parseArgs
    self.createTests()
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/unittest/main.py", line 158, in createTests
    self.test = self.testLoader.loadTestsFromNames(self.testNames,
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/unittest/loader.py", line 220, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/unittest/loader.py", line 220, in <listcomp>
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/home/runner/work/DMOD/DMOD/python/lib/client/dmod/test/test_dataset_client.py", line 2, in <module>
    from ..client.request_clients import DataCategory, DatasetClient, DatasetManagementResponse, MaaSDatasetManagementResponse
  File "/home/runner/work/DMOD/DMOD/python/lib/client/dmod/client/request_clients.py", line 2, in <module>
    from dmod.communication import DataServiceClient, ExternalRequestClient, ManagementAction, ModelExecRequestClient, \
  File "/home/runner/work/DMOD/DMOD/dmod_venv/lib/python3.8/site-packages/dmod/communication/__init__.py", line 2, in <module>
    from .client import AuthClient, CachedAuthClient, DataServiceClient, ExternalRequestClient, PartitionerServiceClient, \
  File "/home/runner/work/DMOD/DMOD/dmod_venv/lib/python3.8/site-packages/dmod/communication/client.py", line 14, in <module>
    from .maas_request import ExternalRequest, ExternalRequestResponse
  File "/home/runner/work/DMOD/DMOD/dmod_venv/lib/python3.8/site-packages/dmod/communication/maas_request/__init__.py", line 1, in <module>
    from .utilities import (
  File "/home/runner/work/DMOD/DMOD/dmod_venv/lib/python3.8/site-packages/dmod/communication/maas_request/utilities.py", line 1, in <module>
    from .model_exec_request import ModelExecRequest, get_available_models
  File "/home/runner/work/DMOD/DMOD/dmod_venv/lib/python3.8/site-packages/dmod/communication/maas_request/model_exec_request.py", line 4, in <module>
    from .dmod_job_request import DmodJobRequest
  File "/home/runner/work/DMOD/DMOD/dmod_venv/lib/python3.8/site-packages/dmod/communication/maas_request/dmod_job_request.py", line 7, in <module>
    from dmod.core.meta_data import DataFormat, DataRequirement
  File "/home/runner/work/DMOD/DMOD/dmod_venv/lib/python3.8/site-packages/dmod/core/meta_data.py", line 5, in <module>
    from .common.helper_functions import get_subclasses
  File "/home/runner/work/DMOD/DMOD/dmod_venv/lib/python3.8/site-packages/dmod/core/common/__init__.py", line 22, in <module>
    from .collection import Bag
  File "/home/runner/work/DMOD/DMOD/dmod_venv/lib/python3.8/site-packages/dmod/core/common/collection.py", line 12, in <module>
    class Bag(Collection[_T]):
TypeError: 'ABCMeta' object is not subscriptable
Deactiving active virtual env at /home/runner/work/DMOD/DMOD/dmod_venv

The subscript for Bag(Collection[_T]) just needs to be removed. Bonus points if typing.Generic[_T] is added.

I started to work on this earlier this morning and stumbled into #479. Picking it back up now.

I was planning on just slapping it together in codespaces after the standup if you don't want to deal with it. Should be a quick turnaround. I don't want you to be too sidetracked if it's not necessary.


Possibility to clear field from code?

So, it seems that somehow the values get saved in the editable field, and this messes up the model if i'm for example changing the model from a component.
See GIF for example:

In the GIF, whenever i press the green button, the model gets nulled out to default values.
Is this an unfortunate bug or a direct fault on my side?
Is there any way of emptying the inputfield from code upon for example a save of the data?

Hi @leetal,
Would you to do a little plunkr? Or there's any method that I could see your code?
It could be a bug, I'm not sure because I should to do specs in the future.

I'll write a simple plunkr later today/evening to demonstrate the issue 👍

Hi @leetal,
Thanks very much. I'll fix the bug when I detect it because I've never had this use case ;-)


🚀[FEA]: Modulus Launch and Core integration

Is this a new feature, an improvement, or a change to existing functionality?
Change
How would you describe the priority of this feature request
Medium
Please provide a clear description of problem you would like to solve.
This is a proposal to bring the utilities from Modulus Launch into Modulus core and deprecate a separate pip wheel and dockerfile for the Modulus-Launch repo. The utilites in Modulus launch have matured enough to be widely applicable across different data-driven examples and can be integrated into the core Modulus package. The additional dependencies of Modulus Launch will be handled via the route of optional dependencies, i.e. with a [launch] option in the .toml file. From a user standpoint, the APIs/import statements are not affected as namespace packaging is adopted across the Modulus repos.
Describe any alternatives you have considered
No response

Done in linked PR. Closing


move functions to cluster builder

Moves functions to cluster builder so that http2protocol options deprecation can be done.
Pre cursor to https://github.com/istio/istio/pull/31273
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@hzxuzhonghu PTAL

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ce9066f9b720242f9ebb7737848479dda6ad5087
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio


feat(now): implement now() in batch

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Enable batch system to evaluate NOW() as a function instead of an operator.
result before this PR:
dev=> select now();
ERROR:  QueryError: internal error: Failed to build executor: Expr error: Unsupported function: Ok(Now)

result after this PR:
test result:
dev=> select now();
          ?column?
----------------------------
 2023-01-03 08:01:52.304273
(1 row)

dev=> create table t (v1 int);
CREATE_TABLE
dev=> create materialized view mv as select now() as nw from t where v1 >= 3;
ERROR:  QueryError: internal error: Rpc error: gRPC error (Internal error): Expression error: Expected session timestamp bound into Now
dev=> create table tt(v1 int, t1 timestamp);
CREATE_TABLE
dev=> create materialized view mv as select * from tt where tt.t1 > now() - INTERVAL '1 hour';
CREATE_MATERIALIZED_VIEW

We insert a session timestamp into arguments of NOW(), which will only be used in batch system.
Checklist

[x] I have written necessary rustdoc comments
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
#7139

dev=> select now();
ERROR:  QueryError: internal error: Failed to build executor: Expr error: Unsupported function: Ok(Now)

Is it intended?

In the PR description:
dev=> select now();
ERROR:  QueryError: internal error: Failed to build executor: Expr error: Unsupported function: Ok(Now)

Is it intended?

PR description updated.
That should be result before this PR.

test result:
dev=> select now();
          ?column?
----------------------------
 2023-01-03 08:01:52.304273
(1 row)

dev=> create table t (v1 int);
CREATE_TABLE
dev=> create materialized view mv as select now() as nw from t where v1 >= 3;
ERROR:  QueryError: internal error: Rpc error: gRPC error (Internal error): Expression error: Expected session timestamp bound into Now
dev=> create table tt(v1 int, t1 timestamp);
CREATE_TABLE
dev=> create materialized view mv as select * from tt where tt.t1 > now() - INTERVAL '1 hour';
CREATE_MATERIALIZED_VIEW

Once we intend to support now(), we are better to consider it with the timezone. PostgreSQL has a session variable TimeZone to allow users to set the time zone for displaying and interpreting time stamps.
tpch=# select now();
              now
-------------------------------
 2023-01-03 16:24:21.178595+08
(1 row)

tpch=# set timezone = 'UTC';
SET
tpch=# select now();
              now
-------------------------------
 2023-01-03 08:24:48.025885+00
(1 row)

Once we intend to support now(), we are better to consider it with the timezone. PostgreSQL has a session variable TimeZone to allow users to set the time zone for displaying and interpreting time stamps.
tpch=# select now();
              now
-------------------------------
 2023-01-03 16:24:21.178595+08
(1 row)

tpch=# set timezone = 'UTC';
SET
tpch=# select now();
              now
-------------------------------
 2023-01-03 08:24:48.025885+00
(1 row)

Should we use Timestamptz?

Once we intend to support now(), we are better to consider it with the timezone.

Hmm, will the epoch be aware of this timezone (i.e. it is configured to start from UTC 0?)
Should the stream also be aware of this timezone? How does cmp between timestamp with timezone and timestamp work?

Once we intend to support now(), we are better to consider it with the timezone.

Hmm, will the epoch be aware of this timezone (i.e. it is configured to start from UTC 0?)
Should the stream also be aware of this timezone? How does cmp between timestamp with timezone and timestamp work?
I guess the stream case does not require timezone if it assumes that the timestamp column and the result of now() share the same timezone?

I think our epoch originally from UNIX timestamp is time zone independent (UTC). However, when we are trying to display it to users, they have their own timezone which could be modified by TimeZone session variable as well.

Once we intend to support now(), we are better to consider it with the timezone. PostgreSQL has a session variable TimeZone to allow users to set the time zone for displaying and interpreting time stamps.
tpch=# select now();
              now
-------------------------------
 2023-01-03 16:24:21.178595+08
(1 row)

tpch=# set timezone = 'UTC';
SET
tpch=# select now();
              now
-------------------------------
 2023-01-03 08:24:48.025885+00
(1 row)

Should we use Timestamptz?

Yes. If we provide a now() function, it will be definitely used by users to insert data to our system. We need to make sure it has a clear definition, e.g. which timezone it belongs to and how we interpret a timestamp.

Here I give an example I think we need to support. now() should return a timestamp with time zone, even if we don't allow the user to modify the timezone session variable at this moment.
create table tz (a timestamp with time zone);
insert into tz values(now());

Once we intend to support now(), we are better to consider it with the timezone. PostgreSQL has a session variable TimeZone to allow users to set the time zone for displaying and interpreting time stamps.
tpch=# select now();
              now
-------------------------------
 2023-01-03 16:24:21.178595+08
(1 row)

tpch=# set timezone = 'UTC';
SET
tpch=# select now();
              now
-------------------------------
 2023-01-03 08:24:48.025885+00
(1 row)

Should we use Timestamptz?

Yes. If we provide a now() function, it will be definitely used by users to insert data to our system. We need to make sure it has a clear definition, e.g. which timezone it belongs to and how we interpret a timestamp.

but now() in stream is timestamp without time zone...

One of the most scenarios of batch now() is used to insert the current timestamp (with timezone) into a table. This behavior is also compatible with PostgreSQL.  I think streaming now()  can also return a timestamp with UTC timezone. cc @fuyufjh .

One of the most scenarios of batch now() is used to insert the current timestamp (with timezone) into a table. This behavior is also compatible with PostgreSQL. I think streaming now() can also return a timestamp with UTC timezone. cc @fuyufjh .

I have just implemented Timestamp now() in streaming and Timestamptz now() in batch. seems we can have this at the moment

Here I give an example I think we need to support. now() should return a timestamp with time zone, even if we don't allow the user to modify the timezone session variable at this moment.
create table tz (a timestamp with time zone);
insert into tz values(now());

Could you please add this case to the e2e test?

done

Insert into a table column without timezone will cause panic now.
create table t (a timestamp);
insert into t values(now());

Is there any implicit cast which we can utilize?

create table t (a timestamp);

I find a related issue https://github.com/risingwavelabs/risingwave/issues/5826. In our case, it need to convert timestamptz to timestamp.

Insert into a table column without timezone will cause panic now.
create table t (a timestamp);
insert into t values(now());

fixed

fixed

I don't think that implicit cast to UTC+0 works here. As pointed out in the tracking issue https://github.com/risingwavelabs/risingwave/issues/5826, we require the implicit timezone to be implemented.
So for batch, we require:
set time zone = 'UTC+8'
create table t (a timestamp);
insert into t values(now());
select *, now() from t;

Result:
'2023-01-04 11:25:00' | '2023-01-04 03:25:00Z'

I think streaming now() can also return a timestamp with UTC timezone.

Indeed. It should be a timestamptz not timestamp.
To compare against timezone, performed by the MV should cast timestamp -> timestamptz with the session timezone.
So for instance:
set timezone = 'UTC+8';
create table t (ts timestamp);
select * from t where ts >= now();

plan pseudocode:
DynamicFilter { ts >= now() }
  Project { ts::timestamp with time zone("UTC+8") }
  Now { now (UTC) }

In order to more finely control the timezone of their timestamp column, the user should cast their timestamp to a specific timezone.
Data collected in UTC+8, session timezone is UTC-8:
create table t (ts timestamp);
select * from t where ts at time zone 'UTC+8' >= now();

This PR doesn't introduce session timezone, so session timezone can be assumed as 'UTC+0' and can't be modified now. Session timezone is important to batch and streaming now() and we need to supported it later.

MV should cast timestamp -> timestamptz with the session timezone at the time of its creation.

I doubt whether MV should cast timestamp -> timestamptz with the session timezone at the time of its creation.

I doubt whether MV should cast timestamp -> timestamptz with the session timezone at the time of its creation.

It's definitely worth discussing. Note that for batch, psql will cast timestamp to the session timezone. We may forbid such a cast for streaming in order to force the user to explicitly convert their timestamp to a given timezone. I think this semantic may be clearer?

fixed

I don't think that implicit cast to UTC+0 works here. As pointed out in the tracking issue #5826, we require the implicit timezone to be implemented.
So for batch, we require:
# defaults to local time zone
set timezone = 'UTC+8';
create table t (a timestamp);
insert into t values(now());
set timezone = 'UTC+0';
select *, now() from t;

Result:
'2023-01-04 11:25:00' | '2023-01-04 03:25:00+00'

I think we should remove the cast for now.

I think streaming now() can also return a timestamp with UTC timezone.

Indeed. It should be a timestamptz not timestamp.
To compare against timestamp without time zone, MV should cast timestamp -> timestamptz with the session timezone at the time of its creation.
So for instance:
set timezone = 'UTC+8';
create table t (ts timestamp);
select * from t where ts >= now() - interval '1 h';

plan pseudocode:
DynamicFilter { ts >= now() }
  Project { Cast(ts at time zone 'UTC+8') }
  Now { now (UTC) }

In order to more finely control the timezone of their timestamp column, the user should cast their timestamp to a specific timezone.
Data collected in UTC+8, session timezone is UTC-8:
create table t (ts timestamp);
select * from t where ts at time zone 'UTC+8' >= now() - interval '1 h';

ok. Now I switch streaming now into timestamptz too.
Should I revert the cast from timestamptz to timestamp? @chenzl25


Center crop ImageProcessor

Issue #320 talks about a crop image processor.
Do you think a center crop image processor fits into the current collection of core processors?

Sure, it could be a great improvement! Do you have time to implement it? (or I will handle it later since I'm getting quite busy for now)

I can certainly take a crack at it, with a warning that I just started using swift ;)
Do you think it makes more sense as a separate ImageProcessor, or possibly as part of options passed to the current resize processor?

I believe it would be better to be a new one :)

With crop anchor as parameter, and center as its default value.

I'd love to help out with this. Our Android team is using Glide, which implements a similar centerCrop transform.
Might help to take a look at:
https://github.com/bumptech/glide/blob/6ddb5f0598b1a5a5a51647fb968e998d6cabbd3d/library/src/main/java/com/bumptech/glide/load/resource/bitmap/CenterCrop.java

I put together a quick centre crop processor that I needed for my app, posting it here for anyone that might need it. I have not implemented the anchor yet, if I do I'll create a pull request. :) (P.S.: The code was found on stack overflow, I just put it in an ImageProcessor)
import Foundation
import Kingfisher

/// Processor for cropping the center of an image
public struct CenterCropImageProcessor: ImageProcessor {
		public let identifier: String

		/// Center point to crop to.
		public var centerPoint: CGFloat = 0.0

		/// Initialize a `CenterCropImageProcessor`
		///
		/// - parameter centerPoint: The center point to crop to.
		///
		/// - returns: An initialized `CenterCropImageProcessor`.
		public init(centerPoint: CGFloat? = nil) {
			if let center = centerPoint {
				self.centerPoint = center
			}
			self.identifier = "com.l4grange.CenterCropImageProcessor(\(centerPoint))"
		}

		public func process(item: ImageProcessItem, options: KingfisherOptionsInfo) -> Image? {
			switch item {
			case .image(let image):

				var imageHeight = image.size.height
				var imageWidth = image.size.width

				if imageHeight > imageWidth {
					imageHeight = imageWidth
				}
				else {
					imageWidth = imageHeight
				}

				let size = CGSize(width: imageWidth, height: imageHeight)

				let refWidth : CGFloat = CGFloat(image.cgImage!.width)
				let refHeight : CGFloat = CGFloat(image.cgImage!.height)

				let x = (refWidth - size.width) / 2
				let y = (refHeight - size.height) / 2

				let cropRect = CGRect(x: x, y: y, width: size.height, height: size.width)
				if let imageRef = image.cgImage!.cropping(to: cropRect) {
					return UIImage(cgImage: imageRef, scale: 0, orientation: image.imageOrientation)
				}

				return nil

			case .data(_):
				return (DefaultImageProcessor.default >> self).process(item: item, options: options)
			}
		}
}

@L4grange Good job! I'll take a look at it to see whether we could implement a built-in crop processor based on this.

Cropping image is implemented in #630 now.

how i can crop image @onevcat many thank for support, great respo!

Just create a CroppingImageProcessor and pass it as an option to setImage methods. Please have a look at our wiki for more.


Drag selection with mouse results in two undo entries

If you select something, then left-drag it somewhere else, it takes two Ctrl+Z to revert the change (should be just one)

Fixed.


Eye targeting not working with near hand pointers enabled anymore

Describe the bug
Hand focus breaks BaseEyeFocusHandler in Unity Editor (did not test on device).
Edit: I noticed that after I remove all of the "Articulated Hand" pointers, namely PokePointer and GrabPointer, the expected behavior would work again: Look at a target and use airtap to select it. I had already removed the DefaultPointer (causing the hand ray to show up) a while ago, because it interferred with eye targeting as soon as a hand would be detected. However, so far, it was still possible to use "Look & tap" for far and poke and grab for near interactions. This is not possible anymore.
To reproduce
Steps to reproduce the behavior:

Load EyeTrackingDemo-00-RootScene
Hit play
Move eye cursor over a gem by pressing right mouse button and moving mouse. The gem should start rotating.
Press Space to show hands. The rotation stops. An airtap does not cause the gem to be selected.
Release Space to hide hands. Eye targeting via BaseEyeFocusHandler remains broken.

Expected behavior
Look at a gem and select it via airtap.
Your Setup (please complete the following information)

Unity Version [e.g. 2018.4.0f1]
MRTK Version [e.g. last updated 05/16/19 - 1:43 PM]

Target Platform (please complete the following information)

HoloLens
HoloLens 2
WMR immersive
OpenVR

Additional context
Current Input Profile setting that seems to work for "look & tap":

Okay, figured out what's going on here - after this PR went in:
https://github.com/microsoft/MixedRealityToolkit-Unity/pull/4270
It looks like this was also causing the new-eye-tracking-style-gaze-provider to also get disabled once hands were in the picture, and you had to say "select" in order to bring them back.
It looks like the intent here is for eye gaze scenarios, we want to go back to what it was before (i.e. if any far interactions active, disable eye gaze, near interactions don't really matter)


sway-beta module: prevents cli args from getting to sway

Issue description
The wrapper around sway in the sway-beta module prevents the usage of cli args with sway, particularly flags for debugging, help, etc.
Steps to reproduce
# activate the sway-beta module
sway --help

Notice that it just starts instead of displaying the help...
Technical details
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.

cc: @gnidorah @primeos Is there a reason that pkgs.writeShellScriptBin is used instead of something like makeWrapper ?

No special thinking, I just don't know how to write it using makeWrapper. How to write ifs with it?
@bbigras change is wrong, because we don't need to run it via dbus-launch each time, only on the start, in the same manner there is no need to set environment every time. The proper way should be:
  swayWrapped = pkgs.writeShellScriptBin "sway" ''
    if [[ "$#" -ge 1 ]]; then
      exec sway"$@"
    else
      ${cfg.extraSessionCommands}
      exec ${pkgs.dbus.dbus-launch} --exit-with-session sway
    fi
  '';


PSF Deconvolution and  more PSF cupy optimizations - [merged]

In GitLab by @wtbarnes on Feb 27, 2020, 14:45
Merges psf-gpu-again -> master
Fixes #33
RE calculating the PSF, I got a 20% performance boost (down to just over 8 s for a single channel!) by doing the FFT calculations with cupy and not casting back to numpy until the very end.

In GitLab by @wtbarnes on Feb 27, 2020, 16:07
added 2 commits
a1baf028 - clarify comment56beea9c - first pass at RL deconvolution; currently broken
Compare with previous version

In GitLab by @wtbarnes on Feb 27, 2020, 15:12
marked as a Work In Progress

In GitLab by @wtbarnes on Feb 28, 2020, 10:24
I've gotten a working version of the RL deconvolution algorithm with cupy, aiapy.psf.deconvolve. It accepts a sunpy Map and optionally a PSF (if you don't pass one, it is calculated automatically) and spits out the deconvolved image in a sunpy Map.
Using cupy on my machine, I can do the full-frame deconvolution in about 800 ms with 25 iterations. The same calculation with numpy takes about 28 s. Calculating both the PSF and doing the deconvolution takes about 9 s in total with cupy.
@markcheung I essentially just copied your RL implementation out of your colab notebook. One question: why is it necessary to apply np.roll to the PSF again befor deconvolving? It seems like the opposite operation is already done when calculating the PSF?

In GitLab by @wtbarnes on Feb 28, 2020, 10:17
added 1 commit
a31eff86 - psf fft bugfix; roll psf in both axes
Compare with previous version

In GitLab by @wtbarnes on Feb 28, 2020, 11:48

Nice. I guess I may have had the np.roll there  because some earlier version of the PSF routine returned PSFs centered at (2048,2048) instead of (0,0)?

When I don't include the roll in the deconvolution function, I get out very strange deconvolved image:

Should we drop the roll in the PSF calculation?

It's important to keep things in device memory and do as few transfers between device and host as possible because of the latency.

Yes, that's what saved me the additional two seconds on the PSF calculation. I think I have all of the transfers down to a minimum in both functions.

Please include a reference to Cheung 2015 (https://on-demand-gtc.gputechconf.com/gtcnew/sessionview.php?sessionName=s5209-gpu-accelerated+imaging+processing+for+nasa's+solar+dynamics+observatory) in docstring for cuda speedup.

:thumbsup:

In GitLab by @markcheung on Feb 28, 2020, 11:34
Nice. I guess I may have had the np.roll there (https://colab.research.google.com/drive/1tHC9lU8S9Gy2ROLCh6Eej-LlJQetDzra) because some earlier version of the PSF routine returned PSFs centered at (2048,2048) instead of (0,0)?
It's important to keep things in device memory and do as few transfers between device and host as possible because of the latency.
RL application is a very nice example of speeding up scientific computation on the GPU because we are doing many iterations on the same memory on the device.
Please include a reference to Cheung 2015 (https://on-demand-gtc.gputechconf.com/gtcnew/sessionview.php?sessionName=s5209-gpu-accelerated+imaging+processing+for+nasa's+solar+dynamics+observatory) in docstring for cuda speedup. Even though we were't using cupy then it's the same technique.

In GitLab by @wtbarnes on Feb 28, 2020, 12:14
added 2 commits
198f3fdf - intersphinx mapping for cupye521ec55 - fix up docstrings
Compare with previous version

In GitLab by @markcheung on Feb 28, 2020, 13:06
Anyway, the way the deconvolution is implemented, the PSF needs to be centered at (0,0). That's the reason for the np.roll applied to the PSF that is image-centered.

In GitLab by @wtbarnes on Feb 28, 2020, 12:34
added 1 commit
0e7cfb1f - cleanup comments on np.roll
Compare with previous version

In GitLab by @markcheung on Feb 28, 2020, 13:05
The original IDL code gave PSFs centered in the center of the image. So let's keep it that way. The np.roll function isn't too much overhead.

In GitLab by @wtbarnes on Mar 2, 2020, 08:37
Needs a test, but then it should be good to go

In GitLab by @wtbarnes on Mar 4, 2020, 15:41
added 2 commits
c1ee99c6 - move around some fixtures0f229a72 - add deconvolve test; make psf module level fixture
Compare with previous version

In GitLab by @wtbarnes on Mar 4, 2020, 20:25
mentioned in commit 377cf773417f9c92ac891f1d7c00008419025018

In GitLab by @wtbarnes on Mar 4, 2020, 17:57
added 1 commit
fa5f97ec - dont look for tests in generated gallery
Compare with previous version

In GitLab by @wtbarnes on Mar 4, 2020, 15:58
added 1 commit
eccee640 - skip deconvolve test with full psf if cupy not installed
Compare with previous version

In GitLab by @wtbarnes on Mar 4, 2020, 20:24
unmarked as a Work In Progress

In GitLab by @wtbarnes on Mar 23, 2020, 13:30
mentioned in commit 50cfc13cc982e3737ce7963d312754f2a9cae2bc

In GitLab by @wtbarnes on Mar 4, 2020, 20:25
merged


image, film, link for wysiwyg(quilljs)

Hello,
thanks for amazing admin panel, neither the wysiwyg editor nor the admin panel itself does not have image upload functionality which is vital.On the other hand, the editor lacks some features like image, film and link functionality. is there a way to add these functionalities to my panel ?
thanks for any assistance,

Hi once again, I have used DropZone and it works properly thanks for great docs but I still think that film , link and image for editor is a must would be appreciated for any help

Hi @Amixengineer - glad you like it so far :)
Regarding the quill editor - currently there is no easy way of modifying its behavior via admin-bro-options. The only thing you can do right now is to write your own edit component for your property (https://adminbro.com/tutorial-customizing-resources.html - section: { [propertyName].components } property appearance)
original quill component is here - you can use it as a starting point.

thanks for your replay
look here I have copied content from a webpage which have some linking words onto them and pasted to the editor. magically the links for the words remained!!!!!!!!

https://www.youtube.com/watch?v=7WtKcFqJHho&t=320s
thanks for comprehensive explanation of file upload.

np - glad you liked it


[MINOR] Fix and enhance the spark session example

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

No
How was this patch tested?

closed by https://github.com/apache/spark-connect-go/pull/54


Update README

Signed-off-by: Alessandro Comodi<EMAIL_ADDRESS>Fixes #5

I was wonder if this would be better called "symbiflow-tools-data-manager"? It doesn't really manage packages but the data required by the packages right?

@mithro Agreed. I think also that manager might be incorrect as well, as this does not manage data, but it is rather a helper to get the data.
Maybe symbiflow-tools-data-fetcher?

I think manager in the name is good -- we should expand the tool to understand what has been downloaded. (IE You have all the artix line available, etc).

@mithro Ok, I'll proceed with renaming the repo than (and the README as well)

BTW -- I'm thinking this tool should probably be included as part of the symbiflow_XXXX (synth/place/etc) tooling?


Jupyter notebook example

Could you let me know how to use it in Jupyter notebook.
Should I add something to lightgbm package ?
Can u add an example

Original "lightgbm" provides a good python API, which you can refer for using it in jupyter.
https://lightgbm.readthedocs.io/en/latest/Python-Intro.html
Thus, compile the files we provide, then you can use our code in Jupiter.
I will consider adding a test python code sooner for illustration, but you can first have a quick try.

Step 1 : cd Unbiased_LambdaMart
mkdir build ; cd build
cmake ..
make -j4
step 2: import lightgbm as lgb
is this the order?

I was able to compile.
 Now how to call this in a notebook. I tried doing
import lightgbm as lgb
error: ModuleNotFoundError: No module named 'lightgbm'
could you help

Sorry about previous mistake. I checked the python interface, and find that there are some parts need to be modified to adapt our changes. I will fix this issue as soon as possible.
Meanwhile, I also find a really simple script for you to run. After you compile the model, you can find a compiled "lightgbm" file. Move this file into "examples/lambdarank", then execute it by:
./lighgbm --config="train.conf"
And you can see the log and the trained model.
Using the jupyter is exactly the same as modifying "train.conf", so you can have a try before I modify the python interface.

Hey @acbull, thanks for contributing the great Unbiased LambdaMart. May I know if there's any update on the python API? Thanks!


Trainer ignores CUSTOM_CACHE_REPO and doesn't enable caching

The env var CUSTOM_CACHE_REPO is being ignored by Trainer. It doesn't matter if you export it before or add it to the torchrun command.
The only way to activate caching while training is with: optimum-cli neuron cache set ... before torchrun.
But when working with containers & SageMaker it is not possible to invoke optimum-cli before torchrun is executed.

Fixed in the latest version: 0.0.10


[TVer] Support series URL

e.g.)
yt-dlp https://tver.jp/series/srtxft431v --get-filename
yt-dlp https://tver.jp/series/sru35hwdd2 --get-filename

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Description of your pull request and other information
Series URL is unique for each TV show and includes all available episode URLs. This is expected to work like an auto-updating playlist.

Based on my current understanding, I think I have submitted the best I can write. Having said that, I may not have understood  _TESTS and  self.playlist_result well.


How to config custom DrawerNavigator DrawerItems with ScrollView

import { DrawerNavigator, DrawerView } from 'react-navigation';

const contentComponent = (props) => (
    <ScrollView>
        <DrawerView.Items {...props} />
    </ScrollView>
);

const navigator = DrawerNavigator(routeConfig, {
    ...
    contentComponent,
    ...
});

Please close don't forget to close this issue if this solution solves your problem.

Had the same problem, and your proposition fixed the issue.
The fact is the https://reactnavigation.org website is based upon the master branch, thus said to use DrawerItems, but this is due to #1219 which append after the latest beta release (beta.8).
Maybe it is just a matter of days before the 1.0 stable is released, but if not, and if it's easy to do, the website should use the latest release tag.

Yes this is being discussed already https://github.com/react-community/react-navigation/issues/1060

Ok,thanks

Check out<EMAIL_ADDRESS>Hoping it helps in figuring out how to customise the drawer navigator.


Code bug in _getcwd sample

This line
printf("%s \nLength: %d\n", dir, strnlen(dir));
has 2 errors:
error C2660: 'strnlen': function does not take 1 arguments

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 26a72576-a0f9-aabb-840f-a521b92d7ec9
Version Independent ID: e892325a-273a-86dd-b01d-13cb4675cd25
Content: _getcwd, _wgetcwd
Content Source: docs/c-runtime-library/reference/getcwd-wgetcwd.md
Product: visual-cpp
Technology: cpp-ucrt
GitHub Login: @corob-msft
Microsoft Alias: corob

@BCG-Jackson
Yes, that's an issue; well spotted, thanks. I've updated the sample a bit to compile cleanly in the latest C and C++ environments. It should be visible in tomorrow's published updates.


Create SECURITY.md

Create SECURITY.md based on the Microsoft best practice

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (726d49e) 92.97% compared to head (17c1aeb) 92.97%.

:exclamation: Current head 17c1aeb differs from pull request most recent head 68b90a1. Consider uploading reports for the commit 68b90a1 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   92.97%   92.97%
=======================================
  Files          16       16
  Lines        6007     6007
=======================================
  Hits         5585     5585
  Misses        422      422

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@Hexagon I've added protections to the main branch and need your approval here - want to give it a shot? 👍


Use charstring as plain text when lengthIV is -1.

Fixes #7769

/botio test

Also fixes #8644

/botio makeref


[Feature]: Developers should be able to create routes in a space only if they are SpaceDevelopers

Background
As an admin
I want to assign the SpaceDeveloper role to the users I trust
So that they can push apps to their spaces
Acceptance Criteria
GIVEN two spaces space1 and space2 exist
AND mgr has a RoleBinding to the SpaceManager ClusterRole in space1
AND dev has a RoleBinding to the SpaceDeveloper ClusterRole in space1

WHEN I create a route in space1 as dev
THEN I see it working
WHEN I create a route in space1 as mgr
THEN I get the following response:HTTP/1.1 403 Forbidden
Content-Type: application/json

{
  "errors": [
    {
      "code": 10003,
      "title": "CF-NotAuthorized",
      "detail": "You are not authorized to perform the requested action"
    }
  ]
}

WHEN I create a route in space2 as dev
THEN I get the following response:HTTP/1.1 403 Forbidden
Content-Type: application/json

{
  "errors": [
    {
      "code": 10003,
      "title": "CF-NotAuthorized",
      "detail": "You are not authorized to perform the requested action"
    }
  ]
}

Dev Notes

Create route needs RBAC.
Get domain and get space already have RBAC.
e2e tests

@gcapizzi we merged the changes for this story, but wanted to call out that the A/C in the story appears incorrect.
In the case where the user has no rights to the space, we believe that the API should return 422 Unprocessable Entity in order to be consistent with other endpoints that refer to the space within the request message body. That was what the handler was already doing, so we left that behavior in place.
Please feel free to reject the story if we've got that wrong. Thanks!
cc @clintyoshimura

@julian-hj I've just checked this on a CF-on-VMs and you're absolutely right, I'll fix acceptance!

@julian-hj I double-checked this during acceptance and it looks like:

if the space exists but the user is not authorised in it, you'll get 403 Forbidden;
if the space doesn't exist, you'll get 422 Unprocessable Entity.

So CF-on-VMs effectively leaks space existence, which I don't think is a great idea. I'd prefer to just always return 422 Unprocessable Entity, even if the space exists. @tcdowney thoughts?

Accepting this with the behaviour described in the comment above.


[microTVM] move function prototypes from lib0.c to an include file

Now that we have --interface= target string flag, it's possible to wind up in a bad situation with two different styles of function prototypes:
lib0.c:
TVM_DLL int32_t tvmgen_default_fused_multiply_add(TVMValue* args, int* type_code, int num_args, TVMValue* out_value, int* out_type_code);

lib1.c:
TVM_DLL int32_t tvmgen_default_fused_multiply_add(void* arg0, void* arg1, void* arg2) {

target string used: "c -keys=cpu -link-params=1 -model=host -runtime=c -system-lib=1 -unpacked-api=1"
the action item here is to move the prototype from lib0.c into a header file which is included by both files.
cc @guberti @Mousius

This issue exists on https://github.com/guberti/tvm/commit/61a0a392af5dd20d44f6974f975335a8d4da859d.

I think this has always been the case, at least with AOT? --system-lib=1 also generates normal packed function prototypes without resource_handle:
TVM_DLL int32_t tvmgen_default_fused_layout_transform(TVMValue* args, int* type_code, int num_args, TVMValue* out_value, int* out_type_code);

Whereas the actual operators have resource_handle:
TVM_DLL int32_t tvmgen_default_fused_layout_transform(void* args, void* arg_type_ids, int32_t num_args, void* out_ret_value, void* out_ret_tcode, void* resource_handle) {

This applies whenever you use -system-lib=1. I'm unsure if the correct solution is moving the prototypes to another header or just providing the correct prototypes in the metadata module, it doesn't seem necessary to expose this outside of the .c files?


feat(browser): add support for loading epub from url

:tada: This PR is included in version 1.35.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add support for Python 3.9

Add GitHub Action unit testing of Python 3.9 and add to our supported
list of Python versions.
Signed-off-by: Eric Brown<EMAIL_ADDRESS>

@ericwb it seems like you forked from an old version of master and as if GitHub was configured to want you to update this first.


Ping/Pong

Hello guys,
These are more general question, rather than issue (sorry not sure if this is the correct space, but reading other issues here get more confused).

Should the client manually send ping to server ("to keep connection alive")? Asking because in some issues was mentioned that is handled by StarScream Suggest automatic ping but in another issue is mentioned that should send ping (Suggest manual ping)

.....
// Called when the socket is connected (delegate)
func startPingTimer() {
        stopPingTimer()
        pingTimer = Timer.scheduledTimer(withTimeInterval: 2.0, repeats: true) { [weak self] _ in
            self?.sendPing()
        }
}
.....

Is it there a suitable interval for ping? (I think that 2.0 seconds could cause a lot of overhead like in my example above)

In case the ping is send by Starscream, at what interval?

If the application move to background should continue the ping to the server or should stop it? (i have voip background mode)

Hi,

It depends on how you ws-server configured. If your server sends general ping frames to the client, so Starscream will automatically respond with pong frames. If your ws-server configured to listen to ping frames sent by the client and answer with pong, so you need manually handle ping writes.

Again, it depends on your server settings. I think It should be at least twice often than your ws-server timeout. E.g. if the server has a timeout 10 seconds, so client should send ping frame every 5 seconds. It should cover all cases with network delay (ping to server) etc. Also, your timeout settings may depends on use-cases. E.g. how fast you need to know, that the client disconnected? We send ping every 30 secs and we didn't face any issues.

Correct me if I am wrong, but as I know, Starscream doesn't send ping automatically. He can only respond with pong frame in automatic mode.

I don't know what you trying to achieve. But in our case, we force disconnect WS when application moved to the background. After application moved in active state we have a mechanism to obtain possible missed events. Also, you can check connection handling and communication protocols in other large applications. Personally, I like how it's done in discord.