[Bug][Regression]: CMSIS-Toolbox 2.7.0 breaks build with linker region headers generated by executes statements

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
projmgr rejects projects where linker region files are not found before building, even if those files would be generated by executes statements in CMake.
This behaviour was last changed in devtools#1882
Expected Behavior
projmgr should not reject projects where linker region files are not found before building if those files would be generated by executes statements in CMake. Alternatively, there should be a way to portably include generated files in the linker script preprocessing step, such as by adding include directories for the linker script preprocessing step.
The previous behaviour in cmsis-toolbox 2.6.1 (warning if such files are missing) was fine since the build was not actually stopped, and worked properly after the first build.
Steps To Reproduce
This change breaks projects that generate their own region headers with an executes statement, for example:
project:
  ...
  linker:
    - script: linker_script.sct.src
    - regions: $SolutionDir()$/common/include/project/generated/flash_layout.h
  ...
  executes:
    - execute: generate-flash-layout-header
      run: python $input(0)$ -o $output$
      input:
        - $SolutionDir()$/scripts/generate_flash_layout_header.py
        - $SolutionDir()$/scripts/flash_layout.py
      output:
        - $SolutionDir()$/common/include/project/generated/flash_layout.h
  ...

If $SolutionDir()$/common/include/project/generated/flash_layout.h doesn't already exists before the build is started, the build fails with error csolution: specified regions header was not found.
Affected tools

[X] cbuild
[X] cbuild2cmake
[ ] cpackget
[ ] csolution
[ ] packchk
[ ] svdconv

Affected operating systems

[ ] Windows amd64
[ ] Windows arm64
[X] Linux amd64
[ ] Linux arm64
[ ] MacOS amd64
[ ] MacOS arm64

Environment

Arch Linux
CMSIS-Toolbox 2.7.0 and armclang 6.21.0 as distributed by vcpkg

An alternative to using linker region files for this would be including the generated file in the preprocessing step from the linker .sct.src file, though there is currently no way to add additional include paths to the linker script preprocessing step.

This can be workarounded by touch-ing the generated region files prior to building, though that can sometimes influence whether CMake thinks the file is up-to-date. It works as a workaround for our project until 2.8.0 releases however.

This doesn't look like it is trivial to fix for a few reasons:

just adding a check for && !IsCreatedByExecute(regionsHeader, context.csolution->directory) in PrjMgrWorker::CheckAndGenerateRegionsHeader() is not enough, since PrjMgrWorker::ProcessExecutes() is called after PrjMgrWorker::CheckAndGenerateRegionsHeader().
changing that order in PrjMgrWorker::ProcessContext() is also not enough since solution level executes are not handled by default in PrjMgrWorker::ProcessExecutes()
adding ret &= ProcessExecutes(context, true); breaks the build somewhere later in CMake since executes from multiple contexts end up in the CMake multiple times.


Optionally use counterparty outpoints in dispute resolution

Coverage increased (+0.1%) to 34.761% when pulling a108f6de2ad126aeca15ee55bcfb6c38470a4732 on 1117-use-valid-outpoints-dispute-resolution into f9a6199ea9b65d06f114d9bb784bc1be09235ec4 on master.

@cpacia Fixed.


Fix the bug when no restaurants exist in the DB

Nice dude! You're learning quick. Solid test and fix.

Thanks! I'm learning ;)
I actually wasn't sure if that was the best fix. I have a feeling there's a more elegant fix. I need to spend more time with Django to figure out all the options. :)


ledger: Update local btchip-python

Updates our local copy of btchip-python with modifications for our usage of it.

I verified that 3b76baf49da4a7abda36600853836412e6193c82 updates 4 files to match the v0.1.31 of upstream:
diff btchip-python/btchip/__init__.py HWI/hwilib/devices/btchip/__init__.py
diff btchip-python/btchip/bitcoinTransaction.py HWI/hwilib/devices/btchip/bitcoinTransaction.py
diff btchip-python/btchip/btchip.py HWI/hwilib/devices/btchip/btchip.py
diff btchip-python/btchip/btchipComm.py HWI/hwilib/devices/btchip/btchipComm.py

The second commit drops stuff we apparently don't need (lgtm as long as the test pass I guess). Third updates README.
utACK 3e771958cc811caf22b1f1c4c77008764a09a534

utACK https://github.com/bitcoin-core/HWI/pull/446/commits/3e771958cc811caf22b1f1c4c77008764a09a534


Request for Authorization Status changes

I would be great I you add a opportunity for watching for auth status changes using closures.

Added in 0.9.0. Thank you.


Clarification for APIM handling a request with a Subscription Key when the API doesn't require a Subscription Key

[Enter feedback here]
In the section heading "How API Management handles requests with or without subscription keys", it refers to the behavior when 'Requires Subscription' on the Product is disabled or the 'Subscription Required' is disabled on the API, and a API request is received without a Subscription Key.
Can you confirm the behavior when either of these settings are disabled, and a Subscription Key is presented?
Will APIM validate the Subscription key in all the standard ways?
We are looking to setup an API that can receive either a JWT or a valid Subscription Key, and want to ensure that if we disable the Subscription Required on the API, that when a Sub key is presented, we can rely on APIM validating it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 896691fb-064a-eaf8-f71f-53200149b48a
Version Independent ID: ff3e18ed-6d13-6fac-7b6c-f78f47b0f754
Content: Subscriptions in Azure API Management
Content Source: articles/api-management/api-management-subscriptions.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

@ncroad
Thanks for your feedback! We will investigate and update as appropriate.

Hi @JananiRamesh-MSFT, @YashikaTyagi-MSFT,
Can we please get an update on this item as it is now delaying our project?
Is it possible to get even a draft response confirming the behavior prior to the official documentation being updated?
Thanks.

@ncroad Sorry for the delay in response. When 'Requires Subscription' on the Product is disabled or the 'Subscription Required' is disabled on the API

If call is made with no subscription key, request is accepted.
If call is made with invalid subscription key, request is accepted.
If call is made with subscription key from another product, you will see 401 response.
If call is made with valid subscription key, request will apply corresponding product with that subscription value (which does validate the key).

Refer few other scenarios described here: https://techcommunity.microsoft.com/t5/azure-paas-blog/using-api-management-open-product-to-manage-access-control-with/ba-p/2898754 which would help in understanding how keys are validated.

Ok thanks for this, very helpful.
Is it safe therefore to assume that when a valid subscription key is provided for that API that the context.Product and context.Subscription properties will not be null? Therefore, in the situation that a invalid subscription key is given that we can validate that if the context.Product or context.Subscription is null, we should then return an unauthorized response?
We will look to wrap this in a choose statement, alongside a check for valid JWT. Essentially the request needs to have a valid JWT, OR have context.Subscription and context.Product.

@ncroad I want to remind about overall logic from techcommunity

I think once it is associated with a matching product, your assumption appears to be correct. For invalid subscription key, it will be treated as open product and hence Product and Subscription is expected to be null.
Please validate and let us know if you face any issues. We will now proceed to close this thread.


Add private endpoint parameter tests to all modules with implemented endpoint support

Add private endpoint tests to all modules with implemented endpoint support.
Reference: AutomationAccount

List of private endpoint supported modules (with supported resource type) in the repo with private endpoint support implemented along with an updated parameters file as of today -

Module
Status

App Configuration
✅

Automation Accounts
✅

Batch Accounts

Cognitive Services
✅

Container Registries
✅

Data Factories

Event Grid Topics
✅

Event Hub Namespaces
✅

Key Vaults
✅

Machine Learning Workspaces
✅

Network Application Gateways

Recovery Services Vaults

Service Bus Namespaces
✅

SQL Servers
✅

Storage Accounts
✅

Azure Synapse Analytics
✅

Web/Function Apps
✅

CC: @MrMCake.

All modules with implemented private endpoint support within the repo have been verified to also have private endpoint test cases. Any that were missing have been added. See the comment above for the checklist of resources with implemented private endpoint support.


Const - add vis.plant setting as min planted for invitations

This is currently hard-coded - at 5.
Spec: Make it a setting.

Should it be named "vis.plant" or "fee.invitation", because it's not used only by visitors, right?

What about "invitation.planted"

Check if sow_quanted is above the minimum in _invite.
Make sure people ar not allowed to unplant this min quantity?


Consumable products prices in same currency are still converted

Hi, not sure if the bug is coming from the library or a wrong configuration of the appstore connect. I've set a consumable product with a price in EUR (It is worth to mention that I previously add them in dollar, since my account has dollar a main currency. I've changed it since then).

When I request them, they seem to be converted, but I am in euro :/

I'm quite confused about how to deal with it.
Any help would be appreciated.
Thanks !
Version of react-native-iap
7.5.1
Version of react-native
0.64.1
Platforms you faced the error (IOS or Android or both?)
iOS
Expected behavior
For consumable products, return the price set in EUR in the AppStore Connect
Actual behavior
Returns a converted price
Tested environment (Emulator? Real Device?)
Read Device, an iPhone SE running on 15.1
Steps to reproduce the behavior

Same problem

Could this be related: https://developer.apple.com/forums/thread/660817 ?

Please reopen if it's still an issue on 8.x.x


Auto-generate a valid QBiC project identifier

Currently, the project code needs to be entered manually and thus provokes hit and fails.
Ideally the offer manager provides the possibility to auto-generate a new QBiC project identifier.

Helpful code:
https://github.com/qbicsoftware/projectwizard-portlet/blob/master/src/main/java/life/qbic/projectwizard/control/WizardController.java#L257
https://github.com/qbicsoftware/projectwizard-portlet/blob/master/src/main/java/life/qbic/projectwizard/control/ProjectNameValidator.java


Concrete Strength Calculation

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Concrete Strength Calculation
:red_circle: Aim : Calculate the strength of the concrete using Machine Learning techniques.
:red_circle: Dataset : https://www.kaggle.com/prathamtripathi/regression-with-neural-networking
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
Hello, ML-Crate contributors, this issue is only for the contribution purposes and allocated only to the participants of SWOC 2.0 Open Source Program.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.
A Demo Project has been created to guide you about the whole structure of presenting the Project in this repository. Here's the link of the Demo Project - https://github.com/abhisheks008/ML-Crate/tree/main/Project-Demo-Folder

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID :
Approach for this Project :
Are you a participant of SWOC 2.0?

[ ] YES
[ ]  No

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Full name : Sankalp Srivastava
GitHub Profile Link : www.github.com/sankalp-srivastava
Participant ID : 857
Approach for this Project : EDA and creating different models and comparing them.
Are you a participant of SWOC 2.0?

[x] YES
[ ] NO

Go ahead @sankalp-srivastava

What's the update here @sankalp-srivastava

Almost done

Just need to do readme files

Okay cool @sankalp-srivastava


feat(NumberTheory/Fermat): Fermat numbers

What is the relation of this PR with #14874?

What is the relation of this PR with #14874?

I was not aware of that, but the results are different.
Happy to rebase is either way. I think for #14874 it would be good if they used the terminology introduced here.

Thanks for the review, @loefflerd!

Thanks for your patience with all these pedantic formatting corrections! I think this is good to go now
maintainer merge

bors r+
(I swear I didn't make it the round number on purpose, it was just a coincident. Perhaps I should have waited for the next Fermat number #65537.)


[BUG] Add-ledger issues while testing on Linux

Adding the ledger:

The text instructions say add-ledger [account] but it's not clear that the user needs to type in the command and an account name. If the setup prompts the user for an account, why dont' we simply have the command add-ledger?

Error 1:
Delegating -10000ugrain to palomavaloper1am3k7czusdcewv55nhaugu2drn38af9464n65p
Error: unknown shorthand flag: '1' in -10000ugrain
Usage:
palomad tx staking delegate [validator-addr] [amount] [flags]

Error 2:
Error: decoding bech32 failed: invalid bech32 string length 5
Usage:
palomad tx authz exec [tx-json-file] --from [grantee] [flags]

Wrong Index
My GRAINs on my ledger are on index 1 not index 0. How do we have the user specify the index number? This is a new feature as we agreed to default to index 0, but I am not able to use this as the ledger I have uses index 1.

@taariq The errors are all related to a bad setup. Can you post the full logs of what you were running? Also, can you post the result of cat $HOME/.config/paloma-lightnode/.paloma/keys?
The [account] argument is supposed to be the HD account index and defaults to 0. So in that case you should use add-ledger 1. I will update the help text to make it less confusing.

@maharifu output:
cat $HOME/.config/paloma-lightnode/.paloma/keys
[DancingBanana] paloma182ettr33r6cjh5sly58rl75wzcw8dn65pmey6x
[Scroll] paloma1lsw2g9cpsmh28rd3rnlek8tuev9lkx60f8wwat

@maharifu for the instructions
add-ledger [0]

@taariq Can we close this?


test: misc. CI improvements

This PR performs some miscellaneous cleanup of the tests themselves, as well as adds wrappers around the results of some of the helper functions. This will reduce the amount of boilerplate code in the tests. Furthermore, it refactors some of the helper functions to remove useless return values and groups declarations of vars together.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

Overall looks great, thanks for doing this.


fix compilation error due to Rust/C type mismatches

Most errors where found when compiling on armv7-unknown-linux-gnueabihf
but there may be more type mismatches, I haven't thoroughly checked.
• change i8 to c_char for pointers to CString (c_char is unsigned
on some architectures)
• change i64 to t_time where it represents a timestamp (t_time is
32 bit on on 32 Architectures, at least on Linux)
• change a few other types to the correct C type

Hey thanks for this!  I haven't had a chance to compile this on armv7.  Great work

@hanscj1 could you do a release?  I don't think I have access to release to this package on crates.io

Sure enough.

done

Sweet! Thanks.  Thank you also Peter :)
On Tue, Mar 7, 2017 at 3:56 PM, Chris Jones<EMAIL_ADDRESS>wrote:

done
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ceph/ceph-rust/pull/5#issuecomment-284900308, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC6qE63tXqAjoclw7_br8zUNU6nTjTmwks5rje6RgaJpZM4MWK6_
.


Bug Report:

Windows 10 64 bit
<IP_ADDRESS> FNF - 1.7 Kade Engine (Most recent Zardy release)
Game is locked to somewhere around 60fps (I cant tell exactly what the frame rate is but its definitely lower than 120, although the fps display still claims the game to be at 126 or whatever i set it to in the settings.)
I do not have this problem with other mods nor older releases of Kade engine, however the newest release (1.7 as of this report) does retain this problem
Kade Engine 1.6.2 does not have this issue
Thank you in advance and keep up the good work KadeDev I love your shit

bruh when i put the b side mod into kade engine 1.7 this happens it takes me to the wrong stages

I have this same bug, where the notes seem to scroll at a lower framerate as the rest of the game.

Ok, so i did some research and this bug is now fixed in kade engine but im not sure if kade will update the mod with the new kade engine version

fixed

the latest zardy release still has this problem is there anything I can do to port zardy into a higher kade engine?


support SKYDNS_DOMAIN resolve itself

dig example.com will linked to self.example.com
After I set SKYDNS_DOMAIN=example.com, reslove example.com returned all second-level domain typeA record, so I want to defind an alias named 'self', to get correct results.
Or we can defind an other string.

Where is the bug that you can't have A/AAAA records for the top-level domain? I.e. what are you trying to do and why does it fail?


Proper fix for double colon issue

Test case names in verbose output are no longer correct node ids, so can't be copied to clipboard and passed as pytest command argument. This pull request will keep #153 fixed and bring back correct test case names.

Thanks for working on this!
Unfortunately CI is broken since a while already.
IIRC https://github.com/Frozenball/pytest-sugar/pull/156 should fix it.

@mbachry
CI is fixed, so this can be rebased.

Codecov Report

Merging #172 into master will decrease coverage by 2.25%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   87.47%   85.21%   -2.26%
==========================================
  Files           2        2
  Lines         479      487       +8
  Branches       85       85
==========================================
- Hits          419      415       -4
- Misses         35       45      +10
- Partials       25       27       +2

Impacted Files
Coverage Δ

pytest_sugar.py
80.76% <100%> (-1.98%)
:arrow_down:

test_sugar.py
95.3% <83.33%> (-3.97%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 381cd0e...4e977a3. Read the comment docs.

Hi, could this change be landed?

Hey 👋
Thank you for your PR! I am going through the old PRs in this repository and closing them since a long time has passed since the opening and they may not be that relevant anymore. If you still wish to continue with this pull request, let me know and we can re-open it.
Teemu


Update nginx example

To fix #508 I just update nginx example app to default s2i create structure

It could be run again since I do not change any Go file

yep, it can. [test]
will give this a review tomorrow.

re[test]

@luiscoms i really appreciate your work and i'm sorry but i don't think this is the intended purpose of the tutorial.
Based on Ben's comment and also on the fact that i've done this from scratch and raised the same concerns while doing it, i'm closing this and also the issue that's related to this, since it's not really an issue.
As stated, the tutorial is fine the way it is, and it's meant to be that way.


Better monophasic prediction

Better handling of monophasic variants of serovars.

Missing fljB H2 gene? Monophasic
Otherwise? Biphasic

this is resolved in v. 1.1.0


KAFKA-8997; Make Errors a first class type in the auto-generated protocol.

Introduces a new error type in the generated protocol's specs which maps to the Errors enum in Java/Scala. The error type does not change the wire format which remains an int16.
As a first example, the ApiVersionsResponse has been updated to use the new type. Tests in the generator are limited but the unit and integration tests around the ApiVersionsResponse cover the new error type.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@cmccabe I have updated the PR. Could you have a look when you have a moment?

@cmccabe Could you have a look at this one please?

retest this please

retest this please

retest this please

retest this please


new le and lt for nat

I want to redefine nat.le and nat.lt in the HoTT library as
  inductive le (a : nat) : nat → Type₀ :=
  | base : le a a
  | step : Π {b}, le a b → le a (succ b)

  definition lt [reducible] (n m : ℕ) := succ n ≤ m

The current definition is the other way around, lt is primitive:
  inductive lt (a : nat) : nat → Type₀ :=
  | base : lt a (succ a)
  | step : Π {b}, lt a b → lt a (succ b)

  definition le [reducible] (a b : nat) : Type₀ := a < succ b

@leodemoura: Can this potentially break things in the C++ code? nat.lt and nat.le are not listed in constants.txt but I thought that lt.wf was used for something.

Motivation
With the current definition, you cannot induct over H : n ≤ m. The reason is that H is unfolded to H : n < succ m, and succ m is not a variable, but is an index for the family lt.
You can manually define a recursor for le, but that doesn't have the right computation rules definitionally, which is a pain.
With the new definition, you can induct over both H : n ≤ m and H : n < m, because in both cases the index is a variable. I've used this in my construction of the propositional truncation extensively. For example, you can define
open nat (hiding le)

inductive le (a : ℕ) : ℕ → Type₀ :=
| base : le a a
| step : Π {b}, le a b → le a (succ b)

local infix `≤` := le

variables {A : ℕ → Type} (f : Π{n : ℕ}, A n → A (succ n))
include f

definition fr {n m : ℕ} (a : A n) (H : n ≤ m) : A m := -- repeatedly apply f
begin
  induction H with m H b,
  { exact a},
  { exact f b},
end

I used this definition a lot. And it was important to make this definition as simple as possible, because not only did I need to prove properties about f_repeat, such as
definition fr_f {n m : ℕ} (a : A n) (H : n ≤ m) (H2 : succ n ≤ m) : fr a H = fr (f a) H2

I also needed to show that the definition fr_f satisfied certain properties (so 2-dimensional paths).

I think this is a good change, and it doesn't affect the C++ code.
I did not implement the automation for well-founded recursion yet: https://github.com/leanprover/lean/issues/392

Ok, then I'll implement it.
By the way: I want to say that the induction tactic is very useful and works great. I use it a lot.

closed by 14fb580885170ef2ebbe257395d344dc2452e317 (but not yet merged into master)

Shouldn't we make the same change in the standard library? @fpvandoorn, how much more work would it be to move the change there?

Yes, I'm going to make the same change in the standard library. That shouldn't be much work.
Initially I thought I shouldn't do it for the standard library, because the motivation example - the definition of fr - is not possible in the standard library, because you would have to eliminate from Prop to Type. Or is there a trick to still do this?
However, to keep the libraries as similar to each other as possible (to make future porting easier), it's indeed important that the underlying definitions are the same.

I haven't thought about this carefully, but for predicates A : nat -> Prop, does this give you useful forms of induction? For example, can you use it to prove "total induction"?

@avigad The main motivation for the new declaration is that it is easier to work with.
Indexed families are usually a mess to work with, but there is an exception.
We say it is "easy" to apply induction on a hypothesis h : C A i, where C is an inductive type, A parameters and i the indices, when all indices in i are pairwise distinct variables.
For example, le has one parameter and one index, then h : le x y and h : le (succ x) y are "easy" because in both cases the index is the variable y. On the other hand, le x (succ y) is not.
The induction tactic process "easy" cases by reverting any hypothesis that depends directly or indirectly on h or its indices, then it applies the induction, and then reintroduces everything back.
For user-defined induction principles, we think this is the best we can do automatically.
In the master branch, we define le x y as lt x (succ y). Floris noticed this is bad because we will never have an "easy" hypothesis.  Suppose we have (h : le x y), and say induction h. Then, Lean will say "failed to apply lt.rec_on because succ y is not a variable". However, if we define le as the inductive datatype above, and lt x y as le (succ x) y. Then, both (h : le x y) and (h : lt x y) are "easy" hypothesis.
For builtin induction principles, we can use dependent pattern matching (e.g., cases-tactic) when the index contains constructors. However, the current implementation uses proof irrelevance, and only works reliably on the standard library. So, for the standard library, the change doesn't make a big difference, but I think we should do it anyway to make sure both libraries use similar definitions.

Thanks -- this explanation is very helpful.

Unfortunately, the standard library depends in quite some places on the fact that succ n ≤ m and n < m are definitionally equal. I made the changes here: 23711d9296762cbf9c204cfef793350f13d679f8.
There was one bigger issue: bounded quantification is defined as
  definition bex (n : nat) (P : nat → Prop) : Prop := ∃ x, x < n ∧ P x
  definition ball (n : nat) (P : nat → Prop) : Prop := ∀ x, x < n → P x

Previously, bounded quantification with ≤ was a special case of this:
(∃ x, x ≤ n ∧ P x) ≡ bex (succ n) P
(∀ x, x ≤ n → P x) ≡ bex (succ n) P

Now those definitional equalities are only equivalences. Moreover, if we define bex and ball using ≤, then < would still not be a special case (for n = 0).
To make sure that test/lean/run/bquant compiled, I had to define two more instances in bquant.
This is why the test suite is useful! Otherwise I wouldn't have noticed. Hopefully this is the only thing that broke (the standard library + test suite compiles, so if something else broke, it is not yet used).


Sorting only being fired once

I have a table list that is being generated in the client using UnderscoreJS templates.
To trigger the Sortable plugin I'm running $.bootstrapSortable(true); after the template injection is complete.
However when I click on a heading column it sorts that column once but then will not sort it in the opposite direction when clicking again.
Looking in Inspector I see that it's always inserting the class class="up sorted", I'm presuming this should alternate with class="down sorted"?
Am I missing something?

from what you wrote, it should work
so neither the icon nor the data is changing?

as there is no response, I am closing this
if the problem persist, please provide an example, where I can have a look at it


add punctuators deps to poetry

Hello again :)
After following the installation instructions on README, the "punctuators" package is not getting installed.
This line is giving a module not found error.
https://github.com/zh-plus/Open-Lyrics/blob/master/openlrc/transcribe.py#LL7C6-L7C17
adding it to poetry solves it

Thanks!


ColorPicker vs Active/Focused program

Microsoft PowerToys version
0.59.1
Running as admin

[ ] Yes

Area(s) with issue?
ColorPicker
Steps to reproduce
Try to use the color picker to get the color of the active application's title bar.
✔ Expected Behavior
I was expecting to get the title bar color I was looking at before activating ColorPicker
❌ Actual Behavior
I was only able to get the color of an inactive title bar.
Other Software
Edition: Windows 10 Pro
Version: 21H2
OS Build: 19044.1766
Experience: Windows Feature Experience Pack 120.2212.4180.0

How do you activate the picker? Via the Editor window?
Possible work-arounds: open directly with hotkeys; open more then one window; make a screenshot before picking

Yep, the UI takes focus. Should not be possible.

I just tried this and had teams for example in focus and then triggered Color Picker.  I was able to get the appropriate color for the search bar.  We need a bit more info here as i can't repro this and can get actual in app focus color.
/needinfo

@crutkas might depend on 2 things:

must be a Windows 10 thing, since Windows 11 usually doesn't paint colored title bars any more
the chosen activation: If I choose to activate the color picker immedately it can work as expected, other methods make the other/targeted window lose focus

FWIW, I just discovered that I can do the following to work-around the fact that ColorPicker "steals" the focus when activated:

Press Ctrl+Shift+C to activate color picker
Move the mouse over the element whose active color I want to pick
Use Alt+Tab to re-activate the appropriate program

After doing that, ColorPicker showed the activate title bar color.  So it is possible, but a bit cumbersome.  Thanks for at least thinking about this!  Have a great day!

Couldn't replicate this, as well. I'm on Windows 10 too.

@Jay-o-Way we need clearer steps. Both Jaime and myself couldn’t repro this
happy to pop on a call for a demo

For me it's simple:

PowerToys is running and Color Picker is on (obviously)
Some window has focus
Press hotkey
Window lost focus

But the weird thing is, this is not consistent. Sometimes it works as extected, sometimes it doesn't.
Video 1
Video 2

For me it's simple:

PowerToys is running and Color Picker is on (obviously)
Some window has focus
Press hotkey
Window lost focus

But the weird thing is, this is not consistent. Sometimes it works as extected, sometimes it doesn't.
Video: https://youtu.be/G1ynPDuuHbk

I've been able to reproduce this now, but it's inconsistent as you say...


Dataset Viewer issue for Tylersuard/PathfinderX2

Link
https://huggingface.co/datasets/Tylersuard/PathfinderX2
Description
The dataset viewer is not working for dataset Tylersuard/PathfinderX2.
Error details: I uploaded a big .zip file.  I would like to be able to show a preview of some of the images.
Error code:   PreviousStepFormatError

Thanks for reporting, @Tylersuard. I'm having a look at it...


Fix issue where meta editor resulted in infinite recursion

Issue was due to the implementation of ConstRenderer, which did not correctly imploy 'effects'
The other changes in this PR are not essential.
A remaining issue after this fix is the slow responsiveness when entering text in the form, I think due to the upload/editor button..?

This fix doesn't work when upload a metadata json. Fields from json cannot be applied to the form from my end.

so this seems to work in the standalone editor, but in the uploader we've got two issues:

can't type in the metadata form. Seems to have been introduced in 0c9a7d9b
can't set the metadata form from the uploader UI. This appears to pre-date 0c9a7d9b

The last commit appears to fix both issues on my side.

The last commit appears to fix both issues on my side.

Can we merge this?


Word counts for characters (or users)

There's already a word count for individual posts.

Added word counts for users on a per-thread basis on the stats page in #366


[Question][PotentailBug][FeatureRequest] XNet Gui BlockRenderer is weird.

We are testing XNet with IC2Classic like a little bit now.
And we found something weird. XNet does render almost every IC2C Machine as machine/advMachine block.
which is really weird. Because that should not happen.
I wanted to know if you use the getDamageDropped and getItemDropped for your GuiRenderer of the Blocks that are connected to your XNet System?
Because if yes i ask you to change that because ic2c does use the drop logic to make sure that you get a different machine back when you break your block.
What i would suggest just use a default renderer with getStateFromMeta() that works also.
Also 1 other thing i notice is. When you have 2 connectors on 1 Block the renderer for that second connector doesnt render anything at all. Its a invisible thing.
This is our modpack. It could be that we are outdated but we noticed that a lot.
http://imgur.com/a/5GvgI
Also 1 wish i would have is that XNetConnectors could send a Redstone signal. Unless the adv can already do that then never mind.

Also 1 other thing i notice is. When you have 2 connectors on 1 Block the renderer for that second connector doesnt render anything at all. Its a invisible thing.

That's intended. It is to make it easier to see that they are the same block.
As to the renderer. XNet (and all my mods) use the standard Vanilla:
        RenderItem.renderItemAndEffectIntoGUI(itm, x, y);

To get that item I use:
                IBlockState state = getWorld().getBlockState(pos);
                ItemStack item = state.getBlock().getItem(getWorld(), pos, state);

I can't use getStateFromMeta() as that breaks with other mods which override getItem() to get the right item. I was using that in the past with bad results.

To the double thing. Yeah that would be reasonable if these would be sorted properly.
But they arent. They apear randomly on the list. So you have a random Empty one where you have to look all the time (unless you know) what it is.
Maybe add a sorter?
Oh i know why. You use a Depricated function. getPickBlock is the function i use which has a extra player.
I can support that really easyly. But i didnt come to think of that.
Thanks as always.
What about the redstone thing?

Can you show a screenshot of that random order? That should not happen.
Redstone support is already there. The logic channel can send out redstone signals

Well let me join my testserver because i have none open right now.
So you can emit redstone out of a connector?

yes (about the redstone)

I assuem you need a advanced connector.

No, redstone works with normal connectors too

how can i make that to happen then? (because i wasnt able to find that out)

Create a logic channel. Make a 'redstone' connector in it (i.e. you can toggle between 'sensor' and 'redstone')

You need at least version 1.3.0 for this though

ok we are extremly outdated. And on top of that i cant reproduce that scenario. I know that it was a thing. But maybe it was a rare case...

^^" Thanks for the help. I will fix the bug on my side and make sure XNet works properly.

Em yeah something new.

This is something that happend after i updated to 1.3.1
TileEntityCrops (thats my class) has no RF, Fluid, or ItemCapability.
This is a really really weird bug.

Here is the code that checks if a connection is possible:
public static boolean isConnectable(IBlockAccess world, BlockPos pos) {
    TileEntity te = world.getTileEntity(pos);
    IBlockState state = world.getBlockState(pos);
    Block block = state.getBlock();
    if (block instanceof ConnectorBlock) {
        return false;
    }
    if (block == ModBlocks.redstoneProxyBlock || block == Blocks.REDSTONE_LAMP || block == Blocks.LIT_REDSTONE_LAMP) {
        return true;
    }
    if (block.canConnectRedstone(state, world, pos, null) || state.canProvidePower()) {
        return true;
    }
    if (te == null) {
        return false;
    }
    if (te instanceof IInventory) {
        return true;
    }
    if (EnergyTools.isEnergyTE(te)) {
        return true;
    }
    if (te.hasCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, null)) {
        return true;
    }
    if (te.hasCapability(CapabilityFluidHandler.FLUID_HANDLER_CAPABILITY, null)) {
        return true;
    }
    if (te instanceof TileEntityController) {
        return true;
    }
    if (te instanceof TileEntityRouter) {
        return true;
    }
    return false;
}

Maybe you can check if your block matches any of these criteria?

On top of that i may have a feature request for the color buttons.
When you leftclick it should go forward and when you right click it should go backwards. That allows better changing. (Its somehting that pisses me off)

For color buttons: shift-right-click goes backwards

ok ty.

for the crops. They provide a redstone signal.
They have to be a power emitter because else some crop types do not work properly.

So that's why XNet connects. So that it can read/send redstone signals to it

Because the CropType is not Metadata based. Its tileEntity based.
Could you maybe add a OverrideAPI that allows to control redstone a bit more?
Or can you disable connectors ingame som how.

Why do you want to disable them?
This is a useful feature. XNet can read and send redstone to those

Well i mean force a connection not to be happening. Because i dont want it to read my crops.

I can perhaps add an interface for that
But anyway, weird that you have to implement redstone support for this though.
Note that the connection is only visual. It is not really in the way of anything. Just looks a bit ugly :-)

Because this is how these things look like...
I know this is due to getItem() because its unsupported (my bug). but i would like to remove these from my list of things to check.

Could you maybe add like a feature when you click lets say with a stick on the Connector side that the connection is no longer done because the player manually disable teh connection?

Perhaps. I'll think about it

Just something i got requested from a couple testers. (I know sry that i come with so much things).
They asked if you could add EU support to XNet. We have right now power cost removed because our Pack has basically no RFProduction besides forestry, and they would like to use EU and maybe transfer EU with it.
I would like to know how you think about that?

I have considered it in the past but then I looked at the EU API and I was like 'heck no'. I'm really not a fan of that power API to be honest and it would fit in badly with how XNet works right now. I may do it at some point in the future but for now I'm too busy to look at that

Yeah i know EU is not as easy in the first place but it has some really powerfull features that you can't do with RF.
Basically. You do not need to implement any Interface to your main TileEntity Class to support EU (thats why the registry Event).
You can just have a fieldInstance of the EU Receiver/Emmiter in your TileEntity and register that to the Enet.
IC2Exp force that these fields have to be TileEntities (yes i know its stupid, the IC2 team is in the design a API regard not really good to say it nice) but they don't have to be in the world, thats why the BasicSource&BasicSink Exists.
And when you register your EnergyField the enet will automaticly asign it to your Block and IC2Cables and all other things that send/transfer EU (properly) support it automaticly.
When you register a EnergyReceiver/Emitter/Conductor to the Enet via the event it automaticly handles EnergyTransfer for you.
Just to give you a point of view.

Anyway i dont want to force that feature in or something i just wanted to know your point and tell you the things that arent commonly known. Thanks for the talk and have a nice day. (I try not to come back with issues xD)

Sry that i am back. I just lookt at my server console and i got this
java.util.concurrent.ExecutionException: java.lang.NullPointerException
        at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_121]
        at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_121]
        at net.minecraft.util.Util.func_181617_a(SourceFile:46) [h.class:?]
        at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:668) [MinecraftServer.class:?]
        at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:387) [ld.class:?]
        at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:613) [MinecraftServer.class:?]
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:471) [MinecraftServer.class:?]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121]
Caused by: java.lang.NullPointerException
        at mcjty.xnet.apiimpl.logic.Sensor.update(Sensor.java:214) ~[Sensor.class:?]
        at mcjty.xnet.apiimpl.logic.LogicConnectorSettings.update(LogicConnectorSettings.java:148) ~[LogicConnectorSettings.class:?]
        at mcjty.xnet.blocks.controller.TileEntityController.updateConnector(TileEntityController.java:448) ~[TileEntityController.class:?]
        at mcjty.xnet.blocks.controller.TileEntityController.execute(TileEntityController.java:516) ~[TileEntityController.class:?]
        at mcjty.lib.network.PacketServerCommand$Handler.handle(PacketServerCommand.java:58) ~[PacketServerCommand$Handler.class:?]
        at mcjty.lib.network.PacketServerCommand$Handler.lambda$onMessage$0(PacketServerCommand.java:37) ~[PacketServerCommand$Handler.class:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_121]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_121]
        at net.minecraft.util.Util.func_181617_a(SourceFile:45) ~[h.class:?]
        ... 5 more

I know how to reproduce it. Create a Redstone Logic on a controller make one for a block.
And then switch between sensor and output. Works on any Block.

I'll check it out

Its nothing that crashes a server but you get everytime this spam. And i dont know the effect it has on the reader Blocks.

The crash you got will be fixed next release. I'll keep this ticket open for the other suggestions

@McJty i found another bug. Thats actually critical. When you use a AdvConnector and remove a connecting block and set a new block into its place it will keep the settings and i can no longer edit them.
in fact if i try to remove them it will delete other settings... So i am forced to destroy the advconnector.
I didnt update yet so its still the same version.


Use module_item_by_name.

This change is

crates/cairo-starknet/src/contract.rs line 72 at r1 (raw file):
Previously, yuvalsw wrote…
Fix the error message. Same in the other places in this PR

what should be the fixed error message?

crates/cairo-lang-starknet/src/contract.rs line 72 at r3 (raw file):
Previously, yuvalsw wrote…
Nit: You can specify which module.
Here and below

That is exacly why I wanted to leave the old comment.
The failure here is before the lookup.  if the lookup happens and the item is not found it is handled below.


Update GDK WinGet ID in GDK Winget config sample.

Update GDK WinGet ID in GDK Winget config sample per #3970.

@microsoft/xbox-developer-experience-toolbox for awareness.


Add Korean translation.

Adding ko_KR korean translation.

We use transifex for managing the translations. I haven't looked for an easy way to upload them in bulk, but it should exist.

@tim-schilling can you invite me?

I've just checked. thanks


fill in CHANGELOG.md

Current dependencies on/for this PR:

main

PR #12   👈

This comment was auto-generated by Graphite.


xbox controller controls mapping

map xbox buttons and joysticks to various control modes

Xbox controller

Set up the gazebo environment on your computer
Pull code from azumnanji/74/gazebo_simulation
Launch roslaunch uwrt_mars_rover_description display.launch control_mode:=arm_mission
You can use the joint state publisher to see how all the joints in the arm and the drivetrain move
Everything is the same on the real rover except for the gripper and the joints on the drivetrain
- The gripper is closed by a linear actuator which is one motor
- Each side of the drivetrain is controlled by one motor and acts like a differential system
The gimbal has a camera that can be controlled - will provide the topic name here
If you don’t know the topic of the joint you are trying to publish cmd_vel to put something random for now and we will fix it in the PR
A good place to start is in drive_testing branch. This has all the code for mapping xbox commands to the drivetrain

High level objectives

We want the left joystick to be for movement and the right joystick to be for camera / gimbal camera movement
We want to be able to switch between control modes for arm, science, autonomy
We need to be able to control every joint on the arm, slow and fast modes for the drivetrain and the gimbal camera at all times


[Meta] Documentation of Releases

Not a huge issue, but it might be nice to document release a bit more. Github has a nice release feature.

Done :)
https://github.com/michael-lazar/rtv/releases

I updated the readme to reflect theses changes as well. And fixed it up as well :) #79


Update continuous-backup-restore-introduction.md

Address grammar and article flow

@kanshiG
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Add tag importer progress bar and some additional worker behaviour

See commits for details.

🎉 very cool!

BTW we should revisit this when we've upgraded to Rails 5. Super curious if ActionCable is easy enough to be used for this.


reorder createContainer steps

defer functions are called in stack order. Move state dir preparation
first so that it is cleaned up last. Otherwise we might accidentally
delete contents in container rootfs in case of failure.
This should fix https://github.com/hyperhq/runv/issues/550.

os.RemoveAll() does not follow symlinks!


error in set focus

Describe the bug
when i click view table  it renders the data window.....
the selected entry point is highlighted the table name ...ok
the error return creates a second highlighted the data connection entry..... bad error
it forces the selected entry to jump up the the data connection....
I have small screen so it mess up my tree on a large screen the effects would be un notice
next is add 2 new icons for the tree one yellow key for primary and one orange  for foreign key
i added this new feature because your playing with the tree view and you can fix both at the same time....
To Reproduce
[sqlite]
Expected behavior
Screenshots
Desktop (please complete the following information):

OS: [e.g. Windows, Linux, Mac]
SQLTools Version [e.g. v0.17.x]

Additional context
styles and features go hand and hand .....
https://www.iconfinder.com/
basically you setup your styles  the table icon and field type icons
the icon-finder will let you build the icon  you need as temp icons ......
a text icon a blob icon an integer icon...

Is it the latest version @julientype ?

yes the view was corrected as you did....  the return focus created 2  focus points where only 1  should be at all times base on the operation at hand.... styles to new features go hand and hand.... this way your not back tracking to correct features later..... so you have a style error and the selected action return entry
like if you create something what return focus entry should highlighted in the tree  we cant have multi entries can we....
stay tune on on multi dimension form layout for sql .... you can  create forms where your trying to create arrays to build sql formats in javascripts memory or let dom do it for you..... xml is an loaded array with speed...

ohh yes their is away to query the css being used in its frame to get its tree active object.....   again your not building arrays to cycle an active request .... your working from the load dom object... and let it do the work for you....   you do get dom access in vs-code addins but its limited  granted by vscode styles themes.....   your working off its style object.....

Get a white board as you read draw the ideas on the board on how we are going to move information around..... your a data store connector and the cat window is your client......
the client will never connect to the database .... your the connector store.... where you add alter values from to the database.... like add delete create.....  where the complex code is not mix in with data connection store......
with client creating sql do you need the store to create it ...no.....  so we create a server client apps this way and delegate operation to one or the other.....
do you need a grid layout yes..... do i no..... i need data sachems injections from the store to pay with

Wait. We are talking about a lot of stuff.
What's the problem? Is because the 3 is being expanded on connect?

in a client server operation we need maintain a connection  so its important the data store tree to retain 1 element selected ..... you have a cat window open and moving to different   area in the store....
a) do you close the cat window
b) let the user submit sql   from a client window.  ..no
your command operation happens by the user.... im not sure  how vscode lets you do this in its implemented styles .... but styles are styles....
you do need to master it single or multi selector in css and multi is harder where a request operation is sent to a corrected selected item or items ...lol.....for its focus set or get element at hand....
css
a:focus {
color:rgb(85, 171, 228);
}
.divToolTree,
a:hover {
color:rosybrown;
}
.divToolTree,
a:active {
color: olive;
}

here is the code.... where a long array gets mess up and you need the user back to its inserted operation in the tree....
elem[iclause].scrollIntoView({});

Ok, I got it now.
But currently there's nothing I can do with vscode styles. Their api programmatically create an item defining icons and some other props, but it's JS only. CSS is not allowed right now. There is an issue on VSCode repo about this, I don't remember the name. I'll relate it later here, but for now, my hands are tied. Some extensions change VScode styles, but it's not persistente. The user need to re-do this whenever it updates

I'll close this issue since it's not a SQLTools bug itself. But I'll open or thumbs up the related issue on VSCode repository.
Thanks @julientype !

@julientype can you create a PR for this feature?


Add unused var rules

Purpose
Typescript is not configure to alert for unused variables generating dead code in the application.
Proposal
Use the rules noUnusedLocals and noUnusedParameters to alert for unused var.

I suggest you to split your commit in two:

One that modify the configuration
One modifying the code once the configuration applied.

Like you did we can't detect, searching in the commit history, the commit changing the configuration (with the :wrench: emoji).
Also explain in the commit message what is your motivation to change the configuration. You explain it in the PR description so I understand why you did it (we have dead code) but I don't find this explanation in the commit message.
Otherwise on the PR itself, your modification is great and will help us to clean the code.
Thanks

I suggest you to split your commit in two:

One that modify the configuration
One modifying the code once the configuration applied.

That's what I did in the first place then I remembered this rule in the handbook:

We can run the test suite on every commit and it should always stay green 😎.

I checked quickly and according to this issue I can not configure the rule to warn, this will always raise errors while transpiling.
Can you confirm that I can bypass the "rule" ?

No you are right for this rule. So you can keep one commit but you should modified the title to add where you are adding the rule (in tsconfig) and complete the message with the suggestion I made in my previous message.


Add the env variable OS filter

If this variable is set only the matching OS will be tested.
Like this:
SPEC_FACTS_OS='ubuntu' rake spec

Coverage increased (+0.3%) to 95.0% when pulling 24f5fccf0c5c8a1ec41d0fe0b54325e7c843c5c2 on dmitryilyin:master into 026e8ef054b1e2053d6f690d7113a7e94863b546 on mcanevet:master.

Coverage increased (+0.3%) to 95.0% when pulling 24f5fccf0c5c8a1ec41d0fe0b54325e7c843c5c2 on dmitryilyin:master into 026e8ef054b1e2053d6f690d7113a7e94863b546 on mcanevet:master.

@dmitryilyin could you please not mark unit tests as pending?

But almost all of them are marked as pending there.

ping

Test still pending...

Coverage decreased (-0.2%) to 94.545% when pulling de7b7736184c8d7f7506aededb94675207e0b16f on dmitryilyin:master into 026e8ef054b1e2053d6f690d7113a7e94863b546 on mcanevet:master.

Coverage decreased (-0.2%) to 94.545% when pulling 498edd41223c2b80a73bc50895ab487189cd3588 on dmitryilyin:master into 026e8ef054b1e2053d6f690d7113a7e94863b546 on mcanevet:master.

@dmitryilyin o_O, there is way more things in this commit...
Some kind of automatic refactoring?

Nope, everything is done manually, it's just when you start fixing things you cannot stop)

Ah, and the PR comment was not auto-updated. Updated it manually.

Coverage increased (+3.5%) to 98.276% when pulling 48ae933f58435f49ce245f97f22fc8dda2e2db68 on dmitryilyin:master into 026e8ef054b1e2053d6f690d7113a7e94863b546 on mcanevet:master.

Coverage increased (+5.3%) to 100.0% when pulling 47efecbd1bc81a012b11f247f5adf8eb2a6a6a41 on dmitryilyin:master into 026e8ef054b1e2053d6f690d7113a7e94863b546 on mcanevet:master.

Coverage increased (+5.3%) to 100.0% when pulling 2b2975b16a910bbf680c5a0314b8aa7d76bcfa8f on dmitryilyin:master into 026e8ef054b1e2053d6f690d7113a7e94863b546 on mcanevet:master.

Got 100% )

@dmitryilyin I really want to merge this, but it's quite big and unreadable right now... Would it be possible to split this in smaller commits?

And why do people always ask me this? I would always prefer to read a single large patch all in one place then a group of small patches. Besides, it's not easy to make them meaningful separately and they are nightmare to maintain and test.
Ok, i'll try to split this somehow...

Coverage increased (+3.0%) to 97.701% when pulling f87eb22523813588ca3f072cb5a7d3070be6d372 on dmitryilyin:master into 026e8ef054b1e2053d6f690d7113a7e94863b546 on mcanevet:master.

Coverage increased (+4.1%) to 98.851% when pulling a2913f50607fd80b85173b3fb78bbf2f0787cb63 on dmitryilyin:master into 026e8ef054b1e2053d6f690d7113a7e94863b546 on mcanevet:master.

Coverage increased (+5.3%) to 100.0% when pulling a2913f50607fd80b85173b3fb78bbf2f0787cb63 on dmitryilyin:master into 026e8ef054b1e2053d6f690d7113a7e94863b546 on mcanevet:master.

I've managed to split only the refactoring and adding filter parts.

@dmitryilyin it's better but the first commit is still way too big IMHO.
Could you please split this 3 points in different commit?

Cleanup the methods and some minor
refactoring without introducing any
new featutres
Add inline YARD documentation
and yard doc actions to the Rakefile
Refactoring and improvements of the
RSpec tests

I can do it myself if you don't have time. If so, do you want me to put you as the author of the commit?

Sigh... Ok, i've done as you requested

Coverage increased (+5.3%) to 100.0% when pulling c56ec905ef97c0850f592f729020e4a327d34dd8 on dmitryilyin:master into 026e8ef054b1e2053d6f690d7113a7e94863b546 on mcanevet:master.

@dmitryilyin ok LGTM now. Thanks


HIstorical data for all stocks

Just saw that there is a historical data for each stock.
Eg: http://phisix-api.appspot.com/stocks/TEL.2015-01-19.json
Is it possible to include a historical data also for all stocks like the one below?
http://phisix-api.appspot.com/stocks.2015-01-19.json
Thanks :)

i second!!


Is there Any way we can support leetcode-cn.com

Is there Any way we can support leetcode-cn.com

ping @JacobLinCool

@fabian4
Sorry for the late reply.
I think it is possible to support Leetcode-CN since they both provide GraphQL API.
The problem is that their data schemes are quite different, so it would need some work to "normalize" them.
I don't know if there is any package that can do this for us?
I would like to support that feature after I rewrite the messy codebase.
Thank for your advice.


TransferManager.shutdownNow() does not work

Hello! I am experiencing the same problem described on this AWS forum post: https://forums.aws.amazon.com/thread.jspa?messageID=593757. As I described it there:

I have a web app that uses TransferManager from server side to upload some files. When I use transferManager.shutdownNow() it gives me the RejectedExecutionException. When I do not shutdown the TransferManager, then it stops working after a 1000 threads are opened.

This is causing huge issues in my Grails app which I am struggling to solve. I read some of the code from the plugin's AmazonWebService.groovy file and in its getTransferManager method I realized that you are getting the TransferManager "singleton" from a list with the regionName as the key. Therefore, I think that when the TransferManager is shutdown with transferManager.shutdownNow() method and I retrieve it again on a next iteration, the TransferManager's instance is already down.
Can you think of any elegant way to prevent this without having to always create a new TransferManager instance using new TransferManager(getS3(regionName)) as it is done right now in the AmazonWebService.groovy file?

This issue should be opened with the AWS java SDK project.


Fix alpine socket bug

In case of an UnsatisfiedLinkError (which will happen if needed system libraries are missing) when trying to access Docker via Unix socket, a proxied Unix socket is used as a fallback on Linux instead. In addition, the check for determining the concrete HostPortWaitStrategy behavior now depends on mac as an OS.
However please note, that the existing mac workaround might not work if using images that don't contain bash or sh.

This is looking great, thanks. Let's aim to merge tomorrow, and I'll release tomorrow night.

Just testing locally then will merge

Merged manually- thanks!


Update package.json

Version bump to make everything node >=0.6.10 compatible. See https://github.com/felixge/node-require-like/pull/3

Applied in b55b633f1ca5a05c7817cbb1c85406de6030559e and released as v0.1.3. Please do not bump the main package version, that's my job! Kidding aside, I do like those bumps in separate commits as well as using tags, and I don't think tags can be included in pull requests.
--fg

Oh of course, you're so right, sorry. I was a bit overwhelmed by that new github feature: "Fork and edit this file"... Crazy shit!


Test Dependen Issues action

Dependencies:

Depends on #2

This PR/issue depends on:

beltranaceves/gen_dsl#2
By Dependent Issues (🤖). Happy coding!


Moving to resource popup window questions

Hi Tom,
The first, thanks for writing & maintaining this fantastic peace of software!  A lot of hard work man .... Thanks!
I have a few question/enhancements(?) as i not sure they exist yet:

Is possible to remove from key string formatted placeholders for C# moving to resource popup window ? For example : "My name is {0}." or $"My name is {name}."  The result is 'MyNameIs0'

Is it possible to remove English 'the' and 'a' as they worthless junk for meaning or readability

Can we have configurable (like drop-down in configuration) how to compose the resource key for example:
{Class}{Mehtod}{Key_Phrase}   or
Mehtod}_{Key_Phrase}   or
{Key_Phrase}  just

Let's say we having very long phrase like:
"The resolution key field for the resolution level '{0}' is null. Try restarting the workflow manager service or resetting the resolution key" I think it would be nice to check for phase with 50 chars+ get first  char '.'  after that and truncate use sub-string only so ti suggest something like ResolutionKeyFieldForResolutionLevelIsNull

This would cover most scenarios for most folks. Like we have huge project and we have hundred resx files spitted by module or group so {Key_Phase) its the best, but for other on small projects they might need {Class}{Mehtod}{Key_Phrase} which is good practice...

Thanks in advance for your time, Jim

I found that however hard you try, keys generated from text are usually bad and have to be edited anyhow, so I simply put in as much info as possible, because deleting is easier typing.
However you have some good arguments there, maybe you want to provide a PR with a more sophisticated solution. The code that generates the key is here:
https://github.com/tom-englert/ResXResourceManager/blob/master/ResXManager.VSIX/Visuals/MoveToResourceViewModel.cs#L184

Hi Tom,
I think i found solution top please everybody . As developers we overthinking sometimes ... Look that we need just token replacement dictionary essentially.
So user in GUI enters in configuration tab something like key/value pairs
" & "  => " and "
"{0}"  => ""
"The " => ""
" the " => ""
...
and so on everybody customizes according language and their requirements as pleased
now that what left for you (last part):
var builder = new StringBuilder(phrase);
for item in dictionary
builder.Replace(key, value)

Very simple no performance overhead like some crazy regex or C# code. Easy implement i guess & pleasing everyone ... What do you think?

Yes, generally sounds good. However do you think the replace is really necessary?
Replace "&" with "and" and then replace "and" with nothing sounds like overkill.
If we just provide a list words to remove, and maybe allow regex (there is no need to consider performance, it's executed once per mouse click), configuration would me much simpler.

Hi Tom,
This just an example to show that even most picky folks can do what they want for naming  and  your software is great for customization ...  :)


Send emails asynchronously

This mainly changes the email sending behaviour so they happen asynchronously with ActionJob. Since moving to Notify we've had to send emails individually which when happening inside the request leads it to time out.
I've also made a few extra fixes and tidied up a few other things, see individual commits for more details.
Depends on #459.
Trello Card

I was hoping to get #459 merged in separately and then rebase this so it's not quite as big!


Scrobbler doesn't works for the albums

It works perfect. From youtube, deezer, spotify (open), and so on. But i noticed something, the scrobbles for the album doesn't work. I mean if i listen a whole album, the scrobble of the artist and the songs are there, but not the album ones... Could this be fixed? I know i can added manually, but  i do not wanna do this anytime.
Besides this, the add-on is perfect! Thanks a lot
Thanks!

Some websites don't provide album title, so there's no way to get album info of now playing song.
In next update the extension will automatically retrieve album title from Last.fm.

Thanks a lot! it was weird, i guess deezer provided it, but i think not. Anyway, amazing job and many thanks!

Also happened with spotify, but anyway, i am glad to hear that this will be fixed in next extension


feature-request: synth upgrade-jail

I don't know if this is possible but it would be nice to have a synth upgrade-jailcommand.
It could retrieve the jail's packages, rebuild what is necessary and upgrade the jail using pkg -j.

the request makes zero sense.
poudriere has "jails", synth does not.
there are no packages inside a synth builder.
The request basically makes no technical sense at all.  (not to mention it goes completely against the design target of Synth)

I think I didn't explain this properly:
The command would be used to upgrade jails that run under the host system.
If I have a jail called "mail" I can issue pkg -j mail upgradeor pkg -j mail install postfix-currentor even pkg -j mail upgrade -f -r Synth (if Synth's repository is null-mounted into the jail).
Maybe Synth could upgrade jails the way it upgrades the host system.
Just an idea…

That's out of scope.  Synth's job is to create local repositories and as a special feature, interface with host system pkg(8) to update that system with a single command.  Beyond that, the user would have to manually update clients of the repository.
I would think the sysadmin would want to do this manually anyway.

Since synth is scriptable, I suggest the solution is to write a script to update the jails and command synth as necessary.
The main problem with scripting Synth though is failure due to obsolete port options.  Whenever a port option changes Synth is just going to stop and ask the user to fix it first.
I know I'll never add a command for this use case (particularly since there are other solutions) so best just to close it now.

👍🏻


druid segments on HDFS not used by historical

druid coordinator not load old interval segments after I changed load rules from P10D to P1M.
Affected Version
0.11.0
Description
rule config and loaded interval segments  only has latest 2 days .

metadata interval and hdfs files:

when I start a index_hadoop task , it failed. message is interval not exists.

The interval segments exists, but the mysql metadata column used is 0.

Any one had same problem ? Any Suggestions?

I resolve this problem by reconfig drop rule. Now I use load forever.
Enable segment manually.
curl -X POST http://druid-others-001:8081/druid/coordinator/v1/datasources/market_trade_jjz_order_ds/segments/market_trade_jjz_order_ds_2019-06-19T16:00:00.000Z_2019-07-09T16:00:00.000Z_2019-07-09T20:12:16.208Z

But I don't know the reason why data in the rule interval not loaded. It seems like the coordinator update the segments used to false after I manually enabled.


Added solution to Use the CSS Transform scale Property to Scale an Element on Hover

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


RuntimeError: Internal: src/sentencepiece_processor.cc(1101) [model_proto->ParseFromArray(serialized.data(), serialized.size())]

Hello, I have been trying to use VideoChatGPT for single video inference/video demo and am having diffulties getting set up. I have followed the installation setup as laid out by the readme, and have downloaded the llava weights per this issue post:
git lfs install git clone https://huggingface.co/mmaaz60/LLaVA-7B-Lightening-v1-1
yet, when I run this script:
python video_chatgpt/demo/video_demo.py --model-name /home/Video-ChatGPT/LLaVA-7B-Lightening-v1-1 --projection_path /home/Video-ChatGPT/video_chatgpt-7B.bin
I get the following error:
RuntimeError: Internal: src/sentencepiece_processor.cc(1101) [model_proto->ParseFromArray(serialized.data(), serialized.size())]
which occurs during the AutoTokenizer.from_pretrained(model_name) call in video_chatgpt/eval/model_utils.py.
I have reattempted downloading the weights on the off chance that the .bin files are corrupted, but the error persists. I have checked that I have the correct package versions, and they seem to match what is in requirements.txt and the config.json file in the /LLaVA-7B-Lightening-v1-1 folder (it expects "transformers_version": "4.28.0.dev0", which is what is installed).
According to these posts, this error could occur from a corrupt .bin file or not using the correct tokenizer. Though from my understanding, AutoTokenizer is a generalized wrapper so I don't think this is what is causing the error.
Any help is appreciated, thanks.

Hi @rjccv
Thank you for your interest in our work. The error seems to be generated because of either the corrupted checkpoints or a different transformer version. Can you double check if the error persists after installing the transformers using the following command?
pip install transformers@git+https://github.com/huggingface/transformers.git@cae78c46

Further, please provide the environment and hardware details you are using to comment further. Thanks

Thank you for the quick response. When running this line, a warning in the git log mentions that the branch or tag cae78c46 could not be found:

This is the version that appears as installed when I check run conda list transformers

In LLaVA-7B-Lightening-v1-1/config.json, the transfromers_version matches the output of my conda environment, so I don't believe that is the cause.
{
"_name_or_path": "liuhaotian/LLaVA-Lightning-7B-delta-v1-1",
"architectures": [
"LlavaLlamaForCausalLM"
],
...
"transformers_version": "4.28.0.dev0",
"tune_mm_mlp_adapter": false,
"use_cache": false,
"use_mm_proj": true,
"vocab_size": 32003
}
I did notice though in LLaVA-7B-Lightening-v1-1/tokenizer_config.json that there is an argument "special_tokens_map_file" that points to a checkpoint folder not present in my directory. Could this be causing the issue? If I need this installed, where can I download it from?
{
...
  "special_tokens_map_file": "./checkpoints/vicuna-7b-v1-1/special_tokens_map.json",
  "tokenizer_class": "LlamaTokenizer",
  "unk_token": {
    "__type": "AddedToken",
    "content": "<unk>",
    "lstrip": false,
    "normalized": true,
    "rstrip": false,
    "single_word": false
  }
}

Alternatively, if this is not the issue and it is corrupted checkpoints, is there another method for downloading them? As mentioned in the link I referenced, huggingface never sends out an email for the Llama weights, so that doesn't seem like an option.
I am attempting to run this on one RTX 3080 Ti GPU.

Hi @rjccv

Can you try using special tokens maps from https://huggingface.co/lmsys/vicuna-7b-v1.1? Also please try loading the base vicuna model and see if the issue appears there as well. Thanks

Okay I have changed the path of "special_tokens_maps" to point to the local special_tokens_maps.json file since the two are the same. And I am able to load the base model  without any errors when I replace the script as below:
    # # Load tokenizer
    # tokenizer = AutoTokenizer.from_pretrained(model_name)

    # # Load model
    # model = VideoChatGPTLlamaForCausalLM.from_pretrained(model_name, low_cpu_mem_usage=True, torch_dtype=torch.float16,
    #                                                      use_cache=True)

    tokenizer = AutoTokenizer.from_pretrained("lmsys/vicuna-7b-v1.1")
    model = AutoModelForCausalLM.from_pretrained("lmsys/vicuna-7b-v1.1")

tqdm did display stderr when loading both bin files, but they seem to have loaded? This is now my issue. It seems like this is now related to compute? Is it possible to run inference on a single RTX 380 Ti?

I was able to resolve this. The bin files were indeed corrupted, but because I didn't have git-lfs installed globally. No error appeared after git lfs install because of the sequential executing command.
git lfs install
git clone https://huggingface.co/mmaaz60/LLaVA-7B-Lightening-v1-1

After installing this and properly downloading the weights, your model worked as expected. Anyway, thank you for all your help. I'm looking forward to playing around with your model.


Change IGN WMTS example to use PLANIGNV2 layer

Support of the pratique and choisirgeoportail keys has changed again https://geoservices.ign.fr/blog/2021/01/29/Maj_Cles_Geoservices.html and neither now support the GEOGRAPHICALGRIDSYSTEMS.MAPS layer.  While GEOGRAPHICALGRIDSYSTEMS.MAPS remains supported by free personal keys obtained (temporarily) via https://www.sphinxonline.com/surveyserver/s/etudesmk/Geoservices_2021/questionnaire.htm#1 these require security settings such as referer which would make them unsuitable for users editing the example in codesandbox, so it seems appropriate to use the new GEOGRAPHICALGRIDSYSTEMS.PLANIGNV2 layer instead.

Thanks, @mike-000


is there a way to change Expression

Is there a way to change expression instead of creating a new Expression object each time especially I need to add custom operator before evaluating expression.

No, but you can always write a factory method which does all the basic setup of the Expression.
I believe it would be rather easy to add, but as far as I know there isn't a way to remove a variable/function once added to the Expression, so being able to  set a different expression does only make partially sense.

This is an example of using Factory Pattern to generate expression that have our own custom operations.
The following code in kotlin, you can find any java equivalent easily.
class ExpressionFactory {
    companion object {
        fun createWith(
            expression: String,
            mathContext: MathContext = MathContext(128,RoundingMode.HALF_UP)
        ): Expression {
        val expressionEvaluator =  Expression(expression.toText(), mathContext)
        // Add all custom operations / Functions
        return expressionEvaluator
        }
    }
}


Improve javadocs

Javadocs are mainly a copy/paste of the redis documentation. We need to change them to represent proper java types and exception handling.
There are also methods which doesn't have any javadoc at all.

Just ran into #976 as well and finding the docs lacking.
Whats the status on this issue?

@kag0 we're working on some important core features of Jedis at this moment and we're only two active collaborators. Any help would be much appreciated :smile:

I thought about Javadoc a little.
As Marcos said, we're only two active collaborators.
I'm wondering we could perfectly maintain source codes with javadoc. It was already nearly unmaintained, and I think it can't be changed unless we have many active contributors or collaborators.
Btw, we can move javadoc from implementations to interfaces, and use @inheritDoc tag to reduce amount of duplicated comments.
@marcosnils What do you think?

@HeartSaVioR moving Javadocs to interfaces seems the right way to go. I don't have time to do that kind of work at this moment, hopefully some new collaborator would help :)

OK. I also think we may just replace the explanations for the command to link to Redis doc, since it is actively maintained with many contributors.

If we replace javadocs with redis links then users without internet connection won't be able to see the docs (which is kind of sad). Redis docs are stored in a JSON format in the redis page repo.
Maybe we can annotate the javadocs in some way which allows us to run a simple program which takes the commands description form the redis json doc and replaces it into Jedis. I'm not sure about this exactly but I agree with you that maintaining the documentation is quite messy as we don't have the enough collaborators to do it ATM.

javadocs support html in the comments, so you could potentially do something there with the redis docs. Wouldn't fix issues like #976 though.
I wouldn't be opposed to helping to get some native docs in place, I just don't know when I'd have time. At bare minimum it shouldn't be hard to get default javadocs up on gh-pages as a starter.

@kag0 :+1:

@marcosnils can you please create a gh-pages branch (off of master) so I can open a PR into it?

@kag0 Done.


Mismatched anonymous define() module

I'm trying to use ngTable with require.js and  head.js but I'm getting the following error:
Uncaught Error: Mismatched anonymous define() module: function (angular) {
return factory(angular);
}
Here is my require config:
(function(head){
    'use strict';
    head.js(
        { jquery: "../vendor/jquery/dist/jquery.js"},
        { require: "../vendor/requirejs/require.js" },
        { angularjs: "../vendor/angular/angular.js" },
        { uiRouter: "../vendor/angular-ui-router/release/angular-ui-router.js" },
        { angularTable: "../vendor/ng-table/ng-table.js"}
    ).ready("ALL", function(){
        require.config({
            appDir: '',
            baseUrl: '',
            paths: {
            },
            shim: {
            }
        });

        require(['config'], function(config){
        });
    });
}(window.head));

Can anyone help me with this problem?

+1

yay, it closed

Know this closed but still shows up in a search result, so instead of crushing the brief glimmer of hope, I found a lead to the issue based upon a SO answer.
http://stackoverflow.com/questions/26992356/ng-table-mismatched-anonymous-define-module/27778108#27778108
TL;DR - Load this library with RequireJS or fork it and remove the define() call from the src.


chore: update dependencies to angular 7

The dependency updates to angular 7,8 and 9 are still outstanding.
Is this library still maintained ?


Scroll view content offset reset

When a UIViewController is pushed over the UIViewController that has the SHViewPager, on popping that top UIViewController the content offset of the scroll view of the SHViewPager is reset to zero (0) regardless of the last position of the content offset.

Hello, the bug can be fixed if the UIViewController that has the SHViewPager, call the method [self.viewPager pagerWillLayoutSubviews]; called in - (void)viewWillAppear:(BOOL)animated.
In addition, i created method of -(void)moveToTargetIndexWithoutAnimation in SHViewPager.m, duplicate method of moveToTargetIndex but without animation.
And the result, when a UIViewController is pushed over the UIViewController that has the SHViewPager,
on popping that top UIViewController the content offset of the scroll view of the SHViewPager back to the last position of the content offset.

Anyway, your project library really helps me out, thanks a lot for creating this awesome viewpager for ios!

@ksandyasa , thank you! Could you please create a pull to merge request so that this solution can be merged with the master brunch?

I can't push to master branch because i don't have permission to push it aka permission denied..

Please fork the source, make the changes and then commit. After that you'll be able to make a pull to merge request.


Easy, medium, hard levels added in Memory Game

Description
Easy, medium, hard levels added in Memory Game
Issue #4
Add relevant screenshot or video (if any)

You did a great work @Jagannath8 Thank you :)


⚠ Bofrost.be has degraded performance

In dd641e2, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1714 ms

Resolved: Bofrost.be performance has improved in f25bb16 after 7 minutes.


re-organise badge examples

Following on from https://github.com/badges/shields/pull/1762#issuecomment-406896626 I've extracted the changes to the examples. This re-shuffles the examples into categories:

Build
Chat
Dependencies
Downloads
Funding
Issue Tracking
License
Rating
Social
Version
Other

#1762 can be rebased on to this later.

Warnings

:warning:

This PR modified services/gem/gem.js but not services/gem/gem.tester.js. That's okay so long as it's refactoring existing code.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @chris48s!

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

  Generated by :no_entry_sign: dangerJS

Yes- good suggestion. I wrote this little script to do that:
const allBadgeExamples = require('./lib/all-badge-examples');

var examples = [];
allBadgeExamples.forEach(function(category) {
  examples = examples.concat(category.examples);
});
var previewUrls = examples.map(function(example) {
  return example.previewUri;
});
previewUrls.sort();
previewUrls.forEach(function(title) {
  console.log(title);
});
console.log(previewUrls.length);

Running that on master and my branch revealed there were a couple of things that got lost somewhere, so I've fixed those in 0076a6e .
Now I get the same result from running that script on my branch and latest master. You should be able to check that if you want.

For convenience, if you do want to test the way I did it was I ran that script, piped the output to a file on each branch and then diff the 2 output files.

Thanks for doing that!

This is live.


add support for merged results

problem:

user-made result functions for GV often have scalar return value, so a single mat file stores a single scalar number
there can be thousands of mat files each storing a single number
filesystems don't handle lots of little files well

solution:

have function that merges results into single mat file with 1 cell per sim and add suffix like, 'merged'.
also add support to dsImportResults
add flag to automatically merge results and optionally delete original separate results

made dsMergeResults that calls dsImportResults

todo: add ability to fill in missing new results

add faster moveAllContents flag which just renames results dir.


libzmq3 vs libzmq5

I don't have libzmq3, though I do have libzmq3-dev. Do you expect this to work ok with libzmq5, which is present?

I'm using PyZMQ internally, so I think the answer is "whatever pyzmq can use", which looks like any version >= 2.1.4


add a conda-env-export endpoint

Closes #12
It looks like this:

Closing since this was worked into #92. Thanks for all the hard work on this! Needed to add the celery backed bits in #92.


Do not cull all but one DLCs

Fixes https://github.com/itchysats/itchysats/issues/2070.
The cull_old_dlcs API was meant to delete the old DLC data of all CFDs. The implementation had a huge bug which instead deleted all DLC data (old or current) for all open CFDs, except for the data of the oldest DLC-related event ever.
We modify the test that was meant to verify that we don't delete unexpected stuff when calling this API to make sure that we don't introduce a similar bug in the future.

Superseded by https://github.com/itchysats/itchysats/pull/2073 and https://github.com/itchysats/itchysats/pull/2074.


Use the dlami module from the terraform-modules repo

@alexwlchan update those refs :)

The third commit is a rebased version of the old branch with an updated reference, and I’ve run a local plan to confirm it works. Merging without waiting for a full Travis run.


The Universal Datatype

level: advanced
language: en
twitter: @sergimansilla
tags:

rxjs
reactive
javascript

In this talk I'll introduce reactive programming using RxJS and it's central concept: the Observable Sequence. Observable sequences give developers super-powers by letting you manage asynchronous code with ease, and think about complex flows of events as if they were all synchronous, abstracting time in a way you've never seen before. You can think of it as a simpler Promise, but on steroids. I'll show you some cool programs and examples straight from my Reactive Programming book, and if there is time, I might try to even do some live-coding!

Sorry, could you please copy over the talk to the speakers repo https://github.com/BarcelonaJS/speakers? Thanks!

@sergi I'd appreciate if you could copy over the talk as I can't do it.

@sergi are you interested in presenting this talk in the February meetup? If so, please create the issue in https://github.com/BarcelonaJS/speakers repository.
Thank you

Hi @PatrickHeneise @dgil, sorry I didn't see the notification for this. I'll do that now.


Avoid actual filtering, if ids have not changed. #1751

Check if ids have been changed before filtering, avoiding expensive memory operations.
In the case of mantel, identical ids are the norm, so optimization of this scenario is warranted. #1751
Please complete the following checklist:

[x] I have read the guidelines in CONTRIBUTING.md.

[x] I have documented all public-facing changes in CHANGELOG.md.

[ ] This pull request includes code, documentation, or other content derived from external source(s). If this is the case, ensure the external source's license is compatible with scikit-bio's license. Include the license in the licenses directory and add a comment in the code giving proper attribution. Ensure any other requirements set forth by the license and/or author are satisfied. It is your responsibility to disclose code, documentation, or other content derived from external source(s). If you have questions about whether something can be included in the project or how to give proper attribution, include those questions in your pull request and a reviewer will assist you.

[x] This pull request does not include code, documentation, or other content derived from external source(s).

Note: REVIEWING.md may also be helpful to see some of the things code reviewers will be verifying when reviewing your pull request.

CC @wasade

CC @wasade

Looks like there is a conflict and possible real failure on py3.6

Looks like a possible real failure on py36

Looks like a possible real failure on py36

@wasade All tests are passing
Did I miss something?

looks like its passing now, but there was a prior failure (see https://github.com/biocore/scikit-bio/runs/1841515590#step:6:183) which appears to be the stochastic one on small floats in the treenode doctest. I'll clean up the conflict here and merge in a mmoment


Bad type inferring on big JSON file

Bug Report
Introduction
This problem is difficult to reproduce. I can't use Playground because I need to add external JSON files.
So, I'm sorry if I can't help you with more explicit context.
Context

Typescript version: 4.7
Tsconfig:

{
    "compilerOptions": {
      "target": "ES2017",
      "module": "commonjs",
      "declaration": false,
      "declarationMap": false,
      "skipLibCheck": true,
      "sourceMap": true,
      "outDir": "./dist",
      "rootDir": "./",
      "allowSyntheticDefaultImports": true,
      "esModuleInterop": true,
      "forceConsistentCasingInFileNames": true,
      "resolveJsonModule": true
    },
    ...
  }

Problem
When I import an external JSON file, I want to have his type.
No problem example
I can do this with simple JSON, no problem:
JSON

test-with-array.json

[
    {
        "a": 1,
        "b": 2
    },
    {
        "toto": "abc"
    }
]

Typescript
import testWithArrayDatas from './test-with-array.json';

type JsonWithArray = typeof testWithArrayDatas;

Result

Problem example
But if I do the same thing with a big JSON file, Typescript does not find type:
JSON file
test-with-big-array.json.zip
Typescript
import testWithBigArrayDatas from './test-with-big-array.json';

type JsonWithBigArray = typeof testWithBigArrayDatas;

Result

You can look the type seems to be {}. That's not true ! The minimum true type is any[]
or Record<string; unknown>.
Attempted
A choice:

Find the minimum good type: any[] instead of {}
Display a warning to prevent user that the type inferring can't analyze all because it's too important/large
Purpose a property in tsconfig to set maximum size of variable type inferring analyze

Note
I could see that between a minimum size of JSON and more bigger, the result is any[].
In the idea:

small JSON
big JSON
really big JSON

good type
any[]
{}

You can look the type seems to be {}. That's not true ! The minimum true type is any[] or Record<string; unknown>.

42 and "hello" are valid top-level JSON results; those values are {} but are not Record<strings.
The current behavior is still correct. I think it's extremely unsurprising for TS to refuse to try to make sense of 38 megabytes of JSON.

Display a warning to prevent user that the type inferring can't analyze all because it's too important/large

I'm trying to imagine how an algorithm that works based on how "important" the data is would look like...

I assumed that was mistranslation of a word meaning "weighty" 😉

42 and "hello" are valid top-level JSON results; those values are {} but are not Record<strings.

@RyanCavanaugh Although technically, null is valid top-level JSON as well, but not assignable to {}.

130 megabytes of json don't work either! This bug is real and I have github actions to prove it. Locally it works fine, but when I push it to github, it won't work no matter what. I'm going to try to break the json into smaller ones. If you guys are curios, go see "actions" on my repository called sitedeploy .


Postgres does not like lowcased names

Customer reported that in order to make TOM work with PostgreSQL one need to do this tweak;
--- a/lib/model/db/leave.js
+++ b/lib/model/db/leave.js
@@ -57,7 +57,7 @@ module.exports = function(sequelize, DataTypes) {
fields : ['leaveTypeId'],
},
{

       fields : ['approverid'],

       fields : ['approverId'],
   },
 ],
 classMethods : {

Fixed by #126


Credentials in Credential Endpoint Response in an array

See https://github.com/openid/OpenID4VCI/pull/391#pullrequestreview-2319901526

Deprecated, now we have credential and credentials to differentiate the json member type within the credential response
Do we want to handle batched issuances within the credential endpoint in this milestone?
-> next-milestone


fix: gvki now gracefully exits when OpenCL 2.0

SVM Pointer is created. This kind of interception
is not supported yet. The gvki wrapper script will
detect this error and report at the end of the processing.

lib/InterceptedHostFunctions.cpp:

intercepts clSetKernelArgSVMPointer, prints a message and exits

scripts/colors.py:

python colored terminal module

scripts/gvki.py

detects gvki error and logs errors to a file
error report at the end of the processing
using absolute paths for better compatibility
improved pattern for script/module launching

scripts/kernel_preprocess.py

improved pattern for script/module launching

scripts/.gitignore

now ignores .pyc files

I'll be going ahead and accept this request since this is more of a testing branch and, as far as I can tell, there are no functional differences in how gvki behaves. However, the colours are extra and we should consider if we want them in the original gvki once (and if) we merge the branches.


Can't find how to modify the device administrator role

I can't find this option: "Manage Additional local administrators on all Azure AD joined devices"

And I DO have AAD Premium P2.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 823c9751-c496-f972-3b1b-640a1bd81412
Version Independent ID: 6951f3d5-c766-133c-4785-9cd4192bae19
Content: How to manage local administrators on Azure AD joined devices
Content Source: articles/active-directory/devices/assign-local-admin.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@epomatti
Thank you for your post!
Can you also make sure that the user you're signed in with has the correct permissions? i.e. Global Admin.

@JamesTran-MSFT I had to exit and enter the Portal again 🤦restarting the browser did it for me.

@epomatti
Thank you for following up on this and I'm glad that you were able to resolve this issue!


Error when trying to open channel: macaroon validation failed

Issue Description
When attempting to open a channel at https://terminal.lightning.engineering/#/channels/open (from a remote machine) I receive an error message and cannot proceed.
Expected behavior
Channel opens successfully.
Actual behavior
Upon selecting the 'Open Channel' button, below error message appears and channel does not open:
UNABLE TO OPEN CHANNEL
rpc error: code = Unknown desc = lnd macaroon validation failed: rpc error: code = InvalidArgument desc = permission denied
To reproduce
With below mentioned system information:

Go to https://terminal.lightning.engineering/#/dashboard and select Open Channel on any recommended channel
Enter SATS amount and FEE RATE
Select Open Channel button
--> Error

System information

Machine / Server: AWS EC2 t3.medium Instance / 2 vCPUs / 25 GiB storage / Ubuntu 22.04.1 LTS
Setup guide (neutrino config): https://github.com/alexbosworth/run-lnd
LND Version: V0.15.1-beta
Lightning Terminal Version: v0.8.0-alpha installed from github binaries as per https://docs.lightning.engineering/lightning-network-tools/lightning-terminal/get-lit
Lightning Terminal Mode: I would assume lnd-mode=remote as I have not adjusted the default settings although I am not sure how to check this definitively
Remote machine displaying error: Windows 10 Home / Chrome OS Version 106.0.5249.91

Extra Info
I have tried deleting all .macaroon and macaroons.db files inside of all folders, restarting lnd / litd and starting a new lightning terminal session. All deleted files were recreated but I still get the same error
Note that I am able to see my node alias and correct sat balance in the lightning terminal.
ATTACHMENTS
Error screenshot

litd log file...
litd.log

To connect to terminal.lightning.engineering, what kind of session did you create in your local LiT instance? Was that a read-only session perhaps?

Thanks @guggero for taking a look at this.
I am not sure how to the check the LiT session type but what I did is follow these instructions https://docs.lightning.engineering/lightning-network-tools/lightning-terminal/run-litd#docs-internal-guid-fa69f7a0-7fff-8b6a-aadb-a1932e40738b
In other words, I logged into my aws ec2 instance via ssh, started up lnd and litd and then typed litcli --lndtlscertpath ~/.lit/tls.cert sessions add --label="default" into the command line.

Hi @cliffpeskin , yes that command will create a read-only session :) to create an admin session you can add --type=admin to that command

Awesome, thanks @ellemouton and @guggero ! Have been stuck on this for days.

Thanks for pointing this out! We should defs update the docs to explain how to create an admin session 👍


BinaryImageClassification

Description
A requests for the Implementation of BinaryImageClassification and a documentation for this feature, it would benefit developers which are trying to detect if a Image is similiar to another one or not. This Feature can then be used for checks like, Image similiarity and filtering Systems. It would also benefit newer developers, like me, which do not completly understand the way of how everything directly works.

I mean with Binary image classification a one class classification.

@DxsSucuk You can consider using transfer learning; use pre-trained model to get vector embedding of pictures. Then it can be used for the downstream tasks like one-class classification. We are working on part of this feature now.

Here is an example of binary classification on image, using transfer learning. It should be able to similarly apply to the use case you mentioned.

Here is another example: https://github.com/frankfliu/visrec-djl/blob/master/jsr381/src/main/java/ai/djl/jsr381/spi/DjlBinaryClassifierFactory.java#L45

Thanks I will look into it!


Updates for v3.4.4.

Description

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit c3c7dc37acde0828fb9761ee98bdde41068bee65
https://deploy-preview-2512--calico.netlify.com


Strech mode settings stopped working on master

Godot version:
master (23b7670d32c566acd62870c73676531eb187aa94)
OS/device including version:
Linux 5.6.7-arch1-1
Issue description:
Expected result (3.2.1):

What I got (master):

Steps to reproduce:

Minimal reproduction project:
Strech_Mode_Not_Working.zip

Seems to work fine in current master (after taking into account the rename of Test Width and Test Height).


Feature/chat wallet app extraction

Remove wallet from Chat app
Implement new Wallet app with updated design using Web3Wallet lib

[ ] Breaking change
[x] Requires a documentation update

@llbartekll updated with session request and PR fixes

Is it possible to fix modal background appearance on "Enter a WalletConnect URI" screen? Not critical

Why WalletApp redirect to Showcase after Approving Auth Request?

Why WalletApp redirect to Showcase after Approving Auth Request?

@flypaper0 in showcase you receive Cacao object after, this redirection is kind of success imitation, but I can remove it or change if needed


SchemaRegistry: Add missing schema descriptions in swagger

Added descriptions for SchemaId.id, SchemaGroup.name, SchemaGroup.createdTimeUtc, SchemaGroup.updatedTimeUtc, and SchemaGroup.schemaType.

@arerlend, @hmlam,
These changes to the swagger were needed to fix the errors found when trying to generate the .Net SDK.
See https://github.com/Azure/azure-sdk-for-net/issues/13471#issuecomment-662745525

Yeah looks good, thanks for making the changes.
FYI - it is looking like we are going to have to switch to Swagger 2.0 for azure-rest-api-specs, but there will be no functional difference between the 3.0 and 2.0 specs, so I don't foresee issues with C# client dev.

Yeah looks good, thanks for making the changes.
FYI - it is looking like we are going to have to switch to Swagger 2.0 for azure-rest-api-specs, but there will be no functional difference between the 3.0 and 2.0 specs, so I don't foresee issues with C# client dev.

AutoRest converts all OpenAPI 2.0 documents to 3.0 internally for new generators. So, it really doesn't make a difference either way. Whatever the specs repo needs, go for it.

This is no longer relevant.


Data Explorer: Clicking submit a query is taking too long

This delay is happening in the data explorer whenever i click the submit button. Clicking the button should register instantly for the user.

@Asalem1 does the PR you have solve this issue or just add a cancel button?

Both. It address the issue that clicking submit should immediately set the button value to a loading state rather than waiting for the query to compile and execute. @russorat I just merged the changes onto master if you wanna see if the issue is resolved for you. If it is, feel free to mark it as closed, otherwise let me know and I'll see about speeding the event up some other way

This is what i see in the data explorer in us-west this morning. There is still a noticeable delay when interacting with the button.

Hmmm, would you mind sending me a link to a dashboard that's experiencing this? We're setting the state on click so I'm not sure where the delay is coming from. We've got a feature enhancement request coming up to half a second until the cancel text displays (so that it doesn't flash so abruptly). I'm wondering if that might help in the perception that the event didn't register?