[Bug]: Dialog Scroll Issue When Keyboard is Shown on Android 9

Summary
This issue arises only on Android Version 9. It works well on Android 14.
About Issue
When you click on edit-text the keyboard appears, but there is no way to scroll the dialog and reach to the submit button.
Thus, making it unavailable to submit the valuable feedback by the user.
I have fixed this issue locally its one line fix.
Objects.requireNonNull(getWindow()).setSoftInputMode(LayoutParams.SOFT_INPUT_ADJUST_RESIZE);

Steps to reproduce

Open the app.
Click on the more from the bottom Navigation
From the bottomSheet click on Feedback
Scroll (Make sure you are on Android 9, it works properly on Android 13,14)

Expected behaviour
Allow the user to scroll when the keyboard is shown.
Actual behaviour
Doesn't lets the user to scroll, hide keyboard. Thus has only one option which is dismiss the dialog.
Device name
No response
Android version
Android 9
Commons app version
4.2.1-debug
Device logs
API level: 28
Android version: 9
Device manufacturer: OPPO
Device model: CPH1859
Device: CPH1859
Network type: wifi
App version name: 4.2.1-debug
User name: null
Screen-shots
https://github.com/commons-app/apps-android-commons/assets/60827173/57480466-d4cf-4205-b64b-416ee5ef6fc7
Would you like to work on the issue?
Yes

I have fixed this issue locally. If this issue is considered valid I will release the PR .
Before
https://github.com/commons-app/apps-android-commons/assets/60827173/57480466-d4cf-4205-b64b-416ee5ef6fc7
After
https://github.com/commons-app/apps-android-commons/assets/60827173/ae0c6542-29d2-4059-9275-b018d6ebba8f

Good improvement thanks! Feel free to send a PR :-)

Added the PR for fix @nicolas-raoul


v1.2 - Tidying up before CSS Grid

adding client list with boxes and icons (for two clients) and styling
adding skills bars
adding work pages with link to master stylesheet
adding index.html fragment links (internal id hashtag links)
adding J personal icon
adjusting structure of index.html site to prep for CSS grid
minor improvements to get ready for CSS grid

Addresses issue: #14, #6

Addresses issues #14, #6


Oas31 schema

That fixes all the issues with references. I haven't tried running it against an actual OpenAPI document yet.
#ExternalDocumentation is referenced, but never defined. I copied the schema from the 3.0 meta-schema

Added a couple of fixes based on @MikeRalphson's openapi3.1-examples. There's one that still fails, but it's something that JSON Schema can't express.
Apparently there is no schema for webhooks yet. I put a placeholder in with a TODO comment.

Once https://github.com/OAI/OpenAPI-Specification/pull/2467 is merged, we can update /$defs/Objects/$defs/Schema to point to the dialect.

Thank you @jdesrosiers, I'll keep plugging away at this when I can and I'll keep an eye on https://github.com/OAI/OpenAPI-Specification/pull/2467


Fix: don't modify ARGV array when parsing options

You might want to reference the arguments somewhere else in the application

This is not a fix. Ruby works like that too. The idea is that OptionParser will remove the options used, and then you are left with the program arguments. You can call parse(ARGV.dup) if you want to.

Thanks for the pointer


SNOW-1867961: from_json does not work for TimestampType if it contains tz_info

Relevant functions:
https://github.com/snowflakedb/snowpark-python/blob/69c41a28110eb530c771179c52dc515535fa6e03/src/snowflake/snowpark/types.py#L927
https://github.com/snowflakedb/snowpark-python/blob/69c41a28110eb530c771179c52dc515535fa6e03/src/snowflake/snowpark/types.py#L209

Hello @AdamosX ,
Thanks for raising the issue. Could you clarify the requirement for the scenario and please share the code snippet as well?
Are you trying to convert JSON to custom python data types ?
Regards,
Sujan

Sure, I just read a table schema from a real table on snowflake and serialized it to json.
Then I wanted to deserialize it from json, and it failed.
The code below contains the simplified relevant parts:
from snowflake.snowpark.types import StructType, TimestampType, TimestampTimeZone, StructField
s = StructType(
        [
            StructField(
                "INSERT_TIMESTAMP",
                TimestampType(timezone=TimestampTimeZone.NTZ), #if I remove timezone, it works
                nullable=True,
            ),
        ]
    )
j = s.json_value()
sj = StructType.from_json(j) #does not work: ValueError: Cannot parse data type: timestamp_ntz

Thank you @AdamosX ,
We are able to reproduce the issue, and will work on eliminating it, and will update.
Regards,
Sujan


Increment version for communication releases

Increment package version after release of Azure.Communication.Rooms

API change check
API changes are not detected in this pull request.


[Bug]: VectorStoreIndex.from_document KeyError

Bug Description
Getting key error with: VectorStoreIndex.from_documents using a MLFloatGateway Langchain embedding model.
The trace shows:
    |_embedding ->  0.970113 seconds
    |_embedding ->  0.973638 seconds
    |_embedding ->  0.97082 seconds
    |_embedding ->  0.969955 seconds
    |_embedding ->  0.494139 seconds
    |_exception ->  0.0 seconds
      |_exception ->  0.0 seconds

Version
0.9.1
Steps to Reproduce
I loaded a folder of .pdf files and then used VectorStoreIndex
Would it be due to some issue to do with the embedding model? If so, How can I debug and check?  And it works if you just use other embeddings? It's specific to this embedding model?

This is the code that builds the id map
id_to_embed_map: Dict[str, List[float]] = {}

    texts_to_embed = []
    ids_to_embed = []
    for node in nodes:
        if node.embedding is None:
            ids_to_embed.append(node.node_id)
            texts_to_embed.append(node.get_content(metadata_mode=MetadataMode.EMBED))
        else:
            id_to_embed_map[node.node_id] = node.embedding

    new_embeddings = embed_model.get_text_embedding_batch(
        texts_to_embed, show_progress=show_progress
    )

    for new_id, text_embedding in zip(ids_to_embed, new_embeddings):
        id_to_embed_map[new_id] = text_embedding

    return id_to_embed_map

The only think I can think of is ids_to_embed is not the same length as new_embeddings

I have done some digging and whilst the OpenAI Embedding class has things like retry etc, the MLflow Gateway class doesn't could it be that my endpoint is returning a 404 from exceeding a rate limit or something.
Is there some error handling in llama_index I can use to check?

this is my ingestion code block:
from llama_index import SimpleDirectoryReader, download_loader

UnstructuredReader = download_loader("UnstructuredReader", refresh_cache=True, use_gpt_index_import=True)
unstruct_loader = UnstructuredReader()

dbfs_source_docs = '/dbfs/bootcamp_data/pdf_data'
print(f'loading documents from: {dbfs_source_docs}')
documents = SimpleDirectoryReader(
    input_dir=dbfs_source_docs,
    file_extractor = {'*.pdf': unstruct_loader}
).load_data()

If I loop the documents object manually and embed the text field I don't get any errors and the documents are all successfully embedded

My original documents was of len() 300.
I just tried running subsets
doc_subset = documents[0:100]
even slowly cutting down to 5 docs still can't get working still have key error

@Data-drone is mlflow gateway free to use? I'd love to reproduce this locally
Otherwise, I'd suggest setting some breakpoints or prints in the llamaindex code (maybe in that function I pasted above?)
Specifically, we are using embed_model.get_text_embedding_batch(texts) under the hood

It is this: https://mlflow.org/docs/latest/llms/gateway/index.html
I am connecting to a mosaicml service but it may break with openai too not sure haven't tested that combo

I ran this:

for document in documents:
  document.embedding  = embeddings.embed_query(document.text)

on my documents first then ran: VectorStoreIndex.from_documents and it all worked

I think it's an error on VectorStoreIndex. I had a running code, and now running it, throws an adjacent error:
index = VectorStoreIndex.from_documents(documents, storage_context=storage_context, service_context=service_context)

throws:
----> 1 index = VectorStoreIndex.from_documents(documents, storage_context=storage_context, service_context=service_context)

File ~/opt/anaconda3/envs/test/lib/python3.11/site-packages/llama_index/indices/base.py:97, in BaseIndex.from_documents(cls, documents, storage_context, service_context, show_progress, **kwargs)
     95 with service_context.callback_manager.as_trace("index_construction"):
     96     for doc in documents:
---> 97         docstore.set_document_hash(doc.get_doc_id(), doc.hash)
     99     nodes = run_transformations(
    100         documents,  # type: ignore
    101         service_context.transformations,
    102         show_progress=show_progress,
    103         **kwargs,
    104     )
    106     return cls(
    107         nodes=nodes,
    108         storage_context=storage_context,
   (...)
    111         **kwargs,
    112     )

AttributeError: 'str' object has no attribute 'set_document_hash'

I was able to reproduce your error @Data-drone -- debugging now 👍🏻

@Data-drone the error is actually a bug in langchain -- https://github.com/langchain-ai/langchain/blob/751226e067bc54a70910763c0eebb34544aaf47c/libs/langchain/langchain/embeddings/mlflow_gateway.py#L62
Pretty sure that line should be embeddings.extend(..) instead of append()
Editing that line fixes everything

Going to close the issue here -- but feel free to file a bug or PR on langchain


How to launch app

I want to luanch my app from terminated state when user accept call in ios

it is the limitation of the iOS system, it will open the CallKit for audio call or ask to unlock the device for opening your app for the video call. what type of calls do you mean?


extra comment after disable directive

It would be nice to be able to add extra comment after a disable directive such as:
# shellcheck disable=SC2034 variable FOO is used in other files that import this one

to remind oneself and others what is being ignored.

I'm afraid I'm not following what you're saying here.  Where do you want to add a comment, and what does that have to do with syntastic?

The example directive in the original comment is invalid.  Syntastic won't actually disable the SC2034 check for the line following that line, presumably because there is text trailing the directive.
I'm proposing that if there is text trailing a directive line, that it be ignored rather than invalidating the directive.  That text is there to explain to future readers why the directive has been put there, for example.

I'm afraid I still don't follow.  What directive?  Please explain in enough detail to be accessible to my tiny brain: what did you do, what did you expect to happen, and what happened instead?

Never mind.  I had the wrong project open.


Buggy If Conditional Behavior?

What version of Go are you using (go version)?

$ go version go1.13.4 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
  macOS
    GOARCH="amd64"
    GOHOSTARCH="amd64"
    GOHOSTOS="darwin"

What did you do?
shift elements of an array inside of a for loop, when I try to shift elements it causes the function to run 4 times instead of the normal two based off input. You can see this if you run the code in the Golang playground link and then run again with line 19 uncommented.
https://play.golang.org/p/DkaqFm8VLzy
What did you expect to see?
Elements in the array swapped based off the indexes used in the scope of if conditional.
What did you see instead?
Elements shifted to the wrong spots because the function ran more than it should when I added that section of code in the scope.

I didn't see anything wrong. You have swap the elements of the array, so the "if" path run 4 times.

If you comment out the swap statement then you see amt variable is only incremented twice. I’m wanting to only make a swap for each time amt is incremented so I’m not sure why when I add the swap statement to the same block it runs 4 times instead of 2
Cameron Hunter

On Nov 26, 2019, at 7:49 PM, erifan<EMAIL_ADDRESS>wrote:

I didn't see anything wrong. You have swap the elements of the array, so the "if" path run 4 times.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

https://play.golang.org/p/_zm8i7MS14A please check why it runs 4 times instead of 2, this is not a Go issue, I'll close it.


Remove UI test project and all dependencies

Since the UI components' test project is not maintained, I recommend to create a branch at this point and remove all tests and their dependencies from the dev branch. @TheHadiAhmadi do you have any comment?

It is okay, I will work on it

It is okay, I will work on it

No need, i will do


Quick fix for Timber 1.1.2

Fixed the deprecated {{ post.permalink }}, changed it to {{ post.link }}.

Thanks for submitting the PR. We are looking at fully upgrading to Timber v1 at the moment. From what I recall, they've changed their namespaces too (e.g. TimberSite is now Timber\Site), so we will need to extra work to upgrade properly. Therefore, I won't merge this in, but instead do the upgrade ourselves & make sure we've covered all cases and documentation too :)
Thanks for letting us know that Timber 1 is important to you and we'll look at getting this upgraded asap


Minor UI Improvements

Description

This pr modifies the action item and takeaway cards to match the slightly better layout of the topic card. It also makes sure that the edit meeting page automatically focuses the user on the meeting name.
Type of change

[x] Housekeeping and refactoring

How Has This Been Tested?

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@zbarnz Yeah these are the ones that I intended. It isn't a great pr name but the commit names are usually what you look at anyway.

@thudsonbu I dont see a commit relating to the layout change I only see 3 lines of code change with the autofocus fix and the history button fix?

@zbarnz You're right, this isn't the right branch.


Site not rendering in one Web App slot but no exceptions raised

Describe the bug
Same code deployed into two different slots on Azure, one renders the page as expected the other returns a 200 with no content
Expected behavior
Both slots to render the page
Screenshots
Sorry if this is the wrong place, I originally raised a ticket with Azure support but there's no exception being raised on the platform and it seems to be ASP.NET Core related as my .NET Framework apps in the same web site are running fine; the code also works fine locally.
Here's  an extract from the working service's diagnostic logs, you can see...

Correctly routes
Executes the appropriate controller method
Find the view
Invokes the viewcomponents on the page

2018-10-24 09:45:01.852 +00:00 [Information] Microsoft.AspNetCore.Hosting.Internal.WebHost: Request starting HTTP/1.1 GET http://dev.xxx.com/
2018-10-24 09:45:01.852 +00:00 [Trace] Microsoft.AspNetCore.HostFiltering.HostFilteringMiddleware: All hosts are allowed.
2018-10-24 09:45:01.852 +00:00 [Debug] Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware: The request path / does not match a supported file type
2018-10-24 09:45:01.852 +00:00 [Trace] Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingBasedDataProtector: Performing protect operation to key {4fb996e1-xxx-xxx-xxx-f09880aa903a} with purposes ('D:\home\site\wwwroot', 'SessionMiddleware').
2018-10-24 09:45:01.853 +00:00 [Debug] Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationHandler: AuthenticationScheme: Cookies was not authenticated.
2018-10-24 09:45:01.853 +00:00 [Debug] Microsoft.AspNetCore.Routing.RouteBase: Request successfully matched the route with name 'default' and template '{controller=Home}/{action=Index}/{id?}'.
2018-10-24 09:45:01.853 +00:00 [Information] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Route matched with {action = "Index", controller = "Home"}. Executing action Lighthouse.Web.Controllers.HomeController.Index (Lighthouse.Web)
2018-10-24 09:45:01.853 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Execution plan of authorization filters (in the following order): None
2018-10-24 09:45:01.853 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Execution plan of resource filters (in the following order): Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter
2018-10-24 09:45:01.853 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Execution plan of action filters (in the following order): Microsoft.AspNetCore.Mvc.Internal.ControllerActionFilter (Order: -2147483648), Microsoft.AspNetCore.Mvc.ModelBinding.UnsupportedContentTypeFilter
2018-10-24 09:45:01.853 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Execution plan of exception filters (in the following order): None
2018-10-24 09:45:01.853 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Execution plan of result filters (in the following order): Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter
2018-10-24 09:45:01.853 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Resource Filter: Before executing OnResourceExecuting on filter Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter.
2018-10-24 09:45:01.853 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Resource Filter: After executing OnResourceExecuting on filter Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter.
2018-10-24 09:45:01.853 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Action Filter: Before executing OnActionExecutionAsync on filter Microsoft.AspNetCore.Mvc.Internal.ControllerActionFilter.
2018-10-24 09:45:01.853 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Action Filter: Before executing OnActionExecuting on filter Microsoft.AspNetCore.Mvc.ModelBinding.UnsupportedContentTypeFilter.
2018-10-24 09:45:01.853 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Action Filter: After executing OnActionExecuting on filter Microsoft.AspNetCore.Mvc.ModelBinding.UnsupportedContentTypeFilter.
2018-10-24 09:45:01.853 +00:00 [Information] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Executing action method Lighthouse.Web.Controllers.HomeController.Index (Lighthouse.Web) - Validation state: Valid
2018-10-24 09:45:01.854 +00:00 [Information] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Executed action method Lighthouse.Web.Controllers.HomeController.Index (Lighthouse.Web), returned result Microsoft.AspNetCore.Mvc.ViewResult in 0.0211ms.
2018-10-24 09:45:01.854 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Action Filter: Before executing OnActionExecuted on filter Microsoft.AspNetCore.Mvc.ModelBinding.UnsupportedContentTypeFilter.
2018-10-24 09:45:01.854 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Action Filter: After executing OnActionExecuted on filter Microsoft.AspNetCore.Mvc.ModelBinding.UnsupportedContentTypeFilter.
2018-10-24 09:45:01.854 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Action Filter: After executing OnActionExecutionAsync on filter Microsoft.AspNetCore.Mvc.Internal.ControllerActionFilter.
2018-10-24 09:45:01.854 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Result Filter: Before executing OnResultExecuting on filter Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter.
2018-10-24 09:45:01.854 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Result Filter: After executing OnResultExecuting on filter Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter.
2018-10-24 09:45:01.854 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Before executing action result Microsoft.AspNetCore.Mvc.ViewResult.
2018-10-24 09:45:01.854 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine: View lookup cache hit for view 'Index' in controller 'Home'.
2018-10-24 09:45:01.854 +00:00 [Information] Microsoft.AspNetCore.Mvc.ViewFeatures.ViewResultExecutor: Executing ViewResult, running view Index.
2018-10-24 09:45:01.854 +00:00 [Debug] Microsoft.AspNetCore.Mvc.ViewFeatures.ViewResultExecutor: The view path '/Views/Home/Index.cshtml' was found in 0.0433ms.
2018-10-24 09:45:01.854 +00:00 [Debug] Microsoft.AspNetCore.Mvc.ViewComponents.DefaultViewComponentInvoker: Executing view component Lighthouse.Web.ViewComponents.AdvancedSearchViewComponent with arguments ().
2018-10-24 09:45:01.854 +00:00 [Debug] Microsoft.AspNetCore.Mvc.ViewComponents.DefaultViewComponentInvoker: Executed view component Lighthouse.Web.ViewComponents.AdvancedSearchViewComponent in 0.006ms and returned Microsoft.AspNetCore.Mvc.ViewComponents.ViewViewComponentResult
2018-10-24 09:45:01.854 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine: View lookup cache hit for view 'Components/AdvancedSearch/Default' in controller 'Home'.
2018-10-24 09:45:01.854 +00:00 [Debug] Microsoft.AspNetCore.Mvc.ViewComponents.DefaultViewComponentInvoker: Executing view component Lighthouse.Web.ViewComponents.SidebarViewComponent with arguments (Home, , False).
....

The non-working slot does the following

Correctly routes
Executes the appropriate controller method
Returns almost immediately

2018-10-24 09:42:46.847 +00:00 [Information] Microsoft.AspNetCore.Hosting.Internal.WebHost: Request starting HTTP/1.1 GET http://beta.xxx.com/
2018-10-24 09:42:46.847 +00:00 [Trace] Microsoft.AspNetCore.HostFiltering.HostFilteringMiddleware: All hosts are allowed.
2018-10-24 09:42:46.848 +00:00 [Debug] Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware: The request path / does not match a supported file type
2018-10-24 09:42:46.848 +00:00 [Trace] Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingBasedDataProtector: Performing protect operation to key {cdd64fe0-xxxx-xxxx-xxxx-ebbc149107d4} with purposes ('D:\home\site\wwwroot', 'SessionMiddleware').
2018-10-24 09:42:46.852 +00:00 [Debug] Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationHandler: AuthenticationScheme: Cookies was not authenticated.
2018-10-24 09:42:46.895 +00:00 [Debug] Microsoft.AspNetCore.Routing.RouteBase: Request successfully matched the route with name 'default' and template '{controller=Home}/{action=Index}/{id?}'.
2018-10-24 09:42:46.896 +00:00 [Information] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Route matched with {action = "Index", controller = "Home"}. Executing action Lighthouse.Web.Controllers.HomeController.Index (Lighthouse.Web)
2018-10-24 09:42:46.896 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Execution plan of authorization filters (in the following order): None
2018-10-24 09:42:46.896 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Execution plan of resource filters (in the following order): Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter
2018-10-24 09:42:46.896 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Execution plan of action filters (in the following order): Microsoft.AspNetCore.Mvc.Internal.ControllerActionFilter (Order: -2147483648), Microsoft.AspNetCore.Mvc.ModelBinding.UnsupportedContentTypeFilter
2018-10-24 09:42:46.896 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Execution plan of exception filters (in the following order): None
2018-10-24 09:42:46.896 +00:00 [Debug] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Execution plan of result filters (in the following order): Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter
2018-10-24 09:42:46.896 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Resource Filter: Before executing OnResourceExecuting on filter Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter.
2018-10-24 09:42:46.896 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Resource Filter: After executing OnResourceExecuting on filter Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter.
2018-10-24 09:42:46.897 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Resource Filter: Before executing OnResourceExecuted on filter Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter.
2018-10-24 09:42:46.897 +00:00 [Trace] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Resource Filter: After executing OnResourceExecuted on filter Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter.
2018-10-24 09:42:46.897 +00:00 [Information] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Executed action Lighthouse.Web.Controllers.HomeController.Index (Lighthouse.Web) in 1.304ms
2018-10-24 09:42:46.905 +00:00 [Debug] Microsoft.AspNetCore.Server.Kestrel: Connection id "0HLHPHV0DC1D9" completed keep alive response.
2018-10-24 09:42:46.905 +00:00 [Information] Microsoft.AspNetCore.Hosting.Internal.WebHost: Request finished in 57.729ms 200

The main difference I can see is that the working slot has
2018-10-24 09:45:01.853 +00:00 [Information] Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker: Executing action method Lighthouse.Web.Controllers.HomeController.Index (Lighthouse.Web) - Validation state: Valid
There's no security in place as this is just Home/Index
Bit stumped about how to determine what's causing the problem or what further information I can gather.

Can you share the controller code?

Your trave log is consistent with an exception being thrown when executing the action. Given the code you have it's most likely that executing your view is throwing. Could you also include your Startup code, perhaps something is swallowing the thrown exception?

Thanks, that gave me enough of a nudge to work it out...
I'd missed changing one of the app settings for the beta slot to the appropriate value which mean that when the container tried to construct the concrete IAssetClient there was an internal url mismatch so it threw an exception in the class constructor, which meant one of the dependencies for the Home controller failed.
Don't know what is swallowing it as I'd expect that to be seen/tracked by the runtime and/or Application Insights but it's working now and I have some more tests to write.


2.5.1 documentation contains the out-of-date documentation of kubernetes deployment

Motivation
The out-of-date k8s documentation was already removed from 2.5.0 and master. Somehow the old documentation was brought back to the website. We should remove it.
https://pulsar.apache.org/docs/en/2.5.0/kubernetes-helm/
https://pulsar.apache.org/docs/en/2.5.0/functions-overview/
https://pulsar.apache.org/docs/en/next/kubernetes-helm/
https://pulsar.apache.org/docs/en/next/helm-overview/

OK. This task has been added to the backlog.

@Huanli-Meng Since you worked on this issue and discussed w/ sijie before, could u pls double-check the issue status? thanks

@sijie , it seems that the issue is fixed as we checked before. if not, could you please identify which are old contents? Thx.

@Huanli-Meng double confirmed with @sijie that this issue is fixed, so I close it.


Create a Recipes docs

Hi,
I would love to submit a recipes md with a few solutions that I've found after refactoring a whole application with this library, there were a few escenarios that were had for me to understand at first, like updating one state property after another one updated. This also helped me to understand pure components and all the stuff that I was doing really bad.
I think a lot of people could update this doc with their own recipes as well.
I wonder if this is something that would be accepted as a PR?

Here we have wiki you are free to add recepies there, no need in PR I think

https://github.com/acdlite/recompose/wiki

nice thanks!


Add Line to Social

https://developers.line.biz/en/docs/line-login/

Don't open an issue if you've already open a PR, please wait for the review. If you find any bugs or genuine issues then only open an issue otherwise don't
Thanks


Link miscellaneous events with responses

A lot of miscellaneous events have responses so link them up yo. You should be able to use Laboratory.request() with misc stuff too.

Request linking is no longer needed as of https://github.com/marrus-sh/laboratory/commit/4859a4b3aa9180222caf8df19fde78825e8f9261 so we'll call this fixed


Deploy an Upgradeable contract without openzeppelin/hardhat-upgrades?

Is there a way to deploy and update an Upgradeable Smart contract without @openzeppelin/hardhat-upgrades?
I'm having issues compiling successfully with it and i hope the next time i need to update my smart contract, the bug would have been fixed or the feature would have been implemented
https://github.com/OpenZeppelin/openzeppelin-upgrades/issues/405 is not allowing me compile for some unknown reasons and i can't even debug the task properly

Hello @noobshow,
It is possible to deploy upgradeable contracts without the package. Upgradeability happens at the blockchain level, and the package is just tooling to simplify the deployment.
However, deploying by hand will not produce the manifest that you will later need to verify the consistency (security) of upgrades.


New version: Sudoku v0.1.1

Registering package: Sudoku
Repository: https://github.com/scheinerman/Sudoku.jl
Created by: @scheinerman
Version: v0.1.1
Commit: 9038548e1def08c628b1f5df518846f615a10e10
Git reference: HEAD

[noblock] I think I fixed the error. How do I retrigger??

Register the new revision as you did before, without changing the version number
[noblock]

Register the new revision as you did before, without changing the version number
[noblock]

[noblock]
I registered version 0.1.1 at https://juliahub.com/ui/Registrator by entering the URL for my github repository. That failed

Please update the version number in the package's Project.toml before registering a new version. The current version number is already tagged to a different commit

So I increased the version number to 0.1.2 and then got this complaint:

Your new version pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

Does not meet sequential version number guideline: version 0.1.2 skips over 0.1.1

Please help! I will roll back the version number in Project.toml to 0.1.1 since that's the number I really want.

You have to delete the tag https://github.com/scheinerman/Sudoku.jl/releases/tag/v0.1.1. In general, do not create git tags before actual registration: if there are problems like this you end up with a mismatch between the version in the registry and the git tag. You should instead use TagBot to automatically create git tags after successful registration: https://github.com/JuliaRegistries/TagBot
[noblock]

You have to delete the tag https://github.com/scheinerman/Sudoku.jl/releases/tag/v0.1.1. In general, do not create git tags before actual registration: if there are problems like this you end up with a mismatch between the version in the registry and the git tag. You should instead use TagBot to automatically create git tags after successful registration: https://github.com/JuliaRegistries/TagBot
[noblock]

[noblock]
Thanks. Trying this!


sidebar doesn't fix.

Description
sidebar doesn't fix,while I adding the "position:fixed" attribute to class "page__sidebar",then it works.
情况图片-1

Environment (If Necessary)

OS: Ubuntu18.04 LTS
Ruby: ruby 2.5.1p57
jekyll 3.8.5
Broser: Firefox

Is your HEAD behind this commit?

Is your HEAD behind this commit?

yes！

@ehds Could you tell me your Firefox Version ?

chrome works well,but firefox does not!

firefox version is 63.0(64位)


Edit Tag on backspace press

When pressing backspace in an empty input field, we can show the last tag and set that text as the value of the input. This way the user has more flexibility to edit their tags. It'll make it easier for the end-user to edit tags with ease and not rewrite the entire thing for just editing a misspelling.
This behaviour can be controlled with a prop if needed.
If this feature interests you, I can create a PR for the same.
Thanks!

@rohitpotato soon the tags will editable once https://github.com/react-tags/react-tags/pull/763 is merged. Then the user will be able to edit tags just by clicking on the tags, we might not need the edit tag with backpress then, wdyt ?

@ad1992 How about both? Considering mobile devices where the user can just remain in the input box rather than finding the tag to click and edit?

let's wait once we release the edit feature in the next release and then take the call if we want to implement it with the backspace press as well. Since this will only allow editing the last tag so I am not very sure if this will be needed so lets wait for more feedback :)

I was thinking more in terms of editing a tag that the user just created. A simple backspace press and they can edit and create the tag again.
Let's wait for the feedback, let me know whenever this becomes relevant and I'll be happy to implement it.
Thanks for your time!

Sure thing 👍🏻


New release?

@kassens, is there a plan to release a new version of this library? There has been around 50 commits since the last release on January 2019. Specifically, I want to submit a PR to fix some of the types, am I'm not sure if I should submit it to @types/graphql-relay, or the yet-unreleased ones in this repo.

@andrehsu Thanks for raising this issue 👍
Just got right to the NPM package so now I'm able to release a new version.
Will work on the release tomorrow (update deps + fix npm install + merge PRs) and release.
P.S. Long term plan is to merge this package into https://github.com/graphql/graphql-js and we will probably do it this summer as part of GSoC: https://github.com/graphql/foundation/tree/main/mentorship/2021/gsoc#2-integrate-graphql-relay-js-into-graphql-jsmedium

I don't forget about this issue, just catch COVID so very hard concentrate because of fewer.
It's at the top of my list once I start feeling better.

HI @IvanGoncharov, any news about this merge?

Just released a new version https://github.com/graphql/graphql-relay-js/releases/tag/v0.7.0


Statoscope App Redesign

This is a root issue about brand new design of Statoscope application.

Major flows:

Opening statoscope.tech, loading one or more stats files, navigating
Auto opening ui-report after build (locally stored)
Viewing saved interactive reports with title, description and more
Viewing linting results in graphical and interactive way

The layout is ready (we are not publishing it yet, we are discussing it with Sergey). It is UI Kit and major-flow-screens. After initial publishing the previous one will become deprecated, but you still can access it.
The main provisions for the layout

Use only the default system sans-serif font. In macOS, for example, it will be San Francisco. Perhaps the default font is not the best idea. If so, we will choose any of the free ones.
Desktop only. The minimum screen width is 1000px.
Making the Select component native (by default). There are no inputs and many others components in ui kit yet, it will be added as soon as possible.
There is no dark mode. But while developing it is necessary to declare color schemes for a soft landing.

New features (only in the new app)

Bundle evaluation system (score)
The ability to free up memory from already loaded stats
Quick search for all entities from stats as in Sublime Text (by modules, assets, chunks, etc).

The Future of Statoscope application design

Dark Mode
Advanced loading screen (with stages: loading, processing, normalization)
Preferences not only for the interface, but also for the application
Statoscope checks-report (validation) directly in the application
Update the Module screen
Jupyter-like report, saving the report to PDF, HTML or JPEG format
Saving discovery-reports to users' Gist, and showing them for a specific kind of stats


Invite sdjpark to CDCgov GitHub Organization

What type of help do you need?

[ ] Question
[ ] New Repo
[ ] Delete Repo
[x] User Membership (please make sure new members are familiar with the CDC open practices and set up their profile with name and org info to help people collaborate with them)
[ ] Other

Please describe how you'd like us to help.
Please invite @sdjpark to the CDCgov GitHub organization.  Their CDC e-mail is<EMAIL_ADDRESS>

Completed. I sent the request over to their CDC email, can they verify and pick it up from there - Peter?

Completed. I sent the request over to their CDC email, can they verify and pick it up from there - Peter?

They accepted the invite as the new GitHub user hcp4.  Thanks!


Client always calls dev COMBINE API

i don't remember setting the configuration of the combine service to be dependent on the environment, so it must be always calling the dev deployment, even in production

The deployed dispatch app always calls org.
https://combine.api.biosimulations.dev is hardcoded into libs/combine/api-client/src/lib/api/simulationProjectsCOMBINEOMEXArchives.service.ts. I guess this happens because this is the first URL in the OpenAPI spec.
The configurationFactory needs to be linked to Endpoints or the generate-combine-client script can modify how configuration is passed in.

The associated commit may not work since config service is provided async.

I am working on this in #3495

I am working on this in #3495

I saw that. In practice, it seemed to work fine. The client library has to be changed to accommodate that.


Update to a newer node versions

Some packages use newer features that are not available in your NodeJS version, I where just wondering if you could update it to a newer version.

+1 for this thing
BTW We are using this package with Node 16.13.2 (16.13.2-alpine3.15) since January 2022 and no problems so far.

++

For me, It is not work after Node 16.14.2.
After 16.14.2(such as 16.14.3), AWS lambda always return below error.
Error: Runtime exited with error: exit status 254 Runtime.ExitError

Any news on this from the AWS team? NodeJS 18 will become the active LTS in October 2022, so the RIC support is getting very out-of-date.

Please can you give us an ETA? It is really, really old at this point.

Any news?! This library still only supports Node 14 - which is in Maintenance phase since 1 year and 2 even-numbered versions behind current LTS.
The fact that noone from AWS responded to this ticket yet is shockingly unprofessional and shows major disregard for their customer base.

Is there any news on this? Amazon officially supports NodeJS 18 however the RIC has yet to be updated. We rely on this module to run our own base images on Lambda.
@makeable Did you manage to get the workaround executing? We get errors related to missing libraries etc when trying to run with NodeJS 18 using following command.
docker run --entrypoint /bin/bash public.ecr.aws/lambda/nodejs:18 -c 'yum install -y tar gzip &>/dev/null && tar czf - /var/runtime' | tar xzf -

@DavidArayan

We get errors related to missing libraries etc when trying to run with NodeJS 18 using following command.

What base image are you using? If you are using an Alpine Linux based one it could be because it's using musl libc and the aws image is using glibc. So try 18-slim instead of 18-alpine for example. IRC the slim image uses Debian and thus glibc.
We'll need to figure out a solution / workaround for this too as Node.js 14 goes of end life very soon.

@esamattis

What base image are you using? If you are using an Alpine Linux based one it could be because it's using musl libc and the aws image is using glibc.

We tried a variety of base images including 18-slim. Perhaps we're doing something wrong with the setup. Is there a list of libraries besides glibc that the RIC relies on that we are missing?

Uh. So yeah. We ported our custom image to use the provided base image. It seems to be very actively updated.
It has yum which can be used to add custom packages very easily. The only downside is that the image size more doubled from our previous Alpine based one. Will probably look into SlimToolkit for reducing it's size at some point.

Hi,
We investigated the issue and have updated instructions on how to use the RIC with Node16+.
Summary of the issue:
Starting from<EMAIL_ADDRESS>npm writes logs under the /home/.npm dir: https://github.com/npm/cli/pull/4594
This is not possible inside the Lambda execution env since the fs is read-only. In earlier versions of npm, there was a bug which caused it to silently fail when unable to write cache directory: https://github.com/npm/cli/issues/4996, hence why the runtime was just returning the 254 error code. There are some ways to prevent this:

(preferred) Setting the npm cache folder path to /tmp using a Docker ENV var:

ENV NPM_CONFIG_CACHE=/tmp/.npm

Use yarn instead of npm since it fallbacks to /tmp if the preferred cache folder isn't writable
Setting ENV NPM_CONFIG_CACHE=/tmp/.npm inside Lambda as an env var
Run aws-lambda-ric directly using node instead of using npx


nvm

Please add support for nvm, a popular Node.js version manager:
https://github.com/creationix/nvm
While not as advanced as nenv, nvm is still really popular.

I hope to accept nvm on this repo.


ShareUrl not passing url value on iOS

i pass in a url value & text string that works on android, but on iOS, only the text value gets passed in. I have a log right before the shareUrl gets called, and can see it populated.
I just updated to the latest 1.5.0

the issue was caused due to not using https. I added https in front of the url i'm sharing and works properly on ios now.


The links created in HTML report should be clickable

The links for http sites are currently not using anchor tags. So one has to manually copy and paste. It would be nice if we can just click and visit the page.

Oke noted , Will be added soon


Attempt to use opentelemetry_api headers cause envoy build fails

Title: Attempt to use opentelemetry_api headers cause envoy build fails
Description:
I need a help regarding using opentelemetry_api that was added in this commit.
/source/extensions/tracers/opentelemetry has opentelemetry_api  as external_deps, in opentelemetry_tracer_impl.h file I have included a otel header file as:
#include "opentelemetry/logs/provider.h"

I used to build envoy with docker-clang option, but this time it fails:
$ bazel build envoy --config=docker-clang
INFO: Analyzed target //:envoy (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
INFO: Docker sandboxing is supported
ERROR: /home/matin/envoy-build/envoy/source/extensions/tracers/opentelemetry/BUILD:14:19: Compiling source/extensions/tracers/opentelemetry/config.cc failed: (Exit 1): clang-14 failed: error executing command (from target //source/extensions/tracers/opentelemetry:config) /opt/llvm/bin/clang-14 -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wunused-but-set-parameter -Wno-free-nonheap-object -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++0x' ... (remaining 246 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from source/extensions/tracers/opentelemetry/config.cc:8:
In file included from ./source/extensions/tracers/opentelemetry/opentelemetry_tracer_impl.h:16:
In file included from bazel-out/k8-fastbuild/bin/external/io_opentelemetry_cpp/api/_virtual_includes/api/opentelemetry/trace/provider.h:11:
In file included from bazel-out/k8-fastbuild/bin/external/io_opentelemetry_cpp/api/_virtual_includes/api/opentelemetry/trace/noop.h:16:
In file included from bazel-out/k8-fastbuild/bin/external/io_opentelemetry_cpp/api/_virtual_includes/api/opentelemetry/trace/span.h:13:
bazel-out/k8-fastbuild/bin/external/io_opentelemetry_cpp/api/_virtual_includes/api/opentelemetry/trace/span_context.h:33:40: error: use of old-style cast [-Werror,-Wold-style-cast]
        trace_flags_(trace::TraceFlags((uint8_t)sampled_flag)),
                                       ^        ~~~~~~~~~~~~
1 error generated.
Target //source/exe:envoy-static failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 15.400s, Critical Path: 14.38s
INFO: 4 processes: 4 internal.
FAILED: Build did NOT complete successfully

I've tried to turn off this -old-style-cast by passing the build option in bazel like this:
bazel build --cxxopt="-Wno-old-style-cast" envoy

But got the same error. I also try pass this option from Bazel BUILD file like this:
    copts = [
        "-Wno-old-style-cast"
    ],

That didn't work either.
I asked this question in bazel community slack. The said, it needs to be fixed from Envoy. Here is the thread: https://bazelbuild.slack.com/archives/CGA9QFQ8H/p1709093105289759

Upstream issue https://github.com/open-telemetry/opentelemetry-cpp/issues/2556

submitted https://github.com/envoyproxy/envoy/pull/32624 to patch fix for now


There is no need to include webpack-dev-server.js in index.html

Automatic page refresh works without <script src="/webpack-dev-server.js"></script> in index.html. So, it could be removed from index.html.
Steps to reproduce the problem:

remove  <script src="/webpack-dev-server.js"></script> from index.html.
npm start
open localhost:3000 in browser
change something in any file in src directory
page will be automatically reloaded

same here

@Redigast13 yep, it is not always needed, but in case you want to use the Webpack API.


Possible fix for leaking file handles

Closes #1025

This seems like better code. I don't think it made a difference to the problem we were seeing, but is it better than what was there? Should we merge it anyway?


If args are submitted to get search on those terms.

Closes #200
Simple string matching search based on spec names.


MRDS parameters

Do we need more options to control the MRDS parameters?

isotropic volume fraction prior needed? How is it set? What is the assumption?
diffusivity ranges for the tensors?

Maybe checkout the freewater_flow and noddi_flow options?
https://github.com/scilus/freewater_flow/blob/main/main.nf
https://github.com/scilus/noddi_flow/blob/main/main.nf

@arnaudbore :)


Determine how to deal with encryption during server migrations

Without recovering the encryption keys or decrypting all data, migrating to a new Nextcloud installation will cause all files to be unrecoverable.
We can either:

grab the encryption keys from these locations and copy them onto the new installation as part of a migration playbook

data/<user>/files_encryption

Users’ private keys and all other keys necessary to decrypt the users’ files

data/files_encryption

private keys and all other keys necessary to decrypt the files stored on a system wide external storage

If the keys are not there, run occ encryption:show-key-storage-root to get the current location of the keys

or

run the occ encryption:decrypt-all [username] to decrypt all data before migrating it to the new system

this would take forever. Probably do not want this.

I think it would make sense to leave encryption off by default, as most people who would use nextcloud utilize it internally, and would also prefer better performance to better security. It should be available as a configuration option, but not by default.
As for moving the user files to a new instance, it is stated that moving the data directory is not supported and can cause issues Nextcloud forum on Data Dir.
One option for users, is to create a local backup by syncing nextcloud to their local machine. Once the new nextcloud instance is available, simply sync the backup to the new nextcloud sync directory. I have not found a way to move the files personally without some kind of rather roundabout way, since Nextcloud will only recognize files that are indexed during syncing, and not when they are added into the data directory on the server side.


Support for installing remotely hosted dependency files (requirements.txt, lock files, constraints, overrides, etc)

Missing feature from uv pip that is available in pip is that it cannot install a dependency file from a remote source.
Example
Deploy an application released in GitHub releases using a lock file and a wheel file.
$ export URL=https://github.com/myusername/myapp/releases/download/v1.2.3/
$ uv pip install -r $URL/requirements.txt $URL/myapp.whl

Duplicate of https://github.com/astral-sh/uv/issues/1332. See https://github.com/astral-sh/uv/pull/2081 for ongoing discussion.

Closing into other issues.


should FakeWebpackLoader also mock get_assets?

I found myself needing to create an extended FakeWebpackLoader when using webpack_static:
class MockWebpackLoader(FakeWebpackLoader):
    def get_assets(self):
        return {}

(otherwise you hit an IOError when it attempts to read).  Would that be a good PR?  or should I be doing this differently anyway?

Please feel free to open the PR, thanks!


Fixing the Era Name test cases on Linux.

ICU returns "AD" instead of "A.D." for the era name and "A" instead of "AD" for the abbreviated era name.
System.Globalization.Tests now passes successfully on my machine with this change.
@ellismg, @tarekgh, @steveharter

LGTM. thanks Eric for getting these fixed :-)


Hard-Coded to First Container in Pod - Fails to Inject Agent with Istio

Description
The container injector is hard-coded to inject the New Relic agent into the first container in the pod. In my case, this causes the agent to be injected into the Istio sidecar container instead of the application container, leading to non-functionality.

https://github.com/newrelic/k8s-agents-operator/blob/main/src/apm/java.go#L64

Steps to Reproduce

Set up a Kubernetes pod with Istio sidecar injection enabled.
Deploy an application where the application container is not the first container in the pod.
Configure New Relic K8s Agent Operator to inject the agent.
Observe that the agent is injected into the first container (Istio sidecar), not the application container.

Expected Behavior
The New Relic agent should be injected into a specified application container, not the Istio sidecar.
Actual Behavior
The New Relic agent is injected into the first container in the pod, which in this case is the Istio sidecar container.
Suggested Solution:
Allow the container injector to target a specific container within the pod, provide a mechanism to configure which container the agent should be injected into.
Your Environment
K8s with Istio

This issue is happening with Dapr as well, as Dapr runs as the sidecar container alongside the application container.


Possible to use in Browser with WebRTC?

I want to use this in a peer-to-peer browser environment using WebRTC as the network transport. Is that possible?

It is possible, but has a different scope than skiff, which is designed to work on Node.js.
Also, I'm not sure if majority consensus and constant pings is something you'd want in a browser environment, Raft can be rather chatty..


Update handle_config_terminate API

Update handle_config_terminate API to match changes in https://github.com/apache/couchdb-config/pull/11
COUCHDB-3102

Just had the one trivial comment. If you prefer the existing approach feel free to ignore my suggestion.
+1


Added new bis commands (1.54 and dev)

Hi,
I updated the syntax highlighting and auto-completion

Thanks!


Adds a plugin publishing best practices guide.

This guide is based on the following blog post: https://grafana.com/blog/2024/06/06/6-tips-to-improve-your-grafana-plugin-before-you-publish/

we can do this separately but I think we should update this page https://grafana.com/developers/plugin-tools/publish-a-plugin/publish-a-plugin either directly here or shortly after.
Maybe remove the whole "Before you begin" sections and update the intro text.
Otherwise it feels redundant and confusing once we add the "best practices" page.

I've added an extra bullet in the "Before you begin" section that links to this document for now. I think it's worth discussing as part of a separate PR whether this document becomes a sort of pre-requisite guide (and therefore supersedes the "Before you begin" section of the publish page). I hadn't intended for this doc to be a replacement for that initially, and I'm still not sure it makes sense to do that.


Ensure that observer has observe function available

Hola ☀
First of all, thanks a lot for making lazyload. It's amazing 👍
I've seen many errors like this in the error tracker:

I've implemented this fix locally and it seems like the issue is gone:

Looking forward to your feedback, would be great to fix it on library level, so we can upgrade to the version with fix 🚀

Hey @makaroni4, I've checked the code and opened this branch to support this PR.
I didn't find any case in any browser in which there can be this._observer but not this._observer.observe. If I could see your JS code maybe I can give you more information.
Thanks

Hi @makaroni4,
thanks for sending the explanation over.
I've seen the code on your website, and my first concern is: why do you select elements with [data-src], [data-srcset]? If it's to load lazily the source tags inside the picture tag, there's no use to do it. You can select the img inside the picture and LazyLoad does the "if parent is picture" detection automatically, and sets the srcset in the source tags out of the box.

As of my tests, selecting with [data-src], [data-srcset] doesn't cause any errors, it just makes the scroll down much slower. Anyway I'd suggest to use a lazy class in the images, iframes or videos you wish to load lazily, then selecting them with {elements_selector: ".lazy"}

Hi @makaroni4,
in version 10.11.0 I changed right that portion of code you suggested to change.
Can you try with this latest version and tell me how it goes?
Thanks

Let's say 10.11.1. 10.11.0 had a nasty bug.

@makaroni4 please let me know how it goes with the newest versions, then feel free to reopen in case.


Subset evaluation

based on Yada's new data_loader, add cola in/out/full domain and Alex's cola dev set annotation to task. add ling3340 baseline experiments config files to config.

This is weird.
I can see, with my own naked eyes, my files don't conflict with master.
I don't know why this file changes tool isn't comparing to the latest, real mater branch.

good, no conflicts now.

Ready!


CircleTransformation (and maybe others) not always applied

I am getting an error where sometimes the circletransformation doesn't get applied.
It works 99% of the time but 1% of the time the same image is square. Is there any reason why this would happen with such low probability? Is the transformation done on a separate thread or something?
UserProfileImage = new CachedImage {
HeightRequest = 120,
WidthRequest = 120,
Aspect = Aspect.AspectFill,
HorizontalOptions = LayoutOptions.Center,
Source = "https://patook.com/Content/ProfileWoman.jpg",
Transformations = new System.Collections.Generic.List<FFImageLoading.Work.ITransformation>() {
				new FFImageLoading.Transformations.CircleTransformation(),
			},
		};

When this happens it means that the transformation could not be applied.
Instead of crashing we revert to the previous image (pre transformation).
Why a transformation could not be applied? You are low on memory, some Android/Xamarin issue, a bug in your app, a bug in our lib, ...
It is impossible to say.

We are 3 Developers 2 with Xamarin for OSX and 1 with VisualStudio.
Never work, (emulator or real device).
You should fix the issue or we uninstall it, because we can´t round images with other libraries.

@jposes22 It definitely works. Clone a project and run the demo project, you'll see that it works correctly. The important thing is to set Transformations before Source property, not the opposite.


Init Cassandra service

This is not yet fully working.
When using the default Cassandra package you will get warnings about python being an insecure package. There is also an issue where I seem unable to connect to the database using cqlsh.
When using the cassandra_4 package, I am able to connect using the cqlsh tool.
I'm sure the code itself can be cleaned up as well.

Looks good to me :)

CI failure was fixed in main branch

Just rebased from the main branch.
One thing to note is that I am still unable to seem to connect using the default cassandra package. But I think I have found out why. Avoid merging this for now and I will see if I can figure it out.

Looking at https://github.com/NixOS/nixpkgs/pull/213140, we are probably best off using Cassandra 4 that supports Python 3.


chore: bump protobuf and grpc versions to support apple silicon

Overview
When debugging some issues on my M1 mac, I needed to update the version of the GRPC and Protobuf librarires in order
to be able to build the native parts of the toolings.

Merged into https://github.com/fetchai/cosmpy/pull/330.


Classic dataset on Titanic disaster used often for data mining tutori…

…als and demonstrations
This is a classic dataset used in many data mining tutorials and demos -- perfect for getting started with exploratory analysis and building binary classification models to predict survival.

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Good one @kavyaLokuge
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow these steps.

Star this repository. ⭐
SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .
Go to the profile section from the top right-hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard!
And don’t forget to share your achievement with your friends.

Good one @kavyaLokuge
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow these steps.

Star this repository. ⭐
SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .
Go to the profile section from the top right-hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard!
And don’t forget to share your achievement with your friends.

Profile URL : https://www.clueless.tech/profile/82757644
@nikhil25803


Release v3.12.0

Main features

Set v1.3.0 as default version (#2608)
Enable Walletconnect owners for polygon and BSC (#2589)
Get gasprice from multiple oracles and edited config files (#2604)

Safe apps SDK

Feature: Return threshold and safe owners in getSafeInfo for apps (#2583)

Chores

Report the e2e tests' status in a PR comment

I cannot access any of the builds. It just loads the gnosis safe app forever

Found issues:
https://github.com/gnosis/safe-react/issues/2627

@dasanra , will we have a new release candidate with changed 1.3.0 mastercopy contract for L1?

@liliya-soroka didn't saw this comment before.
Update master copy address for L1 networks is already ready to be check in this PR
https://github.com/gnosis/safe-react/pull/2623/commits/7a289e8c0e06c5f2c89ab32054c65d48429c2dd2

I tried to execute a tx several times with a ledger and I wasn't able too. It always end up failing. It can be sign and execute or only execution.
I've checked in Etherscan, the address of my ledger and no tx was mined in all those attempts, so it seems it's the gnosis app failing to send the tx.
I have a ledger nanoS, last firmware and etherum apps version available

I had no issues with MM, Trezor or WC with MM phone app

@francovenica could you please link safe/tx? the error just says the transaction hasn't been mined within 50 blocks, doesn't mean it's failing

@francovenica @mikheevm is right. Should have been some issue when mining the transaction, low gas or some issues with rinkeby. I'm able to execute with Ledger without issues.

This is the safe https://pr2623--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x574cC50f00536c79143aaA80aB09825083f4f542/transactions
This is the address of the ledger 0x6f965E48347AF3Df65c14CCc176A9CbeCEa0eDb5

The ledger doesn't have any pending transactions though. There are some problems with the backend right now. All the transactions go through just fine, it's backend sync issue or something like this

Oh wait, the latest tx from the ledger is 20 days, are you sure this is the right address?

It is the right address. I don't use the ledger pretty often, usually every 2 weeks for regressions.
All that being said. I tried to create a safe in prod rinkeby in the 3.11.1 version and it is not working there either, so it must be my ledger having issues. This PR is innocent

Ok, regression on rinkeby went just fine. Also did a smoke in bsc and polygon and they worked fine too
The issue with the ledger persist, but since I already have it in prod, I'll check it and report it in a separated issue if necessary.


Lit/Localize: Improve handling of translation messages with same id

Description

Who wants the functionality
Your friends at Reddit 😄

What it is they want
The following code produces the below error when running lit-localize extract

msg(str`${mother} said hello`)
msg(str`${father} said hello`)
....
error TS2324: Message ids must have the same default text wherever they are used

Why they want it
To improve developer ergonomics of using Lit/Localize.

Acceptance criteria
At a minimum: the error message is more clear and actionable.
Ideally: Allow the same message in multiple places, as long as the strings + description are the same.

If there are multiple @lit/localize messages with the same ID (whether defined automatically or manually), we currently run a validation check to reduce the chance that those messages might actually have different semantic meaning, since they will be translated as a single unit. It's defined here: https://github.com/lit/lit/blob/064e2f4aca7fe822206c09438d0e68ccbec0c973/packages/localize-tools/src/program-analysis.ts#L631
The current rule is:

Require that the string portions of the template are identical.
Require that the text of the template expressions are identical.

Which is why the above example errors. We'll modify the rule to instead:

Require that the string portions of the template are identical.
Require that the descriptions are identical.

And to have a more helpful error message like:
The translation message with ID <id> was defined in N places, but with different strings or descriptions. If these messages should be translated together, make sure their strings and descriptions or identical, and consider factoring it out into a common variable or function. If they should be translated separately, add an "id" override to distinguish them."


Add Roma as an ethnic background option

 Prototype: add new ethnicity option to match HESA and Census

Note: this isn't covered in the GDS equality information pattern. However that pattern is based on the 2011 Ethnicity harmonised standard, and the notes for that standard say that for new things teams should follow the 2021 Census, which is more up to date. Roma was included in the 2021 Census.
I've raised an issue against the design system to consider updating to use the 2021 Census options.


Add more tracking options

Right now the app tracks IPV4 address, IPV6 address and User-Agent. Add more tracking options like Country,date filters,Referrers etc. :)

Please assign me this project, I would love to work on it.

Hey @pepoflex  really glad to know that plese go ahead :)

Hey @pepoflex you still working on this? I'd like to help or take over if you don't have the time.

Hola @pepoflex, ¿sigues trabajando en esto? Me gustaría ayudar o hacerme cargo si no tiene tiempo.

Right now I'm out of time brother, please continue.


Inconsistent use of "methods" and "routines"

I noticed in docs for class Method that most sections are "Routines supplied by class..." but "Methods supplied by role Callable".
In the "Routines" section of the docs, there seems to be no consistency with the distinction in the type docs.  E.g. "arity" is listed as a "Routine supplied by class" in the type docs for Method, but as "method" in the Routines page, whereas "assuming" is listed as "Method supplied by role" in the type docs for Method, and as a "method" on the "Routines" page.
Having different terms implies significance, but the inconsistency implies maybe no significance.
I think docs needs to pick one term or another and use it consistently.  Unless there is significance to the term "Routine supplied by...", I think saying "Method supplied by..." for both classes and roles would be more consistent and be easier to understand for people coming from other languages.
Then the Routines page can roll up all routines (method or not) and indicate their types (as it does).

It might be tricky (or needless) to name sections by what they list, as for example this one lists both the sub form of defined() and the method form of .defined(). And this one lists traits in it as well as methods.
Since traits and methods are types of routines, at least factually the sections are correct. It's just the consistency is the issue. I think always naming sections 'Routines supplied by...' would be fine.

What about “routines and methods” or “routines / methods” or something like that?

I agree there should be consistency.  Since classes can supply any of methods and/or subs (and there are cases where the docs identify things as "traits"), I suspect using the generic Routine is the most correct from a language point of view.
I suspect this is not an exhaustive list, but classes/roles/grammars can document things that include terms such as "sub", "method", "trait", "regex", "token", "rule", and "submethod" and the generic way to refer to all of these is likely "routine".  (Routine is the common superclass for all of these.)

I'd prefer more specificity.  Assuming that "Routines provided by" refers to methods provided by subclasses, then I'd much rather the term "method" explicitly.  If traits or other things are inheritable (apologies -- I haven't reached those docs yet), then I'd like to see "Traits provided by..." or whatever.  The more specific and correct and consistent the documentation, the easier it is for new readers to stay oriented.

The problem here that some routines can behave either as methods or as subs, depending on the context. That is the case for mkdir mentioned in #1867. The problem is that they are only indexed as either, not as both.

some routines can behave either as methods or as subs

It's worth noting that's not just because there are both sub and method forms of some routines, but that both Method and Sub objects in Perl 6 are of type Routine, so it's valid to call both of them a "routine":
<Zoffix__> m: say Method ~~ Routine
<camelia> rakudo-moar 97677a792: OUTPUT: «True␤»
<Zoffix__> m: say Sub ~~ Routine
<camelia> rakudo-moar 97677a792: OUTPUT: «True␤»


Add support for more bitmap map parameters

In particular, Invert and Output Amount.

Can I close this?

Yes, closing.


Not the same number of samples at each epoch

Hello,
I have classification dataset of 32k samples, where 89% of my data is class 0 and the other 11% is class 1. I tried to use pytorch-resample to Undersample my 0-class, with a distribution of 0.5/0.5. It did work great, but I noticed that the dataset differs at each epoch, making the training useless. I know there is a random seed initialized the first time we call the Undersample class, but I didn't manage to reset this seed after each epoch since the dataset is part of the DataLoader.
Have you not encountered a similar behavior? Do you have an idea for a fix? Thanks in advance

Hello! Glad to know you're using the package.
You could reset the seed by replacing the rng parameter before generating a new batch, but that would be hacky from an API perspective.
Could you maybe provide a minimal reproducible example to further explain what you would like? I'm happy to make changes that help you but I'm not 100% clear about what you want.

Hello! Glad to know you're using the package.
You could reset the seed by replacing the rng parameter before generating a new batch, but that would be hacky from an API perspective.
Could you maybe provide a minimal reproducible example to further explain what you would like? I'm happy to make changes that help you but I'm not 100% clear about what you want.

Hello, thanks for releasing it!
After several tries, I can't seem to reproduce the problem with random data, so it seems to come from the WebDataset package. I've tried to reseed the rng, and aside from being hacky it still doesn't work with my WebDataset.

Hello, thanks for releasing it!
After several tries, I can't seem to reproduce the problem with random data, so it seems to come from the WebDataset package. I've tried to reseed the rng, and aside from being hacky it still doesn't work with my WebDataset.


Ellipsoid height validation

Meters: between 600 and 4,300
Feet: between 2,000 and 14,000 (looks like this is already implemented, but it is also applied to meters currently)

This contradicts #88. I think these values are better choices and will use them instead of what you suggested in 88.


Fixed failed docker-compose commands on Makefile

The command is docker-compose and not docker compose. This syntax problem was causing the makefile to fail.

Hi @doublebyte1: I incorporated this change into the Makefile, so now it's using docker-compose instead of docker compose. Thanks for the suggestion!
On this repo, I rebase main to have a really simple commit history, which is why you'll see that force push caused this PR to be closed.


Exclude files from .gitignore

Resolves #200.
PR Checklist

[x] A description of the changes is added to the description of this PR.
[x] If there is a related issue, make sure it is linked to this PR.
[x] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated

Description of changes
This PR implements the changes suggested in the linked issue with the help of pathspec, with a slight modification: it doesn't empty the default exclude list. Since not all projects use git, I figured that it might be better to keep this default list.
Keeping the PR as a draft for now because the documentation needs to be updated to describe the new behaviour.

Codecov Report

Merging #248 (aff5037) into main (01f6b83) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #248   +/-   ##
=====================================
  Coverage   95.6%   95.7%
=====================================
  Files         32      32
  Lines        899     919   +20
  Branches     189     192    +3
=====================================
+ Hits         860     880   +20
  Misses        26      26
  Partials      13      13

Impacted Files
Coverage Δ

deptry/cli.py
93.4% <100.0%> (+0.1%)
:arrow_up:

deptry/core.py
97.6% <100.0%> (+<0.1%)
:arrow_up:

deptry/python_file_finder.py
100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


DBT run fails and throws a TrinoExternalError in QA

Steps to Reproduce
Running dbt on QA models, throws a TrinoExternalError.
Here is an example dbt  --debug run --full-refresh --select models/staging/micromasters/stg__micromasters__app__postgres__auth_user.sql
Expected Behavior
(Optional)
Actual Behavior
(Optional)
Stacktrace
17:17:31.077413 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'deprecation', 'label': '23ee032b-8d56-4a19-b107-2fffc83e9042', 'property_': 'warn', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10c27ddf0>]}
17:17:31.664230 [debug] [MainThread]: Partial parsing enabled: 0 files deleted, 0 files added, 0 files changed.
17:17:31.664532 [debug] [MainThread]: Partial parsing enabled, no changes found, skipping parsing
17:17:31.896153 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'load_project', 'label': '23ee032b-8d56-4a19-b107-2fffc83e9042', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10f15d0d0>]}
17:17:32.668848 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'resource_counts', 'label': '23ee032b-8d56-4a19-b107-2fffc83e9042', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10c74e220>]}
17:17:32.669514 [info ] [MainThread]: Found 177 models, 3786 tests, 0 snapshots, 0 analyses, 590 macros, 0 operations, 0 seed files, 98 sources, 0 exposures, 0 metrics
17:17:32.669952 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'runnable_timing', 'label': '23ee032b-8d56-4a19-b107-2fffc83e9042', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10a585400>]}
17:17:32.827246 [info ] [MainThread]:
17:17:32.827842 [debug] [MainThread]: Acquiring new trino connection "master"
17:17:32.829450 [debug] [ThreadPool]: Acquiring new trino connection "list_ol_data_lake_qa"
17:17:32.844099 [debug] [ThreadPool]: Using trino connection "list_ol_data_lake_qa"
17:17:32.844393 [debug] [ThreadPool]: On list_ol_data_lake_qa: select distinct schema_name
    from ol_data_lake_qa.INFORMATION_SCHEMA.schemata
17:17:32.844678 [debug] [ThreadPool]: Opening a new connection, currently in state init
17:17:33.667961 [debug] [ThreadPool]: SQL status: SUCCESS in 0.82 seconds
17:17:33.670373 [debug] [ThreadPool]: On list_ol_data_lake_qa: Close
17:17:33.691363 [debug] [ThreadPool]: Acquiring new trino connection "list_ol_data_lake_qa_ol_warehouse_qa_staging"
17:17:33.701579 [debug] [ThreadPool]: Using trino connection "list_ol_data_lake_qa_ol_warehouse_qa_staging"
17:17:33.701928 [debug] [ThreadPool]: On list_ol_data_lake_qa_ol_warehouse_qa_staging: select
      table_catalog as database,
      table_name as name,
      table_schema as schema,
      case when table_type = 'BASE TABLE' then 'table'
           when table_type = 'VIEW' then 'view'
           else table_type
      end as table_type
    from ol_data_lake_qa.INFORMATION_SCHEMA.tables
    where table_schema = 'ol_warehouse_qa_staging'
17:17:33.702257 [debug] [ThreadPool]: Opening a new connection, currently in state closed
17:17:35.105744 [debug] [ThreadPool]: SQL status: SUCCESS in 1.4 seconds
17:17:35.110968 [debug] [ThreadPool]: On list_ol_data_lake_qa_ol_warehouse_qa_staging: ROLLBACK
17:17:35.111334 [debug] [ThreadPool]: On list_ol_data_lake_qa_ol_warehouse_qa_staging: Close
17:17:35.112522 [debug] [ThreadPool]: Acquiring new trino connection "list_ol_data_lake_qa_ol_warehouse_qa_intermediate"
17:17:35.119062 [debug] [ThreadPool]: Using trino connection "list_ol_data_lake_qa_ol_warehouse_qa_intermediate"
17:17:35.119438 [debug] [ThreadPool]: On list_ol_data_lake_qa_ol_warehouse_qa_intermediate: select
      table_catalog as database,
      table_name as name,
      table_schema as schema,
      case when table_type = 'BASE TABLE' then 'table'
           when table_type = 'VIEW' then 'view'
           else table_type
      end as table_type
    from ol_data_lake_qa.INFORMATION_SCHEMA.tables
    where table_schema = 'ol_warehouse_qa_intermediate'
17:17:35.119769 [debug] [ThreadPool]: Opening a new connection, currently in state closed
17:17:36.346300 [debug] [ThreadPool]: SQL status: SUCCESS in 1.23 seconds
17:17:36.350657 [debug] [ThreadPool]: On list_ol_data_lake_qa_ol_warehouse_qa_intermediate: ROLLBACK
17:17:36.351075 [debug] [ThreadPool]: On list_ol_data_lake_qa_ol_warehouse_qa_intermediate: Close
17:17:36.352335 [debug] [ThreadPool]: Acquiring new trino connection "list_ol_data_lake_qa_ol_warehouse_qa_mart"
17:17:36.361433 [debug] [ThreadPool]: Using trino connection "list_ol_data_lake_qa_ol_warehouse_qa_mart"
17:17:36.361782 [debug] [ThreadPool]: On list_ol_data_lake_qa_ol_warehouse_qa_mart: select
      table_catalog as database,
      table_name as name,
      table_schema as schema,
      case when table_type = 'BASE TABLE' then 'table'
           when table_type = 'VIEW' then 'view'
           else table_type
      end as table_type
    from ol_data_lake_qa.INFORMATION_SCHEMA.tables
    where table_schema = 'ol_warehouse_qa_mart'
17:17:36.362107 [debug] [ThreadPool]: Opening a new connection, currently in state closed
17:17:37.321953 [debug] [ThreadPool]: SQL status: SUCCESS in 0.96 seconds
17:17:37.328643 [debug] [ThreadPool]: On list_ol_data_lake_qa_ol_warehouse_qa_mart: ROLLBACK
17:17:37.328985 [debug] [ThreadPool]: On list_ol_data_lake_qa_ol_warehouse_qa_mart: Close
17:17:37.329969 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'runnable_timing', 'label': '23ee032b-8d56-4a19-b107-2fffc83e9042', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10f277c10>]}
17:17:37.331228 [debug] [MainThread]: On master: COMMIT
17:17:37.331959 [info ] [MainThread]: Concurrency: 1 threads (target='qa')
17:17:37.332294 [info ] [MainThread]:
17:17:37.336559 [debug] [Thread-1  ]: Began running node model.open_learning.stg__edxorg__bigquery__mitx_courserun
17:17:37.337046 [info ] [Thread-1  ]: 1 of 1 START sql table model ol_warehouse_qa_staging.stg__edxorg__bigquery__mitx_courserun  [RUN]
17:17:37.338049 [debug] [Thread-1  ]: Acquiring new trino connection "model.open_learning.stg__edxorg__bigquery__mitx_courserun"
17:17:37.338397 [debug] [Thread-1  ]: Began compiling node model.open_learning.stg__edxorg__bigquery__mitx_courserun
17:17:37.338739 [debug] [Thread-1  ]: Compiling model.open_learning.stg__edxorg__bigquery__mitx_courserun
17:17:37.343570 [debug] [Thread-1  ]: Writing injected SQL for node "model.open_learning.stg__edxorg__bigquery__mitx_courserun"
17:17:37.344271 [debug] [Thread-1  ]: finished collecting timing info
17:17:37.344630 [debug] [Thread-1  ]: Began executing node model.open_learning.stg__edxorg__bigquery__mitx_courserun
17:17:37.375304 [debug] [Thread-1  ]: Using trino connection "model.open_learning.stg__edxorg__bigquery__mitx_courserun"
17:17:37.375614 [debug] [Thread-1  ]: On model.open_learning.stg__edxorg__bigquery__mitx_courserun: drop table if exists ol_data_lake_qa.ol_warehouse_qa_staging.stg__edxorg__bigquery__mitx_courserun__dbt_tmp
17:17:37.376010 [debug] [Thread-1  ]: Opening a new connection, currently in state closed
17:17:38.096751 [debug] [Thread-1  ]: SQL status: SUCCESS in 0.72 seconds
17:17:38.102278 [debug] [Thread-1  ]: Using trino connection "model.open_learning.stg__edxorg__bigquery__mitx_courserun"
17:17:38.102617 [debug] [Thread-1  ]: On model.open_learning.stg__edxorg__bigquery__mitx_courserun: drop table if exists ol_data_lake_qa.ol_warehouse_qa_staging.stg__edxorg__bigquery__mitx_courserun__dbt_backup
17:17:38.798883 [debug] [Thread-1  ]: SQL status: SUCCESS in 0.7 seconds
17:17:38.818403 [debug] [Thread-1  ]: Writing runtime sql for node "model.open_learning.stg__edxorg__bigquery__mitx_courserun"
17:17:38.822168 [debug] [Thread-1  ]: Using trino connection "model.open_learning.stg__edxorg__bigquery__mitx_courserun"
17:17:38.822530 [debug] [Thread-1  ]: On model.open_learning.stg__edxorg__bigquery__mitx_courserun: create table ol_data_lake_qa.ol_warehouse_qa_staging.stg__edxorg__bigquery__mitx_courserun__dbt_tmp

  as (
    -- MITx Courses Information sourced from edx.org

-- Note that course id here is always in old format as {org}/{course number}/{run} as IR converts the new format
-- to old format in order to preserve functionality of old apps
-- e.g course_id: "MITx/14.73x/3T2020" is the same course run "course-v1:MITx+14.73x+3T2020" in MITxOnline

with source as (

    select * from ol_data_lake_qa.ol_warehouse_qa_raw.raw__irx__edxorg__bigquery__mitx_course

)

, renamed as (

    select
        course_number
        , course_title as courserun_title
        , semester as courserun_semester
        , url as courserun_url
        , institution as courserun_institution
        , instructors as courserun_instructors
        , registration_open as courserun_enrollment_start_date
        , course_launch as courserun_start_date
        , course_wrap as courserun_end_date
        , replace(course_id, 'ESD.SCM1x', 'CTL.SC1x') as courserun_readable_id
        , coalesce(self_paced = 1, false) as courserun_is_self_paced
    from source

)

select * from renamed
  )
17:17:40.430391 [debug] [Thread-1  ]: Trino adapter: Trino query id: 20230209_171738_81550_imgyu
17:17:40.430912 [debug] [Thread-1  ]: Trino adapter: Trino error: TrinoExternalError(type=EXTERNAL, name=HIVE_CURSOR_ERROR, message="io.trino.hive.$internal.org.codehaus.jackson.JsonParseException: Current token (VALUE_STRING) not numeric, can not use numeric value accessors
 at [Source: [B@4b1b5ecc; line: 1, column: 308]", query_id=20230209_171738_81550_imgyu)
17:17:40.431647 [debug] [Thread-1  ]: finished collecting timing info
17:17:40.432085 [debug] [Thread-1  ]: On model.open_learning.stg__edxorg__bigquery__mitx_courserun: ROLLBACK
17:17:40.432470 [debug] [Thread-1  ]: On model.open_learning.stg__edxorg__bigquery__mitx_courserun: Close
17:17:40.433598 [debug] [Thread-1  ]: Database Error in model stg__edxorg__bigquery__mitx_courserun (models/staging/edxorg/stg__edxorg__bigquery__mitx_courserun.sql)
  TrinoExternalError(type=EXTERNAL, name=HIVE_CURSOR_ERROR, message="io.trino.hive.$internal.org.codehaus.jackson.JsonParseException: Current token (VALUE_STRING) not numeric, can not use numeric value accessors
   at [Source: [B@4b1b5ecc; line: 1, column: 308]", query_id=20230209_171738_81550_imgyu)
  compiled Code at target/run/open_learning/models/staging/edxorg/stg__edxorg__bigquery__mitx_courserun.sql
Traceback (most recent call last):
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/adapters/trino/connections.py", line 368, in exception_handler
    yield
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/adapters/sql/connections.py", line 70, in add_query
    cursor.execute(sql, bindings)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/adapters/trino/connections.py", line 330, in execute
    result = self._cursor.execute(sql, params=bindings)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/trino/dbapi.py", line 435, in execute
    result = self._query.execute()
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/trino/client.py", line 758, in execute
    self._result.rows += self.fetch()
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/trino/client.py", line 773, in fetch
    status = self._request.process(response)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/trino/client.py", line 574, in process
    raise self._process_error(response["error"], response.get("id"))
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/trino/client.py", line 543, in _process_error
    raise exceptions.TrinoExternalError(error, query_id)
trino.exceptions.TrinoExternalError: TrinoExternalError(type=EXTERNAL, name=HIVE_CURSOR_ERROR, message="io.trino.hive.$internal.org.codehaus.jackson.JsonParseException: Current token (VALUE_STRING) not numeric, can not use numeric value accessors
 at [Source: [B@4b1b5ecc; line: 1, column: 308]", query_id=20230209_171738_81550_imgyu)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/task/base.py", line 385, in safe_run
    result = self.compile_and_execute(manifest, ctx)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/task/base.py", line 338, in compile_and_execute
    result = self.run(ctx.node, manifest)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/task/base.py", line 429, in run
    return self.execute(compiled_node, manifest)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/task/run.py", line 281, in execute
    result = MacroGenerator(
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/clients/jinja.py", line 326, in __call__
    return self.call_macro(*args, **kwargs)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/clients/jinja.py", line 253, in call_macro
    return macro(*args, **kwargs)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/jinja2/runtime.py", line 763, in __call__
    return self._invoke(arguments, autoescape)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/jinja2/runtime.py", line 777, in _invoke
    rv = self._func(*arguments)
  File "<template>", line 96, in macro
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/jinja2/sandbox.py", line 393, in call
    return __context.call(__obj, *args, **kwargs)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/jinja2/runtime.py", line 298, in call
    return __obj(*args, **kwargs)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/clients/jinja.py", line 326, in __call__
    return self.call_macro(*args, **kwargs)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/clients/jinja.py", line 253, in call_macro
    return macro(*args, **kwargs)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/jinja2/runtime.py", line 763, in __call__
    return self._invoke(arguments, autoescape)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/jinja2/runtime.py", line 777, in _invoke
    rv = self._func(*arguments)
  File "<template>", line 52, in macro
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/jinja2/sandbox.py", line 393, in call
    return __context.call(__obj, *args, **kwargs)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/jinja2/runtime.py", line 298, in call
    return __obj(*args, **kwargs)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/adapters/base/impl.py", line 278, in execute
    return self.connections.execute(sql=sql, auto_begin=auto_begin, fetch=fetch)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/adapters/trino/connections.py", line 481, in execute
    _, cursor = self.add_query(sql, auto_begin)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/adapters/trino/connections.py", line 460, in add_query
    connection, cursor = parent.add_query(
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/adapters/sql/connections.py", line 78, in add_query
    return connection, cursor
  File "/Users/sar/.pyenv/versions/3.9.12/lib/python3.9/contextlib.py", line 137, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/Users/sar/Library/Caches/pypoetry/virtualenvs/ol-data-platform-IaJixTul-py3.9/lib/python3.9/site-packages/dbt/adapters/trino/connections.py", line 379, in exception_handler
    raise DatabaseException(msg)
dbt.exceptions.DatabaseException: Database Error in model stg__edxorg__bigquery__mitx_courserun (models/staging/edxorg/stg__edxorg__bigquery__mitx_courserun.sql)
  TrinoExternalError(type=EXTERNAL, name=HIVE_CURSOR_ERROR, message="io.trino.hive.$internal.org.codehaus.jackson.JsonParseException: Current token (VALUE_STRING) not numeric, can not use numeric value accessors
   at [Source: [B@4b1b5ecc; line: 1, column: 308]", query_id=20230209_171738_81550_imgyu)
  compiled Code at target/run/open_learning/models/staging/edxorg/stg__edxorg__bigquery__mitx_courserun.sql
17:17:40.442074 [debug] [Thread-1  ]: Sending event: {'category': 'dbt', 'action': 'run_model', 'label': '23ee032b-8d56-4a19-b107-2fffc83e9042', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10f3c9e50>]}
17:17:40.442718 [error] [Thread-1  ]: 1 of 1 ERROR creating sql table model ol_warehouse_qa_staging.stg__edxorg__bigquery__mitx_courserun  [ERROR in 3.10s]
17:17:40.443275 [debug] [Thread-1  ]: Finished running node model.open_learning.stg__edxorg__bigquery__mitx_courserun
17:17:40.445164 [debug] [MainThread]: Acquiring new trino connection "master"
17:17:40.446138 [debug] [MainThread]: On master: COMMIT
17:17:40.446891 [info ] [MainThread]:
17:17:40.447246 [info ] [MainThread]: Finished running 1 table model in 0 hours 0 minutes and 7.62 seconds (7.62s).
17:17:40.447593 [debug] [MainThread]: Connection 'master' was properly closed.
17:17:40.447920 [debug] [MainThread]: Connection 'model.open_learning.stg__edxorg__bigquery__mitx_courserun' was properly closed.
17:17:40.850601 [info ] [MainThread]:
17:17:40.850978 [info ] [MainThread]: Completed with 1 error and 0 warnings:
17:17:40.851318 [info ] [MainThread]:
17:17:40.851653 [error] [MainThread]: Database Error in model stg__edxorg__bigquery__mitx_courserun (models/staging/edxorg/stg__edxorg__bigquery__mitx_courserun.sql)
17:17:40.851970 [error] [MainThread]:   TrinoExternalError(type=EXTERNAL, name=HIVE_CURSOR_ERROR, message="io.trino.hive.$internal.org.codehaus.jackson.JsonParseException: Current token (VALUE_STRING) not numeric, can not use numeric value accessors
17:17:40.852273 [error] [MainThread]:    at [Source: [B@4b1b5ecc; line: 1, column: 308]", query_id=20230209_171738_81550_imgyu)
17:17:40.852572 [error] [MainThread]:   compiled Code at target/run/open_learning/models/staging/edxorg/stg__edxorg__bigquery__mitx_courserun.sql
17:17:40.852884 [info ] [MainThread]:
17:17:40.853230 [info ] [MainThread]: Done. PASS=0 WARN=0 ERROR=1 SKIP=0 TOTAL=1
17:17:40.853660 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'invocation', 'label': 'end', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10f3c7d30>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10f3a5d90>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10f764b50>]}
17:17:40.854105 [debug] [MainThread]: Flushing usage events

Related Issues
(Optional)
Screenshot or Screencast
(Optional)

Chatted with Starburst folks about it but they weren't sure what could be causing this. I did come across this issue https://github.com/trinodb/trino/issues/12866 that seems similar to what we're running into. Tried querying QA in Athena, and that works, however it fails in the Starburst UI which in my mind is pointing back to data syncing and the glue connector and how it's formatting the data that it uploads to S3.

This was generated by an error in the Airbyte protocol upgrade as part of release 0.40.31 and was resolved in 0.41.0.


Initial work on rewritting the theme

As mentioned in #1, this is just some initial work on moving the theme from the colorgen structure to something more maintainable. Definitely not ready for merging right now.
config.lua and util.lua are taken from the rose-pine repo almost word for word, which isn't great.
The main reason why I am even making the draft PR is to make sure everyone can see the changes.

This makes the scheme usable, but removes support for all plugins. But if they link to the built-in highlight groups by default they should look correctly anyway. I will now start going through most common plugins and adding explicit support one by one.


Can i specify the expiration date instead of 2 years 3 month?

https://github.com/FiloSottile/mkcert/blob/1a5aaff12e0edb54f32ce187079d05c4a1ffd19b/cert.go#L62
I need more longer expiration time for self signed certs, not only for IOS/MAC.

Sorry, but mkcert is an opinionated tool that aims to hide all the complexity it can from developers, not a general purpose local CA management tool. We're not going to make the lifetime configurable when that can make the certificates mysteriously fail on some platforms.

Sorry, but mkcert is an opinionated tool that aims to hide all the complexity it can from developers, not a general purpose local CA management tool. We're not going to make the lifetime configurable when that can make the certificates mysteriously fail on some platforms.

So, Apple changed their security policies in April 2021 after this ticket was closed, and the new policies reject any certificates over a year in expiration without certain other requirements attached to them. I appreciate this is an opinionate tool, however the ability to generate a temporary certificate with a 3-6 month length would be very useful for people developing on macOS versions >= 10.14. https://sslmate.com/blog/post/apples_new_ct_policy has an explanation of exactly what they changed in it, which I'm hoping means more to you than me (SSL's internals isn't really in my wheelhouse!)

i think you can modify this line . then recompile and generate binaries to replace the original binaries


TSServer: Use JSON-RPC as RPC protocol (discussion)

Currently, TSServer uses its own protocol for RPC. The mechanics of it are fine and it does the job well. However, when it comes to implementing clients for TSServer, it is somewhat tedious to build wrappers specifically to interface with the TSServer protocol. Although it is fairly trivial thing to implement, it ends up being a unnecessary upfront cost to using TSServer (i.e. https://github.com/Microsoft/vscode/blob/master/extensions/typescript/src/utils/wireProtocol.ts)
As a client library user, this would be very helpful and would have saved me a significant amount of time when using TSServer.
As far as compatibility goes, the current protocol has a convention for RPC which looks like:
{ command: "someCommand", arguments: ... }

JSON-RPC would look something like:
{"jsonrpc": "2.0", "method": "someMethod", "params": ..., "id": 1}

As you can see, the serialization works out pretty favorably, and it would possible to actually support both JSON-RPC and the current protocol for a period of time to ease deprecation. If boilerplate is a concern, we could potentially even omit the jsonrpc key like xi-editor does.
Let me know your thoughts on this idea, and thanks for all the excellent work on Typescript!

Changing the protocol now means that every users of the server needs to change their serialization logic. so the only option is to add another protocol, and then maintain them as we go forward..
The server is exposed as both a node process, this one uses the JSON+contentLength messages as well as stdio for reading and writing. The server is also exposed as a library, see https://github.com/Microsoft/TypeScript/blob/master/lib/tsserverlibrary.js. This library has all the functionality without the node interaction. you can load it in your process, and customize the implementation. all you will need is to override the implementation of Session.send.

Possible duplicate #11274

so the only option is to add another protocol, and then maintain them as we go forward

@mhegazy Would it not be possible to deprecate the current protocol, support both serialization formats until the next major release, then drop support fort for the old protocol on the next major release?

@mhegazy Would it not be possible to deprecate the current protocol, support both serialization formats until the next major release, then drop support fort for the old protocol on the next major release?

it would. but that means that VSCode, VS plugin, sublimtext plugin, vim plugin, emacs plugin, eclipse plugin, etc.. have to all change their serialization. if I was in one of these plugin author shoes, i would not be happy about that.

if I was in one of these plugin author shoes, i would not be happy about that.

I wrote the TypeScript backend for YouCompleteMe and would definitely not be happy. If the protocol was changed, all clients would have to maintain both protocols if they wanted to be backwards compatible.

@icholy I am a bit confused since you seem supportive of https://github.com/Microsoft/TypeScript/issues/11274
Regardless, this issue can probably be closed in favor of that one.

@ianks IMO trade-offs are worth it with the language-server-protocol as opposed to just changing the format.

@mhegazy do you think you will attention to support Language Server for TypeScript https://github.com/Microsoft/TypeScript/issues/11274
I'm really interested with this support since Eclipse IDE and Eclipse Che are implementing Language Server  . It exists many Language Server like JSON, CSS but not for TypeScript -(

@mhegazy do you think you will attention to support Language Server for TypeScript #11274

I do not think we have talked about this specifically. A bit of a historical perspective. the TS LS protocol came first :) and then VSCode elaborated on it, and changed some things.
having said that, i do not see why not implement the protocol if there are consensuses around it. again, we will need to support this along with the current protocol, either through a configuration message to select the protocol version to use or some other mean.

I would be very interested in having Typescript officially support the language server protocol.
I have created an LSP client in pure vim script which works asynchronously in both vim and neovim. https://github.com/prabirshrestha/vim-lsp
It is currently being used by https://github.com/tjdevries/nvim-langserver-shim

As noted earlier, this would be a large breaking change, or a large tax to take. we would likely implement #11274 instead.