Booting instance cause infinite recursion in the case of enough user quota and unlimited project quota

Do NOT include any confidential information, this issue will be created on a public repo
This section is completed by the issue reporter
On which version(s) do you encounter this issue?
Please provide the output to 'git describe --all' for  all deployments where you have confirmed it occurs.
liberty-12.2
What type of issue is this? Please tick the appropriate box.

[x] bug - existing functionality that does not work for you as documented
[ ] feature - new functionality that you would like to see added

What is the expected behavior?
https://bugs.launchpad.net/nova/+bug/1491222
https://bugs.launchpad.net/nova/+bug/1591429
What is actually happening?
https://bugs.launchpad.net/nova/+bug/1491222
https://bugs.launchpad.net/nova/+bug/1591429
What were you attempting to do when you encountered this error (give as much detail as possible)?
https://bugs.launchpad.net/nova/+bug/1491222
https://bugs.launchpad.net/nova/+bug/1591429
How can we reproduce this issue?
https://bugs.launchpad.net/nova/+bug/1491222
https://bugs.launchpad.net/nova/+bug/1591429
How can we verify your issue is addressed?
https://bugs.launchpad.net/nova/+bug/1491222
https://bugs.launchpad.net/nova/+bug/1591429
If you are using or know of a workaround please describe the necessary steps?
What is your evaluation on the importance of this issue, and why?

This section is completed during the issue resolution process. If you are reporting an issue, please do not modify the section below.
Which branches are impacted by this issue?
Remove branches that are not impacted.
For each pull request, update the branch line to reference it.

[ ] master
[ ] liberty-12.2

Upgrade impact. Consider the impact on moving between major, minor and patch releases.

[ ] This change does not impact upgrades
[ ] This change addresses a potential upgrade impact
[ ] The upgrade impact is being tracked by another issue.

The issue tracking the upgrade impact is:
Testing impact

[ ] An issue/pull-request has been create or exists to track the testing gap, and is referenced below
[ ] This change includes additional testing
[ ] This change is tested by the existing setup

Additional testing links:
Release note

[ ] This change includes a release note.
[ ] This change does not require a release note.

Doc Impact
Does your change require documentation?

[ ] Yes, and I submitted an issue to Docs issues
[ ] Yes, and I contributed a documentation patch to docs-rpc
[ ] No documentation required for this change

Additional documentation links (please add links if you have ticked yes):

@git-harry Looks like @JCallicoat proposed a backport to liberty upstream already [1]. Does this need to be added to RPC-O also?
[1] https://review.openstack.org/#/c/329231/

@ameserole I don't understand your question.
I see that review has been there for 5 weeks. We need to be working with the community to try and get it merged given the importance support place on its resolution.

UPDATE:
The backport is not passing gating tests. I am investigating on how to fix the issues now.

@git-harry This was assigned to Andrew but he is going and I must have missed this one at the replenishment meeting. We need someone to continue this work. cc: @mancdaz

@alextricity25 aren't you working on this?

@sigmavirus24 no. It should be moved back to approved IMO

@alextricity25 I'll ask differently. Can you work on this one please :)
We can't move work backwards as it creates flow debt.

Those assigned to work on revision releases need to organise around the issues that have lost an owner due to changing team membership. As a group we have committed to this work and so need to do our best to complete it.

@git-harry I saw someone already working on Liberty fix, so should I help him reviewing or open another patch review to fix liberty issue?

I discussed the possibility of @Frank-ZhangXin contributing to the upstream Nova project by helping get this patch merged so we can file an OSA bug for a SHA bump to include it, so we can bump the OSA sha in RPC-O and get this deployed. The change looks small and simple, so barring any serious objections by Nova, I can't see any reason this would be too big a deal.
But, the status of this bug should be "blocked" until the upstream bug(s) are merged, I would think.

@tomc603 the SHA updates are done as part of the RPCO and OSA release processes. If that is all that's left to do, the issue can be moved to pending-SHA-update. If the Nova patch just needs reviews, this issue can be moved to needs-review or if @Frank-ZhangXin is helping create the patch it should stay in doing. The issue shouldn't be blocked if the upstream work needs completing because part of us pulling the issue in is so that we assist with it.
I'll remove the blocked label but if I've missed something let me know and we can change it.

@JCallicoat hi, Jordan. I would like to assist you on the existing backport. Or I am able to take over it if your schedule too packed. What do you think? Thanks

Update: rebase to master, gate test - devstack vm gate test failed, which is caused by timeout of devstack-vm-gate.sh . And other nova network tests failed also. Previous one test related to nova network passed this time. My conclusion is no idea what happened, and need more advise.

@tomc603 is this something you can help Frank with?

Currently blocked until we get support feedback.

Update: I've have reached master patch author Rui Chen, and exchange each other's mind. The conclusion so far still is we're getting unrelated gate errors. The patch works for a better nova db unit test rather than triggering devstack and xenserver failed.

I took a look at review. I suspect we'll have to keep rechecking that xenserver CI job until it passes. If it fails a bunch more, we should try to get in touch with the CI maintainers about it.

Update: Citrix XenServer CI -dsvm-tempest-nova-network is failed which is caused by "Invalid disk format 'qcow2' for image.".

This is blocked upstream waiting for nova stable brach maintainers to merge the backport. Don't think you need anything from @rcbops/support-feedback.

@tbreeds Given the time frames around liberty, can you advise on the possibility of this going into liberty upstream? It's something that bubbled up for us and some customers in support.
@jhesketh Can you possibly have a look at this for us from the ci side? The Xenserver CI job seems cranky, and seems like it should be unrelated to the patch, but I don't think we know for sure. Any help would be appreciated, or if you can direct us to the right folk.

@claco thanks for reference

I'll look at the patch today, with a 30second look I think it'll be okay for liberty.
XenServer is 3rd  party CI so it's more of a nova issues that an Infra issue.  I'll look at that as we may have introduced a regression while that CI was offline.  Also IIUC it isn't blocking the change even with a -1 from that CI we can merge it

Yeah so the XenServ CI is misconfigured:  http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/31/329231/3/check/dsvm-tempest-nova-network/b323a09/logs/etc/glance/glance-api.conf.txt.gz
Doesn't list qcow2 it has "ami,ari,aki,vhd,raw,iso" so it'll will never pass.  I'll look at adding a fix to tempest to detect this and skip if required

Actually this is happening because of I41c09d5a682cdb068b97b4bd1be3403ee7973c7c which is relatively new.  We need to get XenServer CI reconfigured
Until then it'll fail everything

I'll reach out to the CI in question.  This should be failing on master as well, but like I said it's not on the critical path

I've done the needfull.  I'll poke some of the (non-racker) nova-stable-cores in the next few days

I agree with Tony's assessment here. It's up to the 3rd party CI to fix their tests. Tony let me know if you need any help reaching out to them if you haven't already.

@tbreeds @jhesketh Thanks, guys. Appreciate professional insight and review.
@git-harry @b3rnard0 So this should be marked blocked until upstream CI test fixed in future. Tony has already state the cause very specifically which points out 'qcow2' format missing in nova config.

Thanks @jhesketh I reached out to them yesterday.
The XenServer CI team has "fixed" the problem by disabling that test :( rather than doing as I suggested and add the appropriate devstack config :(
So this is currently blocked on a second (non-racker) core review of the change in question.

Update:
gate-tempest-dsvm-neutron-multinode-full and Mellanox CI are failed, but don't block patch merging.
@tbreeds Tony do you family any Nova community or IRC channel that we could send our patch to review? Thanks.

Update:
Just got another +2, patched merged.

SHA bump has been completed and includes the upstream fix for this in liberty https://github.com/rcbops/rpc-openstack/pull/1422


Return tuples

Fix #10, always return a tuple from SanicTestClient request, and ASGITestClient request()

Note, this has now introduced a new MyPy error:
sanic_testing/testing.py:293: error: Signature of "request" incompatible with supertype "AsyncClient"

Note, this has now introduced a new MyPy error:
sanic_testing/testing.py:293: error: Signature of "request" incompatible with supertype "AsyncClient"

Fixes #11 by casting the HTTPX response to a Sanic response. The use case for this original behavior no longer exists.

Fixes #11 by casting the HTTPX response to a Sanic response. The use case for this original behavior no longer exists.


Revert fix build for older Go versions

Revert previous version check to keep compatibility for Go v1.17+ only.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Compat conflict only occurs on M1, which currently fails for other reasons.


pretrain model shape is different with config shape

input cmd
python scripts/cicai_render.py --load-config outputs/clone/nsg-vkitti-car-depth-recon/2023-08-02_085533/config.yml --output_path renders/output-pretrain.mp4 --seconds 13
I place the pretrained vkitti2 model below in 2023-08-02_085533

output
Loading poses from: vkitti2/Scene06/clone/pose.txt
Loading bbox from: vkitti2/Scene06/clone/bbox.txt
Loading info from: vkitti2/Scene06/clone/info.txt
[array([0.]), array([1.]), array([2.]), array([7.]), array([8.]), array([3.]),
array([9.]), array([4.]), array([5.]), array([12.]), array([6.]), array([10.]),
array([11.]), array([13.])] in this scene
finished data parsing
Loading poses from: vkitti2/Scene06/clone/pose.txt
Loading bbox from: vkitti2/Scene06/clone/bbox.txt
Loading info from: vkitti2/Scene06/clone/info.txt
[array([0.]), array([1.]), array([2.]), array([7.]), array([8.]), array([3.]),
array([9.]), array([4.]), array([5.]), array([12.]), array([6.]), array([10.]),
array([11.]), array([13.])] in this scene
finished data parsing
/home/rongbo.ma/anaconda3/envs/mars/lib/python3.8/site-packages/torchmetrics/utilities/prints.py:61: FutureWarning: Importing PeakSignalNoiseRatio from torchmetrics was deprecated and will be removed in 2.0. Import PeakSignalNoiseRatio from torchmetrics.image instead.
_future_warning(
Loading latest checkpoint from load_dir
Traceback (most recent call last):
File "scripts/cicai_render.py", line 391, in
entrypoint()
File "scripts/cicai_render.py", line 387, in entrypoint
tyro.cli(RenderTrajectory).main()
File "scripts/cicai_render.py", line 311, in main
_, pipeline, _, _ = eval_setup(
File "/home/rongbo.ma/nerf/mars/nerfstudio/nerfstudio/utils/eval_utils.py", line 104, in eval_setup
checkpoint_path, step = eval_load_checkpoint(config, pipeline)
File "/home/rongbo.ma/nerf/mars/nerfstudio/nerfstudio/utils/eval_utils.py", line 61, in eval_load_checkpoint
pipeline.load_pipeline(loaded_state["pipeline"], loaded_state["step"])
File "/home/rongbo.ma/nerf/mars/nsg/nsg_pipeline.py", line 252, in load_pipeline
self.load_state_dict(state, strict=True)
File "/home/rongbo.ma/nerf/mars/nerfstudio/nerfstudio/pipelines/base_pipeline.py", line 125, in load_state_dict
self.model.load_state_dict(model_state, strict=False)
File "/home/rongbo.ma/anaconda3/envs/mars/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1671, in load_state_dict
raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for SceneGraphModel:
size mismatch for background_model.field.embedding_appearance.embedding.weight: copying a param with shape torch.Size([358, 32]) from checkpoint, the shape in current model is torch.Size([476, 32]).

Hi! Thanks for your feedback! If you want to render with our pre-trained model, you must ensure that your config is the same as the config.yml you load in.
We have already uploaded our config to Google Drive, you can visit here to download our config.yml for each pre-trained model.

@xBeho1der Your kitti pretrain model is wrong. For task reconstruction, the size of the pretrain model' embedding_appearance in TCNNNerfactoField is [384, 32]. But for image range [5, 260], its size should be [512, 32]. I think the pretrain model for task reconstruction is in fact the model of nvs-75, since 512*0.75=384


Promise rejection when running track-investments

I have been able to run the sync-bank,kbb, and zestimate scripts but I get this error with the track-investments.
I have one SimpleFIN synced account that I added "calcInvestment" to the notes.
connect
open file
Loaded spreadsheet from cache (14787 items)
Syncing since 2024-07-01T19:53:43.236Z-0000-a172f8989c62ff17 2 (attempt: 0)
Got messages from server 1
node:internal/process/promises:389
      new UnhandledPromiseRejection(reason);
      ^

UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "#<Object>".
    at throwUnhandledRejectionsMode (node:internal/process/promises:389:7)
    at processPromiseRejections (node:internal/process/promises:470:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32) {
  code: 'ERR_UNHANDLED_REJECTION'
}

Node.js v22.3.0

Can you try running node --trace-warnings track-investments.js to see if we get a useful stack trace?

That doesn't appear to have change the output.
connect
open file
Loaded spreadsheet from cache (14787 items)
Syncing since 2024-07-01T19:56:28.349Z-0000-a172f8989c62ff17 0 (attempt: 0)
Got messages from server 1
node:internal/process/promises:389
      new UnhandledPromiseRejection(reason);
      ^

UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "#<Object>".
    at throwUnhandledRejectionsMode (node:internal/process/promises:389:7)
    at processPromiseRejections (node:internal/process/promises:470:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32) {
  code: 'ERR_UNHANDLED_REJECTION'
}

Node.js v22.3.0

@faultoverload I also updated the code to add more logging, could you pull and see if that gives a trace?

@faultoverload This might have been because you renamed the account.  Did you rename the account from what SimpleFIN originally provided?
I hit that issue with one of my accounts.  I fixed the crash, but unfortunately for now I can't get it to work.  There is a PR in Actual that needs merged before this can work with accounts that were renamed.

Hey, I don't think I renamed anything in simplefin but the account name in
Actual doesn't match with Simplefin.
I tried running the updated code you added but I was actually getting
errors for all the scripts after that. Tested on my local install as well
as a docker container running node.
On Wed, Jul 10, 2024, 7:50 PM Robert Dyer @.***> wrote:

@faultoverload https://github.com/faultoverload This might have been
because you renamed the account. Did you rename the account from what
SimpleFIN originally provided?
I hit that issue with one of my accounts. I fixed the crash, but
unfortunately for now I can't get it to work. There is a PR in Actual that
needs merged before this can work with accounts that were renamed.
—
Reply to this email directly, view it on GitHub
https://github.com/psybers/actual-helpers/issues/1#issuecomment-2221722817,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKIMSHFWUPF4V7TBU6O3MGTZLXCEHAVCNFSM6AAAAABKGGJLU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRRG4ZDEOBRG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

@faultoverload Did you update the packages, npm update? It needs the latest Actual API.
But yes if the name does not match that was why you were previously getting an error.  As of right now, the error should be silenced but it will not update it.  After one of my PRs is merged in and a new Actual release happens I'll update these scripts and it should start working.

@faultoverload You need to run npm update to get the latest Actual API.  Otherwise, you get APIErrors because the API you are using does not match the server's API.
Since you are doing it via Docker images, you will need to rebuild the Docker image.

Ok actually this might be my code.  It looks like the API was changed to require a category ID and I do not provide one.  Let me try fixing this.

@faultoverload If you can, please pull the latest.  This should fix your issues.  You might need to set some new environment variables in your .env file:
# optional, name of the payee for added interest transactions
INVESTMENT_PAYEE_NAME="Investment"
# optional, name of the cateogry group for added investment tracking transactions
INVESTMENT_CATEGORY_GROUP_NAME="Income"
# optional, name of the category for added investment tracking transactions
INVESTMENT_CATEGORY_NAME="Investment"

I pulled your new code and rebuilt the container and after a bit of fussing about it appears to be working correctly.
Is it possible to allow us to declare the SimpleFIN token through the .var file because having to type it into the console during the first run breaks the automation with Docker.

The token is only good for one use, so no matter how you do it you must save the result.  You could mount the path into your Docker image, so that the file that saves the login token is persisted.
I'm going to close this issue since you got it working.

That said I can maybe get it so you can stuff the resulting token into an ENV...

Pull the latest.  Now when you give it your setup token it will print the credentials (and store to the file).  If you want, you can stick that into an ENV and it will use that instead of the file.

Thanks! That did the trick. I submitted my code as a pull request in case anyone else wants to use Docker for this project.


StreetNamePost type in City Name

The PlaceName gets tagged as StreetNamePostType in cases where the PlaceName is like a StreetNamePostType.
Sample strings that were parsed.
5113 OLD GRANBURY ROAD FORT WORTH TX 76133
115 LONGHORN ROAD FORT  WORTH TX 76179
12317 DAVIS BULEVARD FORT MYERS, FL 33905
418 S ALISTER STREET PORT ARANSAS TX 78373
1600 N STATE STREET FORT  DAVIS TX 79734
7001 S FREEWAY FORT  WORTH TX 76134
Obtained output
(u'5113', 'AddressNumber'),
(u'OLD', 'StreetName'),
(u'GRANBURY', 'StreetName'),
(u'ROAD', 'StreetName'),
(u'FORT', 'StreetNamePostType'),
(u'WORTH', 'PlaceName'),
(u'TX', 'StateName'),
(u'76133', 'ZipCode')
Expected Output
(u'5113', 'AddressNumber'),
(u'OLD', 'StreetName'),
(u'GRANBURY', 'StreetName'),
(u'ROAD', 'StreetNamePostType'),
(u'FORT', 'PlaceName'),
(u'WORTH', 'PlaceName'),
(u'TX', 'StateName'),
(u'76133', 'ZipCode')
The parser works well in cases where the StreetNamePostType is abbreviated and in some cases if it is spelt correctly 'Boulevard' or 'BLVD' instead of 'Bulevard'
if the address string was '5113 OLD GRANBURY RD FORT WORTH TX 76133', the output is as expected.
(u'5113', 'AddressNumber'),
(u'OLD', 'StreetName'),
(u'GRANBURY', 'StreetName'),
(u'RD', 'StreetNamePostType'),
(u'FORT', 'PlaceName'),
(u'WORTH', 'PlaceName'),
(u'TX', 'StateName'),
(u'76133', 'ZipCode')

That's an interesting edge case @yashodhan19! We can drop these in as training data for the next release. I'd also accept a PR if you want to help improve the model yourself.


local tests can't be run in root folder of exercise

It seems that this bug usually doesn't happen and it may have been user error like mistyped path, etc. . We should still verify that this bug can never happen by going through the code.
The error message that was "You have to give exercise name in parameters" or something similar.

It seems that the recent refactoring of WorkDir removed also this problem


Techdebt/provider refactor + blocknative wip

This PR upgrades our blocknative bnc-onboard wallet to web3-onboard, as well as refactoring much of the global state management to centre around events rather than individual pieces of state.

Nice! I left some minor comments but it looks good to me. We still have the problem that staking will ask metamask to swtich network if you have our tab open and are on a network we're not supporting. But if you'd plan to tackle that in another PR this make sense. Oh also, need to rebase dev too, have some conflicts

@bachstatter I've added this for the network switching thing

And re-added some icons for wallet type


Add walletVersion as a required string on wire-format.message.payload

In the xstate wallet: populate this string using the githash (which we are already using and is injected during the webpack build).
In the server wallet: write the package version number into the compiled javascript before publishing. Use an empty string otherwise (e.g. with ts-node).
Also throw an error if we got a message from a wallet at a different walletVersion.

I yarn linked locally to the graph repo, ran the e2e tests and found what I wanted in the logs

Note that the specific short term goal this PR aims to achieve is to detect and notify when your wallet is talking to a different wallet (i.e. one at a different version).
It also makes it relatively simple to extend / relax this so that "different wallet" becomes "incompatible wallet" , for example using semantic versioning to decide whether there is a problem or not.

In response to feedback:

no new errors thrown anymore
catch pushMessage errors and insert context about 2x wallet versions (this + incoming message)
wallets own their child logger and every log message has log their DB_NAME and walletVersion

I guess at a high level I'm confused as to whether or not there should be two concepts; one for the wallet software version and another for the wire format version that perhaps multiple wallets (e.g., browser and server) at multiple versions (e.g., August 2020 and November 2020) might both be compatible with

I guess at a high level I'm confused as to whether or not there should be two concepts; one for the wallet software version and another for the wire format version that perhaps multiple wallets (e.g., browser and server) at multiple versions (e.g., August 2020 and November 2020) might both be compatible with

Perhaps: at least this PR gets us some of the way there. The wire-format version (if we chose to use that at some point) would be inserted and checked at a slightly different level, I think. As it is we are using exact versioning, so it's easy to infer a version of the wire format that each of our wallet versions is compatible with.


Usernamespaces: Fix permissions on runDirPath and BundlePath

When running crio with id-mappings,it fails to create container
due to permission errors.
Fixes: #1939
Signed-off-by: vikaschoudhary16<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

/approve
/test all

ping @giuseppe @mrunalp

LGTM

@giuseppe may be /lgtm is required to tag it.

We usually do 2 LGTM before tagging it.  So I am waiting for another review first

/lgtm


Clarify licensing

This series try to clarify the current licensing situation, with the objective of then being able to upload this to Debian. I've tried to infer the correct licenses from the stuff in the repo as a starting point, but probably my guesses are wrong, I'm happy to amend any of them.
I think the spec file syntax is correct, but I've not run rpmlint.
I've also left the debian directory alone for now which contains incorrect licensing data, with invalid syntax, as packaged this project from scratch anyway, and I'm not sure whether there's value in shipping the packaging upstream? So perhaps a better option is to remove it? But if you want to preserve it, I could prepare a targeted fix for just the copyright file though.

Can you drop the io_uring.h change, then I'm happy with the rest.

Thanks, pulled.


Part 4: Add Date of birth option in User profile; #186 - subtask.

This subtask is for the enhancement https://github.com/rilling/OpenTracksConcordia/issues/186 .
Add components for choosing the Date of birth and storing it in local storage to be used by other parts of the app.
Location: src/main/res/xml/settings_user_profile.xml
After making the necessary changes, merge it with the branch [group_9_case_2]

Added DOB input field

The above changes are committed and pushed to the mentioned branch.
Commit Link: https://github.com/rilling/OpenTracksConcordia/commit/32c4955538772ce0d82e7e55fd091c73a851e1d9

Commit : https://github.com/rilling/OpenTracksConcordia/commit/695c4477d40caadf7d62d8cec76d9f8d6cda5e11


sub classes are generated in different parent classes with jdk6 update 14

Previously using xjc to generate java classes for asap.xsd an observers class
would be generated as a sub class in the SetPropertiesRs class. After updating
to jdk6 the Observers class is now being added to the GetPropertiesRs class. The
issue is ultimately traced to the jdk hashMap class hash function being changed
so that the hashMaps are in a different order that before. The jaxb SchemaImpl
class uses hashMaps to store the elements in the schema, which later is used to
generate the element classes. Before jdk6 for the asap.xsd the hashmap looked
like - {ResultData=ResultData element declaration, SubscribeRq=SubscribeRq
element declaration, CompletedRs=CompletedRs element declaration,
Instance=Instance element declaration, SetPropertiesRs=SetPropertiesRs element
declaration, UnsubscribeRs=UnsubscribeRs element declaration,
UnsubscribeRq=UnsubscribeRq element declaration, StateChangedRq=StateChangedRq
element declaration, GetPropertiesRq=GetPropertiesRq element declaration,
ListInstancesRs=ListInstancesRs element declaration, ContextData=ContextData
element declaration, CreateInstanceRs=CreateInstanceRs element declaration,
CompletedRq=CompletedRq element declaration, SetPropertiesRq=SetPropertiesRq
element declaration, GetPropertiesRs=GetPropertiesRs element declaration,
ChangeStateRs=ChangeStateRs element declaration, SubscribeRs=SubscribeRs element
declaration, ChangeStateRq=ChangeStateRq element declaration, Event=Event
element declaration, CreateInstanceRq=CreateInstanceRq element declaration,
ListInstancesRq=ListInstancesRq element declaration,
StateChangedRs=StateChangedRs element declaration
Now with jdk 6 it is -
ContextData=ContextData element declaration, ResultData=ResultData element
declaration, Instance=Instance element declaration,
GetPropertiesRs=GetPropertiesRs element declaration,
GetPropertiesRq=GetPropertiesRq element declaration, Event=Event element
declaration, ListInstancesRq=ListInstancesRq element declaration,
UnsubscribeRq=UnsubscribeRq element declaration, SetPropertiesRs=SetPropertiesRs
element declaration, UnsubscribeRs=UnsubscribeRs element declaration,
SetPropertiesRq=SetPropertiesRq element declaration,
StateChangedRs=StateChangedRs element declaration,
ListInstancesRs=ListInstancesRs element declaration,
CreateInstanceRs=CreateInstanceRs element declaration,
ChangeStateRq=ChangeStateRq element declaration, StateChangedRq=StateChangedRq
element declaration, CreateInstanceRq=CreateInstanceRq element declaration,
ChangeStateRs=ChangeStateRs element declaration, CompletedRq=CompletedRq element
declaration, SubscribeRs=SubscribeRs element declaration,
SubscribeRq=SubscribeRq element declaration, CompletedRs=CompletedRs element
declaration
Being that the GetPropertiesRs class is listed first in the hashmap now the
Observers class is generated there and all references to it in other classes are
GetPropertiesRs.Observers rather than SetPropertiesRs.Observers in the previous jdk.
We've currently changed our code to handle the class location being different
but are concerned that this may cause issues elsewhere that we have not seen.
Environment
Operating System: Windows XP
Platform: PC
Affected Versions
[2.1.10]

LinkedHashMap is there


TypeError: Cannot use 'in' operator to search for 'ie' in undefined:  Getting Error validate-jsons.js

I executed validate-jsons.js on data.json and its throwing error.
TypeError: Cannot use 'in' operator to search for 'ie' in undefined     at Validator.validateKeys (C:\Users\Qadeer.a\Documents\caniuse-master\validator\validate-jsons.js:186:30)     at Validator.validateSupportData (C:\Users\Qadeer.a\Documents\caniuse-master\validator\validate-jsons.js:216:18)     at Validator.validateFeature (C:\Users\Qadeer.a\Documents\caniuse-master\validator\validate-jsons.js:250:18)     at new Validator (C:\Users\Qadeer.a\Documents\caniuse-master\validator\validate-jsons.js:284:22)     at processFile (C:\Users\Qadeer.a\Documents\caniuse-master\validator\validate-jsons.js:309:13)     at C:\Users\Qadeer.a\Documents\caniuse-master\validator\validate-jsons.js:319:13     at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:446:3)

Not seeing any issues according to Travis CI at https://travis-ci.org/Fyrd/caniuse/ . Perhaps fetch the latest data and try again?

At this line 323, i changed from sample-data.json to data.json. In response i get this error.
https://github.com/Fyrd/caniuse/blob/master/validator/validate-jsons.js#L323

I encountered the same issue.


Define workflow for verifying MSRV for [lib]s where version reqs support a range of MSRV

[lib]-only crates generally do not maintain a Cargo.lock file which makes verifying MSRV difficult because a dependency version requirement might cover a range of MSRVs.
Case studies

Clap's MSRV checks broke (and many dependent crate's CIs broken) when bitflags updated its MSRV

https://github.com/clap-rs/clap/issues/2691
https://github.com/clap-rs/clap/issues/2734
https://github.com/clap-rs/clap/issues/2735

To prevent that scenario, Nom constrained the upper bound of their version req, breaking other people's builds

As far as I'm aware, the only solution I know for this is to keep a Cargo.lock.msrv and to copy it over in CI.  cargo-msrv verify natively recognizing this pattern and documenting it would be one solution.
The ideal long term solutions are

-Z minimal-versions that only does minimal versions for direct dependencies (see ehuss's comment) (only a partial solution)
Cargo's resolver to take MSRV into account

(somewhat related to #117)

Excellent suggestion, thanks for opening an issue!
I'll have a proper look at this soon.


[Request for External] Document Service Management

OnPrem we use the "Document Service Management" (COD 9510) to store documents on Sharepoint and to call them up again. We would like to use these functions in the cloud as well.

Can you allow access on table<PHONE_NUMBER> "Document Service" in scope "Cloud"?
Remove [Scope('OnPrem')] on functions in codeunit 9510 "Document Service Management"?

Thank you!

@StanPesotskiy Is there any indication if and when we can expect this feature? Thank you.

@bleisibach Thank you for your suggestion!
However, the requested function operate with file paths and there are security concerns when opening such functions for cloud development. As for the table, we try to hide table behind APIs.
Document Service is a great idea for a new system module! Would you interested in developing such a system module? I promise I'll help on the way.

If you want to learn more about what it takes to develop a new AL Module, you can read more here aka.ms/NewALModule.

@bleisibach Just letting you know that we created a work item on our backlog to reenable Document Service for cloud.
Unfortunately, however, I cannot promise any delivery point in time.

Thank you @mazhelez for putting this on the list.
The suggestion to advance the topic as an AL Module was tempting. Unfortunately, we currently lack the necessary resources.
We currently only need a minimally small part of the code unit:

TestConnection
SaveStream
OpenDocument

And of course we need access to the table<PHONE_NUMBER> "Document Service" to save the setup. So everything without file access etc ...
Thank you anyway!

Enable "Document Service" for cloud is now set as candidate for 2021 Wave 2. We will have to do some work on the authentication bit as well to make this work properly in a cloud setting.

@Jesper: thx for enabling the functionality. Unfortunately, all the functions in codeunit "Document Service Management" are still scoped to On-prem and are file based too. Why this? We want to use it on SaaS to upload our own documents as a stream.

I would have to get back to you on this one. We haven't gotten around to address this request yet and I'm not sure if we're going to, as we're working on a similar story around OneDrive. Those are the changes you're seeing in that codeunit! Let me ask someone who knows a little more about our plans to reply to this thread.

Discussion will continue in new issue created.


PEP8 complient

Blank lines in PEP8:

Surround top-level function and class definitions with two blank lines.
Method definitions inside a class are surrounded by one single blank line.

Extra blank lines may be used (sparingly) to separate groups of related functions. Blank lines may be omitted between a bunch of related one-liners (e.g. a set of dummy implementations).
Reference: http://legacy.python.org/dev/peps/pep-0008/#blank-lines

Fixed in e0a112152a7a7fbc8c7c640e5c55554ad0b2e745.
Use the following code if you don't want to clean up multiple blank lines for Python:
# do not clean up multiple blank lines for PEP8-compliant
let g:scavenger_exclude_on_blank_linse = ['python']


build: drop support for python 3.6

Closes #61
macos-latest on Actions is transitioning to macos-11, which will also no longer have support for Python 3.6. actions/virtual-environments#4060

github actions?


BIGTOP-4153: Enhance Bigtop package.gradle: Add pkgSuffix and parentD…

…ir Build Arguments for Deb Package

Description of PR
Update package.gradle to pass pkgSuffix and parentDir parameters to the Debian package scripts to support the "Add pkgSuffix and parentDir Build Arguments for Deb Package" feature.
How was this patch tested?
1.test with   pkgSuffix and parentDir parameters

2.test without   pkgSuffix and parentDir parameters

3.run zk smoke test on ubuntu-22

For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
[ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

@iwasakims Could you help check again?


Makefile: Use the full git commit hash when building binaries

Update the root Makefile and copy-paste the GIT_COMMIT from the
staging/operator-lifecycle-manager/Makefile that checks if any of the
ART-defined environment variables are present in the build environment,
and falling back to the full git commit hash.
This is important as there's existing tests in openshift/origin that
verify that full commit hash is present when running the
version/--version command/flags for the OLM and registry binaries.

Link to a rehearsal that caught this when attempting to promote from the downstream monorepo instead of the upstream equivalents: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/17323/rehearse-17323-pull-ci-openshift-operator-framework-olm-release-4.9-e2e-gcp/1376992350034726912.

/lgtm


TE with threading build

Description
In #987, TE build with parallel jobs was added, while threading for fused_attn build was removed. With #1048, the build time of the ext can be measured and compared.
It turns out that using max parallel jobs together with setting --threads 4 halves the build time. However, it adds some potential oversubscribes that may break the build on NGC. So NVTE_MAX_BUILD_THREADS env var was added to provide an option to disable this threading build.
Type of change

[ ] Documentation change (change only to the documentation, either a fix or a new content)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Infra/Build change
[ ] Code refractor

Checklist:

[x] I have read and followed the contributing guidelines
[x] The functionality is complete
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

I updated the default value for threading to 1 and added a message for parallel build info.


python -m unittest seq2seq.test.pipeline_test -> ModuleNotFoundError: No module named 'seq2seq'

seq2seq/test/pipeline_test.py:25: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses   import imp Traceback (most recent call last):   File "seq2seq/test/pipeline_test.py", line 35, in <module>     from seq2seq.test import utils as test_utils ModuleNotFoundError: No module named 'seq2seq'
I get this error when running the unit test pipeline_test. Any suggestions to solve the problem?

您的邮件已收到，，，我会尽快回复的，，，

maybe the tensorflow version doesn't match. i face some other questions lack of packages or no exist packages on tf-v2.8


Pythonnet Converter is leaking memory

Expected Behavior

No memory leak occurs during conversion
Actual Behavior

There is a memory leak in the conversion of the new supported types
Potential Solution

Review and free leaking memory
Update pythonnet version to <IP_ADDRESS> (next version number)

Reproducing the Problem

Execute python algorithm with a ton of calls to OnData()
System Information

N/A
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

@AlexCatarino please update the NuGet package with the new version of pythonnet


Browse window does not stay in Dark Theme mode

Issue
While testing the Visibility Add-In in ArcGIS Pro 2.6 in Dark Theme mode.
I noticed that the browse window does not stay consistent with the Dark Theme mode while importing relevant files, such as: .SHP, .txt, .csv, etc.

Expected Behavior
This browse window should stay consistent and match the Dark Theme mode..
Detailed steps

Launch ArcGIS Pro 2.6
Open the Visibility Add-In through the Add-In tab
Right click below the Observer Points or Target Points window and select Import
Observe the background color associated with the Browse window

Additional Info:
ArcGIS Pro Build
ArcGIS Pro 2.6.0 alpha3+build 23550
Visibility Add-In Version and Date:

@dfoll  please provide feedback

@OscarVilla1 good issue. I would just add the build number of ArcGIS Pro 2.6, because it is not released yet

Successfully tested on ArcGIS Pro 2.6
Add-In release date: 9 MARCH 2020
Issue has been fixed.


chore: prepare Falcon 4.0.2 (in-tree)

This is WiP, items remaining:

[x] Aggregate contributors.
[ ] Add a newsfragment for enabling PDF on RtD.
[ ] Decide when we want to ship this.

Decide when we want to ship this.

I think wait a few more days to see if anything more pops up, then release like at the beginning on November.
After that we could start working on 4.1

Hm, maybe we should add #2396 to known typing limitations?

Hm, maybe we should add #2396 to known typing limitations?

Makes sense


update a11y project

👷 Deploy Preview for fancy-puffpuff-df775f processing.

Name
Link

🔨 Latest commit
f23372caa1487bd50669a91ca95e0631b02be5b9

🔍 Latest deploy log
https://app.netlify.com/sites/fancy-puffpuff-df775f/deploys/664a5fb066c07b00086af479


Resolve Inference Selection Bug Affecting Transcription Quality

Currently, when none of the inference made at different temperatures can satisfy all of the "non-fallback" conditions, the last one is returned (the one with the biggest emperature with default args).
This can lead to weird behaviors, for example:
# I want to transcribe this piece of audio
print(model.transcribe(audio)["text"]) # Works fine

# I want to transcribe this piece of audio, and i want it to be very good so I increase the min logprob
print(model.transcribe(audio, logprob_threshold=-0.2)["text"]) # Result is bad because the one inference that is returned is the last one, with the biggest temperature

This PR doesn't change the behaviour when one of the inferences satisfy all of the conditions.
When it's not the case, the result that is returned is the one leading to the highest avg_logprob
When the avg_logprob condition isn't satisfied and the result is re-computed with a greater temperature, the best option is returned

This change makes sense but I think it should take into account compression_ratio_threshold.
For example only consider the results where the compression ratio is below compression_ratio_threshold and select the best log prob from them. If all compression ratios are above compression_ratio_threshold, then it can pick the best log probs from all results.

This PR was merged into SYSTRAN/faster-whisper#356 and seems to somewhat improve transcription quality. Is there anything I can do for the review process ?

Hello guys,
I have also encountered this bug recently, so let me share my opinion about solution of this issue.
So let's assume the none of the predictions is meeting the criteria for compression_ratio and logprob.

I aggree with @guillaumekln, that in the case where one or more of the predictions is meeting the criteria for compression_ratio, then select the one with the best logprob.
If none of the predictions is meeting the criteria for compression_ratio, it can be a bit tricky to just select the one with the best logprob, because for small improvement of logprob, you can gain huge increase of compression_ratio.

So I suggest to calculate something called tradeoff_factor, that would take into both compression_ratio and logprob as:
(logprob of the prediction/logprob threshold) * (compression_ratio of the prediction / compression_ratio threshold).
And afterwards select the prediction with the lowest value of this tradeoff_factor.
In the current case, it will be:
[0.72419, 0.79707, 0.800047, 0.7878599, 0.9106927, 0.40129]
Possible implementation:
def _select_best_prediction(
    decoded_results: List[Decoding_result],
    logprob_threshold: Optional[float] = -1,
    compression_ratio_threshold: Optional[float] = 2.4,
) -> DecodingResult:
    """Select best prediction from decoded results with various temperatures."""
    assert len(decoded_results) > 0
    predictions_meeting_compression = []
    for pred in decoded_results:
        if pred.compression_ratio <= compression_ratio_threshold:
            predictions_meeting_compression.append(pred)

    # Case 1: There exist prediction with compression lower than
    # is the threshold
    # Then select the prediction with best log_prob
    if len(predictions_meeting_compression) > 0:
        return max(predictions_meeting_compression, key=lambda x: x.avg_logprob)

    # Case 2: There does not exist any prediction with compression ratio
    # smaller than the threshold
    # Then calculate tradeoff_factor between log_prob and compression ratio as
    # (logprob of the prediction/logprob threshold) *
    # (compression_ratio of the prediction / compression_ratio threshold)
    # and select the prediction with lowest value of this factor
    else:
        tradeoff_factors = []
        for pred in decoded_results:
            factor = (pred.avg_logprob / logprob_threshold) * (
                pred.compression_ratio / compression_ratio_threshold
            )
            tradeoff_factors.append(factor)
        best_index = tradeoff_factors.index(min(tradeoff_factors))
        return decoded_results(best_index)


fix: don't echo double backslashes to server.properties

Using sed, we need to escape backslashes, but with echo we can just use the variable as-is.
Closes #949

It looks like auto-merging of changes to branches is broken: https://github.com/itzg/docker-minecraft-server/actions/workflows/merge-variants.yml. It fails on merging .github/workflows/build-multiarch.yml to branches without workflows permission.

Yep, that's by design in GitHub actions. And then I forgot to do the merge myself manually. Doing that now...

Merged and new images pushed

Great, thanks!


Upgrade y18n package to v4.0.1

Upgrade y18n package (used by the React UI) from v4.0.0 to v4.0.1, which fixes CVE-2020-7774.
See https://github.com/yargs/y18n/blob/v4/CHANGELOG.md#401-2020-11-30
(Issue is also fixed in y18n v5.0.5)
This is the same issue as https://github.com/prometheus/prometheus/issues/8282

@kyoto Thanks for opening this. We should take care of it. Help wanted.
Also, it's curious that we haven't alerted by the dependabot?

This was fixed by https://github.com/thanos-io/thanos/pull/3813


[5.1] Increasing code readability in ResetsPassword trait

Added tiny type-hinting there and better variable naming to enhance code readability. Nothing big. I needed this for myself and took me some time to find out what that variable $m is in that lambda function.

@GrahamCampbell You said it was essentially breaking. Did you mean type-hinting may break things because of IoC container behaviour?


Hidden container

There are some problems with hidden containers - its getting wrong dimensions when its hidden and trigger load function when it shouldnt be, maybe you could add some if to check if container is visible first and then go working ?
Im using it with notifications - on hover/click like on facebook.

I am having same issue. Did you manage to solve it? @Jurigag

I added those directives : infinite-scroll-use-document-bottom="false"
infinite-scroll-distance='1' infinite-scroll-parent and it works fine. My parent is  list.

@Jurigag could you provide samples? Did not work for me

My html template looks like this:

Nieprzeczytanych powiadomień:

Code of it is just included in  tag which is display:none by default.

@Jurigag thanks


enhance(source): remove admin check from ListUserRepos

required change for https://github.com/go-vela/community/issues/102

Changes
removed admin access filter from ListUserRepos
altered/added source testdata for ineligible repos, now tests ineligiblity based on archived/enabled rather than admin access.


mgba: 0.6.1 -> 0.6.3

Motivation for this change
Another update and small restructure.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build mbga

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: mbga
Partial log (click to expand)
Cannot nix-instantiate `mbga' because:
error: attribute 'mbga' in selection path 'mbga' not found

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: mbga
Partial log (click to expand)
Cannot nix-instantiate `mbga' because:
error: attribute 'mbga' in selection path 'mbga' not found

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: mbga
Partial log (click to expand)
Cannot nix-instantiate `mbga' because:
error: attribute 'mbga' in selection path 'mbga' not found

@Chiiruno This package doesn't seem to be present in pkgs/top-level/all-packages.nix.

@yegortimoshenko I seem to have misnamed the title.
The package that needs to be built is mgba.

@GrahamcOfBorg build mgba

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: mgba
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: mgba
Partial log (click to expand)
shrinking /nix/store/fpi445gjwmpscknj6rkwqh48sajn9zwg-mgba-0.6.3/bin/mgba
shrinking /nix/store/fpi445gjwmpscknj6rkwqh48sajn9zwg-mgba-0.6.3/bin/mgba-qt
shrinking /nix/store/fpi445gjwmpscknj6rkwqh48sajn9zwg-mgba-0.6.3/lib/libmgba.so.0.6.1
gzipping man pages under /nix/store/fpi445gjwmpscknj6rkwqh48sajn9zwg-mgba-0.6.3/share/man/
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fpi445gjwmpscknj6rkwqh48sajn9zwg-mgba-0.6.3/lib  /nix/store/fpi445gjwmpscknj6rkwqh48sajn9zwg-mgba-0.6.3/bin
patching script interpreter paths in /nix/store/fpi445gjwmpscknj6rkwqh48sajn9zwg-mgba-0.6.3
checking for references to /build in /nix/store/fpi445gjwmpscknj6rkwqh48sajn9zwg-mgba-0.6.3...
postPatchMkspecs
/nix/store/fpi445gjwmpscknj6rkwqh48sajn9zwg-mgba-0.6.3

Success on aarch64-linux (full log)
Attempted: mgba
Partial log (click to expand)
shrinking /nix/store/s01frflb6vyhvqgmlmj6y31ha1ymx6w8-mgba-0.6.3/bin/mgba-qt
shrinking /nix/store/s01frflb6vyhvqgmlmj6y31ha1ymx6w8-mgba-0.6.3/bin/mgba
shrinking /nix/store/s01frflb6vyhvqgmlmj6y31ha1ymx6w8-mgba-0.6.3/lib/libmgba.so.0.6.1
gzipping man pages under /nix/store/s01frflb6vyhvqgmlmj6y31ha1ymx6w8-mgba-0.6.3/share/man/
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s01frflb6vyhvqgmlmj6y31ha1ymx6w8-mgba-0.6.3/lib  /nix/store/s01frflb6vyhvqgmlmj6y31ha1ymx6w8-mgba-0.6.3/bin
patching script interpreter paths in /nix/store/s01frflb6vyhvqgmlmj6y31ha1ymx6w8-mgba-0.6.3
checking for references to /build in /nix/store/s01frflb6vyhvqgmlmj6y31ha1ymx6w8-mgba-0.6.3...
postPatchMkspecs
/nix/store/s01frflb6vyhvqgmlmj6y31ha1ymx6w8-mgba-0.6.3


[WIP]Add tests to  check upstream data

Signed-off-by: Shivam Sandbhor<EMAIL_ADDRESS>

Part of https://github.com/nexB/vulnerablecode/issues/272 effort

@rolfschr  this pr is adding a test for upstream data sources. The nix pipeline is running this test, could you disable that.
I think  at https://github.com/nexB/vulnerablecode/blob/d8ce30e29c0d3257a1d00d89feb0afa753ba3f69/etc/nix/flake.nix#L139
instead of just running pytest, running pytest -m "not webtest" would fix this. Not sure whether this has any side effets tho.


Track and Branch Automation fails during merge trigger.

The Branch and Track automation fails when it is triggered during a merge. It fails during the following call:
git diff --name-only HEAD~1..HEAD
This is called to check if any of the files in the releases directory were changed. This seems to fail during merges due to some conflict between git branches. A different method to discover these changes needs to be found.
Until then the current workaround is to just ignore the merge failure and call the automation manually through workflow dispatch.

I am not looking at this code atm, but I've seen similar things in other CI.  It might be because the way you git diff against the "past" depends on whether you're doing a PR or merge.  There are some gh actions written specifically to handle this, or our own logic can be implemented


Images only check ignores the whitelist

After enabling the images only check, we noticed that normal users, who were already in the white list, were banned by the bot after sending images without text. I believe this to be unintended behavior.

From the code, I don't see how this is even possible. The check for approved users happens before any other checks are reached, including the image-only check (a part of the meta checks).
https://github.com/umputun/tg-spam/blob/fd75fc789e09ff89b93567d7aa934d2e77bd6bda/lib/tgspam/detector.go#L120-L120
Are you sure you have not set ParanoidMode (check all messages, env: 'PARANOID', cli: '--paranoid')? The other way to have the check invoked for active users is by setting FIRST_MESSAGES_COUNT, which is by default 1 ("number of first messages to check").

I was able to reproduce. If you're okay with that, I can follow the logs to you privately (they contain some sensitive data). But my user was indeed banned by the bot while being in the whitelist (and, in fact, remaining in the whitelist after the ban).

And the reasons for the ban were:

I was able to reproduce. If you're okay with that, I can forward the logs to you privately (they contain some sensitive data). But my user was indeed banned by the bot while being in the whitelist (and, in fact, remaining in the whitelist after the ban).

sure, send it over. also configuration (docker compose or cli params) may help to reproduce it locally

should be fine on master, pls give it a try. the PR #177 explains what the issue was.

By the way, thanks for providing details and pushing the issue, which was real.


Fix namespaces and psr compliance

@daveross
Hey, I like the project and wanna help, I can fix namespaces mostly when
/*
* @return Closure
*/

should be
/*
* @return \Closure
*/

So IDE know it's from global namespace.
and also indentation according to PSR since it's I guess most popular standard theses days.
Can you add me to contributors so I could create PRs.
Thanks.

This should be completely addressed in version 4.0.0. Let me know if you see additional changes that will make it work better with your IDE.


Show refresh button if fetching live state has error

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

Show a button to refresh the live state instead of auto-refreshing if has an error

/approve

/approve


Why should one gamut map in interpolation instead of clipping?

This is really more a question.
I know color.js defaults to gamut mapping instead of naive clipping, which is cool. And I understand that this helps give more accurate colors when converting from a large color space to a small color space. And color.js generally recommends against using simple clipping, but from what I've observed, gamut mapping seems to give choppy results in interpolation.
You can kind of see the solid bands and such instead of a smooth transition.

We can see here that clipping gives much smoother results (it was easier to show both in this fashion). The second gradient is the clipped one:

It seems in some cases that gamut mapping maybe isn't always the best. It seems that, for instance, if you are in a smaller gamut, and want to interpolate in a larger gamut, that maybe clipping is better. In the above scenario, you ramp up to the gamut limit, so it seems clipping will just keep it at that limit until it drops back into the gamut. If you gamut map in these situations, it seems it can create a discontinuity as the chroma compression can give a noticeably different color than what you were transitioning through.
I guess my question is whether I am missing something? Is there some kind of flaw in my thinking?

I'm now convinced that there is a flaw in the gamut mapping algorithm. I spent some time actually go over the algorithm, and the issue (seems to me) be related to the second condition in this loop:
while ((high - low > ε) && (error < base_error)) {

I removed that, I found that I get a smooth transition:

I think the algorithm is kicking out too soon sometimes.

Cleans up gradients a lot in the color.js docs as well:
Before:

After:

I'm happy to create a pull request, but I'll wait for a response to see if maybe I'm missing something.

I see that color.js has been updated. Gamut mapping looks much better now 🙂.
I also did more testing, and I did find some cases where using simple gamut checks was not ideal, so I think I will stick with Delta E as well 🙂. It may be more expensive, but I agree it gives the overall best results.

I just updated it again and, if the gamut mapping space is OKLCH then it uses the (better, also cheaper) deltaEOK rather than deltaE2000. (It also adjusts the value for a JND, in that case, from 2 to 0.02).
The default space for gamut mapping is also OKLCH, now.


Bad package for Ubuntu: can't install update

OS: Ubuntu 20.04.2 LTS x86_64
DE: Xfce 4.14
WM: Xfwm4 version 4.14.1 (revision 44809c49)
At the moment I've:

Today it offered me to download update (as many times before): I was redirected to browser and automatically started downloading of dbeaver-ce_21.1.5_amd64.deb file. I've run that file and get this (only Remove):

But if I look at the installed version, I see this (no version at all):

What happened? Why can't I anymore install newer just via *.deb-file from site? How should I update dbeaver?

@MikePryadko Hello. Have you updated DBeaver by executing a *.deb file before? It can be related to our latest fix that let's you have multiple editions of Dbeaver on one machine.

Hi @Matvey16 ! Yes, I've used that method few times and all was Ok.

Ok, we will look into that. In the meantime you can update either by removing and reinstalling DBEaver with latest deb package or just use sudo dpkg -i dbeaver-ce_21.1.5_amd64.deb to update your current version

@Matvey16 thanks for the advice, but my current version works fine so I prefer to wait yours fix and then test it :sunglasses: I think it's right: I've got the problem and I'll report it fixed. :relieved:

Seems to be a problem with outdated PPA. Must be fixed by now.

@MikePryadko Are you sure you were able to just execute the .deb file and click an update button earlier. I can't remember if it was ever possible and everyone on our team who uses linux don't remember it either. I also tried installing old version 21.0.0 and update it with .deb file of 21.0.1 version, but it still had only remove.
Can you update any other app like this? Maybe this behavior was changed on OS level in some of the Ubuntu updates.

There has been no update on the issue for a long time. If it is still actual for you - feel free to reopen it with additional info

@Matvey16 yes, I'm sure. And yes - right now I've updated Zoom exactly by this way :relieved:
https://user-images.githubusercontent.com/31248040/147404554-90330b41-a0df-4f09-804d-61c99d08730c.mp4


[Identity] Add new @azure/identity library and @azure/core-http abstractions

This PR introduces the new @azure/identity library for simplifying client authentication in the new Azure data plane SDK libraries.  I might wait to add thorough tests so that folks can go ahead and take a dependency on the @azure/core-http abstractions ASAP.
Questions for Reviewers

~Is it a good idea to alias string | string[] to CredentialScopes or does that introduce unnecessary import complexity?~
~Should I run Prettier or some other formatter over this code before merging?~

Tasks

[x] Test ClientSecretCredential against Azure to ensure it retrieves an access token successfully
[x] Write basic tests for AzureCredential, EnvironmentCredential, and ClientSecretCredential
[x] Run Prettier on code
[x] Add basic usage instructions in README.md

Related to #2650.

I wouldnt alias string | string[] to CredentialScopes. Its one more level of indirection which I don't believe we need.
Do run Prettier. I believe all the new packages are using it.

Thanks for all the feedback so far!  I've addressed everything actionable and have moved this PR out of Draft state so that we can move forward with the final review.  Please let me know if you have any other feedback!

Thanks again for all the feedback!  I'll rebase this PR and then merge it once CI goes green again :tada:

Argh, now the npm audit job is failing the build because @azure/core-http isn't published to npm.  Why didnt' this fail in any of the previous jobs for this PR?


ChakraProvider is transferred to @chakra-ui/provider

Hello,
ChakraProvider is transferred to @chakra-ui/provider:
https://www.npmjs.com/package/@chakra-ui/provider
Ps. Thank you for you great project
Best Regards,
Mike

Thanks, thats worked for me.

you can also import it from @chakra-ui/react:
import { ChakraProvider } from "@chakra-ui/react";
just make sure to update the dependency:
npm install @chakra-ui/react
thats work for me ;)


Product Customizable Options not exported

Customizable Options of Simple Products are currently not exported at all. They are available in mage2vs.

PR: https://github.com/DivanteLtd/magento2-vsbridge-indexer/pull/42


bugfix:replaceAll escape content.

Coverage decreased (-0.02%) to 47.075% when pulling d83720150ce09e1a750b00ad96024edad6b556f4 on lepdou:bugfix_1206 into f144fe06f20f254d5c6cfafdcded6786d41996f8 on ctripcorp:master.

Current coverage is 43.91% (diff: 3.57%)

Merging #475 into master will decrease coverage by 0.01%

@@             master       #475   diff @@
==========================================
  Files           303        303
  Lines          7731       7743    +12
  Methods           0          0
  Messages          0          0
  Branches        887        888     +1
==========================================
+ Hits           3396       3400     +4
- Misses         4091       4099     +8
  Partials        244        244

Powered by Codecov. Last update f144fe0...d837201

Coverage decreased (-0.1%) to 46.96% when pulling 005ee5968e3e4d59f0a1c30e139a511776271906 on lepdou:bugfix_1206 into f144fe06f20f254d5c6cfafdcded6786d41996f8 on ctripcorp:master.

Coverage decreased (-0.1%) to 46.95% when pulling 005ee5968e3e4d59f0a1c30e139a511776271906 on lepdou:bugfix_1206 into f144fe06f20f254d5c6cfafdcded6786d41996f8 on ctripcorp:master.

Coverage decreased (-0.04%) to 47.057% when pulling 873ea6bb84c1e6fb2793488791bf0cf005fc135b on lepdou:bugfix_1206 into f144fe06f20f254d5c6cfafdcded6786d41996f8 on ctripcorp:master.

Coverage decreased (-0.1%) to 46.993% when pulling 873ea6bb84c1e6fb2793488791bf0cf005fc135b on lepdou:bugfix_1206 into f144fe06f20f254d5c6cfafdcded6786d41996f8 on ctripcorp:master.


[examples/sveltekit-scoped/] Trying to update the example with preset-typography without much luck.

Hello @jacob-8 I have made a fork of the example with some minimal changes that I describe in the README header.
Here is the repo: https://github.com/bySabi/example-unocss-sveltekit-scoped
I think the problem is that the preset-typography doesn't get loaded globally.
The Visual Studio Code UnoCSS extension also does not highlight the prose class
It would be nice to have a preset-typography example with SvelteKit. I am not able to find any.

@bySabi thanks for your patience on this - you've probably moved on by now, but do know that #2098 includes the ability to use presetTypography as well as a usage example. Once that is merged, you'll be good to go.

@bySabi we've created a new project that depends on UnoCSS called svelte-scoped-uno. You can read how to install at https://github.com/jacob-8/svelte-scoped-uno/blob/main/packages/svelte-scoped-uno/README.md and you have an example project with typography at https://github.com/jacob-8/svelte-scoped-uno/blob/main/examples/sveltekit-vite-plugin - note especially the unocss.config.ts


dynamic run expensive CI

Currently, we have some expensive CI checks, eg. docker.
I want to add a dynamic run workflow like OpenDAL.
stateDiagram-v2
    [*] --> Push
    [*] --> PR

	State1: Language CI
    note left of State1
      every expensive language CI can be set differently
    end note

    Push --> Determine
    PR --> Determine
    Determine --> State1
    State1 --> [*]

Thanks, looks reasonable to me!


K8SPS-204: don't depend on orchestrator for topology discovery

https://jira.percona.com/browse/K8SPS-204
DESCRIPTION
Problem:
We don't want to use an orchestrator for topology discovery, as it will be one point of failure.
Solution:
We should improve the  pkg/mysql/topology package and use it instead of sending requests to the orchestrator.
CHECKLIST
Jira

[x] Is the Jira ticket created and referenced properly?
[x] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[x] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[ ] Is an E2E test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?

Config/Logging/Testability

[ ] Are all needed new/changed options added to default YAML files?
[ ] Are the manifests (crd/bundle) regenerated if needed?
[ ] Did we add proper logging messages for operator actions?
[ ] Did we ensure compatibility with the previous version or cluster upgrade process?
[ ] Does the change support oldest and newest supported PS version?
[ ] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
failure

gr-demand-backup
failure

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
failure

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
failure

version-service
passed

We run 23 out of 23

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/8217f42a0f2be88987221ab183657df677502474
image: perconalab/percona-server-mysql-operator:PR-339-8217f42

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
failure

version-service
passed

We run 23 out of 23

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/c6383e7727747edddd7ea801d04279bc54d814de
image: perconalab/percona-server-mysql-operator:PR-339-c6383e7

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
failure

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 23 out of 23

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/b4a53300caaafad4466c97cf24e4fee33dc22d13
image: perconalab/percona-server-mysql-operator:PR-339-b4a5330

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 23 out of 23

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/b4a53300caaafad4466c97cf24e4fee33dc22d13
image: perconalab/percona-server-mysql-operator:PR-339-b4a5330

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
failure

gr-bootstrap
failure

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 23 out of 23

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/cc640a90b5ed8893fe36d1da9a3915b6f82c8713
image: perconalab/percona-server-mysql-operator:PR-339-cc640a9

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-bootstrap
passed

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
failure

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

self-healing-chaos
failure

We run 24 out of 24

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/a6e616a4da887ed31acd105aef3fe2a8a7df9635
image: perconalab/percona-server-mysql-operator:PR-339-a6e616a

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-bootstrap
passed

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
failure

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

self-healing-chaos
failure

We run 24 out of 24

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/9670cc556dfe6435501e2392971f98bcb6346c0e
image: perconalab/percona-server-mysql-operator:PR-339-9670cc5

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-bootstrap
passed

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

self-healing-chaos
failure

We run 24 out of 24

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/27c7b3f0317002a818571239dbe74c387fa155ad
image: perconalab/percona-server-mysql-operator:PR-339-27c7b3f

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-bootstrap
passed

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

gr-self-healing-chaos
failure

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

self-healing-chaos
failure

We run 25 out of 25

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/b887ca607fd695579e5679eaa0278e388ae511b2
image: perconalab/percona-server-mysql-operator:PR-339-b887ca6

The idea of TOPOLOGY_EXPERIMENTALis, if it's not enabled we should preserve the old behavior. As I see, we use new experimental topology manager in bootstrap, in haproxy checks even if it's not enabled.

We shouldn't delete orc-handler. The idea is not depending on orchestrator for discovery, it's still the orchestrator that manages async topology and it should be the orchestrator that labels the primary pod.

I see new tests are failing, you probably need to drop finalizers as the last step like we do in other tests.

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-bootstrap
passed

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

gr-self-healing-chaos
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

self-healing-chaos
passed

We run 25 out of 25

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/5ea4793c5e2961ffeec291fc6f68b159c875a004
image: perconalab/percona-server-mysql-operator:PR-339-5ea4793

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-bootstrap
passed

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

gr-self-healing-chaos
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

self-healing-chaos
passed

We run 25 out of 25

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/aabef925be9672ca2edc32cc343470ed20d2dcb3
image: perconalab/percona-server-mysql-operator:PR-339-aabef92

Test name
Status

async-ignore-annotations
failure

auto-config
failure

config
failure

config-router
failure

demand-backup
failure

gr-bootstrap
failure

gr-demand-backup
failure

gr-ignore-annotations
failure

gr-init-deploy
failure

gr-one-pod
failure

gr-scaling
failure

gr-tls-cert-manager
failure

gr-self-healing-chaos
failure

haproxy
failure

init-deploy
failure

limits
failure

monitoring
failure

one-pod
failure

scaling
failure

service-per-pod
failure

sidecars
failure

tls-cert-manager
failure

users
failure

version-service
failure

self-healing-chaos
failure

We run 25 out of 25

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/3d2b994431c77db74ba47c0d7ddf813ba5e8de64
image: perconalab/percona-server-mysql-operator:PR-339-3d2b994

please fix conflicts
orc-handler should come back (right now ps-init-entrypoint.sh fails because we still try to install it even tough we removed from Dockerfile)
bootstrap fails on async replication

first pod goes into CrashLoopBackOff with the following error:
2023/08/04 07:32:54 Peers: [3237353861636563.cluster2-mysql-unready.ps]
2023/08/04 07:32:54 FQDN: cluster2-mysql-0.cluster2-mysql.ps
2023/08/04 07:32:54 Primary: cluster2-mysql-0.cluster2-mysql.ps Replicas: []
2023/08/04 07:32:54 lookup cluster2-mysql-0 [<IP_ADDRESS>]
2023/08/04 07:32:54 PodIP: <IP_ADDRESS>
2023/08/04 07:32:54 bootstrap finished in 0.039863 seconds
2023/08/04 07:32:54 bootstrap failed: get primary IP: lookup cluster2-mysql-0.cluster2-mysql.ps: lookup cluster2-mysql-0.cluster2-mysql.ps on <IP_ADDRESS>:53: no such host
2023/08/04 07:33:14 Peers: [3237353861636563.cluster2-mysql-unready.ps]
2023/08/04 07:33:14 FQDN: cluster2-mysql-0.cluster2-mysql.ps
2023/08/04 07:33:14 Primary: cluster2-mysql-0.cluster2-mysql.ps Replicas: []
2023/08/04 07:33:14 lookup cluster2-mysql-0 [<IP_ADDRESS>]
2023/08/04 07:33:14 PodIP: <IP_ADDRESS>
2023/08/04 07:33:14 bootstrap finished in 0.071393 seconds
2023/08/04 07:33:14 bootstrap failed: get primary IP: lookup cluster2-mysql-0.cluster2-mysql.ps: lookup cluster2-mysql-0.cluster2-mysql.ps on <IP_ADDRESS>:53: no such host

P.S.: During bootstrap pod is not ready, therefore cluster2-mysql-0.cluster2-mysql.ps is not resolvable.

Test name
Status

async-ignore-annotations
passed

auto-config
failure

config
passed

config-router
passed

demand-backup
failure

gr-bootstrap
passed

gr-demand-backup
passed

gr-haproxy
failure

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

gr-self-healing-chaos
failure

haproxy
failure

init-deploy
failure

limits
passed

monitoring
passed

one-pod
failure

scaling
failure

service-per-pod
failure

sidecars
passed

tls-cert-manager
passed

users
failure

version-service
passed

self-healing-chaos
failure

We run 26 out of 26

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/1d1f7b9a03d03343fd08696c528dbbbeb6716ad4
image: perconalab/percona-server-mysql-operator:PR-339-1d1f7b9

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-bootstrap
passed

gr-demand-backup
passed

gr-haproxy
failure

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

gr-self-healing-chaos
failure

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

self-healing-chaos
passed

We run 26 out of 26

commit: https://github.com/percona/percona-server-mysql-operator/pull/339/commits/3a8483b129049b498436f1f62b677ca8a4ecbf8e
image: perconalab/percona-server-mysql-operator:PR-339-3a8483b


Preserve placeholder on initial focus. Make opposite behavior a config option

I just started using this add-on in a project (and great job, btw!), and I noticed that when using placeholders, the placeholder will be removed from the ::before pseudo element’s content as soon as the element gains focus. This is contrary to the native behavior for placeholders in input elements (which I made a quick demo for here), which only clears the field when the user begins typing.
With that in mind, I’d like to suggest keeping ember-content-editable consistent with standard placeholder behavior by default -- but then also providing a configuration option for the opposite behavior.
The former change is just a minor tweak to addon.css that accounts for [contenteditable=true]:focus:empty:before when applying the placeholder. The latter change would just be a classNameBinding on the config option with a corresponding CSS rule of its own:
    .ember-content-editable.clear-on-focus[contenteditable=true]:empty:focus:before {
      content: '';
    }

If these are acceptable changes, there’s one other addition I’d like to include here.
Along the way of adding tests, I discovered that PhantomJS doesn’t play too nicely with the :focused state of DOM elements (there’s actually an open bug here), Particularly, it doesn’t respond to the event being triggered on an in-memory Node.
This made headless tests for the ::before content of a focused element altogether impossible -- and it lead to the test for toggling focus when clearPlaceholderOnFocus was true passing in Chrome but failing in Phantom. (Side note: For what it’s worth, I can also confirm success with the behavior of toggling clearPlaceholderOnFocus in a project that's using my local branch).
With ember-content-editable’s primary concern being so DOM-centric, I think it would be a great improvement going forward to set up Travis to run tests in Chrome. I the made changes to travis.yml necessary for doing so — and currently, we’re all green.

Great, thanks for the detailed PR 😄. I agree with everything - updated on npm now.


[Fix] Docker Build fails almalinux:9.3

fixes: #1048

@aryan-rajoria looks like we need another PR to resolve a similar issue in deno and bun image as well. Could you take a look?


chore: remove some choices from create-fuels CLI

Summary
This PR removes two choices from the create-fuels CLI which we now deem unnecessary.
1. Package Manager
The CLI will just use npm as the default from now on. I tried to add some logic that would detect the package manager used by the user to call the command but have not find a reliable solution yet. I will try to file a follow-up for this.
Users can still explicitly specify if they want to use a specific package manager by flags like --bun, --pnpm
2. Programs to include
From now on we will just give our users all three programs included in the template, instead of giving them a choice when the CLI is run. If they want only one or two, they can easily delete the rest themselves.

Is there an issue we can link this PR to?

@arboleya I don't think there is one. This just started off as a quick draft at the offsite without an issue. I will create one.

@arboleya #2508

@Dhaiwat10 As @petertonysmith94 said here, I think these are the original issues:

#2459
#2460

Maybe you can close https://github.com/FuelLabs/fuels-ts/issues/2508 in favor of these or vice versa.
Or close them all with the PR.