Microsoft.DataProtection swagger changes

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.  - March 2021
When you expect to publish swagger? Please provide date, or month to public if date is not available yet. March 2021
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

We are not changing the API version as we are just addressing swagger for some new features and no clients/customers currently use this API version. So it is not a breaking change.

}

You don't really need to define the status check api for async operation. But here the response schema should follow RPC guideline. https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/Addendum.md#operation-resource-format
I know this will be a breaking change. Just fyi for consideration for new api-version.

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/preview/2021-02-01-preview/examples/GetOperationResult.json:20 in 9b9b6bc. [](commit_id = 9b9b6bc76513745d2d90683a44d3a30d667b735c, deletion_comment = False)

GetOperationResult

This is the response for Location header. For the response if azure-async header(GetOperationStatus) already follows the OperationResource format.
Link to repose of azure-async: https://github.com/zakinkh/azure-rest-api-specs/blob/master/specification/dataprotection/resource-manager/Microsoft.DataProtection/preview/2021-02-01-preview/examples/GetOperationStatus.json

Justification for not updating the version : we are not adding a new version since the current version is not being used by customers, we are stabilizing the current version for PowerShell testing for GA.

Hi @zakinkh, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

@zakinkh , please follow above Action for the breaking change review.

There are no SDK, PS, CLI generated for this api-version and also no customer is using this api-version. This is internal and only used for stabilizing swagger for GA.


Is there any way to show the x and y string values in the chart

I just want to show the values of x and y like [Mon - Fri] , [1000 - 8000] likewise. Is there any way display it in the chart

+1

You can done with your own UIView/UILabel and place/assign text to it.
I think it's out of scope.


High level design for write support

proposed data flow: https://www.lucidchart.com/invitations/accept/264350eb-27f2-43c9-bf50-2ef7f33e44df

i'm actually not sure if this needs to go through store. I initially though this as just a thing which maintains your writes, and works w/ the same database (source of truth) that Store uses. There might be options for better integrations though but i don't think they need to be coupled.
Part of having support for single source of truth in store is making Store compatible with anything else that has such support.
A key requirement to make this consistent is the ability to change modification log in the same transaction as the source of truth. Otherwise, it is not feasible to be resilient w/o adding payload to the mutable objects (or to the source of truth).
I can try to push the code i had about local modification log thing to provide more background on the thinking. (which was the basis for the offline first design doc)

I personally would vote for adding update support to Store. It feels like a missing core usecase of a repository pattern. Given how disjoined the read support and the write support are I can also see us doing it in a separate class/library though.
Maybe you can take me through the history of why you decided to move from exposing SourceOfTruth to exposing 3 individual functions.
If we have users provide one impl of source of truth rather than individual function it would be easy to extend that interface to have user provide transactional update support for writes.

My vote is for it to be part of main artifact but we to not be a part of RealStore, instead builder can return a RealUpdatingStore which can wrap a RealStore.  As for the SourceOfTruth as  single or multiple functions @yigit might remember, I don't feel strongly one way or another on that one.  Historically Store use to have interfaces like RecordProvider or Clearable that user can add to a Persister to make a ClearingPersister or RecordPersister.  I found that to be a flexible api allowing RealStore to operate differently based on the type of persister.

yea there is no real reason for it to be 3 methods instead of SOurceOfTruth, it is just some API decision left TBD.
Coupling with store might be nice for trivial use cases but it won't cover all and will be a limiting factor.
If we implement it independently, we can still provide first class support for it, or Store can depend on it but I initially envisioned it as an independent artifact.
One major use case is when the change includes multiple stores. This is also having support for a true SourceOfTruth comes handy.
For example, if it is a messaging app, i might have two store:
Store<Conversation>, Store<Message>.
When User marks a conversation as read, it is possibly a write in multiple tables (stores) that needs to run in a single transaction in the database. As store works well w/ an observable database, this will just work on the store side (for reads). For writes, developer would use the LocalModificationLog in a combined path for all of their local writes (both user writes and data coming from server) so that local modifications can be re-applied.
Sorry this example may not be good (had 8 hrs of meetings today :/) but hopefully it conveys the idea where writes might be modfying multiple entities that are represented as different store instances.

Ok lets assume we're going to support write from a separate entry point (let's call it WriteStore for until we come up with a better name).
There are 2 general options here:

We support local update by recording the modification in a separate table and keep the value table unmodified until the update is confirmed by the server
We support local update by immediately applying the local modification and update the source of truth's value table. We roll back in case of a conflict (which means we still need to record the local modifications so that we can re-apply them on the new base).

option 1 is simpler to implement with one caveat: The (read) Store source of truth now needs to track both the value table and the local modifications table to that it can emit reduce(baseValue, localModificaitonsList) every time a new local modification is committed locally.
I can't quite put my finger on what makes me uncomfortable with option 2 above, aside from the issue that we will have a complex source-of-truth not consistent with the server situation that can probably lead to subtle bugs down the line.

I was thinking of going w/ option 2.
To do offline first, app has to handle conflicts w/ the server. It is normal to make you uncomfortable, it is an uncomfortable situation :)
The problem w/ not writing writes into database is that it makes it impossible to run queries properly.
e.g. if I marked a message as read in a chat app, it needs to be marked as read in the database so that a query like select count(*) from messages where read=  1 can work properly.
For the API design, in my opinion, it is better to design local modifications as custom objects rather than the whole class.
For instance, this is some code from my app where i was playing w/ this pattern:
db.withTransaction {
            modificationRegistry.enqueueUpdateTask(
                taskId, UpdateTaskArgs(
                    title = title,
                    tags = tags.map { it.id },
                    localId = localTaskId
                )
            )
            db.taskDao().updateTitleAndTags(taskId, title, tags)
        }
        enqueueWorker()

In a transaction, it both saves enough information about the change and also modifies the database. Same modification is run over any incoming data from network as well so that if any local modification has not arrived to the server yet, it gets re-applied before it is saved to database. This ensures having locally latest data always in database.

OK I think that could work. We'll maintained to concept of baseValue which could be updated locally and also the local modification log. in case of conflict we will fetch the new baseValue from the server, attempt to reapply the updates and do everything else the same.
Updating the original table means we have no side-effects between reads and writes so we can create a completely separate entry point for write


chore: directory cleanup

Changelog
Summary
Some general cleanup following our UI Dev discussion meeting about consistent package structure. There will be separate PRs for things related to distributed files and NPM publishing.
Added

yarn.lock file

Updated

renamed guides directory to docs. No changes to actual documentation
moved examples directory to the package root for better visibility. No changes were made to the actual files
update any references to the docs or examples to use the latest paths
update to reference yarn instead of npm
contributing documentation to remove a couple inaccurate statements
renamed test-helpers directory to env

Removed

package-lock.json

Code review

[x] The code must be reviewed by at least one Maintainer

Code quality
Manual testing to be completed by reviewers

[ ] Documentation is understandable

Compliance requirements

[x] The pull request must have a link to GitHub issue

Related to https://github.ibm.com/Watson-Health/design-library/issues/5743
Definition of done

The code has been reviewed by the Maintainer
The code has passed quality checks

85% code coverage
Passed the following tests:

Unit

Documents are updated

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Push notification crash on Android 12

There is a new bug in the latest version of Countly SDK for Android and it crashes just on Android 12.
Stacktrace:
java.lang.RuntimeException: Unable to start receiver ly.count.android.sdk.messaging.CountlyPush$NotificationBroadcastReceiver: java.lang.SecurityException: Permission Denial: android.intent.action.CLOSE_SYSTEM_DIALOGS broadcast from com.samanpr.blu (pid=_, uid=__) requires android.permission.BROADCAST_CLOSE_SYSTEM_DIALOGS.
API Changes:
https://developer.android.com/about/versions/12/behavior-changes-all?hl=fr#close-system-dialogs

Hello, this issue should be fixed in this release:
https://github.com/Countly/countly-sdk-android/releases/tag/20.11.12


EC-802 Include SHA/Image Digest in report output

This commit adds functionality to display the SHA/Image digest in the report output. Speicifically it ensures that for git and oci sources, the identifying SHA/Image Digests are determined and provided in the report output, allowing for auditing and reproducibility.

There are four files at the core of this PR:
cmd/validate/image.go
internal/cache/cache.go
internal/policy/source/source.go
internal/validate/helpers.go

The remainder of the churn in this PR is due to updating tests and snap files as we now return the pinned SHA / image digest in the output.

Added touch-ups addressing all comments. Thank you for the reviews.


[Feedback v0.13.0]

Closed due to empty issue, please feel free to reopen if you have additional questions.


Bug: DeserializeError kyc_verified

Affected Portal:
Devhub
Description:
I found that while running the script bring-cache-up-to-date.py that I pushed in PR 4 to fix issue 990.
I found this error in the live logs of fly.io:
 Failed to get proposal on block: DeserializeError(Error("missing field `kyc_verified`", line: 0, column: 0)), block_id: 122927408

Reproduction Steps

Set the block height via https://devhub-cache-api-rs.fly.dev/proposals/info/122927407
Monitor the fly dashboard https://fly.io/apps/devhub-cache-api-rs/monitoring
Get https://devhub-cache-api-rs.fly.dev/proposals/
View the live logs

Expected behavior
I expect the transactions to be processed without any deserialisation error.
Priority
Select One: Critical (P0)
** Additional Context **
This bug causes the proposal overview of devhub to show a total that is too low https://dev.near.org/devhub.near/widget/app?page=proposals right now it should say 262 but it says there are 250 in total. So we know it happens at 12 different proposals.

After the standup we decided to skip these old snapshots. There are only a few historical snapshots which cause an deserialization error and is not relevant to indexing new once right now.


bug: Add logic to handle and send 404 for unregistered routes and send pro…

…per error codes from server to client

What's the progress here, @chiraglulla ?


js - python - js calls

Seems that if I click a button in html which calls Python, and then that Python code happens to call back into javascript in order to e.g. get the state of the DOM, then the latter Python call to Javascript must be asynchronous, otherwise it didn't work reliably for me.  In fact attempting such a scenario caused the communication between python/javascript to becomes slow and unresponsive for all communication.
Unless there is Python code running in a thread or at the module level during Python startup, it may be that the above scenario is the typical way Python would call Javascript? And if synchronous calls from Python are attempted and clog/confuse the socket communication, then perhaps synchronous calls from Python to Javascript should not be encouraged or allowed in such cases?
html
        <button id="scan_dom" class="btn util_button">scan dom</button>
javascript:
        $('#scan_dom').on('click', function () { scan_dom() })
        async function scan_dom() {
          let n = await eel.py_scan_dom()();
          console.log('Got this from Python: ' + n);
        }
        eel.expose(js_dom_info);
        function js_dom_info() {
            let btn_ids = []
            $('button').each(function(idx, btn) {
                btn_ids.push(btn.id)
            });
            return btn_ids
        }

synchronous python which clogged the socket
@eel.expose
def py_scan_dom():
    # call a javascript function synchronously
    n = eel.js_dom_info()()  # This immeadiately returns the value
    print('Got this from Javascript:', n)

return list(range(10,100,5))

async python which worked ok
@eel.expose
def py_scan_dom():
    def got_dom_info(n):
        print('Got this from Javascript:', n)

    # call a javascript function synchronously
    n = eel.js_dom_info()(got_dom_info)

    return list(range(10,100,5))

Apologies if I have misunderstood something.

@abulka you wrote it correctly from what I can see, the could be some subtle locking issue I have overlooked.
I am on holiday at the moment so might not be able to look at this for a few days.


Add example of editable package with custom src folder layout

Please consider adding a more complicated example,
where the user can use cmake_layout() AND add to the layout() function to support editable, where the source is in an unusual layout.
Also, this example demonstrates how to use the consumer to initialise the editable dependency build environment, which is required  when the consumer may apply a complex set of options to the dependency.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


class_info$cgenes_list clarification

Hi,
Thank you for such a great package! I had a quick question about class_info$cgenes_list. Are these the top positively expressed genes? Or are they the top most variable (both positive and negatively expressed genes)?
Hope this makes sense.
Thank you!

They are the top differentially expressed genes.


How to get prediction without normalized?

I get prediction result, but it is normalized. it is not intuitive and difficult to show on diagram.
Could you please tell me how to get un-normalized results?  thanks for your attention

Hello, you can try out the inverse_transformer of the dataset.
related issue: https://github.com/thuml/iTransformer/issues/40


Validate granularity on diff even when values are equal

Issue #384
This fixes the granularity validity not being checked when applying diff on equal values.
This makes the behavior consistent. Currently diff only fails with an invalid value when comparing times:
iex(1)> Timex.diff(~N[2012-12-12 12:00:00], ~N[2012-12-12 12:00:00], :invalid)
0
iex(2)> Timex.diff(~D[2012-12-12], ~D[2012-12-12], :invalid)
0
iex(3)> Timex.diff(~T[12:00:00], ~T[12:00:00], :invalid)
{:error, {:invalid_granularity, :invalid}}

Coverage increased (+0.001%) to 67.988% when pulling 263a1e7dbb95d029d5b1a81077052c8d283f9081 on fsabe:assertive-diff into c86a96af43cb0052249a4899d988aaa4f665982b on bitwalker:master.


[SPARK-42657][CONNECT][FOLLOWUP] Correct the API version in scaladoc

What changes were proposed in this pull request?

SPARK-42657 is for Spark 3.5.0.
Why are the changes needed?

Fix the wrong API version
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Passing GA.

cc @HyukjinKwon

Merged to master.


%md5% truncates to 2 digits

What steps will reproduce the problem?
Downloading images as usual seems to cause the issue.
What is the expected behavior? What do you get instead?
My name scheme is %md5%.%ext%
I should be getting the full md5 hash with the original image extension appended.
Instead it returns the first 2 characters of the hash, appends the extension, and saves that.
E.g.:
[01:42:44.733] Image received from http://img.rule34.xxx/images/1989/7afd2f926ef40f964975d2089f841b1e.png
[01:42:45.538] Saving image in M:\bryan\Pictures\cake\7a.png
The image then appears in my folder named as such.
It is occasionally also truncated to a single character.
What version of the program are you using? On what operating system?
Just updated to 4.8.3, on Windows 10.
Please provide any additional information below

This has the secondary effect of preventing some new images from loading:

Just figured you'd want to know they were interacting this way.

Problem still exists as of 4.9.1

Can't reproduce in any way.
Did you change the "limit" setting in some way? Does it also happen with the default settings?

I don't know what was wrong, but this doesn't happen anymore!

Well that's a good thing. Strange, though.
Feel free to re-open if it starts again.


Create OpenXR Texture Copy and Create Render Target

These two functions created by Patrick Down are currently needed for the TiltFive plugin to work.
texture_copy will hopefully soon be obsolete and will be removed from this PR once an upstream change in the TiltFive SDK becomes available.
texture_create_render_texture I need to evaluate further. This currently is possible in Vulkan through our RenderingDevice but not possible in OpenGL. The solution will likely need to change to only effect the OpenGL implementation. It is important for XR interfaces to be able to create alternative render textures.

Superseded by #77224 and new TiltFive SDK


SA1600 (Elements must be documented) throws InvalidCastException

I get the following exception, though I can't see what code is causing this. It has me scratching my head, since I can't work out how the parent of a method declaration could be a compilation unit.
Analyzer 'StyleCop.Analyzers.DocumentationRules.SA1600ElementsMustBeDocumented' threw the following exception:
'System.InvalidCastException: Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Syntax.CompilationUnitSyntax' to type 'Microsoft.CodeAnalysis.CSharp.Syntax.BaseTypeDeclarationSyntax'.
   at StyleCop.Analyzers.Helpers.AccessLevelHelper.GetEffectiveAccessibility(BaseMethodDeclarationSyntax syntax, SemanticModel semanticModel, CancellationToken cancellationToken)
   at StyleCop.Analyzers.DocumentationRules.SA1600ElementsMustBeDocumented.Analyzer.HandleMethodDeclaration(SyntaxNodeAnalysisContext context)
   at StyleCop.Analyzers.AnalyzerExtensions.<>c__DisplayClass2_0`1.<RegisterSyntaxNodeActionHonorExclusions>b__0(SyntaxNodeAnalysisContext c)
   at Microsoft.CodeAnalysis.Diagnostics.AnalyzerExecutor.<>c__DisplayClass35_0`1.<ExecuteSyntaxNodeAction>b__1()
   at Microsoft.CodeAnalysis.Diagnostics.AnalyzerExecutor.ExecuteAndCatchIfThrows_NoLock(DiagnosticAnalyzer analyzer, Action analyze)'.

Do you have a method defined outside of a type?

I have 17,000 source files, so I'm not sure!
I didn't think that was ever valid C# syntax. Delegates can be outside of a type, but I wouldn't have thought that they would come through as BaseMethodDeclarationSyntax.
Could the exception have been thrown on incomplete code while I was typing in the editor? I can't reproduce that though.

OK. I managed to reproduce this. A public method placed in the global scope is invalid, but still get analyzed, and so you still see the exception.

Grabbed


lessThanOrEqual not working correctly?

Consider this output:
checking if this value: 15367555 is less than 0
it is less!
For this code:
echo "checking if this value: ".$value->getAmount()." is less than ".Money::EUR(0)->getAmount();

if ($value->lessThanOrEqual(Money::EUR(0))) {
	echo "
 it is less!";
} else {
	echo "
 no its not";
}
die();

Duplicate of #99


Firewall Rule - Gateway cannot be unset

Describe the bug
Because the API does not support empty value for gateway attribute in firewall rule endpoint, it cannot be unset back to "*" (Default)
To Reproduce
Steps to reproduce the behavior:

Create Firewall Rule with assigned gateway
Update the Firewall Rule with empty "gateway" field
See BAD REQUEST error with Unknown firewall rule gateway

Expected behavior
Empty value should set the gateway to the Default - the same as in GUI
Screenshots or Response
{"status":"bad request","code":400,"return":4043,"message":"Unknown firewall rule gateway","data":[]}

pfSense Version & Package Version:

pfSense Version: [e.g. pfSense 2.5.2]
Package Version [e.g. v1.3.3]

Affected Endpoints:

/api/v1/firewall/rule

Additional context
Maybe there is some hidden default value that I dont know or is not documented? :)

Hey!
Looks like you are correct. The gateway lookup that is called during firewall updates does not check for a value to revert to the default gateway; so once it is set it cannot be unset (from the API at least). This should be fairly easy to fix, I'll see if I can put together enough changes to justify a patch containing this fix. If not, I'll roll this into v1.4.0 which should be released pretty soon.
As a workaround in the meantime, you can use the API to delete the firewall rule (without applying changes), re-create the rule without specifying a gateway, and then apply the changes. This should have the same effect as updating the entry, but some of the original data such as the created field and firewall rule position will be lost.
I'll update this issue once I have a pull request containing the fix.
Thanks!

Thanks for response and workaround suggestion! :)


Providing More Variable Configurations

This allows

Footer data
Logo and SVG files and path that can be utilised

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.saranshisatgit seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.saranshisatgit seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I guess the PR was not full called for would there be a possible situation where those values could be dynamically set using ENV VAR?


Question: Does Dota2 use a custom/modified MoltenVK version?

Hi,
grabbed Dota 2 beta with "Vulkan support" package from Steam and inspecting copied the shipped libMoltenVK.dylib to /lib folder pointed by the icd json..
doing a vulkaninfo report I see:
[mvk-info] MoltenVK version 1.0.11. Vulkan version 1.0.75. from what I have:
[mvk-info] MoltenVK version 1.0.12. Vulkan version 1.0.77.
and things a pretty similar exceptuating it seems Valve's MoltenVK adds some format feature flags (or they were removed in 1.0.12 and supported on standard (read non Valve) 1.0.11 builds?
for example for
FORMAT_R8_UNORM:
it adds:
linearTiling   FormatFeatureFlags:
VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT
VK_FORMAT_FEATURE_STORAGE_IMAGE_BIT
VK_FORMAT_FEATURE_STORAGE_IMAGE_ATOMIC_BIT
VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT
VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT
VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT
note there are a lot formats with these added flags (well someones not VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT) : FORMAT_R8_SNORM,FORMAT_R8_UINT,FORMAT_R8_SINT,etc..
maybe Valve MoltenVK perhaps is reporting these flags although not supporting it fully only to avoid code modifications just for MoltenVK..
I know, I know.. may be better to ask directly to Valve devs..
thanks..

@oscarbg
The change that you are referring to...the trimming of supported linear tiling format features...was introduced around the same time that the MoltenVK version number was changed to 1.0.11.
Since this is an open-source project, developers are free to fork it at anytime...make changes and commit back at any time. Sometimes that will affect the order of content both in the developer's fork...and the MoltenVK repo.
In this particular case...it was Valve that updated the version to 1.0.11. One of the drivers that mandates an update to the version number is changes to shader conversion...because MoltenVK uses the MoltenVK version number as one of the factors that determines whether an offloaded pipeline cache is compatible with the current version of MoltenVK. And Valve had triggered such a shader conversion change in that case.
So...I suspect that after Valve had updated the version number to 1.0.11, they did not update their fork to include the near-simultaneous changes to linear tiling features.
@danginsburg If you want to add anything, please do.


Added client_id and cipher DEFAULT:!DH

Closes #9
Turns out my roomba rejects mqtt connections if the client_id isn't set to blid.
Also adds the `"DEFAULT:!DH" ciper from #8

wow


Streaming Delay

I recently tried streaming from a GoPro to my laptop and am disappointed with the video stream delay. Is there anyway to solve this?

Which GoPro do you have? My GoPro 3 had about a 5 second delay when streaming. It's better to use the HDMI port than it is to use the streaming feature of the camera.

I have the Hero4 and am using the commands in the Hero4.md file. I understand that an HDMI connection would be best, but would really like to fine a way to livestream over Wifi.
It is obviously doable since the GoPro iPhone App streams the camera in realtime and without the same delay. I was just curious if anyone had figured out the settings/configuration needed to eliminate the delay.

I am trying to livestream Hero4 on android but not able to do so. Is there any special player required to livestream it on android. Also is there any way to livestream Hero4 on vlc in windows???

@makk909 I understand that the streaming is over UDP protocol, and that Android does not support this? Any updates?

Try using ffplay:
ffplay -fflags nobuffer -f:v mpegts -probesize 8192 udp://:8554
https://www.reddit.com/r/gopro/comments/2md8hm/how_to_livestream_from_a_gopro_hero4/cr1b193

I tried but it's not working, did all this gopro live streaming hdmi - https://goo.gl/OpxjZi

@videopro what camera? HERO4?

@videopro Please paste the output from the command. As Konrad has said, what GoPro platform are you using, and what computer platform are you using (Windows, Mac, Linux)


Generate a package.json file in browser/dist

When using this module as a shared dependency in a webpack federated module project, a package.json file seems to be needed in browser and browser/dist and they both must have a version property.  Without this, the following error results:
Compiled with problems:

WARNING in shared module yaml -> C:\Users\Eric\git\api-designer\ads-ui\node_modules\yaml\browser\index.js

No version specified and unable to automatically determine one. No version in description file (usually package.json). Add version to description file, or manually specify version in shared config.

I've updated the build to generate these two package.json files.

This is odd, and sounds more like a bug in the tool you're using in your build. Would you be able to provide a reproduction of the original issue so this can be diagnosed further?

Sure.  I'll see if I can create as simple a reproducer as possible.

Reproducer here:  https://github.com/EricWittmann/module-federation-with-yaml-issue
The issue appears as only a warning during the build, but is more of a blocker when in dev mode.

This looks like an instance of webpack/webpack#13457 or something very close to it.
The warning is coming from here. This is a Webpack bug as that plugin only looks at the nearest package.json file, rather than the nearest one which does define a "name" and a "version", as it should.
I would recommend that you file a bug (and possibly a PR for a fix?) in Webpack for this.

OK I can try that.  I've seen other projects hit this issue and fix it in their own projects. But if it's a webpack bug it certainly makes more sense to attack it at the root.  I'll see what I can do.

This comment in webpack suggests a workaround (and that they may not be open to a resolution fix):
https://github.com/webpack/webpack/issues/13457#issuecomment-1017970025
I think I'll add a comment there with a reference to this PR (and reproducer) for context.  We'll also try the workaround when we have a chance...

name and version are required fields in package.json.

Closing, as this needs to be fixed in Webpack: webpack/webpack#13457.


Option to change the html tag generated

Discussed in https://github.com/justintaddei/v-wave/discussions/280

Originally posted by kleine-b-avt March 14, 2022
It would be nice to have this option, in cases when we have to use last-of-type css selectors.

@kleine-b-avt thoughts?
Purposed API:
<button v-wave="{
  containerElementTag: 'span'
}">
Click me!
</button>

Result:
<button v-wave="{
  containerElementTag: 'span'
}">
Click me!

</button>

Please let me know if you have any ideas to improve this!

It could be that. or it could be that the span is the wave element itself. Either way, both works for the purpose intended.

@kleine-b-avt the container is already part of the current implementation. It's used to apply overflow: hidden  in a manner that doesn't change the appearance of the host element.

Oh, ok. Got it. Your initial solution is perfect.
Thanks for the prompts responses.


Added teardown_module to uninstall/janitor frameworks after tests run

Removed unneeded imports
Deleted duplicate setup_module method in prototype framework

Is the data deleted by gc_frameworks() supposed to go away on its own (eg by some sort of garbage collection by mesos) in a real-world environment?

May have found the answer, under 'sandbox lifecycle': http://mesos.apache.org/documentation/latest/sandbox/

yes, in the real world it would go away at a rate determined by this formula: http://mesos.apache.org/documentation/latest/configuration/#gc_disk_headroom http://mesos.apache.org/documentation/latest/configuration/#gc_disk_headroom
related: https://jira.mesosphere.com/browse/CORE-874 https://jira.mesosphere.com/browse/CORE-874

On Mar 20, 2017, at 11:38 AM, Nicholas Parker<EMAIL_ADDRESS>wrote:
May have found the answer, under 'sandbox lifecycle': http://mesos.apache.org/documentation/latest/sandbox/ http://mesos.apache.org/documentation/latest/sandbox/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/mesosphere/dcos-commons/pull/599#issuecomment-287857430, or mute the thread https://github.com/notifications/unsubscribe-auth/AACnWOIKxyxw4dAGr7v31MirLp6BWsLNks5rnsfCgaJpZM4MKZ_z.


[Feature Request] Sorting contribution stats

Is your feature request related to a problem? Please describe.
When a repo has a load of contributors, it becomes unweidly to view the generated contribution stats
It currently appears to be unsorted?
Describe the solution you'd like
A CLI option to sllow for sorting based on field. ie. Name Descending or lines changed ascending ...etc
Describe alternatives you've considered
Unsure?

Also a graph will be nice there!


WIP: modified docs to adhere to schema_3rd PR

For Jira #2557.
See related GitHub issues:

fixes  #250
fixes #311
fixes #314

Didnt meant to approve this for now, was confused between this and the 2nd PR which i meant to approve 😄

LGTM language-wise

@elsony, thanks! I think we can merge this PR, because the adding kubernetes component to a devfile will be merged in PR #43, so they'll both be merged in separate PRs as you stated.


Adds padding and adjust table headings

Ticket Link
Ticket
Test Checklist

[x] Unit Tests Passed:
[x] Jasmine Tests Passed:
[x] General Visual Inspection:

A previous PR also triggered a Codacy complaint that the indentation should be 4 spaces rather than 2 and for that PR we agreed to placate Codacy.  Not sure why the main branch didn't already have the new spacing though.

You can press cmd+option+L in mainv2_3.css to reformat to 4 spaces.

You can press cmd+option+L in mainv2_3.css to reformat to 4 spaces.

When I do that, it says the code is already formatted correctly, and git status says nothing's changed.

You can press cmd+option+L in mainv2_3.css to reformat to 4 spaces.

When I do that, it says the code is already formatted correctly, and git status says nothing's changed.

I'm currently using the default code style in Intellij and it seems to reformat properly.

I'm currently using the default code style in Intellij and it seems to reformat properly.

I think I'm using the Project code style. My code is already indented with 4 spaces though, so I'm not sure why the Codacy test is failing.

I don't think our project code style XML includes CSS formatting specifications, so it probably runs the default IntelliJ settings.

Perhaps check the CSS code style in your settings. Here is what mine looks like.

Perhaps check the CSS code style in your settings. Here is what mine looks like.

Mine looks the same.

Okay, I found the issue! I was editing the wrong files. Thank you everyone for your help!


Improve Docker Hub READMEs

The docs we expose on Docker Hub for pulumi/actions and pulumi/pulumi are just duplications of the pulumi/pulumi README. Instead, we should present container-specific usage documentation (and appropriate links to related Pulumi resources) for each of these.

I believe this is https://github.com/pulumi/pulumi/issues/2432.

Updated docs here: https://hub.docker.com/r/pulumi/pulumi

These are good now.


Bug: one-space-between-tags rule fails when paired with indentation rule

Steps to reproduce:

Turn all rules off except indentation and one-space-between-tags
Execute npm run demo

The results incorrectly identify many features with correct tag spacing.  Among them, the feature designed to NOT have violations:
gherkin-lint/test/rules/one-space-between-tags/NoViolations.feature
  1     There is more than one space between the tags @featuretag1 and @featuretag2            one-space-between-tags
  8     There is more than one space between the tags @scenariotag1 and @scenariotag2          one-space-between-tags
  9     There is more than one space between the tags @scenariotag3 and @scenariotag4          one-space-between-tags
  13    There is more than one space between the tags @scenariotag5 and @scenariotag6          one-space-between-tags

If you turn indentation off, one-space-between-tags appears to work fine.

The issue was that the indentation rule was actually modifying the position of the tags. The fix in #102 resolves the issue.

@jhedstrom Thanks for checking this out.  I added your change in my project here at work to test it out and was successful.  I'm new to GitHub, what are the next steps to getting this merged?  Just wait for the project owner?

@ajthesnare I merged @jhedstrom 's change and it's released with version 2.9.1.

@vsiakka thanks!  I got it up and running.


Windows version has no upgrade, build or settings buttons

I downloaded the app on java se 17 and everything works fine, the app opens perfectly, but there are not buttons along the top to use the tool. pls help

nvm i clicked about for a minute and they are all along dropdown menus along the top.


invalid Microsoft.NETCore.App after upgrade to SDK 2.1.401

After upgrading MS to 15.8.2 with SDK 2.1.401 today my web app (netcoreapp21) failed to build with

Severity	Code	Description	Project	File	Line	Suppression State
Error		NETSDK1061: The project was restored using Microsoft.NETCore.App version 2.1.2, but with current settings, version 2.1.3-servicing-26724-03 would be used instead. To resolve this issue, make sure the same settings are used for restore and for subsequent operations such as build or publish. Typically this issue can occur if the RuntimeIdentifier property is set during build or publish but not during restore. For more information, see https://aka.ms/dotnet-runtime-patch-selection.	…

adding a global.json pinning the SDK to 2.1.400 allows the project to compile.
It appears something in the new SDK is referencing Microsoft.NETCore.App version 2.1.3-servicing-26724-03 from a MyGet feed

@natemcmaster @JunTaoLuo

@matthewDDennis - what feeds do you have in your NuGet.config?

Same issue here. No additional nuget feeds.

Hmm where was this .NET Core SDK installed from? An official release, or a nightly build?

On dev machine, VS update. On target machine official release (hosting bundle)

--info

C:\Projects\Tedd>dotnet --info
.NET Core SDK (reflecting any global.json):
Version:   2.1.401
Commit:    91b1c13032
Runtime Environment:
OS Name:     Windows
OS Version:  6.1.7601
OS Platform: Windows
RID:         win7-x64
Base Path:   C:\Program Files\dotnet\sdk\2.1.401\
Host (useful for support):
Version: 2.1.3-servicing-26724-03
Commit:  124038c13e
.NET Core SDKs installed:
1.0.0-preview2-003131 [C:\Program Files\dotnet\sdk]
1.1.0 [C:\Program Files\dotnet\sdk]
2.0.0 [C:\Program Files\dotnet\sdk]
2.0.2 [C:\Program Files\dotnet\sdk]
2.0.3 [C:\Program Files\dotnet\sdk]
2.1.2 [C:\Program Files\dotnet\sdk]
2.1.4 [C:\Program Files\dotnet\sdk]
2.1.101 [C:\Program Files\dotnet\sdk]
2.1.102 [C:\Program Files\dotnet\sdk]
2.1.103 [C:\Program Files\dotnet\sdk]
2.1.104 [C:\Program Files\dotnet\sdk]
2.1.200 [C:\Program Files\dotnet\sdk]
2.1.201 [C:\Program Files\dotnet\sdk]
2.1.202 [C:\Program Files\dotnet\sdk]
2.1.300 [C:\Program Files\dotnet\sdk]
2.1.400 [C:\Program Files\dotnet\sdk]
2.1.401 [C:\Program Files\dotnet\sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 1.0.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 1.0.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 1.1.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.0.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.0.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.3-servicing-26724-03 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download
C:\Projects\Tedd>

I'll send an internal email about this. If VS installed a servicing build, something probably went wrong in the CLI to VS handoff.
As a workaround, try going to Windows Settings > Apps and uninstalling "Microsoft .NET Core SDk 2.1.401".

One more thing: before you uninstall, can you share the file version of the installer? This is visible in Windows Settings. For example:

Control panel says 2.1.401

Can't seem to find in Win7 anything else

Just checked a Win10 machine that was also updated this AM and it shows 2.1.401. It's not on the same network so I cannot build/publish that same project to test.

I too have the Microsoft.NETCore.App 2.1.3-servicing-26724-03 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

Thanks for all the details, we are working with @livarcocc to get to the bottom of this.

It appears Visual Studio bundled the wrong build of the CLI. @livarcocc's team is working with the VS team to investigate fixes. I'm going to close this as a duplicate of https://github.com/dotnet/cli/issues/9897.
The recommended workaround is to uninstall 2.1.401, download the correct 2.1.401 installers from https://www.microsoft.com/net/download/dotnet-core/2.1, and install those instead.

This appears to have fixed it, but I had to do a dotnet restore -f at the root directory of the solution before it would compile without errors using SDK 2.1.401

When trying to publish a Web Job to Azure, this error is now a result:
Severity	Code	Description	Project	File	Line	Suppression State
Error	NETSDK1005	Assets file '-----\obj\project.assets.json' doesn't have a target for '.NETStandard,Version=v2.0'. Ensure that restore has run and that you have included 'netstandard2.0' in the TargetFrameworks for your project.	Orsted.BiothermalPower.Repository.Azure	C:\Program Files\dotnet\sdk\2.1.401\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	198

However, a normal Web App publish does not have this error.
Any hints? It is very tiresome with these errors ... and i suspect they are related to the latest VS2017 update that introduced the other error mentioned in this thread.

@gimlichael can you open a separate issue for this? It appears unrelated to the original issue.

I ran into the same issue when I tried to publish then kept seeing it after that. Uninstalling SDK 2.1.401 fixed it for me. I still have 2.1.400 installed.

you need to set the TargetLatestRuntimePatch to false in the project file,and Specified sdk version

Update my Core SDK, it's ok to work.

I don't know what caused the issue, but it might be related to @Mcgrady2009  suggestion. I deleted the publish profile and closed Visual Studio. After opening and creating a new publish profile, it worked again.
I just hope that with our feedback, that the team can and will improve the error messages. At least for me, it did not make any sense .. and only added to frustration.
Otherwise; keep up the good work - and happy coding :-)

Microsoft has released an update for this problem. Installing Visual Studio 2017, 15.8.3 will fix this.