Pusher environment with Spring pipeline

Hi,
I've been trying to experiment with Pusher env using Spring as a pipeline, and had significant trouble getting anything to train. I investigated a bit and found that there seems to be something wrong with Spring-Pusher combination. For example in the training notebook training goes well for Positional and Generalized pipelines, but for Spring it fails. The graphs below are generated using said notebook:

Spring
Positional
Generalized

I tried to find out what the problem may be and after looking at renders it seems to me that in Spring pipeline there is no friction (or it is very small) between the object and the surface.  I also include the video generated with Spring pipeline, that shows this behavior.
https://github.com/google/brax/assets/56890546/a610a239-c97d-4f85-93bd-0cfba70be975

Hi @wladekpal
The pusher model doesn't have contact friction. The object rests on a plane using joint constraints
https://github.com/google/brax/blob/b45760cfa6ba0c3567ae36f988766a8299853c49/brax/envs/assets/pusher.xml#L84-L85
So I'm a bit surprised that the positional pipeline works, but spring doesn't due to "damping" of the velocity.
With that being said, the spring pipeline dampens velocity in the integrator here:
https://github.com/google/brax/blob/b45760cfa6ba0c3567ae36f988766a8299853c49/brax/spring/integrator.py#L48-L49
So maybe you can add vel_damping here  to see if that helps?
https://github.com/google/brax/blob/b45760cfa6ba0c3567ae36f988766a8299853c49/brax/envs/assets/pusher.xml#L16

Alright, thanks for the response. Generalized backend works fine for my purpose, I just wanted to know if that discrapency in backends is expected. Since it is I will close the issue.

The issue should be reopened, as it is a real bug that breaks pusher when the spring backend is used. I encountered exactly the same behaviour as @wladekpal
Adding vel_damping as suggested by @btaba solved the problem, though I had to set its value to -1, despite it being set to either 0 or 1 in the Brax codebase.
Looking at the integrator.py code shows that having vel_damping > 0 leads to anti-damping, as xd_i.vel is multiplied by exp(positive number) > 1. Someone should probably check if vel_damping should indeed be set to 1 (and not -1) in walker2d.xml and hopper.xml
P.S. Hilariously, the hyperparameter optimization procedure that I ran was able to work around the infinite sliding by nudging the object very slightly, so that it would spend the most of the episode next to the goal


Handle twitch.tv links etc.

Right now only the official Twitch App is opened. :/

Seems like the intent-filters are set up correctly. I identified autoVerify as a possible issue.

Twitch set up an Android App Link Handler for tv.twitch.android.app. This, by design, will open the official Twitch app every time one of the twitch domains is used in Chrome for example. Only the user can change this behavior by going to Settings -> Apps -> Twitch -> Standard for -> To supported Links -> Select "Always Ask".

I'm encountering this issue myself, your mentioned Setting does not exist for me (Android 12) so I did the next best thing, disabled handling of all URLs by the official app and enabled them for bttv - this still results in all links being opened by the official app, and if I uninstall the official app, they will just be opened in the browser


add kafka simple consumer buffer and timeout to stream config

When the kafka broker cluster has max message size config bigger than our current hard-coded value of low-level consumer buffer size (512K), pinot kafka consumer could encounter messages from kafka that are bigger than our buffer size. When this happens, kafka low-level consumer will fail silently and returns an empty message result list to low-level message ingester. From pinot users' point of view, pinot kafka low-level consumer stuck at the large message offset. This change aims to allow users to define their kafka ingestor buffer size so it can handle the failure scenarios above.

Codecov Report

Merging #3584 into master will increase coverage by 0.02%.
The diff coverage is 75%.

@@             Coverage Diff              @@
##             master    #3584      +/-   ##
============================================
+ Coverage      70.8%   70.83%   +0.02%
  Complexity        4        4
============================================
  Files          1007     1007
  Lines         46179    46203      +24
  Branches       6193     6197       +4
============================================
+ Hits          32697    32727      +30
+ Misses        11334    11322      -12
- Partials       2148     2154       +6

Impacted Files
Coverage Δ
Complexity Δ

...altime/impl/kafka/KafkaStreamConfigProperties.java
25% <ø> (ø)
0 <0> (ø)
:arrow_down:

...altime/impl/kafka/KafkaPartitionLevelConsumer.java
64.51% <100%> (+1.18%)
0 <0> (ø)
:arrow_down:

...re/realtime/impl/kafka/KafkaConnectionHandler.java
69.51% <100%> (+0.76%)
0 <0> (ø)
:arrow_down:

...realtime/impl/kafka/KafkaLowLevelStreamConfig.java
61.53% <66.66%> (+11.53%)
0 <0> (ø)
:arrow_down:

...in/pinot/core/query/pruner/ValidSegmentPruner.java
57.14% <0%> (-28.58%)
0% <0%> (ø)

.../impl/dictionary/LongOffHeapMutableDictionary.java
81.81% <0%> (-10.91%)
0% <0%> (ø)

...kedin/pinot/core/util/SortedRangeIntersection.java
83.82% <0%> (-7.36%)
0% <0%> (ø)

...troller/helix/core/retention/RetentionManager.java
73.07% <0%> (-3.85%)
0% <0%> (ø)

...der/HighLevelConsumerBasedRoutingTableBuilder.java
90.9% <0%> (-3.04%)
0% <0%> (ø)

...e/operator/dociditerators/MVScanDocIdIterator.java
62.12% <0%> (-1.52%)
0% <0%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 683b22d...2aaa0dc. Read the comment docs.

LGTM

@npawar Thanks for the confirmation. I'm merging the pr.


Delay operation for delaying the operation application

Is your feature request related to a problem? Please describe.
Frequently it is convenient to partially apply all arguments, but delay the application of operation.
There is no Q# syntax for that.
Describe the solution you'd like
Introduce operation Delay and its variants with the following signature:
operation Delay<'T>( op : ('T => Unit), target : 'T, aux : Unit ) : Unit
// Usage
let delayedX = Delay(X,qubit,_); // now delayed X is of type (Unit => Unit)

together with a functional version Delayed with variants with signature:
function Delayed<'T>( op : ('T => Unit), target : 'T) : (Unit => Unit)
// Usage
let delayedX = Delayed(X, qubit);

Describe alternatives you've considered
A potential alternative is to extend Q# to have a special syntax.
Additional context
It is convenient for passing arguments of type Unit => Unit to functions and operations.

Related PR #145


npm cli can't open lint rules file

I was able to run speccy lint, and wanted to try a local custom rules file. When I do this, I get an error that looks like speccy is looking in my profile for the file.
This happens for a file that exists in the current directory as well as an HTTP resource.
Checklist
None of the checklist applied to this scenario.
Detailed Description

installed npm package with npm install -g speccy
ran speccy lint spec.yaml, got a validation rule I don't care about
made a copy of default.json and removed the rule for contact info
ran speccy lint -r custom.json spec.yaml, got the error below.
ran speccy lint -r http://source/raw/rules spec.yaml, got the same error except the file tried was C:\Users\jblazek\AppData\Roaming\npm\node_modules\speccy\rules\http://source/raw/rules.json

note my incoming param didn't have a .json extension but it gets added.

I'm using Windows 10, and tried from powershell and bash with the same result.
Error: ENOENT: no such file or directory, open 'C:\Users\jb\AppData\Roaming\npm\node_modules\speccy\rules\custom.json.json'
    at Object.fs.openSync (fs.js:653:18)
    at Object.fs.readFileSync (fs.js:554:33)
    at deepMergeRules (C:\Users\jb\AppData\Roaming\npm\node_modules\speccy\lib\linter.js:13:22)
    at Object.loadRules (C:\Users\jb\AppData\Roaming\npm\node_modules\speccy\lib\linter.js:38:42)
    at Command.command (C:\Users\jb\AppData\Roaming\npm\node_modules\speccy\lint.js:79:10)
    at Command.listener (C:\Users\jb\AppData\Roaming\npm\node_modules\speccy\node_modules\commander\index.js:315:8)
    at emitTwo (events.js:125:13)
    at Command.emit (events.js:213:7)
    at Command.parseArgs (C:\Users\jb\AppData\Roaming\npm\node_modules\speccy\node_modules\commander\index.js:651:12)
    at Command.parse (C:\Users\jb\AppData\Roaming\npm\node_modules\speccy\node_modules\commander\index.js:474:21)

I just saw in the docs now that there's only support for the built-in rule sets now. Feel free to close this if adding support is already on your roadmap.


Expansion of CONTRIBUTING

Still requires documentation for Translation/Localization efforts and a PR template.

I'll convert to Draft since it's not ready for review yet

Absolutely should be a draft, I have no knowledge of any translation/localization being worked on currently and would love an assist if you know who is doing so (assuming it is being done).
I have a PR template (based on GitHub template) that I typically use, can be seen on #1669. If this is acceptable as a starting point I will include it in documentation for now.

Localization and PR templates were put in backlog. Documentation ready, but a proof-read or grammatical review would be appreciated.


Missing DELETE servers in documentation

I'm submitting a ...

[ ] bug report
[ ] new feature / enhancement request
[ ] improvement request (usability, performance, tech debt, etc.)
[X] other

Traffic Control components affected ...

[ ] CDN in a Box
[X] Documentation
[ ] Grove
[ ] Traffic Control Client
[ ] Traffic Monitor
[ ] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] unknown

Current behavior:

Missing documentation. DELETE endpoint for servers exists but is not documented.
Expected / new behavior:

The DELETE handler of servers endpoint should be documented.
Minimal reproduction of the problem with instructions:

Link to servers endpoint documentation: https://traffic-control-cdn.readthedocs.io/en/latest/api/servers.html
Anything else:

Related: #2726 and #3443

Looks like this route was removed. Documentation is no longer necessary.

... was it though?

I tried making a DELETE request to /servers and  I got a 404 and resource not found


Remove channel suffix from version specification

https://github.com/oae/asdf-flutter/blob/b136e675d57c9c083c92902c259e285c7154d8a8/bin/install#L23
There should only be one channel per version at any one time, hence it seems redundant to append the channel to the version then check that matches with user input. This is also is different from the asdf norm, my preference would simply to limit it to comparing version[1:] with the user input.
This means that installing the latest version would change from inputting "1.12.13+hotfix.5-stable" to simply "1.12.13+hotfix.5".

As I check the versions, There are multiple channels for the same version like this;
    {
      "hash": "27321ebbad34b0a3fafe99fac037102196d655ff",
      "channel": "stable",
      "version": "v1.12.13+hotfix.5",
      "release_date": "2019-12-11T15:48:44.133001Z",
      "archive": "stable/linux/flutter_linux_v1.12.13+hotfix.5-stable.tar.xz",
      "sha256": "d792c92895623da35e1a9ccd8bc2fe84c81dd72c2c54073f56fe70625866d800"
    },
    {
      "hash": "27321ebbad34b0a3fafe99fac037102196d655ff",
      "channel": "beta",
      "version": "v1.12.13+hotfix.5",
      "release_date": "2019-12-11T02:46:38.389095Z",
      "archive": "beta/linux/flutter_linux_v1.12.13+hotfix.5-beta.tar.xz",
      "sha256": "fec59dff786265626d4e340a5d4d0e0774085155f38755983a2a485aa4a3dd50"
    },

I think user should choose which channel they want when installing them.


Update miden-crypto dependency to the latest version

This PR updates miden-crypto crypto dependency to the latest version. Right now this points to the next branch, but once the next version of miden-crypto is released, I'll update this to point to the crates.io version.
The main update is the change in the API of many Merkle structs to use RpoDigest instead of Word.

There are a couple other instances of Rpo256::merge_in_domain with redundant intos in push_smtget test.

Thank you! Fixes!


Create a single record and multiple related records with optional relation to another entity returns inconsistent order

Bug description
With the provided prisma schema the creation order of the related records depends on whether I link an additional related entity or not when performing a "create single record and multiple related records" operation with prisma.
With no optional related entity provided, the creation order reflects the input order passed to the nested create, with an optional related entity provided the creation order somehow is reversed.
How to reproduce
Clone the reproducible github repo and follow the steps in the readme.
https://github.com/yss14/prisma-reproducible-example-nested-writes-optional-relation

Create a .env file and provide a DATABASE_URL environment variable
npm i
npm run prisma:generate
npm run prisma:migrate-deploy
npm start

Expected behavior
The creation order should in both cases be the same. Otherwise it is hard to relate on the creation order, e.g. when writing integration test cases or matching results to the corresponding input data.
Prisma information
Schema
model Group {
    id    Int    @id @default(autoincrement())
    name  String
    slots Slot[]
}

model Slot {
    id         Int       @id @default(autoincrement())
    from       DateTime
    groupId    Int
    group      Group     @relation(fields: [groupId], references: [id])
    capacityId Int?
    capacity   Capacity? @relation(fields: [capacityId], references: [id])
}

model Capacity {
    id    Int    @id @default(autoincrement())
    count Int
    slots Slot[]
}

Code
const newGroupWithoutCapacity = await prisma.group.create({
  data: {
    name: "Group without capacity",
    slots: {
      create: [
        { from: new Date("2022-07-22T00:00:00.000Z") },
        { from: new Date("2022-07-23T00:00:00.000Z") },
        { from: new Date("2022-07-24T00:00:00.000Z") },
      ],
    },
  },
  include: {
    slots: true,
  },
});

console.log(JSON.stringify({ newGroupWithoutCapacity }, null, 2));

/*
    Creation order matches the input order

    {
    "newGroupWithoutCapacity": {
        "id": 9,
        "name": "Group without capacity",
        "slots": [
        {
            "id": 25,
            "from": "2022-07-22T00:00:00.000Z",
            "groupId": 9,
            "capacityId": null
        },
        {
            "id": 26,
            "from": "2022-07-23T00:00:00.000Z",
            "groupId": 9,
            "capacityId": null
        },
        {
            "id": 27,
            "from": "2022-07-24T00:00:00.000Z",
            "groupId": 9,
            "capacityId": null
        }
        ]
    }
    }
*/

const newGroupWithCapacity = await prisma.group.create({
  data: {
    name: "Group with capacity",
    slots: {
      create: [
        {
          from: new Date("2022-07-22T00:00:00.000Z"),
          capacity: { create: { count: 10 } },
        },
        {
          from: new Date("2022-07-23T00:00:00.000Z"),
          capacity: { create: { count: 10 } },
        },
        {
          from: new Date("2022-07-24T00:00:00.000Z"),
          capacity: { create: { count: 10 } },
        },
      ],
    },
  },
  include: {
    slots: true,
  },
});

console.log(JSON.stringify({ newGroupWithCapacity }, null, 2));

/*
    Creation order is reversed input order

    {
      "newGroupWithCapacity": {
        "id": 10,
        "name": "Group with capacity",
        "slots": [
          {
            "id": 28,
            "from": "2022-07-24T00:00:00.000Z",
            "groupId": 10,
            "capacityId": 13
          },
          {
            "id": 29,
            "from": "2022-07-23T00:00:00.000Z",
            "groupId": 10,
            "capacityId": 14
          },
          {
            "id": 30,
            "from": "2022-07-22T00:00:00.000Z",
            "groupId": 10,
            "capacityId": 15
          }
        ]
      }
    }
  */

Environment & setup

OS: macOS 11.5.2
Database: PostgreSQL 14.2 on aarch64-apple-darwin20.6.0, compiled by Apple clang version 13.0.0 (clang-13<IP_ADDRESS>), 64-bit
Node.js version: v18.0.0

Prisma Version
prisma                  : 4.1.0
@prisma/client          : 4.1.0
Current platform        : darwin-arm64
Query Engine (Node-API) : libquery-engine 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at node_modules/@prisma/engines/migration-engine-darwin-arm64)
Introspection Engine    : introspection-core 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at node_modules/@prisma/engines/introspection-engine-darwin-arm64)
Format Binary           : prisma-fmt 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at node_modules/@prisma/engines/prisma-fmt-darwin-arm64)
Default Engines Hash    : 8d8414deb360336e4698a65aa45a1fbaf1ce13d8
Studio                  : 0.467.0
Preview Features        : interactiveTransactions

Related https://github.com/prisma/prisma/discussions/14351

Yep, it's still happening with 4.3.1.
Here's additionally the debug logs for the dev who picks this up:
  prisma:client  Prisma Client call: +5ms
  prisma:client  prisma.group.create({
  data: {
    name: 'Group without capacity',
    slots: {
      create: [
        {
          from: new Date('2022-07-22T00:00:00.000Z')
        },
        {
          from: new Date('2022-07-23T00:00:00.000Z')
        },
        {
          from: new Date('2022-07-24T00:00:00.000Z')
        }
      ]
    }
  },
  include: {
    slots: true
  }
}) +1ms
  prisma:client  Generated request: +0ms
  prisma:client  mutation {
  createOneGroup(data: {
    name: "Group without capacity"
    slots: {
      create: [
        {
          from: "2022-07-22T00:00:00.000Z"
        },
        {
          from: "2022-07-23T00:00:00.000Z"
        },
        {
          from: "2022-07-24T00:00:00.000Z"
        }
      ]
    }
  }) {
    id
    name
    slots {
      id
      from
      groupId
      capacityId
    }
  }
}
 +0ms
  prisma:client:libraryEngine  sending request, this.libraryStarted: true +6ms
prisma:query BEGIN
prisma:query INSERT INTO "public"."Group" ("name") VALUES ($1) RETURNING "public"."Group"."id" /* traceparent=00-00-00-00 */
prisma:query INSERT INTO "public"."Slot" ("from","groupId") VALUES ($1,$2) RETURNING "public"."Slot"."id" /* traceparent=00-00-00-00 */
prisma:query INSERT INTO "public"."Slot" ("from","groupId") VALUES ($1,$2) RETURNING "public"."Slot"."id" /* traceparent=00-00-00-00 */
prisma:query INSERT INTO "public"."Slot" ("from","groupId") VALUES ($1,$2) RETURNING "public"."Slot"."id" /* traceparent=00-00-00-00 */
prisma:query SELECT "public"."Group"."id", "public"."Group"."name" FROM "public"."Group" WHERE "public"."Group"."id" = $1 LIMIT $2 OFFSET $3 /* traceparent=00-00-00-00 */
prisma:query SELECT "public"."Slot"."id", "public"."Slot"."from", "public"."Slot"."groupId", "public"."Slot"."capacityId" FROM "public"."Slot" WHERE "public"."Slot"."groupId" IN ($1) OFFSET $2
prisma:query COMMIT
  prisma:client  Prisma Client call: +5ms
  prisma:client  prisma.group.create({
  data: {
    name: 'Group with capacity',
    slots: {
      create: [
        {
          from: new Date('2022-07-22T00:00:00.000Z'),
          capacity: {
            create: {
              count: 10
            }
          }
        },
        {
          from: new Date('2022-07-23T00:00:00.000Z'),
          capacity: {
            create: {
              count: 10
            }
          }
        },
        {
          from: new Date('2022-07-24T00:00:00.000Z'),
          capacity: {
            create: {
              count: 10
            }
          }
        }
      ]
    }
  },
  include: {
    slots: true
  }
}) +1ms
  prisma:client  Generated request: +0ms
  prisma:client  mutation {
  createOneGroup(data: {
    name: "Group with capacity"
    slots: {
      create: [
        {
          from: "2022-07-22T00:00:00.000Z"
          capacity: {
            create: {
              count: 10
            }
          }
        },
        {
          from: "2022-07-23T00:00:00.000Z"
          capacity: {
            create: {
              count: 10
            }
          }
        },
        {
          from: "2022-07-24T00:00:00.000Z"
          capacity: {
            create: {
              count: 10
            }
          }
        }
      ]
    }
  }) {
    id
    name
    slots {
      id
      from
      groupId
      capacityId
    }
  }
}
 +0ms
  prisma:client:libraryEngine  sending request, this.libraryStarted: true +6ms
prisma:query BEGIN
prisma:query INSERT INTO "public"."Group" ("name") VALUES ($1) RETURNING "public"."Group"."id" /* traceparent=00-00-00-00 */
prisma:query INSERT INTO "public"."Capacity" ("count") VALUES ($1) RETURNING "public"."Capacity"."id" /* traceparent=00-00-00-00 */
prisma:query INSERT INTO "public"."Slot" ("from","groupId","capacityId") VALUES ($1,$2,$3) RETURNING "public"."Slot"."id" /* traceparent=00-00-00-00 */
prisma:query INSERT INTO "public"."Capacity" ("count") VALUES ($1) RETURNING "public"."Capacity"."id" /* traceparent=00-00-00-00 */
prisma:query INSERT INTO "public"."Slot" ("from","groupId","capacityId") VALUES ($1,$2,$3) RETURNING "public"."Slot"."id" /* traceparent=00-00-00-00 */
prisma:query INSERT INTO "public"."Capacity" ("count") VALUES ($1) RETURNING "public"."Capacity"."id" /* traceparent=00-00-00-00 */
prisma:query INSERT INTO "public"."Slot" ("from","groupId","capacityId") VALUES ($1,$2,$3) RETURNING "public"."Slot"."id" /* traceparent=00-00-00-00 */
prisma:query SELECT "public"."Group"."id", "public"."Group"."name" FROM "public"."Group" WHERE "public"."Group"."id" = $1 LIMIT $2 OFFSET $3 /* traceparent=00-00-00-00 */
prisma:query SELECT "public"."Slot"."id", "public"."Slot"."from", "public"."Slot"."groupId", "public"."Slot"."capacityId" FROM "public"."Slot" WHERE "public"."Slot"."groupId" IN ($1) OFFSET $2
prisma:query COMMIT
  prisma:client:libraryEngine  library stopping +10ms
  prisma:client:libraryEngine  library stopped +0ms
  prisma:client:libraryEngine:exitHooks  exit event received: beforeExit +0ms
  prisma:client:libraryEngine:exitHooks  exit event received: exit +0ms

This is quite complex issue to solve. The analysis is in an internal document, and it's about the graph modification parts where we swap parent and child queries, where we go wrong: https://www.notion.so/prismaio/Spec-Wrong-Related-Item-Insertion-Order-4306d2ae32ba4404a7b5130c2a66bf04

Any progress with this?


Spin button

Describe the PR
Port over SpinButton code and some test cases.
Ill be considering putting docs in a separate mass update.
Feel free to take a look. Will be planning on merging in the coming week.
Small replication
If the change is large enough, a small replication can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix :bug: - fix(...)
[x] Feature - feat(...)
[ ] ARIA accessibility - fix(...)
[ ] Documentation update - docs(...)
[ ] Other (please describe)

The PR fulfills these requirements:

[x] Pull request title and all commits follow the Conventional Commits convention or have an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

I'd prefer the component to be rewritten using <template>'s. I generally write tests first, attempt to get full code coverage, then make the change. In addition, I usually prefer to get rid of the bootstrap-vue utils code. But, if you would like to get it working, I can later on make the tests and rewrite to script setup and template. And, as much as possible remove attempts to call "window" for ssr. I'm aware that this is a draft.

I'd prefer the component to be rewritten using <template>'s. I generally write tests first, attempt to get full code coverage, then make the change. In addition, I usually prefer to get rid of the bootstrap-vue utils code. But, if you would like to get it .......

I am going to complete the tests. You might have to elaborate on the utils part. I am going to move toward providing a functional component. The window stuff will not impact server side rendering as they are event listeners and will not present any effects on hydration and template rendering. Code acts as more of a polyfill which may not need to be necessary.

You might have to elaborate on the utils part

Bootstrapvue has a util called arrayIncludes. Js has a method called Array.includes. why use their function?

You might have to elaborate on the utils part

Bootstrapvue has a util called arrayIncludes. Js has a method called Array.includes. why use their function?

interesting I did not know that.

You might have to elaborate on the utils part

Bootstrapvue has a util called arrayIncludes. Js has a method called Array.includes. why use their function?

interesting I did not know that.

BV also does some other weird stuff, like making a function called mathMin that literally returns Math.min
export const mathMin => Math.min was an actual function for some reason

Yeah I have been moving away from the math utility's. I’ll update and check through ones that are not necessary


add integration tests for various charts supported by juttle-viz

just expand the existing app tests to include the basic set of integration tests that verify each supported chart type does what its suppose to do.

Per team discussion, these tests can be done at lower level in juttle-viz, rather than as end-to-end selenium based tests.


Parameter updating by novel view synthesis

Hi @tinghuiz,
The method _interpolate in file utils.py samples pixels in the source image with tf.gather, given the indices computed from intrinsics matrices and depth. The gradient of tf.gather is not computed w.r.t. the indices, so backpropagation does not reach the tensor of the computed depth (or, similarly, the pose). So,
How does the network update the depth (pose) parameters? Am I missing something in the analysis?
Cheers.

Oh, why do you think the gradients cannot backprop through tf.gather? FYI, I copied the _interpolate method from the official tensorflow repo: https://github.com/tensorflow/models/blob/master/transformer/spatial_transformer.py.

Sorry, now I understand: the gradient is backpropagated to depth and pose through the calculated weights wa, wb, wc, wd, not through the indices idx_a, idx_b, idx_c, idx_d, i.e., through the interpolation. Of course, for each sampled pixel, the net decides "where to move" in the grid only looking at the four neighbouring pixels used in the interpolation, but not beyond those pixels. So:
Am I wrong if I think that the optimization works because the baseline between consecutive frames is small? I mean, if the baseline were greater, the optimization wouldn't work, right?
Cheers!

You are right that the gradients for depth and pose are backproped through the w's, and the gradient can only be derived from the four neighboring pixels used in the interpolation, which is why we use a multi-scale loss and depth smoothness loss in the objective to overcome the gradient locality (see Sec. 3.4 of the paper).

Oh, I didn't take that into account. Thank you very much for the explanation and for sharing your code!
Cheers!


ITMS-91056: Invalid privacy manifest - The PrivacyInfo.xcprivacy file from the following path is invalid: “Frameworks/ZegoExpressEngine.framework/PrivacyInfo.xcprivacy”. Keys and values in any privacy manifest must be in a valid format.

Missing an expected key: 'NSPrivacyCollectedDataTypes' Runner.app/Frameworks/ZegoExpressEngine.framework/PrivacyInfo.xcprivacy

Have you modified the local ZegoExpressEngine library?
Delete the local library downloaded by flutter and try pub get again.

Hi sir ,
can you explain to me a little bit more from which folder I need to delete
this file?
Thanks & Regards
Priya Srivastav
On Wed, 10 Jul 2024 at 08:41, yoer @.***> wrote:

Have you modified the local ZegoExpressEngine library?
Delete the local library downloaded by flutter and try pub get again.
image.png (view on web)
https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/assets/11307627/10789620-6d77-48ca-a432-de1016b9617f
—
Reply to this email directly, view it on GitHub
https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/53#issuecomment-2219458620,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BH3QPUOYQPHT6S6CWPZ4HJ3ZLSQ43AVCNFSM6AAAAABKTHBNAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZGQ2TQNRSGA
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Hi , i did all these steps but the issue still persists.

What is your Flutter version and ZegoExpressEngine version?

Flutter version - 3.10.0
zego_uikit: ^2.14.3
zego_uikit_prebuilt_call: ^3.17.2
zego_uikit_signaling_plugin: ^2.6.2

What is your ZegoExpressEngine version? check in pubspec.lock

ZegoExpressEngine version: "3.12.4"

The version of flutter must be 3.13.0 or above

Is it normal after upgrading the Flutter version?

As you said to upgrade flutter version, i have upgrade the flutter version from 3.10.0 to 3.22.2 , but the issue still persists.

Hi sir ,
Please provide the solution ?

how about upgrade zego_express_engine to 3.15.

how about upgrade zego_express_engine to 3.15.

The zego_express_engine version should be greater than 3.13.2

It’s been too long without reply

The issue was resolved .

what's the approach to solve this @priya1-2

what's the approach to solve this @priya1-2

The zego_express_engine version should be greater than 3.13.2


shortcuts - add new paper note

Hi, this is my first PR and also first for anything Rust related, very new to Rust 😅 also I'm in love with this project feel like I can learn a lot just by contributing to this project.
So for this PR I just kind of copy paste the paper note insertion handler implementation from button_handlers.rs. I don't know where should I create a reusable function for this one, please let me know how I can improve this if you have time. thank you!

Welcome @irfanabliz 👋
Yes, you can learn a lot from the project, unfortunately building UI in bevy is not super ergonomic as for now, so it might be not the easiest project to get started.


Add code coverage

This PR adds code coverage reports to both Mocha and Jest test suites. Coverage appears in the console when running tests locally and in CI. Reports are also uploaded to https://codecov.io/gh/artsy
The codecov library is used only to upload reports, and is run with the script report-coverage. This step is invoked during CI runs and creates a few new env vars for the test run.
To generate reports in Mocha, the nyc library is used in combination with mocha-lcov-reporter. Jest uses its built in coverage. Controls for both are located in package.json. We can add more options there, including minimum coverage for the repo, or other flags that will cause an ❌in CI.

Coverage reports for this PR can be viewed here: https://codecov.io/gh/artsy/force/pull/3930/tree


Which bitcoin address?

adress -> address, btw
Disclaimer: I'm not a user of the product and don't intend to pay any bitcoin at this point, I just noticed that you don't actually specify the address in the README.

Thanks for pointing out !


attribute linked properties reflect state after 2nd mutation in browsers with native shadow DOM ( Chrome,Safari)

When defining component property linked to DOM attribute via {attribute:true}, it doesn't do anything on first mutation via setAttribute.
Looks like this issue is only in browser which have native shadow dom v1 ( chrome, safari 10 )
Chrome:

Safari:

Firefox ( works as expected ):

Example:
https://plnkr.co/edit/UNZYkOQ0EeUrGHeo85Iy?p=preview
maybe this is unrelated but why does skatejs-web-components add deprecated registerElement do document instead of polyfilling just actual v1 spec? "thanks to that" both flags(customElement) are always true

aybe this is unrelated but why does skatejs-web-components add deprecated registerElement do document instead of polyfilling just actual v1 spec? "thanks to that" both flags(customElement) are always true

That's a side-effect of document-register-element that it brings in.

I think this is either an issue with document-register-element not reflecting the change properly, or the internal flags that we keep being out of sync. We keep flags so that recursion doesn't happen when reflection attrs / props. I think we'll probably implement #838 as proposed which will remove the need for the flags and make reflection simpler.

I've switched from document-register-element to custom-elements. Issue still remains.
https://plnkr.co/edit/yF83goIEcZ95dGelKb8z?p=preview
So there are 2 possible reasons why is this happening:

both polyfills have bug
skate has damaged tail or nose, so we can't ollie properly :)

I did further investigation/debugging
Results:
Component.prototype.attributeChangedCallback is called once in Chrome/Safari and twice in Firefox on attribute Mutation.
This resolves in behaviour that in FF, internal __SKATE_DATA for greet property, which has both flags after attaching to DOM set to true( IMO that's the issue ),
{
  settingAttribute: true
  syncingAttribute: true
}

is toggling the  syncingAttribute to false so the second call of attributeChangedCallback will allow it to go to else branch
 if (propData.syncingAttribute) {
          propData.syncingAttribute = false;
        } else {
          // Sync up the property.

and set the property correctly.
After the attrs/props are synced both flags are set to false
{
  settingAttribute: false
  syncingAttribute: false
}

so after that everything works as expected.
So I think to fix this issue, we need to properly resolve the flags after the element is attached to the DOM to false

Do you know if this is still an issue in latest?

Will retry with latest skate+polyfills later on today and will get back to you with results. thanks

unfortunately, issue is still valid
https://plnkr.co/edit/UNZYkOQ0EeUrGHeo85Iy?p=preview

For what it's worth this bug breaks compatibility with Angular 1.x which uses setAttribute when interpolating:
<x-button label="{{app.myLabel}}"></x-button>

When app.myLabel is resolved it calls setAttribute once but due to this bug it does not re-render the component.

Here is the workaround that resolves the issue for me:
import {props, Component} from 'skatejs';

class Button extends Component {
  // ...props
  static attributeChanged(elem, {name, newValue}) {
    props(elem, {[name]: newValue});
  }
 // ... render
}

@camwest workaround === hack IMHO, I really hate hacks :) as previously discussed, issue is in how skate resolves "flaging" toggles for props lifecycle

Definitely, but it's at least a way to get around it. I've been wanting to fix this but am strapped for time ATM. Is one of you able to submit a PR?

This issue is resolved.


[7.x.x] Bump Dependencies #5589429538

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/5589429538

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add option to simulate network conditions like lag and packet loss

Require some variable to simulate network condition for development and testing stable multiplayer algorithm and approach.
It's analog: net_packetextralag && net_packetlossrate from CryEngine, net_fakelag && net_fakeloss from Valve Source, PkgLag && PkgLoss from Unreal

@Calinou
This is not about variable, it is about packet loss patterns simulation. Only makes sense for UDP networks. Can be done using external tools though.
Please change topic, otherwise it is very confusing.

For reduce network latency in gamedev use only UDP (i mean real time game). External tool is not a handy way and besides that set different network condition for each client is a problem. What if i say about some like a random lag (i forgot add it to proposal) ? Do you think it's a simple to find a tool with multiplatform support and open source which is satisfy it ? How about easy to use ? How about add initial network condition for testing (imagine you have a team of 10+ QA and some branch with network depended feature like a server authoritative movement etc.) ? From my point of view exist only one best way and it's primary way in other engine and already proven by time. Thanks.

where I live many ISPs block UDP completely, but many MP games still work
so I guess TCP as also common option. But your request is not about variables,
but about network testing, please make topic clear about this. I work on Linix
and it have extensive network failure si,ulation tools to test apps.
I'm not against
adding some network error injector in Godot, but that will probably will be most
low priority ever. I think you better try to find some external tools
if you have
a problem at hand. Most Godot developers do not have experience in the area,
so I guess that will require outside contribution and you need to convince
developers to put such a feaure in the roadmap. Also I guess this could be
implemented as "gdnative" thing, but somethings tells me it is not possible
this way that easily. Another thing you will need to properly test is packet
reordering and traffic replayers. So I still bet more on external
tools if I were you.
On Thu, May 2, 2019 at 3:40 AM megalike<EMAIL_ADDRESS>wrote:

For reduce network latency in gamedev use only UDP (i mean real time game). External tool is not a handy way and besides that set different network condition for each client is a problem. What if i say about some like a random lag (i forgot add it to proposal) ? Do you think it's a simple to find a tool with multiplatform support and open source which is satisfy it ? How about easy to use ? How about add initial network condition for testing (imagine you have a team of 10+ QA and some branch with network depended feature like a server authoritative movement etc.) ? From my point of view exist only one best way and it's primary way in other engine and already proven by time. Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Real time games (i mean AAA games) using UDP only.
No matter it's TCP or UDP at all, it's about network conditions.
I want to do this feature in the near future by myself, because it's absolutely require as i mention before. And it's not a problem if it's get a low priority. It's should only approve now in community to see it's value.

Yeah anyway, but maybe it can be useful for other.
For me it mean to try do not make a fast but not a better solution if i trap. And i spend more time to find a better solution to solve some problem and stick to guideline.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


drag and drop is not supported on Ubuntu 12

@xfoxawy If you do find the browser and can give more info about how to reproduce, we can take a look.  Please raise a new issue in https://github.com/SheetJS/js-xlsx


Getting issue while installing app at production mode

Hi @kinngh
Recently, I submitted an app to the Shopify app store, and the Shopify support team emailed me, stating that they're encountering an issue while installing the app. Upon investigation, I found that I am facing the same issue. Let me explain:

The first time I installed the app using the URL, it installed successfully and worked perfectly,
like this: https://abc.com/api/auth?shop=xyz.myshopify.com.
After I uninstalled the app.
When I reinstalled the app from the Shopify "Uninstall" tab, I encountered the issue: "admin.shopify.com redirected you too many times."

Please also review the attached video for a better understanding: https://drive.google.com/file/d/1k2Yraebe27FmrN1YWBFfpjajwoqTerwR/view?usp=drive_link

Here's the error log for further investigation.
[shopify-api/ERROR] Could not find OAuth cookie | {shop: dev-upsell2.myshopify.com}  ---> Error at /api/auth/tokens CookieNotFound [Error]: Cannot complete OAuth process. Could not find an OAuth cookie for shop url: dev-upsell2.myshopify.com      at Object.callback (/var/www/dev-upsell/node_modules/@shopify/shopify-api/lib/auth/oauth/oauth.js:99:19)      at runMicrotasks (<anonymous>)      at processTicksAndRejections (node:internal/process/task_queues:96:5)      at async file:///var/www/dev-upsell/server/middleware/auth.js:57:32
Please help me out. I have been using this package for a long time, and I have never faced this issue before. I appreciate your insight.
Thanks

See if either of these gists I wrote a good while ago solve your issue. MAKE SURE YOU SAVE YOUR CHANGES BEFORE RUNNING THE SCRIPTS BECAUSE IT CHANGES A BUNCH OF CORE PACKAGES.

https://gist.github.com/kinngh/995a64372e8d698c38ca4aaef61e2edc
https://gist.github.com/kinngh/ab36102f4c1f2bdd9a56729253af222b

If it doesn't work, lmk, I'll migrate the entire thing over to managed install and write a guide so the older OAuth issues are completely taken care of

Hi @kinngh
Thanks for sharing the patch; it really helps me a lot. The patch is running perfectly. However, I think the code below didn't work. So, I manually changed "lax" to "none," and now it's working fine :)
const domainEntry = "domain: .${config.hostName}`,";
let result;
if (data.includes(domainEntry)) {
// If domain entry already exists, replace it
result = data.replace(new RegExp(domainEntry, "g"), domainEntry);
} else {
// If domain entry doesn't exist, add it
const regex = /(sameSite: 'lax',\n\s+secure: true,)/g;
result = data.replace(regex, $1\n${domainEntry});
}`
Thanks for your support and appreciate your help

Hi @kinngh
I am facing another issue related to cookies. Here's the error message I received from the Shopify support team:
Your embedded app must use session tokens and not rely on 3rd party cookies to function properly. Your embedded app must not use local storage. Your app must function in incognito mode in Chrome.

Additionally, please check the attached video.
https://drive.google.com/file/d/1PdLEs_0UPnyDnI5h9-lR61yc_x5H--BE/view?usp=sharing
I appreciate your insight.
Thanks

Ok what version is your @shopify/shopify-api? Looks like an older version. Also, This could, highly likely, just be the app reviewer being dumb. A lot of these cases happen regularly.

upgrade App Bridge to App Bridge CDN, uninstall app bridge packages and see the repo in it's current state to understand how the new CDN works. I suspect that could be the problem since it's also taking you to *.myshopify.com domain instead of admin.shopify.com/store/*. Also lowkey surprised why you don't have it upgraded already

I tried to upgrade the whole package to a new version and I am using "@shopify/shopify-api": "^10.0.0" along with the App Bridge CDN. However, I am still facing the same issue. Please check the attachment below.
Additionally, for further clarification, I suggest you try setup the latest package on the server end and attempt the installation in an incognito window.

All of my boilerplates are what I use in production - this is not a throw away open source project that I maintain out of kindness, this is what I personally use in production and open sourced it for everyone to use.
That said, 4 days ago I went through app review with no problems using this exact boilerplate, so please double check your project on what's happening - it's either a package or some of your code that's causing the issue because if it was an actual problem with the base boilerplate, I would have multiple people reporting problems with it and I would have a solution for it, like what I had with the auth.
Moreover, the screenshot alone is of absolutely 0 help - I don't have any error logs, server setup, etc. I do not have the time to sit around and debug an issue that cannot be reliably reproduced just for one project.
Closing this issue.

Also, just so I don't hear from you that I didn't pull the latest commit and try it out, here's a screen cast of installing a freshly pulled, freshly created boilerplate app in Safari's Private mode, the absolute worst browser to try it out on.
https://youtu.be/MKrp7GaiW7M

Thanks for you efforts and tried it out. Could you please try it out at the chrome browser and make sure disable the third-party cookies (Private window).
Also, I freshly installed the package at live server.

I did try it out with Chrome, Safari, Firefox and Arc, and it all worked just fine, and only uploaded the Safari one, since if it works on Safari, it works everywhere.

Tracking this in #132 . THAT is how you write a proper error log, and not just post a screenshot with no logging whatsoever.

Fixed in c747c


Remove version: vatis-project.vAtis version 4.0.0-beta.3

It return 404 in GitHub Action
Microsoft Reviewers: Open in CodeFlow

Will be replaced by #200026


Add the Data Classifcation fields

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
In the Object Documentation report it would be great to have the Data Classification fields of

Data Owner
Field Usage
Data Sensitivity level
Compliance Categorization

This way at a glance I can see what fields need my attention to go tag properly
Describe alternatives you've considered
Going in one by one to check or find another 3rd party app
Additional context

i like this idea VERY much !!
So here you want the information on the Object tab in the fields section.
Will it make sense also to have this information on the Custom tab as well??

for information: https://help.salesforce.com/s/articleView?id=sf.data_classification_metadata_fields.htm&type=5

will be available in the next version !! thank you for this idea !!

with values

I will not implement this on the custom tab page as it requires potentially more time to display the page for some orgs.


Dashboard should show Connection Lost notification if connection to server is lost

With D1, if the connection to the node red server is lost then a Connection Lost notification is shown until the connection is regained.
With D2 there is no such indication, and components such as dropdowns appear to continue to function, but are of course not sending information to the server, and the dashboard is not being updated with current information.  This is a serious issue as, for example, a machine operator might not realise that there was a problem.
The Browser Console does show communications errors when the connection is lost.
To replicate, view the dashboard on a machine other than the node-red server.  Disconnect the network from the machine running the browser.

Closed by https://github.com/FlowFuse/node-red-dashboard/pull/790


Updates for paraview compatability with docs

Adds instructions on README
Adds cmocean_all.xml file that allows a user to import all the colorbars at once
Typo fixes

awesome!


update sample link after kfp sample restructure

This change is

/assign @sarahmaddox

Thanks!
/lgtm
/approve


Fix flaky test

What was wrong?
We currently wait for the json-rpc Endpoint to connect
to other endpoints before we do certain assertions.
But sometimes we might end up in a situation where
al other endpoints have already connected to this
endpoint and so it does not actively connect to
others and the test fails.
How was it fixed?
It is safer to simply wait for the announcement of the
JSON-RPC endpoint instead.
To-Do

[x] Clean up commit history

Cute Animal Picture

@carver I think this fixes #1362

Maybe a release note in the internal section? Having less flaky tests is very satisfying to other devs :)

:+1: to ship this.  FYI, I'm very close to being ready to implement component dependencies which will make component startup order more deterministic for things like this and hopefully easier to read about.

Maybe a release note in the internal section? Having less flaky tests is very satisfying to other devs :)

Good point. I keep forgetting we have internal! Added.


[Relay][Pytorch] Add aten::new_ones, aten::new_full, aten::fill_, aten::pad, aten::reshape_as and atem::empty_like

This PR intends to add the following five ops for the pytorch frontend:

aten::new_ones
aten::new_full
aten::fill_
- aten::pad (This op is relocated to #11922 )
aten::reshape_as
aten::empty_like

Note that arguments to the above ops will be changed by relay at runtime so verify_model won't work on them.
cc: @masahi @junrushao1994 @zxybazh

@masahi Tests are added. Should be good to take another look.

@tvm-bot rerun

@masahi It is possible that tests for empty and empty_like are flaky. It failed on CI once but by reading the outputs it shouldn't fail. Just to give a heads-up.

Did they ever fail in your local testing?

@masahi Local testing no.


re-enable null-safety integration tests once framework/test code is migrated

Now the the frontend_server has auto-detection, opting in the entry point will fail since the dependencies are not migrated. Disable these tests for now so we can keep rolling.

This could also be re-enabled once sound-null-safety can be disabled.


[discord-game-sdk] build failure with MSVC

Host Environment

OS: Windows
Compiler: Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30137 for x86

To Reproduce
Steps to reproduce the behavior:
./vcpkg install discord-game-sdk:x64-windows
Failure logs
LNK2038	mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in main.obj discord_game_sdk_cpp.lib(achievement_manager.cpp.obj)	1

LNK2038	mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MDd_DynamicDebug' in main.obj discord_game_sdk_cpp.lib(achievement_manager.cpp.obj)	1

LNK4098	defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library

22 Mismatches detected

Additional context
This problem occurs because the current port does not properly select the correct libs based on the build type.
In debug they show up like this:
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\fluidsynth.lib
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\PocoNetd.lib
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\PocoJSONd.lib
X:\Big_Code\vcpkg\installed\x64-windows\lib\discord_game_sdk.lib
X:\Big_Code\vcpkg\installed\x64-windows\lib\discord_game_sdk_cpp.lib
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\lua.lib

When I manually change the game sdk path to
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\discord_game_sdk.lib
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\discord_game_sdk_cpp.lib

Everything works as expected. The port needs to have the correct cmake configuration rules to detect if needs debug or release linkage.
Note that while this problem is very similar to 26342, my project has dynamic linkages and I am not writing my own triplet to fix this issue. Manually fixing the issue will prevent us from doing CI/CD.

@TheMaverickProgrammer, Thanks for posting this issue, I can install discord-game-sdk:x64-windows successfully on my machine with windows11 vs2022:
PS F:\test\vcpkg> ./vcpkg install discord-game-sdk:x64-windows --editable
Computing installation plan...
The following packages will be built and installed:
    discord-game-sdk[core]:x64-windows -> 2.5.6#4
Restored 0 package(s) from C:\Users\vzhli17\AppData\Local\vcpkg\archives in 152.3 us. Use --debug to see more details.
Installing 1/1 discord-game-sdk:x64-windows...
Building discord-game-sdk[core]:x64-windows...
-- Using cached discord_game_sdk.zip.
-- Extracting source F:/test/vcpkg/downloads/discord_game_sdk.zip
-- Applying patch include-cstdint.patch
-- Using source at F:/test/vcpkg/buildtrees/discord-game-sdk/src/d_game_sdk-19a6f72d70
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/bin/discord_game_sdk.dll
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/debug/bin/discord_game_sdk.dll
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/lib/discord_game_sdk.lib
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/debug/lib/discord_game_sdk.lib
-- Found external ninja('1.11.0').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/share/discord-game-sdk/copyright
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/share/discord-game-sdk/usage
-- Performing post-build validation
Elapsed time to handle discord-game-sdk:x64-windows: 14.11 s
Total install time: 14.14 s
The package discord-game-sdk does not provides CMake integration:

    find_library(GAME_SDK discord_game_sdk)
    target_link_libraries(<my_target> PRIVATE ${GAME_SDK})

    find_path(GAME_SDK_INCLUDE discord-game-sdk/discord.h)
    target_include_directories(<my_target> PRIVATE ${GAME_SDK_INCLUDE})

The C++ SDK source code is compiled in a static library:

    find_library(CPP_GAME_SDK discord_game_sdk_cpp)
    target_link_libraries(<my_target> PRIVATE ${CPP_GAME_SDK})

Did your error occur when installing discord-game-sdk or when using discord-game-sdk?

@TheMaverickProgrammer, Thanks for posting this issue, I can install discord-game-sdk:x64-windows successfully on my machine with windows11 vs2022:
PS F:\test\vcpkg> ./vcpkg install discord-game-sdk:x64-windows --editable
Computing installation plan...
The following packages will be built and installed:
    discord-game-sdk[core]:x64-windows -> 2.5.6#4
Restored 0 package(s) from C:\Users\vzhli17\AppData\Local\vcpkg\archives in 152.3 us. Use --debug to see more details.
Installing 1/1 discord-game-sdk:x64-windows...
Building discord-game-sdk[core]:x64-windows...
-- Using cached discord_game_sdk.zip.
-- Extracting source F:/test/vcpkg/downloads/discord_game_sdk.zip
-- Applying patch include-cstdint.patch
-- Using source at F:/test/vcpkg/buildtrees/discord-game-sdk/src/d_game_sdk-19a6f72d70
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/bin/discord_game_sdk.dll
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/debug/bin/discord_game_sdk.dll
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/lib/discord_game_sdk.lib
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/debug/lib/discord_game_sdk.lib
-- Found external ninja('1.11.0').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/share/discord-game-sdk/copyright
-- Installing: F:/test/vcpkg/packages/discord-game-sdk_x64-windows/share/discord-game-sdk/usage
-- Performing post-build validation
Elapsed time to handle discord-game-sdk:x64-windows: 14.11 s
Total install time: 14.14 s
The package discord-game-sdk does not provides CMake integration:

    find_library(GAME_SDK discord_game_sdk)
    target_link_libraries(<my_target> PRIVATE ${GAME_SDK})

    find_path(GAME_SDK_INCLUDE discord-game-sdk/discord.h)
    target_include_directories(<my_target> PRIVATE ${GAME_SDK_INCLUDE})

The C++ SDK source code is compiled in a static library:

    find_library(CPP_GAME_SDK discord_game_sdk_cpp)
    target_link_libraries(<my_target> PRIVATE ${CPP_GAME_SDK})

Did your error occur when installing discord-game-sdk or when using discord-game-sdk?

This is through cmake installing via with github workflow

@TheMaverickProgrammer, I investigated and found that the files under the debug\lib and \lib paths after successfully installing discord-game-sdk are the same:

Are you using the latest vcpkg?

Your discord_game_sdk_cpp.lib is clearly not the same in file size. Which according to my original error is the problem;
discord_game_sdk_cpp.lib(achievement_manager.cpp.obj)

@TheMaverickProgrammer The "Steps to reproduce the behavior" could be understood as a problem with building discord-game-sdk:x64-windows, but actually you face problems using discord-game-sdk:x64-windows.
The printed usage instructions are for single-config generators. AFAICT they would cause the reported problem for the debug variant of a multi-config cmake project (e.g. using VS generators).

Do you have a solution? All other vcpkgs I use correctly link to the correct symbols (debug/release).

So you really want to use multi-config? The key is to use two calls to find_library and then continue with select_library_configurations or setting up an imported target.

So you really want to use multi-config? The key is to use two calls to find_library and then continue with select_library_configurations or setting up an imported target.

Any idea why all my other vcpkg libraries are correctly configured without doing this extra setup with select_library_configurations?

It is not possible to say something about all your other libraries. But for those mentioned:
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\fluidsynth.lib
Port fluidsynth provides CMake config with an imported target.
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\PocoNetd.lib
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\PocoJSONd.lib
Port poco provides CMake config with imported targets.
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\lua.lib
Port lua modifies  CMake's regular find module output variables, leveraging unofficial CMake config with an imported target.

It is not possible to say something about all your other libraries. But for those mentioned:
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\fluidsynth.lib Port fluidsynth provides CMake config with an imported target.
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\PocoNetd.lib X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\PocoJSONd.lib Port poco provides CMake config with imported targets.
X:\Big_Code\vcpkg\installed\x64-windows\debug\lib\lua.lib Port lua modifies CMake's regular find module output variables, leveraging unofficial CMake config with an imported target.

Thank you for pointing this out. It was my understanding from all of my experience so far with vcpkg ports that the imported target should be correctly configured otherwise it was a problem with the port's build scripts. I'll try your suggestion and see if it solves my issue.
In the mean time, what do you mean by (and I'm paraphrasing) me "setting up my own imported target"? Is that not the same thing as writing my own port? Because that is not ideal and is very time consuming. I'd prefer using the extra CMake steps to configure the target correctly and build as I'd expect it to.

You are not meant to modify the port. You simply need to do elaborate the find_* steps in your own project. That's almost the whole magic behind Find modules. Modern Find modules add libraries of type UNKNOWN IMPORTED and set per-config properties from the results of the find_* calls.
The key strength of exported CMake config is that it can easily capture not only install locations but also configuration options and transitive usage requirements. But this port doesn't declare any dependencies.
In generally it is upstream's task to provide official CMake config.
Last not least, this is the code for settung up variables (untested):
find_library(GAME_SDK_LIBRARY_RELEASE NAMES discord_game_sdk PATHS "{VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/lib" NO_DEFAULT_PATH)
find_library(GAME_SDK_LIBRARY_DEBUG NAMES discord_game_sdk PATHS "{VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/debug/lib" NO_DEFAULT_PATH)
include(SelectLibraryConfigurations)
select_library_configurations(GAME_SDK)
target_link_libraries(<my_target> PRIVATE ${GAME_SDK_LIBRARIES})

(I would like to avoid the PATHS option with the  VCPKG_INSTALLED_DIR variable by using PATH_SUFFIXES instead, but this should really be tested first, because it interacts in a more complex way with standard CMake variables.)

In generally it is upstream's task to provide official CMake config.

So you are affirming this is an issue but you have provided a manual solution.
Who is upstream in this case? VCPKG port maintainers or Discord Game SDK owners? If VPKG, we're in the right thread and we can wait for the issue to be pickup and resolved. If it's the Discord Game SDK owners, I can send this with my findings to their github.

Thanks for asking again ... Looking more closely, I have to rectify some statements.

vcpkg doesn't build the discord_game_sdk lib but just copies upstreams artifacts into release and debug directories.
So for this (C ?) lib, there is no difference between debug and release.
However, vcpkg builds the discord_game_sdk_cpp lib. This C++ library must be used correctly for debug vs. release, similar to what I presented in the cmake snippet.
(And this is the lib where you saw the error.)
The build of the C++ lib is done by a CMake project which comes with the vcpkg port. So there is no point in asking upstream to fix it, unless they would be willing to add similar CMake.

Given that upstream does provide any build system for the C++ lib, and no official lib name, providing this C++ library already is vcpkg lock-in, and adding unofficial CMake config directly to the vcpkg port would be the right thing to do.
(This being said, one could submit a simple CMake build system to the Discord Game SDK owners, but it is unclear if this is what they want and which additional question they would raise.)

Sorry your sentence structure doesn't make sense and it is hard to follow.
Anyway, I tried your suggestion and it includes both debug and release libraries into the project for both debug and release build configurations.
It's definitely promising that it did find the debug library.

Update, I changed
target_link_libraries(<my_target> PRIVATE ${GAME_SDK_LIBRARIES})

to just
target_link_libraries(<my_target> PRIVATE ${GAME_SDK_LIBRARY})

and I see the correct paths now. I'll double check with another clean build. 👍

Here's my final cmake to make this work right. I confirmed with a full clean build on both debug and release:
if(MY_PROJECT_DISCORD_SUPPORT)
	# Headers
	find_library(DISCORD_GAME_SDK discord_game_sdk)
	target_link_libraries(<my_target> ${DISCORD_GAME_SDK})
	find_path(DISCORD_GAME_SDK_INCLUDE discord-game-sdk/discord.h)
	target_include_directories(<my_target> PRIVATE ${DISCORD_GAME_SDK_INCLUDE})

	# The C++ SDK source code is compiled to a static library
	#
	# Fix for vcpkg port to select correct symbols 03/19/2023
	# https://github.com/microsoft/vcpkg/issues/29306#issuecomment-1475303879
	find_library(DISCORD_CPP_GAME_SDK_LIBRARY_RELEASE NAMES discord_game_sdk_cpp
		PATHS "${VCPKG_INSTALLED_DIR}"
		PATH_SUFFIXES "${VCPKG_TARGET_TRIPLET}/lib" NO_DEFAULT_PATH)
	find_library(DISCORD_CPP_GAME_SDK_LIBRARY_DEBUG NAMES discord_game_sdk_cpp
		PATHS "${VCPKG_INSTALLED_DIR}"
		PATH_SUFFIXES "${VCPKG_TARGET_TRIPLET}/debug/lib" NO_DEFAULT_PATH)

	include(SelectLibraryConfigurations)
	select_library_configurations(DISCORD_CPP_GAME_SDK)

	target_link_libraries(<my_target> ${DISCORD_CPP_GAME_SDK_LIBRARY})
endif()


Migrate to webpack2

Thank you for the great patch.
I'll check it soon.

Thank you @yuki-takei , I merged by #193 (merged current master and fixed shrinkrwap)


[docs] Add RN 0.71 iOS setup on AppDelegate.mm to README.md

[docs] Add RN 0.71 iOS setup on AppDelegate.mm to README.md

Updated README.md for additional instruction on how to setup your lottie splash screen on AppDelegate.mm now that 0.71 doesn't give access to rootview by default.

@madmeatballs Thank you!! LGTM!
Could you change your commit to the following format?
[docs] Add RN 0.71 iOS setup on AppDelegate.mm to README.md

- Updated README.md for additional instruction on how to setup your lottie splash screen on AppDelegate.mm now that 0.71 doesn't give access to rootview by default.

Thank you for your contribution!

Updated the commit message.

Oh, What I meant was the real commit message. Sorry

Oh, What I meant was the real commit message. Sorry. Could you push again after editing?

will do, I'll close this and open an new one


Build a wheel, and upload with twine

This will require to additionally install wheel and twine locally.

Thanks!


Workspace grid: Adjust grey color based on zoom

Our grid implementation doesn't antialiasing, so it is the overall visual shade changes as the dots are packed tighter together. The fastest way to solve this is by fading the shade of grey as the dots get closer.

Hello there, can I work on this?


RFC: Change indentation?

I use tabs in almost all of my projects, but the ruby world has more or less settled on two-space indentation.
Would changing ruby-macho to use two-space indentation be appreciated? Currently, whenever I update the vendored version in Homebrew, I run a little script to change it. I could just run that script in the repo and have it done in a single commit.
(Feel free to shoot this down if it's pointless - I just remembering seeing the indentation as a nit when originally getting ruby-macho merged in).
cc: @mikemcquaid @UniqMartin

Would changing ruby-macho to use two-space indentation be appreciated? Currently, whenever I update the vendored version in Homebrew, I run a little script to change it. I could just run that script in the repo and have it done in a single commit.

Yeh, sounds like a good idea :+1:

I'm also in favor of changing to two-space indentation. Too bad this is going to make the existing repository history almost useless, but better now than later.

I suggest to run all the ruby code against brew style --fix to improve the code style.

@UniqMartin Yeah, this was my primary concern.
@xu-cheng I'll look into that as well, thanks.
I'll make this change tonight.


file.publicUrl() returns a Promise instead of the publicUrl

Steps to reproduce
const bucket = storage.bucket(bucketName);
const file = bucket.file(filename);
const publicUrl = file.publicUrl();

There's actually a PR for this! https://github.com/googleapis/nodejs-storage/pull/1339

It still not working. I got undefined when I call file.publicUrl.

It still not working. I got undefined when I call file.publicUrl.

@soraxtend is your file already public? It can be made public by calling await storage.bucket(bucketName).file(filename).makePublic();


CSS inside the template should be moved to the CSS file

The template returned by the server, which contains the root element, contains a bit of CSS. This should be moved to the CSS file, but there are a few problems.
When the CSS file is processed all the ids are changed, so the reference to the "root" id is lost.
This id should not be processed. There should be some way to add a CSS file which will be merged with the main one without processing the ids.

It has been moved to its own file, which is not processed. But this is not the best solution.


[TRG 4.02] Check compliance with add mandatory image for frontend, add image names to readme

Introduction
Due to legal constrains we need to annotate the released container images to make it clear that we do our best to provide good images for demo purposes, but we do not provide any legal guarantee. To make that process easy, we are aligning on agreed base images for specific languages and use an aligned section to describe the base image.
Since many of our Eclipse Tractus-X product use the same language, we are aligning on a dedicated container base image per language. The following table lists container base images, that are already agreed on.

Language / Runtime
Container base image
Notes

Java / Kotlin / JVM based
Eclipse Temurin
prefer JRE over JDK and alpine tags for your JRE version

JS frontends
nginx-unprivileged
prefer :stable-alpine tag

.NET runtime
.NET runtime
prefer :alpine tag

ASP.NET runtime
ASP.NET core runtime
prefer :alpine tag

What needs to be done?
Add the base images used in the project to the README.md file.

This issue is duplicated from #42

https://github.com/eclipse-tractusx/digital-product-pass/pull/89


Translate quickstart-intermediate page

Source: https://github.com/laravel/docs/blob/5.2/quickstart-intermediate.md

đang dịch bài này

Added via https://github.com/petehouston/laravel-docs-vn/pull/67


Intellisense or language service error

have
Put caret between |
Press Enter
Type @if ( fast. After typing ( the additional if appears.

I cannot reproduce this in VS 16.0


Don't inject empty interior rings when converting to geo Polygons

I ran into what I think may be a small bug when using this library in a CLI tool I am working on.
It seems that when converting an exterior-only GeoJson polygon to a geo_types polygon, the library is injecting an empty interior ring rather than simply leaving the interiors field of the geo_types polygon empty.
This results in some surprising behavior if you do any round-trip conversions from geo_types -> GeoJson -> geo_types, since a polygon like this:
{"type":"Polygon",
 "coordinates":[[[30.0, 10.0],[10.0, 30.0],[40.0, 40.0],[30.0, 10.0]]]}

becomes:
{"type":"Polygon",
 "coordinates":[[[30.0, 10.0],[10.0, 30.0],[40.0, 40.0],[30.0, 10.0]], []]}

I've added a test case here which demonstrates the issue and included what I think is a reasonable approach to fixing it. Hope this is helpful!
I also fixed up a few test-name typos I noticed when I was reading these tests -- hope that is Ok.

bors r+


list of problem

easter... Don't Work !
enigma...  Don't Work !
this spaming error exist
socket.send() raised exception.

easter... Don't Work ! enigma... Don't Work !
this spaming error exist socket.send() raised exception.

firsly enigma and easter and supperset also it just claim after i update this i will update it everday when i have free time. But if you can't wait, just do it first.
secondly socket.send() raised exception. I need more information to be able to fix it. like:

what is your current python version you are using
-send me a screenshot of that problem


No connection can be established

I made a simple android app, that uses your library and the code on the front page to get a Callback when the device is connected. Unfortunately, this never happens, the app does not find a myo device. It is powered on and also connected to the phone via bluetooth.
Any help would be greatly appreciated!

Try increasing the timeout, make sure the myo is awake.
If all else fails try stepping through the code with the debugger.


Only allow instancing in GLESv2 when the extensions exist

This should fix compilation issues on ubuntu while linking with mesa/nvidia GLESv2.
P.S. Adding GLES2/gle2ext.h will default to Angle extension since it's defined first
Disclaimer:
I didn't test with angle (while extensions are on).
I didn't check with emscripten either.

Thanks!


drivers: flash: Introduce i.MX RT FlexSPI driver

Introduces a new flash driver for the FlexSPI peripheral on i.MX RT
SoCs. The hardware provides a flexible sequence engine (LUT) that
supports various types of external devices, including serial NOR flash,
serial NAND flash, HyperBus (HyperFlash/HyperRAM), and FPGAs. It
supports up to four connected devices in single/dual/quad/octal modes
and provides memory-mapped read/write access to these devices through
the AHB bus.
The driver implementation consists of a shared controller for each
FlexSPI peripheral instance, and protocol-specific device drivers for
each external device. The controller provides a private interface for
multiple devices to access the FlexSPI peripheral registers. FlexSPI
devices provide the public flash driver interface to applications or
subsystems like storage or flash file systems; they also provide
protocol-specific LUT sequences to the controller.
Currently the only device type supported is QSPI NOR flash, but other
types like HyperFlash will be added later.
XIP is not yet supported, as this requires additional work to relocate
code to RAM and managing interrupts.
Signed-off-by: Maureen Helm<EMAIL_ADDRESS>

This looks great. Thanks!
I'll try to look at the LUT part. We had lots of problems with that initially.

I have the mimxrt1060_evk, and am unable to get any of the samples (littlefs, spi_flash, jesd216, latter two with code changes to make it compile) to work.  littlefs builds and flashes, but dies in CLOCK_InitUsb1Pfd with no further output, not even the boot message.
Reflashing with hello-world works.
Is this board supposed to work, or does it use the flash in a way that's incompatible with this feature?

I have the mimxrt1060_evk, and am unable to get any of the samples (littlefs, spi_flash, jesd216, latter two with code changes to make it compile) to work.  littlefs builds and flashes, but dies in CLOCK_InitUsb1Pfd with no further output, not even the boot message.
Reflashing with hello-world works.
Is this board supposed to work, or does it use the flash in a way that's incompatible with this feature?

I have the mimxrt1060_evk, and am unable to get any of the samples (littlefs, spi_flash, jesd216, latter two with code changes to make it compile) to work. littlefs builds and flashes, but dies in CLOCK_InitUsb1Pfd with no further output, not even the boot message.
Reflashing with hello-world works.
Is this board supposed to work, or does it use the flash in a way that's incompatible with this feature?

No, this won't work on mimxrt1060_evk until XIP is supported. I specifically chose mimxrt1064_evk because it has two QSPI flashes - one internal to the package that is used for XIP, and one external mounted on the board that I could use exclusively for storage. mimxrt1060_evk only has the latter QSPI flash, so it has to be used for both code and storage, and thus needs XIP support in the flash driver.

I have the mimxrt1060_evk, and am unable to get any of the samples (littlefs, spi_flash, jesd216, latter two with code changes to make it compile) to work. littlefs builds and flashes, but dies in CLOCK_InitUsb1Pfd with no further output, not even the boot message.
Reflashing with hello-world works.
Is this board supposed to work, or does it use the flash in a way that's incompatible with this feature?

No, this won't work on mimxrt1060_evk until XIP is supported. I specifically chose mimxrt1064_evk because it has two QSPI flashes - one internal to the package that is used for XIP, and one external mounted on the board that I could use exclusively for storage. mimxrt1060_evk only has the latter QSPI flash, so it has to be used for both code and storage, and thus needs XIP support in the flash driver.

I pushed a new version with the following changes:

Renamed the driver and dts compatibles from qspi to nor. e.g., flash_mcux_flexspi_nor.c and nxp,imx-flexspi-nor. I want to add octal support in a future PR, and I think it will make more sense to extend this driver rather than create a new driver.
Removed unused LUT sequences. I tried to do this in my original version, but it didn't work at runtime. Turns out I needed to change the init function to update the LUT after setting the flash config, not before.
Included spi_nor.h to reuse some command macros like SPI_NOR_CMD_RDID and SPI_NOR_CMD_RDSR

@galak Will you please review the dts bindings?
@mmahadevan108 @arvid-r Will you please review the driver implementation?

I pushed a new version with the following changes:

Renamed the driver and dts compatibles from qspi to nor. e.g., flash_mcux_flexspi_nor.c and nxp,imx-flexspi-nor. I want to add octal support in a future PR, and I think it will make more sense to extend this driver rather than create a new driver.
Removed unused LUT sequences. I tried to do this in my original version, but it didn't work at runtime. Turns out I needed to change the init function to update the LUT after setting the flash config, not before.
Included spi_nor.h to reuse some command macros like SPI_NOR_CMD_RDID and SPI_NOR_CMD_RDSR

@galak Will you please review the dts bindings?
@mmahadevan108 @arvid-r Will you please review the driver implementation?

Removed unused LUT sequences. I tried to do this in my original version, but it didn't work at runtime. Turns out I needed to change the init function to update the LUT after setting the flash config, not before.
Why is that? Is the LUT cleared by setting the flash config?

Removed unused LUT sequences. I tried to do this in my original version, but it didn't work at runtime. Turns out I needed to change the init function to update the LUT after setting the flash config, not before.
Why is that? Is the LUT cleared by setting the flash config?

Looks good in general, but this is rather complex. I would like to try it on imx1020. Is that supposed to work if I run directly from SRAM? I have always used XIP, so I don't know if that is possible or how it can be done.

Looks good in general, but this is rather complex. I would like to try it on imx1020. Is that supposed to work if I run directly from SRAM? I have always used XIP, so I don't know if that is possible or how it can be done.

I think it would make sense to be more clear in the devicetree files for boards like mimxrt1060_evk that the flexspi-nor node doesn't actually work now. Perhaps by setting status = "disabled"; with a comment explaining why.

We can't disable the node because it's used to generate FLASH_SIZE and FLASH_BASE_ADDRESS for XIP.

Looks good in general, but this is rather complex. I would like to try it on imx1020. Is that supposed to work if I run directly from SRAM? I have always used XIP, so I don't know if that is possible or how it can be done.

I've been working to extend this to the XIP flash on RT1064, but it's not quite functional yet. I can relocate the driver to RAM with #31132, but unless we relocate the entire app to RAM, we have to disable interrupts for a very long time when we write or erase the flash.

What properties are you inheriting from the jedec nor binding?  Seems like just the size

size and spi-device properties

Why do we need different compats for hyperflash v nor as the bindings are identical currently

Because in the future we'll introduce another driver for hyperflash, which needs a different LUT and driver logic than the nor driver.

Why the defaults (see @pabigot question) on this.

I used the values needed for the internal QSPI flash on RT1064.

I think it would make sense to be more clear in the devicetree files for boards like mimxrt1060_evk that the flexspi-nor node doesn't actually work now. Perhaps by setting status = "disabled"; with a comment explaining why.

We can't disable the node because it's used to generate FLASH_SIZE and FLASH_BASE_ADDRESS for XIP.

Looks good in general, but this is rather complex. I would like to try it on imx1020. Is that supposed to work if I run directly from SRAM? I have always used XIP, so I don't know if that is possible or how it can be done.

I've been working to extend this to the XIP flash on RT1064, but it's not quite functional yet. I can relocate the driver to RAM with #31132, but unless we relocate the entire app to RAM, we have to disable interrupts for a very long time when we write or erase the flash.

What properties are you inheriting from the jedec nor binding?  Seems like just the size

size and spi-device properties

Why do we need different compats for hyperflash v nor as the bindings are identical currently

Because in the future we'll introduce another driver for hyperflash, which needs a different LUT and driver logic than the nor driver.

Why the defaults (see @pabigot question) on this.

I used the values needed for the internal QSPI flash on RT1064.

I used the values needed for the internal QSPI flash on RT1064.

If those are not going to be correct for other QSPI flash devices then they need to be explicit in the rt1064 and other board devicetree files, and required rather than defaulted in the devicetree binding specification.

I used the values needed for the internal QSPI flash on RT1064.

If those are not going to be correct for other QSPI flash devices then they need to be explicit in the rt1064 and other board devicetree files, and required rather than defaulted in the devicetree binding specification.

I pushed a new version with the following changes:

Expanded dts property descriptions to include references to their associated hardware register fields
Reviewed and updated dts property defaults to reflect hardware register reset values. There are a few exceptions for boolean properties that are default enabled in hardware, but default disabled in dts. I believe it's not possible to unset a boolean dts property if it was already set by default.
Added an rx_clock_source property instead of hard-coding the value in the driver
Removed the ahb-base property and used the second MMIO reg property instead (DT_INST_REG_ADDR_BY_IDX(n, 1))
Replaced the chip-specific sector erase command with the standard SPI_NOR_CMD_SE command

I purposely did not rebase to make it easier to see what changed from the previous version.

I pushed a new version with the following changes:

Expanded dts property descriptions to include references to their associated hardware register fields
Reviewed and updated dts property defaults to reflect hardware register reset values. There are a few exceptions for boolean properties that are default enabled in hardware, but default disabled in dts. I believe it's not possible to unset a boolean dts property if it was already set by default.
Added an rx_clock_source property instead of hard-coding the value in the driver
Removed the ahb-base property and used the second MMIO reg property instead (DT_INST_REG_ADDR_BY_IDX(n, 1))
Replaced the chip-specific sector erase command with the standard SPI_NOR_CMD_SE command

I purposely did not rebase to make it easier to see what changed from the previous version.

I believe it's not possible to unset a boolean dts property if it was already set by default.

It is; in an overlay add:
&node {
    /delete-property/ bool-prop;
};

I believe it's not possible to unset a boolean dts property if it was already set by default.

It is; in an overlay add:
&node {
    /delete-property/ bool-prop;
};

Rebased to resolve conflicts after merging #30864 and to pick up #31042.
@pabigot please check that I've integrated the jesd216 binding correctly in dts/bindings/mtd/nxp,imx-flexspi-device.yaml
scripts/dts/gen_defines.py wouldn't let me set boolean properties as default true, so I set them in the SoC level dts/arm/nxp/nxp_rt.dtsi

Rebased to resolve conflicts after merging #30864 and to pick up #31042.
@pabigot please check that I've integrated the jesd216 binding correctly in dts/bindings/mtd/nxp,imx-flexspi-device.yaml
scripts/dts/gen_defines.py wouldn't let me set boolean properties as default true, so I set them in the SoC level dts/arm/nxp/nxp_rt.dtsi

scripts/dts/gen_defines.py wouldn't let me set boolean properties as default true, so I set them in the SoC level dts/arm/nxp/nxp_rt.dtsi

I think that's an edtlib bug; I'm working on a patch.

scripts/dts/gen_defines.py wouldn't let me set boolean properties as default true, so I set them in the SoC level dts/arm/nxp/nxp_rt.dtsi

I think that's an edtlib bug; I'm working on a patch.

I think that's an edtlib bug; I'm working on a patch.

https://github.com/zephyrproject-rtos/zephyr/pull/31366

I think that's an edtlib bug; I'm working on a patch.

https://github.com/zephyrproject-rtos/zephyr/pull/31366

There is a bug in mimxrt1064_evk in how zephyr,flash-controller is set. It should technically not be set, based on how we define zephyr,flash-controller as the controller node for where zephyr,flash is set. As we don't set zephyr,flash we shouldn't be setting this property.

Ok, fixed. Please have another look. I also removed the xip property and set status = "disabled" instead.

There is a bug in mimxrt1064_evk in how zephyr,flash-controller is set. It should technically not be set, based on how we define zephyr,flash-controller as the controller node for where zephyr,flash is set. As we don't set zephyr,flash we shouldn't be setting this property.

Ok, fixed. Please have another look. I also removed the xip property and set status = "disabled" instead.


multi-line paragraphs

Please add support to multi-line paragraphs so that the following is considered to be a single paragraph:
This is
a paragraph
of multiple lines.

This is what Pandoc supports.
It would be a convenience (and compatibility) feature. I would not have to go through pasted text to remove line breaks.

The 2014 response is no longer accurate.
A simple way to get the requested behavior is to change the document's markdown presets. File Properties > Simple Properties > Extensions. Change the Preset from default to commonmark, for example.


Fix $ElementType union property key

Fixes #4211
Same fix as in destructuring with defaults

@jbrown215 will take a look when he has a minute!

Similar bug, my fix doesn't seem to work with it
https://flow.org/try/#0PTAEAEDMBsHsHcBQiAuBPADgU1AMQJZbQAmAzqALygDeAPoqKAIYBcoAFAJSUB8opKAE74AdgHMANA1AAjNl16gRAVwC2MrIMS0AvgG5kAY1giBoYkxSs8hEuSrVp1hRT4AiSLFhupjOR25XUAAWACZEfWRiLENoJkEcADd40ABrLDQ2ABIAaQzSAB4CIjIeA2jY+KSUyGyAUWgsVSwRFAAVTCwi2zIJUFz87pLSHjKjEzMAC0pQSC4DY1MUczZ0bFhIUGmqOc4FieXSbIBhJmhoArWsDdm+Ha5EIA

not clear if that's a bug to me. uncertain how the semantics of Call with no arguments should be

Please provide some more context about your change here. In particular, please provide some insight into your analysis of the underlying bug. What is the root cause? Separately, why does this change address that root cause?

Root cause is same as destructuring bug

I would be surprised if that's the case, but regardless note that de994b684b3b0561df4e596e0a46b63a93d70a33 has a quite substantial analysis which both explains the underlying mechanism that causes the buggy behavior as well as an explanation of the fix. This is the kind of analysis I am looking for here.

Yeah, it basically turns unions into two separate constraints like destructuring did, so it behaves like union in lower bound and intersection in upper bound, it's explained it issue itself and error looks similar how destructuring error looked

@samwgoldman I updated main post

If you think this is not the same bug, then how this should be fixed?

Wasn't aware of this PR. https://github.com/facebook/flow/commit/f322d37b1a209587449f73642b13d866e8bd9eb8 added something similar.

Similar bug, my fix doesn't seem to work with it EDIT: better example https://flow.org/try/#0PTAEAEDMBsHsHcBQiAuBPADgU1AMQJZbQAmAzqALygDeAPoqKAIYBcoAFAJSUB8opKAE74AdgHMANA1AAjNl16gRAVwC2MrIMS0AvgG5k6bKAAqlUABIAwk2jQAPBYCi0LKqwiUJzFnsEiZBKWANJYaKR+hCSkPLEGxFgAxtBMgjgAbqmg6WwmBuw5SmoagqC0-EKiYpz5AIxsKuqaZRXC4jWI7PWmHYhAA

This was fixed more recently with https://github.com/facebook/flow/commit/79a1f56596446269aa2392951fdfbecc77318517


PIAA dataset

Dear author, your paper is very nice and gives me great inspiration. I have some questions in "train_multi_attr_model_add_human_attr.py" of AesMamba_p. I download PIAA dataset, but I can not find "/PARA/annotation/user/random{random_idx}/user{idx}/train_100shot.csv" and '/data/sjq/IAAdataset/PARA/annotation/user/random{random_idx}/user{idx}/test.csv'. I think this dataset is produced by the author. Can you share this dataset? Thank you very much!

sorry i,m late.   all right, i will give you later

Uploading user.zip…

Uploading user.zip…
I clicked on this link, but no response.

Dear author, I clicked on this link, but no response. And, Can you also share Photo.Net dataset? Thank you very much!

user.zip

Pan-Baidu：PhotoNetDataset
Link：https://pan.baidu.com/s/169lvGraBH0LXguebi813mA?pwd=zp5o
passwd：zp5o

Thank you very much!


Is it possible to utilize this parser for single line input?

I have a need for a single line subset of Markdown. I.e. one that doesn't generate paragraphs and only supports inline constructs.
The use case are standalone single lines of content e.g. coming from input[type="text"] not a textarea.
Minimum support would be bold, underline...

https://markdown-it.github.io/markdown-it/#MarkdownIt.renderInline

Thanks, missed that.


Ga/website update

Its a shame RStudio only has soft-wrapping of long lines (an old and still open issue requesting hard-wrapping).
Very minor suggestions from @tdjames1 and I agree that the clarify and make things consistent.
Great work @G-Accad :+1:  Happy to approve once these tweaks are done.

Thank you both!! Will change the name to R-Ladies Sheffield in the top bar and request (hopefully) final approval.
I really appreciate it 🙌


Only initialize NSDate when it is needed

Further to discussion in https://github.com/pinterest/PINCache/pull/57 this PR cleans up date logic so that we only create the NSDate when we actually need to use it.

Awesome, thank you!


Error in command init -    Cannot find apps/PROJECT FOLDER/project.json

Im macos, after i install, when i run the comand:
nx g @badgers-ua/nx-react-pwa:init
gives me a error
Cannot find apps/'PROJECT FOLDER'/project.json

it  seems to me that this plugin was designed for monorepos ...
however, after having setup a monorepo using: npx create-nx-workspace@latest i still run into this issue:

NX   (0 , file_utils_1.readFileIfExisting) is not a function

TypeError: (0 , file_utils_1.readFileIfExisting) is not a function
at updateIndexHtml (monorepo\node_modules@badgers-ua\nx-react-pwa\src\generators\nx-react-pwa\utils\ast.utils.js:7:57)

anyway, one way for you to get started would be to:

clone the repo: https://github.com/badgers-ua/nx-react-pwa-example
run this script: npx workbox-cli generateSW ./apps/pwa/workbox-config.js
npm i + npm start
now remove the && !isLocalhost statement on line 10 of registerServiceWorker.js

this should start up the application and register the SW on development. you might need to change security settings no chrome/Firefox though:  https://stackoverflow.com/questions/34160509/options-for-testing-service-workers-via-http
https://blog.bitsrc.io/using-service-workers-with-react-27a4c5e2d1a9