Crash in Godot when trying to register signals with two more more parameters

Godot is crashing when I try to register a signal with two or more parameters. Adding the homepage signal example:
@Signal static void function(String message, int num) sendMessage;

To the asterois test project causes the following backtrace:
$ godot --path project

OpenGL ES 3.0 Renderer: Mesa DRI Intel(R) UHD Graphics 620 (Kabylake GT2)
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /usr/lib/libc.so.6(+0x3a7e0) [0x7f2c38fdb7e0] (??:0)
[2] godot() [0xa8ba1f] (??:0)
[3] godot() [0xe2aa93] (??:?)
[4] /home/ricardo/Workspace/Programming/Godot/godot-d/examples/asteroids/project/libasteroids.so(_D5godot1d8register__TQmTC9asteroids9AsteroidsZQBlFNbPvSQCc15gdnativelibrary15GDNativeLibraryZv+0x951) [0x7f2c0faaf7a1] (??:0)
[5] /home/ricardo/Workspace/Programming/Godot/godot-d/examples/asteroids/project/libasteroids.so(asteroidsnativescript_init+0x45) [0x7f2c0faaee15] (??:0)
[6] godot() [0xc88fbc] (??:?)
[7] godot() [0x973a1f] (??:0)
[8] godot() [0x9dd4fc] (??:0)
[9] godot() [0x214041f] (??:?)
[10] godot() [0x21e63f1] (??:?)
[11] godot() [0x1d9f786] (??:?)
[12] godot() [0x23b02c7] (??:?)
[13] godot() [0xb52044] (??:0)
[14] godot() [0x25130ee] (??:?)
[15] godot() [0x238ea62] (??:?)
[16] godot() [0x1d9f20f] (??:?)
[17] godot() [0x23b02c7] (??:?)
[18] godot() [0x25130ee] (??:?)
[19] godot() [0x238ea62] (??:?)
[20] godot() [0xb350e3] (??:0)
[21] godot() [0x7b28ab] (??:0)
[22] /usr/lib/libc.so.6(__libc_start_main+0xf3) [0x7f2c38fc7ee3] (??:0)
[23] godot() [0x7bfc4e] (??:0)
-- END OF BACKTRACE --
[1]    29383 abort (core dumped)  godot --path project

I'm not even sure if this is a problem with Godot-d or Godot itself though.

I managed to compile Godot with debug symbols, revealing more info:
...
Loading resource: res://Asteroids.tscn
Loading resource: res://Asteroids.gdns
Loading resource: res://asteroids.gdnlib
handle_crash: Program crashed with signal 11
Dumping the backtrace.
-- END OF BACKTRACE --
[1]    27041 abort (core dumped)  ./godot.x11.tools.64 --path  --verbose

Meaning the problem is ocurring here: https://github.com/godotengine/godot/blob/3.1/modules/gdnative/nativescript/godot_nativescript.cpp#L167
I'm not sure on how I should be reading the data, but playing with gdb I found out that the first arg has (PropertyHint)arg.hint equal to PROPERTY_HINT_NONE, but the second argument has PROPERTY_HINT_ENUM. That's the only fishy thing I could find.

Found the problem. There was a mismatch in the sizes of the structs:

Both the D and C++ (Godot) godot_size_argument have a sizeOf of 52 bytes.
Doing godot_signal.args[0].sizeof also reported the correct size of 52.

However, on the register.d file, line 251 (inside the static foreach), when the struct is created on line 257 (godot_signal gs;), doing gs.args[0].sizeof returned a size of 56 bytes. This mismatch is what was causing Godot to crash: because the pointer arithmetic is different, Godot started reading garbage data.
I have created a PR (#52) to fix this issue. From my personal tests it didn't break anything (the examples and my project), but I don't know the impact of the changes.

Nice debugging, thanks. I've had a similar problem before with godot_property_attributes. Apparently extern(C) is not enough to match GDNative's alignment. I'm not sure if this is implementation-defined on the C++ side or just a bug in the D compiler. This case looks more like a D compiler bug, but I don't really know what the "official" intended behavior is either.


Demo hidden ToC items using orphans

Draft to demo how to hide items from ToC

I don't think we need this anymore - please feel free to reopen if I'm mistaken.


[$1000] Android  - App displays broken message text without email for existing email contact on user details

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app on android
Open any report
Mention email only user to whom you have already chatted before (user email should not have dot in its email before @) and send the message
Click on mention to open details page and observe that app does not display email besides 'message' and also paritally cut the message text

Expected Result:
App should display user email beside 'message' on user details page. If the email is too long, it should display similar to this, where ... are on the far right of the screen

Actual Result:
App does not display user email besides message on user details and displays truncated 'message' if we had already chatted with user and user email has no dot before @
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:  v1.3.43-7
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/cc728077-bdda-4a80-80ab-82445cb93c8f
Expensify/Expensify Issue URL:
Issue reported by: GH handle - @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689956338921469
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0114172bcac0ccb2df
Upwork Job ID:<PHONE_NUMBER>894810624
Last Price Increase: 2023-07-31

Was able to repro, updated the Expected behavior with

App should display user email beside 'message' on user details page. If the email is too long, it should display similar to this, where ... are on the far right of the screen

I think this might be a duplication of #23769. Wasn't able to reproduce on the latest main - I think it was repaired in this PR #24142 . Will check if it occurs before that.

Hi @SosenWiosen, @thesahindia, the issue is raised before #23769, if it was solved because of that issue, will it be eligible for reporting bonus?

Sorry for the lonnnnng delay, I was caught up in a deadline for another project.
https://github.com/Expensify/App/issues/23769
Created on July 27th

This bug reported created on July 21

@dhanashree-sawant , it appears they are the same or similar, is there any way to 'prove' that the PR for that one fixed this?  Asking cuz it's helpful to have a link to drop in for auditing purposes if I pay this out for the reporting bonus.

From what I have seen in the PR and in that issue, root cause was 'The root cause is android use different way to break words'  (taken from this proposal) and changes was made on both details and profile page. In this issue, we had the same root cause for 'Message' text truncate on details page. Since that PR also made the changes on Details page too, the following issue seems to be fixed due that.

Thanks @dhanashree-sawant , it seems/sounds like, since you reported the issue first, you are due compensation for reporting the bug. (and, the other contributor was already compensated cuz that bug got fixed first so we can't/won't claw that payment back). Can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0114172bcac0ccb2df

Thanks @mallenexpensify, I have accepted the offer.

Issue reporter: @dhanashree-sawant paid $250 via Upwork


Feature/config dirs

Coverage increased (+0.2%) to 81.667% when pulling 9b6be975066f99d6d7380458358ae0b55ed0f108 on feature/config-dirs into ab2cf9493b89fa7c9bed2777dad901ef5851a44b on master.


Write contribution guide

Dedicated docs in the README for contributors.
Also begins following the specs of allcontributors.com, and updates the URL in the JSDoc comments to point to grammy.dev  instead of the old preview domain.

I will address the changes to the build tooling in a separate PR.

However, given that most bot developers are still using Node, all documentation is written Node-first. We may migrate it if Deno overtakes Node. If you are already on Deno today, we expect you to know what you're doing. You mainly have to adjust the imports to URL imports, and use https://deno.land/x/grammy.
I don't agree on this actually. Deno should be first, not node.

Why? What is your rationale?
Docs are supposed to be targeted towards the reader. It is a fact that most readers know Node (even if on Deno), but very few readers know Deno. Ignoring this makes the docs worse, and introducing Deno AND grammY is out of scope.

I see your point. We should migrate the docs earlier, not only when Deno overtakes Node. However, I still believe that the current day is too early to do this.

I see your point. We should migrate the docs earlier, not only when Deno overtakes Node. However, I still believe that the current day is too early to do this.

Yep. I agree


BUG: Don't use CRS classes for defaults in CRS child class init signatures

[x] Closes #554
[x] Fully documented, including history.rst for all changes and api/*.rst for new API

cc: @jorisvandenbossche

Thanks!
Are you planning to do a 2.5.1 before 2.6?

Originally I was. But, I added some new features since then. Also, PROJ 7 was just released and PROJ 6 seems to be nearing end of support, so I think moving on to add PROJ 7 in the wheels would be a good idea. So, the plan is just to jump to 2.6.


fix event publisher in graph options

Description
Fix wrong event Publisher type in the graph service
Motivation and Context
Make the linter happy
How Has This Been Tested?

manually,
tested create user and create space events via audit log ✅

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

not needed.


adapter installation is failing

When I try to install the adapter from iobroker admin guy, I receive following error
$ ./iobroker add sainlogic  --host iobroker
NPM version: 6.14.12
npm install<EMAIL_ADDRESS>--loglevel error --prefix "/opt/iobroker" (System call)
npm ERR! code ETARGET
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>ERR! notarget In most cases you or one of your dependencies are requestingnpm ERR! notarget a package version that doesn't exist.
npm ERR! A complete log of this run can be found in:npm ERR!     /home/iobroker/.npm/_logs/2021-08-01T16_11_04_120Z-debug.log
ERROR: host.iobroker Cannot install<EMAIL_ADDRESS>1
ERROR: process exited with code 25
the corresponding log
2021-08-01T16_11_04_120Z-debug.log
Version Info
iobroker.admin V4.2.2
Node.js: v10.24.1
NPM: 6.14.12

The latest Version in this Repo is 0.7.2 The rpm Version is still on 0.6.6. Therefor the npm Version has to be updated to eliminate the Error.

Ok, I did overlook this one. npm version is fixed, now I am getting a different error:
$ ./iobroker add sainlogic  --host iobroker
NPM version: 7.20.3
npm install<EMAIL_ADDRESS>--loglevel error --prefix "/opt/iobroker" (System call)
npm ERR! code ETARGET
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/iobroker/.npm/_logs/2021-08-02T18_22_12_745Z-debug.log
ERROR: host.iobroker Cannot install<EMAIL_ADDRESS>1
ERROR: process exited with code 25
The mentioned 2021-08-02T18_22_12_745Z-debug.log is empty..

Yes. The nom Version of this Adapter is outdated. You can simply install this repo with
npm install https://github.com/phifogg/ioBroker.sainlogic --prefix "/opt/iobroker"
Then the newest Version is installed

Thanks for your help @MrDrache333  - I am working with the ioBroker team to get the npm version updated. However, they ask for some additional work from me with takes extra time.

0.7.3 has been pushed to the official repo... should show up shortly in ioBroker.


When exporting my LinkedIn profile, I end up with someone else's work experience

I have a strange issue. When using the extension on my LinkedIn profile, the resulting JSON Resume file contains my own summary and education sections, but someone else's work history. In this case, it's the work history of an ex-colleague of mine. I assume this is a bug?

Thanks for reporting this. I was immediately able to reproduce the exact same results as you got (your ex-colleague's work experience got pulled in). This is... bizarre, to say the least.
I'll look into this; my guess is the wrong profile URN ID is getting pulled in somehow, which LinkedIn is making it harder and harder to extract reliably.

@DandyDev This indeed was an issue with incorrect profileUrnId extraction; a fix has been implemented and a new release authored (v1.4.1).
Thanks again for reporting (and including the profile links - that helped me a lot).

Awesome, this works correctly for me now!


order pool报错

一开始运行时是好的，每隔一分钟会提示一次avaliable session pool有3个，但是自从报了下面这一堆错之后就不再显示avaliable session pool了
2023-10-13 11:37:04,408.408 INFO OrderPool.order/handle_pool: Number of available order session pools: 3
2023-10-13 11:37:07,989.989 INFO MainThread.inventory_monitoring/start: 苏州 iPhone 15 Pro Max 256GB 原色钛金属 店内取货 暂无供应
2023-10-13 11:37:17,978.978 INFO MainThread.inventory_monitoring/start: 苏州 iPhone 15 Pro Max 256GB 原色钛金属 店内取货 暂无供应
2023-10-13 11:37:26,683.683 INFO MainThread.inventory_monitoring/start: 苏州 iPhone 15 Pro Max 256GB 原色钛金属 店内取货 暂无供应
2023-10-13 11:37:34,410.410 INFO OrderPool.order/handle_pool: Number of available order session pools: 0
2023-10-13 11:37:34,411.411 INFO OrderPool.order/add_to_cart: Adding to cart...
2023-10-13 11:37:35,332.332 INFO MainThread.inventory_monitoring/start: 苏州 iPhone 15 Pro Max 256GB 原色钛金属 店内取货 暂无供应
Exception in thread OrderPool:
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 467, in _make_request
    self._validate_conn(conn)
  File "/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 1092, in _validate_conn
    conn.connect()
  File "/usr/local/lib/python3.10/site-packages/urllib3/connection.py", line 642, in connect
    sock_and_verified = _ssl_wrap_socket_and_match_hostname(
  File "/usr/local/lib/python3.10/site-packages/urllib3/connection.py", line 783, in _ssl_wrap_socket_and_match_hostname
    ssl_sock = ssl_wrap_socket(
  File "/usr/local/lib/python3.10/site-packages/urllib3/util/ssl_.py", line 469, in ssl_wrap_socket
    ssl_sock = _ssl_wrap_socket_impl(sock, context, tls_in_tls, server_hostname)
  File "/usr/local/lib/python3.10/site-packages/urllib3/util/ssl_.py", line 513, in _ssl_wrap_socket_impl
    return ssl_context.wrap_socket(sock, server_hostname=server_hostname)
  File "/usr/local/lib/python3.10/ssl.py", line 513, in wrap_socket
    return self.sslsocket_class._create(
  File "/usr/local/lib/python3.10/ssl.py", line 1104, in _create
    self.do_handshake()
  File "/usr/local/lib/python3.10/ssl.py", line 1375, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLEOFError: [SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol (_ssl.c:1007)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 790, in urlopen
    response = self._make_request(
  File "/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 491, in _make_request
    raise new_e
urllib3.exceptions.SSLError: [SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol (_ssl.c:1007)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/requests/adapters.py", line 486, in send
    resp = conn.urlopen(
  File "/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 844, in urlopen
    retries = retries.increment(
  File "/usr/local/lib/python3.10/site-packages/urllib3/util/retry.py", line 515, in increment
    raise MaxRetryError(_pool, url, reason) from reason  # type: ignore[arg-type]
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='www.apple.com.cn', port=443): Max retries exceeded with url: /shop/buy-iphone/iphone-15?ams=0&product=MU2Q3CH/A&step=attach (Caused by SSLError(SSLEOFError(8, '[SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol (_ssl.c:1007)')))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/usr/local/lib/python3.10/threading.py", line 953, in run
    self._target(*self._args, **self._kwargs)
  File "/app/actions/order.py", line 471, in handle_pool
    pool_data = self.new(order_data)
  File "/app/actions/order.py", line 479, in new
    order.init_order(order_data)
  File "/app/actions/order.py", line 36, in init_order
    self.add_to_cart(order_data.model, order_data.model_code)
  File "/app/actions/order.py", line 121, in add_to_cart
    resp = self.session.get(
  File "/app/libs/requests.py", line 36, in get
    return self.request(
  File "/app/libs/requests.py", line 27, in request
    return self.session.request(method, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 725, in send
    history = [resp for resp in gen]
  File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 725, in <listcomp>
    history = [resp for resp in gen]
  File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 266, in resolve_redirects
    resp = self.send(
  File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/requests/adapters.py", line 517, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='www.apple.com.cn', port=443): Max retries exceeded with url: /shop/buy-iphone/iphone-15?ams=0&product=MU2Q3CH/A&step=attach (Caused by SSLError(SSLEOFError(8, '[SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol (_ssl.c:1007)')))
2023-10-13 11:37:43,966.966 INFO MainThread.inventory_monitoring/start: 苏州 iPhone 15 Pro Max 256GB 原色钛金属 店内取货 暂无供应
2023-10-13 11:37:53,118.118 INFO MainThread.inventory_monitoring/start: 苏州 iPhone 15 Pro Max 256GB 原色钛金属 店内取货 暂无供应
2023-10-13 11:38:02,917.917 INFO MainThread.inventory_monitoring/start: 苏州 iPhone 15 Pro Max 256GB 原色钛金属 店内取货 暂无供应
2023-10-13 11:38:11,511.511 INFO MainThread.inventory_monitoring/start: 苏州 iPhone 15 Pro Max 256GB 原色钛金属 店内取货 暂无供应
2023-10-13 11:38:20,700.700 INFO MainThread.inventory_monitoring/start: 苏州 iPhone 15 Pro Max 256GB 原色钛金属 店内取货 暂无供应
2023-10-13 11:38:30,326.326 INFO MainThread.inventory_monitoring/start: 苏州 iPhone 15 Pro Max 256GB 原色钛金属 店内取货 暂无供应
2023-10-13 11:38:38,992.992 INFO MainThread.inventory_monitoring/start: 苏州 iPhone 15 Pro Max 256GB 原色钛金属 店内取货 暂无供应`
```

增加了错误后重试


Variables not recognized from variable groups

when I run my script to login to quay and push my image, my environment variables are not recognized:

script: |
docker login -u $(quayUser) -p $(quayPswd) quay.io
output:
2018-10-31T15:33:35.8408915Z /home/vsts/work/_temp/XXX.sh: line 1: quayUser: command not found
2018-10-31T15:33:35.8409887Z /home/vsts/work/_temp/XXX.sh: line 1: quayPswd: command not found

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd7e0bd3-1f7d-d7b6-cc72-5ef63c31b46a
Version Independent ID: dae87abd-b73d-9120-bcdb-6097d4b40f2a
Content: Pipeline variables - Azure Pipelines & TFS
Content Source: docs/pipelines/process/variables.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

Can you paste in the entire relevant section of the YAML you tried? There's not enough here to troubleshoot (except that your macros are being passed through without replacement, which then makes Linux try to execute quayUser).

# Docker image
# Build a Docker image to deploy, run, or push to a container registry.
# Add steps that use Docker Compose, tag images, push to a registry, run an image, and more:
# https://docs.microsoft.com/azure/devops/pipelines/languages/docker
#testing build
pool:
  vmImage: 'Ubuntu 16.04'

variables:
  imageName: 'quay.io/blah/blah:$(build.buildId)'

steps:
- script: docker build -f Dockerfile -t $(imageName) .
  displayName: 'docker build'

- script: |
    docker login -u $(quayUser) -p $(quayPswd) quay.io
    docker push $(imageName)
  displayName: 'Push to Quay.io'

I've tried running it as bash instead of script as well and that didn't change anything

@vtbassmatt let me know if you need more info

Got it. You have to explicitly map in variable groups. Something like this:
pool:
  vmImage: 'Ubuntu 16.04'

variables:
- name: imageName
  value: 'quay.io/blah/blah:$(build.buildId)'
- group: myQuayVarGroup  # the name of the group which contains quayUser and quayPswd

steps:
- script: docker build -f Dockerfile -t $(imageName) .
  displayName: 'docker build'

- script: |
    docker login -u $(quayUser) -p $(quayPswd) quay.io
    docker push $(imageName)
  displayName: 'Push to Quay.io'

Thanks @vtbassmatt !!! Now I can try out more of the tight integration this provides vs using drone

I had this same issue when running checked-in script and referring variable value from classic editor bash task.
Workaround is use inline option and call your script and pass the variable through inline  & read the variable value through command line variable inside the script.
./run  $(variable_group_variable)


bug(frontend): copy to clipboard doesn't work on firefox

Error message:

We are directly using navigator.clipboard in copy-to-clipboard.tsx, this should be a very easy switch to something like clipboardjs.

Hi @abelanger5 - Can you guide me how can I reproduce this error on firefox?

I filed this on the project's Discord here and it just clicked that the clipboard API is privileged and when I got this error I was accessing via http
Maybe show like an error message or hide the button or something when running on an insecure context?

Ah I see, I think hiding the button would be better as error message can lead to bad UI/UX.
I know this is out of scope now but clipboardjs relies on execCommand API which is now deprecated.

@abelanger5 Please review


DROPDOWN - Extra padding between trigger and bib when the bib opens at the top

Please verify the version of auro-form you have installed
1.5.0
Please describe the bug
See spacing between bib:

Reproducing the error
This issue is reproducible on the Auro docsite
Expected behavior
The extra padding should be added when the bib opens on the bottom, rather than the top.
Exit criteria
Extra padding between the bib and trigger when it opens upwards should be removed and applied when the bib opens downwards.

Duplicate ticket.

Still an issue, re-opening the ticket.


Plan out the stucture of the repository, cad, and documentation source and how this creates the final documentation

As there are a good number of comments here I am leaving this issue where it is. But it is in the wrong repository. It should be in Wakoma/nimble!
Sorry

The repository structure is still somewhat evolving. The biggest issue here is python package management and imports.
Relative python imports cause a number of weird issues, it is much more reliable to create packages that can be pip installed. But due to the other assets needed this is still somewhat problematic unless we include in place, and because the scripts we call are not packaged.
This structure is likely to evolve as the server becomes more contained.

In the rush to get things building and serving for Re:Publica I push forward with a somewhat-odd python module structure where we pip install in place (i.e. with -e) and a lot of things rely on local paths. We also have really have 3 packages in one (the server, the orchestration, and the shelf code). I think it is time to detangle this before the knots I created become the structure that we build upon evermore.
Long term we want this workflow to be available to any modular project, not just to Nimble. For this reason I suggest we split the repo in two repositories.
Repo 1: Nimble (this repo)
Keep under CERN OHL-S
This will still contain:

The CadQuery scripts that make the shelves/assemblies
The base GitBuilding docs
The shelf builder python module
Nimble specific configurations for orchestration
Nimble specific instructions for the server (i.e. the CSS, the wording, the configuration form)

Repo 2: Modular orchestrator
Relicense to GPL, or AGPL or something
This will become a stand alone python module which has a server, and handles orchestration. For now, as Nimble is the only project using it, it will be somewhat Nimble focussed; however, we should endeavour to have any nimble-specific information in the Nimble. This will contain

Utilities such as the Yaml Cleaner, or ExSourceDefinition writer
The underlying server code. - This server code should look for a configuration file that tells it which questions to ask, the website text, logo, CSS, etc.
The a generic orchestration module, containing the generic steps of "generate component cad", "generate assembly renders", "generate assembly CAD", "generate documentation".
Entrypoints for running the server.

Suggested workflow for using orchestrator in Nimble or any future project.

Create your CAD scripts
Create your static GitBuilding files
pip install orchestrator
Create config file that explains component types and documentation steps/templates for modular templates - Temporarily this may need to be done via child classes of some of the orchestrator classes
Create config file that explains what the web-configurator should ask, and how it should look
run orchestrator serve

I think that even if the orchestrator starts of being Nimble focussed, it gives a path we can show NLNet for how it will be separable and reusable in the future.

Other questions:
@jmwright @drayde @ericnitschke Would be great to know your thoughts on this. Specifically to the following questions:

Are you happy for me to implement this?
Do you have a better name for the orchestrator repository/python module than orchestrator
Where does the orchestration repo live? I think it may make sense to live within the "GitBuilding" organisation on GitLab, as the orchestrator will be tied to both ExSource and GitBuilding which already sit under this organisation. I would of course make people team members of this project so that you can continue dev. I am not trying to grab ownership the orchestration project. I am just thinking about where it feels like it belongs. I'm happy to put it elsewhere.

I had expected the orchestration layer and the server to be in separate repos, especially since you do pip install orchestrator. Is it just the Nimble UI that will be in a separate repository, and this "server" is just an API interface to the orchestration script?

I suppose my thought was that a generic orchestrator will always need a server to provide the interface to use it? We can then provide ways that projects can style and add content/options to their server?

I had been thinking that the orchestrator was just a CLI utility, and that the server was added as a layer on top of that. However, if the main/only mode of interacting with the orchestrator will be through the server layer, then the server could be more tightly coupled to it.
If Repo 1 is structured in such a way that it can be cloned inside of Repo 2 (submodule or whatever) and could be swapped out for another project, I expect that would go a long way towards the NLnet goal of making this work applicable to other open hardware projects.

My thoughts exactly. In fact I'm hoping even easier than cloning/submoduling. I am hoping that Repo 1, just pip installs Repo2, and now has an server interface for orchestration (in the same way it can pip install gitbuilding to get a local "server" interface for modifying the docs). If @smamudhan  can then use is containerisation skills to make a generic container for Repo two it should be easy for people to deploy.

I too was assuming orchestrator would not have any server code. There are use cases, where having a server with the orchestrator does not make sense, like using it in a build pipeline. If we want to do a general purpose (not Nimble specific) configuration server interface to orchestrator, maybe have it in yet another repo?

It is fine to use the orchestration without ever starting up the server. It is just that the server can never run without the orchestration, as it needs to directly interact with the orchestration. Therefore developing them in two repositories is a unnecessary overhead.
If the server dependencies are deemed to large we can always just have it be
pip install orchestrator-package
for no server. But if you want the server:
pip install orchestrator-package[server]

Closed by https://github.com/Wakoma/nimble/pull/84


chore(main): release 3.8.0

:robot: I have created a release beep boop
3.8.0 (2024-08-12)
Features

Support transient identities and traits (#93) (0a11db5)

Bug Fixes

Offline handler not used as fallback for local evaluation mode during init (#100) (6f6d595)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v3.8.0
:sunflower:


SQL parser issue - 2.1 - unable to create embedded list item

Hi
I have a problem to create any embedded list item because parser is not able to parse @type and @class fields.
orientdb version: 2.1
Here is an output from orientdb:
OrientDB.RequestError: Error on parsing command at position #0:
Encountered " <RECORD_ATTRIBUTE> "@type "" at line 1, column 400.

Maybe it is linked with https://github.com/orientechnologies/orientdb/issues/4724

Hi @seeden
could you please post the SQL statement you are using?
Thanks

I have a classes with defined schemas. This is the reason why I need to add metadata @type and @class if I wanted to create an embedded item. Without it I am not able to add any embedded item and migrate to version 2.1. Thank you for your help Luigi.
Here is a query:
INSERT INTO Activity SET user = #14:1, story = #18:2, like = :paramlike0;

{
  params: {
    paramlike0: {
      count: 0,
      latest: [],
      '@type': 'document',
      '@class': 'Like'
    }
  }
}

Any progress with this issue?

fixing it right now

Thank you

fixed in both 2.1.x and develop branches.
Please confirm that it also fixes your use case
Thanks

Thanks it is working


Add a prominent remark in the README that errors of type Retval[0] does not have value may be caused by operations unsupported by CoreML

It will save a headache for those who are new to machine learning and just trying to convert an existing tensorflow model they found somewhere on the internet.

Or, most probably, by having training phase nodes in your graph .pb file, which must first be removed by tensorflow.graph_util.remove_training_nodes


Edit multiple paragraphs at once.

Is there a way to select multiple paragraphs and turn them into a bulleted list or delete them? It seems that only one paragraph can be edited at a time.
Thanks.

@bcreeves sorry I thought initially this was an issue raised as a feature request for CT 2 (I've had a few recently so was in that mindset), I will move this across to the feature requests section of the CT 2 repo now to keep track of this.
At the moment there's no support for selecting multiple blocks of editable content I'm afraid.


Carousel starting off in a weird place

I don't know if it's because I have it inside a tab which is hidden at the beginning (from reading around I get the impression that this could cause problems) but I'm finding that the carousel (which is just a test version with code basically just copied from the website) starts off up in the corner. If you interact with it it centers itself and switching away from that tab and back to it it works fine, but it looks pretty weird. It also gets hidden behind some other content if I add some things to the page.
Here is my Codepen: http://codepen.io/anon/pen/PpWNdV

The text is for reference, it's centered on the page.
Thank you for making this framework and for reading!

Use the onShow callback to reinitialize the carousel. Something along the lines of:
  $('.tabs').tabs({
    onShow: function() {
      $('.carousel').carousel();
    }
  })

Thanks, it seems like that would work (it works in the pen), but for some reason on my actual site it never gets run. Any idea why that might be?

Not sure, when I add the code snippet to your codepen it works. Are you sure you are putting it in a document ready? Where you initialize all your other components?

Silly me, I didn't put it in the document.ready. Sometimes I think I  just forget how the languages I'm coding in work 😛. Additionally, did you guys make any major changes to the tooltips? I have some branches of my project where they work and some where they don't, and the only difference I can find (that would affect the tooltips, anyway) is that I updated the Materialize version.


ReflectionProbe Does Not Reflect Panorama Sky

Godot version
v3.4.stable.official
System information
Ubuntu 21.10 AMD 6800XT Mesa Drivers GLES3
Issue description
The reflection probe does not seem to capture the panorama sky texture, only the default procedural sky.

I would expect that the reflection captures the scene as you see it on screen, including the sky texture.
Steps to reproduce
Create a scene with some objects to reflect.
Add a panorama sky to the camera environment, all formats seem to be affected.
Add a reflective object, such as a sphere with metallic at 1 and roughness at 0.
Play the scene and see only the default sky is reflected, not the sky texture.
Minimal reproduction project
ReflectionProbe.zip

Additionally, you can notice that the environment lighting within the ReflectionProbe is incorrect.

Actually, the shadows are correct, but for the default environment. I think if the reflection used the panorama, then the lighting would be accurate.

I know why this is happening. The environment is configured on the camera, but this does not affect ReflectionProbes. The environment doesn't appear in the editor unless you're previewing the camera:

Okay, yes that works now. I wish I knew that before, and I don't see this in the documentation.
https://docs.godotengine.org/en/stable/classes/class_reflectionprobe.html
https://docs.godotengine.org/en/stable/tutorials/3d/reflection_probes.html
Neither of those pages even mention the word WorldEnvironment. So I am okay with the functionality, since it does work, but I believe this should be more clear in the docs as I spent a lot of time trying to troubleshoot this.

I can reproduce this on master 2a9dd654b as well:

Testing project for master: ReflectionProbe_1.zip


add lazy env

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (e10e7ba) 100.00% compared to head (b8da24b) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##            master       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         9    +1
  Lines          331       379   +48
  Branches        51        51
=========================================
+ Hits           331       379   +48

Files Changed
Coverage Δ

cabina/__init__.py
100.00% <100.00%> (ø)

cabina/_environment.py
100.00% <100.00%> (ø)

cabina/_lazy_environment.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


build 2.10.0

PKG-3195
Upstream requirements

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:40: invalid_url: https://innovation.alteryx.com/natural-language-processing-featuretools : Not reachable: 403
ERROR: clone/recipe/meta.yaml:75: invalid_url: https://innovation.alteryx.com/natural-language-processing-featuretools : Not reachable: 403
Errors were found


[ComponentName] bug_title

What package is this for?

[x] React
[ ] Angular

Describe the bug
If you manage views and in the modal uncheck “display public views”, close the modal, then open up manage views again, it stays unchecked but public views are show.
https://next.carbon-addons-iot-react.com/?path=/story/1-watson-iot-table-statefultable--stateful-example-with-create-save-views
To Reproduce
Steps to reproduce the behavior:

Go to Manage views
uncheck "display public view"
close modal
open mange views again

Please create a reduced test case in CodeSandbox:
https://codesandbox.io/s/github/carbon-design-system/carbon-addons-iot-react/tree/next/packages/react/examples/codesandbox

Expected behavior
The list would follow whatever the checkmark says
Environment/versions:

OS: Mac
Browser: Firefox
carbon-addons-iot-react version: [e.g. v2.60.0]

Additional context

Add any other context about the problem here.
Specific timeline issues / requests
Do you want this work within a specific time period? Is it related to an
upcoming release?
NB: The core contributors will try to work with your timeline, but it's not
guaranteed. The earlier you make a request in advance of a desired delivery
date, the better!

Will be solved by https://github.com/carbon-design-system/carbon-addons-iot-react/issues/3234

Will be solved by #3234 This is a bug in the Storybook story and not the actual component.

Ok thanks.
@dianatran18 Asked me to log this one


Putting the content of the docs at more logical places.

Guys, I hope I'm not messing up a lot of people, but I felt the docs weren't as usable as I'd like. I've changed it a fair bit and I'd like your opinion. Feel free to set it all aside, it's been not as much work as it looks like. I've added a PR where you can find it all: #513

Thanks @Alber70g, let's discuss this on #513 then! 👋


Current master branch does not detect optional parameter

public async Task<Models.V1.Item> Get(int id, string itemName = null, CancellationToken? cancellationToken = null) { /* ... */ }
results in all parameters required.

I'm unable to repro this. With the following action signature ...
public async Task<Product> GetById(int id, string itemName = null, CancellationToken? cancellationToken = null);

I get the following description with itemName and cancellationToken "not" required:

As a side note, I'm guessing you don't even want to display the CancellationToken as a parameter because it's really a server-side detail and not part of your API. Unfortunately, WebApi's built-in metadata layer (used by SB) still includes it in Api descriptions. But you could easily remove it by creating a simple IOperationFilter (see readme). See a related issue #306

I try it with from codebase 07f48b3. No luck...

Is this still an issue with 5.2.2? As I said, I'm unable to get a repro and without this it's very difficult for me to troubleshoot your issue

Closing due to inactivity. I can't repro.


Add get_hdx_url and get_api_url to Dataset and Resource

Needed for HAPI Dataset and Resource tables

coverage: 98.555% (-0.1%) from 98.65% when pulling 6cf1a028c4ba2dce212f71ad4ecda007ec9f42e6 on hdx_api_urls into 2bc171063be0e28c746cd69b18238c006c36d0ab on main.

@turnerm Wasn't sure best way to tag you on this so added you as reviewer but will merge without your approval as agreed


All the Carousel Webparts are giving issues

Hi,
This morning I started facing this issue where I am not able to edit and save any of the properties of the carousel webparts. It won't allow me to add/edit items in the webpart nor can I save my changes and publish the page.
Any idea what might going wrong here?

Same thing here. It happened two weeks ago but the problem seemed to be solved 2 days later. However the problem occured today again.

I am facing the same issue, have you had solutions ?

Learn spfx and build your own webparts
On Wed, Jun 19, 2024 at 9:27 AM ljensomo @.***> wrote:

I am facing the same issue, have you had solutions ?
—
Reply to this email directly, view it on GitHub
https://github.com/OlivierCC/spfx-40-fantastics/issues/115#issuecomment-2177946702,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGIOQ6TAOXFWSWD42RD6EGDZIEXGTAVCNFSM6AAAAABJRO324GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZXHE2DMNZQGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Update Dependencies.cmake

changed boost_USE_STATIC_LIBS to ON
Due to cmake update i guess Boost is not found on OSX.
Suddenly Boost is not found when set to OFF.
Is there any conflict with win / Linux ?

Now the linker needs libboost_python37.a and lib boost_numpy37.a instead of
libboost_python.a and libboost_numpy.a ...will update dependencies

updated MacDistFiles and azure build.sh


net/http: Content-Type is set even with empty body

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version devel +1948b7f Wed May 31 10:28:05 2017 +0000 linux/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/tw/golib"
GORACE=""
GOROOT="/home/tw/goroot"
GOTOOLDIR="/home/tw/goroot/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build555764928=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config
What did you do?
package main

import (
        "fmt"
        "log"
        "net/http"
        "net/http/httptest"
        "net/http/httputil"
        "net/url"
)

func main() {
        backendServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
                w.WriteHeader(http.StatusOK)
        }))
        defer backendServer.Close()

        rpURL, err := url.Parse(backendServer.URL)
        if err != nil {
                log.Fatal(err)
        }
        frontendProxy := httptest.NewServer(httputil.NewSingleHostReverseProxy(rpURL))
        defer frontendProxy.Close()

        resp, err := http.Get(frontendProxy.URL)
        if err != nil {
                log.Fatal(err)
        }

        fmt.Printf("response header: %#v\n", resp.Header)
}

What did you expect to see?
Content-Type should not be set with empty content.
What did you see instead?
Content-Type is set automatically by Go http server.
response header: http.Header{"Content-Length":[]string{"0"}, "Content-Type":[]string{"text/plain; charset=utf-8"}, "Date":[]string{"Sat, 24 Jun 2017 05:18:32 GMT"}}

I suppose this patch should work:
diff --git a/src/net/http/server.go b/src/net/http/server.go
index add05c2..a48b88b 100644
--- a/src/net/http/server.go
+++ b/src/net/http/server.go
@@ -1304,7 +1304,7 @@ func (cw *chunkWriter) writeHeader(p []byte) {
        if bodyAllowedForStatus(code) {
                // If no content type, apply sniffing algorithm to body.
                _, haveType := header["Content-Type"]
-               if !haveType && !hasTE {
+               if !haveType && !hasTE && len(p) > 0 {
                        setHeader.contentType = DetectContentType(p)
                }
        } else {

Any thoughts ?

Sure, seems fine to change. It's harmless as-is and not wrong, but not sending it saves some bandwidth at least.
Feel free to send a change + test: see https://tip.golang.org/doc/contribute.html

@bradfitz  Yes, it's alright in most cases, but some clients don't expect this header when they encounter a response with a empty blank. I find this when resolving this caddy issue.


[Bug report] Code block performs poorly when its bg color is similar to the theme's bg color.

Description
Currently, code highlighting plugins support applying different background colors to code blocks based on various highlighting themes. However, when the background color of the code block is similar to or even the same as the theme background color, it becomes difficult to distinguish the code block from other content, resulting in a poor visual presentation.
For example, when using @vuepress/plugin-shiki with github-light, the background color of the code blocks is #fff, which is consistent with the theme's background color. The appearance at this time is as follows:

Reproduction

Used Package Manager
npm
System Info
-

We need solutions for situations like this:

How to identify when such problems occur;
Change the background color of the code block or add a border.

Though  shiki plugin may understand the background color of each theme, but it still can not understand how --vp-c-bg differs with shiki background.
In a pervious patch, we already set --code-c-bg with higher priority, so that developers and users should be able to override code block color to another value, or add border with extra css.
So I don't think there is anything that a plugin should do.


adding automatic generated migration file

i had a problem when using the makemigrations django command, which failed at being able to write the appended migration file to the installed location in the system. this commit just adds what (my) django 1.8 makemigrations created when running with the appropriate permissions. i don't know whether or not this introduces any problems, it worked flawlessly on my installation setup, the error on makemigrations is gone and migrate applies cleanly.

Thanks @tiberius, I think this might be some Python 2 / 3 differences in the master migrations file. I'll have a dig into this.

:+1:
I needed this same migration when running Python 3.4/Django 1.8.3.

Migration for request.method is unnecessary (see #79).

Fixed in #79


decimal:fix bug caused by do_mul

What have you changed? (mandatory)
This PR fix bug in the function do_mul of decimal,
The master will panic in the following case:
0.00000000000000*0.000000000000000000000000000000000000000000000000000000000000000

What are the type of the changes? (mandatory)

Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)
unit test
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
no
Does this PR affect tidb-ansible update? (mandatory)
no
Refer to a related PR or issue link (optional)
https://github.com/pingcap/tikv/pull/3190
The related code in tidb: https://github.com/pingcap/tidb/blob/master/types/mydecimal.go#L1725

/run-integration-tests

LGTM

ping @AndreMouche


ARROW-16294: [C++] Improve performance of parquet readahead

Turns out the batch size we were slicing internally for parquet (in the TableBatchReader) was not the batch size from the scanner.  I added batch slicing in file_parquet to leave the parquet reader itself more or less unchanged here (and it's not clear it would make more sense to use the smaller batch size slicing inside the reader anyways).
Changed parquet readahead so it reads ahead more than one row group.  It now tries to keep batch_size * batch_readahead reads in flight.  Users that want more parallel reads can increase batch readahead.

Looks like there's a lint failure, and MSVC is unhappy as usual:

The dangers of thinking I can fix an MSVC complaint using Github's edit feature :laughing:
I think this is good now.  I changed the variable itself to int64_t instead of adding static_cast since it is now a "rows" variable and not a "batches" variable.
The behavior for 0 readahead is now "fetch batch when asked for" instead of defaulting to something like 1 row (which probably would have been the same thing anyways but I think this is more clear about our intentions).


Bump premajor version to v3.0.0-alpha.0

As part of #T303503 we would like to use a Vue3 version of some of the Wikit components, created in the next branch.

I think we should also change the two 2.1.0-alpha.12 versions in vue-components/package-lock.json (related to wikit-tokens) to 3.0.0-alpha.0.


added gittuf

Description of changes

added gittuf
gittuf can be used to ensure integrity properties of git repositories.
It is based on academic research and promoted by the linux foundation: https://openssf.org/blog/2024/01/18/introducing-gittuf-a-security-layer-for-git-repositories/
website: https://gittuf.dev/
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 285801 run on aarch64-linux 1

1 package built:

gittuf

Hi, can you rename your first commit to maintainers: add flandweber ?
Reviewed points

[x] package path fits guidelines
[x] package name fits guidelines
[x] package version fits guidelines
[x] package builds on aarch64
[x] executables tested on aarch64
[x] meta.description is set and fits guidelines
[x] meta.license fits upstream license
[ ] meta.platforms is set
[x] meta.maintainers is set
[x] build time only dependencies are declared in nativeBuildInputs
[x] source is fetched using the appropriate function
[x] the list of phases is not overridden
[x] when a phase (like installPhase) is overridden it starts with runHook preInstall and ends with runHook postInstall.

Possible improvements
Comments
$ gittuf clone https://github.com/gittuf/gittuf.git -b master
Error: unable to clone repository
reference not found

$ gittuf clone https://github.com/gittuf/gittuf.git
Error: unable to clone repository
couldn't find remote ref "refs/gittuf/reference-state-log"

I don't know what's going on, is it supposed to work like that?

On https://gittuf.dev/ i see

Current Status
gittuf is currently in alpha. Please do not use it in a production system or repository.

Hi! gittuf maintainer here.

I don't know what's going on, is it supposed to work like that?

Yes, we're currently not securing gittuf's repository with gittuf, but the plan is to start soon (https://github.com/gittuf/gittuf/blob/main/docs/roadmap.md#dogfood-gittuf).
You can try gittuf clone on our ci-demo repo here: https://github.com/gittuf/ci-demo.
Also, we plan to move from alpha soon as we are beginning to work on how different repositories (including the gittuf repo itself) can start using gittuf.

Looks ok to me

Result of nixpkgs-review pr 285801 run on x86_64-darwin 1

1 package built:

gittuf

I guess we should not install cli binary:
$ results/gittuf/bin/cli -h
Generate help docs

Usage:
  gendoc [flags]

Flags:
  -d, --dir string   Path to directory in which to generate docs (default ".")
  -h, --help         help for gendoc

version should be set properly:
$ results/gittuf/bin/gittuf version
gittuf version devel

I guess we should not install cli binary:

Do you have a better way than removing it in postInstall?

I guess we should not install cli binary:

Do you have a better way than removing it in postInstall?

Removing in postInstall is just fine.


Provide an '-r' command-line option

This minor enhancement allows to run the generated output directly from colm,
so programs can be compiled & executed in with just one command. The colm
process will be replaced by the called binary.

Thanks! I modified it to use NULL as the sentinal. Seems newer gcc will warn if you use 0. I wasn't aware of that.

I'm not sure what current github etiquette is. Would you prefer I just make the necessary changes myself, or send it back to you? The former is certainly more efficient, however perhaps the latter more customary.

I'm not sure what current github etiquette is. Would you prefer I just make the necessary changes myself, or send it back to you? The former is certainly more efficient, however perhaps the latter more customary.

Hi @ehdtee, I think this decision is on yours as you're author and project maintainer of COLM. I would also prefer first way, change whatever you wish to change without any further revision.

I modified it to use NULL as the sentinal. Seems newer gcc will warn if you use 0. I wasn't aware of that.

Normally I would use NULL also, but I thought that using just 0 is more near on your coding conventions inside the whole project.
More to come, I've found several other issues that can be improved. Thanks!


Unintuitive out-of-memory error message

Out-of-memory isn't properly handled, see #236.
Error reports include:
Error in `python': free(): invalid next size (normal): 0x000000000dfff920 ***
Aborted (core dumped)

Error in `python': free(): invalid pointer: 0x0000000005fff4a8 ***

Thanks. Definitely agree that there's a problem here.
Likely candidates are the raw calls to PyMem_Malloc and PyMem_Realloc in thinc. Mostly memory allocation goes via the cymem library, which I believe is checking status codes correctly.


Fix - sdkVersion 16 - default can be overriden

Changes
https://github.com/cunarist/rinf/issues/355
Fix
This is a small patch to allow for the parent package to override the sdkVersions

CI is telling us where the error is coming from:
[        ] A problem occurred evaluating project ':rinf'.
[        ] > No signature of method: static java.lang.Math.max() is applicable for argument types: (null, null, Integer) values: [null, null, 31]
[        ]   Possible solutions: max(int, int), max(double, double), max(float, float), max(long, long), wait(), any()

I'll update the PR to make it work :)


Read Google Drive directories concurrently

This PR will read Google drive directories concurrently.
Maximum connection handling is moved to the "pacer", and removed from ACD.
It seems like root drive listing is handled elsewhere, but that performs really well, so I have not done anything to change that.

This fixes #143 if used with "-v".  We could still add a more generic progress display for file listing.

Putting the concurrency control inside the pacer is a great idea.
I did a bit of testing with drive and it speeds my directory listings up by a factor of 3.5!
There is a way of listing everything on drive so we use that for the root directory listing.
Here is a comparison of the root directory listing
$ rclone ls drive: > 0

Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:       19.1s

$ rclone --drive-full-list=false ls drive: > 1

Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:        7.5s

$ diff <(sort <0) <(sort <1)

Whether it is faster or slower will depend on your drive contents I think...
I've merged that - thanks!

Thinking about this futher, it is short selling the concurrency in the sync phase slightly which is supposed to be config.Transfers and cofig.Checkers....  So the default could be config.Transfers+config.Checkers which over sells the concurrency in the listing phase, but I'd be happy with that.


[Task] Update Gaia's profile on the OC Team page

What product(s) is this story for?
OpenChallenges
As a user, I want
No response
Description
@gaiaandreoletti has accepted the role of OC Data Lead. The goal of this task is to reflect this change to the Team page.

Place Gaia in second position after me
Update Gaia's title to "Data Lead"
Update Thomas' title to "Team Lead"
Capitalize the other titles

Acceptance criteria
No response
Tasks
No response
Anything else?
No response
Have you linked this story to a GitHub Project?

[X] I have linked this story to a GitHub Project and set its metadata.

This should be trivial to complete - will try to do so in the May sprint.

Added to Sprint 24.5


Reserved Documentation Ranges

There are ranges of IPs reserved solely for use in documentation.
The isValid will return true for these ranges. Is this expected behaviour, or would it be useful to have another method to check for these IPs?
IPv4 Ranges, reference:

<IP_ADDRESS>/24
<IP_ADDRESS>/24
<IP_ADDRESS>/24

IPv6 Ranges, reference:

2001:DB8::/32

Yes, its ok


Building on CentOS

The build script for CentOS could not build the man pages on CentOS 6 since ruby 2 is not available. However, there is a way to get ruby via the RVM. That has been added in so that CentOS 6 can build the man pages using this script
Getting golang on CentOS 5 isn't really a "supported" idea, but I looked into a number of work arounds and settled on the simplest one. I saw it mentioned in the comments and gave it a try. If you would rather say NO to CentOS 5, I can remove that, but I can also say that this will build and run git-lfs on a a CentOS 5 Machine (Tested on a 5.11 VM).
Also add the ability to use a currently cloned version of git-lfs, so it does not always clone into /tmp

As someone that doesn't use CentOS, and is not even much of a devops person, PRs like this are difficult to review.  I'll probably ping you on any issues we get on these scripts, so I'd love any further help you can provide.  I think eventually I'd like to setup some VMs for running QA checks on stuff like this before we release.
/cc @jsh, author of the CentOS install script.

@technoweenie Not a problem. Just let me know when you got an issue, and I'll see if I can help. CentOS is my primary OS of choice ;) So I'm definitely testing that!

@andyneff: can you confirm this works with master?  We've made some major changes (see #345). Looks like it should just work though.

@technoweenie You'll have to forgive me relative lack of experience with go, but... Now that you've removed the symlink, how is this supposed to build now?
on 47f735098b626d3d5536f907adbdc88a590e8170, scripts/bootstrap fails stating
script/build.go:13:2: cannot find package "github.com/github/git-lfs/lfs" in any of:
        /usr/lib/golang/src/github.com/github/git-lfs/lfs (from $GOROOT)
        ($GOPATH not set

which is the import ("github.com/github/git-lfs/commands") line. So... where is that import?
Centos 7.1.1503 (should be the easiest case)

Gah, I should add this to the readme or contributing guide. Go projects expect you to clone the repository to $GOPATH. Its directory tree should look like this:
- src
  - github.com
    - github
      - git-lfs
- pkg
  (go build artifacts)
- bin
  (compiled go apps)
...

I just use $HOME/go as my GOPATH.

Here's a great way to get started hacking on Git LFS, and really any Go project:

Install Go 1.3+
Make sure $GOPATH is set (I use $HOME/go).
Run go get github.com/github/git-lfs.
Optional: Symlink $GOPATH/src/github.com/github/git-lfs to your project directory if you have one.

Well... Thank you for the hand holding, I needed it apparently... let me just rant say that IS a paradigm I'm not used to, the repo != the build structure... And using golang like that enforces that... (by checking out the repo into this other build structure)... I do not like... but that is not a discussion for git-lfs, it looks like that is golang's fault.
So this brings me to the inevitable question now, what is the purpose/scope of these scripts? Because BEFORE, they had two features (intended or not)

I could git clone the repo, and run that script, and everything builds
I could download JUST the script, it clones the repo for me, and everything builds

But as I see it now, the only course of action is to
a) Follow the 5 steps @technoweenie Gave me, and then run it and it will work
Which makes lines 37-39 pointless (in their current state)
So what do you want this to do now?

You're right, the new setup is a bit of a regression. Getting this to actually work on Windows (no more symlinking) is worth it IMO.
I would say option 1 is the primary goal of these scripts.

@technoweenie Ok, I have 1 working again. I went ahead add took your suggested optional step 4 and added a symlink myself. I guess whomever writes a similar windows script could do the same thing, but with a junction? Just guessing. At any rate, it all works now.


Implement Hoodie Event callbacks

This is needed for an external monitoring system looking to get events on hoodie.

Hi @prazanna, I have a PR ready for this. Could you please assign this to me? Thanks.

Done , merged


Improve Documentation

Add a short introduction about why it helps to know a bit about the concept of binds
have a more detailed page about how binding process works (bootstrapping)

Right now tests are the documentation.


Roadmap

After the initial release, there are few suggestions/improvements to be made!

[ ] #85
[x] #84
[ ] Implement folders to some degree?
[x] #83
[x] Editor - images inline with text

The main task for now is to rewrite the frontend, as it's full of hackarounds and things that are funky to say the least, mainly depending on the initial V1 MVP and concepts from the old backend

replaced by #185


Update csv email

Can be done after or with the django update. The CSV download email can use an update. Suggestions:

Use the SITE_NAME from settings rather than hard-coding 'I-analyzer'
Update the organisation name (currently Digital Humanities Lab) - also make this configurable in settings?
Update the logo link in settings (or just update the image on dhstatic)
Add a link to the downloads page.
The downloads page currently offers options that the direct download link doesn't, like excel-friendly encoding. Two possible solutions:

Change the email so it presents the link to the download history as the primary option, encouraging users to download through there.
The direct download link in the email should not lead to the API, but to a frontend page that offers download options.

The plain text version is messy and does not include the actual link. This is an issue for unit testing, as well as accessibility.
I would not be opposed to simplifying the HTML for a more readable template and more plain-looking email.

The organisation name and logo have been updated (#1165), other points are still "to do".

The downloads page currently offers options that the direct download link doesn't, like excel-friendly encoding. Two possible solutions:

Change the email so it presents the link to the download history as the primary option, encouraging users to download through there.
The direct download link in the email should not lead to the API, but to a frontend page that offers download options.

See also #1495 : if we want to send CSV downloads to users without an account, the email can't link to their download history, so a frontend page for that specific download is probably a better solution.
For authenticated users, the e-mail should still include a link to the user's download overview, though.


Get permission for 11471-KAO

The mod page for 11471-KAO states the following:

Modification permission
You must get permission from me before you are allowed to modify my files to improve it

We should get explicit permission to make compatibility patches.

Asked for permission here.

Permission granted here.


No license attributed with the repo

Would you consider adding a license? Either MIT or GNU?

Hey, thanks for mentioning this. I've added an MIT license to this repository.


TS 4.1 should support require with nested binding patterns

prettier uses nested binding patterns to import multiple things from "namespaces":
Code
const {
  builders: {
    concat,
    join
  },
  utils: {
    nub,
    intercalate
  }
} = require('../document')

(Identifier names have been changed to make fun of Haskell.)
Expected behavior:
nub :: Eq a => [a] -> [a]
Actual behavior:
error "Module '../document' has no exported member 'nub'.", and nub: any.
This worked before switching const x = require to create real aliases, and needs to work afterwards.

Update from surveying user tests for this pattern:

Prettier uses it in 21 places, all from document.js. Maybe they're treating it like an index.js?
Eslint and discord use it once each.
Webpack has 2 tests that use it.

I'm still running my survey on js files from DefinitelyTyped. It's a lot slower than grep since I'm using naive AST-walking search.

We can re-open this if prettier wants it, or if somebody else starts using this pattern (they shouldn't, it's a bad idea).

Hi @sandersn please see this PR: https://github.com/prettier/prettier/pull/9207
Unfortunately I had to apply some ugly workaround hacks to get Prettier's typecheck to work with typescript 4.1.0-dev.20200915. I think this is not something we want to apply unless absolutely necessary.
I suspect that this would be a very small corner case, maybe needs a new issue?

Yep, looks like a separate bug from this one -- and hopefully a minor one -- so I filed #40578 to track it. Thanks for checking this out!


Add crypto currency mining donation button as an example

@nayafia amazing guide! I wish I had this when I was getting started in open source. Thank you for creating it for the community.
I added a new section for consideration.
It is a futuristic concept (but I think valuable in the near future) - the user donates to an open source project by donating CPU cycles. Those CPU cycles are used to generate crypto currency.
What is neat about it, is it makes it possible to accept donations worldwide and with relatively less friction. The donor doesn't need a credit card or even a bank account. And the project benefitting from the donations does not need a merchant account.
What do you think?
Here's an example of a donation page: http://www.opensourcecitizen.org/project?url=github.com%2Fmotdotla%2Fnode-lambda
And an example of the README badge: https://github.com/motdotla/node-lambda-template

Hey @motdotla, thanks for the kind words!
This is a really cool funding mechanism that I hadn't seen before. I'm hesitant to add it as a dedicated section, because it isn't yet in widespread use. There aren't many examples of providers, nor are there many examples of open source projects that are using it. (I didn't add the freemium license or advertising sections, for example, until I saw enough examples of them in the wild.)
Wish there was a section to keep "Experiments" or "Crazy ideas" :smile: but even that feels a bit editorialized to me. Thanks for flagging it. If it keeps coming up, I'll consider adding a new section.

Makes good sense. Thank you for considering it!


Include interactiveEditor.editMode in settingsLayout.ts

[warning] SettingsEditor2: Settings not included in settingsLayout.ts: interactiveEditor.editMode, accessibility.verbosity.diff-editor, accessibility.verbosity.terminal

@rzhao271 can you help me understand what this means and what needs to be done

Duplicate of https://github.com/microsoft/vscode/issues/181084

@rzhao271 not a dupe


More webpack5 - more(?) sourcemaps

Fixes #32
webpack5 compiles the plugin but screens do not appear. I have a weird CSP warning, that does not go away but might not have anything to do with the screens.
devtool needs to be re-enabled (one of the causes of #23  ) as well as loads of removed path.joins (forgive me)

Can someone test this? I think this is now running BUT:

without hot-reloading. that package seems to be unmaintained and not getting any updates. Can we do that somehow without that package?

for me the plugin does compile but not do a thing :/

Plugin Verwaltung:
Uncaught ReferenceError: browser is not defined
Kontext
_generated_background_page.html
Stacktrace
js/background.bundle.js:92503 (Anonyme Funktion)

browser.storage.onChanged.addListener(function (changes) {
...

this must be related to that "RTFM" thing here: https://github.com/mozilla/webextension-polyfill/issues/5 - I guess I still don't get it.. checking :)

why don't we want this: https://github.com/mozilla/webextension-polyfill#basic-setup-with-module-bundlers ?

why don't we want this: https://github.com/mozilla/webextension-polyfill#basic-setup-with-module-bundlers ?

yeah seems like the compiler warnings are gone now when re-adding var browser = require("webextension-polyfill"); everywhere

update and it seems to work for me.

Works for me , hot reloads for me. Cool to merge!


Broker fix

Description of the Change
Remove api change of broker fixup and fix bugs within current iroha_actor api.
Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

I would suggest using a more descriptive PR name: Remove subscription id from actor public API. Or something like that.
Also there are no bugs currently... So the description is incorrect.

This is rather strange, did you simply revert the previous commit? Maybe it is better to change the things that we agreed that might be improved in API, but not to revert everything?


Feature/issue 1046 fake redis expire response error with non int values

Left a minor comment. We also need to fix all the tests that now fail though. :(


How do I kill an account?

Hi! How do I transfer all funds from one account to another?

Okay, I would use the extrinsic call transfer for that, now if you mean something like transfer max there isn't such a method which would calculate the max amount including the fees.
Maybe this can help https://www.shawntabrizi.com/substrate/substrate-weight-and-fees/

Here Dans answer to the max amount:

<@darkfriend77:matrix.org> Short question is there something like transfer max amount from one account to another, and having the amount including the fees to max.

yes, but afaik there is no easy UI to do this officially
https://polkadot.js.org/docs/api/start/api.tx.subs#payment-information
you can do a (hypothetical) create -> check fees -> create actual tx = total ballance - fees -> (optional) check fees match with real tx -> send tx

Thanks! This method works

👍


Can't talk to my Telegram bot using the Telegram notifier

Expected behaviour:
Flexget sends messages via Telegram to my bot.
Actual behaviour:

no chat id found, try manually sending the bot any message to initialize the chat

Steps to reproduce:

Step 1: Create a Telegram bot
Step 2: Get the API key via BotFather.
Step 3: Send a message to the bot from foo user (direct chat)
Step 4: Configure Flexget as follows

Config:
templates:
 ...
  notifyseries:
    notify:
      entries:
        title: "A new episode of {{series_name}} is ready!"
        message: "{{series_id}} ({{quality}})"
        via:
          - telegram:
              bot_token: '{? tg.token ?}'
              recipients:
                - username: '{? tg.myself ?}'

Then use the template in a task classifying files, like:
  sortseries:
    priority: 10
    no_entries_ok: yes
    metainfo_series: yes
    accept_all: yes
    filesystem:
      path: "{? paths.torrent_base ?}/downloads"
      recursive: 3
      retrieve: files
      regexp: '.*\.(avi|mkv|mp4|m4v|ts)$'
    regexp:
      reject:
        - sample
    require_field: series_name
    thetvdb_lookup: yes
    copy:
      to: "{? paths.media_base ?}/Shows/{{tvdb_series_name|default(series_name)}}/Season {{series_season}}/"
    template:
      - notifyseries
      - refreshkodi

tg.myself is a secret, set to foo which is my Telegram username.
Log:
2023-10-09 17:27:51 ERROR    notify_entry  sortseries no chat id found, try manually sending the bot any message to initialize the chat
Additional information:

FlexGet version: Official container image, Flexget version 3.9.10. Nothing Telegram-related in https://github.com/Flexget/Flexget/compare/v3.9.10...v3.9.12

I use the bot from Home assistant too and I can see messages sent to it that way. As mentioned, I have sent several messages using user foo to the bot.
Thanks in advance for any insights.

I created a brand new bot and it worked. No idea.


Can't restart SM after log rolls

The supervisor can't restart SecurityMonkey after the log rolls.
Error in supervisor log:
ValueError: Unable to configure handler 'file': [Errno 13] Permission denied: '/var/log/security_monkey/securitymonkey.log'
When the log rolls to .1, the new log file is created with ubuntu:ubuntu permission instead of ubuntu:www-data
ubuntu@ip-10-0-1-56:/var/log/security_monkey$ ls -alrt
total 10544
drwxrwxr-x 12 root   syslog       4096 Aug 25 01:17 ..
-rw-rw-r--  1 ubuntu www-data 10485725 Aug 25 17:22 securitymonkey.log.1
-rw-rw-r--  1 ubuntu ubuntu        159 Aug 25 17:23 securitymonkey.log
drwxr-xr-x  2 ubuntu www-data     4096 Aug 25 17:23 .
-rw-r--r--  1 root   root         2273 Aug 25 20:37 security_monkey.error.log
-rw-r--r--  1 root   root       284133 Aug 25 20:37 security_monkey.access.log
I believe this is causing the error. If I rerun the command from the setup instructions:
sudo chown -R whoami:www-data /var/log/security_monkey/
then it can restart without a problem.
I believe a sudo chmod g+s /var/log/security_monkey will help.

I believe @mcpeak did some work in this area.  Tagging him for any comments. I think there was a modification to the flask logger that wold set group permissions or something.

In config you should be able to use logging.handlers.GroupWriteRotatingFileHandler instead of logging.handlers.RotatingFileHandler.  This will make it so the newly created files have group-writable, which should mitigate this problem.  Let me know if this doesn't work.

@kur3us - Are you using the quickstart setup or did you customize the permissions to have it run in the www-data group?

I used the quickstart setup.

I'm also seeing errors like this in /var/log/supervisor/securitymonkeyscheduler-stderr---supervisor-GE6Imt.log:
Logged from file watcher.py, line 626
Traceback (most recent call last):
  File "/usr/lib/python2.7/logging/handlers.py", line 77, in emit
    self.doRollover()
  File "/usr/local/src/security_monkey/security_monkey/__init__.py", line 254, in doRollover
    handlers.RotatingFileHandler.doRollover(self)
  File "/usr/lib/python2.7/logging/handlers.py", line 136, in doRollover
    os.rename(sfn, dfn)
OSError: [Errno 13] Permission denied
Logged from file peering.py, line 68
Traceback (most recent call last):
  File "/usr/lib/python2.7/logging/handlers.py", line 77, in emit
    self.doRollover()
  File "/usr/local/src/security_monkey/security_monkey/__init__.py", line 254, in doRollover
    handlers.RotatingFileHandler.doRollover(self)
  File "/usr/lib/python2.7/logging/handlers.py", line 136, in doRollover
    os.rename(sfn, dfn)
OSError: [Errno 13] Permission denied
Logged from file peering.py, line 62

With respect to  @mcpeak 's comment, it looks like the config file IS using logging.handlers.GroupWriteRotatingFileHandler.

OK, since group write is on, you should be able to make this work if you add ubuntu as a member of www-data.  The GroupWriteRotatingFileHandler makes it so that you have g+w.

@mcpeak, I added ubuntu to the group. There is one more thing that needs to be done. In the quickstart guide, it says to run these commands:
sudo mkdir /var/log/security_monkey
sudo chown -R `whoami`:www-data /var/log/security_monkey/

That creates a directory with these permissions:
drwxr-xr-x  2 ubuntu www-data 4096 Aug 31 03:53 .
The log rolling moves the current file to a .1, and then creates a new file that looks like this:
-rw-rw-r-- 1 www-data www-data  1273655 Aug 31 04:01 securitymonkey.log
So the Security Monkey process is running as "www-data", but the directory is owned by "ubuntu", and the group permission for write is not set.
So I think this command must also be done:
chmod 775 /var/log/security_monkey/
As soon as I did that, the errors in the supervisor log stopped, and a the securitymonkey logs rolled successfully.


n5010-test: Split ddr test mode into ddr-prbs and ddr-directed

Coverage decreased (-0.09%) to 60.864% when pulling 40c10394572f4f340bd8265fd922a0cd81dd359c on rchriste/n5010-test-update into c9da064787e670925cf6030909ba4ac496c80437 on master.


Investigate usability of "micro" package

In order to make further steps, we have to understand whether or not Finch will be focused on "micro" style.

Is there a simple way to combine simple RouteN with PRequestReader within one route?
Something like

val filterReader = param("name") ~ param("sort") ~> SomeFilter
...
Get / "catalog" / "page" / int ~ filterReader /> someFn
...
def someFn(page: Int)(filter: SomeFilter)`

it would be super useful to process requests with params from route, payload etc with just one line

It's totally possible. You can look at playground example. The idea is following:

You can route request directly to Micro if there is no route params
You can route request to a function that return Micro if there are router params

val get10: Micro[Int] = Micro.value(10)
def get10xA(a: Int): Micro[Int] = Micro.value(10 * a)

val endpoint =
  Get / "10" /> get10 |
  Get / "10/ "x" / int /> get10xA

Sorry, I probably wasn't clear. For now the only way to do it is to deal with type RouterN[Micro[A]], which is a RouterN composed with Micro and called Endpoint. Is it something that you wanted @ImLiar?

Well, probably it is. I got sick a little, so I'll check it out later. Thx @vkostyukov

Hi, I've been (briefly) fooling around with Micro and what's hard to get (for me) is how to write functions and then sort of attach them to Finch endpoints.
I found your playground example a little bit too much in that it also deals with filters and custom requests and so on.
If I don't look at that I can only find simpler example (like this get10 and get10xA one).
This basically shows how you can use Micro.value and just have your stuff in there.
Now suppose I have some code that does some computation... say
def getAge(userId: Int): Future[Int] = { /* some code returning a Future[Int] */ }
How do I attach it my Get / "age" /> thingie?
Do I JUST wrap the function call inside a Micro.value? Is that it?

Hi @mfirry!
Thanks for the feedback!
There is probably no docs for this, but there are 2 new combinators described in release notes: ~> and ~~> that allow you to compose Micro[A] with A => B and A => Future[B] correspodningly.
You'r example would look something like this:
def getAge(userId: Int): Future[Int] = ???
val endpoint = Get / "age" /> (param("userId") ~~> getAge)

Awesome! Thanks so much.

Howdy, I got the chance to dive into the Micro stye pretty heavily at the end of last week - I'm looking at this style for my next project.  Two things:
1.) When I first started playing w/ it, I got super excited at the ability to compose + separate out business logic. Then after a couple of hours I realized . . .
2.) It feels like the abstraction HttpRequest => (A => B) => HttpResponse  is a bit incomplete at this stage, due to the fact that there is a lot of business logic wrapped into HttpResponse codes.  Perhaps this in overly Rails~y way to view it ( I work in a Rails shop and I've written a bunch of it ), but the heavily resource biased style of an API is what I'm used to working with ( and to be honest, it's what I expect from an API I consume ).  I'm not sure that EncodeResponse[B] is powerful enough to handle all the ( normal ) response codes I would like to provide beyond
b match {
  case Some(b) => return Ok(b)
  case None    => return NotFound
}

As I sit here w/out an coffee this morning, in my head if feels like the abstraction needs to be closer to the form HttpRequest => ( A => HttpResponseCode[B] ) => HttpResponse.  Of course, it's entirely possible I'm not seeing the full jigsaw puzzle. However, the vast majority of the time when I'm working on an API my initial thought is, "What is the proper response code to this request"?
I do want to reiterate that I love this style and I fully agree this is where Finch needs to be going. I'm deeply appreciative of this project.

Hi @penland365!
Thanks a ton for this feedback!
It's true. You thoughts are similar to mine. That's why there is a ticket about a heterogeneous router (see #221). The motivation for that is basically to provide users more flexibility on what is the proper response. (and this is exactly what confused you) Within a heterogeneous router we no longer stick to the abstraction HttpRequest => (A => B) => HttResponse - we're going to deal with a function HttpRequest => (A => B). So, you can serialize any B (even an HttpResponse).
Quick example:
val endpoint: Router[User :: HttpResponse :: HNil] =
  Get / "users" /> User(10) ::
  Get / "health" /> Created.withHeaders("X" -> 10)()

@travisbrown and I are thinking about this right now and I hope we will ship something in the next release. So, I would suggest you to wait until that and use a heterogeneous router instead of Micro, since the last one will probably die soon (will be deprecated in 0.7.0).

@vkostyukov Thanks for the reply!  I had typed up a response earlier, then went to eat lunch and forgot about it. Yeah, the heterogeneous router feels a little closer to what I was mulling over this morning.

Micro is going to be deprecated in 0.7.0 since it was probably a bad idea. The current big thing that replacing Micro is Heterogenous Routers #221.


bugfix:fix seata-spring-boot-starter does not work

Ⅰ. Describe what this PR did
fix seata-spring-boot-starter does not work.
Ⅱ. Does this pull request fix one issue?

fixes #2027
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done integration testing.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #2029 into develop will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #2029      +/-   ##
=============================================
- Coverage      55.02%   55.01%   -0.02%
- Complexity      2472     2473       +1
=============================================
  Files            444      444
  Lines          14784    14795      +11
  Branches        1746     1747       +1
=============================================
+ Hits            8135     8139       +4
- Misses          5902     5909       +7
  Partials         747      747

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/io/seata/config/FileConfiguration.java
38.65% <33.33%> (-3.02%)
6 <0> (ø)

...server/store/file/FileTransactionStoreManager.java
57.14% <0%> (+0.63%)
30% <0%> (+1%)
:arrow_up:

...very/registry/zk/ZookeeperRegisterServiceImpl.java
63.7% <0%> (+0.8%)
24% <0%> (ø)
:arrow_down:

retry ci


[Design-System] Features

This is a feature list for Design System

[X] Theme
[X] Buttons

[X] Default Button
[X] Secondary Button
[X] Outlined Button
[ ] Circle Button
[ ] With Loading
[ ] With Icon

[ ] Header

[ ] Menu
[ ] Desktop
[ ] Mobile

[ ] Footer

[ ] Desktop
[ ] Mobile

[ ] Typographs

[ ] Title
[ ] Subtitle
[ ] Body
[ ] Text
[ ] Links

[ ] Form

[ ] Input Text
[ ] Input Upload
[ ] Select
[ ] Checkbox
[ ] Radio
[ ] Switch

[ ] Cards
[ ] Images

[ ] Gallery
[ ] Carrousel

[ ] Icons
[ ] Cart
[ ] Checkout
[ ] Wishlist
[ ] Messages (Popover)
[ ] Configure Jest/Enzyme
[ ] Add Addons to Storybook

[ ] Docs
[X] Knobs
[X] Accessibility

Theme
Link figma: https://www.figma.com/file/wm1eayZPzNKapBtg5oE6i3/UI-Challenge-10_12?node-id=0%3A149
Typograph

Font: Proxima Nova

Weight

thin: 100
semiBold: 600
regular: 400
bold: 700
black: 900

Texts

Title: 30px;
Subtitle: 24px;
Body1: 18px;
Body2: 16px;
Text: 14px;

Colors

Primary Light: #1BE0AB

Primary dark: #43FECB

Secondary: #743AF2

Error:  #FF3773

Black: #1F1F24

Black Dark: #27272D

Black Normal: #34353D

Black Light: #484854

Gray: #737380

White: #FFFFFF

Spacing

Here Design-System and Sdk running test at the same time with Lerna! 🎉


Cleanup, and simplify steps.

Codecov Report

Merging #24 into stage1 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           stage1      #24   +/-   ##
=======================================
  Coverage   96.22%   96.22%
=======================================
  Files           2        2
  Lines          53       53
  Branches        5        5
=======================================
  Hits           51       51
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2113c04...796ada8. Read the comment docs.


AbstractProgressParserTest - Fix Generics in list

Coverage increased (+0.5%) to 84.195% when pulling e1e82f22b6d8cb2b956a043987d5651b44cf20c1 on stonio:patch-7 into 99312e3e0a5323cb4db251897fb803ff86ccd389 on bramp:master.


⚠ ClamAV has degraded performance

In 1d45203, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 59 ms

Resolved: ClamAV performance has improved in cf5dccd after 5 minutes.


BUG: Service does not run on Apple silicon Mac

Might just have to update to using policy deployment as @joewxboy updated for web-helloworld-go with this PR: https://github.com/open-horizon-services/web-helloworld-go/pull/14

hi @t-fine can you assign me to this issue?


✨Add mysql support for mysql-connector-python

support mysql connections via the mysql-connector-python dbapi

Codecov Report

Merging #16 (785cc93) into main (4d1d5ee) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 785cc93 differs from pull request most recent head d404eb2. Consider uploading reports for the commit d404eb2 to get more accurate results

@@            Coverage Diff            @@
##              main       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           12        14    +2
  Lines          320       350   +30
  Branches        54        57    +3
=========================================
+ Hits           320       350   +30

Flag
Coverage Δ

3.10
100.00% <100.00%> (ø)

3.7
100.00% <100.00%> (ø)

3.8
100.00% <100.00%> (ø)

3.9
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pydapper/mssql/pymssql.py
100.00% <ø> (ø)

pydapper/__init__.py
100.00% <100.00%> (ø)

pydapper/mysql/__init__.py
100.00% <100.00%> (ø)

pydapper/mysql/mysql_connector_python.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1d5ee...d404eb2. Read the comment docs.


[CI] Updated core workflow for E2E

Signed-off-by: Axit Patel<EMAIL_ADDRESS>Description
This PR fixes  https://github.com/meshery/meshery/issues/5529
Notes for Reviewers
Ports the Cilium to the new core e2e workflow
Signed commits

[x] Yes, I signed my commits.

Required changes have been done @gr455

Signed-off-by: Axit Patel<EMAIL_ADDRESS>Description
This PR fixes meshery/meshery#5529
Notes for Reviewers Ports the Cilium to the new core e2e workflow
Signed commits

[x]  Yes, I signed my commits.

@Akshit42-hue Can you just change 'This PR fixes' to 'This PR is a part of' so that it doesn't close the issue on merge


Circular reference Error | Xcode 11.5

I have read the guidelines for contributing and I understand

[x] My issue is happening in the latest version of SideMenu (older versions are no longer maintained).
[x] My issue was not solved in the README.
[x] My issue can not be answered on stackoverflow.com.
[x] My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.
[x] My issue is reproducible in the demo project.

Describe the bug
I have been using your pod in my swift project built on 11.2.1. Last night I had updated my Xcode and getting the error 'Circular reference' on line 112 of SideMenuNavigationController.swift. I have tried updating pod to newer version (6.4.7 - Auto) but the issue still remains. please check and resolve it asap.
To Reproduce
Steps to reproduce the behavior:
Just install and run sidemenu pod in xcode 11.5 version
Expected behavior
I expect it to not throw the error and run smooth like it was before

Screenshots
Attached a screenshot of issue

As of now I have copied the above SideMenuNavigationController.swift from ver. 6.4.8 and pasted it in my pod file by unlocking the file. I can run the app now but an update will be better sir.


InvalidCleanMethod clean_email2 when using django-allauth

Hi, me again and with an issue very similar to #23
Allauth seems to have an email2 field and a ACCOUNT_SIGNUP_EMAIL_ENTER_TWICE which is false by default, so there is a problematic and useless in my case clean_email2 field, this is my current workaround
from allauth.account.forms import SignupForm

class UserSignupForm(SignupForm):
    # This prevent django-fastdev from raising an error when accessing the signup page
    clean_username = None
    clean_email2 = None

I also don't require the username so the the field is not present on the form
a better idea ?

Yea, this seems like a reasonable approach.

Hi, those methods (clean_password1, clean_password2, clean_email)   exists but in the BaseSignupForm .
@boxed, is it possible to implement these checks in the base classes?

Did you paste the wrong link? Because it doesn't lead to any of those.


Update README.md with application and meeting URL examples

Description of changes:
Provide example of Application output URL and meeting URL with the meeting name as query parameter.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This should be fixed with PR https://github.com/aws-samples/amazon-chime-sdk-recording-demo/pull/23

Sure @anuranduttaroy
Closing this PR since the master branch is updated with PR #23


non threadsafe code in LiteDB/LiteDB/Mapper/Reflection/Reflection.cs

hi ,
In Reflection.cs , you are using Dictionary to store cached reflection results.
We are getting An item with the same key has already been added , when attempting to read from db in several threads.
I suppose that a quick fix would be to switch to ConcurrentDictionary
here
https://github.com/mbdavid/LiteDB/blob/bf5dd3de8e589ca0acfb5ce64cd8eee03ad9f73e/LiteDB/Mapper/Reflection/Reflection.cs#L25
Noticed project is using .NET 3.5
Perhaps this will help
http://www.nuget.org/packages/TaskParallelLibrary
Stack trace:
: Failed to create instance for type 'XXXYYY' from assembly 'XXXYYY, ZZZ, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. Checks if the class has a public constructor with no parameters. ---> System.ArgumentException: An item with the same key has already been added.
at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
at LiteDB.Reflection.CreateInstance(Type type)

+1. I'm having the same bug when two threads are reading from the same collection at the same time.

Another quickfix would be to use a ReaderWriterLockSlim.
see my commit here :
https://github.com/s-ve/LiteDB/commit/339593919f52e2dd2582c38f9c852eb87f91585c

Fix #455

Fix #488


Character literals are not supported - ERROR: invalid character '''

What reproduces the bug? Provide code if possible.
Character literals are described in the user manual as to be enclosed in single quotes, but they don't appear to work. Reproduced with bpftrace v0.20.1 and v0.21.1.
cat<<"EOF" > test.bt
BEGIN {
    $c = 'c';
    printf("Test %c\n", $c);
}
EOF

sudo bpftrace test.bt

test.bt:2:11-12: ERROR: invalid character '''
    $ch = 'a';
          ~
test.bt:2:11-14: ERROR: invalid character '''
    $ch = 'a';
          ~~~

bpftrace --info output
System
  OS: Linux 6.1.0-18-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.76-1 (2024-02-01)
  Arch: x86_64

Build
  version: v0.21.1
  LLVM: 18.1.7
  unsafe probe: no
  bfd: yes
  liblldb (DWARF support): yes
  libsystemd (systemd notify support): no

Kernel helpers
  probe_read: yes
  probe_read_str: yes
  probe_read_user: yes
  probe_read_user_str: yes
  probe_read_kernel: yes
  probe_read_kernel_str: yes
  get_current_cgroup_id: yes
  send_signal: yes
  override_return: no
  get_boot_ns: yes
  dpath: yes
  skboutput: yes
  get_tai_ns: yes
  get_func_ip: yes
  jiffies64: yes
  for_each_map_elem: yes

Kernel features
  Instruction limit: 1000000
  Loop support: yes
  btf: yes
  module btf: yes
  map batch: yes
  uprobe refcount (depends on Build:bcc bpf_attach_uprobe refcount): yes

Map types
  hash: yes
  percpu hash: yes
  array: yes
  percpu array: yes
  stack_trace: yes
  perf_event_array: yes
  ringbuf: yes

Probe types
  kprobe: yes
  tracepoint: yes
  perf_event: yes
  kfunc: yes
  kprobe_multi: no
  uprobe_multi: no
  raw_tp_special: yes
  iter: yes

Character literals have never been supported as far as I know. I'm surprised they're documented!
Looks like that docs entry was added in #1900

Thanks for the clarification. Happy to open a PR to clarify it in the documentation if that makes sense to you.

Thanks, that'd be great!


Encode URL to follow RFC 1866 (another attempt)

See #16.  Since $sharing_url, $sharing_name and $sharing_img are only used as URL parameters, they should all be URL encoded.  I found this problem when a product name with a % sign in it was causing twitter to give an HTTP status code 4xx.

Hello @watou , thanks for your contribution, would you mind to rebase your pull request? Thanks

Thanks @watou


Checkout Swift LLVM Bindings repo

This is similar to https://github.com/apple/swift/pull/60193.

@swift-ci please test

Hi @egorzhdan , this will likely break things on any branch that isn't main because there won't be a repository defined for that specific branch. Essentially a key error will occur in python.
For example, this is how our CI is run on 5.7:
./run release/5.7 --assertions --build-config=debug

** RUN **
Traceback (most recent call last):
  File "swift-source-compat-suite/./run", line 325, in <module>
    sys.exit(main())
  File "swift-source-compat-suite/./run", line 35, in main
    common.clone_repos()
  File "swift-source-compat-suite/common.py", line 188, in clone_repos
    branches[swift_branch]['swift-llvm-bindings'], workspace
KeyError: 'swift-llvm-bindings'

Is your intention to only clone this repo when building/testing the main branch?

One thing to note is that you are in a particular position where your changes will not be tested by the PR CI jobs because we run with --skip-clone when invoking run.py
We defer the dependency cloning to the build-script itself

Thanks @justice-adams-apple!

Is your intention to only clone this repo when building/testing the main branch?

Yeap, this is correct. This repo will only be used with main, and with release branches that will be created in the future.

One thing to note is that you are in a particular position where your changes will not be tested by the PR CI jobs because we run with --skip-clone when invoking run.py

Oh interesting, I didn't realize that. I'll make sure to test this locally.
I was mostly trying to mirror another patch that added the "swift-experimental-string-processing" repo (https://github.com/apple/swift-source-compat-suite/pull/635), since our checkout scheme is quite similar, but I'll double check that this doesn't produce errors for existing release branches.

@egorzhdan If you needed this in quickly you could likely just add swift-llvm-bindings': 'stable/20211026', to each of the repo->branch maps like you did with main.
However this will just mean that the release branches which don't need to actually clone that repository will do so anyway. It's a quick way to get this in without breaking things, but adds some small overhead of cloning a project unnecessarily.
The proper way would probably be to update the clone_repos() method of common.py with some logic to figure out which branch needs which set of projects based off the dictionary in question
Happy to help out either way, just let me know

@justice-adams-apple I tweaked the clone_repos() logic slightly to make sure it doesn't try to checkout swift-llvm-bindings for the existing release branches. I'll run this locally to make sure it doesn't break something else. Could you please take another look at this patch?

@swift-ci please test

Thanks @justice-adams-apple!
I updated the branch name after rebranch.

@swift-ci please test