Build <IP_ADDRESS>0 still has an outdated multipart dependancy.

Build 300 again forces a bogus multipart 2.0 dependency when multipart is officially at version 1.4. McMultipart 1.4.0 is actually a newer version of multipart than the the unintentionally published 2.0 release that mekanism is dependant on.

There's (a long known issue) related to that. Aiden is still releasing build of the master branch, while there are 32 commits, with the above issue fixed, on the 1.10 branch.
If you want to use it now, you can compile the 1.10 branch and use it.

Thank you much for the suggestion, but for some reason compiling mekanism always fails for me. I was actually using your (quite appreciated) build for quite a while but figured I'd update since it had been a rather long time. I was surprised to still see this issue existed. In the meantime I've deleted the dependencies.info in the jar as a workaround since the constant deletion of the proper mcmultipart causes some issues with refined relocation. Do you recommend I close this issue since it is already known?

There's currently an open issue (by me) for attending Aiden on the issue with the branches (#4059).
Great to hear the old build is appreciated! Maybe I can help you with compiling? What kind of errors do you get?
Deleting of the dependencies file is a good workaround, but your missing some nice bugfixes, which you can see at: https://github.com/aidancbrady/Mekanism/compare/1.10

Well, again I owe you many thanks. I dusted off my old compiling shoes, downloaded the most recent jdk, and was greeted with a "build successful" on my first attempt. Haven't tested it though yet. No idea what I was doing wrong last time either.
Suppose I'll close this issue. I'll post here again if I have any problems with my homebaked build if you have the time to answer any questions. And I give you a giant gold star for always helping out here. I've been using mekanism and lurking about the issues for years now and Aiden is a great guy, but he needs a little help with some maintenance at times. It was great when unpairedbracket was around to do it and you seem to be picking up the slack now. I just want to say that its much appreciated and thanks for the help!

Great that the build has succeeded and thank you for your appreciation! :D Means a lot


feat(avatar): DLT-1916 remove dt-icon

feat(avatar): DLT-1916 remove dt-icon
:hammer_and_wrench: Type Of Change

These types will increment the version number on release:

[ ] Fix
[x] Feature
[ ] Performance Improvement
[ ] Refactor

:book: Jira Ticket
DLT-1916

:book: Description
Removes the use of dt-icon from the Avatar component. Adds instead a slot for the avatar icon and for the overlay icon.
As a consequence of these changes, these recipes need to be updated:

[x] Feed item row
[x] Contact Info
[x] Callbox
[x] Contact Row

:bulb: Context
The want to remove all the uses of dt-icon from Dialtone so that consumers can make use of the tree shakable feature of Dialtone icons.
Instead, all icons should be directly imported in this format: import { DtIconDownload } from '@dialpad/dialtone-icons/vue2';
:pencil: Checklist

For all PRs:

[x] I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
[x] I have reviewed my changes.
[ ] I have added all relevant documentation.
[ ] I have considered the performance impact of my change.

For all Vue changes:

[x] I have added / updated unit tests.
[ ] I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script
[ ] I have validated components with a screen reader.
[x] I have validated components keyboard navigation.

For all CSS changes:

[ ] I have used design tokens whenever possible.
[ ] I have considered how this change will behave on different screen sizes.
[ ] I have visually validated my change in light and dark mode.
[ ] I have used gap or flexbox properties for layout instead of margin whenever possible.

:crystal_ball: Next Steps

[ ] Do a beta release with just the Avatar component and test that in the chat bot app everything works as expected and that dialtone-icons is effectively tree shaken
[ ] Update doc site for all updated components
[ ] Update vue 2
[ ] Update product

:camera: Screenshots / GIFs
Avatar

Contact Info

Callbox

Contact Row

I wouldn't merge this directly to beta, merge it into a new branch and then you can merge that branch into beta when you want to release


Update .NET license to standard text

Close #95

@david-poindexter The license text is NOT in source code, the text is in a .txt file, mentioned in the .dnn LP manifest. The license text is displayed during the extension install (the normal DNN extension license text).
I must not use 3 lines with // and without , since the license display during (DNN extension) installation would not be readable as 3 lines.

@EPTamminga I understand - sorry for any confusion.  My point was not the slashes (//), it was the actual text to be consistent with what is used in Dnn.Platform.  So, it would be something like the following if you wanted to use the
 for HTML styling during the installation process:

Copyright (c) .NET Foundation. All rights reserved.

Licensed under the MIT License. See LICENSE file in the project root for full license information

@david-poindexter, see https://github.com/dnnsoftware/Dnn.Platform/pull/3795#pullrequestreview-420105436, https://github.com/dotnet-foundation/foundation/blob/master/guidance/copyright.md, and https://github.com/dnnsoftware/Dnn.Platform/pull/3801.  This is the new license header to be consistent with, based on @mitchelsellers' comments yesterday

@bdukes @david-poindexter So my PR is correct?
If so, please review and process.

In this case, I would think we would want the full license to be included in the package, rather then the "file header" version.  @valadas what do you think about copying the LICENSE file in the root into the zip during packaging?  Then we don't need to copies of the license file that can get out-of-sync?  In either case, the root LICENSE file needs to also be updated based on https://github.com/dotnet-foundation/foundation/blob/master/guidance/copyright.md#copyright, i.e. the start should be:
The MIT License (MIT)

Copyright (c) .NET Foundation and Contributors
All Rights Reserved

Permission is hereby granted...

@bdukes I think is it easier to do an URL in my license text that points to that formal license file on GitHub.

👍 I think that's a great approach

@bdukes Consider it done...
The URL link in the license.txt in the dnn manifest points to the license in the DNNPlatform repo. The license text is also updated in the LP repo


[1pt] Create empty My profile - Setup (group task)

Create a route and a view component. Use <NavLink /> for the page navigation links and style active class to indicate which section/page the user is currently on (underline active navigation link).
This view should be empty - you will add content in separate tasks.

I think we can safely close this, right?

And the first two, maybe. @TechnoAndy , what do you think?

Yip, but don't delete the branch
On Tue, Nov 29, 2022 at 3:53 PM Olaoye Oluwatoyin Abayomi <
@.***> wrote:

And the first two, maybe. @TechnoAndy https://github.com/TechnoAndy ,
what do you think?
—
Reply to this email directly, view it on GitHub
https://github.com/TechnoAndy/space-travelers-hub/issues/3#issuecomment-1330685234,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALH5U7BQSXXLAWYWAKZOBFLWKYDHBANCNFSM6AAAAAASNLGHXE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Adding basic types for OpenCV

Some of the basic types for OpenCV
The mat type is binary and won't archive well with non-binary archivers
OpenCV's FileStorage api still might be a bit more convenient to use (supplying matrixes by hand)
But this can be useful.

I also wrote cereal serialisation functions for OpenCV a few months ago and I have a few remarks regarding this PR:
This pulls in all kinds of headers from OpenCV for cv::DMatch and cv::KeyPoint. These should be separated from what is in OpenCV core (i.e. cv::Mat, cv::Vec, etc.). Ideally we'd have a cereal module for each of the OpenCV modules that require serialisation, but I think it's enough to just serialise the types in core for a start. Certainly we shouldn't require the user to pull in modules others than core, so these additional types should be removed from the PR.
OpenCV has a proxy type for its data structures, OutputArray and InputArray. I'm not sure whether they can or should be used, but we should think about it. (one reason against it would be that for example std::vector<cv::Vec3f> is an InputArray as well, but in this case we wouldn't want OpenCV to serialise it but rather use cereal/types/vector.hpp to serialise the std::vector and our OpenCV serialisation to serialise the cv::Vec3f's).
The serialisation for cv::Mat in this PR is not as simple as it could be - it's sufficient to serialise  mat.rows, mat.cols, mat.type() and mat.isContinuous(). You can find my implementation in my blog: http://www.patrikhuber.ch/blog/6-serialising-opencv-matrices-using-boost-and-cereal which in my opinion is much simpler.
Seems to me like you shouldn't use CV_IS_MAT_CONT (deprecated C-API macro).
Also, in my opinion, supporting XML serialisation for cv::Mat doesn't make sense, because the files get very large very quickly, and if you look at them, each matrix entry will be inside its own XML attribute, so it's not really "human-readable" anyway. So I would remove _CEREAL_NVP. (But in case you want to keep it, I think you should use cereal::make_nvp instead).
Interestingly, I believe in your implementation if you save a non-continuous matrix, it will have continuous = true after loading it. We should think about whether we want this behaviour.


Bandit parser: implement scanner confidence

Work

[x] implement scanner confidence
[x] fix some formatting in description
[x] remove useless attribute to 'N/A' or useless value

lgtm except the failed integration test :)

@ptrovatelli changed how the title is managed so it broke the integration tests. fixed now :)

@ptrovatelli could you take a look?

Sometimes the tests fail due to a timeout or GitHubAction issue. You can restart them by clicking on them and on the top right more or less there's a "Re-Run all jobs".


ribbon ensure liveness of servers

HI ,when ribbon is selected from multiple servers, it often chooses unavailable services. How can you ensure server availability?

If you are not using Eureka, you probably want to look into using the IPing functionality in Ribbon.  You can customize the ping interfaced using in Spring Cloud Netflix Ribbon in your Ribbon configuration.

I has been used Eureka , also uses the IPing, but now ,it often chooses unavailable server.

Can you provide an app that reproduces the problem?

Closing due to age of the question. If you would like us to look at this issue, please comment and we will look at re-opening the issue.


Always return 304 Not Modified when the browser asks for updated file

Since Refile attachments are immutable I think it makes sense to always return 304 Not Modified when a browser asks if a file has changed since it was last downloaded.
The practical aspect is that resized images are loaded only once, reducing the CPU load of resizing. This is nice in development. I can't speak to the performance increase in production with a CDN but it should help there too when several CDN edge servers ask for the same resource.
If you think this is a good idea I'll write tests for this change.

I'm a bit wary of how this affects CDNs, do you have any experience with that?

Not yet. Let me turn on the CDN host on my site and report back what I find.
In principle though, do you think this is a good idea? A specific attachment_url will always point to exactly one version of a file, right?

I think that this is possibly unnecessary, I'm not sure if we even get any if-modified-since headers.

If it is a legitimate improvement I'm all for it though.

With the CDN configured I can't see any change in behavior. As you noted returning 304 is unnecessary in this case: the CDN caches the file and each edge server that needs it will request it only once. It never sends if-modified-since headers.
The real use for me is in development: when I load a profile index page full of avatars, each takes ~1 second to resize each one, so the full page load is ~30 seconds.
With the 304 Not Modified change each image is loaded only once unless I do a hard reload. Subsequent profile page loads are therefore very fast.
Is there a better way to have fast resized image load in development without sending 304 Not Modified?

I'm really surprised this would have any effect in development either, since we already have far-future cache expiry headers. Are you sure you're on the latest version of Refile otherwise? I think I'm going to close this for now.

Thanks for looking back at this issue Jonas. I still think the issue is there.
I agree that refile sends the correct cache expiry headers.
The issue is that refile doesn't check those headers when a browser makes the request so it always processes images and sends the entire body of the file even when the browser indicates it only wants a file if it has changed. Since refile attachments are immutable, it can never have changed if a browser indicates it has a cached copy.
I run into this in development when reloading a page that has refile attachment_image_tag with F5. The browser reloads all attachment images even with the far-future cache expiry headers.
I made a repository that illustrates this with the latest version of refile. Please check it out when you have time.
https://github.com/monkbroc/refile-not-modified


[Web] and [Mobile] - link validation

Link validation in QuillEditor no longer accepts<EMAIL_ADDRESS>or tel:NUMBER. Only valid urls can be added as a link. Mailto and tel are not accepted any more and can not be added.

For sure it looks like we need to introduce some testing framework in the app to start preserving these features. I've found many such regressions. Can you provide more details about the issue you are facing?  When it was last working. What else does not work. etc. Cheers! also consider the unoficial discord to get a live chat on the issue.

When you click on the attached link in Quill editor, alert dialog is opened with two inputs - text and link for that text. OK button in dialog is disabled until the valid link is entered. (Only accepts valid urls). Otherwise, the OK button is disabled and the entered link value can not be set (mailto: or tel:).
You can see attached screenshots. It is tested on the Web, but the same logic is used also on Mobile, and probably other platforms.
Last version where it was working was 2.0.5 (it is the old version but I can confirm for sure that it worked in this version, didn’t notice this issue with later versions, but can not confirm that it worked in some versions between the last available version and v2.0.5).

This clarification helps a lot. Hopefully one of the maintainers can have a look. I'm caught in many things, can't promise a day when I release a fix. But I'll keep it in mind to check it. Maybe there's an easy fix there.

I believe it is related to an improvement I introduced previously in #579.
Updating the regex might be part of the solution.


MWPW-126169: authoring changes for hiding individual CTAs

Authoring would work by having a separate panel where they can list ids and for those IDs the primary CTA will be removed. (either css display:none or just never render html)
Here's a detail of UX requirements:
We want a new tab similar to the "Feature Cards" and "Exclude Cards".
The new tab will be called "Hide CTAs" and the user will be the prompted to add content ID or card path, with "Add" option for more cards (similar to the Exclude Cards UX).
We also have a "Hide all cards in collection" option. While this duplicates the current functionality in UI->"Collection Button Style", this will be good in case users go to the new "Hide CTAs" tab and don't know why they can't hide all CTAs for the collection (even though they can if they used the current method)
Requires: https://github.com/adobecom/caas/pull/17
Resolves: [MWPW-126169]
Test URLs:
Before: https://main--milo--adobecom.hlx.page?martech=off
After: https://hide-caas-ctas--milo--sheridansunier.hlx.page?martech=off

@sheridansunier, I'm testing your change on the caas tool page with your branch: https://hide-caas-ctas--milo--sheridansunier.hlx.page/tools/caas
If you look at the following screenshot, I added the card id of the first 3 cards to the new Hidden CTAs section. However, those 3 cards in question still show a CTA button.

I do see the configured card ids getting sent in query parameter hideCtaIds though.

@honstar - it requires a PR to chimera-io that is on dev.  So you will need to switch to that endpoint on the advanced tab.

It also requires https://github.com/adobecom/caas/pull/17 (so making sure this is consuming the latest or at least that version of caas)

@sunier, leaving notes of what we discussed in slack in the PR for historical reference:
We discussed having the hide cta functionality for individual cards be 100% clientside versus sending the params to chimera io approach that is in the PR.
The reason being is will easily exceed the URL request limit of 2048 chars using the original approach in this PR.
We already have cases where we are using 1600-1800 chars for URLs on prod and if they wanted to hide some CTAs it may become troublesome for us.
The other benefit is, by changing the approach, we don’t have to worry about having people sync chimera dev versions and dexter release versions when reviewing this PR.

I agree with @sanrai's assessment, hiding CTAs should be done entirely on the clientside. The chimera-io backend does not need to be aware of it nor process this setting in any way.

Is Hide all cards in collection supposed to be in this PR?
I understand giving the ability for authors to hide ctas this way in a collection, but shouldn't that also be doable when creating a card so the card always has the cta hidden?  With it setup this way authors have to remember all of the cards that shouldn't have CTAs and then add those ids in.

@chrischrischris - that's already enabled, you can hide all of the ctas by going to UI > Collection Button Style > Hide CTAs

@sheridansunier : what's the status on this PR? It has been last updated 2 weeks ago and it has the do not merge label.


Improve JVM dashboards

There is quite a feature gap between the JVM dashboard that comes out of the box with Datadog and the one from ElasticAPM.
Datadog:

ElasticAPM:

After a conversation, some more specific notes about the screenshots.
Useful information missing in the JVM Dashboard:

Number of classes loaded
GC Collection Size -> Comparison between New & Old
Heap usage, breakdown per node (or deployment). ie. to see OOM on a specific deployment

The garbage collection New Gen & Old Gen can be collected with the jmx configuration.
It would be great to populate visualisations when the data is present.
Top 10 dashboards are a nice to have, but not as important as some of the other features mentioned above.


[WIP] zebra puzzle

work in progress, open-source contribution

Hi @JenniferHumphrey did you get stuck on this? If so, holler, and we'll help you get sorted. (If you just changed your mind, that's totally cool, too!)


Version that is compatible with .NetStandard 1.3

Is there a newer version that is compatible with .NetStandard profiles?

I believe AsyncLocal is built-in to netstandard1.3

Hmm, ok I'll keep looking as I cannot seem to find it anywhere

It's in the System.Threading package.


Track 'Mailmunch'

Vendor Site - https://www.mailmunch.com/
Example Site - https://www.letrunkshop.com/ OR https://www.muloshoes.com/
Category - 32 (Marketing automation)
Detection - Check for script from domain //a.mailmunch.co
- Check for JS object 'mailmunch'

added #5182


add cell decorator to import_gds

this PR avoids duplicated cells from import_gds

And this will avoid duplicate components because of what?

this was failing before
import gdsfactory as gf

if __name__ == "__main__":
    c1 = gf.c.straight()
    gdspath = c1.write_gds()
    c2 = gf.import_gds(gdspath)
    c3 = gf.import_gds(gdspath)

    c = gf.Component()
    c.add_ref(c2)
    c.add_ref(c3)
    c.write_gds()
    assert c

i added it to the tests

I mean yeah, of course this is failing. You are creating two cells that are named the same.
That's why I like the
kcl.read(...)
return Component.from_kcell(kcl[cell_name])

much more than this.


Adding Code for Session 7 Video 7 and Edits for Video 6

I double checked the video and it turns out the code in the video 6 folder actually matched the end of video 7. I made some very minor changes so that the code matched the end of 6 and made a new folder with the code for video 7.
We're half way there!!!! :)

Amazing, thank you!


customize output

I was trying to achieve an output like this: 7 days ago, 7 days ago or anything similar to be able to apply some css.  After a look at the source I couldn't find a way. Would you point a way to do this? Is it possible to do without modifying your code, just re-declaring the directive?
My current code is:

also note that  where I added days ago could've been seconds ago, months ago, etc

@TheWrongAlice see #44, it shows how to do this.
@enapupe Overiding humanize() (as outlined in #44) should do the trick, though, we currently update the element's text (and not innerHTML).

@urish Yeah, that's a deal breaker..
I'm gonna stick with my  modified version of angular-moment for now.

@enapupe no problem... Closing the issue for now


Mechanism to cancel waitForCode in LocalServerReceiver

Currently, callers of waitForCode() are blocked and cannot escape the method until the server handles the login redirect. In IDEs, this is a critical problem, as users cannot cancel a login flow. Because of this, Google Cloud Tools for IntelliJ already duplicated the code of LocalServerReceiver. I may also duplicate the code soon for Google Cloud Tools for Eclipse.
One idea would be make stop() (or a new method) escape a caller that is blocked or will be blocked on waitForCode().
Another idea would be make waitForCode() accept a timeout so that callers can poll.

Another idea would be make waitForCode() accept a timeout so that callers can poll.

Or return a Future

It looks like a bug that stop() does not cause waitForCode() to fail. That at the very least should be fixed. It would also be pretty easy to have a new waittForCode(long, TimeUnit) that also could throw InterruptedException (and probably TimeoutException).


Wrong position is printed when undefined object field is detected

Description:
type Ob object {
    string a;
    int b;
...
}

function f() {
    Ob o = new();
    o.z();
}

When undefined field 'z' is referred, error is shown in position of the method receiver 'o'.

In the above screenshot only first letter is squiggly lined for the same error.
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Fixed with https://github.com/ballerina-platform/ballerina-lang/issues/18758


LG ac ir remote

Hello, I have an LG air conditioner and I could not adapt it to it. I put it into recognition mode and when I press the air conditioner's remote control, it blinks but it does not receive any commands. I would be very grateful if you could help me.

Long pressed  5-10 second: Set up the infrared protocol
Long pressed 10-15 second: Restore settings

I did it but it didn't work. I tried it on a different air conditioner and it works, but I couldn't get it to work on LG. I would be very happy if you help

<EMAIL_ADDRESS>this is my email

I want to customize the air conditioner for myself. How can I make changes to the LG air conditioner codes?

I could never recognize the remote control. I put a screenshot.


New gas estimation algorithm

Block limit agnostic EIP150 gas estimation algorithm.

Hey, just found about your work on rewriting gas estimation via https://medium.com/truffle-suite/ethereum-gas-exactimation-1158a996eb8c
This is interesting as I was investigating the same recently as I thought every client behaved like ganache, in that they were simply executing the call once with the gas specified and returned the gasUsed minus the gas refund.
For that reason I was proposing a new estimation algorithm that paired with a new opcode could provide accurate estimation without binary search. see  https://github.com/ethereum/EIPs/pull/2075
I cancelled the Pull request since its motivation and rationale were wrong: current mainnet client are actually estimating the gas required correctly.
But the solution presented would reduce by 20 times the amount of computation required for an accurate estimation (since it would not need a binary search). I was planning to create a new PR with that sole objective in mind.
Now, I am intrigued by your solution. while it would deal with the extra gas required for success (due to 1/64 rules), it would still require a binary search to deal with smart contract that have code like
require(gasleft() > X)`

What my new proposal proposes is a new opcode (like explained in https://github.com/ethereum/EIPs/pull/2075
) for requiring gas like above. Allowing the client to estimate accurately such calls.
But since we would need backward compatibility, we would still require binary search for contract deployed before that. In other words, the optimization could only affect new contract and, new contract that do not use the new requireGas opcode would have their gas estimation broken.
We could mitigate this though by first calculating the exact gas cost via the new algorithm, use that as the first estimate. if it throws, use binary search upward.
I would love to get this kind of optimisation implemented, so let me know if you need more info. I would be happy to collaborate.

@wighawag Thanks for reaching out and sorry for the late reply!  We definitely appreciate your interest and are always open to contributions and collaborations in the pursuit of free and open source software!
You're right that this can still fail when the code branches on a condition like gasLeft().  This is definitely a case we are aware of, however currently we are pushing forward with this implementation.  From what we've seen in practice branching on gasLeft in such a way that gas usage changes has little utility outside of tricking gas estimation algorithms :laughing:!
With regard to next steps, we will be modifying the algorithm slightly to listen for the GAS opcode.  In which case we will need to rerun the transaction through the VM; if it fails we will just use our original estimate as our starting point and binary search for a better estimate (within some range of tolerance)..
Let us know what you think and please feel free to improve this implementation!
Also, @davidmurdoch and I will be co-presenting a workshop at TruffleCon 2019 on this algorithm, gas estimation in general, and techniques for gas optimization.  If you're interested, it will be one of the best places to connect and collaborate with other like minded devs! https://www.trufflesuite.com/trufflecon2019

Hi @nicholasjpaterno thanks for the reply.

From what we've seen in practice branching on gasLeft in such a way that gas usage changes has little utility outside of tricking gas estimation algorithms 😆!

This is not true, with meta transaction or any other call that need to ensure the gas available is sufficient before making a call, the gasleft check is required. See https://github.com/gnosis/safe-contracts/blob/5a8b07326faf30c644361c9d690d57dbeb838698/contracts/GnosisSafe.sol#L101
Or https://github.com/pixowl/thesandbox-contracts/blob/3a603597e85ace9de164def049b5b9e013422895/src/Sand/erc20/ERC20MetaTxExtension.sol#L177
It is important that the estimation algorithm supports such use cases.

With regard to next steps, we will be modifying the algorithm slightly to listen for the GAS opcode. In which case we will need to rerun the transaction through the VM; if it fails we will just use our original estimate as our starting point and binary search for a better estimate (within some range of tolerance)..

That would work but it would be better if we could add a specific gascheck opcode contracts could use so so that even in these cases (contract that use gas checks) the optimization can run. See my comments above.
Anyway it is good to see you are working in that direction.
I won't be able to attend truffle conf unfortunately.

@wighawag if the gasLeft checks whether the call has more gas than it needs to run, this will fail.
Remember, the initial estimate allows the transaction to use all the gas available in the block, which would enable us to investigate beyond any GAS checks during the estimate and calculate the exact gas needed for the call.  So long as gas requirements do not change, the estimate should have enough gas for the actual transaction.  Changes in state will break any estimations.
I agree though, an explicit operation to check for gas would make things easy, as I could just investigate the state at that time, however for backwards compatibility it would never obviate the need for binary searching in these cases.  I originally attempted to perform some static analysis with the GAS opcode, but that value could be manipulated or measured before it was needed making such a non-trivial.

if the gasLeft checks whether the call has more gas than it needs to run, this will fail.

Yes it will but this case is definitely a case of "tricking gas estimation algorithms" as you would put it. After all the binary search will also fails there.

Remember, the initial estimate allows the transaction to use all the gas available in the block, which would enable us to investigate beyond any GAS checks during the estimate and calculate the exact gas needed for the call. So long as gas requirements do not change, the estimate should have enough gas for the actual transaction. Changes in state will break any estimations.

I know that, but such initial estimate will under estimate for contract which have code like require(gasleft()>X) As such this estimate will be invalid on its own.. Hence my proposal for a new opcode to allow such initial estimate to consider the gas requirements performed by the code.

however for backwards compatibility it would never obviate the need for binary searching in these cases. I originally attempted to perform some static analysis with the GAS opcode, but that value could be manipulated or measured before it was needed making such a task non-trivial.

As I mentioned for contract that use such  checkGas opcode, the worst case would 2 estimate call : one to check the initial estimate and one to confirm there is no need to perform more checks.
This means that such contracts will get the optimization while other will fall back on the binary search, preserving backward compatibility.

@wighawag 	it could actually bit a bit better than the worse case you've described. We can check for the GAS opcode while collecting the gas fees, and only then validate the estimate.
In any case, I would like to keep this extra level of estimation certainty on our radar. Would you mind creating a separate issue for it so if people start running into gas estimation issues related to gasleft checks we can collect more use cases there?

@wighawag Definitely agree! require(gasleft()>X) cases like these are what I'm referring to here:

if the gasLeft checks whether the call has more gas than it needs to run

I agree though that a simple safety mechanism providing a lower bound for calls is an important use case.  With that said, it would be relatively easy to calculate the correct gas cost whenever its in a form like require(gasleft()>X).  I'll definitely add this check/optimization at some point.

the worst case would 2 estimate call : one to check the initial estimate and one to confirm there is no need to perform more checks.

True!  Although, I think this would be the best case.  And, with the optimization above I think I can correctly estimate in most cases.  Worst case of course is having to binary search.

@nicholasjpaterno
Yes sorry, meant to say best case. And as @davidmurdoch mentioned with your gas opcode check the best case could be one call (assuming the smart contract is not using the gas opcode). But for the use case I had in mind (meta transaction), the gas opcode would be used to compute the relayer's reward, even if the check of gas could use the hypothetical new opcode gasCheck.

With that said, it would be relatively easy to calculate the correct gas cost whenever its in a form like require(gasleft()>X). I'll definitely add this check/optimization at some point.

If it is in that particular form, yes but not if it was something like require(gasComputedEarlier > X) it would be more complicated. And if the algorithm is not full proof, it can't be used as it would break backward compatibility to assume it works in all case.
@davidmurdoch

Would you mind creating a separate issue for it so if people start running into gas estimation issues related to gasleft checks we can collect more use cases there?

I can put forward a failing test case for ganache as I encountered the issue while I was testing some contract behavior. Just need to extract them out.


Add metadata for PyPI in pyproject.toml

Hey @eimrek, great work on optimake serve and the PyPI release, this PR just adds some info in the pyproject.toml that PyPI will use to populate the project page/search.

whoops i didn't notice this, as i was debugging my release workflow. thanks @ml-evs, i'll try to incorporate rest of the changes.


[Microsoft.DeviceRegistry] Added spec for Microsoft.DeviceRegistry RP GA version

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

/azp run

Will hold on to merge this to properly orchestrate the rollout ⏸ @davidemontanari

@tadelesh - The azure-sdk-for-go task passed in the pipeline, but the BreakingChange-Go-Sdk tag is still active. Any actions we need to do on our side? Thanks.

@tadelesh - The azure-sdk-for-go task passed in the pipeline, but the BreakingChange-Go-Sdk tag is still active. Any actions we need to do on our side? Thanks.

resolved with suppression.


SETTINGS["CAPTURE_MODE"] is ignored

The following line uses CAPTURE_MODE as second priority if the first option (set by command-line argument -C) is not set. However, -C is never None, both because it has a non-None default value and because it is not allowed to be None. So setting SETTINGS["CAPTURE_MODE"] = "foooo" does nothing.
https://github.com/IDSIA/sacred/blob/c1c19a58332368da5f184e113252b6b0abc8e33b/sacred/stdout_capturing.py#L28-L29
Other relevant lines:
https://github.com/IDSIA/sacred/blob/c1c19a58332368da5f184e113252b6b0abc8e33b/sacred/run.py#L223-L227
https://github.com/IDSIA/sacred/blob/c1c19a58332368da5f184e113252b6b0abc8e33b/sacred/commandline_options.py#L298-L305

I misunderstood what was happening (so the post above is largely false), closing this


EF Cache issues

I have a problem, as follows:

Get object A, Include sub object by EF Core
Modify the data of object A in the database by Sql
Retrieving object A through EF, but object A's data is still not up-to-date

We should use AutoFac to do dependency injection. The lifetime of DbContext is PerRequest.
I research the NoTracking() function can flush it. But we need to change some data in point 1 and point 3.
Please help me.
Thank you

@zhangxijing666 Couple of ideas:

Consider using a different context instance for each modification. Typically the context instance should be used for a single unit-of-work and then disposed. It's hard to tell from just the info above, but it feels like this is two units of work.
Use context.Entry(myEntity).Reload() to update the entity with values from the database.

@ajcvickers I got it and fixed my bugs, the reason is my repository was be inject, so point 1 and point 3 is a same instance. Thank you.


Question: Does Zimg use the GPU at all or possibly could? Especially the FFmpeg zscale filter.

I'm just wondering if it could or if Zimg runs completely on the CPU.

No GPUs.

https://github.com/FFmpeg/FFmpeg/search?o=desc&q=cuda_scale&s=committer-date&type=commits
This one is good in ffmpeg, uses CUDA.

I've already seen it a while ago but thanks anyway. I was just wondering if Zimg supports GPUs.


imaging files concatenated by pyuvdata rotates image?

When I image a 10-minute HERA-47 Miriad file, my images appear as I expect. If, however, I concatenate a series of 10-minute Miriad files using pyuvdata and image that file, my images appear slightly rotated (see below). This rotation gets worse the more files I concatenate, leading me to think it is perhaps a phasing issue? One thing that happens in the process of getting a Miriad file to a CASA MS is converting to uvfits which phases the whole dataset to the first time integration.
As I said, I'm not sure if this is a pyuvdata problem or a problem in my imaging scripts, so if someone can try to duplicate this with their own imaging scripts, that would be appreciated.

^ Image of a GLEAM 02h source on a single 10-minute Miriad file

^ Image of the same source having concatenated 6 time-contiguous Miriad files w/ pyuvdata

How did you phase the files?

yeah, good point.
This rotation gets worse the more files I concatenate, leading me to think it is perhaps a phasing issue? One thing that happens in the process of getting a Miriad file to a CASA MS is converting to uvfits which phases the whole dataset to the first time integration.

I do the Miriad -> uvfits via the pyuvdata.miriad_to_uvfits.py script

yes, but you can phase the files to a specific location if you'd like, rather than just letting it default to the first time sample

well, in CASA, I do a fixvis, which should phase the data to the location I want. is there some discrepancy between the phasing algorithm in pyuvdata and CASA?

So after reading in the miriad files, you can use the phase_to_time or phase methods before calling write_uvfits.
It is possible that there is a discrepancy. CASA is known to have some phasing issues. pyuvdata is not perfect either, partly because we have struggled to find reference files to test against, but we believe it is good to better than an arcsecond. See issue #148

ok, i'll try that and see if it fixes the problem and let you know

Thank you, I'm definitely interested. This may be a very good thing to help us figure out residual phasing problems.

I need to refresh myself on the details, but there is an option in CASA that only applies a phase to the visibilities but does not change the UVWs which is fundamentally not what is generally meant by phasing in radio astronomy.
I believe that there is also an option which is supposed to properly change the visibilities and uvws together but there was a bug in that code at least as of a year or so ago. @dannyjacobs may know more about this.

indeed, seems to have fixed the issue

^ Image of GLEAM 02h source having concatenated 6 time-contiguous Miriad files, phased to the source time, and then written out to uvfits and passed through CASA

my fixvis call in CASA is
fixvis(msin, msin, phasecenter=fixdir)

which based on the CASA doc seems re-calculate the UVW array...

Excellent! Easier than I was worried it'd be. Should we close the issue?

Just saw your last comment. This bears looking more into I think.

well, not sure just yet: I think we have gotten used to using miriad_to_uvfits.py as a general purpose Miriad -> uvfits tool, and what we are seeing now is that for longer integration files we can't use that script... perhaps we can add a "jd_time" argument to miriad_to_uvfits.py that will optionally phase data to that input before writing to uvfits?

We may just rediscover a known CASA problem, but in theory the information in the FITS file should tell CASA where the data are currently phase.

that should solve problems on my end at least..

I'm definitely in favor of improving the script, why don't you add what you think is needed and make a PR? Maybe make some options so people can do different things...

sure thing!

But I'm also curious about the underlying problem. If CASA is getting the right info, and barring any bugs, it should be able to rephase the data as you'd like.

agreed. I think someone should try to duplicate this result with their own CASA imaging scripts just to ensure its not something I'm doing by accident... :)

Fair enough. I think your best bet there is probably @KingsleyWeb

If you're up for another test @nkern, I'd love to try doing the pyuvdata steps in another order to make sure the order doesn't matter: First read in all the miriad files (read_miriad can be passed multiple files) and then phase the final object once.
Also, as a clarification, did the original script phase each file to it's own first time before combining the files? That would explain the problem but should have raised an error in pyuvdata

@bhazelton that is exactly what I did for that third image above: I read in 6 files at once with uvd.read_miriad(['fname1', 'fname2', ...]), then used uvd.phase_to_time(<source_JD>), then wrote it out as uvd.write_uvfits(<output_fname>, spoof_nonessential=True), then passed that uvfits file through my CASA pipeline.

great, thanks!

@nkern should we close this issue or is there still work to be done on it?

@nkern should this issue still be open?

closing now because of recent phasing improvements.


otp not received to the mobile number

Describe the bug
after entering the number the number haven't received the otp's please resolve it
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-2e224u
Steps to reproduce
i want to generate otp request to the given phone number
Expected behavior
i want to generate otp request to the given phone number
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 129
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 44861142,
  "usedJSHeapSize": 43396618,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = hitboyrohith
Chat ID = c4c827fbaa75

Additional context
No response

Hi @hitboyrohith,
While we’re committed the success of our users, unfortunately we aren’t equipped to offer one-on-one engineering support for individual coding projects.
There are some excellent resources in #678 that others have found helpful in advancing their skills and building complex applications on the platform.


This app has a critical bug: calls from Android to iOS don't work.

Good afternoon, installed your sample on android and ios (not emulators).
If the call is initiated by ios, then android and ios users see each other in video chat
If the call is initiated from android, then the user from ios cannot see the user from android.
An example application that we used:
https://github.com/ConnectyCube/connectycube-cordova-samples/tree/master/sample-videochat-cordova
"cordova-android": "^9.1.0"
"cordova-ios": "^6.2.0"
"cordova-plugin-iosrtc": "^6.0.9"
"cordova-plugin-android-permissions": "^1.0.2"

Hi @Chechko-Ivan

some more information

The Cordova video chat app uses a Web code sample as a basis https://github.com/ConnectyCube/connectycube-web-samples/tree/master/videochat
and a web demo https://connectycube.github.io/connectycube-web-samples/videochat/dist

regarding your issue - do you see any error logs or anything like this? It would be great if you can share if any.

2.2) Also, is it only an issue with camera display, but voice is working well? can both users hear each other?


Edit Cycle Time Summary Data

As an ECMPS user (logged-in), I want to update Cycle Time Summary data so that I can add information to a test
Acceptance Criteria:
Given the user has selected Cycle Time Summary from the Test Type Group dropdown
When the user selects 'Edit' for Cycle Time Summary
Then the system displays the edit modal
And the user can edit Cycle Time Summary
Total Time (Text)
Given the user has updated Cycle Time Summary Data
When the user chooses to save and close
Then the data is saved
And the modal closes
And the user is returned to the Landing page for Cycle Time Summary Data
And the updates are reflected in the Cycle Time Summary data section
Warning message to pop up when a user updates data and closes the modal without saving (Cancel or clicks on X)
Warning message to read: Closing this window will discard any unsaved changes
Reference Screenshot:

Testing
Test Case: TC1106
Tester: @mosesdeeCVP

Test Passed


Add extra explicit arguments to call cradles

As requested in https://github.com/digital-asset/ghcide/issues/62#issuecomment-531934756, it would be nice to write:
cradle:
    stack:
    arguments:
        - -Wunused-binds
        - -Wunused-imports

Seems like it should apply to all cradles.

CC @fendor @jacg

I think that you should add these options to your stack.yaml?

It works, but it the warnings I want in my IDE aren't necessarily the same options I want during compilation.

I think, we have to be careful to not reinvent the wheel with the specification of hie.yaml.
If we continue to rapidly adding features, we might soon have an unmaintainable behemoth.
However, I think it is worth implementing custom arguments in one way or another. For example, in the case of a stack cradle, if projects support more than one snapshot, e.g. has multiple stack-*.yaml files, hie-bios automatically uses stack.yaml. Let's assume this stack.yaml uses ghc 8.6.5. However, sometimes I would rather want to use stack-8.6.4.yaml, since my version of hie/ghcide is compiled with ghc 8.6.4.
Currently, to work around this, we can copy stack-8.6.4.yaml to stack.yaml. However, now we have to careful to not commit the changes to stack.yaml and revert these changes if we want to switch the branch, which is not optimal.
Thus, in my opinion, it would be useful if we can specify the stack.yaml to use in hie.yaml. Consequentially, custom arguments for the cradle build-tools might make sense.

I'm certainly very uncomfortable with having to edit a project's version-controlled files, just to get my IDE to behave the way I want it to, and then to have to juggle these edits in stashes whenever I want to switch branch or rebase.

I want to try tackle this feature.
We will have to discuss a potential API.

I have been thinking about this feature request.
In the issue, it is described to pass in ghc arguments to the underlying tools and essentially extends all cradles to implicitly be direct cradles, too. This does not solve the problem described in https://github.com/mpickering/hie-bios/issues/44#issuecomment-532143616, though. NOTE: you can actually work-around the described issue by defining an env variable STACK_YAML. All stack-commands will then use this env variable. (@vilem-ff maybe interesting for you)
Then, I thought about adding a global field for custom cradle arguments.
However, having a global field for it, such as
cradle: ....
dependencies: ...
arguments: ...

has the issue that this arguments fields doesnt do anything for most cradles, e.g. for none and direct, and you can debate bios, since the flags are all going to be passed into a ghc session, eventually, and I dont think you need custom cradle arguments for a ghc session.
So, it feels like the only cradle types that would profit from this are cabal and stack.
I think this indicates that custom arguments to the underlying tools (cabal and stack) could be more useful than general extra explicit arguments (but feel free to disagree).
Assuming only stack and cabal need custom arguments, a potential api could be:
cradle:
  stack:
    ...
  arguments:
    - "--stack-yaml=..."

Something similar for cabal.
Problems I see with this approach:

Wrappers for hie/hls/ghcide are harder to write, since the ghc version to use may depend on these arguments.
It is not nicely generalized. Adding another cradle forces us to rewrite parsing logic, etc...

To mitigate the former problem we could extend the API, to e.g. expose the path to the ghc version to use for the cradle.
Any opinions on these thoughts? Are we looking for explicit ghc arguments for the cradle, or rather arguments to the tools cabal and stack?

In my mind we should allow additional options that might be passed to the CLI versions of stack or cabal.

I'm planning to use HLS with my corporate project, maintained as a stack project, which consists of dozens of packages with heavy optimisation/type-checking burdens.
As a daily workaround to check if they compile, I normally pass --work-dir=.stack-prof --fast --ghc-options="-O0 -dynamic" flags to stack; otherwise it takes more than an hour to compile, which is too much for IDE-thing.
All these configurations could be specified and managed by stack.yaml thing, so I think to provide an ability to customise the stack.yaml parameter would be at least enough.

I'd really like to be able to pass --no-docker to stack.

This would be a very useful feature.
As a stack user, I frequently run stack build --fast and stack test --fast locally, which collides with my HLS stack configuration. I believe this is the source of a lot of unnecessary recompilation (Compiling <blah> [Optimisation flags changed]).

hie-bios allows now to specify the cabal.project and stack.yaml for the session.
I think we can consider this issue to be imlpemented.


Bump the ulimit when running the tidy task if needed

What does this PR do?

Bump the ulimit when running the tidy task if needed
Motivation

Depending on the terminal emulator, people can have various values for the max number of files open. On iterm2 it seems to be 256, which is pretty low for the tidy task.
We bump it for the current process so people don't face the issue and don't need to tweak their own config.
We might move it to the init section so all task can benefit from it if it works well enough but let's keep it for just this one for now.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Private cmdlets use unapproved verbs (PSUseApprovedVerbs)

A number of the private cmdlets are flagged by PSScriptAnalyzer for using an unapproved PowerShell verb:-

RuleName
Severity
ScriptName
Line
Message

PSUseApprovedVerbs
Warning
Color-ToNumber.ps1
1
The cmdlet 'Color-ToNumber' uses an unapproved verb.

PSUseApprovedVerbs
Warning
Parse-SlackChannel.ps1
2
The cmdlet 'Parse-SlackChannel' uses an unapproved verb.

PSUseApprovedVerbs
Warning
Parse-SlackGroup.ps1
1
The cmdlet 'Parse-SlackGroup' uses an unapproved verb.

PSUseApprovedVerbs
Warning
Parse-SlackMessage.ps1
2
The cmdlet 'Parse-SlackMessage' uses an unapproved verb.

PSUseApprovedVerbs
Warning
Parse-SlackMessage.ps1
9
The cmdlet 'Extract-Previous' uses an unapproved verb.

PSUseApprovedVerbs
Warning
Parse-SlackTeam.ps1
2
The cmdlet 'Parse-SlackTeam' uses an unapproved verb.

PSUseApprovedVerbs
Warning
Parse-SlackUser.ps1
2
The cmdlet 'Parse-SlackUser' uses an unapproved verb.

The easiest way to fix this would be to explicitly suppress the PSUseApprovedVerbs rule for the Private\Parse-Slack* cmdlets by adding something like the below to each.
[Diagnostics.CodeAnalysis.SuppressMessage("PSUseApprovedVerbs", Scope="function")]

IMO, the cleaner way to fix this would be to rename those cmdlets to use an approved verb.
For the Parse- cmdlets, ConvertTo- or New- may be a suitable candidate from the current list of approved verbs, perhaps coupled with an Object or Type suffix (e.g., ConvertTo-SlackTeamObject),
Thoughts? Is a clean bill of health from PSScriptAnalyzer even worth pursuing?

I feel it's a bit of semantics, however I see your point. Color-ToNumber could become Convert-ColorToNumber, and Extract-Precious could become Export-Previous, but looking at Microsoft's docu on this there really isn't anything that could be interchangeable for Parse. Without looking at what each of those Parse commands do I would assume Get could possibly be used? But as a whole does this really matter besides it would pass some validation tool? Is there confusion with the commands?
https://msdn.microsoft.com/en-us/library/ms714428(v=vs.85).aspx

IMO, the only time I personally leverage PSScriptAnalyzer suppression is for things like Password parameters when the actual use case for the function doesn't really allow something unsafe to be passed there. Resolving the PSScriptAnalyzer messages with approved verbs would be ideal.
Here are my thoughts on best replacements with approved verbs:

Existing
Suggested

Color-ToNumber
Convert-ColorToNumber

Extract-Previous
Get-Previous

Parse-SlackChannel
Resolve-SlackChannel

Parse-SlackGroup
Resolve-SlackGroup

Parse-SlackMessage
Resolve-SlackMessage

Parse-SlackTeam
Resolve-SlackTeam

Parse-SlackUser
Resolve-SlackUser

Would it be proper to use the "diagnostic" verb Parse? MS suggests diag verbs are "used to diagnose the health of something." I finally got to look those cmdlets over and ConvertTo might be closer to what I understand those scripts to be doing since it is a PSSlack type they are creating. Maybe?

I'm thinking along the lines of Resolve-Path's behavior and looking at Resolve in that light, although Resolve is technically a diagnostic verb in PowerShell's definition. Maybe it's diagnosing the initial intention? 🙃

Ah, right. Good point. Yeah, totally agree with that. Just wish MS didn't use it like that and create the contradiction and confusion.

Receive-<...>Response (e.g. Receive-SlackUserResponse) might be an option as well.


Remaining records not passed to RemainingRecordsErrorHandler

As can be seen here - https://github.com/spring-projects/spring-kafka/blob/7c512c900c280750f2883d3a7d53adaaa030acf8/spring-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java#L1231 -that remaining records are passed only for ContainerAwareErrorHandler . RemainingRecordsErrorHandler implements ConsumerAwareErrorHandler and hence this.errorHandler.handle(e, record, this.consumer); is called which throws UnsupportedOperationException

Ref: https://gitter.im/spring-projects/spring-kafka?at=5c24f8e5db5b5c6883158523


renamed all conf files to gconf CERT-4617

Rename all the gambit config files to have the suffix .gconf

Thanks for the PR! I assume json extensions continue to work still since we didn't change the code in any way, yes?

Yes. We have to else it would break backwards compatibility. It is just a new convention.


User authorization

Is it possible to authorize ebay user with this SDK, get access token and use it to get details of that user account ?

It depends on which authorisation your project needs. If you want an Auth'n'auth token for use with the Trading service then this will be possible with the SDK. The API provides the two operations GetSessionID and FetchToken which you can call with the SDK.
If you are looking to use an OAuth token for the new RESTful APIs you are going to have to go outside the SDK as it's currently not supported. There has been some discussion over at https://groups.google.com/d/msg/ebay-sdk-php/JUHcEtdD9gg/inND9c5MDQAJ which may be of use.
I'm looking at seeing if I can add something to the SDK that would make it easier to get the OAuth token but I don't have an ETA yet.

Alright, seems i have to do it then. Could you please then assist with this error i am having:
error .

Sure :)

I'm going to close this as I aim to address this issue in #75.

New OAUTH2 functions of this API are working. I am able to get an OAUTH Token and a Refres OAUTH User token using API. However, It is not clear to me how to use these for BULK Data exchange APIs - Or if it is even possible to use AUTH2 with Bulk Data Exchange API functions.

@ediceapi read the docs debug the code, use the regular ebay forum.
https://developer.ebay.com/api-docs/static/oauth-trad-apis.html


Line breaks are ignored

When the text that needs to be animated contains line breaks, for the line break char class is created with empty which results in concatenated words.

Just realized that it's lettering.js issue...


Modify submit example and readme in the example of Kaggle pawpularity with automm.

Issue #, if available:
Add notebook link and stand alone installation in the example. Modify the submit example to correspond with notebook in Kaggle.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1894-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1894/1/index.html


Add codeql workflow

add codeql workflow similarly to other
projects in k8snetworkplumbingwg org

replaces #246

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.156%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
422

Relevant Lines:
1106

💛  - Coveralls


[MetaSchedule] Fix a typo in MemoryDatabase

This typo was introduced a while ago, but was not uncovered until I was rebasing Relax when a unittest crashes.

CC: @Icemist @echuraev @masahi

Will add a regression test over the weekend

@tqchen a test is added accordingly


Is it supposed to work on AGP 4.1?

Hello,
I'm using AGP 4.1-rc02 and I get the following error in a leaf Android module:
Caused by: com.android.builder.errors.EvalIssueException: Manifest file does not exist:

I have the following configuration in the root project's build.gradle.kts:
plugins {
    id("com.gradleup.auto.manifest") version "1.0.2"
}

autoManifest {
    packageName.set("com.company")
    replaceDashesWithDot.set(true)
}

I see the plugin has been built with AGP 3.6.3. Did you ever try it in a project using AGP 4.1? Might be caused by a change in ordering in recent AGP versions?

While working on this AGP 4.1 was early alpha and it was working. I didn't check with RCs.
I actually want to use the new transformation APIs available in 4.1 but they did not quite work at the time. Actually I heard in Slack that the API is going to break in 4.2 and 5.0.
Anyways, thanks for reporting this. I will have a look soon.

Thanks for your response and consideration!
FYI, I have been trying with AGP 4.1-rc02 but in AS 4.2 Canary 10.
I don't think that should change the behavior, but in case you are not reproducing in AS 4.1 RC2/3, then this might be good to know.

Hey, sorry for late reply on this. I found one issue and going to push a fix for that.
I was not able to reproduce this error on the sample app. I will try in Splitties.

I think the issue on Splitties was because of the following line: https://github.com/LouisCAD/Splitties/blob/main/buildSrc/src/main/kotlin/config/AndroidLibraryConfig.kt#L27

For those who are curious, I've integrated it into Splitties. This library is even more useful for Kotlin Multiplatform projects (Splitties is one of them) since you have to put the manifest under main folder which is not really a valid folder at all in Kotlin Multiplatform.
Splitties was changing it manually to be consistent with androidMain in KMM. It is mostly not needed anymore.

Thanks for digging @tasomaniac!
Do you know if the plugin could play nicely with custom defined manifest files, or if it could detect it and show a proper error message with resolution suggestion?

It's tricky. What I can do is to hardcore the original path used by Android Gradle Plugin and compare. AGP does not have any API on this and if they change it, my plugin would be broken. But the fact is that it did not change in 10 years 😊

I gave another thought on this.
If you have custom defined manifest file and that file exists, the plugin already detects that and it wouldn't be a problem.
The problem with Splitties was that the custom path for Manifest was defined for all modules. When integrating auto-manifest,  since the natural thing to do is to delete those one-liner files, it was erroring.
Not sure if we can handle that. I will add info into Readme tho.


PR Build - Changes done for conditional build

------------ Changes for PR build ----------
This changes will allow to build the repo as per file changes in area path .
--testAreaPath 'MdouleName'  will allow to build a specific module
No change for a local dev scenario

Looks good


Explore showing workspace search results in the command center

We want to start to explore what it'd be like to have a quickpick that shows text results.
For example, if we search activate in the vscode-livepreview repo, we don't get anything because it isn't in any filenames.

It would be nice if vscode knew that activate was in the extension.ts file and showed that file.

I started trying this our in Insiders. Initially didn't seem to work, until I realized it's vital to enter a space after the % character prefix.

The reason why we need a space after the % is because we try to keep the same pattern as the other quick accesses

One argument for requiring a space is if the workspace has files whose names begin with %

We now have a preliminary version of this. I will close this and additional requests regarding it can be in its own issue.


Where is docs ?

Hello. I interested in your library. But i don't found docs for it. Where can i find this docs ?

 I'd either be in the Instance declaration in Handles.cs or in Additions.cs, but apparently it's in neither.

Wait, there's an odd invocation via Commands, you can see an example here

Thank you :O I didnt know GitHub was more reactive than a Discord or a Ferrari !
Another question then, i browsed Samples but still can't figure out how to link to Debug Report callbacks ;(
I saw this function, but can't deduct via the arguments how it is supposed to be used in C#. ;(
"CreateDebugReportCallbackEXT"

Found it ! If anyone pass here you can learn that here : https://github.com/mono/VulkanSharp/blob/master/docs/development/ValidationLayers.md


Revert cleave.js version

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #238
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Revert cleave.js package version to the previous release.
AC:
The link to the cleave.js release that we currently support is here: https://github.com/nosir/cleave.js/releases/tag/v1.6.0
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 2.14.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Please update this plugin to statamic 5 [SC-1447]

@Oleafeon, we are currently working on the upgrade to Statamic 5.

@Oleafeon support for Statamic 5 (and 4) has been added in version 1.0.8


Search button does not work

Describe the bug
Pressing the search button after entering text in the search box has no effect.
To Reproduce
Steps to reproduce the behavior:

Go to market.oceanprotocol.com
Enter some text in the search box
Click on the search button

Expected behavior
The results list is displayed.
Desktop (please complete the following information):

OS: Windows 11
Browser: Chrome (version106.0.5249.103) or Microsoft Edge (version 106.0.1370.42)

firing search either with enter or by using the search icon is intended so this is valid bug.


Dash webapp

Adds the ability to plot IMD Decile and % uptake by Westminster Parliamentary Constituency (or indeed mutliple layers of different boundaries).
Has some slight deficiencies which will need to be corrected, notably between boundary, map_plotter and map, where the readibility and functionallity could be improved relatively easily.

What does the dash webapp part do?


Feature: Pass custom ruleKeys to rule.

handle customRule values from parent

Codecov Report

Merging #74 into master will increase coverage by 0.13%.
The diff coverage is 68.96%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   72.59%   72.72%   +0.13%
==========================================
  Files           7        7
  Lines         135      132       -3
  Branches       18       18
==========================================
- Hits           98       96       -2
+ Misses         34       33       -1
  Partials        3        3

Impacted Files
Coverage Δ

src/Rule.jsx
100% <100%> (ø)
:arrow_up:

src/controls/ValueEditor.jsx
100% <100%> (ø)
:arrow_up:

src/controls/ValueSelector.jsx
100% <100%> (ø)
:arrow_up:

src/controls/ActionElement.jsx
100% <100%> (ø)
:arrow_up:

src/RuleGroup.jsx
100% <100%> (ø)
:arrow_up:

src/QueryBuilder.jsx
47.05% <46.26%> (-0.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2ef5aa...54ad23f. Read the comment docs.


⚠ Samsung has degraded performance

In 6d711c4, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2890 ms

Resolved: Samsung performance has improved in 443df2b.


Add support for aggregation and Graphite Separate Instances to Collectd plugin, add 2 plugins to collectd

https://github.com/opnsense/plugins/issues/1758
Implemented the aggregate values for CPU and the "separate instances" feature.
Added "disk" (disk i/o) and "swap" plugins.
I need to research why the "cputemp" plugin is not available in the package version used by OPNsense.

Why do you change the templating so aggregating only works when Graphite is enabled? Isn't this relevant for Network plugin?

I didn't - IMHO.
This is my generated collectd.conf:
Hostname    "opnsense.local"
Interval    10

LoadPlugin syslog
<Plugin syslog>
  LogLevel err
</Plugin>

LoadPlugin contextswitch
LoadPlugin cpu
LoadPlugin aggregation
LoadPlugin disk
LoadPlugin df
LoadPlugin interface
LoadPlugin load
LoadPlugin memory
LoadPlugin swap
LoadPlugin processes
LoadPlugin uptime
LoadPlugin users
LoadPlugin write_graphite

##############################################################################
# Plugin configuration                                                       #
#----------------------------------------------------------------------------#
# In this section configuration stubs for each plugin are provided. A desc-  #
# ription of those options is available in the collectd.conf(5) manual page. #
##############################################################################

<Plugin write_graphite>
  <Node "graphite">
    Host "<IP_ADDRESS>"
    Port "2003"
    Protocol "tcp"
    ReconnectInterval 0
    LogSendErrors true
    Prefix "servers."
    SeparateInstances true
    StoreRates true
    AlwaysAppendDS false
    EscapeCharacter "_"
    PreserveSeparator false
    DropDuplicateFields false
  </Node>
</Plugin>

<Plugin cpu>
  ValuesPercentage true
</Plugin>

<Plugin "aggregation">
  <Aggregation>
    Plugin "cpu"
    Type "percent"
    GroupBy "Host"
    GroupBy "TypeInstance"
    CalculateNum false
    CalculateSum true
    CalculateAverage true
    CalculateMinimum false
    CalculateMaximum false
    CalculateStddev false
  </Aggregation>
</Plugin>

Aggregation is a separate plugin and the config goes into a separate plugin section as it should.

Yes, it looks same to me, but it seems you deleted an endif somewhere so plugin config only get's written when graphite is enabled.

My bad - will check and fix. Thanks.

@fichtner I'll bump version/changelog after merge as I also want to clean up the UI with some headers to separate outputs and plugins

Merged, thanks!


Add HIP-782: Smoothing Staking Rewards

Problem
HIP-782 describes modifying the staking reward rate property.
HIP: https://hips.hedera.com/hip/hip-782
HIP: https://github.com/hashgraph/hedera-improvement-proposal/pull/786/files
Mirror Node:

issue to track TBD

Solution
Review the changes and modify UI where applicable.
Alternatives
No response

Suggesting to do these changes:

Also visible on the staging server.


using loom only on tests; features additive

Work done

Configuring loom as a dev-dependency.
Creating a loom-tests feature that is no-op, except for diatomic-waker unit tests.

Benefits

Removing loom as dependency of diatomic-waker.
After upgrade of loom from 0.5 to 0.7, MSRV should go up because of the loom dependency. Now this is not required anymore, except for testing scenarios.
Loom does not appear in production code at all :).

This looks like the best compromise, and it doesn't even requires the bump in MSRV; I'm still wondering where is the catch ;-)
If you don't mind renaming the feature to just loom-tests and fix the small formatting issue, I would just merge it as-is.
Many thanks!

Working on the changes!
The catch is:

default features does not use loom-tests.
loom-tests is a no-op feature, unless you are running cargo test for diatomic-waker crate. It pollutes a bit the list of features, although it is harmless.

We took advantage that unit tests, and only unit tests can run with cfg(test) enabled. And as we stated we don't want others to enable loom outside unit testing of diatomic-waker, this is the safest bet.

FYI, one side effect of upgrading loom on #7 is that the MSRP should be 1.70.0.
loom 0.7 -> generator 0.8.2 -> windows 0.58 (Requires 1.70.0).
But, as we move loom to be a "test-only" dependency, now this is not a problem anymore :).

The catch is:
* default features does not use `loom-tests`.

* `loom-tests` is a no-op feature, unless you are running `cargo test` for `diatomic-waker` crate. It pollutes a bit the list of features, although it is harmless.

Oh yes sure, I got that, I was just wondering if there is a hidden downside :-)
Still haven't found one so let's merge!

Oh, I see now the downside (which may be what you were explaining, but I did not understand it): we still need to curate the list of features passed to cargo when running regular tests.

It looks like there is no issue when replacing the loom-tests feature by a flag (PR #11) while keeping your idea of gating loom on cfg(test). This looks like the winning combo: no feature pollution, and --all-features can be passed to all CI targets including in particular regular tests.

Published in v0.2.2 :tada:
Thank you again for your help with this!

You are welcome. Thanks for being open for changes. Was a fun excercise.


Add documentation to the main function

I think it would be good to add a simple description as to what the main function does even if this
might seem to be obvious.

Alright @pneumatos! I think that would be good too! Thank you!


reflection data not generated for template arguments

from_json<variant<foo_t>> will break, because reflect<foo_t> is not generated.

not broken, added test


Elaboration of Verilog Generation

Hello :wave: Cool project!
I just wanted to ask what is planned for the Verilog generation in the TODO section of the README? I'm a Verilog RTL developer and would be keen to contribute to this project.

Great, thanks for the response!
What did you have in mind for the Verilog generation feature? I'm having trouble seeing the kind of functionality here, since Verilog is used to infer digital logic to synthesise actual circuits, what kind of circuits are we trying to describe here? As far as I understand it, SharpRISCV is essentially a browser-based RISCV emulator that can run code and generate executables.

Generate a Verilog code to load instructions and data memory for an FPGA, similar to what we did with the hex file.
Ref: Rivasm - A RISC-V RV32IM Assembly Program Assembler and Simulator, and a RISC-V RV32IM CPU / Computer System Implementation on FPGA

Ah got it, makes sense. This sounds like a useful feature, I'd imagine I'd start off with generating a 'generic' rom file directly from your that is simply just the raw instructions in hex format, represented as an appropriately sized 2D array and then eventually add some parameterisation to map it into specific Xilinx/Altera(now known exclusively as Intel since the acquisition) IP blocks. There'll be a bit of glue logic to generate to handle whether the IP block is sync/async but that doesn't too hard.
Cool, I'll fork this repo and have a play around over the next few days and show you what I get 👍


Sass Writing Styles

Description
Currently, Creative Commons does not have a Sass writing style though it follows a standard code style in all .scss files. This issue proposes finding and preparing a writing style from the .scss files present in this repository.
Please provide your suggestions on this idea.
Implementation

[x] I would be interested in implementing this feature.

Hi, Please I would love to work on this if it has not been assigned to anyone.

I have prior experience working with Sass and respective processors, and I'm willing to work on this. Is this issue still open for work, @TimidRobot?


RKE2 Provisioning: Agent Environment Variable Support

Setting up the agent environment variable should configure the relevant agents to have env var support.
Available to view on the cluster in the UI under deployments:
cattle-cluster-agent
fleet-agent
@Oats87 Is there a way to test that the system-agent is getting the agent environment variables?
system-agent
This issue is to track that these environment variables are passed to these agents.

From @bashofmann on the previous issue, I believe this would help track an issue with the rancher-system-agent:
For me the rancher-system-agent fails to even pull the system-agent-installer-rke2
Aug 05 12:21:15 ip-10-0-1-230 rancher-system-agent[2757]: time="2021-08-05T12:21:15Z" level=info msg="Pulling image index.docker.io/rancher/system-agent-installer-rke2:v1.21.3-rc3-rke2r2"
Aug 05 12:22:15 ip-10-0-1-230 rancher-system-agent[2757]: time="2021-08-05T12:22:15Z" level=error msg="error while staging: Get "https://index.docker.io/v2/\": context deadline exceeded: failed to get image index.docker.io/rancher/system-agent-installer-rke2:v1.21.3-rc3-rke2r2"
Aug 05 12:22:15 ip-10-0-1-230 rancher-system-agent[2757]: time="2021-08-05T12:22:15Z" level=error msg="error syncing 'fleet-default/custom-61ef3f741d5c-machine-plan': handler secret-watch: error applying plan: error executing instruction 0: Get "https://index.docker.io/v2/\": context deadline exceeded: failed to get image index.docker.io/rancher/system-agent-installer-rke2:v1.21.3-rc3-rke2r2, requeuing"
The setup:
Rancher and downstream cluster are in the same private network and only have internet connectivity through a http proxy
I set the necessary HTTP_PROXY, HTTPS_PROXY and NO_PROXY environment variables under "Agent Environment Variables". These are also present in /etc/systemd/system/rancher-system-agent.env:
sudo cat /etc/systemd/system/rancher-system-agent.env
HTTPS_PROXY=http://<IP_ADDRESS>:8888
NO_PROXY=<IP_ADDRESS>/8,<IP_ADDRESS>/8,<IP_ADDRESS>/12,<IP_ADDRESS>/16,.svc,.cluster.local,rancher.<IP_ADDRESS>.nip.io
HTTP_PROXY=http://<IP_ADDRESS>:8888
The same proxy settings work fine in a K3s cluster and images can be pulled there through the proxy.

The easiest way to test that the system agent is receiving the variables would just be to use it and check the logs of the proxy server that has been specified. But as @bashofmann has shown, the agent is in fact able to consume proxy environment variables that are provided via the /etc/systemd/system/rancher-system-agent.env file. Additionally, if the user that is running the system-agent-install.sh script has proxy variables defined in their environment, the install script will automatically create an environment variable file with those proxies: https://github.com/rancher/system-agent/blob/main/install.sh#L605-L612

on v2.6.0-rc4:

custom node with http_proxy, https_proxy and no_proxy settings in both the registration cmd through rancher and as environment variables on a private node (amazon ec2). Rancher server has self signed certs, so the insecure flag was used when registering the node

registration cmd is able to begin registration on the private node

Reopening for the following issue:

node is unable to complete registration. Here are the final logs on the node

 level=info msg="Cluster-Http-Server 2021/08/18 21:56:09 http: TLS handshake error from <IP_ADDRESS>:54680: remote error: tls: bad certificate"
Aug 18 21:56:09 ip-172-31-13-126 rke2[2033]: time="2021-08-18T21:56:09Z" level=info msg="Running kube-proxy --cluster-cidr=<IP_ADDRESS>/16 --conntrack-max-per-core=0 --conntrack-tcp-timeout-close-wait=0s --conntrack-tcp-timeout-established=0s --healthz...

through rancher, the node is stuck in state waiting for cluster agent to be available

linking for tracking purposes:
https://github.com/rancher/system-agent-installer-rke2/pull/10
https://github.com/rancher/system-agent-installer-rke2/pull/9
https://github.com/rancher/system-agent-installer-rke2/pull/7
https://github.com/rancher/system-agent-installer-rke2/pull/6
https://github.com/rancher/system-agent-installer-rke2/pull/5

I was able to confirm on 2.6-head (06c8898):
single node (all roles cluster), 1 env. variable:

cattle-cluster-agent -- environment variable accessible -- pass
fleet-agent -- environment variable accessible -- pass

multi node (dedicated node per role), multiple vars:

cattle-cluster-agent -- environment variables accessible -- pass
fleet-agent -- environment variables accessible -- pass

able to remove environment variable by editing the cluster -- fail -- fleet-agent is not removing the agent environment variable at the same time that cluster-agent is updated
able to edit environment variable by editing the cluster -- fail  -- fleet-agent is not updating the agent environment variable at the same time that cluster-agent is updated
Summary:
filed https://github.com/rancher/rancher/issues/34368 for the above 2 failures, and will also block this/include the proxy testing as part of this ticket


Implement pickup/dropoff types for stopTime entity in schedule viewer

@mattwigway I'm going to take a crack at adding in stopTime pickup/dropoff
Code reference: parseTime function

@mattwigway Here are my thoughts on this:

a keypress event to specify pickup/dropoff for stopTimes would be appropriate (e.g., d and p).
cell highlighting (or border) in the HTML renderer function based on time pickup / dropoff type (right now this is just a placeholder conditional)
The thing I need help with is actually modifying the stopTime entity... I'm not sure how to get the stopTime on the keypress

Any thoughts on this approach?

OK, I've made some headway.  It might not be entirely ready for primetime, but once I get your feedback we can further refine:

I now have the keypress working for both d and p
the modifyStopTimeType function toggles the stopTime from SCHEDULED to NONE (other options not accounted for presently)
the highlighting is now showing yellow for no dropoff, blue for no pickup, and red for no pickup or dropoff (these need to be refined for style/legibility and other combinations.  Maybe the styling should follow another pattern, e.g., range of background colors for dropoff values and a range of border colors for pickup values.


Implement bootstrap theme

Hi @mahedee bhai,
Bootstrap implementation done.
Implement bootstrap theme close #12

I have one big problem. 7224 files changed in one PR! I think we should fix it before merging the PR.
Another option is merging this PR and create a Issue for clearing those files as soon as possible. This is all up to you @kajal-alpha

As we discussed in our previous meeting, @mahedee bhai wanted to do code review for this repository. So I didn't review it. But he is busy. So I will continue my code review from now on, untill he can manage time.


Allows to enable/disable keyboard control, fixes issue of unwanted focus ring in macOS 14+

Fixes: https://github.com/fermoya/SwiftUIPager/issues/329 by using the new modifier .allowsKeyboardControl(false)

Curious how does this PR solve the focus ring issue?

Curious how does this PR solve the focus ring issue?

Simply by giving the option to disable keyboard control… without keyboard control, the focus ring doesnt appear


rbd.Image.ReadAt and rbd.image.WriteAt are not thread-safe.

rbd.Image.ReadAt() and rbd.image.WriteAt() are not thread-safe (i.e. cannot safely be used from more than one go-routine) because they call rbd.image.Seek() without maintaing a mutex. The reason POSIX introduced (and golang simulates) ReadAt and WriteAt calls was specifically so that they can be used safely in a multithreaded environment.
I don't know whether librbd supports proper ReadAt and WriteAt calls. If it does then these should be used. If it does not then at the very least the documentation should carry a heavy warning that unlike ReadAt() and WriteAt() elsewhere in golang, these are not concurrency safe.
This is actually causing me a problem in gonbdserver, where I attempt to use a threaded backend to ensure that reads/writes to different OSDs execute in parallel. With the existing implementation, this is very unsafe.

Thanks for tackling this. I'll review this soon.

I just merged your patch, thanks. Looking through it you are correct. It's not clear why the ReadAt and WriteAt versions in there were modifying the offset state. I think this should be resolved now.

Thanks!
On 20 May 2016, at 15:35, Noah Watkins<EMAIL_ADDRESS>wrote:

I just merged your patch, thanks. Looking through it you are correct. It's not clear why the ReadAt and WriteAt versions in there were modifying the offset state. I think this should be resolved now.
�
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

--
Alex Bligh


Migrates to Swift 4.2

Following these steps:

Use Swift migration assistant.
Updates where Xcode presents Swift compiler warnings.

@nixta might there be other areas of the app you would recommend migrating more actively? (Based on some updates to the Swift Standard Library or as a result of Swift language evolution.)
https://swift.org/blog/swift-4-2-released/

References: https://github.com/Esri/maps-app-ios/issues/60

@philium I think what you suggested makes sense. I've also removed
maps-app-ios/Extensions/UIViewAnimationCurve+UIViewAnimationOptions.swift
because it's no longer used.
Would you have another look?

@esreli & @philium: thanks for doing this.


[stable/heapster] Fix stable heapster fullname

What this PR does / why we need it:
Currently if we install heapster by helm upgrade --install heapster stable/heapster,
then we get the fullname heapster-heapster.
This PR fixes this so that we'll get the fullname heapster.
Which issue this PR fixes
There is no associated issue.
Special notes for your reviewer:
helm create command also creates this templates/_helpers.tpl.
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] title of the PR contains starts with chart name e.g. [stable/chart]

/assign @viglesiasce

This will be a breaking change so we should up it by a major version ... since its still < 1.0.0 ... we can bump this to 1.0.0.

@paulczar Thanks for your review.
I bumped version to 1.0.0 98e8a7a

/assign
/ok-to-test
/lgtm


[SPARK-37596][SQL] Add the struct support in the DropDuplicate

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Can one of the admins verify this patch?

cc @cloud-fan @HyukjinKwon @viirya


struct generation is a bit redundant.

I think your struct generation is a bit redundant.
typedef Person ={

    var name:String;
    var age:Int;
    var ?address:String;
}

and your code
#pragma once

#include <optional>
#include <string>
#include "_AnonStructs.h"

// { age: Int, name: String, address: Null<String> }
struct Person {

	// default constructor
	Person() {}

	// auto-construct from any object's fields
	template<typename T>
	Person(T o):
		age(haxe::unwrap(o).age),
		name(haxe::unwrap(o).name),
		address(extract_address(haxe::unwrap(o)))
	{}

	// construct fields directly
	static Person make(int age, std::string name, std::optional<std::string> address = std::nullopt) {
		Person result;
		result.age = age;
		result.name = name;
		result.address = address;
		return result;
	}

	// fields
	int age;
	std::string name;
	std::optional<std::string> address;

	GEN_EXTRACTOR_FUNC(address)
};

I think it's too heavy to use .
why not like this ?
struct Person {
    std::string name;
    int age;
    std::optional<std::string> address;
};

May be your code is for some reason.
The goal of designing the struct in this way is to provide multiple ways of constructing Person objects based on different scenarios. By including these various constructor options, the struct becomes more versatile, allowing users to create Person objects using their preferred method based on the available data or requirements.

Yes! Apologies for the delay, but a Haxe "anonymous structure" is very different from a C++ struct. An anonymous structure needs to be able to be assigned from any object with the same fields, like this:
class Test { var a: Int = 0; }

function main() {
    final test = new Test();
    doThing(test);
}

function doThing(num: { a: Int }) {
    // do something with an object with "a: Int"
}

So that's why there needs to be a lot of boilerplate. If you want a "struct", you can create a Haxe class with just fields in it. class and struct do the same thing in C++ afaik!


Remove BDC provided book from Books viewlet.

Steps to Reproduce:

Open ADS and navigate to Books view
On the Provided Books view pane, expand the options -> Sql Server 2019 Guide shows up.

Remove the BDC book.

@MaddyDev Please open a port


If p2p instance failed to start due to TUN/TAP problems DHT connection is still active

If p2p instance failed to start due to TUN/TAP problems DHT connection is still active

p2p related issue

Issue moved to subutai-io/p2p #881 via ZenHub


Various Enhancements: Enhanced access to actual array element form defs, Dynamic change of other form elements  from change handler and more

I have whole queue of enhancements/ideas/design suggestions queue up from working with ASF for a good while. I've read enough of the source code to pretty familiar, but not quite familiar enough with enough time to actually try to hack the changes in how I'd like to see them... I think I'll just suggest in example code...
{
    key: "modules[].activities",
    add: 'Add activity'

    ,items: [

        {
//putting this element first just in this example
          key:"modules[].activities[].fullFilePath"
        },
        {
            key:'modules[].activities[].srcFolderPath',
            onChange:function(modelValue, form, schemaFormSystem, rootForm)
            {

                // HMMM... I *really* need to access the form element for "modules[].activities[].fullFilePath",
                // more specifically for "modules[n].activities[n].fullFilePath"
                // because I need to change something -- like the titleMap for modules[n].activities[n].fullFilePath and JUST modules[n].activities[n].fullFilePath
                // that correspond to the n-th item that this field corresponds to

                var $injector = angular.injector(['ng']);

                $injector.inject(['$http', function($http)
                {
                    $http.get('/getFileListingForFolderByFolderName/' + modelValue)
                        .then(function(resp){

                        var data = resp.data;
                        var PathOfCurrentFormDef = schemaFormSystem.getPathForFormDefintion(form)
                        // PathOfCurrentFormEl is string "modules[2].activities[1].srcFolderPath'"

                        var BasePathForFormDef = schemaFormSystem.getBasePathForFormDefintion(form)
                        // BasePathForFormDef is string "modules[2].activities[1]"

                        var myFormDefinitionToUpdatePath =  BasePathForFormDef + '.fullFilePath'

                        var myFormDefinitionToUpdate
                                = schemaFormSystem.getFormDefinitionByPath(rootForm, myFormDefinitionToUpdatePath)

                        myFormDefinitionToUpdate.titleMap = _.map(data.FileListing), function(filename){
                            return {name:filename, value:filename}

                        })

                        schemaFormSystem.redraw(myFormDefinitionToUpdate);

                    })

                })

            }
        },

    ]
}

So... quick summary and perspective on a few of the needs/suggestions etc:

Need form elements to be able for update other form elements from within itself.
Would be good to be able to explicitly only "re-draw" what's needed and not the WHOLE form. Would be HUGE for performance. Redraw of large forms is quite slow at times.
Why not pass the entire SF system to the form and let it have access to do whatever it needs to to itself, within itself?
More super-friendly utility functions built or exposed to handle accessing form definitions by path names and to create the path names would be great (some of this might already be built in via object path,, i dont know).
Also.. technically I need to initially populate  key:'modules[].activities[].srcFolderPath' via an $http.get/Promise. I haven't seen this available either? Or have I missed it?

Oh Btw.. I might suggest start "flattening" the args to onChange. Rather than:
onChange:function(modelValue, form, schemaFormSystem, rootForm)...          onChange:function(changeContext)
where:
 changeContext = {
    modelValue:modelValue,
    ngModel: ngModelForChangingFormDef
    form: changingFormDef,
   schemaFormSys : schemaFormSysInstance
   rootForm: rootLevelFormFor the changingFormDef
 }

Just give us more stuff to roll our own/hack with! And a single arg is much more future proof ;)
It's kind an urgent need for some few parts of this somehow, someway.  Maybe with some guidance  on how to implement  ( or some extra time on my hands soon!) I could hack at it.   Any Quick Ideas? Maybe for the  "Enhanced access to actual array element form defs" component of this.... or the limited redraw aspect?
I'll likely add more comments/perspective to this post later. Or discussion.Time to break for now.

"Need form elements to be able for update other form elements from within itself."
I've done this with my add on (external-options the latest version in git not bower...), take a look at how it works, not too hard to load new titleMaps from a server dynamically. I will improve on this soon and was considering making a separate add on to assist with a pure titlemap load without it being specifically select related.

@souluniversal it would help if your suggestions were in separate issues so they can each be considered on their own merit.
FYI the new builder does pre-render the form and has made performance improvements and is expected to be enhanced to do partial updates in future.

Marcel, thanks. I actually hackishly implemented a good bit of it. I don't really have time to clean it up or do a pull request etc -- would you (anyone?) possibly want to coordinate to have a look and consider the changes directly with me?
From: Marcel J Bennett<EMAIL_ADDRESS>Sent: Monday, April 11, 2016 12:41 AM
To: json-schema-form/angular-schema-form
Cc: Robert Taylor
Subject: Re: [json-schema-form/angular-schema-form] Various Enhancements: Enhanced access to actual array element form defs, Dynamic change of other form elements from change handler and more (#585)
@souluniversalhttps://github.com/souluniversal it would help if your suggestions were in separate issues so they can each be considered on their own merit.
FYI the new builder does pre-render the form and has made performance improvements and is expected to be enhanced to do partial updates in future.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/json-schema-form/angular-schema-form/issues/585#issuecomment-208161079

Btw, when I say hackishly, I would call it 85% quality level. Maybe higher, we'll see!
From: Marcel J Bennett<EMAIL_ADDRESS>Sent: Monday, April 11, 2016 12:41 AM
To: json-schema-form/angular-schema-form
Cc: Robert Taylor
Subject: Re: [json-schema-form/angular-schema-form] Various Enhancements: Enhanced access to actual array element form defs, Dynamic change of other form elements from change handler and more (#585)
@souluniversalhttps://github.com/souluniversal it would help if your suggestions were in separate issues so they can each be considered on their own merit.
FYI the new builder does pre-render the form and has made performance improvements and is expected to be enhanced to do partial updates in future.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/json-schema-form/angular-schema-form/issues/585#issuecomment-208161079

@souluniversal does this offer still stand, I think I understand the code a lot better now and could potentially implement some things. Some of the items are already planned, like a rules engine that can update properties of multiple fields based on conditions. Have you seen the new alphas?


Add stage selection

We want to be able to have defined stages per match. Probably randomized from a finite list, so that we don't repeat levels. Normal levels for tryouts, Dark World for Semis and Cataclysm for the final.

[ ] Set selections upon generating the tournament
[ ] Display in frontend

Not sure if you know this, but:

Note that stages can be eliminated from the random selection pool by pressing the Left Trigger button when highlighted.

From here. All around useful info.


ID what_you_will_need:
User feedback: something
(what_you_will_need)

Question ID
what_you_will_need

Details
I would suggest condensing the first two screens into one. I would basically have something that looks like the first screen, but delete the final paragraph and add a new paragraph with: "If you need more help, you can use the Guide to Legal Help to search for a lawyer or legal services."

Then I would also suggest moving the "When do you need court permission?" screen up to the 2nd screen to better match where that info shows up in the LHI version.
Variable being sought | what_you_will_need
Package version | 0.0.6
Filename | docassemble.MLHMotionRegardingChangeOfDomicile:data/questions/motion_regarding_change_of_domicile.yml

I shifted it to the second screen and tried to get the formatting of the text to look right. Update in commit 77d0004.