Link and period formatting changes

Changes:

Don't show link href in parentheses if link is tautological (normalized href matches content).
Don't add a space prefix before data starting with '.' (also addresses #7 )

This code is a bit hacky but I thought I'd share it anyways. Feel free to merge either change if you think it would be beneficial.
Input:

If you would like to provide feedback please email <a href='mailto:johndoe<EMAIL_ADDRESS>Original output:
If you would like to provide feedback please email<EMAIL_ADDRESS><EMAIL_ADDRESS>.
New output:
If you would like to provide feedback please email<EMAIL_ADDRESS>Issues:

Not i18n.
Potential issues with periods in other contexts.

@gdewald I like this very much, thanks for the contribution!
Best,
Jay


bboot2

Add bboot2

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/104


fix: empty type issue for the jsonschema import

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

fix https://github.com/kcl-lang/kcl/issues/1260
fix: empty type issue for the jsonschema import

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 61.927%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
3245

Relevant Lines:
5240

💛  - Coveralls


ENG-6273 remove API 29 calls

move the implementation from onActivityPostCreated to onActivityStarted in android lib and react native activity callbacks
change min target to 21 in NeuroID module
cleanup

To test this

Create a simulator with an API 21 image. To do this go to Android Studio, tools-> device manager and click on the "Create Device" button. In the pop up choose a hardware profile (Pixel 2 is fine) and click next. Click on the Arm Images tab, scroll the table to an API level 21 system image and click the download icon in the first column (Release Name) to download the image. If the download icon is not there, you already have the image downloaded. Highlight the row, click next and click finish. You don't need to set anything else after you have chosen a system image. You simulator can now be chosen from the device tab.

build the lib and copy to a sandbox app of your choice (layout, fragment, whatever)
run it with your new simulator (choose the proper device in the tab show below) and ensure the events are firing properly.

Let me know if you have any questions. Thank you.

Passed release and debug android libs to Burak. He tested and mentioned "looks fine on 21, 33, 30 and 28".


Update Pipeline Compone Bath Deployment inheritance

Description
Update PipeleComponentBatchDeployment entity and schema inheritance so that the autogen docs no longer inherit unusable attributes form the deployment class
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-ml


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
9d3b8e02ec6ae137292c91c53ccdf0bda2a6fcf5
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
9d3b8e02ec6ae137292c91c53ccdf0bda2a6fcf5
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
9d3b8e02ec6ae137292c91c53ccdf0bda2a6fcf5
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Integrate ChatDev with Langchain

I noticed that since there is no memory hosting the past work done by the custom multi-agent, is it possible to merge the Langchain to store the input/output of past records for each agent to use in future output generation?

not without file injection @run.py time which would hold a tokenized txt file of the conversation history. It would become part of the task_prompt file along with a whole prompt engineering construct, much like the ones we use today except more in depth and increased ability to create rules for an agent.  this is not in the package as of yet. I have started my own run.py version with a link to the file in first draft.  Issue #321
In the end it will inject files where we have to type task, name, org.

So will it requires more token during the task creation?

that would depend on the specificity of the task outline.  more information will define the task better.

@Linuxscot1974  may I know have you tried out the Redis chatGPT memory and if yes, what are the differences between langchain and redis chatGPT memory?

In the end it will inject files where we have to type task, name, org.

So it means that we ended up having more parameters for output creation?


check_dead_providers.py added to return the list of bad requests endp…

@tomkins
the check_dead_providers.py can identify the dead providers and then removed it from list,although i removed the get_embed('http://www.revision3.com/demo')
and
get_embed('http://qik.com/demo')
if only these two which need to be removed was a problem then i think there is no need for check_dead_providers.py.

Hi @isatyamks
Although I've mentioned 2 providers, there's definitely others in that list that no longer exist. Having a script to quickly analyse them might help you find the problematic ones a bit more quickly - the work required for the PR is probably more that you'll need to manually check/curate the list, and show why they're gone.
Also, looking at the history of oembed_providers, https://github.com/wagtail/wagtail/pull/33 is where they originally came from, which references https://github.com/panzi/oembedendpoints/blob/master/endpoints-regexp.json (which is no longer being updated). Over years minor tweaks have been added.
I'm not sure if the script to check providers belongs inside Wagtail itself, and currently it's only checking a small set of providers in that file - not all of them in the main file.

@tomkins  hii , actually i was working on it, and done the mostly the same thing,  Removed defunct providers from oembed_providers.py.

Updated embeds.py to handle width and height values more robustly. but how exactly can I find the other non-existing providers ??


WinUI hosted MFC application and UWP application crashed when more than 122 ListView/GridView loaded. Is it any restriction for the number of ListView/GridView loaded on an application ?

Dynamically loaded 125 ListView(with or without listview item) on a WinUI hosted MFC application.ListView loaded inside a Grid.
Application crashed with an exception.
Exception details from output tab -
Exception thrown at 0x00007FFBE5B44ED9 (KernelBase.dll) in SampleApp.exe: WinRT originate error - 0x80070057 : 'Style1.xaml is not a valid absolute URI.'.
Exception thrown at 0x00007FFBE5B44ED9 (KernelBase.dll) in SampleApp.exe: WinRT originate error - 0x80070057 : 'Style2.xaml is not a valid absolute URI.'.
Exception thrown at 0x00007FFBE5B44ED9 (KernelBase.dll) in SampleApp.exe: WinRT originate error - 0x80070057 : 'Style3.xaml is not a valid absolute URI.'.
'SampleApp.exe' (Win32): Loaded 'C:\Windows\System32\directmanipulation.dll'.
'SampleApp.exe' (Win32): Loaded 'C:\Windows\System32\Windows.UI.Xaml.Controls.dll'.
Unhandled exception at 0x00007FFBE5C1BD3E (KernelBase.dll) in SampleApp.exe: 0xC000027B: An application-internal exception has occurred (parameters: 0x00000264CBF44AC0, 0x0000000000000001).

@codendone or @alwu-msft  ring a bell for either of you?

We need a repro project. This isn't exactly a common scenario.

We need a repro project. This isn't exactly a common scenario.
Project is available at :
https://github.com/VrindaJayan/Sample_StressTestApp/tree/main/SampleApp/SampleApp


Reconnect desktop

@keybase/react-hackers @maxtaco
This allows the desktop to reconnect to the socketfile. Not ideal but I wanted to not touch framed-msgpack-rpc at all

:+1:

https://github.com/keybase/client/pull/1385 is way better than this


Add parser support for 'tag'

Add Parser class for Tag
Edit AddressBookParser to accept tag commands
Add input validation to check for existing tags (non-empty, index followed by existing tag category)
Add TagsOnGuest class to represent the set of tags the user has defined


fix(vite): fix a broken issue when used with @vitejs/plugin-legacy

fix: #2563

Windows is failing. If you can confirm it's a non-issue but more like timeout thing, we could skip the fixture test on Windows

Windows is failing. If you can confirm it's a non-issue but more like timeout thing, we could skip the fixture test on Windows

Yes, it's just a timeout thing


Redirect to new profile path after sign up and show a message

Description of Feature or Issue
closes #44
User is redirected to the new profile path after sign up and asked to create a profile in the welcome message. I think this makes the most sense in terms of the registration flow, instead of waiting for an error message or auto-filling the profile. Had to create a new registrations controller to change the redirect path for Devise.
Checklist

[ ] Added/changed specs for the changes made
[x] Is the linting build successful?
[x] Is the test build successful?

User-Facing Changes

@ChaelCodes I was wondering if this project is still being actively developed? It's been a couple years since most of the issues were opened and was curious if it's back to being active?

Thanks for asking! It is active! I tried to deploy it on stream today. I took a break for over a year because I was on maternity leave. Deployment didn't go so great this time due to some issues on fly.io's side, and it was previously deployed on Heroku, but when they changed their pricing tiers, they deleted my database, so I'm looking for a new more trustworthy hosting provider.

I'm currently in the process of renaming it from ConfBuddies to HallwayTrack or HallwayTracks. HallwayTrack is a really nice name, but there are people squatting on .com, .io, and .xyz, and HallwayTracks is clear.

You could try using Kamal and Digital Ocean/Hetzner! Found it to be a really simple and cheap way to deploy


Add a new webpage

thanks, but the link you are adding here leads to a modified version of the template, not to a personal webpage (while all links in that list correspond to personal webpages). I'm going to close this PR.
btw, the nordic color scheme in the modified looks very cool. would be awesome to add it as an option to al-folio :)


Provide example of how to write a FA2 contract in Archetype docs

Here is the link to the archetype FA 2
https://completium.com/docs/templates/nft
Do not hesitate if questions.

Here is the link to the archetype FA 2
https://completium.com/docs/templates/nft
Do not hesitate if questions.

Thank you again Benoit, you've been a great help. I'm getting an error now when trying to be compliant to TZIP-016 standards requiring an asset named metadata, I get this:

TZIP-012 specification allows for a token_metadata (which compiles successfully), but I want to be compliant with TZIP-016, which is what Temple Wallet is looking for when adding a non-fungible token to your wallet:

Would you know why the Archetype linter is saying metadata has a previous definition even though there is none?

Hi Matthew,
Here is the link to tzip-16 specification with archetype:
https://docs.archetype-lang.org/archetype-language/metadata-tzip-16
For the linter, in archetype, metadata identifier is reserved for a variable typed big_map<string, bytes>, so you cannot use this identifier to name an asset.
Let me know if you have any other questions or comments,


Prebuilt frameworks for 10.22.1

Description
I am expecting to find prebuilt frameworks under the Github release Firebase Apple 10.22.1
I don't see any
Where can I find them?
Reproducing the issue
No response
Firebase SDK Version
10.22.1
Xcode Version
15.1
Installation Method
Swift Package Manager
Firebase Product(s)
Analytics, Crashlytics
Targeted Platforms
iOS, macOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

We did not republish the zip distribution in 10.22.1. It will be available with 10.23.0.
the workaround is to access the corrected GoogleAppMeasurementOnDeviceConversion xcframework from the link in the podspec - https://github.com/firebase/firebase-ios-sdk/blob/main/GoogleAppMeasurementOnDeviceConversion.podspec#L20. (or to use Xcode 15.2 or earlier)


Add placeholder editor form and attribute for applicable fields

issue #6336

I vote for FormElementWithPlaceholder as i tend to name my classes the same way when no distinct word is available that can be placed in front of the class name.

@mdameer, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, .NET Foundation Pull Request Bot

Class renamed to FormElementWithPlaceholder as requested.


[Observ] Add Host metics pannel "Memory Used" group by type

Added in this commit https://github.com/kubegems/dashboard/commit/fc3f69acc4a111ec0fa50e944ca122fefb7812eb


Taxon overview: make the reference genome list little longer

It seems we have more vertical space available in the left panel to make the reference genome list longer. Please make it long enough to display top 10 rows, to avoid scrolling in most cases.
-Maulik

fixed and will be available on alpha soon


Height variables on surveys have two "dropdown" symbols

Seems like auto-prefixer wasn't working for appearance property


Add table styles to CSS layout

Fixes #138

Hey @micbra, thank your contribution, it is appreciated! I'll review your changes later today and merge of applicable :fist:

The new table styles should move to markdown-css dependency - anyway, this looks good to me and could be shipped as preliminary fix with the next patch release.
cc @Dangoo

Thanks @micbra :clap:


Treat warnings as errors in zlint tests

Seems like the right thing to do. This involves both parsing the response and itemizing the warnings and errors as a part of the test failure in a meaningful way.

Namely, I think the API changes will involve some kind of introspection or passing of arguments to the CA type constructor to pass a url + DNS name into it so it can be propagated as the issuerAltName. Right now it's just copied from the issuer settings (a feature of openssl), which is apparently incorrect best I can tell.

Added a ZLINT_WARN so the file doesn't have to be patched. Set it to non-empty in the environment to trigger warnings as errors with zlint.


Add API to return CommandResult for ExternalCommands

ExternalCommands mimic a process that runs in-process but could express their result only as a bool before.
With this change, an ExternalCommand can also set itself as cancelled or skipped on their own logic.
That allows clients to cancel commands if their dependencies exit with an unwanted BuildValue.
rdar://87451647

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Add HTML5 W3C validation

http://stackoverflow.com/questions/18607437/should-i-care-about-w3c-validation

Hey Overbid, great catch! Thank you so much for the PR!

Your wellcome, and thank for fast responss and nice module.


Bump to v0.4.11

C3 moved to a org repo so references to it have been changed.

Thanks for the PR, I'll get this merged and rubygem published by the end of this week once I get my computer running again.

Merged and published.

Cool, thanks man :+1:


🐞 Bad Bundle and CFBundleExecutable

Description
I am having problems when trying to export, sign or upload to TestFlight my application
To Reproduce

Archive Project
Try to Validate or Submit to TestFlight

Expected Behavior
I am not sure what is the problem. Not an expert. I don't know if I am missing something obvious.
Appreciate the help :)
Version Information
CodeEditSourceEditor: [0.7.2]
macOS: [e.g. 14.4.1]
Xcode: [e.g. 15.2]
Additional Context
No response
Screenshots

Looks like this is an issue with CodeEditLanguages, I'll take a look at the framework packaging script there. We may be missing a info.plist key there.


use error

Hello
I use IE Driver.
I run example code. and error occur.
from Screenshot import Screenshot_Clipping
from selenium import webdriver

ob=Screenshot_Clipping.Screenshot()
driver = webdriver.Ie('IEdrver.exe')
url = "https://github.com/sam4u3/Selenium_Screenshot/tree/master/test"
driver.get(url)
img_url=ob.full_Screenshot(driver, save_path=r'.', image_name='Myimage.png')
print(img_url)
driver.close()

driver.quit()

error log
Screenshot_Clipping: line 58, in full_Screensot
  top_height = i + viewport_height
TypeError: unsupported operand type(s) for + : 'int' and 'NoneType'

Script (window.innerHeight) not working in IE.
Hmm...

Hi
Let me check once and get back to you...
Also you can contribute to this project ..

Updated with new scripts for capturing screenshot

Fixed


[HUDI-5420] Fix metadata table validator to exclude uncommitted log files due to retry

Change Logs
When a write transaction writes uncommitted log files in a delta commit, e.g., due to Spark task retries, these log files stay in the file system after the successful delta commit for some time (unlike uncommitted base files, which are deleted based on the markers).  The delta commit metadata does not contain these log files, and the metadata table does not contain these entries either.  This is a valid case where the metadata-table-based file listing (providing committed data files) is different from the file system (providing committed data files + uncommited log files in this case).

This PR fixes the logic of the metadata table validator to check whether the difference in the list of log files between metadata table and direct file system is due to committed log files, based on the commit metadata.
The PR is tested locally with such a case.  Before this PR, the metadata table validator throws an exception.  After this PR, the validator succeeds.
Impact
This PR improves the robustness of the metadata table validator so that it does not fire false alarms for the valid case above.
Risk level
low
Documentation Update
N/A
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Ack! Will review this pr later this week.

Let's ignore MDT for now. I have some basic doubt on MOR table inner workings.
So, how does extraneous log files are ignored while reading a committed data from DT?
ie. let's say we make commit3 which had some spark retries. So, instead of logFile1, we now have logFile1 and logFile2, where only logFile2 is valid. our marker based re-concilliation is not going to delete nor add rollback block for logFile1.
So, when someone does snapshot read, where exactly we skip logFile1? It should be part of AbstractLogRecordReader right. I could not locate it only.

Patch looks good from MDT validation standpoint.

Let's ignore MDT for now. I have some basic doubt on MOR table inner workings.
So, how does extraneous log files are ignored while reading a committed data from DT? ie. let's say we make commit3 which had some spark retries. So, instead of logFile1, we now have logFile1 and logFile2, where only logFile2 is valid. our marker based re-concilliation is not going to delete nor add rollback block for logFile1. So, when someone does snapshot read, where exactly we skip logFile1? It should be part of AbstractLogRecordReader right. I could not locate it only.

Based on my understanding, the extraneous logFile1 or particular log block from a successful commit is read for snapshot query if the file or the block is not corrupted, e.g., partially written.  Correctness-wise, it should be okay as long as the update logic generates the same merged payload after applying the same change log twice.


Use print() function in both Python 2 and Python 3

fixes: #684
This PR pulls the core changes from #683 as requested by @KennethNielsen.  After this PR has landed, we can determine what to do with #683.

On the flake8 test selection, this PR does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect).  Instead these tests are focus on runtime safety and correctness:

E9 tests are about Python syntax errors usually raised because flake8 can not build an Abstract Syntax Tree (AST).  Often these issues are a sign of unused code or code that has not been ported to Python 3.  These would be compile-time errors in a compiled language but in a dynamic language like Python they result in the script halting/crashing on the user.
F63 tests are usually about the confusion between identity and equality in Python.  Use ==/!= to compare str, bytes, and int literals is the classic case.  These are areas where a == b is True but a is b is False (or vice versa).  Python >= 3.8 will raise SyntaxWarnings on these instances.
F7 tests logic errors and syntax errors in type hints
F82 tests are almost always undefined names which are usually a sign of a typo, missing imports, or code that has not been ported to Python 3.  These also would be compile-time errors in a compiled language but in Python a NameError may be raised which will halt/crash the script on the user.

Looks good. Merged. Please add a note to the release notes issue #674 about there changes.


Not possible to create a vacant parent node.

There seems to be no way to create a node with an empty child set. Not quite sure if that is an issue. It probably is in some cases. Anyway it seems strange this cannot be done. For example:
	node "empty" {}
	node "empty" { value "''" }
	node "empty" { value "'abc'" }
        node "parent" { copy "0" }
	node "parent" { if "0" { node "a" { } } }

Output:
	empty ""
	empty ""
	empty "abc"
	parent ""
	parent ""

The last 2 examples could/should create a vacant parent node, e.g. parent { }. The logic being that if the compound statement contains another node or copy statement, a parent node is implied, but will be vacant if no actual child nodes are created.
It is an odd way to create a parent that is deliberately vacant, but how often will you need to do this anyway?

Available as of 1.3.1.


Handle IAM constraint expressions that are null

It's possible to create IAM constraints that don't have any expressions in them (not saying there's a good reason, but it's definitely possible!).
I've been running into this as an error when attempting to deploy the app 😅 This patch addresses those cases by failing out similar to unconditional role assignments.

Thank you for creating this PR!


Available players is not populated in addWinDialog

This was an issue with grabbing the userlist. I was using a new ParseQuery("User") when I should have used a new ParseUser.getQuery()


Feature Request: Let downloader plugin be aware of Chart and Release information

It could be nice to let downloader plugin be aware of Chart and Release information, especially when the plugin is used to download value files.
This let the availability for plugin to fetch config files that depends of chart name or release name.
This already be supported the case for the kubeContext and the installation namespace.
Theses informations can be exposed through environment variables  like actual ones.
Maybe something like :

HELM_CHART_NAME : The chart name given to the helm command (only when downloading values files).
HELM_RELEASE_NAME : The release name given to the helm command (only when downloading values files).
Maybe there is others relevant informations that depends of Chart & Release, that I don't see.

For now, there is a workaround to do that, only when the user specify these information in the helm command.
The plugin can get the parent process and re-parse all commands args ; this is not ideal and it's not works with --generate-name and --name-template flags.
I'll be glad to make a PR on that subject, if you think this is relevant.

Can you provide a use case for adding this functionality?
To provide some context, Helm is a package manager like apt, yum, homebrew, etc. Making decisions about what package to install in what situation is usually something a higher level tool would do. Something like helmfile or one of the Helm based operators.
With that in mind, what is the use case and how do you see this fitting in with Helm?

Yes of course.
Context:
I've installed a plugin that implement the Downloading plugin part; to handle a scheme.
For exemple:

https://github.com/jkroepke/helm-secrets
https://github.com/aslafy-z/helm-git

When
I run some chart lifecycle commands like : helm template|install|upgrade, with a value file that will be handled by a downloader plugin
Eg.
helm template . -f config://config-name
helm template . -f git+https://github.com/jetstack/cert-manager@contrib/charts/values.yaml?ref=v0.5.2
helm template . --generate-name -f secrets://my-secrets.yaml

Actual state
These plugins receives some information form the helm command :

All positional arguments of downloader plugin : command certFile keyFile caFile full-URL
All plugin environment variables : described in this section

On these information there for exemple the namespace where the helm command is currently operate in.
Expected
Give the availability to these plugin when acting to download a value file, to know some relevant information about the Chart and the Release currently proceed by the Helm command.
As I propose below, there as least two relevant information that are relevant in theses cases :

The chart name given to the helm command
The release name given to the helm command

Possible Solutions

Add theses information though environment variables
Add theses information as optional positional argument of the downloader plugin. For exemple : command certFile keyFile caFile full-URL [charName] [releaseName]

I hope this was understandable.
I'll be glad to complete my purpose if needed.
I've start something more specific to my personal use case here: https://github.com/jBouyoud/helm-config-scheme/.

@mattfarina anything that i can do to help you ?

@mattfarina could you please find my answers in the previous post. How can I help to get a response ?

@mattfarina could you please find my answers in the previous post. How can I help to get a response ?

@mattfarina any chance to continue the discussion ?
I'll be glad to make a PR on that subject, if relevant.
According to your comment :

To provide some context, Helm is a package manager like apt, yum, homebrew, etc. Making decisions about what package to install in what situation is usually something a higher level tool would do. Something like helmfile or one of the Helm based operators.

This change only expose new information (chart-name and release-name) to your downloader plugin interface. Helm doesn't make any new decisions. That's why I convince that's relevant.


Secure default security groups in core, non-default VPCs

Relates to https://github.com/ministryofjustice/modernisation-platform/issues/1191
Addition of the aws_default_security_group to the vpc-hub module to bring management of the default security group for the non-default VPC under Terraform. Removing the default inbound and outbound rules as per recommended best practice.

An update regarding the state of this PR.
Code changes approved. Merging (and TF applies) dependent on confirmation of replacement actions that Terraform will do on TGW route table routes and subnet route table routes across logging, security and shared-services accounts.


Task implementors/users get often-surprising caching behaviour when file inputs have no explicit normalisation/path-sensitivity

It is currently possible to “cache enable” most tasks by adding @Cacheable or using the corresponding runtime API. When doing only this, users sometimes get behaviour that appears to be correct, but is actually often not fully correct.
The problem arises from file inputs by default not being considered portable. That is, we effectively default to PathSensitivity.ABSOLUTE, which is often not what is actually wanted. Indications are that users are not intentionally using this default. Instead, they are either unaware of the concept of input portability or have forgotten about the property. This has the result of effectively masking the problem.
Our proposed increment for improving this situation is to consider a caching ineligible for caching if any file input property does not have an explicit normalisation/path-sensitivity declared. This ineligibility would be expressed using the existing mechanism that we use for other configuration problems (e.g. overlapping outputs, lambda inputs etc.) and would be observable in the same way. Future work may increase the visibility of this and other related problems.
The net effect of this change is that tasks that declare themselves to be cacheable, but have any file input property declared without a normalisation would no longer be considered cacheable.

Would we emit a warning to the console if a task is @Cacheable but we decline to cache it for the reasons stated? That would be an improvement over a silent failure.

@autonomousapps The feature will not be silent - we will report that caching is disabled via the caching disabled reason. This currently shows up on the info log and is prominent in build scans.

@autonomousapps commented on Oct 12, 2018:

Well, I have confirmation from Google that at least one plugin author is intentionally relying on absolute path-sensitivity. It's nice to be proven wrong so decisively. Here's what Ivan Gavrilovic just said to me by email:

When it comes to path sensitivity, we cannot use relative path sensitivity because of our transforms (com.android.build.api.transform.Transform). Relative path sensitivity breaks the incremental build correctness for them (that is one of the reasons why we have our Android Build cache for dexing). Good news is that we are moving away from those, and migrating to Gradle ArtifactTransforms, which are cacheable.

I admit I don't understand why relative path-sensitivity would break incremental build correctness for those tasks, but maybe I can find someone to explain that to me.

@ldaley commented on Oct 12, 2018:

This change would mean that that task would stop being cacheable until they explicitly add the absolute path sensitivity declaration.

@wolfs commented on Oct 23, 2018:

This issue should probably be solved by doing #833 and then https://github.com/gradle/build-cache/issues/600.


Incorrect registry path

In the section 'Set the AllowWUfBCloudProcessing policy', step 8 says to confirm the policy is applied by checking a registry key.  The correct location to check is
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\PolicyManager\ current \System\AllowWUfBCloudProcessing  (not under the 'default' key)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a62218bc-5b18-dd96-b434-81b6bea709ac
Version Independent ID: 68df8404-dea4-6973-f74c-c6c39d912e22
Content: Windows Update for Business deployment service - Windows Deployment
Content Source: windows/deployment/update/deployment-service-overview.md
Product: w10
Technology: windows
GitHub Login: @jaimeo
Microsoft Alias: jaimeo

I'm not in this area anymore. @dougeby

Hello @jholl016 ,
agree, but I believe it should be ..\current\device.. , not just ..\current..
I created the PR
Thank you


It would be nice if the global help were grouped by noun (release, stemcell, etc.)

I would like to be able to see everything I can do to a release, followed by everything I can do to a stemcell, etc. This makes it easier to parse the help and find what I'm looking for.
e.g.
Stemcells:
  stemcells              List stemcells (aliases: ss, stems)
  delete-stemcell        Delete stemcell (aliases: dels)
  upload-stemcell        Upload stemcell (aliases: us)

Releases:
  releases               List releases (aliases: rs, rels)
  create-release         Create release (aliases: cr)
  delete-release         Delete release (aliases: delr)
  export-release         Export the compiled release to a tarball (aliases: expr)
  finalize-release       Create final release from dev release tarball (aliases: finr)
  init-release           Initialize release
  inspect-release        List all jobs, packages, and compiled packages associated with a release (aliases: insr)
  reset-release          Reset release
  upload-release         Upload release (aliases: ur)

that would be very nice. possibly will have to PR to go-flags.

Closing and re-opening to trigger a github story

Hello,
It looks like we have not responded to this in a reasonable time, and unfortunately a year has passed. Given this, we are going to close the issue, but please feel  free to re-open the issue. In doing so, a new Pivotal Tracker story will be generated, and we can revisit this.
Thanks again for submitting this, and apologies for closing without a proper resolution at this moment.
BOSH Systems Team - @aashah @luan @jaresty


Don't discard labels for local stats

This addresses #279 by adding recording the labels / values on the LocalStat type in lib/metrics.
As I alluded to in the godoc, I used this for testing a custom processor that could count metrics in different ways depending on the messages it was processing.

Hey @bigkevmcd, looking good. There's technically a breaking API change here in GetCounters() and GetTimings(), I doubt anyone is using those methods externally but it would be good to find a backwards compatible work around.

@Jeffail Hi, thanks for the review, yeah, that wasn't a good idea, I've reverted and extended the API.

Ace, thanks @bigkevmcd! I'll take a look later at exposing this via the http metrics output.


Debug toolbar contributed action not aligned when only title is provided

Issue Type: Bug
Testing https://github.com/Microsoft/vscode/issues/69196
Only when the toolbar is floating:

VS Code version: Code - Insiders 1.32.0-insider (393b48d4a5de85b6fa1d2ad0a59588d6715e12ea, 2019-02-25T01:33:51.804Z)
OS version: Darwin x64 18.2.0

I do not really care about this since we do want the extension authors to contribute icons.

Pine also hit it. Assigning to on-deck


docs,fix: Mostly JSDoc tweaks; update deprecated substr() to substring().

Whoops.  Wrong base branch! Will reopen after rebasing…


Drop support for gtk-primary-selection

The last blocking consumer of gtk-primary-selection now supports the standard protocol: https://gitlab.gnome.org/GNOME/gtk/-/issues/2591#note_920637 (released in GTK 3.24.24).

[x] Remove gtk-primary-selection from Sway
[x] Remove gtk-primary-selection from wlroots

GTK 3.24.23 doesn't contain the patch, we'll need to wait for the next release.

GTK 3.24.24 released 2 days ago contains the patch.

These commits break a PRIMARY buffer in some applications, e.g. Firefox ESR on Wayland (and consequently Tor Browser Alpha). And it was removing support from Sway that broke the buffer, even though I have gtk version 3.24.29 (Arch Linux). Can you keep gtk-primary-selection support for now?

GTK 3.24.29 should support the new protocol. Not sure what's going on here.

Can you keep gtk-primary-selection support for now?

Sorry, no.

GTK 3.24.29 should support the new protocol. Not sure what's going on here.

However, manually returning support for gtk-primary-selection to Sway fixed the problem. I conclude from this that support for the old protocol remains in gtk.

Yes, support for the old protocol is still there. But it should also support the new protocol.


Version of pre-release NuGet packages should be increased

It looks like you forgot to increase the version number for dev packages after the release of 6.3.0. Because right now all current dev packages on NuGet are seen as older as the last stable version.

Good point, thank you!
Release 6.3.1-devXXXX is on the way. :)


docker-compose localstack

@NetanelBasal  resolved #2 just added s3 to the env on docker-compose file

It does not work without it? I think the default is all services

Yes you're right the default is all service,
Are you saying i should map a different port for S3

No. I would like to have a live example in the code. For example:
https://www.zeolearn.com/magazine/uploading-files-to-aws-s3-using-nodejs

Okay will do my best
Thanks

@NetanelBasal pls kindly check it out and review


fix validation against commit and images, add scenario to prevent rol…

Description
Fix the validation under commitId and images
Prevent rollback on update when pass commitId
Add tests
Fixes # (THEEDGE-2654)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[X] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[ ] I run make pre-commit to check fmt/vet/lint/test-no-fdo

Codecov Report
Base: 36.94% // Head: 37.35% // Increases project coverage by +0.41% :tada:

Coverage data is based on head (62b0a55) compared to base (865a515).
Patch coverage: 90.90% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1606      +/-   ##
==========================================
+ Coverage   36.94%   37.35%   +0.41%
==========================================
  Files          66       66
  Lines        8757     8764       +7
==========================================
+ Hits         3235     3274      +39
+ Misses       5133     5098      -35
- Partials      389      392       +3

Impacted Files
Coverage Δ

pkg/services/commits.go
38.46% <87.50%> (+38.46%)
:arrow_up:

pkg/routes/updates.go
32.81% <100.00%> (+0.92%)
:arrow_up:

pkg/services/errors.go
41.17% <100.00%> (+6.23%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Default button styles not respecting theme overrides

Bug report
Required System information

Node.js version: v14.18.1
NPM version: 6.14.15
Strapi version: 4.1.12
Database: sqlite
Operating system: macOS 12.4

Describe the bug
When overriding theme variables, default buttons do not seem to be overridden
Steps to reproduce the behavior

Clone https://github.com/samturrell/strapi-button-bug
Copy .env.example to .env
Run yarn strapi develop --watch-admin
Open the UI at http://<IP_ADDRESS>:1338/admin
Log in with email<EMAIL_ADDRESS>password: Example1!
Navigate to the content manager http://<IP_ADDRESS>:1338/admin/content-manager/collectionType/api::page.page?page=1&pageSize=10&sort=title:ASC
Observe the button in the top right
Hold down left click on the button in the top right
Observe that the overridden theme values are applied for this state

This is consistent across the strapi UI where the button variant is default
Expected behavior
The button should utilise the provided theme values for the default state
Screenshots
Default state:

Active state:

Code snippets
N/A
Additional context
N/A

@samturrell Could you share your configuration file, which is used to do the overriden, with us? I'm currently looking at this plugin and to me it seems, as if theming for these buttons does work as expected.

@samturrell Could you share your configuration file, which is used to do the overriden, with us? I'm currently looking at this plugin and to me it seems, as if theming for these buttons does work as expected.

Hi @gu-stav - the reproduction repo above should have everything you need, let me know if not.


Increase limit for float vectors to 2048

Summary of the changes / Why this improves CrateDB
This increases the limit for float vectors to 2048 by overriding the Lucene FieldType.
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

retest this please

retest this please

retest this please

It looks like the Lucene community actually close to agree on a 2048 limit
https://github.com/apache/lucene/issues/11507#issuecomment-1585637725
Especially with the improvements of project panama which look promising
https://github.com/apache/lucene/issues/11507#issuecomment-1607892454

The limit is also mentioned in https://github.com/crate/crate/blob/master/docs/general/ddl/data-types.rst which would need an update. (And it would be really cool if we could also mention scaling behavior with larger dimensions if there is data about that, e.g. does indexing cost increase linear/exponential/other, and how does it affect storage space)

I added the feedback and added a rationale in the commit message. Regarding scaling etc., this will need some more research probably by looking into other projects that use the Lucene vector support. I will do this as a follow-up.


CBMC memory-safety proof for DNSgetHostByName_cancel

Description
This PR includes the CBMC proof for memory safety of the DNSgetHostByName_cancel function.

Checklist:

[x] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dan4thewin I have addressed your comment.


Search / synapses filters broken

as per title, not much to add, just try to search for 2 neurons and use the synapses filters

@zsinnema this is still a valid issue, tested in the deployment.
Search for AIBR and ADAL, open the search filter, select AIBR as pre.
You will notice that the search will hang with the spinner indefinitely.
Thx

@ddelpiano I've tested it with branch feature 281 and I get results, and no js error

@ddelpiano this is the PR: https://github.com/MetaCell/geppetto-NeuroSCAN/pull/286

Hi guys-
Bill Mohler here.  I built all the models in NeuroSCAN.  And the code for
CytoSHOW which creates and displays them in Java.
Regarding synapses, the nomenclature was designed specifically so simple
regex searches could pull out whichever relavent synapses a user desires.
Sounds to me like you guys may be using a more indirect route. I would be
happy to consult/advise/learn on this or any other topic...
Bill Mohler
UConn Health
WormGUIDES.org
Collaborator with Daniel and Noelle at Yale.
On Mon, Jan 31, 2022, 2:36 AM Zoran Sinnema @.***>
wrote:

@ddelpiano https://github.com/ddelpiano this is the PR: #286
https://github.com/MetaCell/geppetto-NeuroSCAN/pull/286
—
Reply to this email directly, view it on GitHub
https://github.com/MetaCell/geppetto-NeuroSCAN/issues/281#issuecomment-1025455228,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA4S3A3FXTG4FQJF2HW4X4TUYY3XNANCNFSM5MHAASIQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Tests broken when not building with spiner

#330 added a test for the Bounds class that depends on spiner. When building without spiner, this breaks the tests.
An #ifdef is needed.

Oops my bad. #406

No worries! I should have caught that in my review


Fixed string/int comparison issue

Quick fix for https://github.com/signalsciences/SigSciApiPy/issues/8

LGTM

This change is actually a temp workaround. I fixed the actual issue so this PR is no longer needed.


Update mkdocs-material to v9.0.1

Update mkdocs-material to v9.0.1
Add back the navigation footer
Add back the copy button to code blocks (mainly relevant for contribution guidelines)

Pls review & approve


package.json is not filled with user content

It has hardcoded placeholders. Please change them to template instead.

Also README.

Should be fixed, if README is still messed up, open a new issue please.

I mean, this should also have template placeholders...


Create: funding.json for Retro Funding Round 5

Add: funding.json for Retro Funding Round 5

Description
Sunnyside Labs is applying to Retro Funding 5. From Retro Funding Round 5, the application is required to add the JSON file to prove that the applicant is a contributor to the repository.
Tests
N/A
Additional context
N/A
Metadata
N/A

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.30%. Comparing base (48f5313) to head (5a8315d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   72.30%   72.30%
=======================================
  Files          16       16
  Lines        2723     2723
=======================================
  Hits         1969     1969
  Misses        670      670
  Partials       84       84

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Closing until confirming with the Proof team about this.


runtime.malg: memory leak

Go version
go1.22
Output of go env in your module/workspace:
GO111MODULE='off'
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/user/.cache/go-build'
GOENV='/home/user/.config/go/env'
GOEXE=''
GOEXPERIMENT='nocoverageredesign'
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/user/go/go-code-sparse/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/user/go/go-code-sparse'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/user/.cache/bazel/_bazel_cdvr/0afdc4359d915c9cfae96806c9f27c6f/external/go_sdk'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/user/.cache/bazel/_bazel_cdvr/0afdc4359d915c9cfae96806c9f27c6f/external/go_sdk/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.1 X:nocoverageredesign'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD=''
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build4070154476=/tmp/go-build -gno-record-gcc-switches'

What did you do?
Recently we found on our production servers profiles considerable high memory utilization (50MB) for goroutines, but we couldn't find anything in the goroutine profiles. After a while we discovered this is because there was an spike of goroutines several hours before.
We replicated the scenario with the following code:
package main

import (
        "fmt"
        "net/http"
        _ "net/http/pprof"
        "runtime"
        "sync"
        "time"
)

func main() {
        // Start pprof server
        go func() {
                http.ListenAndServe("localhost:8080", nil)
        }()

        // Create a WaitGroup to wait for all goroutines to finish
        var wg sync.WaitGroup

        // Start half a million goroutines
        size := 100_000
        wg.Add(size)
        for i := 0; i < size; i++ {
                go func() {
                        compute()
                        wg.Done()
                        wg.Wait()
                }()
        }

        // Wait for all goroutines to finish
        wg.Wait()

        fmt.Println("Done")

        // Run GC every second forever
        for {
                runtime.GC()
                time.Sleep(time.Second)
        }
}

// compute performs some simple computation
func compute() {
        for i := 0; i < 1000; i++ {
                _ = i * i
        }
}

I ran it like:
GOMAXPROCS=2 GODEBUG=gctrace=1 go run /tmp/main.go

What did you see happen?
GC trace
gc 512 @521.755s 0%: 0.020+25+0.002 ms clock, 0.041+0/12/23+0.005 ms cpu, 43->43->43 MB, 88 MB goal, 0 MB stacks, 0 MB globals, 2 P (forced)
Heap

Goroutines

It seems the issue comes from:
https://sourcegraph.com/github.com/golang/go@go1.22.1/-/blob/src/runtime/mgcmark.go?L316-318
I see that we do cleanup for stacks for Gs with stacks, but we never cleanup Gs without stacks, we just keep appending:
	lock(&sched.gFree.lock)
	sched.gFree.noStack.pushAll(q)
	unlock(&sched.gFree.lock)

What did you expect to see?
I'm not sure if this is a known issue or an intended behavior, but the only way for us to clear up that memory is by restarting.

Dup of #65864 ?

Dup of #65864 ?

Yes, should I close this one and comment over there?

Yes, thanks.


Cleanup the synthetic key press messages

These are in RecursiveBlock.js. Here is console message:
RecursiveBlock.js?7d03:55
SyntheticBaseEvent {_reactName: 'onKeyUp', _targetInst: null, type: 'keyup', nativeEvent: KeyboardEvent, target: div, …}

@larsgson Do you know what this is about? Is it still a problem?

@larsgson believes that this is in Xelah


Add search

Search bar is not functional right now
Maybe helpful: https://medium.com/nexl-engineering/search-autocomplete-suggestions-with-graphql-query-and-react-hook-3f920215bb9d

https://github.com/JabRef/jabref/issues/7423

Use: https://github.com/darrenjennings/vue-autosuggest

Graphql endpoint also needed for word addin: https://github.com/JabRef/JabRef-Word-Addin/issues/101

@mohit038 This is now implemented, using the filterBy: query argument to me.documents.


About Generating Other Types of Point Clouds in the Dataset

Hello, I would like to ask you again. If I want to generate other types of point clouds, such as "guitar, bag, phone", what else do I need to do besides modifying the class alias I want to generate? (I'll try it out, the generated point cloud is completely different from the actual shape)

do you have wechat(微信？) we can talk there.

you can send it to my email<EMAIL_ADDRESS>

I can generate guitar, I never tried bag or phone. You may provide more details to me so I can know what is wrong. I think wechat is more convenient.

@yztang4 Okay, I have sent my WeChat to you via email. Please check it. Thank you


remove_task_bar not working with multi_monitor

I have both remove_task_bar and multi_monitor set to true and I have a triple monitor setup. The task bar is only removed on the primary monitor and not the two secondary monitors when in work mode.
Please let me know what I additional information I can provide.

One thing I'd need your help with is finding the name of the third taskbar.
Currently wwm supports only the first and second monitor (so if your second monitor doesn't work then that's definetly a bug).
The first monitor taskbar is called Shell_TrayWnd
The second monitor taskbar is called Shell_SecondTrayWnd
Could you please download WinSpy (a tool for inspecting the properties of a window).
After starting WinSpy you will get a window like the following

if you click on the finder tool it will provide a list of currently open windows

afterwards you can click on the more button to see a list of open windows

usually the first item in the list are the Windows 10 windows and there you will be able to find the taskbar windows.
They will look like in the following image

The please tell me the name of the third taskbar.

I think it might be a bug, because for me only the the task bar on the primary monitor is removed, both the second and third monitors do not get the task bar removed. I think the issue might be is Windows labels all task bars after the first one as SecondaryTrayWnd like you mentioned, even when there is more than two. As seen in the following WinSpy screenshots:

When I click on the "000701D8 Shell_SecondaryTrayWnd" and click the flash button the task bar on my second monitor flashes, and when I click on "004E0328 Shell_SecondaryTrayWnd" and click the flash button the task bar on my third monitor flashes. Of course clicking on "000100FE Shell_TrayWnd" flashes my primary monitor.
Unplugging one of the monitors and the as you mentioned the removed task bar seems to work as expected when only two monitors are present.
Basically I think the duplicate naming of the task bar in multi-monitor setups as Shell_SecondaryTrayWnd, seem to be the cause of this bug.
Please let me know if there any additional testing and screenshots you would like me to do.

I think this will be easier to fix than I initially thought. Everything below this line are notes for myself.
Use EnumWindows to enumerate all windows and filter for windows that contain the pattern ^Shell_(Secondary)?TrayWnd$ instead of using hardcoded strings. To find out which monitor holds the window you can use the MonitorFromWndow function.

Thank you for your help!

This should be fixed in the latest dev build.

So far this seems to fix the issue. Thanks!
When you officially merge these changes into the release version you should make a note that the monitor numbering scheme has changed. People might be confused when their workspaces  seem to not be mapped correctly. As before this build my monitor number 1 was not my primary monitor, but rather one of my secondary. In this build my primary monitor is number 1 which is the correct way in my opinion.

I think I closed this issue a bit too soon. It seems the task bar being removed on all monitors only works sometimes, then it gets stuck after sometime and it will either remove the task bar only on the primary monitor or only remove it on the secondary monitor. The only fix I have seemed to find is a complete system restart, even restarting wwm or toggling the remove_task_bar setting doesn't seem to fix the issue.

One thing I noticed is that this can be fixed by also restarting wwm (at least on my machine), so I think it has to be some form of a race condition. I'll try to look at the logs when this happens the next time for me.

I fixed the problem on my own computer (The taskbar on both monitors now become hidden 100% percent of the time), but I never experienced wwm being "stuck". Can you explain a bit more what you mean by this or whether the newest dev build fixed the problem for you?

Yeah I have been trying to reproduce the issue and can't seem to isolate it. I'll test out the latest build and see if that helps. For now I close this issue again until I can reproduce the bug reliably, because like you said for the most part restarting wwm seems to fix it most of the time. Thanks again!


AP-279 store ayden payment methods as shopware payments

Code Review of AP-279.


Setup No IP on the Linux machine.

Open the port on the router.

Not needed anymore... I'll use torrents and the website as permanent storage...


ARROW-6874: [Python] Fix memory leak when converting to Pandas object data

@wesm @jorisvandenbossche would you like to review?

Looking.


Hello. After updating vscode on 2022-09-18, using vscode to open the project does not do anything, the computer memory usage is very high

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:
1.Hello. After updating vscode on 2022-09-18, using vscode to open the project does not do anything, the computer memory usage is very high. It takes up 4 GB of memory when opened

/needsMoreInfo including platform, and whether the problem is being caused by one of your extensions. You can use the Start Extension Bisect command to investigate that.

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

Hello, the platform used is windows10

vsCode and plugins. I completely removed and reinstalled

horrible

Please use Command Palette (F1) to run the Start Extension Bisect command, then follow its instructions.

/需要更多信息，包括平台，以及问题是否由您的某个扩展程序引起。您可以使用“启动扩展一对二”命令来调查这一点。

信息已回复

Please use Command Palette (F1) to run the Start Extension Bisect command, then follow its instructions.

hello. disabled ' Vue Language Features ' Memory restored to 1.5g

/causedByExtension

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!

/causedByExtension

After the plugin is removed, it works fine, thank you very much


Bug - Flexbox exercises: tags linked to google.com don't go to google

Complete the following REQUIRED checkboxes:

[x] I have thoroughly read and understand The Odin Project Contributing Guide
[x] The title of this issue follows the Bug - location of bug: brief description of bug format, e.g. Bug - Grid exercises: CSS not properly linked to HTML files

The following checkbox is OPTIONAL:

[x] I would like to be assigned this issue to work on it

1. Description of the Bug:

There is a list of  links, that should be redirected to google.com. But the links are missing the https:// protocol, and it leads to a GET error (as it is redirecting to my own repo, on google.com)
2. How To Reproduce:

Visit the lesson page (flex/03-flex-header-2/index.html)
Click on any link

3. Expected Behavior:

1.After visiting the lesson (as in 2), by clicking any link you should be redirected to google.com
4. Desktop/Device:
Didn't fill this info because it's a really simple bug, happens anywhere that i tested (motorola g10, windows and linux)
Tested in Edge, Chrome and Safari
5. Additional Information:

tags linked to google.com don't go to google #453

Flex Header 2

        LOGO

link-one
link-two
link-three

        1 new notification

@ojuliocode while the purpose of the links isn't for them to be functional, I can see how it can still be confusing. I'll assign you if you'd still like to make this update. Would you mind also checking other instances we're using anchor tags in the CSS exercises?

@ojuliocode checking in if you'd still like to work on this

Hi, sorry for the delay! Currently I dont think I would be able to work on this. When I posted the issue I was on vacations and looking for some open source to contribute. Now unfortenetly I don't think I could do this due to time

Absolutely, sorry for the delay. Already made the pr


Fix Pi executable and downgrade Electron

Downgrading to Electron 16 seems to fix the performance issue on Pi.
https://forums.raspberrypi.com/viewtopic.php?t=338778

If I upgrade to Electron ^26.1.0, I get the following in my terminal.
MESA-LOADER: failed to retrieve device information
MESA-LOADER: failed to retrieve device information
MESA-LOADER: failed to retrieve device information
MESA-LOADER: failed to open kms_swrast: /usr/lib/dri/kms_swrast_dri.so: cannot open shared object file: Permission denied (search paths /usr/lib/aarch64-linux-gnu/dri:\$${ORIGIN}/dri:/usr/lib/dri)
failed to load driver: kms_swrast
MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: Permission denied (search paths /usr/lib/aarch64-linux-gnu/dri:\$${ORIGIN}/dri:/usr/lib/dri)
failed to load swrast driver

Performance doesn't seem to be an issue after I reinstalled the Raspberry Pi OS.


updated generated src after interface changes

@JamieHouston so I noticed you didn't check in the updated generated src files after you made the "I" interface change, so this PR is doing that


Fix details expanded state not announced on iOS

For some reason, setting display: inline-block on the summary means that VoiceOver on iOS no longer announces the expanded state of the <details> element.
We were using display: inline-block so that the interactive area and the focus state (when visible) were constrained to the text within the <summary>.
We can achieve the same thing by using display: block with width: fit-content.
However, now that we’re no longer using display: inline-block [^fn1], the the 5px bottom margin on the summary and the 30px bottom margin on the details now collapse when the <details> is closed except in Chrome which has been updated to use content-visibility.
Preserve the existing margin on the component and make the behaviour across browsers consistent by establishing a new block formatting context using display: flow-root, preventing the margins from collapsing.
Safari < 13 does not support display: flow-root and so the margins will collapse, which means these older versions of Safari will have 5px less margin than when we were still using display: inline-block.
EDIT: We've dropped the commit that added display: flow-root to the root details element as we removed the extra spacing in https://github.com/alphagov/govuk-frontend/pull/5352, bypassing this issue. Therefore the previous 3 paragraphs are out of date. I'm preserving Ollie's description if we ever wanted to bring the spacing back in.
Fixes #2349
Fixes #4972 (whilst this PR doesn't address 4972 directly, we did explore this option and it unfortuantely doesn't make a difference. This solution has been our most successful so far)
[^fn1]: ‘margins of inline-block boxes do not collapse (not even with their in-flow children)’ – https://www.w3.org/TR/CSS21/box.html#collapsing-margins

Spreadsheet for testing:
https://docs.google.com/spreadsheets/d/1Z7SxQcK-HcwScI_dbSDLwidL7mDctsN0aFPLHaMPmK8/edit?gid=0#gid=0
So far I've not observed any changes other than in Safari on iOS 17.5.1 (21F90) where we see the desired improvement, with the expanded state announced on toggle and when returning to the summary:

Scenario
Before
After

When summary is focused (closed)
Help with nationality, button, collapsed. Double-tap to expand.
Help with nationality, button, collapsed. Double-tap to expand.

When toggling open
Help with nationality.
Help with nationality, expanded.

When summary is focused (open)
Help with nationality, button.
Help with nationality, button, expanded. Double-tap to collapse.

I don't have access to test with TalkBack on Android – it'd be fab if someone else was able to help with that.

I've had a quick look at the margin issue mentioned in the description and I'm going to make the bold case that this isn't worth worrying about. As Ollie mentions, Safari <13, so 12 and lower, for both mac and iOS will functionally have 5px less margin. You can see this illustrated in the below screenshot of Safari mac 12.1 where the margin collapses into the focus state bottom border:

Safari 11 and 12 fall under Grade C in our browser support model which states the following about bugs in those browsers:

For grade C browsers we:

might remove support for individual features in these browsers at any time without considering them a breaking change
will not regularly test in these browsers
will not fix bugs affecting these browsers unless they prevent a user from being able to complete their task, or we can fix the bug by disabling a feature

I'm using this policy and the low impact to visual rhythm for Safari 12 and below users to justify not implementing a fix for this.

I definitely think its worth fixing for all versions of the browser, but to answer to main question yes the answer sounds right to be, scrapping the extra 5px sounds like it should work. Without looking at the reasoning for it, I can’t really see why it would be there in the first place.

Added a PR to tackle the spacing of the details element separately https://github.com/alphagov/govuk-frontend/pull/5352

Just to give a bit more context that I had shared with the team internally last week...
I have tested this in other iOS versions, and I've also tested the native version. Results from that are in the spreadsheet.
(Back in June I had also tested on TalkBack and updated the spreadsheet. The result was that there was no difference.)
VoiceOver iOS 17.5.1
Both the native version and the version from this PR work as expected.
While our old version doesn't.
The fact that the native version works as expected also makes clear that it was our CSS changes to display that caused the issue (together with the bug in iOS and/or VO that makes this behaviour possible).
VoiceOver iOS 15.8
None of the versions work.
Even the native version only says the text of the summary with nothing else announced.
VoiceOver iOS 12.5.7
Interestingly, the native version as well as the version from this PR worked okay.
And our old version doesn't.
That's an indication that that was a regression in iOS, either in version 13, 14 or 15.
Other iOS versions
I don't have access to other iOS versions.
I tested with a simulator in iOS 16.
And although that cannot be relied upon, it seems to be as bad as iOS 15.


use reverse-iterator if possible

Addressing missed comments https://github.com/druid-io/druid/pull/2014/files#r49129298

:+1: after squashing commits

:+1: once commits are squashed

:+1:, will merge once travis passes.


NOOP on wait clause with no explicit time and log/http checkers (#276)

refactor and test checkers cleanup

fixes #276

Thanks ! I added a changelog.md entry and merged to integration.


Use vim.notify api call to report errors, instead of just print

By using vim.notify the user can have a nicer experience, overriding the function with plugins like https://github.com/rcarriga/nvim-notify
An example where this could be applied is when reporting the error:
print 'No previous tab to go to', in main.lua

Thanks for pointing me at vim.notify. I actually didn't know this existed.
I substituted both prints, but was not totally sure about what log-level to choose. I thought maybe vim.log.levels.ERROR is fine, as the desired action could not be executed. But maybe a warning would be more friendly? What's your opinion on this?


fix: Update latest kernel version to fix linode-config.spec.ts

Description 📝

Updates the latest kernel to fix the linode-config.spec.ts failures ❌

How to test 🧪

Verify linode-config.spec.ts passes in Jenkins ✅
Verify linode-config.spec.ts passes locally (optional) ✅

yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts"

As an Author I have considered 🤔

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

@abailly-akamai We need the other version of you!

Here i am! too late!


Feature Request: Options to help using the timeline for music-related applications

Currently there are a couple features that would help using the timeline for music:

The "denominators" for the tick marks between numbers is hardcoded to a very non-musical 1, 2, 5, 10. Exposing this via configuration would help dramatically--for music or for dance 1, 2, 4, 8 etc. would be preferred. https://github.com/ievgennaida/animation-timeline-control/blob/5e4bb08573e96f82d218a9d834f3e90f5d7aa99e/src/utils/timelineUtils.ts#L4
The numbers above the timeline are treated as if they are always seconds, making things confusing when treating the timeline in terms of beats, as they additionally get converted into minutes/hours as the timeline grows. Adding a callback to replace _formatUnitsText dynamically would be optimal, as I could then implement "numbers only" display, or counting to 8s, etc. https://github.com/ievgennaida/animation-timeline-control/blob/5e4bb08573e96f82d218a9d834f3e90f5d7aa99e/src/timeline.ts#L1493

@aaronsantiago

Denominators I can make configuble, but cannot do this week.
format units -> you can just override existing function.

@aaronsantiago Do you have any mock-up or reference with the expected outcome (overall)?


feature/85 add feed until out of food option

Implemented --feed-pets-until-out-of-food
Refactor the feed parameter checker
Change return codes to 1 on failure
Split of feed-all from feed cmd
Split off feed-all command
Add unit test for failing API gateway
Add coverage for co-related functionality

Changed the code from:
hopla feed --feed-until-out-of-food

to
hopla feed-all

related: #104
Fixed a few feed-related sys.exit calls

rebased to clean up commit logs


Please update podspec dependencies

Pod dependencies in podspec are quite outdated. E.g. "BigInt"'s latest version is 5.0, but you are forcing 3.1

Done in 0.2.0.


Refactor/#376 Update SCSS color vars/helpers

Related issue
https://github.com/DivanteLtd/storefront-ui/issues/376
Scope of work
The purpose is to remove excessive SASS color variables, then only theme colors with contextual names should be used on component styles, and avoid as much as possible to use lighten/darken with theme colors directly on component styles.

Removed some ambiguous color variables;
Marked some color vars as Internal color variables only;
New approach for theme colors always with:

$c-color;
$c-color-variant;
$c-on-color;

Updated $colors-map adding variant for each color;
Fixed color helpers function to use variant instead of SCSS lighten;
Updated component styles with new color variables;
Replaced SCSS lighten/darken(theme-color) on component styles with new color variants;

It also adds support for customization by CSS vars, so the user would be able to do, for example:
$c-primary: var(--primary);
$c-primary-variant: var(--primary-light);
$c-on-primary: var(--primary-yiq);

Screenshots of visual changes
N/A
Checklist

[x] I followed composition rules for my component
[x] I tested the component in most common device sizes (can be tested in Storybook from viewport addon in top menu)

@EduardDopler about contrast, I totally agree with you, but on this PR I'm just fixing variables names ans removing some SCSS functions to support CSS vars.
So I'm not changing fg/bg at all, no visual changes (at least no intentionally haha), only conventions.
I think we should open a new issue to talk about contrast, in past I start using yiq function, and, for example, fg for green color was changed, but it was reversed to follow desing decisions...

You're right. This PR isn't about legibility and a11y. Those are design decisions and should go into a new issue 👍

So it's yes for me, that's the right way to go ;). Do you guys think I can merge it in in this form? @mayashavin @przspa >

@filrak 10 failing checks. Are you sure we can merge? :)

@mayashavin oops, i'll check if before...

btw, just for future references:

ok, now passed all checks..
@przspa it may conflict with your open PRs, so I'll wait your feedback before merging, it's ok for you?

@leomp12 sorry, for me is ok, merge your PR :)


Code Splitting - need more information on using dynamic imports with splitChunksPlugin

The docs mention 3 general approaches, and establishes that the entry point approach can be improved by using the splitChunksPlugin.
But then it goes on to remove the splitChunksPlugin when using dynamic imports.
Is there a reason why we can't use both dynamic imports and splitChunksPlugin?
If we just use dynamic imports would it make sure that the runtime is not part of each bundle ?
or that common dependencies are not part of each bundle.
If no, is there a suggested way to use splitChunksPlugin to do those optimizations along with dynamic imports ?

It looks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please either update the issue with the template and reopen, or open a new issue.

Hey,
I didn't delete the issue template.
I raised this issue using "Other - Something else" template, because I didn't think that it is actually an issue with webpack , but possibly with docs.
I would create a new issue with the issue template, if that helps.

Please create it on webpack/webpack.js.org repository.


how does Keras handle loss in a batch?

Hi, thanks for the implementation!
I have a question related to how Keras handles the loss in a batch. I noticed that the loss in the RNN is defined as:
result = K.mean(result, axis = (1,2)) # mean over rollout length and z dim

That means that you end up with one loss per sample in the batch. I am not very familiar with Keras, so I wonder about what happens with these losses when you call
rnn.fit(rnn_input, rnn_output,
        shuffle=True,
        epochs=mdn_epochs,
        batch_size=batch_size,
        validation_split=0.2,
        callbacks=callbacks_list)

Does Keras average over the batch? Could you point me to some documentation about it?
Thanks a lot!

Yes that's correct I believe:
see here https://keras.io/losses/
"The actual optimized objective is the mean of the output array across all datapoints."


[P2P Distance] Enable P2P distance requests

Enable P2P distance requests following the plan here
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01862d7e90e87c0981
Upwork Job ID:<PHONE_NUMBER>514618368
Last Price Increase: 2024-02-20

Backend only, so removing the C+

I wrote all of the code based on the plan in the doc today. I haven't tested any of it yet, manually or automatically. Tomorrow I will start writing tests in Web-E, then filling in some Auth tests too.

I did some testing and made some tweaks in Web-E. It looks like a P2P distance request is being created successfully in the test, I just need to add the assertions. I'll try to add them in such a way that they don't break if the order or amount of Onyx updates changes.

The Web-E PR is ready for review, but it's still on HOLD to merge for the Auth PR. Next step is writing some tests for the Auth PR and then I can put it up for review.

I added some more tests to the Web-E PR this morning. I have one more small test I want to add, then I'll move over to adding Auth tests and getting that PR up for review.

I started adding an Auth test on Friday and got that partially complete this morning. Planning to finish that up and get the Auth PR up for review today, then continue responding to feedback on the Web-E PR.

Both PRs are under review now

Everything was deployed a while ago, and then we found this bug where the rate changed unexpectedly when editing a distance request on a workspace.
@thienlnam helped resolve the blocker and reverted the PR to enable P2P distance requests Manual Revert of https://github.com/Expensify/Web-Expensify/pull/40968. Thanks! That revert also includes a revert for these changes Prevent violations on P2P distance requests.
To move forward I will revert the manual revert, then investigate the root cause of the reported issue. I will also list out more thorough manual tests to make sure there are no regressions with workspace distance requests.

Ok, the PR to re-enable this is up for review.


WSL2 support

Hi! Tried installing for WSL2, keep running into this error:

Any idea how I can set this up in WSL2? I thought it would be similar to setting up in Ubuntu 20.04 (that's the distro I'm using)

Using WSL2 seems like an uphill battle (compared to a more VM-like VM, for example VirtualBox)
But first you need to get systemd running https://gist.github.com/djfdyuruiry/6720faa3f9fc59bfdf6284ee1f41f950
And I guess you'll need the WireGuard kernel module https://centerorbit.medium.com/installing-wireguard-in-wsl-2-dd676520cb21

@radhikasethi2011
As @PAStheLoD alluded, getting Firezone working for WSL2 is going to a very long and painful process. Firezone relies heavily on the WireGuard kernel module and netfilter subsystem and I'm not sure WSL2 exposes these in a way Firezone expects. We may very well have a native Windows package one day, but for now, you're much better off setting up Firezone in a VM using something like Virtualbox.
Going to close this for now. If you still help, feel free to another issue.


Assets losing "metadata" property

Not sure if it could be a problem form anyone else, but we use asset.metadata.dimensions to maintain the aspect ratio of the element while the image lazy loads in. But it seems that this plugin removes the metadata property from the asset object at some point.

Hi @kennedyrose.
I'm really sorry for the really delayed response. Somehow I didn't get a notification for this issue. 😞
I have created #11, which stops the plugin from removing the metadata block. We should be able to get it merged and released in the coming days. I'll keep this issue updated.
Thanks!


Audit LifecycleWatch API shape

Make sure it makes sense.
We'd like to implement it in terms of the ID where we store the watches INSIDE the ID actually rather than storing in the system whicih then does id -> lifecycle watch lookup perhaps even.
This is internal to the runtime; the protocol should expose watch/unwatch, people don't need to know it is implemented like that.

On one hand it's pretty okey and watchTermination(of:) is quite nice, though it risks closing over the actor...
func something(worker: Worker) {
    let otherState = ...
    watchTermination(of: worker) { terminatedID in
        // DO NOT CAPTURE THE WORKER
        // because if it is local you'll retain it and that'll keep it alive

       // very useful because we can capture
       log.info("\(terminatedID) terminated, other state: \(otherState)")
    }
}

So I don't really want to just drop this API... (I'm getting flashbacks of why we implemented "sub-receives" in behaviors to begin with, because the other style can be annoying for more complex things).
So perhaps we should not do this, and instead do:
distributed actor Watcher: LifecycleWatch {

  // MUST IMPLEMENT:
  func actorTerminated(id: ActorID) async throws {
     // implement handling here
     // We lost the ability to capture OTHER state though
     // which gives me flashbacks of why we did sub-receives in the first place
  }

But as I wrote this up, I thought:

Perhaps the real answer is to offer BOTH; and invoke them both.
And provide a default empty impl for actorTerminated?

I'd like some opinions here tbh @yim-lee @drexin @kavon @xedin @tomerd 🤔

watchTermination seems unsafe especially since worker is not supposed to be captured but it's too easy to make that mistake.

I think (of: worker) reads better than (id: ActorID), but this:

// DO NOT CAPTURE THE WORKER (weak is fine, but nonsense, it will always be nil when this triggers)
// because if it is local you'll retain it and that'll keep it alive

A lot of people will not know or will forget this gotcha, thus causing much headache. This is not limited to watchTermination of course, but any way to prevent it from happening would get my vote.

If the worker will always be nil because it's invoked during the actor instance's deinit, then I think it's too dangerous and unsafe to provide a reference to the actor from the deinit. I think providing only the actor's ID to actorTerminated is the right approach for now. If there's a compelling reason to provide a reference to the instance itself, then that could be added later on.

Agreed -- thank you everyone for chiming in, let's go for the safe shape. 👍


Request for  a working example

Hi @Neloop,
It would be a great help if you could provide a working example using your library for ABAC so that we can have a clear understanding of it.
Could you please do that?
Thanks,
Thai

Hi,
yes that would be possible. I would like to make working sample project and also something like tutorial, it is on my mind for some time. But for now, working example project with Spring integration should and has to be enough. I will try to get onto it as soon as possible.
Note that somewhat basic samples can be found in tests, look at DemoPermissionsService class.
Thanks for the interest in the library!

Thanks @Neloop for your response and looking forward to working example with Spring integration.
I did look into In the DemoPermissionsService, I do need some more guidance.
I would like to implement abac for a persistent resource. Take the DemoGroup as a starting point but now I want it to be a JPA entity.
How would the GroupDemoRepository be implemented using both IResourceRepository and JpaRepository of Spring JPA?

Hi,
I am working on an example project with full-fledged Spring Boot, JPA and Security integration.
But implementing both interfaces should be very straight forward, IResourceRepository is intentionally designed to have exactly the same methods as JpaRepository, therefore, implementation of both interfaces is easy should look something like this
public interface GroupRepository extends JpaRepository<Group, Long>, IResourceRepository<Group, Long> {

    Optional<Group> findByName(String name);
}

Hi,
I am really sorry it took so long, I kind of forget about that.
But today I sat down and implemented example project which should be better demonstration of how to use the library. The project resides here jaclp-demo.
Please note there is new release of jaclp library, because of some problems with transactions in 2.0 version. The new version is 2.1 and should be available shortly in maven central.
Best regards, Martin

Awesome and thanks for great work.


DOC: Improve docs for jax.numpy: power and pow

Part of #21461

Thanks! Squashed into single commit.


fix: restructure resend email code to send email code

Which Problems Are Solved
There is currently no endpoint to send an email code for verification of the email if you don't change the email itself.
How the Problems Are Solved
Endpoint HasEmailCode to get the information that an email code is existing, used by the new login.
Endpoint SendEmailCode, if no code is existing to replace ResendEmailCode as there is a check that a code has to be there, before it can be resend.
Additional Changes
None
Additional Context
Closes #9096

please also have a look at the copilot review

please also have a look at the copilot review

Corrected the wrongly mentioned functions in the comments.
Had a look at the copilot review, can change the text, but as it is a oneOf and 'nil' is also checked, default will never happen through an API call. Should we leave this be for now or introduce unit testing for all oneOf mappings in the API?


test: skip process_title for AIX

uv_(get|set)_process_title is not implemented for AIX. See unix/aix.c

Thanks Imran, landed in baf700a.


Remove incorrect text & non-compiling example

This PR removes some text describing binding semantics that, after discussion, turned out to be the result of a bug rather than
intended behavior (the intended behavior is still under-documented, see Raku/doc#3961).  It also removes the accompanying test, which
failed to compile once the bug was fixed.
Finally, it adds a doc-comment clarifying that a nearby test fails at runtime even though it looks like it would throw a compile-time
error (and thus would need to be marked for xt/example-compilation to skip).
Resolves #4020

OK, not so important now, and it solves an issue, so merging this.


Support for PG array_to_string() - concat elements of an array to string / text with a delimiter

Use case:
Support for PG array_to_string() function in CrateDB.
This now can be done as workaround with an UDF for TEXT:
CREATE OR REPLACE function array_to_string(array(TEXT),TEXT)
RETURNS TEXT
LANGUAGE JAVASCRIPT
AS 'function array_to_string(arr, delimiter) { return Array.prototype.join.call(arr, delimiter);}';

SELECT array_to_string(['a','b','c'],',');

Feature description:
There is an array_to_string() function that concats elements with a delimiter (optionally replace NULL values
From PostgreSQL

array_to_string ( array anyarray, delimiter text [, null_string text ] ) → text
Converts each array element to its text representation, and concatenates those separated by the delimiter string. If null_string is given and is not NULL, then NULL array entries are represented by that string; otherwise, they are omitted.
array_to_string(ARRAY[1, 2, 3, NULL, 5], ',', '') → 1,2,3,,5

Isn't this string_agg ?

Isn't this string_agg ?

array_to_string would be a scalar function
It really would be the counterpart to string_to_array()
One would have to unnest the array to use string_agg() first, which might not work with different length arrays in a recordset

Right, of course. I got things mixed up.

All aggregation functions will be supported for arrays after closing 10662 which is in progress now.
If I understand correctly, supporting string_agg  for array  type closes this issue as well, doesn't it?

@BaurzhanSakhariev
array_to_string() would be a scalar function, similar to #10662 i.e. basically an extensions to the other aggregations in there


Can't seem to subscribe to the created openshift-pipeline-operator

Sorry if this is just me not being very familiar with OLM, but I've ran into some problems here that I could use some help untangling.
I've followed the readme, and gotten successfully through installing the prerequisites, setting up Minishift (both with virtualbox and hyperkit as the driver). Creating the development docker image went fine, and I also used ´minikube addons enable registry´ to setup a registry in my minikube cluster. Install OLM and running the UI works great.
If I then try to follow the path of "Deploy openshift-pipelines-operator on minikube for testing" I run into problems because the openshift-operators namespace is used in the objects, but it's not the one we're told to create. I'm guessing this is because this PR #83 changed the objects, but the Readme is still the same. When adapting to this however I'm stuck at the event ´Error: cannot find volume "openshift-pipelines-operator-registry-configmap-server-toknd462" to mount into container "configmap-registry-server"´. This means I can't find the operator in the catalog.
If I instead go for the "Deploy openshift-pipelines-operator on minikube for testing" approach everything is deployed fine if I first create the namespace ´openshift-operators´, and I can even run ´./scripts/olm_catalog.sh > olm/openshift-pipelines-operator.resources.yaml´ after editing the image tag in  ´deploy/operator.yaml´. Using the namespace ´openshift-operators´ I can find the openshift-pipeline-operator but I can't subscribe because of the error ´Operator not available for selected namespaces´
If you can give me some feedback on my assumptions I'd be happy to update the readme, but most importantly what have I missed here that causes both deployment approaches to fail?

... the openshift-operators namespace is used in the objects, but it's not the one we're told to create. I'm guessing this is because this PR #83 changed the objects, but the Readme is still the same. ...

you are right. Read me should say openshift-operators instead of openshift-pipelines-operator. Thank  you for creating this issue. :+1:  PRs are welcome :)

Sure thing 👍
I created #97 to update the readme, however as I'm still getting the ´Operator not available for selected namespaces´ when adding the subscription, I suspect I'm still missing a piece. Any insight on that?

Just did a clean setup of this, and when I try to install OpenShift pipelines though the operator I can't.

´´´
kubectl get pods --all-namespaces
NAMESPACE             NAME                                          READY   STATUS    RESTARTS   AGE
kube-system           coredns-576cbf47c7-mm9fq                      1/1     Running   0          22m
kube-system           coredns-576cbf47c7-nk59j                      1/1     Running   0          22m
kube-system           etcd-minikube                                 1/1     Running   0          21m
kube-system           kube-addon-manager-minikube                   1/1     Running   0          21m
kube-system           kube-apiserver-minikube                       1/1     Running   0          21m
kube-system           kube-controller-manager-minikube              1/1     Running   0          21m
kube-system           kube-proxy-p9tj9                              1/1     Running   0          22m
kube-system           kube-scheduler-minikube                       1/1     Running   0          21m
kube-system           registry-ddx5l                                1/1     Running   0          22m
kube-system           registry-proxy-65s94                          1/1     Running   0          22m
kube-system           storage-provisioner                           1/1     Running   0          22m
olm                   catalog-operator-5cf9ff5855-ctf72             1/1     Running   0          14m
olm                   olm-operator-5d47954b9b-sqqrp                 1/1     Running   0          14m
olm                   operatorhubio-catalog-4csr9                   1/1     Running   0          14m
olm                   packageserver-645fbfcc6-6mnw9                 1/1     Running   0          14m
openshift-operators   openshift-pipelines-operator-registry-npd2z   1/1     Running   0          6m35s
´´´
Both ´tektoncd-pipeline-operator´ and ´operator-lifecycle-manager´ repos were synced today.
Any clues on debugging this?

@brujoand are you creating the operatorsoruce manifest using the script olm_catalog.sh

I had not as I hadn’t made any changes to the docker image. But retrying after generating the manifest gave the same error.

is the openshift-pipelines-operator that we see in the pic above the already existing one or the one added by you

in addition, there is a new workflow recommended by operator-framework to test operators locally
https://github.com/operator-framework/community-operators/blob/master/docs/testing-operators.md

could you give a link to your CSV file

what do you get when you do,
oc get operatorgroup --all-namespaces

When All namespaces installation mode is selected OLM uses a predetermined Namespace to deploy the operator-deployment. The predetermined Namepsace is usually openshift-operators. We need to verify it is the same on your cluster.
ref: https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/operatorgroups.md (especially InstallModes and Supported OperatorGroups)

The openshift-pipelines-operator was added by me, through ´kubectl apply -f olm/openshift-pipelines-operator.resources.yaml´
Not quite sure what you mean by CSV file, is it the yaml generated by olm_catalog.sh?
oc get operatorgroup --all-namespaces
NAMESPACE   NAME               AGE
olm         olm-operators      1h
operators   global-operators   1h

So I guess the last one should have been openshift-operators?

Setting NAMESPACE=operators did the trick, thanks 👍

in addition, checkout s https://github.com/operator-framework/community-operators/blob/master/docs/testing-operators.md
you might find it useful

Thanks, I'm pretty new to openshift, olm and tekton so I need all the links I can get at this point :)

I appreciate your efforts :+1:
if you haven't joined already, join our slack: https://github.com/tektoncd/community/blob/master/contact.md#slack

@brujoand shall we close this issue

Yupp 👍


Remove dependency on sources' logger package for kafka

So during managed kafka testing it was noticed that managed kafka likes to disconnect consumers around every 30 seconds which obviously results in an error. The problem here is that if another package is using this library (superkey-worker in this case) the entire program panics since the sources logger package isn't initialized (and why would it be, that isn't sources!).
This PR pulls out all deps from sources itself and might be a good candidate for upstreaming as part of the app-common-go starter app for kafka.

While scouring the docs for more stuff I did notice that you can pass logging functions to the readers/writers so that internal kafka-ey things get logged like raw publich info, disconnects, rebalances etc which is really nice. So I included some helper functions and added them to the config struct. This way users can opt in/out of logging kafka internals as well as our log messages with the context of the listener.

edit: also moved the kafka.CloseReader() call in the status listener to be before signaling back for shutdown, that way we for sure wait for the listener to shut down.
edit again: ended up going through and implementing a wrapper around the reader/writer structs so we don't expose any implementation details.

Ok I think this is ready - probably worth going through the commits.
The first commit just moves the closeReader call to by synchronous rather than deferred so it can commit properly before exiting. The second commit basically pulls the sources logger requirement and introduces an Options struct so we can pass any logger through, the third commit wraps kafka.Reader/Writer so they don't expose implementation details to any end-users, it also changes the way the logger gets passed so users don't have to pass individual functions they can just pass any logger that implements Debugf and Errorf.

/retest

There is conflict :/

Fixed, and tests are green now.


Verify MaskRCNN accuracy

Check inference results vs. baseline.

There was a bug in ngraph that's causing incorrect results. After some exhaustive debugging, I have found the sigmoid was not handling mkldnn input layout correctly. I'll make a PR to fix it. With that fixed, I think we have reasonable accuracy compared to the CPU baseline. I'll follow up with @lnguyen-nvn on testing.


⚠ Secret Website 3 has degraded performance

In 993f2df, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2908 ms

Resolved: Secret Website 3 performance has improved in 5cb373c.


SURF return to TIC doesn't restore previous line index (and other suggestion)

It would be nice to restore cursor to last selected entry when exiting from a cart.
Also It would be nice to make the menu scroll continuous: from last entry press down bring back to top entry (and viceversa also ;)
And last but not last: use a button to open tic.computer page for selected entry (online only) with system browser. In this way people can comment and vote.

ok, great idea with the website 👍

In addition to launching the webpage for the game, if we could sort by newest instead of most popular would be another great feature.

cursor restores when you back from a game
menu scrolls continuously
press [Y] to open website cart page

popular/new soring will be a separate issue...


[BUG]: Stage3, the last response token is generated both in Actor and InitialModel

🐛 Describe the bug
In def sample(), the generation process is:
for _ in range(input_ids.size(1), max_length):
This exclude the last response token.  Seems like the last response token is been generated by input the sequence into 4 models: Actor, InitialModel, Critic, RM.
Does this make sense?
Environment
No response

Or when input generated sequence to 4 models: Actor, InitialModel, Critic, RM, especially input to Actor and InitialModel,
what does this mean if you input "Prompt+Response" into Actor again? In this case, each output sequence length position will be the next token.