about table5

hi, i don't really know how to get table5 in your essay without pre-train model provided by you. Did you train on sceneflow and finetune on kitti 2012 and 2015? And what this table in readme mean?

All pretrained models are provided: https://github.com/mli0603/stereo-transformer#pre-trained-models

Thank you. I know you provide pretrain model. I want to know how to train a model without a pretrain model. I want to get the result in table5 from the start but not by using a pretrain model, can you help me about it?
------------------ 原始邮件 ------------------
发件人:                                                                                "mli0603/stereo-transformer"                                                                                @.>;
发送时间: 2021年3月12日(星期五) 晚上11:39
@.>;
<EMAIL_ADDRESS>主题: Re: [mli0603/stereo-transformer] about table5 (#19)
All pretrained models are provided: https://github.com/mli0603/stereo-transformer#pre-trained-models
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

You can finetune the sceneflow trained model (the link above) using this script: https://github.com/mli0603/stereo-transformer/blob/main/scripts/kitti_finetune.sh

So, did you get your scenflow pretrianed model by "pre-train on Scene Flow for 15 epochs using a fixed learning rate of 1e-4 for feature extractor and Transformer, and 2e-4 for the context adjustment layer" in your essay and get your kitti finetune model by finetune the sceneflow pretrain model on kitti2015?

Yes. The pretrained script for Scene Flow can be found here: https://github.com/mli0603/stereo-transformer/blob/main/scripts/pretrain.sh

@minchong1998 Oh I see where your confusion comes from. I used 400 epochs but I wrote 300 in the finetuning script. This is a mistake when I transferring PyCharm configuration to a bash scripts. Sorry for the confusion and I will correct it.

hi，i use the kitti_finetnue.sh and finetune on kitti2012 and 2015. When i break down my process, i continue the training by loading the checkpoint like epoch_200_model.pth.tar as pretrian model and carry on. When testing, i run --inference in my terminal and store the disparity map. But i think the map is not good enough. Did i mistake some part? I didn't train 400 epoch but still 300 because i found px_error didn't change much during training.
------------------ 原始邮件 ------------------
发件人:                                                                                "mli0603/stereo-transformer"                                                                                @.>;
发送时间: 2021年3月16日(星期二) 凌晨4:25
@.>;
<EMAIL_ADDRESS>主题: Re: [mli0603/stereo-transformer] about table5 (#19)
@minchong1998 Oh I see where your confusion comes from. I used 400 epochs but I wrote 300 in the finetuning script. This is a mistake when I transferring PyCharm configuration to a bash scripts. Sorry for the confusion and I will correct it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

by the way, it is one of the disparity map i get. No.16 in kitti2015 test
------------------ 原始邮件 ------------------
发件人:                                                                                "mli0603/stereo-transformer"                                                                                @.>;
发送时间: 2021年3月16日(星期二) 凌晨4:25
@.>;
<EMAIL_ADDRESS>主题: Re: [mli0603/stereo-transformer] about table5 (#19)
@minchong1998 Oh I see where your confusion comes from. I used 400 epochs but I wrote 300 in the finetuning script. This is a mistake when I transferring PyCharm configuration to a bash scripts. Sorry for the confusion and I will correct it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @minchong1998, I attched my training log at epoch 250 and 300. Can you see if they match what you have?

Index 0, attn 0.2269, rr 0.8732, l1 0.2209, entropy 0.0019, epe 0.4879, iou 0.9571, px error 0.0094
Index 1, attn 0.2460, rr 0.7193, l1 0.2281, entropy 0.0023, epe 0.5196, iou 0.9555, px error 0.0087
Index 2, attn 0.3206, rr 0.9870, l1 0.3138, entropy 0.0016, epe 0.6210, iou 0.9695, px error 0.0137
Index 3, attn 0.2239, rr 0.7959, l1 0.1930, entropy 0.0012, epe 0.4762, iou 0.9797, px error 0.0052
Index 4, attn 0.3677, rr 0.8059, l1 0.3513, entropy 0.0010, epe 0.6586, iou 0.9760, px error 0.0185
Index 5, attn 0.1844, rr 0.7582, l1 0.1688, entropy 0.0007, epe 0.4503, iou 0.9836, px error 0.0035
Index 6, attn 0.2505, rr 0.8926, l1 0.2230, entropy 0.0007, epe 0.4844, iou 0.9842, px error 0.0138
Index 7, attn 0.3579, rr 0.7557, l1 0.3023, entropy 0.0054, epe 0.6157, iou 0.8632, px error 0.0204
Index 8, attn 0.3536, rr 0.8004, l1 0.2871, entropy 0.0016, epe 0.6047, iou 0.9668, px error 0.0106
Index 9, attn 0.3535, rr 0.7623, l1 0.2600, entropy 0.0096, epe 0.5291, iou 0.9349, px error 0.0135
Index 10, attn 0.3179, rr 0.7905, l1 0.2497, entropy 0.0017, epe 0.5338, iou 0.9710, px error 0.0121
Index 11, attn 0.4146, rr 0.8366, l1 0.3848, entropy 0.0014, epe 0.6967, iou 0.9699, px error 0.0216
Index 12, attn 0.3884, rr 0.7525, l1 0.3516, entropy 0.0014, epe 0.6665, iou 0.9805, px error 0.0157
Index 13, attn 0.6897, rr 1.0362, l1 0.6442, entropy 0.0034, epe 0.9709, iou 0.9780, px error 0.0344
Index 14, attn 0.5307, rr 0.7961, l1 0.4677, entropy 0.0086, epe 0.8167, iou 0.9589, px error 0.0229
Index 15, attn 0.4434, rr 0.8102, l1 0.3955, entropy 0.0039, epe 0.6849, iou 0.9234, px error 0.0203
Index 16, attn 0.4186, rr 0.8544, l1 0.3868, entropy 0.0011, epe 0.7135, iou 0.9817, px error 0.0120
Index 17, attn 0.4630, rr 0.8310, l1 0.4362, entropy 0.0027, epe 0.7465, iou 0.9148, px error 0.0131
Index 18, attn 0.4343, rr 0.7691, l1 0.3473, entropy 0.0017, epe 0.6633, iou 0.9561, px error 0.0254
Index 19, attn 0.2812, rr 0.8765, l1 0.2292, entropy 0.0015, epe 0.5071, iou 0.9614, px error 0.0124
Epoch 250, attn 7.2668, rr 16.5036, l1 6.4412, epe 0.6224, iou 0.9583, px error 0.0156

Index 0, attn 0.2362, rr 0.8956, l1 0.2238, entropy 0.0017, epe 0.4939, iou 0.9563, px error 0.0091
Index 1, attn 0.2385, rr 0.7332, l1 0.2241, entropy 0.0022, epe 0.5112, iou 0.9548, px error 0.0087
Index 2, attn 0.3287, rr 1.0038, l1 0.3148, entropy 0.0029, epe 0.6239, iou 0.9401, px error 0.0134
Index 3, attn 0.2230, rr 0.8094, l1 0.1949, entropy 0.0015, epe 0.4772, iou 0.9761, px error 0.0054
Index 4, attn 0.3925, rr 0.8287, l1 0.3676, entropy 0.0010, epe 0.6728, iou 0.9779, px error 0.0192
Index 5, attn 0.1788, rr 0.7786, l1 0.1579, entropy 0.0008, epe 0.4306, iou 0.9859, px error 0.0032
Index 6, attn 0.2771, rr 0.9102, l1 0.2464, entropy 0.0008, epe 0.5134, iou 0.9834, px error 0.0159
Index 7, attn 0.3520, rr 0.7600, l1 0.3059, entropy 0.0044, epe 0.6226, iou 0.8966, px error 0.0210
Index 8, attn 0.3359, rr 0.7950, l1 0.2678, entropy 0.0015, epe 0.5855, iou 0.9669, px error 0.0093
Index 9, attn 0.3510, rr 0.7809, l1 0.2603, entropy 0.0050, epe 0.5276, iou 0.9715, px error 0.0141
Index 10, attn 0.3101, rr 0.8050, l1 0.2434, entropy 0.0016, epe 0.5239, iou 0.9688, px error 0.0106
Index 11, attn 0.4138, rr 0.8499, l1 0.3961, entropy 0.0015, epe 0.7054, iou 0.9685, px error 0.0228
Index 12, attn 0.3851, rr 0.7561, l1 0.3553, entropy 0.0015, epe 0.6709, iou 0.9776, px error 0.0159
Index 13, attn 0.7022, rr 1.0670, l1 0.6817, entropy 0.0031, epe 1.0121, iou 0.9786, px error 0.0351
Index 14, attn 0.5549, rr 0.8250, l1 0.5101, entropy 0.0037, epe 0.8646, iou 0.9798, px error 0.0255
Index 15, attn 0.4236, rr 0.8251, l1 0.3801, entropy 0.0009, epe 0.6668, iou 0.9778, px error 0.0201
Index 16, attn 0.4183, rr 0.8586, l1 0.3894, entropy 0.0010, epe 0.7195, iou 0.9843, px error 0.0114
Index 17, attn 0.4427, rr 0.8347, l1 0.4201, entropy 0.0018, epe 0.7319, iou 0.9389, px error 0.0127
Index 18, attn 0.4811, rr 0.7763, l1 0.3942, entropy 0.0012, epe 0.7116, iou 0.9744, px error 0.0324
Index 19, attn 0.2778, rr 0.8895, l1 0.2294, entropy 0.0013, epe 0.5030, iou 0.9600, px error 0.0126
Epoch 300, attn 7.3234, rr 16.7827, l1 6.5632, epe 0.6284, iou 0.9659, px error 0.0162

hi, this is my log of 300. i found my iou is much less than yours and it keeps the value of 0.2144. Do you know the reason?
Index 0, l1_raw 0.2145, rr 0.9035, l1 0.2197, occ_be 0.0014, epe 0.4872, iou 0.1586, px error 0.0088
Index 1, l1_raw 0.2177, rr 0.7652, l1 0.2098, occ_be 0.0024, epe 0.4791, iou 0.1603, px error 0.0087
Index 2, l1_raw 0.3408, rr 1.0074, l1 0.3285, occ_be 0.0021, epe 0.6410, iou 0.1600, px error 0.0143
Index 3, l1_raw 0.2165, rr 0.8201, l1 0.1930, occ_be 0.0013, epe 0.4754, iou 0.2128, px error 0.0047
Index 4, l1_raw 0.3879, rr 0.8596, l1 0.3712, occ_be 0.0008, epe 0.6758, iou 0.1950, px error 0.0194
Index 5, l1_raw 0.1737, rr 0.8136, l1 0.1539, occ_be 0.0007, epe 0.4131, iou 0.2230, px error 0.0034
Index 6, l1_raw 0.2413, rr 0.9312, l1 0.2318, occ_be 0.0008, epe 0.4996, iou 0.1741, px error 0.0105
Index 7, l1_raw 0.3045, rr 0.7887, l1 0.2591, occ_be 0.0038, epe 0.5513, iou 0.1684, px error 0.0172
Index 8, l1_raw 0.3317, rr 0.8129, l1 0.2542, occ_be 0.0015, epe 0.5583, iou 0.2463, px error 0.0092
Index 9, l1_raw 0.3736, rr 0.7709, l1 0.2767, occ_be 0.0041, epe 0.5440, iou 0.2784, px error 0.0117
Index 10, l1_raw 0.3156, rr 0.8184, l1 0.2517, occ_be 0.0015, epe 0.5315, iou 0.2583, px error 0.0119
Index 11, l1_raw 0.4098, rr 0.8791, l1 0.3801, occ_be 0.0012, epe 0.6709, iou 0.1766, px error 0.0242
Index 12, l1_raw 0.3483, rr 0.7833, l1 0.3090, occ_be 0.0010, epe 0.5983, iou 0.2444, px error 0.0163
Index 13, l1_raw 0.7159, rr 1.0389, l1 0.6679, occ_be 0.0038, epe 0.9801, iou 0.2637, px error 0.0419
Index 14, l1_raw 0.4482, rr 0.7811, l1 0.4138, occ_be 0.0034, epe 0.7410, iou 0.2273, px error 0.0216
Index 15, l1_raw 0.4284, rr 0.8664, l1 0.3897, occ_be 0.0008, epe 0.6560, iou 0.2551, px error 0.0200
Index 16, l1_raw 0.3964, rr 0.8969, l1 0.3709, occ_be 0.0011, epe 0.6829, iou 0.2672, px error 0.0111
Index 17, l1_raw 0.4728, rr 0.8533, l1 0.4399, occ_be 0.0019, epe 0.7473, iou 0.2731, px error 0.0143
Index 18, l1_raw 0.4405, rr 0.7994, l1 0.3366, occ_be 0.0010, epe 0.6272, iou 0.2395, px error 0.0281
Index 19, l1_raw 0.2873, rr 0.9370, l1 0.2322, occ_be 0.0011, epe 0.5049, iou 0.1058, px error 0.0128
Epoch 300, epe 0.6032, iou 0.2144, px error 0.0158
------------------ 原始邮件 ------------------
发件人:                                                                                "mli0603/stereo-transformer"                                                                                @.>;
发送时间: 2021年3月17日(星期三) 晚上10:05
@.>;
<EMAIL_ADDRESS>主题: Re: [mli0603/stereo-transformer] about table5 (#19)
Hi @minchong1998, I attched my training log at epoch 250 and 300. Can you see if they match what you have?
Index 0, attn 0.2269, rr 0.8732, l1 0.2209, entropy 0.0019, epe 0.4879, iou 0.9571, px error 0.0094 Index 1, attn 0.2460, rr 0.7193, l1 0.2281, entropy 0.0023, epe 0.5196, iou 0.9555, px error 0.0087 Index 2, attn 0.3206, rr 0.9870, l1 0.3138, entropy 0.0016, epe 0.6210, iou 0.9695, px error 0.0137 Index 3, attn 0.2239, rr 0.7959, l1 0.1930, entropy 0.0012, epe 0.4762, iou 0.9797, px error 0.0052 Index 4, attn 0.3677, rr 0.8059, l1 0.3513, entropy 0.0010, epe 0.6586, iou 0.9760, px error 0.0185 Index 5, attn 0.1844, rr 0.7582, l1 0.1688, entropy 0.0007, epe 0.4503, iou 0.9836, px error 0.0035 Index 6, attn 0.2505, rr 0.8926, l1 0.2230, entropy 0.0007, epe 0.4844, iou 0.9842, px error 0.0138 Index 7, attn 0.3579, rr 0.7557, l1 0.3023, entropy 0.0054, epe 0.6157, iou 0.8632, px error 0.0204 Index 8, attn 0.3536, rr 0.8004, l1 0.2871, entropy 0.0016, epe 0.6047, iou 0.9668, px error 0.0106 Index 9, attn 0.3535, rr 0.7623, l1 0.2600, entropy 0.0096, epe 0.5291, iou 0.9349, px error 0.0135 Index 10, attn 0.3179, rr 0.7905, l1 0.2497, entropy 0.0017, epe 0.5338, iou 0.9710, px error 0.0121 Index 11, attn 0.4146, rr 0.8366, l1 0.3848, entropy 0.0014, epe 0.6967, iou 0.9699, px error 0.0216 Index 12, attn 0.3884, rr 0.7525, l1 0.3516, entropy 0.0014, epe 0.6665, iou 0.9805, px error 0.0157 Index 13, attn 0.6897, rr 1.0362, l1 0.6442, entropy 0.0034, epe 0.9709, iou 0.9780, px error 0.0344 Index 14, attn 0.5307, rr 0.7961, l1 0.4677, entropy 0.0086, epe 0.8167, iou 0.9589, px error 0.0229 Index 15, attn 0.4434, rr 0.8102, l1 0.3955, entropy 0.0039, epe 0.6849, iou 0.9234, px error 0.0203 Index 16, attn 0.4186, rr 0.8544, l1 0.3868, entropy 0.0011, epe 0.7135, iou 0.9817, px error 0.0120 Index 17, attn 0.4630, rr 0.8310, l1 0.4362, entropy 0.0027, epe 0.7465, iou 0.9148, px error 0.0131 Index 18, attn 0.4343, rr 0.7691, l1 0.3473, entropy 0.0017, epe 0.6633, iou 0.9561, px error 0.0254 Index 19, attn 0.2812, rr 0.8765, l1 0.2292, entropy 0.0015, epe 0.5071, iou 0.9614, px error 0.0124 Epoch 250, attn 7.2668, rr 16.5036, l1 6.4412, epe 0.6224, iou 0.9583, px error 0.0156
Index 0, attn 0.2362, rr 0.8956, l1 0.2238, entropy 0.0017, epe 0.4939, iou 0.9563, px error 0.0091 Index 1, attn 0.2385, rr 0.7332, l1 0.2241, entropy 0.0022, epe 0.5112, iou 0.9548, px error 0.0087 Index 2, attn 0.3287, rr 1.0038, l1 0.3148, entropy 0.0029, epe 0.6239, iou 0.9401, px error 0.0134 Index 3, attn 0.2230, rr 0.8094, l1 0.1949, entropy 0.0015, epe 0.4772, iou 0.9761, px error 0.0054 Index 4, attn 0.3925, rr 0.8287, l1 0.3676, entropy 0.0010, epe 0.6728, iou 0.9779, px error 0.0192 Index 5, attn 0.1788, rr 0.7786, l1 0.1579, entropy 0.0008, epe 0.4306, iou 0.9859, px error 0.0032 Index 6, attn 0.2771, rr 0.9102, l1 0.2464, entropy 0.0008, epe 0.5134, iou 0.9834, px error 0.0159 Index 7, attn 0.3520, rr 0.7600, l1 0.3059, entropy 0.0044, epe 0.6226, iou 0.8966, px error 0.0210 Index 8, attn 0.3359, rr 0.7950, l1 0.2678, entropy 0.0015, epe 0.5855, iou 0.9669, px error 0.0093 Index 9, attn 0.3510, rr 0.7809, l1 0.2603, entropy 0.0050, epe 0.5276, iou 0.9715, px error 0.0141 Index 10, attn 0.3101, rr 0.8050, l1 0.2434, entropy 0.0016, epe 0.5239, iou 0.9688, px error 0.0106 Index 11, attn 0.4138, rr 0.8499, l1 0.3961, entropy 0.0015, epe 0.7054, iou 0.9685, px error 0.0228 Index 12, attn 0.3851, rr 0.7561, l1 0.3553, entropy 0.0015, epe 0.6709, iou 0.9776, px error 0.0159 Index 13, attn 0.7022, rr 1.0670, l1 0.6817, entropy 0.0031, epe 1.0121, iou 0.9786, px error 0.0351 Index 14, attn 0.5549, rr 0.8250, l1 0.5101, entropy 0.0037, epe 0.8646, iou 0.9798, px error 0.0255 Index 15, attn 0.4236, rr 0.8251, l1 0.3801, entropy 0.0009, epe 0.6668, iou 0.9778, px error 0.0201 Index 16, attn 0.4183, rr 0.8586, l1 0.3894, entropy 0.0010, epe 0.7195, iou 0.9843, px error 0.0114 Index 17, attn 0.4427, rr 0.8347, l1 0.4201, entropy 0.0018, epe 0.7319, iou 0.9389, px error 0.0127 Index 18, attn 0.4811, rr 0.7763, l1 0.3942, entropy 0.0012, epe 0.7116, iou 0.9744, px error 0.0324 Index 19, attn 0.2778, rr 0.8895, l1 0.2294, entropy 0.0013, epe 0.5030, iou 0.9600, px error 0.0126 Epoch 300, attn 7.3234, rr 16.7827, l1 6.5632, epe 0.6284, iou 0.9659, px error 0.0162
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

i think the reason is i don't have the groundtruth occlusion_mask of kitti dataset, and i don't know where to find it. Where you get this groudtruth?

hi, i found that other methods in your table 5 is different with those in kitti official web. For example, d1all of cspn is 1.74 in the website and 1.63 in your table. By the way, you wrote "Evaluation 3 px Error on KITTI 2015." in the title of table 5 and i want to ask what the 3px on kitti 2015 mean? kitti2015 official web seems not provide 3px error.
------------------ 原始邮件 ------------------
发件人:                                                                                "mli0603/stereo-transformer"                                                                                @.>;
发送时间: 2021年3月17日(星期三) 晚上10:05
@.>;
<EMAIL_ADDRESS>主题: Re: [mli0603/stereo-transformer] about table5 (#19)
Hi @minchong1998, I attched my training log at epoch 250 and 300. Can you see if they match what you have?
Index 0, attn 0.2269, rr 0.8732, l1 0.2209, entropy 0.0019, epe 0.4879, iou 0.9571, px error 0.0094 Index 1, attn 0.2460, rr 0.7193, l1 0.2281, entropy 0.0023, epe 0.5196, iou 0.9555, px error 0.0087 Index 2, attn 0.3206, rr 0.9870, l1 0.3138, entropy 0.0016, epe 0.6210, iou 0.9695, px error 0.0137 Index 3, attn 0.2239, rr 0.7959, l1 0.1930, entropy 0.0012, epe 0.4762, iou 0.9797, px error 0.0052 Index 4, attn 0.3677, rr 0.8059, l1 0.3513, entropy 0.0010, epe 0.6586, iou 0.9760, px error 0.0185 Index 5, attn 0.1844, rr 0.7582, l1 0.1688, entropy 0.0007, epe 0.4503, iou 0.9836, px error 0.0035 Index 6, attn 0.2505, rr 0.8926, l1 0.2230, entropy 0.0007, epe 0.4844, iou 0.9842, px error 0.0138 Index 7, attn 0.3579, rr 0.7557, l1 0.3023, entropy 0.0054, epe 0.6157, iou 0.8632, px error 0.0204 Index 8, attn 0.3536, rr 0.8004, l1 0.2871, entropy 0.0016, epe 0.6047, iou 0.9668, px error 0.0106 Index 9, attn 0.3535, rr 0.7623, l1 0.2600, entropy 0.0096, epe 0.5291, iou 0.9349, px error 0.0135 Index 10, attn 0.3179, rr 0.7905, l1 0.2497, entropy 0.0017, epe 0.5338, iou 0.9710, px error 0.0121 Index 11, attn 0.4146, rr 0.8366, l1 0.3848, entropy 0.0014, epe 0.6967, iou 0.9699, px error 0.0216 Index 12, attn 0.3884, rr 0.7525, l1 0.3516, entropy 0.0014, epe 0.6665, iou 0.9805, px error 0.0157 Index 13, attn 0.6897, rr 1.0362, l1 0.6442, entropy 0.0034, epe 0.9709, iou 0.9780, px error 0.0344 Index 14, attn 0.5307, rr 0.7961, l1 0.4677, entropy 0.0086, epe 0.8167, iou 0.9589, px error 0.0229 Index 15, attn 0.4434, rr 0.8102, l1 0.3955, entropy 0.0039, epe 0.6849, iou 0.9234, px error 0.0203 Index 16, attn 0.4186, rr 0.8544, l1 0.3868, entropy 0.0011, epe 0.7135, iou 0.9817, px error 0.0120 Index 17, attn 0.4630, rr 0.8310, l1 0.4362, entropy 0.0027, epe 0.7465, iou 0.9148, px error 0.0131 Index 18, attn 0.4343, rr 0.7691, l1 0.3473, entropy 0.0017, epe 0.6633, iou 0.9561, px error 0.0254 Index 19, attn 0.2812, rr 0.8765, l1 0.2292, entropy 0.0015, epe 0.5071, iou 0.9614, px error 0.0124 Epoch 250, attn 7.2668, rr 16.5036, l1 6.4412, epe 0.6224, iou 0.9583, px error 0.0156
Index 0, attn 0.2362, rr 0.8956, l1 0.2238, entropy 0.0017, epe 0.4939, iou 0.9563, px error 0.0091 Index 1, attn 0.2385, rr 0.7332, l1 0.2241, entropy 0.0022, epe 0.5112, iou 0.9548, px error 0.0087 Index 2, attn 0.3287, rr 1.0038, l1 0.3148, entropy 0.0029, epe 0.6239, iou 0.9401, px error 0.0134 Index 3, attn 0.2230, rr 0.8094, l1 0.1949, entropy 0.0015, epe 0.4772, iou 0.9761, px error 0.0054 Index 4, attn 0.3925, rr 0.8287, l1 0.3676, entropy 0.0010, epe 0.6728, iou 0.9779, px error 0.0192 Index 5, attn 0.1788, rr 0.7786, l1 0.1579, entropy 0.0008, epe 0.4306, iou 0.9859, px error 0.0032 Index 6, attn 0.2771, rr 0.9102, l1 0.2464, entropy 0.0008, epe 0.5134, iou 0.9834, px error 0.0159 Index 7, attn 0.3520, rr 0.7600, l1 0.3059, entropy 0.0044, epe 0.6226, iou 0.8966, px error 0.0210 Index 8, attn 0.3359, rr 0.7950, l1 0.2678, entropy 0.0015, epe 0.5855, iou 0.9669, px error 0.0093 Index 9, attn 0.3510, rr 0.7809, l1 0.2603, entropy 0.0050, epe 0.5276, iou 0.9715, px error 0.0141 Index 10, attn 0.3101, rr 0.8050, l1 0.2434, entropy 0.0016, epe 0.5239, iou 0.9688, px error 0.0106 Index 11, attn 0.4138, rr 0.8499, l1 0.3961, entropy 0.0015, epe 0.7054, iou 0.9685, px error 0.0228 Index 12, attn 0.3851, rr 0.7561, l1 0.3553, entropy 0.0015, epe 0.6709, iou 0.9776, px error 0.0159 Index 13, attn 0.7022, rr 1.0670, l1 0.6817, entropy 0.0031, epe 1.0121, iou 0.9786, px error 0.0351 Index 14, attn 0.5549, rr 0.8250, l1 0.5101, entropy 0.0037, epe 0.8646, iou 0.9798, px error 0.0255 Index 15, attn 0.4236, rr 0.8251, l1 0.3801, entropy 0.0009, epe 0.6668, iou 0.9778, px error 0.0201 Index 16, attn 0.4183, rr 0.8586, l1 0.3894, entropy 0.0010, epe 0.7195, iou 0.9843, px error 0.0114 Index 17, attn 0.4427, rr 0.8347, l1 0.4201, entropy 0.0018, epe 0.7319, iou 0.9389, px error 0.0127 Index 18, attn 0.4811, rr 0.7763, l1 0.3942, entropy 0.0012, epe 0.7116, iou 0.9744, px error 0.0324 Index 19, attn 0.2778, rr 0.8895, l1 0.2294, entropy 0.0013, epe 0.5030, iou 0.9600, px error 0.0126 Epoch 300, attn 7.3234, rr 16.7827, l1 6.5632, epe 0.6284, iou 0.9659, px error 0.0162
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

i found the groundtruth of occ_mask you use to calculate iou is inputs.occ_mask.(self.compute_iou(outputs['occ_pred'], inputs.occ_mask, loss, invalid_mask), which is set as input_data['occ_mask'] = np.zeros_like(disp).astype(np.bool) in kitti.py. This is also use to calculate entropy loss. I wonder why it is set to zero.

The actual occlusion mask is computed inside here. Please see Q&A 3 where I discussed this.
I updated the compute_iou function when releasing the code to make it run faster. Previously I used confusion_matrix from scipy which was very slow. Your IOU is lower because the non-valid pixels were taken into account (which is wrong), I have fixed it and will update soon. Your result looks close to my training log, so I think if you finish training and your result will be close to what's reported in the official benchmark.

hi, i found that other methods in your table 5 is different with those in kitti official web. For example, d1all of cspn is 1.74 in the website and 1.63 in your table. By the way, you wrote "Evaluation 3 px Error on KITTI 2015." in the title of table 5 and i want to ask what the 3px on kitti 2015 mean? kitti2015 official web seems not provide 3px error.

This is because we report 3px error in non-occluded region only. 3px Error means percentage of disparity error larger than 3px. You can use the filter on the top to see non-occluded result only.

the matrix provided by kitti2015 official is "onsiders a pixel to be correctly estimated if the disparity or flow end-point error is <3px or <5% ", it seems stricter than only 3px. What i confuse is where to get a result only consider <3px, but not <3px ot <5%. And where you get other methods result only consider <3px?
------------------ 原始邮件 ------------------
发件人:                                                                                "mli0603/stereo-transformer"                                                                                @.>;
发送时间: 2021年3月19日(星期五) 凌晨2:15
@.>;
<EMAIL_ADDRESS>主题: Re: [mli0603/stereo-transformer] about table5 (#19)
i found the groundtruth of occ_mask you use to calculate iou is inputs.occ_mask.(self.compute_iou(outputs['occ_pred'], inputs.occ_mask, loss, invalid_mask), which is set as input_data['occ_mask'] = np.zeros_like(disp).astype(np.bool) in kitti.py. This is also use to calculate entropy loss. I wonder why it is set to zero.
The actual occlusion mask is computed inside here. Please see Q&A 3 where I discussed this.
I updated the compute_iou function when releasing the code to make it run faster. Previously I used confusion_matrix from scipy which was very slow. Your IOU is lower because the non-valid pixels were taken into account (which is wrong), I have fixed it and will update soon. Your result looks close to my training log, so I think if you finish training and your result will be close to what's reported in the official benchmark.
hi, i found that other methods in your table 5 is different with those in kitti official web. For example, d1all of cspn is 1.74 in the website and 1.63 in your table. By the way, you wrote "Evaluation 3 px Error on KITTI 2015." in the title of table 5 and i want to ask what the 3px on kitti 2015 mean? kitti2015 official web seems not provide 3px error.
This is because we report 3px error in non-occluded region only. 3px Error means percentage of disparity error larger than 3px. You can use the filter on the top to see non-occluded result only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Nice catch. It is worth updating the manuscript to further clarify this, which you are right that it will be stricter than just 3px error. The caption tries to state the result from KITTI benchmark, but defnitely not clear enough.

So did you get your result of table 5 in kitti benchmark or not?
------------------ 原始邮件 ------------------
发件人:                                                                                "mli0603/stereo-transformer"                                                                                @.>;
发送时间: 2021年3月19日(星期五) 上午10:01
@.>;
<EMAIL_ADDRESS>主题: Re: [mli0603/stereo-transformer] about table5 (#19)
Nice catch. It is worth updating the manuscript to further clarify this, which you are right that it will be stricter than just 3px error. The caption tries to state the result from KITTI benchmark, but defnitely not clear enough.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes ;) The arxiv/github results are outdated and I haven't synced them with the KITTI benchmark yet. The update will come soon (probably next week)

thank you, i understand, i'm looking forward it.
------------------ 原始邮件 ------------------
发件人:                                                                                "mli0603/stereo-transformer"                                                                                @.>;
发送时间: 2021年3月19日(星期五) 上午10:15
@.>;
<EMAIL_ADDRESS>主题: Re: [mli0603/stereo-transformer] about table5 (#19)
Yes ;) The arxiv/github results are outdated and I haven't synced them with the KITTI benchmark yet. The update will come soon (probably next week)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

hi, i don't really know how to get table5 in your essay without pre-train model provided by you. Did you train on sceneflow and finetune on kitti 2012 and 2015? And what this table in readme mean?

您好，我可以加一下您的联系方式嘛，我现在也在看这篇论文，部署代码时有些不懂的地方，希望您能帮我解答一下，万分感谢。您也可以加我微信：yt152971

@mli0603 Hi, can provide your training log on Sceneflow？


SQL error: extended protocol limited to 65535 parameters

[ ] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
I am using ent as ORM for PostgreSQL database and I am querying ent model with O2O edge defined as in docs,
func (ModelA) Edges() []ent.Edge {
	return []ent.Edge{
		edge.From("ModelB", ModelB.Type).Ref("ModelA"),
	}
}

func (ModelB) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("ModelA", ModelA.Type).
			Unique()
	}
}

When I try
client.ModelA.Query().WithModelB()

request fails with error extended protocol limited to 65535 parameters, since for WithModelB() call ent tries to do
select id from model_b where id in ( ? )

and ids that are needed to be selected are more than 65535

Expected Behavior 🤔
I believe that ent should divide calls, and make requests in batch
Steps to Reproduce 🕹

Steps:

Define two models (ModelA and ModelB, for example) with O2O relation
Insert more than 65535 entries for one of the models, and link them all to another model (Insert more than 65535 ModelB entries, link all ModelB entries to any of ModelA entries)
Try to query all values (Query ModelA with WIthModelB() call)

Your Environment 🌎

Tech
Version

Go
1.22.1

Ent
0.12.5

Database
PostgreSQL

@a8m @rotemtam any ideas on how we should work around this?


Solid Query is mixing up queries during SSR

Describe the bug
During SSR, query.data is receiving data from another query function.
Your minimal, reproducible example
https://stackblitz.com/edit/github-pqy8j7-s2k3r8?file=src%2Fcomponents%2FPage.tsx
Steps to reproduce

Look at Page.tsx - notice that pageQuery query function resolves to pageQuery API response. However, when you print it, pageQuery.data: "ComponentA API response" is rendered instead.
Note that this is an Astro project and the client:load directive is not used, so this page is never hydrated.

Expected behavior
Output is

...
pageQuery.data: "pageQuery API response"

How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
Chrome, Windows
Tanstack Query adapter
solid-query
TanStack Query version
5.30.3
TypeScript version
No response
Additional context
cc @ardeora

Well this was strange at first but this looks like a bug in maybe astro or solid-js. I'm using createResource here and still see the same issue
https://stackblitz.com/edit/github-pqy8j7-ibsnna?file=src%2Fcomponents%2FPage.tsx

Issue in SolidJS repo:

https://github.com/solidjs/solid/issues/2131


Put ftp close in try/except

This fixes recursion errors if self.ftp no longer exists to close.

Closes #4

Manually tested.  Unpatched version
lucky = Ska.ftp.SFTP('lucky')
del lucky.ftp
lucky.__del__()
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
...

RuntimeError: maximum recursion depth exceeded while calling a Python object

Patched version
lucky = Ska.ftp.SFTP('lucky')
del lucky.ftp
In [24]: lucky.__del__()
In [25]:

Needs a version update, otherwise :+1:.

Actually, would it be easy enough to put in the test that you showed?

I wasn't sure that the recursion was something we wanted to do on purpose
every time this is tested (though I suppose that isn't often).

Though I suppose if this is fixed, there won't be any recursion.

I don't completely understand why the object "goes missing" in use, but if you like the "just delete it and check" test, it shouldn't be a problem.

I'm not exactly clear if the infinite recursion is happening when you do the try/except here.  That would be slightly unappealing, but in practice the actual time for that recursion to is quite short so it isn't a problem.

Yeah, I think you are still getting the recursion,  but yes,  the time is
short.
I was wondering about avoiding the recursion altogether with my suggestion
about checking if ftp exists,  but I suppose the try is nice to just
silently ignore any other weirdness when trying to close the connection
(which we don't care about by the time we're closing).

Huh.  When I try to run this as a new test with with py.test the recursion actually doesn't seem to terminate in a reasonable amount of time.

Ah.  That's probably a namespace package testing error on my part.

Yes, if hasattr(self, 'ftp') and hasattr(self.ftp, 'close') would also probably work and maybe be nicer?  Who knows.

Yes, if hasattr(self, 'ftp') and hasattr(self.ftp, 'close') would also
probably work and maybe be nicer? Who knows.

Yes, that's what I was playing around with next.  But leaving this as the
"open in the other window" type project just now.

So, I'd put this as an "open in the other window" project because nothing was working.  if hasattr(self, 'ftp') and hasattr(self.ftp, 'close') helps to not print a bunch of errors at runtime when calling __del__, at the ipython shell, but I found that the ipython session hung at close.  py.test still displayed the recursion errors on a test.
I think that this getattr:
    def __getattr__(self, attr):
        """
        Fall through to SFTPClient methods, and fail if not found.
        """
        val = getattr(self.ftp, attr)
        if self.logger:
            self.logger.info('Ska.ftp: {}'.format(attr))
        return val

https://github.com/sot/Ska.ftp/blob/205d6ed828922fbd0f8105943f41894b11494a18/Ska/ftp.py#L179
may be the real source of the problem.  Do we really need that for anything except close?   I also think the explicit __del__ method for SFTP may not be needed at all.

Closing unmerged as superceded by #6


Updating Sift.Confg

Hi,
Is there a way to change the account id/secret if Sift.open() has already been called? It looks like Sift.open() ignores the config if a SiftImpl exists, and the setConfig() method in SiftImpl isn't exposed by the Sift singleton.
The context is that in the test build of our app, users can configure whether they hit our staging or prod API. So, when the user switches environments, I want to update the Sift config to use the appropriate keys and call Sift.collect().

@sidnair Ah sure, that's reasonable. I will put that on the list for our next release.

Awesome, thanks. Do you have a sense of timing, so we can figure out how to prioritize workarounds in the meantime?

I'll try to have something by end of next week

@sidnair I just released 0.10.3-beta, which will apply a new config when Sift.open(context, config) is called.l


Improve visual representation of the solar system

Add a nice starfield background for the solar system simulation to give it a more space like feel :D
Also the planets and the moons are drawn as simple circles which may not be so visually appealing. Add textures or colors to represent different types of planets.

Can I be assigned @Redslayer112 -> github username

!assign @Redslayer112 60

!assign @Redslayer112 60

!deassign


Getting syntax error when sourcing antigen (ZSHRC) on WSL Ubuntu

Description
Small paragraph to describe the issue/bug.
Using the latest version of Windows 10, Windows Subsystem for Linux, and Ubuntu downloaded from the Microsoft Store in WSL
Also using the shell C:\\Windows\\System32\\wsl.exe
Steps to reproduce
Minimal steps to reproduce this behavior. Example:
Getting syntax error near unexpected token `fi'
Full command log is
user@DESKTOP-DL1NO2L:~$ source ~/.zshrc
-bash: /usr/libexec/java_home: No such file or directory
zmodload: command not found
autoload: command not found
-bash: /home/user/.zsh/bundle/bin/antigen.zsh: line 30: syntax error near unexpected token `fi'
-bash: /home/user/.zsh/bundle/bin/antigen.zsh: line 30: `      fi'
antigen: command not found
antigen: command not found
antigen: command not found
antigen: command not found

Expected behavior:
What should be happening is the command source ~/.zshrc should run succesfully and update the CLI bar and theme with the reloaded plugins (i.e. powerline bar credit oh-my-zsh)
Software version
latest antigen, 'develop' branch (origin  git@github.com:zsh-users/antigen.git)
Linux DESKTOP-DL1NO2L 4.4.0-18362-Microsoft #476-Microsoft Fri Nov 01 16:53:00 PST 2019 x86_64 x86_64 x86_64 GNU/Linux
Configuration
.zshrc snippet
source $HOME/.zsh/bundle/bin/antigen.zsh

antigen use oh-my-zsh # Load the oh-my-zsh's library.

# Bundles from oh-my-zsh.
antigen bundle git
# Color schemes
antigen theme agnoster

antigen apply # Tell antigen that you're done.

More information
Screenshot or any other information you may find relevant to troubleshoot the issue.

dont know much about WSL. but to me, it looks like you are not using zsh (but bash, that complains about the syntax that probably only works in zsh...), when sourcing .zshrc. You must make sure your are using the right shell, first...for testing, you can just call zsh first, this would also load your .zshrc...

Temp solution, add bash -c zsh to the top of ~/.bashrc


Delete Duplicate Lines › case-insensitive

Please allow to delete duplicate lines matching them in a case-insensitive manner.

Hi @ppo thank you for filing the request. When you mention you want to delete duplicate lines, do you mean you would like to have a command which deletes all duplicate lines in a file?
You can already do an editor text search for a specific piece of text, which is case insensitive, and decide to replace these text occurrences with some other text, which in your case would be an empty string.

Thanks @aiday-mar but I was proposing to add that feature. I was not looking for a workaround. (Moreover, your solution doesn't work to identify at once all the duplicates.)

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


PinchToZoom with ListView or ScrollView does nothing

A more complex and real-world situation would really be nice in this example.
Trying to use this in conjuction with other controls that take the Pan gesture seems to fail.  ScrollView and ListView for example grab the Pinch gesture even though they themselves don't Pinch but they do scroll/pan.  So it seems like Pinch inherits/uses that gesture so it is grabbed by the wrapped control.  This seems to make Pinch a very niche feature that can only work on very static views of Label and Image for example, but nothing more complex.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ddfae6f3-bfc3-da98-251f-4fe08b7f8e21
Version Independent ID: a7a9ebc5-b663-7a19-dc0d-b8fd5050f7b7
Content: Add a pinch gesture recognizer - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/gestures/pinch.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Microsoft support for Xamarin will end on May 1, 2024 for all Xamarin SDKs including Xamarin.Forms. In preparation for this, all issues and PRs in this repository are being closed.
.NET MAUI is the replacement for Xamarin.Forms, and it's documentation can be found here.


[CLOSED] Fix for Makefile run target and its variants

 Issue by akutz
Tuesday Mar 22, 2016 at 17:07 GMT
Originally opened as https://github.com/emccode/libstorage/pull/11

This patch fixes an issue whereby after using make run or one of the run variants, a subsequent make install would not return make: Nothing to be done for 'all'..

akutz included the following code: https://github.com/emccode/libstorage/pull/11/commits

 Comment by codecov-io
Tuesday Mar 22, 2016 at 17:12 GMT

Current coverage is 36.44%

Merging #11 into master will not affect coverage as of acea513

@@            master     #11   diff @@
======================================
  Files            7       7
  Stmts          354     354
  Branches        12      12
  Methods          0       0
======================================
  Hit            129     129
  Partial         12      12
  Missed         213     213

Review entire Coverage Diff as of acea513

Powered by Codecov. Updated on successful CI builds.


change title on README

Left reviews and line comments
Created a file and made a commit
Opened a pull request

Great job everyone!


Regex not matching?

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

In attempting to fix the Funimation extractor, I keep getting RegexNotFoundError: "Unable to extract". I checked in an external program and the Regex matches the HTML string just fine. How do you fix this error?

Plainly either the string that you think is being matched is not the string that yt-dl is trying to match, or the regex that yt-dl is using is not operating as you expect (the "external program" may not be good model).
Some ideas that may help:

enable debugging options of yt-dl (eg --write-pages);
run the program in a debugger or insert print() statements around the area where the extractor is failing;
post actual examples showing the HTML fragment that the extractor should find and the pattern being used.

Thank you! Is it possible to use --write-pages while running a unit test?


[6.x] Add Str::explodeIntoCollection() method To Illuminate\Support\Str

This is a method I add to most of my Laravel projects and one I thought could be a benefit to others.
The method takes a string, explodes it on a given delimiter (Defaulted to ,) and return a new Collection from the resulting array.
It is only a simple addition to the Illuminate\Support\Str class which doesn't effect any existing functionality, and I have added a couple of tests on the new method.
A use case which I find myself regularly using it is from a form on the front end that returns, for example, a comma delimited list of tags (For a blog post for example) or a comma delimited list of IDs, which I then create a Collection from and work my way through using Collection methods.

I think you can macro this into your projects if you need it.


Added Testimonial page

Issues Identification
Closes: #921
Description
The Creative Resume Builder Tool is a web-based application designed to help users create professional, ATS-friendly resumes with ease. Whether you're a job seeker looking to stand out or a professional seeking a simple way to update your CV, this tool offers user-friendly templates and customization options to create polished resumes in minutes.
Summary
A brief description of what this pull request does and why it is needed.
The Testimonials Page showcases the positive feedback and experiences of users who have used the Creative Resume Builder Tool. It highlights customer satisfaction, emphasizing how the tool has transformed the resume creation process for thousands of individuals across various professions.
Key Sections:
User Stats: Displays impressive statistics such as over 10,000 happy users, more than 1 million resumes created, and an average rating of 4.8 stars.
User Testimonials: Includes individual reviews from satisfied users, praising the tool’s ease of use, intuitive design, and powerful templates.
Please check the boxes that apply

[ ] Bugfix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Please check the boxes that apply

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] My changes do not break the current system and pass all existing test cases
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Screenshots
If applicable, please attach screenshots of the changes made to the user interface.
Additional Information
Please provide any other information that is relevant to this pull request.

@aditya-bhaumik now is it correct

please check the last button in the last of the page

https://github.com/user-attachments/assets/e4cc5918-4c57-4ba7-a2c4-1bb6bb251825

how is resume builder in testimonial
This website has many more features except that

the services the users are using
resume builder is one of them

@aditya-bhaumik please mention the changes you want i try to do it

testimonial page is supposed to have everything related to the site not just about resume tool

@aditya-bhaumik now can you check the changes
https://github.com/user-attachments/assets/eba91236-59e6-4aec-9042-336e46fa842c

I hope this shall satisfy your need.

where is the navbar and the footer??

also why is the heading not resume builder tool
isnt this the testimonial page??

the component loader.js file is not matching with the ui of testimonials page
so the navbar is little messed up

for now i have changed the contents and added footer

can you check the deployment once there is still a ui issue

some content is getting hidden


Update shell type option for opta shell

I take it someone asked to switch to this new flag?

Yeah, @NitinAgg asked for it. He mentioned that --use-shell seems boolean and gives a wrong impression.


[Feature Request] Ability to set ReplicaCount for Frontend, History, Matching and Worker pods

Is your feature request related to a problem? Please describe.
According to the Temporal Server documentation, it is recommended to have 5 Frontend, 15 History, 17 Matching, and 3 Worker Services per cluster in real-life production deployments.
But as of now, it is not possible. The helm chart provides a single variable server.replicaCount which commonly set the value for frontend, history, matching and worker services.
I would like the ability to set replica count individually if a user prefers to do so when setting up production environments.
Perhaps it would be good to offer the same for other supporting services like web, admintools, kube-state-metrics as well.
Describe the solution you'd like
Ability to set individual replica counts for cluster services, in the form of,
helm install -f values/values.mysql.yaml temporaltest \
  --set frontend.replicaCount=5 \
  --set history.replicaCount=15 \
  --set matching.replicaCount=17 \
  --set worker.replicaCount=3 \
  --set web.replicaCount=2 \
  --set admintools.replicaCount=2 . --timeout 900s

Additional context

Maybe you can set replicaCount in every service, than you can do that.

Thanks for the help. We can close this issue.


Error in query preparation (but query is correct)

I try to make query:
SELECT avg(net) AS payments_amount
FROM default.payments AS t
WHERE t.payments_amount > 0

And it fails with error:
Received exception from server:
Code: 184. DB::Exception: Received from clickhouse-server:9000, <IP_ADDRESS>. DB::Exception: Aggregate function avg(net) is found in WHERE or PREWHERE in query.

Problem appear when select field name (AS payments_amount) same as field in table.
t.payments_amount try to link with field in results payments_amount.
I specified table name as t, and field in WHERE must use field from table, not from results.
P.S.:
Create table statement: https://pastebin.com/uNm1JeNB

@Bacher I think this is a special design in CH that different from Mysql etc. Fields in WHERE that was from results table columns. This makes query pithier. Also,  this made some problems. Specify a different table column name is the easiest way to solve the problem.

Yes, different column name fixes this problem.
About special design, I disagree. I especially use an alias for table name t and use column name with table alias name (t.payments_amount). I think If Clickhouse engine supports table aliases, It has to support them in all cases.

Of course. Qualified names should not be confused with simple aliases.

Already fixed
CREATE TABLE payments
(
    `net` UInt32,
    `payments_amount` UInt32
)
ENGINE = Memory

Ok.

0 rows in set. Elapsed: 0.019 sec.

SELECT avg(net) AS payments_amount
FROM payments AS t
WHERE t.payments_amount > 0

┌─payments_amount─┐
│             nan │
└─────────────────┘

1 rows in set. Elapsed: 0.028 sec.

The bug is still here for distributed tables (<IP_ADDRESS>)
> CREATE TABLE gb_refs.currencyRateShard (`date` Date, `base` FixedString(3), `code` FixedString(3), `src` Int8, `rate` Decimal(18, 6)) ENGINE = ReplicatedReplacingMergeTree('/clickhouse/tables/{shard}/gb_refs/currencyRateShard', '{replica}') PARTITION BY toYYYYMM(date) ORDER BY (date, base, code, src) SETTINGS index_granularity = 8192

> CREATE TABLE gb_refs.currencyRate (`date` Date, `base` FixedString(3), `code` FixedString(3), `src` Int8, `rate` Decimal(18, 6)) ENGINE = Distributed(gamebeat, gb_refs, currencyRateShard, toYYYYMM(date))

> SELECT base,code,MAX(`date`) AS `date` FROM currencyRateShard WHERE `currencyRateShard`.`date`<='2019-03-01' GROUP BY base,code

┌─base─┬─code─┬───────date─┐
│ USD  │ XPT  │ 2019-02-28 │
...

> # The same query but currencyRateShard replaced with currencyRate
> SELECT base,code,MAX(`date`) AS `date` FROM currencyRate WHERE `currencyRate`.`date`<='2019-03-01' GROUP BY base,code

Progress: 0.00 rows, 0.00 B (0.00 rows/s., 0.00 B/s.) Received exception from server (version 19.5.3):
Code: 184. DB::Exception: Received from ch-dev-n1.a:9000, <IP_ADDRESS>. DB::Exception: Received from ch-dev-n4.a:9000, <IP_ADDRESS>. DB::Exception: Aggregate function MAX(date) is found in WHERE or PREWHERE in query.


Python API equivalent of reconnect ?

so I was playing around with the methods of using the nxbt
so
sudo nxbt macro -c "text.txt" -r
works really well in terms of connecting to my switch even tho it exits after running and has to reconnect
I was looking for the python API to reconnect and have trouble finding it as using the example to press B i think get stuck at creating and finding my device

Bump

Ok I just downloaded the bluez.py file so that I could use it, then I used this:

It seems to show up on the switch

NEVER MIND!! You don't need to add the bluez.py file at all! Just use this lmao (sorry!):


fix(Storybook): changes check for instance of Element

Description
This PR fixes loading errors happening on the following mixins stories:
withMarqueeSync
withUpdates
withTags

changed the conditional in get componentTarget method to look for instance of  Element instead of containing string "Element"  so that the conditional will work on production and development builds

References
Jira-683
Testing

clone branch
yarn start
check the following mixin stories to see if they are loading properly:
withMarqueeSync
withUpdates
withTags

Automation
Checklist

[x] all commented code has been removed
[x] any new console issues have been resolved
[x] code linter and formatter has been run
[x] test coverage meets repo requirements
[x] PR name matches the expected semantic-commit syntax

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


#301: Ensure poly files can be saved

Fixes #301

@tim-vd-aardweg I updated the documentation for write_polyfile and fixed a code smell by adding a comment to the _get_serializer function.


First example Exercism issue

Screenshot of issue
Explain it in words
Clone the repo and look for it

test https://github.com/exercism/exercism.io/pull/2954


lefthook.yml is automatically added when using my library

:wrench: Summary
lefthook.yml file is added when other project added my library.
The content of it is the same with internal/templates/config.tmpl
Lefthook version

1.6.8

Steps to reproduce

Create react native library via create-react-native-library
Create react native app and add above library via git url
Run yarn

Expected results

Should not generate this file

Actual results

lefthook.yml is added to application's source code

Possible Solution
Logs / Screenshots
The content of generated file lefthook.yml
# EXAMPLE USAGE:
#
#   Refer for explanation to following link:
#   https://github.com/evilmartians/lefthook/blob/master/docs/configuration.md
#
# pre-push:
#   commands:
#     packages-audit:
#       tags: frontend security
#       run: yarn audit
#     gems-audit:
#       tags: backend security
#       run: bundle audit
#
# pre-commit:
#   parallel: true
#   commands:
#     eslint:
#       glob: "*.{js,ts,jsx,tsx}"
#       run: yarn eslint {staged_files}
#     rubocop:
#       tags: backend style
#       glob: "*.rb"
#       exclude: '(^|/)(application|routes)\.rb$'
#       run: bundle exec rubocop --force-exclusion {all_files}
#     govet:
#       tags: backend style
#       files: git ls-files -m
#       glob: "*.go"
#       run: go vet {files}
#   scripts:
#     "hello.js":
#       runner: node
#     "any.go":
#       runner: go run
`

Looks like lefthook is used as a dev dependency: https://github.com/callstack/react-native-builder-bob/blob/main/package.json#L25. I think it would better to create this issue in react-native-builder-bob repo, since auto-installing lefthook hooks when installing an npm package is a feature and it is used by many people from the very beginning of the lefthook project. The easiest solution is to ask the react-native-builder-bob developers to remove the dependency.

@namnh-0652 Actually devDependencies should not be installed when installing a dependent package. It will happen only if lefthook was in the dependencies section.
I think I missed that you mentioned

Create react native app and add above library via git url

Looks like in this case devDependencies are being installed too, so lefthook package generates the lefthook.yml.
Since this happens implicitly I can suggest you to add an empty lefthook.yml and commit it into the app repo. I haven't thought of this flow (installing a package via git url), and there's no mechanism to tell npm not to use postinstall scripts when installing a package with git url (I don't know any). So the solution can be to use an empty (dummy) lefthook config that does nothing.
Or you can set the env variable CI=true before running the yarn install, but I think this is less convenient.

I will close this issue since this is not a bug but kind of a side effect of using git urls in npm dependencies.


Can I run under iOS? And  Is it thread safe?

Please don't open issues for MuJS on github to ask questions.
Use IRC to ask questions on the developers IRC channel: #mupdf on irc.freenode.net

OK，sorry
------------------ Original ------------------
From: "Sebastian<EMAIL_ADDRESS>Date: Wed, May 17, 2017 05:45 PM
To<EMAIL_ADDRESS>Cc: "夜禹"me<EMAIL_ADDRESS>Subject: Re: [ccxvii/mujs] Can I run under iOS? And Is it thread safe? (#39)
Please don't open issues for MuJS on github to ask questions.
Use IRC to ask questions on the developers IRC channel: #mupdf on irc.freenode.net
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Import missing Files or File Metadata

Files without metadata (these files are present in Sharepoint, but we don't have metadata for them, so they are not indexed by coveo):

[x] /sites/default/files/en/assets/brochures/bpd/clonepix-2.pdf
[x] /sites/default/files/en/assets/coa/reagents/clonedetect-human-igg-specific-fluorescein-k8200-cda0821a.pdf
[x] /sites/default/files/en/assets/coa/reagents/clonematrix-k8510-mcw0921c.pdf
[x] /sites/default/files/en/assets/coa/reagents/clonematrix-k8510-mcw0921d.pdf
[x] /sites/default/files/en/assets/coa/reagents/clonematrix-k8510-mcw1021a.pdf
[x] /sites/default/files/en/assets/coa/reagents/clonemedia-cho-growth-a-without-l-gln-k8840-99901210801.pdf
[ ] /sites/default/files/en/assets/data-sheets/reagents/calcium-assays-for-the-flipr-system.pdf
[ ] /sites/default/files/en/assets/infographics/dd/cns/patch-clamp-rig.pdf
[x] /sites/default/files/en/assets/infographics/dd/img/history-of-organoid-research.pdf
[ ] /sites/default/files/en/assets/scientific-posters/br/high-throughput-igg-quantitation-platform-for-clone-screening-during-drug-discovery-development.pdf
[ ] /sites/default/files/en/assets/scientific-posters/br/multi-parametric-phenotypic-thp-1-cell-differentiation-and-cytokine-secretion-assay-for-evaluation-of-anti-inflammatory-compounds.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/flipr/complex-event-analysis-for-neurotoxic-profiling-on-human-ipsc-derived-neural-spheriod-3d-cultures.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/flipr/high-throughput-assessment-of-compound-induced-pro-arrhythmic-effects-in-human-ipsc-derived-cardiomyocytes.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/3d-imaging-and-analysis-of-angiogenesis-in-the-organ-on-a-chip-platform.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/ai-based-analysis-of-complex-biological-phenotypes.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/automated-3d-cell-based-assays-using-novel-flowchip-system-and-high-content-imaging.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/cell-migration-analysis-using-automated-cell-imaging.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/deep-learning-based-image-analysis-for-label-free-live-monitoring-of-ipsc-3d-organoid-cultures.pdf
[x] /sites/default/files/en/assets/scientific-posters/dd/img/improving-robustness-of-cell-painting-with-near-infrared-label-and-advanced-image-and-data-analytics.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/live-cell-assays-measuring-complex-compound-effects-in-real-time.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/lung-organoids-as-an-assay-model-for-in-vitro-assessment-of-toxicity-effects-by-3d-high-content-imaging-and-analysis.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/measure-cell-migration-using-automated-cell-imaging-and-analysis.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/monitoring-organoid-development-and-characterization-of-calcium-oscillation-activities-in-ipsc-derived-3d-cerebral-organoids.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/multiplexed-assays-for-neurotoxicity-evaluation-using-neural-3d-cell-models.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/multiplexed-automated-imaging-assays-for-compound-testing-using-induced-pluripotent-stem-cell-derived-cells.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/multiplexed-automated-imaging-assays-for-compound-testing-using-ipsc-derived-cell-models.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/neurotoxicity-profiling-using-human-ipsc-derived-neural-spheroid-3d-cultures.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/novel-assay-methods-for-cancer-patient-derived-organoids.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/novel-high-throughput-solution-for-screening-drugs-with-versagel-3d-tumor-culture-model-and-high-content-imaging.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/organoids-for-disease-modeling-and-in-vitro-drug-screening.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/phenotypic-cell-based-assays-with-new-automated-imaging-system-and-cell-analysis-software.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/quantitative-analysis-of-cytotoxicity-using-ipsc-derived-stem-cells.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/simplified-workflow-for-phenotypic-profiling-based-on-the-cell-painting-assay.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/using-a-laser-light-source-for-high-content-automated-imaging-to-improve-sensitivity-speed-precision-for-complex-biological-assays.pdf
[ ] /sites/default/files/en/assets/scientific-posters/dd/img/water-immersion-objectives-for-automated-high-content-imaging.pdf
[x] /sites/default/files/en/assets/user-guide/dd/flipr/screenworks-system-control-software-v5-1-4.pdf
[x] /sites/default/files/en/assets/user-guide/dd/img/in-carta-installation-guide-5089268a.pdf
[x] /sites/default/files/en/assets/user-guide/dd/img/in-carta-phenoglyphs-user-guide-5087398b.pdf
[x] /sites/default/files/en/assets/user-guide/dd/img/in-carta-qr-protocol-design-5089273a.pdf
[x] /sites/default/files/en/assets/user-guide/dd/img/in-carta-qr-select-view-image-data-5089274a.pdf
[x] /sites/default/files/en/assets/user-guide/dd/img/in-carta-qr-view-classify-export-results-5089275a.pdf
[x] /sites/default/files/en/assets/user-guide/dd/img/in-carta-sinap-user-guide-5087400b.pdf
[x] /sites/default/files/en/assets/user-guide/dd/img/in-carta-volumetrics-user-guide-5087399b.pdf
[ ] /sites/default/files/en/assets/white-paper/br/gxp-regulated-industry-assessments-of-microplate-readers.pdf
[ ] /sites/default/files/en/assets/white-paper/br/gxp-regulated-industry-assessments-of-softmax-pro-software.pdf
[ ] /sites/default/files/en/assets/publications/reagents/clonemedia-hek.pdf
[ ] /sites/default/files/en/assets/publications/reagents/clonemedia-chok1sv.pdf
[ ] /sites/default/files/en/assets/publications/reagents/hybridoma-clonemedia-reagent-guide.pdf
[ ] /sites/default/files/en/assets/publications/bpd/industry-view-on-relative-importance-of-clonality-of-biopharmaceutical-producing-cell-lines.pdf
[ ] /sites/default/files/en/assets/publications/bpd/clonepix-fl-and-intracellular-staining-facilitate-isolation-of-high-producer-cell-lines-for-monoclonal-antibody-manufacturing.pdf
[ ] /sites/default/files/en/assets/publications/bpd/qpix-chroma-filter.pdf
[ ] /sites/default/files/en/assets/publications/bpd/sequential-screening-by-clonepix-fl-and-intracellular-staining-facilitate-isolation-of-high-producer-cell-lines-for-monoclonal-antibody-manufacturing.pdf
[ ] /sites/default/files/en/assets/publications/bpd/transcriptomics-based-drug-repositioning-pipeline-identifies-therapeutic-candidates-for-covid-19.pdf
[ ] /sites/default/files/en/assets/app-note/br/detect-endotoxin-with-the-kinetic-qcl-kinetic-chromogenic-lal-assay.pdf

Files missing (both the file and the metadata is not present)

[ ] /sites/default/files/en/assets/presentations/dd/flipr/functional-and-mechanistic-neurotoxicity-profiling-using-human-ipsc-derived-neural-3d-cultures.ppsx

@dev-rajneeshkumar as discussed, we don't have the metadata for these files as they don't exist in the files export sheet. could you please verify?

@andreituicu checked of a view as we found some issue with the export and could add a few of the missing one.

Closing this as outdated as applications & product resources have been cheked.


Copilot chat and a couple of other features not available despite copilot ready status (and subscription regulated)

VS Code Version: 1.85.0
OS Version: Windows 11
Logs:

Steps to Reproduce:

Open VScode
See copilot chat icon on the extensions sidebar for 2/3 seconds
Copilot chat is now gone as well as other features but Completions (the only one working)
Check copilot status is ready
Try to use copilot command (for instance Explain This)
Get error 'Command not found'
open the context menu and find there's no copilot menu item on the list

Can you open the Output Pane (Ctrl+Shift+U) and on the drop down on the right side choose GitHub Copilot Chat and share the contents of that?

2023-12-14 09:16:42.042 [info] [gitExtensionService] Initializing Git extension service. 2023-12-14 09:16:42.042 [info] [gitExtensionService] Successfully activated the vscode.git extension. 2023-12-14 09:16:42.042 [info] [gitExtensionService] Enablement state of the vscode.git extension: true. 2023-12-14 09:16:42.042 [info] [gitExtensionService] Successfully registered Git commit message provider. 2023-12-14 09:16:42.567 [info] [auth] Logged in as rmadeiraneto 2023-12-14 09:16:43.178 [info] [chat] copilot token chat_enabled: false 2023-12-14 09:16:43.178 [info] [auth] Got Copilot token for rmadeiraneto 2023-12-14 09:41:43.197 [info] [auth] Logged in as rmadeiraneto 2023-12-14 09:41:43.659 [info] [chat] copilot token chat_enabled: false 2023-12-14 09:41:43.659 [info] [auth] Got Copilot token for rmadeiraneto 2023-12-14 10:06:43.665 [info] [auth] Logged in as rmadeiraneto 2023-12-14 10:06:44.118 [info] [chat] copilot token chat_enabled: false 2023-12-14 10:06:44.118 [info] [auth] Got Copilot token for rmadeiraneto 2023-12-14 10:31:44.128 [info] [auth] Logged in as rmadeiraneto 2023-12-14 10:31:44.599 [info] [chat] copilot token chat_enabled: false 2023-12-14 10:31:44.599 [info] [auth] Got Copilot token for rmadeiraneto 2023-12-14 10:56:44.607 [info] [auth] Logged in as rmadeiraneto 2023-12-14 10:56:45.074 [info] [chat] copilot token chat_enabled: false 2023-12-14 10:56:45.074 [info] [auth] Got Copilot token for rmadeiraneto 2023-12-14 11:21:45.087 [info] [auth] Logged in as rmadeiraneto 2023-12-14 11:21:45.574 [info] [chat] copilot token chat_enabled: false 2023-12-14 11:21:45.574 [info] [auth] Got Copilot token for rmadeiraneto 2023-12-14 11:46:45.586 [info] [auth] Logged in as rmadeiraneto 2023-12-14 11:46:46.005 [info] [chat] copilot token chat_enabled: false 2023-12-14 11:46:46.005 [info] [auth] Got Copilot token for rmadeiraneto 2023-12-14 12:11:46.011 [info] [auth] Logged in as rmadeiraneto 2023-12-14 12:11:46.472 [info] [chat] copilot token chat_enabled: false 2023-12-14 12:11:46.472 [info] [auth] Got Copilot token for rmadeiraneto 2023-12-14 12:36:46.486 [info] [auth] Logged in as rmadeiraneto 2023-12-14 12:36:46.950 [info] [chat] copilot token chat_enabled: false 2023-12-14 12:36:46.950 [info] [auth] Got Copilot token for rmadeiraneto 2023-12-14 13:01:46.956 [info] [auth] Logged in as rmadeiraneto 2023-12-14 13:01:47.471 [info] [chat] copilot token chat_enabled: false 2023-12-14 13:01:47.472 [info] [auth] Got Copilot token for rmadeiraneto 2023-12-14 13:10:06.082 [info] [gitExtensionService] Initializing Git extension service. 2023-12-14 13:10:06.082 [info] [gitExtensionService] Successfully activated the vscode.git extension. 2023-12-14 13:10:06.082 [info] [gitExtensionService] Enablement state of the vscode.git extension: true. 2023-12-14 13:10:06.082 [info] [gitExtensionService] Successfully registered Git commit message provider. 2023-12-14 13:10:06.654 [info] [auth] Logged in as rmadeiraneto 2023-12-14 13:10:07.113 [info] [chat] copilot token chat_enabled: false 2023-12-14 13:10:07.113 [info] [auth] Got Copilot token for rmadeiraneto

2023-12-14 09:16:42.042 [info] [gitExtensionService] Initializing Git extension service.
2023-12-14 09:16:42.042 [info] [gitExtensionService] Successfully activated the vscode.git extension.
2023-12-14 09:16:42.042 [info] [gitExtensionService] Enablement state of the vscode.git extension: true.
2023-12-14 09:16:42.042 [info] [gitExtensionService] Successfully registered Git commit message provider.
2023-12-14 09:16:42.567 [info] [auth] Logged in as rmadeiraneto
2023-12-14 09:16:43.178 [info] [chat] copilot token chat_enabled: false
2023-12-14 09:16:43.178 [info] [auth] Got Copilot token for rmadeiraneto
2023-12-14 09:41:43.197 [info] [auth] Logged in as rmadeiraneto
2023-12-14 09:41:43.659 [info] [chat] copilot token chat_enabled: false
2023-12-14 09:41:43.659 [info] [auth] Got Copilot token for rmadeiraneto
2023-12-14 10:06:43.665 [info] [auth] Logged in as rmadeiraneto
2023-12-14 10:06:44.118 [info] [chat] copilot token chat_enabled: false
2023-12-14 10:06:44.118 [info] [auth] Got Copilot token for rmadeiraneto
2023-12-14 10:31:44.128 [info] [auth] Logged in as rmadeiraneto
2023-12-14 10:31:44.599 [info] [chat] copilot token chat_enabled: false
2023-12-14 10:31:44.599 [info] [auth] Got Copilot token for rmadeiraneto
2023-12-14 10:56:44.607 [info] [auth] Logged in as rmadeiraneto
2023-12-14 10:56:45.074 [info] [chat] copilot token chat_enabled: false
2023-12-14 10:56:45.074 [info] [auth] Got Copilot token for rmadeiraneto
2023-12-14 11:21:45.087 [info] [auth] Logged in as rmadeiraneto
2023-12-14 11:21:45.574 [info] [chat] copilot token chat_enabled: false
2023-12-14 11:21:45.574 [info] [auth] Got Copilot token for rmadeiraneto
2023-12-14 11:46:45.586 [info] [auth] Logged in as rmadeiraneto
2023-12-14 11:46:46.005 [info] [chat] copilot token chat_enabled: false
2023-12-14 11:46:46.005 [info] [auth] Got Copilot token for rmadeiraneto
2023-12-14 12:11:46.011 [info] [auth] Logged in as rmadeiraneto
2023-12-14 12:11:46.472 [info] [chat] copilot token chat_enabled: false
2023-12-14 12:11:46.472 [info] [auth] Got Copilot token for rmadeiraneto
2023-12-14 12:36:46.486 [info] [auth] Logged in as rmadeiraneto
2023-12-14 12:36:46.950 [info] [chat] copilot token chat_enabled: false
2023-12-14 12:36:46.950 [info] [auth] Got Copilot token for rmadeiraneto
2023-12-14 13:01:46.956 [info] [auth] Logged in as rmadeiraneto
2023-12-14 13:01:47.471 [info] [chat] copilot token chat_enabled: false
2023-12-14 13:01:47.472 [info] [auth] Got Copilot token for rmadeiraneto
2023-12-14 13:10:06.082 [info] [gitExtensionService] Initializing Git extension service.
2023-12-14 13:10:06.082 [info] [gitExtensionService] Successfully activated the vscode.git extension.
2023-12-14 13:10:06.082 [info] [gitExtensionService] Enablement state of the vscode.git extension: true.
2023-12-14 13:10:06.082 [info] [gitExtensionService] Successfully registered Git commit message provider.
2023-12-14 13:10:06.654 [info] [auth] Logged in as rmadeiraneto
2023-12-14 13:10:07.113 [info] [chat] copilot token chat_enabled: false
2023-12-14 13:10:07.113 [info] [auth] Got Copilot token for rmadeiraneto

I had a personal subscription that I cancelled in order to be added to the company I work for' org, that has an enterprise subscription of copilot. Since then it stopped working well

If you are part of an enterprise subscription you need to enable the beta features at the organisation level first, as it may be overriding your settings.

@rmadeiraneto You should be seeing a notification that says you need to ask your admin to enable chat for your organization. Do you not see this notification?

I don't. But I've already asked and everything looks fine. Thank you!

@rmadeiraneto as in your organization has turned on chat now and it's working again for you?

Yes, exactly

Glad to hear you're unblocked. From what I am hearing, this behavior of chat not being enabled by default is intentional at least for now, but will change in the foreseeable future.

Nice, thanks for all the help guys!


M05-Lab05: Updated Lab 5 instructions

Updated lab 5 instructions to include clicking on the security menu in the instructions which confuses students. Also added a missing step in self hosted agent configuration
Related Issue
Link related Github Issue 🢂 Fixes #172
Checklist
Mark completed with "x" between brackets, "[x]", or checking the box once the PR is created:

[x] Has related GitHub Issue 💥 Create Issue 📝
[x] Tested it
[x] Read the PR collaboration guide 👓 Collaboration Guide 📝

Changes proposed in this pull request:

Added a step so that students know they have to click on the security menu from the dropdown before accessing personal access token option
Added a missing step in setting up self hosted agent

Hi @yashints :) I cannot see the security option

I only see it once a click on PAT, clicking Users Settings icon just shows the options on the screenshot

@unaihuete93  Seems like there are two flavours of menus available

my students were seeing my version yesterday. Maybe we need to add both?

@unaihuete93 updated the instructions to include both scenarios

looks great! :) approved! thanks for you help @yashints ❤


Feature Request: Save Default Search Parameters in Profile

I would love to be able to set default values for some dropdown fields when using the card search feature.
For example/for my own uses, here's what I would set my defaults to:
Card pools & Ban Lists
Rotation - Active/Latest
Ban List - Active/Latest
Submit (filters)
Sort by - Faction
View as - Images Only

Would be good to get a discussion going on this, since it's a useful feature, but expected implementation of it can vary a fair bit from person to person.
Here are some of my initial thoughts:

Would we want to offer this as a toggle/checkbox button so that the user has to interact/approve for it to be saved as their default search preference, or;
Automatically save and apply this, only if the user is logged in (although not all users might prefer this, as after their initial search on this, they then might have to have to edit 3 input separate inputs again if they wanted to change any of these defaults)

Perhaps we could add an additional option in the 'sort by' drop-down menu like so

That would only be added if the user is logged in and has previously searched before, therefore it becomes the 'default' option once those conditions are met. That would also make it easier to change later on if they wanted to swap from their defaults.
To expand on this suggestion, if 'Sort by Preferred' is select, it would use some JS to automatically take their preferred values (store in localStorage) and apply them to the other inputs, if the 'sort by' value changes to anything else, it will revert the other inputs to their default/1st option values.

I'd love this feature. As someone that likes to bake original decks, it's a bit of a pain to select these filters constantly every time. In terms of implementation, a first easy approach could be to allow folks to select "defaults" in their profile. Ir could even be saved to Local Storage with an explicit caveat that the defaults are tied to the device/browser. In any case that would be a huge improvement from having to constantly select those exact 4 options that the OP mentioned.

Another approach could be to just add a small button next to the drop-downs in Card pools & Ban Lists that is "latest standard" which automatically sets the rotation and banlist drop-downs, assuming that the most frequent lookups are for standard legal cards anyways, in which case you wouldn't need to even save anything to a profile.

I haven't looked through the code, but I'd ask if nrdb has analytics to understand how most users leverage the Advanced search page, and be able to have a data-driven argument against just setting the default to what the OP said. I personally always use the same exact 4 options that the OP asked for, so I'd be more than happy if those were the global defaults.


kyber crate extraction script

A simple shell script to pull out kyber as a separate crate for Aeneas.
cc @protz

When running the script I get
fixing up src/PERFORMANCE.md ...
sed: 1: "src/PERFORMANCE.md": unterminated substitute pattern

speaking of which, I need to start regularly updating this file with every PR again ...

When running the script I get

hm, do you use mac sed? gsed should be able to handle this. I didn't want to make this more complex than necessary ...

speaking of which, I need to start regularly updating this file with every PR again ...

Yeah we should update the numbers from time to time....

When running the script I get

hm, do you use mac sed? gsed should be able to handle this. I didn't want to make this more complex than necessary ...

Yeah, I used gsed and it worked. We can just leave the script as is since it's temporary.

Yeah, I used gsed and it worked. We can just leave the script as is since it's temporary.

Yes, we should delete this as soon as it's not needed anymore.


Looking for manual approve of tag edits.

Currently looking for manual approval of editing of a token I submitted a few days ago. (https://github.com/solana-labs/token-list/pull/12411)
I didn't realise the tags where going to affect the way things were handled in apps such as Phantom Wallet. I wrote one tag as NFT based on the fact we were using them for NFT whitelist tokens and this pulled my token into the Collectables portion of Phantom wallet rather than the main wallet. So looking to get all tags removed currently to fix this.

merged

Thank you so much! :)


Change the name of the used datasource from jdbc/kthfs...

...to jdbc/hopsworks to be consistent with the database name

In glassfish admin gui in the Resources section - JDBC resources the name of the resource has to change accordingly.
In Configurations - Server Config - Security - Realms the jndi name has to change accordingly as well


Screencap Update needed

[The UI of the site/org admin area in Atlassian organizations (as well as the UI of all Atlassian Cloud applications) changed at least a year ago, so most of the screencaps in this tutorial are out of date and confusing to folks trying to get this set up.  Can someone go through and update those? ]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 04509836-867e-279f-c1d6-135a237d357e
Version Independent ID: e05a10ce-c46b-334e-78e2-30b416ed904a
Content: Tutorial: Configure Atlassian Cloud for automatic user provisioning with Azure Active Directory
Content Source: articles/active-directory/saas-apps/atlassian-cloud-provisioning-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @zhchia
Microsoft Alias: jeedes

@ergopotato thanks! I have assigned this feedback to the content author to look into.

@ergopotato @MarileeTurscak-MSFT @twimmers
I have updated the Prerequisites and Step 2 of this tutorials as per details found in Atlassian support documentation. The change should be live in next 48 hrs.

#please-close


updated documentation

include a few more files

Only 3 files added/ content added. No code deleted.


Improve SPI driver documentation with guidelines handling SPI buffers

Is your enhancement proposal related to a problem? Please describe.
The current SPI driver transfer API has parameters for an array of struct spi_buf for transmits and another for receive.
The SPI driver is based on a model of a full-duplex bus where bits are transmitted and received on the same (may be on different edges).  This implies struct spi_buf must be processed in pairs and are the same length.  A new test of was added to tests/drivers/spi/spi_loopback which tests a TX buffer with length less than the corresponding RX buffer.  The test assumes the driver will transmit 0 bytes while the remaining bytes of the RX buffer are received.  Some SPI HW requires transmit of some data value to generate clocks.  It is not documented what value to transmit.  I did see the "overrun-character" property in spi-controller.yaml bindings.  The test code is not using this value  and only one vendor is using this property.   Test code should use this property.
Next, "dummy" or tri-state I/O's while generating clocks.  The SPI documentation does state a TX buffer with data a NULL data pointer and non-zero length should be interpreted as generating dummy clocks.  This is HW specific.  Some SPI controllers cannot generate clocks without driving the TX line whereas others can.  Any loopback tests must take this into account and ignore data captured during "dummy" clocks.
Next up Extended modes optional feature to support dual, quad, or octal.  How are the TX and RX buffers to be processed?  Some SPI controllers can split their I/O lines.  I believe there is one SPI controller which can split 8 lines into 4 TX and 4 RX.  Other controllers operate half-duplex in dual and quad mode.  The split bus designs could process SPI buffers in a full duplex fashion.  For those controllers implementing dual and quad as half-duplex there are choices:

Do all TX buffers first, then do all RX buffers.
Limit driver to only TX or RX buffers being passed.  If both are passed return error.
For each pair of (TX, RX) to TX first then RX and move to next pair.  Does this make sense?  If the target SPI device interprets TX data as a command based on CS assertion/de-assertion then this option will not work (SPI flashes).

Describe the solution you'd like
More guidelines for implementing a SPI driver based on various SPI HW implementation.
More guidelines for processing SPI buffers.
Describe alternatives you've considered
Give up SPI DMA and other performance enhancements (dual/quad) and implement the most simple byte-by-byte transfer to match the test cases.
De-emphasize the SPI driver and develop custom flash drivers and try the mspi driver for my quad SPI controller.

I would actually love if this gets done,
The current docs for SPI driver dev are very vague

Will try to find some time for this. I have noticed many times there is a confusion on how SPI buffers are meant to work.


IE 11 support with Pixi v4

We recently updated Pixi from v3 to v4 and noticed that the autoDetectRenderer is no longer allowing for WebGL to be used with IE 11, in case its of importance the render options we have used are as follows:
var rendererOptions = {antialias:false, view:canvasView, resolution:resolution, transparent:false, preserveDrawingBuffer:false, autoResize:true, clearBeforeRender:true};
this.renderer = PIXI.autoDetectRenderer(width, height, rendererOptions);
The resolution value is determined by the value of window.devicePixelRatio, just in case you are interested :)
So I am wondering is this lack of support for Windows with IE and Edge with PIXI 4 intentionally not supporting these browsers?

Hi @shanemccartney
The reason PIXI does not support IE11 is because of it's lack of stencil support in it's WebGL implementation. Looking through the code, the check for the stencil support was added in February 2015.

In that case it might make sense to update the supported WebGLRenderer browsers on the FAQ?

Hey @shanemccartney! hope all is well! Thats a bit of an odd one, v4 webGL should certainly be capable of running in IE11. Possible an oversight here. @themoonrat hows about we label this as a browser bug to be investigated.

Hey @GoodBoyDigital, yes all is going great!
I agree something strange within the conditions of what you require for support with WebGL in the latest version of PIXI v4 as I say in v3 WebGL with IE 11 works fine. For now I am just accepting this as a limitation of PIXI v4 as a client wanted us to update an old HTML5 project.

hello! Man, took a while to get round to this! - but investigation is complete! After looking into this a little further the issue seems to be specific to older versions of IE11.
In browser stack IE11 on (windows 8.1) does not work with v4. This is due to a particular version not supporting STENCIL_TEST , gl.UNSIGNED_SHORT and gl.UNSIGNED_BYTE
These are important elements that we use for batching and masking in v4. This being the case, its probably best to use canvas for theses older versions of IE11.
The good news is that All versions of IE11 (windows 10) afterwards and all versions of edge I tested seem to work (and default to the WebGL renderer) thought which is cool!
Hopefully that all makes sense!
Cheers!


Refactor calling control scripts

We need a unified way of calling control scripts. I would strongly suggest using typed-process.
The way of calling control scripts should automatically handle errors in the following way:

if the control script exited with code 0 and if the current logging level is INFO then output the script call, script output, and exit code to logs.
if the control script exited with code other than 0 and if the current logging level is no more restrictive than WARN then output all of the same things

should probably be done after #71


Apply expected file permissions to linux files after authenticode signing

PR Summary
When trying to authenticode sign files on Windows the linux file permissions are lost. We store them in a json file and then re-apply them.
Fixes https://github.com/PowerShell/PowerShell/issues/18495
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

/backport to release/v7.3.1

/backport to release/v7.2.9

/backport to release/v7.2.9


Docs: Event-Driven Architecture

(docs): Adding the initial draft for the Event-Driven Architecture page for the developer documentation.
This PR takes care of Issue #443.

@yuval-hazaz - Per your request for an "event-driven architecture" doc (to be linked from our website)- please review and approve.

@dericksozo - Good feedback from @yuval-hazaz - Let's update this screenshot-

and display it "active", i.e. after enabling the message broker, and connecting the Service to the topic. Something like-


normal_ext.dynamic rendertypes do not obey ingame transparency modifiers

It's self-explanatory. If a unit, with a cloth that has a dynamic rendertype, uses an invisibility weapon, the cloth will remain visible even to enemies.

Ohh, thanks for letting me know. Almost sounds like this could be related to #70. (Which would be nice to be able to fix them both at the same time.)


Update README.md

I've added example for multiple token injection. I had to read source code to figured out which separator is expected.

[Current coverage][cc-pull] is 70.23%

No coverage report found for master at 1da136a.

Powered by Codecov. Last updated by [1da136a...4203822][cc-compare]
[cc-base-branch]: https://codecov.io/gh/zalando/tokens/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/zalando/tokens/compare/1da136ad6ee68d86f95686a4918fa08d2ab0eaa2...4203822197e49bcdf94b628c44890e24ff2516f8
[cc-pull]: https://codecov.io/gh/zalando/tokens/pull/51?src=pr

:+1:

Thanks for the PR!

@harti2006 @kzimnicki-zalando The code here suggests a dependency on Zign. Am I right?

👍

:+1:

@LappleApple For local testing (on developers machine with 'static tokens') one way to fetch access-tokens could be using zign, that's correct. But in normal use (production on EC2-Instances), 'tokens' will fetch access-tokens by requesting authorization-server with credentials found in 'client.json' and 'user.json'.
I wouldn't call it a dependency. It's only one way to provide access-tokens on developers machine. Its also possible on developers machine to provide 'client.json' and 'user.json' with valid content and point to the tokens-lib to that directory.

Thanks, @jbellmann. This was good info, so I added it (reworked) to the "Local Testing" section; you should probably check to make sure I edited it accurately.


Take a look at K3s - lightweight Kubernetes-certified distro

See: https://k3s.io

"Both ARM64 and ARMv7 are supported with binaries and multiarch images available for both. k3s works great from something as small as a Raspberry Pi or as large as an AWS a1.4xlarge 32GiB server."
"k3s is wrapped in a simple package that reduces the dependencies and steps needed to run a production Kubernetes cluster. Packaged as a single binary, k3s makes installation and upgrade as simple as copying a file. TLS certificates are automatically generated to ensure that all communication is secure by default."
"K3s is a Certified Kubernetes distribution designed for production workloads in unattended, resource-constrained, remote locations or inside IoT appliances."

k3s is dead simple to spin up, and provides some really nice to haves out of the box.

an easy to use / understand local storage PVC
traefik installed by default for ingress (though, should probably upgrade to v2, stable helm release uses v1, I removed and reinstalled v2)
really easy LoadBalancer, if the Service exposes a port, it's exposed through that node's host port (again, should probably handle through traefik)

There are roles for k3s here https://github.com/rancher/k3s/tree/master/contrib/ansible


Fix for async_get_registry issue #19

async_get_registry is deprecated and has now been removed starting with Home Assistant 2023.5.0.

Thanks!


Initial draft of changes

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository.

@adrianbenavides Awesome, I have made the changes but due to merge conflicts had to create another PR. WDYT?
https://github.com/build-trust/ockam/pull/3636

Sure, no problem, whatever works for you! I'll review it today :+1:


Update link checker config

Some new links keep failing the link checker https://github.com/CivicActions/guidebook/actions/runs/8597402687/job/23556026804 so ignoring them in the config.

📚 Documentation preview 📚: https://civicactions-handbook--1368.org.readthedocs.build/en/1368/

This might not be needed if we merge #1379


Help: pattern for writing getters depending on state that might be null

I'm having a bit of trouble developing a pattern to handle getters with a dependency on some app state that may be null. See the getters bellow:
// getters.js
exports.org = ['org'];
exports.menus = ['menus'];
exports.selectedMenu = [exports.org, exports.menus, (org, menus) =>
  menus.find(menu => menu.get('id') === org.get('default_menu'))
];

If org and menus are both defined, this is fine. But it may be possible for them to be undefined, which would cause a .get() of undefined.
I know I can code defensively in computed properties to return a reasonable value if they are undefined but this feels like a bad pattern to adapt everywhere.
I believe part of the problem I'm having is that when getDataBindings returns an object (like below) it 'pulls' on the computed properties attempting to get a value
// menu.jsx - requires the getters.js
module.exports = React.createClass({
  mixins: [flux.ReactMixin],

  getDataBindings: function() {
    return {
      menus: Session.getters.menus,
      selectedMenu: Session.getters.selectedMenu,
    };
  },

  render() { ... }
});

I'm assuming that you have a pattern to avoid loading the menu.jsx component if the data required for it hasn't been populated yet? Do you just return false in the parent component's render() if the data isn't there? Am I making any sense?

Hi @tonytamps
What you are going through can happen when programming using reactively, you need to make sure all of the cases that are possible are handled.
While I agree getting in a pattern of defensive coding isn't ideal there are times where we need to be defensive or at least have a sensible default.
In your case, it looks like menus should always be a List or Map even if its empty.  One way to go about it would be:
exports.org = ['org'];
exports.menus = [
  ['menus'],
  (menus) => menus || toImmutable([])
];
exports.selectedMenu = [exports.org, exports.menus, (org, menus) =>
  menus.find(menu => menu.get('id') === org.get('default_menu'))
];

While this solution does require you to be defensive, it ensures that anything you build on top of the menus getter is getting the same type back, an Immutable.List.  This is a good compromise of being defensive while not letting the defensive pattern leak down into getters that are consuming menus
Hope this helps!  Let me know if you have any other questions.

So my problem might be that a lot of my getters are just `exports.getterName = ['propName'] which means I have to be defensive downstream.
I'm still a little concerned about the render function being overly defensive but I'll see how this change impacts it.
Do you favor the parent not rendering the child if the data isn't available, or the child not rendering itself if the data isn't available? I'm assuming the latter.

I would say that the parent should generally be responsible for choosing whether to render a child or not, based on the state of your application.
Keep in mind there is a difference between a value explicitly being null, in your case if there is no menu selected and the value being null or undefined because it relies on data that isn't available.

@tonytamps I'm curious, why wouldn't your store be responsible for returning the empty Immutable.List([]) when no data is available? null seems like a clearly anti-useful return type for your application.
If you're going through the trouble of defining getters for all the keypaths you use (I usually just use keypaths directly, but like your approach now that I see it), what would be wrong with @jordangarcia 's recommendation of casting to a default in the data's getter?

I'm curious, why wouldn't your store be responsible for returning the empty Immutable.List([])
It can! Sometimes it is. In this case it wasn't. I still don't have a strong reason to go either way but I'm leading towards this (using the store) because of the way it keeps the getters clean.

null seems like an un-useful return type for your application.
Totally agree. It was the crux of the problem.

what would be wrong with @jordangarcia 's recommendation of casting to a default in the data's getter
Nothing wrong, its actually correct and still required sometimes even when your store has been returning default data. Usually when you have a complex object and some of the getters are attempting to access child properties.

I'm also +1 for the parent generally being responsible for deciding whether or not to render the child.
Jury is still out on this. For now I'm putting it where the code is simplest.

I'll close the issue because I believe I have all the help I need. Thanks :grinning:


[CARBONDATA-2790][BloomDataMap]Optimize default parameter for bloomfilter datamap

To provide better query performance for bloomfilter datamap by default,
we optimize bloom_size from 32000 to 640000 and optimize bloom_fpp from
0.01 to 0.00001.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7547/

retest this please

retest sdv please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7589/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6344/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/6052/

retest this please

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7648/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6381/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7674/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6406/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6419/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7693/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7698/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6424/

LGTM


Allow package to be used on PHP 7.1 or latest

It will allow it to install on php 8.x, 9.x etc. but ensure that at least 7.1 is available.
See the above on https://getcomposer.org/doc/04-schema.md#require

This Closes #93

Would be lovely if this could be merged into the master branch <3

months overdue! +1

This PR in incomplete: Travis config must be updated as well (7.1 -> 8.0).


ParticleContainer.js should support tint optionality, as many effects require this

Doesn't seem like it would effect performance all that much, unless i'm missing something. The tint is applied in shader correct, and a CPU calculation done in client to invert the hex.
... Specifically, it becomes possible to animate the tint, or re-use the same "glow" texture in many different situations, especially if your animation data is pre-rendered.

Although this was posted first, I'm going to close it in favor of tracking this issue in #3899 since I saw it first 😜
Thansk!

One quick question though: Are you asking for a tint that is applied to all sprites in the particle container, or a tint per-sprite in the container?

@englercj would it be possible to optionally support tinting in the particle container for each Sprite? We are running into a situation where having tinting on a huge number of sprites (with high performance) would be a huge boon. Are there major technical limitations for that?
It seems like a simple enough per pixel operation roughly equivalent to 3 times the opacity transform, but I'm a laymen when it comes to graphics.

@nwlieb We might add it as one of "properties" option: https://github.com/pixijs/pixi.js/blob/dev/src/particles/ParticleContainer.js#L144

This is unrelated to #3899 since that one only applies to the entire container.
This, however, is a per-particle tint. Which would be pretty awesome since in most if not all particle effects the ability to change the color is a must.
@englercj can you reopen this?

Yes I can, tinting each aprticle could be very useful.


Update dependencies

just updating VS version and dependencies

:+1:

Did you ever ask Praneeth about these tests @mikehancock

I did, he said he'll take a look, but they are failing on master - so I don't think it's anything I've done