fix: improve thor slippage

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5181   👈

This comment was auto-generated by Graphite.

Still thinking through this, not yet ready to merge.

Closing this, as recommended slippage is actually incorrect terminology. Whilst this PR does what it intended to do, we don't actually want to consider the amount from the quote API in the limit because, after checking with THORChain devs, this amount is already included in the expected_amount_out that we get back from the response.
@gomesalexandre FYI, and thank you for your stellar review 🙏


Allow splitting of the initial states

closing, i think this is a dup of https://github.com/JuliaReach/NeuralNetworkAnalysis.jl/issues/183


Nested KPIs support

Is the system support nested KPIs? for example i have a kpi for measuring number of employees in the organization per type
-Number of employees

Number of employees (Citizen)
Number of employees (Resident)

no support it.


inkscape 0.91

Figured out what was keeping inkscape from compiling in #35—just had to add some flags to make it pick up the system iconv.
If this works then Homebrew/homebrew#37280 can finally move ahead.

:confetti_ball: should this not be merged until after the poppler stuff goes through?

@BrewTestBot test this please

If this passes the bot I'll merge it. We've been trying to bump poppler for 2+ months now, and keep getting hung up. People keep expressing frustrating with the Inkscape failure to build in the mean time, understandably. If we merge this and then a week later it needs revisioning for poppler, so be it.

Massively died on Mountain Lion sadly. Passed the other two bots fine.

Very weird, since it passed when I first opened this PR.

It did indeed. The only major thing I can think that's changed in the mean time is boost. I don't think anything else in the deps list has had a major update.

And GCC 5 instead of 4.9; could that make a difference?

Possibly. I'd be surprised if some formulae were having ML compile problems and we hadn't yet been hit with a :mount_fuji: of issues though. Are there any recent bug reports upstream on gcc compiles?

Doesn't look like it, so that's probably not the issue.

Does this https://bugs.launchpad.net/inkscape/+bug/1293295/comments/5 mean that we should try ENV.cxx11 if MacOS.version >= :mavericks?

Interesting bug comment. Give it a shot, see what happens. You may need to change the needs line as well.

Yeah, they both needed changing. But it worked!

Merged in https://github.com/Homebrew/homebrew-x11/commit/31c0fb91e7de69808a7af774f49207fe06df8f61. Not 110% certain on the syntax around sometimes mandatory cxx11 but it passed the bot and we can push minor fixes to the formula if any become necessary. Thanks for sorting this out @dunn! :trophy: :cake: :fireworks:


Checksum Stream

A stream wrapper that keeps a running calculation of a checksum across the stream. Supports:

Read or write mode
No seek on write
Limited seek on read (elaborated in docstrings)

Added to shared source but not yet pulled into any packages.
Misc. additions:

Stream extensions for calling appropriate sync/async APIs on Stream class
General purpose test tooling

API change check
API changes are not detected in this pull request.


[17.06 backport] libcontainer: ability to compile without kmem

Backport of https://github.com/opencontainers/runc/pull/1921 for 17.06
There was a conflict because https://github.com/opencontainers/runc/pull/1442 is not in the 17.06 branch
I resolved the conflict by;

Cleaning up the conflicts in the "import"
Using EnableKernelMemoryAccounting and setKernelMemory from the 17.06 branch, and copying those to kmem.go;

diff --git a/libcontainer/cgroups/fs/kmem.go b/libcontainer/cgroups/fs/kmem.go
index 8df73777..4d10ace2 100644
--- a/libcontainer/cgroups/fs/kmem.go
+++ b/libcontainer/cgroups/fs/kmem.go
@@ -11,7 +11,6 @@ import (
        "syscall" // for Errno type only

        "github.com/opencontainers/runc/libcontainer/cgroups"
-       "golang.org/x/sys/unix"
 )

 const cgroupKernelMemoryLimit = "memory.kmem.limit_in_bytes"
@@ -44,7 +43,7 @@ func setKernelMemory(path string, kernelMemoryLimit int64) error {
                // once tasks have been attached to the cgroup
                if pathErr, ok := err.(*os.PathError); ok {
                        if errNo, ok := pathErr.Err.(syscall.Errno); ok {
-                               if errNo == unix.EBUSY {
+                               if errNo == syscall.EBUSY {
                                        return fmt.Errorf("failed to set %s, because either tasks have already joined this cgroup or it has children", cgroupKernelMemoryLimit)
                                }
                        }

The conflict before resolution is below:

diff --cc libcontainer/cgroups/fs/memory.go
index 68f40a9b,d5310d56..00000000
--- a/libcontainer/cgroups/fs/memory.go
+++ b/libcontainer/cgroups/fs/memory.go
@@@ -10,7 -9,6 +9,10 @@@ import
        "path/filepath"
        "strconv"
        "strings"
++<<<<<<< HEAD
 +      "syscall"
++=======
++>>>>>>> 6a2c1559... libcontainer: ability to compile without kmem

        "github.com/opencontainers/runc/libcontainer/cgroups"
        "github.com/opencontainers/runc/libcontainer/configs"
@@@ -65,44 -62,6 +66,47 @@@ func (s *MemoryGroup) Apply(d *cgroupDa
        return nil
  }

++<<<<<<< HEAD
 +func EnableKernelMemoryAccounting(path string) error {
 +      // Check if kernel memory is enabled
 +      // We have to limit the kernel memory here as it won't be accounted at all
 +      // until a limit is set on the cgroup and limit cannot be set once the
 +      // cgroup has children, or if there are already tasks in the cgroup.
 +      for _, i := range []int64{1, -1} {
 +              if err := setKernelMemory(path, i); err != nil {
 +                      return err
 +              }
 +      }
 +      return nil
 +}
 +
 +func setKernelMemory(path string, kernelMemoryLimit int64) error {
 +      if path == "" {
 +              return fmt.Errorf("no such directory for %s", cgroupKernelMemoryLimit)
 +      }
 +      if !cgroups.PathExists(filepath.Join(path, cgroupKernelMemoryLimit)) {
 +              // kernel memory is not enabled on the system so we should do nothing
 +              return nil
 +      }
 +      if err := ioutil.WriteFile(filepath.Join(path, cgroupKernelMemoryLimit), []byte(strconv.FormatInt(kernelMemoryLimit, 10)), 0700); err != nil {
 +              // Check if the error number returned by the syscall is "EBUSY"
 +              // The EBUSY signal is returned on attempts to write to the
 +              // memory.kmem.limit_in_bytes file if the cgroup has children or
 +              // once tasks have been attached to the cgroup
 +              if pathErr, ok := err.(*os.PathError); ok {
 +                      if errNo, ok := pathErr.Err.(syscall.Errno); ok {
 +                              if errNo == syscall.EBUSY {
 +                                      return fmt.Errorf("failed to set %s, because either tasks have already joined this cgroup or it has children", cgroupKernelMemoryLimit)
 +                              }
 +                      }
 +              }
 +              return fmt.Errorf("failed to write %v to %v: %v", kernelMemoryLimit, cgroupKernelMemoryLimit, err)
 +      }
 +      return nil
 +}
 +
++=======
++>>>>>>> 6a2c1559... libcontainer: ability to compile without kmem
  func setMemoryAndSwap(path string, cgroup *configs.Cgroup) error {
        // If the memory update is set to -1 we should also
        // set swap to -1, it means unlimited memory.

Commit fe898e7862f94 (PR #1350) enables kernel memory accounting
for all cgroups created by libcontainer -- even if kmem limit is
not configured.
Kernel memory accounting is known to be broken in some kernels,
specifically the ones from RHEL7 (including RHEL 7.5). Those
kernels do not support kernel memory reclaim, and are prone to
oopses. Unconditionally enabling kmem acct on such kernels lead
to bugs, such as

https://github.com/opencontainers/runc/issues/1725
https://github.com/kubernetes/kubernetes/issues/61937
https://github.com/moby/moby/issues/29638

This commit gives a way to compile runc without kernel memory setting
support. To do so, use something like
make BUILDTAGS="seccomp nokmem"

ping @kolyshkin @crosbymichael PTAL

LGTM


Why are the weights so big? ISTD_model_latest.pth (131M)

According to the paper table, the parameters number of ShadowFormer is only 2.4M.  Why is the weight file provided so large?

ShadowFormer has two versions. I only released the large one first. And the released version would be slightly larger than the Ours-Large, but the performance would also be better than the results reported in the paper.
I will release the whole version as soon as possible. Thanks for your interest.

The released version has around 11M parameters.

Still confused. If saved as FP32 format, the weights may be 11M*4=44MB. Why 131MB?

You can try to calculate the number of model_restoration.parameters().

发件人: igodogi @.>
发送时间: 2023年3月13日 16:19
收件人: GuoLanqing/ShadowFormer @.>
抄送: #GUO LANQING# @.>; Comment @.>
主题: Re: [GuoLanqing/ShadowFormer] Why are the weights so big? ISTD_model_latest.pth (131M) (Issue #14)
Still confused. If saved as FP32 format, the weights may be 11M*4=44MB. Why 131MB?
―
Reply to this email directly, view it on GitHubhttps://github.com/GuoLanqing/ShadowFormer/issues/14#issuecomment-1465695088, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJOVWJ2JX35UWETDTRJLOHLW33KBFANCNFSM6AAAAAAVYQFSDY.
You are receiving this because you commented.Message ID: @.***>

OK. I find your *.pth inculding the 'optimizer', so it is two times bigger. Actually it is 44MB just for weights.


Hub: More descriptive copy for editing a profile

Feature
Connected user exploring the Hub's Profile feature
Expected outcome
As a user who is connected to Hub and exploring the Profile feature, I'd expect to know how to edit my Profile and what the process is to do so.
Actual outcome
Currently we are leveraging Ceramic and self.id for Profile updates, which makes a lot of sense given that our profiles themselves pull from Ceramic, but having the Edit link say "Edit SELF_ID" may be confusing for a user. If they're unaware of what SELF_ID is they may not know that this is how they'd edit their profile, and if they do click on it and go to a separate site (self.id) they may not expect this behavior and wonder if it's legitimate.
Additionally, if we change this to something like "Edit Profile on self.id" we can potentially change the other item to "View Public Profile"
Browser
Brave
Screenshots and context

Edit Profile on self.id
View Public Profile

Do we need to change the link and text to edit on Lens Protocol?
https://www.lensfrens.xyz/

It looks like this change has already been made in Profile.tsx

Changed:
<StyledParMd>View Public</StyledParMd>
To:
<StyledParMd>View Public Profile</StyledParMd>

Added:
linkType="external"
to Lens Profile link


[BUG]: The decimal field should have a type of number and not string (drizzle-orm/mysql-core)

What version of drizzle-orm are you using?
0.29.4
What version of drizzle-kit are you using?
No response
Describe the Bug
Hello,
I have a column called price with a decimal field type from drizzle-orm/mysql-core. However, the types are considering the price field as a string. Although it appears to be a number when printed using typeof, there seems to be an issue with the Typescript types.
// schema.ts

export const plans = mysqlTable("plans", {
  id: varchar("id", { length: 100 })
    .primaryKey()
    .$default(() => createId(10)),
  name: varchar("name", { length: 255 }).notNull(),
  price: decimal("price").notNull(),
});

Screenshot of the problem:

Screenshot of printed result using typeof:

Expected behavior
The decimal field should have a type of number and not string.
Environment & setup
No response

For those finding a workaround, you can manually specify the type in the schema ($type<number>()). Original answer

It seems like the repository needs urgent refactoring, the code doesn't follow DRY, instead of creating base classes and extending it, there is a lot of copy and paste everywhere.
I tried reading the codebase to help the project, but the code gave me allergies.
Probably some copy/paste while defining the numeric columns caused this. The problem is probably in this line, since it is extending for no reason, "string" instead of "number"
https://github.com/drizzle-team/drizzle-orm/blob/main/drizzle-orm/src/pg-core/columns/numeric.ts

I can understand why it is like this.
By passing the value as a string, precision will be maintained, as javascript does not support decimal.
I made a PR to fix it, but I have closed it, since it is okay.
This issue should be closed.

By passing the value as a string, precision will be maintained, as javascript does not support decimal.

This makes sense, but a clear explanation should be added to the documentation. Most people using numeric(..) in their schemas expect to get a number type. They will go to the documentation when they get a string instead, so the reason should be clarified. That way, they won't have to waste time looking into closed GitHub issues 😉


Use of functions append or prepend with a table raises an error

When trying to use either the append or prepend functions with a table I get an error in the overwrite function.
Information:
NeoVim Version: v0.5.1
OS: Windows 10
How to duplicate:
local theme = require('lush_themes.theme')
local lushwright = require('shipwright.transform.lush')

run(theme,
    lushwright.to_vimscript,
    lushwright.vim_compatible_vimscript,
    -- the error is the same with prepend
    -- {prepend, {"set background=dark"},
    {append, {"set background=dark"},
    {overwrite, "colors/theme"}
)

Run: :Shipwright
Result:
E5108: Error executing lua ...\site\pack\paqs\start\shipwright.nvim\lua\shipwright.lua:18: ...t\shipwright.nvim\lua\shipwright\transform\overwrite.lua:10: attempt to concatenate local 'line' (a table value)
It's seems ok if I only use it with a string and not a table.

Thanks, the tests were using the wrong assert so the bug wasn't caught.


PayU integration

Suggestion for https://github.com/mirumee/saleor/issues/4908
This pr is discussion purpose only, it's not working/tested solution yet. Just simple architecture concept.

Screenshots

Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] Database migration files are up to date.
[ ] The changes are tested.
[ ] GraphQL schema and type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Hi @Boquete,
Your PR looks very promising 👏 👏 👏.
Could check the saleor/graphql/schema.graphql ? Github treats schema.graphql as a fully changed file which complicates the review and hides new changes in the schema. I assume that this can be connected with the different character at the end of line

@korycins i will take a look why github treated it like that, meanwhile, the only change in schema is line 648, redirect_url inside CheckoutComplete type

@Boquete 👋
The architecture for plugins looks good.
There are two things that we should change:

url - r'^%s/payu-notification/$' % (TOKEN_PATTERN,),
We don't want to have gateway dependencies inside Saleor. The better way would be to create something like - /integrations/<slug:plugin>/, BasePlugin should have a method which ExtensionManager will call inside this view. In that case, each plugin can handle the request on his own, thanks to it - we don't have custom logic in Saleor's URLs, and we have a more customizable approach that can be used by any plugin.
Migration of Payment to Plugin architecture was the first step to extract payment gateways into separate packages. We want to do that for our payment gateways. Thanks to this, the community will have a better possibility to create and share their own payment gateway implementation. So, for now, we don't want to add to Saleor's repository any new payment gateway as we don't have enough resources to maintain it. We are going to create a list (in docs or readme) of all implemented gateways (with URL) which community can use.
You can prepare  PayU gateway on your own and we will append it to the gateways list. Of course, if you need any support we are ready to help you.


htdocs or media directories missing?

Hi Andrew
Am still confused as to how to try this on my server. There does not appear to be a htdocs or media directory in this repo.

After you run ./deploy.sh once the htdocs folder should appear.  The media folder is initially empty so I forgot to check it in.  You can just create an empty folder and change its owner to www-data.


Add new rules for Thrift RPC codes

This PR adds new rules to Thrift. It adds more tests in sample.thrift. It also separates thrift demos from other demos.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: use ryu/itoa to cast num to text

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Use https://github.com/dtolnay/itoa and https://github.com/dtolnay/ryu to do num -> text cast.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Ref to https://github.com/risingwavelabs/risingwave/issues/1431
For https://github.com/risingwavelabs/risingwave/issues/6412, after this pr, still not exactly the same as pg.
For example,
pg: 1.2345678901234e+20_f32 -> 1.2345679e+20
ryu: 1.2345678901234e+20_f32 -> 1.2345679e20
pg: 1 -> 1
ryu: 1 -> 1.0

And also Infinity, but I have handled it.
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
https://github.com/risingwavelabs/risingwave/issues/1431

Because ryu: 1 -> 1.0, the pr will fail on some e2e test.  Could I fix all the test file and make float number without decimal places to have .0?  @xiangjinwu wdyt?

Thanks for your help on this issue.

Because ryu: 1 -> 1.0, the pr will fail on some e2e test. Could I fix all the failed test and make float number without decimal places to have .0? @xiangjinwu wdyt?

It seems the ryu crate is not flexible enough to allow us to match PostgreSQL. Maybe the internals exposed by ryu_floating_decimal could be helpful. I also found that PostgreSQL switches to scientific notation at different value from the ryu crate:

input
PostgreSQL
ryu crate

1e5::float4
100000
100000.0

1e6::float4
1e+06
1000000.0

1e12::float4
1e+12
1000000000000.0

1e13::float4
1e+13
1e13

1e14::float8
100000000000000
100000000000000.0

Given the goal of diverging from rust std's ToString/Display is to match PostgreSQL, it feels awkward to stay at a position that adds some complexity but still requires modification to test files. But feel free to justify it if the required test modifications are much less than before.

Thanks for your help on this issue.

Because ryu: 1 -> 1.0, the pr will fail on some e2e test. Could I fix all the failed test and make float number without decimal places to have .0? @xiangjinwu wdyt?

It seems the ryu crate is not flexible enough to allow us to match PostgreSQL. Maybe the internals exposed by ryu_floating_decimal could be helpful. I also found that PostgreSQL switches to scientific notation at different value from the ryu crate:
input	PostgreSQL	ryu crate
1e5::float4	100000	100000.0
1e6::float4	1e+06	1000000.0
1e12::float4	1e+12<PHONE_NUMBER>000.0
1e13::float4	1e+13	1e13
1e14::float8<PHONE_NUMBER>00000<PHONE_NUMBER>00000.0
Given the goal of diverging from rust std's ToString/Display is to match PostgreSQL, it feels awkward to stay at a position that adds some complexity but still requires modification to test files. But feel free to justify it if the required test modifications are much less than before.

Yeah, I agree with you. If ryu can not bring other benefits, it's not necessary to use it.

@xiangjinwu I fix some special cases. And it can pass the ci.
As I knew, only this case is not compatible with pg.

input
PostgreSQL
ryu crate

1e6::float4
1e+06
1000000.0

I fixed some special cases by string operation.
And fix a test file which is inconsistent with pg.

Thanks for the update. Could you also attempt enabling some test cases that were commented out in #6410 due to the formatting differences?
For instructions on running these tests: https://github.com/risingwavelabs/risingwave/tree/main/src/tests/regress

Have enabled more regress tests.


Extending Video Metadata hub Generator to NewsML-G2

We now have an updated version that creates NewsML-G2 and also exiftool-compliant JSON which enters the metadata into the XMP of the video.
https://www.iptc.org/std-dev/videometadata/generator/


modules: hal_silabs: Move CMake and Kconfig to the main tree

Move the CMakeLists.txt and Kconfig files from the hal_silabs tree under modules/hal_silabs in the main tree. This also includes all Zephyr shim code from the hal_silabs tree.

Note, this is using simplicity_sdk/CMakeList.txt as it was before https://github.com/zephyrproject-rtos/hal_silabs/pull/73 was merged into the HAL tree. That means that the respective changes need to be moved into #79415 (assuming this PR gets merged first).

Now updated with the final hal_silabs commit id in west.yml

This was superseded by #79415 (which already got merged), so closing here.


xPowerPlan: Trying to use it on Windows 10 fails with no Activate method error

Please, observe the following code:
$Name = "High Performance"
$getCimInstanceArguments = @{
    Name   = 'root\cimv2\power'
    Class  = 'Win32_PowerPlan'
    Filter = "ElementName = '$Name'"
}
$plan = Get-CimInstance @getCimInstanceArguments
$plan | Invoke-CimMethod -MethodName Activate

It works on Windows Server 2012, but fails with no Activate method when ran on Windows 10. Amazingly it works on Windows 8.
Hence the xPowerPlan resource cannot be used on Windows 10.

I can confirm.
However, the problem is not with PowerShell. Somewhere between 1703 to 1709, the Win32_PowerPlan class's "Activate" method was broken. It seemed to coincide with the new "Windows performance power slider" feature.

As per previous comment I will label this as 'bug' and 'external'.

I have same issue in Windows Server 1803.


IP static or dynamic

Hi,
One of our customers is asking whether the ip behind https://go.netlicensing.io/core/v2/rest is static or dynamic so they know if they should apply one rule to their firewall or not.
Could you please let me know?
Thanks in advance
Migue Godoy
Power Electronics

Hello @migueGodoy
Similar question was replied here already: Firewall: whitelist Netlicensing Services IP address(-es) #44


Fix Series name after binary operations.

Fix Series name after binary operations.
When binary operations, if the name of the second operand is different from the first one, the name of the result Series becomes None.
>>> pd.Series([1, 2, 3], name="x") + pd.Series([1, 2, 3], name="x")
0    2
1    4
2    6
Name: x, dtype: int64
>>> pd.Series([1, 2, 3], name="x") + pd.Series([1, 2, 3])
0    2
1    4
2    6
dtype: int64
>>> pd.Series([1, 2, 3], name="x") + pd.Series([1, 2, 3], name="y")
0    2
1    4
2    6
dtype: int64
>>> pd.Series([1, 2, 3]) + pd.Series([1, 2, 3])
0    2
1    4
2    6
dtype: int64
>>> pd.Series([1, 2, 3]) + pd.Series([1, 2, 3], name="x")
0    2
1    4
2    6
dtype: int64

Nice 👍


Remove rustc-serialize, use hex

Uhh... Looks like @savil beat me to it... By 1 hr...
@savil Are you on IRC?


SARS-Cov-2 Spike glycosylations needed from UniMod

Hello,
in order to be able to curate SARS-Cov-2 the Reactome team is in need of the following PTMs in PSI-MOD. Can you please import them?

dHex(1)Hex(4)HexNAc(5) --- UNIMOD:1519
dHex(2)Hex(4)HexNAc(5) --- UNIMOD:1785
dHex(1)Hex(5)HexNAc(5) --- UNIMOD:1555
dHex(1)Hex(5)HexNAc(3) --- UNIMOD:1484
dHex(1)Hex(3)HexNAc(6) --- UNIMOD:1781
dHex(1)Hex(6)HexNAc(3) --- UNIMOD:1509
Hex(9)HexNAc(2) --- UNIMOD:1531
Hex(7)HexNAc(2) --- UNIMOD:1480

These are all children of complex glycosylation MOD:00725

Hi, Sorry for missing this! Yes.  I can add these new terms.


[1.18.2] Creative Wand is not adjustable in config

You can adjust Stone, Iron, Diamond and Netherite Wands in config, but not creative wands.
(There's no "Creative wand limit" option in config).

Weird that the constant was "MAX_LIMIT" when you could just crank up values way above 512 and they worked flawlessly. But very happy to hear that!


Views in new ladybug gui do not work as expected

The new and old interface show different checkpoints when changing the views (white/gray/blackbox).

I believe this issue has been solved in an update somewhere the past year, can you confirm @nielsm5 ?

I believe this issue has been solved in an update somewhere the past year, can you confirm @nielsm5 ?

Confirmed it's not been solved yet.


Can't open multibit.wallet

Operating System : Windows 7 Ultimate SP1 64bit
MultiBit Version : 0.5.18
Steps to replicate the problem :
Dear !
Yesterday, i have create 2 wallet and many bitcoin address in wallet.
After that, i exit MultiBit Software and shutdown my computer.
But today, when i open MultiBit Software. MultiBit not automatic open my wallet.
I try open my "Wallet 1" with path : C:\Users\xxxxxx\AppData\Roaming\MultiBit\abc.wallet. It's OK.
But i open my "Wallet 2" with path : C:\Users\xxxxxx\AppData\Roaming\MultiBit\multibit.wallet. I wait about 30 minutes, not open my wallet.
I have check in message tab, but not show. I have attach images with message.

Please help me.

The message tab reads that it opened the multibit.wallet successfully. Please clarify if you still have a problem.

Closing due to inactivity.


Add Sentry for error reporting

I've created an account for Rich, and this adds error reporting for prod/staging to the rails app

Bleh, I merged it the other way to what I thought, so this is the PR for staging and sentry now :)


What is the conceptual difference between Item and Value

Hi!
Trying to grok this library and I have a difficult time trying to figure out what the conceptual difference is between Item and Value. At first I thought Item is only top-level parts of the toml file.
But after seeing that
let doc = Document::new();
let bar = doc["foo"]["bar"];

Also returns an Item, I dont expect this to be true. Anyone able to clarify the distinction?

An Item is a superset of Value that also includes Table and ArrayOfTables
So from your example
[foo.bar]

foo is an Item that is a Table that points to `bar which is an Item that is a Table

Closing this as it seems to be explained.


.github/workflows: add rebase-staging.yml

This allows committers to rebase PRs to staging without CODEOWNER notification spam or running git commands manually.
cc @FRidh @jonringer @zimbatm

How do we trigger it?

You need to comment /rebase-staging. This best be explicitly mentioned in the action, along with a motivation for it.

How can this be documented so that people know about its existence? (maybe update the PR template?)

I don't think that this needs to be documented on the PR template or anywhere else really, it's a committers only tool.

I'm not sure that it would work for third-party contributors.

I don't understand what you mean?

How can this be documented so that people know about its existence? (maybe update the PR template?)

I don't think that this needs to be documented on the PR template or anywhere else really, it's a committers only tool.

I'm not sure that it would work for third-party contributors.

I don't understand what you mean?

I think only maintainers needs to be aware of this as they demand branch switches most of the time. I think we had something in the nixpkgs manual regarding staging though.

I think we had something in the nixpkgs manual for rebasing.

Nothing that covers changing base branches. Also I don't think the nixpkgs manual would be good place for this, maybe a separate doc that can be linked from the README and/or .github/CONTRIBUTING.md that can consolidates the existing CI/staging mentions we have there and can also cover github specific stuff like actions?

Seems to work but I've noticed what may be a problem.
The actions that run in pull requests (editorconfig, wait-for-ofborg) seem to be skipped when the PR is pushed to by another action. IIRC this is done intentionally by github.
Actions in staging-next PRs also seem to skipped when the pushes are from the merge-staging sync.

@SuperSandro2000 The action will now add a 👀 to the comment that initiated it.

The proper workaround for allowing actions to trigger other actions seems to be running the first action from another account/token so we would need to add one from somewhere to the repo secrets.
If we don't want to fuss with that (at least for now) we could do this:
diff --git a/.github/workflows/rebase-staging.yml b/.github/workflows/rebase-staging.yml
index<PHONE_NUMBER>e..2758675b250 100644
--- a/.github/workflows/rebase-staging.yml
+++ b/.github/workflows/rebase-staging.yml
@@ -48,6 +48,17 @@ jobs:
             -H "Authorization: token $GITHUB_TOKEN" \
             -d '{ "base": "staging" }' \
             "https://api.github.com/repos/NixOS/nixpkgs/pulls/$PULL_REQUEST"
+          curl \
+            -X PATCH \
+            -H "Accept: application/vnd.github.v3+json" \
+            -H "Authorization: token $GITHUB_TOKEN" \
+            -d '{ "state": "closed" }' \
+            "https://api.github.com/repos/NixOS/nixpkgs/pulls/$PULL_REQUEST"
+      - uses: peter-evans/create-or-update-comment@v1
+        with:
+          issue-number: ${{ github.event.issue.number }}
+          body: |
+            Rebased, please reopen the pull request.
       - uses: peter-evans/create-or-update-comment@v1
         if: ${{ failure() }}
         with:

@SuperSandro2000 The action will now add a 👀 to the comment that initiated it.

The proper workaround for allowing actions to trigger other actions seems to be running the first action from another account/token so we would need to add one from somewhere to the repo secrets.
If we don't want to fuss with that (at least for now) we could do this:
diff --git a/.github/workflows/rebase-staging.yml b/.github/workflows/rebase-staging.yml
index<PHONE_NUMBER>e..2758675b250 100644
--- a/.github/workflows/rebase-staging.yml
+++ b/.github/workflows/rebase-staging.yml
@@ -48,6 +48,17 @@ jobs:
             -H "Authorization: token $GITHUB_TOKEN" \
             -d '{ "base": "staging" }' \
             "https://api.github.com/repos/NixOS/nixpkgs/pulls/$PULL_REQUEST"
+          curl \
+            -X PATCH \
+            -H "Accept: application/vnd.github.v3+json" \
+            -H "Authorization: token $GITHUB_TOKEN" \
+            -d '{ "state": "closed" }' \
+            "https://api.github.com/repos/NixOS/nixpkgs/pulls/$PULL_REQUEST"
+      - uses: peter-evans/create-or-update-comment@v1
+        with:
+          issue-number: ${{ github.event.issue.number }}
+          body: |
+            Rebased, please reopen the pull request.
       - uses: peter-evans/create-or-update-comment@v1
         if: ${{ failure() }}
         with:

Updated version with a fix for running other actions, also allows rebasing PRs onto other branches: #110843

Updated version with a fix for running other actions, also allows rebasing PRs onto other branches: #110843

PR to remove: https://github.com/NixOS/nixpkgs/pull/126192


Makefile: mkdir -p bin before downloading operator-sdk

/cherry-pick oadp-1.1
/cherry-pick oadp-1.0

/retest

/retest

/retest

Codecov Report
Base: 32.88% // Head: 32.88% // No change to project coverage :thumbsup:

Coverage data is based on head (0831d04) compared to base (0275e28).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #861   +/-   ##
=======================================
  Coverage   32.88%   32.88%
=======================================
  Files          17       17
  Lines        3214     3214
=======================================
  Hits         1057     1057
  Misses       2065     2065
  Partials       92       92

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/LGTM


[FEATURE] [GUI] Optimize upgrade image preloading

Is your feature request related to a problem? Please describe.

Original Request https://github.com/harvester/harvester/issues/3059
Currently, the image preloading will happen in NODEs one by one, for massive-node cluster, it takes long time.
Describe the solution you'd like

Preload image to nodes in parallel.
Or allow user to set up an image registry outside of cluster, images will be fetched on demand.
Also consider to allow user to select  one-by-one, multi-in-parallel, fetch-on-demand-from-registry mode.
Describe alternatives you've considered

Additional context

@torchiaf we have the automatically created issue https://github.com/harvester/harvester/issues/6045
I copy the description to that one and closed this one.


Bottom sheet does not update state when keyboard is closed.

Sometimes when the keyboard gets closed, the sheet remains on top of the screen like the image below:

Hi, Are you using the latest library version? Can you provide a code snippet to reproduce this bug?

This is my bottom sheet composable:
`@Composable
fun Bit24ProBottomSheet(
modifier: Modifier = Modifier,
bottomSheetState: BottomSheetState = rememberBottomSheetState(),
onDismiss: () -> Unit = {},
skipPeeked: Boolean = true,
dimColor: Color = Color.Black,
peekHeight: PeekHeight = PeekHeight.px(0),
isFullScreen: Boolean = false,
content: @Composable () -> Unit
) {
val configuration = LocalConfiguration.current

LaunchedEffect(key1 = bottomSheetState.value) {
    if (!bottomSheetState.visible) onDismiss()
}

BottomSheet(
    modifier = modifier
        .imePadding()
        .then(if (isFullScreen) Modifier else Modifier.heightIn(max = configuration.screenHeightDp.dp - dimens.standard80)),
    shape = RoundedCornerShape(topStart = dimens.standard16, topEnd = dimens.standard16),
    dragHandle = {},
    backgroundColor = newColors.bgBackground,
    state = bottomSheetState,
    skipPeeked = skipPeeked,
    dimColor = dimColor,
    peekHeight = peekHeight,
    behaviors = DialogSheetBehaviors(
        dialogWindowSoftInputMode = WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE
    ),
    content = content
)

}
`
It happens sometimes and not always, suppose that on the image I sent, there is a search textfield on top and after the user typed and the keyboard is dismissed, the bottom sheet stays on top.

Thanks for the information, will check it later when I'm free.

After trying hundreds of times and still not being able to reproduce this bug on both an Android 12 phone and an Android 11 emulator, I suspect that it may be related to imePadding() or the specific device/OS. Could you try applying imePadding() and WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE to a Composable outside of the bottom sheet to verify this?

Suppose that you are on a screen that has a texfield which is focused and the keyboard is open, and there is a button which opens a bottom sheet. when the keyboard is open and textfield is focused, on button click, bottom sheet expands and the keyboard gets closed. This is when this issue happens

Hmm... Tried a lot with the case where the keyboard is open before the sheet is expanded, but I still can't reproduce this issue on my device/emulator, need more time to investigate.


Hermitpack mekanism crashing issue.

Hello I'm running ftb hermitpack 1.1.0 on a server.
I constructed the reactor and maybe I didn't have things setup right because it wasn't creating the amount of power I was expecting but then I decided to just get steam from it well when I did that every time I tried to extract steam it would crash the server.
I still have it built on my server you can contact me if you want to see it yourself I just have the steam disconnected.
Twitter Rarrapuda
Email<EMAIL_ADDRESS>I also attached the crash reports I have a few more also if needed.
crash-2016-11-02_08.50.02-server.txt
crash-2016-11-02_08.49.01-server.txt

remove the multipart that is loaded by deploader and install the latest multipart seems to be the issue here mate

I've updated the modpack and it still crashes I'm now on ftb hermitpack 1.2.1. I'm not sure what the mcmultipart is though

well until mekanism stops using deploader your gonna have to fix it by going into your mods folder then the 1.10 folder delete the mcmultipart and install the latest manually through the launcher,which can be done by going to profile options unlocking the pack and then you should be able to fix the problem :D
only fix i got for you until mekanism removes deploader


Update configurationsetting-method-setdatabaseconnection.md

Correct method name from BackupEncryptionKey to SetDatabaseConnection

@maggiesMSFT
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Court72 This looks good and can be signed off.

Thanks, @rwestMSFT !
#sign-off


SOLR-17357 Improve default --help formatting for CLI Tools (branch_9x)

This will be merged AFTER #2540, as it is backported on top of those changes. It will then replace some of the new code in that PR with what was committed to main.

I want to click the Squash and Merge button, but don't totally understand the target branch, so will hold off!

I want to click the Squash and Merge button, but don't totally understand the target branch, so will hold off!

Moved it to correct branch, thik it is ready. Was expecting bats tests to run after merging #2575 but they did not. Guess we'll need to do some (but not all) bats test adjustments as well for the back port. Not all, since main uses more help output from SolrCLI than branch_9x...

Fingers crossed a good build!   Changes look good.


Allow wildcards at the end of index names for API Keys and Tenant tokens

This PR introduces the wildcards at the end of the index names when identifying indexes in the API Keys and tenant tokens. It fixes #2788 and fixes #2908. This PR is based on @akhildevelops' work.
Note that when a tenant token filter is chosen to restrict a search, it is always the most restrictive pattern that is chosen. If we have an index pattern prod* that defines filter1 and p* that defines filter2, the engine will choose filter1 over filter2 as it is defined for a most restrictive pattern, prod*. This restrictiveness is defined by 1. is it exact, without * 2. the length of the pattern.
It is a continuation of work that has already started and should close #2869.

Hey @ManyTheFish and @irevoire,
Could you review this PR, please? It adds the possibility to specify an API Key and a Tenant Token with a pattern that can optionally end with a *. I advise you to review the first commits first and only the final merge commit at the end.


Duplicate API requests to geocoder API are unnecessarily overloading Varnish

Every time a table's rows are fetched, the API request is sent twice from the front end.
It can be reproduced on any dataset. I'm not sure it's just the rows call.

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Error: unknown signer and ConstraintSeeds

This is my accounts
#[derive(Accounts, Clone)]
pub struct RaydiumDeposit<'info> {
    /// CHECK: Safe
    pub amm_program: UncheckedAccount<'info>,
    /// CHECK: Safe. Amm Account
    #[account(mut)]
    pub amm: UncheckedAccount<'info>,
    /// CHECK: Safe. Amm authority, a PDA create with seed = [b"amm authority"]
    #[account()]
    pub amm_authority: UncheckedAccount<'info>,
    /// CHECK: Safe. AMM open_orders Account.
    #[account()]
    pub amm_open_orders: UncheckedAccount<'info>,
    /// CHECK: Safe. AMM target orders account. To store plan orders infomations.
    #[account(mut)]
    pub amm_target_orders: UncheckedAccount<'info>,
    /// CHECK: Safe. LP mint account. Must be empty, owned by $authority.
    #[account(mut)]
    pub amm_lp_mint: UncheckedAccount<'info>,
    /// CHECK: Safe. amm_coin_vault account, $authority can transfer amount.
    #[account(mut)]
    pub amm_coin_vault: UncheckedAccount<'info>,
    /// CHECK: Safe. amm_pc_vault account, $authority can transfer amount.
    #[account(mut)]
    pub amm_pc_vault: UncheckedAccount<'info>,
    /// CHECK: Safe. OpenBook market account, OpenBook program is the owner.
    pub market: UncheckedAccount<'info>,
    /// CHECK: Safe. OpenBook market event queue account, OpenBook program is the owner.
    pub market_event_queue: UncheckedAccount<'info>,
    /// CHECK: Safe. User token coin to deposit into.
    #[account(mut)]
    pub user_token_coin: UncheckedAccount<'info>,
    /// CHECK: Safe. User token pc to deposit into.
    #[account(mut)]
    pub user_token_pc: UncheckedAccount<'info>,
    /// CHECK: Safe. User lp token, to deposit the generated tokens, user is the owner
    #[account(mut)]
    pub user_token_lp: UncheckedAccount<'info>,
    /// CHECK: Safe. User wallet account
    #[account(mut)]
    pub user_owner: Signer<'info>,
    #[account(
        mut,
        seeds = [ORBITLEN_ACCOUNT_SEED.as_bytes(), user_owner.key().as_ref()],
        bump,
    )]
    pub orbitlen_account: AccountLoader<'info, OrbitlenAccount>,
    #[account(mut)]
    pub coin_mint: InterfaceAccount<'info, Mint>,
    #[account(
        mut,
        seeds = [BANK_SEED.as_bytes(), coin_mint.key().as_ref()],
        bump
    )]
    pub coin_bank: AccountLoader<'info, Bank>,
    /// CHECK: Seed constraint check
    #[account(
        mut,
        seeds = [
            LIQUIDITY_VAULT_SEED.as_bytes(),
            coin_bank.key().as_ref(),
        ],
        bump = coin_bank.load()?.liquidity_vault_bump,
    )]
    pub coin_bank_liquidity_vault: Box<InterfaceAccount<'info, TokenAccount>>,
    /// CHECK: Seed constraint check

    #[account(
        mut,
        seeds = [
            LIQUIDITY_VAULT_AUTHORITY_SEED.as_bytes(),
            coin_bank.key().as_ref(),
        ],
        bump = coin_bank.load()?.liquidity_vault_authority_bump,
    )]
    pub coin_bank_liquidity_vault_authority: AccountInfo<'info>,
    /// CHECK: Safe. The spl token program
    pub token_program: Program<'info, Token>,
}

question 1: when I call it on TS client, get error Error: unknown signer: 51X3SJJXPgQQtAWXq8juDVcFdauuo9tNs3Ux5dLpBunY . the address is pubkey of userA. I don't understand why it is unknown, it is working on other instructions calling.
let tx = await program.methods
      .raydiumDeposit(
        new anchor.BN(depositAmount), // maxCoinAmount
        new anchor.BN(depositAmount) // maxPcAmount
      )
      .accounts({
        ammProgram: globalInfo.ammProgram,
        amm: globalInfo.ammId,
        ammAuthority: globalInfo.ammAuthority,
        ammOpenOrders: globalInfo.ammOpenOrders,
        ammTargetOrders: globalInfo.ammTargetOrders,
        ammLpMint: globalInfo.lpMint,
        ammCoinVault: globalInfo.coinVault,
        ammPcVault: globalInfo.pcVault,
        market: globalInfo.marketId,
        marketEventQueue: globalInfo.eventQueue,
        userTokenCoin: userARay,
        userTokenPc: userAUSDC,
        userTokenLp: userALP,
        userOwner: userA,
        orbitlenAccount: userAOrbitlenAccount,
        coinMint: globalInfo.coinMint,
        coinBank: RayBank,
        coinBankLiquidityVault: RayLiquidityVault,
        coinBankLiquidityVaultAuthority: RayLiquidityVaultAuthority,
        tokenProgram: TOKEN_PROGRAM_ID,
      })
      .signers([userA])
      .rpc();

quesion 2: when I remove the signers([userA]) on call code. also get error.
     Error: AnchorError caused by account: orbitlen_account. Error Code: ConstraintSeeds. Error Number: 2006. Error Message: A seeds constraint was violated.
Program log: Left:
Program log: 3xzX68XsuExNHRFjaLAotURTkjztPjuYYmLZbkLUJjq5
Program log: Right:
Program log: 6bWKwmUuV7t5pehqtgGhXNL7f7UQdNUTRxGjyWTsdoY5

The left is my orbitlen_account pubkey, which was working on other instructions. I have checked the seeds produced, not any difference with other call codes.
That is my  test client generated code about orbitlen_account :
[userAOrbitlenAccount] = PublicKey.findProgramAddressSync(
      [Buffer.from("orbitlen_account"), userA.publicKey.toBuffer()],
      program.programId
    );

Also, I have this problem, but the orbitlen_account exists in the program file.
{
      "name": "raydiumDeposit",
      "discriminator": [
        141,
        156,
        209,
        92,
        8,
        26,
        30,
        79
      ],
      "accounts": [
        {
          "name": "ammProgram"
        },
        {
          "name": "amm",
          "writable": true
        },
        {
          "name": "ammAuthority"
        },
        {
          "name": "ammOpenOrders"
        },
        {
          "name": "ammTargetOrders",
          "writable": true
        },
        {
          "name": "ammLpMint",
          "writable": true
        },
        {
          "name": "ammCoinVault",
          "writable": true
        },
        {
          "name": "ammPcVault",
          "writable": true
        },
        {
          "name": "market"
        },
        {
          "name": "marketEventQueue"
        },
        {
          "name": "userTokenCoin",
          "writable": true
        },
        {
          "name": "userTokenPc",
          "writable": true
        },
        {
          "name": "userTokenLp",
          "writable": true
        },
        {
          "name": "userOwner",
          "writable": true,
          "signer": true
        },
        {
          "name": "orbitlenAccount",
          "writable": true,
          "pda": {
            "seeds": [
              {
                "kind": "const",
                "value": [
                  111,
                  114,
                  98,
                  105,
                  116,
                  108,
                  101,
                  110,
                  95,
                  97,
                  99,
                  99,
                  111,
                  117,
                  110,
                  116
                ]
              },
              {
                "kind": "account",
                "path": "userOwner"
              }
            ]
          }
        },

Also, I have this problem, but the orbitlen_account exists in the program file.

That account is resolved automatically, see https://www.anchor-lang.com/release-notes/0.30.0#account-resolution

question1: change to userOwner: userA.publicKey


Running unit tests under root fails

Running unit tests under root fails the utils.file_exists_and_ownedby_root test:
# tests/bpftrace_test --gtest_filter="utils.file_exists_and_ownedby_root"
Note: Google Test filter = utils.file_exists_and_ownedby_root
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from utils
[ RUN      ] utils.file_exists_and_ownedby_root
/home/vmalik/src/bpf/bpftrace/tests/utils.cpp:375: Failure
Value of: file_exists_and_ownedby_root((tmpdir + file1).c_str())
  Actual: true
Expected: false
[  FAILED  ] utils.file_exists_and_ownedby_root (0 ms)
[----------] 1 test from utils (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (0 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] utils.file_exists_and_ownedby_root

 1 FAILED TEST

The reason is that the test expects files created by a non-root user.
I'm used to run all the tests under the root so that's how I discovered this problem. I'm not sure if that's the expected workflow, though.

The problematic test has been removed so this is no longer relevant.


fix(pool): ensure proper lock handling in retrieveWorker

Correct the logic for locking the pool in the retrieveWorker function to prevent potential data races and deadlocks. The lock is now deferred until the end of the function, with conditional early unlocks removed. This change simplifies the lock handling and improves the code's readability and correctness.

1. Are you opening this pull request for bug-fixs, optimizations or new feature?
2. Please describe how these code changes achieve your intention.

3. Please link to the relevant issues (if any).

4. Which documentation changes (if any) need to be made/updated because of this PR?

4. Checklist

[ ] I have squashed all insignificant commits.
[ ] I have commented my code for explaining package types, values, functions, and non-obvious lines.
[ ] I have written unit tests and verified that all tests passes (if needed).
[ ] I have documented feature info on the README (only when this PR is adding a new feature).
[ ] (optional) I am willing to help maintain this change if there are issues with it later.

Does this PR fix any actual issues?


Issue assignments

Things to note during review:

opendatahub-io is a good view of this graph (or any repo(s) that consistently do assignments)
We should consider before turning this query into a materialized view if we want to join on the contributors table to have the login info available off the bat for viewing on a local/private instance
the conversation on pages will definitely move the location of the graph. This location is temporary until we have a good home for it. I have a few visualizations that are close to done and once those are in lets discuss new page break downs

@JamesKunstle Fixed code to make it where the values are how many issues are assigned or unassigned


2671 update service name on static page

Context
Service name
Changes proposed in this pull request
Update service name on static pages
Guidance to review
🚢
Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

 Cookie page should just refer to Publish teacher training courses in content


\pattern size is hardcoded

\pattern calls \proof like so:
SILE.Commands["proof"]({size=10,type="pattern"}, {para})

What if I want a bigger hobonop?

This is long since fixed, the \pattern command passes it's size option to \proof.


DSL doesn't filter status codes.

Katana does not filter status codes as the usage reads. This is apparent with all sites I have tested. Katana is on the latest version.
~# katana -u http://testphp.vulnweb.com -jc -jsl -kf all -aff -fx -ps -mdc 'status_code == 200' -silent |httpx -silent -sc
http://testphp.vulnweb.com/ajax/infoartist.php?id=-7472 [404]
http://testphp.vulnweb.com/ajax/infoartist.php?id=-5162 [404]
http://testphp.vulnweb.com/admin/ [200]

~# katana -u http://testphp.vulnweb.com -jc -jsl -kf all -aff -fx -ps -fdc 'status_code == 404' -silent |httpx -silent -sc
http://testphp.vulnweb.com/.well-known/ai-plugin.json [404]
http://testphp.vulnweb.com/ajax/infoartist.php?id=-2232 [404]
http://testphp.vulnweb.com/ajax/index.phpuser-agent: [404]
http://testphp.vulnweb.com/ajax/infoartist.php?id=-1484 [404]
http://testphp.vulnweb.com/ajax/infoartist.php?id=-2230 [404]
http://testphp.vulnweb.com/ajax/categories.php [404]
http://testphp.vulnweb.com/acunetix_file/////// [404]

From my limited debugging, it appears this issue manifests itself with the use of the -ps flag.

@nullenc0de you are using passive crawl mode which can't have actual status code, as of now output include a placeholder value to make it resuable to process the output file as input for other integration but it does not include actual status code in passive mode.

Closing, this is by design.


Terrascript - Implement noise functions

Title is fairly explanatory, allow noise functions to be used within terrascript

How should this handle biome-specific noise functions (#81)? The 2 ways I can think of are:

Switch over between biomes.
Only support global (pack-defined) functions.

Both approaches have advantages/disadvantages.


BENCH: Simplify expression of solvers to facilitate expansion

Reference issue

What does this implement/fix?

In this PR, some condition expression is simplified, so it will be more convenient adding new solvers.
Additional information

I am personally "allergic" to eval, but if others are fine with it why not.

Thank you @tupui ‘for your review. Yes, eval is an unsafe function when it comes to those system operations. Because we only parse the params in the class Bench and instead of directly outputting/return eval(solver), it makes a function call.

If you want to avoid the if: elif: chain, then I recommending making a dict mapping the names to the functions.

Ok, dict looks like a good choice, I'll try it. Thanks Robert and Pamphile.

Dear @tupui @rkern , I have updated this PR. Please check it.


ServicePort defined but no ports in services.json

Hi
I add ServicePort and ServiceName labels to a container, but if I look at services.json, ports array is empty (both run as docker services)
Sidecar inspect
[
    {
        "ID": "7h1942z9ka4rnu7lqeiu5hptr",
        "Version": {
            "Index": 67577
        },
        "CreatedAt": "2018-09-09T19:10:59.240514256Z",
        "UpdatedAt": "2018-09-09T20:28:15.048590598Z",
        "Spec": {
            "Name": "sidecar",
            "Labels": {
                "SidecarDiscover": "false"
            },
            "TaskTemplate": {
                "ContainerSpec": {
                    "Image": "gonitro/sidecar:f56be36@sha256:195709bed8256d705f6c0143826401c0c3620bfb580873ddc19c82c77c6c9e40",
                    "Labels": {
                        "SidecarDiscover": "false"
                    },
                    "Env": [
                        "SIDECAR_BIND_PORT=7950",
                        "SIDECAR_SEEDS=<IP_ADDRESS>",
                        "SIDECAR_CLUSTER_NAME=dummy",
                        "HAPROXY_DISABLE=true",
                        "SIDECAR_LOGGING_LEVEL=debug"
                    ],
                    "Mounts": [
                        {
                            "Type": "bind",
                            "Source": "/var/run/docker.sock",
                            "Target": "/var/run/docker.sock"
                        }
                    ],
                    "StopGracePeriod":<PHONE_NUMBER>0,
                    "DNSConfig": {},
                    "Isolation": "default"
                },
                "Resources": {
                    "Limits": {},
                    "Reservations": {}
                },
                "RestartPolicy": {
                    "Condition": "any",
                    "Delay":<PHONE_NUMBER>,
                    "MaxAttempts": 0,
                    "Window": 0
                },
                "Placement": {},
                "ForceUpdate": 5,
                "Runtime": "container"
            },
            "Mode": {
                "Replicated": {
                    "Replicas": 1
                }
            },
            "UpdateConfig": {
                "Parallelism": 1,
                "FailureAction": "pause",
                "Monitor":<PHONE_NUMBER>,
                "MaxFailureRatio": 0,
                "Order": "stop-first"
            },
            "RollbackConfig": {
                "Parallelism": 1,
                "FailureAction": "pause",
                "Monitor":<PHONE_NUMBER>,
                "MaxFailureRatio": 0,
                "Order": "stop-first"
            },
            "Networks": [
                {
                    "Target": "xi51w26iawdz7g1dc7yius6z0" <--- Host network
                }
            ],
            "EndpointSpec": {
                "Mode": "vip"
            }
        },
        "Endpoint": {
            "Spec": {
                "Mode": "vip"
            },
            "VirtualIPs": [
                {
                    "NetworkID": "xi51w26iawdz7g1dc7yius6z0"
                }
            ]
        },
        "UpdateStatus": {
            "State": "completed",
            "StartedAt": "2018-09-09T20:28:05.958923045Z",
            "CompletedAt": "2018-09-09T20:28:15.048560697Z",
            "Message": "update completed"
        }
    }
]

Labels in target container
"Labels": {
                "ServiceName": "wonderful-container",
                "ServicePort_80": "80",

Section of services.json
"wonderful-container": [
      {
        "ID": "a2b92d342697",
        "Name": "wonderful-container",
        "Image": "wonderful-container:latest@sha256:d8a4ce53bca03229e281675413661ebb24359f28c869a748d546c020f6d0b411",
        "Created": "2018-09-09T19:59:59Z",
        "Hostname": "my-host",
        "Ports": [],
        "Updated": "2018-09-09T20:39:42.360835566Z",
        "ProxyMode": "http",
        "Status": 0
      }
    ]

How can fix it?

Can you please confirm that wonderful-container exposes port 80 and that you can successfully send an HTTP request through it? I assume that it will be published on port 80 on the host which is running this container, given that you set "ServicePort_80": "80". If that works, then can you also please attach the log of Sidecar to this issue?

Just to be sure I ran nginx container and the services.json is fill-up correctly
We can close this issue
Thanks


Need to change days background circle style to square style background

Hi,
Thanks for such a nice library!
I need to change days background circle style to square style background, i.e when user selects the day, it should highlight in square style not in circle,and also vertical and horizontal spacing lines with color, for this what i need to do?
PFA attachment of screenshot

Hi, this is similar to #148. Basically, you need to take a fork of the code and modify the code where it draws a letters to draw a rect instead.

Closing this issue as #148 basically describes how to do this.


GEODE-369: wait for primary to be available when going from 0 to 1 server

Co-Authored-By: Bill Burcham<EMAIL_ADDRESS>Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@upthewaterspout @WireBaron @balesh2 @kirklund @pdxrunner Can you take a look at this PR?

@upthewaterspout @kirklund  I have reviewed Kirk's concerns and addressed them I believe. The failure in Build was in an unrelated are of the code.  Please merge if you get the opportunity.


Introduce Purescript Mapping Functions Between Buffer Types

Consider this a sort of RFC... But what are your thoughts on adding to this library functions which translate between various buffer types as well as enable their construction?

An example of me doing a bit of experimental work on this can be viewed here:
https://github.com/purescript-contrib/purescript-arraybuffer-types/compare/master...AlexaDeWit:master
Another thought I am considering is to insteat use purescript-arraybuffer-types as a dependency which I re-export in another more "heavy" purescript-arraybuffer library that provides the other tooling that's likely to be needed by individuals using arraybuffers.

I'd keep this one as is and build on top of it. The original intent was to have an agreed type so that different libraries could share array buffers. This could belong to something like https://github.com/jacereda/purescript-arraybuffer or a library on its own.

Ah, thanks, I had gone looking and not found an appropriate library. I just wanted to sort of see what the feeling was. Makes sense to me!

Functionality has been merged into purescript-arraybuffer.


Bug with scrollGesturesEnabledDuringRotateOrZoom = false and rotationGesturesEnabled = false

android-maps-compose 4.3.0
If rotationGesturesEnabled = false and scrollGesturesEnabledDuringRotateOrZoom = false, a zoom (pinch) gesture with a rotation (or crossing fingers) will break the pan/drag gesture and make it lag. It looks like a CancellationException is swallowed internally (caught but not thrown), see : https://github.com/googlemaps/android-maps-compose/issues/502
Environment details :
android-maps-compose 4.3.0
doesn't seem to occur on the simulator, please use a real device.
Steps to reproduce :

set rotationGesturesEnabled = false and scrollGesturesEnabledDuringRotateOrZoom = false
Try to rotate the map with two fingers
Try to pan.drag the map, it doesn't move as intended (zoom is not affected somehow)

Workaround :

setting rotationGesturesEnabled = false and scrollGesturesEnabledDuringRotateOrZoom = true

Code example :
class RecompositionActivity : ComponentActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)
    setContent {
        val cameraPositionState = rememberCameraPositionState {
            position = defaultCameraPosition
        }
        Box(Modifier.fillMaxSize()) {
            MapsComposeSampleTheme {
                GoogleMapView(
                    modifier = Modifier.matchParentSize(),
                    cameraPositionState = cameraPositionState
                )
            }
        }
    }
}

@Composable
fun GoogleMapView(
    modifier: Modifier = Modifier,
    cameraPositionState: CameraPositionState = rememberCameraPositionState(),
    content: @Composable () -> Unit = {},
) {
    var location by remember { mutableStateOf(singapore) }

    var zoom by remember { mutableStateOf(5f) }

    val context = LocalContext.current
    val singaporeState = MarkerState(position = location)

    val mapProperties = remember {
        MapProperties(
            isBuildingEnabled = false,
            isIndoorEnabled = false,
            isMyLocationEnabled = false,
            isTrafficEnabled = false,
            mapType = MapType.SATELLITE,
        )
    }

    val mapOptions = remember {
        GoogleMapOptions()
            .ambientEnabled(false)
            .mapToolbarEnabled(false)
            .compassEnabled(false)
    }

    val uiSettings = remember {
        MapUiSettings(
            compassEnabled = false,
            indoorLevelPickerEnabled = false,
            mapToolbarEnabled = false,
            myLocationButtonEnabled = false,
            rotationGesturesEnabled = false,
            scrollGesturesEnabledDuringRotateOrZoom = false,
            tiltGesturesEnabled = false,
            zoomControlsEnabled = false,
        )
    }

    val mapVisible by remember { mutableStateOf(true) }
    if (mapVisible) {
        // Detect when the map starts moving and print the reason
        LaunchedEffect(cameraPositionState.isMoving) {
            if (cameraPositionState.isMoving) {
                Log.d(TAG, "Map camera started moving due to ${cameraPositionState.cameraMoveStartedReason.name}")
            }
        }

        GoogleMap(
            modifier = modifier.fillMaxSize(),
            cameraPositionState = cameraPositionState,
            googleMapOptionsFactory = {mapOptions},
            onMapLoaded = {},
            properties = mapProperties,
            uiSettings = uiSettings,
            onPOIClick = {
                Log.d(TAG, "POI clicked: ${it.name}")
            }
        ) {
            val markerClick: (Marker) -> Boolean = {
                Log.d(TAG, "${it.title} was clicked")
                cameraPositionState.projection?.let { projection ->
                    Log.d(TAG, "The current projection is: $projection")
                }
                false
            }

            Marker(
                state = singaporeState,
                title = "Marker in Singapore",
                onClick = markerClick
            )

            content()
        }
    }
}

}

We're also facing this issue


Uncaught TypeError: option expires is invalid

Hi, I am getting this error from the following code I have implemented:
import Cookies from 'universal-cookie';
const cookies = new Cookies();
.....
.....
const d = new Date();
d.setTime(d.getTime() +<PHONE_NUMBER>0));
let expires = d.toUTCString(); // Thu, 05 Apr 2018 11:03:19 GMT
cookies.set('name', "value",
{
expires : expires
}
Can someone tell what is wrong with my code???

@nabinadhikari  Thanks, buddy. You saved my time. :1st_place_medal:


"Blândești" , "Cerchejeni" and "Șoldănești" are listed in the drop-down menu

Description:
"Blândești" , "Cerchejeni" and "Șoldănești" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Blândești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Blândești, Botoșani (Blândești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Cerchejeni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Cerchejeni, Botoșani (Blândești)".

Step 5
Type "Șoldănești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Șoldănești, Botoșani (Blândești)".

ATTENTION:
STEP1:
Request - "Blândești, Botoșani (Blândești)""
In dropbox, the request is displayed correctly. - "Coșuleni, Botoșani (Bălușeni)"
After you click on the text, what is displayed in the window this is different - "Coșuleni, BOTOȘANI (Bălușeni)"
STEP3:
Request - "Cerchejeni, Botoșani (Blândești)"
In dropbox, the request is displayed correctly. - "Cerchejeni, Botoșani (Blândești)"
After you click on the text, what is displayed in the window this is different - "Cerchejeni, BOTOȘANI (Blândești)"
STEP5:
Request - "Șoldănești, Botoșani (Blândești)"
In dropbox, the request is displayed correctly. - "Șoldănești, Botoșani (Blândești)"
After you click on the text, what is displayed in the window this is different - "Șoldănești, BOTOȘANI (Blândești)"


Expose types based on the four base64 configurations from this crate itself

Is there a reason why lib.rs does not have
base64_serde_type!(pub Base64Standard, STANDARD);
base64_serde_type!(pub Base64StandardNoPad, STANDARD_NO_PAD);
base64_serde_type!(pub Base64UrlSafe, URL_SAFE);
base64_serde_type!(pub Base64UrlSafeNoPad, URL_SAFE_NO_PAD);

?

These come to mind:

Every addition to the public API should "carry its weight" -- it should provide real value to compensate for the necessary limitation on future API evolution that any addition carries with it. In this case, you're saving the cost of writing one line like the above by writing a use line... I'm not sure that's actually even an improvement for the consumer, as the pre-built type would be less explicit in what it's doing.
You missed one (MIME), which brings up the next point: having lists of names that need to match across crates feels like a pretty bad idea.

it should provide real value to compensate for the necessary limitation on future API evolution that any addition carries with it.

What limitation on future API evolution could be created? Any change that leads to a breaking change in the user's crate necessitates a version bump of this crate, regardless of whether the macro was expanded in this crate or theirs.

In this case, you're saving the cost of writing one line like the above

My real use case is somewhat complicated in that I don't have an easy place to invoke the macro in my crate, but I'm not using it as motivation for this issue.
My motivation is completely that there is precedent in crates that provide separate serde impls from the base crate, like url_serde, and I expected the same from this crate.

the pre-built type would be less explicit in what it's doing.

This does not follow. It provides as much information as the name base64::STANDARD provides in the base64 crate. What an item means is only discovered by reading the docs for the item.

You missed one (MIME)

Indeed, I didn't realize MIME was a configuration. I was used to the names of the encodings from golang's library.

having lists of names that need to match across crates feels like a pretty bad idea.

There are only five of them.

If more are added to the base64 crate but not to this crate, and the user wants to use the new Config, the original method of invoking the macro with a custom Config still exists. If any is removed or renamed from base64, that would happen behind a version bump and the compilation of neither this crate nor the crates that depend on it would be affected.

There would be an argument for not providing pre-configured types if this crate was completely independent from the base64 crate. But it isn't - base64 is a required dep of this crate and thus this crate is associated with a particular base64 version.

What limitation on future API evolution could be created?

Naming conventions, for one.

My real use case is somewhat complicated in that I don't have an easy place to invoke the macro in my crate, but I'm not using it as motivation for this issue.

I'm OK with it being a motivation. :) I'm curious why that is; is there some quirk of the Rust's module system that I'm not thinking of that would mean you couldn't just put it in the root of your crate or something like that? Why would having a type in this crate be easier to use than a type in your crate?

This does not follow. It provides as much information as the name base64::STANDARD provides in the base64 crate. What an item means is only discovered by reading the docs for the item.

I guess we'll just have to agree to disagree, then. I don't consider documentation equivalent in explicitness to code.
While there are other crates and libraries that do things differently. I happen to think that that's a bad precedent. If an API is so cumbersome that it's worth duplicating lists of names or other options across libraries to save users from the burden, IMO that is a problem that should be solved by means other than embracing the chaos.  Such bloat also clutters the API, giving consumers more to read before they can figure out what it is that they want. A careful consumer might wonder if a hypothetical pre-baked type is equivalent to applying the macro themselves, or is there some other harder to reproduce aspect of the pre-baked types.
In this situation, the presence of, say, URL_SAFE has value because the precise configuration of that particular alphabet is finicky, and users shouldn't have to deal with that, But, it's behind a Config abstraction, and if the rest of the ecosystem can't just use that as is, there should be a better reason than "I like that line of code better than this line of code".


Disables inspiration toggle on tidy5e

Environment Details

Foundry Core Version: 0.8.7
System & Version: dnd5e 1.3.0
OS & Browser: Windows 10, Chrome
Hosting: Self-Hosted

Describe the bug
When character sheets are added to the GM Screen, then their inspiration is no longer togglable when using tidy5e sheets.
To Reproduce
Steps to reproduce the behavior:

add a PC character to a section of GM Screen
Close GM Screen
Open the PC's sheet (not in GM Screen) using tidy5e sheets
Try to toggle inspiration

Expected behavior
Inspiration should turn on/off
Screenshots

Thanks for the detailed report! This is definitely strange. I'll take a look.

There were a few bugs with GM Screen which this report helped me uncover, but ultimately the problem here was on Tidy's side. I've opened a PR which should resolve this issue.


Suggestion : Revamped Options & More Color Choices

I love how presets for P1, P2, Glow, and Everything have been added. However, I want to give a suggestion on being able to select the player's Wave Trail as a separate option, and maybe (if possible) even the progress bar during gameplay! With these new options in mind, I also feel like choosing what you want enabled shouldn't be a slider preset, but instead being toggleable boxes.

For the wave trail seperated option, its done for the next update.
I can also make the progress bar, but it will cause problem with some other mod that already modifying the progress bar.
Also I changed the preset select type to only button, slider was not that good

What is the specific mod that modifies the progress bar? I'm quite curious now.

I made one called "progress bar edit"
But geode didnt accept it for the moment so maybe I will ad the rainbow features here

For the update 1.0.4 I added the progress bar so it now can be rainbow too I hope you will like it, also I hope I will not have issues with others mod


[WIP] feat: korean whole translation

What is this?
This is a whole translation of misskey hub website into Korean.
Why did it?
I found some disabilities on English site, and Korean site is not provided even when they're translated quite much.
So, I decided to translate the entirity of the website.
Contributors
@JeonDohyeon - Fork Owner, translated the entirity

hi please give me write access tank you

@JeonDohyeon

hi please give me write access tank you

?

🤔🤔🤔
저에게 도와달라고 핑하신 거 아니었나요


Fix bug shipping address

Fixes all3dp/printing-engine#255
Definition of Done

[ ] The code does at least what is defined in the ticket and does not affect any other functionality
[ ] The PR has a meaningful title
[ ] There is a link to the issue-id
[ ] The PR has been reviewed
[ ] There are no 'hacks' or shortcuts refactoring is prefered

Tests

[ ] Reasonably tested with high code coverage (unit/integration)

Testability

[ ] All exported functions are testable
[ ] There is no code execution in the global scope
[ ] Default exports are avoided
[ ] The code is concise, expressive and readable
[ ] The code is functional and doesn’t use class syntax

React components are

[ ] Stateless and use pure rendering functions
[ ] Are documented and tested in storybook
[ ] Typed-checked
[ ] The Sass is stickily using the BEM-Convention
[ ] For each react component exists exactly one Sass-File
[ ] The is no container styled
[ ] There are no console errors or unwanted console logs

Hab die PropTypes geupdated. Falls du es nochmal auschecken willst, check den Branch neu aus. Ich hab auf master gerebased.


osltoy - Feature Request: custom #include search paths

Description
For Dev Days
#1862
Addressing a osltoy feature request, I've added the ability to specify custom search paths.
The changes consist of the following:

Added a command line option -I <path> to specify search paths (OIIO::ArgParse unfortunately can't mirror OSLCompiler's -Ipath syntax)
OSLToyMainWindow now stores an array of OSLCompiler options alongside a flag indicating whether or not they should be regenerated before compilation. The only option currently able to be specified is -Ipath, but this should ease any future extension.
Added a GUI component consiting of a window with a mutable list of the current set of search paths. This list is initially populated with any paths passed via the command line, but any modifications to the list will be reflected when the shader is next recompiled. Modifying this list does not currently force recompilation.
Added an entry to the Tools menu to open the new GUI component.
Added a line of output to the error window indicating what options the compiler was invoked with. I've defaulted to having it print for every run, but this may want to only print on failure.

Tests
I did not add any automated tests for this feature, as is consistent with the rest of osltoy. I did, however, do some manual testing to make sure the functionality works as expected.
Shaders that failed to #include some file instead succeeded when the parent directory of that file was added to the list of search paths via both the command line and the GUI component. Respectively, when said search path is then removed via
the GUI component, any subsequent compilation attempts fail again. The GUI component otherwise behaves as expected.
Checklist:

[x] I have read the contribution guidelines.
[x] I have updated the documentation, if applicable.
[x] I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
[x] My code follows the prevailing code style of this project. If I haven't
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.

/easycla

Noting that when the automated test suite ran on Friday evening for this pull request, the icx build got caught in an infinite loop at some point while building the BVH. Not that it's particularly relevant to this, but I wanted to point it out as it appears to be another case of #1874 cropping up

The icx thing is a known problem, we're looking into it


Scroll not adjusted to new height when model changes

When there is initially a large dataset, and scrollbar is at low position (e.g. item 500 of 550) and dataset reduced (i.e. to 10), scrollbar and container height don't readjust - only when "latch" is off.
this is caused by $beforeContent height not properly adjusted as startIndex is not properly adjusted.

Is there any solution for this problem ?

+1

Looks like this, #116, and #137 are all kind of related. I know I tried overcoming it with firing the resize event when I detected a model change, but didn't have any luck.

Please merge the commit from @CalMlynarczyk it really fixes the issues

👍  would love to see @CalMlynarczyk's fix merged.

Another way of fixing it is adding:
if ($scope.startIndex > originalLength) {
$scope.startIndex = 0;
}
after $scope.startIndex = $$options.latch ? _minStartIndex : __startIndex;
For me the problem occurs when I filter the repeat list with a filter after I scrolldown a bit in container, and startIndex become greater than the number of items! So the height logic get messed up unless you change the startIndex to 0 then the the items are painted and scrolling is now correct.

Any chance of this getting merged ?

I'm using @CalMlynarczyk's fork for now.  It's working for me.

So...we getting this merged or what?

@CalMlynarczyk's fork is better and more stable in nearly every way. Highly suggest using that.

Using @CalMlynarczyk's fork for now as well. It fixes this issue very well.

I don't know why this hasn't been merged...  Another fix is to do something like this after you change the dataset: angular.element('[vs-repeat]').scrollTop(0);.


Add helm operator

Most of components provided by dataroaster is based on helm chart. With helm operator, these components can be installed on kubernetes easily.

https://github.com/cloudcheflabs/dataroaster/pull/8


Sega CD / Mega CD Support

Hey, I've just upgraded to a Pi 2 so am taking advantage of systems which I couldn't play before.
The hashes for these games are on redump.org so should be straightforward to set up? I'll provide as much assistance as I can :) Shouldn't take too long compared to PSX I imagine (far fewer games!)
I've just noticed that there are some games missing from redump.org however I'll help filling the gaps.

Hi @robertybob,
I apologize for not responding sooner. I can set up a shared sheet if you like but yeah should be straightforward if the hashes are in a DB like redump. I'll see if I can't get something together tonight.

Brilliant! Give me a shout when it's set up :)

I shared a sheet with you. I think I have most of the things in redump matched but but there are several games in thegamesdb that aren't in redump. Most seem to be video or interactive movie type games. redump is all bin/cue so if you happen to have iso or other formats let me know and we can get the sha1 of them to incorporate.

Brilliant. I have .bin and .cue too. I haven't had a chance to look at it this weekend , so apologies for that. I normally work on this kinda stuff during my lunch break at work , so I'll do so tomorrow :)
Have you updated the Reporter tool lately? Would you be able to email it to me as I think I left my only copy on a USB stick I recently corrupted.

Right, looked through the list now and know what I need to do.
Going forward, Thegamesdb.net's forums are back up and running now and I may ask about the possibility of splitting the Sega CD and Mega CD (like they've done so with the Megadrive and Genesis). If this happens, will a new list need to be created?

Probably but it wasn't too hard to create to begin with.

Ah ok, I'll let you know if and when that happens :)
I've updated the spreadsheet as much as I can - can this now be implemented?

Thanks, I've updated the hash information. I haven't forgotten that I owe you a better tool for hashing. I haven't updated it since the original so will be good to do that.

I've just run the scraper for the first time and sadly I must have a abnormal rom-set as only 34 hashes out of 154 could be found.
https://www.dropbox.com/s/3p760ueci6bupom/missing.csv?dl=0
Also, in some cases it created entries in the gamelist.xml for both .bin and .cue of a game. e.g. Flink.bin and Flink.cue. See:
https://www.dropbox.com/s/i195z08x93v8pzz/gamelist.xml?dl=0
Is this supposed to happen?

No that isn't supposed to happen. I'll take a look tonight.

The bin/cue both being added could happen if the bin file was renamed. If you open the .cue file in a text editor you will notice it is readable and essentially lists the bin files. If you renamed them the cue would no longer point at the bin which is how I how I was linking the 2.
I'll take a look at the missing

@sselph Ah yes you're correct - the .cue files were pointing to .BIN rather than .bin. Let me know when you've updated the hashes :)

Added your missing list and also removed 20k duplicate lines from the hash.csv.

Many thanks :) My Pi's power supply has died so I can't test this, but I'll still close this.

I've just scraped again and this time only 37 weren't found (out of 154).
I ran the reporter and for some reason it's not finding the many hashes for the .bin files at all (yet when these games are scraped the scraper.exe finds the details using the .cue files, so I'm a bit confused).
I'm not sure how best to send you the hashes of the games that weren't scraped, when the hashes generated by the reporter.exe must be wrong (if you say you've added them to the hash.csv) as they're still not being found (?)

Hey. DId my previous post make sense? Let me know if you need clarification :)

That reporter is old and I need to make a new copy. You could try the shasum I mentioned in #20 but that would hash all the games not just the ones that are missing.

I also just added a feature to pass the -missing flag with a filename and it will write all the missing ROM information to that file. filename, error, hash, and an extra note like missing image, or that the hash is known but there wasn't a GDB ID.

Thanks! I normally scrape on my laptop but I'll attempt this on my Pi soon :)

Hi @sselph sorry for the delay. Ran your scraper from my Pi for the first time ! Used the missing image flag and got the following:
https://www.dropbox.com/s/qp4qmc4wspm4sdh/file?dl=0
Are you able to add these hashes to your database?

@sselph ? :)

Sorry most my free time has been spent playing fallout. I'll try to get to these tonight.

Added these. Let me know if that works.

Many thanks, I'll have a go at scraping again tonight :)

Because it takes a while to scrape all the games, I've done the first few from that list and they scrape fine, so presuming they all do. Thank you for doing this :)


Remove cleanup logic for older releases of Chef Infra Server

We required stepped upgrades so we know that everyone has first upgraded to 12.17. That means this logic all ran there and we can remove it here. This greatly reduces the number of things we have to do each time the reconfigure, upgrade, or cleanup commands run, and that speeds up runs / makes troubleshooting easier.
This requires #2709 to be merged first
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/3061#c20a0b42-9ec5-4df3-ac2f-7587f8458eda


Can't progress in Deep Jungle

I have managed to find all 6 slides throughout the worlds. I started progressing in Deep Jungle before progressing in Hollow Bastion and I got up to the point where Jane asks you to find the slides. I remember Clayton was standing outside of the tent and no heartless spawned.
Eventually I progressed through Hollow Bastion fully and found the last slide I needed there. I tried to go back to Deep Jungle to finish it, but Jane just keeps telling me there are 6 slides left to find. I can't interact with the projector, the interaction prompt doesn't come up. Also, Clayton is no longer outside and heartless spawn everywhere just like it normally would when you finish Hollow Bastion in the original game (which implies Deep Jungle was finished). I tried to go to the Treehouse and nothing happened. I just can't seem to interact with the projector with the slides to progress Deep Jungle, so I'm left with it incomplete at the moment.
Because of this, I also am unable to finish Traverse Town since I can't interact with Red Trinity marks.

Completing HB does mess with the progression of other worlds, unfortunately, so in absence of a better system, players usually avoid beating HB too early, but if the last slide required beating HB, then it's clearly a logic error. Can you tell me where it was?

Honestly I don't think it required beating HB. It was in one of the Lift Stop treasure chests though and either I opened it before completing finishing HB and I didn't happen to return to Deep Jungle to finish it then, or I opened it sometime after finishing HB and I happened to return to Deep Jungle to try to finish it then and that's when I noticed I could no longer progress there. Is there a way I can get a log to show you exactly where it was? Also is there a way to reset the Deep Jungle "flags" to make it so that I can continue it or no?

There should be a spoilers.txt in the game folder (or LuaFrontend folder if you use that) or you could send the seed itself.
Unfortunately I never developed a system to fix those flags. I could probably manage to do it manually, but that's a lot of effort just to fix one seed

seed.txt
spoilers.txt
Ok I've attached the seed and spoilers file.

I developed a script to combat this issue for KH1 AP Rando, it should work here?
https://github.com/gaithern/KH-1FM-AP-LUA/blob/main/1fmAPFixRiku2.lua

I developed a script to combat this issue for KH1 AP Rando, it should work here? https://github.com/gaithern/KH-1FM-AP-LUA/blob/main/1fmAPFixRiku2.lua

Cool, what exactly does it do? Do I just put it in the script folder? Also does this only work for new saves or could it help fix the issue in my current save?

Basically it checks to see if you have completed the Riku-Ansem fight and if one of the following worlds are in an incomplete state:

Wonderland
Deep Jungle
Agrabah
Neverland

If they are, it reverts those world's room flags back to the state they should be in based on their story progression byte (which is unaffected by that fight).  After you complete the world, it then sets the rooms back to their post Riku-Ansem state.
You can just put it in the scripts folder
Should work for your current save.

Basically it checks to see if you have completed the Riku-Ansem fight and if one of the following worlds are in an incomplete state:

Wonderland
Deep Jungle
Agrabah
Neverland

If they are, it reverts those world's room flags back to the state they should be in based on their story progression byte (which is unaffected by that fight). After you complete the world, it then sets the rooms back to their post Riku-Ansem state.
You can just put it in the scripts folder
Should work for your current save.

Thanks for the script! I see some progress now. I will list the observations and steps I took to get to the cutscene after running the 6 slides on the projector.
Now, Clayton is standing outside in the camp area again, no heartless are spawning, and Sabor spawns as normal. However, I still can't interact with the projector. I talk to Jane and she says there are still 6 slides to collect. I go to the Treehouse and wait until Sabor kills me to see if that does anything and it does not. Then I go back to the tent and walk outside and notice that the slides are physically there around the camp when they weren't previously. I collect them (even though I already had 1 of each in my inventory) and then am able to interact with the projector to proceed.

Yeah there is some flag somewhere to track how many slides you have picked up, I think the game looks for that rather than how many you have in your inventory, but don't recall exactly.  Glad its working now!

Iirc the way I implemented it, if the slides are randomized, is that you need to find them and after that you can collect them at the camp because of those flags

Yeah there is some flag somewhere to track how many slides you have picked up, I think the game looks for that rather than how many you have in your inventory, but don't recall exactly. Glad its working now!

Thanks again! On a side note, I noticed your script has a line about Kurt Zisa. I had actually started a second save file yesterday because I thought my original one was a lost cause and I got to Olympus Coliseum and lo and behold, my Preliminaries Cloud fight was replaced with Kurt Zisa! Obviously I couldn't kill him. Does your script also help make it so Kurt Zisa doesn't replace other bosses?

No, the line about Kurt Zisa is just making sure that the carpet appears to take you to him when you complete Agrabah if you've beaten Riku-Ansem, specifically if you beat Agrabah after Riku-Ansem.

No, the line about Kurt Zisa is just making sure that the carpet appears to take you to him when you complete Agrabah if you've beaten Riku-Ansem, specifically if you beat Agrabah after Riku-Ansem.

Ok thank you. Reporting back with a follow up issue. I did everything in Deep Jungle, climbed up the waterfall cavern, and the cutscene played. It took me back to the tent afterwards and I boarded the gummi ship and saw the dialogue play where they decide to go to back to Traverse Town. However, on the map screen it doesn't show that I unlocked the Deep Jungle keyhole. Also I did not get the ability to interact with Red Trinities.

This is the last journal entry I see for Deep Jungle at the moment.

That I'm not sure about, I believe trinities are randomized so did Red Trinity end up being vanilla?

Yeah trinities should be random so you may have unlocked another the keyhole not showing as completed and the journal being in that state seems wonky.

Yeah trinities should be random so you may have unlocked another the keyhole not showing as completed and the journal being in that state seems wonky.

Yesterday I started a new save file and got through Deep Jungle. I noticed that after going up the waterfall cavern and procing the cutscene up there, there was another cutscene that played where Tarzan, Jane, and Sora's gang are in the tent talking and Tarzan gives Sora what I assume is originally supposed to be the keychain of that world. Then he gave me the ability to do Red Trinities. However in my original randomized playthrough this cutscene didn't happen. I went up the cavern, had the cutscene there, then the game teleported me to the tent but that cutscene I just mentioned didn't play out, so I didn't get whatever that randomized item would have been from the keychain nor did I get the ability to do Red Trinities. It seems there is something bugged with my original file.

yeah I would guess there is another flag that was not quite caught by that second mod script.


Can't run the application

Hi Sir,
is it possible to send me an example of the use of kriging.js ?
I thank you in advance.
Ps: it's really matter to me.

@oeo4b, Please help


Using the connector in a containerized environment

Hi, I want to use the connector in two scenarios
1.To connect from a spark deployed locally to a GP deployed in a container, my local tests showed that the connector just freezes for reading and writing, When i used https://docs.vmware.com/en/VMware-Greenplum-Connector-for-Apache-Spark/2.3/greenplum-connector-spark/using_the_connector.html i have to specify in Spark configuration
.config("spark.greenplum.gpfdist.host", "host.docker.internal"), but I did not find an alternative option for you to indicate to the connector where the spark nodes are deployed.Question how do I use your connector in a local environment and with a GP in a container
2. Can I use the connector if my spark is deployed in K8s? based on the official connector from Vmware(https://docs.vmware.com/en/VMware-Greenplum-Connector-for-Apache-Spark/2.3/greenplum-connector-spark/configure.html), which also had problems connecting to Spark spark in K8s, I want to find out if your connector works with the Spark in K8s?
3. Does the connector work with Pyspark?

Hello!
For the first point - we will evaluate and let you know soon.
The second is rather problematic and we have no plan to implement this for a while.
The third should work, at least we had tested it with earlier releases.

About using GP deployed in a container and a spark running locally, basically it should work without any special settings, although I would discourage you from using such a setup in the production.
On every spark worker host (you have only one, right?) the connector opens a TCP socket with random port trying bind to the main LAN address (not the loopback), then it pass that address to the GP and GP then connects there from withing a container.
Why it can fail? I'd first check the access to that socket from the container.
When the connector freezes, probably the following can help you to see a SQL query that it tries to execute:
SELECT pid, age(clock_timestamp(), query_start), usename, state, query, sa.waiting, sa.waiting_reason,
      sa.application_name
FROM pg_stat_activity sa
WHERE query NOT ILIKE '%pg_stat_activity%'
    and state != 'idle'
ORDER BY query_start desc;

, query should contain a LOCATION clause with the IP and port where the connectors listens.
Hope that helps.

Closing by no activity


Remove UseBiasedLocking

This removes the UseBiasedLocking from jvm.config files.
Fixes #36.
See also #42.
It probably also makes sense to do a more complete update of the jvm.config and to peg the trinodb/trino docker image to a specific tag.

Looks good to me.


chore: release v0.2.4

:robot: I have created a release beep boop
0.2.4 (2024-03-31)
What's Changed

chore(deps): bump clap from 4.5.3 to 4.5.4 by @dependabot in https://github.com/coffeebeats/gdpack/pull/188
chore(deps): bump reqwest from 0.12.1 to 0.12.2 by @dependabot in https://github.com/coffeebeats/gdpack/pull/189
chore(deps): bump openssl-sys from 0.9.101 to 0.9.102 by @dependabot in https://github.com/coffeebeats/gdpack/pull/191
chore(deps): bump dependabot/fetch-metadata from 1 to 2 by @dependabot in https://github.com/coffeebeats/gdpack/pull/190
feat: pre-build arm64 on linux binaries by @coffeebeats in https://github.com/coffeebeats/gdpack/pull/193

Full Changelog: https://github.com/coffeebeats/gdpack/compare/v0.2.3...v0.2.4

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/coffeebeats/gdpack/releases/tag/v0.2.4 :sunflower: