Acces token is not refreshed after expiration time is met and refresh token is still valid

Describe the bug
When the expiration time of the access token is past, the new token is not fetched
To Reproduce
Steps to reproduce the behavior:

Login in react-native app successfully
Reload the app and notice auto login because refresh token is still valid
Wait for token to expire (i set it for testing purposes in the keycloak console to 1 minute but it also happened when it was on 5 minutes)
Observe 'OnTokenExpired' event is fired by the ReactNativeKeycloakProvider
Observe 'UpdateToken' is triggered (i put some console.logs)
Observe it takes the short escape as it already found a defined promise

if (this.refreshTokenPromise) {
      return this.refreshTokenPromise;
    }

No new acces token is fetched so next api call is with the expired access token which results in 401 (which is correct as the token is expired)
Reloading the app will use the valid refreshtoken to fetch a new accesstoken and voila api calls are valid again without re-entering credentials. until the token with logging in is expired and no new tokens are retrieved with the updateToken call.

Expected behavior
I expect after returning to the react-native app that the access token will be tried to be updated after it expires.
Screenshots
If applicable, add screenshots to help explain your problem.

Updated client.js in node_modules to set the console.logs:
async updateToken(minValidity = 5) {
    if (!this.refreshToken) {
      throw new Error('missing refreshToken');
    }

    console.log('Update token root: ', {refreshTokenPromise: this.refreshTokenPromise})
    if (this.refreshTokenPromise) {
      return this.refreshTokenPromise;
    }

    this.refreshTokenPromise = new Promise(async (resolve, reject) => {
      let shouldRefreshToken = false;

      if (minValidity === -1) {
        shouldRefreshToken = true;
        this.logInfo('[KEYCLOAK] Refreshing token: forced refresh');
      } else if (!this.tokenParsed || this.isTokenExpired(minValidity)) {
        shouldRefreshToken = true;
        this.logInfo('[KEYCLOAK] Refreshing token: token expired');
      }

      if (!shouldRefreshToken) {
        resolve(false);
        this.refreshTokenPromise = undefined;
        console.log('!shouldRefreshToken', {refreshTokenPromise: this.refreshTokenPromise})
        return;
      }

      const tokenUrl = this.endpoints.token();
      const params = new Map();
      params.set('client_id', this.clientId);
      params.set('grant_type', 'refresh_token');
      params.set('refresh_token', this.refreshToken);
      let timeLocal = new Date().getTime();

      try {
        const tokenResponse = await this.adapter.refreshTokens(tokenUrl, (0, _url.formatQuerystringParameters)(params));
        this.logInfo('[KEYCLOAK] Token refreshed');
        timeLocal = (timeLocal + new Date().getTime()) / 2;
        this.setToken(tokenResponse.access_token, tokenResponse.refresh_token, tokenResponse.id_token, timeLocal); // Notify onAuthRefreshSuccess event handler if set

        this.onAuthRefreshSuccess && this.onAuthRefreshSuccess();
        resolve(true);
      } catch (err) {
        this.logWarn('[KEYCLOAK] Failed to refresh token'); // Clear tokens

        this.clearToken(); // Notify onAuthRefreshError event handler if set

        this.onAuthRefreshError && this.onAuthRefreshError();
        reject();
      }

      this.refreshTokenPromise = undefined;
      console.log('Token Response: ', {refreshTokenPromise: this.refreshTokenPromise})
    });
    return this.refreshTokenPromise;
  }

Smartphone (please complete the following information):

Device: iPhone 11
OS: iOS 14.5
Browser: stock browser (safari)

Additional context
As far as i could see there is only one spot where this.refreshTokenPromise is set and this is in the updateToken function. And it seems that the code that sets this promise as undefined is hit, but when coming back to the app it is already set without any token call being executed.
P.S. Currently im running patch-package in my app and i just comment out the check for an existing refreshTokenPromise which solves the 401 error after your first access token is expired.
P.S2. I had accidently reported the issue under the wrong package (https://github.com/react-keycloak/react-keycloak/issues/147). Although keycloak-ts is under development, it is required by the react-keycloak/native package and therefore hitting the code mentioned above. Now im also unsure if i should report the issue here or under react-keycloak/native package. But since the code my app is hitting is in keycloak-ts, i created the issue here.

This is still an outstanding issue.

further activity occurs

Aye. We are working in it

Any progress on this?

Any update on this issue?

Any update please ? :/

@ronangaillard They bumped the release version to 0.2.4 https://github.com/react-keycloak/keycloak-ts/issues/11

I made it work by targeting the onTokens update event and updated my token stored in cookies as follows:
const App: React.FC = () => { const [cookies, setCookies, removeCookie] = useCookies() return ( <ReactKeycloakProvider         onTokens={({ token }) => {           if (token) {             if (token === cookies["TOKEN"]) {               return             } else {               setCookies("TOKEN")             }           } else {             removeCookie("TOKEN")           }         }}         authClient={keycloak}         LoadingComponent={<Spinner isInFullHeightWrapper />}       > <Routes/> </ReactKeycloakProvider> ) }
Summary: Everytime when keycloak trigger token update method before its expiration I also update my token stored in cookies.


Remove iaso_beneficiaries from the database

https://bluesquare.atlassian.net/browse/IA-1632
Self proof reading checklist

[x ] Did I use eslint and black formatters
[ x] Is my code clear enough and well documented
[ ] Are my typescript files well typed
[ ] Did I add translations
[ x] My migrations file are included
[ ] Are there enough tests

Changes
Migration to remove iaso_beneficiaries from the db
How to test
Explain how to test your PR.
Run the migration, check if iaso_beneficiaries disappeared from the database
Print screen / video
The last entry here should disappear

@beygorghor @madewulf  does it works if some users had that permission?


Hide/Show correct elements for Winner

Acceptance Criteria
Winner screen should look similar to:

The hidden elements are:

Loser Pokemon
Loser Stats

The shown elements are:

Winner box with the name of the winner in it

I'm on it!

Hey! I managed to get most of the work done. However I have a slight issue/bug.

Loser Pokemon Platform is also hidden

I will work on it later! Let me know if you have ideas on how to fix this.
Thank you!

Fixed!


chore: add asyncapi tool info file

Adding file based on https://github.com/asyncapi/website/issues/383
tl;dr the idea is that tools list on website will soon work basing not only on manual process, where people manually add their tools to list, but also automated process where people instead of opening a PR to website, will be able to just add a config file to their public repo.
@magicmatatjahu yes, I know YAML is not supported but when I was writing JSON my blood pressure jumped up by a 100. I think JSON is not really meant to be written by a human. Once this file is merged I'm willing to contribute YAML support to toolings scripts in website repo

/rtm


Add Copyright for ticket: ZQS-994

@max-radin I have changed base from main to dev as I assumed you used main by accident.


Documents how to add token to requests

@shankiesan This is great, thanks for taking the time to do this, very much appreciated!


Transport Error

 Hello Dear Engineer, I am facing an issue while using dtls library, I have created the server side program normally and set the client side certificate validation. I got the following graphical error through Wireshark packet grabber tool and my client program is not receiving the cookie information.

Hey @emorydu really sorry I didn't respond to this sooner. Were you able to fix this?
If it is still happening can you grab the output from PION_LOG_TRACE=dtls
thanks for using Pion!


[BUG] npm create refine-app@latest missing dependencies

Describe the bug
Dependency missing after initial install
@refinedev/react-table
@refinedev/react-hook-form
Steps To Reproduce
npm create refine-app@latest

Next.JS
REST API
Headless
No examples
Google auth
i18n
pnpm
pnpm run build

Expected behavior
All dependencies installed
Screenshot
No response
Desktop
Windows 11
Chrome
"@refinedev/core": "^4.28.2",
Mobile
No response
Additional Context
No response

Hello @silentnyte these dependencies are not installed, because they aren't used anywhere, since you choose "No examples".

As soon as you create a resource they will be needed. Is there a use case where refine is used without any resources?


Fail to show projects every time I restart atom

Issue
Every time I restart atom, the project-viewer panel is gone. I have to disable and enable the package to make it show again.
I also use Sync Settings package, I find the setting for project-viewer cannot sync. I'm not sure will the two packages interact with each other. But even if I disable the Sync Settings, the issue I post below still exists.
Environment

OS: macOS;
Atom: latest;

Steps
If I enable "Old panel integration versus Dock", the error will become more clear. Let's see.
First, make sure I can see the panel normally.

Second, restart atom and I will find the panel shows no project.

Third, click "disable" for the package. Strange UI occurs here.

Last, click "enable", things return normal again.

Fixed by myself. I find out that Set a custom panel width is accidentally set to 1. Restoring to default value 200 makes everything ok.


How to decode chunks and get readable characters ?

Object Storage Provider:   GC
What happened:   encoding issue
I'm using python and getting the blocks in google cloud bucket
I would like to know how can I decode chunks and what is their encoding.
Any help please ?

What chunks you have in mind? You can read exact block format here: https://github.com/prometheus/prometheus/tree/master/tsdb/docs/format :thinking:
Curious what you are working on! (:
Closing for now, feel free to ask follow up questions here or on slack.

I would like to know what is the encoding of the chunks files stored in a GC bucket as octect-stream , and how to decode the data and get readable tsdb

Everything is inside: https://github.com/prometheus/prometheus/tree/master/tsdb/docs/format


Vectorscope depends on volume

I am usually listening to music at low volume

yeah we gotta fix that, this issue reoccured because of the implications regarding https://github.com/Geoxor/amethyst/issues/53

So we made #106 and made it so that the slider affects the master node at the end, however, the vectorscope and spectrum at the  bottom of the screen connect after the slider gain, so this will persist;
We would need to ad pre and post for this to get fixed.

no longer an issue due to this being intended behaviour from the 'master' node


This supecedes and closes #100.

I am getting an error when I try to load any page in my browser window:
query not supported Processing query SELECT * WHERE { _:b3 ?p ?o . }
I have traced the source of this error to Krikri::Provider.all.  When I run it in my console, I get:
Solr query: {:qt=>"search", :rows=>0, :id=>"*:*", "facet.field"=>"provider_id"}
Solr fetch (3.5ms)
SPARQL::Client::ServerError: query not supported Processing query SELECT * WHERE { _:b3 ?p ?o . }
from /Users/audreyaltman/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/sparql-client-1.1.4/lib/sparql/client.rb:344:in `block in response'```

@no-reply can you add documentation, to README and/or app/models/krikri/qa_report.rb explaining how to generate QA reports?

Provider context doesn't seem to be working on validation_reports.  In my browser, with the sample data from the rake task, when I load http://localhost:3000/krikri/validation_reports/sourceResource_title, I see one record, as expected :+1: However, when I load http://localhost:3000/krikri/validation_reports/sourceResource_title?provider=123, I do not see any records, which is incorrect.  I should see one record.

A single record is not rendering from it's local name.  In my browser, with the sample data from the rake tasks, when I load http://localhost:3000/krikri/records/http:%2F%2Flocalhost:8983%2Fmarmotta%2Fldp%2Fitems%2Fkrikri_sample_invalid, I get the expected record :+1:, but we've already learned that URI id's cause breakages if they include dots.  When I do http://localhost:3000/krikri/records/krikri_sample_invalid (using the record's local name instead of the URI), I get a record not found error.

Provider context does not seem to be working on the the records#show page.  In my browser, with the sample data from the rake tasks, when I load http://localhost:3000/krikri/records/http:%2F%2Flocalhost:8983%2Fmarmotta%2Fldp%2Fitems%2Fkrikri_sample?provider=123, the random record button reads "Random record from All Providers" instead of "Random record from Moomin valley Historical Society", as I would expect.  Also, the random record button links to any record, not just records with a provider_id of 123.  Finally, after the button is clicked, the new record URI does not contain the param provider=123 as I would expect.

The local name issue (https://github.com/dpla/KriKri/pull/134#issuecomment-88648192) should be fixed by 82cf8d6.  It was originally removed in 548c381d5ee.

Small unexpected behavior:  When I load http://localhost:3000/krikri/reports?provider=123 into my browser window, I see an error message under the header "QA Reports".  The error message reads, "There was an error generating the QA reports."  I expected the space under the header "QA Reports" to be blank, as it is on http://localhost:3000/krikri/reports.

I believe the latest commits deal with all the issues raised by @AudreyAltman's comments.
@AudreyAltman is going to take a look at moving session handling to its own controller, to deal with: https://github.com/dpla/KriKri/pull/134#discussion_r27616482
In the meanwhile, I'm going to try to diagnose the intermittent test failures (I suspect these are related to index clearing) and add documentation throughout.
@anarchivist your review would be very helpful, at this point.

I think this is looking good. I haven't tested out the functionality locally yet because I've been focused on the review. Hopefully I can do that first thing tomorrow.

I think everything is now addressed.
The test suite now passes, with sleep between indexing and sending requests for the controller specs. I propose opening a chore to come up with a better strategy of dealing with the index-dependent specs.  We could webmock the solr requests, or very aggressively mock blacklight, or just try to index on before(:all) where possible, and include the sleep there.

homerun.


Allow third party packages to synchronize objects

I'd love for there to be a way for users to share not only their text editor but also their "block decorations" (at least certain kinds).
In particular, it would be really great for hydrogen to be able to share plots and other outputs from our live interpreters within Atom with others. At least for data scientists, this would be really useful for sharing current results, data, and plots.
/cc @lgeiger @BenRussert

Thanks for the feedback. Our intention is to expose a JSON-like API for replicated objects, as well as possibly making simple RPCs and notifications extensible. I'll try to remember tag this issue when I open a proposal for how it could work so we can get more feedback.

following

I can second this! Working in a remote Data Science team, this would be a tremendous enhancement to our workflow!


adding hackathon in august

Related Issue
issue goes here with issue number
Summary
Provide an overview
Update type?

[ ] Adding Opportunity
[ ] UI Update

If adding new opportunity

Deadline should be

✔ 15 August : If the available deadline is previous years then do not add date
✔ 15 August 2021 : If available deadline is of present year
✔ August: If you are not sure of the exact date, but the deadline lies in August.
❌ August 15
❌ Aug 15
❌ 2021 Aug 15
❌ 15 Aug 21

If an opportunity is for women add the Women word in type section
Make sure the added opportunity is in the specified format:

{
    name: 'Name of the event',
    link: 'https://valid-url-to-explanation',
    deadline: 'deadline or range',
    type: 'whether a mentorship, internship or hackathon',
}

Proposed Changes

change 1
change 2
...

Screenshots

Original
Updated

** Original screenshot **
** updated screenshot **

Thank you @nishajha629 for your contribution!
Please keep in mind to place the opportunities in ascending order of their deadlines 😊


youtube-dl doesnt respect index parameter in the URL

youtube-dl https://www.youtube.com/watch?v=qHh09DnVUaQ&list=PLyiDf91_bTEgnBN0jAvzNbqzrlMGID5WA&index=1
youtube-dl https://www.youtube.com/watch?v=qHh09DnVUaQ&list=PLyiDf91_bTEgnBN0jAvzNbqzrlMGID5WA&index=54
youtube-dl https://www.youtube.com/watch?v=qHh09DnVUaQ&list=PLyiDf91_bTEgnBN0jAvzNbqzrlMGID5WA&index=33

all result in the same file being downloaded

but curiously enough
youtube-dl https://www.youtube.com/watch?v=qHh09DnVUaQ&list=PLyiDf91_bTEgnBN0jAvzNbqzrlMGID5WA

results in different file being downloaded

All the URLs that are quoted above result in yt-dl retrieving the playlist, unless playlist options are used. For example:
$ youtube-dl --get-id 'https://www.youtube.com/watch?v=qHh09DnVUaQ&list=PLyiDf91_bTEgnBN0jAvzNbqzrlMGID5WA&index=33'
cy4CJ4F-epA
rR8Six9qpcA
pcYrTCGKyrU
gBMkbAM1qiA
...

You might see a different first video being retrieved depending on which playlist items were previously downloaded.
Also, although the index=... URL parameter is clearly known to the site (it doesn't get stripped, and the site may change it), different index values didn't seem to make any difference to the display in the browser.
Apparently index is correctly being ignored by the extractor, but I am no YT expert since I generally use this program, or perhaps Invidious, to access YT content owing to the unusable bloat (etc) of the site itself.

yt-dl is behaving as expected: the index URL parameter is not (or no longer) significant; playlist options have to be used to force selection of the focussed item or any specific item or subset of items.


Appreciation post

This is quite cool and very useful. Great work!
I had to change a few things around but was able to use to generate some data for me. Maybe the documentation needs a section on how to generate new data:
python generators.py /Users/mayurb/src/open/ai/fuxion/templates/generator/jobs.template /Users/mayurb/src/open/ai/fuxion/few_shot_examples/jobs.json

I'm glad you found it useful.
And apologies for the outdated docs, there was a huge refactor on the project and I am working on updating the docs for proper guidance on how to use it.

Docs Updated.
Also, you can now install fuxion via pip with
pip install fuxion


Don't allow picking on the sunPostProcess framebuffer.

Fixes #5478.
Likely fixes #5402.
/cc @bagnell @AnneWoepse
@bagnell I'm curious about the if block I'm modifying here.  It has two else if clauses which could possibly both be false.  What happens if all three paths go false at the same time?  Seems like the framebuffer would not be assigned, would it have a reasonable default?

Please update CHANGES.md

@bagnell Also, it's concerning that picking would "stay broken" even after this code switched back to using the globeDepth framebuffer.  Is switching framebuffers here somehow unsafe for picking?

What happens if all three paths go false at the same time? Seems like the framebuffer would not be assigned, would it have a reasonable default?

It will default to whatever the pass state framebuffer is. When picking, it will be the picking framebuffer. If the pass state framebuffer is undefined, it'll render to the default framebuffer (directly to canvas).

Also, it's concerning that picking would "stay broken" even after this code switched back to using the globeDepth framebuffer. Is switching framebuffers here somehow unsafe for picking?

Yes, during the pick pass it should never switch framebuffers. All of the post processing and globe depth copying should be disabled when picking.

All of the post processing and globe depth copying should be disabled when picking.

During my testing, I added console.log statements to the various if clauses here, and the globe depth one (the middle one) does get executed when the Sun post process filter isn't in effect.  Maybe this whole section of code needs stronger protection from picking.

Maybe the environment isn't being updated correctly?

I think it might be updating correctly but out of order? If you look at Sun.update you'll see this block of code:
if (!frameState.passes.render) {
    return undefined;
}

That would cause environmentState.isSunVisible to be false in that condition.

During my testing, I added console.log statements to the various if clauses here, and the globe depth one (the middle one) does get executed when the Sun post process filter isn't in effect. Maybe this whole section of code needs stronger protection from picking.

That's strange, if you look several lines up you'll see this:
var useGlobeDepthFramebuffer = environmentState.useGlobeDepthFramebuffer = !picking && defined(scene._globeDepth);

That's strange

Oh, I didn't limit my console logging to just the pick pass, fixed now.  So yes, in master, the pick pass chooses either Sun bloom (the first clause, when the Sun is visible in the frame), or it falls past all three conditionals to leave the framebuffer alone (skipping over globe depth and fxaa).

Ah, OK, I found the real issue. The environment state is never updated on a pick. We simply need to call updateEnvironment in Scene.pick right before updateAndExecuteCommands. Do you you want to submit the fix?

Actually I added the call in two places, is this OK?

Yup, thanks @emackey!


self.navigationcontroller is nil in the child view controllers

In the parent view controller, I have printed this value:
print("inside the main, nvc: (self.navigationController)")
which gives me a navigation controller instance,
while when i print:
print("inside the child, nvc: (self.parentViewController.navigationController)") in the child controllers, it gives me a nil value
I have also tried to print print("inside the child, parent vc: (self.parentViewController)") which also gives me an instance of its parent view controller

Do you got any answer

Workaround explained here: https://github.com/uacaps/PageMenu/issues/200


Issue #383 ability to exclude images

@konstruktoid as per our discussion on issue #383

LGTM but remove the white spaces and please sign your commits.
Closes #383

Closes  #369

Thanks!

is -i and -x both should include to run on specific images? I have 100 images and I want to scan only one image in that. Is it possible with -i?

Examples (I've removed the yell):
$ docker images
REPOSITORY                  TAG                 IMAGE ID            CREATED             SIZE
konstruktoid/nginx          latest              b05b335b68d0        23 hours ago        10.6MB
konstruktoid/docker-garby   latest              57fdebbb0bb1        23 hours ago        207MB
nginx                       latest              231d40e811cd        10 days ago         126MB
konstruktoid/alpine         latest              c4e0b1901367        5 weeks ago         5.57MB
alpine                      latest              965ea09ff2eb        6 weeks ago         5.55MB
$ sudo sh docker-bench-security.sh -c check_4_6
[WARN] 4.6  - Ensure that HEALTHCHECK instructions have been added to container images
[WARN]      * No Healthcheck found: [konstruktoid/nginx:latest]
[WARN]      * No Healthcheck found: [nginx:latest]
[WARN]      * No Healthcheck found: [konstruktoid/alpine:latest]
[WARN]      * No Healthcheck found: [alpine:latest]

[INFO] Checks: 1
[INFO] Score: -1
$ sudo sh docker-bench-security.sh -c check_4_6 -i nginx
[WARN] 4.6  - Ensure that HEALTHCHECK instructions have been added to container images
[WARN]      * No Healthcheck found: [nginx:latest]

[INFO] Checks: 1
[INFO] Score: -1
$ sudo sh docker-bench-security.sh -c check_4_6 -x nginx
[WARN] 4.6  - Ensure that HEALTHCHECK instructions have been added to container images
[WARN]      * No Healthcheck found: [konstruktoid/alpine:latest]
[WARN]      * No Healthcheck found: [alpine:latest]

[INFO] Checks: 1
[INFO] Score: -1

I'm not sure how it is working for you. I'm tr

ying the same way. Still No luck :(

@kumarchatla that is the correct behaviour.
You are running one test against one image with no failures, typically the failed image is shown beneath the failed test e.g. in your case which container does not have a healthcheck. However, that test has passed so that looks correct.

@kumarchatla that behaviour is correct.
You are running one test against one container and it has passed. Typically, if it fails it will indicate which container has failed the test. However, in your case there are no failures so this is expected.

If I don't use -i, I am able to see failed for the same image ( Running against all images). If I include ( -i imagename) then that image was passing with no health check complaints.

Apologies, I misread that. I'll try take a look when I get some time.

@kumarchatla that's odd, just to be sure. could you use -i mbt ?

This looks to be only an issue with the images (not containers) because of the stripping of the top row (sed '1d') before searching the results. I've reordered this so the sed command comes first, it should be fixed it in PR #406.

This looks to be only an issue with the images (not containers) because of the stripping of the top row (sed '1d') before searching the results. I've reordered this so the sed command comes first, it should be fixed it in PR #406.

This Works, Thanks


workflows: Specify python-version for docs and release workflows

I merged in #307 earlier today. One of the incompatibilities with the newer version of the setup-python action is that we need to specify python-version. I forgot to add that change to the doc and release workflows.


Variable $cah is undefined.

Various 500 Errors being thrown frequently.  When page loads, if it doesn't work, it states that this is undefined.  Attempting to load the offending JS file actually CRASHED my FireFox instance.  Cross-server issue; renders game unplayable.  Confirmed to affect multiple parties in vastly different locations at the same time.

The servers had been getting massively overloaded. I'm making changes in the near future to help with that... Not really any code bugs, though.


[SDPV-41] Tag table refinement

This story defines success criteria as:

[x] Update column headers "Display Name" to "Tag Type"
[x] Update column headers "Tag code" to "Tag". This should be a free text field.
[x] Update "Code System" to "Code System Identifier (optional)"
[x] Change "Add a row to the table" to " Add a new tag"
[x] Add list of options to "Tag Type" column rows that users can select from. This could be implemented as a drop-down menu, for example. The list of options should include "Disease or Condition", "MMG Name", "MMG Tab Name", "Survey Name", "Code System", and "Other". In the list of feedback it was also stated that other would allow new tags / free text to be entered.

The last item is done using react-autocomplete which allows autocomplete based on the Tag Type, tag itself, or code system (for the future consideration of making reuse easier). The implementation here is WAI-ARIA compliant and can be extended to make the experience more user friendly in the future with longer lists of tags.
Make sure you include the related JIRA issue in the title e.g. '[SDP-007] Fixed navbar issue'
Make sure you have checked off the following before you issue your Pull Request:

[x] Passed all unit tests using rails test with 90%+ coverage
[x] Added cucumber tests for any new functionality
[x] Passed all cucumber tests using bundle exec cucumber
[x] Passed overcommit hooks, including running all code through Rubocop
[x] If any HTML was added or modified check to make sure it was still 508 compliant with WAVE tool / carried over any attributes from similar sections

Noticed two issues after I submitted, display issue on survey edit and showpage rename, fixing these  now.


Air Quality Sensor "TypeError: Cannot read property 'setValue' of undefined"

Dear developers!
Where should I specify this property? Tried inside the payload, outside the payload, nothing helps.... Also what this value should be?

With PM10 it works. With PM2.5 not... So it might be the problem with the dot in the property. Can this be fixed somehow?


fix: Default search type for Teams

Fixes #3734

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.002%) to 84.488%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
19748

Relevant Lines:
22140

💛  - Coveralls


PDF Loading time too much long for big size pdf

When open a big size pdfs , like 500 pages pdf ....then the pdf loading time of too much ...... and memory consumption is too much ....please help me 🙏....

I think here all pages are rendered at same time .....if per page render when scrolling ....
How to implement the loading indicator per page ??

I think here all pages are rendered at same time .....if per page render when scrolling ....

No, the rendering is per-page basis.
The problem seems in the page layout logic. It firstly calculates the width/height of all the pages.
I've tested pdfrx with large documents like PDF Reference and the loading speed is acceptable even if we dynamically download it.
So if your 500-page document takes so long time, the PDF file's structure is too much complicated. Without the file, we cannot check the actual issue.
If you're just talking about download progress, here it is.
And, the memory consumption is already optimized on the latest version. I think there's already no room to optimize the memory usage on pdfrx. If you need more optimization, we should do some in pdfium.

I am talking about when the pdf render per page ...then the circular progress indicator (Not download indicator) appear in per page ....actually, here the page sometimes blank ....then the pdf show ...

You told "The problem seems in the page layout logic. It firstly calculates the width/height of all the pages." -------> how to overcome .....here the app sometimes completely freezed

How to double tap to zoom fuction ???

I implement the code of fetch total pages count ....Future _fetchTotalPages() async {
final document = await PdfDocument.openFile(widget.pdfPath!);
///To prevent the memory leak
if(mounted) {
setState(() {
List pages = document.pages;
 _totalPages = pages.length;

});
}

}  ....

I want to implement the vertical and horizontal mode with a button ... here i want to see this in realtime so i implement " forceReload: isReloadPDFView,"  option ...but then the pdf pages are not fit in the layout ...until when touched the screen .. =============> Here my method of vertical/ horizontal .....code.......

layoutPages: (pages, params) {
              if (!isHorizontalViewMode) {
                // Vertical layout (default)
                final width = pages.fold(0.0, (prev, page) => max(prev, page.width));
                final pageLayouts = <Rect>[];
                double y = params.margin;
                for (final page in pages) {
                  final height = page.height * (width / page.width);
                  pageLayouts.add(
                    Rect.fromLTWH(
                      params.margin,
                      y,
                      width,
                      height,
                    ),
                  );
                  y += height + params.margin;
                }
                return PdfPageLayout(
                  pageLayouts: pageLayouts,
                  documentSize: Size(width + params.margin * 2, y),
                );
              } else {
                // Horizontal layout
                final height = pages.fold(0.0, (prev, page) => max(prev, page.height)) + params.margin * 2;
                final pageLayouts = <Rect>[];
                double x = params.margin;
                for (var page in pages) {
                  pageLayouts.add(
                    Rect.fromLTWH(
                      x,
                      (height - page.height) / 2, // center vertically
                      page.width,
                      page.height,
                    ),
                  );
                  x += page.width + params.margin;
                }
                return PdfPageLayout(
                  pageLayouts: pageLayouts,
                  documentSize: Size(x, height),
                );
              }

        },

300 pages... 3-5seconds.

Please don't reuse a single issue for many things.
I ignore all your questions on the issue.

I think it's quite normal to load 300 pages in 3-5 seconds. Only your issue is it just freezing before showing the pages. I understand your pain. But I'm still thinking how to do that...

@espresso3389 I think this could be the solution: https://apryse.com/blog/pdf-format/what-is-pdf-linearization
https://github.com/mozilla/pdf.js/issues/8897

@letrungdo pdfrx uses pdf.js for web version so PDFJS.disableAutoFetch might be an option though I think it does not work for the case.
By the way, why are you referencing PDF linearization here?

@espresso3389 PDF linearization I think for pdf files downloaded from url it will be necessary to download the first pages to display first, not having to wait for the file to finish downloading to display.

@letrungdo PDF linearization is how PDF content should be and it has nothing to do with PDF viewer.

这是一封自动回复邮件。已经收到您的来信，我会尽快回复。


Cards break into multiple columns

Using the doc for card columns at http://v4-alpha.getbootstrap.com/components/card/, I experience cards that get split across columns, i.e. image is in column 1 and card block continues in column 2. This breaks the design of a single card. This only occurs on Mac in Chrome v53 and Firefox v48.2. Chrome v52 and Firefox v48.0 on Linux for example are rendering cards as expected.

#20654 #20665

Closing as a duplicate of the aforementioned issues.


How to send only once license request?

When playing the encrypted mpd file, Shaka Player send the license request twice.
the mpd that problem occurs is below. The following is an example of playing a video only encrypted mpd. Other than that, a mpd with both video and audio send the license request twice too.
MPD File:
<?xml version="1.0"?>
<!-- MPD file Generated with GPAC version 0.6.1-rev0-g72d766c-HEAD  at 2016-12-20T06:57:38.265Z-->
<MPD xmlns="urn:mpeg:dash:schema:mpd:2011" xmlns:cenc="urn:mpeg:cenc:2013" minBufferTime="PT1.500S" type="static" mediaPresentationDuration="PT0H1M40.067S" maxSegmentDuration="PT0H0M1.000S" profiles="urn:mpeg:dash:profile:isoff-on-demand:2011" xmlns:mspr="urn:microsoft:playready">
  <ProgramInformation moreInformationURL="http://gpac.sourceforge.net">
    <Title>/home/encoder/work/tmp/bbb_2M_100sec_20161220155550/job_4/bbb_2M_100sec.mpd generated by GPAC</Title>
  </ProgramInformation>
  <Period duration="PT0H1M40.067S">
    <AdaptationSet segmentAlignment="true" maxWidth="1280" maxHeight="720" maxFrameRate="30" par="16:9" lang="eng" subsegmentAlignment="true" subsegmentStartsWithSAP="1">
      <ContentProtection schemeIdUri="urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed" value="Widevine">
        <cenc:pssh>AAAAWHBzc2gAAAAA7e+LqXnWSs6jyCfc1R0h7QAAADgIARIQxXcyfkNpsb3dz3hYVXtRrxoMc2tpbGx1cHZpZGVvIg1iYmJfMk1fMTAwc2VjKgVTRF9IRA==</cenc:pssh>
      </ContentProtection>
      <Representation id="0" mimeType="video/mp4" codecs="avc1.4d401e" width="1280" height="720" frameRate="30" sar="1:1" startWithSAP="1" bandwidth="1011314">
        <BaseURL>bbb_2M_100sec/bbb_2M_100sec_0.mp4</BaseURL>
        <SegmentBase indexRangeExact="true" indexRange="1715-2958">
          <Initialization range="0-1714"/>
        </SegmentBase>
      </Representation>
    </AdaptationSet>
  </Period>
</MPD>

The log that confirms the request type with ShakaPlayerNetworkFilter is below.
ShakaPlayerRequestTypeLicense(type=2) is output twice.
Logs:
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:0
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:1
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:2
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:1
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:1
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:2
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:1
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:1
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:1
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:1
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:1
 D -[ShakaPlayer onPlayer:networkRequest:ofType:withBlock:] 588# ENTER ShakaPlayerNetworkFilterReq type:1

And, we setting DRM config in Shaka Player.
Code:
[_shakaPlayer<EMAIL_ADDRESS>withString:licenseUrl];
How to send only once license request?

Sounds like this issue: https://github.com/google/shaka-player/issues/2754
That will be resolved in v3.0.3 and v2.5.15 of Shaka Player, which hopefully will be out this week.  When Shaka Player Embedded adopts that version, you should see the fix in your native app.
@TheModMaker, does that seem accurate?

It could also be a server certificate request.  If this is the case, you could avoid the request by setting the server certificate the same was as in JavaScript.  Something like this:
[player<EMAIL_ADDRESS>withData:cert];
[player<EMAIL_ADDRESS>@"serverCertificate") withData:cert];

I just pushed the fix for the bug @joeyparrish said; if you still have duplicate requests, you'll need to set the server certificate.

Thanks for your response.
We imported the ShakaPlayer Embedded  framework with the bug fixed and set the serverCertificate, but app sent a license request twice.
We tried to play Google's Widevine content in ShakaPlayer Embedded  Sample Project, and sample app sent multiple license requests.
Google's Widevine content:
[uri]
 https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_sd.mpd
[configuration]
 key=drm.servers.com\.widevine\.alpha
 value=https://proxy.staging.widevine.com/proxy

Logs:
ShakaPlayerNetworkFilterRes type:0 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_sd.mpd
ShakaPlayerNetworkFilterRes type:2 uri:https://proxy.staging.widevine.com/proxy
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_audio_eng.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_h264_baseline_240p_800.mp4
ShakaPlayerNetworkFilterRes type:2 uri:https://proxy.staging.widevine.com/proxy
ShakaPlayerNetworkFilterRes type:2 uri:https://proxy.staging.widevine.com/proxy
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_h264_baseline_240p_800.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_audio_eng.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_audio_eng.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_h264_baseline_240p_800.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_audio_eng.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_h264_main_480p_2000.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_h264_baseline_240p_800.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_audio_eng.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears_h264_main_480p_2000.mp4

Code:
NSDataAsset *certificate = [[NSDataAsset alloc] initWithName:@"certificate"];
[self.player<EMAIL_ADDRESS>withData:certificate.data];

It may be related to google/shaka-player#2644.

We tried to play content (google/shaka-player#2644) in ShakaPlayer Embedded Sample Project, and sample app sent multiple license requests.
Content (google/shaka-player#2644):
Manifest URL: https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/dash.mpd
License Server URL: https://cwip-shaka-proxy.appspot.com/no_auth
License Certificate URL: https://cwip-shaka-proxy.appspot.com/service-cert

Logs:
ShakaPlayerNetworkFilterRes type:0 uri:https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/dash.mpd
ShakaPlayerNetworkFilterRes type:2 uri:https://cwip-shaka-proxy.appspot.com/no_auth
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/a-eng-0128k-aac-2c.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/v-0144p-0100k-libx264.mp4
ShakaPlayerNetworkFilterRes type:2 uri:https://cwip-shaka-proxy.appspot.com/no_auth
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/a-eng-0128k-aac-2c.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/a-eng-0128k-aac-2c.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/v-0144p-0100k-libx264.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/v-0144p-0100k-libx264.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/a-eng-0128k-aac-2c.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/a-fra-0128k-aac-2c.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/a-ita-0128k-aac-2c.mp4
ShakaPlayerNetworkFilterRes type:1 uri:https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine/v-0576p-1400k-libx264.mp4
...


VSCode HTML Emmet tab through

VSCode Version: 1.19.3
OS Version: Windows 8.1 Enterprise

Steps to Reproduce:

Use html emmet:  table>tr*10
For me, 9 tr is getting skipped when tabbing through
[Gif](https://i.stack.imgur.com/KPMiC.gif

Does this issue occur when all extensions are disabled?: Yes

@gushuro The 9th tabstop gets replaced with ${0} in this case. Must be a bug in the addFinalTabStop function in the vscode-emmet-helper

resolved in the next insider release.


This page can't load correctly

I'm getting a blue map screen with just the text for development purposes only. And a pop up box saying "This page can't load Google Maps correctly "

Ok, its wierd, but delete the project, re-clone it using git and then try, maybe the config is not correct hence the error


Add support for primer scripts

Custom metrics are executed late in the page load, after most of the initial application code has already run. WebPageTest supports injecting scripts towards the start of the page load, but this isn't guaranteed to always be the first script to execute.
For lack of a better name, primer scripts are guaranteed to be executed before any other 1P code, making them ideal for initializing custom metric telemetry.

[x] Add support to WebPageTest to guarantee that primer scripts are executed first
[ ] Create and document the process for publishing new primer scripts to production

The process should reuse this repo for script development and specify which directory will contain the script or scripts that need to be injected early.
Currently, the main use case is to initialize observers on JS APIs so that we can report usage later in the custom metrics. Without this, we're limited in what we can measure about what JS is actually executed. Regex parsing can tell us what code is on the page, but not what's executed. Blink feature counters (ie chromestatus.com and the blink_features table) do tell us what's executed, but we're limited by what features have been instrumented in Chrome. This gives us the ability to not only detect whether APIs were used, but how.

Agent support has been added and the agent instance templates have been updated to automatically populate the script injection from inject-dist.
@rviscomi feel free to open this if you want to create more documentation than the readme that is currently in inject-dist but the functionality is live (and the webpagetest.httparchive.org instance was also updated to populate the injection scripts from here).


Can an example with a Linux NVA be added?

I've tried to follow the instructions to the best of my ability, but I must be missing something key. Can you add a Linux-based example?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5cc61595-d1ea-d72b-bef8-52e7b7838a14
Version Independent ID: 6df6127e-bf72-eb63-82c2-a132a6576add
Content: Route network traffic - tutorial - Azure portal
Content Source: articles/virtual-network/tutorial-create-route-table-portal.md
Service: virtual-network
GitHub Login: @KumudD
Microsoft Alias: kumud

@NeverOddOrEven Thank you for your feedback . We will review this and see how best we can improve upon this document . If something is not working for you we will try to help you and in case it requires deeper troubleshooting we will help with alternate support options.

@NeverOddOrEven , may I know on which step you are stuck? We have a doc with Linux NVA example that is deployed using Azure CLI as below:
https://docs.microsoft.com/en-us/azure/virtual-network/tutorial-create-route-table-cli
You have to enable IP forwarding on your NVA VM as described below:

If you have the NVA already created, you can run the below command to enable IP forwarding on your NVA VM:
sudo sysctl -w net.ipv4.ip_forward=1
Then make sure you have traceroute installed on your private and public Vms:

And then test the connectivity using traceroute.
Kindly let us know if the above helps or you need further assistance on this issue.

@NeverOddOrEven , I'm following up on my previous comment. Kindly let us know if the above helps or you need further assistance on this issue.

@NeverOddOrEven , Since we have not heard back from you, we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply and we will gladly continue the discussion.


Mid-point slider when auto on.

Consider leaving the midpoint slider drawing even when auto-mid-point is selected... and only 'auto' set it when a change to the black/white points are made. It could even remain editable/moveable if we do it like this. Additionally there would be feedback for what it's actually doing instead of just hiding it.

Implemented in 288ee381b86594accc7a74003d1d99ad6098c1f9


Fix difference between real and displayed value in backlight module

Fix #1180.
WARNING :warning: :warning: : This PR is not only a bugfix, it also add a new feature in polybar :arrow_right: udev meta module.
As explained in #1180. Inotify event aren't guaranteed to work on sysfs (/sys/ /proc/ /dev/ …). So we can't use inotify to watch in theses directories. (citation of the man page below)

Inotify reports only events that a user-space program triggers through the filesystem API. As a result, it does not catch remote events that occur on network filesystems. (Applications must fall back to polling the filesystem to catch such events.) Furthermore, various pseudo-filesystems such as /proc, /sys, and /dev/pts are not monitorable with inotify.

So as the man said, the filesystem can be polled to catch such events, but there is an API to monitor device :arrow_right: udev.
Since udev is quite "standard" among linux distributions and freebsd, I don't think this dependency will cause any problem.
If polybar uses this API, it could be easy to solve #469 #839 #1046 #1181 that may be linked to the aforementioned problem with inotify.
EDIT: To fix the power problems, it is more UPower that should be used (with dbus) sorry my bad.

I will fix this without using UDev.

We may be able to use this udev implementation in other places in the future ;)

We may be able to use this udev implementation in other places in the future ;)

Yeap, but we will need to separate OS implementation since FreeBSD doesn't support UDev (we must use devd).
But using UDev and devd may should several problems in polybar.

Once we have a solid interface for separating data collection from the part that formats it (#1529), we could tackle this.


[SPARK-16600][MLLib] fix some latex formula syntax error

What changes were proposed in this pull request?
\partial\x ==> \partial x
har{x_i} ==> hat{x_i}
How was this patch tested?
N/A

OK, especially if you've had a search for other similar latex issues. It probably doesn't even need a JIRA but OK.

Test build #62460 has started for PR 14246 at commit 127a428.

Test build #62460 has finished for PR 14246 at commit 127a428.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62460/
Test PASSed.

Merged to master, and again to 2.0 being strictly a minor doc fix.


Sync 6.1.0

Tested by:

Running code locally, verified with authentication
Verified metadata endpoint (should send oauth details for R4)
Tested by running DSTU2, DSTU3 and R4 version for the code.
Checked consent and search narrow interseptor


[BP-1.7][FLINK-10773] Harden resume externalized checkpoint end-to-end test

Backport of #7018 for release-1.7

+1, LGTM.


solution to max-level-sum-bin-tree

Solution to the leetcode problem 1161.
I have used the approach of traversing through the tree using Breadth First Search and whenever we go to another level, the  sum of that level is stored in an array. We then find the maximum value of the array and return the index of that value incremented by 1 i.e. the level.
All test cases have been passed using this particular solution.
P.S : This is my first PR and hope the solution is good. Please feel free to let me know if I did something wrong and I need to do it better.
Thank you

Can Someone help me on this Error:
Makefile:16: recipe for target 'test-leetcode' failed
Error: Process completed with exit code 2.
It seems All test workflow run has failed.
My solution is perfect on Leetcode and passes all the test case. I am new to Open Source Programming and this is my first PR.


Differences in de novo and decomposed solution

Hi,
I ran sigProfilerEXtractor for 5 samples and observe three signatures showing up. I had following questions:

Can we turn off the discovery mode and only match with existing signatures ?
The activities.txt in denovo solution folder and decomposed folder in selected solutions vary a lot. For example in the denovo solution the activities are as follows
samples	CNV48A	CNV48B	CNV48C
P037Liv1FF	687	0	0
P037Liv2FF	586	0	0
P037Lym1FF	416	66	21
P037PanFF	0	0	379
P037PerFF	536	72	0
P037PriFFPE	0	1727	0
In deconvoluted they are as follows
Samples	CN4	CN7	CN20	CNV48A	CNV48C
P037Liv1FF	0	0	0	687	0
P037Liv2FF	0	0	0	586	0
P037Lym1FF	0	0	84	419	0
P037PanFF	0	0	0	0	379
P037PerFF	0	0	0	608	0
P037PriFFPE	406	0	657	664	0

For example, in sample P037PriFFPE why do we see only CNV48B in denovo and CNV48A and CNV48B in deconvoluted, somehow these activity plots do not match ? Please let me know, I might be missing something fundamental in the extractor method here.
Thanks
Pushpa

Dear Pushpa,
Thanks for your interest! Regarding your questions:

If you prefer to assign known reference signatures to your samples instead of extracting de novo signatures, I recommend you to use our new SigProfilerAssignment tool (using cosmic_fit analysis).

Decomposed and de novo activities are expected to be different since, in the first case, you are using known reference signatures to reconstruct your samples. In contrast, novel extracted signatures from your data are considered for the de novo activities. Regarding your particular example, CNV48B is decomposed into CN4, CN7 and CNV20. Also, interestingly, it seems that there is no decomposition of reference signatures that can accurately explain your de novo extracted CNV48A and CNV48C signatures. This is why you see CNV48A and CNV48C in both de novo and decomposed activities. You can find more information about the decomposition of de novo signatures in the STAR Methods of our recent publication (https://doi.org/10.1016/j.xgen.2022.100179).

Please feel free to reopen the ticket or reach out by email<EMAIL_ADDRESS>if you have further questions.


Changes to the WTForms package leading to unexpected behavior in the tutorial

Not sure if this has been pointed out to you yet or if you noticed, but with version 2.2 of wtforms (see changes and issue #130, the "DataRequired" and "InputRequired" validators will result in the "required" attribute being rendered in form input tags. This results in browser based client-side validation superseding the server side validation. Not a major issue at all, but you might begin to see some comments from people following along with the tutorial or course (specifically at the web forms) step wondering why their login input errors look/behave differently than in the tutorial images.

This was mentioned to me in a few occasions, but was more an oddity than anything else. The people that notice these are those who use Flask-Babel to offer the application in multiple languages, because these client-side popups do not follow language choices in Flask-Babel and always appear in the language of the browser. I believe it is only Chrome that implements these, I don't recall seeing them on other browsers.

superseding the server side validation

While I agree with you on the general comment, it is important to note that this change does not replace server validation, it just runs client-side validation in real-time as the form is filled to provide immediate feedback, but the server-side DataRequired/InputRequired validators still run on form submission.

Ah that is a specific case.

it is important to note that this change does not replace server validation, it just runs client-side validation in real-time as the form is filled to provide immediate feedback, but the server-side DataRequired/InputRequired validators still run on form submission.

I brought It up because at least on 64-bit Firefox 60.0.1 on Ubuntu 18.04  you cannot submit a form if all fields with the "required" attribute are not filled out. That's what I meant by the client-side validation superseding the server-side. Someone going through the tutorial at that stage with this issue would never get to see the effect of rendering the errors in the template, because the browser wouldn't let them submit the POST request without filling out the form completely.
This Issue was just intended to let you know that that for many people the behavior exhibited in the tutorial at that point will be different than what they actually see in their browsers. This change to wtforms occurred only 2 days ago however, so it's fairly recent.
I agree with you that the required attribute should be opt in rather than opt out, but perhaps the developers/maintainers of wtforms grew tired of people asking why it wasn't the other way around.

I have made a small change in chapter 3 of the tutorial to disable browser validation, so that the reader can experiment with the wtforms validators without that interference.


Extend looks for aliases in service providers

Ah, I should have added it to the CHANGELOG, shouldn't I?


Azure Database for storing the embeddings

The page mentioned: These embeddings can be stored locally or in an Azure Database
Please share which Azure Database is good for storing the embeddings.
Thanks!
Mark

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9c542f1c-f19a-5eea-9e98-1543a7352038
Version Independent ID: f190ef2f-fe21-7610-6893-a4d9149435ff
Content: Azure OpenAI Service embeddings tutorial - Azure OpenAI
Content Source: articles/cognitive-services/openai/tutorials/embeddings.md
Service: cognitive-services
Sub-service: openai
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@markx9
Thanks for your feedback! We will investigate and update as appropriate.

@markx9
There are several Azure databases that could be suitable for storing embeddings, depending on your specific requirements. Here are some options:

Azure SQL Database: This is a fully-managed relational database service that provides built-in features for data security, high availability, and scalability. It supports structured data storage and querying using SQL, making it a good choice for storing embeddings as tables with columns for each embedding dimension.
Azure Cosmos DB: This is a globally-distributed, multi-model database service that supports multiple data models, including document, key-value, graph, and column-family. It provides high availability, low-latency reads and writes, and automatic scaling, making it a good choice for storing embeddings as JSON documents.
Azure Blob Storage: This is a massively scalable object storage service that can store unstructured data, such as images, videos, and text. It provides high availability and durability, and is often used for storing large datasets, including embeddings.
Azure Data Lake Storage: This is a highly scalable and secure data lake that can store both structured and unstructured data. It provides low-latency access to data and supports parallel processing, making it a good choice for storing large embeddings datasets.

Ultimately, the best Azure database for storing embeddings will depend on your specific use case and requirements, such as the size of your dataset, the type of data you are storing, and your performance and scalability needs.
We are going to close this thread, if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


cmake error at build googletest

I have any error

How to fix it ?

https://github.com/Lzhiyong/sdk-tools/blob/master/patches/cmake/protobuf_CMakeLists.txt.patch

Please download the Platform Tools 33.0.3, I have updated the build script


create cellpainting test

Additionally, I added outputs to the workflows that didn't have one.

I created a test folder in the pipelines one.
But this WDL could also go in the ./test one. Whatever you think is best :)

I will check it out!

Okay awesome!
I think if anyone would ever use this meta-workflow, then it should be on Dockstore and it should be in the ./pipelines/cellpainting folder.
If you think nobody can really use this meta-workflow, then I would put it into the ./tests folder and not have it on Dockstore.
What do you think?

I am not sure if other people would use it or not.
In practice, you are analyzing a new dataset you would need the output of the projection and illum pipelines in order to design the .cppipe for the analysis pipeline.
In reality, if you are re-analysing the entire dataset without looking at the images, you could be interested in a workflow like this. But again, if you are re-analysing the pipeline you probably just want to re-lauch the analysis and the cytomining. I can't see a reason for re-doing the projection and illum pipeline, unless you deleted it.
So... I would suggest moving it to ./test
But, It should still need to be in Dockstore for us using it when we want to do a full test (we won't be doing that much). We can keep it "hide" or unpublished when we aren't using it. Thoughts?

Okay it sounds like, for now, it's a test rather than a "real" workflow people want to use.
Yeah I agree with storing it in ./test
I would actually keep it off Dockstore.  The way I'll be setting up the tests, I will pull the test WDL from our GitHub repo rather than from Dockstore.


Add support for form arrays

Fixes #396
Currently, it's not possible to add new forms after component init because life hooks functions are being called when a form is created
This PR moves calls to life hooks outside the superForm function
Current issues
The message store is buggy
1- post a form
2- the message is displayed correctly
3- post the same form again
4- the message is cleared (it should be displayed again)
Test page
http://localhost:5173/v2/multiple-forms

Thank you, do the latest commits fix the message problem, or is it something I have to take a closer look at?

Yes, the each key fix resolved the messages issue
Thank you

Nice work, hopefully I can add this to the next release!

I'll be glad to see it in any release if it's stable and doesn't cause any trouble :))

As mentioned in #396, this has to wait until later.


u18chan post count is wrong.

While browsing threads it always shows a really low post number even if there's more.

They have very strange post counting system when posts with replies are not counted as posts which leads to this issue. I'll fix it soon.


refactor: Make sure code in docs is tested

I also added a section to the dev tutotial, about how to extend the docs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I'm running the e2e tests manually against your branch, let's see the result: https://github.com/awslabs/syne-tune/actions/runs/4403996585

One thing is a bit annoying, I don't have a good answer: When I include a part of a file with literalinclude, and then the file is changed, the range may be wrong. It would be great to get some notification to check ranges for included files once they change. But I think this is not easy to do.

End-2-end tests failed for a number of reasons. I am working on this

OK, all end-to-end tests run through now.

One thing is a bit annoying, I don't have a good answer: When I include a part of a file with literalinclude, and then the file is changed, the range may be wrong. It would be great to get some notification to check ranges for included files once they change. But I think this is not easy to do.

Good point, that is a con. But I think the pros still outweigh the cons, so let's try it, and if we run into challenges we can evolve and adapt as needed.


Adding detekt-hint as an awesome tool (https://github.com/Mkohm/detekt-hint)

Hi again @mre :)
I am currently developing a new tool for detection of design principle violations in Kotlin. https://github.com/Mkohm/detekt-hint
It is not awesome just yet, but i would like to know what are the requirements for being so? Does it need a certain amount users?
If it could be included in this list, it would most likely get more traffic and be awesome faster 😬  But i am aware that you probably don't want unfinished products in the list.

Hey @Mkohm,
nice to hear that you're working on a new tool. Looks great from what I can tell.
The rules for addition are quite simple:
Each tool on the list should be

actively maintained (more than one contributor)
actively used (have more than 20 stars on Github or similar impact)
relatively mature (project exists for at least three months)

See the contributing guidelines here.
So it looks like you're not far away from achieving that. 😉 Looking forward to receiving your PR in the near future. ⭐

Sounds good 👌Closing the issue then. Will create a PR when the time is right!


Docs for Archiving Metrics

🚀 Deployed on https://637ea3d7da05a6634b4a4a5e--cozy-fox-0defec.netlify.app


question: in-memory data store

Problem statement
I want to store objects in memory, as opposed externally, e.g. database, and have them available in handlers. The object store should have some locking capability, e.g. sync.Mutex.
What is the recommended way of implementing this?

For example, one type of objects are user-token mappings. Let's say prior to starting a server, I load token-to-principal mapping in in-memory data store and then, using the tokens I authenticate/authorize requests. The user-token mappings would not be in the database, but only in-memory.

have you looked at the KV store example ?
https://github.com/go-openapi/kvstore
By and large this is the same idea, just not using memory but a KV store instead.

@fredbi , I did consider that. I can do it externally with Consul and libkv, but I want in-memory 😃 It is almost the same as storing credentials in mongodb.

take a look here: https://github.com/go-swagger/go-swagger/blob/master/examples/tutorials/todo-list/server-complete/restapi/configure_todo_list.go
it does that for todo's
You can also use go's sync.Map instead, it will be more performant in high contention scenarios

@casualjim , @fredbi , thank you for the pointers! 👍


Skip typedef in services get js doc tags

Skip @typedef and @callback tags when generating quickinfo for a declaration. They are unattached tags that happen to be attached to a particular node because of the way the compiler works.
Skip comment text from jsdocs that contain only @typedef and @callback tags. Again, these are attached because of an implementation detail.

For example:
/**
 * This is skipped in f's quickinfo
 * @typedef {number} N - and this tag is skipped completely
 */
function f() { }
/**
 * This is NOT skipped because of the param tag
 * @typedef {string} S - but this still is
 * @param {S} x
 */
function g(x) { }

The idea is that the comment text of a jsdoc that contains other tags probably describes both tags.
This is big-ish change in a poorly tested area of services (though with fourslash baselines, it's getting better!). I don't think this should go into 4.3.
Fixes #43534

@mjbvz You might have an opinion about this as well.

From editor meeting:

People thought it was a good idea overall.
Might make the heuristic stricter -- require a newline to skip a whole jsdoc, and maybe include the typedef in a jsdoc that has other tags. Need to look at existing usage, especially for the former.
Need to correctly handle @property and @param inside @typedef and @callback respectively. (The parse tree might make this work already, but it needs a test.)

 /**
  * This is NOT skipped because of the param tag
  * @typedef {string} S - but this still is
  * @param {S} x
  */
 function g(x) { }

It seems fairly useful to preserve this typedef in the quick info for g, since otherwise it may be hard to know what S is. If this “local alias” pattern is the majority of typedefs mixed into comments with other tags, I would say it’s fine to preserve them, and try to instead filter out whole doc comments that seem to be purely typedef-like.
The problem is, it may be hard to reason about what doc comments are “purely typedef-like” from their tags:
/**
 * @deprecated
 * @see Some newer type that you should use instead
 * @author Andrew Branch
 * @typedef {Object} Foo
 * @property {string} email
 * @property {number} whatever
 */

function foo() {}

Two alternative strategies for deciding what comments to remove come to mind:

For a given doc comment attached to a node, if that doc comment includes @type, @param, or @returns, include everything in that doc comment in the quick info, because clearly those tags are supposed to apply to some declaration/expression, not just stand alone as a typedef declaration. Any embedded typedefs are probably contextually relevant to that node, or else the author would have written them somewhere else. If the doc comment doesn’t contain any of those declaration/expression-affecting tags, but does contain a @typedef, treat the entire doc comment as a standalone declaration and don’t show any of it in the quick info for the following node.
For a doc comment that contains a @typedef and some other stuff, use a blank line between the end of the comment and the following node to indicate that none of that doc comment should be included in the node’s quick info.

Andrew's point 2. makes the most sense to me.

I'd rather vote for the strategy 1 and avoid significant blank lines.

I looked at my usual corpora [1] to see which strategy is best. I started by considering three options:

Exclude the whole comment for comments containing a @typedef/@callback and no @param or @return tags. (Strategy 1 proposed by @andrewbranch)
Exclude the whole comment for comments containing only @typedef, @callback and perhaps a small set of associated tags.
Exclude the whole comment for comments containing a (OR only) @typedef/@callback if a newline separated the comment from the next element in the source. (Strategy 2 proposed by @andrewbranch)

I found all comments containing @typedef and dumped the list of tags from each comment.
.ts files
.ts files had almost 300 @typedef, about 250 single @typedefs. The remaining typedefs were in 3 projects:

openfin and google-gax used @summary, @desc and @example to explain the typedef further.
protobufjs used a @callback-like variant of @typedef that Typescript doesn't parse:

/**
 * @typedef {function} Typename
 * @param {number} a
 * @param {string} b
 * @return {string}
 * @this {?object} Please don't pass `this` it is the worst.
 */

Also, notably, in protobufjs, the @typedefs are often immediately followed with a Typescript declaration for the same thing. I think the .d.ts files were generated from Closure @typedefs.
.js files
.js files had more than 8000 @typedef, 7500 single @typedefs. The remaining typedefs fell into 4 categories:

embellishments for documentation or structure like @summary, @description, @category, @public, @module, @global, @static, @interface, @example, @throws. There was a lot of variety here.
'local' typedefs that were immediately used with a @param and @return tag (the typedefs are not actually local to the declaration)
@callback-variants like the protobuf example above, which also used @param and @return tags. (and @this, once or twice)

6 projects use the unsupported callback-like typedefs compared to 3 projects that use local typedefs.
Additionally, I observed plenty of unassociated @typedef comments that were not separated by a newline from the next element, though the median next element was another comment.
Analysis
The best rule for excluding typedefs in quickinfo is (1). Except for local typedefs, all typedef-containing comments that I saw were exclusively about that typedef. And, although both local typedefs and callback-like typedefs are rare, it's better to show a few callback-like typedefs than to hide local typedefs that were intentionally defined in-place. (2) won't work well because there it's too hard to capture the set of associated tags -- we would end up showing any unforeseen variants needlessly. And the data show that (3) is both unnecessary and ineffective.
In the future, if we decide to support callback-like typedefs, then (1) would stop incorrectly showing the callback-like typedefs. The code to implement this wouldn't be large, although I think there isn't much demand.
[1] A full install of Definitely Typed, using @definitelytyped/dtslint-runner to npm install every package inside types/, then find . -iname '*.ts'. The same for the user tests in the TS repo.


Validate updates

As pointed out in https://github.com/elastic/elasticsearch-rails/issues/450 and https://github.com/elastic/elasticsearch-rails/pull/289, the validation doesn't work when you make an update that makes a field invalid.
My knowledge in elasticsearch is very limited, so I am not sure if updating in line 115 works well with the attributes being passed directly in line 126. You might want to pass self.attributes to update instead.

Any priority on getting this to pass CI and merged? IMO, this is a huge flaw in the update_attributes when using the validate: option.

I'm going to close this as it's no longer relevant. We have deprecated and removed the ActiveRecord persistence pattern in version 6.0 of the elasticsearch-persistence gem.
Please consider migrating your app to use the repository pattern instead.


Possible issue with RGBW output from Hue picker

I'm not sure if this is a bug or not but I noticed that when using the hue & saturation picker with output set to RGBW, the maximum value output for any or R, G, B or W, is 153. I would have expected this to be 255. The documentation seems to imply it should go up to 255.

'RGBW color object {r:255,g:255,b:255,w:255} usable for RGBW LEDs experimental feature'

Hi,
sorry to answer so late. You know the holidays;)
The problem might be that if you are missing the brightness channel the brightness will stuck at the brightness of the initial color set or the last color received. If you select HSV or HSL you should get your selected H and S value,
Try to set the initial color to white, or send 255,255,255 as initial value. Or (much better) add the brightness control to complete the color model.

Hi,
Adding a brightness (value) slider worked. I now get up to 255 on each of the RGBW values being output.
This component is awesome by the way.

Thank you for your positive feedback 🤩
Good to hear that it works now.
If you need to set the brightness from an external control you should be able to set it via
msg.saturation 0 - 100


Custom extras in MediaMetadata not getting populated in MediaMetadataCompat

Version
Media3 1.1.1
More version details
No response
Devices that reproduce the issue
All
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps

client use media3
val mediaMetadata = MediaMetadata.Builder().setExtras(bundleOf("my_custom_key" to "my value")).build()
val mediaItem = MediaItem.Builder().setMediaMetadata(mediaMetadata).build()
sdk use media
android.media.session.MediaController#registerCallback(android.media.session.MediaController.Callback)
android.media.session.MediaController.Callback#onMetadataChanged
MediaMetadataCompat does not contain "my_custom_key"
i found
androidx.media3.session.MediaUtils#convertToMediaMetadataCompat
MediaMetadata extras are not processed

Expected result
I saw this issue has been solved 756, but my problem is exactly the opposite of this one.
Actual result
MediaMetadataCompat does not contain "my_custom_key" in onMetadataChanged method
Media
Not applicable
Bug Report

[X] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

Fix was submitted to the main branch 6df2408.


Task suspending itself can remove itself from termination list

Describe the bug
Race condition on system with multiple processors. If  TaskA requests to vTaskDelete(taskB) and taskB is currently blocked on taskENTER_CRITICAL() in vTaskSuspend(0), taskB will remove itself from the termination list and put itself on the suspendedTaskList thus never actually getting deleted when IDLE comes around.
Target

Development board: custom
Instruction Set Architecture: xtensa-esp32
IDE and version: n/a
Toolchain and version: xtensa-esp32-elf-gcc

Host

Host OS: WSL
Version: 1

To Reproduce
Seen using pthread implementation on ESP-IDF v4.4
pthread_join() uses this excerpt
        if (wait) {
            xTaskNotifyWait(0, 0, NULL, portMAX_DELAY);
            if (xSemaphoreTake(s_threads_mux, portMAX_DELAY) != pdTRUE) {
                assert(false && "Failed to lock threads list!");
            }
            child_task_retval = pthread->retval;
            pthread_delete(pthread);
            xSemaphoreGive(s_threads_mux);
        }
        vTaskDelete(handle);

pthread_exit() uses this sequence:
    xTaskNotify(pthread->join_task, 0, eNoAction);
    xSemaphoreGive(s_threads_mux);
    vTaskSuspend(NULL);

If the spawned thread (taskB) calls pthread_exit(), the pthread_join() task (taskA) wakes up and attempts to delete the joined thread. If taskB is on one core and taskA is on the other, it is possible that taskB is at taskENTER_CRITICAL() in vTaskSuspend() when taskA via vTaskDelete()  puts taskB on the xTasksWaitingTermination list. When taskB gets access to the critical region, it calls uxListRemove() thinking it is removing the task from the ready/delayed list when it actually ends up removing itself from the xTasksWaitingTermination list.
taskB is then put on xSuspendedTaskList and becomes a zombie thread from the applications point of view.
Expected behavior
Task should be deleted when requested. vTaskSuspend() needs to verify that the task being suspended is not on the termination list. If it is, then the code which removes it from ready and puts it on the suspended list needs to be skipped.

Thank you so much for reporting the bug, I'll let the team know and someone can have a look at the problem.

On an older version of FreeRTOS, this fixes the issue:
`diff --git a/components/freertos/tasks.c b/components/freertos/tasks.c
index 093b3898bd..7b762cc832 100644
--- a/components/freertos/tasks.c
+++ b/components/freertos/tasks.c
@@ -1965,6 +1965,20 @@ static void prvAddNewTaskToReadyList( TCB_t * pxNewTCB,
         traceTASK_SUSPEND( pxTCB );

       /* Check if the task is already marked for deletion.

        * This can happen if this task was waiting to enter the

        * critical section on one core to suspend itself

        * when a different task on the other core made the request

        * to delete it */

       if (listLIST_ITEM_CONTAINER( &(pxTCB->xStateListItem) ) == &xTasksWaitingTermination)

       {

           /* Task was marked for deletion (probably from the other core)

            * Do not put it in suspended list. We need to let Idle

            * on this core clean it up */

       }

       else

       {

           /* Remove task from the ready/delayed list and place in the
            * suspended list. */
           if( uxListRemove( &( pxTCB->xStateListItem ) ) == ( UBaseType_t ) 0 )

@@ -1987,7 +2001,6 @@ static void prvAddNewTaskToReadyList( TCB_t * pxNewTCB,
}
             vListInsertEnd( &xSuspendedTaskList, &( pxTCB->xStateListItem ) );

       curTCB = pxCurrentTCB[ xPortGetCoreID() ];

           #if ( configUSE_TASK_NOTIFICATIONS == 1 )
               {

@@ -2005,6 +2018,8 @@ static void prvAddNewTaskToReadyList( TCB_t * pxNewTCB,
}
#endif /* if ( configUSE_TASK_NOTIFICATIONS == 1 ) */
}

       curTCB = pxCurrentTCB[ xPortGetCoreID() ];

   }
   taskEXIT_CRITICAL();

   if( xSchedulerRunning != pdFALSE )

`

Hello @panduit-mik ,
What version of the kernel are you using?

The version currently in use for ESP-IDF v4.4.5  https://github.com/espressif/esp-idf/releases/tag/v4.4.5

Hi @panduit-mik
You probably are using Espressif maintained FreeRTOS distribution in esp-idf v4.4.5.
FreeRTOS SMP are included in esp-idf v5.0 as a configuration.
In menuconfig
(Top) → Component config → FreeRTOS → Kernel
Espressif IoT Development Framework Configuration
[*] Run the Amazon SMP FreeRTOS kernel instead (FEATURE UNDER DEVELOPMENT)

If TaskA requests to vTaskDelete(taskB) and taskB is currently blocked on taskENTER_CRITICAL() in vTaskSuspend(0), taskB will remove itself from the termination list and put itself on the suspendedTaskList thus never actually getting deleted when IDLE comes around.

The problem you mentioned is addressed in FreeRTOS SMP.
When taskA deletes taskB which is blocked on taskENTER_CRITICAL(), it will set taskB's run state to taskTASK_SCHEDULED_TO_YIELD and requests taskB to yield. If a task's run state is changed before entering critical section, it will enable the interrupt and retry entering the critical section later. Enabling interrupt should cause the core to handle the pending yield request from taskA immediately. Therefore, taskB will be preempted by other task and vTaskSuspend( 0 ) won't be executed. Later Idle task can delete taskB. You can reference prvCheckForRunStateChange  function for more details.

@panduit-mik
We would like to suggest you to use esp-idf version after v5.0 and enable FREERTOS_SMP feature for this problem.
This issue will be closed for now. If you have further question, feel free to reopen this issue.


code for adgm

I see the class SDGMSSL, which by name and code content seems to be the skip deep generative model. I don't see another class for the auxiliary deep generative model. Was that implemented in this repo?

I found the adgm here. https://github.com/ml-lab/auxiliary-deep-generative-models/blob/master/models/adgmssl.py
Not sure why they are are in different repos. But thanks for the code.


[WIP] [vcpkg] add missing implib definitions, fix shared lib extension on mac

(cherry picked from commit 2cddef9541202ecc01ad43036575bc606dc01117)
@cbezault: for faster merging into master. The other PR will probably take some time.

@cenit are the variables IMPORT_LIBRARY_(SUFFIX|PREFIX) actually useable in portfiles or did you just define them for completeness?

I added them because I needed them ;)
may I ask you why splitting it out? they were necessary in the opencl ports, but they are not necessary without those fixes there

may I ask you why splitting it out? they were necessary in the opencl ports, but they are not necessary without those fixes there

My idea of common definitions is all about variables which will most likely be used in portfiles or are expected to be helpful but are not yet used. On upgrading ports the new variables can then be used to improve the portfile and maybe get rid of some target dependent if control structures making the portfile shorter.


KDC hosts with ports are parsed as URIs which confuses the client

Describe the bug
If you pass a hostname that includes the port the config is parsed as a URI, which causes all transports to fail to parse.
To Reproduce
client.Configuration.Realms["REALM.COM"].Kdc.Add("aaa.realm.com:88");

Expected behavior
Should be treated as a regular SRV record. Suggested fix is to also check if Uri.TryCreate succeeds and kdc starts with http:// or https://.
https://github.com/dotnet/Kerberos.NET/blob/8c254ce2a847248ae4257595e3162212397e4f01/Kerberos.NET/Client/Transport/ClientDomainService.cs#L177-L185
Additional context
https://github.com/dotnet/Kerberos.NET/issues/220

It turns out the root cause of why the tests didn't catch this is because all the tests use IP:Port instead of Host:Port.


Fix incorrect numberings in DG

Codecov Report

Merging #279 (9fd3d26) into master (38b24f1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #279   +/-   ##
=========================================
  Coverage     72.78%   72.78%
  Complexity      754      754
=========================================
  Files           105      105
  Lines          2436     2436
  Branches        325      325
=========================================
  Hits           1773     1773
  Misses          537      537
  Partials        126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b24f1...9fd3d26. Read the comment docs.


Docs state package is at version 5.x when the latest release is showing as v4.6.1

I've been trying to update dependencies on a project and found a discrepancy between the documentation and the available packages. In the docs for single-spa-react, the version tag eyebrow at the top reads as "version 5.x". Is there a package that I'm missing or is this referring to something else? https://single-spa.js.org/docs/ecosystem-react/

Closing due to inactivity and because the answer has been sufficiently answered.


Fix default kubeletPort in docs

Can one of the admins verify this patch?

Thanks for the fix @luksa!
@cadvisorJenkinsBot: ok to test


Removed unnecessary useState

Closes #6559
Fixes Issue

Done improvements as per suggested in the issue.

Changes proposed

Removed unnecessary useState hooks.
Introduced variables instead of the useState hook wherever applicable.
Clustered useState hooks at one location for finding them quickly.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Note to reviewers
Thank you for providing me with the opportunity to contribute.

Sending a new PR with the requested changes.

The lock file still seems to be there with your changes.
I made a video on how to remove your changes https://youtu.be/YUHS5Ana7Jw
You probably used npm install, but you should use npm ci you can learn more in this video here and also how to fix it https://www.youtube.com/watch?v=jHkIXYVpMTo

Watched both the videos, and they were really helpful, thank you for helping me learn these things and letting me contribute to the repository, looking forward to learning and contributing even more.
Thank you!

Thank you 👍

It's my pleasure!
Open for more contributions.

Awesome! More contributions welcome 🎉 💯


Avoid purging Revisions in use by third-party packages

Fixes #10678
Rework of previous PR #10759
Added a test to ensure Revision instances having a ForeignKey with on_delete=models.PROTECT pointing to it are not purged while ensuring the other Revisions are purged without throwing an error.
Please check the following:

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[x] For Python changes: Have you added tests to cover the new/fixed behaviour?
[x] For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

Thanks for looking into the PR Stormheg! I don't think the reviews are harsh in any way and I have to thank you and Sage for taking the time to periodically review them 😅. The feedback has helped me learn more and understand some things better. I'll look into the new feedback and make changes accordingly 🙌

@Stormheg - it looks like changes have been made, would you be OK to do another review?

@NXPY123 I've credited you as 'Neeraj P Yetheendran' (from your GitHub profile).
I see you are already listed in contributors.md as 'Neeraj Yetheendran'. Hope that small difference is okay!


Postcodes with a single inner number are reported as valid

Example: EH1 JS
All postcodes with the format \w{2}\d\w{2} are currently accepted as valid.
@billinghamj

It seems EH1 JS is not valid but EH1JS is. Not sure if \w{2}\d\w{2} is entirely valid since \w also includes underscore and numbers but I think I get your meaning
I think this is definitely a false positive we're able to eliminate with some tighter regex'ing
I made a first pass at it here by amending the way outward codes are handled: https://github.com/ideal-postcodes/postcode.js/pull/8
@billinghamj would be great if you have time to take a look (-:

Will take a look when I get a chance. We're just implementing this in one of services, and Jack noticed the issue! :)

@jFransham This can be closed. Was fixed by #8.


[Dribblish] Fade-in on buddy-feed

How do I get the fade in from the playlist-list on my buddy-feed like this:

(changed this in dev-tools, don't know how to do it in user.css tho)

Please use Discord or reddit for suggestions. Use GitHub only for reporting issues.

https://github.com/morpheusthewhite/spicetify-themes#troubleshooting


upgrade pinned builds to clang 10 & boost 1.72

Change Description

The state DB layout has changed in develop: any post-2.0 release will require users to migrate via a portable snapshot. Might as well take the opportunity to bump our pinned compiler environment.
Upgrade clang from 8.0 to 10.0. Upgrade Boost from 1.71.0 to 1.72.0. Non-optimized replay performance shows a marginal but measurable performance gain. It's nice to have the latest anyways, right?
Also took this opportunity to migrate our clang/llvm clone to the official GitHub monorepo.
This is being left as draft until clang 10.0 final is released, and documentation may need adjustment too.
Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

I had @emorybarlow run our automated benchmarking suite and it shows a 2% improvement.


Add permissions to team views.

@justinvdm Ready for review.

@justinvdm I've addressed your comments. Ready for another review.

:+1: looks good!


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1094

Questions ?
Please refer to the Backport tool documentation