fix: searched ens name are not retrieving data

Bug Report
Swaplace version
230827e
Current behavior

wrapper.ens.eth

Expected behavior
Expected the right user name ens address & retrieve the right data from the user.
Steps to reproduce
Search an ens name and check if the tokens are the same, also in the OfferSummary are not the same name.
Related code
OfferSummary.tsx
SearchBar.tsx

I think this error is related to the end point we are using, it is public and free so it might not be 100% synced with the correct ens state

@0xneves  I'm checking this issue and it looks like we are using the lib "web3-eth-ens" import { ENS } from "web3-eth-ens" to retrieve the ens name address from the user.
I opened this draft PR to show the difference between the getOwner & getAddress..
Let's see it.

Closed by #384

Reopened the issue because the solution in #384 still not working.

Because of this problem we're creating an new issue to remove the .ens from the dApp to works fine without any difference-name-surprise


Minor update

Added "for" in the sentence to make it sound/read well.

@naveedkharadi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Enable SUPPORT_VOLUME_STEP for older Pioneer receivers

Description:
Older Pioneer models like the Pioneer VSX-528 require SUPPORT_VOLUME_STEP to control the volume.
Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[X] I have followed the development checklist

Thanks for the review @springstan. What is needed to get it merged?
Thanks.

@Cloudenius you could update the docs to include an example for the Pioneer VSX-528 model to show that even these older versions work with this integration :)

@Cloudenius you could update the docs to include an example for the Pioneer VSX-528 model to show that even these older versions work with this integration :)

Done! See doc PR attached. I must say that the telnet connection isn't always reliable and I have to disconnect it from power every couple of weeks to get it to work again. Otherwise it will report that the telnet connection was closed. But the app has the same issues, so it seems like an issue with the device itself.


Fix SVGTransform

firstChild doesn't necessarily return a node element (often the case
in SVG files).

Replaced firstChild with getElementsByTagName.

Added test to avoid regressions.

:+1: Thanks for adding the tests too! :dancer:


Unable to import Pegasos module (because atleast2d_or_csr is absent)

Hi Ejlb,
I' d like to use your pegasos library but when I try to import pegasos in python I obtain an ImportError which is the following:
Python 2.7.9 |Anaconda 2.2.0 (64-bit)| (default, Mar  9 2015, 16:20:48)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
Anaconda is brought to you by Continuum Analytics.
Please check out: http://continuum.io/thanks and https://binstar.org

import pegasos
Traceback (most recent call last):
File "", line 1, in
File "pegasos/init.py", line 18, in
from .models import SVMPegasosBase, LogisticPegasosBase
File "pegasos/models.py", line 20, in
from .base import PegasosBase
File "pegasos/base.py", line 21, in
from sklearn.utils import atleast2d_or_csr
ImportError: cannot import name atleast2d_or_csr

I'm using the current version of scikit learn (0.16.1) in which atleast2d_or_csr isn't available.
Please would you have an idea or a solution ?
Thank you in advance,
Chris

use check_array instead.

pip install --user scikit-learn==0.13.1


Typings?

I'm working on some typings for this as we'll likely be using it for our project.
However, I'm just wondering whether you've started the typings already or whether you're interested in creating Typings for this to support Typescript?

No this would be great.. I will be needing this as well shortly.

Looking to utilize this in my project as well, any news on the typings for this :)?

We are in progress internally here but are still aways out.

Hello. I was curious if there is an update on the typings?

Some but not as much as I would have liked.  It will be in earnest in the next few weeks while we ramp up our dashboard project.
From: Jacob Askew<EMAIL_ADDRESS>Reply-To: Raathigesh/dazzle<EMAIL_ADDRESS>Date: Tuesday, October 23, 2018 at 6:14 AM
To: Raathigesh/dazzle<EMAIL_ADDRESS>Cc: Peter Crossley<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Raathigesh/dazzle] Typings? (#52)
Hello. I was curious if there is an update on the typings?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/Raathigesh/dazzle/issues/52#issuecomment-432240127, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAIqKTjzIgsf36rysNfCNWTbivHSdgHqks5unxYigaJpZM4UiIUR.

Sounds good. If I am able to get to it before y'all, I will try to open a PR for it as well.


Add ignore array order for proxy

Description of changes:
Adding "insertionOrder": false to proxy properties, so cloudformation can ignore order when comparing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Added the change for target-group

target group changes included!

Great!


add ehazlett and johnstep to random_assign

congratulations @ehazlett and @johnstep \o/

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "add_ehazlett_and_johnstep_random_assign" git@github.com:vieux/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354462544
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

hmf accidentally hit the "update branch" button, I'll fix when I'm at my computer. Hate that button

there. fixed it :smile:


EdgeDriver cannot execute javascript commands

Current implementation of EdgeDriver lacks ability to use JavascriptExecutor.
This prevents methods like jsClick, scrollIntoView, and highlight from functioning.

Fixed in 10.586.


uppercase vs lowercase extensions

For some census files where they were messy with the extensions , I get this error
$ ./redatam downloads/CP2001BOL/Cp2001BOL/BaseOriginal/CPV2001.dic downloads/CP2001BOL/Cp2001BOL/BaseOriginal/open-redatam-dic
Opening dictionary file...
terminate called after throwing an instance of 'std::ios_base::failure[abi:cxx11]'
  what():  Error: Failed to open file: downloads/CP2001BOL/Cp2001BOL/BaseOriginal/CPV200068.rbf: iostream error
Aborted (core dumped)

In that case, the file ends with .RBF, not .rbf

fixed in 3b875d1


Unable to set "standalone" boolean attributes

1. Description
I am unable to set "standalone" boolean attributes. Getting the value of these attributes results in an empty string. Also setting such attributes is only possible by using a string. While this is not false because only the presence of the attribute matters, I find it a bit odd to use empty strings to set such attributes. For example checked will be true for <input type="checkbox" checked /> and <input type="checkbox" checked="" /> and even for <input type="checkbox" checked="false" /> because only the presence of the attribute matters.
See also: Boolean attribute (HTML).
2. Exception
There is no exception.
3. Fiddle or Project
https://dotnetfiddle.net/r7jvX7
4. Any further technical details
Creating Attributes.Add(string name, bool value) and SetAttributeValue(string name, bool value) could help differentiate between standalone boolean attributes and attributes with a boolean string to allow creating standalone boolean attributes.

HAP Version 1.11.53
NET Version 7

It is possible to set a value-less attribute, however it is a bit awkward and unintuitive as HtmlAgilityPack is not providing a simple convenient API for that.
Basically, currently you gotta do something like this:
static HtmlAttribute SetNoValueAttribute(HtmlNode element, string attributeName)
{
    var attr = element.Attributes[attributeName]
        ?? element.Attributes.Append(attributeName);

    attr.Value = null;
    attr.QuoteType = AttributeValueQuote.WithoutValue;
    return attr;
}

SetNoValueAttribute(iframeNode, "allowfullscreen");

It is possible to set a value-less attribute, however it is a bit awkward and unintuitive as HtmlAgilityPack is not providing a simple convenient API for that.

Thanks for your response and code example.
@JonathanMagnan Even if it is possible to create such value-less attributes, can we discuss about my suggestion to allow attributes to have a boolean value?

Hello @jekru ,
What exactly are you expecting from your proposed method Attributes.Add(string name, bool value) to do?

One solution, meanwhile, is surely creating an extension method on your side using @elgonzo .
From what I understand, you would like it to do this answer

  but having a method with a bool parameter that do nothing will add more confusion than anything else as someone not knowing this issue would expect that it will generate the solution 2 or 3 depending of the value.
Best Regards,
Jon

I would expect that Attributes.Add(string, name, bool value) respectively SetAttributeValue(string name, bool value) would result in

 (when using "checked" as name and true as value). But you are right, this could let to confusion because someone could interpret a boolean value to result in

.
The only problem I see is that there is no way to identify value-less attributes. Here is an example where I would expect null as Value and AttributeValueQuote.WithoutValue as QuoteType:
using System;
using HtmlAgilityPack;
using System.Linq;

public class Program
{
	public static void Main()
	{

		var iFrame = HtmlNode.CreateNode(@"");
		var checkedAttribute = iFrame.Attributes.First();

		// Result is: Value: ''
		Console.WriteLine($"Value: '{checkedAttribute.Value}'");

		// Result is: QuoteType: DoubleQuote
		Console.WriteLine($"QuoteType: {checkedAttribute.QuoteType}");
	}
}

Hello @jekru ,
Something for sure is that by default, we prefer to keep the current empty with the double quote behavior for backward compatibility. Browsers have different behavior on value-less attributes (firefox in developer mode will do the "empty string" like us while Chrome will keep it without value). Which browser is right? I'm not sure of the answer but keeping being backward compatible in this case is probably the best.

@JonathanMagnan
You made a good point with backward compatibility and I also was not aware that the behavior differs from browser to browser. What about creating a function IsBooleanAttribute() or IsValueLessBooleanAttribute() that only returns true if the attribute is a standard html attribute and defined as boolean attribute f.e. "checked" or it is a non standard html atttribute and is without a value (also not an empty string).


REST API method getTokens limit argument added

Default number of tokens is 100, so the API does not return all tokens on the testnet.

Thanks for this.


refactor verify http collect response status code

What's changed?
refactor verify http collect response status code
support api monitoring can custom update success status code in web ui

Checklist

[x]  I have read the Contributing Guide
[x]  I have written the necessary doc or comment.
[ ]  I have added the necessary unit tests and all cases have passed.

should update h2 database with sql:
ALTER TABLE HZB_PARAM  DROP CONSTRAINT CONSTRAINT_82;

4xx , 5xx, 3xx, 2xx may better

4xx , 5xx, 3xx, 2xx may better

mayeb hertzbeat is widely used by developers and devops, so they should be very familiar with shell and regex
So maybe 2**will be better?

4xx , 5xx, 3xx, 2xx may better

mayeb hertzbeat is widely used by developers and devops, so they should be very familiar with shell and regex So maybe 2**will be better?

ok, we can support all. haha


Experiments on VOC

❓ Questions and Help
I converted the PASCAL VOC dataset into the format of COCO dataset and trained a new model, but the AP is low (almost zero). Do you have any suggection on how to train RetinaMask with VOC ?

Hi,
According to my understanding, Pascal VOC does not provide instance segmentation annotation. Did you have the instance segmentation for Pascal VOC?
Another way is to use model trained for COCO detection task as the pretrained model.

Thanks for your response. SBD dataset provides the segmentation annotation for PASCAL VOC.


Terminating app due to uncaught exception 'NSInvalidArgumentException',  could not set nil as the value for the key autoSyncThreshold on app start

Your Environment

Plugin version: 6.1.2
Platform: iOS
Device OS version: 18.0.1
Device manufacturer / model: Apple IPhone 15
XCode version: 16.1
Capacitor info (npx cap doctor)

Latest Dependencies:
@capacitor/cli: 6.2.0
@capacitor/core: 6.2.0
@capacitor/android: 6.2.0
@capacitor/ios: 6.2.0
Installed Dependencies:
@capacitor/cli: 6.1.2
@capacitor/core: 6.1.2
@capacitor/android: 6.1.2
@capacitor/ios: 6.1.2
[success] iOS looking great! 👌
[success] Android looking great! 👌
* Plugin config provided to `#ready`:
```javascript <!-- syntax-highlighting:  paste your code below -->
INSERT_YOUR_CODE_HERE
      distanceFilter: 10,
      elasticityMultiplier: 3,
      url: ApiUrl,
      headers: {
        "Api-Key": ApiKey,
        "Access-Token": AccessToken
      },
      desiredAccuracy: BackgroundGeolocation.DESIRED_ACCURACY_LOWEST,
      autoSync: true,
      stopOnTerminate: false

Expected Behavior

App should start as before without throwing an exception preventing the app from starting.
Actual Behavior

App crashes at startup, throwing the following exception:
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '[<TSConfig 0x1072c4e00> setNilValueForKey]: could not set nil as the value for the key autoSyncThreshold.
Steps to Reproduce

Install the plugin
Use BackgroundGeolocation.ready() and place above configuration
Use BackgroundGeolocation.start() after ready promise resolves

Context

Starting the app after installing the plugin
Debug logs

Logs
PASTE_YOUR_LOGS_HERE
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '[<TSConfig 0x1026a8c40> setNilValueForKey]: could not set nil as the value for the key autoSyncThreshold.'


ETTrace error: Error Domain=NSPOSIXErrorDomain Code=61 "Connection refused"

ETTrace error: Error Domain=NSPOSIXErrorDomain Code=61 "Connection refused"
When I enter "ettrace --launch --simulator", it show this error

@sbsetting  How did you solve this issue?

@ahmdyasser is your app running on the simulator?

At first I forgot to install ETTrace package on Xcode, and I see the error message as well.


"could not get source code"

Hello I am getting this error message with a project that uses a native extension I cannot share.
Any idea as to what is going on (exec not being able to load it ?) or what kind of workaround could be used ?

Probably a network error. Probably not related to pytest-codeblocks, and impossible to debug here without further details.

Probably a network error. Probably not related to pytest-codeblocks, and impossible to debug here without further details.

Network error ? Could you elaborate ? I'm not using network in the code.
Other specificity, some code uses the PYTHONPATH to be loaded.
If you don't have a clue no problem. I understand it's hard to debug when I can't provide a minimal example...

Yeah, there's no way for me to debug here. Feel free to reopen if you can provide a minimal example.

hello @nschloe I used a small change locally where I first compile the code to bytecode and then exec that and fixes my issue.
Is it ok if I submit the patch to your project ?

I don't know what you mean exactly. You can just submit a PR and then we'll know what we talk about.


Create dev environment for ingest

Split between ingest and upload service

some resources have to be manually done and CD has to do the policy creation that relate to the upload service. So there is a dependency here on the upload service.


Usage from China requires different API URL

If using Google Maps APIs from China a different URL should be used, see https://developers.google.com/maps/faq#china_ws_access.
https://maps.googleapis.com should be replaced with http://maps.google.cn, since the regular one is not accessible from within China.

@emilpalsson I did a little modification to this logic here https://github.com/istarkov/google-map-react/pull/530/files#diff-4ed1519a6d20f85caa4cc6b843258ecbR6 I tested it and it seems to be working but if you could double-check that would be rad, thanks.

@itsmichaeldiego Sorry for the late response. The change looks good! However, there is a problem. When serving from China, http should be used - not https. The current version does not work from China.

"When serving content to China, replace https://maps.googleapis.com with http://maps.google.cn."
https://developers.google.com/maps/documentation/javascript/localization#GoogleMapsChina


Typing behavior difference compared to native keyboards

I received this from a beta tester of the new KeyboardKit app:

OK, I was trying to figure out why I was having trouble typing quickly on your keyboard. The reason is the difference in how keyboardkit handles multiple key presses compared to the system keyboard. Specifically, if you press and hold one key down and without releasing it, press another, the system keyboard inserts the first keystroke, even though you still haven’t lifted your finger off it, but KeyboardKit loses that keystroke.

That is a great find that should be adjusted.

This is quite hard to achieve with the current gesture model, since the gestures don't know of each other and there is no state for the currently pressed keys.


Default timetrace list records to the current date

This sets the default date of timetrace list records to the current date to make it easy to just get the records from the current day.

@dominikbraun
Added it to the readme and refactored it a bit by just setting the value to 'today' instead of passing a new date.


🐛 Incorrect Test IDs for Receiving Stake Address and Amount Error message in Treasury Proposal Creation Form

Area
Proposal Pillar
Domain
dev-sanchogov.tools
Which wallet were you using?
No response
Context
During a review of the failing test for a proposal-related report, it was discovered that multiple receiving stake addresses and amounts can now be added in a treasury proposal. This change likely affected test IDs.
Currently, the test IDs for error messages of receiving stake addresses and amounts are not correct. The error message test IDs are the same as their corresponding input field test IDs
Previously used test IDs for error messages:

receiving-address-text-error
amount-text-error
For the new multiple-input scenario, it would be better to append the index of the input to the test ID to ensure uniqueness and clarity.

Steps to reproduce

Connect the wallet.
Navigate to the proposal creation form.
Select the Treasury Proposal option.
Input invalid values for the amount and receiving stake address.
Observe the test IDs of the error messages for receiving stake addresses and amounts.

Actual behavior

The current test IDs of the error messages are the same as the input field IDs. i.e :  receiving-address-${index}-input and amount-${index}-input

Updated test ids of error message for receiving stake address and amount

Previous test ids of error message for receiving stake address and amount

Expected behavior

The test IDs for error messages should be unique for each input.
Suggested format for test IDs:

receiving-address-${index}-text-error
amount-${index}-text-error

@nebojsact, you have updated the test ID for the error message, and that looks good. However, you also updated the input field test ID and made it the same as the error text test ID.

@nebojsact , Actually, I was referring to the receiving address and amount input fields. The test IDs for the error text are fine, but you also changed the test IDs for the input fields.
Suggested Test IDs:

Input Fields:

receiving-address-${index}-input
amount-${index}-input

Error Text:

receiving-address-${index}-text-error
amount-${index}-text-error

The test IDs are now correct:

Test ID for input fields:
receiving-address-${index}-text-input
amount-${index}-text-input

Test ID for error messages:
receiving-address-${index}-text-error
amount-${index}-text-error

CC: @bosko-m


Fix typo in command listing

Codecov Report

Merging #613 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   37.99%   37.99%
=======================================
  Files          50       50
  Lines        3277     3277
=======================================
  Hits         1245     1245
  Misses       1830     1830
  Partials      202      202

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5066a5e...9bdb2b5. Read the comment docs.

@simonwydooghe Good catch! Thanks for your contribution 👍


Feature/demo-application: demo application with local development setup

Summary
Added a demo application with local development setup.

Changes

Added a .net core web application with C#
Added keycloak login
Added to docker compose for local development
Added production docker file for prod build

Screenshots (if applicable)

Notes

Looks great to me. Great job adopting new technology. I learned a lot by reading your pr :)
Just one note, I noticed there are some lib and dist files added to the repo. I'm not familiar with the dotNet build system, please just make sure unnecessary build files are gitignored. Thanks

Great catch. I copied the .gitignore from from a existing dot-ent project that had lots of stars. But i can take further into it!


Show local currency amount in transaction history

Use rate at time of transaction, not real-time exchange rate.

Save the display currency amount in the database as well when sending funds.


[Feature] Support the php 7.1 iterable type hint as a unique token kind

Hi,
This PR implements the feature suggested in #191
There already was a tests using iterable, for now I reused it.
If you want a dedicated test that's not a problem, I will simply need a few information:

Should I remove the iterable type from the current arrowFunctionUnionTypes.php test so that it will not be impacted by the changes ?
Where should I put the new test ? tests/cases/parser71/iterableType.php ?
Is the example provided in the issue enough or do you have something else in mind ?

No objections from me.
Phan continues to work with this change. I haven't tested other applications such as php-language-server, but it doesn't have much special handling for types since type inference isn't a part of php-language-server.
// only references to ReservedWord in php-language-server/src/DefinitionResolver.php
        // TRUE / FALSE / NULL
        // Resolve true and false reserved words to Types\Boolean
        if ($expr instanceof Node\ReservedWord) {
            $token = $expr->children->kind;
            if ($token === PhpParser\TokenKind::TrueReservedWord || $token === PhpParser\TokenKind::FalseReservedWord) {
                return new Types\Boolean;
            }

            if ($token === PhpParser\TokenKind::NullReservedWord) {
                return new Types\Null_;
            }
        }


Class namespaces for Bukkit and Bungee are the same.

This prevents plugins from importing and using both.

I tried using Maven modules, but at the moment it's just not possible for the project i'm working with (it would need a 30% recode in order to work with modules).
Isn't it possible to just make it org.inventivetalent.update.spiget.bukkit for example?


An option to ignore deprecated types/methods

Hi there, amazing project!
I was wondering if you would consider adding an option to ignore types/methods that are marked with ObsoleteAttribute. This way the functionality that is no longer maintained and is already discouraged to use wouldn't affect the coverage results.

I was just about to create a pull request to exclude them by default. Always doing it will be a quick change, but you're probably right that an option is a good idea. If I did that, would it be merged?
https://github.com/tonerdo/coverlet/blob/47206b0ec9cf1a561756c441e44b8eeda7d2dace/src/coverlet.core/Instrumentation/Instrumenter.cs#L384 is the easy part from a quick look.

See #195

#233 and #477 resolved this, thank you @amweiss.


🐛 | Whitespace support in Folder structure

Feature Description
The creation of the playlist has problems if there are spaces in the path.
What functionality would you like to see in your phoniebox?
The Box should play "as normal" if there are spaces in Folderpath/Filename

seems to be related to an outdated MPD DB due to mounting Problems.


Authentication via URL is not working

$url = 'http://bunny:password@<IP_ADDRESS>:15674/api/aliveness-test/%2F';

$guzzle = new \GuzzleHttp\Client();
$amphp = new \Amp\Http\Client\Client();

// 200
dump($guzzle->get($url)->getStatusCode());

// 401
dump((yield $amphp->request($url))->getStatus());

// 200
$request = new Request($url);
$request->addHeader('Authorization', 'Basic ' . base64_encode('bunny:password'));
dump((yield $amphp->request($request))->getStatus());

If this is a desired feature I can try to send a PR if you tell me where it should be handled.

I'm guessing it should be implemented as an interceptor which would check $request->getUri()->getUserInfo() and add it as header?

@enumag That sounds like a good idea, yes.

Should such interceptor be default?

@enumag IMO the interceptor should be enabled by default. See #201 for how I propose doing something similar for following redirect responses.

It should be enabled by default, but probably needs special support for redirects.


Fix first-load scroll on Safari and Firefox

Fixes https://github.com/npmgraph/npmgraph/issues/226

Demo (Safari) ✅

Something's not working right here (still).  If I select the env-paths modules in this graph, it center the view on env-paths as expected:

... but if I then reload the page, it doesn't even come close to it:

This isn't exactly a regression since there's a similar issue on npmgraph.js.org currently.   But if we're trying to fix first-load scrolling... well... we should probably actually fix it. :-/

The other issue you mentioned should be reported/fixed separately

Fair enough... damn it.  😉   Thanks for the fixes!


Added should also be applied to 'Minor' software releases

https://github.com/SystemFiles/GOG/blob/a2e162a1752fbe4452b816f07be52a02077ebb60/command/finish.go#L114

Implemented in BENS-0020


tests: add benchmarks for log.values, log.has(), log.get()

Two sets of benchmarks for log.values, log.has(), log.get().
Interesting results for the log.values benchmark with waves.
~60% drop in throughput from the initial wave (1000 entries -> 2000 entries). By wave no. 3 (4000 entries), it is down ~83% from the initial wave. By wave no. 14 (150000 entries), it starts to level off at ~97% drop from initial wave.
Machine: MacBook Pro (Mid 2012) / 2.6 GHz Intel Core i7 / 16 GB 1600 MHz DDR3
Related: orbitdb/ipfs-log#136

Thanks for the PR @mistakia ❤These are great additions to the benchmarking suite 👍
I was wondering what your idea was to separate the "single entry" test from "multiple entries" (*-plus.js) tests? Would they not work (benchmark) the same (ie. plus benchmark ran with arg 1)?

I made the single entry test first (by quickly cloning the other benchmarks), then wanted another benchmark to see op/s at various log sizes.
Then I never realized that the initial wave of the *-plus.js benchmarks ran with arg 1 are identical to the single entry tests. ¯\_(ツ)_/¯
I think 10 seconds of the initial wave are sufficient to get rid of the single entry tests. If need be, I could add another argument to set the length in time of each wave.

Probably best to close this in deference to #143

Probably best to close this in deference to #143

Makes sense. Feel free to close it when you're ready.


[Feature] azd provision only deploying changed infra

[x] Make sure you've installed the latest version using instructions in the wiki

Output from azd version
N/A
Describe the bug
An amazing feature shipped with azd 1.4: https://devblogs.microsoft.com/azure-sdk/azure-developer-cli-azd-october-2023-release/#azd-provision-is-now-faster-when-there-are-no-infrastructure-changes

If you’ve been using the Azure Developer CLI for a while, you may have noticed that sometimes azd provision takes a long time to complete when it may not need to. The wait time was because, prior to version 1.4.0, azd provision would always reprovision regardless of whether the underlying Infrastructure as Code had changed. In other words, if you ran azd provision multiple times in a row without changing your code, you would have to wait for the same deployment to complete multiple times.

This is great.  But it could be more powerful.  Roughly speaking, when using this feature there are two potential outcomes:

Reprovision all infrastructure
Do not reprovision all infrastructure

There is not a middle ground.  Imagine you're deploying a container app and a Cosmos DB.  In your latest deployment you change one property of the container app.  Ideally you would only reprovision the container app.  Alas, at present, azd will reprovision both the container app and the database.
To Reproduce
N/A
Expected behavior
Ideally, azd would be smart enough to only reprovision the changed infrastructure.
Environment
N/A
Additional context
You can read more about what lead me to raise this issue in this post: https://johnnyreilly.com/using-azd-for-faster-incremental-azure-container-app-deployments-in-azure-devops

Hello @johnnyreilly .  I'm glad to hear you liked that feature!
Your suggestion makes total sense, however, the current azd provision design does not allow such feature.  From azd's current perspective, the infrastructure-as-code is composed by a definition template (either bicep or terraform) and template-inputs and the template is an atomic peace to azd. Azd has no visibility the list of Azure resources inside the template.
There is some work in progress around azd composability which might help for the use case you described. You can see more about it here: https://github.com/Azure/azure-dev/issues/3072
And we also have talked in the past about supporting infrastructure files per service as a way to divide the currently one only infra template into a common template + unique deployments per service. But that's also in the backlog only

Thanks for responding @vhvb1989. The linked issue is interesting.
I've no doubt you've discussed this already, but on the off chance it hasn't come up, I thought I'd throw this into the mix:
My bicep codebase is already modular. I have a main.bicep file which internally triggers deployment of distinct modules for Azure Container Apps / Cosmos DB etc. When deployed, each will result in a separate sub deployment in the Azure Portal with distinct inputs.
I guess I was rather hoping that AZD could work at that level. But from what you've said maybe that's unlikely. Thanks though!

It's a place we want to go, for sure, @johnnyreilly , it is just taking some time.
What makes it a little bit complicated is that, bicep files are first converted to an ARM Json file. The main.bicep and all modules are parsed and combined to build one single json file, which is what azd uses as payload to Azure. Parsing the JSON file to figure the ordering (based on relations) and submitting each deployment happens on the server side. During the process, azd only pulls the progress.
This means that, once azd submitted the deployment, you can stop azd but the full deployment will continue on the server


Fixed installing bug for "1.19","1.18", etc

I couldn't install 1.19, so I fixed the bug.
bug: can't install first of each major version (1.20, 1.19,1.18, etc.), but any subsequent minor version works (1.20.1)
reason: a contains function was used to check for the version number, I just added a "-". Any questions just ask.

Thanks for your contribution


User who added conservation status should be listed as source if there isn't an authority

Currently looking like

at https://www.inaturalist.org/taxa/4777-Gymnogyps. And a rider: updating conservation status should re-index the taxon.

We seemingly don't currently record the user_id that added a conservation status. There's a user_id column in the conservation_statuses table, but there's only 252 records out of 140980 that have a user_id, and they're all Scott. Shall we start to populate the user_id when conservation statuses are manually added? There's not much we can do with the existing statuses that don't have user_ids

Yes, I noticed that we've only recorded Scott too. We should just populate it going forward, but hopefully with #767 in place most people will choose to add a new authority if possible.

This is sort of working, but there's some weirdness with the iNat API, associate loading, and async/await methods that I still don't entirely understand (TL;DR, conservation statuses aren't getting returned with their user, in taxon api responses, even though they are for me locally).

IMO, remaining problem was not well-articulated or reproducible, so I'm closing again.


feat: waku multiconnection

Add more waku nodes to connect to besides the existing one to improve reliability

This is done better in #466


Hosting CLI: Only check requirements update in interactive mode

All Submissions:

[ ] Have you followed the guidelines stated in CONTRIBUTING.md file?
[ ] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

New Feature Submission:

[ ] Does your submission pass the tests?
[ ] Have you linted your code locally prior to submission?

Changes To Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

In deploy command, the function that checks requirements is interactive. Only does the check if the command is interative.

@Alek99 uh oh I wrote the condition backwards, will fix it asap


[Feature] Resident IdP SAML metadata validation

Need a feature to sign the Resident IdP SAML metadata so the external SPs can validate the Resident IdP metadata.
Currently, we don't sign the Resident IdP metadata, so it can't be validated at the SP. As discussed internally we need to sign the metadata and include the signed hash in the metadata. According to the SAML-2.0-Metadata specification, it is recommended that at least the root element of a metadata instance be signed.
We need to sign the Resident IdP SAML metadata returned.

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


7.0.2?

Hey,
is you lib up-to-date?
because i saw there is already a 7.0.2 version of https://github.com/googlei18n/libphonenumber.
i wanne figure out which npm module has the best support of the original google lib.
Thx,
kate

Hi Katharina,
Yes, we update the library regularly. I've just pushed the update for version 7.0.2 and published it to npm. We also provide very straightforward instructions on how to  update it yourself you can you need a more immediate update (a PR is always welcome!). You can check it here: https://github.com/seegno/google-libphonenumber/wiki/Updating-package-dependencies
Unlike other modules, we try to keep the API pristine and keep only what the original google library exposes. You can read more this module's advantages here - https://github.com/seegno/google-libphonenumber#differencies-from-other-forks.
Hope this answers your question!


Remove MaterializationClient factory

looks like tests are failing the server version endpoint needs to be mocked.. probably we need to have both versions..

for sure, but I also wondered what we wanted to do about cases where the materialization server is not yet advertising its version?
currently, None version causes the check to fail like you see in this test. I think this made sense when I first wrote the decorator because I knew that any chunkedgraph server not advertising a version must be <2.15 or whatever it was when I introduced the version API - but in this more general case I'm not sure what it is safe to assume for backwards compatibility

@ceesem it looked like the only methods that had separate implementations for v2 and v3 were live_live_query, tables, and views. The latter 2 im not sure that those are meaningful differences, though.
Here I took the most conservative/dumb approach of just wrapping the entire logic for v2/v3 logic in a massive if/else statement for each of those, I just wanted to make sure I didn't mess anything up there. I also protected a couple of additional kwargs to live_live_query using the decorator.
However, there is obviously a lot of redundant code — would you like me to take a stab at merging them, or would you like to handle it? Or leave as is for now?

@ceesem it looked like the only methods that had separate implementations for v2 and v3 were live_live_query, tables, and views. The latter 2 im not sure that those are meaningful differences, though.
Here I took the most conservative/dumb approach of just wrapping the entire logic for v2/v3 logic in a massive if/else statement for each of those, I just wanted to make sure I didn't mess anything up there. I also protected a couple of additional kwargs to live_live_query using the decorator.
However, there is obviously a lot of redundant code — would you like me to take a stab at merging them, or would you like to handle it? Or leave as is for now?

For views and tables it looks easy - just only look for metadata for Table/ViewManager if V3.

Open to feedback but this is good to go on my end @fcollman @ceesem - I did end up refactoring the ovelapping methods into one with version-conditional logic, but there isn't a ton


Fix FPS calculation on host

This PR improves FPS calculations - as suggested by @alex-luxonis, deque was used and the average FPS is now more reliable.
Running the same command (python3 depthai_demo.py) in this PR printed
=== TOTAL FPS ===
[color]: 35.3
[depth_raw]: 33.1
[depth]: 33.1
[nn]: 32.3

Whereas on main
=== TOTAL FPS ===
[color]: 27.9
[depth_raw]: 27.6
[depth]: 27.6
[nn]: 27.9

What about just counting number of frames that arrive in one second, and then resetting the counter with next second? IMO works well

What about just counting number of frames that arrive in one second, and then resetting the counter with next second? IMO works well

@themarpe I think that the use of deque could help filter out the jitter and show the correct number of FPS e.g. when NN would have 1.5 FPS -deque would show it correctly, whereas the simpler approach would vary between 1 and 2 fps

It's possible to have a good floating point value even as @themarpe suggested, by calculating when the given time was exceeded, with the precise elapsed interval, like:
        tnow = time.monotonic()
        tdiff = tnow - self.prevTime[name]
        if tdiff >= 1:
            self.fps[name] = self.count[name] / tdiff
            self.count[name] = 0
            self.prevTime[name] = tnow

The only advantage of storing every frame's timestamp is we can provide an updated FPS average every frame (from the second frame on). Whether this is good or not (i.e. too hard to read due to frequent updates), is debatable.
Also, counting per second has a slight disadvantage it shows 0 FPS until 1 second elapsed.


Can't include Third-Party-Plugin with styles

Description

Type:  Question

Bug
D:\Users\marvonge\Documents\sandbox\reactGo\node_modules\react-calendar-timeline\modules\lib\Timeline.css:1
(function (exports, require, module, __filename, __dirname) { .react-calendar-timeline * {
^
SyntaxError: Unexpected token .
at createScript (vm.js:53:10)
at Object.runInThisContext (vm.js:95:10)
at Module._compile (module.js:543:28)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object. (D:\Users\marvonge\Documents\sandbox\reactGo\node_modules\react-calendar-timeline\modules\lib\Timeline.js:19:1)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object. (D:\Users\marvonge\Documents\sandbox\reactGo\node_modules\react-calendar-timeline\modules\index.js:7:17)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
[nodemon] app crashed - waiting for file changes before starting...
Steps to Reproduce

clone reactGo
include any third-party-plugin you want which has styles included
Tested with react-calendar-timeline and react-visjs-timeline

Question
How to solve this issue?
Didn't change any webpack files.

You might want to look at this https://github.com/namespace-ee/react-calendar-timeline/issues/72
Basically this happens with libraries that dont use css modules. Happened to me as well with react-select.
https://github.com/reactGo/reactGo/issues/833

We're trying to clean up the project and close issues.
We havent heard back from you so i'll assume it was resolved.
In case you still have an issue, please comment here or open a new one.


How to close or disconnect a socket?

Hi!
Is there any way to close or disconnect an existing socket?
Thanks in advance!

Hei there! I don't really know how this happens, but I actually missed a disconnect method on the Socket struct.  I will add the method and come up with a new version tomorrow!

Yeah, I've already ended up with drop(socket) hack. Will be great to see a new version - thanks in advance for the fix!

Hei, I've just released a new version (v0.2.3) that fixes this issue!


MacOS: App cannot be checked for malicious software

Hello,
On Q Software version 3.2.8 for Mac, on MacOS 11.2.3, the following message is shown when first trying to run the software.

While this can be bypassed via System Preferences --> Security and Privacy --> General --> Open Anyway, it is not ideal.
Thanks

Upvoting this. Would rather not have to adjust my system security settings to install this, if it can be avoided.


Allow users to select the account they want to connect with

It seems that upon connecting to an account, the frontend currently picks the first, visible, account available without letting a user choose another option.
This should be changed to allow for manual selection of the account that should be used.

A sample solution can be found at acala:

Done


Optimisation of component details

Is your feature request related to a problem? Please describe.
No response
Describe the solution you'd like
Optimisation of component details
Describe alternatives you've considered
No response
Additional context
No response

/cib


Could you please apply rainbow indentation to listive?

I've got a rainbow indentation css snippet but it doesn't work with listive :(

Can u share with me which snippets u got? Give me the source as well so that I can credit if I were to implement it

sure, here it is:
https://gist.github.com/GitMurf/5122c0c8405ffa36a03049d9f4434bf4
It looks like this with listive.
live preview:

source:


[BugFix] Fix iceberg sink with null partition

Why I'm doing:
Conversions.fromPartitionString cannot handle null correctly.
What I'm doing:
Add a special branch to handle this.
Fixes https://github.com/StarRocks/StarRocksTest/issues/6734
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

why we can insert null partition?

@mergify backport branch-3.3


Revert "Cut an automatic create-only serializer for eda-server consistency"

Reverts ansible/django-ansible-base#233
Because of requirements beyond the anticipated, this solution has become non-viable to do in DAB to solve the full problem.
The plan is articulated in https://github.com/ansible/eda-server/pull/775, which is that ANSIBLE_BASE_CUSTOM_VIEW_PARENT will be used to make an eda-server-standard base, which will copy this code, and combine with other existing patterns in the code base.
EDIT:
that plan is not implemented in https://github.com/ansible/eda-server/pull/801

This is now ready to merge since the EDA alternative is merged there.

True, this isn't a clear-cut revert, it's a hand crafted one.


Markup for TextInput, like Label

I want to be able to make any part of my text in different colors or style while writing on TextInput
I tried CodeInput and trying to put Label inside TextInput but could not make it work as I want.
I had to add another issue since no one would re-open this one

CodeInput is made for that.
Take a look at :

https://github.com/brvier/MOrg/blob/674b903ed49e9b721b947a7f5d25d78e62378f24/main.kv#L34
https://github.com/brvier/MOrg/blob/674b903ed49e9b721b947a7f5d25d78e62378f24/main.py#L418

CodeInput is made for that.

I tried codeinput but was not able to achieve the results I needed, do you have any tutorial on that? your code is kinda confusing

It seems that the advice you were given was in the first Issue was it wasn't provided by Kivy, but you could implement it yourself. If you think it is worth putting into Kivy, please submit a PR.
Closing as a duplicate of #459.


Component - Cart

[ ] Name
[ ] Quantity
[ ] Increase/decrease quantity
[ ] Delete from cart
[ ] Checkout

Currently we can see what's in the cart (active order) but only because it's been seeded directly in our database

Also we need to make sure that when someone finishes their order the order status changes from OPEN to CLOSED

Chris attempted cart routes but it won't communicate (keeps giving 404 error) - will try again tomorrow

REQUIRETOKEN is giving us a lot of trouble!

Quantity, Subtotal, Total, styling

button links to checkout component


imports mechanism: remove-seed and cosmetics

Changes:

Adding a global remove list that will remove entities from all imports
Refreshed ro_import for the purpose of illustration
Added a way to SKIP import generation during make process
Added a tiny fix for subsets (ODK standard)

See #1942


Configurable keyword case + pretty printer

@sbcgua you should like this

keywords_upper renamed to keyword_case which has a style: upper | lower property
pretty printer will uppercase or lowercase depending on the style

did you try using Enums? https://www.typescriptlang.org/docs/handbook/enums.html
comparing with strings, style === "lower" makes it difficult to refactor and finding references. But I'm not quite sure how/if enums works with the json schema

The editor/type system is smart enough to provide intellisense for the values, but I didn't think of the weaker refactoring support. If you give them string values, the schema will stay the same.

cool, looks better to me 👍


chore: linting and refactoring with scaffolding-cli package

📲 What
Refactor with eslinting.

🤔 Why
Because it was very pythonic.
I know the JSON has changed. But it's good practice to align with: https://google.github.io/styleguide/jsoncstyleguide.xml?showone=Property_Name_Format#Property_Name_Format
🛠 How
More in-depth discussion of the change or implementation.
👀 Evidence
Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR
🕵 How to test
Notes for QA
✅ Acceptance criteria Checklist

[ ] Code peer reviewed?
[ ] Documentation has been updated to reflect the changes?
[ ] Passing all automated tests, including a successful deployment?
[ ] Passing any exploratory testing?
[ ] Rebased/merged with latest changes from development and re-tested?
[ ] Meeting the Coding Standards?

Solves: https://github.com/amido/stacks-webapp-template/pull/214, and https://github.com/amido/stacks-webapp-template/pull/216. Required refactoring with verison updates/


Add consumption from Power BI

@tsikiksr : Thanks for your contribution! The author, @aashishb, has been notified to review your proposed change.

@jborsecnik : Thanks for your contribution! The author, @aashishb, has been notified to review your proposed change.

@jborsecnik : Thanks for your contribution! The author, @aashishb, has been notified to review your proposed change.

@jborsecnik : Thanks for your contribution! The author, @aashishb, has been notified to review your proposed change.

@jborsecnik : Thanks for your contribution! The author, @aashishb, has been notified to review your proposed change.

@tsikiksr & @jborsecnik - please make these edits in the private repo to get them incorporated. azure-docs-pr

@j-martens - when we moved the commits from this PR to the private repo, there were zero changes. So we tracked it down and it looks like @tsikiksr already made these changes in private in this PR https://github.com/MicrosoftDocs/azure-docs-pr/pull/78773. They were merged 9 days ago and should be live already. Thanks.
#please-close


Improve error handling when Deno is missing

Please let me know if I'm overcomplicating things; this is just a quick experiment.
I made some changes to improve the extension's behavior when Deno isn't installed. Here's a recording from my ancient iMac, in which there's no Deno:
https://user-images.githubusercontent.com/73370025/168409263-8b84aefb-1e80-48a8-90ae-33461e38ca97.mp4
Some care needs to be taken in regard to that, if the user clicks Ignore, the extension's activate code won't be run completely.

Love it, this is the kind of stuff that's usually left until last but makes such a difference.


#654 - Fix Layer name is not propagating

Fixed saving namespace into Headline and to layer name
Layer name is created in format: asset_subset, it is extendes by numeric suffix if same subset is loaded multiple times.
Fixed switch asset and update version functionality in Scene Inventory
Switching assets now works properly
Added delete layer by id
Removal of subset in Scene Inventory fixed
Requires reinstall of extension!
Requires:
pypeclub/avalon-core#210
Closes: #654

Works well. even keep non-destructive layer changes


Presence

In Skype consumer, I able to see the presence of a Teams user.  This statement may be incorrect:
Limitations:
Teams users and Skype users can't see each other's presence.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3de87096-6253-ba71-f27a-0b161a36f0e2
Version Independent ID: 8b61b40d-496c-6069-8a60-38a6282e072a
Content: Teams and Skype interoperability - Microsoft Teams
Content Source: Teams/teams-skype-interop.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@danmyhre Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hi @danmyhre As per PM, the statement is correct as is. Team users and Skype users can't see each other's presence. This is not supported. Thanks again for reaching out. @scanum this can be closed thank you.

@danmyhre Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

@scanum might want to have the PM re-check.  In Skype consumer, you can definitely see a Teams user's presence.


ECMPS Reports

Inventory the ECMPS Reports available in 1.0 and determine which are available in 2.0 and which need to be implemented.

These are the reports in 1.0:

File Import Validation Report
Submission Details/Receipt Report
Submission Summary Report
Submission Access Report
Monitoring Plan Printout Report
Monitoring Plan Audit Report
QA/Cert Test Report
QA Cert Events Report
Test Extensions and Exemptions Report
Test History Report
Emissions Summary Report
View PDF Submission Log

Created #6110 to create the submission reports & #6111 to correct the EM report.

Created #6128 for the Diagnostic Report.


L2s don't reorg more often

Describe the bug
Maybe it's just the wording that's wrong or perhaps it makes sense to adjust the logic as well:
https://github.com/safe-global/safe-transaction-service/blob/master/config/settings/base.py#L392-L396
L2s that have shared security with the underlying L1 reorg only if L1 reorgs. With Optimisms Bedrock, this is implied directly because transactions are "attached" to L1 blocks.
Now I've seen this particular line was changed from 50 to 100 because of Polygon. Polygon is considered a side chain with it's own POS, so it makes sense to check reorgs.
But if you wanted to check reorgs for L2, you should be looking at L1 blocks to be safe-safe.
Expected behavior
Monitor L1 blocks? Separate L2 for true L2s and sidechains?
Additional context
I guess the fix is simply to override this default value with something lower for true L2s or consider adjusting the logic to monitor L1 chain.

Hi @InoMurko, first I'm sorry as when I read this issue I wanted to take some time to answer it and then I forgot about it
You are completely right, we are wrongly using L2 naming for SideChains and L2 chains. But I would say at this point is not very worrying, as reorgs parameter is only used to check how many blocks to wait before marking a block as confirmed. This is something internal and blocks will keep showing, so indexing speed will not be affected, it's only that the service will be checking the not confirmed blocks from time to time. Doing a good adjustment can minimize queries to the node (not too much, as we are batching all and retrieving last blocks is a light operation), and we do based on the network (it's a environment variable and we adjust it on production).
Monitor L1 blocks for L2 chains sounds good, but currently we have never had an issue with this so we will not be working on this for now.
Either way, thank you very much for your suggestion and feel free to send us a PR if you have a proposal.


Fix static object destructors being called on gpu selection with X11

Resolves #68322
There is no need to call static object destructors on a child process that is used purely for determining the best GPU to use.

You seem to have typoed your email in your Git identity, so it's not attributed to your GitHub account: https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/68345.patch

Thanks! And congrats for your first merged Godot contribution :tada:

Cherry-picked for 3.6.


Polka lotto

Grant Application Checklist

[ ] The application-template.md has been copied, renamed ( "project_name.md") and updated.
[ ] A BTC or Ethereum (DAI) address for the payment of the milestones is provided inside the application.
[ ] The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
[ ] The total funding amount of the project is below USD $30k for initial grant applications and $100k for follow-up grants.
[ ] The initial PR contains only one commit (squash if needed before submitting your PR).
[ ] The grant will only be announced once we've successfully delivered the first milestone.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Marvin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Issue75 excessive wires

Contains lots of modifications to chisel templates and the way ChiselGenMem works. Instead of breaking a parallelized access into a bunch of individual ports, the ports (w_direct/r_direct/w_xBar/r_xBar).
Also the rewrite rule for FixMod doesn't use the .asBits .asData stuff anymore to reduce the number of nodes in the IR.  It just masks out the appropriate bits with &, which may add a tiny amount of latency but I didn't feel like making a whole new node just for this.  You can change if you want

Maybe I made a mistake but FYI I tried merging this and get these errors:
Memories.scala:365:29: overloaded method value poke with alternatives:
[error]   (signal: chisel3.core.Aggregate,value: IndexedSeq[BigInt])Unit
[error]   (signal: chisel3.Bundle,map: Map[String,BigInt])Unit
[error]   (signal: chisel3.Bits,value: Long)Unit
[error]   (signal: chisel3.Bits,value: Int)Unit
[error]   (signal: chisel3.Bits,value: BigInt)Unit
[error]   (path: String,value: Long)Unit
[error]   (path: String,value: Int)Unit
[error]   (path: String,value: BigInt)Unit
[error]  cannot be applied to (chisel3.core.Vec[chisel3.core.Bool], Boolean)
[error]     c.io.xBarW.foreach{p => poke(p.en, false)}
[error]                             ^

Forgot to update some things for compressWires flag and in the chisel template tests.  Fixed now

Discussed in person, seems good


fix wrong metrics count missing in vision explorer of RAI Vision dashboard for object detection

Description
fix wrong metrics count missing in vision explorer of RAI Vision dashboard for object detection
Several customers are seeing the wrong metrics count missing in RAI Vision dashboard - this was tracked down to extra whitespace added in the generate_od_error_labels methods for linting:
            rendered_labels[_AGGREGATE_LABEL] = \
                f"{sum(image_labels[_CORRECT].values())} {_CORRECT}, \
                  {sum(image_labels[_INCORRECT].values())} \
                  {_INCORRECT}"

The generated json file then had all of this whitespace for incorrect labels:

This extra whitespace at the start of the line caused parsing errors later in the UI code:

This PR fixes the issue and also adds some validation checks in the code.
Checklist

[x] I have added screenshots above for all UI changes.
[x] I have added e2e tests for all UI changes.
[x] Documentation was updated if it was needed.

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bee87b5) 88.84% compared to head (ffede21) 78.01%.

Files
Patch %
Lines

...i_vision/responsibleai_vision/utils/image_utils.py
97.14%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2495       +/-   ##
===========================================
- Coverage   88.84%   78.01%   -10.84%
===========================================
  Files         134       14      -120
  Lines        7737     1360     -6377
===========================================
- Hits         6874     1061     -5813
+ Misses        863      299      -564

Flag
Coverage Δ

unittests
78.01% <97.14%> (-10.84%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


WalletPage and Send redesign proposal

Description:
The wallet page needs a little love to be at the same level as the new designs made by @jbibla. Here's an attached design of my improvement idea:

Balances should display each coin balance and clicking on one of them should redirect to the transactions page with a filter to show all transactions using that coin.
The Send page to make transfers should have the same designs as the Delegation/Undelegation modals.
Happy to hear your thoughts on the subject

It looks beautiful but we have no time for it until we're feature complete.  I'm labelling this wallet2.


How to remove the delay from Invoking module with sending message to listener

Hi,
I have this code where, I'm using 2 edge modules,
1st module has Invoke_method_on_module and send_message_to_output where the module needs to get invoked and send a message,
2nd module needs to receive it using receive_message_on_input.
here is the portion of the code:
async def method_listener(module_client):
        while True:
            print("Module listener")
            method_request = await module_client.receive_method_request("start")
            # Wait for unknown method calls
            # set response payload
            payload = {"result": True, "data": "Received"}
            status = 200  # set return status code
            print("executed method: " + method_request.name)
            print("Payload")
            method_response = MethodResponse.create_from_method_request(
                method_request, status, payload
            )
            # send response
            await module_client.send_method_response(method_response)
            await send_test_message(method_request)
  # send response
    listeners = await asyncio.gather(method_listener(module_client))
    # asyncio.run(await send_test_message(2))
    listeners.cancel()

    # finally, disconnect
    await module_client.disconnect()

async def send_test_message(method_request):
    global module_client
    print("Invoking message to next Module")
    msg = method_request.name
    await module_client.send_message_to_output(msg, "outputmsg")
    print("Done Invoke")

What I need:
I'm invoking the module with an API, and I want the entire process to be completed with 1 invoke (getting invoked and sending message and listening)
What Is happening:
When I send invoke from API once, It is taking 8 - 10 seconds to send msg or to listen in the next module, some where it is taking latency.
But, When I send invoke twice from API (sending Twice simultaneously) then it sends or listens immediately, and there is no latency in the entire process?
##scenario: Sending once API takes 8 seconds but sending twice does the job asap. How?
What I want to know:

How to resolve this?
Is this some logical error or Async programming  nature or is it how azure iot sdk is designed.

Please help me resolve this.

Hi, Anyone got any idea about this please?

Our apologies for not getting to this sooner. We are currently unaware of the cause of the issue, but we are looking into it and hope to have some information in the near future.

Hi @nishad1092, I'm having trouble understanding your question.  What API is taking 8 seconds?  How are you "sending twice simultaneously".?  I don't see you invoking the method named "start" anywhere so I'm not sure how this is involved.

Our apologies for not getting to this sooner. We are currently unaware of the cause of the issue, but we are looking into it and hope to have some information in the near future.

Hi @cartertinney Thnz for the response, Sure, I'll be happy to get this resolved soon.

Hi @nishad1092, I'm having trouble understanding your question. What API is taking 8 seconds? How are you "sending twice simultaneously".? I don't see you invoking the method named "start" anywhere so I'm not sure how this is involved.

Hi @BertKleewein  Im using this api https://docs.microsoft.com/en-us/rest/api/iothub/digitaltwinmodel/service/invokedevicemodulemethod to invoke this module above mentioned, Since Im running this api through postman , I can send it "twice" right, So only when Im executing this api request twice or more, the response is given asap, otherwise for 1 request , response is delayed, I really im not getting why is that?

@nishad1092, @BertKleewein, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey


set error info to the proper handler if it implements the correct method

slaxweb/framework#156

Resolved


Make order's 'partnerID' nullable

This PR makes the field partnerID of s_order nullable and sets its default value to NULL. Previuosly the partnerID was set to an empty string by default, which makes not much sense, since it mapps a foreign key relation to s_emarketing_partner. Furthermore, with the curren HEAD of the 5.2 branch (70b4478d58ebdd145296f2b4c57be18264f403eb), fetching an order using e.g. $this->get('models')->find('Shopware\Models\Order\Order', $orderId); can result in an exception, if the partnerID is set to an empty string:
Missing value for primary key id on Shopware\Models\Partner\Partner in vendor/doctrine/common/lib/Doctrine/Common/Proxy/Exception/OutOfBoundsException.php on line 40

Stack trace:

#0 vendor/doctrine/common/lib/Doctrine/Common/Proxy/AbstractProxyFactory.php(125): Doctrine\Common\Proxy\Exception\OutOfBoundsException::missingPrimaryKeyValue('Shopware\\Models...', 'id')
#1 vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php(2707): Doctrine\Common\Proxy\AbstractProxyFactory->getProxy('Shopware\\Models...', Array)
#2 vendor/doctrine/orm/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php(273): Doctrine\ORM\UnitOfWork->createEntity('Shopware\\Models...', Array, Array)
#3 vendor/doctrine/orm/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php(491): Doctrine\ORM\Internal\Hydration\ObjectHydrator->getEntity(Array, 'r')
#4 vendor/doctrine/orm/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php(165): Doctrine\ORM\Internal\Hydration\ObjectHydrator->hydrateRowData(Array, Array)
#5 vendor/doctrine/orm/lib/Doctrine/ORM/Internal/Hydration/AbstractHydrator.php(147): Doctrine\ORM\Internal\Hydration\ObjectHydrator->hydrateAllData()
#6 engine/Library/Doctrine/ORM/Persisters/Entity/BasicEntityPersister.php(750): Doctrine\ORM\Internal\Hydration\AbstractHydrator->hydrateAll(Object(PDOStatement), Object(Doctrine\ORM\Query\ResultSetMapping), Array)
#7 engine/Library/Doctrine/ORM/Persisters/Entity/BasicEntityPersister.php(760): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->load(Array, NULL)
#8 vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php(462): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->loadById(Array)
[...]

Since that error is fixed by this PR too, I consider this a critical fix.
Besides making the field nullabel, I also changed the code to not cast partnerIDs to strings, but pass the value as it is, when creating an order, which preserves NULL values upon INSERTing.
This PR does not introduce any breaking changes.
Note: This change was first proposed in PR #196, but never merged.

Thanks for your PR.
Could you please remove your changes to the latest.sql file since we do not update this file.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/#/issues/SW-15194.
Please use this issue to track the state of your pull request.

Just to make sure: I changed _sql/demo/latest.sql, which is changed frequently. I thought only _sql/install/latest.sql is not supposed to change, but the demo data should be adjusted.
@janbuecker Can you please confirm, that I should revert my changes in _sql/demo/latest.sql?

Whoops, my fault. Misread that, you're correct :) 👍

Okay, thank you for clarifying 👍

Please note that the error reported in my first comment was caused by a corrupt composer autoloader.php in my shopware system. Nevertheless I think it makes sense to make the partnerID NULLable.

I think we should split up the migrations into 2 files because of process timeouts. We aim for 30 seconds or less per migration. Shops with a large amount of orders may run into issues.
What do you think @bcremer?

After reviewing, is there any reason why you left out the s_order_basket table? there is a partnerID too.

I guess I just missed that one.

Then you know what to do :)

@svenmuennich can you update this PR please? Otherwise it will be closed within the next days.

Sorry for the delay @janbuecker, but I've been quite busy for the last days. I added the following changes:

Rebase the branch to the current HEAD of 5.2 (39212c31d0167b76ca64bcdc32324f29662694fb)

Make s_order_basket.partnerID NULLable

Split up the migration in three files:

Update the fields s_order.partnerID and s_order_basket.partnerID to be nullable and NULL by default
Replace empty string values in s_order.partnerID with NULL
Replace empty string values in s_order_basket.partnerID with NULL

Fixed an analytics query condition

Add changes to UPGRADE-5.2.md

Our tests with elasticsearch failed with your changes as well as the mink tests. Can you please describe, why do you want to introduce this change?

Initially I thought that making partnerID nullable fixes an exception, which occurred when saving an order in the backend. But as it turned out, the exception was caused by something else. I think in general it is just more correct to NULL the field by default, making it easier to create a new order using Doctrine. E.g. the Backend orders plugin currently works around this problem.

Hi, since this PR doesn't fix your problem and the benefit is rather small while breaking the ES testsuite, we will close it.

This change was now partly adopted by 386215a6007c086366f16d336b29e57d37d25665.


Links 404

The "Get Upstreaming Behavior" and "Set Upstreaming Behavior" links located about half-way down the page lead to a 404 error
Relevant section: https://docs.microsoft.com/en-us/azure/devops/artifacts/concepts/upstream-behavior?view=azure-devops&tabs=nuget#allow-external-versions-using-the-rest-api

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 10fb8c20-fe29-a60c-dd6c-45c9e8278162
Version Independent ID: ca24cdd8-dc94-6339-e2ef-95e5a84fa877
Content: Configure upstream behavior - Azure Artifacts
Content Source: docs/artifacts/concepts/upstream-behavior.md
Product: devops
Technology: devops-artifacts
GitHub Login: @ramiMSFT
Microsoft Alias: rabououn

@Cisien Thank you for your feedback!


Add a Buildpack Registry extension

This is a proposal for an extension to the Buildpack Interface Specification. It defines new elements in the buildpack.toml data format.
In the future there may be other additions we can make (such as more formal restrictions or guidelines around buildpack.id), but this is the best starting point.

@hone was there a reason we used capital letters for Ignore and Vendor? @sclevine request lowercase to be consistent with other keys.

@jkutner How exactly do you expect this to be used?  It seems like the implementation based on this spec assumes that all files that might be packaged are checked into source control.  In the case of go-based applications, a pre-packaging step would need to happen to compile some of those files.  In our case, we describe a metadata.pre_package key that is something that needs to be invoked, but of course this can't be done in a "generic" platform as it might need a Go compiler, etc.
It's also interesting that CF's v2B buildpacks choose whitelisting rather than blacklisting.  I modeled our V3 along those same lines as it require positive confirmation and ensures that you don't accidentally ship credentials or something, but I'm wondering if you have some insight on the v2A side that makes you think that blacklisting is better.

@nebhale anything compiled (like Go) would come in pre-compiled (via a transport other than Git). So the ignore list would effectively be "post". That is, the registry itself will not provide a toolchain for building/compiling.
The blacklisting was meant to resemble the behavior when using buildpacks directly from Github (like running heroku buildpacks:set https://github.com/jkutner/heroku-buildpack-minecraft) in which case all files are taken.
I'm open to rethinking whitelist/blacklist.

...via a transport other than Git...

Yep, that's what I was looking for.
For whitelisting my vote is for:
```toml
 [buildpack]

   [publish]
   include(_files?) = ["<files to include>"]
...

My conservative nature leads me to whitelisting over blacklisting, but I'm not super invested either way.


Secrets not applied from now.json

Looks like after https://github.com/zeit/now-cli/pull/508 the secrets are not applied. Previous version seems to work fine.
I did not test if the same applies when the config is not in now.json but in package.json.

I can verify downgrading to 5.2.0 resolves the problem after seeing deployments fail on 5.2.1.

Secrets also not found when on 'command line' now -e MY_SECRET=@my_secret

hmm @mojo5000
I can not confirm this. Using -e works for me with the latest version

@littleStudent sry is a slightly different issue - are you using teams?  it was not seeing the secret created within my team.

no, I dont use teams. So these are different issues i think.

not sure why (server side change?). But it is working again for me with cli 5.2.1. If it is not for you @gabek drop me a line and I will reopen the issue


do you think uv_multiplex would work in conjuction with this?

Asking because I wanted to know your opinion. I am looking for a multithreaded high perf TLS stream to msg parsing framework and so far your abstraction on openssl for async and the example for libuv looks like a potential win (obviously with a lot of work to switch from echo and make more production rdy...) but what do you think it would take to use ￼￼https://github.com/willemt/uv_multiplex and make a example say test_multicore_tls.c in sample/libuv-tls?
Thanks again for the project...

it appears I actually got it to work today.. However doesn't perform as well as I expected. What do you think or what have you tested for number of concurrent conns with evt-tls and libuv? As well as how does libuv do connection state/metadata for the app and does evt-tls expose that I can't seem to find it in your apt/structs. Thx

@deleisha you want a pull request or have any thoughts on this ? What I am after is a path to saturating many cores with tls/io ;)

Good to know that you got it working.
evt-tls will facilitates TLS programming by using, currently only with OpenSSL, as black box. You feed whatever data is received from network(NIO) and read unwrapped data though evt_tls_read.
Implying that network part is handled by libuv and crypto part done by evt-tls and they are independent.
Handling concurrent connection, I do hope, libuv will handle well.
I did not get exactly your question on state/metadata. Could you please elaborate

re state/metadata: say I want a uuid of the connection so that each time a callback is fired I know which one it is to do some other operation / lookups ? thinking it would have to be somehow added to uv_tls_t in the current codebase but there isn't a void *userdata; field or something like that?

Aah, ok.
struct evt_tls_s has a void *data.
uv_tls_t is just for demo on how to integrate it with libuv and you can adapt in any way you like. It demonstrate one of the way of integrating but may not be the best way.
May be you can add void *userdata as well.

I am closing this out, please feel free to reopen if needed

@ljackson
A pull request would be great


localtunnel down again

Seems to be down again.

same here. After long time the connection is hanging, I receive this response:

<title>504 Gateway Time-out</title>

504 Gateway Time-out

nginx/1.17.9

Interestingly the C# client https://github.com/angelobreuer/localtunnel.net
is working!

Hey @juergenr, the service seems to be up and working normally. Have you tried to restart the local tunnel client?
Are you doing stuff like long polling? If yes then this service won't work for you since the reverse proxies I've setup have a timeout setting set

Hi @TheBoroer, thanks for your replay.
No, I'm not doing long polling. My first test is a simple webserver with http or https.
I've done several test, give admin rights, restart several times, use different ports, use different webservers - it always hangs.
While https://github.com/angelobreuer/localtunnel.net (which uses the same backend) and ngrok works.
It would be really nice, if the nodejs client also would work.
Thanks!

Hmm that's weird. Did the npm version work for you before? Seems like it's a local issue with your setup since the npm version works for me on two different laptops. Have you tried reinstalling local tunnel?

I'm using: npm version 8.13.2 and node version v18.6.0
Reinstall doesn't change the problem.

I have used a total fresh Windows machine, installed node v18.12.0 and npm 8.19.2, then installed localtunnel and get the same behavior.
I see the page: "Friendly Reminder" but the button "Click to Continue" does nothing (hangs).

lt --port xxxx hangs for me too, even trying to get an url in my app for my dev env is impossibile today.

Down again also for me

Some news?

The nodejs client still hangs for 3 days, now.
The astonishing is, that the .Net client still works fine with the same backend *.loca.lt
So there must be some problem with the nodeJs client ...
So you can use the .Net client as work-around (it works like a charm).

localtunnel not working for a week.
Its works sporadically 10% of the time

the only way to fix the nodejs client is to allow http tunneling from it like what the C# client does

Seems to have issues again. (I'm running the node client)

Seems to have issues again. (I'm running the node client)

You should use the C# version instead and tunnel it by http

Worked for me for a few weeks and all of a sudden it won't register. lt --port xxxx just hangs there, never returns.


Soft delete a repository

This feature should provide a way to soft-delete all elements being part of a given foo/bar repository (all manifests and all layers references).
It's understood that if the user does simultaneously push, unexpected things will happen.
It's understood that the hub to use that feature is expected to "lock" the repository.

@dmp42 Registry API doesn't really have the concept of a repository, other than the named location of the data. For example, we don't have paths like /v2/<name>, since it requires trailing path elements to "fix" the name. To delete the repository, delete all of its contents, from an API perspective.
When I last spoke to the hub team, they agreed to simply issue a delete of the directory directly to the backend. What happened to this agreement?

When I last spoke to the hub team, they agreed to simply issue a delete of the directory directly to the backend. What happened to this agreement?

What makes you think this changed?

This is a duplicate to #225. Closing for now. If is different. Please reopen.


No such file or directory: '/root/.jasper/profile.yml'

hi
First, YES: I have run the populate.py
I have installed Jasper on my pi and it failed to work
So I run python ~/jasper/client/main.py
Then I get
Traceback (most recent call last):
File "client/../jasper.py", line 138, in
app = Jasper()
File "client/../jasper.py", line 77, in init
with open(new_configfile, "r") as f:
IOError: [Errno 2] No such file or directory: '/root/.jasper/profile.yml'
YES, /root/.jasper does not exist
/home/pi/.jasper does
Any suggestions.

Ignore
This was because I ran python ~/jasper/client/main.py with sudo

Why does this error only come up when running as sudo? Do you know?

yeah because you are loading that users environment. Which is different.  Its quite obvious look at the paths in the error.  You should never run it with sudo

@mattcurrycom True but how else am I supposed to control the raspberry pi's GPIO pins? You can't do so unless the you have run a program as super user. Any ideas? I tried to echo commands to terminal using the os library but that didnt work either.

Try sudo apt-get install rpi-update
I had that prob and that fixed it

Im on kali linux and im root by default so this error needs to be fixed!


custom theme

hi, awesome stuff you made.
not an expert on Android, but i'm trying to use this to style the crash activity, mainly its action bar colors but with no success
<?xml version="1.0" encoding="utf-8"?>
<resources>

    <style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
        <item name="colorPrimary">@color/primary</item>
        <item name="colorPrimaryDark">@color/primary_dark</item>
        <item name="colorAccent">@color/accent</item>
    </style>

    <style name="CustomActivityOnCrashTheme" parent="AppTheme" />

</resources>

my app's activity action bar is styled in red colors, whoever the crash activity action bar is in blue

Hello,
The same issue is happening for me. Is this fixed?

Did not work!

Hi @chrischen-melb, sorry for the long delay in my response.
This should be fixed in the current development version since it now uses AppCompat. It will soon be published in version 2.0.0 of the library.
Please reopen this issue if this isn't fixed, and thanks for reporting the problem.

Hi, latest version is now available on Maven Central. Let me know if you have any other issue!

I tried this but not working.
My apps primaryCOlor is white so I cannot see that button text Error Details due to this. Is there anyway we can achieve this.


Updated dependencies, uses react-dnd >= 7.1

They have published new version of react-dnd, maybe it worth to update then?


feat: add get device by id, get devices and get history - GraphQL

Please check if the PR fulfills these requirements

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?
Adds queries to retrieve a device by id and a list of devices.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Is there any issue related to this PR in other repository? (such as dojot/dojot)
dojot/dojot#1388

Other information:

Why codecov report doesn't run?

When Travis run the test:
 PASS  src/tests/graphql/resolvers/Device.test.js [2020-04-22T13:34:37.547] [WARN] BackStage - TypeError: Cannot read property 'devices' of undefined     at Object.getDevices (/home/travis/build/dojot/backstage/src/graphql/device/Resolvers.js:1724:35)     at <anonymous>

No need to worry about the total percentage of codecov, just cover the new device, history and config files

Just fix codefactor and deepscan issues :)


demo: Add Event Management  (Hacktoberfest Demo)

What does this PR do?
This adds a new innovative Copilot Community project.
This is basically a Event Management with AI integration that seamlessly helps to plan event.
Related PRs and Issues
Checklist

[x] I have read read the Contribution Guide
[x] If the PR changes or adds functionality, I have updated the relevant documentation

Awesome job @heysagnik!


Remove commented out notStored

#9  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pablo-statsig and the rest of your teammates on  Graphite


fix: reduce log pollution

I don't think this shouldn't be a warning, since it's the default and intended behavior.

Closing this in favor of #30


passing multiple occurrences of search result parms in lenient mode causes an error

Working with the current pre-release of FHIR on main branch
Per the conformance documentation:  https://ibm.github.io/FHIR/Conformance
_The _sort, _count, _summary, _elements, and total parameters may each only be specified once in a search. In lenient mode, only the first occurrence of each of these parameters is used; additional occurrences are ignored.
Received an error when trying to use multiple occurrences of the _sort, _count, _summary, _elements, and _total when setting Prefer handling=lenient via the header.  See attached screenshot.
To Reproduce
Default or set 'true' fhir server config parameter 'fhirServer/core/allowClientHandlingPref'
Attempt the following:
GET [base]/Measure?_sort=_lastUpdated&_sort=status
GET [base]/Measure?_count=1&_count=1000
GET [base]/Measure?_summary=text&_summary=count
GET [base]/Measure?_elements=status&_elements=name
GET [base]/Measure?_total=none&_total=accurate
Expected behavior
Expected only the first occurrence to be used successfully as stated above.

we're pretty sure it used to work as documented.
investigate to make sure what we understand whats happening, confirming:

handling=lenient is working as intented
code seems to be logical / make sense

if both those are working as implemented, it should be a doc-only update

She's specifically trying some of the more restrictive search types.
We verified she had that correct.

Confirmed using the single header with ";" works as expected.  Should ',' separator work as well?

Based on https://datatracker.ietf.org/doc/html/rfc7240:
It seems like since handling= and return= are different tokens (i.e. one is not a parameter of the other).  They should actually be separated by ,, instead of ;.  In addition, multiple Prefer headers should be allowed.

I am now seeing that it does not matter what I send on the Prefer header, I usually send return=OperationOutcome.  After pulling the latest code it seems now the default return is set to minimal and I don't get the information back on the API calls I am expecting.  Like $healthcheck does not return any data. just a 200 and a header.

Interesting, the case of the "Prefer" header name appears to be different (perhaps between liberty versions, or something else different between Dag's and my machines) when retrieved by the REST servlet filter, regardless of what is in the original request.
To resolve this, I updated the code to be case-insensitive regards to HTTP header name.

Upon upgrading to the latest Liberty version, I received the same behavior as Dag.  So both of us were able to verify that PR #3356 addressed this issue we were seeing today.

After the latest code changes the issue I reported, it is now working as expected.

Confirmed mixed case Prefer header, multiple Prefer headers , and Prefer header with multiple tokens separated by a comma.


Bump rainbow gem version to >= 2.1.0.

In one of my previous PR's we had to do a 'hacky' fix to get X11 colors to output with the GeneratorMessages. https://github.com/shakacode/react_on_rails/pull/217
I was able to fix the problem with the rainbow gem and get a PR merged: https://github.com/sickill/rainbow/issues/27. The author updated the version of the gem to 2.1.0.

New version of rainbow fixes bug with X11 colors.
Use ‘orange’ instead of RGB color.

LGTM


generation step results in key error

When I try to run the generation step using the following command:
(molopt) user@machine:~/deep-molecular-optimization$ python generate.py --model-choice transformer --data-path data/chembl_02 --test-file-name test_unseen_L-1_S01_C10_range --model-path /home/user/Downloads/models/experiments/trained/Transformer/MMP/checkpoint/ --save-directory evaluation_transformer --epoch 60

I get the following output
15:37:01: generate.__init__ +31: INFO     Namespace(batch_size=128, data_path='data/chembl_02', decode_type='multinomial', epoch=60, model_choice='transformer', model_path='/home/user/Downloads/models/experiments/trained/Transformer/MMP/checkpoint/', num_samples=10, save_directory='evaluation_transformer', test_file_name='test_unseen_L-1_S01_C10_range')
15:37:01: generate.__init__ +32: INFO     Save directory: experiments/evaluation_transformer/test_unseen_L-1_S01_C10_range/evaluation_60
Allocating cuda:0.

/home/user/deep-molecular-optimization/models/transformer/encode_decode/model.py:59: UserWarning: nn.init.xavier_uniform is now deprecated in favor of nn.init.xavier_uniform_.
  nn.init.xavier_uniform(p)
  0%|                                                                                | 0/62 [00:09<?, ?it/s]
Traceback (most recent call last):
  File "generate.py", line 252, in <module>
    run_main()
  File "generate.py", line 248, in run_main
    runner.generate(opt)
  File "generate.py", line 92, in generate
    device=device)
  File "generate.py", line 169, in sample
    smi = self.tokenizer.untokenize(self.vocab.decode(seq.cpu().numpy()))
  File "/home/user/deep-molecular-optimization/preprocess/vocabulary.py", line 66, in decode
    tokens.append(self[ohv])
  File "/home/user/deep-molecular-optimization/preprocess/vocabulary.py", line 23, in __getitem__
    return self._tokens[token_or_id]
KeyError: 121

If I run this a number of times, the key it can't locate changes every time. Am I running this incorrectly?

I've run into the same error.  I tried to wrap this with an exception handler at line 117 in generate.py

try:
    smi = self.tokenizer.untokenize(self.vocab.decode(seq.cpu().numpy()))
    smi = uc.get_canonical_smile(smi)
    smiles.append(smi)
except KeyError:
    print("Key Error")

However, this doesn't appear to have helped.  The output only had blank values for TargetMol.
Also, the README appears to be out of data, it lists an argument "--vocab-path" to generate.py that doesn't appear to be supported.  Can you post a working example?

Hi @spadavec, I think it might be because of the inconsistency of the vocab and model checkpoint. Note there are two branches for two different publications, where the pre-trained models and vocabs cannot be crossly used. For example, if you are using the generation step from master branch, you can't use the model downloaded from the "general_transformation" branch (based on the model path you provided, I guess you are using) for generation.

Hi @PatWalters, can I ask which branch you are using and are you using the model and vocab downloaded from the link residing in that branch correspondingly? Also the "--vocab-path" is only supported on the branch "general_transformation".

my workflow that worked for me to run the generate.py for modifying some smiles strings:
I cloned the repository -> then checkout the branch "general_transformation" -> download the model.tar.gz and data.tar.gz from the https://zenodo.org/record/6319821#.YwSlnnbP2gY (VERSION 2!) -> extracted the two files into the folder "deep-molecular-optimization" -> then run:
!python generate.py --model-choice transformer \                     --data-path "/home/mpr/2_git_repos/deep-molecular-optimization/data/MMP" \  # model where the csv file "small.csv" is located which is a small set of smiles                      --test-file-name "small" \ #name of the csv-file                     --epoch 60 \                     --save-directory "/home/mpr/2_git_repos/deep-molecular-optimization/experiments/evaluation_transformer" \                     --model-path "/home/mpr/2_git_repos/deep-molecular-optimization/experiments/trained/Transformer-U/MMP/checkpoint" \                     --vocab-path "/home/mpr/2_git_repos/deep-molecular-optimization/data/MMP/vocab.pkl"\ # !Important to match the vocab.pkl of the right model -> in this case I used MMP                     --without-property # Because i didn't need the property prediction part
               This worked very well for me
               Thank you for this nice tool!


Please support python-cryptography 1.5

The test suite currently fails with that version:
AttributeError: '_cffi_backend.CDataGCP' object has no attribute 'cert_info'

We merged cryptography 1.5 support just two days ago: #1513

All right, so I'll just wait for a new tag/release and then I can upload to Debian :)


Fix subcommand defaultValue bug

When a command that is build on subcommands (eg. !math) and you do not specify a sub command (eg. !math 1 3) the bot would error out.
Is there a better way of fixing that problem?

@itohatweb You can specify a default subcommand.

I already tested that it did not work on my end. Following error would occur:

I have now tested it on multiple different servers and I always got the same error when I was not using the code of this PR.

Can you provide reproducible code?

Example files:
math.ts: https://hasteb.in/jugurafu.js
test.ts: https://hasteb.in/azevaror.js

!math add 1 2 (works)
!math 1 2 (errors out)
!testing (errors out)

Using the addition of this PR  the above 2 commands do not error out.


Breakdown the connection string properties into configuration entities and properties

Currently, the connection string is a complex property that represents a number of configuration elements. Breakdown the connection string to represent a combination of properties and configuration elements that can be generated into the actual connection string.

Not going to be done. Recent meetings have changed the direction of the project.


⚠ Feedaty widget has degraded performance

In 86c22b4, Feedaty widget (https://widget.feedaty.com/public/js/feedaty.js?merchant=10213975&style_ver=2021&data-sku=36263) experienced degraded performance:

HTTP code: 200
Response time: 2981 ms

Resolved: Feedaty widget performance has improved in d63b667 after 11 minutes.


backwards compatibility with ucan 0.8?

Summary
Originally posted on discord
Problem
A UCAN encoded from nftstorage/ucan-storage is not accepted by rs-ucan because of the missing field ucv.
found via git blame that in <v0.9 ucv was in the header, and in 0.10 in the payload..
Impact
Can't use TS-ucan with rs-ucan
Solution
Posted an issue to update TS-ucan https://github.com/ucan-wg/ts-ucan/issues/105 ...
but what about backwards compatibility?
Too much work for pre-1.0?
Or actually wanted?

FYI - This ts lib is compatible with UCAN spec 0.10 and seems to be the successor to ts-ucan
https://github.com/fission-codes/stack/tree/main/packages/ucan


versions.yml: Need spelling fix and capitalize descriptions.

In versions.yml most of the description fields have capitalized text. Let's keep all them capitalized for the sake of consistency.
Also need to fixed spelling of 'requried'.

Fixed by #2629

;-) - when you add the 'Fixes #nnn' to one of your commits and re-force-push to your PR, then I believe github will make that reference for you automatically ;-)