[TVM] Fix segfault for CanonicalSimplify(x % -1)

@tqchen @xqdan Please review

Thanks, @sgrechanik-h @xqdan , this is merged


Java folder missing

mcdex installPack "D:\Program Files (x86)\MultiMC\instances\Vanilla 1.10.2" https://minecraft.curseforge.com/projects/age-of-engineering/files/2446286
CMD response: 2017/07/09 01:01:18 Failed to initialize: missing Java directory
latest JRE is installed 32 and 64 bit

Hi @geekgarage - how did you install Java? This error only occurs when:

There is no JAVA_HOME set in your env
OR
There is no embedded Java installed with Minecraft
OR
Running "where java" fails

I've tried to cover all the variations I'm aware of, but noting that you're using MMC, I wonder if I missed something. :)

JRE was from the installers from Oracles website so nothing special about it.
According to what i can find JAVA_HOME is JDK specific and JRE is using JRE_HOME
I don't have JDK installed. Is this a must?

I've just uninstalled all JRE versions 8 build 91 and 8 build 131 both x86 and x64.
Then i reinstalled JDK x64 and added JAVA_HOME and JRE_HOME to env to their respective folders.
Minecraft is running fine both vanilla and MMC instances but mcdex is still throwing that error

Hm, ok this is very interesting. I've updated the latest build of mcdex w/ support for more verbose logging of the Java env. Can you please try running:
mcdex -v info
and send me the info via email (my github id @ my github id.com)

It mus have been me forgetting to restart to reload env references because now it works, but yes it seems like it is JDK depended so i think you should add that as a note to the instructions. I sent you a dump anyway if you can use it for some thing, and as a side note i had to manually add the ENV references (and restart)

Hi @geekgarage - glad we got it working! I just pushed up a new version of mcdex (0.6.3) that also checks for JRE_HOME. Hopefully that will avoid this problem in the future. :)

That is awesome, thanks for the update, i'll properly make a youtube video regarding my whole steam Link setup and how i use your program to update my mods :) Thank for a great program and hope you will keep it updated if the mod system ever change, because this save me TONS of work updating my mods


TimeSeries WeightedEnsemble

Issue #, if available:
#1808
Description of changes:

Add WeightedEnsemble to TimeSeries

TODO:

Remove Print Statements
Benchmark
Integrate with new sktime model logic
Fix unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1838-6 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1838/6/index.html

Job PR-1838-8 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1838/8/index.html

Job PR-1838-13 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1838/13/index.html


serialport problems, el capitan (10.11.1)

Received the error below when trying to install the spark-dev atom package.
Using el capitan 10.11.1, with Atom 1.2.3 and Node 5.0.0.
Error:
><EMAIL_ADDRESS>install /private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/node_modules/spark-dev/node_modules/serialport
> node-pre-gyp install --fallback-to-build --runtime=atom-shell

  CXX(target) Release/obj.target/serialport/src/serialport.o
Failed to execute 'node-gyp build --fallback-to-build --runtime=atom-shell --module=/private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/node_modules/spark-dev/node_modules/serialport/build/serialport/v1.7.4/Release/electron-v0.34-darwin-x64/serialport.node --module_name=serialport --module_path=/private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/node_modules/spark-dev/node_modules/serialport/build/serialport/v1.7.4/Release/electron-v0.34-darwin-x64' (1)

npm WARN installMany node-pre-gyp was bundled with<EMAIL_ADDRESS>but bundled package wasn't found in unpacked tree
npm WARN installMany nopt was bundled with<EMAIL_ADDRESS>but bundled package wasn't found in unpacked tree
npm WARN installMany npmlog was bundled with<EMAIL_ADDRESS>but bundled package wasn't found in unpacked tree
npm WARN installMany request was bundled with<EMAIL_ADDRESS>but bundled package wasn't found in unpacked tree
npm WARN installMany semver was bundled with<EMAIL_ADDRESS>but bundled package wasn't found in unpacked tree
npm WARN installMany tar was bundled with<EMAIL_ADDRESS>but bundled package wasn't found in unpacked tree
npm WARN installMany tar-pack was bundled with<EMAIL_ADDRESS>but bundled package wasn't found in unpacked tree
npm WARN installMany mkdirp was bundled with<EMAIL_ADDRESS>but bundled package wasn't found in unpacked tree
npm WARN installMany rc was bundled with<EMAIL_ADDRESS>but bundled package wasn't found in unpacked tree
npm WARN installMany rimraf was bundled with<EMAIL_ADDRESS>but bundled package wasn't found in unpacked tree
In file included from ../src/serialport.cpp:3:
In file included from ../src/serialport.h:5:
../node_modules/nan/nan.h:261:25: error: redefinition of '_NanEnsureLocal'
NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Local<T> val) {
                        ^
../node_modules/nan/nan.h:256:25: note: previous definition is here
NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Handle<T> val) {
                        ^
../node_modules/nan/nan.h:661:13: error: no member named 'smalloc' in namespace 'node'
    , node::smalloc::FreeCallback callback
      ~~~~~~^
../node_modules/nan/nan.h:672:12: error: no matching function for call to 'New'
    return node::Buffer::New(v8::Isolate::GetCurrent(), data, size);
           ^~~~~~~~~~~~~~~~~
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/src/node_buffer.h:41:40: note: candidate function not viable: no known conversion from 'uint32_t' (aka 'unsigned int') to 'enum encoding' for 3rd argument
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/src/node_buffer.h:53:40: note: candidate function not viable: 2nd argument ('const char *') would lose const qualifier
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/src/node_buffer.h:38:40: note: candidate function not viable: requires 2 arguments, but 3 were provided
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate, size_t length);
                                       ^
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/src/node_buffer.h:46:40: note: candidate function not viable: requires 5 arguments, but 3 were provided
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
In file included from ../src/serialport.cpp:3:
In file included from ../src/serialport.h:5:
../node_modules/nan/nan.h:676:12: error: no viable conversion from 'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object>'
    return node::Buffer::New(v8::Isolate::GetCurrent(), size);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:210:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'v8::MaybeLocal<v8::Object>' to 'const v8::Local<v8::Object> &' for 1st argument
class Local {
      ^
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:210:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object> &&' for 1st argument
class Local {
      ^
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:214:13: note: candidate template ignored: could not match 'Local' against 'MaybeLocal'
  V8_INLINE Local(Local<S> that)
            ^
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:326:13: note: candidate template ignored: could not match 'S *' against 'v8::MaybeLocal<v8::Object>'
  V8_INLINE Local(S* that)
            ^
In file included from ../src/serialport.cpp:3:
In file included from ../src/serialport.h:5:
../node_modules/nan/nan.h:683:26: error: no member named 'Use' in namespace 'node::Buffer'
    return node::Buffer::Use(v8::Isolate::GetCurrent(), data, size);
           ~~~~~~~~~~~~~~^
In file included from ../src/serialport.cpp:3:
In file included from ../src/serialport.h:5:
In file included from ../node_modules/nan/nan.h:24:
In file included from /Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/src/node.h:42:
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:221:5: error: assigning to 'v8::Primitive *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:414:12: note: in instantiation of function template specialization 'v8::Local<v8::Primitive>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(v8::Undefined(v8::Isolate::GetCurrent())));
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
In file included from ../src/serialport.cpp:3:
In file included from ../src/serialport.h:5:
In file included from ../node_modules/nan/nan.h:24:
In file included from /Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/src/node.h:42:
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:221:5: error: assigning to 'v8::Boolean *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:424:12: note: in instantiation of function template specialization 'v8::Local<v8::Boolean>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(v8::True(v8::Isolate::GetCurrent())));
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
In file included from ../src/serialport.cpp:3:
In file included from ../src/serialport.h:5:
In file included from ../node_modules/nan/nan.h:24:
In file included from /Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/src/node.h:42:
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:221:5: error: assigning to 'v8::Function *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1514:12: note: in instantiation of function template specialization 'v8::Local<v8::Function>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(handle)->Get(kCallbackIndex)
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
In file included from ../src/serialport.cpp:3:
In file included from ../src/serialport.h:5:
In file included from ../node_modules/nan/nan.h:24:
In file included from /Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/src/node.h:42:
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:221:5: error: assigning to 'v8::Object *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/hwestbrook/.atom/.node-gyp/.node-gyp/0.34.0/deps/v8/include/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1632:12: note: in instantiation of function template specialization 'v8::Local<v8::Object>::Local<v8::Value>' requested here
    return NanEscapeScope(handle->Get(NanNew(key)).As<v8::Object>());
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
9 errors generated.
make: *** [Release/obj.target/serialport/src/serialport.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Darwin 15.0.0
gyp ERR! command "node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--runtime=atom-shell" "--module=/private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/node_modules/spark-dev/node_modules/serialport/build/serialport/v1.7.4/Release/electron-v0.34-darwin-x64/serialport.node" "--module_name=serialport" "--module_path=/private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/node_modules/spark-dev/node_modules/serialport/build/serialport/v1.7.4/Release/electron-v0.34-darwin-x64"
gyp ERR! cwd /private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/node_modules/spark-dev/node_modules/serialport
gyp ERR! node -v v0.10.40
gyp ERR! node-gyp -v v2.0.2
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute 'node-gyp build --fallback-to-build --runtime=atom-shell --module=/private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/node_modules/spark-dev/node_modules/serialport/build/serialport/v1.7.4/Release/electron-v0.34-darwin-x64/serialport.node --module_name=serialport --module_path=/private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/node_modules/spark-dev/node_modules/serialport/build/serialport/v1.7.4/Release/electron-v0.34-darwin-x64' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/node_modules/spark-dev/node_modules/serialport/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
node-pre-gyp ERR! stack     at maybeClose (child_process.js:766:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:833:5)
node-pre-gyp ERR! System Darwin 15.0.0
node-pre-gyp ERR! command "node" "/private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/node_modules/spark-dev/node_modules/serialport/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build" "--runtime=atom-shell"
node-pre-gyp ERR! cwd /private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/node_modules/spark-dev/node_modules/serialport
node-pre-gyp ERR! node -v v0.10.40
node-pre-gyp ERR! node-pre-gyp -v v0.6.12
node-pre-gyp ERR! not ok
npm ERR! Darwin 15.0.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/hwestbrook/.atom/.apm/.apmrc" "--userconfig" "/Users/hwestbrook/.atom/.apmrc" "install" "/private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/d-1151019-9254-1qagqxg/package.tgz" "--target=0.34.0" "--arch=x64"
npm ERR! node v0.10.40
npm ERR! npm  v2.13.3
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build --runtime=atom-shell`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-pre-gyp install --fallback-to-build --runtime=atom-shell'.
npm ERR! This is most likely a problem with the serialport package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build --runtime=atom-shell
npm ERR! You can get their info via:
npm ERR!     npm owner ls serialport
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /private/var/folders/hm/nkjp28h914ddhwb8jz_5nq400000gn/T/apm-install-dir-1151019-9254-3xnw6a/npm-debug.log

Doing some more testing, I no longer experience this issue if I downgrade atom back to v1.1. Is this related to >=1.2?

@hwestbrook It is possible. I will do some tests against it.

Any luck on finding this? Likely the uptick in reports of this issue is due to a bunch of people getting a particle for christmas :)

@hwestbrook & @aleemstreak can you check again now? I updated dependent package which should fix the problem.


feat: Bug fixes and training notebook

Hi Diwank,
thanks a lot for your contribution! The code looks good to me. I might change the structure in the notebooks folder later on. Furthermore, I will add a section on datasets/models (including the one you created) in the readme.md. If you want to share any models publicly in the future, I am happy to link these also there.
Best,
Justus

For sure. :)
I really love the ideas in your paper and after playing around with it, thought it could be interesting to see how this scales. Currently training a gte-large model on a cleaned, combined dataset merging:

daily_dialog
air_dialogue
allenai/prosocial_dialog

It was rebalanced since the datasets are very different in sizes and should probably only be trained for 3-4 epochs.
You can see the combined dataset here. I’ll share my findings and the final model as soon as it’s done training!

Hi @creatorrr
Great! Your dataset is added to the readme.md. If your model is ready, feel free to send a pull request to link it there :)
Are you training it for short-term planning or (long-term planning/sequence modeling)? From my experience, the short-term planning models take usually 1-2 epochs while the latter requires even 5 epochs or more. With the size of the dataset, I would expect even longer training times.
I am curious what your findings are!
Best,
Justus


pep8 project configuration file properties are ignored in some cases

When user will try to use project config (implemented in https://github.com/AtomLinter/linter-flake8/pull/17), for example a config which have a maxLineLenght property, flake8 will ignore config value, and will use value from plugin settings.
This behaviour is bad when user has not set any parameters in linter-flake8 settings by himself and want to use only the config file, pep8 will take a higher priority for arguments and values in config file will be ignored.
Any proposals how to handle this? I think you guys can help me becouse you've were somehow involved in this issue :) @ChaoticMind @matthewwithanm
My proposals:

If property from plugin settings (ex. maxLineLength) have the default value(ex. 79) and config file is found, don't use default values, but use value if it is property!= default value.
Totaly ignore plugin settings if config file is found.

This is the last thing that stopped me from making new release.

Option 2 makes the most sense to me. If I'm using a config file, I want it to use the config file, not (what I would consider defaults) in the plugin settings. I can't think of a single reason I'd want to override my config settings, instead of just temporarily changing the config file itself.

Yeah, I prefer option two too. Honestly, I think it would be best to not have any linter config in the plugin settings and just encourage people to configure linting using the normal means (setup.cfg, tox.ini, etc).

@knyghty @matthewwithanm Thanks! You've just stimulated my brain and I've got idea that will cover this two options: The checkbox with option to ignore plugin settings when config found, defaultly set to true?

That works, though I can't think of a time when you'd have a config file but not want to ignore plugin settings.

Option 2 choosed.

:thumbsup: Great, thanks!


Notepad Sample issue and others - No route found. Setting content type to 'text/plain'

No single solution is running in C# directory works.
After trying several times the notepas solution provided in the zip file, using Faslabs.zip fil to revert to an old version as indicated at
https://github.com/appium/appium-dotnet-driver/issues/217 for resolving the 'Dispose' issue
Now whenever I run a test method, I get

NotepadTest.ScenarioEditor.ClassInitialize threw exception. OpenQA.Selenium.WebDriverException: OpenQA.Selenium.WebDriverException: Unexpected error. The URL '/session' did not map to a valid resource.

Then I decided to hand code something very basic andI tried a very very simple basic test as follows

DesiredCapabilities appCapabilities = new DesiredCapabilities();
appCapabilities.SetCapability("app", @"C:\Windows\System32\notepad.exe");
NotepadSession = new WindowsDriver(new Uri("http://<IP_ADDRESS>:4723"), appCapabilities);
NotepadSession.FindElementByClassName("Edit").SendKeys("This is some text");

I am sure that appium is listening as i did a telnet to <IP_ADDRESS> port 4723, The message in the appium server log is

No route found. Setting content type to 'text/plain'

in the Testmethod error log in Visual studio the message is

Message: Test method CodedUIAppium.CodedUITest1.EditorEnterTextLocal threw exception:
OpenQA.Selenium.WebDriverException: Unexpected error. The URL '/session' did not map to a valid resource

Again, typing in the windows run dialogbox
C:\Windows\System32\notepad.exe
notepad opens without any issue. What is missing?

Hi @eliassal,
Do you mind downloading the latest release of WinAppDriver, running it locally (without Appium), and reporting back the behavior then running the same test code?
If you can provide the following, that would be super helpful as well:

Windows Build (start -> "winver")
WinAppDriver.exe logs

Thanks!

Hi there!
I had the same behaviour that @eliassal said. And It's probably because you are launching appium instead of WinAppDriver.exe to execute your tests. Try to launch WinAppDriver.exe located in C:\Program Files (x86)\Windows Application Driver. I put that path as part of my enviroment variable Path.
Cheers,

Hi, I'm getting an error:


How can i use more GPU usage?

Hi
Thanks for your great works in ConvNetSharp!
I ran your samples and saw that avg. of GPU usage was 15%, how can i use more GPU usage?

Hi,
What is the size of your batch ?
GPU should be better utilized when sending bigger batches.

I was set it into multiple values like 1024, 2048, 10000 but GPU usage had no change in overall.

Which sample did you run exactly ?

MinistDemo.GPU

I've run MinistDemo.GPU in Release mode and got this in VS2017 profiler:

I'm however not sure it represents reliably the GPU utilization.

Hi
Thanks for your great works in ConvNetSharp!
I ran your samples and saw that avg. of GPU usage was 15%, how can i use more GPU usage?

This is because of ConvNetSharp using only one thread to GPU

For more usage. Code logic must be rewrited.
For example.
https://github.com/Cr33zz/Neuro
This repo using ManagedCuda too. But using multi thread to GPU


delete newpod define

Please provide a description of this PR:
same to this closed pr .
Origin code it make confuse.such as :

we define pod equals to newpod.
In eventUpdate, define newpod and oldpod to use, But s.AddPodToMesh(pod) use pod rather than newPod.

There are two  variable declarations, do the same thing.  In one scope mixed use pod and newPod ，very confusing when read。

Hi @zhengbingxian. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhengbingxian this seems like minor rename change which one can argue if it's clearer than explicitly telling new vs old.
Also noticed @howardjohn comment here https://github.com/istio/istio/pull/45851#pullrequestreview-1516764714 about superfluous changes while this is the same change.


MA - ELR File Size Too Big

Problem statement
ELR Batch File Size problem that involved one being cut into smaller files
What you need to know
User's name is Janice Grantner
<EMAIL_ADDRESS>Email from Janice:

Good Afternoon,
We are receiving these reports from Report Stream to the Massachusetts Department of Public Health. The facility that is sending them in CDC Prime-Atlanta, Georgia (Dekalb).

Can you please review the size of these Prime files? We came across a file yesterday that was too big which needed to be split into multiple files. Yesterday file size was 5, 550KB (2096 messages) and we can only accept files up to 2.0MB. I have fixed and manually upload this file to our ELR Portal.

A max file size constraint of 2.0 MB is imposed for HL7 251 messaging. We strongly recommend that you send <=400 messages in your batch. Multiple batch files can be transmitted each day based on reporting volume.

Additionally, this file (prime-20221109145115) was received with special characters within some of the patient names. Can you please review this issue? Also, we noticed several cases that were not Massachusetts residents. They should not be sent to us and should go the proper state." (This bullet point is being handled under Issue # 7393 -- thx, BX)

To do
To review for file submission sizes and errors

[ ] ...

@BerniXiongA6 @brandonnava create new ticket to break out hte data quality issues

New ticket created for third bullet point -- Issue # 7393

Updated the batch timing to be every two hours instead of once a day via the website console.

Bullet points 1-2 are done per @brick-green

Update from Janice:
Hi Berni,
It is nice to meet you too. We will remove Adrian from our email list and add you Brandon, Brick and Sarah to the list. I have added my response under the questions.
Currently, we route results to MA based on the Ordering Facility State or Patient State. If MA only wants results where Patient State = MA, we can make an edit to our filtering. Please confirm this is indeed how you'd like to proceed. (We've experienced that the majority of states want both Ordering Facility State or Patient State.)
Yes we want both of these but only if the patient state is in MA
As for the file in question, after downloading it, our engineer couldn't find any messages with special characters in the patient names. Could you provide us accession numbers with examples?
I will work on getting you the accession numbers for you and send them to you.
Thanks,
Janice Grantner
Research Analyst
Division of Surveillance, Analytics and Informatics
Hinton State Laboratory Institute
305 South Street, Boston, MA  02130
Cell Phone:<PHONE_NUMBER>
Confidential Fax:<PHONE_NUMBER>
Email<EMAIL_ADDRESS>

Re-opening issue:
User response was from 12/6. Please advise.

@LaFreda1
User is asking for an update. Please see above email for reference.

I still don't understand what the ask from MA is here. The file size issue was resolved by Mo on 11/23/22.
@rnz6 What is MA asking us to do?


Resugaring exceptions crashes or leaves unbound variables

This crashes:
module TT

open FStar.All

assume val err_exn : 'a -> ML unit

let catch_errors (f : unit -> 'a) : ML unit =
    try ()
    with | ex -> err_exn ex

Extracted module Native
Extracted module Pervasives
Extracted module Exn
Extracted module FunctionalExtensionality
Extracted module Set
Extracted module Preorder
Extracted module StrongExcludedMiddle
Extracted module PropositionalExtensionality
Extracted module PredicateExtensionality
Extracted module TSet
Extracted module Heap
Extracted module ST
Extracted module All
Extracted module TT
Unexpected error; please file a bug report, ideally with a minimized version of the source program that triggered the error.
Failure("Cannot resugar FStar.All.try_with")

This one seems to succeed extracting,
module TT

open FStar.All

assume val err_exn : 'a -> ML unit // exception -> unit

let catch_errors (f : unit -> 'a) : ML (option 'a) =
    try let r = f () in Some r
    with | ex -> err_exn ex; None

But the result...
open Prims
let err_exn : 'a . 'a -> unit =
  fun uu____16  -> failwith "Not yet implemented:err_exn"
let catch_errors : 'a . (unit -> 'a) -> 'a FStar_Pervasives_Native.option =
  fun f  ->
    try let r = f ()  in FStar_Pervasives_Native.Some r
    with | _ -> (err_exn uu___65_51; FStar_Pervasives_Native.None)

Has uu___65_51 unbound.
Spotted when failing to bootstrap catch_errors in FStar.Errors in a branch of mine that does a bit more of normalization, but these examples explode in current master.

Another issue, branches of matches and trywiths are getting mixed up.
open FStar.All

let aux (b:bool) : ML int =
    try 0
    with | _ -> if b
                then 1
                else 2

open Prims
let (aux : Prims.bool -> Prims.int) =
  fun b  ->
    try (Prims.parse_int "0")
    with | true  -> (Prims.parse_int "1") | uu____14 -> (Prims.parse_int "2")

Error: This variant pattern is expected to have type exn
       The constructor true does not belong to type exn

Should be fixed in master now.  I'm not sure the code is bullet proof now, but passes a few tricky cases:
module Bug1485

open FStar.All

assume val err_exn : 'a -> ML unit

let catch_errors (f : unit -> 'a) : ML unit =
    try ()
    with | ex -> err_exn ex

let catch_errors' (f : unit -> 'a) : ML (option 'a) =
    try let r = f () in Some r
    with | ex -> err_exn ex; None

let aux (b:bool) : ML int =
    try 0
    with | _ -> if b
                then 1
                else 2

let aux2 (b:bool) : ML exn =
    try failwith ""
    with | e -> if b
                then e
                else e

open Prims
let err_exn : 'a . 'a -> unit =
  fun uu____16  -> failwith "Not yet implemented:err_exn"
let catch_errors : 'a . (unit -> 'a) -> unit =
  fun f  ->
    try (fun uu___66_38  -> ()) () with | uu___65_40 -> err_exn uu___65_40

let catch_errors' : 'a . (unit -> 'a) -> 'a FStar_Pervasives_Native.option =
  fun f  ->
    try
      (fun uu___68_69  ->
         match () with
         | () -> let r = f ()  in FStar_Pervasives_Native.Some r) ()
    with | uu___67_75 -> (err_exn uu___67_75; FStar_Pervasives_Native.None)

let (aux : Prims.bool -> Prims.int) =
  fun b  ->
    try (fun uu___70_89  -> match () with | () -> (Prims.parse_int "0")) ()
    with
    | uu___69_91 ->
        if b then (Prims.parse_int "1") else (Prims.parse_int "2")

let (aux2 : Prims.bool -> Prims.exn) =
  fun b  ->
    try (fun uu___72_103  -> match () with | () -> failwith "") ()
    with | uu___71_105 -> if b then uu___71_105 else uu___71_105


feat: my delegators

We should add a new tab on "Delegates" page with "My delegators", this page would includes the list of users delegating to the logged address, if there isn't any logged address we shouldn't show the tab. Here is how it look like:

The voting power % should be based on the total voting power of the logged user (and not total voting power available for the whole space).

Here is example of space with delegations https://snapshotx.xyz/#/sn:0x0041ada9121061198b52ae28edeec8ace7c23f2ba8d66938c129af1a2245701c/delegates

"My delegators" page now belongs to user space profile, and is being covered in a different issue https://github.com/snapshot-labs/sx-monorepo/issues/388


Button to take a screenshot

There should be a button in the menu that can be taken a screenshot very quickly and when this button is pressed, the menu will be hidden

Wow, Thank you for your great Idea, yes, we can make it with a new hotkey and change the default in setting panel.


try/finally does not work when EvalError thrown

BeanShell will not run the finally block when anything other than a TargetError is thown.  So if some other error flavour happens such as an EvalError the finally block is not executed.  Here is a simple and common enough test case to cause an EvalError with in a try block:
   helper(int a) {
      return this;
   }

   try {
      helper(1,2,3);
   } finally {
      print("an error occurred");
   }

I had a look at BSHTryStatement and the problem seems obvious enough:
        try {
            ret = tryBlock.eval(callstack, interpreter);
        }
        catch( TargetError e ) {
            thrown = e.getTarget();
            // clean up call stack grown due to exception interruption
            while ( callstack.depth() > callstackDepth )
                callstack.pop();
        } finally {
            // unwrap the target error
            while ( null != thrown && thrown.getCause() instanceof TargetError )
                thrown = ((TargetError) thrown.getCause()).getTarget();

            // try block finished auto close try-with-resources
            if (null != this.tryWithResources) {
                List<Throwable> tlist = this.tryWithResources.autoClose();
                for (Throwable t: tlist) // Java 9/10 treats this differently from 8
                    if (null != thrown && thrown != t)
                        thrown.addSuppressed(t);
            }
        }

TargetErrors are captured, but everything else is not.  The mechanism to run the final block is only invoked with TargetErrors.
Is there a reason that other errors were excluded, or do you think that this is just an oversight?  It looks easy enough to fix, but I maybe missing something.

TargetError is specifically used as a roll up container for the actual Exceptions thrown which it will report on. As is evident from the getCause and getTarget iterations, if an exception is thrown in try, TargetError is your guy.
Now you are not referring to Exceptions though but specifically an EvalError. I'll have to go check again but I have a suspicion that we abort on those. Something went wrong and from that state there is not much to do to recover from or too, is the understanding. Think blue screen...
Unless you think it should not be an evaluation error in this specific instance (nothing to do with it being inside a try block though but instead its cause is suspect) and there is a way to recover perhaps (not by processing the finally block... script is broke) then we should handle it differently and not have an EvalError.
I could be wrong...

My real case is almost exactly as shown in the example:  a scripted method was called with the wrong number of args, and it was inside a try block.  And it threw an EvalError, and I think that EvalError is an appropriate Throwable for this situation.
So the core of this problem is similar to the undeclared variable issue described by @drosenbauer:  EvalErrors cannot be caught.
try {
  throw new EvalError("boom");
} catch (EvarError ee) {
  System.err.println("never ever gets here");
} finally {
  System.err.println("never gets here either");
}

I think that you are right to be thinking blue screen, possibly unreliable interpreter state.  Maybe it isn't safe to continue.  But even to skip going in to the catch block?  Even to skip the finally block?
I am using BeanShell embedded in a system to run control scripts.  In this context it is important to be able to catch errors and try to unwind resources.  Having large classes of errors/exceptions that cannot be caught is a bit of a shortcoming.
It looks like it would be easy to change BSHTryStatement so that it allows catching all Throwables.  But as you suggest I am not sure of reliability/safety of doing so.  I would have to think about and analyze what could go wrong, but even then I doubt to be aware of all the issues.  The best I can to is make a change and put together a suite of tests, and see what happens.

EvalError should be reserved for unrecoverable problems and should abort the script. The purpose go the TargetError is specifically to be able to roll up exceptions as it is implemented and will not work correctly if we change it, iow we will not be able to catch NPE or anything specific.
The solution is to change whatever might be recoverable to throw an exception instead of EvalError which is something that can be caught and recovered from not to attempt to catch EvalError which purpose is specifically to abort script. Make senes?...

Agreed.
I think that you are right that any changes will have to be made carefully on a case-by-case basis.  Ideally the long term goal would be to convert all recoverable Interpreter errors to TargetErrors.
What type of errors do you see as being so unrecoverable that they cannot be caught at the scripting level?

@opeongo with JAVA we have compile time errors and runtime errors with beanshell we do not compile.  I would assume that everything that cannot compile in JAVA are considered not recoverable or EvalError type.

Also see the relevant comments about try/catch from @patn in issue #151.

@opeongo So can we close this as "works as  implemented" and that we will not be catching EvalError in try catch.

I would assume that everything that cannot compile in JAVA are considered not recoverable or EvalError type.

I don't necessarily agree with this.
For an example, consider a script modified from the initial example:
   helper(int a) {
      return this;
   }

   try {
      connection = openDatabaseConnection();
      doStuff(connection);
      helper(1,2,3);
      finishStuff(connection);
   } finally {
      cleanUpStuff();
   }

In Java, of course, the entire class would fail to compile because helper(int, int, int) does not resolve and is thus a compile-time semantic error. If the call to helper were dynamically invoked via Java reflection, the call to helper(1, 2, 3) would throw a catchable IllegalArgumentException.
In Beanshell, the script parses grammatically, but semantics are evaluated as each statement is executed. The connection would be opened, then the stuff would be done, and then a "compiler type" semantic error would be encountered. As it stands, this would throw an EvalError and abort the script. There would be no opportunity to clean up the "stuff", leaving the operation halfway completed and a dangling database connection.
The problem is pernicious enough that I tend to write my application's Beanshell scripts in a Java IDE to catch semantic errors and then copy-paste them into Beanshell. The fact that the application I work with has an #include type concept makes things worse.

@drosenbauer

If the call to helper were dynamically invoked via Java reflection, the call to helper(1, 2, 3) would throw a catchable IllegalArgumentException.

Your script would always throw the IllegalArgumentException so is there any advantage? Will this help you find the problem or cause more obfuscation?
The question is whether this is a syntactical error (compile time error in JAVA) or a valid execution error.
We could also treat this in a similar manner as for ex. JavaScript does and simply ignore the additional arguments. Again this obfuscates the problem which makes debugging more difficult.
Can you motivate why this should not be considered a syntax error?

The advantage is that I can handle the error by cleaning up the partially-finished operation. I agree that the script will always fail. But if the script runs within the application 30 times before I notice that it's failing, I won't have 30 partially finished operations that I now have to clean up by hand.

In other words, I agree that it's a syntax error, but that's a separate question from whether it ought to be an uncatchable abort. In Java terms, it's probably an Error and not an Exception.
It's something that you should not catch, in terms of best practice, but in specific circumstances, you may want to do something before aborting. You aren't supposed to catch Throwable, but you can.

@drosenbauer but now the script cannot run 30 times as it will be aborted.
In JAVA IllegalArgumentException is a runtime exception because we programatically (at runtime) assign the arguments, it may or may not be correct. This is not the case with your example, it will never be correct and is not a runtime exception.
IMO The best way to deal with this error is to abort the script. Unless you can adequately motivate the contrary, I am still not convinced.

You’re still thinking of the scripts as standalone executions rather than
hooks embedded in a larger application. In my case, the scripts are invoked
by the larger application as business logic to handle events in the system.
30 events mean 30 independent Beanshell script executions. (Possibly more
if the application interprets the error as something retryable.)
In my mind, this embedded case is the primary use case for Beanshell and so
should be accounted for at least as an option.
On Wednesday, May 29, 2019, Nick Lombard<EMAIL_ADDRESS>wrote:

@drosenbauer https://github.com/drosenbauer but now the script cannot
run 30 times as it will be aborted.
In JAVA IllegalArgumentException is a runtime exception because we
programatically (at runtime) assign the arguments, it may or may not be
correct. This is not the case with your example, it will never be correct
and is not a runtime exception.
IMO The best way to deal with this error is to abort the script. Unless
you can adequately motivate the contrary, I am still not convinced.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/beanshell/beanshell/issues/546?email_source=notifications&email_token=AA5H26AYEKJ6GABASX54R6LPX2U4PA5CNFSM4HCE6JE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWP4FTA#issuecomment-497009356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5H26FXE5Z27FFCQNP3AXTPX2U4PANCNFSM4HCE6JEQ
.

Surely your hook/plugin/embedded system is aware of failing scripts and they can be rectified. What you are proposing instead is for failing scripts to succeed, how does this allow us to find problems.
The question is not about the use case the question is whether syntax errors should be catchable.

The question is not about the use case the question is whether syntax errors should be catchable.

Or more specifically, as this conversation is leaning towards, whether incorrect arguments should be considered a syntax error or a catchable runtime error. Unless you also want to catch incorrect function names or general parser errors as well?

I think that general parser errors - i.e. the code provided doesn't match the grammar - are a valid abort scenario. If the provided text cannot be parsed into an AST, there's absolutely no way to run it, and no part of the code can be executed. In fact, there's nothing to run, since no code tree was produced. So the string &ab%12 would throw an exception at parse time.
What I'm getting at here is essentially whether Beanshell should act more like a static language (where all names must be known at parse time) or more like a dynamic language (where they are not). In dynamic languages like Python, after things have been parsed, errors like "bad function name" are catchable (as NameErrors, in that case). They're treated as runtime interpreter errors, not syntax errors.
In its dynamic and shell modes, Groovy also provides a similar exception (MissingMethodException). This is particularly notable in Groovy's case because it is truly compiling to Java bytecode but goes out of its way to make this catchable at runtime.
groovy:000> def a() { return "hi" }
===> true

groovy:000> a()
===> hi

groovy:000> a(1)
ERROR groovy.lang.MissingMethodException:
No signature of method: groovysh_evaluate.a() is applicable for argument types: (java.lang.Integer) values: [1]

groovy:000> try { a(1); } catch(MissingMethodException e) { println "error" }
error

Perl even provides a keyword (eval) that is capable of catching aborts, which can sometimes be initiated by a poorly coded library that one has no control over.
My opinion (and I know we disagree) is that since Beanshell is, at its core, a scripting language, it should behave like one.

The issue you are failing to raise is much bigger than function arguments or missing variables and we keep going around in circles because you refuse to interrogate superficial problems or even scratch the surface and insist on idealistic solutions backed by nonsensical look-but-they-do-it defences.
You cannot approach a problem with a solution in hand, first identify the problem then apply the appropriate solution. Forget about chasing solutions and trying to force the conditions in order to realise an ideal outcome, it will end in disaster. Look for the problem not for the solution, if you have trouble applying a fix then you are looking at symptoms and haven't found the problem yet. Once you realise the problem completely the solution will be an obvious choice of options, one of many. It doesn't matter what the solution is the only important thing is to resolve the issue, then there will be no more problem.
If you are keen to find a solution, which it appears you are, then I suggest start by listing all the EvalError causes and record as much relevant information as possible like location thrown, condition, etc. especially information for grouping. The more similarities different causes have the more likely we can treat them the same. Once we have a comprehensive overview of the affected area we will gain a better understanding of the impact. Identifying distinctions which will assist with their separation and type association.
I have created a new issue #556 for defining the problem properly which includes a link to a google docs sheet which we can use. Email me a gmail account and I will grant you access.
You have confirmed that EvalError works correctly.

I think that general parser errors - i.e. the code provided doesn't match the grammar - are a valid abort scenario.

Since parser errors are of type EvalError then you agree that try/finally works as implemented script aborted.
Closed: works as implemented

InvocationTargetException already result in TargetError
https://github.com/beanshell/beanshell/blob/04ae91a212e96c8a39cd4dc82bb52c2df4773cdf/src/main/java/bsh/BshMethod.java#L266-L270
https://github.com/beanshell/beanshell/blob/04ae91a212e96c8a39cd4dc82bb52c2df4773cdf/src/main/java/bsh/BSHMethodInvocation.java#L77-L94


Adding test for chunked response. Need to fix it.

Coverage increased (+0.08%) to 99.223% when pulling 1b4114a02ecf72dc65d64ff30f1d26d9ab407ac5 on chunk into f4d422f173443294fd4b43fa45867d6c734a00a2 on master.

Coverage increased (+0.02%) to 99.16% when pulling e03f47ce3f4281ff79cf4edda21f456ed369ad10 on chunk into f4d422f173443294fd4b43fa45867d6c734a00a2 on master.

Coverage increased (+0.02%) to 99.16% when pulling 5331cc9cb712d49dd59c5c6505788c21683aa503 on chunk into f4d422f173443294fd4b43fa45867d6c734a00a2 on master.


feat: Adds cypress based fakeAPI mocking plus cucumber usage example

This PR uses Cypress as a browser based test runner to run our more e2e-like tests. Additionally it does this by using cucumber as a thin layer over test assertions etc. Before explaining further, I just wanted to point out that when I say 'e2e', I mean 'frontend e2e' i.e. these tests should not use any backend infrastructure for testing (at least for the moment) These are 'e2e' tests, but without testing the things that we don't own.
We have a longish running desire to run our e2e-like tests in a browser rather than using Node/CLI via Jest, this PR is an approach to that task.
I've used the existing CLI based e2e-like tests from DataPlaneListView.spec (https://github.com/kumahq/kuma-gui/blob/1c7311e7d093397b853ce7f50dd224f7daf13493/src/app/data-planes/views/DataPlaneListView.spec.ts) as a starting point for browser based testing, and you'll see that the new tests here replicate the DataplaneListView tests that we are currently using a CLI to test. I've immediately seen one benefit in using this approach as it prevents things like:
https://github.com/kumahq/kuma-gui/blob/1c7311e7d093397b853ce7f50dd224f7daf13493/src/app/data-planes/views/DataPlaneListView.spec.ts#L292
where we've told the tests to expect without performing an assertion, so the above line currently doesn't assert anything in the places that we use it. In cucumber you'd get an error if you did something similar saying the step doesn't exist.
Another benefit seems to be non-clashing jest/cypress types.
There is work still todo here which I would like to do as a relatively soon follow up task[s], but it's currently at a point where we move all of our e2e tests forwards without more noodling with code (there are typescript types to sort out and probably a bit of duplication to remove). I've kept all the code that could potentially be noodled with in the one place in @/test-support, and as we are using cucumber for syntax we can noodle all we like with the underlying code (when the time is right) and it doesn't effect any of our potentially 1000s of tests.
Briefly:

The main bit of work was getting our dynamic mocks to work within Cypress, but this time using cy.intercept rather than MSW. It doesn't look like Cypress can perform the variable substitution from URLs for you (i.e. /meshes/:mesh/ > {mesh: "default"}, so I've used URLPattern to do that since I'm also using that for something else/elsewhere. This would also be useful on the MSW side of things.
We currently use MSW types for a Request data object (i.e. params and query etc). For the moment I've just @ts-ignored the places where the types originating from Cypress don't match the MSW types we currently use. These will need making more generic/less MSW-coupled when we come back to noodle with this.
We will need to use our @/services/development file so we can re-use all the mock file setup (aswell as the ability to label these for them to automatically picked up) similar to what we do during development/jest testing. Currently Cypress gives a tonne of log errors related to loading .vue files. There is a task here https://github.com/kumahq/kuma-gui/issues/798 to split development out so it doesn't also load production so that might help here. Although it might also be better to configure Cypress to load these if that's possible. I'm unsure about this right now/still thinking.
env will also need to come from the main application (as it does when using MSW)
Probably more comments... (I'll edit in here if/when I think of them)

All in all I wanted to get this up now for 👀 rather than noodle more.
This is not set up in CI yet and shouldn't be until we are a bit further ahead with it, so for the moment you should run yarn dev:real-api (we don't want MSW mocking) on port 8080 and run npx cypress open in order to see this working (you might have to do the ol' cypress install thing previous to that also)
As always, any questions getting it running please ask. We also have a GUI sync up tomorrow so it might be a good opportunity to discuss this further then.

After PRing this I tried some aforementioned noodling to remove some duplication and remove the @ts-ignore.
Completely informal work in progress right now, but here's a link to that https://github.com/johncowen/kuma-gui/compare/feature/cypress...johncowen:kuma-gui:chore/cypress-refact I'm likely to PR this separately soon after. Thought I'd mention here and give a changeset to view even though I can't nest a PR here. I'll try and describe more in the desc for it once I PR it.

I think the other thing I wanted to ask here was: What would next steps be now that we are in a place where we can standup a production build and run e2e tests on it in a browser using mocks?
Options (there may be more than this)

CI integration
Convert our current CLI based tests to browser based
Start creating net new tests (and if so are there any places in particular where we would like to start adding i.e. are there places that are currently lighter in tests than other areas?)

For the CI integration, this will potentially involve standing up/serving a build in CI. We can't use the preview site as they are MSW-mocked by default  (unless we can base the MSW feature flag on a runtime value, say a based on a cookie or something)

Before I forget there's at least one TODO to do here before we merge:

Take a look at moving the .feature files into the /cypress folder instead of being colocated along with the Route/View Component file. We only have one feature file at the minute so shouldn't be an issue

Just to note that ^ shouldn't block review but should be looked at before merge.

FYI, you will need to rebase/merge with master in order to run the tests using the updated GitHub Actions workflow since a job in it was renamed.
This is necessary because branch protection rules for which status checks are required are based on job names and so currently, this PR is waiting for a "Tests" job to have succeeded when it was previously called "Tests & build".

Just wanted to mention before merging this, that there are 2 follow up PRs for this mentioned above - the last one should be ready to go, the previous might be a little out of date and may need a bit of massaging before PRing.
Apart from that I should be able to work on re-using our development service config now development doesn't import production. I can also start looking at bringing this all into CI.


Issuer and the Subject are empty since 0.15.2 but were equal to "O = cert-manager" in 0.14.3 when using SelfSigned CA

Describe the bug:
Issuer and Subject of the generated certificate are empty strings when using SelfSigned Issuer on cert-manager 1.1.0, 0.16.1, 0.15.2 (but they are not empty on 0.14.3).
Expected behaviour:
I expect the Issuer and Subject in the certificate to be populated by non-empty strings for a Self signed certificate.
Steps to reproduce the bug:
I followed the steps described here:
https://cert-manager.io/docs/installation/kubernetes/
to create the test resources with:
kubectl apply -f test-resources.yaml

Then I extracted the self-signed certificate as follows:
kubectl get secret selfsigned-cert-tls -n cert-manager-test -o yaml

I saved the tls.crt contents in the variable named "line"
I used openssl to look at the contents like this:
echo  ${line} |base64 -d | openssl x509 -text

and it generated:
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            80:fd:f9:dd:67:7c:6e:a1:9d:61:57:b1:b0:55:83:66
        Signature Algorithm: sha256WithRSAEncryption
        Issuer:
        Validity
            Not Before: Dec 30 13:13:23 2020 GMT
            Not After : Mar 30 13:13:23 2021 GMT
        Subject:
        Subject Public Key Info:
            Public Key Algorithm:

The problem with the above is that the Issuer and the Subject are empty.
I would have expected to see some values, based on the Issuer name or some other Issuer parameter.
Anything else we need to know?:
I repeated the above steps with the versions 0.16.1. 0.15.2 and they all generated an empty Issuer and Subject strings.
Instead, using 0.14.3 it generated both Issuer and Subject equal to "O = cert-manager" regardless of the strings used in the definition of the Issuer and Certificate.
echo  ${line} |base64 -d | openssl x509 -text
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            86:03:74:ce:20:03:7c:b5:eb:a8:52:5c:96:14:7b:44
        Signature Algorithm: sha256WithRSAEncryption
        Issuer: O = cert-manager
        Validity
            Not Before: Jan  4 15:14:55 2021 GMT
            Not After : Apr  4 15:14:55 2021 GMT
        Subject: O = cert-manager
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                RSA Public-Key: (2048 bit)

Environment details::

Kubernetes version: 1.20
Cloud-provider/provisioner: Ubuntu Microk8s
cert-manager version: problem in 1.1.0, 0.16.1, 0.15.2 (working in 0.14.3)
Install method: static manifests

We removed this om 0.15 as it was wrong behavior to just set that field on every certificate, you can however set the values yourself using the Certificate's subject field: https://cert-manager.io/docs/usage/certificate/

We removed this om 0.15 as it was wrong behavior to just set that field on every certificate, you can however set the values yourself using the Certificate's subject field: https://cert-manager.io/docs/usage/certificate/


[Tensorflow, NNVM, TOPI] Support for logical operators

Support for logical OR/AND/NOT
Thanks for contributing to TVM!   Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@ashutoshparkhi can you please update on this PR?

I'm up for doing the relay part in a follow-up PR if this is ok to merge for NNVM.

OK, this is merged. @abergeron followup with relay op is more than welcomed

Thank you @tqchen  and @abergeron.


Requests with high data load are failing

Describe the Bug
When you request a period of a week, month, or year on some websites, the requests fail. See the screenshots below for one of our websites with a query for "All time" and "24th of Jan 2024"
Failing request

Successful request

This is a fairly persistent issue, meaning we can only request very small data samples, or we have to make API calls directly to the database.
The reason why this happens is that Vercel and Netlify both have small timeouts for cloud functions (around 20 seconds I believe Vercel source and Netlify source), which means you cannot complete the request. The screenshot below shows the slowest queries over the past 24 hours in Planetscale:

As you can see some of the queries take over 6 minutes, which means there is no time for the cloud function to:

Make the call
(await the response)
Parse the response
And send to the client

This is when it usually times out. The first step we took to mitigate this issue was to move the Netlify and Vercel cloud functions to the same AWS datacentre as the Planetscale database, slightly increasing performance.
A suggestion might be to move the web app and database to a cloud server so there are no timeout constraints, however, it would be better if our clients receive the result in under 20 seconds.
So this leads to how the Umami cloud function requests and parses data. It should be investigated how to optimise these queries, with differing strategies. One potential solution could be to create a rollup table where a function periodically fetches data from the previous hour or day, greatly reducing the quantity of data retrieved. Another potential solution could be improving the indexing in the database as @pottiepierre suggests in #2412.
Database
MySQL
Relevant log output
No response
Which browser are you using? (if relevant)
N/A
How are you deploying your application? (if relevant)
Vercel & Netlify with PlanetScale

Temporary improvement
If you are using Vercel and are on a Pro/Enterprise account, you can have up to 5 mins/300 seconds of serverless function execution. Add below to a vercel.json file and push up to your repo:
{
  "functions": {
    "src/pages/api/**/*": {
      "maxDuration": 300
    }
  }
}

This seems to be a issue with our self-hosted DB options (psql/mysql) and higher traffic websites. Probably need to revisit the indexing to see if there can be improvements there. For rolling data into hours, days, etc we looked into timescaleDB as a psql extension, but I guess there should be a way to implement materialized views in our current options. Also we are looking to add ClickhouseDB support to our self-hosted options. We use the same database for our cloud product and it has no problems querying tables with billions of records.

the requests fail

I have over 100K visits every day, and it takes tens of seconds to open the weekly report (on a 4 cores Ryzen 7950x server). Shows errors like yours too. Therefore, I had to stop using Umami because it writes millions of records in the database and does not regularly clean up and summarize them.

@franciscao633 is this triaged or planned for development? Would be good to know a schedule of release for this bug fix, thanks!

Interesting. In terms of app performance I'm mostly interested about indexing on session / website_event. Any noticable improvements on your end from the changes? I agree with @yuanfanzz, in that we won't see huge performance leaps until we start aggregating the data and running queries on those instead of the entire table. Also finally getting around to supporting ClickhouseDB for those who want to self-host high traffic websites.

Not had a chance yet to make a dump of the database, apply and compare the changes but hopefully later in the week my schedule will clear and I can give you a breakdown of before and after.
Data aggregation is a good idea, there are pros and cons for it and lots of open question for consideration around cost of background processes, data increase size, data loss on query, etc...

Managed to get round to some light tests, TL;DR they are better, but not definitive. I made two branch dumps on PlanetScale and applied the recommendations listed above to one of them, built and served the site from my machine and queried the page view endpoint 6 times for the applied recommendations and for the original (current) database schema.
Endpoint
http://localhost:3000/api/websites/[WEBSITE_ID]/pageviews?startAt=1709856000000&endAt=1710460799999&unit=day&timezone=Europe%2FLondon
Results

Current migration
Recommendations applied

13.89s
12.89s

18.18s
12.79s

12.37s
12.87s

19.22s
12.91s

9.57s
12.84s

13.3s
13.22s

Conclusion
On average the current migration took 14.42s and with the recommendations the average query took 12.92s.
Other notes
I did however test the difference between using a specific AWS endpoint on PlanetScale (eu-west.connect.psdb.cloud) vs the auto-resolver (aws.connect.psdb.cloud) and it increased speeds from ~22s to the figures shown above. Not important for most users but could cause some performance improvements for PlanetScale users.

Not stale

Aggregated data for quick queries would be excellent!
@franciscao633 In the meantime: Is a timeout set for the queries in the frontend of Umami? I couldn't find anything like that in the source code, but I can execute a query via API for 130 seconds without any problems, while in the frontend the connection is terminated after only 10 seconds with a 500 error (but unfortunately without any further information about why the status 500 is returned).

Not stale

following this issue, it seems performance improvement is needed for websites with high traffic.


[LOW] [Splits] [$500] Web - Split bill - Split bill shortcut directs to 404 page after splitting a bill with one account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.59-0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team
Action Performed:

Click on FAB and select Request money
Select manual > enter any valid amount and continue
Click on Split on any one participant and click on Add to split
Click on Split {currency} {amount}
Click on FAB and click on the split bill shortcut

Expected Result:
Split bill shortcut should open
Actual Result:
Hmm... it's not here page opens
Workaround:
n/a
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/461d3b0a-aa08-4c3c-bdc1-c2649c866602
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01356e4f802ce02d01
Upwork Job ID:<PHONE_NUMBER>005824512
Last Price Increase: 2024-04-02

@lschurr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Pressing the split bill shortcut after splitting bill with one user leads to not found page.
What is the root cause of that problem?
When we open the split bill from the shortcut, the canCreateRequest condition will be false.
https://github.com/Expensify/App/blob/d7161ae40ea3c09a041fca7c680bdfd8dea0d4fe/src/pages/iou/request/IOURequestStartPage.js#L116
And that's because getMoneyRequestOptions doesn't include the split bill option for 1:1 DM.
https://github.com/Expensify/App/blob/d7161ae40ea3c09a041fca7c680bdfd8dea0d4fe/src/libs/ReportUtils.ts#L4989-L4995
https://github.com/Expensify/App/blob/d7161ae40ea3c09a041fca7c680bdfd8dea0d4fe/src/libs/ReportUtils.ts#L4802-L4809
That's why you can't see the split bill option from composer + menu, but you can still split with one user.
What changes do you think we should make in order to solve the problem?

Split bill with one user is totally valid, so I think we can start showing the split bill option for 1:1 DM too by removing the hasMultipleOtherParticipants conditions (or replacing it with otherParticipants.length > 0).
What alternative solutions did you explore? (Optional)
If we don't want to show the split bill option in the composer + menu but still allow it from the shortcut, then we can:

Add a new param to canCreateRequest whether to include a split bill for 1:1 DM or not and pass true for the money request page.
OR
Add a new param to the money request page indicating the user is coming from the shortcut and always allow the user to create a request.

Looks like we have an inconsistency here as @bernhardoj's proposal points out. We can create a split with a single user from the FAB, but it doesn't show as an option in a 1:1 chat (from the composer + menu). I would say it makes sense to fix up that consistency, so I'd go with the main solution.
I'm not 100% whether there might be some reason for keeping the Split Bill option out of 1:1 DMs, so asking on Slack just in case!
:ribbon::eyes::ribbon: C+ reviewed

Confirmed on Slack that Split bill should be present on 1:1 DMs.

Thanks for double checking @jjcoffee. Agreed that @bernhardoj's proposal looks good 👍

PR is ready
cc: @jjcoffee

PR hit production last week (2024-04-10), so payment should be due tomorrow!

Thanks for the bump @jjcoffee!

Payment summary:

Contributor: @bernhardoj $500 (to be paid in Upwork)
Contributor+: @jjcoffee $500 (to be paid in Upwork)


Generate product types to contain fallback values for unions

Supplying an additional input value to use in the case that the value to be converted from arrays is a non-finite floating-point value gets tricky with unions; we must have a product type that contains a constructor corresponding to each constructor available in the union, because we don't know which constructor we will be in at runtime.
ACs:

Automatically generate type definitions for products dual to unions that are defined in kitty protos

Automatically generate the corresponding non-finite fallback type hierarchy including these products in place of their unions

(Extricated from https://kitty-hawk.atlassian.net/browse/SW-5707)

Greg Pfeil
January 7, 2022, 3:48 PM
Peddie’s parting words on this are that it’s not currently necessary, but would be if we ever have a sum type that has floating point values on more than one alternative.


Add a Codacy badge to README.md

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

See the complete overview on Codacy


Reuse WRKDIR_ARCHIVE_FORMAT for the value of PKG_FORMAT in pkgbase

pass on WRKDIR_ARCHIVE_FORMAT as PKG_FORMAT to pkgbase package builds

I think PKG_EXT/PKG_SUFX is more proper here and relates to #459 somewhat. The extensions are all hardcoded currently.
WRKDIR_ARCHIVE_FORMAT is for debug tarballs of work directories and not the package format.

I think PKG_EXT/PKG_SUFX is more proper here and relates to #459 somewhat. The extensions are all hardcoded currently.
WRKDIR_ARCHIVE_FORMAT is for debug tarballs of work directories and not the package format.

in that case we should maybe call it PKG_FORMAT :D

in that case we should maybe call it PKG_FORMAT :D


added generic linux (.tar.gz) to pkgType config

Hi Rodrigo,
this is my first contribution to an Atom package. So maybe I'm doing all wrong :)
I like your package but needed a new package type to download the ".tar.gz" file.
Could you have a look and maybe release a new version?
What I stumbled upon is that the possible values for the config pkgType are not only in main.js but also in package.json. Can you explain me the reason or show me a good documentation that I can learn from?
Thanks a lot in advance!
Cheers,
Marc

Thanks for the contribution, sorry for the delay in evaluating your request.


Update OpenTelemetry types

This PR updates our typed interfaces from https://github.com/open-telemetry/opentelemetry-js to  revision 45be4b524ef65638ac1ab142c2b5e01e1af2b3fd.
Unfortunately, OpenTelemetry doesn't have published packages we can depend on yet, so I can't switch over to that. The delta from the previous revision are pretty minimal/mechanical.

@ramya-rao-a Revved the package numbers. Currently core-http is the only thing that directly depends on core-tracing to avoid a singleton problem with rollup.

This might be a silly question, but I didn't see how the span are started now. You removed a lot of .start() lines, so I assume it's started doing construction?

That's right @jonathandturner
See https://github.com/Azure/azure-sdk-for-js/blob/f9156930e26d9e483b9e8fbe6292e5dca63f178d/sdk/core/core-tracing/lib/plugins/opencensus/openCensusSpanPlugin.ts#L33


[BUG] OSD distribution for 3.0.0 is invalid due to  security-analytics-dashboards-plugin

What is the bug?
We use nightly builds per version to create playgrounds here: https://playground.nightly.opensearch.org/3x/app/login?
For a long time, 3.0.0 playground is not usable due to below error:
Version: 3.0.0
Build: 8004
Error: vega is undefined
@https://playground.nightly.opensearch.org/3x/8004/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:13:1728233
@https://playground.nightly.opensearch.org/3x/8004/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:13:1680414
@https://playground.nightly.opensearch.org/3x/8004/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:13:1680456
@https://playground.nightly.opensearch.org/3x/8004/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:13:2159585
__webpack_require__@https://playground.nightly.opensearch.org/3x/8004/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:1:936
@https://playground.nightly.opensearch.org/3x/8004/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:1:50640
__webpack_require__@https://playground.nightly.opensearch.org/3x/8004/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:1:936
@https://playground.nightly.opensearch.org/3x/8004/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:37:426256
__webpack_require__@https://playground.nightly.opensearch.org/3x/8004/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:1:936
get@https://playground.nightly.opensearch.org/3x/bootstrap.js:22:25
read@https://playground.nightly.opensearch.org/3x/8004/bundles/core/core.entry.js:15:435962
createPluginInstance@https://playground.nightly.opensearch.org/3x/8004/bundles/core/core.entry.js:15:438401
setup@https://playground.nightly.opensearch.org/3x/8004/bundles/core/core.entry.js:15:437765
setup@https://playground.nightly.opensearch.org/3x/8004/bundles/core/core.entry.js:15:442821

How can one reproduce the bug?
Steps to reproduce the behavior:
Try deploying OSD tarball x64 distribution
What is the expected behavior?
Cluster should come up and should be usable
What is your host/environment?

OS: Linux
Version 3.0.0

Do you have any screenshots?
https://playground.nightly.opensearch.org/3x/app/login?
Do you have any additional context?
Add any other context about the problem.

I believe we saw a similar problem for 2.x (2.17) but it was resolved by the team. Not sure what the exact action item was. @amsiglan @riysaxen-amzn  can you help here?
Thanks!

[Catch All Triage - 1, 2]


How to test the trained model in new tasks?

I have a question is that if you do test with the trained model. If the answer is positive, could you share the method. I train BMAML in Ant for 200 times and draw the curve with the max average return of 5 particles. But how can I test the model in new tasks?  I try to make the "load_policy" is true but the result is not right. So could you tell me how to deal with it?

I think the function of "load_policy" is to comtinue or extand the tranin times. For example, if I have trained 30 times and want to add 20 times, I can load the itr_30.pkl of the 30 times' and set up the meta-itr=50, is that right?
But how to test the trained model? I am really confused with it. Hope for your reply. Thank you very much.

I trained the model in Ant with the command
python bmaml_examples/locomotion/bmaml_ant.py --num_particles=5 --num_parallel=10 --fast_lr=1.0 --meta_step_size=0.01 --fast_batch_size=50 --meta_batch_size=20 --meta_iter=250 --meta_method=chaser --method=svpg --svpg_alpha=0.1
The random seed is 1 and the result is as follow. As we can see, the result is not very better, I wonder if there is some more reasonable parameters. I don't know the reason why the model will get worse when they in about 150 itr.

Any ideas on how to fix the issue or work around it?
Thank you.

I change  the seed=0 and now have the result as follow. The result is similar. In my opinion,  I think maybe the fast_lr=1.0 is too high which result to overfiting. I really have no idea why the result is so bad. The model trained by maml is better than Bmaml's and the tendency of maml is right.....

Hi Morantumi,
Thank you for your interesting about our project.
Let me explain from the beginning.

how to test the trained model?
we didn't implement the test code separately. As you mentioned, the 'load_policy' configuration is to continue training from the finished one before. But it is not working correctly when I checked so I commented 'it is not working.'

Ant experiment
Yes, I also think fast learning rate is too big when comparing my history. And, I'm not sure which option you choose (task option), if you select goal direction, on the goal direction task, our model showed high fluctuation as our paper (but it outperformed maml).

If you can share the details, then let me test on my side too.
Thanks.
Regards, Jaesik.

Thank you very much for your reply!
First, I choose the task：

ant_env_rand_goal
The reason why I choose the fast_lr=1.0 is that I get good result when I use the method of MAML with this value in environmnet ant_env_rand_goal. The parameters setting in MAML is  that
fast_lr=1.0  meta_lr=0.01 kl_weighting=0.1

So I implement the BMAML with the same fast_lr and meta_lr. Maybe it causes the problem.
Besides, I do not clear the impact of the parameter SVPG_lr,  could you tell me the specific value of this parameter when trained in the locomotion environment. The results of BMAML I showed  was obtained in SVPG_lr=0.1. I notice that the computation code about the SVPG is as follow, so I think it may also have a major impact on the final result. If I should change it to 1.0? Could you tell me the vaule of this parameters.
grad=(tf.matmul(kernel_mat,((1/self.svpg_alpha)*f_g_list))-grad_kernel)/len(self.policy_list)
PS:
The result of MAML in  ant_env_rand_goal is as follow:

Could I know the running script for MAML?

Of course.
I use the code from https://github.com/cbfinn/maml_rl, also is implemented in Rllab.
The aglo is sandbox.rocky.tf.algos.maml_trpo
The policy is maml_minimal_gauss_mlp_policy
The environment is ant_env_rand_goal
The script is python train.py Maml --env Ant --fast_batch_size=50 --meta_batch_size=20 --fast_learning_rate=1 --meta_learning_rate=0.01 --seed=1 --kl_weighting=0.1  init_std=1
I also set  num_total_tasks=100  num_grad_updates=1 n_itr=300

The maml uses TRPO, which is powerful and expensive algorithm for reinforcement learning. As we described in our paper, we thus compared emaml-trpo vs bmaml-trpo and emaml-reptile vs bmaml-chaser.

Thanks very much for your reply.
It's my fault to ignore this. I will change the maml-trpo to the maml-reptile and then do the experiment again.  I do this comparement becuase the following result in the paper. I wil retry the experiment.

Besides, I confused with the value setting of fast_lr and svpg_lr for the ant_env_rand_goal for a long time. I has tried  fast_lr=1.0 and svpg_lr=0.1 but the result is bad.  It takes many days to complete 200 times itr.
So, could I know the specific values for these two parameters for Ant tasks?
Hope for your advice and thank you very much.

Yon can check that in running_scripts.txt

Thank you for your reply! It is really very helpful. Thank you very much.


Document -H/--host option

File: engine/reference/commandline/cli.md
On this page, the format for --host is not documented. Or, if it is documented, it should be linked to from this page.
Similarly, the documentation for context create does not document it either. Specifically, I'm looking for how to use ssh:// URLs. I'll keep on hunting, but I'm guessing it isn't documented anywhere.

SSH URLs might be related to my issue:
https://github.com/docker/docker.github.io/issues/11747

Thanks for sharing the issue. This particular content is maintained in an upstream repo with the CLI. If the issue is still applicable, please help create an issue in the source repo at https://github.com/docker/cli/tree/master/docs/reference/commandline
There is a little more info on the man page at https://github.com/docker/cli/blob/master/man/docker.1.md


feat: add tracking for the create Kafka instance event

@pilhuhn could you please give a look at this as well?


[803] Make job alert references required

Trello card URL:
https://trello.com/c/npmtxxuy/803-reference-numbers-for-job-alerts-should-not-be-machine-generated-but-a-mandatory-human-reference-so-that-the-alert-reference-is
Changes in this PR:
This removes the reference setter in favour of requiring presence. It also includes a small copy change.

 Reference numbers for job alerts should not be machine generated but a mandatory human reference so that the alert reference is clear and understandable


WalletConnect No Longer Working

Describe the bug
WalletConnect no longer seems to be working on our website
To Reproduce
Steps to reproduce the behavior:

Click 'Unlock Wallet'

Select WalletConnect

See Error

Expected behavior
This should properly connect to the dapp via WalletConnect

@0xModene I'll take an attempt at this.

This can be closed, worked with dylan and he deployed the last PR, and WC is now working on the site.


Question about new additions

Hi,
I am currently doing another project with LibGDX/LibKTX and I missed a few extensions that I implemented now myself but I could also make them a contribution to LibKTX if needed.
The things I am missing:

destructor operators for certain "math" shapes like Rectangle, Ellipse, ...
a use extension for TiledMap renderer (similar to what we have for batch)

Is that something useful? Or do you think that should not be part of LibKTX?
Rectangle example:
operator fun Rectangle.component1(): Float = this.x
operator fun Rectangle.component2(): Float = this.y
operator fun Rectangle.component3(): Float = this.width
operator fun Rectangle.component4(): Float = this.height

Sure, these could be added to ktx-math and ktx-tiled respectively. Would you like to submit a PR?

Yes, I will try to create one over the weekend :)


Extended GET / PUT / DELETE resources (licenses)

This commit implements confapi-commons 0.24 interface implementation
for the löicenses resource.

obsolete


Review all the titles for the Parasol theme

No more "Streamlining insurance claims with OpenShift AI"

2.1 "Getting Support for RH1"
Change title and support instructions.


⚠ Bofrost.fr has degraded performance

In 70d6b65, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1223 ms

Resolved: Bofrost.fr performance has improved in 88d6ad3 after 312 days, 17 hours, 42 minutes.


Verify API Snippets

Adding the code snippets for the Verify API.

It's just the comment that sticks out I think. Everything looks ok to me!

Shouldn't have approved there. I meant to leave a comment instead! Sorry!


UPSTREAM: :Bump go version

Update the Go version to execute the Snyk scan and identify the CVEs that need fixing.

did you run go mod tidy? because it's showing a diff

did you run go mod tidy? because it's showing a diff

Sorry about that, pushed the changes.


Disable idempotency on streams

Idempotency should be opted out when is not needed.

On SQL Server: Datareader with idempotency turned off could find some NULL values.
Data is Null. This method or property cannot be called on Null values.
Reader should handle nulls on OperationId


Liquibase 4.9.0 and "endDelimiter:/" recognizes "/" used in PL/SQL code for calculation as changeset end delimiter

Environment
Liquibase Version:
4.9.0
Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>
CLI in Image from https://hub.docker.com/r/liquibase/liquibase
Liquibase Extension(s) & Version:
n.a.
Database Vendor & Version:
Oracle Database 21 XE (<IP_ADDRESS>) provided by gvenzl/oracle-xe

Operating System Type & Version:
Podman 4.0.1 on Linux
Description
With Liquibase 4.8.0 the installation of an PL/SQL function in an Oracle 21 XE database including / for calculation purposes in the source code is working without any problems.
After upgrade of the Liquibase image to version 4.9.0, the installed source code of the function in the database ends before / in the return statement and the function in the dabase is invalid because of missing code.
Steps To Reproduce
Environment

Oracle Database 21 XE Image
JDBC driver from Oracle Instant Client <IP_ADDRESS>.0 64bit on Linux
Liquibase 4.8.0 Image
Liquibase 4.9.0 Image
Podman 4.0.1

Changelog install_functions.yaml
#
# install_functions.yaml
#
databaseChangeLog:
    - include:
        file: create_fnc_get_elapsed_time.sql
        relativeToChangelogFile: true

Changeset create_fnc_get_elapsed_time.sql
--liquibase formatted sql
--changeset data_public:create_fnc_get_elapsed_time.sql dbms:oracle endDelimiter:/ failOnError:true runAlways:true runOnChange:true stripComments:false splitStatements:true

CREATE OR REPLACE FUNCTION fnc_get_elapsed_time
  (i_start_time                    IN NUMBER
   ,i_end_time                     IN NUMBER
  )
      RETURN NUMBER
      PARALLEL_ENABLE
  IS
  BEGIN

      RETURN ((i_end_time - i_start_time) / 100);

  EXCEPTION
      WHEN OTHERS
      THEN
          BEGIN
              RAISE;
          END;
  END fnc_get_elapsed_time;
/

Execution of Liquibase 4.8.0
time podman run \
        --name lb-ora \
        --rm \
        --volume /database:/liquibase/changelog:Z \
        --volume /opt/oracle/instantclient:/liquibase/instantclient:ro \
        docker.io/liquibase/liquibase:4.8 \
        --changeLogFile=install_functions.yaml \
        --defaultsFile=/liquibase-development.properties \
        --password="pwd" \
        update

Execution of Liquibase 4.9.0
time podman run \
        --name lb-ora \
        --rm \
        --volume /database:/liquibase/changelog:Z \
        --volume /opt/oracle/instantclient:/liquibase/instantclient:ro \
        docker.io/liquibase/liquibase:latest \
        --changeLogFile=install_functions.yaml \
        --defaultsFile=/liquibase-development.properties \
        --password="pwd" \
        update

Liquibase properties
#
# properties for installation of database objects using Liquibase
#
classpath: /liquibase/changelog:/liquibase/instantclient
driver: oracle.jdbc.OracleDriver
liquibase.hub.mode: off
logLevel: warning
url: jdbc:oracle:thin:@<hostname>:1521/xepdb1
username: <username>
strict: true

Actual Behavior
Partly output when Liquibase 4.9.0 is executed with logLevel: debug:
[2022-03-27 15:52:48] FINE [liquibase.executor] Executing with the 'jdbc' executor
[2022-03-27 15:52:48] FINE [liquibase.util] Computed checksum for inputStream as 31c679bed1defccaefd71f030edcc363
[2022-03-27 15:52:48] FINE [liquibase.util] Computed checksum for 8:31c679bed1defccaefd71f030edcc363: as 94140ee341f64935c5e26926f93ff590
[2022-03-27 15:52:48] FINE [liquibase.servicelocator] Loaded liquibase.hub.HubService instance liquibase.hub.core.MockHubService
[2022-03-27 15:52:48] FINE [liquibase.servicelocator] Loaded liquibase.hub.HubService instance liquibase.hub.core.StandardHubService
Running Changeset: 012-DATA_PUBLIC/create_fnc_get_elapsed_time.sql::create_fnc_get_elapsed_time.sql::data_public
[2022-03-27 15:52:48] FINE [liquibase.changelog] Running Changeset: 012-DATA_PUBLIC/create_fnc_get_elapsed_time.sql::create_fnc_get_elapsed_time.sql::data_public
[2022-03-27 15:52:48] FINE [liquibase.executor] Changeset 012-DATA_PUBLIC/create_fnc_get_elapsed_time.sql::create_fnc_get_elapsed_time.sql::data_public
[2022-03-27 15:52:48] FINE [liquibase.changelog] Reading ChangeSet: 012-DATA_PUBLIC/create_fnc_get_elapsed_time.sql::create_fnc_get_elapsed_time.sql::data_public
[2022-03-27 15:52:48] FINE [liquibase.database] Executing Statement: CREATE OR REPLACE FUNCTION fnc_get_elapsed_time
  /**
   * Calculates the current elapsed time in seconds since the given start time.
   *
   *
   */
  (i_start_time                    IN NUMBER
   ,i_end_time                     IN NUMBER
  )
      RETURN NUMBER
      PARALLEL_ENABLE
  IS
  BEGIN

      RETURN ((i_end_time - i_start_time)
[2022-03-27 15:52:48] FINE [liquibase.executor] Executing with the 'jdbc' executor
[2022-03-27 15:52:48] FINE [liquibase.configuration] No configuration value for liquibase.sql.logLevel found
[2022-03-27 15:52:48] FINE [liquibase.configuration] Configuration liquibase.sql.logLevel is using the default value of FINE
[2022-03-27 15:52:48] FINE [liquibase.executor] CREATE OR REPLACE FUNCTION fnc_get_elapsed_time
  /**
   * Calculates the current elapsed time in seconds since the given start time.
   *
   *
   */
  (i_start_time                    IN NUMBER
   ,i_end_time                     IN NUMBER
  )
      RETURN NUMBER
      PARALLEL_ENABLE
  IS
  BEGIN

      RETURN ((i_end_time - i_start_time)
[2022-03-27 15:52:48] FINE [liquibase.executor] 0 row(s) affected
[2022-03-27 15:52:48] FINE [liquibase.database] Executing Statement: 100);

  EXCEPTION
      WHEN OTHERS
      THEN
          BEGIN
              RAISE;
          END;
  END fnc_get_elapsed_time;
[2022-03-27 15:52:48] FINE [liquibase.executor] Executing with the 'jdbc' executor
[2022-03-27 15:52:48] FINE [liquibase.executor] 100);

  EXCEPTION
      WHEN OTHERS
      THEN
          BEGIN
              RAISE;
          END;
  END fnc_get_elapsed_time;
[2022-03-27 15:52:48] FINE [liquibase.executor] Release Database Lock
[2022-03-27 15:52:48] FINE [liquibase.executor] Executing with the 'jdbc' executor
[2022-03-27 15:52:48] INFO [liquibase.lockservice] Successfully released change log lock
[2022-03-27 15:52:48] SEVERE [liquibase.integration] ORA-00900: invalid SQL statement

liquibase.exception.CommandExecutionException: liquibase.exception.LiquibaseException: Unexpected error running Liquibase: Migration failed for change set 012-DATA_PUBLIC/create_fnc_get_elapsed_time.sql::create_fnc_get_elapsed_time.sql::data_public:
     Reason: liquibase.exception.DatabaseException: ORA-00900: invalid SQL statement
 [Failed SQL: (900) 100);

  EXCEPTION
      WHEN OTHERS
      THEN
          BEGIN
              RAISE;
          END;
  END fnc_get_elapsed_time;]
        at liquibase.command.CommandScope.execute(CommandScope.java:163)
        at liquibase.integration.commandline.CommandRunner.call(CommandRunner.java:51)
        at liquibase.integration.commandline.CommandRunner.call(CommandRunner.java:21)
        at picocli.CommandLine.executeUserObject(CommandLine.java:1953)
        at picocli.CommandLine.access$1300(CommandLine.java:145)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2352)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2346)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2311)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2179)
        at picocli.CommandLine.execute(CommandLine.java:2078)
        at liquibase.integration.commandline.LiquibaseCommandLine.lambda$execute$1(LiquibaseCommandLine.java:325)
        at liquibase.Scope.child(Scope.java:189)
        at liquibase.Scope.child(Scope.java:165)
        at liquibase.integration.commandline.LiquibaseCommandLine.execute(LiquibaseCommandLine.java:291)
        at liquibase.integration.commandline.LiquibaseCommandLine.main(LiquibaseCommandLine.java:80)
Caused by: liquibase.exception.LiquibaseException: Unexpected error running Liquibase: Migration failed for change set 012-DATA_PUBLIC/create_fnc_get_elapsed_time.sql::create_fnc_get_elapsed_time.sql::data_public:
     Reason: liquibase.exception.DatabaseException: ORA-00900: invalid SQL statement
 [Failed SQL: (900) 100);

  EXCEPTION
      WHEN OTHERS
      THEN
          BEGIN
              RAISE;
          END;
  END fnc_get_elapsed_time;]
        at liquibase.integration.commandline.Main$1.run(Main.java:443)
        at liquibase.integration.commandline.Main$1.run(Main.java:221)
        at liquibase.Scope.child(Scope.java:189)
        at liquibase.Scope.child(Scope.java:165)
        at liquibase.integration.commandline.Main.run(Main.java:221)
        at liquibase.command.AbstractCliWrapperCommandStep.run(AbstractCliWrapperCommandStep.java:32)
        at liquibase.command.CommandScope.execute(CommandScope.java:157)
        ... 14 more
Caused by: liquibase.exception.LiquibaseException: liquibase.exception.MigrationFailedException: Migration failed for change set 012-DATA_PUBLIC/create_fnc_get_elapsed_time.sql::create_fnc_get_elapsed_time.sql::data_public:
     Reason: liquibase.exception.DatabaseException: ORA-00900: invalid SQL statement

Expected/Desired Behavior
PL/SQL source code using / for calculations is valid installed in an Oracle database and is not recognized as "endDelimiter" character of a Liquibase changeset.
Screenshots (if appropriate)
PL/SQL source code in Oracle SQL Developer after installation with Liquibase 4.8.0:

PL/SQL source code in Oracle SQL Developer after installation with Liquibase 4.9.0:

Additional Context
There seems to be a change in liquibase-core/src/main/java/liquibase/util/StringUtil.java, which could be relevant for the changed behaviour in Liquibase 4.9.0.

We have encountered this issue as well, and I find it a very critical and an absurd one.
Has this seriously not been looked into since March?

Not a bug - unless Liquibase has changed since 3.x …
endDelimiter:/  instructs Liquibase to treat any and all “/“ as the end of command
In SQL*Plus etc, / is treated as a command terminator only under circumstances (first non-space character on a line, possibly also last non-space character on a line).
I remember encountering problems when running scripts written on Windows (line terminator \r\n)
but executed on Linux (line terminator \n) so the pattern “^\s*/\s*$” didn’t work, which is probably why the guy below used this pattern: “\n/\s*\n|\n/\s*$”
https://stackoverflow.com/questions/2251079/liquibase-uploading-many-oracle-triggers-in-one-file

Thank you for the fix.
I tested Liquibase 4.15 with my Oracle database setup and the problem has been resolved.


python3Packages.mdformat: 0.7.6 -> 0.7.7

Motivation for this change
Update to latest upstream release 0.7.7
Change log: https://mdformat.readthedocs.io/en/stable/users/changelog.html#id1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Duplicate of #128876


Fix sql injection rule

From slack conversation with @joreiche:
Yevhen Zavhorodnii
11:25 AM
I believe it should be like here: https://github.com/Threagile/threagile/pull/74
So:
Lax database connection is only HTTP/HTTPS/Binary/BinaryEncrypted
For lax database connection we're only creating a risk even when technology is not vulnerable to query injection
For normal database connection we're only creating a risk when technology is vulnerable to query injection
Joerg Reichelt
5:50 PM
you can do a query injection over any protocol - even encrypted.
Joerg Reichelt
5:56 PM
what does lax mean in this context? I am assuming that it means there isn't the same strict syntax checking as with sql but that may or may not be true. in any case, if we assume that non-strict db protocols are more vulnerable to query injection then the logic is correct because it would mean:
query injection is a potential issue if either
you have a strict db protocol and that protocol is vulnerable to query injection, or
you have a non-strict db protocol (in which case query injection vulnerability is implied)
Joerg Reichelt
5:58 PM
however, I would suggest to make the evaluation precedence explicit by saying:
if (potentialDatabaseAccessProtocol && isVulnerableToQueryInjection) ||
potentialLaxDatabaseAccessProtocol {
add risk
}
Sounds like LGTM from him for me


Update description to use helm version3+

Many commands do not work anymore because of the changes made to helm version 3+.
Since the documentation already pointed to installing 3 and upwards it is best to make sure that the rest of the description matches the correct version of Helm.

@benkoben : Thanks for your contribution! The author(s) have been notified to review your proposed change. @caya

#please-close


Fixed quadratic easing function typos

Deprecated and added deprecationWarning for the incorrectly spelled QUADRACTIC_IN, QUADRACTIC_OUT, and QUADRACTIC_IN_OUT in Source/Core/EasingFunction.js and added the correct spellings. Changed the only two internal references to the incorrect spellings (in Specs/Scene/TweenCollectionSpec.js).
This addresses the open issue:  #9220. It will be resolved after the deprecation period.
Note that there were two sandcastles here and here that already use the correct spellings of the quadratic easing functions and were so far silently failing (reverting to a default easing function). After this fix, they will be using the correct intended easing functions.
TODO Before Merging:

Decide how long the deprecation period should be (which Cesium release to remove the old spellings).
Me or someone else can substitute the ????s for the correct version number in the JSDocs, deprecation warnings, and CHANGES.md.

Thanks for the pull request @nithinp7!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

From offline discussion, I believe the code will need to use Object.defineProperties in order to use getters in a way that's compatible with ES5 and IE11.
Object.defineProperties(EasingFunction, {
  QUADRACTIC_IN: {
    get: function () {
      deprecationWarning(
        "QUADRACTIC_IN",
        "QUADRACTIC_IN is deprecated and will be removed in Cesium ????. Use QUADRATIC_IN instead."
      );
      return Tween.Easing.Quadratic.In;
    },
  },
  QUADRACTIC_OUT: {
    get: function() {
        ...
    }
  }
}

Also from offline discussion, we will end the deprecation period in 3 releases, so Cesium 1.79.

@nithinp7 excellent - documentation looks good, sandcastles still work, deprecation message gets printed correctly. Thanks as well for the detailed PR description.
Now that this is merged can you open an issue so that we remove the deprecated enums in 1.79? In that issue give some instructions for what needs to be done to remove the deprecated behavior. I think it's just removing the Object.defineProperties(EasingFunction block. See https://github.com/CesiumGS/cesium/issues/7394 for an example. Also, make sure to assign the remove in 1.79 label to the issue (you may need to create a new label).

I also pushed a commit directly that moved the changes into the 1.77 section. https://github.com/CesiumGS/cesium/pull/9264/commits/470b0a6bb6c5195a5a2306f19b9e1b21b9842204


Lazy Loading of a form

Does formly allow lazy loading of a form that is organized in tabs? We have a form that has about 100 questions and alot of validations in various fields. I've disabled the api check and still it takes about 40-50 seconds to render the form. Is there a way we can lazily load this form so it renders more faster may be in 10-15 seconds by only loading the first tab and load the other tabs when the user clicks on the individual tabs?

I recommend that your tabs implementation uses ng-if to wait to compile the tab until it's shown. If you need help doing this, please follow the instructions here: http://help.angular-formly.com
Because this repo's github issues are reserved for bug reports and feature requests, I'm going to close this issue. Good luck!