redirect_uri_mismatch and step2 exchange broken

Error: redirect_uri_mismatch

Application: xxxx

You can email the developer of this application at<EMAIL_ADDRESS>
The redirect URI in the request, http://localhost:5000/, does not match the ones authorized for the OAuth client. Visit https://console.developers.google.com/apis/credentials/oauthclient/xxxx.apps.googleusercontent.com?project=xxxx to update the authorized redirect URIs.

Learn more
Request Details

    access_type=offline
    scope=https://www.googleapis.com/auth/analytics.readonly
    response_type=code
    redirect_uri=http://localhost:5000/
    client_id=xxxx.apps.googleusercontent.com

If I got to localhost:5000 manually I still get an error in the lib below.
(venv) rich@rich-vbox:~/Projects/github/analyses$ python
Python 2.7.12 (default, Aug  6 2016, 22:45:47)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import googleanalytics as ga
>>> accounts = ga.authenticate(save=True, interactive=True)
Human-readable account name: ga
Authentication flow completed. You may close the browser tab.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/rich/Projects/github/analyses/venv/lib/python2.7/site-packages/googleanalytics/auth/__init__.py", line 83, in authenticate
    suffix=suffix,
  File "/home/rich/Projects/github/analyses/venv/lib/python2.7/site-packages/googleanalytics/auth/__init__.py", line 113, in authorize
    credentials = oauth.authorize(base_credentials.client_id, base_credentials.client_secret)
  File "/home/rich/Projects/github/analyses/venv/lib/python2.7/site-packages/googleanalytics/auth/oauth.py", line 34, in authorize
    return flow.step2_exchange(qs['code'])
KeyError: 'code'

Did you set up any authorized redirect URIs? If you don't set up any, it will work with localhost but if you do set them up, you might need to include localhost explicitly among them.


Suddenly not works

3 days ago everything was fine.
Today even I tried
api.get_sd_models()
the result is
{'detail': 'Not Found'}
If call api.txt2img()
the result is
RuntimeError: (404, '{"detail":"Not Found"}')
Can anyone help? Thanks!

Have you forgotten to add --api when running webui?

Have you forgotten to add --api when running webui?

Thanks for your reminding. I did add --api.
Later I restarted the server and it worked well again.
Thanks!


Structured control flow checks should be optional.

My understanding is that SPIR-V v1.0 specification doesn't force control flow to be structured. OpenCL C support things like 'goto' and OpenCL C -> SPIR-V compiler from here produces SPIR-V files with unstructured control flow. These SPIR-V files do not pass structured control flow checks.
Can we make them optional for SPIR-V files produced from OpenCL C?
I attached CL source and SPIR-V file demonstrating the issue.
sample_test.zip

The sample.spv shader uses OpCapability Shader.  That's what's turning on the checks.  When I remove that instruction then the module passes the validator.


Run time error while fine tuning

I am trying to fine tune the model. And I am stuck with this error

Epoch 1/10:  23% 34/145 [00:24<01:21,  1.36step/s, loss=1.92, step=34] Traceback (most recent call last):   File "/content/F5-TTS/train.py", line 94, in <module>     main()   File "/content/F5-TTS/train.py", line 88, in main     trainer.train(train_dataset,   File "/content/F5-TTS/model/trainer.py", line 229, in train     loss, cond, pred = self.model(mel_spec, text=text_inputs, lens=mel_lengths, noise_scheduler=self.noise_scheduler)   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1562, in _call_impl     return forward_call(*args, **kwargs)   File "/usr/local/lib/python3.10/dist-packages/accelerate/utils/operations.py", line 820, in forward     return model_forward(*args, **kwargs)   File "/usr/local/lib/python3.10/dist-packages/accelerate/utils/operations.py", line 808, in __call__     return convert_to_fp32(self.model_forward(*args, **kwargs))   File "/usr/local/lib/python3.10/dist-packages/torch/amp/autocast_mode.py", line 43, in decorate_autocast     return func(*args, **kwargs)   File "/content/F5-TTS/model/cfm.py", line 273, in forward     pred = self.transformer(x = φ, cond = cond, text = text, time = time, drop_audio_cond = drop_audio_cond, drop_text = drop_text)   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1562, in _call_impl     return forward_call(*args, **kwargs)   File "/content/F5-TTS/model/backbones/unett.py", line 162, in forward     text_embed = self.text_embed(text, seq_len, drop_text = drop_text)   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1562, in _call_impl     return forward_call(*args, **kwargs)   File "/content/F5-TTS/model/backbones/unett.py", line 57, in forward     text = self.text_embed(text) # b n -> b n d   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1562, in _call_impl     return forward_call(*args, **kwargs)   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/sparse.py", line 164, in forward     return F.embedding(   File "/usr/local/lib/python3.10/dist-packages/torch/nn/functional.py", line 2267, in embedding     return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse) RuntimeError: Expected tensor for argument #1 'indices' to have one of the following scalar types: Long, Int; but got torch.cuda.FloatTensor instead (while checking arguments for embedding)

these are the inputs I am using.
target_sample_rate = 24000
n_mel_channels = 100
hop_length = 256
tokenizer = "pinyin" # 'pinyin', 'char', or 'custom'
tokenizer_path = None # if tokenizer = 'custom', define the path to the tokenizer you want to use (should be vocab.txt)
dataset_name = "My_Dataset"
-------------------------- Training Settings --------------------------
exp_name = "E2TTS_Base"  # F5TTS_Base | E2TTS_Base
learning_rate = 5e-06
batch_size_per_gpu = 38400  # 8 GPUs, 8 * 38400 = 307200
batch_size_type = "frame"  # "frame" or "sample"
max_samples = 2  # max sequences per batch if use frame-wise batch_size. we set 32 for small models, 64 for base models
grad_accumulation_steps = 1  # note: updates = steps / grad_accumulation_steps
max_grad_norm = 1.
epochs = 10  # use linear decay, thus epochs control the slope
num_warmup_updates = 20  # warmup steps
save_per_updates = 500  # save checkpoint per steps
last_per_steps = 5000  # save last checkpoint per steps
Is this error something related to my dataset or my input? Can anyone help?

'indices' to have one of the following scalar types: Long, Int; but got torch.cuda.FloatTensor instead (while checking arguments for embedding)
maybe you need to check the tensor's type

@rasheed-aidetic I may guess that you have an empty text sample, check it out. If it intended, you may add the type converter in TextEmbedding
        if text.dtype is not torch.long:
            text = text.long()

Thank you so much @MilanaShhanukova


Set up infrastructure

Infrastructure pieces needed:

[x] Linting (how about this @jarrodmillman ?)
[x] CONTRIBUTOR.md

This may need to point to more detailed files in doc/dev/
Style guide

[x] Travis CI
[x] Coverage
[x] Sphinx

Python

[x] Data loader

Assorted todo's

[x] Close fake issues #1 and #2

Issues #1 and #2 are now fixed.

THIS IS NOT REAL


Add way to enable and disable tests that are using deprecated endpoints

I was hoping to use t.Skipf at the end of the test if a client uses a matched path, but test failures overwrite skipping. Given we need to parse the output though (see #3) we can maybe do a fixed string to mark it as deprecated?

Usage would be to include a skip path list like:
/_matrix/client/v1/events
/_matrix/client/v1/initialSync

which then gets matched in the CS API client transport. So technically it doesn't "disable" the test as setup code will run, but it will mark the test in some way.

I thought about having test metadata but it's a pain to fill out and can get out-of-sync. Better to rely on the actual HTTP requests made.

What do you think about moving tests of deprecated enpoints to dedicated files with a specific build tags?
One can then run the tests for a given version of the API.
Something like https://stackoverflow.com/a/38439941/3207406

We already do this for things like benchmarks and (soon) for MSCs, so this is probably the right way to go about it tbh.

We use build tags for blacklisting stuff now, which is basically the same thing. Closing.


[Auto-generated] Update requirements.txt

Update requirements.txt
Automatically created PR from the ci_update_requirements.yml workflow.

Codecov Report

:exclamation: No coverage uploaded for pull request base (ci/dependabot-updates@ef95f89). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             ci/dependabot-updates     #124   +/-   ##
========================================================
  Coverage                         ?   68.62%
========================================================
  Files                            ?       18
  Lines                            ?      494
  Branches                         ?        0
========================================================
  Hits                             ?      339
  Misses                           ?      155
  Partials                         ?        0

Flag
Coverage Δ

pytest
68.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef95f89...e2f37a1. Read the comment docs.


Cannot install MSMPI with not default msmpisdk way

I'm trying to install msmpi from vcpkg with command vcpkg install msmpi:x64-windows, but I get an error:
PS D:\Alex\Documents\SourceTree\vcpkg> .\vcpkg.exe install msmpi:x64-windows
The following packages will be built and installed:
    msmpi[core]:x64-windows
Starting package 1/1: msmpi:x64-windows
Building package msmpi[core]:x64-windows...
A suitable version of cmake was not found (required v3.10.2). Downloading portable cmake v3.10.2...
-- CURRENT_INSTALLED_DIR=D:/Alex/Documents/SourceTree/vcpkg/installed/x64-windows
-- DOWNLOADS=D:/Alex/Documents/SourceTree/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=D:/Alex/Documents/SourceTree/vcpkg/packages/msmpi_x64-windows
-- CURRENT_BUILDTREES_DIR=D:/Alex/Documents/SourceTree/vcpkg/buildtrees/msmpi
-- CURRENT_PORT_DIR=D:/Alex/Documents/SourceTree/vcpkg/ports/msmpi/.
-- Using cached D:/Alex/Documents/SourceTree/vcpkg/downloads/msmpisdk-9.0.msi
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Using cached D:/Alex/Documents/SourceTree/vcpkg/downloads/msmpisetup-9.0.exe
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
CMake Error at ports/msmpi/portfile.cmake:56 (message):
    Could not find:
      C:\Program Files/Microsoft MPI/Bin/mpiexec.exe
    Please install the MSMPI redistributable package before trying to install this port.
    The appropriate installer has been downloaded to:
      D:/Alex/Documents/SourceTree/vcpkg/downloads/msmpisetup-9.0.exe

Call Stack (most recent call first):
  scripts/ports.cmake:72 (include)

Error: Building package msmpi:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: msmpi:x64-windows
  Vcpkg version: 0.0.108-2018-04-10-b4aad86642c50afcbaa4e348dba2b8f86c28ad56

Additionally, attach any relevant sections from the log files above.

I have Windows 10 x64 Pro v1709.

How can I install this library without reinstalling MSMPI?

vcpkg is not going to actually install msmpi, it's just going to download the installer, and once you install it check whether it is installed.
Looks like you have msmpi installed already, did you verify whether this file C:\Program Files/Microsoft MPI/Bin/mpiexec.exe exist?

This file does not exist, because I was changed the destination folder when I was installing it. It exists by D:\Program Files\Microsoft MPI\Bin\mpiexec.exe way (other, not system installed drive)

@AJIOB просто распакуй и скопируй с заменой по тем путям, которые имеются
just unpack and copy with a replacement on the paths that are available

@Voskrese которые требует vcpkg?
Unpack in that way, that vcpkg tool require for MSMPI installing?

@AJIOB да, девятую версию, vcpkg проверяет из строки версии
D:\Program Files\Microsoft MPI\Bin - сюда исполняемые и со скриншота либы и хидеры
могу посоветовать прошрамму распаковке всяких разных архивов  Universal Extractor (UniExtractor)

@Voskrese файлы лежат на D, но он их на C все равно ищет. Почему? Цель этого issue, чтобы это и поправили (и брали пути из переменных среды)

@AJIOB хмм.. из реестра первой установки, либо в скрипте поиско жеско пути прописаны.
ок, вопрос ясен

Hi @AJIOB , thanks for reporting this issue!
It seems to have fixed a near version. So I closed it.
Please open a new issue if this is still a problem for you.
Thx.


Detecting invalid cbor when deserializing multiple objects

I am deserializing multiple objects from a slice (like in https://github.com/pyfisch/cbor/issues/20).
I am using the EOF error to detect when I reached the last object, but I have no way to distinguish between an actual EOF and an invalid cbor object.
It would be great to have an Iter implementation that does the right thing or that the thrown error had not the current offset in the stream but the offset where the deserialization began.

Can you check if the slice is empty rather than if you get an EOF error to detect the end of the sequence?

@sfackler is the slice being mutated by the deserializer?

Could you show your code?

Sure, simplified:
fn decode_next<'a>(
    de: &mut serde_cbor::Deserializer<SliceRead<'a>>,
) -> Result<Option<Value>, CborError> {
    let res: Result<Value, CborError> = de::Deserialize::deserialize(de);
    match res {
        Ok(v) => Ok(Some(v)),
        Err(ref e) if e.is_eof() => Ok(None),
        Err(e) => Err(e),
    }
}

// I use it like:
let mut results = Vec::new();
loop {
    let res = decode_next(&mut deserializer)?;
    match res {
        Some(v) => {
            results.push(v);
        }
        None => {
            break;
        }
    };
}

It's not trivial to detect if cbor is invalid (it's very dense and almost every possible combination of values are valid) but having to rely on an error to know then the stream is finished vs failed seems like an hack.
Also, the above would be a lot better in an iter :)

There are ways you can work around it but they're pretty convoluted. I opened up a PR to just add a StreamDeserializer which should be much easier to work with! #72.

Makes sense, thanks @sfackler!


[Bug]: OpenAPI3 YAML emitter causes the Norway problem

Describe the bug
The openapi yaml emitter causes the Norway problem because it doesn't quote strings properly.
model A {
    @example("no")
    a?: string;
    @example("yes")
    b?: string;
}

@example(#{a: "no", b: "yes"})
model B {
    a?: string;
    b?: string;
}

becomes
openapi: 3.0.0
info:
  title: (title)
  version: 0.0.0
tags: []
paths: {}
components:
  schemas:
    A:
      type: object
      properties:
        a:
          type: string
          example: no
        b:
          type: string
          example: yes
    B:
      type: object
      properties:
        a:
          type: string
        b:
          type: string
      example:
        a: no
        b: yes

All of those no and yes must be quoted, because otherwise they become boolean False and True when the yaml is parsed.
The optionality of quoting strings in yaml is fundamentally dangerous. Please just quote all strings.
Reproduction
Playground Link
Checklist

[x] Follow our Code of Conduct
[x] Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
[x] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[x] The provided reproduction is a minimal reproducible example of the bug.

Kinda feels like this might be more a problem with the parser, this is valid emitted yaml 1.2 no?
We could consider adding an option to emit 1.1 if the yaml library allows it which is not super clear from their doc(I see they allow on parsing but don't know for stringify).

Oh wow! TIL yaml got an update for this a very long time ago and just didn't get any support in some widely used parsers. Apologies, and thanks for that correction. Don't I feel foolish now.
This creates a kind of weird situation for openapi generation, because they do say that 1.2 is "recommended", but then that leaves the world in a kind of weird state re. parsing incapability, buuuuuut that's not your problem. I'm just going to close this issue.


Add unreferenced support libraries to cql_dependency_structure.

Pull requests into Bonnie Bundler require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
A measure will fail to load properly if a measure has a support library, but does not use any of the definitions or functions in that library and instead only references a value set or a DRC from the library. This issue is due how we build cql_dependency_structure. In order to fix this, we now add all libraries to the cql_dependency_structure. If the library has no dependencies we assign it to an empty hash.
Submitter:

[x] This pull request describes why these changes were made.
[x] This PR is into the correct branch.
[x] JIRA ticket for this PR: https://jira.mitre.org/browse/BONNIE-1270
[x] JIRA ticket links to this PR:
[x] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] Tests are included and test edge cases
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[x] Code coverage has not gone down and all code touched or added is covered.

In rare situations, this may not be possible or applicable to a PR. In those situations:

Note why this could not be done or is not applicable here:
Add TODOs in the code noting that it requires a test
Add a JIRA task to add the test and link it here:

[x] Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

[x] JIRA test links: N/A
[x] Justification for using JIRA tests: N/A
[x] JIRA tests have been added to sprint: N/A

Reviewer 1:
Name: @losborne

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[x] JIRA tests have been run and pass N/A
[x] You agree with the justification for use of JIRA tests or have provided input on why you disagree N/A

Reviewer 2: @mayerm94
Name:

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[x] JIRA tests have been run and pass
[x] You agree with the justification for use of JIRA tests or have provided input on why you disagree

failing due to security vulnerabilities - need to update to latest prod release


Make rollover idempotent

Resolves #1403
Signed-off-by: Pavol Loffay<EMAIL_ADDRESS>

I am happy that it's not ruby :hankey:


Is this project still active?

https://pub.dev/packages/binance says the project is discontinued, but judging from the activity here it doesn't look like it.
Just checking-in, thanks!

Hi, I am interesting in this project too.  So, Is this project still active?  Please.  Thank you.

I discontinued it because I'm no longer able to promise full support. But I still use it in production to this day in a small app. Use at your own risk.


Add functional tests for cFE Table Registration APIs

Is your feature request related to a problem? Please describe.
Need open source functional tests for certifiability
Describe the solution you'd like
Add functional tests for cFE Table Registration APIs
CFE_TBL_Register - Register a table with cFE to obtain Table Management Services.
CFE_TBL_Share - Obtain handle of table registered by another application.
CFE_TBL_Unregister - Unregister a table.
Describe alternatives you've considered
N/A
Additional context
N/A
Requester Info
Alex Campbell GSFC

I'll start working on this.


update config to match with json tag

Fixes #
pilosa server can run with default config
Pull request checklist

[ ] I have read the contributing guide.
[ ] I have agreed to the Contributor License Agreement.
[ ] I have updated the documentation.
[ ] I have resolved any merge conflicts.
[ ] I have included tests that cover my changes.
[ ] All new and existing tests pass.

Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

[ ] Ensure that any changes to external docs have been included in this pull request.
[ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.
[ ] Ensure the new code is properly commented and follows Idiomatic Go.
[ ] Check that tests have been written and that they cover the new functionality.
[ ] Run tests and ensure they pass.
[ ] Build and run the code, performing any applicable integration testing.

I agree, I just updated the json tag that I think the simplest way to fix thing if we don't care about struct/json consistent name


add extra volume mounts

https://github.com/DependencyTrack/helm-charts/pull/20#issuecomment-2058885050
It's not possible to add custom volumes to the pod, which is useful for a number of use cases and makes it easier for users to extend the helm chart.

I will try to create a PR tomorrow for this.


iOS 13 Dark Mode

Perhaps a new default value that switches between SVProgressHUDStyleLight and SVProgressHUDStyleDark based on the dark mode setting?

Good idea. A PR is warmly welcome.

@honkmaster any update on this?

Lol

.

👹

This would be an incredibly useful feature


Create quickstarts and explain: ZTNA, ZTHA, ZTAA

We have decent doc outlining what ZTNA/HA/AA looks like, but not decent examples showing somone how to put it into practice with OpenZiti. Illustrate each level of zero trust with an example. Right now the "my first service" is effectively ZTNA when run from the docker compose world, but ZTHA when used as is but it's not spelled out in detail, for good reason i think.
This feels like separate pages for each topic along with examples and explanations and fits into the "learn" bucket

done by dariusz a while back


Check for GetGitRevision module

CMake should check for the GetGitRevison module before it errors out (and just spring a warning instead).

Never mind. We'll just always include the GetGitRevision module. Closed with carothersc/ROSS@a70373a8b70d3b3b4d5aef3bfb67ba2f913e1587


⚠ Bofrost.lu has degraded performance

In dac0512, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1347 ms

Resolved: Bofrost.lu performance has improved in 104c746 after 8 minutes.


Mysos CLI.

It would be nice to have a CLI that wraps around the RESTful APIs.

It'd be even greater if it integrated with the DCOS :D

Integration would be nice, but being able to use it separately is a hard requirement IMHO.

https://issues.apache.org/jira/browse/COTTON-12


Make modules documentation more prominent and add simple examples

Circe is a superb library which provides a lot of useful functionality, but it's spread across a lot of modules and it's not always obvious where to look for a particular thing.
This issue aims to address it by providing an overview of modules in documentation with simple examples of usage. It might also be good to accompany each module's description with a short motivation note to explain why the decision to separate some functionality was made.

I'm going to start by going through the list of modules at http://circe.github.io/circe/api/ to see if I can figure out how to present each one of them. Some I've already used and have an idea of what might be the most important things to demonstrate to get people started faster, others I did not, so I'll be able to note what might be the most confusing things about using them (if any) from a "clean" perspective.
Hopefully I'll have some time to start drafting a PR this weekend.

👍 this sounds great.

Closing in cleanup run, If anyone cares about this, please comment and I'll reopen.


Manually add sql not set time query exception

GORM Playground Link
https://github.com/go-gorm/playground/pull/14
Description
Manually add sql not set time query exception

https://github.com/go-gorm/playground/pull/15

Fixed, thank you for your report.


Figure out why our coverage reports show low coverage for models.py

As part of #732, I was looking at the coverage reports for models.py, and apparently our coverage system shows all the models definitions as uncovered, which I don't think really makes sense.  We should investigate what we need to do to make the coverage reporting reasonably accurate for models.py.

Probably the same as this stackoverflow post. If you generate coverage instead with:
coverage run --branch ./tools/test-backend
coverage report
coverage html -d coverage-report

you get:


Disable the Redis network filter

Issue #12139 highlighted a problem with the Redis filter. This disables the filter completely to avoid breaking Istio networking.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: venilnoronha
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cc @howardjohn / @duderino
dont forget to merge this for the next RC

@venilnoronha: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Is there any docs that need to be updated for this?

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2cf3c0237ad8d911f49223cf76ed32d1ac547710
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

No, docs weren't updated for Redis.

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2cf3c0237ad8d911f49223cf76ed32d1ac547710
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
38687fd878f33aa3a81e52b3cd54bce75f4cdcb0
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2cf3c0237ad8d911f49223cf76ed32d1ac547710
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
38687fd878f33aa3a81e52b3cd54bce75f4cdcb0
link
/test istio-presubmit

prow/istio-unit-tests.sh
38687fd878f33aa3a81e52b3cd54bce75f4cdcb0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2cf3c0237ad8d911f49223cf76ed32d1ac547710
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
38687fd878f33aa3a81e52b3cd54bce75f4cdcb0
link
/test istio-presubmit

prow/istio-unit-tests.sh
38687fd878f33aa3a81e52b3cd54bce75f4cdcb0
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
38687fd878f33aa3a81e52b3cd54bce75f4cdcb0
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: venilnoronha
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
1d72d1d625a8dc3aa962c2dc664b1ddbb8d49647
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2cf3c0237ad8d911f49223cf76ed32d1ac547710
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests-minProfile.sh
aa29ec6d000a65bac576bd9cc2a0ac6a2b6f65e4
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-minProfile.sh
aa29ec6d000a65bac576bd9cc2a0ac6a2b6f65e4
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-multicluster-e2e.sh
aa29ec6d000a65bac576bd9cc2a0ac6a2b6f65e4
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-minProfile.sh
aa29ec6d000a65bac576bd9cc2a0ac6a2b6f65e4
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-multicluster-e2e.sh
aa29ec6d000a65bac576bd9cc2a0ac6a2b6f65e4
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
aa29ec6d000a65bac576bd9cc2a0ac6a2b6f65e4
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Snowman bootstrapping can be blocked with empty ids

Describe the bug
Same as https://github.com/ava-labs/gecko/issues/94 but different application.
With Snowman, a validator can cause bootstrapping to hang in another node by responding to a Get request with the requested blkID and modified bytes that point to an empty parent. The bootstrapping node will be blocked as it searches for the nonexistent id,
/snow/networking/sender/sender.go#87: Sending Get to validator NwEmCRVweJs9vTin7LpnweWSKVP4AB9Qi. RequestID: 10. ContainerID:<PHONE_NUMBER>1111111111111111111111LpoYY
To Reproduce
Bootstrap a node and sendRequest for an unkown block to a validator running,
func (t *Transitive) Get(vdr ids.ShortID, requestID uint32, blkID ids.ID) {
    if blk, err := t.Config.VM.ModifiedGetBlock(blkID); err == nil {
	t.Config.Sender.Put(vdr, requestID, blkID, blk.Bytes())
    }
}
func (vm *VM) ModifiedGetBlock(id ids.ID) (snowman.Block, error) {
    blk, err := vm.state.Block(vm.baseDB, id)
    blk.parentID = ids.Empty
    blk.UpdateBytes()
    return &LiveBlock{ vm: vm, block: blk, }
}
func (b *Block) UpdateBytes() {
    codec := Codec{}
    bytes, _ := codec.MarshalBlock(b)
    b.bytes = bytes
}

Expected behavior
Derive the block id from the block bytes before working with the payload data
By submitting this issue I agree to the Terms and Conditions of the Developer Accelerator Program.

Thanks for bringing this up.
To clarify you are saying that in a network with two nodes A, and B, if A sends a Get to B, then B can respond to this request with a block that doesn't match the requested block, right?

That's correct. If during bootstrapping B responds to A with a block that doesn't match the requested block and that new block has a parent that doesn't exist, A will continually search for the nonexistent parent block as pending remains > 0.


Doesn't work with an SFTP repo when run as Docker container - libssh2 handshake failed [-5]

Heya
I noticed that the exporter stopped working once I switched to an SFTP repo.
I am running it as a Docker container.
I tried attaching to the container shell with docker exec -it ... bash to check pgbackrest behavior within the container, and this is the error:
/# pgbackrest info
stanza: [invalid]
    status: error (other)
            [ServiceError] libssh2 handshake failed [-5]
    cipher: none

Please note that pgbackrest works on the host machine, that's why I thought it would make sense to raise an issue here, since there seems to be some discrepancy with the Docker image configuration.
Could you please point me in the right direction?

Hi
Which version of the exporter image are you using?
Is the same configuration pgbackrest used for the host pgbackrest and in the docker?
Could you provide logs for command pgbackrest info --log-level-console debug inside container (with error)?
It looks like there are configuration differences on the host machine and inside the container.
For example, is there an ssh connection to the sftp host from the container?

Is the same configuration pgbackrest used for the host pgbackrest and in the docker?

The pgbackrest configuration is mounted from the host via volume mount.

Could you provide logs for command pgbackrest info --log-level-console debug inside container (with error)?

Here is the output of the command as executed from within the exporter container:
2024-07-20 22:19:55.648 P00  DEBUG:     common/io/socket/common::sckInit: (block: false, keepAlive: true, tcpKeepAliveCount: 0, tcpKeepAliveIdle: 0, tcpKeepAliveInterval: 0)
2024-07-20 22:19:55.648 P00  DEBUG:     common/io/socket/common::sckInit: => void
2024-07-20 22:19:55.648 P00  DEBUG:     command/command::cmdBegin: info command begin 2.48: --buffer-size=16MiB --compress-level-network=3 --exec-id=2798-9dc5f8d9 --log-level-console=debug --repo1-path=/my-repo-1 --repo1-sftp-host=xx.xx.xxx.xxx --repo1-sftp-host-key-check-type=none --repo1-sftp-host-key-hash-type=sha256 --repo1-sftp-host-user=root --repo1-sftp-private-key-file=/var/lib/postgresql/.ssh/id_rsa --repo1-type=sftp
2024-07-20 22:19:55.648 P00  DEBUG:     config/load::cfgLoad: => void
2024-07-20 22:19:55.648 P00  DEBUG:     command/info/info::cmdInfo: (void)
2024-07-20 22:19:55.648 P00  DEBUG:     command/info/info::infoRender: (void)
2024-07-20 22:19:55.648 P00  DEBUG:     protocol/helper::repoIsLocal: (repoIdx: 0)
2024-07-20 22:19:55.648 P00  DEBUG:     protocol/helper::repoIsLocal: => true
2024-07-20 22:19:55.648 P00  DEBUG:     storage/sftp/helper::storageSftpHelper: (repoIdx: 0, write: false, pathExpressionCallback: *void)
2024-07-20 22:19:55.648 P00  DEBUG:     storage/sftp/storage::storageSftpNew: (path: {"/my-repo-1"}, host: {"xx.xx.xxx.xxx"}, port: 22, user: {"root"}, timeout: 60000, keyPriv: {"/var/lib/postgresql/.ssh/id_rsa"}, hostKeyHashType: sha256, param.keyPub: null, param.hostKeyCheckType: none, param.hostFingerprint: null, param.knownHosts: {[]}, param.modeFile: 0640, param.modePath: 0750, param.write: false, param.pathExpressionFunction: (function *))
2024-07-20 22:19:55.648 P00  DEBUG:     common/io/socket/client::sckClientNew: (host: {"xx.xx.xxx.xxx"}, port: 22, timeoutConnect: 60000, timeoutSession: 60000)
2024-07-20 22:19:55.648 P00  DEBUG:     common/io/socket/client::sckClientNew: => {type: socket, driver: {host: xx.xx.xxx.xxx, port: 22, timeoutConnect: 60000, timeoutSession: 60000}}
2024-07-20 22:19:55.739 P00  DEBUG:     command/info/info::infoRender: => {"stanza: [invalid]
                                            status: error (other)
                                                    [ServiceError] libssh2 handshake failed [-5]
                                            cipher: none
                                        "}
stanza: [invalid]
    status: error (other)
            [ServiceError] libssh2 handshake failed [-5]
    cipher: none
2024-07-20 22:19:55.739 P00  DEBUG:     command/info/info::cmdInfo: => void
2024-07-20 22:19:55.739 P00  DEBUG:     command/exit::exitSafe: (result: 0, error: false, signalType: 0)
2024-07-20 22:19:55.739 P00 DETAIL: statistics: {"socket.client":{"total":1},"socket.session":{"total":1}}
2024-07-20 22:19:55.739 P00  DEBUG:     command/command::cmdEnd: info command end: completed successfully (91ms)
2024-07-20 22:19:55.739 P00  DEBUG:     command/exit::exitSafe: => 0
2024-07-20 22:19:55.739 P00  DEBUG:     main::main: => 0

For example, is there an ssh/sftp connection to the sftp host from the container?

When I do ssh<EMAIL_ADDRESS>-i /var/lib/postgresql/.ssh/id_rsa from within the exporter container - it works fine and lets me into the server.
I suspect this has something to do with SSH client configuration or version inside the image.
I checked the ssh auth logs in the backup server, and it seems that the following error is attributed to the pgbackrest connection attempts from within the exporter container (e.g. when executing pgbackrest info:
Unable to negotiate with xx.xx.xxx.xxx port xxxxx: no matching host key type found. Their offer: ssh-rsa,ssh-dss [preauth]

Which version of the exporter image are you using?

fc059eb7d28a   6 months ago

Once I pulled the latest image, it started working! Thanks for the hint!


setRowData and Filters

Hi,
I noticed that in the column filters, if a user changes the dropdown from contains to equals, and doesn't enter anything into the search field before setRowData is called, the dropdown reverts back to contains, instead of keeping the state of the dropdown selection.
I am saving/restoring the filter state using the get/set filter models. It works fine if there is something in the text field, but if there isn't, the dropdown value doesn't save. My data is refreshing every 3 seconds, so if a user hesitates at all the drop down will revert.
Is there a fix or something that I can do to prevent this?

if you don't want the filter to change between loads, use:
filterParams: {newRowsAction: 'keep'}

https://www.ag-grid.com/javascript-grid-filtering/index.php


Is it possible to introspect and verify the composition of a schema generated with makeExecutableSchema?

I have an apollo server that uses graphql-tools makeExecutableSchema. I want to unit test the schema and resolvers so that my tests notice if an important field gets changed on a type or other situations like that.
I found this tutorial that does it. But it looks like what he's doing will only work if my schema is made of GraphQLObjectType.
So, my question is:
Is it possible to introspect and verify the composition of a schema generated with makeExecutableSchema?
If such functionality exists, can it be added to the docs?
Any suggested workaround if not?
Thanks for your time.

Hey @kierah! You can use printSchema from graphql-js to print your schema in the SDL format, and snapshot test that. Is that sufficient for your needs?

See https://github.com/apollographql/graphql-tools/issues/702#issuecomment-404974854 - thanks!


js close for alert boxes

Pivotal
The staff app features alert boxes, or flash messages, that have a close button marked with an 'x' that doesn't do anything. This lets the user close the messages by clicking the 'x'.

:+1:


[ACM-15010] Added error condition for invalid client id

Description
When a user has an invalid client ID, the discovery-operator is not removing any DiscoveredCluster resources from the console. This PR will add a new error condition for a invalid_client and remove any DiscoveredCluster resource from the cluster.
2024-10-23T14:24:44.803Z ERROR reconcile Error updating DiscoveredClusters {"error": "couldn't get token: &{401 invalid_client Invalid client or Invalid client credentials <nil> []}"}

Related Issue
https://issues.redhat.com/browse/ACM-15010
Changes Made
Added new error condition for invalid_client.
Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist

[ ] I have tested the changes locally and they are functioning as expected.
[ ] I have updated the documentation (if necessary) to reflect the changes.
[ ] I have added/updated relevant unit tests (if applicable).
[ ] I have ensured that my code follows the project's coding standards.
[ ] I have checked for any potential security issues and addressed them.
[ ] I have added necessary comments to the code, especially in complex or unclear sections.
[ ] I have rebased my branch on top of the latest main/master branch.

Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2
Definition of Done

[ ] Code is reviewed.
[ ] Code is tested.
[ ] Documentation is updated.
[ ] All checks and tests pass.
[ ] Approved by at least one reviewer.
[ ] Merged into the main/master branch.

/lgtm


Update README

📚 Documentation preview 📚: https://jaxsim--129.org.readthedocs.build//129/

I'll wait a quick check from @traversaro before merging.


Vim performance scope 2

prereqs:

#7281
#7260

This moves to make find_entries just a scope manipulation, so we can pass scopes around inside RBAC
/cc @matthewd @Fryguy
/cc @gtanzillo FYI - thanks for help with other sections

unWIPping - fixed rbac warnings, added a number of helpers to reduce the "if it is daily" logic. There is still more to do there

@chessbyte I updated find_for_interval_name - there was only 1 optional parameter.
But your primary question is still present.]
Should those go in as a hash or as multiple methods.
The goal is to mimic find_all_by_interval_and_time_range as closely as possible

@gtanzillo @blomquisg @Fryguy please review

ok.

changed timestamp to `time_range
reworked time_profile / tz so we didn't have those funky nil parameters.

Let me know what you think


Store endpoint address with file data in localStorage

Hi, When I pause or stop uploading a file, that file stored in localStorage and in next time when I uploading that's file again, FineUploader read that from localStorage.
Now I want to store Endpoint address in localStorage to in next time resume uploading file with stored Endpoint.
Can I do that?

No. Localstorage space is far too small to reliably store files.

But now, store file name and id in localStorage. And I need to store Endpoint address because I have many Endpoint address!

How would storing the file name be useful? How would you retrieve the file later?

Now, I have uploaded a file and while uploading I refresh the page and after that in my local storage following items stored!


chore: split out cli and api targets

TODO: no typings, yet. for some reason, parcel2 is not generating typings when using more than one target.

This was us trying to fight with parcel bundler. We have since ditched it.


Install with brew

Thanks for the tool, can you add support for install with homebrew?

@PhotonQuantum I just made a PR (https://github.com/PhotonQuantum/homebrew-tap/pull/2) to your homebrew-tap.


build: Consolidate check scripts and separate from linting

Adds a new "checks" script to the root package.json which runs all the CI checks locally, including the syncpack and prettier tasks.
Other relevant changes:

The lint tasks no longer run prettier.
The build script now runs all checks, not just policy/layer check.

Along the lines of Matt's comment in Teams, how about adding some markdown content somewhere with suggested workflows?


Could we add support to package the build result into Debian Package?

Sure, just send a patch or pull request, I'd be happy to take it.

Merge https://github.com/axboe/liburing/pull/22


backslash in text creates error condition

Describe the bug
Text which includes a backslashed punctuation character creates an error conditions. e.g. . [, etc.
Steps to reproduce

enter any line with text such as "this [word]" - no problem
put  a backslash in front of [ or .
results in "Error on text "This [word]"

Expected behavior
Just display the backslashed character.
Emacs functionality
Backslashed text is displayed properly, No error is raised.
Minimal init.lua
No changes made to default initl.lua
Screenshots and recordings
No response
OS / Distro
Ubuntu 21.04    5.11.0-40-generic #44-Ubuntu SMP
Neovim version/commit
NVIM v0.6.0-dev+575-g2ef9d2a66
Additional context
This may represent a known limitation, but I've not found it documented anywhere. Issue arose when taking notes on coding.

This is coming from treesitter parser. I'll need to check what's happening there.

Seems the issue may be a bit broader. The following line results in the same error:
'A random line with $ in it'
The issue seems to be the $ surrounded by blanks. If the $ is followed by text it is okay. e.g. $word is treated properly

And, if the last line in a fold ends in a period, it seems not be included in the fold.

And, if the last line in a fold ends in a period, it seems not be included in the fold.

Can you give an example here? I can't reproduce this. Other things are reproduced.

I'll try to recreate and let you know, but right now, I can't duplicate it.
I'm trying to convert files that I've been using on emacs and am having
regular weird issues with folding and "Error on text" without it being
clear what the issue is. I've attached a png of what I'm trying to sort out
now.
On Sat, Nov 20, 2021 at 12:38 PM Kristijan Husak @.***>
wrote:

And, if the last line in a fold ends in a period, it seems not be included
in the fold.
Can you give an example here? I can't reproduce this. Other things are
reproduced.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kristijanhusak/orgmode.nvim/issues/157#issuecomment-974708280,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJLLWQA7GJ56IY43JCO5W3UNABMPANCNFSM5IMTHW6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I'm not seing an image, probably because you wrote from in-mail. Make sure to recalculate folds with zx before reporting any potential issues, since Vim/Neovim folding can be a bit confused at first.

One problem I have that is reproducible in the inclusion of a standalone $
in text causes an error to be raised. Some of my org files include text
copied from a terminal session which tend to include such a  naked $. Don't
know if this is a bug, but it is a nuisance. If you like, I'll make that a
bug report.
Most of my other issues have been related to sloppy formatting which
emacs' orgmode seems to handle better.
Thanks.
Hal
On Sat, Nov 20, 2021 at 1:01 PM Hal @.***> wrote:

I'll try to recreate and let you know, but right now, I can't duplicate it.
I'm trying to convert files that I've been using on emacs and am having
regular weird issues with folding and "Error on text" without it being
clear what the issue is. I've attached a png of what I'm trying to sort out
now.
On Sat, Nov 20, 2021 at 12:38 PM Kristijan Husak @.***>
wrote:

And, if the last line in a fold ends in a period, it seems not be
included in the fold.
Can you give an example here? I can't reproduce this. Other things are
reproduced.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kristijanhusak/orgmode.nvim/issues/157#issuecomment-974708280,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJLLWQA7GJ56IY43JCO5W3UNABMPANCNFSM5IMTHW6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Theseshould be fixed with the latest master. If the issue persist, let me know and I'll reopen the issue.


Notice about 2D dataset

Some 2D ground-truth data of the 2D pose dataset provided by this repository has been shifted, so there are some areas that are not correct.
Check it with images
for example : S9 - Greeting, SittingDown 1 and Waiting 1
Also, The action name for this dataset is also strange.
I've visualized it and checked it all.
 We generate ".npz" using the code in "https://github.com/facebookresearch/VideoPose3D".


[Test] Write test for Stellar Asset Contract for an invalid asset

[Test] Write test for Stellar Asset Contract for an invalid asset.

We have tests for invalid assets in the footprint.


Adding CPU import conversion and ordinal assignment machinery.

During conversion to the LLVM dialect any func.call to an extern function or a function emitted during conversion will be lowered into an import call with a placeholder ordinal. This uses a technique like executable constants whereby imports get an attributed global placeholder for the ordinal that is assigned in the new LLVMCPUAssignImportOrdinals pass after linking. During serialization the import table built during assignment is used to declare the imports on the executable library data structure.
The automatic conversion comes courtesy of @nicolasvasilache and should handle most basic arg/result packing.
Minor fixes were required in the runtime for MSVC compatibility with embedded ELFs.
Fixes #7504.

@nicolasvasilache this should automate what you need - you can either come in to ConvertToLLVM with func.calls to external functions or emit them during ConvertToLLVM. Updated example: https://github.com/iree-org/iree/compare/benvanik-cpu-imports...benvanik-native-example?expand=1

Tested locally, LGTM, thanks much!


Request injected request singleton cloned

Builds on the hard work of @alkimake in #229 and fixes #228

🤦 wrong repo

lol :D


refactor: add financial mutation attributes to statements

There seems to be a test that is failing

There seems to be a test that is failing

Fixed it, the mock import was incorrect, so it tried to connect to the Moneybird Client.

Only one minor comment!


fix: prevent cache on optional package resolve (v3) (#10812)

cherry pick of #10812 for v3. looks like it isn't affecting heavily on ecosystem-ci
ref: https://github.com/withastro/astro/issues/5145

/ecosystem-ci run

@dominikg added support for testing the v3 branch on vite-ecosystem-ci. @bluwy I think you need to target v3 with this PR though 🤔. And then we can run ecosystem CI against it.

Ughh I forgot to change that 😅


Splitter - Set-Size example buggy / crashes

Description
When I do api().setSize("a", 10) I expect the panel to get resized to 10% of the size.
It doesn't do that consistently, just hitting the buttons makes the UI unresponsive.
Additionally: resizing a panel to under 10% and then setting the size to 10% throws an exception that the total is over 100%:
this breaks mouseover of the handle since state.context becomes undefined.
Link to Reproduction (or Detailed Explanation)
(video)
Steps to Reproduce
https://github.com/chakra-ui/ark/assets/719818/2dd3d1e8-f857-45cd-82f6-40cd8c31f2b7
(Code from https://ark-ui.com/react/docs/components/splitter)
import { Splitter } from '@ark-ui/solid'

export const RenderProp = () => (
  <Splitter.Root
    size={[
      { id: 'a', size: 50 },
      { id: 'b', size: 50 },
    ]}
  >
    <Splitter.Context>
      {(api) => (
        <>
          <Splitter.Panel id="a">
            <button type="button" onClick={() => api().setSize('a', 10)}>
              Set to 10%
            </button>
          </Splitter.Panel>
          <Splitter.ResizeTrigger id="a:b" />
          <Splitter.Panel id="b">
            <button type="button" onClick={() => api().setSize('b', 10)}>
              Set to 10%
            </button>
          </Splitter.Panel>
        </>
      )}
    </Splitter.Context>
  </Splitter.Root>
)

Ark UI Version
3.3.0
Framework

[ ] React
[X] Solid
[ ] Vue

Browser
Electron 29.1.5
Additional Information
No response

This issue does mention ArkUI 3.3.0, its really old version per my opinion.

Oh? I may try to reproduce it this weekend with current v4.2.0.

Hey @segunadebayo  any update on this? We're still encountering this, which is further described in #2967.
Still occurs on the latest version.


Check that certain decorations cannot be used more than once and/or are mutually exclusive

Fixes #1636

PTAL

PTAL

Please rebase and fix the formatting.


gsplat 1.0 breaks nerfstudio splatfacto

Describe the bug
gsplat 1.0 moves some files around to different folders which causes import failures on new nerfstudio builds due to no upper bound on gsplat dependency
To Reproduce
Steps to reproduce the behavior:

Install nerfstudio
Use splatfacto

ModuleNotFoundError: No module named 'gsplat._torch_impl'

+1 to this. Just ran pip install -U gsplat and got the same error after running ns-train --help

+1，I just run pip install gsplat==0.1.11 to avoid this and then i can use ns-train again

Not sure if either of you guys noticed this, but they recently pushed changes to this repo that fixes the problem with nerfstudio interfacing with gsplat 1.0.0. After rebuilding my working docker container, I was able to run pip install -U nerfstudio, which also upgraded gsplat to 1.0.0, which was encouraging to see.
That  said, the splats which i got after running it through my existing pipeline with gsplat 1.0.0 was surprisingly not usable. I'll probably be reverting back in the meantime. Curious if you guys run into a similar experience. I'll probably be opening up a new issue on this soon

@rowellz Please open issues if you experience any issue with the latest nerfstudio. Upgrading to gsplat 1.0.0 takes some effort before it stabilizes. If you have critical tasks, you can use nerfstudio 1.1.0 + gsplat 0.1.12

I have the same problem with the docker, and it is related to only one dn_splatter library
File "/home/user/nerfstudio/dn_splatter/dn_model.py", line 24, in
from gsplat._torch_impl import quat_to_rotmat
ModuleNotFoundError: No module named 'gsplat._torch_impl'
As I understand from looking at gsplat now this method should be called either through legacy_cuda or using normalize . At the moment the current version of nerfstudio from the docker doesn't work because of this library

I have the same problem with the docker, and it is related to only one dn_splatter library
            File "/home/user/nerfstudio/dn_splatter/dn_model.py", line 24, in <module>
               from gsplat._torch_impl import quat_to_rotmat
           ModuleNotFoundError: No module named 'gsplat._torch_impl'

https://github.com/maturk/dn-splatter/blob/bc83595b0685f0fba0f0b440d510bb9123a8fdb2/dn_splatter/dn_model.py#L24
As I understand from looking at gsplat now this method should be called either through .cuda or using normalize. Like this, for example:  from gsplat.cuda._torch_impl import _eval_sh_bases_fast Here is the reference: https://github.com/nerfstudio-project/gsplat/blob/3a184580a0509da80d8d7a56178ab5c6bb736575/examples/utils.py#L86 And here the code https://github.com/nerfstudio-project/gsplat/blob/3a184580a0509da80d8d7a56178ab5c6bb736575/gsplat/cuda_legacy/_torch_impl.py#L227

@efyphil, dn-splatter is not bundled with the docker image... you have installed the extenal dn_splatter library somehow within your docker container.

It's true, yes, but it really strange, i don't know how i install it

use nerfstudio 1.1.0 + gsplat 0.1.12

when I return to  nerfstudio 1.1.0 + gsplat 0.1.12, I got the error: ModuleNotFoundError: No module named 'nerfstudio.viewer.server.viewer_state'

Currently, the only combination that works for me is:         nerfstudio==1.0.3   gsplat==0.1.13


Support for influxdb 2.0

Now It seems that I can only find code about influxdb 1.x, so I wonder is there any plan about supporting benchmark with influxdb 2.0? Thanks!

Hello @dragonly, we don't have any plans for updating the influxdb to 2.0 for now, but Pull Requests are welcome :)

Two users have reported that InfluxDB v2 querying is 10x - 100x slower than v1.


registerCompletionItemProvider include extra data

VSCode Version: 1.29.0
OS Version: 10.3.3

Steps to Reproduce:

when i use registerCompletionItemProvider api, the IntelliSense include some extra data like this

i just want my data show

Does this issue occur when all extensions are disabled?: Yes

Extensions cannot mute other extensions. The design of the system it to be cooperative and not exclusive.


[feature] Swap selection contents

A feature that I often used in Sublime Text is text swapping. ctrl+T would swap the content when you had two selections active.

Any status on this?

@realappie, you can find out the current status of this project, using the iteration-plan label: https://github.com/Microsoft/vscode/labels/iteration-plan

@mrmlnc I was wondering if there is any status related to this feature. There is nothing in the iteration plans that mentions this feature, so the link you have sent me is kind of irrelevant :(

@ivancuric Check out this extension!

Thanks :) Already forgot about this issue since I've been using the same extension for months now :)


[EFCore] How to migration?

In EF7, we can use 'dnx ef migrations add xx'.
But in EF Core, I get a message: 'Microsoft.EntityFrameworkCore.Commands' does not contain a 'Program' type suitable for an entry point

The nightly builds are transitioning to the .NET Core CLI. DNX will no longer work. I recommend using RC1 until RC2 is released.

Work is already tracked by https://github.com/aspnet/EntityFramework/issues/3925

Thanks!


Missing security policy

I would like to report a potential security issue privately, but it is not clear how to do that as the repository has neither a SECURITY.md nor any obvious contact information for the author.

Please feel free to email me at<EMAIL_ADDRESS>.

Fixed in c2d3144


[Allure Report with Cucumber ] when we use @BeforeStep the output at the report is not formated like given/when/then annotations

Describe the bug
when we use @BeforeStep the output at the report is not formated like given/when/then annotations
To Reproduce
Steps to reproduce the behavior:

create simple BDD script
add @BeforeStep anotation
run your script and check allure report

Expected behavior
@beforeStep should be formated like given/when/then
Screenshots

@magdyheiba any news? Do you need any support?

reproduced case on local testing environment... preparing to fix.

fix will be to remove the steps completely from the summary to match the native cucumber report

fixed


Suggestion: Use a custom response for Beta Channel version, instead of using Ninja Cat

Make Cliptok auto-delete NC's response about beta channel (because NC doesn't grab the correct version sometimes)

Context: https://discord.com/channels/150662382874525696/187649467611086849/913026528063934514

The main blocker for me when thinking about this issue is what to put in the message that replaces the Ninja Cat one.
I could put something like "Check the thread list of #insiders to see the latest builds", but that might be confusing.
And then Cliptok doesn't really have any way of retrieving the most recent Beta build without searching the thread list itself, which seems unreliable.

This shouldn't be a problem for a while now, so I'll close the issue for the time being


Update SSP based on followup comments from JAB TRs

In order for our compliance reviewers to close out their remaining comments on our SSP, we need to update the remaining items that still give them questions or concerns.
Fully updated comment workbook: https://docs.google.com/spreadsheets/d/1181S9yd00UkR11gBsrPK7dEiefP_scSlz-Nz9l0R6sY/edit#gid=386614391
Our PMO would like this done by Thursday 12/8 COB.
Acceptance criteria
First stage (ASAP):

[x] CA-3 (3) is updated (some drafting at https://docs.google.com/document/d/1iOu5BfDp5kvfTT8p4bved65AxQTyaVD-wd3bad6Bz94/edit)
[x] All 5 DHS TR items are addressed in some meaningful way
[x] We've uploaded that SSP version to Google Drive and MAX, and we've emailed a note to the PMO (including both Bridget and Betsy)

Second stage, GSA and DoD items:

[x] RA and SI items are updated (https://docs.google.com/document/d/11aoiBj36dj_ITd982BGwifQH14Qy_oCnMGRGgeNG3g8/edit)
[x] All GSA items are updated or explained
[x] All DoD items are updated or explained
[x] We've uploaded that SSP version to Google Drive and MAX, and we've emailed a note to the PMO (including both Bridget and Betsy)

We uploaded 1.28 to address all of this! Closing this; followup items should go into new issues.


Adv/Dis on Saving throws or checks

I don't know if it's intended, but if you gain advantage or disadvantage on checks or saving throws, the roll doesn't change. For example, if you use enhance ability and choose Bear's endurance, the token gains the temp hp, but rolls aren't afected

DFreds will be the final judge, but I think that it is working as intended. Enhance Ability affects ability checks and not saving throws 🤷

Enhance ability should be working only on Abilitiy checks, not saving throws.
Are you using MidiQOL to fastForward rolls? If not, then you should try with the setting on for Fast Forward Ability Rolls

And if yes, do you also use Better Rolls? Maybe try without.
Just some input until DFreds picks this up ;)

@thatlonelybugbear correct. You need midi for advantage and disadvantage to actually work, and enhance ability does not affect saving throws.


Fix multiple incoming connections creation

This MR fixes multiple incoming connections creation.
Let me describe old behavior:
When you successfully creates first incoming connection with endpoint idsserver://<IP_ADDRESS>:9292 - ConnectorRef will be stored in CONNECTORS with key idsserver:<IP_ADDRESS>:9292.
Then, if you want to create one more incoming connection and by some reason you set endpoint to idsserver://<IP_ADDRESS>:9292 - ConnectorRef will not be found in CONNECTORS, because it's key will be idsserver:<IP_ADDRESS>:9292 and we will try to create new Jetty server on port 9292, but it will cause an exception, because 9292 port is already binded. And because of that exception - there will be method doStop called, that will clear whole CONNECTORS map.
I fixed all that issues: now <IP_ADDRESS>, localhost, <IP_ADDRESS> or local address (like docker pod name (i.e. provider-core)) will be replaced with local in getConnectorKey method.
Also, method doStop now will not clear whole CONNECTORS map, but will delete entry from it if connector.refCount == 0.

Hi @milux , could you please check this MR?


unix,win: unify timers implementation

/cc @libuv/collaborators
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/136/

12 files changed, 207 insertions(+), 407 deletions(-)

Look at those nice stats!

I see a warning (on Windows at least).  Looks like while the timeout is uint64_t, uv_backend_timeout returns int. I think we should change that to uint64_t. I can do that as a separate commit in this PR.

Looks like there were a number of problems with Jenkins, but LGTM once the CI is happy.

I just moved that code around...I guess we could even just inline the
number.
On Sep 18, 2016 3:17 PM, "Colin Ihrig"<EMAIL_ADDRESS>wrote:

@cjihrig commented on this pull request.
In src/win/core.c
https://github.com/libuv/libuv/pull/1058#pullrequestreview-475010:

@@ -159,6 +160,17 @@ static void uv_init(void) {
}

+/* The number of milliseconds in one second. */
+#define UV__MILLISEC 1000
This name seems a little misleading. Maybe UV_SECOND would be better?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/libuv/libuv/pull/1058#pullrequestreview-475010, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATYGBpusJ01RbUjvxuZuM8WbfkHzc-hks5qrTnVgaJpZM4J_2la
.

Ran another CI : https://ci.nodejs.org/view/libuv/job/libuv-test-commit/137
Looks :green_heart: to me.

Over all LGTM, few nits. Is UV__MILLISEC used anywhere but that line? If not, not opposed to inlining

LGTM.
One question: why were the implementations different?

Looks like I nedd to do some extra finagling on Windows, because we store the timeout as uint64_t and the Windows API takes a DWORD, which is a 32 bit integer.
I'll add some more changes here, also changing the return type to uint64_t.

One question: why were the implementations different?

They were developed by different people, in parallel.  Now it's time for a Grand Reunification. :-)

Updated, PTAL.
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/139/
Also, disregard that about uint64_t.

CI is 💚 , but not too sure about this : https://ci.nodejs.org/job/libuv-test-commit-windows/195/nodes=win2008r2-vs2013/console

@iWuzHere Thanks for the review!  That bot fails because master no longer support Visual Studio 2013.  Here's to the future! :cocktail:

Since we're here: @joaocgreis hey Joao, is it possible to remove the VS 2013 Windows bot for the master branch only? (v1.x should still test there)

@saghul Done (I hope). It is not possible to remove based on branch (because branch names change when testing PRs) but it is possible based on the libuv version (I guessed you want v2). So, Ci now runs grep -oP "^#define[[:space:]]*UV_VERSION_MAJOR[[:space:]]*\K[[:digit:]]*$" include\uv-version.h and if the output of that is >=2 and the current label is VS2013 it just marks the job as success and runs nothing. It is not possible (or I don't know how) to remove entry for VS2013 from just some runs, so it has to be there, just green.

@joaocgreis That will do.  Thanks a lot Joao!


Goto Def does not work for error keyword

Description:
$subject
Steps to reproduce:
Click the error keyword.
public function main(string name) returns error? {
    if (name.length() < 5) {
        error e = error("InvalidName", message = "invalid length");
        return e;
    }
}

Affected Versions:
1.2.0

Since this is a built-in constructor this should be ok. @KavinduZoysa @nadeeshaan Please reopen if you think otherwise.


API for performantly bulk-creating pages programatically

Fixes #10833 adds an API for bulk creating children.

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For new features: Has the documentation been updated accordingly?

@ababic does slug conflict matter at different depths of the tree? For example, if there's an object with the pathBread/bagel and we try to add another with the path Bread/FrenchBread/bagel should this be considered a conflict?

I understood your comments earlier but I have a few doubts regarding them:

Is there any benefits to making a set of the existing slugs instead of filtering out matches with the new slugs?
The check to see if auto-generated slugs are inside either the existing slugs or the new ones is only relevant for the immediate children of the tree being created right?
The data being passed is a recursive structure where the children can have their own children. I'm assuming slug conflict doesn't matter when they don't share the same parent so I created a recursive function that searches each level and makes srue there's no conflict and auto generates slugs based on slugs at each level. Is this correct or do I have to check the combined the original combined slug list everytime?

Hi @NXPY123.

Out of all of the common container types in Python, set is significantly faster than anything else when it comes to membership tests. So, if that's what you intend to use it for, why wouldn't you?
Slugs only have to be unique between siblings under the same parent. Personally I think that should be all we should be going for here... Making it recursive is a nice idea, but I would argue that use cases for that are quite rare, so the added code complexity is probably not worth it (Especially while we're still trying to get the basics right)

Can you please check the _check_unique() and bulk_add_children() methods in models/__init__.py ?

I've made changes to use bulk_create instead in 5be4dff. The page does seem to be made but I think the page is not set as the child page of the parent. Do we have to call add_child on the parent to be able to do this or is there any other way?

Hi @NXPY123. Thanks for sticking with it. Yes, it definitely won't work as it is. We need to replicate what add_child() does in terms of setting field values on the new child pages involved, and updating numchild on the parent page.

In the django-treebeard docs they suggest not changing the path, depth, and num_child values directly and using one of the methods instead. Is this something I should take into consideration?

@NXPY123 it's good to be cautious. I expect the reason the docs say that is to keep you using the documented APIs, because what happens underneath is quite complicated. However, I don't see how using those methods can work in a bulk creation context, because each use involves at least one write to the database (one of the key aims of this feature is to avoid that).

In the django-treebeard code, when the children have a sorted order set in the tree, they use this to find the location to add the child and get the path:
if self.pos == 'sorted-sibling':
            siblings = self.node.get_sorted_pos_queryset(
                self.node.get_siblings(), newobj)
            try:
                newpos = siblings.all()[0]._get_lastpos_in_path()
            except IndexError:
                newpos = None
            if newpos is None:
                self.pos = 'last-sibling'
        else:
            newpos, siblings = None, []

        _, newpath = self.reorder_nodes_before_add_or_move(
            self.pos, newpos, self.node.depth, self.node, siblings, None,
            False)

I'm kinda stuck trying to figure out how to get newpath for each child when we're bulk adding them since we're not committing and updating the query set each time we add a child so there is a possibility of conflict in the newpath we obtain for the children as the function will give out the same newpath for new children that are determined to have the same position in the queryset. I think converting the queryset to a list would help append the children as we create them but get_sorted_pos_queryset expects a queryset to be passed and this would affect that

Hi @NXPY123. I think we can ignore the 'sorted-sibling' case in your code sample (
we're only interested in the 'adding children to a parenr' case), which should simplify things somewhat. We just need to figure out how to generate path values for the new pages, in the order they are supplied. You might need to do a single query to identify the current maximum path for children at the same location.

Can you please check the changes I've made? I haven't checked the code when the children are ordered, only the case where it's unordered.

I've made changes as per the review. If they are fine I'll start making tests and moving the logic to Manager class.

Are these changes fine? Should I alter them?

Hi @NXPY123, I've left a little more feedback. Please continue with moving the changes to the Manager and adding tests. Things tend to change slightly during that process, so it will be better for me to review again once everything is finished.
Please also consider marking this PR as a draft until you are finished, as it helps other contributors to know that it's with you, and you aren't waiting on anyone else.

I've added tests. When I went through the bulk_create docs they mentioned a few caveats:

The model’s save() method will not be called, and the pre_save and post_save signals will not be sent.
It does not work with child models in a multi-table inheritance scenario.
If the model’s primary key is an AutoField and ignore_conflicts is False, the primary key attribute can only be retrieved on certain databases (currently PostgreSQL, MariaDB, and SQLite 3.35+). On other databases, it will not be set.
It does not work with many-to-many relationships.
It casts objs to a list, which fully evaluates objs if it’s a generator. The cast allows inspecting all objects so that any objects with a manually set primary key can be inserted first.

Will these cause issues when implementing the functionality?

@NXPY123 Ahh, that second point sounds like it could be problematic. Honestly, I find that quite surprising with how advanced the API is in other areas. Maybe it just hasn't been in-demand enough.

Hi @NXPY123. Just to put you on the right track, I was imagining that this would be baked into the existing BasePageManager class, rather than inventing a new concept. Ideally, we would overriding bulk_create() so that it is available from the manager of any page subclass. For example:
SimplePage.objects.bulk_create(simplepage_list, parent_page)

It sounds like we might be blocked on being able to utilise Django's default implementation, but that doesn't necessarily need to be the end of the story... I would suspect there is a workable solutions out there in the wild somewhere.

Hi @NXPY123. Just to put you on the right track, I was imagining that this would be baked into the existing BasePageManager class, rather than inventing a new concept. Ideally, we would override the default bulk_create() implementation, so that it is available from the manager of any page subclass. For example:
SimplePage.objects.bulk_create(simplepage_list, parent_page)

It sounds like we might be blocked on being able to utilise Django's default implementation, but that doesn't necessarily need to be the end of the story... I would suspect there is a workable solution out there in the wild somewhere.

I thought about it but wouldn't the BulkManager inherit methods of the models.Manager class which we wouldn't require?

@NXPY123 Ahh, that second point sounds like it could be problematic. Honestly, I find that quite surprising with how advanced the API is in other areas. Maybe it just hasn't been in-demand enough.

I found examples for workarounds here: https://stackoverflow.com/questions/49826482/django-valueerror-cant-bulk-create-a-multi-table-inherited-model
Can we use any of these?

I thought about it but wouldn't the BulkManager inherit methods of the models.Manager class which we wouldn't require?

We'll, yes, but that is really the point! 😀Bulk creation is typically done via a model's default Manager, so why should this be any different? In my view at least, the bulk creation logic isn't important enough to warrant invention of new concepts. I beleive developers would expect it to work as closely to the default bulk_create() implementation as possible (the only different being that a parent page must be provided).

I found examples for workarounds here. Can we use any of these?

Your first step really needs to be writing test that fail due to this limitation. If you're not getting a clear error about multi-table-inheritance not being supported, then clearly things aren't working the way you're intending. Once you're at the point where you're sure that's where the issue is, you'll be in a good place to experiment and see if you can get past it (we're not quite there yet, though).

I've put the method in the PageManager and set it as the default Manager for Page class. Is this fine?

@ababic sorry I couldn't work on this for a while. Are the changes made fine?


document new web3js plugin

add basic example to https://docs.celo.org/developer/sdks/celo-sdks
with link back to its github repo

Closed by https://github.com/celo-org/docs/pull/1511


53 organize cards booster pack and booster pack cards views and forms

Closes #53.
It requires #40 to be merged first.

Codecov Report

Merging #54 (604da67) into release-candidate (ae235f3) will not change coverage.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           release-candidate       #54   +/-   ##
===================================================
  Coverage             100.00%   100.00%
===================================================
  Files                     42        44    +2
  Lines                   1033      1116   +83
===================================================
+ Hits                    1033      1116   +83

Impacted Files
Coverage Δ

source/YugiAcademy/YuGiOh/apps.py
100.00% <100.00%> (ø)

...e/YugiAcademy/YuGiOh/booster_packs/booster_pack.py
100.00% <100.00%> (ø)

...iAcademy/YuGiOh/booster_packs/booster_pack_card.py
100.00% <100.00%> (ø)

...Oh/booster_packs/booster_pack_management_system.py
100.00% <100.00%> (ø)

...my/YuGiOh/booster_packs/tests/test_booster_pack.py
100.00% <100.00%> (ø)

...tests/test_booster_pack_based_management_system.py
100.00% <100.00%> (ø)

...GiOh/booster_packs/tests/test_booster_pack_card.py
100.00% <100.00%> (ø)

.../test_booster_pack_card_based_management_system.py
100.00% <100.00%> (ø)

source/YugiAcademy/YuGiOh/cards/spell_card.py
100.00% <100.00%> (ø)

.../YugiAcademy/YuGiOh/cards/tests/test_spell_card.py
100.00% <100.00%> (ø)

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fall back to /usr/lib/os-release if /etc/os-release doesn't exist

From https://www.freedesktop.org/software/systemd/man/os-release.html:

The file /etc/os-release takes precedence over /usr/lib/os-release.
Applications should check for the former, and exclusively use its data
if it exists, and only fall back to /usr/lib/os-release if it is
missing.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: oscarwcl sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Don't silently discard invalid inputs in txInsValues

Currently, invalid inputs caused by faulty constraints logic (i.e. there is no corresponding input in the lookups) are silently discarded https://github.com/Plutonomicon/cardano-transaction-lib/blob/c599f1c4f3eeb55a1236454ee6ca15a418fa9545/src/BalanceTx.purs#L919
This can cause non-intuitive behavior. It would be better if we threw an error here instead of using mapMaybe
Related: #107, although that's a much larger change. Here we can just throw an error

It would also be pretty straightforward to return an Either _ Value and use a traversal in txInsValue instead of throwing an impure exception


Fix adc_sequence channel vref conversion.

Fix wrong usage of channel adc_raw_to_millivolts on the sequence sample.
Fixes #75517.

@decsny Could you take a look on this? It fixes some misinterpretations with the original sample implementation.