Enable the workload cert rotate automatically

Enable the workload cert rotate automatically
Reference issue: https://github.com/istio/istio/issues/24554
Context:

PROV_CERT : user can set this file path to provide a valid cert as client cert to do mlts with ca for the first connection. If it is empty, it will use the token as a authentication method to work with ca
OUTPUT_CERTS: this is file path where user sets to store the signed cert from CSR response from CA. User should set it to the same as the PROV_CERT to enable the cert rotate

workflow
To enable the Rotate feature user should set the PROV_CERT == OUTPUT_CERTS and PROV_CERT should not be empty and provide a cert under the path

Start: the client will extract both the token in the jwtpath set by user and  the cert in the PROV_CERT path. If one of them succeed , the CSR request will be successful

Rotate: As the latest cert are stored in the OUTPUT_CERTS == PROV_CERT, when the client reconnects, it will automatically extract that latest cert during

Restart: Same as the Start process. So if you want to use the old valid cert. You can set the PROV_CERT and the OUTPUT_CERTS the same, and in that case the client will extract the cert signed by the istio CA before.

Test Result logging info:
2020-07-16T02:57:33.101924Z	info	cache	gggggggkkkkjjjjjjjjssss
2020-07-16T02:57:33.101983Z	info	cache	Ratio:%!s(float64=0.5), secretLifeTime: 23h59m59.281207328s, secret.CreatedTime: 2020-07-16 02:56:54.718792672 +0000 UTC m=+1.738502367
2020-07-16T02:57:33.102005Z	info	cache	Secret default: lifetime: 23h59m59.281207328s, graceperiod: 11h59m59.640603664s, expiration: 2020-07-17 02:56:54 +0000 UTC, should rotate: true
2020-07-16T02:57:33.102171Z	info	sds	resource:default connection is terminated: rpc error: code = Canceled desc = context canceled
2020-07-16T02:57:33.102233Z	info	sds	resource:default connection is terminated: rpc error: code = Canceled desc = context canceled
2020-07-16T02:57:33.102485Z	warning	envoy config	StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "router~<IP_ADDRESS>~istio-ingressgateway-6bc68b4d6b-7gdj6.istio-system~istio-system.svc.cluster.local-1"
2020-07-16T02:57:33.102600Z	warning	envoy config	StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "router~<IP_ADDRESS>~istio-ingressgateway-6bc68b4d6b-7gdj6.istio-system~istio-system.svc.cluster.local-3"
2020-07-16T02:57:33.268131Z	info	sds	resource:default new connection
2020-07-16T02:57:33.268461Z	info	sds	Skipping waiting for gateway secret
2020-07-16T02:57:33.393143Z	info	sds	resource:default new connection
2020-07-16T02:57:33.393277Z	info	sds	Skipping waiting for gateway secret
2020-07-16T02:57:33.607196Z	warn	cache	CertExist set the token to empty, exchangedToken:
2020-07-16T02:57:33.607241Z	info	citadelclient	pppppppppp
2020-07-16T02:57:33.607246Z	info	citadelclient	token is :
2020-07-16T02:57:33.620883Z	info	cache	GenerateSecret default
2020-07-16T02:57:33.621271Z	info	sds	resource:default pushed key/cert pair to proxy
2020-07-16T02:57:33.902586Z	warn	cache	CertExist set the token to empty, exchangedToken:

if we don't reconnect the connection:
https://github.com/istio/istio/blob/1be566e232d9a822fee8985bfc41c364926eb81f/security/pkg/nodeagent/caclient/providers/citadel/client.go#L101-L105
there will be error like this:
2020-07-16T02:29:26.593437Z	info	cache	gggggggkkkkjjjjjjjjssss
2020-07-16T02:29:26.593571Z	info	cache	Ratio:%!s(float64=0.5), secretLifeTime: 23h59m59.585611889s, secret.CreatedTime: 2020-07-16 02:28:47.414388111 +0000 UTC m=+0.929446661
2020-07-16T02:29:26.593579Z	info	cache	Secret default: lifetime: 23h59m59.585611889s, graceperiod: 11h59m59.792805944s, expiration: 2020-07-17 02:28:47 +0000 UTC, should rotate: true
2020-07-16T02:29:26.593737Z	info	sds	resource:default connection is terminated: rpc error: code = Canceled desc = context canceled
2020-07-16T02:29:26.593988Z	warning	envoy config	StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "router~<IP_ADDRESS>~istio-ingressgateway-6bc68b4d6b-fpbs5.istio-system~istio-system.svc.cluster.local-1"
2020-07-16T02:29:27.094266Z	info	sds	resource:default new connection
2020-07-16T02:29:27.094395Z	info	sds	Skipping waiting for gateway secret
2020-07-16T02:29:27.202363Z	warn	cache	CertExist set the token to empty, exchangedToken:
2020-07-16T02:29:27.202400Z	info	citadelclient	pppppppppp
2020-07-16T02:29:27.202405Z	info	citadelclient	token is :
2020-07-16T02:29:27.203112Z	error	citadelclient	Failed to create certificate: rpc error: code = Unauthenticated desc = request authenticate failure
2020-07-16T02:29:27.203137Z	error	cache	resource:default request:d3b0ea33-d38c-4cbd-8034-d6f8dc7ff159 CSR hit non-retryable error (HTTP code: 0). Error: rpc error: code = Unauthenticated desc = request authenticate failure
2020-07-16T02:29:27.203171Z	error	cache	resource:default failed to generate secret for proxy: rpc error: code = Unauthenticated desc = request authenticate failure
2020-07-16T02:29:27.203182Z	error	sds	resource:default Close connection. Failed to get secret for proxy "router~<IP_ADDRESS>~istio-ingressgateway-6bc68b4d6b-fpbs5.istio-system~istio-system.svc.cluster.local" from secret cache: rpc error: code = Unauthenticated desc = request authenticate failure

istiod error logging:
2020-07-16T02:33:06.898917Z	warn	serverca	Authentication failed for <IP_ADDRESS>:49150: Authenticator ClientCertAuthenticator at index 0 got error: no verified chain is found. Authenticator KubeJWTAuthenticator at index 1 got error: target JWT extraction error: no HTTP authorization header exists. Authenticator ClientCertAuthenticator at index 2 got error: no verified chain is found.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
7d1c3eb6a47e8e580e3efc7cd5e511b77e71432a
link
/test lint_istio

gencheck_istio
7d1c3eb6a47e8e580e3efc7cd5e511b77e71432a
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
7d1c3eb6a47e8e580e3efc7cd5e511b77e71432a
link
/test lint_istio

gencheck_istio
7d1c3eb6a47e8e580e3efc7cd5e511b77e71432a
link
/test gencheck_istio

unit-tests_istio
7d1c3eb6a47e8e580e3efc7cd5e511b77e71432a
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7d1c3eb6a47e8e580e3efc7cd5e511b77e71432a
link
/test gencheck_istio

unit-tests_istio
7d1c3eb6a47e8e580e3efc7cd5e511b77e71432a
link
/test unit-tests_istio

lint_istio
3e370494e25e3454ef9864793408ca5f75684a29
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
7d1c3eb6a47e8e580e3efc7cd5e511b77e71432a
link
/test unit-tests_istio

lint_istio
3e370494e25e3454ef9864793408ca5f75684a29
link
/test lint_istio

gencheck_istio
3e370494e25e3454ef9864793408ca5f75684a29
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
3e370494e25e3454ef9864793408ca5f75684a29
link
/test lint_istio

gencheck_istio
3e370494e25e3454ef9864793408ca5f75684a29
link
/test gencheck_istio

unit-tests_istio
3e370494e25e3454ef9864793408ca5f75684a29
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
3e370494e25e3454ef9864793408ca5f75684a29
link
/test gencheck_istio

unit-tests_istio
3e370494e25e3454ef9864793408ca5f75684a29
link
/test unit-tests_istio

lint_istio
e13b92a107eb04436d926979c895cdcc238be2ab
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3e370494e25e3454ef9864793408ca5f75684a29
link
/test unit-tests_istio

lint_istio
e13b92a107eb04436d926979c895cdcc238be2ab
link
/test lint_istio

gencheck_istio
e13b92a107eb04436d926979c895cdcc238be2ab
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
e13b92a107eb04436d926979c895cdcc238be2ab
link
/test gencheck_istio

lint_istio
9c29fdfdc9f36d7cbb1a45a591232f3c45b951b6
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9c29fdfdc9f36d7cbb1a45a591232f3c45b951b6
link
/test lint_istio

gencheck_istio
9c29fdfdc9f36d7cbb1a45a591232f3c45b951b6
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5c4dd1befe9b439d02384dbb7283ef3820674247
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Looks good.
Do we have any test covering rotation, or are you doing it in a separate PR ?

Yes will add an integration test and remove duplicate the env variable in a seperate PR

Could you add some tests to cover the changes to caclient?

Is this user facing? If so, can you please add a release notes entry to the /releasenotes/notes directory? The template is here: https://github.com/istio/istio/blob/master/releasenotes/template.yaml.

Is this user facing? If so, can you please add a release notes entry to the /releasenotes/notes directory? The template is here: https://github.com/istio/istio/blob/master/releasenotes/template.yaml.
It is for VM cases. Where user can provide their cert through a writable directory.

Could you add some tests to cover the changes to caclient?

Will add it with a unit test maybe like TestCertRotation and then add a integration test

@williamaronli: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test release-notes_istio

lint_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test release-notes_istio

lint_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test lint_istio

gencheck_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test release-notes_istio

lint_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test lint_istio

gencheck_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test lint_istio

gencheck_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
7eb35beff76b654f68641c7bd2a97d76dc241d3d
link
/test integ-multicluster-k8s-tests_istio

release-notes_istio
e71a21972740ab039704b2cd7a4727e1985cd22e
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Is this user facing? If so, can you please add a release notes entry to the /releasenotes/notes directory? The template is here: https://github.com/istio/istio/blob/master/releasenotes/template.yaml.

I have added the release note @brian-avery, could you help me verify why there is a release test failure always happend?Thanks

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-mixer-k8s-tests_istio

release-test_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

lint_istio
1fac77b46cd798d8610df152f0946c1a544f863c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

lint_istio
637121f095d8fd5bb9e56a94547c72fbf5f2887c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

lint_istio
637121f095d8fd5bb9e56a94547c72fbf5f2887c
link
/test lint_istio

gencheck_istio
637121f095d8fd5bb9e56a94547c72fbf5f2887c
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3f289e6f4103f6ec0c0d45a4c57d0677bf95986e
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
9669cd4fa7c0cb8a23bac19577b37d008cee8890
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
9669cd4fa7c0cb8a23bac19577b37d008cee8890
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9669cd4fa7c0cb8a23bac19577b37d008cee8890
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@williamaronli: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9669cd4fa7c0cb8a23bac19577b37d008cee8890
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@williamaronli: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
9669cd4fa7c0cb8a23bac19577b37d008cee8890
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Incorrectly converts line breaks to

Markdown in text format is often hard wrapped at some width (typically 80 characters), to maintain readability with editors that don't no soft wrapping. markdown-to-html incorrectly converts line breaks to
 tags.
This is not how github works, as evident in the following gist. Just compare rendered and raw versions, to see that github definitely does not interpret line breaks as
.
https://gist.github.com/raine/dd9a28f763b4a61bc0f56967bb7ff56a
https://gist.githubusercontent.com/raine/dd9a28f763b4a61bc0f56967bb7ff56a/raw/9d8517f1518cfb34d769eced59cce214a3889926/test.md
input
Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem
Ipsum has been the industry's standard dummy text ever since the 1500s, when an
unknown printer took a galley of type and scrambled it to make a type specimen
book. It has survived not only five centuries, but also the leap into electronic
typesetting, remaining essentially unchanged. It was popularised in the 1960s
with the release of Letraset sheets containing Lorem Ipsum passages, and more
recently with desktop publishing software like Aldus PageMaker including
versions of Lorem Ipsum.

output

Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem
Ipsum has been the industry's standard dummy text ever since the 1500s, when an
unknown printer took a galley of type and scrambled it to make a type specimen
book. It has survived not only five centuries, but also the leap into electronic
typesetting, remaining essentially unchanged. It was popularised in the 1960s
with the release of Letraset sheets containing Lorem Ipsum passages, and more
recently with desktop publishing software like Aldus PageMaker including
versions of Lorem Ipsum.

--flavor markdown is a nasty workaround with it's own downsides:

For example, fenced code blocks don't work when using the markdown utility or the Markdown class with the --flavor markdown option.

Needs fixing IMHO

Yeah.  I agree that's bad.  Surprised that I didn't test that -- or maybe
it used to work?
On Sat, May 23, 2020 at 10:29 AM Inan Hira<EMAIL_ADDRESS>wrote:

--flavor markdown is a nasty workaround with it's own downsides:
For example, fenced code blocks don't work when using the markdown utility
or the Markdown class with the --flavor markdown option.
Needs fixing IMHO
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cwjohan/markdown-to-html/issues/31#issuecomment-633101164,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7GVXD4GRJCPI5Q4OWW3SLRTABWDANCNFSM4FXYUVNA
.


Connecting to device fails on iOS

The VSCode frontend is not able to connect to port 18181 when the app is launched/attached on device. All attempts fail with ECONNREFUSED (connection refused). After listing all processes which are using port 18181, it turned out there is no such processes.

Fixed https://github.com/NativeScript/nativescript-vscode-extension/commit/5db8bf04f029950cae96f238f8a7b582470d8e11


$ react-native -v

$ react-native -v
react-native-cli: 0.1.10
react-native: 0.21.0-rc
$ react-native run-android
Starting JS server...
Building and installing the app on the device (cd android && ./gradlew installDebug)...
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':app'.

Could not resolve all dependencies for configuration ':app:_debugCompile'.
Could not resolve com.facebook.react:react-native:0.19.+.
Required by:
Mad:app:unspecified
Could not resolve com.facebook.react:react-native:0.19.+.
> Failed to list versions for com.facebook.react:react-native.
> Unable to load Maven meta-data from https://jcenter.bintray.com/com/facebook/react/react-native/maven-metadata.xml.
> Could not GET 'https://jcenter.bintray.com/com/facebook/react/react-native/maven-metadata.xml'.
> Connection to https://jcenter.bintray.com refused

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
Total time: 4 mins 15.891 secs
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/android-setup.html
Originally posted by @Heaven1619 in https://github.com/facebook/react-native/issues/5884#issuecomment-187205618

https://stackoverflow.com/questions/35394570/react-native-build-failed-with-an-exception


Avoid copying strings in (de|en)codeURI(Component)? and trim

The last step of Encode and Decode was copying the buffer for no reason; skip that copy
Often the input to Encode or Decode doesn't require any transformation, so return the original string in that case
Likewise, avoid creating new substrings for trimmed strings if nothing needs to be trimmed

Related to OS:17754314

FWIW LGTM


Single Player Mode and Dealer AI

Refactor code in preparation for multiplayer socket connection, so that when run:

Game offers a single player option as well as (yet to be implemented) multiplayer
Have single player extend PokerGame and have the player play against computer
Implement basic AI for dealer (computer)

Points: ~100

approved

feature implemented


Add date validation for issue_date and expiry_date for doc_type org.iso.18013.5.1.mDL

Test cases for cbor/formatter had malformed dates. The test case tested mandatory fields, so the malformed date format was not handled and misleading.
This PR tries to give a better error message if providing wrong date format.

Thank you. We have added your pull request to version 0.5.0 of the EUDIW Issuer.


raralabs

What kind of change does this PR introduce?

[ ] Bug Fix
[ ] Documentation change
[x] Added new company
[ ] Other(s)

Why was this change needed?
N/A
Other information
N/A

@TheLearneer can you check this out ?

Thank you for your contribution @ankurgajurel  🥳


Error Loading Any tvOS Samples

I'm running the latest alpha of Xamarin Studio and receiving "Could not load project 'Hello-tvOS/Hello-tvOS.csproj' with unknown item type '{06FA79CB-D6CD-4721-BB4B-1BD202089C55}'" error message.
I'm running Xamarin Studio 5.10 (build 860), from the alpha channel.  I was hoping Alpha would pull in what I needed.  Anybody else having this issue?

Hi @jamesbar2, at this point we don't have support for tvOS in public channels(alpha, beta, stable). However you can download  tvOS preview builds from this page.
Hope it will help,
Thanks


Add cypress base-url

in case your wondering: I re-ran the frontend-tests two more times, to see if this really fixes it. Passed every time

Yes, that's good. But this does not fix the underlying problem actually. It is not more than a dirty workaround.

This is not a fix, but a workaround for #319


nixos/github-runners: remove single runner module, rework default name, add noDefaultLabels

Description of changes
Reworks the NixOS module in a few ways:
Remove services.github-runner
Before #176691, the only way to configure a single GitHub Actions Runner was through the module services.github-runner.
Now that we have services.github-runners.<name> which allows configuration of multiple runners, there's no need to keep the old module around.                                                                                The PR removes services.github-runner through mkRemovedOptionModule which points the user to services.github-runners.<name>.
I also added a release notes entry.
Default runner name
So far, the registration used networking.hostName if the configuration does not set name.
However, not setting name was only possible through services.github-runner which this PR removes; when using services.github-runners.* the name defaults to the attribute name.
Since the runner configuration script defaults to the hostname if the --name option is not used, the PR now allows setting name = null but still defaults to the attribute name.
Add module option noDefaultLabels
v2.305.0 added the configuration option --no-default-labels which our module didn't cover so far.
The PR adds the module option noDefaultLabels and asserts that the configuration uses extraLabels if the option is set to true.
Documentation / Node runtime / Cosmetics
Make the option documentation reflect that changing the workDir and the ephemeral triggers a new runner registration.
The module option nodeRuntimes still accepted node16 as a value which the package does not accept anymore (since we don't have Node.js 16 in nixpkgs anymore).                                                                                Also removed some superfluous usages of lib.
Adapt user and add group
While the documentation tells us that the service would only run as a systemd dynamic user if user == null, this was never the case. Even if someone set the user option, this would only influence the username but would still use a dynamically allocated user. This PR makes the service reflect the documentation.
Also adds a new group option which complements the already existing user option. The effect of the group option also depends on the value user is set to. The option's documentation describes the behavior in detail.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test github-runner

unfortunate for me... but this PR breaks my workflow :disappointed:
the systemd hardening in this module just doesn't work for my usage and there isn't an easy way to undo it with this PR
currently this is what i'm doing... though what i would really love is a way to simply strip out the systemd hardening in this module and then i wouldn't need to resort to the hacks i use in the link provided
@veehaitch given the direction this PR is taking the module is there anything you can recommend for me? :bowing_man:

unfortunate for me... but this PR breaks my workflow 😞
the systemd hardening in this module just doesn't work for my usage and there isn't an easy way to undo it with this PR currently this is what i'm doing... though what i would really love is a way to simply strip out the systemd hardening in this module and then i wouldn't need to resort to the hacks i use in the link provided
@veehaitch given the direction this PR is taking the module is there anything you can recommend for me? 🙇♂

With the latest version of this PR, you should be able to use services.github-runners directly without any hacks; serviceOverrides should do the job.

serviceOverrides should do the job.

with serviceOverrides i need to figure out what all the default values are as well as keep a close eye on every PR to this module so i can defensively block new options as they are added
but i guess that is what i will need to do - ok, thanks

I see. I'm not against having a new option which controls the default hardening options as long as those are enabled by default. That's probably another PR though 🙂

I see. I'm not against having a new option which controls the default hardening options as long as those are enabled by default. That's probably another PR though 🙂

it's really more of a nixos in general thing, not specific to this module. the changes to this module just make my workaround ineffective... but that's not your problem.
thanks for taking such great care of this package and module - it is very helpful to me 👍


crtl + space to github copilot

Type: Feature Request
It will be amazing to using ctrl + space to trigger the github copilot.
And instead the native code complation model, we can use the one of github copilot's suggestions.
Thanks.
VS Code version: Code 1.75.1 (Universal) (441438abd1ac652551dbe4d408dfcec8a499b8bf, 2023-02-08T21:34:59.000Z)
OS version: Darwin arm64 21.6.0
Modes:
Sandboxed: No

@alexdima, could you please help with the routing of this issue. Thanks!

You can change the keybinding in your local setup!


[test] issue during the Debian build process

Hello, I unactviated the OPENCL tests and I got this error.
WARNING:run_tests:Test silx 0.5.0 from /<<PKGBUILDDIR>>/.pybuild/pythonX.Y_2.7/build/silx
WARNING:silx.test.test_sx:silx.sx tests disabled (DISPLAY env. variable not set)
WARNING:fabioimage:PIL is not installed ... trying to do without
WARNING:tifimage:PIL is not installed ... trying to do without
WARNING:bruker100image:PIL is not installed ... trying to do without
WARNING:xsdimage:lxml library is probably not part of your python installation: disabling xsdimage format
WARNING:silx.opencl:Use of OpenCL has been disables from environment variable: SILX_OPENCL=0
Traceback (most recent call last):
  File "run_tests.py", line 369, in <module>
    unittest.defaultTestLoader.loadTestsFromNames(options.test_name))
  File "/usr/lib/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib/python2.7/unittest/loader.py", line 115, in loadTestsFromName
    test = obj()
  File "/<<PKGBUILDDIR>>/.pybuild/pythonX.Y_2.7/build/silx/test/__init__.py", line 52, in suite
    from ..image import test as test_image
  File "/<<PKGBUILDDIR>>/.pybuild/pythonX.Y_2.7/build/silx/image/test/__init__.py", line 33, in <module>
    from . import test_medianfilter
  File "/<<PKGBUILDDIR>>/.pybuild/pythonX.Y_2.7/build/silx/image/test/test_medianfilter.py", line 34, in <module>
    from silx.image import medianfilter
  File "/<<PKGBUILDDIR>>/.pybuild/pythonX.Y_2.7/build/silx/image/medianfilter.py", line 36, in <module>
    from silx.opencl import medfilt as medfilt_opencl
  File "/<<PKGBUILDDIR>>/.pybuild/pythonX.Y_2.7/build/silx/opencl/__init__.py", line 46, in <module>
    from .common import *
AttributeError: 'module' object has no attribute 'mf'
E: pybuild pybuild:283: test: plugin custom failed with: exit code=1: env PYTHONPATH=/<<PKGBUILDDIR>>/.pybuild/pythonX.Y_2.7/build WITH_QT_TEST=False SILX_OPENCL=False SILX_TEST_LAW_MEM=True python2.7 run_tests.py -v
dh_auto_test: pybuild --test -i python{version} -p 2.7 -s custom "--test-args=env PYTHONPATH={build_dir} WITH_QT_TEST=False SILX_OPENCL=False SILX_TEST_LAW_MEM=True {interpreter} run_tests.py -v" returned exit code 13

Cheers

Ok looking at the code of common, mf is not defined when the SILX_OPENCL=0 or False
if os.environ.get("SILX_OPENCL") in ["0", "False"]:
    logger.warning("Use of OpenCL has been disables from environment variable: SILX_OPENCL=0")
    pyopencl = None
    <mf should be define here also>
else:
    try:
        import pyopencl
    except ImportError:
        logger.warning("Unable to import pyOpenCl. Please install it from: http://pypi.python.org/pypi/pyopencl")
        pyopencl = None
        class mf(object):
            WRITE_ONLY = 1
            READ_ONLY = 1
            READ_WRITE = 1
    else:
        import pyopencl.array as array
        mf = pyopencl.mem_flags

Another problem already saw on pyFAI :)
WARNING:run_tests:Test suite failed
usage: prog [--version|--help] <command> [<args>]

The prog commands are:
   foo        A command
   help       Show help of the following command

See 'prog help <command>' to read about a specific subcommand
('Unknown command: %s', 'foo2')
usage: prog [--version|--help] <command> [<args>]

The prog commands are:
   foo        A command
   help       Show help of the following command

See 'prog help <command>' to read about a specific subcommand
usage: run_tests.py [--version|--help] <command> [<args>]

The run_tests.py commands are:
   help       Show help of the following command

See 'run_tests.py help <command>' to read about a specific subcommand
usage: run_tests.py [--version|--help] <command> [<args>]

The run_tests.py commands are:
   help       Show help of the following command

See 'run_tests.py help <command>' to read about a specific subcommand
run_tests.py version None
usage: run_tests.py help [-h] [command]

Display help information about run_tests.py

positional arguments:
  command     Command in which aving help

optional arguments:
  -h, --help  show this help message and exit
usage: run_tests.py help [-h] [command]

Display help information about run_tests.py

positional arguments:
  command     Command in which aving help

optional arguments:
  -h, --help  show this help message and exit
Unknown command: foo2
usage: prog [--version|--help] <command> [<args>]

The prog commands are:
   foo        A command
   help       Show help of the following command

See 'prog help <command>' to read about a specific subcommand
usage: prog [--version|--help] <command> [<args>]

The prog commands are:
   foo        A command
   help       Show help of the following command

See 'prog help <command>' to read about a specific subcommand
('Unknown command: %s', 'foo2')
usage: prog [--version|--help] <command> [<args>]

The prog commands are:
   foo        A command
   help       Show help of the following command

See 'prog help <command>' to read about a specific subcommand
usage: run_tests.py [--version|--help] <command> [<args>]

The run_tests.py commands are:
   help       Show help of the following command

See 'run_tests.py help <command>' to read about a specific subcommand
usage: run_tests.py [--version|--help] <command> [<args>]

The run_tests.py commands are:
   help       Show help of the following command

See 'run_tests.py help <command>' to read about a specific subcommand
run_tests.py version None
usage: run_tests.py help [-h] [command]

Display help information about run_tests.py

positional arguments:
  command     Command in which aving help

optional arguments:
  -h, --help  show this help message and exit
usage: run_tests.py help [-h] [command]

Display help information about run_tests.py

positional arguments:
  command     Command in which aving help

optional arguments:
  -h, --help  show this help message and exit
Unknown command: foo2
usage: prog [--version|--help] <command> [<args>]

The prog commands are:
   foo        A command
   help       Show help of the following command

See 'prog help <command>' to read about a specific subcommand

The log with application output should be fixed now if you use the last master. But the behaviour do not look at the same according to different operating system.

this AttributeError: 'module' object has no attribute 'mf' issue have been fixed by commit 47996542

closing as both issues should be fixed


fix(Dockerfile): remove hardcoded exposed port

Pull Request Type

[ ] ✨ feat
[x] 🐛 fix
[ ] ♻ refactor
[ ] 💄 style
[ ] 🔨 chore
[ ] 📝 docs

Relevant Issues
Exposed hardcoded port are causing "overriding" problems in Docker compose labels. In our use case, we are using traefik labels but the exposed port keeps overriding.
What is in this change?
Remove exposed port. It might also be improper since we can override th SERVER_PORT making the expose port not usable
Developer Validations

[x] I ran yarn lint from the root of the repo & committed changes
[x] Relevant documentation has been updated
[x] I have tested my code functionality
[x] Docker build succeeds locally

Great point, that line has probably been in there forever and there is no need to EXPOSE any port when we direct people to boot the container with -p xxxx:xxxx anyway 👍

Shout out to @shatfield4 :D


Not working in iOS

I'm facing an issue while using yoyo-player, the m3u8 plays fine in android but it doesn't works in iOS

I have, maybe, the same issue. It does not work after switching quality.
iOS 13.5.1

It also didn't work on IOS with me. Does not start the video. It is showing the image of wait.
iPhone 5s
OS: 12.4.9


Can't Delete a test member from ghost after deleting the customer on stripe

Summary:
A test user whose associated stripe test customer has been deleted cannot be deleted.
Steps to reproduce:

sign up on your ghost site.
subscribe to any membership using stripe test API keys.
go to the /ghost admin endpoint and select members.
select that member and then select their stripe customer.
delete the customer on stripe.
click on delete member on ghost admin.

Expected result: admins should be able to delete members regardless of Stripe membership.
Actual result: on version 3.3.0 I used to get 500 and that "message" can't be undefined.
On 3.4.0 which I updated to since it included a crucial fix to Lyra, I simply get 404.
I would appreciate a fix to this as I'm on the cusp of importing my entire email list to the site as subscribers.
I'm on ubuntu, self-hosting on AWS. Let me know if you need any more information and I'll include what I can.

Hi @oreniko26 have put this into our backlog. Will update when it's prioritized to be worked on.

I couldn't reproduce this. I am able to delete the customer successfully in the latest version. Is this fixed in any of the patches done recently?

@oreniko26 are you still experiencing this issue?

Still getting a 'resource not found' error. Did you try to delete the member's associated stripe info before deleting them in ghost?

@oreniko26 Here is what I did:

I subscribed to the blog and paid with stripe.

The member appeared in the members tab in ghost admin.

Then, I went to stripe dashboard and deleted the test customer from there.

Came back to ghost admin and deleted the member from there. It got deleted.

The only thing I am concerned here is that when I subscribed to the blog by paying via stripe, the stripe info did not appear in the member tab in ghost. I mean the following:

Not sure if the above is the reason.

This should not be picked up until we've clarified members delete behaviour, as it may go away as part of changing that instead.

I'm facing the exact same issue. Is there a way to delete the member from the backend?
https://forum.ghost.org/t/help-unable-to-delete-member/15743

Anyone facing the same issue -
I solved it by going to :
sudo mysql -u ghost -p
enter password (You'll get this in the ghost config file)
show databases
USE ghost_production
``` (if 'ghost_production' is the name of your db)
`show tables`

navigate to tables and delete all entries from  'members_stripe_customers_subscriptions'

Use basic commands from this -

https://dev.mysql.com/doc/mysql-getting-started/en/

(I figured it out myself by googling, surfing YT videos after tirelessly requesting on the forum and github. Posting the solution here so you don't have to go through all this.) :)


Consider committing lockfile

In https://github.com/amethyst/shred/pull/228 I ran into the issue of the CI failing due to a dependency with a higher MSRV. If we had a lockfile to pin dependencies this would not have occurred.
Ideally, we would have CI running with both the pinned versions and without the lockfile. Since we already test with multiple compiler versions, I think it would be suitable to use a lockfile for the MSRV toolchain, and the others could ignore the lockfile.

https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html


Too much Project MMO xp awarded when chopping player-placed logs

Project MMO normally reduces XP awarded for breaking player-placed blocks. That's not happening when chopping.

Is this really a problem, though? AFAIK, you don't get enough XP for chopping down trees with Tree Chop enabled, as you're only chopping a small percentage of the actual tree's volume. It took me a very long time just to reach 30.

Hey, that's a good point. I'll consider awarding some extra XP when chopping (see #78).
Still, Project MMO does discourage "farming XP" by reducing how much XP is given when breaking player-placed blocks, and TreeChop currently doesn't respect that. Realistically, though, this issue probably won't get fixed -- Project MMO's method for detecting player-placed blocks is pretty sketchy, last I checked. Although, if I do get around to fixing this issue, I'll be sure to first add an option for awarding extra XP when chopping to compensate.

I could've sworn I was getting PMMO Woodcutting XP for each "chop" in 1.18.1 but now I see it's an open issue here. Old age is getting to me...
With that said, +1 bump for wanting this feature implemented.

Version 0.17.0 (only for minecraft 1.19.2 at the moment, but 1.18.2 will come soon) fixes XP awards (players were getting 12 per chop instead of 100) and makes them configurable. I also turned off PMMO's XP reduction for player-placed blocks when chopping -- it doesn't really make sense for chopping.


Fix install script when no plugin was ever installed in Xcode

Fix https://github.com/alcatraz/Alcatraz/issues/392 #394
If Xcode never loaded any plugin, the DVTPlugInManagerNonApplePlugIns-Xcode-$xcode_version does not exist, and the script halted on the line
defaults read -app Xcode "$PLIST_PLUGINS_KEY" > "$TMP_FILE"

We now check the return code of default read before continuing.
Sorry about that :/

:+1: thanks @guillaume-algis
@supermarin @kattrali LGTM

Thanks @guillaume-algis!
Looks good, altho I'd prefer using set -e for control flow.
Merging to fix existing installations

Looks good, altho I'd prefer using set -e for control flow.

Not quite sur what you mean. We're already using set -e. This is precisely why the script failed for some people. defaults read returned 1 on the non-existing key, and set -e halted the script.

Oh sorry, I reviewed from the phone.
Not sure how the && fixes the problem then
https://github.com/alcatraz/Alcatraz/pull/393/files?diff=split#diff-19783275db54420a49d7297671f8258eR13
Shouldn't the line fail on set -e the same way && wouldn't continue?

You got me worried here for a minute. No, && prevent set -e to halt the script (emph. mine):

The shell does not exit if the command that fails is part of the command list immediately following a while or until keyword, part of the test in an if statement, part of any command executed in a && or || list except the command following the final && or || [...]

So by using && we explicitly allow defaults read to fail (which is reasonable). I just realized the script is still printing the defaults read error though. A 2> /dev/null is probably needed.


Disable Glitch Effect  via props

I'm trying to disable the Glitch effect via a UI input but this seems to take no effect.
Here's a repro of the issue.
https://codesandbox.io/s/tender-star-lw07h

Works in version<EMAIL_ADDRESS>and<EMAIL_ADDRESS>


Introducing Extractly for insertion of TOC and code block highlightning

Pull Request Test Coverage Report for Build 12f433ba6ea52c5b1dd61059c7f359284082eb9f-PR-51

0 of 0   changed or added relevant lines in 0 files are covered.
24 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 74.7%

Files with Coverage Reduction
New Missed Lines
%

src/link_text_parser.erl
24
76.71%

Totals

Change from base Build d39ed626a156131b16fd0c5505d6c5e4dbd99f16:
-0.2%

Covered Lines:
1060

Relevant Lines:
1419

💛  - Coveralls

Pull Request Test Coverage Report for Build 0c7cb0616b7a9b703a6e81fd2e8d362f9d88f4ab-PR-51
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
10 unchanged lines in 7 files lost coverage.
Overall coverage increased (+16.9%) to 91.779%

Files with Coverage Reduction
New Missed Lines
%

lib/earmark_parser/ast/renderer/ast_walker.ex
1
83.33%

lib/earmark_parser/helpers/html_parser.ex
1
95.65%

lib/earmark_parser/helpers/lookahead_helpers.ex
1
92.86%

lib/earmark_parser/helpers/string_helpers.ex
1
60.0%

lib/earmark_parser/parser.ex
1
90.34%

lib/earmark_parser/helpers/html_helpers.ex
2
0.0%

lib/earmark_parser/helpers/attr_parser.ex
3
87.1%

Totals

Change from base Build d39ed626a156131b16fd0c5505d6c5e4dbd99f16:
16.9%

Covered Lines:
748

Relevant Lines:
815

💛  - Coveralls


Request from HL7-FHIRi: tighten the context of the "basedOn: and the "based on extension" extensions.

Section Numbers/URLS

IHE-FHIR-PHARM-MEDICATIONRECORD\basedOn - FHIR v5.0.0 (links to a CarePlan)
IHE-FHIR-PHARM-MEDICATIONRECORD\Based On Extension - FHIR v5.0.0 (link to a MedicationStatement)

Issue
HL7 FHIR-i is reviewing extensions defined in the FHIR space in order to clean them up, remove redundant extensions and improve the definition of the remaining ones.
During this process, a set of IHE defined extensions where discussed that need work.
The extensions context is 'Element', allowing it to be used on any element on any resource. FHIR-i is concerned that this is far to generic and strongly recommends restricting the use to the specific context where it is intended to be used.
For the first extension (basedOn) this would be MedicationStatement, as that is the only place it is used).
The context of use of the second extention (link to MedicationStatement) is unknown and should be specified or the extension should be removed.
The descriptions of both extensions is very sparse making it very difficult to deduct their intend and use, please extend these and make them more specific.
Proposed Change
Restrict the use of these extensions to the root level of MedicationStatement. This can be achieved by adding the line
Context: DiagnosticReport to the header of these extensions in the sushi fsh file.
Extend the description of these extensions.
Priority:

Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.

the IG that is mentioned doesn't exist anymore.
This has been migrated and the extension doens't exist (yet/anymore)?
Leaving the ticket open for now while that content is reconsidered (just to not dismiss the ticket) .And the need is still there, not sure if we will eventually have the extension.


Helm list with --selector

Output of helm version:
version.BuildInfo{Version:"v3.9.0", GitCommit:"7ceeda6c585217a19a1131663d8cd1f7d641b2a7", GitTreeState:"clean", GoVersion:"go1.17.5"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.1", GitCommit:"3ddd0f45aa91e2f30c70734b175631bec5b5825a", GitTreeState:"clean", BuildDate:"2022-05-24T12:26:19Z", GoVersion:"go1.18.2", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.9", GitCommit:"3396beebcd97ed3b01f57127fba1b8565b311acb", GitTreeState:"clean", BuildDate:"2022-06-04T17:58:54Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"linux/amd64"}

I am trying to use the label selector functionality described in the documentation and here, without any success. Is anyone able to actually use this in their releases and filtering with helm list -l key=value?
I currently have a release with the following configmap and when using the -l flag I get no results at all.
apiVersion: v1
data:
  TEST_1: "1"
  TEST_2: two
kind: ConfigMap
metadata:
  labels:
    app.kubernetes.io/managed-by: Helm
    name: test-config
    namespace: test

I've tried the following commands but neither finds any results.
$ helm list -l "app.kubernetes.io/managed-by=Helm" -n test
$ helm list -l app.kubernetes.io/managed-by=Helm -n test
$ helm list -l "app.kubernetes.io/managed-by==Helm" -n test
$ helm list -l app.kubernetes.io/managed-by==Helm -n test

What am I doing wrong?

The configmap in your snippet is a helm configmap (where helm stores release info) or configmap created by helm chart?

This is the actual configmap generated by helm install test helmctart/ -n test and viewed through kubectl -n test edit configmaps test-config.

I'm trying to achieve the intended purpose, filtering releases based on a tag. And since the addition of filters has not been merged I was hoping that I could filter on manually added tags inside the helm chart, which you explained is not possible.
Is there any workaround way of getting the selector to work until the label creation PR gets merged?

@dm3ch Thank you so much for this! I agree it's not the prettiest solution but it works fine for now.


Support fixtures defined in other files/plugins

It would be great if this plugin would understand fixtures defined in plugins and other files.
test_foo.py
def test(my_fixture):
    assert True

conftest.py
import pytest

@pytest.fixture
def my_fixture():
    # do some mocking
    return 42

Currently this is not supported tp supress errors generated by my_fixture. Note that, conftest.py can exist also in every parent directory and therefore be nested. Also plugins might provide plugins.
Therefore asking pytest like pytest --fixtures --collect-only test_foo would be good (similar to pylint_pytest)

@kasium I have (finally) taken a look at the old plugin and see that it works by actually invoking pylint to collect all fixtures. I'm not sure if I agree with that approach as it means that pylint will be even slower and reliant on the behaviour of another tool.

Yes, that is one downside of the plugin but I see no way around that if you want a stable and reliable plugin.
However, what do you think about a persistent cache for the fixtures? So that these at only fetched with the first run or if the file was changed. But still a special handling for these conftest files would be needed...

I think it might be quite hard to set up the correct cache hit and cache regenerate conditions. pylint itself notoriously doesn't do this as well because we deemed it to be too hard.

Valid point. I thought also about it and I guess for normal projects, a simple cache would work. However, when it comes to dynamic plugins, imports in conftest, etc. it won't work or would be too complicated.
However, here are two ideas:

Having a "fast" and "slow" mode --> The "fast" mode would work with your current code and the "slow" one would ask pytest for the fixtures
(could be combined with 1.) --> ask the pytest team to provide a way to receive all possible fixtures in all files. It would nto be 100% safe (e.g. a unused-variable is in fact unused and not a fixtures) but it's still better than nothing. The collection needs only to be done once per pylint session and not for every file.

What do you think?

I guess asking pytest with the "--fixtures" flag should return all fixtures defined in the current scope. The previous plugin did it on file level.and not down to the single test function as far as I known

I guess asking pytest with the "--fixtures" flag should return all fixtures defined in the current scope. The previous plugin did it on file level.and not down to the single test function as far as I known

Yeah, that's what I'm worried about. Because then the next opened issue will be: why is the support for fixtures broken for my function, etc. I think we would open a can of worms with it.

Fair point, I'm really not sure how to continue then


Comparison to existing systems

How is this different from Interledger or Stellar? The white paper would benefit greatly from a related work section.

+1 for a related work section
Quick analysis of the two mentioned projects:

Interledger: (x) any-to-any¹ transfers ( ) decentralized ( ) flexible anonymization
Stellar: (-) any-to-any transfers (x) decentralized ( ) flexible anonymization

¹ to / from fiat and crypto
Thus it looks like the greatest benefits are decentralization and flexible anonymization allowed by the use of DIDs and VCs.


ShapeCast3D moves when Visible Collision Shapes are enabled

Tested versions
Reproducable in 4.3dev6 and 4.2.1.stable
System information
Godot v4.2.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - integrated Intel(R) UHD Graphics 620 (Intel Corporation; <IP_ADDRESS>1) - Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 Threads)
Issue description
I have added a ShapeCast3D as a child to a CharacterBody3D. When the CharacterBody3D moves, the ShapeCast3D moves with it.
With Visible Collision Shapes enabled, when the ShapeCast3D hits a StaticBody3D the ShapeCast3D does not keep to its original position in relation to its parent, the CharacterBody3D. It seems to get stuck on the StaticBody3D as if it were colliding.
Other CharacterBody3Ds moving into the ShapeCast3D can also move it.
I am not 100% certain but I believe this only affects the Visible Collision Shapes, not the actual ShapeCast3D itself. But it makes debugging hard.
This is a clip showing the issue.
The moving square is a CharacterBody3D, the static square is a StaticBody3D. The rectangle is the ShapeCast3D.

Steps to reproduce
Make a scene with the following structure:

Node3D

Camera3D
CharacterBody3D

CollisionShape3D
ShapeCast3D

StaticBody3D

CollisionShape3D

Move the ShapeCast3D position so that it is in front of the CharacterBody3D.
Attach a script to the CharacterBody3D that takes user input to move it around.
Enable Visible Collision Shapes and run the scene. Move the CharacterBody3D so the the ShapeCast3D would collide with the StaticBody3D.
Minimal reproduction project (MRP)
test.zip

This looks by design IMO, it shows how far the shape can move before it hits, which is part of how the ShapeCast3D node is designed, I don't think this is a bug but a feature, you can see the code making this happen here:
https://github.com/godotengine/godot/blob/daa81bbb7d1c6d75d1711595604178ee62a5801d/scene/3d/physics/shape_cast_3d.cpp#L498-L515

It's certainly possible that this is by design, but to me it seems very unintuitive and somewhat buggy for several reasons.

I was under the impression that ShapeCast3D would behave similarly to Area3D, meaning it will only report and what it overlaps with, not actually collide and move.
This makes ShapeCast3D behave differently from RayCast3D, meaning RayCasts aren't moved when detecting a collision.
The position / global_position value of the ShapeCast3D does not change, only the visual representation of it. That makes zero sense to me.
As you can see in the clip above, when the CharacterBody3D moves all the way forward to the StaticBody3D, the ShapeCast3D actually moves to the back side of the StaticBody3D. So it does not actually show "how far the shape can move before it hits".

It doesn't collide and move, it doesn't actually move, the debug is just a debug representation, don't take the visualization to be the real behavior
The shape visualizes the closest safe fraction, which is a common use of ShapeCast3D, see here for details on what that means
This is 100% by design, this code didn't happen by accident because it doesn't represent some simulation, it's just a visualization.
In the final case where it moves beyond that's due to it not being able to work at the root position, which is possibly a bug in how ShapeCast3D works fundamentally, but not in the visualization
So while that specific behavior part might be a bug, the fact that it visualizes this way is not an oversight but by design, and displays how the node works and the features of it, you can read the documentation for more details if you have questions on how it works

I see, thanks. I think I understand now that this is how ShapeCast3D works, and is working as intended. (Possibly except for the case where it moves beyond the StaticBody3D)
However, for debugging purposes, would it not make more sense to keep the visual representation of the ShapeCast3D in its root position? If not, would it be possible to show both root position and closest safe fraction, or maybe make it an option to choose from root position or closest safe fraction?

However, for debugging purposes, would it not make more sense to keep the visual representation of the ShapeCast3D in its root position?

I don't think that makes sense, it doesn't serve any purpose like that IMO, the way it currently works it shows:

If it is colliding
Where it collides

Which IMO is exactly the information you want to visualize

If not, would it be possible to show both root position and closest safe fraction

This would be cluttered

or maybe make it an option to choose from root position or closest safe fraction?

That could be an idea, but that would have to be handled in a proposal instead
So I'd suggest opening a proposal for that part, and the incorrect check at the root position is already tracked in:

https://github.com/godotengine/godot/issues/72995

So closing this, but thank you for your report and conversation! If you're interested in changing the behavior of this please open a proposal to discuss this


How is this different than Leshan

Hi,
Could you please clarify how is this different than Leshan?
Does it provide better performance?
I see it lacks few features like Lack of DTLS support but what are its main points where it stands taller than Leshan.
Thanks, Santos

Hey Santos,
Well when I started the project I was a bit over ambitious of the scope. I was also learning the spec and what better way than to implement it.
since then I found that there was absolutely no reason for another implementation of the server. There has been a lot of quality effort poured into that by some talented folks.
A client would still make sense and would be better use of my time,IMO.
I've created another issue #40 to highlight the fact that I will be refactoring the project heavily to make it client only and remove the server implementation.
The Go language itself has lots of nice things going for it.
With regards to DTLS, it would be soon coming. I've implemented recently dTLS support in the dependent CoAP library also written by me(Canopus). I'm taking my time a bit so that I'm satisfied with the implementation. After that the refactoring of betwixt will incorporate that.
Hope that was clear.

any update on this
I have all my application running in go and I would like to add the LWM2M with DTLS support
that would be a great add on
really appreciate your work


Opt/clear invalid error msg

关联的Issues (Related Issues)

close https://github.com/filecoin-project/venus/issues/5924
改动 (Proposed Changes)

推送消息失败时把消息 cid 输出到日志
移除上轮选择消息时出现的错误信息

附注 (Additional Info)

自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

[ ] 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
[ ] 具有清晰明确的commit message / All commits have a clear commit message.
[ ] 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
[ ] 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
[ ] 通过必要的检查项 / All checks are green

Codecov Report

Merging #343 (ee6d69f) into master (48daea0) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   54.08%   54.06%   -0.02%
==========================================
  Files          74       74
  Lines        8014     8023       +9
==========================================
+ Hits         4334     4338       +4
- Misses       3333     3338       +5
  Partials      347      347

Flag
Coverage Δ

unittests
54.06% <25.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cli/util.go
0.00% <0.00%> (ø)

publisher/publisher.go
73.43% <0.00%> (-1.97%)
:arrow_down:

service/message_selector.go
78.35% <100.00%> (+0.18%)
:arrow_up:


Adding demo3 documents

Adding video that Amit's created
Adding presentation and the content
Resolve #91

I do not think it should be here, Consider maintainig a blog related to this repo, but not in it

You think we should delete all the documentation files (This directory ) from this repo?

I do not think it should be here, Consider maintainig a blog related to this repo, but not in it

can you explain @Yarboa ??

I do not think it should be here, Consider maintainig a blog related to this repo, but not in it

can you explain @Yarboa ??

You canhave the presentation as md file
I would skip hebrew presentation, at least try to upload it in markdown or image in md file

@avi-biton @Yarboa I deleted the Hebrew presentation.
I prefer to work some more important things instead of convert the presentation to MD file.
If the presentation must be a md file, maybe we can consider to close this PR .

@avi-biton @Yarboa I deleted the Hebrew presentation. I prefer to work some more important things instead of convert the presentation to MD file.
If the presentation must be a md file, maybe we can consider to close this PR .

Its the group decision,
Either you think there should be a resource to that or not

I also think it's not a top priority, so to close the pr right now and upload it only after demo 4

@avi-biton @Yarboa I deleted the Hebrew presentation. I prefer to work some more important things instead of convert the presentation to MD file.
If the presentation must be a md file, maybe we can consider to close this PR .

Its the group decision, Either you think there should be a resource to that or not

In my opinion, we need this presentation on GitHub.

@avi-biton @Yarboa I deleted the Hebrew presentation. I prefer to work some more important things instead of convert the presentation to MD file.
If the presentation must be a md file, maybe we can consider to close this PR .

Its the group decision, Either you think there should be a resource to that or not

In my opinion, we should not convert this presentation to an MD file.  I think that a lot of work was done on this presentation and we already have 2 presentations in our repository.
If we cannot reach an agreement I would convert this presentation after demo4.

I have no problem with merging it as it is.
@Yarboa Is it OK with you?


make find state global

Makes find state global, like search state (history) is shared across text editors.
An example: if you do t* to move the cursor to the next * in one editor, switch to another editor, and do ;, you'll go to the next * as well.

Love it!  This is how Vim works.

tests updated to actually use multiple editors (thanks for the suggestion @maxbrunsfeld); please review especially the changes in spec-helper - hope this is useful for other specs too.

Awesome!

thanks for the patience and attention to detail 8-)


[Feature] Option to disable the granularity in the time axis

What problem does this feature solve?
Is there a way to disable the different time granularity in the time axis? E.g. when displaying the dates, the month should not be displayed when there is a switch to a new month.
What does the proposed API look like?
https://echarts.apache.org/en/option.html#xAxis.axisLabel.formatter
https://apache.github.io/echarts-handbook/en/basics/release-note/v5-feature/ (see section Time Axis, in the second graph the month should not be displayed)

Yes, you can disable it with String Templates.
Demo Code

Thanks for the response. I would like to avoid using the String Template and instead let ECharts calculate the format of the time axis, while only showing one type of granularity. Is this possible?

why not, AI is coming...
On Sat, Feb 11, 2023, 08:56 LuisaW @.***> wrote:

Thanks for the response. I would like to avoid using the String Template
and instead let ECharts calculate the format of the time axis, while only
showing one type of granularity. Is this possible?
—
Reply to this email directly, view it on GitHub
https://github.com/apache/echarts/issues/18252#issuecomment-1426823758,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDPD56UPQKGFW4O2VIKBQLWW7AD7ANCNFSM6AAAAAAUVH4EVI
.
You are receiving this because you commented.Message ID:
@.***>

@luisa-c-wolf, when you say "was possible before the release", which previous release worked for you?  I checked the older available v.5.0.0 and it was still showing days and months mixed. So it seems the current behavior was established long ago.
@bgmeinder, "consistent interval" can be set with xAxis.splitNumber
It is still unclear to me what is the goal of this feature request. Maybe it would be better to describe what you want to see - providing an image is best.
disclaimer
opinions expressed in this post are strictly personal, as ECharts user, not a developer

@helgasoft  Version 4 had the behavior.  Version 5 added new intervals for Year/Month.
Look at my demo above.  The X axis looks terrible.  Look at your demo.  It's 4 day intervals, then suddenly the 1st is there after 2 days.    Update your demo to be a 3 month span, and yyyy/MM/dd format and you suddenly see why it's a problem.   splitNumber doesn't fix that.  "Note that this number serves only as a recommendation, and the true segments may be adjusted based on readability."  MinInterval seems like it might help, but it's unclear what that number should be.  Milliseconds?  Even so, adding that didn't change my demo.
Think about a use case of previous 90 days.  You don't care if it's the first of the of month or the year.  The goal of the feature request is to not add arbitrary ticks, or make them something like a minorTick that can be hidden.  That if I have a previous 60 days timespan, and echarts determines that interval to be 7 days, it's always 7 days.  Not, 7 days, 1st of the month, 7 days from that.

@bgmeinder - good explanation, now I understand the problem.
Cannot offer a fix, but kind of a makeup relief. Playing with maxInterval and formatter will produce decent results.
Demo Code

Thanks, but that doesn't help me.  My demo is essentially our use case.  Labels are too wide so they overlap.  Hide overlap or a formatter can solve that, but I can't hide the extra ticks.
If minInterval worked like minInterval does, that would be a solution, but it doesn't.  I don't know if that is a bug, or it works differently.

minInterval works, but in a weird way. The auto-generated interval in your example is 7 days, minInterval has to be more than twice that to take effect. For instance minInterval: (3600 * 24 * 1000) *17 will make labels sparse.

Yeah, this functionality broke interval and minInterval.  Maybe minInterval was always weird where it seems like there is some internal calculation to determine how many ticks to show, and you have to have a high enough minInterval to push it to the next threshold.
There is all kinds of weirdness and inconsistency going on.  You set a min: 6/14, max: 9/18 and you get 7 day intervals, with issues each month because the intervals hit the 29th and 1st.  You change min to 6/13, and suddenly it's bi-monthly, but 1st & 17th.  I mean, I can live with that, because it's not noticeably differently sized intervals, but huh?  13 days, 16 days, 14 days, 16 days?  Maybe there is a timezone issue, but wouldn't you expect 1/15 each month? Or some moment month/2 days or something?


When will the Chinese translation version be released?

please complete the following information:

OS version: [Mac Bigsur]
Editor: [vscode]
Editor version:	1.63
Programming language: [js, ts, html, css]
TabNine extension version: 3.5.4
Engine version (could be located within Tabnine Hub): 4.0.23-42

Issue Details:
I am a front-end developer from China and a paying user of yours. This is the smartest code prompt completion plugin I have ever used. Given that there are a large number of developers in China, when will a Chinese translation version be released?
gz#9783

Hi
We’re not working on that, and it may not happen, but I’ll pitch it to the team and see what they think.
If you have any other questions, I’ll be happy to help.