Update docker image tags in k8s spec

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4173/
Test PASSed.

I think master should always just use latest?

@calvinjia since we publish SNAPSHOT docker images, it makes sense to update the tag as well. other someone following along the master docs will end up installing 1.8.1 (or released version) with master docs

Oh it looks like latest is not really suggested use in Dockerhub.

alluxio-bot, merge this please.


Use shape dtype on argreduce to determine return type.

Use the shape argument type instead of a fixed Int32 type, this expects the shape type to always be an integer. Fix #11794 .

@tqchen @jroesch cc

LGTM, can you add the test from https://github.com/apache/tvm/issues/11794?

@masahi Sure, I just added it under test_type_infer.py which seemed reasonable to me but please let me know if you believe it should be somewhere else.


fix the case when tashkeel comes after tnween

This issue is to keep track of weird cases like having tashkeel character coming after tnween fatha'a character.
Example resulting in an error:
ثَمَلًاَ عَلَى شُرُفَاتِهَا

case fixed in this commit


Prevent implicit return of window.URL function

This prevents the implicit return of window.URL's constructor instead of a simple boolean value for usermedia-core's test. This is important because the polyfiller looks to see if test is a function, and if so calls it. The recently released Chrome 53 doesn't allow direct calls to the URL constructor anymore and will throw an error if called directly. So now a lot of people are seeing webshim break and the further load of their JS stack halt.
It looks like the call to URL's constructor has been occurring for a little while now but was hidden because the existence of window.URL is still being verified, even though it was also being erroneously called.

👍

Can we get this fix in a new release please?

@eraserqueen
I will do so. Give me this weekend.


ci: add label PR workflow

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[x] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Provides consistent labelling for the repository by covering the 2.x alongside the main branch.
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have added tests (if possible).
[ ] I have updated the documentation accordingly.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (853439d) 66.04% compared to head (8d78713) 66.22%.
Report is 394 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x   #25580      +/-   ##
==========================================
+ Coverage   66.04%   66.22%   +0.17%
==========================================
  Files          93       93
  Lines        4076     4121      +45
  Branches     1147     1169      +22
==========================================
+ Hits         2692     2729      +37
- Misses       1121     1126       +5
- Partials      263      266       +3

Flag
Coverage Δ

unittests
66.22% <ø> (+0.17%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


HELP - Cache Only Lookup Failed

Hi All,
Firstly thanks for developing such an awesome API Gateway.
So we have our K8s setup over AKS and installed Kong 1.9.1 using Helm Charts. While exposing a microservice via Kong, we are faced with the following error when the microservice tries to make a call to a particular intended server:
2020/09/22 10:20:40 [error] 23#0: *90700 upstream timed out (110: Operation timed out) while reading response header from upstream, client: <IP_ADDRESS>, server: kong, request: "POST /testperson/keep-testperson HTTP/1.1", upstream: "http://<IP_ADDRESS>:8080/testperson/keep-testperson", host: "y.y.y.y:80" <IP_ADDRESS> - - [22/Sep/2020:10:20:40 +0000] "POST /testperson/keep-testperson HTTP/1.1" 504 51 "-" "PostmanRuntime/7.26.5" 2020/09/22 10:20:41 [error] 23#0: *90702 upstream timed out (110: Operation timed out) while connecting to upstream, client: <IP_ADDRESS>, server: kong, request: "POST /api/testpersonRecord/keeptestperson HTTP/1.1", upstream: "https://x.x.x.x:443/api/testpersonRecord/keeptestperson", host: "y.y.y.y:80" 2020/09/22 10:20:41 [error] 23#0: *90702 [lua] balancer.lua:1123: balancer_execute(): DNS resolution failed: dns server error: 100 cache only lookup failed. Tried: ["(short)test-website.com:(na) - cache-miss","test-website.com.default.svc.cluster.local:1 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com.svc.cluster.local:1 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com.cluster.local:1 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com.blahblahblah.fx.internal.cloudapp.net:1 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com:1 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com.default.svc.cluster.local:33 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com.svc.cluster.local:33 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com.cluster.local:33 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com.blahblahblah.fx.internal.cloudapp.net:33 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com:33 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com.default.svc.cluster.local:5 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com.svc.cluster.local:5 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com.cluster.local:5 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com.blahblahblah.fx.internal.cloudapp.net:5 - cache only lookup failed/dns server error: 100 cache only lookup failed","test-website.com:5 - cache only lookup failed/dns server error: 100 cache only lookup failed"] while connecting to upstream, client: <IP_ADDRESS>, server: kong, request: "POST /api/testpersonRecord/keeptestperson HTTP/1.1", upstream: "https://x.x.x.x:443/api/testpersonRecord/keeptestperson", host: "y.y.y.y:80" 2020/09/22 10:20:41 [error] 23#0: *90702 [lua] init.lua:871: balancer(): failed to retry the dns/balancer resolver for test-website.com' with: dns server error: 100 cache only lookup failed while connecting to upstream, client: <IP_ADDRESS>, server: kong, request: "POST /api/testpersonRecord/keeptestperson HTTP/1.1", upstream: "https://x.x.x.x:443/api/testpersonRecord/keeptestperson", host: "y.y.y.y:80" <IP_ADDRESS> - - [22/Sep/2020:10:20:41 +0000] "POST /api/testpersonRecord/keeptestperson HTTP/1.1" 500 46 "-" "Apache-HttpClient/4.5.12 (Java/11.0.8)"
Can you guys please provide some pointers as to where exactly we might have to look into or in case we might missed any particular configuration via helm charts??
p.s: I did checkout similar issues related the above error and the closest that I have come to is "https://github.com/Kong/kong/issues/4496" but the error is not entirely same as what the Issues OP has posted.

reformatted

2020/09/22 10:20:40 [error] 23#0: *90700 upstream timed out (110: Operation timed out) while reading response header from upstream, client: <IP_ADDRESS>, server: kong, request: "POST /testperson/keep-testperson HTTP/1.1", upstream: "http://<IP_ADDRESS>:8080/testperson/keep-testperson", host: "y.y.y.y:80" <IP_ADDRESS> - - [22/Sep/2020:10:20:40 +0000] "POST /testperson/keep-testperson HTTP/1.1" 504 51 "-" "PostmanRuntime/7.26.5"
2020/09/22 10:20:41 [error] 23#0: *90702 upstream timed out (110: Operation timed out) while connecting to upstream, client: <IP_ADDRESS>, server: kong, request: "POST /api/testpersonRecord/keeptestperson HTTP/1.1", upstream: "https://x.x.x.x:443/api/testpersonRecord/keeptestperson", host: "y.y.y.y:80"
2020/09/22 10:20:41 [error] 23#0: *90702 [lua] balancer.lua:1123: balancer_execute(): DNS resolution failed: dns server error: 100 cache only lookup failed. Tried: [
  "(short)test-website.com:(na) - cache-miss",
  "test-website.com.default.svc.cluster.local:1 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com.svc.cluster.local:1 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com.cluster.local:1 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com.blahblahblah.fx.internal.cloudapp.net:1 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com:1 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com.default.svc.cluster.local:33 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com.svc.cluster.local:33 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com.cluster.local:33 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com.blahblahblah.fx.internal.cloudapp.net:33 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com:33 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com.default.svc.cluster.local:5 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com.svc.cluster.local:5 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com.cluster.local:5 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com.blahblahblah.fx.internal.cloudapp.net:5 - cache only lookup failed/dns server error: 100 cache only lookup failed",
  "test-website.com:5 - cache only lookup failed/dns server error: 100 cache only lookup failed"
] while connecting to upstream, client: <IP_ADDRESS>, server: kong, request: "POST /api/testpersonRecord/keeptestperson HTTP/1.1", upstream: "https://x.x.x.x:443/api/testpersonRecord/keeptestperson", host: "y.y.y.y:80"
2020/09/22 10:20:41 [error] 23#0: *90702 [lua] init.lua:871: balancer(): failed to retry the dns/balancer resolver for test-website.com' with: dns server error: 100 cache only lookup failed while connecting to upstream, client: <IP_ADDRESS>, server: kong, request: "POST /api/testpersonRecord/keeptestperson HTTP/1.1", upstream: "https://x.x.x.x:443/api/testpersonRecord/keeptestperson", host: "y.y.y.y:80" <IP_ADDRESS> - - [22/Sep/2020:10:20:41 +0000] "POST /api/testpersonRecord/keeptestperson HTTP/1.1" 500 46 "-" "Apache-HttpClient/4.5.12 (Java/11.0.8)"

see these:

https://github.com/Kong/kong/issues/4496#issuecomment-501625133
https://github.com/Kong/kong/issues/5550

answers there explain the mechanism, look into the stale_ttl property

@Tieske : Thanks for your reply. I did try seting the dns_stale_ttl: 20 but still the issue persists with the same error message as above. Any other pointers?

the otherway around, make it bigger! set it to 600 and try again.

Hey @swapnilpotnis. Were you able to test @Tieske's suggestion? Please let us know!

@gszr, @Tieske : I did set it to 600 but now my application is stating TIMEOUT issues. I am not sure whether it is because of dns_stale related changes or something else. I am still debugging the issue.
btw, I am using the helm charts for installing kong over Azure from https://github.com/Kong/charts#setup location. Just wanted to confirm that the above mentioned charts do work over Azure as well right??
The reason for me asking is, I saw another helm charts repo for kong from bitnami(https://bitnami.com/stack/kong/helm) and hence wanted to confirm that the source of the charts which I currently have is correct?

It is your application for sure. That's what is causing those issues in the first place. I'm not familiar with the helm charts however so dunno...

@Tieske : Yes....Its actually related to Azure to be more specific. We are able to overcome my originally posted issue with dns_stale property. Thanks for your help :)

@swapnilpotnis  thanks for reporting back 👍

@swapnilpotnis how to update stale_ttl in k8s kong setup

like any other config setting; use an env-variable; KONG_STALE_TTL, see https://docs.konghq.com/gateway-oss/2.4.x/configuration/#environment-variables

Thanks @Tieske

@Tieske should that be KONG_DNS_STALE_TTL instead?

@r1ckr yes, corrected


Invalid Web App Manifest / Add to home screen not working

Describe the bug
Add to home screen feature not working correctly with evcc.
To Reproduce
Steps to reproduce the behavior:
Open evcc with mobile browser and select "Add to home screen".
A shortcut is created on the home screen, but without an icon and with an invalid URL (e.g.": https://evcc/dist/#/).
Expected behavior
A shortcut is created on the home screen, with evcc icon and correct start URL.
EVCC details:
evcc 0.37

/cc @naltatis I have the same problem. Looks like another bug in parcel.js. Any idea how to fix this?

I already looked into fixing this in parcel, but since this is not our only issue with relative paths it might be easier to switch from parcel to vue-cli (Webpack). I already have a version of this working in a local branch.

Encountered other side effects (necessary workarounds) with parcel also: e.g. adding a simple, relative "a href" seems to be impossible. Needed this ugly workaround, a link like "/broker/login" is impossible:

         <router-link class="nav-item nav-link pb-1" to="/">Laden</router-link>         <router-link class="nav-item nav-link pb-1" to="/config">Konfiguration</router-link>

So I would appreciate to drop the parcel usage also.

For me it looks like the relative path inside the webmanifest with only one folder up is the problem. In the release 31/32(?) the deployment of the assets were changed and now the manifest file locates in a different two level deep folder (source and published). Adding another ../ should solve this issue.
A current workaround is to have two container with evcc. One with version 0.30 for creating the homelink and one with the latest version for working with.

It's tool-generated. Problem is that the bundling tool does not work with relative paths.

It's tool-generated. Problem is that the bundling tool does not work with relative paths.


Add script to clean up generated frameworks

The framework generated by build.swift out of the box needs some work to be compatible with codesign. This commit adds a script that adds in the expected "Versions" folder similar to frameworks generated by Xcode.
Will take any and all feedback / improvements on my poor Bash scripting :)
TODO:

[x] macOS build links and codesigns in app
[x] iOS build links and codesigns in app
[ ] iOS app can load in simulator

Closes #455

This is looking mostly good, but I'm still having trouble generating an Info.plist for the framework that iOS will accept, when I try to run an app with one of the Firebase frameworks embedded, I get:
Failure attempting to launch <XCUIApplicationImpl: 0x60400024d980 co.flightlabs.Flight at /Users/paul/Library/Developer/Xcode/DerivedData/Flight-cbyjdsglmnwngfasdbewusjszwnm/Build/Products/Debug-iphonesimulator/Flight.app>: Error Domain=IXUserPresentableErrorDomain Code=2 "This app was unable to be installed." UserInfo={NSLocalizedDescription=This app was unable to be installed., NSUnderlyingError=0x60400024ae90 {Error Domain=MIInstallerErrorDomain Code=35 "Failed to load Info.plist from bundle at path /Users/paul/Library/Developer/CoreSimulator/Devices/6530A98C-5983-447B-9972-052240711A00/data/Library/Caches/com.apple.mobile.installd.staging/temp.Jl6qEG/extracted/Flight.app/Frameworks/FirebaseCore.framework" UserInfo={LegacyErrorString=PackageInspectionFailed, FunctionName=-[MIBundle _validateWithError:], SourceFileLine=38, NSLocalizedDescription=Failed to load Info.plist from bundle at path /Users/paul/Library/Developer/CoreSimulator/Devices/6530A98C-5983-447B-9972-052240711A00/data/Library/Caches/com.apple.mobile.installd.staging/temp.Jl6qEG/extracted/Flight.app/Frameworks/FirebaseCore.framework}}}

Thanks for the PR.
As discussed in #455, it's not clear that this is solving the issue.
Also, we're planning to remove the build.swift script with #444 since its original reason for existence (building drop in replacements of binary CocoaPod static frameworks) is going away. However, we're open to keeping it around if it addresses another use case.

@paulb777 Ya, given build.swift is about to :fire:, no sense in this PR


Improving memory usage for PDF files loaded by chunks

When file is loaded using  pdfDataRangeTransport  ChunkedStream will allocate memory for the whole file. In our case opening 1.9GB PDF file crashed practically every browser except 64-bit Chrome and even that one had 50-50 chance of crashing.
I have refactored ChunkedStream to use non-continuous memory.  Reading (but not displaying) the same file now consumes 50MB or so. My commit is here:
https://github.com/bh213/pdf.js/commit/161218e81a74c3256703f9dbc8dbf09713c5dcaf
I've added unit tests and the code passes all the tests. Still, I am not sure this is ready for pull request yet. There is no eviction (even though it is trivial to implement) and I'd like a review of both of my one line changes to core.js and worker.js. I haven't done any pull requests before so I probably did something else wrong too.

Closing as, mostly a, duplicate of issue #5304.


Expandable list item animation is not smooth backwards

Short description of the problem:
There's no animation when pulling an expandable list item (until the animation finishes) and then going backwards.
See ItemSliding API Docs, try sliding one of the Login items until Mute button is gone and then back until it reappears.
What behavior are you expecting?
To have a smooth animation like on iOS.
For expected behaviour see Apple iOS' Mail animation.
Which Ionic Version? 2.x
Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.1.1
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0-beta.37
Ionic App Lib Version: 2.0.0-beta.20
ios-deploy version: 1.8.6
ios-sim version: 5.0.6
OS: Mac OS X El Capitan
Node Version: v5.0.0
Xcode version: Xcode 7.3.1 Build version 7D1014

We are aware of this issue, there are technical challenges that prevented us to work as "Apple iOS' Mail" for example.
I keep this issue open to track the progress 👍


Error in import library

Version used:
Error in iport library in my project
version: 0.1.11.
Unable to resolve dependency for ':app@debugUnitTest/compileClasspath': Could not resolve com.github.fornewid:neumorphism:0.1.11
Unable to resolve dependency for ':app@debug/compileClasspath': Could not resolve com.github.fornewid:neumorphism:0.1.11
Unable to resolve dependency for ':app@debugAndroidTest/compileClasspath': Could not resolve com.github.fornewid:neumorphism:0.1.11
Unable to resolve dependency for ':app@debugUnitTest/compileClasspath': Could not resolve com.github.fornewid:neumorphism:0.1.11.
Show Details
Affected Modules: app
I would like to use a library, but I am using this error when importing, makes many updates to the tools and android studio, nothing seems to solve

Please check a comment in #17 issue.
If not the reason, reopen this with more details. :)

Unable to resolve dependency for ':app@debug/compileClasspath': Could not resolve com.github.fornewid:neumorphism:{latest_version}.

Unable to resolve dependency for ':app@debug/compileClasspath': Could not resolve com.github.fornewid:neumorphism:{latest_version}.
facing this problem


Apply json_decode have JSON_THROW_ON_ERROR

Changed log

According to the reference, it should be great for throwing the error when calling the json_decode function has been problematic.

I'm going to pass on this for now as there are no complaints about this, and we're currently working on a new major version where we'll do this differently.


Add citations to distlib composition cmindex API

CmIndex classes should contain a citation attribute.
When cross sections are calculated, a statement should be printed to encourage users to cite the appropriate source for the optical constants.

Done


[Slider] [Request] Numeric Slider Values

Description
The slider currently does not offer out-of-the-box value display. According to the Material Design Spec, there is a slider which has the current value in an element above onSlide.
Images & references

It is related to #3393

@smcguinness  I put together this quick hack, may be helpful for you. Considering developing it further... https://github.com/tariqwest/material-ui-slider-label

We plan on migrating the component to the v1-beta branch. I'm closing the issue for #4793.


tests: make test_bulk_insert recreate tenant in same generation

Problem
Test deletes tenant and recreates with the same ID.  The recreation bumps generation number.  This could lead to stale generation warnings in the logs.
Summary of changes
Handle this more gracefully by re-creating in the same generation that the tenant was previously attached in.
We could also update the tenant delete path to have the attachment service to drop tenant state on delete, but I like having it there: it makes debug easier, and the only time it's a problem is when a test is re-using a tenant ID after deletion.
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

(ran the test_bulk_insert.py test locally without issue -- don't want to trigger a whole CI rebuild just to get a benchmark run here)


[MXNET-906] ONNX export/import: Selu

Description
Add support for ONNX import/export of Selu activation
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Add Selu import/export
Add tests for selu

Comments

alpha and lambda are fixed in MXNet based on the paper arxiv:1706.02515 (Eqn 14)

@mxnet-label-bot [pr-awaiting-review, ONNX]

Adding @Roshrini @zhreshold for review

Is this PR good to go @zhreshold @anirudhacharya ?


Local image & text

(Similar issue as https://github.com/basnijholt/home-assistant-streamdeck-yaml/issues/67)
I've downloaded some icons that I like, but they seem to be in front of the text.
If I use the icon from issue #67 via url: the text renders fine.
  - entity_id: sensor.inverter_active_power
    text: '{{ states("sensor.inverter_active_power") }}W'
    text_size: 20
    text_color: "green"
    icon: "/config/streamdeck/solar.png"

Hi @koehntopp, I am trying to reproduce this problem but for me the problem does not occur.
Are you sure you are on the version (>2023.04.10) after https://github.com/basnijholt/home-assistant-streamdeck-yaml/issues/67#issuecomment-1500965704 was merged?

Yep.

Oh lol, I understand what is happening, look at the text in the blue pixels in the middle. I think your icons have a very high resolution (higher than 72x72 at least) and then the text renders tiny.
I‘ll make sure to downsample the icon if needed.

I am relatively sure this is resolved by https://github.com/basnijholt/home-assistant-streamdeck-yaml/pull/120.
Please let me know if this is not the case, then I will reopen this issue.

BTW, note that it takes a few hours until the Add-on has been updated.

I have released the Add-on too: https://github.com/basnijholt/home-assistant-streamdeck-yaml-addon/releases/tag/v2023.7.3

Close 😬

You got the root cause right, though. The one image that shows is one I manually resized to 72x72
Now that I know what the problem is I can go and find some decent icons - thanks!
What is the native size of the buttons, is it 72x72...?

What is the native size of the buttons, is it 72x72...?
I went searching for the answer to the same question a while ago :) . And I found it here:

Stream Decks have different resolution for keys:

Stream Deck Mini - 72x72 pixels
Stream Deck - 72x72 pixels
Stream Deck XL - 96x96 pixels

If you create icons, we suggest using a resolution of 144x144 pixels. The Stream Deck software will scale these as needed.

@bogd, I really understand your concern. However, I don’t think it makes sense that when an image is loaded from file, it is resized differently than when downloading for example.
It should be resized to the native size, which I added in #140.
I’m sorry if this causes any issues for you.


Display message from task underneath the task title

The original listr package displays the message from eg. skip underneath the task name.
Listr2 replaces the title with the message:

This leads to a bit of confusion, since the message is in the middle of task names and feels out of place. I didn't find an option to disable this. Is it possible for the renderer to print the skip messages indented and underneath:

I currently use this snippet to achieve this:
manager.add({
  title: 'Bump version',
  task: () => {
    if (shouldSkip === true) {
      return new Listr({
        title: "Doesn't matter",
        task: (_, task) => task.skip('Version has been already changed')
      }, { collapse: false })
    }
    return '...!'
  }
});

Yeah i changed that since i wrote my messages as skip messages so i did not really needed the task title anymore. But i can add a flag to configure that behaviour in evening today or tommorrow.

Is this a viable solution for the render?
The default behavior is still to replace the title since it makes more sense for my application.
It has to be enabled through the option { collapseSkips: false } where { collapseSkips: true } is the default value, for the reason that I tried to explain.
Passing this via manager is much easier.
import { Manager } from 'listr2'

  manager.add([
    manager.indent<ListrCtx>((ctx) => [
      ...tasks
  ], { collapseSkips: false })

// or for all tasks
manager.runAll{ collapseSkips: false })

// the use case i use is initiate the class in to another class like the one below so it will work for all cases
this.tasks = new Manager({ renderer: this.getListrRenderer(), collapseSkips: false })

I will merge this after I have a look at the other issue. @ #2

Fixed with v1.3.5, need more testing I did not have the environment for testing at the moment.

Thanks a lot for the fix @cenk1cenk2!


chore(helm): fix lint findings

ct lint found linting errors in following files:
charts/umbrella/Chart.yaml

53:6      error    missing starting space in comment  (comments)
59:6      error    missing starting space in comment  (comments)

charts/umbrella/values.yaml

99:23     error    trailing spaces  (trailing-spaces)
112:4     error    missing starting space in comment  (comments)
124:62    error    too few spaces before comment  (comments)
237:4     error    missing starting space in comment  (comments)

There are some issues in the helper functions according to the linting workflow output:
Error:  templates/: template: umbrella/charts/edcprovider/templates/deployment-controlplane.yaml:243:27: executing "umbrella/charts/edcprovider/templates/deployment-controlplane.yaml" at <include "txdc.databaseSecretName" .>: error calling include: template: umbrella/charts/edcconsumer/templates/_helpers.tpl:280:21: executing "txdc.databaseSecretName" at <include "txdc.postgresql.fullname" .>: error calling include: template: umbrella/charts/edcconsumer/templates/_helpers.tpl:35:4: executing "txdc.postgresql.fullname" at <include "common.names.dependency.fullname" (dict "chartName" "postgresql" "chartValues" .Values.postgresql "context" $)>: error calling include: template: no template "common.names.dependency.fullname" associated with template "gotpl"

@almadigabor The problem here was that the recursive charts were not downloaded but referenced in the test.
https://github.com/eclipse-tractusx/e2e-testing/blob/fcabc2a2e938951c0a9e2de81833c5401d4c23bf/charts/umbrella/charts/tractusx-connector/Chart.yaml#L26-L35
Therefore I've modified the wf to previously download all dependency charts.


Typo Fix

This PR is:

[ ] Adding a new domain
[ ] Updating existing domain
[ ] Changing domain name
[ ] Removing existing domain from list
[x] Website code changes (darktheme.club site)
[ ] Other not listed

Whoops, how did I not notice this? 😅 Thanks for the fix!


After successful authentication with Cync, nothing appears to happen.

Describe Your Problem:
When first configuring the plugin, I am able to successfully authenticate with Cync (the plugin shows a green message saying so). However, nothing appears to happen after that.
Logs:
The plugin log window is blank.

Plugin Config:
{
    "platform": "CyncLights",
    "name": "Cync Lights",
    "emailAddress": "my email address appears correct",
    "refreshToken": "NzgyQkM4RTc0OENEMzA5QUZDNjRERTc0ODZDNDFBNzlCNEEyRkJFNjg3N0NGOTlCQThCREU4N0NBMDc5NDQ4Qw==",
    "userID": 234914670,
    "authorize": "2207d2cb020ff41b"
}

Screenshots:

Environment:

Plugin Version: Installed: v1.5.3
Homebridge Version: 1.7.0
Node.js Version: v18.15.0
NPM Version: 10.1.0
Operating System: Synology DSM 7.1.1-42962 Update 6, Linux

OMG, I just restarted Homebridge, and that resolved the issue. My apologies. I will leave everything here should someone else stumble over this.

Closing the issue.


Stop rerendering tabs on layout change

User Story
As a user I want to have my user interface stay in that current state, even when dragging around windows.
This is especially important for uis that hold some state and process the user is currently doing.
Examples could be opening a (in tab) dialog, working on checks, open a website and navigating inside, ...
Description
Do not re-render when the dock layout changes
See https://discord.com/channels/1064938364597436416/1304144059228618802/1305977058412859443

Note that, for react web views, we provide useWebViewState as a web view prop with the intent to persist their state so they don't have to worry about being cleared out. HTML web views can also access web view state with globalThis.getWebViewState, globalThis.setWebViewState, and globalThis.resetWebViewState. Since URL web views cannot communicate over the PAPI, however, they do not have a way to interact with web view state at the moment.

Thanks @tjcouch-sil.
Although web views might be able to use this, I'd say it should not be required as loosing the state on rearranging tabs is unexpected.
I've not seeing many actively using it either.
Settings dos not persist the selection
https://github.com/user-attachments/assets/084d5da0-41f9-4f2c-b758-f65e666c696d
Inventories do not persist the selection
https://github.com/user-attachments/assets/3388fa66-aced-4a05-ac22-b63db5d32f31
Text collection does persist the selection
https://github.com/user-attachments/assets/93bc3a30-c625-4ba7-b266-7eace6985246


[Package Request] VST3 SDK

https://github.com/steinbergmedia/vst3sdk

We can’t reopen this issue until a PR is opened, unfortunately, consider making a pull request!


Allow for dots in package names

Currently, naming a package "Vendor_Name.Package_Name" is disallowed when creating a package. Can we make it so that dots are valid separators in a package name?

Could it be as simple as changing the regex at ...
https://github.com/pyrus/Pyrus/blob/master/src/Pyrus/Validate.php#L38
... to something like '[A-Za-z][a-zA-Z0-9_.]+' ?

Any issues regarding this ? Or do we need to send a PR ?

I can't think of any issues that change would cause. A PR would be great.

PR and a small test would be much appreciated.

How can I run test first ?
 Never used phpt though :( .

You can run all the tests with:
pyrus run-phpt -r tests or pear run-tests -r tests
I believe PHPUnit can run .phpts but I've no experience with that.

$ cat run-tests.log
TOTAL TIME: 30:02
1 PASSED TESTS
1 SKIPPED TESTS
2 FAILED TESTS:
/media/Linux/Pyrus/tests/Validate/validateversion.failure.alpha.2.0.0.phpt
/media/Linux/Pyrus/tests/Validate/validateversion.validsnapshot.phpt

Wondering Is that ok with the failure for validate ?

Hmm. Only 2 failures is fantastic — that there were only 4 tests is a problem. :-)
There should be around 726 tests.

Here's what I get:
TOTAL TIME: 03:28
711 PASSED TESTS
7 SKIPPED TESTS
8 FAILED TESTS:
/Users/bbieber/Documents/workspace/Pyrus/tests/AtomicFileTransaction/AtomicFileTransactionClass/createOrOpenPath/createoropenpath.fail.fp.stream.empty.phpt
/Users/bbieber/Documents/workspace/Pyrus/tests/AtomicFileTransaction/TransactionClass/createOrOpenPath/createoropenpath.fail.fp.stream.empty.phpt
/Users/bbieber/Documents/workspace/Pyrus/tests/Channel/creation.phpt
/Users/bbieber/Documents/workspace/Pyrus/tests/Config/setCascadingRegistries/basic2.phpt
/Users/bbieber/Documents/workspace/Pyrus/tests/Registry/Pear1/getdependentpackages/getdependentpackages.basic.phpt
/Users/bbieber/Documents/workspace/Pyrus/tests/ScriptFrontend/Commands/findpear1.phpt
/Users/bbieber/Documents/workspace/Pyrus/tests/ScriptFrontend/Commands/findpear2.phpt
/Users/bbieber/Documents/workspace/Pyrus/tests/ScriptFrontend/Commands/help.phpt```

By the way I run only for Validate, for it seems only change for Validate is needed .
 $ php pyrus.phar run-phpt -r tests/Validate

But failures are not good , is this only on master ?

hm , sorry it seems something went wrong . Forgot about the error when I run it . Now I am getting 36 success ones for Validate .

Oh, I thought you were still trying to understand how to run the tests.
Yes, if you've got a new test, and there are now failures — that's a problem.
It looks like there's currently 36 tests in the Validate dir:
$ php pyrus.phar run-phpt -r tests/Validate
...
TOTAL TIME: 00:02
36 PASSED TESTS
0 SKIPPED TESTS
0 FAILED TESTS

Sorry this seems hard for me :( . I am stepping out .
Things I did
1 ) Created a channel server with pirum
2 ) Changed the validation as @pmjones mentioned
3 ) To test we need to create a package . As I have made the necessary changes , I cannot use the pyrus.phar I guess . Seems I want to generate again the phar file .
I am still not sure how to make it .
So sorry leaving for the time :( . If someone can help if its easy .

I think we're good to go. Thanks @harikt

Wow great @saltybeagle . The credit goes to @pmjones .
Yes I have tested it some days back when you merged the commit.
But I was not successful creating the phar file . So you guys will be updating the phar soon ? May be its easy for you :-) . @pmjones  What about introducing @pear packages in the coming release if phar is available ?


git: support some form of integrity

Currently, pacote has disabled integrity for git repos, which causes npm to re-download then uninstall every git dependency on specific-package installs.  This makes npm@5 extremely painful for in-house development.
This was introduced as "fix(git): stop generating integrity for git" in https://github.com/zkat/pacote/commit/d45363b605589dae735f126a3ea19b2bf0165caf, as part of https://github.com/zkat/pacote/pull/127
I have experimentally allowed pacote to generate integrity checksums on a local copy of npm.  So far it fixes the issue without apparent side effects, but I am pretty sure I must be missing something.  The pull request mentions ongoing issues, but I have been unable to find what this may be in reference to.
The only indication I have found so far is in a comment about shrinkwrap explaining that integrity for tarballs is not consistent, but so far I have not seen this in practice and do not know how to verify it either way.
Can you help me understand why this change was made?  I am not sure whether the solution to npm's issue is "pacote should support git integrity" or "npm should allow packages without integrity".
Perhaps an alternate is to use the specific commit reference as the integrity string?  Is that string contracted to be a checksum of the files, or will any consistently applied value work?

While I do understand some problems are harder than they seem, generating and tracking proper cache for git dependencies is not the main issue here. A cache miss should not result in packages being removed, it should result int packages being fetched 100% of the time.
This is fundamentally broken in a way that makes it extremely painful to work with git dependencies. Why is such behavior preferred rather than making sure every dependency is installed correctly, even if it takes longer?

@saboya the cache miss isn't what's causing the removal: it's a bug in the way npm itself recognizes and handles git dependencies.


Design notes

After using F#+ and designing types implementing the required static member we observe that types end up with undesired duplication of signature, for example:
ZipList.map f x (function) and ZipList.Map(x, f) (static member).
This can be solved by "hiding" the static member by marking it as "deprecated", but I was thinking that if we use the applicative operator for map we solve that issue and on top of that this code:
(+) <!> ZipList [1;2] <*> ZipList [3;4]

Will just work, independently of F#+ generic calls. I mean even if FSharpPlus namespace is not open and generic operators are not in scope, the above code will compile, without resolving any complicated static constraint.
So, I propose the following design guideline:

For unary operations, like ToSeq, OfBytes we use lower case. The exception here is Return which is a keyword in lowercase.

For binary:

Is there any standard/wide accepted operator ( <!>, <|>, >>=, =>>, <*> ...) ? => Use it.
Does it make sense tupled => Use it tupled, lowercase.
Define it Uppercase but in the client code is recommended to use an attribute to hide it.

For ternary operations or more: 2) and 3) above applies.

All this leads one more time to the question about the utility of the Extensions attributes.
I addition, now we've seen many operators need internal tupling of arguments in order to avoid upcasting to interfaces at overload resolution, which render those attributes unusable.
For C# usability we may consider instead the extensions defined in Extensions.fs file.
We will still have duplicated members/functions internally, but this is fine because it allows us to expose the non-generic function and simplifies the implementation of the static member, which is desirable, I mean to keep the body of the static member short (a call to the non generic).

My feeling is mostly that marking things that are needed as deprecated can be sort of dangerous ... (as I've seen from other projects that have used that technique)

So by having instead of:
type DList<'T> with
   ....
    static member Bind (x, f) = bind x f

you have
type DList<'T> with
   ....
   static member (>>=) (x, f) = bind x f

?

Yes. Which problem you noticed with the deptecated attribute?
The right thing would br to mark them private or internal, but with a trait call that’s a problem.
.NET is not designed for F#

Empty constructors marked as deprecated or obsolete could disappear (since there was not explicit reference for them, while they where needed for the deserialization).

Right now we are in that situation, in the sense that they don’t have refetences.

Anyway, that's a small details. Worst case we leave them visible, but the key change here will be habing to define:

static member (>>=) instead of Bind
static member (<!>) instead of Map
static member (<|>) instead of Append

Another C# aspect to consider is the other way around, using C# from F#, in this case would mean using a type defined in C#. That's something I had in mind when I came up with this design, but for bind and map we expect an F# function, not a Func.

Indeed. I think having the operator symbols would be nice enough.

I doubt when I see (<!>) instead of Map.
Map is used everywhere in the doc to showcase the generics feature.
May be I should just get used to :)

But since you have the overload map, how often is it that you need to be confronting DList.map ?

Good question, actually it all depends on which style the end user choose.
As said in the readme, some people might prefer to use generic functions (map) some others would prefer the more conservative F# style (DList.map).

Another was of hiding methods could be with one of these attributes:
[<CompilerMessage("This method is not intended for use from F#.", 10001, IsHidden=true, IsError=false)>]

[<System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>]` s

If it works, then that's quite nice!

This was already implemented with the exception that for Unary operators we keep duplicating, the reason is that all FSharp.Core generic functions use PascalCase constraints in its type signature.
Regarding use of operators, we still keep using Map, although we can change to <!> but it might not be a good hint for a Functor in the signatures.


Publish firefox and edge store extension

[x] publish extension on firefox store
[ ] publish extension on edge microsoft store
[x] update doc to point to store

edg store support the chrome store... So skip it for moment.
https://learn.microsoft.com/fr-fr/windows/uwp/monetize/create-an-add-on-submission

I gave it a try in Firefox, but I think there is an error and the extension doesn't load with a problem in links.js SyntaxError: export declarations may only appear at top level of a module

@0cv I have fixed an issue with the original manifest.json to rmove links.js from it.

@0cv can you retry with last version?

@0cv can you retry with last version?

Did that work for you? It doesn't for me (the links error has disappeared, but the extension isn't showing up)

@0cv now yes. Indeed the firefox build do not worked at all with script on reloaded. There was an error on manifest and a bug introduce by mac testing on reloaded that I need to remove. Anyway now it is working.


streaming (at least with filed) doesn't work

This is restify 1.0 (https://github.com/mcavage/node-restify/tarball/master#0dfba4fdfd9def5111c29dffd241f344ff1293a8).
...
server.get("/foo.txt", function (req, res, next) {
  filed('tmp/foo.txt').pipe(res);
  next();
});
...

where "filed" is node-filed. The client does not get the "foo.txt" contents before the connection is closed, although the headers look right.
$ curl -iSs http://<IP_ADDRESS>:8080/foo.txt
HTTP/1.1 200 OK
content-type: application/octet-stream
etag: 5138fda15066d6ef868a67d3328b72d6
last-modified: Fri, 20 Jan 2012 16:30:33 -0800
Connection: keep-alive
Transfer-Encoding: chunked

$

Typo; property writeable instead of writable.


Generated POM or Ivy descriptor for replaced module doesn't reflect proper dependencies

Expected Behavior
When a direct dependency is replaced via module replacement, maven POM and Ivy descriptor should use the replacement as part of the final XML.
Current Behavior
Currently, it writes the original dependency.
Steps to Reproduce
This is a sample project for reproducing this: https://github.com/nebula-plugins/gradle-nebula-integration/tree/master/gradle-module-replacement-test
Given this build script:
import gradle.module.replacement.test.plugin.DependencyPlugin

plugins {
    // Apply the java-library plugin to add support for Java Library
    id 'java-library'
    id 'maven-publish'
    id 'ivy-publish'

}

apply plugin: DependencyPlugin

repositories {
    jcenter()
}

dependencies {
     api 'com.google.truth:truth:0.28'
     modules {
         module('com.google.collections:google-collections') {
             replacedBy('com.google.guava:guava')
         }
     }
}

publishing {
    publications {
        maven(MavenPublication) {
            from components.java
            versionMapping {
                allVariants{
                    fromResolutionResult()
                }
            }

        }
        ivy(IvyPublication) {
            from components.java
            versionMapping {
                allVariants{
                    fromResolutionResult()
                }
            }

        }
    }
}

We are replacing google-collections with guava. If we introduce a plugin that adds dependencies (similar to what can be found in other plugins such as lombok), for example:
class DependencyPlugin implements Plugin<Project> {
    @Override
    void apply(Project project) {
        addCollectionsDependendency(project, "api")
    }

    private void addCollectionsDependendency(Project project, String configurationName) {
        project.dependencies.add(
                configurationName,
                "com.google.collections:google-collections:1.0"
        )
    }
}

When this plugin is applied, I can see the following dependency graph:
compileClasspath - Compile classpath for source set 'main'.
+--- com.google.collections:google-collections:1.0 -> com.google.guava:guava:18.0
\--- com.google.truth:truth:0.28
     +--- com.google.guava:guava:18.0
     \--- junit:junit:4.10
          \--- org.hamcrest:hamcrest-core:1.1

Replacement happens, however... when publishing a POM or Ivy descriptor we get the following:
?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <groupId></groupId>
  <artifactId>gradle-module-replacement-test</artifactId>
  <version>unspecified</version>
  <dependencies>
    <dependency>
      <groupId>com.google.collections</groupId>
      <artifactId>google-collections</artifactId>
      <version>1.0</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>com.google.truth</groupId>
      <artifactId>truth</artifactId>
      <version>0.28</version>
      <scope>compile</scope>
    </dependency>
  </dependencies>
</project>

and module info:
{
  "formatVersion": "1.0",
  "component": {
    "group": "",
    "module": "gradle-module-replacement-test",
    "version": "unspecified",
    "attributes": {
      "org.gradle.status": "integration"
    }
  },
  "createdBy": {
    "gradle": {
      "version": "5.4",
      "buildId": "ifwmcnxslvewrcmeypdqqhpjja"
    }
  },
  "variants": [
    {
      "name": "apiElements",
      "attributes": {
        "org.gradle.category": "library",
        "org.gradle.dependency.bundling": "external",
        "org.gradle.jvm.version": 8,
        "org.gradle.usage": "java-api-jars"
      },
      "dependencies": [
        {
          "group": "com.google.collections",
          "module": "google-collections",
          "version": {
            "requires": "1.0"
          }
        },
        {
          "group": "com.google.truth",
          "module": "truth",
          "version": {
            "requires": "0.28"
          }
        }
      ],
      "files": [
        {
          "name": "gradle-module-replacement-test-unspecified.jar",
          "url": "gradle-module-replacement-test-unspecified.jar",
          "size": 1147,
          "sha1": "287897e93d34ddabe79418773ad9586e0daf81ab",
          "md5": "db4e7a3119fa94e1c5d7e8094dd9aa0e"
        }
      ]
    },
    {
      "name": "runtimeElements",
      "attributes": {
        "org.gradle.category": "library",
        "org.gradle.dependency.bundling": "external",
        "org.gradle.jvm.version": 8,
        "org.gradle.usage": "java-runtime-jars"
      },
      "dependencies": [
        {
          "group": "com.google.collections",
          "module": "google-collections",
          "version": {
            "requires": "1.0"
          }
        },
        {
          "group": "com.google.truth",
          "module": "truth",
          "version": {
            "requires": "0.28"
          }
        }
      ],
      "files": [
        {
          "name": "gradle-module-replacement-test-unspecified.jar",
          "url": "gradle-module-replacement-test-unspecified.jar",
          "size": 1147,
          "sha1": "287897e93d34ddabe79418773ad9586e0daf81ab",
          "md5": "db4e7a3119fa94e1c5d7e8094dd9aa0e"
        }
      ]
    }
  ]
}

We would expect the guava replacement to be reflected in the POM / module files.

Is this related to https://github.com/gradle/gradle/issues/9565 ?

No, it is different, although the end solution is similar.
So effectively this was fixed through #10019. Note that the substitution only takes place when publishing resolved versions.
Without that behavior, Gradle does not even attempt resolution and thus has no way to know that a first level dependency was substituted.


[Bug]: Normal model version names are not longer allowed

What happened?
I've tried to publish new model version with the same naming convention as previous one, and I couldn't - normal model version names (like git tag, usually up to 20-30 characters) are no longer allowed. It was working fine about 2 weeks ago, but currently it's limited to only 10 characters.
I've originally started a discussion for it (https://github.com/orgs/civitai/discussions/446), but it's rather regression in functionality, so I am reporting this as an issue.
Steps to reproduce the problem

Start publishing new model, or edit existing model details.
Try to set a name longer than 10 characters (like "MoonRide Mix 10").

What should have happened?
Model names longer than 10 characters should be allowed - it should work like git tag names, where short, but descriptive names are often used. I think that 20-30 characters should be OK.
If you need to keep it shorter for whatever reason, then please allow at least 15 characters.
What platforms do you use to access the site?
Windows
What browsers do you use to access the site?
Microsoft Edge
Additional information, context and logs
No response

I've just tried it today (when website style changed to dark colors), and it seems to be working, now.


Issue 295: Fix multiple thread conditional appending

Change log description
Fix race condition in multi thread conditional append.
I have run the performance benchmark and there is no difference between the current and the past impl.
Purpose of the change
Fix #295
What the code does
Current impl is to only hold the latest EventHandle. The fix is to hold all the EventHandles and checks each one to see if there is a ConditionalCheckFailure.
How to verify it

Codecov Report

Merging #296 (892bc1b) into master (c3b9268) will increase coverage by 5.98%.
The diff coverage is 100.00%.


Search Query Categorization (Phase 2)

This is a followup on the Search Query Categorization (Phase 1):
https://github.com/opensearch-project/OpenSearch/issues/10250
During Phase 1, the following enhancements were implemented:

Logging of query shape as a trace log.
Capture of query type information and level information for each query and sub-query for select query types (Bool, Function Score, Match, Multi-Match, Match Phrase, QueryString, Range, Regex, Term, Wildcard).
Recording of top-level query type information for Sort and Aggregation queries.
Capturing the order of the sort queries (asc, desc).
Integration with the Metrics Framework.

In Phase 2, our objectives include:

Expanding the capture of query type and level information to encompass additional query types.
Extracting field-related information, specifically the number and types of fields involved in the queries.
Identifying and documenting the types of aggregations applied.
Incorporating the number and types of fields as part of the response data.

We welcome any feedback or suggestions for additional information that can be included in Phase 2 of this initiative.

cc @getsaurabh02

Hi, are we on track for this to be released in 2.12 ?

Yes, this is released in 2.12. Closing this issue for now. Will iteratively add more metrics on the search path and will add these as future issues.


Error: Tried to add null to stats for path categories,performance

Hi, got an error when trying to use the new Lighthouse report. Can I get some help with it?
Command:
docker run --shm-size=1g --rm -v "$(pwd)":/sitespeed.io sitespeedio/sitespeed.io:11.4.0-plus1 -n 1 https://tv.yousee.dk/tv-guide --plugins.add analysisstorer --plugins.add /lighthouse
Docker version:
Docker version 19.03.5, build 633a0ea
OS:
osx Catalina 10.15.1 (19B88)
In the report I can see the following

Log:
Google Chrome 78.0.3904.87
Mozilla Firefox 70.0
[2019-11-28 10:31:38] INFO: Versions OS: linux 4.9.184-linuxkit nodejs: v12.13.0 sitespeed.io: 11.4.0 browsertime: 7.2.2 coach: 4.2.0
[2019-11-28 10:31:38] INFO: Will run Lighthouse tests after Browsertime has finished
[2019-11-28 10:31:38] INFO: Running tests using Chrome - 1 iteration(s)
[2019-11-28 10:31:39] INFO: Testing url https://tv.yousee.dk/tv-guide iteration 1
[2019-11-28 10:31:54] INFO: https://tv.yousee.dk/tv-guide 585 requests, backEndTime: 135ms, firstPaint: 278ms, firstVisualChange: 302ms, DOMContentLoaded: 1.35s, Load: 1.37s, speedIndex: 2222, visualComplete85: 4.83s, lastVisualChange: 5.83s, rumSpeedIndex: 278
[2019-11-28 10:31:54] INFO: The server responded with a 404 status code for https://tv.yousee.dk/tv-guide
[2019-11-28 10:31:54] INFO: The server responded with a 403 status code for https://cloud.yousee.tv/static/img/logos/Seapp_Small_KanalSp...
[2019-11-28 10:31:54] INFO: The server responded with a 403 status code for https://cloud.yousee.tv/static/img/logos/seapp_small_kanalsp...
[2019-11-28 10:31:54] INFO: The server responded with a 403 status code for https://cloud.yousee.tv/static/img/logos/Seapp_Small_ESPNCla...
[2019-11-28 10:31:54] INFO: The server responded with a 403 status code for https://cloud.yousee.tv/static/img/logos/small_espnamerica.p...
[2019-11-28 10:31:54] INFO: The server responded with a 403 status code for https://cloud.yousee.tv/static/img/logos/seapp_small_silverh...
[2019-11-28 10:31:54] INFO: The server responded with a 403 status code for https://cloud.yousee.tv/static/img/logos/small_drupdate.png
[2019-11-28 10:31:54] INFO: Start collecting Lighthouse result for https://tv.yousee.dk/tv-guide iteration 1
[2019-11-28 10:32:02] ERROR: Lighthouse could not test https://tv.yousee.dk/tv-guide please create an upstream issue: https://github.com/GoogleChrome/lighthouse/issues/new?template=Bug_report.md Error: Tried to add null to stats for path categories,performance
    at Object.pushStats (/usr/src/app/lib/support/statsHelpers.js:27:13)
    at Aggregator._pushStats (/lighthouse/aggregator.js:18:23)
    at /lighthouse/aggregator.js:23:12
    at /lighthouse/node_modules/lodash.foreach/index.js:221:11
    at baseForOwn (/lighthouse/node_modules/lodash.foreach/index.js:153:20)
    at /lighthouse/node_modules/lodash.foreach/index.js:190:14
    at forEach (/lighthouse/node_modules/lodash.foreach/index.js:290:10)
    at Aggregator.addToAggregate (/lighthouse/aggregator.js:22:5)
    at Object.processMessage (/lighthouse/index.js:156:29)
[2019-11-28 10:32:04] INFO: HTML stored in /sitespeed.io/sitespeed-result/tv.yousee.dk/2019-11-28-10-31-38

Thank you @feliupe for reporting, let me fix that to the next release.

I've fixed the error, going out in the next release. However seems like Lighthouse can't test that page.

Thanks @soulgalore . Apparently there is also a problem in our page, returning 404. So it looks like the error makes kinda sense :)


Add export command to UG feats

Resolves #5

Codecov Report

Merging #10 (d05ec03) into master (3f0322e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f0322e...d05ec03. Read the comment docs.


Getting unknown as result type

Hi, I'm trying to parse the JSON schema from this JSON file:
https://github.com/jsonresume/resume-schema/blob/master/schema.json
Anyway, when doing so, I just get unknown as the result type.
This is my code:
import type { FromSchema, JSONSchema } from 'json-schema-to-ts';
import resumeSchema from 'resume-schema/schema.json';
const schema = resumeSchema as const;
export type ResumeSchema = FromSchema<typeof schema>;

Would you mind guiding me on what I'm doing wrong?
Thanks in advance!

Yup, it's all there: https://github.com/ThomasAribart/json-schema-to-ts/blob/main/documentation/FAQs/does-json-schema-to-ts-work-on-json-file-schemas.md


clarify loadPath for node-sass wrt to npm v3

This PR updates the Foundation SASS docs to clarify loadPath for the grunt example.
Due to the changes npm v3 introduced regarding dependency resolution, I'm not sure we can guarantee the foundation module will live in the root of the node_modules folder.
Therefore, this update suggests using node's builtin require (https://nodejs.org/dist/latest-v4.x/docs/api/modules.html#modules_all_together) and path (https://nodejs.org/dist/latest-v4.x/docs/api/path.html) modules for determining the path to Foundation.

Assuming Foundation is a top-level dependency, it's always going to be in the same place, right?

Assuming Foundation is a top-level dependency, it's always going to be in the same place, right?

Yes I believe this is correct.

Also, going from npm v2 to v3, isn't it more likely that foundation-sites will be a top-level folder in node_modules?

Come to think of it, that's probably true too. Only conflicts would be between different versions of foundation-sites in a package's sub-dependencies and therefore installed in a sub-folder of a dependency. Probably not an ordinary use-case though!

For sure. Eyeglass is going to be a good solution to this problem once it sees wider adoption, because it makes Sass's @import basically work like Node's require(), which removes the need to specify manual load paths.
Foundation works as an Eyeglass module right now, and once that thing hits 1.0 I'd like to integrate it into our build processes.

Great, thanks for the consideration! Glad that Eyeglass is getting attention here!


Add paths to dymoconnect

It turned out that there were a few additional paths needed.

Looks good!
Is there a double / in your code? Or does my app display this incorrectly?
appLaunchDaemons+=("/Library/LaunchDaemons//com.dymo.pnpd.plist")

Good finding! Corrected file is pushed.


Allow users to pass local embeddings to Weaviate Hybrid Search Retriever

Feature request
Fork off from this issue: https://github.com/hwchase17/langchain/issues/5300
The idea is to provide the WeaviateHybridSearchRetriever with the ability to use local embeddings similar to the Weaviate vectorstore. Specifically, for the WeaviateHybridSearchRetriever.add_documents() and WeaviateHybridSearchRetriever.get_relevant_documents() functions to work similar to the Weviate.from_texts() function where there is the option to use local embeddings if passed during creation. Additionally, the WeaviateHybridSearchRetriever._create_schema_if_missing() function likely needs to remove the default addition of a vectorizer in the schema object (related issue here: https://github.com/hwchase17/langchain/issues/5300).
Motivation
This will allow those of us running Weaviate without embedding modules (like myself) to use the Weaviate Hybrid Search Retriever.
Your contribution
I am planning on working to get a fix locally, I can potentially submit this as a PR down the line. Busy this week so others would probably beat me to it. I can review though.

I'm here too for a similar issue,
we should allow using Weaviate without embeddings, see: https://weaviate.io/developers/weaviate/quickstart#option-1-vectorizer
it seems Weaviate has the option to handle vectorization internally which sounds cheaper on a large scale than using openAIEmbeddings i often run into rate limit errors because of large documents (on the free plan)


Idea: Extra builders for htmx

Hi there,
in search of a lightweight web application frameworks, I've recently discovered Shaka and htmx. I think they could be used together very well. Both are very lightweight, yet very capable.
I'm not yet as skilled a Scala developer as I want to be. However, for adding htmx attributes to Shaka, I thought that creating some extra builders (like the Builders.scala) as a separate module would be the way to do it.
WDYT?

Hi Oliver,
I think that's a great idea.
I haven't used htmx before, but it looks like it would work well. The builder DSL could be implemented like
inline def hxGet(path: String)(using e: Element, binding: Binding[?]): Unit =
  // and add a click listener that checks e for any hx-swap or other attributes, and fires GET

The question is how the DOM swapping would work. We need to make sure all Bindings are closed properly when changing the DOM. I'll think about this some more, but I think it can be done.

Unfortunately I don't think that HTMX will work with the Shaka databinding.
But you can still copy the Builders.scala HTML DSL into a new library and implement HTMX with it (just remove all the Binding parameters).
I'm going to eventually make a PR for 'ApiState', which extends State and can post/get/patch data.

Wow! Really great that you took a look into this! I really need to get much more into Shaka, but that ApiState change also sounds nice.
Thanks for investigating!


DOC: refine doc for spatial.distance.squareform

What does this implement/fix?
Improve documentation for squareform() function:

remove misleading variable d, keep only n
use more math-rendered blocks
loosen vector size restriction (as code actually allows input vectors of zero length)

Thanks @Alvant

use more math-rendered blocks

This change is unfortunately undesirable, because it makes the plain-text version of the docstring pretty much unreadable. And that's important because a lot of users read docstrings in, e.g., IPython. So we try to strike a balance; only using :math: if it really helps the html and doesn't hurt terminal readability too much. Could you undo those changes?

@rgommers, thanks for the explanations!
Yes, I overdid it a little 😊 but now the point is clear. Ok, I hope things are better now.

Thanks @Alvant, LGTM now, merged. I just changed some single to double backticks (for typesetting as code).


Enhance importer to be more relaxed with single insert errors

Refs https://github.com/TryGhost/Ghost/issues/10580
^ The whole import failed because a single field did not match a validation condition.
It is nearly impossible for the importer to catch all edge cases or bugs which Ghost has introduced.
My thinking is that the importer should be more relaxed if it receives an error for an insert.
It should continue with importing as much as possible and report back which inserts did not work.
It's much better if you import a file and everything works except of settings compared to "not imported at all". This will reduce the chance of breaking the full importer feature compared to a single resource does not import.

This requires strong deduplication and maybe further UI options.


coc-clangd unable to get local issuer certificate.

When I type :CocInstall coc-clangd, then it shows error:
✗ coc-clangd unable to get local issuer certificate

Also, in case of :CocCommand clangd.install, then it shows that:
[coc.nvim] Command: clangd.install not found

So how can I fix this?

Does your network behind a proxy? It's not coc or coc-clangd issue. Try add "http.proxyStrictSSL": false to your coc-settings.json and try again.


Update package.json

Added missing reference to @react-spring/three

The react-spring dependency installs all platform packages, including @react-spring/three and @react-spring/web
See https://react-spring.io/#installation

Apologies. It did work fine today on. Yesterday somehow it failed.
Closging the request.


Proposal for better error messages

This is a proof-of-concept proposal for improving our error messages.  It currently implements a few cases in flax.core.scope. If we get consensus on this proposal then I will continue to implement it for our entire code base (~70 cases in total).
I think the proposal improves the user experience a lot, since we can give concrete code examples in the error messages, rather than throwing generic Python exception with a one-line explanation. The error class doc-strings serve as documentation on RTD directly, which makes the proposal quite light-weight.
RTD demo: https://flax.readthedocs.io/en/improve-error/flax.errors.html
Before:
>>> from flax.core import scope
>>> scope.in_filter(3, 4)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/marcvanzee/github/flax/flax/core/scope.py", line 105, in in_filter
    raise TypeError(f'Invalid Filter: "{filter_like}"')
TypeError: Invalid Filter: "3"

After:
>>> from flax.core import scope
>>> scope.in_filter(3, 4)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/marcvanzee/github/flax/flax/core/scope.py", line 105, in in_filter
    raise InvalidFilterError(f'Invalid Filter: "{filter_like}"')
flax.errors.InvalidFilterError: Invalid Filter: "3" (https://flax.readthedocs.io/en/improve-error/flax.errors.html#flax.errors.InvalidFilterError)

I don't have a super strong opinion but just for consideration:
We could make the message the responsibility of the error class itself so you have things like:
class InvalidFilterError(FlaxError):
  def __init__(self, filter_like):
    super().__init__(f'Invalid Filter: "{filter_like}"')
    self.filter_like = filter_like

This way all error messages are in one module which should also make maintenance easier. For example it is very easy to keep messages consistent in style.

I don't have a super strong opinion but just for consideration:
We could make the message the responsibility of the error class itself so you have things like:
class InvalidFilterError(FlaxError):
  def __init__(self, filter_like):
    super().__init__(f'Invalid Filter: "{filter_like}"')
    self.filter_like = filter_like

This way all error messages are in one module which should also make maintenance easier. For example it is very easy to keep messages consistent in style.

We could make the message the responsibility of the error class itself so you have things like:

Yes I like that idea, I've implemented it.

We could make the message the responsibility of the error class itself so you have things like:

Yes I like that idea, I've implemented it.

Codecov Report

Merging #949 (97885b7) into master (5924484) will increase coverage by 0.11%.
The diff coverage is 82.55%.

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
+ Coverage   80.93%   81.04%   +0.11%
==========================================
  Files          55       56       +1
  Lines        4421     4496      +75
==========================================
+ Hits         3578     3644      +66
- Misses        843      852       +9

Impacted Files
Coverage Δ

flax/core/scope.py
92.92% <44.44%> (+0.33%)
:arrow_up:

flax/errors.py
82.60% <82.60%> (ø)

flax/serialization.py
86.33% <88.88%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a7c91...97885b7. Read the comment docs.

Codecov Report

Merging #949 (97885b7) into master (5924484) will increase coverage by 0.11%.
The diff coverage is 82.55%.

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
+ Coverage   80.93%   81.04%   +0.11%
==========================================
  Files          55       56       +1
  Lines        4421     4496      +75
==========================================
+ Hits         3578     3644      +66
- Misses        843      852       +9

Impacted Files
Coverage Δ

flax/core/scope.py
92.92% <44.44%> (+0.33%)
:arrow_up:

flax/errors.py
82.60% <82.60%> (ø)

flax/serialization.py
86.33% <88.88%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a7c91...97885b7. Read the comment docs.

Are you keeping a list of TODOs for this errors project? Could you add that there?

I created a tracking issue containing all TODOs: #957

Are you keeping a list of TODOs for this errors project? Could you add that there?

I created a tracking issue containing all TODOs: #957


Can't send from IRC to Discord afterwards.

I've been using this for more than a year. I'm not good at explaining but here's the issue I copied from the command prompt.

(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) UnhandledPromiseRejectionWarning: TypeError: this.client.listenerCou
nt is not a function
at item.request.gen.end (C:\Users\TV-Nihon\AppData\Roaming\npm\node_modules
discord-irc\node_modules\discord.js\src\client\rest\RequestHandlers\Sequential.j
s:87:29)
at then (C:\Users\TV-Nihon\AppData\Roaming\npm\node_modules\discord-irc\node
_modules\snekfetch\src\index.js:214:21)
at
at process._tickCallback (internal/process/next_tick.js:189:7)
(node:5220) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This
error originated either by throwing inside of an async function without a catch
block, or by rejecting a promise which was not handled with .catch(). (rejection
id: 2)
(node:5220) [DEP0018] DeprecationWarning: Unhandled promise rejections are depre
cated. In the future, promise rejections that are not handled will terminate the
Node.js process with a non-zero exit code.
(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) DeprecationWarning: Collection#find: pass a function instead
(node:5220) DeprecationWarning: Collection#find: pass a function instead<

After the "UnhandledPromiseRejectionWarning" shows up, it cannot send transmission from IRC to Discord from one of the multiple channels (while the rest are working).
Screenshots from Discord: https://i.imgur.com/9N6TX6e.png, IRC: https://i.imgur.com/jfaaVTv.png
Can you fix that issue?
P.S. "DeprecationWarning: Collection#find: pass a function instead" annoys me so can you do something about that?

I do have the exact same problem. Do you need any more debug logging?

Thanks for looking into it, let's wait for upstream to fix it. As a workaround, I use a systemd timer to restart discord-irc every hour.

Seems similar to #326 and #328.

The error message occurs for me when many lines are sent at once. IRC-> discord cuts off on 5th or so message, iirc.

I'll close this issue for now, as I haven't heard anything recent and the above logs look strange (our uses of find are all currently valid?). If you notice any recent connectivity issues, please get back in touch!

Sorry to say, but I'm still getting that and will probably add --unhandled-rejections=strict to the service to see if systemd can just restart it instead of being blind about the bot not working.
Aug 12 18:49:13 masterpi npm[2731]: (node:2731) UnhandledPromiseRejectionWarning: FetchError: request to https://discordapp.com/api/v7/channels/653307272004632623/messages failed, reason: getaddrinfo EAI_AGAIN discordapp.com
Aug 12 18:49:13 masterpi npm[2731]:     at RequestHandler.execute (/app/node_modules/discord.js/src/rest/RequestHandler.js:107:21)
Aug 12 18:49:13 masterpi npm[2731]:     at runMicrotasks (<anonymous>)
Aug 12 18:49:13 masterpi npm[2731]:     at processTicksAndRejections (internal/process/task_queues.js:93:5)
Aug 12 18:49:13 masterpi npm[2731]: (node:2731) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 32415)

Hrrm, that's a shame. Are you testing out the latest alpha version (v2.9.0-alpha)? If not, would you be able to try that out and see if the same issue occurs? This seems to be happening in discord.js, which is a library we rely on, but it's had quite a significant recent update, and I wonder if it might have improved the behavior around this.

It is running v2.8.1-11-g5af02c1 at the moment, is it considered 2.9 or should I git pull?

I can't actually seem to find g5af02c1 in the repo (is that a Git commit?), so I'm not sure if you're on a more recent version than the release, but 2.8.1 was 41f8444d17b2b282c437b5f871f0252968c03525, and the main relevant change for 2.9.0-alpha happened in f047ce0224d0bf5bb769659c8015ed7371879d94 - at the end of the v2.8.1...v2.9.0-alpha comparison.

My bad, I should have git log before posting.  g5af02c1 = git shorthash when you remove the leading g.  Git log shows that this short hash is "Add 2.9.0-alpha to CHANGELOG" 5af02c16c60ba53586a733237face76eed017da0

I almost forgot about this ticket and when I checked again, surprise!  The service crashed a couple time but systemd restarted it as expected.
With strict mode enabled, here is the log that is spit out before crashing:
Sep 10 12:57:43 masterpi node[27874]: 2020-09-10T16:57:43.620Z info: Connected to Discord
Sep 10 12:57:44 masterpi node[27874]: 2020-09-10T16:57:44.669Z info: Connected to IRC
Sep 10 12:57:44 masterpi node[27874]: 2020-09-10T16:57:44.737Z info: Connected to IRC
Sep 10 12:57:53 masterpi node[27874]: 2020-09-10T16:57:53.724Z info: Connected to Discord
Sep 14 17:17:46 masterpi node[27874]: 2020-09-14T21:17:46.664Z error: Received error event from IRC {
Sep 14 17:17:46 masterpi node[27874]:   prefix: 'wolfe.freenode.net',
Sep 14 17:17:46 masterpi node[27874]:   server: 'wolfe.freenode.net',
Sep 14 17:17:46 masterpi node[27874]:   command: 'err_notregistered',
Sep 14 17:17:46 masterpi node[27874]:   rawCommand: '451',
Sep 14 17:17:46 masterpi node[27874]:   commandType: 'error',
Sep 14 17:17:46 masterpi node[27874]:   args: [ '*', 'You have not registered' ]
Sep 14 17:17:46 masterpi node[27874]: }
Sep 14 17:17:49 masterpi node[27874]: 2020-09-14T21:17:49.855Z info: Connected to IRC
Sep 14 17:17:57 masterpi node[27874]: 2020-09-14T21:17:57.987Z info: Connected to IRC
Sep 14 17:24:42 masterpi node[27874]: 2020-09-14T21:24:42.989Z info: Connected to IRC
Sep 14 20:20:46 masterpi node[27874]: 2020-09-15T00:20:46.050Z error: Received error event from IRC {
Sep 14 20:20:46 masterpi node[27874]:   prefix: 'card.freenode.net',
Sep 14 20:20:46 masterpi node[27874]:   server: 'card.freenode.net',
Sep 14 20:20:46 masterpi node[27874]:   command: 'err_cannotsendtochan',
Sep 14 20:20:46 masterpi node[27874]:   rawCommand: '404',
Sep 14 20:20:46 masterpi node[27874]:   commandType: 'error',
Sep 14 20:20:46 masterpi node[27874]:   args: [ 'TiCPU_', '#btrfs', 'Cannot send to nick/channel' ]
Sep 14 20:20:46 masterpi node[27874]: }
Sep 14 20:32:35 masterpi node[27874]: /app/node_modules/discord.js/src/rest/RequestHandler.js:158
Sep 14 20:32:35 masterpi node[27874]:           new HTTPError(res.statusText, res.constructor.name, res.status, item.request.method, request.path),
Sep 14 20:32:35 masterpi node[27874]:           ^
Sep 14 20:32:35 masterpi node[27874]: Response: Internal Server Error
Sep 14 20:32:35 masterpi node[27874]:     at RequestHandler.execute (/app/node_modules/discord.js/src/rest/RequestHandler.js:158:11)
Sep 14 20:32:35 masterpi node[27874]:     at runMicrotasks (<anonymous>)
Sep 14 20:32:35 masterpi node[27874]:     at processTicksAndRejections (internal/process/task_queues.js:93:5) {
Sep 14 20:32:35 masterpi node[27874]:   code: 500,
Sep 14 20:32:35 masterpi node[27874]:   method: 'post',
Sep 14 20:32:35 masterpi node[27874]:   path: '/channels/653307177762553881/messages'
Sep 14 20:32:35 masterpi node[27874]: }
Sep 14 20:32:35 masterpi systemd[1]: discord-irc.service: Main process exited, code=exited, status=1/FAILURE
Sep 14 20:32:35 masterpi systemd[1]: discord-irc.service: Failed with result 'exit-code'.
Sep 14 20:32:35 masterpi systemd[1]: discord-irc.service: Consumed 4min 43.594s CPU time.
Sep 14 20:32:45 masterpi systemd[1]: discord-irc.service: Scheduled restart job, restart counter is at 1.
Sep 14 20:32:45 masterpi systemd[1]: Stopped Discord to IRC bridge.
Sep 14 20:32:45 masterpi systemd[1]: discord-irc.service: Consumed 4min 43.594s CPU time.
Sep 14 20:32:45 masterpi systemd[1]: Started Discord to IRC bridge.

Based on that log, it looks like something went wrong internally in Discord, since it returned an Internal Server Error?
The upstream discord.js provides a retryLimit option for 500-error requests, which looks targeted at this. I'll try adding a retry limit of 3 (rather than the default of 1), and then cut a beta, to see if that helps out!

From my point of view, this issue is fixed, when the retries can't handle it, the only way to fix 500 errors is wait for the platform to heal itself and restart.  So, having the service manager handle the restart does it for me.


[OHIF-313] - Sync measurement panel label updates to cornerstoneTools

This PR adds a handler for cornerstoneTools that updates annotation labels upon an update to the measurement service annotation representation.
I had to add a field to MeasurementService.update's emitted event data called notYetUpdatedAtSource, to prevent circular updates if the measurement service fires an update to listeners when cornerstone was the source of the update itself.
Edit: This also solved OHIF-271 & OHIF-275

Included in #1955.


Refactor css for better variable usage

I noticed the font-stack and while changing that I think I managed to improve a couple of other small things in the sass as well.

Thanks 👍


Reverse the measurements display

#64 Fix for the Measurements display reverse issue.

#63 Fix for Hiding add button on compass modal toggled on. Commit id : 0f32c631bd55e42db1b7a4a1e882b2554c843b91

#65  Polygon vertex addition, immediately available for edit, instead of a short press commit id :
065fc0e28b0765f3bb6002b8ebeb2036181ce436


Praveen Science

Due we close new issues on PR merge and voting is still possible on closed issues I will close this one.


⚠ Samsung has degraded performance

In 2b98cf1, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2714 ms

Resolved: Samsung performance has improved in 3e81e20.


CIP-0100? | Governance Metadata

This CIP is the second draft for a standard surrounding any "metadata" attached to the activities that users engage in during governance.
The first draft, along with comments left by some members of the Cardano community, can be found here:
https://gist.github.com/Quantumplation/56ef2ffccb05f5d2974fd17240dc406c
A recording of the workshop held to solicit feedback that went into this second draft can be found here:
https://www.youtube.com/watch?v=TnPJ11Po04s
There are some <!-- inline comments --> with notes from various workshops, if you're curious, but that aren't relevant to the main CIP.
There are some open questions in the form of task lists that I could use some help answering.
Rendered

@Quantumplation this is up for introduction at today's CIP Editors' Meeting at 4PM UTC; it would be nice if you could be there, though not planning on a detailed review at the meeting (https://hackmd.io/@cip-editors/70).
I was expecting more community feedback about this, especially with the Forum introduction, but without any dispute I'm going to recommend this be given a CIP number so hopefully it can march forward into wider review.

@rphair I won't be able to make it exactly at 4pm UTC, as that's when we have standup, but I can join 10-15 minutes later!

The bulk of the discussion in the CIP editors meeting was focused around the motivations for this proposal, how to handle versioning, and how much to specify here vs other proposals.
The main takeaway was that this defines a very basic MVG of properties, which are shared by all types of governance actions; and how a subsequent draft of this will probably limit it to just those properties, and leave extensions up to other CIPs.

Below is a list of fields I think we should include in Governance Action metadata (assuming they come from discussions happening off-chain).
[GA = Governance Action]
These can be included and expand the already proposed 'Justification' field:

Title > this provides initial context about the GA and it should make it easier (both off-chain and on-chain) to differentiate and identify GAs
Summary / abstract > this provides the initial overview of the problem/reason related to the submission of the GA allowing anyone (especially voters) to understand the context behind the GA
Motivation / Problem > this should detail the problem / motivation that is driving the GA
Rational > this reinforce the Motivation / Problem and should expand on the proposed solution (AKA provide context on the actual GA. Ex. 'So I propose to change parameter X to Y)
Supporting Links > This allows the proposer to add extra relevant information about themselves as proposers, or about the proposal itself (for example to add links to other discussions or evaluations or audits ...)

@gitmachtl

Is there a fields-list yet for dRep registration?

Not yet -- any ideas? 🤓

@gitmachtl

Is there a fields-list yet for dRep registration?

Not yet -- any ideas? 🤓

hmm...  maybe something general like:
{
  "id": "drepid again",
  "about": {
    "name": "full name",
    "image": "url to an image, http(s)/ipfs",
    "desc": "a short description about the drep",
    "link": "url to a website, etc",
    "tags": "separated tags to describe the purpose of the drep",
    "location": "country/town where the drep is located"
  },
  "contact": {
    "email"<EMAIL_ADDRESS>    "twitter": "mytwitterhandle",
    "x": "mytwitterhandle",
    "telegram": "mytelegramhandle",
    "facebook": "",
    "youtube": "",
    "twitch": "",
    "discord": "",
    "github": "",
    "patreon": "",
    "linkedin": "",
    "adahandle": "$myadahandle"
  }
}

not sure what was discussed in the workshops about being a drep.

@Quantumplation recording from CIP meeting today that we're looking forward to documentation of your workshop feedback and waiting for your planned changes in response.  Personally I'm looking forward to the details of URL interaction as per CIP-0013. 👍 cc @scarmuega

@Quantumplation we decided to put this at Last Check today & merge no later than the next meeting.
I do believe you should incorporate @Ryun1's https://github.com/cardano-foundation/CIPs/pull/556#discussion_r1403376949 or equivalent language before merge, so this section doesn't cause ambiguities later.

@rphair when is the next call? I can prise to have the final draft up by then

@Quantumplation here you are on the agenda again 🤩 Tuesday 12th December 2023 (4PM UTC)

@Ryun1 @rphair Pushed a final draft ahead of the Tuesday meeting; I think this is in a really good place now, with an example context, example document, etc.
I also folded in your suggestion, @Ryun1, to rename "justification" to "comment".
It's a lot of little pieces swimming, so I'm sure something is misaligned / unclear somewhere, but I think that can be corrected with a follow up PR when it's discovered.


Add compliance overwrite when fips is enabled

What does this PR do?
Overwrite compliance_config.endpoints.* when fips is enabled

Motivation

compliance_config.endpoints.* in security agent which are both available in GovCloud, so they must be handled by the Agent config when fips.enabled is true.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Run the Agent with fips.enabled: true and get the config with datadog-agent config.
In the config verify that the following values are correctly overwritten:
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

It looks good to me, but please fix the conflicts and add release notes. Thanks.


Added Love Babbar DSA Sheet

Hey,
Love Babbar DSA sheet is a must for students preparing for placement in college.
Kindly Merge the PR

Please add it to the readme as well.

@aaryan2134 Done. I have updated Readme too.

The index link is not pointing to the section.
Also, as you have added a google drive link there is no need to create a directory for the sheets

Ok, I am updating in CS Resources Directory

I have updated Readme. You can view and merge the PR

If you are contributing for hacktoberfest you need to add atleast 5 resources. Check out the contributing guidelines for more details.
If you are not doing it for hacktoberfest then let me know

Are you still working on this?


[Feature request]: Add PS5 by passing the IP

Is your feature request related to a problem? Please describe
My PS5 is not being discovered in my network setup (/23 network, no VLANs)
Describe the solution you'd like
Additional field in configuration to set an IP address.
playactor should be used with this IP e.g. playactor check --ip <IP_ADDRESS>
Describe alternatives you've considered
Any alternative to use my PS5 without being found by playactor browse
Additional context
See https://github.com/FunkeyFlo/ps5-mqtt/issues/164

second this, I have multiple vlans, and assigning broadcast address is not helping (likely due to complex isolation rules in my network setup)
so would be much easier to just tell the plugin where the PS5 is by IP (since it's static) and avoid having to add firewall rules / broadcast address changes, etc ...

This is still needed

still needed

Still needed

Still needed

++

May we have this, please?

Also very much interested in being able to directly target a DDNS hostname or at least the IP. Browsing does not work across networks, and setting the broadcast address doesn't help if the HA host is not actually in the network we would like to scan.

+1 for this please !


feat(tree): Schema validation

Description
Builds on top of https://github.com/microsoft/FluidFramework/pull/20904, to enable content being inserted into a shared tree to be validated against the stored schema of the tree.
Reviewer Guidance
The review process is outlined on this wiki page.
I first tried putting the flag that defines if schema validation should happen or not just in TreeConfiguration but some code paths didn't seem to have good access to it. It felt natural to make it part of the policy.

@noencke new changes in; basically moved the new enableSchemaValidation to a property bag passed to new TreeConfiguration() which required adding ITreeConfigurationOptions to the public API (cc @microsoft/fluid-cr-api). Not sure if this will matter much as https://github.com/microsoft/FluidFramework/pull/20815 moves forward since it might end up replacing schematize() and have its own API shape (could reuse the new interface, maybe with a new name).


latest-tag-button, default-branch-button and list-prs-for-file are not fast/reliable enough

Visit https://github.com/sindresorhus/refined-github/blob/42dfa16cd5366de26b475de94f8225003df07364/source/features/list-prs-for-file.tsx (or any file with an open PR)
Refresh the page
Wait for each button to appear, if ever

These are 3 separate features but they affect the same area. I think they should be reviewed to understand why they're so slow and why latest-tag-button sometimes doesn't appear at all.
default-branch-button is the most annoying one because it's a simple feature with data that's easily available, it should be instant.

Debugged default-branch-button
If we move this
https://github.com/sindresorhus/refined-github/blob/017c17b36565186d87edb7618d781b0e87b206f3/source/features/default-branch-button.tsx#L19-L19
Before this
https://github.com/sindresorhus/refined-github/blob/017c17b36565186d87edb7618d781b0e87b206f3/source/features/default-branch-button.tsx#L13-L13
There is almost no jump at all. (not perfect but better then before)

Makes sense! Any API calls should appear before elementReady, or else we definitely wait too long.

Here's an error:
refined-github.js:5657 ❌ Refined GitHub → latest-tag-button → TypeError: Cannot read property 'parentElement' of null
    at init (refined-github.js:6078)
    at async runFeature (refined-github.js:5697)
    at async setupPageLoad (refined-github.js:5710)

It can't find #branch-select-menu. It happened on the root of a fork:
https://github.com/fregante/refined-github


Extend the Plugin API to allow clients to easily disable selected plugins

The hawtio-online Discover plugin would like to be able to disable the connect plugin. At the moment, the following workaround has to be executed:
 for (const plugin of hawtio.getPlugins()) {
    if (plugin.id === 'connect') {
      log.debug('Disabling connect plugin')
      plugin.isActive = async () => {
        return false
      }
    }
  }

see: https://github.com/hawtio/hawtio-online/blob/main/packages/online-shell/src/bootstrap.tsx#L17-L24
This is a bit of a hack and an easier API could be provided.
reference: https://github.com/hawtio/hawtio-online/pull/244#pullrequestreview-1772235968

@phantomjinx Probably this #788 fixes the issue as well. So, with the fix now you can select what plugins to use for hawtio online:
// Bootstrap Hawtio
//registerPlugins()

// You can also select which builtin plugins to load
connect()
jmx()
camel()

Do you think we can close this with the fix?

Fixed by #788.


Final revisions on all schemas

This is strongly based on all the checkpoints in #86. titles were not added as was concluded in https://github.com/HumanBrainProject/openMINDS_core/issues/131.
_instruction (formerly description) has been updated to be more of an instruction message. It follows the logic:

non-references (e.g. string, array not pointing to other schema) --> "Enter STUFF."
references to other schemas, expecting single object --> "Add STUFF."
references to other schemas, allowing an array of object --> "Add one or several STUFF."
special cases, e.g. electrodeArray that expects at least 2 objects for electrodes were adjusted to reflect that --> "Add two or more STUFF." (in that case)

Additional updates:

unit doesn't point to a controlledTerm anymore but to the openMINDS schema quanitativeValues.schema.json (described in https://github.com/HumanBrainProject/openMINDS_core/issues/99)
unit was removed from image.schema.json; instead voxelSize is now pointing to quanitativeValues.schema.json where the value and the unit can be defined
NOTE: For image this was straight forward and made more sense (especially because we have discussed this before, but did not have the quantitaiveValue.schema.json yet). The other schema that uses unit is coordinateSpace, which I'd like to discuss. We could do something similar here too by turning origin into a reference to quantitaiveValue.schema.json. Would we like to do this? If so, the origin could be defined with a combination fo different units, that would also be the units for the axes. Do we want that?

Side-note: This PR is quite large and it might be good if both @skoehnen and @lzehl could review it. @olinux feel free to have a look as well ;)

The other schema that uses unit is coordinateSpace, which I'd like to discuss. We could do something similar here too by turning origin into a reference to quantitaiveValue.schema.json. Would we like to do this? If so, the origin could be defined with a combination fo different units, that would also be the units for the axes. Do we want that?

May I ask why origin is affected by the changes to unit?
As far as I can see origin asks for a point defined by 2(or 3) coordinates, so why would it be affected by the shift from controlledTerm  to the openMINDS schema quanitativeValues.schema.json.
What is the argument for defining origin with a combination of different units compared to a coordinate point?
If I've misunderstood something basic (which might be the case here), my appoligies and please enlighten me.

The other schema that uses unit is coordinateSpace, which I'd like to discuss. We could do something similar here too by turning origin into a reference to quantitaiveValue.schema.json. Would we like to do this? If so, the origin could be defined with a combination fo different units, that would also be the units for the axes. Do we want that?

May I ask why origin is affected by the changes to unit?
As far as I can see origin asks for a point defined by 2(or 3) coordinates, so why would it be affected by the shift from controlledTerm to the openMINDS schema quanitativeValues.schema.json.
What is the argument for defining origin with a combination of different units compared to a coordinate point?
If I've misunderstood something basic (which might be the case here), my appoligies and please enlighten me.

I would suggest in general throughout all schemas to use the quantitativeValue schema to define "number+unit".
In case of origin, we could even go further and say (as @aeidi89 is pointing out as well) this should point to a coordinatePoint which should use quanitatitveValues to define x, y, and z.
In case of coordinateSpace, the property unit defines the native unit (of the smallest step?) that should be used for that space. The origin could be stated then in different units, but when displayed within the space they need to use the unit native to the space.

Discussion with @lzehl: All 2D/3D properties as array with "minItems": 2 and "maxItems": 3. EXCEPT for anatomicalOrientation, which is always 3D (because anatomical orientations are always 3D even when coorindate space only shows 2 of the 3 dimensions).


Replace sequences with statement

Adds the sequence modules as discussed in #33
It works with standalone sequences, in if statements and return statements:
return k[e] || (k[e] = 0), k[e]++, k[e] >= i;
// -->
if (!k[e]) {
  k[e] = 0;
}
k[e]++;
return k[e] >= i;

Only thing I couldn't figure out is how to deal with the top level where it does this:
x();
(a(), b());
// -->
x();
{
  a();
  b();
}

If the Program node would get marked for replacement to insert the statements, it results in [-] Nothing was deobfuscated

Another good addition :)
Regarding the Program node issue, I don't think there's anything wrong with
x();
{
  a();
  b();
}

in the context of this module.
This should be normalized as part of the consolidateNestedBlockStatements where any block statement placed within the program's body should be dissolved. That would take care of this problem but I don't think it should be done in this scope.
One thing I do think that should be changed is the name:
replaceSequencesWithStatements should be replaceSequencesWithExpressions since that's what it's doing.