/run/xtables.lock file missing after upgrading to stable 3033.2.0

Description
After rebooting to Flatcar stable 3033.2.0, /run/xtables.lock file is no longer present on the host due to iptables upgrade to use nftables backend.
Impact
In my case, I run kubelet in a Docker container, so I have to bind-mount /run/xtables.lock from host into kubelet container to avoid concurrent modification of iptables rules. Because of this and lack of this file after the reboot, Kubernetes node failed to come back after a reboot. Fortunately FLUO did not proceed with upgrading next nodes.
Workaround
The issue can be at least temporarily workaround by executing the following commands before the reboot for upgrade:
sudo mkdir -p /etc/systemd/system/docker.service.d

cat <<EOF | sudo tee /etc/systemd/system/docker.service.d/override.conf
[Unit]
Requries=systemd-tmpfiles-setup.service
After=systemd-tmpfiles-setup.service
EOF

cat << EOF | sudo tee /etc/tmpfiles.d/xtables-workaround.conf
f       /run/xtables.lock       0755    root    root    -       -
EOF

Additional information
Opening mainly for documentation purposes requested by @t-lo.

Thanks, we should keep shipping this file as long as we can assume that common containers still ship binaries that interact with xtables and should add your systemd tmpfile directive to the image.

The workaround is backported to the 3033 and 3066 release maintenance branches and future Stable, Beta, and Alpha releases will have it.

@invidian weird indeed. xtables.lock is created by systemd-tmpfiles maybe systemd-tmpfiles-setup.service took some time to start (because of dependencies):
$ systemctl show --property=After systemd-tmpfiles-setup
After=systemd-journald.socket setup-nsswitch.service system.slice systemd-journald.service systemd-sysusers.service systemd-journal-flush.service local-fs.target

I think everything is fine, sorry for the noise. kube-proxy was not starting because of some other reason and the warning keeps showing up and this is because of my setup, where kubelet simply don't have access to /run/xtables.lock as it runs inside the container.


Problem dynamically inserting paper elements

Hi,
I'm having problems when dynamically inserting paper elements in HTML in Dart.
I am knew with dart and polymer, maybe this isn't the forum to post it...., or it's so an easy question that nobody else needed to post it...
I have to add content dynamically to my page, because it depends on users input, so I can't use template-repeat.
When I try the code in Dartium, it works perfectly,but with another browser like IE or Firefox, paper elementes injected are simply ignored.
A simple example of what I mean....
template
<paper-action-dialog id="dialog" backdrop autoCloseDisabled layered="false">

xxxxxxxxx

  <paper-button affirmative autofocus>Tap me to close</paper-button>
</paper-action-dialog>

dart code
PaperActionDialog get dialog => $['dialog'];
When something happens...
dialog.appendHTML('');
dialog.toggle();
I hope someone could help me....
Thanks in advance
Best Regards

Is what I append to dialog.appendHTML

Issues here in the GitHub repo are for bug reports.
SO is a good place for questions or https://groups.google.com/a/dartlang.org/forum/#!forum/web
See https://www.dartlang.org/support/ for more options.
The Slack channel is monitored most of the time.
I guess what you want to do is

http://stackoverflow.com/questions/20474071
and maybe http://stackoverflow.com/questions/25962986

Thank you very much, I'm going to try as soon as possible.
Still I can't understand very well why I have to use "new Element.tag" in order to inject a paper-element inside HTML for IE and Firefox and it works without it in Dartium... It's not a new polymer element I'm creating, is a core polymer element....

The default sanitizer used by appendHtml no longer allows custom element tags, are you seeing any errors in the console?

Well, jakemac53, My first aproach was showing a warning in the console:
Removing disallowed element
but I didn' t saw it, ups....
zoechi,
Element papercheckbox = new Element.tag("paper-checkbox");
tdResultado.append(papercheckbox);
Worked for me, thank you very much.
It also worked for me:
PaperCheckbox pc = new PaperCheckbox();
tdResultado.append(pc);


TerminateOnNaN epoch level callback

epoch frequency support for TerminateOnNaN callback.
Batch level hook fails when used with distributed strategies, as logs is not of type dict (tensorflow.python.distribute.coordinator.values.RemoteValueImpl)

fixed formatting issue

Thanks for the PR! Can you add a test to make sure the newly added paths are covered and the test is passing?

added tests and they are passing.

@hertschuh @rchao
anything else needed here?

Looking at original issue,

Batch level hook fails when used with distributed strategies, as logs is not of type dict (tensorflow.python.distribute.coordinator.values.RemoteValueImpl)

why not use RemoveValue.get to convert removevalue to concrete one in batch hook? Why can't Parameter server/other distributed strategies not support batch level terminate on nan?

Looking at original issue,

Batch level hook fails when used with distributed strategies, as logs is not of type dict (tensorflow.python.distribute.coordinator.values.RemoteValueImpl)

why not use RemoveValue.get to convert removevalue to concrete one in batch hook? Why can't Parameter server/other distributed strategies not support batch level terminate on nan?

I can include this as well, but calling .get() on remote value comes with sync cost and can slow down distributed training.

Yes but that is controllable by check_freq. If you use check_freq of 1 and call .get() every batch then training will probably become slow. If you use check_freq of 100-1000 batches then it’s more likely sync effect will be minor. Exact impact will depend a lot on your model/dataset but you can adjust it to minimize performance impact.

@rchao @hertschuh
anything remaining?

Hi @abinthomasonline Can you please check @rchao's comments and keep us posted ? Thank you!

@gbaned @rchao Updated.
Sorry, I missed the updates on this thread.

Update: pradeepkuppla@ is helping with some internal testing, and we'll circle back once we have more updates.

@rchao , this is failing TAP test with below error.
Is it something actionable from user side?
third_party/py/keras/api/tests/api_compatibility_test.py", [line 293](https://cs.corp.google.com/piper///depot/google3/third_party/py/keras/api/tests/api_compatibility_test.py?l=293&ws=tap-presubmit-server/54210978&snapshot=2), in _AssertProtoDictEquals
    self.fail(
AssertionError: 1 differences found between API and golden.

@rchao , this is failing TAP test with below error. Is it something actionable from user side?
third_party/py/keras/api/tests/api_compatibility_test.py", [line 293](https://cs.corp.google.com/piper///depot/google3/third_party/py/keras/api/tests/api_compatibility_test.py?l=293&ws=tap-presubmit-server/54210978&snapshot=2), in _AssertProtoDictEquals
    self.fail(
AssertionError: 1 differences found between API and golden.

@abinthomasonline can you check if following the instruction here helps with resolving this?

Hi @abinthomasonline Any update on this PR? Please. Thank you!

Hello, Thank you for submitting a pull request.
We're currently in the process of migrating the new Keras 3 code base from keras-team/keras-core to keras-team/keras.
Consequently, merging this PR is not possible at the moment. After the migration is successfully completed, feel free to reopen this PR at keras-team/keras if you believe it remains relevant to the Keras 3 code base. If instead this PR fixes a bug or security issue in legacy tf.keras, you can instead reopen the PR at keras-team/tf-keras, which hosts the TensorFlow-only, legacy version of Keras.


Fix: transcode coroutine didn't run if longer than 1 frame

Child coroutines can't be started this way; they need to be started with StartCoroutine or manually progressed from the parent coroutine.

Thanks @hybridherbst  for this contribution!
I didn't have time to check/merge right away and in the meantime I've switched to async, rendering this PR obsolete.
If you feel like testing it, let me know if the current main branch works for you.
Thanks!

Thanks @hybridherbst  for this contribution!
I didn't have time to check/merge right away and in the meantime I've switched to async, rendering this PR obsolete.
If you feel like testing it, let me know if the current main branch works for you.
Thanks!


Improve the getting started docs

Adds an introductory few paragraphs to docs/index page to explain the value proposition of Read the Docs. The goal here is to answer the "Why Read the Docs" question.
Breaks the getting started guide into 3 docs

getting started with Sphinx
getting started with MkDocs (this is brand new)
importing your documentation

In the getting started with X guides, I briefly explain the benefits/trade-offs of using Sphinx/MkDocs
Puts "connecting your account" (to GitHub, Bitbucket, GitLab) into a separate doc rather than in the getting started guide. This won't be as necessary going forward as more people choose to sign up with GitHub, etc.
In the toctree, moves:

the "about Read the Docs" section below "Feature documentation"
puts the "Design" section into the developer documentation

After merging
Create a redirect in the Read the Docs project dashboard for the "docs" project from getting-started.html -> intro/getting-started-with-sphinx.html.
Notes
I would like to put full sentence/paragraph descriptions on different sections (eg. User documentation, Feature documentation, About Read the Docs, etc.), but there isn't a great way to do this. I still think we should do it to explain the differences between those various sections. Currently the best path I have for that is similar to what I did with "First steps" which is to make the toctree hidden and then also have duplicate links to the documents.
What are peoples' thoughts on having more screenshots in our docs? I put one in the import guide but I could easily create a lot more. I think especially in getting started guides, these are very reassuring and show people they are doing the right thing in the right place.
Fixes #4648

Shouldn't we mention the configuration part here? Like using a configuration file or the web admin.

I think that's a great idea.
Where do you think it should go? Perhaps just a sentence or two in "Importing Your Documentation >> Building your documentation" and it links to the Yaml config docs?
I also think the Yaml config docs should be linked from the builds docs.

I also think the Yaml config docs should be linked from the builds docs.

Definitely, that's a good place

Where do you think it should go? Perhaps just a sentence or two in "Importing Your Documentation >> Building your documentation" and it links to the Yaml config docs?

That's a good question p: not sure, maybe it makes sense on an early step? Looks like an intermediate step between creating the documentation and importing/building it on rtd.

If you don't have a strong opinion, I lean toward putting it in "Importing Your Documentation >> Building your documentation". I think that because many projects (especially simple ones) won't need it and I want to keep the getting started guide short and simple.

2018年9月29日 07:36於 "Santos Gallegos"<EMAIL_ADDRESS>
I also think the Yaml config docs should be linked from the builds docs.
Definitely, that's a good place
Where do you think it should go? Perhaps just a sentence or two in
"Importing Your Documentation >> Building your documentation" and it links
to the Yaml config docs?
That's a good question p: not sure, maybe it makes sense on an early step?
Looks like an intermediate step between creating the documentation and
importing/building it on rtd.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rtfd/readthedocs.org/pull/4676#issuecomment-425594297,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZ510P5mRLHbWm0Q7cRn1Q6eumpv693gks5ufrKOgaJpZM4XALPy
.

I linked to the Yaml config on "Importing Your Documentation". The builds page needs a bit more work and is a little out of scope for this PR. I created https://github.com/rtfd/readthedocs.org/issues/4679 to handle it.

I like screenshots. We don't have a great way of managing them, but I'm +1 on having them, especially in tutorial/intro docs.

I added screenshots. I moved the images around (under _static) and re-enabled html_static_path so that I could create hyperlinks to the images themselves.

The lint errors are due to search stuff, not these docs.


coco-p1 training divergent

I tried to reproduce results under coco-p1 configuration, but training divergent after 40k steps and I got only 14% mAP which is far lower than  19.64%. Could you help me, please

Training with such small amout of supervision is sensitive to hyper-parameters, please try batch 8 and logits weight 3

just corrected the config in latest commit

Thanks for the reply, I will try the latest code

I just tried the latest config, and I add IMS_PER_DEVICE=1 to avoid the below assert.
def adjust_config(cfg):     base_world_size = int(cfg.SOLVER.IMS_PER_BATCH / cfg.SOLVER.IMS_PER_DEVICE)     # Batchsize, learning rate and max_iter in original config is used for 8 GPUs     assert base_world_size == 8, "IMS_PER_BATCH/DEVICE in config file is used for 8 GPUs"
But the training still diverged after about 40k steps. I got higher result 16% mAP, but it's still much lower than 19.64%. I notice that coco-p1 don't use multiple-scale training, will that influence the final result?

Indeed... Thanks for correction, I'll fix it. The multi-scale training would affect performance a lot, please use SUPERVISED=(WeakAug,dict(short_edge_length=(640, 672, 704, 736, 768, 800), max_size=1333, sample_style="choice")),

Thanks for your reply. I get 18.49 mAP now, but it's still 1 point lower than the score presented in paper(19.64±0.34). Can this fluctuation in the result be considered normal?
Besides, I noticed that both the student model and the teacher model are evaluated twice, but I can't find where the problem is. This problem can be reproduced with the latest code, could you please help?

seems its close, our curve looks like this:

We make the model evaluate both teacher and student every 2k, and we report the performance of the teacher

Thanks for your detailed reply! In my situation, the inference is carried out 4 times every 2k iter, not 2 times. Both the teacher and student models are evaluated twice which is bizarre. I didn't modify the code, could you reproduce this problem with the official code?

Thanks for your detailed reply! In my situation, the inference is carried out 4 times every 2k iter, not 2 times. Both the teacher and student models are evaluated twice which is bizarre. I didn't modify the code, could you reproduce this problem with the official code?

I aslo have same situation！

Thanks for your detailed reply! In my situation, the inference is carried out 4 times every 2k iter, not 2 times. Both the teacher and student models are evaluated twice which is bizarre. I didn't modify the code, could you reproduce this problem with the official code?

I also have same situation!


Update he.md

If you are creating a PR about PETs, please go the the Preview tab and select the pet-template:

Signature
Distance Calculation
Secure Multi-party Computation

Hi, thanks for your contribution. Can you add two spaces for the first two lines of each entry? For example:
- *Jean-Philippe Aumasson, Adrian Hamelink, and Omer Shlomovits,*[add-space][add-space]
  [A Survey of ECDSA Threshold Signing](https://eprint.iacr.org/2020/1390)[add-space][add-space]
  Cryptology ePrint Archive, 2020


Access denied error when building from source

Following the instructions in the build from source WIki on a Win10 machine. Running restore completes with no errors. Running build generates the following 4 errors.
Build FAILED.

ALINK : error AL1078: Error signing assembly -- Access is denied. [C:\Users\scott\repos\AspNetCore\src\Middleware\Localization\sample\LocalizationSample.csproj]
ALINK : error AL1078: Error signing assembly -- Access is denied. [C:\Users\scott\repos\AspNetCore\src\Middleware\Localization\testassets\LocalizationWebsite\LocalizationWebsite.csproj]
ALINK : error AL1078: Error signing assembly -- Access is denied. [C:\Users\scott\repos\AspNetCore\src\Mvc\test\WebSites\RazorPagesWebSite\RazorPagesWebSite.csproj]
ALINK : error AL1078: Error signing assembly -- Access is denied. [C:\Users\scott\repos\AspNetCore\src\Components\test\testassets\BasicTestApp\BasicTestApp.csproj]
    0 Warning(s)
    4 Error(s)

Digging into the logs, I can see al.exe running with the following command line for the first error:
C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.7.2 Tools\al.exe
  /culture:es-ES /delaysign-
  /keyfile:C:\Users\scott\.nuget\packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.19574.1\tools\snk/AspNetCore.snk
  /out:C:\Users\scott\repos\AspNetCore\artifacts\obj\LocalizationSample\Debug\netcoreapp5.0\es-ES\LocalizationSample.resources.dll
 /template:C:\Users\scott\repos\AspNetCore\artifacts\obj\LocalizationSample\Debug\netcoreapp5.0\LocalizationSample.dll
 /embed:C:\Users\scott\repos\AspNetCore\artifacts\obj\LocalizationSample\Debug\netcoreapp5.0\LocalizationSample.My.Resources.Startup.es-ES.resources

With the sysinternals tools, I can see the ACCESS DENIED error popping up when al.exe tries to create a file: C:\ProgramData\Microsoft\Crypto\RSA\MachineKeys\eecbfdd95d7ed9110d5942eb026463f1_7990d07d-81f1-4e2e-a733-048b6f7c81bc.

There's a workaround listed here: https://github.com/dotnet/corefx/issues/3784#issuecomment-404795417. Since this issue isn't specific to AspNetCore, we'll use the other issue to track addressing it.

The proposed workaround is to give yourself Full Control over the MachineKeys folder. MachineKeys is the folder where private keys from all users and system processes appear, so the proposed work around is dangerously wrong.
The MachineKeys folder requires special permissions as I have documented here: https://odetocode.com/blogs/scott/archive/2020/01/12/solving-access-denied-in-crypto-machine-keys.aspx


Configuring build versions

Once again, I apologize if what's really going on here is that I'm confused about how gradle works.
I'm trying to integrate into a project that already has a build script for other tasks. For historical reasons, there are two properties, acmeMajorVersion and acmeMinorVersion that are used to track the product version (instead of the version property). For better or worse, that's the way it is and I'm hoping I don't have to try to fix that globally.
I tried:
build {
  version = "${acmeMajorVersion}.${acmeMinorVersion}.0"
  packageVersion = "${acmeMajorVersion}.${acmeMinorVersion}.0"
}

And that didn't work. I tried setting things in various places (settings.gradle, gradle.properties, etc.) to no avail. Thoroughly confused, I thought I'd start with what is documented as working:
build {
  version = project.version
  packageVersion = project.version
}

But that doesn't work either:
* Where:
Build file '/Volumes/Acme/src/acme/acmedev/build.gradle' line: 120

* What went wrong:
A problem occurred evaluating root project 'Saxon'.
> Cannot get property 'version' on null object

What's really odd is that if I put a print statement before the dotnet configuration block:
println("${project.acmeMajorVersion}, ${acmeMajorVersion}, ${project.version}")

that prints "11, 11, unspecified" before the failure.
Is there some way that I can get the values I want inserted into the build script?

Hi, can you check with --stacktrace in your gradle command to verify where does the null pointer coming from?
it could be a bug in the plugin but you might also try setting project.version by acmeMajorVersion and acmeMajorVersion as well

I'll try to get a stack trace asap. I just started another build and they take a while.
I'm thinking, because of #18, that I might end up having to run the dotnet commands in an Exec task.

Sorry I dropped the ball on this. Focus was on getting a release out and I think I just worked around it.


fixing redirect

There was an error while validating job 50bb0099-a5dd-40d2-889c-1194885944c9 Message:
Result status: Failed
There was a problem accessing Github repository 'https://github.com/Microsoft/cordova-docs.git'.
Details:Microsoft.LightweightJobEngine.Core.Language.ContextCommandBase+ContextCommandException:
Result status: Failed
There was a problem accessing Github repository 'https://github.com/Microsoft/cordova-docs.git'.
---> System.AggregateException: One or more errors occurred. ---> System.ArgumentException: Error clonning repository ---> LibGit2Sharp.NotFoundException: Branch 239 not found. Available branches: origin/master
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.GetBranch(Repository repo, String name)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.<>c__DisplayClass30.<>c__DisplayClass34.b__29(KeyValuePair2 branch)    at System.Collections.Generic.List1.ForEach(Action1 action)    at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.<>c__DisplayClass30.<CloneRepository>b__28()    at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.<>c__DisplayClass1.<ExecuteAction>b__0()    at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.ExecuteAction[TResult](Func1 func)
at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.ExecuteAction(Action action)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository(String url, IDictionary2 branches)    --- End of inner exception stack trace ---    at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository(String url, IDictionary2 branches)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository()
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.GetVersionAsync(String path)
at Microsoft.DPS.Commands.IdentifyDocumentsToPublish.CheckExternalServicesCommand.Do(IDictionary2 context)    --- End of inner exception stack trace ---    --- End of inner exception stack trace ---    at Microsoft.LightweightJobEngine.Core.Language.ContextCommandBase.ThrowIfErrorsLogged()    at Microsoft.DPS.Commands.IdentifyDocumentsToPublish.CheckExternalServicesCommand.Do(IDictionary2 context)
at Microsoft.LightweightJobEngine.Core.Language.JobWorkflow1.RunCommands(Guid jobId, IDictionary2 context, CancellationTokenSource cancelSignal)


[tool_crash] UnsupportedError: Unsupported operation: Illegal character in path: ihttps:

Command
flutter --quiet assemble --no-version-check --depfile D:\Final Project\blood_donor\build\app\intermediates\flutter\debug/flutter_build.d --output D:\Final Project\blood_donor\build\app\intermediates\flutter\debug -dTargetFile=D:\Final Project\blood_donor\lib\main.dart -dTargetPlatform=android -dBuildMode=debug -dTrackWidgetCreation=true --DartDefines=RkxVVFRFUl9XRUJfQVVUT19ERVRFQ1Q9dHJ1ZQ==,RkxVVFRFUl9XRUJfQ0FOVkFTS0lUX1VSTD1odHRwczovL3d3dy5nc3RhdGljLmNvbS9mbHV0dGVyLWNhbnZhc2tpdC8wNDgxN2M5OWM5ZmQ0OTU2ZjI3NTA1MjA0ZjdlMzQ0MzM1ODEwYWVkLw== -dFlavor= -dAndroidArchs=android-x86 -dMinSdkVersion=19 -dIsAndroidLibrary=false debug_android_application

Steps to Reproduce

...
...
...

Logs
UnsupportedError: Unsupported operation: Illegal character in path: ihttps:
#0      _Uri._checkWindowsPathReservedCharacters (dart:core/uri.dart:1840:11)
#1      _Uri._toWindowsFilePath (dart:core/uri.dart:2893:7)
#2      _Uri.toFilePath (dart:core/uri.dart:2865:38)
#3      ManifestAssetBundle._parseAssetsFromFolder (package:flutter_tools/src/asset.dart:916:29)
#4      ManifestAssetBundle._parseAssets (package:flutter_tools/src/asset.dart:817:9)
#5      ManifestAssetBundle.build (package:flutter_tools/src/asset.dart:267:54)
<asynchronous suspension>
#6      copyAssets (package:flutter_tools/src/build_system/targets/assets.dart:57:26)
<asynchronous suspension>
#7      AndroidAssetBundle.build (package:flutter_tools/src/build_system/targets/android.dart:66:34)
<asynchronous suspension>
#8      _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:861:9)
<asynchronous suspension>
#9      FlutterBuildSystem.build (package:flutter_tools/src/build_system/build_system.dart:628:16)
<asynchronous suspension>
#10     AssembleCommand.runCommand (package:flutter_tools/src/commands/assemble.dart:318:32)
<asynchronous suspension>
#11     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1389:27)
<asynchronous suspension>
#12     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#13     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#14     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:355:9)
<asynchronous suspension>

[✓] Flutter (Channel stable, 3.19.2, on Microsoft Windows [Version 10.0.19045.4046], locale en-US)
    • Flutter version 3.19.2 on channel stable at C:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (6 days ago), 2024-02-27 16:51:22 -0500
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\hp\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.9.2)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.9.34622.214
    • Windows 10 SDK version 10.0.22621.0

[✓] Android Studio (version 2023.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874)

[✓] VS Code (version 1.87.0)
    • VS Code at C:\Users\hp\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.84.0

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)       • windows       • windows-x64    • Microsoft Windows [Version 10.0.19045.4046]
    • Chrome (web)            • chrome        • web-javascript • Google Chrome 122.0.6261.95
    • Edge (web)              • edge          • web-javascript • Microsoft Edge 122.0.2365.66

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: false
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: 78666c8dc57e9f7548ca9f8dd0740fbf0c658dc9

@AnuradaMishel
Can you check if there are any invalid chars in assets or in pubspec.yaml file ?
Couple of similar issues were fixed recently which may not be in stable yet, but should be available in latest master version:
https://github.com/flutter/flutter/issues/141211
https://github.com/flutter/flutter/issues/140092
Can you switch to latest master and run your scenario again to see if the same exception occurs or not ?


Proposal: TabViewItem's CloseButton & TabView's AddButton should have dedicated theme resources

Proposal: TabViewItem's CloseButton & TabView's AddButton should have dedicated theme resources
Summary
If you currently try to change the foreground of the TabViewItem's Close button, the easiest way to do so is to use lightweight styling by overriding the TabViewButtonForeground theme resource. See the following XAML:
<muxc:TabView>
    <muxc:TabView.Resources>
        <SolidColorBrush x:Key="TabViewButtonForeground" Color="Red" />
    </muxc:TabView.Resources>
    <muxc:TabView.TabItems>
        <muxc:TabViewItem Header="Tab 1">
            <muxc:TabViewItem.IconSource>
                <muxc:SymbolIconSource Symbol="Home" />
            </muxc:TabViewItem.IconSource>
        </muxc:TabViewItem>
        <muxc:TabViewItem Header="Tab 2">
            <muxc:TabViewItem.IconSource>
                <muxc:SymbolIconSource Symbol="Emoji" />
            </muxc:TabViewItem.IconSource>
        </muxc:TabViewItem>
    </muxc:TabView.TabItems>
</muxc:TabView>

this creates the following TabView result:

Notice how not only the TabViewItem's Close button has changed its foreground but also the TabView's Add button! In other words, it is currently not possible to independently style the (foreground) color of the close button (this applies to the close button's background as well) using lightweight styling.
This proposal aims to split up the current TabViewButton* theme resources into specific theme resources for the TabViewItem's Close button and the TabView's Add button (as these are the only instances in the in-box tab control where they are used):
TabViewItem's Close button:
TabViewItemCloseButtonBackground"
TabViewItemCloseButtonBackgroundPressed"
TabViewItemCloseButtonBackgroundPointerOver"
TabViewItemCloseButtonBackgroundDisabled"
TabViewItemCloseButtonBackgroundActiveTab"
TabViewItemCloseButtonForeground"
TabViewItemCloseButtonForegroundPressed"
TabViewItemCloseButtonForegroundPointerOver"
TabViewItemCloseButtonForegroundDisabled"
TabViewItemCloseButtonForegroundActiveTab"

TabView's Add button:
TabViewAddButtonBackground"
TabViewAddButtonBackgroundPressed"
TabViewAddButtonBackgroundPointerOver"
TabViewAddButtonBackgroundDisabled"
TabViewAddButtonForeground"
TabViewAddButtonForegroundPressed"
TabViewAddButtonForegroundPointerOver"
TabViewAddButtonForegroundDisabled"

Rationale
Gives customers more design flexibility by enabling them to independently style the TabView's Add button and the TabViewItem's Close button.
Additional Context
TabView's scrolling buttons can currently be lightweight styled using the specific RepeatButton theme resources such as RepeatButtonForeground. It seems reasonable to add specific TabView resources for these buttons too, such as TabViewScrollButtonForeground. This would give us the benefit of further decoupling TabView's lightweight styling feature from the TabView's implementation (where these scroll buttons are currently implemented as RepeatButton's) and thus make it more future-proof.
This could either be tracked in its own issue or added to this one if this suggestion is accepted by the team.

I think seperating the resources that the components point to makes sense.  @stmoy and @teaP fyi

+1 - agree with @StephenLPeters that having dedicated resources makes sense.


Incompatibility with Jacoco XML report

Dear Ryanluker,
it seems that your plugin is incompatible with the XML created by Jacoco for Java Code Coverage.
Here is the error:
[1534934414978][coverageservice]: LOADING
[1534934415364][coverageservice]: Loading 1 file(s)
[1534934415406][lcovparser][cobertura-parse]: Error: Cannot read property 'packages' of undefined
[1534934415406][lcovparser][cobertura-parse]: Stacktrace: TypeError: Cannot read property 'packages' of undefined
	at unpackage (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/cobertura-parse/source/index.js:71:29)
	at /Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/cobertura-parse/source/index.js:134:22
	at Parser.<anonymous> (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/xml2js/lib/parser.js:303:18)
	at emitOne (events.js:116:13)
	at Parser.emit (events.js:211:7)
	at SAXParser.onclosetag (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/xml2js/lib/parser.js:261:26)
	at emit (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/sax/lib/sax.js:624:35)
	at emitNode (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/sax/lib/sax.js:629:5)
	at closeTag (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/sax/lib/sax.js:889:7)
	at SAXParser.write (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/sax/lib/sax.js:1436:13)
	at Parser.exports.Parser.Parser.parseString (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/xml2js/lib/parser.js:322:31)
	at Parser.parseString (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/xml2js/lib/parser.js:5:59)
	at exports.parseString (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/xml2js/lib/parser.js:354:19)
	at Object.parse.parseContent (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/node_modules/cobertura-parse/source/index.js:127:5)
	at Promise (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/out/src/lcovparser.js:52:35)
	at new WrappedPromise (/Users/fox/.vscode/extensions/vscjava.vscode-maven-0.10.0/node_modules/async-listener/es6-wrapped-promise.js:13:18)
	at LcovParser.xmlExtractCobertura (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/out/src/lcovparser.js:50:16)
	at LcovParser.<anonymous> (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/out/src/lcovparser.js:38:43)
	at Generator.next (<anonymous>)
	at /Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/out/src/lcovparser.js:7:71
	at new WrappedPromise (/Users/fox/.vscode/extensions/vscjava.vscode-maven-0.10.0/node_modules/async-listener/es6-wrapped-promise.js:13:18)
	at __awaiter (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/out/src/lcovparser.js:3:12)
	at LcovParser.filesToSections (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/out/src/lcovparser.js:25:16)
	at CoverageService.<anonymous> (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/out/src/coverageservice.js:68:60)
	at Generator.next (<anonymous>)
	at fulfilled (/Users/fox/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.1.1/out/src/coverageservice.js:4:58)
	at propagateAslWrapper (/Users/fox/.vscode/extensions/vscjava.vscode-maven-0.10.0/node_modules/async-listener/index.js:502:23)
	at /Users/fox/.vscode/extensions/vscjava.vscode-maven-0.10.0/node_modules/async-listener/glue.js:188:31
	at /Users/fox/.vscode/extensions/vscjava.vscode-maven-0.10.0/node_modules/async-listener/index.js:539:70
	at /Users/fox/.vscode/extensions/vscjava.vscode-maven-0.10.0/node_modules/async-listener/glue.js:188:31
	at <anonymous>
[1534934415406][coverageservice]: Caching 0 coverage(s)
[1534934415406][coverageservice]: READY
[1534934415406][coverageservice]: RENDERING
[1534934415406][coverageservice]: READY

I attached the file for you.
Regards,
S.
cov.xml.zip

@foxpluto thanks for submitting an issue! It is rather easy to add another parser https://github.com/ryanluker/vscode-coverage-gutters/commit/50ea4fea491d9b69a8ee46143b6df1ab80d5ceb3 as long as we can figure out the structure of the xml to use in the conditional logic flow. I see that you provided the xml as well so that will make this much easier :nerd_face:. I will take a look at this when I do the next release (2.2.0) or someone else can try to tackle it before then by looking at the other parser integrations.

@foxpluto completed this in #165 and it should go out in the 2.2.0 release (~ a couple days or so).

Wow!
That's great!
Thanks a lot.
Regards,
Stefano
Il Dom 9 Set 2018, 21:47 Ryan Luker<EMAIL_ADDRESS>ha scritto:

Closed #163
https://github.com/ryanluker/vscode-coverage-gutters/issues/163.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ryanluker/vscode-coverage-gutters/issues/163#event-1834712013,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZAkxceD2jm4I2GgvK4Pcwpvzc2-sY85ks5uZXBkgaJpZM4WHa4J
.


Heart Rate Estimation

Do we have a chance to get heart rate values instead of pulse prediction and resp prediction?
Or if it is convertable, how we can do that?

You can detect peaks from PPG and calculate HR from it. I have forked this repo and add heart rate functionality to it. Check here

You can detect peaks from PPG and calculate HR from it. I have forked this repo and add heart rate functionality to it. Check here

I examined your additions. I guess you're getting just one average heart rate value but what we need is frame level or second level heart rate values. Do you have any comment on this?

First its not feasible to get on frame level, and second I did not get what is meant by second level heart rate values.
The reason why frame level is not possible is that, even doctor wait for 30 seconds or 60 seconds to count pulse. Even If we try to capture heart rate via ECG, then we have to wait some seconds to capture enough R-R peaks.
The only solution is to capture frame by frame is that, first get some frame and display HR, then keep on adding frame and until the value of HR get stable. But still this is not frame by frame. But it displays the result of last x seconds on a particular frame. Hopefully I am clear.

Thanks for explanation. I think you are right about the frame level issue.
About "second level heart rate values", actually i meant getting heart rate value for every second because there are some real time rPPG applications. Therefore we thought that the prediction can be made for every second of the video.
The reason for asking that question was single heart rate value for a video doesn't meet our needs, we need a set of values.
Finally, we thought that we can convert the pulse predictions into heart rates by specifying a window size -such as 150 frames- and taking the mean of these values, after that shifting the window by some seconds. This solution gives a set of heart rate values.

Yes, sliding window is the option, i am working on it. I will update, once I implemented it

You guys can also refer to here about how to calcuate HR.

You guys can also refer to here about how to calculate HR.

Hello, did you test this? I get really wrong results with it. Got 60 bpm when the ground truth is 110! Do we need to adjust inference preprocess to cut facial ROI?

@rhaizer , You need to check if the cropping is correct. You don't need to do a perfect facial cropping because the network has an attention layer, but you need to make sure the your frame contains your face.

@rhaizer , You need to check if the cropping is correct. You don't need to do a perfect facial cropping because the network has an attention layer, but you need to make sure the your frame contains your face.

Thanks for the quick response. Did you test this on your own webcam videos other than the datasets? How was the result? Even though I'm sure all the frames contains the face I get really bad results. Does it need certain frame count for the video or any random length video input is acceptable. Or  maybe there are some error on HR calculation. I will continue to try to make it work.

i am surprized that your results are so incorrect. i have tested this repo and results are not that bad. I created a streamlit app. Can you check this repo, it provide a colab notebook. You have to run that notebook, and it will create a url via ngrok. you can open that url in your mobile etc
https://github.com/talhaanwarch/streamlit-rPPG-app

i am surprized that your results are so incorrect. i have tested this repo and results are not that bad. I created a streamlit app. Can you check this repo, it provide a colab notebook. You have to run that notebook, and it will create a url via ngrok. you can open that url in your mobile etc https://github.com/talhaanwarch/streamlit-rPPG-app

I just tried it but got the following error:
https://github.com/talhaanwarch/streamlit-rPPG-app/issues/1

I have the same problem of @rhaizer with the code of @talhaanwarch  mentioned here: https://github.com/talhaanwarch/streamlit-rPPG-app/issues/2 but all my videos gives an output but always so high heart rate (e.g. ground truth = 65, but inference = 120 app). I attach a couple of photos of this. My videos are UHD and 60 fps. Do you have any s

uggestions to solve the inferences. I thank you in advance.

Yes, sliding window is the option, i am working on it. I will update, once I implemented it

@talhaanwarch have you finished the implementation of sliding window?

Please move to https://github.com/ubicomplab/rPPG-Toolbox
We added support there.
Thanks!


Stepper doesn't work in colorzone or in Dialogs(MaterialDesignDialogHost)

Unfortunatly the stepper foreground and when hovering the hover-color are not corectly set when the stepper is inside a colorzone from MaterialDesignInXamlToolkit:

Something simmilar happens when the stepper is inside a materialDesign-Dialog and the App is set to dark (the dialog is always in light mode):

It seems that the stepper is somehow always using the application colors.

@speedyalibaba There is a quite easy trick for your special requirements: Reference the theme with the desired colors inside your Stepper control.
<controls:Stepper>
    <controls:Stepper.Resources>
        <ResourceDictionary>
            <ResourceDictionary.MergedDictionaries>
                <ResourceDictionary Source="pack://application:,,,/MaterialDesignExtensions;component/Themes/MaterialDesignDarkTheme.xaml" />
                 <!-- or -->
                 <!--<ResourceDictionary Source="pack://application:,,,/MaterialDesignExtensions;component/Themes/MaterialDesignDarkTheme.xaml" />-->
            </ResourceDictionary.MergedDictionaries>
        </ResourceDictionary>
    </controls:Stepper.Resources>
</controls:Stepper>

@spiegelp Thank you very much. Helped me a lot :)


Hot reload not working on latest flutter beta on vs code auto save

Steps to Reproduce

create default example app in vs code
change any strings or wrap any widget to auto save in vs code
no hot reload happen
Intended Behavior: Auto save and hot reload

Logs

Logs

dup https://github.com/flutter/flutter/issues/75456

Hi @Shreemanarjun
Please check out https://github.com/flutter/flutter/issues/75456#issuecomment-773724721
Closing as duplicate of https://github.com/flutter/flutter/issues/75456
For issues/proposals for VS Code Flutter Extension, file issue on their repository.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Local level register's renewal condition seems incorrect

Checklist

[x] Did you specify the current behavior?
[x] Did you specify the expected behavior?
[x] Did you provide a code example showing the problem?
[x] Did you describe your environment?
[ ] Did you specify relevant external information?

What is the current behavior?
Below firrtl code, I expect that r1 register in when block is renewed into v only when en0 and en1 are true.
However, in emitted verilog code, register's renewal condition only look at en1 and ignore en0.
circuit LocalReg:
  module LocalReg:
    input clk: Clock
    input rst: UInt<1>
    input en0: UInt<1>
    input en1: UInt<1>
    input v: UInt<8>

    output out: UInt<8>

    out is invalid
    when en0:
      reg r1: UInt<8>, clk with: (reset => (rst, UInt<8>(0)))
      out <= r1
      when en1:
        r1 <= v

module LocalReg(
  input        clk,
  input        rst,
  input        en0,
  input        en1,
  input  [7:0] v,
  output [7:0] out
);

<various initialization section>

  always @(posedge clk) begin
    if (rst) begin
      r1 <= 8'h0;
    end else if (en1) begin
      r1 <= v;
    end
  end
endmodule

What is the expected behavior?
Above verilog code, I think second condition in always block should be en0 & en1, not en1.
On the other hand, I also think reset condition should keep current emitted result (i.e. not en0 & rst).
Your environment

firrtl version: 1.3.2
OS: Linux soya 5.4.0-42-generic ~18.04.1-Ubuntu SMP Fri Jul 10 07:21:24 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

External Information

This is the intended behavior
The semantics of both Chisel and FIRRTL are that connections are only predicated by conditions between the declaration and the connection.
See section 5.10.2 of the FIRRTL spec: https://github.com/freechipsproject/firrtl/blob/d7a3741909edb72cda2b768e2f8fae4f3c2fd6e2/spec/spec.pdf
The semantics follow from the thought experiment: what does it mean for the declaration of a register to be conditional?
Obviously, we can't make the register only exist when the condition is true, but the implication from the user is that the register only matters when the condition is true. Semantically, you can't access the register outside the scope within which it was defined, so in general the effect should not be observable.


Data Merge failures

Hi @abelardopardo, first of all, thanks for all your work on this fantastic tool! Instructors on our campus are piloting it and giving us lots of positive feedback. I'm hoping you (or someone else) could help us track down a bug that's been super annoying and a real blocker to us promoting OnTask to more users on our campus.
Bug: System Error on merging data
Steps to reproduce:
- Super simple case

Create a new workflow and import in raw2.csv in the attached testcases.zip file
In the Table Tab, under the Manage table data button, click "Upload or merge data"
Load in the same file (raw2.csv), skipping nothing.
Select Student number as the column to merge on
Select "Option 4" in the last question (Can also reproduce error with Option 3 selected).
Hit Finish twice, and you'll be greeted with a system error (which doesn't show up in the logs)

- Slightly more advanced case
Repeat steps above, but use raw2.csv as the original file, and the raw2_times100.csv. The only difference in this file and raw2, is that Col2 is multiplied by 100.
If you could let us know if you can reproduce this issue or not, that might give us some clues as to what's going on.
Thanks a lot!
testcases.zip

Hi. Thanks for the commens and for submitting the bug. A fix should be ready soon. Which version are you using?

I'm working on the same team as @andrew-gardener and @craigdsthompson over at UBC (https://github.com/ubc/ontask_b). We have moved to 3.0.1 in our testing environment but not yet in production.
The three bugs I reported (#97, #98, #99) are reproducible on v3.0.1 as well as 2.8.3.
FYI: Due to institution policies we aren't able to use emails for sending messages so have added some changes on top of each release in order to send messages through Canvas (#78). I've been told that we don't yet have resources to clean up our additions and push to the main codebase yet as we're in a pilot phase.
Thanks for agreeing to fix; I think the plan is that once this bug has been fixed, we'll apply it on our fork as well and push to production (even if it's not a full release) as the workarounds are quite time consuming.

Release B.3.0.3 now fixes these three issues.


[Mesos] Limit the default number of libprocess worker threads for executors to 8.

This limitation improves performance and memory consumption on hosts with large number of cores.
Schedulers running custom executors can still override this value by providing it in their executor definition.

Test failure was flaky tests.
Would it make sense to set this on the mesos agent as a whole at the very least, as well as potentially marathon and metronome? Seems like they'd all have this same thing, not a great deal of benefit to running with a ton of libprocess worker threads (Even the master seems like it wouldn't actually gain much more parallelism for the most part).

🚢 . Discussed offline with @jmlvanre some. We'll look into setting it more places in the next release


Update Github repo processes for expired PATs

Issue
Since you're meant to set relatively short expiry of your PATs, and the current process for kgit clone uses the HTTPS clone method. The problem exists where the PAT used - which is embedded in the original clone command may have expired - effectively expiring the Git pull and fetch commands, which means the kgit clone and sync commands will also fail - and if you have a large number of repositories cloned using the expired PAT, then the clone from list process is effectively broken.
Potential fixes

You could auto-update the remote using the GITHUB_AUTH_TOKEN required to be stored in the env (and trust that this has been updated with the new PAT. git remote set-url origin <origin embedded with new PAT>
You could investigate whether to switch to SSH access (even if this is frowned on by Micro$oft !!

So .. when you add the new PAT as the "password" for the old PAT - it works - but doesn't change url for the remote origin ...
I'm not sure how that works - but that DOES fix the problem ... Just need to be aware of it.
Not sure if you want to add that to the help instructions.. but we can close this issue.


Release_0.81.1

Pull Request Description
Enhancements
Fixes

Fixed bug related to pypi release github action failing #4330
Fixed bug related to conda build github action #4335 #4337, #4338, #4340

Changes
Documentation Changes

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

No linked issues found. Please add the corresponding issues in the pull request description.  Use GitHub automation to close the issue when a PR is merged


Alexa SampleApp v.1.1.0 - Unable to play any TuneIn station

Good day everyone,
I am testing the Alexa client aligned to v.1.1.0 release. During my test session I am able to successfully ask questions to Alexa, but when it comes to ask Alexa to play a station from TuneIn (tap to talk, and then ask "Play the station The Legend" e.g.) I hear "The legend from TuneIn" but then no sound comes out. I tested almost 30 radios, without getting the chance of being able to play any of them.
I attach to this ticket the log acquired from the SampleApp test session with DEBUG9 level.
Having a quick look, the only errors I noticed in the log when asking for a TuneIn station is about some missing fields in the JSon.
Thanks indeed for your support
alexaClientLog_20171012_165453.log

Hi Longynus83,
Has this worked for you previously?  The logs look ok, and the missing JSON fields don't prevent the AudioPlayer from attempting to render the url.  TuneIn provides urls from within their own network, and I believe we have seen issues before where some of those urls were not accessible to some customers.
If this always breaks for you, then we can investigate further.

Hi @dhpp,
Thanks for your feedback. Yesterday, after posting the  issue I tried again several times (most likely 40-50 radios) and I succeeded only once with one of the radios that did not worked previuosly.
Additionally, using the same account and credential with the javaclient with one of the radios that was not working with C++ agent, It succeeded at first attempt.
The strange thing is that right after asking for the TuneIn radio, the agent react as if immediately after the radio audio would be played and, after this, nothing happens (that is different from other scenarios where the "...radio is currently unavailable" text is played).

Hi All,
any hint on this?
Thanks indeed

Good day everyone,
is anybody having a look/investigating the issue that I reported?
Could you please provide an update on this?
Thanks indeed

Have you tried doing the news flash briefing? I get the alexa words of what service I picked then when the actual content comes I get nothing.

@ryan-esty Same behavior on my side, I mean, for the flash news. At the time being I am unable to get TuneIn as well as flash news, and I tested flash news in the past without problems...this is why I opened this issue.
Regards

@Longynus83 same as me this worked in the past and now is broken. I even had iheartradio working and now it doesn't. I had to make changes to get my stuff to work in my environment but if others are having issues I'm guessing it isn't those changes.

@dhpp Do you think it is possible to mark this issue for investigation on your side, as based on what @ryan-esty reported it seems like I am not the only one that is facing issued with C++ SDK features like this.
My apologize for the direct mention in this post, but I am really looking forward to the next SDK update to get this issue hopefully fixed.
Thanks and Regards

@Longynus83 I was able to back down to 1.0.2 and one change that I put in that could of broke the later build is using alsasink. I'm trying to use pulsesink now and see if I can get it working. Not sure if you tried using alsasink in MediaPlayer or not.

@Longynus83 Same behavior on myside for news as well.
@dhpp Is this being worked on or do you think if there is any setup issue on our side? Can you suggest any changes we can try?

@krishnaswamyna  did it break when you went from 1.0.2 to 1.1.0 or did it never work? I'm still using 1.0.2 and this feature seems to work with only pulseaudio but I can't say for certain. I had to change the code for my project as autoaudiosink doesn't work for me. It seems others have 1.1.0 working with the news services and streaming so I don't think something broke.

I was using the TuneIn radio with acceptable success ratio of getting a radio played with previous versions of the SDK (the last I remember is v.1.0.3, but I cannot give it for 100% sure...much better to rely on v.1.0.2).
After upgrading to v.1.1.0 I get the 100% of failure ratio trying to play a TuneIn radio, so there must be something that resulted in this feature to be broken. Please, be aware that I am not saying that this is necessarily an issue in the Alexa SDK, as it can also be a compatibility issue with all the linked libraries for example.
At least I am not the only one facing such issue, so this should help in root-causing this issue.
Regards

Thanks for the details.  We are looking into it.   Are all TuneIn channels not working, or is it a few specific ones?

@bandkenamazoncom when I upgraded to 1.1.0 even the news flash briefing didn't work and I think that is true for others in this thread.

Additionally, using same credential that I am currently using in Alexa C++ SDK in the javaclient is resulting in different behavior: the javaclient works like a charm with TuneIn radio using the same credentials for getting the refresh token, so most likely is not something related to the account itself.
@bandkenamazoncom In my case all TuneIn channels either return "XXX is currently unavailable" or in the strangest scenario right after asking for the TuneIn radio, the agent react as if immediately after the radio audio would be played (saying "here is XXX from TuneIn" or something like this) and, after this, nothing happens...

There are a number of deadlocks in MediaPlayer that we are fixing in the next release, and it looks like this is one of those.  Please stay tuned!

@ryan-esty I tried directly on v1.1.0 and flash briefing did not work. It speaks out the source and after that there is no audio. I did not try on any previous release. But yes i could try on v1.0.3.
I will also wait for next release as mentioned by @bandkenamazoncom

All I upgraded to 1.2 and my streaming issues went away. Thanks avs-team.

@ryan-esty I still got no chance of trying the new release, but as per your feedback I am looking forward to this new drop...


Peer only allowed 1 swap-in per app launch

This PR fixes 2 separate (but related) bugs.
Bug 1:
Previously, the Peer was structured like this:
launch {
  swapInWallet.walletStateFlow
    .filter { it.consistent }
    .fold(false) { swapAlreadyAttempted, wallet ->
        if (wallet.confirmedBalance > 10_000.sat) {
          if (swapAlreadyAttempted) {
            // swap-in already attempted: not doing anything
          } else {
            // send command RequestChannelOpen ...
          }
          true // ^fold
        } else {
          // balance insufficient: waiting for more
          swapAlreadyAttempted // ^fold
        }
    }
}

The end result is that the Dual-Funding flow is only initiated once per app launch. Because once the swapAlreadyAttempted flag is set, it is never un-set.
Bug 2:
In PR #396, we fixed a bug related to the confirmed vs unconfirmed balance. We noted that:

initiating the Dual-Funding flow with unconfirmed inputs would ultimately fail, with the server sending a TxAbort message

And although we no longer start the Dual-Funding flow until the confirmedBalance is sufficient, we still use the FULL set of utxos, regardless of whether or not these are confirmed or unconfirmed.
For example, in WaitForAcceptChannel:
val fundingContributions = FundingContributions.create(fundingParams, init.wallet.utxos) // <- ALL utxos

If the user is attempting to move funds into Phoenix, there may be a mixture of confirmed vs unconfirmed utxos. And although we wait until confirmedBalance is sufficient, this doesn't guarantee there aren't any unconfirmed utxos in the set.
Proposed solution
First we expose the confirmedUtxos in ElectrumMiniWallet:
val confirmedUtxos: List<Utxo> = utxos.filter { it.blockHeight > 0L }
val unconfirmedUtxos: List<Utxo> = utxos.filter { it.blockHeight == 0L }

And use only confirmedUtxos when appropriate:
val fundingContributions = FundingContributions.create(fundingParams, init.wallet.confirmedUtxos)

Next we fix the Peer with the following logic:

when we start a swap-in, what we want to do is reserve a set of utxos for the dual-funding flow
we keep track of this reserved Set<Utxo>, and exclude them from consideration when calculating the balance

So it looks like this:
launch {
  swapInWallet.walletStateFlow
    .filter { it.consistent }
    .fold(setOf<WalletState.Utxo>()) { reservedUtxos, wallet ->
      // reservedUtxos are part of a previously issued RequestChannelOpen command
      val availableWallet = wallet.drop(reservedUtxos)
      val balance = availableWallet.confirmedBalance
      if (balance > 10_000.sat) {
        logger.info { "$balance available on swap-in wallet: requesting channel" }
        input.send(RequestChannelOpen(uuid, availableWallet, other, params))
        reservedUtxos + availableWallet.confirmedUtxos // ^fold
      } else {
        logger.info { "$balance available on swap-in wallet but amount insufficient: waiting for more" }
        reservedUtxos.intersect(wallet.utxos) // drop items from reservedUtxos that are no longer in wallet
      }
    }
}

So by calling wallet.drop(reservedUtxos) we're creating a WalletState subset. Which we then pass to RequestChannelOpen ensuring that it will only use what we've newly reserved for it.
And the reservedUtxos doesn't grow forever, as we drop items as they get removed from the wallet. I.e. when we spend those Utxos.

Nit, that we could fix in this pass:

15:19:42.980 INFO  Peer - 0 sat available on swap-in wallet but amount insufficient: waiting for more

We're close to merging #391, we should be able to merge this and #395 early next week

This can now be merged.


[vm, service] Dump complete gc roots.

Incomplete gc roots causes many objects to be placed in the uncollected garbage when load the Snapshot file.

/cc @rmacnak-google

Gerrit CR in https://dart-review.googlesource.com/c/sdk/+/163361

According to the Gerrit CL, these changes have been applied in a different commit.


multicluster-operators-subscription image does not have git installed

When using Kustomize it's possible to point to git repos in order to get the base files.
eg: https://github.com/mvazquezc/acm-testing/blob/stage/apps/reversewords/kustomization.yaml#L3
When the App Manager tries to run the kustomization it fails with the following error:
E0330 16:23:55.208403       1 subscriber_item.go:252] Failed to applying kustomization, error: couldn't make loader for github.com/mvazquezc/acm-testing/apps/reversewords?ref=config: no 'git' program on path: exec: "git": executable file not found in $PATH

I patched the image adding git to it, and after that, it worked as expected:
I0330 16:54:46.398444       1 event.go:255] Event(v1.ObjectReference{Kind:"Subscription", Namespace:"gitops-apps", Name:"reversewords-dev-app-subscription", UID:"b0b2b9fd-344a-4f20-b76f-7de68f8b8f81", APIVersion:"apps.open-cluster-management.io/v1", ResourceVersion:"85925", FieldPath:""}): type: 'Normal' reason: 'CreateResource' Synchronizer created resource reversewords-dev-app-subscription of gvk:apps.open-cluster-management.io/v1, Kind=Subscription
I0330 16:54:46.409408       1 subscription_controller.go:134] Standalone/Endpoint Reconciling subscription: gitops-apps/reversewords-dev-app-subscription
I0330 16:54:46.414057       1 subscriber_item.go:100] Polling on SubscriberItem reversewords-dev-app-subscription
I0330 16:54:46.414315       1 subscriber_item.go:826] Subscribing to branch: refs/heads/stage
I0330 16:54:46.427998       1 subscription_controller.go:134] Standalone/Endpoint Reconciling subscription: gitops-apps/reversewords-dev-app-subscription
I0330 16:54:47.534023       1 subscriber_item.go:223] Applying kustomization /tmp/gitops-apps/mvazquez-gitops-github/apps/reversewords/

Closed in favour of https://github.com/open-cluster-management/backlog/issues/1294


orientdb 2.0.16 exception with java 1.7

After a clean installation of orientdb 2.0.16 I get a lot of this exception when I launch the studio:
java.lang.NoSuchMethodError: java.util.Map.putIfAbsent(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
        at com.orientechnologies.common.profiler.OProfiler.updateCounter(OProfiler.java:138)
        at com.orientechnologies.orient.server.network.protocol.http.ONetworkProtocolHttpAbstract.connectionClosed(ONetworkProtocolHttpAbstract.java:655)
        at com.orientechnologies.orient.server.network.protocol.http.ONetworkProtocolHttpAbstract.execute(ONetworkProtocolHttpAbstract.java:516)
        at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:69)
java.lang.NoSuchMethodError: java.util.Map.putIfAbsent(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
        at com.orientechnologies.common.profiler.OProfiler.updateCounter(OProfiler.java:138)
        at com.orientechnologies.orient.server.network.protocol.http.ONetworkProtocolHttpAbstract.connectionClosed(ONetworkProtocolHttpAbstract.java:655)
        at com.orientechnologies.orient.server.network.protocol.http.ONetworkProtocolHttpAbstract.execute(ONetworkProtocolHttpAbstract.java:516)
        at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:69)
java.lang.NoSuchMethodError: java.util.Map.putIfAbsent(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
        at com.orientechnologies.common.profiler.OProfiler.updateCounter(OProfiler.java:138)
        at com.orientechnologies.orient.server.network.protocol.http.ONetworkProtocolHttpAbstract.connectionClosed(ONetworkProtocolHttpAbstract.java:655)
        at com.orientechnologies.orient.server.network.protocol.http.ONetworkProtocolHttpAbstract.execute(ONetworkProtocolHttpAbstract.java:516)
        at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:69)
java.lang.NoSuchMethodError: java.util.Map.putIfAbsent(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
        at com.orientechnologies.common.profiler.OProfiler.updateCounter(OProfiler.java:138)
        at com.orientechnologies.orient.server.network.protocol.http.ONetworkProtocolHttpAbstract.connectionClosed(ONetworkProtocolHttpAbstract.java:655)
        at com.orientechnologies.orient.server.network.protocol.http.ONetworkProtocolHttpAbstract.execute(ONetworkProtocolHttpAbstract.java:516)
        at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:69)

I can't reproduce it after a clean install of orientdb 2.0.15
Step to reproduce:

Untar orientdb-community-2.0.16.tar.gz(downloaded from website)
run bin/server.sh
browse the studio home page

The exception appear when the studio homepage is loading
It seems that the 2.0.16 version now require java 1.8(I'm on 1.7).

Happened the same to me. The method putIfAbsent of the Map interface has been introduced since java 1.8. So yes, I think it is no more compatible.

I've just fixed the bug on 2.1.x branch and develop. On 2.1x this is the commit: https://github.com/orientechnologies/orientdb/commit/c1b0b302f668e16b34e42b062efb67b198577a18
maybe you can cherry-pick this commit?
I think we will release a 2.1.7 ASAP

Thank you,
I've already upgraded to java 1.8.
I don't know if this need a separated issue, but I experienced some problems with the java upgrade related to my server side javascript functions.
Since java 1.8, java use nashorn instead of rhino for the javascript interpreter and there is some compatibility issue and code syntax change between both.
Maybe you could had a warning in the documentation or the upgrade note because it is not easy to figure that the java upgrade can impact the javascript functions.

Thank you for the point. We will take care to update docs about JS


Trouble with the removing of features

Hello sir,
I was trying to implement by my own a kind of Viola and Jones programm, and Iloved and adapted your function called "learn", but I'm facing a problem with the removing of features after having selecting one. For the next feature , the line  86 : " best_feature_idx = feature_indexes[min_error_idx] " will sometimes not run because the " min_error_idx " will be bigger than the length of the list... How can I fix it? And even if my indexes stay lower then the list length, is it not going to change the order of features and select a wrong one? Thanks for reading :)

Hey,
it is a bit tricky to subsequently select features while making sure that no feature is selected twice, which is why the implementation is not straight forward for that part.
Let's get an overview of the lists that are used in the code:

features is the list of actual features, it will not be changed during the whole process
feature_indexes is the list of indexes of features that we haven't selected so far, we are removing indexes from this list as we are selecting features, so that no feature can be selected twice
classification_errors holds the error for each feature that was not yet selected, it has the same length as feature_indexes

When selecting the best feature we take the index of the smallest error (np.argmin(classification_errors)). This index is not yet the feature index, but the index of the feature index. So the index of the feature with smallest error is feature_indexes[min_error_idx] and the best feature is then features[best_feature_idx].
Last but not least we have to remove the best_feature_idx from the list of feature_indexes.
In the original code classification_errors has the same length as feature_indexes (line 70: classification_errors = np.zeros(len(feature_indexes))), which means that min_error_idx as an index of classification_errors can never be out of bounds of feature_indexes.
Hope this helps resolving your issue!
Simon

Thank you very much!
I think I did not understand how important the " feature_indexes " list was, so I programmed all with features and it's initial length. Now my programm is working really better, I am very liable to you.


CLI options are deprecated. Please update README and offer alternatives if they exist.

$ curl -L https://coveralls.io/coveralls-linux.tar.gz | tar -xz -C .
$ ./coveralls --help
Coveralls Coverage Reporter v0.6.14
Usage: coveralls [command] [options]
    report                           Report coverage
    done                             Call a webhook after all parallel reports
    version                          Show version
    --debug                          Debug mode: data being sent to Coveralls will be printed to console
    --dry-run                        Dry run (no request sent)
    --no-fail                        Always exit with status 0
    -n, --no-logo                    Do not show Coveralls logo in logs
    -q, --quiet                      Suppress all output
    -h, --help                       Show this help
    -rTOKEN, --repo-token=TOKEN      Sets coveralls repo token, overrides settings in yaml or environment variable
    -cPATH, --config-path=PATH       Set the coveralls yaml config file location, will default to check '.coveralls.yml'
    -bPATH, --base-path=PATH         DEPRECATED: Path to the root folder of the project the coverage was collected in
    -fFILENAME, --file=FILENAME      DEPRECATED: Coverage artifact file to be reported, e.g. coverage/lcov.info (detected by default)
    -jFLAG, --job-flag=FLAG          DEPRECATED: Coverage job flag name, e.g. Unit Tests
    -p, --parallel                   DEPRECATED: Set the parallel flag. Requires webhook for completion (coveralls done)
    -d, --done                       DEPRECATED: Call webhook after all parallel jobs (-p) done
    --format=FORMAT                  DEPRECATED: Force coverage file format, supported formats: clover, cobertura, jacoco, golang, python, coveralls, lcov, simplecov, gcov
    --allow-empty                    DEPRECATED: Allow empty coverage results and exit 0
    --compare-ref=REF                DEPRECATED: Git branch name to compare the coverage with
    --compare-sha=SHA                DEPRECATED: Git commit SHA to compare the coverage with
    --carryforward=FLAGS             DEPRECATED: Comma-separated list of parallel job flags
    --service-name=NAME              DEPRECATED: Build service name override
    --service-job-id=ID              DEPRECATED: Build job override
    --service-build-url=URL          DEPRECATED: Build URL override
    --service-job-url=URL            DEPRECATED: Build job URL override
    --service-branch=NAME            DEPRECATED: Branch name override
    --service-pull-request=NUMBER    DEPRECATED: PR number override
    -v, --version                    DEPRECATED: Show version

I was anticipating using things like the job id and PR numbers, but I found those to be deprecated. Are there env vars to leverage instead?

@smcclure15 yes, you can find those here (linked from here in the README).


Resolve the Einstein Equations

Hello!
There is a way to resolve the Einstein equations with EinsteinPy  ?
If we consider that we have a function B(t) in the tensor, and we want to resolve the einstein equations and to determine the function B(t)

I tried to resolve :
So I want  to add up the Einstein tensor with ( the metric tensor * the cosmological constant) to create one tensor, but I have an error :
""unsupported operand type(s) for +: 'EinsteinTensor' and 'MetricTensor'   ""
Can I have some help please ?

Hi @AfnanAlsaati , can you please post some code snippet that can help recreate the issue?

Hi @shreyasbapat,
I finally resolve my problem. Here the resolution (according to me).  And I also discover that in EinsteinPy there is an Einstein tensor ! '' EinsteinTensor "

Thanks for opening the issue. As you've discovered, you can use EinsteinTensor to calculate the required terms. You can also use sympy.simplify to get further simplified expressions (when applicable). There is a short tutorial on calculating the Einstein Tensor available in EinsteinPy documentation.


new example with PIL

Changes

adds: tweet_generator.py example

Check off the following

[X] I have tested my changes with the current requirements
[X] My Code follows the pep8 code style.

Im getting this error when I run it
https://pastebin.com/NjYmLEad
Also everything should be in a subfolder and I think the resources should use _ instead of spaces in the name.

Im getting this error when I run it https://pastebin.com/NjYmLEad
Also everything should be in a subfolder and I think the resources should use _ instead of spaces in the name.

OS?

I'm on vanilla arch btw. I'm guessing the issue is os dependent cause it's an os error. I haven't found any info on what the issue is yet.

Yeah, I think it's something depending on the OS, I'm on Windows 10 and it works fine, so...

I'm 100% sure the same implementation was working less than a week ago, tested older version that drawbu sent me on discord and still have the same error

Looks like the issue is with the font file. I guess they should be replaced with new or we can just not store them on git. Thats probably the better thing to do anyway tbh so we don't need to worry about licensing.

Also, I believe we should remove the font file.
Either we add a note telling one to download the font file by themselves and location to place it
or we use different font with a better license.


Add linking API endpoints

@jugarrit @lemieux @dannytranlx @mspensieri
This adds the endpoints for
POST /appUsers/:userId/channels
DELETE /appUsers/:userId/channels/:channel

Rest looks good 👍

👍

:+1:


cjq4435: Initial implementation

This module was tested on the Grove MOSFET.
Signed-off-by: Jon Trulson<EMAIL_ADDRESS>Signed-off-by: Zion Orent<EMAIL_ADDRESS>

Thanks!  Merged and closing.


Write transferred outputs into timestamped sub-directory

To handle the use-case where we may want to transfer updated analysis outputs for a sequencing run that has already been transferred, consider writing the transferred outputs under a sub-directory that is named using a timestamp with format YYYYMMDDHHmmss

Finished testing using a dev-config.json in directories under my home folder. Feels ready to merge from my perspective. Let me know your thoughts @dfornika

Fixed in #4


SCB-317 Use CDN Servers to resolve front-end dependencies

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
 A more thorough check will be performed on your pull request automatically.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #272 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   70.33%   70.36%   +0.02%
==========================================
  Files          17       17
  Lines        3418     3418
==========================================
+ Hits         2404     2405       +1
  Misses        846      846
+ Partials      168      167       -1

Impacted Files
Coverage Δ

server/service/service_dependency.go
73.91% <0%> (+0.86%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a498a...d4b2cff. Read the comment docs.

Coverage increased (+0.1%) to 73.998% when pulling d4b2cff3587f34c5e24d4c2953eee33588e3282c on asifdxtreme:master into e9a498a5475549fe8a2b4c60d4e005b1bf0c3b00 on apache:master.

This PR removes all the bower_components which were earlier added to the code to make the development faster and also to reduce the load time of the page.
Currently all the bower_components dependencies can be resolved using CDN Servers, this will increase the load time of the page but this is the better way to handle the dependencies as server will not have overhead to send the scripts to client, all the dependencies will be directly downloaded on the client side by internet hence reducing the traffic to server.


Unable to complete the setup

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Version of Data Accelerator

Services:
DataProcessing
WebSite:

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

A clear and concise description of what the bug is.

Logged in using windows command prompt as admin
Logged into azure using az login
Updated the parameters with my tenandid and subscription id
deploy.bat always fails with this message
Note: If any module is installed, you will have to close this prompt and restart deploy.bat as admin again...
Install Module:  azuread
Install Module:  mdbc
The script execution completed after one or more packages have been installed. In order to use the latest packages, please close this prompt, open a new command prompt as admin and run deploy.bat again
Error occurred at deployresources.ps1
I tried running it again but same problem

Thanks Raj for the feedback!  We have tweaked the experience to work through these types of issues more easily by allowing newer versions of the packages to already be installed, as well as an option to skip the installation of dependency module entirely.  To ensure the scripts can update the components, also make sure to close any potential app using the Azure AAD and mdbc components (i.e. a clean reboot should help).  Thanks and looking forward to having you try the template again.


Allow to use android & iOS facetId as origin

Hey @hiepthai thanks for the PR. Is this already finished? Could you add a description and explain the changes, issues and if your change completely makes iOS & Android compatible or if other changes are needed as well?

Merged #121 instead for the same feature - thanks though!


RDM-12096: Fortify Issue 13318074 - Null Dereference

JIRA link
https://tools.hmcts.net/jira/browse/RDM-12096
Change description
Fixed NULL dereference issue
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Code cleanup moved to RDM-12121


Month picker navigation using keyboard keys not working

Describe the bug
User can not able to select month using keyboard navigation keys. Only the year can allow to change
To Reproduce
() => {
const [startDate, setStartDate] = useState(new Date());
return (
<DatePicker
selected={startDate}
onChange={date => setStartDate(date)}
dateFormat="MM/yyyy"
showMonthYearPicker
/>
);
};

Go to month input
Click on keyboard arrow keys

Expected behavior
A month should be able to select using keyboard navigation keys

Bumped into the same issue.

+1
Same problem here

+1


[main] Update community files

Cron -knative-prow-robot
/cc we don't use Prow
/assign we don't use Prow
Produced by: knative-sandbox/knobots/actions/update-community
Details:

Codecov Report

Merging #301 (c648f03) into main (4af99ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   80.65%   80.65%
=======================================
  Files          20       20
  Lines         765      765
=======================================
  Hits          617      617
  Misses        134      134
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af99ba...c648f03. Read the comment docs.


Added support for Amazon SageMaker Asynchronous Endpoints

Description
Added support for Amazon SageMaker Asynchronous Endpoints.
Issue
#6928
Dependencies
boto3, uuid
Maintainer
@hwchase17
Twitter handle
DGallitelli95
Code to test this
from typing import Dict
from langchain import PromptTemplate
from langchain.llms.sagemaker_endpoint import LLMContentHandler, SagemakerAsyncEndpoint
from langchain.chains import LLMChain

# This ContentHandler has been tested with Falcon40B Instruct from SageMaker JumpStart
class ContentHandler(LLMContentHandler):
    content_type:str = "application/json"
    accepts:str = "application/json"
    len_prompt:int = 0

    def transform_input(self, prompt: str, model_kwargs: Dict) -> bytes:
        self.len_prompt = len(prompt)
        input_str = json.dumps({"inputs": prompt, "parameters": {"max_new_tokens": 100, "do_sample": False, "repetition_penalty": 1.1}})
        return input_str.encode('utf-8')

    def transform_output(self, output: bytes) -> str:
        response_json = output.read()
        res = json.loads(response_json)
        ans = res[0]['generated_text']
        return ans

chain = LLMChain(
    llm=SagemakerAsyncEndpoint(
        input_bucket=bucket,
        input_prefix=prefix,
        endpoint_name=my_model.endpoint_name,
        region_name=sagemaker.Session().boto_region_name,
        content_handler=ContentHandler(),
    ),
    prompt=PromptTemplate(
        input_variables=["query"],
        template="{query}",
    ),
)

print(chain.run("What is the purpose of life?"))

Preparing review...

PR Analysis

🎯 Main theme: Adding support for Amazon SageMaker Asynchronous Endpoints
🔍 Description and title: Yes
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
✨ Minimal and focused: Yes

PR Feedback

💡 General PR suggestions: The PR is well-structured and follows good coding practices. However, it lacks tests for the new functionality. It would be beneficial to add tests to ensure the new code works as expected and to prevent potential regressions in the future. Additionally, consider handling exceptions more gracefully, providing more informative error messages to the user.

🤖 Code suggestions:

suggestion 1:

relevant file: sagemaker_endpoint.py
suggestion content: Consider moving the wait_inference_file function inside the SagemakerAsyncEndpoint class as a static or class method. This would improve the organization of the code and make it more object-oriented. [important]

suggestion 2:

relevant file: sagemaker_endpoint.py
suggestion content: In the wait_inference_file function, instead of using a while True loop, consider using a for loop with a maximum number of retries to avoid potential infinite loops. [important]

suggestion 3:

relevant file: sagemaker_endpoint.py
suggestion content: In the __init__ method of SagemakerAsyncEndpoint, consider validating the input arguments to ensure they are in the correct format and within expected ranges. This can help catch errors early and provide clearer error messages to the user. [medium]

suggestion 4:

relevant file: sagemaker_endpoint.py
suggestion content: In the _call method of SagemakerAsyncEndpoint, consider handling the exception when the endpoint is not running. Instead of raising a generic Exception, provide a more specific error message to the user. [medium]

🔒 Security concerns: No

Add a comment that says 'Please review' to ask for a new review after you update the PR.
Add a comment that says 'Please answer <QUESTION...>' to ask a question about this PR.

Updated PR. Please review. Commit: 703081c4dee43c5c47801c28f171f61a684038a0

Please review.

Please review

🚀 Requesting Langchain team's review and approval for this PR 🙏 to add support for Sagemaker async endpoints. Let's leverage these cost-effective endpoints for enhanced performance! 🌟💻 Thank you!

cc @3coins

@dgallitelli
Thanks for submitting this PR.
It seems like the async endpoints are specifically geared towards large payloads (1GB) and long processing times. Is this something ideal for an LLM application? I am curious about what specific use case will this integration help with?

@dgallitelli Thanks for submitting this PR. It seems like the async endpoints are specifically geared towards large payloads (1GB) and long processing times. Is this something ideal for an LLM application? I am curious about what specific use cases will this integration help with?
How does this compare with SageMaker serverless inference which might also have the cost benefits?

If I may add my comment, the integration of AWS Sagemaker async endpoints holds promise for Langchain's LLM application. The support for GPU instances in async endpoints addresses the size and complexity of LLM models, unlike Sagemaker serverless inference which is limited to CPU instances. This distinction is significant for achieving optimal performance. Moreover, the cost-effectiveness achieved through scaling down to zero during idle periods enhances the feasibility of using AWS async.

@dgallitelli Hi , could you, please, resolve the merging issues and address the last comments (if needed)? After that, ping me and I push this PR for the review. Thanks!

@dgallitelli Hi , could you, please, resolve the merging issues and address the last comments (if needed)? After that, ping me and I push this PR for the review. Thanks!

Hi @leo-gan, the latest commit has passed all checks, and we have reviewed the previously described comments. Shall we move forward with PR review?

@dgallitelli Hi, could you, please, resolve the the branch conflicts? After that ping me and I push this PR for the review. Thanks!

It tells me I don't have write access to this repository though?

Hey @dgallitelli ! Closing because the PR wouldn't line up with the current directory structure of the library (would need to be in /libs/langchain/langchain instead of /langchain). Feel free to reopen against the current head if it's still relevant!
You don't need write access on langchain-ai/langchain in order to modify your branch. If you update it and reopen without conflicts, we'd love to review it! Apologies if the Github write access message was confusing.


Sort out Darwin API changes to MTRDeviceController

There were various changes to MTRDeviceController.  We need to sort out which of those changes we might need to partially undo.

Diff of the changes:
diff --git a/src/darwin/Framework/CHIP/MTRDeviceController.h b/src/darwin/Framework/CHIP/MTRDeviceController.h
index 188cd3787..8bf5e0dcc 100644
--- a/src/darwin/Framework/CHIP/MTRDeviceController.h
+++ b/src/darwin/Framework/CHIP/MTRDeviceController.h
@@ -18,107 +18,98 @@
 #import <Foundation/Foundation.h>

 #import <Matter/MTRNOCChainIssuer.h>
-#import <Matter/MTROnboardingPayloadParser.h>

 @class MTRBaseDevice;

 NS_ASSUME_NONNULL_BEGIN

-typedef void (^MTRDeviceConnectionCallback)(MTRBaseDevice * _Nullable device, NSError * _Nullable error);
-
 @class MTRCommissioningParameters;
-@protocol MTRDevicePairingDelegate;
+@protocol MTRDeviceControllerDelegate;
+@class MTRSetupPayload;

 @interface MTRDeviceController : NSObject

-@property (readonly, nonatomic) BOOL isRunning;
+/**
+ * If true, the controller has not been shut down yet.
+ */
+@property (readonly, nonatomic, getter=isRunning) BOOL running;

 /**
- * Return the Node Id assigned to the controller.  Will return nil if the
+ * Return the Node ID assigned to the controller.  Will return nil if the
  * controller is not running (and hence does not know its node id).
  */
-@property (readonly, nonatomic, nullable) NSNumber * controllerNodeId;
+@property (readonly, nonatomic, nullable) NSNumber * controllerNodeID;

 /**
- * Start pairing for a device with the given ID, using the provided setup PIN
- * to establish a PASE connection.
+ * Set up a commissioning session for a device, using the provided setup payload
+ * to discover it and connect to it.
+ *
+ * @param payload a setup payload (probably created from a QR code or numeric
+ *                code onboarding payload).
+ * @param newNodeID the planned node id for the node.
+ * @error error indication if discovery can't start at all (e.g. because the
+ *              setup payload is invalid).
  *
  * The IP and port for the device will be discovered automatically based on the
  * provided discriminator.
  *
- * The pairing process will proceed until a PASE session is established or an
- * error occurs, then notify onPairingComplete on the MTRDevicePairingDelegate
- * for this controller.  That delegate is expected to call commissionDevice
- * after that point if it wants to commission the device.
- */
-- (BOOL)pairDevice:(uint64_t)deviceID
-     discriminator:(uint16_t)discriminator
-      setupPINCode:(uint32_t)setupPINCode
-             error:(NSError * __autoreleasing *)error;
-
-/**
- * Start pairing for a device with the given ID, using the provided IP address
- * and port to connect to the device and the provided setup PIN to establish a
- * PASE connection.
- *
- * The pairing process will proceed until a PASE session is established or an
- * error occurs, then notify onPairingComplete on the MTRDevicePairingDelegate
- * for this controller.  That delegate is expected to call commissionDevice
- * after that point if it wants to commission the device.
+ * Then a PASE session will be established with the device, unless an error
+ * occurs.  MTRDeviceControllerDelegate will be notified as follows:
+ *
+ * * Discovery fails: onStatusUpdate with MTRCommissioningStatusFailed.
+ *
+ * * Discovery succeeds but commissioning session setup fails: onPairingComplete
+ *   with an error.
+ *
+ * * Commissioning session setup succeeds: onPairingComplete with no error.
+ *
+ * Once a commissioning session is set up, deviceBeingCommissionedWithNodeID
+ * can be used to get an MTRBaseDevice and discover what sort of network
+ * credentials the device might need, and commissionNodeWithID can be used to
+ * commission the device.
  */
-- (BOOL)pairDevice:(uint64_t)deviceID
-           address:(NSString *)address
-              port:(uint16_t)port
-      setupPINCode:(uint32_t)setupPINCode
-             error:(NSError * __autoreleasing *)error;
+- (BOOL)setupCommissioningSessionWithPayload:(MTRSetupPayload *)payload
+                                   newNodeID:(NSNumber *)newNodeID
+                                       error:(NSError * __autoreleasing *)error;

 /**
- * Start pairing for a device with the given ID and onboarding payload (QR code
- * or manual setup code).  The payload will be used to discover the device and
- * establish a PASE connection.
- *
- * The pairing process will proceed until a PASE session is established or an
- * error occurs, then notify onPairingComplete on the MTRDevicePairingDelegate
- * for this controller.  That delegate is expected to call commissionDevice
- * after that point if it wants to commission the device.
+ * Commission the node with the given node ID.  The node ID must match the node
+ * ID that was used to set up the commissioning session.
  */
-- (BOOL)pairDevice:(uint64_t)deviceID onboardingPayload:(NSString *)onboardingPayload error:(NSError * __autoreleasing *)error;
-- (BOOL)commissionDevice:(uint64_t)deviceId
-     commissioningParams:(MTRCommissioningParameters *)commissioningParams
-                   error:(NSError * __autoreleasing *)error;
+- (BOOL)commissionNodeWithID:(NSNumber *)nodeID
+         commissioningParams:(MTRCommissioningParameters *)commissioningParams
+                       error:(NSError * __autoreleasing *)error;

 - (BOOL)continueCommissioningDevice:(void *)device
            ignoreAttestationFailure:(BOOL)ignoreAttestationFailure
                               error:(NSError * __autoreleasing *)error;

-- (BOOL)stopDevicePairing:(uint64_t)deviceID error:(NSError * __autoreleasing *)error;
-
-- (nullable MTRBaseDevice *)getDeviceBeingCommissioned:(uint64_t)deviceId error:(NSError * __autoreleasing *)error;
-- (BOOL)getBaseDevice:(uint64_t)deviceID
-                queue:(dispatch_queue_t)queue
-    completionHandler:(MTRDeviceConnectionCallback)completionHandler;
+/**
+ * Cancel commissioning for the given node id.  This will shut down any existing
+ * commissioning session for that node id.
+ */
+- (BOOL)cancelCommissioningForNodeID:(NSNumber *)nodeID error:(NSError * __autoreleasing *)error;

-- (BOOL)openPairingWindow:(uint64_t)deviceID duration:(NSUInteger)duration error:(NSError * __autoreleasing *)error;
-- (nullable NSString *)openPairingWindowWithPIN:(uint64_t)deviceID
-                                       duration:(NSUInteger)duration
-                                  discriminator:(NSUInteger)discriminator
-                                       setupPIN:(NSUInteger)setupPIN
-                                          error:(NSError * __autoreleasing *)error;
+/**
+ * Get an MTRBaseDevice for a commissioning session that was set up for the
+ * given node ID.  Returns nil if no such commissioning session is available.
+ */
+- (nullable MTRBaseDevice *)deviceBeingCommissionedWithNodeID:(NSNumber *)nodeID error:(NSError * __autoreleasing *)error;

 /**
- * Controllers are created via the MTRControllerFactory object.
+ * Controllers are created via the MTRDeviceControllerFactory object.
  */
 - (instancetype)init NS_UNAVAILABLE;
 + (instancetype)new NS_UNAVAILABLE;

 /**
- * Set the Delegate for the Device Pairing  as well as the Queue on which the Delegate callbacks will be triggered
+ * Set the Delegate for the device controller  as well as the Queue on which the Delegate callbacks will be triggered
  *
- * @param[in] delegate The delegate the pairing process should use
+ * @param[in] delegate The delegate the commissioning process should use
  *
  * @param[in] queue The queue on which the callbacks will be delivered
  */
-- (void)setPairingDelegate:(id<MTRDevicePairingDelegate>)delegate queue:(dispatch_queue_t)queue;
+- (void)setDeviceControllerDelegate:(id<MTRDeviceControllerDelegate>)delegate queue:(dispatch_queue_t)queue;

 /**
  * Sets this MTRDeviceController to use the given issuer for issuing operational certs. By default, the MTRDeviceController uses an
@@ -140,19 +131,27 @@ typedef void (^MTRDeviceConnectionCallback)(MTRBaseDevice * _Nullable device, NS
  * Attempts to retrieve the attestation challenge for a commissionee with the given Device ID.
  * Returns nil if given Device ID does not match an active commissionee, or if a Secure Session is not availale.
  */
-- (nullable NSData *)fetchAttestationChallengeForDeviceId:(uint64_t)deviceId;
+- (NSData * _Nullable)fetchAttestationChallengeForDeviceID:(NSNumber *)deviceID;

 /**
- * Compute a PASE verifier and passcode ID for the desired setup pincode.
+ * Compute a PASE verifier for the desired setup passcode.
+ *
+ * @param[in] setupPasscode   The desired passcode to use.
+ * @param[in] iterations      The number of iterations to use when generating the verifier.
+ * @param[in] salt            The 16-byte salt for verifier computation.
  *
- * @param[in] setupPincode    The desired PIN code to use
- * @param[in] iterations      The number of iterations to use when generating the verifier
- * @param[in] salt            The 16-byte salt for verifier computation
+ * Returns nil on errors (e.g. salt has the wrong size), otherwise the computed
+ * verifier bytes.
  */
-- (nullable NSData *)computePaseVerifier:(uint32_t)setupPincode iterations:(uint32_t)iterations salt:(NSData *)salt;
++ (nullable NSData *)computePASEVerifierForSetupPasscode:(NSNumber *)setupPasscode
+                                              iterations:(NSNumber *)iterations
+                                                    salt:(NSData *)salt
+                                                   error:(NSError * __autoreleasing *)error;

 /**
- * Shutdown the controller. Calls to shutdown after the first one are NO-OPs.
+ * Shut down the controller. Calls to shutdown after the first one are NO-OPs.
+ * This must be called, either directly or via shutting down the
+ * MTRDeviceControllerFactory, to avoid leaking the controller.
  */
 - (void)shutdown;

Dealt with in #23512


Allow application-level expression filtering of MemcachedBinaryPacket properties

Right now we can only check properties on the MemcachedBinaryOperation, but it'd nice to also be able to check aggregate values on the container packet: port, IP (source/dest), overall packet size, number of operations etc.

Update the README.md with examples of how to do helpful things when this issue is completed.


⚠ Samsung has degraded performance

In d0605d4, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 1888 ms

Resolved: Samsung performance has improved in d98b023.


Clarify guidelines for maintenance grants

MGs may only be used for small features, bug fixes and dependency upgrades.
They must be limited in duration.

We might need to clean up the readme/move parts to other readmes at some point. It’s becoming rather long.


Fix for #117 post_authenticated_signal

Hi, I think this is the fix for https://github.com/knaperek/djangosaml2/issues/117. I do not have a test server for saml and my production server runs an older version of djangosaml2 which cannot be upgraded without significant rewrites (custom user lookup function and such). Therefore i was unable to test this code.

Please write a unit test or use a idp like uniAuth or Djangosaml2idp to do your tests, I really appreciate your contribution

I'm not sure how the testing system works... I see some tests in /djangosaml2/tests/init.py and some in /djangosaml2/tests/testprofiles/tests.py
According to the github tests/checks, the login system is tested and signals are sent, so it shouldn't be too hard to add tests to see whether the signals trigger.
By the way, the other signals are not tested either if i'm correct.

Install pytest-cov and codecov
See
https://github.com/UniversitaDellaCalabria/uniAuth/blob/master/.coveragerc
Test code coverage as follow
https://github.com/UniversitaDellaCalabria/uniAuth#tests
You'll see which Lines of code are not covered by unit tests yet.
This Will let you check if your code being tested or not.
Continue on this line, you're doing a great job

Hey, i managed to add tests. Apparently the existing test for post_authenticated was not operational as well, because errors inside the signal_handler drop silently.
Now both signals are tested and it is tested whether all required attributes are present as well.

Thank you