Angular does not detect DOM change after popup is displayed on multiPolyline (created via paths directive)

From @vtytar on May 14, 2015 15:14
You can create a path with message field in its params, and as a result you will get it drawn with capability to click on it and raise a popup. If message field contains angular directives, they won't be recognized (parsed) as angular does not detect the DOM change after popup is displayed.
For instance,
HTML:
<leaflet [...] paths="map.paths"></leaflet>

Controller:
$scope.map.paths = [
    {
        type: 'multiPolyline',
        message: '

',
        latlngs: [
            { lat: 49.784499, lng: 24.060047 },
            { lat: 49.803566, lng: 23.996404 }
        ]
    }
];

Once you press on this polyline, empty popup is displayed without any attempt to download views/route.html. It happens because leaflet-directive paths link function binds the popup, but does not attach popupopen/popupclose events like marker directive does.
Here is how this is done for markers directive (which handles this situation very well):
listenMarkerEvents: function(marker, markerData, leafletScope) {
    marker.on("popupopen", function(/* event */) {
        safeApply(leafletScope, function() {
            markerData.focus = true;
        });
    });
    marker.on("popupclose", function(/* event */) {
        safeApply(leafletScope, function() {
            markerData.focus = false;
        });
    });
}

Probably something similar has to be done for paths as well.
I would appreciate if you suggested fix for the issue described above.
Copied from original issue: tombatossals/angular-leaflet-directive#756

From @vtytar on May 16, 2015 1:34
Apparently, adding listenPathEvents is not enough (of course it is not), it also requires to copy managePopupOpen from the marker. I have also noticed that path vs. marker API is a bit different inside of leaflet library in what seems should be the same: for instance, basic methods like path.getPopup() or path.closePopup() are missing etc.
Anyway, I have managed to resolve described problem myself, with, of course, two small buts:

My project is based on angular-leaflet-directive-v0.7.10 (higher releases caused some regressions in critical path as compared to 0.7.10, so I decided to stick to this version until I am able to fix them and upgrade to ToB).
Obviously, I have added only the stuff required by my project, which is not a complete solution (5% of what marker does), but in general it seems no harm to overall functionality: it only adds, should not break.

@nmccready, let me know if you are interested in taking the fix, and I will find some time to upgrade my project to latest version and create a corresponding pull request.
.

From @vtytar on May 16, 2015 1:36
Patch based on angular-leaflet-directive-v0.7.10:
--- build/bower_components/angular-leaflet-directive/dist/angular-leaflet-directive.js	2014-12-12 20:22:39.000000000 +0200
+++ build/bower_components/angular-leaflet-directive/dist/angular-leaflet-directive.patched.js	2015-05-16 03:52:50.300140837 +0300
@@ -978,7 +978,10 @@
                 paths     = leafletScope.paths,
                 createPath = leafletPathsHelpers.createPath,
                 bindPathEvents = leafletEvents.bindPathEvents,
-                setPathOptions = leafletPathsHelpers.setPathOptions;
+                setPathOptions = leafletPathsHelpers.setPathOptions,
+                listenPathEvents = leafletPathsHelpers.listenPathEvents,
+                manageOpenPopup = leafletPathsHelpers.manageOpenPopup;
+

             mapController.getMap().then(function(map) {
                 var defaults = leafletMapDefaults.getDefaults(attrs.id),
@@ -1006,12 +1009,19 @@

                     // Function for listening every single path once created
                     var watchPathFn = function(leafletPath, name) {
-                        var clearWatch = leafletScope.$watch('paths.' + name, function(pathData) {
+                        var clearWatch = leafletScope.$watch('paths.' + name, function(pathData, oldPathData) {
                             if (!isDefined(pathData)) {
                                 map.removeLayer(leafletPath);
                                 clearWatch();
                                 return;
                             }
+
+                            // The markerData.focus property must be true so we update if there wasn't a previous value or it wasn't true
+                            if (pathData.focus === true && oldPathData.focus === false) {
+                                // Reopen the popup when focus is still true
+                                manageOpenPopup(leafletPath, pathData);
+                            }
+
                             setPathOptions(leafletPath, pathData.type, pathData);
                         }, true);
                     };
@@ -1078,6 +1088,7 @@
                                 }

                                 bindPathEvents(newPath, newName, pathData, leafletScope);
+                                listenPathEvents(newPath, pathData, leafletScope);
                             }
                         }

@@ -2744,11 +2755,12 @@
 	};
 });

-angular.module("leaflet-directive").factory('leafletPathsHelpers', ["$rootScope", "$log", "leafletHelpers", function ($rootScope, $log, leafletHelpers) {
+angular.module("leaflet-directive").factory('leafletPathsHelpers', ["$rootScope", "$log", "$compile", "leafletHelpers", function ($rootScope, $log, $compile, leafletHelpers) {
     var isDefined = leafletHelpers.isDefined,
         isArray = leafletHelpers.isArray,
         isNumber = leafletHelpers.isNumber,
-        isValidPoint = leafletHelpers.isValidPoint;
+        isValidPoint = leafletHelpers.isValidPoint,
+        safeApply     = leafletHelpers.safeApply;
     var availableOptions = [
         // Path options
         'stroke', 'weight', 'color', 'opacity',
@@ -2992,6 +3004,41 @@
             }

             return pathTypes[path.type].createPath(options);
+        },
+        manageOpenPopup: function(path, pathData) {
+            //the path may have angular templates to compile
+            var popup = path._map._popup;
+            if (isDefined(popup)) {
+                var updatePopup = function(popup) {
+                    popup._updateLayout();
+                    popup._updatePosition();
+                };
+
+                $compile(popup._contentNode)($rootScope);
+                //in case of an ng-include, we need to update the content after template load
+                if (isDefined(popup._contentNode) && popup._contentNode.innerHTML.indexOf("ngInclude") > -1) {
+                    $rootScope.$on('$includeContentLoaded', function(event, src) {
+                        if (popup.getContent().indexOf(src) > -1) {
+                            updatePopup(popup);
+                        }
+                    });
+                }
+                else {
+                    updatePopup(popup);
+                }
+            }
+        },
+        listenPathEvents: function (path, pathData, leafletScope) {
+            path.on("popupopen", function(/* event */) {
+                safeApply(leafletScope, function() {
+                    pathData.focus = true;
+                });
+            });
+            path.on("popupclose", function(/* event */) {
+                safeApply(leafletScope, function() {
+                    pathData.focus = false;
+                });
+            });
         }
     };
 }]);

My suggestion is to dig into the code base and try to copy the implementation from leafletMarkersHelpers to where it needs to be on path. I don't have time to implement this right now. Open source depends on more contributors.


Project doesn't install headers

1.9.5 installed the headers, and 1.9.10-21 - doesn't.

Indeed it did: https://github.com/thrust/thrust/blob/aded199441e022f7fb89d51c1b2804ebc448c1af/CMakeLists.txt
Apparently the install logic got removed at some point. We should add this back.

I'll add this to my list of CMake features to add, but it might be a little bit before I can get to it.
As a workaround for now, just copying the thrust/thrust directory into the install location should provide a usable version of thrust.

Rules have been added in #1245.


fix flaky client test

The problem here was that the session that is spun up here tries to write the CHLO. It needs a valid remote address to send it to. It doesn't matter if someone is actually receiving the CHLO.
I ran the unit tests a couple of times on Travis, seems to work now.

Codecov Report

Merging #539 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
- Coverage   90.86%   90.79%   -0.07%
==========================================
  Files          79       79
  Lines        5406     5406
==========================================
- Hits         4912     4908       -4
- Misses        316      318       +2
- Partials      178      180       +2

Impacted Files
Coverage Δ

session.go
86.61% <0%> (-0.92%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130620d...7104604. Read the comment docs.


Publish Docker tags

Hi!
Could you please publish Docker tag for the latest release?
We can't use :latest because of our policy. Thanks!

Same issue over here, we cannot use moving targets. Any plans on providing them in the near future?

Its a fair point I'll look to do this asap

Hi @jamesdbloom,
Thanks! Any news regarding that?

This is now done, please check the docker hub for tags for most version of MockServer


org.osgi.test.cases.rest.client.js TCK fails intermittently in the CI build

The org.osgi.test.cases.rest.client.js TCK fails intermittently in the CI build due to some timing error. See https://github.com/osgi/osgi/runs/2822589008?check_suite_focus=true for an example.
This needs to be fixed to complete the Compendium R8 release.

The problem seems to relate to some unicode mismatch:
The assertion failure is:
Expected
bjhargrave;email="hargrave@us.ibm.com";name="BJ Hargrave";organization=IBM;organizationUrl="https://developer.ibm.com";roles=developer;timezone="America/New_York",rotty3000;email="raymond.auge@liferay.com";name="Ray AugÃÂ©";organization="Liferay Inc.";organizationUrl="https://www.liferay.com";roles=developer;timezone="America/New_York",kriegfrj;email="fr.jkrieg@greekwelfaresa.org.au";name="Fr Jeremy Krieg";timezone="Australia/Adelaide"

but was
bjhargrave;email="hargrave@us.ibm.com";name="BJ Hargrave";organization=IBM;organizationUrl="https://developer.ibm.com";roles=developer;timezone="America/New_York",rotty3000;email="raymond.auge@liferay.com";name="Ray AugÃ©";organization="Liferay Inc.";organizationUrl="https://www.liferay.com";roles=developer;timezone="America/New_York",kriegfrj;email="fr.jkrieg@greekwelfaresa.org.au";name="Fr Jeremy Krieg";timezone="Australia/Adelaide"

So the difference is in:
name="Ray AugÃÂ©" vs name="Ray AugÃ©"
One of the problems with this test is that it uses a random bundle every time, so it won't produce the same test result every run.

So the difference is in:
name="Ray AugÃ�Â©" vs name="Ray AugÃ©"

Just changing the TCK to exclude this one header is just ignoring the real encoding problem. I have a PR to fix this in the test.

And thanks to @rotty3000 for exposing this TCK bug! :-)


Update main.tf

Kikitux
I tested you change and it didn't work.
Because I use terraform 0.11 which the custom plugin I use requires we have to use value = "${data.extip.external_ip.ipaddress}"
Your syntax would be correct to use with terraform version 0.12 and higher.
Thank you for reviewing my code. Please keep doing this in the future. I really appreciate it


Node: Re-create the lockfiles for the project-with-lockfile test projects

Make the results easy to compare.
Part of #9261.

Merge regardless of the unrelated clearlydefined test failures.


Not properly sanitizing $BoundParameters before converting to JSON and sending in request body

In your functions, you are taking $PSBoundParameters and converting it to a JSON string then sending it to the API. This causes unneeded properties to be sent with the request when the function is called with common parameters such as -Verbose or -Debug. The Isilon API responds with an error when these properties are sent.
Might I suggest you sanitize your properties before sending to the API? The function below will remove common properties.
function SanitizeBoundParameters {
	[cmdletbinding()]
	param(
		[parameter(Mandatory, ValueFromPipeline)]
		[hashtable]$Parameters
	)

	$commonParameters = @('Verbose', 'Debug', 'ErrorAction', 'ErrorVariable', 'WarningAction', 'WarningVariable',
		'OutBuffer', 'PipelineVariable', 'OutVariable')

	$commonParameters | % {
		$Parameters.Remove($_)
	}

	return $Parameters
}

This function could then be called like so:
$boundParameters = $PSBoundParameters | SanitizeBoundParameters
$body = ConvertTo-Json -Depth 40 $BoundParameters
$ISIObject = Send-isiAPI -Method POST -Resource ("/platform/1/quota/quotas" + "$queryArguments") -body $body -Cluster $Cluster

Great!
I'll work the enhancement into Isilon-POSH-Generator and recreate all functions.

merged enhancement with Sanitize BoundParameters


Add WebhookAdmission reference

This adds a reference for WebhookAdmission config generated from kubernetes-sigs/reference-docs/genref tool.
More specifically, it is generated using the following command:
./genref -format markdown -include apiserver-webhookadmission

Preview: https://deploy-preview-26605--kubernetes-io-master-staging.netlify.app/docs/reference/command-line-tools-reference/apiserver-webhookadmission.v1/

/sig api-machinery

/reopen
Oops!

/sig api-machinery

LGTM

/hold
Depends on: https://github.com/kubernetes-sigs/reference-docs/pull/214

/hold cancel
kubernetes-sigs/reference-docs#214 is in.

/lgtm


fix missing curly bracket in css

added a missing closing curly bracket in css style

@Sarfarazsajjad : Thanks for your contribution! The author, @v-jaswel, has been notified to review your proposed change.


Issue with import-to-neo4j.sh

I am working with neo4j 3.5.8 for my thesis and I have issue with the import-to-neo4j outcome. Here is the code and the result:
`#!/bin/bash
$NEO4J_HOME/bin/neo4j-import --into $NEO4J_DB_DIR
--id-type=INTEGER
--nodes:Place "${NEO4J_DATA_DIR}/static/place${POSTFIX}"
--nodes:Organisation "${NEO4J_DATA_DIR}/static/organisation${POSTFIX}"
--nodes:TagClass "${NEO4J_DATA_DIR}/static/tagclass${POSTFIX}"
--nodes:Tag "${NEO4J_DATA_DIR}/static/tag${POSTFIX}"
--nodes:Message:Comment "${NEO4J_DATA_DIR}/dynamic/comment${POSTFIX}"
--nodes:Forum "${NEO4J_DATA_DIR}/dynamic/forum${POSTFIX}"
--nodes:Person "${NEO4J_DATA_DIR}/dynamic/person${POSTFIX}"
--nodes:Message:Post "${NEO4J_DATA_DIR}/dynamic/post${POSTFIX}"
--relationships:IS_PART_OF "${NEO4J_DATA_DIR}/static/place_isPartOf_place${POSTFIX}"
--relationships:IS_SUBCLASS_OF "${NEO4J_DATA_DIR}/static/tagclass_isSubclassOf_tagclass${POSTFIX}"
--relationships:IS_LOCATED_IN "${NEO4J_DATA_DIR}/static/organisation_isLocatedIn_place${POSTFIX}"
--relationships:HAS_TYPE "${NEO4J_DATA_DIR}/static/tag_hasType_tagclass${POSTFIX}"
--relationships:HAS_CREATOR "${NEO4J_DATA_DIR}/dynamic/comment_hasCreator_person${POSTFIX}"
--relationships:IS_LOCATED_IN "${NEO4J_DATA_DIR}/dynamic/comment_isLocatedIn_place${POSTFIX}"
--relationships:REPLY_OF "${NEO4J_DATA_DIR}/dynamic/comment_replyOf_comment${POSTFIX}"
--relationships:REPLY_OF "${NEO4J_DATA_DIR}/dynamic/comment_replyOf_post${POSTFIX}"
--relationships:CONTAINER_OF "${NEO4J_DATA_DIR}/dynamic/forum_containerOf_post${POSTFIX}"
--relationships:HAS_MEMBER "${NEO4J_DATA_DIR}/dynamic/forum_hasMember_person${POSTFIX}"
--relationships:HAS_MODERATOR "${NEO4J_DATA_DIR}/dynamic/forum_hasModerator_person${POSTFIX}"
--relationships:HAS_TAG "${NEO4J_DATA_DIR}/dynamic/forum_hasTag_tag${POSTFIX}"
--relationships:HAS_INTEREST "${NEO4J_DATA_DIR}/dynamic/person_hasInterest_tag${POSTFIX}"
--relationships:IS_LOCATED_IN "${NEO4J_DATA_DIR}/dynamic/person_isLocatedIn_place${POSTFIX}"
--relationships:KNOWS "${NEO4J_DATA_DIR}/dynamic/person_knows_person${POSTFIX}"
--relationships:LIKES "${NEO4J_DATA_DIR}/dynamic/person_likes_comment${POSTFIX}"
--relationships:LIKES "${NEO4J_DATA_DIR}/dynamic/person_likes_post${POSTFIX}"
--relationships:HAS_CREATOR "${NEO4J_DATA_DIR}/dynamic/post_hasCreator_person${POSTFIX}"
--relationships:HAS_TAG "${NEO4J_DATA_DIR}/dynamic/comment_hasTag_tag${POSTFIX}"
--relationships:HAS_TAG "${NEO4J_DATA_DIR}/dynamic/post_hasTag_tag${POSTFIX}"
--relationships:IS_LOCATED_IN "${NEO4J_DATA_DIR}/dynamic/post_isLocatedIn_place${POSTFIX}"
--relationships:STUDY_AT "${NEO4J_DATA_DIR}/dynamic/person_studyAt_organisation${POSTFIX}"
--relationships:WORK_AT "${NEO4J_DATA_DIR}/dynamic/person_workAt_organisation${POSTFIX}"
--delimiter '|'`
./import-to-neo4j.sh: línea 3: /var/lib/neo4j/bin/neo4j-import: No existe el archivo o el directorio
I checked the environment variables and its are the following:
export NEO4J_HOME="/var/lib/neo4j"
export NEO4J_DATA_DIR="/home/fco/ldbc_snb_datagen-0.3.2/test_data_100/social_network"
export NEO4J_DB_DIR=$NEO4J_HOME/data/databases/graph.db
export POSTFIX=_0_0.csv
@szarnyasg sorry I must transfer everything to a server

Use triple backticks for formatting code blocks. One backtick is only sufficient for inline code.
Regarding the problem, does /var/lib/neo4j/bin/neo4j-import exist? You can easily check this by issuing:
$ ls /var/lib/neo4j/bin/neo4j-import

It might be the case that you have installed Neo4j 4.0 in which case you'll only have the /var/lib/neo4j/bin/neo4j-admin binary. In this case, I'd encourage you to try and move to Neo4j 3.5. for 4.0, you'd have to switch to the dev branch - which has different environment variables and the 4.0 importer has some known issues as of today.

I can’t take it to neo4j 4 because I already did some work for my thesis on neo4j 3.5.8. The result of the route query indicates that it does not exist. According to neo4j the route to import into Debian is /var/lib/neo4j/import I make the modification in the code and I throw this:
. /import-to-neo4j.sh: line 3: /var/lib/neo4j/import: It is a directory

/var/lib/neo4j/import is indeed a directory but that's there for the online import tools, i.e. the ones which can load data while the database is running. You're using the offline import tool now, so this directory will not be relevant. Can you do an
$ ls /var/lib/neo4j/bin/

to see what's in there?
I don't have any experience with the Neo4j Debian package so I'm in the dark here.

There is nothing but the path that is there is supposed to point to where the neo4j-import file is located, that is in the path /usr/bin/neo4j-import. This is the result:
WARNING: neo4j-import is deprecated and support for it will be removed in a future version of Neo4j; please use neo4j-admin import instead. Exception in thread "main" org.neo4j.unsafe.impl.batchimport.input.HeaderException: Missing header of type START_ID, among entries [Post.id:string, Place.id:string] 	at org.neo4j.unsafe.impl.batchimport.input.csv.DataFactories$AbstractDefaultFileHeaderParser.validateHeader(DataFactories.java:259) 	at org.neo4j.unsafe.impl.batchimport.input.csv.DataFactories$AbstractDefaultFileHeaderParser.create(DataFactories.java:215) 	at org.neo4j.unsafe.impl.batchimport.input.csv.CsvInput.verifyHeaders(CsvInput.java:145) 	at org.neo4j.unsafe.impl.batchimport.input.csv.CsvInput.<init>(CsvInput.java:112) 	at org.neo4j.unsafe.impl.batchimport.input.csv.CsvInput.<init>(CsvInput.java:91) 	at org.neo4j.tooling.ImportTool.main(ImportTool.java:477) 	at org.neo4j.tooling.ImportTool.main(ImportTool.java:379)
neo4j and neo4j-admin files are located in the same path, also the good thing is that there already works the code but presents another problem.

This error message is pretty good news! It informs you that the header is not compatible with the Neo4j import tool. To fix this, you'll need to run the convert-csvs.sh script and try loading again.
PS: again, use triple backticks to fence code/console output blocks:
```
some code
```

Ok, the problem is that convert-csvs.sh does not do the conversion but if the process ends :/
PS: there I corrected the request :)

Thanks for the formatting improvement. What's the error message when the conversion process terminates?

Exactly is the result of the previous error. With regard to the result that the terminal delivers after running convert-csvs.sh is as follows:
starting preprocessing
preprocessing finished

It seems your convert-csvs.sh has finished correctly. You can double-check this by taking a look at e.g.
$ head social_network/dynamic/person_0_0.csv

to see if the header has been changed or not. It shoud have :STRING, :INT and similar type information in its header.

Hello I was able to fix the problem, it was a problem of configuration of the files .sh because its execution was not allowed, in addition to correcting the route /usr/bin/ which refers to:
neo4j
neo4j-import
neo4j-admin

Thank you @szarnyasg for your help :D

Welcome.

It is problem of headers.txt. the order of title is confused that cannot correspond to csv file

@xspeng95 make sure you use the (non-default) stable branch of the generator and the implementations repositories. For those, the headers align.

@xspeng95 make sure you use the (non-default) stable branch of the generator and the implementations repositories. For those, the headers align.

oh no! I am sorry!  I used the default branch of the generator!!!!


Could you offer LAION GPT4V images

follew https://huggingface.co/datasets/laion/gpt4v-dataset. There are about 400-500 pictures that cannot be downloaded. Could you provide the complete version?

Hi, same here, some images seems can not be downloaded automatically still it get from browser manually, does there any images.zip could be shared?

Just curious, does the name in annotation like: gpt4v-dataset/images/gpt_v7519.jpg the name is the index in json order?

Just curious, does the name in annotation like: gpt4v-dataset/images/gpt_v7519.jpg the name is the index in json order?

same question here, did you get a reasonable explanation?


Fix menu about and hide title

The title for About and Hide menu options are using the default ElectronReact labels.

Thanks!


fix: simplify gutters

Description

Swapping gutterX and gutterY objects with t-shirt sizes to more streamlined single values in the theme and updating all styles mapped to those tokens accordingly. Additionally, this updates the Badge text style to map to "tag1" instead of "caption1," Marquee to use a static "100" (not a token number) for fadeWidth (but still theme-able), and the GridOverlay to display the Gutter values in the text overlay.
References

Testing

Ensure stories are displaying as expected, especially Rows and Columns

Automation

Checklist

[ ] all commented code has been removed
[ ] any new console issues have been resolved
[ ] code linter and formatter has been run
[ ] test coverage meets repo requirements
[ ] PR name matches the expected semantic-commit syntax

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

:tada: This PR is included in version @lightningjs/ui-components-theme-base-v1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @lightningjs/ui-components-v2.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Issues regarding VSC dark+ theme

https://github.com/PrismJS/prism-themes/blob/1e3e8d655802dd24b65a39a4a5637c5ec0c7af72/themes/prism-vsc-dark-plus.css#L48
At this line there is an issue which sets the background-color of inline code-blocks to a light color (#f9f2f4) instead of a dark one like the code-block background-color (#1e1e1e).
I suggest changing this to a dark color like #1e1e1e to achieve a good contrast between code and background.
Preview of inline code-block:

Furthermore I wanted to add that it probably would be better if the font size is the same in every theme.

Regarding font size: Over at PrismJS/prism, we use a font-size: 1em for all themes. It might be a good idea to do so here as well.


gocd-server: add startupOptions, empty extraOptions

Motivation for this change
Avoiding unexpected behavior.
services.gocd-server.extraOptions has a default value which seems surprising given other "extraOptions" values are empty (including that for gocd-agent).  Given that default value seems important, it was moved to startupOptions to mirror how gocd-agent is configured, and the default was removed for extraOptions.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[X] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@tvon Thank you for submitting this PR.  I was able successfully install gocd-server in nixos with your PR.
It looks like the Travis build failed due to a timeout.
@grahamc Would you like to run the test suite on this PR?  I am still having trouble getting my VM to run the tests.

LGTM


Fix inefficient Solution in ExamProtocolDao

In the ExamProtocolDao in the method "getNumberOfExamProtocolsTotal()", the number of exam protocols is calculated by fetching all exam protocol objects from the DB and then using the array size of this result. Fix this by using the SQL "COUNT" functionality.

Fixed in 75cb45833dddee56cc2e67513febfbc12140ddcc.


Fix kubeversion formatting in EKSD_LATEST_RELEASES

Fix kubeversion formatting in EKSD_LATEST_RELEASES file.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Force merging to unblock e2e test pipeline.


PyPI has an outdated (1.3.1) release

The most recent release on PyPI (1.3.1) is one minor version behind the current 1.4, which is only available here on Github. There must be countless deployments and projects out there that will therefore never update to the newest release because pip doesn't know about it.
I would have expected PyPI to contain the same v1.4 release.

hey @dnso86 and @alain-khalil thanks for your offer to help out here. I'd prefer to configure GH Actions to deploy to PyPI. I think we can cannibalize the workflow config from here: https://github.com/mandiant/capa/blob/master/.github/workflows/publish.yml
i'll try to do this first thing in the morning, and if it doesn't work out, I'll tag @alain-khalil to help out.

Ok great


Suggestion: some way of highlighting dependencies

The only "difficulty" I'm having in mathing everything out, is identifying what is used where. A tree view with a filter would be magnificent, but in the current UI, maybe an exclusive button similar to the "toggle item group" functionality, that simply highlights all recipes (and parent recipes) that use the selected ingredient. Perhaps a color gradient to indicate how "far away" from the specified item the recipe is, aka if I highlight Engines, then Electric Engines would be one step away, and production science would be two steps.
Just a thought, I'm not really sure what the ideal extension of the current UI would be, but it'd be a useful function.

Did this commit solved your difficulty?
Add ability to click on graph nodes: https://github.com/KirkMcDonald/kirkmcdonald.github.io/commit/b38ad04619feb79566c0a69f1a417a51e76ddc4e

Did you know there is a "visualize" tab? I think it does exactly what you're asking here (and otherwise I don't know exactly what you're asking for)


Add Dynamic Texture Loader from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of rbray89, to add Dynamic Texture Loader to CKAN.
Please direct questions about this pull request to rbray89.

Done in #2877


[Bug] Reorder stops working when depth > 2 and middle element is deleted

Reported here: https://github.com/Laravel-Backpack/CRUD/pull/4908
It has videos and such so no much explanation needed. Just need to find a better solution.

Hey @pxpm
I solved here #5028
This is the best solution as per my understanding. I tested in multiple ways, worked every way!
You too have a check! 🤞

Closing this one.
let's keep the conversation in the PR https://github.com/Laravel-Backpack/CRUD/pull/5028


feat: add new LIP on coverage application

Specifies an in-protocol mechanism of applying coverage to address slashing/penalties events.
:heart_on_fire: :heart_on_fire: :heart_on_fire:

@ujenjt and @skozin thank you so much! :handshake:


Time for version 1.0

it's time to create release tag on GitHub for proper dependency management

As it stands, I'm not sure that versioning this repo makes a ton of sense. We'd have to do version bumps for a lot of unrelated changes and following the changes and relevant versions would get complicated.
As we have time I'm imagining splitting this out would be better, but in the meantime I don't see versioning this repo as a good idea. @mittonk let me know what you think.

I'd agree --- let's version separate single-language repos as we create them.


Set Date and Time - Wrong time zone (?)

Checklist

[X]  I am not using Home Assistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem is not mentioned there.

Deploy method
Home Assistant Add-on
Z-Wave JS UI version
9.3.2
ZwaveJS version
12.3.0
Describe the bug
When using the "Set date and time of this node to current time" function on my z-wave thermostats, the time is one hour off. Wrong time zone?
This has been working perfectly until recently.
To Reproduce

Open Z-Wave JS UI and go to control panel
Select a node with time, e.g. Namron - 16A Touch Thermostat - White
Select "Advanced"
Click on the "Sync"-button under "Set Date and Time"
View the updated time on the device display

Expected behavior
The time on the device display is reflecting the system time and time zone.
Additional context
The log from the addon is showing the correct time

@mariuske Could you try to reproduce with latest 9.6.0? cc @AlCalzone

Same problem by me with the last 9.6.0  version

There has been an issue previously where some Namron Thermostats were expecting the time to be set as UTC because they get the timezone information from somewhere else: https://github.com/zwave-js/node-zwave-js/issues/6386
According to the device manual, parameter 24 is used to configure the timezone, and it states that the device expects the commands to use UTC:


unordered-set: Fix flaky test

We saw this fail once here:
--- FAIL: TestToSlice (0.00s)
    unorderedset_test.go:25:
        Expected: [one two]
        Actually: [two one]

@asridharan PTAL


adding shadocs theme

Adding shadocs to the Hugo themes

Hello @jgazeau,
thanks for sharing your documenation theme with the Hugo community 👍 It should appear on www.themes.gohugo.io soon.
Tip: on themes.gohugo.io, you can add next to the "Download" button a "Demo" button to link to a self-hosted demo by adding the following information to the theme.toml:
# If you have a running demo of the theme.
demosite = "https://your-url.com"

Hello @digitalcraftsman ,
Thanks for your tip and your reactivity 😃


[Feature request]: Remove "!important" from --ngx-editor-click-pointer And add :not(:disabled) or add a second var for :disabled

Proposal
Hello!
See title. Thanks :)
.NgxEditor__MenuBar button, .NgxEditor__MenuBar [role=button] {
  cursor: var(--ngx-editor-click-pointer, default) !important;
}

Willing to submit a PR?
None

Should be fixed in v17.5.4


Cleanup travis config about dep

What this PR does / why we need it:
It seems we have adopted to Go Module, so comments in Travis configuration is outdated.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
I'm going through kubefed recently, I wish I can help to make it better.

/assign @font

/assign @pmorie @hectorj2f

/approve

/lgtm


Category link and View?

Q
A

Bug report?
yes/no

Feature request?
yes

Support request?
yes

I just curious about all categories page that we made it. wheres the link of the category that contains all listings.

The link of your categories pages are the same than you have when you make a search with categories.

@cocolabssas without selected location I can't get the results so how can I see all result in only one specific category.

If you work with only one country you can use the url of a search on this country and this category.
Else you have to implement this simple functionality yourself.


[WIDGET] flowbox

Description of the widget
the flowbox widget would act much like a CSS flexbox, being able to wrap its contents based on its width/height.
Implementation proposal
This widget would be based on the GTK flowbox, which already does much of what is required.
Example usage
the widget could be used in several ways:

dynamic widget layouts that could be integrated into tiling window Managers.
file explorers
image galleries
app launchers

Format
(flowbox :width "100%"
         :height "100%"
         :orientation "v" ;;same as box widget
         :direction "down" ;;other values: up, left/right (if orientation is horizontal)
         :min-item-size "30px" ;;dictates how small items can be smooshed before they get wrapped. If unspecified, the contents of the items will determine the minimum size
         :max-per-row 5 ;;mutually exclusive with the previous property. if unspecified, value defaults to the flowbox's current width / min-item-size.
         :row-size 40px ;;how high/wide to make each row/column. if unspecified, item dimensions will dictate the row's appearance.
         :justify-end "fill" ;;how do the items in the last row get spaced if they can't fill the whole row? possible values: "start", "end", "center", "fill", "space" (keeps the items the same width, but centers them and spaces them evenly)
    (children)  ;; Children would have an "order" property, which determines the order in which the items appear.
)

Those are all the properties I would find useful. Even some of these would make this widget a great addition to eww.
Additional context
No response

I need this widget too


add origin to CSP so Safari can do recursion

adds a content_security_policy_origin option to server. Tested on safari on macos 14.1.1 by doing ord server --content-security-policy-origin http://<IP_ADDRESS>:80 and was able to view recursive inscriptions correctly.
fixes #2229

Does this have to be a full url with http/https, or can it just be a host?
Otherwise this looks good. Maybe a shorter flag name, like --csp-origin?

it looks like you need the full url.
flag shortened


Make euclid optional for the crankstart-sys crate

Hi,
Thank you for creating this, I'm having fun using crankstart-sys crate  :-)
As I don't need the euclid crate (because I'm using glam instead),
It would be great if I could avoid pulling dependencies I don't need.
I suggest making it optional, so crates that want it  (i.e. the crankstart crate) can have it, and other consumers can opt-out.
What do you think?

👍


Deana can create a new entry

Given Deana has and account and is logged in
When Deana clicks the button to create a new entry
Then a form should pop up, and the input data should be inserted into the diary table in db.

Create new diary entry server endpoint created, postman tested.

Linked to frontend. I can successfully add an entry and see it in my database, but I think the USER ID may be incorrect. (i logged in with user_id "5" in my own database, but when adding an entry it says my user_id is "1".)

Linked to frontend. I can successfully add an entry and see it in my database, but I think the USER ID may be incorrect. (i logged in with user_id "5" in my own database, but when adding an entry it says my user_id is "1".)

This is linked to the user's auth feature, currently, all users point to users_id 1, will look into this further.


Integration on start.spring.io

Quoting metalhead-001 from reddit, who asked about this in the jte 3 comments.

I really wish the Spring project would adopt this as one of the supported Spring Boot templating engines that show up on start.spring.io like Thyemeaf, Freemarker, etc. do. Have you considered attempting to get jte brought into Spring like the others?

As far as getting it integrated into start.spring.io, I think you would just have to open a pull request into the Spring project and include your starter with it...basically follow the same pattern as the Thymeleaf and Freemarker, etc. integrations.

I bet if you got that going they would be willing to accept it as they have accepted the other templating engines. There is also a bit of documentation that would have to be provided. Look at the documentation on the Thymeleaf integration here. Search for Thymeleaf on this 'one page' documentation and you can see everywhere it's documented. Similar documentation would have to be provided for jte.

https://docs.spring.io/spring-boot/docs/3.1.0/reference/htmlsingle/
@atomfrede do you think we should give this a try?

Why not. It seems there is some kind of proposal process, so maybe we should start with creating such a proposal. But I could imagine it is easier as jte is "just" a template engine and not backed by a company like this proposal https://github.com/spring-io/start.spring.io/issues/1114

Oh yes, the proposal you linked looks frightening. I'm unsure if we are ready to commit to this.

Should we try to create a proposal here together? At jcon a lot of people knew and asked Thomas and me about jte vs thymeleaf for example. So I would say there is some interest

That would be awesome! What would be the best way to collaborate on a document like this? Best thing I could think of would be a branch with a markdown file in it?
Also, really cool to hear that people where asking about jte 😊

@casid
Yea I currently support 2 libraries in my library, and JTE is definitely the better option, for using with Spring ViewComponent. Thymeleaf has a lot of Spring Magic, that you don't really need with server-side components.
I just need to get going on my compile time checker because then it would be completly type safe and null safe, cause currently JTE throws an error at runtime if a property that is declared as an parameter is not available in the model.
btw did you see my Spring I/O Talk? I also talked a bit about JTE there: https://youtu.be/DPAtQU-erM4?t=749

@tschuehly great talk, thanks for sharing the video!
As for type-safety of params, maybe the new jte-models extension could be helpful?

@casid, if it’s okay with you, I would like to add support for JTE templates in Generator Genie. I’ve already started the process but ran into this issue, which I posted on StackOverflow. Once this issue is resolved, I plan to add support for JTE templates.

Welcome @nicholasnet
Sure thing, go for it, that's very much appreciated!
Can you post a stacktrace of the error you run into in production?

Sure here is the repo link I think that will be easier. As you see this is plain vanilla Spring Boot MVC app.
https://github.com/nicholasnet/jte-spring-gradle
Here if you do just ./gradlew bootRun
Then go to http://localhost:8080 it works.
However, if you do
./gradlew bootBuildImage
Then run the image docker run -it --rm -p '8080:8080' -e 'SPRING_PROFILES_ACTIVE=prod' jte:0.0.1-SNAPSHOT
Then go to http://localhost:8080 it does not work.

I've just submitted an issue for integrating it into start.spring.io: https://github.com/spring-io/start.spring.io/issues/1560

Hey @casid, Moritz waits for feedback from you. Would be awesome if you could approve the integration!


add distinction between OS1 and OS2 for singlemode fiber in constants.py

Environment

Python version:  3.6 (from netbox-community docker image)
NetBox version:  2.5.5

Proposed Functionality
Addition of OS1 and OS2 singlemode fiber options in constants.py. No changes to workflow or user interface needed as far as I can see.  I can add a PR if requested.
Use Case
This is needed for being able to choose from this two types of singlemode fiber for cable "creation". Till now there is just "Singlemode Fiber" available but four types of multimode fiber.
Database Changes
Not that I'm aware of. Name and ID come from constants.py and are probably stored as such in the DB.
External Dependencies
None.

As discussed in Slack, there are other types beyond OS1 and OS2, so I would propose keep SMF as 3500, then add OS1 and OS2 as something like 3510, 3520 as they are derivative of the SMF type but rename it Singlemode Fiber (Generic)

http://www.thefoa.org/tech/ref/basic/fiber.html
I prefer using official Names (see Graphic) if we allow to specify them:
http://www.thefoa.org/tech/ref/basic/FiberFamilyTree.jpg

For consistency, I'm going to:

Add a generic MMF type
Keep the existing generic SMF type in place
Add two new types for OS1 and OS2

This leaves it up the user whether they want to specify just MMF or SMF, or a specific class.


Installation NoMethodError: undefined method `has_key?' for "objectId":String

Hi I am having this error
NoMethodError: undefined method `has_key?' for "objectId":String from /Users/foobar/.gem/ruby/2.1.2/gems/parse-ruby-client-0.3.0/lib/parse/object.rb:198:in `parse'

whenever I try to call
installation = Parse::Installation.new "objectId"

I am using version 0.3.0, any idea where does that come from?

Parse::Installation.new just doesn't work anymore
Parse::Installation.get doesn't exist and with you try: Parse::Installation.new {"installation_id"=>"ID"}
nothing happens

@fernandodev which version are you using? The 0.3.0 is seriously old and we're working on master.
can you explain what you're trying to do?

Hello @rhymes
I'm using v0.3.0 =~
I was trying to get a specific Installation by installation_id. It was necessary for targeted push notification.
At this moment I've implemented an API Wrapper for Parse using rest_client's  gem.

@fernandodev don't know if you have the time but you could try out the github version.
To retrieve an installation by a field different from objectId you should query for it. For example:
installation = client.query('Installation').tap do |q|
  q.eq('installation_id', value)
end.get

Thank you @rhymes :+1:


Error in tutorial code

Describe the bug
In the tutorial's main() function, it's calling initialModel() but it should be initializeModel().
Setup
Please complete the following information along with version numbers, if applicable.

OS: any
Shell: any
Terminal Emulator: any
Terminal Multiplexer: any

To Reproduce
Steps to reproduce the behavior:

copy the tutorial code
run it

Source Code
func main() {
     p := tea.NewProgram(initialModel())
     if _, err := p.Run(); err != nil {
         fmt.Printf("Error: %v", err)
         os.Exit(1)
     }
 }

Expected behavior
The tutorial code should run without error
Screenshots

Additional context
N/A

Read tutorial wrong


Set default handler for XmlSlurper to avoid printing exception [Fatal…

… Error]  1 1  Content

Codecov Report

Merging #871 into 2.0.x will decrease coverage by 0.12%.
The diff coverage is 46.15%.

@@             Coverage Diff              @@
##              2.0.x     #871      +/-   ##
============================================
- Coverage     56.17%   56.04%   -0.13%
  Complexity     2188     2188
============================================
  Files           229      229
  Lines         10395    10403       +8
  Branches       1447     1451       +4
============================================
- Hits           5839     5830       -9
- Misses         3753     3769      +16
- Partials        803      804       +1

Impacted Files
Coverage Δ
Complexity Δ

...k/cloud/contract/verifier/util/ContentUtils.groovy
58.36% <37.5%> (-1.02%)
59 <1> (+1)

...ct/verifier/wiremock/WireMockToDslConverter.groovy
35.57% <60%> (+1.57%)
19 <1> (+1)
:arrow_up:

...loud/contract/stubrunner/TemporaryFileStorage.java
22.58% <0%> (-32.26%)
5% <0%> (-1%)

.../contract/stubrunner/ScmStubDownloaderBuilder.java
79.41% <0%> (-0.99%)
10% <0%> (ø)

...loud/contract/stubrunner/AetherStubDownloader.java
63.2% <0%> (-0.95%)
25% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f774f...f63d0a0. Read the comment docs.

Codecov Report

Merging #871 into 2.0.x will decrease coverage by 0.12%.
The diff coverage is 46.15%.

@@             Coverage Diff              @@
##              2.0.x     #871      +/-   ##
============================================
- Coverage     56.17%   56.04%   -0.13%
  Complexity     2188     2188
============================================
  Files           229      229
  Lines         10395    10403       +8
  Branches       1447     1451       +4
============================================
- Hits           5839     5830       -9
- Misses         3753     3769      +16
- Partials        803      804       +1

Impacted Files
Coverage Δ
Complexity Δ

...k/cloud/contract/verifier/util/ContentUtils.groovy
58.36% <37.5%> (-1.02%)
59 <1> (+1)

...ct/verifier/wiremock/WireMockToDslConverter.groovy
35.57% <60%> (+1.57%)
19 <1> (+1)
:arrow_up:

...loud/contract/stubrunner/TemporaryFileStorage.java
22.58% <0%> (-32.26%)
5% <0%> (-1%)

.../contract/stubrunner/ScmStubDownloaderBuilder.java
79.41% <0%> (-0.99%)
10% <0%> (ø)

...loud/contract/stubrunner/AetherStubDownloader.java
63.2% <0%> (-0.95%)
25% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f774f...f63d0a0. Read the comment docs.


perlPackages.starman: add shortenPerlShebang on darwin

Motivation for this change
nix-serve doesn't work on darwin because of starman package.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build perlPackages.starman


Update Use_solve_ivp_without_py-pde_wrapper branch

Discussed in https://github.com/astro-turing/Integrating-diagenetic-equations-using-Python/discussions/26
From this discussion it is clear that this branch should be maintained. One of the most pressing reasons is the need to solve for stiff equations in the perhaps not too distant future. This requires implicit solvers using functional Jacobians, which solve_ivp accommodates for, but only if the py-pde wrapper is not used.
What this means is that the refactoring applied to the main branch should also be applied to the Use_solve_ivp_without_py-pde_wrapper branch. This involves PR #15 and beyond. Abundant use of git's cherry-pick is anticipated.
A constant porosity diffusion coefficient needs to implemented, similar to the main branch, which should be propagated to the functional Jacobian.
An important aspect is that solve_ivp's memory use and performance needs to be investigated and improved if needed.

I believe we can also close this issue now since the py-pde wrapper can be coaxed into reproducing oscillations?

One of the most pressing reasons is the need to solve for stiff equations in the perhaps not too distant future.

The py-pde wrapper precludes functional Jacobians, but at this point it seems we can get away with numerically approximated Jacobians for implicit solvers.
A constant porosity diffusion coefficient needs to implemented, similar to the main branch, which should be propagated to the functional Jacobian.

A constant porosity diffusion coefficient has been implemented in the Use_solve_ivp_without_py-pde_wrapper branch, not in its functional Jacobian, but that is not an issue, as long as you don't call the functional Jacobian.
An important aspect is that solve_ivp's memory use and performance needs to be investigated and improved if needed.

This has been tackled.

I hear a "yes"?

Yes!


Make the sidebar scrollable above 768px

I tested those changes in the devtools but I did not build the docs to check (it would be nice to have instructions on how to contribute)

:wave: Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

:art: If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
:fast_forward: If this is a PR that includes changes to an interaction, please include a video recording in the description.
:warning: If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.


Trouble Connecting

PiVPN Issue Template

Console output of curl install.pivpn.io | bash
I'm getting an error on my computer of

> TLS Error: Unroutable control packet received...

My iPhone works great however. It was working just fine on my windows computer until today.
I regenerated the config/certificate for this computer, and it still doesn't work.
What do you suggest trying? My computer is running the default OpenVPN client.

Console output of pivpn add or pivpn add nopass

Console output of pivpn debug

Issue

I accidently posted twice.


Palomabot.ai no longer shows total volume for Curve TWAP and other bots

Volume figures are suddenly missing for a number of bots.
See image below.

Volume.finance page data is also missing.

Fixed


HandyJSON and Swift 5

Undefined symbol: _swift_getFieldAt
Please update HandyJSON for compatibility with Swift 5

Here is the solution for this, which means the need is to update HandyJson branch to 5.0.0-beta.1.
[https://github.com/alibaba/HandyJSON/issues/307](HandyJson Issue 307)

With regard to using HandyJson 5.0.0-beta.1: that build isn't compatible with ScClient 1.0.8 (which requires HandyJson 4.2.0). Any possibilities of updating ScClient to support the HandyJson beta build?

Added support for swift 5, I am really sorry for the delayed response :) Please try using it and let me know if you are facing any issues.


[MM-56620] use compression for dumps

Summary
Saves up almost %90 space for the dumps. a 3-node installation may have around 100MB of data for a week, compression shrinks it down to ~10MB.
Ticket Link
https://mattermost.atlassian.net/browse/MM-56620

Codecov Report
Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (7f9a6fe) 12.58% compared to head (b9cf7fe) 11.35%.
Report is 1 commits behind head on master.

Files
Patch %
Lines

server/plugin.go
0.00%
56 Missing :warning:

server/cluster.go
0.00%
32 Missing :warning:

server/copy.go
74.07%
3 Missing and 4 partials :warning:

server/dump.go
0.00%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   12.58%   11.35%   -1.24%
==========================================
  Files           8        9       +1
  Lines         715      775      +60
==========================================
- Hits           90       88       -2
- Misses        609      672      +63
+ Partials       16       15       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Generated SRAM macros

Hi, I generated SRAM macros with OpenRAM, since I needed nearly 40 kB of RAM and it is almost impossible to provide it with 2 kB macros. I got Magic DRC errors and asked about it in the Slack channel. They told me that SRAM macros commonly have this issues and reccomended to turn off Magic DRC check while running user_project_wrapper. The flow passes but I have problems in precheck due to DRC issues. I also asked about it in the Slack channel and they told me that SRAM macros in the PDK directory are automatically excluded from DRC check, but they were not sure if users can add custom SRAM macros. Am I allowed to add my custom SRAM in caravel user project? If yes, how can I make the precheck tool to exclude my SRAM too?

The pre-check tools only recognized the published SRAM macros, so, we recommend you to use the published ones


fix(#7): add "base" key in config to specify base url

I tested this and it worked with the example I added in ./examples.
If you feel like "base" is too vague feel free to change the name. It could be base_url but you already use that name elsewhere so I wasn't sure what to do with that.
I've never coded in rust before so I'm not sure if I needed to add this line:
.set_default("base", "")?

or is that already default?
Finally, it might be important to say somewhere that the leading slash in the base url is needed, or we could figure out a way to make it not needed. Not sure what the proper way to do this would be.

Hi @matt1432, many thanks for this pull request. I will quickly take a look at code, and test it. After that, I will address your comments regarding the naming convention, and making the leading slash optional.
Adding a line .set_default("base", "")? is a good idea, to set the base url to an empty string if not present in the config.json file.

Thanks @matt1432, I've addressed both points in my last commit. The baseUrl field in the config.json does not require a leading slash anymore. I've also renamed the base_url to bazarr_url and base to base_url to follow a nice naming convention in accordance with Bazarr.


Navigating between pages requires prefix and suffix slash (per Vite)

Docs say /page works but it needs to be /page/
https://vitejs.dev/guide/build.html#multi-page-app

Maybe peek into how SvelteKit handles this? They don't require the trailing slash. Also wonder if Vite still does, it's been a little while (maybe Cayo's Vite dep just needs to be updated).


added pool name to AzureClient.add_job()

The AzureClient.add_job() method is missing the pool_name argument. This should fix it

I created a couple more changes similar to this that included additional logic regarding the pool_name param. Those changes have been merged to master so I'll close out this PR.


marpa_g_symbol_is_start() behavior is counter-intuitive

In working #11 @rns noticed that the marpa_g_symbol_is_start() behavior is counter-intuitive.  I need to look into this.

@rns -- This is the fix.  It's makes the behavior consistent with the documentation, but since it is not bug-for-bug backward compatible, I bumped the version number in the commit following this fix.  That's a good idea anyway now that we are re-licensing.
I'll wait a bit to see if this looks OK to you, then close it.

@jeffreykegler -- the test now passes, so this looks OK and can be closed, thanks.


SubComponent click entire row instead of just the arrow

Hello,
I'm not sure how to allow clicking any part of a row will expand the subcomponent. I've been reading throught the documentation as well as some online articles but there isn't anything covering my specific requirement.
I've tried hooking into SubComponent and creating a div covering the entire row for onClick but that wasn't working for me either.
Thanks

You need to use getTrProps and provide an onClick handler for the entire row. getTrProps is a function that supplies you all of the information you'll need, including the viewIndex of the row.
In your onClick handler for the row, you will need to update and keep track of the opened and closed rows in your parent component and use the expanded controlled prop to send that model to the table. It is simply an object with keys that correspond to the rowIndex of the page and a value that can be truthy or falsey. eg.
{
  3: true,
  4: true,
  5: false,
  7: {
    2: true,
  }
}

The above object would result in rows 3, 4, 7 being expanded, including the 2nd sub row of the 7th row (if you have multiple nesting levels). As you can see, defining false for a row is possible, but not necessary as leaving it undefined is the same as being collapsed.
Hope this helps :)

Hi, I would also like to do that. I saw there is a onExpanderClick function. is there a way i can call it?
thanks

I know that is not the best approach, but this solution worked for me:
    onClickRow = (e) => {
        const row = $(e.target);
        $(row.parent().siblings())[0].

        const columns = [{
            Header: 'Tag Name',
            id: 'label',
            Filter: getSearchFilter(),
            Cell: item =>

                {item.original.label}

        }, {

For anyone considering implementing this, I recommend reconsidering.
By controlling the 'expanded' state in your component or store, you'll need to also handle sorting, the original expander button, and your custom click implementation.
The documentation says to use handleOriginal() but if you're calling onClick() from elsewhere, handleOriginal is not defined.
Further, it's difficult to tell if a row is already expanded because isExpanded is not passed to row when rendering Cell, only Expander.
Still working through this problem. Hope to post my complete solution if I don't backtrack before then.

I had a fairly simple table, but was able to achieve expanding rows on click with the following getTrProps change:
  getTrProps(state, rowInfo, col, instance) {
    return {
      onClick: (e) => {
        const { expanded } = state;
        const path = rowInfo.nestingPath[0];
        const diff = { [path]: expanded[path] ? false : {} };

        instance.setState({
          expanded: {
            ...expanded,
            ...diff
          }
        });
      }
    };
  }

@NathanCH have you managed to expand on row-click without having to completely control <ReactTable>?
I have a component created on top of  (to set some defaults, styles, etc.) which is totally un-opinionated in regards to whether ReactTable is controlled or not (i.e. if, somewhere, I need to use MyTable and control it, that's just fine).
The problem is that I need row-click-to-expand as the default behaviour.
This requires me to use getTrProps and control the state in MyTable PLUS take care of all cases and edge cases (probably via getDerivedStateFromProps)

Thanks for all the comments guys! They were super helpful. Just to follow up with a full solution -- here is the component that I built from these comments.
export class ExpandableReportTable extends React.Component {
  constructor() {
    super();
    this.state = {
      expanded: null
    };
  }

  expand_row(row) {
    var expanded = {...this.state.expanded};
    if (expanded[row.index]) {
      expanded[row.index] = !expanded[row.index];
    } else {
      expanded[row.index] = true;
    }

    console.log(expanded);
    this.setState({
      expanded: expanded
    });
  }

  render() {

    return (
      <ReactTable
        columns={this.props.columns}
        data={this.props.data}
        expanded={this.state.expanded}
        getTdProps={(state, rowInfo, column, instance) => {
          return {
            onClick: e => {
              this.expand_row(rowInfo);
            }
          };
        }}
        SubComponent={d => {
          console.log('sub component: ', d);
          return
boop!
;
        }}
      />
    );
  }
}

It toggles a row's expansion on click and renders a subcomponent of "boop"

@jpribyl your solution looks pretty good to me. without trying it out, i think that you should use the property viewIndex instead of index. afaik viewIndex takes sorting and filtering into consideration, whereas index does not. So you would use
expanded[row.viewIndex] and so on. Hope that helps


Unresolved compilation problem: org.apache.hadoop.shaded.com.google.protobuf.GeneratedMessage$Builder cannot be resolved. It is indirectly referenced from required .class files

Building an assembly from master and running with a local Hadoop 3.1.2, I ran into issues with the Master and Tserver.  The err log for both was the same
Exception in thread "tserver" java.lang.Error: Unresolved compilation problem:
	The type org.apache.hadoop.shaded.com.google.protobuf.GeneratedMessage$Builder cannot be resolved. It is indirectly referenced from required .class files

	at org.apache.accumulo.server.security.delegation.AuthenticationTokenSecretManager.<init>(AuthenticationTokenSecretManager.java:1)
	at org.apache.accumulo.tserver.TabletServer.<init>(TabletServer.java:426)
	at org.apache.accumulo.tserver.TabletServer.main(TabletServer.java:3260)
	at org.apache.accumulo.tserver.TServerExecutable.execute(TServerExecutable.java:43)
	at org.apache.accumulo.start.Main.lambda$execKeyword$0(Main.java:129)
	at java.lang.Thread.run(Thread.java:748)

So what is using that?
cd server/base
mvn dependency:copy-dependencies
cd target/dependency
jar tf hadoop-client-runtime-3.1.1.jar  | grep GeneratedMesage$Builder\.class
org/apache/hadoop/shaded/com/google/protobuf/GeneratedMessage$Builder.class

So this too looks like a problem with the runtime jar similar to https://bugs.eclipse.org/bugs/show_bug.cgi?id=541772
That jar and class are in the Hadoop install
cd $HADOOP_HOME
jar tf share/hadoop/client/hadoop-client-runtime-3.1.2.jar | grep GeneratedMessage$Builder\.class
org/apache/hadoop/shaded/com/google/protobuf/GeneratedMessage.class

The tserver process is not running, but the master is still running even though the monitor can not connect to it.  So I can check that jar is on the classpath.
jcmd | grep master
9597 org.apache.accumulo.start.Main master
jcmd 9597 VM.system_properties | grep ^java.class.path | tr ':' '\n' | grep runtime
HADOOP_HOME/share/hadoop/client/hadoop-client-runtime-3.1.2.jar\
HADOOP_HOME/share/hadoop/client/hadoop-client-runtime-3.1.2.jar\

It is there, but why twice?
I do not have protoc installed but I don't think that is the issue.

Does all this work with 3.1.1?

HADOOP_HOME/share/hadoop/client/hadoop-client-runtime-3.1.2.jar

Is some config missing a a $?   Should HADOOP_HOME be $HADOOP_HOME?

Does all this work with 3.1.1?

I can test that.  Do you know of a change between 3.1.1 and 3.1.2?

Is some config missing a a $? Should HADOOP_HOME be $HADOOP_HOME?

No, HADOOP_HOME is my edit.  I was a full path on my filesystem

Does all this work with 3.1.1?

I can test that. Do you know of a change between 3.1.1 and 3.1.2?

No. The default build uses 3.1.1. Since I haven't seen this issue, I'm trying to determine if the problem is your setup, or a change in Hadoop. I've recently tried 3.1.1, and 3.2.0 and have not encountered this problem.

No. The default build uses 3.1.1. Since I haven't seen this issue, I'm trying to determine if the problem is your setup, or a change in Hadoop. I've recently tried 3.1.1, and 3.2.0 and have not encountered this problem.

K, good to know it worked for you with 3.1.1.  I'll try that

No. The default build uses 3.1.1. Since I haven't seen this issue, I'm trying to determine if the problem is your setup, or a change in Hadoop. I've recently tried 3.1.1, and 3.2.0 and have not encountered this problem.

K, good to know it worked for you with 3.1.1. I'll try that

Hadoop 3.1.1 is having the same issue.  I will keep digging

Is this only in Eclipse, or is this when compiling from the command-line also? What OS/platform/JDK? Do you have steps to reproduce?
Have you tried running with https://github.com/apache/fluo-uno/ or https://github.com/apache/fluo-muchos/ ?

No IDE, just mvn clean package on master and running from the build tar.gz.
I do not have protobuf installed, but I can't see how that would be the issue.  I see the runtime jar being loaded, something weird is happening.
Going to try some different things, like building 1.9.3 and running against that.  Mostly just wanted to document.
Thanks @ctubbsii

Try cleaning out your local maven repository, like rm -rf ~/.m2/repository/org/apache/{hadoop,accumulo}

1.9.2 ran fine on Hadoop 3.1.1 after I tweaked the bin/accumulo script to load jars from HADOOP_HOME/share/common/lib on the classpath.  Did run into one issue with bootstrap_config.sh that I will document, but not this issue.
~/.m2 was empty when I built, so I don't think that is it.

FWIW, the workaround for https://bugs.eclipse.org/bugs/show_bug.cgi?id=541772 is to ensure hadoop-client-runtime is on your compile-time class path. This indicates that perhaps hadoop-client-runtime isn't on your runtime class path for running the tserver.
You will probably need to edit CLASSPATH in your conf/accumulo-env.sh script. By default, that script puts ${HADOOP_HOME}/share/hadoop/client/* on the CLASSPATH, but that may not be applicable to your installation.

I am unable to replicate now, not sure changed but I am guessing it is on my system.  Closing.

These items were not used in the code at all, and should not have been required for compilation error marker occurred in the editor on the first line of the file. Again, this class had no compile-time references to this class is only used within the runtime library. Read more: BigData Hadoop Training in Delhi


Add hash functions for id's

Id's currently have no string representation expressions.  The base64 function on ID should be used to string rep.  Two flavours are needed:  (base, long, long, long....) and (struct)
#9 introduced an as_uuid filter unwrapper and the same should be done for these functions

dupe of #10, github rejected but added twice


Reenabling unit tests for ROCm

An upstream of https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/pull/2061
This reenables a number of unit tests or subtests which were disabled for ROCm but were passing, or which could be fixed with minimal effort.

Hi @jurahul / @frgossen Can you please review this PR ? Thank you!

Hi @ekuznetsov139 Can you please check @frgossen's comments  and keep us posted? Thank you!


(feature) Introduce concept of flag set

Requirements
As of today, GO Feature Flag is evaluating flag differently for client and server evaluations.

In the client-side, we are evaluating the flags in bulk, and we are keeping the evaluation responses in memory for the duration of the application.
In the server-side, we are evaluating the flags 1 by 1, and we are not keeping the evaluation responses in memory (except if a cache is configured).

In both cases having a flag set could be beneficial, for performance reasons, but also for organization reasons.

A PR is open for the specification https://github.com/thomaspoignant/go-feature-flag/pull/2734


Problem with FAQ entry hc_prefix_invalid / hc_invalid_prefix / redirects

Where to find the issue

https://www.coronawarn.app/de/faq/#hc_prefix_invalid
https://www.coronawarn.app/en/faq/#hc_prefix_invalid

Describe the issue
The iOS app links to https://www.coronawarn.app/en/faq/#hc_prefix_invalid, which was deleted and a redirect was added to https://www.coronawarn.app/en/faq/results/#eu_dcc. This means, currently, users of the iOS app do not see any helpful information in the iOS app if there is an error with the certificate scanning.
Under Android @MikeMcC399 opened https://github.com/corona-warn-app/cwa-app-android/issues/5099.
Suggested change
There are two ways this issue could be fixed: Restore the old behavior of the FAQ or adapt the apps.
Relaxed issues

https://github.com/corona-warn-app/cwa-app-android/issues/5099
https://github.com/corona-warn-app/cwa-app-ios/issues/4463

Corresponding iOS issue: https://github.com/corona-warn-app/cwa-app-ios/issues/4461

@dsarkar Are you fine with me providing a PR for this change?

@Ein-Tim
Why do you think #hc_invalid_prefix has been deleted?
Are you having problems displaying https://www.coronawarn.app/en/faq/results/#hc_invalid_prefix ?

(In any case #eu_dcc would be the wrong URL for troubleshooting.)

@MikeMcC399 Ah, the problem is a different one:
The iOS app links to https://www.coronawarn.app/de/faq/results/#hc_prefix_invalid, while the correct entry is https://www.coronawarn.app/en/faq/results/#hc_invalid_prefix.
So this is a problem which should be fixed on iOS side, I guess?

This is a problem in the iOS app and should be solved there.

@Ein-Tim
I will take a look tomorrow. I'm not sure whether the app or the website needs changing. I would also look at the old web and find out whether the link was broken there.

@MikeMcC399
Thanks, I quickly looked at it myself. Using the old-faq of your fork of the cwa-website repository, I see that the anchor always was hc_invalid_prefix and not hc_prefix_invalid.
See:
https://github.com/MikeMcC399/cwa-website/blob/8a841ee08a3a76fd2b758f3fb36ff24da105a3ef/src/data/faq.json#L228

@Ein-Tim
I suggest you re-open this issue or open a new one.
The issue is not that #hc_prefix_invalid was deleted, but that there is a mismatch between the iOS / Android app links and the website. (Sorry I didn't notice that in my initial reply.)
My suggestion for resolution, since it affects both iOS and Android, would be to change the id of the FAQ article from hc_invalid_prefix to hc_prefix_invalid on the website which would match the internal error code HC_PREFIX_INVALID.
Then add an FAQ redirect from hc_invalid_prefix to hc_prefix_invalid just in case it has been bookmarked elsewhere.
That would require no change to the apps and would be quick to implement.

@MikeMcC399
No reason to apologize, we both missed the real reason why the link is not working first.
I will provide a PR as @MikeMcC399 suggest, if I get a GO from @dsarkar.
Thanks for your help here and elsewhere Mike, appreciate it!

@dsarkar Could you let me know if the change @MikeMcC399 suggested would be approved? I'd like to provide a PR for this.

@Ein-Tim @MikeMcC399 Thanks for analysing this issue. PR will be appreciated very much and accepted!

PR https://github.com/corona-warn-app/cwa-website/pull/2796 created.

@dsarkar / @Ein-Tim

The change was introduced on Feb 1, 2022 with https://github.com/corona-warn-app/cwa-website/pull/2373

hc_prefix_invalid was renamed to hc_invalid_prefix
and
hc_prefix_invalid was redirected to eu_dcc where it remains today
This needs to be reviewed in the context of the FAQ site reorganization, whether it is still the right construction.

@Ein-Tim
The statement in the title of this issue is incorrect.
"FAQ entry hc_prefix_invalid deleted without redirect added"
https://github.com/corona-warn-app/cwa-website/blob/6af1b6b1ce70f9d705e7f79657a811ea0ff5d0ba/src/data/faq_redirects.json#L6
hc_prefix_invalid redirects to eu_dcc

This means the iOS app is currently linking to eu_dcc which seems to be the wrong place to link to if a certificate is already registered / a certificate is invalid, etc.

@MikeMcC399 @Ein-Tim I see: I remember why that was done. There is the inconsistency between Android and iOS, so we put the error message articles on top of the "certificated" eu_dcc section. In the meanwhile this got "lost" ...

Sorry, I don't understand this anymore and won't follow up on this anymore. I think the app code needs changing to fix this mess, but I don't think this should be done from the community.
Please close this issue if you want to open another one so that the real issue can be tracked in a clean issue. I'm closing my PR now.

@dsarkar
You probably should review with the iOS and Android developers. Especially due to the split in the FAQs between App Features and Troubleshooting.
@Ein-Tim
You and I may have made some incorrect analysis in these steps, but thanks to your efforts an overall issue has been identified. Well done for that! 👏🏻

@MikeMcC399 @Ein-Tim Thanks to you both. I understand the best solution would be to adapt the link in the iOS app to be the same as in the Android app. Will try to push that forward.

Thank you very much @dsarkar. I created an issue in the iOS repo of this: https://github.com/corona-warn-app/cwa-app-ios/issues/4463

@dsarkar

I understand the best solution would be to adapt the link in the iOS app to be the same as in the Android app. Will try to push that forward.

The link in the Android app #eu_dcc does not give the desired result. See issue https://github.com/corona-warn-app/cwa-app-android/issues/5099
If your suggestion is to use #hc_already_registered in both iOS and Android, that would probably make sense.

@MikeMcC399 The problem is that the iOS app currently only has one link for all problems, so currently a link to https://www.coronawarn.app/en/faq/results/#support_certificates makes the most sense under iOS, for all errors OR my enhancement request https://github.com/corona-warn-app/cwa-app-ios/issues/4463 gets implemented and iOS is aligned to Android.

@Ein-Tim
Thanks for pointing out the differences between iOS and Android! The developers will need to put their heads together if there is to be a common solution.

@Ein-Tim
Do you think that a change is needed to the website? If not, then probably this issue should be closed. You already wrote in the header that this issue is out of date.

If this issue is closed, there is no other one open where this issue can be addressed. As I said in my comment above, I don't understand the situation anymore, so I can't follow up with another issue at the moment, sorry.
Maybe you could open a follow up issue in the documentation repository? Then I would close this one.

@Ein-Tim

For Android, I think the only issue is the one I described in https://github.com/corona-warn-app/cwa-app-android/issues/5099, however there has been no feedback on this issue and it is not mirrored to Jira, so I don't know what will happen to it.
For iOS, you opened the issue https://github.com/corona-warn-app/cwa-app-ios/issues/4463

I don't know either what an additional issue would be, so I cannot describe one at this time.

@MikeMcC399
I'm unsure how to proceed here. IMO it's really important that this get's fixed, and I only opened an enhancement request and no bug report. I would like to wait for feedback from @dsarkar here. I hope that's ok for you @MikeMcC399!

@Ein-Tim
I need to wait for feedback on https://github.com/corona-warn-app/cwa-app-android/issues/5099 so I guess waiting is OK for now.

@MikeMcC399 Okay, thanks! Enjoy your weekend!

@Ein-Tim
Your title says "Problem with FAQ entry hc_prefix_invalid / hc_invalid-prefix / redirects"

#hc_prefix_invalid redirects to #eu_dcc

hc_invalid-prefix seems to be a typo and probably hc_invalid_prefix is intended

#hc_invalid_prefix is not a redirect. It is the direct anchor of an article "Error 'HC_PREFIX_INVALID'"

I am still unclear how you want to handle this issue and what exactly you think the issue is.

There has been no concrete feedback on https://github.com/corona-warn-app/cwa-app-android/issues/5099

@MikeMcC399
The current problem I see: The iOS app links to https://www.coronawarn.app/en/faq/#hc_prefix_invalid, which was deleted and a redirect was added to https://www.coronawarn.app/en/faq/results/#eu_dcc. This means, currently, users of the iOS app do not see any helpful information in the iOS app if there is an error with the certificate scanning.
Under Android you should know the problem, as you opened https://github.com/corona-warn-app/cwa-app-android/issues/5099.
There are two ways this issue could be fixed: Restore the old behavior of the FAQ or adapt the apps.
I left this issue open for visibility reasons. If you think I should close this issue, let me know (:

@Ein-Tim

I suggest you copy your text to the top of this issue (First and third paragraph) so it is clear what problem you see and what you expect could be done
You could also correct the typo in the title "hc_invalid-prefix" => "hc_invalid_prefix"
and leave the issue open

Will do so @MikeMcC399! Thanks & have a nice weekend!

This issue was never addressed, and I also don't expect it to be addressed anymore, as the CWA project went into ramp-down mode. I'm therefore closing this issue now.


微信如何回复图片或文件消息

微信如何回复图片或文件消息？say方法貌似只支持文本格式。

@dosu-bot 按照代码 import { FileBox }  from 'wechaty', 会报错 SyntaxError: The requested module 'wechaty' does not provide an export named 'FileBox'。貌似现在最新版中已经没有FileBox？该如何正确引入？

我只能说wechaty太强大了

🤖
Based on a similar issue in the Wechaty repository, it seems that you might need to instantiate FileBox from a specific instance rather than trying to import it directly from the 'wechaty' module. However, in the case of FileBox, it has been moved to a separate module called 'file-box'. You should import it from there instead. Here is how you can do it:
import { FileBox } from 'file-box';

This change is reflected in the Wechaty codebase where 'FileBoxInterface' is imported from 'file-box' instead of 'wechaty':
import type {
  FileBoxInterface,
}                         from 'file-box'

You can refer to this in the source code.
As for the reason behind this change, the changelog does not provide any specific information about the removal of the 'FileBox' class from the 'wechaty' module. There is a mention of a problem with FileBox instance type checking in the "Fixed bugs" section, but it does not indicate that the class was removed. Here is the related entry from the changelog:

FileBox instance type checking problem #2035

Without more specific information or context, it's not possible to definitively say whether the 'FileBox' class was removed from the 'wechaty' module. However, the change in the import statement should resolve the issue you're facing.
Sources

SyntaxError: The requested module 'wechaty' does not provide an export named 'UrlLink'
src/user-modules/message.ts
CHANGELOG.md

About Dosu

如何转发微信群聊中的图片信息呢?


Cannot be used with BSON library

Command
build
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
I want to integrate the bson library into the app, library repo https://github.com/mongodb/js-bson, but an error occurred during build.
I have searched those pages, it shows I can switch builder to @angular-devkit/build-angular:browser-esbuild to fix this error, but now it doesn't work.
https://github.com/angular/angular-cli/issues/26507
https://stackoverflow.com/questions/77287205/error-upon-importing-bson-library-saying-the-top-level-await-experiment-is-not
Minimal Reproduction
in the angular project folder and run:
bun add bson
bun run build

Exception or Error
=> bun run  build
$ ng build
Application bundle generation failed. [8.210 seconds]

✘ [ERROR] Top-level await is not available in the configured target environment ("chrome120.0", "edge120.0", "firefox115.0", "ios16.0", "safari16.0" + 5 overrides)

    node_modules/bson/lib/bson.mjs:204:26:
      204 │ const nodejsRandomBytes = await (async () => {
          ╵                           ~~~~~

error: script "build" exited with code 1

Your Environment
_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 17.3.0
Node: 22.0.0 (Unsupported)
Package Manager: bun 1.1.5
OS: darwin x64

Angular: 17.3.0
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, material, platform-browser, platform-browser-dynamic
... router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1703.0
@angular-devkit/build-angular   17.3.0
@angular-devkit/core            17.3.0
@angular-devkit/schematics      17.3.0
@schematics/angular             17.3.0
rxjs                            7.8.1
typescript                      5.3.3
zone.js                         0.14.4

Warning: The current version of Node (22.0.0) is not supported by Angular.

Anything else relevant?
No response

Duplicate of https://github.com/angular/angular-cli/issues/26507
Top level awaits are not supported and explicitly disabled as these can use a certain optimisations not to work correctly.

@alan-agius4 is there a way to make bson library work with angular?


MoM 19.05.2017

Participants: @Andrey9kin @buep @ewelinawilkosz2
Goal: Decide about the JenkinsAsCode's WoW and responsibilities
CloudBees may work on a similar solution but it doesn't seem like we can expect anything in the nearest future. We've decided to continue with JAC development/improvement
@ewelinawilkosz2 will be a Benevolent Dictator of JAC
@Andrey9kin will be a technical advisor
We agreed that the main focus should be now on defining efficient workflow for JAC implementation - many of us, who uses JAC for customers, already have made a lot of updates in general configuration scripts/properties files. There is a risk that we may end up with reinventing the same things couple of time because we don't know it was already made by someone in customer's repository (it has probably already happened). To avoid that we need an easy way to share our changes with others.
Separating "what" & "how" would help to achieve this goal.
One idea was to keep scripts in one common repository, instead of having copies in customer's repos. It would also make it much easier to upgrade customer's jenkins to version used in this repository.
It was also mentioned that documentation should be improved.
In upcoming weeks I will work on proposals:

how to split repository - common part (scripts), and configuration (properties)
workflow
how to introduce solutions already present in customers' repos
As a result we will have some new issues here.

Another topic was building a community around JAC, so far we decided that as a BD I am also responsible for that

@ewelinawilkosz2 great notes! Thanks

Contributed with #195, #196, #197 from my own personal notes so we don't forget. They are from this meeting here.


Quick fix resolve path on mixins

This fixes a bug that wasn't thought of which occurs when setting inductiva.working_dir to be a path outside the current working directory. For example,
inductiva.working_dir = "../some_path".
With this setting, the if to check if the directory name already existed was not working inside this new working directory, and was checking inside the local directory where python was being run.
By setting before the files.resolve_path(root_directory) before that if this bug is fixed.

LGTM. Thanks Ivan,
Maybe leave a more detailed description of the bug. Also helpful for QA later on

Done! Gonna merge anyway since we will do a large QA session later this week.


EF Plus stays FREE but now depend on EF Extensions

We have chosen to make Entity Framework Plus (EF Plus) dependent on Entity Framework Extensions (EF Extensions).
That’s a major decision since as most of you know, EF Plus is free and open-source, but EF Extensions is a commercial library.
Don’t worry, EF Plus will remain 100% free and will always be. We just added a dependency to be able to continue to provide good support to our libraries.
This dependency will be added in a few weeks.
Will EF Plus continue to evolve?
Yes, and faster!
In the past, we sometimes restricted ourselves to keep intellectual property inside EF Extensions. For example, TPC and TPT are already supported for Batch Update in EF Extensions but not yet supported in EF Plus. By adding this dependency, we can now easily add it to EF Plus.
Why this decision?
EF Plus has been very fun to create a few years ago, don’t get me wrong.
However, maintaining this library was not amusing at all since we had to support:

Different versions of Entity Framework
Different versions of Entity Framework Core itself!
Different versions of .NET Standard
Different versions of Database Provider
Many weird special cases 😉

EF Plus doesn’t use public API but mostly internal API that is subject to change from a version to another and hell, EF Core proved that’s true from a preview version to another! Our code now looks so messy and need some love with a big cleanup.
EF Plus has reached a point that we cannot close our eyes anymore about the maintaining cost.
What’s the cost of maintaining a free library?
EF Plus is indeed FREE for you, but that’s a money pit for our company ZZZ Projects.
Over the past 3 years, we answered more than 500 issues on GitHub and more than 1000 emails.
We invested way more than $300,000 USD in development and maintenance and received less than $1,000 USD in donations.
People usually make free library on their free time for fun and eventually stop supporting it to move to something else. However, on our side, we created EF Plus to show you can trust a free library that keeps getting supported over the years.
For example, simply upgrading EF Core 3.0 from a preview to the latest preview version took us more than 100h due to many internal methods modified. These hours have a cost as we need to pay developers to code it. (labor is not cheap in Canada)
Let be honest, adding a dependency to EF Extensions allow us to show our PAID library through our FREE offer (EF Plus). So, it gives us additional reasons and motivation to keep supporting EF Plus. Also, it allows us to reduce the cost to maintain both libraries.
Will EF Plus remain 100% Free?
YES, EF Plus continues to be 100% free and will always be!
Question or Comment?
Please let us know if you have any concerns.
We understand that not everyone will be happy with this decision, but we believe that’s the best decision for the future of EF Plus and our company.

First of all, thanks for announcing this upfront.
I have a few questions to clarify:

How exactly will EF Plus work "100% Free" with a dependency on a paid library. Will we be needed to have a license for the library once it becomes dependent on it even if we don't use the features from the paid library anywhere?
If it's not required to have a paid license - will we get the future updates even without the paid library?
If it is required required to have a paid license - is the Starter edition enough to keep the EF Plus running going forward? Or is it necessary to buy the whole Full edition? We're specifically interested in using it with EF Core (the Starter edition states that it requires EF 6).

Thank you @jasho for those questions.

Will we are needed to have a license for the library

No, you will not need a license.
EF Plus will use methods from EF Extensions that don't require a license. For example, the GetModel method in EF Extensions is way more complete than the light version in EF Plus.
We will make very clear in the documentation when a license would be required. For example, to improve performance when saving audit entries.

Will we get the future updates even without the paid library?

Yes, nothing changes. In fact, it now gives us more reason to keep EF Plus up to date.
We started to add some free features recently in EF Extensions such as ToSelfHierarchy and DeleteByKey which doesn't make sense if we have a free library.  By having this dependency, it now give us a reason to add future features such as Query Hint in EF Plus instead.
By improving EF Plus, we promote at at same time EF Extensions even if that's not required to make it works. So it will give us a motivation to keep creating features in EF Plus.
Let me know if you have more questions.

As a EF Plus (free version) consumer, in which way will be  I able to check: am I using free functionality or not?

will be I able to check: am I using free functionality or not?

That's a very good question.
We will add something such as EntityFrameworkManager.IsCommunity (we are not sure yet about the option name). When enabling, it will throw an error right away when using a paid functionalities.
At this moment, the only paid functionalities are:

BatchSaveChanges
BulkSaveChanges
BulkInsert
BulkUpdate
BulkMerge
BulkDelete
BulkSynchronize

All other methods are already free. It will be very clear in the documentation about what's free and what's not and we will make a comparative table like we did on EF Classic.

Why not do it the other way around, and let the commercial library depend on the free library? As far as I know, the commercial library has all the features of the free one plus more, so it would make more sense to reverse the dependency in my opinion. This way you'll also won't exposes premium functions to free users and have them throw exceptions during runtime.
Either way, what will happen to the batch operations from EF Plus (Update and Delete) and the operations from EF Extensions ('UpdateByQueryandDeleteByQuery`)? Or are they the same?

Hello @RudeySH ,

Why not do it the other way around, and let the commercial library depend on the free library

It could be an alternative but cannot happen for at least 3 reasons:

Intellectual Property
EF Plus doesn't use the full potential of the Model or some other method at this moment (just a light version of what exists in EF Extensions).
So if EF Plus doesn't depend on EF Extensions, we will need to continue to use those light versions as we don't want to disclose some private code.

Major Breaking Change
No one like breaking change.
Forcing people using free features seeing paid features is somewhat not cool, we understand it.
However, forcing paid customers to see free features is not cool either.
The choice of who should be impacted is an easy decision here.

Marketing
If we make EF Plus depend on EF Extensions, on the marketing side, it makes sense to hire a developer dedicated to EF Plus features, it makes sense to pay for better documentation. Every time we bring something, it now makes sense to add it to EF Plus since people at least see our paid library as well.
Otherwise, we will need to continue to add some free features directly in EFE such as: ToSelfHierarchyList or DeleteByKey that should have been added in EF Plus
Staying like we are in the moment just makes this project a money pit and hard for myself to continue to invest in it.
Ask to yourself: Will you invest 100k of your own money in the next year to improve EF Plus with almost no return on investment? Without a doubt, no one will answer yes to this question. I did it in the past 3 years, but I don't wanna longer unless the ROI makes sense.

As this is a big decision, I'm trying to be 100% honest and transparent in all my answers.
I hope you will understand this decision through it.

Hey sorry for reopening this, but I have an issue/question.
I use Z.EntityFramework.Plus.EFCore in my project. It says it is free and always will be. Still I have to download the latest version of the library every month in order to have my application working.
In the docs for the Extentions-library (https://entityframework-extensions.net/trial-period-expired-exception) I can see that this is due to no "free" license being available.
I assume this is the intended behavior in order to gently nudge more people into buying the full package? ( I am totally fine with this by the way!)
If not am I doing something wrong?

Hello @ZarPeter ,
No that's not intended to force people to download the latest version of EFE every month. If that's the case, that's for sure a mistake and we will fix it.
Are you using one feature such as BulkSaveChanges or BulkInsert which are not free?
I just made the test with a 5 months old version and didn't get any error when using DeleteFromQuery.
Do you have the full stack trace or know on which method our library is asking for the trial?
Best Regards,
Jon

Hey @JonathanMagnan,
many thanks for your reply! I just double-checked and I am 100% sure we are not using either feature.
We only use following operations:
DeleteFromQueryAsync
SingleInsertAsync
UpdateFromQueryAsync
Or is there any "hidden" usage of BulkSaveChanges or BulkInsert in there that I am not aware of?
Best Regards,
Robert

The issue is caused by this method: SingleInsertAsync.
We never announced it as a free or paid feature and it uses the same logic as BulkInsertAsync so, therefore, require a license at this moment (so currently a paid one).
I will speak with my team next week about what we should do with this situation and if we should make all single[Action] method free.

Hello @ZarPeter ,
Just to let you know, starting from the v5.1.10, all Single[Action] methods are now free to use (will only work with one entity, but you can call the method multiple times).
We will add some documentation about it very soon and announce that since versions released in 2021, those methods are free.
If you still have a problem, please open a new issue.
Best Regards,
Jon

Hello Jon,
many thanks for your reply and hard work! I am grateful for the news and am looking forward to see the change coming. All the best for you and your kin in 2021!
Best Regards,
ZarPeter
Von: Jonathan Magnan<EMAIL_ADDRESS>Gesendet: Mittwoch, 30. Dezember 2020 19:38
An: zzzprojects/EntityFramework-Plus<EMAIL_ADDRESS>Cc: ZarPeter<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [zzzprojects/EntityFramework-Plus] EF Plus stays FREE but now depend on EF Extensions (#510)
Hello @ZarPeterhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FZarPeter&data=04|01||811c4900362d4396760008d8acf1fc33|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637449502604382500|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=lpOHAvwKGy2Y86jsDbwGOjF3G5ltn7A16qLFHoIMz9U%3D&reserved=0 ,
Just to let you know, starting from the v5.1.10, all Single[Action] methods are now free to use (will only work with one entity, but you can call the method multiple times).
We will add some documentation about it very soon and announce that since versions released in 2021, those methods are free.
If you still have a problem, please open a new issue.
Best Regards,
Jon

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzzzprojects%2FEntityFramework-Plus%2Fissues%2F510%23issuecomment-752718561&data=04|01||811c4900362d4396760008d8acf1fc33|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637449502604392495|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=OAywHAX3CxlZSVkKhIH1CuMk2pUZyHNIF1PD8%2FETELs%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQ34B23OK4O7T6T3ELFL4L3SXNXPBANCNFSM4INXR7ZA&data=04|01||811c4900362d4396760008d8acf1fc33|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637449502604392495|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=kt8rYmea1%2FM23SwNyogVnj%2BA7OrLxRrdGJFz1ZuqvaQ%3D&reserved=0.

This thread convinced me to write stored procedures with user-defined table types instead of installing this package.
I'm not confident paying for the software would alleviate the likely future bugs from having to account for all of this.