Treejs LoadScreen and Trnsitions

This is just an idea and comments are welcomed.
I merged the two helper functions in playground.three.js but I'm not particularly proud of that.
Maybe  the place for this files is in plugins/threejs, with

three-helpers.js having those two functions (rename playground.three.js),
playground.three.js contains the render (rename playground.threestarter.js)
other files

Also, the css solution for transitions is flexible but has the nasty effect that css must be embedded in the js, otherwise the user must remember to include the css files, those files must be part of the distribution, etc. Any thoughts on that?

@TNick
Hiya, thanks for the contributions!
I am not very fancy adapting CSS transitions into a mainstream three.js distribution

CocoonJS does not support CSS
Shaders and direct graphics manipulations are more powerful than CSS

Nonetheless I don't have time to develop proper Three.js support now
My advice would be to put your vision of THREE support as a plugin that replaces Transitions, Renderer, LoadingScreen and etc that you find convenient.
I wouldn't be worried about putting css in separate files - the same concerns shaders anyway.
I would add transitions/ folder and implement app.loadTransitions("something") function that works in the same way as app.loadData
Also put one default css transition embeded straight into your plugin so something works even if you don't include any css files.

css
I see your points about css transitions.
Once I get the hang of three.js I will replace them.
folder
Ok, so a folder under plugins would do, then.
transitions
But the transitions are gonna be specific to the render that is used (at least in this case).
You mean to say that the render that is loaded augments the app object with a loadTransitions?
Or the application implements loadTransitions and deposits them in app.transitions to be later used by the render?
And I would allow each state to specify the transition to be used when entering that state with an option - say transition.
others
Also, I would move the canvas render to a plugin folder of its own for symmetry.

@TNick
others
I agree that CanvasQuery based renderer should be moved out of the main tree.
For readability I think we could go with renderers/canvas/ or plugins/renderers/canvas/ folder
transitions
var app = playground({

  create: function() {

    this.loadTransitions("slideDown", "fadeIn");

  }

});

app.loadTransitions would basically insert style loaded by XMLHttpRequest into DOM structure - however I still don't think it is a good idea to use CSS when u have WebGL at disposal - it's more up to you - and what your project needs tho.
css

Once I get the hang of three.js I will replace them.

I advise you to not create public code/libraries that are not outcome of real products. Write a little game (or a couple) - experience what works and then grant it to the public domain.
On the sidenote for THREE.js support - you see I am really struggling there - because I am not very experienced with it and I don't really know what's the standard for a professional game - do you want to have an camera object out of box, or multiple cameras and one renderer? That's why I've added the basic loaders and abandoned it.


Align versions for cudnn, clang-tools, cython, and doxygen with the rest of RAPIDS.

This PR aligns versions for wholegraph dependencies with versions used by other RAPIDS packages. This is needed for devcontainers, to make the unified RAPIDS conda environment solvable. See https://github.com/rapidsai/devcontainers/pull/191.

/merge


Microsoft Edge 18 and Internet Explorer 11 since build 17672 added Support for same-site cookies

https://blogs.windows.com/windowsexperience/2018/05/16/announcing-windows-10-insider-preview-build-17672/#206PHKJM9FkE5EtT.97 IDK for now but the proof is here. Both Edge18 and IE11 landed support for Same-Site cookies in B17672

Seems handled already months ago


Update link to Octane dependency injection docs

[x] Added or updated tests
[x] Documented user facing changes
[x] Updated CHANGELOG.md

Changes
I was trying to use https://github.com/nunomaduro/larastan/blob/master/docs/rules.md?rgh-link-date=2021-05-07T06%3A38%3A08Z#octanecompatibilityrule in a project, found some errors and followed the link. I then found that the docs has since been moved from the projects README.md to the Laravel docs website.
Breaking changes
No.

Thank you.

Thank you! Can you also change it here?

Thank you!

Released: https://github.com/nunomaduro/larastan/releases/tag/v0.7.6


Implement keepalive support

Please describe the change you are making
Teach containerssh about keepalive packets to avoid the logs being spammed by 'unknown global request logs'. Additionally, add settings for containerSSH to generate its own keepalives if necessary.
Are you the owner of the code you are sending in, or do you have permission of the owner?
Sent with permission of the owner.
The code will be published under the MIT-0 license. Have you read and understood this license?
Yes.

Squashed & signed, this needs a re-approval to be merged.


macOS guest support

The macOS license actually allows running macOS in a VM on Apple host hardware, which hyperkit would satisfy. I'm wondering what work would be required to enable that. Since quite a few people have figured out how to run it under qemu (with questionable licensing implications), it seems like there's probably enough FOSS code out there that HyperKit could take inspiration from to support macOS guests too.
I imagine the two biggest missing pieces are EFI emulation and the magic "don't steal macOS" blurb.

Oh, I guess this is sort of duplicating the follow-up discussion to https://github.com/moby/hyperkit/issues/19. I'll let maintainers decide if this is worth closing due to that ticket, but my inclination would be to track individual missing features rather than a big batch like in #19, since it's hard to decide when that ticket is "fixed".

A separate issue like this specifically for macos support seems wise.

Cool!  The other stuff is probably all work that needs doing. It does look like they got it working without EFI unless I'm missing something that implies EFI in that command line.

On a quick scan:

-bios ~/OVMF.fd: This is the EFI firmware, not sure it'll work
-device usb-kbd -device usb-tablet: HyperKit does not have USB support
-device isa-applesmc: No idea what that is, but hyperkit does not have it
-device e1000-82545em: That's some e1000 network car which HyperKit does not support
-device ide-drive: Not sure this is in HyperKit either

Yeah, sounding like lots and lots of work 😄
Here's AppleSMC, FWIW: https://github.com/qemu/qemu/blob/master/hw/misc/applesmc.c. I think it stands for System Management Controller and controls various cooling and lighting options on Apple hardware, as well as containing the magic string that macOS checks for original Apple hardware.

For available permissively-licensed code, bhyve has an e1000 (aka 82545em) emulation, an XHCI USB controller emulation plus tablet device, and there is an out-of-tree IDE driver from a GSoC project.

did anything changed in this scope? can I virtualized macOS guest using hyperkit?

AFAIK, no one has been working on this. But you could try a recent version of qemu on macOS. In January or so, Hypervisor framework based acceleration was added.


feat(vfp): 677 pipeline to build dll

feat(vfp): 677 pipeline to build dll

feat(vfp): 677 pipeline to build dll (#723)


WSL-Terminal dir on run

How can you set that WSL-Terminal is positioned in /home/$USER directory, instead of its installation dir?

you can use 4-create-start-menu-shortcut.js in tools directory.


Loan created with wrong start and end date

https://catalogue.library.cern/backoffice/loans/575cg-ts426
https://catalogue.library.cern/backoffice/loans/b8ejm-esr37

Other example.
https://catalogue.library.cern/backoffice/loans/wf4h0-1ew90
The loan was done just before the checkin.
The loan date is correct, but the checkin date is marked as 2021-04-28

Another case happened this morning: the loan date is 28/04/2021, but the loan request was created on 06/05/2021.
See the screenshot:


[full dmmf] make sure tests pass & remove old stuff

This is invalid and just done in each individual task.


Enhance Dark Mode Implementation

📘 Description

The current dark mode implementation works well but can be improved to simplify maintenance and provide a more customizable experience. By adopting the shadcn/ui approach, its components will automatically adjust to dark mode and allow users to choose between their personal preference or the system/browser setting.

🔢 Steps

Replace the current dark mode logic with the approach outlined in the official shadcn/ui documentation.
Ensure that the change is applied correctly in both light and dark modes, according to the user's selected preference.

✅ Acceptance Criteria

The dark mode logic has been successfully replaced with the shadcn/ui approach.
All components and pages work correctly in both light and dark modes according to the user's preference.

🌎 References

Official shadcn/ui dark mode documentation

📜 Additional Notes

If the filters don’t display correctly in dark mode, don’t worry. These issues will be addressed in future improvements.
Blocked by: #54

⚠ Do not apply until the ODHack begins.
⚠ Read our guidelines before applying.

Could I take on this issue?

Hello @danielcdz, I’d love to work on this issue as I have strong experience with front-end development.
My Approach:

I will replace the current dark mode implementation with the shadcn/ui approach as outlined in the official documentation.
This will ensure that all components automatically adjust to light or dark mode based on the user's preference or system settings.

Please assign this to me, and I’ll deliver an efficient and secure PR within 12-24 hours.

Hi, I am a proficient blockchain developer, expert in Cairo, Rust, Solidity, Aptos, and web development. I have contributed to various projects like Chainevents and Arkprojects etc .
Please assign this issue to me.
Thank you!


[QPPSF-11661] [DEVOPS] Codebuild Build status Slack notifications

Information

Fixes #_.
QPPSF-11661

Changes proposed in this PR:

Added Slack notifications to Codebuild Buildspec yml

Checklist

[ ] All JUnit tests pass (mvn clean verify).
[ ] New unit tests written to cover new functionality.
[ ] Added and updated JavaDocs for non-test classes and methods.
[ ] No local design debt. Do you feel that something is "ugly" after your changes?
[ ] Updated documentation (README.md, etc.) depending if the changes require it.

There's an issue with Snyk on this. Can you take a look into this @rajkpammi ?

Nevermind, I found the issue and will fix it in another PR.


Add Network.Name to IpAddress

This PR adds the optional field ipAddress.Name, which is read and written as an optional field in ContainerInfo.NetworkInfo.Name.
This branch successfully builds but fails to pass the existing tests, presumably because I am incorrectly reading and storing the nullable string from the protobuf.
Not looking to merge this until the first commit (bump to Mesos 1.0.0 protobufs) is mainlined through the official mesos-utils build system. But am looking to get this working ASAP as early access to CNI plugins. Can anyone provide some scala-foo for what I may be doing wrong?

Some sample test failures:
- BuildIfMatchesWithIpAddress *** FAILED *** (6 milliseconds)
  0 was not equal to 1 (TaskBuilderTest.scala:588)

- BuildIfMatchesWithIpAddressAndCustomExecutor *** FAILED *** (6 milliseconds)
  0 was not equal to 1 (TaskBuilderTest.scala:639)

- BuildIfMatchesWithIpAddressAndDiscoveryInfo *** FAILED *** (4 milliseconds)
  0 was not equal to 1 (TaskBuilderTest.scala:694)

- ConstructFromProto with default proto *** FAILED *** (1 millisecond)
  IpAddress(Vector(),Map(),DiscoveryInfo(List()),Some()) did not equal IpAddress(List(),Map(),Discove
ryInfo(List()),None) (IpAddressTest.scala:97)

Cool, I was just missing one embarrassing line. This all seems to be working now. Is there any other work that needs to be done while we wait for 1.0.0 mesos-utils to drop? Presumably just:

tests
documentation

just merged this morning: https://github.com/mesosphere/marathon/commit/731b4d4ee7de2e48417c7b4a7833a6050e0b898a
if this meets the need, can we close this out?

@djosborne is the feature merge provided by jdef sufficient?  can we close this?

@kensipe I built from master last week after it was merged and was unable to get a task to launch with CNI. I will retry with latest master and close if it works, or post debug info if it does not.

Just got this working. The network names that have been added are sufficient for CNI for Mesos tasks.
FYI I was running into an issue where Marathon was complaining that 1.0.0 was compatible because of 0.28.0. Looks like the main Dockerfile installs Mesos 0.28.2, whereas Dockerfile.development correctly installs 1.0.0-rc1. I can raise an issue if this is not being tracked

@jdef Just launched a Docker task on a Docker UDN using the new Api. All worked as expected. Nice!

Is there a plan to support the labels field mentioned in http://mesos.apache.org/documentation/cni/?

@jkidambi That's currently supported. Marathon's ipAddress.labels field gets pushed into Networkinfo.labels. More info here: https://mesosphere.github.io/marathon/docs/ip-per-task.html

@djosborne Thanks. I did figure that out after I posted that question, and have been able to successfully test it end-to-end.

@djosborne Is there a way to specify multiple networks per container? I'm not seeing a way to do that. If there is a better place to post such questions, I'll do so.

@jkidambi I don't think there is currently. I think since configurable networking for Mesos is a relatively new concept, use cases for multi-network tasks hasn't been clearly ironed out yet, and there's not a lot of support for it yet.
(Also note that though there's a "Mesosphere member" label next to my name, I am not employed by Mesosphere, and don't maintain any of their software - I work on Project Calico)


Incomplete document

The document references doing the compression ONLINE or OFFLINE but finding the syntax for using that option is not trivial to find or understand.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9b4d1b7c-15c8-6671-9b5e-78ff189b354a
Version Independent ID: 5c12ec62-94f5-7a43-04e5-026b09ac2538
Content: Enable Compression on a Table or Index - SQL Server
Content Source: docs/relational-databases/data-compression/enable-compression-on-a-table-or-index.md
Product: sql
Technology: performance
GitHub Login: @WilliamDAssafMSFT
Microsoft Alias: wiassaf

@jeananns1 -- thank you for your feedback.  Please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@WilliamDAssafMSFT -- William, please look into this issue.

@jeananns1 -- thank you for your feedback.  Please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@WilliamDAssafMSFT -- William, please look into this issue.

Thanks @jeananns1 for contacting Microsoft with feedback about our product documentation. Depending on the complexity, it could take from a few business days to a few weeks to look further into your question, issue, or suggestion. Thanks again for submitting your feedback. Your suggestions help improve our documentation.

Thanks @jeananns1 for contacting Microsoft with feedback about our product documentation. Depending on the complexity, it could take from a few business days to a few weeks to look further into your question, issue, or suggestion. Thanks again for submitting your feedback. Your suggestions help improve our documentation.

#in-progress

#in-progress

Thanks @jeananns1 for your suggestion, a doc update is in flight.

Thanks @jeananns1 for your suggestion, a doc update is in flight.

#please-close

#please-close


Double definition of *RssMaxProcNumber

The *RssMaxProcNumber registry key is defined twice. It's either a redundancy or some other registry key should have been described instead of the second definition.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b99aa941-27c4-c5cd-386c-fa1f64ab828f
Version Independent ID: 23ccb092-56e8-8165-65f4-25bd2e3a983d
Content: Standardized INF Keywords for RSS - Windows drivers
Content Source: windows-driver-docs-pr/network/standardized-inf-keywords-for-rss.md
Product: windows-hardware
GitHub Login: @duncanmacmichael
Microsoft Alias: dumacmic

Ah, you have a keen eye @I-gor-C. Judging by the table below, it looks like that second definition is supposed to be for *NumRSSQueues. I've updated that, and the changes should be live later today. Thanks!


Save and Continue button should scroll to error summary (top of form) if there are errors with the form

As I user I want to know where my errors are on the page when I press save and continue. So that I can quickly identify the error and amend it.

As per GDS guidance here:
Error summary - https://design-system.service.gov.uk/components/error-summary/
Error message - https://design-system.service.gov.uk/components/error-message/
Those two examples are separated but here is an example (from GOV.UK) with both parts together:

Note: we do not reload the page to check for errors.

@enoranidi should we have page transitions? So, for example:

click the Save & Continue button
the screen transitions into a waiting/thinking state (perhaps an overlay with some fade in/out)
after a comfortable delay the screen transitions to the next page

If so then we could use this to have the user end up on the same page displayed from the top.
If not then I guess we just jump straight to the top of the page.

@YaaL Oh, so what happens then?
Perhaps a demo on your screen so I can make sure I am viewing the correct interactions for this ticket?

This appears to have been completed.

This appears to have been completed.


Linkage Error found while exposing getNotification in storage.

Build failed of  storage -138 due to linkage error :
SEVERE: Newly introduced problem:
(google-cloud-nio-0.120.0-alpha.jar) com.google.cloud.storage.contrib.nio.testing.FakeStorageRpc's method getNotification(String arg1, String arg2) is not implemented in the class
  referenced from com.google.cloud.storage.spi.v1.StorageRpc (google-cloud-storage-1.104.0.jar)

Solution:
https://github.com/googleapis/java-storage-nio/blob/df030b86e43dd8ea627b25e2ea7700510abf2ba3/google-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/testing/FakeStorageRpc.java#L632-L644
We have to override getNotification method  in FakeStorageRpc.java once  storage - 138 gets merged.
  @Override
  public Notification getNotification(String bucket, String notification){
    throw new UnsupportedOperationException();
  }

Addressed in #135


Make release.py its own CLI/script?

Maybe release a gist for now

gist available at https://gist.github.com/ewen-lbh/b83fe7e0abf451b4ad43716294db2fd3

See ewen-lbh/deliverit :)


Fix Spark-DL notebooks for CI/CD and update to latest dependencies

Changes:
Version updates:

Updated all examples to run with latest Triton (24.08), Tensorflow (2.17.0), and Torch (2.4.1), and match updated APIs.
Notable changes:

Using new .keras model format in Tensorflow wherever applicable
Added use of Torch-TensorRT inference locally and on Spark to PyTorch notebooks

Environment separation:

Updated README for instructions on creating separate environments for Torch/Tensorflow to avoid CUDA conflicts.
Separated Huggingface examples into _torch/_tf versions for environment separation and to demonstrate model interoperability.

CI/CD:

Included local Spark Session initialization to work with CI/CD pipeline. Confirmed this will not affect preexisting Spark sessions if the notebook is already running on a cluster.
Verified that all notebooks run error-free with jupyter nbconvert.

please help re-base on dev branches like branch-24.10, thanks
also cc @eordentlich to help for ML notebooks review thanks


based on older master

[test]

@dobbymoodge @stevekuznetsov so as i suspected, we are not testing these PRs on top of master.
compare my other PR which passed tests here:
https://github.com/openshift/jenkins/pull/305
both PRs are making the same no-op change, but this PR branch is based on an older version of master that had an issue w/ the jenkins plugin installer script which causes the test to fail.

From the test in this PR, thus is how we're grabbing the commit to test:
+ git fetch --tags --progress origin pull/306/head:pull/306
From https://github.com/openshift/jenkins
 * [new ref]         refs/pull/306/head -> pull/306
++ git log -1 --pretty=%H pull/306
+ commit_to_test=afbc94e8618f83e727f020ff5b5b808d81db3a0f

We then ran the tests like so:
+ vagrant test-origin-image --image jenkins --source openshift/jenkins --ref afbc94e8618f83e727f020ff5b5b808d81db3a0f

@stevekuznetsov well it's got the right commit, which isn't surprising from what i've seen, but it doesn't seem to have rebased/merged that commit on top of the most recent master correctly.

Or are you saying we're not merging the PR into master? If so, yeah, probably not. After trying to make that work and realizing vagrant test-origin-image didn't use the normal vagrant sync-$foo; vagrant test-$foo flow I just made the job work as it did before Rosie was involved.

@bparees @stevekuznetsov That look like the wrong commit to me, if I do git co $commit_to_test ; git diff origin/master I see more than just a no-op.

@dobbymoodge the commit is right, but the commit was not rebased on top of the latest master like it's supposed to be.

(or git merge isn't doing what we think it is when we merge the PR branch into the master branch)

@bparees Where does that $commit_to_test code come from, anyway? Don't you want to test the merge commit, not the one prior to it? That's why it's pulling the "old" master.

e.g. in this diagram, A is $commit_to_test, it comprises D and E
master comprises D, E, F, and G
H is A + current master, which is what should be tested
$commit_to_test is H-1
H-1 resolves to commit A, which has the new code but not the intervening commits F, G and H
       --------A  topic
      /         \
 D---E---F---G---H master

@bparees Where does that $commit_to_test code come from, anyway?

don't know. i'd expect this job to behave exactly like the origin job behaves, and the origin job always did a proper rebase onto current master.

Don't you want to test the merge commit, not the one prior to it? That's why it's pulling the "old" master.

yes.

i'd expect this job to behave exactly like the origin job behaves

Why? This was not how the job worked before Rosie, and barring some serious re-wiring of the Vagrant plugin, it will not work that way. I know we had mentioned that moving to Rosie could make PRs start to be merged before tests, but upon more investigation I found it was going to take too much work and opted to not change the job.

Also @dobbymoodge that diagram is totally not how we're grabbing the commit SHA to pass to the test. There's no merge. We're just looking at the head of the branch at the source of the PR.

Why? This was not how the job worked before Rosie, and barring some serious re-wiring of the Vagrant plugin, it will not work that way.

I guess i misunderstood what you were doing when you created the rosie job and updated the vagrant plugin.

I know we had mentioned that moving to Rosie could make PRs start to be merged before tests, but upon more investigation I found it was going to take too much work and opted to not change the job.

ok, i missed or forgot that.

Also @dobbymoodge that diagram is totally not how we're grabbing the commit SHA to pass to the test. There's no merge. We're just looking at the head of the branch at the source of the PR.

then what is all this?
Local merging pull request #306 for repo 'jenkins'
+ pushd jenkins
+ git checkout master
Already on 'master'
+ git checkout -b tpr_broken_test_bparees
Switched to a new branch 'tpr_broken_test_bparees'
+ git pull git@github.com:bparees/jenkins.git broken_test
From github.com:bparees/jenkins
 * branch            broken_test -> FETCH_HEAD
+ git pull git@github.com:bparees/jenkins.git broken_test --tags
From github.com:bparees/jenkins
 * branch            broken_test -> FETCH_HEAD
+ git checkout master
Switched to branch 'master'
+ git merge tpr_broken_test_bparees
+ git submodule update --recursive
+ popd

IIRC the previous behavior was that the Jenkins master would check out the PR branch and the HEAD SHA would be passed to vagrant test-origin-image

@stevekuznetsov no argument about the previous behavior (as provided by the github PR tester plugin), i just thought the automated rebase/merge into master before testing behavior was part of what we were getting when this was switched to be rosie based.

I guess i misunderstood what you were doing when you created the rosie job and updated the vagrant plugin.

Yeah, I started down that road but realized it would require a rewrite of that test code and bailed. I think I worked through this with Gabe, sorry that I did not adequately communicate this to you too.

then what is all this?

That code is doing the merge, locally, on the Jenkins master. That code is synced to the remote VM but the SHA you pass to the plugin overrides it anyway. I should clean up the job to not do the local merge + sync since it's unused.

i just thought the automated rebase/merge into master before testing behavior was part of what we were getting when this was switched to be rosie based.

Yeah, sorry for the misunderstanding. If the vagrant test-origin-image code followed the local-checkout, sync-$foo, and test-$foo pattern you would indeed get this. If you'd like to change the test, I've done the sync half so that would get you where you want to be.

That code is doing the merge, locally, on the Jenkins master. That code is synced to the remote VM but the SHA you pass to the plugin overrides it anyway. I should clean up the job to not do the local merge + sync since it's unused.

could we just change the SHA we pass to be the merge commit?

could we just change the SHA we pass to be the merge commit?

The vagrant test-origin-image code looks at the GitHub remote for the SHA, I think. The merge commit only exists locally.

Also @dobbymoodge that diagram is totally not how we're grabbing the commit SHA to pass to the test. There's no merge. We're just looking at the head of the branch at the source of the PR.

So we don't need the local_merge_pull_request line at all, but we do need to properly merge the PR against current master on the test instance, huh?

The vagrant test-origin-image code looks at the GitHub remote for the SHA, I think. The merge commit only exists locally.

oh. the way the origin stuff used to work was to merge locally and then sync the local repo over to the ec2 instance.  assumed something similar was happening here.  sounds like we're doing the merge(for no reason at this point) but not the sync.

@bparees @stevekuznetsov It looks like test-origin-image doesn't merge the PR, it just checks out the ref provided in $commit_to_test: https://github.com/openshift/vagrant-openshift/blob/master/lib/vagrant-openshift/command/test_origin_image.rb#L127
I seriously doubt this is the intended behavior...

We are doing the sync, I just can't say for sure Thad the code in vagrant test-origin-image will check it out correctly. Feel free to try.

note to self:
git fetch origin refs/pull/306/merge:my_new_branch; git checkout my_new_branch
does what we need.

I did some testing with /merge and it did not always do what we needed. Can't remember the specifics.

if all my rosie work has paid off, this [test] should pass now.

Nice

woot.  thanks for your help @stevekuznetsov


Providing additional custom elements to the Patient resource

Section Number https://profiles.ihe.net/ITI/PIXm/ITI-104.html#231044121-patient-resource-constraints 2:<IP_ADDRESS>.2.1 Patient Resource constraints
Issue
It is not clear if PIXm offers the ability to provide additional custom elements to the Patient resource (as FHIR extensions).
Proposed Change Explicitly state that additional elements to the Patient resource can be supported.
Priority:

Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.

https://github.com/IHE/ITI.PIXm/commit/4585181cfc60963483b90ccec66bd59502fed0af


BenchmarkGromovDensity

Add a function to benchmark a presentation with n generators, with density d at length l.

This function is currently called BenchmarkGromovDensity and has parameters

eps - the epsilon for the RSym tester
ngens - number of generators of the group
density - the desired density
length - the desired length.

The function prints how many relators it will pick.


Dialog scope does not show in JSON trace

The dialog object does not show in the JSON trace.

Version
4.7.0-preview-191208-1
Browser

[ ] Chrome
[ ] Safari
[ ] Firefox
[X ] Edge

OS

[ ] macOS
[ X] Windows
[ ] Ubuntu

To Reproduce

Set property dialog.test with value "test"
Run Bot
Click on the last trace and try to find the property dialog.test in the JSON output

Expected behavior

have the dialog properties show up so you can debug

This can not be reproduced on master branch.

Sorry hibrenda, latest version this is fixed.


Provide the GitHub token by default

This PR contains out-of-scope changes, so it can be another PR if necessary.

To be clear, it's just a new context for secrets.GITHUB_TOKEN. The fact that you can pass something like this to input by default is a useful hack that only the internal team knows :)


an operator file to allow setting the external URL value for prometheus.

The primary reason for adding this is to make the "source" link on alerts in Alert Manager take you to the web accessible URL for prometheus.
By default it tries to take you to a URL with the BOSH instance-group id of the prometheus node which isn't too helpful.

Thanks @m-richo!


test: update lambda callout migration snapshots

Description of changes

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request base (feat/replace-lambda-callouts@be9432b). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@                       Coverage Diff                       @@
##             feat/replace-lambda-callouts   #12787   +/-   ##
===============================================================
  Coverage                                ?   48.63%
===============================================================
  Files                                   ?      846
  Lines                                   ?    38263
  Branches                                ?     7821
===============================================================
  Hits                                    ?    18608
  Misses                                  ?    18061
  Partials                                ?     1594

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


How many DBs can follow?

If I have many dynamic to follow DBs (one per user), Any idea how many can follow? 10?100?10000?

depends on how many http connections your node process can handle and what async actions are then triggered from it. It also depends on how active these feeds are. From my experience running in production, I would definitely follow less than 100 in a single process but I would do some experimentation.

Oh thank you so much, I think the point is how much async is the process, so if I check the changes every two hours rather than all the time, doesn't matter how many DBs are.


DTZ007 - arguably a false positive

A not uncommon pattern to parse a date string to a Python date uses similar code to the below. Times/time-zones shouldn't matter.
Ruff: DTZ007 Naive datetime constructed using `datetime.datetime.strptime()` without %z
  |
1 |         # Parse the date parameter
2 |         try:
3 |             input_date = datetime.strptime(date, "%Y-%m-%d").date()
  |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ DTZ007
4 |         except ValueError:
5 |             print("Invalid date format. Use YYYY-MM-DD.")
  |
    = help: Call `.replace(tzinfo=<timezone>)` or `.astimezone()` to convert to an aware datetime

To summarize your request: It is about detecting the specific usage of datetime.strptime where the pattern is %Y-%m-%d) which is followed by a call to date().
I'm not a datetime expert, but I think this pattern, indeed, doesn't require time zone information. The main challenge I see is that detecting this usage consistently without surprises requires quiet involved analysis. E.g what about:
input = datetime.strptime(date, "%Y-%m-%d")
input_date = input.date()

What if there are multiple statements in-between? That's why I think using a noqa comment in this situation is probably fine.
To me, using DateTime.strptime over date.fromisoformat would express the intent more clearly. What's your reason for preferring strptime?

I think you are right. I had forgotten about date.fromisoformat.
(Although if the dates were in a different, non-ISO format, e.g. %d/%m/%Y, it's a bit more marginal).

(Although if the dates were in a different, non-ISO format, e.g. %d/%m/%Y, it's a bit more marginal).

That's fair. I think adding a noqa in this situation is reasonable. We may be able to do better once we have type inference and can guarantee that the value returned by datetime.strptime isn't used anywhere else other than for calling .date.


[Good First Issues]: implement function "extract_between_delimiters" - 7 points

Motivation
Vanus Functions are a series of pre-built functions worked within Vanus transformer. By choosing a function, users can specify the way that events will be changed.
It will be a good start if you decide to contribute to Vanus codes.
Details
Function name: extract_between_delimiters
args

sourceJsonPath – The name of an existing path.
targetJsonPath – The name of the new path to be created.
startDelimiter – A regular expression, indicating the character or characters that begin the delimited value.
endDelimiter – A regular expression, indicating the delimiter character or characters that end the delimited value.
..

Description
The function is used to extract value between the start delimiter and end delimiter from the source JSON path. Then assign the value to the target JSON path.
Extraction is base on the starting and ending delimiters.
Example
{
    "specversion" : "1.0",
    "type" : "com.example.someevent",
    "source" : "/mycontext",
    "subject": null,
    "id" : "C234-1234-1234",
    "time" : "2018-04-05T17:31:00Z",
    "comexampleextension1" : "value",
    "comexampleothervalue" : 5,
    "datacontenttype" : "application/json",
    "data" : {
        "appinfoA" : "Hi welcome to &&Vanus&",
        "appinfoB" : "efgs",

    }
}

After the function "extract_between_delimiters":
"pipeline":[
    {"command":["extract_between_delimiters","$.data.appinfoA", "$.data.appinfoC", "&&", "&"]}
]

The transformed event should look like this:
{
    "specversion" : "1.0",
    "type" : "com.example.someevent",
    "source" : "/mycontext",
    "subject": null,
    "id" : "C234-1234-1234",
    "time" : "2018-04-05T17:31:00Z",
    "comexampleextension1" : "value",
    "comexampleothervalue" : 5,
    "datacontenttype" : "application/json",
    "data" : {
        "appinfoA" : "Hi welcome to &&Vanus&",
        "appinfoB" : "efgs",
        "appinfoC" : "Vanus",
    }
}

How to implement

Fork the vanus repository.
Create a branch function-extract_between_delimiters
Create extract_between_delimiters.go under internal/primitive/transform/action/strings, and then implement the function.
Create extract_between_delimiters_test.go under internal/primitive/transform/action/strings for unit test.
Register your function in internal/primitive/transform/runtime/init.go.
Submit your PR

Contribution points
Each issue counts specific points based on its difficulty. Contributors earn the corresponding points if they solve that issue. Contribution points are used to describe the contributions contributors have made.  They can also be used to get rewards when there are community events.
This issue counts 7 points.
How to claim to solve the issue
If you want to implement this function, please leave a comment in this issue like:

I'd like to implement this function, please assign this issue to me.

Vanus community will assign the issue to you on time.

I don't have a lot experience with Go, but looking through merged PRs, I think I get the gist, and I really want to try to implement this function, please assign this issue to me.

Great I will assign this issue to you please also join our slack community for better future communication if any.


enh(r) Add operators and punctuation

This change adds highlighting for operators and punctuation, and fixes #3194.
Changes

Correct syntax highlighting for numbers adjacent to operators or at the beginning of the document
Remove incorrect declaration of -> as illegal
Add support for highlighting operators and punctuation
Update language definition to use v11 names (className => scope)

Unfortunately this introduces a slight regression, hence a draft PR: the auto-detection sample now fails for R, since <- is no longer used as a hint, instead it now has relevance 0 along with all other operators (without this, many languages incorrectly auto-detect as R, presumably since they don’t define operators).
Is there a way of adding an auto-detection hint for <- assignment without adding yet another variant to the two separate definitions of operators (L161 and L202)?
Also, is the formatting OK as it is? I’m no JS guy, and the linter I’m using is going slightly crazy, though it doesn’t seem entirely consistent in its complaints.
Checklist

[x] Added/updated markup tests, or they don't apply here because...
[x] Updated the changelog at CHANGES.md
[x] Fix failing auto-detection

Is there a way of adding an auto-detection hint for <- assignment without adding yet another variant to the two separate definitions of operators (L161 and L202)?

Does it really need to be in BOTH? Often spaces will be used and we'll match (and color it) either way with the number rule.. so perhaps the relevancy boost can only handle the "on it's own" case... in which case it's just 2-3 lines of code much like exactly what we had before.

Perhaps that would fix the auto-detect?

I’ll try!

Looking good!

Thanks for the patient review! There were a lot of details that required attention.

How does this kind of solution feel to the original look-behind problem?

It’s not too bad but of course there’s still quite a bit of duplication here. I also keep racking my brain whether I’ve missed a situation in which numbers are preceded by something other than operators and whitespace (I don’t think so).

It’s not too bad but of course there’s still quite a bit of duplication here.

I'm more interested in overall complexity than boilerplate.  Feels like a pretty clean solution overall I think.  Not perfect, but not ugly.

I also keep racking my brain whether...

Problem for another day. :-)


The top part of nvim-tree not visible

as you can see in the image below that the first line which shows the working directory is invisible until you move the cursor there

Yep, that's intentional. I added that to give it a cool, clean look to nvim-tree. You can make it visible in your personal config:
nvimtree = {
	enabled = true,
	show_root = true, -- set this to `true`
}

thanks for the reply, i tried your solution but unfortunately it didn't worked for me

is there something wrong with my config?
Thanks for your help

I'm also getting the same issue as described above, even with enabling show_root

The nvimtree setting does not seem to work, and this problem makes me sad


textarea: native attribute

Hello all,
This PR improve the usage of native attribute for the textarea with
v-bind="$attrs"

Thanks to that we can use native attribute (e.g: disabled, readonly...) into the BIMDataTextarea without using Vue props.
A note is added below the props explanation within the doc for textarea (and input) that explain the usage of $attrs
Paul

:tada: This PR is included in version 1.2.0-rc.17 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Feature]: Identify Perfect Forward Secrecy cipher suites

Should overlap with AEAD, but need to fine-tune the definitions.

DHE or ECDHE key exchanges are considered forward secrecy.
https://en.wikipedia.org/wiki/Forward_secrecy#Protocols

https://www.sectigo.com/resource-library/perfect-forward-secrecy

Fixed in the Go library in 8c5ad55.


Maintainer selection

we have all 3 group members now and this homework is shorter so i think we should do maintainer and task selection early. Who wants to be maintainer?

One of you can be the maintainer, just ask professor, I am fine with that. @JustinJaniszewski

And yes, you are correct, we should do it fast.

Hi all,
I can be the maintainer, no worries. I'll ask the professor now


Parse SOL_TLS control message, closes #2064

cf. #2064 - I've added the absolute minimum I need. We could swap that u8 with something more strongly-typed, but since I'm clearly the first person using ktls & the nix crate together, I'm treading lightly in terms of added lines.

@asomers twelve years later, the requisite changes have been merged into libc (and released to crates.io), so this PR now bumps the dependency and uses the constants from there.

@asomers is there anything I can do to help move this along? https://github.com/hapsoc/ktls/issues/24 has been blocked on it for a while (..mostly while waiting for libc to merge+release, but the ball's in nix's court now).

Update: I'm maintaining a fork of just this bit of nix now: https://crates.io/crates/ktls-recvmsg
(I'd like to deprecate that fork eventually)

Please see CONTRIBUTING.md on how to add changelog entries

Thanks!


Installation failed with existent cert-manager on EKS

Hi, I've installed the operator following this instructions, for environments with existent cert-manager(v1.14.4) implementation
https://github.com/zilliztech/milvus-operator/blob/main/docs/installation/installation.md#installation
helm install milvus-operator \
  -n milvus-operator --create-namespace \
  https://github.com/zilliztech/milvus-operator/releases/download/v0.9.13/milvus-operator-0.9.13.tgz \
  --set checker.disableCertManagerCheck=true

Issue
The pods are stuck on ContainerCreating

  Type     Reason       Age                   From               Message
  ----     ------       ----                  ----               -------
  Normal   Scheduled    5m49s                 default-scheduler  Successfully assigned milvus-operator/milvus-operator-6c88644565-klhpn to ip-10-30-4-20.us-west-2.compute.internal
  Warning  FailedMount  98s (x10 over 5m48s)  kubelet            MountVolume.SetUp failed for volume "cert" : secret "milvus-operator-webhook-cert" not found

ERROR
MountVolume.SetUp failed for volume "cert" : secret "milvus-operator-webhook-cert" not found
Should I create another resource, what part am I missing?
Thank you so much for your help.

As far as I can see, it is trying to mount a secret with a cert, but there is not such secret.
does the helm chart should create that resource? or should I create it?

@riosje The secret should be created by cert-manager in regular procedure. I doubt if the cert-manager is working correctly.
It seems very close to this issue https://github.com/milvus-io/milvus/issues/21961.
If you still can't solve it please provide me the logs of cert-manager.

@haorenfsa  To me it seems that currently the operator chart is broken. If you look in the deployment.yaml of the chart, it depends on the webhook-cert secret and tries to mount it as a volume: https://github.com/zilliztech/milvus-operator/blob/bd4dc2b1c10065dcd13d880b6774ee30ba58fcec/charts/milvus-operator/templates/deployment.yaml#L66
Problem is, the issuer and the certificate resources are not create by the chart. Instead there is a code in the operator, that tries to create it if it does not exist: https://github.com/zilliztech/milvus-operator/blob/bd4dc2b1c10065dcd13d880b6774ee30ba58fcec/pkg/provisioner/cert_manager.go#L116
Problem is, that code never gets executed because the operator pod never starts. So there is a circular dependency there.
I hope I am overlooking something but as far as I can tell the chart can't work as is.

related to https://github.com/zilliztech/milvus-operator/issues/132


Enable use of git submodules

We use git submodules for our puppet modules.
The following change together with passing -f and -t without leading 'origin/' makes it work.
This would obviously need cli params to enable git submodules and some clean code :-)
lib/octocatalog-diff/catalog-util/git.rb
      def self.create_git_checkout_script(branch, path)
        tmp_script = Tempfile.new(['git-checkout', '.sh'])
        tmp_script.write "#!/bin/bash\n"
        tmp_script.write "set -euf -o pipefail\n"
        # tmp_script.write "git archive --format=tar #{Shellwords.escape(branch)} | \\\n"
        # tmp_script.write "  ( cd #{Shellwords.escape(path)} && tar -xf - )\n"
        tmp_script.write "git clone --single-branch -b #{Shellwords.escape(branch)} . #{Shellwords.escape(path)} \n"
        tmp_script.write "( cd #{Shellwords.escape(path)} && git submodule init && git submodule sync  && git submodule update )\n"
        tmp_script.close
        FileUtils.chmod 0o755, tmp_script.path
        at_exit { FileUtils.rm_f tmp_script.path if File.exist?(tmp_script.path) }
        tmp_script.path
      end

FYI this is a major edge case since standard use is librarian-puppet, r10k, or code manager for this.

Thank you, i am very aware of that. Nonetheless, the change/addition to make this 'edge case work' is minor.

I think the best implementation here would be to template https://github.com/github/octocatalog-diff/blob/master/lib/octocatalog-diff/catalog-util/git.rb#L52-L62 into an ERB or a static file that uses environment variables, so it's easier to update the underlying script without having it being written out line-by-line.
I'm not at all opposed to supporting submodules here, but I won't really have a way to test it myself on a substantially large code base, since we use librarian internally at GitHub.

@zipkid please advise if you're interested in writing this code. If not I will probably have some time next week to make a preliminary attempt at it.

I am not sure i know how to write that.
We can certainly test it. We have, up to now 77 submodules in our puppet control repo.

Marked as in progress - I've started a branch to address this (and refactor a bit around how external scripts are run in general).


dotnet-sdk: Add Darwin support to dotnetCorePackages

This PR builds upon https://github.com/NixOS/nixpkgs/pull/73262 by adding Darwin support to DotnetCore

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Thanks for getting the ball rolling on this @reset. I realised the .NET SDKs in nixpkgs were Linux-only yesterday and started making my own change before finding this PR. Can I help at all to keep the momentum up?

#88750 solves this, closing


BTS-668 | List code, error, errorNum, errorMessage, and extra attributes for subsequent cursor batches

Backport of #15752

[ ] https://jenkins.arangodb.biz:3456/view/Documentation/job/arangodb-ANY-examples/1721/


Fix for missing locality in OpenCage reverse geocode responses

We've been using opencage as provider for quite a while now and only recently realised that in some cases the geocoder returns an empty string for City. After having contacted opencage, they told us, we should be using the field suburb whenever City, Town, Village, etc are empty. So here's the fix.
Since opencage uses the OSM format, but this (to the best of my knowledge) is opencage specific, I went for putting the "fix" in the specific geocoder, instead of fixing osm.Address.Locality().

Cheers!


Upgrade svelte-preprocess

Currently, installing sveld produced the following warning:
warning "sveld ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>

@metonym any chance this might be included in a new release at some point? 😄

@nowylie Sorry for the delay – published this in v0.19.1

No worries, thanks for the release (and working on Sveld)!


⚠ PrivateHD has degraded performance

In 2896995, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 3274 ms

Resolved: PrivateHD performance has improved in eddb52b.


build failure

I tried to build your project
but it fails
In file included from .piolibdeps/ESP Async WebServer/src/ESPAsyncWebServer.h:32:0, from src/api.h:6, from src/api.cpp:2: src/WiFi.h:39:5: error: 'AsyncWebServer' does not name a type AsyncWebServer& getWebServer();  // code-smell, we should think of a better way than to expose this inner reference when we need to register routes! ^ In file included from .piolibdeps/ESP Async WebServer/src/ESPAsyncWebServer.h:32:0, from src/api.h:6, from src/api.cpp:2: src/WiFi.h:40:5: error: 'AsyncWebSocket' does not name a type AsyncWebSocket& getWebSocketServer();  // code-smell, we should think of a better way than to expose this inner reference when we need to register routes! ^ src/WiFi.h:41:26: error: 'AsyncWebServerRequest' has not been declared bool isAuthenticated(AsyncWebServerRequest *request); ^ src/WiFi.h:42:33: error: 'AsyncWebServerRequest' has not been declared bool isAuthenticatedSession(AsyncWebServerRequest *request);

this full log (truncated more error after last line)
`platformio run -t upload
Processing nodemcuv2 (framework: arduino; platform: espressif32; board: nodemcu-32s)
LibraryManager: Installing id=346 @ 0.8.2
Downloading  [####################################]  100%
Unpacking  [####################################]  100%
LibraryManager: Installing id=305 @ ^1.1.0
Downloading  [####################################]  100%
Unpacking  [####################################]  100%
LibraryManager: Installing id=1826 @ ^1.0.0
Downloading  [####################################]  100%
Unpacking  [####################################]  100%
LibraryManager: Installing AsyncTCP
git version 2.17.1
Cloning into '/Users/skype/liam-esp/.piolibdeps/_tmp_installing-R41EOl-package'...
remote: Enumerating objects: 74, done.
remote: Counting objects: 100% (74/74), done.
remote: Compressing objects: 100% (46/46), done.
remote: Total 142 (delta 33), reused 63 (delta 28), pack-reused 68
Receiving objects: 100% (142/142), 50.10 KiB | 569.00 KiB/s, done.
Resolving deltas: 100% (60/60), done.
HEAD is now at d1f28ff Merge pull request #46 from atanisoft/patch-1
LibraryManager: Installing ESP Async WebServer
git version 2.17.1
Cloning into '/Users/skype/liam-esp/.piolibdeps/_tmp_installing-FoCSqC-package'...
remote: Enumerating objects: 1300, done.
remote: Total 1300 (delta 0), reused 0 (delta 0), pack-reused 1300
Receiving objects: 100% (1300/1300), 739.70 KiB | 880.00 KiB/s, done.
Resolving deltas: 100% (876/876), done.

The platform 'espressif32' has been successfully installed!
The rest of packages will be installed automatically depending on your build environment.

Dependency Graph
|--  0.8.2
|   |--  1.1.0 #d1f28ff
|--  1.1.0 #d1f28ff
|--  1.2.2 #b0c6144
|   |--  1.1.0 #d1f28ff
|   |--  1.0
|   |--  5.13.4
|   |--  1.0
|--  5.13.4
|--  1.0.3
|--  1.4.2
|   |--  1.0.1
|--  1.1.0
|   |--  1.0.1
|   |--  1.0
|--  1.0.4
|   |--  1.0.1
|--  1.0
|--  1.0
|   |--  1.0
|--  1.0
|--  1.0
|--  1.0
|--  1.1
|--  1.1.0
|   |--  1.0
|--  1.0
|   |--  1.0
|   |   |--  1.0
|   |--  1.0
|   |--  1.0
|--  1.0.1
|--  1.0
|   |--  1.0
Compiling .pioenvs/nodemcuv2/src/api.cpp.o
Compiling .pioenvs/nodemcuv2/src/battery.cpp.o
Compiling .pioenvs/nodemcuv2/src/configuration.cpp.o
Compiling .pioenvs/nodemcuv2/src/cutter.cpp.o
Compiling .pioenvs/nodemcuv2/src/definitions.cpp.o
In file included from .piolibdeps/ESP Async WebServer/src/ESPAsyncWebServer.h:32:0,
from src/api.h:6,
from src/api.cpp:2:
src/WiFi.h:39:5: error: 'AsyncWebServer' does not name a type
AsyncWebServer& getWebServer();  // code-smell, we should think of a better way than to expose this inner reference when we need to register routes!
^`

It should build, I’ll try to clone out the project fresch when I get back from vacation. Maybe I have forgot to push something. Make sure you have the latest VSCode and Platform.io installed.

I update platformio and VSCto latest one
platformio --version
PlatformIO, version 3.6.7
VSCode Version 1.34.0
still no luck

I'm running:
VSCode: 1.36.1
PlatformIO, version 4.0.0
Espressif 32, version 1.9.0
Maybe you have not installed the "Espressif 32" library? Can you verify in PlatformIO?

As I know about Platformio it installs this library as a dependency
CONFIGURATION: https://docs.platformio.org/page/boards/espressif32/nodemcu-32s.html
PLATFORM: Espressif 32 1.9.0 > NodeMCU-32S

I also tried to remove ~/.platformio folder
and when run upload  it downloaded automatically and installed
PlatformManager: Installing espressif32
Downloading  [####################################]  100%
Unpacking  [####################################]  100%
espressif32 @ 1.9.0 has been successfully installed!
The platform 'espressif32' has been successfully installed!
The rest of packages will be installed automatically depending on your build environment.
PackageManager: Installing toolchain-xtensa32 @ ~2.50200.0
Downloading  [####################################]  100%
Unpacking  [####################################]  100%
toolchain-xtensa32 @ 2.50200.80 has been successfully installed!
PackageManager: Installing tool-mkspiffs @ ~2.230.0
Downloading  [####################################]  100%
Unpacking  [####################################]  100%
tool-mkspiffs @ 2.230.0 has been successfully installed!
PackageManager: Installing framework-arduinoespressif32 @ ~2.10002.190416
Downloading  [####################################]  100%
Unpacking  [####################################]  100%
framework-arduinoespressif32 @ 2.10002.190628 has been successfully installed!
PackageManager: Installing tool-esptoolpy @ ~1.20600.0
Downloading  [####################################]  100%
Unpacking  [####################################]  100%
tool-esptoolpy @ 1.20600.0 has been successfully installed!
CorePackageManager: Installing tool-scons @ ~2.20501.7
Downloading  [####################################]  100%
Unpacking  [####################################]  100%
tool-scons @ 2.20501.7 has been successfully installed!
Verbose mode can be enabled via -v, --verbose option
CONFIGURATION: https://docs.platformio.org/page/boards/espressif32/nodemcu-32s.html
PLATFORM: Espressif 32 1.9.0 > NodeMCU-32S
......
but still same error

also maybe espressif library must be installed separately?

Hmm, it has been a while since I set up my system from scratch, I'll try a
fresh install?
What OS do you run? So that I could try to mimic the installation. Maybe I
could improve the documentation in the process. ;-)
Have you done a "git pull" on my project to get the latest changes?
Den tis 16 juli 2019 kl 12:00 skrev faronov<EMAIL_ADDRESS>
also maybe espressif library must be installed separately?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/trycoon/liam-esp/issues/4?email_source=notifications&email_token=AAX744UZHWXHEL45NCR2GM3P7WL35A5CNFSM4H66HSUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ALLOA#issuecomment-511751608,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAX744SIWF5EDSHLC6T5DG3P7WL35ANCNFSM4H66HSUA
.

I use macOS 10.13 and 10.14
and of course, I use the latest git pull

also, keep in mind that platformio use home folder for storage libraries

do you have any news?
it still failed to build

Yes, sorry that I have left you waiting!
I have fetched my work Macbook and tried install the project, and I can reproduce the error.
I have found what is wrong and will push a fix during next day.

Done.


Cublic Splines works too slow

One of the reasons is that currently, we use Nx.solve which is roughly O(n^3), but for tridiagonal matrices, there is a linear algorithm that solves the problem.

We should add a triangular_solve to Nx perhaps?

Yes, absolutely. I'll work on that

For this particular case there is even faster algorithm (Thomas Algorithm) which is O(N) but general triangular solve that is O(N^2) will be also very helpful

We already have triangular_solve


Fix example "clear Input"

Removing a misplaced bracket

Current coverage is 93.04% (diff: 100%)

Merging #587 into master will not change coverage

@@             master       #587   diff @@
==========================================
  Files            11         11
  Lines           503        503
  Methods          15         15
  Messages          0          0
  Branches         90         90
==========================================
  Hits            468        468
  Misses           12         12
  Partials         23         23

Powered by Codecov. Last update 4b8baba...b0598d6

Thanks!


✨ Add BMO upgrade e2e test

What this PR does / why we need it:
Adds a simple BMO upgrade e2e test.
This test is very similar to the ironic upgrade test. So far they do not
really upgrade from an older version to the latest. Instead they upgrade
from no tag (latest) to main. So we at least see that it is possible to
rollout an upgrade.
The idea is to later make the tests start from an older release and upgrade to the latest.

/test-v1b1-e2e

/test-v1b1-integration

/assign @Xenwar

/approve


Add support for bots

https://boardgame.io/documentation/#/tutorial?id=bots

MCTS is not viable for Thinktank, and random play is not fun to play against


To bring ScalPBReadSupport par with parquet-proto ProtoReadSupport

This MR resolves #12, resolves #13
In this MR two methods were added to companion object of ReadSupport impl. ScalaPBReadSupport

scalapb.parquet.ScalaPBReadSupport.setScalaPBClass
scalapb.parquet.ScalaPBReadSupport.setRequestedProjection

Also some plumbing was modified per parquet-mr protobuf/avro to better reflect parquet-mr api usage.
How to use:
def readParquetAsRDD[T <: GeneratedMessage with Message[T]](inputDirs: Iterable[String],
                                                          projection: String,
                                                          maybeFilteringBinaryColumn: Option[BinaryColumn],
                                                          job: Job)(implicit tag: ClassTag[T]): RDD[(Void, T)] = {
    val vClass = tag.runtimeClass.asInstanceOf[Class[T]]
    val jobConf = new JobConf(spark.sparkContext.hadoopConfiguration)

    scalapb.parquet.ScalaPBReadSupport.setScalaPBClass(jobConf, vClass.getName)
    scalapb.parquet.ScalaPBReadSupport.setRequestedProjection(jobConf, projection)
    ParquetInputFormat.setReadSupportClass(jobConf, classOf[scalapb.parquet.ScalaPBReadSupport[T]])
    // Set a predicate and Parquet only de serializes the right ones ...
    maybeFilteringBinaryColumn.foreach(bc => {
      val filter = FilterApi.userDefined(bc, classOf[NotNullNotEmptyPredicate])
      ParquetInputFormat.setFilterPredicate(job.getConfiguration, filter)
    })

    val filteredRDD = spark.sparkContext.newAPIHadoopFile(inputDirs.mkString(","), classOf[ScalaPBInputFormat[T]], classOf[Void], vClass, jobConf)

    filteredRDD
  }

Unfortunately I did not have time to add any tests even though I have tested this change in my own project I work on currently and it works as expected.
Hopes this helps.

Wow, this looks great! Thanks! I hope I get to write tests for sparksql-scalapb at some point in the future, and I wouldn't want to ask anyone else to be the one who writes the first test, though in lack of tests, would it be possible for you to post here a complete minimal sbt project that uses this feature, so I'll port it into a test when the time comes? Including a little parquet file in that project is fine, or that project can write and later read.

Sorry that this has been standing open for so long. It looks however there is no demand for this functionality so I will close this PR. In the latest version of sparksql-scalapb it is easy to convert a proto RDD to dataframe and use that representation to save to parquet.


cassandra-spark sample update

@richagaur : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

#hold-off
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@richagaur : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@richagaur : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@richagaur : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Created azure-docs-pr https://github.com/MicrosoftDocs/azure-docs-pr/pull/204612. Closing this.


[PRoot]: carry some patches

see: https://github.com/AkihiroSuda/runrootless
and xattrs for rootless

PRoot is currently slow because seccomp acceleration has been broken with recent kernels.
(Tracked in https://github.com/proot-me/PRoot/pull/130 but seems still broken now)
So I'd suggest using rootless runc with SUID newuidmap tools.
(It requires my several PRs. review is welcome :penguin: https://github.com/opencontainers/runc/pulls?q=is%3Apr+is%3Aopen+label%3Arootless-containers)
At least, PRoot should be only enabled for apt/apk/yum commands.

cc @cyphar

FYI here is some benchmark result of PRoot https://github.com/AkihiroSuda/runrootless/issues/14

oh cool thanks so much for the info!


Remove black box dependency on nvidia-vkvideo-parser.dll

In order for this to serve as a useful example of how to use the vulkan video decoding APIs, I think it's most useful it it wouldn't include references to proprietary libraries. Since FFMPEG is already included as a dependency it might be more useful to use it to the parsing.

FFMPEG is a poison-pill for many projects due to the licensing, which can't be worked around easily due to this nv parser DLL being closed-source. I also think I will have to put my use of Vulkan Video on hold, perhaps permanently, due to this dependency.
The nv parser dll also still creates an unavoidable console window popping up, which I reported a long time ago and still isn't fixed. The combination of these factors makes it really kind of a disappointing sample, I agree. Closed-source dependencies defeat the entire purpose of open source software and vendor-agnostic APIs. I would also need to support other codecs such as VP9 for alpha channel or grayscale video formats but currently none of these are supported and there seems to be no easy way to do it myself. I've used FFMPEG before for realtime GPU-based video decoding and it wasn't that difficult to plug in to an OpenGL renderer to it (via DX <-> GL interop), and this is taking me way longer.
Please either make the nv parser dll open source or remote it as a dependency (which amounts to the same thing). Then we can fix all these issues including removing the dependency on FFMPEG entirely and just using the libs that it uses.
From what I understand with LGPL, anything that calls FFMPEG or modifies its source code needs to have its source published, so I'm not even sure if the closed-source nature of nv parser is even compliant. I've had to publish an FFMPEG code wrapper to github due to the aforementioned GPU decoder I worked on in 2016 to be LGPL compliant so I'm curious if the nv parser's source code is available or published somewhere. From what I understand, I believe it should be. In either case, it's very strange to make a public open source vendor-neutral video decoder where the meat of the decoding is hidden in closed-source dll. It's kind of mind-boggling to me.

Hi @Jasper-Bekkers, please have a  look at this thread by Lynne about using the FFMPEG parser with Vulkan Video:  http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2021-November/287683.html


Tensorflow cudnn integration status

With this issue I would like to track the efforts in integrating the
cudnn library within tensorflow.
As of June 17th 2016 doing a manual grep on the repository gives these
functions as being mapped from cudnn to the stream executor,
From chapter 4 of the cudnn User Guide version 5.0 (April 2016):

[x] cudnnGetVersion
[ ] cudnnGetErrorString
[x] cudnnCreate
[x] cudnnDestroy
[x] cudnnSetStream
[ ] cudnnGetStream
[x] cudnnCreateTensorDescriptor
[ ] cudnnSetTensor4dDescriptor
[ ] cudnnSetTensor4dDescriptorEx
[ ] cudnnGetTensor4dDescriptor
[x] cudnnSetTensorNdDescriptor
[x] cudnnDestroyTensorDescriptor
[x] cudnnTransformTensor
[x] cudnnAddTensor
[ ] cudnnOpTensor
[x] cudnnSetTensor
[ ] cudnnScaleTensor
[x] cudnnCreateFilterDescriptor
[ ] cudnnSetFilter4dDescriptor
[ ] cudnnGetFilter4dDescriptor
[ ] cudnnSetFilter4dDescriptor_v3 (versioned)
[ ] cudnnGetFilter4dDescriptor_v3 (versioned)
[ ] cudnnSetFilter4dDescriptor_v4 (versioned)
[ ] cudnnGetFilter4dDescriptor_v4 (versioned)
[x] cudnnSetFilterNdDescriptor
[ ] cudnnGetFilterNdDescriptor
[ ] cudnnGetFilterNdDescriptor_v3 (versioned)
[ ] cudnnGetFilterNdDescriptor_v3 (versioned)
[ ] cudnnGetFilterNdDescriptor_v4 (versioned)
[ ] cudnnGetFilterNdDescriptor_v4 (versioned)
[x] cudnnDestroyFilterDescriptor
[x] cudnnCreateConvolutionDescriptor
[ ] cudnnSetConvolution2dDescriptor
[ ] cudnnGetConvolution2dDescriptor
[ ] cudnnGetConvolution2dForwardOutputDim
[x] cudnnSetConvolutionNdDescriptor
[ ] cudnnGetConvolutionNdDescriptor
[x] cudnnGetConvolutionNdForwardOutputDim
[x] cudnnDestroyConvolutionDescriptor
[ ] cudnnFindConvolutionForwardAlgorithm
[ ] cudnnFindConvolutionForwardAlgorithmEx
[x] cudnnGetConvolutionForwardAlgorithm
[x] cudnnGetConvolutionForwardWorkspaceSize
[x] cudnnConvolutionForward
[ ] cudnnConvolutionBackwardBias
[ ] cudnnFindConvolutionBackwardFilterAlgorithm
[ ] cudnnFindConvolutionBackwardFilterAlgorithmEx
[x] cudnnGetConvolutionBackwardFilterAlgorithm
[x] cudnnGetConvolutionBackwardFilterWorkspaceSize
[x] cudnnConvolutionBackwardFilter
[ ] cudnnFindConvolutionBackwardDataAlgorithm
[ ] cudnnFindConvolutionBackwardDataAlgorithmEx
[x] cudnnGetConvolutionBackwardDataAlgorithm
[x] cudnnGetConvolutionBackwardDataWorkspaceSize
[x] cudnnConvolutionBackwardData
[ ] cudnnSoftmaxForward
[ ] cudnnSoftmaxBackward
[x] cudnnCreatePoolingDescriptor
[ ] cudnnSetPooling2dDescriptor
[ ] cudnnGetPooling2dDescriptor
[x] cudnnSetPoolingNdDescriptor
[ ] cudnnGetPoolingNdDescriptor
[ ] cudnnSetPooling2dDescriptor_v3 (versioned)
[ ] cudnnGetPooling2dDescriptor_v3 (versioned)
[ ] cudnnSetPoolingNdDescriptor_v3 (versioned)
[ ] cudnnGetPoolingNdDescriptor_v3 (versioned)
[ ] cudnnSetPooling2dDescriptor_v4 (versioned)
[ ] cudnnGetPooling2dDescriptor_v4 (versioned)
[ ] cudnnSetPoolingNdDescriptor_v4 (versioned)
[ ] cudnnGetPoolingNdDescriptor_v4 (versioned)
[x] cudnnDestroyPoolingDescriptor
[ ] cudnnGetPooling2dForwardOutputDim
[ ] cudnnGetPoolingNdForwardOutputDim
[x] cudnnPoolingForward
[x] cudnnPoolingBackward
[x] cudnnActivationForward
[ ] cudnnActivationBackward
[x] cudnnCreateActivationDescriptor
[x] cudnnSetActivationDescriptor
[x] cudnnGetActivationDescriptor
[x] cudnnDestroyActivationDescriptor
[ ] cudnnActivationForward_v3  (versioned)
[ ] cudnnActivationBackward_v3 (versioned)
[ ] cudnnActivationForward_v4  (versioned)
[ ] cudnnActivationBackward_v4 (versioned)
[ ] cudnnCreateLRNDescriptor
[ ] cudnnSetLRNDescriptor
[ ] cudnnGetLRNDescriptor
[ ] cudnnDestroyLRNDescriptor
[ ] cudnnLRNCrossChannelForward
[ ] cudnnLRNCrossChannelBackward
[ ] cudnnDivisiveNormalizationForward
[ ] cudnnDivisiveNormalizationBackward
[ ] cudnnBatchNormalizationForwardInference
[ ] cudnnBatchNormalizationForwardTraining
[ ] cudnnBatchNormalizationBackward
[ ] cudnnDeriveBNTensorDescriptor
[ ] cudnnCreateRNNDescriptor
[ ] cudnnDestroyRNNDescriptor
[ ] cudnnSetRNNDescriptor
[ ] cudnnGetRNNWorkspaceSize
[ ] cudnnGetRNNTrainingReserveSize
[ ] cudnnGetRNNParamsSize
[ ] cudnnGetRNNLinLayerMatrixParams
[ ] cudnnGetRNNLinLayerBiasParams
[ ] cudnnRNNForwardInference
[ ] cudnnRNNForwardTraining
[ ] cudnnRNNBackwardData
[ ] cudnnRNNBackwardWeights
[ ] cudnnCreateDropoutDescriptor
[ ] cudnnDestroyDropoutDescriptor
[ ] cudnnDropoutGetStatesSize
[ ] cudnnDropoutGetReserveSpaceSize
[ ] cudnnSetDropoutDescriptor
[ ] cudnnDropoutForward
[ ] cudnnDropoutBackward
[ ] cudnnCreateSpatialTransformerDescriptor
[ ] cudnnDestroySpatialTransformerDescriptor
[ ] cudnnSetSpatialTransformerNdDescriptor
[ ] cudnnSpatialTfGridGeneratorForward
[ ] cudnnSpatialTfGridGeneratorBackward
[ ] cudnnSpatialTfSamplerForward
[ ] cudnnSpatialTfSamplerBackward

Batch Normalization
Seems @lukemetz was working on it but has stalled for a bit https://github.com/tensorflow/tensorflow/pull/1759
What is the plan for the RNN ?
I know @wchan was working on a cpu version. I was trying to get a stub at using the cudnn version but from the comments in that thread seemed like @zheng-xq was working on it internally.
Can anyone comment on the status of these ops?
Other Questions

Any reasons why the Softmax functions are not being used ?
Would make sense to split the above list in chunks and create issues with contribution welcome, so external contributors can tackle them without duplicating internal work, or mark what google will be working on internally ?

I hope this helps in organizing the work around the cudnn and inspire the community to contribute. I will try to keep this issue up to date.

In general, TensorFlow prefers its own implementation on GPU, if the performance is close enough. This is because we would have the source code for customization. Conv is a good example where it would take a lot of effort to replicate Cudnn's performance.
There is still an ongoing investigation how TensorFlow would expose a fused RNN/LSTM implementations. The current Cudnn interface does not provide enough customization to accommodate common variations. In the mean time, it is possible that we can add a wrapper op in TensorFlow/contrib around the current Cudnn implementation, before we can decide what is the best way for long-term support in the TensorFlow core.

@zheng-xq How much of this policy is related to the blend effort of each framework to an API conformation on cudnn and how much to the control  of  kernels code from open source point of view?

@bhack, in case of LSTM, the biggest concern is lack of customization. In general, having access to the source code gives us better ability us to tweak our code to better serve TensorFlow users.
That said, we won't hesitate to pick any good functionalities from any library including Cudnn, if there is evidence showing a sizeable benefit.

Closing this tracking bug because it seems there is not a goal to map all cuDNN functions for reasons given by @zheng-xq. Please open separate issues to track specific missing cuDNN functionality.

@michaelisard Can you give me an estimated ratio between not satisfied API design and the closed source nature of cudnn that not attracted full coverage?

@zheng-xq can comment better than I can.

You can close. I was only curious.

I would be interested in having full support of the cuDNN library through the stream executor and all the goodies that comes with it. Expose all the endpoints in the cudnn layer and only few to the public layer.
@zheng-xq  did the problem with cudnnRNN got solved at the end? When I tried the wrapping I wasn't sure where to store the temporary variables required by the cudnn library.

@bhack, I don't think anyone sets a clear ratio. And it varies case by case for each op. For new ops, we firstly prefer a fast solution with source within reasonable amount of effort. If it takes a lot of effort to match the performance of Cudnn, or any other library, we would not hesitate to use that library. Overall, we go with the fastest solution. If the performance is about the same between our custom code and Cudnn, we prefer the one with the source.
@Mistobaan, we are working on adding a Cudnn RNN layer to tf.contrib. We will announce in the release note when it is done.


Bug: Motion Detection Stops working unless restart home assistant and camera

Describe the bug
A clear and concise description of what the bug is.
Motion Detection reporting only works before the server reaches a day, then stops reporting. If its not reporting, it won't trigger the wifi bulb.
Expected behavior
n/a
Log
No logs

**Using stream component**
yes
**Camera works through onvif component OR different cameras work in general**
yes - rtsp
**Camera has all attributes filled out properly in developer tools**
yes
**HASS Environment**
Raspberry pi 4

Duplicate of  https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/issues/84 .


Aspire Redis Commander setup issue

Describe the issue or suggestion
Hi
I was exploring Aspire by following a guide at https://github.com/csharpfritz/BigBadBlog/blob/main/docs/1-Introduction.md. However, when I try to add Redis Commander to Aspire, it seems like the port setup to Redis on the commander container is not correct? It refuses to connect to the Redis instance if I query inside the Commander.
Screenshot below:

Logs:

Are you using podman or docker?

I am using docker on linux. It also seems like the docker.host.internal is a windows thing?

maybe this is the root cause https://github.com/docker/for-linux/issues/264. Is aspire allow to set an external host like this?

@karolz-ms @danegsta - is using host-gateway possible when Docker Desktop is not installed?
@masonyc - is it possible to install Docker Desktop? I believe that will make this scenario work.

host-gateway without Docker Desktop still doesn't allow communicating to Aspire/DCP proxies because we bind to localhost only, but host-gateway uses a specific network interface/IP (and therefore won't resolve to localhost on the host machine). Docker Desktop implements a proxy to forward gateway traffic to localhost.

hi @eerhardt , thanks for the reply. Yes, installing docker desktop will solve the issue.

This isn't really a docs issue, and it seems like there's a work around. Can we close this?


Correct capitalizing

Capitalize only the first letter of the first word. Ex: Segunda-feira, 20 de jul
Monday, 20 de jul

Lowercase first letter of the date is found not only in pt/pt-br, but also in ru/ru-ru.


Failed to verify OTA update signature!

First of all, you published this tool exactly at the moment I was searching for an tool with these exact features. Thank you.
But I do get an error with it, see below, it's probably a stupid mistake on my side, but I can't quite figure this one out. If you can help out, that'd be appreciated.
Package: build/ota.zip
Certificate: /srv/android-build/resign-android-image/grapheneos-ota.pem
Package length:<PHONE_NUMBER>
Comment length: 1983
Signed data length:<PHONE_NUMBER>
Signature start:<PHONE_NUMBER>
Use SHA-256: True
Digest: eafbf513294e998e967bae2ec38e80a1264f199eca8d64379661e1cedbcf507a
RSA operation error
140027523401024:error:0407008A:rsa routines:RSA_padding_check_PKCS1_type_1:invalid padding:../crypto/rsa/rsa_pk1.c:66:
140027523401024:error:04067072:rsa routines:rsa_ossl_public_decrypt:padding check failed:../crypto/rsa/rsa_ossl.c:588:
Traceback (most recent call last):
  File "/root/.resign-android-image/otatools/bin/check_ota_package_signature/internal/stdlib/runpy.py", line 174, in _run_module_as_main
  File "/root/.resign-android-image/otatools/bin/check_ota_package_signature/internal/stdlib/runpy.py", line 72, in _run_code
  File "/root/.resign-android-image/otatools/bin/check_ota_package_signature/__main__.py", line 12, in <module>
  File "/root/.resign-android-image/otatools/bin/check_ota_package_signature/internal/stdlib/runpy.py", line 174, in _run_module_as_main
  File "/root/.resign-android-image/otatools/bin/check_ota_package_signature/internal/stdlib/runpy.py", line 72, in _run_code
  File "/root/.resign-android-image/otatools/bin/check_ota_package_signature/check_ota_package_signature.py", line 183, in <module>
  File "/root/.resign-android-image/otatools/bin/check_ota_package_signature/check_ota_package_signature.py", line 177, in main
  File "/root/.resign-android-image/otatools/bin/check_ota_package_signature/check_ota_package_signature.py", line 125, in VerifyPackage
  File "/root/.resign-android-image/otatools/bin/check_ota_package_signature/common.py", line 312, in RunAndCheckOutput
common.ExternalError: Failed to run command '['openssl', 'rsautl', '-verify', '-certin', '-inkey', '/srv/android-build/resign-android-image/grapheneos-ota.pem', '-in', '/tmp/digest-6OY5hU', '-out', '/tmp/decrypted-0XNjPV']' (exit code 1):

Failed to verify OTA update signature!
Failed to run: download_ota build/ota.zip.ok.Dnwzgo.tmp
Failed to run: make_extract_ota build/ota.nYHA9M.tmp
Failed to run: make_extract_ota_payload build/ota_payload.WeuMLI.tmp
Failed to run: make_target_files_extracted build/out_resign/target_files_extracted.done.zsxQys.tmp
Failed to run: make_target_files_intermediates_base build/out_resign/target_files_intermediates.CxTtA6.tmp
Failed to run: make_target_files_intermediates build/out_resign/target_files_intermediates.done.UIOZOo.tmp
Failed to run: make_target_files_intermediates_zip build/out_resign/target_files_intermediates.zip.cys3Nh.tmp
Failed to run: make_target_files_signed build/out_resign/target_files_signed.uuoKYW.tmp
Failed to run: make_target_files_base build/out_resign/target_files.Kj8HZ5.tmp
Failed to run: make_target_files_zip build/out_resign/target_files.zip.iANgtZ.tmp

Ah, I think the issue was that GrapheneOS uses different keys per device and the provided key is for raven whilst I am using oriole. Then again, it seems even changing out the key or using testing using raven results in a different error for me. (Unexpected file size change for file ./apex/com.android.cellbroadcast.capex: 4420998 -> 4395562)

Sorry for the issues, I just published the script and it hasn't been tested much beyond my own setup and device.
The first issue is indeed because I mistakenly only included the raven key.
I think the second might be because you are using the otatools.zip from ci.android.com as the script says while I built it myself from GrapheneOS sources, and I guess they might build APEXes slightly differently, so the size is not the same. I think the simplest solution is to use the code path that replaces the files whenever the size changes. In general, it would probably a good idea to rebuild the ext4 images from scratch instead of the current patching approach; I wrote the current code with the idea of modifying the original images as little as possible, but it creates a lot of complexity and potential issues and produces images that are larger than needed.
Will fix as soon as possible.

I'm sorry, I forgot I was using a different otatools.zip than needed (https://ci.android.com/builds/submitted/8562694/aosp_cf_x86_64_phone-userdebug/latest/otatools.zip).
That still gives the below error:
Updating ./system/etc/security/otacerts.zip: 1955 -> 1955
0+1 records in
0+1 records out
1955 bytes (2.0 kB, 1.9 KiB) copied, 8.833e-05 s, 22.1 MB/s
Compressed 35927296 bytes into 19026424 bytes ==> 52.96%
        MADE /home/build/android-build/build/out_resign/target_files/IMAGES/vendor_boot.img with make_boot_image
        MAKING /home/build/android-build/build/out_resign/target_files/IMAGES/vbmeta.img with make_vbmeta
        MADE /home/build/android-build/build/out_resign/target_files/IMAGES/vbmeta.img with make_vbmeta
        DISCARD: /home/build/android-build/build/out_resign/target_files_signed
        MAKING /home/build/android-build/build/out_resign/target_files/META/care_map.pb with make_care_map
        MADE /home/build/android-build/build/out_resign/target_files/META/care_map.pb with make_care_map
MADE /home/build/android-build/build/out_resign/target_files.zip with make_target_files_zip
DISCARD: /home/build/android-build/build/out_resign/target_files /home/build/android-build/build/out_resign/target_files_signed.zip
MAKING /home/build/android-build/build/out_resign/factory with make_factory
        MAKING /home/build/android-build/build/out_resign/factory_unchecked with make_factory_unchecked
                MAKING /home/build/android-build/build/out_resign/factory_image with make_factory_image
                        MAKING /home/build/android-build/build/factory_zip.ok with download_factory
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1273M  100 1273M    0     0  41.8M      0  0:00:30  0:00:30 --:--:-- 49.4M
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   250  100   250    0     0   4098      0 --:--:-- --:--:-- --:--:--  4098
                        MADE /home/build/android-build/build/factory_zip.ok with download_factory
                        MAKING /home/build/android-build/build/factory with do_unzip
                        MADE /home/build/android-build/build/factory with do_unzip
                        MAKING /home/build/android-build/build/factory.list with do_unzip_list
                        MADE /home/build/android-build/build/factory.list with do_unzip_list
                        DISCARD: /home/build/android-build/build/factory_zip/oriole-factory-2022050800.zip
                        MAKING /home/build/android-build/build/factory_image with do_unzip
                        MADE /home/build/android-build/build/factory_image with do_unzip
                        MAKING /home/build/android-build/build/factory_image.list with do_unzip_list
                        MADE /home/build/android-build/build/factory_image.list with do_unzip_list
                        DISCARD: /home/build/android-build/build/factory/oriole-factory-2022050800/image-oriole-2022050800.zip
                MADE /home/build/android-build/build/out_resign/factory_image with make_factory_image
        MADE /home/build/android-build/build/out_resign/factory_unchecked with make_factory_unchecked
unzip:  cannot find or open /home/build/android-build/build/out_resign/factory_unchecked/image-oriole-2022050800, /home/build/android-build/build/out_resign/factory_unchecked/image-oriole-2022050800.zip or /home/build/android-build/build/out_resign/factory_unchecked/image-oriole-2022050800.ZIP.
Cannot open input file /home/build/android-build/build/out_resign/check_factory.Yb27bj.tmp/factory_image/system.img
Traceback (most recent call last):
  File "/home/build/.resign-android-image/otatools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 196, in _run_module_as_main
  File "/home/build/.resign-android-image/otatools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 86, in _run_code
  File "/home/build/.resign-android-image/otatools/bin/unpack_bootimg/__main__.py", line 12, in <module>
  File "/home/build/.resign-android-image/otatools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 196, in _run_module_as_main
  File "/home/build/.resign-android-image/otatools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 86, in _run_code
  File "/home/build/.resign-android-image/otatools/bin/unpack_bootimg/unpack_bootimg.py", line 563, in <module>
  File "/home/build/.resign-android-image/otatools/bin/unpack_bootimg/unpack_bootimg.py", line 558, in main
  File "/home/build/.resign-android-image/otatools/bin/unpack_bootimg/unpack_bootimg.py", line 480, in unpack_bootimg
FileNotFoundError: [Errno 2] No such file or directory: '/home/build/android-build/build/out_resign/check_factory.Yb27bj.tmp/factory_image/vendor_boot.img'
/home/build/android-build/build/out_resign/check_factory.Yb27bj.tmp/vendor_boot/vendor_ramdisk00: is not a regular file
cpio: premature end of archive
unzip:  cannot find or open /home/build/android-build/build/out_resign/check_factory.Yb27bj.tmp/vendor_boot_ramdisk/system/etc/security/otacerts.zip, /home/build/android-build/build/out_resign/check_factory.Yb27bj.tmp/vendor_boot_ramdisk/system/etc/security/otacerts.zip.zip or /home/build/android-build/build/out_resign/check_factory.Yb27bj.tmp/vendor_boot_ramdisk/system/etc/security/otacerts.zip.ZIP.
cmp: /home/build/android-build/build/out_resign/check_factory.Yb27bj.tmp/recovery_otacerts/keys/releasekey.x509.pem: No such file or directory
Recovery otacerts.zip has wrong key!!!
Failed to run: check_factory /home/build/android-build/build/out_resign/check_factory.Yb27bj.tmp
Factory key check failed!!!
Failed to run: make_factory /home/build/android-build/build/out_resign/factory.D2Dy58.tmp

When using any other kind of otatools from ci.android.com it always gave the below error:
ERROR: Failed to obtain minSdkVersion: aapt2 return code 1:

/tmp/tmpSaMIHR_framework-res.apk: error: failed to find resource entry for staged  resource ID 0x01fe0000.

Traceback (most recent call last):
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/internal/stdlib/runpy.py", line 174, in _run_module_as_main
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/internal/stdlib/runpy.py", line 72, in _run_code
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/__main__.py", line 12, in <module>
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/internal/stdlib/runpy.py", line 174, in _run_module_as_main
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/internal/stdlib/runpy.py", line 72, in _run_code
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/sign_target_files_apks.py", line 1401, in <module>
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/sign_target_files_apks.py", line 1382, in main
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/sign_target_files_apks.py", line 547, in ProcessTargetFiles
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/sign_target_files_apks.py", line 464, in SignApk
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/common.py", line 2280, in SignFile
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/common.py", line 2228, in GetMinSdkVersionInt
  File "/home/build/.resign-android-image/otatools/bin/sign_target_files_apks/common.py", line 2203, in GetMinSdkVersion
common.ExternalError: Failed to obtain minSdkVersion: aapt2 return code 1:

/tmp/tmpSaMIHR_framework-res.apk: error: failed to find resource entry for staged  resource ID 0x01fe0000.

Failed to run: go /home/build/android-build/build/out_resign/sign_target_files.bIM40s.tmp /home/build/android-build/build/out_resign/target_files_signed.zip.7qDnjp.tmp
Failed to run: make_target_files_signed_zip /home/build/android-build/build/out_resign/target_files_signed.zip.7qDnjp.tmp
Failed to run: make_target_files_signed /home/build/android-build/build/out_resign/target_files_signed.0rhGXN.tmp
Failed to run: make_target_files_base /home/build/android-build/build/out_resign/target_files.4Gg2ai.tmp
Failed to run: make_target_files_zip /home/build/android-build/build/out_resign/target_files.zip.pTaMZt.tmp

Sorry, looks like the code to test built factory images was broken since I most likely never tested it because I wrote it after I had already installed the OS on my device and started building only OTAs and forgot to test it.
I pushed a commit that should hopefully fix it, but I haven't finished testing it yet.

No problem, thanks for taking the time to look after the project.
I now get the following error with grapheneos built otatools:
Updating ./system/etc/security/otacerts.zip: 1955 -> 1955
0+1 records in
0+1 records out
1955 bytes (2.0 kB, 1.9 KiB) copied, 8.305e-05 s, 23.5 MB/s
Compressed 35927296 bytes into 19026424 bytes ==> 52.96%
        MADE /home/build/android-build/build/out_resign/target_files/IMAGES/vendor_boot.img with make_boot_image
        MAKING /home/build/android-build/build/out_resign/target_files/IMAGES/vbmeta.img with make_vbmeta
        MADE /home/build/android-build/build/out_resign/target_files/IMAGES/vbmeta.img with make_vbmeta
        DISCARD: /home/build/android-build/build/out_resign/target_files_signed
        MAKING /home/build/android-build/build/out_resign/target_files/META/care_map.pb with make_care_map
        MADE /home/build/android-build/build/out_resign/target_files/META/care_map.pb with make_care_map
MADE /home/build/android-build/build/out_resign/target_files.zip with make_target_files_zip
DISCARD: /home/build/android-build/build/out_resign/target_files /home/build/android-build/build/out_resign/target_files_signed.zip
MAKING /home/build/android-build/build/out_resign/factory with make_factory
        MAKING /home/build/android-build/build/out_resign/factory_unchecked with make_factory_unchecked
                MAKING /home/build/android-build/build/out_resign/factory_image with make_factory_image
                        MAKING /home/build/android-build/build/factory_zip.ok with download_factory
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1273M  100 1273M    0     0  27.8M      0  0:00:45  0:00:45 --:--:-- 25.2M
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   250  100   250    0     0   4629      0 --:--:-- --:--:-- --:--:--  4629
                        MADE /home/build/android-build/build/factory_zip.ok with download_factory
                        MAKING /home/build/android-build/build/factory with do_unzip
                        MADE /home/build/android-build/build/factory with do_unzip
                        MAKING /home/build/android-build/build/factory.list with do_unzip_list
                        MADE /home/build/android-build/build/factory.list with do_unzip_list
                        DISCARD: /home/build/android-build/build/factory_zip/oriole-factory-2022050800.zip
                        MAKING /home/build/android-build/build/factory_image with do_unzip
                        MADE /home/build/android-build/build/factory_image with do_unzip
                        MAKING /home/build/android-build/build/factory_image.list with do_unzip_list
                        MADE /home/build/android-build/build/factory_image.list with do_unzip_list
                        DISCARD: /home/build/android-build/build/factory/oriole-factory-2022050800/image-oriole-2022050800.zip
                MADE /home/build/android-build/build/out_resign/factory_image with make_factory_image
        MADE /home/build/android-build/build/out_resign/factory_unchecked with make_factory_unchecked
Archive:  /home/build/android-build/build/out_resign/factory_unchecked/oriole-factory-2022050800/image-oriole-2022050800.zip
  inflating: /home/build/android-build/build/out_resign/check_factory.xjhjX3.tmp/factory_image/vendor_boot.img
  inflating: /home/build/android-build/build/out_resign/check_factory.xjhjX3.tmp/factory_image/system.img
boot magic: VNDRBOOT
vendor boot image header version: 4
page size: 0x00000800
kernel load address: 0x10008000
ramdisk load address: 0x11000000
vendor ramdisk total size: 25317131
vendor command line args: earlycon=exynos4210,0x10A00000 console=ttySAC0,115200 androidboot.console=ttySAC0 printk.devkmsg=on cma_sysfs.experimental=Y stack_depot_disable=off page_pinner=on swiotlb=noforce at24.write_timeout=100 log_buf_len=1024K bootconfig buildvariant=user
kernel tags load address: 0x10000100
product name:
vendor boot image header size: 2128
dtb size: 495134
dtb address: 0x0000000011f00000
vendor ramdisk table size: 216
vendor ramdisk table: [
    vendor_ramdisk00: {
        size: 19026424
        offset: 0
        type: 0x1
        name:
        board_id: [
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
        ]
    }
    vendor_ramdisk01: {
        size: 6290707
        offset: 19026424
        type: 0x3
        name: dlkm
        board_id: [
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
        ]
    }
]
vendor bootconfig size: 38
70171 blocks
Archive:  /home/build/android-build/build/out_resign/check_factory.xjhjX3.tmp/vendor_boot_ramdisk/system/etc/security/otacerts.zip
 extracting: /home/build/android-build/build/out_resign/check_factory.xjhjX3.tmp/recovery_otacerts/keys/releasekey.x509.pem
debugfs 1.45.5 (07-Jan-2020)
debugfs:  dump /system/etc/security/otacerts.zip /home/build/android-build/build/out_resign/check_factory.xjhjX3.tmp/system_otacerts.zip
debugfs:  Archive:  /home/build/android-build/build/out_resign/check_factory.xjhjX3.tmp/system_otacerts.zip
 extracting: /home/build/android-build/build/out_resign/check_factory.xjhjX3.tmp/system_otacerts/keys/releasekey.x509.pem
ln: failed to access '/home/build/android-build/build/out_resign/factory': No such file or directory
Failed to run: make_factory /home/build/android-build/build/out_resign/factory.as0Kdm.tmp

Pushed another commit that should fix that, thanks for reporting!

Changing this to a symbolic link seems to fix the below error:
DISCARD: /home/build/android-build/build/out_resign/target_files /home/build/android-build/build/out_resign/target_files_signed.zip
MAKING /home/build/android-build/build/out_resign/factory with make_factory
Archive:  /home/build/android-build/build/out_resign/factory_unchecked/oriole-factory-2022050800/image-oriole-2022050800.zip
  inflating: /home/build/android-build/build/out_resign/check_factory.SkdQaY.tmp/factory_image/vendor_boot.img
  inflating: /home/build/android-build/build/out_resign/check_factory.SkdQaY.tmp/factory_image/system.img
boot magic: VNDRBOOT
vendor boot image header version: 4
page size: 0x00000800

kernel load address: 0x10008000
ramdisk load address: 0x11000000
vendor ramdisk total size: 25317131
vendor command line args: earlycon=exynos4210,0x10A00000 console=ttySAC0,115200 androidboot.console=ttySAC0 printk.devkmsg=on cma_sysfs.experimental=Y stack_depot_disable=off page_pinner=on swiotlb=noforce at24.write_timeout=100 log_buf_len=1024K bootconfig buildvariant=user
kernel tags load address: 0x10000100
product name:
vendor boot image header size: 2128
dtb size: 495134
dtb address: 0x0000000011f00000
vendor ramdisk table size: 216
vendor ramdisk table: [
    vendor_ramdisk00: {
        size: 19026424
        offset: 0
        type: 0x1
        name:
        board_id: [
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
        ]
    }
    vendor_ramdisk01: {
        size: 6290707
        offset: 19026424
        type: 0x3
        name: dlkm
        board_id: [
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
            0x00000000, 0x00000000, 0x00000000, 0x00000000,
        ]
    }
]
vendor bootconfig size: 38
70171 blocks
Archive:  /home/build/android-build/build/out_resign/check_factory.SkdQaY.tmp/vendor_boot_ramdisk/system/etc/security/otacerts.zip
 extracting: /home/build/android-build/build/out_resign/check_factory.SkdQaY.tmp/recovery_otacerts/keys/releasekey.x509.pem
debugfs 1.45.5 (07-Jan-2020)
debugfs:  dump /system/etc/security/otacerts.zip /home/build/android-build/build/out_resign/check_factory.SkdQaY.tmp/system_otacerts.zip
debugfs:  Archive:  /home/build/android-build/build/out_resign/check_factory.SkdQaY.tmp/system_otacerts.zip
 extracting: /home/build/android-build/build/out_resign/check_factory.SkdQaY.tmp/system_otacerts/keys/releasekey.x509.pem
ln: /home/build/android-build/build/out_resign/factory_unchecked/oriole-factory-2022050800: hard link not allowed for directory
Failed to run: make_factory /home/build/android-build/build/out_resign/factory.FvT0wx.tmp

Added a commit that should fix that, should have time to complete testing and fix any other issue in 12-24 hours

It did, but I accidentally bricked my phone in the process. I installed the update via the recovery which worked, but then I disabled OTA unlocking in the settings and installed a magisk module that apparently overwrote the boot image to which I restarted to recovery to try and install the update again at which point it was bricked.
In general I think disabling OEM unlocking is not really advisable, since I don't think it provides any benefit and can make the device unrecoverable.

Unfortunately I don't think I can offer more help; I'm not really an expert on recovering devices though so maybe there's some way I don't know.
No worries, it was completely my fault and no issue of the script.
In general I think disabling OEM unlocking is not really advisable, since I don't think it provides any benefit and can make the device unrecoverable.
Yes, I guess so.

I am currently waiting on the RMA process, I'll let you know when it's done.


update new image in readme

Add android screenshots

Can I do this?

Can I do this?

Yes, please.

Where are the screenshots?

Can you please explain, what to do exactly !!

Just visit the Telegram Bot in your Android phone, take a screenshot of
graph, delhi and daily command and add in the README.

Need to add any other image?

@gurrrung Done. Here is the PR #92