tf.function should trace the additional attributes of a tensor

Hello, I'm not sure if this should be considered as a Feature or a Bug
System information

TensorFlow version (you are using): 2.0
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
Let's consider the following code (from TF 1.8) of the loginctensornetwork project
def And(*wffs):
    if len(wffs) == 0:
        result = tf.constant(1.0)
        result.doms = []
    else:
        cross_wffs,_ = cross_args(wffs)
        label = "_AND_".join([wff.name.split(":")[0] for wff in wffs])
        result = tf.identity(F_And(cross_wffs),name=label)
        result.doms = cross_wffs.doms
    return result

def constant(label,value=None,
                 min_value=None,
                 max_value=None):
    label = "ltn_constant_"+label
    if value is not None:
        result = tf.constant(value,name=label)
    else:
        result = tf.Variable(tf.random_uniform(
                shape=(1,len(min_value)),
                minval=min_value,
                maxval=max_value,name=label))
    result.doms = []
    return result

def cross_args(args):
    result = args[0]
    for arg in args[1:]:
        result,_ = cross_2args(result,arg)
    result_flat = tf.reshape(result,
                             (tf.reduce_prod(tf.shape(result)[:-1]),
                              tf.shape(result)[-1]))
    result_args = tf.split(result_flat,[tf.shape(arg)[-1] for arg in args],1)
    return result, result_args

def cross_2args(X,Y):
    if X.doms == [] and Y.doms == []:
        result = tf.concat([X,Y],axis=-1)
        result.doms = []
        return result,[X,Y]
    X_Y = set(X.doms) - set(Y.doms)
    Y_X = set(Y.doms) - set(X.doms)
    eX = X
    eX_doms = [x for x in X.doms]
    for y in Y_X:
        eX = tf.expand_dims(eX,0)
        eX_doms = [y] + eX_doms
    eY = Y
    eY_doms = [y for y in Y.doms]
    for x in X_Y:
        eY = tf.expand_dims(eY,-2)
        eY_doms.append(x)
    perm_eY = []
    for y in eY_doms:
        perm_eY.append(eX_doms.index(y))
    eY = tf.transpose(eY,perm=perm_eY + [len(perm_eY)])
    mult_eX = [1]*(len(eX_doms)+1)
    mult_eY = [1]*(len(eY_doms)+1)
    for i in range(len(mult_eX)-1):
        mult_eX[i] = tf.maximum(1,tf.floor_div(tf.shape(eY)[i],tf.shape(eX)[i]))
        mult_eY[i] = tf.maximum(1,tf.floor_div(tf.shape(eX)[i],tf.shape(eY)[i]))
    result1 = tf.tile(eX,mult_eX)
    result2 = tf.tile(eY,mult_eY)
    result = tf.concat([result1,result2],axis=-1)
    result1.doms = eX_doms
    result2.doms = eX_doms
    result.doms = eX_doms
    return result,[result1,result2]

In this project, we need to store some metainformation within every tensor for ensuring the correct behaviour of functions like And regardless of the order of the arguments.
Migrating to Tensorflow 2.0 if I decorate a function with @tf.function this function will not return the additional doms attribute of the tensor. This attributes, as you can see in functions like cross_2args are mandatory for ensuring the correctness of the flow.
My goal is to ensure that if a function is adding a set of attributes to a tensor before returning it, decorating the same function with tf.function should in the same way return a tensor which has the same set of additional attributes.
Will this change the current api? How?
No
Who will benefit with this feature?
Everyone who wants to add new attributes to a tensor for having meta-information about it during the forward process
Any Other info.

@thadumi, Thanks for reporting this issue.
Will it be possible to provide the complete standalone code to reproduce the reported issue here. Thanks!

Hi @gadagashwini ,
please take a look at the following example
import tensorflow as tf

def foo(label, tensor=None, min_value=None, max_value=None):
    if tensor is not None and tf.is_tensor(tensor):
        result = tf.identity(tensor, name=label)
    else:
        result = tf.random.uniform(shape=(1, len(min_value)),
                                   minval=min_value,
                                   maxval=max_value, name=label)
    result._bar = [label]
    return result

@tf.function
def fooAutoGraph(label, tensor=None, min_value=None, max_value=None):
    if tensor is not None and tf.is_tensor(tensor):
        result = tf.identity(tensor, name=label)
    else:
        result = tf.random.uniform(shape=(1, len(min_value)),
                                   minval=min_value,
                                   maxval=max_value, name=label)
    result._bar = [label]
    return result

assert hasattr(foo('a', min_value=[0.] * 10, max_value=[1.] * 10), '_bar') # this works
assert hasattr(fooAutoGraph('a', min_value=[0.] * 10, max_value=[1.] * 10), '_bar') # this will fail

I'd like to point out that the same issue exists also for Keras subclassing
The workaround for Keras is the following
class MyLayer(KL.Layer):

    def __init__(self, *args, **kwargs):
        super(MyLayer, self).__init__(*args, **kwargs)

    def __call__(self, inputs, *args, **kwargs):
        outputs = super(MyLayer, self).__call__(inputs, *args, **kwargs)
        flat_outputs = nest.flatten(outputs)

        meta = self.compute_meta(inputs, **kwargs)
        for output in flat_outputs:
            output._my_meta = meta

        return outputs

    def compute_meta(self, inputs, **kwargs):
        return [] # no metadata

@jvishnuvardhan I'd like to contribute. Could you tell me where I should add this feature?

@mdanatg FYI
Unfortunately, @tf.function is supposed to trace only direct Tensor manipulations.  I agree that it's not ideal but currently it's out of the scope for @tf.function.  For now, I suggest to manage the metadata outside of @tf.function
FYI, @tf.function is defined here https://github.com/tensorflow/tensorflow/blob/7cebef3019e9ec10fd81a021e56233527ae7c9d1/tensorflow/python/eager/def_function.py#L970

Indeed, it would be cleaner to encapsulate those tensors inside structures that tf.function supports, like namedtuple objects. These structures could then carry the values along with the metadata. In general, tensors generally have semantics of opaque values (unfortunately not uniformly implemented right now), so in theory they should not allow setting custom attributes (they should behave more like int or np.ndarray in that regard).
Here's an example which uses namedtuple:
LblStruct = collections.namedtuple('LblStruct', ('value', 'bar'))

@tf.function
def foo_with_namedtuple(lbl_struct, tensor=None, min_value=None, max_value=None):
    label = lbl_struct.value
    if tensor is not None and tf.is_tensor(tensor):
        result = tf.identity(tensor, name=label)
    else:
        result = tf.random.uniform(shape=(1, len(min_value)),
                                   minval=min_value,
                                   maxval=max_value, name=label)
    return LblStruct(result, [label])

lbl_struct = LblStruct('a', '_bar')
assert hasattr(foo_with_namedtuple(lbl_struct, min_value=[0.] * 10, max_value=[1.] * 10), 'bar')

Side discussion --
Technically speaking, preserving custom attributes would be doable for static attribute modifications (that is, not for attributes that are set inside data-dependent control flow), like in this hand-coded example:
def foo(label, tensor=None, min_value=None, max_value=None):
    if tensor is not None and tf.is_tensor(tensor):
        result = tf.identity(tensor, name=label)
    else:
        result = tf.random.uniform(shape=(1, len(min_value)),
                                   minval=min_value,
                                   maxval=max_value, name=label)
    result._bar = [label]
    return result

def foo_with_custom_attributes(label, tensor=None, min_value=None, max_value=None):

  @tf.function
  def wrapper(label, tensor, min_value, max_value):
    return foo(label, tensor, min_value, max_value)

  result = wrapper(label, tensor, min_value, max_value)
  result._bar = [label]
  return result

assert hasattr(foo('a', min_value=[0.] * 10, max_value=[1.] * 10), '_bar') # this works
assert hasattr(foo_with_custom_attributes('a', min_value=[0.] * 10, max_value=[1.] * 10), '_bar') # this works too
assert hasattr(tf.function(foo)('a', min_value=[0.] * 10, max_value=[1.] * 10), '_bar') # this fails

When it traces its body, tf.function creates new tensor objects for its arguments and return values (e.g. arguments are replaced with placeholders that will be fed at execution), which is when custom attributes get lost. So tf.function could copy them over, if this was done with care, to avoid copying attributes that it should not (we don't want to accidentally set a non-user attribute).
If you'd like to experiment with it, that's probably best done deep inside tf.function around the point when if calls the original function, which should be here. That's where AutoGraph proper is applied as well, if you look a couple of lines up.
Again, the above is purely an academic point, because I think this caveat is valid not just for tf.function, but may other ops as well, like tf.cond, tf.while_loop, even tf.identity` - any of these are expected to replace respective arguments without warning - they only preserve values; so if anything,  would require a lot of code.

Hi @mdanatg sorry for the delay.
Thanks for the explanation. I refactored the code for working with something very similar to the wrapper proposal.

@thadumi,
Can you please let us know if this comment has resolved your issue so that we can close it? Thanks!


Ferdi doesn't launch after update

Describe the bug
After installing updates on my computer just now, Ferdi doesn't launch - or rather: is stuck on the purple screen (before even log-in shows).
A few seconds I see a white-ish flash on the screen, relaunching a few times it seems that that flash shows some field-areas (but in white, only).

Desktop:

OS: Linux
Ferdi Version - I believe 5.5.0 now (before I believe 5.4.3). Installed via flatpak
Server Used: none (local)

Thank you for the report @keunes. Can you confirm you were using Ferdi without an account? Sorry for the bad experience with the update, this has been reported in https://github.com/getferdi/ferdi/issues/543 as well. We had to make trade-offs as new users were still geting 5.4.3 via the website and other stable release channels, where a lot of things wasn't working anymore 🙏 Let's continue the discussion in the other thread? We will do better with the next iteration. Thank you for your patience!

Hi, this happened to me too.
I noticed that in the previous dev version 5.5.0-gm.2, Ferdi breaks when I set up a password lock.
Then I had this problem on Windows 10,  on my Ubuntu system I did not update because of this.
The solution that I did was to delete everything using geek uninstaller.
Then, I installed the 5.4.3 version and it prompted me to update directly to the 5.5.0.
This resolved the issue BUT if I enable password lock, the app just crashes and this happens again.

Thank you @jeannsensei, we will address via https://github.com/getferdi/ferdi/issues/543 🙏


Deploy Application on Github pages

In this PR, the portfolio webpage is deployed on the Github pages. The "Readme.md" file is updated and the live version link of the webpage is present in the readme.md file.

Great Work 😄

Correct GitHub flow 👍
No linters Errors 😃
Live Website 😉

Appreciations:

It is based on the figma design
you have used the most readable styling
class names are descriptive

Great work:

The Figma design was followed properly.


Update meta.yaml

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@richardjgowers I can't remember, did lomap2 need to use the git url to work?


Enables hystrix monitoring of multiple services on a single server.

Original request with conversation #574

I like more tests than code! Thanks again.


Make more options available in blackout rule

Right now blackout rules use Environment with other options. Only exception is the possibility of using resource and event together using the Res-Event from the dropdown. It would be more powerful blackout engine if it was possible to use different combination in the rule. For example I have use case where I would like to Environment, Event & multiple tags.
Since in version 5.x all tags from grafana are converted to alert.attributes. So it would even better if in future release it can be combination of all alert attributes.

My immediate reaction is that I think this would be too complex and computationally expensive to implement. However, I'll review it in more detail when I have time and get back to you. Thanks for the feedback.

This PR https://github.com/alerta/alerta/pull/627 added support for every combination of environment, service, resource, event, group and tags. I think that addresses your issue here.


Cancellation Token

Feature Request from Original Project: /microsoft/RulesEngine/issues/609

Implemented, will be released soon.


Documentation request: How to add featureGroups to custom panes

Hi There,
I couldn't find documentation for this anywhere.  I want to do something like the following:
var highlightPane = map.createPane('highlight');
var highlightLayerGroup = L.featureGroup({pane:highlightPane});
var geojsonLayer = L.geoJson(geojson, {pane:highlightPane});
highlightLayerGroup.addTo(map);
This doesn't work.  Is there a way to do this?
Thanks!

Discussions and example on #1742 may help.
cc @Jakobud so we need more documentation on new pane management?

Okay I'll put together something soon.

Is this not covered in the panes tutorial? Maybe a section on how to create renderers with panes is needed.

Closing as a duplicate of #4277


new release?

@RenanCarlosPereira
publish a new release and nuget package?  are we ready for it?

No, we need to update the changelog with the fixes we have fixed
I will open the PR for the changelog.
We also need to define the package name 😅
We also need to generate another sign key. We can keep the same file name just generate another one and update the references in the manifests

are you creating a PR to update the changelog AND signkey?

No just the changelog, if you want to do the sign key feel free, too late here today, will catch up tomorrow

no problem

In case you dont know how to generate the base64 and import it to the secrets heres how to do it
In the end ipen the file copy its contents and add to the secret in github
# Generate the .snk file using sn.exe
# Make sure the Developer Command Prompt for Visual Studio is available
& "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.29.30037\bin\Hostx64\x64\sn.exe" -k RulesEngine-publicKey.snk

# Convert the .snk file to a base64 string
$snkPath = "RulesEngine-publicKey.snk"
$base64String = [Convert]::ToBase64String([IO.File]::ReadAllBytes($snkPath))

# Output the base64 string to a file
$base64String > "RulesEngine-publicKey.txt"

# Also print the base64 string to the console
Write-Output $base64String

Explanation

Generate the .snk file: This uses the sn.exe tool to create a new strong-name key file (RulesEngine-publicKey.snk).
Convert to Base64: This reads the .snk file and converts its content to a base64-encoded string.
Output the Base64 String: The script writes the base64 string to a file (RulesEngine-publicKey.txt) and prints it to the console.

Usage

Make sure to update the path to sn.exe if it differs based on your Visual Studio installation.
Run this script in a PowerShell environment.

completed

v6.0.0 published to nuget and package created for github

NOW! lets make some changes and break this thing! JK

nice, all good with the automation?

I noticed you created, the release resources, you don't need to do it, just create the tag when the build complete it will generate a release automatically, so u only need to add some text there if needed

i couldn't figure out how to create only a tag.

oh no, what I mean is, that you don't need to attach binaries, the pipeline will do that for you.
if you see we will have 2 binaries there, there no need 😅

i had to create a release to create the tag.  i think creating it as prerelease to create the tag and deleting the prerelease was an option i saw someone mention in the community

Yes, you can create a tag in GitHub without creating a release.
Here’s how you can create a tag without a release using Git commands.
Using Git Command Line:

Open your terminal or command prompt.

Navigate to your local repository.

Create a tag using the following command:
git tag <tag-name>

For example, to create a tag named v1.0.0, you would use:
git tag v1.0.0

Push the tag to GitHub:
git push origin <tag-name>

For example:
git push origin v1.0.0

This will create a tag in your repository without creating a release. You can see the tags in the "Tags" section of your repository on GitHub.
that will trigger the release and build and publish the nuget.
when everything is ready you can edit the release with some notes. you can also create in github too, but you don't need to add the artefacts

thanks!


Update quickstart

Issue #, if available:
Description of changes:
The proxmox provider will no longer needed to be added to clusterctl config,
this will be merged after this: https://github.com/kubernetes-sigs/cluster-api/pull/9798
Testing performed:

https://cluster-api.sigs.k8s.io/user/quick-start#initialization-for-common-providers


Launcher won't start if detects no public port open

Kee said these may just need an override option if it fails

we have an public open port test now, just waiting for june 15th release to unblock the rest of this (or maybe a branch?)


If you set the inputtime to 8:30 the control makes it 9:30

This is because you use toFixed(0) to round the value for the hours.
You need to use Math.floor..

+1  I am facing the same issue.

I need to write this junky piece of code, to fix this in runtime.

Even with the commit made by @koiyu the problem continues to happen. Any news about that?

@lucasdoamaral I don't understand your problem without more context.
If your currentTime represents inputTime option, then remember: inputTime is not a Date object.
If you wish to use Date objects (I do, at least), then you could use the following options:
$scope.data.created = new Date();

$scope.changeTime = function() {
            ionicTimePicker.openTimePicker({
                callback: function(val) {
                    var hours = Math.floor(val / 60 / 60),
                        minutes = val / 60 % 60;
                    $scope.data.created.setHours(hours, minutes);
                },
                inputTime: ((($scope.data.created.getHours() * 60 * 60) + (($scope.data.created.getMinutes() * 60)))),
                format: 24
            });
        };

Hi @koiyu ,
What they are saying is correct. I am experiencing the same issue. With your code, if I open, the current time in midday (12.03pm). The input on 12 hour clock time will show as  00 : 03 pm. I think before that I did it at 11.55am and it showed as 12.55am.
Very useful Directive. Thank you.
Cameron

+1

+1 still the issue, please regenerate ionic-timepicker.bundle.min.js
this is the fix

Had the same problem (toFixed was rounding the time). @koiyu fix worked.

Hi,
could you push the new version of this component to bower, including your fix of this issue ?
Thanks

Fixed in v0.6.0


Integration test stops after setUp call and returning "passed" mark

Before test I would prepare database for it. So I use setUp function which calls function in API class for removing test user account from database if it exists because I will test user account registration and provide same data between tests.
class IntegrationTestApi with REST {
  Future<void> removeTesterAccountIfExists() async => delete('tester/account');
}

void main() {
  setUp(
    () {
      IntegrationTestApi().removeTesterAccountIfExists();
    },
  );

  patrolTest(
    'App started successfully',
    nativeAutomation: true,
    (PatrolTester $) async {
// …

But test completes as "passed" just after starting without any real work.
https://user-images.githubusercontent.com/11006352/234412454-6f136c17-1925-4b7b-a02c-9f6c5e4df242.mp4
Whats wrong?

API-calls not allowed in integration tests as in widget tests?

API-calls not allowed in integration tests as in widget tests?

They are allowed. App during integration testing behaves mostly like a real app.

Whats wrong?

It's hard to tell just by looking at the code you provided. I'd say everything is fine – the app starts, the expect() passes, and that's it - end of test. What would you expect?


[BUG] aqara cube knock on faces 2, 3, 5, 6 report wrong activated face

Describe the bug
Doing a double knock on faces 2, 3, 5 and 6 reports incorrect values for activated face:
Below example is for active face 2:
"command": "knock",
"args": {
    "value": 513,
    "description": "aqara logo facing user rotated 90 degrees left",
    "activated_face": 5

To Reproduce
Steps to reproduce the behavior:

Enable event listening.
Flip the cube and knock on each face (1-6), check events.
Faces 1 and 4 work fine but knocking on faces 2, 3, 5, 6 generates incorrect activated_face values.

Expected behavior
Testing results for knock events: 6 and 3 are interchanged so are 2 and 5. 1 and 4 are reporting correctly.
Screenshots
If applicable, add screenshots to help explain your problem.

Device signature
Paste the device signature here.
Don't remove the extra line breaks outside the ``` marks.

Diagnostic information
Paste the diagnostic information here.
Don't remove the extra line breaks outside the ``` marks.

Additional logs
Paste any additional debug logs here.
Don't remove the extra line breaks outside the ``` marks.

Additional context
Add any other context about the problem here.

Relevant PR that also contains some discussion: https://github.com/zigpy/zha-device-handlers/pull/1972


Adds all-contributors-cli to the project

All Contributors - #114

Creates a new markdown file that is registered in the /.all-contributorsrc file.

@GantMan let me know if you have any more thoughts on this. You could also pull this down and add contributors and see what it looks like.

Thats where the contributors list goes. Wasn't sure if you wanted to maintain this list yourself or not. Otherwise, I can go through and start adding contributors in this PR based off of who has contributed so far.
Basically, we just need to start running all-contributors add [GH Username] code,doc and it will append the new contributor to https://github.com/mattathompson/solidarity/blob/all-contributors/docs/existingContributors.md

O crap... there's no automated way?  That's a pain!  Maybe I should write a CLI for @jfmengels so it would automatically parse the git history, and identify suggested emojii for that person.

https://github.com/jfmengels/all-contributors-cli/issues/49

That would be legit.
On Nov 8, 2017 11:57 AM, "Gant Laborde"<EMAIL_ADDRESS>wrote:

O crap... there's no automated way? That's a pain! Maybe I should write a
CLI for @jfmengels https://github.com/jfmengels so it would
automatically parse the git history, and identify suggested emojii for that
person.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/infinitered/solidarity/pull/119#issuecomment-342882336,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF83K__iZG2EzLB6GsVyPeg0x89HDMTnks5s0d2GgaJpZM4QSZHh
.

Looks good Matt.  Not sure when I'd be able to make it automated, but that's on my list of open source TODO


Refactor timeAgo to make it more performant

What are you changing?

refactor the internals of timeAgo
~reformatted the tests (unintentionally)~ → #852

Why?

internal changes that result in a ~25× speed up for dates under a week, which brings the execution from 1-2µs to 60-70ns.

To clarify yak shaving, I meant in a good way:
"An activity that allows one to overcome intermediate difficulties, which then allows one to solve a larger problem."
As in avoiding death of a thousand papercuts on performance.


Sponsor Page is Working fine and it is responsive

linking to #8

Not Responsive @SWASTI-SUNDAR

Thanks @SWASTI-SUNDAR , The component is completed.


add CI for e2e tests

runs e2e tests using kind

create kind cluster with multiple nodes
kind load a test image
create ImageList object with the test image
check if pods are scheduled on all nodes
check if pods are complete
when finished, check if test image is removed

@sozercan  Do you mind if I use the e2e-framework to build the e2e tests?
Also, the issue description for CI but your comments for building the tests, is that right?


Introduce updateOne and updateMany to ODM's builder

Follows up https://github.com/doctrine/mongodb/pull/275 and closes https://github.com/doctrine/mongodb-odm/issues/1501

@alcaeus PR updated and rebased :)

Thanks for the reminder. I lost sight of this one for a moment :)


Error

Does anyone know why I'm getting the below error when I go to my view? I'm using Laravel 5
FatalErrorException in ClientProxy.php line 15:
Declaration of ClientProxy::request($method, $uri, array $options = Array) must be compatible with GuzzleHttp\ClientInterface::request($method, $uri = NULL, array $options = Array)

class pokemonController extends Controller
{

    public function run(Request $request)
    {
        // EXAMPLE Authentication via Google user credentials
        $config = new Config();
        $config->setProvider(Factory::PROVIDER_GOOGLE);
        $config->setUser(Auth::User()->pokego_username);
        $config->setPassword(Auth::User()->pokego_password);
        // Create the authentication manager
        $manager = Factory::create($config);
        // Add a event listener,
        $manager->addListener(function ($event, $value) {
            if ($event === Manager::EVENT_ACCESS_TOKEN) {
                /** @var AccessToken $accessToken */
                $accessToken = $value;
                // Persist the access token in session storage, cache or whatever.
                // The persisted access token should be passed to the Authentication factory for authentication
            }
        });
        // Initialize the pokemon go application
        $application = new ApplicationKernel($manager);

        // Retrieve the pokemon go api instance
        $pokemonGoApi = $application->getPokemonGoApi();
        // Retrieve the profile
        $profile = $pokemonGoApi->getProfile();
        // Retrieve the profile data
        $profileData = $profile->getData();
        echo sprintf('The profile data: %s', print_r($profileData, true));
    }

}

You get the error because your are using a version of Guzzle before https://github.com/guzzle/guzzle/commit/acd0bcded6705fa53d3150661a5709cea5b08000 (tagged as 6.2.1). A composer update should fix that temporarily.
But it is not your fault, the composer.json of this project should require ^6.2.1 to avoid this problem.


Add a verify script that checks for json tags in versioned api types.go

All fields in types.go files in versioned APIs should have a json tag.  This is a candidate to pull into repo-infra from k8s.

I looked at this and attempted to verify that hack/verify-description.sh is the script we need to import from k8s. But after removing a JSON tag in pkg/api/v1/types.go and then testing, the script didn't fail. When running "make verify", I didn't see any output specifically illustrating the diff I was expecting so maybe I'm testing incorrectly? update-codecgen.sh at least produced a diff that something changed from the previous working state, but this doesn't seem to match what this issue is requesting.

@jpeeler Here's the start of a verify-types.go file that will check to make sure "json:" appears in the tag of each struct field:
package main

import (
	"fmt"
	"go/ast"
	"go/parser"
	"go/token"
	"os"
	"strings"
)

func verifyTypes(fileName string) int {
	rc := 0
	fset := token.NewFileSet()

	fileAst, err := parser.ParseFile(fset, fileName, nil, parser.ParseComments)
	if err != nil {
		fmt.Fprintf(os.Stderr, "Error parsing file %q: %s\n", fileName, err)
		return 1
	}

	for _, decl := range fileAst.Decls {
		genD, ok := decl.(*ast.GenDecl)

		// Skip non-Type decls
		if !ok || genD.Tok != token.TYPE {
			continue
		}

		for _, spec := range genD.Specs {
			daType, ok := spec.(*ast.TypeSpec)
			if !ok {
				continue
			}

			// Skip non-struct types
			structType, ok := daType.Type.(*ast.StructType)
			if !ok {
				continue
			}

			if structType.Fields != nil {
				for _, field := range structType.Fields.List {
					// Note that we'll skip anonymous fields
					for _, name := range field.Names {
						// No tag, not a string or no "json:" and we error it!
						if field.Tag == nil ||
							field.Tag.Kind != token.STRING ||
							!strings.Contains(field.Tag.Value, "json:") {

							fmt.Printf("%s.%s: missing json tag\n",
								daType.Name, name)
							rc = 1
						}
					}
				}
			}
		}
	}

	return rc
}

func main() {
	rc := 0
	for _, fn := range os.Args[1:] {
		rc += verifyTypes(fn)
	}

	os.Exit(rc)
}

I think we'd just need to call it for each of our versioned types golang files.

Looks nice and might be small enough to just keep in service-catalog, but I'd expect this sort of validation to live in k8s for everybody to use eventually.

yea, we can add it to: https://github.com/kubernetes/repo-infra  once we know it works

closed by #1480


Disable GPG check for all sle15 repos

What does this PR change?
Disable GPG check for all sle15 repos as workaround to have a QAM deployment until build service updates the GPG keys

This workaround defeats the security brought by GPG keys. ￼
For an "enterprise" product, it is a very serious problem IMHO...

This workaround defeats the security brought by GPG keys. ￼
For an "enterprise" product, it is a very serious problem IMHO...

Superseded by https://github.com/uyuni-project/sumaform/pull/841 closing

Superseded by https://github.com/uyuni-project/sumaform/pull/841 closing


module 1.2 Assignment

uploaded the image, but it's over two screens... hope you got a large place to view it. Also your directions are not os friendly. If this was a chromebook... shudders in fear of the work.


fix: fake commit to trigger build

Issue
This PR Closes #
Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Build (npm run build) was run locally and any changes were pushed
[ ] Lint (npm run lint) has passed locally and any fixes were made for failures

Changes
Changes in this pull request:

Browsers
I tested the build on the following browsers:

[ ] Firefox Desktop
[ ] Chrome Desktop
[ ] Safari Desktop
[ ] Firefox Mobile
[ ] Chrome Mobile
[ ] Safari Mobile
[ ] Opera
[ ] Brave

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

Mentions

@lyne-design-system/core

:tada: This PR is included in version 6.14.9 :tada:
The release is available on:

npm package (@[secure] dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


requires RxBlocking @ runtime!

I cannpt add Action to my project using Carthage
I'm getting

dyld: Library not loaded: @rpath/RxBlocking.framework/RxBlocking

Referenced from: ...app/Frameworks/Action.framework/Action
Reason: image not found

at runtime and obviously RxBlocking is Test library
NOTE: adding RxBlocking fixed runtime issue but I cannot push the binary to itunesconnect

Very strange, can anyone from @RxSwiftCommunity/contributors take a look at this? I'm unfamiliar with how Carthage is integrated with the Action library.

@ashfurrow you already merged pull request #79 that fixes this problem, but latest git tag (2.2.1) was made before that merge, so new release (like 2.2.2) will fix that problem.

@reloni Thanks for the update.
@ashfurrow When do you release next version?

Working on it right now.

Should be good to go, version 2.2.2 pushed. Let me know.

It works fine with 2.2.2
Thanks @ashfurrow

@ashfurrow It's been resolved in 2.2.2 so that I can run locally but I'm unable to push to iTunesConnect!
the app including Action.framework gets 'This build is invalid' error after Processing and if I remove Action then it succeeds.
Any thoughts?

Did you add the Action framework in Carthage's custom build phase script?

@stefanomondino Yes I do

The only thing I guess could be the reason is I looked inside the built Action.framework and the version in Info.plist is 2.1.1! compare to when I use pod which is 2.2.2
my cartfile.resolved includes github "RxSwiftCommunity/Action" "2.2.2"

2.3 fixes this issue.
Thanks


Update README.md

Sorry for the 3 different PR. I edited files directly on Github and for some reason, i thought it would merge them into one PR.

@Landish Thank you for the pull requests, I've released 1.2.1

@KasparRosin Thanks for you quick response. Cheers!


Bump Dependencies #11798332896

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/11798332896

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Outdated


AS400 DB2 Admin mode

Hi,
Sorry if this question is not posted in the correct area.
I am using DBeaver to connect to DB2 database on iSeries server.  I can do pretty much everything on the Test server.  However, when it comes to the Production server, I can't update any records. It gives me a "Not authorized to object X"
If I go to the emulator and type "admin (*on) then use STRSQL, I can make the updates.
Is there anything that we can configure in DBeaver to do the same?  I need to run a lot of SQL stmts one after another and using STRSQL in iSeries would be a huge pain.
Thanks

If it is possible to switch to admin mode by SQL then you could try to execute this SQL in bootrstrap SQL queries (connection properties->General->Bootstrap queries)

Serge-rider,
Thanks for the response but I have no clue if that is even possible.  The Sysadmin folks are remote and aren't helpful here.

In any case, in DBeaver you can:

set some connection (driver) properties
configure bootstrap SQL (which will be executed right after database connection is initiated)
configure shell commands (some native command line commands which can be run before/after connection).

You can pass variables (like user name, host name, etc) in both bootstrap SQL and shell commands.
I think there are no other way to set connection configuration.


Debug and tasks should fetch latest configuration from disk

Repro

Create a "project" that uses command-line arguments. In my case, a node.js command-line tool.
Modify the "configuration.args" in associated launch.json
Press F5 to debug

Issue
Modifications to launch.json in step 2 would not be used for step 3 until launch.json is explicitly saved (Ctrl+S). 'launch.json' is a special file and should probably be automatically saved on F5 or at least user should be warned it is on a modified state.
Visual Studio Code
Version 0.10.8
Commit db71ac615ddf9f33b133ff2536f5d33a77d4774e
Date 2016-02-05T10:10:11.194Z
Shell 0.35.6
Renderer 45.0.2454.85
Node 4.1.1

We are actually saving all files on the debug session start, however there is a timing issue here. If you start a second debug session you will see that your changes are picked up.
The root cause here is that the configuration service is giving me a stale launch.json so forwarding to @bpasero
To repro, change something in launch.json, notice that the change is not picked up on first debug launch, however it is picked up afterwards. I think we already looked into this issue some time ago but forgot what was the conclusion.

I am sure we have a dupe for this...

@isidorn even if the configuration service would react synchronously to the file getting saved, there is still a delay until the configuration service would read the file from disk and emit the configuration change event.
If you can suggest how this would work, let me know. Should we have a method on the configuration service to always fetch the config from disk and bypass the cache?

@bpasero having a method that bypasses the cache would work for me in this scenario, not sure if you want to add it though. Tasks might also benefit from this, run task would also need to bypass the cache for similar reasons. But where do we draw a line between using a configuration service and the file service to just read the content of the file?

No it would always go through the configuration service and never the file service. I agree that tasks should use it as well then.

Updating to reflect the issue exists for tasks as well.

is there a fix for this issue?

This issue is currently assigned to the backlog. Every sprint we pick items from the backlog to plan for the current iteration. Please see https://github.com/Microsoft/vscode/wiki/Issue-Tracking#planning

@isidorn the change is for debug and tasks to fetch latest config from disk so that you do not get stale results. one use case to verify is to F5 with a dirty launch.json and making sure everything works including the dirty changes that get saved right after.

Awesome!

@bpasero Great!!! you fixed the issue. If I download the latest visual studio code, will it be having the fix incorporated?

@balachandar88 end of month, next release!

@bpasero works great! Love that this got fixed

@isidorn nice!


Unable to destroy VM

Sometimes, after lots of reinstalling+testing of HAXM while working on it, I encounter one mysterious issue that occurs rather unfrequently (this is the third time that happened to me in the past 3 months). When trying to uninstall the driver, following error shows up:
haxm_error:Still VM not be destroyed?

This prevents the drivers from being reinstalled and forces me to reboot Windows to continue working on HAXM. I'm still confused as to what causes this issue, or how to debug it. Any ideas would be appreciated.

Thanks. I've never seen this error on Windows, but it sounds like a pretty severe bug. Similar issues I've seen include:

On Mac, we used to fix a bug (probably this one), where launching a guest (VM creation) would fail without properly destroying the HAXM VM data structures (vm_t, etc.), leaving behind a few HAXM-specific devfs nodes. As a result, the HAXM KEXT could not be unloaded without a system reboot. I don't remember the error message, which was probably the same that you quoted. We ended up fixing the VM creation bug, but never the VM destruction bug.
On Windows, we used to fix a nasty deadlock bug (#48), where one of the QEMU vCPU thread would block in a HAXM driver call, and even killing the QEMU process would not unblock it. As you could imagine, HAXM driver could not be unloaded without a system reboot, but the difference is that sc stop would hang, and HAXM did not have a chance to print that error message.

If we can't reproduce the issue reliably, the best we can do is review the current code and fix any code path that could lead to hax_put_vm() not being called.


Development - Pull request to Master

Silvana has requested a review of the Customize branch - able to run arbitrary scans.  Chris will pull in high resolution scan options.  Additional files included:  edge effect journal, hourly tracking gendaylit example.

OK, there are still some problems with this branch - there is an end-to-end unit test failing for large azimuth tilt angles.  The logic around lines 1357 - 1366 is resulting in incorrect line scans.  The test case in tests/test_bifacial_radiance/test_RadianceObj_high_azimuth_angle_end_to_end(): is azimuth = 30 degrees


Add settings window to open on running app without an argument

Also add a shortcut to the start menu in the msi.


[BUG] Multiple starred expressions in a list

Hi !
I think Cython is not able to compile when I unpack multiple expressions separated by commas, in one list.
Describe the bug
When I want to compile my python file containing a condition like
if arr['name'] not in [*foo.bar.keys(), *foo.bar2.keys()]:

I get two error messages
Error compiling Cython file:
------------------------------------------------------------

if arr['name'] not in [*foo.bar.keys(), *foo.bar2.keys()]:
                            ^
------------------------------------------------------------

src/package/foo/bar.py:964:83: starred expression is not allowed here

Error compiling Cython file:
------------------------------------------------------------

if arr['name'] not in [*foo.bar.keys(), *foo.bar2.keys()]:
                                             ^
------------------------------------------------------------

src/package/foo/bar.py:964:83: starred expression is not allowed here

I know it is a very particular method and I could do
if arr['name'] not in [*foo.bar.keys()] + [*foo.bar2.keys()]:

But maybe it's possible to add this feature to Cython ?
I found this issue which looks like my problem, but setting different language_level doesn't change anything.
To Reproduce
To reproduce behaviour, try to compile
if arr['name'] not in [*foo.bar.keys(), *foo.bar2.keys()]:

Expected behavior
Errors should appear
Environment (please complete the following information):

OS: Linux & Windows
Python version 3.7.9
All Cython versions tested, even master branch

Additional context

Probably an issue with the optimised in tests. If there is a starred expression in the in list, then it should not get optimised.
See the FlattenInListTransform in Optimize.py.
Test should go into tests/run/pep448_extended_unpacking.py

Suitable for a backport to 0.29.x.

I'd like to give this a shot

Could not reproduce the issue when I test with
a = {1: 'a', 2: 'b'}
b = {3: 'c', 4: 'd'}
print(2 in [*a.keys(), *b.keys()])
-----
O/P: True

Still looks broken to me - it doesn't look like you tried to compile it with Cython.

Sorry, my bad. Can replicate the issue.
cython3 --embed -o test.c test.py
/usr/lib/python3/dist-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /home/arvind/test.py
  tree = Parsing.p_module(s, pxd, full_module_name)

Error compiling Cython file:
------------------------------------------------------------
...
a = {1: 'a', 2: 'b'}
b = {3: 'c', 4: 'd'}
print(2 in [*a.keys()])
           ^
------------------------------------------------------------

test.py:3:12: starred expression is not allowed here

@da-woods @scoder The PR is ready.


Add support for component-scan like in spring framework

Please add support for component-scan like in spring framework.
http://docs.spring.io/spring-javaconfig/docs/1.0.0.M4/reference/html/ch06s02.html

Duplicate of #49.


removing use of pronoun 'we'

Fixes #280

@brettmarquard - What issue were you fixing with this change? It isn't #289 (as noted in the description of this PR) and I'm not finding the issue at first glance.

should have been #280, sorry.


Bomberman multiple issues (PPU Player 1.1)

Scrolling registers change independently and the picture "swims"
The image does not match the patterns
You can barely see the logo

Scans:

Also not very healthy, because the visible part of the signal is very sloping and rises just above the black level. Although the phase component slips here and there. Well, in fact, it can be seen on the screen - blackness + sometimes dark spots.

Some progress.

And field after:

😞

Scrolling split has been fixed. There was a bad RegDump.


test: Make 1node suites work on 2node setups

Currently, 1node suite after creating SSH connections leaves the active one pointing to slave host, but cluster reinit assumes the active connection points to master.

Proposed fix: https://github.com/contiv/vpp/pull/265

Suite teardown still needs a fix to pass when not all nodes are used.

Teardown fix: https://github.com/contiv/vpp/pull/267

1node suites should work correctly on 2node setups now.


Fenrus does not fully support laptops/small resolutions

When running fenrus in 1080p 100% scaling I can edit this fine

However if i got to my laptop which is 1080p 125% scaling it shows like this

Hiding the save button and with no scrolling it makes it unusable
Work around for now is to try different monitor or adjust scaling

already fixed, will be in next release.

thats fast

fixed it yesterday when i saw it :P


New install of demo app crashes with error related to MatInput

Bug, feature request, or proposal:
Bug
What is the expected behavior?
After installing demo-app, be able to start it via npm run demo-app
What is the current behavior?
Get the following error in the cmd window (Windows 10):
Error: Error: E:/DevTest/material2/src/lib/input/input.ts:48:1: Error encountered in metadata generated for exported symbol 'MatInput':
 E:/DevTest/material2/src/lib/input/input.ts:165:48: Metadata collected contains an error that will be reported at runtime: Expression form not supported.
  {"__symbolic":"error","message":"Expression form not supported","line":164,"character":47}
    at E:\DevTest\material2\node_modules\@angular\compiler-cli\src\metadata\collector.js:663:27
... etc.

Browser (Chrome) console has:
Failed to load resource: the server responded with a status of 404 (Not Found)
zone.js:690 Unhandled Promise rejection: (SystemJS) XHR error (404 Not Found) loading http://localhost:4200/dist/packages/material/public-api.js
	Error: XHR error (404 Not Found) loading http://localhost:4200/dist/packages/material/public-api.js
	    at XMLHttpRequest.wrapFn (http://localhost:4200/node_modules/zone.js/dist/zone.js:1166:39)
	    at ZoneDelegate.invokeTask (http://localhost:4200/node_modules/zone.js/dist/zone.js:425:31)
	    at Zone.runTask (http://localhost:4200/node_modules/zone.js/dist/zone.js:192:47)
	    at ZoneTask.invokeTask [as invoke]

... etc.
What are the steps to reproduce?
Providing a StackBlitz/Plunker (or similar) is the best way to get the team to see your issue.
Plunker starter (using on @master): https://goo.gl/uDmqyY
StackBlitz starter (using latest npm release): https://goo.gl/wwnhMV

Download zip (11/11/17 - 3PM) of material2-master.zip
Unzip to folder (material2)
Bring up cmd window and navigate to folder
Follow procedure on Getting Started page (https://material.angular.io/guide/getting-started) and install @angular/material, @angular/cdk, @angular/animations, also hammerjs
Run npm install
Run npm run demo-app ... this leads to the errors above.

What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 5.0.1, Material 5.0.0-rc0, OS - Windows 10 Pro 64-bit, TypeScript 2.4.2, browser Chrome: 62.0.3202.75
Is there anything else we should know?
Nothing I can think of.

Will be fixed by https://github.com/angular/material2/pull/8367.


CI: Outdated GitHub actions

Hi,
Would you like to enable dependabot for this repo?
IMHO, at least for github-actions it would be a good enhancement. Otherwise, golang would possible as well, for updating the whole module vendoring.
If you agree, I can submit a PR for this.
Thank you!

I wasn't aware you could setup dependabot for actions. I'd be happy to take a look at a PR :+1:


Add option to open automatically the VNC session if there is only one

I am using selenoid just because I want to use my computer while running the tests. It would be nice if I had an option to automatically show the VNC window fullscreen if there is only one session running and this option is activated.

@istvandesign how would you imagine that option, can you describe it more precisely?

@lanwen Hello, my idea is to have a flip switch near the Starts/Capabilities in the header which when set to ON would open the last created vnc session maximized if there are no others sessions running.


Undo/Redo Actions for Components

Components should support undoing/redoing operations that modify the structure.

Resolved in builds >= 3.4.4199


R CMD build is run in wrong directory

When executing bash r-packaging.sh the resulting xtensor... tar.xz doesn't contain the headers. This is, because the folder in which R CMD build R-package is executed in is the root folder and not build, so only the template get's packaged.

Right it must be run from the build folder.

I fixed the readme.


[FormBuilderDropdown]: wrong alignment when using flutter sdk 3.22.0

Is there an existing issue for this?

[X] I have searched the existing issues

Package/Plugin version
9.2.1
Platforms

[X] Android
[ ] iOS
[ ] Linux
[ ] MacOS
[ ] Web
[ ] Windows

Flutter doctor

Flutter doctor

[✓] Flutter (Channel stable, 3.22.0, on Microsoft Windows [Version 10.0.22631.3593], locale en-US)
    • Flutter version 3.22.0 on channel stable at F:\libs\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5dcb86f68f (2 weeks ago), 2024-05-09 07:39:20 -0500
    • Engine revision f6344b75dc
    • Dart version 3.4.0
    • DevTools version 2.34.3

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\victo\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Zulu\zulu-17\bin\java
    • Java version OpenJDK Runtime Environment Zulu17.50+19-CA (build 17.0.11+9-LTS)
    • All Android licenses accepted.

[✓] Android Studio (version 2023.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0--11572160)

[✓] VS Code (version 1.89.1)
    • VS Code at C:\Users\victo\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.88.0

[✓] Connected device (1 available)
    • Redmi Note 8 (mobile) • 139ed888 • android-arm64 • Android 13 (API 33)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Minimal code example

Code sample

FormBuilderDropdown<String>(
  name: 'hello_world',
  autovalidateMode: AutovalidateMode.onUserInteraction,
  decoration: const InputDecoration(
    hintText: 'Hello world',
    suffixIcon: Icon(
      Symbols.expand_more,
    ),
  ),
  icon: const SizedBox.shrink(),
  items: const [
    DropdownMenuItem(
      value: '1',
      child: Text('Option 1'),
    ),
    DropdownMenuItem(
      value: '2',
      child: Text('Option 2'),
    ),
  ],
),

Current Behavior
The hint text alignment of FormBuilderDropdown is wrong in Flutter SDK 3.22.0:

Expected Behavior
Downgrade to Flutter SDK 3.19.6 fixed the issue

Steps To Reproduce
Upgrade Flutter SDK to 3.22.0
Aditional information
No response

Hi!
Can test with original Flutter dropdown to know if the bug is the same?

It seems that it's the problem of Flutter itself:
https://github.com/flutter/flutter/issues/148532
I will investigate tomorrow since it's getting late where i live.

Yep, confirmed to from flutter
Using this example:

Yep, confirmed to be from Flutter:
DropdownButtonFormField(
  decoration: const InputDecoration(
    hintText: 'Language',
    alignLabelWithHint: false,
  ),
  items: const [
    DropdownMenuItem(
      value: 'vi',
      child: Text('Tiếng Việt'),
    ),
    DropdownMenuItem(
      value: 'en',
      child: Text('English'),
    ),
  ],
  icon: const Icon(
    Icons.keyboard_arrow_down_rounded,
  ),
  onChanged: (value) {},
),


My project

My Idea project

@echoowall So, what are you doing for this, there is nothing changed but just a password


Feature/update requirements with hashes

What? and Why?

What does this pull request change/fix? Why was it nessessary?

Adds hashes for each requirement this should help avoid accidental or malicious changes.
Checklist

[x] CHANGELOG.md updated? (if required)

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   97.33%   97.33%
=======================================
  Files           8        8
  Lines         300      300
=======================================
  Hits          292      292
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c193b...0b9a81c. Read the comment docs.

 Turn on PIP hashed requirements.txt (3)

 Turn on PIP hashed requirements.txt (3)


Secure ase deployment

Hello Alex Buck and Adam Boeglin,
Can you please review, thank you.

OPS Build status updates of commit 2555682:
:clock10: Preparing: average preparing time is 45 sec(s)

OPS Build status updates of commit 2555682:
:clock10: Incremental building: average incremental building time is 22 sec(s)

OPS Build status updates of commit 2555682:
:warning: Validation status: warnings

File
Status
Preview URL
Details

bread/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

docs/example-scenario/apps/ecommerce-scenario.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-architecture.png
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-with-architecture.png
:white_check_mark:Succeeded
View

docs/example-scenario/apps/secure-deploy-to-app-svc-env.md
:white_check_mark:Succeeded
View

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\zrhr\bread\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\zrhr\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\zrhr\building-blocks\extending-templates\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 4cf8760:
:clock10: Preparing: average preparing time is 45 sec(s)

OPS Build status updates of commit 4cf8760:
:clock10: Incremental building: average incremental building time is 22 sec(s)

OPS Build status updates of commit 4cf8760:
:warning: Validation status: warnings

File
Status
Preview URL
Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

bread/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

docs/example-scenario/apps/ecommerce-scenario.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-architecture.png
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-with-architecture.png
:white_check_mark:Succeeded
View

docs/example-scenario/apps/secure-deploy-to-app-svc-env.md
:white_check_mark:Succeeded
View

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\ifbv\building-blocks\extending-templates\toc.json'.

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\ifbv\bread\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\ifbv\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit f40dccf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/example-scenario/apps/ecommerce-scenario.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/fully-managed-secure-apps.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-architecture.png
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-with-architecture.png
:white_check_mark:Succeeded
View

docs/example-scenario/apps/secure-deploy-to-app-svc-env.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 8327fdf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/example-scenario/apps/ecommerce-scenario.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/fully-managed-secure-apps.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-architecture.png
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-with-architecture.png
:white_check_mark:Succeeded
View

docs/example-scenario/apps/secure-deploy-to-app-svc-env.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 2084f09:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/example-scenario/apps/fully-managed-secure-apps.md
:warning:Warning
View
Details

docs/example-scenario/apps/media/ilb-ase-architecture.png
:white_check_mark:Succeeded
View

docs/example-scenario/apps/fully-managed-secure-apps.md

Line 32: [Warning] Invalid file link:(~/example-scenario/apps/media/ilb-ase-with-architecture.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 1a44f72:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/example-scenario/apps/fully-managed-secure-apps.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-architecture.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 436852c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/example-scenario/apps/fully-managed-secure-apps.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-architecture.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit a875847:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/example-scenario/apps/fully-managed-secure-apps.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-architecture.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 525a8ae:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/example-scenario/apps/fully-managed-secure-apps.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-architecture.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9c12ec4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/example-scenario/apps/fully-managed-secure-apps.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/media/ilb-ase-architecture.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions


Changing :options during run-time, are not applied with update()

I have created a codesanbox, with the full code of the described particular issue below: https://codesandbox.io/s/vqm9rn4ry7.
What I'm expecting here is: to toggle the wheelPropagation with a click on the button, and scrolling in the provided "container" where the perfect-scrollbar is applied, to "propagate / not propagate" the scrolling on the main screen. depending of the value for variable: wheelPropagation.
Code is in the components/ScrollbarTest.vue and from there you can see that in the <perfect-scrollbar> component I'm dynamically passing the :options:
    <perfect-scrollbar
      :options="{ wheelPropagation: wheelPropagation }"
      ref="scroll"
      class="container"
    >

where the second wheelPropagation is a variable in my component:
  data() {
    return {
      wheelPropagation: false,
      ...
    };
  },

changing this value with a click on a button - inside the method:
    toggleWheelPropagation() {
      let self = this;
      //setTimeout(() => {
      //self.$nextTick(() => {
        self.wheelPropagation = !self.wheelPropagation;
        self.refs["scroll"].update();
      //});
      //}, 0);
    }

Is actually not applying the new values in the passed :options property.
I also tried using the setTimeout() and $nextTick() methods, but also was not working.
So I'm wondering: am I doing something wrong here, or maybe this is actually not supported?

"self.$refs"

However dont work:
https://codesandbox.io/s/vue-template-bf8qo

I suggest to watch on options props then when props were changed we should update perfect scrollbar instance. I'm not sure if update method (from PS) is applying changes options ? Maybe we should destroy and create new. What do you think ?

I suggest to watch on options props then when props were changed we should update perfect scrollbar instance. I'm not sure if update method (from PS) is applying changes options ? Maybe we should destroy and create new. What do you think ?

In this case, our block will jump

@ivan0071 @o4umevshiy check my PR -> https://github.com/mercs600/vue2-perfect-scrollbar/tree/9-feat-watchOptions


SdkContainerImageBuilder should take machineType configs

When prebuilding the python SDK container harness image with SdkContainerImageBuilder on google cloud build, it can run out of memory and fail the build with docker exit code 137. The default machineType is only n1-standard-1 and it is unlikely sufficient to build large images.

The SdkContainerImageBuilder should take additional machineType configs to circumvent the docker OOM issue.
Imported from Jira BEAM-12447. Original Jira may contain additional context.
Reported by: yichi.

Issue is fixed.


day1 tasks: contains lots of struff related to learning / motivation

needs either to be added somewhere else or removed.

can this be closed?

outdated


WFLY-14388 resolve expression for transaction-support attribute in r-a subsystem.

Issue: https://issues.redhat.com/browse/WFLY-14388  resolve expression for transaction-support attribute in r-a subsystem.
In r-a subsystem ResourceAdapterSubsystemParser and ResourceAdapterParser rely on resolved value of transaction-support (user specified transaction support level of the resource adapter among NoTransaction, LocalTransaction and XATransaction) to read/write connection-definition attributes. It's not a perfect approach, but that's the reason transaction-support attribute is defined to determine XA.
Also I have removed unused isXa in parseTimeOutand unused resource-adapters-xapool-expression2.xml
@tadamski  please review. thanks.

Sounds fine so long as we're in agreement re what I say at https://issues.redhat.com/browse/WFLY-14388?focusedCommentId=15896045&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15896045


Need contents after Week 13

I can't find anything after Week 13...? Can anyone help me?

@royayon
The content is missing after week 13, I couldn't complete it since my focus direction has changed, I will try to finish it the upcoming month.


  I apologize if this is just ignorance on my part, but it doesn't appear that controller.get_broadcastnode nor controller.get_multicast_group are supported.  A quick peek at zwave-js-server/command.ts shows that the commands themselves don't appear to be implemented.   It does look like the broadcast_node and multicast_group classes are implemented.  If I'm wrong, I would appreciate a brief description on how to access those methods.

As I suspected, I didn't quite understand how multicast and broadcast groups worked.  Turns out that you can access that functionality directly by using the Broadcast and  Multicast Group services.  Having the controller fetch (or create) a group is unnecessary because Zwave creates them dynamically...


[Question] Is there any plan to upgrade cloud function gen 2?

I am one of the users of the algolia extension on firebase.
a few days ago, I received an email from firebase regarding cloud functions, the contents are more or less like this :

Question :
will firestore-algolia-search still use cloud function gen 1?

need change imports from firebase-functions to firebase-functions/v1 before September 1, 2024.

or firestore-algolia-search will upgrade to cloud function gen 2?

I am waiting on the Google Firebase team to let me know if Gen2 is supported.  Last time I checked, they were going to look into it.  I will check again.

The extension team has confirmed that Gen2 functions is now supported.  I am going to start the process of moving toward supporting V2 function.

ok, it looks like gen2 is not support for Cloud Firestore.  I will check with the Firebase team to see when this will be supported.

what problem are you facing with Cloud Firestore on V2?
I'm using today with
import {onDocumentCreated} from "firebase-functions/v2/firestore";
export const exportChatInvite = onDocumentCreated(
  {document: "collection/{document}/subcollection/{memberId}", region: "europe-west1"},
  async (document) => {

@smomin If you don't mind me asking. We're working on migrating a project to v2 too. A colleague noticed this commit of yours where you reverted to back V1 functions. Was there a specific issue you faced that caused the revert?

Firestore extension does not support v2 functions so I had to remove it.


Sometimes Trees (leaves) get decayed during worldgen

should be fixed https://github.com/quentin452/Novam-Terram-Continuation/commit/10f67467590e05c02362bec53cdf3e7537b51009

not fixed


TypeScript ES6 decorator emit leaves class in a position closure doesn't re-write

eg
blaze-bin/third_party/javascript/angular2/github/modules/angular2/src/web_workers/shared/serializer.js
contains
let Serializer = class {
...
};
Serializer = __decorate([
    di_1.Injectable(),
    __metadata('design:paramtypes', [render_store_1.RenderStore])
], Serializer);
exports.Serializer = Serializer;

With language_out=ES5, closure still leaves class keywords in the final JS.
//third_party/javascript/angular2/github/modules/angular2/src/web_workers/shared/serializer.js
goog.loadModule(function(exports) {'use strict';goog.module('angular2$src$web__workers$shared$serializer');
...
let Serializer = class {
...

This breaks us, even in Chrome where class is supported, because it disallows using call or apply on the constructor function of a class.

This is probably a closure issue. The foo-bundled.js file doesn't down-level the class construct, but foo.js output does.


Generator with demo settings

GUS: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00000f6e
Description
This is a follow up to #320
This PR updates the generator to allow users to select the new demo storefront as a backend.
Notes:
The project that is generated defaults to RefArchGlobal and en-GB locale. A separate PR will be submitted to update the generator to default to RefArch and en-US.
Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[X] New feature (non-breaking change that adds functionality)
[X] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

Pulled in from #320:

Add prompt to generator for demo settings or custom settings
Update custom prompts for accuracy
Shorten docs URLs slightly

How to Test-Drive This PR

In the pwa-kit-create-app directory, run node scripts/create-mobify-app-dev.js
Selecting the option to generate using Demo storefront creates a project with the demo storefront preconfigured
Selecting the option to use custom settings works the same as before.

Checklists

General

[ ] Changes are covered by test cases
[x] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[X] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

@vcua-mobify Thanks for your patience. I've put some suggestions over here. Some points to explain:
Your preset is intended to be an "ask no questions" preset, but it prompts for a question!
This strikes me as odd. My guess is that it isn't obvious how you would avoid it in the original code. But you can avoid it – we already do for some of the private presets (eg. TEST_PROJECT).
If we can get away without prompting for any questions, we should do so – having the prompt in there makes it much more difficult to script interactions with the generator, which is a thing people are likely to want to do.
The interface I'm shooting for on the suggestions PR is create-mobify-app --preset [PRESET_NAME]. If you run that and choose a preset that needs to ask questions, you see questions. If you choose "demo", then you shouldn't see them at all.
We're missing a good place to document the presets.
Putting these in the help text for the CLI makes it self documenting. Here's what I have right now:
Usage: create-mobify-app [options]

Generate a new PWA Kit project, optionally using a preset.

Examples:

  create-mobify-app --preset "prompt"
    Generate a project using custom settings for B2CCommerce, by answering
    questions on the CLI.

    Use this to connect to an existing instance.

  create-mobify-app --preset "demo-project"
    Generate a project using default settings for an existing demo B2CCommerce
    backend. This preset does not ask for input.

    Use this to try out SDK features against an existing backend.

Options:
  --outputDir <path>  Path to the output directory for the new project (default: "/Users/o.brook/repos/pwa-kit/packages/pwa-kit-create-app/pwa-kit-starter-project")
  --preset <name>     The name of a project preset to use (choices: "prompt", "demo-project", default: "prompt", env: GENERATOR_PRESET)
  -h, --help          display help for command

Lovely.
We should anticipate adding more presets, if it is easy to do so
Your current interface looks kinda like this:
> pwa-kit-create-app
> Do you want to use the demo backend (yes/no)? Yes
> Generating project!

To me, it's kind of unclear how you would evolve this to cleanly support other presets. If I asked us to support a preset for a supermarket vertical, what would the API look like?
If we add a --preset flag, to me it's obvious: --preset supermarket, --preset supermarket-demo, --preset one-commerce, --preset fancy-new-js-framerk... It just goes on and on.
I haven't tested my suggestions extensively – could you take a look and let me know what you think?

@vcua-mobify and I discussed this over call and here's what we decided:

We retain all changes related t o--preset as it's helps running it via CI and it's the future direction that we want to go for.
At the same time, we also retain changes related to default user experience.

This mean, if there is no --preset option in npx pwa-kit-create-app, then developer is given an option to chose between demo project (retail-react-app-demo) or advance BYO-sandbox (retail-react-app). Depending on their choice, we invoke one of the preset, and generate the project.

There's still quite a lot of confusion when I talk to people about what we want here. I just chatted to Jen to clarify – in my view this is the flow we are looking for without and with the --preset flag passed.
First, without:
> npx pwa-create-app
> Select a template to use:

> retail-react-app (the retail react app, with prompts connect to your existing backend)
> retail-react-app-demo (the retail react app, with no prompts - connects to a default demo backend)
> hello-world (a basic hello world project)

Then, with:
> npx pwa-create-app --preset hello-world
# Immediately generates the project. No further questions

> npx pwa-create-app --preset retail-react-app
# Continues with the usual prompts for the retail react app

> npx pwa-create-app --preset retail-react-app-demo
# Immediately generates the project. No further questions.

I'm trying to shoot for this so that we can support --preset uknown-exciting-thing in the very near future, too. So we can't make too many assumptions about what that thing is, other than that it has a name!


ENH Update CMS 6 support

Issue https://github.com/silverstripe/.github/issues/342

Good catch, updated


Can Fabric integrate Sawtooth Lake's consensus?

Description
I want to call Sawtooth Lake's consensus in Fabric, any ideas?
I also would like to know more about collaboration between Fabric and Sawtooth Lake.

They do not integrate today. One of the goals of the next architecture at https://github.com/hyperledger/fabric/wiki/Next-Consensus-Architecture-Proposal is to be able to support additional consensus algorithms such as PoET.
I would hope in the future that the projects evolve towards a common protocol.


Return a nonzero exit code when help/usage is displayed

The picoclii verson is 4.7.3, running with OpenJDK 17 on Ubuntu Server 22.04.  The gradle project builds for compatibility with Java 11.
I can't figure out how to have my program return a nonzero exit code if it displays the usage help.  I need my script to do something different based on the exit code.  Changng the exit code is easy enough in my own program logic, but I can't figure out how to have picocli do it automatically.
This is the main method I have concocted with help from the documentation, but if I run it without any of the required parameters, its exit code is still zero:
  public static final void main(final String[] args) {
    try {
      final CommandLine cmd = new CommandLine(new MailCheckMain());
      cmd.setHelpFactory(StaticStuff.createLeftAlignedUsageHelp());
      cmd.getCommandSpec().exitCodeOnUsageHelp(1).exitCodeOnVersionHelp(1);
      cmd.execute(args);
    } catch (final Exception e) {
      throw new RuntimeException("Error starting program", e);
    }
  }

This particular class does implement Runnable, so my logic can be found in the run() method.  I must be missing something.

I think this can be accomplished in the annotations.
See: https://picocli.info/#_exception_exit_codes
And https://picocli.info/apidocs-all/info.picocli/picocli/CommandLine.Command.html#exitCodeOnUsageHelp()
@Command(exitCodeOnUsageHelp = 42)
class Cmd { //...

You may need to do this in the @Command annotation for the subcommands also...

I already have the exitCodeOnUsageHelp parameter in the annotation.  It's not working.

This is the class signature:
@Command(name = "mail_status_check", sortOptions = false, scope = ScopeType.INHERIT, description = "End to End mail checker", exitCodeOnUsageHelp = 1)
public class MailCheckMain implements Runnable {

If you have any interest, I can share a repo URL for it.  It's not on github.  I can't find a way to send a private message on github, or I would have already sent it.

This test passes for me. Does it pass for you?
import org.junit.jupiter.api.Test;
import picocli.CommandLine;

import static org.junit.jupiter.api.Assertions.assertEquals;

public class ExitCodeTest {
    @Test
    public void testStandardExitCode() {
        @CommandLine.Command(mixinStandardHelpOptions = true)
        class App implements Runnable {
            public void run() { }
        }

        CommandLine cmd = new CommandLine(new App());
        int exitCode = cmd.execute("-h");
        assertEquals(CommandLine.ExitCode.OK, exitCode);
        int exitCodeVersion = cmd.execute("-V");
        assertEquals(CommandLine.ExitCode.OK, exitCodeVersion);
    }

    @Test
    public void testCustomExitCode() {
        @CommandLine.Command(mixinStandardHelpOptions = true, exitCodeOnUsageHelp = 33, exitCodeOnVersionHelp = 44)
        class App implements Runnable {
            public void run() { }
        }

        CommandLine cmd = new CommandLine(new App());
        int exitCode = cmd.execute("-h");
        assertEquals(33, exitCode);
        int exitCodeVersion = cmd.execute("-V");
        assertEquals(44, exitCodeVersion);
    }
}

Okay, looking at your original code, I can see the answer:
the code needs to call System.exit from the main method with the result of CommandLine::execute.
I believe this will work:
  public static final void main(final String[] args) {
    try {
      final CommandLine cmd = new CommandLine(new MailCheckMain());
      cmd.setHelpFactory(StaticStuff.createLeftAlignedUsageHelp());
      cmd.getCommandSpec().exitCodeOnUsageHelp(1).exitCodeOnVersionHelp(1);
      int exitCode = cmd.execute(args);
      System.exit(exitCode);
    } catch (final Exception e) {
      throw new RuntimeException("Error starting program", e);
    }
  }

(By the way, picocli does not throw any checked exceptions, so I believe you can omit the try/catch from the main method.)

Yep, the test worked.  I added the System.exit() and now it all works.   And I removed the try/catch with no compile errors.  It's basically a reflex adding that, because it's very often required.

Or maybe it's not completely correct.  Running with no options kicks back an exit code of 2, but I set both of the exit codes to 666, so I could be absolutely sure that the exit code would be very unique for usage printing.  It's nonzero now which makes my script work better, but not completely right.

The built-in exit codes are as follows:
By default, the execute method returns CommandLine.ExitCode.OK (0) on success, CommandLine.ExitCode.SOFTWARE (1) when an exception occurred in the Runnable, Callable or command method, and CommandLine.ExitCode.USAGE (2) for invalid input. (These are common values according to this StackOverflow answer). This can be customized with the @Command annotation.

Running with no options kicks back an exit code of 2 ...  It's nonzero now which makes my script work better, but not completely right.

As I recall your command requires a subcommand to be specified, so an exit code of 2 (incorrect usage) seems correct:
When a required option or required subcommand is missing, the execute method will return exit code 2. Is your expectation different?

As I recall your command requires a subcommand to be specified, so an exit code of 2 (incorrect usage) seems correct:
When a required option or required subcommand is missing, the execute method will return exit code 2. Is your expectation different?

This is a different project than the one that requires a subcommand.  For this one, only the one Command class is defined.  Picocli is my new hammer, and I am finding a lot of nails to use it on. :)  It's a GREAT tool.
I had set both the annotation parameter exitCodeOnUsageHelp = 666 and cmd.getCommandSpec().exitCodeOnUsageHelp(666); so I was expecting to see an exit code of 666.  I remember that with those setting, the exit code was 154 ... no idea at all where that came from.
The value of 2 is something I can use, and I have done so, but I was hoping for the very distinctive value.

I wonder if I should have put quotes around 666 for the annotation...

Can you provide a test (maybe like what I did above) to demonstrate the 666 vs 154 issue you mention?
Quotes in the annotations won’t compile (int value only).
And glad to hear you are enjoying using picocli! 😅

@elyograg were you able to reproduce the 666 vs 154 issue you mentioned? Could you provide a program to reproduce it?

@elyograg were you able to reproduce the 666 vs 154 issue you mentioned? Could you provide a program to reproduce it?

I will need to make a minimal project and experiment.

Yes, this is several months later, but… It's probably because exit code is always 8 bits? because 666 % 256 = 154


The logo is different in different pages

The logo in the home page and about page is different. Similarly, it is different in the contact page.
I could fix this this issue.
Please assign it to me

I could fix this issue.

Okay you have assigned someone to design a logo for the website, i'll work on this issue after thats ready?

Hey Mansiv, the logo is ready and it is present in the images folder as the name of ace.png and ace.svg . You can start your work.


Add support for structured curved mesh visualization in 2D

@bennibolm @erik-f @NichtLucas 2D waved flag seems to work now. Starting julia --project in this branch, using
julia> using Trixi2Vtk

julia> Trixi.trixi2vts("../main-Trixi.jl/out/solution_000041.h5")

yields the following VTS visualization in ParaView:

So, loading the mapping function from the string in the file is still somewhat brittle. With local ad-hoc modifications, I am able to also visualize the result of examples/2d/elixir_euler_free_stream_curved.jl:

We now plot CurvedMesh data on Lagrange cells, which allows for perfect resolution with only n_nodes visualization nodes. However, the nonlinear subdivision level in ParaView needs to be turned up to get proper results.
We removed duplicate code and reused most of the code for TreeMesh data.
It is possible to use more visualization nodes than DG nodes, which is useful for curved cells. While ParaView shows the exact interpolation if the Lagrange nodes are equidistant, it shows different results otherwise. This means that the data on curved cells is not exactly the correct interpolation. Using more visualization nodes somehow mitigates this problem.

All suggestion should be implemented now. n_max_cells=0 is still needed because we didn't add a default value there.

Can you please mark all resolved comments as such? And why do we still need n_cells_max=0?

I can't, it's not my PR. But all should be resolved now (maybe except the one with n_cells_max?).
In Trixi's load_mesh_serial we just added the max(n_cells, n_cells_max) but no default value for n_cells_max. We just added it for load_mesh but that's a restart file there.


have a "if you use this service in research, plz cite us" note in BridgeDb OpenAPI UI

@nunogit, is it feasible to make "branding" changes to the OpenAPI UI?

@egonw I am not sure I understand what you mean.
It's feasible to do changes to the UI. Colors, logos, etc.
Probably, also, make it open API, as we are still using swagger.
Do I answer your question?

Yes, sort of. The follow question is, of course, how do we practically go about to do this? What file needs to be changed? Which git repo holds that file?

Most likely the javascript on index.html. But we might be able to change the index.html only, depending on what you want to do.
https://github.com/bridgedb/swagger-webservice/blob/master/index.html
Where do you want to put this? I guess it should have some highlight.


Add description of consistency errors

@MarkvanMents , I have implement your review and I would be very grateful if you can have a look at content/refguide/consistency-errors-pages.md (if you have time ofc). I am particularly interested in what you think of introduction. Is the goal of the document clear after I extended the intro? In this case, I will copy it for other consistency errors docs.
Thanks in advance.


Fix inline snapshot indenting

Summary
Fixes #9477
Test plan
I've added a new test 🌮

Codecov Report

Merging #9523 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9523      +/-   ##
==========================================
+ Coverage   65.02%   65.03%   +0.01%
==========================================
  Files         283      283
  Lines       12114    12113       -1
  Branches     3000     3000
==========================================
+ Hits         7877     7878       +1
+ Misses       3598     3597       -1
+ Partials      639      638       -1

Impacted Files
Coverage Δ

packages/jest-snapshot/src/inline_snapshots.ts
82.17% <ø> (+1.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0d8ba...8a6466b. Read the comment docs.

Codecov Report

Merging #9523 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9523      +/-   ##
==========================================
+ Coverage   65.02%   65.03%   +0.01%
==========================================
  Files         283      283
  Lines       12114    12113       -1
  Branches     3000     3000
==========================================
+ Hits         7877     7878       +1
+ Misses       3598     3597       -1
+ Partials      639      638       -1

Impacted Files
Coverage Δ

packages/jest-snapshot/src/inline_snapshots.ts
82.17% <0.00%> (+1.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0d8ba...372ced3. Read the comment docs.

Codecov Report

Merging #9523 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9523   +/-   ##
=======================================
  Coverage   65.03%   65.03%
=======================================
  Files         283      283
  Lines       12113    12113
  Branches     3000     3000
=======================================
  Hits         7878     7878
  Misses       3597     3597
  Partials      638      638

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 372ced3...cecda64. Read the comment docs.

Thanks!


About download personal like page

I use the link：https://www.tumblr.com/liked/by/foobar
add blog, then add to queue, then crawl.
But there is always a error:
Error 1: You need to login to tumblr.com for downloading foobar. Go to settings -> authenticate.
But after I finish authentication, the error 1 appeared again, and I have to authenticate again, and the error again... infinite loop.
How to fix it?

I don't know, since this has never happened to me, thus all I can do is guessing. Could you elaborate more on your system, and what steps you did to trigger this behavior? Windows version, any antivirus/security software that might block access to the Internet Explorer cookies?! Do you use the Internet Explorer for browsing?
Here is some one with the same symptom. He delete the cache/cookie within the Internet Explorer (settings wheel -> Internet Options -> Browsing History -> Delete), re-authenticated and it worked afterwards:
https://github.com/johanneszab/TumblThree/issues/171#issuecomment-345447059
I'd really love to improve the code if there is something wrong, but based on your description, there is nothing I could possibly do.

@johanneszab I was having the same problem and clearing IE cache worked for me. But now I encounter another one. The program just downloads some images and then stop. I have to Add to queue again for it to continue but after a few times, it just says Evaluated x tumblr blog site and stop. No more images getting downloaded. Download url list doesn't seem to work either.

I'm again just guessing, and without seeing it for myself, I cannot really do much.
If that is happening during downloading liked/by posts, then set the settings back to defaults. I.e. not one connection, also not too many. Something like 5-10, but increase the time out option.
For me it sounds like the crawler connection dies and stalls the application. Crawling likes couldn't be usefully parallelized since there was no was of way of telling the maximum time span of the liked/by posts beforehand. And since every new page contains a time stamp that is embedded in the previous page, the scanning serial.
I haven't checked what would happen if that thread dies, but since you could always download a few more posts, that somehow sounds like it. As written in the description l the code for notification of those events is still missing, and my connection here is rather quick and stable.
Like I've mention in all other threads here before: Include the URL you want to download, otherwise I cannot look into it. And if you share the url, how many posts did it download for you? Another thing you should do is to always test everything with the defaults again before opening a new issue.
But thanks already for the detailed description and giving some insights to the previous question.

I've browsed until I've found 3 blogs random blogs where I could access the liked/by site. For me, there is no issue. Default settings, simple added the sites and click on crawl:

Until I get a web site (or even better, sample photo or video posts) were a large amount of downloads is missing, I assume that there is no issue.


Login page can't Login and the loader spins forever

The issue being that the login process failed to proceed and the loader spins forever after the latest event source update (0.3.17)

No error message from AWS end.

#29


851 create form submission model

🔗 Issue
(https://github.com/rubyforgood/pet-rescue/issues/851)
✍ Description
Create form_submission model

create test for form_submission model
create the foreign key for has many relationship between form_submission and submitted_answer
create the foreign key for has many relationship between form_submission and adopter_application
update submitted_answer model test to include new association with form_submission
update adopter_applicaiton model test to include new association with form_submission

Added an associations context block
this also involved creating a form_submission factory that can be called within tests

📷 Screenshots/Demos

@Gabe-Torres This is looking good so far! Like you said, the pipeline is not passing because the seeds are not loading due to an error - my immediate guess is that AdopterApplication and SubmittedAnswer do not have a FormSubmission to belong to.
To your questions about adding in the additional components to get the tests to pass - ideally, yes. PRs should be complete and always pass the pipeline. This will likely mean updating the seeds to make sure associated objects exist, and to update any test setups that also need the object to exist. Now, if this is starting to look like a huge chunk of work, we can always help you out! Let me know what you think! Ask as many questions as you need.

context "associations" do

@Gabe-Torres This is looking good so far! Like you said, the pipeline is not passing because the seeds are not loading due to an error - my immediate guess is that AdopterApplication and SubmittedAnswer do not have a FormSubmission to belong to. So it will be a matter of creating that object and passing it to its associations in both Baja and Alta seeds files. I usually like to just focus on one seed file first and get that working, then it's more or less a copy paste into the other file as they should be almost identical.
To your questions about adding in the additional components to get the tests to pass - ideally, yes. PRs should be complete and always pass the pipeline. This will likely mean updating the seeds to make sure associated objects exist, and to update any test setups that also need the object to exist. Now, if this is starting to look like a huge chunk of work, we can always help you out! Let me know what you think! Ask as many questions as you need.
I usually try to break things up more into smaller chunks. But, given this is addition of a model, we need to add it and make sure it's working as expected. So, it's a bit more work...but should not be too much more as it's just two associated models. Famous last words.

Thank you for the feedback @kasugaijin ! I can get sidetracked sometimes, so it's good to know I was on the right track. I updated tests where needed and made some tweaks to the adopter_applications factory to account for the new association with form_submissions.
Regarding seeds – How are we planning to handle a form_submission instance? In my current version, I created one form_submission object that has an association with the organization at the top of the file, along with a singular person. The seeds create 10 adopter applications. Do you think it would make sense to also create 10 form_submissions, or would that suffice for our needs?

context "associations" do

@Gabe-Torres This is looking good so far! Like you said, the pipeline is not passing because the seeds are not loading due to an error - my immediate guess is that AdopterApplication and SubmittedAnswer do not have a FormSubmission to belong to. So it will be a matter of creating that object and passing it to its associations in both Baja and Alta seeds files. I usually like to just focus on one seed file first and get that working, then it's more or less a copy paste into the other file as they should be almost identical.
To your questions about adding in the additional components to get the tests to pass - ideally, yes. PRs should be complete and always pass the pipeline. This will likely mean updating the seeds to make sure associated objects exist, and to update any test setups that also need the object to exist. Now, if this is starting to look like a huge chunk of work, we can always help you out! Let me know what you think! Ask as many questions as you need.
I usually try to break things up more into smaller chunks. But, given this is addition of a model, we need to add it and make sure it's working as expected. So, it's a bit more work...but should not be too much more as it's just two associated models. Famous last words.

Thank you for the feedback @kasugaijin ! I can get sidetracked sometimes, so it's good to know I was on the right track. I updated tests where needed and made some tweaks to the adopter_applications factory to account for the new association with form_submissions.
Regarding seeds – How are we planning to handle a form_submission instance? In my current version, I created one form_submission object that has an association with the organization at the top of the file, along with a singular person. The seeds create 10 adopter applications. Do you think it would make sense to also create 10 form_submissions, or would that suffice for our needs?

So the benefit of the FormSubmission is that we should be able to associated multiple adopter applications with a single FormSubmission, so let's go with that in the seeds for now.

@Gabe-Torres Looking great! Just a few comments.

Awesome! I changed the belongs_to association to acts_as_tenant.  Thank you @kasugaijin. I think everything is updated and ready to go!

@Gabe-Torres approved, but please add the comments to the class per my comment above.

Added! Apologies, I had added the comments before merging the most recent main and must of not added them while sorting conflicts.


Scrolling doesn't work on the main wonders screen on macOS

Mouse wheel scrolls don't scroll the content. Works with trackpad

I have MX Master 3 mouse that has dedicated horizontal scroll wheel.
It works, but it's not perfect.
The bigger the screen the more you need to scroll for the page to switch.
When using full screen window QHD 2560x1440 then it's really hard to scroll to the next page.
When resizing window to smallest size then it's easy to scroll pages too fast and skip pages.

Scrolling does work using the SHIFT modifier, which is the default Flutter behavior. We have also added some physical next/prev btns.


Fix StringBuilder cache corruption on recursive access

I would prefer a fix with the minimal amount of LOCs required.

You are right. I have changed the implementation as you suggested and it indeed looks better. :100: Thanks for the review. :heart_eyes: