Convert from Axle to Mutiny

According to @Sanne the strategy going forward should be to use Mutiny instead of Axle, so we should convert dependencies over and also upgrade to the newest version of Mutiny (0.0.14 as of writing this).

Well wait up

Look, the actual thing that is being proposed, that has not been fully discussed and agreed upon yet, is to migrate the API of Hibernate RX to use Uni/Multi instead of CompletionStage, or possibly offer both options.
Now, if we're planning on only supporting Uni/Multi, then what we would be doing here is going through all the code of Hibernate RX and migrating all of it away from CompletionStage. On the other hand, if we decide it's worth maintaining both APIs as options, then it seems to me that we should be offering the Mutiny API as a separate optional façade, and retaining the use of CompletionStage throughout the rest of the code base.
Whatever, this issue is not a simple matter of "swap out axle and add an unnecessary dependency on mutiny when we're not even using it's APIs". That doesn't make sense at all.

Now, if we're planning on only supporting Uni/Multi, then what we would be doing here is going through all the code of Hibernate RX and migrating all of it away from CompletionStage.

That's what I was expecting and I think it would be nice to see what it involves with an initial PR.

On the other hand, if we decide it's worth maintaining both APIs as options, then it seems to me that we should be offering the Mutiny API as a separate optional façade, and retaining the use of CompletionStage throughout the rest of the code base.

As far as I can see converting a Uni/Multi to CompletionStage is quite trivial, so mantaining both API could be done by adding a facade on top of Mutiny that converts the results to CompletionStage (I think).
Wouldn't that make sense?

+1 on using Uni/Multi by default. I think it's very similar to Reactor's Mono/Flux concept which I like a lot and it is easy for users to grasp.
Since it's so easy to convert to completion stage (just tack on .convert().toCompletionStage()) we may not even need to provide a facade since users could easily convert on their own. We could always provide a facade later if we find that users prefer CompletionStage.

Right, but here's my issue: Mutiny and CompletionStage aren't AFAIK the only things in the whole wide reactive universe, and at some stage we might want to support something else as well. If that's likely, then it seems to me that it would make more sense to retain CompletionStage as the "lowest common denominator" thing, merely because it's right there in the JDK, and doesn't require that people who're using something other than Mutiny still drag along Mutiny as a dependency.
Note: it's not that I'm attached to CompletionStage at all (just like @FroMage, I think it's a mess of an API, actually), nor that I'm at all hostile to Mutiny (I have not even looked at it yet, but I trust you guys that it's much better).

(If MutinySession is just a façade, then I suppose that mutiny could be an optional dependency. But if we reimplement this project to use mutiny APIs internally, then it's going to be a hard requirement at runtime.)

That's a very valid point @gavinking. I think the thing that would make Mutiny a good base-requirement option is the fact that it has explicit bridge methods for all of the big reactive APIs out there today: CompletionStage, Reactor, and RxJava (see the "How do I interact with X" sections)
To me this makes Mutiny look like a really attractive API to use internally, because we won't be on the hook for maintaining the conversion logic to CS/Reactor/RxJava. If Mutiny was "yet another reactive API" I would quickly dismiss it as an option, but the interop features it has with the other APIs makes it really compelling IMO.

I would prefer having Mutiny only on the exposed API initially: it's a very
young project and we don't know yet how cast in stone it is, how it
performs, etc..
Of course I don't mean it should be strictly exclusively referenced in the
API but take the boundaries in the most pragmatic manner, and keeping in
mind that indeed we'd prefer to keep our options open to other models.
We could eventually have multiple public APIs so to have something for each
flavour of reactive - hopefully basing this on the Mutiny adaptors but
keeping in mind we might have to adapt.
On Sat, 11 Apr 2020, 16:22 Andrew Guibert<EMAIL_ADDRESS>wrote:

That's a very valid point @gavinking https://github.com/gavinking. I
think the thing that would make Mutiny a good base-requirement option is
the fact that it has explicit bridge methods for all of the big reactive
APIs out there today: CompletionStage, Reactor, and RxJava (see the "How
do I interact with X
https://smallrye.io/smallrye-mutiny/#_how_do_i_interact_with_completionstages"
sections)
To me this makes Mutiny look like a really attractive API to use
internally, because we won't be on the hook for maintaining the conversion
logic to CS/Reactor/RxJava. If Mutiny was "yet another reactive API" I
would quickly dismiss it as an option, but the interop features it has with
the other APIs makes it really compelling IMO.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hibernate/hibernate-rx/issues/84#issuecomment-612445126,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAKMTMY3AZMAKUTATXWNQ3RMCDJ3ANCNFSM4MFBJ2AA
.

Closing this issue as a duplicate of #94


Keep the json structure constant with default values

What is happening now ?

JSON data structure is not uniform , when the author / description / the name of action is not defined in the YAML.
Filtering on these fields ( example for search functionality ) is hard since the function fails for undefined fields in JSON.

Solution :

Keep the JSON structure uniform for all the data received from the action by Injecting a default value if its not defined in the action.yml file.

Awesome, thanks for adding this! Some small suggestions that I will process myself and then I'll make a new release out of this.


chore(master): release 1.29.0

:robot: I have created a release beep boop
1.29.0 (2024-09-02)
Features

landmark: add screenshare teleport landmarks (#661) (69a7682)
program buttons: stop only (8f00fa1)
program instance list (ea639fc)
program list with ttl (7eb2cc7)

Bug Fixes

auth: only request single-scene specific perms when rendering scene (43d80fe)
chat: disable chat message ui when user permissions are removed (4e9e801)
make sure subscribe is only called after connect (4c802fb)
mqtt connect (64c4fd4)
particles: fix particle load failure introduced in #f54e682 (5c85f87)
screenshare: add landmarks for named screenshare objects (c00455b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/arenaxr/arena-web-core/releases/tag/v1.29.0 :sunflower:


Compilation warnings in PG11 and final error upon CREATE EXTENSION

Hi,
I tried to compile the extension for PG11 but the following warnings appeared:
In file included from inetrange.c:9:0:
inetrange_canonical.c: In function ‘inetrange_canonical’:
inetrange_canonical.c:11:19: warning: implicit declaration of function ‘PG_GETARG_RANGE’ [-Wimplicit-function-declaration]
   RangeType  *r = PG_GETARG_RANGE(0);
                   ^
inetrange_canonical.c:11:19: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
inetrange_canonical.c:21:14: warning: implicit declaration of function ‘PG_RETURN_RANGE’ [-Wimplicit-function-declaration]
   if (empty) PG_RETURN_RANGE(r);
              ^
inetrange_canonical.c:34:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Moreover, when I tried to CREATE  EXTENSION inetrange ... I got the following error:
Query execution failed

Reason:
SQL Error [XX000]: ERROR: could not load library "/usr/lib/postgresql/11/lib/inetrange.so": /usr/lib/postgresql/11/lib/inetrange.so: undefined symbol: PG_GETARG_RANGE

Tia

Thank you for the report! I haven't tried building this against pg11 before, but I'll take a look.

Confirmed: I can built it against pg10, but on Ubuntu 16.04 after doing sudo apt-get install postgresql-11 postgresql-server-dev-11 I get the same errors.

Looks like PG_GETARG_RANGE was renamed: https://www.postgresql.org/message-id/11607.1505246855%40sss.pgh.pa.us

Fixed in https://github.com/pjungwir/inetrange/commit/42c467a06d69666dcaf9277acc1ee456f0f884cf and release 1.0.1.


Cli user docs

Update install page and fix bin/omero -> omero in cli docs.

Travis is failing on finding redirects:
     [exec] Adding redirects:
     [exec]
     [exec] Exception occurred:
     [exec]   File "/home/travis/virtualenv/python3.6.7/lib/python3.6/shutil.py", line 121, in copyfile
     [exec]     with open(dst, 'wb') as fdst:
     [exec] FileNotFoundError: [Errno 2] No such file or directory: '/home/travis/build/ome/ome-documentation/omero/_build/html/sysadmins/server-overview.html'

This was changed recently, https://github.com/ome/ome-documentation/pull/2042/commits/2e2202c2d7867fafb8592c191c9c8b086f55de31 cc @joshmoore

Redirect is fixed with my last PR. New failure is:
     [exec] Warning, treated as error:
     [exec] /home/travis/build/ome/ome-documentation/omero/users/clients-overview.rst:2:Duplicate explicit target name: "omero.figure".

Nice. Thanks!

I have no idea what Duplicate explicit target name: "omero.figure" failure meant, but it drew my attention to the excess paragraph.

Duplicate explicit target name: "omero.figure"

Pretty sure it just means you linked to the same thing twice.


add stations and update names to be more consistent

adding some stations and changed names to be more consistent with others

Sorry, I made a mistake by copying the file from my current HA without the latest commit for this file. I readded it


Cannot set item in hand when spawning entity

See: https://forums.spongepowered.org/t/spawning-skeleton-with-item-in-hand/19794/4
It looks like unimeplemented yet.
spongevanilla-1.11.2-6.1.0-BETA-11
spongeforge 1.11.2-2315-6.1.0-BETA-2438

Please backport to 1.11.2 too - api 6.1.0. Thanks.

@hunter688 Done.


As a user I want to be notified when a  new app version is available

I currently am trying to implement auto-update and with that notifications. This is my very WIP branch: https://github.com/meetalva/alva/tree/feat/autoupdate

Added in 32c259ca052ccfa83500cffcb24acbcf71adca0a


Add UR robot support

This PR adds support for velocity controlled UR robots, specifically the UR5e.
As it should run off the same code base and the UR has 6 joints compared to the 7 of Panda, many things are generalized in this PR. Most notably, the moma_ocs2_ros is now a templated header-only library.
The gains for the UR are tuned (lowered) according to the velocity control approach and allow a safe operation without noise.

For review, it's easiest to first check the changes to definitions.h, which introduce helper functions for getting state and input dimensions from the configurable arm input dimension. These are used throughout the code.
There are some "TODO"s that are labeled as hard-coded. These are at places where we have no direct ability to get the joint count from anywhere else. So they are just kept like this for now.
Since we omitted the frame transforms relying on the transform buffer due to controller crashes, a proper checking of world frame is now implemented.

Well done! I do not have any major comment. The only thing is that we have quite some code duplication just for the ur robot (which is also using a standard VelocityInterface).

Well done! I do not have any major comment. The only thing is that we have quite some code duplication just for the ur robot (which is also using a standard VelocityInterface).

Yes, there is a lot of overlap between panda_mpc and ur_mpc, which could be abstracted or commonized into ocs2_mpc_ros.
I think that's something one could address in a separate PR, since such a change would have made reviewing this PR more difficult.

Yes, lets keep it like that for now. Maybe other changes between the two robots are needed which are not visible at the moment, given the limited testing.


[SPARK-7106][MLlib][PySpark] Support model save/load in Python's FPGrowth

What changes were proposed in this pull request?
Python API supports mode save/load in FPGrowth
JIRA: https://issues.apache.org/jira/browse/SPARK-7106
How was the this patch tested?
The patch is tested with Python doctest.

cc @mengxr @yanboliang  Could you take a look at this?

Test build #51768 has started for PR 11321 at commit b7145ac.

Test build #51768 has finished for PR 11321 at commit b7145ac.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class FPGrowthModel(JavaModelWrapper, JavaSaveable, JavaLoader):

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51768/
Test PASSed.

@vectorijk Please check this commit https://github.com/apache/spark/commit/9ca79c1ece5ad139719e4eea9f7d1b59aed01b20 and update your PR. Thanks!

Test build #51830 has started for PR 11321 at commit 10580d2.

@mengxr Thanks, I didn't notice that. Addressed comment.
Also, I take a look at 9ca79c1 and it only moved cleanup temp file code for doctest under ml directory. Meanwhile, it seems like we should do the same thing under mllib. Should we also need to create a JIRA issue for this?
off-topic
I was wondering if Spark community would be interested in mentoring students for Google Summer of Code(GSoC) under Apache Software Foundation this year. Last time, I was impressed by the MechCoder's project mentored by @mengxr. Therefore, I look forward to having a chance to do something interesting and continue to contribute to codebase during this summer.
@mengxr, Are you still interested in mentoring a MLlib PySpark related project this summer? If so, I am very willing to brainstorm with you and others on JIRA about what could be probably worked on during this summer. And I might start to write the proposal for GSoC. If there are some pre-GSoC issues related to project, I would love to work on those.
P.S Here is the post I published on dev mailing list.

Test build #51830 has finished for PR 11321 at commit 10580d2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51830/
Test PASSed.

Test build #51874 has started for PR 11321 at commit f4b5357.

Test build #51874 has finished for PR 11321 at commit f4b5357.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51874/
Test PASSed.

LGTM. Merged into master. Thanks!
For GSoC, I created https://issues.apache.org/jira/browse/SPARK-13489 to collect some project ideas. Let's move our discussion there. If I don't have time to mentor a GSoC project, other committers might be interested. Could you prepare a draft proposal and post it on the JIRA?

@mengxr, Thanks for replying!
Definitely, I will post a rough draft proposal on JIRA later.
On Wed, Feb 24, 2016 at 11:31 PM, Xiangrui Meng<EMAIL_ADDRESS>wrote:

LGTM. Merged into master. Thanks!
For GSoC, I created https://issues.apache.org/jira/browse/SPARK-13489 to
collect some project ideas. Let's move our discussion there. If I don't
have time to mentor a GSoC project, other committers might be interested.
Could you prepare a draft proposal and post it on the JIRA?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/11321#issuecomment-188651306.


Remove compression from the message metadata

Description
ADO:2942
It is safe now to remove the compression flag from the message metadata and leave only the top level compression message field.
Breaking Changes
This is technically a breaking change, as new runtimes will not be able to process compressed payloads from the older runtimes and we could deal with this. However, this is not a shipped feature and also an experimental feature, therefore it is safe to abruptly end support for such a short-lived message protocol.

Seems to produce a consistent test failure. Investigating..


Why is Visual Studio 2017 giving Messages in the Error List when using the sample JSON within a DeploymentProject?

Why is Visual Studio 2017 (VS2017) giving Messages in the Error List when using the sample JSON within a DeploymentProject?
Repo steps:

Go to VS2017 and open an existing DeploymentProject (.deployproj) or create a new one
Add a new file Azure Resource Manager Deployment Template
Go to the "Create empty resource group" section of this article
Copy the JSON
Go back to VS2017 and paste in the text
Under "resources", both "type" and "apiVersion" are highlighted with green swigglies
Go to Error List Window and make sure you have Messages enabled
I see 3 Messages:
a. Line 14 (the curly brace line within "resources") - Value must conform to exactly one of the associated schemas
b. Line 15 (the "type" line) - Value must be one of the following values: "Microsoft.ServiceFabric/clusters/applications/services"
c. Line 16 (the "apiVersion" line) - Value must be one of the following values: "2017-07-01-preview"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: da55b847-6066-3e2b-09bc-160e17cf33f3
Version Independent ID: 9a08f975-dcf6-3e2d-0c77-845a1b94271e
Content: Create resource group in Azure Resource Manager template
Content Source: articles/azure-resource-manager/create-resource-group-in-template.md
Service: azure-resource-manager
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@JimInWA Thanks for the Comment. We are actively investigating and will get back to you soon.

@tfitzmac  - any insights on this please?

@JimInWA - thanks for the feedback. This is a schema validation issue but it does not affect the ability to deploy the template. For some reason, that type has not been added to the schema yet. I will try to find out why it is not present.

#please-close

Actually, don't close. I am exploring a potential issue. #hold-off

@JimInWA - this article was showing the wrong schema file. The validation warnings disappear if your use:
"$schema": "https://schema.management.azure.com/schemas/2018-05-01/subscriptionDeploymentTemplate.json#",

Thanks for the update, that fixed my issue.
Follow-up question (let me know if I need to create a separate issue for it): Is there public Docs page that has all of the latest schemas published at https://schema.management.azure.com/schemas/?
I realize that I can I go to https://github.com/Azure/azure-resource-manager-schemas/tree/master/schemas and drill through all of the folders, but it would be really helpful if there was single page that had the latest versions without having to drill through each of the folders looking for a specific file (e.g. subscriptionDeploymentTemplate.json).
Thanks,
Jim.

There are just two template schemas you need to know about - 2015-01-01 deployment template and 2018-05-01 subscription deployment template.
If you look in those files, you'll see referenced schemas versions for each resource type. Each type can be listed more than once, so it is not just the latest. Occasionally, a valid resource type is not listed in the template schema, but it is still usable.
I'll look for a good place to include that information in the docs.

The interesting thing is that while "https://schema.management.azure.com/schemas/2018-05-01/subscriptionDeploymentTemplate.json#" worked for the scenario described in my issue report, it caused other Messages in the Error List in VS2017 in my actual ARM templates.
The really interesting thing is that on a lark I tried "https://schema.management.azure.com/schemas/2018-05-01/deploymentTemplate.json#" and it worked, meaning that it resolved all of the Messages in the Error List window (but the appropriate file is not in the 2018-05-01 folder in GitHub).

Yes, "2018-05-01 subscription deployment template" is just for subscription level resources. That would be resource groups, roles, and policies. "2015-01-01" for resource group level resources which would be most other resources. Policies can work in either schema.


Clean up copy specs

Add @Override annotations where necessary
Add @Nullable and @NonNullApi annotations where necessary
Some small optimizations
Fix IntelliJ warnings
Remove some dead code

This is about salvaging as much as possible from #4655.

Branch build: https://builds.gradle.org/viewQueued.html?itemId=11552054

Branch build: https://builds.gradle.org/viewQueued.html?itemId=11552853

New build: https://builds.gradle.org/viewQueued.html?itemId=11556021

@wolfs since all tests pass I'm going to merge this now. Feel free to review post-merge, though.

@wolfs thanks for the review, please take a look at https://github.com/gradle/gradle/pull/4721


[nrf fromlist] cmake: Zephyr module processing set modules path

This PR is inspired by: https://github.com/NordicPlayground/fw-nrfconnect-nrf/pull/1576.
to minimize the need for knowing the path of other modules, as seen here:
https://github.com/hakonfam/fw-nrfconnect-nrf-1/blob/41d353f5e67c3dbc0501807b4ccc3cb28a4c1be2/cmake/mcuboot.cmake#L2

This commit introduces the variable:
ZEPHYR_${MODULE}_MODULE_DIR that can be used for modules to obtain
locations of other modules.
As example: a module which requires the knowledge of mcuboot con now
fetch this information using ZEPHYR_MCUBOOT_MODULE_DIR.
Signed-off-by: Torsten Rasmussen<EMAIL_ADDRESS>

This is great, let's send it upstream.

Can you please send this directly upstream?
We are going to upmerge in the next few days

Done:
https://github.com/zephyrproject-rtos/zephyr/pull/21226

History in this repository has been rewritten. Please rebase this PR.

Edit: actually, can't this simply be closed? We should get this in the next mergeup via zephyrproject-rtos/zephyr#21226.

If next rebase is happening soon (which I assume it will), then agreed, we can simply close it.

If next rebase is happening soon (which I assume it will), then agreed, we can simply close it.

I believe @anangl is beginning the next rebase soon.

If next rebase is happening soon (which I assume it will), then agreed, we can simply close it.

I believe @anangl is beginning the next rebase soon.

I'm sorry, I meant to say "mergeup", not "rebase".


Line breaks for ObjectPatternComma doesn't work like expected

I try make these two ways of destruction possible:
a) let {foo, bar} = this.props
b)
let {
   foo,
   bar
} = this.props

As I understand the documentation this would be lineBreak.after.ObjectPatternComma = "<2" but this adds always a line break.

DEBUG=rocambole:br:* ./bin/esformatter --lineBreak.after.ObjectPatternComma="<2" --lineBreak.after.ObjectPatternOpeningBrace="<2" --lineBreak.before.ObjectPatternClosingBrace="<2"

shows that line break is added because of --lineBreak.before.Property=">=1" (setting it to -1 solves the conflict but is not a valid solution):
  rocambole:br:before typeOrValue: Property, expected: >=1, value: foo +0ms
  rocambole:br:between diff: 1 +4ms
  rocambole:br:before typeOrValue: Property, expected: >=1, value: bar +1ms
  rocambole:br:between diff: 1 +0ms

will probably need to skip Property automatic line break if inside ObjectPattern - should be easy to fix.


[Feat]: Dark mode vanishes on refresh

What feature?
I have an idea to persist changes of dark/light mode feature also after refresh in a tab.
Add screenshots
Add screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

can I work on this under GSSOC 24?

@rahul803213 Do you want to work in it? and how you will resolve it?

@shyamtawli I will use Local Storage of the browser to save theme preferences.

@rahul803213 Go ahead

Thank you @shyamtawli

Hi there,
I'm enthusiastic about your project and would love to contribute to its improvement! Could you assign me the task of fixing the dark mode issue ?
Looking forward to your response.
Best regards,
Jishnay

I would like to resolve this can I go ahead? it will take me just few minutes.

Is this issue is still Open ?


Opting in and out of cookies

User story
As a user I want to be able to opt-in or out of cookies either on the cookie banner or on the cookies page at any time. So that I can control what data I share with Government Digital Service and Google.
Acceptance criteria

[ ] Show the cookie banner if the user has not set their cookie preferences
[ ] By default the GTM tag should not be active if the user has not set their preference
[ ] If the user clicks "accept analytics cookies" in the cookie banner then hide the banner and enable the GTM tag. The tag should fire on every return visit going forward.
[ ] If the user clicks "reject analytics cookies" in the cookie banner then hide the banner and continue with the GTM tag not being active
[ ] If cookies are rejected then hide the banner for up to 30 days
[ ] If the user clicks "View cookies" in the banner then go to the cookies page (https://platforms.service.gov.uk/help/cookies.html)
[ ] On the cookies page there should be 2 radio options, one option which says "Use cookies that measure my website use" and the other that says "Do not use cookies that measure my website use" (following the pattern on GOV.UK https://www.gov.uk/help/cookies)
[ ] If the user has already set their preferences then the correct radio button should be selected
[ ] If the user has not set their preference then both radio buttons should be in an empty state
[ ] The user can change their choice of if they are opted-in or opted-out and then they can press a button which says "Save changes"
[ ] On change of preference the GTM tag should be enabled/disabled depending on the change

@mgearon-gds
If cookies are rejected then hide the banner for up to 30 days
In general, none of GDS/DSP frontend estates do this. We set the cookie with a 1 year validity regardless of the preference set.
If the team would still like to set the 30 day limit, I'll work to extend the cookie policy objecy with a created date and then in the initial check extent to work out 30 days since that date.
For the cookies page form, I have gone with what's described on https://design-system.service.gov.uk/patterns/cookies-page/ and hot what gov.uk says.
If required, I can amend the working  to says Use cookies that measure my website use" and the other that says "Do not use cookies that measure my website use"

@kr8n3r let's go with 1 year validity to match other frontend estates please. Happy to go with what has been described on the cookies page.


v4.0.0 Incorrect ApiException exception references

ApiException class was moved, however references/phpdocs throughout the code do not point to the new location.
e.g.
\DocuSign\eSign\Client\ApiException is referenced in many places as \DocuSign\eSign\ApiException which my editor PHPStorm complains about it not existing.
I also noticed that the PHP code is not to PHP best practices in places.
I would recommend using phpstan to scan the code: https://github.com/phpstan/phpstan

Here is the code analysis from PhpStorm:
I suggest a serious tidyup is needed. This is not production ready code in my eyes.

Thank you for the bug report. I have filed internal bug DCM-3372
Re: I also noticed that the PHP code is not to PHP best practices in places.
I would recommend using phpstan to scan the code: https://github.com/phpstan/phpstan
I have filed enhancement request DCM-3373

Hi @abarke ,
DocuSign engineering reports that this problem has been solved. Can you verify?
Many thanks,
Larry

Confirmed. Working with v5.0.0 and I dont see these errors anymore. Thanks.

Excellent, thank you


Installation issues

I am a new user to sift and was coming across this issue through installation both on Ubuntu 16.04 and 18.04.  Currently I am booting Ubuntu from a live-usb, could that be the issue, otherwise I am going to try out the ova.
me:/$ sudo sift install
<EMAIL_ADDRESS>
sift-version: notinstalled

Installing and configuring SaltStack properly ...
Command failed: apt-get install -y --allow-change-held-packages salt-minion
E: Unable to correct problems, you have held broken packages.
Error: Command failed: apt-get install -y --allow-change-held-packages salt-minion
E: Unable to correct problems, you have held broken packages.
at ChildProcess.exithandler (child_process.js:205:12)
at emitTwo (events.js:106:13)
at ChildProcess.emit (events.js:194:7)
at maybeClose (internal/child_process.js:899:16)
at Socket.<anonymous> (internal/child_process.js:342:11)
at emitOne (events.js:96:13)
at Socket.emit (events.js:191:7)
at Pipe._handle.close [as _onclose] (net.js:511:12)

I have tried going through and obtaining multiple other package requirements for salt-minion and salt-common, but with no succes of installation.  I have also tried to figure out what packages are broken with zero display from dpkg -l | grep ..^r
I no longer have any other ideas on what I am doing wrong and any sense of direction would be appreciated.

Sounds like your apt is broken. Try installing something like apt-get install curl to see if there's a problem and try to correct it.

Cool, thanks for the insight.


[beta] Remove unnecessary hover references

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[ ] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Removed a part of the description of a challenge, since the challenge requirements were changed. Removed also some code from the next challenges for consistency. See issue #12979 for more details.

Note: As you can see, as of now (21 feb) I did not test the changes locally, because I'm having some problems with my local setup and I wanted to finish the pull request thing so I can focus only on tests (it's the first time I use Git from command line, have mercy). I'll update the PR as soon as I solve this.
EDIT: solved it! Changes were successfully tested on my local setup.

Decription edited, I tested the changes locally and everything looks fine to me.

:1st_place_medal: Congrats on your first PR! Looks good to me! :1st_place_medal:
Closes #12979


Open problem: Prove ¬◇a => ⊥^a constructively or prove it is impossible to prove

Currently, the proof ¬◇a => ⊥^a requires a do be decidable, which means it only holds in classical logic. See modal::npos_to_para. This will be available in v0.27.
The problem is whether this is possible to do constructively or not.
This requires proving ¬◇a => ⊥^a constructively or ⊥^((¬◇a => ⊥^a)^⊤) constructively (or similar) in Prop.

Closed by https://github.com/advancedresearch/prop/pull/469
Conclusion: It is constructive.


Cherry Pick #843 Into Master

@swift-ci please test.

My CI-foo must be weak this morning.
@swift-ci please test

Thanks!

FWIW Build on Ubuntu16.04 is still failing with this import in a different file.
CoreFoundation/Collections.subproj/CFBasicHash.c:14:10: fatal error: 'Block.h' file not found
#include <Block.h>
         ^~~~~~~~~
18 warnings and 1 error generated.

I would still expect you to need Block.h to compile CF. I don't expect you to need it to import Foundation.


Hardening of SQL Editor -> Visualize flow

MVP feature in getting Caravel SQL Lab to general availability

Notice: this issue has been closed because it has been inactive for 525 days. Feel free to comment and request for this issue to be reopened.


Test Beckn-ONIX GUI installer provided by Mulearn

Supported the entire day today. At EOD the status is:

BAP/BPP registration is failing
LT needs to be manually installed for the GUI installer to work

I will open a new ticket for further support on Monday.


[.Net] update GeminiChatAgent.cs

Why are these changes needed?
multipe -> multiple
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

@eltociear Hey, thanks for the PR, we are going through a major refactor on a new AutoGen architecture for the main branch currently so we may have to postpone merging this PR until then. You can find out more information for the new architecture under #3601.

@LittleLittleCloud - can you decide whether this work should come forward and be adapted to 0.4?

This PR is against AutoGen 0.2. AutoGen 0.2 has been moved to the 0.2 branch. Please rebase your PR on the 0.2 branch or update it to work with the new AutoGen 0.4 that is now in main.


Add support to Conventional Commits automatically with Commitzen

Why
Because will make easier ensure that all commits are being done thinking in Semantic Release
How
We could just use Husky and Commitzen like this video:

https://youtu.be/F3B8W3yPPSo
https://youtu.be/1eTofdmfq1g

@omariosouto, I saw that there are 2 commits (https://github.com/elvinciqueira/core/commit/fd07dd18da6d51bba764a825dcf13a5e610cc90f and https://github.com/skynexui/core/commit/58abd17403515c80bfeb2cd4127ced5fbee56bdf) about this issue, but it's not in the main branch.
Do you still need help with this? If so, I will love to help 😉


NIFI-10202 ConvertJSONToSQL issue with primary keys for UPDATE statem…

NIFI-10202 ConvertJSONToSQL issue with primary keys for UPDATE statement from "statement.type" attribute fixed

Thanks for the contribution @kmor76, this is resolved in pull request #6652


apparmor: add initial AppArmor CRD management implementation

What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements the initial mechanics to manage AppArmor's CRD without the actual apparmor lower-level code.
Which issue(s) this PR fixes:
Relates to #118
Does this PR have test?
N/A
Special notes for your reviewer:
Follow-up PR to include apparmor logic and tests.
Does this PR introduce a user-facing change?
NONE

Codecov Report

Merging #650 (7520b47) into master (417797b) will increase coverage by 0.78%.
The diff coverage is 81.63%.

@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
+ Coverage   43.38%   44.16%   +0.78%
==========================================
  Files          31       31
  Lines        1920     1963      +43
==========================================
+ Hits          833      867      +34
- Misses       1040     1049       +9
  Partials       47       47


[SPARK-19694][ML] Add missing 'setTopicDistributionCol' for LDAModel

What changes were proposed in this pull request?
Add missing 'setTopicDistributionCol' for LDAModel
How was this patch tested?
existing tests

Test build #73255 has started for PR 17021 at commit 367a681.

Test build #73255 has finished for PR 17021 at commit 367a681.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73255/
Test PASSed.

LGTM

Merge to master


Python 2.7 Windows Support

Hello,
I stumbled across this while looking for an alternative to pyodbc for an ETL application that I've built using pandas and sqlalchemy. Because of existing design decisions and my organization's internal IT structure, I'm somewhat stuck using Windows Server and MS SQL Server for hosting the app and data that I'm processing. The current application is built in Python 2.7 and everything works great except for very  slow insert times with pyodbc for large (10,000 - 400,000) datasets into MSSQL. I have adapted a "fast_load" workstream with ceODBC, but it doesn't seem to be actively developed and some of my data sets have NVARCHAR('max') fields that throw an error when the values are too large (doesn't happen with pyodbc).
Long story short, I'd like to replace them both with one module that is fast and can handle the large strings. Am I in the right place?
I saw that Windows support was recently released for Python 3.5+. Is there any chance of getting Python 2.7 support also? I'd be willing to help implement the necessary changes to downgrade, but I thought I'd see what the general thoughts on the level of difficulty is first.

Hi! Thanks for coming here :-). To your questions: Yes, turbodbc can deal with strings, even large ones. There are a few caveats, though.

The first one is that turbodbc will allocate buffers that are sufficiently large to handle any supported value in a given column. For a VARCHAR(4000) that would be 4000 bytes, for a TEXT column that would be 2^31 bytes. This approach requires lots of memory for unrestricted columns. I have proposed a solution at #76 which I plan to implement soonish.
Currently, turbodbc cannot deal with retrieving result sets with columns that contain VARCHAR(MAX). Actually, I heard about this type from your issue :-). The thing is that ODBC drivers translate VARCHAR(MAX) to a VARCHAR type with length 0 (see this reference). Turbodbc happily uses this 0 as the actual length of the string and will allocate buffers for null termination characters. I would fix that in the same go as I fix #76, basically by passing turbodbc a maximum size that is reserved for such "unlimited" columns.

For inserting strings, turbodbc also uses a buffered approach, but the buffer size is dynamically adjusted to what you actually want to insert using an exponential strategy. So if you insert about 6000 characters, a buffer of approximately 6-8 kB will be allocated.
Regarding the Python 2.7 support, there is nothing intrinsic to turbodbc that forbids the use of Python 2.7. I continuously test it with Linux and OSX. The reason why I do not yet offer Python 2.7 support in Windows is that compiling the thing is more difficult for Python 2.7, apparently because Python 2.7 was built with an earlier compiler than I require. Once this problem is solved (don't know exactly how at the moment, but I am no Windows expert), I can release additional binary wheels. Changes should be limited to the build support files such as appveyor.yml, setup.py, and probably some CMakeLists.txt files.
I hope this has not scared you too much... :-)

Thanks for the quick response. It sounds like the string issue is more in-depth than I had thought. Based on the other issue you linked (76), I'm not sure my use case fits with your goals for the package. The size of some of my NVARCHAR fields goes up to ~120,000 characters, and I'd like to preserve the content from the raw source if possible. I realize that storing large strings in this way isn't very efficient (might be better off storing what are essentially documents as binary and reading from them as needed). I'll try to rethink the uses of the information on my end, but I'll keep an eye on this for the implementation of 76 and see if it is a better fit at that point.

That sounds like a plan. I'll implement #76 nevertheless, and if setting a limit of 200,000 for you is okay, then you can give turbodbc a spin in the future and see what happens.
But you are right, turbodbc's main benefit is not the handling of large strings. Still, there's no reason why it should handle large strings not at all ;-).

@jhall6226 Small breakdown of things I did in a branch:

The CMake-based build with MSVC (Microsoft Visual Studio Compiler) 14 and Python 2.7 compiles and all tests pass.
Using python setup.py bdist_wheel uses MSVC 9, which leads to build errors.
After wading through source code and the internet, I could not identify a way to force python setup.py bdist_wheel to use a different version of MSVC for Python 2.7.

Doing further research on building Python extensions on Windows, there are statements from sources (1, 2) who know better than myself that extensions for Python 2.7 are supposed to be built with the compiler Python 2.7 was built with. That would be MSVC 9, also known as Visual Studio 2008. Visual Studio 2008 has no support for C++11 at all, and thus cannot be used to build turbodbc.
Failing to build Python 2.7 extensions with anything else than MSVC 9 would lead to a clash of C standard library versions, and this may lead to Bad Things (TM).
There are two hearts beating in my chest. One heart says: It is impossible to support Python 2.7 on Windows. Turbodbc relies on C++11 and pybind11, and pybind11 relies on C++11 even more. Without a compiler that knows C++11, there is no compiling turbodbc.
The other heart says: Well, the cmake build demonstrates MSVC 14 and turbodbc and Python 2.7 works fine, so what's the problem?
After some struggling with myself, I have to (grudgingly) close this story. I do not know how to make the setup.py build with MSVC 14 without patching setuptools with something that is considered a Bad Idea (TM). Even if the cmake build appears to work just fine for my set of integration tests, I cannot ignore the problems that will eventually surface. I am sorry, the problem just seems too fundamental.


Removed build.sh

Closes #300 , assuming it didn't do anything useful anymore

@debonte Is this good to be merged?


DotNetCoreCLI takes too long for some builds

ℹ We have been forwarded here from https://github.com/actions/virtual-environments/issues/1733
Required Information
Type: Bug
Name: DotNetCoreCLI
Environment
Azure Pipelies
For account name, team project name, build definition name/build number, see links in issue description.
Issue Description
We are experiencing some random extra build times in DotNetCoreCLI@2:
Here I have two example builds that shows the problem:

This build: unittest takes less than 1 minute.
This build: unittest takes 30 minutes

Between this two commits there are no changes on that c# project, therefore if we are not wrong, something in the cloud must be going on.
Error logs
None, the process seems to hang for a very long time, sometimes 30 min, sometim ~20min ....

ℹ We have split the build step and the unittest step in two separate jobs.
Now we get timeouts all the time on the unittest, example build
I hope this info helps, do you have any news on your side?

Here a build with dotnet verbosity level diagnostic enabled.

@damccorm are we sure this is an enhancement?
A step that used to take 49 seconds takes now 30 minutes, we will gladly work together to sort out this issue but I believe we need a input from your side to know if this is problem on our side or something is going on on the cloud.

¯\_(ツ)_/¯ Might be related to https://github.com/dotnet/sdk/issues/12281, https://github.com/dotnet/sdk/issues/1228, https://github.com/dotnet/sdk/issues/12445

The problem seems to be related to the dotnet test command. Adding --no-build and explicitely building it beforehand brings down the job build time from ~20 min to ~5 min.
Workaround:
+  - task: DotNetCoreCLI@2
+    displayName: build
+    inputs:
+      command: build
+      projects: 'myproject.csproj'
+      arguments: --configuration $(buildConfig) --verbosity $(dotnetVerbosity)
+
   - task: DotNetCoreCLI@2
     displayName: UnitTests
     inputs:
       command: test
       projects: 'myproject.csproj'
-      arguments: --configuration $(buildConfig) --verbosity $(dotnetVerbosity)
+      arguments: --configuration $(buildConfig) --verbosity $(dotnetVerbosity) --no-build
       testRunTitle: UnitTests

Adding @phanikmmsft to take a look at dotnet test

@anuragc617 @phanikmmsft  any news on this?

@anuragc617 @phanikmmsft  any news on this?

Since there is a workaround, I don't think anybody cares about this. Closing.

Since there is a workaround, I don't think anybody cares about this. Closing.


Fix: Duplicated proxies

Fix duplicated proxies in ProxiesList
Added groups by chain to reduce work in UI

Task linked: CU-8693mw54k Wallet details. App is stuck when open details


Incompatibility with Laravel 5.6? "Call to undefined method Dingo\Api\Routing\Route::getDomain()"

Q
A

Bug?
maybe

New Feature?
no

Framework
Laravel

Framework version
5.6.20

Package version
1.0.0-beta8

PHP version
7.16

Actual Behaviour
When running:
app('Dingo\Api\Routing\UrlGenerator')->version('v1')->route('route.alias', ['parameter'])
I get the following error
Error : Call to undefined method Dingo\Api\Routing\Route::getDomain()
Expected Behaviour
The route must be correctly generated.
Steps to Reproduce
config/app.php:
return [
    'providers' => [
        Dingo\Api\Provider\LaravelServiceProvider::class,
        ...,
    ],
    'aliases' => [
        'Route' => Illuminate\Support\Facades\Route::class,
        'DingoApi' => Dingo\Api\Facade\API::class,
        'DingoRoute' => Dingo\Api\Facade\Route::class,
        ...,
    ],
];

app/Providers/RouteServiceProvider.php:
    protected function mapApiRoutes()
    {
        \Route::prefix('api')->group(base_path('routes/api.php'));
    }

routes/api.php:
$api = app('Dingo\Api\Routing\Router');
$api->version(
    'v1',
    [
        'namespace' => 'App\Http\Controllers\Api\V1',
    ],
    function ($api) {
        $api->get(
            '/',
            [
                'as' => 'xpto',
                'uses' => 'xptoController@index',
            ]
        );
        $api->group(
            [
                'namespace' => 'Abc',
                'prefix' => 'abc',
                'middleware' => ['api.auth'],
            ],
            function ($api) {
                $api->get(
                    'getAbc',
                    [
                        'as' => 'api.abc.get',
                        'uses' => 'AbcController@getAbc',
                    ]
                );
            }
        );
    }
);

Possible Solutions
https://github.com/laravel/framework/blob/5.5/src/Illuminate/Routing/RouteUrlGenerator.php version is different from previous ones. it is since 5.5 that getDomain() was introduced.
Maybe it is necessary to update the current Routing/Route.php domain() method? To something like what exists in Illuminate/Routing/Route.php:
    /**
     * Get or set the domain for the route.
     *
     * @param  string|null  $domain
     * @return $this|string|null
     */
    public function domain($domain = null)
    {
        if (is_null($domain)) {
            return $this->getDomain();
        }

        $this->action['domain'] = $domain;

        return $this;
    }

you should use 2.0.0-alpha2 for 5.6 compatibility

@marconett Hey Marco! Thank you very much for the help and sorry for the trouble.


Minor word duplication

In the usWinAscent description, there is a sentence that starts like:

Also, this clipping behavior also interacts...

One ‘also’ is superfluous, I think.

Document details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1ae9457c-0d3d-c137-588b-81d54a086f07
Version Independent ID: 658c6d22-b9d1-1007-9cdb-6898911c9c75
Content: OS/2 - OS/2 and Windows metrics table (OpenType 1.9) - Typography
Content Source: typographydocs/opentype/spec/os2.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: alib

See the OT 1.9.1 alpha for draft revisions addressing this issue.


Update more unreads button to new design

Summary
Update the 'More Unreads' button to match the new design changes.
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/14141
Checklist

[x] Has UI changes

Device Information
This PR was tested on:

OnePlus 7 running on Android 10

Screenshots

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/4776
https://circleci.com/gh/mattermost/mattermost-mobile/4775

Artifact links:
https://4776-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk
https://4775-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa

@matthewbirtch I've made the suggested changes. Can you confirm the Shadows with respect to React Native?

Based on the screenshots, it looks like a few more tweaks need to be made:

The icon size is a bit smaller than the design
The font weight should be semi-bold
The shadow is close. I think if we change the shadowRadius to 4, we should be good

I placed the button from the design on to your screenshot to compare

I think that's it!

@matthewbirtch I think the font weight is a common problem on Android, can you tedt it on iOS and see if it is also present there?

The last review the font weight was incorrect on iOS too. I don't see any further commits to do a new build to test with?

I only now realized the font-weight issue.
In some time I'll push the changes.

@matthewbirtch

After applying suggested changes

@chuttam Is there a reason this didn't go through QA review?
Also after a PR is merged, the corresponding Jira ticket should be resolved with the fix version updated.

Hi @amyblais this PR has no functional changes just some styles.
It was an honest omition but not critical in any way

@josephbaylon feel free to review anyway

@chuttam Is there a reason this didn't go through QA review?

Whoops. Didn't realise there was no QA review done. I was last on the list to approve. Sorry about that @amyblais ! I'll keep an eye out.

Also after a PR is merged, the corresponding Jira ticket should be resolved with the fix version updated.

You bet.


[THY-51-85] Load Stats on Game End

Description
Load the current user’s stats from Firebase on Game End and update them if they’re out of sync with the local version.
The motivation is to allow users to retrieve their current stats from any device if they’ve logged in. There may be synchronization issues.

Branch: https://github.com/FHU/thywordle/tree/THY-51-85-load-stats-on-game-end


"is" keyword does not show up in completion

module M {
    function isString(y: string | number): y is
}

'is' doesn't show up in completion. This is not good for type predicates:

My language service was not up to date.


building from source on jetson tx1 aarch64.

Hi, thank you for the good work on mujoco.
I'm a (engineer) and I'm trying to use MuJoCo for my research.
I'm looking for some help with building from source on jetson tx1 aarch64_.
Here is a model which explains my question:
I followed the instructions from here.
But i got error while doing cmake --build . saying below.
I googled it. it seems like related to cmake problem. But i cannot solve it. Help me!
[ 62%] Linking CXX static library ../../../lib/libgtest_main.a
[ 62%] Built target gtest_main
[ 62%] Building CXX object test/CMakeFiles/fixture_test.dir/fixture_test.cc.o
[ 62%] Linking CXX executable ../bin/fixture_test
../lib/libfixture.a(fixture.cc.o): In function mujoco::SaveAndReadXml[abi:cxx11](mjModel_ const*)': fixture.cc:(.text._ZN6mujoco14SaveAndReadXmlB5cxx11EPK8mjModel_+0x164): undefined reference to std::filesystem::temp_directory_pathabi:cxx11'
fixture.cc:(.text.ZN6mujoco14SaveAndReadXmlB5cxx11EPK8mjModel+0x1ac): undefined reference to std::filesystem::__cxx11::path::_M_split_cmpts()' fixture.cc:(.text._ZN6mujoco14SaveAndReadXmlB5cxx11EPK8mjModel_+0x1b4): undefined reference to std::filesystem::__cxx11::path::has_root_directory() const'
fixture.cc:(.text.ZN6mujoco14SaveAndReadXmlB5cxx11EPK8mjModel+0x284): undefined reference to std::filesystem::__cxx11::path::_M_split_cmpts()' fixture.cc:(.text._ZN6mujoco14SaveAndReadXmlB5cxx11EPK8mjModel_+0xd20): undefined reference to std::filesystem::__cxx11::path::has_root_directory() const'
fixture.cc:(.text.ZN6mujoco14SaveAndReadXmlB5cxx11EPK8mjModel+0xd30): undefined reference to std::filesystem::__cxx11::path::has_filename() const' fixture.cc:(.text._ZN6mujoco14SaveAndReadXmlB5cxx11EPK8mjModel_+0xda0): undefined reference to std::filesystem::__cxx11::path::_M_split_cmpts()'
collect2: error: ld returned 1 exit status
test/CMakeFiles/fixture_test.dir/build.make:119: recipe for target 'bin/fixture_test' failed
make[2]: *** [bin/fixture_test] Error 1
CMakeFiles/Makefile2:5356: recipe for target 'test/CMakeFiles/fixture_test.dir/all' failed
make[1]: *** [test/CMakeFiles/fixture_test.dir/all] Error 2
Makefile:145: recipe for target 'all' failed
make: *** [all] Error 2

You need c++17 to build from source.

@kevinzakka
Hi, thank you for your attention.
But i am confused with your answer.
Because i already have the g++/cc -8 and -7 which are available to c++17.
(i read c++17 features are available  since gcc-5)
so, i compile g++/cc version 8.4.0. But i got this error.
hmm... does g++/cc 8.4.0 have c++17 compatibility, right?

The error log says cxx11 so it looks like it's not configured correctly. Make sure CXX and CC are exported correctly and double check things with which.

@kevinzakka
Thank you again for quick answer.
So, does it need gcc/++ version 11?
(i am new to this. so, sorry for messing around.)

@kevinzakka
you are right! after upgrading to gcc version 11, the error got resolved.
But i got another error saying, (any suggestion?)
[ 79%] Building CXX object test/engine/CMakeFiles/engine_ray_test.dir/engine_ray_test.cc.o
[ 79%] Linking CXX executable ../../bin/engine_ray_test
[ 79%] Built target engine_ray_test
[ 80%] Building CXX object test/engine/CMakeFiles/engine_sensor_test.dir/engine_sensor_test.cc.o
/home/jetson/mujoco/test/engine/engine_sensor_test.cc: In member function ‘virtual void mujoco::{anonymous}::RelativeFrameSensorTest_ReferencePosMatQuat_Test::TestBody()’:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:79: error: class template argument deduction failed:
std::vector expected_values(data->sensordata, data->sensordata+nsensordata/2);
^
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:79: error: no matching function for call to ‘vector(mjtNum*&, mjtNum*)’
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:411:2: note: candidate: template<class _Tp, class _Alloc, class _InputIterator, class> vector(_InputIterator, _InputIterator, const _Alloc&)-> std::vector<_Tp, _Alloc>
vector(_InputIterator __first, _InputIterator __last,
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:411:2: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:79: note:   couldn't deduce template parameter ‘_Tp’
std::vector expected_values(data->sensordata, data->sensordata+nsensordata/2);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:383:7: note: candidate: template<class _Tp, class _Alloc> vector(std::initializer_list<_Tp>, const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(initializer_list<value_type> __l,
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:383:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:79: note:   mismatched types ‘std::initializer_list<_Tp>’ and ‘mjtNum* {aka double*}’
std::vector expected_values(data->sensordata, data->sensordata+nsensordata/2);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:358:7: note: candidate: template<class _Tp, class _Alloc> vector(std::vector<_Tp, _Alloc>&&, const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(vector&& __rv, const allocator_type& __m)
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:358:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:79: note:   mismatched types ‘std::vector<_Tp, _Alloc>’ and ‘mjtNum* {aka double*}’
std::vector expected_values(data->sensordata, data->sensordata+nsensordata/2);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:348:7: note: candidate: template<class _Tp, class _Alloc> vector(const std::vector<_Tp, _Alloc>&, const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(const vector& __x, const allocator_type& __a)
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:348:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:79: note:   mismatched types ‘const std::vector<_Tp, _Alloc>’ and ‘mjtNum* {aka double*}’
std::vector expected_values(data->sensordata, data->sensordata+nsensordata/2);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:344:7: note: candidate: template<class _Tp, class _Alloc> vector(std::vector<_Tp, _Alloc>&&)-> std::vector<_Tp, _Alloc>
vector(vector&& __x) noexcept
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:344:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:79: note:   mismatched types ‘std::vector<_Tp, _Alloc>’ and ‘mjtNum* {aka double*}’
std::vector expected_values(data->sensordata, data->sensordata+nsensordata/2);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:326:7: note: candidate: template<class _Tp, class _Alloc> vector(const std::vector<_Tp, _Alloc>&)-> std::vector<_Tp, _Alloc>
vector(const vector& __x)
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:326:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:79: note:   mismatched types ‘const std::vector<_Tp, _Alloc>’ and ‘mjtNum* {aka double*}’
std::vector expected_values(data->sensordata, data->sensordata+nsensordata/2);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:295:7: note: candidate: template<class _Tp, class _Alloc> vector(std::vector<_Tp, _Alloc>::size_type, const value_type&, const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(size_type __n, const value_type& _value,
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:295:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:37: note:   cannot convert ‘data->mjData::sensordata’ (type ‘mjtNum* {aka double*}’) to type ‘std::vector<_Tp, _Alloc>::size_type {aka long unsigned int}’
std::vector expected_values(data->sensordata, data->sensordata+nsensordata/2);
^~~~
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:283:7: note: candidate: template<class _Tp, class _Alloc> vector(std::vector<_Tp, _Alloc>::size_type, const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(size_type __n, const allocator_type& __a = allocator_type())
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:283:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:79: note:   couldn't deduce template parameter ‘_Tp’
std::vector expected_values(data->sensordata, data->sensordata+nsensordata/2);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:270:7: note: candidate: template<class _Tp, class _Alloc> vector(const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(const allocator_type& __a) _GLIBCXX_NOEXCEPT
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:270:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:79: note:   candidate expects 1 argument, 2 provided
std::vector expected_values(data->sensordata, data->sensordata+nsensordata/2);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:259:7: note: candidate: template<class _Tp, class _Alloc> vector()-> std::vector<_Tp, _Alloc>
vector()
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:259:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:159:79: note:   candidate expects 0 arguments, 2 provided
std::vector expected_values(data->sensordata, data->sensordata+nsensordata/2);
^
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:173:57: error: class template argument deduction failed:
data->sensordata+nsensordata);
^
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:173:57: error: no matching function for call to ‘vector(mjtNum*, mjtNum*)’
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:411:2: note: candidate: template<class _Tp, class _Alloc, class _InputIterator, class> vector(_InputIterator, _InputIterator, const _Alloc&)-> std::vector<_Tp, _Alloc>
vector(_InputIterator __first, _InputIterator __last,
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:411:2: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:173:57: note:   couldn't deduce template parameter ‘_Tp’
data->sensordata+nsensordata);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:383:7: note: candidate: template<class _Tp, class _Alloc> vector(std::initializer_list<_Tp>, const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(initializer_list<value_type> __l,
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:383:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:173:57: note:   mismatched types ‘std::initializer_list<_Tp>’ and ‘mjtNum* {aka double*}’
data->sensordata+nsensordata);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:358:7: note: candidate: template<class _Tp, class _Alloc> vector(std::vector<_Tp, _Alloc>&&, const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(vector&& __rv, const allocator_type& __m)
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:358:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:173:57: note:   mismatched types ‘std::vector<_Tp, _Alloc>’ and ‘mjtNum* {aka double*}’
data->sensordata+nsensordata);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:348:7: note: candidate: template<class _Tp, class _Alloc> vector(const std::vector<_Tp, _Alloc>&, const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(const vector& __x, const allocator_type& __a)
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:348:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:173:57: note:   mismatched types ‘const std::vector<_Tp, _Alloc>’ and ‘mjtNum* {aka double*}’
data->sensordata+nsensordata);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:344:7: note: candidate: template<class _Tp, class _Alloc> vector(std::vector<_Tp, _Alloc>&&)-> std::vector<_Tp, _Alloc>
vector(vector&& __x) noexcept
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:344:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:173:57: note:   mismatched types ‘std::vector<_Tp, _Alloc>’ and ‘mjtNum* {aka double*}’
data->sensordata+nsensordata);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:326:7: note: candidate: template<class _Tp, class _Alloc> vector(const std::vector<_Tp, _Alloc>&)-> std::vector<_Tp, _Alloc>
vector(const vector& __x)
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:326:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:173:57: note:   mismatched types ‘const std::vector<_Tp, _Alloc>’ and ‘mjtNum* {aka double*}’
data->sensordata+nsensordata);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:295:7: note: candidate: template<class _Tp, class _Alloc> vector(std::vector<_Tp, _Alloc>::size_type, const value_type&, const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(size_type __n, const value_type& _value,
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:295:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:172:45: note:   cannot convert ‘(data->mjData::sensordata + ((sizetype)(((long unsigned int)(32 / 2)) * 8)))’ (type ‘mjtNum* {aka double*}’) to type ‘std::vector<_Tp, _Alloc>::size_type {aka long unsigned int}’
std::vector actual_values(data->sensordata+nsensordata/2,
^~
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:283:7: note: candidate: template<class _Tp, class _Alloc> vector(std::vector<_Tp, _Alloc>::size_type, const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(size_type __n, const allocator_type& __a = allocator_type())
^~
/usr/include/c++/7/bits/stl_vector.h:283:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:173:57: note:   couldn't deduce template parameter ‘_Tp’
data->sensordata+nsensordata);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:270:7: note: candidate: template<class _Tp, class _Alloc> vector(const allocator_type&)-> std::vector<_Tp, _Alloc>
vector(const allocator_type& __a) _GLIBCXX_NOEXCEPT
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:270:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:173:57: note:   candidate expects 1 argument, 2 provided
data->sensordata+nsensordata);
^
In file included from /usr/include/c++/7/vector:64:0,
from /usr/include/c++/7/functional:61,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:138,
from /home/jetson/mujoco_build/_deps/googletest-src/googlemock/include/gmock/gmock.h:59,
from /home/jetson/mujoco/test/engine/engine_sensor_test.cc:22:
/usr/include/c++/7/bits/stl_vector.h:259:7: note: candidate: template<class _Tp, class _Alloc> vector()-> std::vector<_Tp, _Alloc>
vector()
^~~~~~
/usr/include/c++/7/bits/stl_vector.h:259:7: note:   template argument deduction/substitution failed:
/home/jetson/mujoco/test/engine/engine_sensor_test.cc:173:57: note:   candidate expects 0 arguments, 2 provided
data->sensordata+nsensordata);
^
test/engine/CMakeFiles/engine_sensor_test.dir/build.make:75: recipe for target 'test/engine/CMakeFiles/engine_sensor_test.dir/engine_sensor_test.cc.o' failed
make[2]: *** [test/engine/CMakeFiles/engine_sensor_test.dir/engine_sensor_test.cc.o] Error 1
CMakeFiles/Makefile2:6032: recipe for target 'test/engine/CMakeFiles/engine_sensor_test.dir/all' failed
make[1]: *** [test/engine/CMakeFiles/engine_sensor_test.dir/all] Error 2
Makefile:145: recipe for target 'all' failed
make: *** [all] Error 2

You are right, again.
For the second error, i resolve it after switching to gcc/++ version to 8 (maybe 7 would be enough).
Thank you for the reply and I learn something from you.
I will close this 👍


Bring in-progress secure-messaging into master

In order to reduce the burden of keeping feature/secure-messaging branch up-to-date it will beneficial to rebase it as is into master and continue work from there.

merge!

!merge


Remove windows sourceVip config for kube-proxy

Environmental Info:
K3s Version:

Node(s) CPU architecture, OS, and Version:

Cluster Configuration:

Describe the bug:

k3s agent config is setting the sourceVip config of kube-proxy. That is wrong because it depends on the CNI plugin's hns overlay network. Setting sourceVip makes more sense in the rke2-windows executor, which is already happening: https://github.com/rancher/rke2/blob/master/pkg/pebinaryexecutor/pebinary.go#L190-L199
Steps To Reproduce:

Installed K3s:

If you use the rke2 windows-calico PR: https://github.com/rancher/rke2/pull/3543, to deploy rke2-windows, you'll notice multiple logs saying that it can't find a network called vxlan0:
time="2022-11-14T10:07:38-08:00" level=warning msg="can't find HNS network, retryingvxlan0" error="Network vxlan0 not found"

Expected behavior:

Actual behavior:

Additional context / logs:

This was reverted, so moved back to Working status

Verified with rke2 master branch commit 8f52bbbb4760922bd7851ff33d2880811c109547.
Observed no errors or warnings such as level=warning msg="can't find HNS network, retryingvxlan0" error="Network vxlan0 not found"
rke2 -v
rke2.exe version v1.25.4-dev+8f52bbbb (8f52bbbb4760922bd7851ff33d2880811c109547)
go version go1.19.3

time="2022-12-04T05:21:31Z" level=info msg="Generating HNS networks, please wait"
time="2022-12-04T05:21:31Z" level=debug msg="[GET]=>[/networks/] Request : "
time="2022-12-04T05:21:31Z" level=debug msg="Network Response : [{\"ActivityId\":\"49F62917-A5C7-4147-87FB-
...
time="2022-12-04T05:21:31Z" level=debug msg="evaluating if the interface: Ethernet 2 with addresses ...
time="2022-12-04T05:21:31Z" level=info msg="Creating VXLAN network using the vxlanAdapter: Ethernet 2"
time="2022-12-04T05:21:31Z" level=debug msg="hcsshim::HNSNetwork::Create id="
time="2022-12-04T05:21:31Z" level=debug msg="[POST]=>[/networks/] Request : {\"Name\":\"External\",\"Type\":\"Overlay\",\"NetworkAdapterName\":\"Ethernet 2\",\"Subnets\":[{\"AddressPrefix\": ...
...


Check if the accepted_error was not raised from test code

When using testing.numpy_cupy_** testing helpers, both NumPy and CuPy raise the same error type if the test script has a bug, for example, the wrong number of parameters.
This PR avoids passing such a wrong test unexpectedly.
Rel. https://github.com/cupy/cupy/pull/3702

pfnCI, test this please.

pfnCI, test this please.

Jenkins CI test (for commit d5e2d97132378db9c154a8659cde25609c86e66d, target branch master) succeeded!

Jenkins CI test (for commit d5e2d97132378db9c154a8659cde25609c86e66d, target branch master) succeeded!

Jenkins CI test (for commit d5e2d97132378db9c154a8659cde25609c86e66d, target branch master) succeeded!

Jenkins CI test (for commit d5e2d97132378db9c154a8659cde25609c86e66d, target branch master) succeeded!


Method rename detection

In some cases CodeShovel reports that a method was renamed but the original method still exists. In these cases, I would expect that CodeShovel would report as introduced.
77cfe/junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncher.java/discoverRoot___discoveryRequest-LauncherDiscoveryRequest__phase-String.json
commit: 830b6d5976b6db01dad3866cfb3d54c6216b1252: "Ymultichange(Yrename,Yreturntypechange,Ymodifierchange,Ybodychange)",

I think this has been resolved by the icse2021 CRC work.


catkin_make failed (turtlebot3)

ISSUE TEMPLATE ver. 0.2.0

Which TurtleBot3 you have?

[o ] Burger

Which SBC(Single Board Computer) is working on TurtleBot3?

[o] Raspberry Pi 3

Which OS you installed in SBC?

[o] Raspbian

Which OS you installed in Remote PC?

Call Stack (most recent call first):
CMakeLists.txt:63 (catkin_workspace)
-- +++ processing catkin package: 'turtlebot3_description'
-- ==> add_subdirectory(turtlebot3/turtlebot3_description)
CMake Error at /opt/ros/kinetic/share/catkin/cmake/catkin_workspace.cmake:116 (add_subdirectory):
The source directory
/home/pi/catkin_ws/src/turtlebot3/turtlebot3_description

does not contain a CMakeLists.txt file.
Call Stack (most recent call first):
CMakeLists.txt:63 (catkin_workspace)
-- Configuring incomplete, errors occurred!
See also "/home/pi/catkin_ws/build/CMakeFiles/CMakeOutput.log".
See also "/home/pi/catkin_ws/build/CMakeFiles/CMakeError.log".
Makefile:990: recipe for target 'cmake_check_build_system' failed
make: *** [cmake_check_build_system] Error 1
Invoking "make cmake_check_build_system" failed

Please, describe detailedly what difficulty you are in

Hi, This will not be the problem in my laptop but just in my turtlebot. I'm posting a question, hoping that there might be someone who experienced same problem during installing the turtlebot. i hope someone can help me to solve this problem or Error ^-^.. If anyone have any suggestions, please do let me know.

@Aidlieys
The packages you are having the issue with are not need in Turtlebot PC.
$ cd ~/catkin_ws/src/turtlebot3
$ sudo rm -r turtlebot3_description/ turtlebot3_teleop/ turtlebot3_navigation/ turtlebot3_slam/ turtlebot3_example/
Regards,
Ryan

@Aidlieys
The packages you are having the issue with are not needed in Turtlebot PC.
$ cd ~/catkin_ws/src/turtlebot3
$ sudo rm -r turtlebot3_description/ turtlebot3_teleop/ turtlebot3_navigation/ turtlebot3_slam/ turtlebot3_example/
Regards,
Ryan

So i need to put this program in PC or Turtlebot??

@Aidlieys
You should do it in your Tuetlebot.
As you can see on our e-manual, Turtlebot PC indicates the SBC in your Turtlebot, whereas Remote PC means your own PC (like your laptop).
Let us know if you have any other questions,
Ryan

@Aidlieys
You should do it on your Tuetlebot.
As you can see on our e-manual, Turtlebot PC indicates the SBC in your Turtlebot, whereas Remote PC means your own PC (like your laptop).
Let us know if you have any other questions,
Ryan

i have done do at my PC. and it become error when i try to doing turtlebot_slam.. how to fixed it back??
the command out :

slam_methods:=gmapping
[turtlebot3_slam.launch] is neither a launch file in package [turtlebot3_slam] nor is [turtlebot3_slam] a launch file name
The traceback for the exception was written to the log file

@Aidlieys
Please, check out our e-manual.
(http://emanual.robotis.com/docs/en/platform/turtlebot3/pc_setup/#pc-setup)
Regards,
Ryan

@Aidlieys
Please, check out our e-manual.
(http://emanual.robotis.com/docs/en/platform/turtlebot3/pc_setup/#pc-setup)
Regards,
Ryan

can help me solve another problem?? hehe ^-^
i try to bringup the camera..
$ roslaunch turtlebot3_autorace_camera turtlebot3_autorace_camera_pi.launch
command out :
[turtlebot3_autorace_camera_pi.launch] is neither a launch file in package [turtlebot3_autorace_camera] nor is [turtlebot3_autorace_camera] a launch file name
The traceback for the exception was written to the log file

@Aidlieys
Please refer to the following link.
(http://emanual.robotis.com/docs/en/platform/turtlebot3/autonomous_driving/#tutorials-1-requirements)
Also, as we cannot support every little issue you encounter while following the tutorial, I recommend you learn basic knowledge first at the following link (http://wiki.ros.org/ROS/Tutorials) and follow our e-manual.
Regards,
Ryan

Ok.. Thank for Help..

@Aidlieys
I will close this issue. Good luck with your work! Ryan


Silent loofah deprecation warning; GHA touch-ups; bump version

Description

c4b7165 Silent loofah deprecation warning
[1] https://github.com/flavorjones/loofah/commit/7cda1210a99721b4fa6fc0f659ac75f00bec6b11
544c515 Fix CI not running on primary branch
67f05eb Format GitHub Action files
1f98f6a Bump version to 4.38.3

References
N/A
Before merging this PR

[x] Fill out the Risks section
[x] Think about performance and security issues

Risks

[RUNTIME] Can this change affect apps rendering for a user? No, it's
used to validate SVG files.
[Low] What features does this touch? SVG validation. SafeList is an
alias of the old constant.

https://github.com/rubygems/rubygems.org/issues/3605
will retry

https://rubygems.org/gems/zendesk_apps_support/versions/4.38.3


Support wav2vec training on LibriSpeech

Hi @mravanelli, @TParcollet,
this is a PR for  wav2vec training on LibriSpeech.
The training is based on facebook/wav2vec2-large-960h-lv60-self, and I got 1.90 on test-clean, 3.96 on test-other.
The performance is close to the numbers reported here:
https://huggingface.co/facebook/wav2vec2-large-960h-lv60-self

Pre-trained model for reproducing the results:
https://drive.google.com/drive/folders/1uKpnllZRM3fs5KVAR7HiFlaNhefGdwLb
@aheba  you may also find this useful.

Great. @TParcollet, could you replicate this number? Once we replicated that and did the last changes I think we can merge it!

we have to put the model on HuggingFace

Note that according to the requirements we suggest pytorch 1.8. We actually support pytorch 1.9, which is working totally fine except for some annoying warnings triggered internally to pytorch 1.9.

I'm on it.

@30stomercury I tested, it works. Could you please add a README with the results ?

Once we have the results, I'll merge.

Ok, now LGTM. Merging after the tests. Thanks @30stomercury

Ok, can we merge then?


Add the new Legendary badge

Thanks for this, just need a couple of changes before merging.

Mostly fixed with #140


Version bump (v0.4.6)

Just bumping the version again for another IE fix

Looks like you need to push the tag, but other than that, this looks great!

Supposedly it's been pushed 🤔 at least, according to the CLI here

Looks like you need to push the tag, but other than that, this looks great!

Supposedly it's been pushed 🤔 at least, according to the CLI here

Doh, I'm dumb. I got trolled by the GitHub action. Apologies!


usblp0 removed

Bug description
print by usb, usblp0 removed
log:
usblp0 removed
usb 1-1.5: reset full-seep USB device number 11 using dwc_otg
Steps to reproduce

python3 test.py
code here:
from escpos import *

""" Seiko Epson Corp. Receipt Printer (EPSON TM-T88III) """
p = printer.Usb(0x09c5, 0x0588, 0, out_ep=0x2)
print(p)
p.text("Hello World\n")
p.barcode("6484848575", "CODE128", function_type="B")
str = "123\n"
p.text(str)
p.qr("https://www.google.com")
p.cut()
p.close()
Device info

Printer: Manufacturer Kuai Mai LabelPrinter

python-escpos version: 2.2.0
pyusb version: 1.0.2
pyserial version: 3.4
python version: 3.7
**operating system:**centOS 7.7

Hi,
sorry, I don't understand your issue. As far as I get it you are telling, /dev/usblp01 is missing on your platform. In this case I am not sure, how we can help you.

Hello i have the same issue, after executing the above code, dmesg | more shows "usblp0:removed".

thank you
发自我的iPhone
------------------ Original ------------------
From: kesienajoel @.>
Date: Sun,Jun 6,2021 1:55 PM
To: python-escpos/python-escpos @.>
Cc: MLGS @.>, Author @.>
Subject: Re: [python-escpos/python-escpos] usblp0 removed (#387)

I have same issue, /dev/usb/lp0 disappears after using Usb(0x04b8,0x0e2a).
Is there some workaround? How to re-add /dev/usb/lp0?

Hey, I have same issue,
def printer_print(_text: str, retry=10):
    _p = Usb(
        idVendor=0x0416,
        idProduct=0x5011,
        profile="NT-5890K",
    )
    logger.info("Trying to print...")
    _p.text(_text)
    logger.info("Print success... (probably)")
    _p.close()
    del _p

After running this device is no longer accesible via /dev/usb/lp0.
It was before running this code.


GitHub pages publish actions

Description
Created workflow actions to publish to github pages and added static export to config.
To-Dos

[x] Successful build yarn build
[ ] Successful Cypress tests

Changed my mind


[KFNBC]: All ISV/RH addon tiles are missing from the Dashboard

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
After installing the 1.15 livebuild (quay.io/modh/rhods-operator-live-catalog:1.15.0-qe-nbc), all ISV tiles and all additional RH addons tiles are missing from the dashboard.
The behaviour is present both after a fresh install and after enabling KFNBC
Expected Behavior
Dashboard shows all resources and tiles that are currently available in RHODS
Steps To Reproduce
Install a 1.15 live build
Visit dashboard
Workaround (if any)
No response
OpenShift Version
No response
Openshift Version
No response
What browsers are you seeing the problem on?
No response
Open Data Hub Version
No response
Relevant log output
No response

@LaVLaS @cfchase thoughts on what happened here? I'm not super familiar with the RHODS setup, so I do not know if there is additional things not packaged with. I imagine it has to do with a configuration from the KFDEF, no?
@lugi0 Do you recall the last version it worked with?

It is currently working with the 1.14 RC build @andrewballantyne

The ISV/RH addon tiles are specific to the downstream build and not included upstream build.  Since those tiles need to be built into the image, we will add an extra commit downstream to add those missing tiles for the downstream build.
There are hardcoded yaml files in the data folder that will eventually be moved to k8s resources that will be read at runtime in #243

Increasing priority since this is a blocker for RHODS 1.15 release

This issue will be fixed in ODH by https://github.com/opendatahub-io/odh-dashboard/pull/243

Misunderstanding on what would address this.

This is not an upstream odh-dashboard blocker because these files are not relevant for the upstream release.

This is my fault causing this ticket to yo-yo haha... The solution is indeed downstream as Landon mentions. https://issues.redhat.com/browse/RHODS-4800 is the downstream ticket. I misunderstood how we were tracking things and normally everything is in ODH first, but this is an exception to that rule. @lugi0 please follow the Jira ticket for the solution/progress watching of this issue.


[rc6] Need help resolving things properly

Just testing out RC5/6, and having issues resolving things properly (but I may well be doing something wrong): I'm getting a ton of  errors à la
cra.dll.js:746 Uncaught Invariant Violation: Objects are not valid as a React child (found: object with keys {__dataID__, year}). If you meant to render a collection of children, use an array instead or wrap the object using createFragment(object) from the React add-ons. Check the render method of `BodyRow`.`

when I'm trying take care both of property-based path resolvers and explicit resolve handlers via
    const resolver = resolve.resolve({
      columns: this.state.columns,
      method: (row, column) => resolve.byFunction('cell.resolve')(
        resolve.nested(row, column),
        column
      )
    });

The underscore properties are added alright, but for some reason it still seems to want to use the nested objects as the resolved values. Can you help me diagnose the problem?

... so, if I add a formatter like this:
      cell: {
        property: 'myNestedDataObject',
        resolve: value => myNestedDataObject.someArray.length ? 'Present' : 'Absent',
        format: (value, {rowData}) => {
          return rowData._myNestedDataObject;
        }
      }

... then everything works as expected. Shouldn't that happen automatically whenever resolve.byFunction is used?

Ah, I see now. I think we'll need to make Table.Body aware of the resolved values. So instead of passing regular value to format, we'll need to pass resolved one instead if it exists.
You can still access the original one through the data but I feel this is the right thing to do and it would fix your issue. I'll change this for the next release.
Thanks for the report!


chore: bump @apify/docs-search-modal version

Adds different icon for fragment-level records and expands the breadcrumbs.
See the left pane (results list) in the before / after comparison:

before
after

that would indeed be nice, I might look into it soon


Text in the HELM box is not wrapped

If I copy text from an email with extremely long lines of text into the HELM text box, it is displayed with the text going beyond the text box limits.

It should be wrapped to stay within the box.

Fixed

Confirmed fixed.


Middle click and drag down selects too much

VSCode Version: 1.26.0
OS Version: Win 10

Steps to Reproduce:

Create a text where the first line is shorter than another one
Middle click and drag down to the longest line
A part of the line is selected although the requested behavior is to select only each end of lines (as it is with Sublime Text)

Duplicate of #49454


Fix unhandled promise rejection when calling read on Windows.

Without this change, following error is signaled:
(node:12996) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: First argument must be an int

Current coverage is 90.00% (diff: 100%)

Merging #1072 into master will increase coverage by 0.26%

@@             master      #1072   diff @@
==========================================
  Files            15         14     -1
  Lines           633        590    -43
  Methods          98         86    -12
  Messages          0          0
  Branches        105        104     -1
==========================================
- Hits            568        531    -37
+ Misses           65         59     -6
  Partials          0          0

Powered by Codecov. Last update 4cf98ae...777da79

hi
used: v5.0.0-beta3 on win10, it also display this,
node: v7.8.0
test code copied  node-serialport/examples/readline.js

(node:15372) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: First argument must be an int
(node:15372) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.


Geospatial category

@louwers Thanks for the suggestion. Do you have an example library that would fit in this category?

https://turfjs.org/ comes to mind. https://www.npmjs.com/package/@turf/turf
https://www.npmjs.com/package/geolib seems another popular option
https://www.npmjs.com/package/@maplibre/maplibre-gl-native is a very neat package that allows you to render images of maps (I am a maintainer of the underlying C++ library).

@louwers I've added a Geospatial Analysis with the two libraries you've mentioned: https://nodejstoolbox.com/categories/geospatial-analysis. maplibre-gl-native seems to be frontend/app focused, instead of a backend/Node.js library. If you have any additions let me know.


The blob file which created from Azure view doesn't exist in "File Explorer"

OS: Windows 10
Build Version: 20200721.3
Repro Steps:

Expand one blob container and click "Open in File Explorer", it will open it in a new VS Code instance.
Create a file from "File Explorer" then refresh the blob container, the file shows in blob container.
Create empty blob or upload a file "one" to blob container from Azure view, then refresh the "File Explorer".
Check the result.

Expect:
The file "one" shows in "File Explorer".
Actual:
There is no file "one" shows in "File Explorer".

As Eric said here, its doubtful that the file explorer and azure view would be used at the same time


Repackage, change project structure layout, add carthage

This repackages and changes the layout as such:

Separate the library code and tests in a top level project.
Add example projects for iOS and macOS as child library projects.

This structure is more aligned with the library objective and also enables easy Carthage support.

Closed. Will revisit packaging later.

Current coverage is 81.78% (diff: 100%)

Merging #36 into master will not change coverage

@@             master        #36   diff @@
==========================================
  Files             8          8
  Lines          1202       1202
  Methods          75         75
  Messages          0          0
  Branches        100        100
==========================================
  Hits            983        983
  Misses          165        165
  Partials         54         54

Powered by Codecov. Last update 9ff90dc...6e18303


Add the ability to easily disable skills-client

Add new optional enabled parameter to the configure method:
 this.SkillsClient.SkillsConfiguration.configure({
           serviceUrl: 'http://localhost:8080',
           projectId: 'your-project-id',
           authenticator: '<auth>',
           enabled: false
        });

when disabled the skills-client library should remain dormant, and not attempt auth, network communication, skill reporting, etc.
Please Note: enabled will default to true

PR: https://github.com/NationalSecurityAgency/skills-client/pull/254


Character length hang fix for dotdraw

Fixed crash when the length of character was too long
Also added a way to import custom fonts

Suggestion, make the error text more friendly and match the style of the other "Oh snap!" messages,
// ...
    content: 'Oh snap! That message was a bit too long to process.',
// ...

Missing const:
https://github.com/Microsoft-community/Dotsimus/blob/e7f451ba1705f73ba13f37d603035bb638ed5e71/src/features/commands/dot-draw.js#L36


backport fix for cve-2023-39319 to 1.19.12-eks

Issue #, if available:
#1146
Description of changes:
Cherry-pick commit https://github.com/golang/go/commit/2070531d2f53df88e312edace6c8dfc9686ab2f5 to include fix for cve-2023-39319
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


Standardize Node RPC API to generate OpenAPI spec

https://docs.blockstack.org/references/stacks-rpc-api is all written inline; ideally we would be using standard OpenAPI spec tools

this is fixed now


Add test cases for uncovered branches

Test coverage now at 100%

Codecov Report

Merging #2 (6cf4a4f) into master (6911556) will increase coverage by 3.12%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           master        #2      +/-   ##
===========================================
+ Coverage   96.87%   100.00%   +3.12%
===========================================
  Files           1         1
  Lines         352       352
===========================================
+ Hits          341       352      +11
+ Misses          8         0       -8
+ Partials        3         0       -3

see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thank you.


fix dangling reference in the README

@bors r+

:pushpin: Commit 625b4ed3412b259c3e2aa0c171b65d745de6af8c has been approved by RalfJung

:hourglass: Testing commit 625b4ed3412b259c3e2aa0c171b65d745de6af8c with merge f8840e683ec465ff4349799a3e36ff498e88c9a5...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing f8840e683ec465ff4349799a3e36ff498e88c9a5 to master...


az_json_writer_append_json_text doesn't add comma when needed

If I'm writing a JSON array containing nested JSON then no commas are inserted between the array elements:
TEST_F(Azure, NestedJson) {
    char Buffer[1024];
    char Result[1024];
    az_json_writer Writer = { 0 };
    EXPECT_EQ(AZ_OK, az_json_writer_init(&Writer, AZ_SPAN_FROM_BUFFER(Buffer), NULL));
    EXPECT_EQ(AZ_OK, az_json_writer_append_begin_array(&Writer));
    EXPECT_EQ(AZ_OK, az_json_writer_append_json_text(&Writer, AZ_SPAN_FROM_STR("{\"a\": 1}")));
    EXPECT_EQ(AZ_OK, az_json_writer_append_json_text(&Writer, AZ_SPAN_FROM_STR("{\"b\": 2}")));
    EXPECT_EQ(AZ_OK, az_json_writer_append_end_array(&Writer));
    az_span_to_str(Result, sizeof(Result), az_json_writer_get_bytes_used_in_destination(&Writer));
    EXPECT_STREQ("[{\"a\": 1},{\"b\": 2}]", Result);
}

The result I'd expect is [{"a": 1},{"b": 2}] but instead I get [{"a": 1}{"b": 2}].
I'm using version 1.1.0-beta.3 of the SDK.

FYI: @ahsonkhan

Great catch, @kevinior, fixed in https://github.com/Azure/azure-sdk-for-c/pull/1600

@RickWinter I think its worth considering porting this fix as a hot-fix for the 1.0.0 release, and make a 1.0.1 patch version bump.  This API (and bug) was introduced prior to 1.0.0 GA (specifically in preview 5 - https://github.com/Azure/azure-sdk-for-c/releases/tag/1.0.0-preview.5)
https://github.com/Azure/azure-sdk/blob/0cd54f07c99a9534036f8a1a376bba7064f0b1b1/docs/policies/repobranching.md#hotfix-branches