🐛 [firebase_auth] authStateChanges doesn't emit initial data upon listening after a hot restart on web

Bug report
Describe the bug
After hot reloading on web, listening to authStateChanges does not emit any initial data.
Steps to reproduce
Steps to reproduce the behavior:

In a Firebase project with auth enabled, add a listener to authStateChanges
Run the app on web
See that the listener is triggered
Hot restart the app
See that the listener is not triggered

Expected behavior
My understanding is that authStateChanges should always emit the user's current auth state upon listening to the stream.
Additional context
This works as expected when I initially run my app on web and when I force-refresh the browser. However, when I hot restart, authStateChanges does not seem to emit that initial data. It only emits data when the user signs in/out again.
What I'm trying to figure out here is how I can show a loading indicator when the user's auth state is unknown. I figured I would show the loading indicator until the listener from authStateChanges fires, but then the loading indicator will show indefinitely when hot restarting during development. If I try to check currentUser, then I can see the user's data after hot restart, but it can be null initially which could either mean "the user's auth state is unknown" or "the user is logged out."

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel dev, 2.3.0-1.0.pre, on macOS 11.2.3 20D91 darwin-x64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.1)
[✓] VS Code (version 1.56.2)
[✓] Connected device (1 available)

• No issues found!

@doppio
Can you provide flutter pub deps -- --style=compact  to know which version of firebase_auth are you using ?
I tried with latest plugin version (1.2.0) on stable (2.0.6) branch using below code sample on web, with which I was able to see the authstatechanges being listened to properly, ie, initially, there's no one signed in, so it shows null:
When I signin with a test email and password, it shows the relevant user details and shows the uid of the user logged in:

After signing out and pressing r to hot -restart, it does shows the correct status as logged out:

 code sample

import 'package:firebase_core/firebase_core.dart';
import 'package:firebase_auth/firebase_auth.dart';
import 'package:flutter/foundation.dart' show kIsWeb;
import 'package:flutter/material.dart';
import 'package:flutter_signin_button/flutter_signin_button.dart';
import 'package:google_sign_in/google_sign_in.dart';

final FirebaseAuth _auth = FirebaseAuth.instance;

Future<void> main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp();
  runApp(AuthExampleApp());
}

/// The entry point of the application.
///
/// Returns a [MaterialApp].
class AuthExampleApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(title: 'Firebase Example App', theme: ThemeData.dark(), home: SignInPage());
  }
}

/// Entrypoint example for various sign-in flows with Firebase.
class SignInPage extends StatefulWidget {
  /// The page title.
  final String title = 'Anonymous number link test';

  @override
  State<StatefulWidget> createState() => _SignInPageState();
}

class _SignInPageState extends State<SignInPage> {
  String uid = "";

  @override
  void initState() {
    changeUidText(_auth.currentUser);
    _auth.userChanges().listen(changeUidText);
  //  print(_auth.currentUser.uid.toString());
    super.initState();
  }

  void changeUidText(User user) {
    setState(() {
      if (user == null) {
        uid = "Signed out";
        return;
      }
      uid = user.uid;
      if (user.email != null) {
        uid += " " + user.email;
      }
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
        actions: <Widget>[
          Builder(builder: (BuildContext context) {
            return FlatButton(
              child: const Text('Sign out'),
              textColor: Theme.of(context).buttonColor,
              onPressed: () async {
                final User user = _auth.currentUser;
                if (user == null) {
                  Scaffold.of(context).showSnackBar(const SnackBar(
                    content: Text('No one has signed in.'),
                  ));
                  return;
                }
                _signOut();
                final String uid = user.uid;
                Scaffold.of(context).showSnackBar(SnackBar(
                  content: Text(uid + ' has successfully signed out.'),
                ));
              },
            );
          })
        ],
      ),
      body: Builder(builder: (BuildContext context) {
        return ListView(
          padding: EdgeInsets.all(8),
          scrollDirection: Axis.vertical,
          children: <Widget>[
            Text(uid),
            RaisedButton(
              child: const Text("Print currentUser info"),
              onPressed: () => print(_auth.currentUser.toString()),
            ),
            _EmailPasswordForm(),
          ],
        );
      }),
    );
  }

  // Example code for sign out.
  void _signOut() async {
    await _auth.signOut();
  }
}

class _EmailPasswordForm extends StatefulWidget {
  @override
  State<StatefulWidget> createState() => _EmailPasswordFormState();
}

class _EmailPasswordFormState extends State<_EmailPasswordForm> {
  final GlobalKey<FormState> _formKey = GlobalKey<FormState>();
  final TextEditingController _emailController = TextEditingController();
  final TextEditingController _passwordController = TextEditingController();

  @override
  Widget build(BuildContext context) {
    return Form(
        key: _formKey,
        child: Card(
          child: Padding(
            padding: const EdgeInsets.all(16.0),
            child: Column(
              crossAxisAlignment: CrossAxisAlignment.start,
              children: <Widget>[
                Container(
                  child: const Text(
                    'Sign in with email and password',
                    style: TextStyle(fontWeight: FontWeight.bold),
                  ),
                  alignment: Alignment.center,
                ),
                TextFormField(
                  controller: _emailController,
                  decoration: const InputDecoration(labelText: 'Email'),
                  validator: (String value) {
                    if (value.isEmpty) return 'Please enter some text';
                    return null;
                  },
                ),
                TextFormField(
                  controller: _passwordController,
                  decoration: const InputDecoration(labelText: 'Password'),
                  validator: (String value) {
                    if (value.isEmpty) return 'Please enter some text';
                    return null;
                  },
                  obscureText: true,
                ),
                Container(
                  padding: const EdgeInsets.only(top: 16.0),
                  alignment: Alignment.center,
                  child: SignInButton(
                    Buttons.Email,
                    text: "Sign In",
                    onPressed: () async {
                      if (_formKey.currentState.validate()) {
                        _signInWithEmailAndPassword();
                      }
                    },
                  ),
                ),
              ],
            ),
          ),
        ));
  }

  @override
  void dispose() {
    _emailController.dispose();
    _passwordController.dispose();
    super.dispose();
  }

  // Example code of how to sign in with email and password.
  void _signInWithEmailAndPassword() async {
    try {
      final User user = (await _auth.signInWithEmailAndPassword(
        email: _emailController.text,
        password: _passwordController.text,
      ))
          .user;

      Scaffold.of(context).showSnackBar(SnackBar(
        content: Text("${user.email} signed in"),
      ));
    } catch (e) {
      Scaffold.of(context).showSnackBar(SnackBar(
        content: Text("Failed to sign in with Email & Password"),
      ));
    }
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.6, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.0.6 at /Users/dhs/documents/fluttersdk/flutter
    • Framework revision 1d9032c7e1 (6 days ago), 2021-04-29 17:37:58 -0700
    • Engine revision 05e680e202
    • Dart version 2.12.3

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Connected device (3 available)
	  • SM G975F (mobile) • RZ8M802WY0X • android-arm64 • Android 10 (API 29)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 14.4.1
    • macOS (desktop)           • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 89.0.4389.114

! Doctor found issues in 1 category.

If above doesn't represent your case, can you provide a code sample ?
Also check if this issue resemble yours, https://github.com/FirebaseExtended/flutterfire/issues/4348

This sounds like a bug that was fixed recently.
Make sure that you are using the latest versions available as @darshankawar said.

Running flutter packages upgrade seems to have fixed it. :) Thought I was on latest, but I guess I wasn't. Thank you for looking into it!

@doppio Which versions are you using? I'm still experiencing this exact issue using 8.6.1 gstatic packages in index.html, after running flutter clean, restarting VSCode and Chrome.
Using firebase_auth 1.2.0, firebase_auth_web 1.1.3, firebase_core 1.2.0, firebase_core_web 1.2.0 (looking in pubspec.lock)
I have no idea what else to do to get it to work...

@stx I'm on the same versions, except for firebase_core_web which is 1.1.0 in my pubspec.lock. Maybe the Flutter version could be related somehow? 🤷♂ I'm on the dev channel, 2.3.0-12.1.pre.


Add evidence prompt to email instructions in confirmation pages

@Demwunz you okay to merge this?

@teneightfive LGTM


fix: Make SpecClient() work with default values for optional args

[X] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Fix the bug where the SpecClient() result in error though the arg configuration is optional.
Why should this Pull Request be merged?
Enable users use SpecClient()  when run in SLE Jupyter executions or with SystemLink Client without passing an HttpConfiguration except for elevated privilege.
What testing has been done?
Run integration tests
Test using a simple spec query example on local machine with SystemLink Client connected to a SLE instance with valid specs.
from nisystemlink.clients.spec import SpecClient
from nisystemlink.clients.spec.models import QuerySpecificationsRequest

client = SpecClient()

product_id = "e1ed79db-2d05-466b-a6d8-9872ec5cee54"
query_request = QuerySpecificationsRequest(product_ids=[product_id])

specs = client.query_specs(query_request)

print(specs.specs)

@mure , Please review this simple bug fix PR.


Example of building an Angular app

Make a new fresh Angular 14 app using ng new and then wrap the architect-cli to build under Bazel.

Looking forward to this!

It would be great if such an example app included a test. I can't tell if rules_js supports any sort of browser-based testing. (Even getting jasmine tests that run in node working isn't straightforward.)

See https://github.com/aspect-build/bazel-examples/tree/main/angular for the architect-cli example. It maintains the ng cli structure and functionality so you can continue using the cli or use bazel. The BUILD files are fairly simple with any complexity hidden in the macros.

I'm running those tests on my linux machine, but they fail, similar to what @jbedard saw last week:
27 06 2022 18:17:41.979:INFO [launcher]: Trying to start Chrome again (2/2).
27 06 2022 18:17:42.011:ERROR [launcher]: Cannot start Chrome
	cmd_run.go:1044: WARNING: cannot create user data directory: cannot update the 'current' symlink of "/home/alexeagle/snap/chromium/current": remove /home/alexeagle/snap/chromium/current: read-only file system
internal error, please report: running "chromium" failed: cannot create transient scope: DBus error "org.freedesktop.DBus.Error.InvalidArgs": [Process 77 is a kernel thread, refusing.]

27 06 2022 18:17:42.012:ERROR [launcher]: Chrome stdout:
27 06 2022 18:17:42.012:ERROR [launcher]: Chrome stderr: cmd_run.go:1044: WARNING: cannot create user data directory: cannot update the 'current' symlink of "/home/alexeagle/snap/chromium/current": remove /home/alexeagle/snap/chromium/current: read-only file system
internal error, please report: running "chromium" failed: cannot create transient scope: DBus error "org.freedesktop.DBus.Error.InvalidArgs": [Process 77 is a kernel thread, refusing.]

27 06 2022 18:17:42.012:ERROR [launcher]: Chrome failed 2 times (cannot start). Giving up.
-- Test timed out at 2022-06-27 18:22:33 UTC --
✔ Browser application bundle generation complete.
✔ Browser application bundle generation complete.
SUCCESS
Result: {
    "success": true,
    "target": {
        "project": "lib-a",
        "target": "test"
    }
}

Logs:
================================================================================
INFO: Elapsed time: 301.700s, Critical Path: 301.00s
INFO: 4 processes: 6 linux-sandbox.
//projects/common:test                                                  TIMEOUT in 300.1s
  /shared/cache/bazel/user_base/d2d284156f9a05720bb6279c9999ed4c/execroot/__main__/bazel-out/k8-fastbuild/testlogs/projects/common/test/test.log
//projects/lib-a:test                                                   TIMEOUT in 300.1s
  /shared/cache/bazel/user_base/d2d284156f9a05720bb6279c9999ed4c/execroot/__main__/bazel-out/k8-fastbuild/testlogs/projects/lib-a/test/test.log
//:test                                                                  FAILED in 0.9s
  /shared/cache/bazel/user_base/d2d284156f9a05720bb6279c9999ed4c/execroot/__main__/bazel-out/k8-fastbuild/testlogs/test/test.log

Executed 3 out of 3 tests: 3 fail locally.

Should get these green before we close this issue.

Base on the logic here https://github.com/bazelbuild/rules_nodejs/blob/c962f12e06d99230f17d82a732958f3c00c9438e/examples/angular/tools/karma.conf.js#L285, we need to use --no-sandbox flags for Chrome, I have tested with architecture bazel rule, and it worked.


fix: icon contributes

Types

[x] 🐛 Bug Fixes

Background or solution
Changelog

Codecov Report

Merging #728 (e11144f) into main (f429772) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   58.63%   58.61%   -0.02%
==========================================
  Files        1209     1209
  Lines       74845    74841       -4
  Branches    15535    15533       -2
==========================================
- Hits        43882    43866      -16
- Misses      28226    28236      +10
- Partials     2737     2739       +2

Impacted Files
Coverage Δ

packages/extension/src/common/index.ts
77.46% <75.00%> (+1.46%)
:arrow_up:

...es/src/browser/userstorage/user-storage.service.ts
57.30% <0.00%> (-14.61%)
:arrow_down:

packages/file-service/src/browser/watcher.ts
95.65% <0.00%> (-4.35%)
:arrow_down:

packages/keymaps/src/browser/keymaps.service.ts
62.96% <0.00%> (-0.86%)
:arrow_down:

packages/theme/src/browser/icon.service.ts
83.95% <0.00%> (+0.53%)
:arrow_up:

packages/core-common/src/node/port.ts
46.96% <0.00%> (+3.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f429772...e11144f. Read the comment docs.


Automatically assigned workitem numbers should exist in the context of a space

At present, all users+spaces share a common incrementing set of numbers/IDs assigned to workitems when the workitems are created. It will be less confusing to the user if the numbers exist in the context of a space.
When a user creates a new space, and creates a workitem in that space. the workitem number/ID should be "1" andnot a number greater than 1:

From the discussion with Todd this morning - this should be by "entity" - not by space.

@catrobson can you please explain a bit more on by entity ?

Entity can be a username or a space right now.  Entity is the top level item used in the URL paths - which you can see here:  https://docs.google.com/spreadsheets/d/1cNSDuek0v1EBPpdPlFwG_Y_yOlux86m9MYf9UrF82l4/edit

See:  https://openshift.io/openshiftio/openshiftio/plan/detail/1036


Do not use resourcePrefix alone when assigning names to resources with uniqueness requirements

Description
We're generating a resourcePrefix value by default like so:
https://github.com/Azure/missionlz/blob/52882f61b11f802d00a72b350e034dfbaceef058/src/bicep/mlz.bicep#L465
And using that to assign names for certain resources that require uniqueness (things like Log Analytics Workspaces and Storage Accounts) like so:
https://github.com/Azure/missionlz/blob/52882f61b11f802d00a72b350e034dfbaceef058/src/bicep/mlz.bicep#L643
This can introduce failed deployments and unwanted behavior when a user specifies their own resourcePrefix value.
We should instead generate some uniqueness and use it for the resource names that require it.
Steps to Reproduce
Steps to reproduce the behavior:

Provide a user-supplied value for resourcePrefix like foo
Certain items will occasionally fail on redeploy for resources that take longer to clean-up like certain security solutions for Log Analytics Workspaces

Expected behavior
I can provide my own resourcePrefix value to a deployment and re-deploy as often as I want without error.
Actual behavior
Certain items will occasionally fail on redeploy for resources that take longer to clean-up like certain security solutions for Log Analytics Workspaces
Cloud (public, Azure Government, etc.): public

This should merge with #439 as naming conventions will most likely solve for issues. Also think the issue that originally raised this has a different root cause that this will hide since despite documentation the LA Workspace doesn't require global uniqueness but following a naming convention like -<prefix name/workload>- would solve for. The primary concern is LA naming shouldn't be randomized since then its usage via portal, queries or coding becomes difficult.

Also please take #393 into consideration when addressing this bug.

The team recommends a spike on proving the implementation: a resource group that has a storage account that has a unique name based on a user-provided value, but is consistently generated so that idempotency is preserved.

Just wanted to place this here for reference of future need in unique names. Log Analytics workspace does not require it to be globally unique as per this GA announcement in commercial and gov: https://azure.microsoft.com/en-us/updates/general-availability-log-analytics-workspace-name-uniqueness-is-now-per-resource-group/
This may need further investigation as it may not be GA in all clouds.

This issue was resolved with #556


[Drilldown] Accessibility/Keyboard controls issues

Keyboard control in the drilldown menu component seems to have some issues. This is using the drilldown component in a new project with the basic example markup provided in the documentation.  Focus doesn't move off of the first item. This appears to be because once you are focused inside the component, the keyboard actions are being handled by the component, and they seem to be applying focus to the <li> instead of the <a>.
Adjusting this in each of the key handlers seems to fix the focus issue. For example, adjust the down method to
down: function() {           $nextElement.children('a').focus(); },
and adjusting the others accordingly seems to take care of the focus issue. However, there still seems to be some issues with navigating through menu items that have children and the js added back button, along with moving the focus back up a layer.
I'll be looking into this a bit more when I have some time, I like the component, but need a completely accessible menu for the project I'm currently working, so hopefully I can get this sorted.

It sounds like that is the issue. Were you able to tinker with it more? Any suggestions?

Fixed in https://github.com/zurb/foundation-sites/commit/ab0f267608e95a9a9ee9d1bbc85746577b756493


Common header-fail fuzzing

We've hit issues where filters assume host (where there isn't always one on the early response path) and have concerns about impending pathless support with Connect.  It'd be awesome if our fuzz corpus included both checks of those two common gotchas as well as a presubmit that 1) new filters have fuzzers and 2) the initial corpus includes NoHost and NoPath checks

I think we can close this off given the new accessors solve the problem in a different way


Add docs for HTTP(S) proxy server configuration

Fixes #1038.
This also adds a note to the "Composite" section to clarify that a composite which includes a Vault server will always require a Vault token in the request (otherwise the entire request fails, as mentioned already in the docs).

Codecov Report

Merging #1063 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1063      +/-   ##
============================================
- Coverage     77.99%   77.68%   -0.31%
+ Complexity      930      923       -7
============================================
  Files           109      109
  Lines          3322     3312      -10
  Branches        466      462       -4
============================================
- Hits           2591     2573      -18
- Misses          554      563       +9
+ Partials        177      176       -1

Impacted Files
Coverage Δ
Complexity Δ

...or/BitbucketPropertyPathNotificationExtractor.java
75% <0%> (-25%)
5% <0%> (-6%)

...fig/client/ConfigServicePropertySourceLocator.java
63.97% <0%> (-3.68%)
22% <0%> (ø)

...environment/MultipleJGitEnvironmentProperties.java
84.61% <0%> (-3.62%)
3% <0%> (ø)

...rk/cloud/config/client/ConfigClientProperties.java
89.18% <0%> (-0.91%)
38% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97bd640...03a6636. Read the comment docs.


set GOPROXY=direct in Dockerfile

Some VPNs or networks block proxies or caches for golang package artifactories. Setting GOPROXy to direct so that the build works in all environments.

I don't think we want to enforce this for everyone as GOPROXY=direct can be significantly slower than using a module proxy.  It should be configurable via a setting in the Makefile.


how do you use the  lstsq to get the alpha value？

I am confused by the alpha value too。I try to use batch norm to replace the alpha，but it did't work。

It's a linear regression problem, and minimization function is least square error. So OLS would be fine, but I use the scipy.linalg.lstsq lib instead.
In fact, it's NOT an efficient way to approximate the linear combination, because the linear regression problem has few parameters(1~5 unknown alpha) but large amount of quantized samples(256965*5 first bin layer).
So I think author maybe avoid this problem through some other method.
As for using batch norm to replace the alpha, I don't think that batch norm can combine the effect of each base to approximate F.P. weights.

@andeyeluguo  @cow8  Hello, I use the batch norm as beta to approximate activations , now its training;  do you have any good idea for activations.

@cow8 Thank you for your reply， I will have a try！


feat: Added gcloud.yml to lock gcloud version.

Added gcloud.yml to lock the google cloud sdk version.
Closes : https://github.com/jenkins-x/jx/issues/6369

/ok-to-test

/lgtm

/retest


Error using "MMMM" with skeleton in date formatting.

This code generates an error using version 1.2.3 of Globalize:
Globalize.dateFormatter({ skeleton: "MMMM" })(new Date())

The error is "E_UNSUPPORTED: Unsupported {"feature":"year pattern u"}." which occurs because in the dateExpandPattern this line turns the pattern into "undefined at undefined":
				result = combineDateTime( type,
					cldr.main([
						"dates/calendars/gregorian/dateTimeFormats/availableFormats",
						dateSkeleton
					]),
					cldr.main([
						"dates/calendars/gregorian/dateTimeFormats/availableFormats",
						timeSkeleton
					])
				);

This happens in Chrome (v59), Firefox (v53), and Node (v4.4.5).

Thanks for filing this issue. This is fixed in master (and in 1.3.0-alpha.3), coming in 1.3.0 soon.


Prometheus Alertmanager integration

This would be a good idea

Looks like their client for pagerduty is hard-coded into their golang codebase.
We should probably write a golang client for iris, maybe keep it in the same repo as the python one (separate subfolder that's still go get-able.

Note that as per their documentation, they won't be accepting new receivers. Instead, they're betting on everything supporting a generic webhook.

Closing this as wleese added this.


Uncaught TypeError: Cannot read property 'Addon' of undefined

Hey, I'm getting these errors in my console when I add the datepicker component to an app.
Warning: React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components). Check the render method of `DatePicker`.
Uncaught TypeError: Cannot read property 'Addon' of undefined

Not sure what to do. any ideas?
Thanks

Please provide version numbers of relevant libraries and the code throwing the error.


Callback method is not fired with time picker.

I have my time picker  in  an ionic modal with date picker as well,, the time picker sets the model value correctly,, but not calling the call back method,. on the other hand datepicker is working just fine..
here is my code:
  <ionic-timepicker etime="filterStartTimeDisplay.epochTime"        format="filterStartTimeDisplay.format" step="filterStartTimeDisplay.step"   callback="timePickerCallback">
         <p > <standard-time-meridian  etime='filterStartTimeDisplay.epochTime'></standard-time-  meridian></p>
          </ionic-timepicker>

 $scope.timePickerCallback = function (val) {
           if (typeof (val) === 'undefined') {
            console.log('Time not selected');
           } else {
             console.log('Selected time is : ', val);    // `val` will contain the selected time in epoch
           }
        };

as you can see the object filterStartTimeDisplay is set correctly,, but the time picker callback function is not working... the log is not generated.

Are you using the callback in the same controller in which you are using the timepicker?

Yes of course .

If so, the callback should be called for sure. Are you still facing this issue or resolved?

If you have write the callback function, in the respected controller, then for sure, it should work.


chore: bump alloy

ref #6211

calldata doc test failing now, looks related @DaniPopes ?

New is correct. It was missed in alloy migration (uint vs uint256 hash) https://github.com/foundry-rs/foundry/commit/251ef74e04c6ad11eb02787c4b6190858d4ec1d7


name property from FirebaseToken is null

I don't know if I missed something but in my case it.name is null from
fun Application.configureFirebaseAuth() {
    install(Authentication) {
        firebase {
            validate {
                // TODO look up user profile from DB
                User(it.uid, it.name)
            }
        }
    }
}

I followed the tutorial and came across that. I am using email/password signup this might be the case of the error.

Is it just the name property that is null? Or is it the whole firebase user object that is null? If uid isn't null it could just be that the user you are authenticating with doesn't have a name so you could fix it with .orEmpty()

name is null. Yes, it seems the user doesn't have a name (name is not in the list of properties of the FirebaseToken I receive). However, I wonder if it worked for you using email/password auth.

@grrigore it does work for me with email password, but I was using my personal account logging into a personal project on firebase which I know has a name. I'll have to update the project to account for this and use the orEmpty() function or make the user name property itself null.

I've used Sign up with email/password to create an account and there was no name set. I'll try to use that update profile endpoint. Thank you for your time and great tutorial! :)


Whitelabel Error Page - GreetingController annotation might be wrong

When the GreetingController has the annotation @Controller annotation the URL to localhost:8080/greeting does not work. Changing the annotation to @RestController (as suggested in https://stackoverflow.com/questions/40797628/spring-boot-thymeleaf-viewresolver-on-rest-controllers) fixes the error.
In the browser the error is shown as:
Whitelabel Error Page
This application has no explicit mapping for /error, so you are seeing this as a fallback.

Sun Dec 30 00:07:06 CET 2018
There was an unexpected error (type=Internal Server Error, status=500).

In the terminal the error:
2018-12-30 00:07:06.767 ERROR 4852 --- [nio-8080-exec-1] o.a.c.c.C.[.[.[/].[dispatcherServlet]    : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is org.thymeleaf.exceptions.TemplateInputException: Error resolving template "greeting", template might not exist or might not be accessible by any of the configured Template Resolvers] with root cause

org.thymeleaf.exceptions.TemplateInputException: Error resolving template "greeting", template might not exist or might not be accessible by any of the configured Template Resolvers

I used the complete sample, added the maven pom and then run Application. But if it occurs only for me I'll close this issue.

When you say “added the maven pom” what does that mean exactly? There is already a pom.xml in the complete sample. If you use it, I expect it will work.

I got it to work and figured out what went wrong!
I used the IntelliJ functionality VCS -> Checkout from version control -> Git to add an existing project. This does not add the pom.xml. Also the folder structure is different from the complete sample. It sets the main folder as the project root. Thymeleaf tries to search for the template under src/main/resources/templates when the template is under main/resources/templates. This caused the org.thymeleaf.exceptions.TemplateInputException


issue #4259 fix

Please do not update the README or Change Log, we will do this when we merge your PR.
This PR (delete as applicable)

Adds a new feature

Describe the changes below:
Attempt to fix issue described here: https://github.com/photonstorm/phaser/issues/4259

Thanks for spending the time opening this PR. However, I'm going to close it without merging because I don't feel it fixes the relevant issue in depth. There are lots of places where colors are taken that need updating and it's quite a big and involved task, so it wouldn't be right to mark the issue as fixed when only implemented in a couple of places. There needs to be a more consistent way to define and extract color values.


Change events id and parent_id type from Integer to Bignum

#116887061

We ran units locally against mysql and postgresql to double check.


FederatedStore move usage of graphLibrary into GraphStorage.

GraphStorage should control the adding to library and managing errors.
  private void _add(final Graph newGraph, final FederatedAccess access) {
        graphStorage.put(newGraph, access);

        if (null != getGraphLibrary()) {
            getGraphLibrary().add(newGraph.getGraphId(), newGraph.getSchema(), newGraph.getStoreProperties());
        }
    }

overwrite exception occurs the graph has been placed in storage.

within: gh-1297


Code coverage

@dschmidtAs recommended by @joeg-pro I added the https://docs.google.com/document/d/1YTqpZRH54Bnn4WJ2nZmjaCoiRtqmrc2w6DdQxe_yLZ8/edit#heading=h.1ocirhrp51lj section which explain how to generate the coverage image. This contains now also links to code sample.

No-op scripts added.


[Bug]: Updating plugin to v4 causes 502 error on some routes

Summary
I'm currently running Next 11.1.2, and tried updating this plugin from v3.9.2 to v4.0.0. Some routes, I believe the ones with getServerSideProps(), now throw a 502 error.
Is v4 of this plugin supposed to work with Next 11, or should I update to Next 12? (I tried updating to Next 12 and the same routes fail, though with a standard 500 "Internal Server Error" page instead)
What set of versions should I use to try to reproduce this in another repo? Waiting for builds is pretty time-consuming so I'd love some suggestions for narrowing down the issue if you have any ideas.
For now I've downgraded back to v3.9.2 so I can continue to push new builds.

Here's the error I get with Next 11:

(👇  the error as json)
{
   "errorType":"Runtime.ImportModuleError",
   "errorMessage":"Error: Cannot find module '/var/task/packages/studio721/.next/server/middleware-manifest.json'\nRequire stack:\n- /var/task/node_modules/next/dist/server/next-server.js\n- /var/task/.netlify/functions-internal/___netlify-handler/handlerUtils.js\n- /var/task/.netlify/functions-internal/___netlify-handler/___netlify-handler.js\n- /var/task/___netlify-handler.js\n- /var/runtime/UserFunction.js\n- /var/runtime/index.js",
   "trace":[
      "Runtime.ImportModuleError: Error: Cannot find module '/var/task/packages/studio721/.next/server/middleware-manifest.json'",
      "Require stack:",
      "- /var/task/node_modules/next/dist/server/next-server.js",
      "- /var/task/.netlify/functions-internal/___netlify-handler/handlerUtils.js",
      "- /var/task/.netlify/functions-internal/___netlify-handler/___netlify-handler.js",
      "- /var/task/___netlify-handler.js",
      "- /var/runtime/UserFunction.js",
      "- /var/runtime/index.js",
      "    at _loadUserApp (/var/runtime/UserFunction.js:202:13)",
      "    at Object.module.exports.load (/var/runtime/UserFunction.js:242:17)",
      "    at Object.<anonymous> (/var/runtime/index.js:43:30)",
      "    at Module._compile (internal/modules/cjs/loader.js:1085:14)",
      "    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)",
      "    at Module.load (internal/modules/cjs/loader.js:950:32)",
      "    at Function.Module._load (internal/modules/cjs/loader.js:790:12)",
      "    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)",
      "    at internal/main/run_main_module.js:17:47"
   ]
}

And with Next 12:

Steps to reproduce

(I believe) Have a Next 11 project with pages using getServerSideProps()
Upgrade from plugin v3.9.2 to v4.0.0
Navigate to one of those routes

A link to a reproduction repository
No response
Plugin version
4.0.0
More information about your build

[ ] I am building using the CLI
[ ] I am building using file-based configuration (netlify.toml)

What OS are you using?
No response
Your netlify.toml file

`netlify.toml`
# Paste content of your `netlify.toml` file here

Your public/_redirects file

`_redirects`
# Paste content of your `_redirects` file here

Your next.config.js file

`next.config.js`
# Paste content of your `next.config.js` file here. Check there is no private info in there.

Builds logs (or link to your logs)

Build logs
# Paste logs here

Function logs

Function logs
# Paste logs here

.next JSON files

generated .next JSON files
# Paste file contents here. Please check there isn't any private info in them
# You can either build locally, or download the deploy from Netlify by clicking the arrow next to the deploy time.

Hey. This looks like it's using Next 12 for the server, but it was built with Next 11. The code that tries to import that file was introduced in Next 12, but so was the code that generates it. Could you run either npm ls next or yarn why next depending on your package manager and see if you have multiple versions (and why)?

Good catch!
I think I had installed Next in the root of my monorepo to fix a failing build issue, and I must've installed the wrong version.
I think this was the error that I fixed by installing next in the root... but installing just critters at the root instead seems to work. I don't know what critters is but I guess it's used somewhere in the build pipeline 🤔

Anyway, the plugin v4 works with both Next 11 and 12 for me now, so I'll close this.

Great! Is that log from version 3? If not, you should also remove all of the next_* functions created by version 3 of the plugin.

It needs at least 10.0.9

@ascorbic Can you help me with this error
   at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15 undefined)","
   at Function.Module._load (internal/modules/cjs/loader.js:746:27 undefined)","
   at Module.require (internal/modules/cjs/loader.js:974:19 undefined)","
   at require .require (internal/modules/cjs/helpers.js:93:18 undefined)","
   at NextNodeServer.getMiddlewareManifest (/var/task/node_modules/next/dist/server/next-server.js:521:20 undefined)","
   at new Server .new Server (/var/task/node_modules/next/dist/server/base-server.js:126:40 undefined)","
   at new NextNodeServer .new NextNodeServer (/var/task/node_modules/next/dist/server/next-server.js:73:9 undefined)","
   at getBridge .getBridge (/var/task/.netlify/functions-internal/___netlify-odb-handler/___netlify-odb-handler.js:46:28 undefined)","
   at handler .handler (/var/task/.netlify/functions-internal/___netlify-odb-handler/___netlify-odb-handler.js:75:46 undefined)","
   at Runtime.handler (/var/task/node_modules/@netlify/functions/dist/lib/builder.js:41:25 undefined)"]}

Experienced the same issue with next: "11.0.0" but changing the version to next: "^11.0.0" seems to have fixed the issue for me.


Using rad-dropdown with a rad-state has issues getting closed using the rad-state's close method

<section class="new-drawer-section">
  {{#rad-state as |state stateActions|}}
    {{#rad-drawer externalToggle=state Target='Click me' as |components hidden|}}
      {{#components.content}}
        {{#rad-button click=stateActions.close}}Button{{/rad-button}}
        {{#rad-button click=(action stateActions.close)}}Button 2{{/rad-button}}
      {{/components.content}}
    {{/rad-drawer}}
  {{/rad-state}}
</section>`

One of the buttons inside the content should close the dropdown, but it doesn't.

Upon review, this isn't so much a bug as it is just an issue with how booleans and the stateActions actions manipulate the value of state. Always using stateActions.toggleState will overcome this problem, OR inverting the value of state when passed into rad-drawer will also work (e.g. externalToggle=(not state).
There are some changes we can make to rad-drawer and rad-state to make this a little easier to grok, though.
For starters, we should deprecate the externalToggle prop of rad-drawer and have people pass hidden instead, since externalToggle is just a proxy for the internal hidden prop.
Secondly, the actions on rad-state need to be renamed for clarity; right now they are named open and close, which is presumptive. Those action names should be deprecated and updated with more explicit names like setTrue and setFalse so it is more obvious how the value of state is being manipulated.


A small error inside the documentation

Note: For questions about how to use an endpoint, or problems related to Twitter API than the lib itself, please use the GitHub Discussions instead of opening a new issue.
The code block that states

The .loginWithOAuth2() method already returns a logged client, but if you want to create an instance by yourself with an access token (for example to make a request from a saved access token), use it as a Bearer token.

has a small mistake. It should specify that the method accepts a bearerToken instead of an accessToken as given inside the line of code that follows.
const client = new TwitterApi('<YOUR-ACCESS-TOKEN>');

should ideally be:
const client = new TwitterApi('<YOUR-BEARER-TOKEN>');

Hi,
Even if it is in fact a Bearer token, this is named access token to avoid confusion with App-only OAuth2 Bearer token, that is widely mentionned as it in the Twitter documentation.


Use PublishCodeCoverageResults@2 in dotnetcore pipeline guide

@juliakm
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Reset button does not work in the Static Front Page section

Issue description:
Pressing the "Reset" button does not actually reset the fields in the Static Front Page section.
Version used:
(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)
Yes, I tried this with the dev branch.
Using theme_mods or options?
options
Code to reproduce the issue (config + field(s))
Do not apply (this is a WordPress default panel)

Nice catch, fixed. 👍

Thanks, @aristath. I just realized that the Reset button isn't' working also with widgets.
Tested with three themes: Twenty Seventeen, Twenty Fifteen and Riba Lite (just a random theme I use to test this).

Did you try pulling the latest commits?
Reset is now only added to Kirki sections

Oh, I see. Yes, I tried the last commit and the Reset button was indeed removed in default sections. 👍

@aristath, https://github.com/aristath/kirki/commit/1f59e2e2bcf11f7e4f9619750c70b4ca065d648f does not work with fields created using the default customizer API methods.
The class control-section-kirki-default, used in the conditional check, is added to the code only when Kirki methods are being used to add fields.

Yes, that was the intention.
TBH if I could I would completely remove the reset feature... It's problematic and there's already a ticket in WP-Core to add reset there, so I can't wait for that to happen :P
But if a plugin provides a reset feature, it makes sense that it would be intended for the sections created by that plugin.
Any section created using Kirki::add_section() will have the reset on top.

Ok, got it. I'll use the Kirki methods then. Thanks @aristath.


rolling out a pipeline type system for dispatching on analysis details

This PR implements dispatching on the type of pipeline <: AbstractEpiAwarePipeline to implement pipeline workflow.
I have kept default constructors and in each case the pipeline-dependent constructor function just returns these. However, there is now a obvious place to extend the pipeline type tree to specify additional behaviour by writing methods for any of the component parts, e.g. make_inference_method(pipeline) etc.
Additionally, the AnalysisPipeline and its unit tests have been refactored into a logical file organisation (obviously opinions make vary) and other minor fixes (e.g. rmprocs has been added to pipeline script).
NB: With reference to #221 and also following f2f meetings this PR is keeping the computation DAG as generated by Dagger.@spawn macros on function calls. This limits the pipeline to any backend which can interface with Julia Base.Distributed, and may be changed in near future.
Closes #218 .

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.73%. Comparing base (576e0ee) to head (1115140).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   92.73%   92.73%
=======================================
  Files          42       42
  Lines         399      399
=======================================
  Hits          370      370
  Misses         29       29

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

The overall organisation and high level stuff is good. I don't understand the choice to keep the default functions as it appears to lead to duplication and reduced modularity with no clear upside but maybe I am missing something

Mainly, I quite like having default_... functions, but upon reflection very "dev script"-y and I'm being lazy since I can get the effect with make_...(RtwithoutRenewalPipeline()). I'll do a quick change on this.

I've resolved the comments around using default_... as I think addressed.
If you could review:

Abstracting the map over inference problems to function
set of make_... functions.
Solution to wanting both the name of latent models as a condensed string and the model itself, i.e. passing as a vector of name => model Pair objects.

That would be great.


[Cosmos] Respect preferredLocations

There is a bug in the retry code where we end up calling the routing code with a parameter that ignores preferred locations passed to the client

Resolved in another PR


Bug: Tooltip Issue on Action Titles

Description
I've noticed that when I hover over the action title, the tooltip only appears when the action is not in progress.
Steps To Reproduce

Initiate an action
Navigate to the status center
Hover over the title

Requirements
Implement a solution that allows the tooltip for an action title to display in real-time, irrespective of whether the action is in progress or completed.
Files Version
<IP_ADDRESS>
Windows Version
10.0.22621.2506
Log File
...

Thanks for the report, I've added this to the project board.

This in by design

This in by design

Sounds like I had the same feedback recently. How can this be by design? If you need it, you need it

Not every action state has a tooltip at the moment


galaxy outdated

1.12.5 is not available. It seems that you have not enabled autoimport. Shall I enable it by creating a PR?

published as v2.1.15 to the galaxy


Document IAM requirements

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Document all OCI IAM requirements:

on a separate page
in the form of a table

Things to document:

Dynamic group
Policies
Notifications

This is probably base of all other OCI terraform modules, until dynamic group, policies and notifications are in place, all things fall apart. If you have this mentioned anywhere, i can make a document for same, else i will need to find out myself.


Migrate from Gecko SDK 4.4.4 to Simplicity SDK 2024.6.2

I think most of the issues have been ironed out in the 2024.6.2 release of the Simplicity SDK.
This PR upgrades OpenThread, Zigbee, and the Gecko Bootloader templates.

Some extra stuff for create_gbl.py (also the file for cpc_version changed):
https://github.com/NabuCasa/silabs-firmware-builder/blob/5055f0d719a22624995d9565bddfeac9daf0637c/tools/create_gbl.py#L165-L178
        metadata["ezsp_version"] = zigbee_esf_props["version"][0]

    if "ot_version" in gbl_dynamic:
        gbl_dynamic.remove("ot_version")
        ot_esf_props = parse_properties_file(
            (gsdk_path / "protocol/openthread/esf.properties").read_text()
        )
        metadata["ot_version"] = ot_esf_props["version"][0]

    if "ble_version" in gbl_dynamic:
        gbl_dynamic.remove("ble_version")
        sl_bt_version_h = parse_c_header_defines(
            (gsdk_path / "protocol/bluetooth/inc/sl_bt_version.h").read_text()
        )
        metadata["ble_version"] = ".".join(
            [
                str(sl_bt_version_h["SL_BT_VERSION_MAJOR"]),
                str(sl_bt_version_h["SL_BT_VERSION_MINOR"]),
                str(sl_bt_version_h["SL_BT_VERSION_PATCH"]),
            ]
        )

    if "cpc_version" in gbl_dynamic:
        gbl_dynamic.remove("cpc_version")
        sl_platform_version_h = parse_c_header_defines(
            (gsdk_path / "platform/common/inc/sl_platform_version.h").read_text()
        )
        metadata["cpc_version"] = ".".join(
            [
                str(sl_platform_version_h["SL_PLATFORM_MAJOR_VERSION"]),
                str(sl_platform_version_h["SL_PLATFORM_MINOR_VERSION"]),
                str(sl_platform_version_h["SL_PLATFORM_PATCH_VERSION"]),
            ]
        )

Regarding the OpenThread version: the commit ID sometimes changes (and sometimes does not) even while the version stays static. I think this is also the version string returned by the Spinel protocol, in line with the others.


ovs-vsctl add port failed

I'm using docker to create a network topology by containers.
and I created a few container by "docker-ovs"
also, followed the official tutorial "Building a point-to-point connection"
https://docs.docker.com/articles/networking/#building-a-point-to-point-connection
connected my containers,
however, after I type ovs-vsctl add-port br0 A
there will be a error, says
root@jace# docker exec node1 ovs-vsctl add-port br0 A
ovs-vsctl: Error detected while setting up 'A'.  See ovs-vswitchd log for details.
do you have any clue or any information about this problem?

If you are planning on running OVS in userspace mode, you will need to set the Bridge's datapath_type=netdev. If not, please ensure the OVS Kernel Module is loaded in you host e.g modprobe openvswitch

I've checked my kernel module by lsmod | grep openvswitch
and it was loaded in for sure, also I add datapath_type=netdev when creating bridge
that's why I feel kinda strange.

ok, you don't need to use datapath_type=netdev when the kernel module is loaded.
if you can create a new bridge and try adding a port, that would be great....
you can also use docker logs <container_id> to get some output for OVS as to why this might have failed

Thanks for your help, it seem like I loaded openvswitch.ko and use datapath_type=netdev at the same time.

hey can you please let me kn ow how you resolve this issue

Hi mehwishZaidi,  the conversation above contains the solution to this problem.
Are you still unable to solve your problem?


pkg/build: extract unstripped module object files for Pixel

Unstripped module object files are compressed and stored in the 'dist' directory after build. Add functionality to extract these object files and store them with the kernel object to be used when generating kernel coverage.

@kalder

What does the archive look like? Are there really also directories or just module files?

The archive directory contains an "unstripped" directory, which contains the module files.

Is it possible to get the same files from e.g. the out/ folder without having to extract the archive?

Yes. I avoided this initially because the unstripped object files are located in the directories of their original modules, making using filepath.Glob() difficult as the path searching needs to be recursive. However, that's a good point that avoiding extracting may be cleaner.
I've updated this to copy files from the out/ folder, avoiding the stripped module objects in staging. This does have the benefit of using osutil file copying.

@eprucka3 @kalder
Folks, we probably need to sync our efforts. There's a flag called android_split_build that should handle the unstripped modules without the need to copy them. Also, keep in mind that the modules can be built on a different machine, in which case copying is not possible.

@eprucka3 @kalder Folks, we probably need to sync our efforts. There's a flag called android_split_build that should handle the unstripped modules without the need to copy them. Also, keep in mind that the modules can be built on a different machine, in which case copying is not possible.

That's good to know about the android_split_build flag; that seems very useful. In this case however, the modules objects are cleaned during Android.Clean() and the copying prevents this. Another solution would be not cleaning the output, or cleaning the output aside from these files, but the copy function seemed a clean way to address this.
That being said, I agree that we need to sync our efforts, and we will definitely utilize the android_split_build flag on other builds


fix: Update dependencies

:tada: This PR is included in version 2.4.2 :tada:
The release is available on:

v2.4.2
GitHub release

Your semantic-release bot :package::rocket:


Show all tenant

添加租户时，要求租户名不能重复

Codecov Report
Base: 64.98% // Head: 64.95% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (3f10cf8) compared to base (0c4a4cf).
Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   64.98%   64.95%   -0.04%
==========================================
  Files          94       95       +1
  Lines        2499     2551      +52
  Branches      310      320      +10
==========================================
+ Hits         1624     1657      +33
- Misses        837      853      +16
- Partials       38       41       +3

Impacted Files
Coverage Δ

apps/mis-server/src/services/tenant.ts
84.21% <77.77%> (-5.79%)
:arrow_down:

apps/mis-server/src/services/admin.ts
44.00% <0.00%> (-7.36%)
:arrow_down:

apps/mis-server/src/bl/importUsers.ts
94.87% <0.00%> (-5.13%)
:arrow_down:

apps/mis-server/src/clusterops/slurm/user.ts
9.52% <0.00%> (-1.01%)
:arrow_down:

apps/mis-server/src/utils/slurm.ts
95.65% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Adopt prettier

Let's join the modern world, shall we?

I should mention that I'm not necessarily attached to Prettier here; I just want a consistent, common style which can be applied 100% automatically. Prettier fits the bill. A careful selection of eslint rules which have fixers would work just as well, but it's a lot more work to curate.

luckily the airbnb config already exists :-p but not yet for typescript, so, this is probably the easiest path

luckily the airbnb config already exists

Yeah but it enforces a lot of much more controversial non-formatting stuff, and cannot be applied 100% automatically. (Unless there's a version of it which is just formatting? I'd be fine with that.)

I think we might not be on the same page here :-)
Nobody should ever be running any formatter on a project except the project's own formatter. Running prettier on a project that doesn't explicitly use prettier is not appropriate.
Similarly, eslint is already a linter and formatter combined. It's fine if a project doesn't want to enable non-autofixable rules (altho you miss out on a ton of useful checks that way), but that's a separate choice from "which formatting tool do i want to use".
Using only eslint - which many people have their editors set up to automatically use local settings/versions for - means that we can easily add additional rules in the same single source of truth (the eslint config), without having to maintain two separate configs for linting/formatting.

Nobody should ever be running any formatter on a project except the project's own formatter. Running prettier on a project that doesn't explicitly use prettier is not appropriate.

Well, sure, but the point of this PR is to make this project use prettier as a formatter. At which point, running it on this project would be appropriate. And it wouldn't matter if you're running it via eslint or not, because it would have the same effect either way.

Similarly, eslint is already a linter and formatter combined.

It is true that it offers both of those benefits. Here it is serving as a formatter strictly via a plugin which causes it to defer to prettier.

It's fine if a project doesn't want to enable non-autofixable rules (altho you miss out on a ton of useful checks that way), but that's a separate choice from "which formatting tool do i want to use".

Agreed, and I think non-autofixable non-formatting rules are good. (I have in fact just added one.) It is specifically non-autofixable formatting rules which I'd prefer to avoid; I don't think the benefit of marginally more consistent style is worth the overhead of making contributors (including me) manually mess with formatting.
As I said, I'd be fine with replacing this PR with any other method of enforcing a consistent, common style which can be applied 100% automatically. That's the thing I actually want. Prettier does that. Other formatting tools, including eslint unless you do a great deal of work, do not. That's why I've made the choice to use Prettier as the formatting tool.

Using only eslint - which many people have their editors set up to automatically use local settings/versions for

This enforces prettier using eslint; I'm not sure what issue you see here. (Also, such people tend to also have their editors set up to automatically use prettier as well, in my experience, though it's not necessary if you configure eslint to use prettier as I've done here.)

means that we can easily add additional rules in the same single source of truth (the eslint config)

Style rules, once established, change very rarely, especially if you use prettier to do styling (since it has so few knobs). So while I agree this is a nice thing to have in principle I think it ought to be given very little weight. Having one place to configure formatting rules and a separate place to configure non-formatting rules seems acceptable to me, in exchange for the benefit of being able to automatically fix all formatting rules.

I think that I can deal with leaving the prettier config in their own places for now (to ensure prettier --write works properly), but i'd also rather project formatting be done via eslint --fix, and if there's a formatting rule that we don't like, disable it. Does that seem like a reasonable compromise?

I think that I can deal with leaving the prettier config in their own places for now (to ensure prettier --write works properly), but i'd also rather project formatting be done via eslint --fix

eslint --fix works fine as of this pr. I've just also added a format command for convenience which just does formatting. eslint --fix would have the effect of doing exactly the same formatting, and then also erroring if you non-formatting issues, so it seems like not the right choice for a command named format.
But I guess I could switch it out, or remove it entirely, if you feel particularly strongly about it; I just don't understand why.

if there's a formatting rule that we don't like, disable it

To be clear, this PR already disables all formatting rules except for "is in the format prettier would output", and adopting prettier generally means sticking with that philosophy going forward.


Missing/broken links in doc files.

I noticed that there are quite a few broken/missing links in the .md files.
Is this something that you want help with?
If so I would love too help, just a few questions.

Is doc/manual meant to be a folder or is the root of doc where those files will remain?
The links to each operator in operators.md, will they link to the operator in http://reactivex.io/RxJS/ or to separate markdown files as in Reactive-Extensions/RxJS/.
How should the PRs be made, 1 per file worked on or as many links fixed as possible?

FYI: the docs are now at http://reactivex.io/rxjs, and that changed just a couple of hours ago. Does that have anything to do with your issues?

Yes that seem too fix everything!


Replicating published results

I'd like to replicate the results you've shown in your recent publication on PanopTILs. (Table 1 to start with but ideally every table and figure.) How would you recommend doing this?
My guess would be to start by running MuTILsTrainer.py, adjusting variables like BASEPATH to match the directory from which I've downloaded and unzipped PanopTILs bootstrapped set to. However, I noticed that the Trainer main calls utils.GeneralUtils.save_configs, which has been commented out in the GeneralUtils file. Should I avoid using it?
Once I have a trained model, would I use MuTILsWSIRunner or MuTILsAnalyticalValidation to evaluate my trained model on the manually labeled test set across the five folds?
Thank you for your help.

We have some written and recorded documentation that I can share with you. Let me consult with the students and see if they consent to sharing the recording. Please email me at lee dot cooper at northwestern dot edu and I will find a way to get this to you.
You will not be able to replicate exactly what is shown in the tables since a portion of the training data cannot be shared. The majority of the data is accessible though.

We have some written and recorded documentation that I can share with you. Let me consult with the students and see if they consent to sharing the recording. Please email me at lee dot cooper at northwestern dot edu and I will find a way to get this to you.
You will not be able to replicate exactly what is shown in the tables since a portion of the training data cannot be shared. The majority of the data is accessible though.

Can you also share the model wrights with us? Not only for MuTILs but it seems essential if we wanted to use HIPs to directly quantify slides.
Thanks

I have hosted the original weights for download and have gathered documentation on running the model and the pipeline outputs. I'm waiting on the author to have a break so that we can update the repo and project website.

Super! Many thanks!

I have hosted the original weights for download and have gathered documentation on running the model and the pipeline outputs. I'm waiting on the author to have a break so that we can update the repo and project website.
Can you share the link？  @cooperlab

I have hosted the original weights for download and have gathered documentation on running the model and the pipeline outputs. I'm waiting on the author to have a break so that we can update the repo and project website.

Hi, many thanks for sharing this great work. Could you pls share this link?


Add members of Cardano Wallet team to the "About Daedalus" screen.

Hi there!
The "About Daedalus" screen includes some members of the Cardano Wallet developer team, but some are missing. I've wonder if it's possible to add the remaining members? 🙏🏻 (I've added them in this PR.)
The following members are already listed within the "Cardano Team" section:

Johannes Lund (@anviking)
Pawel Jakubas (@paweljakubas)
Piotr Stachyra (@piotr-iohk)

This PR adds the remaining (current) members to the same section:

Heinrich Apfelmus (@HeinrichApfelmus)
Jonathan Knowles (@jonathanknowles)
Paolo Veronelli (@paolino)
Yura Lazarev (@Unisay)

Many thanks! 🎄
Jonathan

cc @danielmain @daniloprates

Hi @tomislavhoracek,
Just curious (just attempting to tie up a loose end). Is there anything that we need to add to get this merged?
Though no pressure if you're already snowed under.
All the best
Jonathan

Please approve and make our children, wives and girlfriends happy and proud... :pray:

Yuriy Lazaryev

@Unisay Apologies for using the wrong spelling here. -- I've now updated it! Could you verify that the new spelling is correct? 🙏🏻

cc @marcin-mazurek

Please add a CHANGELOG entry 🙏


[WIP] Rewrite dask order

This is a rewrite of the existing dask.order implementation
Closes https://github.com/dask/distributed/issues/8255
This is still WIP but for most unit tests it provides equivalent or strictly better ordering. There are still a couple of failures I have to address but the failures do not look critical and may even point to improper test logic.
From my perspective this rewrite is preserving most of the key logic of the current algorithm but it removes plenty of specialized edge cases. I will follow up with a more rigorous description of the changes once CI is green
TODO:

[ ] Perf testing of the actual order algorithm
[ ] Coiled benchmarks

Exciting
On Thu, Oct 12, 2023 at 7:10 AM Florian Jetter @.***>
wrote:

This is a rewrite of the existing dask.order implementation
Closes dask/distributed#8255
https://github.com/dask/distributed/issues/8255
This is still WIP but for most unit tests it provides equivalent or
strictly better ordering. There are still a couple of failures I have to
address but the failures do not look critical and may even point to
improper test logic.
From my perspective this rewrite is preserving most of the key logic of
the current algorithm but it removes plenty of specialized edge cases. I
will follow up with a more rigorous description of the changes once CI is
green
TODO:

Perf testing of the actual order algorithm
Coiled benchmarks

You can view, comment on, or merge this pull request online at:
https://github.com/dask/dask/pull/10557
Commit Summary

27bb6f5
https://github.com/dask/dask/pull/10557/commits/27bb6f5ef1949a1d8f6346ef2217035d297d9986
more fixes to dask.order
bbfa1d8
https://github.com/dask/dask/pull/10557/commits/bbfa1d8c3804d37cd8f9c4df92e2adc2dcfbea42
Rewrite dask.order

File Changes
(3 files https://github.com/dask/dask/pull/10557/files)

M dask/base.py
https://github.com/dask/dask/pull/10557/files#diff-10422b02c591d63ee295724faa14f7698b4a742c98ba20771c5f70d1a6926d06
(9)
M dask/order.py
https://github.com/dask/dask/pull/10557/files#diff-16341d447452e36a9d001fe3bcb08157cba6233ecbeb3b1f2d0af30b00c42677
(627)
M dask/tests/test_order.py
https://github.com/dask/dask/pull/10557/files#diff-5ff706869bdb554d4e160ef54f0241ce96be47c22dae92ab483b20ab88037d2a
(75)

Patch Links:

https://github.com/dask/dask/pull/10557.patch
https://github.com/dask/dask/pull/10557.diff

—
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/10557, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKZTH5AJ4FE57ZDBHSE53X67M4FAVCNFSM6AAAAAA55QMWJKVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTSOBVGA3DAMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

TLDR The preliminary benchmark results are interesting but not super exciting. The results of this, so far, are not necessarily convincing enough to move forward with this but I believe this proposed algorithm is easier to maintain so I'll look into it a little more.
There are a couple of perf issues with this implementation I'll need to review (there are a couple of very hot loops) and rerun this again. If I can stabilize performance, this may be still interesting.
(The one thing that may be interesting to look into more closely is test_sum_residual which shows an impressive relative improvement in memory usage. The test is relatively small scale so I'll have to review this a little more closely to assess if real world workloads would benefit from this.)
Wall Time
There seem to be a mild general positive trend in wall time
(Please ignore the TPCH improvments. I didn't notice that the benchmark configuration is configured to compare released dask-expr vs main so I'll have to rerun this).
There are some runtime regressions in things like test_trivial_workstealing which is in absolute values only a two or three seconds. I'm currently reviewing the code and there are some perf issues that I think cause this. Should be gone in the next run as well.

(Peak) Memory Usage
Again, the impact of this PR appears to be overall positive (again, please ignore the TPCH block that is deeply red here).
However, the huge relative gains here are relatively small in absolute values so this is not super exciting

Ok, just got the finished new benchmark results that include a couple of performance fixes of the algorihm and the results look much more robust (also with aligned dask-expr versions for the TCPH stuff)
Wall Time
There is still a thing with the work stealing but I'm not terribly concerned about that

(Peak) Memory

The signal around peak memory reduction for double diff and zarr filtering seems to be solid

Apart from complexity reduction and apparently some memory performance gains, I'm also interested in this implementation since the new implementation aligns pretty well with prior ideas to deal with co-assignment and STA (https://github.com/dask/distributed/pull/7141) that ultimately failed because of ordering issues. I may revisit this idea again but from a dask.order perspective and not as an extension as discussed there.

The performance of the initial implementation was not good enough to be usable. I applied some optimizations now and think it is fine. It is slower in most cases, faster in few. Either way, it's not orders of magnitude.
For this optimization I took the benchmarks in the dask-benchmarks repo

I'm currently waiting for updated large scale benchmarks.

The bad performance from the worst cases stems from the "change of tactical goal" which is still a bit of logic I preserved from earlier. Essentially, we do something expensive (e.g. sorting or diff-ing sets) just to briefly afterwards pause this effort and start again from scratch. This could likely be salvaged at the cost of readability but until we have more solid large scale benchmarks, I won't tune this further.

 Memory usage looks similar to the above and overall the same or better. However, the runtime performance of the algorithm itself seems to be not negligible, i.e. we cannot merge this.
I will pause work on this for a while


Working with workspaces containing multiple applications\services

Hi @madjam002
I understand that you are using this plugin with some large workspaces.
Would you mind sharing how you handle building sub-projects within a workspace? Do you just build them all in one massive derivation based on top level yarn.lock? Or do you maintain individual lock files for sub-projects which allow them to be built in isolation?
Thanks!

Cross referencing similar topic on a similar project: https://github.com/stephank/yarn-plugin-nixify/issues/63

Hi @adrian-gierakowski
Yes you can have a top level yarn.lock, this is what I do, although there's no "one massive derivation". The yarn plugin generates a yarn-manifest.nix file which is basically just a version of yarn.lock that the Nix part of this library can better understand. Each package is its own derivation, whether that's your own packages in the workspace or dependencies. Because of this, if you build a package in your workspace that only has a few dependencies, only those dependencies will be built rather than every dependency of the entire workspace.
That said, I can't see any problems if you use separate yarn.lock files, you'll just need to install the yarn plugin and generate the yarn-manifest.nix for each corresponding yarn.lock and pass it to mkYarnPackagesFromManifest like so:
https://github.com/madjam002/yarnpnp2nix/blob/d3e33b12216a7450b0952c4841b57a1953a6ccf7/test/flake.nix#L19
I hope that helps.

@madjam002 awesome, thanks!
If each package gets its own derivation depending only on the deps they actually use then I don’t need separate lock files.
I’ll give it a spin next week!
Btw. is there support for private npm registries? I’ve added it to my fork of yarn-plugin-nixify so if not I could open a PR if I end up using your project at work.


chore(main): release audit 1.36.2

:robot: I have created a release beep boop
1.36.2 (2023-04-25)
Bug Fixes

tips display crash in non-tty envs (afd121c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/sandworm-hq/sandworm-audit/releases/tag/audit-v1.36.2 :sunflower:


Add sigwait/sigwaitinfo/sigtimedwait.

I fixed it as much as I could. I noticed that a lot of functions had special linker attributes for netbsd. How do I determine the right linker targets for a function on netbsd (and apparently i686-apple-darwin)?

Ah most of those attributes came out as a result of CI, but if the CI is green then no need for any attributes! Looks like though sigwait on OSX has a special name as well as sigtimedwait on NetBSD, so I guess this isn't the case here unfortunately.
From what I can tell, however, the names seem to be:

OSX - sigwait$UNIX2003 (you can follow other examples here as well)
NetBSD - __sigtimedwait50 (there's also probably a few other examples here as well)

Thanks!


fp8 - call hip api once to unblock stuck at tensilelite validation

mi300
[----------] Global test environment tear-down
[==========] 48206 tests from 13 test suites ran. (2633308 ms total)
[  PASSED  ] 48206 tests.
hipBLASLt version: 1000
gfx1201
[==========] 22565 tests from 13 test suites ran. (1311278 ms total)
[  PASSED  ] 22565 tests.


The generated QR Code for 2FA now contains an issuer.

The issuer can be configured in the config.php as SERVER_NAME and defaults to $_GLOBALS['SERVER_NAME']

Thanks for submitting a pull-request, it would be nice to address the comments and make sur the automated tests pass, they are currently broken.

I think i've addressed all issues you had.
Accidently another change was added to the pull request (https://github.com/fguillot/kanboard/pull/2435/commits/035c6225b9b4db6765a60d475b676b5c739b23a7).
I don't know how to remove it from the pull request, because this is a different feature.

Your PR have been merged manually (cherry-pick the commits and squashed into a single commit).
You should make a branch for each PR to avoid unrelated commits.
Thanks.


Visualisations of model with letsplot

We can discuss the place where these helper functions could be placed in library as their seems to be reusable in every conv models easily. I would keep this PR opened until there is a decision where to put this functions and maybe how to improve them and maybe introduce more of them

Created separate module for visualizations, run themnist samples with plotting on jvm (without jupyter) to compare the old aproach with the new one and the achieved effects

@avan1235 it's ok to add notebooks later, as you suggested, so write some useful KDocs and notify me, will run the TC

@zaleslaw I added the kdocs, hope they are readable

@avan1235 could I start a final review on this PR?

@zaleslaw There are no extra visualizations of activations and filters in conv1d but I think they can be added separately, as another PR. It depends on what do we expect from this PR - if only introducing the base for visualizations with nem approach and separated module for visualizations then you can start with the review

I've cloned your repo and run local examples.
I run an example LeNetFashionMnistVisualization.kt, I've got a messages.
SLF4J: The class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/C:/Users/zaleslaw/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-slf4j-impl/2.14.0/d6003a3b3f24fdb476848f4ecabdb2a43354e410/log4j-slf4j-impl-2.14.0.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/C:/Users/zaleslaw/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-simple/1.7.28/cf5f2cf3c31e0e41b68d932d756398a1238d4456/slf4j-simple-1.7.28.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory]

It looks like new dependencies added a hidden dependency to SLF4J bindings.
Also it prints (seems like in loop)
Graphics2D from BufferedImage lacks BUFFERED_IMAGE hint
Graphics2D from BufferedImage lacks BUFFERED_IMAGE hint
Graphics2D from BufferedImage lacks BUFFERED_IMAGE hint
Graphics2D from BufferedImage lacks BUFFERED_IMAGE hint

During the visualization phase, one of the pictures looks strange for both Conv examples but displays well after resizing. Did you face this issue?
Before resizing

After resizing

I've cloned your repo and run local examples.
I run an example LeNetFashionMnistVisualization.kt, I've got a message.
SLF4J: The class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/C:/Users/zaleslaw/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-slf4j-impl/2.14.0/d6003a3b3f24fdb476848f4ecabdb2a43354e410/log4j-slf4j-impl-2.14.0.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/C:/Users/zaleslaw/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-simple/1.7.28/cf5f2cf3c31e0e41b68d932d756398a1238d4456/slf4j-simple-1.7.28.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory]

It looks like new dependencies added a hidden dependency to SLF4J bindings.
We are using 2.14, but some dependencies use slf4j-simple-1.7.28.jar
Could you please propose a possible solution for this task?

I'll fix this by excluding the dependency in build.gradle

Also, it prints (seems like in loop)
Graphics2D from BufferedImage lacks BUFFERED_IMAGE hint.
Graphics2D from BufferedImage lacks BUFFERED_IMAGE hint
Graphics2D from BufferedImage lacks BUFFERED_IMAGE hint
Graphics2D from BufferedImage lacks BUFFERED_IMAGE hint

I don't see this. Maybe it is because you use Windows / another version of Java? I am working on Debian 10 with Java 11 fyi

During the visualization phase, one of the pictures looks strange for both Conv examples but displays well after resizing. Did you face this issue?
Before resizing

After resizing

I think that can also be connected with your environment meaning the Windows / Java version? In my case it is displayed correctly with no resizing needed but  I think that we would need some check of 3rd person / another computer if possible to test it better

On another side, the module and examples are ready to merge, but I suggest delaying it before solving the next things

[ ] Fix Graphics2D from BufferedImage lacks BUFFERED_IMAGE hint. warning
[ ] Fix SLF4J: The class path contains multiple SLF4J bindings.

Sorry, but does kotlinx.html issue is solved? I didn't see the repository mentioned earlier? Should I ping kotlinx.html creators?

Yeah, I've run it on Windows/Java 11.0.9
So,I'll try to fix hint things locally and share the results here

It's still not available. The kotlinx is added in main build.gradle. I think I can eventually move it to specific module gradle definition if you wish.
Yes, please look at this Graphics2D from BufferedImage lacks BUFFERED_IMAGE hint. strange message as I don't get it. I will fix the SLF4J in a few minutes

I've asked kotlinx.html contributors about deploying the previous version to the MC and created a ticket in let's plot kotlin (but contributor on vacation, and we could go without it for now).
So, will wait your fix for loggers and run the TC

Just created the fix - was searching for some good solution to do it explicitly (not as default for all dependencies) to have control over that exclusion. Just check if it will remove the warning also in your case

Great, thanks for the fix, the log message is in past for now and the kotlinx.html issue is localized in the visualization module.

Execution failed for task ':examples:test'. org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration$ArtifactResolveException: Could not resolve all files for configuration ':examples:testRuntimeClasspath'.
Looks like it's related to the order of the repositories

Fixed with moving the kotlinx dependency back to main build.gradle. Hope to remove it soon

@avan1235 I've merged this PR for now, but we have a problem, kotlinx.html maintainers are not going to release 0.7.1 on Maven Central.
I'll ask the lets-plot maintainers to bump the version from 0.7.1 to 0.7.3 (hope they will do it).
If it will be not solved and we could not isolate this dependency and bintray repo in the visualization module or in the examples module, we will need to remove this functionality or move it to the separate project

Ok, so in the meantime we can clean KotlinDL state by as you wrote - by placing the kotlinx repo dependency explicitly in two modules - examples and visualisations. What do you think?


openspecfun: 0.5.3 -> 0.5.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/JuliaLang/openspecfun/releases.
meta.description for openspecfun is: "A collection of special mathematical functions"
meta.homepage for openspecfun is: "https://github.com/JuliaLang/openspecfun"
meta.changelog for openspecfun is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.5.5 in filename of file in /nix/store/vs3nf9k4g4il3ynqfq86h6vsf99fkh5k-openspecfun-0.5.5

directory tree listing: https://gist.github.com/4b87fec654ec8cb5437cbfaa41522376

du listing: https://gist.github.com/a81c7faf671cef7a4fd650a8520e4262

Rebuild report (if merged into master) (click to expand)

24 total rebuild path(s)

6 package rebuild(s)

6 x86_64-linux rebuild(s)
6 i686-linux rebuild(s)
6 x86_64-darwin rebuild(s)
6 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
julia
julia-lts
julia-stable
julia_10
julia_15
openspecfun

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vs3nf9k4g4il3ynqfq86h6vsf99fkh5k-openspecfun-0.5.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A openspecfun https://github.com/r-ryantm/nixpkgs/archive/3c3d2edc0950d0c22171b88ee6bab4e12e056e83.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vs3nf9k4g4il3ynqfq86h6vsf99fkh5k-openspecfun-0.5.5
ls -la /nix/store/vs3nf9k4g4il3ynqfq86h6vsf99fkh5k-openspecfun-0.5.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package marked as broken and skipped:

julia-stable

1 package built:

openspecfun

Maintainer pings
cc @ttuegel for testing.

Result of nixpkgs-review pr 134238 run on x86_64-linux 1

5 packages marked as broken and skipped:

julia
julia-lts
julia-stable
julia_10
julia_15

1 package built:

openspecfun


a dropdown list of templates when you create new projects

(suggestion from arc)

could be nice, but think i'll hold off since you can have get mostly the same effect by having a templates folder you open up from, and save-as your project file


Inject ElasticSearch FilterBuilder on dynamic methods

can't find an easy way to do that... :disappointed:


import-entries error on OS X El Capitan

I'm using this after successfully exporting from the wordpress-exporter. The import-content-model command works perfectly and the import command works up until the entry part and then gives the same output:
$ contentful-importer --configuration=settings.yml import-entries
/usr/local/lib/ruby/gems/2.3.0/gems/contentful-importer-0.2.1/lib/contentful/importer/data_organizer.rb:28:in `/': divided by 0 (ZeroDivisionError)
	from /usr/local/lib/ruby/gems/2.3.0/gems/contentful-importer-0.2.1/lib/contentful/importer/data_organizer.rb:28:in `split_entries'
	from /usr/local/lib/ruby/gems/2.3.0/gems/contentful-importer-0.2.1/lib/contentful/importer/data_organizer.rb:19:in `execute'
	from /usr/local/lib/ruby/gems/2.3.0/gems/contentful-importer-0.2.1/lib/contentful/importer/parallel_importer.rb:31:in `import_data'
	from /usr/local/lib/ruby/gems/2.3.0/gems/contentful-importer-0.2.1/lib/contentful/importer/import_entries.rb:14:in `import'
	from /usr/local/lib/ruby/gems/2.3.0/gems/contentful-importer-0.2.1/lib/contentful/importer/import_entries.rb:19:in `run'
	from /usr/local/lib/ruby/gems/2.3.0/gems/claide-0.8.2/lib/claide/command.rb:312:in `run'
	from /usr/local/lib/ruby/gems/2.3.0/gems/contentful-importer-0.2.1/bin/contentful-importer:12:in `<top (required)>'
	from /usr/local/bin/contentful-importer:22:in `load'
	from /usr/local/bin/contentful-importer:22:in `<main>'

Here is my settings.yml:
#PATH to all data
data_dir: exported/news

########## IMPORT DATA TO CONTENTFUL ##########

## EXPORTED XML FILE FROM WORDPRESS
wordpress_xml_path: wordpress_settings/wp-news-2016-02-03.xml

## CONVERT CONTENTFUL MODEL TO CONTENTFUL IMPORT STRUCTURE
content_model_json: wordpress_settings/contentful_model.json
converted_model_dir: wordpress_settings/contentful_structure.json

contentful_structure_dir: wordpress_settings/default_contentful_structure.json

# Contentful credentials
access_token: XXX
organization_id: XXX
space_id: XXX
default_locale: en-US

I believe this is the issue fixed by #24, but there hasn't been a new gem release since merging that. For the time being, you can either use master or explicitly pass a non-zero thread count on the commandline , e.g. --threads=1.

Hey @oddmouse,
Releasing a new version now with your issue fixed.
Cheers

Thanks @neonichu and @dlitvakb. You guys are quick! Works like a charm.


Low battery script

Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
It will popup a message displaying Low battery
Fixes #1674

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] My documentation follows Template for README.md
[x] I have added the project meta data in the PR template.
[x] I have created the requirements.txt file if needed.

Project Metadata
If there is no-file/nothing to fill the below fields with, then type: none
Example: If no requirements.txt needed/present, then type none in Requirments.
Category:

[ ] Calculators
[ ] AI/ML
[ ] Scrappers
[ ] Social_Media
[ ] PDF
[ ] Image_Processing
[ ] Video_Processing
[ ] Games
[ ] Networking
[x] OS_Utilities
[x] Automation
[ ] Cryptography
[ ] Computer_Vision
[ ] Fun
[ ] Others

Title: Low Battery Alert
Folder: Low_battery_alert
Requirements: Readme.md
Script: low_battery_alert.py
Arguments: <enter any arguments that the script needs but - separeted like: h-c-m>
Contributor: Gulshan Kumar jakhon
Description: This Script will help the user when the system battery goes low, this script will popup message "Low battery"

Hi @avinashkranjan please review


Add more containerd logs

What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Adds '--pids' option to shimdiag.exe log collection
Collects logs from hcsdiag.exe tool
Fixes #
Special notes for your reviewer:
Release note:
Release note:
none

cc @chou @ShiqianTao  @junjiezhang1997

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.013%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3032

Relevant Lines:
3937

💛  - Coveralls

@AbelHu @ShiqianTao  could you please take a look? Thanks!

@AbelHu @ShiqianTao could you please take a look? Thanks!

This has been verified on AKS windows cluster:

Could you please take a look and merge PR if things look good please? Thanks!


fix #481 close when Jedis not work any more

Ⅰ. Describe what this PR did
close when Jedis not work any more
Ⅱ. Does this pull request fix one issue?

fix #481
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #482 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop     #482      +/-   ##
=============================================
- Coverage      28.03%   28.01%   -0.02%
  Complexity       646      646
=============================================
  Files            193      193
  Lines           7451     7456       +5
  Branches         910      910
=============================================
  Hits            2089     2089
- Misses          5144     5149       +5
  Partials         218      218

Impacted Files
Coverage Δ
Complexity Δ

...r/discovery/registry/RedisRegistryServiceImpl.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 900be5c...731ec94. Read the comment docs.

Codecov Report

Merging #482 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop     #482      +/-   ##
=============================================
- Coverage      28.03%   28.01%   -0.02%
  Complexity       646      646
=============================================
  Files            193      193
  Lines           7451     7456       +5
  Branches         910      910
=============================================
  Hits            2089     2089
- Misses          5144     5149       +5
  Partials         218      218

Impacted Files
Coverage Δ
Complexity Δ

...r/discovery/registry/RedisRegistryServiceImpl.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 900be5c...731ec94. Read the comment docs.


option for mocha-clean

Would be good to have an option for mocha-clean.
Unless of course it's possible to use the latest Mocha version which pretty much obsoletes the mocha-clean.

have you tried implementing it in your html test runner? https://github.com/rstacruz/mocha-clean#usage-browser

I'll test-run today and come back to you with some results, thanks!

Unfortunately not working :(

The latest mocha should not break this runner, I'll look into bumping it.

I bumped mocha to latest in master.


ERROR -<EMAIL_ADDRESS>start: gulp

Hi
I am new to Foundation email. I am following the official documentation step by step. But when is tried to npm start in the project directory then I get a really flashy error as below:
npm ERR! Windows_NT 10.0.15063
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "start"
npm ERR! node v7.2.0
npm ERR! npm  v3.10.9
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: gulp
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'gulp'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the foundation-emails-template package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs foundation-emails-template
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls foundation-emails-template
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Parmveer\Downloads\Email Foundation 6\EmailSass\EmailTemplate\npm-debug.log
Here's the log file:
npm-debug.log
I have tried to fix the git path in environment variable of the os.
I am stuck here. Could you please help me out with this.

Hi, and what was the solution?

Not much info here. Did you try to install the latest 7. release of Node.js?

I've did when fixed, however with further use I noticed that I need to run every npm start using sudo. Otherwise won't work but I suppose this is more related to how the foundation CLI is installed and where the project is located.

I've did when fixed, however with further use I noticed that I need to run every npm start using sudo. Otherwise won't work but I suppose this is more related to how the foundation CLI is installed and where the project is located.

This is related how you installed it with npm.

Closing as we did not receive any further feedback.


Spec needs to allow "#void" for consistency with "const Symbol('void')"

In issue #19972, we decided that in spite of the fact that "void" is not a valid identifier, we should allow:
const Symbol('void')

and
new Symbol('void')

because the mirrors API has come to rely on the use of the void symbol to represent the name of the return type of a function returning void.
For consistency, I believe we should also change the spec to allow void as a symbol literal, i.e.:
#void

I propose to modify the grammar rule:
symbolLiteral:
  ‘#’ (operator | (identifier (‘.’ identifier)*))
  ;

To instead read:
symbolLiteral:
  ‘#’ (void | operator | (identifier (‘.’ identifier)*))
  ;

(Note that the vm, dart2js, and the analyzer all currently forbid void as a symbol literal).

No milestone now: This will not block Dart 2.
We may still perform said adjustment.

#void is supported today.


Add "Run piped external commands" example

Please propose a nice example of >=2 commands piped to each other.
cc #266
See CONTRIBUTING.md for details.

 The example will rely on std::process::Child and std::process::Stdio in order to run the equivalent  bash command:
echo "cookbook" | grep -o . | sort | uniq

Is it ok with you?

@ludwigpacifici excellent! Go for it :+1:
Although I'd try to use commands that would be both actually useful and not trivially reproduced in pure rust just to make the example more interesting.
If you will have hard time thinking up such example ping me and I'll help.

Good point ; what do you think about the below?
# For a given directory, shows the `<number>` biggest files/directories and its human readable size.
du -ah <directory> | sort -hr | head -n <number>

<number> and <directory>can be passed by the command line and use the clap crate?
Also, processes can be handle via tokio_process crate. Should I use it or use the standard one (std::process)?

Nice! Although I would avoid additional crates here not to obfuscate the examples lets go with just std::process.

Hi @ludwigpacifici . Do you need help with this example?

Thanks @budziq, it should be fine. I send the pull request #297 to start discussing the code review.

merged!


[ImgurBridge] Web-scraping imgur bridge

A bit of a request for comment really. A start of what #1068 wants. Scrapes the website rather than using the API like #1662.
For filling in timestamp, content, and enclosures, it would need to request the page for each post in the feed, is this what we want? That seems rather heavy, are there other bridges that do this so I can understand our best practice around caching in that instance?
Alternatively on timestamps, imgur does say "4 hours ago" on the search page, and maybe I could parse that, but it would be messy, changing frequently.

Taking a look at other PRs, namely #1836, I can see that yeah, fetching the page for every item in the feed is accepted practice. So I can add that later I think

I think it's best to just close this, as #1662 or similar is going to be a better solution

I think it's best to just close this, as #1662 or similar is going to be a better solution


Update habana profiler (#50)

What does this PR do?
Updates the way habana profiler works with ability to steer waiting steps
Cherry-picked from habana-dev

@regisss please review


Correct usage

Hi. I'm wondering if this is the correct usage:
{
    "version": "0.0.1",
    "summary": "my project",
    "repository": "https://github.com/user/project.git",
    "license": "bsd3",
    "source-directories": [
        "."
     Thanks for your work in putting this project together!

You need to add aforemny/elm-mdl as a dependency to dependencies the version does not matter. dependency-sources are just for specifying where your dependencies come from so adding a only package there does nothing.

That did it!


Add Sofie to .zenodo.json

With this PR I added my own name to the .zenodo.json file.
That's all 👯

We are thinking about removing all authors from the zenodo publication and use "ASReview developers" or something similar instead. This is more inclusive given the number of contributors (of which many contributed on github, while others in different ways.) In our opinion.
If we change our minds, we will reopen this PR.