handle python datetime object

Currently, the date arguments are sent as string objects.  Need to handle datetime objects.

Handled the python datetime object.


[BUG] Getting the size of the attachment doesn't work

Expected Behavior
When I use Timber::get_attachment($image), I want to get the size of the file in MB and not in Bytes, unfortunately the conversion is not done.
Actual behavior
Code :

{{ file.extension|upper }}
{{ file.title }}
{{ file.size }}

Render :

Steps to reproduce behavior
No response
Notes
For the moment the temporary solution is to do this in the twig:
{{ fn('size_format', file.size) }}
What version of Timber are you using?
2.0.0-rc.1
What version of WordPress are you using?
WordPress 6.3.2
What version of PHP are you using?
8.2
How did you install Timber?
Installed or updated Timber through Composer

Size are now returned as a raw value (see https://github.com/timber/timber/pull/2753).
If you want to format your value, use the size_format filter:
{{ file.size|size_format }}

This still needs to be documented, I'll update the docs soon.

Perfect, yes indeed, I had relied on the documentation.
Thank you!

@thomasnavarro It's documented now!


fix: --fail-fast deadlock

Current situation
--fail-fast can end in a deadlock.
Proposal
Fix fail-fast logic

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 47 (0.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.6%) to 50.855%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/action/action.go
0
47
0.0%

Files with Coverage Reduction
New Missed Lines
%

internal/helm/chart/dependency_manager.go
2
90.1%

internal/action/action.go
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>1:
-0.6%

Covered Lines:
1695

Relevant Lines:
3333

💛  - Coveralls


Update code-signing-cert-manage.md

I have added Certera EV Code Signing Certificate as the certificate authorities offering EV Code Signing Certificate.

#assign @anaharris-ms

@jp-mehta ,
Thank you for your suggestion, but we only accept certs from members of the Microsoft Trusted Root Program.


Add Frensel lens

Would be great to have frensel lens capability

Fresnel lenses are just normal lenses mathematically speaking, they just require a lot less material and lenses aren't displayed in this simulator anyways

It would make a really cool example lens!

Example added in #60 by @StasFainer.
However, a direct tool to create this (with tunable parameters) is still desired.

Now it can be created with Glass -> Custom equation


Velocity = 🚄?

https://github.com/JuliaClimate/IndividualDisplacements.jl/blob/7a5df040c6674013deb461f5fe6bd3feb21d3ba4/src/API.jl#L20
I find it confusing to describe the 🚄 as velocity, whereas from the /src it seems to me that this is actually the interpolation function for a given velocity field? Reading through the docs I initially thought that one has to provide the flow fields as 🚄.

https://github.com/openjournals/joss-reviews/issues/2813

I just added a comment in the docstring to be more explicit (the quoted line  starts with functions but was not enough). The hasted docs also now has this information further repeated (see typical workflow, and 2nd tutorial example)

Sounds good.


unison: 2.48.4 -> 2.51.2

Motivation for this change
Update unison to the latest upstream.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ocamlPackages.unison

@GrahamcOfBorg build usync


file extensions not working

vscode 1.4
win 10 x64
I have this
    // Configure file associations to languages (e.g. "*.extension": "html"). These have precedence over the default associations of the languages installed.
    "files.associations": {
        "*.js?": "javascript",
        "*.es": "javascript"
    },

    "vsicons.useFileAssociations": true,

Actual behaviour:
only .js files are "iconized"

Can confirm it.
This does not work. (I just don't recognized.)
http://prntscr.com/c26rpi
VSCode 1.4 Stable.
Windows 10 64x

My bad... First of all, no regular expression or glob patterns are supported. Second, I didn't really think about file associations already having its own convention (they use "javascript" instead of "js" for associations) so this won't work. I will fix it asap and let you know :disappointed: The only way for this to work at the moment would be this:
"*.es": "js"

But as I said, wait for the fix. :wink:

I've just published 1.5.6 that will fix this. Still not supporting complex patterns but will cover the most common scenarios.
To use it, you won't be using file.associations anymore but a custom property inside vsicons:
{
  "vsicons": {
     "useFileAssociations": true,
      "associations":{
        "*.cc": "css"
      }
    }
}

In your case, first case is not supported at the moment, but I will try to implement it if possible  :wink:

@robertohuertasm does not seem to be working for me.
in user settings.json
// VS Icons

  "vsicons": {
     "useFileAssociations": true,
      "associations":{
        "*.es": "js"
      }
    }

the options does not appear on the workspace settings (not sure if relevant)
same environment as above

You're right, now only supported extensions will work... . es is not in the list of supported extensions so it won't be considered.
I'll try to fix it tonight. Sorry for the inconveniences!

It's already fixed. #152
Will be released soon in a major version with other enhancements.

@robertohuertasm great work, thanks!

Already released in 1.6.0

@robertohuertasm does not work for me. Same config as above (also tried several extensions values

Please, read the new readme as this has changed to support regular expressions.

@robertohuertasm Tried a bunch of configs until I hit the update command :sweat_smile:

@rickmed thanks for your feedback. I'll update the readme to make it more explicit.


encrypted coveralls token

Just a note coveralls docs suggest/ask/insist on keeping tokens private (though give no guidance on how).
The sercure vars is one way to do it.
http://docs.travis-ci.com/user/environment-variables/

Thanks.
Fixed using Travis env variables

ah cool. I hadn't got to using those.


[Explorer] Updates UI for Addresses displaying packages

The below demo shows how this works at different screensizes:
https://user-images.githubusercontent.com/11377188/199743126-4f77a870-31ee-454c-8a5e-9833243d48ea.mov
Updated 3/11/2022

@Andrew47 i see deltas from mobile & tablet breakpoints? https://www.figma.com/file/kSD0qXCIDZA4KQVNepA5hR/02-Explorer?node-id=211%3A48503

@mystie711 , It might be that some of these features are to be implemented in subsequent PRs. The list I have is as follows:

Display modules in a paned section (this PR)
Add search functionality (next PR)
Display public functions - this is where I'll add the Simulate & Execute section
Support executing transactions within module view - this is where I'll add the buttons you see in the Simulate & Execute section

@Andrew47 good to know we have more PRs coming.
I was specifically referring to spacing and ui component details for mobile/tablet sections,

selection state of items in Modules list
selection bg color
module list height on mobile, tablet

If it is easier to talk through over a Slack huddle let's do that.

Just to keep all reviewers in the loop; I'm going to change the plan and add the search functionality part to this PR. This matches with there being one JIRA task for both pieces of functionality. It should also simplify getting the padding/spacing right.

@mystie711 --> I've updated the PR:

The cut-off from the 'mobile' look to the 'desktop' look has been reduced to 768vw.
There is now a search bar.
The borders were indeed > 1px; this has been fixed.
The space on the right of the buttons has been reduced.
Only 5.5 items are shown on mobile screen sizes.
I've checked the colours match those specified in Figma.

The video at the top of the page has been updated to reflect the new look.

Looks like there's some weird breakpoints:

This is strange. I've tested the PR on Chrome, Firefox and Safari on macOS and could not replicate this screenshot. Could you provide some further details on where this was seen?

1544px

Excellent - I see now.

@mystie711 / @Jordan-Mysten , I've updated the PR to use the new search function UX as detailed in Figma


Add few more tests for native Python API

@DonJayamanne Do you plan on working on this?

If yes, there are a few cases:

When pet is not available in the extension, there is no error
If there is a permission issue to run pet there is no error

Basically if spawn fails for any reason, we are not raising error and exiting in a safe way.


SPIFFS Partition Could not be found (IDFGH-3578)

Environment
Development Kit: ESP32-Wrover-Kit
Kit version (for WroverKit/PicoKit/DevKitC): v4
Module or chip used: ESP32-WROOM-32
IDF version : 4
Build System: CMake
Operating System: Linux
Using an IDE?: PlatformIO on Visual Studio Code
Power Supply: USB
I am using Arduino as an ESP-IDF Component
Problem Description
I am getting an error 261
When I initiate SPIFFS
  Serial.println("Setting Up Flash Memory Reader");
  if (!SPIFFS.begin(true))
  {
    Serial.println("An Error has occurred while mounting SPIFFS");
    return;
  }

Steps to reproduce

I uploaded the program with Platformio
I uploaded the SPIFFS data via Arduino.

Code to reproduce this issue
// the code should be wrapped in the ```cpp tag so that it will be displayed better.
#include "esp_log.h"

void setup()
{
  Serial.println("Setting Up Flash Memory Reader");
  if (!SPIFFS.begin(true))
  {
    Serial.println("An Error has occurred while mounting SPIFFS");
    return;
  }
}

void setup()
{
Serial.begin(115200);
Serial.println("Default SSID" + DEFAULT_SSID);
Serial.println("===================Setting Up Start=======================");
//Relay Setup
Serial.println("Setting Up Relay");
pinMode(relay_pin, OUTPUT);
//Rtc
Rtc.Begin();
Serial.println(printDateTime(Rtc.GetDateTime()));
//Serial.println("Printing Current Date & Time From DS3231");
//printDateTime(Rtc.GetDateTime());
//preferences settings
fmem.begin(flash_namespace);
//fmem.clear();
uint8_t size_of_one_time = fmem.getBytesLength(onetime_keystore_key);
uint8_t size_of_reccurring = fmem.getBytesLength(recurring_keystore_key);
Serial.println("Current Onetime Key Bytes Length");
Serial.println(size_of_one_time);
Serial.println("Current Recurring Key Bytes Length");
Serial.println(fmem.getBytesLength(recurring_keystore_key));
Serial.println("Current Relay State");
Serial.println(fmem.getUInt(relay_state_key, 0));
//Switch Relay To that state
switch_relay(fmem.getUInt(relay_state_key, 0));
if (size_of_one_time == 0)
{
onetime = false;
}
if (size_of_reccurring == 0)
{
recurring = false;
}
load_keystore();
Serial.printf("\nOne Time Keystore Size: %d", onetime_keystore.size());
Serial.printf("\nRecurring Time Keystore Size: %d", recurring_keystore.size());
for (String i : recurring_keystore)
{
Serial.println(i);
}
//LED Testing
Serial.println("Setting Up LED");
pinMode(led_pin, OUTPUT);
Serial.println("Setting Up Hotspot");
setup_hotspot();
Serial.println("Setting Up Flash Memory Reader");
if (!SPIFFS.begin(true))
{
Serial.println("An Error has occurred while mounting SPIFFS");
return;
}
Serial.println("Running Switch Reset in Core 0");
//Running Timer Checker on Core 0
xTaskCreatePinnedToCore(time_checker_task, "Time Chcker", 10000, NULL, 0, &Task1, 0);
Serial.println("===================Setting Up Stop=======================");
}
Debug Logs
https://gist.github.com/mntolia/d709bccaba7974cd8670f983c5a0726a
Other items if possible

[ ] SDKconfig file: https://gist.github.com/mntolia/0fb93ca96206ff5c7fee349f1beedcfd

How is your partitions.csv looks like?
Do you have board_build.partitions = partitions.csv n platformio.ini file?

How is your partitions.csv looks like?
Do you have board_build.partitions = partitions.csv n platformio.ini file?

You are right.
Darn it. I put one less 0 in the spiff's partition. Sorry for the trouble.

@chegewara Thanks for the notes. @mntolia Thanks for reporting, feel free to reopen if the issue still happens. Thanks.


Correction for raw affiliation IFB - South Green Bioinformatics Platform, Bioversity, CIRAD, INRAE, IRD – Montpellier, France; PHIM Plant Health Institute, University of Montpellier, CIRAD, INRAE, Institut Agro, IRD – Montpellier, France

Correction needed for raw affiliation IFB - South Green Bioinformatics Platform, Bioversity, CIRAD, INRAE, IRD – Montpellier, France; PHIM Plant Health Institute, University of Montpellier, CIRAD, INRAE, Institut Agro, IRD – Montpellier, France
raw_affiliation_name: IFB - South Green Bioinformatics Platform, Bioversity, CIRAD, INRAE, IRD – Montpellier, France; PHIM Plant Health Institute, University of Montpellier, CIRAD, INRAE, Institut Agro, IRD – Montpellier, France
new_rors: 05q3vnk25;03rnk6m14;003vg9w96;05kpkpg04;051escj72;03fkrcm40;05y5s3h28
previous_rors: 05q3vnk25;03rnk6m14;003vg9w96;05kpkpg04;051escj72;03fkrcm40
works_examples: W3185853800
contact: 6f117ddf3118bf031cdcacc724bb3e01:c5bac91e566d5df3cbce790dd81c18af1150 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


[crypto] re-activate the batch verification feature

The batch verification feature was de-activated for technical (build) reasons in https://github.com/libra/libra/pull/5061
This issue is about re-instating it, when we switch to the new resolver (https://github.com/libra/libra/pull/3134) or ed25519-dalek 1.0.0-pre.4 is released, whichever comes first.
(cc @kchalkias )

Thanks! One other reason was to avoid randomized verification at this stage until our analysis with @valerini and @huitseeker gets finished.


Uber native login flagging error

I am currently running the example codes provided by Uber SDK (Swift  version).
I encounter a problem when I clicked on the Native Login
After setting up the app in Uber and also copied the Client ID to the info.plist, I counter the error below:
When I click at the Login Button,  Uber App open and flag a UIAlert with a message of "There seems to be a problem connecting to Uber. Please go back to AppName and try again". What could be the problem? and not redirecting to my application
Btw, I fill in the redirect URL as "myapp://oauth/callback" on both the dashboard and the app info.plist.
Anything I miss out during the setup of this example?
Thanks.

Hi @MukeshMuteja786 sorry to hear you're having trouble. Not redirecting back to your app sounds like there could be an issue with how you have your redirect URL set up. I see that you added the url to your dashboard and the info.plist. Did you also add "myapp" as one of the URL types recognized by your app? You can either do this via the Info tab of your application target or by adding the following to your info.plist:
	<key>CFBundleURLTypes</key>
	<array>
		<dict>
			<key>CFBundleTypeRole</key>
			<string>Editor</string>
			<key>CFBundleURLSchemes</key>
			<array>
				<string>myapp</string>
			</array>
		</dict>
	</array>

You also need to make sure that you have added your app's Bundle ID to the dashboard, in the App Signature field.

Firstly Thank you for support and Faster Reponse ...
Now App Redirecting Back but with error
Error Domain=com.uber.rides-ios-sdk.ridesAuthenticationError Code=18 "The Redirect URI provided did not match what was expected." UserInfo={NSLocalizedDescription=The Redirect URI provided did not match what was expected.}

That error indicates that the redirect you specified in your info.plist
doesn't match exactly what you have listed on the developer dashboard.
If on the dashboard I am using "exampleapp://connect" then for the callback
in my info.plist I would also have "exampleapp://connect". And in my url
types I would only need the scheme, "exampleapp"
On Wed, Aug 31, 2016 at 9:17 PM MukeshMuteja786<EMAIL_ADDRESS>wrote:

Firstly Thank you for support and Faster Reponse ...
Now App Redirecting Back but with error
Error Domain=com.uber.rides-ios-sdk.ridesAuthenticationError Code=18 "The
Redirect URI provided did not match what was expected."
UserInfo={NSLocalizedDescription=The Redirect URI provided did not match
what was expected.}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/uber/rides-ios-sdk/issues/100#issuecomment-243971837,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFPJ4Esg09TiqpuNjbXPC8EpNokYNnWxks5qllH1gaJpZM4JxUwf
.

Please Help me to get Solve this issue. data on .plist :- is

CFBundleTypeRole
Editor
CFBundleURLSchemes

myApp

UberCallbackURIs

URIString
myApp://connect
UberCallbackURIType
General

URIString
myApp://connect
UberCallbackURIType
AuthorizationCode

URIString
myApp://native_deeplink_callback
UberCallbackURIType
Native

and Same "myApp://connect" URL on Dashboard  NSLocalizedDescription=The Redirect URI provided did not match what was expected

the information on .plist are:-
CFBundleTypeRole
Editor
CFBundleURLSchemes

myApp

UberCallbackURIs

URIString
myApp://connect
UberCallbackURIType
General

URIString
myApp://connect
UberCallbackURIType
AuthorizationCode

URIString
myApp://native_deeplink_callback
UberCallbackURIType
Native

and on Dashboard link is same myApp://connect
error is same "NSLocalizedDescription=The Redirect URI provided did not match what was expected."

Thank you @jbrophy17  for your support and Faster response

no problem :)


"zero-sh" is actually "zero" in tap

The documentation and setup script install the brew named "zero-sh" but it's simply zero.

This. Seems the README.md needs to be updated to read:

brew install zero-sh/tap/zero

Fixed by @buckleyc in #9.


Maybe I can use Nokogiri from Bundler?

Another lingering bit of build weirdness from #741; see also #781 and #777

🚀 Deployed on https://6617af66b07fb16c09102745--alexwlchan.netlify.app


Real-Time-Chat-Application (1417)

Real Time Chat Application using PHP with MySQL & Ajax
- Creating a Real-Time Chat Application with PHP with MySQL & Ajax.
- It will keep track on the users and save chat history with respective person.
- And it also keep track on the conversations, so its also safe.
- It has LOGIN/LOGOUT feature, so security and privacy is also maintain.

TECHNOLOGY USED:

PHP
MYSQL
JQUERY
BOOTSTRAP
HTML
CSS

Hello @Jyoti6828 ! I really appreciate the amount of work that you put in the code. However, this repo strictly contains projects made using HTML, CSS and vanilla javascript. I'm really sorry but we cannot merge your pr. Hope you understand.

Okay.. So can I build this application using HTML, CSS, vanilla JavaScript.

Sure! Please go ahead.

@Rizwan-S  Sure!.. Thank You So Much!!
I will do it ...

@Jyoti6828 what's the update?

@Rizwan-S I'm working on it. I will push the code as soon as possible.


Endpoint config not always updated when sending query

Version and Environment Details
Operation system: MacOS
IDE name and version: IntelliJ 2019.3.3
Plugin version: 2.3.0
Expected Behaviour
If I change a service endpoint configuration in .graphqlconfig (namely, updating an Authorization header that is configured for that endpoint with a new Bearer token), I expect GraphQL requests sent to that endpoint to take this change into account.
Actual Behaviour
It seems the updated Authorization header is not sent: I'm getting an error message from the server saying that credentials are required.
Schema introspection calls, which are protected by the same means on the server, are working.
Note that the introspection call issued by a click on the GraphQL Schemas and Project Structure tool page tab  fixed the issue, but a click on the green button in the editor window of .graphqlconfig does not.
A better way to reconfigure the endpoint which is used for the sending queries would improve usability.
Steps to Reproduce / Link to Repo with Reproduction and Instructions
See actual behaviour section.

Sorry for the noise!
It seems like the configuration used for queries is updated as soon as the .graphqlconfig is saved to disk.
That's a thing that is easily forgotten in IntelliJ with its usual "no need to explicitly save" approach.
Anyway, I still think this is a confusing behaviour, and there might be a possibilty in the GUI to make that "you need to save" requirement more visible or even unneeded.
Could maybe an auto-saving of the .graphqlconfig be done before running the query?

Hi Dirk,
Thanks for using the plugin.
This is a good suggestion. I'll mark this as an improvement candidate for an upcoming release.
Best regards,
Jim


Refactor store and resource types into models package

The original implementation had two types per API Resource, and those types were translated from and into the store package. I changed it to have a models package that is used all over the application. The mapping from models to MySQL tables is hidden under the store.Store api instead of being in the resource handlers.
For proving that it works as expected, I extended the test suite with some basic integration tests for the MySQL store.

The tests are actually altering the database, creating and updating features and environments forever thanks to config from the environment variables. This is bad, I didn't know that.

I agree with the models package decision

I don't see a problem with the test wiping out the database on each run. It's the development database. Nothing valuable should be stored there. And it's a quite common behaviour in my opinion.
Even if I change it to create random data in each run, it will still mess up with the database. And we need integration tests for the store package. There is no other way to be sure that the database code works as is expected, than to actually running against a database.

I think a proper solution would be to have a setting to indicate the databse in which you want the test to run. This way you can have a dedicated test database and are not forced to use the app-level connection settings

We can change the database name to always be test. Alternatively we can add a TEST prefix to the environment variables, Like LAIKA_TEST_MYSQL_HOST.

:+1:


Is This Project Abandoned ?

Its been 4 years almost last commit , its been to long this project have not updated is this project abandoned?

@PREKNOWLEDGEWEB  https://github.com/NodeOS/NodeOS/issues/441#issuecomment-667554567

In #441, there's more information about the situation.

@PREKNOWLEDGEWEB #441 (comment)
It's not that we wouldn't work on this, but we also have other things to do, like working on other Stuff. This Project is Open Source and everyone is welcome to contribute. I wanted to revive that Project, but having a Full Time Job and doing Side Projects takes up a lot of Time, so that Projects like NodeOS doesn't get that much Attention anymore.
But like i said if you want to contribute, you're totally welcome to do so. We have plenty of things to do.

People , You are awesome<3 <3 <3

@PREKNOWLEDGEWEB #441 (comment)
It's not that we wouldn't work on this, but we also have other things to do, like working on other Stuff. This Project is Open Source and everyone is welcome to contribute. I wanted to revive that Project, but having a Full Time Job and doing Side Projects takes up a lot of Time, so that Projects like NodeOS doesn't get that much Attention anymore.
But like i said if you want to contribute, you're totally welcome to do so. We have plenty of things to do.

We and the community are with you luii even it's 2024, we are desperate to make this thing a real one! Me and all of this open source community also love the idea of this project. We are with you.

I'm myself focusing all my spare time that i'm not working on freelance projects and trying to move forward https://mafalda.io. I would LOVE to be able to find some time to get back on NodeOS and try to update and finish It, but in the foresee, i think my "big open source projects" time have got behind... :-/
Said that, if anybody is interested, I can agree on being contracted as a freelance for some hours to put NodeOS in shape, or can accept PRs of somebody else doing It. Maybe i would consider givin admin permissions to somebody else if it's interested and have a clear plan to propose about that.

I would also like to work on this project.

I would also like to work on this project.

What do you propose to do?

Has anybody thought of DenoOS?


update link to metrics-server repo

the current text indicates metrics-server but the link points to heapster.

/sig instrumentation
/assign @brancz

/lgtm

/approve


returns user to mono-mode after exiting VR, fixes #22

@dmarcos r?

Addressed comments from @cvan.    1/ removed useCapture false, 2/ removed the extra non-prefixed fullscreenchange.

Thanks @dmarcos !


boards: arm: swan_r5: Add support for the Blues Wireless Swan

Add Zephyr support and docs for the Blues Wireless Swan, an STM32L4R5-based board.

Thanks @erwango, I've made the requested changes and squashed all of my commits. Please take a look and let me know if there's anything else I need to address.

Thanks @erwango, I've made the requested changes and squashed all of my commits. Please take a look and let me know if there's anything else I need to address.

@bsatrom Thanks but I don't see the changes... Did you push the right stuff ?

@bsatrom Thanks but I don't see the changes... Did you push the right stuff ?

I believe so, but please let me know if I've done something wrong.

@bsatrom Thanks but I don't see the changes... Did you push the right stuff ?

@erwango I believe so, but please let me know if I've done something wrong.

You can just have a look to this PR and see that code is still the same and 3 commits are still there.
Obviously, something went wrong on your side.

@erwango I am looking at the PR and I see changes in 14 files, including the ones you request, for instance board.c here. Are you not seeing any of those changes?

Ok, I see you made changes, but I'm still seeing 3 commits ...

Yeah, I am having a bit of trouble squashing those two into the latest, but I will get it done.

ok @erwango should be good to go now

@erwango or others, any idea when this PR will get a deeper look?

What's the next step here?

What's the next step here?

@bsatrom We need to get the CI passed, then minimum 2 approvals.
Currently CI is failed (See Documentation Build), but having a closer look, it doesn't seem related with you changes.
Would you mind rebasing and see if issue vanishes ?

@erwango ah, I was wondering about that. Will do.

urk, I borked this quite badly. Will fix.


up2k not work in Google Chrome

Describe the bug
any file upload task by up2k will fail in Google Chrome 129.0.6668.100, seems to be related with filename or filesystem charset, but full alphabet filename fails too.
To Reproduce
no specific step
edit: it's triggered by enabling https
Client details

OS version: Arch Linux
browser version: Google Chrome 129.0.6668.100

Additional context
the error page:

btw it works fine in Mozilla Firefox 131.0

ohh, i think i know what this is - could you try to switch the language to English? if that makes it work, I'll get it fixed properly tonight.

I found it's related to https just now, upload works great with http.

I found it's related to https just now, upload works great with http.

that's weird... could you please try to change language to Chinese, then refresh the page, and see if the problem returns?

I found it's related to https just now, upload works great with http.

that's weird... could you please try to change language to Chinese, then refresh the page, and see if the problem returns?

Hi, yes after some more rounds of testing, ui language should be the problem. it works sometime after switching between languages so I made a wrong conclusion before.

Awesome, thanks! I plan to have it fixed tonight, unless something else comes up 👍


Set new Global ENV

Global.env param
Hello! How can I add an additional parameter to global.env ?
There are four modes of operation: dev (local), testing, productrion, and demo.
How can I add a "demo"?
I run: gulp build --env=demo
But it does not work.
PS I want in file main.ts present variable "declare var ENV: string" // demo

env for gulp tasks should be using --env=demo
but for build step, it's in
https://github.com/antonybudianto/angular2-starter/blob/master/src/systemjs.conf.js#L9

I run gulp serve-dev --env=demo
But in systemjs.conf file global.ENV == undefined

no, --env=demo will never affect global.ENV since they're totally different.
--env is for node environment, global.ENV is for browser environment

Yes, how i can change global.ENV?
I want add "global.ENV = demo". How I can do this?

you can declare that anywhere before systemjs.conf.js loaded, for example you create env.js with following lines:
(function(global){
global.ENV = 'demo';
})(window);

and load the script before systemjs.conf.js

I have a different configuration files (a class).
I depending on the environment variable must use different files.
For example, "demo.conf" or "dev.conf"

Thank you, it solved my problem.


[HOLD for payment 2023-08-01] [$1000] mWeb - Next button is hidden behind the keyboard

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click + icon and select assign task option
Click on title or description to open keyboard

Expected Result:
Next button should float to the top above the keyboard and not be hidden behind the keyboard
Actual Result:
Next button is hidden and user have to close keyboard to click on Next button
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/b8bb7fde-3a8f-435e-a698-1572e95e50c8
https://github.com/Expensify/App/assets/93399543/5a156b48-c2a2-494c-b4eb-d215053d8b03
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689051900984439
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0156fee52bf18361b2
Upwork Job ID:<PHONE_NUMBER>140999680
Last Price Increase: 2023-07-14

Proposal
Please re-state the problem that we are trying to solve in this issue.
For mWeb task details page Next button isn't shown when keyboard opened
What is the root cause of that problem?
We are not passing the shouldEnableMaxHeight to the ScreenWrapper here which won't adjust the maxHeight on updated windowHeight.
https://github.com/Expensify/App/blob/702d8e254760b3ac3d90586d80528acebbb0b529/src/pages/tasks/NewTaskDetailsPage.js#L75-L78
What changes do you think we should make in order to solve the problem?
Pass shouldEnableMaxHeight prop to the ScreenWrapper for NewTaskPage which will update the maxHeight based on the windowHeight which makes sure to show the button if the space is available for it.
https://github.com/Expensify/App/blob/702d8e254760b3ac3d90586d80528acebbb0b529/src/pages/tasks/NewTaskDetailsPage.js#L75-L78
We can pass the shouldEnableMaxHeight prop to other pages as well.

Was able to reproduce, updated OP for the expected result to

Next button should float to the top above the keyboard and not be hidden behind the keyboard

Example here

@Pujan92 Thanks for the proposal. Your RCA is correct and the solution looks good to me.
:ribbon: :eyes: :ribbon: C+ reviewed
Link to proposal

@Beamanator can you review @Pujan92 's proposal above plz?

@s77rt - the proposal looks great, and I think we should also check if there's other places we need to be adding that prop but aren't 👍

@s77rt @Beamanator PR is ready for review!

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/16443 and https://github.com/Expensify/App/pull/17940
The offending PR has been commented on: https://github.com/Expensify/App/pull/16443#issuecomment-1650602866 and https://github.com/Expensify/App/pull/17940#discussion_r1274151064
A discussion in #expensify-bugs has been started: https://expensify.slack.com/archives/C049HHMV9SM/p1690322590131429
Determine if we should create a regression test for this bug: No

Issue reporter: @gadhiyamanan paid $250 via Upwork
Contributor: @Pujan92 paid $1500 via Upwork, including the urgency bonus
Contributor+: @s77rt paid $1500 via Upwork, including the urgency bonus.


⚠ Samsung has degraded performance

In 8452032, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2862 ms

Resolved: Samsung performance has improved in 478b5cd.


Wrong Maven Url

Please use the release version of the Maven repo, not development. Development is always the latest builds off of master, whereas release is the official version shipped with the plugins. The correct url is http://first.wpi.edu/FRC/roborio/maven/release.

On my last check the 'release' maven was missing some artifacts (networktables ARM iirc). Has this been resolved?

They're all there. The artifacts are copied from our build server to the web-accessible repo, so you might have checked before they were fully finished copying.

If you do notice something missing, please let me know.

Okay, sounds good to me. Will merge :+1:


Why not automatically place host and device markings to functions?

Something like is done in hipSYCL where all functions called from a kernel are automatically marked as __host__ and __device__ if they do not have any of these markings. It could be more refined and mark an unmarked function as __device__ if it is used only in kernels and __host__ __device__ if it is used both in kernels and host. Or maybe also mark functions based on which type of functions it is calling (for example a function which calls a function already marked as __device__ will also get __device__ marking)?
Is there some technical problem why this would not be a good idea?
(Maybe also kernels could be automatically marked as __global__ based on whether the function is dispatched as kernel or not.)

@yxsamliu But AdaptiveCpp (former hipSYCL) does it through their clang plugin.

@yxsamliu But AdaptiveCpp (former hipSYCL) seems to be able to do it with their clang plugin.

It probably won't work for general cases.

It probably won't work for general cases.

For example?

@misos1, thanks for reaching out and sorry for the lack of follow-ups. Based on their docs, seems like AdaptiveCpp does not have it nailed either. Initially parsing everything as __host__ __device__ doesn't sounds like the best idea, especially for something like HIP. Moreover, one key design consideration of HIP is for easy interop with CUDA code, so changing the syntax for how __host__ and __device__ work is likely not going to happen unless CUDA somehow also agrees to change the syntax on their side as well.
It is a cool concept and would be great if it can be implemented, but due to the reasons above we are unlikely to implement this any time soon, if ever to be frank.
I will be closing this issue for now, but please feel free to ask follow up questions. Thanks!


List of External databases used in Chado (standardization of database prefixes)

In this list we have
ChEBI/CHEBI
PomBse
PubMed/PMID
Rfam/RFAM
TAIT possibly TAIR?
Uniprot/UniProKB/ UniProtKB/Swiss-Prot
url/URL
Need to

Identify correct ones
Identify where errors are coming from
Fix
Implement checks to prevent incorrect Ids (dbxrefs list = PomBase specific/inhouse?)

Original comment by: ValWood

Is this ticket still valid now?

There are lots of DBs in Chado that don't come from PomBase annotation because we load lots of OBO files and external GAF files.  It's going to difficult to fix all the odd DB names that come from the sources.

They should all conform to the GO db xrefs?
Can discuss tomorrow, and decide if we need to do anything.

They should all conform to the GO db xrefs?

It looks like there are a lot of cases where no checking is done.  The dbxrefs in the term definition ("def:") lines in OBO files are all over the place and often don't match anything in GO.xrf_abbs

seems to overlap with
https://github.com/pombase/pombase-chado/issues/614

This is a very long ticket, and I'm not sure it is still required. I think it is covered by
#614 which  involved standardization of  database prefixes and is now close.
I'll close this. If anything buried in this ticket is still required please open new.
I'll have a poke around for any specific oddities  outstanding and open tickets to address those.

and
https://github.com/pombase/pombase-chado/issues/227


Test Failure - test-rules: Assertion failed: status == SIGALRM (tests/test-rules.c: test_process_scan: 3524)

Describe the bug
The test-rules test fails.
test-rules.log:
--- PASS 1 ---
Assertion failed: status == SIGALRM (tests/test-rules.c: test_process_scan: 3524)
Aborted
FAIL test-rules (exit status: 134)
test-rules.log lines 1-4/4 (END)

Which points to this line. https://github.com/VirusTotal/yara/blob/8fa55cde4c0cde8a1ba4ced1c131827eb4005f0d/tests/test-rules.c#L3524
To Reproduce
make check

Expected behavior
Tests should pass.
Please complete the following information:

OS: Gentoo
YARA version: https://github.com/VirusTotal/yara/commit/8fa55cde4c0cde8a1ba4ced1c131827eb4005f0d

Additional context
Occurs on both my glibc and musl systems and with --without-crypto.
test-rules.trs:
:test-result: FAIL
:global-test-result: FAIL
:recheck: yes
:copy-in-global-log: yes

On FreeBSD I have similare test failures,  this is with version 4.5.0:
Assertion failed: (status == SIGALRM), function test_process_scan, file tests/test-rules.c, line 3551.
And after commenting it out:
Assertion failed: (status == SIGALRM), function test_process_scan, file tests/test-rules.c, line 3572.


Updated management API update

@Antvgski : Thanks for your contribution! The author, @kevinvngo, has been notified to review your proposed change.

#sign-off

@julieMSFT: I'm sorry - only the author of this article, @kevinvngo, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@Jak-MS : Thanks for your contribution! The author, @kevinvngo, has been notified to review your proposed change.

@Antvgski - we'll go ahead and merge this, but it's pretty long for a change come through the public repository.
In the future, please note that Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.
Thanks.


Copyright 2016

In the "Licensing" pane, only 2015 is mentioned in the license.
Copyright 2015 OpenBazaar Developers

What about 2016?

fixed


Wrong unrolling of loop iteration

julia> function pow(x, n)
                r = 1
                while n > 0
                    n -= 1
                    r *= x
                end
                return r
           end
pow (generic function with 1 method)

julia> val, tape = trace(pow,2,4)
(16, Tape{Umlaut.BaseCtx}
  inp %1::typeof(pow)
  inp %2::Int64
  inp %3::Int64
  const %4 = 1::Int64
  %5 = >(%3, 0)::Bool
  %6 = -(%3, 1)::Int64
  %7 = *(%4, %2)::Int64
  %8 = >(%6, 0)::Bool
  %9 = -(%6, 1)::Int64
  %10 = *(%7, %2)::Int64
  %11 = >(%9, 0)::Bool
  %12 = -(%9, 1)::Int64
  %13 = *(%10, %2)::Int64
  %14 = >(%12, 0)::Bool
  %15 = -(%12, 1)::Int64
  %16 = *(%13, %2)::Int64
  %17 = >(%15, 0)::Bool
)

Here the IR is for n=4 while it should contain a loop dependent on n. Correct me if this is expected... Thanks!

Another unrelated question: would it be possible/in your interest/acceptable if I did it to expose handle_gotoifnot_node! to contextual rewriting?

Oh I'm sorry I missed the part where it says control flow tracing is not implemented 😆


Any better way to handle time for linestring in geojson files?

At the moment I figured out, we can add time as a property for point and polygons. Works great but for line strings we need to add times as many times as coordinates or else just the last point is displayed. This is cumbersome. Does anyone have a different approach?
Point Sample
   "type":"FeatureCollection",
   "crs":{
      "type":"name",
      "properties":{
         "name":"urn:ogc:def:crs:OGC:1.3:CRS84"
      }
   },
   "features":[
      {
         "type":"Feature",
         "properties":{
            "ID":1,
            "Category":null,
            "Type":"Test",
            "Date":"20180101000000",
            "time":"2015-03-08T00:00:00.000Z"
         }
      }
   ]
}

Linestring Sample
   "type":"FeatureCollection",
   "crs":{
      "type":"name",
      "properties":{
         "name":"urn:ogc:def:crs:OGC:1.3:CRS84"
      }
   },
   "features":[
      {
         "type":"Feature",
         "properties":{
            "ID":1,
            "Category":null,
            "Type":"Bike",
            "Date":"20181201000000",
            "time":"2017-09-08T00:00:00.000Z",
            "times":[
               "2017-03-08T00:00:00.000Z",
               "2018-03-08T00:00:00.000Z",
               "2019-03-08T00:00:00.000Z",
               "2020-03-08T00:00:00.000Z",
               "2021-03-08T00:00:00.000Z",
               "2022-03-08T00:00:00.000Z",
               "2022-03-08T00:00:00.000Z",
               "2022-03-08T00:00:00.000Z",
               "2022-03-08T00:00:00.000Z",
               "2022-03-08T00:00:00.000Z",
               "2022-03-08T00:00:00.000Z",
               "2019-03-08T00:00:00.000Z",
               "2020-03-08T00:00:00.000Z",
               "2020-04-08T00:00:00.000Z",
               "2020-06-08T00:00:00.000Z",
               "2022-9-08T00:00:00.000Z",
               "2022-03-08T00:00:00.000Z",
               "2022-03-08T00:00:00.000Z",
               "2022-03-08T00:00:00.000Z"
            ]
         },
         "geometry":{
            "type":"LineString",
            "coordinates":[
               [
<PHONE_NUMBER>9854402,
                  -37.900577963091273
               ],
               [
<PHONE_NUMBER>6949803,
                  -37.900442408518742
               ],
               [
<PHONE_NUMBER>9717303,
                  -37.900365586305668
               ],
               [
<PHONE_NUMBER>2853602,
                  -37.900303624206259
               ],
               [
<PHONE_NUMBER>5611304,
                  -37.900240128116373
               ],
               [
<PHONE_NUMBER>6753902,
                  -37.900183918893688
               ],
               [
<PHONE_NUMBER>8427402,
                  -37.90013647945878
               ],
               [
<PHONE_NUMBER>0724803,
                  -37.900103552184376
               ],
               [
<PHONE_NUMBER>4621902,
                  -37.900062765214692
               ],
               [
<PHONE_NUMBER>6021803,
                  -37.900032461346385
               ],
               [
<PHONE_NUMBER>8573804,
                  -37.8999824054616
               ],
               [
<PHONE_NUMBER>7229104,
                  -37.899951376409859
               ],
               [
<PHONE_NUMBER>1577102,
                  -37.89989803638057
               ],
               [
<PHONE_NUMBER>6349104,
                  -37.899865072139342
               ],
               [
<PHONE_NUMBER>1145203,
                  -37.89982319766478
               ],
               [
<PHONE_NUMBER>3259702,
                  -37.89946918323816
               ],
               [
<PHONE_NUMBER>1228403,
                  -37.899210914901786
               ],
               [
<PHONE_NUMBER>1296702,
                  -37.89899193259587
               ],
               [
<PHONE_NUMBER>3213405,
                  -37.898545654643044
               ]
            ]
         }
      }
   ]
}

Hi @rainitesh,
the library will search for the time information inside the properties of the feature, searching these properties: coordTimes, times, linestringTimestamps and time (in this order). All these properties should be arrays of dates. Except time, which must be a date.
In the case of a LineString, the library creates a new LineString taking only those coordinates that matches with the active times (depending on the current time, the duration parameter, etc).

Hello @bielfrontera,
So there is no other way than creating array of dates. These array of dates have to be within the given "date" or can it be past the "date" attribute?
At the moment, we pretty much have date for each feature and some line strings are massive. Is there any better/automated approach to create these arrays dynamically for each feature? I am doing it manually for now which leads to multiple errors.
Thanks.

I recommend you to automatize the generation of your GeoJSON. You have to be able to identify each coordinate of the trajectory (the linestring) with a date. And add to the feature a property with this array of dates.
But if you have only one date for the whole trajectory, you can add the property time (not an array).

Yes I just have one date for each linestrings. I did want to avoid the generation of time arrays.
When I just added the time property it did not plot anything. It just plots the last point in the line. Am I missing something here.
Thanks for the help @bielfrontera

This is what I am doing
$.getJSON("data/bikes.geojson",function(bikeData){
        var bikeMap = L.geoJson( bikeData,{
            style: bikeStyle
        });

        window.bikeLayer = L.timeDimension.layer.geoJson(bikeMap, {
            waitForReady: true
        });
    });

Geojson file sample
   "crs":{
      "type":"name",
      "properties":{
         "name":"urn:ogc:def:crs:OGC:1.3:CRS84"
      }
   },
   "features":[
      {
         "type":"Feature",
         "properties":{
            "ID":1,
            "Category":null,
            "Type":"Bike",
            "time":"2017-09-08T00:00:00.000Z"
         },
         "geometry":{
            "type":"LineString",
            "coordinates":[
               [
<PHONE_NUMBER>9854402,
                  -37.900577963091273
               ],
               [
<PHONE_NUMBER>6949803,
                  -37.900442408518742
               ],
               [
<PHONE_NUMBER>9717303,
                  -37.900365586305668
               ],
               [
<PHONE_NUMBER>2853602,
                  -37.900303624206259
               ]
            ]
         }
      }
   ]
}

If I add the time array it plots fine but the moment I remove them they disappear with no errors.

I've checked the code and it's not working as you expected with one time for the whole linestring. It is generating a new linestring with the first point.
But you can create a new class to override the method _getFeatureBetweenDates, and return the feature without modification if its time is active. Checkout this example
L.TimeDimension.Layer.BikeLayer = L.TimeDimension.Layer.GeoJson.extend({

    // Do not modify features. Just return the feature if it intersects
    // the time interval
    _getFeatureBetweenDates: function(feature, minTime, maxTime) {
        var featureStringTimes = this._getFeatureTimes(feature);
        if (featureStringTimes.length == 0) {
            return feature;
        }
        var featureTimes = [];
        for (var i = 0, l = featureStringTimes.length; i < l; i++) {
            var time = featureStringTimes[i]
            if (typeof time == 'string' || time instanceof String) {
                time = Date.parse(time.trim());
            }
            featureTimes.push(time);
        }

        if (featureTimes[0] > maxTime || featureTimes[l - 1] < minTime) {
            return null;
        }
        return feature;
    },

});

L.timeDimension.layer.bikeLayer = function(layer, options) {
    return new L.TimeDimension.Layer.BikeLayer(layer, options);
};

var map = L.map('map', {
    zoom: 17,
    fullscreenControl: true,
    center: [-37.9, 144.666],
    timeDimension: true,
    timeDimensionControl: true,
});

$.getJSON("data/bike.geojson",function(bikeData){
    var geojsonLayer = L.geoJson(bikeData);
    var bikeTimeLayer = L.timeDimension.layer.bikeLayer(geojsonLayer, {
        waitForReady: true,
        updateTimeDimension: true
    });
    // geojsonLayer.addTo(map);
    bikeTimeLayer.addTo(map);
});

@bielfrontera that just worked perfectly as I expected. Thanks heaps :)


Updated HTML CSS JS for cookie modal

Related issue COOKIE MODAL Was not working and learn more had nothing
Fixes:  #1531
Description
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]
New pull from your present repo was stopping the functionality of the cookie modal, so I restored functionality.
I have added content to learn more option when clicked the modal. I have also fixed the CSS formatting of the same

Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]

Checklist:

[x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

Please add the gssoc and level labels


Unable to properly detect version

CodeSonar versions: 5.0, 4.5p2
Jenkins version: 2.174
The Jenkins run successfully completes the analysis phase, but in the later step to get information to populate the warnings total graph in the Jenkins interface it fails. That is, the CodeSonar post build action is failing, not the build action.
We tracked the error produced to the file CodeSonarPublisher.java, at line 160 in the current state of your repository. So apparently you are requesting the /command/anon_info/ page from the Hub, and getting something back that does not lead to an exception, but the regex to identify the version isn't matching on anything.
We checked to make sure the page is available and produces what is expected when requested, and for both 5.0 and 4.5p2 we see pages where the regex should match. However, when we check the traffic log for the Hub we don't see the request at all from the Jenkins plugin.

Turns out it was a misconfiguration. The user has been notified about it. Implemented fix and additional checks in https://github.com/Praqma/codesonar-plugin/commit/10ef6be2b7c07d3ff3e0cba0d7c62ee60f7aa466


Arrow function body

Is there any treatment of arrow functions? I see no tests for that.

Oh, that seems to be non-trivial...
let x = ( a = () => {} ) => { a = () => {}  }


feat: handle updates to Source tileJsonSource prop more gracefully

In mapbox 1.12.0, a feature was released which allows changing the URL/tiles props on a vector source without removing it from the map. This is much more performant, especially in cases where the map undergoes several back-to-back changes to its tiles URL (after a few rapid changes, mapbox-gl starts to have issues when constantly removing/re-adding layers/sources).
In this PR, I've:

Updated dependency to mapbox-gl to be the latest (I had to make some type changes to get the build to pass, ideally these wouldn't be needed, but I'm hoping these could be resolved at a later date)
Modified the Source component to use the new setUrl and setTiles APIs when dealing with a vector source. I kept the old behaviour as a fallback, as raster tile sources for example didn't get this new feature.

When testing in a local setup with an app that does many tiles property changes, this new approach is significantly more performant.

Added an example as well, based it on the example from Mapbox, with the extension that you can switch the mirror for the tiles, which also tests the changes in this PR.
The problem I had originally is not surfaced in this demo, unfortunately, as likely the variety in the tiles URL is too small (i.e if it had query parameters that changed etc, then the problem would surface), I did manage to reproduce it by adding a random query parameter to it (something like t=Math.random()), after toggling the layer a few times, the performance of reloading the tiles after the button clicked started going down - this did not happen with the updated Source


Using pnpm install find no matching version error

Node: 16.17.0
pnpm: 6.14.7
No matching version found for @plasmohq/prettier-plugin-sort-imports@* inside the workspace

You will need to use pnpm@7 to install the dependency. This example directory cannot be used by itself, it's mainly for reference purposes.
See: https://discord.com/channels/946290204443025438/1044558522316234752
Also please see #8


application.properties syntax

I am using Kafka with spring cloud stream in docker. I am confused about application-dev.yml syntax. The documentation is quite misleading. Which one is right from below? does it make any difference? and also Eclipse shows Unknown property 'spring.cloud.stream.kafka' warning message as shown at the end of the comment.
Syntax1:
  cloud:
       stream:
           kafka:
               binder:
                   brokers: localhost
                   zk-nodes: localhost
               bindings:
                  customChannel:
                     producer:
                        destination: customChannel
                        content-type: application/json
                  subscribableChannel:
                     consumer:
                        destination: customChannel
                        startOffset: earliest
                        group: group1

Syntax2:
cloud:
     stream:
         kafka:
             binder:
                 brokers: localhost
                 zk-nodes: localhost
         bindings:
             customChannel:
                producer:
                   destination: customChannel
                   content-type: application/json
             subscribableChannel:
                consumer:
                   destination: customChannel
                   startOffset: earliest
                   group: group1

application-dev.yml
# ===================================================================
# Spring Boot configuration for the "dev" profile.
#
# This configuration overrides the application.yml file.
#
# More information on profiles: http://www.jhipster.tech/profiles/
# More information on configuration properties: http://www.jhipster.tech/common-application-properties/
# ===================================================================

# ===================================================================
# Standard Spring Boot properties.
# Full reference is available at:
# http://docs.spring.io/spring-boot/docs/current/reference/html/common-application-properties.html
# ===================================================================

logging:
    level:
        ROOT: DEBUG
        com.chargecodes: DEBUG
        io.github.jhipster: DEBUG

eureka:
    instance:
        prefer-ip-address: true
    client:
        service-url:
            defaultZone: http://admin:${jhipster.registry.password}@localhost:8761/eureka/

spring:
    profiles:
        active: dev
        include: swagger
    devtools:
        restart:
            enabled: true
        livereload:
            enabled: false # we use gulp + BrowserSync for livereload
    jackson:
        serialization.indent_output: true
    cloud:
        stream:
            kafka:
                binder:
                    brokers: localhost
                    zk-nodes: localhost
                bindings:
                   customChannel:
                      producer:
                         destination: customChannel
                         content-type: application/json
                   subscribableChannel:
                      consumer:
                         destination: customChannel
                         startOffset: earliest
                         group: group1
    datasource:
        type: com.zaxxer.hikari.HikariDataSource
        url: jdbc:mysql://localhost:3306/chargecodes?useUnicode=true&characterEncoding=utf8&useSSL=false
        username: root
        password:
        hikari:
            data-source-properties:
                cachePrepStmts: true
                prepStmtCacheSize: 250
                prepStmtCacheSqlLimit: 2048
                useServerPrepStmts: true
    jpa:
        database-platform: org.hibernate.dialect.MySQL5InnoDBDialect
        database: MYSQL
        show-sql: true
        properties:
            hibernate.id.new_generator_mappings: true
            hibernate.cache.use_second_level_cache: false
            hibernate.cache.use_query_cache: false
            hibernate.generate_statistics: true
    mail:
        host: localhost
        port: 25
        username:
        password:
    messages:
        cache-seconds: 1
    thymeleaf:
        cache: false
    zipkin: # Use the "zipkin" Maven profile to have the Spring Cloud Zipkin dependencies
        base-url: http://localhost:9411
        enabled: false
        locator:
            discovery:
                enabled: true

liquibase:
    contexts: dev

# ===================================================================
# To enable SSL, generate a certificate using:
# keytool -genkey -alias chargecodes -storetype PKCS12 -keyalg RSA -keysize 2048 -keystore keystore.p12 -validity 3650
#
# You can also use Let's Encrypt:
# https://maximilian-boehm.com/hp2121/Create-a-Java-Keystore-JKS-from-Let-s-Encrypt-Certificates.htm
#
# Then, modify the server.ssl properties so your "server" configuration looks like:
#
# server:
#    port: 8443
#    ssl:
#        key-store: keystore.p12
#        key-store-password: <your-password>
#        key-store-type: PKCS12
#        key-alias: chargecodes
# ===================================================================
server:
    port: 8081

# ===================================================================
# JHipster specific properties
#
# Full reference is available at: http://www.jhipster.tech/common-application-properties/
# ===================================================================

jhipster:
    http:
        version: V_1_1 # To use HTTP/2 you will need SSL support (see above the "server.ssl" configuration)
    # CORS is disabled by default on microservices, as you should access them through a gateway.
    # If you want to enable it, please uncomment the configuration below.
    # cors:
        # allowed-origins: "*"
        # allowed-methods: "*"
        # allowed-headers: "*"
        # exposed-headers: "Authorization,Link,X-Total-Count"
        # allow-credentials: true
        # max-age: 1800
    security:
        authentication:
            jwt:
                secret: my-secret-token-to-change-in-production
                # Token is valid 24 hours
                token-validity-in-seconds: 86400
                token-validity-in-seconds-for-remember-me: 2592000
    mail: # specific JHipster mail property, for standard properties see MailProperties
        from: chargecodes@localhost
        base-url: http://<IP_ADDRESS>:8081
    metrics: # DropWizard Metrics configuration, used by MetricsConfiguration
        jmx.enabled: true
        graphite: # Use the "graphite" Maven profile to have the Graphite dependencies
            enabled: false
            host: localhost
            port: 2003
            prefix: chargecodes
        prometheus: # Use the "prometheus" Maven profile to have the Prometheus dependencies
            enabled: false
            endpoint: /prometheusMetrics
        logs: # Reports Dropwizard metrics in the logs
            enabled: false
            report-frequency: 60 # in seconds
    logging:
        logstash: # Forward logs to logstash over a socket, used by LoggingConfiguration
            enabled: false
            host: localhost
            port: 5000
            queue-size: 512
        spectator-metrics: # Reports Spectator Circuit Breaker metrics in the logs
            enabled: false
            # edit spring.metrics.export.delay-millis to set report frequency

# ===================================================================
# Application specific properties
# Add your own application properties here, see the ApplicationProperties class
# to have type-safe configuration, like in the JHipsterProperties above
#
# More documentation is available at:
# http://www.jhipster.tech/common-application-properties/
# ===================================================================

application:

@pavankjadda the syntax2 is the correct one above. Bindings are applied at the spring.cloud.stream level (spring.cloud.stream.bindings.<BindingName>.*) and any binder specific properties are provided at the corresponding binder level (as in  spring.cloud.stream.kafka.binder). I am not sure, why your IDE is not recognizing the property prefix.


ERROR Colab

Hello Guys, before I could run in Colab but now they are giving the following errors.
could you help me please?
update-alternatives: using /usr/bin/python3.10 to provide /usr/bin/python3 (python3) in auto mode Connecting to Google Drive... Mounted at /content/drive Installing Sports2D in Google Drive... Collecting Sports2D Downloading sports2d-0.2.5-py3-none-any.whl (2.6 MB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.6/2.6 MB 10.8 MB/s eta 0:00:00 Requirement already satisfied: ipython in /usr/local/lib/python3.10/dist-packages (from Sports2D) (7.34.0) Requirement already satisfied: toml in /usr/local/lib/python3.10/dist-packages (from Sports2D) (0.10.2) Requirement already satisfied: numpy in /usr/local/lib/python3.10/dist-packages (from Sports2D) (1.23.5) Requirement already satisfied: pandas>=1.5 in /usr/local/lib/python3.10/dist-packages (from Sports2D) (1.5.3) Requirement already satisfied: scipy in /usr/local/lib/python3.10/dist-packages (from Sports2D) (1.10.1) Collecting anytree (from Sports2D) Downloading anytree-2.9.0-py3-none-any.whl (38 kB) Requirement already satisfied: opencv-python in /usr/local/lib/python3.10/dist-packages (from Sports2D) (<IP_ADDRESS>) Collecting mediapipe (from Sports2D) Downloading mediapipe-0.10.3-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (33.5 MB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 33.5/33.5 MB 39.3 MB/s eta 0:00:00 Requirement already satisfied: matplotlib in /usr/local/lib/python3.10/dist-packages (from Sports2D) (3.7.1) Collecting PyQt5 (from Sports2D) Downloading PyQt5-5.15.9-cp37-abi3-manylinux_2_17_x86_64.whl (8.4 MB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 8.4/8.4 MB 82.6 MB/s eta 0:00:00 Requirement already satisfied: statsmodels in /usr/local/lib/python3.10/dist-packages (from Sports2D) (0.14.0) Requirement already satisfied: python-dateutil>=2.8.1 in /usr/local/lib/python3.10/dist-packages (from pandas>=1.5->Sports2D) (2.8.2) Requirement already satisfied: pytz>=2020.1 in /usr/local/lib/python3.10/dist-packages (from pandas>=1.5->Sports2D) (2023.3) Requirement already satisfied: six in /usr/local/lib/python3.10/dist-packages (from anytree->Sports2D) (1.16.0) Requirement already satisfied

Hi there,
Yes I noticed that... It is due to the fact that Colab upgraded their Ubuntu version to 22.04, and OpenPose doesn't compile right anymore.
There is an ongoing conversation about it here:
https://github.com/CMU-Perceptual-Computing-Lab/openpose/issues/1736#issuecomment-1652507856
Unfortunately, I won't have time to spend on it these days... If you have anyone who can help you in your team that is at ease with compilation, that may be solved relatively quickly! In that case I'm interested in your feedback so that I can implement the correction :)

Hi @GUIARRUDA84 ,
(very) long story short, the colab version should be up now! Don't hesitate to tell me if you face any issues.
I'm closing this for now but if you experience any problem please reopen the issue.


bugfix: fixes  #448

Fixes issue #448 (Trie.mergeDisjoint can produce broken tries)

actually forces a trap when Trie.mergeDisjoint tries to merge maps with non disjoint domains (as claimed in the doc).

Unfortunately, the test harness isn't set up to test for traps, but you manually verify it by running (in dir test)

[nix-shell:~/motoko-base/test]$ moc -c --package base ../src -wasi-system-api traps/issue-448.mo

[nix-shell:~/motoko-base/test]$ wasmtime run --disable-cache issue-448.wasm
Trie.mergeDisjoint
Error: failed to run main module `issue-448.wasm`

Caused by:
    0: failed to invoke command default
    1: wasm trap: wasm `unreachable` instruction executed
       wasm backtrace:
           0: 0x1634 - <unknown>!trap
           1: 0x1618 - <unknown>!anon-func-576.15
           2: 0x1c73 - <unknown>!rec2
           3: 0x1d62 - <unknown>!rec1
           4: 0x1586 - <unknown>!disj
           5: 0x1732 - <unknown>!rec
           6:  0x5eb - <unknown>!mergeDisjoint
           7:  0x57e - <unknown>!init
           8: 0x1f84 - <unknown>!_start

Would be curious to know how much more expensive this "safer" version is over the earlier version that assumed, but did not check, for disjoint arguments.  But that's just another curiosity.
LGTM.

Would be curious to know how much more expensive this "safer" version is over the earlier version that assumed, but did not check, for disjoint arguments. But that's just another curiosity.

No idea, but producing a broken trie seems dangerous to me. Correctness first, then perf, I'd say.


Fix: logic error in gdscript_parser.cpp for-loop-range

Done. and thanks for the review
@vnen

Thanks!

Cherry-picked for 3.2.2.


arc: print human-readable exception info

Right now only numerical values are printed which must
be looked up in the Designware ARCv2 ISA Programmer's
Reference, which is not easily obtainable without
registration.
Add a non-default Kconfig to print more information at
the expense of footprint, and enable it for all the simulator
targets.
We only print code/parameter details for machine check and
protection violations, more may be added later as desired.
This should cover all the exceptions we commonly encounter
for memory protection.
Signed-off-by: Andrew Boie<EMAIL_ADDRESS>

@ruuddw thanks for reviewing.

Privilege exceptions have additional cause/parameter fields as well, these could be added as well.

Done.


Found a typo in the docs

Queueing a Series of State Updates it should Queuing a Series of State Updates this same typo is present at 3 places in the docs

https://github.com/reactjs/react.dev/pull/6278#issuecomment-1706644435


should the library control the Write Protect pin?

It would add five (simple) functions to the class

void setWriteProtectPin(uint8_t pin)  set pinMode(_wpPin, OUTPUT) + defaults enable write ?
uint8_t getWriteProtectPin() returns _wpPin
uint8_t enableWrite() digitalWrite(_wpPin, LOW);
uint8_t disableWrite() digitalWrite(_wpPin, HIGH);
uint8_t isEnabledWrite() return (digitalRead(_wpPin) == LOW);

These 5 functions can be kept disjunct from the existing class. so if not used no code increment.
If merged into e.g. writeBlock() - checking isEnabledWrite() - it would always add to the footprint.
integration could also be in begin(), default pin -1?
(constructor would interfere with default Wire parameter)
low prio

As many devices have a WriteProtect or enable pin this could be a minimal class.
Other classes could inherit this WriteProtect class.
As naming + function and polarity etc differ it looks like overkill to "classify" this idea.

Note the writeProtectPin could also be controlled by a 595 shift register or a PCF8574.
Note: most EEPROMs are used as always writeable (assumption) so no control needed.

https://github.com/RobTillaart/AnalogUVSensor
Has functions to control the power pin, is a bit similar.

void setPowerPin(uint8_t powerPin, bool invert = false)
void switchOff()
void switchOn()

If the pin is not set there is a possible ambiguity. One does not know if the WP is GND or VCC.
So best strategy is to assume write enabled and let the hardware decide.
uint8_t isEnabledWrite()
{
  if (_wpPin == -1) return true;    //   in fact unknown
  return (digitalRead(_wpPin) == LOW);
}

test needed if footprint increases

not used not integrated
not used integrated

test code
  //  WRITE PROTECT PIN experimental
  void    setWriteProtectPin(uint8_t pin) { _wpPin = pin; };
  uint8_t getWriteProtectPin() { return _wpPin; };
  void    enableWrite()  { digitalWrite(_wpPin, LOW); };
  void    disableWrite() { digitalWrite(_wpPin, HIGH); };
  bool    isEnabledWrite()
  {
    // if (_wpPin == 255) return true;
    return (digitalRead(_wpPin) == LOW);
  };

  uint8_t _wpPin = 255;

observations

not using the code adds 1 byte RAM for _wpPin + 4 bytes for the assignment = 255;
call added ee.isEnabledWrite() adds a 100 - 120  bytes footprint.  (depending on adding the test for _wpPin == -1 )
ee.isEnabledWrite() does not sound good in code =>  ee.isWriteEnabled()
it would be great if EEPROMS would have a register to see the status of the chips own WP pin

Conclusions
The addition of the write protect pin logic would add a performance gain in the write and update functions as it can be easily checked if the EEPROM is write protected.
However the logic to add is very simple, one might ask if it should be in the library when a user can easily add it.
Mind you,  it would add to the footprint of the library also for all the users that would not use it.
Also it expands the width of the interface.
soft write enabled ?
An even simpler way might be a software only write enable flag.
  //  SOFT WRITE PROTECT PIN experimental
  void    enableWrite()  { _writeEnabled = true; };
  void    disableWrite() { _writeEnabled = false; };
  bool    isWriteEnabled() { return _writeEnabled; };

  bool    _writeEnabled = true;

This only works if integrated in the write /set / update functions, and it would add only very small tests.
Functionally it would prevent writing although not backed by hardware.
The question is if the default should be true or false?
For now the answer is true as that will not break the current behavior.

test software write disable

adds 42 bytes on an UNO to test the 5 above functions.
substantial less than the hardware controlled

conclusion (for now)
The functionality to prevent writing by implementing a write protect mechanism will not be added.
The same argument holds here:
.., the logic to add is very simple, one might ask if it should be in the library when a user can easily add it.


Not receive my all coins

Hello @Anvarkp
You're experiencing transcript error. It sounds like your query would be best dealt with by the support team.
I'll have to refer you to the official support live chat with the ticket ID TON07638
Please see the link below to our dedicated support line:
Tonkeeper Network DApps Support Ticket Requests.
Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent.


Refactor Pending Transactions

Currently, the management of a pending tx is spread all over the codebase.
There are parts of it in createTransactions, processTransaction, and other logic spread in other places for the Owners, and so on.
Maybe, by creating a service to centralize this whole pending state would be a good starting point to decouple a bit more the app.

duplicated by #1342, but I'm closing it as the other has reference to a discussion around the topic.


Fix dropdown field wrapper

Removed the input decoration implementation in the wrapper and just passed decoration to the drop-down widget, so it handles all the decoration and spacing

This will allow us to let the inkwell ripple effect expand to the edges of the fields, as it supposed to

@joanpablo, Anything I can do so you can merge?

Hi @mohn93 sorry the delay but the PR is not building correctly there are some issues. Could you fix those issues first? Thanks

@joanpablo, Could you check now, please?

It looks like we had a regression on testing coverage. Doesn't it?

@joanpablo, Sorry, Can you check now?

@joanpablo , Sorry, Can you check now?

Hi @mohn93 seams like 1 file is failing because a formatting error.

@joanpablo , May I ask what the error is exactly?

The file test/src/widgets/reactive_dropdown_field_test.dart does not comply with formating rules for a flutter dart file.

@joanpablo Pushed

@joanpablo  Please check


Separate platform specific config options

We should add linux and windows section, and put platform specific config into those sections.
Example options that don't make sense to Windows:

disable_cgroup
disable_apparmor
restrict_oom_score_adj
...

Instead of having the entire default config in config_unix.go and config_windows.go, let's clean this up and only have different parts in them.

Sounds good. I just removed them from the containerd.toml so the toml file looks clean anyways. But this is better e2e


256 customize the modus controls colors

Implemented a custom theme to support both light and dark modes
If the user wants to use light theme color codes for dark theme that options also added

@Sofiya-kumar Good to merge?


Use ReadTheDocs theme for documentation

Instead of hosting the Dropwizard documentation on GitHub pages and having to update the gh-pages branch (semi-) manually after each release, we can use https://readthedocs.org/ which will take care of building the documentation and serving it in multiple versions.
While the original Dropwizard theme could be used on ReadTheDocs, the official RTD theme providers some features which we would have to add to the original theme, such as:

Search function
Version selection
Automatic sitemap generation

Preview: https://dropwizard.readthedocs.io/en/rtd/
@dropwizard-committers When somebody wants to port the search bar and the version selection to Dropwizard's original theme, I'm happy to keep using it.

Overall, looks good, but one unfortunate downside I see is that the Dropwizard Configuration Reference page becomes much harder to use due to the layout being so narrow.

@pstackle I've made the theme a little bit wider to accommodate wide tables (although the configuration reference still doesn't fit).
@dropwizard-committers If you're okay with it, I'd merge this PR and release Dropwizard 2.0.0-rc1 in the next days.
The latest version of the docs created from this branch are at https://dropwizard.readthedocs.io/en/rtd/.


type-connect part 1: small stuff, generated stuff

This is a 9 part PR to improve the typing of our connected components. This has revealed some thing that were going untyped. I split it up into chunks to aid in reviewing, but only part 9 will pass flow/lint
https://github.com/keybase/client/pull/13356
https://github.com/keybase/client/pull/13357
https://github.com/keybase/client/pull/13358
https://github.com/keybase/client/pull/13359
https://github.com/keybase/client/pull/13360
https://github.com/keybase/client/pull/13361
https://github.com/keybase/client/pull/13362
https://github.com/keybase/client/pull/13363

[x] We kept 2 copies of the generated protocol js files. Now just keep the copy we keep in shared
[x] export typePrefix from generated actions. Useful to get all routeTree actions for example
[x] Remove entities/routeTree custom action creators and use json + generation instead (in prep for later parts of this PR where you can no longer dispatch non-generated actions)
[x] Moved retention policy types to their own file to avoid cycles with chat/teams
[x] Split generated rpc files into .flow and implementation files to avoid cycles with TypedState and engine / substore using RPCTypes
[x] Remove entirely stubbed out flow-typed files. It creates types for every single file in the projects which adds too much time to flow. Going back to using lib/flowinterface file instead

@keybase/react-hackers this is ready

fix flow slow merges

[ ] actions/teams
[ ] profile/proofs


Handwritten equation solver using CNN

hi @Niketkumardheeryan  can you please assign me this issue

@Sumit11081996 u can not work on 2 issues at a time..

I would like to contribute. Please assign me this project.


Speed up unit tests

- What I did
Made at_secondary_server unit tests run faster
- How I did it
Made tests use different storage directories in order to isolate them from each other
Reduced idle, ttl and ttb times in tests (and associated sleep durations in individual test cases)
Miscellaneous lint
- How to verify it
The unit tests should all still pass, but should take ~10 seconds compared with ~75 seconds previously
- Description for the changelog
Made at_secondary_server unit tests run faster

Sigh. Consistently working on local command line and in IDE. Something else is making it hang now.

I shall return to this later in the week, I've had enough yak shaving for now

Abandoning this PR, will fix up my local branch and create a new one


Add OpenBSD to the CI

Add the OpenBSD GitHub Action to the CI.

Unfortunately, we're blocked because nokogiri tries to run tar -xJvf on an .tar.xz file, but OpenBSD's tar does not support a -J option:
https://github.com/ronin-rb/scripts/actions/runs/8906296207/job/24458239963#step:3:1356
The code in question is in mini_portile2, which handles building libxml2 for the nokogiri C extensions:
https://github.com/flavorjones/mini_portile/blob/6463c42f1fd703343612211a48addc00381574f2/lib/mini_portile2/mini_portile.rb#L510-L564


[5.3][5.4]Queue:work always fails after the first job

Laravel Version: 5.3.11
PHP Version: 7.1.1-1+deb.sury.org~xenial+1
Database Driver & Version: 5.7.17
Queue Driver: Beanstalkd

Description:
Only a first job succeeds when using queue:work. Queue:listen poses no problems, as does manually starting and stopping queue:work for every single job. I've pinpointed the issue to laravel framework 5.3.11, or to be more precise: https://github.com/laravel/framework/commit/23c12765557ebc5e3c35ad024d645620f7b907d6
My situation is the following: Each job is handled by a Job class. This Job class creates a Command class which is dispatched through Laravel's command bus.
First job:

Handle on the Job class is called.
Command class is created, as well as a pipeline (Laravel's command bus) to put the command through.
Command is dispatched through the pipeline.
All is well, Job successful.

Second job

Handle on the Job class is called.
No new Command is created.
The Job class is dispatched through the command bus, instead of the lacking Command class. Resulting in fatal errors.

Steps To Reproduce:
I've simplified my classes to look like the following:
class Job implements ShouldQueue
{
  public function handle()
  {
    $command = new Command();

    Bus::pipeThrough(['stuff']);
    Bus::dispatch($command);
  }
}

class Command
{
   public function __construct()
   {
     dump("Command created");
   }
}

This should output:

"Command created"
[2017-04-02 19:16:58] Failed: App\Jobs\Job
"Command created"
[2017-04-02 19:16:58] Failed: App\Jobs\Job
"Command created"
[2017-04-02 19:16:58] Failed: App\Jobs\Job

But it doesn't, it outputs:

"Command created"
[2017-04-02 19:16:58] Failed: App\Jobs\Job
[2017-04-02 19:16:58] Failed: App\Jobs\Job
[2017-04-02 19:16:58] Failed: App\Jobs\Job

(note only one command created).
If I comment return $this->runNextJob($connectionName, $queue, $options); in framework/src/Illuminate/Queue/Worker.php:runNextJobForDaemon() it works as expected again. The comment below this line suggests it is added because of compatibilty with SQS, but now i'm experiencing issues when using Beanstalkd.

Please upgrade to 5.4 and try to replicate the issue there, 5.3 is not supported anymore.

I've reverted from Laravel 5.4 back to 5.3 because of this issue. Issue still applies. Thought it might be helpful to pinpoint were the issue started.

Opened new issue for Laravel 5.4.17 https://github.com/laravel/framework/issues/18640. Will make sure I use supported Laravel version in issue next time.


Build for macOS arm

I've made a build for arm based macOS (as there is no github runner available), based on Meshkernel 3.0.1.  🎉
Shall I upload it to the releases page? And afterwards someone can upload it to pypi?

Encountered while working on https://github.com/Deltares/HYDROLIB-core/issues/588

For future reference, building Meshkernel on macos arm requires setting unset(_CMAKE_APPLE_ARCHS_DEFAULT) in compiler_config.cmake.

Fixed by #112


Watcher improvements

This PR addresses feedback listed in https://github.com/cdr/code-server/pull/4499#issuecomment-967292556
Previously, attempting to load VS Code before the compiler all files resulted in some cryptic errors. Our file watcher now detects when VS Code has truly finished compiling and appends a file our server can check for during development.

codecov/project — 65.44% (-0.60%) compared to dd29a82

It's less than a %. I think it's okay for us to ignore this


x/net/http2: High CPU usage on light traffic

Go version
go version go1.21.6 linux/amd64
Output of go env in your module/workspace:
default
What did you do?
Stream k8s pod log using we socket using client-go library, which uses http2
What did you see happen?
High CPU usage in pipe read and mutex time on one CPU core.
pprof.kube-term.samples.cpu.001.pb.gz
What did you expect to see?
Lower CPU usage

I believe this should first be a kubernetes issue, they have a nonstandard setup with SPDY

@seankhliao Are you talking about remotecommand.NewSPDYExecutor,  but what I used is the request.Stream.  And the pprof did show golang.org/x/net/http2.transportResponseBody.Read used most of the CPU time not any of the kubernetes library.


Heroku CI fails because DATABASE_URL is set

Hi,
I just enabled Heroku CI for a project I recently created using suspenders. Unfortunately, I couldn't run the tests successfully due to the following line: abort("DATABASE_URL environment variable is set") if ENV["DATABASE_URL"] in https://github.com/thoughtbot/suspenders/blob/master/templates/rails_helper.rb#L4
It seems that the heroku-postgresql add-on is added to the Heroku CI app, causing the DATABASE_URL variable to be set. I'm not aware of any configuration changes I have made so I'm assuming the fact that this add-on is installed is a result of "normal" suspenders usage.
I'm puzzled that this hasn't been reported before as this line has been there for a while. Why shouldn't I use a DB provided by Heroku in my test environment? And why was it configured automatically anyways?
Cheers,
Johannes
PS: If nothing else comes out of this, I will propose a change to the abort message. It was very hard to spot "DATABASE_URL is set" as the error cause.

So... was this fixed? Will this be fixed? Does anyone have a workaround, or is it safe to just comment out that line? It's odd to claim this works with Heroku out of the box but make CI tests fail due to that line in the rails_helper.rb file.

I had to make a similar change on another project recently, so I've opened #979 which should help solve this. It takes the same approach as rspec-rails and what was suggested above.

It looks like this issue was already resolved by @nickcharlton so I'm closing it ❤


Throwing a Response object leads to 500 error

The thing that I am trying to implement is an authentication check for most of the routes. I imagined I could implement it roughly like this:
function checkAuth() {
  if (!isAuthenticated()) {
    throw new Response(401, {}, { message: 'Not Authenticated' });
  }
}

but it seems that throwing a response does not work as I would have expected and instead it is always resulting in an Internal Server Error.
@samselikoff do you think it would be useful to check if the thrown error is a Response instance and in that case use that instead of creating a new 500 response? if that sounds good to you I'd be happy to open a PR :)

Oh interesting. Hm. I'm guessing you know you can return a Response, but you want this just so you can short-circuit a route handler at any time?
We really need a middleware system in Mirage... this has come up a lot recently and will probably be added in the near term.

but you want this just so you can short-circuit a route handler at any time

exactly, yes

We really need a middleware system in Mirage

yeah, that would be the other potential solution for this

I think I'm a little hesitant to merge this in, because it introduces some new "magic" (exceptions in route handlers return a 500, unless they happen to throw Responses), and in general I don't like using exceptions for program logic/control flow.
I think we should eventually introduce middleware pattern to deal with this.
For now, if you wanted to reuse this logic for your route handlers, I think your best bet might be to make a HOF:
this.get('/users', withAuth((schema, request) => {
});

You might also be able to use the application serializer's serialize method to perform some checks / change the response before it goes out. But I agree we need a better story here.

yeah, the withAuth() is pretty much exactly the workaround that I'm using right now. unfortunately though prettier isn't exactly happy about it and transforms it into a multi-line statement... 😅

sucks :/
I'd be happy to prioritize middleware, or even ship it behind a feature flag so we can test it out a bit

You might also be able to use the application serializer's serialize method to perform some checks / change the response before it goes out.

I just tried this out, but it seems like the serializer isn't used at all when I throw something in the route handler. Looking at the code, the this.serialize() call is only done in the successful case, but not for the error case. 🤔


Cities not identified

I have found 2 cities which are not identified in geotext.
The cities "Ventalló" and "Sant Cugat del Vallès" exist in http://www.geonames.org but geotext is not able to find.

GeoText("Ventallo").cities
[]
GeoText("Sant Cugat del Vallés").cities
[]
GeoText("Alcalá de Henares").cities
['Alcalá de Henares']

"Ventallo" == "Ventalló"
>> False

"Sant Cugat del Vallés" == "Sant Cugat del Vallès"
>> False

Check the punctuation.

It doesn't matter if its on http://www.geonames.org/. If it's not in geotext/data, geotext will not find it.

The regex statement that geotext uses to parse capitalized/named entities from an input text does not work on city names with more than two words. So neither "Sant Cugat del Vallés" nor "Alcalá de Henares" could be found, even if they were in geotext/data.

Hope that clarifys it for you.

You are mixing 2 different languages here.
"Sant Cugat del Vallés" is in Spanish and "Sant Cugat del Vallès" is in catalan. Similar thing to Ventallo, is sometimes written without accent. In geonames all 4 cases are included.
I understood that geotext/data is an extraction from geonames, isn't it? How often are you making the update of the file?
Well, actually "Alcalá de Henares" has worked out.  Concerning your statement about more than 2 words, actually the example in teh wellcome page uses "Rio de Janeiro", having 3 words. It looks working on that one, isn't it?

I'm not mixing anything. I'm just pointing out that you have to be specific about what you're looking for and what is contained within cities15000.txt file.
I'm not updating anything.
With regex101 you can check what geotext uses under the hood to identify named entities, that it then looks up in the geonames. The regex is specifically build to catch:
a) capital word like "Rio"
b) something like di, "de", du
c) another capital word like "Janeiro".

Check it yourselves by using:
import geotext
import re

text = 'I loved Rio de Janeiro and Havana'
city_regex = r"[A-ZÀ-Ú]+[a-zà-ú]+[ \-]?(?:d[a-u].)?(?:[A-ZÀ-Ú]+[a-zà-ú]+)*"
candidates = re.findall(city_regex, text)

print(candidates)
>> ['Rio de Janeiro', 'Havana']

So yes, it catches a three word city if there are two capitalized words, separated by di-da-de-du.
Now let's take this experiment further and show why regex does a job, but not a good and reliable job in this specific task to find a word in a text.
import geotext
import re

text = 'In Rio de Janeiro and Havana people love to drink rum.'
city_regex = r"[A-ZÀ-Ú]+[a-zà-ú]+[ \-]?(?:d[a-u].)?(?:[A-ZÀ-Ú]+[a-zà-ú]+)*"
candidates = re.findall(city_regex, text)

print(candidates)
>> ['In Rio', 'Janeiro ', 'Havana ']

Now the regex statement does not catch Rio de Janeiro, because Rio is already associated to "In".
Hope I made myself a little more clear.

Ok, now I understood what you mean with more than two words, I would rephrase it like "2 words excluding nexus (da-u). I found a couple of matches that the regular expression used will not be able to match.
Those "nexus" which are not "da-du" will not be detected, for example:
#French
print(GeoText("Fos sur Mer").cities)
>> []
#English (place of Shakespeare)
print(GeoText("Stratford-upon-Avon").cities)
>> ["Avon"]
#Avon is located in US

When the "nexus" and another word appear together. This might be an specific case:
text = 'Conocí a Pedro de Buenos Aires'
city_regex = r"[A-ZÀ-Ú]+[a-zà-ú]+[ \-]?(?:d[a-u].)?(?:[A-ZÀ-Ú]+[a-zà-ú]+)*"
candidates = re.findall(city_regex, text)

print(candidates)
>> ['Conocí', 'Pedro de Buenos', 'Aires']
#Right city match is Buenos Aires

I have also found something odd. Actually I should have got a match in "Sant Cugat del Vallés", if you look to the file cities15000.txt we have the following:

"3110718	Sant Cugat del Vallès	Sant Cugat del Valles	Sant Cugat,Sant Cugat del Valles,Sant Cugat del Vallès	41.46667	2.08333	P	PPLA3	ES		56	B"

So, ideally I should have a match only in the first 2 words, actually:
text = 'Sant Cugat del Vallés'
city_regex = r"[A-ZÀ-Ú]+[a-zà-ú]+[ \-]?(?:d[a-u].)?(?:[A-ZÀ-Ú]+[a-zà-ú]+)*"
candidates = re.findall(city_regex, text)

print(candidates)
>> ['Sant Cugat', 'Vallés'']
#So, the first part "Sant Cugat" is matched and it is contained inside the file

Actually, I made some testing, It looks the algorithm is later not using all the entries inside cities15000.txt. For example, for Mexico City I have been only able to match "Mexico City" and not other names I tried (did not tried all)

3530597	Mexico City	Mexico City	Cidade de Mexico,Cidade de México,Cidade do Mexico,Cidade do México,Cita du Messicu,Citta del Messico,Città del Messico,Cità dû Messicu,Cità dû Mèssicu,Ciudad Mexico,Ciudad de Mejico,Ciudad de Mexico,Ciudad de Méjico,Ciudad de México,Ciutat de Mexic,Ciutat de Mèxic,Lungsod ng Mexico,Lungsod ng

print(GeoText("Mexico City").cities)
>> ["Mexico City"]
print(GeoText("Cidade de Mexico").cities)
>> []
print(GeoText("Ciudad de Mexico").cities)
>> []

Concerning the version of the geonames (as Sant Cugat del Vallés is not included), I have downloaded from geonames the file cities15000.txt and found that, although in the website I can find "Sant Cugat del Vallés", you will not find it in the raw extracted file. So it looks the website is not providing all the data.
Quick question, I have seen that also cities down to 500 people are included and the size of the file is "just" 4 times the file of 15000. Why not using the bigger file for higher coverage? I mean, software is quite good in performance.
At the end, this piece of code is much better to what I have, just brainstorming some ideas that might improve it.

Quick question, I have seen that also cities down to 500 people are included and the size of the file is "just" 4 times the file of 15000. Why not using the bigger file for higher coverage? I mean, software is quite good in performance.

Ideally you would have the option to pass a country and/or language and geotext would pull what it needs. I also don't think that creating the index on every class initiation of Geotext is a good design decision. I would create it once and pass it along to every child of geotext. Also, as we both now pointed out, regex is not the way to go.
So there are a couple of things you would have to tackle in order to make it better, if that is even necessary/wanted in the first place.

Hi guys, thanks for the great feedback. The library is unfortunately somewhat abandoned but the good news is that after seeing that people still use it despite its many flaws I plan to give it some attention during the holidays.
These are some areas that I see can be improved based on your feedback:

Improve the regex: rule based systems have high precision but low recall compared to machine learning approaches. In general they are also more efficient and this is the motivation for the library. Still it is not clear if the current regex is a good tradeoff between simplicity / good coverage? If you have ideas on how to improve it please let me know. I plan to play with ML and see if I can come up with a better option. An alternative would be to offer to regexes, with several precision / recall trade off and leave the user the freedom to choose depending on which one works better for their use case.

Hi @elyase!
I'm not really using geotext, rather it has been one of my first favs on github and that's why I choose to help with issues that come up once in a while, even if it's just answering questions.

A rule based system such as regex is too fragile and not versatile enough. I tried to adapt the regex to cover more languages. I ended up with multiple regex statements, for multiple languages, because a single one could not fit ALL my requirements. Even then I wasn't able to catch really exotic city names, of which there are certainly a lot. So when you boil down what a user would expect when using geotext, it's that if the city-/country name is in a provided list/index/dict, it should be found within a text. It should not be left to chance whether the regex matches and the searched name is returned.

There are ML based modules out there. If people wanted to use the heavy machinery they would just use that. Tools like spaCy are easily understood, have pre-trained models for a lot of languages and are highly accurate. Geotext should stick to its roots. It should stay a very slim library with next to no dependencies.

I'm all for API improvements. The one you propose would already make a lot of sense. I would also add the possibility to add different datasets. So people could provide their own city lists if they choose so.

I would be happy to help. :)

The code is quite good. ML can be heavy, but might support some other users. For my specific use is not a priority.
I do agree regex might be a little big fragile, but on the other side, is quite fast. You can always combine regex with other regex and/or other approaches. Maybe mix with ML in a "high accuracy" mode? Finally you will need a bunch of examples and develop algorithms to overcome them, I can provide some in the languages I master.
I can support as well on development.
Ok for API improvements, but not a pain for me today.


Problem installing with tdlib 1.5

Designed github : https://github.com/vysheng/tdbot
I am experiencing the following error while installing, and thank you for publishing the TDLIb-compatible files:
Scanning dependencies of target telegram-bot [ 98%] Building CXX object CMakeFiles/telegram-bot.dir/main.cpp.o In file included from /root/tdbot/cliclient.hpp:20:0,                  from /root/tdbot/main.cpp:20: /root/tdbot/td/td/tl/tl_json.h:45:63: error: ‘to_json’ is not a member of ‘td::td_api’  auto lazy_to_json(JsonValueScope &jv, const T &t) -> decltype(td_api::to_json(jv, t)) {                                                                ^ /root/tdbot/td/td/tl/tl_json.h:45:63: note: suggested alternative: /root/tdbot/td/td/tl/tl_json.h:37:13: note:   ‘td::to_json’  inline void to_json(JsonValueScope &jv, const JsonVectorInt64 &vec) {              ^ /root/tdbot/td/td/tl/tl_json.h:45:63: error: ‘to_json’ is not a member of ‘td::td_api’  auto lazy_to_json(JsonValueScope &jv, const T &t) -> decltype(td_api::to_json(jv, t)) {                                                                ^ /root/tdbot/td/td/tl/tl_json.h:45:63: note: suggested alternative: /root/tdbot/td/td/tl/tl_json.h:37:13: note:   ‘td::to_json’  inline void to_json(JsonValueScope &jv, const JsonVectorInt64 &vec) {              ^ CMakeFiles/telegram-bot.dir/build.make:62: recipe for target 'CMakeFiles/telegram-bot.dir/main.cpp.o' failed make[3]: *** [CMakeFiles/telegram-bot.dir/main.cpp.o] Error 1 CMakeFiles/Makefile2:74: recipe for target 'CMakeFiles/telegram-bot.dir/all' failed make[2]: *** [CMakeFiles/telegram-bot.dir/all] Error 2 CMakeFiles/Makefile2:86: recipe for target 'CMakeFiles/telegram-bot.dir/rule' failed make[1]: *** [CMakeFiles/telegram-bot.dir/rule] Error 2 Makefile:162: recipe for target 'telegram-bot' failed make: *** [telegram-bot] Error 2

See https://github.com/tdlib/td/issues/712#issuecomment-536477650.


Instructions for TCP/UDP test in section 3.1.3 not clear

The current instructions don't make a distinction between the input/output on the command line on one side and the instruction/explanation on the other. Maybe like this ...

Test of TCP-connection
After you issue the nc command below, you can enter an arbitrary text on the console. Once you hit Return, the text will be echoed back by the TCP-interface on the cloudFPGA and displayed. You can repeat this several times and end the test with CTRL-C
    $ nc <role_ip> 8803
    Hello Kale
    Hello Kale
    ^C

@zrlhle , thanks for assessing the quickstart flow. Some instructions have been added and/or modified with the general idea being to walk the user through the essential steps without going into many details and explanations, but focusing on the workflow.

Looks good now, thank you, closing
(Detail: may want to replace "Ctlr" with "Ctrl")