[Bug] Add a error message for unauthorized user

Describe the bug
When I try to generate Fern Docs for an organization I'm not part of, I get the error message Failed to publish docs.
$ fern generate --docs --preview
[docs]: ✓ All checks passed
[docs]: Failed to publish docs.
┌─
│ x  your-organization.docs.buildwithfern.com
└─

The user needs to add fern generate --docs --preview --log-level debug in order to learn that it is a 403 and they are not a member of the organization:
ERROR 2024-01-18T01:30:19.948Z [docs]: Failed to publish docs.
DEBUG 2024-01-18T01:30:19.949Z [docs]: Error: {"content":{"reason":"non-json","statusCode":403,"rawBody":"Forbidden"}}

Suggestion
Message:
This user is not authorized to edit this organization's docs. If there's already an organization, please reach out to<EMAIL_ADDRESS>if you would like to be added to your organization. If there isn't an organization yet, please run fern generate which will create one for you (even if that command throws an error.)
^wow we gotta do better than that

I feel like the CLI is playing a prank on me.
$ fern generate --docs

Failed to create organization: your-organization

$ fern generate --docs --log-level debug

DEBUG 2024-01-18T01:50:01.971Z Running fern<EMAIL_ADDRESS>ERROR 2024-01-18T01:50:08.679Z Failed to create organization: your-organization
DEBUG 2024-01-18T01:50:08.680Z Error: {"content":{"reason":"unknown","errorMessage":"getaddrinfo ENOTFOUND venus.buildwithfern.com"}}

closing to track in linear


Inference Speed data

Hi @JUGGHM, Thank you all for your great work with MMDE.
I would like to know if you have some inference time or speed data available on any GPUs or some benchmarks related to that.
Best Regards
Aman

We have posted it in the supplementary materials. (On an a100 gpu.)


Accordion 1

📥 Proposed changes
Start cleanup of code from hackathon: Refactor scss files and use more accessible elements for the react component.
☑ Submission checklist

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[x] yarn build works locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

💬 Further comments
More work is needed on this

@all-contributors add @piofinn for code


Redundant useEffect Dependency in Header Component

The Header component has redundant useEffect blocks that both fetch userInfo from localStorage and dispatch the setUserInfo action. This results in multiple dispatches of setUserInfo whenever the auth state changes, potentially causing unintended updates to the auth state.
Solution:
Remove the useEffect that has auth as a dependency, keeping only the one that runs on the initial mount to load userInfo from localStorage.

@Amansingh0807 Actually the header should re-render on on the auth change (such as login and logout)  as well that's why I added the effect with dependency. Also sometimes the users directly visit a URL or reload the URL  in such cases also the the effect should run and header should re-render.

Actually the header should re-render on on the auth change (such as login and logout) as well that's why I added the effect with dependency. Also sometimes the users directly visit a URL or reload the URL in such cases also the the effect should run and header should re-render.

Thank you for the clarification! I now understand the purpose of having the auth as a dependency in the useEffect. It ensures the header re-renders appropriately on login, logout, and page reload, which is crucial for keeping the UI in sync. I'll revise my PR accordingly. Thank you for your feedback!


Event module redesign

We plan to redesign the event module slightly for better alignment with the new Play portal.

A redesign has been made as part of 3.x releases.


⚠ Empornium has degraded performance

In 5d77fe4, Empornium ($EMP) experienced degraded performance:

HTTP code: 200
Response time: 2714 ms

Resolved: Empornium performance has improved in 2ddb794.


remove unsed advertised addr for swan manager

Signed-off-by: kevin xu<EMAIL_ADDRESS>

Codecov Report

Merging #543 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
- Coverage   19.22%   19.22%   -0.01%
==========================================
  Files          28       28
  Lines        1498     1493       -5
==========================================
- Hits          288      287       -1
+ Misses       1171     1167       -4
  Partials       39       39


Share OpenAPI specification

Is your feature request related to a problem? Please describe.
My customers use Postman to test, develop their APIs. But it's difficult to use with MIE because MIE doesn't share an OpenAPI Specification. OpenAPI would help customers to test, monitor and generate client code based on Open API Specification
Describe the feature you'd like
Postman has a native integration with API Gateway based on Open API : https://blog.postman.com/aws-api-gateway-integration-postman/
Several  framework can generate client code :
https://github.com/openapitools/openapi-generator
https://github.com/zalando/connexion
https://haseebmajid.dev/blog/rest-api-openapi-flask-connexion
https://openapi.tools/
Additional context
Add any other context or screenshots about the feature request here.

Thanks for the suggestions.   This is broadly related to #501

API Gateway natively supports exporting APIs to the OpenAPI specification. From the stage configuration page in the API Gateway console, choose the Export tab and then one of the available options (Export as OpenAPI, Export as OpenAPI + API Gateway Integrations and Export as Postman) to download the OpenAPI definition.

I think this issue is resolved, but please reopen if you think it is not resolved.


Remove user param from call to reveal.html template.

As suggested in the comment, someone already did put a Turing test
there instead. The user param is no longer used.

Sent to Avi.


[load-creds-from-ec2-role]

revert the changes pushed for loading creds for the role attached to an aws ec2 instance.

@otisg I have found an issue in the current logic, reverting it to the previous state. I will further test it and create a new PR. Please merge this PR as soon as possible.


Add WYSIWYG (CKEditor) in create article page (#215)

Looks good! Thanks for working on this!

This editor is doesn't work well on mobile.  Can you check if there is some settings we can use to fix this?  Or maybe tweak some css?

@codyseibert fixed it, can you confirm?


Add Buffer_Misc model group to separate buffers

Intended to separate buffers into geometry data and animation data. #440

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Crash while opening a librairy

Description
When I open Files on two specific library

Home -> one underlying folder = C:\Users<myUser>
Images -> one underlying folder = C:\Users<myUser>\images

Steps To Reproduce
Just open Files in "images" Library
Expected behavior
Files doesn't crash.
Files Version
Version : <IP_ADDRESS> OS Version: 10.0.18363.1916
Windows Version
Windows 10 enterprise 1909 build 18363.1916
Relevant Assets
2021-11-23 14:14:45.6852|WARN|CheckForUpdatesAsync|Could not fetch updates.
System.ArgumentOutOfRangeException: L’opération a tenté d’accéder aux données en dehors de la plage active (Exception from HRESULT: 0x8000000B)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0x70
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task) + 0x38
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task) + 0x17
   at Files.Helpers.AppUpdater.<CheckForUpdatesAsync>d__2.MoveNext() + 0x268

Unfortunately that's only a warning. Could you post the full log files?
Is the crash repeatable?
When it crashes, do you get a notification asking for you to report the bug?

Thanks for your response.
The crash can be repeated every time I reproduce the given steps -> open one of the two libraries
No notification triggered, juste the main window that closes.
About the logs, here they are, but unfortunately there is nothing more in the logs...
debug.log
debug_fulltrust.log
.

Thanks for the info, would you check if the crash happens also if you do the following?

In Files settings > Files and folders, turn off "Enable individual preferences for folders"
Navigate to any directory (that does not crash) and set e.g Tiles layout mode
Navigate to one of the libraries

You're right, by setting this parameter, is works like a charm !
Thanks 👍

Glad it works, unfortunately it will use Tiles view mode in all folders :)
Just for confirmation would you try to set the layout to Details and check if the issue reappears depending on "Enable individual preferences for folders" being on or off?

Actually is does not, detailed view is still used.
I had a wired behaviour, after disable the setting, all went well (in detailed view) and after that, no matter if I enable or disable the setting, it still works just fine !
I've try it another time by :

enable the setting
create a library
try to display the librairy -> crash
disable the setting
try to display the librairy -> ok

I have to say that I don't really understand...
The tile view mode does not seems to change something.

Oh no I'm sorry, I did not refreshed my view.
My previous message is wrong, I'll let you know my test result tomorrow.
Thanks for your help.

No rush, thanks for all the testing

Hi @gave92,
Unfortunately I did not reproduce the behaviour after a switch of the parameter...
Maybe the restart of the system did change something, or the switch got it fix somehow.
Anyway, I do not have the bug anymore, thanks for you help !

I roughly followed the steps to do the Enable individual preferences for folders-dance, but I

Being on start screen
disabled the setting
navigated to "Pictures" - and this time it did not crash
navigated to C-drive
enabled the setting
navigated to "Pictures" - and this time it did also not crash 🎉

But:
If I navigate to another library, it will crash again. After this crash, navigating to "Pictures" crashes again.
It seems to me, that after a library-folder is accessed for the first time, it is cached, so the Enable individual preferences for folders-bug does not trigger.
This could mean changing this setting only applies to not previously accessed folders.

Ok my understanding is that it only crashes when a folder is in details view & grouped & system language is not english. That issue has been fixed in #7202.


Remove pointless toString

There is a constructor for BigDecimal which directly takes BigInteger. It is more efficient than printing the string and re-parsing it. It can make a slight difference in the scale that is used but the division sets the scale anyway.

Coverage remained the same at 100.0% when pulling 29aba846d553c78967a69675c9f6f301e0e7370e on Et999:remove-to-string into 85c602a1e6da825ce6edeb81cd594e03d0b1b667 on sebhoss:master.

Hey sorry for the super late reply & thanks for the PR - I've just pushed https://github.com/metio/storage-units/releases/tag/2022.10.29 which includes the exact same change.


⚠ Bofrost.at has degraded performance

In c155598, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1265 ms

Resolved: Bofrost.at performance has improved in f025498.


remove relatedTo and directSiblingOf

from Nico:
Wait, don't merge this yet - I don't see how we can ever get these back atm - boomer won't give them to us for free!

sounds like we don't want to do this


Issue with emitting signals from handlers of C# events

Godot version
4.1.beta1.mono
System information
Godot v4.1.beta1.mono - Windows 10.0.22621 - Vulkan (Forward+) - integrated Intel(R) UHD Graphics 620 () - Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz (8 Threads)
Issue description
Emitting signals from handlers of C# events does not work in Godot 4.1
My code in 4.0 was:
In _Ready()
_timeManager = new ChessMatchTimeManager();
_timeManager.PlayerSecondElapsed += HandlePlayerSecondElapsed;

	private void HandlePlayerSecondElapsed(int secondsRemaining)
	{
		EmitSignal("PlayerTimeElapsed", _boardState.Board.Turn.ToString(), secondsRemaining);
		_energyManager.HandleSecondElapsed();
	}

This produces an error:
_E 0:02:38:0692   Godot.NativeInterop.NativeFuncs.generated.cs:353 @ Godot.NativeInterop.godot_variant Godot.NativeInterop.NativeFuncs.godotsharp_method_bind_call(IntPtr , IntPtr , Godot.NativeInterop.godot_variant** , Int32 , Godot.NativeInterop.godot_variant_call_error& ): Caller thread can't call this function in this node. Use call_deferred() or call_thread_group() instead.
  <C++ Error>    Condition "!is_accessible_from_caller_thread()" is true. Returning: (ERR_INVALID_PARAMETER)
  <C++ Source>   scene/main/node.cpp:3566 @ emit_signalp()
  <Stack Trace>  Godot.NativeInterop.NativeFuncs.generated.cs:353 @ Godot.NativeInterop.godot_variant Godot.NativeInterop.NativeFuncs.godotsharp_method_bind_call(IntPtr , IntPtr , Godot.NativeInterop.godot_variant** , Int32 , Godot.NativeInterop.godot_variant_call_error& )
                 NativeCalls.cs:6058 @ Int32 Godot.NativeCalls.godot_icall_2_676(IntPtr , IntPtr , Godot.NativeInterop.godot_string_name , Godot.Variant[] )
                 GodotObject.cs:563 @ Godot.Error Godot.GodotObject.EmitSignal(Godot.StringName , Godot.Variant[] )
                 ChessMatchSimulation.cs:224 @ void ChessMatchSimulation.HandlePlayerSecondElapsed(Int32 )
                 ChessMatchTimeManager.cs:144 @ void ChessSimulation.src.match.ChessMatchTimeManager+<>c__DisplayClass36_0+<<Start>b__0>d.MoveNext()
                 :0 @ void System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext , System.Threading.ContextCallback , System.Object )
                 :0 @ void System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1.MoveNext(System.Threading.Thread )
                 :0 @ void System.Threading.PeriodicTimer+State.Signal(Boolean , System.Threading.CancellationToken )
                 :0 @ void System.Threading.PeriodicTimer+<>c.<.ctor>b__2_0(System.Object )
                 :0 @ void System.Threading.TimerQueueTimer.Fire(Boolean )
                 :0 @ void System.Threading.TimerQueue.FireNextTimers()
                 :0 @ Boolean System.Threading.ThreadPoolWorkQueue.Dispatch()
                 :0 @ void System.Threading.PortableThreadPool+WorkerThread.WorkerThreadStart()_

Where line 224 is EmitSignal one in HandlePlayerSecondElapsed method.
I understand that there's a good chance this is the expected behaviour and just part of multi-threading improvements you are making but I want to make sure. If so, what is the preferred solution?
Steps to reproduce

Create a C# class that emits dotnet events
Handle those events in Godot Node
Try to call EmitSignal in the handler logic

Minimal reproduction project
N/A

The EmitSignal method has a thread guard which means it has to be called from the main thread:
https://github.com/godotengine/godot/blob/0aad5eb1cff831fce1263bf59144a63ecde32421/scene/main/node.cpp#L3574
As suggested by RedworkDE, using Godot's built-in timers should work. But if you want to keep using C# timers, you should be able to use CallDeferred like the error suggests. You can use GodotObject.CallDeferred or a Callable, here's an example using a Callable:
private void HandlePlayerSecondElapsed(int secondsRemaining)
{
	Callable.From(() =>
	{
		EmitSignal("PlayerTimeElapsed", _boardState.Board.Turn.ToString(), secondsRemaining);
		_energyManager.HandleSecondElapsed();
	}).CallDeferred();
}

I think I'll try the CallDeferred approach, as I want to leave the logic in the other class free of Godot dependency.
Thank you very much for the explanation and an example!

I just spent a day debugging this:
        DamageLabel.Text = $"{damage}";  // THIS WORKS

        var damageLabelTimer = new System.Timers.Timer(2000);
        damageLabelTimer.Elapsed += (sender, args) =>
        {

                DamageLabel.Text = $" " ; // THIS RESULTS IN SILENT ERROR IN EDITOR:   <C++ Error>    Condition "!is_accessible_from_caller_thread()" is true.
        };

Can someone please add some additional documentation that C# events MAY cause issues and how to fix them. I used your fix and it worked:
        var damageLabelTimer = new System.Timers.Timer(2000);
        damageLabelTimer.Elapsed += (sender, args) =>
        {
            Callable.From(() =>
                DamageLabel.Text = $" " ; // THIS WORKS
            }).CallDeferred();
        };

The error is quite sneaky, I mostly searched for bugs regarding Label control but it is not directly related to Label control at all.


core(deps): Upgrade ibc-hooks to IBC v8 and SDK v0.50.x

Hi,
When is this branch planned to be merged into main?

Still waiting for this PR to be merged. Is there any estimation on when it will be done?

@disconsolate not really.  Both @alexanderbez and I took a swing at it.

https://github.com/eve-network/eve/issues/128

Closing this in favor of PR #166 which builds off it and passed CI test. Looks to be mostly just bumps and tweaks.
Have tagged osmosis as reviewers + added a new review me label as well


History page abruptly cut?

The text in the history page appear to be abruptly cut in the middle of a sentence.
https://github.com/theupdateframework/theupdateframework.io/blob/main/content/en/docs/project/history.md

@chalin Do we have a copy of the old text here?   It looks like it may have been cut off when we switched styles?

Yes, the state of the repo before the LFX work is here: https://github.com/theupdateframework/theupdateframework.io/tree/pre-lfx-2024.
This is the page link: https://github.com/theupdateframework/theupdateframework.io/blob/pre-lfx-2024/content/history.md
I'll get to adding the missing text soon.


TimePickerThemeData's copyWith method contains fields which not used.

Steps to Reproduce
TimePickerThemeData has 'copyWith' method. And there are two arguments in it which do nothing. They are
'hourMinuteUnselectedTextColor' and 'hourMinuteUnselectedColor'.
Expected results:
These arguments should affect unselectedTextColor and unselectedColor of hourMinute sections.
Actual results:
These arguments affect nothing.

[✓] Flutter (Channel stable, 1.20.2, on Mac OS X 10.15.6 19G2021, locale en-GB)
    • Flutter version 1.20.2 at /Users/shushper/Development/Flutter/sdk/flutter
    • Framework revision bbfbf1770c (5 days ago), 2020-08-13 08:33:09 -0700
    • Engine revision 9d5b21729f
    • Dart version 2.9.1

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/shushper/Development/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_SDK_ROOT = /Users/shushper/Development/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[!] IntelliJ IDEA Community Edition (version 2019.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] Connected device (1 available)
    • Pixel 3a XL (mobile) • 95QAX0G3AH • android-arm64 • Android 10 (API 29)

Also found on latest master channel. The parameter in question are not being used anywhere:
https://github.com/flutter/flutter/blob/db705b81e3aa427bec93f8d0d20cda82e35f1212/packages/flutter/lib/src/material/time_picker_theme.dart#L207-L208

 flutter doctor -v
[✓] Flutter (Channel master, 1.21.0-10.0.pre.138, on Mac OS X 10.15.6 19G2021,
    locale en)
    • Flutter version 1.21.0-10.0.pre.138 at
      /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision 3562b3c0de (27 hours ago), 2020-08-18 01:46:02 -0400
    • Engine revision 02de4eb7ce
    • Dart version 2.10.0 (build 2.10.0-37.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 48.1.4
    • Dart plugin version 202.6397.47

[!] VS Code (version 1.48.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API
      30) (emulator)
    • macOS (desktop)         • macos         • darwin-x64     • Mac OS X
      10.15.6 19G2021
    • Web Server (web)        • web-server    • web-javascript • Flutter Tools
    • Chrome (web)            • chrome        • web-javascript • Google Chrome
      84.0.4147.135

! Doctor found issues in 3 categories.

Oops, looks like these snuck in when they weren't supposed to.
In order to provide different colors for selected/unselected states in your time picker theme, you should use a MaterialStateColor instead of a plain old Color.
I've put up https://github.com/flutter/flutter/pull/64167 to remove these arguments


Crash at PushNotifications.swift:39

We had a few crashes being reported to Crashlytics with the following stack trace:
          Crashed: com.pusher.beams.handleMessageQueue
0  redacted-app               0xdd2b74 closure #1 in PushNotifications.serverSyncHandler.getter + 39 (PushNotifications.swift:39)
1  redacted-app               0xde8e0c ServerSyncProcessHandler.processSetUserIdJob(userId:) + 306 (ServerSyncProcessHandler.swift:306)
2  redacted-app              0xde79e8 closure #1 in ServerSyncProcessHandler.processJob(_:) + 209 (ServerSyncProcessHandler.swift:209)
3  redacted-app               0xde7398 ServerSyncProcessHandler.processJob(_:) + 189 (ServerSyncProcessHandler.swift:189)
4  redacted-app               0xde9614 ServerSyncProcessHandler.handleMessage(serverSyncJob:) + 379 (ServerSyncProcessHandler.swift:379)
5  redacted-app               0xdeb3c8 partial apply for closure #1 in closure #1 in ServerSyncProcessHandler.init(instanceId:getTokenProvider:handleServerSyncEvent:) + 60 (ServerSyncProcessHandler.swift:60)
6  redacted-app               0xdd8b24 thunk for @escaping @callee_guaranteed () -> () + 6283756
7  libdispatch.dylib              0x2370 _dispatch_call_block_and_release + 32
8  libdispatch.dylib              0x40d0 _dispatch_client_callout + 20
9  libdispatch.dylib              0xb6d8 _dispatch_lane_serial_drain + 744
10 libdispatch.dylib              0xc1e0 _dispatch_lane_invoke + 380
11 libdispatch.dylib              0x17258 _dispatch_root_queue_drain_deferred_wlh + 288
12 libdispatch.dylib              0x16aa4 _dispatch_workloop_worker_thread + 540
13 libsystem_pthread.dylib        0x4c7c _pthread_wqthread + 288
14 libsystem_pthread.dylib        0x1488 start_wqthread + 8

The issue might be here:
private lazy var serverSyncHandler = ServerSyncProcessHandler.obtain(
    instanceId: self.instanceId,
    getTokenProvider: { return PushNotifications.shared.tokenProvider[self.instanceId] }, <---- HERE!
    handleServerSyncEvent: { [weak self] event in
        self?.serverSyncEventHandler.handleEvent(event: event)
    }
)

instanceId can still be nil when serverSyncHandler is accessed, or maybe there is a race condition. On our side, we start the instance and set the user ID as expected. Any idea what could be happening and what we could do on our side to fix this? Thanks in advance.
Additional info
SDK: 4.0.0
iOS: 18.1.1

Hey @FilipeAVS , I guess you are unable to replicate this in your build?
To help us debug this, could you create a simple app and upload that reflects your implementation so that we can try to re-produce it and also to make sure nothing stands out in the implementation?

Hey @aonemd! Exactly, I am unable to replicate the issue, and we have a very low count of users who experienced the same issue, so this might be a very specific edge case.
As for the implementation, hope you don't mind that I share here a snippet that represents how we are implementing it.
So from different parts of the app, we call the initialize function on our PushNotificationsManager class.
final class PushNotificationsManager {
    static let shared = PushNotificationsManager()

    private let userStore: UserStore
    private let client = PushNotifications.shared

    private init(userStore: UserStore = UserStore.shared) {
        self.userStore = userStore
    }
}

// MARK: - Public Methods
extension PushNotificationsManager {
    func initialize() {
        startInstance()
        setUser()
    }
}

// MARK: - Private Methods
private extension PushNotificationsManager {
    func startInstance() {
        client.start(instanceId: "...")
        client.registerForRemoteNotifications()
    }

    func setUser() {
        guard
            let accessToken = userStore.accessToken,
            let userId = userStore.userId
        else { return }

        let tokenProvider = BeamsTokenProvider(authURL: "...") { () -> AuthData in
            let headers = ["Authorization": "Bearer \(accessToken)"]
            let queryParams: [String: String] = [:]
            return AuthData(headers: headers, queryParams: queryParams)
        }

        client.setUserId(userId, tokenProvider: tokenProvider) { error in
            if let error {
                print("Failed to authenticate to PushNotifications with error: \(error.localizedDescription)")
                return
            }
            print("Successfully authenticated with PushNotifications")
        }
    }
}

With the above, in various contexts (like resuming the app, logging in, etc.) we call the initialize method.
PushNotificationsManager.shared.initialize()

This is the general implementation that we are using. Could it be that since we are calling the initialize method from different places, and some of them are very close to each other, we are hitting some race conditions? I appreciate your help @aonemd!


Submit button not working properly with and without input in contact.

Issue :
Submit button not working properly with and without input in contact.
Description :
The submit button doesn't work when clicked, whether the user enters text or not.
No error message pops up if the user tries to submit an empty form.
Expected behavior :
When clicking the submit button without input, a message like "Please enter the required information" should appear.
When valid input is provided, the form should be submitted successfully.
Screenshot :

please assign this issue

Hey! I'd like to work on this issue. Please assign it to me. I'm currently working on the fix and will submit a PR soon.


Volunteer Opportunities Page

The filter controls

filter by event type (Knit Hats or Hats and Hot Chocolate)
Map will center base on the zipcode inputted (default is 60201 for Evanston Illinois)
Radius input will zoom in or out on the map (yet to implemented: filter based on whether the distance from each event address to the zipcode input is within the radius chosen)

The map is interactive, each location in the event list is indicated on the map by a red marker.

Filter by radius is implemented. The default zipcode is 60201 and default radius is null. When no radius is selected, all events are shown in the event listing. Test radius by changing the radius from 5 to 20. By doing so, you should see the event list get smaller and then larger again.


Events Page Update: Frontend And Backend

Currently the events page only has our recruitment event. We need to update this with past events, data to be taken from pbdsce instagram. Additionally, Add SIH  , Pb Hustle to ongoing events and PB recruitment and CTF to future events.
If logged in as Admin, A create event form should be available that allows us to create a new event with all details and a duration during which it will be ongoing.
Data should be fetched from firebase backend, with events categorised as per their duration property.

Assigned to Ayush

@ayush1009208 Some updates to the frontend and integration with backend is remaining

Logout button styling is weird
Data is not being displayed
Add padding from top


Move from Travis CI to GitHub Actions CI

cc: @ablaom @tlienart

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@36c35ff). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #72   +/-   ##
=========================================
  Coverage          ?   90.82%
=========================================
  Files             ?        7
  Lines             ?      229
  Branches          ?        0
=========================================
  Hits              ?      208
  Misses            ?       21
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c35ff...0e2aeb9. Read the comment docs.

@ablaom @tlienart This is ready to merge.


Bluesky content moderation system is flagging non-explicit images as explicit

Describe the bug
Bluesky content filtering is flagging images with no NSFW/Explicit imagery as sexually explicit.
To Reproduce
Steps to reproduce the behavior:

Upload images or media that contain no explicit elements to them
Post the images
Observe that Bluesky content flagging will automatically flag them as explicit despite no noticeable signs of NSFW nature to them

Expected behavior
Bluesky content moderation allows SFW/Non-Explicit images to go through without any tagging or false flagging behavior.
Screenshots

Details

Platform: All platforms
Platform version: Do Not Know
App version: Do Not Know

Additional context
Attempting to upload art as an introduction for my bluesky account, repeated twice and both times i was flagged as having explicit imagery despite images containing no nudity or elements of explicit behavior in them.

Automatic tagging of completely wholesome content is still an issue.


Add explicit exports to the main module

I'm not a 100% sure on this since this isn't on PyPI and I just copied the cwa module as suggested in the README. However, I think the example in the README is wrong when it says
import cwa
…
eventDescription = cwa.CwaEventDescription()

It should either be
from cwa import cwa

Or the cwa main module should expose the public API directly, as this PR proposes.

Hi @raphaelm, nice so see you here!
I was unsure and moved some stuff around, which is why the example was incorrect. You are by far the better python developer, so I'll go with your solution.


Fix comapction log comparison issue

We saw this exception in compaction logs:
java.lang.IllegalArgumentException: Comparison method violates its general contract!         at java.util.TimSort.mergeHi(TimSort.java:903) ~[?:?]         at java.util.TimSort.mergeAt(TimSort.java:520) ~[?:?]         at java.util.TimSort.mergeCollapse(TimSort.java:448) ~[?:?]         at java.util.TimSort.sort(TimSort.java:245) ~[?:?]         at java.util.Arrays.sort(Arrays.java:1515) ~[?:?]         at java.util.stream.SortedOps$SizedRefSortingSink.end(SortedOps.java:353) ~[?:?]         at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485) ~[?:?]         at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?]         at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) ~[?:?]         at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]         at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578) ~[?:?]         at com.github.ambry.store.CompactionLog.processCompactionLogs(CompactionLog.java:119) ~[ambry-store-0.3.870.jar:?]         at com.github.ambry.store.BlobStore.buildCompactionHistory(BlobStore.java:1326) ~[ambry-store-0.3.870.jar:?]         at com.github.ambry.store.BlobStore.start(BlobStore.java:261) ~[ambry-store-0.3.870.jar:?]         at com.github.ambry.store.DiskManager.lambda$start$0(DiskManager.java:173) ~[ambry-store-0.3.870.jar:?]         at java.lang.Thread.run(Thread.java:834) [?:?]

Codecov Report
Base: 73.05% // Head: 66.33% // Decreases project coverage by -6.72% :warning:

Coverage data is based on head (c77ba5a) compared to base (2dd4780).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2250      +/-   ##
============================================
- Coverage     73.05%   66.33%   -6.73%
+ Complexity    10336     9170    -1166
============================================
  Files           748      748
  Lines         57002    57183     +181
  Branches       7014     7037      +23
============================================
- Hits          41643    37932    -3711
- Misses        13095    16922    +3827
- Partials       2264     2329      +65

Impacted Files
Coverage Δ

...ain/java/com/github/ambry/store/CompactionLog.java
0.90% <0.00%> (-77.12%)
:arrow_down:

...rc/main/java/com/github/ambry/store/TimeRange.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/java/com/github/ambry/store/CostBenefitInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...om/github/ambry/store/CompactAllPolicyFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...github/ambry/store/CompactionPolicySwitchInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...github/ambry/store/StatsBasedCompactionPolicy.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...hub/ambry/store/HybridCompactionPolicyFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ambry/store/StatsBasedCompactionPolicyFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../main/java/com/github/ambry/store/ScanResults.java
0.00% <0.00%> (-96.71%)
:arrow_down:

...java/com/github/ambry/store/CompactionDetails.java
0.00% <0.00%> (-92.50%)
:arrow_down:

... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add new configuration variable BUILD_JAIL_SILENTLY

Add new configuration variable BUILD_JAIL_SILENTLY. If you set it to yes in poudriere.conf, then -s option is passed to make(1) and therefore less messages are displayed when building/installing/updating jail from source tree. It affects only when you use either -b or -m git|svn option of jail command.

I think we have too many options as is and complicate the interface. Defaulting to make -s when poudriere -v is not used seems better to me. Git/svn already do that.
Somewhere near the top:
[ $VERBOSE -gt 0 ] && MAKE_CMD="${MAKE_CMD} -s"

I have MAKEWORLDARGS=" -s " in my poudriere.conf for years now so any solution would be fine to me.

I think we have too many options as is and complicate the interface. Defaulting to make -s when poudriere -v is not used seems better to me.

I updated that way.


Add FullName of topic to status

Not sure about the naming of this field; is it self explanatory?

I considered FinalName, but didn't really think that was any better. Suggestions?

Maybe CanonicalName?

FullyQualifiedName?

Not sure I think either of those are any better to be honest. FullyQualifiedName might be a tad better, but not sure it would make a difference.

Name contest in Slack?

Name contest in Slack?

Good idea. Will follow up with results this evening.

FullyQualifiedName seems to be the winner.


Error or terraform comand: VPCIdNotSpecified: No default VPC for this used

I am getting an error when trying to run terraform apply -var-file=bentoctl.tfvars -auto-approve
error creating Security Group (test-bentoml-ec2-bentoml-sg): VPCIdNotSpecified: No default VPC for this user │ 	status code: 400, request id: 7bacdb7e-b1a5-408f-8cc2-dfbaa66de321 │  │   with aws_security_group.allow_bentoml, │   on main.tf line 96, in resource "aws_security_group" "allow_bentoml": │   96: resource "aws_security_group" "allow_bentoml" {
How can I eddit to add an default VPC ID ? not sure if this is the problem though

It should use the default VPC by default so I think that the default VPC is not available locally in your system. Can you try the instructions here https://docs.aws.amazon.com/vpc/latest/userguide/default-vpc.html#create-default-vpc to create a new VPC?.
You can also create a VPC and attach it to the security group. Look into the main.tf file that is generated. check out https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group#vpc_id


Getting crash on Flutter upgrade to 3.7.2

Step to reproduce : Upgrade Flutter from 3.7.1 to 3.7.2
Flutter crash report.
Please report a bug at https://github.com/flutter/flutter/issues.
command
flutter --no-color --no-version-check precache
exception
PathNotFoundException: PathNotFoundException: Creation failed, path = '/Users/rafiizzatulrizqufaris/Documents/flutter/bin/cache/artifacts/engine/darwin-x64/FlutterMacOS.framework' (OS Error: No such file or directory, errno = 2)
#0      _Directory.createSync (dart:io/directory_impl.dart:129:7)
#1      ForwardingDirectory.createSync (package:file/src/forwarding/forwarding_directory.dart:20:16)
#2      ErrorHandlingDirectory.createSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:434:22)
#3      _runSync (package:flutter_tools/src/base/error_handling_io.dart:600:14)
#4      ErrorHandlingDirectory.createSync (package:flutter_tools/src/base/error_handling_io.dart:433:12)
#5      EngineCachedArtifact.updateInner (package:flutter_tools/src/cache.dart:916:19)
<asynchronous suspension>
#6      CachedArtifact.update (package:flutter_tools/src/cache.dart:810:5)
<asynchronous suspension>
#7      Cache.updateAll (package:flutter_tools/src/cache.dart:677:9)
<asynchronous suspension>
#8      PrecacheCommand.runCommand (package:flutter_tools/src/commands/precache.dart:168:7)
<asynchronous suspension>
#9      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1257:27)
<asynchronous suspension>
#10     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#11     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
<asynchronous suspension>
#12     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:283:9)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#14     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
<asynchronous suspension>
#15     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:64:9)
<asynchronous suspension>
#16     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#17     main (package:flutter_tools/executable.dart:91:3)
<asynchronous suspension>

flutter doctor
[✓] Flutter (Channel stable, 3.7.2, on macOS 13.1 22C65 darwin-arm64, locale en-ID)
    • Flutter version 3.7.2 on channel stable at /Users/rafiizzatulrizqufaris/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 32fb2f948e (12 hours ago), 2023-02-08 07:30:10 -0800
    • Engine revision f40b73f8a4
    • Dart version 2.19.2
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc1)
    • Android SDK at /Users/rafiizzatulrizqufaris/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc1
    • Java binary at: /Library/Java/JavaVirtualMachines/jdk-18.jdk/Contents/Home/bin/java
    • Java version Java(TM) SE Runtime Environment (build 18+36-2087)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] VS Code (version 1.75.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • M2103K19PG (mobile) • tw7x8pofkbnzhihi • android-arm64  • Android 12 (API 31)
    • macOS (desktop)     • macos            • darwin-arm64   • macOS 13.1 22C65 darwin-arm64
    • Chrome (web)        • chrome           • web-javascript • Google Chrome 109.0.5414.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

@RafiIzzatulRizquFaris
I am unable to replicate this error after trying the said command in 3.7.1 and then upgraded to 3.7.2 which resulted in no crash.
Do you consistently get the crash everytime you run the command ?


Create builds for Xamarin

This PR creates projects for Xamarin.iOS / Xamarin.Android / Xamarin.Mac. To build it, you'll need a copy of at least Xamarin Indie Edition. This builds on #29, start reading at 683e1c0
TODO:

[x] Set up a separate project
[x] Make sure it builds
[ ] Create a sample application
[ ] Actually make sure it sends crash reports
[ ] Merge #29

love the TODO checklist :) easy to know what's going on :+1:

@paulcbetts 👴 we are about to release v2 of the notifier which will make this impossible to merge! We will look at adding Xamarin support once that is released. https://github.com/bugsnag/bugsnag-dotnet/tree/v2


module.rule.generator.publicPath not work for css background-image

System Info
System:
OS: macOS 13.6
CPU: (8) x64 Intel(R) Core(TM) i7-8557U CPU @ 1.70GHz
Memory: 29.29 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
pnpm: 8.7.1 - /usr/local/bin/pnpm
Browsers:
Chrome: 119.0.6045.199
Chrome Canary: 122.0.6171.0
Safari: 16.6
Details
when use publicPath in rule, the images from css/less/vue-style tag or the style in template still prefixed with the output.publicPath, not the inner one；but in img tag with src, it works:
module.exports = {
  //...
  output: {
    publicPath: 'https://xxx.com/',
  },
  module: {
    rules: [
      {
        test: /\.png/,
        type: 'asset/resource',
        generator: {
          publicPath: 'https://cdn.xxx.com/',
        },
      },
    ],
  },
};

Reproduce link
rspack-vue-publicPath-reproduce
Reproduce Steps
in my case it's a vue2 project with less:
write a tag like
name
 or
in the less file or vue/style tag:
p {
  background-image<EMAIL_ADDRESS>}

cases above still use the output.publicPath

It seems to be because the loaderContext is missing the importModule, maybe https://github.com/web-infra-dev/rspack/pull/4718 this pr will support it

It seems to be because the loaderContext is missing the importModule, maybe this pr(#4718) will support it

@faga295  any EST for this pr to be merged and released? I would like to have a try

@JSerFeng cc

Look like the img src is correct, I can't reproduce the bug, can you provide more information?

@ahabhgk the img src is ok, but the url in background-image: url("") is not replaced

https://github.com/webpack-contrib/mini-css-extract-plugin/blob/7ddf35a178a6a0dc331e8099e29437f20d0a2c47/src/loader.js#L319-L339 In mini-css-extract-plugin, it will resolve request via importModule, but current rspack is missing it

This is a bug about experiments.css url, this will be fixed by #5099, and the fix will land in v0.4.5 in next week

This is a bug about experiments.css url, this will be fixed by #5099, and the fix will land in v0.4.5 in next week

looking forward to it 👀


[FEATURE REQUEST]: Any plan to develop a pull-up to refresh feature ?

There are any plan to develop a pull-up to refresh feature or to implement the RefreshControl component ?

Found a solution. I use the following property to access the benath FlatList properties.
masonryFlatListColProps = {{
                        refreshControl: ...


Upload the file to google Cloud

Thanks for create this amazing project :+1:
I like to know how we can upload the rendered video to Google Cloud Server like S3 and FTP server
Regards
Senthuran

Hello @senthudms
Try to check out post rendering actions:
https://github.com/inlife/nexrender#actions
https://github.com/inlife/nexrender/tree/master/packages/nexrender-action-upload
And then also select the driver you want to use:
https://github.com/inlife/nexrender#protocols
https://github.com/inlife/nexrender/tree/master/packages/nexrender-provider-s3
https://github.com/inlife/nexrender/tree/master/packages/nexrender-provider-ftp

Thank @inlife
I'm testing that. I will update you asap

Hi, the latest release seems to support uploading to Google Cloud Storage as a post render action now.

HI
Thank you so much :)
On Fri, Jan 10, 2020 at 3:23 PM Frank Bruns<EMAIL_ADDRESS>wrote:

Hi, the latest release seems to support uploading to Google Cloud Storage
as a post render action now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/inlife/nexrender/issues/258?email_source=notifications&email_token=ADBYW2PWP3OOYYCGL3TC4L3Q5BASBA5CNFSM4I7AC4IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEITKGQQ#issuecomment-572957506,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADBYW2NH2Z4VMUY4FKG7PR3Q5BASBANCNFSM4I7AC4IA
.


Line 95 of src/Swatches.vue v1.0.2 change is missing in NPM's v1.0.2 package

Issue:
The change to line 95 of Swatches.vue of the 1.0.2 release is not included when installing that version of the package.  When diffing with that version of the file all of the other changes are appearing which seems strange, and I'm hoping someone else can reproduce this.  This missing change is causing the submit event to be triggered when vue-swatches is used within a form, and would be fixed if Vue's prevent event modifier was included.  An alternative fix would be to use the type="button" attribute to override the standard submit type.
Expected result:
line 95 of Swatches.vue should include Vue's prevent event modifier:
@click.prevent="onFallbackButtonClick"
Actual result:
line 95 of Swatches.vue does not include Vue's prevent event modifier:
@click="onFallbackButtonClick"
Steps to reproduce:

Create a new directory and initialize as a new NPM package by running npm init (accept defaults).
Install the latest published version of the vue-swatches package npm install vue-swatches --save
Confirm in node_modules/vue-swatches that the version in package.json is 1.0.2
Open node_modules/vue-swatches/Swatches.vue and inspect line 95 and compare to the v1.0.2 release to see the difference.  Look at one of the other lines like line 70 to see that it does correctly match what was changed in the release.

You can also download the following test package, unzip, and run npm install which as you will see in its' package.json will only install vue-swatches 1.0.2:
vue-swatches-test.zip

I apologize, I see clearly the commit was after v1.0.2 so it just has not been released yet.  Feel free to close or if you have an update on when it might be released let us know.  Thanks again for your work, and sorry for the false alarm.

I just released v.1.0.3 for this matter

Thanks for your help @saintplay, and for the quick release.


Unable to edit existing Subscription-level throttling policies

Description:
User can't edit the existing Subscription-level throttling policies.
When edit button is clicked, fields are displayed blank with name field frozen. When trying to save error message "Name is Empty" is displayed.

Steps to reproduce:

Go to admin portal
Click subscription policies
Click edit in policy "Gold"

Expected output :
Existing values should be loaded in the fields.
Affected Product Version:
API-M 4.0.0
Suggested Labels:
API-M 4.0.0

Someone please check this in Windows

Tested in windows 10 Google Chrome
Version 89.0.4389.114 (Official Build) (64-bit)
And Microsoft Edge

This is no longer reproducible for me as well. We can close this issue.

This is reproducible in the latest built pack


Fixing up a bunch of minor problems

Remove browser prefixes from Sass, just use autoprefixer during build
Use images-to-variables to inline svg image
Use a relative font size (1 em)
Switch to using the C12 colors from vui-colors
Add focus style where there is hover style
Add homepage, and bugs links to package.json

:+1:

Should this be going into a c12 branch? Or perhaps we should bump a 1.0 and make a 1.x branch for continued dev on current styles before merging this?

Owen and Dave are you guys OK with this going in now? I have another change after this to setup the npm key with travis.

Seems like you've implemented all of the feedback, so, sure, looking good


Ability to add a third button on consent_modal

Hello,
First, thanks for this awesome plugin!!!!!
After readed this GDPR white paper, for a full gdpr compliant (in Belgium anyway), we need to add a third button on the "consent_modal". Like Settings - Accept all - reject all!
Is there a way to add it or did you already plan this functionnality ?
https://www.universem.com/blog/gdpr-belgium-white-paper-universem-lexing/
Thanks

Hi @BigsmileAgency,
this has already been implemented in v3, which should be released ~soon. Check out #288 for a preview.

Hi @orestbida ,
So great!!
Thanks for this and your reactivity ;)


Upgrade to OpenNLP 2.5.x

Description
Apache OpenNLP 2.5.0 has been released. This version contains new implementations of TokenNameFinder et al., that are Thread-Safe. Moreover, models for many new languages (32, as of Nov 2024) are now available. Those models are also available as Maven artifacts.
Apache OpenNLP 2.5.0 requires Java 17 and should be fully compatible with Java 21.
This task is update the OpenNLP dependency version to 2.5.x (x >= 0). Note: Release 2.5.1 is expected in December 2024.

I was looking into this (trying to upgrade to 2.5.1) and initially ran into some failing test cases.
It looks like they were all related to the switch of the default POSTagFormat from Penn to UD. I was able to get all the tests passing by changing this line: https://github.com/apache/lucene/blob/9a88d8ad25d2568955b26b09b3f18b3c8ad01ba2/lucene/analysis/opennlp/src/java/org/apache/lucene/analysis/opennlp/tools/NLPPOSTaggerOp.java#L33
to
tagger = new POSTaggerME(model, POSTagFormat.PENN);

(I assume that we should support UD-style tags eventually too, but this at least keeps the existing functionality the same.)

@msfroh Thx for checking. The option (PENN format) you chose is the quick option for updating to 2.5.x (hint: x=2 released today).
The UD format will give the Lucene project a possibility to rely on a wider range of models for 32 languages, we have trained and published (see: OpenNLP models page) recently. Might be an option for 2025 and onwards: just switch to the UD model files and the corresponding format.
Open for any further feedback/questions.


ZipIterator issues

The current implementation of ZipIterator has a bunch of issues:

If it's possible, it would be much better to implement a plain
iterator that returns the entries as lazy values that actually do the
reading when needed.  This would make it possible to drop the
sampling completely, and use something like
.filter(_ => r.nextDouble < someRatio) instead of baking it in.

Reading the quick description, it's not clear to me that it always
returns the same elements (ie, the setSeed(0)) -- but maybe this is
idiomatic and shouldn't be documented?

Also, there is the known algorithm that returns N random elements,
maybe it's also useful to do that?  (This would be easy if the first
point is done.)

The implementation is not too great -- it looks like there are too
many vars, and the return inside the while loop is making it
hard to follow.  Again, doing the first point would make all of this
complexity go away.

This is no longer in the code as part of the streaming functionality pr


"maximum recursion depth exceeded" when using keras.layers

I was trying Keras 3.0 on Google Colab (no GPU), by first upgrading all required packages:
%pip install einops tensorflow jax --upgrade --quiet
%pip install keras --upgrade --quiet

The imported versions conform to the compatibility matrix from the website:
print(jax.__version__) >>> 0.4.20
print(tf.__version__) >>> 2.15.0
print(keras.__version__) >>> 3.0.0

However, if I follow the guide on running a custom training loop in JAX I get the following error:
RecursionError: Exception encountered when calling Dense.call().
maximum recursion depth exceeded in comparison
Arguments received by Dense.call():
• inputs=jnp.ndarray(shape=(32, 784), dtype=float32)
I can replicate the error with the following short snippet:
xb = jax.numpy.ones((4, 2))
model = keras.layers.Dense(5)
_ = model(xb)
w = model.trainable_variables
jax.value_and_grad(lambda w: model.stateless_call(w, [], xb).sum())(w)

Any idea what I am doing wrong? Is it just a matter of compatibility with Google Colab?

On the default Colab runtime, just running all cells in the guide with zero changes works fine.
"maximum recursion depth" is something that is configured at the Python level. It is supposed to default to 1000. In the Colab runtime it is 1000 indeed (and that works for the guide). This is an error that is usually found when there is an infinite recursion loop happening.
Now, I can reproduce the error for your code standalone snippet. Looking at it, there is an infinite recursion issue happening in JAX when we call jnp.matmul, specifically at the level of this line:
# jax/_src/interpreters/ad.py
class JVPTracer(Tracer):
  ...

  @property
  def aval(self):
    # TODO(dougalm): add epsilon ball
    return get_aval(self.primal)

So it appears to be a JAX bug. One way you can route around it is by extracting JAX arrays from the Keras variables before you send them to the JAX transform, e.g.
xb = jax.numpy.ones((4, 2))
model = keras.layers.Dense(5)
_ = model(xb)
ws = [w.value for w in model.trainable_variables]
jax.value_and_grad(lambda w: model.stateless_call(ws, [], xb)[0].sum())(ws)

Please open a bug report in the JAX repo for this issue.

Thanks for the detailed answer! To complement my original post, I got the error from the guide on the Keras website because I did not jit the train step:
https://colab.research.google.com/drive/1lwDczGJ_CbFbP-ZfWJBYsajs9MpVGj93?usp=sharing
Uncommenting jax.jit, everything works.


Update source packaging

The source is missing requirements.txt. This PR will ensure such slip-ups are avoided by design with minimal maintenance in future.

[x] Update MANIFEST.in: Closes #126

Explicitly specify files/folders to include or exclude from the PyPI source (unionml-#.#.#.tar.gz file).
This also helps separate the concern of what to package in the PyPI source from the rest of the logic in setup.py .

[x] Add .gitattributes file to control what to include/exclude in GitHub releases: Closes #127

[x] Single source version (unionml.__version__) from setup.py: Closes #129

[x] changes unionml/__init__.py
[x] changes workflow: publish.yml

cc: @cosmicBboy

@cosmicBboy I have made the changes. Please see and let me know if you think anything else must be addressed before merging.

there's a mypy issue: https://github.com/unionai-oss/unionml/runs/7010795478?check_suite_focus=true#step:6:63
gonna add a # type: ignore comment

@sugatoray looks like there are some linting/formatting errors: please follow the contribution guide to run the pre-commit hooks:
https://unionml.readthedocs.io/en/latest/contributing_guide.html#pre-commit-setup

I was pushing these changes from the web version of VSCode as an experiment to see what kind of challenges I might come across if only using VS Code to push code changes.
Will now clone locally and apply pre-commit as well. Thank you, for pointing it out.

Known issue with pre-commit + VS Code git integration
I use VS Code. If you are using VS Code + pre-commit + conda, you may see some weird behavior in VS Code, while using the git integration/extension it provides out of the box for committing files. I opened an issue here.

https://github.com/microsoft/vscode/issues/153037

Added constrained installation of importlib-metadata only for python version <3.8.
Source: https://github.com/huggingface/huggingface_hub/blob/66175504f943f080e0b407e04cf56bd0895f6bb9/setup.py#L20
- importlib-metadata
+ importlib-metadata;python_version<'3.8'

✅ LGTM! Merging now... congrats on your first contribution @sugatoray ! 🎉🎉🎉

@cosmicBboy Thank you for the reviews and merging. :rocket:


ZStream transduce makes spurious ZSink calls

I expected the following test case to pass, but it fails:
  private def transduceTermination = {
    val sink = Sink.fold(None: Option[Int]) { (_, a: Int) =>
      ZSink.Step.done(Some(a), Chunk.empty)
    }
    val transduced = ZStream(1).transduce(sink)
    val prg = transduced.run(ZSink.collect[Option[Int]])
    val list = unsafeRun(prg)  // List(Some(1), None)
    list must_=== List(Some(1))
  }

The issue is that once the last value from the upstream has been processed, transduce finishes off by calling Sink#initial followed by Sink#extract. In the above test cases, the sequence of calls to the sink are:

initial → Sets state to None
step → Sets state to Some(1)
extract → returns Some(1)
initial → Sets state to None
extract → returns None

meaning the transduced stream emits two values: Some(1) and None.
This issue doesn't show up for any sinks where extract errors if there hasn't been at least one call to step, as transduce eats all errors from the final extract call (I have no idea why), and nothing is emitted downstream.
I can have a go at fixing this, but I thought it worth confirming that this is really not expected.

Thanks for investigating this @quelgar! I agree that your test indicates the desired behavior. Please give this a shot if you have the time.
A few notes:

The last calls to initial and extract are intended to process the leftovers from the last element, but that combinator is a bit of a maze so bugs are definitely possible.
The foldM that swallows the errors at the end is a bit suspicious. Maybe @jdegoes remembers why is it there.

Let us know if you need any assistance in fixing this!

Looking back in the commit history, I see that I added the call to redeem (which is now ZIO#foldM) in https://github.com/scalaz/scalaz-zio/commit/b3198d153945787ec30afe004ce556246e92a6a4, but I can't recall why. So let's fix this indeed :-)


Goals for this project?

Hi.  Saw the description of this repo, and was just curious what perf stuff you're looking to measure, and what sort of "good practices" you're looking at.

Hi @markerikson , the main goal of the project is to compare the different ways of processing data in redux. For now it's a sandbox for analyzing the following things in terms of performance:

analysis of how react-redux works
impact of data normalization.
using immutable.js
using virtual lists.

I would also like to show a case study to find specific performance issues using devtools.

Interesting.  Sounds like a useful line of investigation.
FYI, my React/Redux links list has a large section of articles on performance that covers React, Immutable.js, and Redux: https://github.com/markerikson/react-redux-links/blob/master/react-performance.md .  Probably some relevant info there for you.  I also recently wrote a blog post that discusses Redux perf at http://blog.isquaredsoftware.com/2017/01/practical-redux-part-6-connected-lists-forms-and-performance/ , and the Redux FAQ has a number of related questions ( http://redux.js.org/docs/faq/Performance.html#performance-scaling , http://redux.js.org/docs/faq/OrganizingState.html#organizing-state-nested-data , http://redux.js.org/docs/faq/ImmutableData.html .
Also, if you're interested in the internals of React-Redux, Dan wrote a simplified version of connect that illustrates the basic approach, but without any of the optimization aspects: https://gist.github.com/gaearon/1d19088790e70ac32ea636c025ba424e .  You may also be interested in the two main issues that cover the implementation of React-Redux v5, which was a complete internal rewrite: https://github.com/reactjs/react-redux/issues/407 , https://github.com/reactjs/react-redux/pull/416 .
Hope that helps, and lemme know if you finish and come up with any useful conclusions or data points.

Thanks mate, it looks like a lot of interesting stuff in there! I haven't made such complex investigation yet but I am pretty sure you have just filled many gaps in my knowledge.

Yay, mission accomplished! :)
If I had to TL;DR things:

React-Redux generates wrapper components that subscribe to the store, extract data using the given mapState function, and diff the results using shallow equality to see if the values changed and the wrapped component actually needs to re-render
Normalization allows generally simpler immutable updates, multiple views of the same data, and enables connected components that look up a given item by ID even if it's technically nested
Immutable.js offers some perf benefits if you're copying/updating very large objects and can make equality checks easy to implement, but (my own opinion) is a bad choice for most projects.  It also leads to some potential perf anti-patterns - use of toJS() is horrible for perf, especially if called in mapState.

There was a recent Twitter thread on why we normalize data with Redux in the first place ( https://twitter.com/AdamRackis/status/847883670950219776 ), and a while back I wrote my reasons why I advise against use of Immutable.js ( https://www.reddit.com/r/javascript/comments/4rcqpx/dan_abramov_redux_is_not_an_architecture_or/d50covu/?context=3 ).

I started this repo after experiences gained from production projects I've made. This is even more interesting as I came up with very similar thoughts  (eg. about immutable and how people wanted to have POJO with toJS in selectors). I could not get better advice than yours.


[Bug]: Multi-line labels for date widgets

Is there an existing issue for this?

[X] I have searched the existing issues

Description
This is somewhat related to https://github.com/appsmithorg/appsmith/issues/20413
The label on the date widget will break/wrap in the middle of a word.
Additionally, if you set height to "fixed" and then manually make the height tall enough to accommodate the label, the label does not expand.
Please consider using word-break: normal with overflow-wrap: break-word like you did in the other ticket, in addition to fixing manual height.
Steps To Reproduce
Create a date widget
Give it a long label, long enough to be multiple lines
Manually expand widget height and notice that the label is still truncated
Change height to "auto height"
Notice the label is now multiple lines, but words are broken mid-word
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Self Hosted - 1.9.40

Note, this is also applies to the list widget.  Maybe others.

@eedwardsSGS thanks for reporting this. We'll look into it

@ichik what do you think about this? Is this something we should think about under WDS development?

@somangshu label is a short helpful marker for the input field, it should not take multiple lines.

So we dont support this dimension?
Can / should we limit the label to certain length?

@somangshu I think builder already can identify label of excessive length intuitively and fix it without putting artificial restrictions on it.

IMO, if we allow multi-line labels, this requests are going to come in future as well and we cant really justify them.
We either find a solution around them or limit them based on the product constrains.

@somangshu we don't need to allow them to be multi-line, a single line can simply overflow out of canvas.

@ichik is that even possible with the new layout system (anvil)
cc @KelvinOm @prsidhu WDYT?

@somangshu white-space: nowrap is pretty ancient.


cull_opacity_perf__timeline_summary timing out

cull_opacity_perf__timeline_summary started timing out with https://github.com/flutter/flutter/pull/65044, but the revert didn't fix it.
cull_opacity_perf__timeline_summary_48ba488_2.log

Failing on mac-20 and mac-21

@jmagman different revert, we could try with  #65044 but when I ran locally it passed

Ah, https://github.com/flutter/flutter/commit/ea75ffc1ba8a0af33bdba352e733c2ba5fa11472 wasn't merged.

Passed on revert https://github.com/flutter/flutter/pull/66051


Broken 'Unlock' link on "Your locked pages" dashboard panel

Issue Summary
The "Unlock" link on the "Your locked pages" dashboard panel on the admin homepage is broken.
Steps to Reproduce

From a fresh bakerydemo installation, edit the homepage and lock it from the status sidebar
Go back to the admin homepage, where a "Your locked pages" panel now appears
Click the "Unlock" button under the homepage item. You arrive at the URL http://localhost:8000/admin/undefined, with the error message:

RuntimeError at /admin/undefined
You called this URL via POST, but the URL doesn't end in a slash and you have APPEND_SLASH set. Django can't redirect to the slash URL while maintaining POST data. Change your form to point to localhost:8000/admin/undefined/ (note the trailing slash), or set APPEND_SLASH=False in your Django settings.

Technical details

Python version: 3.8.0
Django version: 4.1.2
Wagtail version: main (4.2a0)
Browser version: Chrome 106.0.5249.119

Looks like this has been broken since 3.0... current behaviour started in 6f10ae45c76b9f5533e92c749bc1856f86df3d06, and before that the button didn't respond at all. (It did work in 2.16)

Original breakage (button not responding) happened in f323d887658c1f82d71960cd48d8929e233ff473.

That's interesting, I think I've tested this either for #9528 or for #9530, and it worked. Maybe #9530 actually fixes it, I thought it was only "cosmetic" :sweat_smile:

Confirming this is broken. Also may be fixed with merged https://github.com/wagtail/wagtail/pull/9530

Fixed via https://github.com/wagtail/wagtail/pull/9530
5086257539c54f8674a33b48b52f39a61a76126e
5584b44ca72e091fadd5fb4d4ac3b116900da371 (4.1 stable)


Fix error about symbolic link

Fix error about https://github.com/yyuu/pyenv/pull/502

Same comment as in https://github.com/rbenv/rbenv/pull/838— I would appreciate a test here.

I find this error in pyenv, and @yyuu suggest me send fix to here.
In pyenv abs_dirname has been used not only to get bin_path but also  to transfer PYENV_FILE_ARG into PYENV_DIR.
In rbenv abs_dirname is only used by bin_path, so there is not obviously error in rbenv now.
But if somebody use abs_dirname in some other situation future, maybe fail.
a test.sh is here.
#!/usr/bin/env bash

resolve_link() {
  $(type -p greadlink readlink | head -1) "$1"
}

abs_dirname() {
  local cwd="$PWD"
  local path="$1"

  while [ -n "$path" ]; do
    echo "Debug: path is ${path%/*}" >&2
    echo "Debug: name is ${path##*/}" >&2
    [ -d "${path%/*}" ] && cd "${path%/*}" \
        && echo "Debug: pwd is $(pwd)" >&2
    local name="${path##*/}"
    path="$(resolve_link "$name" || true)"
  done

  pwd
  cd "$cwd"
}

abs_dirname $(which $1 || echo "$1")

and I run it
MengtekiMacBook-Pro:tmp meng$ ls -lR testdir/
total 16
lrwxr-xr-x  1 meng  staff   7 12 15 09:18 justtest -> test.rb
-rwxr-xr-x  1 meng  staff  41 12 15 09:17 test.rb
MengtekiMacBook-Pro:tmp meng$ ./test.sh testdir/justtest
Debug: path is testdir
Debug: name is justtest
Debug: pwd is /Users/meng/tmp/testdir
Debug: path is test.rb
Debug: name is test.rb
/Users/meng/tmp/testdir
MengtekiMacBook-Pro:tmp meng$ cd testdir/
MengtekiMacBook-Pro:testdir meng$ ../test.sh justtest
Debug: path is justtest
Debug: name is justtest
Debug: path is test.rb
Debug: name is test.rb
/Users/meng/tmp/testdir
MengtekiMacBook-Pro:testdir meng$ ../test.sh sqlmap
Debug: path is /usr/local/bin
Debug: name is sqlmap
Debug: pwd is /usr/local/bin
Debug: path is ../Cellar/sqlmap/0.9_1/bin
Debug: name is sqlmap
Debug: pwd is /usr/local/Cellar/sqlmap/0.9_1/bin
Debug: path is sqlmap.py
Debug: name is sqlmap.py
Debug: path is ../libexec
Debug: name is sqlmap.py
Debug: pwd is /usr/local/Cellar/sqlmap/0.9_1/libexec
/usr/local/Cellar/sqlmap/0.9_1/libexec
MengtekiMacBook-Pro:testdir meng$

It's OK.
And if without [ -d "${path%/*}" ] && check in abs_dirname
MengtekiMacBook-Pro:tmp meng$ ls -lR testdir/
total 16
lrwxr-xr-x  1 meng  staff   7 12 15 09:18 justtest -> test.rb
-rwxr-xr-x  1 meng  staff  41 12 15 09:17 test.rb
MengtekiMacBook-Pro:tmp meng$ ./test.sh testdir/justtest
Debug: path is testdir
Debug: name is justtest
Debug: pwd is /Users/meng/tmp/testdir
Debug: path is test.rb
Debug: name is test.rb
./test.sh: line 14: cd: test.rb: Not a directory
/Users/meng/tmp/testdir
MengtekiMacBook-Pro:tmp meng$ cd testdir/
MengtekiMacBook-Pro:testdir meng$ ../test.sh justtest
Debug: path is justtest
Debug: name is justtest
../test.sh: line 14: cd: justtest: Not a directory
Debug: path is test.rb
Debug: name is test.rb
../test.sh: line 14: cd: test.rb: Not a directory
/Users/meng/tmp/testdir
MengtekiMacBook-Pro:testdir meng$ ../test.sh sqlmap
Debug: path is /usr/local/bin
Debug: name is sqlmap
Debug: pwd is /usr/local/bin
Debug: path is ../Cellar/sqlmap/0.9_1/bin
Debug: name is sqlmap
Debug: pwd is /usr/local/Cellar/sqlmap/0.9_1/bin
Debug: path is sqlmap.py
Debug: name is sqlmap.py
../test.sh: line 14: cd: sqlmap.py: Not a directory
Debug: path is ../libexec
Debug: name is sqlmap.py
Debug: pwd is /usr/local/Cellar/sqlmap/0.9_1/libexec
/usr/local/Cellar/sqlmap/0.9_1/libexec
MengtekiMacBook-Pro:testdir meng$

It output error.

But if somebody use abs_dirname in some other situation future, maybe fail.

Thanks for the explanation. So it seems like abs_dirname implementation is not perfect now, but due to the ways it's used right now, there isn't a concrete bug that exists yet with it?
It would be great if we had more extensive tests for this abs_dirname function. I may try to come up with some tests in rbenv project. Until then, this is not urgent, and I will hold off merging until we have some test coverage.
Thanks for the patch!


Hangs before exit

I have a bit of code that calls await packageInfo(packageName) in a loop.  The info is properly returned for each package queried.
Yet when I end the loop to exit the program, I don't get a prompt or in the android studio debugger the stop button is enabled as if the program were still running.
There's some sort of timeout that once reached, the program does exit.
I have tried using a single Client instance and one per query, with the same results.
If I were to guess, I'd say the HTTP socket is keep-alive and the code won't exit until that socket is closed.
If this is the case, my suggestion would be some sort of destroy(), close(), or cleanup() on the client instance to force close the socket.
I don't see one here:
https://pub.dev/documentation/pub_api_client/latest/pub_api_client/pub_api_client-library.html or
https://pub.dev/documentation/pub_api_client/latest/pub_api_client/PubClient-class.html
It's probably a good idea to implement such a function, even if it simply returns (for now).

BTW, thanks for this package.  It's quite useful.

@mschwartz did you try calling close on the client?
You can do the following way.
  final client = PubClient();
  final packageScore = await client.packageInfo('provider');
  client.client?.close();

I can do that, thanks.
You still might consider adding a close() method on the PubClient that does the client?close(). If we use that new close() method and you later implement code that requires more cleanup, we all get it for free.
Again, thanks for this package!

Thanks for adding the close method.
However, the issue persists even with calling client.client?.close().
If I comment out the line that calls client.anymethod(), the program exits immediately.  Otherwise there's a several second pause at the end.
I've tried creating the client and closing it for each method call as well as one global client that I reuse and close before program is finished.
I could call exit(), but you might want to investigate this (or not :))

@mschwartz based on my research it seems there are some open issues in regards to the HttpClient, some even point at malformed responses, so I am not 100% sure if this something that needs to be fixed on pub_api_client
Did you fix to close after each method work?

Close after each method did not solve the problem.  I tried both ways: create, query, close, and create, query, query….

Not being able to replicate this. If there is a sample code that I can use to replicate it would be great

The example code can be used to replicate the issue. The following code hangs for me.
import 'package:pub_api_client/pub_api_client.dart';

void main() async {
  final client = PubClient();
  final packageScore = await client.packageScore('fvm');
  print('Package Score: $packageScore');
}

I'm having the same issue.


THis is the new b777-300er philippine airlines I resize the font

Listen PhilAvia744 Made It Because Your Livery Of Philippine Airlines Sucks!

Can You Ban @andymance  On Livery Selector? He's Rigging This!

YOU'RE PEDO NOW!


Fixed bug where BlobBaseClient.Exists() did not function correctly for blobs encrypted with CPK

Not technically a 78 feature but I need the regenerated code.
This PR is to address a scenario when a customer has a blob encrypted with CPK and calls exists without the CPK on the client.
If someone does not have a CPK, it is fine to return back true since the service is not hiding the fact that the blob exists (otherwise it would return 404 like in incorrect SAS or auth scenarios). The service returns an error message saying the blob uses CPK so it cannot return back properties.

Can you update the description with more info on what we're trying to achieve here besides just this API not throwing in a certain context? What customer need are we responding to with this change? If someone doesn't have the CPK, is it acceptable that we relay true back to them? Is the REST service specifically hiding anything from us on this or is it acknowledging that the blob does indeed exist on this response?

Updated the description


star macro issue when no columns returned

If there are no columns returned in the macro it returns as commented out block but the issue is if the star macro isn't the last selected field in a select statement, it will place a comma on the outside of the comment block.
-- example
with
  final as (
    select
      {{ dbt_utils.star( ref("foo")) }},
      {{ dbt_utils.star( ref("bar")) }}

      from ...
)

select * from final

-- In this example let say the table foo doesn't return any columns. The compiled code looking like
with
  final as (
    select
      /* no columns returned from star() macro */,
      bar_column1,
      bar_column2...

    from ...
)

select * from final
-- The above will fail to execute due to the comma outside of the comment block.

Simple fix would be to change the method being used to comment to simple double dash. Also believe this change will still comply with SQLFluff.
Reference source line
https://github.com/dbt-labs/dbt-utils/blob/fc98e4e30cd299ddd67c43902f2a5efa9511edfb/macros/sql/star.sql#L26

I am also thinking ... WHat does <0 represent in this line?
https://github.com/dbt-labs/dbt-utils/blob/be74299894413860f8de7dc3e45f2263f03d4acd/macros/sql/star.sql#L16

I am also thinking ... While =0 makes sense, what purpose does <0 serve in this line?
https://github.com/dbt-labs/dbt-utils/blob/be74299894413860f8de7dc3e45f2263f03d4acd/macros/sql/star.sql#L16

@Datarogie, Shouldn't this fail loud if no columns are returned from foo?
What use case would a change serve?

The addition of , will help the user remind that something is missing otherwise, one might totally miss the issue that the first Ref isn't returning any column


[v0.12.0] Fix arch detection on darwin

macOS Intel:
>>> platform.architecture()[0]
'64bit'
>>> platform.machine()
'x86_64'

macOS M1:
>>> platform.architecture()[0]
'64bit'
>>> platform.machine()
'arm64'

I don't ever execute this code on the target platform (I don't have a Mac), but use the environment variable PYSOUNDFILE_ARCHITECTURE instead.
Thus, we have to follow the logic in https://github.com/bastibe/python-soundfile/blob/v0.12.0/soundfile.py#L153, and either take platform.architecture()[0] or platform.machine(), depending on sys.platform, iff PYSOUNDFILE_ARCHITECTURE is not set.
Would you like to amend the pull request accordingly? If not, I'll do it, that's perfectly fine, too.

Would you like to amend the pull request accordingly? If not, I'll do it, that's perfectly fine, too.

Please do. Sorry but I don't quite follow the idea here.
The error is caught when I try to bump soundfile to 0.11.0 for nixpkgs https://github.com/NixOS/nixpkgs/pull/215066

Could you have a look at #367 and see if that fixes your issue?


$.jPlayer.event.pause not fired

Hi there, i want to integrate analytics in my jPlayer instance. $.jPlayer.event.play is fired but not $.jPlayer.event.pause or $.jPlayer.event.stop
do you have any ideas?

So, now i've figured out that the pause event is not getting fired if a livestream is running.


removed 'name' variable and purged all references in util.go and contracts.go

Now compiling is to be done in generated directories (changes reflected in README).  Primary reason being that if we're including a file path for a signature, it seems to make sense that it would be relative to the directory in which the params file exists (also, even if the signature method is changed, it still makes sense to me to work out of the specific directory to which you're making changes).

Actually maybe just take a look at my latest commits? Everything is fixed there plus more feature added. I'll make a pull request here.

LGTM :+1:
ideally, the last commit should have been squashed into the commit that introduced the formatting mess up, but it's fine for now


put operation raises exception: AttributeError: 'NoneType' object has no attribute 'absolute_update'

My tets running on gcsfs-2021.7.0 worked without any issues, though upgrading to gcsfs-2021.9.0 gave me the following error on the gcsfs.core.GCSFileSystem.put method. See the following traceback:
Traceback
damsat/ingestion/ingestion.py:671: in do_cut_general
    move(filename, remote_filename)
../../miniconda3/envs/damsat/lib/python3.7/site-packages/libsat/filesystem.py:84: in move
    fs_target.put(source_path, target_path, recursive=recursive)
../../miniconda3/envs/damsat/lib/python3.7/site-packages/fsspec/asyn.py:91: in wrapper
    return sync(self.loop, func, *args, **kwargs)
../../miniconda3/envs/damsat/lib/python3.7/site-packages/fsspec/asyn.py:71: in sync
    raise return_result
../../miniconda3/envs/damsat/lib/python3.7/site-packages/fsspec/asyn.py:25: in _runner
    result[0] = await coro
../../miniconda3/envs/damsat/lib/python3.7/site-packages/fsspec/asyn.py:422: in _put
    coros, batch_size=batch_size, callback=callback
../../miniconda3/envs/damsat/lib/python3.7/site-packages/fsspec/asyn.py:213: in _run_coros_in_chunks
    results.append(await coro)
../../miniconda3/envs/damsat/lib/python3.7/asyncio/tasks.py:560: in _wait_for_one
    return f.result()  # May raise f.exception().

failing on the following function call
    async def _put_file(
        self,
        lpath,
        rpath,
        metadata=None,
        consistency=None,
        content_type="application/octet-stream",
        chunksize=50 * 2 ** 20,
        callback=None,
        **kwargs,
    ):
        # enforce blocksize should be a multiple of 2**18
        if os.path.isdir(lpath):
            return
        consistency = consistency or self.consistency
        checker = get_consistency_checker(consistency)
        bucket, key = self.split_path(rpath)
        with open(lpath, "rb") as f0:
            size = f0.seek(0, 2)
            f0.seek(0)
            if callback is not None:
                callback.set_size(size)

            if size < 5 * 2 ** 20:
                await simple_upload(
                    self,
                    bucket,
                    key,
                    f0.read(),
                    consistency=consistency,
                    metadatain=metadata,
                    content_type=content_type,
                )
>               callback.absolute_update(size)
E               AttributeError: 'NoneType' object has no attribute 'absolute_update'

possible related change
Perhaps since the callback was introduced https://github.com/dask/gcsfs/commit/552ccb3735b9bcfe153977ca78fa842b05ad59bf it may be None, although that case is not handled in the code.

It should not be set to None, but NoOpCallback, right @isidentical ?

Right, my bad

@teije01 , your workaround would be to pass put(..., callback=fsspec.callbacks.NoOpCallback()) for now

Running into this too - I think there needs to be another if callback is not None check here:
https://github.com/dask/gcsfs/blob/main/gcsfs/core.py#L918

This should do it?
--- a/gcsfs/core.py
+++ b/gcsfs/core.py
@@ -15,6 +15,7 @@ import warnings
 import weakref

 from fsspec.asyn import sync_wrapper, sync, AsyncFileSystem
+from fsspec.callbacks import NoOpCallback
 from fsspec.utils import stringify_path, setup_logging
 from fsspec.implementations.http import get_client
 from .retry import retry_request, validate_response
@@ -896,6 +897,7 @@ class GCSFileSystem(AsyncFileSystem):
         # enforce blocksize should be a multiple of 2**18
         if os.path.isdir(lpath):
             return
+        callback = callback or NoOpCallback()
         consistency = consistency or self.consistency
         checker = get_consistency_checker(consistency)

With these changes, my test passes. Howver this should probably also include a change on the cases
if callback is not None:

found on https://github.com/dask/gcsfs/blob/f0cd0ef45d46aa2e079d29da738ce61cbd10c6e7/gcsfs/core.py#L905-L906 and
https://github.com/dask/gcsfs/blob/f0cd0ef45d46aa2e079d29da738ce61cbd10c6e7/gcsfs/core.py#L933-L934

Wondering why these tests are skipped.
https://github.com/dask/gcsfs/runs/3701196719?check_suite_focus=true#step:6:59
Any one of the put tests would have caught this.

if callback is not None:

Right, callback will never be None now

why the test_get_put tests are skipped

I cannot get them to work with vcrpy. They work against the real GCS. Maybe vcrpy is confused by having many similar requests in flight at once.

Is the VCR recordings the only thing that is blocking this?

For the original issue, nothing is blocking except to make the PR. It would be nice to test, thought.
For the get/put test skip, yes, it is only vcr that is preventing them from running (and they would have caught this problem).


Remove $charset

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
yes

Tests pass?
no

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

The separate charset property is no longer needed.
Both MySQL and PostgreSQL support setting charset via the dsn.

Merged. Thank you!


[Lecture4][0326] Questions about fast approximation in Harris corner detection

@yjyoo3312 I have a question about fast approximation in harris corner detection!

As you can see in this figure's highlighted formula, the theta value is computed using eigenvalues of matrix M.
But you mentioned that the benefit of this fast approximation is We do not need to calculate Eigenvalue.
How can I understand this part?
Thank you! :)

@jeonghyunpark2002 Sorry for the late reply!
I believe today's course will help the understanding of the questions.
https://github.com/PiLab-CAU/ComputerVision-2401/blob/8e5333a6387887b88dbabe67cff0bad52a0c6165/lecture4/utils.py#L201
Here's the code snippet. It demonstrates how we compute the response theta, bypassing the need for eigenvalue calculations.
The formula, lamda_1*lambda_2 - alpha(lambda_1+lambda_2)^2, has been deduced by (brilliant) mathematicians to achieve the same result. This allows us to indirectly incorporate our initial criteria for the eigenvalues at the corner points (requiring both to be significant) within the response map, eliminating the necessity to calculate eigenvalues.
Thank you:)

Thank you for the detailed explanation about my question 😄


Rolling back markdown-translatable

WIP: do not merge please

This change is

Should be good to review now!  Thank you!

Testable @ https://5fbd0a1c4527ee012211d203--tc-create-app.netlify.app/


max_axis() and min_axis() - intended behaviour?

Godot version:  v3.2.beta3
The help file says max_axis() returns the axis that is "largest". However it is currently returning the axis that is highest. Vector3(-100,7,3).max_axis() will return AXIS_Y, while I would personally describe AXIS_X as the "largest", I don't think I'm alone on this.
Vector3 typically deals with 3D space, so I think retrieving the real largest vector axis even if it's negative would be the much more popular use-case for the majority of people. Tell me if you agree or disagree.
I am aware .abs().max_axis() can be used as a workaround.
If this is not a bug then the help file could be clarified.

This is intended behavior, and should not be changed.
Comparing by "largest" as you put it would require finding the absolute value of everything. This would add complexity which for most users would only end up producing the wrong output.
However, you're right that the documentation could be slightly clearer, so I added this to #34005.

Thanks for the clarification aaronfranke.


[Feature Request] select Add Item shortcut

Existing Component
是
Component Name
el-select
Description
now
when we need add an item to select, first need to input something in input ,then click the item in dropdown, it's inconvenience.
wish improve：
after input something in input, tap enter key to add item.
example
https://codepen.io/Yuliang-Lee/pen/pdYEzw

Use default-first-option: https://jsfiddle.net/jqat4sq5/


[Feature Request]: changing drawing background to white

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
White bachground also suits for using image on documents
Use Case
many different use cases eg  your sign on documents etc
Benefits
No response
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a SSOC'24 contributor
[X] I want to work on this issue

There is not an actual significance to this change, there is already option to change the Background.


Reorganize and make things more typed, as well as improve the CLI

I also improved the parsing of the websocket URL, so now it returns actual errors. A good thing to do after this would be to return the errors as plain Strings too, that way you don't get nasty debug-esque results.

I'm not sure if type-safe is the right word here - but it's definitely more typed than it was before.

Good reorganization, did you try that all subcommands work? If you can pass clippy cargo fmt -- --check I'll merge it.

Ran cargo fmt and fixed some nits from cargo clippy.  Also ran cargo fmt -- --check and it should pass now, at least it does locally.
All subcommands should be working fine now, with better errors on the CLI now (e.g. command recs when you type something wrong, and it lists out all the different choices). Everything shows up properly on my end, and testing some commands, they all work.
I will note that the user is now forced to input the URL for the websocket, but I don't see that as a big problem so long as the README (should I add that to the CLI as an error too?) tells them what to do.

I will note that the user is now forced to input the URL for the websocket, but I don't see that as a big problem so long as the README (should I add that to the CLI as an error too?) tells them what to do.

Yes, I'd like to keep the thing simple and not overengineered a default obsws url  and parameter --obsws for who wants to override it. Feel free to re-add the obs-cmd.toml support if you need it

No need, I'll just match on cli.websocket and provide default values if None, as well as wrap websocket as Option<ObsWebsocket>.

Can you check that the parameter --obsws continue to work also in the explicit way?
obs-cmd git:(master) ./target/debug/obs-cmd --obsws obsws://localhost:4455/secret info
Version: Version { obs_version: Version { major: 30, minor: 0, patch: 0 }, obs_web_socket_version: Version { major: 5, minor: 3, patch: 3 }, rpc_version: 1, available_requests: ["OpenSourceProjector", "OpenInputInteractDialog", "OpenInputFiltersDialog", "OpenInputPropertiesDialog", "OffsetMediaInputCursor", "GetMediaInputStatus", "ResumeRecord", "SetInputAudioSyncOffset",

I tested your branch but i gave me issue
obs-cmd git:(cleanups) ./target/debug/obs-cmd --websocket obsws://localhost:4455/secret info
Error: Handshake(ConnectionClosed(Some(CloseDetails { code: Library(4009), reason: "Authentication failed." })))

obs-cmd git:(cleanups) ./target/debug/obs-cmd --obsws obsws://localhost:4455/secret info
error: unexpected argument '--obsws' found

Usage: obs-cmd [OPTIONS] <COMMAND>

I renamed the argument to --websocket, which should get the point across better.

After mulling over the changes a bit more, I'm not seeing any regressions or major bugs; everything necessary should be handled. We validate the websocket URL as best we can (so it's valid when passed to the API) and the CLI should still be compatible aside from the --websocket flag change.
There are a few more possible cleanups in main.rs, but I'm going to save those for later.

I'd like to merge this, but it should behave like in master branch, with the default url and also with the explicit url

It not working there seems like a bug somewhere. I'll add some debug logging and take a peek.

Found the problem.
⬢ [crystalbox2:2023-07-29] ❯ cargo run -- -w obsws://localhost:4455/secret info
    Finished dev [unoptimized + debuginfo] target(s) in 0.05s
     Running `target/debug/obs-cmd -w 'obsws://localhost:4455/secret' info`
[src/main.rs:11] cli.websocket.clone() = Some(
    ObsWebsocket {
        hostname: "localhost",
        port: 4455,
        password: Some(
            "/secret",
        ),
    },
)
Error: Connect(Io(Os { code: 111, kind: ConnectionRefused, message: "Connection refused" }))

Try now.

Nope
it seems the url is not split correctly and maybe the default password is secret and not /secret. It shuould behave like https://github.com/grigio/obs-cmd/blob/master/src/main.rs#L42
➜  obs-cmd git:(cleanups) cargo run -- -w obsws://localhost:4455/secret info
    Finished dev [unoptimized + debuginfo] target(s) in 0.37s
     Running `target/debug/obs-cmd -w 'obsws://localhost:4455/secret' info`
Error: Connect(Io(Custom { kind: Uncategorized, error: "failed to lookup address information: Name or service not known" }))

Eugh. I keep messing up the logic. Looks like I split the hostname, not the password.
[src/main.rs:11] cli.websocket.clone() = Some(
    ObsWebsocket {
        hostname: "ocalhost",
        port: 4455,
        password: Some(
            "/secret",
        ),
    },
)

Idea still stands, I just did it wrong.

If there's anything else regarding this tool you'd like me to work on, poke me - I've been enjoying it, and if you're willing to listen to how it all works, I'd be happy to help teach you Rust.


AOT: Add utility json deserialization method

To support AOT we need to remove the usage inside the SDK of LitJson's JsonMapper which is not AOT safe. This PR adds a new Amazon.Util.Internal.JsonSerializerHelper.Deserialize common utility for handling deserialization. There are 2 different implementations of the method. .NET 6+ it uses System.Text.Json along with a JsonSerializerContext that uses a source generator to generate all of the deserialization code at compile removing reflection. For older .NET targets continue to use JsonMapper.
The goal is through the SDK you can replace the calls for JsonMapper with JsonSerializerHelper.Deserialize after defining your own JsonSerializerContext. So the code compiles with the same line of code regardless of targets stub classes were added for targets less then .NET 6 for the missing System.Text.Json types. Those types are not used for anything other then making a compatible method signature.

Can you also switch to the helper on public static RegionEndpoint Region getter and remove the using of ThirdParty.Json.LitJson;. Also I don't see why do we need using System.Text.Json.Serialization.Metadata;

The using System.Text.Json.Serialization.Metadata; in EC2InstanceMetadata.cs as an accident after repeated refactoring attempts. I have removed it.
This PR is to make sure we are happy with this pattern of abstracting the Json serialization. Once we are it will be used to replace the direct usages of JsonMapper throughout the SDK like your call out for RegionEndpoint.


2.1.10 version of vsix is missing

Hi,
Is it possible to upload the latest 2.1.10 version of vsix to the GitHub release?
Thanks,
Rima

The releases are uploaded to the VS Code marketplace. I only upload releases to the GitHub page if they are experimental or pre-releases. You can also get old releases from the marketplace.
And the latest release is 2.1.14.
Closing. Please ping if you still need support with this.

Hi @dbaeumer ,
Thank you for your response. We are downloading .vsix during the docker build so it is very convenient for us to download it from the releases ;) If you don't mind to upload it to the releases, we would very appreciate it :)
Thank you in advance,
Rima

@rimasirich actually I have to say no on this since I don't have any plans to maintain two places where I publish releases.
Are you using VS Code remote for docker? If so the devcontainer.json can contain extensions to install from the marketplace which will do all the magic for you. You can also have an .vscode/extensions.json in the workspace folder which list the extensions to install.


Very minor formatting changes

Changes proposed in this pull request:

Some files had BOM headers, these were removed so they're raw UTF8
Replaced the few instances of tabs with spaces
In the Pester tests if $PSVersion isn't defined then we define it so users can run Invoke-Pester

Has been tested on (remove any that don't apply):

Powershell 5.1
Windows 10

Stripped BOM headers not supported in PSv2, It fail to detect utf8

May be this is becase it really does not contain any non-ascii symbols, so it non-utf ? :)
But contain BOM on accident, so the topic should sound like 'convert unneeded utf to ascii' ?


update to "nightly" instead of "preview" for radar image

hi,
it seems the preview tag for linuxserver/radarr has been replaced with nightly.  any plans to update this image to use nightly?

Wasn't aware they had made this change
Just pushed updates, give docker hub some time to update the builds

https://github.com/mdhiggins/radarr-sma/tree/nightly


Safari browser for iOS & mac, editor itself doesn't work.

Specific issue to angular-summernote only (it does not exist on summernote).
Reproducible: Safari browser for iOS & mac, editor itself doesn't work.
You can't focus editable area, and cursor doesn't appear. So no question of further editing of text. It behaves as normal display div and not as a content-editable div.

I was having this problem.
For me the problem was that contenteditable="true" did not work when user-select: none CSS was applied to the element.
Solved by adding the following to a more specific CSS rule (i.e. the particular dialog that had my editor):
-webkit-user-select: initial;
user-select: initial;