The root of most evil

Long long ago, #686 started taking advantage of the fact that all the numeric quantities in geom are rounded to a few decimal places, by serializing smaller integers instead of full f64s. But that PR had a bug, one which @michaelkirk pointed out. This PR improves the unit tests to catch this problem, then fixes it.
The problem is this:

We construct a bunch of geometry in-memory. Every time we do Pt2D::new, we trim the floats to 4 decimal places.
We serialize the f64's as ints
We deserialize the ints, multiplying back to f64's
The in-memory geometry and the round-tripped saved-then-loaded geometry differ

This has extremely scary implications -- #689 hit one in the traffic simulation that I never bothered to dig into. But there are so many more, mentioned in #1061. When we construct a PolyLine most of the time, we guarantee that no adjacent points are equal (up to the epsilon implied by this rounding behavior). That means later we can get individual Line segments that have nonzero distance. The problem is, this guarantee held when we originally constructed the geometry, but sometimes after deserializing, we lost that guarantee, because the points changed very slightly. This has caused so much havoc.
An example of the problem in the unit test, before the fix:
tests::f64_trimming' panicked at 'Round-tripping mismatch!
input=            Pt2D { x: -138849.6769, y:<PHONE_NUMBER> }
json_roundtrip=   Pt2D { x: -138849.6769, y:<PHONE_NUMBER> }
bincode_roundtrip=Pt2D { x: -138849.6769, y:<PHONE_NUMBER> }', geom/src/lib.rs:198:17

196157.1725 in-memory gets turned into<PHONE_NUMBER>.
Next steps
If this fix is truly correct, it has very far-reaching implications. For example, https://github.com/a-b-street/abstreet/blob/aeb14c799df79c79fcffa3fd5b3052643056980a/map_model/src/map.rs#L884 actually just catches panics that I'm pretty sure were root-caused by this. I want to start digging out these hacks.
More short-term, I want to simplify a few things within geom. We have a custom PartialEq implementation for Pt2D here. I don't think this should be necessary, I'm going to just derive it. I also want to consider removing HashablePt2D and just making Pt2D internally use ordered_float, but that's less urgent. (And there's some current bug here where we violate the hash(x) == hash(y) implies x == y invariant; I need to dig into this...)
CC @BudgieInWA

I've tested a bit more, and am going to merge this. The next steps of cleaning up HashablePt2D and EPSILON_DIST are actually tricky. The problem is that Pt2D equality currently uses EPSILON_DIST (0.1 meters), but HashablePt2D hashes on more detailed f64's. I'll dig out of that hole separately. I think we usually just want to do raw comparison the trimmed f64's and stop doing approx_eq checks in many places.


Always use truncated printing by default

Use IOContext to control the behaviour.
Fix #40 @karlwessel
julia> using Measurements, Unitful

julia> x = pi ± (ℯ/100)
3.142 ± 0.027

julia> (x,)
(3.142 ± 0.027,)

julia> x * u"m"
3.142 ± 0.027 m

julia> println(IOContext(stdout, :error_digits=>0), x)
3.141592653589793 ± 0.02718281828459045

julia> println(IOContext(stdout, :error_digits=>1), x)
3.14 ± 0.03

julia> println(IOContext(stdout, :error_digits=>5), x)
3.141593 ± 0.027183

Codecov Report

Merging #43 into master will decrease coverage by 0.33%.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##           master     #43      +/-   ##
=========================================
- Coverage   96.64%   96.3%   -0.34%
=========================================
  Files          12      12
  Lines         537     542       +5
=========================================
+ Hits          519     522       +3
- Misses         18      20       +2

Impacted Files
Coverage Δ

src/show.jl
72.72% <81.81%> (-2.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e3bef...acb8c8b. Read the comment docs.

Works like a charm:
julia> using Measurements

julia> a = 10π ± π
31.4 ± 3.1

julia> a, a
(31.4 ± 3.1, 31.4 ± 3.1)

Also in legends of plots and everywhere else where i tested.
Thank you!

Cool, thanks for testing!


Only the first line in RewardDesc for Jobs Quests is displayed

Description of issue:
In the latest version of Jobs Reborn, only the first line in rewardDesc for Jobs Quests is displayed.

CONFIG SECTION (DELETE IF NOT RELEVANT):
        RewardDesc:
        - "Kill 50 zombies"
        - "Get 2000 for this!"

With the above config, this quest will only display "Kill 50 zombies" when you hover over it in /jobs quests

Server Type (Spigot/Paperspigot/etc): Paper-225
Server Version (using /ver): MC 1.14.4

Send a screenshot about the problem in game.

Here is a quest I've made in my config:
`      1:
    Name: "Lumberjack Daily Quest"

    Objectives:

    - Break;oak_log;50

    - Break;spruce_log;50

    - Break;birch_log;50

    - Break;jungle_log;50

    - Break;acacia_log;50

    - Break;dark_oak_log;50

    RewardCommands:

    - "money give [playerName] 1000"

    - "crate give to [playerName] Common 3"

    - "cmi toast [playerName] -t:challenge -icon:iron_axe &9Lumberjack Daily Quest"

    RewardDesc:

    - "&7Description: &6Break 50 of each type of log"

    - "&7Reward: &63 Common Keys and $1000"

    Chance: 90`

I would expect both the "Description:" and "Reward:" lines to show up when I hover over the quest in /jobs quests. This is how it worked in previous versions. But on the current version, only the first line (the one with "Description:") is displayed. I checked, and the same issue exists in the default config. Only the first line of RewardDesc is displayed.


Create namespace if it does not exist

I thought about this when I was adding a new stack for an existing
service and found myself debating between using chat to initialize
a repository for a 5th time (it's deployed to as many clusters)
just for namespace creation, or to do it manually and out-of-band.
Neither seemed like great options to me, so I figured, why couldn't
we just create the namespace on the fly if it doesn't exist?
I don't think the tradeoff of requiring a namespace to already
exist necessarily makes sense any longer, even though in the
majority of cases at Shopify it will.
The initializer already enforces that a namespace is given,
so we can guarantee this receives a non-empty value.
This makes kubernetes-deploy a little more plug-and-play with,
IMO, minimal drawbacks.

What have we done in the past?

What have we done in the past?

It currently will fail the deploy if the namespace does not exist.

Yeah, but how have we created in the past? Manually? Some spy command? Script?

Yeah, but how have we created in the past? Manually? Some spy command? Script?

spy cloud init creates the namespace (and also drops an ejson keys secret in it).
The downside is a significant decrease in control over app deployment to our tiers. I'm not sure I like the idea of making it that easy for any app to create namespaces... they would effectively be able to do so in any valid tier. In the case of apps (which is what we should be optimizing this script for IMO), I think requiring explicit, external steps to initiate a namespace migration is perfectly reasonable. Presumably the thing you're deploying for the 5th time is one of our own controllers, which will be involved in the new-cluster deploy story we need to figure out.
@Shopify/cloudplatform I think we should discuss this as a team.

@sirupsen for new namespace (e.g. staging) of existing project we created them with kubectl create namespace walrusser (same for undercloud)
I agree that it's a pain point right now when you create a staging stack and the namespace is missing, but at the same time I think we should be more strict about certain things and not automatically create the namespace.
If you intended to deploy to tier4 where the namespace is ready for you but accidentally deployed to tier1 where there's no such namespace, I'd prefer to be precautionary and fail early rather than automatically create the missing namespace.

I'd like to start annotating these namespaces for network policies at some point, so maybe this shouldn't live here? food for thought and I rly don't care what happens in the mean time
e.g.
# When a namespace opts into isolation, all traffic directed
# at pods in the namespace is blocked unless explicitly allowed
# by configuration on a NetworkPolicy object
# this is arguably the k8s equiv of --icc=false

# this is configured at the namespace level
apiVersion: v1
kind: Namespace
metadata:
  name: my-new-namespace
  annotations:
    net.beta.kubernetes.io/network-policy: |
      {
        "ingress": {
          "isolation": "DefaultDeny"
        }
      }

@JonPulsifer sounds like you'd be interested in https://github.com/Shopify/cloudplatform/issues/214


Restricting all references in where clause for gql

Suppose one is allergic and searches for an apartment that has no cat:
{
  Get {
    Things {
      Apartment (where: {
            path: ["hasPet", "Pet", "name"]
            operator: NotEqual
            valueString: "cat"
          }
      }){
        name
        hasPet {
          ... on Pet {
            name
          } } } } } }

Right now this query will return all apartments that have either no Pets at all or at least one pet that is not a cat. What would be needed is a NoneEqual operator that does enforce that none of the references has this value.

NoneEqual seems like an intuitive name for this operator to me. Possibly NoReferenceEquals to make it even more explicit?
Thoughts @bobvanluijt @laura-ham?

Note to myself on how to implement this: Since reference props are currently already nested objects in our ES mappings, we can have an inner query to find each reference where the condition is met at least once, then an outer query with must_not on the inner query like so: https://discuss.elastic.co/t/elasticsearch-must-not-on-all-elements-in-array/138390/3

Thoughts @bobvanluijt @laura-ham?

I leave this one to @laura-ham :-)

I'd say NoneEqual is most intuitive and best option for me.

Should this one stay open?


Fix race in etcd ListAndWatch

The etcd revision is updated to the latest revision on every pagination request. Any updates between the initial page and the final page could be lost and the watcher would never receive it until another update occurs for that key.
The fix is to use the revision from the first page.
This was found while investigating an issue we hit in production where newly created nodes/cilium agents would be missing IPs of pods from clusters connected via clustermesh. This seemed to only occur to pods created around the same time of the new node/cilium agent. While I can't say for sure yet whether this resolves the issue for us I felt confident that this is a bug regardless and wanted to expedite getting a fix merged.
This bug was originally added here https://github.com/cilium/cilium/pull/25469
and initially landed in v1.14.0

Huh, what are the odds.. This issue was brought up for discussion during the Cilium community meeting last week and I just reviewed/merged the equivalent fix at https://github.com/cilium/cilium/pull/34091 :sweat_smile: .
This gives me additional confidence that the fix should be the right one. I appreciate your diligence in tracking this down and proposing the PR!
Feel free to take a look over 34091 to see if it matches your understanding, but otherwise I think we will have to close this one out as it now conflicts with main because the fix is already applied.

@joestringer What a coincidence. Happy to see it fixed and being backported. The other PR looks good to me.

@joestringer do you have any insight into when we can expect a v1.14.x release with the fix? I am trying to determine whether we should build/deploy our own image or wait for a release. We see this issue regularly during our application upgrade process.

@dboslee sure, you can see the general guidance here: https://docs.cilium.io/en/stable/contributing/release/organization/#stable-releases .


Create production environment for codeforpoznan v3

https://github.com/CodeForPoznan/codeforpoznan.pl_v3/issues/385
:rocket:

done in https://github.com/CodeForPoznan/Infrastructure/pull/90


Update universe domain demos bazel google-cloud-cpp commit SHA

Update the version to a commit sha that has the demo code merged.

Scott will look at

renovate-bot has taken care of this, just need to remove the TODO from the code.


Remove unused eslint-plugin-cypress package

Build cache support
Remove unused eslint-plugin-cypress package
Refactor pagination calculation

Codecov Report

Merging #172 (761ee6a) into main (df40663) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #172   +/-   ##
=====================================
  Coverage   6.00%   6.00%
=====================================
  Files         43      43
  Lines       1650    1650
  Branches     272     271    -1
=====================================
  Hits          99      99
  Misses      1551    1551

Impacted Files
Coverage Δ

src/routes/details/Details.tsx
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df40663...761ee6a. Read the comment docs.


Missing information

https://docs.microsoft.com/en-us/microsoft-365/admin/manage/assign-licenses-to-users?view=o365-worldwide#assign-licenses-to-multiple-users
In the section "Assign licenses to multiple users" it should be mentioned that the "Active users" page has a limit of 40 users at a time and if you need to assign licenses for a large number of users, such as hundreds or thousands of users, use Powershell or group-based licensing in Azure Active Directory (Azure AD)
https://docs.microsoft.com/en-us/azure/active-directory/enterprise-users/licensing-groups-assign
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e42a261b-afb1-e8d4-e61d-c9d30cb71a00
Version Independent ID: 3649a463-b7d6-104a-608f-cfcf16b66cb5
Content: Assign licenses to users - Microsoft 365 admin
Content Source: microsoft-365/admin/manage/assign-licenses-to-users.md
Service: o365-administration
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@ssmiller60 Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/4905
Thanks
Sri


replace script tag's src attribute

what about just replace the script tag's  src attribute without create new file;
i have a file which name is index.ejs(who is a template for ejs or other template engine)
(index.ejs);
... <script src="index.js" ></script> ...
to
...  <script src="index.[hash].js"></script>  ...
course of i will upload static files to cdn server, but webserver will runs on ourself server,& i don't want to replace the tags manaul,
is there any idear?

Try {%=o.htmlWebpackPlugin.webpack.hash%} inside the template

@jantimon Thanks, works for me, but it should be {%=o.webpack.hash%}.

Oh - okay cool :+1:


@W-9745169 configurable guardrails

added guardrails mode to translator config
refactored guardrails and moved to a separate package

@jimevanssfdc ready for review

@jimevanssfdc addressed, pls feel free to merge if it's LGTM


value not formatted correctly after initial rendering

When I'm rendering the following code:
{{paper-pikaday
    value=date
    format="ddd, MMM Do, YYYY"
    onChange=(action (mut warranty.expiresOn))}}

the input element shows the date formatted as "YYYY-MM-DD". Only after opening the calendar and selecting a new date, the used format is applied.
I 'fixed' this by explicitly setting the date in the didInsertElement hook:
  didInsertElement() {
    this.set("date", moment(this.get("date")).format("ddd, MMM Do, YYYY"));
  }

Is this a bug or did I forget to pass an option and/or is there a better way/workaround?
Thx.

Hmmm looks like a bug. The format specified should overwrite the default format? could you recreate this problem in a repo and send me the link

I forked your repo and reproduced the bug in this commit. Hope this will give you enough input?


Bump token plugin versions to use latest RCs

also fix some site and email references.

Signed-off-by: Wade Barnes<EMAIL_ADDRESS>

This is preparation for a Sovrin RC release.


[Feature]Execute multiple statements in a sql node

Execute multiple statements in a sql node, I use a semicolon to separate, the execution reports a syntax error

I will implement this feature
The implementation logic is as follows:

If it is a query type statement, only the first query statement is executed
If it is a non-query type statement, it will be divided according to a semicolon and executed sequentially
what do you think about?

我将会实现这个feature
实现逻辑如下：

如果是查询类型的语句，只执行第一条查询语句
如果是非查询类型的语句，将会根据分号进行划分，依次执行

你有什么想法？

I replace the demands put forward by netizens, your solution is very good, thank u.


MSDKUI-2170: Update cocoapods version.

Signed-off-by: Piotr Szmyt<EMAIL_ADDRESS>

Codecov Report

Merging #146 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   87.55%   87.53%   -0.03%
==========================================
  Files          89       59      -30
  Lines        5932     3683    -2249
==========================================
- Hits         5194     3224    -1970
+ Misses        738      459     -279

Flag
Coverage Δ

#ios
87.53% <ø> (-0.03%)
:arrow_down:

Impacted Files
Coverage Δ

MSDKUI_Demo/IconButton.swift

MSDKUI_Demo/OptionsViewController.swift

MSDKUI_Demo/ManeuversOverviewViewController.swift

MSDKUI_Demo/GuidanceDashboardViewController.swift

MSDKUI_Demo/ExtensionArray.swift

MSDKUI_Demo/RouteViewController.swift

MSDKUI_Demo/ExtensionUITableViewCell.swift

MSDKUI_Demo/ExtensionBundle.swift

MSDKUI_Demo/ExtensionNMAMapMarker.swift

...UI_Demo/GuidanceDashboardTableViewDataSource.swift

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420bd16...a6282fd. Read the comment docs.


How can I get a list of Virtual Machines in the Service Management API?

https://github.com/Azure/azure-sdk-for-net/blame/master/src/ServiceManagement/Compute/ComputeManagement/Generated/VirtualMachineOperations.cs
Here is the current service management Virtual Machine operations and there is no GetAll  or any way to search for VMs as far as I can tell. Is this just a bug that this operation is missing from the API ?
cc @hyonholee @stankovski @jeffwilcox ???

@erichexter This is the RDFE API for compute.  Any new APIs would be in the ARM library for compute

Im sorry i don't know what this is: RDFE  ?

Hi Erich,
Did you find what you need?  If not, here is the direct link: https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.management.compute?view=azure-dotnet and here is a link to a stack overflow question for the same: https://stackoverflow.com/questions/21738152/how-to-get-list-of-virtual-machines-in-windows-azure-programatically
If this does not answer your question, please re-open with more information on your use case.


ldc.eh: Improve GC-less exception behaviour

With the recent changes to remove GC usage from exception handling, _d_exception is now manually allocated and deallocated. However, the initial solution failed to handle the case of
try { throw new Exception(""); }
finally { throw new Exception(""); }

To fix this issue, this PR adds an additional field to ActiveCleanupBlock to store _d_exception instances in. The _d_exception for a given exception is no longer necessary during chaining, making it an ideal place to destroy older instances.
To verify that the above fix works correctly, this PR also adds opt-in verification (debug = EH_verifyExceptionStructLifetime with debug = EH_personality simultaneously enabled) that keeps track of the number of exception structs active at any given time.
To round out the nogc-related changes, this PR also implements a fixed memory pool, implemented with a free list, that allows for O(1) allocation/deallocation for up to N structs. This is used for ActiveCleanupBlock and _d_exception, both of which use N = 8.

Updated to address the issues mentioned. I have reservations about FixedPool's lazy initialisation scheme, but I can't see a better way of doing it without requiring more effort on the user's part (i.e. a post-creation initialisation method). I was going to use a static opCall, but that would break with the use of internal pointers.
A potential solution that comes to mind is the use of array indices instead of pointers. It'd be a trivial change, but I'm not sure it's worth it.


ActiveRecord update() returning TRUE?

This is likely a very minor, probably documentation-related issue.
According to the documentation ActiveRecord's update() method returns either integer or boolean. Is this right? We know that it can return FALSE when failing, but does it ever really return TRUE? When?
I am only bringing this up, because according to the same documentation delete() explicitly only returns integer or false, rather than boolean, which makes sense.

I guess you are right, it never returns true. It is the case for update (https://github.com/yiisoft/yii2/blob/master/framework/db/ActiveRecord.php#L525) and the same applies for updateInternal() (https://github.com/yiisoft/yii2/blob/master/framework/db/BaseActiveRecord.php#L733).
You could make a pull request to fix it.

fixed, thanks for reporting.


chore(rules): dedupe AVD-AWS-0180

Fixes: https://github.com/aquasecurity/trivy/issues/5065

@simar7 We must keep the no_public_db_access.cf.go and no_public_db_access.tf.go files, since they are used in the Rego rule. https://github.com/aquasecurity/trivy-policies/blob/main/rules/cloud/policies/aws/rds/disable_public_access.rego#L22-L25
Only RDS instances are checked in the Rego rule, but not RDS cluster instances as is done in the Go rule.  https://github.com/aquasecurity/trivy-policies/blob/main/rules/cloud/policies/aws/rds/no_public_db_access.go#L39-L50

@simar7 We must keep the no_public_db_access.cf.go and no_public_db_access.tf.go files, since they are used in the Rego rule. https://github.com/aquasecurity/trivy-policies/blob/main/rules/cloud/policies/aws/rds/disable_public_access.rego#L22-L25
Only RDS instances are checked in the Rego rule, but not RDS cluster instances as is done in the Go rule. https://github.com/aquasecurity/trivy-policies/blob/main/rules/cloud/policies/aws/rds/no_public_db_access.go#L39-L50

good catch, I merged your PR.


Update maintainers.yml

Please confirm this pull request meets the following requirements:

[X] I followed the contributing guidelines: https://github.com/github/india/blob/main/CONTRIBUTING.md.

Which change are you proposing?

[ ] Adding/updating open source project/s
[X] Adding/updating maintainer/s

Adding/updating open source project/s

[ ] The project was built in or receives significant contributions from India
[ ] The project has at least 100 stargazers

Why should this open source project be featured?

Please replace this line with an explanation of why you think these changes should be made.

Adding/updating maintainer/s

[X] Maintainer's location on their GitHub profile indicates as India
[X] Maintainer has approved this PR to be included on the website

What open source project/s does the individual maintain?

Please replace this line with GitHub URLs to projects that the individual/s maintains

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing page, or at least not a single one

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

PR cannot be merged due to following issues:

Maintainers

merrcury

Maintainer has less than 1 follower

@viveknigam3003 Please approve

Thanks for your contribution 💙
Unfortunately, since all the requested information is not provided in the PR body, we are closing this PR.
Feel free to reopen this PR once you have provided all the information in the PR body.


add new scope based on class

Add namespace option, when using the scope user, this way it is possible to register settings for different classes.

For reference: This will fix #51

I'm not sure or naming it namespace is the correct way to go, sounds a bit confusing to me. What about naming it something like group or settingGroup or collection ? Can we also make sure there is a testcase for this? :rocket:

Lots of things have happened since you created this PR 5 hours ago. I think this is a great idea. @rvanlaak had some very good comments that we should address first.

@juanolon see https://github.com/dmishh/SettingsBundle/issues/57#issuecomment-195725682

i'm back. the original idea of calling it namespace was, that the value of the option is actually a class namespace. i'll continue on the other thread..

btw. testcases. i may take a little bit longer with that, as i'm not use to write tests on php..

btw. testcases. i may take a little bit longer with that, as i'm not use to write tests on php..

Push something and we will help you.
Also, be aware that you need to rebase your work.


Normalize the "amount per age group" to it's proportion of the population

Or maybe add another layer on top the current graph, something like this:

Done :)


build: verify package.json integrity

Inspired by this comment, I created a script which verifies the integrity of all package.jsons of non-private packages.
I also made the @fuel-ts/testcases package private as it's only used in devDependencies, except for the fuels package where it was set as a dependency but nothing was being exported from it so I removed it from its dependencies. It had some mismatches with the root package.json, but I didn't see the need to actually fix it to match package.json and opted to make it private. I suppose a refactor could make this package go away completely, but I didn't investigate much.

Is this CI check really necessary? This seems a little overkill to me

@nedsalk Is this CI check really necessary? It seems a little overkill to me.

I see it as a win. Whoever updates node or pnpm in the future or creates a new package that differs in the author field will get a failing CI. It just automates @arboleya's comment and programmatically ensures a bit more consistency.


feat: adjustable/flexible dialog width

This function solves the problem (这个功能解决的问题)
The width of the dialog is currently static. Some components e.g. <n-transfer /> stick over the edges.
Expected API (期望的 API)
dialog.warning({
    ...
    width: '200px' || flexWidth: true
  });

I found it's already supported just not documented. So just use it.


fix(BolusExtraCommand): Fixes squareWaveExtendedTime

I was looking through the code and saw that the squareWaveDuration variable uses the same encodedData bytes as timeBetweenPulses in the init function while it doesn't do this in the data function.
I am not completely sure if the change is incorrect and the data function should be changed

I think this may be correct, thanks. Could you add a test for this? It would help verify that the encoding and decoding match.

During the make of the test, I found something else: there was a difference factor of 10 between encoding and decoding. After some testing, I think it is wrong on the encoding side, but @ps2 can you check that just to be sure?

Besides the mistake in the BolusExtraCommand intervalCounts calculation, there are a number of issues with the new tests. Having an encode test for a 2.6U immediate bolus with 1 second pulses with a 36U extended bolus over 1 hour is not a "typical  prime" as a prime bolus cannot be combined with anything and 30U is the maximum supported bolus size. Also, it would be good to make sure that the BolusExtraCommand handles extended boluses without an immediate bolus portion.  I think that the BolusExtraCommand encode function should be able to take a timeBetweenPulses of 0 when there is no immediate bolus. Supporting this requires the following one line change to OmnipodCommon/MessageBlocks/BolusExtraCommand.swift (since for non prime boluses I believe that the pod insists that the minimum time between pulses is 2 seconds -- even when there are no pulses).
@@ -70,7 +70,7 @@ public struct BolusExtraCommand : MessageBlock {
self.completionBeep = completionBeep
self.programReminderInterval = programReminderInterval
self.units = units

   self.timeBetweenPulses = timeBetweenPulses

   self.timeBetweenPulses = timeBetweenPulses > 0 ? timeBetweenPulses : .seconds(2)
   self.squareWaveUnits = squareWaveUnits
   self.squareWaveDuration = squareWaveDuration

}

Here's a my corrected and updated version of the BolusTests (assuming the above one line change for the no immediate bolus extended boluses). These samples were all taken from real life examples captured in the openomni wiki and described in https://github.com/openaps/openomni/wiki/Command-17-Bolus-extra.
diff --git a/OmniBLETests/BolusTests.swift b/OmniBLETests/BolusTests.swift
index bebf053..9c8c7e7 100644
--- a/OmniBLETests/BolusTests.swift
+++ b/OmniBLETests/BolusTests.swift
@@ -63,6 +63,50 @@ class BolusTests: XCTestCase {
let cmd = BolusExtraCommand(units: 2.6, timeBetweenPulses: .seconds(1))
XCTAssertEqual("170d000208000186a0000000000000", cmd.data.hexadecimalString)
}
+

func testBolusExtraSquareWave() {

   // 6.0U combo bolus with 2.0U immediate and 4.0U over 3 hours

   // 17 0d 3c 0190 00030d40 0320 00cdfe60

   do {

       let cmd = try BolusExtraCommand(encodedData: Data(hexadecimalString: "170d3c019000030d40032000cdfe60")!)

       XCTAssertEqual(false, cmd.acknowledgementBeep)

       XCTAssertEqual(true, cmd.completionBeep)

       XCTAssertEqual(.minutes(60), cmd.programReminderInterval)

       XCTAssertEqual(0.0, cmd.units)

       XCTAssertEqual(.seconds(2), cmd.timeBetweenPulses)

       XCTAssertEqual(1.0, cmd.squareWaveUnits)

       XCTAssertEqual(.hours(1), cmd.squareWaveDuration)

   } catch (let error) {

       XCTFail("message decoding threw error: \(error)")

   }

   // Encode 1.0U extended bolus over 4.5 hours with nothing immediate

   let cmd = BolusExtraCommand(units: 0.0, timeBetweenPulses: 0, squareWaveUnits: 1.0, squareWaveDuration: .hours(4.5))

   XCTAssertEqual("170d00000000030d4000c804d3f640", cmd.data.hexadecimalString)

}
func testBolusExtraOddPulseCount() {
// 17 0d 7c 00fa 00030d40<PHONE_NUMBER>00

Is is very important to make the identical changes to rileylink repo in the OmniKit/OmnipodCommon/MessageBlocks/BolusExtraCommands.swift and to OmniKitTests/BolusTests.swift files!

@itsmojo Sorry for the last commit, but I applied your feedback in the lastes commit

Square wave fixes addressed in this PR: https://github.com/LoopKit/OmniBLE/pull/69


Flagger addon pattern with nginx meshprovider

Issue #, if available:
Description of changes:
Created a functional pattern example of my addon using canary files.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Eli1123 Please confirm if you are still working on this PR. No activity for couple of months.

@Eli1123 Planning to make progress on this PR?

@Eli1123 Planning to make progress on this PR?

Sorry, missed this. Currently not planning to continue my intern project here as other projects are keeping me busy. Perhaps later down the road but if someone else wishes to pick up where I left off in the mean time they can feel free to do so.


use latest version of hls.js, and enable fetch loader?

Could the player use latest version of hls.js, and enable fetch loader, other than xmlhttprequest loader?

@gmluo2 this repository its just a react wrapper to hls.js, it's easy fork the repository and do your changes.
If you need just hls.js updated with version 1.2.3, you can use https://github.com/marcosalberto/react-hls

I am maintaining, a fork with up to date dependencies, bug fixes, and a test suite here: https://github.com/cgilly2fast/react-hls


[ASR Microservice] Incompatible parameters with LLM service for ASR Microservice

This bug was found when validating the example of AudioQnA, the mega service orchestrates ASR and LLM microservices in this example in the pipeline.
The example is okay for mega service pipeline in docker because mega service handle the pipeline data transformation, however, these microservices can not work well in Kubernetes due to the incompatible parameters between ASR and LLM microservices.
Suggest that the microservices should follow the unification API definition in LLMParamsDoc in Mega service if they want to work with LLM service together.

Hi @zhlsunshine , https://github.com/opea-project/GenAIComps/pull/341 is already merged and you can use it directly on k8s :)

Hi @Spycsh, thanks so much, we would validate it, then close this issue if it's okay!

Hi @Spycsh and @lkk12014402, I updated the code from main branch of GenAIComps, then I deployed the AudioQnA example in my K8s cluster, however, I still get below error information:
Error for whisper service:

Error for speecht5 service:

Not sure about that there may be necessary sync with OneClick team, @yongfengdu and @lianhao

@zhlsunshine PR #406 change the in container user from root to user with uid=1000. This could cause a file permission issue between old and new model data cache. Please go into your model data cache directory in your host, and do a chmod 777 to all the files under your model data cache dir.

Hi @lianhao, thanks for your replying, go for the help offline.

It's okay now, let me close this issue.


Add guide for upgrading to v0.18.x

Description of your changes
Adds a guide for handling breaking API changes while upgrading to v0.18.x.
This PR also fixes an issue with late initializing during importing a resource which causes a nil pointer exception.
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
In progress...

[x] Test clean migration by upgrading from v0.17.0 to latest master

[x] With no managed resource

[ ] Test with broken package upgrade from v0.17.1 to latest master

[x] Revert with no managed resource
[ ] Revert with nodepool and gkecluster as managed resources
[x] Fix Upgrade with no managed resource
[ ] Fix Upgrade with nodepool and gkecluster as managed resources, import as stable

[ ] Test clean migration by upgrading from v0.17.1 to latest master

[x] With no managed resource
[x] With a Bucket & CloudMemorystore - no nodepool or gkecluster
[x] With nodepool and gkecluster as managed resources, import as stable
[x] With nodepool and gkecluster as managed resources, import as beta
[ ] With nodepool and gkecluster as part of a composition, import as stable

Install platorm-ref-gcp configuration using package registry.upbound.io/upbound/platform-ref-gcp:v0.0.5
Create example network and cluster resources there.
Follow migration guide and upgrade to provider-gcp latest master
Upgrade configuration package to registry.upbound.io/hasan/test-platform-ref-gcp:v0.0.6 which is built from this PR

Tested with the scenarios listed in the PR description. All passed except the one with composition seems to be a bit tricky, new composition resulted in a new cluster resource ignoring the imported one. I guess I will need one more step to make sure that previous composite resources bind the imported ones.
kubectl get clusters.container.gcp.crossplane.io
NAME                                   READY   SYNCED   STATE     ENDPOINT        LOCATION   AGE
platform-ref-gcp-cluster-mwx8t-5j9hv   True    True     RUNNING   <IP_ADDRESS>   us-west2   11m # <--- imported one
platform-ref-gcp-cluster-mwx8t-bzk59   False   False                              us-west2   10m


Flake8 non-formatting changes

This PR contains a series of patches to resolve flake8 violations, which are not just code formatting.
The ignored violations are appended to tox.ini, so now flake8 --config tox.ini should pass without an error.
This patch series depends on #422 , so that one can run the unittests on a standard development environment.
All Submissions:

[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you added an explanation of what problem you are trying to solve with this PR?
[x] Have you added information on what your changes do and why you chose this as your solution?
[ ] Have you written new tests for your changes?
[x] Does your submission pass tests?
[x] This project follows PEP8 style guide.

Thank you! Some of those conventions may change, as I think they are in conflict with pysaml2's ruleset and conventions (which will probably be shared with this project).
But for now this is an improvement ;)


Lack of information on reports for images with no vulnerabilities found

Hi,
I'm using clairctl to create reports from the Clair image analysis, also performed using clairctl. The report issued for a compromised image is information-rich, showing the number of vulnerabilities found and describing each one of it. However, reposrts issued for "clean images" does not show information like "no vulnerabilities found".
Bad Report:

Good Report:

I'm missing the "Total: 0 Vulnerabilities: 0" on the bad report.
Is this expected or am I doing something wrong?
PS: Using 2.0.1
Thanks!
Paulo

Clair need to sync the security data from the NVD and parse those meta data save into postgres DB.
If you postgres DB is null. the report will show "no vulnerabilities found".

Hi @tieyi0404
I don't think this is the problem. I use the same database to perform analysis on other images. My point here is not the lack of vulnerabilities OR the scanning quallity, but the absense of "Total: 0 Vulnerabilities" text on the report for a scanned image with no issues.
The lack of this piece of information make report interpretation unclear as I'm able to see only image SHA and the repository/image name.
This is what I'm expecting:

Thanks!
Paulo

I Am also having same issue. any updates?


Render model

Search before asking

[X] I have searched the MuZero issues and found no similar bug report.

🐛 Describe the bug
I was trying to render my model and see how it performs on the Atari game breakout, but I encounter this error and don't know how to resolve this:
TypeError: render() missing 1 required positional argument: 'mode'
Add an example
Stack Trace:
0. Train
1. Load pretrained model
2. Diagnose model
3. Render some self play games
4. Play against MuZero
5. Test the game manually
6. Hyperparameter search
7. Exit
Enter a number to choose an action: 3
Testing 1/1
(SelfPlay pid=16394) /usr/local/lib/python3.7/dist-packages/ale_py/roms/__init__.py:94: DeprecationWarning: Automatic importing of atari-py roms won't be supported in future releases of ale-py. Please migrate over to using `ale-import-roms` OR an ALE-supported ROM package. To make this warning disappear you can run `ale-import-roms --import-from-pkg atari_py.atari_roms`.For more information see: https://github.com/mgbellemare/Arcade-Learning-Environment#rom-management
(SelfPlay pid=16394)   _RESOLVED_ROMS = _resolve_roms()
(SelfPlay pid=16394) A.L.E: Arcade Learning Environment (version 0.7.4+069f8bd)
(SelfPlay pid=16394) [Powered by Stella]
(SelfPlay pid=16394) /usr/local/lib/python3.7/dist-packages/gym/utils/seeding.py:160: DeprecationWarning: WARN: Function `hash_seed(seed, max_bytes)` is marked as deprecated and will be removed in the future.
(SelfPlay pid=16394)   "Function `hash_seed(seed, max_bytes)` is marked as deprecated and will be removed in the future. "
(SelfPlay pid=16394) /usr/local/lib/python3.7/dist-packages/gym/utils/seeding.py:204: DeprecationWarning: WARN: Function `_bigint_from_bytes(bytes)` is marked as deprecated and will be removed in the future.
(SelfPlay pid=16394)   "Function `_bigint_from_bytes(bytes)` is marked as deprecated and will be removed in the future. "
(SelfPlay pid=16394) /usr/local/lib/python3.7/dist-packages/gym/utils/passive_env_checker.py:98: UserWarning: WARN: We recommend you to use a symmetric and normalized Box action space (range=[-1, 1]) https://stable-baselines3.readthedocs.io/en/master/guide/rl_tips.html
(SelfPlay pid=16394)   "We recommend you to use a symmetric and normalized Box action space (range=[-1, 1]) "
(SelfPlay pid=16394) /usr/local/lib/python3.7/dist-packages/gym/utils/passive_env_checker.py:234: UserWarning: WARN: Future gym versions will require that `Env.reset` can be passed `options` to allow the environment initialisation to be passed additional information.
(SelfPlay pid=16394)   "Future gym versions will require that `Env.reset` can be passed `options` to allow the environment initialisation to be passed additional information."
Traceback (most recent call last):
  File "muzero.py", line 680, in <module>
    muzero.test(render=True, opponent="self", muzero_player=None)
  File "muzero.py", line 405, in test
    muzero_player,
  File "/usr/local/lib/python3.7/dist-packages/ray/_private/client_mode_hook.py", line 105, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/ray/worker.py", line 1831, in get
    raise value.as_instanceof_cause()
ray.exceptions.RayTaskError(TypeError): ray::SelfPlay.play_game() (pid=16394, ip=<IP_ADDRESS>, repr=<self_play.SelfPlay object at 0x7fbe5d7acf10>)
  File "/content/drive/MyDrive/muzero-general/self_play.py", line 126, in play_game
    self.game.render()
  File "/content/drive/MyDrive/muzero-general/games/breakout.py", line 198, in render
    self.env.render()
  File "/usr/local/lib/python3.7/dist-packages/gym/core.py", line 343, in render
    return self.env.render(**kwargs)
  File "/usr/local/lib/python3.7/dist-packages/gym/wrappers/order_enforcing.py", line 51, in render
    return self.env.render(**kwargs)
  File "/usr/local/lib/python3.7/dist-packages/gym/wrappers/env_checker.py", line 55, in render
    return passive_env_render_check(self.env, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/gym/utils/passive_env_checker.py", line 310, in passive_env_render_check
    return env.render(**kwargs)
TypeError: render() missing 1 required positional argument: 'mode'

Environment
No response
Minimal Reproducible Example
No response
Additional
No response

downgrade gym to 0.21.0 may solve your problem


403 New uploads are temporarily disabled.

Uploading distributions to https://upload.pypi.org/legacy/
INFO     dist/cator-1.0.5-py2.py3-none-any.whl (20.6 KB)
INFO     dist/cator-1.0.5.tar.gz (16.5 KB)
INFO     password set by command options
INFO     username: __token__
INFO     password: <hidden>
Uploading cator-1.0.5-py2.py3-none-any.whl
25l
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/[31](https://github.com/mouday/cator/actions/runs/8464541416/job/23189386667#step:7:32).4 kB • --:-- • ?
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 31.4/31.4 kB • 00:00 • 102.8 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 31.4/31.4 kB • 00:00 • 102.8 MB/s
25hINFO     Response from https://upload.pypi.org/legacy/:
         403 New uploads are temporarily disabled. See
         https://pypi.org/help/#admin-intervention for more information.
INFO

           <title>[40](https://github.com/mouday/cator/actions/runs/8464541416/job/23189386667#step:7:41)3 New uploads are temporarily disabled. See
         https://pypi.org/help/#admin-intervention for more information.</title>

403 New uploads are temporarily disabled. See
         https://pypi.org/help/#admin-intervention for more information.

           Access was denied to this resource.

         New uploads are temporarily disabled. See
         https://pypi.org/help/#admin-intervention for more information.

ERROR    HTTPError: 403 Forbidden from https://upload.pypi.org/legacy/
         New uploads are temporarily disabled. See
         https://pypi.org/help/#admin-intervention for more information.

https://github.com/mouday/cator/actions/runs/8464702877/job/23189882005

Also getting this from CLI.
py -m twine upload .\dist\wagtail_editorjs-1.4.4.tar.gz
Uploading distributions to https://upload.pypi.org/legacy/
Uploading wagtail_editorjs-1.4.4.tar.gz
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 195.5/195.5 kB • 00:00 • 499.6 kB/s
WARNING  Error during upload. Retry with the --verbose option for more details.
ERROR    HTTPError: 403 Forbidden from https://upload.pypi.org/legacy/
         New uploads are temporarily disabled. See
         https://pypi.org/help/#admin-intervention for more information.

Have the same. The reason seems to be this: https://status.python.org/incidents/dc9zsqzrs0bv

Noticed the same issue when trying to publish a new version of an existing project too.

Like the message said, new uploads were temporarily disabled. More information was available at https://pypi.org/help/#admin-intervention, which linked to https://status.python.org/incidents/dc9zsqzrs0bv. We have now resolved this incident and uploads can resume.


code is not complete！

(Please note: The code in this repository is currently undergoing updates and is not yet complete. Stay tuned for the latest versions!)

(Please note: The code in this repository is currently undergoing updates and is not yet complete. Stay tuned for the latest versions!)

Thank you, sir! Look forward to your full version of the code. I wish you a good paper!

@clement-chupin I was reading your paper and trying to implement the code but I notice from the custom packages in train.py error was raise for not seeing the folder dataloader, train_configs and trainer.

Hi @Bunmsel,
Thank you for your interest in our work. The error you encountered is due to a few missing files. I plan to release the complete code this week, so please stay tuned.


isMisspelled() always returns false under Linux after publishing in Electron app

isMisspelled() returns the correct value when running in development Linux build. However, when releasing the app the method stops working.
Is it possible this is related to the app.asar that we are building? Are you aware of such issue?

@astoilkov is it resolved?

I just ran into this problem too. Is this npm package still monitored / maintained? Can anyone at least help me debug the issue?

FYI, for those finding this in the future, disabling asar fixes the issue.

So the crux of the issue is node-spellchecker expects these hunspell dictionary files to be available in a very specific directory although the docs never tell you that. If you are using electron-builder (and I recommend it) then you can add this to your json to fix the issue:
"extraResources": [       {         "from": "node_modules/spellchecker/vendor",         "to": "app.asar.unpacked/node_modules/spellchecker/vendor",         "filter": "**/*"       }     ],
At build time the above lines will get the dictionaries and place them in the right location. To use the system default directories on Linux would require a fork of this project, and I don't have time for it right now.

@cruzerld, could one use something like this to pull in the system installed dictionaries?
"extraResources": [
     {
        "from": "/usr/share/hunspell",
        "to": "app.asar.unpacked/node_modules/spellchecker/vendor/hunspell_dictionaries",
        "filter": "**/*"
      }
    ],


fix(cookbook): deadlinks

Closes #15

Deployed! FWIW deploying by way of the build.sh script really is no work, I have to drop into a shell to run the script that we use to merge PRs anyway.


Overlap between samples should be restricted to a threshold value, since train/val split is now automatic.

When preparing samples with high overlap (ex.: >25%), the automatic train/val split creates very similar samples in both sets. The evaluation on validation set is then largely overestimated.
Automatic split was implemented here: https://github.com/NRCan/geo-deep-learning/pull/123

Possible solution: Add warning for users also document on README.md


Model Optimization

🤔 What type of PR is this? (check all applicable)

[x] 🍕 Addition
[ ] ⌨ Productivity
[X] 🐛 Bug Fix
[X] 🔥 Optimization
[ ] ⚙ Configuration
[x] 🌟 Quality Of Life
[x] ✨ Enhancement
[ ] 📝 Documentation

📝 Description
Repaired most of the factory files and models for weapons, thanks to Braiam06
The barrel of the M134 and the chamber of the revolver can rotate
Thanks to the M134 model and texture files provided by Braiam06

🚦 Testing

[x] Client

🖼 Screenshots/Recordings
Video about rotating parts
https://cdn.discordapp.com/attachments/1128548815994101821/1159447630628257862/Desktop_2023.10.05_-_<IP_ADDRESS>.mp4?ex=65310ec0&is=651e99c0&hm=55cc8aa7dfb7045339101bc828756226eb9f7653a8a40f612a062222388fc044&
https://cdn.discordapp.com/attachments/1118470073254944798/1162837063985529013/Desktop_2023.10.15_-_<IP_ADDRESS>.mp4?ex=653d6368&is=652aee68&hm=8a25d202e38aac3fbed6b363598d8a8fb12c32448925d4cdef6d1e397e1823a8&

📖 Added to documentation?

[ ] 📜 README.md
[ ] 📓 Javadoc
[ ] 🍕 Comments
[x] 🙅 no documentation needed

bro, don't upload it yet, it needs to be configured

Wat

Why is this so big?

Why is this so big?

nice question

Nice one

Has been re-created under a cleaner form, new PR: #312


feat: support Basic Auth for Bitbucket Server

Closes: #12586
Signed-off-by: Patrick Jungermann<EMAIL_ADDRESS>Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@namco1992 would be great if you can give this change a try with your setup.

@pjungermann just chatted with @namco1992 and he's out sick. So I'm thinking that we merge this as is, and if it's still broken we can ship something out in the next release next week? Does that sound OK?

Or actually, I'm thinking that we wait, as I don't want to grow the surface of the integrations api unless we need it. Let's wait until he's back, and we get this in the next release next week instead.

After a bit of hacking I got this to work with the BitbucketDiscoveryProcessor.
Since the BitbucketDiscoveryProcessor uses the original BitbucketIntegrationConfig I had to change it to BitbucketServerIntegrationConfig, but after that it seems to work well, nice job! 👍

Thanks for this! Let's get it shipped in the --release next tomorrow and test it out! 👍

After a bit of hacking I got this to work with the BitbucketDiscoveryProcessor.
Since the BitbucketDiscoveryProcessor uses the original BitbucketIntegrationConfig I had to change it to BitbucketServerIntegrationConfig, but after that it seems to work well, nice job! 👍
Edit: this will be easier to use for the catalog once we get the catalog-backend-module-bitbucket-server in place.

FYI - Bitbucket Server introduced OAuth 2.0 support in there 7.20 Release i gave the Bitbucket Cloud Provider a try but its redirecting me to the static bitbucket.org url.
https://bitbucket.org/site/oauth2/authorize?response_type=code&redirect_uri=http ://localhost:7000/api/auth/bitbucket/handler/frame&scope=team&state=STATE&client_id=CLIENT_ID
According to this document looks like the bitbucket server url would be https://bitbucketserver.myorg.com/rest/oauth2/latest/authorize?client_id=CLIENT_ID&redirect_uri=REDIRECT_URI&response_type=code&state=STATE&scope=SCOPE&code_challenge=CODE_CHALLENGE&code_challenge_method=S256

@regicsolutions there is no auth provider for Bitbucket Server yet. The scaffolder would make use of a user token though if available.


Exclude pre-compiled packages matching excludes list

Description
There are some locally installed packages I don't want to install on my lambda function, such as coverage or mypy. They are in the excludes but somehow are still included in the final ZIP. This change prevents ignored packages from being included in the final ZIP file, resulting for me in a 30% reduction of the lambda size.
This works fine for me locally using Python3.7 and Python3.8
One caveat I just discovered is that patterns (like packagename*) will not be interpreted and will be used as plain strings.
Resulting output:
Downloading and installing dependencies..
 - psycopg2==2.7.7: Using locally cached manylinux wheel
 - pip==19.0.3: ignored, skipping...
 - mypy==0.720: ignored, skipping...
 - markupsafe==1.1.1: Using locally cached manylinux wheel
 - ipdb==0.12.3: ignored, skipping...
 - cryptography==2.8: Warning! Using precompiled lambda package version 1.9 instead!
 - coverage==4.5.4: ignored, skipping...
 - cffi==1.13.2: Using locally cached manylinux wheel
 - sqlite==python3: Using precompiled lambda package
Packaging project as zip.

GitHub Issues
I have not opened a GitHub issue first, I'm happy to do it if it's really required, but a PR likely describes more what I want to do :)

Coverage increased (+0.08%) to 73.047% when pulling fa76166b27dfbf46720ef7052d84beebc695779b on MickaelBergem:master into 80a6881f0ec0be525a8fd7835b5a1157f9e66100 on Miserlou:master.

Coverage increased (+0.08%) to 73.047% when pulling fa76166b27dfbf46720ef7052d84beebc695779b on MickaelBergem:master into 80a6881f0ec0be525a8fd7835b5a1157f9e66100 on Miserlou:master.


KeyError: 'result'

Hi @jrbartola ,
First, thanks for the program, it's awesome.
Second, do you know why I have that issue ?
REP/USD:

indicators:	rsi #0: 37.57571773 	bbp #0: 0.08632842/4.18769970
informants:
crossovers:

Is first run: True
Alert once for REP/USD rsi 30m
Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "app.py", line 94, in run
    self.behaviour.run(self.market_data, self.settings['output_mode'])
  File "/app/behaviour.py", line 74, in run
    self.notifier.notify_all(new_result)
  File "/app/notification.py", line 148, in notify_all
    self.notify_stdout(new_analysis)
  File "/app/notification.py", line 306, in notify_stdout
    self.notifier_config['stdout']['optional']['template']
  File "/app/notification.py", line 352, in _indicator_message_templater
    if analysis['result'].shape[0] == 0:
KeyError: 'result'

My config FYI :
settings:
  log_level: DEBUG
  update_interval: 60
  market_pairs:
    - REP/USD

exchanges:
  kraken:
    required:
      enabled: true

indicators:
  rsi:
    - enabled: true
      alert_enabled: true
      alert_frequency: always
      signal:
        - rsi
      hot: 50
      cold: 70
      candle_period: 30m
      period_count: 14
      mute_cold: true
  bbp:
    - enabled: true
      alert_enabled: true
      alert_frequency: always
      candle_period: 30m
      period_count: 20
      hot: 0.5
      cold: 1
      std_dev: 2
      signal:
        - bbp
        - mfi
      hot_label: 'Lower Band'
      cold_label: 'Upper Band'
      indicator_label: 'Bollinger Crossing'
      mute_cold: true

notifiers:
  stdout:
    required:
      enable: true
    optional:
      template: "{{exchange}}-{{market}}-{{indicator}}-{{indicator_number}} is {{status}}!{{ '\n' -}}"

Thanks in advance

Hi,
Are u working with the develop branch ?

Hi @laliux ,
Yes I am. Is it wrong ?

Is fine, .. seems a little bug with stdout notifier. I'm going to check it.
Btw, the most proven (and cool) notifier is Telegram. I recommend to use it.

Ok thanks, I will have a look at it.

@Atem18
Hi,
I wrote a fix and is ready to test. Just pull the latest develop branch.
Best


is there a way I can host an app in 2 different platforms

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have removed any sensitive information from my code snippets and submission.

Amplify Hosting feature
Not Applicable
Is your feature request related to a problem? Please describe:
I have a monorepo with two applications: one in React and another in Next.js. Each project has its own amplify.yml in its root folder. While I was able to build both applications in my Amplify, the CI/CD doesn't work properly because the app's platform should be 'Web' for React and 'Web compute' for Next.js. As a result, I need to manually change it every time I want to deploy one of them.
Also, a follow up question - is it possible to set the AMPLIFY_MONOREPO_APP_ROOT from one of the configuration files?
Describe how you'd like this feature to work
Generally, my goal is to connect both monorepo folders (react and nextjs) into 1 URL, i.e. https://example.com which is hosted on Amplify. Then, for every example.com/app2, this should show the Next.js app; otherwise, it should show the React app. I was able to achieve this with a rewrite, however, I wonder if there is a simpler way to do it that will also support CI/CD.

Any update on this one @Milan-Shah  @ArseniyKotov ?

Any update on this one @Milan-Shah @ArseniyKotov ?

No updates. We will work closely with our product owner and assign priority to this feature request.

Great !!!

Hopefully this comes out in next 2-4 years and version in Amplify ❤. Can not wait to you this in sibling products @Milan-Shah @mauerbac @ArseniyKotov . I am also interested in discussing this with you guys in this coming month as I am planning to visit New York. Seems like a fun feature request

Thanks @mauerbac  and @Jay2113  ❤. You guys are really AWEsoummmm.... (Awesome!!!!)

Duplicate of https://github.com/aws-amplify/amplify-hosting/issues/3907

Ummm. I apologize for duplicating issues u guys thought this is sumyathing else


Privacy for each form field

Ability to specify privacy for each field for the user, as an example - user can show their phone number for friends only.

Also would be good to extend the date of birth field so a user can choose between showing full entry (i.e. age etc) or just what day is their birthday (i.e. not showing age, just a date without the year)


Update README.md, added script to create bulk sites

Bulk creation of SharePoint online sites from CSV as mentioned in the idea by @pkbullock Bulk applying techniques #552

Hey @kzkalra, another great sample, thank you much appreciated 😁 - this should be live shortly 🎉


Periodic noise in flow based model?

Hi,
Thank you for your nice job. But I found that either your FloWaveNet or NVIDIA's WaveGlow has a problem of containing periodic noise.

Maybe this is caused by the squeeze operations, because I found that the frequencies of the periodic noise in WaveGlow are multiples of sample_rate // squeeze_factor. (for example, 16khz audio with squeeze_factor 8 may have periodic noise with 2khz, 4khz, 6khz and so on)
So do you any idea about how to solve this problem?

Thank you for the input! We're also experiencing these kinds of freq band artifact during experiments (as stated in the preliminary draft). We are now tracking down the possible root cause with follow-up experiments. We'll share our result soon along with the updated version of the draft!


no need to call the $render just using standard formatters

This way its more clear how the model is updated and you don't need to hack the $render os $setViewValue inside the directive

+1


Error in mysqldump backup logs with recent versions of mysql

Describe the bug
Error in mysqldump backup command:
mysqldump: Error: 'Access denied; you need (at least one of) the PROCESS privilege(s) for this operation' when trying to dump tablespaces

To Reproduce
Steps to reproduce the behavior:

View backup logs for recent versions of mysql.

Expected behavior
No error should be logged.
Screenshots
n/a
Additional context
This blog post describes the problem. The fix we need in Lagoon is to add this flag to all our mysqldump commands: --no-tablespaces.

I think we should do what is suggested here: https://github.com/drush-ops/drush/issues/4489#issuecomment-804773355

Seems like a simple win to just amend the k8up backup command to insert --no-tablespaces. But I do like the suggestion to make this the default with the /etc/my.cnf file, as this would prevent customers having the issue as well (this was brought up today in Slack).

the my.cnf settings file would get ignored by drush though - as drush uses --defaults-file automagically https://dev.mysql.com/doc/refman/5.7/en/option-file-options.html#option_general_defaults-file


Write state functionality

State is going to be updated by checks.
State is used for being able to provide the API with information about what the member/cluster is doing.
Idea is that the state should be written out (periodically) by each member to etcd; API then accesses and exposes data from etcd.

Wooooooo! 🔥

I think I may need to figure out how to give checks unique identifiers.

I went with uuid's for tagging inbound alert messages; seems to get the job done; using github.com/satori/go.uuid - already vendored.

Ignore my last comment. Checks have a name, a base64 encoded string that is used for instantiating the check. There should be no need to add any other identifiers.

Where's the base64 string getting passed that would define the check?

Really simple initial implementation - just dump state information on an interval. This may need to be further expanded in the future to be a bit more sophisticated.
Addressed in #64


mdoc-like .md support

Duplication of https://github.com/VirtusLab/scala-cli/issues/1231

@lwronski Would it be reasonable to reopen this? The markdown support in #1231 relates to running markdown files. While the main use-case of mdoc is having typechecked documentation. I don't know if the two are related on a technical level, but from a user point of view they are different. I also couldn't find any other open issue to track it.
Considering one of Scala CLI's strengths is how easy it is to make CLI apps or smaller-sized applications, I think typechecked documentation still falls within the scope and is very useful for open-source repos wanting to provide a typechecked readme.


Fix documentation for sidecard unlimited resources on Autopilot

Related to: https://github.com/GoogleCloudPlatform/gcs-fuse-csi-driver/issues/61
Can we fix the documentation to specify that this feature is not available on AutoPIlot?
https://cloud.google.com/kubernetes-engine/docs/how-to/persistent-volumes/cloud-storage-fuse-csi-driver#sidecar-container
This page is labeled both Autopilot and Standard.

Updated the doc: https://cloud.google.com/kubernetes-engine/docs/how-to/persistent-volumes/cloud-storage-fuse-csi-driver#sidecar-container with two notes:

Note: Autopilot might overwrite your sidecar container resource configuration. To learn more, see Resource requests in Autopilot.

Note: You cannot use value "0" to unset the sidecar container resource limits and requests on Autopilot clusters.

it seems it is possible now but I don't know the minimal GKE version.


[Proposal]: Create new DevOps/GitHub hack

Topic
The existing DevOps/GitHub What the Hack is both dated and a bit redundant in its structure. Some of the services highlighted in the original have since been released, and there are new features such as Codespaces and Copilot which aren't used. This new hack is has a more targeted agenda and provides and overview of a true day-in-the-life for a developer using GitHub.
Abstract/Learning Objectives

Using GitHub templates
Creating and configuring Codespaces for cloud-based development
Using Copilot as an AI pair programmer
Enabling protected branches to enforce rules
Enabling Codescanning to ensure new code doesn't introduce vulnerabilities
Using config as code and GitHub Actions to create an environment on Azure
Using GitHub Actions to enable continuous deployment

Delivery Date
2023-03-03
Authors
@geektrainer

Other
The hack is already built. Happy to make the necessary updates. This will be delivered next week for a customer.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

#578


perf: Improved Menu performance and Flip bugs

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

Codecov Report

Merging #680 (cedcb66) into v2.0 (91534b8) will decrease coverage by 0.04%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             v2.0     #680      +/-   ##
==========================================
- Coverage   79.29%   79.24%   -0.05%
==========================================
  Files         240      240
  Lines        4959     4949      -10
  Branches     1007     1004       -3
==========================================
- Hits         3932     3922      -10
- Misses        210      214       +4
+ Partials      817      813       -4

Impacted Files
Coverage Δ

packages/varlet-ui/src/menu-v2/props.ts
100.00% <ø> (ø)

packages/varlet-ui/src/select/example/index.vue
64.51% <ø> (+2.01%)
:arrow_up:

packages/varlet-ui/src/select/Select.vue
80.46% <50.00%> (+0.89%)
:arrow_up:

packages/varlet-ui/src/menu-v2/MenuV2.vue
77.57% <60.00%> (-0.87%)
:arrow_down:

packages/varlet-ui/src/menu/Menu.tsx
84.00% <0.00%> (-6.00%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix Failing SPP Tests

Attempting fix the SPP lmp tests that are failing on github actions with an SSL error, but run without problem in other enviornments
here is an action where they are failing: https://github.com/kmax12/gridstatus/actions/runs/5892948248/job/15983385496?pr=263
except from logs

self = Retry(total=0, connect=None, read=False, redirect=None, status=None)
method = 'GET'
url = '/arcgis/rest/services/MarketMaps/RTBM_FeatureData/MapServer/1/query?f=json&where=OBJECTID+IS+NOT+NULL&returnGeometry=false&outFields=%2A'
response = None
error = SSLError(SSLError(1, '[SSL: DH_KEY_TOO_SMALL] dh key too small (_ssl.c:1007)'))
_pool = <urllib3.connectionpool.HTTPSConnectionPool object at 0x7f703a8c9e70>
_stacktrace = <traceback object at 0x7f7039955fc0>

    def increment(
        self,
        method: str | None = None,
        url: str | None = None,
        response: BaseHTTPResponse | None = None,
        error: Exception | None = None,
        _pool: ConnectionPool | None = None,
        _stacktrace: TracebackType | None = None,
    ) -> Retry:
        """Return a new Retry object with incremented retry counters.

        :param response: A response object, or None, if the server did not
            return a response.
        :type response: :class:`~urllib3.response.BaseHTTPResponse`
        :param Exception error: An error encountered during the request, or
            None if the response was received successfully.

        :return: A new ``Retry`` object.
        """
        if self.total is False and error:
            # Disabled, indicate to re-raise the error.
            raise reraise(type(error), error, _stacktrace)

        total = self.total
        if total is not None:
            total -= 1

        connect = self.connect
        read = self.read
        redirect = self.redirect
        status_count = self.status
        other = self.other
        cause = "unknown"
        status = None
        redirect_location = None

        if error and self._is_connection_error(error):
            # Connect retry?
            if connect is False:
                raise reraise(type(error), error, _stacktrace)
            elif connect is not None:
  /home/runner/work/gridstatus/gridstatus/gridstatus/nyiso.py:448: UserWarning: Could not infer format, so each element will be parsed individually, falling back to `dateutil`. To ensure parsing is consistent and as-expected, please specify a format.
    queue["Proposed Initial-Sync Date"] = pd.to_datetime(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED gridstatus/tests/test_spp.py::TestSPP::test_get_status_latest - Runtim...
FAILED gridstatus/tests/test_spp.py::TestSPP::test_lmp_date_range[Markets.DAY_AHEAD_HOURLY]
FAILED gridstatus/tests/test_spp.py::TestSPP::test_get_lmp_historical[Markets.DAY_AHEAD_HOURLY]
FAILED gridstatus/tests/test_spp.py::TestSPP::test_get_lmp_latest_with_locations[Markets.REAL_TIME_5_MIN-Interface]
FAILED gridstatus/tests/test_spp.py::TestSPP::test_get_lmp_latest_settlement_type_returns_three_location_types
FAILED gridstatus/tests/test_spp.py::TestSPP::test_get_lmp_historical[Markets.REAL_TIME_5_MIN]
FAILED gridstatus/tests/test_spp.py::TestSPP::test_get_lmp_today[Markets.DAY_AHEAD_HOURLY]
FAILED gridstatus/tests/test_spp.py::TestSPP::test_get_lmp_today[Markets.REAL_TIME_5_MIN]
FAILED gridstatus/tests/test_spp.py::TestSPP::test_get_lmp_latest[Markets.REAL_TIME_5_MIN]
FAILED gridstatus/tests/test_spp.py::TestSPP::test_get_lmp_latest_with_locations[Markets.REAL_TIME_5_MIN-Hub]

I believe this issue is fixed as the SPP tests are no longer failing.


Unable to Delete File or Vectors.

There is no way to delete a file once uploaded. There should be a way to delete files that are uploaded. If you have an endpoint to do this please let me know.
Thanks

Expand the file - it is purge document.
UI will be changing soon for file manager to be more intuitive.


[FLINK-24851][Connectors / Kafka] KafkaSourceBuilder: auto.offset.reset is ignored

What is the purpose of the change
Creating KafkaSource like this:

val props = new Properties()
props.put("bootstrap.servers", "localhost:9092")
props.put("group.id", "group1")
props.put("auto.offset.reset", "latest")
val kafkaSource = KafkaSource.builder[String]()
      .setProperties(props)
      .build()

The actually used value for "auto.offset.reset" is "earliest" instead of configured "latest".
This occurs because "auto.offset.reset" gets overridden by startingOffsetsInitializer.getAutoOffsetResetStrategy().name().toLowerCase(). The default value for startingOffsetsInitializer is "earliest".
This behavior is misleading.
This behavior imposes an inconvenience on configuring the Kafka connector. We cannot use the Kafka setting "auto.offset.reset" as-is. Instead we must extract this particular setting from other settings and propagate to KafkaSourceBuilder.setStartingOffsets():
val kafkaSource = KafkaSource.builder[String]()
      .setProperties(props)
      .setStartingOffsets(
        OffsetsInitializer.committedOffsets(
          OffsetResetStrategy.valueOf(
            props.get(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG)
              .asInstanceOf[String]
              .toUpperCase(Locale.ROOT)
          )
        )
      )
      .build()

The expected behavior is to use the value of "auto.offset.reset" provided by KafkaSourceBuilder.setProperties() - unless overridden via KafkaSourceBuilder. setStartingOffsets().
https://issues.apache.org/jira/browse/FLINK-24851
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @AHeise could you please help to review the code? thank you.

@PatrickRen can you PTAL?

Thanks for the patch and sorry for my late response!
Basically I think this is not a bug and I left some comments in FLINK-24851. Feel free to continue the discussion in the ticket~

@PatrickRen can you PTAL?

@flinkbot run azure

@hililiwei The Flink Kafka connector resides in it's own repository nowadays, if this code change is still relevant, please open the PR in https://github.com/apache/flink-connector-kafka


Registers in the riscv-executor can hold fields.

tests failing

I thought you would tell me to squash before merging.


Lab Report: Usage analytics

Our first lab report. Tells users how to craft a basic usage analytics master page, with tutorial and XML included.
Of note: Instead of our camelCase capitalization as used in the experiments folder, I think we should go with kebab-case here. If we choose to eventually generate HTML from these reports, this will help with SEO.

@zachelrath Thanks for the comments! How is this looking now?


chore: rename cjs index file extension js to cjs

add to build script to rename commonJS index file for compatibility

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: Added --embed option to %%manim ManimMagic.

Overview: What does this pull request change?
Adds a --embed option to the %%manim magic that will embed the video data.  This resolves issue #2441.
Motivation and Explanation: Why and how do your changes improve the library?
Currently video data is embedded only if running on Google's CoLab platform, but there are other use-cases (relocatable notebooks) and this should be customizable.
Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

I think the code is complete, but need to figure out how to write tests.  Also, I have slightly abused config allowing users to set config.embed_video = True (or False to override CoLab).  Should add an official config option or just leave this as a mildly documented feature?

Any suggestions on how to test this change would be appreciated.  Only the _generate_file_name() function seems to be currently tested in tests/.  Am I missing some sort of testing that spins up a notebook and executes the magic?

In principle Images can be embedded too, so I changed the config option to simply embed and apply it to images as well.  The CoLab override only applies to videos, but the default for Image is generally True unless it is a URL.

I went ahead and fixed the issues raised in my code review via 1ec20177 -- from my point of view, this is good to go now.
Thanks again for your efforts!

This seems to have broken preview in jupyter notebooks.


Disallow additional properties in the cluster-aws schema

Cluster app values schemas must not allow arbitrary values on the root level, so that our user interface presents a clean overview of all properties in their categories.

Done


fix: set CONFIG_SCHEMA to accept configuration from config entries

Related Issues

Closes #19

Proposed Changes:

Sets CONFIG_SCHEMA to accept configuration from config entries. This change is not tested as hassfest workflow does the check to be sure it's set.
Testing:

n/a
Extra Notes (optional):

n/a
Checklist

[x] Related issues and proposed changes are filled
[x] Tests are defining the correct and expected behavior
[x] Code is well-documented via docstrings

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 95.109%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
599

Relevant Lines:
631

💛  - Coveralls


Large Figure in Native Resolution

Hi,
I am trying to save a figure at full resolution. It has been working fine for me with smaller images (see attached image and figure). When I try to do it with a larger figure, ~3.5M pixels, it is throwing away every other column of data and doubling each pixel's width in order to compensate (see the attached image "Large Figure Error Example.png").
I have been using the following command to export my figures:
export_fig('test_figure.png','-native')
When I render the image in MATLAB with opengl, zbuffer, or painter it looks good in the figure window.
I have tried exporting using the following renderings but I get the same results:
export_fig('test_figure.png','-native','-opengl') % This gives me the same results
export_fig('test_figure.png','-native','-zbuffer') % This gives the following warning: "Warning: Zbuffer is not supported for printing, using OpenGL instead." and then gives me the same results as opengl
export_fig('test_figure.png','-native','-painters') % This produces an image similar to opengl except that things seem smoothed/blurred over
I have also tried exporting as a tiff but it does not change anything.
I am using MATLAB R2016a. Also, I have made sure that I am using the latest version of export_fig.
The .fig file is too large to attach, so I've included a google drive link with all the files: https://drive.google.com/drive/folders/1Y7mj3SGhJT81MFrx_8lrFOGrBI2ACmnh?usp=sharing
Thanks,
Landon

If anyone else has this problem, I spent a while trying to solve my issue but could never figure out how to save my figure in full resolution. However, a super quick way to overcome the issue (at least in my case) was to just save the image using imwrite and set the resolution to the size of the image.

This is a natural outcome of how export_fig works: when you have a large image which is displayed inside a small figure, only some of the pixels are displayed. When export_fig outputs a screenshot of the figure, it only exports the visible pixels, without the higher-resolution pixels that are not visible.
If you want to export a high-resolution image (rather than a figure), don't use export_fig but rather Matlab's builtin imwrite function, which exports all pixels.


patch for broken regex in search

The current regex doesn't work when escaping double quotes with a backslash.

Thanks @kellengreen, we are working on a major refactor of the searchcommands sub-package and we'll look into this before we release it.

The searchcommmands package is refactored and changed now.

@kellengreen can we delete your branch?

Is it fixed?

@kellengreen it will be in the next release


PayPal RSD to USD conversion

PayPal RSD to USD conversion support added
Explanation:
Because PayPal is supported in Serbia but not supporting our national currency RSD I have created Payment conversion if invoices are in RSD to USD. The conversion is using 100% accurate conversion rate from national bank of Serbia (I provide the API for free) + 4% FEE for currency oscillations.
This doesn't have to be merged to the official module, rather as a customization or addon for Serbian boxbilling users.
Regards

Coverage decreased (-0.001%) to 41.478% when pulling 7e52bcd0b701f05e415493c11e097caa44a2edc4 on lukapaunovic:master into abf19c8edec5d2bfbcd038a98e93f5a3b174ac57 on boxbilling:master.


is the "position" attribute a real thing?

The docs mention that settable hardware objects should implement position, "a heuristic that describes the current position of a device as a single scalar, as opposed to the potentially multi-valued description provided by read()" [1]. As far as I can tell, this isn't a real thing? I don't see ophyd devices implementing position.
Any clarification would be appreciated :smile:
[1] https://blueskyproject.io/bluesky/hardware.html#position

https://github.com/bluesky/ophyd/blob/5734e401c887d8ddbe564daa840c8b8a4a1f7d5a/ophyd/epics_motor.py#L183-L192
https://github.com/bluesky/ophyd/blob/19237e3063889659637c880c3818c34e8c72e769/ophyd/positioner.py#L218-L226

Thanks for your response, @prjemian, I missed that!

I don't see ophyd devices implementing position.

All I actually did was look at the motor objects at https://try.nsls2.bnl.gov/, those do not implement position from what I can see?
Do we wish to enforce the position attribute in is_movable? Is it used by the run engine?

https://github.com/bluesky/bluesky/blob/4fab894bddbd4a563f28852ea3171b87140ae7b9/bluesky/preprocessors.py#L977
A quick search shows that it is only used once inside the library (used a few times in tests as well)
Even here, there is fallback behavior, so not 100% required

Yeah, my original observation was that my yaqc_bluesky.Device objects seem to work just perfect without position.

Not sure the bluesky package needs to use the ophyd .position property but instrument plans might make heavy use of this shortcut to motor.user_readback.get().  See for example this search for .position in the APS USAXS instrument repository:
https://github.com/APS-USAXS/ipython-usaxs/search?q=.position&unscoped_q=.position
It's a great tool for the command-line user and for user plans.

Ah, I see... :thinking:

Positioner objects should work without the .position property but users familiar with Bluesky will miss this shortcut if not provided.
Point of interest, I believe it was inherited into ophyd from the PyEpics support for the EPICS motor record.  Still, there, as a shortcut.

I can totally see why position is generally useful---I'm just wondering if we want to enforce it for all bluesky interface objects or have it be just an optional extra that ophyd does sometimes. I believe that @tacaswell told me that set is very flexable and supports interfaces with very rich state, so I wonder if position is unreasonable to expect of generic bluesky interfaces.
I appreciate that this isn't a very practical question... Personally all of my interfaces work fine with position so I'm happy to keep it.

set() is general for ophyd Signals.  position is specific to ophyd Positioner Devices.  If positioners subclass from ophyd.positioner.PositionerBase, they'll get the .positioner property.  Subclasses can override as they choose but it is provided.
Not used for ophyd Signals.  For those, there is a (similar) .value property which creates a warning now (means: use .get() instead of .value, at least for now).  The source code has some documentation on this.

I can totally see why position is generally useful---I'm just wondering if we want to enforce it for all bluesky interface objects or have it be just an optional extra that ophyd does sometimes.

It is an optional extra that ophyd does sometimes, primarily used when people are poking ophyd devices interactively, sans bluesky. We try very hard to avoid using .position or .get() or anything that communicates directly with hardware in bluesky or in bluesky plans, because it enables simulators like summarize_plan(...) ,check_limits(...), and the long-dreamed-of-but-not-yet-implemented estimate_time(...) to consume the plan without causing hardware interaction. That only works if plans are careful to avoid touching hardware in a way that bluesky cannot intercept.

As Dan implied, the bluesky RunEngine is not the only software that might review the actions of a plan.  Make sure your plans have instructions for actions, without actually acting on them.

OK, I think what I've heard is that y'all like the idea of position and think that it should stay a popular convention, but position should be considered an optional attribute for the movable interface.


--reporter-options flag is not working properly

Hello,
I trying to use different type of reporters( mocha: xunit, custom: mochawesome, mocha-junit-reporter ) with flag --reporter-options, but seems that this flag is not working properly.
When I run tests by mocha — all works fine.
Example of commands:

mocha my-test --reporter xunit --reporter-options output=reports/report-mocha.xml
mocha my-test --reporter mocha-junit-reporter --reporter-options mochaFile=reports/report-mocha.xml
mocha my-test --reporter mochawesome --reporter-options reportDir=reports,reportFilename=report-mocha

If I run the commands mentioned above with mocha-parallel-tests instead of mocha, the tests are performed successfully, but the report file is not created.
Versions:

node v6.9.1
mocha v2.5.3
mocha-parallel-tests v1.2.5
mocha-junit-reporter v1.13.0
mochawesome v2.0.2

Thank you. Will take a look on these holidays.

Unfortunately this is the same issue as #80. Bad news here is that this issue is at this time really hard to solve.

Reporters behaviour is fixed in mocha-parallel-tests@2


Respond correctly to 404 responses when communicating with the CCDH service

The CCDH Terminology Service now returns an HTTP 404 message when a field either doesn't exist or doesn't have known permissible values. This PR adds support for that to the Terminology Service communication library.
(This change is already present in PR #21, but we're working on that PR as a group, so this is a way of getting that change into sheet2linkml more quickly.)

This PR has now been merged into PR #28, closing.


Unable to cast date{32,64} to date{32,64}

Describe the bug, including details regarding any error messages, version, and platform.
It looks like I'm able to cast ints/string:
> import pyarrow as pa

> n_legs = pa.array([2, 2, 4, 4, 5, 100])
> animals = pa.array(["Flamingo", "Parrot", "Dog", "Horse", "Brittle stars", "Centipede"])
> names = ["n_legs", "animals"]

> batch = pa.RecordBatch.from_arrays([n_legs, animals], names=names)
> batch

pyarrow.RecordBatch
n_legs: int64
animals: string
----
n_legs: [2,2,4,4,5,100]
animals: ["Flamingo","Parrot","Dog","Horse","Brittle stars","Centipede"]

> schema = pa.schema([
>     ('n_legs', pa.int64()),
>     ('animals', pa.string()),
> ])
> pa.RecordBatchReader.from_batches(
>     schema,
>     [batch]
> ).cast(schema).read_all()

pyarrow.Table
n_legs: int64
animals: string
----
n_legs: [[2,2,4,4,5,100]]
animals: [["Flamingo","Parrot","Dog","Horse","Brittle stars","Centipede"]]

But it seems to fail with a date32:
> import pyarrow as pa
> from datetime import date
> birthday = [date(1990, 3, 1)]
> names = ["Fokko"]
> batch = pa.RecordBatch.from_arrays([birthday, names], names=['birthday', 'name'])
> batch
pyarrow.RecordBatch
birthday: date32[day]
name: string
----
birthday: [1990-03-01]
name: ["Fokko"]

> schema = pa.schema([
>     ('birthday', pa.date32()),
>     ('name', pa.string()),
> ])

> pa.RecordBatchReader.from_batches(
>     schema,
>     [batch]
> ).cast(schema).read_all()

---------------------------------------------------------------------------
ArrowTypeError                            Traceback (most recent call last)
Cell In[6], line 9
      1 schema = pa.schema([
      2     ('birthday', pa.date32()),
      3     ('name', pa.string()),
      4 ])
      6 pa.RecordBatchReader.from_batches(
      7     schema,
      8     [batch]
----> 9 ).cast(schema).read_all()

File /opt/homebrew/lib/python3.10/site-packages/pyarrow/ipc.pxi:800, in pyarrow.lib.RecordBatchReader.cast()
File /opt/homebrew/lib/python3.10/site-packages/pyarrow/error.pxi:154, in pyarrow.lib.pyarrow_internal_check_status()
File /opt/homebrew/lib/python3.10/site-packages/pyarrow/error.pxi:91, in pyarrow.lib.check_status()
ArrowTypeError: Field 0 cannot be cast from date32[day] to date32[day]

Same for date64:
---------------------------------------------------------------------------
ArrowTypeError                            Traceback (most recent call last)
Cell In[42], line 15
      4 schema = pa.schema([
      5     # ('date32', pa.date32()),
      6     ('date64', pa.date64()),
      7 ])
      9 batch = pa.RecordBatch.from_arrays(data, schema=schema)
     12 table = pa.RecordBatchReader.from_batches(
     13     schema,
     14     [batch]
---> 15 ).cast(schema).read_all()
     17 assert table['date32'][0].as_py() == dt
     18 assert table['date64'][0].as_py() == dt

File /opt/homebrew/lib/python3.10/site-packages/pyarrow/ipc.pxi:800, in pyarrow.lib.RecordBatchReader.cast()
File /opt/homebrew/lib/python3.10/site-packages/pyarrow/error.pxi:154, in pyarrow.lib.pyarrow_internal_check_status()
File /opt/homebrew/lib/python3.10/site-packages/pyarrow/error.pxi:91, in pyarrow.lib.check_status()
ArrowTypeError: Field 0 cannot be cast from date64[ms] to date64[ms]

This looks like a valid cast operation to me. Please advise. Happy to create a PR, if someone can point out the place where I should add the test would be very helpful, since I'm not familiar with the codebase :)
> pa.__version__
'16.1.0'

Component(s)
C++

Issue resolved by pull request 43192
https://github.com/apache/arrow/pull/43192


feat: load gzip compressed files (.gz extension) into bigquery

load gzip compressed files into bigquery.
Tested from local only.
IMO, would be great to remove LocalStorageHandler, is it still usefill to keep it ?

Gr8 PR
I agree that we should remove local storage


mario

mario

mario
this image fits this pr cuz its the same as the other trashy pfps

mario

mario

mario

mario

mario

oiram

"Build Android" detected. Kidneys: Terminated.

"Build Android" detected. Kidneys: Terminated.

Why specifically the kidneys??

"Build Android" detected. Kidneys: Terminated.

did you just break the chain

"Build Android" detected. Kidneys: Terminated.

did you just break the chain

luigi

"Build Android" detected. Kidneys: Terminated.

did you just break the chain

luigi

mario mf!


AuthenticationError fix doesn't work

Lately I have been tackling this issue. I saw a lot of other people complaining about this. Some say they managed to fix it and some that don't.
I saw there was a merge recently claiming to fix this but after I installed the newest version of the API it seems that the issue persists.
After completing the challenge successfully I attempt to login once more and it works, when attempting to like a user I get this to the console:
AuthenticationError {name: "AuthenticationError", message: "Login required to process this request"}
Anyone has an idea how to fix this?

Need a full example of bug to reproduce