Problem when adding users with same name different letter case, from different origins

Describe the bug
We are trying to add users from uaa and saml using a task that runs cf-mgmt update-space-users command. The thing is that, on the space config files the users within the users array are listed in all lower case<EMAIL_ADDRESS>The users   into the saml array have a capital first letter<EMAIL_ADDRESS>It appears to be 50-50 if it will pick the user with the lower or upper case to then add to the spaces.
If it picks the user<EMAIL_ADDRESS>(from saml) then the user is added in from uaa and saml . If it picks the one with the lower case<EMAIL_ADDRESS>then this user appears to always appear in the task everytime it runs and it doesn’t seem to actually put them in the space. There is not output to say it has failed but it repeats the same user each time picking the lower case name.
If the user list is short, it will fail 100%.
To Reproduce
Steps to reproduce the behavior:
Create a user in uaa<EMAIL_ADDRESS>and then put that in the users array and then<EMAIL_ADDRESS>in the saml_users array.
Run cf-mgmt update-space-users  command, and you'll see that it only adds<EMAIL_ADDRESS>, although it appears twice in the commands output. E.g
$ cf-mgmt update-space-users --system-domain=run-20.slot-59.pez.vmware.com --user-id=cf-mgmt  --client-secret=cf-mgmt-secret
2021/07/21 15:59:22 W0721 15:59:22.020792 49718 yaml_config.go:546] Ldap bind password should be removed from ldap.yml as this will be deprecated in a future release.  Use --ldap-password flag instead.
2021/07/21 15:59:38 I0721 15:59:38.750581 49718 users.go:94] adding<EMAIL_ADDRESS>to role developer for org/space test/test-space
2021/07/21 15:59:39 I0721 15:59:39.951816 49718 users.go:94] adding<EMAIL_ADDRESS>to role developer for org/space test/test-space

and all the next executions it shows the user is added. E.g.
cf-mgmt update-space-users --system-domain=run-20.slot-59.pez.vmware.com --user-id=cf-mgmt  --client-secret=cf-mgmt-secret
2021/07/21 16:15:59 W0721 16:15:59.497327 51571 yaml_config.go:546] Ldap bind password should be removed from ldap.yml as this will be deprecated in a future release.  Use --ldap-password flag instead.
2021/07/21 16:16:16 I0721 16:16:16.772073 51571 users.go:94] adding<EMAIL_ADDRESS>to role developer for org/space test/test-space

So it seems that it checks if the user already exists already in uaa, and if it does, some how, it picks the uaa user instead of the saml user.
This is the snippet of spaceConfig.yml
org: test
space: test-space
space-developer:
  ldap_users: []
  users:
  - admin
  -<EMAIL_ADDRESS>  saml_users:
  -<EMAIL_ADDRESS>
Expected behavior
Users from saml should be added to the space
Additional context
If users don't exist in uaa and you run the command with only saml_users filled, then users are added to the space correctly.
But if then you add users in uaa and run the command with the users array, it will complain saying that the user "doesn't exist in origin uaa, so must add internal user first" when the user indeed exists.

Hey there @bjalonmontanes I can see from the code that users from LDAP / SAML are assumed to be in UAA, and assumed that even if SAML users have Upper case characters, they are always converted to lower.
That's the current behaviour which matches your output above. Therefore your LDAP / SAML / UAA users regardless of Upper/Lower are assumed to be the same, i.e.
<EMAIL_ADDRESS>===<EMAIL_ADDRESS>==<EMAIL_ADDRESS>etc...

@mstergianis , this seems like a product choice was made, and the assumption the code makes is the opposite of what this issue is requesting. WDYT?

this seems like a product choice was made

Can't speak to the original product choice, but this is consistent with what I think. While the standard allows for case sensitive email addresses, it is not something you see in practice.
From RFC 5321:

While the above definition for Local-part is relatively permissive,
for maximum interoperability, a host that expects to receive mail
SHOULD avoid defining mailboxes where the Local-part requires (or
uses) the Quoted-string form or where the Local-part is case-
sensitive.

In addition, cf-mgmt will try to create a uaa user based on the saml user definition.
So, the intended use case here is; if the user's source of truth is SAML, they only appear in the saml_users array, not both.
Though maybe I'm misunderstanding the problem. Is the intent that each user has two sign-ins to the cf instance?
e.g. I as a user could do
cf login -a my-cf.example.com -u<EMAIL_ADDRESS>-p my-super-secret-password

Alternately, intending to be a slightly different user
cf login -a my-cf.example.com --sso

Things I have tried:
Test Case 1
Added a user to saml_users field that does not exist in UAA.
I got the following error from cf-mgmt update-space-users:
Unable to create user<EMAIL_ADDRESS>This was possibly just an error for the env I am using. As mentioned above, the behaviour is to create a user in UAA.
Test Case 2
Added a user to saml_users field that does exist in UAA
WHERE saml_users field was<EMAIL_ADDRESS>and users field was<EMAIL_ADDRESS>I got the following from cf-mgmt update-space-users:
2021/07/21 15:56:20 I0721 15:56:20.491951 89901 users.go:94] adding<EMAIL_ADDRESS>to role developer for org/space test/test-space
2021/07/21 15:56:20 I0721 15:56:20.836599 89901 users.go:94] adding<EMAIL_ADDRESS>to role developer for org/space test/test-space

user added to space under the name<EMAIL_ADDRESS>Cannot login via SAML.
Test Case 3
Added a user to saml_users field that does exist in UAA
WHERE saml_users field was<EMAIL_ADDRESS>Ran: cf create-user<EMAIL_ADDRESS><password>
Ran: cf-mgmt update-space-users:
2021/07/21 16:16:20 I0721 16:16:20.856229 93538 users.go:94] adding<EMAIL_ADDRESS>to role developer for org/space test/test-space

User was assumed to exist in UAA for SAML also. It didn't create another user for SAML in UAA => could not login via SAML with this user.

Though maybe I'm misunderstanding the problem. Is the intent that each user has two sign-ins to the cf instance?
Yes  @mstergianis , that is the use case, users can login with both uaa and saml users.

Thans!

Interesting @bjalonmontanes. I'd love to know more of why each user has two cf accounts.
As it stands right now though, I don't think we'll be changing this behaviour. Treating email addresses as case sensitive is not something I want to unpack :joy:.
Sorry, that this doesn't fit your use case. Have you considered omitting the email address for the native UAA acocunts? I don't believe UAA has a constraint that user accounts be email

hey @bjalonmontanes , given the reply to this thread, I will close this issue out tomorrow. Feel free to re-open / open another if you feel it is not resolved.


Feature/turn on hazard lights at comfortable stop

Description

https://tier4.atlassian.net/browse/T4PB-22513
Add hazard_lights_selector so that hazard lights can be directed from nodes other than behavior_path_planner
Related PR

https://github.com/tier4/autoware_launch.x2/pull/258

Before

After

Test
緩停止MRMを発動させて/planning/hazard_lights_cmdのcommandが2 (=ENABLE)をpublishすること
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mkuri
I think this is irrelevant with this PR, I found that the vehicle sometimes can't stop with MRM comfortable stop. :pleading_face:
https://user-images.githubusercontent.com/11865769/225790191-9edd6d46-0454-494a-804f-f764b4b051c3.mp4

@TomohitoAndo

I think this is irrelevant with this PR, I found that the vehicle sometimes can't stop with MRM comfortable stop.
I'll fix this issue in a separate PR

pre-commit.ci run

@mkuri
I added pre-commit fixes and this can be merged now.


Using entry_points to register dataset and dataarray accessors?

Is your feature request related to a problem?
External libraries often use the dataset/dataarray accessor pattern (e.g. metpy). These accessors are not available until importing the external package where the registration occurs. This means scripts using these accessors must include an often-unused import that linters will complain about e.g.
import metpy # linter complains here

# some data
ds: xr.Dataset = ...

ds.metpy....

Describe the solution you'd like
Use importlib entrypoints to register these as entrypoints so that registration is automatically handled. This is currently enabled for the array backend, but not for accessors (e.g. metpy's setup.cfg).
Describe alternatives you've considered
No response
Additional context
No response

Thanks for the suggestion @nbren12 !
Whilst I agree that this would be a more "correct" way of providing accessor functionality, I think there is a big downside in that Entrypoints are quite a lot harder for users to use than the accessors are.
Whilst the way the accessors actually add the method is kind of black magic, all the user has to do is copy-paste the example from the docs and change the methods and accessor name to what they want, and it will immediately work.
Adding an entrypoint requires going into your setup.py (which you wouldn't even have if you're running a script or notebook), and it's conceptually complicated. The accessors stuff is useful even for relatively novice users, so I don't really want to make it harder to understand...
Interested in what other people think though?

I see your point, but xarray could do both, and most accessors I've used come in a pip installable package and we can make that workflow a bit less painful with entry points. IMO it is an advantage of entrypoints is that they don't require editing source code, just a 1 line change to a setup.py, setup.cfg, or pyproject.toml.
I'm wonder how often "users" define their own accessors...I use python functions and modules.

Are there similar patterns in other libraries around using entrypoints?
I agree it's important to allow defining them in python. Also allowing entrypoints sounds viable; would be interesting to see prior art.

I think it would be nice to have the entry point method as an optional way to get accessors loaded. Essentially this is a way to have xarray execute the needed import rather than the user needing to do it manually.
It looks like the entry points syntax could be used to simply define some modules where accessors live that xarray could import and still use the standard registration decorators that are used today. You're just using setup.cfg/pyproject.toml to register the hooks at install time and have importlib.metadata as an easy way to have Python scan the environment for the appropriate hooks.


question - who owns or maintains this package? Do you need help with maintenance?

I have been trying to contact the maintainers of this package for a while and would appreciate a reply.
It seems unclear to me who maintains this, or what the status is, and would also like to offer my help.
What I know so far:

Robert Martin (@robertmartin8) is the owner of GitHub and pypi, is listed as the single email contact on the landing page and readme.
Tuan Tran (is that @tuantp7?) is mentioned as "primary maintainer" on the readme, but does not seem to own any relevant assets, nor have they made any GitHub contributions in the last year
I contacted the email of Robert Martin from the readme, he advised I should get in contact with another package instead. Requests to put me in touch to maintainers of pyportfolioopt (instead of the other package) have now remained unanswered for more than a month.

I do find his odd - the matter I originally wanted to discuss is integration with sktime.
Now, I wonder: do you need any help with maintaining this package?
It would be a shame if this nice package died!
I'd be happy to help!
(and I'd be happy to discuss how to secure assets or maintain them jointly without "handing them away", in case security/safety of the owned package assets is a concern)

Hi @fkiraly, it's great to have your help. Since @robertmartin8 is currently busy with market activities, I am now the maintainer of this package, primarily focusing on bug fixes. Many issues with this package revolve around installation, often related to dependencies. While we can provide assistance and guidance, resolving these dependency-related issues may be beyond our control.
If you have any suggestions or contributions to make, please feel free to let me know. Your input and collaboration are highly valued.

Hi! I have submitted a PR to remove my email from the readme, and apologies for the slow pickup on your emails – unfortunately it is difficult for me to spend any time on the package nowadays.
Fortunately, we have Tuan (@88d52bdba0366127fffca9dfa93895) as the maintainer and as far as I'm concerned he is doing an excellent job. I respect his judgment on decisions for the future of the package, though I am happy to provide input on major changes if that is desired!
Cheers,
Robert

Hi! I have submitted a PR to remove my email from the readme, and apologies for the slow pickup on your emails – unfortunately it is difficult for me to spend any time on the package nowadays.

If you would like to hear my advice, @robertmartin8, @88d52bdba0366127fffca9dfa93895, it might be good to clarify asset and legal ownership and stewardship going forward. If you remove your email from the readme, @robertmartin8, but remain the (technical and legal) owner of assets, it will be harder to find you if the need arises. I would advise the community to have a clear discussion on ownership and responsibilities, if you would like to retain - or enable - an open governance model.
There's basically two "stable" models here which you can end up with:

"open governance", which means you try to build a model where the package remains owned by the wider, distributed contributor base. Typically incorporated as a non-profit or similar to give this legal grounding. Profits/benefits go to the wider community and are managed by a board, and the primary aim is to keep the software open for the user base.
"closed/corporate governance", where assets are owned by a company, with the primary aim to monetize the user base. Decision making sits with a board, and profits/benefits go to shareholders.

As a project, you seem to be currently in a transition situation, and the de-facto decision power on which direction it goes sits with the person(s and/or incorporated entities) owning the key assets - the GitHub repository and the pypi project.

So, what's next, @88d52bdba0366127fffca9dfa93895, @robertmartin8?
You said,

Your input and collaboration are highly valued.

and I'd be happy to do either.
What's the status of this package?

Hey @fkiraly, I really do appreciate the input; please accept my apologies for the poor response time (both on email and here).
Preamble
I think sktime is a marvellous open source project – I think you (plural) have done a great job on the package, docs, and community. So I am genuinely receptive to your suggestions, subject to the constraints mentioned below (the most unfortunate being my lack of bandwidth).
My philosophy on the package
My philosophy is that PyPortfolioOpt should provide a stable baseline implementation of standard portfolio optimisation in python that is user-friendly and well-documented.
This philosophy arises out of my conversations with institutional users of PyPortfolioOpt, as well as my personal observations having been on both the retail and institutional side. In my view, it is useful to have a simple, well-documented reference implementation of mean-variance optimisation, which has well-understood flaws.
I personally do not think that the package should attempt to incorporate the latest experimental/advanced methods, many of which have are there to keep journal editors busy rather than being practically useful, having pitfalls that are poorly understood.
In other words, if it were possible, I would happily "freeze" the package as is – I want the library to be in a stable phase without much active development. As Tuan points out however, python versioning stuff makes this tricky – like the red queen, we have to run just to stay in the same place.
This is all just my perspective, which I am open to change my mind on, especially if the people who are now maintaining the library (@88d52bdba0366127fffca9dfa93895) think differently – as time goes on, the library is as much theirs as it is "mine" (whatever that means).
Constraints
However, there are some things that I do feel strongly about:

I do not want any form of closed/corporate governance model. This project has been MIT licensed from the start, and I would like it to remain so. PyPortfolioOpt has been through the wringer in terms of open-source "mis-use" (perhaps it's just the standard open source experience...): people wrapping it into consulting services, people bundling it into other software and selling it, plagiarism ranging from petty to "cloning-the-whole-project-and-changing-the-name". But apart from the plagiarism – which is not permitted by the MIT license – I don't actually have any complaint.

Good documentation matters – one worry I have is that people often care more about adding features than adding good documentation. If people want to add more features, I think good documentation really matters.

Time constraint: unfortunately, I have essentially zero bandwidth for PyPortfolioOpt nowadays, apart from chiming in on issues, or responding to emails once in a while (as you know I have not done a very good job even on this). This lack of bandwidth also extends to the immediate next steps – I simply don't see myself overcoming the activation energy to incorporate a non-profit or do anything like that.

Conclusion
It does seem to me that the package is basically working as intended (thanks to the maintenance of @88d52bdba0366127fffca9dfa93895). If suddenly it came to pass that people couldn't install the package, or there was persistent bugs, then I would probably be more inclined to action.
All this said, if there is low-hanging fruit that people feel would move this package to a significantly more stable solution, I will be able to carve out a few hours at some point to oversee the transition.
I will endeavour to be more responsive on this thread over the next couple of weeks.


python37Packages.dogpile_cache: 1.1.0 -> 1.1.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.dogpile_cache is: "A caching front-end based on the Dogpile lock"
meta.homepage for python37Packages.dogpile_cache is: "https://bitbucket.org/zzzeek/dogpile.cache"
meta.changelog for python37Packages.dogpile_cache is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.1.1 with grep in /nix/store/4id9c2khv81shy6vjjayv5wf4mg6wyzh-python3.7-dogpile.cache-1.1.1

directory tree listing: https://gist.github.com/08340fedf0d06301b90251516e6251a3

du listing: https://gist.github.com/62ecf72373c0b07fd54941a4d9bc10e1

Rebuild report (if merged into master) (click to expand)

28 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
7 x86_64-darwin rebuild(s)
7 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
nox
python37Packages.bugwarrior
python37Packages.dogpile_cache
python37Packages.subliminal
python38Packages.bugwarrior
python38Packages.dogpile_cache
python38Packages.subliminal

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4id9c2khv81shy6vjjayv5wf4mg6wyzh-python3.7-dogpile.cache-1.1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.dogpile_cache https://github.com/r-ryantm/nixpkgs/archive/33e5958e5f2c23cfce14cb6895c0c6b27ff56d9e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4id9c2khv81shy6vjjayv5wf4mg6wyzh-python3.7-dogpile.cache-1.1.1
ls -la /nix/store/4id9c2khv81shy6vjjayv5wf4mg6wyzh-python3.7-dogpile.cache-1.1.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

7 packages built:

nox
python37Packages.bugwarrior
python37Packages.dogpile_cache
python37Packages.subliminal
python38Packages.bugwarrior
python38Packages.dogpile_cache
python38Packages.subliminal

Maintainer pings

Result of nixpkgs-review pr 104907 run on x86_64-darwin 1

7 packages built:

nox
python37Packages.bugwarrior
python37Packages.dogpile_cache
python37Packages.subliminal
python38Packages.bugwarrior
python38Packages.dogpile_cache
python38Packages.subliminal


s3cmd error because s3proxy does not return etag

It looks like s3proxy doesn't return an etag which makes it difficult to use s3cmd with the proxy. Obviously any other client that uses the etag will also have issues.
This is on a s3cmd get s3://container_0/file.txt based on a swift provider.
I am receiving this error:
Problem: KeyError: 'etag'
S3cmd:   1.6.0+
python:   2.7.10 (default, Oct  6 2015, 11:07:59)
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.0.72)]
environment LANG=en_US.UTF-8

Traceback (most recent call last):
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/s3cmd-1.6.0_-py2.7.egg/EGG-INFO/scripts/s3cmd", line 2813, in <module>
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/s3cmd-1.6.0_-py2.7.egg/EGG-INFO/scripts/s3cmd", line 2721, in main
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/s3cmd-1.6.0_-py2.7.egg/EGG-INFO/scripts/s3cmd", line 549, in cmd_object_get
  File "build/bdist.macosx-10.11-x86_64/egg/S3/S3.py", line 636, in object_get
    response = self.recv_file(request, stream, labels, start_position)
  File "build/bdist.macosx-10.11-x86_64/egg/S3/S3.py", line 1455, in recv_file
    md5_from_s3 = response["headers"]["etag"].strip('"')
KeyError: 'etag'

@dleute I tested this using a SoftLayer backend and s3cmd 1.5.0 and master (e4639e0862ae04d348f127a96e09c1846bb20208) and cannot reproduce your symptoms.  Can you give me more information on which backend and client you are using?  Also re-run with debug logging to see what the backend provides via:
java -DLOG_LEVEL=debug -jar target/s3proxy --properties configs/softlayer.conf

I think this is because of my previous issue using the swift legacy provider. With your feedback for openstack-swift it is now working as expected.
I'll test for a bit and comment!
Thanks!

This issue was related to #82 and has been resolved along with that issue.
Thanks for the help!

Thanks for the feedback on the legacy swift provider.  jclouds replaced this with the modern openstack-swift provider which has many improvements but retained the legacy provider since HP still uses it.

Yep. I was aware. I just wasn't aware of the temp credentials to make it work with v1.0 auth. Does jclouds itself have documentation on the config parameters like that? I haven't found any yet.


update UI of "check" option

https://github.com/sunfish-shogi/electron-shogi/issues/445

Codecov Report
Patch and project coverage have no change.

Comparison is base (d4fd7d1) 71.46% compared to head (01da3f0) 71.46%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   71.46%   71.46%
=======================================
  Files          69       69
  Lines       14655    14655
  Branches     1894     1894
=======================================
  Hits        10473    10473
  Misses       2315     2315
  Partials     1867     1867

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Train error after corrections in DAOD.py

Hi, Excellent works!
Something was wrong when I was training this week. I guess it's because you corrected the DAOD.py three weeks ago . I found you corrected  in line 155 two times, but the second time you changed the first correction back.  I don't konw why.
And in line 45 you changed
'val_data_list': root / 'Cityscapes/AOOD_Main/val_target.txt'
to
'val_data_list': root / 'Cityscapes/AOOD_Main/train_target.txt'
I wonder whether it's  appropriate  if train_data_list is same to val_data_list.
And The error comes to me is
FileNotFoundError: [Errno 2] No such file or directory: '/data/jyq/SOMA/datasets/dataset/Cityscapes/leftImg8bit_foggy/val/jena/jena_000061_000019_leftImg8bit_foggy_beta_0.02.png'
FileNotFoundError: [Errno 2] No such file or directory: '/data/jyq/SOMA/datasets/dataset/Cityscapes/leftImg8bit_foggy/val/hamburg/hamburg_000000_029144_leftImg8bit_foggy_beta_0.02.png'
However,it didn't  happen before you made thess corrections, it will be so kind of you to help me solve this issue.
Thank you!

thanks a lot ,I think it will be work  after you correct in line 39


BUGFIX: SD-2276 testing

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/56/ : SUCCESS in 9s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-oss-check/74/ : SUCCESS in 6s

not use

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/57/ : SUCCESS in 9s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-oss-check/75/ : SUCCESS in 6s


Checkbox style issue is fixed

Changed the width of the checkbox

This fixes the issue https://github.com/brutusin/json-forms/issues/141.

PLease review and merge.


test dind support for tekton pipeline

Signed-off-by: Nicholas Goracke<EMAIL_ADDRESS>

Not ready for merge

This is ready for review now


Execute the README examples during the pre-deployment checks

Twice now (#48, #47)  there has been trouble with the README examples. This is difficult to catch in an automated way because the README code isn't run in ci.yaml. Making sure the examples run and produce the expected output would prevent these errors from being merged.

Also per JOSS reviewers, the examples in the documentation can be automatically tested by Documenter.jl which needs to be set up.

Closed by @rafaelbailo in #54


Add a member to general programme committee members list

This re-adds an allegedly lost member to the general programme committee who is actually staying.

Thanks for merging!


Please, update screenshots of hud and provide description how to get old-style hud (black hud with white spinner) without long efforts to customise it properly

Screenshots have been updated. If you don't want to spend time customizing the new appearance you can check out the legacy branch.

Thank you. I deal with customisation ;) It seems screenshot are still broken. :(


Frontity CLI

Frontity CLI detailed explanation
@michalczaplinski @DAreRodz @luisherranz
Feel free to add any info that can help to understand better these commands
I've already opened a few threads to try to understand better what can be done with them

Purpose --production in frontity dev and --development in frontity build
Purpose of --target  option in frontity dev or frontity build
Purpose of no-prompt option in frontity create-package command

@DAreRodz Feel free to add that argument or new option you commented the other day, or add I comment explaining it so I can add this new info


Export  impress.js presentation as a Video using ccapture.js

I would like to export a impress.js presentation as a Video (mp4/webm/..). Is this possible?
Can I use something like https://github.com/spite/ccapture.js/ to achieve this?

Hello!
I am not entirely sure if that would work, but you can try. The easiest thing though would be to record it using normal screen recording software like OBS.

The easiest thing though would be to record it using normal screen recording software like OBS.
joop that is how i do it know - but it is manula and i like to cretae the videos by CLI batch if possible
I am not entirely sure if that would work, but you can try.
I'm not an JS expert . I tought maybe someone can precheck if there is a chance to make it

I will have a look if I can get it to work at some point when I find the time to.


defer() should error?

Just wondering, I noticed this:
https://github.com/norskeld/sigma/blob/0d967375e7cf8f98bd9550e76f126fdaf648fa3e/src/parsers/defer.ts#L72-L77
I'm not sure this makes sense as a parser error?
It's not that parsing failed - it's that there is something wrong with your code.
So I think maybe it would be more appropriate to throw an error here?
You might have had some sort of reason for this - it looks a little off to me, so I figured I'd ask. 🙂

Totally makes sense. I thought about making it throw an error, but forgot about that. I'd appreciate a PR!


1.3 beta 8: Astronomy - Error: The "collection" property has to be an instance of...

When I run the kickstarter in 1.3 beta 8:
I get
Error: The "collection" property has to be an instance of the "Mongo.Collection" in the "_color" class
If I pull _colors from collections.js and use directly in colors.js, the error goes away.
import {Mongo} from 'meteor/mongo';

var _colors = new Mongo.Collection('_colors')

const Model = Astro.Class({
  name: '_color',
  collection: _colors,

Of course when I go test it, more things are broken, like method '.find' not found. But I'm not sure if this is an Astronomy or Meteor 1.3 problem.

+1 Same at here.

This issue existing at 1.3beta 6 & 1.3 beta 7 as well.
A simple fix of this issue is :
change code in /lib/collections.js from
export default {
  Posts: new Mongo.Collection('posts'),
  Comments: new Mongo.Collection('comments')
  ,_colors: new Mongo.Collection('_colors')
};

to
export const Posts = new Mongo.Collection('posts');
export const Comments = new Mongo.Collection('comments');
export const _colors = new Mongo.Collection('_colors');

Everything works fine now.


Better support for index creation and deletion

Currently when an index is open, multiple database are opened. For an index named "example" we open example-main, example-postings-lists...
LMDB and therefore heed do not support database deletion as we would like, it is really unsafe to close a dbi (database). This is why we do not close those but just remove the database name from the list of databases and the cache hashmap.
With this solution we do not support deletion and creation as we would like, if we let LMDB open 3000 databases, we are limited to 374 indexes (because they need 8 dbis each). Once this limit is reached we will need to restart the program to be able to reuse those dbis.
I would like to introduce a better solution: using numbers to identify database instead of names, this way we would be able to create/delete and reuse identifiers. We could achieve this by using the databases-name index and associate a unique number to the real name of the database.
If we delete a database, we remove the number from this list and if we need to create a new index, we search for the first available number in this list and associate the index name to it.

Can I try to help with this?

Hey,
I am currently working on a new core engine that can support much more documents and answer in much less time, it also consumes much less space. This core engine will only serve one index at a time, we will make it be a library and the multi-index will be handled by another library.
So, a big refactoring of the internal of MeiliSearch is coming soon. I will not be able to guide you through this until we use this new core engine I am working on.

Sure, not a problem! I'll try to see where else I could help with the project in the meantime.

This is no more relevant, we close it, feel free to comment here, or open a new issue.


Run CI on node 18, 20, and 22

This is the same thing as https://github.com/changesets/changesets/pull/1465 but for the next branch. Maybe we should do this only for the next branch for now.

Maybe we should do this only for the next branch for now.

I'm fine with that 👍


Cache/memoize kernel_matrix_row_sum_mean in the Kernel not Coreset.

What's the new feature?
Remove kernel_matrix_row_sum_mean from Coreset and cache the result of the last call to Kernel.calculate_row_sum_mean in a new attribute Kernel.matrix_row_sum_mean, or determine some means to memoize calls to Kernel.calculate_row_sum_mean. The difficulty with memoization stems from the input arrays to calculate_row_sum_mean being unhashable (you can hash on the shaped array but this doesn't capture the required behaviour).
What value does this add?
Allows Coreset to be simplified and retains Kernel logic in the Kernel instance. Also allows approximation to be integrated more seamlessly into Kernel.
Is there an alternative you've considered?
No response
Additional context
No response

After some discussion, this will not be considered any further as the cache needs to be associated with the coreset state.


Bootstrap image path issues & 404 errors

When you add an image to a Bootstrap project via the WYSIWYG toolbar the images display correctly but you also get a 404 error in the console for each image. The path in the console suggests that initially the image attempts to load when including 'FileLocation + fileName.jpg' rather than after the correct URL has been evaluated. Try this project in Chrome & you'll see the error in console: https://xot.xerte.org.uk/play.php?template_id=207
In projects where you have a lot of images added in this way you get loads of 404 errors! Has it always been this way? I find it hard to believe I haven't noticed before

Actually if you follow that link it doesn't seem to show the 404s when you first view - you may have to refresh before you see them

@FayCross well spotted! I'm just about to join a meeting so can't test further at the moment but I checked a few versions/revisions and at least with a quick glance it looks like it's a recent issue e.g.
the example with the issue that you linked to on xot.xerte is 3.8.5-13
the same issue exists in develop and also 3.8.5-23
However I tested on a 3.8.5 install and the issue doesn't seem to exist on that version.
So it looks like it's an issue that got added after the original 3.8.5 release and is part of the later updates.
@torinfo @JohnSmith-LT any ideas?

We're on 3.7 here & have 404s appearing in console. It's odd though - I have some older projects with images added via the wysiwyg toolbar where you don't get the 404s, even though looking at the underlying xml I can't see anything obviously different between them.


bash completions failing

[!note]
IDK if this is an upstream issue or not, so I'll play-safe and open it here. I'll test upstream later

Any completion whose prefix is tar  causes bash to print this error message:
bash: no match: --occurrence[=NUMBER]

It doesn't happen with default config files on Debian-based distros (it may be any GNU+Linux distro). This is very weird...

This also happens with shellcheck on Linux, but only when completing --. I haven't tested on Termux. I haven't tested if this also happens without the dotfiles

This seems to have been fixed by the new .inputrc. Only tested on Termux

On Debian, the new .inputrc makes no diff

Now the completions work on Debian and Termux!

BTW, I tested upstream on Debian, and it works just fine


Fix memory allocation bug in sample. Using char count, not byte count

Closes #141

Docs Build status updates of commit 24e396f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/creating-a-pseudoconsole-session.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Bump uri template

This should fix #584 , I couldn't verify that this completely solves the problem but is a good guess ...

should be ready now 🙂

@koros have you had the time to look into this PR? Anything I can do?
@andreaTP I'll check it out and get back to you

@andreaTP The code looks okay on my end, however I am not sure why the pipeline tests failed here: https://github.com/microsoft/kiota-typescript/actions/runs/4809556938/jobs/8560999617?pr=619, also which version of kiota generator should I use to run more tests

I'll rebase this early tomorrow if this is still open :+1:

@koros , rebased on latest main, the CI should be green, can you please trigger it?

@andreaTP all the tests are okay now, Thanks. There is a minor issue though https://github.com/microsoft/kiota-typescript/actions/runs/5014471823/jobs/8989301442?pr=619 It looks like the CI/CD is trying to add a comment about the bundle size but it probably can't access your resource.  I can merge it if there is no other comment from @sebastienlevert @gavinbarron

@koros , rebased on latest main, the CI should be green, can you please trigger it?

@andreaTP all the tests are okay now, Thanks. There is a minor issue though https://github.com/microsoft/kiota-typescript/actions/runs/5014471823/jobs/8989301442?pr=619 It looks like the CI/CD is trying to add a comment about the bundle size but it probably can't access your resource. I can merge it if there is no other comment from @sebastienlevert @gavinbarron

LGTM!

thanks @koros for the feedback, opened #667 to track the issue with the CI.

@koros I'm not sure I fully understand the problem here, let me go through it.

it looks like the CI wont allow merge before all checks

either you disable the check as proposed in #667 or you disable the check as "mandatory" in the project settings.

in the past how were the PRs done

this is my first PR to this repository, and, apparently, this is the first from a community member that is not part of the microsoft-graph organization.

is the issue we're encountering new or its something known.

the issue with the CI is something that happened in other repositories, e.g.:
https://github.com/microsoft/kiota-java/pull/142
https://github.com/microsoft/kiota/issues/2591

Rebased on latest main, @koros can you, please trigger the CI?

@andreaTP there's something else broken but it has nothing to do with this PR, its the generation side let me look into that.

Thanks for chipping in @MIchaelMainer !

Folks, we shouldn't be merging directly into the branch where we publish from.

This is not a common practice, but I have no objection if someone is willing to do the manual work all of the time ...

We should consider creating another branch off of main, create new PR into the branch, merge into that branch, and then the CI/CD can run when you create another PR into main.

This could work, but I expect it to work now as #668 got merged.
At the moment seems like something is broken in Kiota main and the test is correctly failing because of it.

Just to make it clear, the current CI failure doesn't seem to be related with the changes proposed in this PR.

@baywet sorry for bothering you directly, would you be able to facilitate the progress on this PR?

@andreaTP it seems our CI is impacted by this https://github.com/microsoft/kiota/issues/2676 which makes it flaky. I just reran the thing for now and it passed.
Thank you for your patience while I was away. We'll need to investigate the generation behaviour, but that's a separate issue we've already captured.
Merging.

Not sure this is related - but, with Vite and:
  "name": "@microsoft/kiota-abstractions",
  "version": "1.0.0-preview.19"

i get an exception:
Uncaught (in promise) TypeError: Template is not a constructor
    at get URL [as URL] (requestInformation.ts:42:24)
    at FetchRequestAdapter.<anonymous> (fetchRequestAdapter.js:452:45)

Looking at the packages for kiota-abstractions:
  "dependencies": {
    "@opentelemetry/api": "^1.2.0",
    "tinyduration": "^3.2.2",
    "tslib": "^2.3.1",
    "uri-template-lite": "^23.4.0",
    "uuid": "^9.0.0"
  },

we are on the new version of uri-template-lite.
But it code seem to break here:
 const template = new Template(this.urlTemplate);
          const data = {};

aka:
      const template = new (Template as any)(this.urlTemplate);

Got any ideas? This is a rather "blocking" issue.

Thanks for reporting this. Do you have the same issue if you downgrade the package?

If I downgrade to
    "@microsoft/kiota-abstractions": "1.0.0-preview.18",
    "@microsoft/kiota-http-fetchlibrary": "^1.0.0-preview.18",
    "@microsoft/kiota-serialization-form": "^1.0.0-preview.8",
    "@microsoft/kiota-serialization-json": "^1.0.0-preview.17",
    "@microsoft/kiota-serialization-text": "^1.0.0-preview.16",

I no longer see the error, mentioned before. (I only downgraded kiota-abstractions)
But now there seems to be a mismatch between kiota-abstractions and kiota-http-fetchlibrary and I get different errors.
Any idea what the working combination might be?

Just an update - in the end, this combination ran for me:
    "@microsoft/kiota-abstractions": "1.0.0-preview.18",
    "@microsoft/kiota-http-fetchlibrary": "1.0.0-preview.17",
    "@microsoft/kiota-serialization-form": "1.0.0-preview.7",
    "@microsoft/kiota-serialization-json": "1.0.0-preview.16",
    "@microsoft/kiota-serialization-text": "1.0.0-preview.15",

Able to compile and bundle with Vite - the definition mismatches are also gone.

@ksdaniel would you be able to provide a minimal reproducer so that we can fix the underlying issue?


xbmctorrent style download information when video pauses.

Hi;
xbmctorrent have download status when video pauses. But pulsar does not have. I cant see downloaded percent or speed. Maybe added next realese.

bump, it would realy help people to know if there connection or the chosen torrent is good for streaming, a lots of time the stream stops and you dont have a clue why, maybe your ineternet d/c.
please add it :+1:

That would be nice...

+1, this would be really nice!


Fix Review Files

This PR does not include any feature update. This is the result of running rush update && rush build in our repo (without any code changes).
These files are regenerated every time I run them and keep showing up in my PRs and I have remove them manually. Would be a lot easier if I just push these changes. Please review and approve

Thanks @sarangan12
@KarishmaGhiya I thought we discussed pinning the api-extractor version being used so that this doesnt happen anymore? https://github.com/Azure/azure-sdk-for-js/pull/8179#discussion_r403639580

@ramya-rao-a  yes will be sending a PR out for it later today

https://github.com/Azure/azure-sdk-for-js/pull/8400 - pinning api-extractor

This should no longer be a problem with #8400


Please add the OSPO Fabricbot

This repo should have the OSPO fabricBot added to this repo so issues and PRs get an automatic system for assigning people and labels.

Could you please guide us for more details about OSPO Fabricbot ? How to onboard or leverage this?

Could you please guide us for more details about OSPO Fabricbot ? How to onboard or leverage this?

https://docs.opensource.microsoft.com/tools/fabricbot/index.html - LMK if you need help.

https://docs.opensource.microsoft.com/tools/fabricbot/index.html - LMK if you need help.

@diberry We already have msftbot to route to corresponding service team when adding "Service Attention" and some service label. Does OSPO Fabricbot you mentioned have the same behavior or this bot could provide more features?

@diberry We already have msftbot to route to corresponding service team when adding "Service Attention" and some service label. Does OSPO Fabricbot you mentioned have the same behavior or this bot could provide more features?

More features. It can handle first level routing for issues and PRs and circle back around after N days asking for more information or closing with polite messages.


reduce image size with docker-slim

could be interesting to build the image using https://github.com/slimtoolkit/slim, on the free tier, there is a limit on the github packages size, smaller images could help here.

I probably wouldn't dig into it myself, but I'd take a look at a PR for this.
I added a directory deletion at https://github.com/adamghill/fediview/blob/main/.github/workflows/deploy.yml#L17-L18 to reduce the size of the fediview image (based on https://github.com/orgs/community/discussions/25678). I wonder if it would be helpful here, too?

I probably wouldn't dig into it myself, but I'd take a look at a PR for this.

I will look into issue, my only issue is how to test the action to see if it's working

I added a directory deletion at<EMAIL_ADDRESS>because I was running into disk space issues (based on github.com/orgs/community/discussions/25678). I wonder if it would be helpful here, too?

yep could be useful, doesn't hurt to add

@Tobi-De How much will docker-slim reduce your image size if you've already made it small by using multi-stage builds?
https://docs.docker.com/get-started/docker-concepts/building-images/multi-stage-builds/
https://docs.docker.com/build/building/multi-stage/
E.g.: https://github.com/benwis/benwis_leptos/blob/main/Dockerfile
Can docker-slim do more size reduction?


⚠ Bofrost.de has degraded performance

In 20d6ffb, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1346 ms

Resolved: Bofrost.de performance has improved in c146783.


operator hive-operator (1.2.4002-a78647b)

Update Hive community operator channel(s) [['alpha']] to 1.2.4002-a78647b

/merge possible


[changelog] Labeler regex does not match

Task List

[x] Steps to reproduce provided
[ ] Stacktrace (if present) provided
[ ] Example that reproduces the problem (link to git repository is ideal)
[x] Full description of the issue provided (see below)

Steps to Reproduce

Add a changelog labeler with regex such as regex:#\d+.
Add the labeler to a known category.
Generate the changelog in a project that has matching commits.

Expected Behaviour
Matched commits organized in the given category.
Actual Behaviour
No matches.
Environment Information

Operating System: N/A
JReleaser Version: 0.8.0
JDK Version: N/A

What happens is that JReleaser macthes #\d+ as is when it should be .*#\d+.*.
JReleaser could inject the surrounding  .* if there are no ^ and $ characters.


legend  can not  rotate

One-line summary [问题简述]
legend text can not rotate
Version & Environment [版本及环境]

ECharts version [ECharts 版本]: all
Browser version [浏览器类型和版本]:all
OS Version [操作系统类型和版本]:all

Expected behaviour [期望结果]
ECharts option [ECharts配置项]

option = {
 legend: {
        type: 'scroll',
        orient: 'vertical',
        right: 10,
        top: 20,
        bottom: 20,
        data: data.legendData,

        selected: data.selected,
        textStyle:{
                rich:{
                    a:{
                        fontSize:20,
                        verticalAlign:'top',
                        align:'center',
                        padding:[0,0,28,0],
                        rotate: 90,
                    },
                }
    },
    },
    formatter: function (name) {
    return '{a|' + name +"}";
    },
}

Hi swwinone, I would like to make sure, in which case is this necessary? Because I don't think it a good idea to rotate the text in that the readability is decreased.

First, I use echatrs on the phone page. To achieve the full-screen feel of the line chart, I rotated the entire echarts diagram, and other options could be rotated, but only legend could not rotate.

That makes sense. Let's see if we can provide an option for it.

Hello, has this problem been solved? I also met. Can you tell me how to solve it?

Sorry for this delay, a solution has been proposed, but It needs future development, something needs to enhance

I just do like this:
      legend: {
        icon: 'none',
        formatter: (name) => {
          const verticalName = name.split('').join('\n')
          const arr = [`{a|${verticalName}}`]
          return arr.join('\n')
        },
        textStyle: {
          rich : {
            a: {
              lineHeight: 20,
            }
          }
        },
      },

is there any fix for this?

I think html is the best way to do this,

I think html is the best way to do this,

i use css transform to rotate parent dom, but it not work in minapp, like weapp

so i think it may be can set rotate property with per compoent, link axis, tooltip, lengend

What I propose is that use somting like <div>  to create custom legend, in miniprogram is <view>

What I propose is that use somting like <div> to create custom legend, in miniprogram is <view>

I will try. thanks guy. 👍🏻


<tex_object>.SampleLevel doesn't work with CPU when using the Offset parameter

When executing SampleLevel using Offset parameters in slang-test, we get a failure with the CPU profile.
Example calls:
val += t1D.SampleLevel(samplerState, u, 0, 1);
val += t2D.SampleLevel(samplerState, float2(u, u), 0, int2(1, 1));
val += t3D.SampleLevel(samplerState, float3(u, u, u), 0, int3(1, 1, 1));
val += t1DArray.SampleLevel(samplerState, float2(u, 0), 0, 1);
val += t2DArray.SampleLevel(samplerState, float3(u, u, 0), 0, int2(1, 1));
Where val and u are a float.

Textures on CPU are not fully implemented so this is expected. Let's focus on other issues first.


MPV error on Launch

I am on MacOS and have had mpv installed and working for a long time.
When I run cthulhu, it spits out an error indicating I do not have mpv installed.
note: In actual fact I have mpv and a MacOS fork of mpv that basically makes mpv a gui app on a mac. Both work perfectly.

I fixed, just had to edit the path inside the code to match the location on mpv. Works well.
I have some suggestions:

Allow hitting esc to exit
More categories, Tv Shows, music etc. they only show when using the --fast switch
Add a config file
Add a switch to allow for custom number of results or
Add support for fzf (just a thought), this would allow for "unlimited" search results
Add columns for peers, leeches etc.
Add more urls/sites (the more the better)

I do think that using a config file would allow for a lot more customising.
Keep up the awesome work.

Andy

It's nice that you found a fix so fast, I was worried for a second there since I didn't officially test on macOS yet (oops).
Also, thanks for the suggestions! I will definitely look into including most of them depending on the viability. Stuff like a config file and more URL sources are already being planned for (I'm looking to organize the code a bit better first since it's a bit of a mess right now).
An option to customize the number of results is trivial to add for anything less than 20. It's also technically possible to add an option to show more than 20 results, but it would require making more requests since each search on 1337x is limited to 20 per page. I'll still look into it since that's what the default filter does anyways.
Raiyan

I fixed, just had to edit the path inside the code to match the location on mpv. Works well.

Just curious, would master correctly detect your mpv executable on MacOS? The dependency check is no longer based on hardcoded paths, hopefully this should work on MacOS too now.

hmmm, not to sure about that, as the app I use is in /Applications rather than /usr/local/bin etc.
I have just come across webtorrent-cli and and straight away thought of your app. Might be worth it for you to have a look at the flags they have included
for some inspiration ie. --stdout so you can output to a custom client or wherever.
Another program you may want to look at is pirate-get, its essential a torrent searcher & downloader, but unlike yours it searches multiple sites at once.
webtorrent-cli and pirate-get are similar with the exception that webtorrent-cli needs a magnet file or a direct link whereas pirate-get does not, you have have to select from a (possibly huge) list and select to download with whatever client you want.
Just some food for thought.
To me it just seems that a hybrid of the 3 projects would be perfect:

Cthulhu's streaming capablilites (granted webtorrent-cli can stream like yours does just with more options in the streaming department.)
webtorrent-cli's customisation
pirate-get's torrent searching capabilities.

I hope this helps you in some way
Andy

Just to disambiguate, I am not the developer of cthulhu, but I know it no longer checks for hardcoded paths to detect mpv, so it may work for you out of the box. I am not sure how PATH is handled on MacOS though.
@trianglecirclexyz knows about webtorrent-cli but while there are common features with peerflix, there are also a few differences. They seem to both have their strengths but apparently should be relatively easily interchangeable.
I knew about pirate-get and tended to use it together with stig (a TUI torrent application based on transmission), but I admit I like the straightforward use of cthulhu where you don't even have to copy a magnet. I use it on my phone so not having to deal with the clipboard is more comfortable.
If you want to try something like cthulhu but using webtorrent under the hood, have a look notflix which was apparently an inspiration for cthulhu (the link is in the README here).

I think it depends on how mpv/vlc are installed on macOS for it to work out of the box from my testing in a mac VM. Im planning on writing a seperate bit for macOS/BSD installation after some more testing.

looks like notflix depends on x11?

Probably when using dmenu indeed, which is the default, but someone submitted a PR to allo full use from the CLI and therefore making dmenu optional. I haven't tried though.
On 2022-01-16 05:13 Andy @.***> wrote:

looks like notflix depends on x11?
--
Reply to this email directly or view it on GitHub:
https://github.com/trianglecirclexyz/cthulhu/issues/1#issuecomment-101
3807561
You are receiving this because you commented.
Message ID:
@.***>


[core-rest-pipeline] - Upgrade to core-tracing preview.14

Let's see what happens
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

Going to do it for reals this time, closing


Resort Columns

Block should include the title, placeholder the map link at first, will figure out how to address that later.
Authoring should be based on max number displayed on desktop - will impl mobile first and grow accordingly.

Merged the component: https://github.com/aemsites/jet2holidays-portugal/pull/77


vg-mute-button / failed to set the 'volume' property

An error occurs when we click on mute twice (found with vg-type="audio").
Here is the log : "angular.js:12520 TypeError: Failed to set the 'volume' property on 'HTMLMediaElement': The provided double value is non-finite."
This is a quick fixe for 'vg-mute-button.js' line 98 :
if(newVolume != undefined)
                      if (!isMuted) {
                        scope.defaultVolume = newVolume;
                    }
                    else {
                        // if was muted but the user changed the volume
                        if (newVolume > 0) {
                            scope.defaultVolume = newVolume;
                        }
                    }
else
       scope.defaultVolume = 1;

instead of :
                      if (!isMuted) {
                        scope.defaultVolume = newVolume;
                    }
                    else {
                        // if was muted but the user changed the volume
                        if (newVolume > 0) {
                            scope.defaultVolume = newVolume;
                        }
                    }

I can't reproduce this with online demo. Can you provide a codepen with this issue?
http://localhost:8888/videogular/app/#/audio


Regarding exercises in Character-Level RNN

I was wondering where I can find the dataset for the exercises given in Classifying Names with Character-Level RNN.
For example:
Any word -> language
First name -> gender
Character name -> writer
Page title -> blog or subreddit
To complete this task, do I have to create my own dataset or is there any repo where I can download that dataset?

Those are just ideas to try with your own datasets. For the reddit one I suggest https://github.com/linanqiu/reddit-dataset

Thank you very much spro.


[Question]: How can I inherit the sdk's classes e.g. TradingClient?

Question form pre-submit checklist.

[X] I have searched the existing issues to ensure there isn't already an issue about this question.
[X] My question has to do with the Python SDK and isn't a general question about the API. (If it is please open your issue here)
[X] My question isn't about how to do a specific algorithm or asking for trade advice (answers to these are outside the scope of this repo).

Question
I'm trying to extend the capabilities of alpaca.trading.client.TradingClient
I tried to start a very simple example by creating a subclass like this:
class StockTrader(TradingClient):
    def __init__(self, api_key, secret_key, paper):
        super().__init__(api_key=api_key, secret_key=secret_key, paper=paper)

    def get_account(self):
        return super().get_account()

However when I try to use this class:
trader = StockTrader(api_key,secret_key,paper)
trader.get_account()

I get the following error:
TypeError: TradingClient.get_account() missing 1 required positional argument: 'self'
Is there an obvious reason why inheriting from TradingClient like this can't work?

@dskarbrevik I can not replicate this issue in my local environment and also Google Colab.
Can you please provide more information to replicate this issue such as version of alpaca-py and Python .
Below is the code I have tested in my end with alpaca-py v0.11.0 and Python 3.10.12 / Python 3.11.5.
from alpaca.trading.client import TradingClient

class StockTrader(TradingClient):
    def __init__(self, api_key, secret_key, paper):
        super().__init__(api_key=api_key, secret_key=secret_key, paper=paper)

    def get_account(self):
        return super().get_account()

api_key=<PAPER API KEY>
secret_key=<PAPER API SECRET>
paper = True

trader = StockTrader(api_key, secret_key, paper)
trader.get_account()

IMO generally this method:
def get_account(self):
        return super().get_account()

should actually be:
def get_account(self):
        account =  self.get_account()
        # do something else here
        return account

or even better you shouldn't re-define the same method if you're not doing anything else apart from calling the method of the parent class and returning it, this way you're just polluting that class namespace with no real reason.


Type hinting

I've left one task open on https://github.com/orestes/katana-sdk-node/commit/879637e0748f943775783dfef061373a8d6125f5
@rvegas could you implement those? I think there were not in the spec at the time of the implementation. Specially the methods in Request, I'm almost sure those are coming from the Request Attributes feature

Coverage decreased (-0.1%) to 79.73% when pulling 0b505e0ce59f46b3a942ccd8b2482b5e30b7822d on orestes:master into 88eb436a811b9bc481a736551f221b3f42376989 on kusanagi:master.


config file location

Config file is located right in the project folder. Can it be moved to .vscode folder?

refer to #7

Now config file does place in the .vscode folder. 🎉🎉🎉


Add consumer managed resource enhancement

What problem are you facing?

This provider shall be able to handle NATS Jetstream consumers. It should give the user the full configuration possibilities the consumers can configured with.
How could Crossplane help solve your problem?

Well, let's implement this provider.

fixed by #3


Compiling serde_json for wasm32

I am trying to track down a build problem that crept into a crate of mine.
Is it possible that a previous release of serde_json compiled for wasm32-unknown-unknown and now it doesn't?
When I try and compile master for that target I get:
cargo build --target=wasm32-unknown-unknown
   Compiling itoa v0.4.7
   Compiling ryu v1.0.5
   Compiling proc-macro2 v1.0.26
   Compiling serde v1.0.125
   Compiling serde_json v1.0.64 (/Users/andrew/workspace/json)
error[E0463]: can't find crate for `core`
  |
  = note: the `wasm32-unknown-unknown` target may not be installed

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: could not compile `itoa`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error[E0463]: can't find crate for `core`
  |
  = note: the `wasm32-unknown-unknown` target may not be installed

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: build failed

I tried without default features also in case that could achieve it.
Is there a way to compile the latest releases for wasm32 target?

Ignore, seems was a problem with my installation of rustc. :-(


chore(linter): update golangci.yaml

add new linters
See: 42

Here is a PR I made for pman
https://github.com/theredditbandit/pman/pull/25
You can see the linters I used. I enabled all revive and disabled only a few, I'm unsure if it was a good idea for maintenance but the results were impressive

Dupwords should be enabled, it costs nothing and detects typos
gci should be enabled with the following linter settings

standard
default
localmodule

Done

Here is a PR I made for pman
theredditbandit/pman#25
You can see the linters I used. I enabled all revive and disabled only a few, I'm unsure if it was a good idea for maintenance but the results were impressive

I enable all linters from revive
https://github.com/lasiar/canonicalheader/blob/e73e1bb759da822df08218cdbf0db7b4f53248c6/.golangci.yaml#L375-L375

@ccoVeille, I'm sorry for long reply
I'm busy IRL


Complete quoting for parameters of some CMake commands

Some parameters (like "${CMAKE_BINARY_DIR}/generated.h") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.
I would recommend to apply advices from a wiki article.

We can reopen this issue if it is still valid.


[stable/prometheus/operator] selector gets merged instead of overwritten

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Bugreport
Version of Helm and Kubernetes:
v2.11.0
Which chart:
[stable/prometheus/operator] v0.1.16
What happened:
I followed the docs that allow to override service selectors, because the helm chart is STILL pointing to a very old k8s version (I suggest to use component instead of k8s-app asap):
# values.yaml:
kubeControllerManager:
  service:
    selector:
      component: kube-controller-manager
coreDns:
  service:
    selector:
      component: kube-dns
kubeEtcd:
  service:
    selector:
      component: etcd-server
kubeScheduler:
  service:
    selector:
      component: kube-scheduler

but they get merged in the services:
kubectl -n kube-system get svc prometheus-operator-kube-etcd -o yaml
you see:
selector:
    component: etcd-server
    k8s-app: etcd-server

What you expected to happen:
the old version was:
selector:
    k8s-app: etcd-server

which should be looking like:
selector:
    component: etcd-server

How to reproduce it (as minimally and precisely as possible):
Use the values as specified.

This is not a chart issue but a helm issue, which merges maps and overrides lists. This chart specifically provides an escape hatch around a helm bug (https://github.com/helm/helm/issues/3117) by allowing you to remove the defaults:
selector:
  k8s-app: null
  component: kube-controller-manager

Changing the defaults would be a breaking change but if they are definitely better than what is specified here then it's a good one. Could you point at the documentation for what these labels are?


When using AnimationPlayer with Capture and Cubic Angle, it does NOT take the shortest rotation path

Godot version
4.0.3
System information
Linux (but happens on every target)
Issue description

Scenario

You have AnimationPlayer with a Capture track using Cubic Angle easing controlling the rotation of a sprite.

Expected Behavior

No matter what the current rotation is, the animation should take the shortest angle of rotation.

Actual Behavior

The animation does NOT take the shortest rotational angle.
This often results in weird and unexpected spinning through the largest possible instead of shortest possible angle.

Strangely, if I change the Capture track's easing to Cubic, instead of Cubic Angle, it actually works as expected in the demo project I made, but that does not fix the problem in my real project, nor would I expect it to -- I actually need the documented behavior of Cubic Angle, which is to ensure the shortest rotational angle.

Steps to reproduce

Make a sprite.
Add an AnimationPlayer.
Make a track, "run", that's 2 seconds, Cubic Angle easing, with three sprite rotation keyframes: @0: 0, @0.5: +5, @1.5: -5
Make another track, "stop", that's 0.5 seconds, Capture mode, Cubic Angle easing, with one sprite rotation keyframe: @0.5: 0
Play the "run" animation, verify that it basically swings back and forth.
While "run" is going, switch to the "stop" animation during the first half of the animation: it rotates back to 0 normally.
While "run" is going, switch to the "stop" animation during the second half of the animation: it spins around taking the longest possible rotational angle path back to 0.

This also happens with Linear Angle easing, the "Cubic" part of it doesn't matter.
Minimal reproduction project
bug.zip

I said in my initial submission that switching to "Cubic" instead of "Cubic Angle" fixed the demo project but not in my real project (where things are significantly more complex). However, I just went and changed every instance of "Cubic Angle" to "Cubic" and every "Linear Angle" to "Linear" in all animations my real project and this does fix the problem. (It did not fix the problem to just change the Capture tracks -- so maybe something more complex is going on here.)
Is it possible that the behavior of "Cubic" and "Cubic Angle" is switched or something?
Either way, the demo project and reproduction steps I provided show the bug, I just wanted to give a bit more info of other things I tried on my real project just in case it helps debug this.

After more experimenting, it seems like the easing ("Cubic" or "Cubic Angle") on the capture track doesn't appear to matter, what matters is the easing on the interrupted track. If it's "Cubic Angle" this problem comes up, if it's "Cubic" this problem doesn't appear (that I have seen). I can reproduce this both in the demo project I posted and in my own more complex real project.
Either way, this doesn't work as it should, but again trying to help give more info to find the root cause. =)

The cubic interpolation takes one previous key and two later keys from the current key for a cubic calculation as the name implies. I know there are some issues with the capture mode that the behavior is not consistent to begin with (https://github.com/godotengine/godot/issues/48432, https://github.com/godotengine/godot/issues/55110), but I think there is an additional issue with the failure to get the correct keys when it consider captured key as current key.

In case you still have a project trying to make use of CAPTURE in 4.x, could you assess whether #86715 solves the issue the way you would expect it to? You can test the PR by download a build (artifact) for your platform from the "Checks" (CI) tab.


🐛 Bug Report: Can't use this sdk with bare react native

👟 Reproduction steps
I just used this sdk with my bare react native project and encountern the error that this package uses expo-file-system and I have to use expo with my bare react native project, I can't affords using expo in my project because I am using some packages which not support expo. This package should be bare react native first then expo and you should mention in the docs that this package only for expo projects only. I know react native's official docs recommended to using expo so what? there are many comapines using bare react native in production and few using expo in production, because of one package we can't affords using expo.
👍 Expected behavior
Should works fine with both workflow.
👎 Actual Behavior
Actual Error:

🎲 Appwrite version
Different version (specify in environment)
💻 Operating system
Windows
🧱 Your Environment
react-native-appwrite = 0.4.0
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

@imPrathamDev, thanks for raising this issue! 🙏🏼 Do you have a suggestion for how to support both expo and non-expo projects? From what we saw, it's possible to use expo-file-system in a non-expo project, however, the other packages we looked at for non-expo projects didn't work on expo.

@imPrathamDev @stnguyen90 I was able to use the SDK in a bare React Native project recently by installing expo (Expo modules are also supported in RN now). You can follow these steps from the official expo docs - https://docs.expo.dev/bare/installing-expo-modules/
After installing expo I installed expo-file-system and Appwrite SDK was working.

Is this Issue Resolved?


Minor Usability Improvements

See individual commits

A related issue I just noticed in https://github.com/lightningdevkit/ldk-sample/blob/e3d528d2cfe5ec239571c70f71a9f0f9307862f2/src/cli.rs#L222
the return value should be checked via the ? operator.


MSAL: Logout and when Login immediately not asking for User Credentials

Please follow the issue template below. Failure to do so will result in a delay in answering your question.

Library

[ ]<EMAIL_ADDRESS>
Framework
-[] Angular 8
Description
We are using Front End as Angular 8 and Back End .Net Core 3.1 with MSAL 1.3.4. When we logout of the application and without closing the window try to login not asking for user credentials.
Also seen when we logout the localStorage is cleared.
Please help
Expected behavior
When user tried to relogin to application after logout. Should be asking for credentials.
Browsers/Environment

[ ] Chrome
[ ] Firefox
[ ] Edge

@veera-raghavagupta are you using an AAD or B2C application? Could you please provide your MSAL configuration? In the future, please complete all sections of the issue template so we can better investigate and address your issues.

Going forward will make sure will fill all the details.
Front end - Angular 8
Back end - .Net Core 3.1
MSAL- 1.3.4
We are using Azure B2C
Initially when we click on login redirects to login page for user to credentials, after successful login will be redirected to dashboard. And on click of logout will be redirected to login page as expected. When user clicks on login again should be asked for user credentials instead getting redirected dashboard.
msal-angular-custom.zip

Can you confirm if you are using B2C local accounts or Social IDP logins? This is expected behavior when using Social logins with B2C. When you logout you are clearing local/session storage of your tokens for your app and closing the session with B2C, you are not logging out of your federated IDP (Google, Facebook, etc). This is because your app and the B2C service should not make any assumptions about whether or not a user wants to be signed out of your social account everywhere or just for that app. What this translates to in practice is that when you try to login again, the B2C service should present you with a screen to select the IDP you'd like to use (this suggests the B2C session was closed previously). Once you select your IDP you will be redirected to the IDP's login page, which if you are already signed in, will automatically redirect you back to B2C and then back to your app without asking for credentials.

did anyone get any solution for the same? what if the user wants to log in with a different account, not with the current login user? did the user need to wait till the session got expire in IDP?

This issue has not seen activity in 14 days. It will be closed in 7 days if it remains stale.

We are still waiting for the fix as we are still facing the issue. Team, please help me with turn around solution.

I am in the same situation. Any help will be appreciated. Thanks.

@veera-raghavagupta @carlosrc As explained above this is expected behavior for Social IDPs. There's a great answer on Stack Overflow explaining why it works this way.
I've also added an entry to our FAQ here if you still have questions.

@tnorling We are not using Social IDPs for logging in

@veera-raghavagupta Can you send me a network trace including the login, logout and the 2nd login? Email is on my profile. Thanks!


Spyder code folding not working on 4.1.5

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[x] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
Code folder does not work. It shows an extra column but the option to fold does not appear. Attempted this solution but does not work. Created a new issue to not open up the old one.
What steps reproduce the problem?

Install conda
conda install spyder==4.1.5

What is the expected output? What do you see instead?
I expect to see code folding options. It was working in a previous iteration of spyder.
 Both of these options really improved my productivity :(

Hey @RSKothari, thanks for reporting. Please open a terminal, run the following command:
spyder --debug-info verbose --debug-output file

and upload here the file called spyder-debug.log, which is created in the same directory where you ran the command above.

Interesting, I feel like I'm missing something essential

Sorry, this is caused by a bug that we haven't noticed before and we'll fix it in our next version (4.2.0), to be released in a few days.
Please run instead
spyder --debug-info verbose

and look for errors in the output.

Interesting, it seems to be a Kite thing. I ran the program with debug on and switched code folding ON and OFF.

For starters, I received this error
pkg_resources.VersionConflict: (ujson 1.35 (/home/rakshit/.local/lib/python3.7/site-packages), Requirement.parse('ujson>=3.0.0; python_version > "3"'))
debug.txt

Ok, that looks promising. Please run
conda install ujson=3

to fix it.

That did not help :(
On Mon, Nov 9, 2020 at 8:45 AM Carlos Cordoba<EMAIL_ADDRESS>wrote:

Ok, that looks promising. Please run
conda install ujson=3
to fix it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/14166#issuecomment-724022469,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPIEKTEAEEHGQ4QU3RCKTTSO7W7BANCNFSM4TNSWWJQ
.

--
Rakshit Kothari
Research & Teaching Assistant
Perception for Action and Motion lab (PerForM)
Center for Imaging Science
Rochester Institute of Technology

Ok, I didn't read your error message correctly. Please remove this directory
/home/rakshit/.local/lib/python3.7/

Then your error should be fixed.

I built an env totally via pip, and see the same issue--no code folding. The column appears / disappears when the option is selected / deselected, but no folding.
* Spyder version: 4.1.5 None
* Python version: 3.7.4 64-bit
* Qt version: 5.12.9
* PyQt5 version: 5.12.3
* Operating System: Windows 10

Dependencies:

# Mandatory:
atomicwrites >=1.2.0           :  1.4.0 (OK)
chardet >=2.0.0                :  3.0.4 (OK)
cloudpickle >=0.5.0            :  1.3.0 (OK)
diff_match_patch >=20181111    :  20181111 (OK)
intervaltree                   :  None (OK)
IPython >=4.0                  :  7.19.0 (OK)
jedi =0.17.1                   :  0.17.1 (OK)
nbconvert >=4.0                :  5.6.1 (OK)
numpydoc >=0.6.0               :  0.9.2 (OK)
paramiko >=2.4.0               :  2.7.2 (OK)
parso =0.7.0                   :  0.7.0 (OK)
pexpect >=4.4.0                :  4.8.0 (OK)
pickleshare >=0.4              :  0.7.5 (OK)
psutil >=5.3                   :  5.7.3 (OK)
pygments >=2.0                 :  2.5.2 (OK)
pylint >=1.0                   :  1.9.4 (OK)
pyls >=0.34.0;<1.0.0           :  0.36.1 (OK)
qdarkstyle >=2.8               :  2.8.1 (OK)
qtawesome >=0.5.7              :  0.7.3 (OK)
qtconsole >=4.6.0              :  4.7.7 (OK)
qtpy >=1.5.0                   :  1.9.0 (OK)
sphinx >=0.6.6                 :  1.8.5 (OK)
spyder_kernels >=1.9.4;<1.10.0 :  1.9.4 (OK)
watchdog                       :  None (OK)
zmq >=17                       :  19.0.2 (OK)

# Optional:
cython >=0.21                  :  0.29.14 (OK)
matplotlib >=2.0.0             :  3.3.2 (OK)
numpy >=1.7                    :  1.19.3 (OK)
pandas >=0.13.1                :  1.1.4 (OK)
scipy >=0.17.0                 :  1.5.4 (OK)
sympy >=0.7.3                  :  None (OK)

Please see my https://github.com/spyder-ide/spyder/issues/14166#issuecomment-723523256 above on how to get debug output and look for errors.

Please see my #14166 (comment) above on how to get debug output and look for errors.

For me this issue was also fixed by updating to Spyder 4.2.0

OK. I'll get to do this after an upcoming submission. A little hesitant to mess with my state at this juncture.

Closing due to lack of response.

@ccordoba12 This fixed the issue, thanks a lot.

I had the same problem and solved it by upgrading toml package from 0.10.0 to 0.10.2. Found this problem through debug information @ccordoba12 suggested.
I am on spyder 4.2.3 and Ubuntu 20.04

I'm having this issue with spyder 5.3.3.


Optionally support datadog apm for observability and monitoring.

Feature Request
I see https://github.com/svix/svix-webhooks/issues/344 is also reported. However, our team has gone with datadog apm for our observability and tracing needs so it would be best for us.
https://docs.rs/datadog-apm/latest/datadog_apm/

Thanks @alexrejto for the suggestion!
Given that Datadog supports OpenTelemetry (#44 that you mentioned), do you think adding OpenTelemetry will do the trick, or does using OpenTelemetry with Datadog come with limitations?

We'll look into it further. It also seems like the OpenTelemetry Rust library I mentioned above supports Datadog natively because of special extensions to OpenTelemetry.
I'll let you know once we take a look and have something to share.

I'm going to close this, as #344 in now fixed.
Though please reopen this if the OpenTelemetry integration is not sending everything you'd expect to datadog.


feat(typescript-operations): add arrayInputCoercion option

Description
This adds the arrayInputCoercion option to prohibit input type
coercion in the generated TypeScript definition.
Related #5352
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Thank you @BridgeAR , this is great!


Fix vcs foreground color

The VCS segment defined on every piece the foreground color itself. That was from a time when I wanted to emphasize more relevant information by a stronger color. Other informations needed therefore to be displayed in weaker colors (like "dark grey" instead of "black").
Here I removed this completely, so the dynamic overriding mechanism can take place.
This fixes #213. Thx @bartlibert for the report.

I like this change a lot, and I also like your design for addressing it, @dritter.
I have one question about the state map (three vs four states). Once we get that resolved, I can address #217 on top of these changes.

@bhilburn Done. Corrected that comment. :)
I had four states in mind thinking that the action (like rebasing, merging) is a state of its own.


HMS-1419: worker/server: optimized JobResult fetching

TLDR:  This pull request is a first step at fixing the bandwidth consumption issue between composer and the dbjobqueue.
The reason why we are doing this:

it has been observed huge consumption spikes in bandwidth on the production platform.
we are afraid of scalability issues on the long run if more people are using the web service

What's going on:
It turns out that in many places in the code base, when composer wants to access a job state, it will request from the DB the JobResult, which is a JSON blob that can be quite heavy. For the order of magnitude, one OSBBuild JobResult can weight around 90K for a fedora36 build.
The constraints around this work:

The reason why we had to transit a result blob is because its content is not API, and is not aimed to be API. The rework needs to preserve that property. The changes can't lock us in a corner API-wise and retro-compatibility-wise. Meaning that changes to the way we request data from postgres must be minimal and not dependent of the JobResult content.
The only way we can really  decrease bandwidth usage is to stop transiting the result blob when we don't really need it in its entirety.

The way the change is orchestrated:

[ ] rewrite description

Testing:

[x] Added new tests in the internal/jobqueue/jobqueuetest/jobqueuetest.go.

Alternative solutions:
Caching was also another option. But it turns out quite often a user will only request once a full blob, caching can't really help us here.

The new version has landed. The main difference with the one before is that it brings in the possibility to query multiple JSON field at once and to store them into an object that has corresponding json tags setup. It uses reflection to explore the types.

Thanks everyone for your time reviewing :heart:  Let's speak abouth this PR in the team meeting this afternoon :slightly_smiling_face:

I'm closing this PR for now as I think we need another angle to tackle the issue, see https://issues.redhat.com/browse/HMS-1419


[ENH] Support partial term fetching failures

Closes #54

Changes proposed in this pull request:

Add new response model for combined attribute response from all nodes
Refactor out building of combined response into its own function
Gracefully handle any errors from requested nodes
Switch to async process for sending out individual node requests for terms

Checklist

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
[x] PR has a label for the release changelog or skip-release (to be applied by maintainers only)
[x] PR links to GitHub issue with mention Closes #XXXX
[x] Tests pass
[x] Checks pass

For new features:

[x] Tests have been added

For bug fixes:

[x] There is at least one test that would fail under the original bug conditions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 115 (100.0%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 99.707%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
681

Relevant Lines:
683

💛  - Coveralls

:rocket: PR was released in v0.1.0 :rocket:


Stm32F CPU STOP issue

#include "mbed.h"
Serial pc(PA_2, PA_3);

void Callback(){
 char Temp_Data = pc.getc();
 pc.putc(Temp_Data);
}

int main(){
 pc.attach(&Callback,Serial::RxIrq);
 while(1){

 }
}

I am currently using the device Nucleo_F401RE.
But even the same symptoms MBED 2.0, the CPU will stop the moment it takes an interrupt is received.
The compiler is okay to stop using the Microlib the Keil compiler is online and, Keil. It seems there is a problem with the MBED.
Until now Export by an external compiler, but resolved using Microlib The MicroLib there are additional libraries that do not work are looking for what to do now resolved.
Please help.

@Sim-jaeil are you happy to file the issue against the https://github.com/ARMmbed/mbed-os repository where all the boards/platforms code live?

Ping @Sim-jaeil


Incorrect API example for linux.

Description
Documentation on API shows incorrect dlopen() usage.
Steps to reproduce
This is not a run time issue. It is an issue with API.
Environment

RenderDoc version: 1.28
Operating System: Ubuntu 23.04
Graphics API: Vk

The linux example shows incorrect code.
Instead of
dlopen("librenderdoc.so", RTLD_NOW | RTLD_NOLOAD);

it should use:
dlopen("librenderdoc.so", RTLD_NOW);

Otherwise dlopen() will return 0 with dlerror() giving no useful feedback.
The affected page is at:
https://renderdoc.org/docs/in_application_api.html

I think I misunderstood this... the dlopen will succeed if launched from renderdoc instead of by itself.


Fixed audio recording with opensles.

Simplify recording (eliminate unnecessary thread)
Eliminate buffer copy
Utilize a fixed 2 buffer setup to remove unnecessary allocations

@freerdp-bot test


custom loss function behaving different from build-in loss

Hi,
I just noticed, that when defining a custom loss-function:
def custom_loss(y_true, y_pred): return keras.losses.binary_crossentropy(y_true, y_pred)
The optimization is much slower than using 'binary_crossentropy' directly as loss in the compile function.
Info: I am training a modified U-Net version with Tensorflow as backend.
I would like to know if this is just me or someone else experienced something similar before.
Lukas

@lufol Do you mean the compiling time is slow or the running time? Can you provide a simple code snippet to reproduce it ? Thanks.


add functionality to types

Purpose
Add type functionality to traversals
Changes

Ticket

@stevenbenjamin will this address #37 ?


fsaverage_sym as possible output space?

How difficult would it be to add fsaverage_sym as a possible output space? fsaverage_sym is the hemisphere-symmetric atlas, and it would require an additional step in recon-all,  namely:
# Invert the right hemisphere
xhemireg --s bert
# Register the left hemisphere to fsaverage_sym
surfreg --s bert --t fsaverage_sym --lh
# Register the inverted right hemisphere to fsaverage_sym
surfreg --s bert --t fsaverage_sym --lh --xhemi

(as described in https://github.com/scitran-apps/retinotopy-templates)

Probably not too difficult. It would require:

Add fsaveragesym (note lack of underscore; this is to fit BIDS naming convention) as an option to --output-space
Wrapping those three steps into a small workflow, creating nipype interfaces for xhemireg and surfreg, if they don't already exist. This would conditionally follow recon-all.
Adjust the mri_vol2surf step as needed to correctly resample to the template.

Anything I'm missing? And are you interested in submitting a PR?

I ran the above lines on the bert subject distributed with FreeSurfer 6.0. At least without any multithreading turned on, the second and third steps each took >1 hour, so we would definitely not be turning this on by default, and should make a fairly prominent warning about the increased runtime to potential users.
The xhemireg and surfreg tools do not currently exist in nipype, so they would need to be added, and multithreading should be looked into.

I'm a little bit out of my depth trying to add this in nipype but I can give it a shot. This would be implemented in nipype/interfaces/freesurfer/utils.py?

I might go in registration instead of utils, but to be honest, the organizational scheme is somewhat arbitrary.