[CT-3398] unit tests should support enabled, meta, and tags config

Housekeeping

[X] I am a maintainer of dbt-core

Short description
Folks may want to:

turn unit tests on/off
add metadata to
or add tag(s) to

their unit tests.
In order to do configs we'd have to have model config objects for unit test definitions, create a project object unit_tests dictionary, and merge configs from dbt_project and each individual unit test.
Acceptance criteria
https://docs.getdbt.com/reference/resource-configs/enabled
Unit tests should support the enabled, meta, and tags config:
By resource path in dbt_project.yml:
unit-tests:
  <resource-path>:
    +enabled: ...
    +meta: ...
    +tags: ...

Or in unit test definition yml:
unit-tests:
  - name: test_my_model
    model: my_model
    config:
      enabled: false
      meta:
        owner: "@doug"
      tags: my_favoirte_unit_tests
    given:
      - input: ref('my_model_a')
        format: csv
	rows:
          - {id: 1, name: gerda}
          - {id: 2, b: michelle}
    ...

Impact to Other Teams
none
Will backports be required?
no
Context
No response

Notes from estimation:

tags already works when set in the unit test definition (but ? when set in the dbt_project.yml, which requires a config object)
https://github.com/dbt-labs/dbt-core/pull/8565 (already has meta and tags)

Alternative ways to provide folks the ability the exclude all unit tests in a given environment:

flag
...

enabled can be configured for all the other resource types that I tried out:

models
seeds
snapshots
sources
exposures
semantic models
generic data tests
singular data tests
analyses

resource type
dbt_project.yml
properties YAML
config() macro

models
✅
✅
✅

snapshots
✅
✅
✅

seeds
✅
✅
❌

sources
✅
✅
❌

exposures
✅
✅
❌

semantic models
✅
✅
❌

analyses
❌
✅
✅

singular data tests
✅
❌
✅

generic data tests
✅
✅
❌

unit tests
❌
❌
❌

Example files

models/metricflow_time_spine.sql
{{ config(materialized='table') }}

select cast({{ dbt.string_literal("2000-01-01") }} as date) as date_day

Note: singular data tests can't be disabled within a YAML file (like models/_properties.yml,  but either dbt_project.yml or config() within SQL file are options.
tests/singular_data_test.sql
-- { { config(enabled=false) }}

select *
from {{ ref('metricflow_time_spine' )}}
where 0=1

snapshots/my_snapshot.sql
{% snapshot my_snapshot %}

{{
    config(
      target_database=target.database,
      target_schema=target.schema,
      unique_key='id',
      strategy='check',
      check_cols='all',
    )
}}

select 1 as id

{% endsnapshot %}

seeds/my_seed.csv
id
1

Note: analyses can't be selectively disabled within dbt_project.yml -- they inherit the config from models within dbt_project.yml.
analyses/my_analysis.sql
-- { { config(enabled=false) }}

select 1 as id

models/_properties.yml
models:
  - name: metricflow_time_spine
    config:
      enabled: true
    columns:
      - name: date_day
        data_tests:
          - not_null:
              name: generic_data_test
              config:
                enabled: true

sources:
  - name: my_source
    tables:
      - name: my_source_table
    config:
      enabled: true

seeds:
  - name: my_seed
    config:
      enabled: true

snapshots:
  - name: my_snapshot
    config:
      enabled: true

analyses:
  - name: my_analysis
    config:
      enabled: true

exposures:
  - name: my_exposure
    type: dashboard
    owner:
      email<EMAIL_ADDRESS>    config:
      enabled: true

metrics:
  - name: my_metric
    label: my_metric
    type: derived
    type_params:
      expr: revenue - cost
    config:
      enabled: true

semantic_models:
  - name: my_semantic_model
    model: ref('metricflow_time_spine')
    config:
      enabled: true

saved_queries:
  - name: my_saved_query
    query_params:
      metrics:
        - my_metric
    config:
      enabled: true

unit_tests:
  - name: my_unit_test
    given: []
    model: metricflow_time_spine
    expect:
      rows:
        - {date_day: 2000-01-01}
    # Note: this does NOT have any effect
    # So need to comment out or delete this unit test if its associated model(s) are disabled
    config:
      enabled: true

dbt_project.yml
name: "my_project"

# Note: also disables analyses!
models:
  my_project:
    +enabled: true

seeds:
  my_project:
    +enabled: true

snapshots:
  my_project:
    +enabled: true

sources:
  my_project:
    +enabled: true

exposures:
  my_project:
    +enabled: true

metrics:
  my_project:
    +enabled: true

# Note: inconsistent to have "semantic-models" with a dash, but "data_tests" and "unit_tests" with underscores
semantic-models:
  my_project:
    +enabled: true

# Note: this has no effect -- must configure within properties.yml or config() within the analysis file
analyses:
  my_project:
    +enabled: true

data_tests:
  my_project:
    +enabled: true

# This has no effect -- there is no way to disable a unit test outside of commenting it out or excluding it from the selection.
# It will give the following warning:
#   [WARNING]: Configuration paths exist in your dbt_project.yml file which do not apply to any resources.
#   There are 1 unused configuration paths:
#   - unit_tests.my_project
unit_tests:
  my_project:
    +enabled: true

Run this command to see which resources are enabled:
dbt list --resource-type all

Then change the enabled config for one or more resources and re-run the dbt list command above to see if it disappears or not.

Workarounds
Currently, there's a handful of ways to prevent a unit testing from running:

Comment it out within the YAML. i.e. add a leading #  to the beginning of each line
Delete the unit test definition entirely
Move the unit test YAML. i.e. move it to a folder that is outside of the model-paths: [directorypath] configured in dbt_project.yml (e.g. disabled_unit_tests)
Add a tag and then --exclude that tag (using the "tag" method)

I need to conditionally enable/disable unit tests in the audit helper repo, because (for example) some use SQL fixtures which have different syntax on different platforms.
I've gone with this, but I do not like it:
unit_tests:
  [...]
    config:
      tags: "{{ 'works_on_my_machine' if (target.type in ['snowflake', 'bigquery']) else 'skip' }}"

And the CircleCI job will have this defined:
dbt build --exclude tag:skip

@joellabes sounds like what you're actual after is something like conditional fixtures?
unit_tests:
  - name: test_my_model
    model: my_model
    given:
      - input: ref('my_model_a')
        format: csv
        fixture: "{{ 'my_model_a_fixture_snow_bq' if (target.type in ['snowflake', 'bigquery']) else 'my_model_a_fixture_other' }}"
    ...

Ooooh that's a fun idea! In practice I wouldn't want to have to make a dozen or more fixture files though, the fact that I can put it inline in the yaml is pretty compelling to me.
Secondarily, I also worry that the conditional Jinja logic would get horrendous if it wasn't just a binary option. Although I guess I could do {{ target.type }}_fixture_1.sql instead of an if block (were I willing to make files for each of them)

Just adding a +1 for this issue. We use enabled: to dynamically turn models on and off depending on the deployment region (not all models are applicable in all geographies).
Applying unit tests to models which are disabled in a particular region causes the DBT compile to fail. This means we're unable to adopt the new unit testing functionality :'(.

We would want to move the disabled unit tests to the disabled dictionary.

In the meantime, did you try out the workaround using tags, by any chance?

Hey @dbeatty10 apologies for the slow reply. Unfortunately the tags approach doesn't work for our current setup...
production-frankfurt:data ❯ dbt test -s alerts --exclude tag:skip
15:31:20  Running with dbt=1.8.1
15:31:21  Registered adapter: snowflake=1.8.2
15:31:21  Unable to do partial parsing because profile has changed
15:31:29  Encountered an error:
Parsing Error
  Unable to find model 'snowflake_db_transformations.alerts' for unit test 'unresolved_qualified_and_resolved_alerts' in models/inbox/alerts/alerts.yml

In the example above the alerts model has a unit test which has been tagged with skip but because this model is disabled in the selected environment (production-frankfurt) the compilation step fails before the test command can be run. Does that make sense?
I think the only way to make the tags approach work is to enable all models in all environments (and use tags to control the execution of models in different regions). We tried this approach but ran into complications with slim-ci because the manifest.json doesn't accurately reflect the models deployed in a given environment (it includes all of them regardless).

Let's do #10540 together with this issue.

I can confirm that the tags approach doesn't work

@adionisio8 we're hoping to pick this up soon! PR has been opened

Hi! @graciegoheen do you have a link to the PR? Thanks

Closed by https://github.com/dbt-labs/dbt-core/pull/10831

Opened a new issue in dbt-labs/docs.getdbt.com: https://github.com/dbt-labs/docs.getdbt.com/issues/6427


It would be great if one could send attachments such as images

Hmm, yeah, that could be nice. Do you have a suggestion of how you'd want the interface to work for that?

@timabbott, i thought a bit about it. One option could be to allow markdown in the content field of github-actions-zulip, similar to how zulip itself references attachments. The URL could then be an absolute/relative filesystem URL. However, this might open some security holes, so you probably want this to be opt-in with a flag. Alternatively, the content string could allow placeholders for filenames "This is a message File", and an extra files field would then be used to map placeholders to local filenames.


Define Instance, Module, etc. inside Wasmer module

PHP has a namespace feature but Ruby does not. In Ruby, we define classes inside of module instead.
module Wasmer
  class Instance
    def initialize
      # ...
    end
  end
end

instance = Wasmer::Instance.new()

I changed to define classes inside the Wasmer module to prevent the global namespace from being polluted with generic name such as Module.

Thanks for the PR! It's much better like this :-).


Cannot save if remove_trailing_spaces is enabled

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[ ] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
After PR #13295, if "Automatically remove trailing spaces when saving files" is enabled, an exception is raised and the file is never saved.
This happens because remove_trailing_spaces is defined here as a method and here as an attribute assigned in __init__, there the method defined in CodeEditor is replaced by False.
What steps reproduce the problem?

Enable "Automatically remove trailing spaces when saving files" in Editor preferences
Open a file in the editor
Save it

Paste Traceback/Error Below (if applicable)

Traceback (most recent call last):
  File "/home/Public/spyder/spyder/plugins/editor/widgets/editor.py", line 2075, in save
    self.remove_trailing_spaces(index)
  File "/home/Public/spyder/spyder/plugins/editor/widgets/editor.py", line 2880, in remove_trailing_spaces
    finfo.editor.remove_trailing_spaces()
TypeError: 'bool' object is not callable

Versions

Spyder version: 4.2.0dev0 1c3583e
Python version: 3.6.9

I can confirm behavior with bootstrap on Python 3.7.9 (#14009 )

@andfoy , as @trollodel astutely observed, remove_trailing_spaces is defined as a method in CodeEditor and an attribute initially set to false in the superclass TextEditBaseWidget. It was likely not an issue until your recent edit because the attribute was spelled differently (remove_trailling_spaces) in TextEditBaseWidget.


Fix TextBlock auto sizing when TextWrapping | TextTrimming is used

What does the pull request do?

It introduces rounded values for TextLayout.Size
What is the current behavior?

Currently, the TextLayout's size isn't rounded. Because of that in some situations, the TextLayout produces trimmed or wrapped lines when it shouldn't.
What is the updated/expected behavior with this PR?

Auto sizing should now work properly.
How was the solution implemented (if it's not obvious)?

The TextLayout's size is rounded when the layout is finished.
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes: #6698

Turned out we need a different approach to fix auto sizing


Stat with illustration padding issue

Fixes MERATIVE-950
Description
The stat with illustration block was designed to only have an image below it. We would like to update this block to ensure there is the proper padding added above/below when an image is not present.
Test URLs

Before (Changes from main): https://main--merative2--hlxsites.hlx.page/drafts/Keith/real-world-evidence-copy
After (Changes from this PR): https://stat-with-illustration-padding-issue--merative2--nimithshetty17.hlx.page/drafts/Keith/real-world-evidence-copy

@keith-kaplan have added the bottom padding. Let me know if this is ok.

No worries. This looks good to me. @sachinmesh  @anabarcelona  want to take a look? https://stat-with-illustration-padding-issue--merative2--nimithshetty17.hlx.page/drafts/Keith/real-world-evidence-copy

@nimithshetty17  I just saw the Figma file. I think we need to make the number stat a gradient like the content intro stat block.

The width of the stat component is wrong, it should be desktop is 360px, tablet 275px, mobile 270px @nimithshetty17

CC: @keith-kaplan @anabarcelona

@sachinmesh please check now.
cc: @keith-kaplan


styling: default.theme incomplete

The widget should apply the Bootstrap modal styling to the popup. It seems that it relies on classes that are not part of the default.theme.

Fixing this by adding the missing CSS classes.
The "right way" to do this is by changing the PopupWidget to use Bootstrap CSS instead.

Fixed on master (v1.5.0) and release-1.4.x (v1.4.2).


Fixed a small typo

Changed "Azure DataL Lake Storage" to "Azure Data Lake Storage"

@rablaine : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Background color

i want the background color to change based on which item is selected

There is no built in option for defining this, but you can achieve it pretty easily by subclassing PagingCell and setting the background color based on the selected state. Just create your own subclass and override setPagingItem:
class CustomPagingCell: PagingTitleCell {

  override func setPagingItem(_ pagingItem: PagingItem, selected: Bool, theme: PagingTheme) {
    super.setPagingItem(pagingItem, selected: selected, theme: theme)

    if selected {
      contentView.backgroundColor = .red
    } else {
      contentView.backgroundColor = .white
    }
}

Then set the menuItemClass property to CustomPagingCell.self:
struct Options: PagingOptions {
  let menuItemClass: PagingCell.Type = CustomPagingCell.self
}

And pass that into the PagingViewController:
FixedPagingViewController(viewControllers: viewControllers, options: Options())

This will set the background color when the selected state changes, without any animation. If you want to tween between the colors based on how much the user has scrolled, you can override apply:layoutAttributes instead of setPagingItem:
class CustomPagingCell: PagingTitleCell {

  open override func apply(_ layoutAttributes: UICollectionViewLayoutAttributes) {
    super.apply(layoutAttributes)
    if let attributes = layoutAttributes as? PagingCellLayoutAttributes {
      contentView.backgroundColor = UIColor.interpolate(
        from: .white,
        to: .red,
        with: attributes.progress)
    }
  }

}

This will interpolate between the selected background color based on the scroll progress. I'm using UIColor.interpolate here which you can find the source code for inUIColor+interpolation.swift.

huum thanks, one more question, oh i get click on menu cell?

If you are using FixedPagingViewController you can use the FixedPagingViewControllerDelegate to get notified when an item was scrolled to:
public protocol FixedPagingViewControllerDelegate : class {
  func fixedPagingViewController(fixedPagingViewController: FixedPagingViewController, willScrollToItem: ViewControllerItem, atIndex index: Int)
  func fixedPagingViewController(fixedPagingViewController: FixedPagingViewController, didScrollToItem: ViewControllerItem, atIndex index: Int)
}

Or if you need the actual select event you create your own subclass and override didSelectItem:
class MyPagingViewController: FixedPagingViewController {
  override public func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
    super.collectionView(collectionView, didSelectItemAt: indexPath)
    print("did select")
  }
}

class ViewController: UIViewController {
override func viewDidLoad() {
super.viewDidLoad()
// Load each of the view controllers you want to embed
// from the storyboard.
let storyboard = UIStoryboard(name: "Main", bundle: nil)
let firstViewController = storyboard.instantiateViewController(withIdentifier: "FirstViewController")
let secondViewController = storyboard.instantiateViewController(withIdentifier: "SecondViewController")

// Initialize a FixedPagingViewController and pass
// in the view controllers.
let pagingViewController = FixedPagingViewController(viewControllers: [
  firstViewController,
  secondViewController
])

// Make sure you add the PagingViewController as a child view
// controller and contrain it to the edges of the view.
addChildViewController(pagingViewController)
view.addSubview(pagingViewController.view)
view.constrainToEdges(pagingViewController.view)
pagingViewController.didMove(toParentViewController: self)

}
}
sorry for my poor knowledge, but in a class like this how I create mine subclass and override didselectitem?

You need to create a new class outside ViewController – like the MyPagingViewController snippet above – and replace this line:
let pagingViewController = FixedPagingViewController(viewControllers: [

with this:
let pagingViewController = MyPagingViewController(viewControllers: [

thanks for support :)

No problem, happy to help!

hi, its me again..... can u explain me "If you are using FixedPagingViewController you can use the FixedPagingViewControllerDelegate to get notified when an item was scrolled to", i dnt know who to use delegate :/..

No worries, the documentation for this isn't very good. You need to conform to the FixedPagingViewControllerDelegate protocol in you ViewController class. Here an example:
extension ViewController: FixedPagingViewControllerDelegate {

  func fixedPagingViewController(fixedPagingViewController: FixedPagingViewController, willScrollToItem: ViewControllerItem, atIndex index: Int) {
    print("will scroll to item")
  }

  func fixedPagingViewController(fixedPagingViewController: FixedPagingViewController, didScrollToItem: ViewControllerItem, atIndex index: Int) {
     print("did scroll to item")
  }

}

Then set the itemDelegate property in viewDidLoad:
pagingViewController.itemDelegate = self

hi, i think i found a bug, in fixedPageViewController u have :
open override func em_pageViewController(_ pageViewController: EMPageViewController, didFinishScrollingFrom startingViewController: UIViewController?, destinationViewController: UIViewController, transitionSuccessful: Bool) {
super.em_pageViewController(pageViewController, didFinishScrollingFrom: startingViewController, destinationViewController: destinationViewController, transitionSuccessful: transitionSuccessful)
    if let index = items.index(where: { $0.viewController == destinationViewController }) {
        itemDelegate?.fixedPagingViewController(
            fixedPagingViewController: self,
            didScrollToItem: items[index],
            atIndex: index)
    }
}

i think u need check if transition is successful because if u do a "fake swipe" and dnt swipe to next menu tab and stay on same menu tab and didscroolToItem is activated.... in my opinion the code looks like this:
open override func em_pageViewController(_ pageViewController: EMPageViewController, didFinishScrollingFrom startingViewController: UIViewController?, destinationViewController: UIViewController, transitionSuccessful: Bool) {
super.em_pageViewController(pageViewController, didFinishScrollingFrom: startingViewController, destinationViewController: destinationViewController, transitionSuccessful: transitionSuccessful)
if transitionSuccessful == true {
    if let index = items.index(where: { $0.viewController == destinationViewController }) {
        itemDelegate?.fixedPagingViewController(
            fixedPagingViewController: self,
            didScrollToItem: items[index],
            atIndex: index)
        }

     }
  }

Yeah, that's definitely a bug. I also found another bug were the willScrollItemItem was not called at all. Fixed in #63 – will release a new version soon. Thanks for catching that 🙌

u welcome :)


Data visualization

Summary

[x] Visualize SAR data in python notebook
[ ] Download a chunk of the data for visualization (sea ice concentration STAR blended)

Marking this as complete


TimeZoneInfo.ConvertTime() errors

I'm doing as in "Planets Data" of you Readme:
But I need results for a specific date and time.
So I Created this.
DateTime UTC = new DateTime(MyDateTime.Value.Year, MyDateTime.Value.Month, MyDateTime.Value.Day, MyDateTime.Value.Hour, MyDateTime.Value.Minute, MyDateTime.Value.Second, DateTimeKind.Utc);
TimeZoneInfo zoneUTC = TimeZoneInfo.FindSystemTimeZoneById("Greenwich Standard Time");

and when I insert to your:
Moon object = new Moon(Lat, Long, TimeZoneInfo.ConvertTime(UTC, zoneUTC);
I get error: "Cannot convert from "System.DateTime" to "System.TimeZoneInfo"
I used many different setups (e.g. using basic "DateTime.Now") and this happens every time, when something calls to "TimeZoneInfo".
I use vs2019, and I'm working on NET Core 3.1.
Maybe something needs to be updated. Or something is wrong in the callback three for ConvertTime.

I refactor the code using .NET Core and make the code public. Try this new version~

From what I can see, you have extended/corrected references under:
„AstroAlgo.Basic”, old „AstroAlgo.Base”.
„AstroAlgo.Models”, old „AstroAlgo.Model”.
But Objects under:
“AstroAlgo.SolarSystem”
have missing references, except for “Equals”.
Codes like:
“Sun star1 = new Sun(Lat, Long, TTimeZoneInfo.Local)” do not work anymore;

FOR All Objects under “AstroAlgo.SolarSystem”.
I have no better way to compare you old code, then just compare references in my project.
Definitely, the Old one is still useful.
I would say that “We” are working on the Beta, of the future version 😃, but you should enable old one.
I'm not actually doing anything, but If you care to give me access to Old code, I would be happy to help.
Even if I'm still new in Coding.

I refactored the class. The original problem is that only parameters of DateTime.Now can be calculated. You can now calculate the parameter at the specified time. I will finish the documents as soon as possible.😄
The old code is here https://github.com/ZhangGaoxing/AstroAlgo/tree/d4c51f70918ce7bc111415c31cf05e4dfc59cb07

The document is here https://github.com/ZhangGaoxing/AstroAlgo/tree/master/docs/en 😄


Port to .NETCore/.NETStandard ?

System.Security.Cryptography.HMACSHA256 does not have Hash() and TransformFinalBlock() in .NETCore.
.NETCore documentation link

I believe it shouldn't be that hard to port it.
I will dig into it this week and I will let you know.

If this helps : https://github.com/dotnet/corefx/issues/9442

Ah yes, took about 2 lines to port (most of the commits are to fix my own mistakes) , however travis deployment would require  scripts for .NET Core so I am not submitting a pull request.

Thanks for that @prajaybasu
I have to keep compatibility with .NET 2.0, I will check how to keep it working with .NET 2.0 and .NET Core 1.0 and then I will release a new version on NuGet.

Just to let you know, I've released a new version on NuGet, this version contains a DLL for .NET 2.0 and another for .NET Core (netstandard 1.3).
I also added your references in the AUTHORS file.
Thanks again.


Rename pyvrp.educate to pyvrp.search

This PR:

[x] Closes #239.
[ ] Adds and passes relevant tests.
[x] Has well-formatted code and documentation.

Notes:

It is essential that you add a test when making code changes.
This keeps the code coverage level up, and helps ensure the changes work as intended.
When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
Docstring additions must render correctly, including escapes and LaTeX.

@leonlan could you also review this final change for #239? Again fairly mechanical, pyvrp.educate -> pyvrp.search.


tags: fix non-latin tag display on pages

Cyrillic tags are not displayed on the page
It started a few updates ago

Could you print your page's content here?

config.toml
`baseURL = '/'
languageCode = 'en-us'
title = 'My New Hugo Site'
theme = "hugo-theme-relearn"
[outputs]
home = [ "HTML", "RSS", "SEARCH"]`

Fixed. Thanks for reporting.


Remove deprecated Gamelift MatchMaking resources

Remove deprecated Gamelift MatchMaking resources.
This is a reminder for the next major release of pulumi-aws.
These got deprecated in:  https://github.com/pulumi/pulumi-aws/pull/4257

Before going forward, confirm no paying customers affected.


Carcinogenesis NamedIndividual having True and False for the same property

Is it even possible ?!
    <owl:NamedIndividual rdf:about="http://dl-learner.org/carcinogenesis#d135">
        <cytogen_ca rdf:datatype="http://www.w3.org/2001/XMLSchema#boolean">false</cytogen_ca>
        <cytogen_ca rdf:datatype="http://www.w3.org/2001/XMLSchema#boolean">true</cytogen_ca>
    </owl:NamedIndividual>

I think technically this is possible but semantically it doesn't make sense. I noticed that this individual is the only one that has this property assigned twice. Its probably a mistake.

Exactly


Fix explanation utils DataMapper docs

Signed-off-by: Chris Gregory<EMAIL_ADDRESS>

Looks like _transform_data() is not called from anywhere in this repo. Maybe it should be cleaned up as this is an internal function. @imatiach-msft what do you think?

@gaugup great find, it does look like it's not used anywhere, and since it's a private function I agree that we can just remove it

@gregorybchris it might be a good idea to look at all the methods in explanation_utils.py and clean up the other internal mehods which aren't used by this package.

Opened feature request https://github.com/interpretml/interpret-community/issues/372


feat: add feature rules

Current situation
There is no support for feature rules.
Proposal
Add support for all three feature rule types including force, rollout and experiment.
Note this feature is backwards compatible meaning as long as .rules is null aka not set existing manually created rules are not removed. However as longs as the rules are set either with at least one rule or an empty slice any manually created rules from the related feature are removed!
Note: rules have an internal id which the web ui sets if created via the ui. Now it seems also to work if the id is not set at all which is what this pr does atm. The nice thing is if there is no id the web ui displays the rules in a greyish output. It looks like it can't be modified (it can be still). Didn't check if thats a growthbook feature on purpose though.

Fantastic work!
Question: I see that you also implemented SavedGroupTargeting, ScheduleRule and ExperimentRules... Those typically reference another object, like an experiment in the experiments collection or a saved group in the savedgroups collection. I assume (from the code) that these are not managed by the controller?

They are there for the sake of feature rule api spec completeness but no things like experiments are not supported by the controller for now.

58ab6bb5d3f4adf3e801468a68235f7bb506b637 now keeps manually created rules. Also see updated pr description.


improve testsuite runtime

pytest fixtures allow scoping at many levels to reuse objects between tests. by moving our migrations to the "session" scope, we can skip the expensive process.
since the db_session already uses PostgreSQL SAVEPOINT statements to isolate tests, this works without a hitch!
this change reduced testing time (comparing between two runs only) by about 90%
before:
real	7m29.159s
user	0m0.652s
sys	0m0.254s

after:
real	0m40.297s
user	0m0.666s
sys	0m0.279s

Travis results... again a single case... but still!
before:
11 min 39 sec

after:
7 min 28 sec

Beautiful. 🤩

Part of me feels like there was a reason I did that, but fuck if I can remember what it was or if it's still valid. so 💯


ENH: special: add the analytic continuation of Riemann zeta

Reference issue
Closes gh-10277.
What does this implement/fix?
The analytic continuation of the Riemann zeta function (i.e. the one-argument version of special.zeta) is added.
Additional information
The implementation is done by reusing parts of the zetac implementation, which already has the analytic continuation. Mpmath and special cases tests are added, and the test_zeta.py file is also cleaned up a bit.

needs rebase

Rebased.


UART bootloading for STM32H7/Durandal not functional

The H7 in-tree bootloader does not seem to work with UART bootloading.
I tried using an FTDI connected to TELEM2 to flash a Durandal, but the board doesn't stay in bootloader, and neither does the uploader detect the bootloader.
./Tools/px_uploader.py --port /dev/ttyUSB0 --baud-bootloader 115200 build/holybro_durandal-v1_default/holybro_durandal-v1_default.px4

Some inital notes:

The bootloader should be listening on USART3 at 115200 baud
https://github.com/PX4/Firmware/blob/0b74076265edda2ac34cb9c4addcfeea7277d3a2/boards/holybro/durandal-v1/nuttx-config/bootloader/defconfig#L82
https://github.com/PX4/Firmware/blob/0b74076265edda2ac34cb9c4addcfeea7277d3a2/boards/holybro/durandal-v1/src/hw_config.h#L72
SERIAL_BREAK_DETECT_DISABLED is set by default. Could this be the reason? https://github.com/PX4/Firmware/blob/0b74076265edda2ac34cb9c4addcfeea7277d3a2/boards/holybro/durandal-v1/src/hw_config.h#L86

@amikhalev fyi

@davids5 any ideas?

OK it was indeed SERIAL_BREAK_DETECT_DISABLED=1. Works now:

Any reason why it's set by default?
Can we disable the flag on master, and set a higher baudrate (e.g 921600) to enable UART bootloading by default on H7?

@davids5 I also noticed that the B/E LED stopped working when I updated the bootloader to whatever is on master.

I could not get it working at higher baud rates beyond 115200, even after adjusting these lines:

https://github.com/PX4/Firmware/blob/master/boards/holybro/durandal-v1/src/hw_config.h#L72
https://github.com/PX4/Firmware/blob/master/platforms/nuttx/src/bootloader/stm32h7/main.c#L197

Looks like I just needed a make clean because things aren't correctly rebuilt. Works at 921600 and 3000000 now.

We'll open a PR enabling this on all H7 boards @ 921600 baud.


Inputs inside cells are focused unintentionally

Same as #398
I'd like to make an editable spreadsheet with the input in each cell. Everything works fine and fast the only issue is that when I focus any input every other n-th row input is focused as well (n depends on the height of the table).
Clicked:

Scrolled:

Hey,
This repo isn't maintained anymore, so we can't even offer a PR to fix this.
We have a fork that is actively being worked on.
Free free to file an issue and we can help you out!


10.15.1 Malware

Hi,
macOS 10.15.1 complains this app will damage your Mac and moves it to the Trash.

Please see #17 #16 #12 #15 #10 etc.
This is, of course, not a malware.


Rotation Icons/Refactoring/Fix minor bugs

@rsinghal
I change the rotation circle to icon. The icon here is temporary until we agree on which one to use.When we choose one I will change it.
I fixed some bugs related to selecting elements. Currently, before those fixes you were able to select sometimes more than one shape at a time which was rather buggy.
I refactored all unit tests. Most of them still need more refactoring because they depend on other tools to test themselves which is not right. I included a dummy tool but its not used anywhere. I'll refactor them step by step with the new functionality.
After we merge this I am thinking to start implementing 2.iii.a.b.a for which I will also need a proper trashcan icon.
For now they will be hardcoded because there is some math behind them, but in future I'll try to make them to come as configuration (both rotation and deletion icons)

Coverage decreased (-0.6%) to 43.894% when pulling 1932dd88254e00c3f60989279f5283515ff308aa on SirmaITT:feature/rotate-icon into d47faf57ba8dc39a95e30c2415317efe5e263d88 on IIIF:annotation-work.

Coverage decreased (-0.2%) to 44.31% when pulling 52665b9a5c242034a6f78b13891c92a22a3df629 on SirmaITT:feature/rotate-icon into d47faf57ba8dc39a95e30c2415317efe5e263d88 on IIIF:annotation-work.

Coverage increased (+0.08%) to 44.584% when pulling 55514c50f68d1caf45dd073490bb2caa0ca21398 on SirmaITT:feature/rotate-icon into d47faf57ba8dc39a95e30c2415317efe5e263d88 on IIIF:annotation-work.

Coverage increased (+0.08%) to 44.584% when pulling 55514c50f68d1caf45dd073490bb2caa0ca21398 on SirmaITT:feature/rotate-icon into d47faf57ba8dc39a95e30c2415317efe5e263d88 on IIIF:annotation-work.

Until you are ready to completely remove awesome cursor from the code, can you comment out using the new icon since it is showing both right now.
http://jsfiddle.net/rna9qv6m/ is another alternative for the icon

@rsinghal  I changed the the rotation handle to become an image. I did not changed any cursor icons yet.
What do you mean by

it is showing both right now.

Also, the length of the line above the rectangle (for the rotation handle) and the new rotation icon do not properly scale as you zoom in and out.  If you start off fully zoomed in and click on a shape and then zoom fully out or vice versa, you will see the issue.

@rsinghal I saw that issue with zoom in/out Ill try to fix it. What do you suggest about the rotation cursor?

For now, let's just keep using awesome cursor until we can think through this some more.  Since you also need to add the trash can icon with the shape on edit, the rotation icon can be revisited then.

@rsinghal  Okey Ill comment in the the rotate icon which is attached to the shape?

Yes, sounds good.

@rsinghal I'll be ready in few minutes and then start working on the trash can :+1:

@rsinghal It should be same as before + some fixes :) . Would you please give me some info from where I can get the rotation handle icon and trash can images.

Coverage decreased (-0.2%) to 44.269% when pulling 0ed2765f0eefc33aa12a29d8bd41fd5e82c1aaf6 on SirmaITT:feature/rotate-icon into d47faf57ba8dc39a95e30c2415317efe5e263d88 on IIIF:annotation-work.

Coverage decreased (-0.2%) to 44.269% when pulling 0ed2765f0eefc33aa12a29d8bd41fd5e82c1aaf6 on SirmaITT:feature/rotate-icon into d47faf57ba8dc39a95e30c2415317efe5e263d88 on IIIF:annotation-work.


Move to Jellyfish organization

This should be moved to the jellyfish organization & made public.

Closed by moving it and #218


HTTP Verb Error 1704

Hey there, I am using your fmRest API since a while and everything works great thanks! However, when I try to use findRecords, I always get this error: Resource doesn't support the specified HTTP verb [code] => 1704
I tried debugging it, looked at your fmrest.php file and so on but never found out what's wrong..
Do you have any idea concerning this topic?
Kind regards
Yassin

Please post a snippet of sample code of the query you are trying to make, otherwise it's incredibly difficult for anyone to assist in troubleshooting.

@mbcbus you are right, sorry for that, here is a snippet of the findRecords code:
include_once('fmREST.php');
$fm = new fmREST();
$fm->host = 'xy.xyz.com';
$fm->db = 'X.fmp12';
$fm->user = 'username';
$fm->pass = 'password';
$layout = 'X';
$date = new DateTime('NOW');
$date = $date->format('Y-m-d H:i:s');
$timestamp = strtotime($date);
$request1['typ'] = '0';
$query = array($request1);
$data['query'] = $query;
$data['limit'] = 1;
$result = $fm->findRecords($data);

Is your X::typ field a number or text field? You are casting zero to a string in your find request which might matter for accurate results.
Also, is the X::typ field on the $layout you are setting to perform the find?
What version of filemaker server?
What's the output of $fm -> show_debug = true; if you add this after your call: print_r ($fm->debug_array);
Have you tried another example call that isn't layout/find specific? Such as: $result = $fm -> layoutNames (); to confirm the Data API is working properly?
Also, your DB name includes the ".fmp12" extension, which I do not believe is needed.

X::typ is a number and it is shown in the layout.
The Filemaker server runs with the version: <IP_ADDRESS>9
The output is:
Array ( [login start cookie] => Array ( [fmtoken] => [Phpstorm-x] => X [_ga] => X ) [login existing token] => X [Succeeded initial login] => Array ( [response] => Array ( [token] => X) [messages] => Array ( [0] => Array ( [code] => 0 [message] => Already have a token. ) ) ) [pre-payload: ] => Array ( [query] => Array ( [0] => Array ( [typ] => 0 ) ) [limit] => 1 ) [not empty token on call] => X [payload: ] => Array ( [query] => Array ( [0] => Array ( [typ] => 0 ) ) [limit] => 1 ) [header] => Array ( [0] => Authorization:Bearer X [1] => Content-Type: application/json ) [url] => https://x.x.com/fmi/data/vLatest/databases/X.fmp12/layouts//_find [call error: ] => [call result: ] => {"messages":[{"message":"Resource doesn't support the specified HTTP verb","code":"1704"}],"response":{}} [call info: ] => Array ( [url] => https:// https://x.x.com/fmi/data/vLatest/databases/X.fmp12/layouts//_find [content_type] => application/json [http_code] => 405 [header_size] => 333 [request_size] => 245 [filetime] => -1 [ssl_verify_result] => 0 [redirect_count] => 0 [total_time] => 0.081742 [namelookup_time] => 0.019166 [connect_time] => 0.026888 [pretransfer_time] => 0.071603 [size_upload] => 33 [size_download] => 105 [speed_download] => 1296 [speed_upload] => 407 [download_content_length] => -1 [upload_content_length] => 33 [starttransfer_time] => 0.071611 [redirect_time] => 0 [redirect_url] => [primary_ip] => xxx.xxx.xx.xx [certinfo] => Array ( ) [primary_port] => xxx [local_ip] => xxx.xxx.x.xxx [local_port] => xxxxxx [http_version] => 3 [protocol] => 2 [ssl_verifyresult] => 0 [scheme] => HTTPS [appconnect_time_us] => 71390 [connect_time_us] => 26888 [namelookup_time_us] => 19166 [pretransfer_time_us] => 71603 [redirect_time_us] => 0 [starttransfer_time_us] => 71611 [total_time_us] => 81742 ) [findRecords pass 1] => Array ( [messages] => Array ( [0] => Array ( [message] => Resource doesn't support the specified HTTP verb [code] => 1704 ) ) [response] => Array ( ) ) [login result] => Array ( [response] => Array ( [token] => X ) [messages] => Array ( [0] => Array ( [code] => 0 [message] => OK ) ) ) [login end cookie] => Array ( [fmtoken] => X [Phpstorm-x] => X [_ga] => X ) [checkValidResult] => 2nd login succeeded [findRecords pass 2] => Array ( [messages] => Array ( [0] => Array ( [message] => Resource doesn't support the specified HTTP verb [code] => 1704 ) ) [response] => Array ( ) ) )
Yes I have tried it with createRecord, which is working.

In the URL you show a double slash after "layouts" which would indicate $layout might be null.
You can review starting at line 294:
https://github.com/kdoronzio/fmREST.php/blob/master/fmREST.php
To see how the layout is used to put together the url used in the query.
You haven't modified fmREST.php at all correct?

Look at sample.php lines 11-17 versus your code making the connection to FM.
https://github.com/kdoronzio/fmREST.php/blob/master/sample.php
$host = 'myhost.domain.com';
$db = 'fmREST-sample';
$user = 'fmrest';
$pass = 'paradise';
$layout = 'sample';

$fm = new fmREST ($host, $db, $user, $pass, $layout);

In the sample, $layout is being passed when creating the new object. In your code though, you are setting $layout as a variable without actually using it anywhere.
So in essence, the function in fmREST.php reverts back to the objects default value (set on creation), unless you specifically pass in a $layout argument to the findRecords() method.
You can either adapt your connection code to match the sample above, or just actually USE your $layout variable in the function:
$result = $fm->findRecords($data, $layout);

I'm guessing this is your issue, which was identified by seeing that layout was missing from your URL (although I realize you're masking your url, so I can't be sure).

Thank you so much @mbcbus for your invested time and great explaining! I just tried it out and it works now, the http verb error is gone :) cheers mate 👍


immutable-by-default config option

Hi there,
The use of $ReadOnlyArray<>, covariant { +prop: type }, $Exact<>, and probably others can help enforce immutability in a JS codebase which uses primitives.
However, they're not very convenient to use manually every time.
A config option that makes these the default could be helpful to those trying to enforce immutability in their codebases.
For example:
const arr = [1, 2, 3]; // implicitly a $ReadOnlyArray
arr.push(4) // Error!

const record = { // implicitly $Exact
  foo: 1, // implicitly +foo
  bar: 2, // ditto
};
record.foo = 2 // Error!
record.qux = 3 // Error!

In order to opt-out, a new type may need to be introduced. For example:
const arr: $MutableArray<number> = [1, 2, 3];
arr.push(4); // ok

const record: $MutableObject<string, number> = {
  foo: 1,
  bar: 2,
};
record.foo = 2 // ok
record.qux = 3 // ok

I have not yet used Flow extensively, so please pardon any ignorance here 😄
I think this feature could be popular among the React community especially.

Reading more into this, $Exact may be less useful than covariance and $ReadOnlyArray, given that objects declared this way will be sealed anyway.

@rattrayalex great idea, this would be amazing!
I think it would be better if you could just pass a type into $MutableObject
type MutableThing = $MutableObject<{ id: string, foo: number }>

This would allow you to convert existing types ie:
type Thing = { id: string, foo: number }
type MutableThing = $MutableObject<Thing>

or better yet combine $MutableObject and $MutableArray into $Mutable which accepts either array or object
$Mutable<Array<number>>
$Mutable<{ id: number }>

This should of course also work for classes, ideally with proper support for setters in the constructor:
class Foo extends Bar {
  a = 1;
  constructor(b: number) {
    super(b);
    this.b = b;
  }
  method() {
    this.c = 1 // error!
  }
}

equivalent to
class Foo extends Bar {
  +a = 1;
  +b: number;
  constructor(b: number) {
    (this: any).b = b; // https://github.com/facebook/flow/issues/2646
  }
}

Duplicate of https://github.com/facebook/flow/issues/5369


Automated cherry pick of #8581: fix: compatible with qcloud zonal bucket

Cherry pick of #8581 on release/3.5.
#8581: fix: compatible with qcloud zonal bucket

Codecov Report

Merging #8582 into release/3.5 will decrease coverage by 2.65%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           release/3.5   #8582      +/-   ##
==============================================
- Coverage         6.14%   3.48%   -2.66%
==============================================
  Files              761     307     -454
  Lines           118373   63346   -55027
==============================================
- Hits              7269    2205    -5064
+ Misses          110445   60986   -49459
+ Partials           659     155     -504

Flag
Coverage Δ

#aFlag
3.48% <0.00%> (-2.66%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/notifyclient/notify.go
1.83% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/cachedimages.go
1.73% <0.00%> (-0.04%)
:arrow_down:

pkg/compute/models/capabilities.go
0.00% <0.00%> (ø)

pkg/compute/models/cloudregions.go
1.54% <0.00%> (-0.04%)
:arrow_down:

pkg/compute/models/cloudsync.go
0.00% <0.00%> (ø)

pkg/compute/models/cloudsyncelasticcache.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstance_secgroups.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstancejoints.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstancenetworks.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstances.go
0.75% <0.00%> (+<0.01%)
:arrow_up:

... and 464 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c714f...55b2855. Read the comment docs.

/lgtm

/lgtm

/lgtm

/lgtm

/lgtm

/lgtm


Minor fixes to InstantQueryFromPlan

The query type for instant queries from an existing plan were set to RangeQuery because we were using the same function as the one used for range queries. This leads to empty results for those queries.
We still need to infer the sort order for the instant query, but this might not be needed since the sort would be done at the root anyway.
We will need better integration tests for this function in the future to prevent regressions.

We have the promqlsmith based Fuzz tests for Distributed execution as well. It is probably just skipped during CI.
Does it help capture the problem earlier?

We have the promqlsmith based Fuzz tests for Distributed execution as well. It is probably just skipped during CI. Does it help capture the problem earlier?

We have to revisit them at some point; right now its not easy to get them to run well without failures

Yeah fuzzing is disabled, but we should try enabling it again. We should also use this method in distributed tests, even though it will require adding another for loop :)


fix:_check_proto_obj_attr_exist does not handle None properly

None check in _check_proto_obj_attr_exist is not handled properly.
# is buggy for None check.
if not obj:

# correct way
if obj is None:

# Below code makes one example why it is buggy.

from dfcx_scrapi.builders.fulfillments import FulfillmentBuilder
from google.cloud.dialogflowcx_v3beta1.types import Fulfillment

def main():
    fulfilment_builder = FulfillmentBuilder()
    fullfilment_obj = fulfilment_builder.create_new_proto_obj()
    assert fulfilment_builder.proto_obj is not None
    assert isinstance(fulfilment_builder.proto_obj, Fulfillment)
    assert isinstance(fullfilment_obj, Fulfillment)

    assert (not fulfilment_builder.proto_obj) is True
    # fails because there is a bug in _check_proto_obj_attr_exist()
    fulfilment_builder._check_proto_obj_attr_exist()

    """
        def _check_proto_obj_attr_exist(self):

        # BUG HERE : should be if self.proto_obj is None

        if not self.proto_obj:
            raise ValueError(
                "There is no proto_obj!"
                "\nUse `create_new_proto_obj` or `load_proto_obj` to continue."
            )
        elif not isinstance(self.proto_obj, self._proto_type):  # pylint: disable=W1116
            raise ValueError(
                f"proto_obj is not {self._proto_type_str} type."
                "\nPlease create or load the correct type to continue."
            )
    """

if __name__ == "__main__":
    main()

Thanks for pointing this out. This was a known issue but unfortunately I forgot to solve the bug. Please sign the CLA using the email you've created your GitHub account with so we can merge the PR.

I signed the CLA but it still shows pipeline still shows the error.
Does the ci/cd pipeline automatically get triggered by signing CLA?
If not, can you re-trigger the workflow?
thanks,
Yar
On Wed, Jan 10, 2024 at 3:37 PM Milad @.***> wrote:

Thanks for pointing this out. This was a known issue but unfortunately I
forgot to solve the bug. Please sign the CLA
https://cla.developers.google.com/about/google-individual using the
email you've created your GitHub account with so we can merge the PR.
—
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/dfcx-scrapi/pull/166#issuecomment-1885774211,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDVQYJZX6SHMQPP3H4NKKETYN4CZJAVCNFSM6AAAAABBVOGDLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVG43TIMRRGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Gokberk Yar
Senior Software Engineer
Denim Health https://www.denimhealth.com/

thanks for signing that!
@kmaphoenix LGTM!


Added Cheatsheets

Thanks for the contribution the @CandidDeer
Finally, this can be merged haha
Happy Hacktoberfest
💖

I can't believe I finally made it, haha! It paid off to be persistent I guess. ✨ Thanks so so much!


Session ID is not used as URL parameter anymore.

Hello,
I´m trying your extension in my project but when I try to run the product edit form, it displays this message"Session ID is not used as URL parameter anymore.", the problem is apparently in Attachments.php in the line where it calls this method:
'url' => $this->urlBuilder->addSessionParam()->getUrl(
'downloadable/attachment_file/upload',
[Attachment::ATTACHMENT_TYPE => 'attachments', '_secure' => true]
)
under the method: $attachmentUploader['arguments']['data']['config']
So far I´ve just installed the extension via composer on a clean magento install
I´m quite new to magento, and I don´t understand what the problem is, Could you please help me?
Thanks in advance.

@Carlosvice please let me know what magento version do you use. So far module has been tested and worked on magento 2.2+ and 2.3+

@bartoszkubicki  Sure, it´s 2.3.5.
Thanks!

https://github.com/magento/magento2/blob/2.3/lib/internal/Magento/Framework/Url.php
This change had to be added in 2.3.5 or 2.3.4. We have it tested on 2.3.3. I am merging fix for it. Please let me know if it works, and please report any issues with incompatibility with 2.3.5. Thank you!

Please make sure to bump module's compsoer version to 1.3.3

@bartoszkubicki Sure thing Bartosz, I'll replace the file and let you know if I encounter any other issue. I´m running composer 1.10.1 updated on 2020-03-13 Is it ok, or should I downgrade?
Thanks!

I don't think composer does really matter here

Please make sure to bump module's compsoer version to 1.3.3

What was you refering to?
I replaced the file named "Url.php" contained in "vendor/magento/framework/" with the one on your reply but with no luck. Should I try aything else?

@Carlosvice Do not replace any magento files. Download the newest version of our module and replace old one if you have installed it in app/code/ If you have installed it by recommended composer way (https://github.com/lizardmedia/product-attachments-magento2/blob/master/README.md), just run composer update lizardmedia/module-product-attachments

@bartoszkubicki  Ok, I restored the file I changed, although I think it was the same, and ran the composer update. I've just understood you, sorry, now I'm running version 1.3.3 of your extension.
It does no longer triggers the same error but the form doesn't show anything under the attachments section.
Thanks a lot Bartosz.

@Carlosvice I will check that, it should work.

@Carlosvice check newest release 1.3.4. - I have just fixed product page problem.

@bartoszkubicki Done the upgrade but the form stays the same. Can I help you in any way?
Thanks!

@bartoszkubicki Wait I just checked the extension version and it's still 1.3.3. I'll try to update again.

@bartoszkubicki Still no luck. Any other way I can help you, or is there something you would want me to share?
Thanks!

I just have tested it on almost clean magento instal 2.3.4 and there is a form to upload url or a file. Can you share dev console of browser?

Sure.

@Carlosvice looks like you have problem with loading static files, something with content security policy. It doesn't seem to be caused by module, rather its something with your installation. I will upgrade my installation to 2.3.5 and check if module still works. If so, I will have to close this issue.

@bartoszkubicki Ok, please let me know whether you encounter the same issue or not.
Thanks a lot!

@Carlosvice tested today on magento 2.3.5. I am closing this issue, as I can't reproduce it further problems. Issue topic is fixed.

@bartoszkubicki  Good! Thanks Bartosz, I´ll try on a clean install of Magento.

@bartoszkubicki Hello! I managed to solve the csp errors and did a clean install (including OS, XAMPP, Magento and the extension), unfortunately the extension is still not working, could you help me again, I don´t know what could be, I don´t have errors in the log´s nor the console. Thank you!
Here´s a before and after installing the extension:

@bartoszkubicki I´ve been wandering around the code and I noticed that it doesn´t appear anything under the fieldset of the section. Do you think I could be missing parts of your code?

@Carlosvice Ok I see that you've open another issue #34 . Closing this one.


Cover author issue

Some trouble on cover with author:
If pseudo is to long:

If tuto contains many authors:

Possible improvment: use lua for generating list of author. Not displaying too long pseudo and no more than 12 author. For other, add sentence like this: "et X autres auteurs"

Here is the rendering once fixed:

If all authors are not displayed on cover, a new page are created between flyleaf and the table of contents to list all authors:


Check devices before downloading & extracting

If multiple USB devices are available, it's not discovered until the platform has already been downloaded and extracted. These files are not reused during subsequent runs and are downloaded again.

https://github.com/calmh/smartos-platform-upgrade/commit/95205cd5a80408b82bf91f0e19917a61b7c52424
I remember it will report multi usb devices in this patch.
Maybe need a patch to keep the downloaded files?

In my case the server is on a very slow and expensive satellite link and has a pair of USB keys for redundancy. It would be nice to be prompted which key to update and have the downloaded platform file saved.


Revert "Support MetaMask"

Reverts omgnetwork/optimism-v2#162

Codecov Report

Merging #175 (285c432) into develop (96257c6) will increase coverage by 9.72%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
+ Coverage    71.73%   81.45%   +9.72%
===========================================
  Files           68       46      -22
  Lines         2257     1402     -855
  Branches       335      208     -127
===========================================
- Hits          1619     1142     -477
+ Misses         638      260     -378

Flag
Coverage Δ

batch-submitter
?

contracts
89.52% <ø> (ø)

core-utils
54.48% <ø> (ø)

data-transport-layer
?

message-relayer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/message-relayer/hardhat.config.ts

...layer/src/services/l1-ingestion/handlers/errors.ts

packages/data-transport-layer/src/utils/common.ts

...ackages/batch-submitter/src/utils/tx-submission.ts

packages/batch-submitter/src/index.ts

...h-submitter/src/batch-submitter/batch-submitter.ts

...itter/src/batch-submitter/state-batch-submitter.ts

...kages/batch-submitter/src/batch-submitter/index.ts

packages/batch-submitter/hardhat.config.ts

...ckages/data-transport-layer/src/utils/contracts.ts

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96257c6...285c432. Read the comment docs.


Add optional gas tracking

While not required for the eEVM's original purpose, other users of the eEVM will want gas to be tracked and expended as specified in the white paper.
If added, this should be an optional additional feature - disabled at compile time in applications where it is not needed.
This is currently a low priority, but I expect it will eventually be a blocking requirement for a potential user.

I would like to work on this.


Is there any reason why pywal's API only works in python > 3.6?

I've been having a bad time installing pywal in some distros, as they don't ship with python 3.6 nor it's in the native repos of said distributions, so I was wondering if there was any real reason why python>=3.4 wouldn't work

This was my first Python project so I just used whatever was installed on my system and it happened to be 3.6. I've got a working 3.5 branch on my laptop with the only big issue being that dicts in <3.6 are unordered so we'll have to swap to using OrderedDict from the collections module.
The local branch is also a little messy since the open() function doesn't work with Path objects in <3.6 so there's a bunch of str() everywhere. There's also no f-strings so the formatting had to be replaced with the % operator.
I'll work on the branch and clean things up but I'm not going to support anything below 3.5 since it's the newest version that Debian Stable ships with.

There's also no f-strings so the formatting had to be replaced with the % operator

Use .format() instead of % 🙏  😄

yes, it seems so, I was just genuinely curious about that detail, if that's the case I'll have to replace those f-strings in wpgtk, too. This way much more users will be able to use our software.

Use .format() instead of % 🙏 😄

The modulo operator is faster no?
I'm assuming so since format() is a function and % is syntax. The same can be said for []/{} and list()/dict(). The syntax is always faster.
Yes, the format() method is much more flexible but we don't really need to use anything other than basic substitutions. (I converted all of the f-strings to the % format with ease.)

It's not a big deal, I just prefer new code being written to use the newer way. % will be a little faster, so that's a win.

I've opened up #79 which adds support for Python 3.5. All of the (known) issues are fixed and all that's left is the cleanup of the str() litter and some test cleanup. I haven't decided whether or not to remove all pathlib/Path usage in place of os.path and Strings.
Anyway, I'll finish this off tomorrow and merge it when I'm happy with it.

#79 is done.
I've removed all pathlib usage, the str() litter and simplified the color dicts so we no longer need OrderedDict. Adding support for Python 3.4 is now possible (There are only two syntax errors.) though I'm not sure if there are any OS that ship anything below 3.5 by default.
This needs testing and I'm also going to write some more unit tests to cover things I found were missing while creating the PR. I also need to take another look at the API to see if this broke anything (probably not). Let me know if you guys come accross any issues.
The performance is actually a little faster in the Python 3.5 version which makes me more eager to merge this sooner so that's nice. I'm not sure if this was due to the simplification of the dicts or not.

wow, that was fast, will check it out today or tomorrow probably.


refactor pkg_deb

Refactor debian building so it can be more easily owned by others.
blocked by #443
cc: @alexeagle

This is ready again, now that the big reorganization PR is merged.

We don't happen to have tests that exercise the distro tarball, would we?  A simple way to do this would be something that would build the distro, extract it somewhere, plant the tests inside the extracted location, and then run the tests.

We don't happen to have tests that exercise the distro tarball, would we? A simple way to do this would be something that would build the distro, extract it somewhere, plant the tests inside the extracted location, and then run the tests.

Yes. The tests under distro do do that. They make sure we can build some things when using the tarball, and under a different repository name.
We could probably add finer grained test in the future.

I think we need to confirm the policy on CODEOWNERs first so we prevent shooting ourselves in the foot.

What particular foot shooting are you thinking of?
The current situation is that you and I are the only codeowners, and with the current branch protection policy, that means a PR from either of us is blocked on the other.
Adding extra owners will allow a domain expert to review and approve a change. If it is strictly to RPM or DEB packaging (or maybe even tar & zip) I welcome the ability to have someone else be on the hook to review things.
That's what this will do.

What particular foot shooting are you thinking of? The current situation is that you and I are the only codeowners, and with the current branch protection policy, that means a PR from either of us is blocked on the other.
Adding extra owners will allow a domain expert to review and approve a change. If it is strictly to RPM or DEB packaging (or maybe even tar & zip) I welcome the ability to have someone else be on the hook to review things. That's what this will do.

I was mostly concerned regarding exclusivity to owners -- that if I were the only owner of the RPM code and I were unavailable, then a change couldn't be approved without editing the CODEOWNERs files.
Reading more closely, I see that this is more of an overlay and not really a problem.  Will approve momentarily.


Update game jam page to have featured submissions

Here's a preview of how the page looks like:

LGTM code-wise! will leave the text for lizzy to approve


"make linting" returns zero exit code even when golangci-lint reports problems

I noticed this while prepping the branch for #161 and encountering the linting errors filed on #176.
https://github.com/atc0005/elbow/blob/1c24a42549e7348805ed5f282295a9a75252e207/testing/run_linting_checks.sh#L65-L71
Running this directly returns 1 to indicate a problem, but running make linting returns 0. Need to fix either the Makefile or the script that it calls so that the appropriate error code from the linting tools can "trickle up" so that GitHub Actions can properly fail or pass the linting run.

Note: Just in case there was any confusion, this is what I meant by running "it" directly:
cd /path/to/this/repo
golangci-lint run -E goimports -E gosec -E stylecheck -E goconst -E depguard -E prealloc


Add possibilty to add custom learning mechanisms

Add possibility for a user to specify a custom mechanism in a separate text file which should be read by the simulator.

Moved to https://github.com/learningsimulator/learningsimulator/issues/111


bugfix: comment on ExternalStream was not showed in system.tables

PR checklist:

Did you run ClangFormat ?
Did you separate headers to a different section in existing community code base ?
Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:
closes #563

(Jove Github Bot) added it to the current sprint.

(Jove Github Bot) moved this ticket out of the GitHub project(up to 1200 tickets for one project).


Django 1.8 upgrade

Coverage decreased (-0.6%) to 91.462% when pulling 8745ab35504fa5ff058c5e930f059df5e63f4976 on django-1.8-upgrade into e835c764b1de59b606c5fdda3738bfaba5b6c331 on master.

r+


convert to new names as appropriate

I saw a reference to k2-tools in build/alpine-builds/runme.sh.  Should this be renamed as well?

we aren't migrating docker repository references right now.  that'll be a follow-on PR and will probably require us to publish multiple copies of each image as we swap over.

kraken-lib not Kraken-lib, etc

Why is it kraken-lib and not Kraken-lib?


Style 'versionadded' and friends

Add: `.versionmodified {font-style: italic}
Will give:

Resolved by https://github.com/TYPO3-Documentation/t3SphinxThemeRtd/commit/1228dfa4a1254bf1e75ba436f4f6ebf9bdf0650e


Fix https://github.com/palantir/tslint/issues/3001

I have found out that getTypeOfSymbol does not check if its parameter, symbol, exists and produce TypeError: Cannot read property 'flags' of undefined when using no-unsed-variable from TSLint.
Fixes https://github.com/palantir/tslint/issues/3001
Also, it is related to https://github.com/Microsoft/TypeScript/issues/15436

@ochanje210,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

I don't necessarily know if this is the correct fix - do other similar functions check for if a symbol is defined? Or do all callers need to make sure that symbols are defined before calling getTypeOfSymbol?
Additionally, we need a failing test case to ensure we don't have regressions.

This change is necessary, and many ts-lint mistakes are hidden because of this issue.

Thank you for your comments and apologies for being late since I've been busy lately. :(
I will try to find out if this is necessarily correct fix, in addition to the failing test case very soon. Also, anyone is welcome to continue this before I could do so.

@ochanje210,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Closing this since it seems fixed with this commit: https://github.com/palantir/tslint/commit/a479f436530f0afd52fc65c5a45645bd4a2b5b29


Stuttering audio on Pi Zero W

I'm running WaveSync tx unicast from my media server (4.1 Ghz quad core) to a pi zero W with a pimoroni pirate audio line out hat and to a raspi3b with the on board audio out.  The pi3 plays fine but the pi zero is having trouble.  It will play fine for a bit and then start stuttering then return to normal.  This can happen every few minutes or every few seconds.  Total cpu usage is under 50%.  NTP is working at about 100ms.

You could try increasing the buffer-size. If it's over wifi, then try
unicast initially, unsure how you sent the data there. Power management
of wifi can cause some troubles and unicast was always easier.
Similar problem with cubie board made me try to code another approach.
It's currently unfinished on audio-callback branch of wavesync. After
some tweaking I made it run ok on cubie board but haven't sorted out all
synchro problems with new approach.
If increasing the buffer don't help I guess I should find some time to
finish the branch. :S
cheers,
kuangmk11 @.***> writes:

I'm running WaveSync tx unicast from my media server (4.1 Ghz quad core) to a pi zero W with a pimoroni pirate audio line out hat and to a raspi3b with the on board audio out.  The pi3 plays fine but the pi zero is having trouble.  It will play fine for a bit and then start stuttering then return to normal.  This can happen every few minutes or every few seconds.  Total cpu usage is under 50%.  NTP is working at about 100ms.

--
Tomasz bla Fortuna
pgp: C009FC9BD59B22FE @ pgp.mit.edu
www: http://bla.thera.be

I switched everything over to chrony from ntp and am getting better sync.  running the W at --tolerance 100.  Might be usable now it has made it through a few songs without a hiccup after initial sync, Ill give it a few hours more.  I have problems since our only internet is flaky LTE hotspot.
I have big plans for this,  I have 3 more piW/pirate audio combos on my desk.  I am replacing the 10 watt FM transmitter on our farm with these.  Thanks for putting this together!

You can keep me posted. ;) I need some motivation to get back to it. I
have small apartement and it works good enough for me on my hw, but
would love to fix some bugs.
There's also snapserver you can try - unsure how will it handle 0pi w.
kuangmk11 @.***> writes:

I switched everything over to chrony from ntp and am getting better sync.  running the W at --tolerance 100.  Might be usable now it has made it through a few songs without a hiccup after initial sync, Ill give it a few hours more.  I have problems since our only internet is flaky LTE hotspot.
I have big plans for this,  I have 3 more piW/pirate audio combos on my desk.  I am replacing the 10 watt FM transmitter on our farm with these.  Thanks for putting this together!

--
Tomasz bla Fortuna
pgp: C009FC9BD59B22FE @ pgp.mit.edu
www: http://bla.thera.be


repo.spring.io is blocking access to builds.

This no longer works. repo.spring.io is blocking access. You will get a 401 back and the build will fail.
buildscript {
    repositories {
        maven { url 'http://repo.spring.io/plugins-release' }
    }
    dependencies {
        classpath 'io.spring.gradle:propdeps-plugin:0.0.9.RELEASE'
    }
}

I was wrong. Ignore this. I am sorry!

Thanks for letting us know!


Update operation-complexity.md

Adjust "o.Enable = true;" to "o.Complexity.Enable = true;"

Thanks for helping out.

Thanks for helping out.

You're welcome !


remove deprecated Z3_EXECUTABLE cmake option

The Z3_EXECUTABLE cmake option for building LLVM is deprecated since https://reviews.llvm.org/D54978 .

thanks!


Check system-wide locations for hunspell

Use of $LANGs other than en_US is broken for some Linux users (atom/spell-check#129).
Ideally, spellchecker should GetAvailableDictionaries from /usr/share/hunspell and whatever other common paths are in use (perhaps there is an environment variable similar to the XDG_*_HOMEs?) for dictionaries other than the single one shipped.
If that is the intention of GetAvailableDictionaries, it seems not to be working.

I'm still getting an empty array in almost 2019.


Repeated error syncing 'git-webhook' seen in Rancher logs

Rancher Server Setup

Rancher version: master-head version 5aa95f2
Installation option (Docker install/Helm Chart): docker single install

Describe the bug

An error is repeatedly seen in Rancher server logs.
To Reproduce

Bring up a single install Rancher on latest master-head.
Launch a DO downstream cluster.
View Rancher logs of local cluster.
Result
This error is repeatedly seen:
[ERROR] error syncing 'git-webhook': handler apiservice: failed to create fleet-system/steve-aggregation /v1, Kind=Secret for apiservice git-webhook: namespaces "fleet-system" not found, requeuing

Additional information
fleet-system namespace does not exist on the local cluster or downstream cluster. But cattle-fleet-system is available.

This is no longer seen and was fixed by https://github.com/rancher/rancher/pull/33577/commits/6dff19b21288e9d3d038a22bdc8fab28e1b28e7e

Tested on Rancher master-head version d3ad5d3 with the following steps:

Bring up a single install Rancher on latest master-head.
Launch a DO downstream cluster.
View Rancher logs of local cluster.

Result:
Error is not seen in Rancher logs.
Secret is successfully created:
2021/07/19 17:38:12 [DEBUG] DesiredSet - Created /v1, Kind=Secret cattle-fleet-system/steve-aggregation for apiservice git-webhook


fix dark theme name conflict

This PR will fix name conflicts when user loads Malibu Dark theme in vscode.
The error that vscode shows is this:
Unable to load file:///c%3A/Users/devmor/.vscode/extensions/wicked-labs.malibu-0.0.6/themes/malibu-sunset.json: Unable to read file 'c:\Users\devmor.vscode\extensions\wicked-labs.malibu-0.0.6\themes\malibu-sunset.json' (Error: Unable to resolve nonexistent file 'c:\Users\devmor.vscode\extensions\wicked-labs.malibu-0.0.6\themes\malibu-sunset.json')
Just because of a filename typo (devmor is my username).

Thank you so much for the heads up!


[bug fix] [Server][sqlTask]The alias column in the query SQL does not take effect #3549

such as the follow png, i think this should be 'getColumnLabel'，not 'getColumnName'

fix issue #3549


Drools 6.4 and manage both stateful and stateless sessions

Some refactoring and make it fully work with latest release 6.4.
It also makes it possible to deal both with Statefull session (KieSession) and stateless session.

Issue with DRL files reading


Loggregator does not reconnect to doppler if idle connections timeout

We have 2 trafficontrollers (both in 1 AZ). Same for dopplers. AZ-s are seperated by firewall what drops 24 old idle connections. Trafficontrollers does not reconnect and gives errors if it tries to retrieve logs via disconnected connection.
If doing cf logs myapp --recent it just hangs and gives the following error:
Error dialing trafficcontroller server: Get https://doppler.cfm.dev:4443/apps/38784616-1b5f-4cde-8c55-91e9af3ba8ad/recentlogs: net/http: request canceled (Client.Timeout exceeded while awaiting headers).
Please ask your Cloud Foundry Operator to check the platform configuration (trafficcontroller endpoint is wss://doppler.cfm.dev:4443).
In the trafficcontroller logs you can find something like this:
2017/05/08 07:15:05 Error while reading from stream (<IP_ADDRESS>:8082): rpc error: code = 1 desc = context canceled
2017/05/08 07:15:05 Disconnecting from stream (<IP_ADDRESS>:8082) (doppler.disconnect=false) (ctx.disconnect=1)
2017/05/08 07:15:05 Error while reading from stream (<IP_ADDRESS>:8082): rpc error: code = 1 desc = context canceled
2017/05/08 07:15:05 Disconnecting from stream (<IP_ADDRESS>:8082) (doppler.disconnect=false) (ctx.disconnect=1)
2017/05/08 07:15:22 error from doppler (<IP_ADDRESS>:8082) while fetching recent logs: rpc error: code = 4 desc = context deadline exceeded
2017/05/08 07:15:22 error from doppler (<IP_ADDRESS>:8082) while fetching recent logs: rpc error: code = 4 desc = context deadline exceeded
2017/05/08 07:15:22 recentlogs request encountered an error: context deadline exceeded
Is there a workaround to configure that trafficontroller tries to connect to only same AZ-s dopplers?

@martjarvi, can we confirm the following:

What loggregator and cf-release version you are?
How much traffic do you have on this system right now?
How many firehose nozzles do you have running?

cf254. Its a test environment so there could be no traffic on weekends hence the 24h timeout and connection drop.
In the setup I had 2 trafficcontrollers and 2 dopplers, 1 in each AZ.

This is a bug that we need to investigate more. Thanks for the information.

We did an experiment with loggregator v81 (version shipped with CF 254) against bosh lite with 1 trafficcontroller and 1 doppler.

We verified we had connections from trafficcontroller to doppler with lsof -c trafficco | grep doppler | wc -l.
We saw 20 connections from trafficcontroller to doppler.
We stopped doppler (monit stop doppler) and saw the number of connections to doppler go to 0.
We started doppler (monit start doppler) and saw the number of connections go back to 20.

While this was going on, we ran the firehose example from noaa and saw expected behavior (data was coming out of firehose before and after restart of doppler).
@wfernandes

@martjarvi Can you provide more information on the firewall rules so that we can more closely replicate your environment to try and re-produce this issue.

@martjarvi Also, are you able to see data coming out of the firehose using the CF Nozzle CLI plugin.
Once installed, run cf nozzle -n.

Hi.
Tested again
cf logs demo --recent (not working)
cf logs demo (working
cf nozzle 5 and cf nozzle -n both working.
Its external firewall between doppler and trafficcontroller so will ask the iptables equivalent rules.

Please put firewall between Trafficcontroller and doppler and add the rule in the firewall machine iptables --append INPUT --protocol all --src SRC_IP --dst DST_IP --jump ACCEPT. When the timeout occurs it should give the same situation hopefully. We have tested the problem with relayd.

@martjarvi, we were able to recreate your logs above.

Deployed a traffic controller and doppler.
Made sure that connections and data were established between the two.
On the doppler, we applied an iptables rule to DENY all packets from traffic controller.

These are the logs from traffic controller:
2017/05/23 17:58:43 Error while reading from stream (<IP_ADDRESS>:8082): rpc error: code = 1 desc = context canceled
2017/05/23 17:58:43 Disconnecting from stream (<IP_ADDRESS>:8082) (doppler.disconnect=false) (ctx.disconnect=1)
2017/05/23 17:58:43 error receiving from doppler via gRPC context canceled

When we removed the iptables rule, the traffic controller indicated that the connections were broken.
2017/05/23 18:13:08 transport: http2Client.notifyError got notified that the client transport was broken read tcp <IP_ADDRESS>:33050-><IP_ADDRESS>:8082: read: connection timed out.

The traffic controller automatically re-established the connection to doppler. Traffic controller was resilient to the loss of connection and re-established the connection when it could.
Please let us know if you something incorrect with the recreation. Please be aware, we are unable to recreate your firewall setup, so this is the closest recreation.
As a resolution, are you able to update your firewall so the connections between traffic controller doppler don't get reaped?

My setup is TC -> (FW machine) -> Doppler. If FW drops sessions, TC does not know that the 20 stateful tcp connections are not working anymore and I cant alter this behaviour. When I try cf logs demo --recent the TC tries to fetch the logs but fails and correctly states that the connection is broken.
2017/05/26 06:38:22 error from doppler (<IP_ADDRESS>:8082) while fetching recent logs: rpc error: code = 4 desc = context deadline exceeded
2017/05/26 06:38:22 recentlogs request encountered an error: context deadline exceeded
2017/05/26 06:38:24 transport: http2Client.notifyError got notified that the client transport was broken read tcp XXX:42958->YYYY:8082: read: connection timed out.
TC creates a new one like you said but before that I get the error :
Error dialing trafficcontroller server: Get https://doppler.cf.dev:4443/apps/6c4ec449-ec8a-473f-b40f-23590f41679c/recentlogs: net/http: request canceled (Client.Timeout exceeded while awaiting headers).
If I try this cf logs command many times (like 5-10) then sometimes it succeeds because it takes the new fresh connection but sometimes fails if it uses the old already invalidate connection and I get the timeout before TC creates a new connection. Eventually when excercising cf logs TC recreates all connections.
Maybe TC should send keepalives to these stateful connections?


Refactored ProxyConnector

What do these changes do?

Proxy request logic is moved from ProxyConnector to TCPConnector
Proxy now is set in ClientSession.request() and can be changed for each subsequent request, e.g session.get("http://httpbin.org/get", proxy="http://localhost:8020")
ProxyConnector stays for backwards compatibility, however now it is just a thin wrapper around TCPConnector.

Are there changes in behavior for the user?
Old ProxyConnector code still works, however new way is preferred.
Documentation is updated to reflect that change.
Related issue number
#985
Checklist

[+] I think the code is well written
[+] Unit tests for the changes exist
[+] Documentation reflects the changes

Coverage decreased (-2.1%) to 95.872% when pulling 944524ed1d7c98cb493be618cdb9c98be6694526 on mind1master:master into 7eac9e3182e64b233880ee0e35d6ed057a0bd357 on KeepSafe:master.

Awesome!


[SQL] [Minor] HiveParquetSuite was disabled by mistake, re-enable them

Test build #26947 has started for   PR 4440 at commit 4be8962.

This patch merges cleanly.

Test build #26951 has started for   PR 4440 at commit f21ede4.

This patch merges cleanly.

Test build #26947 has finished for   PR 4440 at commit 4be8962.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26947/
Test PASSed.

Test build #26951 has finished for   PR 4440 at commit f21ede4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26951/
Test PASSed.

Merging this to master and branch-1.3.


Insteall procps tools for rocky docker images [skip ci]

To fix issue: https://github.com/NVIDIA/spark-rapids/issues/10154
Install 'procps' to fix 'ps: command not found' in nvidia Rocky9 Docker containers,
when runing integration tests with jenkins/spark-test.sh
'procps' is required for rocky docker containers to run spark standalone cluster, see:
https://github.com/apache/spark/blob/v3.3.2/bin/load-spark-env.sh#L68

Signed-off-by: Tim Liu<EMAIL_ADDRESS>

skip ci, pre-merge build can not cover this change, this Dockerfile change is only applied for integration test CI jobs

build


stable setState and improved types

stable setState - wrap method with useCallback, to reuse the same value (mabye I should put onChange to be more consistent with setState?)
improve types - usage is now forced to supply either initialValue or controlledValue, return type is Value, which also works when setting initialValue: undefined or controlledValue: undefined

also - I don't like the limitation of "controlledValue must not be undefined".
undefined should be a valid value, not sure how to work around it

I see. React will show these warnings for controlled elements:
Passing value without onChange:
Warning: You provided a `value` prop to a form field without an `onChange` handler. This will render a read-only field. If the field should be mutable use `defaultValue`. Otherwise, set either `onChange` or `readOnly`.

changing value from undefined to defined: (also vise versa)
Warning: A component is changing a controlled input to be uncontrolled. This is likely caused by the value changing from a defined to undefined, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components

This is sensible. I guess the weird part is that 'controlled' elements have a string value (which can't really be undefined), and this hook can be anything.

I verified npm run lint and npm run build pass 😃

Published in<EMAIL_ADDRESS>– many thanks!


Introduce CLI Aliases to IF

What

Introduce CLI shortcuts for IF flags to make UI simplier. Such as:
Why

To run the IF framework rapidly, use short keywords for --manifest, --output, --help and --stdout.
SoW (scope of work)

[x] Documentation updated
[x] QA Tested

Acceptance criteria

[ ] Updated IF with working shortcuts
GIVEN this update has been implemented and a user has downloaded and installed if
WHEN a user runs the following command ie -m <path-to-a-manifest>
THEN  ie should execute identically to the command `ie --manifest
The same should apply to the following mapping of shortkeys to commands:

shortkey
command

 -h
--help

-m
--manifest

-o
--output

-s
--stdout

[ ] Updated Documentation

The shortkeys should be described in the IF readme and on the CLI page on if.greensoftware.foundation
ie -h // help
ie -m <manifest-path> -o <output-path> -s // manifest, output paths, stdout

@narekhovhannisyan Tested from my side, you can update the docs accordingly.

reopening as docs not yet updated

@jmcook1186 @narekhovhannisyan Updated documentations accordingly
https://github.com/Green-Software-Foundation/if/pull/708
https://github.com/Green-Software-Foundation/if-docs/pull/73


No redirect after login

After posting the login or registration form, the end user redirects to the login interface again.
As example, the user goes to the URL below which displays the login form again.
/account?login=USERNAME&password=PASSWORD
What's going wrong? Just followed the video guide.

Make sure the layout contains the {% framework %} tag to include the AJAX framework. It would appear this is missing from your site. The "RainLab.Vanilla" theme has a working example of this.
https://github.com/rainlab/vanilla-theme


How can i pass credentials (cookies) to networkLayer ?

have to wait https://github.com/facebook/relay/issues/558 ?

Yes, I think it is currently impossible to pass user specific cookies to a network layer on the server. But, you can pass an authentication token to the GraphQL server as an ID parameter of the query root field. You can pass the authentication token to the server in a cookie.

But how can i pass params to GraphQL ? intercept query from client then change it manually ? sounds too tricky...

No, you don't have to intercept any GraphQL queries from the client. The client can set query params including the authorization token, itself.
The authorization token might be a secure hash computed from the user credentials on the server, and returned to the client at the initial HTTP request.
When receiving request from the client (only from the client, because server can't send user specific cookies, and the GraphQL server trusts requests from the server anyway), GraphQL server can verify that the authorization token, passed as a query param, match the user credentials, passed in HttpOnly cookies.
I know, all this is too complicated anyway, but at least it do the job.

you mean send queries both in client & server like:
viewer(uid: xxxxx) {
  nickname
}

seems i can only pass it as a url query param, but how can i insert the param into react-router-relay? use prepareParams  may solve it, but it's really too complicated...

seems i can only pass it as a url query param

You can pass it as a state param.

but i need auth user in every root queries' resolve function except query from server... but it's really too complicated...

The GraphQL server should authenticate and authorize users anyway, even without isomorphism. And it is not so hard to detect that query came from the server. In that case only authorization is needed, and authentication could be just skipped.

Yep, i use passport as authorization solution. seems no open source solution that can mix them up, so, a lot of work to do.
anyway, thx very much for your help!

@denvned Is there anywhere an example of implementing your idea:

When receiving request from a client, the GraphQL server can verify that the user ID, passed as a query param, match the user credentials, passed in HttpOnly cookies. The GraphQL server verifies only client requests because the server can't send user specific cookies (the singleton network layer does not allow it), but the GraphQL server trusts requests from the server anyway, so that is not a problem.

Or possibly different examples implementing different parts of it? I am fairly new to this and while I understand it on the conceptual level, it is hard for me to tell how to implement all the pieces.

@denvned Is there anywhere an example of implementing your idea:

When receiving request from a client, the GraphQL server can verify that the user ID, passed as a query param, match the user credentials, passed in HttpOnly cookies. The GraphQL server verifies only client requests because the server can't send user specific cookies (the singleton network layer does not allow it), but the GraphQL server trusts requests from the server anyway, so that is not a problem.

Or possibly different examples implementing different parts of it? I am fairly new to this and while I understand it on the conceptual level, it is hard for me to tell how to implement all the pieces.


Find javac and jar using the JAVA_HOME

This issue was originally created at: 2007-08-22 19:36:24.
This issue was reported by: tpurl.
tpurl said at 2007-08-22 19:36:25

From my experience, the vast majority of Java developers set the JAVA_HOME environment variable.  It points to the root of the JDK directory.
A lot of Java development tools (such as Ant) use the JAVA_HOME tool to infer the location of java, javac, and jar.  It would be very useful if the scons tools inferred the location of the java development tools based on that
variable's value.
For more information, please see the following mailing list thread:

http://scons.tigris.org/servlets/BrowseList?list=users&by=thread&from=603198

Thanks for considering this!
Tom Purl

gregnoel said at 2008-06-05 17:38:27

Bug party triage: A good idea for javac and javah (jar should eventually be based on the Python zipfile module, as it's faster and more flexible; see issue #1704. Could possibly be implemented as an optional argument to Detect() with the path to try after exhausting the standard path; it would return the full path if the command was found in the extended locations.

russel said at 2008-06-05 22:07:20

Whilst it is usual for JAVA_HOME to be set, it is not mandatory.  It would therefore be a bad idea to assume it.  A good algorithm is to search for the commands in JAVA_HOME/jre/bin and JAVA_HOME/bin if JAVA_HOME is set, otherwise do a search of PATH.
Also of course jar and javac only come with the JDK not in the JRE so the java command may be present but not the others.

gregnoel said at 2008-12-26 13:29:10

Adjust triage of issues.

russel said at 2009-08-28 00:37:36

Adding Russel to the CC list

managan said at 2009-08-28 12:48:32

add java to keywords

Looks to me like #2772 and #2776 are asking for the same thing (taking the more general "improve" rather than the specific solutions suggested).  Maybe we could combine these into just one open issue?


why wstunnel take up huge virtual memory

running wstunnel on ubuntu 20.01/pi4 found each wstunnel process took 270G virtual memory?
the residual not too bad max 44K.
Linux pi4 5.11.0-1019-raspi #20-Ubuntu SMP PREEMPT Tue Sep 21 15:23:42 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux
pi4:~/works$ ps -eo pid,tid,class,rtprio,stat,vsz,rss,comm | grep wstunnel
268182  268182 TS       - Sl   269435092 19020 wstunnel
2284813 2284813 TS       - Sl   269730260 34264 wstunnel
2296457 2296457 TS       - Sl   269730260 44336 wstunnel
2476984 2476984 TS       - Sl   269582676 24436 wstunnel
using 3.0 binary version download from the site

It's an Haskell behavior more than a wstunnel one,you can see https://gitlab.haskell.org/ghc/ghc/-/issues/14193, you can change that by defining RTS settings http://ghc.gitlab.haskell.org/ghc/doc/users_guide/runtime_control.html for example if you add that on wstunnel command line wstunnel +RTS -M100m -RTS it will limit memory usage of wstunnel.

thanks for the response, tried +RTS -M100m -RTS, make no difference.
nevertheless will close the item


Clean up Django HTTP caching

We need to investigate how Django does HTTP-level caching (of API results, CSS files, and JS files). Currently some API functions are marked as @never_cache (like /api/images) for no obvious reason. We need to standardize which API calls we allow to be cached as well as how long we want things to be cached in the browser.

This has all been dealt with. JS and CSS files have version numbers that make sure caching doesn't happen across releases. Pretty much every API call is marked @never_cache so that back end updates take effect immediately, and so that everything makes it into the Apache log files.


Add static as valid keyword for structural element. Fixes #1034

Added tests and fix for #1034

:+1: Thanks ;)

:+1:

Thank you @ceeram.


Redis.Cluster support is broken as of v2.3.6

Description
This change actually caused a breaking change for setups using Redis.Cluster since uri.options.family will not be defined when using Redis.Cluster
Doing (uri.options && uri.options.family || uri.options && uri.isCluster) will work but I haven't dug into ramifications of doing that.
References

Default Cluster Options
Default Redis Options

@jaredwray I'll create a reproduction repo shortly

@jimmy-guzman - any update on this? It would be good to show test code so we can validate against it.

@jimmy-guzman here's a reproduction repo: https://github.com/jimmy-guzman/keyv-redis-bug-reproduction
I hope that helps.

@jimmy-guzman - thanks and we are working on this fix.


common: use ceph/ceph image instead of ceph/daemon

major refactor in order to make ceph-ansible use the ceph/ceph container image instead of ceph/daemon
WIP

jenkins test centos-container-all_daemons

jenkins test centos-container-all_daemons

jenkins test centos-container-all_daemons

jenkins test centos-container-all_daemons

jenkins test centos-container-subset_update

jenkins test centos-container-purge

jenkins test centos-container-purge


[SQL] Support setting of AAD administrator on Managed Instance

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@jaredmoo  please review and let us know when it is ready to merge.

please Rebase against the dev branch. Which should get Travis CI successfully run.

@SanjaMalesevic Can you rebase against dev and fix the conflicts? We're going to build for the next release on Friday Shanghai time.

This PR was merged and will be incorporated in our next release.


Implement the initial UI for the revision notes

Changes Proposed

Implement the initial UI for the revision notes
Since there are many files related to the revision, I have put them together in the new revision folder

[ ] The title of my pull request is a short description of the changes
[ ] This PR relates to some issue: #298
[ ] I have documented the changes made (if applicable)
[ ] I have covered the changes with unit tests

@chad11111


Mouse scroll wheel not working

Hi,
I am using Red Hat 6.5 with rdesktop 1.8.2 (tested with 1.8.3 too) and xrdp 0.5.0-0.13.el6 (tested with 0.6.1-3.el6 too). I tried to connect to the server using rdesktop but the scroll wheel does not work. xev does not show any reactions when scrolling up or down. But using middle button works. What do I have to do for the server to receive wheel events?
Here are some useful details:
a) Windows native rdesktop client -> linux VM xrdp 0.5.0 scroll OK
a) Linux rdesktop 1.8.2 -> Windows VM scroll OK
According to the rdesktop client developper (source here, the issue is with the xrdp implementation, not supporting "slow-path".
I haven't tried with latest xrdp  0.6.1-4.el6, from epel repo.
Thank you.

Can you try with xrdp building the sources from git ?

I tried compiling it with --prefix, copying the compiled files in a VM. I had lots of trouble making it start. The service use new Lsb interface I believe, not used in RedHat 6. So I replaced theses functions with echo or start-daemon, but it didn't work. If I start manually (/etc/xrdp/xrdp.sh start) , I can see a port in LISTEN state. When I rdesktop to it, I have segmentation fault... So it's quite complicated...

I confirm that with 0.8.1 from 0.8 branch 20 Apr 2015 the mouse scroll wheel works.


win: use GetQueuedCompletionStatusEx directly

It was introduced in Vista, so we can assume it's always there now.

I think we could remove a couple of similar indirections... I'll take a look and send more PRs if we can remove similar code.

Oh I thought you he name was odd indeed but hadn't made the connection.
Do we support that? It's not listed as a supported platform.

Looks like it was fixed in Wine 3.21? https://bugs.winehq.org/show_bug.cgi?id=43878

Do we support that? It's not listed as a supported platform.

I test under Wine more frequently than under real Windows. Make of that what you will. :-)
I do believe this was fixed upstream. I'll try to test this PR later today.

Yes, but... that doesn't really matter because we don't support Wine in the first place, right? Anyone can still have their Wine, it just needs to be new enough.
(I was working my way up to a Beaujolais joke but I don't want to cause any sour grapes.)

Yeah, I echo the sentiment with @bnoordhuis here. We do still uphold the Linux support promises we make in SUPPORTED_PLATFORMS. Wine is... different.
I'd be surprised if someone is using such an old distro while at the same time using an app with the latest libuv, that means they compiled it themselves or is part of a new application. They can install a more recent Wine.

@vtjnash Ping, your thoughts?

Wine is often a very useful debugging platform, since it can have better debuggers (particularly rr), compilers, and source code. That said, most of my development machines are supposed to be upgraded soon as 18.04 is close to end-of-life, and I often have wine built from source somewhere around. That said, the older wine that this would break does come as part of the linux in the SUPPORTED_PLATFORMS list. And by that argument, someone using such an old distro could also "just install" a more recent distro.
That said, it also looks like this PR would probably break ReactOS which appears to still declare GetQueuedCompletionStatusEx as a stub
And note that this reverts 153ea114fff672b9c621a5d2bb13cea667b4499e, just for the historical link (from prior to this API existing in wine at all)

Ubuntu 18.04 will be EOL soon. Probably it's time to merge this?

Hello, it's almost 2025! I see no obstacles for this PR to land now, are they? Ubuntu 18.04 has been EOL for over a year now. @vtjnash can you PTAL?

Reading this back after 2 years...

(I was working my way up to a Beaujolais joke but I don't want to cause any sour grapes.)

...can we all agree that was a terrific pun?

10/10 banter :-P