A way to get the t-function outside of components

Is your feature request related to a problem? Please describe.
Maybe I'm missing something, but it does not currently seem possible to translate things outside of components/hooks without passing down the t function as an argument manually which is quite a hassle. For instance, we have various functions that open toasts on errors and those have to be translated.
In previous versions of the library we could get the global instance via the module that initialised next-i18next.
Describe the solution you'd like
Perhaps something like this:
https://github.com/vinissimus/next-translate#gett

Hey @skrivanos, thanks for the feedback.
There isn't a global singleton in<EMAIL_ADDRESS>which you can just import and use as there was in previous versions. However, you always have access to:
const { i18n } = useTranslation()

And can do whatever you like with it, including assigning it to a global singleton.
Let me know if you have any thoughts or suggestions!

Hey @skrivanos, I've had a think about this, and have come up with a way of exporting a global singleton. I will put together a PR and have this released within the next ~24 hours.

@isaachinman Thanks for the extremely fast reply (and potential fix - I didn't even have time to respond!)
I'm impressed 👍

@skrivanos #986 should fix this. Do you mind testing the PR against your use case? You will just need to clone the repo, checkout the branch, do yarn build, and yarn link the dep.

I've encountered a similar use case, I need an access to i18n object (to change a plural form of some lang).
Your PR won't ideal, since it depends on the place & time of where AppWithTranslation is invoked (react / next will decide this).

Hey @felixmosh. Not sure it's logically possible to export a global singleton which returns identically, from a package that is in turn imported by its user and invoked with dynamic config options.
Also, the i18n object comes from context and is not created.
Open to any and all suggestions!

createClient  creates a new instance of i18next each time _app component is rendered.
Since the config is not dynamic, only the lang & it's resources...
Maybe we can create an instance with the static config, pass it to appWithTranslation which will use the passed translations
and setup them using addResourceBundle (if it is not loaded already) and then invoke changeLanguage if the current languages is not set. This approach suitable for client side.
For server side, it should still generate a new instance each render
WDYT?

createClient creates a new instance of i18next each time _app component is rendered.

Correct, but that's rather the point, isn't it?
The _app file will only be executed once per page in SSG, and once per request in SSR. What issue are you trying to solve for with the addResourceBundle approach?

@isaachinman I cannot test your MR against our code since we are yet to actually upgrade to Next 10 (discovered this problem while investigating compatibility of our current dependencies). With that said, I've had a look and I think it should work considering our use case is translating things after a user action. A bit annoying to have to check for null on the export (due to TS) but I suppose we could live with that.
However, I think @felixmosh concerns are very valid and should be taken into consideration before merging. It is indeed worrying that the instance is being re-created every app render. It seems like

The app could potentially re-render multiple times on the initial page load (which happens in our case).
The app re-renders every time Next switches route, which could for instance be when changing query params with shallow routing.

Unless I am mistaken, if the instance is re-created every time the context value will change causing a cascaded update of every single component that uses the context / useTranslation?

Unless I am mistaken, if the instance is re-created every time

This is a completely independent concern of the globalI18n feature being discussed. Yes, appWithTranslation creates a new i18next client on every render. Whether that causes a rerender of child components depends on:

How you manage your key props
Whether you're using shallow routing or not

The _app component should not rerender multiple times on page load. Not sure what would be causing that in your case, but that is not expected.

Unless I am mistaken, if the instance is re-created every time

This is a completely independent concern of the globalI18n feature being discussed.

While somewhat true, it closely relates to the feature being implemented as well (or well, to @felixmosh proposed implementation at least). It would be a shame to merge something that has to be changed later since it's an extension of the public API.

Yes, appWithTranslation creates a new i18next client on every render. Whether that causes a re-render of child components depends on:

How you manage your key props

Can you elaborate?

Whether you're using shallow routing or not

The _app is re-rendering every time there's a shallow route change. I'm not sure if there's something wrong in our code base causing this, but I just tested it before typing up my reply.
Normally this is fine, since performance critical components are memoized. However, if using useTranslation would trigger re-renders of memoized components as well there's a problem.

The _app component should not rerender multiple times on page load. Not sure what would be causing that in your case, but that is not expected.

My mistake, this was due to shallow routing as well (query params being updated on load), apologies.

Can you elaborate?

If you add a key attribute to a React component, and its props don't change, the component won't rerender.
Let's step back and think about this from a broad perspective:

The i18next client is created by appWithTranslation and therefore does not exist until _app runs
_app should only ever run once per page/request/navigation

I created a quick PoC to demonstrate the problem:
https://github.com/skrivanos/next-i18next-rerender-poc
As you can see, the component using useTranslation is re-rendered every single time the query changes despite being wrapped in memo. Now imagine that you have an advanced page with potentially hundreds of components using useTranslation and you also have the need to update the query, perhaps because of filtering or whatever. This will quickly become a performance issue and I'd say this is a serious problem (would definitely prevent our upgrade, at least).
I suppose the easiest solution would be to wrap the created i18n instance in useMemo or simply feed the context with the global instance if it's set?

@skrivanos Yeah, I think it would be an easy issue to solve. Would you be interested in working on a PR?

guys, when u can merged this PR, very need this fix )

@skrivanos Any update? Would be great to get this merged soon.

@isaachinman I am very swamped at work right now because of an upcoming deadline so I don't have time to do much else right now unfortunately. However, I feel like if you're OK with the API you can go ahead and merge your MR. The only other solution that I think might make sense is so allow you to pass a custom i18n instance to appWithTranslation like @felixmosh proposed, since this would also take care of the "i18n might be null"-problem. But I can see how that might be complex in some ways...
The memoization problem could be solved as part of a separate issue like you mentioned before.

// not-component.js
import { i18n } from 'next-i18next';

console.log(i18n.t('common:hi'));

The only thing that confuses me is that I can access all the namespaces. I do not know how critical this is, but this is the worked.


Missing perldoc-html.tar.gz archive.

On the recent version of webpage there is missing  perldoc-html.tar.gz archive.
Previously it was accessible from https://perldoc.perl.org/perldoc-html.tar.gz url.

This hasn't been provided since before the previous refresh, but it is a goal to provide an offline copy of the docs again. It will not have a search function at least for the first iteration since the current search implementation requires a server.

Ok, I'll be waiting. Thanks.

Is it to possible to add Perl version to the archive? For example: https://perldoc.perl.org/perldoc-html-5.32.tar.gz

Is it to possible to add Perl version to the archive? For example: https://perldoc.perl.org/perldoc-html-5.32.tar.gz

The URL will likely be completely new and archives of individual perl versions could be done.

The URL will likely be completely new and archives of individual perl versions could be done.

Это не предоставлялось с момента предыдущего обновления, но цель - снова предоставить автономную копию документов. У него не будет функции поиска, по крайней мере, для первой итерации, поскольку для текущей реализации поиска требуется сервер.


Deactivate keybinding if terminalFocus active

Add when !terminalFocus to all Ctrl+R commands
Fixes #19
Fix typescript lint errors

Good morning my friends
About the issue
https://github.com/gamunu/vscode-yarn/issues/19
There is still the occurrence of no longer switching between workspace using the shortcut keys
CTRL-R


Deserialization likely to fail in Grapher

The current Cereal-based deserialization is likely to fail in Grapher.

The Cereal exception message is like Failed to read 8 bytes from input stream! Read 1.
The error does not always happen.
The same story chunk can be extracted successfully the next time using the same code in potentially another Keeper extraction thread.

@fkengun  Please, update this ticket if you can still observe the issue. Please, close the ticket if the issue has been resolved.

resolved in #166


Alpha premul and LOAD_PREMULTIPLY_ALPHA

Ability to go alpha premultiplied (without going back).

I think this shouldn't be a load flags. This doesn't change layout, so the benefits of loading with the right premultiply are thiner.

...but it's still an importat decision, resizing and sampling work better / differently in some premul configurations.

Superseded by #52


Updates for parsing hashedrekord LogEntry

Summary
Updates to remove nonexistent fields and add functionality to parse hashedrekord LogEntry struct.

You are right, thank you @flavio!


What goes on ordered-startup-listener

I do not understand the documentation.
Which content goes on the "/path/to/ordered-startup-listener" file?
Is the path of the ordered_startup_supervisord.py file installed ?
Thanks.

i assume it is the /usr/local/bin/ordered-startup-listener (if you install via pip)


Adds a created_at column to the reports table

Description

Adds a created_at column to report table.

Checklist

[ ] Add tests for these changes
[ ] Test coverage is not decreased
[ ] Entire test suite passes

Codecov Report

Merging #158 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   97.49%   97.51%   +0.02%
==========================================
  Files          24       25       +1
  Lines        1475     1488      +13
  Branches      236      236
==========================================
+ Hits         1438     1451      +13
  Misses         21       21
  Partials       16       16

Impacted Files
Coverage Δ

src/spellbot/data.py
100.00% <100.00%> (ø)

...ersions/b887e657fb80_adds_created_at_to_reports.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb100d4...7ab23f8. Read the comment docs.


Update actions workflow to support windows

Purpose

Update actions workflow to support windows

Codecov Report

Merging #20552 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20552   +/-   ##
=======================================
  Coverage   15.21%   15.21%
=======================================
  Files          50       50
  Lines        1341     1341
  Branches      208      208
=======================================
  Hits          204      204
  Misses       1121     1121
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec03242...c8a06a7. Read the comment docs.


Text file busy when removing unused services using the cleanup class

Environment details

OS: Ubuntu 22.04
PHP version: 8.1
Package name and version: v2.15.1

Steps to reproduce

Install client composer require google/apiclient:^2.15.0
Add the cleanup scripts  "scripts": {
      "pre-autoload-dump": "Google\\Task\\Composer::cleanup"
  },
  "extra": {
      "google/apiclient-services": [
           "ShoppingContent",
      ]
  }

Run composer update

Code example
composer update

Exception Example
Script Google\Task\Composer::cleanup handling the pre-autoload-dump event terminated with an exception

In Filesystem.php line 200:

Failed to remove directory "(/path/to/project/vendor/google/apiclient-services/src/._Mj2": rmdir(/path/to/project/vendor/google/apiclient-services/src/._Mj2): Text file busy

See #2504

I have tried this fix previously ,and again just now, in case @bshaffer but the issue still occurs. It doesn't appear to be an issue with composer timing as the dump takes a minute or 2, it just seems to be tripping up when deleting the unused services.
The script seems to rename the google/api-client-services/[DIR] folder first then start unlinking files with no issue, but gets stuck removing the Resource folder in the API service and that appears to be what's throwing the Text file busy error.

One thing I noticed here is you're receiving the error for a ._Mj2 file. I'm not sure where those are coming from, but they're not distributed as part of our package. This could be the problem.
Because we haven't received an update on this, I'm closing it for now. Please reopen it or submit a new issue if you continue to have this problem.

@bshaffer I think this can stay closed, but for any update for anyone that comes across this. If you're using Windows with Virtualbox and Vagrant, the way Vagrant maps folders between the virtual environment and the physical Windows host, there can be significant lag which causes the "Text File Busy" error.
It seems to have stopped in google/apiclient v2.15.3 for myself, it could also be due to numerous factors however so I can't guarantee this will work for anyone else experiencing it.


Provisioned 2 CLP sites in a same tenant,both point to the same admin Page

Repro steps:

Run PnP provisioning on site collection#1 https://contoso.sharepoint.com/sites/clp1
Run manual web part installation on site collection#2 https://contoso.sharepoint.com/sites/clp2

Access file https://contoso.sharepoint.com/sites/clp2/sitepages/CustomLearningAdmin.aspx
Redirected to https://contoso.sharepoint.com/sites/clp1/sitepages/CustomLearningAdmin.aspx

Would like to understand the reason of this
How to do if customer has pilot and production sitecollections

Thanks.

You cannot have two "master" custom learning sites in the same tenant.  To be honest your scenario doesn't sound right.  If you have run the manual installation (which include a powershell script) then the master (assuming you did it in the order you said) should be the site clp2.  Which would mean if you access the CustomLearningAdmin page in clp1 it should give you an error message on the page not redirect you.
If you feel you need an entirely separate instance of custom learning then you need to create a separate tenant, maybe using a free developer tenant.  The reasoning for this is so that the custom content is all administrated in one site collection but the web part can display content in any site collection.


fix(docker): node-jiti directory created in project root

Environment
Docker
jiti 1.17.1
node 19.7.0-alpine
Reproduction
https://github.com/dargmuesli/nuxt-jiti
Describe the bug

docker build -t nuxt-jiti .
docker run --rm -it nuxt-jiti /bin/sh
ls -la
see that there is a node-jiti directory in the project's root

I'd expect the directory to be under /tmp.
Additional context

remove "postinstall": "nuxt prepare" from the package.json
append RUN pnpm nuxt prepare to the Dockerfile
run all steps above
see that node-jiti is created in /tmp, as expected

Hi thanks for reporting the issue and repro. I still didn't check repro but we do use os.tmpDir() it is strange not happening. Is tmpDir inside container also / ??

I've checked that as well and looked into the code, I'm wondering the same. $TMPDIR is /tmp inside that container. Almost sounds like a NodeJS bug on alpine Linux maybe.

Nice finding!! Is there a way we can hotfix maybe detecting TMPDIR===CWD()?

We could detect that, but I don't know what we shall set it to then... :thinking:

Not sure but in that case, we can try to clear the env, use os.tmpdir() (and restore to keep pnpm working as it was)

Good idea, that looks like a fair workaround! :raised_hands:

Reopening this to have it closed by the #123


More rawgl updates

Added md_ret_require to build.
Somehow we got an extra quote at the end of addPort

You also left off a quote in your PR here. I've fixed it in https://github.com/zerojay/RetroPie-Extra/pulls/80.
Thanks.


Ignore empty name property in post type discovery

Fixes #756.
Rather than check for the presence of the name property, check for the presence of a value assigned to name.

@gerwitz This should fix the issue you reported regarding notes being discovered as articles. It’ll be in beta-18, which I’ll try and ship in the next week (I’d like to incorporate some of @jackdbd’s contributions as part of the next release too).

Thanks! I hadn't even gotten to creating an issue and you've already resolved. 🫡


Moving Inline CSS in separate files.

I have moved all inline CSS styles in their specific files.
I have used all ID's and classes that have been used before, and also have added some classes and ID's for some elements, (mainly divs).
There is room for improvements so I will be waiting for any specific suggestion.

Styling can be further refined in the near future (perhaps we can also consider adding SCSS), looks good for now


coverage reports attached to merge commits on pull requests

I was experimenting with this action to include it in my workflows. As I was testing with the pull_request event, I realised that the git notes that the action is adding ( by the way, kudos on using git notes for storing coverage reports. It is a cool and neat use of the feature 👏 🎉 ), is being added to merge commits and not to the last commit in the pull request.

I tried to checkout github.head_ref in actions/checkout in a vain attempt to see if that would make a difference, but it did not.

Upon inspecting the code further, I noticed that the note was being added to github.context.sha
https://github.com/gwatts/go-coverage-action/blob/810cf8408bc4d88c4edb030a24f84f090afbbad4/index.js#L68
which, according to the documentation for GitHub Actions, points to the Last merge commit on the GITHUB_REF branch.
This means that there would never be priorCoverage unless there is a companion action run on:push event as well which will push coverage reports on the actual commits on the branch.
Can we instead, push the note to the last commit in the pull request so that the notes are always available?
I am not sure whether the context payload https://github.com/gwatts/go-coverage-action/blob/810cf8408bc4d88c4edb030a24f84f090afbbad4/index.js#L75
would have something like pl.pull_request.head.sha; but if it does, can we target that please? That way, we would not have to have another action that targets on:push events as well in order for the on:pull_request workflows work reliably.

Hi @shinenelson - Thanks for the detailed report!
I actually intended this action to be used in conjunction with a push event as well on the main branch so that the coverage is tracked for commits on that branch
The problem with relying on notes attached to commits in the PR is that they're essentially lost when/if the branch is rebased or squash-merged as the hash will change.

The problem with relying on notes attached to commits in the PR is that they're essentially lost when/if the branch is rebased or squash-merged as the hash will change.

Fair enough. It would be helpful to add this to the ReadMe so that another user who attempts to run this action only on: pull_request event would not be confused by this " intended behaviour "


Updated CSS & Display Styling

Description
Updated CSS & Display Styling
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test, no issues.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Hey Amanda, I'm going to clean this stuff up locally so we don't merge code that could be potentially dated. Would you mind creating a new branch for your feature and pulling down code from master?


Fix menu dismiss when scrolling

What

This is the fix for dismissed menu when chat pane is scrolling
https://skype.visualstudio.com/SPOOL/_workitems/edit/2915497/
Why

How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Also can you check other places where we use preventDismissOnResize and also update those if necessary?


support cell list args

when migrating code i get a lot of
TypeError: unhashable type: 'list'

And your proposed solution is?
I don't really know how to properly deal with it. If you just cast to tuple, you do something very intransparent.


AssetHub <> Relay reserve flippening

We should flip the source of truth for AH and Polkadot for DOT reserves. This will allow us to use AH with DOT as fee payment and also transfer it through AH to other chains.
As a result we can then use the various features of the new XCM functions to transfer and pay fees which is not possible to do through Polkadot relay chain since it doesn't understand other assets than DOT.
Change the reserve chain for DOT from Polkadot relay chain to Polkadot AssetHub.
Schedule the runtime upgrade to happen at some fixed point in time later (with enactment at least 3 days)
Transfer all of the Hydration parachain DOT from the Relaychain to Hydration parachain account on AH at the scheduled flippening time. (we will need to sync these events as close as possible)
Inform

[ ] make a public post this will happen at least a week - 2 upfront and then post more when the date is closing in @lolmcshizz
[ ] nova wallet
[ ] talisman
[ ] subwallet
[ ] paraspell
[ ] our sdk @nohaapav
[ ] xcm sdks? @green-jay
[ ] other wallets? @green-jay

2 runtime upgrades and 2 extra referenda to move funds
1. transfer 1/2 to AH
2. make asset hub reserve chain
3. grace period for UI’s and integrations to start using AH
- optionally rebalance reserves if necessary
4. remove polkadot as a reserve
5. move rest  to AH

transfer 1/2 to AH - calldata
0x6b0003010003140004000000000700e40b540213000000000700e40b540200060102286bee020004000101630b03000100a10f03000101007369626cf20700000000000000000000000000000000000000000000000000000304000000000f0080d5cd60b6510000000000140d0102040001010070617261f2070000000000000000000000000000000000000000000000000000

PR for making AssetHub as dot reserve: https://github.com/galacticcouncil/hydration-node/pull/896

PR to make AH DOT reserve: https://github.com/galacticcouncil/hydration-node/pull/896

When we do the flippening and change the location of DOT in our asset registry, we also need to change it in code: https://github.com/galacticcouncil/hydration-node/blob/eddc67f3b0e7ea8f8c979e90004b3c016f7afb90/runtime/hydradx/src/assets.rs#L777


Custom display of current slider value

This isn't an issue, but a query for an Ionic app I am building.
I do not want the current slider value floating to the right of the handle, instead I want it at the top of the slider. You can see an example of what I am trying to achieve on the demo below.
Demo: http://jsfiddle.net/2txyzo3n/2/
I have tried doing a custom template but I seem to be limited to what I can do as I can't change the root element and then everything goes a bit wild if I try and introduce new divs.
I also tried forcing it with position absolute to the top but then I can't centralise it (I.e. simple text-align: center) so as the value increases / decreases it becomes off-centre.
I also noticed that the slider cannot be contained in a div that is text-align center as the handle goes off, I can fix it by changing by adding the below but it's a bit of a hack, any suggestions on how to position the slider centrally within a container div?
.rzslider.rz-vertical .rz-bar-wrapper {
        left: -7px;
    }

Any help is appreciated
Thanks

For your first question, the best would be to completely hide the label and
display the value with a div outside the slider. There is an option to hide
it, I can't access Github right now so you need to look in the
documentation.
For the centering part, I'm not sure to understand how you do it. If you
don't use it already, you should try flexbox which is great for these
positioning issues.
Le jeu. 17 nov. 2016 16:32, Lee Turver<EMAIL_ADDRESS>a écrit :

This isn't an issue, but a query for an Ionic app I am building.
I do not want the current slider value floating to the right of the
handle, instead I want it at the top of the slider. You can see an example
of what I am trying to achieve on the demo below.
Demo: http://jsfiddle.net/2txyzo3n/2/
I have tried doing a custom template but I seem to be limited to what I
can do as I can't change the root element and then everything goes a bit
wild if I try and introduce new divs.
I also tried forcing it with position absolute to the top but then I can't
centralise it (I.e. simple text-align: center) so as the value increases /
decreases it becomes off-centre.
I also noticed that the slider cannot be contained in a div that is
text-align center as the handle goes off, I can fix it by changing by
adding the below but it's a bit of a hack, any suggestions on how to
position the slider centrally within a container div?
.rzslider.rz-vertical .rz-bar-wrapper {
left: -7px;
}
Any help is appreciated
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/angular-slider/angularjs-slider/issues/461, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACjfUoJ1o18N8vl4srak3XJKNWUleH_oks5q_HOZgaJpZM4K1chZ
.

Closing as there was no answers for months.


Remove play macro rolling

Forgot to double check that GMs are the only ones who can roll via macros.
This should be a relatively easy fix.

Resolved in #15


Message notification in browser tab

It would be really handy if the title in your browser tab would update when you receive messages while the tab is out of focus. That way if someone logs into the game and talks to you while you're looking at something else you'd have a quick notification to let you know to check the game.

A first cut of this feature could update the notification every time a message is received. In the future I could see it only updating on communication (e.g. SAY or TELL messages) or even being configurable about what kinds of messages the player thinks are important. Doing that would probably require sending some additional metadata along with each message.


added a builder option to set the read_chunk_size

Addresses https://github.com/hyperium/hyper/issues/1706

I filed #1708 for the adaptive buffer stuff.

I've taken this branch and made the edits I mentioned, with the beginnings of a ReadStrategy enum, and merged into master in this commit: https://github.com/hyperium/hyper/commit/2e7250b6698407b97961b8fcae78696e94d6ea57
Thanks!


Update type of the Deque Count

https://github.com/MicrosoftDocs/azure-docs/issues/103508#issuecomment-1373702277

@ggailey777

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

emailed GG

emailed author

emailed author

sent reminder to ggailey777

sent reminder to ggailey777

email and Teams msg to author

Your commit is now in my private PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/263427
Thanks again for your help. #please-close


:bug: fix CONTRIBUTING.rst tabs rendering

Signed-off-by: Harmouch101<EMAIL_ADDRESS>What was wrong?
Related to Issue #4462
How was it fixed?
By replacing tabs directives with collapsable sections.
Cute Animal Picture
:dog:

[ ] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[ ] Add or update relevant docs, in the docs folder and in code.
[ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[ ] Run pre-commit hooks and fix any issues.
[ ] Run pytest and tox, no tests failed.

Yeah, I see.


[BUG] healthcheck fails due to redirect response (302) when using https

Environment
Self-Hosted (Docker)
System
Debian GNU/Linux 11 (bullseye) / Docker version 20.10.5+dfsg1, build 55c4c88
Version
Dashy version 2.1.1
Describe the problem
I am running Dashy in a docker container on debian.
I specify my own ssl certificate as per instructions at https://github.com/Lissy93/dashy/blob/master/docs/management.md#passing-a-self-signed-certificate-to-dashy
dashy runs fine with https on port 443 , has correct certificate, no errors in log, able to configure & run with no problems.
the only issue is the healthcheck..
its fails due to a redirect (302) message returned  - (redirection from http to https i assume)
the command used to test healthceck is:
docker exec -it dashy yarn health-check

the result is :
yarn run v1.22.15
$ node services/healthcheck
[Sat Aug 13 2022 12:10:24 GMT+0930 (GMT+09:30)] Running health check...
Status: 302
Request took 0.028 seconds
---
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Is there someway to get the healthcheck to test against https (443) instead of http (80)
my workaroud is to specify
healthcheck:
  disable: true

in the docker-compose.yml but it would be nice to have healthcheck active.
Thanks.
Additional info
No response
Please tick the boxes

[X] You have explained the issue clearly, and included all relevant info
[X] You are using a supported version of Dashy
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Closing as dup of #840 and #768

I have been having the same issue.  I think the issue is with the isSsl test at the beginning of healthcheck.js.  It is determining if SSL is applicable strictly based on the SSL-related environment variables (SSL_PRIV_KEY_PATH and SSL_PUB_KEY_PATH) that are mentioned in the docs amcusack linked:
Passing a Self-Signed Certificate to Dashy
Once you've generated your SSL cert, you'll need to pass it to Dashy. This can be done by specifying the paths to your public and private keys using the SSL_PRIV_KEY_PATH and SSL_PUB_KEY_PATH environmental variables. Or if you're using Docker, then just pass public + private SSL keys in under /etc/ssl/certs/dashy-pub.pem and /etc/ssl/certs/dashy-priv.key respectively

The docs indicate that with Docker you just need to pass the key files to the container (without specifying the environment variables), and indeed Dashy will run in SSL mode by doing so.  However, because healthcheck.js is only using the environment variables to determine the SSL status, if you don't set them it assumes non-SSL and ultimately fails because it gets a "302 Found" instead of a "200 OK".
Ideally, the isSsl check should probably include whatever mechanism Dashy is using to put itself in SSL mode based on the presence of the key files in the container, however you can work around this issue simply by specifying the environment variables with docker run / docker compose:
--env SSL_PUB_KEY_PATH="/etc/ssl/certs/dashy-pub.pem"
--env SSL_PRIV_KEY_PATH="/etc/ssl/certs/dashy-priv.key" \
By specifying the environment variables (in addition to passing the key files), the isSsl check determines the correct status and the rest of the healthcheck proceeds as it should.
This issue has been closed as a duplicate of #768 and #840, however it isn't resolved by those issues.  I'm going to create a new issue for it with the additional details, but wanted to post the workaround here for those that may find this issue (#843).


Require ActiveSupport core_ext for Strings in OriginalRecord factories

Builds were failing on dpla/KriKri#86, @AudreyAltman's compare records PR. Looking at Travis logs for the failed build, running the database migrations (called by the Devise-related generator steps) were failing, because of a NoMethodError for String#strip_heredoc. This change introduces the minimal dependency on the specific ActiveSupport core extensions module used in the OriginalRecord factories.

Should we push this into #86.

Yes, but I'd recommend at some point (during or after review) that we rebase #86 against develop - the branch was started before we cut the 0.1.0 release of Krikri.


PAPP-21883 - Mark as FIPS compliant

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[X] Testing of all the changes has been performed (for bug fixes / features)
[X] The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
[X] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[X] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[X] Verify all checks are passing.
[X] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[X] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[ ] New App
[ ] Bugfix
[ ] Feature
[X] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Release Notes (REQUIRED)
Set FIPS compliant flag to true
What is the current behavior? (OPTIONAL)
Did not have FIPS compliant flag
What is the new behavior? (OPTIONAL)
Set FIPS compliant flag to true
Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

Integration tests are passing until 1 hour timeout. Continued tests on GitLab and passed. - https://cd.splunkdev.com/phantom-apps/app-tests/-/jobs/26582220

Created a merge request for adding the Apache license.
https://cd.splunkdev.com/phantom/app_release/-/merge_requests/1811


subtype dropdown not populating

I don't seem to be able to modify the subtype in our IPT (https://ipt-obis.gbif.us/).  For example, I have two datasets (1994 dataset, 1995 dataset) that should both have "Observation" as the subtype:

However, in both cases, the subtype menu dropdown only populates with "no subtype", even though the previous screenshot shows a subtype listed for one of them. Here is a screenshot of the metadata editor for the 1995 dataset:

Is this a bug, or am I overlooking something?

Thank you for contacting us @sformel-usgs
Looks like a bug, I'll check it


Bump electron-prebuilt version

Signed-off-by: Brian Grinstead<EMAIL_ADDRESS>I was getting an error before updating:
><EMAIL_ADDRESS>postinstall /fawkes/node_modules/electron-prebuilt
> node install.js

module.js:327
    throw err;
    ^

Error: Cannot find module 'process-nextick-args'

Closing - this is now a dupe of #49


Features Approval: new-note template, new-note command

I'm willing to implement following features:

New note template
The template could be set in a configuration (string) or an optional file, whichever you prefer
And embedding data with {title} and maybe {date}. For my use-case I don't really need date, but I presume it will be a popular feature

New note command
Asks for filename/title and pass it as the reference parameter to openDocumentByReference()

Basically what this extension does https://github.com/monferrand/mzettel but integrated so the template works when cmd/ctrl+clicking a new wiki-link

If you agree to implement those features, then I need your feedback:

Would you like the template to be set in a configuration or a file? or any other idea?
Do you agree with the {title} syntax?
Would you like an empty template as default or # {title} or any other?

Would you support multiple templates with some sort of option to choose which template on new note creation and support a default new note template? If so I think the template as a file would be the most user-friendly approach. Otherwise a string makes sense as it would be more or less a default note header.

I didn't intend to support multiple templates.
I could give it a try if @svsool agrees to it, but I'm not sure how the interface would be, maybe a folder like .templates an put all the templates in there?
Nevertheless, I cannot promise to do it, I barely got confidence to do this because I intend to guide (copy :laughing:) from the extension mentioned

Hi @madacol,
Thank you for spending the time and figuring out how to implement these features!
My 0.02$:

New note template

If we want to implement this feature, I would like to understand if we can potentially surpass the functionality of VSCode snippets or at least come close. I can see that variables for inserting the current date and time already supported by snippets.
I suggest trying out snippets first and see if it covers our needs. If yes we can add it later to the help documentation to spread best practices with the rest of the users.
I would be interested to hear your opinion about this 🔼 suggestion.

New note command

It would be nice to have this feature implemented.
More ideas from me:

Configuring default folder where new notes are created on entering short reference

Notice: Memo works both with short references and long (absolute) references on filename collision [[My note]] vs [[Root folder/My note]]

Inferring folder dynamically based on the currently opened document

Do you have some other ideas?

Regarding the note template and the VSCode snippets:
Extensions (like Memo in this case) can supply their own snippets
We could supply some basic functionality based on this extension use case:

journal
books
resources?
???

Regarding the template
Thanks @svsool! :tada:
VSCode snippets along with the extension Auto Snippet completely solve my use case.
VSCode snippets alone should solve @lachyc use case too
@abuggin I think its a good idea to have basic templates :+1:, but I believe they should be part of the documentation, not the extension itself. I think not many templates are usable right away without some customization, just a different language alone would make most template unusable.

Regarding the New note command
VSCode's built-in command New file already creates a file like your second use case:

Inferring folder dynamically based on the currently opened document

Which satisfy my use case too, because Auto Snippet triggers the template on file creation

How should the new note command work for your use case?. This is how I infer the logic:
Check if there's a configured default folder (is a non-empty string?)

if yes: Ask for reference, if it's short: create note in configured folder, if long: create it relative to root folder?
if no: call New file command

Correct me if I got anything wrong

Regarding the New note command
VSCode's built-in command New file already creates a file like your second use case:

Inferring folder dynamically based on the currently opened document

Which satisfy my use case too, because Auto Snippet triggers the template on file creation

Given said it would be good to ask:
Do you still have a need in "new note" command?

How should the new note command work for your use case?.

Those were just an initial ideas / suggestions. In my case new file command is fine.
Regarding default folder + focused document folder logic - I gave it one more thought and I think it's not flexible enough and quickpick popup with long reference autosuggest (like any terminal does for paths) will do that job much better.
@madacol

Do you still have a need in "new note" command?

Not really. In that case I'll just dismiss this issue, just wanted to help if needed.
Anyway, thanks a lot for the suggestions (very helpful beyond this issue) and thanks for this awesome extension 👍


Optimum uses tensorflow by default when you have both torch and tf

System Info
optimum.version.__version__ : 1.7.1
python version: 3.8
system: docker running nvidia/cuda:11.7.0-devel-ubuntu20.04
torch.__version__: 1.13.1+cu117
tensorflow.__version__: 2.11.0
transformers.__version__: 4.26.1

Who can help?
No response
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
Following the hugginface blog tutorial on optimum here: https://huggingface.co/blog/optimum-inference
running pip install optimum[onnxruntime-gpu]. There were multiple connection timeouts, but that maybe a different issue.
and then running the following code snippet from the tutorial
from pathlib import Path
from transformers import AutoTokenizer, pipeline
from optimum.onnxruntime import ORTModelForQuestionAnswering

model_id = "deepset/roberta-base-squad2"
onnx_path = Path("onnx")
task = "question-answering"

# load vanilla transformers and convert to onnx
model = ORTModelForQuestionAnswering.from_pretrained(model_id, from_transformers=True)
tokenizer = AutoTokenizer.from_pretrained(model_id)

# save onnx checkpoint and tokenizer
model.save_pretrained(onnx_path)
tokenizer.save_pretrained(onnx_path)

# test the model with using transformers pipeline, with handle_impossible_answer for squad_v2
optimum_qa = pipeline(task, model=model, tokenizer=tokenizer, handle_impossible_answer=True)
prediction = optimum_qa(question="What's my name?", context="My name is Philipp and I live in Nuremberg.")

print(prediction)
# {'score': 0.9041663408279419, 'start': 11, 'end': 18, 'answer': 'Philipp'}

I see the follwing output in the jupyter notebook:
/usr/local/lib/python3.8/dist-packages/tqdm/auto.py:22: TqdmWarning: IProgress not found. Please update jupyter and ipywidgets. See https://ipywidgets.readthedocs.io/en/stable/user_install.html
  from .autonotebook import tqdm as notebook_tqdm
2023-03-08 07:20:35.187102: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-03-08 07:20:35.826999: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/local/nvidia/lib:/usr/local/nvidia/lib64
2023-03-08 07:20:35.827063: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/local/nvidia/lib:/usr/local/nvidia/lib64
2023-03-08 07:20:35.827071: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.
The argument `from_transformers` is deprecated, and will be removed in optimum 2.0.  Use `export` instead

Expected behavior
optimum seems to use the tensorflow installed on the system. This may not be an issue per se but I have both TF and torch installed for different use cases, I want optimum to use torch, because that's what I use to train my huggingface models for mainly classification tasks. I can't seem to find a way to force optimum to use torch instead. Any help will be appreciated. Thanks.

Thank you for the report @barathbheeman I believe this is due to https://github.com/huggingface/transformers/blob/b338414e614a30af5f940269484ef15bf716d078/src/transformers/pipelines/init.py#L87-L88 in transformers. Tensorflow is actually not used, just imported, which arguably is very bad if it is not useful.
I remember internal discussions about this issue, @Narsil is probably most familiar with.

Yes, but removing those imports are going to be tedious (I have started the work on some branch, felt like a never-ending fight to move imports around).

Thank you for the report @barathbheeman! I believe this is due to https://github.com/huggingface/transformers/blob/b338414e614a30af5f940269484ef15bf716d078/src/transformers/pipelines/init.py#L87-L88 in transformers. Tensorflow is actually not used, just imported, which arguably is very bad if it is not useful.
I remember internal discussions about this issue, @Narsil is probably most familiar with.

Thanks for the quick response. so the import's actually happening in transformers and not optimum. It's nice that I can force it to use torch using the 'framework=pt' argument while creating pipelines. However, it would be nice if I can completely ignore one of the frameworks.
I suppose there's no quick fix available. If you have no more comments or recommendations, feel free to close the close the issue. Thanks!


[No QA] Bump eslint-config-expensify version to 2.0.23

Details
Bump eslint-config-expensify version and update js-lint errors.
cc @roryabraham
Fixed Issues
$ https://github.com/Expensify/App/issues/7454
Tests

Run the app
Verify that there is no js-lint error in terminal.

[X] Verify that no errors appear in the JS console

QA Steps
None.

[ ] Verify that no errors appear in the JS console

Tested On

[X] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @mountiny in version: 1.1.33-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Practice Exam 8 Q 18

Right Answers is C. Amazon VPC peering is used for communication with different VPCs.

hi, @PyFaNNy
Thank you for bringing this to our attention. We apologize for any confusion this may have caused. We have reviewed Practice Exam and made any necessary corrections to ensure the accuracy of our content. If you have any further questions or concerns, please feel free to reach out to us. Good luck with your Cloud Practitioner studies!


Install signal-desktop in macOS via nixpkgs

Resolves GH-843

Ah, it has unfree license only in the darwin package...
https://github.com/NixOS/nixpkgs/pull/348165/files#diff-05921dc46b537c59c8a76dfc3c3e9a3a1fd93345ee5bff8573aae36dedf719bcR49
        (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: Package ‘signal-desktop-7.29.0’ in /nix/store/riqkpszjqk02bi1wppfg8ip5xvh102qd-source/pkgs/applications/networking/instant-messengers/signal-desktop/signal-desktop-darwin.nix:35 has an unfree license (‘agpl3Only free unfree’), refusing to evaluate.

       a) To temporarily allow unfree packages, you can use an environment variable
          for a single invocation of the nix tools.

            $ export NIXPKGS_ALLOW_UNFREE=1

          Note: When using `nix shell`, `nix build`, `nix develop`, etc with a flake,
                then pass `--impure` in order to allow use of environment variables.

       b) For `nixos-rebuild` you can set
         { nixpkgs.config.allowUnfree = true; }
       in configuration.nix to override this.

       Alternatively you can configure a predicate to allow specific packages:
         { nixpkgs.config.allowUnfreePredicate = pkg: builtins.elem (lib.getName pkg) [
             "signal-desktop"
           ];
         }

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
         { allowUnfree = true; }
       to ~/.config/nixpkgs/config.nix.

https://github.com/AsamK/signal-cli


"Graph output" button grayed out

Hi,
I just updated my repository of compiler-explorer in order to try out the new "graph output" button (the server is live at http://brownbot.hopto.org/ and it specialises in 68k compilers)  and I can't seem to enable the feature with my own set of compilers. Here's a few things about the machine and what I tried so far:

It's a raspberry pi 2 running linux raspbian wheezy
The only thing I changed from a clean repository is etc/config/c++.defaults which I'm attaching for reference. - c++.defaults.zip
I tried running npm update in case packages were out of date
I reverted the repo fully and then enabled the gcc arm compilers. Then the button worked as expected.
Just as a test I added both native arm gcc and my cross compilers (some are gcc). Then I can press the "graph output" button on the arm compiler, but switching to the 68k gccs, the window refreshes with "no output"

After this I ran out of ideas to try. The server is running as described in the last step if you are inclined to check.
Any pointers on what to do would be appreciated. Worst case I can live without that particular feature but when possible I do like the shiny new stuff like this :)
Thanks for your time,
George

@cppchedy -- I think your parser only works on x86 assembly so far, is that right?

It seems to work for arm too fwiw!

@ggnkua it should only work for x86 as said by @mattgodbolt . but if you want you add other arch, you need to add  predicates to detect jmp instruction in lib/cfg.js. I think I will write a tutorial on how to add new compilers/lang/arch.

@ggnkua - did you get anywhere with this? I think it should appear in the UI but probably get confused over the opcodes. I'm not sure how it decides whether to display the option to graph or not (@cppchedy do you remember?)

No, there's not enough time to dive into this :). And since I see you're in a spring cleaning spree, lemme save you the trouble and close this one myself!

@mattgodbolt sorry I don't remember exactly but I think it was a simple check for gcc and clang (for x86).


[Designer] Validation error when input id values are dynamic

If I have a loop that outputs different fields based on an inbound configuration and the name value is dynamic from the inbound data, the Designer throws a validation error.
{
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.5",
    "body": [
        {
            "type": "TextBlock",
            "text": "Settings"
        },
        {
            "type": "Container",
            "items": [
                {
                    "$data": "${settings}",
                    "type": "Container",
                    "items": [
                        {
                            "type": "Input.Text",
                            "$when": "${type == 'text'}",
                            "label": "${label}",
                            "value": "${if(value, value, if(default, default, ''))}",
                            "id": "${name}"
                        },
                        {
                            "type": "Input.Date",
                            "$when": "${type == 'date' || type == 'datetime'}",
                            "label": "${label}",
                            "value": "${if(value, value, if(default, default, ''))}",
                            "id": "${name}"
                        },
                        {
                            "type": "TextBlock",
                            "$when": "${description}",
                            "text": "${description}"
                        }
                    ]
                }
            ]
        }
    ],
    "actions": [
        {
            "type": "Action.Submit",
            "title": "Save",
            "data": {
                "tag": "settings"
            }
        }
    ]
}

The error is "[Validation] Duplicate Id "${name}"." It seems like, at least in the context of a loop like this, the validator should skip this if any part of the id is dynamic. Or at least it should show a modified message along the lines of "[Validation] Using an ID value of "${name}" for multiple fields may cause errors if the inbound data is not unique."

This is currently by-design as the validation does not have logic to fully evaluate the templating mechanisms and run through a full evaluation of what side effects templating could have. There are definitely ways we could improve on this, but those are currently out-of-scope for the time being.

I have a valid use case for duplicate id fields, where I have multiple optional Action.ShowCard types, but only need one card filled and submitted.
Example, "id": "identity" needs to be repeated in each card, so that i can extract the identity value on submission later.
{
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "type": "AdaptiveCard",
    "version": "1.3",
    "actions": [
        {
            "type": "Action.ShowCard",
            "title": "Get Mailbox Permission",
            "card": {
                "type": "AdaptiveCard",
                "body": [
                    {
                        "type": "Input.Text",
                        "id": "identity",
                        "label": "Mailbox Owner"
                    }
                ],
                "actions": [
                    {
                        "type": "Action.Submit",
                        "title": "OK"
                    }
                ]
            }
        },
        {
            "type": "Action.ShowCard",
            "title": "Add Mailbox Permission",
            "card": {
                "type": "AdaptiveCard",
                "body": [
                    {
                        "type": "Input.Text",
                        "label": "Mailbox Owner",
                        "id": "identity"
                    },
                    {
                        "type": "Input.Text",
                        "label": "Mailbox Delegate",
                        "id": "delegate"
                    }
                ],
                "actions": [
                    {
                        "type": "Action.Submit",
                        "title": "OK"
                    }
                ]
            }
        },
        {
            "type": "Action.ShowCard",
            "title": "Remove Mailbox Permission",
            "card": {
                "type": "AdaptiveCard",
                "body": [
                    {
                        "type": "Input.Text",
                        "id": "identity",
                        "label": "Mailbox Owner"
                    }
                ],
                "actions": [
                    {
                        "type": "Action.Submit",
                        "title": "OK"
                    }
                ]
            }
        }
    ]
}```

What @adrwh said. We also have the same design for our card templates. I feel without this templating is not feature full.

I have a valid use case for duplicate id fields, where I have multiple optional Action.ShowCard types, but only need one card filled and submitted.

I feel like this might be a separate request as it does not involve dynamic data in the id value.


[docs] Fix Netlify deploy with a dummy index.html

https://deploy-preview-606--mui-toolpad-docs.netlify.app/.
Until #542 is merged, I think that it would be better to keep the CI to default to green, e.g. #605. It will also help test that https://mui.com/toolpad/ proxy works as expected.

A side observation: for community contributions, it won't fly very well:

👍 agreed, IAC all things. Thanks!


[promptfile] fixed

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

Does not works for me at all:
> py -2.7 .\youtube_dl\__main__.py http://www.promptfile.com/l/86D1CE8462-576CAAE416 -v
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'http://www.promptfile.com/l/86D1CE8462-576CAAE416', u'-v']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.09.24
[debug] Git HEAD: 7fd8870
[debug] Python version 2.7.12 - Windows-10-10.0.10240
[debug] exe versions: ffmpeg N-81192-g04da20e, ffprobe N-81192-g04da20e, rtmpdump 2.4
[debug] Proxy map: {}
[PromptFile] 86D1CE8462-576CAAE416: Downloading webpage
[PromptFile] 86D1CE8462-576CAAE416: Downloading video page
ERROR: Unable to extract URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\dev\youtube-dl\master\youtube_dl\YoutubeDL.py", line 694, in extract_info
    ie_result = ie.extract(url)
  File "C:\dev\youtube-dl\master\youtube_dl\extractor\common.py", line 355, in extract
    return self._real_extract(url)
  File "C:\dev\youtube-dl\master\youtube_dl\extractor\promptfile.py", line 48, in _real_extract
    url = self._html_search_regex(r'url:\s*\'([^\']+)\'', webpage, 'URL')
  File "C:\dev\youtube-dl\master\youtube_dl\extractor\common.py", line 667, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "C:\dev\youtube-dl\master\youtube_dl\extractor\common.py", line 658, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Fixed, sorry...
python test/test_download.py TestDownload.test_PromptFile
[PromptFile] 86D1CE8462-576CAAE416: Downloading webpage
[PromptFile] 86D1CE8462-576CAAE416: Downloading video page
[info] Writing video description metadata as JSON to: 86D1CE8462-576CAAE416.info.json
[debug] Invoking downloader on 'http://www.promptfile.com/file/eyJpIjoiODZEMUNFODQ2Mi01NzZDQUFFNDE2IiwiZSI6MTQ3NDgyMTkwMCwidCI6InN0cmVhbSIsImgiOiI5YjAxMWYzNWI2NDA2YTc4YWRjNWFmOWQwMmM0MWU4NmYzOGM3ODc5IiwicyI6MX0='
[download] Destination: 86D1CE8462-576CAAE416.mp4
[download] 100% of 10.00KiB in 00:00
.
Ran 1 test in 0.897s
OK

Not merged to master: https://github.com/rg3/youtube-dl/commits/master/youtube_dl/extractor/promptfile.py. Seems it's Github bug again. @OndrejIT Could you open a new pull request?


CE App Container MD fixes

Docs Build status updates of commit c323d37:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/windows-ce-app-container.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Sdcicd 1165 boilerplate auto generate e2e scaffolding

What type of PR is this?
(bug/feature/cleanup/documentation/test/refactor)
boilerplate auto generate e2e scaffolding
What this PR does / why we need it?
Regerenates osde2e scaffolding via 'make e2e-harness-generate' . This includes openshift template yaml for tekton pod to run e2e harness.
Which Jira/Github issue(s) this PR fixes?
https://issues.redhat.com/browse/SDCICD-1165

Codecov Report

Merging #219 (e48ca93) into main (3a99a4e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   40.35%   40.35%
=======================================
  Files          25       25
  Lines        1866     1866
=======================================
  Hits          753      753
  Misses       1021     1021
  Partials       92       92

/lgtm

/approve


SVG failing to render with 1.1.0, out of memory

This SVG does not render with 1.1.0 due to an out-of-memory error, but it does render with 1.0.0.

Heap-sizes aside, the core issue seems to be a radial gradient radialGradient3595 based on the linear gradient linearGradient3589, which is then applied to path3579.
The issue stems from the two stops at 0 in the gradient. One is replaced with Math.nextAfter(...) in AbstractGradient:112, giving it a value along the lines of 1.4E-45.
In SVGMultipleGradientPaintContext, lines 275-286, this seems to cause the estimatedSize to overflow. It seems therefore the estimatedSize > MAX_GRADIENT_ARRAY_SIZE check fails, and in calculateSingleArrayGradient:344 it tries creating a massive array, causing the error.

Thank you for reporting this (and digging into the issue)!

The fix is included in version 1.2.0


Wrong output from DynamicScatter

Reproduction
In my perspective, the following script should not generate an empty tensor, because there are clearly two valid points.
I have not analyzed it in depth, but I hope the following script can help you figure it out.
BTW, according to my experience, it seems better to implement dynamic voxelization with torch.unique and torch_scatter. The output of torch.unique with return_inverse=True make it very easy to map voxel features to points by a simple indexing op instead of map_voxel_center_to_point function in DynamicVFE. The integer canvas in map_voxel_center_to_point seems memory-consuming when using very tiny voxels in 3D space.  I share my torch_scatter based DynamicVFE in the end, hope it could help.
import torch
from mmdet3d.ops import DynamicScatter
voxel_size = (0.32, 0.32, 6)
voxel_size_t = torch.tensor(voxel_size, device='cuda:0')
point_cloud_range = [-74.88, -74.88, -2, 74.88, 74.88, 4]
pc_range = torch.tensor(point_cloud_range, device='cuda:0')
cluster_scatter = DynamicScatter(voxel_size, point_cloud_range, average_points=True)
features = torch.tensor([[68.9309, 31.5947,  0.8600],
        [69.0586, 31.4590,  0.8594]], device='cuda:0')
coors = torch.tensor([[  0,   0, 332, 449],[  0,   0, 332, 449]], device='cuda:0', dtype=torch.int32)
voxel_mean, mean_coors = cluster_scatter(features, coors)
print(voxel_mean, mean_coors)

# make sure voxelization is right
print((features - pc_range[None, :3]) // voxel_size_t[None,:])

'''
Output:
tensor([], device='cuda:0', size=(0, 3)) tensor([], device='cuda:0', size=(0, 4), dtype=torch.int32)
tensor([[449., 332.,   0.],
        [449., 332.,   0.]], device='cuda:0')
'''

Environment
sys.platform: linux
Python: 3.6.8 (default, Jul  2 2019, 13:27:03) [GCC 5.4.0 20160609]
CUDA available: True
GPU 0,1,2,3,4,5,6,7: NVIDIA GeForce RTX 2080 Ti
CUDA_HOME: /usr/local/cuda
NVCC: Cuda compilation tools, release 10.2, V10.2.89
GCC: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609
PyTorch: 1.9.0+cu102
PyTorch compiling details: PyTorch built with:
  - GCC 7.3
  - C++ Version: 201402
  - Intel(R) Math Kernel Library Version 2020.0.0 Product Build 20191122 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v2.1.2 (Git Hash 98be7e8afa711dc9b66c8ff3504129cb82013cdb)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - NNPACK is enabled
  - CPU capability usage: AVX2
  - CUDA Runtime 10.2
  - NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70
  - CuDNN 7.6.5
  - Magma 2.5.2
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=10.2, CUDNN_VERSION=7.6.5, CXX_COMPILER=/opt/rh/devtoolset-7/root/usr/bin/c++, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -fopenmp -DNDEBUG -DUSE_KINETO -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=1.9.0, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON,

TorchVision: 0.10.0+cu102
OpenCV: 4.1.0
MMCV: 1.3.8
MMCV Compiler: GCC 5.4
MMCV CUDA Compiler: 10.2
MMDetection: 2.14.0
MMSegmentation: 0.14.1
MMDetection3D: 0.15.0+8e0d418

torch_scatter based VFE, having the same interface with the one in MMDetection3D:
@VOXEL_ENCODERS.register_module()
class DynamicScatterVFE(DynamicVFE):
    """ Same with DynamicVFE but use torch_scatter to avoid construct canvas in map_voxel_center_to_point.
    The canvas is very memory-consuming when use tiny voxel size (5cm * 5cm * 5cm) in large 3D space.
    """

    def __init__(self,
                 in_channels=4,
                 feat_channels=[],
                 with_distance=False,
                 with_cluster_center=False,
                 with_voxel_center=False,
                 voxel_size=(0.2, 0.2, 4),
                 point_cloud_range=(0, -40, -3, 70.4, 40, 1),
                 norm_cfg=dict(type='BN1d', eps=1e-3, momentum=0.01),
                 mode='max',
                 fusion_layer=None,
                 return_point_feats=False,
                 return_inv=False,
                 ):
        super(DynamicScatterVFE, self).__init__(
            in_channels,
            feat_channels,
            with_distance,
            with_cluster_center,
            with_voxel_center,
            voxel_size,
            point_cloud_range,
            norm_cfg,
            mode,
            fusion_layer,
            return_point_feats,
        )
        # overwrite
        self.scatter = None
        self.vfe_scatter = None
        self.cluster_scatter = None
        self.mode = mode
        self.return_inv=return_inv

    def map_voxel_center_to_point(self, voxel_mean, voxel2point_inds):

        return voxel_mean[voxel2point_inds]

    # if out_fp16=True, the large numbers of points
    # lead to overflow error in following layers
    @force_fp32(out_fp16=False)
    def forward(self,
                features,
                coors,
                points=None,
                img_feats=None,
                img_metas=None):

        features_ls = [features]
        origin_point_coors = features[:, :3]
        # Find distance of x, y, and z from cluster center
        if self._with_cluster_center:
            voxel_mean, mean_coors, unq_inv = self.scatter_v2(features, coors, 'avg')
            points_mean = self.map_voxel_center_to_point(
                voxel_mean, unq_inv)
            # TODO: maybe also do cluster for reflectivity
            f_cluster = features[:, :3] - points_mean[:, :3]
            features_ls.append(f_cluster)

        # Find distance of x, y, and z from pillar center
        if self._with_voxel_center:
            f_center = features.new_zeros(size=(features.size(0), 3))
            f_center[:, 0] = features[:, 0] - (
                coors[:, 3].type_as(features) * self.vx + self.x_offset)
            f_center[:, 1] = features[:, 1] - (
                coors[:, 2].type_as(features) * self.vy + self.y_offset)
            f_center[:, 2] = features[:, 2] - (
                coors[:, 1].type_as(features) * self.vz + self.z_offset)
            features_ls.append(f_center)

        if self._with_distance:
            points_dist = torch.norm(features[:, :3], 2, 1, keepdim=True)
            features_ls.append(points_dist)

        # Combine together feature decorations
        features = torch.cat(features_ls, dim=-1)

        for i, vfe in enumerate(self.vfe_layers):
            point_feats = vfe(features)

            if (i == len(self.vfe_layers) - 1 and self.fusion_layer is not None
                    and img_feats is not None):
                point_feats = self.fusion_layer(img_feats, points, point_feats,
                                                img_metas)
            voxel_feats, voxel_coors, unq_inv = self.scatter_v2(point_feats, coors, self.mode)
            if i != len(self.vfe_layers) - 1:
                # need to concat voxel feats if it is not the last vfe
                feat_per_point = self.map_voxel_center_to_point(voxel_feats, unq_inv)
                features = torch.cat([point_feats, feat_per_point], dim=1)
        if self.return_point_feats:
            return point_feats

        if self.return_inv:
            return voxel_feats, voxel_coors, unq_inv
        else:
            return voxel_feats, voxel_coors

    def scatter_v2(self, feat, coors, mode):

        new_coors, unq_inv, unq_cnt = torch.unique(coors, return_inverse=True, return_counts=True, dim=0)

        if mode == 'max':
            new_feat, argmax = torch_scatter.scatter_max(feat, unq_inv, dim=0)
        elif mode == 'avg':
            new_feat = torch_scatter.scatter(feat, unq_inv, dim=0, reduce='mean')
        else:
            raise NotImplementedError

        return new_feat, new_coors, unq_inv

Why does your given coors have 4 dimensions? Does it cause the unexpected output?

I think coors should be 4-dimmension (batch_idx, z, y, x) according to https://github.com/open-mmlab/mmdetection3d/blob/master/mmdet3d/models/voxel_encoders/voxel_encoder.py#L230.
I mmdet3d, voxelize function in detector will attach the batch_idx to 3-dimension coors before passing it to voxel_encoder.

Yes, I see. Have you ever tried to add a breakpoint to have a look at the intermediate results when running this function for a complete point cloud? Does it run correctly? Let's see whether this problem is a corner case or not.

According to my observations, this error only occurs when the number of points is very small. When I take point clouds containing at least 500 points as input, no empty tensor is generated and the algorithm works fine.
Although no errors are raised under this situation, I am afraid that the logical correctness can not be strictly guaranteed. I have encountered a problem that the output DynamicScatter is slightly different from the output of torch_scatter, but I can not reproduce it now.
The good news is I can obtain almost the same performance with DynamicScatter and torch_scatter, so it might not a big deal.

Thanks for your sharing of observations. I guess there might be some problems with corner cases, and I will just keep this issue open for community discussion. We will also further check this part afterward.

This is a known issue #768. It has been fixed by PR #915 since version 0.17.1.


fixed print statements for python 3 compatibility + question about modules (brombo/galgebra#35)

@micahscopes commented on Apr 24, 2017 •
edited

I forked johanbluecreek/py3_compat branch because I was having issues in python 3 with deprecated print foo, bar statements.  In python 3, print is no longer a keyword.
Here's my branch:
https://github.com/micahscopes/galgebra/tree/py3_compat
I also had trouble with the import ga style statements, and replaced them with local from . import ga style statements. This library doesn't seem to follow 'typical' python module/class conventions (which is fine by me), but this change seems compatible with the current behavior (seems like it should be).
I don't really even understand the 'typical' conventions all that well anyway.  So here's my question:  why aren't the ga, mv, etc. objects being imported via the init.py file?  To avoid polluting the global namespace?

@godefv commented on May 11, 2017

actually, to work with python 3 I had to change from  from . import foo to import foo
there was also a function from the deprecated module compiler.ast that I had to replace

From http://webcache.googleusercontent.com/search?q=cache:https://github.com/brombo/galgebra/issues/35

@utensil seems to have already labelled this as done, closing


[test] Fix cuda checks on Kesch

Fixing cuda checks as #924 was intending to do. Currently the checks are failing on Kesch:
https://jenkins.cscs.ch/blue/organizations/jenkins/reframe-kesch-production-daily/detail/reframe-kesch-production-daily/180/pipeline/

@teojgo There is already an issue on Jira for that failure: see https://jira.cscs.ch/browse/UES-533


Emphasize pipe name more than classname in flow editor

Describe the bug
When looking at a flow an trying to understand the working of the adapter the pipe names are more important than the classnames but as the classnames are bold and at the top they draw more attention. I think it would be better to turn them around. In the Graphviz flow the pipe names are on top and the classnames are mentioned below it between round brackets.
Reporter
Jaco de Groot
Category

Flow

To Reproduce
-
Expected behavior
-
Screenshots
-
Additional context
-

HMM I think I tend to disagree the function performed is more important as the name is it not?

The function only tells you so much. Like XsltPipe tells you some transformation is done but the name (when carefully chosen by the developer) tells you what it functionally does. And in case of an XmlSwitch you know a switch is done but not what switch is done. For example in the following image:
https://frank2example.frankframework.org/iaf/api/adapters/HelloWorlds/flow?1649410389515
The RenameElementLineToTest tells me more then XsltPipe and CheckDummyMessage with false/true tells me more than XmlSwitch. This is also true for other elements like CreateExampleMessage tells me more than FixedResultPipe etc.

A nice middleground could be to keep the order the same (type on top and name at the bottom) but to make the name bold instead of the type. I saw this somewhere else and it was pretty clear.

Would be okay for me I think

:tada: This issue has been resolved in version 2.22.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Error handling during postprocessing in the back end

I now have problems with the optimizations that take place in the backend. In the case of different examples, regular terminations occur here. This leaves half-finished files behind and you have to start the process over and over again. This is not nice, because it takes a certain amount of time to get to this point, depending on the file. I therefore have the following proposals:

if a process is terminated pretty much at the end, is there a change to continue with the existing files without creating them over and over again? For example, if I want to extract a certain function in the result of the assembler, I have to add it again and again during the process. It would be nice if you could analyze the original file once and then continue with it. Then the processing would be much faster.

interruption during processing in the backend. It would be nice that the complete process is not considered to be faulty, only if a processing (optimizer) has failed.

optimization of only certain functions. It would be desirable if one could specify per function which optimizations are to be carried out.

These are the main points I have noticed. It would be desirable if the processing could be made more robust and thus faster.

There are several proposals in this issue, so I will comment on them separately.

The viability of this feature depends on the input parameters. For example, if you use any of the parameters that affect earlier stages of the decompilation, the decompilation has to go through the full pipeline. However, if you only want to select which functions should be decompiled, the front-end should be able to run only once (in theory, as this not yet implemented).

Well, the back-end fails only if there is an unrecoverable error (e.g. not enough memory, segmentation fault). So, when any of its stages fails, we are out of luck. One way of tackling this would be to to try recovering from out-of-memory errors, but this will be very hard.

This is doable.


hashbrown is not following strict provenance

hashbrown is using int-to-ptr casts in some places, instead of the strict provenance APIs:
https://github.com/rust-lang/hashbrown/blob/09dc17e0d686cdeba15920a4f77462c572e7cad1/src/raw/mod.rs#L306
https://github.com/rust-lang/hashbrown/blob/09dc17e0d686cdeba15920a4f77462c572e7cad1/src/raw/mod.rs#L326
https://github.com/rust-lang/hashbrown/blob/09dc17e0d686cdeba15920a4f77462c572e7cad1/src/raw/mod.rs#L334
(there might be more)
The cases I have found so far are all inside if Self::IS_ZERO_SIZED_TYPE {, so I assume these are "fake" pointers that are never dereferenced, and could be using ptr::invalid_mut.
The fuzzy_provenance_casts lint can be used to statically check for such casts. Currently however the strict provenance functions are still unstable.

Should hashbrown use sptr crate for the time Strict Provenance API is unstable?

@Amanieu is there a usual cadence for syncing hashbrown changes to the standard library?
Looks like the version shipped with current nightly still has the old int2ptr casts in it.

We currently have several breaking changes on master, and I'm finishing up some new feature which will be released in hashbrown 0.14. I think the release should happen in the next week or two.

Cool, thanks for the update!


Fix snap_package bugs

First and foremost this fixes the bug in which #8827 where
snap_package hangs forever.
See the comment in the code for the nitty-gritty details, but snap never
returns an EOF so you have to jump through GREAT hoops not to hang
forever.
UNLESS you want to use nonblock+read, but it takes MUCH longer:
[phil@ldt-hardwired ~]$ time /tmp/test.rb char

real    0m0.252s
user    0m0.207s
sys     0m0.044s
[phil@ldt-hardwired ~]$ time /tmp/test.rb select

real    0m5.244s
user    0m0.183s
sys     0m0.056s

That's just for doing GET /v2/snaps/black
Second, if you try to install a snap that doesn't exist on the stable
channel then Chef crashes with a undefined method [] on nil, so let's
check for that explicitly.
And a bunch of other fixes that were required to even install anything:

prevent get_current_versions from returning [nil]
don't try to 'update' when something is not yet installed
don't try to install versions, install packages
don't try to push ruby hashes into HTTP without JSONing them first
when installing, install one at a time, it's the only API that accepts a channel
options is an array, not a hash

NOTE... there's a lot of janky here. A lot. It's the minimalist stuff
from #9106 I could pull in, while also making the socket stuff not
painfully slow. That PR aims to support versions and lots of other and
should be fixed up and [eventually] merged... but in the meantime this
provider doesn't even come close to working and this at least gets
packages installing.
After this, I never want to touch snap again.

Before we can merge this or #9106 we need to add some kitchen tests or snap_package exercising as many scenarios as we can reasonably do in a quick kitchen run. It's something we can't really test in unit tests and we need to have a reasonable level of confidence when merging future changes.

@tas50 - yup the few unittests that are there are basically useless. Yes, we should have a kitchen tests and I can add one. however this PR isn't meant to last. This whole thing needs a ground up re-write, and frankly, unless either the author of #9106 or lamont are going to actually do that, we should probably just remove this provider altogether. It doesn't work. I'm not even sure this will work reliably. Among other things it drops versions on the floor.... nothing here works as advertised, this just makes it not crash and at least attempt to install something.
At this point I'd almost rather just do:
execute 'snap install black' do
  not_if 'snap list | grep black'
end

for the 3 snaps I have to install. I guess what I"m saying is I can add a kitchen test that calls install (that's the ONLY thing that works at this point), or more, but I'm in no way going to take responsibility for making those tests work (only the simplest install case will work at this moment).
I actually pulled this monkey patch out of our cookbook at work and put the install into a shell script because I don't trust this provider at all, but I figured the least I could do is get something out so people who are following the attached bug might have some way forward.

I attempted to add kitchen tests, @tas50 , but it turns out that snap has some issues running in containers:
    status: Internal Server Error, kind: , message: system does not fully support snapd: cannot mount squashfs image using "squashfs": mount: /tmp/sanity-mountpoint-649535134: failed to setup loop device for /tmp/sanity-squashfs-413258619.

I know that loopback mounts can work in containers, but no idea what needs to be done to make it so.

huh I take it back, looks like it worked on Azure. Won't look a gift horse in the mouth. Woot.

@tas50 to aisle 5

@jaymzh Can you rebase it and fix the failing spec?

yeah if you're happy with the kitchentest

rebased, fixed specs.

I'll nuke the kitchen tests out later since it turns out that doesn't work in docker atm.


Some image alt texts in the tutorial need to be updated, since they are just "alt text"

Some of the alternate text of images in the tutorial (perhaps elsewhere as well) are simply "alt text". Good practice dictates these should be more meaningful, preferably indicating what they represent (not so much what the picture is).
Naturally, for SPOT, this isn't the most important thing, since SPOT is for a large part a visual tool; someone using a screen reader will find little utility in SPOT.

Moved to https://github.com/NLeSC/spot-tutorial/issues/7


Spring RSocket route support

Spring's RSocketRequester has route support, any plan to add function name as route name to call different function?
        String text = rsocketRequester.route("uppercase").data("\"hello\"").retrieveMono(String.class).block();

No route support from RSocketListenerFunction.java
	private static Message<byte[]> deserealizePayload(Payload payload) {
		ByteBuffer buffer = payload.getData();
		byte[] rawData = new byte[buffer.remaining()];
		buffer.get(rawData);
		if (payload.hasMetadata()) {
			String metadata = payload.getMetadataUtf8(); // TODO see what to do with it
		}
		MessageBuilder builder = MessageBuilder.withPayload(rawData);
		Message<byte[]> inputMessage = builder.build();
		return inputMessage;
	}

Sure, we're definitely have plans to expend it

Sure, we're definitely have plans to expend it

Great.  Because some developers use spring-boot-starter-rsocket already, and it's some important to be compatible with Spring RSocket.

Fixed via: https://github.com/spring-cloud/spring-cloud-function/commit/b681fb96d6c12b231a7620fa439dfbf558ff6e02


Build |ServiceResponseSchema| based on |Task|.

For #19, ServiceResponseSchema is also to be generated through Task. It allows developers to use the library for multiple endpoints per Task/Config such as:
in:
    type: example_rest_service
    endpoint_type: users  # Accessing to api.example.com/users

in:
    type: some_rest_service
    endpoint_type: items  # Accessing to api.example.com/items which has a different JSON format

@muga Can you PTAL?

LGTM 👍  (sorry for the delay)

Thanks, and no problems. I pushed the PR last week as WIP, and asked for reviewed just now. :)


Please add documentation what happens if inner activity failes

Please add some documentation to the page to what happens if an inner Until activity fails.
In contrast to a regular programming language it looks like the Until activity just continues if an inner activity fails.
Would be good to know whats really expected.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 73ff4df3-ae31-335a-bf60-b97dbe98fa58
Version Independent ID: 1c769558-db53-2e3d-f3b7-cdb23c2689d8
Content: Until activity - Azure Data Factory & Azure Synapse
Content Source: articles/data-factory/control-flow-until-activity.md
Service: data-factory
Sub-service: orchestration
GitHub Login: @chez-charlie
Microsoft Alias: chez

Thanks for the feedback! We have assigned the issue to the content author to further review this and update the document as appropriate.

If an inner activity fails, the Until activity does not stop. This has added to the article. Thanks for mentioning it. #please-close

Documentation is still missing information about Until loop status if one of the inner activities fails. Is it one of the following

failed as soon as any of the inner activities fails
failed if last execution is on failed state
will never fail?


Bugtest SUMO Crashing on Turns

This one seems to occur in just the second episode of loop. Replicate with just a call to supervisord and Eclipse SUMO sumo Version 1.8.0.

@Adaickalavan I found out one of the reasons why we could not reproduce the sumo crash on docker.
For some reason Docker is installing a different version of smarts in the image.

I have put up an image that should be able to reproduce the problem https://hub.docker.com/layers/huaweinoah/smarts/bugtest_0.4.13-sumo_1_8_0/images/sha256-51025124ec25309e923893c59c569939d788983fd76d7e5b3bac116d9c3dddcb?context=repo .

I ran the given commands on the docker image.
Test outcomes are as follows. Each test was started afresh by restarting the docker and re-running all commands.

Test #
Outcome

1
Tracii connection error in 3rd episode

2
Finished all 10 episodes without any errors

3
Finished all 10 episodes without any errors

4
Finished all 10 episodes without any errors

Perhaps, the docker image should be tested multiple number of times by more people @iman512003 @JingfeiPeng.

Going to try using #612 to get this to become fully reproducible.

#619 is looking at this issue more in depth.


Add short url manager env vars

Part of https://trello.com/c/BrKRdn4f/495-rebuild-gov-uk-app-deployment-pipeline
Adds more env vars for short-url-manager to help move it to govuk-app-deployment
Depends on https://github.gds/gds/deployment/pull/1154

continuous-integration/jenkins/pr-merge has a known problem


Gradle files use outdated functionality

> Configure project :@terrylinla/react-native-sketch-canvas
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html
WARNING: The specified Android SDK Build Tools version (25.0.0) is ignored, as it is below the minimum supported version (27.0.3) for Android Gradle Plugin 3.1.2.
Android SDK Build Tools 27.0.3 will be used.
To suppress this warning, remove "buildToolsVersion '25.0.0'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

I'll replace compile with implementation in next release! Thanks!


Error: Building package opengl:x86-windows failed with: BUILD_FAILED

Hello!
I do have the same problem as  #5866 and #5495
CMake Error at ports/opengl/portfile.cmake:20 (message):
          Cannot find Windows 10.0.18362.0 SDK.     File does not exist:
          C:\Program Files (x86)\Windows Kits\10\Lib\10.0.18362.0\um\x86\OpenGL32.Lib
          Call Stack (most recent call first):          scripts/ports.cmake:71 (include)

my windows kits are installed here though:
D:\Windows Kits\10\Lib\10.0.18362.0\um\x86
I know it's closed, but I'm just asking for some fix for it.
Reason for this behavior:
the port-cmake of opengl makes an assumptions on specific paths:
if (WINDOWS_SDK MATCHES "10.")
    set(LIBGLFILEPATH  "${PROGRAM_FILES_32_BIT}\\Windows Kits\\10\\Lib\\${WINDOWS_SDK}\\um\\${TRIPLET_SYSTEM_ARCH}\\OpenGL32.Lib")
    set(LIBGLUFILEPATH "${PROGRAM_FILES_32_BIT}\\Windows Kits\\10\\Lib\\${WINDOWS_SDK}\\um\\${TRIPLET_SYSTEM_ARCH}\\GlU32.Lib")
    set(HEADERSPATH    "${PROGRAM_FILES_32_BIT}\\Windows Kits\\10\\Include\\${WINDOWS_SDK}\\um")

Is it good too ask the ${PROGRAM_FILES_32_BIT} variable?

So what should I do now?
Installing Visual Studio again?
Or can I give vcpkg some hint for searching at some other location for those libs?
the last post suggested reading from the registry. Is that viable?
HKLM\SOFTWARE\Wow6432Node\Microsoft\Windows Kits\Installed Roots
KitsRoot10="PATH_TO_WINDOWS_KITS"

Duplicated to https://github.com/microsoft/vcpkg/issues/5495


feat(debug): Use a script loader in the debug index.

This prevents exceeding Chrome's 25MB outstanding request limit when loading the debug index.

I also updated the lint pattern to include test files.

:tada: This PR is included in version 2.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix(plugin): add highlight for context-start to indent-blankline

Description

'nocombine' is intentionally omitted; e.g. to preserve italics

Screenshots
before:

after:

What's the plugin that italicize the words in the first picture? Is that the default behavior of context start?

What's the plugin that italicize the words in the first picture? Is that the default behavior of context start?

It's treesitter.
enabled:

disabled:

LGTM. Thanks!


Futhark doesn't understand C defines that define type aliases.

For example:
#define LRESULT long

Gets turned into something like:
when not declared(Lresult):
  when long is typedesc:
    type
      Lresult* = long        ## Generated based on /home/dian/Projects/nsciter/sciter-js-sdk/include/sciter-x-types.h:71:11
  else:
    const
      Lresult* = long        ## Generated based on /home/dian/Projects/nsciter/sciter-js-sdk/include/sciter-x-types.h:71:11
# somewhere else in the file
when not declared(long):
  type
    long* = distinct object

The problem here is actually that the right hand side should get checked if it is a C-type and turned into a c prefixed type (in this case clong).


Add Missing Test Cases

Missing test cases in url, views and models should be added.

Test cases are merged into main.


[#5629] Ensure direct ByteBuffer are wrapped in as direct ByteBuf.

Motivation:
We need to check if a ByteBuffer is direct via isDirect() to detect if its direct as hasArray() may also return true for a direct ByteBuffer.
See also:
https://docs.oracle.com/javase/8/docs/api/java/nio/ByteBuffer.html#allocateDirect-int-
Modifications:
Add isDirect() check.
Result:
Correct wrap a direct ByteBuffer in all cases.

surprising that this is is thing ... but lgtm

Cherry-picked into 4.1 (76a3ea6) and 4.0 (df5cb48e08122c861e71a1bc6da9e554250f9633)


some docs and ops stuff: may 10th

CodeQL to run only via cron, no longer on push
added waste to gallery
updated Distribution Creation file for mixture([dist1, dist2])
changed title to Squiggle and added a subtitle Early access. If we don't like it we should at least change it to prealpha from alpha.
enforced the order that pages go in in documentation sidebars.
replaced ; and && in package.json scripts, which reveals that the yarn coverage:rescript:ci job had been failing silently this entire time! So I fixed that

I'd like to

remove /blog route.
rethink tagline "Estimation language for forecasters" -- just for forecasters? how about for forecasters and analysts?

Codecov Report

Merging #507 (216ede4) into develop (a2a4756) will increase coverage by 13.73%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           develop     #507       +/-   ##
============================================
+ Coverage    43.27%   57.00%   +13.73%
============================================
  Files           23       45       +22
  Lines         2066     2754      +688
============================================
+ Hits           894     1570      +676
- Misses        1172     1184       +12

Impacted Files
Coverage Δ

...Interface/ReducerInterface_GenericDistribution.res
53.37% <0.00%> (ø)

...educer/Reducer_Expression/Reducer_Expression_T.res
64.28% <0.00%> (ø)

...cer/Reducer_MathJs/Reducer_MathJs_ToExpression.res
98.55% <0.00%> (ø)

...ucer/Reducer_Dispatch/Reducer_Dispatch_BuiltIn.res
98.46% <0.00%> (ø)

...ang/__tests__/Reducer/Reducer_TestMacroHelpers.res
61.11% <0.00%> (ø)

...ges/squiggle-lang/src/rescript/Reducer/Reducer.res
0.00% <0.00%> (ø)

...rc/rescript/Reducer/Reducer_Js/Reducer_Js_Gate.res
100.00% <0.00%> (ø)

...e-lang/src/rescript/Reducer/Reducer_ErrorValue.res
70.00% <0.00%> (ø)

.../Reducer/Reducer_Expression/Reducer_Expression.res
82.85% <0.00%> (ø)

...Reducer_Expression/Reducer_Expression_Bindings.res
88.88% <0.00%> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a4756...216ede4. Read the comment docs.


./dist/index.js does not exist

When working with eslint-plugin-import I noticed that my forgo import didn't seem to want to resolve. When inspecting why, it seems that the main field in package.json points to ./dist/index.js which does not exist when you download forgo via npm i forgo.

Is it possible to update the main field to ./dist/forgo.min.js? I'm not entirely sure if this breaks non-minified builds, however.

Yeah, I don't think it'll be a problem to do that.
It sounds like we could probably drop the main field entirely since we have the exports field. I'll set up a basic repro with eslint-plugin-import and see if that works.

This was released in v3.2.1.


Add styling

-Style recipe list and public recipe to look like wireframe

Hi @Rudy-Menekam ,
✔   Status: APPROVED 🏆 🎉 🎊
You have done a great job on this project, keep it up 👍 🥇. Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
congratulations!  🎉💯🌟
Top highlight 🎯

The Pull Request is following the Git Flow ✅
The PR title and description are professional and descriptive ✅
Forms working as expected ✅

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏


Jokes

Is your feature request related to a problem? Please describe.
no
Describe the solution you'd like
Have the program simply pull jokes from a text file. I could also have it display the response after a x second delay. The command will run using !joke

I would like to have the opportunity to work on it.

I don't think this is a necessary feature to implement at this time. Maybe we can revisit this in the future.