ColorPresetsDesigner: Some QOL improvements

This PR improves the ColorPresetsDesigner:

identifiers for template are sorted
added color is selected
after deleting the first color is selected
adjust designer view
scrollbars actually work

The following is working

[x] identifiers for template are sorted
[x] added color is selected
[x] after deleting the first color is selected
[ ] adjust designer view (i do not know what i need to see here)
[x] scrollbars actually work

If it is possible, can you sort the list when i add a new color to the template list
Added a color, that starts with a F and is on top of the list as that is "default" by the program
When i add a other new color, i like to have the F one i added before be sorted in the list where it belongs, while the new added color is on top of the list.
my idea is : when push the + on the template list sort first then add the new template one

The list uses the auto sort of CollectionView, so it should already be sorted.
But I will check what the issue is and see if I can fix it.

The combobox is filled with all identifiers that were found in the building presets file.
So the different capitalization has to be in the presets file.
Do I get your request correct that you only want a single entry (e.g. for Bakery and bakery) and all entries should start with an uppercase letter?
Are you sure that the app is fine with that?
I'm fine with it if the app is fine with it 😃

Do I get your request correct that you only want a single entry (e.g. for Bakery and bakery) and all entries should start with an uppercase letter?

No, i mean can  you check all identifiers in lowercase (string.ToLower()) so that anno 2070 identifiers (that is in lowercase's all the time) that are the same are anno 1404 identifiers (that starts with a capital letter) are disappear from the combo-box as well?
(this was option 1)
If this is not possible i am willing to let all identifiers on Anno 2070 starting with a capital letter (as that is not the case in the preset-parser at the moment an read plain in what is in the assets, this we never changed from when we got the project)

As far as I can see everytime the Identifier is checked/compared StringComparison.OrdinalIgnoreCase is used.
Therefor I will convert all identifiers found in the building presets to a first uppercase letter and remove duplicates.


PayPal
<EMAIL_ADDRESS>

Close
Verify your identity by scanning the QR code with your phone
It's easier to complete this step with your phone.
Having trouble scanning? Follow these steps

PayPal.Me.  HTML Living Standard — Last Updated 23 August 2024  One-Page Version html.spec.whatwg.org   Multipage Version /multipage   Version for Web Devs /dev   PDF Version /print.pdf   Translations 日本語 • 简体中文   FAQ on GitHub   Chat on Matrix   Contribute on GitHub whatwg/html repository   Commits on GitHub   Snapshot as of this commit   Twitter Updates @htmlstandard   Open Issues filed on GitHub   Open an Issue whatwg.org/newbug   Tests web-platform-tests html/   Issues for Tests ongoing work Table of contents 1 Introduction 2 Common infrastructure 3 Semantics, structure, and APIs of HTML documents 4 The elements of HTML 5 Microdata 6 User interaction 7 Loading web pages 8 Web application APIs 9 Communication 10 Web workers 11 Worklets 12 Web storage 13 The HTML syntax 14 The XML syntax 15 Rendering 16 Obsolete features 17 IANA considerations Index References Acknowledgments Intellectual property rights Full table of contents 1 Introduction 1.1 Where does this specification fit? 1.2 Is this HTML5? 1.3 Background 1.4 Audience 1.5 Scope 1.6 History 1.7 Design notes 1.7.1 Serializability of script execution 1.7.2 Compliance with other specifications 1.7.3 Extensibility 1.8 HTML vs XML syntax 1.9 Structure of this specification 1.9.1 How to read this specification 1.9.2 Typographic conventions 1.10 A quick introduction to HTML 1.10.1 Writing secure applications with HTML 1.10.2 Common pitfalls to avoid when using the scripting APIs 1.10.3 How to catch mistakes when writing HTML: validators and conformance checkers 1.11 Conformance requirements for authors 1.11.1 Presentational markup 1.11.2 Syntax errors 1.11.3 Restrictions on content models and on attribute values 1.12 Suggested reading 2 Common infrastructure 2.1 Terminology 2.1.1 Parallelism 2.1.2 Resources 2.1.3 XML compatibility 2.1.4 DOM trees 2.1.5 Scripting 2.1.6 Plugins 2.1.7 Character encodings 2.1.8 Conformance classes 2.1.9 Dependencies 2.1.10 Extensibility 2.1.11 Interactions with XPath and XSLT 2.2 Policy-controlled features 2.3 Common microsyntaxes 2.3.1 Common parser idioms 2.3.2 Boolean attributes 2.3.3 Keywords and enumerated attributes 2.3.4 Numbers <IP_ADDRESS> Signed integers <IP_ADDRESS> Non-negative integers <IP_ADDRESS> Floating-point numbers <IP_ADDRESS> Percentages and lengths <IP_ADDRESS> Nonzero percentages and lengths <IP_ADDRESS> Lists of floating-point numbers <IP_ADDRESS> Lists of dimensions 2.3.5 Dates and times <IP_ADDRESS> Months <IP_ADDRESS> Dates <IP_ADDRESS> Yearless dates <IP_ADDRESS> Times <IP_ADDRESS> Local dates and times <IP_ADDRESS> Time zones <IP_ADDRESS> Global dates and times <IP_ADDRESS> Weeks <IP_ADDRESS> Durations <IP_ADDRESS> Vaguer moments in time 2.3.6 Colors 2.3.7 Space-separated tokens 2.3.8 Comma-separated tokens 2.3.9 References 2.3.10 Media queries 2.3.11 Unique internal values 2.4 URLs 2.4.1 Terminology 2.4.2 Parsing URLs 2.4.3 Dynamic changes to base URLs 2.5 Fetching resources 2.5.1 Terminology 2.5.2 Determining the type of a resource 2.5.3 Extracting character encodings from meta elements 2.5.4 CORS settings attributes 2.5.5 Referrer policy attributes 2.5.6 Nonce attributes 2.5.7 Lazy loading attributes 2.5.8 Blocking attributes 2.5.9 Fetch priority attributes 2.6 Common DOM interfaces 2.6.1 Reflecting content attributes in IDL attributes 2.6.2 Using reflect in specifications 2.6.3 Collections <IP_ADDRESS> The HTMLAllCollection interface <IP_ADDRESS>.1 [[Call]] ( thisArgument, argumentsList ) <IP_ADDRESS> The HTMLFormControlsCollection interface <IP_ADDRESS> The HTMLOptionsCollection interface 2.6.4 The DOMStringList interface 2.7 Safe passing of structured data 2.7.1 Serializable objects 2.7.2 Transferable objects 2.7.3 StructuredSerializeInternal ( value, forStorage [ , memory ] ) 2.7.4 StructuredSerialize ( value ) 2.7.5 StructuredSerializeForStorage ( value ) 2.7.6 StructuredDeserialize ( serialized, targetRealm [ , memory ] ) 2.7.7 StructuredSerializeWithTransfer ( value, transferList ) 2.7.8 StructuredDeserializeWithTransfer ( serializeWithTransferResult, targetRealm ) 2.7.9 Performing serialization and transferring from other specifications 2.7.10 Structured cloning API 3 Semantics, structure, and APIs of HTML documents 3.1 Documents 3.1.1 The Document object 3.1.2 The DocumentOrShadowRoot interface 3.1.3 Resource metadata management 3.1.4 Reporting document loading status 3.1.5 Render-blocking mechanism 3.1.6 DOM tree accessors 3.2 Elements 3.2.1 Semantics 3.2.2 Elements in the DOM 3.2.3 HTML element constructors 3.2.4 Element definitions <IP_ADDRESS> Attributes 3.2.5 Content models <IP_ADDRESS> The "nothing" content model <IP_ADDRESS> Kinds of content <IP_ADDRESS>.1 Metadata content <IP_ADDRESS>.2 Flow content <IP_ADDRESS>.3 Sectioning content <IP_ADDRESS>.4 Heading content <IP_ADDRESS>.5 Phrasing content <IP_ADDRESS>.6 Embedded content <IP_ADDRESS>.7 Interactive content <IP_ADDRESS>.8 Palpable content <IP_ADDRESS>.9 Script-supporting elements <IP_ADDRESS> Transparent content models <IP_ADDRESS> Paragraphs 3.2.6 Global attributes <IP_ADDRESS> The title attribute <IP_ADDRESS> The lang and xml:lang attributes <IP_ADDRESS> The translate attribute <IP_ADDRESS> The di


Postgres IAM authentication is flaky due to OAuth2 token inconsistency

Bug Description
See discussion on related Java connector issue https://github.com/GoogleCloudPlatform/cloud-sql-jdbc-socket-factory/issues/565

Fixed (temporarily) by https://github.com/GoogleCloudPlatform/cloudsql-proxy/pull/851.


File was corrupted by async_std::fs::File

Hello! To reproduce this bug you may use this project:
https://github.com/svmk/test-async-std-bug
Download it and exeucte file run-test.sh
Steps to reproduce:

Download remote url https://www.sec.gov/Archives/edgar/full-index/1994/QTR1/company.idx by using reqwest library
Save it to file while downloading by using async_std::fs::File
Download remote url https://www.sec.gov/Archives/edgar/full-index/1994/QTR1/company.idx using wget
Compare files. It's differ!

Expected result:
Files must be equal.
Code to reproduce this bug:
use futures::stream::StreamExt;
use async_std::fs::File;
use futures::AsyncWriteExt;
use std::{fs::File as SyncFile, io::Write};

#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
    let url = "https://www.sec.gov/Archives/edgar/full-index/1994/QTR1/company.idx";
    let client = reqwest::Client::new();
    let response = client.get(url).send().await?;
    let mut response_body = response.bytes_stream();
    let mut async_file = File::create("company.async.idx").await?;
    let mut sync_file = SyncFile::create("company.sync.idx")?;
    while let Some(buffer) = response_body.next().await {
        let buffer = buffer?;
        let _ = async_file.write(&buffer).await?;
        async_file.sync_all().await?;
        sync_file.write(&buffer)?;
    }
    return Ok(());
}

I believe the issue here is the same as https://github.com/async-rs/async-std/issues/939#issuecomment-762092739 — you're doing async_file.write(&buffer).await (Write::write) instead of async_file.write_all(&buffer)(Write::write_all — write doesn't necessarily write all of the contents. If you log the return value from write and compare it to the buffer.len(), there will be occasional discrepancies


Implement RadioCommunicationsFamily PDUs

What is the problem this feature would solve?
The RadioCommunications family of PDUs have not been implemented yet. To be fully compliant with the IEEE 1278.1 standard, these must be implemented in accordance with the standard's definitions.
What is the feature you are proposing to solve the problem?
Consult the IEEE 1278.1 standard to map the definitions for the RadioCommunications family of PDUs into working, tested Rust code.
What alternatives have you considered?
No response

Hey, I've been doing quite a bit of work with radio comms and DIS recently. Will be more than happy to pick this up if you're not already working on it?

@luke-else I have some minimal progress made on this issue (see branch feature/7-implement-radiocommunicationsfamily-pdus), but feel free to open a PR and contribute as you see fit. If you do choose to contribute, just ping me when your PR is ready for review, and I'll take a look at it. Thanks!

@crhowell3 Nice! Yeah I'll get the ball rolling on that! Could probably have it done by late next week. I'll keep you posted :)


Test build #25713 has started for   PR 4092 at commit 10cb496.

This patch merges cleanly.

Test build #25713 has finished for   PR 4092 at commit 10cb496.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25713/
Test FAILed.

Test build #25720 has started for   PR 4092 at commit 27b08c9.

This patch merges cleanly.

Test build #25720 has finished for   PR 4092 at commit 27b08c9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25720/
Test PASSed.

we also need update the sql-doc

Yup. I was thinking I'd work on those towards the end. But if you are interested in submitting patches to fix sql doc as we go along, please do so. Thanks.


[PFObject pin] takes longer time with more objects saved in LocalDataStore

It seems that [PFObject pin] takes longer time with more objects saved in LocalDataStore
When LocalDataStore is empty, it takes only 50ms to pin 10 ParseObjects.
When there are 500 objects in LocalDataStore, it takes 750ms to pin.
When there are 1,000 objects in LocalDataStore, it takes 1480ms to pin.
I've attached a simple repro project file using Starter Project.
https://dl.dropboxusercontent.com/u/309225/LocalDataStorePerformance.zip
By running it, you can see that pin is repeated, and its process time gets longer and longer.
Is there any way to make this faster?
Thanks for your advice.
Environment:
Parse SDK 1.8.1
iPhone6

Duplicate of #32.

Oh I've never noticed LDS means LocalDataStore.

i am getting same issue and i am totally frustrated after choosing parse. I want to go for paid plan but this issue is the hurdle to my project. Did you get any solution?

We are tracking this on #32, and currently, we have a solution for one aspect of LDS performance for release in 1.9.0.

When 1.9.0 will be released, my project is stuck for that?
I would recommend your support on this.

It's coming soon, no specific time set, but you can get a rough estimate from looking at the periods of previous releases.

Latest iOS sdk is 1.8.5 and upcoming will be 1.9.0 or 1.8.6?
And 1.9.0 will solve this issue of slow pin?

@PSIPhone, 1.9.0 will improve the performance with pinning and querying objects in Local Datastore.
Solve this issue - up to extent. As I and Richard previously mentioned - we are working on improving overall experience and performance with Local Datastore and tracking progress in #32.
Next version is going to be 1.9.0, according to the milestones in this repository.

Ok waiting and hope this will fix if i have thousands of rows in a table.


More Species page

[ ] Disable editing for volunteers
[ ] Mobile

/cib more species

Branch 108-more-species created!


Added SinusBot

Microsoft Reviewers: Open in CodeFlow

I could not find the uninstall.  Did I miss it?

I could not find the uninstall. Did I miss it?

The software has no integrated uninstaller by now. It can be uninstalled just by removing it's data folder C:\SinusBot


Fuzzy Search: Use web workers to execute fuzzy search code

Certain larger queries cause a visible delay between input completion and the component re-rendering to reflect the input text and the recommendations. For instance, the query ics causes my browser (Firefox 99.0.1) on my laptop to become unresponsive for ~200ms. This is mitigated to an extent by caching, so subsequent queries don't incur the same performance cost, but this will always happen to the initial query.
A solution would be to use web workers to run search(), so the main thread isn't blocked and the app doesn't freeze completely for the user. However, this is not feasible with the current version of webpack we ship, and so will have to wait for #279.

Can't reproduce. It's as fast I can perceive when I tried it on my Chrome and Firefox installations.


Add actual class tests to tests.py

Do you mind adding doc strings to this before I merge?

I can do that. hang on.


(GH-1724) Fix bug in remote transport from nil results

Closes #1724, #1718
Seems that sometimes Results are created without actions, causing exceptions to be thrown when referenced from the Human outputter.
TODO

Should i put a guard in the human outputter to check for nil actions? https://github.com/puppetlabs/bolt/blob/master/lib/bolt/outputter/human.rb#L101
Need to add tests for the remote transport. There doesn't seem to be any. I'm thinking the easiest course of action would be to write some unit tests that mock out the executor.  Does this sound right?
Integration tests i could probably write based off of the local transport. Does this sound right?

Broadly speaking, we need to establish concretely whether all Result objects should have an action or not. If so, then Result should do something to ensure one is present (either make it a required field or have a default). If not, then the human outputter should be updated to accommodate a Result without an action.

CLA signed by all contributors.

@nicklewis made the requested updates :)


fix: Update dlmodels.sh to not exit after every successful download.

Pull request checklist

[x] The PR has a proper title. Use Semantic Commit Messages. (No more branch-name title please)

[x] Make sure this is ready to be merged into the relevant branch. Please don't create a PR and let it hang for a few days.

 These submissions will be prioritized for review:
Introduce improvements in program execution speed;
Introduce improvements in synthesis quality;
Fix existing bugs reported by user feedback (or you met);
Introduce more convenient user operations.

PR type

Bug fix

Description
Why is this here? A mistake?
Current behavior causes script to exit after every successful download, forcing you to rerun the script 19 times.
This pull request will make all the downloads necessary by running the script once, by simply removing "&& exit 1" which was probably accidentally placed there.

closing in favor of #2175, I didn't notice it was there


Allow Graviton-specific APIs and services to be exposed to applications

For example, it'd be good to have APIs for:

Controlling online updates
Scheduling background tasks using Graviton Scheduler
Reliable large file transfer over HTTP, with a callback when the transfer is done, even if the app isn't running.
Shared HTTP cache that doesn't count towards app quota, when sandboxing is implementing.

For (3), what I'm thinking about here is using HTTP Range requests to keep trying to download files even when connectivity is interrupted and IP addresses change e.g. roaming across different wifi hotspots, wired connections, mobile hotspots etc. Likewise, pausing the transfer if disk space is low until some disk space is freed, and other annoying details that are required to successfully retrieve large assets.

There's now a Graviton interface and classloader setup that lets us expose APIs to apps. The first and currently only API is a way to opt in to using the top level stage for JFX apps.


Tree component doesn't work with angular 12?

While updating my app from 10 to 12, my tree component isn't working anymore. The new library @circlon/angular-tree-component seems isn't working with angular 12. I do not get any error but my tree component isn't displayed.
I have followed the doc:
npm install @circlon/angular-tree-component

Import TreeModule:

import { TreeModule } from '@circlon/angular-tree-component';

@NgModule({
  declarations: [AppComponent],
  imports: [TreeModule],
  bootstrap: [AppComponent]
})
export class AppModule {}
Add css to styles.scss or include in angular.json:

@import<EMAIL_ADDRESS>I have followed every step as the doc said but still, I can't make it work. My app looks something like this: app-example. By this, I refer to the code as I am using this library "@circlon/angular-tree-component": "^11.0.4", with angular 12. But the code is before updating to angular 12. Basically, only the package has changed. It seems that whatever is inside  tag is hidden. And also I tried to remove this: @import<EMAIL_ADDRESS>and there is no error. Does anybody have any idea, or can someone help me replace this component? I am asking for help cause I am new at angular and I do not understand many things. But I am happy to learn new things every day. Thank you all for every idea or help.
stackblitz example: appp

[@tobiasengelhardt]

Same issue.
Do you found any solution?

Yes, i change the way we upload the libraries:
angular.json
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
diff --git angular.json
--- a/angular.json
+++ b/angular.json
@@ -15,6 +15,7 @@
"index": "src/index.html",
"main": "src/main.ts",
"tsConfig": "src/tsconfig.json",

       "polyfills": "src/polyfills.ts",
       "assets": [
         "src/assets"
       ],

@@ -390,4 +391,4 @@
"prefix": "app"
}
}
-}
\ No newline at end of file
+}
Index: /polyfills.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
diff --/src/polyfills.ts
--- a/src/polyfills.ts
+++ b/polyfills.ts
@@ -17,5 +17,6 @@
import 'core-js/es7/reflect';
import 'zone.js';
+import 'reflect-metadata';
-import 'core-js/client/shim.min';
\ No newline at end of file
+import 'core-js/client/shim.min';
Index: index.html
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
diff --git /index.html
--- a/index.html
+++ b/index.html
@@ -24,8 +24,6 @@

Hi,
I also encountered this problem and did not understand the way to solve it,
If you could explain what exactly you did that would work for you.
I would be very happy.

Yes, i change the way we upload the libraries. basically i moved the polyfills to angular angular.json:
"polyfills": "src/polyfills.ts",
At polyfills.ts file i added:
+import 'reflect-metadata';
index.html file
I removed:


Is there a paper?

thanks

Edge-Enhanced_GAN_for_Remote_Sensing_Image_Superresolution.pdf
the paper was produced by IEEE, but the results was not very satisfying, so i switched to the EESRGAN so changed the ultra dense blocks with RRDB for more robust feature extraction.


Fix e2e compression tests for epoll1 and h2_http_proxy

Partially fixes #12394

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

Corrupt JSON data (indicates timeout or crash):
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__2M_2_0.counters.old: 1

[microbenchmarks] Performance differences noted:
Benchmark                                             nows_per_iteration
----------------------------------------------------  --------------------
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/0/2M  -4%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Known Issues : #12605, #12785 and unrelated windows tests


[feat] Add metadata to environment definitions in the configuration

This is the complete analogous to the extras in the definition of the partitions. Users can now define an extras attribute in their environment configuration, which allows them to attach arbitrary properties to environments. These are accessible inside a test through the extras attribute of the current_environ.
Fixes #1973.
Fixes #2230.

@jenkins-cscs daint

Codecov Report

Merging #2265 (a1c0e48) into master (47fc045) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2265   +/-   ##
=======================================
  Coverage   86.12%   86.13%
=======================================
  Files          56       56
  Lines       10198    10202    +4
=======================================
+ Hits         8783     8787    +4
  Misses       1415     1415

Impacted Files
Coverage Δ

reframe/core/systems.py
89.47% <ø> (ø)

reframe/core/environments.py
97.19% <100.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47fc045...a1c0e48. Read the comment docs.


General: Show applications without integration in project

Brief description
It is not possible to add new applications without implementation and add them to project to be able launch them from launcher (or ftrack).
Changes

removed unused shell from applications
all applications can be added to project's applications even if does not have host implementation
it is possible to define applications that have custom launch method so they are not visible on task automatically
added new Additional group into system settings applications. Additional applications does not support host selection

Testing notes:

Create new application group in applications with schemas
Store it's defaults
From that moment it is possible to add application to anatomy applications (add it to one project)
You should see the application in launcher tool and in ftrack

Resolves https://github.com/pypeclub/OpenPype/issues/2653
Screenshot

Task linked: OP-2590 Applications without integration

Adding a category within application called Additional with no host implementation into the default applications, would let studios quickly add additional application without host implementation as it's variant

Added. It is not 100% "safe" (you can add maya) but I would not care about it until someone hit the issue...

I've tried adding affinity and getting following

Fixed


[#5713] Dialogs.Declarative.Tests hang and give no message.

Fixes # 5713
Description
This PR fixes an issue when BotFramework-CLI is not installed in the Operative System (OS), the tests hang while installing the library. Instead, when it isn't installed, the tests will fail, warning the user to install the library.
Specific Changes

Added BotFrameworkCLIPrerequisite method in Microsoft.Bot.Builder.Dialogs.Declarative.Tests/SchemaTestsFixture.cs.

Will execute the bf command to corroborate that's installed.
If the bf command execution failed, it will throw an error warning to install the library.

Testing
The following images show when there is no bf-cli install, and when there is.

Promoted https://github.com/microsoft/botbuilder-dotnet/pull/5993


Feature: Log print() calls as Breadcrumbs

:scroll: Description
We can now record calls to print() as Breadcrumbs.

One can easily run into recursion. I added a tests so that it should not happen. See comments.
Should this be an option in SentryOptions? -> Yes

Example event: https://sentry.io/share/issue/9aba382a0ae649baafaea54522729709/
:bulb: Motivation and Context
Closes https://github.com/getsentry/sentry-dart/issues/423
:green_heart: How did you test it?
I've written new tests.
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

Codecov Report

Merging #439 (7d389d9) into main (056cf7b) will increase coverage by 3.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   89.88%   93.86%   +3.97%
==========================================
  Files          54        5      -49
  Lines        1691      163    -1528
==========================================
- Hits         1520      153    -1367
+ Misses        171       10     -161

Impacted Files
Coverage Δ

flutter/lib/src/sentry_flutter_options.dart
78.12% <0.00%> (-1.37%)
:arrow_down:

dart/lib/src/platform/_io_platform.dart

dart/lib/src/hub.dart

dart/lib/src/protocol/sentry_package.dart

dart/lib/src/utils.dart

dart/lib/src/protocol/sentry_id.dart

dart/lib/src/sentry_stack_trace_factory.dart

dart/lib/src/protocol/contexts.dart

dart/lib/src/diagnostic_logger.dart

dart/lib/src/protocol/sentry_device.dart

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 056cf7b...7d389d9. Read the comment docs.


Add optimize call with help options

Optimizing and doing delta roll-ups can help performance when significant changes are made. Add an option for it.

This is implemented now.


Android N does not take picture

I am using the nexus 6p device with android N 7.1.1, but when I take am image it does not call the callback on onPictureTaken, could this be a bug or this library only supports 24 and below?

The library does support Nougat. It is working fine on my Nexus 5X and Pixel. Please attach a bug report so I can investigate.

@poldz123
It is working fine. Make sure you are using latest library for same.
Sincerely,
Shreyash


update hyundai palisade steer ratio

short-term improvement until https://github.com/commaai/openpilot/issues/19672 is resolved

Where did you get 15.6? 13.75 seems very low.

Where did you get 15.6? 13.75 seems very low.

There is a link in https://github.com/commaai/openpilot/issues/19672


Improve offset calculations in example in README

getBoundingClientRect can directly determine the actual height of an element and
is supported in all modern browsers.
Also the fixed header element needs to be looked up only once at initialization
(if the element somehow must change, which should be quite a rare use/design case,
this can be adjusted in the example code).

Nice update!


Use credentials defined in Root project

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

The promotion build: https://builds.gradle.org/viewLog.html?buildId=45447321&tab=buildResultsDiv&buildTypeId=Gradle_Master_Promotion_PublishBranchSnapshotFromQuickFeedback

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


DataAnnotations for validation

New Feature
Introduce data annotations for validating the incoming documents. This would be useful for automatic validation of ProseMirror documents when receiving them in ASP.NET requests.
Some suggestions for validations:

Document text length
Maximum list depth nesting

Released as part of 1.0.3


Fix  readline-promise import

This fixes the issue with #24

Hi @stv8!
Thank you for contributing. I was a little unsure that this fix would work, so I gave it a shot and it's breaking for me. I looked at NPM and I think you're seeing readline-promise from this package: https://www.npmjs.com/package/readline-promise
That package isn't a part of this script, so it can't be used. Only native Node modules can be used. If I'm mistaken and this is native and I've misunderstood, please let me know!

Ah yeah I see. I didn't realize there was a new native node module named similarly. Thanks for the update.


climetlab should not require branca==0.3.1

https://github.com/python-visualization/branca/issues/81 is now closed
So climetlab should probably not require anymore branca==0.3.1

Yes, I guess the setup.py could then be updated to branca<=0.3.1,branca>=...
Do you want to submit a PR?

It's difficult for me to submit a PR because :

I don't know what is exactly climetlab problem with branca>0.3.1, I only know that the branca issue is referenced in setup.py
the branca issue is closed not because of a change in branca, but because of a new folium support in streamlit with streamlit-folium library (see https://github.com/python-visualization/branca/issues/81#issuecomment-1304563574)
So I don't know if the climetlab problem would be resolved by changing branca dependency, or changing folium dependency, or adding streamlit-folium dependency...

If you give me the scenario to reproduce the problem, I could make some tests and maybe then submit a PR.
My problem is that a would like to use climetlab and other packages requiring branca>0.3.1 in the same python program...

This was introduced to make sure this notebook works, for interactive maps: https://climetlab.readthedocs.io/en/latest/examples/17-interactive-maps.html
This notebook is expected to work when we install pip install climetlab[interactive]
At this time we had to install the dependencies  "skinnywms" and "folium>=0.12.1" (see in the setup.py, the extra "interactive").
Since it causes weird dependency problems with branca versions and the most robust solution were to set branca>0.3.1.
I suggest using this notebook as a test (there are no test on this interactive map, this is a very experimental feature). If it still works, as long as the other tests, we are good to go.

Sorry, I don't have the time nor the competencies (not a folium user) to work on this...
I just think it's not a good thing to have a 5 years old dependency in climetlab and that you should find a way to update it.
Until then, may be branca==0.3.1 could only be an extra "interactive" dependency ?

I saw you removed the exact dependency to branca 0.31 in release 0.13.5.
Thanks, this issue can be closed.


cmd/go: go version shows command not found, when I install go by go1.12.darwin-amd64.pkg or go1.11.5.darwin-amd64.pkg

go version:
go1.11.5.darwin-amd64.pkg  or go1.12.darwin-amd64.pkg
OS:
macOS Mojave 10.14.3
I install go by go1.12.darwin-amd64.pkg or go1.11.5.darwin-amd64.pkg.
1、 I type go version in mac terminal, it shows -bash: go: command not found.
2、I type echo $PATH, there isn't  go path like /usr/local/go/bin, but the /etc/paths.d/go is found.
3、 I type cd /usr/local/go/bin and ./go version, this shows go version.
4、I set the go path export PATH=$PATH:/usr/local/go/bin  in .bash_profile and source .bash_profile, and then I exec steps ，shows -bash: go: command not found .
So, what's wrong whit me?

Did you follow the steps here (https://golang.org/doc/install#macos) exactly ?

The package should put the /usr/local/go/bin directory in your PATH environment variable. You may need to restart any open Terminal sessions for the change to take effect.

including this one ?

In fact, I don't need to add the go path to my PATH environment variable，because the pkg package had auto add it in /etc/paths.d, and OS will load it when I restart OS. But it takes something wrong here.
Steps 4, I had add it and restart terminal.

It's a new os, I just formatted hard disk and install it.
My another computer is update os from 10.14 to 10.14.3,  go version shows version info, It looks good

Sorry, I don't know what's wrong, when I takes export PATH=$PATH:/usr/local/go/bin  to the end of the .bash_profile and kill the terminal , go version shows version info, It looks good.


Deal with satellite outages

Sometimes, on a fairly regular schedule, the rapid refresh satellite data that we use to run the model in production goes offline. Usually for a 2-day period each month.
This can cause a degradation in model performance like happened on 20th June.

When the rapid refresh is down the 15-minutely data still exists, and PVNet1 used this. See here. We could try a similar solution for PVNet2, maybe in combination with training a model specifically for this circumstance

Thanks @dfulu for putting this here,

note: this happens when switching from the 5 min data, to 15 min data

Could this be solved by,

loading 15 mins data, when 5 mins is not avaialble
dont fill satellite data with zeros?

Thoughts @dfulu

@dfulu we can probably close this too


Japanese Italics

Doesn't seem to recognize italics in Japanese. I want to help, but there don't seem to be any instruction in https://github.com/tesseract-ocr/langdata.

If you want to train Tesseract, use one of these guides:
https://github.com/tesseract-ocr/tesseract/wiki/tesstrain.sh
https://github.com/tesseract-ocr/tesseract/wiki/TrainingTesseract
For further questions, please use the Tesseract users forum.

@amitdo Thanks!

Hi! I'm wondering if the tessdata for italics of Japanese fonts have finished?


Feature Request: Users should not see TLP Group if they are not in the group

When submitting a sample to Assemblyline users can select a TLP and a group. Users who are not assigned to a group should not see the group in the UI when making a submission.
Example: System has the below context
Team AR
Team AT
Team BR
Team BT

User X is Assigned Team AR, when User X tries to submit a file they are able to see AR, AT, BR, BT if the user picks any of AT, BR, BT an error shows up, because the user is not assigned that context.
To allow for an easier user experience the UI should only show Groups that that user is assigned.

The reason it is done this way is to be able to share analysis between groups.
Ex: I'm in team AR and I want to share the analysis with team BT. Therefore I should be able to select AR and BT. Yes you are right, this can lead to selecting a combinaison where it is actually invalid for you...
Maybe a compromise would be to have the UI show you in advance that this classification is invalid for you instead of waiting for the submission to be sent?

Yes a UI element showing this would be a nice way to handle this.
Not sure about one thing, I will test it out, but don't you need to be in both AR and BT groups to be able to select this combination? if that's the case removing groups you're not part of in the UI should not impact this behaviour.

I think this issue here comes down to the wording that we chose for the classification.
Levels is basically a number from 0 to inf where if you have a level you get access to all levels below
Required is a list of tokens that you must have to get access to the data (uses an AND operator)
Groups and Sub-Groups is a list of token that you must be member of at least one of to get access to the data (uses an OR operator)
So in your case, if you want to hide what you call groups from the ppl that don't have access to it. You can put your group definitions in the required section and a user would have to be part of all mentioned groups to get access and see that the group exists.
If you use the group section, a user has to be only a member of one of the selected group to get access to the data.
WARNING: Moving your groups into the required section is not a trivial thing because it will render all old data unaccessible because those part are broken down into multiple field in the DB to compute proper access control using filter queries.
I can still proceed witht the UI warning for now as I added classification checking in the UI already for the external links


MINOR:Fix illogical log in fetchOffsetAndTruncate method

In the fetchOffsetAndTruncate method of AbstractFetcherThread, when 'leaderEndOffset' is greater than or equal to 'replicaEndOffset', 'offsetToFetch' takes the maximum value of the two, so the warning log of "Reset fetch offset" should indicate the maximum offset, and Not the so-called "leaderStartOffset".

Does anyone have a review?

Hi, do you have time to help review this? @dajac @satishd

hi, is this pr ready to merge? @satishd

@hudeqi Waiting for @dajac reply on your clarification.
@dajac Please take a look at comment and send your update.

@viktorsomogyi hi, this minor pr is also about replica fetcher thread, please help to review, thanks! Seems @dajac have no time.

Hi, is there any suggestion and must do for this PR now? @dajac @satishd @divijvaidya

Also, @hudeqi please don't use force pushes because it makes it impossible to go back to previous commits which sometimes needed in reviews to get the proper context. When we merge a PR it gets squashed together into a single commit, so there is not need to force push.

@dajac do you have other comments or can I merge this?

@viktorsomogyi Nope. LGTM. Feel free to merge it. Thanks!


pull request for e2e test at 01/11/2017 10:26:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Frontend: Introduce -experimental-lazy-typecheck action

This action is currently just an alias of the -resolve-imports action. However, it's named to more clearly reflect the purpose which is to do the minimal typechecking needed in order to emit the requested outputs. This mode is intended to improve performance when emitting .swiftinterface and .tbd files.

@swift-ci please smoke test

Driver PR: https://github.com/apple/swift-driver/pull/1419


Various fixes

Disallow some actions for non-loaded packages (issue openspending/openspending#1176)
Allow to filter packages by loading status (loaded, in progress, failed) (issue openspending/openspending#1177)

Awesome!


[Bug] Skip SavedQuery node would cause dbt-core to error out on the node

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
When a node upstream of a SavedQuery node fails and lead to SavedQuery node being skipped(vs NO-OP), dbt-core will raise an error saying Exception on worker thread. 'SavedQuery' object has no attribute 'schema'.
Please see additional context section
Expected Behavior
SavedQuery node properly skipped
Steps To Reproduce

use latest main branch of dbt-core
use this jaffle shop at this branch: https://github.com/dbt-labs/jaffle-shop/tree/repro/saved-query-schema-error
run dbt build

Relevant log output
22:40:22  49 of 52 SKIP test accepted_values_customers_customer_type__new__returning ..... [SKIP]
22:40:22  50 of 52 SKIP test dbt_utils_expression_is_true_customers_lifetime_spend_pretax_lifetime_tax_paid_lifetime_spend  [SKIP]
22:40:22  51 of 52 SKIP test not_null_customers_customer_id .............................. [SKIP]
22:40:22  52 of 52 SKIP test unique_customers_customer_id ................................ [SKIP]
22:40:22
22:40:22  Finished running 6 view models, 7 table models, 3 unit tests, 6 seeds, 27 data tests, 3 saved queries in 0 hours 0 minutes and 29.53 seconds (29.53s).
22:40:22
22:40:22  Completed with 4 errors and 0 warnings:
22:40:22
22:40:22  Failure in unit_test test_supply_costs_sum_correctly (models/marts/order_items.yml)
22:40:22

actual differs from expected:

@@ ,order_id,product_id,supply_cost
→  ,1       ,1         ,4.5→4.50
+++,2       ,2         ,Decimal('8.50')
+++,2       ,2         ,Decimal('8.50')
---,2       ,2         ,Decimal('8.5')
---,2       ,2         ,Decimal('8.5')

22:40:22
22:40:22    compiled Code at target/compiled/jaffle_shop/models/marts/order_items.yml/models/marts/test_supply_costs_sum_correctly.sql
22:40:22
22:40:22    Exception on worker thread. 'SavedQuery' object has no attribute 'schema'
22:40:22
22:40:22    Exception on worker thread. 'SavedQuery' object has no attribute 'schema'
22:40:22
22:40:22    Exception on worker thread. 'SavedQuery' object has no attribute 'schema'

Environment
- OS:mac os
- Python: 3.11
- dbt: 1.8.0b3(latest main

Which database adapter are you using with dbt?
No response
Additional Context
If you set a breakpoint at on_skip function, you will find that Saved Query node do not have Schema. I don't think we ever had that attribute on SavedQuery node.

Internal thread

Check what the error message would be if on_skip when schema do not exists we just put a None.


add clusterrole & clusterrolebinding to infra

Signed-off-by: Larry Steck<EMAIL_ADDRESS>closes cloudpakbringup/deployment-guides#102

LGTM


Make Tangent Gamejam ready

Must have for the gamejam, not for the launch. But the gamejam "starts" the same day as the launch.
Must haves:

Mod manager button
Easier way to find code / id to copy and paste https://github.com/AmbientRun/TutorialProject/blob/chapter-8/my_mod/ambient.toml - maybe in the description of the game (at least for the duration of the gamejam)

Nice to haves:

The mods for tangent in the same page as Tangent the game, so users can find their mod already next to the game on the website.
The code for each mod we've made should be accessible either directly like the schema is, or it should at least be a link to it on GitHub
Improved game UI. Like findig the classes / vehicles "q" as a button.

@ten3roberts if you get time to solve the embed after the launch then that would be supernice, because now gamejam participants won't be able to submit their games / mods to itch.

@ten3roberts if you get time to solve the embed after the launch then that would be supernice, because now gamejam participants won't be able to submit their games / mods to itch.

@FredrikNoren just confirming, is this done?

@ten3roberts Well.. what I did was I just copied the ambient-web-embed (formerly instance-manager.js) to google storage. So sure, it works right now, but we should pull it out to a repo and handle it a bit more proper long term.


Generate and register command

PR Description
Update validator generate command so that it only generates validator keys and doesn't send eth1 deposit transactions. The existing functionality for both is in a new subcommand generate-and-register.

Removed registering the validator as part of the validator generate command
Added a new subcommand validator generate-and-register which has the existing functionality of both creating validator keys and registering them
Moved the deposit command logic out into a generateAction and generateParams classes so this can be re-used between the two commands that need to handle generating validator keys

Fixed Issue(s)

fixes #1889
Documentation

[x ] I thought about documentation and added the documentation label to this PR if updates are required.

Doc'd - https://docs.teku.pegasys.tech/Reference/CLI/CLI-Subcommands/#generate-and-register


Terraform landing page and tutorial

Adding Terraform landing page
Need to figure out how to add tables (or a good way to display the info https://github.com/Kong/terraform-provider-konnect?tab=readme-ov-file#capabilities)
Preview link: https://deploy-preview-36--kongdeveloper.netlify.app/terraform/

@cloudjumpercat can you rebase this?

After going through the content in this PR, I'm going to close it for now. The how to content was basically copy/pasted from the Terraform GitHub repo readme and I hadn't revised it yet. The landing page content was sparse and I don't think the diagram I made was useful, so I think I'll just close this.


Make Parsr available as a single PyPi package

Additional Ideas:

Split the current project into libraries before publishing them as individual libraries.
Add our types to @types/... http://definitelytyped.org/

UPDATE: Priority shifted to a python/pip packaging

Update: We will instead focus on a python library's addition to the PyPi (https://pypi.org) repository for easier access via Python.

Resolved in #382


[REGRESSION] some input can cause the UI to become 'weird'

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
typeset a=$'@lulu @firewall @export LuLu\'s rules are stored in /Library/Objective-See/LuLu/rules.plist. If one has root privileges, by design, the rules can be directly read, and/or modified\n\C-@@zip @rar arc\n\C-@@pdf2epub @finereader flexible layout loses content. formatted_html+cali is good (though epub then cali is probably the same). fine reader is better than all I have tried yet.\n\C-@@pdf2epub @epub @pdf @word word to epub sucks with libre, cali, pandoc\n\C-@@zsh zsh: $var1 posix: How can I expand a quoted variable to nothing if it\'s empty? ${var1:+"$var1"}\n\C-@@Zsh @quote\nIn zsh, you can omit the double quotes most of the times, with a few exceptions.\n\n$var never expands to multiple words, however it expands to the empty list (as opposed to a list containing a single, empty word) if the value of var is the empty string. Contrast:\n\nvar=\nprint -l $var foo        # prints just foo\nprint -l "$var" foo      # prints an empty line, then foo\nSimilarly, "${array[@]}" expands to all the elements of the array, while $array only expands to the non-empty elements.\n\nThe @ parameter expansion flag sometimes requires double quotes around the whole substitution: "${(@)foo}".\n\nCommand substitution undergoes field splitting if unquoted: echo $(echo \'a\'; echo \'*\') prints a * (with a single space) whereas echo "$(echo \'a\'; echo \'*\')" prints the unmodified two-line string. Use "$(somecommand)" to get the output of the command in a single word, sans final newlines. Use "${$(somecommand; echo _)%?}" to get the exact output of the command including final newlines. Use "${(@f)$(somecommand)}" to get an array of lines from the command\'s output.\n\C-@boy\n\C-@@magic @progressify @go \nmacOS: dtruss go get github.com/divan/gofresh 2>&1 |  pv -i 0.05 > /dev/null\nlinux: strace -f -e trace=network go get github.com/divan/gofresh 2>&1 | pv -i 0.05 > /dev/null\n\C-@A variable declared with typeset without -g in a function has the local scope of the function.\n\C-@'

echo "$a" | FZF_DEFAULT_OPTS= command fzf --read0

In previous versions, things were fine:

My current version:
❯ fzf --version
0.27.1 (brew)

Getting the same issue after upgrading to 0.27.1, bisected the issue to commit 3f75a8369f63f2bd6ac3686fc5d88f2bc128e610.

Thanks for the report. I can easily reproduce the problem like so.
seq 1000 | fzf --read0

The problem is runewidth.StringWidth is seeing \n as a zero-width character.
package main

import "fmt"
import "github.com/mattn/go-runewidth"

func main() {
	fmt.Println(runewidth.StringWidth("foo\nbar"))
}

$ GO111MODULE=auto go run main.go
6

Should be fixed in 0.27.2.

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
typeset a=$'@lulu @firewall @export LuLu\'s rules are stored in /Library/Objective-See/LuLu/rules.plist. If one has root privileges, by design, the rules can be directly read, and/or modified\n\C-@@zip @rar arc\n\C-@@pdf2epub @finereader flexible layout loses content. formatted_html+cali is good (though epub then cali is probably the same). fine reader is better than all I have tried yet.\n\C-@@pdf2epub @epub @pdf @word word to epub sucks with libre, cali, pandoc\n\C-@@zsh zsh: $var1 posix: How can I expand a quoted variable to nothing if it\'s empty? ${var1:+"$var1"}\n\C-@@Zsh @quote\nIn zsh, you can omit the double quotes most of the times, with a few exceptions.\n\n$var never expands to multiple words, however it expands to the empty list (as opposed to a list containing a single, empty word) if the value of var is the empty string. Contrast:\n\nvar=\nprint -l $var foo        # prints just foo\nprint -l "$var" foo      # prints an empty line, then foo\nSimilarly, "${array[@]}" expands to all the elements of the array, while $array only expands to the non-empty elements.\n\nThe @ parameter expansion flag sometimes requires double quotes around the whole substitution: "${(@)foo}".\n\nCommand substitution undergoes field splitting if unquoted: echo $(echo \'a\'; echo \'*\') prints a * (with a single space) whereas echo "$(echo \'a\'; echo \'*\')" prints the unmodified two-line string. Use "$(somecommand)" to get the output of the command in a single word, sans final newlines. Use "${$(somecommand; echo _)%?}" to get the exact output of the command including final newlines. Use "${(@f)$(somecommand)}" to get an array of lines from the command\'s output.\n\C-@boy\n\C-@@magic @progressify @go \nmacOS: dtruss go get github.com/divan/gofresh 2>&1 |  pv -i 0.05 > /dev/null\nlinux: strace -f -e trace=network go get github.com/divan/gofresh 2>&1 | pv -i 0.05 > /dev/null\n\C-@A variable declared with typeset without -g in a function has the local scope of the function.\n\C-@'

echo "$a" | FZF_DEFAULT_OPTS= command fzf --read0

In previous versions, things were fine:

My current version:
❯ fzf --version
0.27.1 (brew)

[ ] @KashcheyMC

Cannot reproduce with your example @KashcheyMC on master (or with the seq 1000 | fzf --read0 example for that matter), however I agree this still happens in some cases. I've attached a file that reproduces with cat file.txt | fzf --read0 on master (b8aa2d2c32e791c5d9dc97443f0c7e108b52a34c) and would ask for a reopen if you can reproduce.

@azenet I can't reproduce on fzf 0.27.2 (brew):

@NightMachinary thanks for testing, I'm assuming this might be a terminal-related issue then (I'm using konsole on archlinux, tested with 0.27.2 (e086f0b) and master)


Update copy following changes to the questionnaire

On both production V1.46.2 and Staging V1.52.0, the dialog "New topics. have been recommended based on your answers! See recommendations" doesn't show up after answering Q2 although the recommended list gets updated based on the answers.
Acceptance Criteria

[ ]  The dialog "New topics have been recommended based on your answers! See recommendations" should show up for every instance where the answer(s) to any of the questionnaire changes the recommended list.
[ ] New copy: "Your recommended topics have been updated based on your answers"

Steps for QA:

Click "Answer questions" button on the home screen
Select an answer or skip Q1
Select one or more answers under Q2
Click X at the top right corner to close the Questionnaire
The dialog "New topics have been recommended based on your answers! See recommendations" should pop up then you click "See recommendations" button to see the updated recommended list.

This is as expected, but it's tricky. Try these steps:

Delete all data off the app
Go to the home screen, observe that "Apply for Social Insurance Number (SIN)" shows up in the list of things to do right away
Click Answer Questions
Skip the first question
On the second question, mark that "I have a Social Insurance Number"
Click X, observe that you do not see the dialog (this is counter-intuitive but I would argue, correct behaviour)
Go to the home screen, observe that "Apply for Social Insurance Number (SIN)" no longer shows up in the list of things to do right away

The thing is that Q2 is special, in that marking questions removes recommended topics, doesn't add them. That is why you don't get the dialog.
I'm open to talk about how we can make this clearer.

New copy: "Your recommended topics have been updated based on your answers", button still says "See recommendations"

Moving this back from In Review to product team backlog.

Moving this back from In Review to product team backlog.

Related to #1539


Archive project

Hi @alfonsogarciacaro ! First of all, thank you for a great work! I created this issue because I found there are two versions of UseElmish hook - this and Feliz. Based on fable blog post I assumes that Feliz's version is deprecated. Hovewer, later I found that the changes from here were moved to Feliz and any maintenance is continued by @Zaid-Ajaj.
Having two same libraries is confusing - my company already used Fable.React.UseElmish and after discovering an error with useEffectOnce were switched to the Feliz.UseElmish. To save time of the others, I suggest to archive this repo or at least put some note.

Hello @lukaszkrzywizna,
Thank you I just archived this repo and marked the package as deprecated on NuGet.


old hardfork tests spend too much time incrementing blocks

durations.txt
See the attached file for unit test runtimes. Notice that the old hardfork tests take too long. We have a better mechanism to bring the hardfork block numbers in line with the number of blocks already mined in the unit test. I.e. from the normalization fork:
    int currentHeight = chainActive.Height();
    const Consensus::Params& consensus = Params().GetConsensus();
    const_cast<Consensus::Params&>(consensus).nNormalizedNameForkHeight = currentHeight + 2;

Feel free to encapsulate this somehow.
Acceptance Criteria
These tests have been sped up: hardfork_claim_test, hardfork_support_test, claimtriebranching_hardfork_disktest, claim_expiration_test
Definition of Done

[ ] Tested against acceptance criteria
[ ] The project builds without errors
[ ] Peer Code Review performed

I want to work on this. Can you please help me with what needs to be done.

done via cherry-pick


Balena engine with Kubernetes

I am trying to run kubernetes on my cluster and want to have Balena as my container runtime. But kubelet is not starting up with Balena engine. Does Balena have cri shim layer to talk to kubelet ? Is it compatible with kubernetes?

since balena api's are same as docker, I think it should work, though not personally tested.
Kubelet have inbuild CRI implementation called  dockershim , which is enabled by default.
You may try configuring kubelet with  --docker-endpoint  to  /var/lib/balena.sock  .

Since Kubernetes is deprecating Docker and the old CLIs has anyone been able to set balena-engine as the container runtime?


Fix arrow key focus manager

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/19012
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests

Open chat screen.
Type<EMAIL_ADDRESS>with some mention. The suggestion window should contain 2 or more suggestions.
Select the second suggestion.
Use the left arrow to move your cursor in the composer to the left, triggering the suggestion menu to appear again.
You will see only one item in the suggestion window. Press Enter and choose it. An error should occur.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome
https://github.com/Expensify/App/assets/48593211/68b3041e-c4dd-4095-baad-7d49aa8a587f

Mobile Web - Safari

Desktop

iOS

Android

Hi @perunt, I'm a little confused by this PR. In the discussion here, it says that the issue is being fixed by an ongoing PR and @sophiepintoraetz recommended closing out this issue.
Do you think you can elaborate on why we need this PR? Sorry, I'm new to this discussion so just want to make sure I'm on the same page.

you're right, so I'm going to close this pr as well


Create About Us Page

Create a new About Us page, add a photo, or maybe a moving animation if you want to. Give  a paragraph of lorem ipsum

I'd like to take this on! Can you allow me to contribute

@drewduong Yes, you can work on this !!

@drewduong Are you working on it ?


Argument not for where.OR.1.codes.some.code.not must not be null. Please use undefined instead.

Bug description
The query was working correctly until I modified a model but the attribute codes had no changes and neither the relationship with type code
Before:
model Component {
  id           Int @id @default(autoincrement())
  title        String
  premium      Boolean
  codes        Code[]
  images       ComponentImage[]
  group        ComponentGroup @relation(fields: [groupId], references: [id])
  groupId      Int
  published    Boolean
  createdAt    DateTime @default(now())
  updatedAt    DateTime @updatedAt
}

After
model Component {
  id           Int @id @default(autoincrement())
  title        String
  premium      Boolean
  codes        Code[]
  imageMobile  String?
  imageTablet  String?
  imageDesktop String?
  group        ComponentGroup @relation(fields: [groupId], references: [id])
  groupId      Int
  published    Boolean
  createdAt    DateTime @default(now())
  updatedAt    DateTime @updatedAt
}

I had a problem with the command migrate up, so I:

truncated _Migration
removed the Migration folder
deleted the ComponentImage table

and after worked fine.
When I ran a query and I got an error:
{
  "errors": [
    {
      "message": "\nInvalid `prisma.component.findMany()` invocation in\n/Users/adriano/Documents/Codes/lib/graphql-prisma/src/resolvers/Query.js:34:29\n\n  30     },\n  31   }\n  32 }\n  33 \n→ 34 return prisma.component.findMany({\n       where: {\n         group: {\n           slug: undefined,\n           category: {\n             type: undefined\n           }\n         },\n         published: true,\n         OR: [\n           {\n             imageDesktop: {\n               not: null\n             }\n           },\n           {\n             codes: {\n               some: {\n                 code: {\n                   not: null\n                        ~~~~\n                 }\n               }\n             }\n           }\n         ]\n       },\n       include: {\n         group: {\n           include: {\n             category: true\n           }\n         },\n         codes: true\n       }\n     })\n\nArgument not for where.OR.1.codes.some.code.not must not be null.  Please use undefined instead.",
            "",
            "",
            "    at Document.validate (/Users/adriano/Documents/Codes/lib/graphql-prisma/node_modules/@prisma/client/src/runtime/query.ts:256:19)",
            "    at Object.model [as Component] (/Users/adriano/Documents/Codes/lib/graphql-prisma/node_modules/@prisma/client/src/runtime/getPrismaClient.ts:435:20)",
            "    at Object.findMany (/Users/adriano/Documents/Codes/lib/graphql-prisma/node_modules/@prisma/client/src/runtime/getPrismaClient.ts:553:33)",
            "    at components (/Users/adriano/Documents/Codes/lib/graphql-prisma/src/resolvers/Query.js:34:29)",
            "    at field.resolve (/Users/adriano/Documents/Codes/lib/graphql-prisma/node_modules/graphql-extensions/src/index.ts:274:18)",
            "    at resolveFieldValueOrError (/Users/adriano/Documents/Codes/lib/graphql-prisma/node_modules/graphql/execution/execute.js:486:18)",
            "    at resolveField (/Users/adriano/Documents/Codes/lib/graphql-prisma/node_modules/graphql/execution/execute.js:444:16)",
            "    at executeFields (/Users/adriano/Documents/Codes/lib/graphql-prisma/node_modules/graphql/execution/execute.js:281:18)",
            "    at executeOperation (/Users/adriano/Documents/Codes/lib/graphql-prisma/node_modules/graphql/execution/execute.js:225:122)",
            "    at executeImpl (/Users/adriano/Documents/Codes/lib/graphql-prisma/node_modules/graphql/execution/execute.js:102:14)"
          ]
        }
      }
    }
  ],
  "data": null
}

I tested with undefined but some item return with codes: [] and imageDesktop: null
If I comment this lines in Query (below):
codes: {
  some: {
    code: { not: null }
  }
}

The error disappears
Expected behavior
Return without codes empty as before.
Prisma information
Query:
Before
components(parent, args, { prisma, request }) {
  let whereArgs = {}

  if (args.where) {
    whereArgs = {
      group: {
        slug: args.where.slug,
        category: {
          type: args.where.type
        }
      },
    }
  }

  return prisma.component.findMany({
    where: {
      ...whereArgs,
      published: true,
      OR: [
        {
          images: {
            some: {
              desktopSrc: { not: null }
            }
          }
        },
        {
          codes: {
            some: {
              code: { not: null }
            }
          }
        }
      ]
    },
    include: {
      group: {
        include: {
          category: true
        }
      },
      codes: true,
      images: true
    }
  })
},

After
components(parent, args, { prisma, request }) {
  let whereArgs = {}

  if (args.where) {
    whereArgs = {
      group: {
        slug: args.where.slug,
        category: {
          type: args.where.type
        }
      },
    }
  }

  return prisma.component.findMany({
    where: {
      ...whereArgs,
      published: true,
      OR: [
        {
          imageDesktop: { not: null }
        },
        {
          codes: {
            some: {
              code: { not: null }
            }
          }
        }
      ]
    },
    include: {
      group: {
        include: {
          category: true
        }
      },
      codes: true,
    }
  })
},

Environment & setup

OS: macOS 10.15.4
Database: PostgreSQL
Prisma version: 2.0.0-alpha.1257
Node.js version: v13.3.0

I am unable to reproduce this with alpha.1299:

Can you please try this again with the latest alpha?

Today I updated to v2.2.0 and the error persist.
The error disappears when I comment or removing code: { not: null }

@adrianoresende Can you share a SQL dump of your database so that I can import it? You can either upload it here or send it to<EMAIL_ADDRESS>if the data is sensitive.
We can also sign a NDA if you want.

Ping @adrianoresende about Harshit's last followup.

I am going to close this as its been 3 months now and there is no activity here.
Please open a new issue in https://github.com/prisma/prisma if you want us to take another look.

I am going to close this as its been 3 months now and there is no activity here.
Please open a new issue in https://github.com/prisma/prisma if you want us to take another look.


New macos-13 release breaks InstallAppleCertificate@V2 task

Description
MacOS agents are often used for building iOS Apps, for this you would typically use the Task InstallAppleCertificate@V2, which in the latest version of the macos-13 agents stopped working.
Looking at the list of things that were updated, LibreSSL was replaced with OpenSSL. https://github.com/actions/runner-images/releases/tag/macos-13%2F20230731.2
There is an open issue in with the InstallAppleCertificate Task, which explicitly says that it breaks when OpenSSL is installed: https://github.com/microsoft/azure-pipelines-tasks/issues/18560
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[X] macOS 13
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Agent name: 'Azure Pipelines 3'
Agent machine name: 'Mac-1690898999289'
Current agent version: '3.224.1'
Operating System
Runner Image
Runner Image Provisioner
Current image version: '20230731.2'
Is it regression?
Yes
Expected behavior
InstallAppleCertificate task works
Actual behavior
The Task breaks with:
/usr/local/bin/openssl pkcs12 -in /Users/runner/work/_temp/mykey.p12 -nokeys -passin pass:*** | /usr/local/bin/openssl x509 -sha1 -noout -fingerprint -subject -dates -nameopt utf8,sep_semi_plus_space
Error outputting keys and certificates
00077E5CF87F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:crypto/evp/evp_fetch.c:341:Global default library context, Algorithm (RC2-40-CBC : 0), Properties ()
##[debug]success of first tool:false
Could not read certificate from <stdin>

Repro steps
Add the InstallAppleCertificate@V2 task and install a Apple certificate

thank for the report. I'll have a look

This issue is very impactful, all ios builds with Azure DevOps are blocked.

@ilia-shipitsin I cannot share a distribution certificate with you. But usage would be:
    - task: InstallAppleCertificate@2
      displayName: 'Install Apple Distribution Certificate'
      inputs:
        certSecureFile: '$(distributionCertName)'
        certPwd: '$(distributionCertKey)'

It could be useful: the InstallAppleCertificate Task attempts to use openssl from the path at /usr/local/bin instead of the system openssl binary at /usr/bin

Will attach pieces of reports from Appcenter CI

yes, I think the issue is on InstallAppleCertificate, I plan to find a way how to tell it to use proper openssl command line

In the last version, the openssl has changed:
https://github.com/actions/runner-images/pull/8013/files#diff-49d5008075920b3466eff9e2bb3f4a933cca7733524c0153fd761cf9b6fc4fd4R56

we do not install neither OpenSSL, nor LibreSSL. I bet it came as a dependency of some other Homebrew package.
I do not have a certificate to play with, but I was able to put libressl before any other implementation in the following way
          brew install libressl
          export PATH="/usr/local/opt/libressl/bin:$PATH"
          echo 'export PATH="/usr/local/opt/libressl/bin:$PATH"' >> /Users/runner/.bash_profile

can you try it as a workaround?

I guess resolution of OpenSSL happens here: https://github.com/microsoft/azure-pipelines-tasks-common-packages/blob/aea571fa9b87ad655280a86530c88b1e9b12790b/common-npm-packages/ios-signing-common/ios-signing-common.ts#L525

we do not install neither OpenSSL, nor LibreSSL. I bet it came as a dependency of some other Homebrew package.
I do not have a certificate to play with, but I was able to put libressl before any other implementation in the following way
          brew install libressl
          export PATH="/usr/local/opt/libressl/bin:$PATH"
          echo 'export PATH="/usr/local/opt/libressl/bin:$PATH"' >> /Users/runner/.bash_profile

can you try it as a workaround?

Giving it a spin now

The command most likely needs the -legacy or -provider legacy to allow it to work: https://stackoverflow.com/questions/72598983/curl-openssl-error-error0308010cdigital-envelope-routinesunsupported

looks like a proper way. however, it will require us few days to test and deploy

Would it be possible to somehow use the macOS-13 image release that was available before the latest 20230131?

Can we please roll back to previous image so we can continue to build while you figure out if -legacy command will work.

How does this stuff get released?   This operation would happen on pretty much every iOS build.   Please revert this latest set of changes.

MacOS-12 still works fine; I'm very hopeful they're not going to update it.

MacOS-12 still works fine; I'm very hopeful they won't update it.

Except if you are using the latest SDKs it requires Xcode 14.3 which isn't on macos-12. I'd have to pin an older version of dotnet to allow Xcode 14.2 so I could use macos-12. Which puts you in a bad position if there were bug fixes in the later version of dotnet that you were using.

looks like adding -legacy to the "OpenSSL arguments for PKCS12" fixes the issue here
opensslPkcsArgs: '-legacy'

@samvantran what are the chances that this image will be deployed out soon?

While waiting for the new image to get deployed. Instead of the InstallAppleCertificate and InstallProvisioningProfile tasks you could do something like I do here: https://gist.github.com/Cheesebaron/a2e8f9c1c62ad3e38fae4b668fc30eed

Excellent. I'll give this one a whirl. Thanks @Cheesebaron!

While we work on the image, some teams have had success with this mitigation:
run brew unlink openssl after brew install openssl@3

A fix is rolling out over the next few hours: https://github.com/actions/runner-images/pull/8019

Just as soon as I applied @Cheesebaron's fix, the fix got rolled out and was working in other branches and projects. 🤦🏻♂
This day was a total write off!

@Cheesebaron , the following caught my attention Algorithm (RC2-40-CBC : 0)
can you provide more details on certificate ? is it RC2-40-CBC ?
those algorithms were indeed disabled in modern OpenSSL-3.X by default (and must be enabled by using "legacy" provider), however, justification on enabling legacy algs by default is not clear.

@ilia-shipitsin this is what I get with:
openssl pkcs12 -in mykey.p12 -noout -info:
MAC verified OK
PKCS7 Encrypted data: pbeWithSHA1And40BitRC2-CBC, Iteration 2048
Certificate bag
PKCS7 Data
Shrouded Keybag: pbeWithSHA1And3-KeyTripleDES-CBC, Iteration 2048

These are issued by Apple FYI.

Interesting. Looks like a good justification for enabling "legacy" on Homebrew side

Alternatively there needs to be a step in the process that attempts to convert the cert or some docs about how to convert the certificate to a format that is supported.

well, it should have been addressed better.
maybe, some helpful error message on InstallAppleCertificate@V2 side, like "your certificate is not secure, please do so and so"

Hello all!
We apologise for inconvenience caused. Even though the issue is fixed, we would like to remind that macOS-13 is still in the public beta state, therefore, we urge everybody not to use it for the production development yet. We are working on improving the image's stability and will make an additional announcement once macOS 13 is generally available.
Thank you for your patience and understanding!

To be quite frank you probably wouldn't have found out unless we used it for production purposes already. AppCenter thinks that these are fine to use for production purposes as well.
Also keep in mind that some people are forced to use the images because of which versions of Xcode available on macos-12 agents.

Hi, we found the same issue on macos-15 image, currently we workaround by adding -legacy to openssl command. But we hope this gets a fix.

Hi, we found the same issue on macos-15 image, currently we workaround by adding -legacy to openssl command. But we hope this gets a fix.

+1

@Komdosh @TedaLIEz
legacy didnt work for me - I had to convert my certificate exported from Keychain Access using this guide: https://www.docuseal.com/docs/convert-legacy-p12-pfx-files-to-support-openssl-3
Seems to work after that.


Please support building with external libxxhash

Is your feature request related to a problem? Please describe.
As a Linux distribution packager, I need to build with system copies of third-party libraries whenever possible.
Describe the solution you'd like
Add a CMake option to use an external copy of libxxhash, similar to gRPC_ZLIB_PROVIDER and friends. Use something like pkg_search_module() to find it.
Describe alternatives you've considered
Manually patch cmake/xxhash.cmake to use pkg_search_module(); use that to set _gRPC_XXHASH_INCLUDE_DIR and a new _gRPC_XXHASH_LIBRARIES, and (to simplify the downstream patch) shove ${_gRPC_XXHASH_LIBRARIES} into _gRPC_ALLTARGETS_LIBRARIES in CMakeLists.txt. This works. Upstream support would be better.

Feel free to submit a PR for this one? We used a header-only build with an actual code drop to avoid any of these issues on purpose however.

Feel free to submit a PR for this one? We used a header-only build with an actual code drop to avoid any of these issues on purpose however.

Knowing that the library is not needed is helpful; I had missed the use of XXHASH_INCLUDE_ALL. That means I can unbundle downstream simply by removing third_party/xxhash and letting the system xxhash.h be found instead.
That’s good enough for me; I think it’s best not to attempt a PR that would add configuration to the process.


Expand README.

So one checkouts, installs the requirements, asv run, ... — then what?

We should probably point to the ASV docs, and mention publish/preview.
Plus maybe how to generate a few runs for (e.g.) daily commits for last week, weekly commits for last month? (So there's something to see).

Plus, also, a little about the project, and how to join in.
Related is the discussion on the forum about the results folder: https://forum.djangoproject.com/t/django-benchmarking-project/13887/11 — Can we commit this back to the repo (and accept PRs maybe) so that we can build up the data over time?
I would think that running once a day (or week even once we've got some data) is more than enough to spot regressions no?
(Thoughts? 🤔 — We're working out the answers.)

I agree with all of Carlton's comments.
Scipy has a separate repo[1] which stores the results, and an action [2] to build and publish the pages. Note: I'm not entirely sure where the script for the actions are saved.
[1] https://github.com/pv/scipy-bench
[2] https://github.com/pv/scipy-bench/actions
I think it is reasonable to store the results in this repo (scipy's benchmarks are in its main repo i.e there equivalent to django/django) and build the output here too.
I did some work with the aim of running a benchmark and committing the results back to the repo a while back. Some of these steps may be useful here, but likely there is a better way since I wrote this a couple of years ago.
https://github.com/smithdc1/djangobench-tracker/blob/main/.github/workflows/django-commits.yml
It could be two actions. One to run the benchmarks as a cron job and another to build and publish the pages on each commit. That way we can accept prs with others results in future.
Likely running it in GHA will be noisy. I'm not familiar with self hosted runners but presumably it will be the same workflow just run on our own infrastructure 🤔.

Likely running it in GHA will be noisy. I'm not familiar with self hosted runners but presumably it will be the same workflow just run on our own infrastructure 🤔

Yes, we need to investigate.
My thought though is to just get it up with the hosted runner and have a look. (Maybe that's enough, maybe it's easier to see what the requirements are from there, maybe weekly hosted with some uploads from … is enough to, ... — etc.) — either wa we should be able to block out what we need initially on the hosted runners.
(I haven't heard back from Ops yet: other things going on. But to the extent we can pull from an untrusted environment, rather than push with a token of some kind into a trusted environment, the happier they'll be, I imagine.)

Hey @deepakdinesh1123 -- What's your thoughts on this? (No rush, just wanted to check it's on your radar 📡 )

I am sorry I did not reply earlier, I was working on this for the past couple of days, and here is the progress I was able to make

Locally, I was able to generate results for the first commit of each month for the past 5 years and I am running actions on my fork to automate the benchmarking and publishing part
After a few sample workflow runs where I tried to commit to the results folder itself, I think keeping the results folder ignored is better as running the benchmarks on branches can affect it and the results might get affected.
The results can be published and viewed by copying the asv.conf.json file to ci-results folder and running the asv publish

I will update the README as soon as I am done with the workflows, I am currently working on setting up a workflow to generate the result for the commits for the past 5 years and push it to the repository.

No need to apologies, you are doing great work. 🙏

...  I am running actions on my fork to automate the benchmarking and publishing part

Great stuff, looking forward to seeing this. 🎉

... running the benchmarks on branches can affect it and the results might get affected.

I don't quite understand this, could you explain further please?

ASV saves information about the machine, so if the results of the benchmarks from another machine are added, the results cannot be published and the results will be corrupted.

Hmmm 🤔
I thought the idea was to both be able to filter by and average over different machines.
Maybe a bit of investigation? (I may be entirely wrong 😃)

From the docs:

The results are stored as JSON files in the directory results/$MACHINE, where $MACHINE is the unique machine name that was set up in your ~/.asv-machine.json file.

And locally:

So, can we add results to the correct $MACHINE subdirectory, and add How to do that to the README? 🤔

These were the results I was able to obtain while using multiple machines, is this what you were hoping to see?
Should I change the benchmark.yml  workflow to run on different operating systems and add those results to their respective directories in ci-results?

These were the results I was able to obtain while using multiple machines, is this what you were hoping to see?

These screenshots look nice. 👌
This is was I was expecting to see, you can the slice the data by machine and see them all at once. And maybe in the future by Python version too.
Maybe there's still some work to see how many machine names we get from running it in CI (are they unique every time?), but maybe that can be improved with a self hosted runner.

Should I change the benchmark.yml  workflow to run on different operating systems and add those results to their respective directories in ci-results?

Could you explain this further. I'm not sure I'm familiar with either of benchmark.yml or ci-results (why is this different to the results folder in Carlton's image).
I wonder if it may help my understanding and the discussion if you could open a PR with the current changes? 🤔

I think closed by #59 for now.


Introduce a new interactive engine

What do these changes do?

We have developed a new interactive engine which including a new IR compiler, an executor and are going to replace the legacy one.
Basically, it involves the following items.

New super lightweight frontend.
New super lightweight executor.
Coordinator is removed.
Zookeeper is no longer needed anymore.

Related issue number

Fixes #1674 #1675 #1676 #1771

Codecov Report

Merging #1782 (3689682) into main (e0166e7) will increase coverage by 20.93%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1782       +/-   ##
===========================================
+ Coverage   43.86%   64.79%   +20.93%
===========================================
  Files          89       89
  Lines        9798     9798
===========================================
+ Hits         4298     6349     +2051
+ Misses       5500     3449     -2051

Impacted Files
Coverage Δ

...aphscope/tests/kubernetes/test_resource_builder.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...on/graphscope/tests/kubernetes/test_demo_script.py
0.00% <0.00%> (-91.75%)
:arrow_down:

python/graphscope/deploy/kubernetes/utils.py
11.90% <0.00%> (-58.58%)
:arrow_down:

python/graphscope/tests/unittest/test_java_app.py
49.33% <0.00%> (-50.67%)
:arrow_down:

python/graphscope/deploy/kubernetes/cluster.py
23.55% <0.00%> (-50.20%)
:arrow_down:

python/graphscope/analytical/app/java_app.py
24.24% <0.00%> (-44.95%)
:arrow_down:

...thon/graphscope/tests/kubernetes/test_with_mars.py
0.00% <0.00%> (-44.83%)
:arrow_down:

python/graphscope/interactive/query.py
41.12% <0.00%> (-38.71%)
:arrow_down:

...n/graphscope/deploy/kubernetes/resource_builder.py
30.59% <0.00%> (-25.95%)
:arrow_down:

python/graphscope/client/rpc.py
76.85% <0.00%> (-12.97%)
:arrow_down:

... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0166e7...3689682. Read the comment docs.


Instructions for Instructions on Production Floor Execution Unclear

The following section list an "Example" of a scenario of when instructions appear.
https://learn.microsoft.com/en-us/dynamics365/supply-chain/production-control/production-floor-execution-use#opening-instructions
"For example, a document that is attached to a product on the Released products page in Supply Chain Management will be available for workers to open in the shop floor execution interface."
Are there other examples?  Is there a configuration needed for this?  Are only specific types of documents applicable?  I am unable to find any specific details on how it should work.
Thanks,
Ryan

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 17fe109b-0191-fae3-c120-608f709208c3
Version Independent ID: 2ae7d13f-c34e-53de-3265-c1c508c3703e
Content: How workers use the production floor execution interface - Supply Chain Management | Dynamics 365
Content Source: articles/supply-chain/production-control/production-floor-execution-use.md
Service: dynamics-365-supply-chain
Product: ****
Technology: ****
GitHub Login: @johanhoffmann
Microsoft Alias: johanho

Bug 804149 has been logged to address this issue.

@rmccarron-napoleon, thanks for contacting us. Unfortunately, we're unable to handle Support requests for the product here. To contact Support, consider one of the options described here: Support contact options. In particular, you might want to go to the Dynamics 365 community page to get help with your questions from the Dynamics community.


Using programmatic deployer with multiple namespaces does not work

Here is a sample program to illustrate the problem. You'll need to test this with a couple of namespaces (and need to generate a couple of login tokens to run this code).
const { runNimCommand} = require('nimbella-cli');
const nimDeployer = require('nimbella-cli/lib/deployer');

async function getResourceFromToken(token) {
  await runNimCommand('auth/login', [token]);
  const namespace = (await runNimCommand('auth/current')).captured[0]
  const actions = (await runNimCommand('action/list')).table
  console.log(namespace)
  console.log(actions[0].namespace)
}

async function main() {
 await getResourceFromToken(process.env.TOKEN1)
 await getResourceFromToken(process.env.TOKEN2)
}

main().catch(console.log)

To run this you'll need to use nim auth export for two different namespaces and create two env vars TOKEN1 and TOKEN2, and ensure you have at least one action in each namespace.
expected result
namespace1
namespace1
namespace2
namespace2

actual result
namespace1
namespace1
namespace2
namespace1

If you run this with DEBUG=* you'll see that the second handoff to AIO is wrong and preserved the "whisk identity" from the first login. Look for output like this:
nim:base aio capture intercepts installed
  aio-cli-config reading config: ...
  aio-cli-config reading env variables: runtime.namespace, runtime.apihost, runtime.auth
  aio-cli-plugin-runtime {
  aio-cli-plugin-runtime   apiversion: 'v1',
  aio-cli-plugin-runtime   apihost: 'https://...',
  aio-cli-plugin-runtime   api_key: 'namespace1-only-will-appear-here'
  aio-cli-plugin-runtime }

The CLI so far has avoided setting WHISK_AUTH explicitly as done in the now merged PR. The whisk auth value ends up https://github.com/adobe/aio-cli-plugin-runtime/blob/156cc025270153f1c9d5929cdd18f6fae0daa6c3/src/RuntimeBaseCommand.js#L33
The AIO config class https://github.com/adobe/aio-lib-core-config/blob/dc1e97e82c20ec1f283c01755b6cad7d469b5b3d/src/Config.js#L51-L59 converts AIO_RUNTIME_AUTH to runtime.auth but it's plausible that the config is not reloaded
https://github.com/adobe/aio-lib-core-config/blob/dc1e97e82c20ec1f283c01755b6cad7d469b5b3d/src/Config.js#L72 and so we might need a deeper fix.

IMO this issue should have been filed against the CLI and not the deployer.   IMO the title should replace 'deployer' with 'CLI'.
Although the deployer API is imported it is not used in the example.  The misbehavior is entirely driven via usage of the CLI library, not the deployer library.
Note that there is no declared dependency of the deployer on AIO.  So, it will be difficult to fix this in deployer code.
The accident of history that is confusing us here is that the NimBaseCommand class is located in the deployer package even though it is actually in no way shape or form part of the deployer.   It was stuck there some time ago to avoid proliferating packages.   There was (at least at the time) a reason why it needed to be moved out of the CLI because of circular dependencies.   I think moving it back into the CLI should be explored now that the packaging has changed substantially.

Thanks for the input @joshuaauerbachwatson. I’ll move the issue and update the code snippet to remove the unused deployer reference.


Can't install libssl-dev on this Docker image

See details here: https://github.com/gplessis/dotdeb-php/issues/146
Basically, the following works (from the official Debian image):

docker pull debian:jessie
docker run --detach --privileged --volume=/sys/fs/cgroup:/sys/fs/cgroup:ro debian:jessie /lib/systemd/systemd
docker exec --tty [id] env TERM=xterm apt-get -y update
docker exec --tty [id] env TERM=xterm apt-get -y install libssl-dev

While the following doesn't (using this Docker image):

docker pull geerlingguy/docker-debian8-ansible:latest
docker run --detach --privileged --volume=/sys/fs/cgroup:/sys/fs/cgroup:ro geerlingguy/docker-debian8-ansible:latest /lib/systemd/systemd
docker exec --tty [id] env TERM=xterm apt-get -y update
docker exec --tty [id] env TERM=xterm apt-get -y install libssl-dev

The latter results in:
$ docker exec --tty 3c808f66 env TERM=xterm apt-get -y install libssl-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libssl-dev : Depends: libssl1.0.0 (= 1.0.1t-1+deb8u2) but 1.0.2h-1~bpo8+2 is to be installed
              Recommends: libssl-doc but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

It looks like the version that's already present is installed as part of the image's ansible install, which requires libssl1.0.0... hmm, don't know if I can resolve this easily :/

Ah, I just realized it's probably because I'm building from the jessie-backports repo... which has different versions for a lot of things. Ugh.


Intellisense should not work inside string literals

Should be fixed in 0.1.6 https://github.com/fsprojects/FSharp.Atom/commit/c43efbfec50f67de2fa82731f20c95d5dcdfa804


Build errors on 10 and 11i386

10: http://pkg.awarnach.mathstat.dal.ca/data/10i386-default/2017-10-30_08h44m48s/logs/errors/smart-0.0.4.log
11i386: http://pkg.awarnach.mathstat.dal.ca/data/11i386-default/2017-10-30_08h44m48s/logs/errors/smart-0.0.4.log

10.x is problematic because it is missing NVMe suppport as well as the scsi_ata_pass() interface for ATA devices attached to a SAS adapter. I can "ifdef" out unsupported code, but this starts getting messy and looses more functionality than I'd like. Any sense of how important this is for 10?

My sense is that it's not worth messing up clean code for 10, which should be EOL within a year.  I asked @allanjude, who requested the port, to share his thoughts.  Is the 11i386 issue similarly problematic or is there a simpler solution I should wait for before committing the port?

No, the 11i386 fix was easy and is now committed. If 10.x isn't needed, I'll bump the revision and tag.

Sounds good.  After you tag the new release I'll commit the port.  Thanks.

I still see the build error with 0.05 on 11i386.

Hmmm, I don't see the incomplete type error:
# uname -a
FreeBSD  11.1-RELEASE FreeBSD 11.1-RELEASE #0 r321309: Fri Jul 21 04:10:47 UTC 2017     root@releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC  i386
# git status
HEAD detached at 0.0.5
nothing to commit, working tree clean
# make
echo smart.full: /usr/lib/libc.a  >> .depend
Warning: Object directory not changed from original /usr/home/ctuffli/dev/smart.git
cc -O2 -pipe   -g -MD  -MF.depend.smart.o -MTsmart.o -std=gnu99 -fstack-protector-strong    -Qunused-arguments  -c smart.c -o smart.o
cc -O2 -pipe   -g -MD  -MF.depend.libsmart.o -MTlibsmart.o -std=gnu99 -fstack-protector-strong    -Qunused-arguments  -c libsmart.c -o libsmart.o
cc -O2 -pipe   -g -MD  -MF.depend.freebsd_dev.o -MTfreebsd_dev.o -std=gnu99 -fstack-protector-strong    -Qunused-arguments  -c freebsd_dev.c -o freebsd_dev.o
cc -O2 -pipe -g -std=gnu99 -fstack-protector-strong -Qunused-arguments  -o smart.full smart.o libsmart.o freebsd_dev.o  -lcam
objcopy --only-keep-debug smart.full smart.debug
objcopy --strip-debug --add-gnu-debuglink=smart.debug  smart.full smart
#

OK, it looks like struct scsi_log_informational_exceptions wasn't introduced until 11.1

This should build cleanly with >= 11.0 now

Confirmed.  Thanks.

P.S., the port is in the tree. :)  http://www.freshports.org/sysutils/smart/

@jehops Thanks for getting that done!


Fix autocompletions on Windows (fixes #1553)

fixes #1553
Test plan

Run IDE on Windows
Automatic autocompletions work
Triggered autocompletions work

Verified on both Windows & macOs - works 🚀


Universal Logging

This absolutely needs to go through.

See https://github.com/libgdx/libgdx/pull/6024