bug: duplicated/shorter documentation with neodev

Did you check docs and existing issues?

[X] I have read all the neodev.nvim docs
[X] I have searched the existing issues of neodev.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.0-dev-d2d3885
Operating system/version
Windows 11
Describe the bug
When using neodev, I get multiple function definitions for most lua stuff:

Without neodev I get just one definition (in this case for the wrong version of Lua, so using neodev it is more correct):

Steps To Reproduce
Open the attached repro and press Shift-K on require
Expected Behavior
Just one definition
Repro
--[[

=====================================================================
==================== READ THIS BEFORE CONTINUING ====================
=====================================================================

Kickstart.nvim is *not* a distribution.

Kickstart.nvim is a template for your own configuration.
  The goal is that you can read every line of code, top-to-bottom, understand
  what your configuration is doing, and modify it to suit your needs.

  Once you've done that, you should start exploring, configuring and tinkering to
  explore Neovim!

  If you don't know anything about Lua, I recommend taking some time to read through
  a guide. One possible example:
  - https://learnxinyminutes.com/docs/lua/

  And then you can explore or search through `:help lua-guide`
  - https://neovim.io/doc/user/lua-guide.html

Kickstart Guide:

I have left several `:help X` comments throughout the init.lua
You should run that command and read that help section for more information.

In addition, I have some `NOTE:` items throughout the file.
These are for you, the reader to help understand what is happening. Feel free to delete
them once you know what you're doing, but they should serve as a guide for when you
are first encountering a few different constructs in your nvim config.

I hope you enjoy your Neovim journey,
- TJ

P.S. You can delete this when you're done too. It's your config now :)
--]]
-- Set <space> as the leader key
-- See `:help mapleader`
--  NOTE: Must happen before plugins are required (otherwise wrong leader will be used)
vim.g.mapleader = " "
vim.g.maplocalleader = " "

-- Install package manager
--    https://github.com/folke/lazy.nvim
--    `:help lazy.nvim.txt` for more info
local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({
		"git",
		"clone",
		"--filter=blob:none",
		"https://github.com/folke/lazy.nvim.git",
		"--branch=stable", -- latest stable release
		lazypath,
	})
end
vim.opt.rtp:prepend(lazypath)

-- NOTE: Here is where you install your plugins.
--  You can configure plugins using the `config` key.
--
--  You can also configure plugins after the setup call,
--    as they will be available in your neovim runtime.
require("lazy").setup({
	-- NOTE: First, some plugins that don't require any configuration

	-- Git related plugins
	"tpope/vim-fugitive",
	"tpope/vim-rhubarb",

	-- Detect tabstop and shiftwidth automatically
	"tpope/vim-sleuth",

	-- NOTE: This is where your plugins related to LSP can be installed.
	--  The configuration is done below. Search for lspconfig to find it below.
	{
		-- LSP Configuration & Plugins
		"neovim/nvim-lspconfig",
		dependencies = {
			-- Automatically install LSPs to stdpath for neovim
			"williamboman/mason.nvim",
			"williamboman/mason-lspconfig.nvim",

			-- Useful status updates for LSP
			-- NOTE: `opts = {}` is the same as calling `require('fidget').setup({})`
			{ "j-hui/fidget.nvim", tag = "legacy", opts = {} },

			-- Additional lua configuration, makes nvim stuff amazing!
      "folke/neodev.nvim",
		},
	},

	{
		-- Autocompletion
		"hrsh7th/nvim-cmp",
		dependencies = {
			-- Snippet Engine & its associated nvim-cmp source
			"L3MON4D3/LuaSnip",
			"saadparwaiz1/cmp_luasnip",

			-- Adds LSP completion capabilities
			"hrsh7th/cmp-nvim-lsp",

			-- Adds a number of user-friendly snippets
			"rafamadriz/friendly-snippets",
		},
	},

	-- Useful plugin to show you pending keybinds.
	{ "folke/which-key.nvim", opts = {} },
	{
		-- Adds git related signs to the gutter, as well as utilities for managing changes
		"lewis6991/gitsigns.nvim",
		opts = {
			-- See `:help gitsigns.txt`
			signs = {
				add = { text = "+" },
				change = { text = "~" },
				delete = { text = "_" },
				topdelete = { text = "‾" },
				changedelete = { text = "~" },
			},
			on_attach = function(bufnr)
				vim.keymap.set(
					"n",
					"<leader>hp",
					require("gitsigns").preview_hunk,
					{ buffer = bufnr, desc = "Preview git hunk" }
				)

				-- don't override the built-in and fugitive keymaps
				local gs = package.loaded.gitsigns
				vim.keymap.set({ "n", "v" }, "]c", function()
					if vim.wo.diff then
						return "]c"
					end
					vim.schedule(function()
						gs.next_hunk()
					end)
					return "<Ignore>"
				end, { expr = true, buffer = bufnr, desc = "Jump to next hunk" })
				vim.keymap.set({ "n", "v" }, "[c", function()
					if vim.wo.diff then
						return "[c"
					end
					vim.schedule(function()
						gs.prev_hunk()
					end)
					return "<Ignore>"
				end, { expr = true, buffer = bufnr, desc = "Jump to previous hunk" })
			end,
		},
	},

	{
		-- Theme inspired by Atom
		"navarasu/onedark.nvim",
		priority = 1000,
		config = function()
			vim.cmd.colorscheme("onedark")
		end,
	},

	{
		-- Set lualine as statusline
		"nvim-lualine/lualine.nvim",
		-- See `:help lualine.txt`
		opts = {
			options = {
				icons_enabled = false,
				theme = "onedark",
				component_separators = "|",
				section_separators = "",
			},
		},
	},

	{
		-- Add indentation guides even on blank lines
		"lukas-reineke/indent-blankline.nvim",
		-- Enable `lukas-reineke/indent-blankline.nvim`
		-- See `:help indent_blankline.txt`
		main = "ibl",
		opts = {},
	},

	-- "gc" to comment visual regions/lines
	{ "numToStr/Comment.nvim", opts = {} },

	-- Fuzzy Finder (files, lsp, etc)
	{
		"nvim-telescope/telescope.nvim",
		branch = "0.1.x",
		dependencies = {
			"nvim-lua/plenary.nvim",
			-- Fuzzy Finder Algorithm which requires local dependencies to be built.
			-- Only load if `make` is available. Make sure you have the system
			-- requirements installed.
			{
				"nvim-telescope/telescope-fzf-native.nvim",
				-- NOTE: If you are having trouble with this installation,
				--       refer to the README for telescope-fzf-native for more instructions.
				build = "make",
				cond = function()
					return vim.fn.executable("make") == 1
				end,
			},
		},
	},

	{
		-- Highlight, edit, and navigate code
		"nvim-treesitter/nvim-treesitter",
		dependencies = {
			"nvim-treesitter/nvim-treesitter-textobjects",
		},
		build = ":TSUpdate",
	},

	-- NOTE: Next Step on Your Neovim Journey: Add/Configure additional "plugins" for kickstart
	--       These are some example plugins that I've included in the kickstart repository.
	--       Uncomment any of the lines below to enable them.
	-- require 'kickstart.plugins.autoformat',
	-- require 'kickstart.plugins.debug',

	-- NOTE: The import below can automatically add your own plugins, configuration, etc from `lua/custom/plugins/*.lua`
	--    You can use this folder to prevent any conflicts with this init.lua if you're interested in keeping
	--    up-to-date with whatever is in the kickstart repo.
	--    Uncomment the following line and add your plugins to `lua/custom/plugins/*.lua` to get going.
	--
	--    For additional information see: https://github.com/folke/lazy.nvim#-structuring-your-plugins
	-- { import = 'custom.plugins' },
}, {})

-- [[ Setting options ]]
-- See `:help vim.o`
-- NOTE: You can change these options as you wish!

-- Set highlight on search
vim.o.hlsearch = false

-- Make line numbers default
vim.wo.number = true

-- Enable mouse mode
vim.o.mouse = "a"

-- Sync clipboard between OS and Neovim.
--  Remove this option if you want your OS clipboard to remain independent.
--  See `:help 'clipboard'`
vim.o.clipboard = "unnamedplus"

-- Enable break indent
vim.o.breakindent = true

-- Save undo history
vim.o.undofile = true

-- Case-insensitive searching UNLESS \C or capital in search
vim.o.ignorecase = true
vim.o.smartcase = true

-- Keep signcolumn on by default
vim.wo.signcolumn = "yes"

-- Decrease update time
vim.o.updatetime = 250
vim.o.timeoutlen = 300

-- Set completeopt to have a better completion experience
vim.o.completeopt = "menuone,noselect"

-- NOTE: You should make sure your terminal supports this
vim.o.termguicolors = true

-- [[ Basic Keymaps ]]

-- Keymaps for better default experience
-- See `:help vim.keymap.set()`
vim.keymap.set({ "n", "v" }, "<Space>", "<Nop>", { silent = true })

-- Remap for dealing with word wrap
vim.keymap.set("n", "k", "v:count == 0 ? 'gk' : 'k'", { expr = true, silent = true })
vim.keymap.set("n", "j", "v:count == 0 ? 'gj' : 'j'", { expr = true, silent = true })

-- [[ Highlight on yank ]]
-- See `:help vim.highlight.on_yank()`
local highlight_group = vim.api.nvim_create_augroup("YankHighlight", { clear = true })
vim.api.nvim_create_autocmd("TextYankPost", {
	callback = function()
		vim.highlight.on_yank()
	end,
	group = highlight_group,
	pattern = "*",
})

-- [[ Configure Telescope ]]
-- See `:help telescope` and `:help telescope.setup()`
require("telescope").setup({
	defaults = {
		mappings = {
			i = {
				["<C-u>"] = false,
				["<C-d>"] = false,
			},
		},
	},
})

-- Enable telescope fzf native, if installed
pcall(require("telescope").load_extension, "fzf")

-- See `:help telescope.builtin`
vim.keymap.set("n", "<leader>?", require("telescope.builtin").oldfiles, { desc = "[?] Find recently opened files" })
vim.keymap.set("n", "<leader><space>", require("telescope.builtin").buffers, { desc = "[ ] Find existing buffers" })
vim.keymap.set("n", "<leader>/", function()
	-- You can pass additional configuration to telescope to change theme, layout, etc.
	require("telescope.builtin").current_buffer_fuzzy_find(require("telescope.themes").get_dropdown({
		winblend = 10,
		previewer = false,
	}))
end, { desc = "[/] Fuzzily search in current buffer" })

vim.keymap.set("n", "<leader>gf", require("telescope.builtin").git_files, { desc = "Search [G]it [F]iles" })
vim.keymap.set("n", "<leader>sf", require("telescope.builtin").find_files, { desc = "[S]earch [F]iles" })
vim.keymap.set("n", "<leader>sh", require("telescope.builtin").help_tags, { desc = "[S]earch [H]elp" })
vim.keymap.set("n", "<leader>sw", require("telescope.builtin").grep_string, { desc = "[S]earch current [W]ord" })
vim.keymap.set("n", "<leader>sg", require("telescope.builtin").live_grep, { desc = "[S]earch by [G]rep" })
vim.keymap.set("n", "<leader>sd", require("telescope.builtin").diagnostics, { desc = "[S]earch [D]iagnostics" })
vim.keymap.set("n", "<leader>sr", require("telescope.builtin").resume, { desc = "[S]earch [R]esume" })

-- [[ Configure Treesitter ]]
-- See `:help nvim-treesitter`
-- Defer Treesitter setup after first render to improve startup time of 'nvim {filename}'
vim.defer_fn(function()
	require("nvim-treesitter.configs").setup({
		-- Add languages to be installed here that you want installed for treesitter
		ensure_installed = {
			"c",
			"cpp",
			"go",
			"lua",
			"python",
			"rust",
			"tsx",
			"javascript",
			"typescript",
			"vimdoc",
			"vim",
			"bash",
		},

		-- Autoinstall languages that are not installed. Defaults to false (but you can change for yourself!)
		auto_install = false,

		highlight = { enable = true },
		indent = { enable = true },
		incremental_selection = {
			enable = true,
			keymaps = {
				init_selection = "<c-space>",
				node_incremental = "<c-space>",
				scope_incremental = "<c-s>",
				node_decremental = "<M-space>",
			},
		},
		textobjects = {
			select = {
				enable = true,
				lookahead = true, -- Automatically jump forward to textobj, similar to targets.vim
				keymaps = {
					-- You can use the capture groups defined in textobjects.scm
					["aa"] =<EMAIL_ADDRESS>					["ia"] =<EMAIL_ADDRESS>					["af"] =<EMAIL_ADDRESS>					["if"] =<EMAIL_ADDRESS>					["ac"] =<EMAIL_ADDRESS>					["ic"] =<EMAIL_ADDRESS>				},
			},
			move = {
				enable = true,
				set_jumps = true, -- whether to set jumps in the jumplist
				goto_next_start = {
					["]m"] =<EMAIL_ADDRESS>					["]]"] =<EMAIL_ADDRESS>				},
				goto_next_end = {
					["]M"] =<EMAIL_ADDRESS>					["]["] =<EMAIL_ADDRESS>				},
				goto_previous_start = {
					["[m"] =<EMAIL_ADDRESS>					["[["] =<EMAIL_ADDRESS>				},
				goto_previous_end = {
					["[M"] =<EMAIL_ADDRESS>					["[]"] =<EMAIL_ADDRESS>				},
			},
			swap = {
				enable = true,
				swap_next = {
					["<leader>a"] =<EMAIL_ADDRESS>				},
				swap_previous = {
					["<leader>A"] =<EMAIL_ADDRESS>				},
			},
		},
	})
end, 0)

-- Diagnostic keymaps
vim.keymap.set("n", "[d", vim.diagnostic.goto_prev, { desc = "Go to previous diagnostic message" })
vim.keymap.set("n", "]d", vim.diagnostic.goto_next, { desc = "Go to next diagnostic message" })
vim.keymap.set("n", "<leader>e", vim.diagnostic.open_float, { desc = "Open floating diagnostic message" })
vim.keymap.set("n", "<leader>q", vim.diagnostic.setloclist, { desc = "Open diagnostics list" })

-- [[ Configure LSP ]]
--  This function gets run when an LSP connects to a particular buffer.
local on_attach = function(_, bufnr)
	-- NOTE: Remember that lua is a real programming language, and as such it is possible
	-- to define small helper and utility functions so you don't have to repeat yourself
	-- many times.
	--
	-- In this case, we create a function that lets us more easily define mappings specific
	-- for LSP related items. It sets the mode, buffer and description for us each time.
	local nmap = function(keys, func, desc)
		if desc then
			desc = "LSP: " .. desc
		end

		vim.keymap.set("n", keys, func, { buffer = bufnr, desc = desc })
	end

	nmap("<leader>rn", vim.lsp.buf.rename, "[R]e[n]ame")
	nmap("<leader>ca", vim.lsp.buf.code_action, "[C]ode [A]ction")

	nmap("gd", vim.lsp.buf.definition, "[G]oto [D]efinition")
	nmap("gr", require("telescope.builtin").lsp_references, "[G]oto [R]eferences")
	nmap("gI", require("telescope.builtin").lsp_implementations, "[G]oto [I]mplementation")
	nmap("<leader>D", vim.lsp.buf.type_definition, "Type [D]efinition")
	nmap("<leader>ds", require("telescope.builtin").lsp_document_symbols, "[D]ocument [S]ymbols")
	nmap("<leader>ws", require("telescope.builtin").lsp_dynamic_workspace_symbols, "[W]orkspace [S]ymbols")

	-- See `:help K` for why this keymap
	nmap("K", vim.lsp.buf.hover, "Hover Documentation")
	nmap("<C-k>", vim.lsp.buf.signature_help, "Signature Documentation")

	-- Lesser used LSP functionality
	nmap("gD", vim.lsp.buf.declaration, "[G]oto [D]eclaration")
	nmap("<leader>wa", vim.lsp.buf.add_workspace_folder, "[W]orkspace [A]dd Folder")
	nmap("<leader>wr", vim.lsp.buf.remove_workspace_folder, "[W]orkspace [R]emove Folder")
	nmap("<leader>wl", function()
		print(vim.inspect(vim.lsp.buf.list_workspace_folders()))
	end, "[W]orkspace [L]ist Folders")

	-- Create a command `:Format` local to the LSP buffer
	vim.api.nvim_buf_create_user_command(bufnr, "Format", function(_)
		vim.lsp.buf.format()
	end, { desc = "Format current buffer with LSP" })
end

-- document existing key chains
require("which-key").register({
	["<leader>c"] = { name = "[C]ode", _ = "which_key_ignore" },
	["<leader>d"] = { name = "[D]ocument", _ = "which_key_ignore" },
	["<leader>g"] = { name = "[G]it", _ = "which_key_ignore" },
	["<leader>h"] = { name = "More git", _ = "which_key_ignore" },
	["<leader>r"] = { name = "[R]ename", _ = "which_key_ignore" },
	["<leader>s"] = { name = "[S]earch", _ = "which_key_ignore" },
	["<leader>w"] = { name = "[W]orkspace", _ = "which_key_ignore" },
})

-- mason-lspconfig requires that these setup functions are called in this order
-- before setting up the servers.
require("mason").setup()
require("mason-lspconfig").setup()

-- Enable the following language servers
--  Feel free to add/remove any LSPs that you want here. They will automatically be installed.
--
--  Add any additional override configuration in the following tables. They will be passed to
--  the `settings` field of the server config. You must look up that documentation yourself.
--
--  If you want to override the default filetypes that your language server will attach to you can
--  define the property 'filetypes' to the map in question.
local servers = {
	-- clangd = {},
	-- gopls = {},
	-- pyright = {},
	-- rust_analyzer = {},
	-- tsserver = {},
	-- html = { filetypes = { 'html', 'twig', 'hbs'} },

	lua_ls = {
		Lua = {
			workspace = { checkThirdParty = false },
			telemetry = { enable = false },
		},
	},
}

-- Setup neovim lua configuration
require("neodev").setup({
  override = function(_, library)
    library.enabled = true
    library.plugins = true
  end,
})

-- nvim-cmp supports additional completion capabilities, so broadcast that to servers
local capabilities = vim.lsp.protocol.make_client_capabilities()
capabilities = require("cmp_nvim_lsp").default_capabilities(capabilities)

-- Ensure the servers above are installed
local mason_lspconfig = require("mason-lspconfig")

mason_lspconfig.setup({
	ensure_installed = vim.tbl_keys(servers),
})

mason_lspconfig.setup_handlers({
	function(server_name)
		require("lspconfig")[server_name].setup({
			capabilities = capabilities,
			on_attach = on_attach,
			settings = servers[server_name],
			filetypes = (servers[server_name] or {}).filetypes,
		})
	end,
})

-- [[ Configure nvim-cmp ]]
-- See `:help cmp`
local cmp = require("cmp")
local luasnip = require("luasnip")
require("luasnip.loaders.from_vscode").lazy_load()
luasnip.config.setup({})

cmp.setup({
	snippet = {
		expand = function(args)
			luasnip.lsp_expand(args.body)
		end,
	},
	mapping = cmp.mapping.preset.insert({
		["<C-n>"] = cmp.mapping.select_next_item(),
		["<C-p>"] = cmp.mapping.select_prev_item(),
		["<C-d>"] = cmp.mapping.scroll_docs(-4),
		["<C-f>"] = cmp.mapping.scroll_docs(4),
		["<C-Space>"] = cmp.mapping.complete({}),
		["<CR>"] = cmp.mapping.confirm({
			behavior = cmp.ConfirmBehavior.Replace,
			select = true,
		}),
		["<Tab>"] = cmp.mapping(function(fallback)
			if cmp.visible() then
				cmp.select_next_item()
			elseif luasnip.expand_or_locally_jumpable() then
				luasnip.expand_or_jump()
			else
				fallback()
			end
		end, { "i", "s" }),
		["<S-Tab>"] = cmp.mapping(function(fallback)
			if cmp.visible() then
				cmp.select_prev_item()
			elseif luasnip.locally_jumpable(-1) then
				luasnip.jump(-1)
			else
				fallback()
			end
		end, { "i", "s" }),
	}),
	sources = {
		{ name = "nvim_lsp" },
		{ name = "luasnip" },
	},
})

-- The line beneath this is called `modeline`. See `:help modeline`
-- vim: ts=2 sts=2 sw=2 et

I'm facing the same issue on debian!

Same issue, but set one of two fields below to false will deduplicate the documentation.
-- set `runtime` to false
require("neodev").setup({
	library = {
		runtime = false, -- runtime path
		types = true, -- full signature, docs and completion of vim.api, vim.treesitter, vim.lsp and others
	},
})

or
-- set `types` to false
require("neodev").setup({
	library = {
		runtime = true, -- runtime path
		types = false, -- full signature, docs and completion of vim.api, vim.treesitter, vim.lsp and others
	},
})

Related: #175


ClueScroll Light Sources

Closes #9626
Credit to @Dava96 and PR #9628 for a baseline for this PR.
Created a VariableItemRequirement class to see if any light source is equipped or in inventory.

This looks like the same thing as using AnyRequirement with multiple SingleRequirements?

This looks like the same thing as using AnyRequirement with multiple SingleRequirements?

Would it be better to instantiate a list of ItemRequirements for all the light sources and just check that at least one of them is satisfied?

As was discovered in the Discord, the Braziers that can be lit after Making Friends with My Arm have varbits that control their state, and are globally available. Adding them as an extra check would be a good idea.

Do I need the changes from #9628? If I am understanding correctly, the only emote clue scroll that needs the light source is the one referenced there.

start with this: https://github.com/runelite/runelite/wiki/Code-Conventions, currently your PR is a bit messy because you do not have codestyle setup properly.


dont send ReadyForQuery after error response

the server needs to wait for Sync message from the frontend
before it sends ready for query message back to frontend
read and discard messages until a Sync is received

This is a lint issue that we need to remove unused imports.

Fixed the lint issue. Also made additional changes to read and discard messages from the socket until the Sync message is received. That behavior is documented in the postgres docs: https://www.postgresql.org/docs/current/protocol-flow.html#PROTOCOL-FLOW-EXT-QUERY

Thank you @poudels14

@poudels14 I'm running into an issue that psql hangs when error occurs. I investigated simple query message flow and the server actually sends ReadForQuery after error.

I just created #148 to fix that.


Provide documentation

Hey bro, I recently stumbled upon this your software, the prophit-bet software, I cloned it and decided to run the code, but I'm having problems like in the GUI you did not provide enough documentation about training models, again, most parameters in the new season like the HW and so on are saying 'nan', still on the documentation part again, I find it difficult to predict future games as there are not listed in the GUI. Please can you help explain these problems for me or provide a well documented Documentation. Thanks.

Yes I‘ve seen this problem too. At Jupiter League, German Bundesliga and more. If kochlisGit could give us a hint to solute this, it would be great. I thought the problem is the year 2021 in creating the league and change it to 2022, but I don‘t think so. The Brazilian Serie A or China Superleague are in their 2024 league and there are no problems with it.


bump cetz version

Updates fletcher to use the latest version of cetz

Unfortunately this change is not so innocent. There are quiet breaking changes in the update of cetz, and it also includes a license change that will effect fletcher too.

Ah, I did not see the MIT -> GPL license change. Likewise I didn't note any breaking changes affecting the typst-fletcher code that I had.


Add an option that can ignore the OR condition if it's an empty array.

Problem
I'm using the OR  + other condition to be the  where body.  Coz the OR is dynamic, So in the edge case, the OR is an empty Array. Usually, we think if it's empty so should match other condition and ignore it. But. the truth is. If OR is empty it will no longer match other conditions. will always return an empty result.
This is the code snip
const where = {
   isActive: true,
   OR: []
}

if(false){ // some time it's true
  where.OR.push({name:"a"})
}

this.findMany({where})

If OR is empty it will always return an empty result.
Now what I do is  add this line in logic
if(where.OR.length ===0 ){
 delete where.OR
}

It resolved my issue. but I guess maybe Prisma can do it better.
Suggested solution
What I suggested is. Can we add an option to let the query ignore the OR if it's empty? and set the default is false
like this
this.findMany({where, options:{ignoreEmptyCondition:true}})

so funny, that after year, this thing was not fixed :)

Please 🙏🙏🙏

Still ruin my production code. Still need to write additional useless code because of this bug :(

I think it's better to explicitly delete OR. Because it can become empty unintentionally and return whole collection.


Is it possible to disable or change ligature for <= in assignment statements?

Is it possible to disable ligature for <=, or change the font for it in assignment/comparison statements?
Fira code has both arrow and lte ligatures. Currently, the lte ligature is shown. ST4 doesn't currently support cv codes, so I could instead modify font and make the arrow ligature the default, but I also want to have the lte ligature in the correct places. Is it possible to achieve that?

This is more a SublimeText question, but last time I checked it's just not possible: the font can only have one glyph associated with "<=" : either an arrow or the less-than-or-equal, but you can't have both.


Document how to use tasty-discover with tasty-rerun ingredient

I've been looking all over the place for how to use the tasty-rerun ingredient with tasty-discover.
I've tried the following, but that's obviously wrong.
{-# OPTIONS_GHC -F -pgmF tasty-discover -optF --ingredient=Test.Tasty.Ingredients.Rerun.rerunningTests #-}
I've also tried adding the --rerurn option to the pragma but that doesn't work either.
Maybe the answer is obvious to experienced Haskell users. But for new users, like myself, the exact Pragma to get it running without much fuss will be appreciated.

Good question!
The problem is that tasty-rerun is not an ingredient, but an ingredient transformer. tasty-discover invariably generates T.defaultMainWithIngredients ingredients, while to invoke tasty-rerun one has to write T.defaultMainWithIngredients [rerunningTests ingredients].
Unfortunately, there is nothing we can do on the side of tasty-rerun: when you run tasty-discover, it is fully in control of code generation and cannot be affected by tasty-rerun. Could tasty-discovery possibly have a command-line flag to apply rerunningTests transformation? @mystilleef could you please raise this issue at https://git.coop/decentral1se/tasty-discover/-/issues?

Okay, I will.


No named exports edge case

Was just wondering about the case for a module without any exports, say only imports, where that module represents some ordered execution that should take place.
Currently the deferral would work, but there would be no way to trigger the execution without a named export.

It seems reasonable to me to disallow defer when no bindings are present?

I don't think it's a problem. The [[Get]] (or [[GetOwnPropertyDescriptor]]) on the ModuleNamespace exotic object can trigger the module execution, so accessing a non-existed property should be able to trigger the execution too.

@Jack-Works right but in this case there is no module namespace object.

I like @ljharb's proposal. The only reason modules without exports exist is because they have side effects, such as some initial setup of the environment. On the other hand, deferred imports are for "pure" modules, i.e. modules that don't have significant side effects so you can very safely delay their initialization.
If your module only executes side effects, and these side effects are not for the initial setup of the application, it should just export a function that can be later called at any time.


MK8 resolution graphics pack not being applied on character select screen in multiplayer

I'm using the 1.16.1 vulkan and graphics packs v587. In Mario Kart 8 I'm using the 4k graphics pack. On the character select screen for multiplayer, the models appeared to be rendered at the native resolution rather than 4k. Ingame in multiplayer it is indeed 4k, and in the singleplayer character select screen it is indeed 4k.

Thanks for reporting this issue! It should be upscaled if you update your graphic packs.


'SparsePauliOp.from_operator' can be optimized

What should we add?
Qiskit provides a functionality which can decompose a matrix into it's pauli sums. It is 'SparsePauliOp.from_operator'. Coincidently, I am working on a problem in qiskit which requires Pauli decomposition of any matrix. I have developed an algorithm which works approx 8-10 times better than the current algorithm in respect of time. I have tested the algorithm on many trail problems. Do you have any test cases so that I can check whether its performing as expected. And if it does I would like to contribute this code to qiskit library. I am new to github, so I'm not aware of the procedure. So can you guide me through it. Thank you.

Great to hear you're working on an improvement!
We have some explicit tests (not a lot though it seems...) in: https://github.com/Qiskit/qiskit-terra/blob/38132d80d30aa383e54fe82a32fb7c86035cda44/test/python/quantum_info/operators/symplectic/test_sparse_pauli_op.py#L155
If you have an update to the function you could replace the current SparsePauliOp.from_operator method with your implementation and run the test suite, see here for some guidance. If everything passes your code should be good 🙂
Since you're suggesting a performance improvement it would also be great to see a benchmark. Maybe you could time your function and our current one in some examples of varying sizes so we can see how it performs?

I have a matrix how to decompose and can you share your code
matrix =np.array([[1.1, 0,  0,  0,  0.3,  0,  0,  0],
[0, 1.1,  0,  0,  0,  0.3,  0,  0],
[0, 0,  0.9,  0,  0,  0,  0.3,  0],
[0, 0,  0,  0.9,  0,  0,  0,  0.3],
[0.3, 0,  0,  0,  1.1,  0,  0,  0],
[0,  0.3, 0,  0,  0,  1.1,  0,  0],
[0, 0,  0.3, 0,  0,  0,  0.9, 0],
[0,  0,  0, 0.3,  0,  0,  0,  0.9]])

SparsePauliOp.from_operator has recently been optimized in https://github.com/Qiskit/qiskit/pull/11133 and https://github.com/Qiskit/qiskit/pull/11557. The code is currently written in Rust and is based on the algorithm "tensorised-Pauli decomposition" described in https://arxiv.org/abs/2310.13421.
Do you have any suggestions for further optimizations or could this issue be closed?


Update aws-java-sdk-bundle to 1.12.333

Updates com.amazonaws:aws-java-sdk-bundle from 1.12.330 to 1.12.333.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #2387.


Deprecated & incorrect info

When creating a new Solidity project the Truffle migration uses truffle-hdwallet-provider. That provider has been deprecated a long time ago and instead @truffle/hdwallet-provider should be used
When trying to interact with the HelloBlockchain contract (via "Show contract interaction page") I get an error "the current provider doesn't support subscriptions: A". If I look at the used provider URI it uses https. If the interaction is supposed to use WebSockets this URI should use wss protocol.
After a few tries it fail to even open the "Show contract interaction page". It just says "no contract deployed" even if I redeploy it. No idea how this could be resolved.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df32d8b8-aa8f-b8da-3bc6-3fcba16be8bd
Version Independent ID: 71fdb7e0-bb97-f96a-84fc-778eeb590982
Content: Create, build, & deploy smart contracts tutorial - Azure Blockchain Service - Azure Blockchain
Content Source: articles/blockchain/service/send-transaction.md
Service: azure-blockchain
GitHub Login: @PatAltimore
Microsoft Alias: patricka

@microbecode  Thanks for the feedback! We are currently investigating and will update you shortly.
Adding author @PatAltimore as well for further insights.

@microbecode  Thanks for the feedback! We are currently investigating and will update you shortly.
Adding author @PatAltimore as well for further insights.

Hi @microbecode,
I'm sorry about the issue. We're working on a fix to the extension for questions 2 & 3.  See https://github.com/microsoft/vscode-azure-blockchain-ethereum/issues/57.
If you want to send a transaction without the interaction page, you can follow the steps in a previous version of the tutorial. Here's a link to the history: https://github.com/MicrosoftDocs/azure-docs/blob/faf74c90d878347089eb31f6a8457d5bebcc96b2/articles/blockchain/service/send-transaction.md.
Thanks for reaching out. Sorry for the inconvenience.
Hope that helps,
Pat

Hi @microbecode,
I'm sorry about the issue. We're working on a fix to the extension for questions 2 & 3.  See https://github.com/microsoft/vscode-azure-blockchain-ethereum/issues/57.
If you want to send a transaction without the interaction page, you can follow the steps in a previous version of the tutorial. Here's a link to the history: https://github.com/MicrosoftDocs/azure-docs/blob/faf74c90d878347089eb31f6a8457d5bebcc96b2/articles/blockchain/service/send-transaction.md.
Thanks for reaching out. Sorry for the inconvenience.
Hope that helps,
Pat

Hi @microbecode,
I gave the feedback for question 1 to the extension dev team. For 2 & 3, I have a backlog item to update the article with any changes as soon as the interaction page fix is complete.
Thanks again for the feedback. I'm going to request closing this issue for now since we have backlog items for the issues.
Thanks,
Pat
#please-close

Hi @microbecode,
I gave the feedback for question 1 to the extension dev team. For 2 & 3, I have a backlog item to update the article with any changes as soon as the interaction page fix is complete.
Thanks again for the feedback. I'm going to request closing this issue for now since we have backlog items for the issues.
Thanks,
Pat
#please-close

@microbecode I am prepping a release (1.7.0) which will have the update for the hdwallet-provider.  This requires a change to a base template used for new solidity projects and the code extension.  This release is targeted for release at end of January.
For the 2/3 items, the refactored smart contract interaction is still in progress and won't be in release 1.7.0 however I can push the bits up to a dev branch for early access soon.
Apologies on the lag here.

@microbecode I am prepping a release (1.7.0) which will have the update for the hdwallet-provider.  This requires a change to a base template used for new solidity projects and the code extension.  This release is targeted for release at end of January.
For the 2/3 items, the refactored smart contract interaction is still in progress and won't be in release 1.7.0 however I can push the bits up to a dev branch for early access soon.
Apologies on the lag here.

@caleteeter Thanks for the update.
I personally don't need an early access version, but maybe someone else does.

@caleteeter Thanks for the update.
I personally don't need an early access version, but maybe someone else does.


Better Log/Message Handling

Context
Implement better log handling to reduce the amount of redundant code throughout script files and standardized how messages are recorded.
Choices

Migrated logging to functions within the helper_functions utility script. Allowing for easy use anywhere and a single point to modify the look & feel of messages

Test instructions

Validate logging messages are being properly presented to the user

Checklist before requesting a review

[X] I have performed a self-review of my code
[ ] I've added documentation about this change to the README.
[X] I've not introduced breaking changes.

Hey there!
this has the changes from #345 aswell. Is that on purpose?

Nope - I'll sort out the git branch & request in the morning.
For now just put this into draft mode

Closing in favor of https://github.com/thijsvanloef/palworld-server-docker/pull/356


kernel: Add 4.19.8 config for x86

We want to make sure Kata runs on latest stable kernels so that it
benefits from the latest features.
For instance, in case of Kata relying on NEMU hypervisor, the recent
kernel patches reworking the way timer calibration is handled are
solving some boot latency issues.
Signed-off-by: Sebastien Boeuf<EMAIL_ADDRESS>

@jcvenegas here is the configuration that we need after I have reused the one from 4.14.x. The only thing I had to say Y was the new VIRTIO_MENU config option.
Both patches 0001(9p) and 0002(evged) applied properly. Problem with 0003 is that it's not needed since it's already part of the stable release 4.19.8. How do you want to handle this? I'm asking cause we have other architectures relying on 4.14.x, thinking about s390, that needs this patch.
Should we bump all architectures to 4.19.8? I don't have the hardware to check that what I'm doing is okay for other archs...
Let me know how we should proceed here.

/cc @rbradford

ping @kata-containers/kernel, @alicefr.

Hi~@sboeuf
I have already fired a PR #269 to bump arm guest kernel to 4.19.4 for supporting nvdimm on arm64.
And with regards to applying patches, in that pr, I have classified them based on arch.
I think that both patches 0001(9p) and 0002(evged) are generally applied  for all arches and 003 is just for s390x. Wdyt?

For Arm64, we’re welcome 4.19.x ;)

@Pennyzct 003 is s390 specific but it's applied to all arch. It could be that the patch doesn't apply to the 4.19. I need to check. The patch has been upstreamed since version 4.16

Otherwise I'll fix it and also generate the s390x configs :)

I think that in the master branch we should just keep one set of configs & patches that applies to the kernel version specified in runtime/versions.yaml, hence we should delete old configs  & patches.
We have stable- branches to keep older config versions.
The process should be:

update runtime/versions.yaml
update configs / patches in packaging

@Pennyzct would it be OK to converge to this same kernel version for ARM? It would make life easier for packaging.

hi~ @alicefr @marcov sure, let's keep one set. I will update my PR to follow the latest 4.19.8 and delete arch-dependent code in related PR. ;)

@marcov should I open a PR for the s390 configs?I still need to test the kernel but I can do it quickly

@Pennyzct thanks!
@alicefr you can open a PR to update the s390 config to 4.19.8, and thank you for testing it.

@marcov do I need to remove the s390 config 4.14 and the patch in the same PR? This PR https://github.com/kata-containers/packaging/pull/275 would also be worthless

@marcov @alicefr
Removing the patch 0003 from the list of patches would be ideal in a PR bumping s390 arch to kernel 4.19.8, and thanks for doing that :)
Once your PR lands, I'll rebase this one, without the need to handle the patch 0003.

@sboeuf sorry for the late response for next PRs to avoid conflicts with patches and kernel versions we need to move them to its own directory  4.18.x/patches etc

@sboeuf @marcov @Pennyzct I open a PR https://github.com/kata-containers/packaging/pull/281 that remove the 003 patch and adds the new s390 kernel config. If you decide to keep the 4.14 config let me know and I'll change my PR consequently

lgtm

lgtm


【控件】对话框，窗口内的弹框无法关闭

【控件】对话框，窗口内的弹框无法关闭
在新建的窗口中显示对话框，然后再次创建窗口，这样原窗口的对话框无法关闭

I tested but did not see any problem

I tested but did not see any problem


CI on master branch is broken

Describe the Bug
The CI is broken on master branch, caused by some format mismatch in round_trip tests.
You can see the errors here: https://github.com/rustwasm/walrus/runs/7362687785?check_suite_focus=true
failures:
---- tests_round_trip_anyref2_wat stdout ----
thread 'tests_round_trip_anyref2_wat' panicked at 'CHECK failed!
Did not find pattern
    CHECK: (module
    NEXT: (type (;0;) (func (param i32) (result externref)))
    NEXT: (func (;0;) (type 0) (param i32) (result externref)
    NEXT: local.get 0
    NEXT: table.get 0)
    NEXT: (table (;0;) 1 externref)
    NEXT: (export "a" (func 0)))
in output
    (module
      (type (;0;) (func (param i32) (result externref)))
      (func (;0;) (type 0) (param i32) (result externref)
        local.get 0
        table.get 0
      )
      (table (;0;) 1 externref)
      (export "a" (func 0))
    )
', crates/tests/src/lib.rs:182:9

Note that the generated code has extra line breaks for some closing )s.
I think it has been broken for quite a while, as many PRs are blocked by the same CI failure.
Steps to Reproduce
Just trigger a CI and you can see it. Or you can run cargo test -p walrus-tests --test round_trip locally to reproduce (be sure to install bynaryen and wabt first).

https://github.com/rustwasm/walrus/pull/232


[SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

What changes were proposed in this pull request?
This patch tries to keep consistency whenever UTF-8 charset is needed, as using StandardCharsets.UTF_8 instead of using "UTF-8". If the String type is needed, StandardCharsets.UTF_8.name() is used.
How was this patch tested?
Existing unit tests.

Test build #108548 has started for PR 25335 at commit e7e98cc.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #108548 has finished for PR 25335 at commit e7e98cc.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108548/
Test FAILed.

Test build #108556 has started for PR 25335 at commit f5d5355.

Test build #108556 has finished for PR 25335 at commit f5d5355.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108556/
Test FAILed.

+1 for this PR.

Test build #108561 has started for PR 25335 at commit 5b30e6c.

Even if I'm on vacation this looks simple enough to give a helping hand 🙂
Looks good but maybe 'import java.nio.charset.StandardCharsets.UTF_8' could be used all the places to save some characters.

Test build #108561 has finished for PR 25335 at commit 5b30e6c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108561/
Test PASSed.

Test build #108585 has started for PR 25335 at commit 42b1b89.

Test build #108585 has finished for PR 25335 at commit 42b1b89.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108585/
Test FAILed.

Thanks for the quick and detailed reviewing! Btw, is there any approach to enable build for both hadoop 2.7 and hadoop 3.2? Looks like this PR needs both and only hadoop-2.7 profile is enabled in build.

Test build #108592 has started for PR 25335 at commit 94bb1d6.

Test build #108592 has finished for PR 25335 at commit 94bb1d6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108592/
Test PASSed.

I don't think the PR builder can test vs 3.2, but we have a separate job for that. I don't see what might be different for 3.2 though?

retest this please

This patch touches various versions of hive-thrift server code which seems to require builds from both profiles (hadoop-2.7, hadoop-3.1).

Test build #108612 has started for PR 25335 at commit 94bb1d6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13697/
Test PASSed.

Oh I see your point. Can you try compiling with the 3.2 profile locally as a check? I think it will be fine in any event.

FWIW, I triggered the build against hadoop3.2 profile in this PR builder by changing its PR title.
Building Spark
========================================================================
[info] Building Spark using SBT with these arguments:  -Phadoop-3.2 -Pkubernetes -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos test:package streaming-kinesis-asl-assembly/assembly
...

Test build #108612 has finished for PR 25335 at commit 94bb1d6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108612/
Test PASSed.

I've run both builds locally (if I remember correctly) before pushing the last commit, and we've run both builds for the last commit, so unless we touch more, looks like it's good to go.

Thanks for the fix, @srowen . The change is fine. I didn't ask to put it out as you saw here.
However, the reviewers had better give a clear direction to the contributors and help them make better PRs next time.
Previously, I sometimes revised some PR descriptions by myself and informed them. And, it turns out that the contributors do not pay attentions on their next PR titles and descriptions more and more. That was not helpful for the community growth.
The problem I pointed in this PR was that this unintentionally disguised as an innocent PR replacing a string literal with the predefined one. (function signature change was not mentioned at all). This is very wrong because it makes the review harder. After merging this PR, the commit log will mislead the readers definitly.
That's the reason why I do nit-picking on the misleading PRs. Especially, PR title/description/patch consistency.

I understand the intention and appreciate the continuous effort on improving quality of commit message. Thanks!
There're some points I honestly have 2 cents:

The definition of 'good' varies to everyone. One example: now the commit title is far from guide in git commit, 50 characters vs 150+ characters. Even without tagging it exceeds 100 characters.
When contributors may not agree the guide of revising commit title or description (when they are having different perspective of 'good') but just follow the guide and change the title/description to let PR just merge in, nothing would be changed in further PR. We shouldn't expect it even we put effort to educate them. If we think something is mandatory to be included in the PR's title or description, we should discuss and document it explicitly. (Like #25310 - actually I'm not sure I could agree requiring contributors even describe "developer-facing" change though. Happy to see it excluded.)

The project seems to go on direction for asking more and more efforts on contributors, even on minors. Time is gold, not only for reviewers, but also for contributors. We may need to find some balance here.

We might want to always remind that we are not doing like reviewing minors with microscope while skimming the code change for 1000+ of lines. So many developers agreed on this old tweet: https://twitter.com/iamdevloper/status/397664295875805184 (It would be fun to go through the thread.) I'd rather say "importance" should be considered instead of "lines", but minors are minors, both code lines and importance.

I think we should update the guidelines to force something. If something doesn't comply to the guide line, we should fix. Otherwise, we call committer's judgement.
I agree @dongjoon-hyun's in general because I fix PR descriptions and titles too when it looks not well-formed by myself. I do nitpick too time to time but maybe we should avoid to nitpick too much.

I'm very sad to hear your complaint like the following that because I'm the one who tried to help you in several your PRs as a committer.

The project seems to go on direction for asking more and more efforts on contributors, even on minors. Time is gold, not only for reviewers, but also for contributors. We may need to find some balance here.

@HeartSaVioR . The only reason why the committers comments on your PRs is to merge your PR quickly. Otherwise, I'll will not be here. As you know as an Apache Storm PMC, if a committer feels a PR is mergeable, he become active on that PR to complete it quickly. It's not to sabotage it.

First of all, whatever my intention was, apologize my bad, I was pretty bad at representing my voices in formal way if you feel this as complaint. My 2 cents was not only for this PR but across all the mood in the project.
To be honest, I'd rather just follow whatever reviewers (especially someone with commit privilege) ask to fix it and don't say anything, if I just wanted to let commit be merged. Easiest way and no noise. If that's how the project works I would respect and just follow it.
What I pointed out is regarding some kind of preference which sometimes make contributors back and forth, as reviewers are not sharing consistent view. If we can see the values among community, we could reach a consensus in official discussion (either small or require votes) and require it. I'm afraid it can be educated, and it should be educated once someone feels it as preference. Honestly, the only way to correct it would be correcting time to time. Contributors can't read reviewers' mind in prior.

@dongjoon-hyun @HeartSaVioR My $0.02:
I do think it's ideal to keep the PR description up to date as it becomes part of the commit log. I don't know if it was a big deal in this case as the additional change was a minor internal refactoring, and we wouldn't exhaustively list every single change in the description.
I don't see harm in the reminder or implementing the one-line edit, so it was fine. It was minor but not nit-picky. This is a judgment call and this is part of a process of synchronizing that judgment.
There's a very good point here that minor changes inevitably get more scrutiny because there's less to look at. That's not great but it's nature. If you view the occasional microscopic review as more an exercise in communicating about standards, and something that happens when the substance of the change is straightforward, it makes more sense.
I'd also say we might review in more detail for people who are making many good contributions, as that person is growing into a reviewer too and perhaps on the path to committer, whereas it's not worth communicating this for a one-off contributor, and we might just let it go or fix it ourselves. Not great rationalizations, but it's not so bad.
You are right that reviewers don't even always agree, which is also just life. It can be frustrating if it's happening on your PR but is part of the process of synchronization. Reviewers do really need to bias towards finding consensus quickly.

We might be able to emphasize these details in the PR template
Reviewers should probably keep in mind the contributor's time, sure, and judge how much another round of minor changes 'costs' vs value
Contributors may just have to put up with a bit of this process of synchronization sometimes and, weirdly, I hope feel more included as a result

Thanks for the detailed voice, @srowen. I totally agree on your points.
I have to say again, my bad I admit I was a bit rushed on this: not all of my 2 cents apply to this PR but I made confusion that I'm complaint on these things for this PR. I have been struggled with getting review on major PRs for fairly long time and it still doesn't work (that's the main concern, honestly) so as a workaround I have to pick up minors hoping these minors would pass review phase easily, but I failed to isolate the root cause of my concern, and expressed concerns on the wrong place. Apologize to @dongjoon-hyun on this again. Sorry about that.
Likewise "synchronization of judgement" I still think providing consistent view among reviewers would be ideal to contributors. It's natural for reviewers to have different perspectives (sure I'm not blaming this. it's natural.), but once it's happening, ideally discussion should happen among reviewers (maybe including author as well if necessary) and guide as one direction to let contributors follow up without confusion.
It's pretty hard to get rid of individual's preference while reviewing, but it's ideal to try out - asking ourselves again what's the current practice of this project for this guide. Trying to educate without some documented guide might bring unintended reaction - feeling the guide as required to follow one's preference - and it wouldn't gonna work, really. That's the reason style guide exists, PR template exists, guide doc exists, etc.
Btw, maybe this would help reducing efforts if we do update PR's title/description for what we changed during review phase when we are just about to merge. Syncing-up PR's title/description with code changes would be non-trivial effort, especially code changes is still happening. If back-and-forth happens, experience of contributors would be going pretty bad, has to fix both code and PR. At least we could try to avoid this.

LGTM too. Just noticed you guys here are all pretty senior in OSS :).

Sorry again for the noise here, and thanks all for the detailed reviews, valuable feedbacks, and merge!

You raise a good point about not being able to get review attention sometimes @HeartSaVioR . Sometimes something isn't reviewed or merged because it's not obviously wrong, just not obviously worth it or important. That's a soft 'no' and I'd prefer to be more explicit about it, but sometimes that isn't received well.
Sometimes it's just that nobody has picked up that particular change to look at in the long stream of new issues each day, or the right person hasn't seen it. For example I honestly ignore SQL changes and focus on ML, core, docs, small changes.
We want people to ping when they honestly think it's an important change. Sometimes people ping too much ahead of their judgment, but that is not your case. My advice is always to use git 'blame' or Github to figure out who has been working on the code being changed and ping them. Sometimes Github's suggested reviewers are useful.
You can ping me on PRs you think are not getting reviewed and I'll review, and if I feel qualified and it's ready, can merge.


incorporate conflict resolution for marker tfr insert

Leverage existing upsert logic for preventing primary key issues during marker transfer event processing.

That sounds like it would be a good idea.
On Tue, Sep 14, 2021 at 10:04 PM Lee Duan @.***> wrote:

@.**** commented on this pull request.
In
service/src/main/kotlin/io/provenance/digitalcurrency/consortium/domain/MarkerTransfer.kt
https://github.com/provenance-io/digital-currency-consortium/pull/38#discussion_r708781130
:

@@ -18,17 +18,18 @@ object MarkerTransferTable : BaseRequestTable(name = "marker_transfer") {

open class MarkerTransferEntityClass : BaseRequestEntityClass<MTT, MarkerTransferRecord>(MTT) {
fun insert(fromAddress: String, denom: String, amount: String, toAddress: String, height: Long, txHash: String) =
Sounds like that bug we had awhile back where an exception i the event
stream handler started up a duplicate event stream thread. Maybe we need to
reconcile that we have that fix applied here?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/provenance-io/digital-currency-consortium/pull/38#discussion_r708781130,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEEIHXSJO62QJEABUKXD3TUB75K5ANCNFSM5EASHCSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
This message and its contents are confidential. If you received this
message in error, do not use or rely upon it. Instead, please inform the
sender and then delete it. Thank you.


Rev 0p8 release

Updates included in this PR:

Updated specs and testplan
Switched to MD format for release notes and update with 0p8 details Closing #8
Updated README.md timestamp
PR 103317: bugfix - 455868 - dlen restricts size of data response that may be read Closing #48
PR 102229: kv_crypto flow
PR 103177: fix for response data corruption bug issue 45
PR 103133: notif interrupt when soc tries to acquire lock but uC already has it
PR 103097: Basic SoC register tests
PR 103042: fixing bug in mailbox that would allow soc to clear execute register
PR 102817: Watchdog timer
PR 102845: Fixes for vault state machine spurious increments of offsets
PR 102748: Add zeroize to ECC
PR 100743: Mailbox Reset Testcases
PR 102362: New random reg access sequence for uvmf caliptra top
PR 102044: updated sha256_directe yml
PR 101424: New sequence and lint fixes
PR 101301: Fuse Register Tests
PR 101508: PCR Vault UVMF
PR 101462: Compatibility updates for TRNG build flow

Congrats on this PR. Very clean. And obviously high-five all around on the op8 milestone


Add socks5 support

I'm very proud we made that adapter design, which made adding this proxy very easy.

Right, it worked well. Thank you for the clean design.

What if the user chose multiple proxys? Do we want to allow that?

Good question. I just checked and the node fails to start if multiple proxies are specified on the command line:
error: the argument '--p2p-socks5-proxy <P2P_SOCKS5_PROXY>' cannot be used multiple times

Supporting multiple proxies or proxy chains should not be very difficult, but I don't think we should bother with that (Bitcoin Core does not support it).

This lacks tests.
... Adding TODOs or creating an issue is good enough for now.

TODO added.
And I tested the node with socks5 server (ssh -D) and it worked as expected.
I also switched from SocketAddr to String so users can use host names (for example, localhost:9050)


[Minor] Fix list column output in Gravitino CLI

What changes were proposed in this pull request?
Stop an error line being output in list columns CLI command.
Why are the changes needed?
It should not display an error.
Fix: # N/A
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested locally.

LGTM wrt the scope of this PR.


App asks for account reset, but web doesn't allow it

Hi,
I installed keybase app for Windows and signed in. Then I revoked the device and uninstalled the app and installed it again. Now the app says I need to reset my account , but that option is not showing up in menu on the website. See screenshots attached.

Tomas

i reset your account


Key phrases in other languages.

I was wondering if there is a list of requirements we need to make sure are fulfilled to be able to run this system to extract key phrases in other languages. It seems to me that at least the Stanford CoreNLP server should be called with an appropriate language model, and the trained model used by SENT2VEC should be set appropriately. Could you say more about this?

Yes you are totally right, in addition to the PosTagger and sent2vec , you also need to define rules to extract candidate phrases.


[SPARK-32183][DOCS][PYTHON] User Guide - PySpark Usage Guide for Pandas with Apache Arrow

What changes were proposed in this pull request?
This PR proposes to move Arrow usage guide from Spark documentation site to PySpark documentation site (at "User Guide").
Here is the demo for reviewing quicker: https://hyukjin-spark.readthedocs.io/en/stable/user_guide/arrow_pandas.html
Why are the changes needed?
To have a single place for PySpark users, and better documentation.
Does this PR introduce any user-facing change?
Yes, it will move https://spark.apache.org/docs/latest/sql-pyspark-pandas-with-arrow.html to our PySpark documentation.
How was this patch tested?
cd docs
SKIP_SCALADOC=1 SKIP_RDOC=1 SKIP_SQLDOC=1 jekyll serve --watch

and
cd python/docs
make clean html

cc @rohitmishr1484 and @fhoering FYI

Test build #127924 has started for PR 29548 at commit e8b52e4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32550/
Test PASSed.

Test build #127924 has finished for PR 29548 at commit e8b52e4.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127924/
Test FAILed.

Test build #127925 has started for PR 29548 at commit 268001e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32551/
Test PASSed.

Test build #127925 has finished for PR 29548 at commit 268001e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127925/
Test PASSed.

Thank you @viirya for reviewing this!

Test build #127979 has started for PR 29548 at commit 56af102.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32605/
Test PASSed.

GitHub Actions builds passed. Merged to master.

Test build #127979 has finished for PR 29548 at commit 56af102.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127979/
Test FAILed.

Sorry for the late review.. Looks great though, thanks!


Connect with OGC

The BC Oil & Gas Commission (OGC) is a single window regulatory agency with responsibilities for overseeing oil, gas and renewable geothermal operations.
(Single window are platforms that are government mandated and allow for the submission of information to fulfill regulatory requirements between economic operators and government authorities)

[x] Set up calendar invite
[x] Write questions for conversation
[x] Get feedback on questions

Hi @jaimiebutton - just clarifying, this is the interview that has been postponed until July?

Hey Lindsay, yes. We have another ticket for conducting the conversation that I'll keep in our backlog until then :)


Add Producer Scheduler Version to Block Header & Validate It

Any time there is a new set of producers it is added to the block header along with an incrementing version number. This set of producers becomes effective once the block becomes irreversible.
Light clients need to know when the block becomes irreversible so they can switch to the new schedule, but the current block headers requires light clients to process all headers (an indeterminate number) to find out when to apply the change.
A sparse light client needs to know when the active set changes in a more efficient manner.  To do this each block header will include the producer schedule version that applies for a given block. Full nodes will validate this number, light nodes will trust this number.  It should only ever increment.

Related PR is #1672

ATC:
Add more unit tests to producer_schedule_tests where it verifies:

Producer schedule version is updated (incrementally) inside the block header whenever a new set of producer schedule is applied
And ensure the unit test pass


Eliminate use of mktemp -- use mkstemp instead

The use of mktemp() results in an unsuppressable warning message
on certain compilers, including gcc.  This causes problems for
projects which have rules regarding warning-free compiles.
Use mkstemp instead. The problem with mkstemp is that it opens the
file instead of just returning a unique file name.  However, as a
side effect it does change the template to a unique file name.
This can be used similarly to the return value from mktemp.

Why not stay with mktemp on MSVC as e.g. here: https://github.com/tkelman/graphviz/commit/acdbce81a005e88fd6fffb998c97d27e6e1d303f ?

That is a valid alternative. To my eye, it dirties up the actual source code more with all the ifdefs in the code versus an ifdef up at the top in the "preamble" code.
Perhaps a better fix than either would be to encapsulate the mkstemp/mktemp changes in a static function.  The function would return the filename that should be used in the Mat_CreateVer call.  This would hide all ifdefs at the top and eliminate confusion as to why mkstemp() was being used just for the side-effect of changing the filename template.

Changes Unknown when pulling 62ed547a8b3a95868e7c2b2d21d77076745d1f4e on gsjaardema:master into ** on tbeu:master**.

Changes Unknown when pulling c1e5cb6bf39e5ef878f2ea79c2a3cf363e7cba7f on gsjaardema:master into ** on tbeu:master**.

Changes Unknown when pulling 62ed547a8b3a95868e7c2b2d21d77076745d1f4e on gsjaardema:master into ** on tbeu:master**.

Changes Unknown when pulling 62ed547a8b3a95868e7c2b2d21d77076745d1f4e on gsjaardema:master into ** on tbeu:master**.

Without the dependency on the hdf5 library I figured out a secure temp file creation in Mat_VarDelete using tmpfile (and thus avoiding the file name argument). However, as long as the hdf5 library does not support any secure temp file creation and management, I will not touch it. (HDF5 issue number is HDFFV-8703 from 2014.)
So, for now, I close this with wontfix.


fixed off-by-one length assignment to ensure (RFC 7946) compliance an…

First of all, I would like to thank the contributors behind Mapbox and all of its subprojects for their amazing work. I want to point out a small mistake that I found while re-writing some of the geo calculations for a library in GO, using Mapbox, amongst other projects, as a reference.
As per The GeoJSON Specification (RFC 7946). A Polygon consists of Linear Rings and a linear ring "... is a closed LineString with four or more positions", the reason for the four positions is that "The first and last positions are equivalent, and they MUST contain identical values; their representation SHOULD also be identical", i.e. to ensure the linear ring is closed the first and last position must be identical, deeming the first, or the last for that matter, position redundant and opens the door for some miscalculations similar to the one that I am attempting to fix in this PR.
The "-1" added in this PR solved two problems one is much simpler than the other but it is the main focus of this PR. The issues are:

The coordsLength > 2 in line 60 does not comply with the four positions requirement mentioned above, so a polygon with the invalid coordinates below would pass it, even though it is not a proper polygon (has less than four coordinates). [[[46.78401786031469,24.672371366746333 ],  [46.78401786031469, 24.69016675081427 ], [46.78401786031469, 24.672371366746333]]]

The second issue is in the calculations. The code cites the source  * Reference: Robert. G. Chamberlain and William H. Duquette, "Some Algorithms for Polygons on a Sphere", JPL Publication 07-03, Jet propulsion Laboratory, Pasadena, CA, June 2007 http://trs-new.jpl.nasa.gov/dspace/handle/2014/40409 then uses it properly, almost, at least. From this source we can see the calculation of the area:
"Assume we are dealing with a polygon with N vertices", after some work the equation becomes:

In this equation we have the same conditions as Geojson's polygons; N and 0 are identical. Thus the equation stops at N-1, i.e. the point just before the duplicate 0th point.
In the code, however, this is not the case, as it stops at the Nth point instead. This extra iteration on the Nth point results in an inconsistent behavior. For example, if we use this multipolygon:
{"type":"MultiPolygon","coordinates":[[[[28.321755510202507,16.35627490376781],[20.424575867090823,1.7575215418945476],[48.254218513706036,20.42650462625916],[36.310934132380964,14.226760576846956],[28.321755510202507,16.35627490376781]]]]}
We will get the good and rather accurate approximated area of:<PHONE_NUMBER>938.0227, but if we rotate the coordinates upwards, while maintaining the order and right-hand rule we will get the following calculations:<PHONE_NUMBER>938.023,<PHONE_NUMBER>938.0222,<PHONE_NUMBER>938.0227, and<PHONE_NUMBER>938.0227. The coordinates of each rotation are respectively:
[   [ 20.424575867090823, 1.7575215418945476 ], [ 48.254218513706036, 20.42650462625916 ], [ 36.310934132380964, 14.226760576846956 ], [ 28.321755510202507, 16.35627490376781 ], [ 20.424575867090823, 1.7575215418945476 ] ]
[[ 48.254218513706036, 20.42650462625916 ], [ 36.310934132380964, 14.226760576846956 ], [ 28.321755510202507, 16.35627490376781 ], [ 20.424575867090823, 1.7575215418945476 ], [ 48.254218513706036, 20.42650462625916 ]]
[[ 36.310934132380964, 14.226760576846956 ], [28.321755510202507, 16.35627490376781 ], [ 20.424575867090823, 1.7575215418945476 ], [ 48.254218513706036, 20.42650462625916 ], [ 36.310934132380964, 14.226760576846956 ]]
[[ 28.321755510202507, 16.35627490376781 ], [ 20.424575867090823, 1.7575215418945476 ], [ 48.254218513706036, 20.42650462625916 ], [36.310934132380964, 14.226760576846956 ], [ 28.321755510202507, 16.35627490376781 ]]
Now while the difference in the calculations is trivial, the inconsistency is, definitely, problematic and is caused by the the extra iteration on the Nth point. If we stop the iterations at N-1 we will get the consistent calculation of:<PHONE_NUMBER>938.0225.
I hope my points are clear, I am ready to clarify any unclear points if needed.

@tmcw

I stopped working at Mapbox and having commit access in 2017.

Oh that's weird, seems like you are the only person in thr contributors list, aside from one one-time contributor, do you know who should I mention?


ImageWMS UpdateParams - object is not extensible

Describe the bug
With React 18.2 / Node 18, i get a critical error when i try to update WMS params :
Uncaught TypeError: Cannot add property CQL_FILTER, object is not extensible
    at assign (<anonymous>)
    at ImageWMS.updateParams (ImageWMS.js:483:1)

My code :
componentDidUpdate () {
        ........
        cqlFilter = navigationType === "epci" ? `id_epci=${epci.siren}` : `id_com=${territoire.insee}`;
	carLayer.getSource().updateParams({
		CQL_FILTER: cqlFilter
	})
       .......
}

Here the OL code from ImageWMS that return an error (on Object.assign method):
https://github.com/openlayers/openlayers/blob/31a42949e6b81389bd1718dcdc5d03f0f7c3426c/src/ol/source/ImageWMS.js#L474-L479
Where :
this.params_ content is :
{
  CRS: "EPSG:3857",
  FORMAT: "image/gif",
  FORMAT_OPTIONS: "dpi%3A113",
  LAYERS: "xxxxx",
  STYLE: "default",
  STYLES: "",
  CQL_FILTER: "",
  TRANSPARENT: true,
  VERSION: "1.3.0"
}

And params content is :
{
  CQL_FILTER: 'insee="22300"',
}

To Reproduce
Update ImageWMS params with React.
Expected behavior
Update the ImageWMS params.

Was the params object you passed to the  constructor extensible?
https://github.com/openlayers/openlayers/blob/main/src/ol/source/ImageWMS.js#L109
Maybe this.params_ = Object.assign({}, options.params); would be safer at that line.

Was the params object you passed to the constructor extensible?

Saw default CQL_FILTER and STYLES missing from default options.params object.
Why couldn't we add new object to ImageWMS params like CQL_FILTER if not already defined ? Because sometime we need to add a new param. This works out of React (JS Vanilla).
Don't really understand this point.
Next, i try to change CQL_FILTER now and i get this error :
Uncaught TypeError: Cannot assign to read only property 'CQL_FILTER' of object '#<Object>'
Params  object :
{
  CQL_FILTER: 'insee="22300"',
}

this.params_ object (same as options.params):
{
  CRS: "EPSG:3857",
  FORMAT: "image/gif",
  FORMAT_OPTIONS: "dpi%3A113",
  LAYERS: "xxxxx",
  STYLE: "default",
  STYLES: "",
  CQL_FILTER: "",
  TRANSPARENT: true,
  VERSION: "1.3.0"
}

Maybe this.params_ = Object.assign({}, options.params); would be safer at that line.

Yeah, sur i dunno why we try to change params directly here.

Yes, that would be a good change to make. Pull request anyone?


Everything set up, but no logs are being fetched

Using ec2 VM (Ubuntu) and everything is set up: Gcloud, my Cloudflare credentials, Cronjob, scrips, etc.
In my GPC console, VMs, functions and storage are set up. APIs are enabled.
Can't figure out where is the problem. It happens that the logs aren't being fetched, as I can see at the *_logs bucket in my Google Storage.

Can you confirm that the GC Function is running properly? That is what pushes logs from storage to BigQuery.


chore: replace '::set-output' with '>> $GITHUB_OUTPUT'

Problem
GitHub Actions: Deprecating save-state and set-output commands
Summary of Changes
replace ::set-output with >> $GITHUB_OUTPUT

TBH, my second commit is not related to this PR's topic. If we would like to make the PR clear, I can make another PR for it.

I'll just go ahead and merge since it's late for you.  Feel free to merge on your own in the future though!

oh! Thank you haha 👻


Machine Translation, WMT14, and BLEU

Implemented the first machine translation scenario WMT14 and the adaptor/metric/etc. it relies on.
Fixes #1303
Usage
venv/bin/helm-run -r wmt_14:model=openai/davinci,language_pair=fr-en,max_train_instances=1 -m {MAX_EVAL_INSTANCES} -t {NUM_TRAIN_TRIALS} --suite 1
Results

Translation Direction
Ours (mean)
Ours (max)
GPT-3 Paper

fr->en
34.0
37.1
33.7

en->fr
25.5
31.1
28.3

The metric is sacrebleu.
The setting is 1-shot in-context learning. We use the same prompt used in the GPT-3 paper.
Our results are the mean/max over 5 training trials on 100 test examples; it is unclear how many trials OpenAI does or how many test examples they include. They likely use the whole test set, which include ~3000 examples.
OpenAI uses beam search for decoding while we use greedy decoding.

Can we make sure this is added to the next round of scenarios we'll run, that it loads reasonably quickly, and is it possible to throw up examples of the scenarios just to manually inspect them? (cc @yifanmai )


RoutingTest not working anymore

com.predic8.membrane.examples.tests.versioning.RoutingTest
looks like the service is no up anymore. Needs a review if we will fix that

Why don't we close the issue?


.babylon loading issue 2

This .babylon file loads fine on the playground (https://playground.babylonjs.com/#CU2WRV#5) but doesn't load on Babylon Native. I also tried to load the same .babylon file in experience.js and run it, and this error is printed in the console

I/BabylonNative: Unsupported buffer type createTexture@app:///Scripts/babylon.max.js:39055:36
Texture@app:///Scripts/babylon.max.js:97413:54
app:///Scripts/babylon.max.js:97856:42
Parse@app:///Scripts/babylon.max.js:141938:43
Parse@app:///Scripts/babylon.max.js:97808:97
Parse@app:///Scripts/babylon.max.js:141960:80
Parse@app:///Scripts/babylon.max.js:88329:98
loadAssetContainer@app:///Scripts/babylon.max.js:64513:93
load@app:///Scripts/babylon.max.js:65035:47
app:///Scripts/babylon.max.js:65902:39
dataCallback@app:///Scripts/babylon.max.js:65524:22
successCallback@app:///Scripts/babylon.max.js:65544:29
onReadyStateChange@app:///Scripts/babylon.max.js:143344:38

Also taking a look.

Also taking a look.

Tested OK on my Android device with this PR : https://github.com/BabylonJS/BabylonNative/pull/590
@filippograssi  Can you check now it's been merged into master?

Hello @CedricGuillemet , as for issue #585 everything is loading perfectly now. This model however (https://playground.babylonjs.com/#CU2WRV#6) I still can't load either on the Emulator and on my Android device.

I can repro! Trying to fix it now.

This is fixed.


support for pandas dataframes

pandas dataframes are ideal for working with Excel tables and pivottables. Dataframes are supported in xlwings.

+1

This has now been released as part of xlwings 0.7.0.


dcc_run: expose more code used by docido_contrib_crawlers

Coverage increased (+0.06%) to 92.955% when pulling f46f0893cc19e4f143b4f81558c742b7c0d0fdb2 on enh/share-dcc-run into 9e69b18d350892f83fc06d50c925aa3c43535058 on master.

Coverage increased (+0.07%) to 92.973% when pulling e65ec123437cf178f1487e9715483e0905e7b352 on enh/share-dcc-run into 9e69b18d350892f83fc06d50c925aa3c43535058 on master.

Coverage increased (+0.3%) to 93.169% when pulling 86d2f37d537586a6ff10fecc9dfe168090e2c0bc on enh/share-dcc-run into 9e69b18d350892f83fc06d50c925aa3c43535058 on master.

Coverage increased (+0.2%) to 93.117% when pulling 59a015b0fc233d4da4d03641d6a83f6cd12d6795 on enh/share-dcc-run into 9e69b18d350892f83fc06d50c925aa3c43535058 on master.


Minor formatting (proposals)

@kant thank for your contribution, however your commit is not signed.
See instructions here:
https://github.com/IBM/cap/blob/0b52b622a89d00ffa9a437ba2ec164a7f36342ac/docs/contributing.md

Proposal accepted but commit is not signed. Will apply the nits edits on another pr. Cheers.


Getting error on npm run start

Getting below error on npm run start in blockchain-explorer directory:
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>app-start: ./start.sh
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>app-start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Hi @tohammad
Please make the changes in the "start.sh" file as shown below. This worked for me.

Thank you!

I tried running explorer locally and found that it was failing for node v14 and v16, but worked with v12. You can try running it with v12

This issue regarding v14, v16 is fixed in the upcoming release, v2.0.0.


Updated Untyped Plutus Core Specification

This dependency affects the following Milestones:
Syntax of Plutus, as specified in the Plutus core specification
Semantics of Plutus, as specified in the Plutus Core specification

This dependency is related with documents:

Updated Semantics for Untyped Plutus Core (message)
https://docs.google.com/document/d/1l0V3hG1Ew7uqObnZ_Eq1ryYq0kKZiUMn1o7sr0ufeFs/edit?usp=sharing
Updated CEK machine transitions for type-erased Plutus Core
https://drive.google.com/drive/folders/0AAQtLO9q8bCLUk9PVA


UDP only received first message on ios 14

Description
Hi, I use this lib, but when run on ios 14, udp socket only received first message. I must restart app to listen again. Please help fix it.

Did you close right away? Do a Promise and return wait before you close so you can get all the messages. Remember UDP is an asynchronous operation.

No, I don't close socket until close app. I want listen many UDP message.

No, this bug is still on.


[Starter Packs] Failed to create starter pack

Steps to Reproduce
Two ways to trigger this:

trying to open a new starter pack with the minumum amount of people and no feeds
trying to change name or description of an existing starter pack

The error message is not descriptive enough for the user - did it fail because of app error or because of something the user did?
Attachments
No response
What platform(s) does this occur on?
Android, Web (Desktop)
Device Info
Google Pixel Pro 8 (Android 15) & Windows 11 (Firefox)
What version of the app are you using?
<IP_ADDRESS>3 ee184d2cd (prod)
Additional Information
No response

same issue. no matter what i do, it fails to publish my starter pack. but when i created a test pack, adding random users and feeds, it published successfully. i don’t know what is possibly causing my pack to fail to publish
i tried
-ipados app, ipad browser (safari), windows pc (firefox)
-adding more than the minimum amount of ppl (10-12 instead of 7)
-creating 3 empty feeds to add to the pack (i don’t want to add feeds and wasn’t adding them before)
-reducing pack description to below 300 characters (299 characters)
-censoring words in description that could trigger moderation (sexual terms) using an asterisk
at this point i am completely lost, i’ve been struggling to make this pack for about 2 hours and have zero clue why it isn’t working, especially bc it worked when i made a test pack halfway thru my attempts to make the real one. the only other detail about my pack that was different from the test one was that the title/description were bilingual (english with japanese translation)
there should be specific error messages for things such as the server just failing to process, title/description being blocked by automod (and say which phrase/s are the problem), description being too long (just add a character counter in the corner?), so on so on


Update Sonobuoy release

This could/should be a more clever, but this should do for now.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: TerryHowe
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [TerryHowe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jaxesn, TerryHowe
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [TerryHowe,jaxesn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


License

Thank you for creating this project.
Can you add a license ? (even though most of the original logic is from the Tailwind project). Thanks :)

Thanks for the interest!
A license was added in this commit.


[SPARK-15263][Core] Make shuffle service dir cleanup faster by using rm -rf

What changes were proposed in this pull request?
Jira: https://issues.apache.org/jira/browse/SPARK-15263
The current logic for directory cleanup is slow because it does directory listing, recurses over child directories, checks for symbolic links, deletes leaf files and finally deletes the dirs when they are empty. There is back-and-forth switching from kernel space to user space while doing this. Since most of the deployment backends would be Unix systems, we could essentially just do rm -rf so that entire deletion logic runs in kernel space.
The current Java based impl in Spark seems to be similar to what standard libraries like guava and commons IO do (eg. http://svn.apache.org/viewvc/commons/proper/io/trunk/src/main/java/org/apache/commons/io/FileUtils.java?view=markup#l1540). However, guava removed this method in favour of shelling out to an operating system command (like in this PR). See the Deprecated note in older javadocs for guava for details : http://google.github.io/guava/releases/10.0.1/api/docs/com/google/common/io/Files.html#deleteRecursively(java.io.File)
Ideally, Java should be providing such APIs so that users won't have to do such things to get platform specific code. Also, its not just about speed, but also handling race conditions while doing at FS deletions is tricky. I could find this bug for Java in similar context : http://bugs.java.com/bugdatabase/view_bug.do?bug_id=7148952
How was this patch tested?
I am relying on existing test cases to test the method. If there are suggestions about testing it, welcome to hear about it.
Performance gains
Input setup : Created a nested directory structure of depth 3 and each entry having 50 sub-dirs. The input being cleaned up had total ~125k dirs.
Ran both approaches (in isolation) for 6 times to get average numbers:

Native Java cleanup
rm -rf as a separate process

10.04 sec
4.11 sec

This change made deletion 2.4 times faster for the given test input.

Test build #58312 has started for PR 13042 at commit 32cc1e6.

ok to test

Test build #58312 has finished for PR 13042 at commit 32cc1e6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58312/
Test PASSed.

Test build #58332 has started for PR 13042 at commit 1877ad4.

Seems fairly reasonable; is the speedup measurable? wouldn't have thought so, but maybe for tens of thousands of files, sure.

Test build #58332 has finished for PR 13042 at commit 1877ad4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58332/
Test PASSed.

Merged build finished. Test PASSed.

Test build #58352 has started for PR 13042 at commit ed45e47.

as a linux adm, JFYI, you may encounter "too many arguments" error someday as described here:
https://linuxconfig.org/bash-bin-rm-argument-list-too-long-solution
just to make sure this will never happen - use find with -delete flag.
find /some/dir/ -name <name pattern> -delete

That LGTM; @podwhitehawk I don't think that will be a problem? the command is always rm -rf [dir]

Test build #58352 has finished for PR 13042 at commit ed45e47.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58352/
Test PASSed.

@podwhitehawk I agree with @srowen about single argument being passed.
Generally speaking, there is not a maximum path length in Unix but there might be restrictions on the length of each individual filename / dirname (this might be due to FS) [0]. Now its possible that the input dir is itself a super super large string and which might cause rm -rf to fail due to too large command. I would argue that even find .. -delete would be a victim of the same. Worse case, we are not able to cleanup the dir using Unix command.. but we still have backup from using Java IO (which I guess will also hit some limits because it will boil down to a system call).
[0] : https://www.quora.com/Why-does-UNIX-system-have-maximum-path-of-108-bytes

Test build #58439 has started for PR 13042 at commit 5170789.

Test build #58439 has finished for PR 13042 at commit 5170789.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58439/
Test FAILed.

ok to test

Test build #58499 has started for PR 13042 at commit da915ee.

Test build #58499 has finished for PR 13042 at commit da915ee.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58499/
Test FAILed.

Not sure of the build failure was related from my recent change(s). Retest please.

Jenkins add to whitelist

Jenkins retest this please

Out of curiosity, I wonder what the performance would be if you use java.nio.file.Files.walkFileTree... assuming it can be used in this case.

Test build #58511 has finished for PR 13042 at commit da915ee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58511/
Test PASSed.

@vanzin : I haven't gathered numbers with Files.walkFileTree. Based on its source code, it will have the same quirks wrt race conditions and speed. I believe that FileVisitor interface is suited for custom (pre, visit, post, failure) operations while visiting the tree.

There are no outstanding review comments left to address here. If everything looks good, can someone merge this PR ? Thanks !!

This seems OK to me. There is actually another delete-recursively method in TestShuffleDataContext in network-shuffle which should be able to use this method rather than define it again.
It seems like this could be usefully implemented in the main Utils.deleteRecursively as well, rather than have two differing implementations. I'm trying to figure out whether that's a win or poses any risks; it probably speeds up some big deletes but does mean spawning a process, in many cases at JVM shutdown.
If anyone's supportive of that we could try it here, but it's not essential

I am fine with changing TestShuffleDataContext to use the method in JavaUtil.
For Utils.deleteRecursively, I am not sure if that will have impact on other areas in the code due to extra process spawned. Will wait for 2 more days to see what rest folks think.

I'm OK with just the first change, for tidiness.

Test build #58701 has started for PR 13042 at commit a6eda94.

Ok. Changed TestShuffleDataContext to use the method in JavaUtil

Test build #58701 has finished for PR 13042 at commit a6eda94.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58701/
Test PASSed.

merged to master. I'm not against merging to 2.0.0 but wasn't sure how much of a perf problem this is in normal usage.


Update boringssl submodule

As a part of the 1.39 release
The boringssl commit being used is google/boringssl@bcc01b6c6

macos build failures are due to https://github.com/grpc/grpc/issues/26522


RUMM-1115: Prevent listing git ignored files

What does this PR do?
This change prevents listing patterns mentioned in .gitignore by switching from manual folder traversal to using git ls-files which respects this rule.
Review checklist (to be filled by reviewers)

[x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[x] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[x] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #24 (e9fe245) into main (b9dc769) will increase coverage by 6.81%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##               main      #24      +/-   ##
============================================
+ Coverage     80.43%   87.23%   +6.81%
- Complexity       97       99       +2
============================================
  Files            13       13
  Lines           281      282       +1
  Branches         37       36       -1
============================================
+ Hits            226      246      +20
+ Misses           46       23      -23
- Partials          9       13       +4

Impacted Files
Coverage Δ
Complexity Δ

...og/gradle/plugin/internal/GitRepositoryDetector.kt
85.19% <83.33%> (+65.95%)
4.00 <1.00> (+2.00)

...n/com/datadog/gradle/plugin/internal/ProjectExt.kt
100.00% <0.00%> (+18.18%)
0.00% <0.00%> (ø%)