ArgumentException thrown when invoked on a .PPTM or .PPTAM file

I got this exception while using the (excellent) OOXML Validator VS Code extension. The exact message was
Failed to run OOXML Validator. The error was: Unhandled exception. System.ArgumentException: file must be a .docx, .xlsx, or .pptx at OOXMLValidatorCLI.Classes.FunctionUtils.GetDocument(String filePath) in C:\source\OOXMLValidator\OOXMLValidatorCLI\Classes\FunctionUtils.cs:line 42 at OOXMLValidatorCLI.Classes.Validate.OOXML(String filePath, String format) in C:\source\OOXMLValidator\OOXMLValidatorCLI\Classes\Validate.cs:line 22 at OOXMLValidatorCLI.Program.Main(String[] args) in C:\source\OOXMLValidator\OOXMLValidatorCLI\Program.cs:line 20

The validator works well on .PPT and .PPTAM files, if they are renamed to .PPTX. So maybe the macro-enabled extensions could be allowed as well?

Hi @rajch , Thanks for the suggestion. I like the idea and adding more allowed file types would be a simple change, but I'm not sure the validation is really correct. I'm have not worked with .PPTAM files, but I have worked with .PPT.  And .PPT files are in a binary file format and .PPTX are based on Office Open XML (OOXML), which uses the Open Package Convention so a .PPTX is a zip file with a lot of xml files in it that has a .pptx extension. The validator uses a wrapper around the Open Xml SDK to validate those xml parts in the .pptx, .xlsx, or .docx file. I will have to check with that team to see if the validation works with other file types.
When you validated the renamed .PPT and .PPTAM files did the validator find any errors or did it say the file was valid?

Hi @mikeebowen
It found the exact validation error that my buggy code had introduced, and helped me solve my problem.
A PPTM or PPTAM is just a PPTX with some extra elements. It’s still OOXML, and so the validator should work without any changes. I assume the same is true for XLSM, XLSAM, DOCM et al.
I’ll be happy to beta-test, if you make the change.
Thanks for an awesome pair or products.
Regards
Raj
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows
From: Michael @.>
Sent: 17 January 2022 01:55
To: @.>
Cc: Raj @.>; @.>
Subject: Re: [mikeebowen/OOXML-Validator] ArgumentException thrown when invoked on a .PPTM or .PPTAM file (Issue #1)
Hi @rajchhttps://github.com/rajch , Thanks for the suggestion. I like the idea and adding more allowed file types would be a simple change, but I'm not sure the validation is really correct. I'm have not worked with .PPTAM files, but I have worked with .PPT. And .PPT files are in a binary file format and .PPTX are based on Office Open XML (OOXML)https://support.microsoft.com/en-us/office/open-xml-formats-and-file-name-extensions-5200d93c-3449-4380-8e11-31ef14555b18, which uses the Open Package Conventionhttps://en.wikipedia.org/wiki/Open_Packaging_Conventions so a .PPTX is a zip file with a lot of xml files in it that has a .pptx extension. The validator uses a wrapper around the Open Xml SDKhttps://github.com/OfficeDev/Open-XML-SDK to validate those xml parts in the .pptx, .xlsx, or .docx file. I will have to check with that team to see if the validation works with other file types.
When you validated the renamed .PPT and .PPTAM files did the validator find any errors or did it say the file was valid?
—
Reply to this email directly, view it on GitHubhttps://github.com/mikeebowen/OOXML-Validator/issues/1#issuecomment-1013946047, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACUBHOISHDUZXPTL77FSRWTUWMSR5ANCNFSM5MCQY4ZQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @rajch , Thanks for the kind words :-) I spoke with the Open Xml SDK team and you're right, the SDK can make and validate XLSM, XLSAM, DOCM, etc., so the extension can validate them. The OOXML Validator VS Code Extension is where the code needs to change for this, so could you please make a request for the feature on the repo for the OOXML Validator VS Code Extension and list all the file extensions you would like added. That will help me keep track of the feature and put it with the other issues for the extension.

Hi @rajch , update the extension to the latest and the validator will work on the additional file types.


docs: add info that storage is still unencrypted

Summary:
AsyncStorage is still unencrypted, so we need to be clear about this.
Test Plan:
None

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[ERROR DRT-0073] no ap for Instance/pin in a design with just 8% utilization

As mentioned in the Gitter discussion, I have been constantly getting the [ERROR DRT-0073] no ap for (...) when running the detailed_route step.
In an effort to find out the root cause for this issue I have reduced the design to a  Minimum Working Example - mwe.tar.gz.
This design example has   8% utilization, so this is should not be related with excessive routing congestion..
In order to easily replicate the issue, please proceed as follows:
Download mwe.tar.gz to OpenROAD-flow-scripts/ directory, untar it to OpenROAD-flow-scripts/mwe/ and then run:
docker run -it -u $(id -u ${USER}):$(id -g ${USER}) --mount type=bind,source=$(pwd)/flow/platforms,target=/OpenROAD-flow-scripts/flow/platforms --mount type=bind,source=$(pwd)/mwe,target=/mwe  openroad/flow-scripts

or, alternatively,  run
source mwe/run.sh

then inside the running docker container, run the following:
source setup_env.sh
openroad /mwe/cmd.tcl

Please let me know if there is something else I can do to aid in the debug.
Thank you in advance!

The problem is with STDLIB_3bdec cell, pin yz[0]. You are creating a port for each rect, when you could create a single port for all of them (at least for those that are in touch with each other). If you create a port for all the pin shapes it should work. Still, the macro definition is not wrong and I think TR should handle this situation, but if you want a quick solution, you can do as I suggested.

Putting touch shapes in different ports is wrong, see the LEF manual:
Each PORT of the same PIN is considered weakly connected to the other PORTs
If they are touching shapes they are not weakly connected.  We might be able to route anyways but it is not correct modeling.

Thanks for such a quick feedback.
I confirm that modifying the LEF in this way solves the issue and I am able to get a fully routed DEF on this design sample!
Still, I am now trying to do the same on the original design and I get this error one just one cell.
I am trying to check if this is still a LEF issue with the particular std cell.
Do you have any  hints on how to debug this kind of errors ?
Is there anyway to output a partial routed DEF file for debug whenever this kind of errors arise ?

I have been able to avoid this error by slightly changing the pin location of STDCELL.
Thanks very much for the great support.

I am sorry to re-open the issue, but could you please help me debug a similar error, on a different STD cell ?
This time I do not have weakly connected PORTs, so I guess it should be related with a different issue here.
The error I get is  [ERROR DRT-0073] no ap for I150_16581/s, which corresponds to the s port of a SR-latch.
The files are at:  Minimum Working Example 2 - mwe2.tar.gz
I really want to understand how to debug this issues so I can avoid them in future designs.
Thank you once again for the great feedback.

Hi zml, no worries.
For debugging, you can used the flag -gui when you call openroad, but you also need to add, in you cmd.tcl, before detailed_route command, the following command:
detailed_route_debug -pa
You can also use the flag -pin (for this command) to track a specific pin. Use the following format for pin name: :. Example:
detailed_route_debug -pa -pin inst0:A
However, I dont know if this will help much. My debugging required me to look at the code. But at least you can understand the context and narrow the error.
I will take a look on the new error right now.

The problem is that you have an obstacle over a small pin and TR is trying to create access points accessible only by vias.

I will further investigate why it is not allowing planar access.

@Stephanommg this sort of situation is what nearby grid APs were created for.  There is a similar situation in skywater.  I'm not sure if they are possible for this shape or not.  In general this isn't a good cell design practice.

This is the full picture with nearby aps. It seems that any via that will be used will be still close to the obstacle.

@zml By default TR doesnt allow planar access to access points in M1.

@zml you can set VIA_ACCESS_LAYERNUM in src/global.cpp to something less then 2 to allow planar access to those access points, but do this at you own risk since this is non-default in TR.

@zml By default TR doesnt allow planar access to access points in M1.

Just to make sure I am getting this right.
Does that  mean that TR will always try to connect with M2 + Via directly and would not try to create a vertical M1 path  ?
Because if simply increase M1 rectangle height of the  PIN s   as follows :
#        RECT 2.11 3.63 2.245 3.87 ;
          RECT 2.11 3.63 2.245 5.7 ;

The error no longer occurs.
Thanks

Right, in general routing on m1 may make other pins inaccessible.  To avoid those complications we just assume via access and check for compatibility of via access.  More work could be put into this area but that's the current strategy and it tends to work ok when pins are not blocked like this one.
Making the pin bigger likely means we find a way to drop a via on it and the problem is gone.

I get it. Many thanks.


Update sbt-softwaremill-common, ... to 2.0.7

Updates

com.softwaremill.sbt-softwaremill:sbt-softwaremill-common
com.softwaremill.sbt-softwaremill:sbt-softwaremill-publish

from 1.9.15 to 2.0.7.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sbt-softwaremill" } ]

labels: sbt-plugin-update, semver-major

Superseded by #537.


Facebook bot not receiving events

bot handle beachgenius.  We have the steps over and over again and cannot get our bot to work on facebook.  Works like a champ on skype.
we are getting these as issues
Cannot message users who are not admins, developers or testers of the app until pages_messaging permission is reviewed and the app is live - we are developing now so not sure why we see these

Cannot message users who are not admins, developers or testers of the app until pages_messaging permission is reviewed and the app is live

reconfigured it all and it is now working

haligasd,
can you please explain the reconfigured steps. I am also facing same issue.
please refer below link.
https://github.com/Microsoft/BotBuilder/issues/2510

i had the wrong page id / app id combo.  make sure configuration is setup.  also check the errors in the bot dashboard.  make sure your account you are testing with is a dev / admin in facebook


Signal problem

Describe the bug
Bazzite OS is installed on a PC connected to the TV.. If you first turn on the PC and then the TV, then the black screen, if in the reverse order, then everything is fine. The only thing that helps is rebooting with the power button or the keyboard shortcut Ctrl+Alt+Del.
What did you expect to happen?
I don't think this should happen.
Output of rpm-ostree status
No response
Hardware
No response
Extra information or context
No response

Is it working using a different linux distribution or using Windows ? Did you try with another HDMI cable ?

Before this, I installed Chimera OS with the same cable and did not experience such a problem.


Move metadata to post files

Keeping the post metadata in posts.edn requires you to make changes in two places when adding a new post, and also makes caching slightly more complex. As MultiMarkdown (the markdown flavour implemented by markdown-clj) has support for including metadata at the beginning of a file, we can move the metadata to the posts files themselves and not require posts.edn anymore.

I'm all for doing this and in fact, I did try to make this work before moving my blog to this library, but it had a couple of downsizes. The primary downside being having to read through all files when refreshing the index/archive/tags pages, but with the right caching in place, this should also be solveable.

So, PR welcome! Note that I'd like first see #12 to be solved since that's a regression.

@borkdude This can be closed now.


Use of a 'toy' function for pycairo fonts

I've searched how manim fonts were - loaded and i found the line https://github.com/ManimCommunity/manim/blob/faaeb89af98ed03160f44625907a3c231abbd84e/manim/mobject/svg/text_mobject.py#L314 . So i looked at pycairo documentation in order to understand how are fonts parsed and the doc tells that the function should not be used for production, only for "playing around" with cairo.
Note: The select_font_face() function call is part of what the cairo designers call the “toy” text API. It is convenient for short demos and simple programs, but it is not expected to be adequate for serious text-using applications.
``` on https://cairographics.org/documentation/pycairo/2/reference/context.html

I will try to work on it after school if you let me do so.

I think this has been said in #262 .
Unfortunately, as far as I know, there is no way to go around this limitation except by using an external library such as Pango, as mentionnée in the docs.
This is definitely something we should do.

Duplicate of #393

Thanks @MysaaJava, let's continue discussion in #393


Validate pseudo and conditional HTTP/2 headers

Motivation:
Netty HTTP/2 implementation is not 100% compliant to the spec ( https://github.com/netty/netty/issues/5761 ). This
commit improves the compliance regarding headers validation,
in particular pseudo-headers and connection ones.
According to the spec:

All HTTP/2 requests MUST include exactly one valid value for the
":method", ":scheme", and ":path" pseudo-header fields, unless it is
a CONNECT request (Section 8.3).  An HTTP request that omits
mandatory pseudo-header fields is malformed (Section <IP_ADDRESS>).

Modifications:

Introduce Http2HeadersValidator class capable of validating HTTP/2
headers
Invoke validation from DefaultHttp2ConnectionDecoder#onHeadersRead
Modify tests to use valid headers when required
Modify HttpConversionUtil#toHttp2Headers to not add :scheme and
:path header on CONNECT method in order to conform to the spec

Result:

Initial requests without :method, :path, :scheme will fail
Initial requests with multiple values for :method, :path, :scheme
will fail
Initial requests with an empty :path fail
Requests with connection-specific header field will fail
Requests with TE header different than "trailers" will fail
Fixes <IP_ADDRESS> tests from h2spec #5761
Fixes <IP_ADDRESS> tests from h2spec #5761

@netty-bot test this please

I've actioned PR feedbacks:

provided a way to disable validation
change the way we validate pseudo headers to be more efficient
move request/response validation from HPackDecoder to Http2HeadersValidator

Any other opinion? @ejona86, @Scottmitch ?

@ejona86 @carl-mastrangelo @bryce-anderson @Scottmitch @mosesn @rkapsi  so what we want to do with this ? Sorry I totally lost track of this one :/

@normanmaurer I like the idea of validation, but I don't know if I want to take on the performance penalty (Ctrl F for "bench" doesn't bring up anything).    In the case where most clients and servers are well behaved (i.e. both owned by the same party) it doesn't make sense to add so much validation.  Not sure this would catch any violations.
That said, if @madgnome can show that the default on case is not so expensive, following the spec more strictly can only be good for Netty users.

@madgnome @carl-mastrangelo @ejona86 @bryce-anderson what do we want to do with this one ? I think I am fine with adding this as long as we use a default of false for now. WDYT ?

I'm fine with introducing it with a default of disabled.

@carl-mastrangelo @ejona86 @trustin WDYT?

+1. Maybe better defaulting to 'enabled' and allowing to disable?

@trustin I am a bit afraid that this will break apps when upgrading ... you are not ?

Shouldn't we consider this as a bug fix? What requests that violate the validation rules in this PR could be sent in reality?

@trustin I think it is more about what @bryce-anderson mentioned at some point... It may hurt proxies.

What if we validate only pseudo headers and TE strictly and remove the connection headers from HTTP/1 then?

@bryce-anderson @ejona86 @carl-mastrangelo WDYT ?

Will there be an option to disable all this new validation? I'm not strongly opinionated about it unless we can't disable it.

Wouldn’t it be good enough to allow to disable this with all the other header validation?

Am 24.07.2019 um 22:13 schrieb Bryce Anderson<EMAIL_ADDRESS>Will there be an option to disable all this new validation? I'm not strongly opinionated about it unless we can't disable it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

rebased this one

@bryce-anderson sorry missed to tag you on my response...

@normanmaurer, yes, that should be fine if it can be disabled with the rest of the validation.

Let me merge this ... As stated it can be disabled with the rest of the validation and follows more closely the RFC. We will add a note in the release note.

@netty-bot test this please

@netty-bot test this please

@madgnome thanks a lot! Sorry for the long turn-around


Permission Issue

While using the plugin it does not work for anyone unless they are a operator. I've tried to use a couple of solutions such as reinstalling it, going through configs and even using lucky perms but with no solution or result.
Non operators/ Admins do not have access craft anything within the magic plugin, they do not have access to use magic even when given a magic wand with /mgive wand @ P.
And even with Operators and  Admins most of the time crafting is not working.

What permission plugin are you using?

Lucky perms

That's strange, LuckPerms (?) is what I use and test with. There have been some incompatible permission plugins in the past, but I thought we mostly had the kinks worked out.
Players shouldn't need any permission by default, and if you're not using any permission plugin players should be able to craft and use wands.
The only thing that would keep them from wands would be if you have specifically negated some permissions, like "" or "Magic." or something like that.
The fact that ops can use everything makes it sound more like a permission problem than an incompatibility of some kind.
But just in case, do you see any errors in your server logs or does Magic report errors to operators?

Well even ops don't have access to everything. Using the magic part of the magic plugin works but crafting isn't. This was and is an issue before using luck perms. I thought it would be of help but it didn't work. I'm using Shock byte as a server hosting if that helps. Also what do i do to send magic reports/errors?

There is no error reporting mechanism, but the plugin should tell you if there are errors in the logs when you log in.
Might be a good idea to check manually, though. If you'd like to attach your server logs here you can. I'd prefer it to be a clean startup, with you logging in then trying to craft or use a wand.
Can ops use a wand if given it via /mgive ?

The output of both /version and /magic would be best.

Here you go, for this one " you have to craft with the magic version of the items, so /mgive diamond|/mgive stick|etc. " it did work so its more of a crafting issue

https://medal.tv/games/minecraft/clips/iBLvQOMZtGeVFJOZ0/d1337xOzDcWS?invite=cr-MSxYZWcsMTYzNTk2OTQs

Ok, thanks a lot!
That does help, I'm able to reproduce the problem. I can't craft with naturally-spawned sticks or amethyst shards.
As you said, it only works with the versions I get from /mgive.
Those versions seem to have a "damage" component attached. I'm guessing my plugin is doing that somewhere, and shouldn't be.
I will need to track that down and release a fix- sorry for any trouble in the meantime!

No worries I will use this work around for now! Let me know when a fix becomes official and posted. I've been loving this plugin for what seems like 5ish years now! I think i've been using it since 2016 give or take a few years. So if I can be of help then I'd love to assist!

Thanks!
The crafting issue should be fixed in this dev build:
https://jenkins.elmakers.com/job/MagicPlugin/4298/
I'll need to release it asap, but you can use a dev build in the meantime if you want to test it out and let me know if it's all good :)
Do you think there were other issues besides the crafting? I think you mentioned something about non-ops not being able to use a wand even when given one?

Ill let you know about any other issues but the crafting is fixed! :D

The Music spell is not playing music


Please invite me to the community

Name
Chavas
Additional Context
I want to learn from each other and share my experiences.

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is a remarkable open-source solution tailored for serverless platforms, aimed at empowering creators to craft their infrastructure solutions. 💻 We're thrilled to welcome you into our vibrant community! ✨ We eagerly anticipate your valuable contributions! 🤓 Don't forget to explore our community on Github and connect with us on LinkedIn 💜 Feel free to spread the word about our community to like-minded individuals interested in development, DevOps, technology, and collaborative contributions. 👉💜👈


no .meteor.com anymore

This URL does not work
A sample blog app built with Mantra http://mantra-sample-blog.meteor.com/
cause there's no meteor.com anymore.

Yes, @arunoda you may need to host the demo app somewhere.


Setup on Vue Js 3

I tried to set it up on Vue Js 3 but seems I get blank page, this is already supported on Vue js 3?

I have not yet updated the plugin to support Vue3, but I plan to do so in early January.

Glad to hear that
Thank you for an update


Front refacto

new translation keys (the rest will come)
code cleaning
got fetch functions out of components
got switch statements out of components
creation of components

@mridha-emran  I've tried to test everything as much as I could, but please feel free to do monkey tests to make sure I haven't broken anything :)

everything is good only the signout(Déconnexion) button is not working. and maybe the icons are too small


Github action could not find factories

Tests works perfectly fine in local environment. However, when running in Github action using php artisan test, the factories seems not to be able to be detected:
Class "Modules\MyModule\Database\factories\MyModuleFactory" not found.
I modified phpunit.xml for php artisan test to work:
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
         bootstrap="vendor/autoload.php"
         colors="true"
>
<testsuites>
        <testsuite name="Unit">
            <directory>tests/Unit</directory>
            <directory>Modules/MyModule/tests/Unit</directory>
            <directory>Modules/MyModule1/tests/Unit</directory>
            <directory>Modules/MyModule2/tests/Unit</directory>

        </testsuite>
        <testsuite name="Feature">
            <directory>tests/Feature</directory>
        </testsuite>
    </testsuites>
    <source>
        <include>
            <directory>app</directory>
        </include>
    </source>
    <php>
        <env name="APP_ENV" value="testing"/>
        <env name="BCRYPT_ROUNDS" value="4"/>
        <env name="CACHE_DRIVER" value="array"/>
        <!-- <env name="DB_CONNECTION" value="sqlite"/> -->
        <!-- <env name="DB_DATABASE" value=":memory:"/> -->
        <env name="MAIL_MAILER" value="array"/>
        <env name="PULSE_ENABLED" value="false"/>
        <env name="QUEUE_CONNECTION" value="sync"/>
        <env name="SESSION_DRIVER" value="array"/>
        <env name="TELESCOPE_ENABLED" value="false"/>
    </php>
</phpunit>

Hi, I'm encountering an issue like this:
Check the folder name of factories and its namespace. Ensure that the first character of both is either upper case or lower case.

Yeah, I think I found the issue.
I just use the command php artisan module:make-factory MyModule MyModule and basically it makes a folder Factories containing the MyModuleFactory.php.
However,the basic laravel framework uses folder called factories instead of Factories. There is where the github action might got confused.


Basic working version of rotary-utils

In this PR, the basic skeleton of the rotary-utils package was set up with two utilities, the repair utility and the rotate utility. (Main, where I want to merge this PR, currently just contains the raw repair.py file ported from rotary.)
Major updates included in this PR:

meta.yml, pyproject.toml, and environment.yml files are now present for installation.
The package and its installation and usage are described in the README. (FYI, some README text was ported over from the rotary README, because rotary-utils code is being brought over from there. The rotary README will eventually be simplified, to remove some of the ported text, after rotary-utils starts to be used for the utility code.)
A main CLI script, rotary_utils.py, was created.
Some basic utilities (to be shared between future modules) were moved from repair.py to utils.py
A new module, rotate.py, was added. This module handles basic operations for rotating circular DNA elements and will be helpful for future code modules I will add. For now, a basic working version is included with a couple stub functions that will be expanded in future. Some functionality from rotate.py is used in repair.py.

rotary-utils repair and rotary-utils rotate pass end-to-end tests on my machine.
@LeeBergstrand Looking forward to review. Once this basic framework for rotary-utils is in place, I can start to add other modules into rotary-utils.

@jmtsuji, I noticed that you tended to space out some of your loops and statements.
   # Get the original (pre-stitched) contig sequence as a SeqRecord
    with open(input_fasta_filepath) as fasta_handle:

        for record in SeqIO.parse(fasta_handle, 'fasta'):

            sequence_names.append(record.name)

            if record.name in subset_sequence_ids:

                yield record

or
    if circlator_info['circularised'].sum() / circlator_info.shape[0] == 1:

        logger.debug('Everything is stitched.')
        result = True

    elif circlator_info['circularised'].sum() >= 0:

        logger.debug('Not everything is stitched.')
        result = False

    else:

        logger.error('File processing error. # of non-stitched contigs is not >=0. Exiting...')
        raise RuntimeError

When indenting, most developers I know do not put blank lines between each line of code. Instead, they blank lines to break out the code into logical blocks. The extra blanks make the code longer to scroll through, which takes time.
For Example:
There is only a blank line above the if statement to break it out from the rest of the loop. In this case, you could even remove that blank line, and the code would still be readable.
   # Get the original (pre-stitched) contig sequence as a SeqRecord
    with open(input_fasta_filepath) as fasta_handle:
        for record in SeqIO.parse(fasta_handle, 'fasta'):
            sequence_names.append(record.name)

            if record.name in subset_sequence_ids:
                yield record

or
Here, we remove the blank lines from the if elif else clause and break it out from the other code with lines. This makes it look like a switch statement, which it functionally is. As you can see, the indenting makes the code fairly readable, even with the blank lines removed.
    circlator_info = pd.read_csv(circlator_logfile, sep='\t')[['#Contig', 'circularised']]

    if circlator_info['circularised'].sum() / circlator_info.shape[0] == 1:
        logger.debug('Everything is stitched.')
        result = True
    elif circlator_info['circularised'].sum() >= 0:
        logger.debug('Not everything is stitched.')
        result = False
    else:
        logger.error('File processing error. # of non-stitched contigs is not >=0. Exiting...')
        raise RuntimeError

    return result

@jmtsuji, I noticed that you tended to space out some of your loops and statements.

@LeeBergstrand Thanks for these detailed tips -- they are very helpful! I've tried making my code styling more compact in my new updates to this branch -- let me know your thoughts.

@LeeBergstrand Thanks for your helpful last round of comments! I've made several updates to this PR after receiving your advice from the last code review and from #2. Most previous comments are now addressed (although you'll see a couple discussion threads above that are still active).
As one unexpected update, I ended up completing a basic working version of the rotate.py module and added it to this PR. (Because I accidentally introduced an incomplete version of this module into #2 as mentioned previously, I figured it would be better to just get a basic working version of the rotate.py module into this PR before this PR gets merged to main, rather than leave an incomplete version of this module in the code base.) The repair and rotate modules pass end-to-end testing on my end, based on almost the latest commit. I've updated the description at the top of this PR to reflect that rotate is now included.
Look forward to your review of this updated version -- thanks again for your input.

def generate_bed_file(contig_seqrecord: SeqIO.SeqRecord, bed_filepath: str, length_threshold: int = 100000):
    """
    Generates a BED file for a desired region around the ends of a contig.

    :param contig_seqrecord: SeqRecord of the contig
    :param bed_filepath: desired output filepath for the BED file
    :param length_threshold: length (bp) around the contig end to target in the BED file.
                             Half of this length will be returned around each end of the contig.
    :return: writes the BED file to the bed_filepath
    """

    contig_name = contig_seqrecord.name
    contig_length = len(contig_seqrecord.seq)

    logger.debug('Making BED file with end proximity threshold of ' + str(length_threshold))

    if contig_length < length_threshold:
        logger.warning(f'Contig length ({contig_length}) is less than the supplied length threshold '
                       f'({length_threshold}), so the BED file will be for the whole contig.')

The  :return: is generally only specified when the function returns a return value (i.e., the function returns a value later assigned to a variable in the calling program). Above and in several other places, you specify return value descriptions for functions that do not return values (i.e., there is no return at the end of the function). If we decide to do readthedocs down the road, the code for readthedocs parses the contents of the function doc string and turns it into a website. It could get confusing if the documentation starts specifying return values that don't exist. Instead, I would write the text you specify in the return value description to the function description.
def map_long_reads(contig_filepath: str, long_read_filepath: str, output_bam_filepath: str, log_filepath: str,
                   append_log: bool = True, threads: int = 1, threads_mem_mb: float = 1):
    """
    Maps long reads (via minimap2) to contigs and sorts/indexes the resulting BAM file. Writes output_bam_filepath and log_filepath to disk.
    """

The  :return: is generally only specified when the function returns a return value (i.e., the function returns a value later assigned to a variable in the calling program). Above and in several other places, you specify return value descriptions for functions that do not return values (i.e., there is no return at the end of the function). If we decide to do readthedocs down the road, the code for readthedocs parses the contents of the function doc string and turns it into a website. It could get confusing if the documentation starts specifying return values that don't exist. Instead, I would write the text you specify in the return value description to the function description.

@LeeBergstrand Thanks for the advice! I've now cleaned up the way that return is described in the docstrings, as you've suggested.

@LeeBergstrand I've implemented the code changes you've suggested and look forward to receiving your updated review. I would be OK to wait on changing the package name until a separate PR, if this is OK with you. Thanks!

@LeeBergstrand I've implemented the code changes you've suggested and look forward to receiving your updated review. I would be OK to wait on changing the package name until a separate PR, if this is OK with you. Thanks!

Changing the name in another PR works for me.

Merging into master as discussed in #14 . Thanks for your help with these improvements @LeeBergstrand !


Change user agent in header for mobile version of website

For http://example.com different html and js is rendered for mobile and desktop version. So is it possible to change page user agent as we do in phantomJS?

Ask this upstream please. https://github.com/giakki/uncss/issues


can´t download any voids...

Hello,
I was using TwitchLeecher 1.2.2 in my windows vista and updated to the most recent(1.3.9) and now when im downloading a void it goes 100% completed and give me 2 error afther:
-ffmpeg_x86exe - point of input not found (and stop working)
was not possible to find the point of input of procedure GetNumaNodeProcessorMaskEx in the library of hyperlink dynamics KERNEL32.DLL

when opening it appear a tiny error that can´t be read for being to small and not showing,twitchleecher only appear wen closing the error.

Logs:
Download task has been started!
TWITCH LEECHER INFO
Version: 1.3.9
VOD INFO
VOD ID: 150928602
Selected Quality: 1280x720@30fps
Download Url: https://www.twitch.tv/videos/150928602
Crop Start: Yes (00:00:00)
Crop End: Yes (00:01:00)
OUTPUT INFO
Output File: C:\Users\Administrador.luso\Downloads\20170610_150928602_IRL.mp4
FFMPEG Path: C:\Program Files\Twitch Leecher\ffmpeg_x86.exe
Temporary Download Folder: C:\Users\Administrador.luso\AppData\Local\Temp\TL_7a61d24a-9e3d-4c69-ac16-8f1b0050de10
ACCESS INFO
Token: %7B%22user_id%22%3Anull%2C%22vod_id%22%3A150928602%2C%22expires%22%3A1497306953%2C%22chansub%22%3A%7B%22restricted_bitrates%22%3A%5B%5D%7D%2C%22privileged%22%3Afalse%2C%22https_required%22%3Afalse%7D
Signature: 6764a106ef762130a3999fe50ca07fe4952353b6
Sub-Only: No
Privileged: No
Creating directory 'C:\Users\Administrador.luso\AppData\Local\Temp\TL_7a61d24a-9e3d-4c69-ac16-8f1b0050de10'... done!
Retrieving m3u8 playlist urls for all VOD qualities... done!
https://vod.edgecast.hls.ttvnw.net/2c4118aa1d84c91967ab_jasminemilktea_25479934480_661166397/chunked/index-muted-LXSMWXPI0Y.m3u8
https://vod.edgecast.hls.ttvnw.net/2c4118aa1d84c91967ab_jasminemilktea_25479934480_661166397/720p30/index-muted-LXSMWXPI0Y.m3u8
https://vod.edgecast.hls.ttvnw.net/2c4118aa1d84c91967ab_jasminemilktea_25479934480_661166397/480p30/index-muted-LXSMWXPI0Y.m3u8
https://vod.edgecast.hls.ttvnw.net/2c4118aa1d84c91967ab_jasminemilktea_25479934480_661166397/audio_only/index-muted-LXSMWXPI0Y.m3u8
https://vod.edgecast.hls.ttvnw.net/2c4118aa1d84c91967ab_jasminemilktea_25479934480_661166397/360p30/index-muted-LXSMWXPI0Y.m3u8
https://vod.edgecast.hls.ttvnw.net/2c4118aa1d84c91967ab_jasminemilktea_25479934480_661166397/160p30/index-muted-LXSMWXPI0Y.m3u8
Playlist url for selected quality 1280x720@30fps is https://vod.edgecast.hls.ttvnw.net/2c4118aa1d84c91967ab_jasminemilktea_25479934480_661166397/720p30/index-muted-LXSMWXPI0Y.m3u8
Retrieving playlist... done!
Parsing playlist... done!
Number of video chunks: 818
Starting parallel video chunk download
Number of video chunks to download: 6
Maximum connection count: 10
Parallel video chunk download is running...
Download of all video chunks complete!
Creating local m3u8 playlist for FFMPEG... done!
Writing playlist to 'C:\Users\Administrador.luso\AppData\Local\Temp\TL_7a61d24a-9e3d-4c69-ac16-8f1b0050de10\vod.m3u8'... done!
Executing 'C:\Program Files\Twitch Leecher\ffmpeg_x86.exe' on local playlist...
Command line arguments: -y -ss 0 -i "C:\Users\Administrador.luso\AppData\Local\Temp\TL_7a61d24a-9e3d-4c69-ac16-8f1b0050de10\vod.m3u8" -analyzeduration<PHONE_NUMBER> -probesize<PHONE_NUMBER> -c:v copy -c:a copy -bsf:a aac_adtstoasc -t 60 "C:\Users\Administrador.luso\Downloads\20170610_150928602_IRL.mp4"
Starting temporary download folder cleanup!
Deleting directory 'C:\Users\Administrador.luso\AppData\Local\Temp\TL_7a61d24a-9e3d-4c69-ac16-8f1b0050de10'... done!
Download task ended with an error!
System.AggregateException: Ocorreram um ou mais erros. ---> System.ApplicationException: An error occured while processing the video!
em TwitchLeecher.Services.Services.TwitchService.ProcessVideo(Action1 log, Action1 setStatus, Action1 setProgress, Action1 setIsProcessing, String ffmpegFile, String playlistFile, String outputFile, CropInfo cropInfo)
em TwitchLeecher.Services.Services.TwitchService.<>c__DisplayClass56_0.b__2()
em System.Threading.Tasks.Task.InnerInvoke()
em System.Threading.Tasks.Task.Execute()
--- Fim do rastreio da pilha de excepção interna ---
---> (Excepção Interna #0) System.ApplicationException: An error occured while processing the video!
em TwitchLeecher.Services.Services.TwitchService.ProcessVideo(Action1 log, Action1 setStatus, Action1 setProgress, Action1 setIsProcessing, String ffmpegFile, String playlistFile, String outputFile, CropInfo cropInfo)
em TwitchLeecher.Services.Services.TwitchService.<>c__DisplayClass56_0.b__2()
em System.Threading.Tasks.Task.InnerInvoke()
em System.Threading.Tasks.Task.Execute()<---
waiting for your answer on how to fix it..
cya

Sure it doesn't work. Windows Vista is neither supported by ffmpeg nor by TL. Why are you using such an ancient operation system that's out of support?

i don´t have a job to upgrade the system. so if this 1.3.9 is not for my pc, can i get old version that i was using and it was working?

nope, nothing lower than 1.3.7 will work because Twitch change their API over time and old versions of TL won't work anymore. I can't help you with this one, I'm sorry.

does tl work on tablets 4.2+?

only windows PC


Fix set_index(..., sorted=True) overlap issue

[ ] Tests added / passed
[ ] Passes black dask / flake8 dask

I just moved the fix_overlap created for multi.py into the actual set_index code, removing the possibility of a warning/error. Resolved #4860

At a glance, the CI failures look related. Does that sound right?

For anyone who has read my fix_overlap I have the following question: in general, if you're doing an operation that involves getting the ith partition of a Dataframe (here, I'm replacing partition[i] with concat(get_overlap(partition[i-1]), drop_overlap(partition[i]))), am I forced to construct the task graph explicitly and use HighLevelGraphs? Or is there something like map_partitions where you can access the index?

am I forced to construct the task graph explicitly and use HighLevelGraphs?

Typically for internal code we construct task graphs explicitly pretty often, unless there is some core operation like map_partitions aca, or map_overlap that would handle it for us.  In this case maybe map_overlap would work, if modified to accept index values rather than number of rows, but the way that you handled the problem seems natural to me.

@codercody do you need help working on the test failures?

No thanks. This has been on my todo list and I plan on doing it by Sunday. Sorry for the delay.

@codercody this seems like it is very close! It probably just needs a rebase and some test clean-up. Are you interested in taking that on?

Hi @jsignell, I have tried to finish this off in #6226 :)

Thanks @codercody, this was updated and merged in #6226.


RFC: bcbio in clinical sequencing

I was wondering if anyone is currently using bcbio in a regulated clinical space, i.e. for analyzing patient data. I am especially interested in existing frameworks providing HIPAA/CLIA/ISO 27001 compliance, i.e. systems that wrap bcbio and provide platform security architecture, access control, consistency of results (that can be done within bcbio itself, of course), auditability, availabilty, and mechanisms for tracking provenance to enable withdrawal of patient consent.
Obviously, we are not looking for using bcbio as diagnostic device (the horrors of FDA approval), but rather as a technology to characterize patient populations before clinical trials to augment our existing panels with more diverse genotypic data. I know that Curoverse is going in that direction and iRODS offers technology that aids in acquiring compliance, but none of these frameworks cover all of the issues.
If anyone has experience in these matters regarding bcbio and would be willing to give a pointer or be available for a quick chat I would greatly appreciate that - also after the holidays. Thanks a bunch.

Sven-Eric;
We're not currently running bcbio this way ourselves, but would love to move towards this goal. From the science side, there is not a fundamental difference between the needs in research and development labs and clinical practice except the time frames over which changes and updates can happen. Both need correctness, built in validation, and paths to stay on specific versions or move forward with new algorithms and approaches.
Practically, I know there are a lot of infrastructure and consistency mechanisms needed for compliance. Our in-progress plan is to move to using CWL for parallelization so we can work on platforms like Arvados that provide that infrastructure. This allows bcbio itself to focus on the biology and validation side of the work, and work with teams like Curoverse on the compliance issues. This is all still a work in progress but definitely something we'll be pushing for in the near future.
I'd love to hear other folks thoughts and experiences as well. Thanks so much for starting this discussion.

Hi Brad, Sven-Eric
We are also looking for an automated analysis pipeline for our diagnostic data. Since bcbio offers validated pipelines, this project would fit the bill. And judging by the roadmap set by Brad, bcbio will stay very relevant for us.
There are still some points that I'd like to adress however.

will bcbio support iRods datastores in the (near) future? or is there already support built it that I somehow missed?
are there plans for somewhat more robust sequencer integration? The LIMS interface in Galaxy hasn't been updated/ used in ages, and was deprecated by the dev's a while ago, so I'd really like something like a monitored folder where we can put the raw data, after which it gets processed and put into an output folder/datastore.

Thanks for al the work you've put in this already!
Cheers
M

Matt,
the LIMS integration has been on the todo list of my group for a while now. @guillermo-carrasco built a basic monitor that keeps an eye on the bcbio log files and reports events, but we'd have to add API calls (or have it reach out to the LIMS system). For the folder monitoring we've been looking at http://arteria-project.github.io/ and similar systems as the glue rather than trying to build this directly into bcbio as requirements probably vary widely between sites -- but that's my take, Brad might have a different view on this.
@brainstorm - when you were running bcbio at SciLife was there ever any integration with the iRods system?

When I was at SciLife, the only integration that we had with iRods was for backups. A tool we developed called TACA took care of moving the result files, FASTQs and everything we wanted to backup to our iRods store on regulare basis. @matthdsm maybe you're looking for something like that for that particular task, which I would personally separate from the analysis, i.e bcbio-nextgen.
This is the monitor @ohofmann pointed, let me know if you want to give it a try and run into any issue :-). As he said, for integration with any LIMS new API call should be added. This shouldn't be very complicated, but depends on how good the API of the target LIMS is.
Hope that helps a bit!

Hi all,
Thanks a lot for chiming in! I'll make sure to check each tool and give them a shot!
If I run into any issues, I'll create an issue in the appropriate repo, as not to pollute this one to much ;)
Thanks again!
M

He @matthdsm :-) TACA is quite SciLifeLab specific, so I'm not sur you can use other than the idea of it. I was doing a lot of developing in there though, so feel free to ask.

Matt, Oliver and Guillermo;
Thanks for all the discussion. For your specific questions we don't have immediate plans to support iRods or additional LIMs integration. Our current infrastructure plan is supporting the common workflow language (CWL: http://bcbio-nextgen.readthedocs.io/en/latest/contents/cwl.html) so that we can run bcbio inside platforms that provide this type of functionality. Since bcbio will have a generalized representation in CWL, it can then integrate with other infrastructure so we don't have to build out everything as part of bcbio.
The reasoning behind this is that we're not realistically going to have enough time to do all this work ourselves, so can take advantage of the strength of other tools while continuing to build out what bcbio does well. This will let us focus more of validations, tool integration and tackling harder problems with structural variation and cancer tumor heterogeneity.
Hope this provides some background behind our current work, and still makes bcbio useful for the work you're doing.

Hi Brad,
I'm replying to this post to get some follow up on the status of work done in bcbio regarding CWL. We currently have (almost) have bcbio up and running in our genetics context and are already looking to the future. We'd like to migrate from a regular cluster to a mesos cluster running bcbio in docker as part of bigger workflow.
Thanks
M

Thanks for following up. We're still actively working on CWL and following the path outlined in my last post. We are actively working on getting bcbio running with Toil, which supports CWL and has mesos integration:
http://toil.readthedocs.io/en/latest/
I have not personally worked with a Mesos cluster so don't have practical experience to share but the workflow of using bcbio CWL with Toil on it should hopefully support the type of system you're building out. Hope this helps.

So, as a late update on this topic: we have re-implemented the relevant bcbio workflows on a commercial  GxP-compliant, validated (CSV) sequence analysis platform that sits on top of iRODS and provides role-based access, SDTM export, chain-of-custody, audit logs and provenance tracking. I am happy to provide more info on personal contact.

Nice work

Sven-Eric -- wow, congrats that is great news. I'd definitely love to hear more details if you're able to share either publicly or via e-mail. Out of curiousity, how much of bcbio were you able to re-use? Did you have to re-implement entirely or are you able to use bcbio within your chosen platform? As you know one of our current goals is to make bcbio more portable to multiple platforms, so it would be useful to hear your practical experience with doing that right now. Thanks much for sharing and congrats again on all the hard work that must have gone into putting this together.

Curious as well. Happy to take this to email or a video chat. Auditing will start for as in Q1/Q2 2017.

Hi @schelhorn
Very happy to hear that, we'd be very interested to hear more about your experiences, as we're trying to accomplish the exact same thing!

Sure, I'd be happy to share our architecture and learnings in an academic/precompetitive setting. I'd suggest that whoever is interested in such a TC may contact me on LinkedIn and there send me an email address and time zone. I'll try to find a slot end of January/beginning of February and we can do a Skype call (preferred) or Hangout/Webex then.

Hi @schelhorn
Since I don't have a premium account, I'm not able to send you any "InMail". I did however send you an invite to connect. We're very interested to have a talk with you. You can find all contact info on my GitHub profile.
Thanks,
M

Sure, feel free to send me a contact request.


Remove Field without using component's Mount/Unmount

I have dynamic fields set up as per the Ant Design example https://ant.design/components/form/#components-form-demo-dynamic-form-item
However, I need to keep the form object to show another step of the submission process.
Luckily, getFieldDecorator() has a nice option called preserve: true that does exactly that.
Unfortunately though, this doesn't work nicely with dynamic fields.
When the user removes a field, the field stays in the form object, which is expected as the field is set to preserve.
I'd need a way to manually remove this field from the form object programmatically without relying on the mount/unmount of the component.
Reference to this issue from a while back #160

If you use my above example, you can see the issue I'm having/
Reproduce with this:

Add 3 fields
Input a value of 1, 2, 3 for each corresponding input box. So we can tell the difference.
Remove the 2nd field using the minus button.
Click "Next". -- The Form should now "Unmount" but the Form object will be preserved.
Click "Submit" and view the console.log
Console.log shows all names have been preserved

The dynamic example relies on the the field to be unmounted in order to delete it from the form object. However, I need these fields in order to submit them later on Page 2.
I need to use this in a much more complex way in my actual app but this is a simplification of the problem that I'm trying to solve.
Anybody have any ideas on how to solve this?

the same problem I meet


Table does not display all columns at 100% zoom

the table above only displays some of the columns, need to fix so it auto resizes instead of making the user scroll all the way to the bottom to realize that they can scroll right to see the remaining columns

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96467ddc-a592-f70e-2b1d-c9258984558b
Version Independent ID: 5ace59d8-2a58-e013-0bd6-8cce315783e2
Content: Supported Remote Desktop RDP file settings
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/rdp-files.md
Product: windows-server
Technology: remote-desktop-services
GitHub Login: @btaintor
Microsoft Alias: helohr

An existing alternative is to view the Github page, because it does not include the menu index on the sides and shows the table in full width:

https://github.com/MicrosoftDocs/windowsserverdocs/blob/master/WindowsServerDocs/remote/remote-desktop-services/clients/rdp-files.md

What creates the limitation in the first place is the top menu, dividing the page in 3: Left index, Center article, Right index (which is an empty placeholder in this case). I worry how long the table would become if it had been designed to fit 100% within the article width, but growing downwards as the columns got narrower.

The tables (yes, plural tables) were updated in commit https://github.com/MicrosoftDocs/windowsserverdocs/commit/4a33a6287001e55b69e9a3b67166299007092a0d (April 9, 2020), PR #4312 to be narrower and are now visible in 100% scale, at least on a screen resolution of 1920x1080 (full HD).

#please-close


[issue] No protocol specified

Hi @awjuliani ,
I am trying to run the obstacle tower on a remote machine without root credentials. Running it through ssh I get the following:
~/.obstacle/obstacletower.x86_64
No protocol specified
Found path: /home/stelios/.obstacle/obstacletower.x86_64
No protocol specified

Hi @Solliet
It seems that this error is not specific to Obstacle Tower, but instead related to the graphics set-up of your remote machine. Can you tell me a little more about what you have running on the machine?

The machine is running ubuntu 18.04 on an i7 8700k, nvidia 2080ti.
Simply executing ~/.obstacle/obstacletower.x86_64  causes the terminal to hangup. Running  xvfb-run --auto-servernum --server-args='-screen 0 640x480x24:32' ~/.obstacle/obstacletower.x86_64 --nographics results in: Found path: /home/stelios/.obstacle/obstacletower.x86_64 and then the terminal exits.

Hi @Solliet
Are you able to run any other Unity/ML-Agents binaries by chance? If not, then the issue might be best asked on the ML-Agents forums, or github page. Unfortunately I am not familiar with this issue myself.


runtime/debug: SIGSEGV in dumpgoroutine

From linux-ppc64le-buildlet in https://build.golang.org/log/e905b629a5a27c512d13fcbeffe416796327bba3:
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x18cbc]

runtime stack:
runtime.throw(0x15c4a9, 0x2a)
	/workdir/go/src/runtime/panic.go:1045 +0x5c
runtime.sigpanic()
	/workdir/go/src/runtime/signal_unix.go:573 +0x474
runtime.dumpgoroutine(0xc000001680)
	/workdir/go/src/runtime/heapdump.go:374 +0x23c
runtime.dumpgs()
	/workdir/go/src/runtime/heapdump.go:403 +0xa8
runtime.mdump()
	/workdir/go/src/runtime/heapdump.go:649 +0xc0
runtime.writeheapdump_m(0x7)
	/workdir/go/src/runtime/heapdump.go:672 +0x6c
runtime.runtime_debug_WriteHeapDump.func1()
	/workdir/go/src/runtime/heapdump.go:24 +0x2c
runtime.systemstack(0x0)
	/workdir/go/src/runtime/asm_ppc64x.s:269 +0x94
runtime.mstart()
	/workdir/go/src/runtime/proc.go:1069

goroutine 21 [waiting]:
runtime.systemstack_switch()
	/workdir/go/src/runtime/asm_ppc64x.s:216 +0x10 fp=0xc0001c4e50 sp=0xc0001c4e30 pc=0x6de00
runtime/debug.WriteHeapDump(0x7)
	/workdir/go/src/runtime/heapdump.go:23 +0x60 fp=0xc0001c4e90 sp=0xc0001c4e50 pc=0x17dd0
runtime/debug_test.TestWriteHeapDumpNonempty(0xc0000aa100)
	/workdir/go/src/runtime/debug/heapdump_test.go:25 +0x124 fp=0xc0001c4f60 sp=0xc0001c4e90 pc=0x103b54
testing.tRunner(0xc0000aa100, 0x15e690)
	/workdir/go/src/testing/testing.go:916 +0xc0 fp=0xc0001c4fb0 sp=0xc0001c4f60 pc=0xca1a0
runtime.goexit()
	/workdir/go/src/runtime/asm_ppc64x.s:884 +0x4 fp=0xc0001c4fb0 sp=0xc0001c4fb0 pc=0x703c4
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:967 +0x2ec

goroutine 1 [chan receive]:
testing.(*T).Run(0xc0000aa100, 0x158713, 0x19, 0x15e690, 0x301)
	/workdir/go/src/testing/testing.go:968 +0x308
testing.runTests.func1(0xc00008c000)
	/workdir/go/src/testing/testing.go:1209 +0x78
testing.tRunner(0xc00008c000, 0xc000054d88)
	/workdir/go/src/testing/testing.go:916 +0xc0
testing.runTests(0xc00000c060, 0x2455e0, 0x7, 0x7, 0x0)
	/workdir/go/src/testing/testing.go:1207 +0x27c
testing.(*M).Run(0xc00000a080, 0x0)
	/workdir/go/src/testing/testing.go:1124 +0x150
main.main()
	_testmain.go:58 +0x130

goroutine 9 [runnable]:
runtime.Goexit()
	/workdir/go/src/runtime/panic.go:608 +0x16c
testing.(*common).SkipNow(0xc00008c200)
	/workdir/go/src/testing/testing.go:749 +0x3c
testing.(*common).Skipf(0xc00008c200, 0x15def2, 0x4a, 0xc000078020, 0x1, 0x1)
	/workdir/go/src/testing/testing.go:735 +0x7c
internal/testenv.SkipFlaky(0x182500, 0xc00008c200, 0x4e6c)
	/workdir/go/src/internal/testenv/testenv.go:241 +0xe4
runtime/debug_test.TestSetGCPercent(0xc00008c200)
	/workdir/go/src/runtime/debug/garbage_test.go:114 +0x5c
testing.tRunner(0xc00008c200, 0x15e670)
	/workdir/go/src/testing/testing.go:916 +0xc0
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:967 +0x2ec
FAIL	runtime/debug	0.052s

CC @cuonglm @aclements @cherrymui

Seems a flaky for me, another fail https://build.golang.org/log/ac9672a53d4ece77dcb8acca1cf4a468c719cceb

Here's one on freebsd-arm-paulzhol: https://build.golang.org/log/47a67881527b85bd923b75d9aa910a7f62598790

This is on the line
		dumpint(uint64(uintptr(unsafe.Pointer(d.fn.fn))))

where d is a defer.
@danscales, didn't open-coded defers make it possible for there to be a defer object on the chain with _defer.fn set to nil?
Probably we should just emit nil in the heap dump in that case. To the extent that the heap dump is meaningful at all at this point, I think the defer records are only used to find roots the way the GC does, and the GC just ignores d.fn if it's nil.

The Goexit failure is discussed here
https://github.com/golang/go/issues/34575
On Sat, Oct 26, 2019 at 3:05 AM Cuong Manh Le<EMAIL_ADDRESS>wrote:

Seems a flaky for me, another fail
https://build.golang.org/log/ac9672a53d4ece77dcb8acca1cf4a468c719cceb
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/35172?email_source=notifications&email_token=ACH7BDFBHYMN4RAQ44MD6DDQQP24BA5CNFSM4JFLKWLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKCSSY#issuecomment-546580811,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACH7BDCMRBKB7VJLG2U6SATQQP24BANCNFSM4JFLKWLA
.


Add version: lencx.ChatGPT version 0.7.2

Pull request has been created with Komac v1.9.1 :rocket:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/115221&drop=dogfoodAlpha

@wingetbot run


Can't download from a tou.tv account. Site redesigned!

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.05.01. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.05.01

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: [u'--audio-quality', u'0', u'-o', u'%(title)s.%(ext)s']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'-u', u'PRIVATE', u'https://ici.tou.tv/unite-9/S05E01']
Type account password and press [Return]:
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.05.01
[debug] Python version 2.7.14+ (CPython) - Linux-4.15.0-2-amd64-x86_64-with-debian-buster-sid
[debug] exe versions: avconv 3.4.2-2, avprobe 3.4.2-2, ffmpeg 3.4.2-2, ffprobe 3.4.2-2, rtmpdump 2.4
[debug] Proxy map: {}
[tou.tv] Downloading homepage
ERROR: Unable to extract toutvlogin; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 789, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 439, in extract
    self.initialize()
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 397, in initialize
    self._real_initialize()
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/toutv.py", line 52, in _real_initialize
    r'(?s)toutvlogin\s*=\s*({.+?});', webpage, 'toutvlogin'), None, js_to_json)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 820, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract toutvlogin; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://ici.tou.tv/unite-9/S05E01

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
I doesn't have problem to download free content but it doesn't work when I want to download "extra" (premium) videos from an account, tou.tv have change their web site design recently. It worked less than a month with my account before the web site change. The tou.tv login script probably need a update for the new web site.
If you need a login to help you, I can give my account credential.
I hope that my English is not too bad!
Thanks for your help.
Erik.

It's geo-restricted to Canada.

@Altruo The geo-restriction just mean to developers outside of the Canada that want to help us need a Canadian IP thru a proxy or VPN to be able to work on the problem.

Also some of its content can be downloaded without an account (only Tou.TV Extra content needs a valid account).
Example: https://ici.tou.tv/infoman/S18E31

Sorry to say that, I doesn't have account anymore. Generally I subscribe a month to download premium content that's interesting and after I unsubscribe to save money.

I can provide an account if needed, let me know how to proceed.

That's the problem, it doesn't works for the premium contents, but only regular contents. Youtube-dl doesn't works anymore with the credentials (user & password (-u -p))  for that specific site. But it used to...
ERROR: Unable to extract toutvlogin; please report this issue on https://yt-dl.org/bug .
Make sure you are using the latest version; type  youtube-dl -U  to update.
Be sure to call youtube-dl with the --verbose flag and include its complete output.

Same problem here. Doesn't work for Extra contents even with appropriate credentials (user and password).

Unless it's just me, I am having this problem, but with content that doesn't require a subscription. See https://ici.tou.tv/terreur-404/S01B00

Hi. I'm from Montreal, Canada, and I have a premium account for tou.tv. I've started looking into this - it does stem from the UI re-design; tou.tv has moved the client-code generation into obfuscated scripting, which makes the old code no longer work. There might be a way around that.
But, be also aware that even if the login is fixed, more and more content of tou.tv will fail to convert for playback as it is tainted with DRM that only web-browsers can decode, so downloading/converting for offline playback will no longer be a possibility for a portion of the tou.tv content.

Great ! Thanks man that would be fantastic.
Merci

@tabarnakos / @alexhuot1 Did your fixes make it to the public release yet? I have 2<IP_ADDRESS> and even on non-georestricted emissions I receive "ERROR: radiocanada said: Exception has been thrown by the target of an invocation."

We are still waiting for the PR to be accepted. For now you can checkout master from my fork and test is the fix works.

Hello. Do anyone have codes to access to a Tou TV Extra account ?

@Meremptah unless you work on the project and it's for troubleshooting an issue, you have to pay for that.


Moving branch "tomcat-virtualhost-support" from wso2-dev to wso2 repo

This PR is to merge changes from branch "tomcat-virtualhost-support" from wso2-dev repo and contains old commits that reverts some of the required changes. Closing as vhost feature changes are already merged to master branch.


getting error repeatedly

📑 I have found these related issues/pull requests
Trace: TypeError: callback is not a function
at Socket. (/app/server/server.js:915:17)
at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
at process.emit (node:events:517:28)
at emit (node:internal/process/promises:149:20)
at processPromiseRejections (node:internal/process/promises:283:27)
at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
at Socket. (/app/server/server.js:915:17)
at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
at process.emit (node:events:517:28)
at emit (node:internal/process/promises:149:20)
at processPromiseRejections (node:internal/process/promises:283:27)
at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
at Socket. (/app/server/server.js:915:17)
at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
at process.emit (node:events:517:28)
at emit (node:internal/process/promises:149:20)
at processPromiseRejections (node:internal/process/promises:283:27)
at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
at Socket. (/app/server/server.js:915:17)
at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
at process.emit (node:events:517:28)
at emit (node:internal/process/promises:149:20)
at processPromiseRejections (node:internal/process/promises:283:27)
at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
at Socket. (/app/server/server.js:915:17)
at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
at process.emit (node:events:517:28)
at emit (node:internal/process/promises:149:20)
at processPromiseRejections (node:internal/process/promises:283:27)
at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
at Socket. (/app/server/server.js:915:17)
at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
at process.emit (node:events:517:28)
at emit (node:internal/process/promises:149:20)
at processPromiseRejections (node:internal/process/promises:283:27)
at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
at Socket. (/app/server/server.js:915:17)
at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
at process.emit (node:events:517:28)
at emit (node:internal/process/promises:149:20)
at processPromiseRejections (node:internal/process/promises:283:27)
at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
at Socket. (/app/server/server.js:915:17)
at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
at process.emit (node:events:517:28)
at emit (node:internal/process/promises:149:20)
at processPromiseRejections (node:internal/process/promises:283:27)
at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
at Socket. (/app/server/server.js:915:17)
at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
at process.emit (node:events:517:28)
at emit (node:internal/process/promises:149:20)
at processPromiseRejections (node:internal/process/promises:283:27)
at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
randomly get above error in docker logs
👟 Reproduction steps
i happens randomly
👀 Expected behavior
no such error should be there
😓 Actual Behavior
there re errors but not sure if it affects any services
🐻 Uptime-Kuma Version
1.0
💻 Operating System and Arch
Docker
🌐 Browser
Chrome
🖥 Deployment Environment

Runtime: Docker 27.3.1
Database: embedded
Filesystem used to store the database on: EXT4/SSD
number of monitors: 37

📝 Relevant log output
Trace: TypeError: callback is not a function
    at Socket.<anonymous> (/app/server/server.js:915:17)
    at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
    at process.emit (node:events:517:28)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
    at Socket.<anonymous> (/app/server/server.js:915:17)
    at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
    at process.emit (node:events:517:28)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
    at Socket.<anonymous> (/app/server/server.js:915:17)
    at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
    at process.emit (node:events:517:28)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
    at Socket.<anonymous> (/app/server/server.js:915:17)
    at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
    at process.emit (node:events:517:28)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
    at Socket.<anonymous> (/app/server/server.js:915:17)
    at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
    at process.emit (node:events:517:28)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
    at Socket.<anonymous> (/app/server/server.js:915:17)
    at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
    at process.emit (node:events:517:28)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
    at Socket.<anonymous> (/app/server/server.js:915:17)
    at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
    at process.emit (node:events:517:28)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
    at Socket.<anonymous> (/app/server/server.js:915:17)
    at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
    at process.emit (node:events:517:28)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues
Trace: TypeError: callback is not a function
    at Socket.<anonymous> (/app/server/server.js:915:17)
    at process.unexpectedErrorHandler (/app/server/server.js:1905:13)
    at process.emit (node:events:517:28)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues

We never could reproduce this in

https://github.com/louislam/uptime-kuma/issues/5010#issuecomment-2283550401

Please consider upgrading to v2

but its beta release, is it ok to upgrade it to beta version?

You can upgrade to the beta version via this guide: https://github.com/louislam/uptime-kuma/wiki/Migration-From-v1-To-v2


Temporarily skip verification due to broken image construction process.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Not tested in PR, merging.


Broken exception handling code in session-manager after logging cleanup.

Describe the bug
INFO:educates.workshopsession:Workshop session creation request for lab-k8s-fundamentals-w03-s001 being retried, retries 3.
ERROR:kopf.objects:Handler 'workshop_session_create' failed with an exception. Will retry.
Traceback (most recent call last):
  File "/opt/app-root/venv/lib64/python3.12/site-packages/pykube/http.py", line 437, in raise_for_status
    resp.raise_for_status()
  File "/opt/app-root/venv/lib64/python3.12/site-packages/requests/models.py", line 1024, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 409 Client Error: Conflict for url: https://<IP_ADDRESS>:443/api/v1/namespaces

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/app-root/src/handlers/workshopsession.py", line 737, in workshop_session_create
    pykube.Namespace(api, namespace_body).create()
  File "/opt/app-root/venv/lib64/python3.12/site-packages/pykube/objects.py", line 131, in create
    self.api.raise_for_status(r)
  File "/opt/app-root/venv/lib64/python3.12/site-packages/pykube/http.py", line 444, in raise_for_status
    raise HTTPError(resp.status_code, payload["message"])
pykube.exceptions.HTTPError: namespaces "lab-k8s-fundamentals-w03-s001" already exists

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/app-root/venv/lib64/python3.12/site-packages/kopf/_core/actions/execution.py", line 276, in execute_handler_once
    result = await invoke_handler(
             ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/venv/lib64/python3.12/site-packages/kopf/_core/actions/execution.py", line 371, in invoke_handler
    result = await invocation.invoke(
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/venv/lib64/python3.12/site-packages/kopf/_core/actions/invocation.py", line 139, in invoke
    await asyncio.shield(future)  # slightly expensive: creates tasks
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/src/handlers/workshopsession.py", line 740, in workshop_session_create
    if e.code == 409:
       ^
UnboundLocalError: cannot access local variable 'e' where it is not associated with a value

Additional information
No response

Original error that triggered it from a bad workshop definition was:
ERROR:kopf.objects:Handler 'workshop_session_create' failed with an exception. Will retry.
Traceback (most recent call last):
  File "/opt/app-root/venv/lib64/python3.12/site-packages/pykube/http.py", line 437, in raise_for_status
    resp.raise_for_status()
  File "/opt/app-root/venv/lib64/python3.12/site-packages/requests/models.py", line 1024, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 422 Client Error: Unprocessable Entity for url: https://<IP_ADDRESS>:443/apis/apps/v1/namespaces/lab-k8s-fundamentals-w03/deployments

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/app-root/venv/lib64/python3.12/site-packages/kopf/_core/actions/execution.py", line 276, in execute_handler_once
    result = await invoke_handler(
             ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/venv/lib64/python3.12/site-packages/kopf/_core/actions/execution.py", line 371, in invoke_handler
    result = await invocation.invoke(
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/venv/lib64/python3.12/site-packages/kopf/_core/actions/invocation.py", line 139, in invoke
    await asyncio.shield(future)  # slightly expensive: creates tasks
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/src/handlers/workshopsession.py", line 3109, in workshop_session_create
    pykube.Deployment(api, deployment_body).create()
  File "/opt/app-root/venv/lib64/python3.12/site-packages/pykube/objects.py", line 131, in create
    self.api.raise_for_status(r)
  File "/opt/app-root/venv/lib64/python3.12/site-packages/pykube/http.py", line 444, in raise_for_status
    raise HTTPError(resp.status_code, payload["message"])
pykube.exceptions.HTTPError: Deployment.apps "lab-k8s-fundamentals-w03-s001" is invalid: [spec.template.spec.containers[0].name: Invalid value: "<container-name>": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?'), spec.template.spec.containers[0].image: Required value]


Vickel: Blacklist martelgold.com

Vickel requests the blacklist of the website martelgold\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

martelgold\.com has been seen in 6 true positives, 0 false positives, and 0 NAAs.

Approved by Ryan M in Charcoal HQ


Documentation for how attesters use verifiers

related to https://github.com/Unirep/Unirep/pull/427
Documentation for

how to deploy verifiers
how to import verifiers in attester smart contracts
how to use it (decode and verify)

Merging with issue #472


Simd.js - Enable typespec of most remaining ops

This change contains the following:

Enabling type-specialization of most of the SIMD.js ops. Except ones taking bool args, and check ops.
Fixed GlobOpt/Lowerer to handle ops returning bools. Lowerer will take care of boxing the lane value as True/False
Fixed Unit-tests to call each method twice for type-spec for method-level full-JIT to kick in

Remaining work:

Enable ops with bool args
Enable CSE for all ops. This is currently blocked by #459

Most of the files changes are unit-tests.
@LouisLaf , can you please reveiw ?

This change is

@LouisLaf , I have update this to include several fixes based on ExprGen. Notable ones:

Keep InlineeBuiltInEnd after BailOnNoSimdTypeSpec insertion.
Set merged ValueTypes to definite, if we decided to keep the type-spec Simd value live.
On x64, canonicalize NaNs if extracted from Float32x4 value.
Bad entryInfo -> opcode mapping of Uint8x16 cmp ops

        Assert(IsLiveAsSimd128(stackSym, &block->globOptData));

We are losing an important assert here that the symbol is live somewhere...  This has found many bugs.  Can we have it back?

Refers to: lib/Backend/GlobOpt.cpp:2339 in f6ea7a3. [](commit_id = f6ea7a32097f30fb6fa232a0429ab31a47ac2bc2, deletion_comment = True)

    Assert(IsLiveAsSimd128(varSym, &block->globOptData));

Again, I'd like an assert that the sym is live as SIMD if we get here.

Refers to: lib/Backend/GlobOpt.cpp:13165 in f6ea7a3. [](commit_id = f6ea7a32097f30fb6fa232a0429ab31a47ac2bc2, deletion_comment = True)

return  IsSimd128TypeSpecialized<TySimd128F4>(sym, data) ||

if (func->HasSIMD() && (...))

Refers to: lib/Backend/GlobOpt.cpp:14412 in f6ea7a3. [](commit_id = f6ea7a32097f30fb6fa232a0429ab31a47ac2bc2, deletion_comment = False)

GlobOpt@2339
        Assert(IsLiveAsSimd128(stackSym, &block->globOptData)); We are losing an important assert here that the symbol is live somewhere... This has found many bugs. Can we have it back?
For GlobOpt@2339: I am assuming you are refering to:
StackSym * GlobOpt::GetSimd128EquivSym(BasicBlock * block, StackSym * sym, IRType &type)
{
        if (block->globOptData.liveVarSyms->Test(id))
        {
       ...
        }
        else if (block->globOptData.liveInt32Syms->Test(id) && !block->globOptData.liveLossyInt32Syms->Test(id))
        {
...
        }
        else if (block->globOptData.liveFloat64Syms->Test(id))
        {
...
        }
        else
        {
            stackSym = GetSimd128EquivSym(block, stackSym, fromType);
        }
}

GetSimd128EquivSym will check all liveness BVs, and if the sym is not alive as any Simd128 types, it will assert:
#define SIMD_GET_SYM(_TAG_) \
    if (IsSimd128TypeSpecialized<TySimd128##_TAG_##>(sym, &block->globOptData)) \
    { \
        type = TySimd128##_TAG_##; \
        return sym->GetSimd128##_TAG_##EquivSym(this->func); \
    }
    SIMD_EXPAND_W_TAG(SIMD_GET_SYM)
#undef SIMD_GET_SYM
    Assert(UNREACHED);
    return nullptr;

GlobOpt@13165:
Assert(IsLiveAsSimd128(varSym, &block->globOptData));
Again, I'd like an assert that the sym is live as SIMD if we get here.

GetSimd128LiveType will assert if sym is not live as Simd128. I will add an explicit assert there though, for clarity.

@LouisLaf, @MikeHolman, perhaps it is better to have func->HasSIMD() merged into release/1.2 ?
Since part of the BVs check overhead is already in the GlobOpt for the AsmJs implementation.  We can then rebase this change onto master and add the extra checks needed.

We will have HasSimd() in this PR only. The overhead is only two BVs in the globOpt in release/1.2, not worth duplicating the work. Let me know if you have other thoughts.

@LouisLaf , we added func->HasSimdOps(). Please take a look.

@nmostafa @LouisLaf any update on this?

@dilijev AFIK this PR is currently blocked by the TC39 decision on SIMD.js.

@arunetm If so, I'll add the corresponding tag.

@arunetm any update on this PR? Is it still blocked by TC39 decision? Is there a TC39 issue open to track that?

@nmostafa @arunetm ping. Any update here?

@dilijev TC39 has not made a decision on SIMD.js yet and the proposal is still at stage3. It was decided to leave this PR open at ChakraCore and revamp or close it once TC39 makes its final decision. I am keeping track of this PR and will update once I hear more about this. :)

@arunetm Thanks for the update!

SIMD.js has been moved back to stage 1 and is no longer considered an active proposal, as of March TC39 meeting. We can revisit if this changes in the future.


fix apiVersion and preview version being the same

When an apiVersion has a preview the matches the latest, we don't enforce the latest.  This should fix that...
Also added unit tests, we had very few so hard to track regressions.

#294 - also fixed


How to change quality list name,the m3u8 file have name tag

Hi Kutu,
How to change quality list name,the m3u8 file have name tag.
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=500000,RESOLUTION=640x360,NAME="360p SD"
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=800000,RESOLUTION=853x480,NAME="480p SD"
I do like quality switch list to show NAME(360p SD, 480p SD) content. can I custom text?
Thank You.

by changing source code


Added reponsive switch with minWidth

Test version of example.html here https://gist.github.com/galczo5/9a2df391e625b08e1cfea0d1c5d5ad18

perfect


bug: hit up, resend @-tagged file does not include the file, highlight the link, etc.

Version
Main a8d1fb32916d7f08ce26277cbbf0c186d5fb78f8
Describe the bug
Repro steps:

Start a chat
@-mention a file, chat about it.
Hit up to bring up the same message again, chat that.

https://github.com/sourcegraph/cody/assets/55120/b7a09274-c584-4905-9da6-9dd628c3457b
Expected behavior
Expected behavior: File is highlighted like a link, sent every time I mention it.
Actual behavior: File isn't highlighted like a link, I have just sent Cody the file name.
Additional context
No response

Related, if I @ and "type through" the autocomplete, then there's no file included. I feel like this is a good thing, because sometimes you do really want to talk about things that start with that symbol. So probably the chat history needs to remember, not only what the text of the message is, but where did that text come from?

shouldn't hitting Up and resubmitting a chat prompt do the same thing it did before?

I started looking at this, but it wasn't as straight forward as I thought. I pushed the changes that I started to https://github.com/sourcegraph/cody/pull/2473 and would like some pointers/validation that this I'm going in the right direction. Thanks!


AttributeError: 'CreateOnlyDefault' object has no attribute 'is_update'

I'm getting this exception when navigating to the doc page.  While there, none of the endpoints will expand.
I think it's probably related to declarations of model fields in the serializer.  The offending code is below.  Any ideas what might be going on here?  Looking at CreateOnlyDefault, is_update is only set when set_context is called, and apparently it isn't being called during API doc generation.
class Trail(models.Model):
    ...
    saved_search = models.ForeignKey(SavedSearch, on_delete=models.PROTECT,
                                     editable=False)

class TrailSerializer(serializers.ModelSerializer):

    ...
    saved_search = PrimaryKeyRelatedField(
        read_only=True, default=CreateOnlyDefault(TrailSavedSearchDefault()))

    class Meta:        # pylint: disable=C0111,C1001,W0232
        model = Trail
        # remove swift_password from response
        extra_kwargs = {'swift_password': {'write_only': True}}

And the exception:
Traceback (most recent call last):
  File "/Users/stanford/.virtualenvs/goldstone-server/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/Users/stanford/.virtualenvs/goldstone-server/lib/python2.7/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
    return view_func(*args, **kwargs)
  File "/Users/stanford/.virtualenvs/goldstone-server/lib/python2.7/site-packages/django/views/generic/base.py", line 71, in view
    return self.dispatch(request, *args, **kwargs)
  File "/Users/stanford/.virtualenvs/goldstone-server/lib/python2.7/site-packages/rest_framework/views.py", line 466, in dispatch
    response = self.handle_exception(exc)
  File "/Users/stanford/.virtualenvs/goldstone-server/lib/python2.7/site-packages/rest_framework/views.py", line 463, in dispatch
    response = handler(request, *args, **kwargs)
  File "/Users/stanford/.virtualenvs/goldstone-server/lib/python2.7/site-packages/rest_framework_swagger/views.py", line 164, in get
    'models': generator.get_models(apis),
  File "/Users/stanford/.virtualenvs/goldstone-server/lib/python2.7/site-packages/rest_framework_swagger/docgenerator.py", line 139, in get_models
    data = self._get_serializer_fields(serializer)
  File "/Users/stanford/.virtualenvs/goldstone-server/lib/python2.7/site-packages/rest_framework_swagger/docgenerator.py", line 328, in _get_serializer_fields
    'defaultValue': get_default_value(field),
  File "/Users/stanford/.virtualenvs/goldstone-server/lib/python2.7/site-packages/rest_framework_swagger/introspectors.py", line 54, in get_default_value
    default_value = default_value()
  File "/Users/stanford/.virtualenvs/goldstone-server/lib/python2.7/site-packages/rest_framework/fields.py", line 225, in __call__
    if self.is_update:
AttributeError: 'CreateOnlyDefault' object has no attribute 'is_update'
[10/Mar/2016 03:10:07] "GET /docs/api-docs/compliance HTTP/1.1" 500 134636```

A little digging suggest that this might be resolved in the next DRF release:
https://github.com/tomchristie/django-rest-framework/pull/2619

Closing out.


Host Docker image on GitHub instead of Docker Hub

We can simplify our setup by hosting the Docker image used for the documentation build by using GitHub's Container Registry. That will avoid the need for Docker Hub credentials management in GitHub, and also the creation of a DoWhy account on Docker Hub (currently we're hosting the image in personal accounts (first @petergtz's, now @darthtrevino's), which is not great).

@darthtrevino Would you say that's a sensible approach?

Hey Peter,
I'm all for publishing the container on GitHub; I ended up just extending the image you had published, and my contribution is in docs/Dockerfile. I think merging your base in would make sense though.

This all sounds positive to me.

@darthtrevino Ah, I remembered there was another Dockerfile somewhere, but couldn't remember. 👍 Okay, yea, let's simplify all that.

I ended up just extending the image you had published, and my contribution is in docs/Dockerfile

@darthtrevino Is https://hub.docker.com/r/darthtrevino/dowhy-docs built from this docs/Dockerfile, or is it built from https://github.com/darthtrevino/dowhy-examples-notebooks-deps-dockerfile/blob/main/Dockerfile?

Actually, I was able to answer my own question. I'm making the necessary changes and will post a PR soon.

@darthtrevino @emrekiciman So it turned out that the R dependencies are extremely brittle and what worked at the time to build the pego/dowhy-examples-notebooks-deps Docker image from https://github.com/petergtz/dowhy-examples-notebooks-deps-dockerfile already doesn't work anymore.
Alternative proposal therefore: we keep the image that I've built there at the time as a base image, but move it to Github container registry. We can also provide the Dockerfile for documentation purposes, so that we have a a reference on how this was originally built. But then use the dowhy/docs/Dockerfile as actual place to make adjustments.
The reason is that we probably don't want to get into the game of regularly fixing R dependencies, because this is extremely time-consuming and painful. Furthermore, this dependency on R should get on a deprecation path, where instead, we provide these causal discovery algorithms natively in Python. Once we're there, we can completely drop that base image.
What do you guys think?

How big would the impact be if we removed the rpy2 dependencies, in terms of example notebooks and library features?

I don't think it would be too significant.  The most significant usage is the first experimental version of causal discovery that calls out to CDT.  That is already being replaced by do-discover.
Then I've seen one example notebook that calls out to R only to load a sample dataset.  We should be able to find a work-around for that.  I don't think there are others but would have to check.

@darthtrevino Not sure if you've seen it, but I submitted

#695

to address this issue. Would love to get your review on it. The checks are not successful, but I'm not sure they can be successful as part of the PR.

@darthtrevino @emrekiciman I've removed the dependency on R for loading Lalonde in

#697