Interactive Snapshot Update mode

Fix https://github.com/facebook/jest/issues/1798
This pull request is introducing a new option in jest watch mode allowing people to update the failed snapshot of one test suite at a time.

It seems possible to update only the snapshot of 1 test, but I want to make sure my approach is correct.
I am having trouble to finish the tests for this change, especially the modification of watch.js. I tried to inspired myself from the packages/jest-cli/src/__tests__/watch-filename-pattern-mode-test.js file, but I would appreciate some advice. The file watch-snapshot-interactive-test.js is left in a "work in progress state".

This is great ❤. Can't wait to lay my eyes on the implementation and post some feedback.

Can't wait for the feedback.

@thymikee
I am getting this error while testing my branch
TypeError: Watcher is not a constructor
    at createWatcher (/Users/xt-pro/Dev/jest/packages/jest-haste-map/build/index.js:597:23)
    at Array.map (native)
    at HasteMap._watch (/Users/xt-pro/Dev/jest/packages/jest-haste-map/build/index.js:744:25)
    at _buildPromise._buildFileMap.then.then.hasteMap (/Users/xt-pro/Dev/jest/packages/jest-haste-map/build/index.js:276:21)
    at <anonymous>

Do you know by any chance what would create it? Thanks

Codecov Report

Merging #3831 into master will increase coverage by 0.27%.
The diff coverage is 80.48%.

@@            Coverage Diff             @@
##           master    #3831      +/-   ##
==========================================
+ Coverage   60.27%   60.55%   +0.27%
==========================================
  Files         198      200       +2
  Lines        6779     6855      +76
  Branches        6        6
==========================================
+ Hits         4086     4151      +65
- Misses       2690     2701      +11
  Partials        3        3

Impacted Files
Coverage Δ

packages/jest-cli/src/constants.js
100% <ø> (ø)
:arrow_up:

packages/jest-util/src/index.js
0% <0%> (ø)
:arrow_up:

...ackages/jest-util/src/get_failed_snapshot_tests.js
100% <100%> (ø)

packages/jest-cli/src/watch.js
69.56% <37.5%> (-4.42%)
:arrow_down:

packages/jest-cli/src/lib/terminal_utils.js
50% <40%> (-50%)
:arrow_down:

packages/jest-cli/src/snapshot_interactive_mode.js
96.15% <96.15%> (ø)

packages/jest-cli/src/reporters/utils.js
63.54% <0%> (+1.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c1d6a...45e4e1f. Read the comment docs.

@genintho could you rebase? Would love to see this land 🙂

Ping? Are we planning on merging this one?

I'd love to have it merged. CI is green, so it might be enough to just rebase it. I can have a look this evening

The error I commented above is still happening for me. Not sure what can cause it ATM.

Can you rebase and push?

Hey everyone! What is the status of this? A lot of people would love to have this feature but the PR is stale and needs a bunch of rebases.

this would be awesome to have! i can maybe rebase the branch and try to fix the conflicts.. is someone already working on this? maybe @genintho ?

Rebase done,
I can not make the following test pass,
 FAIL  integration_tests/__tests__/timeouts.test.js (9.343s)
  ● exceeds the timeout
  ● does not exceed the timeout

@genintho CI is green, thanks for rebasing!
@thymikee could you review again?

@SimenB If you could test the code changes too, that would be appreciated.

I guess this needs to be re-implemented to be a plugin for the watch mode?

Not necessarily I'd say. Btw, I'm keeping testing this feature on my little to-do list, it's just postponed a bit because of holiday.

If it can be implemented as a plugin, that would be preferable. But it's not a necessity for merge, I'd say 🙂


stepValue isn't defined and keeps "running"

Using this handy script on a website, checked the browser error log (firefox & chrome) and see the following:

My code is:
$('.first.circle').circleProgress({
 value: 0.6,
 emptyFill: "#F4F4F4",
 size: 150,
 fill: { color: "#3BB9BC" }
}).on('circle-animation-progress', function (event, progress) {
 $(this).find('strong').text(String(stepValue.toFixed(2)).substr(1));
});

This won't cause an issue for sites using 1 progress circle but if you have a few then having a script constantly "running" (the bottom number keeps increasing), could that effect the speed of the website?
p.s. using jquery 1.11.1 and 1.12.3 (upgraded incase it was an issue with the older version).
Is there a fix for this, I did try setting stepValue as a variable but it removes the %age count.

You aren't defining the variable stepValue.
stepValue = $(this).data('value');

I used the example #3 from http://kottenator.github.io/jquery-circle-progress/examples.js which doesn't define the stepValue but works fine....
Tried your code and doesn't work either,
$('.first.circle').circleProgress({   value: 0.6,   emptyFill: "#F4F4F4",   size: 250,   fill: { color: "#3BB9BC" }  }).on('circle-animation-progress', function (event, progress) {   var stepValue = $(this).data('value');   $(this).find('strong').text(String(stepValue.toFixed(2)).substr(1));  });

Perhaps you haven't a data attribute named data-value on your <div>? If that's the case, & looking at the API, it states you can get the value with:
var value = $('.circle').circleProgress('value'); // 0.5
Updating the code above, you'd use the progress multiplied by the value.
$('.first.circle').circleProgress({
    value: 0.6,
    emptyFill: "#F4F4F4",
    size: 250,
    fill: {
      color: "#3BB9BC"
    }
  }).on('circle-animation-progress', function(event, progress) {
      var value = $('.circle').circleProgress('value') * progress;
      $(this).find('strong').text(value.toFixed(2));
});

It really does depend on how your HTML markup. :)

@gareth-gillman: has @simonmacfadyen solved your problem?

Not had chance to test yet, will do tomorrow morning :)

I'm closing this ticket. Feel free to reopen if you still have problems


Fix clusterCA value location

Follow-up for https://github.com/giantswarm/cluster-apps-operator/pull/169. Dex chart expects clusterCA to be at the root of the values (see https://github.com/giantswarm/dex-app/blob/f4d88eae4ef1cb2fb27b0d1a61acaa78194b5d1c/helm/dex-app/templates/dex-k8s-authenticator/configmap-customer.yaml#L51). There are no other consumers of this value that I know of.
Checklist

[x] Update changelog in CHANGELOG.md.

Tested on gamma.


[BUG] 查看日志发现偶尔服务器自己重启

[INFO] 商家：business_id_5584上线
[INFO] Crontab task [WsHeadBeat] executed successfully at 2021-02-14 07:46:30.
[INFO] Worker#0 started.
[WARNING] WebSocket: fd[2762998] does not exist.
[INFO] WebSocket Server listening at <IP_ADDRESS>:9502
[INFO] HTTP Server listening at <IP_ADDRESS>:9501
[WARNING] WebSocket: fd[2762932] does not exist.
[WARNING] WebSocket: fd[2762954] does not exist.

然后下面有一些异常日志不清楚是否有关

[2021-02-14 07:46:35 *263.0]    WARNING Worker_reactor_try_to_exit (ERRNO 9012): worker exit timeout, forced termination

===================================================================
 [FATAL ERROR]: all coroutines (count: 1) are asleep - deadlock!
===================================================================

 [Coroutine-3]
--------------------------------------------------------------------
#0  Redis->zRangeByScore() called at [/hyperf-skeleton/vendor/hyperf/redis/src/RedisConnection.php:76]
#1  Hyperf\Redis\RedisConnection->__call() called at [/hyperf-skeleton/runtime/container/proxy/Hyperf_Redis_Redis.proxy.php:49]
#2  Hyperf\Redis\Redis->Hyperf\Redis\{closure}() called at [/hyperf-skeleton/vendor/hyperf/di/src/Aop/ProceedingJoinPoint.php:84]
#3  Hyperf\Di\Aop\ProceedingJoinPoint->processOriginalMethod() called at [/hyperf-skeleton/vendor/hyperf/di/src/Aop/ProxyTrait.php:85]
#4  Hyperf\Redis\Redis::Hyperf\Di\Aop\{closure}() called at [/hyperf-skeleton/vendor/hyperf/utils/src/Pipeline.php:104]
#5  Hyperf\Utils\Pipeline::Hyperf\Utils\{closure}() called at [/hyperf-skeleton/vendor/hyperf/di/src/Aop/ProceedingJoinPoint.php:69]
#6  Hyperf\Di\Aop\ProceedingJoinPoint->process() called at [/hyperf-skeleton/vendor/hyperf/tracer/src/Aspect/RedisAspect.php:71]
#7  Hyperf\Tracer\Aspect\RedisAspect->process() called at [/hyperf-skeleton/vendor/hyperf/di/src/Aop/Pipeline.php:30]
#8  Hyperf\Di\Aop\Pipeline->Hyperf\Di\Aop\{closure}() called at [/hyperf-skeleton/vendor/hyperf/utils/src/Pipeline.php:95]
#9  Hyperf\Utils\Pipeline->then() called at [/hyperf-skeleton/vendor/hyperf/di/src/Aop/ProxyTrait.php:86]
#10 Hyperf\Redis\Redis::handleAround() called at [/hyperf-skeleton/vendor/hyperf/di/src/Aop/ProxyTrait.php:29]
#11 Hyperf\Redis\Redis::__proxyCall() called at [/hyperf-skeleton/runtime/container/proxy/Hyperf_Redis_Redis.proxy.php:70]
#12 Hyperf\Redis\Redis->__call() called at [/hyperf-skeleton/vendor/hyperf/redis/src/RedisProxy.php:32]
#13 Hyperf\Redis\RedisProxy->__call() called at [/hyperf-skeleton/vendor/hyperf/socketio-server/src/Room/RedisAdapter.php:209]
#14 Hyperf\SocketIOServer\Room\RedisAdapter->cleanUpExpiredOnce() called at [/hyperf-skeleton/vendor/hyperf/socketio-server/src/Room/RedisAdapter.php:201]
#15 Hyperf\SocketIOServer\Room\RedisAdapter->Hyperf\SocketIOServer\Room\{closure}() called at [/hyperf-skeleton/vendor/hyperf/utils/src/Functions.php:271]
#16 call() called at [/hyperf-skeleton/vendor/hyperf/utils/src/Coroutine.php:62]

通常不太要紧。。
你看看是不是设置了了 max_request 参数

通常不太要紧。。
你看看是不是设置了了 max_request 参数

'max_request' => 100000,
哦哦看见了 是因为 这个吗、因为他重启后 好像socketio 组件 显示的连接数 显示又不太对

        $socket_io = ApplicationContext::getContainer()->get(\Hyperf\SocketIOServer\SocketIO::class);
        $clients = $socket_io->of('/')->getAdapter()->clients();

        $this->output->info('数量：'.count($clients));

你设置为0就行

你设置为0就行

ok


putenv is not thread safe so it should be removed to avoid leaking dot env variable to other applications

PHP Version
8.1
Shopware Version
<IP_ADDRESS>
Expected behaviour
putEnv should not be used as it isn't thread safe and therefore could leak variables like database URL to other applications which doesn't sound like a good idea (especially in shared hosting environments).
Actual behaviour
remove putenv and getenv calls.
getenv if it is anywhere still should be replaced with EnvironmentHelper like e.g. \Shopware\Core\Framework\Api\Controller\CacheController::info
or as that is part of dependency injection already,  just add%env(...) or the parameter as arguments.
How to reproduce
See above.

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


Defect: Fix Line Height

Defect
The line height of the opening instructions for the Lab 5 Exercise is slightly off. Most text utilizes a line height of 1.75, but this text has a line height of 1.5, which is inherited from the body styling rule.
Here is a screenshot of the specific text:

Acceptance Criteria

[ ] Line height style rule is changed for this piece of text to be 1.75
[ ] Body line height stays 1.5

Closing - this is no longer an issue!


🐛 [firebase_ui_auth] "more signin methods" error persistence

Bug report
On the profile page, if you have "google" and "apple" in the list of more signin methods and you click "apple" without apple signin being enabled in the firebase console for the project, you get an error message in red on the screen.  If you then click google, it fails and the error message persists even though google signin is enabled for the project in the firebase console.  If you log out then back in, you can then add google as a signin method with no error.
Steps to reproduce
Use the example app and follow the description above.
Expected behavior
Enabling google signin should work and the error message should disappear.
Of course, most likely apple won't be in the list of providers if it isn't enabled in the firebase console so this is mainly FYI.
  If you enable google sign-in on the profile page, it gets enabled correctly but stays in the list of "more sign in methods" and doesn't appear in the list of "sign-in methods" when it should.  If you click the google icon again, it once again tries to enable it but reports an error in red text "This provider is associated with a different user account".  If you sign out and back in it shows google in the list of enabled "sign-in methods" as it should.  If you then delete it from the list of sign-in methods it goes back into the list of "more sign-in methods".  If you then click the google icon you get an immediate error message - "The given sign-in provider is disabled for this Firebase project"  -which is wrong.  Now if I sign out and back in I can enable google as a sign-in method again and google enables the sign-in method but doesn't ask for my password ?????????

/cc @lesnitsky

click "apple" without apple signin being enabled in the firebase console for the project

This is an invalid use of the library. The documentation clearly states that apple sign in should be enabled in firebase console before adding a provider to the Firebae UI Auth configuration.

You didn't bother to read the second post that I wrote in this thread.  Please re-open this report and leave it open until it is fixed,

I read it. I wasn't able to reproduce it. Most likely the error was valid and you indeed had a google credential associated with a different user account. You could check that on firebase console. If you encounter this issue again – please submit a new issue


Pack items cause errors on Update D&D Beyond

If a pack item like an Explorer's Pack is added to a character's inventory in Foundry, an error is returned:

TypeError: Cannot read property 'flags' of undefined

This is because say an explorers kit gets expanded into all it's parts. A fix might be... complicated. I'll get to it eventually.
Workaround - add kit in DDB and reimport.


[ Full Stack Cert ] - update description for travel agency page

Let’s update the intro text to the following:
"intro": [
          "For this lab, you will review working with HTML fundamentals by creating a web page for a travel agency. This lab will give you an opportunity to review working with images, the figure element, the figcaption element, the anchor element and more."
        ]

Here is the file you need to edit:
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/client/i18n/locales/english/intro.json#L1721-L1726

This has been opened for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.
If you would like to contribute and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/
If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum
Happy coding


WorkspaceEdit and File Level Operations

A rename operation, for example returns a WorkspaceEdit operation. However, when renaming a Java class, for example, I expect the file to be renamed as well. Is there a way to express that in LSP?

See also #41 and #191.

What about a simple delete: true flag to mark the previous file as deleted (flag to be added to protocol) + a regular TextEdit with whole content of the new file?

I agree that we should expand the WorkspaceEdit with a resourceChanges property which allows for the following resource operations:

create (with content)
move (includes rename)
delete

This would solve the rename refactoring as as well.

A proposal is highly appreciated.

@dbaeumer I think this one needs a proposal-provided label also

Agree.

@dbaeumer I have seen there is support for resource change now in LSP. However, what's missing from my point of view is the creation of folders. If I have a rename or a delete, I know whether I am dealing with a folder or a file, But in a create, I have no way of knowing. Shouldn't "isFolder" be added to CreateFileOptions?

@tsmaeder correct :-). All I can recommend right now is to create a file in the folder and then delete the file.
I will keep the request open to support creating a folder. Will very likely be an additional property / param type: 'file' | 'folder'

See also https://github.com/Microsoft/vscode/issues/62663

@dbaeumer
For the workaround, on my windows' desktop, I always disabled recycle bin support.  So the work around will pop up with text Failed to move 'fakeFile' to the recycle bin
This workaround is kind of issue if customer doesn't support recycle bin or have to enable options files.enableTrash: false
Either way, it is not decent workaround at this time.

Refactor package name is really an important feature for Java language, without creating/deleting folder support in LSP level, it's hard to bring this feature to jdt.ls.
@dbaeumer is there any update about this issue? Or any help i can provide to solve it? thanks.

@testforstephen thanks for offering your help. Things needed to be done to make this work:

extend LSP to provide a createFolder resource change
to be able to leverage this in VS Code the API must be extended as well (see: https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L2870 and https://github.com/microsoft/vscode/issues/62663)

Should not be too complicated. I would start with the VS Code work and then add the LSP resource change.

great, thanks for the explanation. Looking forward to see it's solved.

This got added a while back ago.


add rights, attachment operations

Description:
now, there are fungible_ops, and data_ops related to FungibleAllocation, and DataAllocation, so I think we can also have rights_ops, attachment_ops related to RightsAllocation, AttachAllocation.

add rights_ops interface
add attachment_ops interface

There is a question: I found the info: ContractInfo defined in the ContractIface, but it seems like it's not used in this struct and all the interfaces defined in the ContractIface.

but it seems like it's not used in this struct and all the interfaces defined in the ContractIface.

What do you mean by "not used"? It is subject to be used by software integrating RGB: this is how it gets information about the contract like if it is on testnet, creation identity and timestamp etc.


Review current SBOM for obvious missing Linux and MacOS detail

The current SBOM json needs reviewing to add obvious missing details, eg.gcc or clang version, Xcode version, ...?

Closing out-of-date issue


In Obsidian 1.5.3 + Minimal Theme Setting 7.3.1 , there is a misalignment issue with the positioning of tables.

In Obsidian 1.5.3 + Minimal Theme 7.4.3 + Minimal Theme Setting 7.3.1, there is a misalignment issue with the positioning of tables.
I have already disabled all my CSS Snippets.
This is my Minimal Theme style settings (about Table) in "Style Settings" plugin:

I chose "always fill."

Then, the table will display like this:

After testing, I discovered that this issue does not occur in the default theme or other themes. If I select the "Fit to line width" option (default value), the table displays correctly (indicating that, by default, tables in the Minimal Theme do not experience misalignment). However, when I select the "Overflow line width" or "Always fill" options, the table's positioning becomes misaligned.

Additionally, using cssclasses does not resolve this misalignment issue.
Debug ingo:
SYSTEM INFO:
	Obsidian version: v1.5.3
	Installer version: v1.4.16
	Operating system: Windows 10 Pro 10.0.26016
	Login status: logged in
	Catalyst license: none
	Insider build toggle: off
	Live preview: on
	Base theme: dark
	Community theme: Minimal v7.4.3
	Snippets enabled: 0
	Restricted mode: off
	Plugins installed: 9
	Plugins enabled: 9
		1: Thino v2.1.4
		2: Admonition v10.1.1
		3: Advanced URI v1.38.1
		4: Dataview v0.5.64
		5: Hider v1.3.1
		6: Minimal Theme Settings v7.3.1
		7: Obsidian42 - BRAT v0.12
		8: Style Settings v1.0.7
		9: Sortable v0.3.1

RECOMMENDATIONS:
	Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

When I took the screenshot, I had multiple plugins enabled, and I needed to eliminate the interference of the plugins, so I closed all but nine of them, but the problem persisted. Therefore, some of the plugins that appear in my screenshot are not included in the list of plugins in the debug info because I had already disabled them.

Addition: The tables generated by DataView do not experience positional displacement.

Please keep issues like this in the Minimal repo

The information has been synchronized to another issue.
Looking forward to getting it fixed. thx:)


Automatic Sign-in to execute ProvisionComposer.js /Deploy Resources

Hi,
I am using provisioncomposer.js to deploy the resources, but with that we will have to manually sign-in by pasting the url and code. Is there an option to use service principal / managed identity /connect command to automatically login from some configuration.
(I am new to those concepts, please correct me if i am wrong somewhere)
I have configured provisioncomposer.js in Jenkins. I want to make it automated for creating the resources and update the appsettings.json with the generated keys.
If i get some support, it will be great.

UmPrel

@benbrown can you please comment on this?

This provision script using ARM templates and the az cli to achieve the outcome.  It is possible to use your own mechanism and auth to execute the ARM templates, but we do not plan to add this functionality natively to the provision script.

Hi Ben,
I noticed the below thread where it is mentioned that composer team will provide some support for CI/CD related documentation.
https://github.com/microsoft/BotFramework-Composer/issues/3339
If that is the case, there should be some option for the automated sign-in i felt.
Any comments on this.

@UmaPrelude in the ci/cd environment, credentials are provided via different mechanisms other than interactive login. Future integrations in that area will take advantage of the available auth mechanisms - keyvault, service principals, etc.


Android: Tracker (Music Editor) doesn't work properly on android.

Even if you have keyboard opened, it'll only enter sharp notes from number keys. When pressing z,x,c and so on, nothing happens. Possible solution would be a "piano" on the bottom half of the tracker (at the cost of pattern space, which would then need to be scrollable), similar to the one in the sound editor.

Already have an issue for this. Closing to avoid duplicate.
https://github.com/nesbox/tic.computer/issues/106

And there will be a separate Piano Mode optimized for touch input


Question: How to change the Bitrate in the NIT table?

Hi,
I need to update the bitrate manifest inside the NIT table of a current TS.
Any plugin to execute this task?
Thank you!

What is the "bitrate manifest" in the NIT?

What is the "bitrate manifest" in the NIT?

The Terrestrial Delibery System Descriptor (0x5A) inside the NIT table. I need to update this descriptor after using the reduce plugin.
Any idea?

Ah, ok, you want to update the modulation parameters (which, in turn, determine the bitrate, this is correct).
The plugin nit provides a few specific on-the-fly transformations on the NIT, but not that one specifically. For any generic modification like this, the process is:

Extract the tables from the PID in XML format using the plugin tables.
Manually modify the XML file (this is text). Here, you can do what you want, really.
Reinject the tables in the stream using the plugin inject, replacing the previous content of the PID.

In the case of the NIT, just be careful to extract all tables from PID 16, namely the NIT Actual and all NIT Other (if there are any).

Ah, ok, you want to update the modulation parameters (which, in turn, determine the bitrate, this is correct).

YES!

The plugin nit provides a few specific on-the-fly transformations on the NIT, but not that one specifically. For any generic modification like this, the process is:

Extract the tables from the PID in XML format using the plugin tables.
Manually modify the XML file (this is text). Here, you can do what you want, really.
Reinject the tables in the stream using the plugin inject, replacing the previous content of the PID.

It works, thank you! :+1:
tsp -I file input.ts -P filter --pid 16 -P tables --xml-output nit.xml -O drop
nano nit.xml
tsp -I file input.ts -P inject --pid 16 -r --xml nit.xml -O file out.ts

However, as a simple question: Any option to have something like this?
tsp ... -P nit --replace "terrestrial_delivery_system_descriptor"=file.xml -O ...

Now it's easy to edit the XML files (thank you for this unvaluable option). However, instead of replace the full table, I ask about replace part of it. Any change?

tsp ... -P nit --replace "terrestrial_delivery_system_descriptor"=file.xml -O ...

No, because, in this case, you must also specify the TS id. Then, if you extend this to any type of table, the complexity is so high that it becomes useless. Too many structures, too many descriptors. The plugins such as nit,  pmt, etc. have some options to handle specific use cases on the fly. But there always will be other cases which are not handled. So, the generic method is the XML one.

Hi @lelegard ,
Thank you for your explanation. I agree and I accept your opinion on the KISS principle. :+1:
However, with all due respect I have created this XML file with only this data:
<?xml version="1.0" encoding="UTF-8"?>
<tsduck>
  <NIT>
    <transport_stream>
      <terrestrial_delivery_system_descriptor centre_frequency="698,000,000" bandwidth="8MHz" priority="HP" no_time_slicing="true" no_MPE_FEC="true" constellation="64-QAM" hierarchy_information="0" code_rate_HP_stream="2/3" code_rate_LP_stream="1/2" guard_interval="1/4" transmission_mode="8k" other_frequency="true"/>
    </transport_stream>
  </NIT>
</tsduck>

And the idea is to REPLACE the used table with this content. I understand it's hard to implement functions/parameters for ALL values (that's impracticable). However, I feel the solution of an XML replace will provide the best from both sides: flexibility and simplicity.
What you think?

No way, too specific, impossible to address the general case.

No way, too specific, impossible to address the general case.

I'm disappointed to hear that.


Add DigitalOcean2 and ProfitBricks features to Karaf build

thanks @sjcorbett -- would it be useful to add a comment in the feature.xml to remember to use jclouds-all-compute from https://github.com/jclouds/jclouds-karaf/blob/master/feature/src/main/feature/feature.xml and jclouds-labs-all-compute from https://github.com/jclouds/jclouds-karaf/blob/master/feature-labs/src/main/feature/feature.xml when we bump to jclouds 2.1.x ?

I think that is a good point but probably outside the scope of this PR @andreaturli so it shouldn't stop this being merged. This looks fine to me, so I'm going to merge now, thanks @sjcorbett.


Debian build failed due to division by zero test

@arstrube :)
https://buildd.debian.org/status/package.php?p=cpputest&suite=sid

It seems that on arm64 the explanation in test-suite.log is:
FAIL: CppUTestTests
....
tests/UtestPlatformTest.cpp:128: error: Failure in TEST(UTestPlatformsTest_PlatformSpecificRunTestInASeperateProcess, DivisionByZeroInSeparateProcessWorks)
./include/CppUTest/TestTestingFixture.h:112: error:
actual <
Generic:1: error: Failure in TEST(Generic, Generic)
Failed in separate process
.
Errors (1 failures, 1 tests, 0 ran, 0 checks, 0 ignored, 0 filtered out, 1 ms)
   did not contain  <Failed in separate process - killed by signal 8>

http://nominolo.blogspot.sg/2012/07/arms-new-64-bit-instruction-set.html
Especially this section:
There is now an integer division instruction. However, it does not generate an exception/trap upon division by zero. Instead (x/0) = 0. That may seem odd, but I think it's a good idea. A conditional test before a division instruction is likely to be cheaper than a kernel trap.

Neat ;-)
I will remove the test case. I will start my own collection of "CppUTest XXtreme" testcases from now on. I find such test cases interesting, but they shouldn't be part of the tests that get always executed. In this particular case, nothing is going to be lost, not even test coverage ;-)
I never knew how different some things can be handled by some compilers / architectures.


2091 barracuda waf issue

Fix for Barracuda WAF Syslog Parser in Splunk Connect for Syslog
In version 2.44.0 of Splunk Connect for Syslog, a Barracuda WAF syslog parser was introduced to handle Barracuda WAF logs. However, this implementation was reported to be non-functional in issue 2091.
To address the issues with the previous implementation, the following fixes have been implemented in the latest update:

Multiple Sourcetypes: Instead of having a single sourcetype (barracuda:waf), the new version introduces five distinct sourcetypes to better categorize the logs:
barracuda:system
barracuda:waf
barracuda:web
barracuda:audit
barracuda:firewall

ISO Timestamp Parsing: The fix addresses the ISO timestamp parsing for the vendor format: %Y-%m-%d %H:%M:%S.%f %z, ensuring that timestamps are correctly interpreted.

Program Field Filtering: In the previous implementation, logs were filtered based on the waf-den hostname, which was incorrectly considered the program name. The fix applies filtering based on the correct values: SYS, WF, TR, AUDIT, and NF.

Please note that this revised version assumes a context related to the documentation and the mentioned issues and fixes. If there are additional technical details or context not provided in the original text, there may be a need to tailor the revised version accordingly.

I have read the CLA Document and I hereby sign the CLA

recheck

:tada: This PR is included in version 3.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Webhook Template Page - when there is not any data message shows "No user found"

Describe the bug

when there is not any data in webhook template the message is showing "No Users Found."
message should be change
message should be in left align
no background required in message

https://www.berrycast.com/conversations/efb15b6f-c453-509d-bac5-98389daaf14f


QR Code code in Send vs. QR Code icon in main screen for wallet information

Clicking into a read-only wallet on Android
Click on the QR sign next to "Show content for"
Scan an Ergodex transaction generated using SAFEW.
Creates a situation where you drop out of the app and android asks if you want to stop the app or wait for it.
Might want to add some kind of error handling for people that think that the QR code will automagically know what you are doing. Because these two look the same but do not work the same.

Thanks for the report. It is a bug fixed in ddd515efb84cf464d1af030820a4f0452044c1ab - fix is in the next version.
For the time being, scan from send screen or wallet overview. Only ErgoPay is affected, all other types work from the details screen.


Cóntributions list should filter out records where valid != true

Describe the bug
The Contributions tab lists contributions as retrieved from the DB. Some entries in the DB subrecord (ceremonies/(cid)/circuits/(cct)/contributions) are contributions that failed, or at least failed to verify.  These should be excluded from the table.
To Reproduce
Steps to reproduce the behavior:

Go to Contributions tab for a ceremony where some failed contributions exists.
The earliest entries in the list are the failed contributions. They have no zkey file and no hash, only a timestamp.

Expected behavior
Screenshots
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context

Merged into prod


make gringoft as third-party lib for other project

Codecov Report

Merging #23 into master will increase coverage by 0.66%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   71.51%   72.18%   +0.66%
==========================================
  Files          85       85
  Lines        3283     3361      +78
  Branches     1324     1365      +41
==========================================
+ Hits         2348     2426      +78
- Misses        933      934       +1
+ Partials        2        1       -1

Flag
Coverage Δ

#unittests
72.18% <84.21%> (+0.66%)
:arrow_up:

Impacted Files
Coverage Δ

src/infra/raft/RaftReplyLoop.cpp
93.67% <ø> (ø)

src/infra/raft/StorageMain.cpp
0.00% <0.00%> (ø)

src/infra/util/FileUtil.h
52.72% <ø> (ø)

src/infra/util/StrUtil.h
100.00% <ø> (ø)

...c/infra/es/store/ReadonlyRaftCommandEventStore.cpp
90.05% <14.28%> (-3.09%)
:arrow_down:

src/infra/util/CryptoUtil.cpp
83.13% <84.00%> (+7.19%)
:arrow_up:

src/infra/raft/storage/Segment.cpp
88.84% <96.00%> (+0.27%)
:arrow_up:

src/infra/raft/RaftLogStore.cpp
95.23% <100.00%> (+0.07%)
:arrow_up:

src/infra/raft/storage/InMemoryLog.h
90.00% <100.00%> (+0.11%)
:arrow_up:

src/infra/raft/storage/Log.h
100.00% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe9c58...cd16554. Read the comment docs.

I created an issue to link this PR: #25


test: use context with timeout to ensure that Cilium log gathering takes <= 5 minutes

If the test environment is in a bad state, the log gathering steps can stall the CI, causing it to timeout. Provide context to functions which is connected to a timeout so that once said timeout is reached, the log-gathering will short-circuit and exit quickly.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>

This change is

Coverage decreased (-0.01%) to 42.116% when pulling 4b6ea026d15ad603739ec5e8d921be57b467fd41 on pr/ianvernon/provide-configurable-exec-timeout into 6204b7b8420034689a22bae36698f29bef8d57bf on master.

test-me-please

test-me-please

test-me-please

@ianvernon Any reason why we aren't backporting this?

@aanm I hadn't considered it yet. Let's backport it.


how to set user snippet so that no matter when sami can be appeared at end of line?

example: my setting is:
"fg": {"prefix": "fg ","body": [
"function*($1) {",
"  $2",
"};"],"description": "fg"}
when the cursor in "()", input "fg", enter, result is "(function*(){};)", but i hope "(function*(){});"
英语太挫了, 希望有中文大神指点一下, 在Emacs下可以实现的一个功能, 比如光标在括号里, 输入fg回车, 得到"(function*(){});" 在vscode里只能是"(function*(){};)", 有办法实现么?

Static snippets cannot do that but CompletionItemProviders. Have a look at this extension sample https://github.com/Microsoft/vscode-extension-samples/tree/master/completions-sample which implements a basic completion item provider.

@jrieken thank you for answer, I have success run those samples, learn something about extension, but have not realize the purpose, I will have time to try again !


Update RX sequence number after refusing TCP FIN packet.

Update RX sequence number after refusing TCP FIN packet.
Description

As FreeRTOS Forum TCP Refusing FIN mentioned, the expected RX sequence is not well handled in the stack when refusing FIN. Update the RX sequence number when hitting this scenario.
Test Steps

Refer to this forum post for the test result.

Create TCP connection.
Keep sending packets.
Receiving FIN packet.

Checklist:

[x] I have tested my changes. No regression in existing tests.
[] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi, I have backported the changes to TCP 3.1.0 for testing, using kernel 10.5.1 and Xilinx Zynq port.  All appears to be working as expected.  Let me know if there is any other information I can provide.  Thanks for the great support!
Gain: Socket 6000 now has 1 / 1 child
prvSocketSetMSS: 1460 bytes for C0A81505ip:53356
Socket 6000 -> C0A81505ip:53356 State eCLOSED->eSYN_FIRST
prvWinScaleFactor: uxRxWinSize 2 MSS 1460 Factor 0
Socket 6000 -> C0A81505ip:53356 State eSYN_FIRST->eSYN_RECEIVED
TCP: passive 6000 => C0A81505ip:53356 set ESTAB (scaling 1)
Socket 6000 -> C0A81505ip:53356 State eSYN_RECEIVED->eESTABLISHED
Starting network tasks
Refusing FIN[6000,53356]: RxCompl 1 tx done 0
TCP: RST received from C0A81505ip:53356 for 6000
Socket 6000 -> C0A81505ip:53356 State eESTABLISHED->eCLOSED
error reading from socket
Notify txTask to shutdown
Tx task is deleting itself
Lost: Socket 6000 now has 0 / 1 children
FreeRTOS_closesocket[6000 to C0A81505ip:53356]: buffers 64 socks 1
Rx task is deleting itself


update: avalanchego-installer.sh

Why this should be merged
The Installer script is not supported for macOS. But it doesn't throw an error message indicating that the user is on an unsupported OS. Instead, it simply exits after the Preparing environment... line.
Made changes to check if the user is running on macOS and terminated with a self-explanatory message.
How this works
The problem is that the getOsType function is not compatible with macOS. It simply doesn't do anything. Not even a blank space or garbage value is returned. This results in the osType check failing and the program halts without any error message.
Effectively, this message should echo on the terminal.
I have included commands in the getOsType function to check if the OS is different than Linux. This was initially being checked here.
How these changes were tested
Ran the script again to test and the below image is the result.

LGTM, would love some feedback from @jpop32 before merging. Thanks as always @ashucoder9 💪


No build yurt-edgex-manager binary or image user guide

Maybe it's more friendly to provide user guide how to build yurt-edgex-manager binary or image. @lwmqwer

Greate, I will update the README.


Textures from base64-encoded data URIs reports wrong validity

Expected Behavior
PIXI.Texture.from('data:image/svg+xml;base64,...').valid is expected to be false If it is not cahched.
Current Behavior
It returns true regardless of the loading state.
Possible Solution
As far as I known, this issue is caused by the SVGResource L20. Canvas elements created at that line has the non-zero width / height, thus the method #valid reports true even if a SVG is not loaded yet.
https://github.com/pixijs/pixi.js/blob/c4968736f2c6e928097ef7e903e14e86e6f1de01/packages/core/src/textures/resources/SVGResource.js#L20
https://github.com/pixijs/pixi.js/blob/c4968736f2c6e928097ef7e903e14e86e6f1de01/packages/core/src/textures/resources/Resource.js#L115-L118
Thus, resetting the canvas width/height explicitly solves this issue.
At least, it worked for me.
export default class SVGResource extends BaseImageResource
{
    constructor(source, options)
    {
        options = options || {};
+       const canvas = document.createElement('canvas');
+       canvas.width = canvas.height = 0;
+       super(canvas);
-       super(document.createElement('canvas'));

Steps to Reproduce
Please see the following playground:
https://www.pixiplayground.com/#/edit/_2bneblE7~49HhtvsviJZ
Environment

pixi.js version:  5.0.4
Browser & Version: Chrome 75.0.3770.100
OS & Version: Windows 10
Running Example: _https://www.pixiplayground.com/#/edit/_2bneblE7~49HhtvsviJZ_

Yes, it shouldn't be valid before we actually know its size. super(canvas) isn't good idea, I'll think how to modify your PR, it should look better.

Btw, you are on fire, 4 PR's in short time 👍

Yes, it shouldn't be valid before we actually know its size. super(canvas) isn't good idea, I'll think how to modify your PR, it should look better.

OK, I got it.

Btw, you are on fire, 4 PR's in short time 👍

Thank you for making PixiJS 👍
Saved me a lot.

The PR is merged 🎉


Multiple input

Hi guys,
There is a way to make multiple input field in the dialog box?
Thanks in advance.

+1

+1


9.2.9 typo in lemma

"Then for all valuations α and β in M,..."
should be "all assignments"

This is much bigger than I though, I confuse the words everywhere... big edit coming right up q


[export bug] comment renders into next line, painting over next line

Hi there,
so I have a screen that renders weirdly:

Obviously, the comment shouldn't be rendered into the next line like that.

Browser:
  Firefox 69.0.1

Code Snippet
https://carbon.now.sh/DSvQlK1qbxkq9bOgMAih
// calling setTimeout with a inline callback function to provide a parameter
function delay(data) {
  return new Promise(resolve => setTimeout(() => resolve(data), 1000))
};

// calling setTimeout with the target function and the parameter directly
function delay(data) {
  return new Promise(resolve => setTimeout(resolve, 1000, data))
};

If you need anything else, please ping me :)

This might be a duplicate of https://github.com/carbon-app/carbon/issues/743 - if you agree, feel free to close this.

@phryneas which operating system were you using?

Linux - NixOS 19.09 to be specific.

Yeah this is most definitely a duplicate. Thank you for posting though! 🙂


[US] Export/Import Environment Variables

As an application configurator, I want to be able to export my environment variables to a file and reload such variables from a file so that it's possible to keep/use different env. variables.

MoSCoW
Risk
Story Points

Should
Low
2

Acceptance Criteria

The configurator can successfully export the environment file
The configurator can successfully reload an environment file onto the application

Risks

Letting users upload files could lead to injection vulnerabilities

Pre-requisites

[x] Meet with the stakeholder to clarify the requirements if deemed necessary

Tasks

[x] Export environment variables
[x] Reload environment variables

DEMO VID
https://github.com/WillTrem/UInnovate/assets/47327032/68ce5e07-759c-4371-8543-fc70c9800426

Looks good! Signing off!


Identify new Common Crawl providers

www.rawpixel.com
www.thorvaldsensmuseum.dk
eunis.eea.europa.eu
svgsilh.com **
digital.smb.museum
capl.washjeff.edu
www.perseus.tufts.edu
digi.ub.uni-heidelberg.de
www.free-photos.biz
www.ipernity.com
www.maxpixel.net

**do we want to integrate SVG in CC Search or are the concerns similar to icons? @janeatcc

I'd have to take a look. But the issue is closed already?

Here's some potential providers I found:

www.rawpixel.com

97353 CC0 images (C-MAIN-2019-04)

http://www.bcx.news/

84856 CC-BY-NC
84856 CC-BY (probably duplicates)

townmapsusa.com

44297 CC BY-NC
22150 CC-BY-SA
these seem programmatically generated (a map containing the location of a single US city for every US city), but they're unique and the site encourages remix and reuse.


Issue: In a special case the CSS file names are not replaced correctly in the HTML code

Hello,
I am working on a project that is based on HTML5 Boilerplate. Unfortunately, grunt-cache-killer is not correctly replacing CSS files names in index.php; this is due to a file named style.css, this file is part of HTML5 Boilerplate.
Before running the task:
<link rel="stylesheet" href="css/vendor/bootstrap-5.1.3.min.css">
<link rel="stylesheet" href="css/style.min.css">
<link rel="stylesheet" href="css/custom.min.css">

After:
<link rel="style.20220813212624.min.css">
<link rel="style.20220813212624.min.css">
<link rel="style.20220813212624.min.css">

This is the task's configuration:
    cacheKiller: {
      options: {
        mask: '{datetimestamp}',
        prepend: '.'
      },
      build: {
        files: {
          'dist/css/style[mask].min.css' : ['dist/index.php'],
          'dist/css/custom[mask].min.css' : ['dist/index.php']
        }
      }
    },

And this is the debug output:
[D] Options object: { prepend: '.', append: '', mask: '{datetimestamp}', length: -1 }

[D] Validating option types.
[D] Success..!

[D] Validating mask function type.
[D] Success..!

[D] Building tasks list.
[D] Working..!.

[D] Validating template filenames.
[D] Success..!

[D] Validating position of mask placeholder.
[D] Success..!

[D] Validating asset filename.
[D] Success..!

[D] Validating template filenames.
[D] Success..!

[D] Validating position of mask placeholder.
[D] Success..!

[D] Validating asset filename.
[D] Success..!

[D] Build tasks list.
[D] Success..!

[D] Tasks list object:
{
  '0': {
    asset: {
      name: {
        full: 'dist/css/style[mask].min.css',
        base: 'dist/css/',
        file: 'style[mask].min.css',
        pre: 'style',
        post: '.min.css'
      },
      mask: {
        prepend: '.',
        value: { raw: '20220813212624', computed: '20220813212624' },
        append: ''
      },
      rename: {
        from: { file: 'style.min.css', full: 'dist/css/style.min.css' },
        to: {
          file: 'style.20220813212624.min.css',
          full: 'dist/css/style.20220813212624.min.css'
        }
      }
    },
    templates: [ 'dist/index.php' ]
  },
  '1': {
    asset: {
      name: {
        full: 'dist/css/custom[mask].min.css',
        base: 'dist/css/',
        file: 'custom[mask].min.css',
        pre: 'custom',
        post: '.min.css'
      },
      mask: {
        prepend: '.',
        value: { raw: '20220813212624', computed: '20220813212624' },
        append: ''
      },
      rename: {
        from: { file: 'custom.min.css', full: 'dist/css/custom.min.css' },
        to: {
          file: 'custom.20220813212624.min.css',
          full: 'dist/css/custom.20220813212624.min.css'
        }
      }
    },
    templates: [ 'dist/index.php' ]
  }
}

[D] Synchronously renaming asset file.
[D] Success..!

>> build : Asset file 'style.min.css' renamed to 'style.20220813212624.min.css'.
[D]
[D] Synchronously read contents of template.
[D] Success..!

[D] Replace template's matching content.
[D] Success..!

[D] Synchronously write contents to template.
[D] Success..!

>> build : Reference(s) updated in template file 'dist/index.php'.

[D] Synchronously renaming asset file.
[D] Success..!

>> build : Asset file 'custom.min.css' renamed to 'custom.20220813212624.min.css'.
[D]
[D] Synchronously read contents of template.
[D] Success..!

[D] Replace template's matching content.
[D] Success..!

[D] Synchronously write contents to template.
[D] Success..!

>> build : Reference(s) updated in template file 'dist/index.php'.

Success..!

Done.

@alchemist-153 Within your cacheKiller task configuration, try removing dist/ from the beginning of both CSS asset file paths and their associated template paths as shown below.
    cacheKiller: {
      options: {
        mask: '{datetimestamp}',
        prepend: '.'
      },
      build: {
        files: {
          'css/style[mask].min.css' : ['index.php'],
          'css/custom[mask].min.css' : ['index.php']
        }
      }
    },

This script does not change the asset and template file paths, only the asset file names and their reference in the template(s).

I assume you are using other CSS build tools and cacheKiller to achieve the following.

<link rel="stylesheet" href="css/vendor/bootstrap-5.1.3.min.css">
<link rel="stylesheet" href="css/style.min.css">
<link rel="stylesheet" href="css/custom.min.css">

<link rel="stylesheet" href="dist/css/vendor/bootstrap-5.1.3.min.css">
<link rel="stylesheet" href="dist/css/style.20220813212624.min.css">
<link rel="stylesheet" href="dist/css/custom.20220813212624.min.css">

If that is the case, then either run cacheKiller:

Before your CSS build tool processes and moves your CSS files to the dist directory,
and drop reference to dist/ in the cacheKiller task configuration (as initially shown above).

After your CSS build tool copies your processed CSS files to the dist directory,
and leave reference to dist/ in the cacheKiller task configuration (as your CSS build tool would have prepended dist/ to the front of the your asset file path(s)).

Let me know how you go...

Thank you for your reply!
I tried all the solutions you kindly provided, but unfortunately Grunt Cache Killer fails again to correctly replace the strings.
One easy solution that works, but I don't like for some reasons, is to rename style.css to main.css, doing it like this, Grunt Cache Killer works very well and I can use the html code and task configuration I posted at the beginning of my previous post.
After running Cache Killer this is what I get now, and it's correct:
<link rel="stylesheet" href="css/vendor/bootstrap-5.1.3.min.css">
<link rel="stylesheet" href="css/main.20220814161445.min.css">
<link rel="stylesheet" href="css/custom.20220814161445.min.css">

I think that these new results suggest that the problem is caused by the string 'style', not the string 'dist'.
My knowledge of JavaScript is very basic, but please consider this as the possible explanation:
When using 'style.css' as the name of a file, and 'style[mask].min.css' as the new name of the file, Cache Killer makes this:
$tasks[i].asset.name.pre = 'style';
Then, Cache Killer scans my html code and finds the first link tag:
<link rel="stylesheet" href="css/vendor/bootstrap-5.1.3.min.css">
And it matches the value of the variable name.pre ('style') with the string 'style' that is inside rel="stylesheet", this leads to rel="stylesheet" being replaced with rel="style.20220814121121.min.css" (Please see the section 'After running the task' of my first post). The same happens with the rest of the link tags. Please note that href attributes are being deleted.
I think that maybe there is a minor error in a regular expresssion.

@alchemist-153 Good news. I have been able to reproduce the error in a new test (test 6) as shown below.
Testing test6.js.F
>> cacheKiller - test_2
>> Message: File names and contents should match.
>> Actual:
>>   '<!DOCTYPE html>\r\n' +
>>     '\r\n' +
>>     '\r\n' +
>>     '    \r\n' +
>>     '    <meta charset="UTF-8">\r\n' +
>>     '\r\n' +
>>     '    \r\n' +
>>     '    <title>Test HTML Template - Master</title>\r\n' +
>>     '\r\n' +
>>     '    \r\n' +
>>     '    <link rel="style.9063da07.min.css">\r\n' +
>>     '\r\n' +
>>     '\r\n' +
>>     '
Test HTML Template - Master
\r\n' +
>>     '\r\n' +
>>     ''
>> Operator:
>>   ==
>> Expected:
>>   '<!DOCTYPE html>\r\n' +
>>     '\r\n' +
>>     '\r\n' +
>>     '    \r\n' +
>>     '    <meta charset="UTF-8">\r\n' +
>>     '\r\n' +
>>     '    \r\n' +
>>     '    <title>Test HTML Template - Master</title>\r\n' +
>>     '\r\n' +
>>     '    \r\n' +
>>     '    <link rel="stylesheet" href="../css/style.9063da07.min.css">\r\n' +
>>     '\r\n' +
>>     '\r\n' +
>>     '
Test HTML Template - Master
\r\n' +
>>     '\r\n' +
>>     ''
>> at Object.test_2 (tests\functional\test6.js:24:14)
>> at processImmediate (node:internal/timers:464:21)
>> at process.topLevelDomainCallback (node:domain:152:15)
>> at process.callbackTrampoline (node:internal/async_hooks:128:24)

Warning: 1/15 assertions failed (28ms) Use --force to continue.

Aborted due to warnings.

Process finished with exit code 6

As mentioned, line 362 will be the problem.
var result = content.replace(new RegExp($tasks[k].asset.name.pre + '.*' + $tasks[k].asset.name.post, "g"), $tasks[k].asset.rename.to.file);
I'll look at geting this fixed as soon as possible for you.
Thank you @alchemist-153 for bringing it to my attention.

@alchemist-153 All fixed.
grunt-cache-killer : v1.3.7 has now been pushed to GitHub and NPM.
Let me know if you continue to have any problems.

Hello @custom-dev-tools, I tried the new version of cacheKiller a moment ago and it works very well 👏🏼
Thank you very much!


Fix perl's SafeHole on Darwin

Description of changes
Exports CC to fix build on Darwin
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hi @someone-stole-my-name!
Diff LGTM - but the commit message does not follow CONTRIBUTING.md

@ofborg build perlPackages.SafeHole


Send a notification on slow query

This PR utilises Laravel's whenQueryingForLongerThan functionality to send a Telegram message to admins if a slow query is encountered.
@driesvints do you think we should make the duration parameter of whenQueryingForLongerThan configurable or ship this and see how we get on?

Telegram seems to strip the select, but I think that's ok.


Remove incorrect table qualification

Remove the qualification rtl because the table was not aliased to rtl in that section of the code
Description & motivation

To-do before merge

Prerelease docs
If this change is related to functionality in a prerelease version of dbt (delete if not applicable):
Checklist
If you added new pages (delete if not applicable):
If you removed existing pages (delete if not applicable):

@runleonarun any idea why the checks are failing?

@runleonarun @mirnawong1 Just seen this again after a long time. What needs to be done to get it merged?


[Peek] - preview any media (play audio and video files at least)

Description of the new feature / enhancement
Peek should be able to open any type of media.
Now we are halfway there!!!
PLS PLS PLS implement this <3
Scenario when this would be used?
In the Sound design community (my work), we have have been yearning for an "Apple quick preview" feature to preview all the sounds we make and need to audition on a regular basis to come to windows.
Supporting information
No response

Agreed, need this!

Is this issue about audio support for Peek?

/dup #25989


Cities Table is not seeding

Laravel Version: 8.65
Nnjeim/world: ^1.0
While using php artisan db:seed --class="WorldSeeder", it takes less than expected which means, nothing was seeded. However, I've found that after comment the line 30, the seed works without cities table.
line 30:
$this->data['cities'] = json_decode(File::get(__DIR__ . '/../../resources/json/cities.json'), true);
I was thinking that the file cities.json is very big. But, changing configurations in php.ini, such as upload_max_filesize and post_max_size to greater than the size of the file still not working.
What should I do to make the seed works?

@claytongf Hi, the only thing i can think about is the memory allocated to php try to increase the memory_limit in php.ini.
on my local machine i have 2048M allocated and it works fine.

@nnjeim Hi. Thanks for your response.
Changing the memory allocated in php.ini to 2048M worked fine! Thank you!
I'm just worried about seeding all the data in production. You think there is a way to seed them allocating less memory?

@claytongf Hi again, the seeder is only needed to build up the database tables, once done , the php resources can be reduced. I will try to set the memory limit in the seeder itself in the coming version ini_set('memory_limit', '2G'). Another solution might be to array_chunk the cities array.


Include Xamarin Android and iOS in NuGet Packages

I tried successfully your excellent new library with Xamarin Andoid. But I need to add a reference manually. Can you configure your NuGet package definition to include MonoAndroid and Xamarin.iOS (see https://developer.xamarin.com/guides/cross-platform/advanced/nuget).
All dependencies are already included in Mono framework.
See here a sample of the NuGet Package Explorer result.

We'll probably just wait for Xamarin to catch up with netstandard NuGet changes, but leaving open to look at post 1.0.0

Xamarin has announced support now for .NET Standard. https://blog.xamarin.com/net-standard-library-support-for-xamarin/. Some basic scenarios work, and using Xamarin + Visual Studio I've been able to get a simple Xamarin.iOS/Android app working...
...but with a few hacks. There are still bugs in Microsoft.Data.Sqlite.
Known issues on Xamarin

When using Xamarin Studio on macOS: System.Data.Common doesn't unify to System.Data. https://bugzilla.xamarin.com/show_bug.cgi?id=42702
Relative paths in connection strings fail on Xamarin.iOS/Android https://github.com/aspnet/Microsoft.Data.Sqlite/issues/279
Installation fails due to nuget bug when installing our dependency on SQLite.Native: "the package does not contain any assembly references or content files that are compatible with that framework." https://github.com/natemcmaster/libsqlite3-package/issues/6

Is there any update now on using EF Core with Xamarin now that Xamarin supports netstandard? I see a few related entries here on GitHub where people are trying to use EF Core with the latest Xamarin supporting netstandard and running into issues and in particular it seems with Microsoft.Data.Sqlite and its related packages.
Specifically Xamarin states they are now supporting netstandard but I keep running into this: Could not install package 'SQLite.Native 3.12.2'. You are trying to install this package into a project that targets 'MonoAndroid,Version=v6.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
So is this an issue with the package or Xamarin because that package on NuGet.org says it is netstandard1.0 compatible.

@wjvii this is one of the known issues I referenced in my previous comment: https://github.com/aspnet/Microsoft.Data.Sqlite/issues/255#issuecomment-237616906 (see https://github.com/natemcmaster/libsqlite3-package/issues/6). I am working with the sqlite team to release an update to the SQLite package that resolves the issue.

FWIW, I think this issue might be more complicated than just needing netstandard support.
The NativeMethods/pinvoke stuff might work okay for iOS as long as you're not using any callbacks anywhere.  (I haven't checked.)
But the new rules with Android N make it basically essential to bundle a SQLite library rather than use the one provided by the OS.
Long term, supporting Xamarin probably means dealing with a lot of the same issues as SQLitePCL.raw (which I maintain).
As part of my exploration of this area, I have submitted pull request #292, in which I rip out the current interop stuff and replace it with a SQLitePCL.raw dependency.  For discussion purposes.

The NativeMethods/pinvoke stuff might work okay for iOS as long as you're not using any callbacks anywhere.

We don't yet, but we've played with callbacks and may add them. https://github.com/aspnet/Microsoft.Data.Sqlite/issues/143

But the new rules with Android N make it basically essential to bundle a SQLite library rather than use the one provided by the OS.

How does SQLitePCL.raw distribute sqlite for Android N?

How does SQLitePCL.raw distribute sqlite for Android N?

Bundling a native lib for Xamarin.Android requires placing the .so files into an embedded resource in an assembly.
For use with SQLitePCL.raw, I maintain a set of SQLite builds which are called "e_sqlite3", to eliminate ambiguity with the system SQLite.
The id for the e_sqlite3 package containing the embedded library assembly for Android is SQLitePCLRaw.lib.e_sqlite3.android
An implementation of ISQLite3Provider specifies that "e_sqlite3" is the desired library.  Providers are in packages with id starting with SQLitePCLRaw.provider.*
I have bundle packages which, for each target framework or platform, contain dependencies on the lib and the appropriate provider packages.  Plus an init function which injects the provider into the core assembly so everything is ready to go.

@bricelam are we still planning to do anything about this for 1.1.0-preview1?

I don't think it fits into 1.1.0-preview1, but we could look at it before 1.1.0 RTMs.

After #21, I don't think there'll be anything left to do on our side to support Xamarin.


add namespace to shard identifier

Codecov Report

Merging #35 into master will decrease coverage by <1%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
- Coverage      78%    78%   -1%
=====================================
  Files          42     42
  Lines        3827   3827
=====================================
- Hits         2991   2989    -2
- Misses        613    615    +2
  Partials      223    223

Flag
Coverage Δ

#unittests
78% <100%> (-1%)
:arrow_down:

Impacted Files
Coverage Δ

client/datastor/zerodb/client.go
74% <ø> (ø)
:arrow_up:

client/datastor/zerodb/cluster.go
87% <100%> (ø)
:arrow_up:

client/datastor/zerodb/shard.go
25% <100%> (ø)
:arrow_up:

client/datastor/pipeline/storage/distributed.go
77% <0%> (-2%)
:arrow_down:

client/metastor/db/etcd/etcd.go
81% <0%> (+4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16fb474...ebe8b3f. Read the comment docs.


doppelgreener: Blacklist premiumpureforskolinrev.com

doppelgreener requests the blacklist of the website premiumpureforskolinrev.com. See the Metasmoke search here

forskolin should be caught whatever it comes up, so it's probably worth finding out why it didn't get caught, if that's the case.


German language is not appropiate used when using Confirmprompts

The Issue
I am building a chatbot for german users. I am sending the local "de-de" as user, and can confirm this actual arrives the bot. When i want to use  Confirmprompts the bot returns Yes and No and not "Ja" "Nein".
The Solution
After a lot of digging, I found the underlying cause and a fix. The culture model does not actually recognices German (de-de) as supported language, and thus switches to the default (english). But in the prompt_culture_models.py German actualy exists and ther is a todo "# TODO: Replace with Culture.German after Recognizers-Text package updates." Which I looked up and the Recognizers-Text package sis already updated :) . Still this is not the real issue.
The reason is that german is not listed in the supported cultures function. I simply added it and every thing works fine.
    @classmethod     def get_supported_cultures(cls) -> List[PromptCultureModel]:         """         Gets a list of the supported culture models.         """         return [             cls.Chinese,             cls.German,             cls.Dutch,             cls.English,             cls.French,             cls.Italian,             cls.Japanese,             cls.Korean,             cls.Portuguese,             cls.Spanish,             cls.Turkish,         ]

Hi @PascalHessler -- thanks, looking into this issue.

@PascalHessler There is a PR which will fix this issue. Thanks, @ramfattah for the PR!


Add UART buffer from old Zephyr code

I modified the code slightly to work with newer mbed and removed the need to attach the IRQ handler in the user code.

There is also UARTSerial included in mbed, which appears to do the same thing. I will try that first.

UARTSerial duplicates this so I won't merge.


Saka-key extension not opening correctly

Mac OS 11.12.1 and Firefox 85.0.2
When I open the extension it does not fully open correctly as seen in attached image.
Haven't needed to click on the extension in a while so I'm not sure when this broke for me.

#127 @LinxiFan comment on Feb 11, 2018 gives a work around.

I figured out. You have to open the option menu on a separate page instead of operating directly in the popup. You can do that from Firefox extension manager.

Or pull the saka button out of the Overflow menu. See my answer to a similar question here: https://github.com/lusakasa/saka-key/issues/320#issuecomment-876554924


Bug: Encrypter->decrypt issue?

Describe the bug
I've set an Encryption key, and i'm testing the decryption process, when not passing the 2nd argument everything looks fine, but when I encrypt with a different key as follow i've came across what could be a critical problem:
CodeIgniter 4 version
4.0.3
Affected module(s)
\Config\Services::encrypter()
Expected behavior, and steps to reproduce if appropriate
$crypt = \Config\Services::encrypter();

$userKey = base64_encode($crypt->key . 'usermail@gmail.com');  //creating unique key for user

$userData = $crypt->encrypt('user sensitive data', $userKey);

// Allright here, passed user key and it passes and decrypts as intended
echo "
Decrypted + correct userkey: ", $crypt->decrypt($userData,$userKey), "
";

// here passing a wrong key it throws an error as intended
echo "
Decrypted + wrong userkey: ", $crypt->decrypt($userData, 'wrongkey'), "
";

// !!! BUG HERE!!!
//  I believe that when i'm not passing 2nd arg, it is using the default key ($crypt->key), it SHOULD throw an error, but instead it decrypts correctly
echo "
Decrypted - without userkey: ", $crypt->decrypt($userData), "
";

Context

OS: debian
Web server Apache 2.4
PHP version 7.4

Reading through the docs that Jim wrote, it looks to me that is not a bug - but the intended way it should work. It is designed so that you shouldn't have to pass a key at all, which would mean that it would use the key set in the config file by default.


Add BUILD_REV + fix jsBundleId

2 issues in 1.
Test: kp

(1) Generate BUILD_REV strings
Will be used by

Sentry -- it needs a version number to tie up source-maps.
New bundle ID for the ui.js file.

solves issue_2003
easier to determine which commit a particular ui.js is from.

Format
"<YYYYMMDDHHMM>.<commit_id_12_chars>"

The time will be in UTC.
Rationale for format:

Putting the date in front allows the string/file to be sortable.
Combining both date and commit id covers the case of rebuilding from the same commit, i.e. BUILD_REV would still end up unique.

Other notes

COMMIT_ID comes from the command line, which it currently does in production. If not provided (e.g. debug), the rev would just be the date string.

(2) Fix unstable jsBundleId reference
Closes #2003
Root
It's a combination of 2 problems:
(a) getJsBundleId houses a file-level variable that would end up in a new context when Node resets (or some action, not sure what), thus returning a different ID from what webpack used.
(b) insertToHead is being shared in 2 places -- webpack and getHtml.  getHtml uses the output of webpack, so we end up inserting the script tag twice, with the second one being the altered id from (a) above.
Fix

Now that we have a build rev string, use that as the bundle ID instead randomly generating it.
The value now also comes directly from the same variable used in webpack, rather than stored at file-level, thus preventing the reset problem.
insertToHead now takes in an optional rev string parameter, so we can control when it needs to inject the script tag or not.

Related
https://odysee-workspace.slack.com/archives/C02G20Z2AEL/p1634682653336100

The minute part could drift between the 2 servers, but we could also remove the date/time from the format and just use the commit ID.  Rebuilds can be addressed by just adding a dummy commit like we always do.
For the lazy-loaded chunks, I think the hashes are based on content, so they should be identical too, but would need to confirm.


Fix broken link in run-with-nginx.md

Weird. The action didn't finished.

its because github actions do not run if only a readme is changed - i will force merge it


Error running make

Hi - when I run make, I get an error:
ERRO Running error: context loading failed: failed to load program with go/packages: internal error: go list gives conflicting information for package nri-network-telemetry/vendor/github.com/newrelic/nri-network-telemetry/internal/util  make: *** [lint] Error 3

tried this after googling around and hitting the same problem:
run
go  env -w GO111MODULE="on"
reason for that error seemed to be, when doing "go env " that module was set to empty.
Now I'm seeing different errors so well, that's progress.

so disregard the above since the error following that -<EMAIL_ADDRESS>used for two different module paths (github.com/fsnotify/fsnotify and gopkg.in/fsnotify.v1)
make: *** [tools] Error 1
got me down a rabbit hole saying modules shouldn't be used, and github links should be used instead so that variable should stay off - https://github.com/golang/go/issues/26904
as per "Agnivade's" comment on that thread.
So just stumped here

This repo previously did not use go modules for dependencies (it used dep).  I've migrated to modules in the latest release, as well as added in CircleCI builds to confirm.
Please retest with:

Golang 1.13.0+
Cleaned repo / pull from master or release tag v1.0.0

Thanks @jthurman42 this works for me now with golang v1.13


Interchaintest for e2e tests

ports e2e framework to use interchaintest.
use test matrix in CI, removing need for self hosted test runner.
improves test coverage by using slashing period of 10 blocks, 90% uptime required, and reducing number of validators in test from 4 to 2, which requires the horcrux validator for consensus.

It's great we're getting more test coverage on CI!

All of the e2e tests were running as part of CI, but on a single job on the external runner, which made figuring out which specific test was failing more difficult.


 Please use the latest version.

Might be a good idea to update the readme with the required version

Hi again,
The go version has been added to the readme. Thanks for your advise!


Awake won't revert to off after waking up screen following set interval in Awake

Microsoft PowerToys version
0.72.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Awake
Steps to reproduce
See #27831
✔ Expected Behavior
Awake settings to revert to Off to properly reflect the alleged normal behavior of going back to system screen-off timer settings
❌ Actual Behavior
Awake settings still displaying set interval thus showing it's active when it's actually not
Other Software
No response

Any progress on this little fix or will it not be implemented ?

Duplicate of #29784

This bothers me also, and I'm baffled that its not fixed yet...


[ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './package.json' is not defined by "exports" in /home/react-storefront/node_modules/react/package.json

Summary
Just got: ERR_PACKAGE_PATH_NOT_EXPORTED
ready - started server on <IP_ADDRESS>:3001, url: http://localhost:3001
info  - Loaded env from /home/react-storefront/.env
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './package.json' is not defined by "exports" in /home/react-storefront/node_modules/react/package.json
    at new NodeError (node:internal/errors:371:5)
    at throwExportsNotFound (node:internal/modules/esm/resolve:429:9)
    at packageExportsResolve (node:internal/modules/esm/resolve:705:3)
    at resolveExports (node:internal/modules/cjs/loader:482:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:522:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)
    at Function.mod._resolveFilename (/home/react-storefront/node_modules/.pnpm/next@12.0.10_757a802188413a36d4f24237d13b8e90/node_modules/next/dist/build/webpack/require-hook.js:183:28)
    at Function.resolve (node:internal/modules/cjs/helpers:108:19)
    at getPackagePath (/home/react-storefront/node_modules/.pnpm/next@12.0.10_757a802188413a36d4f24237d13b8e90/node_modules/next/dist/build/webpack-config.js:548:41)
    at Object.getBaseWebpackConfig [as default] (/home/react-storefront/node_modules/.pnpm/next@12.0.10_757a802188413a36d4f24237d13b8e90/node_modules/next/dist/build/webpack-config.js:564:9) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}
 ELIFECYCLE  Command failed with exit code 1.

Steps to reproduce
git clone git@github.com:saleor/react-storefront.git
pnpm i
npm run dev
node -v --> v17.5.0
A link to a reproduction repository
No response
What OS are you using?
Linux
Your next.config.js file
const withBundleAnalyzer = require("@next/bundle-analyzer")({
  enabled: process.env.ANALYZE === "true",
});

module.exports = withBundleAnalyzer({
  reactStrictMode: true,
  // swcMinify: true,
  swcMinify: false,
  images: {
    domains: ["vercel.saleor.cloud", "img.youtube.com"],
    formats: ["image/avif", "image/webp"],
  },
  async redirects() {
    return [
      {
        source: "/",
        // TODO: Investigate why constants from project cannot be imported
        // User should be redirected to the defaults defined in @lib/regions
        destination: "/default-channel/en-US",
        permanent: false,
      },
    ];
  },
});

Builds logs (or link to your logs)

Build logs
# Paste logs here

Function logs

Function logs
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './package.json' is not defined by "exports" in /home/react-storefront/node_modules/react/package.json
    at new NodeError (node:internal/errors:371:5)
    at throwExportsNotFound (node:internal/modules/esm/resolve:429:9)
    at packageExportsResolve (node:internal/modules/esm/resolve:705:3)
    at resolveExports (node:internal/modules/cjs/loader:482:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:522:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)
    at Function.mod._resolveFilename (/home/react-storefront/node_modules/.pnpm/next@12.0.10_757a802188413a36d4f24237d13b8e90/node_modules/next/dist/build/webpack/require-hook.js:183:28)
    at Function.resolve (node:internal/modules/cjs/helpers:108:19)
    at getPackagePath (/home/react-storefront/node_modules/.pnpm/next@12.0.10_757a802188413a36d4f24237d13b8e90/node_modules/next/dist/build/webpack-config.js:548:41)
    at Object.getBaseWebpackConfig [as default] (/home/react-storefront/node_modules/.pnpm/next@12.0.10_757a802188413a36d4f24237d13b8e90/node_modules/next/dist/build/webpack-config.js:564:9) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}
 ELIFECYCLE  Command failed with exit code 1.

I think using node ^16 solves the problem, what you also can do with node 17 is go to this file /home/react-storefront/node_modules/react/package.json and replace "./" in the exports subsection with "./package.json"

Yes, as described by @jamalbendadi you should be using a Node.js LTS version e.g. 16.


Use one kubernetes client

Is this a bug report or a feature request?:
feature request
What happened:
After the speakers got merged in #76 we just use 2 k8s clients, this is quite exspensive; we should just use one. In the words of @danderson:

TODO future cleanup, we can probably have a single k8s client and a single leader elector for all protocols, and do the fanout in this code.

Each k8s client maintains its own cache of all the objects, and a separate connection to the k8s apiserver, so currently this code is consuming 2x the ram it needs, and making 2x the number of necessary connection (scaling concern).

Again, no need to change this right now, I'm just braindumping things we should do later.

This is actually really important to do immediately, because it turns out you cannot create >1 k8s client per binary. It does process-unique stuff like listen on the HTTP port, register prometheus metrics... So right now the speaker binary just crash-loops when it's deployed.
Working on merging the clients...

Quick and dirty hack implemented. Closing this, opening new issue to clean up the code structure once the rate of change in arp et al. slows down.


⚠ Bofrost.be has degraded performance

In fbb28e0, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2305 ms

Resolved: Bofrost.be performance has improved in 830ef05.


Test master branch on Travis

@iqulus r+

:pushpin: Commit 9349ea9 has been approved by tarcieri

:hourglass: Testing commit 9349ea9 with merge d98af7d...

Giving up on homu :(


Your module do not work when browser no support webp

Your module do not work when browser no support webp. Can you fix this moment?

Fixed


🐛 BUG: Error while importing node:buffer

Which Cloudflare product(s) does this pertain to?
Workers for Platforms
What version(s) of the tool(s) are you using?
.
What version of Node are you using?
No response
What operating system and version are you using?
windows11
Describe the Bug
When I try to create a worker according to https://developers.cloudflare.com/workers/examples/signing-requests/ ,I get "Uncaught Error: No such module " node:buffer". imported from "worker.js" (Code: 10021)".
I have added "compatibility_flags = [ "nodejs_als" ]" to wrangler.toml as per instructions.
worker.js
import { Buffer } from "node:buffer";

const encoder = new TextEncoder();

const EXPIRY = 600;

export default {
  /**
   *
   * @param {Request} request
   * @param {{SECRET_DATA: string}} env
   * @returns
   */
  async fetch(request, env) {

    const secretKeyData = encoder.encode(
      env.SECRET_DATA ?? "my secret symmetric key"
    );

    const key = await crypto.subtle.importKey(
      "raw",
      secretKeyData,
      { name: "HMAC", hash: "SHA-256" },
      false,
      ["sign", "verify"]
    );

    const url = new URL(request.url);

    if (url.pathname.startsWith("/generate/")) {
      url.pathname = url.pathname.replace("/generate/", "/");

      const timestamp = Math.floor(Date.now() / 1000);
      const dataToAuthenticate = `${url.pathname}${timestamp}`;

      const mac = await crypto.subtle.sign(
        "HMAC",
        key,
        encoder.encode(dataToAuthenticate)
      );

      // Refer to https://developers.cloudflare.com/workers/runtime-apis/nodejs/
      // for more details on using Node.js APIs in Workers
      const base64Mac = Buffer.from(mac).toString("base64");

      url.searchParams.set("verify", `${timestamp}-${base64Mac}`);

      return new Response(`${url.pathname}${url.search}`);
      // Verify all non /generate requests
    } else {
      // Make sure you have the minimum necessary query parameters.
      if (!url.searchParams.has("verify")) {
        return new Response("Missing query parameter", { status: 403 });
      }

      const [timestamp, hmac] = url.searchParams.get("verify").split("-");

      const assertedTimestamp = Number(timestamp);

      const dataToAuthenticate = `${url.pathname}${assertedTimestamp}`;

      const receivedMac = Buffer.from(hmac, "base64");
      const verified = await crypto.subtle.verify(
        "HMAC",
        key,
        receivedMac,
        encoder.encode(dataToAuthenticate)
      );

      if (!verified) {
        return new Response("Invalid MAC", { status: 403 });
      }

      // Signed requests expire after one minute. Note that this value should depend on your specific use case
      if (Date.now() / 1000 > assertedTimestamp + EXPIRY) {
        return new Response(
          `URL expired at ${new Date((assertedTimestamp + EXPIRY) * 1000)}`,
          { status: 403 }
        );
      }
    }

    return fetch(new URL(url.pathname, "https://example.com"), request);
  },
};

wrangler.toml
name = "url-sign"
main = "worker.js"
compatibility_date = "2024-07-15"
compatibility_flags = [ "nodejs_compat" ]

Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
No response

Did you use nodejs_compat or nodejs_als as the compatibility flag? The nodejs_als flag only gives access to the node:async_hooks import. For node:buffer you need nodejs_compat.
(Also you could try out the new experimental Node.js compatibility option we are trialling by adding experimental:nodejs_compat_v2 flag.)

The contents of the wrangler.toml file are as follows:
name = "url-sign"
main = "worker.js"
compatibility_date = "2024-07-15"
compatibility_flags = [ "nodejs_compat" ]

I tried experimental:nodejs_compat_v2 and still got the same error, is my formatting wrong?

Can you provide a link to a github repository that we can clone and test?

I get an error after clicking deploy after editing online on cloudflare workers&pages

My code was copied from the https://developers.cloudflare.com/workers/examples/signing-requests/ page

I've tried using CLI deployment and it works fine already.
Perhaps there is a vulnerability in online deployment.

Oh did you create a wrangler.toml file in the Dashboard editor?
If so, that won't work because we don't process that file online - it is only a Wrangler CLI thing.
Instead, online, you need to go and update the compat flags in the settings part of the dashboard for the Worker.

Yes, I edited wrangler.toml online and now I've solved it.


[SuperTextField][iOS] - Popover toolbar appears when it shouldn't

Package Version
main
To Reproduce

Go to SuperEditor demo
Add a few empty paragraphs
Tap on an empty paragraph to place there the selection

Actual behavior
The selection is placed at the paragraph and the toolbar is shown.
Expected behavior
The selection is placed at the paragraph. Only a second tap should reveal the toolbar
Platform
Only reproducible on iOS.
Flutter version
Flutter master
Screenshots
https://github.com/superlistapp/super_editor/assets/31278849/d40ab717-971b-42e9-a334-911a8165d75a
Additional context
Similar issue to https://github.com/superlistapp/super_editor/issues/2005.

Cc @matthew-carroll @angelosilvestre


Feat: Learn more in airdrop network info

Description of change
Adds a link to the assembly & shimmer network info popup.
Type of change

New (a change which implements a new feature)

How the change has been tested
Tested on:

macOS Monterey 12.1

Hey @r-c-k, thanks for adding this. The code is also found here in the StakingAirdrop.svelte dashboard tile - we could de-duplicate this code and add to shared/lib/participation/staking.ts, importing the two functions in the airdrop tile and this popup component?


Fixes #2567

Fixes #2567
PR Checklist

[x] Tests
[x] Documentation
[x] Changelog entry

Originally posted by @Amxx in https://github.com/OpenZeppelin/openzeppelin-contracts/pull/2568

Fixes #2567
PR Checklist

[x] Tests
[x] Documentation
[x] Changelog entry

Originally posted by @Amxx in https://github.com/OpenZeppelin/openzeppelin-contracts/pull/2568

Leop6140


DbContext can support Parallel ?

const string connectString = "Server=localhost;Database=HYW.CRM;User ID=sa;pwd=123456;MultipleActiveResultSets=true";
using (var db = new HYWCRMContext(connectString))
{
    var employeeInfos = db.EmployeeInfo.AsNoTracking().Where(m => m.BranchCode == "0801" && m.Status == 0).ToList();
    var dic = new Dictionary<string,int>();
    employeeInfos.AsParallel().ForAll(e =>
    {
        var count = db.MemberInfo.Count(m => m.EmpCode == e.EmpCode);
        dic.Add(e.EmpName,count);
     });
    foreach (var d in dic)
    {
       Console.WriteLine(d.Key+" "+d.Value);
     }
}

if dbcontxt suppot , How can I use it?
If not, how can I optimize my code?
use dapper?

I write this
               employeeInfos.AsParallel().ForAll(e =>
                {
                    using (var _db = new HYWCRMContext(connectString))
                    {
                        var count = _db.MemberInfo.Count(m => m.EmpCode == e.EmpCode);
                        dic.Add(e.EmpName, count);
                    }
                });

but This will consume a lot of performance

@quan01994, It is a simple SQL.
Code snippet is written on the knee. But it should work and processed on the server side. If not - it is another issue for EF Core with grouping.
using (var db = new HYWCRMContext(connectString))
{
    var employeeInfos =
        from e in db.EmployeeInfo.AsNoTracking()
        where e.BranchCode == "0801" && e.Status == 0
        join m in db.MemberInfo on e.EmpCode equals m.EmpCode
        group m by e.EmpName into g
        select new
        {
           EmpName = g.Key,
           Count = g.Count()
        }

    var dic = employeeInfos.ToDictionary(e => e.EmpName);
    foreach (var d in dic)
    {
        Console.WriteLine(d.Key+" "+d.Value);
    }
}

Note, that result a little bit different. If there no MemberInfo for specific EmployeeInfo  -  employee record will be filtered.
For sure we can rewrite query using LEFT JOIN, but as i know, currently EF Core will fail with such queries.
using (var db = new HYWCRMContext(connectString))
{
    var employeeInfos =
        from e in db.EmployeeInfo.AsNoTracking()
        where e.BranchCode == "0801" && e.Status == 0
        join m in db.MemberInfo on e.EmpCode equals m.EmpCode into members
        from pm in members.DefaultIfEmpty()
        group pm by e.EmpName into g
        select new
        {
           EmpName = g.Key,
           Count = g.Count(member => member.EmpCode != null)
        }
}

SELECT e.EmpName,me.RemarkNumber,me.RemarkPeopleNumber FROM EmployeeInfo e
LEFT JOIN
(SELECT COUNT(RemarkId) as RemarkNumber,COUNT(DISTINCT MemberId) as RemarkPeopleNumber,CreateUser FROM MemberRemark WHERE RemarkStatus=0 GROUP BY CreateUser)
AS me on e.EmpName=me.CreateUser
WHERE BranchCode = '0000' and [Status]=0
in this sql ,COUNT(DISTINCT MemberId) how  to convert  linq

@quan01994, as i know there is no way to do that with pure EF Core. But since I am the author of this library linq2db.EntityFrameworkCore, for sure i will propose its use :)
var emloyeeInfos =
   from e in db.EmployeeInfo
   from me in (
      from memberRemarks in db.MemberRemark
      where
         memberRemarks.RemarkStatus == 0
      group memberRemarks by memberRemarks.CreateUser into g
      select new
      {
         CreateUser = g.Key,
         RemarkNumber = g.Count(),
         RemarkPeopleNumber = g.CountExt(m => m.MemberId, Sql.AggregateModifier.Distinct)
      }
   ).LeftJoin(me => me.CreateUser == e.EmpName)
   where
      e.BranchCode == "0000" &&
      e.Status == 0
   select new
   {
      e.EmpName,
      RemarkNumber = Sql.ToNullable(me.RemarkNumber),
      RemarkPeopleNumber = Sql.ToNullable(me.RemarkPeopleNumber)
   };

var list = emloyeeInfos.ToLinqToDB().ToList();

Note that CountExt, LeftJoin and Sql.ToNullable() are linq2db extension methods.

CountExt - custom aggregate
LeftJoin - linq2db extension for simplifying join operations in linq queries
Sql.ToNullable - since we have LEFT JOIN and RemarkNumber and RemarkPeopleNumber can be NULL, so we just changing their type from int to int?

These two methods create conflicts ！
“Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ToListAsync(System.Linq.IQueryable, System.Threading.CancellationToken)”
“LinqToDB.AsyncExtensions.ToListAsync(System.Linq.IQueryable, System.Threading.CancellationToken)”
@sdanyliv
using Microsoft.EntityFrameworkCore;
using LinqToDB;
How should I choose

@quan01994, we know about that and i did everything to solve this conflict. Just write ToListAsync() it should process anyway.
Collision here because IAsyncEnumerable still not in .NET Framework and each linq provider have to define its own Async methods.

@sdanyliv Thank you for your patience.   :)

Also for achieving best performance i suggest to compare execution plan of previous query against Window Functions usage:
var aggregatedInfos =
   from e in db.EmployeeInfo
   from mr in db.MemberRemark.LeftJoin(mr => mr.CreateUser == e.EmpName)
   where
      e.BranchCode == "0000" &&
      e.Status == 0
   select new
   {
      e.EmpName,
      RN = e.RowNumber().Over().PartitionBy(e.EmpName).OrderBy(e.EmpName).ToValue(),
      RemarkNumber = Sql.Ext.Count().Over().PartitionBy(e.EmpName).ToValue(),
      RemarkPeopleNumber = Sql.Ext.Count(mr.MemberId, Sql.AggregateModifier.Distinct).Over().PartitionBy(e.EmpName).ToValue()
   };

var emloyeeInfos =
   from ei in aggregatedInfos
   where ei.RN == 1
   select new
   {
      e.EmpName,
      e.RemarkNumber,
      e.RemarkPeopleNumber
   };

var list = emloyeeInfos.ToLinqToDB().ToList();

@smitpatel please link this scenario to GroupBy improvement.

#11976


Support ${workspaceFolder} variable in sqltools.sessionFilesFolder setting

Is your feature request related to a problem? Please describe.
I have .vscode in .gitignore file and want to save session file there. Currently the only option is to specify absolute path to that directory, which actually not an option and would break if I move project somewhere else.
Describe the solution you'd like
Support ${workspaceFolder} variable in sqltools.sessionFilesFolder setting so I can save sassion file somewhere in workspace directory without specifying absolute path.
Describe alternatives you've considered
Specifying absolute path.
Additional context
Using latest available sqltools (0.25.1) in vscode (1.72.1).
Current behavior:

${workspaceFolder}/.vscode - trying to create $\{workspaceFolder\}/.vscode and fails to save session file.
.vscode - trying to create /.vscode and fails to save session file.

+1 for this support. The current experience isn't back-breaking as long as you delete the file before your following git commit/whatever. Still, there is the added risk that queries using sensitive data will appear in the git history for that repo if you forget to remove the sensitive data before committing.
My current workaround is to move the queries manually I do want to keep into a queries/adhoc folder, and delete those that I don't need records of before doing anything with git.


Fix conflict typo in jsx-in-depth page

Fix conflict typo in jsx-in-depth page
link: https://ko.reactjs.org/docs/jsx-in-depth.html
As-is

To-be

Progress

[x] content/docs/jsx-in-depth.md

LGTM

LGTM

빌드에 실패해서 새로 수정했습니다


Fix Dashboard Cards xpath to fix failure in 2.6 for Patternfly

Hi @nehachopra27, thank you for this. May I ask why only some subset of the pf-* class attributes were updated? At first sight I though this was a bulk update of all of these. But maybe you did a more thorough check instead?


[zh] Update reserve-compute-resources.md

[zh] Update reserve-compute-resources.md

/lgtm
/approve


Add is_connected property to NetworkBase class

NetworkBase.is_connected calls _wifi.is_connected which calls esp.is_connected

I messed up my comment format.


Devops: Make use of the improved fixtures in aiida-core

The fixtures now provide the config_psql_dos fixture with the
difference that it no longer provides the dictionary of an entire
profile but just the storage configuration. The new tmp_aiida_profile
is used to create a temporary profile with arbitrary storage on the fly.

Thanks @sebaB003 . I just opened the PR to test the new interface. I am holding off with merging this until the new functionality is released with AiiDA v2.6 which is relatively soon. I don't want to build of a branch of aiida-core in this package


[Manual Sync] Update the kubernetes-dependency-watches library

Closes #230

/cherry-pick release-2.8

/cherry-pick release-2.9


[rolling] Port test improvements from #272

🦟 Bug fix
Summary
Port test improvements from #272 on galactic to humble+.
This should clear up some of the CI issues that we have been facing.
Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

garden CI is failing to find ignition-math7.  @chapulina has this ever worked?  Is it expected to work or can we disable it until those packages are ready?

CC: @quarkytale this should get you closer to green.


Scaling - initial draft

Marek please review the code

I've tested on dev scaling up and down and it seems fine so I'll merge this branch with master.


Setting WORKLOAD_CERT_TTL has no effect in Istio 1.5.0

Bug description
Setting WORKLOAD_CERT_TTL has no effect in Istio 1.5.0
Expected behavior
After setting WORKLOAD_CERT_TTL environment variable for istiod and restarting it, the new WORKLOAD_CERT_TTL should reflect new cert validity
Steps to reproduce the bug
kubectl get deployment istiod -n istio-system -o yaml | tee ~/istiod.yaml
Update ~/istiod.yaml and add
        - name: WORKLOAD_CERT_TTL
          value: "10m"

To istiod environment variables section
kubectl apply -f ~/istiod.yaml
Deploy the httpbin and sleep example applications.
 kubectl create ns foo
 kubectl apply -f <(istioctl kube-inject -f samples/httpbin/httpbin.yaml) -n foo
 kubectl apply -f <(istioctl kube-inject -f samples/sleep/sleep.yaml) -n foo

Validation:
wenzhong-tang:istio-current wenzhong_tang$ kubectl exec $(kubectl get pod -l app=sleep -n foo -o jsonpath={.items..metadata.name}) -c istio-proxy -n foo -- openssl s_client -connect httpbin.foo:8000 | openssl x509 -text -noout | grep Validity -A 2
depth=2 C = US, ST = California, L = Sunnyvale, O = Istio, OU = Test, CN = Root CA, emailAddress =<EMAIL_ADDRESS>verify error:num=19:self signed certificate in certificate chain
DONE
        Validity
            Not Before: Mar  5 20:48:58 2020 GMT
            Not After : Mar  6 20:48:58 2020 GMT

The reason why this is the case is because WORKLOAD_CERT_TTL only kicks in when requested lifetime <= 0. Istio-proxy’s SDS agent defaults to 24 hours when setting the cert lifetime. Therefore, workload cert TTL is always 24 hours regardless of what value WORKLOAD_CERT_TTL has.
We currently workaround this issue  by manually updating istio-sidecar-injector and update SECRET_TTL
kubectl edit cm istio-sidecar-injector -n istio-system
Then restart istiod and all pods.  However we would like a central place to set it, ideally during installation.
Proposal:
Expose setting SECRET_TTL in istio-sidecar-injector config map as an installation option. Allow operators to configure workload cert lifetime.
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
wenzhong-tang:~ wenzhong$ istioctl version --remote
client version: 1.5.0
control plane version: 1.5.0
data plane version: 1.5.0 (4 proxies)

We use kubernetes 1.13.
How was Istio installed?
istioctl manifest generate > ~/manifest-1_5.yaml
kubectl apply -f ~/manifest-1_5.yaml

Environment where bug was observed (cloud vendor, OS, etc)
Kubernetes on AWS

https://github.com/istio/istio/pull/22072 is created to address this issue, which exposes configuring SECRET_TTL as an installation option to allow operators to configure workload cert lifetime.

istioctl manifest apply --set meshConfig.defaultConfig.proxyMetadata.SECRET_TTL=10
This sets the TTL on the client side.

This doesn't work. I got:
Error: failed to apply manifests: failed to generate tree from the set overlay, error: bad path=value: meshConfig.defaultConfig.proxyMetadata.SECRET_TTL=10

Sorry, I missed the "m" in the end:
istioctl manifest apply --set meshConfig.defaultConfig.proxyMetadata.SECRET_TTL=10m


Update docstring of v1beta1.PipelineObject

Changes
This commit clarifies the v1beta1.PipelineObject by deleting the ClusterPipeline which had not been implemented.
/kind documentation

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs included if any changes are user facing
[n/a] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

Also could we check if v1beta1.PipelineObject interface is used anywhere else that should not be replaced by just v1beta1.Pipeline since we are not having ClusterPipeline?
cc @vdemeester

can we just delete pipelineobject?

Actually I also felt the same 🤔  but not sure if it is safe since that's an interface under apis?


Add chronos_servers category rather than using masters, close #13

Can you update the vagrant host files too (in single & multi) please?

@ankanm done

LGTM


Add tests converting dab files #167

@cab105 you are committing changes from your master please consider creating a new branch, it will enable you to work irrespective of changes being done on master.

Updated, and recreated PR.