Character labels with invalid characters get invisibly eaten

When character labels have invalid characters e.g. "()", the label gets eaten. For example, in this nexus the two labels burn(tr.)_3 and claw(nail)_3:
#NEXUS

BEGIN DATA;
    DIMENSIONS NTAX=3 NCHAR=3;
    FORMAT DATATYPE=STANDARD MISSING=? GAP=- SYMBOLS="01";
    CHARSTATELABELS
        1 hand_1,
        2 burn(tr.)_3,
        3 claw(nail)_3
        ;
MATRIX
A   001
B   000
C   000
;
END;

This has the side effect that data can be deleted invisibly e.g. this is what the resulting data matrix looks like, note that the third character has replaced the second:
OrderedDict([
    ('A', OrderedDict([('hand_1', '0'), ('_3', '1')])),
    ('B', OrderedDict([('hand_1', '0'), ('_3', '0')])),
    ('C', OrderedDict([('hand_1', '0'), ('_3', '0')]))
])

commonnexus should probably emit a warning or an error in this case.
It would be nice to handle this better e.g. by converting to "burn_tr_3" or similar, and
guard against overwriting of characters (it'd be better to have duplicate _3's than lose one).

Ok, what happens is that simply the last word token before a comma is read as label. Thus, two characters get a label _3, which leads to the values for the second character being overwritten by the third in the matrix.

You should have seen a warning about a duplicate charstatelabel, though.

Any kind of conversion would require some sort of config setting, which states what non-word tokens to allow/convert in charstatelabels, I think. So raising a ValueError here seems to be the best we can do.

You should have seen a warning about a duplicate charstatelabel, though.

Just found another bug, where the warning about duplicate state labels wasn't emitted for the last label :)

great, thanks!


Formcontrol adding value by code does not set state filled

I am making an update page. If I add a value to a form control the label does not appear above the input. While debugging I found this comes because of state -> filled not being set to true.
This happens when the data is set after the component mounted and was not present on the state before.

[x] This is a v1.x issue (v0.x is no longer maintained).
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
When there is a value the field form control should have state filled set to true.
Current Behavior
The state filled is still false.
Steps to Reproduce (for bugs)
https://codesandbox.io/s/ll0lnl7zwl
Your Environment

Tech
Version

Material-UI
v1.0.0

React
v16.3.2

browser
Firefox

@s1104373 Check the React warning in the console. Fix it and you will be good.


Fixing breaking filepaths in setup.py

Fixes https://github.com/gvalkov/setuptools-py2cfg/issues/12

BTW, this project seems to be abandoned. My PRs are here for years untouched. I think we need a new maintainer for it.

Also please remember that PEP 621 got implemented in setuptools, so I got rid of all setup.cfg in all my projects. I used ini2toml to convert.

I didn't know that, thank you for letting me know :) yet a new change in what the "pythony" way is :roll_eyes:

Hello @amrsoll and @KOLANICH. Thank you for your patches and sorry for the long time it took me to merge them. A new release on PyPi has been pushed with your changes.


[css] CSS lint false positive on @media not (-vendor-prefix-query)

VS Code Version: 1.55.1
OS Version: Windows 10 20H2

Steps to Reproduce:

CSS validation should be on.
Open some firefox source code for example, or just paste this in a CSS file: @media not (-moz-proton) { *{color:inherit;} }
The first parenthesis is highlighted as an error. The linter says css-mediaqueryexpected. I guess it only recognizes universal/standard media queries.
I guess since the parenthesis is not recognized as valid, rules within the media query get erroneously highlighted for various syntax errors too, like curly brace missing, selector expected, etc.

Is there some configuration file where I can disable this specific lint rule? I don't want to disable CSS validation entirely for obvious reasons. Ideally I could just disable this media query rule. If not, hopefully this can be resolved soon. This makes vs code a real nightmare to use for me since I have no choice but to use these media queries now. Thanks so much 🙏

Does this issue occur when all extensions are disabled?: Yes

Fixed in latest


chore: add migrate-by-directory in md

Based on feedback

@brendaHuang can we also update the help strings in the cli command itself to match

@lynchbomb done


Create the base layer container using config from https://github.com/CentOS/centos-bootc as starting point

Outcomes

definition of base packages that go into the bootc base image layer
changes made to Fedora build infrastructure/tooling/configuration to produce base image layer
base image layer pushed to publicly available image registry

Depends on the completion of #16

We now build this as a part of the Fedora IoT compose as of F40, and it is automatically pushed to Quay.io and fedoraproject.org.


V4 VSIX - Cannot save project

Using the V4 VSIX template, I created a new project. However, I get an error message when I try to save the project. The issue is present for both EchoBot and EmptyBot projects. The message that I get is "The operation could not be completed. No such interface supported."
To Reproduce
Steps to reproduce the behavior:

Go to 'Visual Studio - File - New Project'
Click on 'BotFramework on the left and select 'EchoBot' from the right. Click on OK
Click on Save Project. Specify a local location and click on 'Save'
An error message is shown. Please see screenshot.

Issue seems to be only with this template and all other templates work.

Assigning @Zerryth to assist

@mgazell I wasn't able to repro the error you're getting.

Repro:
I had uninstalled the v4 template (Tools > Extensions and Updates... > Found Bot Builder V4 SDK Template > Uninstall), then installed it once again to make sure I had the most up-to-date published (Version: 4.2.0)
Ctrl + Shift + N (new project) > EchoBot1 > Ok
and
Ctrl + Shift + N (new project) > EmptyBot1 > Ok
F5 to run both. Both bots worked as intended in BF Emulator.

I imagine you actually do have the up-to-date VSIX version installed since you actually have the EmptyBot template, however does the issue persist if you uninstall and reinstall the template?

Also, you mention "other templates" work--which templates are you running that work? The 4.2 v4 VSIX only have Empty and Echo bot templates, but I'm curious to know what other template did work for you

Hi @Zerryth
I tried uninstalling and installing again with no success. I wanted to mention that I am using the community edition of VS 2017. I also dont get an option to save the project when I initially create the project (see screenhot below).

When I said other templates work, I meant other project types like a .net core app or a winforms app.

Hmm just installed VS Community 2017 as well, and again things seem to be working as intended and can't get a repro of your issue.
Although I do note that when I go to create a project, it does let me choose where to save project as well

Are you using an up-to-date version of VS Community?

Alrighty @mgazell so I actually went into Azure, created a virtual machine with only Visual Studio Community 2017 to have a completely clean slate, and was able to successfully download the VSIX and create/save a project from the template. It also let me create and save the project in one go.
Doing an internet search, it doesn't appear to be a Bot Framework-specific issue, but rather something happening on the Visual Studio 2017 side of things.
These two posts (post 1, post 2) mention the solution that worked for them was enabling "Save new projects when created".
I'd suggest trying the workaround in post 1.


Error: 2L not found

Hello, I have a similar issue as previously found on Flamingor
If I input this:
res = flamingo_main_noura(hic_data="matrix.hic",
                    file_format='hic',
                    domain_res=1e6,
                    frag_res=1e4,
                    chr_name="chr2L",
                    normalization='KR',
                    nThread=20)

I get the error, I suspect it comes from the gsub in the function construct_obj_from_hic
function (hic_file, resolution, chr_name, normalization)
{
    library(strawr)
    options(scipen = 999)
    chr_number <- gsub("chr", "", chr_name)
    normalized_data = strawr::straw(normalization, hic_file,
        chr_number, chr_number, unit = "BP", binsize = resolution)
    n <- max(normalized_data[, 2])/resolution + 1
    i_ind <- (normalized_data[, 1]/resolution) + 1
    j_ind <- (normalized_data[, 2]/resolution) + 1
    input_if = Matrix::sparseMatrix(i = i_ind, j = j_ind, x = normalized_data[,
        3], dims = c(n, n))
    res = new("flamingo", IF = input_if, n_frag = n, chr_name = chr_name)
    return(res)
}

My hic was alligned to ucsc, so there is "chr".
When I run:
strawr::readHicChroms("matrix.hic")
I get as expected:
  index  name   length
1     0   All   137547
2     1 chr2L 23513712
3     2 chr2R 25286936
4     3 chr3L 28110227
5     4 chr3R 32079331
6     5  chr4  1348131
7     6  chrX 23542271
8     7  chrY  3667352

If the gsub is not necessary it would be great to be able to run the tool.
Thanks again,
Noura

I have the code running on a dataset with "chr" in the chromosome name. Here's what I did:

Downloaded the code from this GitHub repository using the Code -> Download Zip file

Unzipped the code

unzip FLAMINGOrLite-master.zip

Modified the R code in the package to not have the gsub. It's in the FLAMINGOrLite-master/R/data_utils.R file. Here's the change (commented out the old, the new line is below):

  #chr_number <- gsub("chr","",chr_name)
   chr_number <- chr_name

Rebuilt the package

R CMD BUILD FLAMINGOrLite-master

Reinstalled the package

R CMD INSTALL FLAMINGOrLite_<IP_ADDRESS>00.tar.gz

Now running the code on my dataset it runs as follows:

library(FLAMINGOrLite)

res = flamingo_main(hic_data='inter_30.hic', file_format='hic', domain_res=1e6, frag_res=5e3, chr_name='chr19',normalization='NONE',nThread=2)

Note: that the run hasn't finished yet but it's been running for about 10 minutes so far.

Update, that it did successfully run.


Getting incorrect y of imagelayer on a staggered map

The actual screen height of a staggered map is only half of mapHeightInPixels.

This looks like an OK change. @MobiDevelop can you sign it off?


Reverse order of restriction/default_value in method definitions

To specify a method argument with a type restriction and a default value you currently need to do:
def foo(x = 1 : Int32)
end

With this PR, this is also possible:
def foo(x : Int32 = 1)
end

In the future we will deprecate the first syntax.
Since we'll be making type annotations on instance variables mandatory, and since we already can do things like:
property x : Int32

it makes sense if we could also do:
property x : Int32 = 1

Or:
record Point,
  x : Int32 = 0,
  y : Int32 = 0

Right now x : Int32 = 1 doesn't parse, but it could eventually parse as a TypeDeclaration node with an initializer. Macros such as property and record could use this initializer. Then, of course, the TypeDeclaration node by itself would declare the var and initialize it (#919).
But, if we are going to do this, it would be nice to keep consistency and have method arguments follow the same order (which is also a bit more intuitive, I think).

(there is a bit of duplicated code in the PR, but it will go away once we remove the first syntax, so that's why I didn't bother to refactor)

I also made the formatter change the old syntax to the new syntax, so the migration is easier :-)
Anyone has any reason against this change? Otherwise I'll merge it. /cc @waj @jhass @ysbaddaden

Syntax looks weird. But the original was just as weird, so I guess it won't change much.

I like it, that's how it's currently haxored together in Onyx, though, there, for the inst-var, two consecutive nodes are gen'ed in order to handle the restriction and the assign.
If there's anything I can be tasked with to get it to use a single node, I'd be happy to help.


GRU

Adds working GRU layer and test, as well as a dot product operation

@Anonymission I pulled this into master on my fork of MyGrad. There were a couple of issues with null_gradients that I fixed and added a couple of checks to the unit test. This is so awesome! Excellent work. I'm really interested to see this be trained.

Great! I need to set up a spare computer to let this train for a while, but once it's done I'll let you know the results.
On a side note, the _gru_dLdx function is not required for the code to work; it was part of my experimenting and I forgot to remove it.


This Blip video throws a 404 error

[thomas@chansey ~]♣ youtube-dl -v "http://blip.tv/foldablehuman/s3e2-1-end-of-eva-follow-up-6558464"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://blip.tv/foldablehuman/s3e2-1-end-of-eva-follow-up-6558464']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.08.10
[debug] Python version 3.4.1 - Linux-3.16.1-1-ARCH-x86_64-with-arch
[debug] Proxy map: {}
[BlipTV] 6558464: Downloading video RSS
[BlipTV] 6541774: Resolving URL for Source
[BlipTV] 6541774: Resolving URL for Blip SD
[BlipTV] 6541774: Resolving URL for Blip LD
[BlipTV] 6541774: Resolving URL for Blip HLS
[debug] Invoking downloader on 'http://j-mirror.video2.blip.tv/Foldablehuman-S3E21EndOfEvaFollowUp254.mp4?ir=406114&sr=18170\n\n'
ERROR: unable to download video data: HTTP Error 404: Not Found
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 1022, in process_info
    success = dl(filename, info_dict)
  File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 998, in dl
    return fd.download(name, info)
  File "/usr/lib/python3.4/site-packages/youtube_dl/downloader/common.py", line 291, in download
    return self.real_download(filename, info_dict)
  File "/usr/lib/python3.4/site-packages/youtube_dl/downloader/http.py", line 58, in real_download
    data = self.ydl.urlopen(request)
  File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 1231, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python3.4/urllib/request.py", line 461, in open
    response = meth(req, response)
  File "/usr/lib/python3.4/urllib/request.py", line 571, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.4/urllib/request.py", line 499, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.4/urllib/request.py", line 433, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.4/urllib/request.py", line 579, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

For comparison, the previous episode, which downloads correctly.
[thomas@chansey ~]♣ youtube-dl -v "http://blip.tv/foldablehuman/s3e2-end-of-evangelion-and-the-audience-author-membrane-6540094"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://blip.tv/foldablehuman/s3e2-end-of-evangelion-and-the-audience-author-membrane-6540094']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.08.10
[debug] Python version 3.4.1 - Linux-3.16.1-1-ARCH-x86_64-with-arch
[debug] Proxy map: {}
[BlipTV] 6540094: Downloading video RSS
[BlipTV] 6523404: Resolving URL for Source
[BlipTV] 6523404: Resolving URL for Blip LD
[BlipTV] 6523404: Resolving URL for Blip SD
[BlipTV] 6523404: Resolving URL for Blip HLS
[BlipTV] 6523404: Resolving URL for Closed Captioning - Spanish
[BlipTV] 6523404: Resolving URL for Closed Captioning - Spanish
[debug] Invoking downloader on 'http://j31.video2.blip.tv/11760011693529/Foldablehuman-S3E2EndOfEvangelionAndTheAudienceAuthorMembrane773.mp4?ir=549197&sr=18176\n\n'

Works with latest version. Closing.


Create a list of builders with pictures of their rover

I think it would be fun // lower the barrier to contribution if we had a readme with a table containing images and short descriptions of some of the builders' OSRs. People would submit a PR to have their rover featured on the page.

Agreed. Reposting in the slack

#322


with_data_center method does not work with chef-provisioning

According to the example docs on the chef-provisioning-aws repo, I should be able to define the data center that I want to provision machines in using the with_data_center method. That does not however work. The only way that I can define another data center to stand up instances is in my ~/.aws/confg file with the region setting.
Here is what the examples show...
with_data_center 'eu-west-1' do
  aws_sqs_queue "mariopipes"

  machine 'bowser' do
    machine_options :bootstrap_options => {
            :key_name => 'aws_key'
      }
  end

  load_balancer "webapp-elb" do
    load_balancer_options :availability_zones => ['eu-west-1a'],
                          :listeners => [{
                               :port => 80,
                               :protocol => :http,
                               :instance_port => 80,
                               :instance_protocol => :http,
                           }]
    machines ['bowser']
  end
end

with_data_center does not work, and is ignored if used in a recipe.

Can you file this under chef-provisioning-aws? This issue is specific to that provider. I have confirmed it works with the fog provider.

Yep!  https://github.com/chef/chef-provisioning-aws/issues/85


[Question]: How do i directly get the encoded frames???

Issue guidelines

[X] I've read the Issue Guidelines and wholeheartedly agree.

Issue Checklist

[X] I have searched open or closed issues for my problem and found nothing related or helpful.
[X] I have read the Documentation and found nothing related to my problem.
[X] I have gone through the Bonus Examples and FAQs and found nothing related or helpful.

Describe your Question
I am able to use vidgear, setup to read frames from usb camera, use ffmpeg, and encode to h264 format, i don't want to write it to a mp4 file or something, i just want the encoded frames as they come, to be in my local variable, i will use that to stream directly.
Terminal log output(Optional)
No response
Python Code(Optional)
No response
VidGear Version
0.3.3
Python version
3.8
Operating System version
windows
Any other Relevant Information?
No response

I am able to use vidgear, setup to read frames from usb camera, use ffmpeg, and encode to h264 format, i don't want to write it to a mp4 file or something, i just want the encoded frames as they come, to be in my local variable, i will use that to stream directly.
@Praveenstein Just use my another library DeFFcode that is made for this only. Let me know if you have any other questions!


Typo: calling an address a publisher key

For example, if the same publisher key, SZ2J6ZY48GV1EZ5V2V5RB9MP66SW86PYKKQ9H6DPR...  <-- Should be "address" or "public key hash".  Also, SZ isn't a valid address prefix -- neither in mainnet nor testnet (we only support SP, ST, SM, and SN).
https://blockstack-docs-git-feat-next.blockstack.vercel.app/smart-contracts/principals

fixed with #707


fix: Update bottom nav icons for selected/unselected state

Description:

Update the bottom nav icons on Main Dashboard for selected/unselected state

fix: LEARNER-10137

Tab
Selected Icon

LEARN

DISCOVER

PROFILE

Please update the images on the PR description.

Updated


Going back to vim mode after Shift-Escape?

Shift-Escape lands you in Jupyter Command Mode. Is there a keyboard shortcut to get back to vim mode?
 I just figured out that it can be done by hitting Enter

user peey: Thank you so much for asking this "stupid" question.  I was about to ask the same thing after days of trying to figure it out myself!  You saved me from embarrassing myself... 8-)


Update Flux and Flagger entries

Flux: update homepage and repo (flux2 now), add twitter
Flagger: it's just "flagger" now, update logo, update crunchbase too (cncf project through flux now)

Signed-off-by: Daniel Holbach<EMAIL_ADDRESS>Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[ ] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[ ] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Deploy preview for landscape ready!
Built with commit c9ae4ffadf508e280d23c458486f6e8c8dacf0c3
https://deploy-preview-2017--landscape.netlify.app

Deploy preview for landscape ready!
Built with commit 18ec3d972aa8a8864d60282d9149bafaf7220ef6
https://deploy-preview-2017--landscape.netlify.app

https://deploy-preview-2017--landscape.netlify.app/?selected=flagger
https://deploy-preview-2017--landscape.netlify.app/?selected=flux

LGTM

LGTM


Vulnerability roundup 114: moodle-3.11.4: 1 advisory [4.3]

search, files

[ ] CVE-2022-0984 CVSSv3=4.3 (nixos-21.11)

CVE details
CVE-2022-0984
Users with the capability to configure badge criteria (teachers and managers by default) were able to configure course badges with profile field criteria, which should only be available for site badges.

Scanned versions: nixos-21.11: 3c5ae9be1f1.
Cc @freezeboy

See also: #166672, #160678


Notebooks: Render SVGs as SVGs instead of Images

When rendering SVGs in notebooks today, tooltips (and other info) get lost, because we do the following:
const img = new Image();
img.src = `data:image/svg+xml,${encodeURIComponent(source)}`;

This follows the convention from JupyterLab, which appears to be the odd duck out for how they display SVGs.
Here's what happens in Jupyter:

[Untrusted]

[Trusted]
VS Code: https://github.com/microsoft/vscode/blob/d6e8feb774461355caf045fd6db88dc6aaccea5e/src/vs/workbench/contrib/notebook/browser/view/output/transforms/richTransform.ts#L167 (note that SVGs are displayed as is when executing):

With this change, this is what happens with ADS:

[Untrusted]

[Trusted]

Pull Request Test Coverage Report for Build 427008600

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 43.107%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/notebook/browser/outputs/renderers.ts
0
1
0.0%

Totals

Change from base Build 426986733:
0.001%

Covered Lines:
24118

Relevant Lines:
51267

💛  - Coveralls


Badly need incremental C++ builds

The bridge seems to recompile the entire C++ codebase every time it is invoked, even if only one file has been changed.  The "incremental" profile flag has no effect on behavior.
This is adding up to cost me over an hour per work day waiting on full rebuilds of our c++ lib
let mut bridge = cxx_build::bridges(&source_files).files(&cpp_files).cpp(true).clone();
//...

bridge.compile("lib");

Cargo's limited build.rs functionality has no way to handle this better. It sounds like you need to consider using a real multi-language build system, such as Buck2 or Bazel, which do not have this behavior.


Starting building that can grow ships

Some kind of larger organism that buds off ships.
Players can select a budding ship to detach it and start controlling it.

Blocked on #8


Flickering tests on Windows

Description
The

test_failure.py and
test_time.py

are failing from time to time.
The reason might be the lower resolution of time ticks on windows.
It could be easily fixed by adding a time sleep(0.1). But that's not the right solution IMHO.
A possible solution could be to use  timeit.default_timer() in bar.py, which has a finer resolution on windows.
Versions

Python 2.7.14 / Python 3.6.3
Anconda
Windows 10
Progressbar: 3.34.4

In that case it might be something that would have to be monkeypatched with the tests. I've been burned by the performance impact of replacing the timer before.
Some people literally call the update millions of times in which case replacing the timer can make a huge difference.

Agreed, performance is always an issue, but:
Windows:
python -m timeit -c "import timeit; timeit.default_timer()"
1000000 loops, best of 3: 0.478 usec per loop
python -m timeit -c "import time; time.time()"
1000000 loops, best of 3: 0.572 usec per loop
And on Linux the identical function to time.time() is called.
python -m timeit -c "import time; time.time()"
1000000 loops, best of 3: 0.236 usec per loop
python -m timeit -c "import timeit; timeit.default_timer()"
1000000 loops, best of 3: 0.23 usec per loop
So what was the issue then?

The problem is that it depends on both the windows/linux version and the python distribution (anaconda vs. regular) which makes it notoriously difficult to test for.
For example, read this blog post as well about a similar issue with Java: http://pzemtsov.github.io/2017/07/23/the-slow-currenttimemillis.html

Thanks, interesting reading.
So it looks to me that it is accepted for performance reasons, to have a lower resolution on windows, which makes totally sense to me. The tests is somewhat testing the resolution of the timer and only works on systems with higher resolutions. So I would suggest skipping the test on Windows instead of pretending that the code would match the test, by mocking it.


some context menu items (text) are not aligned

right-click on the torrent that has not been downloaded yet

I know about this problem, but I don't know how to fix it

I tried to fix it but couldn't, most likely these popup elements after downloading torrents have completely different properties, but I don't have that much time to figure it out right now. if you find a solution then you can open a new issue

This might be due to missing leading icons for context menu items.


Add persistent toasts

Sometimes we need to show toast until it's dismissed by user or programmatically. E. g. connection lost and notification is shown until it's back online. Or some long or slow process happens.
It is not always possible to use toast.promise for that. Currently I use very long duration to simulate persistent toast.
Is it possible to add persistent toast, which doesn't have any timers inside them? Then it would possible to do:
const id = toast('No connection.', { persistent: true });

toast('Connected.', { id, persistent: false })

Would { duration: Infinity } do the trick for you?

Just tried. Toast won't even show. I tried both my custom toast and default one.

You are right. That's weird. I'll look into this.

Does toast("Endless", { duration: -1 }) makes sense to you? Was the easiest fix I can think of, not sure if it's the best API though.

@timolins I think it would be better to just do if (isFinite(duration)) { set timeout } and keep using the { duration: Infinity } API.

Thanks for the feedback! I agree with you, using Infinity seems like the more intuitive API. Will update and merge the PR :)


Fixed outdated dependencies

Changes
Previously, our dependencies were incredibly outdated-- this was due to inadequate merging of dependabot suggestions. This led to issues with cloning and developing on our website, and attempting to install dependencies would lead to "npm sharp" errors among other things that prevented local building.
Here, I've manually went through all the dependencies to update them, and also fixed some minor outdated GraphQL syntax and other issues that arose after resolving all the conflicting dependencies.
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)

Related Issues
Link the relevant issue here
#453

Errors are resolved and local build seems fine but the deploy looks weird. Potential culprits to investigate further

MUI issue
Differences between development environment and deploy environment


Get plain-language-accessibility blog approvals

Email sent to Chris with Lindsay cc'ed on 9/23/24

Chris approved, will publish soon.


Misimplementation of Spatial-attention?

Thank you for your incredible work!
However, I believe there is a mistake in the implementation that I'd like to point out. In the paper, it is described as follows:

Given a feature map $x_1 \in \mathbb{R}^{t \times h \times w \times c}$ from the denoising UNet and $x_2 \in \mathbb{R}^{h \times w \times c}$ from ReferenceNet, we first copy $x_2$ by $t$ times and concatenate it with $x_1$ along the $w$ dimension. Then we perform self-attention and extract the first half of the feature map as the output.

The part of the code I am concerned about is found here:
https://github.com/MooreThreads/Moore-AnimateAnyone/blob/02a4342b17fe58a18a196f12eb702c50978456b7/src/models/mutual_self_attention.py#L158-L165
My understanding is that after concatenation, the feature map should be subjected to self-attention, and only the part corresponding to $x_1$ should be retained. This means that the $K$, $Q$, $V$ in attention should all be modify_norm_hidden_states. In your implementation, $K$ and $V$ are a concatenation of the pose embedding and ref_image embedding, whereas $Q$ is solely the pose embedding.
Therefore, I believe the code should be as follows:
hidden_states_uc = self.attn1(
   modify_norm_hidden_states,
   attention_mask=attention_mask,
)[:, :hidden_states.shape[1]]
hidden_states_uc += hidden_states

Sorry, my mistake. Your code is also correct.

I've reopened this because there's one aspect that concerns me.
The distribution after projecting Q, since it does not include the embedding of the ref_image, might deviate slightly from the intent described in the paper. I'm unsure about the extent of this impact. Has this been considered?

I have the same question as you. Have you figured it out? Which implementation do you think is better?


redo readme

Description
Redo the readme to make it more friendly. rendered
Motivation and Context

We were missing examples, and more details on how we operate. This makes the README a bit more compelling, which should also help when linking to Crates.io.
How Has This Been Tested?

Just a readme, copied the example from the examples dir.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Good work making the README more informative and approachable. :+1:


dasdsdsa

adasdsffsatest
test

Hope this is useful!
Cheers,
Cinnabot.

Hi, I have some suggestions to help solving this issue!
Here is a list of similar issues:

1. [adsdssd](https://github.com/fjsj/python-social-auth/issues/24)

2. [dssasddassad](https://github.com/fjsj/python-social-auth/issues/23)

3. [dsads](https://github.com/fjsj/python-social-auth/issues/21)

4. [New issue](https://github.com/fjsj/python-social-auth/issues/20)

5. [issue](https://github.com/fjsj/python-social-auth/issues/10)

Also, fjsj made a PR to close a similar issue, so it might be good to ask them for help.
Hope this is useful!
Cheers,
Cinnabot.


build: deploy blog preview on pull request

Add everything needed to deploy previews on pull requests.

One other thing: can we have this create a deployment so there's a clickable link in the PR?

Done

This LGTM but I'd like someone from @SwissDataScienceCenter/kartografen to review it as well... 🙌


Display skipped executions warning for metrics

Description
Corresponding PRs:

https://github.com/dockstore/dockstore/pull/5822
https://github.com/dockstore/dockstore-support/pull/486
https://github.com/dockstore/compose_setup/pull/251

This PR displays a warning icon if the aggregated metric had executions that were skipped during aggregation. The tool tip displays the number of executions skipped.

Review Instructions
Verify that this workflow (to be filled in) has a skipped executions warning in the Metrics tab.
Issue
SEAB-6046
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that your code compiles by running npm run build
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[x] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[x] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[x] Do not use cookies, although this may change in the future
[x] Run npm audit and ensure you are not introducing new vulnerabilities
[x] Do due diligence on new 3rd party libraries, checking for CVEs
[x] Don't allow user-uploaded images to be served from the Dockstore domain
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
[x] Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

This PR displays a warning icon if the aggregated metric had executions that were skipped during aggregation. The tool tip displays the number of executions skipped.

If I understand correctly, I feel like the warning is a bit too prominent for the following reasons

Once we start skipping executions, even if new executions in the future are fixed, the older skipped executions will remain and be skipped in the future
Even one skipped execution in thousands of runs could cause the icon to pop up
The icon isn't really actionable for end-users, just the platform owner

Brainstorming:
Not sure how to display though, ideas

"Skipped executions" with a tooltip next to aborted executions without the icon?
Info icon, not warning icon?
Display only to admins, curators, and platform owners?

Does a user need to know in detail that, for example, the memory metric aggregation was skipped 8 times, but the CPU metric was skipped 11 times? I would argue not.

I'm actually toying with the idea that users with the platform partner role may want to know about skipped executions, I'm not sure regular user types should

* How frequently are executions skipped in our current data set? Is this a once in a blue moon sort of thing, or will it be fairly common? If it's reasonably common, I would be tempted to just have another column with the number.

Not frequently -- I don't think we have any skipped executions right now because we've been ingesting data for the platforms. Ideally, the webservice should not let any invalid data get in, which is improved with https://github.com/dockstore/dockstore/pull/5822. So I think the chances are low that there are skipped executions because the webservice would throw an error first.

* Does a user need to know in detail that, for example, the memory metric aggregation was skipped 8 times, but the CPU metric was skipped 11 times? I would argue not.

I included it so the user knows how many executions were used to aggregate the metric. For example, an average over 100 executions is different from an average over 1 execution where the other 99 were skipped.

* What if we captured the total number of skipped aggregations at the top along with Total/Successful/Failed/Aborted? I guess the skipped is at different level though, a single execution could have more than one skipped, right?

Yeah, it's scoped to the metric level. So for a single execution, it could be skipped for multiple metrics.


Add zoom slider for freaks with clicky scroll wheels

fixed with https://github.com/datadesk/web-map-maker/commit/1d381a219035f49c4759e84dc03091c2e0dad6b2


Duplicate header entries

When doing a full export, script will now load all productTypes and for every productType it creates a header and export products.
If the productType has a custom attribute with the same name as one of the common attributes (categories, images, taxCategories, ..etc) it will create template with duplicate entries, for example:
_published,productType,variantId,id,sku,categories,channels,categories
And the export will fail with an error: There are duplicate header entries!
This can happen only for old projects because sphereApi should have attribute.name restriction now which permits user to create attributes with duplicate names.
I created this PR which removes duplicit header entries from generated template so the full export will work but it will skip custom attributes named as the common attributes: https://github.com/sphereio/sphere-node-product-csv-sync/pull/142

Updated here https://github.com/sphereio/sphere-node-product-csv-sync/pull/142 currently on hold (this issue can happen only on outdated projects)

I am closing this issue because we discovered that this issue can happen only on a really old project which did not have restrictions for attribute names and it should not occur again

@junajan One can still create attributes named "productType" via AdminCenter. I did it some weeks ago and ran into this issue. I renamed it and it export worked.

@ValeSauer I think this should be reported to the API. It should be avoided from the API level....

I agree with Abi - it should be handled on API because there can be other possible issues when there are multiple attributes with the same name.


Water and Lava textures on schematic overlay garbled

If any mods are installed which register textures in the block atlas, water and lava on schematic overlays will have random garbled textures.
The reason is that SchematicBlockRendererDispatcher is not registered as a resource reload listener (the default dispatcher is), so the sprites (and UV coords) from the initial vanilla block atlas are used forever by the dispatcher's BlockFluidRenderer.

Thanks! Must've missed it while trying to get the overlay working.


Solved CMake exercises by kieslijn

Build instructions
Open this repository in VSCode, type Ctrl + Shift + P and enter: "Dev Containers: Reopen in Container"
The process of building the container takes a while.
When finished, VSCode is opened inside the container and the files of the repository are mounted under /workspaces and the folder name under which the repository was cloned.
The project can be built with CMake and Make:
mkdir build
cd build
cmake .. && make
The program can be executed with: ./cmake-exercise in the build directory.

Looks good in principle, but build_and_run-sh script cannot be used like it is.

Thanks for the tip, i renamed the executable and it should now be compatible with the setup when starting the Devcontainer and running ./build_and_run.sh in the root of this repo.

Thanks for the quick fix. Closing here to keep the overview.


Admin UI Requirements

Admin UI for RHODS configuration and settings
Issues

Admin UI for admins to configure NB container sizes

https://github.com/opendatahub-io/odh-dashboard/issues/467

Admin UI for mapping RHODS groups

Description
As a RHODS admin, I need to be able to configure RHODS for use with the settings that match my organization's needs.
Note: The settings items would apply across the cluster.
Requirement 1
P0: Setting for culling idle notebooks (# of minutes to keep pod up after user stops NB server). Default is 0 or no culling of idle notebooks.
Requirement 2
P0: Ability to map RHODS allowed/user group and admin group to defined groups
(without having to edit config map).
Requirement 3
P0: Ability to configure custom NB sizes (aside from OOTB sizes).
P1: Ability to configure which NB sizes are available for selection.
P2: Ability to configure default PVC size for users. Ability to restore system default.
Requirement 4
P0: Ability to edit opt in/out for specific notifications and user emails that should receive notifications.
Requirement 5
P0: Ability to edit opt in/out for sending user interaction data.
Requirement 6
P0: If Red Hat modifies default values (eg. default PVC size) in a future release, the defaults should only be updated if an admin hasn't changed the default. For example, if the system default for PVC size is 20 GB and an admin changes to 40 GB, then Red Hat updates the default to 30 GB, the change should only apply to clusters that still have the original default value.
Requirement 7
P2: Ability to export config settings and import to another environment. Use cases: organization with multiple clusters.
TBD: Ability to configure log out period for users. For example, we will set a default, but admins should be able to modify the default. Ability to restore default. Note: this capability exists in OSD today.
Notes

In the future, we could include additional groups/permissions capabilities: 1) define access rights for groups (eg. ability to access specific OOTB images or create specific sizes); 2) define custom groups and define access rights (eg. group that can access Seldon).
We expect some of the custom notebooks functionality to be limited to admins. That will be addressed in the custom notebooks epic.
Admins should be able to configure tolerations for Jupyter notebooks. That will be addressed in a separate linked story.

This will be properly tracked when it's on the roadmap again -- requirements slip, it's been a while since this was looked at and we have changed the way we track items now -- seems more headache to keep this floating than to just redo it when the time comes.

Migrated to jira:  https://issues.redhat.com/browse/RHOAIENG-333


Cockroach DB driver

Planned, but yet unscheduled.
Note: additional information follow as soon as the details are clear.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/34056719-cockroach-db-driver?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github).

A cockroach driver is published and being currenlty extended.


Add JoinOn and GroupJoinOn query methods

Are there .NET equivalents of these? We mostly maintain the symmetry.

I think we've been largely maintaining the symmetry. Other maintainers can also chime in if they feel like this is needed.


Generation of contours for plotting is carried out by scikit-image.

Solves #284.

How did you arrive at the >=0.10.0 version requirement?

I could not install any previous version via pip. That said, those versions may work, but if they can't be installed via our installation mechanisms then I see no reason to support them.


Indentation Bug: constant dictionary

A minimal example is as below. every step I only type o to trigger to indentation.

import logging

# from: https://stackoverflow.com/a/56944256
class CustomFormatter(logging.Formatter):
    GREY = "\x1b[38;20m"
    YELLOW = "\x1b[33;20m"
    BLUE = "\x1b[34;20m"
    RED = "\x1b[31;20m"
    BOLD_RED = "\x1b[31;1m"
    RESET = "\x1b[0m"
    CONTENT = "%(levelname)s - %(message)s (%(filename)s:%(lineno)d)"

    FORMATS = {
        logging.DEBUG: BLUE + CONTENT + RESET,
        logging.INFO: GREY + CONTENT + RESET,
        logging.WARNING: YELLOW + CONTENT + RESET,
        logging.ERROR: RED + CONTENT + RESET,
        logging.CRITICAL: BOLD_RED + CONTENT + RESET
    }

    def format(self, record):
        log_fmt = self.FORMATS.get(record.levelno)
        formatter = logging.Formatter(log_fmt)
        return formatter.format(record)

"\x1b[38;20m" line is enough actually to recreate this issue.
I think there is a problem with parsing brackets inside of strings (regardless of escape chars). Another issue that I have is with curly brackets:
var = 0
f'{var} {{'

Or even this
asd = '{'

This will also create the same issue and it's really annoying.


Enigma themed landing page

Current landing page is simple, lets make it more interactive and suspenseful ,
1. Website name
2. Tagline
3. CTA button
4. what is this website about
as anonymous  story treasure lets make it secure and more appealing.
Assign this task to me.

Current landing page is simple, lets make it more interactive and suspenseful ,
1. Website name 2. Tagline 3. CTA button 4. what is this website about
as anonymous  story treasure lets make it secure and more appealing. Assign this task to me.

@psidh is already assigned with this issue if he is unable to raise a PR within 5 days then I will assign this issue to you.

Current landing page is simple, lets make it more interactive and suspenseful ,
1. Website name 2. Tagline 3. CTA button 4. what is this website about
as anonymous  story treasure lets make it secure and more appealing. Assign this task to me.

do star the repo

👍

Hi @Sayak-Bhunia
I want to work on this issue under GSSOC24. Please assign it to me.
Thanks

@psidh is already assigned with this issue if he is unable to raise a PR within 5 days then I will assign this issue to you @rishyym0927 .


Generalise "simulation" to "computational experiment or analysis"

Although Sumatra was developed in the context of simulation-based computational neuroscience, it is clear that it could be useful in computational sciences more generally, and for computational analyses as well as for simulations. The documentation and class names should be modified accordingly.
Imported from Bitbucket issue 5,  created by apdavison on 06-25-2010 at 15:33, last modified: 06-30-2010 at 15:20

Done in r130:3d7bd7e1df2d
Trac comment by apdavison on 06-30-2010 at 15:20


add supply-stats route to show total supply and rich list

Note: the data shown here may not be correct due to issues with my local environment.

so awesome!!

oh my, hope I in the list, haha


Button motion updates

Overview
Updates to the button motion with the System 360 Motion specs, which defines shorter duration and a set of new curves.

resubmitting after rebase fixes

Added

A new$bx-- ease-in-out variable was added in src/globals/scss/_vars.scss

@ibm/motion was added as a dev dependency.

proxies for the @ibm/motion methods were added:

src/globals/js/misc/motion-generator.js
src/globals/js/misc/motion-getDuration.js
src/globals/js/misc/motion-getCurve.js

Changed
The following variables were updated:
$bx--ease-in
$bx--ease-out
$bx--standard-easing
$transition--base
$transition-expansion

Testing / Reviewing
Run $ npm run test and look under button unit test.
Staging URL:
http://carbon-dev-environment-bracteate-akvavit.w3ibm.mybluemix.net/demo/primary-button

👀 ✅
I don't know a whole lot about motion so I'll defer to Tayler's final say but I think this one feels pretty good and natural. It behaved as I would have expected to behave. I like the transition across the sets.

👍 ✅
This motion is snappy and at the appropriate speed for the component.  A good improvement on the more delayed motion we had on the hover color change before. Good work on this one @wonilsuh!


input and array input revert action invalid

In GitLab by @liyanq528 on Sep 27, 2017, 15:18
fixed issue 325,387 and modify some RegExps for buildimage

In GitLab by @liyanq528 on Nov 8, 2019, 07:38
fixed by pull request #486

In GitLab by @sokril on Nov 8, 2019, 08:12
closed

In GitLab by @sokril on Nov 8, 2019, 08:12
assigned to @liyanq528


Install gcc-arm-linux-gnueabihf and binutils-arm-linux-gnueabihf for cross compiling arm

Cross compiling for arm takes several extra minutes because gcc-arm-linux-gnueabihf and binutils-arm-linux-gnueabihfneed to be installed first during a build. For some images relying on buildpack-deps like the official rust image, cross compiling C bindings requires the C cross compilers.
The fix would be to add gcc-arm-linux-gnueabihf and binutils-arm-linux-gnueabihf to the list of installed packages for the image.
https://github.com/rust-lang/docker-rust/issues/53#event-2929276895

Quoting from https://hub.docker.com/_/buildpack-deps/:

The main tags of this image are the full batteries-included approach. With them, a majority of arbitrary gem install / npm install / pip install should be successful without additional header/development packages.

In that context, I don't think cross-compiling tooling really fits since cross-compiling tools would typically be used to build binaries for something other than the current platform (and this repository is targeting being a use-as-is base, not as a build environment to create things for other platforms).
What I'd recommend is creating for yourself a short Dockerfile which is FROM rust:xxx and installs the necessary/appropriate tooling for your desired use case, and set up something like Docker's automated builds to keep it up-to-date for you.


Add example program and make this repository compile by itself.

If I understood it correctly, this repository was meant to be used as a submodule in an other project and therefore the CMakeLists.txt file was kept minimal.
I on the other hand wanted to test this repository and check whether it compiles and runs with my current setup [compiler, Qt version]. To that end I would have liked a minimal example.
In addition I was somewhat confused about the "INTERFACE" nature of the "library". If you don't like my changes regarding to that point, simply let me know and I can revert them.
So thanks for this great project. And I would be glad about any feedback.

So the idea is to make QHexView as static library with a "sample" executable?
The sample code can be simplified as (not tested!):
#include <QApplication>
#include <qhexview/qhexview.h>

int main(int argc, char** argv) {
    QApplication a{argc, argv};

    QHexDocument* doc = QHexDocument::fromFile(QApplication::applicationFilePath());

    QHexView view;
    view.setDocument(doc); // No parent, it takes the ownership of 'doc'
    view.show();

    return a.exec();
}

Thanks for the feedback.
Feel free to let me know about any desires to simplify the CMakeLists.txt files.
Or if you feel like it, feel free to adapt them yourself. I don't mind.

I just integrated this widget into my app, and my experience is ... just boringly good :)
I am using CPM for integration, then in my CMakeLists.txt  added:
CPMAddPackage("gh:Dax89/QHexView#v5.0.0")
...
target_link_libraries(myapp PUBLIC ... QHexView)

Inside your code you just:
#include <model/buffer/qmemorybuffer.h> // I needed this for my own code
#include <qhexview.h>

And it just works. My CICD also compiles for windows, and I got no errors. It just works.

This commit https://github.com/Dax89/QHexView/commit/2bafc90b79d0957374babf682832e347e8a1d89f reorganize the source code, I have also added an example and changed CMake's target in order to generate a static library.
See here for more details: https://github.com/Dax89/QHexView/discussions/83?converting=1#discussioncomment-10846595.
Let me know if I have missed something!

diff --git a/src/qhexview.cpp b/src/qhexview.cpp
index 1d44009..2af7d25 100644
--- a/src/qhexview.cpp
+++ b/src/qhexview.cpp
@@ -18,7 +18,7 @@
 #include <limits>

 #if defined(QHEXVIEW_ENABLE_DIALOGS)
-#include "dialogs/hexfinddialog.h"
+#include "QHexView/dialogs/hexfinddialog.h"
 #endif

 #if defined(QHEXVIEW_DEBUG)

@diegoiast fixed and pushed, thanks!


Browse Explorer without login

The user have to login to view the sidebar and visit the explorer
I believe we need to add a button on the home page that redirects to the explorer without connecting the user profile.

closing in favor of https://github.com/threefoldtech/tfgrid-sdk-ts/issues/1314


expose doc store cache size

expose lru doc store cache size
optimize doc store cache size

Codecov Report

Merging #1403 (97c48bb) into main (db18366) will decrease coverage by 0.07%.
The diff coverage is 54.00%.

:exclamation: Current head 97c48bb differs from pull request most recent head 4f57747. Consider uploading reports for the commit 4f57747 to get more accurate results

@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
- Coverage   94.32%   94.25%   -0.08%
==========================================
  Files         236      236
  Lines       43640    43695      +55
==========================================
+ Hits        41165    41185      +20
- Misses       2475     2510      +35

Impacted Files
Coverage Δ

src/store/mod.rs
99.17% <ø> (ø)

src/store/reader.rs
82.65% <28.57%> (-4.55%)
:arrow_down:

src/core/searcher.rs
83.46% <33.33%> (-5.24%)
:arrow_down:

src/indexer/merger.rs
98.97% <100.00%> (+<0.01%)
:arrow_up:

src/reader/mod.rs
94.26% <100.00%> (+0.14%)
:arrow_up:

src/directory/directory.rs
90.14% <0.00%> (-3.98%)
:arrow_down:

src/postings/stacker/expull.rs
98.57% <0.00%> (-0.48%)
:arrow_down:

src/directory/error.rs
1.63% <0.00%> (-0.33%)
:arrow_down:

src/directory/mmap_directory.rs
91.08% <0.00%> (+0.02%)
:arrow_up:

src/directory/managed_directory.rs
88.88% <0.00%> (+0.63%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db18366...4f57747. Read the comment docs.

that PR is allowing to set the cache size on the docstore. The PR does not really explain why.
My understanding is that the benefit is to allow a cache of size 1 when merging?
Could this be done on segment reader creation?
Or not done at all actually? Are you thinking of enabling a large LRU size?

that PR is allowing to set the cache size on the docstore. The PR does not really explain why. My understanding is that the benefit is to allow a cache of size 1 when merging?
Could this be done on segment reader creation? Or not done at all actually?

One benefit is to reduce the cache size for merging. The other benefit is to reduce memory consumption for quickwit fetch_docs. The cache size is much more important with the larger blocks now.


Filter on auto-invite

With the auto-invite feature people seem to have a lot of issues with it being able to form groups without interacting with people.   I see that issue #60 is meant to deal with that by making it work on custom only.   is it possible to add 2 additional fields for auto-invite in the options that say auto-invite ONLY if:
1.) person is in your guild
2.) person is on your friend list
Or have an in-addon list of "whitelist" people who can auto-join a group.  This way people can further fine tune the auto invite.
Keep up the great work on this addon, despite what some people may think of it :)

I like the idea for friends and guild mates only, I think the whitelist is a bit to unhandy! Thanks for the support and suggestion!

I agree as it would cause people to have to keep a "friends" list and a "whitelist" list for players though in theory the whitelist could be longer than the friends list.  Was just throwing it out there but I think a guild / friend list only option would be a solid foundation start that might make people more open to the idea.

I removed the auto invite completly for now, will probably bring it back with the limitations stated here if the new API changes are going to allow for it.


Inconsistent undefined in properties

In my config I want to use the /NullValue:Undefined cli option for the generation of a Angular Api Client.
This was no real issue before, since I had strict disabled in my tsconfig, but since I changed it we found an issue.
When I use undefined as our nullvalue, object types get a null check.
_data['endDate'] ? moment(_data['endDate'].toString()) : <any>undefined;

The issue now is that the string does not get such a check.
And I also think other primitive values suffer from the same fate.
So from the backend I get a null from the api call.

The property is defined with undefined.
export class DetailItem {
    dueDate?: moment.Moment | undefined;
    followUpComment?: string | undefined;

    ...
}

But in the assign from the value we are missing the null check.
this.followUpComment = _data['followUpComment'];

for objects this happens with a check.
this.dueDate = _data['dueDate'] ? moment(_data['dueDate'].toString()) : <any>undefined;

So the desired behaviour would be the same as for an object for primitive types, or something simliar to this:
this.followUpComment = _data['followUpComment'] ?? <any>undefined;

That way i can be sure the value is undefined and not null.
Since null should not even be allowed from the configuration.
The issue is similar to this discussion.
https://github.com/RicoSuter/NSwag/issues/926#issuecomment-327509835

Having the same issue which inevitably raises null/undefined exceptions. Generating using swagger.json and (latest) NSwagStudio v<IP_ADDRESS>:
Example swagger.json snippet:
      "Foo": {
        "type": "object",
        "additionalProperties": false,
        "properties": {
          "Dates": {
            "type": "array",
            "nullable": true,
            "items": {
              "type": "string",
              "format": "date-time",
              "nullable": true
            }

Generates the following typescript:
export class Foo implements IFoo {
    dates?: (Date | undefined)[] | undefined; // Correct: Defines dates array as potentially containing undefined elements

    // ...

    init(_data?: any) {
        if (_data) {
            if (Array.isArray(_data["dates"])) {
                this.dates = [] as any;
                for (let item of _data["dates"])
                    this.dates!.push(new Date(item)); // Correct: Initialises (Date | undefined) array with potentially undefined dates at their expected indexes
            }

    // ...

    }

    // ...

    toJSON(data?: any) {
        data = typeof data === 'object' ? data : {};
        if (Array.isArray(this.dates)) {
            data["dates"] = [];
            for (let item of this.dates)
                data["dates"].push(item.toISOString()); // Incorrect: item may be null/undefined and is never checked, toISOString() throws
        }

        // ...
    }
}


[Enhancement] Make control_mode pd_ee_pose for target pose control

I saw in the road map document that one of the goal is to benchmark different BC models, including 3d diffusion policy.
In the original diffusion policy paper, the author recommends using position control, rather than velocity control (i.e.) delta position control), of end-effector pose, as it helps with their task completion performance.

In the controllers guide in the library, (https://github.com/haosulab/ManiSkill/blob/e4cb238e5b5eee78bb7175988222fe071381c91d/docs/source/user_guide/concepts/controllers.md), I found this sentence that says
'At the moment we only support fast GPU accelerated delta end-effector control. Support for GPU accelerated absolute end-effector control requires some much more complicated code but can be possible if one uses cuRobo to generate motion plans given target poses.'
Could you elaborate a bit on what the difficulty is for implementing absolute end-effector control? I initially thought you should be able to generate the target pose as long as you have the target joint pos. It would be a great addition to have the target eef pose control as it has clear benefits for some BC algorithms.
Also, on a tangent, I am also curious the reason for selecting angle-axis representation for orientation control. Are there particular benefits to doing this than using quaternion?
Thanks for all the great work!

Thanks for the kind comment!
For GPU simulation, trying to go to a specific target may require multiple steps. Currently cuRobo is i think the only GPU parallelized library for doing this kind of motion planning. For delta targets / control, computing a jacobian is simple and easy and a few simple/low overhead libraries exist to do that. I did not add cuRobo as it is a bit heavy to use and I did not find it easy to integrate / not an expert on tuning it.
In CPU simulation, computing a motion plan to go to a specific pose is possible, our code does that already (create a pd ee pose controller that has delta=False in the config).This is sufficient for those testing diffusion policy since you do not need GPU simulation for evaluation, you can just use the CPU sim. If you want faster evaluation (e.g. leverage parallel rendering for faster image obs generation) then you need the GPU sim but you can probably hardcode a for loop using a CPU based IK solver to determine the low-level control action given target EE pose.

Thanks for the prompt response.
I am a bit confused about your answer on CPU vs GPU simulation. Didn't fast_kinematics do IK for gpu environment also? Or I guess with your latest update you started using pytorch_kinematics. So I guess my question is what is preventing from setting config.use_delta as true and use gpu?

Oh you can use GPU sim + delta end effector control (use delta is True). That is certainly possible.
With use delta false that would require a different algorithm that I haven't investigated deeply. My understanding is diffusion policy papers definition of "position control" is absolute pose control?

Oh my bad, I meant that if you set config.use_delta as false. My confusion comes from my assumption that pose_absolute  = pose_robot * pose_delta, making calculating pose_absolute trivial. Is this correct?

@sean1295 late update but I recently figured out the right way to do it. It is not as simple as pose_absolute = pose_robot * pose_delta to compute the delta action. On GPU, we currently use a fast approximation of delta IK controller, but that does not work well the larger the delta action it is.
In the scenario where use_delta is False, we must assume the target pose in GPU sim might not be close by at all, and must a iterative optimization algorithm to compute the target joint positions in that setting.
I have an implementation I am testing now in this PR #536 which is adding GPU parallelized real2sim environments from a project called SIMPLER, which happens to require the pd_ee_target_pose controller (this is what one of the real robots uses). Will comment here and close the issue once merged and share an example.

You can test this new GPU based IK controller on panda, there's a new pd_ee_pose controller which accepts absolute poses of the end effector (in the robot base frame at the moment)

Awesome! Thanks for the update! I have just played around with that and have lingering questions regarding the pose itself. Following was the code I ran, which is to basically track the pose of the cubeA in the stacking task.
import gymnasium as gym
import mani_skill.envs
import roma
import imageio
num_envs = 1 # you can go up to 4096 on better GPUs
env = gym.make("StackCube-v1", num_envs=num_envs, obs_mode = 'state_dict', control_mode = 'pd_ee_pose', render_mode = 'rgb_array')
imgs = []
obs, _ = env.reset(seed=0)
done = False
for _ in range(30):
    pos = env.cubeA.pose.p - env.agent.robot.pose.p
    ori = roma.unitquat_to_rotvec(env.cubeA.pose.q[:, [1,2,3,0]])
    gripper = torch.ones((1,1)).to(env.device)
    action = torch.cat((pos, ori, gripper), dim = -1)
    obs, rew, terminated, truncated, info = env.step(action)
    done = (terminated | truncated).any() # stop if any environment terminates/truncates
    imgs.append(env.render()[0].cpu().numpy())
imageio.mimwrite('video.mp4', imgs)

https://github.com/user-attachments/assets/be85696a-6193-4062-83b3-c78ea70c0982
This was based on my assumption that it is the absolute pose wrt robot base. (since robot base has identity quaternion). I think I get the accurate position tracking which is good, but am a bit confused which orientation action should be used. Your help would be much appreciated.

For quaternions/orientation you should just start with the current orientation as the action and modify it. The orientation of the end effector TCP (what IK is controlling) is not 0,0,0.
A simple (not optimized) solution is this:
from transforms3d import euler
euler.quat2euler(env.agent.tcp.pose.q.cpu().numpy())


Tree: Level Order Traversal

Add a code file in C++ of Level Order Traversal

could you assign this to me?

i can work on this, can you assign this to me? @amritansh22

@milanj-1 @khushi2912 Anyone of can do it. Just read the contribution guide and open a PR once done

can I work and open a pr

@rasacharjee Yes sure please go ahead

Thanks for helping me contribute to the issue. I have made a pr .I would be grateful if that's merged.


Make https://github.com/gruntwork-io/terragrunt/pull/2889 mergeable

Simply rebased and fixed a couple of small things to be able to review and merge the work of @rodrigorfk from https://github.com/gruntwork-io/terragrunt/pull/2889

Closing in favor of the original PR which is now fixed!


is there an objective-c version as swift files are much bigger when compiled

as swift files are much bigger

Unfortunately, there is not - the project is based on Objective-C project, you can find it here: https://github.com/cwRichardKim/RKSwipeBetweenViewControllers
It is not exactly the same since I have made some more or less minor changes to it but you can give it a shot. (closing for now, but do not hesitate to ask any other questions ✌)


Make all nodes in expressions a fixed length

The acceptExpression method of the htmlbars runtime is a source of a lot of V8 JIT churn because of BoundsCheck hoisting, if we made all the nodes the same length, just filling the empty slots with undefined, when the acceptParams and acceptHash loops caused the argument destructing BoundsCheck opcode to be hoisted outside the loop it would not cause a deopt because all nodes would be the same length.

Breakdown (after running the Ember test suite) of node.length counts:
Object {2: 8435, 3: 3323, 4: 2860, 5: 760}


fix: multi page mode app start event redundant logging

Description

fix multi page mode app start event redundant logging

General Checklist

[x] Added new tests to cover change, if needed
[ ] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[ ] Documentation update for the change if required
[x] PR title conforms to conventional commit style
[ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2eb9c1d) 100.00% compared to head (86bbacf) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           24        24
  Lines          987       994    +7
  Branches       182       183    +1
=========================================
+ Hits           987       994    +7

Files
Coverage Δ

src/tracker/SessionTracker.ts
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Disable f-m-p version upgrade in the release script as its causing is…

…sues right now.

[merge]


Samples throw exceptions on start

I just downloaded and built these 3 samples. The only one that executes is MediaEngineEMEUWP. The other 2 throw exceptions on debug start. Using VS 2019 16.8.3, with latest C++ redistributable.
I can provide stack traces if not reproducible.
I assume since one works, I have any necessary pre-req's installed.

The media content link at line#18 in MediaEngineUWPSample/src/App.cpp is no longer available. Replace it with a working link or local content path and it should work fine.

Yes, easy enough of a fix for both. Had assumed all 3 were looking at same url. Thanks.

Issue resolved


File download fails

Weights and Biases version: wandb.__version__ == '0.6.27'
Python version: 3.6.5 Anaconda
Operating System: Ubuntu 18.04

Description
When trying to download a file via wandb.Api().run("rmst/ssvg/rm8dpyrx").file('blip').download() it fails with
500 Server Error: Internal Server Error for url: https://api.wandb.ai/rmst/ssvg/rm8dpyrx/blip

The download via the web interface works. The metadata for 'blip' is also available through the API. Just download() seems to fail.

Hey @rmst.  I'm planning to release a new package today to address this issue.  In the meantime you can install from master to fix it:  pip install --upgrade git+git://github.com/wandb/client.git@master#egg=wandb

Awesome, such a quick answer and it works! Thank you!


scikit-learn standalone ctypes module

0.6.9rc6
Python: 3.7.6 (tags/v3.7.6:43364a7ae0, Dec 19 2019, 00:42:30) [MSC v.1916 64 bit (AMD64)]
Executable: E:\winpytest\WPy64-3760\python-3.7.6.amd64\python.exe
OS: Windows
Arch: x86_64
I installed python using winpython:
http://winpython.sourceforge.net/
and used pip install to get the newest prerelease from GitHub. I used this because I had the same issue as someone else with the released version but I am blanking on what it was I will look through issues and update.
There were no issues when I ran standalone on hello.py. I had associated my issue with scikit-learn and tried to create a simple test modifying hello.py. Scikit-learn version 0.22.1:
from sklearn.decomposition import PCA

def talk(message):
    return "Talk " + message

def main():
    print( talk("Hello World"))

if __name__ == "__main__":
    main()
    a=PCA()

What I ran, I used numpy plugin just in case:
python -m nuitka hello.py  --mingw64 --standalone --show-progress --show-scons --follow-imports --plugin-enable=numpy
Everything compiles fine, However when I run it I get:
E:\winpytest\WPy64-3760\notebooks>"E:\winpytest\WPy64-3760\notebooks\hello.dist\hello.exe"
Traceback (most recent call last):
File "E:\winpytest\WPy64-3760\notebooks\hello.dist\hello.py", line 1, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in load_unlocked
File "E:\winpytest\WPy64-3760\notebooks\hello.dist\sklearn_init.py", line 80, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in load_unlocked
File "E:\winpytest\WPy64-3760\notebooks\hello.dist\sklearn_distributor_init.py", line 18, in
File "E:\winpytest\WPy64-3760\notebooks\hello.dist\ctypes_init.py", line 364, in init
OSError: [WinError 126] The specified module could not be found
Based on another error someone reported and fixed by adding specific folder I tried this as well and got:
E:\winpytest\WPy64-3760\notebooks>"E:\winpytest\WPy64-3760\notebooks\hello.dist\hello.exe"
Traceback (most recent call last):
File "E:\winpytest\WPy64-3760\notebooks\hello.dist\hello.py", line 1, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in load_unlocked
File "E:\winpytest\WPy64-3760\notebooks\hello.dist\sklearn_init.py", line 80, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in load_unlocked
File "E:\winpytest\WPy64-3760\notebooks\hello.dist\sklearn_distributor_init.py", line 18, in
File "E:\winpytest\WPy64-3760\notebooks\hello.dist\ctypes_init.py", line 364, in init
self._handle = _dlopen(self._name, mode)
OSError: [WinError 126] The specified module could not be found"
_dlopen is just "from _ctypes import LoadLibrary as _dlopen" which _ctypes is indeed being shown in my dist folder so I am at a loss at this point.

Adding folders is murking the waters. I am not sure how well WinPython works with Nuitka.

I was getting this one with CPython:
File "C:\Users\kayha\repos\Py2C\MINILE~1.DIS\ctypes\__init__.py", line 373, in __init__
FileNotFoundError: Could not find module 'C:\Users\kayha\repos\Py2C\MINILE~1.DIS\sklearn\.libs\vcomp140.dll' (or one of its dependencies). Try using the full path with constructor syntax.

So far, we do not copy and DLLs specifically for sklearn, seems that is no longer correct.

Ah, my bad, I shortened the traceback too much, this is the code that uses ctypes there:
if os.name == 'nt':
    # Pre-load the DLL stored in sklearn/.libs by convention.
    dll_path = op.join(op.dirname(__file__), '.libs', 'vcomp140.dll')
    WinDLL(op.abspath(dll_path))

Adding that as a DLL dependency will be very possible.

It seems there was an extra-dlls folder previously, I think I recall seeing it once myself. That got renamed to to .libs apparently, as that one is empty.
While messing with this area of the plugin system, I wonder if it's not time to shift the copying of files out of the plugins, while then making them repeat what they did. Also it seems we went to the effort of lowering the DLL structure to top level, which may not work with this code anymore. This might be a bit breaking, but as it is now, the code is hard to read.

This has been fixed a long time ago I believe. The example is even one I regularily check.


Class picker for new assets

Just a helpful class selector when you have multiple asset classes like with DataAssets.
It's fully optional and disabled by default
I'm quite sure most of people who have created quest or dialogue systems have implemented some form of this

@Bargestt that's a great QoL improvement! Also backward-compatible 👍
Thanks for that, I'm quite used to adding custom AssetTypeActions and Factory classes for any custom class. But I bet it gonna be useful for many people :)


Add transcription using gladia

Hi,
Added audio loader using Gladia which uses whisper backend with optimizations. It usually takes less than a minute to get the transcription for an hour audio file.
Thank you.

heads up @ravi03071991 i ended up moving the gladia logic to a separate file, thought it was cleaner to separate the arguments since they are pretty distinct


Foxit Reader

Download and Munki recipes for Foxit PDF Reader. The download url seems to be static and redirects to the actual pkg download.
Used our common approaches to specify the minimum_os_version and a proper installs array.
Since the version of the downloaded package does not match the version of the installed app, I am overriding the version, as well.

Added an empty blocking_applications array to let munki remove the app. Additional cleanups in postuninstall_script (leftover daemon, custom preferences file).

Uninstallation works now.
Still open: If someone tells Foxit PDF Reader to assign the app to all pdf files and uninstalls the app, the following misleading error message appears (at least in an english environment): "The file can't be found". Could be circumvented by checking via duti in preuninstall_script. Should we take care of here or in override? Can be squashed and merged from my side if not applicable.


Runtime error with cellpose 2.2 GUI on Win 7 [BUG]

Hello,
I installed cellpose 2.2 with GUI in isolated conda environment (conda version 23.1.0) on Windows 7 Professional SP1. The cellpose GUI runs just fine, but only until cellpose or conda is restarted. Then the following runtime error shows up when I try to run again the command "python -m cellpose":

I think the problem happens only on Win 7; I do not have it on my laptop with Win 10. Reinstallation with the same python did not help (I still can use it only until cellpose/conda is restarted). Reinstallation with other python versions or with downgraded PyQt5 was not successful at all. I am aware Win 7 is outdated but the two most powerful PCs that I have easy access to at work still run on Win7, so any chance to solve this problem would be great for me. If this is too time consuming, I will try to use jupyter notebook version (I hope it will work) or look for an access to a powerful PC with Win 10.
thank you!

Can you list the steps to reproduce this behavior? It sounds like it works half of the time?

No, no, this is not what I meant. It works straight after installation, but not after software restart.
Exact steps:
1.) create conda environment called cellpose2 with python 3.8 (I use conda 23.1.0 with python 3.7.6 in base environment).
2.) conda activate cellpose2
3.) python -m pip install cellpose[gui]
4.) python -m cellpose to start the cellpose GUI. After that cellpose works fine, as long as I need, until I close the software
5.) close the software by clicking "X" on top right corner of GUI
6.) (optional) conda deactivate then conda activate cellpose
7.) python -m cellpose results in runtime error
In other words: under Win 7 on my desktop I need to freshly install cellpose GUI every time I need to work with it. It is doable, installation takes a few minutes, but it is troublesome to work like that.
One more strange thing: the platform says "win32" (see screenshot above). My PC is 64-bit.

I have exactly the same issue, while trying to install CellPose on an old machine (W7SP1). The Anaconda is 2020.07-Windows-x86_64, with only one environment. Cellpose starts after the first installation, but after Anaconda is closed it throws this error when trying to run cellpose. If I delete the environment and do a full installation again, it again works, but only once. Twice I was able to run it by just repeatedly trying to call cellpose despite the error, but it's not reliable.

@twegier can you make sure that you have the 64bit version of conda installed to match your OS?
Also, please share your conda environment with conda list after activating

conda info says platform is "win-64".
Below is the output of conda list in "cellpose2" environment:
Name                    Version                   Build  Channel
ca-certificates           2023.05.30           haa95532_0
cachetools                5.3.1                    pypi_0    pypi
cellpose                  2.2.2                    pypi_0    pypi
certifi                   2023.5.7                 pypi_0    pypi
charset-normalizer        3.2.0                    pypi_0    pypi
colorama                  0.4.6                    pypi_0    pypi
fastremap                 1.13.5                   pypi_0    pypi
filelock                  3.12.2                   pypi_0    pypi
google-api-core           2.11.1                   pypi_0    pypi
google-auth               2.22.0                   pypi_0    pypi
google-cloud-core         2.3.3                    pypi_0    pypi
google-cloud-storage      2.10.0                   pypi_0    pypi
google-crc32c             1.5.0                    pypi_0    pypi
google-resumable-media    2.5.0                    pypi_0    pypi
googleapis-common-protos  1.59.1                   pypi_0    pypi
idna                      3.4                      pypi_0    pypi
imagecodecs               2023.3.16                pypi_0    pypi
importlib-metadata        6.8.0                    pypi_0    pypi
jinja2                    3.1.2                    pypi_0    pypi
libffi                    3.4.4                hd77b12b_0
llvmlite                  0.40.1                   pypi_0    pypi
markupsafe                2.1.3                    pypi_0    pypi
mpmath                    1.3.0                    pypi_0    pypi
natsort                   8.4.0                    pypi_0    pypi
networkx                  3.1                      pypi_0    pypi
numba                     0.57.1                   pypi_0    pypi
numpy                     1.24.4                   pypi_0    pypi
opencv-python-headless    <IP_ADDRESS>                 pypi_0    pypi
openssl                   3.0.9                h2bbff1b_0
packaging                 23.1                     pypi_0    pypi
pip                       23.1.2           py38haa95532_0
protobuf                  4.23.4                   pypi_0    pypi
pyasn1                    0.5.0                    pypi_0    pypi
pyasn1-modules            0.3.0                    pypi_0    pypi
pygments                  2.15.1                   pypi_0    pypi
pyqt5                     5.15.9                   pypi_0    pypi
pyqt5-qt5                 5.15.2                   pypi_0    pypi
pyqt5-sip                 12.12.1                  pypi_0    pypi
pyqtgraph                 0.13.3                   pypi_0    pypi
python                    3.8.17               h1aa4202_0
qtpy                      2.3.1                    pypi_0    pypi
requests                  2.31.0                   pypi_0    pypi
roifile                   2023.5.12                pypi_0    pypi
rsa                       4.9                      pypi_0    pypi
scipy                     1.10.1                   pypi_0    pypi
setuptools                67.8.0           py38haa95532_0
six                       1.16.0                   pypi_0    pypi
sqlite                    3.41.2               h2bbff1b_0
superqt                   0.4.1                    pypi_0    pypi
sympy                     1.12                     pypi_0    pypi
tifffile                  2023.7.10                pypi_0    pypi
torch                     2.0.1                    pypi_0    pypi
tqdm                      4.65.0                   pypi_0    pypi
typing-extensions         4.7.1                    pypi_0    pypi
urllib3                   1.26.16                  pypi_0    pypi
vc                        14.2                 h21ff451_1
vs2015_runtime            14.27.29016          h5e58377_2
wheel                     0.38.4           py38haa95532_0
zipp                      3.16.2                   pypi_0    pypi

@twegier we're about to release an update to the pyqt versioning. We've only tested it with Windows 10, but you might be able to use it on Windows 7. You can install the code after activating your environment with:
pip install git+https://github.com/mrariden/cellpose@qtpy_refactor
or you can wait a few more days and try to upgrade when we pull the changes into the main branch.

Closing due to inactivity, reopen if necessary


feat: Add number of artworks to Search artwork grid

Description
This PR adds the number of artworks to the Search artwork grid.

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Add number of artworks to Search artwork grid - ole

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (Add number of artworks to Search artwork grid - ole - olerichter00)

  Generated by :no_entry_sign: dangerJS against 541e315fab8fc3ed26509189948209616a6d89c9


自编译报两个错误

Error:(81) Android NDK: Application targets deprecated ABI(s): armeabi
Error:(82) Android NDK: Support for these ABIs will be removed in a future NDK release.

你这也怪我咯...


Have better vertical axis in sparkline plots

Provide some sort of label and standardized scaling for the vertical axis on the spark line plots including axis ticks.

@SRGDamia1 - sparkline plots, by definition, do not typically have axes or coordinates. They are designed to give an indication of the general shape of the variation in some measurement, usually over time. I think we are asking the sparklines to do too much because we don't have visualization capabilities added to the system yet.

@SRGDamia1 - for the moment, we are not going to change anything to address this issue. When @Maurier implements the standard 72 hour window for sparklines and we have the TSA implemented, we can reassess. I will leave this issue open and assign it to the next milestone for now, but it may get closed at that point.

Deployed and ready for testing.

Closing this issue. Dynamic visualizations will be done by WebTSA.


Introduction: wave example

Draft of the wave example exercise. Requires #4 to land first.

And going in...


[SPARK-43156][SQL][3.4] Fix COUNT(*) is null bug in correlated scalar subquery

What changes were proposed in this pull request?
Cherry pick fix COUNT(*) is null bug in correlated scalar subquery
cherry pick from #40865 and #40946

Why are the changes needed?
Fix COUNT(*) is null bug in correlated scalar subquery in branch 3.4

Does this PR introduce any user-facing change?
No

How was this patch tested?
add new test.

cc @cloud-fan

I fixed the PR title.
- [SPARK-43156][SQL][3.3] Fix COUNT(*) is null bug in correlated scalar subquery
+ [SPARK-43156][SQL][3.4] Fix COUNT(*) is null bug in correlated scalar subquery

cc @sunchao and @parthchandra


DO NOT MERGE: Emergency revert for icon update.

This will update the icon utility to redirect icons back to the old xivapi static endpoint.
Please do not merge this unless required. cc @supamiu, drop a line here, on discord, or anywhere if server isn't coping and this needs to be rolled back.

seems stable. closing - can reapply if something goes boom.


SOLR-17453: Leverage waitForState() instead of busy waiting

https://issues.apache.org/jira/browse/SOLR-17453

Description
For some changes done to the cluster state via overseer, the code actively refreshes the seen cluster state until the change is fully done. This is a waste of resources, and this can be replaced by a ZK watch.
Solution
Replace busy waiting (mostly done with TimeOut class) by Zookeeper watches and ZkStateReader.waitForState().
Tests
No new tests added.
Some tests updated to also remove busy waiting.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[ ] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

A line of javadocs on TimeOut recommending waitForState would be good but perhaps arguably a distraction to a general utility -- :shrug: whatever.  I don't think we'll backslide much if all/most cluster state waiting is done using the correct API.

One thought, is there a way to enforce the use of waitForState() pattern via any of our code quality tools?

Not sure how we can automate decision on whether usages of Timeout are legit or not. We should use waitForState() instead of busy waiting for changes in Zookeeper, so we leverage the registered watchers. There are other cases, mostly when doing Solr-to-Solr requests, where we should keep Timeout.

Probably just a one-liner left and I'll merge away :-)


How to implement daemon in rails environment?

Hi. What is the best way to implement tweetstream's daemon in rails environment so it would be able to write all tweets directly to db? Right now all my tryings are giving me uninitialized constant Object::ModelName

I'm placing scrip in script/parse/twitter.rb and inside of it trying to do this: ```TweetStream::Daemon.new('tracker')client.track('#WordsINeedToHear') do |status|
APP_PATH = File.expand_path('../../../config/application',  FILE)
require File.expand_path('../../../config/boot',  FILE)
but it results with `LoadError: no such file to load -- /config/boot`. I'm so confused because file is there.

Ok, all I've needed was to place script in script/twitter.rb and run rails runner script/parser.rb start. That way rails manages all the dependencies on it's own.


Security Fix for Prototype Pollution - huntr.dev

https://huntr.dev/users/alromh87 has fixed the Prototype Pollution vulnerability 🔨. alromh87 has been awarded $25 for fixing the vulnerability through the huntr bug bounty program 💵. Think you could fix a vulnerability like this?
Get involved at https://huntr.dev/
Q | A
Version Affected | ALL
Bug Fix | YES
Original Pull Request | https://github.com/418sec/JSON8/pull/2
Vulnerability README | https://github.com/418sec/huntr/blob/master/bounties/npm/json8-patch/1/README.md
User Comments:
📊 Metadata *
json8-patch is vulnerable to Prototype Pollution.
This package allowing for modification of prototype behavior, which may result in Information Disclosure/DoS/RCE.
Bounty URL: https://www.huntr.dev/bounties/1-npm-json8-patch
⚙ Description *
Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects.
JavaScript allows all Object attributes to be altered, including their magical attributes such as proto, constructor and prototype.
An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values.
Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain.
💻 Technical Description *
Fixed by avoiding setting magical attributes.
🐛 Proof of Concept (PoC) *

Create the following PoC file:

// poc.js
var json8Patch = require("json8-patch")
var obj = {}
const patch = [{op: "add", path: "/__proto__/polluted", value: "Yes! Its Polluted"}];
console.log("Before : " + obj.polluted);
json8Patch.apply(obj, patch);
console.log("After : " + {}.polluted);

Execute the following commands in another terminal:

npm i json8-patch # Install affected module
node poc.js #  Run the PoC

Check the Output:

Before : undefined
After : Yes! Its Polluted

🔥 Proof of Fix (PoF) *
After fix execution will block prototype pollution and throw an exception according to herror handling in lib, see https://github.com/sonnyp/JSON8/blob/master/packages/patch/lib/walk.js#L23-L25

👍 User Acceptance Testing (UAT)
After fix functionality is unafected

@sonnyp - same as the other, let me know if you have any questions! 🍰

I'm confused.
Are you @luci-m-666 ?
If so why did you submit (twice) the same code changes as https://github.com/sonnyp/JSON8/pull/117 ? Why are those commits made by @alromh87
If not why claiming credit?

duplicate of duplicate of https://github.com/sonnyp/JSON8/pull/117

Maybe because @luci-m-666 loved much my work 😋


fix storing releases_log when running deploy on windows

[x] Bug fix #…?
[ ] New feature?
[ ] BC breaks?
[ ] Tests added?
[ ] Docs added?

the implementation for escapeshellarg differs between linux and windows. from documentation (https://www.php.net/manual/en/function.escapeshellarg.php):

escapeshellarg() adds single quotes around a string and quotes/escapes any existing single quotes allowing you to pass a string directly to a shell function and having it be treated as a single safe argument. This function should be used to escape individual arguments to shell functions coming from user input. The shell functions include exec(), system() and the backtick operator.

On Windows, escapeshellarg() instead replaces percent signs, exclamation marks (delayed variable substitution) and double quotes with spaces and adds double quotes around the string. Furthermore, each streak of consecutive backslashes () is escaped by one additional backslash.

i am releasing from windows machine and previous change merged in https://github.com/deployphp/deployer/pull/3328 made my releases_log file look like this:
{"created_at":"2022-11-26T18:58:41+0000","release_name":"1","user":"samuel","target":"develop"}
{"created_at":"2022-11-26T19:54:38+0000","release_name":"2","user":"samuel","target":"master "}
{"created_at":"2022-11-27T19:53:04+0000","release_name":"3","user":"samuel","target":"master "}
{"created_at":"2022-11-27T17:36:11+0000","release_name":"4","user":"samuel","target":"master "}
{"created_at":"2022-11-27T17:47:13+0000","release_name":"5","user":"samuel","target":"master "}
{"created_at":"2022-11-29T17:42:39+0000","release_name":"6","user":"samuel","target":"master "}
{"created_at":"2022-12-03T23:23:42+0000","release_name":"7","user":"samuel","target":"master "}
{"created_at":"2022-12-18T23:42:57+0000","release_name":"8","user":"samuel","target":"develop"}
{"created_at":"2022-12-18T23:47:02+0000","release_name":"9","user":"samuel","target":"develop"}
{ created_at : 2023-03-06T21:46:42+0000 , release_name : 10 , user : samuel , target : develop }
{ created_at : 2023-03-21T19:54:32+0000 , release_name : 11 , user : samuel , target : master }
{ created_at : 2023-04-03T21:26:39+0000 , release_name : 12 , user : samuel , target : develop }
{ created_at : 2023-04-06T19:28:11+0000 , release_name : 13 , user : samuel , target : develop }

notice the missing double quotes in releases 10-13. since that is not a valid json, the lines became "invisible" for deployer.
seemed like no big deal, releases (at least successful, i had no failing one) were deployed fine, but i notice my old release folders were not deleted during a cleanup. so i found this discussion: https://github.com/deployphp/deployer/discussions/3511
and after digging deeper i found a case. this is it. for the windows environment, it basically replaces the single quotes with an apostrophe () and surrounds the json with single quotes
fixes https://github.com/deployphp/deployer/issues/3507 fixes https://github.com/deployphp/deployer/discussions/3511
note about checking the OS: https://www.php.net/manual/en/reserved.constants.php#constant.php-os-family

oh, after playing around i desiced to suggest to use the same method for linux as well. because the solution with escapeshellarg (despite i agree it should be used for escaping shell commands) makes the json not valid in a case that contains a single quote
as an example, this escapeshellarg(json_encode(['name' => "Erik D'Ercole"])), produces this '{"name":"Erik D'\''Ercole"}' that clearly is not a valid JSON

Thanks for bringing this problem and for solution.
But I want do do something similar I did in the github.com/google/zx project.

@antonmedv but wouldn't it may be be better to updathe the release_log locally and then upload the edited file, so that you don't have to rely on escapeshellargs? Should be a more stable solution I think, rather than trying to dump file contents via echo on the command line.

Yes, this will be preferable

This can be closed, now that #3603 is merged.


⚠ ClamAV has degraded performance

In bd1e28c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 355 ms

Resolved: ClamAV performance has improved in 194a590 after 16 minutes.


add pod level retry relaunch with worker number unchanged

add relaunch logic for "pod level retry", in this case, the workers numbers will be the same, only the the new started workers's Ip will be changed, need to re-launch the script in this case.

Can one of the admins verify this patch?

@shadowtudark - apologies for not reviewing this before, but is this still a PR you think brings value?  If so, happy to review.

Closing as stale for now/target branch not master as well.  If this is needed, please re-open or re-create this PR.


Loading Robyn issue

Project Robyn
Describe issue
Packages Robyn, numpy, and nevergrad are all installed. When loading Robyn, library(Robyn), error message "R session Aborted." Tried many times, same issue.
Provide reproducible example
Environment & Robyn version

Robyn version:  3.10.3
R version: 4.3.2
Windows OS

sorry this is very hard for us to debug. can you try another laptop?

I was able to download and install later on. I don't know what I specifically did, though.