Windows build is broken

mvn package is currently broken on Windows. On Linux it works as expected. It looks like it's something related to the backslash.
Command
git clone https://github.com/Paullo612/mlfx.git
cd mlfx
mvn package

Ubuntu 20.04
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /opt/maven
Java version: 17.0.5, vendor: Azul Systems, Inc., runtime: /usr/lib/jvm/zulu-17-amd64
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "<IP_ADDRESS>-microsoft-standard-wsl2", arch: "amd64", family: "unix"

Windows 10
Apache Maven 3.8.7 (b89d5959fcde851dcb1c8946a785a163f14e1e29)
Maven home: C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7
Java version: 17, vendor: Oracle Corporation, runtime: C:\Program Files\Zulu\zulu-17
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Errors
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\attribute_instance_property\instanceProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\attribute_static_property\staticProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\bundle\bundle.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\coercible_id_property\idProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\collection\collection.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\default_instance_property\instanceProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\default_instance_property_fx_define\fxDefine.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\default_string_instance_property\instanceProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\empty_attribute_instance_property\instanceProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\empty_default_string_instance_property\instanceProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\empty_string_read_only_instance_property\instanceProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\enum_fx_constant\fxConstant.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\expression_handlers\handlers.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\external_fx_controller\fxController.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\fx_controller\fxController.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\fx_copy\fxCopy.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\fx_define\fxDefine.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\fx_factory\fxFactory.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\fx_include\car.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\fx_reference\fxReference.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\fx_root\fxRoot.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\fx_value\fxValue.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\generic_property\genericProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\handlers\handlers.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\id_property\idProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\initializable_fx_controller\fxController.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\initialize_fx_controller\fxController.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\inject\inject.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\instance_property\readOnlyInstanceProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\multiple_instance_properties\instanceProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\multiple_resources\properties.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\resources\resources.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\root_primitive_fx_constant\fxConstant.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\root_primitive_fx_factory\fxFactory.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\static_property\staticProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\string_instance_property\instanceProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\string_read_only_attribute_instance_property\instanceProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\string_read_only_instance_property\instanceProperty.fxml
[ERROR]   ComplianceSpec.FXMLLoader loads the same object tree as CompiledFXMLLoader for #pathAndTestName.testName:283->CompileSpec.compile:91 » Runtime java.lang.IllegalArgumentException: Illegal character in path at index 2: io\github\paullo612\mlfx\compiler\compliance\two_slots_primitive\twoSlotsPrimitive.fxml
[INFO]
[ERROR] Tests run: 477, Failures: 0, Errors: 39, Skipped: 0

Fixed. Thanks for the report! Messed up with line separators a little bit. I haven't tested fixes on real project, but as far as tests are now compile fine, there should be no problems anymore.


2 years old - some dependencies are not accounted for and some failures occur

security groups (vpc)
enis (subnet)


Style attribute function does not allow runtime strings

Is there any particular reason why the style attribute function only allows static strings? (see https://github.com/pointfreeco/swift-html/blob/f4ac5ec066c53d942fb79dc00bfbb523503131e1/Sources/Html/Attributes.swift#L1117)
I used the old Html module from swift-web before and it didn't use to have this limitation.

Hi there! We've renamed the version that takes any old string style(unsafe:), denoting that this string may be unsafe from user input. All elements that take CSS or JavaScript have StaticString and unsafe: String versions.


Transparency working weird

Describe the bug
Before the breaking changes, my transparency worked just fine with a setting "floats" to "transparent" in my tokyonight theme setup. After the changes, the transparency is not working anymore. I tried to set normal_bg to none or transparent(but unfortunately couldn't find transparent hex code that is working) and it seems like it works only with "Lspsaga peek_definition" when I set normal_bg to "". I'm attaching the video for an example.
https://user-images.githubusercontent.com/20822372/212482867-582c01fc-07f5-4631-aded-cbf29f9447dd.mov
Steps to reproduce
do Lspsaga peek_definition, Lspsaga hover_doc, Lspsaga lsp_finder
Expected behavior
every floating windows should be transparent.
Neovim version (nvim -v)
0.8.2
Operating system/version
macOS 13.1 Ventura
Terminal name/version
kitty 0.26.5
$TERM environment variable
xterm-256color

the thing is that I didn't change any of my colorscheme settings. It worked before, and now it is not. Am I missing something in my config?

In addition, it only works fine when I do Lspsaga peek_definition, anything else not being transparent including hover_doc, lsp_finder, show_line_diagnostics, show_buf_diagnostics, and diagnostic jumps

known bug of neovim

known bug of neovim . if you open same file in floatwindow. it will appear. peek support you can edit this file in this floatwindow. if only get some text and show in flaotwindow then this proble will disappear but it only can preview you can't
do nothing.

Ah then I'll close this and report this to the neovim repo. Thanks for your amazing work!


CDATA process is correct?

according to these belowarticles:
https://en.wikipedia.org/wiki/CDATA
https://stackoverflow.com/questions/35504890/how-to-add-a-newline-line-break-in-xml-file
https://stackoverflow.com/questions/15016004/whats-the-correct-way-to-encode-cr-lf-line-breaks-in-text-xml-values
we can not process any characters in CDATA section, but tinyxml2 will do NEEDS_NEWLINE_NORMALIZATION operation for it.

TinyXML-2 does newline normalization before CDATA. It also compromises on whitespace handling - it's not as super-pedantic as a fully correct processor would be. I don't think it makes sense to bloat the library to fix either problem.


WebApp - Bug related to the popup Recommended validators

Describe the bug

[x] Do not show error message after click Continue on popup recommended validators

To reproduce the behavior
Steps:

Switch to All accounts
Go to Start earning screen and input:

Choose account do not have enough balance to earn
Select validator < Max validatator

Click to Stake button
Click to Continue on popup Recommended validator

Actual: After click Continue the close popup but do not error message
Expect: Prioritize error message display

[x] Disable button Continue after click button
Actual: Popup does not turn off immediately, allowing repeated clicking of a button results in multiple confirmations
Expect: When user click button Continue, you need to turn off the popup immediately and do not allow click multiple time to button

Version test: https://dfda53a2.subwallet-webapp.pages.dev/
Validation passed in case:

Do not show error message after click Continue on popup recommended validators
Disable button Continue after click button
Re-check validate earning


option to run the changed files in a commit --onlyChanged

I am using jest with onlyChanged in CI for every commits. I want to test the list of files changed during the commit instead of list of uncommitted files. Is there any option to do this.
jest-changed-files/git.js
Instead of git ls-files. I need git rev-parse HEAD
My english may be poor, but i think you can get the point.

Your English is just perfect and I can understand your concern. Would you mind explaining why you want to use this flag on the CI? You should always run all tests on CI to make sure everything works together. --onlyChanged is meant to be for local development.
I recommend doing this:

Store the files from git rev-parse HEAD
Call jest with that list of files. Then Jest will only run those files. Like jest <file1> <file2> etc.

Let me know if that doesn't work for you and I can reopen this issue and help you prepare a PR.

The above idea will not work for me. The changed files will be source files and test files, while running the test files it will be ok. But when running source files like this jest <file1> <file2> i think it will not find the dependent test files.

Since you already found the code where we detect this, would you be willing to send a PR both for git and mercurial that looks for files the way you are asking for? :)

Will send a Pull Request soon 👍


[JBEAP-7740] Negative Address Size after paging

JIRA: https://issues.jboss.org/browse/JBEAP-7740
upstream jira: https://issues.apache.org/jira/browse/ARTEMIS-748
upstream pr: apache#903
(cherry picked from commit 66080ca115903d47b4d0a20da114eba34eb59938)

The JIRA does not have all Acks required for merge.


Design multi-threading support

We should come up with a way to support multi-threading where beneficial, to speed things up. See https://github.com/libbpf/blazesym/pull/93 for when we removed earlier support for that in DWARF parsing code, which wasn't accessible by users.

The more I think about it and look at the original approach, the less I like it and the more I think it is not suitable given our architecture. Our DWARF parsing as well as various other bits are lazy by design: we only parse data if it is being asked for. Ideally that wouldn't be the only mode of operation (https://github.com/libbpf/blazesym/issues/433), but it is how things work at this point and anything else is orthogonal: it just makes sense in many contexts this library is likely being used in: you generally don't want to parse a multi-GiB file eagerly if all you need is function information from a single compilation unit.
In my opinion the best way to multi-thread this kind of code is by (conceptually), replacing all OnceCell constructs with promises that resolve asynchronously. That resolution can but does not have to happen on a separate thread. Only once the result is needed would code actually wait for the completion. I think this mostly fits into the existing async Rust ecosystem, but there may be some differences. In the end we may not really want async (usage of the keyword) itself, because we are not interested in super fine grained work distribution: effectively nothing is blocking inside a "parse" sub-operation, so once you scheduled a promise there isn't really a need to cooperatively schedule sub-tasks. Rather, it can just run until completion. Not using async (the keyword) would mean we don't run into "function coloring" issues either. And we certainly don't have any intention of asyncyfying our API surface at this point.
Such an approach would be much more flexible to work with than hard coding thread usage in certain locations. Because we do not parse everything eagerly, it's hard to tell how best to distribute work to threads. But that is precisely what would be dictated by program structure ("run this function on this thread").
It would also mean that users could be given some control over threading properties: they could provide a spawn or schedule function that would know how many threads to use, when to spawn a new one or clean up existing ones, and even plug in an existing thread pool.

The main problem, I suspect, will be that the moment anything looking like a thread is involved there is a requirement for data to be 'static. For us, I believe, this may be a major issue, because we effectively use zero-copy parsing where possible and so the to-be-parsed data will be what is transferred between threads and that is unlikely to be 'static.

The main problem, I suspect, will be that the moment anything looking like a thread is involved there is a requirement for data to be 'static.

Well, that's not quite true of course. One can have scoped threads that alleviate this constraint, but at least as outlined above it would presumably be impossible to marry the two designs, I think.


1.4 release

I'm going to merge this so people don't have to wait for 1.4 images, but please comment here if you have any feedback.

Sorry I planned just to check this at the end of the day but you are right better to move quickly.
LGTM (late)
Btw, what is this new official-images repo about haven't seen it before.


provides AppVeyor's Boost directory via CMAKE_MODULE_PATH

https://github.com/johnmcfarlane/fixed_point/issues/268


Clusters List should be able to differentiate between regular imported clusters and CAPI clusters

Is your feature request related to a problem? Please describe.

When Rancher Turtles imports a CAPI cluster it is listed as a standard Imported cluster. This is technically correct as CAPI is handling all the provisioning and then when the cluster is provisioned Rancher Turtles automatically imports it into Rancher Manager. However, it will be useful for the users if we indicated that this is a CAPI cluster.
Describe the solution you'd like

UI should be able to:

Distinguish this is a CAPI provisioned cluster
What CAPI infrastructure provider(s) are used
(ideally) What flavor of k8s it is (i.e. plain, rke2, k3s)

Describe alternatives you've considered

UI team needs to investigate available options. One option would be to utilize labels or annotations.
Additional context

One possible approach would be to use an annotation to direct the dashboard to load information from a provisioner class, demonstrated in this poc: https://github.com/nwmac/dashboard/pull/21/files#diff-d888082c4e23d876ed1154a65f0abf824000d685eda426eee3512d88318f7d2bR19-R43
In this case the capi-ui-extension would likely need to generate these 'provisioner' classes for each provider that its currently hardcoding support for, as well as a generic option that would merely display eg whatever the value of the annotation is in the 'provider' table column.
We have a small assortment of extension points for these provisioner objects in the dashboard already (used in aks, eks, gke provisioning ports)  but we would need to expand on it to support this use case.


Need to add order books

Need to port over code for ask and bid order books.

Merged into develop.


networkmanager: 1.12.2 -> 1.12.6

Motivation for this change
Contains cups build fix (which is a separate PR),
so that this can be built and such.
More conservative than upgrade to 1.14.x as done in
https://github.com/NixOS/nixpkgs/pull/51122 .
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Depending on taste might want to pick this as a cleanup: 85cd0a08365fc5b0daaa661098d8c55ab48b779c

Closing in favor of #51122 ! :)


Disable ARM tests.

Disable ARM test. Also includes -

Disable building of SDK images build task.
Reset jobTimeoutInMinutes to 60.

@ravimeda,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Thanks!


Create Breaking News Section

Inside this section we have the breaking news component

#27 is an attempt at this
Need help aligning it to bottom of here


Add double click functionality

We've added this internally for our team and maybe it can be useful to everybody. Or maybe it hasn't been implemented due to something I've missed :)
Double click in change project's form cells will select that project.
Double click in cloud hosted environment cells will open the RDP for that environment.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: aariste sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for this. It is intuitive and useful.


Breadcrumbs don’t match permalinks

Description
I’ve renamed “docs” to “info” via the permalink settings, but the breadcrumbs still say docs.
Steps to reproduce
Change docs permalink to have any word other than docs at the beginning
Expected result
Breadcrumbs match url/permalink
Actual result
Still says docs.

I’ve renamed “docs” to “info” via the permalink settings, but the breadcrumbs still say docs.

Next to that:

rename ./content/en/docs/ to ./content/en/info/, and
copy ./layouts/docs/, and paste as ./layouts/info/

Ad 1) this will create the node info (as used by the breadcrumb)
Ad 2) this will make sure the content in info will be displayed like the content in docs
Linked discussion: https://github.com/h-enk/doks/discussions/882

copy ./layouts/docs/, and paste as ./layouts/info/

I am using a child theme so I don’t have that path in my code tree. I’m attempting to not do things that will get out of sync with your theme as it updates… is there any way to do this via configuration in one of the toml files or in the frontmatter?

You would then have to copy<EMAIL_ADDRESS>+<EMAIL_ADDRESS>and paste as ./layouts/info/list.html + /layouts/info/single.html respectively.
Or, add type: "docs" in the frontmatter of your content in the info directory — see also the Hugo docs: Front Matter Variables. Not tested though, it could be that you need to be more specific ( it works for type: "about" with an about.html template).

Closing as the actual issue at hand has been solved.


Added Buuny is lost game

Description
Added bunny is lost game
Fixes:  #2128

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Hey @DiwareNamrata23
Kindly check your scores Immediately. As per the new Instructions contributors should not get 150 points from here. Close all your Issues @DiwareNamrata23

the points are not 150 from here they are less than it @Sulagna-Dutta-Roy can plz merge this pr

This is pending since last week: Change the directory name as: Bunny Lost /your files @DiwareNamrata23

Kindly update @DiwareNamrata23

the total points are80

 the total points are80

KIndly check the directory name and change it

Sure maam

added changes to directory


Initial options tab after installation

Both Trailing '#' (href="#"):  & Empty Link (href=""):  have the same description, see below:
Warnings
Parse DOM after hashtag (#):
Hashtags can link to elements by id within the DOM. Enabling will add add the check to make sure an element exists by id to correspond to the hashtag. When enabled, if the page resolves but the corresponding element is not found, the element will be marked as a warning and shown in the console.log (F12->Console tab). Request Type: GET is required
Trailing '#' (href="#"):
When enabled, if the link url endswith '#' you will be warned.
Empty Link (href=""):
When enabled, if the link url endswith '#' you will be warned.

Fixed in #48


Class Name is lost when creating new one by duplicating existing script

Godot version
4.1.2
System information
Win 10
Issue description
After creating new script by duplicating script with already made custom class_name, that class_name is lost inside godot.
Steps to reproduce
Exists a script with any custom created resource class_name
for example we have this script
extends Resource
class_name NewResource

After creating this script we now can use NewResrource as resource, it's registered inside Godot.
Now if we want to create another class_name by duplicating existing one, new script will have same header with
extends Resource
class_name NewResource

and even if we rename class_name to something else in new script, class_name from original script is lost inside godot.
To register back old class_name we should go back into that script, make some changes to class_name name and save the script again.
Minimal reproduction project
"N/A"

This is kind of unavoidable, only one script can have a specific class_name, you will need to copy it manually instead

This is kind of unavoidable, only one script can have a specific class_name, you will need to copy it manually instead

Indeed, but since new script has class_name changed, class_name for old script should be working back again.
I'd suggest, if something ever happens when in new script there are class_name that has the name that is already in some other older scripts, that name in new script errored and ignored by godot leaving keeping old one working, not removing old one and accepting new instead.

That would be highly complex and hard to do, see #76380

Highly comples is what I just suggested? If whenever new class_name created and that name is already registered, do not unregister that one and error this one instead? It shouldn't require to reload every script to check their name, only that one which is already registered with that same name.

I've also run into this a number of times, and it's annoying since duplicating an existing class script feels like a natural way to start making a new similar class. And it's initially surprising that this breaks (at least temporarily) the old class, even if I think I now understand why it happens.
Based on the basic explanation of the system here: https://github.com/godotengine/godot/issues/76380#issuecomment-1574264774 perhaps a way to handle this would be to allow the system that tracks class_name-script mapping to store multiple scripts per class_name. When compiling this list will be checked, and for any class_names with multiple scripts assigned to it will check these scripts to see if the scripts are still actually referencing the class_name and if the referenced scripts even exist (for move cases). If not, the outdated mapping are removed. If there are still multiple scripts mapped to a single class_name, an error is thrown explaining that multiple scripts (and what scripts) are referencing this class_name and that that's not allowed.
I think this could solve the issue both when duplicating scripts as described above and when moving scripts like in https://github.com/godotengine/godot/issues/76380 and as a bonus we could also get a better error message explaining what we've done wrong and how to fix it when there are real duplicate class_name references.

But that would require you to track old classes with the same name, how would you know which one is valid?

IMO the solution is a warning when duplicating a script like this, including when copying it in the file system, allowing you to not import it and fix it

As I said I don't think that's a good idea because it makes for a lot of complexity where none is needed IMO

The behavior in 3 was to keep the mapping to the original script file, and only add a mapping for the duplicated script when class_name is updated. Seems like the old behavior was both simple and what the user would expect: if a mapping already exists to a valid script file, then don't update the mapping to the duplicate script file.
btw, when this happens to me, I solve it by manually editing .godot/global_script_class_cache.cfg after I've updated class_name in the duplicated file.

I just had this bug crash my whole project again. Duplicating an existing class and renaming it seems like a totally normal workflow and it's weird that Godot gives problems with this. IMO ignoring the issue or just throwing a warning to the issue are not appropiate solutions. The logical thing would be to the new duplicated class to throw an error, instead of the old one which was already registered.


[FIX] ref remains null

Hi, the problem I faced was that "ref" object always remained "null" and never got a value. Here is a fix.

Can you share the codesandbox you are currently encountering?


basic identity transformation

Codecov Report

Merging #6 (3487136) into main (c6f9174) will decrease coverage by 1.70%.
The diff coverage is 13.63%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   34.04%   32.33%   -1.71%
==========================================
  Files           1        1
  Lines         282      300      +18
  Branches      183      200      +17
==========================================
+ Hits           96       97       +1
  Misses          9        9
- Partials      177      194      +17

Impacted Files
Coverage Δ

include/mathia.h
32.33% <13.63%> (-1.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f9174...3487136. Read the comment docs.


Dates in calendar showing horizontally for certain sizes

Environment
Docker
Version
1.12.2 Dev branch
Describe the problem
The text for the dates is showing horizontally, guessing because there isn't enough space.
Resolution of browser is 1893 x 1379, on a 1080p screen.
Calendar widget is smallest size on 12 gridsize large,

Logs
2023-05-22T01:05:08.989112825Z Listening on port 7575 url: http://7723f0d303a6:7575
2023-05-22T04:58:09.001880483Z ℹ Requested frontend content of configuration 'default'
2023-05-22T04:58:11.228314763Z
2023-05-22T04:58:11.228394169Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T04:58:11.228405262Z
2023-05-22T04:58:11.230231455Z
2023-05-22T04:58:11.230264038Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T04:58:11.230273122Z
2023-05-22T04:58:11.675666397Z
2023-05-22T04:58:11.675733493Z  WARN  Unexpected response: Request failed with status code 401
2023-05-22T04:58:11.675742491Z
2023-05-22T04:58:11.972512989Z Retrieving media requests from 1 apps
2023-05-22T04:58:21.407934915Z ℹ Requested frontend content of configuration 'default'
2023-05-22T04:58:41.934250242Z ℹ Requested frontend content of configuration 'default'
2023-05-22T05:01:44.640459501Z Retrieving media requests from 1 apps
2023-05-22T05:03:52.472027008Z
2023-05-22T05:03:52.472061962Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T05:03:52.472071238Z
2023-05-22T05:03:52.520632822Z
2023-05-22T05:03:52.520687029Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T05:03:52.520695980Z
2023-05-22T05:03:52.584571511Z
2023-05-22T05:03:52.584604306Z  WARN  Unexpected response: Request failed with status code 401
2023-05-22T05:03:52.584613077Z
2023-05-22T05:03:58.711048071Z ℹ Saving updated configuration of 'default' config.
2023-05-22T05:04:01.119008391Z ℹ Requested frontend content of configuration 'default'
2023-05-22T05:06:01.089513357Z ℹ Requested frontend content of configuration 'default'
2023-05-22T05:08:42.681718961Z Retrieving media requests from 1 apps
2023-05-22T05:10:17.720225736Z
2023-05-22T05:10:17.720295976Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T05:10:17.720311662Z
2023-05-22T05:10:17.741134637Z
2023-05-22T05:10:17.741161406Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T05:10:17.741170513Z
2023-05-22T05:10:17.778879330Z
2023-05-22T05:10:17.778911787Z  WARN  Unexpected response: Request failed with status code 401
2023-05-22T05:10:17.778946726Z
2023-05-22T05:34:01.424689037Z Retrieving media requests from 1 apps
2023-05-22T05:34:01.433592948Z
2023-05-22T05:34:01.433619544Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T05:34:01.433630596Z
2023-05-22T05:34:01.488832071Z
2023-05-22T05:34:01.488885826Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T05:34:01.488900609Z
2023-05-22T05:34:01.927905850Z
2023-05-22T05:34:01.927950625Z  WARN  Unexpected response: Request failed with status code 401
2023-05-22T05:34:01.927960028Z
2023-05-22T05:34:09.474554975Z ℹ Requested frontend content of configuration 'default'
2023-05-22T05:34:10.436769336Z Retrieving media requests from 1 apps
2023-05-22T05:44:52.464754020Z Retrieving media requests from 1 apps
2023-05-22T05:44:52.519841437Z
2023-05-22T05:44:52.519893126Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T05:44:52.519902270Z
2023-05-22T05:44:52.558912938Z
2023-05-22T05:44:52.559990158Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T05:44:52.560004099Z
2023-05-22T05:44:52.611893909Z
2023-05-22T05:44:52.611943219Z  WARN  Unexpected response: Request failed with status code 401
2023-05-22T05:44:52.611952160Z
2023-05-22T06:27:46.954254048Z ℹ Requested frontend content of configuration 'default'
2023-05-22T06:27:48.495713734Z
2023-05-22T06:27:48.495761787Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T06:27:48.495770956Z
2023-05-22T06:27:48.553069646Z
2023-05-22T06:27:48.553125080Z  WARN  Unexpected response: Request failed with status code 403
2023-05-22T06:27:48.553137895Z
2023-05-22T06:27:48.719390233Z
2023-05-22T06:27:48.719428166Z  WARN  Unexpected response: Request failed with status code 401
2023-05-22T06:27:48.719437208Z
2023-05-22T06:27:48.732794573Z Retrieving media requests from 1 apps
2023-05-22T06:31:24.615101940Z ℹ Saving updated configuration of 'default' config.
2023-05-22T06:31:37.772530633Z ℹ Saving updated configuration of 'default' config.
2023-05-22T06:31:44.720190404Z ℹ Saving updated configuration of 'default' config.
Context
No response
Please tick the boxes

[X] I confirm that I attached the proper logs
[X] I've read the docs
[X] I've checked for duplicate issues
[X] I've tried to debug myself

Sorry but I cannot replicate. I'd suggest you increase the width of your calendar.

Sorry but I cannot replicate. I'd suggest you increase the width of your calendar.
Doesn't help

Sorry but I cannot replicate. I'd suggest you increase the width of your calendar.
Doesn't help

Then it might be due to the dots. I’ll do more investigation on this issue

@ajnart you could try disabling line wrap for the Text element

@ajnart you could try disabling line wrap for the Text element

Yeah. I only tested with my sonarr releases. I don't use other integrations so maybe it wraps because of it

Also, @ajnart don't forget that you can emulate different screen sizes in Chrome and Firefox. This might help recreating the overflow.

I have the same issue, using as well radarr and sonarr

I can not reproduce this issue:

Version
1.12.2 Dev branch

Hi, the calendar has had a general rework in v0.13.
Could you try the latest dev branch and tell us whether you still have the issue?

I just installed version 0.13 today through UNRAID. This occurs for me exclusively when the calendar is in a category. If I have it outside of a category it fixes it. If I remove the left and right padding of the dates in inspect element it fixes the issue.

There is a hotfix that didn't make the v0.13 that is already present in the dev and that might already cover this.
Would you be able to try using the dev instead?

There is a hotfix that didn't make the v0.13 that is already present in the dev and that might already cover this. Would you be able to try using the dev instead?

Switching to the dev branch solved the problem for me. I assume its solved unless OP can reproduce it in a different way

There is a hotfix that didn't make the v0.13 that is already present in the dev and that might already cover this. Would you be able to try using the dev instead?

Switching to the dev branch solved the problem for me. I assume its solved unless OP can reproduce it in a different way

Already on latest dev, got this in the pic on mobile. Not by my pc right now to test there tooScreenshot

Already on latest dev, got this in the pic on mobile. Not by my pc right now to test there tooScreenshot

I hadn't checked mobile as I don't access from phone. It is still present on my mobile as well but still only if it is in a category, by itself works. Cannot reproduce using inspect element and selecting mobile screen mode

Found the problem. Replicating was hard but I was able to and this fixes in. If anybody else wants to try it to confirm they are welcome to.


Add v1beta1 types

Changes
Fixes https://github.com/shipwright-io/build/issues/1103
This work is based on https://github.com/shipwright-io/community/pull/105 and https://hackmd.io/BsPjvGFwQgmVeJRe6FJfMA#Build-sources

Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[ ] Set a kind label on this PR
[ ] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
API additions: Introduce Shipwright Build v1beta1 API types

@SaschaSchwarze0 pls re-review, thanks a lot for the first review.

Ship is merged.
/unhold
/lgtm


[Android] Support Multi-Admin button to check ECM/BCM/Revoke features

Problem

Need to verify Multi-Admin feature on Android chip-tool
TE5 supports Multi-Admin feature including ECM/BCM/Revoke function

Change overview

Create new button to create multi-admin fragment and add ECM/BCM Revoke buttion

Testing

1st Admin execute IP Commissioning with controllee
Press Multi-Admin button and Enter ECM/BCM/Revoke
2nd execute IP Commissioning with controllee

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: sanghyukko:x: HunsupJungYou have signed the CLA already but the status is still pending? Let us recheck it.

@chulspro Please refer to this for the automatic assignment of reviewers for the PR as the next step. 🙏
@v-morales Please take a look at this PR for the next step. 😄

The restyle job is failing for given that some functions doesn't follow the guidelines. You can fix them applying my suggestions or using the restyle-diff script

Thank you for sharing and guide. I will run restyle-diff script and update again.

@msandstedt Please rerun the GH action, so that we can do the next step. 🙏

@austinh0 ?

@andy31415 @woody-apple We are waiting for the further action (GH action rerun) for going to the next step. Just FYI, we applied all the comments from reviewers into the latest commits in this PR. 🙏

@electrocucaracha Seems your comments are resolved.

@msandstedt @andy31415 @woody-apple We have resolved the recent issue in terms of CI Build. Please take a look our recent commits and let us know the next step. 🙏


Pass event type owner references to the data plane

With the contract now including fields to ET owner references (needed for autocreate), we should pass those values to the data plane.

Proposed Changes

Pass the owner reference info to the data plane.

/cc @pierDipi @matzew

/retest-required

/retest-required

/retest-required

Oh - just realized we probably want to backport the data plane contract fix before the upgrade tests will start to pass. I'll open a PR on Monday for that.

/retest-required

/test reconciler-tests-namespaced-broker

/cc @Leo6Leo @creydr


Bug Report: Settings Do Not Open

Environment
Windows build number: 10.0.18362.239
Windows Terminal version: Latest

Steps to reproduce
Open Windows Terminal and try to open the settings via the arrow button.
Expected behavior
A settings dialog opens.
Actual behavior
Nothing.

currently the settings are stored in and edited via a JSON file, so you'll need to associate a text editor with JSON files in your system settings. after that, clicking the settings button will open the settings JSON file for you to edit as you wish.

I have confirmed that my system has mapped *.json to vim, yet control-comma or choosing “Settings” from the tabbed menu fails to load the settings file. Or, as the OP says; “nothing” happens.

Alas, this is a silly bug. #1789
It's been fixed, and that fix is just waiting for another release.

The core of the issue is that gvim registers itself for the "edit" verb but we were using the "open" verb.
The fix for 1789 also added a fallback to Notepad just in case nothing was able to open it.


Add Form Validation

Need to add custom form validation.

This is tied to issue #40

This has been finished.


[write-fonts] iup: fixup vector distance calculation

We were checking the axes independently, instead of checking the overall length of the vector.

Nit: If you use hypot2 or equivalent you can save a sqrt. LGTM otherwise.

Nit: If you use hypot2 or equivalent you can save a sqrt. LGTM otherwise.

Should it also do the powi(2)  once outside the loop?


Fallback if youtube cannot be accessed

We have to support video playback both from behind a corporate proxy and from "normal" internet. For the corporate network scenario, many clients don't have YouTube access, so they would not be able to see videos from this (preferred) source. In Chrome console, this error occurs: GET https://www.youtube.com/iframe_api net::ERR_TUNNEL_CONNECTION_FAILED
Hence, we have to implement a fallback mechanism: when YouTube is not accessible, use an MP4 video file from AWS (static URL). We searched for a solution in plyr, but have not been successful so far. We've seen the error event, but this is not fired in our case. We also investigated the other events, but with no success so far.
Is there a viable solution in plyr or do we have to implement the availability check on our own?

This would be great to see this feature implemented, indeed.
@JauernigIT : I'm not sure I would strongly recommend this tool, but I believe http://afterglowplayer.com/ allows to have this "fall back if youtube isn't reachable".


Missing Copyright Notice and License to Uhaha

Hi,
The source code in the rafthub directory of this project is directly copied from https://github.com/tidwall/uhaha/blob/master/uhaha.go, which is 3K+ lines of original source code written and copyrighted by me.
The original copyright notice and LICENSE were omitted.
The Uhaha LICENSE states:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

Ok I will add it later

Hi,
The source code in the rafthub directory of this project is directly copied from https://github.com/tidwall/uhaha/blob/master/uhaha.go, which is 3K+ lines of original source code written and copyrighted by me.
The original copyright notice and LICENSE were omitted.
The Uhaha LICENSE states:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

IceFireDB stands on the shoulders of the giant uhaha. I will adjust and restore uhaha's copyright and agreement at the fastest speed. I apologize to you and hope to be inclusive.

Hi,
The source code in the rafthub directory of this project is directly copied from https://github.com/tidwall/uhaha/blob/master/uhaha.go, which is 3K+ lines of original source code written and copyrighted by me.
The original copyright notice and LICENSE were omitted.
The Uhaha LICENSE states:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

I finished the adjustment with the fastest speed. I have merged the master branch. Please forgive the negligence of the open source novice, and once again declare that IceFireDB stands on the shoulders of uhaha,
And thanks for the outstanding contribution of the uhaha project

Hi,
The source code in the rafthub directory of this project is directly copied from https://github.com/tidwall/uhaha/blob/master/uhaha.go, which is 3K+ lines of original source code written and copyrighted by me.
The original copyright notice and LICENSE were omitted.
The Uhaha LICENSE states:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

If you still need to adjust, please feel free to contact me


How to check reboot order

I wonder if somehow i can moderate forever-script loading order.
Some of my node scripts depends on mongodb, which has loading delay.
So, after system reboot i have some scripts started, but not working.
Is there an ability to moderate loading order?

@AlexFrost47rus although it can be done, my advise would be to make your application such a  way that it can wait for resources to come up and/or reconnect. Since even if service starts, some times it may not mean your specific db has started (For e.g. it could be recovering). Also what if your database service restarts..?

All the scripts are saved with K20 prefix at rcN.d
So, im not very strong linux user, but if there is a way to set this prefix manually to prevent lower order of installed script on reboot.
My scripts are reconnecting on error, so sometimes there are pretty fat error logs on reboot. I just want to exclude that scenario :)

Oh, yeah. Found it.
update-rc.d script-base-name defaults 99, so default value will be 99


Slug dot into slash

Grav translate it this way for the reference-able headers

@oleorhagen This (or a similar fix) is required for https://github.com/mendersoftware/mender-docs/pull/1812

@oleorhagen This (or a similar fix) is required for mendersoftware/mender-docs#1812

Understood, but it's been a while. Have you done this, or do I need to follow-up with something here?

@oleorhagen This (or a similar fix) is required for mendersoftware/mender-docs#1812

Understood, but it's been a while. Have you done this, or do I need to follow-up with something here?

You need to approve and merge this one :smile: Then I will take take care of re-submitting the mender-docs PR

@oleorhagen This (or a similar fix) is required for mendersoftware/mender-docs#1812

Understood, but it's been a while. Have you done this, or do I need to follow-up with something here?

You need to approve and merge this one smile Then I will take take care of re-submitting the mender-docs PR

Should this project be migrated to mendersoftware while we are at it? :thinking:

Should this project be migrated to mendersoftware while we are at it? thinking

We could. But we also need to move remark-validate-links and update then the package.json in mender-docs. I would say it is nice to do, not a requirement.


--no-error-notification Not Working

I try to disable getting errors for all the files with the --no-error-notification flag. But I receive all the errors in all the files and it seems --no-error-notification is not disabling this behavior.
Logs:
1486159845321:Noti:{"event"::"server.connected","params"::{"version"::"1.17.0","pid"::178954,"sessionId"::"1486159845024.8738"}}
1486159857819:Req:{"id"::"2","method"::"analysis.setAnalysisRoots","params"::{"included"::["/tmp/analysis_server_test247026551"],"excluded"::[]}}
1486159858004:Res:{"id"::"2"}
1486159858027:Noti:{"event"::"analysis.errors","params"::{"file"::"/tmp/analysis_server_test247026551/dart/tools/cida/testproject/a/lib/h.dart","errors"::[]}}
1486159858035:Noti:{"event"::"analysis.errors","params"::{"file"::"/tmp/analysis_server_test247026551/dart/tools/cida/testproject/a/lib/src/test.dart","errors"::[]}}
1486159858036:Noti:{"event"::"analysis.errors","params"::{"file"::"/tmp/analysis_server_test247026551/dart/tools/cida/testproject/a/lib/e.dart","errors"::[]}}
1486159858038:Noti:{"event"::"analysis.errors","params"::{"file"::"/tmp/analysis_server_test247026551/dart/tools/cida/testproject/b/lib/space.dart","errors"::[]}}
1486159858040:Noti:{"event"::"analysis.errors","params"::{"file"::"/tmp/analysis_server_test247026551/dart/tools/cida/testproject/b/lib/world.dart","errors"::[]}}
1486159858043:Noti:{"event"::"analysis.errors","params"::{"file"::"/tmp/analysis_server_test247026551/dart/tools/cida/testproject/lib/helloworld.dart","errors"::[]}}

Pietro is refering to the analysis server binary, documented here:
https://htmlpreview.github.io/?https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/doc/api.html

Yes, I believe that this is a bug in server. That said, it should be easy to work around it by ignoring the notification.

@srawlins @bwilkerson it looks like that cli arg is deprecated (https://htmlpreview.github.io/?https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/doc/api.html). I'll close this issue as working as expected - please let us know if this is blocking an important use case.


CI: Remove sourcery from CI and pre-commit

They're only offering a paid service now, and will be removing the free version in the future.

close via #55


Hope to update the version to support the latest system 10.12.6

Have you tried these steps?
Is there already an open topic for this issue?
Please include the following information.

OS Version:
Mac model:
Dongle or replaced card?:
Used dongle/card:

Your Issue:
Steps done to try to fix the issue:

The beta branch already supports 10.12.6 and High Sierra too.


Product search required features

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

[ ]


re-generate peripheral::* modules

:pushpin: Commit ed7f8c4 has been approved by japaric

@homunkulus r+

:hourglass: Testing commit ed7f8c4 with merge ed7f8c4...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing ed7f8c497773e6076c85d629b5ca1c92764bc2e4 to master...


ML: rename the filters button on mobile

[ ] Rename the filters button on mobile to: "Categories & Filters"
[ ] Reduce the size of the search input to allow for this
[ ] 12 px padding between the search input and the button
[ ] Rename the filters heading when you open the filters menu on mobile to: "Categories & Filters"

https://www.figma.com/file/GKhft5ZOwuH3ANrupGNCLHUU/Market-list-page?node-id=1331%3A3936

looks done. closing


In ts.performance.now, bind window.performance.now

Fixes #9954
Using an arrow function. Previously, it was set directly to window.performance.now, which fails when used in Chrome.

Incidentally, I ripped off Date.now in both Chrome and Node and it works fine that way.

:+1: It's always a little disappointing how inconsistent the web is with what you can rip off its hosting object and what you cannot.

And neither Date nor performance document it, in the documentation I found at least.

@sandersn That was why I thought it was okay to rip both off. :disappointed:

One of the Mac builds timed out. I think it's OK to merge anyway.

@sandersn This has been happening every few builds - I actually restarted a build last night that had been running for over an hour (I just assumed travis had hung). I don't know if it's a random pathological perf problem in TS that's only exposed on mac, or an issue with the travis infrastructure.

FYI: compared () => performance.now() with performance.now.bind(performance), the arrow function is faster on my Chrome, faster in FireFox — but slower on IE11.
Don't have an Edge to try.
Here's the code below to run in DevTools console:
var runAndAgain = function() {
  setTimeout(function() {
    runMillion();
    runAndAgain();
  }, 1);
};
runAndAgain();

function runMillion() {

  var now_arrow = function() { return performance.now(); };
  var now_bind = performance.now.bind(performance);

  var start = new Date(), tmp=0;
  for (var i = 0; i < 1000000; i++) { tmp = now_arrow(); }
  var arrow_time = new Date() - start;

  var start = new Date(), tmp=0;
  for (var i = 0; i < 1000000; i++) { tmp = now_bind(); }
  var bind_time = new Date() - start;

  console.log('arrow '+arrow_time+'\tbind '+bind_time+'\t ratio '+(((10000*arrow_time/bind_time)|0)/100)+'%');
}

Does anybody use IE11 to debug TypeScript? Faster in Chrome is better in my book.

AFAIK, most of the team doesn't use IE, so the faster in chrome/FF option does seem better.

I totally agree, Chrome is a better target -- and the difference is small enough anyway. Only wanted to give more context :+1:


Segfaulting issue when running distributed LightGBM on a large dataset

Hello LightGBM community, I'm running distributed training for LightGBM with a custom way of setting up the distributed environment (via MPI), but I'm running into a segfault that only happens when I use a large enough number of nodes, e.g. 300. I've pasted the script I used to reproduce the issue with dummy data, and I'm running on LightGBM version 3.3.5. In the script, I create a pre-partitioned dataset that is proportional in size to the number of nodes.
import time
import random
from sklearn.datasets import make_regression
import traceback
import os
import torch
import socket
import sys
import numpy as np

from lightgbm import LGBMRegressor
import logging
from typing import Optional

logger = logging.getLogger(__name__)

# Number of samples per node I have for my internal dataset
SINGLE_NODE_SAMPLES = 11714612
MODEL_PARAMS = {
    "force_col_wise": True,
    "verbosity": 2,
    "tree_learner": "data",
    "n_estimators": 100,
    "num_leaves": 2048,
    "max_depth": 11,
    "histogram_pool_size": 16384,
}
class ProgressCallback:
    def __init__(self) -> None:
        super().__init__()
        self.epoch_start_time = time.time()

    def __call__(self, env) -> None:
        logger.info(
            f"Epoch {env.iteration} finished in {time.time() - self.epoch_start_time:.3f} seconds."
        )
        self.epoch_start_time = time.time()

def seed_everything():
    random.seed(0)
    np.random.seed(0)

def find_free_network_port() -> int:
    s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
    s.bind(("", 0))
    port = s.getsockname()[1]
    s.close()
    return port

def get_host_ip(host_ip: Optional[str] = None) -> str:
    if host_ip == "dns":
        result = socket.getfqdn()
    elif host_ip is None or host_ip in ["auto", "ip"]:
        try:
            result = socket.gethostbyname(socket.getfqdn())
        except socket.gaierror:
            logger.warning("gethostbyname(socket.getfqdn()) failed... trying on hostname()")
            result = socket.gethostbyname(socket.gethostname())
        if result.startswith("127."):
            s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
            s.connect(("<IP_ADDRESS>", 1))
            result = s.getsockname()[0]

    assert result is not None
    return result

def setup_environment():
    torch.distributed.init_process_group(backend="mpi")
    local_rank, local_world_size, rank, world_size = (
        int(os.environ["OMPI_COMM_WORLD_LOCAL_RANK"]),
        int(os.environ["OMPI_COMM_WORLD_LOCAL_SIZE"]),
        int(os.environ["OMPI_COMM_WORLD_RANK"]),
        int(os.environ["OMPI_COMM_WORLD_SIZE"]),
    )

    host_ip_list = [None for _ in range(world_size)]
    torch.distributed.all_gather_object(host_ip_list, get_host_ip())
    port_list = [None for _ in range(world_size)]
    port = find_free_network_port()
    torch.distributed.all_gather_object(port_list, port)
    machines = ",".join([f"{host_ip}:{port}" for host_ip, port in zip(host_ip_list, port_list)])
    local_listen_port = port
    logger.addHandler(logging.StreamHandler(sys.stdout))
    for plogger in [logging.getLogger(name) for name in logging.root.manager.loggerDict]:  # type: ignore[attr-defined]
        plogger.setLevel(level=logging.INFO if rank == 0 else logging.ERROR)

    return local_rank, local_world_size, rank, world_size, machines, local_listen_port

def main(
    local_rank, local_world_size, rank, world_size, machines: str, local_listen_port: int
) -> None:
    logger.info(f"Constructing the dataset of {SINGLE_NODE_SAMPLES * world_size} examples...")
    # Create a dataset of size proportional to the number of nodes, i.e. `world_size`
    train_x, train_y = make_regression(
        n_samples=SINGLE_NODE_SAMPLES, n_features=960, random_state=local_rank
    )
    logger.info(f"Constructing progress callback...")
    progress_cb = ProgressCallback()
    cbs = [progress_cb]
    model = LGBMRegressor(
        pre_partition=True,
        machines=machines,
        local_listen_port=local_listen_port,
        num_machines=world_size,
        **MODEL_PARAMS,
    )
    logger.info(f"Starting fit for model on {len(train_x)} examples...")
    model.fit(
        train_x,
        train_y,
        sample_weight=np.ones_like(train_y),
        callbacks=cbs,
    )

if __name__ == "__main__":
    seed_everything()
    (
        local_rank,
        local_world_size,
        rank,
        world_size,
        machines,
        local_listen_port,
    ) = setup_environment()
    print("Environment has been set up.")
    exception = None
    try:
       main(local_rank, local_world_size, rank, world_size, machines, local_listen_port)
    except Exception as e:
       exception = e
       logger.error("".join(traceback.format_exception(type(exception), exception, exception.__traceback__)))
   finally:
       torch.distributed.destroy_process_group()
       if exception:
          raise exception

To run, I do:
MKL_CBWR=COMPATIBLE MKL_NUM_THREADS=8 mpirun --map-by ppr:1:node:pe=28 --bind-to core --report-bindings --mca orte_base_help_aggregate 0 --mca routed direct python3 train.py

The segfaulting error I see (on all nodes) is:
Caught signal 11 (Segmentation fault: address not mapped to object at address (nil))
==== backtrace (tid:  29334) ====
 0 0x00000000000534e9 ucs_debug_print_backtrace()  ???:0
 1 0x0000000000012ce0 __funlockfile()  :0
 2 0x0000000000262213 LightGBM::Network::AllgatherBruck()
 3 0x00000000002648ff LightGBM::Network::AllreduceByAllGather()  ???:0
 4 0x00000000001d186a LightGBM::DatasetLoader::ConstructFromSampleData()  ???:0
 5 0x00000000003b1211 LGBM_DatasetCreateFromMats()  ???:0
 6 0x00000000003b175c LGBM_DatasetCreateFromMat()  ???:0
 7 0x000000000000a6b4 ffi_call_unix64()  ???:0
 8 0x000000000000a0d1 ffi_call()  ???:0
 9 0x000000000000f8e5 PyCData_set()  ???:0
10 0x0000000000014049 _ctypes_callproc()  ???:0
11 0x000000000003aca3 __libc_start_main()  ???:0

Other notes:

The segfaulting issue occurs when I use a large number of nodes, e.g. 300, but not when I use a smaller number of nodes, e.g. 100, 50, 20, etc.
When the dataset is highly similar across the nodes, i.e. when I make the dummy dataset without specifying the random_state corresponding to the local rank, then the script does not segfault.

Let me know if there's any other info I can provide to help debug this. Thanks in advance!

Hi @jameslamb, I saw you had changed the tags - is there any other info I can provide here to help assess what might be the issue? I've tried a couple other things as well, including explicitly setting the number of threads to the number of cores I have on each node that I'm running on.

Thanks! I can't upload logs due to company policy, but I will try to summarize what's in the logs. I also found that the script works when I change the tree_learner to voting from data and when I add num_threads explicitly to be the core count on each node (I have 1 worker per node, and 300 total nodes).
Environment has been set up.  # (logged 300 times)
Constructing the dataset of<PHONE_NUMBER> examples...
[LightGBM] [Info] Connected to rank 0  # (logged 298 times)
[LightGBM] [Info] Connected to rank 1  # (logged 298 times)
...
[LightGBM] [Info] Connected to rank 299  # (logged 298 times)
[LightGBM] [Warning] num_threads is set=28, n_jobs=-1 will be ignored. Current value: num_threads=28  # (logged 299 times)
[LightGBM] [Warning] Histogram LRU queue was enabled (histogram_pool_size=16384.000000).  # (logged 299 times when this parameter is set)
Will disable this to reduce communication costs  # not sure if this is associated with the histogram pool size?

The reason that I'm using this custom setup is because I have a generalization for distributed environments that spans XGBoost, LightGBM, and Torch, and I have a different CLI I'm using for submitting training jobs that are potentially distributed, so I don't have a good way of using the CLI.
We built LightGBM using the default settings, so I think MPI is not supported (which would mean it's using socket (https://github.com/microsoft/LightGBM/blob/master/src/network/linkers_socket.cpp) for distributed, right?).

@dthiagarajan It seems there are some problems when constructing Dataset distributedly. Can you provide the number of columns (features) of the used dataset?

Yep, I'm using 960 features.

I also found that the script works when I change the tree_learner to voting from data and when I add num_threads explicitly to be the core count on each node (I have 1 worker per node, and 300 total nodes).

What happens if only add num_threads explicitly?

If I specify num_threads explicitly and use tree_learner = 'data', then I see same segfault error mentioned above.


Handle footnote backlinks that lack css classes and ids. Fixes #3083 for macOS

Handle footnote backlinks that lack css classes and ids. Fixes #3083 for iOS
A recent bug report described unusual behavior with footnote backlinks from the SixColors.com feed on iOS. Investigations showed there were two separate bugs, one already fixed on NNW 6.x for iOS, the other present on NNW for both macOS and iOS.
By utilizing CSS wildcard selectors that match internal links this patch generalizes the current selectors that make the backlink functionality work, fixing this bug. This is likely to also enable footnote backlinks to work in some future/unknown CMS systems that do not use the handpicked css class names NNW was previously targeting, as long as they use the overall .footnotes parent class.

Good patch, bad branch base. Will fix shortly. :)

Replacement macOS pull request based on correct branch to come shortly. Apologies for noise. Feel free to delete this PR. :)


invoking 'search.source': Error: Internal server error [500]...Help please!

I´m triying follow step by step the user guide package but I´m getting the same error. Is my first App, and I don´t have idea what happen but sadly, is not working...
Some suggestion?
Thanks in advance
Exception in delivering result of invoking 'search.source': Error: Internal server error [500]
at .extend.livedata_result (http://localhost:3000/packages/ddp-client.js?250b63e6c919c5383a0511ee4efbf42bb70a650f:4625:23)
at onMessage (http://localhost:3000/packages/ddp-client.js?250b63e6c919c5383a0511ee4efbf42bb70a650f:3365:12)
at http://localhost:3000/packages/ddp-client.js?250b63e6c919c5383a0511ee4efbf42bb70a650f:2734:11
at Array.forEach (native)
at Function..each..forEach (http://localhost:3000/packages/underscore.js?46eaedbdeb6e71c82af1b16f51c7da4127d6f285:149:11)
at self.socket.onmessage (http://localhost:3000/packages/ddp-client.js?250b63e6c919c5383a0511ee4efbf42bb70a650f:2733:11)
at REventTarget.dispatchEvent (http://localhost:3000/packages/ddp-client.js?250b63e6c919c5383a0511ee4efbf42bb70a650f:173:22)
at SockJS._dispatchMessage (http://localhost:3000/packages/ddp-client.js?250b63e6c919c5383a0511ee4efbf42bb70a650f:1158:10)
at SockJS._didMessage (http://localhost:3000/packages/ddp-client.js?250b63e6c919c5383a0511ee4efbf42bb70a650f:1216:18)
at WebSocket.that.ws.onmessage (http://localhost:3000/packages/ddp-client.js?250b63e6c919c5383a0511ee4efbf42bb70a650f:1363:17)

Solved! it´s mandatory add manually "check" and "ejson" package in your App... Aleluya! it´s working fine now!

Looks like package.js may be adding check and ejson only for the client.  Both are clearly used on the server also.

@urco Thank you so much!

@urco Thank you so much!

@urco Thanks for your sharing ! It helps me a lot .

No problem folks;)


county level scraper for MO

This is a county-level scraper for MO from the public health website that was already documented: https://health.mo.gov/living/healthcondiseases/communicable/novel-coronavirus/

In my haste of merging your excellent contribution, I forgot to ask that you add yourself as the maintainer if you'd like to be credited on the site and are willing to maintain it (like done here): https://github.com/lazd/coronadatascraper/blob/master/scrapers/BRA/index.js#L15-L24
Additionally, we've also added a source field where we put the name, url or anything else that's relevant so we can cite the source properly. I see that, for this PR, your URL is the same as your source (for others, the source may be, say, the Department of Health, but the URL is ArcGIS's server). In this case, I would add:
source:  {
  name: 'Missouri Department of Health and Senior Services'
}


@griffel/babel-preset produces invalid import for filter: url(#a)

Input:
import { makeStyles } from "@griffel/core";

export const useClasses = makeStyles({
  root: {
    filter: `url(#a)`
  }
})

Output:
import _asset from "./#a";
import { __styles } from "@griffel/core";
export const useClasses = __styles({
  "root": {
    "Bhu2qc9": "f1rurakv"
  }
}, {
  "d": [`.f1rurakv{-webkit-filter:url(src/#a);filter:url(${_asset});}`]
});

filter: url(#a) refers to a filter element with ID a in an SVG element, it's not an asset that needs to be imported, so it should output as is.
Also, even if #a is an asset, -webkit-filter:url(src/#a) should be -webkit-filter:url(${_asset}).
Complete repro: https://github.com/yume-chan/griffel-filter-url

@yume-chan thanks for the complete report 👍  I think that an additional condition there could fix it:
https://github.com/microsoft/griffel/blob/ebe44fdd9c34a87a4106c95c5b47f5719c215e8f/packages/babel-preset/src/assets/normalizeStyleRules.ts#L30-L32


Upgrade org.postgresql:postgresql 42.3.4 -> 42.3.5 - autoclosed

This PR contains the following updates:

Package
Type
Update
Change

org.postgresql:postgresql (source)
build
patch
42.3.4 -> 42.3.5

org.postgresql:postgresql (source)
compile
patch
42.3.4 -> 42.3.5

Release Notes

pgjdbc/pgjdbc
v42.3.5
Changed

test: polish TimestampUtilsTest
chore: use GitHub Action concurrency feature to terminate CI jobs on fast PR pushes

Added

Added KEYS file to allow for verifying artifacts PR 2499

Fixed

perf: enable tcpNoDelay by default PR 2495.
This is a regression from 42.2.x versions where tcpNoDelay defaulted to true
docs: fix readme.md after PR 2495 PR 2496
feat: targetServerType=preferPrimary connection parameter PR 2483
fix: revert removal of toOffsetDateTime(String timestamp)  fixes Issue #2497 PR 2501

[ ] If you want to rebase/retry this PR, click this checkbox.

Restored & reopened 👀.


Milkomeda chain support

This PR adds Milkomeda chain support. Milkomeda is a EVM compatible side-chain for the Cardano network. Milkomeda does not have a token of it's own, rather it's main asset is wrapped ADA, known as MilkADA.
The PR includes the addition of Milkomeda chain definitions for main and tests nets, as well as Ticker service for mainnet.

Awesome :) How integrated is this to the main Cardano?

It's just a sidechain with a bridge for asset transfer to/from the main Cardano chain:
https://cardano-bridge.milkomeda.com/bridge
They plan to bridge to Solana and Algorand too. I also saw something about turning it into an L2, but that's probably a long way away.


SCRUM-2338 Load and display allele_database_status attribute

PS... I have found some duplicate indexing on some of the tables on alpha. This would cause slower insert times, if you have a few maybe you could go through some of the slot annotation tables and create a migration to remove some of the extra (duplicate) indexes. But I would suggest that in a separate PR.

Sure, will take a look at them in another PR


v12 support [Beta Version Available]

Title says it all.

Seconded. It's the only reason I'm still using V11.

+1 , adding my voice to fix this fantastic must have add-on .

I'll be working on the v11 / v12 dual compatibility release this week.
Beside v12 support some small quality of life enhancements I'm going to investigate adding are:

Allow actor documents to be set as rewards. Item Piles and game system loot chests are often implemented as actors. This will allow game system specific distribution of currency / XP.
Enrich the text of custom rewards. A fair amount of game systems
Verify linking Monk's Enhanced Journal entries as quest givers / make sure images display.

Super awesome, and I am thrilled it is still being actively updated. As dead as the other one was (which makes sense as it isn't the projects home) I was afraid it was an abandoned project. I only recently found it and started using it.

Thank you so much. My quest log vanished and I panicked a bit as I realised a lot was in there. Luckily the once a week game doesn't mean it's super essential but would love to see it in v12 as it's a massive boon to my players to not only track all the things they have done in this game but have a clear choice of quests to pick up when they aren't sure what to do. Really easy system to use as well.

One of the most useful and phenomenal modules for any given system - would love to see it updated to V12 - thanks for all of it so far! I'll have to port to the raw journals for now, so you can bet I'll be cheering on the process. Good luck!

Or you can wait until Sunday or Monday when things are likely to be released.

One of the most useful and phenomenal modules for any given system - would love to see it updated to V12 - thanks for all of it so far! I'll have to port to the raw journals for now, so you can bet I'll be cheering on the process. Good luck!

Or you can wait until Sunday or Monday when things are likely to be released.

To be honest, I first saw the developer comment that it would be worked on 'this week' and it's been two, edging on three since. I want to show positivity and faith, not try to rush, and I am cheering them on.
I know how unexpected developments can slow these things down. If they didn't get it released in the time they thought, chances are it may not be this week, or the next, and that's totally fine. I just want them to know people are definitely looking forward to it, and will be grateful for the hard work done.
Edit: I also don't want to assume you are the sole developer, or anything, but if this is your own update on an actual ETA, then that's good. I tend to run my sessions on Monday evenings, so it'd be pretty neato.

From personal experience: don't update to a new version of Foundry the day of/before a session 😬
Anyhow, many thanks for your work, @typhonrt. Looking forward to the release :)

I didn't expect to start an overall chain.
But thank you so much for the extensive work put into it!

Until the issue is fixed officially, it can be fixed very easily. Just replace all references to CONST.DOCUMENT_PERMISSION_LEVELS by CONST.DOCUMENT_OWNERSHIP_LEVELS in dbSchema_1.js, Utils.js, Quest.js and QuestDB.js.

Until the issue is fixed officially, it can be fixed very easily. Just replace all references to CONST.DOCUMENT_PERMISSION_LEVELS by CONST.DOCUMENT_OWNERSHIP_LEVELS in dbSchema_1.js, Utils.js, Quest.js and QuestDB.js.

Folks are certainly free to make this general patch locally albeit not convenient for most.
This only fixes the immediate runtime issue on v12, but does not address a thorough maintenance review of FQL as a whole. To keep FQL in tip top shape I need to do a thorough review / testing cycle of all functionality for the v12 release. I did not have time to do that for the v11 release. There are other subtle issues that need to also be addressed. I already got started on this process, but an example is that when you create a new quest the default permissions / ownership for all players is not set properly and likely didn't work as intended during the whole v11 timeframe yet no one really reported a problem. In the code at this location permission needs to be ownership. This doesn't crash FQL, but it doesn't set the default ownership level of new quests created. This is not something that is caught without examining the functionality of FQL as a whole. I don't use FQL on a day to day basis or run any Foundry campaigns currently. The only time I take a look at FQL is during the update process when a new core version is released.
I can launch into a diatribe about the state of Foundry for 3rd party developers and needless to say I'll skip it, but things are not good all around. I'm a professional developer who spent a lot of my own money, much more than you'd expect anyone to sanely do so, developing FQL and my larger aspirations about doing sustainable pro-grade 3rd party package dev beyond FQL is not materializing and likely it won't.
Currently, I am engaged and have been for the last ~4 weeks in a massive modernization PR to a highly used math library gl-matrix. This library averages ~1.8MM weekly downloads, so is not small change. I utilize gl-matrix in my larger Svelte based framework for Foundry that many other devs use to create awesome engaging packages that you use. Due to the time sensitive and momentum requirements to get this PR accepted, which it will because I have put in the work, I have to see that through before I can work on FQL. It's at that last ~3% stage, but as things go with professional grade development that last final finishing aspect can take additional time.
Mind you that this same professional high quality eye for detail and finishing capability is what is going to be applied to the v12 FQL release, but it needs to wait in the queue and is next up.

And when I said "wait until Sunday or Monday when things are likely to be released" that was accurate at that time where I even got half a day in on starting (Friday). However, there were further unexpected developments Friday afternoon regarding the gl-matrix work and that simply takes priority until that is handled. It looks like that is wrapping up where there is a breaking point in the next couple of days and if all goes well FQL is out this weekend... Don't quote on that though, but likely.
There are no outstanding bugs with FQL and it's been bug free for ~2 years. Small things like the very minor document ownership thing with a new quest are only detectable for the most part if you know exactly how FQL should work. The average user would experience nothing breaking, but not know what the intended behavior is like. If it was broken during v11 no one reported it.
Another minor complication that is a bit of a PITA is that I don't own the Foundry package manager rights to update FQL. Super weird and odd, but I have to track down someone else to update it and it's a PITA, so I'd rather just do that once. Even if FQL is wrapped up for release that can take an extra day or two for the update to post.

I didn't notice any beaks in V11, personally, and I do remember actively changing it so people by default couldn't see new quests, and it working, so it may well have been working for most of V11 or an edge-case. That, or perhaps it really is just that subtle.

Quite possibly just a v12 thing, but something that is non-obvious I noticed relatively quickly. What I was pointing out is that the basic CONST reference fix gets things working, but doesn't take into account other subtle aspects that are non-breaking that v12 might have messed with. The CONST thing would have been caught in the v11 update, but since I did a quick pass then and it doesn't generate deprecation warnings it slipped through as v11 worked. For the most part as long as there isn't a huge document model change like in 0.8 and v10 things should continue to work fine.
Also good news for the P2FE folks as they just posted today that the v12 system release should take into account this recent issue #39, so hopefully that is verified / enabled.
When I mention doing a full end to end testing regimen when available on a new core release I test across the top 30 game systems. I also test every feature and it takes time given the client / server / multiple players aspect of FQL. FQL appears reactive, but it is a whole lot of plumbing under the hood to give that appearance. It's been a while for that, so this is part of the process this time around and takes ~6 hours just for detailed manual testing of FQL. This new release will also work on v11 / v12, so I have to test on both core releases.

im really happy my inline checks is being added or working. thanks!

im really happy my inline checks is being added or working. thanks!

It's not something specifically I've implemented. This is only for PF2E as they are overriding core Foundry functionality to make it work. Also, I'll be verifying this against the unreleased v12 version of PF2E, but at least can give feedback to the system maintainers if their solution works. Indeed for other game systems it's going to be hit or miss and it's not likely other system maintainers will patch Foundry core to enable this kind of thing. A good issue / request for Foundry v13 though is making this easier for system developers to implement said features in a reliable and standardized manner.
So hopefully it does work for PF2E and I can confirm it in FQL.

im really happy my inline checks is being added or working. thanks!

It's not something specifically I've implemented. This is only for PF2E as they are overriding core Foundry functionality to make it work. Also, I'll be verifying this against the unreleased v12 version of PF2E, but at least can give feedback to the system maintainers if their solution works. Indeed for other game systems it's going to be hit or miss and it's not likely other system maintainers will patch Foundry core to enable this kind of thing. A good issue / request for Foundry v13 though is making this easier for system developers to implement said features in a reliable and standardized manner.
So hopefully it does work for PF2E and I can confirm it in FQL.

when you say unreleased do you mean on a branch that is beta or something thats being worked upon? currently the v12 version of pf2e is out https://github.com/foundryvtt/pf2e/releases/tag/6.0.3

I'll add my gratitude to your hard work on this, @typhonrt.
Like all labour-of-love modules, I'll take anything I can get with heartfelt thanks : )

im really happy my inline checks is being added or working. thanks!

So hopefully it does work for PF2E and I can confirm it in FQL.

when you say unreleased do you mean on a branch that is beta or something thats being worked upon? currently the v12 version of pf2e is out https://github.com/foundryvtt/pf2e/releases/tag/6.0.3

This commit in PF2E from a day ago:
https://github.com/foundryvtt/pf2e/commit/7edaa67b3834aff685569bbb31ad2a2f625ad860
6.0.3 is 2 days old.

Just letting folks know that I've wrapped up my other work and I'll be starting on FQL in earnest tomorrow (Wed) until it is released. No chance for further delay. As I mentioned this time around it's a full in-depth analysis of the code base and testing cycle in addition to adding / verifying a few new features. I appreciate everyone's patience as it's not always going to be the case where the Foundry release cycle will match any given 3rd party developers schedule or commitments.
The v12 FQL release will continue the high quality / bug free experience and if things work out how I hope for the new features added things will be rather nice moving forward.

just wanted to ask if there was an eta on this as its the last mod i need before switching my kingmaker game over. no rush or anything just wanted to know a reasonable timeframe. :)

@ThingsCouldGetDicey et al
There is a public beta release available of the next FQL release (0.8.0-beta.1). It is v11 / v12 capable and is fully functional.
Check out this video for install and quick overview of new features:
https://www.youtube.com/watch?v=cX8EbdRLJe8
I'll be making an actual release video for the public release later.
To install the beta release:

Uninstall any existing FQL module.

Install the beta from this package link in the Foundry package manager:
https://github.com/typhonjs-fvtt-scratch/foundryvtt-forien-quest-log/releases/latest/download/module.json

For good measure when the official 0.8.0 release becomes available uninstall the beta release and reinstall FQL from the Foundry package manager.

There are no DB changes / migrations so this is a safe update. As always though please back up your data.
New features:

Actor documents can be set as rewards (Item Piles / PF2e loot actors)
All rewards can have associated image changed.
Player notes

If you are using dnd5e you can use the system text enrichment capabilities to create a custom reward using:
[[/award 1000xp]] to distribute XP.

The official release may happen next week. Do remember to uninstall the beta and re-install the official release as the beta repo / resources will be taken down after the official release is available.

@ThingsCouldGetDicey et al
There is a public beta release available of the next FQL release (0.8.0-beta.1). It is v11 / v12 capable and is fully functional.
Check out this video for install and quick overview of new features: https://www.youtube.com/watch?v=cX8EbdRLJe8
I'll be making an actual release video for the public release later.
To install the beta release:
* Uninstall any existing FQL module.

* Install the beta from this package link in the Foundry package manager:
  `https://github.com/typhonjs-fvtt-scratch/foundryvtt-forien-quest-log/releases/latest/download/module.json`

For good measure when the official 0.8.0 release becomes available uninstall the beta release and reinstall FQL from the Foundry package manager.
* Optional: Install latest `Item Piles / 3.0.5` if your system is supported.

There are no DB changes / migrations so this is a safe update. As always though please back up your data.
New features:
* Actor documents can be set as rewards (Item Piles / PF2e loot actors)

* All rewards can have associated image changed.

* Player notes

If you are using dnd5e you can use the system text enrichment capabilities to create a custom reward using: [[/award 1000xp]] to distribute XP.
The official release may happen next week. Do remember to uninstall the beta and re-install the official release as the beta repo / resources will be taken down after the official release is available.

if i uninstall it will it delete any of the quests outstanding or made?

if i uninstall it will it delete any of the quests outstanding or made?

No... Quests are stored as journal documents. Always back up your data though regardless especially when moving to a new Foundry core version.

Tried it out in my game tonight and it's working well. Didn't encounter any issues creating quests.

So, a small update on progress and what is going on...
If all goes well there should be an official release this week. It's taken longer because I've decided to return FQL to Forien, the original developer. He stepped away at the end of '20 from Foundry dev, but has been back for the last year or so. In this process I've taken extra time to thoroughly go through the codebase modernizing / streamlining it with today's knowledge / ES2022. A lot of the code for FQL was done in '21, so even a 3 year gap can lead to better coding standards.
I estimated the cost for me to do the next wave of significant maintenance in moving to the new "AppV2" UI API and all that entails to cost me at least $10k USD. I can no longer stomach such losses for the actual real work involved. This is not work that needs to be done immediately, but something in the next 1-2 years.
I'm passing back the torch to Forien with FQL in a strong position to continue forward. New features in this upcoming release bring several new possibilities for a complete questing solution particularly around XP / currency / item distribution.
The final timing snag will be the package transfer and final release process getting Forien back in control of the package listing. The Leagues source repo where FQL has been developed will be moving back upstream to Forien's original repo.
So it's happening, but extra parts of the process this time around. There is a beta release available above for now.

This fork is now merged upstream to Forien's original repo. An email for the package transfer back to Forien is pending. It's up to Forien to list / publish the next release. I don't know when that might occur, but hopefully soon.

Yesterday or so FQL has now been officially released on the Foundry package manager. Please note that anyone that installed the beta release described above should uninstall FQL and reinstall from the Foundry package manager to ensure that you continue to get updates.
All future development of FQL will be in Forien's hands again, so refer to the main repo for issues. When I started working on FQL it was in serious disrepair / MVP status with Foundry v0.8 tanking it entirely. With the 0.8.0 release I cleaned up / streamlined the codebase and returned it to Forien in a bug free state. While he will have to understand the codebase to move forward FQL is in a sound state for now.


syz-ci: create hermetic images/containers for build environment

Currently our syzbot setup for running syz-ci is quite ad-hoc: machines are setup completely manually and doing any updates, setting up new machines is very painful. The process is also not reproducible/repeatable. We need some kind of pre-created images/containers to make it all hermetic/reproducible/repeatable.
Use cases we need to support:

upgrading gcc/clang/bazel/go compilers easily
upgrading other static assets (linux image template, netbsd image, etc)
installing additional packages, both standard and custom (e.g. we need a newer version of pahole for bpf/btf, but it's not provided by our current distro)
upgrading host kernel (required for nested virtualization: qemu/gvisor)
creating new host machines more easily

To be able to control the host kernel we need to have a GCE-compatible disk image.
One design option would be to bundle everything into that image than somehow update the VM disk image when we need to do any updates. Another design option is to pack everything else (packages, compilers) into a docker image and only update the docker image most of time (easier) and only update the disk image when we need a new kernel.
I am leaning towards using docker image. Also having single GCE disk image and docker image for all machines, i.e. make it include superset of everything needed (bazel, all artifacts, etc).
Another question is when/how the docker image will be updated. It would be nice if one just needs to push a new docker image to the registry and syzbot will automatically pick it up in a reasonable time (e.g. tied to syz-ci updates, every 12h). Not sure where we need to insert docker pull in this case. Currently, syz-ci does not exit on updates, it just re-exec's newer version of itself, so it cannot update the image it runs in. Maybe we need to make it exit instead and rely on systemd to restart it, but before each restart systemd could pull new docker image. Need to double-check if this will work for OpenBSD/FreeBSD as they don't use systemd/linux (they are self-hosted).
Separately of this we probably need 2 disks for each host VM: one for the base image (transient, can be thrown away anytime), another for persistent data (syz-ci workdir with kernel checkouts, corpuses, etc).
Note: should also include ccache for #2091

@avagin @melver @blackgnezdo does this plan look good to you?
Greg, the persistent/transient disk image is what you use for OpenBSD, right? And as far as I understand quite successfully?

It seems Docker is the simplest solution. Is this supposed to work regardless of deployment, i.e. not specific to our current GCE instances?
If not, here is an alternative if we can make assumptions about where we run this:
I've had success in the past managing entire clusters of machines with Puppet. However, it does require a little more upfront work. But once it's set up, you just make a change to some central config, push it to all machines, and they all get updated automatically. For example, software that is available in the package repository just needs to be declared as installed in the Puppet config, and all machines will just install it once they receive the config.
Upgrading custom compilers etc. automatically could be done without docker as well. Since we have the same GCE image, we can just install whatever tools we need (like we have in /syzkaller now) on one master machine, which then rsyncs the tools to other machines automatically.

Correct. I keep a persistent filesystem mounted as /syzkaller and launch syz-ci from there. The root file system is transient. I periodically rebuild it by running create-openbsd-gce-ci.sh. I launch that from a private deployment script that also uses some gsuitl/gcloud/ssh.

Note: should also include ccache for #2091

We now have tools/docker/syzbot (gcr.io/syzkaller/syzbot) container. I think this can be considered fixed.


Removing getCertificate() from the Credential interface

Credential is a public interface and is declared as follows in the typings:
interface Credential {
    getAccessToken(): Promise<admin.GoogleOAuthAccessToken>;
}

But in the actual implementation (credential.ts), there's an additional method in the interface:
https://github.com/firebase/firebase-admin-node/blob/843df1229405d441fd5e8bd4170e38cd9fd4cbd4/src/auth/credential.ts#L291-L294
This can cause issues if the developer implements the public Credential interface, and passes it through AppOptions. Internal code that expects to find a getCertificate() method will fail.
This PR addresses this issue by separating the getCertificate() method from the Credential interface.
Resolves #573

Some other places:
https://github.com/firebase/firebase-admin-node/blob/2b4031334071476b5a6a481aa52578a713a5b719/src/storage/storage.ts#L73
https://github.com/firebase/firebase-admin-node/blob/9f770b4a96619e19297bb3e1d540fa710cd213af/src/utils/index.ts#L72


Attach local .m2 in the docker-compose container

Task Description
On some occasions you would want to do docker-compose up to do a quick build.
However, the current docker-compose.yaml file does not contain the local .m2 which might lead to exceptions like
strongbox-from-web-core_1 | [FATAL] Non-resolvable parent POM for org.carlspring.strongbox:strongbox-masterbuild:1.0-SNAPSHOT: Failure to find org.carlspring.strongbox:strongbox-parent:pom:1.0-issue-1877-upgd-dep-SNAPSHOT in http://repo.carlspring.org/content/groups/carlspring was cached in the local repository, resolution will not be reattempted until the update interval of carlspring has elapsed or updates are forced and 'parent.relativePath' points at no local POM @ line 8, column 13

An example fix is available here:
https://github.com/strongbox/strongbox-web-integration-tests/blob/master/sbt/docker-compose.yml
Help

Our chat
Points of contact:

@carlspring
@sbespalov
@steve-todorov

Can I take this up?


[BUG] ui: Error in the console when user tries to save recurring backup/snapshot in a detached volume

Describe the bug
[BUG] Error in the console when user tries to save recurring backup/snapshot in a detached volume
To Reproduce

Create a volume in Longhorn.
Volume will be in detached state.
Click on recurring Snapshot and backup
Enter backup/snapshot and click on Save.
There is an error in the console. And the changes are NOT saved

Uncaught (in promise) TypeError: Cannot read property 'replace' of undefined
    at main.57489847.async.js?9dec21b8a6e1c16d51e5:280
    at O (main.57489847.async.js?9dec21b8a6e1c16d51e5:280)
    at main.57489847.async.js?9dec21b8a6e1c16d51e5:286
    at s (main.57489847.async.js?9dec21b8a6e1c16d51e5:147)
    at Generator._invoke (main.57489847.async.js?9dec21b8a6e1c16d51e5:147)
    at Generator.forEach.e.<computed> [as next] (main.57489847.async.js?9dec21b8a6e1c16d51e5:147)
    at a (main.57489847.async.js?9dec21b8a6e1c16d51e5:7)
    at c (main.57489847.async.js?9dec21b8a6e1c16d51e5:7)
    at main.57489847.async.js?9dec21b8a6e1c16d51e5:7
    at new Promise (<anonymous>)

Expected behavior
User should be able to save the data
Environment:

Longhorn version: 1.0.0-rc1
Kubernetes version: 1.17.5
Node OS type and version: rke do linux 18.04

Verified with ui tag: wangsiye/longhorn-ui:afa7e56
Validation: PASSED

Create a volume in Longhorn.
Volume will be in detached state.
Click on recurring Snapshot and backup
Enter backup/snapshot and click on Save.
No error is seen in console.
Changes are saved.

Verified on master - 05/22/2020 - ui tag: 9ab6368
Validation: FAILED
Steps:

Create a volume in Longhorn.
Volume will be in detached state.
Click on recurring Snapshot and backup
Enter backup/snapshot and click on Save.
There is an error in the console. And the changes are NOT saved

@sowmyav27 @smallteeths This is weird... This is the same error message as before.

Verified on master - ui tag: ca99642 on longhorn - 1.0.0-rc1
Validation: PASSED
Steps:

Create a volume in Longhorn.
Volume will be in detached state.
Click on recurring Snapshot and backup
Enter backup/snapshot and click on Save.
There is no error on the console and the changes made are saved.

@sowmyav27 Thanks. I've moved the issue to merged column.