Feature/ Venue: rebuttal stage

Looks good! I'm confused with the flags, let me try to understand:
single_rebuttal: False, unlimited_rebuttal: False => One rebuttal per review
single_rebuttal: True, unlimited_rebuttal: False => One rebuttal per submission
single_rebuttal: False, unlimited_rebuttal: True => Multiple rebuttals per submissions
single_rebuttal: True, unlimited_rebuttal: True => ( not supported)

Looks good! I'm confused with the flags, let me try to understand:
single_rebuttal: False, unlimited_rebuttal: False => One rebuttal per review single_rebuttal: True, unlimited_rebuttal: False => One rebuttal per submission single_rebuttal: False, unlimited_rebuttal: True => Multiple rebuttals per submissions single_rebuttal: True, unlimited_rebuttal: True => ( not supported)

The plan was that unlimited_rebuttals would override single_rebuttal, so in any case where unlimited_rebuttals is True, we treat it as Multiple rebuttals per submission.
I do:
if not review_rebuttal_stage.single_rebuttal and not review_rebuttal_stage.unlimited_rebuttals:  => One rebuttal per review
and whenever unlimited_rebuttals=True => Multiple rebuttals per submissions
Let me know if this is confusing or if it doesn't look right!

I realize unlimited_rebuttals was not implemented for first API but the option will show in the request form so adding that now. It is easier because we already have separate invitations for paper vs review rebuttals.
Another point, we are not checking if the signatures belongs to a reviewer in the API2, should I add this too?
We check this in the conference class: conference.review_rebuttal_stage.unlimited_rebuttals:
@melisabok

I realize unlimited_rebuttals was not implemented for first API but the option will show in the request form so adding that now. It is easier because we already have separate invitations for paper vs review rebuttals.

Why don't we just create the rebuttal stage invitation for the venue of the API 2 only?

Another point, we are not checking if the signatures belongs to a reviewer in the API2, should I add this too?

Sounds good, let's check it but I believe the Review Invitation doesn't allow other signature than the reviewer.


Language Specification - #shared clarification

Hello,
In the language specification's section on Sections, #shared is described as follows:

The #shared intrinsic variable returns a record containing the names and values of all shared section members currently in scope.

From the testing I've done, #shared contains all shared section members as well as all members defined directly (i.e. outside of a section) in the global scope (e.g. the standard library).
Examples

Given a Power Query section document containing a single section named "Section1" having a single (shared) member named "Query1", the results returned by #shared will include Query1 as well as almost 800 other entries corresponding with the names defined by the standard library.
Expression.Evaluate("#shared", [Test = 123]) returns a record listing "Test" as its sole field even though no sections exist in the evaluated environment (e.g. `````Record.FieldCount(Expression.Evaluate("#sections", [Test = 123]))```` returns 0).

Suggestion
Could the above-quoted paragraph be revised to something like:

The #shared intrinsic variable returns a record containing the names and values of all shared section members currently in scope and of all members defined directly in the global scope.

Thank you,
Ben

This issue seems to be about this page:

URL: https://docs.microsoft.com/en-us/powerquery-m/m-spec-sections
Source: https://github.com/MicrosoftDocs/query-docs/blob/main/query-languages/m/m-spec-sections.md

@bgribaudo if you have time and are willing, feel free to propose the change in the public repo. Thanks much, Jason
#please-open

Resolved by the linked PR.


Roll engine 209250da1bb3..07f7932d70bd (1 commits)

https://github.com/flutter/engine/compare/209250da1bb3...07f7932d70bd
git log 209250da1bb31dd3cc56e9a96274e62c7d7d39ee..07f7932d70bd88a56a3e03cb3871f3b5672bee5f --no-merges --oneline
07f7932d7 Roll src/third_party/skia b9416caa367a..47c7e80e9552 (2 commits) (flutter/engine#9308)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5431196587130880

Commit queue failed; closing this roll.


Splitquery e2e

Integrated the new SplitQuery RPC into vitess.
This PR does not replace the old SplitQuery RPC, but rather adds the new SplitQuery RPC as a new method called SplitQueryV2.
However, I do not add a new gRPC method to the API but instead decide which method to call based on a new Boolean field, UseSplitQueryV2, added to SplitQueryRequest. I don't want to add a new gRPC method since that will be hard to get rid of later on.
@michael-berlin @alainjobart @dumbunny Please take a look.

This change is

LGTM lots of boilerplate code :( but will go away after the transition.

:-( Yes I know. But I hope it's not going to be too bad to remove it.

Review status: 0 of 39 files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


FunC v0.5.0 logic and dependencies updates

Since FunC v0.5.0 introduces new keywords and new syntax for get methods, contracts written in v0.5.0+ should be correctly parsed and highlighted in TON verifier.
Highlighing is implemented in https://github.com/ton-community/contract-verifier-sdk/pull/324, so we just need to update the dependency.
To parse sources, tree-sitter-func.wasm is copied (surprisingly) from VS Code plugin, implemented here.
The file getterParser.ts contains logic for AST traversing, also modified by this MR (supports both method_id from v0.4.x and get from v0.5.0).

When https://github.com/ton-community/contract-verifier-sdk/pull/324 and https://github.com/ton-community/vscode-func/pull/11 are merged, I'll take the latest wasm and regenerate dependencies for proper package.lock changes, and this MR will become non-draft

30e95361a083dfc327a80d29c45f3c22e0162c55

BiMkiais

30e9536

Solana a


get/set LEDs

Currently it is possible to set LED colour and PWMF through PSMoveController. There is no way to query a controller's LED and PWMF, though the last set values are stored in PSMoveController private member variables. Obviously we need to expose these through similar getter functions.

What should the RGB return type be? We can pass pointers in as function arguments or return a container. FWIW, we shouldn't pass in pointers because we don't do that for any other function. Here's what it might look like to return a std::tuple

const std::tuple<unsigned char, unsigned char, unsigned char> getLED() const
 {
    return std::make_tuple(LedR, LedG, LedB);
}
// Use with...
unsigned char r, g, b;
std::tie(r, g, b) = controller.getLED();

I'll update this issue with another question once I think through how the tracker is going to know which colours to get positions for. I'm about to add a comment to #12

I think this is satisfied now that we can set/get both the tracking color and and override color


The pkg whitesur-gtk-theme doesnt work with most apps

Describe the bug
The theme partially works but the minimize maximize etc icons dont work for most apps
Steps To Reproduce
Steps to reproduce the behavior:

Install the theme through nixpkgs
Run any app such as nautilus vesktop spotify etc...

Expected behavior
The app windows have the correct top bar icons instead of ignoring the theme
Screenshots

Notify maintainers
<!--
@romildo Notifying the maintainer
---

Note for maintainers: Please tag this issue in your PR.

---

Add a :+1: [reaction] to [issues you find important].

[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[issues you find important]: https://github.com/NixOS/nixpkgs/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc

https://github.com/sjhaleprogrammer/nixosv2/tree/master/modules/home-manager/macos-theme here my home-manager macos theme

@sjhaleprogrammer I added this to my config `{ pkgs, lib, ... }:
{
gtk = {
enable = true;
cursorTheme = {
  name = "WhiteSur";
  package = pkgs.whitesur-cursors;
  size = 32;
};

iconTheme = {
  name = "WhiteSur-dark";
  package = pkgs.whitesur-icon-theme;
};

theme = {
  name = "WhiteSur-Dark";
};

};
home.activation = {
installThemes = lib.hm.dag.entryAfter [ "writeBoundary" "installPackages" "git" ] ''
${pkgs.git}/bin/git clone https://github.com/vinceliuice/WhiteSur-gtk-theme.git
  theme_dir="$HOME/WhiteSur-gtk-theme"
  install_script="$theme_dir/install.sh"

  if [ -f "$install_script" ]; then
    echo "Attempting to install WhiteSur GTK Theme..."

    chmod +x "$install_script"
    export PATH=${pkgs.sassc}/bin:${pkgs.which}/bin:${pkgs.getent}/bin:${pkgs.util-linux}/bin:${pkgs.glib.dev}/bin:${pkgs.libxml2.bin}/bin:${pkgs.sudo}/bin:$PATH
    cd "$theme_dir"
    ${pkgs.bash}/bin/bash -c "./install.sh -l"
    rm -rf "$theme_dir"
  else
    echo "Theme installation script not found at $install_script"
  fi
'';

};
}
`
but i get this error error: error parsing derivation '/nix/store/76r1s6q1dyb3ha6csar2841x0lhh9szz-dbus-1.drv': error: expected string 'D' no matter what im on gnome btw

'/nix/store/76r1s6q1dyb3ha6csar2841x0lhh9szz-dbus-1.drv': error: expected string 'D' no matter what im on gnome btw

Sounds like a corrupted nix-store. Try repairing nix-store, then garbage collect then repair again.

@sjhaleprogrammer  It was a random pkg but now i get this `× home-manager-pantelis.service - Home Manager environment for pantelis
Loaded: loaded (/etc/systemd/system/home-manager-pantelis.service; enabled; preset: ignored)
Active: failed (Result: exit-code) since Mon 2024-12-23 13:33:13 EET; 285ms ago
Invocation: c1053a3a15f640eca54723140d64e1b8
Process: 34512 ExecStart=/nix/store/m91h9kmjw78swvldfb9px8qnv1nb23ax-hm-setup-env /nix/store/c9hibkz414bviff91jiyanji0r1jmlr7-home-manager-generation (code=exited, status=1/FAILURE)
Main PID: 34512 (code=exited, status=1/FAILURE)
IP: 0B in, 0B out
IO: 192K read, 0B written
Mem peak: 6.1M
CPU: 232ms
Δεκ 23 13:33:13 nixos hm-activate-pantelis[34538]: Please do one of the following:
Δεκ 23 13:33:13 nixos hm-activate-pantelis[34538]: - Move or remove the above files and try again.
Δεκ 23 13:33:13 nixos hm-activate-pantelis[34538]: - In standalone mode, use 'home-manager switch -b backup' to back up
Δεκ 23 13:33:13 nixos hm-activate-pantelis[34538]:   files automatically.
Δεκ 23 13:33:13 nixos hm-activate-pantelis[34538]: - When used as a NixOS or nix-darwin module, set
Δεκ 23 13:33:13 nixos hm-activate-pantelis[34538]:     'home-manager.backupFileExtension'
Δεκ 23 13:33:13 nixos hm-activate-pantelis[34538]:   to, for example, 'backup' and rebuild.
Δεκ 23 13:33:13 nixos systemd[1]: home-manager-pantelis.service: Main process exited, code=exited, status=1/FAILURE
Δεκ 23 13:33:13 nixos systemd[1]: home-manager-pantelis.service: Failed with result 'exit-code'.
Δεκ 23 13:33:13 nixos systemd[1]: Failed to start Home Manager environment for pantelis.
warning: error(s) occurred while switching to the new configuration
`

@sjhaleprogrammer  now the unite extension doesnt work

I haven't tested that extension with the theme


Have a warning

Hi @rossmartin. Navigation is working. First of all, thank you for your effort.
However, it gives a warning, is there a solution?
Mapbox warning Falling back to MGLIdeographsRasterizedLocally because  MGLIdeographicFontFamilies are specified. {"filePath": "-[MGLRendererConfiguration glyphsRasterizationOptionsWithLocalFontFamilyName:rasterizationMode:]", "level": "warning", "line": 111, "message": "Falling back to MGLIdeographsRasterizedLocally because  MGLIdeographicFontFamilies are specified."}
I also get such an error.
Mapbox error [event]:General [code]:-1 [message]:Unable to calculate appropriate zoom level for bounds. Vertical or horizontal padding is greater than map's height or width. {"filePath": "virtual bool mbgl::MGLCoreLoggingObserver::onRecord(mbgl::EventSeverity, mbgl::Event, int64_t, const std::string &)", "level": "error", "line": 30, "message": "[event]:General [code]:-1 [message]:Unable to calculate appropriate zoom level for bounds. Vertical or horizontal padding is greater than map's height or width."}
Finally, is it possible to set the language?

Those errors appear to be logged by the underlying SDK. I'm not sure what is going on but you could check out issues on the https://github.com/mapbox/mapbox-navigation-ios. There might be an existing one and if not you could open an issue asking about them.
I answered your question about language in #11


bug: Attempt to connect to relay via transportOpen has stalled. Retrying

Current Behavior
After upgrading to wallet connect v2, our website often shows Attempt to connect to relay via transportOpen has stalled. Retrying. If i refresh it, the error will be gone.

I wonder if this is related to relay url, which i didn't find how to add it in configuration of walletConnect module.
Expected Behavior
I expect this error not to be shown in console
Steps To Reproduce

Upgrade to wallet connect v2
Try to load the website or connect your wallet after loading the website
Go to the developer console of your browser.

What package is effected by this issue?
@web3-onboard/walletconnect
Is this a build or a runtime issue?
Runtime
Package Version
"@web3-onboard/vue": "^2.7.8"
Node Version
18.15.0
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Anything else?
No response
Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

Have you upgraded to the most recent version of @web3-onboard/walletconnect- 2.4.2?

Have you upgraded to the most recent version of @web3-onboard/walletconnect- 2.4.2?

Yes, i do.

And i also add dappUrl both in WalletConnectOptions and in appMetadata.explore that is supplied to the web3-onboard init.
To reproduce, i have to send multiple request to my own api. But i wonder why axios request will be stalled by wc socket stalled.

@frankye23 you may want to reach out to the walletconnect team as the transport relay is out of our scope

@frankye23 is this still an issue on your end?

@frankye23 is this still an issue on your end?

Sorry to respond late. It turns out i init the wc provider in a wrong way. So it's no longer a issue. Thanks for reply anyway!


Add a check for the project and publication url fields under submit tab

Current behavior
Currently, there is no check for the project and publication url fields when making submissions under the Submit tab
Expected behavior
There should be a check for the above mentioned fields if they are real.

I am working on this issue. Please assign it to me @Sanji515 . Thanks!

Hey @Abhi58 it is already been fixed here. Please feel free to take some other issue. Closing this.


Roadmap to 0.0.1 prerelease

I think we can have a pre release when we get the parsing working. Also perhaps implementing a basic CLI with a few commands that you can point to a .svelte file and it prints out the AST?

[x] #55

I agree

How close are we to getting a full svelte file parsed? Is there anything else we need to add

For a full svelte file a lot more stuff has to be added. More expressions need to be supported and classes dont work right now. Right now I think just the example works but I havent tried anything else.

I tried publishing the project to crates.io but realised that a rustle project already exists https://crates.io/crates/rustle.

You could name it like how swc names their projects

Ok, so for now, I'll publish the project as rustle_lib and rustle_cli. I would also like to try and ask @thomaslee if he would want to let us take over the rustle namespace on crates.io. I can't find his email anywhere, so I guess I'll try and ping him with this comment?


Consider making inner GraphQLRequest public or implement Display

Hello team,
We're using juniper_rocket_async and it all works great, but I can't find a way of accessing the inner graphql request object. I would like to log it, either as just a string or as json.
Specifically, it would be convenient if this inner type was public https://github.com/graphql-rust/juniper/blob/9c9639e8f0da0337880759c6fde469f863f74841/juniper_rocket_async/src/lib.rs#L64
However, that maybe is an API change you're not very interested in. Any ideas for a better solution? I would be happy to provide a PR.
Best,
Knut

I think either route is reasonable!

@knutin would be AsRef + AsMut enough for your purposes?


Fixed doc - Title 'spo listitem get'. Closes #2093

Fixed doc issue 'spo listitem get'. Fixed the Title. Closes #2093
Fixed the issue for the title which was there for the doc command 'spo listitem get'.

Linked Issue

Closes #2093

Coverage remained the same at 100.0% when pulling 05eea9cf56ed059f4be7172ff131ace1b51066c9 on arjunumenon:2093-docbug-spolistitemget into 5dac8ec9ca4e1e83373c824cfd649b52a384891f on pnp:main.

Coverage remained the same at 100.0% when pulling 05eea9cf56ed059f4be7172ff131ace1b51066c9 on arjunumenon:2093-docbug-spolistitemget into 5dac8ec9ca4e1e83373c824cfd649b52a384891f on pnp:main.

Merged manually. Thank you! 👏

Merged manually. Thank you! 👏


Pyprep drops eog channels from mne.info

Dear pyprep-team,
I've used pyprep for preprocessing my EEG data and now want to do additional preprocessing steps including ICA. For ICA I want to use the EOG channel as a reference channel to select ICA components. Unfortunately, during preprocessing the eog channels were dropped from the info structure and it does not seem to be possible to add the back. Is this an issue with the pyprep pipeline or is there a simple workaround?
Before pyprep:
`<Info | 8 non-empty values
bads: []
ch_names: Fp1, AF7, AF3, F1, F3, F5, F7, FT7, FC5, FC3, FC1, C1, C3, C5, ...
chs: 64 EEG, 4 EOG
custom_ref_applied: False
dig: 67 items (3 Cardinal, 64 EEG)
highpass: 0.0 Hz
lowpass: 104.0 Hz
meas_date: 2018-04-06 09:34:26 UTC
nchan: 68
projs: []
sfreq: 512.0 Hz

`

After pyprep:
`<Info | 8 non-empty values
bads: []
ch_names: Fp1, AF7, AF3, F1, F3, F5, F7, FT7, FC5, FC3, FC1, C1, C3, C5, ...
chs: 64 EEG
custom_ref_applied: False
dig: 67 items (3 Cardinal, 64 EEG)
highpass: 0.0 Hz
lowpass: 50.0 Hz
meas_date: 2018-04-06 09:34:26 UTC
nchan: 64
projs: []
sfreq: 100.0 Hz

`

Hi @SebastianSpeer can you post that part of the code where you call pyprep?
Markdown tip:
If you want to format code over multiple lines, you need to use three backticks at the start, and at the end:
like this:
```
#code goes here
```

To also add coloring to your code snippet, you can add the language to be used for coloring to the top line, e.g.
```Python
def my_python_func(a,b):
    return a**b
```

for code on a single line, you can use single backticks, like you did:  hello this is code

I think you should be able to copy the eog channels to another object (in example copying the raw object and then dropping all but eog); then add them back to the raw object thats preprocessed with raw.add_channels().
Now there may be problems with the times (ie the array length)? Im not sure, I think there should not be problems. But thats one thing to try, never done it though.
The dropping inside pyprep is indeed done in the constructor of the PrepPipeline class. Incidentally maybe inside prep we should do that to not lose the eog channels when we return the preprocessed object.

I think you should be able to copy the eog channels to another object (in example copying the raw object and then dropping all but eog); then add them back to the raw object thats preprocessed with raw.add_channels().
Now there may be problems with the times (ie the array length)? Im not sure, I think there should not be problems. But thats one thing to try, never done it though.
The dropping inside pyprep is indeed done in the constructor of the PrepPipeline class. Incidentally maybe inside prep we should do that to not lose the eog channels when we return the preprocessed object.

@yjmantilla  Thanks for your suggestion. I've tried this but indeed the dimensions do not seem to match:
eeg_index = mne.pick_types(raw.info, eeg=True, eog=False, meg=False)
ch_names = raw.info["ch_names"]
ch_names_eeg = list(np.asarray(ch_names)[eeg_index])
raw_without_eeg=raw.copy().drop_channels(ch_names_eeg)
prep.raw.add_channels([without_raw])

@SebastianSpeer did you make another comment here? Because in my email notifications it seems like you commented something else but here is nowhere to be found.

@yjmantilla I initially commented something, but then I figured it out myself. Your suggestion worked fine. Thanks!


[Bug]: Hunter binary cache doesn't account rustc --version

Bug Summary
Two or more packages build with rustc of different versions may get cached for the same hunter toolchain id which will break kagome linkage
Bug Description
Hunter (binary cache) does not account rustc --version while toolchain id or package hash gets calculated.
That may lead to having packages built with different compiler versions, as the result the appearance of rust-std symbols of different versions will break kagome from successful linking.
Possible workaround - combine all the rust packages into single.
Possible solution - expose rustc version to hunter package hash calculator + enforce same version condition.

cc FYI @Harrm @xDimon


Ogre leaks GPU locks and crashes if tangents are calculated for a mesh without normals.

Trying to call OgreMesh::buildTangentVectors() on a mesh that does not contain vertex normals will cause Ogre to throw an exception and leak its GPU buffer locks.
Afterwards the function will assert/crash on a null pointer trying to lock again buffers that are already locked.
Occurs on a mesh 'doesnotwork.mesh', archived and available on request.

Fixed in https://bitbucket.org/clb/ogre-safe-nocrashes/changeset/3423 .


[PE-D] edit success message

Edited Person did not refresh after edit

Labels: type.FeatureFlaw severity.Low
original: badfr0g/ped#2

Edited person is to show the person data before editing. It should be correct here.


TypeError: 'NoneType' object is not subscriptable

Describe the bug
During comments iteration i got a weird exception 'NoneType' object is not subscriptable. Is there maybe any instagram changes or am i doing something wrong? You can find the stacktrace below.
To Reproduce
I got this error while iterating posts comments a couple of times. The error is random and I can't say a precise way to reproduce it.
Error messages and tracebacks
...
File "/usr/local/lib/python3.9/site-packages/instaloader/nodeiterator.py",line 141, in __next_
    query_response = self._query(self._data['page_info'] ['end_cursor'])
File "/usr/local/lib/python3.9/site-packages/instaloader/nodeiterator.py",line 102, in query_
    data = self. _edge extractor (
File "/usr/local/lib/python3.9/site-packages/instaloader/structures.py", line 569, in <lambda>
    lambda d: d['data' ] ['shortcode_media'] ['edge_media_to_parent_comment'],
TypeError: 'NoneType' object is not subscriptable

Instaloader version
I am running the 4.9.6
Hope it helps.

Can you share the line of code (or function) that is generating this error?

Hi @Physsikal, thanks for your answer, below you can find the code that generate the error
I am trying to insert all the comments and their answers in the same list with this simple code
for comment in post.get_comments():
    comments.append(comment_to_dict(comment, post))
    for answer in comment.answers:
        comments.append(comment_to_dict(answer, post, parent_id = comment.id))

Thanks for your help

post.get_comments() works for me. Is there a specific post where this error happens?


Encoder/Decoder bytes metrics

The current metric implementation for Encoder/Decoder bytes produced metrics leaves to the caller instantiating the metrics that are used for gathering data.
Instead of this approach would be better to add the metric creation logic here and expose a otel MeterProvider configuration attribute to configure metric collection.

I'm closing this issue as the code it mention does not exists anymore.
It was referring to the metrics in codec/json https://github.com/elastic/apm-queue/blob/9b40f8e1716ec8fcb4a334d8b494c3f1d4ec201c/codec/json/json.go#L32-L33, which has been since refactored and removed.


Implement API to test mail

added API point api/users/notifications/testmail that sends "unknown" event on GET request
make sendMailSync public
moved try/catch to runable

I decided to throw exceptions in resource. It will help debug without looking in log file.

Renamed and used POST

Merged, thanks.

Have no idea where to put button in web interface. Do you have?

I was thinking we can put it in the user dialog.


write a bench that tests acquiring elements under contention

If we implement #3 it'd be fun to measure how we fare under contention first. Because a mutex that's not contested has virtually no overhead. But once multi-threaded things come into play it's a different story.
An example of a contention benchmark can be found here: https://github.com/async-rs/async-std/blob/master/benches/mutex.rs

This is fixed with #5


magic number question

features[NB_BANDS+2NB_DELTA_CEPS] -= 1.3;
features[NB_BANDS+2NB_DELTA_CEPS+1] -= 0.9;
features[NB_BANDS+3NB_DELTA_CEPS] = .01(pitch_index-300);
features[0] -= 12;
features[1] -= 4;
I donnot know why 1.3 0.9 12 and 4 is subtracted in feature excact funciton.
Could any one answer me?

These are simplified standardization measures.

thanks


chore: setup sonarcloud analysis

Setup CI-based SonarCloud analysis

Changes unknown
when pulling 65ba795d3dc40743dbf61774f1b558a6471e4c44 on chore/configure-sonarcloud
into ** on main**.


Close price is the ask price

Describe bug
In Yahoo's page, the SPXI11.SA ETF price is 250.70 (market closed now). However, yf.download shows 251.19 which is the ask price in the screenshot.

Simple code that reproduces your problem
>>> import yfinance as yf
>>> yf.__version__
'0.2.33'
>>> yf.download(["SPXI11.SA"], period="1d")
[*********************100%%**********************]  1 of 1 completed
             Open        High         Low       Close   Adj Close  Volume
Date
2023-12-28  249.5  251.460007  248.559998  251.190002  251.190002    1727

Debug log
>>> yf.download(["SPXI11.SA"], period="1d")
DEBUG    Entering download()
DEBUG     Disabling multithreading because DEBUG logging enabled
DEBUG     Entering history()
DEBUG      SPXI11.SA: Yahoo GET parameters: {'range': '1d', 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG      Entering get()
DEBUG       url=https://query2.finance.yahoo.com/v8/finance/chart/SPXI11.SA
DEBUG       params={'range': '1d', 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG       Entering _get_cookie_and_crumb()
DEBUG        cookie_mode = 'basic'
DEBUG        Entering _get_cookie_and_crumb_basic()
DEBUG         reusing cookie
DEBUG         reusing crumb
DEBUG        Exiting _get_cookie_and_crumb_basic()
DEBUG       Exiting _get_cookie_and_crumb()
DEBUG       response code=200
DEBUG      Exiting get()
DEBUG      SPXI11.SA: yfinance received OHLC data: 2023-12-28 13:00:00 -> 2023-12-28 13:00:00
DEBUG      SPXI11.SA: OHLC after cleaning: 2023-12-28 10:00:00-03:00 -> 2023-12-28 10:00:00-03:00
DEBUG      SPXI11.SA: OHLC after combining events: 2023-12-28 00:00:00-03:00 -> 2023-12-28 00:00:00-03:00
DEBUG      SPXI11.SA: yfinance returning OHLC: 2023-12-28 00:00:00-03:00 -> 2023-12-28 00:00:00-03:00
DEBUG     Exiting history()
DEBUG    Exiting download()
             Open        High         Low       Close   Adj Close  Volume
Date
2023-12-28  249.5  251.460007  248.559998  251.190002  251.190002    1727

Bad data proof
No response
yfinance version
0.2.33
Python version
3.12.1
Operating system
Ubuntu Linux 22.04.3 LTS

download fetches from historical tab. Summary tab difference caused by Yahoo.


Support referenced LU authoring when adding a trigger

Based on the context of https://github.com/microsoft/BotFramework-Composer/issues/6489 , the calendar bot is using the referenced LU content for trigger phrases, so we need to support how to add trigger for referenced LU content from UX .
Option A : Auto attached trigger phrases if trigger name match with the intent name defined in lu (current or imported) file.
Option B : Drop down list for user to choose to bind them together.
Similarly what should be showed in the LU editor & inline LU view should be aligned with the action.
eg. for choosing from drop down list, we may display the referenced file path ?
for auto attached trigger phrases we may extract the trigger phrase from corresponding lu file ?
@mewa1024 @sangwoohaan  @boydc2014 @zhixzhan

This is new to me – didn't know you can import lu files and reference them from activities. Instead of coming up short-term solution, I'd like to take some more time to investigate. Could this be an item for R14?

yes, I agree with @sangwoohaan. For R13, the new creation experience (with templates that import LU) is a preview experience.

@hibrenda, @sangwoohaan, I'm so sorry--I got R13 mixed up with R12 in my previous comment. I think we should consider this for R13 since many of the new templates will encounter this. Related issue filed by Lauren: #5358

As a temporary solution for R13, the solution would be as simple as this

Hi @hibrenda @sangwoohaan , before this new design, I figure out a solution to support display/edit referenced intent as well as it is in current file inside, no matter where actually the intent is, it behavior same. Do you think it's reasonable or we should take this new design?
This is the PR
https://github.com/microsoft/BotFramework-Composer/pull/6536

Hi @zhixzhan yes, I think we should go with your solution.

For the new trigger dialog, I think we should go with Option A for now. While Option B would make it easier to reuse trigger intents, I think it might confuse non-advanced users.

@srinaath okay to move this to R15 milestone?


Improper partition used when generating SNS Topic ARN

What happened?
In US Gov partitions, the provider generates the wrong ARN for the GetTopicAttributes call. This results in the pulumi_aws.sns.Topic() resource from failing to create when the lookup happens.
Example
When using a provider in the US Gov (or China I'm sure too) creation of the topic fails:
test_topic = aws.sns.Topic("test_tjf_1")
Output of pulumi about
pulumi about
CLI
Version      3.112.0
Go Version   go1.22.1
Go Compiler  gc

Plugins
NAME        VERSION
aws         6.32.0
datadog     4.28.0
kubernetes  4.11.0
postgresql  3.11.0
python      unknown
random      4.16.1

Host
OS       darwin
Version  13.6.6
Arch     arm64

This project is written in python: executable='/Users/tomfarvour/.local/share/virtualenvs/pulumi-FBQqJsZg/bin/python3' version='3.11.7'

Additional context
This patch, which I presume patches the upstream TF provider, assumes it can use aws as the partition.
https://github.com/pulumi/pulumi-aws/blob/ba6524913c1a4b5b254bcc20465ed59b83b92b34/patches/0052-non-idempotent-sns-topic-creation.patch#L23-L28
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

It could be the case that our patch introduced a new failure mode:
	if !tfresource.NotFound(err) {
+		return diag.FromErr(err)
+	}
+

If we're not always predicting ARN correctly, this could surface a failure from by-ARN locator that wasn't a failure in upstream provider.


Change Node3D Gizmo to call group in realtime.

Averts godot crash which occurs if a node is added and then removed from the edited scene within one frame.
I have not filed an issue because the project and reproduction steps are complex, but essentially there is a tool script which adds nodes to the screen, manually ticks some IK processing on those nodes, then subsequently deletes them and saves out a PackedScene, all at once. The crash then happens at the next frame when the editor becomes responsive again.
Visual Studio stacktrace screenshot before applying this fix:

Basically, call_group_flags invokes a Node3DEditor::_request_gizmo with the default flags (0) so that the gizmo is called from MessageQueue on the next frame, after the node in question was destroyed.
Because the node was added to the active scene, it qualified for is_node_being_edited.
CC @TokageItLab

Would be obsoleted by #51591

@lyuma Do you think this change relevant for 3.x as well? It's probably too risky to apply to 3.5 by now, but maybe it could be considered for 3.6 if the original issue can affect it too.

Closing because #51591 was merged (default flag is now realtime).
I have filed a 3.x backport here: #62339 but I do not have a MRP, so I can't verify that it fixes anything.


fix: test_checkpoint_fallback test

Fix the test after https://github.com/a16z/helios/pull/326

Thanks for following up. Already handles in #327


fix error when total_awarded_amount=none, improve write using csv

Fix error when total_awarded_amount=none
improve ouput with csv module to handle comma in values

Thank you very much :)


phpPackages.imagick: 3.4.3RC1 -> 3.4.3

Motivation for this change
This version of the PHP extension is out of RC status.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg  build php70Packages.imagick php71Packages.imagick php72Packages.imagick php56Packages.imagick

Success on x86_64-linux (full log)
Attempted: php70Packages.imagick, php71Packages.imagick, php72Packages.imagick, php56Packages.imagick
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/186f29a2d7kwj9c5x2l70kx2vhhjvgps-php-imagick-3.4.3
shrinking /nix/store/186f29a2d7kwj9c5x2l70kx2vhhjvgps-php-imagick-3.4.3/lib/php/extensions/imagick.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/186f29a2d7kwj9c5x2l70kx2vhhjvgps-php-imagick-3.4.3/lib
patching script interpreter paths in /nix/store/186f29a2d7kwj9c5x2l70kx2vhhjvgps-php-imagick-3.4.3
checking for references to /build in /nix/store/186f29a2d7kwj9c5x2l70kx2vhhjvgps-php-imagick-3.4.3...
/nix/store/186f29a2d7kwj9c5x2l70kx2vhhjvgps-php-imagick-3.4.3
/nix/store/jxy3qk3amx3ir87bgsqadg81z6cyhwxa-php-imagick-3.4.3
/nix/store/6s3z54p2w888s6vcinbf5v8hdi1mzw2m-php-imagick-3.4.3
/nix/store/90mwpkyh6ypbmc0pqkx0w7zv6ckj7s6v-php-imagick-3.4.3

Success on aarch64-linux (full log)
Attempted: php70Packages.imagick, php71Packages.imagick, php72Packages.imagick, php56Packages.imagick
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/2nna1xl1a11irxawkwgpwkw44j0dl9r6-php-imagick-3.4.3
shrinking /nix/store/2nna1xl1a11irxawkwgpwkw44j0dl9r6-php-imagick-3.4.3/lib/php/extensions/imagick.so
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2nna1xl1a11irxawkwgpwkw44j0dl9r6-php-imagick-3.4.3/lib
patching script interpreter paths in /nix/store/2nna1xl1a11irxawkwgpwkw44j0dl9r6-php-imagick-3.4.3
checking for references to /build in /nix/store/2nna1xl1a11irxawkwgpwkw44j0dl9r6-php-imagick-3.4.3...
/nix/store/lz20jfqva6bzbdc0bql7w4b9qm6s7p3z-php-imagick-3.4.3
/nix/store/a5v57q579345h6bs4df4hfh4b09zpkwl-php-imagick-3.4.3
/nix/store/2nna1xl1a11irxawkwgpwkw44j0dl9r6-php-imagick-3.4.3
/nix/store/wl0ywwhl37h5hrn42imch19g4dprp70z-php-imagick-3.4.3

Failure on x86_64-darwin (full log)
Attempted: php70Packages.imagick, php71Packages.imagick, php72Packages.imagick, php56Packages.imagick
Partial log (click to expand)
/nix/store/pgfhjpxxijnwi0qjryfiv42gzjrpfai6-php-7.2.7/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/pgfhjpxxijnwi0qjryfiv42gzjrpfai6-php-7.2.7/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/pgfhjpxxijnwi0qjryfiv42gzjrpfai6-php-7.2.7/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/pgfhjpxxijnwi0qjryfiv42gzjrpfai6-php-7.2.7/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/pgfhjpxxijnwi0qjryfiv42gzjrpfai6-php-7.2.7/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
moving /nix/store/pgfhjpxxijnwi0qjryfiv42gzjrpfai6-php-7.2.7/sbin/* to /nix/store/pgfhjpxxijnwi0qjryfiv42gzjrpfai6-php-7.2.7/bin
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/af0x9c3inyz2h8n3ich5kvv10cv7gdhp-php-7.2.7-dev
cannot build derivation '/nix/store/b274hij6r8b089v9010vxarmws19vb79-php-imagick-3.4.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/4wszjbyn59pxa8knpnhv9pc2papn0353-php-imagick-3.4.3.drv', '/nix/store/b274hij6r8b089v9010vxarmws19vb79-php-imagick-3.4.3.drv', '/nix/store/cjyck8imm5zcng35s7kgw74mgzvvg2l0-php-imagick-3.4.3.drv', '/nix/store/ncjp9z349y8fphp3qz2551q68dgpqcrg-php-imagick-3.4.3.drv' failed


Support SAML authentication

I've seen https://github.com/jaimejorge/rig that tries to do something similar to oauth2_proxy.. and these libs: https://github.com/RobotsAndPencils/go-saml https://github.com/mattbaird/gosaml that handle SAML.
It would be awesome to have oauth2_proxy be the most complete sidecar to secure your app.
Do you think it'd be feasible to tack in SAML flows ?
thanks for oauth2_proxy .. I love it.

I'm thinking of starting work on this. Any objections or directions I would take ?


have all steps expanded?

Hi there--love this component and getting some good use out of it. I'd love for there to be a way with the vertical stepper to show all the steps as expanded. This is useful in cases where you'd like the user to see all the steps at once, without hiding any of the content / form entries contained within a step.

Hey, thanks for your comment @rgarcia
In order to do that, you can send the expandVerticalSteps prop to true inside the Stepper component.
<Stepper expandVerticalSteps>
  ...
</Stepper>

amazing--don't know how I missed that. Thanks a lot!


Support basePath in getUrl() #58

vercel/next.js#16047 (comment)

No—they are not safe to use, anything you import from dist/... is considered private and may break or change at any time.

Are you sure you want to use this?

Good point, didn't know that !
Will use this instead:
const { basePath } = useRouter();

@pmi if you make changes to a pull request we would still need a new review 👀
So we don't just push a commit to master without another person looking at the code

Right, but I made changes you suggested, so I assumed you would be ok with them :)

I am okay with them :P Still the need approval 😁


runtime: SIGSEGV in allocNeedsZero on darwin

#!watchflakes
post <- goos == "darwin" && log ~ `runtime\.\(\*mheap\)\.allocNeedsZero` && log ~ `SIGSEGV`

(Pulled out from https://github.com/golang/go/issues/55167#issuecomment-1443976333.)

The stack trace implies loading a nil heapArena struct. I'm not sure how this could happen (for instance due to a race). I'll look into it.

I want to look into whether this is actually only happening on Darwin.

I see it once on freebsd in 2021:
2021-10-13T18:15:48-40f82f8/freebsd-386-12_2

@golang/runtime, is this another symptom of #60449 or do we think it has a separate root cause?

I believe it's another symptom. I recall investigating this and concluding that it's memory corruption. I double-checked just now and yeah, the failing line doesn't really make sense (that index is write-once, but if it was just allocated and the wrong index was being set up, then we'd be seeing these crashes in a lot more places).

I added this as a condition to https://github.com/golang/go/issues/60449, closing now as a duplicate.


Update hugo reference in go.mod to a release.

It seems that 99eafa8257df was rebased out of the Hugo repo, And 0.55.7 was never a release, so I went with 0.56.0 for a minimal change. With a tag and go mod tidy, that removes a ton of lines.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Refactor leader election to use watchers

After discussions with @iocanel and @steven-sheehy I've decided to refactor the leader election implementation to have a more thorough checking on pod readiness and also make use of watchers provided by KubernetesClient.
First, change is that pod no longer can become a leader which its status is not ready.
Another change is that there were multiple actions added that can trigger leader information reload and change as opposed to only scheduled update as it was before:

Periodic update scheduled by LeaderInitiator in case there was a missed event or other problem
Add, update or delete action on configmap received by LeaderRecordWatcher
Readiness status change received by any instance of PodReadinessWatcher. Normally there are one or two instances running at a time. Always an instance monitoring readiness of a host pod. And optionally an instance monitoring a leader pod, if host is not a leader.

I have tested this manually and also added unit tests for the smaller classes. I didn't want to waste too much time writing unit tests for the biggest class or integration tests before getting some feedback on the change.
@iocanel, @steven-sheehy, would you mind providing your feedback?

FYI this PR makes https://github.com/spring-cloud-incubator/spring-cloud-kubernetes/pull/204 irrelevant.

First, change is that pod no longer can become a leader which its status is not ready.

What about when there are no ready pods? It should still choose a random leader so it doesn't wait a minute or two for a pod to become ready.

I don't think it is correct to assign leadership to a random non-ready pod.
Firstly, because if the pod is not ready it means it is not yet functioning properly and is not ready to accept requests. If your pods are not booting up it must be an issue and just assigning a leader to a random one wouldn't solve the issue.
Secondly, it will increase a possibility that the leadership will be assigned and immediately revoked when another pod becomes ready faster.
And overall this behaviour would confusing and unpredictable.


Make updated release for Swift 4.2 update

With the proper updated description for Cocoapod and others

There is a 1.1.1 version on cocoapods, but the files are from Dec 2017.
But yeah, new release would be appreciated.

For anyone unaware, you can fetch the latest version of this pod by specifying the repo and a specific commit hash in your Podfile.
pod 'SimpleImageViewer', :git => 'git@github.com:aFrogleap/SimpleImageViewer.git', :commit => '863f96ac070b05c374ee1e198524be3b039a89fd'

Thanks @VFUC! For anyone getting a permission denied error, changing the URL fixes it:
pod 'SimpleImageViewer', :git => 'https://github.com/aFrogleap/SimpleImageViewer.git', :commit => '758a43a29e14252fafb40dd5ec464c86f48b0363'

(PS: am using 758a43a in the line above -that's the last verified commit)

Unfortunately I am getting ;
Please make sure you have the correct access rights
and the repository exists.


Add ineffassign tool

Description
Configure ineffassign tool on CI
Fixes #13
Type of change

[x] New feature (non-breaking change which adds functionality)

Testing steps
Run ./ineffassign.sh or wait for CI to complete.

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #27   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          34     34
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 477d9a9...f57a3c1. Read the comment docs.


[Qt] feature latest to build 5.13.1

Default-Features: latest will be removed after CI run

@cbezault @Rastaban. Just informational pinging due to updated and new PR replacing #8189

You should be able to trigger this behavior off of VCPKG_USE_HEAD_VERSION instead of making it a feature (I understand if you're doing the feature thing just to test it in our CI).

VCPKG_USE_HEAD_VERSION is set when passing vcpkg the --head option.

@Rastaban @cbezault:
If I do vcpkg install qt5 --head: Is VCPKG_USE_HEAD_VERSION really also set in the build of qt5-base? I don't think so since propagating --head into the dependent ports feels like a really wrong thing to do. (although i did not try it out. But If it does I would certainly assume thats a bug)

@Neumann-A I think your right, --head  would not be propagated.  In that case the feature route is really the only option.


FBX: Fix material colors

Fixes #90527
Using ufbx test case to validate importing: https://github.com/ufbx/ufbx/blob/picort-refactor/data/maya_material_chart_7700_ascii.fbx
This test case consists of a 4x3 grid of planes, all with different materials, which should resolve to the same color in a correct renderer.
Reference image: All squares should be the same color (not accounting for some minor quantization inaccuarcies)

Godot ufbx before: Emissive textures were not imported correctly and linear material colors were not converted to sRGB:

Godot ufbx with this PR: Base color factors are currently ignored in Godot if textures are connected, as some files may contain garbage factors:

Godot ufbx with factor support (see note below):

The following diff would fix the factor support, but it is unclear if it is worth it as it may break other files. One approach would be to add an import option for it but it's probably a too fringe case to support.
// Combined textures and factors are very unreliable in FBX
- material->set_albedo(Color(1, 1, 1));
+ Color albedo_factor = Color(1, 1, 1);
+ if (fbx_material->pbr.base_factor.has_value) {
+     albedo_factor *= (float)fbx_material->pbr.base_factor.value_real;
+ }
+ material->set_albedo(albedo_factor.linear_to_srgb());

Test project: ufbx_material_chart.zip

One further thing, the example project includes the following script:
func _ready() -> void:
    for child in self.get_children():
        # Disable speculars for all meshes
        var mesh = child as MeshInstance3D
        if mesh:
            var mat = mesh.get_active_material(0) as StandardMaterial3D
            mat.specular_mode = BaseMaterial3D.SPECULAR_DISABLED

        # The light is configured to have intensity of PI, which is then
        # compensated by the 1/PI normalization of the BRDF.
        # However, Godot seems to not do this?
        var light = child as Light3D
        if light:
            light.light_energy = 1.0

In the test case I had configured the light intensity to PI to compensate for the 1/PI factor in normalized Lambertian diffuse. The top row contains emissive colors with zero diffuse. If the light intensity is not hacked the diffuse planes are quite a bit brighter:

Both Arnold and ufbx's test path tracer result in the correct image with the PI-intensity light, so it seems that Godot is doing something different here. FBX2glTF also seems to import the light intensity as-is, so it's probably for the best not to touch it, even though it will result in brighter scenes than in other renderers.
Also, speaking of FBX2glTF, here is what the test scene looks like using that, after the following fixes:

Directional light was rotated by 90 degrees
Orthographic camera units were not scaled, resulting in a 100x too large camera

I couldn't get the emissive and diffuse materials to match up using FBX2glTF, either with PI-intensity and 1-intensity directional light. This does mean that ufbx will produce different results than FBX2glTF, so it might be worth it to look a bit deeper whether ufbx is doing the correct thing after all.

Follow-up observation comparing the FBX2glTF (left) and ufbx (right) result:

It looks like FBX2glTF does take the base color factor into account by default, so for compatibility it would probably make sense to do that in the ufbx importer as well. On the other hand, many authoring programs default the base color factor to 0.8, so users may get darker textures than they would expect, but that would already be an issue with FBX2glTF.

As long as everyone is in agreement of using the albedo factor with albedo textures, I'd say I'm fine with getting this merged as-is.

I don't know why this fails randomly, but it feels unrelated.
./tests/scene/test_navigation_region_3d.h:79: ERROR: CHECK_EQ( navigation_mesh->get_polygon_count(), 0 ) is NOT correct!
  values: CHECK_EQ( 2, 0 )

./tests/scene/test_navigation_region_3d.h:80: ERROR: CHECK_EQ( navigation_mesh->get_vertices().size(), 0 ) is NOT correct!
  values: CHECK_EQ( 4, 0 )

Thanks!


Add 'Send Settings' button

Add 'Send Settings' button, to make it possible to change the settings by specifying a JSON object in the 'Description' of the 'Send Settings' button. Those settings will then be transmitted to the AWTRIX3 API when the button is pushed.

Merge conflicts

Merge conflict is resolved :-)

i didnt merge this yet because i thought you still wanted to change this in several devices?
https://github.com/galadril/Domoticz-AWTRIX3-Plugin/issues/7

Thanks for the merge.
The additional settings are part of another PR (See: #8), that I already prepared in the meantime, however was depending on this PR.


Running multiple inference

Hi,
Is it possible to run inference using the nndet_predict / nndet_eval command on a new test set by specifying the new folder input and output paths instead of copying the new data into the imagesTs folder and risk overwriting the previous inference data in imagesTs as well test_result, test_analysis, test_predictions folders?
Thank you!

Hi @Pri0805,
No, nnDetection can only function with the folder structure mentioned in the README. You can only configure the path to the data folder with the det_data environment flag.
In your case, you can rename the current imagesTs folder to something else (like imagesTs2) and copy your new test images to imagesTs or if you want to avoid copying, then you can create a symlink that points to your new test set folder. Also, to retain the current test results, you have to move them to a safe place before your run prediction for the new test set.
Best,
Partha

Hi @partha-ghosh,
We followed the above steps and ran the predict command. However in the test_predicitons file we notice that the old test data has been predicted again along with the new test data. Prior to running the command we renamed the following folders:
imagesTs, labelsTs in raw_splitted dir
test_analysis, test_results, test_predictions in consolidated dir
Is there any other folder we are missing that is causing old test cases to be predicted as well?

Hi @Pri0805,
Yes, you also need to rename or remove the imagesTs and labelsTs folders in the preprocessed directory.
Best,
Partha

Got it! Thank you!


Gce user

Use 'appscale' user on GCE.

Build: https://ocd.appscale.com:8080/job/Create-Eucalyptus-Image/3212/

It doesn't seem to work correctly.


Release v0.22.0

Release v0.22.0
This is a tracking issue for the release v0.22.0.
I would love to include in this release the following PRs:

https://github.com/crossplane-contrib/provider-gcp/pull/461
https://github.com/crossplane-contrib/provider-gcp/pull/457
https://github.com/crossplane-contrib/provider-gcp/pull/440
https://github.com/crossplane-contrib/provider-gcp/pull/467

They are almost ready to merge, I expect to merge them until next week and then we are ready to cut the release.
Steps needed for the release

TBD

I never did a release in provider-gcp before, maybe @hasheddan or @turkenh can help me defining all steps necessary to consider the v0.22.0 release done? 🙂

@Feggah happy help out here :)

Thanks @hasheddan!
I didn't see any issue in the past that were tracking the release of this provider. Do you know the process in the top of your mind? If so, could you edit the issue description and fill the "Steps needed for the release" subsection?

@Feggah the general release process follows the same as Crossplane as defined in https://crossplane.io/docs/v1.9/contributing/release-process/. Happy to help run this on Monday -- what are the status of the PRs you linked / are they hard blockers?

@hasheddan Got it. They are not hard blockers, just something nice to have in the release. They are all reviewed and waiting for some requested changes.
The PR #440 is just waiting an approval and merge, I solved the requested issues and it is waiting for the second review. Can you have a look?
I believe we can proceed without the rest because I don't know how much time contributors will need to solve the requested changes.


Added copy geos.framework script to Build/Products to fix Playground

Seems that if the geos.framework is in the Build Products folder it works:
https://imgur.com/a/T9eKors
I have added a script which copies it over on build, so if you choose a Simulator and hit build the Playground should now work.
I don't know why it can't find the Framework in $SRCROOT/Carthage/Build/iOS considering that the project itself can find it while building and its in the Framework Search Paths setting.
I tried readding a new playground, renaming it and even nesting it in the project but nothing worked except the above.

Thank you!


Use built in HomeAssistant's built in editMode

Using editMode property provided by HomeAssistant cards, is way more resource efficient than querying HTML elements every 100ms
Also the setInterval was called on every hass update, and not cleaned up, it caused build up of running 100ms intervals forever for each entity update.

Thank you! I was not aware of that, this seems like a great PR!


Gallery improvements

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-3 of 3 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-21.5%) to 37.438%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/libraries/Faze.Core/Faze.Core/Extensions/ReversePipelineExtensions.cs
0
1
0.0%

src/libraries/Faze.Utilities/Faze.Utilities.Testing/Extensions/TestImageRegressionServiceExtensions.cs
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-21.5%

Covered Lines:
535

Relevant Lines:
1425

💛  - Coveralls


Wandb in jenkins pipeline

wandb, version 0.8.32
Python 3.7.3
Darwin
Description
Use weights and biases init statement during Jenkins pipeline.
What I Did
I tried adding Jenkins to the sudoers file but that didn't fix it.
https://www.edureka.co/community/8365/permission-denied-error-while-running-simple-job-in-jenkins
Paste the command(s) you ran and the output:
Executed through simple jenkins pipeline:
wandb.init(project="superdan_training")

I'm getting a permission error:

+ python -m training.training
wandb: ERROR Failed to create run directory: [Errno 13] Permission denied: '/.config'
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/wandb/__init__.py", line 1049, in init
    run = wandb_run.Run.from_environment_or_defaults()
  File "/usr/local/lib/python3.7/site-packages/wandb/wandb_run.py", line 232, in from_environment_or_defaults
    api = InternalApi(environ=environment)
  File "/usr/local/lib/python3.7/site-packages/wandb/apis/internal.py", line 70, in __init__
    self._settings = Settings(load_settings=load_settings)
  File "/usr/local/lib/python3.7/site-packages/wandb/settings.py", line 22, in __init__
    self._global_settings.read([Settings._global_path()])
  File "/usr/local/lib/python3.7/site-packages/wandb/settings.py", line 100, in _global_path
    util.mkdir_exists_ok(config_dir)
  File "/usr/local/lib/python3.7/site-packages/wandb/util.py", line 499, in mkdir_exists_ok
    os.makedirs(path)
  File "/usr/local/lib/python3.7/os.py", line 213, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/usr/local/lib/python3.7/os.py", line 223, in makedirs
    mkdir(name, mode)
PermissionError: [Errno 13] Permission denied: '/.config'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/Users/italosayan/.jenkins/workspace/super-dan-experiment/training/training.py", line 13, in <module>
    wandb.init(project="superdan_training")
  File "/usr/local/lib/python3.7/site-packages/wandb/__init__.py", line 1053, in init
    raise LaunchError("Could not write to filesystem.")
wandb.run_manager.LaunchError: Could not write to filesystem.

This is trying to write a file to the users home directory which in your case is "/" and you don't have permission to write there.  Either start your process with a user that has a home directory, or set the environment variable to WANDB_CONFIG_DIR=/tmp or some other directory you have write access to.

Worked like a charm. I added WANDB_CONFIG_DIR and WANDB_API_KEY to the environment variables inside Global properties in Jenkins.


seq_length dimension different to AlphaFold-multimer

In case of the original AlphaFold pipeline, the "seq_length" array in the feature_dict seems to get flattened in multimer mode (in monomer mode it stays a 1-D array). As far as I can see this does not happen in case of the OpenFold feature pipeline (where seq_length has the same dimension in monomer and multimer mode) and causes an incompatibility if one wants to use a features_dict from the original AlphaFold data pipeline. It might also be related to this issue: https://github.com/aqlaboratory/openfold/issues/111#issue-1252970018
Update:
In case anyone else is trying to use the feature pipeline or features.pkl from original AF:  There are some more differences in the feature_dict (int instead of float in case of "asym_id", "sym_id", "entity_id") which caused more errors downstream. I added now some code to my local installation to "convert" the dict from the original AF pipeline to make it compatible. Now the prediction worked.

Are you using the multimer branch? That's still experimental (we'll get to this eventually), and so small discrepancies like this are to be expected.

@gahdritz, really curious about the state of the multimer branch and whether there is a planned timeline for it to be finished.
Thank you for the great work!


[fix] Use the raw link to the script so that it works

If folks right-click and "copy link", it would be better if
they were able to directly download the script from that link.
Resolves #23.
Signed-off-by: Avi Miller<EMAIL_ADDRESS>

This is the URL I use: https://raw.githubusercontent.com/oracle/centos2ol/main/centos2ol.sh
curl "https://raw.githubusercontent.com/oracle/centos2ol/main/centos2ol.sh" --output "centos2ol.sh"
# OR
curl "https://raw.githubusercontent.com/oracle/centos2ol/main/centos2ol.sh" | bash

This is the URL I use: https://raw.githubusercontent.com/oracle/centos2ol/main/centos2ol.sh
curl "https://raw.githubusercontent.com/oracle/centos2ol/main/centos2ol.sh" --output "centos2ol.sh"
# OR
curl "https://raw.githubusercontent.com/oracle/centos2ol/main/centos2ol.sh" | bash

This is the URL I use: https://raw.githubusercontent.com/oracle/centos2ol/main/centos2ol.sh

Yep, that's the URL I'm changing the link to. 😄

This is the URL I use: https://raw.githubusercontent.com/oracle/centos2ol/main/centos2ol.sh

Yep, that's the URL I'm changing the link to. 😄

If you'd like to preview the rendered version, you can see it in the fix-link branch of my fork: https://github.com/Djelibeybi/centos2ol/blob/fix-link/README.md

If you'd like to preview the rendered version, you can see it in the fix-link branch of my fork: https://github.com/Djelibeybi/centos2ol/blob/fix-link/README.md


The "line" word was shown twice in method line link

The method_source_link macro already returns line X or line X and adding one more line word in front of it's result is redundant.

Thank you @aik099.


Add optional parameter color to keras_unet.utils.plot_imgs function

This PR may look weird but the segmentation part of my dataset mostly consisted of red color. Plotting the results with red overlay doesn't make it look comparable.
So, I have added optional param color with default value to give user a chance to choose the color for masks. Below attached image is my use case.
Default usage:

Custom color:

PS: change is not big, just few lines, but my linter reformatted the indentation.
What do you think?

Yes! @muminoff thanks for picking that up. mask_to_rgba function was there exactly for that reason but I must have forgotten to actually use it in plot_imgs function.
I need to add a simple assertion and some code comments and will merge this PR into master.
Thanks!


DMR kit is not affected

Online with bots doesn't work
Online without bots doesn't work
Offline with bots doesn't work
Offline without bots doesn't work
Achievement requirements:
All days loud, 4 players with unmodified  AK Rifle and Para SMG.

.


Something broke template loading

See error on https://master-branch-opensphere-ngageoint.surge.sh/
Our people seem to think it is related to yarn upgrade with something released in the last day or so.

This has been initially resolved by #932, however, further investigation needs to be made to see if a bug needs to be filed with jquery or if we should use something stricter for our html template linting.

@wallw-bits the template issues should be fixed by #1137. Can we close this?

@wallw-bits the template issues should be fixed by #1137. Can we close this?


Asana importer

Import from Asana (CSV export)
This importer pretty much mirrors the Jira importer but adapted for Asana.
Other changes

Labels/States/Users will now use existing ones instead of creating new ones every time
Assignees now get added if possible

Should we add to README.md? Other importers are described there.

@jorilallo  Here is an example of the Asana output:

Task ID
Created At
Completed At
Last Modified
Name
Assignee
Assignee Email
Start Date
Due Date
Tags
Notes
Projects
Parent Task
Priority

237764736
2019-07-16
2019-08-12
2019-08-12
Asana Task Title
Zach
<EMAIL_ADDRESS>

label
Asana Task Description

High

Here is the actual csv:
Task ID,Created At,Completed At,Last Modified,Name,Assignee,Assignee Email,Start Date,Due Date,Tags,Notes,Projects,Parent Task,Priority
237764736,2019-07-16,2019-08-12,2019-08-12,Asana Task Title,Zach,zach.loza@gmail.com,,,label,Asana Task Description,,,High

@Zach10za Thanks!!


Quote JSON path segments for query accessor.

1. Why is this change necessary?
Usage of hyphenated fields in JSON fields in a DAL query currently results in a MySQL error "Invalid JSON path expression". Such fields must be quoted to be used in a query.
2. What does this change do, exactly?
It quotes all segments (separated by .) when building the field accessor for the MySQL query.
3. Describe each step to reproduce the issue or behaviour.

Create a custom field "my-hyphenated-field"
Use the custom field in a query:

$criteria->addFilter(new EqualsFilter('customFields.my-hyphenated-field', 'some value'));

See error during execution

4. Please link to the relevant issues (if any).
There's no issue yet, as far as I can tell.
5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

I am not sure if all relevant use cases of this accessor builder are present in my test. Suggestions would be much appreciated.

Upon further testing and checking other cases from the failing tests, I think this can be solved more easily by adding quotes (like customFields."my-hyphenated-fields") directly in the filter arguments. I'm closing this PR :-)

Upon further testing and checking other cases from the failing tests, I think this can be solved more easily by adding quotes (like customFields."my-hyphenated-fields") directly in the filter arguments. I'm closing this PR :-)


ISPN-7683 a test

This is forwardported from product :)

retest this

retest this please

Speaking about assertions, I recently came over AssertJ and I must admit that I really like the fluent syntax. The existing support wouldn't cover all cases (e.g. our eventually* assertions would need to be implemented) and I wonder why exceptions require assertThatThrownBy, but I still like it.

To keep going off-topic, I also like the idea of AssertJ, but in order to convince everyone I think someone needs to do a POC (e.g. with BaseDistFunctionalTest and its subclasses) to show how complex assertions like assertOnAllCachesAndOwnership() would be easier to write and to reuse with a fluent syntax.
WRT assertThatThrownBy I think they expect specialized methods like assertThatIOException() to be used instead.

We are already using AssertJ - https://github.com/infinispan/infinispan/blob/master/server/rest/pom.xml#L67.
+1 to make it standard since they abstract the way JUnit and TestNG assertEquals are structured. In JUnit you have the expected value as first parameter but in TestNG it's the second one ;)
RT eventually, you can always write custom assertions (see the AssertJ docs).

@slaskawi We already have a solution for the assertEquals parameter order problem: never use org.testng.Assert, always use org.testng.AssertJUnit instead :)

...about always:
18:54:48@rvansa infinispan$ grep -R -I . -e 'import static org.testng.Assert[^J]' | wc -l
405

Rebased, and simplified the test so the only test param is the server instance. That should avoid confusion in the future.

@rvansa the rule was always there, but maybe not everyone was aware of it :)

I've simplified the test to not use data providers and make it all happen in a single test method. Should  be good now.

Integrated, thanks Adrian!


improve exception handling / diagnosis

in attic.archiver:727:
try:
    exit_code = archiver.run(sys.argv[1:])
except Error as e:
    archiver.print_error(e.get_message())
    exit_code = e.exit_code

The problem here is that print_error only prints very little information. No traceback, thus no information where it crashed. For debugging, I just added a "raise" before this line, to re-raise the Error and get a normal traceback.

Here's some patch to show tracebacks:
https://github.com/ThomasWaldmann/attic/commit/14d91a25fcfc68a16cfb29e8eb0ab203d4d236c0
Less pretty, but more useful in case of errors / hangs.


Update peerDependency to allow Grunt 1.0.0

All Grunt plugins are strongly recommended to update their peerDependencies to allow Grunt 1.0.0 as of an official announcement of its 1.0.0 release. This change make it.
http://gruntjs.com/blog/2016-04-04-grunt-1.0.0-released#peer-dependencies

Thanks!


Auto model updates notebook

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @rszper I mostly pulled the content from the webpage.

cc: @rezarokni

R: @damccorm


Schematics poor performance: Tree includes node_modules

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Performance of schematics.call() is poor and there is a possible memory leak in registerOptionsTransform.
Area
- [ ] devkit
- [x] schematics

Versions

"@angular-devkit/schematics": "0.0.35"

Repro steps

I have a method for generating blueprints based on https://github.com/angular/devkit/blob/master/packages/angular_devkit/schematics/bin/schematics.ts:
export class SchematicsManager {
  host = new NodeModulesEngineHost();
  engine = new SchematicEngine(this.host);
  config = { /* ... */ };

  generateBlueprint(collection, blueprint) {
    console.log((`Executing command: ng generate ${ blueprint }`));

    this.host.registerOptionsTransform((schematic: any, options: {}) => {
      const transformed = {
        ...this.defaults(schematic, options),
        ...this.values(schematic, options),
      };

      console.log(`registerOptionsTransform`);
      return transformed;
    });

    const _collection = this.engine.createCollection(collection);
    const schematic = _collection.createSchematic(blueprint);

    const dryRunSink
      = new DryRunSink(this.config.workspaceRoot, true);
    const fsSink
      = new FileSystemSink(this.config.workspaceRoot, true);
    const fsHost
      = new FileSystemHost(this.config.workspaceRoot);
    const tree$
      = of(new FileSystemTree(fsHost))

    dryRunSink.reporter.subscribe((event: DryRunEvent) => {
      /* ... */
    });

    schematic.call({}, tree$)

      .do(() => console.time('schematics.call()'))

      .map((tree: Tree) => Tree.optimize(tree))
      .concatMap((tree: Tree) => {
        return dryRunSink
          .commit(tree)
          .ignoreElements()
          .concat(of(tree));
      })
      .concatMap((tree: Tree) => {
        return dryRun || error
          ? of(tree)
          : fsSink
            .commit(tree)
            .ignoreElements()
            .concat(of(tree));
      })

      .do(() => console.timeEnd('schematics.call()'))

      .subscribe({
        error: (error) => { /* ... */ },
        complete: () => { /* ... */ }
      });

  }
}

The log given by the failure

When I call it to generate a few classes with generateBlueprint('@schematics/angular', 'class') this is the log:
Executing command: ng generate class
registerOptionsTransform
schematics.call(): 87.711ms
CREATE /src/app/x.ts (19 bytes)

Executing command: ng generate class
registerOptionsTransform
registerOptionsTransform
schematics.call(): 74.361ms
CREATE /src/app/x.ts (19 bytes)

Executing command: ng generate class
registerOptionsTransform
registerOptionsTransform
registerOptionsTransform
schematics.call(): 76.646ms
CREATE /src/app/x.ts (19 bytes)

It takes 7-9 seconds to generate this class, probably because the tree contains whole node_modules folder.
Also host.registerOptionsTransform() is called +1 times for each call. I tried unsubscribing in various places, using take(1) and some other things, but nothing worked. It seams there is a subscription somewhere that isn't cleared...
Desired functionality

If I set different root for the FileSystemHost:
    const fsHost
      // = new FileSystemHost(this.config.workspaceRoot);
      = new FileSystemHost(join(this.config.workspaceRoot, 'src/app'));

schematics are generated much faster 0.4-1s:
Executing command: ng generate class
registerOptionsTransform
schematics.call(): 16.902ms
CREATE /src/app/x.ts (19 bytes)

Executing command: ng generate class
registerOptionsTransform
registerOptionsTransform
schematics.call(): 9.312ms
CREATE /src/app/x.ts (19 bytes)

Executing command: ng generate class
registerOptionsTransform
registerOptionsTransform
registerOptionsTransform
schematics.call(): 4.560ms
CREATE /src/app/x.ts (19 bytes)

In my project I imported .angular-cli.json and used apps[ ... ].root as FileSystemHost root. Maybe something similar would be good for schematics too- using Tree without node_modules.
Any idea what could be causing multiple calls to host.registerOptionsTransform()?
Mention any other details that might be useful

A bit off-topic question: How are the paths for files generated? All schematics have name, path, sourceDir, appRoot properties, but no descriptions and I couldn't find exactly where they are used.

For the performance, can you try again with the latest versions?
For the registerOptionsTransform issue, that call should only happen once when the host is initialized.  In the code above it is being called on every generate and causing an additional transform function to be registered per generate call.

@clydin With 0.0.36 I'm getting a desired result, schematics.call() takes about a second. This is great as it will solve some other problems I had with non-root FileSystemHost. Thanks!

@clydin  service schematic is still slow, all others work as expected.

Filtering currently causes a full walk of the underlying tree.  For most schematics this is typically only done on the source tree and since source trees are generally small,  there is no noticeable performance impact.
The Angular service schematic, however, filters on the destination tree which can cause a performance problem for large file system trees.

@clydin Thanks for the clarification.


Should we retire heapster in dashboard addon

Heapster is deprecated, should we retire it from the addons?

Yes, we should. The dashboard addon needs some cleanup in general. It is not just the dashboard.

This is already retired from MicroK8s 1.19


Add play button for albums/playlists in SongCollectionList, shown on hover

Matches the behaviour in iTunes. Makes it easy to start playback of a full album/playlist without drilling down into it.

Thanks!


Fix build issue introduced in #25

Fixes #26

Coverage remained the same at 100.0% when pulling 5628ce4b39f62fd31a81f7c7aadbd7dcdbfac54e on APIs-guru:master into e6d5e9dc1aafe8d4712f22fb34d7781612e77127 on leebyron:master.

Also did run into this. had to downgrade graphql-js

when would it be published?

I hope this fix will be merge soon cause I can't deploy my app in production.  Please do it fast :s

#25 also breaks promise rejection,
if the iter.next() rejects, it won't propagate..
can this be fixed as well as part of this PR?

@DxCx I don't experience the same problem so it's hard for me to fix it.
Can you please open separate issue about it?
@leebyron This issue brakes many builds including apps that use graphql package.
Can you please merge this super simple PR?

@leebyron it would be nice if you merge it and make a new release as soon as possible.

Thanks for fixing this, Ivan!


Filter xlens in decode_match_xlen

filter xlens in decode_match_xlen so that the list is only those values less than Xlen.

This issue has been superceded.


Fix parsing of XAML setters when the child isn't a text node

What does the pull request do?
This PR fixes a problem introduced by #16153 that was preventing nested elements from being correctly assigned to property setters of primitive types.
The implementation now checks that there is a single parseable text node, instead of taking only the very first one into account.
A unit test has been added.
Fixed issues

Fixes #16754

https://github.com/AvaloniaUI/Avalonia/issues/17019 This might be fixed as well.


enhancement: add permission client sync prop

extend permission to contain the @Client.Synchronize prop

This feels redundant. Clients need to safeguard against empty ids anyway. Adding a property only adds conditions clints have to check.
When we change the sharedWithMe endpoint to always contain driveItems with a remoteItem we have to invent a non existing driveItem for an unmounted / unsynced remoteItem. OneDrive actually seems to create an id for those but it has no property to distinguish if a file should be synced or not. Onedrive does not have spaces. It only synchronizes the personal drive. Shares can be synced by adding 'shortcuts' to the shared file in the personal space. In a way the onedrive personal drive is our oc10 user storage with mountpoints. you can even add multiple 'shortcuts' aka mountpoints to the personal drive and move them ito any place you like.
Technically, this is easily possible to do. 'shortcuts' in the personal drive would then implicitly cause a share to be synced. Might be easier to understand than having to manage the synced status of shares ... but collecting them in a dedicated share jail is less confusing.
We can always add 'shortcuts' later.
Back to the issue at hand: using a dedicated property to indicate the synced status. I don't like adding redundancy, especially if it allows more contradictions that we need to test and prevent. What if id is empty but @Client.Synchronize is true or id is set but @Client.Synchronize is false?
I'd not add this property and rather improve the description of the driveItem id te explain that it might be empty in the sharedWithMe endpoint ... however ... an empty id violates the identifier nature for driveItems: "id": "string (identifier)", ...
urgh ... this sucks .... but we cannot really invent a stable idyentifier for non existing drive items. so leave it empty. and document that.

as discussed today<EMAIL_ADDRESS>and<EMAIL_ADDRESS>is now part of the remote item

as discussed today<EMAIL_ADDRESS>and<EMAIL_ADDRESS>is now part of the remote item

I would really love to understand why it was changed that way. Would be really cool if the commit message of the commit making that change contained some reasoning for that.
It is at least conflicting with the idea for grouping multiple share for a single use (e.g. direct share + group share) in a single remoteItem as outlined here: https://github.com/owncloud/ocis/pull/8016#issuecomment-1873973545

I also don't get that change honestly. When you have more than one share per remote item the hidden and synced states are conflicting.

@micbar i agree, that was one of my concerns too, but to be honest, please ask @butonic for details, we discussed it longer and he gave a pretty good explanation why it should be that way...
i just created the pr to be able to continue on the sharedWithMe PR.

I remember now. @kulmann @fschade and I decided that the ui property made more sense on the remote item because users do not care about individual permissions. They only care about resources. They don't want to reject permissions. Only resources. Brb


Crash after around 100~110 runs

It constantly happens, both the game and koolo would crash.
If I manually stop koolo at around 70~80 runs and start it again, then they won't crash, so I think it's koolo, not the game, or my OS/VM/hardware.
I'm doing only pindleskin runs with blizzard sor BTW, VM is on Proxmox VE with GPU passthrough, if that matters.

I observed a bit more and I think it's memory leak, koolo's memory usage is constantly increasing after each run, reaches 1.7GB after 33 runs, according to task manager.

By increasing windows virtual memory setting from 4G to 32G, I'm able to reach 500 runs until crash.

You should try with 64 now 😆
Thanks for reporting, I will take a look, many places that can be leaking actually, but must be something big.

I'm so close to setup a go env until you replied, haven't been doing go dev for quite a while, should not be too hard to figure it out with pprof though.
I'm okay with 500 consecutive runs now :D

I will be more than happy to review any contribution 😉

I'll take a look this weekend if you haven't fixed it by then 😉

pretty sure it will not be fixed by then 😢 I'm too busy introducing new memory leaks 🤣

Same here. Paused and shutdown the bot this morning. Now the CMD no longer works. It opens and shuts down instantly.


[Feature Request] Sulfuras & Self-Crafted

Sulfuras is an item crafted by the player.
It does not get a "made by" tag so a self-crafted challenge user might be locked out of their own weapon by crafting sulfuras.
Current workaround is to manually assign made by tag in DB by hand, but this could be automated ideally.
There may be other items which are "crafted" but not given "" tags.

Crazy idea but what if inscription had an item which applied a "made by" tag to items? As an optional file.


[balsa] Add config field to enable custom methods.

This is no behavioral change by default: only methods from a hard-coded list (that matches the list hard-coded in http-parser, and is slightly different from the one that will be used by UHV) are accepted.
Then the new knob is true, BalsaParser does the exact same validation as UHV will by default: method has to be non-empty and only contain allowed characters.
When UHV method validation logic is turned on in the future, all validation can be removed from BalsaParser. When non-UHV mode is deprecated, this new proto field can be removed.
This is reverting the part of #25714 that allows custom headers unconditionally if ENABLE_ENVOY_UHV is defined. This compile time option will be rolled out first in the process of launching UHV, and it is important not to introduce behavioral changes with it.
Tracking issue: #21245
Commit Message: [balsa] Add config field to enable custom methods.
Additional Description:
Risk Level: low, changed code is protected by existing default-false runtime flag.
Testing: //test/common/http/http1:codec_impl_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Runtime guard: envoy.reloadable_features.http1_use_balsa_parser

LGTM at a high level. Assigning over to @yanavlasov for review/merge as area owner.

/assign @alyssawilk
Alyssa: please verify that this PR achieves what we are aiming for.

/wait-any

Thinking more about this. Do we need this functionality ahead of UHV?

Making this functionality available costs exactly as much as landing this PR, and deprecating the field in the future in the same PR that deprecates the adjactent Balsa field. Given the projected timeline of Balsa rollout and UHV rollout, I think this is a reasonable cost for bringing this ahead.

@yanavlasov I agree on this - UHV isn't even landed and I suspect will remain months behind balsa, so adding a removable knob seems pretty cheap to me.

@yanavlasov gentle ping.

We have some internal discussions about this change. Will update PR when we sort it out.


TSC Recommendations - Dev Guidelines

@jason-fox @fgalan as commenters to this PR I would need a LGTM. We need to nail down this as soon as possible
thanks!

@jmcanterafonseca could yo add "Fixed in " marks to the opened comments so we can trace how each one has been addressed, pls? Thx!


add grouping functions

batching, be able to say "i want this thing dumped in 10 batches" or i want this in 10 batches but i only want the 3rd batch.

can use romans timestamp splitting tool to do this.

nobody has really asked for this.


Puts th inside thead, puts tr in tbody (plugins#updated)

Another small fix to html structure

:+1:


Update FC Image

Update to https://github.com/microsoft/frameworkcontroller/releases/tag/v0.7.0

Coverage remained the same at 34.34% when pulling c80b86b88b4955a63c4baffb649f816940a01de5 on yqwang/dev into d25096c8810c675db6a76746a2e984b673fe0c6d on master.


Simple throttle to handle rate limiting during update_slash_commands

This PR addresses issue #4 . It's a simple throttle that uses the returned header values X-RateLimit-Remaining and X-RateLimit-Reset that just goes into a loop until current epoch time is greater than ``X-RateLimit-Reset`
The meat and potatoes of it are on lines 141 and 151-170. I apologize for my formatter (Black) autoformatting everything thus creating a bunch of insertions and deletions. This may not be the most elegant solution but I've tested it on my end and I'm able to get more than 2 discord commands registered as where before I couldn't. Even if you don't accept the PR I hope it helps. Here's a link to the relevant docs from discord https://discord.com/developers/docs/topics/rate-limits
-Brad

Thank you for taking the time to submit this PR! I've tested your changes and everything seems to work great.
I've cleaned up the diff by removing the autoformatter changes--any discussion of changes to the code style should probably happen elsewhere. I also cleaned up the throttle function a bit, removing the while loop and just calculating the sleep duration based on the X-RateLimit-Reset value.
Thank you for linking to the relevant documentation as well. I think Discord changed the rate limits for slash commands at some point, which is why my library started having issues. I'll push this as a new version to PyPI soon!


feat: Implemented the LineaWorldID and Modifier functionality

I have followed this documentation as used in issue #1
Updated contracts :

LineaWorldID.sol

Replaced CrossDomainOwnable3 with MessageServiceBase to apply caller modifier, as mentioned in Linea Messaging docs
Replaced onlyOwner modifier with onlyMessagingService and  onlyAuthorizedRemoteSender as provided by MessageServiceBase
Added updateMessageServiceBase to update Authorised addresses

Added MessageServiceBase(contains new modifiers), IMessageService(dependency for MessageServiceBase), ILineaWorldID(dependency of LineaWorldId)

Hi @0xprinc , do forge fmt to lint the code well.

@0xprinc Looks good overall. Thank you very much for your contribution!


Mangadex doesn't list all chapters given the language

Describe the bug
I'm running into the issue where I'm trying to download JoJo's part 5 colored, and it only lists 70 chapters out of 155. At first I thought it was the issue described at #155 which was said that it was because of external links. It is not the case for this manga.
I tracked it down to the language option, as using "any" shows the correct chapters (and all other languages, too), but "en" stops at 70.
The manga in question is this one (there are 2 with the same name). I've manually checked the API and the chapters are fine.
By using the API directly with the language "en" (https://api.mangadex.org/manga/fd917921-5e97-479f-b22c-5d7f00e1c830/aggregate?translatedLanguage[]=en) gives all the 155 chapters.
I even checked chapter 71, 72 and 73 to see if they had the correct language and if they were not external. I used the API for this too (https://api.mangadex.org/chapter/ecbda659-532a-401f-8585-d6025bf745fe, change the id for whatever chapter id).
Why is 500 added to the offset at line 60-63 at chapters.go?, looks like it would be added too often... and all "en" chapters are available. Also lines 86-92 are both out of the for loop, maybe this is a bug?
Reproduction steps

Search for "Jojos colored" using built in Mangadex (using language "en").
Select "JoJo's Bizarre Adventure Part 5: Vento Aureo" (fd917921-5e97-479f-b22c-5d7f00e1c830).
It will only show 70 chapters.
Using the API we can see that for "en", there are 155 chapters (https://api.mangadex.org/manga/fd917921-5e97-479f-b22c-5d7f00e1c830/aggregate?translatedLanguage[]=en).
We can check that chapter 71 is "en" and externalUrl is null (https://api.mangadex.org/chapter/ecbda659-532a-401f-8585-d6025bf745fe).
Do the same search with "any" as language, and the correct "en" 71 chapter will be found (id ecbda659-532a-401f-8585-d6025bf745fe). This might require to delete  the mangal cache.

Expected behavior
To actually list all chapters with the specified language.
Additional context
No response
Operating System
Linux

Ok, found the issue, already fixed on my local. It is an issue with the offset. The way it is meant to work is to use an offset to get chunks of chapters (500 per is the max). The issue was that the offset was increased by 500 each time the language was not met, so the chapters after 500 where lost due to the offset being grater than the total of chapters.
Will be creating a PR for this once I figure out how to do so lol.

It's fixed by the two commits on the closed pull request, if needed you can get those from my fork.

Still have the same issue

This seems to have fixed it for my local build.  Had to clear cache for the change to become effective.
@jorgejung If you are still having the issue then clear the cache for mangal.  On Windows it is in Local Appdata.  I don't know where it is on other platforms (if it matters).

@shinji257 you might be using a different fork, because the bug still exists in this code, for a more updated version you could use https://github.com/Belphemur/mangal or my fork (heavily different, so not a drop-in replacement yet)

@shinji257 you might be using a different fork, because the bug still exists in this code, for a more updated version you could use https://github.com/Belphemur/mangal or my fork (heavily different, so not a drop-in replacement yet)

I'm using this repo + the two commits you indicate fixes it. That's what I mean when I say "this seems to have fixed it". I had to clear cache out for mangal so it could pull the data again but for the one manga where I hit it then it pulled fine after. It might be that I need to have a larger manga to check for it still happening.
I'll give the forks you indicated (yours and mangal) a go sometime to see how they work out for me.

Ah I see, my bad I didn't read correctly I thought you said something in the lines of "it fixed by itself for me" for some reason. I'm not sure if Belphemur implemented the fix but you could check. If you check mine (uses updated version of v5 branch from metafates, with some updates for myself) just expect things to break (it will complain about the mangal config); ping me/open an issue on my repo/PR and I'll happily look into it. Belphemur is also pretty active and has added a ton of stuff and updated his version, too.


Arrow to go back between way- point challenges

Challenge http://www.freecodecamp.com/challenges/waypoint-use-a-css-class-to-style-an-element has an issue. Please describe how to reproduce it, and include links to screen shots if possible.
Should be a simple-fix
Right from the screen an arrow that allows a user to go back in order to check previous solution so that  one can understand why one method is superior to another

Hey @gabazine, thanks for posting.
I'm not sure I understand the request here.  Since it is pretty stale I'm going to close it but feel free to reopen and clarify.


added workflow for github actions

I was thinking more of a .yml file type of Github action, check out this

I was thinking more of a .yml file type of Github action, check out this

ohh sorry for the problem ... i updated the issue can u please recheck it once


Fix Flash Attention forward for Llama-2 70b

This pull request fixes #28  when training LLama-2 70b with LoRA and flash attention.

@philschmid can you have a look?

Can you please explain why this should fix flash attention for GQA?

The 70B are also having tp == 1 https://huggingface.co/meta-llama/Llama-2-70b-hf/blob/main/config.json#L17

LGTM. Can you share a script to quickly reproduce it?

here you go: d91f6ddf2a0a05e92ebc865d8fe1e42b9eac7849

LGTM. Can you share a script to quickly reproduce it?

here you go: d91f6dd

actually, we don't want to have this in the repo so here:
from datasets import load_dataset
from peft import LoraConfig, prepare_model_for_kbit_training, get_peft_model
from transformers import TrainingArguments
from trl import SFTTrainer
from random import randrange
import torch
from transformers import AutoTokenizer, AutoModelForCausalLM, BitsAndBytesConfig

# Load dataset from the hub
dataset = load_dataset("databricks/databricks-dolly-15k", split="train")

print(f"dataset size: {len(dataset)}")
print(dataset[randrange(len(dataset))])
# dataset size: 15011

def format_instruction(sample):
	return f"""### Instruction:
Use the Input below to create an instruction, which could have been used to generate the input using an LLM.

### Input:
{sample['response']}

### Response:
{sample['instruction']}
"""

use_flash_attention = True
# COMMENT IN TO USE FLASH ATTENTION
# replace attention with flash attention
if torch.cuda.get_device_capability()[0] >= 8:
    from utils.llama_patch import replace_attn_with_flash_attn
    print("Using flash attention")
    replace_attn_with_flash_attn()

# Hugging Face model id
#model_id = "NousResearch/Llama-2-70b-hf" # non-gated
model_id = "meta-llama/Llama-2-70b-hf" # gated

# BitsAndBytesConfig int-4 config
bnb_config = BitsAndBytesConfig(
    load_in_4bit=True,
    bnb_4bit_use_double_quant=True,
    bnb_4bit_quant_type="nf4",
    bnb_4bit_compute_dtype=torch.bfloat16
)

# Load model and tokenizer
model = AutoModelForCausalLM.from_pretrained(model_id, quantization_config=bnb_config, use_cache=False, device_map="auto")
model.config.pretraining_tp = 1

# Validate that the model is using flash attention, by comparing doc strings
if use_flash_attention:
    from utils.llama_patch import forward
    assert model.model.layers[0].self_attn.forward.__doc__ == forward.__doc__, "Model is not using flash attention"

tokenizer = AutoTokenizer.from_pretrained(model_id)
tokenizer.pad_token = tokenizer.eos_token
tokenizer.padding_side = "right"

# LoRA config based on QLoRA paper
peft_config = LoraConfig(
        lora_alpha=16,
        lora_dropout=0.1,
        r=64,
        bias="none",
        task_type="CAUSAL_LM",
)

args = TrainingArguments(
    output_dir="llama-70-int4-dolly",
    num_train_epochs=3,
    per_device_train_batch_size=6 if use_flash_attention else 4,
    gradient_accumulation_steps=2,
    gradient_checkpointing=True,
    optim="paged_adamw_32bit",
    logging_steps=10,
    save_strategy="epoch",
    learning_rate=2e-4,
    bf16=True,
    tf32=True,
    max_grad_norm=0.3,
    warmup_ratio=0.03,
    lr_scheduler_type="constant",
#    disable_tqdm=True # disable tqdm since with packing values are in correct
)

# prepare model for training
model = prepare_model_for_kbit_training(model)

# Upcast layer for flash attnetion
if use_flash_attention:
    from utils.llama_patch import upcast_layer_for_flash_attention
    torch_dtype = torch.bfloat16 if args.bf16 else torch.float16 if args.fp16 else torch.float32
    model = upcast_layer_for_flash_attention(model, torch_dtype)

model = get_peft_model(model, peft_config)
max_seq_length = 2048 # max sequence length for model and packing of the dataset

trainer = SFTTrainer(
    model=model,
    train_dataset=dataset,
    peft_config=peft_config,
    max_seq_length=max_seq_length,
    tokenizer=tokenizer,
    packing=True,
    formatting_func=format_instruction,
    args=args,
)

# train
trainer.train()

Neeeded to revert this since the training for 7B became 10x worse and inference wasn't working anymore

For me inference with the 7B model works just the same

I will look into it next week when I have more time

Yeah inference worked, was due flash attetnion being loaded. But running the example with the suggested patch from this branch results into poor performance. Will also try to see from what it is coming from if i have time.


"My organization isn't listed." workflow is inconsistent

Expected behaviour:
I should not be able to edit the super admin in http://localhost:3000/super_admin/users/1/edit
OR
The "My organization isn't listed." button should work
Actual behaviour:
In http://localhost:3000/org/admin/users/admin_index, I can see the list of users, and there is no edit link under the privileges column. Then if I click that user who don't have the edit link button, I will arrive at http://localhost:3000/super_admin/users/1/edit.
But I shouldn't be able to edit it.
If I am able to edit it, the "My organization isn't listed." button doesn't work. (while the same button at http://localhost:3000/users/edit works)
Steps to reproduce:

Setup the roadmap application from scratch according to installation wiki
Open http://localhost:3000/org/admin/users/admin_index and click the first user (should be super user)
see that clicking the "My organization isn't listed."button doesn't work

Note
I tried to debug the issue by doing a system search on the key word "My organization isn't listed." but the js are all ulgified, do you have a normal version somewhere?

hi @Yu-Chieh-Henry-Yang,  thanks for the bug report. I can confirm that this is also an issue on our running services.
The view partial which renders that is shared with the edit profile page, and as is the js.
All of our js lives under lib/assets/javascripts
for whoever picks this ticket up, partial is app/views/shared/_my_org.html.erb and js at lib/assets/javascripts/views/shared/my_org.js

this may be fixed in #1588. If not we can add it since the PR makes modifications to those files for form validation updates.

moving this to the current sprint so i can test. the link works now but the behavior should be the same as when a user clicks the "My Org isn't listed" link to edit their own profile or creates an account.
currently, as a Super Admin I get the following validation error if I don't enter a valid Org and then i can't save the changes (screenshot 1). I should be permitted to save this entry and/or provide a default "No affiliation" entry.
this raises the question about how we're storing/identifying these free text user affiliations in the database. my understanding is that we want to present a "No affiliation" option and use this value in the db even if a user inputs something into this field. can someone confirm that this is the current db situation? our workflow for dmptool is slightly different so i'm confused about the correct behavior for roadmap.

this is working as expected now. closing issue,

Hello,
You should probably add a rake to add a other_org in the database if there isn't at least one.
It's not currently possible to add one through the UI.
If there is no other orgs in the db, the form validation won't get through because the hidden field don't have a value, ex:
<input value="" name="user[other_org_id]" id="93_user_other_org_id" type="hidden">

that's a good point @benjaminfaure