outDir option does not copy the ts files

The tsconfig.json file in my project looks like below. I have outDir set to wwwroot/app. This option copies the js files and the map files. See the picture.
But this outDir option does not copy the sources (ts files from where js files are generated) to the wwwroot/app directory, so the debugging can't be done in IE or any browser.
Is this a bug, or should I set some other option to make it work? Or should I use gulp task to copy the source files?
{
  "compilerOptions": {
    "noImplicitAny": false,
    "noEmitOnError": true,
    "removeComments": false,
    "sourceMap": true,
    "target": "es5",
    "module": "system",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "moduleResolution": "classic",
    "outDir": "wwwroot/app"
  },
  "exclude": [
    "node_modules",
    "wwwroot"
  ]
}

It is not designed to copy the source files.  If you want the source files available, you should do as you suggested and copy them external to the tsc compiler.

Here's the issue with the way typescript is working in Visual Studio 2015 right now with and without the outDir when working with ASPNET5 (sorry, core!)

If you follow best practices and put your .ts files in a separate directory outside of the wwwroot then your .js and .js.map files are in that directory. Which would be fine, use gulp and watch and copy them into the final location. Except then the .js.map points to the wrong location and debugging doesn't work properly. And I have yet to find any rewrite that I can do the relative paths with properly in gulp. Thus this is a no-go.

If you use outDir and you have any other dependencies that are in a different relative sub folder because it comes from another solution (i.e. your api generating typescript interfaces for objects) then outDir goes and creates a silly pathing under whatever you put in outDir.

Oddly, if you use gulp and use outdir instead of outDir then you get the pathing you would expect and it works normally, but then you have to use gulp to compile typescript instead of Visual Studio, and then watch for changes to .ts files to try and get it to compile on save, which is a mess and it doesn't error in a useful way (i.e. they're not in the error window) and doesn't stop execution of your app in debug when there is an error so you're wondering why your typescript changes had no effect.
In short this is a mess right now that needs to be fixed because as it stands the only viable alternative is to put your typescript files in the wwwroot which is a bad solution.

@JohnGalt1717, i d not think your commments are related to the OP.
For outDir computation, if you only specify --outDir the output structure generated by the compiler is mapped to the input, this is based on a common path calculation, which is the longest common prefix of all your input files. Obviouslly this changes with the input files, so to tell the compiler what is the root of your source tree that you want mapped in the output, use --rootDir.
For map files, you do not need to move them along with the js files. use --mapRoot to tell your debugger where to find them, this can be a local path, or a UNC file path, or even a web address.
If you do move the map files, but now the reference to the sources files are wrong, use --sourceRoot to specify the location of the sources. again this can be a local file path, or a web address.
hope that helps.

Here's my structure:
/wwwroot/app <= this is the destination for the js and map files. (with full hierarchy of ./controllers, ./directives etc.)
/scripts/ <= this is the source of the ts files. (with a full hierarchy of ./controllers, ./directives etc.)
using Vs.net 2015 Update 1 with ASPNET 5 RC1 Update 1 please explain how these options can compile the .ts files from the /scripts/ folder into the /wwwroot/app folder properly with the .map files pointing to the right .ts files so that everything will work in IE and Chrome to debug into the .ts files.
And note that the /scripts/*.ts files have a reference at the top that points to something in ../..//scripts/Interfaces.ts and it shouldn't be copied over at all because it's out of the project and it shouldn't effect the pathing that is created in the /wwwroot/app folder.
Anyone doing strong typing from their API to their angular or other app using ts (huge win for testability and reliability by doing this so everyone should be doing this) will have a similar structure so it needs to be supported.
If you use outdir instead of outDir using gulp and TSC it will compile them into the right spots and even the map files will be right. However this isn't recognized by VS.net as a valid param in the tsconfig file and thus can't be used (it just ignores it and compiles to the same directory)

/wwwroot/app <= this is the destination for the js and map files. (with full hierarchy of ./controllers, ./directives etc.)

/scripts/ <= this is the source of the ts files. (with a full hierarchy of ./controllers, ./directives etc.)

using Vs.net 2015 Update 1 with ASPNET 5 RC1 Update 1 please explain how these options can compile the .ts files from the /scripts/ folder into the /wwwroot/app folder properly with the .map files pointing to the right .ts files so that everything will work in IE and Chrome to debug into the .ts files.

set config to be:
{
    "compilerOptions": {
        "outDir": "./wwwroot/app", // put output in /wwwroot/app
        "rootDir": "./scripts" // all inputs are under /scripts
    }
}

And note that the /scripts/*.ts files have a reference at the top that points to something in ../..//scripts/Interfaces.ts and it shouldn't be copied over at all because it's out of the project and it shouldn't effect the path that is created in the /wwwroot/app folder.

That is the problem here. interfaces.ts should be interfaces.d.ts, to tell the compiler that there is no output for it. if it is a .ts file, the compiler has to generate a file for it, and it does not know where to put it at this point, since it does not fit under the rootDir.
Having said that, if gulp is working fine for you, i do not see why you can not use it. TypeScript compiler is not meant to be a build system. Similarly VS is an IDE, it has build integration with MSBuild, but you can use any other build system that works for you with the Task Runner Explorer.

This creates a folder under /wwwroot/app with the project name/src/project name/scripts/ instead of them being deployed in the /wwwroot/app folder itself.
This is the issue endlessly and useing outdir instead of outDir is just a hack because it isn't even supported.
Further, there is no guidance on how gulp should be setup for typescript to work properly and get compile on save, and incremental compile instead of always compile and if you setup watches it fails for bizzare reasons etc.
It shouldn't be this hard to use a basic tool like typescript in aspnetcore. Hence why I went back to using msbuild and vs.net's settings for it, but then it's borked completely.
The problem with using .d.ts is that it isn't just definitions and if I make it add definitions then in that project I get endless compile failures because of everything being defined twice.

This creates a folder under /wwwroot/app with the project name/src/project name/scripts/ instead of them being deployed in the /wwwroot/app folder itself.

you are not using rootDir, this has been my comment from the beginning :) rootDir changed the behavior of outDir.

Further, there is no guidance on how gulp should be setup for typescript to work properly and get compile on save, and incremental compile instead of always compile and if you setup watches it fails for bizzare reasons etc.

if you use gulp/grunt/etc.. you can not use compile on save. gulp has a watch mode, and that would be my recommendation here.

It shouldn't be this hard to use a basic tool like typescript in aspnetcore. Hence why I went back to using msbuild and vs.net's settings for it, but then it's borked completely.

I agree, and i agree the documentation is not compete here. can you share a setup that we can look at and see what issues are happening and how we can make it better, and hopefully write a sample in the process.

The problem with using .d.ts is that it isn't just definitions and if I make it add definitions then in that project I get endless compile failures because of everything being defined twice.

I think these should be compiled twice. i.e. once for your interfaces.ts and once for your other scripts, this way you have two outputs. The fix for issue https://github.com/Microsoft/TypeScript/issues/4714 should make this possible. but again, i would appreciate a repro i can look at.

Except I did use rootDir. I copied exactly what you put in the tsconfig file and got those results.
Gulp watch causes tsc to fail on compile. Hence I can't use it.
here's my tsconfig.json file that is in the /scripts folder:
{   "compilerOptions": {     "noImplicitAny": false,     "noEmitOnError": true,     "removeComments": true,     "sourceMap": true,     "target": "es5",     "module": "amd",     "outdir": "../wwwroot/app"   },   "exclude": [     "node_modules",     "wwwroot"   ] }
Just put any old typescript file in there.
Here's my gulp:
`///
"use strict";
var gulp = require("gulp"),
rimraf = require("rimraf"),
concat = require("gulp-concat"),
cssmin = require("gulp-cssmin"),
uglify = require("gulp-uglify"),
watch = require("gulp-watch"),
less = require("gulp-less"),
livereload = require("gulp-livereload"),
debug = require('gulp-debug'),
inject = require('gulp-inject'),
tsc = require('gulp-typescript'),
tslint = require('gulp-tslint'),
sourcemaps = require('gulp-sourcemaps'),
del = require('del'),
Config = require('./gulpfile.config'),
cache = require('gulp-cached'),
tsProject = tsc.createProject('./scripts/tsconfig.json');
var config = new Config();
var replace = require("gulp-replace");
var gutil = require('gulp-util');
var project = require("./project.json");
var paths = {
webroot: "./wwwroot/"
};
var environment = {
// The names of the different environments.
development: "Debug",
beta: "Beta",
qa: "QA",
demo: "Demo",
production: "Release",
// Gets the current hosting environment the application is running under. This comes from the environment variables.
current: function () { return gutil.env.ASPNET_ENV || this.development },
// Are we running under the development environment.
isDevelopment: function () { return this.current() === this.development; },
// Are we running under the staging environment.
isBeta: function () { return this.current() === this.beta; },
isQA: function () { return this.current() === this.qa; },
isDemo: function () { return this.current() === this.demo; },
// Are we running under the production environment.
isProduction: function () { return this.current() === this.production; }
};
paths.js = paths.webroot + "js//*.js";
paths.minJs = paths.webroot + "js//.min.js";
paths.css = paths.webroot + "css/**/.css";
paths.minCss = paths.webroot + "css/**/*.min.css";
paths.concatJsDest = paths.webroot + "js/site.min.js";
paths.concatCssDest = paths.webroot + "css/site.min.css";
gulp.task("clean:js", function (cb) {
rimraf(paths.concatJsDest, cb);
});
gulp.task("clean:css", function (cb) {
rimraf(paths.concatCssDest, cb);
});
gulp.task("clean", ["clean:js", "clean:css", "clean-ts"]);
gulp.task("min:js", function () {
return gulp.src([paths.js, "!" + paths.minJs], { base: "." })
.pipe(concat(paths.concatJsDest))
.pipe(uglify())
.pipe(gulp.dest("."));
});
gulp.task("min:css", function () {
return gulp.src([paths.css, "!" + paths.minCss])
.pipe(concat(paths.concatCssDest))
.pipe(cssmin())
.pipe(gulp.dest("."));
});
gulp.task("less", function () {
return gulp.src('Styles/*.less')
.pipe(cache('less'))
.pipe(less({ compress: true }))
.pipe(gulp.dest(paths.webroot + '/css'))
.pipe(livereload());
});
gulp.task("html", function () {
return gulp.src('views/**/*.html')
.pipe(cache('html'))
.pipe(gulp.dest(paths.webroot + '/app/views'))
.pipe(livereload());
});
/**

Lint all custom TypeScript files.
*/
gulp.task('ts-lint', function () {
return gulp.src(config.allTypeScript)
.pipe(cache('ts-lint'))
.pipe(tslint())
.pipe(tslint.report('prose'));
});

/**

Compile TypeScript and include references to library and app .d.ts files.
*/
gulp.task('compileTs', function () {
var sourceTsFiles = [config.allTypeScript,                //path to typescript files
config.libraryTypeScriptDefinitions]; //reference to library .d.ts files
var tsResult = gulp.src(sourceTsFiles)
.pipe(cache('compileTs'))
.pipe(sourcemaps.init())
.pipe(tsc(tsProject));
//tsResult.dts.pipe(gulp.dest(config.tsOutputPath));
//return tsResult.js.pipe(gulp.dest(config.tsOutputPath));
return tsResult.js
.pipe(sourcemaps.write('.', { includeContent: false, sourceRoot: __dirname + "\scripts\" }))
.pipe(gulp.dest(config.tsOutputPath))
.on("error", function(e) {
console.log("error: Typescript Compile Failed: " + e);
});
});

/**

Compile TypeScript and include references to library and app .d.ts files.
*/
gulp.task('compileTs-nosource', function () {
var sourceTsFiles = [config.allTypeScript,                //path to typescript files
config.libraryTypeScriptDefinitions]; //reference to library .d.ts files
var tsResult = gulp.src(sourceTsFiles)
.pipe(tsc(tsProject));
//tsResult.dts.pipe(gulp.dest(config.tsOutputPath));
//return tsResult.js.pipe(gulp.dest(config.tsOutputPath));
return tsResult.js
.pipe(gulp.dest(config.tsOutputPath))
.on("error", function (e) {
console.log("error: Typescript Compile Failed: " + e);
});
});

/**

Remove all generated JavaScript files from TypeScript compilation.
/
gulp.task('clean-ts', function (cb) {
var typeScriptGenFiles = [
config.tsOutputPath + '/**/.js',    // path to all JS files auto gen'd by editor
config.tsOutputPath + '/**/*.js.map', // path to all sourcemap files auto gen'd by editor
'!' + config.tsOutputPath + '/lib'
];
// delete the files
del(typeScriptGenFiles, cb);
});

gulp.task("cleanRelease", function () {
console.log(process.env);
gulp.src(["wwwroot/app/app.js"])
.pipe(replace("http://localhost:64553/", environment.isBeta ? "https://betaapi.azurewebsites.net/" : environment.isDemo ? "https://demoapi.azurewebsites.net/" : environment.isProduction ? "https://api.azurewebsites.net/" : "https://qaapi.azurewebsites.net/"))
.pipe(gulp.dest("wwwroot/app"));
});
gulp.task('watchTs', function () {
gulp.watch([config.allTypeScript], ['compileTs']);
});
gulp.task("watchLess", function () {
gulp.watch("styles/**/*.less", ["less"]);
});
gulp.task("watchHtml", function () {
gulp.watch("views/**/*.html", ["html"]);
});
gulp.task("min", ["min:js", "min:css"]);
//gulp.task("default", ["ts-lint", "compile-ts"]);`
Run compile-ts and you'll see what it does. It goes all of the way back to the solution root folder even with rootDir specified.


Top-position activity bar background theming

#202715 (merged as c005fc3) added activityBarTop.foreground and other colors relating to the foreground of icons in the activity bar when it is configured to be at the top of the sidebar. I'd like colors for the activity bar background when it is at the top.
Specifically, I'd like these new colors:

activityBarTop.background to set the background of inactive icons and the region of the top activity bar not occupied by icons, corresponding to activityBar.background.
activityBarTop.activeBackground to set the background of the active icon in the top activity bar, corresponding to activityBar.activeBackground.

See also #202032, #197345.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Please add a mouseover background color, a mouseover foreground color, and a mouseover border color for the icon

"workbench.colorCustomizations": {
      "activityBarTop.iconHoverForeground": "#0b1691",
      "activityBarTop.iconHoverBorder": "#ff0000",
      "activityBarTop.iconHoverBackground": "#ff0000",
  },

vscode 1.86
Windown 10

We added two new color. One for the activity bar background when it is set to the top / bottom (sideBarActivityBarTop.border) and one for the border between the activity bar when set to top / bottom and the views (activityBarTop.background)

Added activityBarTop.activeBackground

@benibenj
Thank you very much for your efforts! 🎉👍👏😜
What needs to be added is:
Can you add the following color setting items:

"workbench.colorCustomizations": {
      "activityBarTop.iconHoverForeground": "#0b1691",
      "activityBarTop.iconHoverBorder": "#ff0000",
      "activityBarTop.iconHoverBackground": "#ff0000",
  },

This color setting project has been a long time coming, but no one has ever made it happen.

@zhouxinghong Can you create a separate issue for this? These are colors that we don't yet have for the default activity bar, right? In that case, please also include a very short description for each color in the issue.

@benibenj
Thank you very much for your reply, teacher! 🎉👏.
I've created this toolbar color issue three times already, but all of them have been rejected. So I am already a bit scared and if I again create a new question for this issue can be entrusted to you, Sensei, then I will have the confidence to continue creating new questions for that issue. 😜

@benibenj No need at the moment, thank you very much!


Fix PWA, .webmanifest, generic.py

Hello, guys!
This is my first commit, and I am very happy to be part of this great community and contribute. I found these errors in the Progressive Web App (PWA), so I decided to fix them.

I use Maskable App to create maskable icons with the classic LNbits color.

I wasn't sure which sizes you needed, so I chose some of them.

I decided to add them in the 'static directory' where the favicon file was.

Source: Mozilla PWA

No more PWA errors; everything works fine now.

The new icons look great.

Maybe you will decide to create new official PWA screenshots from a different page.

When a user decides to install the PWA, they will see the screenshot_desktop (wide) if they are on a desktop, and if they are on a phone, they will see the screenshot_phone (narrow). I highly recommend changing the description from 'Bitcoin Lightning Wallet' to 'LNbits - free and open-source lightning wallet'; it will look better in my opinion.

Maskable icon after installing the app on my Mac.

The screenshots aren't the best.

P.S. Happy first commit to me!

Hey @prusnak,
I've successfully wrapped up the tasks you assigned me:

I've relocated the four .png files to the lnbits/static/images directory, along with the two .webp files.

I've optimized the PNGs using OptiPNG, and here's the detailed report:

lnbits/static/images/maskable_icon.png

Original: 50859 bytes
Optimized: 22401 bytes (55.95% decrease)

lnbits/static/images/maskable_icon_x192.png

Original: 5647 bytes
Optimized: 3490 bytes (38.20% decrease)

lnbits/static/images/maskable_icon_x512.png

Original: 19027 bytes
Optimized: 9345 bytes (50.89% decrease)

lnbits/static/images/maskable_icon_x96.png

Original: 2545 bytes
Optimized: 1522 bytes (40.20% decrease)

Tasks completed, and the PNGs are now optimized for smoother performance.
I haven't optimized the two .webp screenshots yet. I'm thinking we might want to consider using a tool specifically tailored for WebP images, such as cwebp. To streamline the process, we could either create a new script, similar to optipng.sh, dedicated to .webp images, or we can extend the existing script to handle this format as well. I'm not entirely certain about the best approach.
{
                "src": (
                    settings.lnbits_custom_logo
                    if settings.lnbits_custom_logo
                    else<EMAIL_ADDRESS>                ),
                "sizes": "512x512",
                "type": "image/png"
            },
            {
      "src": (
                    settings.lnbits_custom_favicon
                    if settings.lnbits_custom_favicon
                    else "static/favicon.ico"
                ),
      "sizes": "32x32",
      "type": "image/x-icon"
    },

We can enhance the configurational flexibility by adding extra settings for different images like settings.lnbits_custom_logo. For instance, we might introduce settings such as settings.lnbits_custom_favicon, settings.lnbits_custom_maskable_icon ... ,  and so forth. This approach would enable seamless customization of various images across the entire application.
PWA tested on Android phone - Screenshots:

New bugs were found in the PWA on the phone:

Custom messages are in front of the Logo Text/Logo Icon.
The icon for 'Toggle Dark Mode' is missing; when the phone is rotated, the icon appears.

Best,
mrbpp

I haven't optimized the two .webp screenshots yet. ...  I'm not entirely certain about the best approach.

Do the screenshots have to be in WebP format. I did try to convert them into PNG and optimized them with the optipng script and the resulting files are much smaller:
 99049 screenshot_desktop.png
219531 screenshot_desktop.webp
 35446 screenshot_phone.png
 70709 screenshot_phone.webp

My suggestion is to use optimized PNGs if PNG format can be used.

TL;DR: Updated screenshots for desktop and phone with a classic theme, optimized sizes, reduced file size, and cleaned metadata.
I followed the instructions from the Mozilla Developers page. They use .webp, but I think .png will be okay. So, here is my report with new and improved screenshots from both desktop and phone:
Optimized desktop screenshot:
Reduced from 220,193 to 98,187 bytes (55.41% decrease).
Optimized phone screenshot:
Reduced from 147,160 to 120,332 bytes (18.23% decrease).
Additionally, I have removed the metadata from the screenshots using exiftool.
MAC/Homebrew:
exiftool -n /path/file # check metadata
exiftool -all= -overwrite_original /path/file # clean metadata

As you mentioned, it also worked with .png; I tested it.

I did not find any errors.

Looks great.
However, the WEBP files are still being added (each file twice even).
Please remove them with:
git rm lnbits/static/*.webp lnbits/static/images/*.webp
git commit -a

Once this is addressed, we can merge IMO.

Bit weird to have ANOTHER version of a logo, wonder from where that grey came. They should all be the same and not make up additional colours..

It is't another logo; it's a maskable icon. The color comes from the classic Lnbits theme.

Grey is not part of the logo. The background should not be an additional colour.

I tried with black, but it didn't look so good.

It looks exactly the way it should - like the logo. A PR about maskable icons should not mess with CI in that way.

You need to understand that the lnbits logo is a circle and some devices don't support maskable icons in the shape of a circle. I didn't want to add this additional color but the rounded square shape of the maskable icon needed a background color. I couldn't have used a black color because it would have blended in with the original color of the logo. That's why I chose the best possible option, which was the dark gray that's already been used in the lnbits theme. In my opinion, that's not a completely new logo, it was just a necessary thing to do. Thank you for the feedback and I apologize for the inconvenience.

I'm putting my designer hat on. Design is subjective, but these icons are small and visibility at a distance is critical. The grey doesn't look great from a branding perspective. For a small icon the black should be the entire background, not circle within the bounds of the rounded icon. Perhaps this is what @arbadacarbaYK  is referring to. Example here:

I like it, but I thought you wanted it to be round.

We already got 4 versions of a logo, pls just dont add another one, its all too wild.
The background needs to be the one of the logo itself as bitkarrot has shown..

Isn't the idea to use the original LNbits logo, that's round?

Ok.

Maskable icons are all fun and games until you add a colour to it :) Doesnt matter if they are round or square

What is the color code for the dark shade in the logo (not the purple one, which represents Bolt)?

Also, @bitkarrot , what padding are you using? I'd like to replicate the same look, perhaps around 20%, but I'm not entirely sure.

Color: #1e1e1e ;
Padding: 40% ;
Image Optimization Report:

lnbits/static/images/maskable_icon.png

Original: 42098 bytes, Reduced to: 15727 bytes (62.64% decrease)

lnbits/static/images/maskable_icon_x192.png

Original: 4257 bytes, Reduced to: 2383 bytes (44.02% decrease)

lnbits/static/images/maskable_icon_x512.png

Original: 14654 bytes, Reduced to: 6144 bytes (58.07% decrease)

lnbits/static/images/maskable_icon_x96.png

Original: 2029 bytes, Reduced to: 1231 bytes (39.33% decrease)

I have made the modifications you requested.
@arbadacarbaYK and @bitkarrot , please take a moment to review it when you have the time.
Have a great weekend!

I will handle it.
I am new to Git and GitHub, and that's my first commit.
I am so happy that I can contribute to the awesome LNbits.
By the way, I am inspired by the great work you do, @dni. Also, I want to thank @prusnak for helping me with this PR, it was a pleasure.

I'm not sure if everything is fine now, so I would appreciate it if you @dni could double-check.


[SPARK-18538] [SQL] Fix Concurrent Table Fetching Using DataFrameReader JDBC APIs

What changes were proposed in this pull request?
The following two DataFrameReader JDBC APIs ignore the user-specified parameters of parallelism degree.
  def jdbc(
      url: String,
      table: String,
      columnName: String,
      lowerBound: Long,
      upperBound: Long,
      numPartitions: Int,
      connectionProperties: Properties): DataFrame

  def jdbc(
      url: String,
      table: String,
      predicates: Array[String],
      connectionProperties: Properties): DataFrame

This PR is to fix the issues. To verify the behavior correctness, we improve the plan output of EXPLAIN command by adding numPartitions in the JDBCRelation node.
Before the fix,
== Physical Plan ==
*Scan JDBCRelation(TEST.PEOPLE) [NAME#1896,THEID#1897] ReadSchema: struct<NAME:string,THEID:int>

After the fix,
== Physical Plan ==
*Scan JDBCRelation(TEST.PEOPLE) [numPartitions=3] [NAME#1896,THEID#1897] ReadSchema: struct<NAME:string,THEID:int>

How was this patch tested?
Added the verification logics on all the test cases for JDBC concurrent fetching.

Test build #68981 has started for PR 15975 at commit bcc86c0.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68981/
Test FAILed.

Hi, @gatorsmile .
Can we can add a testcase for writing partition here? (According to the PR title, it's beyond of the scope.)

Sure, will add the test cases for the write path. @dongjoon-hyun

The test cases of the write path will be added after https://github.com/apache/spark/pull/15966 is merged.

Test build #69114 has started for PR 15975 at commit 5c5b3ca.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69114/
Test FAILed.

retest this please

Test build #69139 has started for PR 15975 at commit 5c5b3ca.

Test build #69139 has finished for PR 15975 at commit 5c5b3ca.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69139/
Test FAILed.

Merged build finished. Test FAILed.

@gatorsmile did you update this?

Will update it tonight.

@dongjoon-hyun Will not add test cases for the write path in this PR, because it requires code changes on the source codes.

Test build #69180 has started for PR 15975 at commit 1b0caea.

@gatorsmile NP. Thank you for informing that.

Test build #69180 has finished for PR 15975 at commit 1b0caea.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69180/
Test PASSed.

Any more comment? : )
Also cc @cloud-fan @hvanhovell

LGTM except https://github.com/apache/spark/pull/15975/files#r89722356, what's the status of it?

Test build #69253 has started for PR 15975 at commit c29199c.

Test build #69253 has finished for PR 15975 at commit c29199c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69253/
Test PASSed.

retest this please

Test build #69392 has started for PR 15975 at commit 404aa22.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69392/
Test FAILed.

Merged build finished. Test FAILed.

Test build #69430 has started for PR 15975 at commit 728c103.

Test build #69430 has finished for PR 15975 at commit 728c103.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69430/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #69444 has started for PR 15975 at commit 728c103.

Test build #69444 has finished for PR 15975 at commit 728c103.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69444/
Test PASSed.

Merged build finished. Test PASSed.

thanks, merging to master!
Since https://github.com/apache/spark/pull/15868 is not backported to 2.1, this PR conflicts with 2.1, @gatorsmile can you send a backport PR? thanks.

Sure, will do it soon.


[Feature Request] httpserver测试

Checklist

[X] I searched exising issues and no one else requests similar feature.
[X] I think that 25%+ users are positive towards this feature.

Describe the feature
https://github.com/Konloch/HTTPdLib/blob/main/src/test/java/com/konloch/TestHTTPServer.java
Additional context
No response

Hello @unknowIfGuestInDream. This issue is marked as deprecated and closed.


⚠ Jenkins Plugins Artifactory has degraded performance

In 8014035, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1339 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 41b8f14 after 12 minutes.


When parameter -N is used, the file modification time can't be set after downloading.

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
I'm using a Windows version of yt-dlp and found that,

If I use default options to download a video (eg. https://www.youtube.com/watch?v=JJG_Qu41IQw ), the Modification Time of the file should be the uploading time, like this:

But if I use "-N [x]" to use multiple threads to download the video, the Modification Time won't be set to the uploading time, like this:

Some other information for your reference:

When I use "--no-mtime" and other in default, the Modification Time won't be reset. This function works well.
When I use "-N [x]" and "--mtime", this issue can still be reproduced.
When I use "--downloader aria2c" and "--mtime", this issue can still be reproduced.

Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
C:\Users\zc169\Desktop>yt-dlp -vU --proxy http://<IP_ADDRESS>:7890 -f 137+140 "https://www.youtube.com/watch?v=JJG_Qu41IQw" -N 16
[debug] Command-line config: ['-vU', '--proxy', 'http://<IP_ADDRESS>:7890', '-f', '137+140', 'https://www.youtube.com/watch?v=JJG_Qu41IQw', '-N', '16']
[debug] Encodings: locale cp936, fs utf-8, pref cp936, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2023-03-05-git-912ac82a3c-full_build-www.gyan.dev (setts), ffprobe 2023-03-05-git-912ac82a3c-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4
[debug] Proxy map: {'http': 'http://<IP_ADDRESS>:7890', 'https': 'http://<IP_ADDRESS>:7890'}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>Current Build Hash: 5590c57bd0433ed239a2deaaf92e2ad6f37fe50f53664c821575cafe106a9421
yt-dlp is up to date<EMAIL_ADDRESS>[youtube] Extracting URL: https://www.youtube.com/watch?v=JJG_Qu41IQw
[youtube] JJG_Qu41IQw: Downloading webpage
[youtube] JJG_Qu41IQw: Downloading android player API JSON
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[info] JJG_Qu41IQw: Downloading 1 format(s): 137+140
[debug] Invoking dashsegments downloader on "https://rr2---sn-oguelnze.googlevideo.com/videoplayback?expire=1683321100&ei=rBxVZIztDoWN1d8PqJKlyAg&ip=<IP_ADDRESS>&id=o-AD7Pi-Ck9ofFaKMgfdbMLj1cmIZCTg782HfEtRMq1Ecq&itag=137&source=youtube&requiressl=yes&mh=Ty&mm=31%2C29&mn=sn-oguelnze%2Csn-oguesn6d&ms=au%2Crdu&mv=m&mvi=2&pl=21&initcwndbps=112500&spc=qEK7B9kr9iF2i2DtHu0316J6pilfClM&vprv=1&svpuc=1&mime=video%2Fmp4&gir=yes&clen=14051172&dur=31.080&lmt=1521307590513865&mt=1683299119&fvip=1&keepalive=yes&fexp=24007246&c=ANDROID&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRQIgTZOPCN5lCRDX5Ipv7vc_nFZXTJUIN6jLggZoaoDyEiECIQDQxQz_sGNlxDisGqK28zWWlS_dSaeBRuZoh5HM4sj-bA%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRgIhALEg9YZ86GEPvoc5owLfq3MQsTTQi1cVxywjzk_TZgzTAiEAi9whk0UOdXZu-WNWT51NMwn2I50A3n7XaUT1jXsBPuM%3D"
[dashsegments] Total fragments: 2
[download] Destination: Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f137.mp4
[debug] File locking is not supported. Proceeding without locking
WARNING: The download speed shown is only of one thread. This is a known issue
[download] 100% of   13.40MiB in 00:00:01 at 8.07MiB/s
[debug] Invoking dashsegments downloader on "https://rr2---sn-oguelnze.googlevideo.com/videoplayback?expire=1683321100&ei=rBxVZIztDoWN1d8PqJKlyAg&ip=<IP_ADDRESS>&id=o-AD7Pi-Ck9ofFaKMgfdbMLj1cmIZCTg782HfEtRMq1Ecq&itag=140&source=youtube&requiressl=yes&mh=Ty&mm=31%2C29&mn=sn-oguelnze%2Csn-oguesn6d&ms=au%2Crdu&mv=m&mvi=2&pl=21&initcwndbps=112500&spc=qEK7B9kr9iF2i2DtHu0316J6pilfClM&vprv=1&svpuc=1&mime=audio%2Fmp4&gir=yes&clen=495272&dur=31.137&lmt=1521307522919898&mt=1683299119&fvip=1&keepalive=yes&fexp=24007246&c=ANDROID&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRAIgZ3KMPjatyasmzDjgdOgwK0cdGQG78gxwLK8TxG5N-B8CIGBWyLOFMw6df6ny6rg2WqE44TJLucYtoG1uhSua5dMP&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRgIhALEg9YZ86GEPvoc5owLfq3MQsTTQi1cVxywjzk_TZgzTAiEAi9whk0UOdXZu-WNWT51NMwn2I50A3n7XaUT1jXsBPuM%3D"
[dashsegments] Total fragments: 1
[download] Destination: Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f140.m4a
WARNING: The download speed shown is only of one thread. This is a known issue
[download] 100% of  483.66KiB in 00:00:00 at 569.82KiB/s
[Merger] Merging formats into "Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f137.mp4" -i "file:Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f140.m4a" -c copy -map "0:v:0" -map "1:a:0" -movflags "+faststart" "file:Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].temp.mp4"
Deleting original file Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f140.m4a (pass -k to keep)
Deleting original file Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f137.mp4 (pass -k to keep)

C:\Users\zc169\Desktop>yt-dlp -vU --proxy http://<IP_ADDRESS>:7890 -f 137+140 "https://www.youtube.com/watch?v=JJG_Qu41IQw"
[debug] Command-line config: ['-vU', '--proxy', 'http://<IP_ADDRESS>:7890', '-f', '137+140', 'https://www.youtube.com/watch?v=JJG_Qu41IQw']
[debug] Encodings: locale cp936, fs utf-8, pref cp936, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2023-03-05-git-912ac82a3c-full_build-www.gyan.dev (setts), ffprobe 2023-03-05-git-912ac82a3c-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4
[debug] Proxy map: {'http': 'http://<IP_ADDRESS>:7890', 'https': 'http://<IP_ADDRESS>:7890'}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>Current Build Hash: 5590c57bd0433ed239a2deaaf92e2ad6f37fe50f53664c821575cafe106a9421
yt-dlp is up to date<EMAIL_ADDRESS>[youtube] Extracting URL: https://www.youtube.com/watch?v=JJG_Qu41IQw
[youtube] JJG_Qu41IQw: Downloading webpage
[youtube] JJG_Qu41IQw: Downloading android player API JSON
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[info] JJG_Qu41IQw: Downloading 1 format(s): 137+140
[debug] Invoking dashsegments downloader on "https://rr2---sn-oguelnze.googlevideo.com/videoplayback?expire=1683321176&ei=-BxVZOKVFrKV1d8PjMSxsAk&ip=<IP_ADDRESS>&id=o-ANOf8aO-S23HMu6kcOkjHSHySJraLKWK-TNo06mJ2E2_&itag=137&source=youtube&requiressl=yes&mh=Ty&mm=31%2C29&mn=sn-oguelnze%2Csn-oguesn6d&ms=au%2Crdu&mv=m&mvi=2&pl=21&initcwndbps=132500&spc=qEK7B3RYJ5_rzg4DDmUVgR4Yq2Va5Jo&vprv=1&svpuc=1&mime=video%2Fmp4&gir=yes&clen=14051172&dur=31.080&lmt=1521307590513865&mt=1683299119&fvip=1&keepalive=yes&fexp=24007246&c=ANDROID&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRQIhAIubhdhGRac7sYD_r3USuSVEiMsdXOqFJuQuZKbo7Af2AiAzFhLIq1tEppB-VYj9RetXsOchlhBiFZrZLLBqCDEexw%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRgIhAL9nibr4IdDkE5mFjY05RNSeyuMTcwLROz_lpuo8LEnmAiEA1vx5Rf-En5DJWSB9JoBKuX0RSN1t9cxERAC35ixgBJc%3D"
[dashsegments] Total fragments: 2
[download] Destination: Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f137.mp4
[debug] File locking is not supported. Proceeding without locking
[download] 100% of   13.40MiB in 00:00:03 at 4.35MiB/s
[debug] Invoking dashsegments downloader on "https://rr2---sn-oguelnze.googlevideo.com/videoplayback?expire=1683321176&ei=-BxVZOKVFrKV1d8PjMSxsAk&ip=<IP_ADDRESS>&id=o-ANOf8aO-S23HMu6kcOkjHSHySJraLKWK-TNo06mJ2E2_&itag=140&source=youtube&requiressl=yes&mh=Ty&mm=31%2C29&mn=sn-oguelnze%2Csn-oguesn6d&ms=au%2Crdu&mv=m&mvi=2&pl=21&initcwndbps=132500&spc=qEK7B3RYJ5_rzg4DDmUVgR4Yq2Va5Jo&vprv=1&svpuc=1&mime=audio%2Fmp4&gir=yes&clen=495272&dur=31.137&lmt=1521307522919898&mt=1683299119&fvip=1&keepalive=yes&fexp=24007246&c=ANDROID&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRQIhAOjPnt2MY6ZeEuwxihobatsUCpISvQebnEwsAWMhukY-AiA6I195eQjhmf_r6FDuFWhuUuBbSo9FEgwQVxCVUMcQ-Q%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRgIhAL9nibr4IdDkE5mFjY05RNSeyuMTcwLROz_lpuo8LEnmAiEA1vx5Rf-En5DJWSB9JoBKuX0RSN1t9cxERAC35ixgBJc%3D"
[dashsegments] Total fragments: 1
[download] Destination: Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f140.m4a
[download] 100% of  483.66KiB in 00:00:00 at 487.21KiB/s
[Merger] Merging formats into "Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f137.mp4" -i "file:Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f140.m4a" -c copy -map "0:v:0" -map "1:a:0" -movflags "+faststart" "file:Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].temp.mp4"
Deleting original file Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f140.m4a (pass -k to keep)
Deleting original file Queen Elizabeth II Officially Opens The London 2012 Olympics - Opening Ceremony [JJG_Qu41IQw].f137.mp4 (pass -k to keep)

Duplicate of #5522
Related #3224


infer will pop error in two situations, one is pass “null”  parameter to a method, but sometimes, developer did write different logic for null in the method so can infer ignore such error? I will give two code samples for this, looking forward for the reply...

sample 1:
 object jsonArray last assigned on line 169 could be null and is dereferenced by call to getAlphabetList(...) at line 170
  168. String key = iterator.next();
  169. JSONArrayPoxy jsonArray = alphabetJson.getJSONArrayOrNull(key);
  170. > ArrayList alphabetValueList = getAlphabetList(jsonArray);
alphabetJson.getJSONArrayOrNull code is like this below
private ArrayList getAlphabetList(JSONArrayPoxy jsonArray) {
	ArrayList list = new ArrayList();
	if (jsonArray != null && jsonArray.length() > 0) {
		for (int i = 0, len = jsonArray.length(); i < len; i++) {
			try {
so it already took actions for the situation (jsonArray==null), can infer know this?
sample 2
Class A{
Util utils=new Util();
utils.createAccount(null);
}
—— developer pass null directly to the method,  but utils.createAccount has the same judge for null paramter in the Class file.So can infer do something like depth first search? we can define the depths

Can you give a complete trace of the error using inferTraceBugs? Infer should not report if null is handled correctly by the method.

You mean you want the whole log by using infer --trace-error gradle assembleDebug?

AndroidJD-Lib/src/com/jingdong/common/entity/FilterBrand.java:170: error: NULL_DEREFERENCE
object jsonArray last assigned on line 169 could be null and is dereferenced by call to getAlphabetList(...) at line 170

  168.   				String key = iterator.next();
  169.   				JSONArrayPoxy jsonArray = alphabetJson.getJSONArrayOrNull(key);
  170. > 				ArrayList<BrandValueModel> alphabetValueList = getAlphabetList(jsonArray);
  171.   				if (alphabetValueList != null && alphabetValueList.size() > 0) {
  172.   					alphabetKeys.add(key);

And getAlphabetList is defined as below
private ArrayList<BrandValueModel> getAlphabetList(JSONArrayPoxy jsonArray) {
    ArrayList<BrandValueModel> list = new ArrayList<BrandValueModel>();
	if (jsonArray != null && jsonArray.length() > 0) {
		for (int i = 0, len = jsonArray.length(); i < len; i++) {
                    ...
                }
         } // end of if
         return list
} // end of func define

@carozuoP I mean the output of inferTraceBugs --max-level max when you select the bug where infer seems to be wrong. inferTraceBugs is an executable that ships with infer.


Vile Toxins

Please add an option for the vile toxins more multiplier on hits:

Skills deal 5 % more damage with hits for each poison on the enemy (up to 6-9).

This could be a part of the configuration panel, where we currently state weather the enemy is "chilled, ignited, covered in ash, ...". Could be an option like "Does the enemy have poison stacks" that lets us specify the number of poison stacks. I feel the gem will give a lot more damage to some builds, as soon as this is considered in the calculation.
Thanks!

I do want to add support for this, but unfortunately the limit makes it a bit trickier to implement than would otherwise be the case. But I'll take another look at it now, since you asked nicely...

Ok, I've found a reasonably elegant solution for this; it'll be in the next update.

Awesome. Many many thanks!


Try catch exception

Original issue: https://github.com/mapbox/tippecanoe/issues/817
Adding a try/catch block to catch exceptions when decoding so that an error message is printed detailing which tile caused the exception

Thanks!


Hash file path to generate diff IDs

Fix #820
Also fixed the issue where filenames couldn't contain special characters.


Figure out how middleware might work. Global/scoped

"Middleware" would be awesome, to perform tasks such as validation on incoming messages.
How it could be implemented is tricksy. The most probable plan is to rename remit.Event.Skip to remit.Event.Next and use that to skip the current function and/or move to the next middleware function.
Then, middleware could be created like so:
func middleware(event remit.Event) {
        event.Data["bar"] = true
        event.Next <- true
}

func handler(event remit.Event) {
        if event.Data["bar"] {
                event.Success <- true
        } else {
                event.Failure <- true
        }
}

endpoint := remitSession.Endpoint("foo")
endpoint.OnData(middleware, handler)

This does also raise the question of whether we need channels for Success or Failure at all; they can only be invoked once, so... is it even worth it? We could just move back to functions?

8953583eec352e27e6e5a9419b73feb00d357a24 helps with this a little bit. We have middleware now, but no global middleware (that would affect all data handlers).

Will close this for now and deal with global middleware in another issue.


chore: release 1.1.3

:robot: I have created a release *beep* *boop*
1.1.3 (2019-07-26)
Bug Fixes

deps: update dependency @google-cloud/paginator to v2 (#238) (42c35d2)

This PR was generated with Release Please.

Release is at https://github.com/googleapis/nodejs-resource/releases/tag/v1.1.3

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


Write draft new TermInfo queries

https://github.com/VirtualFlyBrain/VFB_neo4j/blob/master/doc/v2_TermInfo_queries.md


Add GNSS hardware and geometry

ToDos:

[x] add tests
[x] fix pipeline
[x] go back to GeoPoint not GeoPose
[x] everything included that we liked in other implementations?
[x] is current_geo_reference a good name?
[x] fix test with 45, 179 degrees error (test_pose_cartesian)
[x] Add noise to simulated lat, lon?

@falkoschindler, @codingpaula and @pascalzauberzeug I'm still not convinced that passing the reference as a parameter is the right design decision. If you look at https://github.com/zauberzeug/field_friend/pull/231 the code becomes quite more cluttered and complicated. I really think having the reference globally available like we do with frames would be much better. Parameter passing would only be necessary if there are multiple different reference points to be used in parallel. And that is not something we need to do, right?

@rodja The old field_friend implementation was easy to use, but wasn't easy to change and had problems when imported in the wrong way.
This implementation is a hassle in the app code, yes.
Multiple references may not be needed at the same time, but at least the reference should be easily changeable.
Claude.ai also suggested doing it the same way as with frames and I think that keeps the best of both worlds.
Something like this.
# geo_registry.py
from typing import TYPE_CHECKING

if TYPE_CHECKING:
    from .geo_reference import GeoReference

_global_reference: dict[str, 'GeoReference'] = {}  # Empty dict, will be initialized later

def get_reference(key: str = 'default') -> 'GeoReference':
    """Get the global geo reference."""
    return _global_reference[key]

def set_reference(reference: 'GeoReference', key: str = 'default') -> None:
    """Set the global geo reference."""
    _global_reference[key] = reference

That way you can initialize a default reference for the robot, but also can set an extra reference for a special area, which could make local coordinates easier to work with.

Multiple references may not be needed at the same time, but at least the reference should be easily changeable.

What do you mean by "easily changeable, @pascalzauberzeug? Code plasticity, eg. a changeable architecture? Or update-able variable at runtime? For what scenarios would we need the latter? I think it is fine to restart RoSys if the reference point changes.

@falkoschindler @codingpaula I think it's done now and can be tested with this script:
from nicegui import ui

import rosys
from rosys.geometry import GeoPoint, GeoReference
from rosys.hardware import GnssSimulation, WheelsSimulation

def main():
    wheels = WheelsSimulation()
    GeoReference.update(GeoReference(GeoPoint.from_degrees(lat=52, lon=7)))
    gnss = GnssSimulation(wheels=wheels)
    with ui.row():
        with ui.column():
            gnss.developer_ui()

    ui.button('Set Reference', on_click=lambda: GeoReference.update(GeoReference(gnss.last_measurement.pose.point)))
    ui.label().bind_text_from(GeoReference.current, 'origin', lambda p: f'Reference: {p}')

rosys.on_startup(main)
ui.run(title='RoSys')

First I tried to make current a property and save the reference in _current, but you can't chain @classmethod and @property anymore. The alternative, a classmethod named get_current or something, didn't look as smooth.
Sadly, I had to remove the MissingGeoReferenceError, because when accessing the reference directly there's no clean way to raise it, I think.

Tested on our robot, will merge now


upgrade: Skip the device which only has the same label name

- when upgrading, we need find the related label name and
  upgrade with it. If we have many devices have the same
  label name, it would cause failure. To avoid this case,
  we need add more checking about the target disk should
  be the active cOS disk.

Fixes  #348
Signed-off-by: Vicente Cheng<EMAIL_ADDRESS>

closing in favour of https://github.com/rancher/elemental-cli/pull/350


Update to latest master

I reset to latest upstream master: https://github.com/bors-ng/bors-ng/commit/c04c58d9d05e874abaf679fd5d9087742a12b444. Then I merged our existing master to keep our changes.
It looks like 3f6c7cb was also merged upstream in bors-ng/bors-ng#862, so that is no longer needed.
There's no release notes, but here's the diff: https://github.com/bors-ng/bors-ng/compare/ef1cc41227a5e404928fdd7e71e260eae1312f43...c04c58d
Highlights include:

bors-ng/bors-ng#919 should fix the Github deprecated API issue
bors-ng/bors-ng#888 requires SSL, but we are already using it
bors-ng/bors-ng#928 adds Co-Authored By to the squash commit message
bors-ng/bors-ng#929 improves author naming

@Inglorion-G a rollback to the current version we have. It's all on Heroku so it's pretty easy.


Removing duplicate code

Hi, thanks for the fun tutorial!
I found a duplicate in the sample code, so I created a Pull Request to remove one of them.
https://github.com/MicrosoftDocs/mixed-reality/blob/076ca5bb73ac776c963d73cbffc19c1b5938e4b5/mixed-reality-docs/mr-dev-docs/develop/javascript/tutorials/babylonjs-webxr-piano/keyboard-model-02.md?plain=1#L375-L376
VS.
https://github.com/MicrosoftDocs/mixed-reality/blob/076ca5bb73ac776c963d73cbffc19c1b5938e4b5/mixed-reality-docs/mr-dev-docs/develop/javascript/tutorials/babylonjs-webxr-piano/keyboard-model-02.md?plain=1#L393-L394

@katsuhisa91 : Thanks for your contribution! The author(s) have been notified to review your proposed change. @JING1201


Prepare release r1.1

What type of PR is this?
Add one of the following kinds:

subproject management

What this PR does / why we need it:
Prepare the release r1.1:

[x] Update CHANGELOG.med
[x] Update README.md
[x] Set versions in quality-on-demand and qos-profiles
[x] Set version in qos-provisioning (check all "wip", including event version)
[x] Update API Readiness Checklists

Which issue(s) this PR fixes:

Fixes #334
Special notes for reviewers:
Still in draft mode ... please review the initial content within CHANGELOG.md

@RandyLevensalor @jlurien have a look on the r1.1 section in CHANGELOG.md.

Release PR is almost complete ... just waiting for the merge of #299 and the ability to set the version in the new API qos-provisioning to 0.1.0-rc.1

Replaced all "wip" in qod-provisioning.yaml:

in version and server field according to guidelines
in org.camaraproject.qod-provisioning.vwip.status-changed to org.camaraproject.qod-provisioning.v0.status-changed.

There is no specific guideline for initial API versions
The event version should be decoupled from the API version (as the API can have breaking changes, but keep the event structure stable) ... so if the event structure will change with a later initial API version we can still then use another number.
BTW: I would not reset to wip as long as there is no breaking change to the event structure within a PR

in https://api.example.com/qod-provisioning/v0.1/device-qos/... set to the current one, but as it is only an example, wouldn't matter too much if we miss this one going forward

@camaraproject/quality-on-demand_maintainers @camaraproject/release-management_maintainers
The release PR for r1.1 is now complete and ready for review.
Note: #325 has to be merged first before this PR can be merged and the release created.


Create Data Quality Dashboard

Create new tab - Data Quality

This tab should include the following Quality Test:

Freshness Anomalies
Volume Anomalies
Schema Changes
Assertion Tests
Column Values Anomalies

ODD needs to show the count of Quality Test Runs with statuses:

Success
Failed
Running
Skipped
Broken
Aborted
Unknown

implemented in https://github.com/opendatadiscovery/odd-platform/pull/1502


⚠ Bofrost.at has degraded performance

In 9125b3d, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1372 ms

Resolved: Bofrost.at performance has improved in 8d7273c.


failed to resolve revision HEAD

Bossman command are throwing the below error:

There are no problems with the git command because all the git command are working fine.

Hi @fsipa ,
Thanks for this. Could you please share the output of git status?
It looks like you may be running into #9 , which typically occurs when a build system checks out a specific commit or tag as opposed to a branch. I would appreciate if you could help me confirm this.

@ynohat here the output of git status

I assume that i am not running into detached HEAD. I have just clone the git repositery and try to run the "bossman status" from the master branch

@ynohat yes the output from bossman status give also the same error

@fsipa sorry for the confusion. The error you are showing is the output of bossman commands. I am asking for the output of the git status command please.

Ah ok. The confusion comes from me, sorry. Here the output of git status and bossman status

Thanks a lot. Can you please share the output of
python3 -m pip show bossman

and
bossman --verbosity=DEBUG status

It would also be helpful if you could share details about how this occurred. Did you recently change workstations and are reinstalling? Was it an upgrade? Any change at all?
Thanks a lot for helping me troubleshoot this.

@ynohat here the commands output:

I switch for 6 weeks from a Windows workingstation to Mac M1. So the setup went well.

OK very clear, thank you.
Can you please try upgrading bossman to the latest version, which is 0.42.0?
python3 -m pip install --upgrade bossman

@ynohat

i have actually the latest version(0.42.0) on my machine. Thanks

OK @fsipa, thanks for the update, do you still get the error though?

I just released v0.42.1 which adds more detailed logs for when the error condition you are experiencing occurs.
If you are still facing this, please upgrade and share the logs again.
bossman --verbosity=DEBUG status

@ynohat unfortunately the error is still there. I upgraded to the new version v0.42.1 and run the bossman status again

@fsipa thanks for your patience with this; I'm surprised by the output, which does not contain the extra debug information I was expecting.
Could you please share the output of
which bossman

The intent is to check that the bossman you are executing is actually the one in /Users/fsi/Library/Python/3.9/bin/bossman which you just upgraded to 0.42.1.
If it is in a system wide location, then you should execute sudo python3 -m pip uninstall bossman.
Then
echo $PATH

To verify that you can /Users/fsi/Library/Python/3.9/bin/ is searched for executables, otherwise the command won't be found.
Thanks again for your patience and help debugging this.

@ynohat thank you for the help
The output of the "which bossman" command is empty. Very strange.
I executed also the other command "echo $PATH"

OK, let's try this command:
PATH="/Users/fsi/Library/Python/3.9/bin/:$PATH" bossman status

Here the output

sorry, with --verbosity=DEBUG please

@ynohat  here it is

I think I've got it.
I believe you have maybe retrieved your bashrc file from your WSL env on windows and it had an alias for executing bossman in docker, this may be why you have the Popen cwd=/work.
This would also explain why which bossman returns no output, because bossman is not actually resolving to the executable, but in fact to the bossman alias.
If this is the case, you should have an alias bossman="docker run ..." command in one of your init files (e.g; ~/.bashrc).
Could you please check?

@ynohat
I already have an alias command in my bash file.
alias bossman='docker run -it --rm --platform linux/amd64 --name=akamai-bossman -e TERM=xterm-256color -v ~/.ssh/id_rsa:/home/bossman/.ssh/id_rsa:ro -v $PWD:/work -v ~/.edgerc:/home/bossman/.edgerc ynohat/bossman'
I have tried to remove this alias command and add it again, however the output of debug command still shows Popen cwd=/work

Just in case: When you remove the alias you need to
Message ID: @.***>
source ~/.bahrc
Or re-open a new terminal, for the change to take effect.

Hi @ynohat
i have tried it. But unfortunately it still not working.

Hi @fsipa you really need to remove the alias from your .zshrc, it is not working and is causing our troubles.
Once removed, you should
source ~/.zshrc

And try again

Hello @ynohat. Thank you for the support.
I removed the alias from the .zshrc and it look now somehow different...

OK, there is likely a .bossmancache.db file in your project folder, copied over from the windows install? Please delete that.

Unfortunately i don't have this file .bossmancache.db on my project folder, I have this instead .bossmancache

Right, that's the one; please delete it

I'm happy to know you folks are still happy users! Any time.


Add hyphen to clarify the intent

Add hyphen between non and public (non-public) to clarify the meaning, and avoid confusion.

I signed it!
On Sat, May 13, 2017, 8:55 PM googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the
company's name.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/continuous-deployment-on-kubernetes/pull/76#issuecomment-301255131,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFek0KNpBs0kD2J9aNX1QgKs_Jus4NGoks5r5cuCgaJpZM4NaGjX
.


Hotfix/issue 301 integration

This change is

Current coverage is 56.33% (diff: 69.41%)

Merging #303 into hotfix/integration will decrease coverage by 0.24%

@@           hotfix/integration       #303   diff @@
====================================================
  Files                    1967       1969     +2
  Lines                  102191     102225    +34
  Methods                     0          0
  Messages                    0          0
  Branches                12799      12802     +3
====================================================
- Hits                    57826      57590   -236
- Misses                  41341      41609   +268
- Partials                 3024       3026     +2

Powered by Codecov. Last update 5efd4c3...13fd9f8


Add us-east region to the list of regions

Coverage remained the same at 79.977% when pulling c80d2e0094cc1e166cf13382c10b9c7ccb4e9f52 on us-east-master into ed79383b0b4c7cff9b18fc5e4880c05c2f4f59cc on master.


jenkins rich text parameter plugin

Repository URL
https://github.com/noneorone/rich-text-parameter-plugin
New Repository Name
rich-text-parameter-plugin
Description
I have develop a rich text parameter plugin based on KindEditor4.x js lib. This plugin can let us input some formatted string as text parameter to pass into work flow. It supplies base64 string for the final content with switch controll.
GitHub users to have commit permission
@noneorone
Jenkins project users to have release permission
noneorone
Issue tracker
Jira

Security audit, information and commands
The security team is auditing all the hosting requests, to ensure a better security by default.
This message informs you that the security team was notified about the request and will soon participate in this issue to assist.
The team is usually starting by a quick superficial audit and if it's not sufficient, they are planning a deeper audit.
Commands
Security team only:

/audit-ok => the audit is complete, the hosting can continue :tada:.
/audit-skip => the audit is not necessary, the hosting can continue :tada:.
/audit-required => the superficial audit was not sufficient, a deeper look is necessary :mag:.
/audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

/audit-review => the findings from the audits were corrected, this command will ping the security team to review the findings :eyes:.
	It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message)

/hosting re-check

account noneorone has logged into Artifactory for a long time, but Jenkins project users to have release permission check again. Is there some other configuration for me? thanks

/hosting re-check

Jenkins CERT will have a deeper look at this. Tracked internally as JENSEC-1887.

Thank you for your patience and kind sugguestions. code changes as below:

I have removed the unused view and local yui editor javascript library.
The reason why including kindeditor source code is that the functionality can be customized or extended as needed on the original basis.

Thanks sincerely for taking much time to audit this project :D

/audit-findings

/audit-review

@noneorone,
The XSS is not addressed.
If you have any questions regarding the vulnerability please feel free to ask.
Otherwise, we'll let you fix it and let us know when it's done.

/audit-findings

Ok, I've got it. Could you please explain and figure it out about the XSS of the project for detail? Thanks sincerely.

@noneorone What specifically are you asking? https://github.com/jenkins-infra/repository-permissions-updater/issues/2805#issuecomment-1248267313 includes step-by-step instructions how to exploit it. XSS being possible for users with Job/Configure permission is a big problem.

Okay, thank you, I will check and repair it carefully after I passed, and then reply to the update before replying to you.

/hosting re-check

Hey @noneorone,
are you still looking forward to fixing the open vulnerability?

@noneorone are you still considering hosting the plugin in the community?

I'll go ahead and close the hosting request, due to lack of response of @noneorone.
You are welcome to reopen the issue, once you have addressed the outstanding issues and the plugin is ready for a new review.


[Bug]: The SQL preview number inside the structure comparison in dark mode is black

ODC version
odc424
OB version

What happened?

What did you expect to happen?
The characters are white
How can we reproduce it (as minimally and precisely as possible)?

Anything else we need to know?
No response
Cloud
No response

pass


Error 401 and 403 redirections

Hi,
Getting back on #167, here is a scenario giving a weird behavior:

User is not logged in and visit some page requiring authentication on https://login.example.com (Authelia's web UI itself), say https://login.example.com/loggedin, for instance.
Then, the user gets a 401 error: perfectly normal. However, it also states “Please click here if you are not redirected in few seconds.”, with a link pointing to the default redirection page—not the original requested URI—, to where it gets redirected. If there is no default redirection in Authelia's config, there a is merely the 401 error, of course.

This exact same behavior occurs for a lack of autorisation, but with 403 instead of 401, when an authenticated user try to access a resource protected by Authelia (not necessarily on Authelia's web UI itself) and does not have sufficient rights.
In both cases, I guess this should be totally unrelated to the default redirection page: maybe both Authelia's 401 and 403 pages should include something like:

Please log in with an account having sufficient permissions to access this resource.
Click here if you are not redirected in few seconds.

where “here” refers to https://login.example.com/?redirect=originalRequestedURI (with automatic redirection, of course).
Hopefully, as already implemented in Authelia, unauthenticated users won't have to go through Authelia's 40x page (and thus wait for a couple of seconds) in case they try to access a resource that is protected by Authelia: only authenticated but unauthorized ones will land on such a page.

I think this feature is already handled at head.
The error 403 page comes with the following message:

You don't have enough privileges to access this resource.
Please click here if you are not redirected in few seconds.

And 401 with:

You are not authorized to access this resource.
Please click here if you are not redirected in few seconds.

The second sentence disappears if there is no link to redirect to. Can you please try and tell me if you see something missing from what you expect?

The "already logged in" page will be handled in #194 .

Hello @n4kre , can you please confirm everything is working fine at head?

I do confirm :)


Upgrade to Leaflet 1.9.3

This brings 4 years of improvements, including better mobile support and better accessibility.
The only issue I could find is the map theme control has smaller font. I couldn't figure out why. Let me know if this is a blocker.
Before

After

I'll close this for now in favor of upgrading to 1.7.1, the last version that doesn't mess up the font size: https://github.com/ParkingReformNetwork/parking-lot-map/pull/53
That still gets us benefits with no downside.


Multiple Page GUI

Multipage GUI as opposed to one python file, the functionality is split into their own python files

Reviewed, working with Unit tests


Add Chinese documents

Added a link to the Simplified Chinese version in README.md
Added README_zhCN.md

I apologize for an unnecessary change in the middle, and it seems that there is a problem with the commit message format.
I am a newcomer to GitHub and I am not very familiar with how to use git.
I have successfully run my code locally and I do not see any issues.
If there are any problems, please contact me, I am very happy to hear your opinions.


feat: add theme to idp

add a login theme when inviting a company
change the login theme when activating the company
Refs: CPLP-2205

@ntruchsess & @evegufy there is also a PR for CD


Documentation (swagger) not updated

Work, well play, i search for it then i found this project on the strapi market place :)
But ...

On my documentation (swagger) , i can see Data and Attributes object, possible to change swagger too ?
Thanks

I will need to check how swagger generates the sample response and see if it's feasible. Most likely it's something that needs to be accounted for on swagger plugins side.


solutions page - fix sizing of text

For mobile & desktop, can we drop the size of the H2 headers down to match the why zesty and headless cms pages. Example below - please lower the font size of the H2 and lower the font size of the description below.

Approved!


Create EDS principles for spacing and typography

Reason:
During the process of the creation of the foundations, we have discovered a series of principles that are helping us to follow a same direction and a common criteria when it comes to define a new decision or create a new item.
General objective:
Collect the common norms that have been helping us to build and make the decisions on the foundations.
Specific objectives:

To simplify future processes
To align in order of a single direction
To build a solid product.

Outcome:
A series of concepts (or phrases) that helps to reach the level needed in EDS products.

We need to add the two principles defined for spacing and typography to the Figma file to can close the task.

Wrap the documentation following the structure:

Cover
Principles
Typography
Density


Some packages could be moved to devDependencies?

Some packages could be moved to devDependencies
 "devDependencies": {
    "eslint": "8.39.0",
    "eslint-config-next": "13.3.1",
    "typescript": "5.0.4"
  }

If you want, you can assign me this very small change
Thanks in advance

@thomascouto thank you for reporting!
I did a quick review of the dependencies and created this PR to move sobre dependencies to devDependencies: https://github.com/datopian/portaljs/pull/848


[$500] Category - Narrow spacing between search field and "Recent" header

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Go to workspace chat
Open manual request page
Enter amount > Next
Click Show more > Category

Expected Result:
There will be adequate spacing between the search field and "Recent" header
Actual Result:
The spacing between search field and "Recent" is narrow
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01698b7535b20746f7
Upwork Job ID:<PHONE_NUMBER>609216512
Last Price Increase: 2024-02-27

We think that this bug might be related to #wave5
CC @dylanexpensify

Proposal
Please re-state the problem that we are trying to solve in this issue.
Category - Narrow spacing between search field and "Recent" header
What is the root cause of that problem?
Over here, there is no spacing
<Text style={[styles.ph5, styles.pv3]}>{translate('iou.categorySelection')}</Text>
            <CategoryPicker
                selectedCategory={transactionCategory}
                policyID={report.policyID}
                onSubmit={updateCategory}
            />

What changes do you think we should make in order to solve the problem?

We need to add spacing here
What alternative solutions did you explore? (Optional)
N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
Spacing between header and content is narrow.
What is the root cause of that problem?
There's no padding in View of renderSectionHeader.
What changes do you think we should make in order to solve the problem?
Add padding for the header in BaseSelectionList
const renderSectionHeader = ({ section }: { section: SectionListDataType<TItem> }) => {
        if (!section.title || isEmptyObject(section.data)) {
            return null;
        }

        return (
            <View style={[styles.optionsListSectionHeader, styles.justifyContentCenter, { paddingTop: 10 }]}>
                {/* 10 is just an example */}
                <Text style={[styles.ph4, styles.textLabelSupporting]}>{section.title}</Text>
            </View>
        );
    };

Updated Proposal

Definitely a bug, but doesn't need to block the deploy. Removing the label.

Proposal
Please re-state the problem that we are trying to solve in this issue.
List header needs more spacing.
What is the root cause of that problem?
The value of marginTop for optionsListSectionHeader is 8.
What changes do you think we should make in order to solve the problem?
Change the value on optionsListSectionHeader style for marginTop from 8 to 20.
optionsListSectionHeader: {
-   marginTop:  8,
+   marginTop:  20,
	marginBottom:  4,
},

What alternative solutions did you explore? (Optional)

Hi, Will take a look in my morning.

Reviewing now

This is straightforward styling issue with multiple possible ways to update the styling. So going ahead with the first proposal since all proposals having similar logic at different places.
@godofoutcasts94 's proposal here https://github.com/Expensify/App/issues/37328#issuecomment-1967295147 looks good and works well.
🎀 👀 🎀
C+ Reviewed

This is straightforward styling issue with multiple possible ways to update the styling. So going ahead with the first proposal since all proposals having similar logic at different places.
@godofoutcasts94 's proposal here #37328 (comment) looks good and works well.
🎀 👀 🎀 C+ Reviewed

Thanks for assigning it to me @abdulrahuman5196 ! Tomorrow PR will be ready for review for sure because actually I am out somewhere that's why

Adding @Expensify/design to confirm we want this change and to make it right if we do

Would this increase the spacing below every search in the app or just for categories?
I compared the spacing for a new chat, money request, and category, and they all look the same to me (these screenshots are from staging).

cc @Expensify/design (on purpose this time 😁) I feel like this might be a do nothing situation.

Yeah, I agree with you! I think we can just close this.
@lanitochka17  can you help us understand why you decided that this was a bug? Mostly want to understand if there was a test that failed or something else.

Hey @shawnborton and @dannymcclain. Is there anything that i would get if the issue is closed ? because I tried my level best and also put on some work and my proposal got selected as well.

If we close this out (which I anticipate that we will), then there would be no payments awarded since we deem this to not be a bug.

@lanitochka17 @puneetlath @aldo-expensify please feel encouraged to tag the design team earlier on in the triage process so we can make these determinations faster in the future - thanks!

No problem thanks for updating @shawnborton

Of course! We definitely appreciate your proposal though and hope to see you around on other issues in the repo 😄

Yes @dukenv0307 Thanks! And yes yesterday I was also not in front of my system. So I didn't see that but yes that's true what @dukenv0307 is stating that previously we were using OptionSelector in here - src/components/CategoryPicker.tsx, but now after this PR. We have added SelectorList. The margin-top used to be 20px but now its just 8px.
So, please have a look at it @shawnborton

I am pretty confused. What should I do? Should I raise a PR for review or not ? @abdulrahuman5196

I am pretty confused. What should I do? Should I raise a PR for review or not ? @abdulrahuman5196

@godofoutcasts94 PR shouldn't be raised until you have been assigned(If assigned after discussions)

I think the bug here is the space between the search input and the section header is less than before. In the past, we used OptionSelector, section header had margin-top 20px but now it's 8px when we use SelectionList.

I am not sure comparing it to previous view would be the right path. Anyways it would be design decision to maintain the current existing spacing or have more spacing. I was under the impression this was already design team reviewed since the bug as already a deployment blocker.

Okay @abdulrahuman5196 ! So I have to wait for the design team to come up with the idea or thing what they want then only we can proceed further right ?

Hey @shawnborton! Can you please have a look on this comment and let me know what needs to become done as @abdulrahuman5196 initally assigned me this issue but right I can't do anything about it. So please decide on this.

I guess we could add extra space below the search input, or we just do nothing and close this out. Curious what everyone else thinks.

No strong opinion, I'll go with what you think is best from a design point of view :P. if both options feel equivalent, I would close.

I guess we could add extra space below the search input, or we just do nothing and close this out. Curious what everyone else thinks.

So my proposal is doing the same @shawnborton but yes whatever you decide that will be fine.

I think we should close.

I'm happy to close this and have everyone focus on higher value bugs. That's my vote.


accept package path in 'gohack get'

$ gohack get -vcs github.com/rogpeppe/go-internal/modfile
module "github.com/rogpeppe/go-internal/modfile" does not appear to be in use
all modules failed; not replacing anything

The module is github.com/rogpeppe/go-internal. But the intent of the command was clear: I want to look at the package github.com/rogpeppe/go-internal/modfile. gohack get should accept a package path and start hacking on the containing module.

Somewhere in cmd/go there must be a method that maps import paths to their containing modules. But I can't find it. I'm happy to work on implementing this if anyone can point me to that.

@josharian,
go list -f '{{with .Module}}{{.Path}}{{end}}' github.com/rogpeppe/go-internal/modfile

will give you the module containing package github.com/rogpeppe/go-internal/modfile.


Can I continue training from a checkpoint?

It seems it can get the last checkpoint in train/llama.py. But the loss seems to start over again(at 1.6). It should be 0.2 at this checkpoint.
{'loss': 1.6927, 'learning_rate': 0.0003589922426773994, 'epoch': 24.06}
 38%|█████████████████████████████████████████████████████████████████████▌                                                                                | 1549/4096 [25:45<11:16:38,

or can I code like this in train/llama.py?
check_point="/output/checkpoint-1536"
trainer.train(resume_from_checkpoint=check_point)

sorry to bother you for those questions. I am new to LLM fitune. I hope I can get your answer.

Where does your checkpoint come from? If you start a fine-tune, checkpoints are created automatically and if you then interrupt the fine-tuning and start it again (with the same --output directory), training should be resumed from the latest checkpoint automatically.


feat(ModelTheory): lift of equivalences between direct limits, and direct limit of system of substructures

Define the equivalence between direct limits of isomorphic systems, and the equivalence between the direct limit of a system of substructures and the union of these substructures.
Co-authored-by: Aaron Anderson<EMAIL_ADDRESS>
Important additions:

In DirectLimit:

Defined Equiv_iSup, the isomorphism between a direct limit of a system of substructures and their union.
Defined equiv_lift, the equivalence between the direct limits of two isomorphic directed systems

Also added some results about limits, and simple simp lemmas.
This is some preparation work for  #9967.

bors r+


How to upload local file?

Electron version: 0.36.9
Operating system: Windows7

I use the electron to load my remote url.I modify the remote website, when function require is not undefined, i load the additional js file which can run in the electron enviroment. I want to upload local audio file to the server by absolute address, rather than using input control to select the file. I only can get the raw data by using readFile method of fs. But only file object can be as parameter for $.ajax.
How can i do? How can i upload the local file? thx.
main.js:
mainWindow.loadUrl('http://XXX.XXXX.COM/');

You can use a library like requestto send the file/stream from thefs` APIs to your server.
Here is a simple example from the README:
request('http://google.com/doodle.png').pipe(fs.createWriteStream('doodle.png'))

Closing this out.


[W.I.P] [gui][ImageStack] add clear option for the UrlList

Is that WIP? or ready to merge?

Ready to merge, I forgot to change title, my bad.


Set WM_CLASS and WM_NAME before mapping window

ICCCM <IP_ADDRESS> states that:

This property must be present when the window leaves the Withdrawn state and may be changed only while the window is in the Withdrawn state.

Previously, we would first map the window, and then set these properties, causing sadness for window managers (#167, tomaka/glutin#879). This patch changes that by setting the class and name attributes immediately after the window is created, and before it is mapped.
Fixes #167.

Thanks!


Deprecated package reference on Nuget (Rx-Linq)

Hi,
seems Obvs <IP_ADDRESS> (current version) on Nuget references Rx-Linq, which as far as I know is deprecated/unlisted and has been replaced by System.Reactive.Linq.
Any plans to update this here & on Nuget?
As for me, I'm getting exceptions when using both (e.g. reference the latest System.Reactive) as Obvs seems to fail finding/loading the old Rx DLLs, in spite of having assembly redirects in place. Haven't spent much time on the issue yet as I figured an Obvs upgrade to the latest Rx libraries probably makes more sense anyway?

Hello, yes you are correct, upgrading Obvs to the latest System.Reactive libraries would make sense. I had put any upgrading on hold while they sorted out .Net core, as I assumed the next version of Obvs would be based on .Net core, but haven't had time to pursue it. You can see the issue open here https://github.com/inter8ection/Obvs/issues/25
There are currently no plans to upgrade, but I look into it.

Fixed in https://github.com/inter8ection/Obvs/pull/27


Error in pytest

Hi, when I installed the molgrid, I run the pytest .. as you said in https://github.com/mattragoza/conda-molgrid. there are errors as follows:
pytest ..

.....
==============================
*** Open Babel Warning  in ReadMolecule
  WARNING: Problem interpreting the valence field of an atom
The valence field specifies a valence 3 that is
less than the observed explicit valence 4.
WARNING: Problem interpreting the valence field of an atom
The valence field specifies a valence 1 that is
less than the observed explicit valence 2.
WARNING: Problem interpreting the valence field of an atom
The valence field specifies a valence 3 that is
less than the observed explicit valence 5.
WARNING: Problem interpreting the valence field of an atom
The valence field specifies a valence 1 that is
less than the observed explicit valence 2.
WARNING: Problem interpreting the valence field of an atom
The valence field specifies a valence 1 that is
less than the observed explicit valence 2.
 To silence this warning, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
  Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
    a3d = np.arange(27).astype(np.float).reshape(3,3,-1)

test/test_numpy.py::test_numpy_conv
  /NAS/luohao/software/molgrid/libmolgrid/test/test_numpy.py:40: DeprecationWarning: `np.float` is a deprecated alias for the builtin `float`. To silence this warning, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
  Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
    a3d = np.arange(27).astype(np.float).reshape(3,3,-1)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================= short test summary info =============================
FAILED ../test/test_coordinateset.py::test_coordset_from_mol - assert 263424.0 =...
FAILED ../test/test_torch_cnn.py::test_train_torch_cnn - RuntimeError: CUDA erro...
============== 2 failed, 63 passed, 2 warnings in 220.38s (0:03:40) ===============

I don't know why the before !=after (os.getpid() returns the same value). CUDA also seems to have an error.
Thanks!

The test_coordinateset.py error is identifying a memory leak.  The amount of memory in use before and after the code should be the same.  If profiling is turned on, you might see this error.
The other error appears to be coming from pytorch.  What versions of operating system/pytorch/CUDA are you using?

If another user or program have operations on memory, can cause this error? Can I ignore this error?
my system/pytorch/CUDA are as follows:
CentOS Linux release 7.8.2003 (Core)
pytorch                   1.11.0
CUDA：
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2021 NVIDIA Corporation
Built on Mon_May__3_19:15:13_PDT_2021
Cuda compilation tools, release 11.3, V11.3.109
Build cuda_11.3.r11.3/compiler.29920130_0
Thanks!

You can probably ignore the error, unless you are seeing memory leakage in real world practice.

Hi, @dkoes when I run make install, there is a note at the end:
[ 29%] Built target libmolgrid_shared
[ 59%] Built target libmolgrid_static
[ 65%] Built target molgrid
[ 68%] Built target test_coordinateset_cpp
[ 71%] Built target test_grid_cpp
[ 75%] Built target test_grid_cu
[ 78%] Built target test_gridmaker_cpp
[ 81%] Built target test_gridmaker_cu
[ 84%] Built target test_gridinterp_cpp
[ 87%] Built target test_mgrid_cpp
[ 90%] Built target test_mgrid_cu
[ 93%] Built target test_quaternion_cpp
[ 96%] Built target test_transform_cpp
[100%] Built target test_transform_cu
Install the project...
-- Install configuration: "Release"
-- Installing: /home/lh/.local/lib/libmolgrid.so
-- Up-to-date: /home/lh/.local/lib/libmolgrid.a
-- Up-to-date: /home/lh/.local/include/libmolgrid/libmolgrid.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/grid.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/managed_grid.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/quaternion.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/transform.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/atom_typer.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/example.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/coordinateset.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/exampleref_providers.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/example_extractor.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/example_provider.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/example_dataset.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/grid_maker.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/grid_interpolater.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/coord_cache.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/common.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/grid_io.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/cartesian_grid.h
-- Up-to-date: /home/lh/.local/include/libmolgrid/config.h
Unknown option: -C
usage: git [--version] [--help] [-c name=value]
           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           <command> [<args>]
Cannot obtain version number from git.

I don't know how to solve it. Thanks!

I would guess you need to upgrade your version of git.


About petkit fresh element infiniti config

Hi Julio,
I opened this issue for petkit fresh element infiniti's support, below is my charles screenshot, if you need any help, please let me know!
Thanks for your work!

Hi,
please send the screenshot when activating the manual lock or the light mode.
tku
jubepue

Hi

Hi jubepue,
I refetch the data, please take a look and let me know if you have any other questions!

Hi,
A new beta is uploaded, please test it and tell me back.
https://github.com/jubepue/homebridge-petkit-pet-feeder/releases/tag/v2.3.2-beta.1
Regards
jubepue


Modified Color Code: Add color code and copy to clipboard

Description

Added display of hex RGB and HSL codes for chosen color.
On clicking on the color code, it is copied to the clipboard for further use.
Made some improvements in the styling of the page
Fixes #280

Screenshot

@aditi-singh-442 Thank you for your contribution. Looking forward to more such amazing contributions 🥂


Align LokiJS v1 and v2

Just to keep track with LokiJS1.
I will start again refactoring LokiJS for Version 2 - I hope to start this week.

I missed your last commit yesterday. :) I will merge this tonight.

Thanks Viatorus!


Fix version conflicts caused by PR#626

I encountered a similar dependency hell issue when bump Nerdbank.Streams from 2.6.81 to 2.8.46. (PR#626).
Hope this fix can help you.
Best regards,
sucrose

Closing as we are on v2.10.x of Nerdbank.Streams


Uncrustify PR Check Changes

Uncrustify PR Check Changes
Description
Put the uncrustify parsing in a log group
Print out a git diff of the changes if a file is incorrectly formatted so end user can see it
Test Steps
Run the CI-Checker GitHub Action
Working Run One, Working Run Two, Forced a failure on this run to show how it looks now
Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I like this change - should we add it to the github action in CI-CD-GitHub-Actions then swap this out for the action? I've been trying to push for uncrustify to have a single source of truth.


Make build-related scripts executable

The software cannot be built without making those files executable, so I did.

Closed because it was structured wrong


Document lifetime of temporaries in conditions of if and while-expr

Explain that temporaries created in the condition expression of an if or if/else expression are dropped immediately after the condition expression. Similar for while. See rust-lang/rust#12033

Thanks!


The file cannot be opened

(prediction.ipynb)The file cannot be opened

File was corrupted, should be fixed now


Error in retry of a failed run

resolution_fixed   |    by<EMAIL_ADDRESS>
Suites are configured to automatically retry on failure. This works ok for an MPI related failure right at the start.
However if the model runs a few days and writes the partial sum files the retry will fail because these partial sums are later than the restarted model time.

Issue migrated from trac:347 at 2024-01-31 18:32:39 +1100

<EMAIL_ADDRESS>commented

Not an issue for the Met Office because they write both restarts and partial sums every 10 days.

Removing them before retry should be ok as long as we only save monthly means from the UM, not seasonal means.

<EMAIL_ADDRESS>set resolution to fixed

<EMAIL_ADDRESS>changed status from assigned to closed

<EMAIL_ADDRESS>commented

Writing the partial sums to /jobfs gets around this problem because it's not persistent. It should also be more efficient than using /short for these files.
https://code.metoffice.gov.uk/trac/roses-u/changeset/106959/b/f/4/8/1/trunk.


English version of printer.cfg and macros

Hey,
as this is the english part of this tutorial, I've spend some time to translate everything from german to english. This is for X-Max 3 with proximity probe.
printer.zip
macros.zip
Jakub

Thank you for your efforts Jakub. I am currently working on the translation and some other changes


Langpack source and XLF update for April 2023 Release

This PR updates the langpack source files, as well as provide an update to the English strings (in advance for the next Langpack, this is done to reduce the number of localization commits in ADS)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.004%) to 41.687%

Files with Coverage Reduction
New Missed Lines
%

extensions/sql-bindings/src/common/azureFunctionsUtils.ts
1
80.65%

extensions/machine-learning/src/common/processService.ts
2
81.48%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.004%

Covered Lines:
30315

Relevant Lines:
67318

💛  - Coveralls


Not working on web

Hi, thanks for the package!
It seems that the package currently is not working on the web.
In the web console I get the following errors:
Refused to set unsafe header "cookie"
and
Refused to set unsafe header "user-agent"
The package itself throws the following error:
ChatGPT failed to refresh auth token: Exception: Failed to refresh access token, token in response is null

Our base project is https://github.com/transitive-bullshit/chatgpt-api and v2 published yesterday.

Pull requests are welcomed :)

[ERROR:flutter/runtime/dart_vm_initializer.cc(41)]
Unhandled Exception: Exception: ChatGPT failed to refresh auth token: Exception: Failed to refresh access token
#0      ChatGPTApi._refreshAccessToken (package:flutter_chatgpt_api/flutter_chatgpt_api.dart:152:7)

#1      ChatGPTApi.sendMessage (package:flutter_chatgpt_api/flutter_chatgpt_api.dart:50:25)

#2      _ChatScreenState._buildSubmit. (package:neural_ai/screens/chat.screen.dart:110:30)

@coskuncay Hi, thanks for this package.
Is there anything we can do to make this run on flutter web? Is there a limitation on the base project?


ATOM syntax incorrect: "CG0" is not a valid AutoDock type.

My ligand is prepared using meeko_0.5. When I dock the ligand, the error appears

This error i solved by using obabel.
Could you please guide me on whether there’s a way to restrict the ligand modes to 2 or 5, to save time?


How to select the platform version stv2 ?

There is some way to set the Platform Version Stv1 or Stv2 on the terraform code?
I need to upgrade my Stv1 to Stv2 but I don't want to recreate my resource.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 95445129-2409-6617-feb9-6fa4e123b69d
Version Independent ID: 82ef024c-abed-a030-4d29-16083acb108c
Content: Quickstart: Create an Azure API Management service using Terraform
Content Source: articles/api-management/quickstart-terraform.md
Service: api-management
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

@adrianolw
Thanks for your feedback! We will investigate and update as appropriate.

@adrianolw We have doc: Migrate an API Management instance hosted on the stv1 platform  to stv2 that helps in migrating from stv1 to stv2 via portal, Rest API and the scenario varies based on whether VNET-injected or not.
Regarding how to select stv2 in terraform, you can refer this discussion page which talks about the flow in deciding the compute.

Source: https://techcommunity.microsoft.com/t5/azure-paas-blog/compute-platform-versions-for-azure-api-management-service/ba-p/2836971
I would like to share that this repo is specifically for doc-related feedback/issues and if you have any other questions, suggest you post it in Microsoft Q&A and experts can help in answering them.
I hope this helps.

Thanks for the documentation, I will prepare a change to specify static IP address.
I think this is my problem.

@adrianolw Sure, will proceed to close this thread. Feel free to reach out if any questions.


fix linux compile

compilation on linux, because ssize_t not defined,
add an #include <sys/types.h> to fulfill the needed types

Build status:

Linux
Windows

Could you provide instructions for replicating the error/warning?
In general, LGTM.
@Acuadros95 S&M if you are ok