plugins/vsenv.py fails under linux

$ bob ls
An internal Exception has occured. This should not have happenend.
Please open an issue at https://github.com/BobBuildTool/bob with the following backtrace:
Bob version 0.18.2.dev30+g5e670dc.dirty
Traceback (most recent call last):
  File "/mnt/c/bob/pym/bob/scripts.py", line 147, in catchErrors
    ret = fun(*args, **kwargs)
  File "/mnt/c/bob/pym/bob/scripts.py", line 248, in cmd
    ret = cmd(args.args, bobRoot)
  File "/mnt/c/bob/pym/bob/scripts.py", line 54, in __ls
    doLS(*args, **kwargs)
  File "/mnt/c/bob/pym/bob/cmds/misc.py", line 104, in doLS
    for (stack, root) in packages.queryTreePath(args.package):
  File "/mnt/c/bob/pym/bob/pathspec.py", line 852, in queryTreePath
    (nodes, valid) = self.__query(path)
  File "/mnt/c/bob/pym/bob/pathspec.py", line 829, in __query
    root = self.__getGraphRoot()
  File "/mnt/c/bob/pym/bob/pathspec.py", line 781, in __getGraphRoot
    self.getRootPackage)
  File "/mnt/c/bob/pym/bob/pathspec.py", line 535, in init
    root = PkgGraphNode.__convertPackageToGraph(db, rootGenerator())
  File "/mnt/c/bob/pym/bob/pathspec.py", line 843, in getRootPackage
    self.__root = self.__generator()
  File "/mnt/c/bob/pym/bob/input.py", line 3725, in <lambda>
    lambda: self.__generatePackages(nameFormatter, env, cacheKey, sandboxEnabled))
  File "/mnt/c/bob/pym/bob/input.py", line 3707, in __generatePackages
    result = self.__rootRecipe.prepare(env, sandboxEnabled, states)[0]
  File "/mnt/c/bob/pym/bob/input.py", line 2465, in prepare
    thisDepTools, depStack)
  File "/mnt/c/bob/pym/bob/input.py", line 2465, in prepare
    thisDepTools, depStack)
  File "/mnt/c/bob/pym/bob/input.py", line 2653, in prepare
    for (name, tool) in self.__provideTools.items() }
  File "/mnt/c/bob/pym/bob/input.py", line 2653, in <dictcomp>
    for (name, tool) in self.__provideTools.items() }
  File "/mnt/c/bob/pym/bob/input.py", line 548, in prepare
    for k, v in self.environment.items() }
  File "/mnt/c/bob/pym/bob/input.py", line 548, in <dictcomp>
    for k, v in self.environment.items() }
  File "/mnt/c/bob/pym/bob/stringparser.py", line 511, in substitute
    return StringParser(self, self.funs, self.funArgs, nounset).parse(value)
  File "/mnt/c/bob/pym/bob/stringparser.py", line 50, in parse
    return self.getString()
  File "/mnt/c/bob/pym/bob/stringparser.py", line 125, in getString
    s.append(self.getCommand())
  File "/mnt/c/bob/pym/bob/stringparser.py", line 202, in getCommand
    return self.funs[cmd](words, env=self.env, **self.funArgs)
  File "layers/basement/plugins/vsenv.py", line 15, in vsvars2019
    vswargs = (os.path.join(os.environ["ProgramFiles(x86)"],
  File "/usr/lib/python3.6/os.py", line 669, in __getitem__
    raise KeyError(key) from None
KeyError: 'ProgramFiles(x86)'

Does this just fail for me? Why, this should also fail in the basement-crossplatform-tests?!
I guess the "(" and ")" are the problem for the os environment python stuff.
I "fixed" it by adding a KeyError-exception.

- if: !expr |
     "${BOB_HOST_PLATFORM}" == "msys" || "${BOB_HOST_PLATFORM}" == "win32"

solution! Okay, that is the reason, why this works for tests. should we catch the error in vsenv?

The error should certainly be catched. It reminds me that Bob should catch plugin exceptions and print a proper error message that the plugin is faulty too.


Removing universal build, make cross explicit

This was a test to see what the CI builds would do.


New Algorithm

Up until now, DerivableJS used a mark-and-sweep style algorithm to both propagate change and free unused memory.
This had a couple of minor performance implications, and one obscure-but-serious memory leak vulnerability (see #36).
This reimplementation of DerivableJS' core data structures removes the mark-and-sweep stuff, replacing it with a significantly simpler system inspired by Clojure's epochal STM.
The practical implications are:

atoms never ever store references to derivations. Only to reactors. This is ideal, and solves the memory management issue once and for all.
the time complexity of updating atoms is now linear in the number of dependent reactors rather than in the number of dependent (derivations + reactors), and should be much more performant due to cache locality goodness.
the cost of dereferencing derivables should be either similar or faster than before, but I'll have to do benchmarking to be sure of this.
smaller file size (.min.gz has gone from 4,330 bytes down to 3,718 bytes. Makes all the difference.)

The progress of this reimplementation is as follows:

[x] typescript prototype of epochal system to verify viability
[x] retrofit DJS with epochal system
[x] get all the unit tests passing
[x] trial epochal system in real-world projects already using DJS
[x] modernize code base (npm build scripts, es6 modules + rollup, CI)
[x] do white box testing. get 100% test coverage.
[x] check performance and rework if necessary
[ ] modify read-me to talk about push-pull as opposed to mark-and-sweep, like Agera
[ ] release

Sweet! Looking forward to replacing my workaround.

Changes Unknown when pulling d8ed9a567d9faceabb2bdd0009a04869f742a8f4 on new-algo into ** on master**.

Changes Unknown when pulling 878ccb59a3500d12c1a6cd1df2d9b89c8e4b1b06 on new-algo into ** on master**.

@liron00 I wonder if you'd be willing to test this on any of your projects? I managed to introduce a few sneaky bugs during this transition which only became apparent when testing on real projects.
I'm feeling confident that they're fixed now, and I've got 100% statement test coverage, but I'd still feel a lot better if your projects also work fine with the new stuff.
It's available on npm with the version tag beta7.

Sure I'll start using @beta7 and let you know how it goes.

Thanks :D

Quick update:
I did some preliminary benchmarking to find out how the new stuff compared to the old stuff, speed-wise. Turns out there was no improvement but, in fact, a slight worsening. I tried three or four approaches to bring it back up to speed, but none have been able to match DJS 0.12.1 - I've landed on using the fastest  of those approaches for now, which is not far away, but it would be nice to get that speed back at some point in the future.
The good news: DJS is still more than twice as fast as MobX! Although I'm not sure it would make much of a difference for ordinary workloads. So far I've been measuring the overhead of propagating changes to live reactors, which is normally dwarfed by the cost of computing new state and doing the side effects themselves.
Anyway I'm happy enough with the current state of things and will try to push forward with a release at the weekend.

New update,
I've largely re-written DJS yet again and now it is considerably faster than 0.12.x. I dumped the epochal verison tracking and replaced it with an obscenely simple system which sets up bi-directional relationships like before, but only for derivables which are touched by an active reactor. This means the bug in #36 is still fixed, but as a trade-off you don't get lazy caching goodness for derivables which are not used in reactions. I don't think anyone really dereferences derivables outside of reactions anyway, so not too much of a problem there.
I'm also introducing some breaking API changes for the 1.0.0-beta release coming up very soon. These are currently:

no more .reactor method.
no more whole-module withEquality function. but the .withEquality method remains

Also some new stuff in the works

[ ] benchmarking against mobx (in progress)
[ ] wrapPreviousState function.
[ ] .mReact method
[ ] a quick-and-dirty practical gitbook guide to using the library.

I've also gotten rid of the big discourse about state management that I was writing in the README before. I gave a talk in London with more or less the same content but a slightly different focus involving React, which went extremely well so I'm going to turn that into a blog post on futurice.com and link to it from the readme.

I would love to see a CQRS example in the mix. Just to give an idea of how to structure a larger application. I notice there's a redux-like example here: https://github.com/andreypopp/react-derivable#fluxredux-like-unidirectional-data-flow

@mruzekw What kind of thing do you have in mind? I see Redux as a lightweight instance of the CQRS pattern. Although admittedly it doesn't do much on the query side of things until coupled with other libraries.

Does the flux challenge you've written use CQRS/redux?

Neither, although the approach is very similar indeed. The main difference from Redux is that the actions are implicit so they're not serializable. The reducer pattern is more-or-less intact. Porting the code to redux should be super easy.

I'll just give that a look and maybe convert it to Redux as an exercise.

So close now! When will this land?

Not sure. I was planning to make nice new docs and a respectable-looking landing page before pushing out a 1.0.0 release. This was partly done, then summer happened and I got put on a very fulfilling project at work so my motivation to code on evenings and weekends has been waning.
However I've lately been learning the value of MVPs and thinking that it would be better to put out something more lean (docs-wise) to begin with at least. But still need to wait until I have some spare time at a weekend, which is looking like early October right now.

Can you shortly explain about breaking changes in feature release?  What sould be avoided in the current version?

The main breaking change is that the Reactor class and its associated API (Derivation#reactor) have gone away.
The top-level withEquality function was removed too.
Behaviour-wise, laziness is now only provided for 'active' derivations (which are upstream of an 'active' reactor). I might still change this back to the old behaviour (always lazy) before 1.0.0 is released if I can find a way to do it without impacting performance for active derivations.
I think everything else is the same.

I try to test 1.0.0-beta11, but catch strange bug: derive does not cache result, each get recalculate value again. It's some optimizations or bug?
        const a = atom({p: 1})

        const b = a.derive((p) => {
            console.log('test')
        })

        b.get() // "test"
        b.get() // error: "test" again

but I still would like to bring caching
back for all derivations somehow before it leaves beta.

Any idea how to achieve that? I'd be interested to work on a pull request.

@andreypopp The epochal system I started this PR with would work if kind-of superimposed over the current setup. That could end up being quite complex to implement and test, but it should add only a small amount of constant overhead. A PR would be super cool if you're feeling intrepid :)

How is the rewrite coming along? ☺

Oh gosh. Well the code is pretty tight (currently released as beta), but I
haven't had the extra-curricular moxie to finish off the docs and landing
page in recent months. I've got a big 5-week chunk of holiday coming up in
February; maybe that with replenish my OSS mana.
On 14 Dec 2016 8:14 am, "Oskar Börjesson"<EMAIL_ADDRESS>wrote:

How is the rewrite coming along? ☺
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ds300/derivablejs/pull/37#issuecomment-266960696, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABL1qTkIsixvfwaiZ7S97VvPVB2q0_Mvks5rH5dygaJpZM4IOY1p
.

Ill send you a mana potion for Christmas 🎅
On Wed, Dec 14, 2016, 10:10 David Sheldrick<EMAIL_ADDRESS>wrote:

Oh gosh. Well the code is pretty tight (currently released as beta), but I
haven't had the extra-curricular moxie to finish off the docs and landing
page in recent months. I've got a big 5-week chunk of holiday coming up in
February; maybe that with replenish my OSS mana.
On 14 Dec 2016 8:14 am, "Oskar Börjesson"<EMAIL_ADDRESS>wrote:

How is the rewrite coming along? ☺
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ds300/derivablejs/pull/37#issuecomment-266960696,
or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/ABL1qTkIsixvfwaiZ7S97VvPVB2q0_Mvks5rH5dygaJpZM4IOY1p
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ds300/derivablejs/pull/37#issuecomment-266981731, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPNfWDu5rMCD8MiAFj587g2wiRxpZx6ks5rH7KWgaJpZM4IOY1p
.

 I'm just gonna merge it into master and start doing feature and release branches.


Forward member updates from API to CRM

Backend CRM is not going away, so start handling it in the API

For whatever reason, I no longer seem to be able to review (even though I see 'Add your review' on the Conversation page)


docs-bug(COMPONENT): Provide a way to generate prebuild different combination of theme

Documentation Feedback
When looking at dist folder for M3 theme following themes are prebuilt

indigo-pink
deeppurple-amber
pink-bluegrey
purple-green
azure-blue
rose-red
cyan-orange
magenta-violet

provide a different way to build a different combination. For eg.

pink-indigo

Directly using
html {
  @include mat.theme((
    color: (
      primary: mat.$pink-palette,
      tertiary: mat.$indigo-palette,
      theme-type: light,
    ),
    typography: Roboto,
    density: 0
  ));
}

break ui on some older mobile browser due light-dark css function and using the css in angular json provides more compatibility.
Affected documentation page
https://material.angular.io/guide/theming

You can make your own combination of color palettes, see our Theming Guide for the full list of palettes and theming setup instructions.
Although are you saying you are encountering issues when doing so because of an older browser? Which browser and version are you using?


ES5 Issues

There is some issues with loading the ES5 modules that are provided by the published version of OrbitJS. Namely, the issue that I am immediately seeing is due to this line:
https://github.com/orbitjs/orbit/blob/master/packages/%40orbit/jsonapi/src/lib/request-settings.ts#L13
It seems that the published es5 version is located at @orbit/jsonapi/dist/commonjs/es5/lib/request-settings.js which contains the relevant section:
    for (var param of ['filter', 'include', 'page', 'sort']) {
        if (options[param]) {
            (0, _utils.deepSet)(settings, ['params', param], options[param]);
        }
    }

However, I believe valid transpiling would look like this:
    var _arr = ['filter', 'include', 'page', 'sort'];

    for (var _i = 0; _i < _arr.length; _i++) {
        var param = _arr[_i];
        if (options[param]) {
        (0, _utils.deepSet)(settings, ['params', param], options[param]);
        }
    }

Reference: https://github.com/addyosmani/es6-equivalents-in-es5#iterators-and-for-of

A quick code search indicates that's the only use of for ... of in the project. I'll accept a PR to replace that usage with a forEach, and then I can issue a new patch release of @orbit/jsonapi.


feat: added support for device attributes

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

[x] Assign members of your team to review the pull request.
[x] Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
[ ] Wait until the pull request has been reviewed and approved by a teammate
[ ] After pull request is approved, and you determine it's ready add the label "Ready to merge" to the pull request and it will automatically be merged.

Pull request title looks good 👍. If this pull request gets merged, it will cause a new release of the software.
Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.1.0.
To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

In my last PR review, I left this comment

In this PR, I don't see support for adding custom attributes? Is that planned for a future PR? On iOS, it got implemented in it's PR for adding device attributes. I assume Android should support it as well?

I don't see support for adding custom attributes added so this question still stands. Besides this question, the PR looks good to me.

In my last PR review, I left this comment

In this PR, I don't see support for adding custom attributes? Is that planned for a future PR? On iOS, it got implemented in it's PR for adding device attributes. I assume Android should support it as well?

I don't see support for adding custom attributes added so this question still stands. Besides this question, the PR looks good to me.

Awesome thanks @levibostian ! custome attributes is part of future releases when BE/FE supports it.

:tada: This PR is included in version 1.1.0-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[W 151017 09:26:00 index:107] connect to scheduler rpc error: error(111, 'Connection refused')

I have a question, pyspider cannot normal use mysql, the database can be created, but the project information cannot write projectdb, there are some abnormal in use is as follows:

unknown project: test
Error Info [W 151017 09:26:00 index:107] connect to scheduler rpc error: error(111, 'Connection refused')
Codes:
============================================================
[I 151017 13:04:00 tornado_fetcher:425] fetcher starting...
[I 151017 13:04:06 result_worker:49] result_worker starting...
[I 151017 13:04:06 processor:213] processor starting...

[I 151017 13:05:10 tornado_fetcher:457] fetcher exiting...
[I 151017 13:05:10 result_worker:66] result_worker exiting...
[I 151017 13:05:10 app:75] webui exiting...
[I 151017 13:05:10 scheduler:470] scheduler exiting...
=============================================================

This is mysql environment, I don't have the use of conf  environment。
MySQLEnvironment
export MYSQL_NAME=mysql
export MYSQL_PORT_3306_TCP_PORT=3306
export MYSQL_PORT_3306_TCP_ADDR=root:root@ip

[I 151017 13:04:00 tornado_fetcher:425] fetcher starting...
[I 151017 13:04:06 result_worker:49] result_worker starting...
[I 151017 13:04:06 processor:213] processor starting...

[I 151017 13:05:10 tornado_fetcher:457] fetcher exiting...
[I 151017 13:05:10 result_worker:66] result_worker exiting...
[I 151017 13:05:10 app:75] webui exiting...
[I 151017 13:05:10 scheduler:470] scheduler exiting...


No hover background change for show search details

Issue Type: Bug

VS Code version: Code - Insiders 1.56.0-insider (ce791d27dc9889a392f4d29abefe9c53eb0b5129, 2021-04-16T11:25:09.662Z)
OS version: Windows_NT x64 10.0.18363

Thank you for submitting your feature request and everyone who considered it! Unfortunately, this issue did not receive enough votes over the allotted time, and so we are closing the issue. PRs are welcome so you can create a PR that fixes this if you are passionate about getting this feature across the finish line. Thanks!


Documentation on how to use test-utils without babel/webpack

What problem does this feature solve?
The documentation explains how to use vue-test-utils with different runners and build setups but not how to test a plain component without babel / webpack. Since Vue itself works great without using single file components or a build step it would be great to provide at least one simple example on how to use vue-test-utils in that case.
I have tried some obvious ways and asked for help on the forum and SO more than two weeks ago but since no one could help this really seems to be not documented at all.
https://forum.vuejs.org/t/how-to-test-plain-vue-components-not-single-file-components/58415
https://stackoverflow.com/questions/55052983/how-to-test-plain-vue-components-not-single-file-components
What does the proposed API look like?
var testUtils=require('@vue/test-utils'), Vue=require('vue');

require('jsdom-global')();

testUtils.mount({ template: '
test
' });
// or
testUtils.mount(Vue.component('test', { template: '
test
' }));

would be obvious but fails with this error:
@vue/test-utils/dist/vue-test-utils.js:2471
var componentInstance = node.child;
TypeError: Cannot read property 'child' of undefined

You need to load the DOM before requiring Vue. Change you code to this:
require('jsdom-global')();
var testUtils=require('@vue/test-utils'), Vue=require('vue');
// ...

Likely Jest loads JSDOM in some script before Vue is required, which is why it works there. I am not entirely clear on why this the order makes a difference.

It's actually not Vue but @vue/test-utils that has to be required after jsdom, but you are right.
This fact should definitely be included in the documentation.
test-utils could also check if jsdom was loaded and throw a more meaningful error if not.
Thanks a lot!

@aaronsum1102  thanks for raising this issue. Would you like to write the guide?

I got same error.
And then I tried fix as per this document.
https://jestjs.io/docs/en/24.0/configuration#testenvironment-string
testEnvironment: "jsdom",

My test got all green.

if you do this, you can remove jsdom package from your package.json.
jest contains jsdom.

I'm interested in writing a quick guide on how to use test-utils without babel/webpack.


feat: add typing to dbus_fast._private.util

This one has gone stale. I needs to be reworked. No sense in keeping it open for now


Allow for ENV_PATH variable for OpenShift integration, add documentation (#1, #3)

This PR tweaks how the env.json configuration file is loaded, moving the file's expected location to a secrets sub-directory inside the config directory and allowing for an ENV_PATH environment variable to be set in OpenShift to set the path (allowing for different file names, primarily). It also adds an application overview, configuration instructions, and OpenShift deployment details to README.md, as well as makes general formatting changes to the file. This PR aims to aims to resolve issue #1 and finish resolving issue #3.

@pushyamig , please let me know if the recent changes address your requests for more database documentation.

I'm merging now, let me know if you want something else in the README going forward.


PS3 WebMan Mod only seeing PS2 DVD games and not CD (works on a Real PS2 with OPL just fine)

I have managed to get my PS3 with WebMan MOD to successfully see my content for PS3, PS2 and PSX games.
However, I have noticed that its only pulling through the PS2 DVD-ROM ISOs and not any of the CD-ROM ISOs.

Bit of a challenge here.  We split out PS2 games into DVD and CD dirs/links for OpenPS2Loader on PS2.
In ps3netsrv we only have a "PS2ISO" option, which I've linked to the DVD folder for PS2.
What I can do is try linking one level up to the PS2 level, however I don't know if ps3netsrv is happy with subdirs.  I don't have a way to test, so I'll commit the code and ask for some feedback on this if possible.  I'll update again when the change is made.

No @danmons  worries happy to be your tester for this.

I've changed the symlink location for the PS2ISO folder.  You'll need to delete/rename the existing symlink and re-run the ps3netsrv installer from RetroNAS for it to correctly install the new one.

@danmons where do I find the symlink to remove it?

@danmons where do I find the symlink to remove it?

You can either use the command line or the cockpit file manager.
The symlink is under your RetroNAS top level dir, under ps3/ps3netsrv. It's called "PS2ISO".  Simply rename that to "PS2ISO.old" and re-run the ps3netsrv installer.

The webman mod doesn't like the folder structure for this for me, but its fine for multiman itself. It seems to crash easily on a lot of items too but that's not a retronas issue.

i got them to fix folder support in webman, however it only supports single letters and no special chars
If  its possible for you to make a symlink to a folder with a single letter as a name it will work properly.
For example cd folder to c folder in ps3net folder and dvd to d folder

Linking to the WebmanMOD ticket for reference https://github.com/aldostools/webMAN-MOD/issues/642

yes it works, are you on the latest webman from last week?
https://imgur.com/a/aTgLWUj

I recompiled ps3netsrv 20220326 this morning and am on webmanmod 1.47.38 with HEN 3.0.3
capitalization also makes no difference for me

not sure then, it works for me as the images show. Webman doesn't display the folders just the items within the folders for me correctly if that's your issue.
Meaning retronas puts out a b c or whatever folder and webman just lists the contents within not the folders

Grabbed the latest version of 1.47.38 and the hash was different to the one I had so reinstalled webMAN, but behaviour is still the same
Until this has stabilised RetroNAS wont be making any further changes.

you should open a new issue since i doubt he will see a closed issue and I cannot reopen it since he closed it himself

we're not going to be doing anything in this space with RetroNAS, there some weirdness with my install of webMAN MOD that i'll work through with the main project but i'm closing this off because the moving of the symlink is fine for others.


Correct understanding of faceting

I was rather pleased with myself after https://github.com/wellcomecollection/content-api/pull/51 - but I shouldn't have been, I got it wrong. The test cases should adequately illustrate what the misunderstanding was...

face-inating


[Help] Build virtual TestNG suite xml, when add XmlTest failed

TestNG Version: 6.14.3
Platform:

Mac OS 10.13.4
Java: 8
Build System: Maven

Want to build virtual TestNG XML, and meet problem when add Xml Test to Xml Suite:
code:
Initialise XmlSuite instance:
public XmlSuite newXmlSuite() {
    XmlSuite xmlSuite = new XmlSuite;
    // set the xml suite's `name`, `thread-number`, `preserve order`, `parallel` mode
    xmlSuite.setName("XML Suite Sample");
    xmlSuite.setParallel(XmlSuite.ParallelMode.TESTS);
    xmlSuite.setPreserveOrder(false);
    xmlSuite.setThreadCount(Runtime.getRuntime().availableProcessors());
    xmlSuite.setVerbose(2);
    return xmlSuite;
}

This sample will be passed:
public XmlSuite appendXmlTest(XmlSuite xmlSuite) {
    XmlTest xmlTest = new XmlTest(xmlSuite);    // initialise a xml test instance with XmlSuite instance
    // below is initialise `xmlTest` instance context, for example, testing class, testing method of testing     class
    ...
    return xmlSuite;
}

// no problem to run the virtual xml suite
public void testRun() {
    XmlSuite xmlSuite = newXmlSuite();
    xmlSuite = appendXmlTest(xmlSuite);
    log.info(xmlSuite.toXml());

    TestNG testng = new TestNG();
    testng.setXmlSuites(asList(xmlSuite));
    testng.run();
}

This sample will be failed:
public XmlTest getXmlTest() {
    XmlTest xmlTest = new XmlTest();     // initialise xml test instance without any parameter
    // get xml test details
    ...
    return xmlTests;
}

// error met below
public void testRun() {
    XmlSuite xmlSuite = newXmlSuite();
    log.info(xmlSuite.toXml());

    xmlSuite.addTest(getXmlTest());
    TestNG testng = new TestNG();
    testng.setXmlSuites(asList(xmlSuite));
    testng.run();
}

and error message:
Exception in thread "main" java.lang.NullPointerException
	at org.testng.xml.XmlTest.isJUnit(XmlTest.java:281)
	at org.testng.xml.DefaultXmlWeaver.asXml(DefaultXmlWeaver.java:153)
	at org.testng.xml.XmlWeaver.asXml(XmlWeaver.java:67)
	at org.testng.xml.XmlTest.toXml(XmlTest.java:475)
	at org.testng.xml.DefaultXmlWeaver.asXml(DefaultXmlWeaver.java:139)
	at org.testng.xml.XmlWeaver.asXml(XmlWeaver.java:57)
	at org.testng.xml.XmlSuite.toXml(XmlSuite.java:518)

Tried to print out the suite xml (xmlSuite.toXml()), and notice that the failed case xml is same as passed case xml.
Update:
used .setTests(List<XmlTest>) also met the same error.
xmlSuite.setTests(asList(xmlTest));

Could anyone provide how can I fix the failed issue?

@ansonliao - When you instantiate an XmlTest object, you should ensure that it is bound with an XmlSuite object in one of the following two ways

Via the XmlTest constructor org.testng.xml.XmlTest#XmlTest(org.testng.xml.XmlSuite) (or) org.testng.xml.XmlTest#XmlTest(org.testng.xml.XmlSuite, int)
Via the setter method org.testng.xml.XmlTest#setSuite

The null pointer exception is basically arising due to the fact that the XmlTest object is trying to access the attributes of a null XmlSuite.
I have now added an edit check which ensures that you dont see a NullPointerException but instead see a proper error message.

@krmahadevan
Thanks for your reply.


DOC: Fix warnings from new Sphinx

Want to look at #1976?

oh, i totally missed that. Closing in favor of that


Firebase-ESP-Client/examples/Firestore/Data_Query /Data_Query.ino

I am only able to see read time. Do you know how I can add the parameters to get the whole JSON file from the query? I am unable to change the consistency mode to anything besides leaving it undefined which is defaulting to the fb_esp_firestore_consistency_mode_readTime type. The compiler does not recognize objects of the class
"fb_esp_firestore_consistency_mode". I would appreciate any help you could provide with this issue.
(I am using an ESP32)

Update, I realized it's an enum. But if I want to set the consistencyMode to newTransaction, then what should I set consistency to? When I set consistencyMode but put nothing for consistency, it still just returns readTime.


Cache results of historical queries

We now cache the result of queries that are against the last n blocks (where n is set with GRAPH_QUERY_CACHE_BLOCKS) That works well for queries for the latest data, but does not do anything for historical queries. Depending on the mix of latest and historical queries, the cache hit ratio can become quite low.
We should add another cache layer that caches historical queries, similarly size constrained like the cache for latest queries is. Ideally, that cache would use a combination of LRU and query effort to determine which responses to evict from the cache, so that query results that haven't been used in a while, and that are easy to recompute are evicted before recent results or those that are hard to compute are evicted.

This is done as of #1878


CLI inconsistent error on sync after clone in two different ways

I suspect there is some minor inconsistency in the CLI that leads to failing syncs after a clone specified with a hash and no dir argument. The first line works and the seconds one doesn't.
$ dat --version
13.11.4

$ dat clone f427ad98689e020f8d8d16ec238d3d2b56f5cdd3dabe40e7bacb2133c2e33583
$ dat sync f427ad98689e020f8d8d16ec238d3d2b56f5cdd3dabe40e7bacb2133c2e33583/
No existing archive in this directory.

$ dat clone f427ad98689e020f8d8d16ec238d3d2b56f5cdd3dabe40e7bacb2133c2e33583 righthere
$ dat sync righthere/
dat v13.11.4
Downloading dat: 2 files (138 B)

1 connection | Download 0 B/s Upload 0 B/s

dat synced, waiting for updates.
[==========================================] 100.00%

I think it might be having a hard time if you make the directory name the hash.
Specifying a non-hash directory name seems to be ok.
$ dat clone 9852c6d737a05235986fc3975adef9d177aabb13c92d6f1f48007b7dd008abb7 9852c6d737a05235986fc3975adef9d177aabb13c92d6f1f48007b7dd008abb7
$ dat sync ./9852c6d737a05235986fc3975adef9d177aabb13c92d6f1f48007b7dd008abb7
No existing archive in this directory.

$ dat clone 9852c6d737a05235986fc3975adef9d177aabb13c92d6f1f48007b7dd008abb7 here
dat v13.11.4
Created new dat in /tmp/here/.dat
Cloning: 6 files (59 KB)

4 connections | Download 60 KB/s Upload 0 B/s

dat sync complete.
Version 8

Exiting the Dat program...
$ dat sync here
dat v13.11.4
Downloading dat: 6 files (59 KB)

2 connections | Download 0 B/s Upload 0 B/s

dat synced, waiting for updates.
[==========================================] 100.00%

A final hunch is that it is something to do with the length of the directory name. Prepending sha_... does not fix the issue but truncating the hash does.


Add Exam Venues from PDF

Summary
Write a function to make a CSV file from the midsem_venue.pdf (and similarly endsem_venue.pdf for endsem) file attached accordingly so as to find the venue(Room No.) of a given course code for a given roll_number.
Add fields 'midsem_venue' and 'endsem_venue' in 'my_courses_nullable' in main.py and fetch their values by matching Roll number and course code from the CSV.
midsem_venue.pdf
Note: Create pull request in 'hacktober' branch

I want to try working on it!

I want to try working on it!

You have been assigned

hey, could you check the pull request #13  I've made and let me know if there's things I should change.

hey, could you check the pull request #13 I've made and let me know if there's things I should change.

I've added a few comments in the PR

could you check if there's anything else I should change?

resolved them !
conflicts can be such a pain :pensive:

😂 yaa


Set keep alive in TcpTransmission throws PlatformNotSupportedException on Linux/OSX

Describe the bug
The TcpTransmission throws a PlatformNotSupportedException when using IOControl to set keepAlive on non windows os.
That's because it's only supported on Windows. This IOControl code value is Windows-specific.
https://github.com/dotnet/runtime/issues/25555
This creates also an compiler warning 'IOControlCode.KeepAliveValues' is supported on 'windows'

Here is a discussion on that topic from the dotnet runtime repo with some hints to solve this issue
Also here is a link to the specific line to be adapted.

And Console.Beep(int, int) is only supported on Windows as well with no signs for a linux implementation coming as the discussion here indicates

Closed by #102


.NET Core 2.1.0 package updates

updated to 2.1.0-preview1-final, leaving open until the stable version is released


Add LABEL org.opencontainers.image.source

Solves https://github.com/trion-development/docker-ng-cli-karma/issues/19

@everflux


[DO NOT MERGE] Replace WebView with MagicWebView

Have we tested pod install? Is it compatible with Xcframework?


Disable autocorrect for the login page fields

On the login page, the iOS autocorrector remains enabled for all fields. This makes entering the URL very difficult as one has to refuse the proposed corrections for things like domain names or "cgi-bin" or even "mt" (and the habit of iOS to add a trailing space each time one dismisses its corrections).
Please disable auto-correct for all fields on the login page.
(Tested on iOS 8.4 (12H143) on a iPhone.)

Thanks!

Fixed in development.


Upgrade storybook to 5.0.x

Tested

do we need this PR ?

Superceded by #7 (because i'm lazy & rolled it together accidentally)


As application, I want to store and query reporting information so that I can keep track of what has been reported

https://www.pivotaltracker.com/story/show/104425114

@arothuis @DRvanR


Use more anonymous functions for callback

This might make the code actually less readable. Instead, let's check inspect case of a callback and decide whether a dedicated, named method or an anonymous function would be better.


fix(explore): Prevent infinite rerenders when editing dataset

SUMMARY
In some scenarios, editing dataset and then running chart query might lead to an infinite rerender loop (happens inconsistently) and Explore page crashing. Investigation proved that it's related to removing warnings about changed dataset in controls after a successful query. This PR makes updating Redux state conditional in order to run actions dispatch only when necessary and prevent infinite state updates.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

🏷 preset:2022.47


Update adapter to wasmtime 14.0.3

For my understand, as I am now generally bumping the adapter version only for major wasmtime releases and I don't see any wit changes from 14.0.0, is bumping the adapter necessary?

I just confirmed, there were no changes to the adapter source code, or the wit files, between 14.0.0 and 14.0.3. I am curious why the hash changed between those releases, did rustc change as well?

The hash here is a wasmtime commit and not a hash of the adapter module, so I would expect differences between wasmtime versions.

@peterhuene sorry for the noise! Thanks for confirming the process!

oh, right, I forgot we put the commit in there. Thanks


rudimentary endpoint parsing from log of faucet

Codecov Report

Merging #408 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   97.62%   97.87%   +0.25%
==========================================
  Files          31       31
  Lines        1897     1932      +35
  Branches      108      115       +7
==========================================
+ Hits         1852     1891      +39
+ Misses         30       27       -3
+ Partials       15       14       -1

Impacted Files
Coverage Δ

...llerAbstraction/NorthBoundControllerAbstraction.py
98.79% <ø> (-0.01%)
:arrow_down:

...trollerAbstraction/proxy/faucet/test_connection.py
100% <100%> (ø)
:arrow_up:

...dControllerAbstraction/proxy/faucet/test_faucet.py
100% <100%> (ø)
:arrow_up:

...hBoundControllerAbstraction/proxy/faucet/faucet.py
100% <100%> (+7.14%)
:arrow_up:

...ndControllerAbstraction/proxy/faucet/connection.py
71.73% <100%> (+2.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e29953...af89851. Read the comment docs.


Troubleshooting

I'm trying to get this working and I'm just getting nothing.
What are some things to check to see if phpcd is running? I was able to run the command:
php ~/.config/nvim/pack/minpac/start/phpcd.vim/php/main.php `pwd` msgpack vendor/autoload.php 0

And no errors were thrown.
I tried :call phpcd#Index() and I get no output.
Cheers
Snipped output of php -m
[PHP Modules]
msgpack
pcntl

Versions
msgpack: 1.4.2-3
php: 7.1.15
php-msgpack: 2.0.2
neovim: 0.2.2

please make sure you phpcd process is running

I can't see it in htop

please read the README carefully. make sure you project has a autoload php file.

I'm using composer so autoload.php is in the default location (vendor/autoload.php)

please check the ~/.phpcd.log content

Sorry it doesn't exist

It is wired. please drop the two lines
https://github.com/lvht/phpcd.vim/blob/master/php/main.php#L2
https://github.com/lvht/phpcd.vim/blob/master/php/main.php#L24
And run phpcd manually.

I'm not seeing any errors in the console when I try to invoke phpcd inside neovim.

If I press enter in the console while phpcd is running I get this:
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Lvht\MsgpackRpc\ForkServer::onMessage() must be of the type array, integer given, called in /home/deevus/.config/nvim/pack/minpac/start/phpcd.vim/vendor/lvht/msgpack-rpc/src/ForkServer.php on line 32 and defined in /home/deevus/.config/nvim/pack/minpac/start/phpcd.vim/vendor/lvht/msgpack-rpc/src/AbstractServer.php:39
Stack trace:
#0 /home/deevus/.config/nvim/pack/minpac/start/phpcd.vim/vendor/lvht/msgpack-rpc/src/ForkServer.php(32): Lvht\MsgpackRpc\ForkServer->onMessage(10)
#1 /home/deevus/.config/nvim/pack/minpac/start/phpcd.vim/php/main.php(41): Lvht\MsgpackRpc\ForkServer->loop()
#2 {main}
  thrown in /home/deevus/.config/nvim/pack/minpac/start/phpcd.vim/vendor/lvht/msgpack-rpc/src/AbstractServer.php on line 39

Not sure if that's helpful

am getting same error here

Hi @lvht  - I'm experimenting similar issue using MacOS, PHP 7.2 and NeoVim, I have installed the https://github.com/msgpack/msgpack-php extension and my project uses composer so it has autoload.php. It looks like the autostart of the phpcd service is failing. As @deevus commented in my local environment the ~/.phpcd.log file don't exists. I'm trying to start it manually but need to figure out the parameters to pass to main.php. I will update here if I'm able to find what's failing, maybe is an issue when using MacOS?

@citlacom echo all the rpc#start args to get the main.php start flags.
And you need comment this line to see errors.

Hi @lvht - Thanks for your help, finally I found the issue, as I have two versions of PHP 7 installed in my local environment, one that is from MAMP https://www.mamp.info/en/ which I use for web development and other that installed with Homebrew to satisfy the dependency pcntl dependency which don't come built in the MAMP PHP version. As I have exported in my environment PATH the MAMP bin directory I misunderstood that the variable g:phpcd_php_cli_executable can be set at my NeoVim init.vim so even when I set it to my Homebrew PHP version<EMAIL_ADDRESS>when the phpcd server was started was still using the MAMP PHP which don't satisfy the "pcntl" dependency.
After look your example https://github.com/lvht/php-co-demo configuration move the php cli executable override to .phpcd.vim and that worked 👍
Thanks for your support and great work on this plugin!


Only ON/OFF works

Hi
I've just added 2 pcs 48 meters and one 10-15meter or something and it finds all entities but they are listed as unavailable.. Only ON/OFF works.
Do you know how to fix?

Are there any errors?

No - It just says not available. Put actually looking at the new pull request it seems to describe my problem. Maybe it will fix it?

Try it out! And please let me know I haven’t gotten to it yet.

Did not fix my problem :-(

Hi.
First thanks for this component @JurajNyiri
Freshly added  and same issue.
Only  ON/OFF is available ( I also tried the pending PR, quite the same )
LED-4-01-00000000 model name.

LED-4-01-00000000

Everything identifies the same from this brand(?).
Could you post a picture of what you bought - the product itself? Maybe it can help others... As I do not own it it would be pretty much impossible for me to fix this but maybe someone else can.

I altso tried the PR - Didnt work :-(
Is there any infomation I could give you that would make your job easier? logs or something. please let me know

Hi, thanks for this integration. Works great but same issue here. I have two (identical) devices with 240 lights LED-4-02-00000000. One allows to change all entities, the other does allow switching on/off only, stating the rest as "unavailable".

Update: could solve the issue by reconfiguring everything in the Lights App. So that's what I (remember) I did:

Disable your BT Proxy to be able to connect via Lights App again.
Remove device from Lights App.
Unplug device.
Plug In device again.
Connect with Lights App
Switch On the light.
Go to Settings / Functions.
"Combination" (or similar) should be greyed out.
Disable all other options despite "Stay on".
Enable BT Proxy again
Reload Configuration for device.

Maybe I miss-spelled some functions (I am using the german translation for Home Assistant and Lights App, so things are might named different).
Maybe some steps are not needed.
Maybe I forgot something.


Implement Rolling Time Window Counter

Currently metrics-core-hdr is addresed to histograms only, but the solution which implemented in ResetByChunksAccumulator can be easily extrapolated to other window based monitoring structures like counters, cache hit meters and top of slow queries.
So it is need to do:

Extract eviction policy from HdrBuilder to independent entity.
Add support of "Rolling Time Window Counter".
Document new feature.
Create release 1.3.0

The version 1.3.0 with implementation of SmoothlyDecayingRollingCounter is released


[PORT] Proactive auth: trust incoming token url conditionally

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3532

Changed projects

Microsoft.Bot.Builder

@stevengum  - this was discussed in the Stand-up meeting. ChrisMu mentioned that Carlos had already made the update. Is that not the case?

The linked PR is a parity feature that will align the behavior in the two languages. In JS, users still have to trust the serviceUrl to fetch a token for outgoing requests.
In C#, when using BotFrameworkAdapter.ContinueConversationAsync() this is no longer required.
#1889 will change it so that the ServiceUrl is trusted automatically if the bot has an AppId. The unit tests in #1889 account for the scenario that drove microsoft/botbuilder-dotnet#3532.
Because this is just language alignment and not breaking any existing scenarios, I marked it as R9 to not impede the 4.8 release train.

Testing
I tested 4.8.0-rc0 anonymous proactive messaging via sample 16 and @jwiley84 confirmed that it worked for her as well.


Investigate emerging reproducibility issue

#965 fixes tests that have started being flaky recently (Dec 2020) without any related change.
This is probably a dependency update having a wide impact on random states, but not sure.
In 17 December 2020, running this on master was flaky:
pytest nevergrad/benchmark/test_xpbase.py::test_noisy_artificial_function_loss --count=100 --exitfirst
However this was stable before (never had any failure for months/years on this test. Still, using branches dating back to June 2020, I could see the same error. This is why I expect a dependency update has been at play.

Why not sharing a single random generator in Nevergrad, since numpy.random.seed is a legacy function anyway?
How about injecting inspect.getouterframes in the numpy.random.seed function to locate the problem?

Do you mean some libraries use numpy.random.seed and reseed the random number generator?

Why not sharing a single random generator in Nevergrad, since numpy.random.seed is a legacy function anyway?
How about injecting inspect.getouterframes in the numpy.random.seed function to locate the problem?

possibly, but that should not have any impact.

all parametrizations have their own random_state so that we can master exactly what happens. This random_state can be used by functions to iniatilize with different seeds. Then again, some do not, and it could indeed be useful to have our one random_state (although I tend to hate global variables, but anyway np.random is already one...)
I am not familiar with it, i'm curious now. Just a thought but it may not directly link, but this is kind of a "quantum" issue, when I tried to observe/print the random states, then the error disappeared (mostly because then the initialization is done at a different time though). Something unclear must happen between the moment they are now initialized (in the init) and the moment they were initilized before (call)

I have tracked the code leading to #965. Luckily, not many places use np.random.* functions.
The key question is which classes should be allowed to create a random_state? For example,

Random State for Class: If a class needs to generate a random number, such as nevergrad/utils/Transform.py, should we assign a random_state?
Random State for Function: Similarly, the function _noisy_call in nevergrad/functions/functionlib.py looks problematic. As it calls np.random.normal for every evaluation.
Pass-Through: the function ArtificialVariable.process in nevergrad/functions/functionlib.py, the random state is saved and then restored. My observation is it is not allowed in general.

To solve the problems, we should set some rules on random_state management. I think that the random_state management for Parameter class has been carefully written.

Short answer is ArtificialVariable (and all of ArtificialFunction) predates by far the parametrization system, it's a huge hack to for backward compatibility but we should refactor it one day :s (which is hard given the whole range of options :D)

The key question is which classes should be allowed to create a random_state

That's a hard one. I have no exact answer to this. I tend to prefer that functions use the parametrization's random state, that way experiments share a unique source of randomness. In many cases though, functions take a seed to make them "determinitic" of some sort, with their own random state. It's not required for getting reproducibility, but it does depend on how users want their testbeds to behave, so not sure I should fight against it :s
In any case I prefer that they do not tap into numpy's default random state, so that they remain somehow isolated from outside.

Short answer is ArtificialVariable (and all of ArtificialFunction) predates by far the parametrization system, it's a huge hack to for backward compatibility but we should refactor it one day :s (which is hard given the whole range of options :D)

The key question is which classes should be allowed to create a random_state

That's a hard one. I have no exact answer to this. I tend to prefer that functions use the parametrization's random state, that way experiments share a unique source of randomness. In many cases though, functions take a seed to make them "determinitic" of some sort, with their own random state. It's not required for getting reproducibility, but it does depend on how users want their testbeds to behave, so not sure I should fight against it :s
In any case I prefer that they do not tap into numpy's default random state, so that they remain somehow isolated from outside.


Church numbers example only work with type signature

http://playground.oden-lang.org/p/a76c5ec2f9b254c1f1f023833b0747f1
Remove type signatures for zero and one and you get:
Unexpected polymorphic type (zero? : (((#d -> (#e -> (#f -> #f))) -> ((bool -> (bool -> bool)) -> (bool -> (bool -> bool)))) -> (bool -> (bool -> bool))))

Duplicate of #23.


install problem

when I do yarn global add solidity-repl
I get the following error:
└> yarn global add solidity-repl
yarn global v0.24.6
warning No license field
[1/4] 🔍  Resolving packages...
⠁<EMAIL_ADDRESS>⠈<EMAIL_ADDRESS>error Refusing to download the git repo {"protocol":"https:","hostname":"github.com","repository":"https://github.com/debris/bignumber.js.git"} over HTTPS without a commit hash - possible certificate error?
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.

Hi! Since https://github.com/debris/bignumber.js is not actually a dependency of solidity-repl, I don't think there's anything that can be done here. It looks like it is a dependency of web3:
$ npm ls | grep bignumber -B 1
└─┬<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>(git+https://github.com/debris/bignumber.js.git#94d7146671b9719e00a09c29b01a691bc85048c2)

Are you still having this issue? I bet a newer version of web3 would fix it. web3 v1.0 is going to be released soon as well.

Closing due to inactivity


setting a breakpoint on a moved line in ts hit a breakpoint in js

Steps to Reproduce:

Debug a typescript project
add a newline to a ts file
add a breakpoint below the newline
reload the project being debugged
:bug: associated js file opens for a breakpoint at the top of that file

This happens more often than just these specific steps, but this is a consistent repro for me

/jsDebugLogs

Please collect trace logs using the following instructions:

If you're able to, add "trace": true to your launch.json and reproduce the issue. The location of the log file on your disk will be written to the Debug Console. Share that with us.
⚠ This log file will not contain source code, but will contain file paths. You can drop it into https://microsoft.github.io/vscode-pwa-analyzer/index.html to see what it contains. If you'd rather not share the log publicly, you can email it to<EMAIL_ADDRESS>

it happens basically everywhere when debugging vscode OSS, e.g. https://insiders.vscode.dev/github/microsoft/vscode/blob/main/src/vs/workbench/contrib/notebook/browser/viewModel/codeCellViewModel.ts#L165
For that location I
set a breakpoint at L165
open a notebook
reload
add a newline (so now the breakpoint is on L166),
reload (breakpoint is hit correctly)
removed the line previously added (breakpoint disappears)
reload
end up in the js file.
vscode-debugadapter-e45188e8.json.gz

Ah, thanks. That was a case that we should have left it as unverified but were setting it to line=0 column=0 instead.


Vxlan implementation

Coverage remained the same at ?% when pulling e8fedeed0b2b2add0009239b6dc71b75d277144c on qinqon:vxlan_implementation into 34ee4efc751816a8a6ec1f806f802c61ff1c5199 on nmstate:master.

Coverage remained the same at ?% when pulling e8fedeed0b2b2add0009239b6dc71b75d277144c on qinqon:vxlan_implementation into 34ee4efc751816a8a6ec1f806f802c61ff1c5199 on nmstate:master.

NM has the remote property, don't know what's the issue.
autoconnect_slaves: <enum NM_SETTING_CONNECTION_AUTOCONNECT_SLAVES_YES of type NM.SettingConnectionAutoconnectSlaves>
2019-09-30 13:29:52 netapplier.py:228 DEBUG Editing interfaces: []
2019-09-30 13:29:52 nmclient.py:98 DEBUG Executing NM action: func=add_connection_async
2019-09-30 13:29:52 nmclient.py:161 ERROR NM main-loop aborted: Connection adding failed: error=nm-connection-error-quark: vxlan.remote: property is missing (6)
2019-09-30 13:29:52 checkpoint.py:146 DEBUG Checkpoint /org/freedesktop/NetworkManager/Checkpoint/4 rollback executed: dbus.Dictionary({dbus.String('/org/freedesktop/NetworkManager/Devices/2'): dbus.UInt32(0), dbus.String('/org/freedesktop/NetworkManager/Devices/4'): dbus.UInt32(0), dbus.String('/org/freedesktop/NetworkManager/Devices/1'): dbus.UInt32(0), dbus.String('/org/freedesktop/NetworkManager/Devices/3'): dbus.UInt32(0)}, signature=dbus.Signature('su'))
----------------------------------------------------------------------------------------------------------- Captured log teardown -----------------------------------------------------------------------------------------------------------
2019

NM has the remote property, don't know what's the issue. @cathay4t @EdDev do you know why ?
autoconnect_slaves: <enum NM_SETTING_CONNECTION_AUTOCONNECT_SLAVES_YES of type NM.SettingConnectionAutoconnectSlaves>
2019-09-30 13:29:52 netapplier.py:228 DEBUG Editing interfaces: []
2019-09-30 13:29:52 nmclient.py:98 DEBUG Executing NM action: func=add_connection_async
2019-09-30 13:29:52 nmclient.py:161 ERROR NM main-loop aborted: Connection adding failed: error=nm-connection-error-quark: vxlan.remote: property is missing (6)
2019-09-30 13:29:52 checkpoint.py:146 DEBUG Checkpoint /org/freedesktop/NetworkManager/Checkpoint/4 rollback executed: dbus.Dictionary({dbus.String('/org/freedesktop/NetworkManager/Devices/2'): dbus.UInt32(0), dbus.String('/org/freedesktop/NetworkManager/Devices/4'): dbus.UInt32(0), dbus.String('/org/freedesktop/NetworkManager/Devices/1'): dbus.UInt32(0), dbus.String('/org/freedesktop/NetworkManager/Devices/3'): dbus.UInt32(0)}, signature=dbus.Signature('su'))
----------------------------------------------------------------------------------------------------------- Captured log teardown -----------------------------------------------------------------------------------------------------------
2019

I can't be sure, since you don't say what you did that triggered that, but I think that in https://github.com/nmstate/nmstate/pull/515/files#diff-2808139b5c039d9782e3f7fb3ab11d39R56 you're handling the 'remote' property as mandatory, while I think it is optional.
Let me know how it went.

@EdDev this one is ready too.

@EdDev is there anything else missing here ?

@EdDev have refactor it to use a little of OOP also down state need the type but absent state does not.

integration test test_add_new_base_iface_with_vxlan has transitory failures

@qinqon , CI fails: https://travis-ci.com/nmstate/nmstate/jobs/258153028

Ci is passing here for vxlan
./automation/run-tests.sh te--test-type integ --pytest-args='-x -k vxlan' --el8
tests/integration/vxlan_test.py::test_add_and_remove_vxlan PASSED                                                            [ 14%]
tests/integration/vxlan_test.py::test_add_and_remove_two_vxlans_on_same_iface PASSED                                         [ 28%]
tests/integration/vxlan_test.py::test_rollback_for_vxlans PASSED                                                             [ 42%]
tests/integration/vxlan_test.py::test_set_vxlan_iface_down PASSED                                                            [ 57%]
tests/integration/vxlan_test.py::test_add_new_base_iface_with_vxlan XPASS                                                    [ 71%]
tests/integration/nm/vxlan_test.py::test_create_and_remove_vxlan PASSED                                                      [ 85%]
tests/integration/nm/vxlan_test.py::test_read_destionation_port_from_libnm XFAIL                                             [100%]

@qinqon The CI is failling at
tests/integration/nm/vxlan_test.py::test_create_and_remove_vxlan FAILED  [ 96%]
with error:
2019-11-19 11:48:45 nmclient.py:180 ERROR NM main-loop aborted: Connection activation failed on connection_id eth1.101: error=nm-device-error-quark: eth1.101 failed to create resources: Failed to create VXLAN interface 'eth1.101' for 'eth1.101': NME_UNSPEC (1)

@cathay4t , All comments have been answered as far as I can see. If I missed anything, please let me know.


Does the addition of an email address for CrossRef consolidation require to rebuild the Docker container?

I am using GROBID on Docker https://grobid.readthedocs.io/en/latest/Grobid-docker/ and thought to use CrossRef consolidation, doing that in the "polite" way, thus specifying a value for the mailto value in grobid-home/config/grobid.properties (which is a very trivial change).
To do so, do I need to rebuild a custom Docker image, or do I have the option to pass the email address to be used in the CrossRef calls to the container pulled from the public image on Docker Hub e.g. with an option in
docker run -t --rm --init -p 8080:8070 -p 8081:8071 lfoppiano/grobid:${latest_grobid_version}

?

Hi @davidefiocco,
in theory you can use the environment variables as explained here: https://github.com/kermitt2/grobid/pull/482
to overwrite the property you want in the grobid.properties.
export ORG__GROBID__CROSSREF__MAILTO=youremail

should do the trick.

OK @lfoppiano , I will try! By that reasoning, would
docker run -t --rm --init -p 8080:8070 -p 8081:8071 --env ORG__GROBID__CROSSREF__MAILTO='myemail' lfoppiano/grobid:${latest_grobid_version}

also do? That would be super handy also considering https://github.com/kermitt2/grobid/issues/628

Yes. As mentioned in the documentation https://grobid.readthedocs.io/en/latest/Grobid-docker/#configuration-using-environment-variables


why ignore zero?

Hi, thanks for your outstanding work.
I have a question when researching your code.
Why ignore it when class id equals zero?
https://github.com/tfzhou/ContrastiveSeg/blob/7be326ae9127a847558584eac489d4858adf7cb1/lib/loss/loss_contrast_mem.py#L98
https://github.com/tfzhou/ContrastiveSeg/blob/7be326ae9127a847558584eac489d4858adf7cb1/segmentor/trainer_contrastive.py#L114

Same question.
If the code ignore 0 class, this line will raise zero-division exception because there is no positive samples with 0 class:

    mean_log_prob_pos = (mask * log_prob).sum(1) / mask.sum(1)

Same question.
If the code ignore 0 class, this line will raise zero-division exception because there is no positive samples with 0 class:
https://github.com/tfzhou/ContrastiveSeg/blob/7be326ae9127a847558584eac489d4858adf7cb1/lib/loss/loss_contrast_mem.py#L147

Another question,
Why is the step size of pixel_queue_ptr is 1 instead of K?
https://github.com/tfzhou/ContrastiveSeg/blob/7be326ae9127a847558584eac489d4858adf7cb1/segmentor/trainer_contrastive.py#L138
Thanks.

Hi @Junshan233 @Junshan233 , in my cases, the datasets only include a number of semantic categories and one class that will be ignored. Thus, it is ok to ignore class 0. If this does not works in your cases, you need to change the code. For the pointer issue, please refer to https://github.com/tfzhou/ContrastiveSeg/issues/18.


[WiP] HMR in a webworker

This PR contains a:

[x] bugfix
[ ] new feature
[ ] code refactor
[ ] test update
[ ] typo fix
[ ] metadata update

Replaces window -> (typeof self !== 'undefined' ? self : this)
Upgrades loglevelnext to 3.0.0

Motivation / Use-Case

TBD
I'm trying to make HMR work in a webworker
Breaking Changes

TBD
Additional Info

@yurynix hi, how you can use webpack-hot-client?


Add Remove Previous Version action during install

Applying same change from DES-14034.

@lneir , please review it.

lgtm, thanks.


Dui3 124 receiving curves arcs ellipses nurbs curves

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

[ ] My pull request follows the guidelines in the Contributing guide?
[ ] My pull request does not duplicate any other open Pull Requests for the same update/change?
[ ] My commits are related to the pull request and do not amend unrelated code or documentation.
[ ] My code follows a similar style to existing code.
[ ] I have added appropriate tests.
[ ] I have updated or added relevant documentation.

References

Just a general comment: it would be good to align the ArcGIS converter project to have the same structure as the other DUI3 connectors: [Connector] > ToSpeckle / ToHost > [Speckle namespace, eg Geometry] / Raw > converter. Currently ArcGIS is organized like ArcGIS > [ArcGIS type, eg Feature] > converter (for to host, to speckle, and raw)

@AlanRynne only 1 draft PR is waiting for these changes, will only affect several files. The other PRs are not touching converters

@AlanRynne  only 1 draft PR is waiting for these changes, will only affect several files. The other PRs are not touching converters. After @clairekuang  approves requested changes, can be safely merged (blocked atm)


Document modified after update issue

Replicate:

Open a document
Change something
Save
Change something else
Try to save

Fixed in a0a8977767e86a3d42d0c30d9b1d6a845175a910


[ENHANCEMENT][v1.2.2] Bump rancher-monitoring and rancher-logging version

Is your enhancement related to a problem? Please describe.

To solve https://github.com/harvester/security/issues/46
The rancher-monitoring and rancher-logging version should also be bumped as what have already been done in v1.3.0:
#4940
#4941
https://github.com/harvester/harvester-installer/pull/658
https://github.com/harvester/harvester-installer/pull/657
In Harvester v1.2.2, the related upstream versions are:
RKE2_VERSION="v1.26.13+rke2r1"
RANCHER_VERSION="v2.8.2"

Describe the solution you'd like

Bump rancher-monitoring and rancher-logging version
Describe alternatives you've considered

Additional context

This is a manual backport of https://github.com/harvester/harvester-installer/pull/657, https://github.com/harvester/harvester-installer/pull/658 to solve https://github.com/harvester/security/issues/46

Note another issue:
https://github.com/harvester/harvester/issues/5442
https://github.com/harvester/harvester/issues/5499
And related PR:
https://github.com/harvester/harvester-installer/pull/693

Provide test results for new installation (v1.2.2-dev-20240329) and upgrade (v1.2.1 -> v1.2-f414942f-head) case.
Tests looks fine in new installation but we found eventrouter is v0.1.1 instead of expected v0.1.2 in the upgrade case.
Please help to check.
Environment

Harvester

Profile: QEMU/KVM, 8C/16G/500G per node
ui-source: Auto

Test Cases
New Installation (3 nodes, v1.2.2-dev-20240329)

Setup harvester v1.2.2-dev-20240329

 Enable rancher-monitoring and rancher-logging addons

Check charts are properly deployed/running

 :green_circle: rancher-monitoring should be 103.0.3+up45.31.1

Chart

Pod

 :green_circle: rancher-logging should be 103.0.0+up3.17.10

Chart

Pod

 :green_circle: harvester-eventrouter should be v0.1.2

Check Grafana Dashboard and Login

 :green_circle: via Harvester

 :green_circle: via Rancher

Upgrade from v1.2.1 to v1.2-f414942f-head (Single node)

Setup harvester v1.2.1

 Enable rancher-monitoring and rancher-logging addons

Check Grafana Dashboard and Login

 :green_circle: via Harvester

Login
harvester#4756

 :green_circle: via Rancher

Login
harvester#4756

 Upgrade to v1.2-f414942f-head

Check charts version and status

 :green_circle: rancher-monitoring is 103.0.3+up45.31.1

 :green_circle: rancher-logging should be 103.0.0+up3.17.10

 :red_circle: harvester-eventrouter should be v0.1.2 ${\color{red} \text{Got v0.1.1}}$

Ref.

https://github.com/harvester/harvester-installer/blob/v1.2/pkg/config/templates/rancherd-22-addons.yaml#L94
https://github.com/harvester/harvester-installer/blob/v1.2/scripts/images/harvester-additional-images.txt#L2

Check Grafana Dashboard and Login

 :green_circle:  via Harvester

 :green_circle: via Rancher

Reference

PR: https://github.com/harvester/harvester-installer/pull/681

@albinsun Thanks for the detailed verification. I will add another PR to fix the harvester-eventrouter version upgrading.

@albinsun The PR https://github.com/harvester/harvester/pull/5591 was merged today. You may re-validate with a new daily-built ISO from 2024.04.18 which includes the fix, thanks.

Retest the upgrade (v1.2.1 -> v1.2-60f5c8a9-head) case, all 3 images uses expected version, close as fixed.
Thank you.
Environment

Harvester

Version: v1.2.1 -> v1.2-60f5c8a9-head
Profile: QEMU/KVM, single node (16C/32G/500G)
ui-source: Auto

Test Cases

Setup harvester v1.2.1

 Enable rancher-monitoring and rancher-logging addons

Check Grafana Dashboard and Login

 :green_circle: via Harvester

Sign-in
harvester#4756

 :green_circle: via Rancher

Login
harvester#4756

 Upgrade to v1.2-60f5c8a9-head

Check charts version and status

 :green_circle: rancher-monitoring is 103.0.3+up45.31.1

 :green_circle: rancher-logging should be 103.0.0+up3.17.10

 :green_circle: harvester-eventrouter should be v0.1.2

Check Grafana Dashboard and Login

 :green_circle:  via Harvester

 :green_circle: via Rancher


Can't list sessions when using -e

I have an alias set in my .bashrc as
alias abduco='abduco -e ^Qq'
because of this I can't list sessions anymore. Any workarounds?

Wow didn't expect a response this fast! Thank you


p4d instance not able to run job with pcluster 3.11.1

Issue: Job Stuck on p4d Compute Node
Required Information

AWS ParallelCluster Version: 3.11.1
Cluster Name: test-cluster
Region: eu-west-1

Cluster Configuration (Sensitive information omitted)
HeadNode:
  InstanceType: c5.large
  Networking:
    SubnetId: subnet-xxxxxxxxxx
    AdditionalSecurityGroups:
      - sg-xxxxxxxxxxxxxx
  LocalStorage:
    RootVolume:
      VolumeType: gp3
      Size: 200
  Iam:
    AdditionalIamPolicies:
      - Policy: arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore
      - Policy: arn:aws:iam::aws:policy/AmazonS3FullAccess
      - Policy: arn:aws:iam::aws:policy/AWSCloudFormationReadOnlyAccess
      - Policy: arn:aws:iam::xxxxxxxxxxxxxxxxxxx

Scheduling:
  Scheduler: slurm
  SlurmSettings:
    MungeKeySecretArn: xxxxxxxxxxxxx
  SlurmQueues:
    - Name: a100
      ComputeResources:
        - Name: p4d
          Instances:
            - InstanceType: p4d.24xlarge
          MinCount: 0
          MaxCount: 5
      Networking:
        SubnetIds:
          - subnet-xxxxxxxxxxxx
        AdditionalSecurityGroups:
          - sg-xxxxxxxxxxxxx
      ComputeSettings:
        LocalStorage:
          RootVolume:
            VolumeType: gp3
            Size: 200
      Iam:
        AdditionalIamPolicies:
          - Policy: arn:aws:iam::aws:policy/AWSCloudFormationReadOnlyAccess

Image:
  Os: alinux2023
  CustomAmi: ami-xxxxxxxxxxxxx

Bug Description
When attempting to run a job on any p4d compute node, the job becomes stuck in the Slurm status, remaining in a pending state until it times out and retries. This issue occurs even when no special boot scripts are configured. I also did not see anything special in the CloudWatch dashboard logs or on the machine itself.

Observation: The compute node launches successfully, with no immediate errors or unusual logs observed during startup.
Workaround: Replacing the p4d.24xlarge instance type with g5.24xlarge resolves the issue, indicating the problem may be specific to p4d instances.

Potential Cause
This issue may be connected to the increased configuration times introduced in version 3.11.1, as reported in GitHub issue #6479. The longer setup duration might be impacting the readiness or responsiveness of p4d compute nodes in Slurm, causing jobs to remain in a CF state.
Temporary Fix
Downgrading to AWS ParallelCluster version 3.10.1 resolves the issue, allowing jobs to run on p4d instances without getting stuck. This suggests that the issue may be related to changes introduced in version 3.11.1.
Steps to Reproduce

Configure a cluster with a p4d compute node, as shown in the provided YAML configuration.
Attempt to submit a job to the p4d node.
Observe that the job remains in the Slurm queue, ultimately timing out and retrying without successfully executing.

Expected Behavior
The job should execute on the p4d compute node without getting stuck in CF status.
Request
Are known issues with p4d instances on AWS ParallelCluster version 3.11.1 or specific configurations required to support job execution on p4d nodes?

Hi @QuintenSchrevens,
thank you for reporting this problem.
We are taking a look at it and will post an update here soon.
We observed that downgrading the NVIDIa drivers to version 535.183.01 solves the problem.
Would this be a viable solution for you?
Thank you.

Issue and mitigation: https://github.com/aws/aws-parallelcluster/issues/6571

It's failed due to Fabric Manager can not start. As it's a known issue of Nvidia driver 550.90.07 which we are currently using. We decide to upgrade Nvidia driver and Fabric Manger to the latest LTS version 550.127.08. We have tested it can resolve this issue. We will release it on PC 3.12.0.


Coerce use of 1.8.7-p371 with rvm: '1.8.7'

Recent Precise images do not have 1.8.7 pre-installed, so it needs to be
installed on the fly.
Unfortunately, copying the 1.8.7-p371 archive to 1.8.7 does not do the
trick, so we coerce the version to 1.8.7-p371 instead, so that RVM can
find and install it.

Before: https://staging.travis-ci.org/BanzaiMan/travis_staging_test/builds/528971#L131
After: https://staging.travis-ci.org/BanzaiMan/travis_staging_test/builds/528973#L128


Why doesn't changing RawSource at renderModuleContent work?

Bug report

What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.
before<EMAIL_ADDRESS>it can work
plugins: [
  compiler.hooks.compilation.tap("ncc", compilation => {
    compilation.moduleTemplates.javascript.hooks.render.tap('xxx', (moduleSource, module, options) => {
      if (moduleSource._value) {
         // do something with moduleSource._value, it can work
      }
    })
  })
]

at webpack5.0.0+, it doesn't work
plugins: [
  compiler.hooks.compilation.tap("ncc", compilation => {
    webpack.javascreipt.JavascriptModulesPlugin.getCompilationHooks(compilation).renderModuleContent.tap('xxx', (moduleSource, module, options) => {
      if (moduleSource._value) {
         // do something with moduleSource._value, it doesn't work
      }
    })
  })
]

Other relevant information:
webpack version:  5.0.0
Node.js version: 12.18.3
Operating System: windows
Additional tools:

Because it was changed, you don't provide context - what is the problem, why you change it and etc, so we can't help, sorry


Broken Links for Classes defined in an index.ts file

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[x] I have tried the npm run clear or yarn clear command.
[x] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
Currently running into the following build failure:
[ERROR] Unable to build website for locale en.
[ERROR] Error: Docusaurus found broken links!

Please check the pages of your site in the list below, and make sure you don't reference any path that does not exist.
Note: it's possible to ignore broken links with the 'onBrokenLinks' Docusaurus configuration, and let the build pass.

Exhaustive list of all broken links found:

On source page path = /dir/telemetry/modules/
   -> linking to .Config (resolved as: /dir/telemetry/classes/.Telemetry)

Telemetry is a class defined in the index folder of the telemetry package. I am able to access it on the doc site by using the URL postfix /dir/telemetry/classes/index.Telemetry. However, when other pages reference this class, they remove the index prefix, as seen in the broken link above.
Reproducible demo
No response
Steps to reproduce

Define an npm package with a /src directory.
Define index.ts and define a class in that index file.
Provide the package/src as the entrypoint to the docusaurus typedoc plugin.
Run docusaurus build.

Expected behavior
The link to the class in the documentation should contain index.{className}
Actual behavior
The link to the class in the documentation contains .{className}
Your environment

Public source code:
Public site URL:
Docusaurus version used: Docusaurus/core 2.3.1, docusaurus-plugin-typedoc 0.18.0
Environment name and version (e.g. Chrome 89, Node.js 16.4): Node.js 16.18.1 Typescript 4.8.3
Operating system and version (e.g. Ubuntu 20.04.2 LTS):

Self-service

[ ] I'd be willing to fix this bug myself.

Closing in favor of https://github.com/facebook/docusaurus/issues/8665


Add Setup environment actions

Add setup-environment-action to all jobs
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Sorry for the slow review, this looks good to me, I think standardizing on setup is a good idea. Once conflicts are resolved it should be good to merge

@damccorm Actually these changes are more than just standardization (lack of description for PR), I would say that it is a bonus to the actual intent. The purpose of adding the setup-environment-action action is to publish gradle snapshots - there is a baked-in gradle setup step that must be added to every workflow file.
Initially, I added the setup-environment-action step to the setup-action action in order to delay applying this change everywhere until we migrated all workflows. Now, it's time to move out this step from setup-action because they are about different meaning.


It lags out my VS installation

I got to a point where this extension would keep my CPU @ 25-50% not doing anything with my VS, and also lagging it out. Is it a known bug, or not?
After disabling the extension, everything work well again (it's a pure 2015 installation, without any extension or whatnot).

I take a project is loaded - can you share a repro / repro with a public project?

Yes, a project indeed is loaded, a somewhat large one. The repo unfortunately is private, and I cannot share it. I can definitely say the solution has over 100k LoC. Does the size of the solution matter in the performance of the extension?

Maybe, this is something we have to try to reproduce. Do you see any analyzer warning (RECSxxxx) appearing especially often? Not only the size might have an impact, but also how the project's code looks like.

I have a codebase which might be a suitable test case for you
svn clone https://svn.osgeo.org/mapguide/trunk/Tools/Maestro/
at revision 8704
and open Maestro\Maestro_All.sln
It's a 36-project solution
rev 8704 was the state of the code before I went on the great refactoring essentials cleanup job on it. Many VS crashes and crazy memory usage occurrences were had during my cleanup adventure.

Thank you for the hint! I see > 6000 warnings there, many of them from RE analyzers. I'll have a deeper look on that in the next days.

What I've seen with that Maestro project until now is that VS hangs completely when moving the mouse over a project (or the solution) name in Solution Explorer and scrolling through the list of analyzer findings appearing in a popup. I had to kill the process finally.
Apart from that I haven't seen any VS crashes, applying fixes (even batch fixes) also seemed to work.
@jumpinjackie Can you give an example of an applied fix or similar causing crashes or other weird behavior?

If it is on IDE side, we might consider opening up an issue in the Roslyn repo, area IDE.

We'll have to take into consideration the fact that maybe it's not entirely VS's fault.
@Rpinski, were you using RE when you were navigating the projects. If you were, have you tried disabling RE?

What exactly do you mean by "navigating the projects"? If a project has some analyzer warnings, it's underlined in Solution Explorer and a popup is shown on mouse hovering, where you see all warnings in this project. When scrolling through this list, at some point VS will simply stop responding.

Just noticed that the popups in Solution Explorer, which I have described, seem to be a feature of "Productivity Power Tools" extension. That's not regular VS.


Checks do not run on pull requests

@pastewka do you remember from the top of your head how the workflow files should look like ? They are a little different among the repositories

There is the same problem on "Adhesion"

@prs513rosewood solved this for https://github.com/libAtoms/matscipy here https://github.com/libAtoms/matscipy/pull/92 - I'll update the CI configuration accordingly.

Thank you !


How Can I Change Robot URDF?

I want to add my robot your sim. How can I do ?

This is not a simulator. You should first setup your robot in a simulator (For example gazebo: https://classic.gazebosim.org/tutorials).
After the simulation is fully function including navigating towards goals, you can look at using this package as a plugin for full coverage navigation.


chore: Update yarn.lock to match package.json changes

Closes #1162
📝 Description
This PR updates the yarn.lock file to reflect the changes made in the package.json files across various subdirectories.
⛳ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

No
📝 Additional Information

Codecov Report

Merging #1163 (3a45842) into main (23c4cc1) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main    #1163   +/-   ##
=======================================
  Coverage   75.85%   75.85%
=======================================
  Files         223      223
  Lines        3528     3528
  Branches     1114     1114
=======================================
  Hits         2676     2676
  Misses        841      841
  Partials       11       11


Verify the service instance APIs aligns with CF's definition

This is on the calls from a CLI to a service registry.
The cf calls:
   service                                Show service instance info
   create-service                         Create a service instance
   update-service                         Update a service instance
   delete-service                         Delete a service instance
   rename-service                         Rename a service instance

add unit testcases too


Workers being killed

I have many workers being killed and I am only at ~80 points per cycle. Running 1226 threads across 810km utilizing 130% cpu on a 6vCore server with 8GB RAM .. do I need to run less workers? It looks like each core is only at ~21% load but many workers are staying at 0%. Also how much RAM usage are you guys seeing with high amounts of workers?

I didn't have any problem with RAM usage (nearly 500MB for ~200 workers), but because of CPU usage I had to decrease number of workers on my VPS instance. But I figure out a temporary solution, it probably won't help you with workers being killed (anything interesting in log file?), but it may decrease CPU usage for you - https://github.com/modrzew/pokeminer/pull/100

nothing that I can see in the log file.. it all looks pretty normal. The area I am scanning is all metropolitan, disabling workers wont help.. but I am sure I will find this handy when I move on to the lakes and rivers.. thanks!

are you using the sqlite file? Might be that your database is slowing everything down

I have 66 workers at 25 points per cycle, when it starts it's using about 10~15% CPU (Web.py & Worker.py) but after a several hours later, the CPU goes upto 60% and I need to stop them and even sometimes restart my PC because it's so laggy

You will want to limit it to about 200-250 workers per running instance, if you need to use more, you may want to split the area between two copies of PokeMiner with their own configs, thats what I do currently and I'm running about 10 instances of 200 over most of the key areas of Florida.

@thappy 1226 workers?? are you scanning area 51? how the hell is it even possible to run that many workers without getting banned? didn´t mean that as an offense - but that´s really a lot! do all the worker requests come from the same IP?

And I thought 800 workers someone reported a few weeks ago was overkill.
All of you may be interested in what I've been doing in coroutines branch. I'm testing it locally right now, but from what I see it has reduced CPU usage due to lower number of threads, lower number of database connections, and various stability fixes.


Issue1482

Describe your changes :

Change entityName limit to 256 characters

Type of change :

[] Bug fix
[x] Improvement
[x] New feature
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have performed a self-review of my own.
[x] I have tagged my reviewers below.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

@harshach

@sureshms I think it will be better to have the name to be at 128 and FQN to 256. Any higher than that we will run into mysql index size issues and we need to accommodate FQN to contain the max length of name


updating your readme

Hello, Thank you for this package. I will probably need to understand your work to work on this tiket in the next few days. I suggest updating your readme file to explain in more detail how to use your project.

Hi, thanks for your work on Django and for your interest in this project. You can find more explanations in the project documentation, the readme file was only intended as a brief introduction.

great thanks for your work

👋 May I piggy-back this issue to ask you to throw a link to the docs somewhere, if you get the time? Maybe in GitHub's About section, if the README isn't a good place for it?

👋 May I piggy-back this issue to ask you to throw a link to the docs somewhere, if you get the time? Maybe in GitHub's About section, if the README isn't a good place for it?

yes indeed, I think it's a good idea. A link in the readme file to the documentation would be nice.


Unify the logic for defaultLineMode, placeholders and line-column mode

Now the following warnings are not covered by defaultLineMode:
[FILE_NAME_MATCH_CLASS] file name is incorrect - it should match with the class described in it if there is the only one class declared: GenericFunctionTest.kt vs ClassName, line=1, column=1


[virtual paging] Infinite loop on virtual paging issue

If you modify the pageSize to 5 in your virtual paging example (http://www.ag-grid.com/angular-grid-virtual-paging/virtualPaging.html) you'll have an infinite loop on getRows function.
Thanks

Up!
If the tutorial doesn't work, this grid is USELESS!
Thanks!

If you modify the pageSize to 5

-> don't modify the pageSize to 5!!
what's wrong with the tutorial?
this grid is USELESS!

-> go use anther grid then!

Why I cannot modify the page size??
Previously I said " if the tutorial doesn't work THEN the grid is useless"....

re page size, it comes down to maths.
if the pageSize is 5, and the maxPagesInCache is 2, then the total number of rows in the cache is 10 rows (5 x 2). so if your grid can display 40 rows on the screen (pretty normal) then your cache isn't big enough to hold one displayed set of data, thus the cache keeps trashing trying to load the rows.
the grid also renders some rows above and below the screen as a buffer (default is 20 each way) which you need to consider also.
so in summary, if you reduce the page size, you need to ensure you still have a cache size (pageSize x pagesInCache) big enough to hold enough rows to render your grid.

what do you mean by the tutorial doesn't work? what is wrong with it?

I tried the tutorial and sometimes I encountered an infinite-loop. Then I discovered that if set the pagesize to 5 the infinite-loop always occurs.
Tomorrow I will try to change the maxPagesInCache and I will send you a feedback.
Best regards,
Francesco

I tried the tutorial and sometimes I encountered an infinite-loop

the tutorial doesn't use server side paging, so the infinite loop must be something else???

I tried again the tutorial.
In my browser window I can see 36 rows at time, so if I put pageSize:36 I must put maxPagesInCache: 3 else there is a bad render rows. So the developer must know how many rows can be visible in the grid at time, BUT if you try to zoom out the page you will encounter in the same issue.

i wasn't programming with 'zoom out' in mind, so yes, virtual pagination breaks, if you zoom out far enough.

Ok, so in general the developer must know how many rows are visible before the grid is rendered...
Thanks for the support.

yup, that's so. i wasn't expecting the grid to grow in 'number of rows' at runtime.

tracked by https://github.com/ceolter/ag-grid/issues/554


mktime parameters depend on PHP version

is_dst
This parameter can be set to 1 if the time is during daylight savings time (DST), 0 if it is not, or -1 (the default) if it is unknown whether the time is within daylight savings time or not. If it's unknown, PHP tries to figure it out itself. This can cause unexpected (but not incorrect) results. Some times are invalid if DST is enabled on the system PHP is running on or is_dst is set to 1. If DST is enabled in e.g. 2:00, all times between 2:00 and 3:00 are invalid and mktime() returns an undefined (usually negative) value. Some systems (e.g. Solaris 8) enable DST at midnight so time 0:30 of the day when DST is enabled is evaluated as 23:30 of the previous day.
Note:
As of PHP 5.1.0, this parameter became deprecated. As a result, the new timezone handling features should be used instead.
Note:
This parameter has been removed in PHP 7.0.0.

Thx, good catch! Merging!


Feature/toolbar container

Adds the possibility to display the toolbar in a different location outside the editor container.

[ ] Fullsize mode is broken with a toolbar in different location


Backport "Make check flags for newMethod, newVal and newBind in Quotes API less restrictive" to LTS

Backports #18217 to the LTS branch.
PR submitted by the release tooling.
[skip ci]

No regressions detected in the community build up to lts-18723.
Reference


chore: remove Evm trait

PR Type
Enhancement

Description

Removed the Evm trait and replaced it with an Evm struct implemented using revm.
Added type aliases for external crate types from serde_json, ethers_core, and revm.
Introduced EvmInput struct for encapsulating EVM input data with methods for creation from various sources.
Introduced EvmExecutionResult struct for encapsulating EVM execution results with methods for checking success and failure.
Updated module imports and exports to reflect the new structure and removed the revm module.

Changes walkthrough 📝
Relevant filesEnhancement

alias.rsAdd type aliases for external crate types

src/alias.rs
Added type aliases for external crate types from serde_json, ethers_core, and revm.

+27/-0

evm.rsImplement Evm struct using revm and remove Evm trait

src/eth/executor/evm.rs
Removed Evm trait and EvmInput structure.  Implemented Evm struct using revm.  Added methods for EVM execution and session management.

+340/-160

evm_input.rsAdd EvmInput struct for EVM input data

src/eth/executor/evm_input.rs
Added EvmInput struct for encapsulating EVM input data.  Implemented methods for creating EvmInput from various sources.

+152/-0

evm_result.rsAdd EvmExecutionResult struct for EVM execution results

src/eth/executor/evm_result.rs
Added EvmExecutionResult struct for encapsulating EVM execution results.  Implemented methods for checking execution success and failure.

+23/-0

executor.rsReplace Revm with Evm in Evms struct

src/eth/executor/executor.rs

Replaced Revm with Evm in the Evms struct.

+1/-2

mod.rsUpdate module imports and exports for Evm changes

src/eth/executor/mod.rs
Added modules evm_input and evm_result.  Removed revm module.  Updated exports to include new modules.

+4/-4

revm.rsRemove revm module and its implementation

src/eth/executor/revm.rs

Removed the revm module and its implementation.

+0/-370

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

/describe


This is outside the scope of scratch-blocks

This is outside the scope of scratch-blocks
Originally posted by @BryceLTaylor in https://github.com/LLK/scratch-blocks/issues/2164#issuecomment-719003012

Sorry, I don't know what you mean. So I can't defined blocks by myself in scratch-blocks??

Please comment on the existing issue rather than creating a new issue.


Use debounce for onDimensionChange in withWindowDimensions HOC

cc @deetergp
Details
React native has a bug where it calls onDimensionChange callback with swapped dimensions for a very short time before it's called with correct dimensions. https://github.com/facebook/react-native/issues/29290
When this happens, a bug in react-navigation causes left menu to be positioned in the center instead of left side. We're fixing this issue by using debounce to prevent onDimensionChange callback from being called multiple times within 100ms to let react-navigation to complete its animations and positioning elements properly.
Fixed Issues
Fixes https://github.com/Expensify/Expensify.cash/issues/2180
Tests
Verified that left menu is not shown in the center when the app is loaded from background on iPad devices.
QA Steps

Launch App on iPad with iOS 12
Open any chat
Switch orientation of iPad from landscape to portrait
Switch orientation back to landscape
Tap on home button on iPAD to put app into the background
Open App from background
Observe that left menu is not shown in the center

Tested On

[X] Web
[X] Mobile Web
[X] Desktop
[X] iOS
[X] Android

Screenshots
iOS
https://user-images.githubusercontent.com/3853003/117861354-40103600-b289-11eb-9024-55490b5ccc79.mov

I think it'd be good to include a comment explaining why we're debouncing this (like you've explained in the issue) with a link to the react-native issue. Since this should be a temporary fix, it's good to have some context if we choose to remove this in the future because the bug is fixed.
Other than that, the changes look good to me, and I was able to test them as well, nice job!

Thanks for the review @jasperhuangg, added comments and updated the PR 👍

Great explanation! Thanks :)

🚀 Deployed to staging in version: 1.0.43-1🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production in version: 1.0.44-0🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


needsResize displays an unnecessary amount of decimal places in log

For lines 277-282 and 292-295, could use toFixed to display a lesser amount

Excellent idea, I'll change that.


fix panic on gogs webhook creation (#2675)

fix panic on gogs webhook creation
backport of #2675

LGTM

LGTM


Update grafana dashboard to current perf dashboard

PR Template:
Describe your changes

Exported grafana json model from current perf dashboard.
Successfully imported the dashboard into grafana to test!

Ticket reference (if applicable)
Fixes #
Checklist

[ ] Are the agreed upon acceptance criteria fulfilled?

[ ] Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

[ ] Do your changes have passing automated tests and sufficient observability?

[ ] Are the work steps you introduced repeatable by others, either through automation or documentation?

[ ] If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
[ ] An SOP (Standard Operating Procedure) was created

[ ] The Changes were automatically built, tested, and  - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

[ ] Are the agreed upon coding/architectural practices applied?

[ ] Are security needs fullfilled? (e.g. no internal URL)

[ ] Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

[ ] For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

/lgtm


Remove needless headers from qt/walletview.cpp

No symbols from the removed headers are used in the qt/walletview.cpp.
This is a small followup of https://github.com/bitcoin/bitcoin/pull/18027.

friendly ping @gwillen @Sjors :)

utACK, thanks for cleaning up after me. :-) (The Travis failure looks spurious.)

what about this one https://github.com/bitcoin-core/gui/blob/48f6637c4c8003e53334b60015a0e3532bb1c349/src/qt/walletview.cpp#L234

Updated 48f6637c4c8003e53334b60015a0e3532bb1c349 -> 4f9d9efb4e9afb1b012fca689ce77eb1d8d34f7d (pr11.01 -> pr11.02, diff):

addressed @MarcoFalke's comment


build: add hound config

Have you confirmed this works? I would try breaking one of our constructors..


[8.x] Change argument order of perMinues() rate limit method

I created the pull request (#36352) that introduced the perMinutes() rate limit method, to allow greater specificity than the existing rate limit methods allowed. Somehow, during the merge process, it seems like a commit (86d0a5c733b3f22ae2353df538e07605963c3052) was introduced that swapped the order of the arguments.
As a result, the behavior of perMinutes() differs from that of the previously existing methods, perMinute(), perDay() and perHour(). Perhaps I'm missing something obvious here but it seems like the argument order for perMinutes() should match that of the other rate limit methods. This PR changes the order of the arguments so that they match.
As a matter of example, my application had the following code to rate limiting a job to run a maximum of once every 30 minutes:
return Limit::perHour(1, 0.50);

After the perMinutes() method was introduced, I expected to be able to change my code as such:
return Limit::perMinutes(1, 30);

This is a major breaking change.

Yea, you're right. Can we PR this to 9.x instead? And if it's gonna be a breaking change anyway, it would probably make sense to get rid of this new perMinutes() method entirely and simply allow the perMinute() method to accept a minutes argument (making it similar in both naming convention and style) to perHour() and perDay().

We also have to decide if the change is worth it. Upgrading is hard because people probably won't notice this change, since nothing obviously breaks.

Understood. My fear is that people will, naturally I think, assume that perMinutes() has the same argument order as perHour() and perDay(). When I changed my code from perHour() to perMinutes(), I was bit by the swapped argument order and instead of having my job run 1 time every 30 minutes, it was able to run 30 times every 1 minute. A huge difference, obviously.
I'm still confused as to how the arguments got swapped in the first place honestly, but the end result is an inconsistent developer experience with real consequences.
I suppose another option is to keep perMinutes() as is, and introduce the breaking change in 9.x to make perMinute() consistent with perHour() and perDay().
Anyway, I'm happy to alter this PR however people agree is best - if at all.

I think the current order is fine. I believe I may have even changed it. To me it reads naturally say perMinutes(NUMBER_OF_MINUTES... ... since I just said "per minutes" I expect to specify how many minutes first, and then how many requests can take place within that number of minutes.