hang in glz::beve_to_json

The binary_reflection.cpp fuzzer finds this input, where it hangs at line 27: https://github.com/stephenberry/glaze/blob/6115adf616413b6f8b82d3ecb449016cee901ed8/fuzzing/binary_reflection.cpp#L27
base64:
VSYAAGUAPdJVPdI=

or as a c array:
unsigned char oops[] = {
  0x55, 0x26, 0x00, 0x00, 0x65, 0x00, 0x3d, 0xd2, 0x55, 0x3d, 0xd2
};

According to the documentation, beve is supposed to be safe for untrusted input.

Thanks for reporting this. Will look at this next week.

Fixed. Revealed a missing error handling line.


settings: refactor code to hide "Email Change" button.

Follow up of commit 664153f

Automated message from Dropbox CLA bot
@jajodiaraghav, it looks like you've already signed the Dropbox CLA. Thanks!

@jajodiaraghav can you add an explanation to the commit message of why this change is an improvement?  I understand because I know the context, but others may not, and the commit messages are a record for history that may be useful in a couple years, so it's worth taking the time to explain your reasoning.

@timabbott I guess this can now be merged. :)

Merged, thanks @jajodiaraghav!


ClonalArchitecture

Project short name:
ClonalArchitecture
Primary Wrangler:
@ESapenaVentura
Secondary Wrangler:
TBD

Associated files:

Google Drive: https://drive.google.com/drive/u/0/folders/1_4bBKAi2RF2oPQI0K-1JAl58pyFYGOIb
Preprint: https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>1762v2

Key Events

[x] Send initial instructions about contributing, including questionnaire and T&Cs
[x] Receive project questionnaire
[x] Assign the Primary Wrangler
[ ] Receive T&C form filled out by at least 1 representative of group/project
[ ] Send custom metadata template spreadsheet, how-to guide and directions for submitting data, matrix and cell annotation files.
[x] Receive spreadsheet (to a sufficient standard to submit dataset)
[x] Receive data, matrix and cell annotation files (to a sufficient standard to submit dataset)
[ ] Curate metadata spreadsheet with ontologies
[x] Upload sheet to validate metadata
[x] Run graph validator & Check linking
[ ] Validate data files
[ ] Ask the Secondary Wrangler for an end-to-end review of the project. Ask the Expertise Wrangler to review specific tabs if needed
[ ] Get final approval of submission from the contributor including release date, metadata spreadsheet and data files
[ ] Submit to production and inform ingest-devs the project is ready for archiving
[ ] Complete the Export SOP
[ ] Convert project data to SCEA format following the SCEA conversion SOP if appropriate

Please track the below as well as the key events:

Track date first spreadsheet received and final spreadsheet sent by editing ticket to include
date next to event.
Track spreadsheet iterations by placing asterisks next to receive spreadsheet event.
Track any metadata issues/tickets made for dataset with a bulleted list of links under
received spreadsheet event. Links should be to the ticket in the metadata repo.

Asked for a deadline for the dataset and to fill out the consent form - Waiting on the reply

Cecilia asked if we could archive to ArrayExpress - which is not part of our usual process (it's very manual) - and we have informed them as such.
We now have tools like the direct archiving script which should speed up archiving to ENA / BioSamples. We should archive to them if possible - unless contributors have a specific issue with it.

Enrique is working on this.

Asked for a sequencing run --> sequencing instrument map

@ESapenaVentura might move this to secondary review

Dataset is ready for secondary review
For the reviewer, just a couple of small notes:

Green tabs: I think I got most of the metadata available
Yellow tabs: I am pretty sure I am missing something (e.g. sequencing protocols and their linkings to the files), so please be very aware when reviewing this!

Still missing some information from Cecilia.

Hi @ESapenaVentura this looks good to me! I am highlighting mostly nitty gritty details, and also I need to ask you on slack about the experiment design..the extra sample types and pooling isn't clear to me from the preprint.
General

Multiple ontology fields are missing. I think this is because the latest metadata file got corrupted and you plan to add these soon.

Some of the protocol descriptions are in the format of instructions, unlike the past tense. I think it would be good to aim to keep the protocol descriptions consistent in format within and between projects.

Project

PRJEB51634 can be added to the field project.insdc_study_accessions

Collection Method

other_organ_collection description: Is the location they provide for each organ type included in the organ part metadata in the specimen from organism tab? It looks like some regional info. is missing and could be useful e.g. left lower lobe of the lung, right lobe of the liver.

other_organ_collection: I think include "via/from the Cambridge Biorepository for Translational Medicine (CBTM)".

Maybe rename the method from "other_organ_collection" to "solid_tissue_collection" or "solid_tissue_collection_from_organs".

Donor organism

Is the BMI not indicated because it is given as a range of values in the preprint (which I think the hca metadata schema might not support just yet)?

For this kind of study, the days in hospital is probably useful as a time-course value and unit (provided in the preprint donor metadata table).

Can Smoking be added as Y/N/unknown? (provided in the donor table). It doesn't follow the example format, but I seem to remember filling this before as only "smoker" or "non-smoker". TBD based on donor metadata schema.

Specimen from organism

The disease field is not filled.

Dissociation protocol

macs_dissociation is a joint mechanical/enzymatic dissociation method. It isn't  magnetic affinity cell sorting. It should be 2 protocol types: mechanical and enzymatic.

The following is missing from the beginning of the blood_enzymatic_dissociation description: "Bone marrow aspirates and blood samples were diluted 1:1 with PBS and layered directly onto ficoll for mononuclear cell isolation." The included description isn't clear when this piece of information missing.

After the first 2 dissociation protocols, I don't see the descriptions for the following protocols in the paper. They seem to be alternative methods to the macs_dissociation method. Where did you get this information?

Enrichment protocol

70_um_strainer: 70um should be the maximum size selected as opposed to minimum size selected

After the first 2 dissociation protocols, I don't see the descriptions for the following protocols in the paper. They seem to be alternative methods to the macs_dissociation method. Where did you get this information?

Cell suspension

About the pooling of specimens "taken from mixed tissues" and the combination of protocols for some specimens: I will message you on slack, assuming you got this from a public db or the authors as I don't see it in the paper!

Library preparation protocol
Sequencing protocol

Cellranger software (version 3.0.2, 10x Genomics Inc.) could be added.

Sequence file

The sequencing protocol ids are missing.

Analysis file

Some fields are missing. I think maybe they had been included in the latest corrupted file you mentioned? examples: content description, library prep protocol, sequencing protocol.

It will be a really nice study to add this next data release :)

Cecilia is very busy to send what we need. Might be worth sending an email to a contact in Sanger for the sequencing instrument mapping. @Wkt8 to provide email to @ESapenaVentura

Could try to email Elena Prigmore<EMAIL_ADDRESS>

@ESapenaVentura there is now a peer reviewed publication for this project. It might answer or provide the information you need.
https://www.science.org/doi/10.1126/science.abl5197

@ESapenaVentura
Seems to have been published in DCP by UCSC.
https://contribute.data.humancellatlas.org/projects/detail?uuid=04e4292c-f62f-4098-ae9b-fd69ae002a90&tab=project
The pre-print is not captured anywhere though. I think they might have edited your Ingest entry for it. Cause for whatever reason is not picking up the DOI. I believe they have added posteriorly. We might need to file a bug for that as it should not be like that.
This ticket can probably be closed

Closing as it was already pushed to DCP


I'm new to deep learning，I have completed the basic tutorial and seen the results of the backtest，But when I use a model to make a prediction, I can't always predict the outcome of the current time or the outcome of the previous day. What should I do?

I ran my code at 4pm on May 11th，My data is up to May 11th

I don't understand. If I can only predict the previous day's data, how can I apply it to reality

Could you please check what it means by "prediction" here?   Usually, an agents's output is "actions", say "buy or sell #shares".

I'm not familiar with many of the terms of deep learning, so I'll try to be more clear and hopefully help me out，df_account_value,df_actions = DRLAgent.DRL_prediction(model=trained_ddpg,environment=e_trade_gym)，When I use this method，The df_action I output has only the previous day and no data for the current day，For example：When I used the model to output actions on the night of May 11, my data contained data from May 11, but I could only output actions for May 10

Would you like to check the calendar?  Sometimes it may be not in your time zone.

I found the reason. I tested it on China's a shares. It shows the date of the previous day, but its corresponding action is current


feat: added buildAuthorizeUrl and buildLogoutUrl from auth0-spa-js

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Added in the buildAuthorizeUrl and buildLogoutUrl which were both in the https://github.com/auth0/auth0-spa-js repo. This helps with projects that need more management over the browser client eg. Ionic using capacitor requires a native "Browser" plugin to do redirects in app.
References
Related PRs from the spa-js repo: https://github.com/auth0/auth0-spa-js/pull/280, https://github.com/auth0/auth0-spa-js/pull/595
Testing
Added to the auth-provider.test.tsx unit tests a couple of noop tests for coverage that just make sure the call is passed through to the Auth0Client similar to a couple of other tests. I looked at cypress but it seems there is just a bare bones smoke test so didn't feel this needed the full treatment of getting the strings. Let me know if you would like them added

[x] This change adds test coverage for new/changed/fixed functionality

Checklist

[ ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[ ] All active GitHub checks for tests, formatting, and security are passing
[ ] The correct base branch is being used, if not master

Thanks @THISS!

I was literally just opening a feature request to expose the logout URL, and I was growing increasingly confused why I could see this capability on GitHub, but not in my IDE. Imagine my surprise that it was added within the last 24 hours.
Thanks for this! Putting it to use already in a Shopify app, which runs inside an iframe and therefore can't just call logout(). 🙌

Release in https://github.com/auth0/auth0-react/releases/tag/v1.3.0


Migrate from local storage to chrome storage

I've noticed the extension uses local storage to store the configuration. We could use https://developer.chrome.com/apps/storage instead to keep the configuration synced onto different computers logged into the same google account.

I wouldn't want to have my browser data synced across (home and work) devices, nor do I use Google Chrome account.

Although that is good point for those who value privacy and security some others might not want that or care about extension data synced between their devices, some like the idea or possibility.
Maybe it could be something added to the configuration ? On the client view, an option to sync to their Google Account.
As a side note, if you do not want your data to be synced across devices you can change those settings yourself here : chrome://settings/syncSetup.
To be more specific, this issue isn't about sharing browser data such as private history or passwords or anything that affects personal privacy. This is about storing the configuration of your extension, so that someone that is at work or at home won't have to reconfigure every time.

Good point; If it's an option like in uBlock.

Thanks for creating this issue. I was thinking about it but then kind of forgot it... I'll look into adding this with an option to sync it or not in the options for a future version. I am currently working on a settings page to manage white lists, black lists and other settings.


Question: How to disable sampling on all applications

Hello!
We have this code snippet:
public class ConfigurableSamplingTelemetryInitializer : ITelemetryInitializer
{
    public void Initialize(ITelemetry telemetry)
    {
        // TL: Copied from https://learn.microsoft.com/en-us/azure/azure-monitor/app/sampling?tabs=net-core-new
        if (telemetry.Context.IsSamplingDisabled() && telemetry is ISupportSampling supportSamplingTelemetry)
        {
            supportSamplingTelemetry.SamplingPercentage = 100;
        }
    }
}

Which allow us to disable sampling depending on various factors.
However, our dependencies still seem to be sampling and we usually end up with in complete tracking.
How can I make sure all telemetry and "child" telemetry across several applications do not sample this specific telemetry?
Is is possible?

The initializers are run for all telemetry, including dependency. Means this approach is valid for dependencytelemetry as well. If you observe otherwise, could you share a minimal repro app?


Make Tags more prominent

Describe the feature you'd like
Show Tags more prominently. There are multiple different places, either below the details in the right bar, or below the search in the left bar (as a collapsible perhaps)
A tagpill could just be a link to the exisiting search with the tag selected.
Describe the benefits this feature would bring to BookStack users
This would allow for a more useful usage of tags, since there is no overview as proposed in #1354
Additional context
#2829 would also greatly enhance the tagging feature.

Hi @newhinton,
Tags are already displayed in the top-left of a book/chapter/page/shelf view, and clicking on them does start a search as per your request. I wouldn't really want to repeat their display within the same view. Or have I misunderstood this request?

 At first i misunderstood how tags work. I assumed tags would always show up, regardless of 'type'.
Maybe it makes sense to show tags recursively, so that all tags that are present in a book show up on the left when a book is selected, not only 'book'-tags. (And the same for chapters and shelfes)
This way a user could quickly get a selection of a certain topic, without having to find an actual page with the tag.

Okay. I'm not sure on the value of showing all tags applied to child content. Would need to be a click away anyway since it'd otherwise get messy, and think it'll more likely cause confusion than provide assistance, especially since this is the first request I've seen for such tag behaviour.

the "issue" i have is that i dont know what tags are in use, so that i cant really use it to filter for them. It's basically a context dependend version of the page requested here: #1354

this could use the book/page/chapter color instead of the primary-color, and/or use a separation-header to clear it up.
I may be wrong, but besides knowing tags or searching for them, there is no way to actually know which tags are in use, which makes them hard to use.
Also i dont think that it would have to be "a click away" is a bad thing, since its purpose is to give the user an overview, not necessary to get the user to the intended target. It's basically an even more slimed down version of the linked closed pr

Okay. The whole use-case and benefits described here revolve around understanding existing use of tags hence I'd consider this to overlap with the existing issue #738. I'll update that to reference your potential implementation above and therefore close this off.


⚠ Bofrost.lu has degraded performance

In 3192348, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1665 ms

Resolved: Bofrost.lu performance has improved in 2606415 after 6 minutes.


Needed information missing

I'm just posting this here in hopes of saving the next person hours of wasted time.
This plugin requires information that there is no way to get: ProductKey or ProductId (it uses different terms in different places), gwId, and the IP address, which it's easy to get if you only have one single device, but if you have more than one, there doesn't appear to be any way to figure out which device IDs correspond to which actual devices and hence to which IP addresses.
I've looked all over the place. I'm assuming the missing IP addresses, or an incorrect gwId or productKey, are why this plugin doesn't work, but several hours of online research has not revealed any way to get any of this information with any specificity.
The frustrating thing is this appears to be the only plugin that doesn't incorrectly expose color temperature and RGB at the same time, which causes Home.app presets to display colors incorrectly for Tuya bulbs, otherwise I wouldn't have spent hours trying to figure out how to get the undocumented and apparently unobtainable information to make it work.

I am in the same boat. The lack of consistency with the terms is an issue for me as well. Following the setup guide, I was able to get an ID and key, but I'm not sure which of the four devId/localKey/gwId/productKey they tie to.  After googling, I have seen several posts about the devid & gwid being the same and localKey & productkey being the same. I tried this, but it did not work for me. Were you able to solve this issue?

I am in the same boat. The lack of consistency with the terms is an issue for me as well. Following the setup guide, I was able to get an ID and key, but I'm not sure which of the four devId/localKey/gwId/productKey they tie to.  After googling, I have seen several posts about the devid & gwid being the same and localKey & productkey being the same. I tried this, but it did not work for me. Were you able to solve this issue?

@jaymathew @ApopheniaPays I seem to have figured out where to get these keys.
When you go to the iot page as described to setting it up, you can click Device List, List it based on account, select your account id, change to your country and it can show your devices.


Request time does not take into account connection creation

Reported in https://line-armeria.slack.com/archives/C1NGPBUH2/p1574122806097100
I believe this is a regression after moving Endpoint selection to the begging of the request. We call startRequest only when about to send the request, but not anymore. This is affecting spans, but I think it also affects our totalDuration metric equally.

To some extent, where we start and stop the request timing is up to us - but especially since we have the wire annotations now, it seems fine to me to have the total span duration match the invocation of the stub method (I guess basically invoke() -> completionFuture()). A good enough approximation I'm seeing is to just set the start time when a ClientRequestContext is constructed.

+1 for setting the start time when the context is constructed

It might be great timing to reconsider the RequestLog API - I find the RequestLogAvailability to be so fine-grained that it's fairly hard to understand, and it makes working with logs (e.g., adding a new logged metric) in Armeria very tedious. I wonder how many people need any availability other than Complete - I think log usually ends up being processed / stored into something after a request has finished in most (all?) use cases. With the brave sampler integration, I think we found that the availability didn't really matter and was making the code more complicated when it just needed to either have the information if already available or skip it. Any thoughts? Should we open another issue?

So - any thoughts on the change to the logging API regards to availability setting? :) @trustin @minwoox @ikhoon

Sorry, missed your comment. How about assuming COMPLETE when a user specified no availabilities? That would be less confusing I guess.

@trustin I find it more difficult to actually log things, since it involves figuring out or making a new availability (which are technically not infinite with the current implementation using a bitset). I think your suggestion is referring to consuming logs, but I'm more concerned about adding logs.
For this issue, right now, we have REQUEST_START which contains the start time, channel, and other bits, so if we want to change the timing of when we log requestStartTimeMillis, it's very tedious due to the coupling. It was similar when adding the firstBytesTransferred metrics. I'm not sure the value add of these availabilities is enough to warrant it being so difficult to add logging.

I agree that having too fine-grained availability is bad, but I'm not sure about 'how fine-grained' we need go.  Just having COMPLETE doesn't sound like a good idea, either, because some will want to reduce the latency between the actual event and notification. Do you have some specific suggestions for simplification? I did a quick look and it seems to me that SCHEME maybe can be merged into REQUEST_HEADERS, but that's all?

Looking at the usage in the Armeria codebase, COMPLETE seems to be used the most. I do see a use case for REQUEST_END since there could be services that last a long time between getting a request and finishing, but really don't see much utility for e.g., splitting the notification for even headers / content, for example. We have some listeners that export to metrics but metrics are averaged anyways and don't benefit from such fine-grained notification.
That being said, I realized the opposite idea may make sense too - make availability extremely fine grained by having one for each piece of data that's recorded. Then, adding a new metric is just adding to an enum and saving to the field. Users could have immediate notifications for the data they're interested in, or keep things simple by just listening for completion (we store the listeners with an EnumMap). The bit arithmetic of the current availability goes away along with the coupling that currently can make tweaking things difficult. If that sounds ok, I think it'd help a lot.

Unless we're going to add more than 64 event types, that's basically hiding bit arithmetic into EnumMap. I think we will soon use int or long as an internal representation of listener's interest when we optimize things, i.e. bit arithmetic is inevitable, although we can simplify it.
I agree that having an enum value for each field and removing getter/setter flags will simplify our code a lot, without making too big breaking change, if we can let users add coarse grained listeners, such as for REQUEST/RESPONSE_END and COMPLETE availability.
Thoughts? @minwoox @ikhoon

How about providing a new API like onRequestLogComplete(...) to RequestContext or RequestLog?
I really wanted to get rid of every availability when I saw this code from the user:
ctx.log().addListener(log -> {
    // Log request and response content.
, RequestLogAvailability.REQUEST_CONTENT, RequestLogAvailability.RESPONSE_CONTENT);

Of course, this works as expected, but he could just use RequestLogAvailability.COMPLETE without much worrying about what kinna availability he had to use.
However, there should be others who want to reduce the latency between the actual event and notification. I used RequestLogAvailability.REQUEST_HEADERS in RetryingClient to decide to retry as soon as possible. I think REQUEST_HEADERS and RESPONSE_HEADERS are needed especially when streaming requests and responses.
Therefore, I think it's good if we provide a simple API for most of the users and fine-grained APIs for advanced users so that the APIs are separated and most of the users would not worry about RequestLogAvailability because they wouldn't use it.
For the EnumMap, if it simplifies our APIs, there's no reason to be against it.

I think we agree there's some simplification we can do. If it's ok, let me play around with this by switching to field-level availability with some coarse-grained callbacks, and see how things turn out.

OK. Thanks for looking into this, @anuraaga!

@anuraaga Are you working on this? I'm thinking of adding RequestLog.name to resolve https://github.com/line/armeria/issues/1931, so I might need simplification.

Hi sorry - I have a WIP let me finish it up around tomorrow

I have been thinking about simplification this week and thought perhaps we can reduce the granularity to:

REQUEST_IDENTIFIED

Basically when we can build a correct meter ID for metric collection, e.g. request name (or RPC method name) has been determined.

REQUEST_END
RESPONSE_END
COMPLETE

.. because there has not been any use case reported so far.

Hi sorry - I have a WIP let me finish it up around tomorrow

No worries. Please take your time. I will look into other issues. :wink:


Merge to publish.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/sparklinegroup-object-excel.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/working-with-content-controls.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/sparklinegroup-object-excel.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/working-with-content-controls.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Web interface don't working

After installation of ledfx, i execute ledfx --open-ui but it does not work. I don't understand. I am in windows 10 with anaconda

Hey mate,
Can I please point you to the readme on: https://github.com/ahodges9/LedFx/tree/dev & https://ledfx.readthedocs.io/en/docs/index.html
Can I ask you to try the LedFx Exe version 0.0.3: https://ledfx.app/download/
Your welcome to join the developers on LedFx Discord: https://discord.com/invite/wJ755dY

thank you it's work, but now i can't add device in ledfx

Can you send a screenshot of what you are experiencing?
Under device management, add device button, do you get a popup?

In the config the ip was simply not <IP_ADDRESS>


number.victron_vebus_l1_acpowersetpoint_239 can only be changed in steps of 100

Is this a feature or can I control the Victron Multiplus in more granular way?

You can set any value you want via automations or service calls.
For simplicity the sliders use a 100watt step range.
An enhancement request that might also address your request is: #57

@mroggi does the latest release address your feature request?

Yes, thank you!

Closing as complete


Updated API part of README somewhat

The API component of the README was missing display_activations and display_heatmaps and was missing the layer_name parameter to get_activations. I'm not sure if the other parts of it are also in need of attention but get_activations, display_activations and display_heatmaps are the only part of keract that I'm familiar with

Looks really great! Thanks a lot @qwertpi :)


Fixed mapviews graph alignment

Just the alignment :(

retest this please

Frontend tests were OK :+1: (details)


Create Get-TeamTargetingHierarchyStatus.md

Docs Build status updates of commit 3563b95:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-TeamTargetingHierarchyStatus.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

If you have a Microsoft alias, you can link your accounts in GitHub so that a blue "Microsoft submitter" label appears to any PR's or issue you submit. Guidance on it here: https://docs.opensource.microsoft.com/tools/github/index.html
Here is the site you can use to see the mappings between GitHub and Microsoft aliases: https://repos.opensource.microsoft.com/people?q=ayrtonsoftware

@ayrtonsoftware

Gentle reminder @ayrtonsoftware Please implement the suggestions. Thanks

@Kateyanne Please help.

@ayrtonsoftware please review the comments and implement the suggestions. Then we can push this to live.


feat: Bunyan introduction

As per title.
Contributes to: camelotls/actions-jira-integration#
Signed-off-by: Stelios Gkiokas<EMAIL_ADDRESS>

Will reopen after fixing the package-lock.json issues.


Hide Tab On Sub Pages, Please!

I am in the process of developing an multilayered application which requires tab inside tab inside tab and so on for at least 5 layers, and wasn't impressed with ion-tabs appearance and no swipe feature, and thought of using super tabs, but super-tabs has no remedy to use the above mentioned, and I'm not inclined to use the CSS display: none and block, so can you please add the HideTabsOnSubPage=true feature, Since the new Version(4.1.5) has some bug for not displaying the tabs properly, can you please implement the above feature also.
Thanks in Advance,
Regards.

So Sorry, The issue was with my architecture, Fixed it, Don't need the hideTabsonSubPage Thank You Anyways!

Hi, Is there any way to fix it? Facing the same issue

2 things, the navcontroller is a bit fishy, each page has a separate navcontroller, Google about navcontroller to know more, what you need to do is access the rootnavcontroller of the starting page, let's say dashboard page, and push tabspages to it
2nd thing. You can't have one tabs page, and dynamically change it whenever, you need to have separate tabs page for wherever it's required..

@lightyaer So How can we navigate back to the previous menu? this.naVctrl.pop(),this.naVctrl.parent.parent.popToRoot() is not working

Access the root nav controller by using app(lib in ionic-angular ) in the constructor in each page and just do push or pop to it

Can you share the code please?


python-docx: init at 0.8.6

Motivation for this change
This library is a required dependency for something I need to build.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python3.pkgs.python-docx

Failure on x86_64-linux (full log)
Attempted: python3.pkgs.python-docx
Partial log (click to expand)
Reading https://pypi.python.org/simple/pytest/
Download error on https://pypi.python.org/simple/pytest/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'pytest' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for pytest
error: Could not find suitable distribution for Requirement.parse('pytest')
builder for '/nix/store/dimjbvxwszqizm73l14wprfhcg6akls6-python3.6-python-docx-0.8.6.drv' failed with exit code 1
error: build of '/nix/store/dimjbvxwszqizm73l14wprfhcg6akls6-python3.6-python-docx-0.8.6.drv' failed

Failure on aarch64-linux (full log)
Attempted: python3.pkgs.python-docx
Partial log (click to expand)
Reading https://pypi.python.org/simple/pytest/
Download error on https://pypi.python.org/simple/pytest/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'pytest' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for pytest
error: Could not find suitable distribution for Requirement.parse('pytest')
builder for '/nix/store/dwp9vg65yjwsxw4qsr2kdgg8hqac5rq3-python3.6-python-docx-0.8.6.drv' failed with exit code 1
error: build of '/nix/store/dwp9vg65yjwsxw4qsr2kdgg8hqac5rq3-python3.6-python-docx-0.8.6.drv' failed

Success on x86_64-darwin (full log)
Attempted: python3.pkgs.python-docx
Partial log (click to expand)
reading manifest file 'python_docx.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'python_docx.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/4vbr4mknj177smwa1zp4frs54syj62fv-python3.6-python-docx-0.8.6

Test dependencies are missing.

I may have fixed these, not sure if my nix.useSandbox = true is working...

@GrahamcOfBorg build python3.pkgs.python-docx

Ok @FRidh, I think I have it working now.

@GrahamcOfBorg build python3.pkgs.python-docx

Success on aarch64-linux (full log)
Attempted: python3.pkgs.python-docx
Partial log (click to expand)
reading manifest file 'python_docx.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'python_docx.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.002s

OK
/nix/store/yb8p86g2j1qhh5r80a1fmkhpfh2vgki5-python3.6-python-docx-0.8.6

Success on x86_64-linux (full log)
Attempted: python3.pkgs.python-docx
Partial log (click to expand)
reading manifest file 'python_docx.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'python_docx.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/hv5qp66hvnh0k9nwzxny6siiwanznc81-python3.6-python-docx-0.8.6

Ran 0 tests in 0.000s

Please specify an appropriate checkPhase, e.g.
checkPhase = ''
  py.test
'';

checkPhase added, dependencies updated, commits squashed, and commit message updated. Thanks for the thorough review!

@GrahamcOfBorg build python2.pkgs.python-docx python3.pkgs.python-docx

Success on x86_64-linux (full log)
Attempted: python2.pkgs.python-docx, python3.pkgs.python-docx
Partial log (click to expand)

=============================== warnings summary ===============================
tests/styles/test_styles.py::DescribeStyles::()::it_can_get_a_style_by_id[getitem_id_fixture0]
  /build/python-docx-0.8.6/docx/styles/styles.py:54: UserWarning: style lookup by style_id is deprecated. Use style name as key instead.
    warn(msg, UserWarning)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
=================== 1354 passed, 1 warnings in 5.45 seconds ====================
/nix/store/k2prjffaa6kggi2sskgncy1l059pwi9x-python2.7-python-docx-0.8.6
/nix/store/dnqkqpmz84zws4ysb1fw7ja86lspbdj9-python3.6-python-docx-0.8.6

Success on aarch64-linux (full log)
Attempted: python2.pkgs.python-docx, python3.pkgs.python-docx
Partial log (click to expand)

=============================== warnings summary ===============================
tests/styles/test_styles.py::DescribeStyles::()::it_can_get_a_style_by_id[getitem_id_fixture0]
  /build/python-docx-0.8.6/docx/styles/styles.py:54: UserWarning: style lookup by style_id is deprecated. Use style name as key instead.
    warn(msg, UserWarning)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
=================== 1354 passed, 1 warnings in 38.85 seconds ===================
/nix/store/aiphsx26j5xzg5r4v83xld7np6qpj65k-python2.7-python-docx-0.8.6
/nix/store/i3nr5wlvyzzbpq7i7fz53wn24fjpxxbg-python3.6-python-docx-0.8.6


Can we (optionally) remove the stack prop from serialized error?

Guidelines

[X] Please search other issues to make sure this feature has not already been requested.

Which problem is this feature request solving?
When serializing an error to prepare it for API response, I'd like the response to the client NOT to include the stack information of said error
Describe the solution you'd like
optionally also removing stack in afterSerialize
Plugin options or even invocation options could somehow be derived in serializeValue
Pull request (optional)

[X] I can submit a pull request.

Hi @benkroeger,
Great idea! You can now use the {exclude: ['stack']} option to achieve this.
const ExampleError = BaseError.subclass('ExampleError', {
  serialize: { exclude: ['stack'] },
})
const error = new ExampleError('example')

const errorObject = ExampleError.serialize(error)
console.log(errorObject.stack) // undefined
console.log(errorObject) // { name: 'Error', message: 'example' }

Please check out the release notes of 6.1.0 for more details.

@all-contributors Could you please add @benkroeger for ideas?


cmd: deletefile command - fixes #2286

I think that's it. Please let me know if that's what you had in mind and if there are any changes or additions required.

That looks perfect - thanks :-)


Feature request - add new settings parameter for local packages folder

Add in settings.json a new parameter (es local.packageSources) where specify local packages' folder
Here and example of implementation:
"nugetpackagemanagergui.nuget.local.packageSources": [
    "/mnt/local/nuget/packages"
],

Any news?

Question:     Development is dead??
It's long long time that no updates are released.

Hi @CyberGuerro,
Apologies for the delayed response—I haven’t been able to check GitHub. I’ve completed the feature and will include it in the next release.
Thank you for your patience!


[FEATURE] JRTB-2: add telegram bot to the project

Create stub telegram-bot for the project.
Acceptance criteria:

stub answer via telegram-bot added to the project

added in #16 and #17


[volsync integration] remove "create" and possibly "patch" volumesnapshot permissions from dr-cluster

the VRG (dr-cluster) clusterrole currently allows permission to create & patch volumesnapshots.  Ramen should not be creating any volumesnapshots directly (VolSync does this), so this permission can probably be removed.

/assign @tesshuflower


Consider using Flyover Maps

The MKMapTypeSatellite map type has basically been abandoned by Apple and has low quality and old imagery. In fact in iOS 9 Apple only uses MKMapTypeStandard /MKMapTypeSatelliteFlyover/MKMapTypeHybridFlyover in their Apple Maps app.
I'd suggest using these map types if user is iOS 9 or above.

Now added. I close.
Thanks for your suggestion !


Using attr_encrypted consumes a db connection from the connection_pool indefinitely

Environment
Provide at least:

Ruby Version: 2.4.6
Symmetric Encryption Version: 4.3.0
Application/framework names and versions (e.g. Rails, Sinatra, Puma, etc.): Rails <IP_ADDRESS>

I am running into an issue where including
attr_encrypted :column_name

in one of my models results in the rails server starting with an open connection to the database. This means that when trying to make a request from the browser, the following exception is raised:
Rails -- Exception: ActiveRecord::ConnectionTimeoutError: could not obtain a database connection within 5.000 seconds (waited 5.000 seconds)
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:189:in `block in wait_poll'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:180:in `loop'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:180:in `wait_poll'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:135:in `block in poll'
/home/vagrant/.rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/monitor.rb:214:in `mon_synchronize'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:145:in `synchronize'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:133:in `poll'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:425:in `acquire_connection'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:349:in `block in checkout'
/home/vagrant/.rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/monitor.rb:214:in `mon_synchronize'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:348:in `checkout'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:263:in `block in connection'
/home/vagrant/.rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/monitor.rb:214:in `mon_synchronize'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:262:in `connection'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:571:in `retrieve_connection'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_handling.rb:113:in `retrieve_connection'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_handling.rb:87:in `connection'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/migration.rb:383:in `connection'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activerecord-<IP_ADDRESS>/lib/active_record/migration.rb:370:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:88:in `__run_callbacks__'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:778:in `_run_call_callbacks'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:81:in `run_callbacks'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/callbacks.rb:27:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/reloader.rb:73:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/remote_ip.rb:78:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/better_errors-1.1.0/lib/better_errors/middleware.rb:58:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/railties-<IP_ADDRESS>/lib/rails/rack/logger.rb:38:in `call_app'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rails_semantic_logger-4.2.1/lib/rails_semantic_logger/extensions/rails/rack/logger.rb:19:in `block in call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/semantic_logger-4.2.0/lib/semantic_logger/semantic_logger.rb:299:in `fast_tag'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/semantic_logger-4.2.0/lib/semantic_logger/base.rb:190:in `tagged'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rails_semantic_logger-4.2.1/lib/rails_semantic_logger/extensions/rails/rack/logger.rb:19:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rack-1.6.11/lib/rack/session/abstract/id.rb:225:in `context'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rack-1.6.11/lib/rack/session/abstract/id.rb:220:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/cookies.rb:560:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/request_store-1.3.1/lib/request_store/middleware.rb:9:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/request_id.rb:21:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rack-1.6.11/lib/rack/methodoverride.rb:22:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rack-1.6.11/lib/rack/runtime.rb:18:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/activesupport-<IP_ADDRESS>/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rack-1.6.11/lib/rack/lock.rb:17:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/static.rb:120:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rack-1.6.11/lib/rack/sendfile.rb:113:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rack-cors-0.4.1/lib/rack/cors.rb:81:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rack-cors-0.4.1/lib/rack/cors.rb:81:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/sentry-raven-2.9.0/lib/raven/integrations/rack.rb:51:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:518:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/railties-<IP_ADDRESS>/lib/rails/application.rb:165:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rack-1.6.11/lib/rack/lock.rb:17:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rack-1.6.11/lib/rack/content_length.rb:15:in `call'
/home/vagrant/.rvm/gems/ruby-2.4.6/gems/rack-1.6.11/lib/rack/handler/webrick.rb:88:in `service'
/home/vagrant/.rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/webrick/httpserver.rb:140:in `service'
/home/vagrant/.rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/webrick/httpserver.rb:96:in `run'
/home/vagrant/.rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/webrick/server.rb:308:in `block in start_thread'

I was able to "bandaid" the problem by increasing the pool size from 1 to 2, but I'd like to understand what's going on here.
For some more context, the connection that is left open looks like
=# select datid, datname, pid, usesysid, usename, application_name, state, query from pg_stat_activity;
 datid |   datname    | pid  | usesysid | usename | application_name | state  |                                                query
-------+--------------+------+----------+---------+------------------+--------+------------------------------------------------------------------------------------------------------
 16394 | app_dev | 9221 |    16384 | vagrant | bin/rails        | idle   |               SELECT a.attname, format_type(a.atttypid, a.atttypmod),                               +
       |              |      |          |         |                  |        |                      pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod         +
       |              |      |          |         |                  |        |                 FROM pg_attribute a LEFT JOIN pg_attrdef d                                          +
       |              |      |          |         |                  |        |                   ON a.attrelid = d.adrelid AND a.attnum = d.adnum                                  +
       |              |      |          |         |                  |        |                WHERE a.attrelid = '"shipper_applications"'::regclass                                +
       |              |      |          |         |                  |        |                  AND a.attnum > 0 AND NOT a.attisdropped                                            +
       |              |      |          |         |                  |        |                ORDER BY a.attnum                                                                    +
       |              |      |          |         |                  |        |
 16394 | app_dev | 7975 |    16384 | vagrant | psql             | active | select datid, datname, pid, usesysid, usename, application_name, state, query from pg_stat_activity;

This row appears after running bundle exec rails s. The shipper_applications table, is not the model that includes attr_encrypted.
And when I remove the call to attr_encrypted from my model and restart the rails server, I get
=# select datid, datname, pid, usesysid, usename, application_name, state, query from pg_stat_activity;
 datid |   datname    | pid  | usesysid | usename | application_name | state  |                                                query
-------+--------------+------+----------+---------+------------------+--------+------------------------------------------------------------------------------------------------------
 16394 | app_dev | 7975 |    16384 | vagrant | psql             | active | select datid, datname, pid, usesysid, usename, application_name, state, query from pg_stat_activity;

which is what I'd expect.

I am suspicious of this call to define_attribute_methods: https://github.com/rocketjob/symmetric-encryption/blob/45244135d07b47b79eb290686af5aff10a6aa853/lib/symmetric_encryption/active_record/attr_encrypted.rb#L46


Align project with new API & update

Bring the project up to standard and align it with the newly created API (https://github.com/MatthewNobes/recipe-book-api).

This ticket will also include the setting up of mocking for the API, which will allow the App to be tested without the API running


[JENKINS-37934] Add support for JGit's Apache's HTTP client and preemptive authentication

Situation
A few users have noticed that the Git plugin was ignoring the configured credentials (and instead tried to use the process's identity) under the following conditions:

A job uses the Git SCM, configured to use the JGit "installation"
The Git repository is hosted in Team Foundation Server
The Jenkins build executes on Windows

Because JGit, by default, uses the JDKHttpConnectionFactory (which means URL#openConnection()), it turns out the JVM, on Windows, will attempt NTLM authentication using the identity of the current process and JGit's TransportHttp does not support NTLM as an authentication method when the attempt comes back with HTTP 401.
Action

Add org.eclipse.jgit:org.eclipse.jsit.http.apache as a dependency.
Introduce the JGit with Apache HTTP client "installation" option, illustrated in the screenshot below:

When the new "installation" above is used, enable the new PreemptiveAuthHttpClientConnection[Factory], which will attempt to authenticate with the provided credentials, bypassing JGit's authentication mechanism.

Result
By using the JGit with Apache HTTP client "installation", I was able to clone from a variety of repositories, without having to launch Jenkins using a domain identity that had TFS permissions on Windows.  In fact, I tried to get Windows integrated authentication working and it mostly worked, except when I hit a TFS server that had Negotiate (Kerberos) enabled; JGit's TransportHttp noticed that Negotiate was used and then tried to "configure the connection" the second time around, but this failed because JGit expected explicit credentials to be provided.  If integrated authentication from Windows nodes is needed, there's still the original JGit "installation" that can be configured on a per-job basis.
Please let me know if you would like me to add or change anything.
Manual testing

Deployed git-client.hpi from this branch to a Jenkins server.
Added the JGit with Apache HTTP client "installation" and clicked [Save].
Created the following Multi-configuration jobs, each with a single operating_system Slaves axis to run the same job on Linux (Ubuntu 14.6), Mac OS X (10.10.5) and Windows (2012 R2), using the jgitapache Git executable:

GitHub HTTPS

Repository URL: https://github.com/jenkinsci/tfs-plugin.git
Credentials:  - none -, because the repository is publicly-available

GitHub SSH

Repository URL: git@github.com:jenkinsci/tfs-plugin.git
Credentials:  Created a key pair and configured Jenkins with it.

GitLab HTTP

Repository URL: A Git repo in a default GitLab CE instance on the LAN
Credentials: Username & password of the GitLab root user.

Team Services HTTPS

Repository URL: A Git repo in a Visual Studio Team Services account
Credentials: E-mail address and personal access token (PAT)

TFS HTTP domain

Repository URL: A Git repo in a Team Foundation Server on the same domain
Credentials: Domain username & password, with the username portion in the form user

TFS HTTP off-domain, domain slash user

Repository URL: A Git repo in a Team Foundation Server on the same domain
Credentials: Domain username & password, with the username portion in the form DOMAIN\user

TFS HTTP off-domain, user

Repository URL: A Git repo in a Team Foundation Server on a different domain
Credentials: Domain username & password, with the username portion in the form user

TFS HTTP off-domain, user at domain

Repository URL: A Git repo in a Team Foundation Server on a different domain
Credentials: Domain username & password, with the username portion in the form user@domain

TFS HTTP off-domain, user at fully-qualified domain

Repository URL: A Git repo in a Team Foundation Server on a different domain
Credentials: Domain username & password, with the username portion in the form<EMAIL_ADDRESS>

All the jobs succeeded, except the last one.  It seems to be a limitation of the NTCredentials class.  Not a big deal as three other forms of the user name were accepted.

Mission accomplished!

@olivierdagenais could you review my evaluation branch? I have run various interactive tests and automated tests and believe your pull request is ready to merge, but would appreciate it very much if you would review the changes I made to resolve the conflicts from the master branch, and to set the line endings on 2 files to Unix style line endings.

@MarkEWaite I eventually figured out how to compare your branch against mine and they appear to be functionally identical.  If you're happy with the changes, I'm happy. :+1:
Cheers,
- Oli


Error in out-of-bounds lookup with non-scalar VoxelData

When doing a lookup in a VoxelData object where the per-voxel value has dimension 2 (e.g., a flat map), specifying outer_value leads to error because the shape of the result is assumed to be 1-dimensional.
E.g., setting outer_value = np.array([-2,-2]) leads to:
Traceback (most recent call last):
  File "<stdin>", line 5, in <module>
  File "/gpfs/bbp.cscs.ch/ssd/apps/bsd/2023-02-23/stage_applications/install_gcc-12.2.0-skylake/py-voxcell-3.1.4-52dics/lib/python3.10/site-packages/voxcell/voxel_data.py", line 179, in lookup
    result = np.full(voxel_idx.shape[:-1], outer_value)
  File "/gpfs/bbp.cscs.ch/ssd/apps/bsd/2023-02-23/stage_applications/install_gcc-12.2.0-skylake/py-numpy-1.22.4-vtwzpw/lib/python3.10/site-packages/numpy/core/numeric.py", line 344, in full
    multiarray.copyto(a, fill_value, casting='unsafe')
  File "<__array_function__ internals>", line 180, in copyto
ValueError: could not broadcast input array from shape (2,) into shape (2060,)

The issue is that the dimension of result in voxel_data.py:179 does not match the dimension of the values it should store (2 in this example).
A possible fix is the following:
item_shape = self.raw[0,0,0].shape  # can be () for scalars, or (2,) in our case
result = np.full(voxel_idx.shape[:-1] + item_shape, outer_value, dtype=self.raw.dtype)  # tuple addition does the right thing

This way we keep the shape of the array values, and also the original dtype (otherwise it takes it from outer_value).

Hello @seirios, and thanks for opening this issue. Could you please provide a minimal example to reproduce this error? Thank you!

Sure @eleftherioszisis !
This works (assumes only three dimensions):
vc.VoxelData(np.zeros((1,1,1)),(1,1,1)).lookup((-1,-1,-1),0)
But this does not (fourth dim is 1):
vc.VoxelData(np.zeros((1,1,1,1)),(1,1,1)).lookup((-1,-1,-1),0)
Neither does this (fourth dim is 2, as in flat map):
vc.VoxelData(np.zeros((1,1,1,2)),(1,1,1)).lookup((-1,-1,-1),(0,0))

Hello @seirios , please try the py-voxcell 3.1.5 so we can close this issue :slightly_smiling_face:

ping @seirios?

Hi! Sorry for the big delay! I have tested it now, and it works as expected in isolation and in the context of my use case. Thanks!

Thanks for following up @seirios.


Adding additional policy to node group IAM role

Description
We are creating multiple clusters using same set of terraform files and variable values for each one of them is set using tfvar files. Each of our clusters can have different set of eks managed node groups and these are controlled by setting create flag in the respective tfvar file for the cluster.
  eks_managed_node_groups = [
    {
      create                 = var.node_group_configuration.basic_a_arm_r6g.create
      name                   = "${var.cluster_name}-arm-r6"
      node_group_name_prefix = "${var.cluster_name}-arm-r6"
      launch_template_name   = "basic-a-arm-r6g-"
      instance_types         = ["r6g.xlarge"]
      desired_size           = var.node_group_configuration.basic_a_arm_r6g.desired_size
      min_size               = var.node_group_configuration.basic_a_arm_r6g.min_size
      max_size               = var.node_group_configuration.basic_a_arm_r6g.max_size
      subnets                = [module.vpc.private_subnets[var.node_group_configuration.basic_a_arm_r6g.subnet_index]]
      additional_tags = {
        Name = "${local.full_cluster_name}-basic-a-arm-r6g"
      }
    },
    {
      create                 = var.node_group_configuration.intel_m5.create
      name                   = "${var.cluster_name}-intel-m5"
      node_group_name_prefix = "${var.cluster_name}-intel-m5"
      ami_type               = "AL2_x86_64"
      launch_template_name   = "intel-m5-"
      instance_types         = ["m5.xlarge"]
      desired_size           = var.node_group_configuration.intel_m5.desired_size
      min_size               = var.node_group_configuration.intel_m5.min_size
      max_size               = var.node_group_configuration.intel_m5.max_size
      subnets                = [module.vpc.private_subnets[var.node_group_configuration.intel_m5.subnet_index]]
      additional_tags = {
        Name = "${local.full_cluster_name}-intel-m5"
      }
      ]

In addition to this, we are setting additional policy to the node groups. As per this comment to avoid the terraform issue with for-each, we are using aws_iam_role_policy_attachment to attach the additional policy.
resource "aws_iam_role_policy_attachment" "additional" {
  for_each = module.eks.eks_managed_node_groups

  policy_arn = aws_iam_policy.s3_write_policy.arn
  role       = each.value.iam_role_name
}

Let's take a simple example of eks module creating cluster with 2 node groups and below scenarios,

ClusterA: used both the node groups
ClusterB: uses only 1 node group

When we try to deploy these 2 clusters, ClusterA is successfully deployed. For ClusterB, the IAM policy is updated for the node group which is enabled to be created but fails with:
| aws_iam_role_policy_attachment.additional["0"]: Creation complete after 0s [id=arm-r6-eks-node-group-20220429042911230300000001-20220429091830789400000002]

│ Error: Error attaching policy arn:aws:iam::1233333:policy/additional-policy to IAM Role : InvalidParameter: 1 validation error(s) found.
│ - minimum field size of 1, AttachRolePolicyInput.RoleName.
│
│
│   with aws_iam_role_policy_attachment.additional["1"],
│   on cluster.tf line 173, in resource "aws_iam_role_policy_attachment" "additional":
│  173: resource "aws_iam_role_policy_attachment" "additional" {

This seems to indicate that the output module.eks.eks_managed_node_groups is returning both the node group names irrespective of create flag set to true or false.
To work around this we tried to parse the output module.eks.eks_managed_node_groups and add condition to check if there is iam_role_name is set.
resource "aws_iam_role_policy_attachment" "additional" {
  for_each = {
    for node_group, group_details in module.eks.eks_managed_node_groups : node_group => group_details
    # We have to add if condition as the module output contains all node names,
    # even if they are not created.
    if group_details.iam_role_name != ""
  }

  policy_arn = aws_iam_policy.s3_write_policy.arn
  role       = each.value.iam_role_name
}

But, this seems doesn't seem help and we'll end up in the same terraform issue with for-each.
╷
│ Error: Invalid for_each argument
│
│   on cluster.tf line 175, in resource "aws_iam_role_policy_attachment" "additional":
│  175:   for_each = {
│  176:     for node_group, group_details in module.eks.eks_managed_node_groups : node_group => group_details
│  177:     # We have to add if condition as the module output contains all node names,
│  178:     # even if they are not created.
│  179:     if group_details.iam_role_name != ""
│  180:   }
│     ├────────────────
│     │ module.eks.eks_managed_node_groups is object with 2 attributes
│
│ The "for_each" value depends on resource attributes that cannot be
│ determined until apply, so Terraform cannot predict how many instances will
│ be created. To work around this, use the -target argument to first apply
│ only the resources that the for_each depends on.

Could you please see if the output for module.eks.eks_managed_node_groups can be set to only use the values for node groups which are getting created?
Also, please suggest any alternate options for this so that we can overcome this blocker for us.
Versions

Module version [Required]: 18.20.5

Terraform version: 1.1.7

Provider version(s): 4.12.1

the output for the IAM role created for each esg was removed so we can no longer easily add new policies after the fact.

This is available and is one of the recommended ways to getting around this issue currently
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/d969e94bbea89ed616713bdab849f042ceda87ac/modules/self-managed-node-group/outputs.tf#L111
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/examples/eks_managed_node_group/main.tf#L352-L362

the output for the IAM role created for each esg was removed so we can no longer easily add new policies after the fact.

This is available and is one of the recommended ways to getting around this issue currently
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/d969e94bbea89ed616713bdab849f042ceda87ac/modules/self-managed-node-group/outputs.tf#L111
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/examples/eks_managed_node_group/main.tf#L352-L362

Awesome, thank you, i saw that worker_iam_role_name was removed I was looking for if it was replaced by something.

@bryantbiggs - Regarding the output module.eks.eks_managed_node_groups , do you suggest any workaround or have plans to limit the output to list on the node groups which have create set to true ?

@chandanpjain no - the output provided is sufficient I believe

@chandanpjain  did you try using
      iam_role_additional_policies = [
        "arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
      ]

@pen-pal
using iam_role_additional_policies with eks_managed_node_groups triggers prefix length overflow:
Error: expected length of name_prefix to be in the range (1 - 38), got iam_role_additional_policies-eks-node-group-
│
│   with module.eks.module.eks_managed_node_group["iam_role_additional_policies"].aws_iam_role.this[0],
│   on .terraform/modules/eks/modules/eks-managed-node-group/main.tf line 435, in resource "aws_iam_role" "this":
│  435:   name_prefix = var.iam_role_use_name_prefix ? "${local.iam_role_name}-" : null

@pen-pal
using iam_role_additional_policies with eks_managed_node_groups triggers prefix length overflow:
Error: expected length of name_prefix to be in the range (1 - 38), got iam_role_additional_policies-eks-node-group-
│
│   with module.eks.module.eks_managed_node_group["iam_role_additional_policies"].aws_iam_role.this[0],
│   on .terraform/modules/eks/modules/eks-managed-node-group/main.tf line 435, in resource "aws_iam_role" "this":
│  435:   name_prefix = var.iam_role_use_name_prefix ? "${local.iam_role_name}-" : null

nope, that would be the name used on the IAM role - it does not have anything to do with additional policies

@liqwid You need to declare it inside each node group definition

This issue has been resolved in version 19.0.0 :tada:

Guys not sure if related but since upgrading to 19.0.4 we started getting the following error using iam_role_additional_policies
│ Error: Invalid value for input variable
│
│   on .terraform/modules/eks/node_groups.tf line 324, in module "eks_managed_node_group":
│  324:   iam_role_additional_policies = lookup(each.value, "iam_role_additional_policies", lookup(var.eks_managed_node_group_defaults, "iam_role_additional_policies", {}))
│
│ The given value is not suitable for
│ module.eks.module.eks_managed_node_group["initial"].var.iam_role_additional_policies
│ declared at
│ .terraform/modules/eks/modules/eks-managed-node-group/variables.tf:455,1-40:
│ map of string required.
╵
ERRO[0035] Terraform invocation failed in /Users/michael/avalor/avalor/ops/terragrunt/staging/us-east-1/kubernetes/.terragrunt-cache/0yUd7gSBbnz6t6r_HZN_jsvNI5Y/nl9T9BvNL8wJuw1h0rEhuiLCPCM/kubernetes  prefix=[/Users/michael/avalor/avalor/ops/terragrunt/staging/us-east-1/kubernetes]
ERRO[0035] 1 error occurred:
        * exit status 1

for the following declaration
eks_managed_node_groups = {
    initial = {
      name                 = "node-group-initial"
      launch_template_name = "node-group-initial"
      min_size             = 2
      max_size             = 2
      desired_size         = 2
      instance_types       = var.initial_instance_types
      capacity_type        = var.initial_capacity_type
      ami_type             = var.initial_ami_type

      tags = {
        "karpenter.sh/discovery" = var.cluster_name
      }

      create_security_group                 = false
      attach_cluster_primary_security_group = true

      iam_role_additional_policies = ["arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore"]

      security_group_rules = {
        egress_all = {
          cidr_blocks = ["<IP_ADDRESS>/0"]
          from_port   = "0"
          protocol    = "-1"
          type        = "egress"
          to_port     = "0"
        }
      }
    }}

This was working fine before that (not sure which version we were running though).
Would appreciate some input.


Succeed to use Int32 property to query one entity which has Double property

Storage Explorer Version: 1.29.1
Build Number: 20230508.1
Branch: hotfix/1.29.1
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.3.1 (Apple M1 Pro)
Architecture: ia32/x64/arm64
How Found: Exploratory testing
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Tables.

Create a table -> Add an entity containing a custom property of type "Double" with a value of "123.45". Like below:

Click 'Query' -> Add a clause. As below:

Execute query.

Check there is no queried entity.

Expected Experience
There is no queried entity.
Actual Experience
There is a queried entity.

Additional Context

This issue doesn't reproduce when selecting 'Int64'.

A related issue 5346.

I believe this is expected behavior. Table queries do not contain types; only values. So when you are querying for "123.45", the query doesn't care what the type is. It will still return results.
The difference with Int64 is we append an "L" to the value. I'm not entirely sure why we do this, as I can't find any documentation or comments about it. Let me play around with some things to see if removing the "L" messes anything up. But I expect that if the "L" is removed, you'll start getting consistent behavior for all numeric types.

@craxal
When remove 'L' from the Int64 value.
Succeed to use Int64 property to query the entity which has Double property.

@craxal
Updates:
Succeed to use 'int32' type to query one entity which has 'Boolean' property.

This all sounds to be above board. Closing as won't fix.


Support self signed certificates

When connecting to cluster using TLS, the certificate might be a self-signed cert.
Today we receive an error, but there is no documentation on how to configure the cert to validate it.

I think it's the same issue than https://github.com/jlandersen/vscode-kafka/issues/86

I have same problem. At #86 I didn't find solution.

#86 still open and tries to address SASL_SSL, so I guess it should fix the usage of any TLS endpoint. However, I suggest using this issue to track the specifics of using self-signed certs within any TLS type of config.

I have same problem. At #86 I didn't find solution.

Yes sure, it's just some discussion. The issue which implement the idea with certificate (and another configuration) is https://github.com/jlandersen/vscode-kafka/issues/88
But please note if you have the capability to write a vscode extension, you can contribute to vscode-kafka with your cluster configuration. You extension could create the proper kafka config with the proper certificate https://kafka.js.org/docs/configuration#ssl
If you are interested to write your own vscode extension, please see the sample at https://github.com/angelozerr/vscode-kafka-extension-sample/blob/f3470cb0ab8777085e256571eeecc20fd77a7a83/src/extension.ts#L106
For the moment, there is no a robus documentation,please add comment in https://github.com/jlandersen/vscode-kafka/issues/129 if you need a documentation.

However, I suggest using this issue to track the specifics of using self-signed certs within any TLS type of config.

Ok thanks for your suggestion.

@hguerrero can you try the CI build from https://github.com/jlandersen/vscode-kafka/actions/runs/987534310 and give some feedback?

@hguerrero please note that there is a bug with ca, cert, key file save settings. Once you have selected the file, please add a space and remove a space on each file fields before saving. I'm fixing that.

Sure, I'll give it a try

Hey, @angelozerr what type of file do I need to get for the certificate authority? right now I tried, crt, pem, and keystore but I'm not able to select any using the browse button.

Its a mistake that i did. I need to add another file extensions. Please use the expected file extension for the moment by renaming your file extension. I will fix that soon

Ok, adding the full path in the textbox worked.
Awesome work folks!
I was able to connect with no trouble

@hguerrero was your certificate self-signed?

Yes, it was @fbricon

Cool, thanks. FYI, @angelozerr has made some more improvements to the proposed changes, including fixing the file browsing. You can try a newer build from https://github.com/jlandersen/vscode-kafka/actions/runs/994037689

@fbricon I tested the new version, but unfortunately is not working.
Looks like when using the browse button:

I can now select my file
The file does not show in the textbox
When I click on Finish the server is created but the cert is not linked

So, when trying to connect to my cluster I still get the self-signed cert error.
If I add manually the path in the textbox, as I did with the previous version it works.

@hguerrero what OS are you on?

@hguerrero have you tried the latest build from https://github.com/jlandersen/vscode-kafka/actions/workflows/ci.yml?query=is%3Asuccess ?

@hguerrero what OS are you on?

MacOS Big Sur v11.4

@hguerrero have you tried the latest build from https://github.com/jlandersen/vscode-kafka/actions/workflows/ci.yml?query=is%3Asuccess ?

No, used the 6days old, let me try with the one from 1hr ago.

Ok,  I can confirm that the latest build (700) worked correctly.

Fixed with #193

Hi guys! First of all, thank you for making kafka available in vs code. I'm really looking forward to ditching the expensive conduktor I have to use through VNC. However I'm getting this error as well. I might have more than just this issue though - not sure:

I have this issue and I don't understand how I'm supposed to fix it
In conduktor I simply have to point to my truststore.jks file. I converted it using this method. However this only creates a single PEM file. And I'm prompted for three different files in your setup:

not really sure what that translates to. Any help would be greatly appreciated!

@kasperschnack to be honnest with you, I have none knowledge about JKS, etc. I have just consumed the kafkajs API and the expected tls ConnectionOptions :
https://github.com/jlandersen/vscode-kafka/blob/06b74ed03a57c73b2daec4a60a3dfd76145c039e/src/client/client.ts#L491
If it requires some changes, any feedback are welcome, thanks!

Cannot connect using v0.15.0
Cannot find old build for v0.13.0

The certificate I issued does not have correct hostnames, more than that, I'm playing with cluster of 3 brokers.
Need to have ability to bypass host validation.
Failed operation - Connection error: Hostname/IP does not match certificate's altnames: IP:  is not in the cert's list

To install a prior version:


projected rules

Quick take on #1164.

Plot.plot({
  projection: {
    type: "orthographic",
    rotate: [100, -30]
  },
  marks: [
    Plot.sphere(),
    Plot.geo(land, {fill: "currentColor"}),
    Plot.ruleX(d3.range(-180, 180, 10), {stroke: "red"}),
    Plot.ruleY(d3.range(-80, 80, 10), {stroke: "blue"})
  ]
})

Some things to figure out:

How do you turn on/off shape- vs. point-based projection (the projected option)?
Can we assume that projections are spherical? (Probably okay?)
Can you set the precision of the projected line?
Can you set the opposite extent of the projected line (ruleX’s y1 and y2)?

How do you turn on/off shape- vs. point-based projection (the projected option)?

So far none of our initializers messes with x1, y1 etc., they just touch x and y. But if the centroid initializer, for example, started to apply to these channels, we'd have a potential conflict. So it's probably a good prevention to turn this off (silently, or error?) if used with an initializer. I'm not sure if there are other weird cases.

Can we assume that projections are spherical? (Probably okay?)

The default y1=-90 to y2=90 is okay—for a planar projection the user will have to specify y1 and y2 anyway. Though I'd prefer we default y1=-80 and y2=80.

Can you set the precision of the projected line?

I don't think that's necessary. The maximum error happens at latitude 45° and is proportional to step^2. If the step is 1 degree (361 points per parallel), the maximal error (on Earth) is 121m, which is, I think, low enough. 0.5 degree would give use 30.3m. We can even be a bit smarter, and if you "zoom in" split the segment [x1, x2] in ⎡sqrt(360 * (1+ ⎸x2-x1⎸))⎤  parts or something similar, to get even more precision without adding points.

Can you set the opposite extent of the projected line (ruleX’s y1 and y2)?

I've added this.

As more high-level remark, I don't think I'd often reach for a "rule X" to draw a single meridian. What we need most often is a graticule (or subset of a graticule), which sounds more like gridX + gridY. In the tests here we use ruleX(d3.range(-180, 180)), a pretty good indication that we want a gridX. We've also talked about adding lon and lat information on the "sides" of the map, which sounds like an axisX/axisY mark.

Yes. Maybe the way to think about this is: how could we add an automatic graticule/sphere when a spherical projection is in use, similar to how we can add automatic axes for planar coordinate systems?


Error: Hamburger button of navbar not working on Help page.

Describe the Error

Hamburger button of navbar not working on Help page.

Expected behavior

The navbar options should be visible when clicked on Hamburger button.

Additional context
https://github.com/user-attachments/assets/5d700f06-a1ba-4fd8-91ad-c1886299804d
@sanjay-kv @dinxsh please assign this issue to me.

closed via pr #303


Glob matching does not work when specified in script using Yarn 2

Running a script echo: run-p echo:* defined in package.json  will not work on Yarn 2.
Example package.json:
{
  "name": "test-yarn1",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "scripts": {
    "echo:bar": "echo 'bar'",
    "echo:foo": "echo 'foo'",
    "echo": "run-p echo:*"
  },
  "devDependencies": {
    "npm-run-all": "^4.1.5"
  }
}

To reproduce:

Create a dir
Run yarn init -y
Run yarn add -D npm-run-all
Add 3 scripts to package.json:

"echo:foo":  "echo 'foo'"
"echo:bar": "echo 'bar'"
"echo": "run-p echo:*"

Run yarn set version berry
Run yarn echo

=> No matches found: "echo:*"
Oddly enough, running yarn run-p echo:* directly does still work
Reproduction repo: https://github.com/Robin-Hoodie/yarn2-npm-run-all-repro

I just ran into this myself. If you quote the * then yarn won't try to handle the wildcard and run -p will work as expected.
Try this:
  "scripts": {
    "echo:bar": "echo 'bar'",
    "echo:foo": "echo 'foo'",
    "echo": "run-p 'echo:*'"
  }

Thanks for the tip, that works!
I do think the root cause of this should be fixed however (whether here or in Yarn 2)
If not that, at minimum some documentation can be added

I don't think this is a bug for both sides. Please don't get mad at me; I was also confused by the error. However, * is a valid shell syntax for globs, and Yarn implements a bash-like shell that presumably expands the wildcard.
It seems like expanding the wildcard is the expected behaviour of Yarn, and it doesn't look like npm-un-all can solve it either.

I just ran into this myself. If you quote the * then yarn won't try to handle the wildcard and run -p will work as expected.
Try this:
  "scripts": {
    "echo:bar": "echo 'bar'",
    "echo:foo": "echo 'foo'",
    "echo": "run-p 'echo:*'"
  }

Thanks very much for this. I had to line up all related script commands on one line as I didn't know what to do.

Hey, just had the issue too.

it doesn't look like npm-run-all can solve it either.

Agree, but adding it to the doc could be a good help, it avoids people to look for this issue 🙂.

Ditto to all of the above.  Thank goodness for github issues and threads like these.  This was the first thing that broke when I updated to yarn 2, given that the docs say it will work with yarn this was a little confusing to find the solution here.

Adding quotes works for me in Yarn 4.0.0-rc.27:
   "scripts": {
     "echo:bar": "echo 'bar'",
     "echo:foo": "echo 'foo'",
-   "echo": "npm-run-all echo:*"
+   "echo": "npm-run-all \"echo:*\""
   }

I find it odd that this works for all the other manager packages (npm, yarn classic, pnpm, bun), but not for modern Yarn. 😅


[WIP][3.x]exposed blend mode min and max to gles3(they don't exist in gles2)

Addresses https://github.com/godotengine/godot-proposals/issues/2621
I will do 4.0 PR in the future if the feature has interest.

What happens when a GLES2 user selects min or max?

Thank you @lyuma ! Will do that
@clayjohn I'm not sure yet. I suppose that max should alias to add and min to multiply? Would that make sense? GLES2 doesn't have non and max mode.

I'm not sure yet. I suppose that max should alias to add and min to multiply? Would that make sense? GLES2 doesn't have non and max mode.

I think we can make them behave like Mix, and print a warning using WARN_PRINT() or WARN_PRINT_ONCE() if GLES2 is used with the Min or Max modes.

I agree with Calinou, if we add this to 3.x, it needs to fail gracefully on GLES2 and be extremely clear to the user that it doesn't work.
To be honest, I think this is a feature better left for 4.0. I don't like adding features to GLES3 that can't be added to GLES2 and I don't see the need to push a feature through that was just recently requested. Clearly there isn't a large community demand.

@Calinou I'd say the master version looks correct. In 3.x from left to right, top to bottom are displayed: Mix, Add, Disabled, Min. It happens because Min, Max were added after Disabled in the enum and Disabled is not bound to the editor. Looking at how EditorPropertyEnum is being setup:
https://github.com/godotengine/godot/blob/fcfce4be671c1c9713535b185e235616f0ea75ed/editor/editor_properties.cpp#L486-L497
passing proper values for Min and Max after semicolon should fix this.
3.x after enum binding fix, from left to right, top to bottom: Mix, Add, Min, Max; top to bottom: running project, editor:

and with the texture having inverted colors:

Not sure what's causing different look for Min between the editor and running project.

Converted to draft as this PR is still WIP, and doesn't seem to pass CI. Not sure what's the way forward with this proposal?

@QbieShay What's the status on this?

Still wanted but it was made clear to me that it's not compatible with gles2 therefore it won't make it in 3.x
I still want this in 4.x but I don't know vulkan enough to expose it.

I still want this in 4.x but I don't know vulkan enough to expose it.

There's a PR adding this to 4.x already: https://github.com/godotengine/godot/pull/48654

Closed in favour of https://github.com/godotengine/godot/pull/48654


Crash

https://s1.ax1x.com/2022/05/22/OxuwDO.jpg

@sonichy,
can you please provide the crash.txt file, and provide mode detail about circumstances (actions engaged, tools selected, ...)

When I run the app the second day the crash disapear !
Maybe It caused by gInk, I test them in ten minute !

ok. I hope you will like it


numpy fft: Copy twiddle factors into local array to make algo thread safe

The core C++ routines in numpy.fft are not thread safe because they modify the twiddle factors during the function call (the get restored at the end).
This is to avoid the threading issue: I create a temp copy of the twiddle factors before calling the fft routine. It's not great but it does fix the issue.

@jeanlaroche could you add a test case where OpenMP is involved (to test multi threading) and pass clang-format on the modified C++ header, and finally squash all commits?

I don't know anything about openMP, will try to educate myself and ping you if I get stuck

Nice job! You leveled up in OpenMP :-)


Is this possible to download and build only a single file from git repo?

Hi!

Second, I wonder if there is a way to download and build only a single file from repo.
Basically, I want to install font-lock+.el from emacsmirror repo for emacswiki.
It's here: https://github.com/emacsmirror/emacswiki.org/blob/master/font-lock+.el
From what I've read in the readme, there is a :files which can customize how symlinks are built, but if I understand things correctly, it'll still download whole repo to my computer (which I don't want, becase emacswiki repo is huge).
Do you have any tips? Am I missing something?

Regarding my particular case, I just found out that there is a https://github.com/emacsmirror/font-lock-plus which I can install with straight recipe I already know how to build.
But the original question about downloading only single file still relevant :)

Git doesn't provide any way for you to clone only part of a repository, so straight.el doesn't provide any way to do this either.
It would be a useful feature to have, so if you have any suggestions about how it could be implemented I'm all ears.
It might be possible to do it with the same machinery used to support #149. I would have to muse on this.
See also https://github.com/raxod502/straight.el/pull/284 which might be useful for reducing clone sizes (although I'm not sure if shallow cloning is viable in most cases).
[Of course, the real problem here is Drew. If he'd package his code properly then people wouldn't have problems downloading it. But that's water under the bridge.]

Thanks for the in-depth and fast answer! Git provides git archive --remote=url BRANCH file_name. Although GitHub doesn't support it AFAIK. It supports downloading raw files though, by constructing
https://github.com/user/repository/raw/branch/filename URL. I already predict how painful such implementation might be in the code and that it's a really rare use-case (although if we consider Spacemacs discussion, there might be some gains potentially).

I don't think it'll be too bad once #149 is implemented. I added a comment there to explain my idea. There can just be a recipe keyword or something that specifies a single file to use (or multiple, but that would be slower), and then it can download the single file and manage its revisions with the .straight-head file as in the tarball case.

Won't be saying that I fully understand the plan, but it sounds good, thanks!

Out of curiosity, why not https://github.com/emacsmirror/font-lock-plus?

Oh, that's exactly what I did eventually, I should've been clearer here: https://github.com/raxod502/straight.el/issues/285#issuecomment-397787586 :)

Wow, I totally missed that when I re-read this thread. Sorry :(

Hello!, somewhat having the same question, @raxod502 how do I tell straight.el to pull the package from a specific URL like this? https://www.emacswiki.org/emacs/download/hl-line%2b.el, because it seems to not be in the emacsmirror repo:
Could not find package hl-line+ in recipe repositories: (org-elpa melpa gnu-elpa-mirror emacsmirror-mirror)

@ZzAntares this is unsupported. However, that package can be pulled from Emacsmirror under the name hl-line-plus :)


new installation pigs hwer error

Hi.
Make a new installation on a raspberry zero w.
Now i got an error
pi@Test:~ $ pigs hwver
socket connect failed
pi@Test:~ $
any idee?

Did you start the pigpiod service?  See: https://github.com/ebaauw/homebridge-rpi#enable-pigpiod-service.


Remove setuptools ... a lot

The osf docker-compose script was giving some people __version__ errors still. I believe this fixes them. I built a docker image locally and was able to start it and run the server. The uninstall and delete is probably overkill but why not delete it as many times as possible. h/t @felliott Your commit comment gave me enough to figure it out.

Merged as a hotfix, v0.29.1!  Thanks, @cwisecarver!


is it available in Angular 2 RC6?

I'm submitting a ...
[ ] feature request

is it available in Angular 2 RC6?
Thanks

Yes!

which branch?

@jadav1982 take a look at the development branch please, now both rc2 and 2.0 release supported.


Live Channels appears offline

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
Every Live Channel appears offline.

I reinstalled Chatterino,
I reinstalled the VC++ Redistributables
i relogged in

Still, every Live Channel appears offline. Everthing else is loaded (chat messages by example).
Screenshots
No response
OS and Chatterino Version
Chatterino 2.5.1 (commit eafcb941f57011358d63c76de6bee38ca1ba, 2024-04-28), Windows 11

This description does not describe anything about the issue, in the title you say channels but in the description you say channel, report information needs to be specific as one other person reported this, but only for a single channel
Also it's preferred if you follow the suggested instructions for filling out the OS and Chatterino version, as that information is often useful for debugging a problem

This description does not describe anything about the issue, in the title you say channels but in the description you say channel, report information needs to be specific as one other person reported this, but only for a single channel
Also it's preferred if you follow the suggested instructions for filling out the OS and Chatterino version, as that information is often useful for debugging a problem

Well, yes i forgot an s in the description. I'm sorry. But i think the issue is well described: Live channels appears offline. There is nothing to add, except the steps i tried to fix it myself.
I re-downloaded the commit that is tagged as 2.5.1, but i added the commit hash.
I had multiple tabs, a few of them where live but chatterino showes every channel as offline. Do we need some more informations?

Try re-logging

Try re-logging

as already described, i did that..

as already described, i did that..

I stopped reading after I tried some stuff as I didn't expect any useful information to be mentioned after that

as already described, i did that..

I stopped reading after I tried some stuff as I didn't expect any useful information to be mentioned after that

I happy that i teached you wrong for the next time.

Live status information comes from Twitch's Helix API so the main assumption is you can't receive the information bounced back from those requests, either you're having an internet issue or you've hit the ratelimits for the Helix API.

Shameless ad: Since you're on Windows, you can try to capture logs with https://github.com/nerixyz/c2-logs (or you can attach a debugger manually if you don't trust it). You can run it with c2-logs chatterino.*.debug=true (or put a -o file in between to output to a file - see the README for more info).
Live channels recheck periodically, so we only need the logs when that happens. The LiveController logs something like chatterino.twitch.livecontroller: Make {n} requests.

Could you verify that all of your content preferences are unchecked? https://www.twitch.tv/settings/content-preferences

I have the same problem, some live channels (always the same ones) appear as offline.

Could you verify that all of your content preferences are unchecked? https://www.twitch.tv/settings/content-preferences

However after enabling everything in my content preferences, one of the problematic channels came back showing as live properly (after I logged in again).


feat: MultiProgress insert_from_back

Add insert_from_back method to MultiProgress

It may not matter that much, but wouldn't that be subject to a race condition if another thread added a new progress bar between the call to len and the call to insert? Granted in practice this would result in the bars being added in unspecified order which is probably fine.
An alternative would be insert_from_back or to change insert to take negative numbers Python-style to indicate offset from the end.
I run into this when I have an overall status bar at the bottom, and then add subactions above, when there are enough subactions (or a more are added as we go) that the overall status bar would scroll offscreen.

It may not matter that much, but wouldn't that be subject to a race condition if another thread added a new progress bar between the call to len and the call to insert? Granted in practice this would result in the bars being added in unspecified order which is probably fine.

I think just using insert without relying on the length of the MultiProgress could also result in a race condition. For example, if you were to insert multiple bars with the same index concurrently, you wouldn't have any guarantees as to which eventually resides at that index.
use indicatif::{MultiProgress, ProgressBar};
use std::{sync::Arc, thread};

fn main() {
    let mp = Arc::new(MultiProgress::new());
    let first_bar = ProgressBar::new(100);
    let second_bar = ProgressBar::new(100);

    let mp_1 = Arc::clone(&mp);
    let thread_1 = thread::spawn(move || {
        mp_1.insert(0, first_bar);
    });

    let mp_2 = Arc::clone(&mp);
    let thread_2 = thread::spawn(move || {
        mp_2.insert(0, second_bar);
    });

    thread_1.join().unwrap();
    thread_2.join().unwrap();

    // bars in mp have unknown order
}

A potential way this could be mitigated would be to change insert (and a potential insert_from_back) to require mutable references to self, requiring the user to deal with locking themselves.

I'd prefer an insert_from_back()-like solution over this if that's the actual goal. I think externalizing the locking could be a different PR (or, at least, a different commit).

I'd prefer an insert_from_back()-like solution over this if that's the actual goal. I think externalizing the locking could be a different PR (or, at least, a different commit).

@djc I have changed this PR to add an insert_from_back method. I agree that if the locks were to be externalized it should be a separate PR.

Thanks!


Finetuning kinetics pretrained on my custom dataset. #model not learning anything

@yjxiong  How do we run the model using pre-trained kinetics weights on our own dataset for finetuning? I followed the process presented in the wiki, However, the model is not learning anything.
Dataset configuration: 37900 training videos and 18000 testing videos. Each video around 80 frames.
I am using a single GPU for training.
Here are the training settings I use:
Batch size: 16
net: "models/ntu/tsn_bn_inception_rgb_train_val.prototxt"
testing parameter
test_iter:950
test_interval: 500
test_initialization: true
output
display: 20
average_loss: 20
#snapshot: 500
snapshot_prefix: "models/ntu_rgb_bn_inception"
debug_info: false
learning rate
base_lr: 0.001
lr_policy: "step"
gamma: 0.1
stepsize: 23000
max_iter: 70000
iter_size: 1
parameter of SGD
momentum: 0.9
weight_decay: 0.0005
clip_gradients: 40
GPU setting
solver_mode: GPU
device_id: [0,1,2,3]
richness: 200
~
Here are the training logs:
I0531 22:54:42.976332 14962 solver.cpp:640] Iteration 32800, lr = 0.0001
I0531 22:54:53.158599 14962 solver.cpp:240] Iteration 32820, loss = 3.71449
I0531 22:54:53.158618 14962 solver.cpp:255]     Train net output #0: loss = 3.93352 (* 1 = 3.93352 loss)
I0531 22:54:53.158623 14962 solver.cpp:640] Iteration 32820, lr = 0.0001
I0531 22:55:02.475733 14962 solver.cpp:240] Iteration 32840, loss = 3.73273
I0531 22:55:02.475766 14962 solver.cpp:255]     Train net output #0: loss = 3.33865 (* 1 = 3.33865 loss)
I0531 22:55:02.475772 14962 solver.cpp:640] Iteration 32840, lr = 0.0001
I0531 22:55:16.432497 14962 solver.cpp:240] Iteration 32860, loss = 4.26432
I0531 22:55:16.432529 14962 solver.cpp:255]     Train net output #0: loss = 3.89254 (* 1 = 3.89254 loss)
I0531 22:55:16.432534 14962 solver.cpp:640] Iteration 32860, lr = 0.0001
I0531 22:55:27.215116 14962 solver.cpp:240] Iteration 32880, loss = 3.65911
I0531 22:55:27.215148 14962 solver.cpp:255]     Train net output #0: loss = 3.59853 (* 1 = 3.59853 loss)
I0531 22:55:27.215153 14962 solver.cpp:640] Iteration 32880, lr = 0.0001
I0531 22:55:37.358016 14962 solver.cpp:240] Iteration 32900, loss = 3.92511
I0531 22:55:37.358033 14962 solver.cpp:255]     Train net output #0: loss = 3.6643 (* 1 = 3.6643 loss)
I0531 22:55:37.358053 14962 solver.cpp:640] Iteration 32900, lr = 0.0001
I0531 22:55:48.257910 14962 solver.cpp:240] Iteration 32920, loss = 3.87675
I0531 22:55:48.258025 14962 solver.cpp:255]     Train net output #0: loss = 3.76818 (* 1 = 3.76818 loss)
I0531 22:55:48.258044 14962 solver.cpp:640] Iteration 32920, lr = 0.0001
I0531 22:56:01.281738 14962 solver.cpp:240] Iteration 32940, loss = 3.68521
I0531 22:56:01.281755 14962 solver.cpp:255]     Train net output #0: loss = 3.88777 (* 1 = 3.88777 loss)
I0531 22:56:01.281760 14962 solver.cpp:640] Iteration 32940, lr = 0.0001
I0531 22:56:11.044287 14962 solver.cpp:240] Iteration 32960, loss = 3.66288
I0531 22:56:11.044319 14962 solver.cpp:255]     Train net output #0: loss = 3.50338 (* 1 = 3.50338 loss)
I0531 22:56:11.044324 14962 solver.cpp:640] Iteration 32960, lr = 0.0001
I0531 22:56:20.603466 14962 solver.cpp:240] Iteration 32980, loss = 3.63414
I0531 22:56:20.603592 14962 solver.cpp:255]     Train net output #0: loss = 3.61791 (* 1 = 3.61791 loss)
I0531 22:56:20.603598 14962 solver.cpp:640] Iteration 32980, lr = 0.0001
I0531 22:56:34.572155 14962 solver.cpp:433] Iteration 33000, Testing net (#0)
I0531 22:56:47.896167 14962 solver.cpp:490]     Test net output #0: accuracy = 0.0663158
I0531 22:56:47.896200 14962 solver.cpp:490]     Test net output #1: loss = 4.61347 (* 1 = 4.61347 loss)
I0531 22:56:48.189831 14962 solver.cpp:240] Iteration 33000, loss = 4.04755
I0531 22:56:48.189862 14962 solver.cpp:255]     Train net output #0: loss = 3.54686 (* 1 = 3.54686 loss)
I0531 22:56:48.189867 14962 solver.cpp:640] Iteration 33000, lr = 0.0001
I0531 22:56:58.206900 14962 solver.cpp:240] Iteration 33020, loss = 3.67343
I0531 22:56:58.207010 14962 solver.cpp:255]     Train net output #0: loss = 3.7331 (* 1 = 3.7331 loss)
I0531 22:56:58.207031 14962 solver.cpp:640] Iteration 33020, lr = 0.0001
I0531 22:57:08.124691 14962 solver.cpp:240] Iteration 33040, loss = 3.67509
I0531 22:57:08.124722 14962 solver.cpp:255]     Train net output #0: loss = 3.5837 (* 1 = 3.5837 loss)
I0531 22:57:08.124727 14962 solver.cpp:640] Iteration 33040, lr = 0.0001
I0531 22:57:21.653374 14962 solver.cpp:240] Iteration 33060, loss = 3.71491
I0531 22:57:21.653407 14962 solver.cpp:255]     Train net output #0: loss = 3.42221 (* 1 = 3.42221 loss)
I0531 22:57:21.653411 14962 solver.cpp:640] Iteration 33060, lr = 0.0001

I am using a single GPU for training
Possibly the batchsize is too small. Not sure it will work in this situtation.

the problem was related to batch size and net: "models/ntu/tsn_bn_inception_rgb_train_val.prototxt"


HAWQ-850. Planner supports refineCachedPlan interface.

in PBE(prepare bind execution) cases, plan will be cached, and only be generated once in postgres.
But in HAWQ since resource is dynamic or elastic, the plan maybe changed during the different execution of PBE. Also, the file split allocation result which is stored in plan is dynamically too, so the split-vseg mapping may also be changed.
For example, We call a plpgsql function which do "insert into t select * from t".
in Prepare we cache the plan, with fixed split-vseg mapping(e.g. 10 blocks), but after insert, there would be 20 blocks so the old  split-vseg mapping is invalid. We need to update it. Also when we call this function again and again, the data size of t may request more resource to handle it than the first call, so we should recalculate the entire plan with the new vseg number.
This function is implemented in a interface called refineCachedPlan.
Link to Jira

LGTM

LGTM


[edited] test issue with new title

blah @adriengibrat

opuiopyu

What the hell the title just changed?


Documentation for router ID auto-update feature for ipv6 only systems

Description
A new feature to auto update the router id for ipv6 only system with no ipv4 address is added. Documentation for the same is updated via this PR.

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit a26e5978f434d33ebd4c0e2f0fb75f556451df6a
https://deploy-preview-2474--calico.netlify.com