Handle exceptions when trying to read environment variables

Fix Issue # .

[x] I ran Unit Tests locally.
(although I got System.PlatformNotSupportedException: Access Control List (ACL) APIs are part of resource management on Windows and are not supported on this platform. on some tests, I assume that's MacOS specific.
For significant contributions please make sure you have completed the following items:

[ ] Design discussion issue #

[ ] Changes in public surface reviewed

[ ] CHANGELOG.md updated with one line description of the fix, and a link to the original issue.

[ ] The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.
If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)

Please follow [these] (https://github.com/Microsoft/ApplicationInsights-dotnet/blob/develop/.github/CONTRIBUTING.md) instructions to build and test locally.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: L-Dogg sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I ran unit tests on my Windows machine, found one that was failing because of my changes and fixed it. Other tests were green :).

Thank you for your contribution.
We're working on a different PR for this same issue.
We welcome your participation here: https://github.com/microsoft/ApplicationInsights-dotnet/pull/1504


Should configureScene be handled by the route instead of the navigator?

I have an app with a tabbar, three tabs, one global navigator and one navigator in each tab. All views pushed onto the global navigator should float from the bottom (they hide the tabbar). All views pushed onto one of the other navigators should float from the right (they don't hide the tabbar, it's still possible to navigate to other tabs without popping the views).
Some views can be pushed to any navigator (like a log-in-view). Now I either need to make two different route factories for the login view or pass in props into the route factory to create a route with the specific scene configuration.
Either way the views that push the log-in-view need to know where they are in the view hierarchy to either choose the correct route factory or to pass the correct scene configuration into the route factory. That seems wrong, as it goes against composition. :confused:
Shouldn't only the place of the navigator in the view hierarchy decide about how the next view is shown?

Makes sense. We probably want both the navigator and the route to decide what the transition should look like. For example, in your top-level navigator sometimes you may want to float a scene from the top instead of the bottom, depending on the scene.
Would this API work for you?
<ExNavigator
  defaultSceneConfig={FloatFromBottom}
/>

lgtm :+1:

It seems what is there is just a bug? RN shows on the Navigator and consistent with here: https://github.com/exponentjs/ex-navigator/blob/709af3b1c90517ac7fc862fc51075ef35f8b7700/ExNavigator.js#L65 but not with the props here: https://github.com/exponentjs/ex-navigator/blob/dec56c0d9b782d7b5dff3366a9aa4f21418c71da/ExRoute.js#L14


Feature/#49 crud operation for users

This branch will address issue #49 .It will contain the full user CRUD operations plus User Schema and DTO's
Resolves #49

@sohanur-rahman0 Is this the way you do it though ? I know this is the way you do it when you have another collection. Do sub collections work the same way ?

No....you are referencing here.....It is similar to foreign key.......It's not embedding.....


pkg_resources hard-fails on install_requires for entry point.

This has bitten us a few times now, I think that pkg_resources is a bit aggressive about install_requires, so when you attempt to invoke an entry point, the install_requires list is checked, and if any of the dependencies are missing, the script fails to start.
This problem has come up because we have a system that side-loads pre-built source (a la DPKG and presumably other package managers) where the dependencies are declared by the package manager (so install_requires is actually mostly ignored at install time). Occasionally we have needed to change the name of the package deployed by the package manager even though the importable path has not changed. If someone has the old package name in their install_requires and invokes their script via python -m mypkg, it works fine, but if they are invoking through an entry point, the script fails to run because the dependencies are not installed.
To demonstrate, I have prepared a small repository that demonstrates this behavior.
This is a real problem because it occurs at runtime and there doesn't seem to be any obvious way to "shim" around it other than by providing a dummy package (with no easy way to notify users that they are relying on this dummy package).
I suggest changing the DistributionNotFound error into a warning instead.

Have you tried using the entrypoints project? I suspect because it bypasses pkg_resources, it also bypasses the working set consistency check that leads to the DistributionNotFound error.
I should note that there are other errors besides DistributionNotFound that can result from attempting to load entrypoints (or even just importing pkg_resources), such as a ContextualVersionConflict if the package(s) are present but don't satisfy the declared version.

@jaraco Can we just turn those all into warnings for the purposes of entry_points?
We can maybe have an option to re-enable the old behavior, but I think by default this sort of thing should be enforced only at build time, not at runtime. If you want a hard version check at runtime, that should be opt-in.

Hi,
Given a setup like this one:
setup(
    name = "Project-A"
    #...,
    entry_points={
        "console_scripts": [
            "rst2pdf = project_a.tools.pdfgen [PDF]",
            "rst2html = project_a.tools.htmlgen",
        ],
    }
)

the docs say in optional-dependencies section

When the script rst2pdf is run, it will trigger the installation of the two dependencies PDF maps to.

But if that does not happen, either the docs are wrong, or there is a bug.
Are there plans to fix it, or did I miss anything?

Are there plans to fix it, or did I miss anything?

I mean, this seems to be still unresolved but there is no "bug" label on it...

the docs say in optional-dependencies section

When the script rst2pdf is run, it will trigger the installation of the two dependencies PDF maps to.

The docs may well be wrong. There was a recent revamp where a passionate user attempted to describe what behavior they expected, but it may not map to the actual implementation. I suspect the actual implementation is that the indicated console script will only be installed if the relevant extras are requested. Here's what the old docs said, and that sounds closer to the implementation.
Hmm. Looking at the docs, that's also consistent with what's written here. In c657e826e, I've corrected the documentation to declare that the behavior is implementation-specific.
In another comment, I'll address the larger issue.

I see that this issue has been fixed in #2194 by bypassing pkg_resources in the easy_install scripts and instead relying on importlib.metadata:
setuptools main $ git clone gh://pganssle/pkg_resources_install_requires_demo
Cloning into 'pkg_resources_install_requires_demo'...
remote: Enumerating objects: 22, done.
remote: Total 22 (delta 0), reused 0 (delta 0), pack-reused 22
Receiving objects: 100% (22/22), 5.00 KiB | 5.00 MiB/s, done.
Resolving deltas: 100% (4/4), done.
setuptools main $ cd pkg_resources_install_requires_demo/
pkg_resources_install_requires_demo master $ source-bash initial_install.sh
(venv)  pkg_resources_install_requires_demo master $ venv/bin/pkg1script
Used from pkg2
(venv)  pkg_resources_install_requires_demo master $ cat venv/bin/pkg1script
#!/Users/jaraco/code/public/pypa/setuptools/pkg_resources_install_requires_demo/venv/bin/python3
# EASY-INSTALL-ENTRY-SCRIPT: 'pkg1','console_scripts','pkg1script'
import re
import sys

# for compatibility with easy_install; see #2198
__requires__ = 'pkg1'

try:
    from importlib.metadata import distribution
except ImportError:
    try:
        from importlib_metadata import distribution
    except ImportError:
        from pkg_resources import load_entry_point

def importlib_load_entry_point(spec, group, name):
    dist_name, _, _ = spec.partition('==')
    matches = (
        entry_point
        for entry_point in distribution(dist_name).entry_points
        if entry_point.group == group and entry_point.name == name
    )
    return next(matches).load()

globals().setdefault('load_entry_point', importlib_load_entry_point)

if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw?|\.exe)?$', '', sys.argv[0])
    sys.exit(load_entry_point('pkg1', 'console_scripts', 'pkg1script')())
(venv)  pkg_resources_install_requires_demo master $ pip uninstall pkg2
Found existing installation: pkg2 0.0.0
Uninstalling pkg2-0.0.0:
  Would remove:
    /Users/jaraco/code/public/pypa/setuptools/pkg_resources_install_requires_demo/venv/lib/python3.9/site-packages/pkg2.egg-link
Proceed (y/n)? y
  Successfully uninstalled pkg2-0.0.0
(venv)  pkg_resources_install_requires_demo master $ pkg3script
Fell back to pkg1
(venv)  pkg_resources_install_requires_demo master $ pkg1script
Fell back to pkg1

All you need to do is make sure you have Setuptools 47.2 or later and Python 3.8 or importlib_metadata installed.


Anchor tag link incorrect

In the "Next steps" section, the link to the javascript example point to the C# example.
It should be replaced by: "https://docs.microsoft.com/en-us/azure/cognitive-services/ink-recognizer/quickstarts/javascript"
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce5a700c-1a23-b19c-8f77-87dd17a7e08c
Version Independent ID: 09be56d8-1b8a-736c-77de-5c70ed0c19f4
Content: What is Ink Recognizer? - Ink Recognizer API - Azure Cognitive Services
Content Source: articles/cognitive-services/Ink-Recognizer/overview.md
Service: cognitive-services
Sub-service: ink-recognizer
GitHub Login: @erhopf
Microsoft Alias: erhopf

@iahmedbacha
Thanks for the feedback! We are currently investigating and will update you shortly.

@iahmedbacha Thanks again for the feedback, I have created a PR to fix it and it should be live soon.


Set up a project security policy

Copy SECURITY.md from OpenEXR or one of the other ASWF projects, keep whatever's relevant and delete whatever doesn't apply to your project. This covers several of the OpenSSF badge requirements, like the policy and expectations.
Other ASWF projects support a<EMAIL_ADDRESS>that forwards to your technical steering committee, but this is somewhat redundant with GitHub's private vulnerability reporting, which you've already configured.

Duplicate of #1650


[Enhancement] Add audit log for TaskRun & use ttl instead of label clean

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

1.add audit log for TaskRun sql
2.use ttl instead of previous clean strategy
The previous Task has a binding with the Label's cleanup mechanism, and now take this parameter out.
The previous cleaning strategy was more complicated, but now it is simpler to unify into TTL. In addition, the Submit task will definitely expire. If there are other types that do not set TTL, they will never be cleaned up.
3.Optimize the submission result of Submit, and prompt Reject when the concurrent high lock acquisition fails.
separate task & taskrun lock and add config for control running taskrun and pending taskrun limit.

[FE PR Coverage check]
:disappointed: fail : 16 / 96 (16.67%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/scheduler/SqlTaskRunProcessor.java
0
62
00.00%

:large_blue_circle:
com/starrocks/scheduler/TaskManager.java
4
19
21.05%

:large_blue_circle:
com/starrocks/scheduler/persist/TaskRunStatus.java
2
3
66.67%

:large_blue_circle:
com/starrocks/scheduler/TaskRunContext.java
2
3
66.67%

:large_blue_circle:
com/starrocks/scheduler/Task.java
3
4
75.00%

:large_blue_circle:
com/starrocks/common/Config.java
2
2
100.00%

:large_blue_circle:
com/starrocks/scheduler/TaskRun.java
2
2
100.00%

:large_blue_circle:
com/starrocks/scheduler/TaskBuilder.java
1
1
100.00%

[FE PR Coverage check]
:disappointed: fail : 42 / 135 (31.11%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/scheduler/SqlTaskRunProcessor.java
0
62
00.00%

:large_blue_circle:
com/starrocks/scheduler/TaskManager.java
25
51
49.02%

:large_blue_circle:
com/starrocks/scheduler/TaskRunManager.java
3
5
60.00%

:large_blue_circle:
com/starrocks/scheduler/persist/TaskRunStatus.java
2
3
66.67%

:large_blue_circle:
com/starrocks/scheduler/TaskRunContext.java
2
3
66.67%

:large_blue_circle:
com/starrocks/scheduler/Task.java
3
4
75.00%

:large_blue_circle:
com/starrocks/common/Config.java
4
4
100.00%

:large_blue_circle:
com/starrocks/scheduler/TaskRun.java
2
2
100.00%

:large_blue_circle:
com/starrocks/scheduler/TaskBuilder.java
1
1
100.00%

run starrocks_fe_unittest

[FE PR Coverage check]
:disappointed: fail : 42 / 137 (30.66%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/scheduler/SqlTaskRunProcessor.java
0
64
00.00%

:large_blue_circle:
com/starrocks/scheduler/TaskManager.java
25
51
49.02%

:large_blue_circle:
com/starrocks/scheduler/TaskRunManager.java
3
5
60.00%

:large_blue_circle:
com/starrocks/scheduler/persist/TaskRunStatus.java
2
3
66.67%

:large_blue_circle:
com/starrocks/scheduler/TaskRunContext.java
2
3
66.67%

:large_blue_circle:
com/starrocks/scheduler/Task.java
3
4
75.00%

:large_blue_circle:
com/starrocks/common/Config.java
4
4
100.00%

:large_blue_circle:
com/starrocks/scheduler/TaskRun.java
2
2
100.00%

:large_blue_circle:
com/starrocks/scheduler/TaskBuilder.java
1
1
100.00%

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage check]
:disappointed: fail : 43 / 140 (30.71%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/scheduler/SqlTaskRunProcessor.java
0
64
00.00%

:large_blue_circle:
com/starrocks/scheduler/TaskManager.java
25
51
49.02%

:large_blue_circle:
com/starrocks/scheduler/TaskRunManager.java
4
8
50.00%

:large_blue_circle:
com/starrocks/scheduler/persist/TaskRunStatus.java
2
3
66.67%

:large_blue_circle:
com/starrocks/scheduler/TaskRunContext.java
2
3
66.67%

:large_blue_circle:
com/starrocks/scheduler/Task.java
3
4
75.00%

:large_blue_circle:
com/starrocks/common/Config.java
4
4
100.00%

:large_blue_circle:
com/starrocks/scheduler/TaskRun.java
2
2
100.00%

:large_blue_circle:
com/starrocks/scheduler/TaskBuilder.java
1
1
100.00%

[FE PR Coverage check]
:disappointed: fail : 48 / 146 (32.88%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/scheduler/SqlTaskRunProcessor.java
0
64
00.00%

:large_blue_circle:
com/starrocks/scheduler/TaskManager.java
25
51
49.02%

:large_blue_circle:
com/starrocks/scheduler/TaskRunManager.java
4
8
50.00%

:large_blue_circle:
com/starrocks/scheduler/persist/TaskRunStatus.java
2
3
66.67%

:large_blue_circle:
com/starrocks/scheduler/TaskRunContext.java
2
3
66.67%

:large_blue_circle:
com/starrocks/scheduler/Task.java
3
4
75.00%

:large_blue_circle:
com/starrocks/scheduler/Constants.java
5
6
83.33%

:large_blue_circle:
com/starrocks/common/Config.java
4
4
100.00%

:large_blue_circle:
com/starrocks/scheduler/TaskRun.java
2
2
100.00%

:large_blue_circle:
com/starrocks/scheduler/TaskBuilder.java
1
1
100.00%


[ListItem] Wrapped component does not receive styling (MakeSelectable)

Problem description
I am trying to wrap ListItem into a custom component to reduce boilerplate/duplicates in my code.
Original code:
    <SelectableList id="menu" value={location}>
        <ListItem primaryText="Encoding" primaryTogglesNestedList={true} value="/encoding" nestedItems={[
            <ListItem primaryText="Base32" containerElement={<Link to="/base32"/>} value="/base32"/>,
            <ListItem primaryText="Base32Hex" containerElement={<Link to="/base32Hex"/>} value="/base32Hex"/>,
            <ListItem primaryText="Base64" containerElement={<Link to="/base64"/>} value="/base64"/>,
            <ListItem primaryText="Base64Url" containerElement={<Link to="/base64url"/>} value="/base64url"/>,
            <ListItem primaryText="Hex" containerElement={<Link to="/hex"/>} value="/hex"/>

as you can see - a lot of duplicities (running version to be inspected can be found here).
So I decided to wrap the component to get rid of duplicates:
const MenuItem = ({anchor, ...other}) => (
      <ListItem value={anchor} {...other} key={"item-"+ anchor}/>
);

But the menu item is no longer selectable (try difference between these two sementically identical approaches)
const App = () => (
  <MuiThemeProvider muiTheme={getMuiTheme()}>
    <SelectableList id="menu" value="/li"> {/* Change here to /mi, update, run -> MenuItem is not selected */}
      <ListItem primaryText="ListItem" value="/li" />
      <MenuItem primaryText="MenuItem" anchor="/mi" />
    </SelectableList>
  </MuiThemeProvider>
);

Example on JsFidle: https://jsfiddle.net/1vk8wzoc/27/
I have asked on StackOverflow and user Chris pointed out the probable cause. I would create a PR, but I am just a beginner when it comes to React, so my repair would probably cause more harm than good :-).

Material-UI: "material-ui": "^0.16.6",
React: "react": "^15.0.1",
Browser: Chrome Version 56.0.2924.87

That's a well know issue. I wish we had a better wait to document it. For now, you can refer to this section of the next branch. We use the same pattern on the master branch https://github.com/callemall/material-ui/blob/6ecaea5db76903ac0e33255859317cb8836682c0/docs/customization/composition.md#wrapping-components.
That should do the trick:
MenuItem.muiName = 'ListItem'

Ok, thanks. I was not aware of this page :-).


Parent items for Agenda items (fixes #2213)

Whenever you create or edit an object that has an agenda entry (agenda item, assignment, motion) you can now chose to assign a "parent item" (or chose "no parent item"). The underlying agenda item's parent_id will be updated accordingly -- See #2213.
What remains up for discussion is the agenda weight of an item, as this decides where under the parent item the agenda item is listed. For now, it is not defined upon update, so probably random. I do not know how this weight is calculated.
In terms of code, I may have added a resolve: or two that are unnecessary, I did not fully understand when which resolve takes place, so it was a try-and-error.
(on a side note: git rebase -i HEAD~7 failed, because the order of the commits is messed up/ reversed on my machine. Is there an easy way to recover from this, without losing the last state?)

I don't understand the reason of travis-ci failing.
The command "DJANGO_SETTINGS_MODULE='tests.settings' coverage
run ./manage.py test tests.integration" exited with 1.

This PR involves both server and client side, so I ping both @normanjaeckel  and @emanuelschuetze

@matakuka I tested your branch with a fresh db and I run into some problems:

After creating some agenda items I opened a new motion create form. There NO agenda items are listed in the drop down list!
If I created a new motion and I try to edit this I get a JS error:
Error: motion.agenda_item is undefined @http://localhost:8000/static/js/motions/site.js:793:53 ...

After creating some agenda items I opened a new motion create form. There NO agenda items are listed in the drop down list!

Apparently there is inconsistent behaviour in browser's interpretation of javascript code, as I remember the "wrong" angularjs filter  working well on my other computer (?). However, on this machine, it fails, too (it just filters out everything).
I deactivated this filter for now in all six instances where it appeared (it took care of the item itself not appearing on the "parent list").
As a workaround, if the item is now selected as it's own parent, the parent sets to "none")

If I created a new motion and I try to edit this I get a JS error: Error: motion.agenda_item is undefined @http://localhost:8000/static/js/motions/site.js:793:53 ...

This was a typo. Now it should work again as expected.

Is there any open question to me? The Travis failure is about the number of database queries in a test case. Maybe it is not possible to override the given field agenda_item_id because this is a read only field. Try to use another name for the new write only field.

@emanuelschuetze ready again for testing

JSHint failed for: openslides/motions/static/js/motions/site.js

2 issues:

Try to edit a custom slide -gets Error: customslide.agenda_item is undefined
Please add item number in parent item field (use getListViewTitle

Ready for testing @emanuelschuetze

Retested - one last thing:

Please use "---" (3x '-') as first element in selection field instead of "No parent (place as new item)".
Rest works good.

@normanjaeckel Please review.

As discussed. Is it possible to merge some code to a reusable (generic) factory? Also do not use it in quick edit forms. Thanks. :-)

done @emanuelschuetze

I think it's ready now @emanuelschuetze

@emanuelschuetze remark on additional resolve done

@matakuka I added some new remarks. Please read and fix all (seems that you forget some older remarks). Then rebase.

fixed and rebased @emanuelschuetze

Retested. Looks good! Also all remarks done. Thanks.
@normanjaeckel Ready for your last review

Thanks for your work. Some small remarks and one bigger question.

Looks good. Rebase.

rebased @normanjaeckel

Ok.

Ok. I'll merge it now...


Can't install v0.2.0

I assume because of the new engines value. Even when I completely uninstall advanced-new-file and install again, the v0.1.0 version is installed.

@lee-dohm do you have problem with 0.2.1?

Yeah, still doesn't install on a master branch compiled version. I think that's what it is, the version checking says that Atom is a pre-release version so unless you specify the exact version it won't install.

@lee-dohm you mean if I don't specify exact version of Atom in package.json?

I forget where I saw it now, but basically since I build from master my Atom version number is v0.178.0-deadbeef (or some other hash). Because of the hash at the end, Node considers this a "pre-release" version. If you say you are compatible with >=v0.5.0, Node only matches that with released versions greater than or equal to v0.5.0, but if you say that you're compatible with >=v0.5.0-alpha1 then it'll accept v0.5.0-beta5 but not v0.6.0-beta9. Or something like that ... like I say, I can't find the reference now :cry:

Orrrr I could be completely wrong and you got bit by atom/atom#5417. It looks like it should be space-separated ... not comma-separated.

I see :) I will take a look at https://github.com/Trudko/advanced-new-file/issues/5 and will release this with it during the weekend.

I've pushed new version please try that one

That one worked, thanks!


Display a report for better error analysis

People are often asking for help when a sign operation doesn't work.
Instead of asking multiple questions or ask the user to show us logs, ... it would be nicer to have access to a page that would display a report the user could give or send to the concerned party.
We could have a small text below the try again button like this

This would lead to a page displaying essential information for debugging
We could prepare a formatted page showing
1/ The url used (for example : /sign/vote?voter=ned&author=krnel&permlink=getting-too-personal-with-ai-assistants&weight=10000)
2/ The complete parameters and operations broadcast
3/ The full stack of the blockchain error
This page would display FAQ and documentations link first and then suggest where to send this report either to steemit support, a discord channel or open a github issue if the user is sure that it's a bug

Thank you, I'm sure this would allow me to fix #209. More than likely an issue with the parameters I am using but without the error response, it's guesswork to figure out what it is.


Doesn't work for some workshops

This userscript is amazing! But sometimes it doesn't work.
When I download the latest workshop of WallpaperEngine, I get an error: Status: Failed to find download link.
But when I downloaded the workshop from a few years ago, it did work.
I guess it may be that WallpaperEngine does some protection mechanism.
Browser console print information:

{
    "method": "GET",
    "url": "http://steamworkshop.download/download/view/2870209872"
}

{
    "method": "POST",
    "data": "app=431960&item=2870209872",
    "headers": {
        "Content-Type": "application/x-www-form-urlencoded",
        "Host": "steamworkshop.download",
        "Origin": "http://steamworkshop.download",
        "Referer": "http://steamworkshop.download/download/view/2870209872"
    },
    "url": "http://steamworkshop.download/online/steamonline.php"
}

No download link found for<PHONE_NUMBER>

Please ignore the last warning,it's not relevant...

Lmao, this was still working? Wow
Anyways, valve AKA steam have changed how workshop downloads work, so the things you could download using my userscript are things that were previously cached by the website im using to download them.
Anything recent is not cached, therefore won't download.
So even if you can download an item, it might be out of date compared to the one on the workshop.
Sadly that's the truth, you need to own the game to freely download from the workshop.

@ArjixWasTaken  you should update the readme , if not then people will still try to use it and waste there time and create a issue here later.

I guess I'll do just that.

All right.What a pity.

Lmao, this was still working? Wow
Anyways, valve AKA steam has changed how workshop downloads work, so the things you could download using my userscript are things that were previously cached by the website im using to download them.
Anything recent is not cached, therefore won't download.
So even if you can download an item, it might be out of date compared to the one on the workshop.
Sadly that's the truth, you need to own the game to freely download from the workshop.


Update README.md

Make it more clear that 8.2.2 and 8.2.1 can be built with master

Sorry, I did not explain myself properly. Made my own update.


yocto build error in do_image_wic phase (no kickstart files found)

HI Leon,
I'm following your guide on Getting Started with RAUC on Raspberry Pi but struggling over a build error:
ERROR: core-image-minimal-1.0-r0 do_image_wic: No kickstart files from WKS_FILES were found: sdimage-dual-raspberrypi.wks. Please set WKS_FILE or WKS_FILES appropriately.

The local conf file contains the line
WKS_FILE = "sdimage-dual-raspberrypi.wks"

I found the file as "sdimage-dual-raspberrypi.wks.in"

All repositories are on branch dunfell:
> vcs branch
.....
=== ./meta-openembedded (git) ===
dunfell
=== ./meta-raspberrypi (git) ===
dunfell
=== ./meta-rauc (git) ===
dunfell
=== ./meta-rauc-community (git) ===
dunfell
=== ./poky (git) ===
dunfell

I'm not very familiar with Yocto. So could you please give a hint to solve that problem.
Thanks a lot !
Best regards,
Michael.

Hi Michael,
Ah, sorry, over the time sdimage-dual-raspberrypi.wks was renamed to sdimage-dual-raspberrypi.wks.in. Could you please update WKS_FILE in your local.conf files as the one below?
WKS_FILE = "sdimage-dual-raspberrypi.wks.in"

I hope this will solved the issue you are experiencing.
Best regards,
Leon

Indeed this solves the issue - thank you very much for the fast help
(and sorry for not testing it on my own - never thought the solution would be so self-evident :smiley:  )


Github action to verify that every commit in a PR compiles on its own

When rebasing a PR with multiple commits; it's tedious to checkout each commit
and ensure the code builds fine.
This GitHub action checkout and build every commit in a PR.
Fixes: #12554
Signed-off-by: Ankur Kothiwal<EMAIL_ADDRESS>Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[x] Thanks for contributing!

Fixes: #issue-number
<!-- Enter the release note text here if needed or remove this section! -->

@nbusseneau Please have a look at the PR.

Requested changes resolved. @pchaigno please take a look.

@nbusseneau I have made the suggested changes. Can you please review the same?

From https://github.com/cilium/cilium/runs/2346163535?check_suite_focus=true:
Rebasing (2/10)

Since the PR has 5 commits, I would have expected this to rebase only 5 commits, not 10 🤔
We should find out why that's not the case. I suggest trying to reproduce the rebase locally to examine what's happening from git's POV.

Really don't understand what's happening. From the raw logs there are only 5 Executing: make clean && make -j 2 && make -C bpf build_all -j 2, which is correct.
The strange thing is every commit seems to be counted twice for rebase purposes:
2021-04-15T20:47:08.5721702Z Rebasing (3/10)
2021-04-15T20:47:08.5722506Z Rebasing (4/10)
2021-04-15T20:47:08.5724819Z Executing: make clean && make -j 2 && make -C bpf build_all -j 2

Does this happen as well when rebasing locally using the same SHAs?

@nbusseneau I ran the git rebase --exec command in my local setup and the command ran successfully but I couldn't get the number of times the git is rebasing commits. Is there something I may run to get this info?

You can run a git rebase with a simple --exec such as git rebase --exec "git rev-parse HEAD".

You can run a git rebase with a simple --exec such as git rebase --exec "git rev-parse HEAD", which has the added bonus of displaying which SHA are actually rebased.
git is rebasing only on 5 commits

You can run a git rebase with a simple --exec such as git rebase --exec "git rev-parse HEAD", which has the added bonus of displaying which SHA are actually rebased.

git is rebasing only on 5 commits

@Ankurk99 @christarazi thanks again for the PR, as a quick reminder for future PRs, please ensure that you either update the release note in the description or remove this section as these end up in the final release notes for the upcoming release:
<!-- Enter the release note text here if needed or remove this section! -->

@Ankurk99 @christarazi thanks again for the PR, as a quick reminder for future PRs, please ensure that you either update the release note in the description or remove this section as these end up in the final release notes for the upcoming release:
<!-- Enter the release note text here if needed or remove this section! -->

Sorry for the incovenience. Will remember this in the future.


Dummy commit

This change is

Codecov Report

:exclamation: No coverage uploaded for pull request base (dummy-master@d4667fd). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             dummy-master      #36   +/-   ##
===============================================
  Coverage                ?   67.89%
  Complexity              ?      216
===============================================
  Files                   ?       28
  Lines                   ?      676
  Branches                ?       16
===============================================
  Hits                    ?      459
  Misses                  ?      212
  Partials                ?        5

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/org/oscm/rest/account/DummyClass4.java
0% <0%> (ø)
0 <0> (?)


Extend rosdep keys upstream

RMF packages require certain python dependencies to be installed manually. It would be beneficial for users building from source and also during binary generation, if these dependencies can be installed automatically via rosdep. They include:

python3-shapely
python3-yaml
python3-requests
python3-flask-cors

Yes, we can use rosdep as it is specified in https://github.com/ros/rosdistro/blob/master/rosdep/python.yaml. I will address this, and append this dep on its relevant package.xml.


Remove unnecessary promise wrapper

Currently, fetch API errors are consumed and ignored by the unnecessary promise wrapper. Discussion can be found here.

This looks great @JasonGhent -- I'll merge this into a feature branch so that I can add a test case for the Promise rejections.


Consider building upstream modules regardless of being changed or not when using -pl and -am

See https://github.com/vackosar/gitflow-incremental-builder#mvn--pl:

Upstream projects of these selected projects are built if:

-am (--also-make) is used
and:

they are changed (or depend on other changed upstream modules) and buildUpstream is not > never or false
or buildAll is enabled

More specifically this part:

they are changed (or depend on other changed upstream modules)

I had a reason to implement it like this but I don't remember. Actually I now think this is counterintuitive and the condition should be dropped.

@mickroll Do you have an opinion about this?

I see 2 main use cases for gib:

ci builds, where only changed modules should be built, on top of an existing workspace of an earlier build.
local, day to day builds where gib should 'not get in the way' (which means something different for any dev)

CI builds may use some more gib configuration, as it is not changed very often.
Local builds should be not need a lot of config parameters. If i supply mvn with a project list, i expect it to be built, regardless of detected changes. So:

-pl should skip change detection
-am, -amd and -rf should also skip change detection

Maybe there is a way to use properties like -Dgib.am (like mvn -am) to have a clear distinction between gib-enhanced and mvn-default behaviour? This would end the discussion which behaviour is 'best' and enable users to directly tell mvn/gib what they want. No guesswork needed.

At some point, I actually thought about something like -Dgib.am but it somehow like reinventing the wheel.
Besides, there is already -Dgib.buildUpstream=... (and -Dgib.buildDownstream). Maybe changed` could be added as value.
So, basically you confirmed what I was thinking. Thanks!


raspimouse_description: 1.0.0-2 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository raspimouse_description to 1.0.0-2:

upstream repository: https://github.com/rt-net/raspimouse_description.git
release repository: https://github.com/rt-net-gbp/raspimouse_description_ros2-release.git
distro file: foxy/distribution.yaml
bloom version: 0.11.1
previous version for package: null

raspimouse_description
* LiDARの追加 (#38 <https://github.com/rt-net/raspimouse_description/issues/38>)
* Merge master branch (ROS1) into ros2 branch (#37 <https://github.com/rt-net/raspimouse_description/issues/37>)
* Update library to rviz2 (#36 <https://github.com/rt-net/raspimouse_description/issues/36>)
* Update tread (ROS 2) (#32 <https://github.com/rt-net/raspimouse_description/issues/32>)
* Update README for ROS 2 (#26 <https://github.com/rt-net/raspimouse_description/issues/26>)
* Support ROS 2 Foxy (#24 <https://github.com/rt-net/raspimouse_description/issues/24>)
* Contributors: Daisuke Sato, Shota Aoki, Shuhei Kozasa

For ROS 2 we're asking people to use a release repository hosted in ros2-gbp so we can do additional automation for you. To that end please request to setup a release repository here: https://github.com/ros2-gbp/ros2-gbp-github-org

Thank you! We will make a request to create a new repository there.
I will close this pull request.


Allow omitting types for fields with an initializer

For this to work, the work should be shifted from declaration phase to the definition phase.

At the definition phase, a macro can no longer augment other classes but only the class it's applied to. If the parsing is done by the generated parser class, then there must be a macro application on it. Such an application must be generated by Args macro when generating the parser class.
This is currently not implemented in the Dart SDK:

https://github.com/dart-lang/sdk/issues/56042

A workaround would be to move the parsing into a new static method in the arguments data class. On one hand, we don't want to pollute its namespace because it's the user's class. On the other hand, making that in the parser class will require defining a new macro that will be visible in the args_macro.dart library the user imports.


Deleted redundant code in MIQ AE Controller

Check for generated flash messages no longer needed with the code fix in https://github.com/ManageIQ/manageiq/pull/6525
New begin/rescue block in ci_processing/process_elements generates flash messages

@dclarizio @h-kataria Redundant code removal, please review.

LGTM


tasks.TASK_NAME.status failed to resolve

Summary
What happened/what you expected to happen?

Passing in variables tasks.TASK_NAME.status causes a failed to resolve error.
Internal Server Error: templates.main.tasks.task2 templates.task2-template: failed to resolve {{tasks.task1.status}}

Diagnostics
What Kubernetes provider are you using?
AKS
What version of Argo Workflows are you running?
v2.11.3
Workflow Sample:
metadata:
  name: xyz-
  generateName: xyz-
  namespace: ml-workflow
spec:
  templates:
    - name: main
      dag:
        tasks:
          - name: task1
            template: task1-template
          - name: task2
            template: task2-template
    - name: task1-template
      container:
        name: task1
        image: alpine:latest
    - name: task2-template
      container:
        name: task2
        image: alpine:latest
        env:
          - name: INPUT_PATH
            value: "{{tasks.task1.status}}"
  entrypoint: main

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

are you getting this error in CLI or server log?

I tried submitting via UI and also via python. I didn't try using cli
On Mon, Nov 2, 2020, 7:25 AM Saravanan Balasubramanian <
<EMAIL_ADDRESS>wrote:

are you getting this error in CLI or server log?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/argoproj/argo/issues/4430#issuecomment-720264781, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6JKJF6DI2B6QOO4TN7LTTSNZGHNANCNFSM4TG2GNZA
.

the template name is missing in variable "{{main.tasks.task1.status}}"
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: xyz
  generateName: xyz-
  namespace: argo
spec:
  templates:
    - name: main
      dag:
        tasks:
          - name: task1
            template: task1-template
          - name: task2
            template: task2-template
    - name: task1-template
      container:
        name: task1
        image: alpine:latest
    - name: task2-template
      container:
        name: task2
        image: alpine:latest
        env:
          - name: INPUT_PATH
            value: "{{main.tasks.task1.status}}"
  entrypoint: main

HI @sarabala1979 ,
Thank you for quick response. I tried with template name, now i don't get any error but status value is not replaced. Please find below sample workflow,
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: xyz
  generateName: xyz-
  namespace: argo
spec:
  templates:
    - name: main
      dag:
        tasks:
          - name: task1
            template: task1-template
          - name: task2
            template: task2-template
            dependencies: ["task1"]
    - name: task1-template
      container:
        name: task1
        image: alpine:latest
    - name: task2-template
      container:
        name: task2
        image: alpine:latest
        command: ["printenv"]
        env:
          - name: INPUT_PATH
            value: "{{main.tasks.task1.status}}"
  entrypoint: main

Task2 Logs(First 3 lines),
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=xyz-563385519
INPUT_PATH={{main.tasks.task1.status}}

Please suggest how to make sure status is replaced.
Thanks.

@sarabala1979 you got some time to check this issue. This is really blocking us.
Thank you for your time.

@sarabala1979 it will really good to solve this issue, we are blocked on our implementation.

/bug

hello, is there any update here? getting the same behavior as well

Facing the same issue, any advice?
failed to resolve {{tasks.task.status}}

@SiddharthMalhotra are you facing  in exit hook?

I'm facing it in an exit hook


Setting Score Threshold Per Class

I have modified COCOeval.summary to return the score threshold that maximizes F1 score per class Now I would like to use the returned scores with my models at inference
How could I set these 'optimal' score threshold per class in mmdetection?

Currently, we don't support setting score threshold for each class individually. But you can implement it yourself. The filter step is in there:
https://github.com/open-mmlab/mmdetection/blob/048c41a8d00f57ed33affd0ea73c8bc6de76e98a/mmdet/core/post_processing/bbox_nms.py#L31-L42

Thanks, I am going to check it

Thanks, I am going to leave my solution here in case someone needs it
If your code specifies a list as the class-wise score thresholds before init_detector(), e.g in case of 3 classes
cfg.test_cfg.rcnn.score_thr=[0.82, 0.6, 0.74]
model = init_detector(cfg, cfg.load_from, device='cuda:0')

it is only required to transform list to torch.Tensor appropriately before score thresholding at multiclass_nms(), i.e.:
 if type(score_thr) == type([]):
   if multi_scores.is_cuda:
     score_thr = torch.cuda.FloatTensor(score_thr);
   else:
     score_thr = torch.FloatTensor(score_thr);

 # filter out boxes with low scores
 valid_mask = scores > score_thr


Not clear where client-id comes from

Under "Configure and compile your app" it states:
azure.keyvault.enabled=true
azure.keyvault.uri=Your-Keyvault-uri
azure.keyvault.client-id=Your-Client-ID
azure.keyvault.tenant-id=Your-Tenant-ID
However, nowhere on the page is it described where you should get this "client-id". Tenant-id is also not very clear but if you run az keyvault list you are actually able to retrieve this. I have no idea where the client-id should come from.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43e25b58-811b-ec83-0251-7a641d4a7670
Version Independent ID: 55deb14a-7feb-fcf3-95e7-5e947f5fb061
Content: How to use the Spring Boot Starter for Azure Key Vault
Content Source: articles/java/spring-framework/configure-spring-boot-starter-java-app-with-azure-key-vault.md
Service: key-vault
GitHub Login: @bmitchell287
Microsoft Alias: brendm

@jonckvanderkogel thanks for pointing out the missing info! We'll investigate and update the topic.

@KarlErickson that's great, thank you. In the meantime, could you please confirm that what I need to do here is create a service principal which will give me the client-id I need to link my application to the key vault? I have been trying to piece together other parts of the documentation and it would appear that the service principle is the way to go but if you could confirm it that would be great and potentially save me some time on a path that will not pan out. Thanks!

@jonckvanderkogel unfortunately I'm not a subject-matter expert here, but I've brought it to the attention of the product team.

Fixed in https://github.com/MicrosoftDocs/azure-dev-docs-pr/pull/921 .  #pleaseclose

Thanks, @edburns !


Add project_description [REPLACEMENT ISSUE]

The original issue
Id: 71
Title: Add project_description

could not be created.
This is a dummy issue, replacing the original one. It contains everything but the original issue description. In case the gitlab repository is still existing, visit the following link to show the original issue:
TODO

In GitLab by @yliefting on Dec 7, 2020, 14:15
This would be a great addition allowing a few lines of info on the project. The other fields are too restrictive and do not allow you to describe, for example, what the goal/research question of the project is.

In GitLab by @kbubnicki on Dec 7, 2020, 14:17
Good idea! What about abstract or summary instead of description?

In GitLab by @peterdesmet on Dec 7, 2020, 16:27
Any of these terms is ok for me, I just opted for description as that is used in the data package specs for the package description/summary/abstract and thought it nice to reuse that: https://specs.frictionlessdata.io/data-package/#description

In GitLab by @kbubnicki on Dec 8, 2020, 12:06
Actually, that was more or less my reasoning i.e. to change it to abstract or summaryas it can be confusing when we have two description fields. Alternatively, we can skip adding this new field and assume that this short project's description can be part of package's description?

In GitLab by @peterdesmet on Dec 8, 2020, 13:13
Yes, but package description has to be Markdown (not something I'm sure is the case for all project descriptions).
And in general, I like to avoid adding too much dataset/package metadata (title, description, licenses) in the datapackage.json, since 1) those are things have to be populated in the metadata fields of a repository like Zenodo anyway, 2) they require a bit more writing to make external users understand (not a text that is readily available in the DB) and 3) by making it part of the file, it is harder to correct those errors in e.g. Zenodo (as it is considered data, not metadata). For the project information, I'm fine having this in datapackage.json as it is something that is directly exported from what the researcher wrote in the DB. I therefore like description at that level.

In GitLab by @peterdesmet on Jan 15, 2021, 14:20
Decided to add project: description and recommended (not require) markdown. This field is not required.

In GitLab by @peterdesmet on Jan 15, 2021, 14:20
assigned to @peterdesmet and unassigned @kbubnicki

In GitLab by @peterdesmet on Jan 15, 2021, 15:16
assigned to @kbubnicki

In GitLab by @peterdesmet on Jan 15, 2021, 15:16
unassigned @peterdesmet

In GitLab by @kbubnicki on Jan 15, 2021, 17:25
I am not sure how to formulate description of this description field ;) @peterdesmet can you look at the proposal below?
"description": {
  "description": "Description of the project. Adding a corresponding markdown-style description at a data package level is recommended but not required.",
  "type": "string",
  "format": "default"
}

In GitLab by @peterdesmet on Jan 18, 2021, 11:45
mentioned in commit a2a8749c06bc7ae01fdc65ebedb96a17133d1225

In GitLab by @peterdesmet on Jan 18, 2021, 11:46
Great, I've added it in a2a8749c as:

Description of the project, ideally expressed in Markdown format. To describe the data package itself, use https://specs.frictionlessdata.io/data-package/#description.


map change of split in stocks

For the moment, it is assumed return of separate stock isin. This is due to the fact that the dataset does not contain information about the percentage of split


Add Custom CoM

Add an empty GameObject and move it to were the center of mass should be before adding it to the new serialized field in the physics script. It will use that objects transform.

I would set custom COM to rigidbody rb.centerOfMass = com.position, because rigidbody of an airplane in this simulation is not kinematic, so some of calculations happen inside unity's rigidbody


UnsupportedClassVersionError

Jenkins and plugins versions report

Environment

Paste the output here

What Operating System are you using (both controller, and any agents involved in the problem)?
java.lang.UnsupportedClassVersionError: com/sun/xml/bind/StackHelper has been compiled by a more recent version of the Java Runtime (class file version 53.0), this version of the Java Runtime only recognizes class file versions up to 52.0
Reproduction steps
withAWS(role: "${AWS_ROLE_ARN}", region: "${AWS_REGION}") {  // try to upload to s3 bucket }
Expected Results
it should upload to s3 bucket
Actual Results
it seems code is compiled with java9 which is mistach with java8. Here is stacktrace: java.lang.UnsupportedClassVersionError: com/sun/xml/bind/StackHelper has been compiled by a more recent version of the Java Runtime (class file version 53.0), this version of the Java Runtime only recognizes class file versions up to 52.0
Anything else?
No response

We have the same issue, builds keep failing when uploading to s3


Nice work!

Nice work!
Originally posted by @ghost in https://github.com/termux/termux-tasker/pull/36#pullrequestreview-545746846

Hello everyone, I'm going to close this issue as a spam.


Modbus exception with d.scan() on SMA inverter

Dear developers,
I get a Modbus exception with v1.0.4 (both via pip3 install as well as from master branch) when trying to scan() an SMA inverter (STP-5000TL-20 via Ubuntu 20.04.02 LTS), see below:
$ python3
Python 3.8.5 (default, Jan 27 2021, 15:41:15)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import sunspec2.modbus.client as client
d = client.SunSpecModbusClientDeviceTCP(slave_id=126, ipaddr='<IP_ADDRESS>', ipport=502)
d.scan()
Traceback (most recent call last):
File "", line 1, in
File "/home/dennis/.local/lib/python3.8/site-packages/sunspec2/modbus/client.py", line 262, in scan
model.read()
File "/home/dennis/.local/lib/python3.8/site-packages/sunspec2/modbus/client.py", line 85, in read
data = self.model.device.read(self.model.model_addr + self.offset, self.len)
File "/home/dennis/.local/lib/python3.8/site-packages/sunspec2/modbus/client.py", line 317, in read
return self.client.read(addr, count, op)
File "/home/dennis/.local/lib/python3.8/site-packages/sunspec2/modbus/modbus.py", line 584, in read
data = self._read(addr + read_offset, read_count, op=op)
File "/home/dennis/.local/lib/python3.8/site-packages/sunspec2/modbus/modbus.py", line 545, in _read
raise ModbusClientException('Modbus exception %d: addr: %s count: %s' % (except_code, addr, count))
sunspec2.modbus.modbus.ModbusClientException: Modbus exception 2: addr: 40085 count: 98

Any idea how to solve this?
I modified the exception, to also show len(resp)=9 and resp[TCP_HDR_LEN+1]=0x83, the output is below, and I hope this helps to analyse the issue:
  File "/home/dennis/compiling/SST/pysunspec2/sunspec2/modbus/modbus.py", line 545, in _read
    raise ModbusClientException('Modbus exception %d: addr: %s count: %s, len(resp)=%d, resp[TCP_HDR_LEN+1]=0x%x' % (except_code, addr, count, len(resp), resp[TCP_HDR_LEN + 1]))
sunspec2.modbus.modbus.ModbusClientException: Modbus exception 2: addr: 40085 count: 98, len(resp)=9, resp[TCP_HDR_LEN+1]=0x83

Kind regards,
Dennis

This SMA device is likely not pySunSpec2-compliant.  You'll have to use the original pysunspec python library because it is not backward compatible.  There were major revisions to the structure of the datatypes when SunSpec moved to pysunspec2.  Try: https://github.com/sunspec/pysunspec

We will look at this in more detail but wanted to clarify the comment from @jayatsandia. pysunspec2 should be compatible with all SunSpec compliant devices and is backward compatible with all SunSpec standard model definitions and implementations. We recommend that you replace pysunspec with pysunspec2 for SunSpec device interaction. Support for pysunpec is very limited. The scripting syntax when interacting with devices is a little different in pysunspec2 than pysunspec so minor adjustments may be needed to scripts moving from pysunspec to pysunspec2.
SunSpec has updated the modeling and model definitions but still supports all existing model definitions.

My mistake.  I misunderstood the following statement in the pySunSpec2 README: "The Python objects used for interacting with devices have some differences from version 1 and it is not backward compatible with version 1. This version of pySunSpec must be used with devices implementing the 7xx series of information models as they use updated modeling concepts."

No worries, good to clarify.

Hi again,
I created a simple Python program sma-test.py.txt to test the addresses and length fields for the different modules and this appears to work fine for my SMA inverter:

checkFromPICS(): start registers from each module sheet of the PICS file
checkWithOffsets(): using length registers when starting with register 40002 for the first ID, and length on the following register address. It stops when length=0

Here is the output for the offset test:
$ ./sma-test.py
40002: ID=1
40003: L=66
40070: ID=11
40071: L=13
40085: ID=12
40086: L=98
40185: ID=103
40186: L=50
40237: ID=120
40238: L=26
40265: ID=121
40266: L=30
40297: ID=122
40298: L=44
40343: ID=123
40344: L=24
40369: ID=124
40370: L=24
40395: ID=126
40396: L=64
40461: ID=127
40462: L=10
40473: ID=128
40474: L=14
40489: ID=131
40490: L=64
40555: ID=132
40556: L=64
40621: ID=160
40622: L=48
40671: ID=4335
40672: L=0
Kind regards,
Dennis

Can confirm this issue also happens on SMA SB 4000 TL, SB 1500, SB2000 TL and SB Storage 2500. So probably all SMA devices. Communication works just fine when using the old pysunspec library.

Can confirm this issue also happens on SMA SB 4000 TL, SB 1500, SB2000 TL and SB Storage 2500. So probably communication wih all SMA devices is affected. Communication works fine when using the old pysunspec library.

It looks like I have the same problem with my SMA SB 3000TL-21
How can you use the old pysunspec library? Which file(s) do you need for that?

@bijwaard There was an issue with models reads being two registers short that we fixed in the latest release. Can you update pysunspec2 and try again?


Create company links and GTM tracker components

Traditionally, these components have been copied/pasted between tenants using Leaders. This consolidates them within the leaders package.

 Add leader (company) "impression" tracking


Insiders doesn't open with WSL anymore

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.67.0-insider (user setup)
Commit: b84feecf9231d404a766e251f8a37c730089511b
Date: 2022-04-11T05:15:52.676Z
Electron: 17.4.0
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Steps to Reproduce:

Start WSL terminal
Run code-insiders ./

Expected:
It installs VS code server and launches in WSL mode
Actual:
It treats the open the same as opening a normal windows path.
For example, the terminal window gives this error:
> Executing task: npm run compile <

'\\wsl$\Ubuntu\home\rich\source\vscode-jupyter'
CMD.EXE was started with the above path as the current directory.
UNC paths are not supported.  Defaulting to Windows directory.
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path C:\Windows/package.json
npm ERR! errno -4058
npm ERR! enoent ENOENT: no such file or directory, open 'C:\Windows\package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

npm ERR!      C:\Users\aku91\AppData\Local\npm-cache\_logs\2022-04-11T16_32_47_086Z-debug.log
The terminal process "C:\Program Files\PowerShell\7\pwsh.exe -Command npm run compile" terminated with exit code: 1.

Terminal will be reused by tasks, press any key to close it.

Window title bar doesn't indicate WSL anymore (like stable does)
Insiders:

Same directory in stable:


Feature request: Zoom on mouse wheel

Ability to Zoom images on mouse wheel like google drive

Any update on mobile zooming?

You should be able to pinch zoom the page (including image) on mobile.
For better pinch zoom, as well as wheel zoom, please see the lightbox library I made this year:
Demo: https://biggerpicture.henrygd.me/
Repo: https://github.com/henrygd/bigger-picture
I'm going to close this issue as I don't forsee this being added to bigpicture. Handling zoom / panning adds a good amount of weight, and one of the only reasons to use this instead of bigger-picture is the slightly smaller size.

Thanks for the link  to biggerpicture. It provides the solution we were looking for!


> considered as valid symbol instead of punctuation

>example.com
>http://example.com

https://github.com/markdown-it/linkify-it/issues/2#issuecomment-76085926

Thanks.

https://github.com/markdown-it/linkify-it/commit/b20833215113508e02373fbbfd610c7d49fb10ea
I've added a bit more symbols to exclusion for fuzzy links, but not all https://github.com/mathiasbynens/unicode-7.0.0/blob/master/categories/S/regex.js. Don't know if there are any other cases need to be covered.


Fail to map <C-S-HJKL> to resize splits

Here is my configuration
return {
  "aserowy/tmux.nvim",
  event = "VeryLazy",
  opts = {
    resize = {
      enable_default_keybindings = false,
    }
  },
  config = function(_, opts)
    local tmux = require("tmux")
    tmux.setup(opts)
    map("n", "<C-S-H>", "<cmd>lua require('tmux').resize_left()<cr>", "resize")
  end
}

But nothing happen when I press <C-S-H>. Is it a limitation of tmux to bind <C-S-*> keys?

Just out of curiosity, do you use Kitty as your terminal?

Just out of curiosity, do you use Kitty as your terminal?

For my case, yes.
Seems like M-x for resizing works fine, while C-x(hjkl) doesn't.
And the kitty windows jumping via vim-kitty-navigator by pressing C-x(hjkl) is fine...


fatal error with new version 3.0.0

Shopware: 5.6.8
PHP: 7.3.29
Adyen 3.0.0
When we install the 3.0.0 update, we get a fatal error:
Fatal error: Declaration of Shopware\Components\Log\Handler\ChromePhpHandler::sendHeader($header, $content) must be compatible with Monolog\Handler\ChromePHPHandler::sendHeader(string $header, string $content): void in /engine/Shopware/Components/Log/Handler/ChromePhpHandler.php on line 34

Same error
Shopware: 5.6.10
PHP: 7.3.29
Adyen 3.0.0
Right after clicking on update.

Thanks for the suggestion @ifbidev, indeed this is a problem with the package zip file and we're updating it soon. @webtech-tom be aware that after deleting the contents of the package and cloning the master branch you also need to install the package's dependencies https://docs.adyen.com/plugins/shopware-5/?tab=git_hub_3


Milestone 0.4.0

Describe your changes

Linked issues

Closes
Breaking changes

[ ] This issue contains breaking changes

Codecov Report
Base: 70.26% // Head: 69.83% // Decreases project coverage by -0.43% :warning:

Coverage data is based on head (2825b3c) compared to base (3e066c0).
Patch coverage: 54.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   70.26%   69.83%   -0.44%
==========================================
  Files          53       53
  Lines        1527     1545      +18
  Branches      105      106       +1
==========================================
+ Hits         1073     1079       +6
- Misses        424      437      +13
+ Partials       30       29       -1

Impacted Files
Coverage Δ

...n/kotlin/com/swmansion/starknet/account/Account.kt
100.00% <ø> (ø)

...knet/data/types/transactions/TransactionPayload.kt
100.00% <ø> (ø)

...kotlin/com/swmansion/starknet/provider/Provider.kt
20.00% <0.00%> (ø)

...swmansion/starknet/provider/rpc/JsonRpcProvider.kt
77.69% <0.00%> (ø)

...on/starknet/data/types/transactions/Transaction.kt
69.84% <52.63%> (-3.78%)
:arrow_down:

...nsion/starknet/provider/gateway/GatewayProvider.kt
89.91% <77.77%> (+0.04%)
:arrow_up:

.../com/swmansion/starknet/account/StandardAccount.kt
100.00% <100.00%> (ø)

...tlin/com/swmansion/starknet/crypto/NativeLoader.kt
29.03% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Before merging, replace the RequestFailedException in the OkHttpProvider with a custom, unchecked exception indicating that the error was caused by network problems (to differentiate between this and StarkNet level errors).


Store dependencies and versions in INSTALL_RECEIPT.json

The tab for an installed formula should include a new key with an array of all the runtime (i.e. non-build dependencies) used to build the formula.
Extracted from https://github.com/Homebrew/brew-evolution/blob/master/003-install-bottles-of-arbitrary-versions.md merged in https://github.com/Homebrew/brew-evolution/pull/6.
CC @sjackman

I don't yet have an implementation of this feature. Someone else is welcome to tackle this if they're so inclined. Otherwise I will eventually get to it, work permitting.


History of searches/replacements in search/replace dialog

A history of last n searches in the search dialog and additionally of last n replacments in the replace dialog would be very helpful. Thank you.

You can navigate through search/replace history with the arrow keys (or alt+arrow keys in 1.24 and before).


Feature idva5 178 unincorporated journey] what is the correspondence address

-created what is your correspondence address
-add unit test

CI: No security warnings found

CI: No security warnings found


New GPTs to add - YT Shorts Expert

https://chat.openai.com/g/g-wc6rx2PRi-yt-shorts-expert
Thank you!

Please raise a pull request for the same


Update to 1 in STEP and README.md

Update the game over message so people know how to play again!

done


Switch Window

Should have a keyboard shortcut (e.g., Ctrl + Shift + R).
Use the same labels as Open Recent (Ctrl + R) to not be confusing.
Show entries in MRU order.
Support cycling through by holding modifiers while pressing the main key repeatedly.

I think our current "Open Recent" is coming very close to this?

You might be right, I'll try working with that for a bit.

/cc @dbaeumer

@bpasero  Thanks.
As discussed would be cool to cycle through them as we can cycle with Ctrl+P through files.

@chrmarti @dbaeumer now I just realized that we do have a picker for windows:

This is a good start, can you let me know how it works for you?
Meanwhile I am pushing the following changes to this picker:

make it discoverable from the picker help by using a quick open prefix "window "
allow to use the picker with quick navigate keys (so that you can bind a keybinding to navigate through windows and pick it when releasing that key)
show icons

I am not 100% convinced this list should be MRU, rather I think it should be stable and you should always start from the top to find your window. But I am open to change this if we think it does not work.

Quick navigation works except for rare cases where it immediately navigates before I release the modifiers. (Using Ctrl+Shift+R for next, Ctrl+R for previous.)
It would be great if the labels would show the folder first and then its path, similar to Open Recent. The current list is hard to read.

What I like about Ctrl+R is that I don't have to think about whether the windows is open or not. With switch window I do :-). I am already a heavy user of Ctrl+R now.

Just try it out.
LOVE IT.  ❤
I don't need something else, it's just great.

What I miss with Open Recent (Ctrl+R) is the quick navigation (repeated Ctrl+R), maybe that can be added?
Having a list of only the open windows/folders like with Switch Window can be helpful because it represents my "working set".
I'm using Ctrl+R and Cmd+ quite often, but find both have their shortcomings, so I tried using Switch Window. (Cmd+  is Mac's shortcut to switch between windows of the same application.)

@chrmarti there is a bug with quick navigation that should be fixed in my new implementation, can you give it a try via "running out of sources"?
As for the labels, I chose to pick the exact same label that the window actually has and since the window title is configurable (via settings), maybe you can get it to a state where the label works for you? For example:
"window.title": "${rootName}${separator}${activeEditorShort}"
Produces:

@jens1o cool
@chrmarti @dbaeumer yes, we can add quick navigation to Ctrl+R, I can probably do that by turning it into a real picker, similar to what the window switcher is now. It seems to me that once we have that you would no longer use Switch Window. Is something else missing for the recent picker? Would you want to know which of the recent things is opened in another window?

Could only be the once sorted to the top. Or. Since it is LRU. I am fine without that info.

@dbaeumer it is worth mentioning that the "open recent" MRU sorting order is not influenced by you switching windows via Alt+Tab on Windows, it is only influenced by actually picking an entry from the list. As long as you stick to that, you are probably fine.

Open Recent:
Having quick navigation and an indicator for which ones are already open would be great.
While I'm not entirely sure about the indicator, I think it might help navigate in the "working set". It would also help in knowing when to press Cmd (or Ctrl) to open the folder in a new window. Not sure what a good indicator would be, maybe the background color plus something?
Switch Window:
"window.title": "${rootName}${separator}${rootPath}" works well for me with windows on folders (the important case for me), windows without folders might benefit from an alternative label.
The issue with quick nav in Switch Window shows when running the latest from master.
I agree we might not need Switch Window if Open Recent can cover it.

@chrmarti what is your keybinding config for this when running out of master and what is your OS and what are your steps so that quick nav fails?

@bpasero the only thing I could think of having two groups like Ctrl+P has. One open and one recently open.

@bpasero This is on Mac. Steps are:

Hit Ctrl+Shift+R twice without releasing Ctrl+Shift with releasing R between and at the end.
You'd expect the drop-down to stay, but it sometimes closes and switches the window.

This doesn't always happen and I can currently not reproduce. (If that sounds like the problem you fixed, maybe I was running from an old build state, although I thought I had updated that.)
[
	{
		"key": "ctrl+shift+r",
		"command": "workbench.action.switchWindow"
	},
	{
		"key": "ctrl+shift+r",
		"command": "workbench.action.quickOpenNavigateNext",
		"when": "inQuickOpen"
	},
	{
		"key": "ctrl+r",
		"command": "workbench.action.quickOpenNavigatePrevious",
		"when": "inQuickOpen"
	}
]

@chrmarti I can also not reproduce. What I noticed is that there is an issue with switching windows (= giving focus on it) during the keyup-phase so I added a short timeout here to unwind from the callback.
If you can ever reproduce again please see if tweaking that timeout helps.

I have pushed additional changes:

you can now bind to the new workbench.action.quickOpenRecent command to quick pick from recent
you can now bind to the new workbench.action.quickSwitchWindow command to quick pick from windows

Quick Switch Recent
{
	"key": "ctrl+r",
	"command": "workbench.action.quickSwitchWindow"
},
{
	"key": "ctrl+r",
	"command": "workbench.action.quickOpenNavigateNext",
	"when": "inQuickOpen"
}

Quick Switch Window
{
	"key": "ctrl+r",
	"command": "workbench.action.quickSwitchWindow"
},
{
	"key": "ctrl+r",
	"command": "workbench.action.quickOpenNavigateNext",
	"when": "inQuickOpen"
}

See https://github.com/Microsoft/vscode/issues/25145#issuecomment-306722123 for verification.


src/java/CMakeLists.txt: Modified path for javac and jar

Signed-off-by: Andrei Vasiliu<EMAIL_ADDRESS>

Merged, please add more details on why you do things like this in the commit msg next time.

Hello.
On 9 Oct 2015 4:38 pm, "Brendan Le Foll"<EMAIL_ADDRESS>wrote:

Merged, please add more details on why you do things like this in the
commit msg next time.
Sorry about that. I will be more explicit next time.

Andrei

—
Reply to this email directly or view it on GitHub.


Regression in expect_table_columns_to_match_ordered_list

Hello, this appears to have regressed in dbt 0.21.0 and dbt_expectations 0.4.4. It looks like it happened here: https://github.com/calogica/dbt-expectations/commit/c698a1a1108435c18cc7680885795aeb47b8fe74#diff-14b201719d47d2b58e18a4896f8cb1d1f0bc3b414694499ef5eb738b683fb955L11-L12
It was fixed in #99

Hi @mirosval ! Could you describe what error you're seeing and what platform you're on? The PR you reference that fixed  #99 (which was PR #101) used the old way of deriving the missing columns. We changed this to a join based approach that doesn't rely on this type casting to varchar anymore.

Thanks for looking into this!
The error is the same, failed to find conversion function from "unknown" to text
The rendered SQL is:
select
      count(*) as failures,
      count(*) != 0 as should_warn,
      count(*) != 0 as should_error
    from (
      with relation_columns as (
        select
            1 as relation_column_idx,
            'DIM_DATE' as relation_column               <---- HERE
    ),
    input_columns as (
        select
            1 as input_column_idx,
            'DIM_DATE' as input_column                  <---- HERE
    )
    select *
    from
        relation_columns r
        full outer join
        input_columns i on r.relation_column = i.input_column and r.relation_column_idx = i.input_column_idx
    where
        -- catch any column in input list that is not in the sequence of table columns
        -- or any table column that is not in the input sequence
        r.relation_column is null or
        i.input_column is null
    ) dbt_internal_test

When I run this SQL in Redshift it fails with the above error, when I add ::text to the places pointed out in the snippet, it works.
As far as I can tell, this code corresponds to what is currently on master.

Got it, thanks! I'll try and get to this in the next couple of days, unless you want to beat me to it with a PR ;)


Error at example run

I run these cammands
var mma = require('mma');
var name = process.argv[2] + " " + process.argv[3];
mma.fighter(name, function(data){
console.log(JSON.stringify(data));
});
and I get the following error
/home/user/node_modules/request/index.js:44
throw new Error('undefined is not a valid uri or options object.')
^
Error: undefined is not a valid uri or options object.
at request (/home/user/node_modules/request/index.js:44:11)
at Object.module.exports.getFighter (/home/user/node_modules/sherdog/lib/sherdog/index.js:16:3)
at /home/user/node_modules/mma/lib/mma/index.js:105:13
at Request._callback (/home/user/node_modules/mma/node_modules/google/lib/google.js:85:7)
at Request.self.callback (/home/user/node_modules/request/request.js:185:22)
at Request.emit (events.js:182:13)
at Request. (/home/user/node_modules/request/request.js:1161:10)
at Request.emit (events.js:182:13)
at IncomingMessage. (/home/user/node_modules/request/request.js:1083:12)
at Object.onceWrapper (events.js:273:13)
this might be probably a flaw in the API.

Looks like an issue with the google search api. You might be accessing it from a weird proxy server that's blocked. Try using the search-engine-client npm package in place of the google package.


README volumes -> binds

I believe that is how volumes/binds should be described in README. Because currently it's misleading and people have problems because of that (see https://github.com/chef-cookbooks/docker/issues/428).

This has been discussed and is a difference between the API and the CLI. API talks about binds while CLI talks about volumes (-v). We settled on calling them volumes as people work mostly with CLI and less with the API.

@chasebolt I'm not sure what do you mean. This PR is not about naming resource attributes in this cookbook. It's about keeping documentation up to date with code.

Volumes is the property to use. We have deprecated binds (which is an alias to volumes now).

@chasebolt ah, I see. I probably use old version of cookbook.


Add restart wihin restage Epinio command in CLI

Issue
After https://github.com/epinio/epinio/pull/2227 an env var would take effect if deployed in a later stage; however, it would require to restage first and restart later.
Request
The request is to minimize these 2 actions by doing a restart automatically after a restage and ensure that the additions of env vars take place
So instead of doing this...
epinio push --name testapp-githuburl --git https://github.com/epinio/example-go,main
epinio app env set testapp-githuburl BP_KEEP_FILES 'static/*'
epinio app restage testapp-githuburl
epinio app restart testapp-githuburl

... we could drop the last command and still work

We can add a --restart flag to the restage command. If no workload is present, or the instances are scaled to 0 then only arestage will be performed.

Checked restage includes restart by default
Checked --no-restart flag after restage prevents from restarting
Tested in v1.9.0-rc2-1-g2240f783 like this:
epinio push --name testapp-githuburl --git https://github.com/epinio/example-go,main
epinio app env set testapp-githuburl BP_KEEP_FILES 'static/*'
epinio app restage testapp-githuburl

Note: Checked also ui did not inherited this implementation.

Rechecked in v1.9.0-rc3and working:


style: convert forward slashes to backslashes for Windows paths

Ah yes, a leftover from a previous version. Although I think I'm still gonna stick with the #include <Aris/Author/Name> syntax as it goes nicely with the package syntax Author/Name. Or have you encountered any problems because forwardslashes were used instead of backslashes in paths?


Rename Project "ngx-semantic-ui"

This one has been a long time coming, ever since Angular 2 became "just angular" and started asking people to avoid the ng2 prefix, hence ngx-semantic-ui.
I wanted to open it as an issue however to let anyone weigh in on the name change / suggest alternatives before I go through with it.
A potential alternative that has been raised is ng-semantic-ui, though with the major project ngSemantic my worry is they're too similar.
What do people think?

According to this, acceptable names for 3rdparty lib could be:

ng-semantic-ui
angular-semantic-ui

Said that I've seen ng-semantic-ui, angular-semantic-ui and ngx-semantic-ui are already used in (www.npmjs.com).
I'd prefer to avoid the ngx- prefix; so  if you think ng-semantic-ui (my favourite) could generate confusion, go for angular-

I think ng- or angular-semantic-ui. Not too similar to ngSemantic for me.

I would prefer angular-semantic-ui or angular-semanticui.

angular-semantic-ui here!

My personal preference is for ngx- mostly just because this means it's Angular (as opposed to AngularJS) because a lot of the older AngularJS projects used ng-. Having said that, I see that Angular now promotes angular- or ng-, so whatever my preference is, it sounds like you should rather go for one of those. Of course the other option (according to Angular) is Semantic UI for Angular but that's rather long-winded (and how do you name your package in npm then?).

ngx-  for me

Thank you everyone for your collective input. I've thought a lot about this, and I've decided to go with just plain ng-semantic-ui for a number of reasons.
The primary few are that:

Avoiding the x is superior as it's a remnant of AngularJS, enough time has passed for people to see that Angular or ng means Angular 2+
Shorter is better, which is why I went for ng- rather than angular-
ng follows the official presskit guidelines

There are of course a few other factors but those were the main driving points behind the decision.

As an update to this, I'm now in the process of sorting out npm conflict resolution, and have emailed the owner of ng-semantic-ui to request the name. The name change depends on how long it takes for them to reply, (could be between a week and a month), so will keep you updated 😄

Movement! I now control both:
ng-semantic-ui and
@ng-semantic-ui (the whole scope).
So: for the project rename, what are people's thoughts on the package name?
We could go for the plain old ng-semantic-ui, though this precludes the option of publishing different packages under the scope. Otherwise, going for @ng-semantic-ui means we need to pick a "sub name" - my current thoughts were just @ng-semantic-ui/lib.
I want to avoid the full @ng-semantic-ui/ng-semantic-ui as although it's done elsewhere (looking at you ng-bootstrap) I feel it isn't as good as a shorter name like lib or core.

P.S. Rename will be happening with the release of v0.10.0

I get why you want to use core or lib, but are you ever going to have more than 1 repository and more than 1 library?


Enable postmessage

Summary
Took inspiration from the original webview implementation on the react-native repo before the lean core and move to react-native-community
In the current implementation, on the android side, it never exposes the window.postMessage to the window.webkit.messageHandlers.ReactNativeWebView, so messages that are being posted never get handled. On the iOS side, the implementation was updated to use window.ReactNativeWebView as opposed to window.postMessage to pass the data through. I'm not sure if this was on purpose? Some clarification could help @Titozzz

Test Plan

What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Previously, during a webview with a window.addEventListener("message", function (event) ... pattern, the message would not be handled by the library.
Compatibility

OS
Implemented

iOS
✅

Android
✅

Checklist

[X ] I have tested this on a device and a simulator (iPhone 8 physical, iPhone X simulator / Samsung S9 physical )
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

Hello, you are not supposed to use webViewRef.postMessage but instead you should use webViewRef.injectJavascript() to communicate from react-native to the webView.
Maybe see my answer here : https://github.com/react-native-community/react-native-webview/issues/809
If this is ok for you please close this PR

@Titozzz , do you mean to update the postMessage on the javascript in the webview? I'm currently using this with a certain third party integration that posts a message from their javascript that I am capturing in this webview by listening for a message with onMessage.

Webview is not intercepting postMessage on window directly as it caused issues, if you want this behavior you can inject javascript that will proxy anything from window.postMessage to the new one.

As an example of what @Titozzz is saying, you could do something like this:
const interceptPostMessage = `
var _originalPostMessage = window.postMessage
window.postMessage = function(msg) {
  if (_originalPostMessage) { _originalPostMessage(msg) }
  window.ReactNativeWebView.postMessage(msg)
}
true`;

// in render
<WebView
  injectedJavaScript={interceptPostMessage}
  // ...
/>

This guide is helpful to understand how this works: https://github.com/react-native-community/react-native-webview/blob/master/docs/Guide.md#communicating-between-js-and-native

Thanks @jamonholmgren!! I'll try it out!


Ruby: WatchCancelRequest Confusion

I just had a quick question on the proper way to cancel watch requests.
https://github.com/davissp14/etcdv3-ruby/blob/master/lib/etcdv3/etcdrpc/rpc_pb.rb#L153-L155
Looking at the code, the input and output of the WatchCancelRequests just like WatchCreateRequests are handled in a bi-directional stream.
So if we create an active watcher by doing the following:
# Stub out the create request
stub = Etcdserverpb::Watch::Stub.new('localhost:2379', :this_channel_is_insecure)
create_req = Etcdserverpb::WatchCreateRequest.new(key: 'hi')
watch_req = Etcdserverpb::WatchRequest.new(create_request: create_req)

# Start listening for key changes in a new thread.
th = Thread.new do
  stub.watch([watch_req]).each{|resp| puts resp }
end

Then we go ahead and create the cancel enum.
cancel_req =  Etcdserverpb::WatchCancelRequest.new(watch_id: 0)
watch_req = Etcdserverpb::WatchRequest.new(cancel_request: cancel_req)

# This returns a Enumerable that i'm not sure what to do with.
stub.watch([watch_req])

Given that the cancel request simply returns an enumerable, what's the proper way to cancel an active watcher.  If I issue .each and wait it just blocks forever and new events keep coming in.
Is the cancel request any different than simply sending an interrupt to the Thread?

If this question would be better suited in the Grpc project, let me know!

@davissp14 I'm not familiar with ruby so I can't really comment on the grpc bindings, but I can explain how etcd's RPC watch protocol works, if that helps.
The cancel request will stop etcd from issuing events for a given watch id on a grpc watch stream. For example, if you have four watches open on a single stream but only want to stop receiving events for a single watch, the way to do it is to issue a cancel request with the watch id X you want to stop. etcd will acknowledge the watch for X is canceled by sending a watch response with canceled = true and  watchid=X. After that, the etcd server should not deliver any new events on that watch id over that stream.
If your client only has one watch per stream, it suffices to tear down the stream entirely via grpc instead of issuing a cancel request.

@davissp14 does @heyitsanthony's answer solve your problem? can we close this?

Yes, thank you!


imagePullPolicy set to Always in examples without rationale

In the example app deployments, the imagePullPolicy is set to Always for the init container.  Does this need to be the case?
I believe this may be because some examples are not using a tag on the image, but if we use a version tag on the image is there a reason why Always is preferred?  Does the project anticipate making changes to existing versions that we need to pull?
The only "fix" for this is a line in the quick start or main readme explaining the reason for (or for not) using Always.
And, thanks for the effort on this.   We are using it with a good experience so far!

@JPhi1618 The deployments are examples for testing out the system. The reasons for setting imagePullPolicy to true are:

When building the dev images, they are tagged as dev, and having imagePullPolicy set to true allows for easier testing of those images during development.
Previously, I had image versions pinned using tags in the deployments, but it is not fool-proof. There were a few times when I forgot to update those version numbers before tagging a release.

Each versioned image should be considered immutable. They will not be modified in any way after they are pushed.
Having said that, the deployment files are only a guide for testing/setting up a cluster for playing with. In production, you'd most likely have specific requirements where you will have your own deployments.
Hope that helps! 😄

Yes, thanks.  I just wanted to make sure there wasn't some nuance to Always that I was missing.  We haven't had a need to change the default in our own deployments and there's always a chance of some undocumented side effects that aren't obvious.
Thanks again.


Fixes #36 | Allows for single value unions

Why
Fixes #36.  Handles single value unions how typescript handles them.

Codecov Report

Merging #37 (e1751ca) into main (e5e4961) will decrease coverage by 0.44%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   98.49%   98.05%   -0.45%
==========================================
  Files           8        9       +1
  Lines         332      359      +27
  Branches      102      108       +6
==========================================
+ Hits          327      352      +25
- Misses          5        6       +1
- Partials        0        1       +1

Impacted Files
Coverage Δ

src/utils/resolveDefaultProperties.ts
95.23% <95.23%> (ø)

src/core/generateZodSchema.ts
97.29% <100.00%> (+0.09%)
:arrow_up:

src/core/jsDocTags.ts
98.46% <100.00%> (-1.54%)
:arrow_down:

src/core/validateGeneratedTypes.ts
97.43% <100.00%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6ae0a1...e1751ca. Read the comment docs.


Allow openMCT to pull updated dictionaries when a ros system is added or removed

This is actually easily solved by just refreshing the screen.


feat: switching to use dynamic localize mixin to support Hindi

In order to support Hindi, we would have needed a new entry in our localize-core-element.js mixin. Instead, we can just switch to using the sweet LocalizeDynamicMixin which will "just work" when new languages are added. Less code too!
While I was in here, I removed our Serge overwrite rule which will now fall back to the default. This required renaming zh.js -> zh-cn.js.

Ok I did jinx it as the visual diffs are doing unexpected things. I'll have to look into those next week. 😵💫


Consistent crashing on v4

Snekfetch version or commit hash: v4.0.0-rc.0
Explanation of issue:
Crashing due to incorrectly called function options.connection.close. This happens to all my snekfetch using code as of v4.0.0-rc.0.
I can see that you are telling Travis to use Node v9 and any build CI attempts before that fail - is Node v9 a requirement as of Snekfetch v4 then? Currently Node v8.9.4 is still LTS and it will be until about december 2019!
Thrown error:
(node:20449) ExperimentalWarning: The http2 module is an experimental API.
TypeError: options.connection.close is not a function
    at Unzip.stream.once (/home/pi/.djsbots/ribbon/node_modules/snekfetch/src/node/index.js:93:30)
    at Object.onceWrapper (events.js:313:30)
    at emitNone (events.js:111:20)
    at Unzip.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1055:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)

Example code to reproduce:
const request = require('snekfetch');

async function search() {
    try {
        const word = await request.get(`https://glosbe.com/gapi/translate?from=en&dest=en&format=json&phrase=${'soul'}`);

        if (word.ok) {
            return console.log('request passed')
        }
    } catch (e) {
        console.error(e)
    }

}

search();

Tried to throw reproducible code on Runkit but it appears that v4 has not yet been made available there as it uses v3.6.4.

[ ] Issue occurs in browser
[X] Issue occurs in node

p.s. you have a typo in your issue template. You wrote Explaination but it is Explanation

duplicate of #29

My bad. I should've checked closed issues.


Stop nested .from-top classes causing two modal top bars

A package I am using creates a modal and then applies the from-top class to the outer class of the modal. This duplicates that class as and so it causes this to happen:

👎
This change means that if and other packages to this it resets the inner from-top to 0px which doesn't cause the visual issue and looks like this:

👍
I'm not sure if other packages are doing it but though it seemed easier to fix it here incase they are rather than in each package!
Thanks!

Thanks for your contribution 👍
Currently I don't see the benefit of this addition since it has absolut no effect as seen from the perspective of the theme package. There is no class duplicated .from-top selector in any Atom core package which would make use of this.
Also as you can see on the screenshot below the top: 0 gets disabled by Atom anyway since the top: 20vh value overrides all node selectors inside of the top .from-top class.
It would be nice if you can post the name of the package so I can try to reproduce this behavior, but it does look like the specific package should fix the way it creates the modal. The Atom API provides powerful methods to create a package that fits the current theme without setting any custom CSS which may break the UI theme.
I'd like to help you fix this problem, maybe I can reproduce it and create a bugfix PR in the repository of the specific package.

I didn't know if it could be happening with other packages as well so not sure if here was the best place to do it?
I've opened an issue (linked above) over at the other package and then tested removing the CSS classes locally and it all still worked ok so I'd say it was best to fix in other package if you'd prefer! 👍

I've investigated the problem in debug mode and it seems like there is indeed a strange bug in the theme. It seems like the div rendered by the remote-ftp package is affected by the top: 20vh attribute and gets moved down relative to its origin: the <atom-panel> container.
origin atom-panel containerremote-ftp div container
Your PR will would avoid most of the visual issues, but there will still be a small visible overlap between both container and the origin atom-panel container would still get rendered behind the scenes.
Screenshots using the PR branch:

I'll refactor the whole code for overlays- and modals to fix this strange issue since it won't occur with other themes. This will be implemented in the UI scale refacroring #58.
I'll @-notify you as soon as I've updated the linked issue and psuhed a branch to test the changes 😄


Add ScheduleAfterChildren()-API to Containers

Does what it says: Schedules a call to run the next time
UpdateAfterChildren() gets called.

what's the use-case for this one?

The use case is to schedule stuff post-layout. Like chat scroll to end
without a hack delay that breaks at low frame times as is done in osu.
On 8 Jun 2017 6:00 a.m., "Dean Herbert"<EMAIL_ADDRESS>wrote:

what's the use-case for this one?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ppy/osu-framework/pull/802#issuecomment-306991903,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEshB3xZzmQq4Xy_NTeR0nuXMUYk-Qqgks5sB3HCgaJpZM4NzPRD
.

Is there an osu-level PR to move such things over? I would've thought there was at least one potential usage in the framework for this...

Planned to make an osu pr with at least the chat fix once this is in. Can't
immediately think of a good use case within the framework, but I imagine
callbacks post-layout will be a thing in more places.
On 8 Jun 2017 7:25 a.m., "Dean Herbert"<EMAIL_ADDRESS>wrote:

Is there an osu-level PR to move such things over? I would've thought
there was at least one potential usage in the framework for this...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ppy/osu-framework/pull/802#issuecomment-307001854,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEshB6rXATij6DxIoY1S7ez0ol-maAxmks5sB4W4gaJpZM4NzPRD
.

TO be honest, every place I can find UpdateAfterChildren usages, a Cache-Invalidate-Refresh pattern looks to work better...

Adding a scheduler specifically for scrollToEnd feels very wrong. Just add a single internal state for that instead?
I mean there's so many other scenarios where scrollToEnd won't work too (if new content appears when a ScrollContainer is off-screen it won't work etc.) to the point we probably want a permanent ShouldBeAnimatedScrollingToTop  bool or something.
management of keeping a scroll position should be the ScrollContainers responsibility IMO.

Regarding UpdateAfterChildren(): While using the framework I've encountered situations where the literal action, ie "let my children update, then update me" is necessary to get the right order of operations, where this wasn't purely related to just sizes not getting invalidated.
The concrete situation is that I needed a parent container to update based on a childs position, and the childs positioning was managed by the child itself, so the parent has to wait for the childs update to complete before making decisions based on it.
I can imagine similar situations where I will want to use ScheduleAfterChildren() because I need to do an action of a similar kind - but schedule it to the next frame - even though the only use-case I currently have in my own code is making sure that a ScrollContainer properly scrolls to its end.

override UpdateAfterChildren in the parent?


Cant launch program: /sys/kernel/debug/ec/ec0/io does not exist

When trying to launch the program it wont boot anymore after recent updates to the machine. (running Arch)
Might however not be the fault of mlfc itself - seems quite a few things across the system are funky now so i will reinstall in the coming days and then report back if the issue persists.

I think it because of the https://github.com/YoyPa/isw/issues/226

yikes... well seems unfixable for now...

https://github.com/YoyPa/isw/issues/263 maybe they have an idea?

core-Repo of isw-Modern is mentioning this - i decided to ask them if thats what we need to get the ec_sys module back: https://github.com/FaridZelli/acpi_ec

https://github.com/FaridZelli/ISW-Modern/issues/3

using the acpi_ec-dkms module posted above, it works again - although i needed to first install dkms, install the module, then install dkms AGAIN for the module to be recognized and then restart my PC for it to work. but thats but a minor one-time inconvenience.

did you change the ec address '/sys/kernel/debug/ec/ec0/io' to '/dev/ec' ? where did you replace the path?

did you change the ec address '/sys/kernel/debug/ec/ec0/io' to '/dev/ec' ? where did you replace the path?

i just installed the module using the instructions in the readme. Arch isnt mentioned itself, but you can use the Ubuntu-Instructions: install dkms, linux-headers (or headers for your kernel) then run install.sh
afterwards reinstalled dkms to force a scan for new modules.

Now work, thank you

@marshevms i think this issue can be closed as long as the Readme either provides the necessary information or links people here - your choice.


[robot]: deep copy shapes when cloning

This PR enables deep copying of shapes when cloning. This ensures a complete copy of the robot so that we can edit both the original and the clone completely independently (even altering shapes).
This is waiting https://github.com/dartsim/dart/pull/1612 before merging.. We enable the feature only if available (DART 6.13.0 and up)!

Merging


Preview Git SCM cannot create branches from status bar

VSCode Version: Code 1.11.1 (d9484d12b38879b7f4cdd1150efeb2fd2c1fbf39, 2017-04-06T13:58:12.954Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

vscode-caniuse
agauniyal
0.5.0

Handlebars
andrejunges
0.2.0

vscode-yarn-script
carlosjs23
0.0.1

jsrefactor
cmstead
1.0.2

vscode-markdownlint
DavidAnson
0.7.1

vscode-eslint
dbaeumer
1.2.8

githistory
donjayamanne
0.2.0

python
donjayamanne
0.6.0

xml
DotJoshJohnson
1.7.0

vscode-npm
fknop
3.3.0

HTMLHint
mkaufman
0.3.3

PowerShell
ms-vscode
0.12.2

debugger-for-chrome
msjsdiag
2.7.3

ColdFusion
SketchPunk
0.0.1

code-spell-checker
streetsidesoftware
1.0.2

Steps to Reproduce:

Open workspace with git repo
Click branch name in status bar
Enter new branch name

Expected results:

New branch created and checked out

Actual results:

Nothing happens, as the status bar command is "Checkout to..." which in the Preview Git SCM doesn't allow branch creation (there's a separate "Create branch..." command for that)

Tracked in #21439

Absolutely, thanks.


Drop ECR for testing builds

build: Stop building the 3.8 images.
build: Publish to the Github registry.
build: Build the docker image as a part of CI.

@MoisesGSalas this is about how far I've gotten, I think it makes sense to land this without 24.04 for now and then try to fix that as a separate PR in the future.  It looks like something has changed either with docker or with apparmor in that version causing it to not enforce the network limits.   Can you review this and let me know if you have any concerns.  The commit messages should generally explain things but please ask any questions you might have.

@feanil, I will take a look later tomorrow. But I'm wondering if running  the tests directly in the runner without docker (thinking of this network issue) would be easier/better?
I found this repo that seems to use apparmor just fine in the CI runner.

@MoisesGSalas that's something we can consider so that we can just test the profiles without the docker related confusion but since we use docker as a part of tutor, it's useful to also test inside containers so I'm of two minds on the issue.  For now let's focus on landing this for 22.04 and we can come back to 24.04 after the release.


Get involve: SGF text

It looks like the formatting is messed up here: http://gfw-nav.herokuapp.com/getinvolved/apply-to-the-small-grants-fund. Do you mind fixing that?
From: Miguel Barrenechea Sánchez<EMAIL_ADDRESS>Sent: Friday, May 29, 2015 9:02 AM
To: Vizzuality/gfw
Cc: Benjamin Jones
Subject: Re: [gfw] Get involve: SGF text (#1696)
Merged #1696https://github.com/Vizzuality/gfw/pull/1696.
—
Reply to this email directly or view it on GitHubhttps://github.com/Vizzuality/gfw/pull/1696#event-317190171.


Placeholder names on NumberBox result in strange narrator behavior

Describe the bug

When the value of the NumberBoxes is set, narrator still reads out the placeholder, resulting in announcment likes "0.00, edit 100".
@SavoySchuler @YuliKl FYI as I am not sure if this is the best behavior for NumberBox.
Steps to reproduce the bug

Steps to reproduce the behavior:

Open NumberBox page
Start narrator
Enter value in NumberBox
Switch to and from that NumberBox

Expected behavior

Narrator should read out something less confusing
Actual behavior

Narrator announces somewhat confusing content.
Screenshots

Version Info

Gallery version (found on Settings page):

Latest debug build
Windows 10 version:

Insider Build (20236)

Device form factor:

Desktop

Additional context

I'm guessing the narrator behavior is coming from TextBox since we just template bind placeholder text, but I'm not seeing the same behavior in TextBox. It is possible that this is caused by the way TextBox is being used by NumberBox.

Yes, this seems to be an issue with the TextBox jumping in and providing the UIA name here instead of the NumberBox, which in it's current implementation wouldn't even report the value. Is it intended that the NumberBoxAutomationPeer does not read out it's current value if Narrator would use it?