Problem with facebook

Hello,
I have a problem with Bancuh DNS on my phone, facebook comments no longer appear or sometimes facebook tells me network error when I am on your dns. I think it comes from the Api Facebook.
Screen: https://image.noelshack.com/fichiers/2019/35/2/1566865932-s90827-02303810.jpg
Screen: https://image.noelshack.com/fichiers/2019/35/2/1566865936-s90827-02305699.jpg
Merci

Hi @Dadan59DK , Sorry for late reply.
Did you encounter this on the Facebook Mobile App? How about opening Facebook on mobile web browser, same issue? Also, are you on Android or iOS? How did you apply the dns on the phone? Using an app or just change in your home wifi router?
I think some of the recent changes might have blocked some facebook api. I don't know which one I have to whitelist just yet.

Hello,
I had some problems on facebook on pc, sometimes the page gets blocked with a security error.
On Android, it's worse, I can't do any more research or look at my fan pages.
I installed your dns on the router of my internet tv box.
And on Android, your dns is my main server thanks to the Blokada application.

Here is what you need to put on the white list:
https://i.goopics.net/pJeyP.jpg

Hello,
thanks everything seems to work fine, I'll come back to you if I see any problems. I will add your DNS to my blog in the best DNS of the moment, my customers often look at my adblock DNS ranking.

@TechComputerServiceDunkerque , Thsnks for the fast reply. I'll mark this issue as resolved. I'm glad I could be helpful.


Add AutoSaveOn property documentation for Word and PowerPoint

@ElizabethSamuel-MSFT,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/about-coauthoring-in-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookaftersave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookbeforesave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/workbook-autosaveon-property-excel.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/about-autosave.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/application-presentationbeforesave-event-powerpoint.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/application-documentbeforesave-event-word.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/document-autosaveon-property-word.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/about-coauthoring-in-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookaftersave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookbeforesave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/workbook-autosaveon-property-excel.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/about-autosave.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/application-presentationbeforesave-event-powerpoint.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/application-documentbeforesave-event-word.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/document-autosaveon-property-word.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md
:warning:Warning

Details

VBA/Excel-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/about-coauthoring-in-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookaftersave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookbeforesave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/workbook-autosaveon-property-excel.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/about-autosave.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/application-presentationbeforesave-event-powerpoint.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/application-documentbeforesave-event-word.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/document-autosaveon-property-word.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md

[Warning] Reference is invalid: Reference: "https://support.office.com/en-US/article/What-is-AutoSave-6d6bd723-ebfd-4e40-b5f6-ae6e8088f7a5" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../Word-VBA/articles/document-autosaveon-property-word.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../Excel-VBA/articles/workbook-autosaveon-property-excel.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "https://support.office.com/en-US/article/What-is-AutoSave-6d6bd723-ebfd-4e40-b5f6-ae6e8088f7a5" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../Excel-VBA/articles/workbook-autosaveon-property-excel.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../Word-VBA/articles/document-autosaveon-property-word.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.

Line 20: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/Word-VBA/articles/document-autosaveon-property-word.md").

Line 20: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md").

Line 20: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/Excel-VBA/articles/workbook-autosaveon-property-excel.md").

Line 124: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/Excel-VBA/articles/workbook-autosaveon-property-excel.md").

Line 130: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md").

Line 134: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/Word-VBA/articles/document-autosaveon-property-word.md").

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md
:warning:Warning

Details

VBA/Excel-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/about-coauthoring-in-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookaftersave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookbeforesave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/workbook-autosaveon-property-excel.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/about-autosave.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/application-presentationbeforesave-event-powerpoint.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/application-documentbeforesave-event-word.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/document-autosaveon-property-word.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md

[Warning] Reference is invalid: Reference: "https://support.office.com/en-US/article/What-is-AutoSave-6d6bd723-ebfd-4e40-b5f6-ae6e8088f7a5" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../Word-VBA/articles/document-autosaveon-property-word.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../Excel-VBA/articles/workbook-autosaveon-property-excel.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "https://support.office.com/en-US/article/What-is-AutoSave-6d6bd723-ebfd-4e40-b5f6-ae6e8088f7a5" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../Excel-VBA/articles/workbook-autosaveon-property-excel.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.
Reference: "../../Word-VBA/articles/document-autosaveon-property-word.md" contains invalid characters in file vba/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.html.

Line 20: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/Word-VBA/articles/document-autosaveon-property-word.md").

Line 20: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md").

Line 20: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/Excel-VBA/articles/workbook-autosaveon-property-excel.md").

Line 124: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/Excel-VBA/articles/workbook-autosaveon-property-excel.md").

Line 130: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md").

Line 134: [Warning] Invalid file link:(~/Office-Shared-VBA/articles/Word-VBA/articles/document-autosaveon-property-word.md").

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/about-coauthoring-in-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookaftersave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookbeforesave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/workbook-autosaveon-property-excel.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/about-autosave.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/application-presentationbeforesave-event-powerpoint.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/application-documentbeforesave-event-word.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/document-autosaveon-property-word.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/about-coauthoring-in-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookaftersave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookbeforesave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/workbook-autosaveon-property-excel.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/about-autosave.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/application-presentationbeforesave-event-powerpoint.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/application-documentbeforesave-event-word.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/document-autosaveon-property-word.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/about-coauthoring-in-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookaftersave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookbeforesave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/workbook-autosaveon-property-excel.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/about-autosave.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/application-presentationbeforesave-event-powerpoint.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/application-documentbeforesave-event-word.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/document-autosaveon-property-word.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/about-coauthoring-in-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookaftersave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookbeforesave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/workbook-autosaveon-property-excel.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/about-autosave.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/application-presentationbeforesave-event-powerpoint.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/application-documentbeforesave-event-word.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/document-autosaveon-property-word.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/about-coauthoring-in-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookaftersave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookbeforesave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/workbook-autosaveon-property-excel.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/about-autosave.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/application-presentationbeforesave-event-powerpoint.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/application-documentbeforesave-event-word.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/document-autosaveon-property-word.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/about-coauthoring-in-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookaftersave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/application-workbookbeforesave-event-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/workbook-autosaveon-property-excel.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/about-autosave.md
:white_check_mark:Succeeded

VBA/Office-Shared-VBA/articles/how-autosave-impacts-addins-and-macros.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/application-presentationbeforesave-event-powerpoint.md
:white_check_mark:Succeeded

VBA/PowerPoint-VBA/articles/presentation-autosaveon-property-powerpoint.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/TOC.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/application-documentbeforesave-event-word.md
:white_check_mark:Succeeded

VBA/Word-VBA/articles/document-autosaveon-property-word.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Content Creator: Passwords

We need password functionality and UX.
Feature: Password manipulation
  As a content creator
  I want to manipulate my password
  So that I have a secure login.

  Scenario: Password recovery CTA on login
    Given that I am on the login page
      And that I don't know my password
    When I need to get my password
    Then there is a call-to-action to get to a password recovery system

  Scenario: Password recovery email
    Given that I am not logged in
      And that I know my email from login
    When I give my email to the password recovery system
    Then it sends me an email to recover my password

  Scenario: Change my Password CTA
    Given that I need to change my password
      And that I am logged in
    When I view an admin screen for my account
    Then I will see a link to Change my Password

  Scenario: Change password
    Given that I need to change my password
      And that to avoid mistakes I should enter my new password twice
    When I enter in my new password
    Then there should be two password entry fields
      And there should be functionality to test that both are filled in identically
      And there should be an indication that shows the security level of my password.

[ ] Password manipulation / login link
[ ] Password manipulation / recovery email
[ ] Password manipulation / profile link
[ ] Password manipulation / password change screen

Blocked: need ability to send email


谁有version-RFB-640.pth转caffe的模型

谁有version-RFB-640.pth转caffe的模型,现有的caffe模型精度没有官网的好,差很多

English translation:
Who has the version-RFB-640.pth to caffe model?
the accuracy of the existing caffe model is not as good as the official website, and it is much worse


Refactor checkpoint and restore to client

This refactors the checkpoint and restore to be on the containerd client.
ToDo

[x] Tests

Example
$> ctr run --runtime io.containerd.runc.v1 -d docker.io/library/redis:alpine redis
# checkpoint
$>  ctr c checkpoint --rw --task redis checkpoint/redis:20180911
# restore
$> ctr c restore redis-debug checkpoint/redis:20180911
# restore live
$> ctr c restore --live redis-debug checkpoint/redis:20180911

Refs #2602

Codecov Report

Merging #2632 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2632   +/-   ##
=======================================
  Coverage   44.05%   44.05%
=======================================
  Files          94       94
  Lines       10238    10238
=======================================
  Hits         4510     4510
  Misses       5008     5008
  Partials      720      720

Flag
Coverage Δ

#linux
47.77% <ø> (ø)
:arrow_up:

#windows
40.72% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83668f4...74e58ea. Read the comment docs.

Happy to see this pr, it more convenient to test checkpoint/restore with ctr.

Hi, @ehazlett , what is the status of the PR, I think it is a good enhancement.  If you do not mind, I am willing to do the rebase and re-pull with your branch.

@Ace-Tang I will rebase it today thanks!

@Ace-Tang ya there have been a couple of APT fails as well.  i'm restarting the job to see if that can get it to complete.  thx!

LGTM

LGTM


Stack Overflow In Access Analyzer

See KMP.
Looking into this now to see if its something stupid

Noticed this one on Friday - it's gotta be something dumb in the way we've defined the recursive Affine unapply where it doesn't terminate in some specific case.

Overflow is because we have
SRAMRead(ofs = RegRead(reg) - 1)
And I put something like the friendly transformer to look at most recent write of a register and use that instead because it kept making unnecessary duplication any time a register was inserted somewhere in the address path.  This reg has its most recent write as
RegWrite(reg, reg + 1)
I'm going to ignore most recent writes if they are part of an accum cycle, which should break up the stack overflow.  Really we only care about iterators that are hidden behind RegReads so maybe there is a more general way to do this, but it has worked as expected so far except for this case.
Seeing if this causes any surprising changes in compile times

Ah good catch, yeah a cycle like that would cause this infinite recursion issue.
We should double check that your short circuiting logic between RegRead and RegWrite is generally legal - i.e. if there are multiple potential writes that can reach that read, the read should appear random unless we can say something definite about the intersection of all of the writes

Made a special look-thru that doesn't require any isl or metadata that doesn't exist by the time the AccessAnalyzer runs that does basically the same logic as the reachingWrites in access package.  Should we keep working on it with better test cases or call this issue closed?


edit project description and readme

the readme and the project description are not up to date please update them to the latest sprint information

this issue is solved


Added option to disallow usage of collections in expression

https://github.com/arangodb/arangodb/pull/13872

Follow-up change for 3.9: https://github.com/arangodb/docs/commit/1ff4bf0dcc05809f7753d260563f3dc3c84001c8


Use npm-shrinkwrap file instead of package-lock

Related to https://github.com/jhipster/generator-jhipster/issues/10099

Maybe not worth it for this repo


IntelliSense get's out of it's position when list gets shorter at the end of the file

VSCode Version: 1.21.0
OS Version: macOS High Sierra (latest update)

In the new version, sometimes when typing intelliSense gets out of the position like this:

For now I have seen it on Go, C++ and TypeScript. Also it happens time to time about 1/20.

Thanks for reporting @pmkary. This is a regression.
Root cause: https://github.com/Microsoft/vscode/commit/85ac36ee4c5eb9dd922af1265c6850d75448f6eb#diff-caac303ecc98a837b262c2c9a093026d

Thanks a lot for fixing it and for such a quick investigation 👍

fyi: gets / its


Added option to make autocomplete case sensitive

In some cases case sensitive search is preferred or just a lot faster. To allow for that, I added the case_sensitive option to the autocomplete method.
My app has a table with a million domain names. Running a case insensitive search is very slow, because there are no indices to be used. Creating an expression index just for autocompletion seems a little silly, especially since all domain names are lowercase already anyways.
Performance benefit of not using LOWER in query is huge. Others may benefit as well.

@michieldewit Thanks.  It's nice to see a PR that actually covers all of the supported adapters!


Uncaught Exception @ Startup on OSX

Hi I'm using OSX Yosemite 10.10.3 with Macports..
I've used macports to install openssl @1.0.2a and Boost @1.58.0_3
however, when I compile my own upload program or build the OSX version. It compiles with modifications but when I run I receive the following:
libc++abi.dylib: terminating with uncaught exception of type boost::exception_detail::clone_impl<boost::exception_detail::error_info_injectorboost::system::system_error >: add_certificate_authority: cert already in hash table

I believe this should fix the problem when building under macports.


Compute default recipe on Justfile

If a Justfile value stores its own root path, it can compute the default recipe as required, which makes the analyzer simpler and also makes it easier to change what the rules are for determining the default recipe in the future.

This doesn't personally seem like a big win to me. It allows getting rid of keyed::serialize_option, but it removes first from the serialization of Justfile, which breaks backwards compatibility with the JSON dump format.


PowerShell: DSC's Node keyword isn't highlighted

In PowerShell Desired State Configuration (DSC), the node keyword is used to create "node blocks" inside a DSC configuration document. Unfortunately, this keyword isn't highlighted properly.

Cheers,
Trevor Sullivan
Microsoft MVP: PowerShell

Merging into #3342

@joaomoreno  whoops ... I totally forgot that I'd already mentioned the node keyword in that one. Total oversight. Sorry.


[Blocking] Flutter IME key event interception for editing implementation

Currently there is no good way of intercepting IME's key event in Flutter, e.g. Backspace, Enter, Home, End, Up, Down, etc, which is essential for the implementation of UnicodeMath-style editing.
https://github.com/flutter/flutter/issues/14809
Of course, we can infer IME key events by monitoring TextEditingValue and diffing them. But considering we are repurposing IME key events, this will either break copy/paste or undo/redo invoked from keyboard (either you get a garbled clipboard or a garbled history). It is unacceptable to break hardware keyboard shortcut just to fix IME interactions. But it is equally unacceptable to drop IME support on mobile.
We'll wait for Flutter team's solution. If anyone has experience in handling mobile IMEs on Flutter, please leave comments here.

Text diffing is not a viable option due to the following reasons according to testing.

Flutter Web's IME composition string implementation is broken. Composing range is always empty and any changes to the composition string are implemented by two steps: delete all & reinsert. This completely breaks text diffing method.
Flutter Window's has a different event model. When input N characters at once, instead of sending one TextEditingValue update, it will send N updates representing input progress, at the same time.

According to https://github.com/flutter/flutter/issues/50401, these discrepencies are not considered as bug.

The problem with Flutter Windows is solvable with a change of diffing algorithm.
But the problem with Flutter Web seems to be not solvable, and it really doesn't seem to be the fault of Flutter teams. As MathQuill.js also run into the same problem on IME key event handling https://github.com/mathquill/mathquill/issues/327.
The current plan is to bring a broken support with Flutter Web IME。

@znjameswu I did not look into the issue deeply - out of curiousity: what are the problems you are facing with using RawKeyboardEventListener? Is that not a feasible approach when using TextEditingValue?
(I think you notice that I really did not look into it 😅)

@znjameswu I did not look into the issue deeply - out of curiousity: what are the problems you are facing with using RawKeyboardEventListener? Is that not a feasible approach when using TextEditingValue?
(I think you notice that I really did not look into it 😅)

When I opened this issue, I remember that RawKeyboardEventListener  was unable to capture some software keyboard event on Android (i.e. complex keys from Hacker's keyboard). I just tested. It works now.
Another problem is IME handling. RawKeyboardEventListener only deals with a plain software keyboard without IME. Popping up a plain keyboard instead of user's default IME is wierd, and prevents users from inputting non-ascii characters. And I still wish to integrate this to some markdown editor in the future. So, neither constantly switching keyboard types nor dropping support for non-ascii characters seems a good idea.
It seems that RawKeyboardEventListener can partially fulfill the requirement now. But IMO this implementation would largely defeat the purpose of editing.


Updated broken links in docs/ref/contrib/gis/tutorial.txt.

Trac ticket number

N/A
Branch description
Replaced the broken thematicmapping.org links with web archive links and updated the footnote mentioning Bjørn Sandvik.
Checklist

[X] This PR targets the main branch.
[X] The commit message is written in past tense, mentions the ticket number, and ends with a period.
[ ] I have checked the "Has patch" ticket flag in the Trac system.
[ ] I have added or updated relevant tests.
[X] I have added or updated relevant docs, including release notes if applicable.
[ ] For UI changes, I have attached screenshots in both light and dark modes.

@sakhawy Thanks :+1: Welcome aboard :boat:


[google_map_flutter] Markers onTap area is shifted on screen when the app is registered as a game

Hello,
I am having an issue with Google Maps on my app in production. The app uses Google Maps to diplay markers, and users can tap on them to get more info.
The issue is : for some users, the clickable screen area is shifted a few pixels to te top left of the screen, making them miss the click most of the time (see screenshot).

Conserned users : Samsung A41 (and some other Samsung), Redmi phones, Crosscall phones and some iPhones as well.
The app is registerd on the AppStore & PlayStore as a game. It looks like is issue only occurs in this particular case.
My guess is that the app, being registed as a game, triggers a "Game Mode" on these phones and that the Game Mode changes the screen's resolution, which is not properly handled by Google Maps.
Some Samsung A51 users have managed to solve the issue by changing the Samsung Game Mode resolution in their settings. But this issue remains for most users.
Additional info :

flutter doctor:

[✓] Flutter (Channel stable, 1.22.4, on macOS 11.0.1 20B50 darwin-x64, locale en-GB)
    • Flutter version 1.22.4 at /Users/roland/Sdks/flutter
    • Framework revision 1aafb3a8b9 (5 weeks ago), 2020-11-13 09:59:28 -0800
    • Engine revision 2c956a31c0
    • Dart version 2.10.4
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/roland/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.10.0
[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 49.0.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[✓] VS Code (version 1.52.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.17.0
[✓] Connected device (1 available)
• No issues found!

Thanks a lot for looking into it !

Hi @jgrandchavin
Thanks for filing the issue, Would it reproduce on iPhone XR or Oneplus 8 or Realme 6 or Galaxy M30? If yes, I would reproduce it in the play store internal app testing release.
Can you please provide your pubspec.yaml and a complete reproducible minimal code sample
Thank you

Hi @TahaTesser,
I don't know if the issue is reproducible on exactly these phone models.
You can download the app and try.
The app is actually on MapBox because we wanted to try if the issue can be resolved by changing Google Map by Mapbox, but the issue is still there and react exactly the same on both plugins. (maybe a PlatformView issue ?)
Besides, on Android the issue is only on production app downloaded from the PlayStore and maybe the same on iOS.
`name: metropolis_game
description: Geolocalized board game.
version: 11.4.0+0
environment:
sdk: ">=2.6.0 <3.0.0"
dependencies:
flutter:
sdk: flutter
flutter_localizations:
sdk: flutter
Firebase
cloud_firestore: ^0.13.7
firebase_auth: 0.16.1
firebase_messaging: ^6.0.12
firebase_admob: ^0.9.3+4
firebase_crashlytics: ^0.1.4+1
cloud_functions: ^0.5.0
Auth
google_sign_in: ^4.1.1
flutter_facebook_auth: ^0.2.2+3
sign_in_with_apple: ^2.5.1
Log
facebook_app_events: ^0.6.0
amplitude_flutter: ^2.2.0
logger: ^0.9.1
adjust_sdk: ^4.22.1
Utils
rxdart: ^0.24.0
keyboard_visibility: ^0.5.6
package_info: ^0.4.0+13
url_launcher: ^5.5.0
shared_preferences: ^0.5.6
provider: ^4.3.1
path_provider: ^1.5.1
get_it: ^4.0.2
timezone: ^0.5.6
connectivity: ^0.4.6
geolocator: ^5.3.2+2
permission_handler: ^5.0.0+hotfix.5
notification_permissions: ^0.4.4
in_app_purchase: ^0.3.4+1
oktoast: ^2.3.1+1
tuple: ^1.0.3
equatable: ^1.2.3
intl: ^0.16.1
advertising_id: ^1.0.0
UI
flutter_svg: ^0.18.0
flare_flutter: ^2.0.3
loading_indicator: ^1.1.0
page_transition: ^1.1.5
simple_animations: ^2.0.2
google_maps_flutter: ^0.5.29
animated_text_kit: ^2.2.0
auto_size_text: ^2.1.0
dev_dependencies:
flutter_test:
sdk: flutter
flutter_launcher_icons: ^0.7.4
cloud_firestore_mocks: ^0.4.4
Run command:
flutter pub run flutter_launcher_icons:main
flutter_icons:
android: "launcher_icon"
ios: true
image_path_android: "res/launcher/android_stage.png"
image_path_ios: "res/launcher/ios_stage.jpg"
flutter:
uses-material-design: true
assets:
- res/icons/
- res/buildings/with_base/
- res/buildings/without_base/
- res/avatars/
- res/cards/
- res/markers/ios/
- res/markers/android/x0.25/
- res/markers/android/x0.5/
- res/markers/android/x0.75/
- res/markers/android/x1/
- res/shop/
- res/map_styles/
- res/timezone/
- res/animations/
- res/items/
- res/items/accessories/
- res/items/outfits/
- res/items/transports/
- res/languages/
- res/introduction/
- res/building_icons/
fonts:
- family: Averta
fonts:
- asset: res/fonts/Averta-Regular.otf
weight: 300
- asset: res/fonts/Averta-RegularItalic.otf
style: italic
- asset: res/fonts/Averta-SemiBold.otf
weight: 600
- asset: res/fonts/Averta-Bold.otf
weight: 700
- asset: res/fonts/Averta-ExtraBold.otf
weight: 800
- asset: res/fonts/Averta-Black.otf
weight: 900
- family: November
fonts:
- asset: res/fonts/November-Regular.ttf`
`import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';
import 'package:metropolis_game/notifiers/map_notifier.dart';
import 'package:provider/provider.dart';
class MapWidget extends StatefulWidget {
const MapWidget({Key key}) : super(key: key);
@override
_MapWidgetState createState() => _MapWidgetState();
}
class _MapWidgetState extends State with AutomaticKeepAliveClientMixin {
@override
bool get wantKeepAlive => true;
@override
Widget build(BuildContext context) {
super.build(context);
return Consumer(
builder: (BuildContext context, MapNotifier model, Widget child) {
return GoogleMap(
onMapCreated: model.onMapCreated,
onCameraMove: (CameraPosition cameraPos) {
model.updateTeleportationLocation(cameraPos.target);
},
initialCameraPosition: model.initialCameraPosition,
circles: model.circles,
markers: model.markers,
myLocationEnabled: false,
mapToolbarEnabled: false,
indoorViewEnabled: false,
compassEnabled: false,
tiltGesturesEnabled: false,
rotateGesturesEnabled: true,
myLocationButtonEnabled: false,
scrollGesturesEnabled: true,
zoomGesturesEnabled: true,
zoomControlsEnabled: false,
);
},
);
}
}`
`class MapNotifier with ChangeNotifier {
void update({
@required GameConfig gameConfig,
@required User user,
@required Player player,
@required PlayerTags playerTags,
@required List ownedItems,
}) {
if (user.isEmpty) {
// User logged out
_reset();
return;
} else if (_gameId != user.gameId) {
// User switched game
_reset();
_gameId = user.gameId;
if (user.gameId.isNotEmpty) {
_initCollected(user: user);
refresh();
}
}
final bool updateMarkers =
    _player.ownedBuildings != player.ownedBuildings || _player.discoveredBuildings != player.discoveredBuildings;
_player = player;
_gameConfig = gameConfig;
_playerTags = playerTags;
_ownedItems = ownedItems;
refresh(markers: updateMarkers);

}
Future onMapCreated(GoogleMapController mapController) async {
_mapController = mapController;
final String style = await rootBundle.loadString('res/map_styles/map_day.json');
_mapController.setMapStyle(style);
_subs.add(_locationService.locationStream.listen((LatLng location) async {
  if (_mapState == MapState.normal &&
      DistanceHelper.getDistance(_lastLocation, location) > REFRESH_DISTANCE_METERS &&
      !_locationService.isTeleported) {
    _lastLocation = location;
    refresh();
  } else {
    refresh(markers: false);
  }
}));
_subs.add(_locationService.playerSpeedStream.listen((PlayerSpeed playerSpeed) async {
  if (_mapState == MapState.normal && playerSpeed != _playerSpeed) {
    _playerSpeed = playerSpeed;
    refresh();
  }
}));
_subs.add(Database.getRespawnMarkersStream().listen((_) {
  if (_mapState == MapState.normal) {
    refresh();
  }
}));

}
Future _initCollected({@required User user}) async {
final CollectedMarkers collectedMarkers =
await Database.getCollectedMarkers(gameId: user.gameId, userId: user.userId);
_collectedMarkers = collectedMarkers;
}
Future _reset() async {
_subs.clear();
_gameId = '';
_circles.clear();
_markers.clear();
_mapState = MapState.normal;
_collectedMarkers = null;
_mapController = null;
_locationService.teleportationLocationSink.add(null);
_teleportationCardData = null;
_teleportationLocationTarget = null;
_playerSpeed = PlayerSpeed.slow;
}
// Internals
final CompositeSubscription _subs = CompositeSubscription();
final LocationService _locationService = locator();
String _gameId = '';
Player _player = Player.empty();
PlayerTags _playerTags = PlayerTags.empty();
GameConfig _gameConfig = GameConfig.empty();
LatLng _lastLocation = LatLng(0, 0);
List _ownedItems = [];
// State
MapState _mapState = MapState.normal;
GoogleMapController _mapController;
final Set _circles = {};
final Set _markers = {};
CollectedMarkers _collectedMarkers;
PlayerSpeed _playerSpeed = PlayerSpeed.slow;
LatLng _teleportationLocationTarget;
PlayerCard _teleportationCardData;
// Getters
bool get initialized => _gameId.isNotEmpty && _player.isNotEmpty && _gameConfig.isNotEmpty && _mapController != null;
Set get circles => _circles;
Set get markers => _markers;
MapState get mapState => _mapState;
int get actionRange => Rules.getTotalActionRange(
gameConfig: _gameConfig, playerTags: _playerTags, ownedItems: _ownedItems, playerSpeed: playerSpeed);
// Camera
CameraPosition get initialCameraPosition => CameraPosition(
target: _locationService.lastLocation,
tilt: INITIAL_TILT,
zoom: INITIAL_ZOOM,
bearing: INITIAL_BEARING,
);
Future centerCamera() async {
if (!initialized) return;
return _mapController.animateCamera(CameraUpdate.newCameraPosition(
CameraPosition(
target: _locationService.lastLocation,
zoom: INITIAL_ZOOM,
tilt: INITIAL_TILT,
bearing: INITIAL_BEARING,
),
));
}
// Refresh
Future refresh({bool markers = true, bool circles = true}) async {
if (circles) {
_refreshCircles();
}
if (markers) {
await _refreshMarkers();
}
notifyListeners();
}
void _refreshCircles() {
if (!initialized) return;
final int visionRange = Rules.getVisionRange(playerSpeed: playerSpeed);
final int adRange = Rules.getTotalAdRange(
gameConfig: _gameConfig, ownedItems: _ownedItems, playerTags: _playerTags, playerSpeed: playerSpeed);
_circles.clear();
_circles.addAll(MarkersHelper.createCircles(
visionRange: visionRange,
playerTags: _playerTags,
playerSpeed: playerSpeed,
actionRange: actionRange,
adRange: adRange,
location: _locationService.lastLocation,
));
if (_mapState == MapState.teleporting) {
_circles.add(Circle(
circleId: CircleId('teleportation_range'),
center: _lastLocation,
radius: teleportationLimitMeters,
visible: true,
strokeColor: NeoColors.red.withOpacity(0.5),
strokeWidth: 3,
));
}
}
Future _refreshMarkers() async {
if (!initialized) return;
final int visionRange = Rules.getVisionRange(playerSpeed: playerSpeed);
_markers.clear();
_markers.addAll(
await Database.getVisibleBuildingMarkers(
gameId: _gameId,
player: _player,
visionRange: visionRange,
),
);
_markers.addAll(await Database.getVisibleCashMarkers(visionRange: visionRange));
_markers.addAll(await Database.getVisibleCoinsMarkers(visionRange: visionRange));
_markers.addAll(await Database.getVisibleDeckMarkers(visionRange: visionRange));
_markers.removeWhere((Marker item) =>
_collectedMarkers.collectedCoins.contains(item.markerId.value) ||
_collectedMarkers.collectedDecks.contains(item.markerId.value) ||
_collectedMarkers.collectedCash.contains(item.markerId.value));
}
// MapStates
Future showVisibleMarkers() async {
if (!initialized) return;
_mapState = MapState.normal;
refresh();
}
// Markers
void resetCollected() {
if (!initialized) return;
_collectedMarkers.collectedCoins.clear();
_collectedMarkers.collectedDecks.clear();
refresh();
}
void reset() {
_mapState = MapState.normal;
_locationService.teleportationLocationSink.add(null);
notifyListeners();
centerCamera();
refresh();
}
@override
void dispose() {
_subs.dispose();
super.dispose();
}
}`

Hi @jgrandchavin
Unfortunate, the app you provided isn't available in my country.  Can you please provide a minimal complete reproducible code sample without third-party packages
Thank you

Hello @TahaTesser,
Ok, maybe I can do a little project, publish it as a game on the PlayStore, give you the code and then we'll see together if the issue can be reproduced on one of your phones.
Do you think it's a good strategy for you ?

Hey @jgrandchavin
Just a code sample that includes similar markers with onTap is sufficient, I will reproduce it on my end and test with game mode, even if it doesn't reproduce it helps us to understand how to resolve this, and please don't use third-party packages for the code sample.
Thanks

Hello @TahaTesser,
I wish you an happy new year ! 🎉
Sorry for the delay, here is the sample code to reproduce the issue https://github.com/jgrandchavin/google_maps_markers_shifted

Hello @TahaTesser,
I wish you an happy new year ! 🎉
Sorry for the delay, here is the sample code to reproduce the issue https://github.com/jgrandchavin/google_maps_markers_shifted

Hi @jgrandchavin
Thanks for the code sample, I published the code in an app registered as a game on the play store (internal testing release) and tried to run the app in-game mode and non-game mode. Tap areas are working fine, both markers and right/bottom areas as you pointed in your screenshot.
Preview

I tried it on Oneplus 8 and Realme 6.
Were you able to reproduce this issue using your code sample on any device that you have? Can you share a recording of this behavior if possible?
Thank you

Hi @jgrandchavin
Thanks for the code sample, I published the code in an app registered as a game on the play store (internal testing release) and tried to run the app in-game mode and non-game mode. Tap areas are working fine, both markers and right/bottom areas as you pointed in your screenshot.
Preview

I tried it on Oneplus 8 and Realme 6.
Were you able to reproduce this issue using your code sample on any device that you have? Can you share a recording of this behavior if possible?
Thank you


Prefix the current directory to location to path of eslint

The assumption here is that when using eslint from the local/project
node_modules, the user is located in the projects root directory. If
not, the global eslint should be used. If you want to use node_modules
from somewhere else e.g. your user home directory. This might fail, in
that case either use the global one or revert this commit and use it or
update the code to conditionally add cwd.

Why does the cwd need to be explicitly prefixed? Every relative path is by definition already relative to the cwd, isn't it?

Why does the cwd need to be explicitly prefixed? Every relative path is by definition already relative to the cwd, isn't it?

I'm not sure what kind of environment the newly execed shell gets; not too familiar with vim.eval(). However, it doesn't appear to be the directory from where findfile() was invoked or we  would not get a No such file or directory error.
In other words if you have a relative path and then fork and exec a new process and a different directory the path might not be valid.

@theanimal666 Since you originally wrote the eslint integration, could you review this pull request?

@noob9527 @dc3671 @hexasoftware @mqudsi As contributors to the eslint integration, do you have objections or see any potential issues with this PR?

Since there are no objections I'm merging this.


[diem framework] Add metadata field to preburn requests

This adds an opaque-to-Move metadata field to each preburn request in the preburn queue. This is currently not used or set, but put in for future use as it's easier to do so now and avoid a data upgrade later on.
This PR also updates the json-rpc view for preburn queues to support returning the metadata associated with each preburn request in the preburn queue.

This PR may have modified JSON-RPC server code.
Breaking changes policy:

Chaning JSON-RPC method signatures or removing/modifying fields
in the response in /V1 will not be accepted.
Adding fields is ok.
Adding a new JSON-RPC method is ok.

Please ensure you have also done the following to update the docs:

Update json-rpc/API-CHANGELOG.md.
Add/update type/method documentation under json-rpc/docs.

can we get the metadata sent with BurnEvents as well?

/land


Feature/view caching

This adds view fragment caching for set tiles in order to decrease page load time.  It makes use of cache digests, which comes with Rails 4.  Set tiles appear on source_sets#index and source_sets#show (in the "Related primary source sets" carousel").  They look like this:

Logs show that rendering these tiles greatly slows page load time, and because of the nature of the required database calls, they cannot be effectively cached in the controller.  However, they are a good candidate for fragment caching, especially considering that they are relatively static - the associated image and tags change very infrequently.  This has been tested locally, and significantly reduces page load time.
Changes in this PR include:

In the views, template dependencies are articulated according the cache digests conventions.  While this particular PR does not make use of template dependencies, it is now set correctly for any future fragment caching.  You can double-check this in your console by running, for example: rake cache_digests:nested_dependencies TEMPLATE=source_sets/index.

Caching is turned on in the development environment for testing purposes (see config/environments/development.rb).

Since the set tiles conceptually represent a set, the cache key for each set tile fragment is tied to the sets table; whenever the sets table is touched, the key expires.  The tricky part is that correctly rendering a set tile depends on data not only from the sets table, but also from sources, images, tags, and vocabularies.  So we need to make sure that when an entry in any one of these tables is updated or destroyed, or when an association between any of these tables is added or removed, the sets table id also updated.   That's what all the changes in the models are about.  It's easy in the Source model because a Rails method already exists to take of all these dependencies for belong_to relationships - but for all other types of relationships, we have to code it out.

JavaScript is used to to hide the tags for the set tiles in the source_sets#show "Related primary source sets" carousel".  This is so that the same cache fragments can be used in both contexts.  The carousel already depends on JavaScript to render, and defaults to a simple list of sets (as opposed to set tiles) if JavaScript is disabled.

Extensive tests to ensure expected behavior.

In the future, I would like to refactor this to eliminate redundancies and make into something more generally useful in different contexts.  I would also like to add one or more fragment caches in other parts of the application.  But for now it might be worth seeing how this behaves in production environment and iterating later.

Here's the ER diagram, for reference: https://digitalpubliclibraryofamerica.atlassian.net/wiki/display/TECH/Relational+Database+Model

I'm finally reviewing this. Sorry for the delay.

This looks consistent with the Rails documentation recommends. I think it's OK, and will pass it along for review. (Though see below)
The Javascript that hides the tag HTML elements is the part I'm least enthusiastic about.  Could there be separate view fragments for the carousel items?  We shouldn't use Javascript to fix problems with the view rendering what's basically the wrong HTML.
If that can't be pulled off, it seems that the tags ul element should default to visibility: hidden;, and the Javascript in the Set page should set visibility: visible;, to avoid a jitter in the page layout when it displays and then is hidden.
I agree with using Rails's builtin caching, at least for the time being, but it's not ideal. The cache digests are an OK idea in order to make this feasible for a wide variety of applications without a lot of engineering going into them to devise schemes specifically tailored to each application; but I think more could be done to issue fewer memcached requests. We'll have to let that be for now.

@markbreedlove thanks for your review, and for bringing up the use of javascript to hide HTML elements.  I don't know why I didn't realize initially that I could just hide that block with CSS, no javascript necessary.  I made the change here https://github.com/dpla/primary-source-sets/pull/168/commits/02419d13bc8a9565bd4243f6ae3117171cfb1c1f
While I was at it, I also deleted the lines:
   margin: 2em 0;
}```

because I realized they were superfluous.

Thanks, @AudreyAltman. I don't think I have anything more to add and would be happy merging this. Is anyone else in line to review it?  I'll wait for it to be squashed and for your go-ahead before merging.

I don't think anyone else needs to review it.  I'll go ahead and squash.

@markbreedlove okay, squashed and ready to merge!


Custom namespacing and overriding

Question: We're trying to use styled components to style react components that'll be rendered on third party webpages.
I've looked at the docs and asked on gitter but haven't found an answer. Is there a way to apply a custom class prefix? Just to ensure it's something 'reserved' to our components and won't impact any other page?
Also would be possible to go create a global function/helper that goes through every rule and do something? (e.g. add !Important)

Why would you want to add a custom prefix if any class is a hash anyway? No one writes random classes in real CSS so you shouldn't worry about that.
It's not possible to go through all rules and add !important as far as I know.

@k15a well, just to be sure, if the host page uses styled components it's rare but not impossible right?

It's like worrying about guids. Random enough that you shouldn't pay it
mind.
On Tue, Jul 4, 2017 at 2:23 PM Alessandro Tagliapietra <
<EMAIL_ADDRESS>wrote:

@k15a https://github.com/k15a well, just to be sure, if the host page
uses styled components it's rare but not impossible right?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/968#issuecomment-312931526,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1iN2GKClD-cVQ1vzYPeeD9jSIWKkks5sKoM2gaJpZM4ONmTv
.

Well guids are much longer, anyway thanks for the explanation :)

The class is based on a hash of the contents of the class, so even if the classes overlap they'll apply the same styling anyway and it wouldn't matter!

The changing class is based on the componentId and the generated CSS: https://github.com/styled-components/styled-components/blob/master/src/models/ComponentStyle.js#L32
The componentId is based on the displayName plus an increment: https://github.com/styled-components/styled-components/blob/master/src/models/StyledComponent.js#L178
murmurhashes are unlikely to collide

So you should be fine :smile:
If you'd like to guarantee uniqueness in an even safer manner, you can use the babel plugin to generate a componentId based on the file's properties as well: https://github.com/styled-components/babel-plugin-styled-components/blob/master/src/visitors/displayNameAndId.js#L88

Thank you @philpl for all the details! :)


Remove the fmt module

With trait objects working, we no longer need the fmt Rust module. This PR removes it.

Fixes #19


Fixes broken links for authorization page

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.7 Features: set Milestone to 1.7 and Base Branch to release-1.7
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: Please check the “Allow edits from maintainers” box below to allow
reviewers fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

This change is

Hi @chenopis. I foo barred my commits on PR #3900, so created a new PR for this here instead with the changes you requested from there. Thanks!

@karthequian No worries. Thanks for this! =)


Release documentation for metamodel & Model SDK 9.23.0

Already published via https://github.com/mendix/docs/pull/5690


Drop rustc-serialize dependency

It has been deprecated: announcement.

Unfortunately it's still a standard part of docopt.rs's API. Once that's updated, then it will be possible to convert a lot of my projects.

Got it. Looks like they're tracking this on their end in https://github.com/docopt/docopt.rs/issues/128.

OK, rust-serialize is no longer required by docopt, so I'm eliminating it gradually from all my Rust projects. Thank you for letting me know about the deprecation!


Update official release to v8.0.26

Changes proposed in this pull request:

Update to latest UniFi Network Application 8.0.26

@goofball222

Eeek what nasties have they got in v8? I've just been bitten (upgrade to 7.5) by the sneaky forced regression from port profiles to fully open individual port configs... (what no major release version for a breaking change? Naughty, Unifi!) Honestly the more switch ports you have, the less you want to have to individally configure them. Adding a new vlan, or other change that affects hundreds of ports... you want to do that for every port or once in a profile? I guess it is nice that you can configure a port on its own, but that should be considered bad practice and not the forced default.
Thanks for all your work keeping this image uptodate, Alex.


Post scheduling not publishing posts at the scheduled time

Issue Summary
I am running a self-hosted Ghost installation on Ubuntu 16.04, on a DigitalOcean droplet, inside a Docker container, using the standard alpine Ghost image. I had written a post and scheduled it to publish in the future. When I checked a day after the publish date to ensure it had become visible, it had not. This is not a timezone issue as the post was scheduled to publish about 36 hours ago at the time that I checked.
Steps to Reproduce

Create a new post
Schedule it to publish in the future
Check at scheduled time to see post published on live site
Post is not published

In the list view of stories, the story was still marked with a green badge, "scheduled", and said in green text that it "will go live on ", as expected, however this date was in the past, and the expected result would be that the story say "Published" and not "scheduled" at this point.
Technical details:

Ghost Version: 1.17
Node Version: 6.11.5
Browser/OS: Firefox / MacOS
Database: SQLite

Hey!
Sorry to hear you are having trouble, but i can't reproduce.
Please swing by our slack channel to figure out why post scheduling does not work for you.
Maybe this link helps you.
We can re-open this issue if it turns out to be a bug in Ghost.


Can you provide the browse default template

Can you provide the the default template of  browse?

I found it .

@ourfor Please use https://caddy.community/ for such questions in the furture


[5.6] Adjustments in PHPDoc of chunkById() methods

Some follow-up to #14711 and  #17034.

$column can be omitted in Eloquent's method. (in Query Builder too, but it's slightly different, it's a default string)
$alias can be (and is most of the time) omitted.

Perfect, thanks. :)


Add most Generation 7 sprites

So, I went and added most, if not all, of the Generation 7 sprites. That's it. No code changes. Just the sprites.
Note, I got them from Serebii.NET's SM Pokedex pages. If that's frowned upon, then hey, at least I know for next time.

First of all I'd like to say I'm sorry I took so long to get to this, but life has been quite busy for me.
Thank you so much for the contribution :) I don't frown upon getting them from Serebii. In the future I'd like to rip them straight from the game, but for now this is perfectly fine.
A couple of things I'd like to note:

All sprites need to be 100x100.
The lighter background colors for the formatter are pre-generated and need to be adjusted.
Sources should be listed in the About tab.

I'll take care of these now, but please consider them if you'd like to send a PR for sprites again in the future. Thanks again for the help :)


Unraid 6.12 compatibility

Needs changes to be compatible with unraid 6.12+, currently marked incompatible on RC1
https://forums.unraid.net/topic/86715-corsair-rmi-hxi-axi-psu-statistics-cyanlabss-fork/?do=findComment&comment=1241308

Needs changes to be compatible with unraid 6.12+, currently marked incompatible on RC1 https://forums.unraid.net/topic/86715-corsair-rmi-hxi-axi-psu-statistics-cyanlabss-fork/?do=findComment&comment=1241308

I have a working version running right now. I am just waiting for permission to continue this plugin, because the original maintainer doesn't use unraid anymore.


neon: update to 0.33.0

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

neon: update to 0.33.0
Change Log

../SPECS-EXTENDED/neon/neon.signatures.json
../SPECS-EXTENDED/neon/neon.spec
../cgmanifest.json
Does this affect the toolchain?

NO
Associated issues

#xxxx

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-YYYY-XXXX

Test Methodology

Pipeline build id: xxxx

The PR is a leaf PR which builds alone successfully.


Update Dockerfile

The new code in step-file-parser is not compatible with lark-parser 1.x as you noticed

Perfect thanks!


Add support for more OSC color formats

Summary of the Pull Request
This PR improves and adds more color format support for OSC 4/10/11.

References

https://linux.die.net/man/3/xparsecolor

PR Checklist

[X] Closes #3715
[X] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
This PR introduces the following changes:

Correct the behaviour of parsing rgb:R/G/B. It should be interpreted as RR/GG/BB instead of 0R/0G/0B
Add support for rgb:RRR/GGG/BBB and rgb:RRRR/GGGG/BBBB. The behaviour of 12 bit variants is to repeat the first digit at the end, e.g. rgb:123/456/789 becomes rgb:1231/4564/7897. This is done by caculating value / 0xfff * 0xffff.
Add support for # formats. The RGB value caculation is the same as rgb: format. Note that the caculation behaviour is not following XParseColor documentation. This is done because it's close to what it looks like on the web. And it's supported by VTE.
See #3715 for details.

Validation Steps Performed
Manully tested.

New misspellings found, please review:
* xes

To accept these changes, run the following commands
✏ Contributor please read this
⚠ Reviewers
At present, the action that triggered this message will not show its ❌ in this PR unless the branch is within this repository.
Thus, you should make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

OK where on the earth is xes? I literally can not find it.

I think https://github.com/microsoft/terminal/blob/master/src/inc/til/color.h and https://github.com/microsoft/terminal/blob/master/src/til/ut_til/ColorTests.cpp also need to be addressed but could be mistaken.

The behaviour of 12 bit variants is to repeat the first digit at the end, e.g. rgb:123/456/789 becomes rgb:1234/4567/7897.

Don't you mean rgb:1231/4564/7897?

@KalleOlaviNiemitalo  Yes you are correct. Thanks for pointing out.

I'd very much love to add the color names support in rgb.txt. But I think that file itself is for sure GPL. If we use sources like wikipedia, will it still count as using GPL-licensed content?
CC @DHowett

I'd very much love to add the color names support in rgb.txt. But I think that file itself is for sure GPL. If we use sources like wikipedia, will it still count as using GPL-licensed content?

You can get a rgb.txt file from XOrg and that's not GPL licensed.  https://www.x.org/releases/X11R6.7.0/src/X11R6.7.0-src2.tar.gz
Haven't checked how similar it is to the XParseColor version.
Also see https://en.wikipedia.org/wiki/X11_color_names
Another source could be the HTML specs.  https://drafts.csswg.org/css-color/#named-color

Thanks @Lo0oG for the information. I’m surprised (also glad) to know that’s not GPL licensed. We are going through the internal legal process for us to be able to use it.

What I don't get is GPL is still open-source. So why is it an issue to have GPL and MIT in an MS repo? Is it that the legal department doesn't want to have to deal with both? If so, then they should be overridden. Their job isn't to stop usage of OSS based on a particular license.

@WSLUser GPL is "Free" Software, what that means is if you distribute software binaries licensed under GPL, you have to distribute the source code too, MIT on the other hand has no such requirement and MIT licensed software doesn't have to be open source. The problem is that GPL is a "Viral" license, meaning if you include GPL licensed code in your product, you would have to distribute the whole product under GPL, and since some parts of this repo are also synced with the windows source code, it would mean microsoft would have to open-source windows itself, which would be a legal nightmare considering how much code was licensed from third parties. So, while GPL could be used as the license for windows terminal, it can't be used for windows, and hence no GPL licensed code can be included in this repo.

If so, then they should be overridden.

I don't think microsoft would be too happy with that😅

Thanks @AnuthaDev. I wrote basically the same thing then I saw your post and just give up writing my own.
Just want to point out that not allowing GPL code in this repo is actually MS following the rules of the OSS community. Surely one can copy GPL code and keep their work close sourced. And lawsuits about GPL violations are not always feasible. Imagine in what world would XOrg actually sue MS for just some color metadata. It’s not all about getting away from legal issues. It’s also about MS trying to be a good OSS citizen.

I think it's perfectly fine to keep settings.json supporting only the #rrggbb format and not these OSC color formats. Wouldn't want to list all the color names in the JSON schema.

Overall I'm excited about this PR. The reaction of a OSC 4/10/11 in WT (and conhost) is basically the same as GNOME Terminal (and presumably any other VTE-based terminal).

(Due to the other comment about an unordered map being more efficient being on an outdated commit, I cannot reply directly.)
static_map serves as a landing zone for us to go and switch to constexpr once we can build with /std:c++20 and get constexpr sort. It might come at cost until then. In fairness, I asked Chester to use it here by way of kicking the tires.

static_map serves as a landing zone for us to go and switch to constexpr once we can build with /std:c++20 and get constexpr sort. It might come at cost until then. In fairness, I asked Chester to use it here by way of kicking the tires.

Ah OK. I thought maybe it was something about the parameter types that were preventing the constexpr sort from working. I forgot it needed c++20. But even if the map construction were happening at build time, that's just improving the startup time - I wouldn't think it would make the lookup itself any faster. Anyway, it's not a big deal. I was just curious about the choice, and I could be wrong about the speed advantages of the map anyway.

Yeah, there’s definitely something we could do to improve lookup time. I wonder if it’s worth having a perfect hash here? It’s a relatively large table so log() is about 9...
Speaking of: What madness! 6400 bytes of just color names. Not to mention the 3012 bytes of actual RGB values... and the 8 bytes per entry (6024b total) for the pointers to the constant strings!

Speaking of: What madness! 6400 bytes of just color names. Not to mention the 3012 bytes of actual RGB values... and the 8 bytes per entry (6024b total) for the pointers to the constant strings!

When I was testing this functionality on other terminals, I noticed that a few of them actually ignore most whitespace in the name. Doing that would assumedly mean you could drop nearly half the values in the table. I'm not sure if it's worth the effort, though, and it's not strictly compatible with XTerm, but just FYI.

I like the idea of dropping whitespaces. Some of them are identical colors with just different name. Something like a multi-key-same-value-map would also help.

I guess it’s all tradeoffs, right? Once we get constexpr sort... 9 string comparisons for lookup (log2(658) where the values have had whitespace stripped) versus runtime insertion time for an unordered map... versus a theoretical perfect hash. I generated one with gperf and it’s 42k on-disk.
In Windows, we get bugs automatically filed on us(1) for binary size changes and pages read from disk, so I have a bias towards smaller things on-disk that can share COW pages. Something fully statifiable like CodepointWidthDetector or static map (when it actually works) speaks to me for those reasons.
1: we have to fix them, take an IOU out of our department’s budget, or go defend the size/disk read increase to some leadership folks.

My initial indictment of CodepointWidthDetector was that we had 52k of actual code in the text section to populate a static map that was used in almost all codepaths. That’s why we had “GetCharWidthQuick”, I reckon.
Replacing that one with a static table worked out pretty well, because it could be shared and had no construction cost and could be trivially searched.
I’m still deciding how I feel about the color table :)

I'm seeing 676 left (@DHowett  you got 658 cuz some of the name actually contains more than one space). So between smaller footprint and letting people use something as weird as Lig ht Gre en... I'm not sure anymore...

The behaviour of 12 bit variants is to repeat the first digit at the end, e.g. rgb:123/456/789 becomes rgb:1231/4564/7897. This is done by caculating value / 0xfff * 0xffff.

I didn't see any unit tests for the 12 or 16-bit channel values, but I think this algorithm description is wrong. For example, this turns 0x600 into 0x6005, according to Windows' calculator.
The algorithm itself seems correct, it's the same thing XcmsLRGB_RGB_ParseString does to turn any number of digits into a 16-bit channel value. It's just the text that confused me.
That said, it looks like this never happens, because the colour parser ends up scaling down to 8-bits-per-channel, rather than up to 16-bits per channel.
I'm a bit suspicious of that scale-down algorithm too, as it appears to just be trimming the least-significant digits (it seems scaleMultiplier appearing in scaleDivisor cancels out? For example, given 0x6ff, it gets scaled down as (0x6ff * 0x11 / (0x11 << 8 >> 4)) => 0x6f. I'd have expected 0x70 there. Scaling up those two possible values, again, we get 0x6f6f and 0x7070. That's a difference from the original of 0x90 and 0x71 respectively, suggesting that 0x70 was the more-correct value to scale down to.
That said, I'm basing this on rounding-to-nearest behaviour: if there's specific rules about scaling colour channel values down, I'm unaware of them. For example, I tried to invert the round-up rule above as 0x6ff * 0xff / 0xfff, and that also comes out with 0x6f. However, the same rule for 0x6f0 comes out with 0x6e, while the algorithm in the code still gives 0x6f. There's a good change this last thing was not how one inverts that rule though, since in its native habitat, it only ever scales up.

Yeah there’s some gap between the description and the code, cuz too many debates and changes since it’s written. I stole the algorithm directly from @j4james. So probably he has more context.

Ah, up in https://github.com/microsoft/terminal/pull/7578#discussion_r486509990, I see.
That said, your original scale-down algorithm is the same one I tried to make up here, inverting the round-up algorithm from XOrg. I suspect it needed a "+0.5" of some kind to make the integer division be rounded correctly anyway, but the new scale-down algorithm is not equivalent to it, as far as I can tell.
Since it seems the leaning for OSC 4 n ? implementation in #3718 will always be rgb:hhhh/hhhh/hhhh, repeated round-trips through OSC 4 n ? and OSC 4 n <string we just got> probably should not continue to drift after the first precision loss. I am assuming we'd use the XcmsLRGB_RGB_ParseString agorithm to scale the stored 8-bit values up, i.e. x * 0xffff / 0xff, so the scale-down needs to accurately invert that.

In my tests, most terminals (including XTerm) would truncate the high resolution components down to an 8-bit range. So 9ABC is effectively stored as 9A (not rounded up to 9B). And when the colors are reported back with 16-bit components, the 8-bit value is just repeated, so 9A reports as 9A9A. You can think of that as x * 0xffff / 0xf or simply multiply by 0x0101. You're not guaranteed to get back your original 16-bit component, but repeated round trips should be stable.

Anything running on X11 is probably going to have the same behaviour, because all the truncation/scaling is done by Xlib or the XServer, not the terminal. My only concern is where behaviour skews because X11's API uses 16-bit colour channels, while our API us using 8-bit colour channels.
(I wander off into the X11 implementation below)

As far as I can tell, XTerm defers all such manipulation to the X Server (via XAllocColor), which ends up in a pScreen->ResolveColor implementation, which says "Please don't simply truncate these values to the upper 6 bits, scale the result so that the maximum value seen by the client will be 65535 for each primary." for the example of a 6-bit-per-pixel display.
The two in-tree implementations I found (miResolveColor and xnestResolveColor) do indeed truncate and then rescale, so the colour always ends up as "some 8-bit value * 0x101". This is then passed through FindBestPixel to actually calculate the closest value, since RGB is device-dependent, and (I think) CMapRefreshColors provides the actual list of possible channel values based on the device gamma setup. Although since you're seeing multiples of 0x101 in testing, perhaps the colour map is being set up by some other function, or the gamma values line up with that anyway.

So yeah. After all that, it seems reasonably consistent with XParseColor and XTerm's palette handling, that if we only store 8-bit values internally, we can just truncate incoming 16-bit values, and multiply by 0x101 before reporting them back via a 16-bit API.
And hence my claim on #3718 was incorrect, in so far as XTerm's behaviour is to report the screen-displayed colour (before scaling down from 16-bit channels), not the exact previously-set colour, when queried. Which certainly simplifies a few things for us here. And means with HDR enabled, perhaps we could report the resulting 10-bit colour for OSC 4 n ?.

dont write me
Le dim. 13 sept. 2020 à 02:31, Chester Liu<EMAIL_ADDRESS>a
écrit :

@skyline75489 commented on this pull request.
In src/inc/til/static_map.h
https://github.com/microsoft/terminal/pull/7578#discussion_r487463543:

@@ -17,7 +17,7 @@ namespace til // Terminal Implementation Library. Also: "Today I Learned"
using const_iterator = typename std::array<std::pair<K, V>, N>::const_iterator;

     template<typename... Args>

   constexpr explicit static_map(const Args&... args) :

   constexpr explicit static_map(const Args&... args) noexcept :

I'm getting warning C26455: Default constructor may not throw. Declare it
'noexcept' for some reason.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/pull/7578#pullrequestreview-487264957,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQKET3AODPPQ54SBJNRRQZLSFQHHNANCNFSM4RB4DOGQ
.

I'm quite unhappy with the storage performance characteristics of til::static_map, and it looks like even moving to C++20 will not make it constexprable because of some issue in pair/string_view.
As built, this color table takes up 53k (last conhost build was 948k total!) in .text and a commensurate time is spent initializing it.
I'm considering nullifying the usability enhancements in static_map and introducing one that requires its input to be sorted. This drops the cost in the binary down to 8k and zaps the init cost to 0.
@skyline75489 do you mind if I propose a set of changes into your branch?
Before I do that, would you mind moving this table, the campbell tables, the xterm256 table, and the functions that deal with them out of utils.cpp/utils.h and into a new colorTables.cpp/colorTables.h?

Well guess what. I'm up early and I've got no life. So there you have it.
And wow. 53k! Holy smoke that's a lot.

OK I actually run the runformat.cmd and nothing is changed. Yet the bot is telling me the code style is not healthy. I'm lost now..

I'm still seeing about 30k of binary size growth of OpenConsole.exe (1037k -> 1067k). I'm guessing it's not entirely the same as conhost.exe, but I'm still worrying that the binary size is gonna be a problem.

If we had a prefix trie we could probably remove the duplicate cost of the ~514 colors that are literally just colors with different numbers at the end... which would save approximately 5174 bytes. It would complicate this PR a lot, so I'd rather do it later.

 I think I messed up the commits. Well this is indeed a lengthy thread. In fact I think this is most commented PR I've ever made on Github. I'll force push later.

Well, cttrie is out of the question.
Even with half the colors removed:
cl
C:\Users\Dustin\Projects\thirdparty\Terminal\trie\cttrie\getindex.h(26): fatal error C1202: recursive type or function dependency context too complex

clang
./cttrie/getindex.h:27:32: warning: stack nearly exhausted; compilation time may suffer, and crashes due to stack
      overflow are likely [-Wstack-exhausted]

(it's still trying to compile, but I had to set the template depth to 1048576.)

@DHowett I also tried Trie-Gen and with the 3800 loc it generated, the binary size went up to 1080k. So... you can rule that out, too.

cl took 7 minutes before emitting an error message, and clang is still going (miraculously)

Man those poor compilers. They didn't even know what hit them.
Trie-Gen gave me pure C code which is no burden for compiles but not optimized for binary size.

If you're desperate, you could probably save around 5KB by storing the data as two simple arrays. 2704 bytes for the 676 RGBA quads, and 12351 bytes for the strings (6943 bytes of content and 676 pointers). You'd have to then build the map at startup, but I wouldn't think that would be a huge amount of code. Not sure it's worth the complication though.

Yeah, I'd say it's not worth it.
I got the table down to ~5kb using a gperf hash and stripping the color names entirely, but that is riddled with false positives because there's no actual check that the key matched.
(the good)
input: peachpuff
lookup: peachpuff
hash: 2059
found! Color #FFFFDAB9

input: AnTiQuE WhItE
lookup: antiquewhite
hash: 432
found! Color #FFFAEBD7

(the bad)
input: not a color
lookup: notacolor
hash: 599
found! Color #FFEEE0E5

input: ffuphcaep
lookup: ffuphcaep
hash: 2059
found! Color #FFFFDAB9

input: peachpuff
lookup: peachpuff
hash: 2059
found! Color #FFFFDAB9

So I was thinking what if we store the colorTable with prefix trie in some kind of string representation and compressed it using gzip or zlib, then decompress and reconstruct the trie...
OK let's do gperf hash then. I think the false positives should have very limited real-life impact, at least to "normal" people who don't mess around with their terminal.

Thanks for your contributions, everyone!


section for reporting issues

Includes a readme section pointing the user to the wiki before opening an issue.
Closes #145

/ok-to-test
/approve

/lgtm


update task metadata API response when no metadata

Currently, when there is no task metadata Znode, the task metadata API throws exception.
This behavior is confusing when users are trying to get metadata for tasks that do not make use of metadata mechanism (e.g. SegmentGenerationAndPushTask). The following figure shows an example. Users think something is wrong because they see error, but actually everything is correct.

This PR changes this behavior by returning empty JSON. For tasks that do make use of metadata mechanism, returning empty JSON when the task metadata Znode does not exist should also be okay.

Codecov Report

Merging #10301 (6a6c055) into master (4e0afef) will decrease coverage by 56.66%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #10301       +/-   ##
=============================================
- Coverage     70.35%   13.69%   -56.66%
+ Complexity     5826      182     -5644
=============================================
  Files          2016     1961       -55
  Lines        109643   107174     -2469
  Branches      16681    16388      -293
=============================================
- Hits          77136    14678    -62458
- Misses        27096    91330    +64234
+ Partials       5411     1166     -4245

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
13.69% <0.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...roller/api/resources/PinotTaskRestletResource.java
10.76% <ø> (-1.69%)
:arrow_down:

...lix/core/minion/PinotHelixTaskResourceManager.java
29.75% <0.00%> (-21.14%)
:arrow_down:

...src/main/java/org/apache/pinot/sql/FilterKind.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ain/java/org/apache/pinot/core/data/table/Key.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...in/java/org/apache/pinot/spi/utils/BytesUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ain/java/org/apache/pinot/common/CustomObject.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/java/org/apache/pinot/core/data/table/Table.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/core/data/table/Record.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/core/util/GroupByUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/BaseRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1588 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Better colors (Themes)

Hello,
I think we can have some sets of colors or themes.
For example users like theme look like: coreui or adminlte.

@AGhasemzadeh Yes, for now, you can redefine colors in _variables.scss. The docs is here.

For example colors like:
http://coreui.io/demo/Ajax_Demo/#main.html
https://adminlte.io/themes/AdminLTE/index2.html
Most customers like dark sidebar like examples.

Too much bloat. Just add the through variables.


Roles as Code Takeover

Ryan is taking over from John Mastron.

Meeting with Gabe from MCP on Wednesday, copied relevant code and documentation as well as writing up additional guidelines for MCP to use John's solution for eks OIDC providers.

Will be having a meeting with MCP on 6/7.

We met and passed the code the MCP.  Closing this ticket.  MCP will follow-up on progress on their end.


[pigeon] Add support for DateTime

Use case
DateTime is an extremely common type, likely to be used in many Flutter plugins. However, we need to convert DateTime to integer or string to communicate with the native code, and add the same logic both on Dart, Swift/ObjectiveC and Kotlin/Java, which is not type safe (one of the main goals of pigeon).

Proposal

Accept DateTime type on pigeon
Generate the code parsing DateTime from/to the StandardMessageCodec using integer or string.

I'll leave this open for future consideration, but adding new built-in types isn't really within the core scope of Pigeon.

However, we need to convert DateTime to integer or string to communicate with the native code, and add the same logic both on Dart, Swift/ObjectiveC and Kotlin/Java, which is not type safe

This is conflating logic with type safety. Having a string or an integer rather than a dynamic (or the nearest equivalent in the various host languages) is type safety. Converting between two enforced types doesn't lessen type safety.

Thank you for the considerations!
What I meant by "less" type type safe is that it's safer for the developer having this conversion done and well tested by pigeon than having to figure out how to do it for every native language (considering many Flutter devs work mostly with Dart). However, for pigeon, it will always be safer working only with the primitive types.

What I meant by "less" type type safe is that it's safer for the developer having this conversion done and well tested by pigeon than having to figure out how to do it for every native language

As I said above, that is unrelated to type safety. There is no type casting involved in converting between different representations of a date/time.


DbSync 12

OS
Your OS: Ubuntu 20.04.3 LTS
Versions
The db-sync version (eg cardano-db-sync --version):
cardano-db-sync-extended 12.0.0 - linux-x86_64 - ghc-8.10
git revision 9d0180571482ee4c6acb6fbc6bf55b5a4e2ee833
PostgreSQL version: 14.1
Build/Install Method
The method you use to build or install cardano-db-sync: built using cabal
Run method
The method you used to run cardano-db-sync (eg Nix/Docker/systemd/none): systemd
Additional context
Add any other context about the problem here.
Problem Report
Please do not include screenshots or images, but instead cut and paste any relevant log messages
or errors.
Constantly rolling back with a few minutes in between. Can't see any obvious errors just before. Log below include 3 errors with 6 rows before the error.
Let me know if you need any additional data. I know of at least one other that has seen the exact same problem.
{"thread":"191858","loc":null,"data":{"kind":"LocalHandshakeTrace","event":"Recv (ServerAgency TokConfirm,MsgAcceptVersion NodeToClientV_10 (TInt 764824073))","bearer":"ConnectionId {localAddress = LocalAddress \"\", remoteAddress = LocalAddress \"/opt/cardano/mainnet/sockets/node0.socket\"}"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node.Handshake"],"at":"2021-12-07T22:22:01.37Z"}
{"thread":"191858","loc":null,"data":{"kind":"MuxTrace","event":"Handshake Client end, duration 0.000342476s","bearer":"ConnectionId {localAddress = LocalAddress \"\", remoteAddress = LocalAddress \"/opt/cardano/mainnet/sockets/node0.socket\"}"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node.Mux"],"at":"2021-12-07T22:22:01.37Z"}
{"thread":"191859","loc":null,"data":{"kind":"MuxTrace","event":"State: Mature","bearer":"ConnectionId {localAddress = LocalAddress \"\", remoteAddress = LocalAddress \"/opt/cardano/mainnet/sockets/node0.socket\"}"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node.Mux"],"at":"2021-12-07T22:22:01.37Z"}
{"thread":"191862","loc":null,"data":{"message":"Starting chainSyncClient","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:22:01.37Z"}
{"thread":"191862","loc":null,"data":{"message":"Cardano.Db tip is at slot 47349366, block 6598995","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:22:01.38Z"}
{"thread":"191867","loc":null,"data":{"message":"Running DB thread","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:22:01.38Z"}
{"thread":"191867","loc":null,"data":{"message":"Rolling back to slot 47339971, hash c439ae788951c86a6e69fe3a62a99a27033fe92c98f6226ca4cb4d8299ae76fa","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:22:01.38Z"}
--
{"thread":"192004","loc":null,"data":{"kind":"LocalHandshakeTrace","event":"Recv (ServerAgency TokConfirm,MsgAcceptVersion NodeToClientV_10 (TInt 764824073))","bearer":"ConnectionId {localAddress = LocalAddress \"\", remoteAddress = LocalAddress \"/opt/cardano/mainnet/sockets/node0.socket\"}"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node.Handshake"],"at":"2021-12-07T22:26:04.75Z"}
{"thread":"192004","loc":null,"data":{"kind":"MuxTrace","event":"Handshake Client end, duration 0.000250957s","bearer":"ConnectionId {localAddress = LocalAddress \"\", remoteAddress = LocalAddress \"/opt/cardano/mainnet/sockets/node0.socket\"}"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node.Mux"],"at":"2021-12-07T22:26:04.75Z"}
{"thread":"192005","loc":null,"data":{"kind":"MuxTrace","event":"State: Mature","bearer":"ConnectionId {localAddress = LocalAddress \"\", remoteAddress = LocalAddress \"/opt/cardano/mainnet/sockets/node0.socket\"}"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node.Mux"],"at":"2021-12-07T22:26:04.75Z"}
{"thread":"192008","loc":null,"data":{"message":"Starting chainSyncClient","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:26:04.75Z"}
{"thread":"192008","loc":null,"data":{"message":"Cardano.Db tip is at slot 47349582, block 6599010","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:26:04.77Z"}
{"thread":"192013","loc":null,"data":{"message":"Running DB thread","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:26:04.77Z"}
{"thread":"192013","loc":null,"data":{"message":"Rolling back to slot 47349470, hash 96597efb34790d19bfe625f56410ed792deffcd36628df6d45642b25d6f699e9","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:26:04.77Z"}
--
{"thread":"192105","loc":null,"data":{"kind":"LocalHandshakeTrace","event":"Recv (ServerAgency TokConfirm,MsgAcceptVersion NodeToClientV_10 (TInt 764824073))","bearer":"ConnectionId {localAddress = LocalAddress \"\", remoteAddress = LocalAddress \"/opt/cardano/mainnet/sockets/node0.socket\"}"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node.Handshake"],"at":"2021-12-07T22:27:08.95Z"}
{"thread":"192105","loc":null,"data":{"kind":"MuxTrace","event":"Handshake Client end, duration 0.000356182s","bearer":"ConnectionId {localAddress = LocalAddress \"\", remoteAddress = LocalAddress \"/opt/cardano/mainnet/sockets/node0.socket\"}"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node.Mux"],"at":"2021-12-07T22:27:08.95Z"}
{"thread":"192106","loc":null,"data":{"kind":"MuxTrace","event":"State: Mature","bearer":"ConnectionId {localAddress = LocalAddress \"\", remoteAddress = LocalAddress \"/opt/cardano/mainnet/sockets/node0.socket\"}"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node.Mux"],"at":"2021-12-07T22:27:08.95Z"}
{"thread":"192109","loc":null,"data":{"message":"Starting chainSyncClient","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:27:08.95Z"}
{"thread":"192109","loc":null,"data":{"message":"Cardano.Db tip is at slot 47349688, block 6599017","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:27:08.97Z"}
{"thread":"192114","loc":null,"data":{"message":"Running DB thread","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:27:08.97Z"}
{"thread":"192114","loc":null,"data":{"message":"Rolling back to slot 47349470, hash 96597efb34790d19bfe625f56410ed792deffcd36628df6d45642b25d6f699e9","kind":"LogMessage"},"sev":"Info","env":"<unknown>:00000","msg":"","app":[],"host":"","pid":"1547363","ns":["db-sync-node"],"at":"2021-12-07T22:27:08.97Z"}

Might be own fault, investigating. Can most likely close issue soon.
Was because of added trigger on public.epoch and in that code querying for a now in 12.0 a column that has changed. epoch_params.cost_models. After fixing this it now seems better. But keeping open for a short time to verify.

I did get another rollback about 20 min later but seems unrelated to the reported issue. Cant find any obvious cause or error logged related to this one. But closing issue as reported one is not valid.


version v0.4.0

I see version 0.4.0 on pypi https://pypi.org/project/adlfs/
but I don't see any recent commits here or a release at https://github.com/dask/adlfs/releases
Any idea what happened?

Thanks for the catch.  Should be here now.