Make log chicken an option

It can produce a lot of spam for low level bots.

I feel like this is more of a personal want then something we need congesting up in default params.

Looks right to me

I would say no to this pr. Imo we don't need this in default botty. Chickens are seldom to none for the most part (outisde of the first 2 days of reset) where discord sends chicken logs shouldn't be a big deal to most.

As a user I can say this would be very helpful. Since I run a few bots would be nice to be able to troubleshoot setups and have a better logs of what happens during gameplay. I experience chickens often. I’m sure there are other users that do too.
Bitty should be for both those with optimal and suboptimal setups. This would definitely be for those of us who don’t run perfect gear.
Just my thoughts. 😊
d

On May 7, 2022, at 7:25 PM, Legit @.***> wrote:

I would say no to this pr. Imo we don't need this in default botty. Chickens are seldom to none for the most part (outisde of the first 2 days of reset) where discord sends chicken logs shouldn't be a big deal to most.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

It already logs for chickens but default. Not sure how it would be helpful to have the ability to turn it off.

I made it, because for bots with not so good items it produces a lot of messages. You might not actually care that your bots chickens 10% of the runs, but you don't lke that the chicken messages spam away the item found mesages.
This feature is not in any way super important though. Do with it whatver you see fit.


B 22037 server error review service items page int

Agility ticket
Issue ticket
Summary
This was an issue discovered from the testers where they attempted to make a payment request on a future SIT.
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Create HHG shipment as customer
Submit to counselor
Submit to TOO
Submit to Prime
Prime orders origin sit via prime sim with minimum required fields (Todays date provided)
TOO approves
Prime updates shipment, these fields

Scheduled pickup (Today)
Actual pickup (Today)
Scheduled delivery (Today)
weights (2k est, 2k actual)
Touch nothing else, submit update

Prime updates DOASIT departure date (Today), also have to add in customer contacted (today)
Prime update shipment actual delivery (Today)
Prime creates payment request for all shipment service items, not move management. (Tomorrow) provided for payment start and end of DOASIT
TOO clicks review service items, no error

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Test coverage on server failed.
Last run: Wed 04 Dec 2024 09:41:10 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.


Add key value pairs to javascript objects

Added solution to .md file

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thanks! This will get unified throughout the languages, but you couldn't have known at the time of writing.


test: add e2e kubernetes v1.28 test

🤖 Generated by Copilot at f01c29c
Summary
:sparkles::whale::package:

This pull request adds two new test files for testing the sealos cluster run command with different runtime and Kubernetes versions. The files are test/e2e/runtime_version_128_test.go and test/e2e/runtime_version_docker_128_test.go, and they use the containerd and docker runtimes respectively.

sealos cluster run
testing different runtimes
autumn of v1.28

Walkthrough

Add test suites for sealos cluster run command with different runtime and Kubernetes versions (link, link)

Create test/e2e/runtime_version_128_test.go for testing containerd runtime and Kubernetes v1.28.0 (link)
Create test/e2e/runtime_version_docker_128_test.go for testing docker runtime and Kubernetes v1.28.0 (link)

v1.28 not yet implemented , so close it.


As a user, I would like to have an RTC installed so that I can have accurate dates.

Testing of this is largely done.  We need to integrate this into PIO v4.


Refactor save so we can use the low level save internal methods

progressing, but this will need some further refactor, I think it should end in reading from kedro data catalogue or something compatible so the smart selection of sources and output and saving pickles and xls at the same time is basically predefined, with perhaps an option to override individually.


Fix #57 astext of undefined

Not tested - Should resolve https://github.com/prismicio/prismic-reactjs/issues/57

Thanks!


kTLS detection in Configure doesn't work for cross compilation

Version
v3.0.5
Description
For crossing compilation, I executes the following command to configure OpenSSL.
./Configure \
	--cross-compile-prefix="x86_64-pc-linux-gnu-" \
	enable-ktls \
	shared

However, I found that kTLS detection doesn't work as expected, no matter what value I passed via --cross-compile-prefix.
After investigation, it seems that Configure uses a wrong config entry $config{cross_compile_prefix}.
        my $usr = "/usr/$config{cross_compile_prefix}";
        chop($usr);
        if ($config{cross_compile_prefix} eq "") {
            $usr = "/usr";
        }
        my $minver = (4 << 16) + (13 << 8) + 0;
        my @verstr = split(" ",`cat $usr/include/linux/version.h | grep LINUX_VERSION_CODE`);

        if ($verstr[2] < $minver) {
            disable('too-old-kernel', 'ktls');
        }

I think it should be $config{CROSS_COMPILE} ?

By the way, I'm curious about that If my kernel header is in a different directory (e.g. /usr/local/x86_64-pc-linux-gnu/sysroot/usr/include/linux/version.h, not /usr/x86_64-pc-linux-gnu/include/linux/version.h)
Is there a recommended method to let Configure find it in the specified directory?

IMO replacing the detection with something similar to the freebsd routine would make sense - presence of linux/tls.h in the include path of the cross-compile environment should be good enough indicator.

Fix in #19213


Any redistributed package?

Because I found there is org.asciidoctor.cli.AsciidoctorInvoker, do we have any redistributed package for the guys who don't want install ruby version with whole ruby system?

Hi!
When using AsciidoctorJ there is no need at all to install Ruby at the same time.
AsciidoctorJ contains Asciidoctor and bundles JRuby in it.
There are several ways to install AsciidoctorJ.
If you already use SDKMAN, then it should be as simple as sdk install asciidoctorj.
Otherwise you can download a binary distribution for example at Bintray.
The Files section contains a -bin.zip archive.

Exactly what I means. I suggest publish this bundled binary distribution on asciidoctor official site as an alternative to gem installing. This would be nice for the people who is not a developer nor have Ruby environment.

Most users didn't have Ruby environment
But many users have Java runtime
We provided installation steps on asciidoctor portal for the gem one instead of the java one
This would prevent many people from using asciidoctor for who didn't want install whole Ruby environment

So I suggest publish this Java bundle to our portal as well.

Hi,
maybe I expressed myself badly, but there is no need at all to install Ruby or handle with Gems if you don't want to.
If you have Java and also SDKMAN installed (see link above), then simply calling sdk install asciidoctorj will give you Asciidoctor on the path that you can invoke on the command prompt via asciidoctorj.
If you don't have SDKMAN and don't want it, the you can download the zip from the Bintray archive, unpack it, and run the bin/asciidoctorj from there.

Hi,
I think the issue that @hcoona reports is about awareness.
Currently, the site documentation (http://asciidoctor.org/docs/install-toolchain/) does not describe the process to install AsciidoctorJ (or JavaScript), but only describes the Ruby implementation.
That makes entry for Java users a bit harder, because unless they found about AsciidoctorJ on their own they will try to install a Ruby environment.
Is that so?

Yes, @abelsromero you get the point.
@robertpanzer you explained about the asciidoctorj very good, but we are talking 2 stories. It's my bad to mix them together because I have to confirm whether asciidoctorj could run as a CLI tools before the awareness problem. I jumps to fast.
The site document only mentioned about the ruby version, which is very unfriendly to new users who didn't have ruby environment. AsciidoctorJ made a great progress to get rid of full ruby environment nor nodejs environment. I think it necessary to provided a well bundled version of AsciidoctorJ & publish it to the site document.

In that case we should move this issue to https://github.com/asciidoctor/asciidoctor.org.
Reviewing the site (http://asciidoctor.org/docs/), in the same page, below, there's a section about other ways to use Asciidoctor (AsciidoctorJ, maven, gradle, JS, etc.), but it's quite outdated, does not adress he CLI and does not address the of "being nice and easy for Java people".
And agree we should at least discuss how to address this point.

I agreed. We should definitely add this information to asciidoctor.org. We know we want to rework the site to make it more up to date, but that shouldn't stop us from fixing this specific page now.
I'll also add it to my list to turn the asciidoctorj page into an include like the reveal.js page so that is in sync with the README from the repo. I just need to make sure we don't lose any edits...though that won't take me long.

If it's of any use you can now install AsciidoctorJ using Chocolatey (#582) and you should hopefully be able to install it using Homebrew soon (Homebrew/homebrew-core#19517). Both download and unpack the -bin.zip from Bintray and add a shim or link to the asciidoctorj command.

The website now uses the README from the master branch. In the future we'll probably switch to a tag, but I need some changes that are in the master branch in order for it to work.
@robertpanzer I know we probably want to show the docs for AsciidoctorJ 1.6.0, but I'm going to defer that until we overhaul the website...which we're going to get started on later this quarter. The new website will let you browse different versions of the page.


Multiple nouislider widgets overwrite each others' selected value

If you add multiple nouislider widgets to a page and change the selected value of one of them, it changes the selected value of all of them. What do we need to do to make them work independently?
An example of this may be viewed at https://plnkr.co/edit/xsNFYHZKdLrBpulv?preview
Thanks!
Billy McCafferty

Answered here - https://surveyjs.answerdesk.io/ticket/details/t3714/multiple-nouislider-widgets-overwrite-each-others-selected-value

Thank you!!
[image: Welcome to Codai, Inc!]
Billy McCafferty
Software shokunin
t:<PHONE_NUMBER> | e<EMAIL_ADDRESS>http://www.codaiinc.com/
On Thu, Apr 2, 2020 at 3:03 AM tsv2013<EMAIL_ADDRESS>wrote:

Answered here -
https://surveyjs.answerdesk.io/ticket/details/t3714/multiple-nouislider-widgets-overwrite-each-others-selected-value
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/surveyjs/widgets/issues/167#issuecomment-607717813,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABH3YT65Q4ZDDQEVMTJDE7LRKRIENANCNFSM4LZSITCA
.


Complex zero to the power zero is nan

This is a simple yet dramatic bug:
0^0 does not return 1 for complex numbers  (left zero complex) !
System information

OS Platform and Distribution : Linux Ubuntu 16.04 LTS
TensorFlow installed from binary : pip
TensorFlow version : b'v1.13.0-rc1-0-g54c5616308' 1.13.0-rc1
Python version: Python 3.5.2

Describe the current behavior
tf.pow(tf.complex(0., 0.), 0) returns nan + nan j
Describe the expected behavior
It should be 1 + 0j as is returned by np.complex(0., 0.)**0
Code to reproduce the issue
z = tf.complex(0., 0.); sess = tf.Session(); sess.run( tf.pow(z, 0) )

True for TF2.0 preview as well:
In [12]: tf.complex(0., 0.) ** 0
Out[12]: <tf.Tensor: id=13, shape=(), dtype=complex64, numpy=(nan+nanj)>

My guess is that, tf.pow(tf.complex(0., 0.), 0) is casted to
tf.pow(tf.complex(0., 0.), tf.complex(0., 0.))

,  and C++'s std::pow is used, which results in  nan + nan j.
The fix may not be straightforward, as it likely may impact the existing APIs.

@jvishnuvardhan I don't know very much about this. Can you find a more fitting reviewer, please?

@jvishnuvardhan I don't know very much about this. Can you find a more fitting reviewer, please?

@thevincentadam thanks for letting us know. I'll send out a fix, probably sometime next week.

Hello, any progress on this issue?

I'm running into the same problem with TensorFlow 2.0. What is the status of this issue?

Issue is replicating with Tf 2.1 and tf-nightly
Please find the gist here . Thanks

Issue replicating with TF 2.2-rc3. Please, find the gist here.Thanks!

TensorFlow calls Eigen. Eigen calls std::pow. std::pow(0, 0) is implementation defined.
https://en.cppreference.com/w/cpp/numeric/complex/pow
To elaborate, mathematically z^0 is not well defined for |z| = 0 because the angle of z is indeterminate. It may be convenient to choose to follow the pattern for |z| > 0, for which z^0 is 1 + 0i, but it is an implementation choice.


Log everytime a signal is updated or sends an update

To aid in debugging beamline issues it would be good to know the following:

When a signal gets updated from an external source (e.g. a PV). In this case we will want to know:

The name of the signal
The name of the PV
The value we got
The old value (if possible)
Metadata about the update e.g. the EPICS timestamp

When a signal has been written to we would also like to log:

The name of the signal
The name of the PV
The value we got
The old value (if possible)

It should be obviously easy from the logs to differentiate between these two cases. It should be logged as debug as it will be a lot of info

To expand this slightly, we should add log messages to these functions:

https://github.com/bluesky/ophyd-async/blob/e54c91ce826f76a7398178b93243b980f796c102/src/ophyd_async/core/signal.py#L70 saying we are about to connect
https://github.com/bluesky/ophyd-async/blob/e54c91ce826f76a7398178b93243b980f796c102/src/ophyd_async/core/signal.py#L176 saying what value we got from the backend
https://github.com/bluesky/ophyd-async/blob/e54c91ce826f76a7398178b93243b980f796c102/src/ophyd_async/core/signal.py#L94 saying that we made a subscription
https://github.com/bluesky/ophyd-async/blob/e54c91ce826f76a7398178b93243b980f796c102/src/ophyd_async/core/signal.py#L110 saying that we got an update to the subscription
https://github.com/bluesky/ophyd-async/blob/e54c91ce826f76a7398178b93243b980f796c102/src/ophyd_async/core/signal.py#L97 saying we closed the subscription
https://github.com/bluesky/ophyd-async/blob/e54c91ce826f76a7398178b93243b980f796c102/src/ophyd_async/core/signal.py#L211 to say we are about to put a value to the backend, then one after to say the put is complete
https://github.com/bluesky/ophyd-async/blob/e54c91ce826f76a7398178b93243b980f796c102/src/ophyd_async/core/signal.py#L233 to say we are about to put the default value to the backend, and one to say it is complete

For those last 2, you will have to use the @AsyncStatus.wrap decorator a bit like https://github.com/bluesky/ophyd-async/blob/7be73e3ce0f79fca2e02f77f366792ee84586ed7/src/ophyd_async/core/standard_readable.py#L43 so you can put a log message before and after the await

Reviewers: @coretl @ZLLentz

In original Ophyd, the logs appended the name of the ophyd object  at the beginning of the message, but by default these objects didn't have a name. Should we keep it this way? It might be nicer for the default name of an ophyd_async device to be a string of its type.

These objects should be named before connection, so there should be something useful in Device.name most of the time

Fixed by #275


This Repo is Now Deprecated

This repository is now deprecated. Serilog now has the native ability to log span related data. See https://github.com/serilog/serilog/pull/1955.

Can you provide guidance on how to migrate from Serilog.Enrichers.Span to the new Serilog-native equivalent?
It's not clear from reading the attached PR comments what steps are required, if any!

The Serilog libraries are still a couple of months away from stabilizing, and there aren't any docs out there just yet. It's probably best to stick with this package in the meantime unless you have a strong reason to make the switch (happy to help if so!).

@rmorrin Serilog version 3.1 (unreleased at the time of writing) is most likely to contain the new span API's. Switching would be as simple as removing Serilog.Enrichers.Span and upgrading to Serilog to 3.1 and any other enrichers/sinks.

Serilog.Extensions.Logging (which implements ILoggingFactory) inderdeed does fill in SpanId and TraceId, however, nothing like ParentSpanId and SpanStart or similar is being enriched. Therefore, this library still has its use.

@Sebazzz are you currently using this library with a back-end that can use span start/parent span id to display the events hierarchically? (Exploring this space currently... :))


Test Merge Editor: Don't save should be Don't Save

Testing #158819
As mentioned in the title it should be Don't Save in this modal:

Thanks @hediet


Color enhancement

Description
Please include a summary of the changes and the related issue. Also, explain the motivation behind this PR.
Enhanced the color of contact us page . added missing code.
Related Issue
Fixes #382
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ /] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ /] My code follows the style guidelines of this project
[ /] I have performed a self-review of my own code
[ /] I have commented on my code, particularly in hard-to-understand areas
[ /] I have added tests that prove my fix is effective or that my feature works
[ /] New and existing unit tests pass locally with my changes
[ /] Any dependent changes have been merged and published in downstream modules

@subhadipbhowmik please check and review


Add docker image select param for make images

What type of PR is this?
kind/workflow
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #392
Special notes for your reviewer:

yeah ，I added judgment parameters in hack/make-rules/images.sh. If no parameters are passed, then package all modules

@MentosL Please squash your commits and add sign off. Thanks.
Also, would you please to make this PR works like WHAT=clusternet-hub make images?


updated user guide (non-technical)

wrote user guide section 1 and 2 in the adoc.

Pull Request Test Coverage Report for Build 418

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.925%

Totals

Change from base Build 393:
0.0%

Covered Lines:
2041

Relevant Lines:
2348

💛  - Coveralls


org.osbuild.qemu: use subformat=fixed for vhdx

AWS snapshot import reliability is relatively low for imported VHDX
images from time to time. The raw image format works very reliably and
osbuild-composer has temporarily switched to the raw format for AWS
images.
Try using subformat=fixed when creating the VHDX as this is the
required setting for Azure. It's possible that AWS needs the image
formatted the same way.
Signed-off-by: Major Hayden<EMAIL_ADDRESS>

Hmm, what do you suggest? Should we create a new image type of vhdx-fixed with that option applied? Or should osbuild accept some kind of option via the JSON that it adds to qemu-img convert?

I did some experiments with this, see: https://github.com/osbuild/osbuild/commit/21da52dbd035dc1790311a6a8cc5cfa853816a07

Thanks @ondrejbudai! Did you try a fixed vhdx yet?

Sadly, I think that subformat=fixed is not the way to go because it actually creates even bigger images than in the raw format.
However, I've had so far very good results with vmdk and subformat=streamOptimized. It looks like AWS is able to import it and it has very nice size. See:
$ qemu-img convert -O vhdx -o subformat=fixed Fedora-Cloud-Base-32-1.6.x86_64.raw Fedora-Cloud-Base-32-1.6.x86_64.vhdx
$ qemu-img convert -O vmdk -o subformat=streamOptimized Fedora-Cloud-Base-32-1.6.x86_64.raw Fedora-Cloud-Base-32-1.6.x86_64.vmdk
$ ls -lh
-rw-r--r--.  1 obudai obudai 4,0G  3. čec 15.36  Fedora-Cloud-Base-32-1.6.x86_64.raw
-rw-r--r--.  1 obudai obudai 5,2G  7. čec 10.49  Fedora-Cloud-Base-32-1.6.x86_64.vhdx
-rw-r--r--.  1 obudai obudai 277M  7. čec 10.50  Fedora-Cloud-Base-32-1.6.x86_64.vmdk

Note that this needs much more testing but so far it looks promising.


How are the tags detected in virtualHtml?

When I parse this:-
<details>

### Expand to see resulting DVC-file

# ...
deps:
  - etag: '"f432e270cd634c51296ecd2bc2f5e752-5"'
    path: https://data.dvc.org/get-started/data.xml
outs:
  - md5: a304afb96060aad90176268345e10355
    path: data.xml
    cache: true
    metric: false
    persist: false

<abbr>cache</abbr>
DVC checks the headers returned by the server, looking for a strong
[ETag](https://en.wikipedia.org/wiki/HTTP_ETag) or a
[Content-MD5](https://tools.ietf.org/html/rfc1864) header, and uses it to know
if the file has changed and we need to download it again.

</details>

I can only get abbr as the output for props.tag. Why does it ignore the details tag?

How are the tags detected in virtualHtml?

If you want the full details I'd recommend reading the source.

#428 correctly parses the details tag, which will resolve the issue you are experiencing.


Add support for custom graphs via langgraph-cli

Use any arbitrary state graph or message graph with opengpts through the API server created by langchain-cli.

launched as a single docker compose
postgres database shared between langgraph api and opengpts backend (different schemas)
to add a custom graph you'd edit langgraph.json and point it to your custom graph, adding any needed dependencies

Hi @nfcampos thanks greatly for your work on this branch with the new version of langgraph-cli. Just wonder if there is any plan to merge this new architecture into master for us to allow us better use or adapt to new backend? Thanks and happy to know any possible future plans for opengpts project!


[Bug] On StoryList, selecting an option in the 2nd filter after clearing the 1st filter causes browser crash

Describe the bug
When filtering and selecting options to view cards, certain interactions can cause the browser to crash locally.
To Reproduce
Steps to reproduce the behavior:

Click on first filter, and select any option
Clear option
Click on second filter, and select any option
Crash

Expected behavior
Clearing the first filter also clears the second filter, so that no option is clickable.
Desktop (please complete the following information):

OS: Win10
Browser: Firefox
Version: 83.0

Hello everybody,
I just did a pull request to fix this bug

Thanks, @Julien-Bidar!


Session Timer

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always
frustrated when [...]
It's not super important, I just find it slightly annoying when I'm hopping worlds and the Login timer resets. I just like to see how long I'm at revs or doing other things but the timer keeps resetting (since I technically log out of that world it's understandable)
Describe the solution you'd like
A clear and concise description of what you want to happen.
N/A
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've
considered.
Would y'all be able to add a "session" timer to the report button or at the top of the client beside the RuneLite logo (toggle on and off in case people don't want it there)? I know we have a Login Timer for when we login/out of the game but would it be possible to add one to keep counting up till we close our client? I also know there's a stopwatch/ timer but I'd rather not have to keep switching back and forth between that and the loot tab etc etc.
Additional context
Add any other context or screenshots about the feature request here.
N/A

I'd reccomend checking out the new Stopwatches for such a thing. It should keep counting up for as long as the client is open (Independent of logging out/hopping worlds).
Here's a picture of what I'm talking about:

You dont need to go back & forth, just look at that tab when you need to know (what is mostly never). I would say if we already have feature that can be used for this, use it and dont be lazy.

Was just a suggestion. I knew about the timers tab, I just thought it'd be good to have a sessions one.

When speaking on Discord about this topic, the idea was brought up by @Abextm that we could potentially allow for any timer/stopwatch to be bound to the report button to solve the 'issue' mentioned above. Currently, the Report Button plugin only has an enum with the various timers/times, maybe they could be migrated into the stopwatches/timers plugin and make the stopwatches/timers be bindable to report button.


How to upload a TensorFlow model with Giskard?

Hi @jmsquare
Good day!
I would like to take up this topic. Kindly help me to get started!

In fact, I would love to write more tutorials showcasing Giskard capabilities. If I can get someone to discuss further, I am real good to get started.

Hi @prajwal-cn please sign up over here: https://www.giskard.ai/write-for-the-community


[test] Re-enable very large allocation codegen test

A follow-up to #63034, #63093, #63110, #63095.
Hopefully this completes the saga.

Resolves rdar://104435186.

@swift-ci test

cc @ahoppen, @grynspan

@shahmishal, is there any good way to test this on the AArch64 Ubuntu CI platform before merging?

AFAIK, I don’t think there is a way to test AArch64 Ubuntu it in PR testing. I wouldn’t take that for a definite answer though.

We don't have aarch64 support available on PR testing right now, however we are able to trigger Apple Silicon testing if that help.

@shahmishal I suppose it wouldn’t hurt to test, but as I understand it that wasn’t giving any trouble…
I guess otherwise since all the bots are green the strategy can only be to merge and revert if necessary?

Yes, let's merge and if it breaks bots, we will need to revert again.


Upgrade to Ruby 3.1

TODO:

[ ] mixlib-cli, config, auth...
[ ] client tests
[ ] omnibus builds
[x] omnibus toolkit is decoupled
[ ] knife

Acceptance Criteria:

[ ] Should support Ruby 3.0 and 3.1 (do we need n-1 support?)

https://github.com/chef/corefoundation/pull/31


Fix spelling:word role rendering verbatim

A line like:

This :spelling:word`foobared` role needs to be fixed.

would be rendered in the output exactly like that, instead of what it should be:

This foobared role needs to be fixed.

Turns out the cause is quite simple: the nodes.Text object from docutils does not hold both the raw text and the "real" text, so it is being passed the raw text, which includes the role name as we see it.
Add a test case to cover this as well.
NOTE: The other (shorter) way to fix this is simply to change this line:
https://github.com/sphinx-contrib/spelling/blob/f4a419ed6341ba929c0007e82eb1652d9ee60d38/sphinxcontrib/spelling/role.py#L16
to
        return super().__call__(role, text, text, lineno, inliner,

But I think that is more hacky. If you disagree, I can edit this commit.
Fixes #188

Updated commit fixes linting issues as well as adds an entry to history.rst.
This project should have a CONTRIBUTING.md file to mention that requirement.


Some sites block requests made with the default user agent

Some sites block requests made with the default user agent used in Python's requests module.
Hm.com, for instance, responds with a 403. So, even though the file is to be found at hm.com/security.txt, an exception is raised.

 But noted, I'll add a feature to change the UA.


Pwa 706 address management

Pull Request Test Coverage Report for Build 1728

4 of 5 (80.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 42.238%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

components/NavDrawer/components/SubHeader/index.jsx
2
3
66.67%

Totals

Change from base Build 1686:
0.04%

Covered Lines:
1513

Relevant Lines:
3445

💛  - Coveralls

Feature was already reviewed and tested multiple times. No additional review will be performed.


Improvement: Don't fix the dependency versions

Description of new feature, or changes
This PR changes the versions of all requirements to greater or equal the existing version number. It currently is very easy to break halo just by installing a newer package version and pkg_config will complain. This unnecessarily restricts the number of environments in which halo can be used.
I don't think there is any reason not to do this and one can probably assume that most packages will be backwards compatible.
If you'd be okay with it I'd propose to get rid of the requirements.txt (and its dev version) and instead just put them in setup.py directly. I can offer to implement this. There is a short discussion about the merits of each approach here:
https://pip.readthedocs.io/en/1.1/requirements.html

Pull Request Test Coverage Report for Build 372

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.231%

Totals

Change from base Build 355:
0.0%

Covered Lines:
289

Relevant Lines:
313

💛  - Coveralls

Yes, this is costing me several hours of now having to sort out some dependency conflicts.  I will probably have to vendor this package and a few of its dependencies until this can be resolved.

To add, I was cranky about this last night so I apologize for that--this is a really lovely package overall which is why I was so determined to use it despite the dependency hell.  Definitely happy to help if I can.

@embray Thanks for supporting this PR. I'm not sure what issues you've faced exactly. Kindly share your experience which might help in this PR.

@embray Thanks for supporting this PR. I'm not sure what issues you've faced exactly. Kindly share your experience which might help in this PR.

Multiple times I had to fix the dependencies manually because of this:
... halo has requirement colorama==0.3.9, but you'll have colorama 0.4.1 which is incompatible
IMHO it's a waste of time to fix this manually every time I have an error like that and this should not be happening.

@rgcr It completely makes sense. However, having a dependency version as colorama>=0.3.9 forces it to upgrade for major version changes also which may break halo. I think we should avoid upgrading to them automatically. I feel we should check for that and make it more strict i.e. colorama>=0.3.9,<=1.0.0. Correct me if I'm missing something or overthinking this.

Logically I'd be on board with not allowing major version jumps. In practice though Python modules seem to really rarely break their major APIs. In many cases (especially with 0.x.x versions) projects just decide that they are now major enough to slap the 1.0.0 version on it.
What I'm trying to say is that I think it is easier to just set the minimum version (or maybe not set it at all if there is no reason). If there is indeed a breaking version change with one of the dependencies, a limitation can be added but I think this would happen less often than the other way around. Another advantage of not fixing the dependency versions is that other projects using halo can just fix the other dependencies themselves in case an error occurs (which is a lot quicker than submitting something upstream and waiting till it propagates).
Let me know if you disagree and I'll add the restriction on major version jumps.
I just rebased this on the latest master.

Can you also upgrade the patch version for halo to 0.0.26? Kindly make the necessary changes and let me know once done.

I updated it to 0.0.27 as it already was on 0.0.26.

@krischer AppVeyor build is failing. Can you take a look into the issue?

@krischer Ping! I wish to merge this quickly. Kindly update me when you fix this.

@krischer Thanks for working on this. I've released it in 0.0.27!


Slow API calls - backport #1262, #1258, #1213, #1229, #1209, #915, #923 and #914 (release-1.17)

Backport #1262, #1258, #1213, #1229, #1209, #915, #923 and #914 to get rid of API call measurement flakes due to single slow API calls breaking the latency SLOs.
I needed to cherry-pick #914 which gets rid of a deprecated APIResponsiveness altogether for a much easier backporting process - for 1.17 release already we do not collect anything of interest therein (take a look at artifacts in testgrid/#gce-cos-1.17-scalability-100 and testgrid/#kubemark-1.17-500).
1.17 test jobs will still require an override file changing the default value of ALLOWED_SLOW_API_CALLS.
/sig scalability
/cc jkaniuk
/cc mm4tt
/cc wojtek-t

Can we not delete the api_responsiveness.go? This measurement still works in older releases and some people may depend on it. TBH, I wouldn't be surprised if some of our release-XX tests depended on it.

Can we not delete the api_responsiveness.go? This measurement still works in older releases and some people may depend on it. TBH, I wouldn't be surprised if some of our release-XX tests depended on it.

The apiserver metrics that api_responsiveness.go leverages are removed in 1.17.0 in https://github.com/kubernetes/kubernetes/pull/83837 (for the record: CHANGELOG-1.17.md), hence it would be even advisable to get rid of that measurement in release-1.17 branch. All summaries of this measurement from 1.17 tests have exactly same useless contents:
{
  "version": "v1",
  "dataItems": null
}

/lgtm
/approve


Tests: Fix flaky test in Swift object store

Signed-off-by: Matej Gera<EMAIL_ADDRESS>

[ ] I added CHANGELOG entry for this change.
[X] Change is not relevant to the end user.

Changes
I have recently noticed an uptick in failed Swift object store test runs on CircleCI. After comparing a number of failed runs, it became clear the issue is occurring in the Swift store test container. The initiation fails 'silently' but the container keeps on running, which shows up in the logs as (excerpt):
Starting supervisord...
Waiting for openstack to become available at http://localhost:5000/v2.0/...
curl: (7) Failed to connect to localhost port 5000: Connection refused
Connection to openstack failed, attempt #1 of 10
curl: (7) Failed to connect to localhost port 5000: Connection refused
Connection to openstack failed, attempt #2 of 10
Openstack API is up, continuing...
Unable to establish connection to http://localhost:35357/v2.0/OS-KSADM/services

This signals that the Keystone service is not always ready on Swift service or endpoint creation step. Since there was no retry mechanism and no failure check, the container kept running, which resulted in the Swift test to fail with:
--- FAIL: TestBucketStore_e2e (0.31s)
    foreach.go:34: GCS found in THANOS_TEST_OBJSTORE_SKIP array. Skipping.
    foreach.go:34: S3 found in THANOS_TEST_OBJSTORE_SKIP array. Skipping.
    foreach.go:34: AZURE found in THANOS_TEST_OBJSTORE_SKIP array. Skipping.
    --- FAIL: TestBucketStore_e2e/swift (0.15s)
        foreach.go:119: foreach.go:119:

             unexpected error: initializing new container: authentication: Response didn't have storage url and auth token

To make this more robust, I have forked the repository for the original Docker image and built / pushed the image with retry mechanism for Swift service creation. This should ensure that even if the Keystone service is not ready, we will retry the initiation.
Although for now I have forked it on my personal GitHub account, it might be worth thinking about copying the files over to Thanos repository and running the setup from there, to ensure we have control over the code in case other issues appear in the future.
Verification
Running the test locally + CI should pass

Nice, the test run actually caught the issue and succeeded:
Starting supervisord...
Waiting for openstack to become available at http://localhost:5000/v2.0/...
curl: (7) Failed to connect to localhost port 5000: Connection refused
Connection to openstack failed, attempt #1 of 10
curl: (7) Failed to connect to localhost port 5000: Connection refused
Connection to openstack failed, attempt #2 of 10
Openstack API is up, continuing...
Unable to establish connection to http://localhost:35357/v2.0/OS-KSADM/services
Creating service failed, attempt #1 of 10
+-------------+----------------------------------+
| Field       | Value                            |
+-------------+----------------------------------+
| description | None                             |
| enabled     | True                             |
| id          | a7219821724f4fe3ab7cf805ed5f6258 |
| name        | swift                            |
| type        | object-store                     |
+-------------+----------------------------------+
Swift service created

But looks like we caught a different flake on E2E :grimacing:

Great work :+1: I feel like we should move this under the thanos-io organization.

Great work +1 I feel like we should move this under the thanos-io organization.

Agreed :+1:. If any of the maintainers would be available to fork it under thanos-io and put this under Thanos org in quay.io, we can update the image right away.

Forked it under https://github.com/thanos-community/docker-swift-onlyone-authv2-keystone, just need to work on the Docker image build + push now

@matej-g Let's update the image and try again. 👍

@matej-g Let's update the image and try again. +1

I still don't see the image under https://quay.io/organization/thanos, that is where it should be right?


Skip to next bundle on predicate failure.

Without this change, if the predicate fails, the code flow just picks the next predicate to check,
when really we want to skip to checking the next bundle.

Have rebased and pushed the change suggested.

Kicked a new build due to the unrelated failure.
Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: Invalid object ID 34 iota=49
[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: Invalid object ID 34 iota=49
[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: Invalid object ID 27 iota=49

Did this not complete?  The build seems to have finished successfully.

Trying a recycle

Reopening


Revert Xbox.cpp nuget package version from previous commit.

@jicailiu,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


#2049 #2050 - Updates for the spo page header set command which contains outdated arguments

This PR contains fixes for the new topicHeader and layout types.

Thank you! We'll get through it asap 🚀

Thank you! We'll get through it asap 🚀

Merged manually. Thank you! 👏

Merged manually. Thank you! 👏


Flask-Fixtures will parse string containing numbers as datetime

I have a simple database, and tried to load a fixture:
[ { "model": "app.models.Devices",
"records": [ { "uuid": "1", "name": "Agent" } ]
}]
it tries to parse the uuid as a datetime object.  It should not.  If I change the value of uuid to "a1" then it is properly a string.
The model is:
class Devices(db.Model):
tablename = 'devices'
name = Column(String, nullable=False)
uuid = Column(String, primary_key=True, nullable=False)

the parameters will be:
[parameters: {'name': 'Agent', 'uuid': datetime.datetime(2016, 10, 1, 0, 0)}]

I encountered the same problem, had to precede the number with letters.
Can you tell me why?

Unfortunately JSONLoader is trying to automatically parse everything into datetime in flask_fixtures/loaders.py:59. I didn't find so far way, how to use custom JSONLoader instead of provided one as workaround for now.

You can try my PR https://github.com/croach/Flask-Fixtures/pull/32 which allows you to disable parsing. Hopefully @croach will merged it soon.

+1, same issue

+1
Same problem. It only happens if you have dateutil installed.
@s7anley Your PR is from 2016, is it going to be merged yet? Anyway, it fixes the problem only partially. In my case I have string fields representing dates and numbers in the same json.
The workaround I found is to use number in those fields, instead of string representing numbers (as they really are in the database). I'll try to come up with yet another solution for this.

Also, if you use yaml instead of json it will work fine.


Shorthand action notations corresponding to stimulus

Feature Request
Stimulus has a wonderful list of shorthand actions. It's gonna be efficient if we could write data-reflex='Post#update' instead of data-reflex='change->Post#update' in stimulus_reflex as well.
Additional context
Here's a list from stimulus

Element
Default Event

a
click

button
click

form
submit

input
change

input type=submit
click

select
change

textarea
change

Hi @namiwang thanks for the suggestion!
Long ago, this was in PR #12 and it was ultimately rejected by @hopsoft here: https://github.com/hopsoft/stimulus_reflex/pull/12#issuecomment-529136521
I've waffled on the shorthand actions, personally. I'm a huge fan of terse markup (I haven't fallen in love with TailwindCSS and #212) but I also think that there's value in being explicit about certain things, especially for newcomers.


Trying to get in touch regarding a security issue

Hey there!
I'd like to report a security issue but cannot find contact instructions on your repository.
If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.
Thank you for your consideration, and I look forward to hearing from you!
(cc @huntr-helper)

Hey @zidingz, thank you. You can reach out to me directly<EMAIL_ADDRESS>I think we're planning on archiving the project at some point but I'll try my best to address the issue.

Thanks for your reply!
As an alternative to archiving, you might consider finding new (co-)maintainers for your
open source software project on https://adoptoposs.org/

And if it'll save you time: https://github.com/sdelements/lets-chat/pull/820


feat(success-state): Added valid control and improvement twig files - FRONT-2808

After the multiselect pr is accepted and merged, in this pr needs to be added the multiselect success state.

Better, but:
i think it's confusing now, client side validation is always enabled but we advertise it only for the basic example where we apply the "bootstrap" custom validation, so...

i would apply the browser default only to one example, you specify in the basic that is bootstrap form validation and in this other example that is the browser default, instead.
we apply the novalidate attribute to the other examples so that it doesn't validate.
in those examples without client validation i would add an action to the form  like onsubmit="return false;", so that the submit button can still be used with no arm.
i expected the script to be included  in the html tab while is not, that's a pity..


Fix electron tests on windows

Running the tests via Electron on Windows was broken because karma-electron-launcher is unmaintained and no longer compatible with the newer electron package.  This uses karma-electron instead, which is maintained and up to date.

To test this locally, npm -- run test --browsers Electron doesn't work on Windows in master, but works in this branch (after blowing node_modules away and running npm install

:+1:


equals function throws error for FieldArray while using with immutable.

https://github.com/erikras/redux-form/blob/84359b3fb5be9f62e030657100ea1ddede4c5ef7/src/structure/immutable/index.js#L41

I've encountered this error (TypeError: b.equals is not a function) after upgrade from version 7.4.0 to version 8.2.6 and it's really hard to find out what is the cause. It seems like some passed property is not immutable, but since the error message is so blunt, I don't know exactly what. Would it be possible to at least return more descriptive error message?


Support protocol command unbonding-release-state

~Blocked by https://github.com/autonity/autonity.py/pull/55~

Resolved in v1.0.0 as aut protocol is-unbonding-released.


cmd/go: go work init . adds ./. instead of .

What version of Go are you using (go version)?

~/src/golang.org/x/exp$ gotip version
go version devel go1.19-6da16b6ad Tue Mar 1 23:49:01 2022 +0000 linux/amd64

Does this issue reproduce with the latest release?
It reproduces with go1.18rc1, yes.
What operating system and processor architecture are you using (go env)?
go env Output
~/src/golang.org/x/exp$ gotip env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/usr/local/google/home/bcmills/.cache/go-build"
GOENV="/usr/local/google/home/bcmills/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/tmp/tmp.dpCQFoAKTg/.gopath/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/tmp/tmp.dpCQFoAKTg/.gopath"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/google/home/bcmills/sdk/gotip"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/google/home/bcmills/sdk/gotip/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel go1.19-6da16b6ad Tue Mar 1 23:49:01 2022 +0000"
GCCGO="/usr/local/google/home/bcmills/bin/gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="c++"
CGO_ENABLED="1"
GOMOD="/usr/local/google/home/bcmills/src/golang.org/x/exp/go.mod"
GOWORK="/usr/local/google/home/bcmills/src/golang.org/x/exp/go.work"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1424670007=/tmp/go-build -gno-record-gcc-switches"

What did you do?
~/src/golang.org/x/exp$ gotip work init .

~/src/golang.org/x/exp$ cat go.work

What did you expect to see?
go 1.19

use .

What did you see instead?
go 1.19

use ./.

CC @matloob

The argument . should trigger modfile.IsDirectoryPath here:
https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/modload/modfile.go;l=805-807;drc=master
But it doesn't: this looks like a bug in IsDirectoryPath, which does not expect to ever need to refer to a module in the same directory (compare #34417).
For Go 1.19, we should probably fix up modfile.IsDirectoryPath. For 1.18, perhaps we should change the condition to if path == "." || modfile.IsDirectoryPath(path).

Reopening for 1.18 backport.


zeromq version

Does this depend on a certain version of zeromq?  I get the following errors:
eps/handler.Tpo -c src/handler.c  -fPIC -DPIC -o .libs/handler.o
src/handler.c: In function 'mongrel2_recv':
src/handler.c:275:5: error: too few arguments to function 'zmq_recv'
zmq_recv(pull_socket->zmq_socket,msg,0);
^
In file included from src/handler.c:14:0:
/usr/local/include/zmq.h:355:16: note: declared here
ZMQ_EXPORT int zmq_recv (void *s, void *buf, size_t len, int flags);
^
src/handler.c: In function 'mongrel2_send':
src/handler.c:308:5: error: too few arguments to function 'zmq_send'
zmq_send(pub_socket->zmq_socket,msg,0);
^
In file included from src/handler.c:14:0:
/usr/local/include/zmq.h:353:16: note: declared here
ZMQ_EXPORT int zmq_send (void *s, const void *buf, size_t len, int flags);
^
Makefile:753: recipe for target 'handler.lo' failed
make: *** [handler.lo] Error 1

Wow, you're trying to use an old project on an old HTTP server! Is Mongrel2 still maintained?
In any case, yes, I think it requires an older zeromq library to work. Version 2? Now there's 3 or 4 out. May not be too hard to modify to work with newer libraries.
Let me know if you get it working, happy to merge the work in.

mongrel2 v1.11.0 as of Thu Dec 31 2015


http url no longer provided - https url only

Describe the bug
ddev start does not provide a http address - only an https address
Successfully started d8test
Project can be reached at https://d8test.ddev.site, https://<IP_ADDRESS>:32780
$ ddev describe
NAME    TYPE     LOCATION                    URL                       STATUS
d8test  drupal8  ~/docker-sites/ddev/d8test  https://d8test.ddev.site  running
Project Information
PHP version:    7.2
URLs:           https://d8test.ddev.site, https://<IP_ADDRESS>:32777
MySQL Credentials
Username:       db
Password:       db
Database name:  db
Host:           db
Port:
MariaDB version 10.2
To connect to mysql from your host machine, use port 32776 on <IP_ADDRESS>.
For example: mysql --host=<IP_ADDRESS> --port=32776 --user=db --password=db --database=db
Other Services
MailHog:        http://d8test.ddev.site:8025
phpMyAdmin:     http://d8test.ddev.site:8036
DDEV ROUTER STATUS: healthy
ssh-auth status: healthy
To Reproduce
Steps to reproduce the behavior:
I had not used ddev on my laptop for a while, so I was asked to update ddev.
$ brew upgrade ddev
$ ddev config
Then I got warnings about cert so I followed instructions
$ sudo apt install libnss3-tools
$ mkcert -install
Using the local CA at "/home/nigel/.local/share/mkcert" ✨
The local CA is now installed in the Firefox and/or Chrome/Chromium trust store (requires browser restart)! 🦊
close browser
$ ddev restart
The Drupal site opens at https://<IP_ADDRESS>:32777, but when I want to log in at http://<IP_ADDRESS>:32777/user/login I get
400 The plain HTTP request was sent to HTTPS port
Expected behavior
On my other Ubuntu machine there is a http url provided. I use this for local development.
Version and configuration information (please complete the following information):

Host computer OS and Version: Ubuntu 18.04.2
Docker version information (use docker version) and insert it here. 18.09.6
ddev version information (use ddev version) 1.9.1
config.yaml contents for the misbehaving project

APIVersion: v1.9.1
name: d8test
type: drupal8
docroot: web
php_version: "7.2"
webserver_type: nginx-fpm
router_http_port: "81"
router_https_port: "443"
xdebug_enabled: false
additional_hostnames: []
additional_fqdns: []
mariadb_version: "10.2"
nfs_mount_enabled: false
provider: default
use_dns_when_possible: true
timezone: ""

Do you have any custom configuration (nginx, php, mysql) in the .ddev folder? no

Thank you

Yeah, if you have configured mkcert, that's the case. If you just remove the mkcert root CAs you'll have the http URLs back.  However, I definitely agree that we have to make a way to provide the http URLs. Thanks for this issue. They were removed because people were seeing just too many URLs and couldn't parse all the output. But we'll get a flag or something to show all URLs.

Thanks
I did $mkcert -uninstall
"The local CA is now uninstalled from the system trust store"
$ ddev stop
power off and reboot laptop
$ ddev start
successfully started - but still only gives https urls
Is there some other action I need to take?

Yeah, sorry. rm -r $(mkcert -CAROOT). ddev looks for those files to see if mkcert is enabled.
Can you help me understand better why http is important to your situation?  (But making a way to provide all URLs is certainly going to happen.)

That worked. Many thanks.
My (newbie) use case was -
when I want to log in at http://<IP_ADDRESS>:32777/user/login I get
400 The plain HTTP request was sent to HTTPS port.
I knew I'd just followed instructions to add mkcert so I guessed it was related.
Now, on ddev start, there are warnings like
mkcert may not be properly installed, please install it, brew install mkcert nss, choco install -y mkcert, etc. and then mkcert -install:
but I guess I just ignore those. The main thing is that the site is working again.
Many thanks

Why are you using the <IP_ADDRESS> port instead of the ddevtest.ddev.site URL? (There seem to be some D8 bugs related to using https on localhost, which I think is probably what bit you.)

No reason. I think it was the first one that hit my eye and then I just fell into the habit.
Thanks for the tip - I'll use the ddev.site url from now on


How to use IncludeColumns

Hi
I have created following function to retrive Invoice object.
        public static RetrieveResponse<MyRow> Retrieve(int InvoiceId)
        {
            RetrieveRequest request = new RetrieveRequest();
            request.EntityId = InvoiceId;
            request.IncludeColumns = new System.Collections.Generic.HashSet<string>();
            request.IncludeColumns.Add(fld.JobMaterial.Name);
            request.IncludeColumns.Add(fld.JobWo.Name);
            request.IncludeColumns.Add(fld.JobJobNo.Name);
            return new MyRetrieveHandler().Process(SqlConnections.NewByKey("Default"), request);
        }

But the object is not have value in the matching property of IncludeColumns.
For example: JobMaterial, JobWo and JobJobNo are null in return object.

Retrieve already returns all colums. If data is null it means columns are null or mapping is wrong

Ahh Sorryyyyyyyyyyyyy
My Mistake, Just realize taht I was checking for wrong Id which has null Data.
Sorry Again...


Added configuration flags and build ServerConfig object

Using twitter-util flags to accept command line arguments
Using circe to read list of ServiceIdentifier(s) from the JSON file
Fixes #70

Current coverage is 69.23%

Merging #71 into master will decrease coverage by -10.77% as of 167c34e

@@            master     #71   diff @@
======================================
  Files           37      23    -14
  Stmts          460     299   -161
  Branches        14      14
  Methods          0       0
======================================
- Hit            368     207   -161
  Partial          0       0
  Missed          92      92

Review entire Coverage Diff as of 167c34e

Powered by Codecov. Updated on successful CI builds.

No plans to merge this; as these changes are already merged as a part of #80


[Feature]:  flags to circumvent interactivity and predefine choices

Description
I'm trying to use opencommit in an automated  workflow so I don't want the questions like push? approve message? add files ? etc.
Suggested Solution
flags to define choices
Alternatives
don't suggest push or add files, just do the message.
Additional Context
No response

hmm.. good idea, do you want to make a PR?

I'm not exactly a software engineer, and I have never written hello world in javascript or typescript. Really sorry.
🫣

@di-sukharev  Can you please re-open this?
I'm really tired for waiting 4 seconds and pressing enter enter enter enter to go through all the steps of approval and pushing.
Thank you for inventing this.


Fixed global allocation issue with PyTorch

Fix for the issue mentioned here.

Fix for the issue mentioned here.

We will take a review of this PR today~ thanks a lot for your contribution


Anchor scroll-into-view not works with scrollContainer

[x] I'm sure this does not appear in the issue list of the repository

基本信息

依赖包名 及 版本<EMAIL_ADDRESS>复现地址: https://www.npmjs.com/package/compute-scroll-into-view

复现步骤
View the usage of compute-scroll-into-view, actions is an Array, should use actions.forEach() to justify elements scrollLeft/Top.

@MisterLuffy 哥哥自己修一下嘛～


Remove explicit SDK version for Windows builds

Fix SDK build error if 10.0.16299.0 is not installed:
 i Build configuration: Debug
 i Build platform: x64
 × Build failed with message 4:10>C:\Users\redactedUser\.nuget\packages\microsoft.ui.xaml\2.8.0\build\Common.targets(10,5): error : Microsoft.UI.Xaml nuget package requires TargetPlatformMinVersion >= 10.0.17763.0 (current project is 16299) [D:\GitHub\redacted\node_modules\react-native-video\windows\ReactNativeVideoCPP\ReactNativeVideoCPP.vcxproj]. Check your build configuration.

See https://github.com/react-native-async-storage/async-storage/pull/810 for a similar fix.
And these

https://github.com/react-native-picker/picker/pull/483
https://github.com/react-native-clipboard/clipboard/pull/177
https://github.com/software-mansion/react-native-screens/pull/1890

Previously, after bringing down package dependencies you'd have to retarget the SDK version for the module project.
This change was tested by applying a patch-package of the vcxproj to an RNW app and doing a clean build. Basically, if it builds, it's good. No runtime effect.

[x] After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.

This is ok for me, thank you for these pull requests. Just a question, does it imply some necessary change on the application side to configure the sdk ? I think no, but I am asking as I am in doubt !

This is ok for me, thank you for these pull requests. Just a question, does it imply some necessary change on the application side to configure the sdk ? I think no, but I am asking as I am in doubt !

Nope, no change needed on the application side. If the app has an SDK version specified (which it absolutely will have) then this module will match that SDK version with this change. Previously it would fight with the app's specified SDK and you'd need to have both SDK versions installed in order to build. Which could have been transparent if you happened to have multiple SDKs installed, or would be a nuisance to prompt you to go install an SDK version you didn't really need (and also be a drain on your disk space 😉).


[UI] shifted the create pattern button to custom-toolbar:

Signed-off-by: asubedy<EMAIL_ADDRESS>Description
The Create Pattern button now + is shifted to table top with custom toolbars.
This PR fixes #4958
Notes for Reviewers
https://user-images.githubusercontent.com/51183483/150524666-12a4ca9a-29be-488b-8439-e5f470260a28.mov
Signed commits

[X] Yes, I signed my commits.

Codecov Report

Merging #4973 (46350b7) into master (f34d398) will decrease coverage by 6.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4973      +/-   ##
==========================================
- Coverage   32.47%   25.87%   -6.61%
==========================================
  Files          61       61
  Lines        5028     5028
==========================================
- Hits         1633     1301     -332
- Misses       2991     3433     +442
+ Partials      404      294     -110

Flag
Coverage Δ

gointegrationtests
?

unittests
25.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/start.go
1.92% <0.00%> (-54.81%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
2.50% <0.00%> (-47.50%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
1.14% <0.00%> (-43.68%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.05% <0.00%> (-34.74%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
1.78% <0.00%> (-23.22%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.03% <0.00%> (-23.03%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
3.29% <0.00%> (-20.88%)
:arrow_down:

mesheryctl/internal/cli/root/system/dashboard.go
0.00% <0.00%> (-15.88%)
:arrow_down:

mesheryctl/pkg/utils/healthcheck.go
11.65% <0.00%> (-5.83%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f34d398...46350b7. Read the comment docs.

@asubedy great changes, just shift it to the end(right-last) icon in the toolbar.
LGTM 🥇

You mean place it after the url upload button?

@asubedy great changes, just shift it to the end(right-last) icon in the toolbar.
LGTM 1st_place_medal

You mean place it after the url upload button?

yes

Position of the Create (+) button after the latest commit.

Cool :+1:

I feel like adding this to the toolbar is making the toolbar really crowded. I was thinking if we could implement something like this maybe??

Figma link: https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI?node-id=4189%3A21394
@leecalcote thoughts??

My respect for UXers increases every time I try to do something on Figma.😅

@warunicorn19 yes that's what exactly we discussed on Mesehry Dev call, after shifting this btn we will have it like the above(Figma). Thanks for the Figma design this will help contributors in implementation.

No problem. 😅

You guys are tracking well here. There are couple other considerations to be made. I'm not sure that we should make them here and now, actually, but things like:

the create button experience being inconsistent on other UIs
the buttons and their purpose being two close together and too different in purpose. The + button actions are logically grouped, but next to a search and a column view button that are themselves related, but not related to actions under +.

There's more thought (in general) needed here and across the rest of the UIs. Collectively, we'll be spending much time in Figma. For now, for this PR, we do want to have the rounded rectangle button "+ Create New Pattern" above the table - - following suit with the other UIs.

Yes makes sense, Also another thing is, is there an option to create applications or filters? I don't see a button.

Yes makes sense, Also another thing is, is there an option to create applications or filters? I don't see a button.

No for filters we are not yet configuring the wasm binaries for the UI, for the apps it's just not there : )

I feel like adding this to the toolbar is making the toolbar really crowded. I was thinking if we could implement something like this maybe??  Figma link: https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI?node-id=4189%3A21394
@leecalcote thoughts??

This is what I was trying to do on the Sigma you beat me to it 😆.

You guys are tracking well here. There are couple other considerations to be made. I'm not sure that we should make them here and now, actually, but things like:

the create button experience being inconsistent on other UIs
the buttons and their purpose being two close together and too different in purpose. The + button actions are logically grouped, but next to a search and a column view button that are themselves related, but not related to actions under +.

There's more thought (in general) needed here and across the rest of the UIs. Collectively, we'll be spending much time in Figma. For now, for this PR, we do want to have the rounded rectangle button "+ Create New Pattern" above the table - - following suit with the other UIs.

So should I revert the changes made here, and instead only make the change where the rounded blue button with + Create Pattern text is on top of the table?

@asubedy the changes here are good, but yes we need the above as stated by @warunicorn19 and @leecalcote, if you want you can continue making changes to the same pr or could get this merge and track the above(reviews) one as a separate issue.

This is the current state of the patterns page. I have moved the +  Create Button to top left.


update transferred repository links

:train: :sparkles:

FYI did you guys update the links on the website?

nice catch 🐈

@brodybits oops, no we haven't haha


disable yolo for 0.3.1

failing for x86 packaging pipeline

can you please create a task to add this back later?


Shift of exogenous data

🚀 Feature Request
Add class ExogShiftTransform for automatic shift of exogenous data based on lag transform.
Proposal
class ExogShiftTransform(IrreversibleTransform, FutureMixin):
    def __init__(self, lags: Union[int, Literal["auto"]], horizon: Optional[int] = None):
        pass

   def _fit(self, df: pd.DataFrame) -> "ExogShiftTransform":
       pass

   def _transform(self, df: pd.DataFrame) -> pd.DataFrame:
       pass

lags: int -- use passed value to shift all exog columns
lags="auto" -- compute the size of the shift automatically. In this case, estimate for each series the minimal number of steps required to cover all horizon. It may be possible that each exog series will have its own shift size. Computation may be performed using the last available date of the exog variable and the prediction horizon.

When lags="auto" parameter horizon is mandatory.
Name shifted columns in format {exog_name}_shift_{exog_shift_size}.
Test cases

Test all necessary parameters set when initialising the transform.
Test that names for transformed data are correct.
Test all exog data correctly shifted for both modes.
Test that transform works within Pipeline for both modes.
Add transform to inference tests.

Additional context
No response

It seems like this task is relevant here.

It seems like the task #946 is relevant here.


No new release since 2018

Hi @Tanganelli! You rock! Could you make a new release that contains the latest and greatest contributions for CoAPthon3 since 2018?
Much appreciated!

Would appreciate a new version alot. Since #29 iam forced to install a patch at every system update. Please release a new version.

New release published.


Centralize some property and fix Extensions.Config

M.T.E.Config wasn't getting published because were manually managing IsPackable on a per-project basis.


New fields in Dref application form when type is imminent

Addresses:

#698

Changes

Detailed list or prose of changes
Breaking changes
Changes to configurations

This PR doesn't introduce:

[x] typos
[x] conflict markers
[x] unwanted comments
[x] temporary files, auto-generated files or secret keys
[x] console.log meant for debugging
[x] codegen errors

Please update the PR description to reflect what changes have been made


update to zend-expressive 1.0.0

Can be merged if prooph/psr7-middleware 0.1.0 has been released.

[x] update dependencies
[x] move config files to default location
[x] update command routes for prooph PSR-7 middleware
[x] update build scripts
[x] update command handler

fantastic! :+1:

@codeliner can you add prooph/psr7-middlewar to packagist an rerun the tests, please?

@sandrokeil does this PR also solve https://github.com/prooph/proophessor-do/issues/11 ?

great job!


stats: maintenance mode stat

@lyft/network-team
Expose stat for requests that are shed due to maintenance mode.

lgtm, few minor comments

+1


Update quickstart-install-connect-red-hat.md for RHEL8.8 support

Updating doc to reflect RHEL8.8 support (confirmed Amit)

This should be an internal PR, and affects a lot more articles. I'll create that.

Addressed in https://github.com/MicrosoftDocs/sql-docs-pr/pull/27009 and https://github.com/MicrosoftDocs/sql-docs-pr/pull/27392.


Support using Angular CDK & Material v16 in Angular v18

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
Any Angular v17 version.
Description
The peerDependencies sections in the package.json file for Angular CDK v16.2.14 and Angular Material v16.2.14 specify only @angular v16 or v17. However, there is declared official support for running Material M2, even in Angular v18. To allow it, it's necessary to add ^18.0.0 for all Angular packages in the peerDependencies sections of Angular CDK v16 and Angular Material v16.
// Angular CDK 16.2.14
"peerDependencies": {
    "@angular/core": "^16.0.0 || ^17.0.0",
    "@angular/common": "^16.0.0 || ^17.0.0",
    "rxjs": "^6.5.3 || ^7.4.0"
}

// Angular Material 16.2.14
"peerDependencies": {
    "@angular/animations": "^16.0.0 || ^17.0.0",
    "@angular/cdk": "16.2.14",
    "@angular/core": "^16.0.0 || ^17.0.0",
    "@angular/common": "^16.0.0 || ^17.0.0",
    "@angular/forms": "^16.0.0 || ^17.0.0",
    "@angular/platform-browser": "^16.0.0 || ^17.0.0",
    "rxjs": "^6.5.3 || ^7.4.0"
}

Using the --legacy-peer-deps flag is not the ideal solution because it also affects the installation of all other packages.
Expected Behavior
Allow using Angular CDK v16 and Angular Material v16 together with Angular v18.
Actual Behavior
When running the npm i command (Angular v18 environment), the following resolve problem appears:
Could not resolve dependency:
npm error peer<EMAIL_ADDRESS>|| ^17.0.0" from<EMAIL_ADDRESS>npm error node_modules/@angular/cdk
npm error<EMAIL_ADDRESS>from the root project

Environment

Angular: 18.1.0
CDK/Material: 16.2.14
Browser(s): Chrome, FF
Operating System: Windows, macOS, Ubuntu

The current setup is consistent with our version policy. Supporting a wider version range would be more maintenance both on the Material/CDK side and on the framework's side.

@crisbeto But Angular v18 was declared the last version with official support for running Material M2, right? The change from M2 to M3 was introduced in Angular v17.2, and the official version policy should cover Angular v18. What is the version policy you are talking about?

M2 is supported and is the default in v18. We introduced M3 as an opt-in feature.

@crisbeto Are we talking about the same things? I am talking about using all those MatLegacy____Module modules. I checked the timeline in detail, and it's the fact that they were introduced in Angular v15. Does it mean that Angular v16 and v17 covered the maintenance range of the two major versions, and Angular v18 is already out of it?

Yes, the legacy modules were deprecated for two major versions so we removed them for v18.

@crisbeto sorry for reopening this thread, but you've claimed that we would be able to use Material v16 with Angular v18 during v17 launch. Thats really missleading, we were planning to use legacy components with angular v18
Here is the source of that claim ->
We deprecated legacy components in v15 to be removed in v17. Even though they’ll not be part of the Angular Material v17 package, you can still update your apps to Angular v17 and use the v16 Angular Material package. This will be an option until v18, after which Angular Material v16 will no longer be compatible with newer versions of Angular.
https://blog.angular.dev/introducing-angular-v17-4d7033312e4b


Add ptrace for non-apple BSDs

So yesterday I did a PR for ptrace for apple, I've now gone through the ptrace header files for the other BSDs supported by libc and added ptrace + constants for all of them.
Given the lack of ptrace in any of them I don't know if the test has to be changed at all for the new functions so I'll tackle any CI errors that come up if and as they appear.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit 57b136a2de32e01acf73b6c4a1c3125b58b867b1 has been approved by alexcrichton

:hourglass: Testing commit 57b136a2de32e01acf73b6c4a1c3125b58b867b1 with merge dd8f56ed57b628fa69872b1f8943a56184c32904...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing dd8f56ed57b628fa69872b1f8943a56184c32904 to master...


Normalizing Floats

Hi,
I've had a read of many open issues here and it seems that having non-string form values is OK! I have some form values that are floating point numbers. This works fine for initial display but I am struggling with how to handle this for input.
The first thing I did was to make a normalizer (using v5 at the moment).
  form: formReducer.normalize({
    SmallMolecule: {
      molecular_mass: value => value && parseFloat(value)
    }
  })

This ensures that the value always remains a float so that dirty is appropriate should 123.45 become 123.46 then back to 123.45  for example.
I was pleased with that, but then I hit a roadblock. What if there are no decimal places? Say, 123. It becomes impossible to enter the decimal point in the field because when you type it, normalize immediately removes it.
What is the recommended workaround for this? Am I simply forced to using strings for float input fields?
I am wondering if it might be nice to have a value and a displayValue. Nearly always displayValue would simply reference value, but when needed, it could be used to get around situations like this (normalize would set the displayValue to 123. and the value to 123. displayValues could then be reset at the users discretion (e.g. on submit). This isn't a well thought out idea so there might be a huge flaw for internal reasons that I am not familiar with.
Finally, great work on redux-forms, other than this problem I am finding it the perfect way to do forms in React+Redux. Before I was always frustrated that form libraries would want to handle both state and rendering which never made sense to me.
Cheers

That is pretty funny. Isn't programming fun? Seems like you'd have the same problem with an empty string going to NaN, right?
You will either have to use strings as your input values, or special case all the weird edge cases in your normalizer. Something like this (untested):
value =>
  !value || !value.length || value[value.length - 1] === '.' ?
    value : parseFloat(value)

Empty string going to NaN isn't such a big problem as the initialValue would have been undefined in my case so that's easy to special case and it doesn't have the same problem with data entry.
I had considered the special casing of course, but in the end it doesn't really buy you anything over strings because on form submission you still have to process the float values as they could be strings (if the field was blurred when at 123.. Also, if you have any fields which interrelate, it's no longer possible to rely on the type of the float. e.g. if you have a validator that checks if x > y. Now that validator would also have to handle strings.
displayValue idea was no good?

In my vision, normalization shouldn't be used to accommodate the display of any values but to coerce complex values into the store. So, what does this imply?

Store your values as floats
Implement value constraints using the normalizer (but keep floats)
Implement the mask at the component level, not the normalizer

@ooflorent I completely agree with this usage pattern, this is actually what I wanted; To be able to coerce values into the store.
However, I don't think there is a mechanism in redux-forms right now that can cope with the example I laid out above. Either you only coerce when the value is valid or not in some intermediate state (and otherwise leave it as a string in the store) or you use a string. I would welcome an example of how to properly use normalisation in that use case.
Cheers

I think the only missing part is a masked input component. Here is a dummy component to achieve this. It bypasses Redux Form normalizer because in this case it would be overkill.
class MaskedInput extends Component {
  constructor(props) {
    super()

    this.handleBlur = this.handleBlur.bind(this)
    this.handleChange = this.handleChange.bind(this)
    this.state = {
      value: props.value,
    }
  }

  componentWillReceiveProps(nextProps) {
    this.setState({
      value: nextProps.value,
    })
  }

  handleBlur() {
    if (this.props.onBlur) {
      // Swallow the event to prevent Redux Form from
      // extracting the form value
      this.props.onBlur()
    }
  }

  handleChange(event) {
    const value = event.target.value

    // Update the internal state to trigger a re-render
    // using the formatted value
    this.setState({value})

    if (this.props.onChange) {
      // Notify the normalized value
      this.props.onChange(
        this.props.normalize(value)
      )
    }
  }

  render() {
    return (
      <input
        {...this.props}
        value={this.props.format(this.state.value)}
        onBlur={this.handleBlur}
        onChange={this.handleChange}
      />
    )
  }
}

MaskedInput.defaultProps = {
  format: x => x,
  normalize: x => x,
}

MaskedInput.propTypes = {
  format: PropTypes.func.isRequired,
  normalize: PropTypes.func.isRequired,
  value: PropTypes.any,
  onBlur: PropTypes.func,
  onChange: PropTypes.func,
}

I went with the normalizing solution. Keeping the whole thing as a string and dealing with the edge cases:
export const onlyDecimal = (value) => {
  value = value
    .replace(/[^0-9.]/g, '') // Remove all chars except numbers and .
    .replace(/^0+/, '') // Remove any leading 0s

  // Create an array with sections split by .
  const sections = value.split('.')

  // If numbers exist after first .
  if (sections[1]) {
    // Join first two sections and truncate end section to length 2
    return sections[0] + '.' + sections[1].slice(0, 2)
  // If original value had a decimal place at the end, add it back
  } else if (value.indexOf('.') !== -1) {
    return sections[0] + '.'
  // Otherwise, return original value
  } else {
    return value
  }
}

And here are all my passing tests, just so you know!
describe('(Normalizer) onlyDecimal', () => {
  it('Returns a string with only numbers', () => {
    let expected = '123456'
    let actual = n.onlyDecimal('123456')
    expect(actual).to.equal(expected)

    expected = '1234'
    actual = n.onlyDecimal('1234a')
    expect(actual).to.equal(expected)

    expected = '1234'
    actual = n.onlyDecimal('1!2!3!4')
    expect(actual).to.equal(expected)

    expected = ''
    actual = n.onlyDecimal('ab')
    expect(actual).to.equal(expected)
  })

  it('Allows for one decimal symbol', () => {
    let expected = '10.'
    let actual = n.onlyDecimal('10.')
    expect(actual).to.equal(expected)

    expected = '10.0'
    actual = n.onlyDecimal('10.0')
    expect(actual).to.equal(expected)

    expected = '1234.56'
    actual = n.onlyDecimal('1234.56')
    expect(actual).to.equal(expected)

    expected = '1234.56'
    actual = n.onlyDecimal('1234.56.12')
    expect(actual).to.equal(expected)

    expected = '1.1'
    actual = n.onlyDecimal('<IP_ADDRESS>.1.1')
    expect(actual).to.equal(expected)
  })

  it('Truncates to 2 decimal places', () => {
    let expected = '10.00'
    let actual = n.onlyDecimal('10.000')
    expect(actual).to.equal(expected)

    expected = '10.12'
    actual = n.onlyDecimal('10.12345')
    expect(actual).to.equal(expected)

    expected = '10.12'
    actual = n.onlyDecimal('10.123<IP_ADDRESS>')
    expect(actual).to.equal(expected)
  })

  it('Removes leading zeros', () => {
    let expected = '123456'
    let actual = n.onlyDecimal('0123456')
    expect(actual).to.equal(expected)

    expected = '123456'
    actual = n.onlyDecimal('00000123456')
    expect(actual).to.equal(expected)

    expected = ''
    actual = n.onlyDecimal('0')
    expect(actual).to.equal(expected)
  })
})

I used another solution:
In a normal text input, compare past value and current value in handleChange. If a comma is added at the end of the string, skip sending onChange event and edit input value manually (have a state value that is passed as a prop to input). The rest are handled by format and parse props.


Decorators, class properties

I see this:

It looks like the opening  ' isn't seen as a delimiter?

Decorators don't appear to be supported (apologies if this is syntastic or something else!). I've made a little screen cap showing this and the original issue

I missed this syntax (class default property)
Will figure out late.

@bmcorser base on latest ES6 draft.
I don't think this is valid class syntax.
Even if babel support this kind of syntax.

Decorator is not in todo list now.
I don't want include future stuff in here.
But might have another project to add future spec support.

@othree Can you link to the appropriate part of the ES6 docs where you read about class default properties? I'm assuming the "proper" way to do it would be something like:
class Thing{
  constructor () {
    this.defaultProperty = 'abc';
  }
}

However, that would rely on developers (as far as I understand ES6 classes) faithfully calling super on subclass constructors. But that's not our problem :)
Fair enough on decorator syntax; that's your discretion.

ref: http://wiki.ecmascript.org/doku.php?id=harmony:specification_drafts#april_14_2015_rev_38_final_draft
14.5 Class Definitions
ClassDeclaration[Yield, Default] :
    class BindingIdentifier[?Yield] ClassTail[?Yield]
    [+Default] class ClassTail[?Yield]

ClassTail[Yield] :
    ClassHeritage[?Yield]opt {ClassBody[?Yield]opt}

ClassBody[Yield] :
    ClassElementList[?Yield]

ClassElementList[Yield] :
    ClassElement[?Yield]
    ClassElementList[?Yield] ClassElement[?Yield]

ClassElement[Yield] :
    MethodDefinition[?Yield]

14.3 Method Definitions Syntax
MethodDefinition[Yield] :
    PropertyName[?Yield] (StrictFormalParameters) {FunctionBody}
    GeneratorMethod[?Yield]
    get PropertyName[?Yield] ( ) { FunctionBody }
    set PropertyName[?Yield] ( PropertySetParameterList ) { FunctionBody }

The proper way you assume is correct as I know.
For future spec, my base line is appear in spec.
I think create another project to do the future spec support is a good way to keep yajs stable.
Maybe I will start soon for type and decorator.

That's great. I'll pass on to where it was I got that syntax from.
Closing this :+1:

https://github.com/othree/es.next.syntax.vim

I found the proposal of class property initializer
https://gist.github.com/jeffmo/054df782c05639da2adb
Will move to es.next.syntax

Nice one. It seems pretty early in the development; they are calling it Stage 0

Stage 0 is called "Strawman", it has no criteria for inclusion so not sure what the likelihood of it going in is ...

https://docs.google.com/document/d/1QbEE0BsO4lvl7NFTn5WXWeiEIBfaVUF7Dk0hpPpPDzU/edit

Thanks, I know the TC39 process.
My idea is if there is a transpiler supports the new syntax.
And if this syntax might in of ES.Next.
I will try support it in es.next.syntax.vim.
If it comes to stage 3 or browsers are start to support it.
I will move it to yajs.vim.


'arithmetic operation overflowed' when reading "-0" as JSON

Running this program:
extern crate serde_json;
fn main() {
    serde_json::from_str::<serde_json::Value>("-0").unwrap();
}

causes:
thread '<main>' panicked at 'arithmetic operation overflowed', [...]/.cargo/registry/src/github.com-88ac128001ac3a9a/serde_json-0.6.0/src/de.rs:289

whereas I expected it to run to completion successfully with no output.

See #35

This was closed in #35.


Background database deletion

Overview

Allow to permanently delete those soft-deleted databases under background. In general, the soft-deleted database can be kept from several hours to several days. Later, they need to be deleted to reclaim disk space. So one criteria can be specified to decide how to select which soft-deleted databases to be deleted.
Testing recommendations

make check apps=fabric tests=crud_test_,scheduled_db_remove_error_test_
INFO:  Cover compiling /Users/jiangph/fdb/fdb-dbcore-0413/fdb-dbcore/src/couchdb/src/fabric
======================== EUnit ========================
Test scheduled database remove operations
  fabric2_db_crud_tests:77: scheduled_db_remove_error_test_ (scheduled_remove_deleted_dbs_with_error)...[0.026 s] ok
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
  [done in 0.082 s]
Test database CRUD operations
  fabric2_db_crud_tests:37: crud_test_ (create_db)...[0.031 s] ok
  fabric2_db_crud_tests:38: crud_test_ (open_db)...[0.015 s] ok
  fabric2_db_crud_tests:39: crud_test_ (delete_db)...[0.023 s] ok
  fabric2_db_crud_tests:40: crud_test_ (recreate_db)...[0.058 s] ok
  fabric2_db_crud_tests:41: crud_test_ (undelete_db)...[0.039 s] ok
  fabric2_db_crud_tests:42: crud_test_ (remove_deleted_db)...[0.044 s] ok
  fabric2_db_crud_tests:43: crud_test_ (scheduled_remove_deleted_db)...[1.312 s] ok
  fabric2_db_crud_tests:44: crud_test_ (scheduled_remove_deleted_dbs)...[2.016 s] ok
  fabric2_db_crud_tests:45: crud_test_ (old_db_handle)...[0.163 s] ok
  fabric2_db_crud_tests:46: crud_test_ (list_dbs)...[0.024 s] ok
  fabric2_db_crud_tests:47: crud_test_ (list_dbs_user_fun)...[0.014 s] ok
  fabric2_db_crud_tests:48: crud_test_ (list_dbs_user_fun_partial)...ok
  fabric2_db_crud_tests:49: crud_test_ (list_dbs_info)...[0.036 s] ok
  fabric2_db_crud_tests:50: crud_test_ (list_dbs_info_partial)...ok
  fabric2_db_crud_tests:51: crud_test_ (list_dbs_tx_too_old)...[0.076 s] ok
  fabric2_db_crud_tests:52: crud_test_ (list_dbs_info_tx_too_old)...[0.772 s] ok
  fabric2_db_crud_tests:53: crud_test_ (list_deleted_dbs_info)...[0.038 s] ok
  fabric2_db_crud_tests:54: crud_test_ (list_deleted_dbs_info_user_fun)...[0.026 s] ok
  fabric2_db_crud_tests:55: crud_test_ (list_deleted_dbs_info_user_fun_partial)...ok
  fabric2_db_crud_tests:56: crud_test_ (list_deleted_dbs_info_with_timestamps)...[2.284 s] ok
  fabric2_db_crud_tests:57: crud_test_ (get_info_wait_retry_on_tx_too_old)...[0.081 s] ok
  fabric2_db_crud_tests:58: crud_test_ (get_info_wait_retry_on_tx_abort)...[0.080 s] ok
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
  [done in 8.509 s]
=======================================================
  All 23 tests passed.
Cover analysis: /Users/jiangph/fdb/fdb-dbcore-0413/fdb-dbcore/src/couchdb/src/fabric/.eunit/index.html

Related Issues or Pull Requests

Checklist

[x] Code is written and works correctly
[x] Changes are covered by tests
[ ] Any new configurable parameters are documented in rel/overlay/etc/default.ini
[ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

@jiangphcn look great, Peng Hui. Nice work! See a few minor updates and a simplification in regards to batching and it should be good to go.

thanks @nickva so much for your kindly support and review!


cigien: Watch avrilklia.com

cigien requests the watch of the watch_keyword avrilklia\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

avrilklia\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


How to translate Texture/Image for RG?

I tried to edit AutoTranslatorConfig.ini and enable texture translation and dump:
[Texture]
TextureDirectory=Translation\{Lang}\Texture
EnableTextureTranslation=True
EnableTextureDumping=True
EnableTextureToggling=False
EnableTextureScanOnSceneLoad=True

After running RG, I cannot find images like your dumped file sp_rg_help_00_00 [1E94572625-1B4D71021D].png in my Texture folder but some other files doesn't contain any text to be translated.
I also tried to modify images files from RG-Translation/Image Source Files/OriginalFiles/ and copy them into my Texture folder. However the game didn't show my modification.
I am using:
[ScrewThisNoise][Illusion] RoomGirl (ROOMガール) BetterRepack R1.3
BepInEx.IL2CPP.dll 6.0.0 pre-1
XUnity.AutoTranslator.Plugin.BepInEx-IL2CPP.dll 5.1.0
XUnity.AutoTranslator.Plugin.Core.dll 5.1.0

Please coordinate with other translators in Discord server to avoid two people working in the same thing causing waste of effort, which is specially bad for a game with few modders like RG: https://discord.gg/illusionsoft
For your issue, take a look in the config file from this repository in config folder. BetterRepack 1.3 is using an older version of AutoTranslatorConfig.ini that is a way different from the current version which include texture translation.

Thank you. It works.
I am trying to translate images into Chinese. It seems nobody has worked on it.
It is my first time using Discord so I couldn't find the Translation channel.
I think it is fine because I was the only one did HS2 image translation into Chinese.


Support waitable objects on Windows 10

There is an (undocumented) NtAssociateWaitCompletionPacket syscall that can be used for the purpose.

Do you perhaps know of any unofficial documentation on NtAssociateWaitCompletionPacket or maybe even a project using it?

ProcessHacker has a function prototype but I don’t know of anyone else using it.  Fortunately, the argument names should be fairly self-explanatory.

I'd rather avoid using a system call that's entirely undocumented (this issue is the second result on Google when I look up the function name). Is there a way to work this into wepoll?

@notgull Maybe?  wepoll already uses undocumented Windows internals so this would not be new.

I'm honestly not a big fan of that either, since it has led to breakages on certain platforms (e.g. Wine) and could very easily break with no warning on future versions of Windows. However at this point the only alternatives are explicitly deprecated (WSAAsyncSelect) or incompatible with the current API (I/O Completion Ports), so I'm unsure as to what it would be replaced with.
What I'm trying to say is that we already rely on enough unstable behavior, and there's no need to build onto that house of cards more than we already do.

I'm honestly not a big fan of that either, since it has led to breakages on certain platforms (e.g. Wine) and could very easily break with no warning on future versions of Windows.

libuv already relies on the same behavior, so such breakage would be noticed pretty quickly.

However at this point the only alternatives are explicitly deprecated (WSAAsyncSelect) or incompatible with the current API (I/O Completion Ports), so I'm unsure as to what it would be replaced with.

NtAssociateWaitCompletionPacket can only be used with I/O completion ports.  Its purpose is to support objects that IOCP does not.
One alternative would be to use the Windows thread pool API, but I doubt that would be compatible.

As of smol-rs/polling#98, waitable handles can be waited on in polling. It shouldn't be too hard to expose this in async-io.


Set PDF to be Read-Only

I'd like to set a jsPDF-created PDF file as "read-only" (like this one). Can this be done via the setProperties() method? If so, what is the proper name for that attribute and acceptable values?
Thanks,
Patrick

It is not possible yet. ReadOnly is possible if you set security handlers to the pdf. I started to implement it #1458. For this, even text has to be changed to streams. But current jspdf code doesnt transforms text to streams...

Duplicate of #1344


Release packaging of javaagent needs to include asm file

The current zip that is on the release tab for the agent does not contain the asm directory and files.  As such, the javaagent will not run.  The zip needs to be updated to include the asm files

Any chance this is going to be fixed? At the moment this means the whole package doesn't work.

@ind1go apologies for the delay. There is now a 1.0.1 release zip containing all the necessary jars. I will update the deployment instructions in due course.

Thank you!

PR https://github.com/RuntimeTools/javametrics/pull/63 creates the release zip for future releases.
Closing this.


Improve sending GAP [master]

Improvement sending only GAP for sequence number greater/equal than history minimum sequence number. In other case, force to send a piggyback heartbeat.

Build status:

Linux
Mac
Windows


skip onboarding when user registers for an auction

right now when a logged out user taps the bid or register, we pop the general signup/login CTA. After the user signs up with email or FB/Twitter, we should skip onboarding. On the phone this means bypassing the native onboarding flow and for ipad it means bypassing the embedded force onboarding. Instead, we should shoot them directly to the registration screen shown here

@alloy or @1aurabrown can you give a brief estimate on the difficulty level of this?

Is this a native screen we already have or is the question about creating the view?

After the user signs up with email or FB/Twitter, we should skip onboarding.

I’m not sure I follow this. Should this have been like so?

right now when a logged out user taps the sign up bid button

we dont need to create a new view, we just need to skip anything that happens after initial account creation and dump them into this form https://staging.artsy.net/auction-registration/watermill-summer-benefit-and-live-auction-2015

To summarise private discussion, this behaviour is only triggered when the user taps the bid or register to bid buttons.

I don’t foresee any complications, this should probably take 3-4 hours.

@katarinabatina Just to be sure, I assume this one is high-ish priority, right?

@alloy yes

I put in a switch to skip the onboarding flow when the users hits "Bid" or "Register to Bid." I was not able to dump the user directly into the "Register to Bid" form after signing up. The logic to achieve happens on Martsy.
If we'd like to make this flow directly into the Register To Bid form, Martsy would have to handle this.
What it does show you is this, and from there you tap Register To Bid to see the form

I tried to look at the flow on Martsy, but the flow appears to be broken as it shows you the Register To Bid form before asking you to signup/login, for which I filed this ticket: https://github.com/artsy/microgravity/issues/984

We currently cannot skip the onboarding on the iPad, we do have a way to tell if the signup request is coming from a Register To Bid link in a Force view. To be able to do this, I've filed the following request with Force: https://github.com/artsy/force/issues/3211

@anipetrov Can you keep track of https://github.com/artsy/microgravity/issues/984 & https://github.com/artsy/force/issues/3211 with regards to the upcoming auction season (if they’re deemed important enough)?

I got it @alloy


Add deterministic option into convolution_2d and deconvolution_2d

Some of convolution algorithm cuDNN provides are non-deterministic.
So outputs of current chainer convolution and deconvolution can be non-deterministic when cuDNN is available.
I think this might make trouble when you want to do reproducible experiments.
This PR add deterministic option into these two functions and links.
If True, the functions force cuDNN to use deterministic algorithms.

Could you add test cases for this option where we call the function twice and compare results.

We had reverted and resent this PR as #1321. So this feature is not merged yet.


More annoying formatting changes

Extracted from https://github.com/nix-rust/nix/pull/1862

bors r+


Inverted time scale functionality added - Issue #3279

This fixes issue #3279 where when scale type is time and the ticks option has reverse as true, it wouldn't reverse the scale. I have combined various tests such as reversing when distribution is linear and series too.

I'm wondering if we actually need the reverse lookup table. Would it instead be possible to do something like pos = isReverse ? scaleWidth - pos : pos;? I haven't looked at this closely enough to know if that's possible or not, but it might be much easier

@priteshkadiwala thank for your contribution, we merged #5927 instead which contain no code duplication.


Fix out-of-space for build

Issue #, if available:
Description of changes:

Fix out-of-space build issue from https://github.com/aws/eks-distro/pull/1926
Intellij auto fixed whitespaces

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/lgtm

/lgtm