Micro-fixes

First fix is for the Youtube block
If the related videos option is not checked the rel argument is not added at all and Youtube assumes its value is 1 and show the related videos... It's a bit backward.
This micro fix is to ensure the rel argument is always added
Second Fix is to order recommended countries alphabetically during install
During install, in advanced options, the list of countries is divided in 2: recommended countries and other countries.
The list of recommended countries is organized by Punic in order of the number of people speaking that language which doesn't make much sense in the context of a dropdown during install.
This micro-fix ensures the list is ordered alphabetically by country name

Experience taught me it's better to create different pull request for each issue you're trying to fix
You can't sort array of strings that can multibyte strings with asort: you should use \Punic\Comparer
The Country list is meant to suggest the most likely countries for the selected language (ordered by the number of people speaking that language)

Yes I agree but those are really tiny and I suck at Git so... Please allow it just this time
When I tested it worked just fine. it's really just an array of strings so it should be fine but I'll check with Punic
3- I agree but from a usability point of view it sucks. I selected English so I had a list of maybe 30 recommended countries. How am I supposed to know where Morocco ranks as opposed to Danemark? Alphabetically, in that context, makes more sense I think.

When I tested it worked just fine. it's really just an array of strings so it should be fine

Did you test it with multibyte strings (like for instance Japanese or Arabic strings)?

The best approach should be to specify a minimum % of population speaking a language in getCountriesForLanguage. For instance

$territories = \Punic\Territory::getTerritoriesForLanguage($languageCode, 70);

would return the Countries where a language is spoken by at least 70% of population

oh no it's nothing like that, it's just an array of country codes for keys and country names for values. They're all in latin character. Like array('JP' => 'Japan', 'GB' => 'United Kingdom')
Do you think on a Japanese system, for instance, they would show up in Japanese?

oh no it's nothing like that, it's just an array of country codes for keys and country names for values. They're all in latin character. Like array('JP' => 'Japan', 'GB' => 'United Kingdom')

Here's what I see if the current install language is Greek:

https://github.com/concrete5/concrete5/pull/5398 could be mitigate this issue (for instance, for English the list of Countries is reduced from about 140 to about 80).

And that's why you're the go-to guy when it comes to internationalization :)
OK so what do you think I should do? Maybe I should delete this pull request, start a new one just for the Youtube Block and leave the rest alone? Maybe you're in a better position to deal with the language issue

And that's why you're the go-to guy when it comes to internationalization :)

😊 I only learnt to be very careful when assuming stuff in internationalization :wink:

OK so what do you think I should do? Maybe I should delete this pull request, start a new one just for the Youtube Block and leave the rest alone? Maybe you're in a better position to deal with the language issue

That's one of the reasons why it's better to have different PR for different issues... If I were you, I'd close this PR, create a new local branch, cherry pick https://github.com/concrete5/concrete5/pull/5395/commits/a7d76f9356409b88678eaa0ca821ea800c5afff2 and create a new PR...

Thank you. Good advice. Doing that now


Active sessions menu is not populating details of any previous or present active user

Describe the bug
When an admin user log into Mauro to check details of previously and present active users, not details is populating on the Active session’s menu. I have logged in using a different user ID, logged out and re logged back in suing an admin user ID and I can’t view previous user details on the active session’s menu.
To Reproduce
Steps to reproduce the behaviour:

Go to 'Mauro' as an admin user
Select the account setting dropdown menu
Select the Dashboard menu
Keep focus on the Active sessions menu
No details are displayed

Expected behaviour
There should be some previously active users on the menu
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]

Browser [e.g. chrome, safari]

Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Retested successful


Fixes enum generation for TS

Overview
Resolved Enum Generation for typescript code
Fixes https://github.com/microsoftgraph/microsoft-graph-devx-api/issues/815
Fixes https://github.com/microsoftgraph/microsoft-graph-devx-api/issues/813
Testing Instructions
Generated code for https://docs.microsoft.com/en-us/graph/api/accessreviewscheduledefinition-post?view=graph-rest-1.0&tabs=typescript

Can you please add a test case for this?

Will do :-)


Using concurrency to cancel any in-progress job or run

Summary of changes
Uses concurrency to cancel any in-progress job or run to help address #3093

Closes
Pull Request Checklist

[ ] Changes have tests (N/A)
[ ] News fragment added in changelog.d/.  (N/A)
(See documentation for details)

I don't know exactly but I have the impression that this change accidentally is preventing the release job to run on tags...
For example if we look at the workflow for the tag v60.9.1 (Fig. 1), the message seems to indicate that it got cancelled by GitHub because jobs for the commit being pushed to the main branch got enqueued just after the ones for the tag (Fig. 2):

Fig 1: Workflow for tag is getting cancelled because of a higher priority request

Fig 2: The higher priority request seems to be the normal push to main of the same commit

This might be related to the lack of determinism in the order workflows are triggered...
I don't know exactly how to solve this, but maybe it is a good idea to add the name of the event triggering the workflow to the group string? (if that is even possible)
@blink1073, @di what do you think?


This implies you should turn off audit logging if you're using a 3rd party SIEM

Not sure its a good idea to imply turning off Audit Logging here, as it could be used for backup and is a prerequisite for using the O365 Activity Management API
https://docs.microsoft.com/en-us/office/office-365-management-api/office-365-management-activity-api-reference

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f6aa9c0c-c1ba-a464-3724-2060b61df19b
Version Independent ID: 1d2e74f1-d2b8-6cdf-a9ea-e5d9f67a35b0
Content: Turn Office 365 audit log search on or off - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/turn-audit-log-search-on-or-off.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@jebalert Thanks for pointing this out. I'll add a note or otherwise address this.


[NO QA] Document why we pass the currentDate but we don't use it

Details
The ReportActionItemDate component receives a currentDate prop that is not used inside
The prop's purpose is to cause a re-render when it change, but that's not very obvious
Related to https://github.com/Expensify/App/pull/3573
Fixed Issues
N/A Documentation change only
Tests

N/A Documentation change only
QA Steps

N/A Documentation change only
Tested On
N/A Documentation change only

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08.  :confetti_ball:


Owls 99654 - Expand the WDT custom folder from the archive before calling update or create domain

Owls 99654 fix - This change expands the custom folder from the WDT archive in the domain dir before calling updateDomain.sh or createDomain.sh. This PR replaces PR #3108 which has 3.3 as the base release.

Don’t forget to port to main


Markdown support

Create the following features:

[ ] Accept .md extension files
[ ] Markdown italics syntax
[ ] Markdown Bold syntax
[ ] Markdown Heading 1 syntax
[ ] Markdown Heading 2 syntax
[ ] Markdown link syntax

@JerryHue  The logic for parsing markdown syntax should go inside Template.parse_body. Utility functions that don't depend on Template self should be put inside template_file, but outside of the struct.


pronto-rubocop crashes with undefined method `rewrite' for nil:NilClass (NoMethodError)

I'm investigating an issue after upgrading to the latest rubocop and pronto-rubocop in our project. It seems that it's sometimes crashing with
/path/vendor/bundle/ruby/3.0.0/gems/pronto-rubocop-0.11.4/lib/pronto/rubocop/offense_line.rb:43:in `corrected_lines': undefined method `rewrite' for nil:NilClass (NoMethodError)

Further investigation suggests that RuboCop::Cop::Base::InvestigationReport instance has corrector set to nil. This causes corrected_lines to fail. The cop that causes this is RuboCop::Cop::Metrics::ClassLength but I have no idea how to debug it further.

I've managed to narrow it down a bit, it seems to be working fine in rubocop 1.40.0 but starts failing in >= 1.41.0. There seems to have been some changes around the correctors in 1.41.0 which may cause the incompatibility.

@d4rky-pl is it possible to create a test case? If I see a recent run, it used rubocop 1.43.0. I'd want to enhance the tests to cover the scenario you're hitting before we can actually fix it.

I just hit this one too. It fails consistently on one PR but works fine on others.

pronto-rubocop-0.11.4
rubocop (1.43.0)
rubocop-ast (1.24.1)
rubocop-performance (1.15.2)
rubocop-rails (2.17.4)
rubocop-rspec (2.17.0)
ruby 3.1.0

@jesseclark which cops are enabled? Also, is it possible to make to look at the diff and figure out which cop is triggering this?
I would love to have a small testcase which is reproducible :sweat_smile:

@ashkulz The only cop violation I see in the files that changed is Rails/LexicallyScopedActionFilter.
Getting the full list of enabled/disabled cops might be a bit more involved but I could do so if that isn't enough to go on.

Just for a little extra verification, I modified one of the lines that cause the violation and opened a new PR and saw the NoMethodError. I then disabled Rails/LexicallyScopedActionFilter and pushed that. Pronto runs fine.
The code that is generating the violation is in a Rails Controller where we have a before_action call scope to only: :show but the show action isn't defined in the controller. If that helps you to setup a test case.

@d4rky-pl / @jesseclark, can you check if it works for you with the linked PR?

@ashkulz apologies, I was not able to get back to this topic until today. I can confirm the linked PR fixes the problem with rubocop > 1.40 both locally and our CI.

This has been pushed to RubyGems :tada:

Thanks @ashkulz!


Intercept absolute mouse positioning

Im a little bit confused by how to configure the interception driver so that it returns absolute mouse positioning instead of relative positioning to my application?
I always ended up using a second library to read the mouse position, can you guys provide an example or did i misunderstood that completely and the absolute positioning is only for writing?
(I had this problem already with the old library)

Hi,
maybe im blind or so.
I don't see how to tell the driver to return absolute mouse positions (i speak from these 2 byte values you get for X and Y Axis), whatever i do i get relative positions.
I know i can set the mouse to an absolute position using MouseFlag.MOUSE_MOVE_ABSOLUTE but that's not my interest.
Could you provide an working out of the box example that prints the X position (absolute) when the mouse is moved ?
(also i think your md examples don't work, since capture_mouse is not in Interception)

Literally just
import interception

while 1:
    print(interception.mouse_position())

Will print the absolute mouse position of the cursor on your screen.
Also beware that they are not byte values.

ok this works... but its using win32api and not the interception driver. :/

@DMI-1407 Indeed because the driver doesnt provide any way to get the mouse position, the driver deals with the mouse / keyboard device-stream only, it doesn't care where the mouse pointer currently is.
And iirc, win32api is a dependency of pyinterception anyways because its required to translate the keycodes for your keyboard layout properly.


question

Minecraft version & Mod Version:
1.12.2 1.12.2-1.14.3
Single player or Server:
sinlge player
Describe problem (what you were doing / what happened):
was wondering y ores spawn that have absolutely 0 uses in the nether? certus ore thorium dilithium and such but checked JEI and they have no uses besides visual deco blocks cause not having the mods that normally add those installed
Crash log (if any):
(If this is a suggestion and not a bug report, delete all this and just write your suggestion!)

oh and this links sort of to #709

Yep thats why they default to turned off. So when you download the mod and run. they are automatically turned off.
So when you download and run the mod and dont change any configs, they dont exist.
Using the magic of ore dictionary, other mods can use these.
So if you have a mod that uses thorium, then you can enable this ore and it will be fully compatible.   You are correct with the 709 link.  I forget which one, but one of " Nuclearcraft, Industrialcraft, Tech Reborn, Mekanism, Applied Energistics, and Advanced Rocketry " probably uses thorium and certus and dilithium.
For example I know Mekanism uses Osmium, but not many other mods do.  So if you have mekanism, you can enable Osmium.  If you dont, you can set all Osmium to false and move on.

thats the thing by default they were turned on which is weird and im not 100% sure they are turned off unless im just a real big obilivous person lol but thank you

Oh sorry.
i just tested now with latest 14.4 on curseforge (fresh install, deleted cyclic_ores.cfg) , and the ore does not exist, not showing in JEI, not spawning in nether.  So  Yes I think there might have been a bug in 14.1 or 14.2 where it defaulted to on, but at least we know its fixed.  So yeah, delete that file or set to false.
Thanks for reporting !


Add feishu-document-creator extension

Description
Create Feishu/Lark document in one click using native Feishu/Lark URLs.
Read more: https://github.com/rokcso/feishu-document-creator
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi 👋
How is this compared with this extension by @tmkx - would it be possible to enhance or is it two completely different things?

Hi 👋
How is this compared with this extension by @tmkx - would it be possible to enhance or is it two completely different things?

Hi @pernielsentikaer.
The main function of this extension you mentioned is to log in to the specified Lark account and search for the Lark document under that account, and then you can open the Lark document.
The main function of my extension is to create a blank Lark document more quickly and conveniently, and there is no need to log in to any account. By default, create a new blank Lark document under the account that the user's current browser has logged in to.
These two extensions are not solving the same problem.
At the same time, I have searched all the current extension of Raycast about Lark/Feishu, and it can be said that my extension is solving a problem that has not been solved yet.

I think this extension is more like a quicklink collection 🤔, and it can be added to https://www.raycast.com/chyroc/lark-applink, do u think so?

I quite agree that this extension is a quicklink collection, but this extension is not quite the same as Lark Applink, which is mainly aimed at the AppLink of the Feishu/Lark client, and all its quicklink is used to quickly open a page in the Feishu/Lark client.
My extension focuses on quickly creating new Feishu/Lark blank documents, and I think the need to open a page in the Feishu/Lark client through quicklink and the need to quickly create new Feishu/Lark blank documents are not necessarily the common needs of the same group of users, so I still hope that the extension can be independent for a dedicated extension for creating Feishu/Lark blank documents.
That's why this extension is named Feishu Document Creator.


Fails to build against wlroots master

Regressed by https://github.com/swaywm/wlroots/commit/6977f3a843c7
../output.c:235:44: warning: incompatible pointer types passing 'struct wlr_client_buffer *' to parameter of type 'struct wlr_buffer *' [-Wincompatible-pointer-types]
        if (!wlr_output_attach_buffer(wlr_output, surface->buffer)) {
                                                  ^~~~~~~~~~~~~~~
/usr/local/include/wlr/types/wlr_output.h:322:21: note: passing argument to parameter 'buffer' here
        struct wlr_buffer *buffer);
                           ^
../output.c:235:6: error: invalid argument type 'void' to unary expression
        if (!wlr_output_attach_buffer(wlr_output, surface->buffer)) {
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.

Thank for the pointer @jbeich. Note that Cage is deliberately developed against the latest tag of wlroots so I don't have to chase these kinds of breaking changes happening on the master branch :)


shutdown.sh must work with PID+signals

Now the password are not in clear, we need to change shutdown.sh to send a signal to the server process in case no password is provided. So when the server.sh starts, a PID file must be written.
The current alternative to get the password as parameter must stay there too.

Well, this will solve on *nix systems. How to deal on win? any idea?

Try to see Tomcat or other Java app how they do that.

I fixed the shutdown on java side.
handling the pid is another story and it is feasible only on linux, IMHO.

I think the impl. must be reviewed.

just pushed
server.sh saves the pid file in the orientdb home
shutdown.sh has two different behaviour

shutdown.sh without params, check for pid file and if found it simply send a kill -15
if params are passed, calls OshutdownMain

Params are no more positional:
shutdown.sh -h host -P 2424 -u root -p hello
or
shutdown.sh --host host --ports 2424 --user root --password hello
default value are:

host: localhost
ports: 2424-2430
user: root

Cool.


chore: bdd-spring-1582857275 to 0.0.1

chore: Promote bdd-spring-1582857275 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


HeifError: Code: 2, Subcode: 130, Message: "Invalid input: Invalid pixi box: No pixi information for chroma channels."

Hi,
During parsing of multiple HEIC files, most files in my set are parsed correctly, however, some files do not get parsed with the following error:
/usr/local/lib/python3.6/dist-packages/pyheif/reader.py in _read_heif_handle(handle, apply_transformations, convert_hdr_to_8bit)
    136             code=error.code,
    137             subcode=error.subcode,
--> 138             message=_libheif_cffi.ffi.string(error.message).decode(),
    139         )
    140     img = p_img[0]

HeifError: Code: 2, Subcode: 130, Message: "Invalid input: Invalid pixi box: No pixi information for chroma channels."

At the same time, the image is previewed and opened normally on my Mac OS 10.15.7, so it is not a corrupted file.
Any idea what could cause this behavior?
Thanks!

Can you attach an example image pls?

I came up with the same problem.  For example, the below images in zip.
images.zip


tfsec: 0.37.1 -> 0.37.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/tfsec/tfsec/releases.
meta.description for tfsec is: "Static analysis powered security scanner for your terraform code"
meta.homepage for tfsec is: "https://github.com/tfsec/tfsec"
meta.changelog for tfsec is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.37.3 with grep in /nix/store/r3m74g6zbijxgyb0bxymiidzssaf1v7y-tfsec-0.37.3

directory tree listing: https://gist.github.com/7fdb39bebe7666d4133efbfed120c76b

du listing: https://gist.github.com/d438c6150dc723b64ee1d5d16a96d3a5

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
tfsec

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/r3m74g6zbijxgyb0bxymiidzssaf1v7y-tfsec-0.37.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tfsec https://github.com/r-ryantm/nixpkgs/archive/98a8e9c2e7c95f969c2f63c2018a113fc5aca30f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/r3m74g6zbijxgyb0bxymiidzssaf1v7y-tfsec-0.37.3
ls -la /nix/store/r3m74g6zbijxgyb0bxymiidzssaf1v7y-tfsec-0.37.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

tfsec

Maintainer pings
cc @marsam for testing.

Result of nixpkgs-review pr 112220 run on x86_64-linux 1

1 package built:

tfsec


NVIDIA Jetson TX2 - Failed to compile samples , XCB error

With OpenGL backend compiled when started to compile Samples geting the follow problem:
[ 86%] Linking CXX executable AntTweakBarSample
../../../DiligentTools/External/lua-5.2.3/libLua.a(loslib.c.o): In function os_tmpname(lua_State*)': loslib.c:(.text+0x2f0): warning: the use of tmpnam' is dangerous, better use `mkstemp'
/usr/bin/ld: ../../../Common/NativeApp/Linux/libXCBKeySyms.a(xcb_keysyms.c.o): undefined reference to symbol 'xcb_get_setup'
//usr/lib/aarch64-linux-gnu/libxcb.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
DiligentSamples/Samples/AntTweakBar/CMakeFiles/AntTweakBarSample.dir/build.make:103: recipe for target 'DiligentSamples/Samples/AntTweakBar/AntTweakBarSample' failed
make[2]: *** [DiligentSamples/Samples/AntTweakBar/AntTweakBarSample] Error 1
CMakeFiles/Makefile2:1882: recipe for target 'DiligentSamples/Samples/AntTweakBar/CMakeFiles/AntTweakBarSample.dir/all' failed
make[1]: *** [DiligentSamples/Samples/AntTweakBar/CMakeFiles/AntTweakBarSample.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2
XCB is installed , its seems maybe like missing linkage library that is not set in the make file for this project

I added the -lxcb to the linkage makefile and this seems make it better
but now there is another error
[ 86%] Linking CXX executable AntTweakBarSample
../../../DiligentTools/External/lua-5.2.3/libLua.a(loslib.c.o): In function os_tmpname(lua_State*)': loslib.c:(.text+0x2f0): warning: the use of tmpnam' is dangerous, better use mkstemp' /usr/lib/gcc/aarch64-linux-gnu/5/../../../aarch64-linux-gnu/libGL.so: undefined reference to drmFreeDevice'
/usr/lib/gcc/aarch64-linux-gnu/5/../../../aarch64-linux-gnu/libGL.so: undefined reference to drmFreeDevices' /usr/lib/gcc/aarch64-linux-gnu/5/../../../aarch64-linux-gnu/libGL.so: undefined reference to drmMap'
/usr/lib/gcc/aarch64-linux-gnu/5/../../../aarch64-linux-gnu/libGL.so: undefined reference to drmGetDeviceNameFromFd2' /usr/lib/gcc/aarch64-linux-gnu/5/../../../aarch64-linux-gnu/libGL.so: undefined reference to drmCloseOnce'
/usr/lib/gcc/aarch64-linux-gnu/5/../../../aarch64-linux-gnu/libGL.so: undefined reference to drmUnmap' /usr/lib/gcc/aarch64-linux-gnu/5/../../../aarch64-linux-gnu/libGL.so: undefined reference to drmGetDevices2'
/usr/lib/gcc/aarch64-linux-gnu/5/../../../aarch64-linux-gnu/libGL.so: undefined reference to drmOpenOnce' /usr/lib/gcc/aarch64-linux-gnu/5/../../../aarch64-linux-gnu/libGL.so: undefined reference to drmGetDevice2'
collect2: error: ld returned 1 exit status
DiligentSamples/Samples/AntTweakBar/CMakeFiles/AntTweakBarSample.dir/build.make:103: recipe for target 'DiligentSamples/Samples/AntTweakBar/AntTweakBarSample' failed
make[2]: *** [DiligentSamples/Samples/AntTweakBar/AntTweakBarSample] Error 1
CMakeFiles/Makefile2:1882: recipe for target 'DiligentSamples/Samples/AntTweakBar/CMakeFiles/AntTweakBarSample.dir/all' failed
make[1]: *** [DiligentSamples/Samples/AntTweakBar/CMakeFiles/AntTweakBarSample.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

and this was solved by these magic :
cd /usr/lib/aarch64-linux-gnu/
sudo ln -sf tegra/libGL.so libGL.so

OpenGL backend compiled and working !

Reopen the issue for now as XCB should probably be added to the link list. Need to double check.
Not sure about libGL problem though as well as its solution.

https://github.com/DiligentGraphics/DiligentEngine/commit/030cbb3db06c3361e3a5dcfd8dc94ee2231531b6 should also fix this issue. Please reopen if it still doesn't build


[OCCM] occm version not displayed correctly since 1.21 release

Is this a BUG REPORT or FEATURE REQUEST?:
occm version not displayed correctly on using refactored cloudprovider code from k/k 1.21 release

Uncomment only one, leave it on its own line:
/kind bug
/kind feature

What happened:
What you expected to happen:
How to reproduce it:
Anything else we need to know?:
Environment:

openstack-cloud-controller-manager(or other related binary) version:
OpenStack version:
Others:

ref: https://github.com/kubernetes/cloud-provider-openstack/pull/1440#discussion_r620822121

/kind bug

/triage accepted

raised issue in cloudprovider repo for the same , https://github.com/kubernetes/cloud-provider/issues/49

/remove-lifecycle stale

/remove-lifecycle stale

Would it be worth peeking at how they did it for the AWS provider — would it work for us here too?
https://github.com/kubernetes/cloud-provider-aws/pull/317

looks like the problem can be solved by using there example
the only question I am having is following

# ./openstack-cloud-controller-manager-amd64 --version
Kubernetes v1.17.0-426-g033052e-dirty

on master branch
#  git describe
v1.17.0-427-g11155c9

# git checkout v1.23.1
Note: checking out 'v1.23.1'.

# git describe
v1.23.0-4-g1b5899e

so git describe looks like search for latest tag it can reach, we are using 1.17 now
so I guess everytime we do a release is create a release branch then tag on that branch
thus master branch can reach 1.17 ?
if we accept this, then I can submit a PR for this @ramineni @lingxiankong @MPV

so I guess everytime we do a release is create a release branch then tag on that branch

Yeah, we should change this.
I think this method could be good workaround for now.


mock data recipient's client certificate expired today (15/06/2023)

Hi @Smoovsky ,
Thank you for contacting us and raising this issue. Apologies for the inconvenience caused.
We are creating the new certificates now and will publish to GitHub as soon as they are available.
If a workaround is needed until then the below can help:
If you are using the mock-data-recipient and mock-register using visual studio, this cmd file can regenerate a new client mtls certificate.
If you do create and use a new certificate, the new certificate's thumbprint would need to be updated in the mock-register database - cdr-register.dbo.SoftwareProductCertificate.Thumbprint
To use the mock-data-recipient in a docker container, the new client certificate would need to be used to overwrite the existing certificates in the code base. Then the container needs to be re-built using this dockerfile.
We will update this issue as soon as the new certificates are available.

Hi @Smoovsky,
All expired certificates have been updated in the mock-register, authorisation-server, mock-data-holder, mock-data-holder-energy and mock-data-recipient code repositories.
The latest docker images are available on Docker Hub.

Hi team, thank you for updating the certificates. I'm no longer getting 500 errors when refreshing data holders from the mock recipient. However, now I'm observing an error returned from the mock-register and the data holders list still won't refresh. The UI shows BadRequest - {"error":"invalid_client","error_description":"Client certificate validation failed"}. I'm wondering if there is something wrong with the new certificate(s)?

and I can see some errors in the logs too:
mock-register            | 04:48:39.174 +00:00 Information [Serilog.AspNetCore.RequestLoggingMiddleware] HTTP "POST" "/idp/connect/token" responded 400 in 2608.1169 ms                                                                                mock-register            | 04:48:39.178 +00:00 Debug [Microsoft.EntityFrameworkCore.Infrastructure] '"RegisterDatabaseContext"' disposed.
mock-register            | [04:48:39 INF] requestId: 0HMRI2B327KKK:00000002, previousRequestId: no previous request id, message: 400 (Bad Request) status code, request uri: https://localhost:7002/idp/connect/token
mock-register            | [04:48:39 DBG] requestId: 0HMRI2B327KKK:00000002, previousRequestId: no previous request id, message: setting http response message                                                                                mock-register            | [04:48:39 DBG] requestId: 0HMRI2B327KKK:00000002, previousRequestId: no previous request id, message: no pipeline errors, setting and returning completed response
mock-register            | [04:48:39 DBG] requestId: 0HMRI2B327KKK:00000002, previousRequestId: no previous request id, message: ocelot pipeline finished
mock-data-recipient      | 04:48:39.214 +00:00 Debug [CDR.DataRecipient.SDK.Services.Tokens.AccessTokenService] Access Token Response: BadRequest.  Body: "{\"error\":\"invalid_client\",\"error_description\":\"Client certificate validation failed\"}"
mock-register            | [04:48:39 INF] HTTP POST /idp/connect/token responded 400 in 2884.4236 ms

I'm running the services using a derivative of the provided docker compose config
mock-register:1.2
mock-data-holder-energy:1.3
mock-data-recipient:1.2

Hi @FiskilBen,
Thank you for bringing this to our attention. We have tried the same scenario and were able to complete the Get Data Holders request without experiencing an issue.
There are a couple of ways this issue could occur:

Using an old version of mock-register:1.2, mock-data-holder-energy:1.3 or mock-data-recipient:1.2 would still have the expired certificate. Can you try deleting your local copies so the latest images are pulled from Docker Hub when using the docker compose.
If you are using a persistent database and not one inside the docker image then the ThumbPrint in cdr-register.dbo.SoftwareProductCertificate need to be updated. The new Thumbprint is f0e5146a51f16e236844cf0353d791f11865e405.

Let us know if that helps.

Thanks for the quick response @CDR-AndrewG. I was using a separate mssql container for the db as shown in the example docker compose config https://github.com/ConsumerDataRight/mock-data-recipient/blob/main/Source/DockerCompose/docker-compose.yml
Connecting to the sql server and updating the thumbprints in the table directly resolved the issue for me. Is there a seed data script that needs to be updated with the latest thumbprints?
For reference here's the query that resolved the issue for me:
UPDATE [cdr-register].[dbo].[SoftwareProductCertificate]
SET  Thumbprint = 'f0e5146a51f16e236844cf0353d791f11865e405';

Hi @FiskilBen,
Glad that helped.
The mock-register's seed-data has been updated to include the new Thumbprints.
The seed-data is only used when creating the database for the first time. The database migrations have will change the database structure but not the underlying data.
There are a couple of APIs that can be used to update the data in the mock-register database:
load-your-own-data-into-the-mock-register
reate-or-update-data-recipient-records-via-the-admin-api


Unsuccessful flutter web builds

Question
Is anyone able to build their app with hive support to build for web? I'm not even able to build the sample todo app .
Version

Platform: Web
Flutter version: 1.10.7-pre.69
Hive version: 1.0.0
Hive_flutter version: 0.2.1

What error message are you getting?

Launching lib/main.dart on Chrome in debug mode...
Skipping compiling todo|lib/main_web_entrypoint.dart with ddc because some of its
transitive libraries have sdk dependencies that not supported on this platform:
path_provider|lib/path_provider.dart
platform|lib/src/interface/local_platform.dart
https://github.com/dart-lang/build/blob/master/docs/faq.md#how-can-i-resolve-skipped-compiling-warnings
Building application for the web...                                10.7s
Attempting to connect to browser instance..
(This is taking an unexpectedly long time.)

I just found out that Flutter does not allow to import the dart:io library anymore for web projects. Before it was fine as long as it has not been actually used.
This has nothing to do with Hive itself.
You are not allowed to import the path_provider package anymore when you build for web.
The Hive samples do that. You can either comment out all the imports of path_provider or you use conditional imports.
Here is the corresponding Flutter issue: https://github.com/flutter/flutter/issues/39998

I just found out that Flutter does not allow to import the dart:io library anymore for web projects. Before it was fine as long as it has not been actually used.
This has nothing to do with Hive itself.
You are not allowed to import the path_provider package anymore when you build for web.
The Hive samples do that. You can either comment out all the imports of path_provider or you use conditional imports.
Here is the corresponding Flutter issue: flutter/flutter#39998

oh alright thank you very much.


feat(std_lib): println statements

Related issue(s)
Resolves  #383
Description
The new Directive::Log was added in acvm release 0.4.1. The backend has been already updated to reflect this new acvm release.
This PR adds logging statements to Noir. This will enable developers to print out respective variables as they are computed, arrays, and string literals. This will greatly help improve the developer experience as Noir devs will now have an easy (and popular) debugging tool available until more complex debugging is possible with Noir.
Currently, for dev purposes I am restricting the number of arguments in a log statement to one. This can be expanded in a separate PR.
Summary of changes
A builtin function called println has been added to the Noir std lib. There are some differences between println our existing builtin functions as println does not return anything and should not be optimized out.
The majority of the changes are in the noirc_evaluator as logs need to be able to print out the variables according to how they are used in the program. The most significant addition is the evaluate_println where the final string to be logged is constructed and a gate with a new Directive::Log is added to the evaluator. The directive in the acvm can be found here: https://github.com/noir-lang/acvm/pull/61. This new directive can contain either a single string or a vector of witnesses. In the case of a finalized output string the directive simply prints the string it contains and always resolves in the PWG. For the case where our output is witnesses we must fetch the witness values to output when solving the PWG and construct the final string there.
evaluate_println needs some extra information that other builtin methods don't require. It must determine whether to print an array as field elements or a utf8 and thus must know if the expression passed to it is a string. I added Println(bool) to the builtin::Opcode enum. The bool contained in this enum specifies whether the argument to be printed in a string. If a future PR expands println's to accept multiple variables this will have to be changed.
Dependency additions / changes
This is branched off of mv/strings and will re-use some of the decoding information from this PR for printing string arrays.
mv/strings is now in master so no heavy dependency changes here.
Test additions / changes
I am adding usage of std::println to the strings test.
Checklist

[X] I have tested the changes locally.
[X] I have formatted the changes with Prettier and/or cargo fmt with default settings.
[X] I have linked this PR to the issue(s) that it resolves.
[X] I have reviewed the changes on GitHub, line by line.
[X] I have ensured all changes are covered in the description.

Additional context
(If applicable.)

log() may not be the best name as it clashes with logarithms, maybe change to println() to mirror rust? /bikeshedding

log() may not be the best name as it clashes with logarithms, maybe change to println() to mirror rust? /bikeshedding

I agree. I will change this

I merged in master where we have deleted acvm/acir/noir_field. I had a couple conflicts as I made changes in acvm/acir. It seems github now thinks I am deleting all those files. All changes to acvm/acir are under this PR: https://github.com/noir-lang/acvm/pull/61.

When I ran this in my tests I would get the first printed value on the same line as the test name, the test's statue would then be printed after all the println output. As I think tests are a common usecase for println I'd like to get this fixed before merging if possible.

Good catch. I did most of this work before nargo test was added so I didn't consider how it might work in that environment. Will update

Perhaps we should hide print statements during tests like cargo does.
Alternatively we may have to change the test printouts to only print once the test is finished. This is less user friendly for long running tests I think.

Perhaps we should hide print statements during tests like cargo does.

This is probably good to have as prints will slow down large tests. I can add a --nocapture flag like Rust

the test's status would then be printed after all the println output

Rust also prints the test's status after any println output evaluated during the test, so I kept it this way for now. Did you have something else in mind?

Alternatively we may have to change the test printouts to only print once the test is finished. This is less user friendly for long running tests I think.

The way the Log directive is currently written in the acvm we print directly upon solving the directive. This is something that I was meaning to change when we added traces. Instead we would collect all the logs into a vector that is returned from the PWG. Then wherever backend.solve is being called would decide how to handle the logs. This would also enable us to follow Rust where we print to stdout no matter what if a test fails. I could add this into this PR, however, it would require upstreaming some acvm changes and might be left better for a separate PR.
For now I just went with a --nocapture flag on nargo test like in Rust. I also two test cases to tests/test_data/strings as well. For tests/test_data/strings the output from nargo test is this:
Running 2 test functions...
Testing test_prints_array...
ok
Testing test_prints_strings...
ok
All tests passed

While for nargo test --nocapture is this:
Running 2 test functions...
Testing test_prints_strings...
hello world!
goodbye world
ok
Testing test_prints_array...
[0000000000000000000000000000000000000000000000000000000000000001,<PHONE_NUMBER>000000000000000000000000000000000000000000000000000002,<PHONE_NUMBER>000000000000000000000000000000000000000000000000000003,<PHONE_NUMBER>000000000000000000000000000000000000000000000000000005,<PHONE_NUMBER>000000000000000000000000000000000000000000000000000008]
[032cd942673f55c1a82f20ec77f3d3e56896e7d45a724e5e500a90e8480d211f,00ee28a814efc46f099a83341db5e721deb3b323646b7cc6199c8054fbcc8204]
ok
All tests passed

For now I just went with a --nocapture flag on nargo test like in Rust

I switched to the flag --show-logs as I found it more intuitive

Looks good. I assume the changes needed to change print formatting would be in the acir crate now.

Yeah for printing values that require fetching witness values the formatting needs to be solved in the ACVM repo. I will make an issue on ACVM for this.

Corresponding ACVM issue stemming from this PR: https://github.com/noir-lang/acvm/issues/94
Will push something update Directive::Log in a moment

@Globallager @signorecello
Forgot to label this doc needed, just pinging y'all that this is now merged


No categories for extensive coverage for annotator

Add an extensive coverage job with some categories;

Login as annotator and go to task by this job: There are no categories in the list

pls specify examples, I can't reproduce

http://dev1.badgerdoc.com/annotation/tasks/5576
creds: annotator/annotator

Thanks, Svetlana!
In this example, the categories are not displayed even for the admin role.
Unfortunately, it was not possible to reproduce the issue on other extractions(cross, ext cov with categories), the bug is visible only on the specified example. Investigation needed

The bug was related to type of selected categories. If user selected categories with just one type 'Link', then categories will not appear while annotation. So the only way to fix it is when user selects category with type 'Link', he should select category with type 'Box' as well while adding new Job.

Fixed (inline message is displayed for Link categories)


[small thing] Maven dependency in README lists 4.0-SNAPSHOT instead of 4.0

As far as I can tell the version should just be 4.0, not 4.0-SNAPSHOT as listed in the readme, just thought I'd point that out!

You are right. Corrected it. Forgotten to update readme at last release.


docs: script to generate Table of Contents

you can view the final result https://github.com/jjmachan/aws-ec2-deploy/tree/gen-toc#readme

currently, we are using this repo to generate the Table of Content (https://github.com/ekalinin/github-markdown-toc). Modified the script a little bit for your needs. I can also make it a github action so that It updates the TOC everytime there is a change to README.


remove the session lock error message, includes contaria's changes

whats the idea with using an atomic here? atomics only lock for the value itself, dont we want to block for the entire time saving is still happening and not just the check for if its happeneing?

https://discord.com/channels/928728732376649768/928730156967788645/1038408521550675978 this discussion seems to be the impetus for it, I didn't write that part so I don't really know

oh wait i see i thought the outer layer of the sync was also replaced with their one atomic but its not good then

thoughts on setting up CICD, closing this pr and then we just fork yours to mcsr repo?

works for me, I can push the CICD stuff but you'll have to make the org repo

pushed


Support shared preproccessed columns.

This change is

crates/prover/src/core/vcs/verifier.rs line 61 at r1 (raw file):
Previously, andrewmilson (Andrew Milson) wrote…
Should we use tracing logs here i.e. info!(...) since we use for similar logs in other spots like here

IT was here for debugging, I'll remove that.
Thanks.

crates/prover/src/constraint_framework/component.rs line 141 at r3 (raw file):
Previously, shaharsamocha7 wrote…
mask_offset [0] is empty vec before adding the preprocessed columns?
maybe we should put a dbg_assert?

yes

crates/prover/src/constraint_framework/component.rs line 71 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
Done.

done

crates/prover/src/core/air/components.rs line 37 at r3 (raw file):
Previously, andrewmilson (Andrew Milson) wrote…
WDYT?

I think it is slightly less efficient, but I don't mind if you think it is better.

crates/prover/src/examples/blake/air.rs line 93 at r6 (raw file):
Previously, andrewmilson (Andrew Milson) wrote…
Seems ok to me for now.
Was there somewhere you wanted to put it?

maybe in verify_blake? as the verifier is supposed to know the structure of the preproccess trace.
The problem is that I do want the assert here:
https://github.com/starkware-industries/stwo/blob/b36d75f09347977062a1eb077db6c11069996980/crates/prover/src/examples/blake/air.rs#L439

crates/prover/src/core/air/components.rs line 77 at r6 (raw file):
Previously, andrewmilson (Andrew Milson) wrote…
This isn't performance critical. WDYT?
I think offset should be renamed to index because column offset I usually associate with a column's mask offset.

I return component_trace_log_sizes at the end of the map.

crates/prover/src/constraint_framework/component.rs line 134 at r8 (raw file):

                        );
                        next_column
                    })

Note that this removes duplicated columns.
Code quote:
                    .entry(*col)
                    .or_insert({
                        assert_matches!(
                            location_allocator.preprocessed_columns_allocation_mode,
                            PreprocessedColumnsAllocationMode::Dynamic,
                        );
                        next_column
                    })


Bug?: --show-fixes doesn't work with --fix-only

Hi! When I tried to use --show-fixes with --fix-only it doesn't work.
> ruff demo.py --fix-only --show-fixes
Fixed 1 error.

> ruff demo.py --fix --show-fixes

Fixed 1 error:
- demo.py:
    1 × I001 (unsorted-imports)

> ruff --version
ruff 0.0.254

I'm not sure if this is a bug or feature :)

I think this is probably a bug :)


apt.repro not working when using an extra filename argument

Describe the bug
I try to add a repro, but it doesn't work if I specify that it should be put into an extra file. There is no file created. When I do not use an extra file (remove the filename-argument) it works.
To Reproduce
apt.repo(
    {'install perforce repo'},
    'deb http://package.perforce.com/apt/ubuntu bionic release',
    present=True,
    filename="perforce",
)

Expected behavior
I would expect a file "perforce.list" in "/etc/apt/sources.list.d/"
Meta

Include output of pyinfra --support.

    System: Linux
      Platform: Linux-5.3.0-59-generic-x86_64-with-Ubuntu-18.04-bionic
      Release: 5.3.0-59-generic
      Machine: x86_64
    pyinfra: v0.15
    Executable: /home/dev/.local/bin/pyinfra
    Python: 2.7.17 (CPython, GCC 7.5.0)

How was pyinfra installed (source/pip)?
from github

Include pyinfra-debug.log (if one was created)

--> Starting operation: install perforce repo
[@local] >>> sudo -H -n -i sh -c '# If the file now exists
                if [ -f "/etc/apt/sources.list.d/perforce.list" ]; then
                    # Grep for the line, sed if matches
                    (grep "^.*deb http://package.perforce.com/apt/ubuntu bionic release.*$" "/etc/apt/sources.list.d/perforce.list" && sed -i="" "s/^.*deb http:\/\/package.perforce.com\/apt\/ubuntu bionic release.*$//" /etc/apt/sources.list.d/perforce.list) 2> /dev/null ||                     # Else echo
                    echo "deb http://package.perforce.com/apt/ubuntu bionic release" >> /etc/apt/sources.list.d/perforce.list

                # No file, just echo
                else
                    echo "deb http://package.perforce.com/apt/ubuntu bionic release" >> /etc/apt/sources.list.d/perforce.list
                fi'
[@local] mesg: ttyname failed: Inappropriate ioctl for device
    [@local] Success

Additional note: the ttyname failed comes from a bug in the .profile file of the root user, see https://superuser.com/questions/1241548/xubuntu-16-04-ttyname-failed-inappropriate-ioctl-for-device    but not sure if that is really an issue or just trashing the console.

This definitely looks wrong, if the file doesn't exist it should just create + echo to it. Will investigate!

@questor I can't replicate this using Docker or within an Ubuntu 18 VM. If you apply the fix from the SO question does it work? The command being executed is correct/should work.
$ pyinfra @docker/ubuntu:18.04 apt-test.py
--> Loading config...
--> Loading inventory...
    The @docker connector is in beta!

--> Connecting to hosts...
    [@docker/ubuntu:18.04] Connected

--> Preparing operations...
    Loading: apt-test.py
    [@docker/ubuntu:18.04] Ready: apt-test.py

--> Proposed changes:
    Groups: @docker
    [@docker/ubuntu:18.04]   Operations: 1   Commands: 1

--> Beginning operation run...
--> Starting operation: install perforce repo
    [@docker/ubuntu:18.04] Success

--> Results:
    Groups: @docker
    [@docker/ubuntu:18.04]   Successful: 1   Errors: 0   Commands: 1/1
    [@docker/ubuntu:18.04] docker build complete, image ID: 17d0a8499543

$ docker run -it 17d0a8499543 sh
root@331af80ed4e9:/# cat /etc/apt/sources.list.d/perforce.list
deb http://package.perforce.com/apt/ubuntu bionic release

I've patched my config and didn't get the "ttyname failed" message, but still does not work. I've used the "@local" deployment, might this make a change? What I noticed is that I received a "success" message even in the not working case. I've added some logging code and found this (note the printed "blub" and no "blub2"):
--> Starting operation: install perforce repo
[@local] >>> sudo -H -n -i sh -c 'echo "blub"
# If the file now exists
echo "blub2"
if [ -f "/etc/apt/sources.list.d/perforce.list" ]; then
echo "file exists, check if good" >> /etc/apt/sources.list.d/path1.txt
# Grep for the line, sed if matches
(grep "^.deb http://package.perforce.com/apt/ubuntu bionic release.$" "/etc/apt/sources.list.d/perforce.list" && sed -i="" "s/^.deb http://package.perforce.com/apt/ubuntu bionic release.$//" /etc/apt/sources.list.d/perforce.list) 2> /dev/null ||                     # Else echo
echo "deb http://package.perforce.com/apt/ubuntu bionic release" >> /etc/apt/sources.list.d/perforce.list
# No file, just echo
else
echo "file exists, check if good" >> /etc/apt/sources.list.d/path2.txt
echo "deb http://package.perforce.com/apt/ubuntu bionic release" >> /etc/apt/sources.list.d/perforce.list
fi'
[@local] blub
[@local] Success
When I remove all comments (btw it seems there is an error here because of the comment hiding the "" https://github.com/Fizzadar/pyinfra/blob/master/pyinfra/operations/files.py#L248) I get a syntax error because of the "then" and I'm not sure why?! Is it some sort of new-line problem (I've checked files.py and it's NOT using windows-new-lines).
btw my sh is pointing to bash, should be fine I guess?

Hmm - I also tried using @local and it worked the same as my comment above. After you ran the above does /etc/apt/sources.list.d/path2.txt exist/contain anything?
As far as next steps go I can only think of changing the command in the operation to echo instead of writing to the file, this would help identify the path being executed. Currently we don't know if the first if statement is evaluating true or false.

I've created a quick branch to test - https://github.com/Fizzadar/pyinfra/compare/master...temp-apt-repo-test - if you wouldn't mind installing that, rerunning the test and pasting the output here that would really help!

@questor I've just pushed https://github.com/Fizzadar/pyinfra/commit/b325d715cbe1e1ea12fc5e3ac54589eb749a03e7 to master which correctly adds the semicolons - does this work for you?

yep, can confirm that it works now with this change on my machine. small sidenote: I had to put another space BEFORE the semicolon in one of my tests I made, your version works on my machine but as I don't understand why I need semicolons it might be a good idea to make a space before the added semicolons just to be sure(tm).
Thanks for fixing it and being responsive, I know it's hard work to maintain opensource projects, you can close this ticket now!

The semi-colon explicitly separates the commands - not 100% on why the newline didn't have this effect (it should) but this could well be a difference in shells. See: https://stackoverflow.com/questions/7507038/semicolons-superfluous-at-the-end-of-a-line-in-shell-scripts
So this should be OK now! I'm planning to release this in 0.16 today/tomorrow :)


name 'train_dir' is not defined

Hey Wisdom, this is an excellent tutorial. Congratulations.
However, I notice that the variable 'train_dir' at the pre_process.ipynb file is not recognized.
Did you mean src_train_dir? Thank you

same error here, i tried renaming train directory to train_dir, but still same error!


Added micronucleus

Motivation for this change
Micronucleus is a nice bootloader for ATTiny boards, and is used by Digispark. This is a command line tool to flash stuff into it.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Up?

Also, format your commit messages according to CONTRIBUTING.md.
Done

No, the second commit should be micronucleus: init at 2.04.

Done.
On January 1, 2020 11:53:53 PM GMT+01:00, Florian Klink<EMAIL_ADDRESS>wrote:

No, the second commit should be micronucleus: init at 2.04.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/76621#issuecomment-570090317
—
cab

@GrahamcOfBorg build micronucleus

Build fails on darwin, because upstreams makefile hardcodes CC to gcc, which doesn't exist there.
You could try setting CC = if stdenv.isDarwin then "clang" else "cc"; if that's all to get it working, or add remove darwin from meta.platforms.

Build fails on darwin, because upstreams makefile hardcodes CC to gcc, which doesn't exist there.
You could try setting CC = if stdenv.isDarwin then "clang" else "cc"; if that's all to get it working, or add remove darwin from meta.platforms.

can i just use clang then?

@GrahamcOfBorg build micronucleus

@GrahamcOfBorg build micronucleus


I want to add lunarVim to the install process and I don't know if I'm doing it right?

Hi Axon,
I saw your Talk and it got me excited to play around with gitpod and ssh. I tried to add lunarVim to the installation and I don't know if I'm doing it correctly?
Here is your forked repo, with the modifications:
https://github.com/marcograhl/dotfiles-sh-test
Right now I just install it every time. Thanks for showing how to set this all up - much appreciated
kind regards marco

Hi @marcograhl
If you run the command in the following manner, it should work
https://github.com/axonasif/dotfiles-sh/blob/5cd761f52d67f9fb940210f432eb9b04066cf630/src/install/neovim.sh#L13
Instead of this command here on your fork. Basically, curl can't execute the script for you, you have to pipe it to bash.
As a side note, I also replaced NvChad with LunarVim as it looks like LunarVim creates a wrapper script and does not put itself as the default config for neovim, which is probably good for putting as an example ready-to-use config :)
So that means, if you pull the new changes from here to your fork, it should just work!

Thats awesome, I didn't know we need to pupe it to bash. I'm very new to this.
Awesome that you added LunarVim, I will test this out. Thank you Axon  🙌
How would I add a custom config.lua to the mix?

I tested it and It works like a charm, thanks


Fix RuntimeError: Attribute hass is None for <Entity ...>

Greetings! I've seen the following error in my HA logs:
2023-10-29 07:57:08.393 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved:   File "/usr/local/bin/hass", line 8, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 204, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 186, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.11/asyncio/base_events.py", line 640, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.11/asyncio/base_events.py", line 607, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.11/asyncio/base_events.py", line 1914, in _run_once
    handle._run()
  File "/usr/local/lib/python3.11/asyncio/events.py", line 80, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/local/lib/python3.11/site-packages/gehomesdk/clients/base_client.py", line 132, in async_run_client
    await self._async_run_client()
  File "/usr/local/lib/python3.11/site-packages/gehomesdk/clients/websocket_client.py", line 119, in _async_run_client
    await self._process_message(message)
  File "/usr/local/lib/python3.11/site-packages/gehomesdk/clients/websocket_client.py", line 293, in _process_message
    await self._process_cache_update(message_dict)
  File "/usr/local/lib/python3.11/site-packages/gehomesdk/clients/websocket_client.py", line 409, in _process_cache_update
    await self._update_appliance_state(mac_addr, updates)
  File "/usr/local/lib/python3.11/site-packages/gehomesdk/clients/websocket_client.py", line 445, in _update_appliance_state
    await self.async_event(EVENT_APPLIANCE_UPDATE_RECEIVED, [appliance, updates])
  File "/usr/local/lib/python3.11/site-packages/gehomesdk/clients/base_client.py", line 101, in async_event
    asyncio.ensure_future(cb(*args, **kwargs), loop=self.loop)
  File "/usr/local/lib/python3.11/asyncio/tasks.py", line 649, in ensure_future
    return _ensure_future(coro_or_future, loop=loop)
  File "/usr/local/lib/python3.11/asyncio/tasks.py", line 670, in _ensure_future
    return loop.create_task(coro_or_future)
Traceback (most recent call last):
  File "/root/.homeassistant/custom_components/ge_home/update_coordinator.py", line 280, in on_device_update
    entity.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 756, in async_write_ha_state
    raise RuntimeError(f"Attribute hass is None for {self}")
RuntimeError: Attribute hass is None for <Entity EID Cook Mode>

I started digging in a little bit and came across the two references to the same hass object. This PR removes the reinitialization of the class's properties e.g. entity_id via the super method call. Happy to add any necessary tests or discuss further. Thank you!

These fixes were excellent and really helped with the None for <Entity ...> errors.  After applying, I was still getting some errors with my dishwasher when the appliance sent new updates.  Seems to be fixed by defining the entities at line 275:
       entities = [               entity for api in self.appliance_apis.values() for entity in api.entities         ]
Then removing api in api.entities in the next line:
        for entity in api.entities:
changed to:
       for entity in entities:

I think these should be resolved a different way in the newest release, but feel free to submit an issue if you're still experiencing issues.


[Bug]: jest.restoreAllMocks() clobbers legacy fake timers since 29.4.3

Version
29.4.3
Steps to reproduce

git clone https://github.com/robhogan/jest-restore-mocks-bug
Observe npm --prefix jest-29-4-2 test passes
npm --prefix jest-29-4-3 test fails

Expected behavior
Tests that pass in 29.4.2 should pass in 29.4.3
Actual behavior
Test fails in 29.4.3
Additional context
I imagine this has a lot to do with the various changes to restoreAllMocks coupled with the fact that legacy timers are Jest mock based. Calling useFakeTimers({ legacyFakeTimers: true }) after jest.restoreAllMocks() fixes the test again.
I'm still looking into root-causing and fixing this but thought I'd share a repro as soon as I had one.
Environment
System:
    OS: macOS 13.4.1
    CPU: (10) arm64 Apple M1 Max
  Binaries:
    Node: 20.1.0 - ~/.nvm/versions/node/v20.1.0/bin/node
    Yarn: 1.22.19 - ~/homebrew/bin/yarn
    npm: 9.6.4 - ~/.nvm/versions/node/v20.1.0/bin/npm
    pnpm: 7.27.1 - ~/homebrew/bin/pnpm
  npmPackages:
    jest: ~29.4.0 => 29.4.3

@mrazauskas any immediate ideas?

First though to check if time is faked (and that legacy implementation was used) and if so to call useFakeTimers({ legacyFakeTimers: true }) here:
https://github.com/jestjs/jest/blob/0fd5b1c37555f485c56a6ad2d6b010a72204f9f6/packages/jest-runtime/src/index.ts#L1334-L1336
Fake timers will get installed, but is that enough? These will be not the same instances of mock functions. Second thought from here: jest.resetAllMocks() and jest.clearAllMocks() also mess up timer mock functions. Perhaps it would be enough to document all these peculiarities of legacy timers? In a way the following makes sense (or not?):
beforeEach(() => {
  jest.restoreAllMocks();
  jest.useFakeTimers({ legacyFakeTimers: true });
});

By the way, jest.restoreAllMocks() is in the spotlight, but what happens after calling jest.resetAllMocks()? If in the reproduction I use jest.resetAllMocks() instead of jest.restoreAllMocks(), test fails with both versions of Jest. How do users deal with that? Sorry, I never used legacy timers (;

Thanks for pointing to this test suite. Note that it has a second test with these lines (legacy timers are used, because of "legacyFakeTimers": true in package.json):
https://github.com/jestjs/jest/blob/0fd5b1c37555f485c56a6ad2d6b010a72204f9f6/e2e/fake-timers-legacy/reset-all-mocks/__tests__/resetAllMocks.test.js#L19-L20
File history is somewhat broken on GitHub. The test file was added in 2016 and got just few cosmetic changes (see #2109). This answers my question how jest.resetAllMocks() is supposed to be used with legacy timers. So I guess jest.restoreAllMocks() should be used in similar way.

The "bug" here isn't so much that 29.4.3 behaves in a certain way, it's that it behaves differently from 29.4.2.

Hm.. Isn’t it that we could complain about any bug fix in similar way? The change we are talking about comes from #13867. Looking at the PR, you can see that this was just a tiny bug fix.
I understand that the change is painful and that it is rather unfortunate to publish it as a minor release. All I could do is to spend time trying to explain how Jest got better after this change (see #13925). Hope this helps.

Thanks for linking that context. It may well be that new nee behaviour is better designed, more consistent, etc - I’m not disagreeing with the change in principle - but as it was an apparently unintentional regression (breaks tests that previously passed), shouldn’t we follow semver, revert it and hold it back until v30?
To put it directly, would you accept a PR that reverted the behaviour change, or is this effectively “wontfix”?

I'm happy to land a revert and then revert the revert for v30

@robhogan This can be closed, right?


Throw error if parent of operation group cannot be found

Right now, if the parent of an operation group is not found, the generator will not print any info. And the codes of operation group are generated, but the codes regarding the parent/child are not. This will leave the generated codes without compilation error, but not work.

Resolved in https://github.com/Azure/autorest.csharp/pull/1565


GEOMESA-2133 JsonPath converter treats missing elements as null

Signed-off-by: Emilio Lahr-Vivaz<EMAIL_ADDRESS>

Does this deserve any mention in the docs?  I can see it either way.

i'm not sure we want to get down to that level of detail in the docs... since we don't currently mention it one way or the other, i think it's ok to leave it


Image not Found in Tutorial Docs

The image here and other images in the same url  https://internetcomputer.org/docs/current/tutorials/create_your_first_app/. Are not being loaded .

Fixed in the latest patch


404 page should be as lightweight as possible for /simple/

seems lots of clients probe the simple index for versions.
404 page should be as lightweight as possible to lower BW costs.

This was fixed in #2220


Support multiple mastodon channels

Investigate if we should rather use https://toot.bezdomni.net and include more metadata in the toot-files. E.g. to which account it should be tooted (galaxyproejct, gtn ...).

I guess neither toot-together, nor the alternative support decalring the language of toots, do they?
That might be an interesting feature for Galaxy Europe.


ConflictError: Unable to activate cheffish-1.2, because chef-zero-3.2.1 conflicts with chef-zero (~>4.2)

Hi, I followed instructions to setup "chef-provisioning-azure" which went fine, I got a copy of a very basic VM creation on Azure from the url
http://stuartpreston.net/2015/02/chef-provisioning-with-microsoft-azure-part-1/#comment-595
the azure-provisioning-test.rb
As I have a full chef ubuntu server, I tried the following statements
chef-client --local ./azure-provisioning-test.rb
and
chef-apply ./azure-provisioning-test.rb
I get the following exceptions:
starting chef client, version 12.0.3
..Running Handlers
.....Error Running exception handlers
Error: Unable to activate cheffish-1.2, because chef-zero-3.2.1 conflicts with chef-zero (~> 4.2)
FATAL: Gem::ConflictError: Unable to activate cheffish-1.2, because chef-zero-3.2.1 conflicts with chef-zero (~>4.2)
How this can be resolved?
Thanks

Hey could you solve the problem? Even I'm facing the same.

pretty sure this got solved awhile ago


Disqus not working

Hey does anyone got Disqus to work in this theme? I've tried inlude shortName inside config.toml, is there any configuration that I missed out?

I've tried this


Application Email broken

The e-mail application seems to be broken when it comes to hiding or showing some items of it such as writing e-mail which appears at the edge of the page adding a horizontal scrollbar.
This issue is also occurring in the demo: https://zuramai.github.io/mazer/demo/application-email.html

I have checked it and yep, it seem the compose element doesn't hide properly and the position it's not absolute which make the element extended the section. I will try to fix it and will let you know soon

Abwesenheitsnotiz:
Vom 22.06.2023  bis einschließlich 11.07.2023  bleibt unser Büro geschlossen. E-Mails werden entsprechend der Dringlichkeit verzögert bearbeitet.
In Notfällen benutzen Sie bitte das telefonische Notfallsystem unter 02206-95100-0.

Beste Grüße
1 Qubit - J.Suing

1 Qubit - J.Suing
Laurentiusstr. 41 - 51789 Lindlar
fon: 02206-95100-0 - fax: 02206-95100-29
Portfolio
STARFACE Telefonanlagen
Software-Entwicklung
Firewall, Security, UTM, VPN
Mailserver / Unified Messaging
CRM / ERP
Partner
STARFACE Advanced Partner
STARFACE Module Creator
Securepoint Professional Partner
Tobit Software Authorized Partner
work4all! Solution Partner
Kerio Partner
Blog, Forum, Module und mehr...
www.1qubit.de
This issue has been automatically marked as stale because it has been open for 14 days without activity. It will be closed if no further activity occurs within the next 14 days. If this is still an issue, just leave a comment or remove the "stale" label.
--
Reply to this email directly or view it on GitHub:
https://github.com/zuramai/mazer/issues/236#issuecomment-1615315729
You are receiving this because you are subscribed to this thread.
Message ID: @.***>


Using LogsActivity and CausesActivity Traits on Same Model

use Spatie\Activitylog\Traits\LogsActivity;
use Spatie\Activitylog\Traits\CausesActivity;

class Admin extends Authenticatable
{
     use Notifiable;
     use CausesActivity;
     use LogsActivity;

Get this error:
(1/1) FatalErrorException
Trait method activity has not been applied, because there are collisions with other trait methods on App\Admin
Does not happen if I use only LogsActivity

Duplicate of #215
I'll fix this late August when creating v2 that will be L5.5 only.

Still getting the error on version 2.0 with L5.5.
Trait method activity has not been applied, because there are collisions with other trait methods on App\User

I forgot to put my revisit label here, so didn't revisit this issue before tagging v2.
I'll talk a look before tagging the next major version (might be a while though)


Add versioning document

Add a document that describes our versioning strategy for this package and some of the thinking that went into it.
@jorgepiloto This is intended to go some way to explaining why we're doing things slightly differently to other PyAnsys packages. We are definitely open to discussion though if there's anything we've missed or should re-evaluate.
@da1910 I don't seem to be able to add you as a reviewer (you may not have re-authed with the Ansys organization), but please do take a look.
This document is also to remind our future selves that we've already done this thinking once and we shouldn't keep going over the same ground multiple times.

This covers the discussion we had yesterday to the best of my recollection. I wonder if it's worth making clear that it might be forwards-compatible, but we don't guarantee it?

I was thinking about that, but I decided against it. Even if by some happy accident an API definition is forwards-compatible with the next version, that's just luck. I feel like the intent is the important thing to characterize here, since it's the intent that has gone into our versioning decision.

See individual comments

Thanks @judy-selfe-ansys . I made your suggested modifications.

After discussion, we're going to go forward with a PyGranta-specific metapackage that will handle the mapping between SemVered Python packages and CalVered Ansys releases. I will create a separate PR that updates the README appropriately.


Testing expected errors without Assertion Plan (misleading docs)

I was trying out Jest and started to write some tests around expected errors.
In the docs I found a section for async testing and error handling: https://facebook.github.io/jest/docs/tutorial-async.html#error-handling
// Testing for async errors can be done using `catch`.
it('tests error with promises', () => {
  return user.getUserName(3)
    .catch(e => expect(e).toEqual({
      error: 'User with 3 not found.',
    }));
});

// Or try-catch.
it('tests error with async/await', async () => {
  try {
    await user.getUserName(2);
  } catch (object) {
    expect(object.error).toEqual('User with 2 not found.');
  }
});

Both of these examples are super misleading, because the test passes in both cases if the function doesn't throw in the first place. E.g. this is a perfectly fine test that Jest doesn't complain about:
it('error handling', () => {
  try {
    console.log('definitely not failing')
  } catch (err) {
    expect(err).toBeTruthy()
  }
})

I couldn't find any hint in the docs whether something like plan(1) does or doesn't exist, but the migration guide for AVA and Tape mentions that it's unsupported. I would've loved to send a PR that improves the docs directly, but without a plan feature I don't see an elegant solution.
This isn't cool:
it('error handling', () => {
  const expect2 = jest.fn(expect)
  try {
    console.log('definitely not failing')
  } catch (err) {
    expect2(err).toBeTruthy()
  }

  expect(expect2.mock.calls.length).toBe(1)
  // fails now
})

This isn't cool either:
it('error handling', () => {
  try {
    console.log('definitely not failing')
    expect(false).toBeTruthy()
    // fails now
  } catch (err) {
    expect(err).toBeTruthy()
  }
})

And neither is this:
it('error handling', () => {
  try {
    console.log('definitely not failing')
  } catch (e) {
    var err = e
  }
  expect(err).toBeTruthy()
  // fails now
})

I'm not sure if it's just that I'm still thinking in terms of tap[e], or if this really is a problem, and how you would solve it elegantly in a Jest style.

Yep, you are right we should improve this API and that it sucks currently. My hope was that we could make expect(() => {}).toThrow() async, but that's not easy either. I don't really like the "plan" functionality so much but we should potentially consider it – although it would be a pretty big hack into Jasmine. What do you think is best?
cc @dmitriiabramov

Just a quick thought: If .toThrow() would always await the function passed to expect, would that work?
The same problem occurs for event emitters btw.
it('emit event', () => {
  emitter.on('event', (event) => {
    expect(event).to…
  })
})

In case the event is never fired the test still passes. I know that using a spy on the handler could make this work, but I think t.plan would be way easier in most cases.

yes. this was always a very dangerous thing.
what if we introduce async matchers?
expect.async(await stuff).toThrowErrorMatchingSnapshot();

might also be a default behavior for expect to wait if a promise passed.

I think plan does have some interesting use cases that I would love to see in Jest. There's a good article on it in the AVA docs.
In tape it's relatively easy to implement, because all expectations go through the t callback object like this example:
var test = require('tape');

test('timing test', function (t) {
    t.plan(2);

    t.equal(typeof Date.now, 'function');
    var start = Date.now();

    setTimeout(function () {
        t.equal(Date.now() - start, 100);
    }, 100);
});

Could you potentially do something similar in Jest, but using the global Jest object for the plan function like this?
it('does timing stuff', () => {
    Jest.plan(2);

    expect(typeof Date.now).toEqual('function');
    var start = Date.now();

    setTimeout(function () {
        expect(Date.now() - start).toBe(100);
    }, 100);
});

I don't know enough about how Jest is wired up behind the scenes yet to know if this would be practical. I'd love to have a go myself, but I haven't had much time to look at the source yet so might need a pointer on where to start looking.

It would be expect.plan. We already have per-test state, so we can do this.

Anybody up to make a PR?

This will be in the next Jest release as expect.assertions(number).


[FEATURE]: Add support for RHEL 9 in PowerStore CSI Driver

Describe the solution you'd like
Add support for RHEL 9 in the PowerStore CSI Driver.
Describe alternatives you've considered
Use an operating system that is already supported by the PowerStore CSI Driver.
Additional context
Our organization is planning to migrate to RHEL 9 in the near future and we would like to ensure that the PowerStore CSI Driver is compatible with this operating system. We have tested the current version of the CSI Driver on CentOS 7.9, but we would like to take advantage of the new features and improvements in RHEL 9.

@matthewc97 Thanks for filing this request. This is being tracked as part of https://github.com/dell/csm/issues/893 and targeted for a future release (that is TBD at the moment, will update https://github.com/dell/csm/issues/893 once the support is planned for). Would it be ok if I close this ticket?

@bharathsreekanth sure, thank you!

thank you @matthewc97


If modules overlap, deleting one can clobber the other

Describe the bug
If modules overlap, deleting one can clobber the other
Application: Brain Simulator,
To Reproduce
Steps to reproduce the behavior:

Create network with ImageFile Module
Overlay ColorComponent module over a pixel of the picture area
Delete the ImageFile module
The ColorComponent module crashes because it relies on neuron settings which have been removed

Maybe we are having trouble here since the module literally occupy neurons rather than having their own "sub-network". If every module had its own network they would be truly independent.

Yes, this is also exactly the problem of dragging modules or selections across each other. It seems like this would be a big deal to fix but perhaps not.


Can't build SiamMask and TransT functions

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce
I'm encountering an issue where building automated annotation functions (SiamMask and TransT) in CVAT gets stuck in the "building" state. Below are the steps I followed and the output logs.
Steps to Reproduce:

Installed CVAT locally using WSL 2 and Docker, following the installation instructions.
CVAT runs fine, and I can annotate videos.
Tried building automated annotation functions (SiamMask, TransT) using:
./serverless/deploy_cpu.sh serverless/pytorch/foolwood/siammask/

Both SiamMask and TransT get stuck in the "building" state. Here's the console output for SiamMask:

24.09.30 21:28:55.948 (I)                     nuctl Project created {"Name": "cvat", "Namespace": "nuclio"}
Deploying pytorch/foolwood/siammask function...
24.09.30 21:28:56.094 (W)            nuctl.platform MaxWorkers is deprecated and will be removed in v1.15.x, use NumWorkers instead
24.09.30 21:28:56.192 (I)                     nuctl Deploying function {"name": "pth-foolwood-siammask"}
24.09.30 21:28:56.193 (I)                     nuctl Building {"builderKind": "docker", "versionInfo": "Label: 1.13.13, Git commit: 028989fe9d3fec47692e4a1384ac42267a8b7e0b, OS: linux, Arch: amd64, Go version: go1.21.13", "name": "pth-foolwood-siammask"}
24.09.30 21:28:56.329 (I)                     nuctl Staging files and preparing base images
24.09.30 21:28:56.393 (W)                     nuctl Using user provided base image, runtime interpreter version is provided by the base image {"baseImage": "ubuntu:2a0.04"}
24.09.30 21:28:56.454 (I)                     nuctl Building processor image {"registryURL": "", "taggedImageName": "cvat.pth.foolwood.siammask:latest"}
24.09.30 21:28:56.454 (I)     nuctl.platform.docker Pulling image {"imageName": "quay.io/nuclio/handler-builder-python-onbuild:1.13.13-amd64"}
24.09.30 21:28:59.486 (I)     nuctl.platform.docker Pulling image {"imageName": "quay.io/nuclio/uhttpc:0.0.1-amd64"}
24.09.30 21:29:02.353 (I)            nuctl.platform Building docker image {"image": "cvat.pth.foolwood.siammask:latest"}

It halts at this point. When accessing http://localhost:8070/projects/cvat/functions, I see the functions stuck in the "building" state, and the build log shows nothing.
Found somewhat similar issues:
https://github.com/cvat-ai/cvat/issues/3059
https://github.com/cvat-ai/cvat/issues/4475
Followed the suggestions from the first one (adding port and IP address into SiamMask function.yaml), but it didn't solve the problem.
Expected Behavior
SiamMask and TransT functions should be deployed successfully and appear in the AI Tools section of the CVAT annotation UI.
Possible Solution
No response
Context
No response
Environment
Docker Desktop 4.34.2 (167172) on Windows 10
CVAT:
Server version: 2.20.0
Core version: 15.2.0
Canvas version: 2.20.9
UI version: 1.66.0

Please try to run the build with the verbose option and attach a full log. If the build process is running, it does not mean that the function container cannot be built. I would suggest waiting for completion, it can't continue forever anyway


Fix wrong channel and playlist names of AWS courses

What does this PR do?
Fix wrong name of playlist and channel here #7437
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ ] Read our contributing guidelines.
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction).
[ ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

thanks


Zombies see vanished players

I have a ready fix for that, but it will require to make some patches using harmony which we don't have as a library in RocketMod yet

Or maybe better just make a plugin for that, and publish it on Unturnedstore also, with info kind a: developed by RocketModFix etc, to popularize new RocketMod fork


fix: configure the pipelines-visualizer to access the logs storage

this will allow the UI to access the long-term storage directly, to view an old pipeline that has been garbage collected in the cluster
related to https://github.com/jenkins-x-plugins/jx-build-controller/pull/11

Hi @vbehar. Thanks for your PR.
I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign daveconde
You can assign the PR to them by writing /assign @daveconde in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/ok-to-test
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vbehar: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
cb594169e6506da78b6bb5a94532cfdeb668fc4f
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

/retest


Pending request and alert bubble/number stuck

Subject: Pending request and alert bubble/number stuck
Description:
Tried to reject (or accept) the request.
Results:
After clicking reject or accept it says "This request is in the past." The alert bubble/number is still showing on Messages. It should have allowed me to reject the Request (or asked if I wanted to delete it). Regardless, it is still showing the alert bubble/number and I have seen this page many times.
Thanks for looking into this report!
Backend version: develop-7c33e18d
Frontend version:
User Agent: Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36 OPR/86.0.4363.59
Page: https://couchers.org/messages/request/21978
User: josiah (13389)

Addressed by the "mark all as read" button


Introduce gosec for Static Application Security Testing (SAST)

How to categorize this PR?

/area compliance security
/kind enhancement
What this PR does / why we need it:
This PR introduces gosec for Static Application Security Testing at Gardener and should replace other code scanners.
It uses the default ruleset of gosec with two exceptions.

Scanning generated code is disabled. The Kubernetes code-gen creates hundreds of low priority findings for unsafe pointers (G103). The generated code has proven that it is working and it is not possible to address those findings.
The ./hack folder is excluded, because gosec does not support nested go modules (like logcheck) and there is no productive code in this folder anyway.

All findings based on these settings have been mitigated in this PR.
There are two new make targets.

make sast is supposed to be called in unit tests. It logs all finding to console and fails in case of errors.
make sast-report can be used in build pipelines. It fails on errors too. Additionally, it creates a report in sarif format to ./gosec-report.sarif file. This report also tracks suppressed findings.

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
cc @ccwienk @ThormaehlenFred @dkistner
Release note:

`gosec` was introduced for Static Application Security Testing (SAST).

/assign

/lgtm cancel
/unhold
If there are multiple reviewers, one can add /approve and the other one /lgtm 🙂

@oliver-goetz : I suggest to add a change similar to this to this repository's branch.cfg (refs/meta/ci). Of course, instead of lint, you should use verify as step-name`, + adjust labels and comment accordingly. Said change will disable CX-Checks.

@oliver-goetz : I suggest to add a change similar to this to this repository's branch.cfg (refs/meta/ci). Of course, instead of lint, you should use verify as step-name`, + adjust labels and comment accordingly. Said change will disable CX-Checks.
/lgtm

Okay, I'll update the pipeline accordingly, when the PR is merged.
Could/should we store the resulting report which is now saved in ./gosec-report.sarif file somewhere as a build artifact or attachment?


Minor refactoring in advance of forthcoming module functionality

The most significant component is moving the existing files from lib/ to lib/internal/, as the module functionality will allow for public, optional modules residing as the immediate children of lib/.

Coverage increased (+0.01%) to 95.904% when pulling 345dd550f982bcb373a0c2800a7c7ba190fb8256 on refactor into f9ef7251d0df989f30fd4888d74bf91374c87673 on master.


Addresses #1528 renal interstitial pericyte and glomerular mesangial cell edits

Addresses #1528 renal interstitial pericyte edits

Changes made:
For  'renal interstitial pericyte':

changed EA:
from
'pericyte cell'
and ('part of' some kidney)
to
'pericyte cell'
and ('part of' some 'kidney interstitium')

Added textual definition:
A pericyte cell located in the kidney interstitium.

For 'glomerular mesangial cell':

added
‘capable_of’ some phagocytosis

added
‘capable_of’ some ‘actin-mediated cell contraction’

@dosumis, could you approve my changes? It appears merging is blocked until "requested changes are addressed".

@bvarner-ebi pericyte cell is redundant since "cyte" means cell.... not sure why it would be called this?

@emquardokus rmbr seeing this fix before so went to look back at closed PRs - that has indeed been fixed: https://github.com/obophenotype/cell-ontology/pull/1555