Update the policy and gateway status to match GEP GEP-713

What
Our policy controllers and Gateway controllers should ensure they follow the recomended status conditions https://github.com/kubernetes-sigs/gateway-api/blob/release-0.8/geps/gep-713.md#solution-cookbook

@maleck13
I'm not sure which status conditions solution this issue refers to (as there are a few in the solutions cookbook), but I would recommend careful consideration as to which status condition solutions to implement at this time, given the wording on some of the solutions.
i.e.

This solution is IN PROGRESS and so is not binding yet.
This solution requires definition in a GEP of its own to become binding.
The description included here is intended to illustrate the sort of solution that an eventual GEP will need to provide, _not to be a binding design.
The description included here is intended to illustrate the sort of solution that an eventual GEP will need to provide, _not to be a binding design. THIS IS AN EXPERIMENTAL SOLUTION DO NOT USE THIS YET.

A couple of options to progress this issue in a safer way would be to:

wait for further updates and/or GEPS with recommendations that are more concrete
and/or get involved in defining the more concrete versions of those recommendations

Yep agree on deciding carefully. But really we know we need some more status to expose clearer information to the user so we either come up with our own or look to use some of those defined in this GEP. No reason as we do this we can't make more recommendations.

Going to update this with a set of tasks based on https://github.com/Kuadrant/architecture/pull/9/files#diff-367635fe9aacbfbd467205789c2aa3ed677cd8cbd2ba2a6f92ce61c83e63ad0bR138

This issue is stale because it has been open for 60 days with no activity.

This issue was closed because it has been inactive for 30 days since being marked as stale.


Separate components in AuthenticatedApp and UnauthenticatedApp

The main project structure may need to be separated in an auth and unauth components

Not sure if this is going to be needed, if not, I'll close this issue.


pymongo.errors.NotMasterError in clashleaders/player_worker.py:47

Error in ClashLeaders
pymongo.errors.NotMasterError in clashleaders/player_worker.py:47
interrupted at shutdown
View on Bugsnag
Stacktrace
clashleaders/player_worker.py:47 - fetch_clans_since

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
pymongo.errors.NotMasterError in clashleaders/player_worker.py:47


Re click can not be hidden explorer view

We have written the needed data into your clipboard because it was too large to send. Please paste.

@RbBtSn0w can you please share the information generated by the Issue Reporter here ?

Close as lack of enough information to help troubleshoot. We can reopen whenever we have good reproduce steps.


StorageLoader: write JSON path for com.mailgun/message_clicked/jsonschema/1-0-0

Migrated to https://github.com/snowplow/iglu-central/issues/541


Editor options do not appear

Sometimes options for buttons and maybe more do not appear.
No errors in logs.

Could be a HACS / loading problem.
Possible causes:

card registered twice in resources.
bug when downloading. Redownload in HACS.

Looks like the input elements need to be loaded first. Could be fixed by adding home assistant helpers in the repo.


Question regarding "identifiers" in "dds.pf.tmLanguage.json"

I was viewing the DDS source for a physical file the other day and noticed that the "R" in position 29 was not highlighted when the length of the field name is 10 characters long.

If I remove the whole "identifiers" section from the syntax file then it works as expected.

I couldn't see any specific documentation in the Language Configuration Guide that mentioned "identifiers" so was curious as to what this definition actually does. Does anyone know?
As an aside the pattern name within the "identifiers" section is identifier.other.dds.lf.identifiers rather than identifier.other.dds.pf.identifiers.

Identifier is a term used during lexing/parsing for representing variables, parameters, user-defined functions, etc (https://en.wikipedia.org/wiki/Lexical_analysis). This term is used in the vscode docs at https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide#standard-token-types-and-modifiers.
I think there may be a regex bug in the R column example you provided; I will look into this. Additionally, I agree the pattern name is wrong and is a copy/paste error that needs correcting.

Fixed in v0.6.18 - https://github.com/barrettotte/vscode-ibmi-languages/releases/tag/v0.6.18

I can confirm this is working.
Is the identifiers section still required?


RepoDB: Model with FK to lookup table use case

See #14

Just assign all the things-to-do to me for RepoDb, I will revisit them all soon. Thanks

IMHO, the HR.EmployeeDetail view must not be present. I think, this scenario is a good candidate to showcase the capability of the ORM to handle the actual parent-child relationship without the help of the combined resultsets like HR.EmployeeDetail view is doing.
I would somehow say, this view should be removed and have the other cater the table-based direct queries.
Anyway, I have never used the HR.EmployeeDetail view in my repository. :)

You're not required to use it, but there's nothing wrong with taking advantage of views in the database.

Was not it a different scenario when using it?
Why? By using this, we can just simply hack the Employee class to simplify the process of decomposition of EmployeeClassification within the memory (through property values assignment). We defeat the purpose of Object-Graph, 2 DB queries or JOIN feature.

We can have a separate use case demonstrating client-side joins.
The point of this one is to demonstrate the correct way of handling the lookup table use case with a given ORM. Technically speaking, an ORM could do everything via stored procedures so long as it passes the tests.

Okay. Fair enough. Then I will maybe re-issue a PR to this soon. Thanks

Added #86 for client side joins.


Enable Reporting / Set Browser

I am doing some research on using Playwright with the testing service and was not able to find answers to a couple questions.
Using dotnet, C#, & xUnit, connecting using a bearer token to the Azure endpoint. How can I specify for the service to use Edge or Chrome instead of just Chromium? I don't see settings in the BrowserTypeConnectOptions or BrowserNewContextOptions. Is there a way to specify it as a query string on the URL?
Any runs report as Reporting Disabled. Is it possible to enable this when running locally or is it something which will only work in a pipeline by uploading a TRX output?

Hi @JDCain, Great to hear your interest in using dotnet.
Regarding chrome/mdesge
You can use it via option channel https://playwright.dev/dotnet/docs/browsers#google-chrome--microsoft-edge
We have recently added first class support for Nunit runner in playwright testing service and here is example https://playwright.dev/dotnet/docs/browsers#google-chrome--microsoft-edge, this enabled reporting as well without any need of CI or trx output.
We dont yet natively support Xunit but I am interested in understanding your research and then see how can we help it.  I can arrange a sync up call to over it. please drop a email at<EMAIL_ADDRESS>

When locally using LaunchAsync it's clear how to pass the channel, however when using ConnectAsync to access wss://eastus.api.playwright.microsoft.com the class BrowserTypeConnectOptions which is taken by ConnectAsync does not include a channel property.
Unfortunately using NUnit is not an option as we currently have thousands of xUnit based dotnet Selenium tests with custom xUnit behaviors. I am looking at using this IWebDriver abstraction (https://github.com/thomhurst/Selenium.PlaywrightDriver) to switch out existing tests to xUnit.

Hi @JDCain ,
You can pass channel browser info via header x-playwright-launch-options with value BrowserTypeLaunchOptions
                Headers = new List<KeyValuePair<string, string>>
                {
                    new KeyValuePair<string, string>("Authorization", $"Bearer {token}"),
                    new KeyValuePair<string, string>("x-playwright-launch-options", System.Text.Json.JsonSerializer.Serialize(new BrowserTypeLaunchOptions(){Channel= "msedge"}, new JsonSerializerOptions() { DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull }))
                },

@puagarwa What about passing the bearer token via the  --logger "microsoft-playwright-testing"?
I've set it via $env:PLAYWRIGHT_SERVICE_ACCESS_TOKEN and the url $env:PLAYWRIGHT_SERVICE_URL=wss://eastus.api.playwright.microsoft.com/accounts/<secret>/browsers but I still get the error: 1) The authentication token provided is invalid. Please check the token and try again. Are there any other settings I am missing?

HI @JDCain , I will try it tomorrow, but it could be due to default value of param ServiceAuthType as "EntraId" whereas in your case it should be "AccessToken" since you are using token auth. Would you mind either
defining runsettings and add

or pass it from dotnt cli as
--% -- TestRunParameters.Parameter(name="ServiceAuthType", value="AccessToken")

Setting ServiceAuthType did make it so I no longer get errors. I also made sure the RunId would match between the logger and the test run. However, no logging ever shows up in the UI. In fact they all list as Reporting Disabled

Hi @JDCain , As i mentioned earlier we havent tested our logger for Xunit yet so its possible it may not work. I can take a look at it tomorrow if you can share small repro (possibly repo)
Meanwhile, can you share your subscription Id so that i can take a look at telemetry.

The reporting is a ITestLoggerWithParameters so it should be agnostic to whatever testing framework is being used. I'll send you the id directly.

Hi @JDCain , I spent some time with Xunit + service. Good part is both cloud browser and reporting works. here are my findings and suggestion

Make sure you use different runId every time --> in your example in discord (BaseClass) you have hard coded it. I will suggest pass it via env variable like this $"wss://eastus.api.playwright.microsoft.com/accounts/secret/browsers?os=linux&runId={Environment.GetEnvironmentVariable("PLAYWRIGHT_SERVICE_RUN_ID")}
You can remove runId from runsettings as well, logger consider this env variable PLAYWRIGHT_SERVICE_RUN_ID, as long as you set this, it should work fine
For AccessToken, please pass it from env variable PLAYWRIGHT_SERVICE_ACCESS_TOKEN, logger takes it from this env variable.

Please try these and let me know. I will also test to add working example in this repo in few days.

There appear to be several settings which cannot be set via environmental variables with the reporter and still need the run settings. For example I can't use the key unless I set ServiceAuthType in the run settings: https://github.com/Azure/azure-sdk-for-net/blob/c7aebd5804617eed4744bf97dec8636a9ab347ef/sdk/playwrighttesting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/src/PlaywrightReporter.cs#L96C9-L96C1
Is there any trick to getting video and screenshots to upload? I have them working locally but when using the service they never appear.

HI @JDCain , in my above message. you could still use runsettings. I only asked to pass Token and runId from env variable instead of runsettings. Rest everything can either be passed either via runsettings or via cli params (--% -- TestRunParameters.Parameter(name="ServiceAuthType", value="AccessToken")).
Yeah, similar to how i have done it for Nunit in my example in this repo, we could do it for Xunit as well. basically the trick is to enable those by following playwright docs and then make sure add it in testcontext. I havent tried this yet but should be doable.

TestContext does not exist in xUnit currently so that can't be used to attach things via the logger.
Also how would that work since the test is running remotely in the service? When I run a test with video on the cloud service no video is locally created which I could attach.

HI @JDCain ,
Yes, As you mentioned testContext doesnt exist in Xunit and its open ask by many on thier repo  from many years.
I spend time on trace/video in Xunit and here is my findings

You could generate trace and video locally even when using cloud browser, the way cloud browser works it always fetches the artifacts at client side.
Even though we can generate these artifacts, due to Xunit lack of support for TestContext and AddTestAttachment its not possible to attach it to reporting. (Xunit issue)

Here is modified code to enable trace and video. With this you should see trace and videos collected in bin\Debug\netX.0 location
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Text.Json.Serialization;
using System.Text.Json;
using System.Threading.Tasks;
using Microsoft.Playwright;
using Azure;
using System.Reflection.PortableExecutable;

namespace PlaywrightTestsXUnit
{
    public class PlaywrightTestWithArtifact : IAsyncLifetime, IDisposable
    {
        private IPlaywright _playwright;
        private IBrowser _browser;

        public async Task InitializeAsync()
        {
            _playwright = await Playwright.CreateAsync();
            // use endpoint, runid from environment variables
            _browser = await _playwright.Chromium.ConnectAsync($"{Environment.GetEnvironmentVariable("PLAYWRIGHT_SERVICE_URL")}?os=windows&runId={Environment.GetEnvironmentVariable("PLAYWRIGHT_SERVICE_RUN_ID")}", new BrowserTypeConnectOptions
            {
                ExposeNetwork = null,
                Headers = [new KeyValuePair<string, string>("Authorization", $"Bearer {Environment.GetEnvironmentVariable("PLAYWRIGHT_SERVICE_ACCESS_TOKEN")}"), // use token from env variable
                new KeyValuePair<string, string>("x-playwright-launch-options", System.Text.Json.JsonSerializer.Serialize(new BrowserTypeLaunchOptions { Channel= "msedge", Headless = false}, new JsonSerializerOptions() { DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull }))],

                SlowMo = null,
                Timeout = null
            });
            Context = await _browser.NewContextAsync(ContextOptions());

            // Enable Trace
            await Context.Tracing.StartAsync(new()
            {
                Title = $"{Guid.NewGuid}",
                Screenshots = true,
                Snapshots = true,
                Sources = true
            });
            Page = await Context.NewPageAsync();
            //await Context.Tracing.StartAsync(new TracingStartOptions()); // not needed
        }
        public async Task DisposeAsync()
        {
            var tracePath = $"trace-{Guid.NewGuid()}.zip"; // Since Xunit doesnt support TestContext hence using guid, there are workaround using reflection to get testName if needed for trace file name
            await Context.Tracing.StopAsync(new()
            {
                Path = tracePath
            });
            var videoPath = $"trace-{Guid.NewGuid()}.webm"; // Since Xunit doesnt support TestContext hence using guid, there are workaround using reflection to get testName if needed for video file name
            await Context.CloseAsync();
            if (Page.Video != null)
            {
                await Page.Video.SaveAsAsync(videoPath); // this is required to get video locally when using cloud browser
                //TestContext.AddTestAttachment(videoPath, description: "Video"); // cant work in Xunit
            }
            return;// Task.CompletedTask;
        }

        public IBrowserContext Context { get; set; }
        public IPage Page { get; set; }
        public virtual BrowserNewContextOptions ContextOptions()
        {

            return new()
            {
                Locale = "en-US",
                ColorScheme = ColorScheme.Light,
                RecordVideoDir = ".videos" // required to enable video
            };
        }
        public void Dispose()
        {
            _playwright.Dispose();
        }
    }
}

Is there documentation for the API used to upload the artifacts, and does that API allow you to upload artifacts after the results have already been uploaded?  e.g. Could I create a separate job which uploads the artifacts after the run completes without using the logger? I do something similar to this with our current custom ITestLogger and videos with Selenium.
Also does the API instead allow for say appending links or notes to a run? There was some concern about uploading the videos at all as there could be information we don't want to upload to the cloud in the videos. For example in TFS you can append notes to a run via a markdown file with links.

Is there documentation for the API used to upload the artifacts, and does that API allow you to upload artifacts after the results have already been uploaded? e.g. Could I create a separate job which uploads the artifacts after the run completes without using the logger? I do something similar to this with our current custom ITestLogger and videos with Selenium.

We have API but it wont allow you to upload artifacts post run completion (which happen from service logger). I understand your ask and intent here but its not possible yet. please open a feature ask in github issues.

Also does the API instead allow for say appending links or notes to a run?

Currently no, we dont allow any update in run/result post run completion.

This video recording also does not work for me when using the cloud service
Yes, i can also see the issue, I will take a look at it and check whats the issue. It works in Nunit/MSTest so need to check once.

Hi @JDCain , I found the issue with empty view. It was due to Test is creating local Page, hence it is not using global Page which we created in initialize.
In class UnitTest1, Comment this line
Page = await Context.NewPageAsync();
Also, In my above fixture, i put OS name as windows, you could change it to linux if needed
_browser = await _playwright.Chromium.ConnectAsync($"{Environment.GetEnvironmentVariable("PLAYWRIGHT_SERVICE_URL")}?os=windows&runId={Environment.GetEnvironmentVariable("PLAYWRIGHT_SERVICE_RUN_ID")}
We could make code changes to honor runsettings value if needed.


[Bug]: Pictures are squeezed at insta section at home page

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
In the insta section at home page the images that are displayed are squeezed and are not balanced and seems unprofessional. I want to fix this UI issue.
Below is the screenshot of this issue.
Add Screenshots / Video Clip

What browsers are you seeing the problem on?
Chrome
Agreements

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC contributor
[X] I'm a Hacktoberfest contributor
[X] I want to work on this issue [Optional]
[X] I'm willing to provide further clarification or assistance if needed.

Kindly add hacktoberfest-accepted, hacktoberfest and gssoc-ext labels to this issue and assign this issue to me. Would love to contribute.


Create gender-zeitschrift-fur-geschlecht-kultur-und-gesellschaft.csl

https://forums.zotero.org/discussion/109008/pagenumbers-in-inline-citation#latest

oops -- this is the wrong repo -- I was wondering why we weren't getting any previews :))


commit request

Hi man , i got some free time for the holidays and ive decided to work on project , i really love ur work
I broke it down to smaller files , instead of a massive one.
Fixed some issues that the windows users had when copying the command for PowerShell (it now finds and opens the default powershell and as  a foldback it displays a message)
fixed some issues that the linux users had , and improved the auto-releases to pair it with a auto-update , unfortunately i don't have a mac so i cant it there

Sure, welcome! 👏 Next time remember to git pull first~


ASSERT.assertNotNull verhindert MayProduceNPE Warnung nicht

Is your feature request related to a problem? Please describe.
After checkong an object via AssertProvider.ASSERT.assertNotNull(Obj o) intelliJ nethertheless shows the "Method invocation may produce NullPointerException" warning

Describe the solution you'd like
use @Contract("null -> false") for assertNotNull

The @Contract annotation belongs to the dependency org.jetbrains:annotations which is not part of Testerra. This could helpful if all Testerra users use IntelliJ. But Testerra is a common Java Framework. I'm not sure if we have to add special helpers for certain IDEs.
Of course we could provide some hints how to configure your IDE for best experience. Is there another solution for IntelliJ? Well, the IDE already knows the Assert methods of Junit and TestNG. Could we extend that rules?


Docs should describe how to add a MetaGraphDef to an existing graph

URL(s) with the issue:
https://www.tensorflow.org/guide/saved_model#save_and_restore_models
Description of issue (what needs changing):
Clear description and Usage Example
I've already created several models, trained over several days each, that we're ready to move from local testing to a serving environment.
The models were saved using the function
def save_graph_to_file(sess, graph, graph_file_name):
    """Saves an graph to file, creating a valid quantized one if necessary."""
    output_graph_def = graph_util.convert_variables_to_constants(sess, graph.as_graph_def(), [final_tensor_name])
    with gfile.FastGFile(graph_file_name, 'wb') as f:
        f.write(output_graph_def.SerializeToString())

via the image retraining sample script.
Now, I'm ready to move this to a serving environment (via Sagemaker, but that just implements tensorflow.serving).
The error is clear enough:
2019-06-04 22:38:53.794056: I external/org_tensorflow/tensorflow/cc/saved_model/reader.cc:54] Reading meta graph with tags { serve }
2019-06-04 22:38:53.798096: I external/org_tensorflow/tensorflow/cc/saved_model/loader.cc:259] SavedModel load for tags { serve }; Status: fail. Took 83297 microseconds.
2019-06-04 22:38:53.798132: E tensorflow_serving/util/retrier.cc:37] Loading servable: {name: model version: 1} failed: Not found: Could not find meta graph def matching supplied tags: { serve }. To inspect available tag-sets in the SavedModel, please use the SavedModel CLI: `saved_model_cli`

Loading up the graph by adapting the loader from the retrain script, I try to just append the serving tag to the graph
def load_graph(model_file):
    """
    Code from v1.6.0 of Tensorflow's label_image.py example
    """
    graph = tf.Graph()
    graph_def = tf.GraphDef()
    with open(model_file, "rb") as f:
        graph_def.ParseFromString(f.read())
    with graph.as_default():
        tf.import_graph_def(graph_def)
    return graph
# Load the graph
graph = load_graph(modelPath)
import shutil
if os.path.exists(exportDir):
    shutil.rmtree(exportDir)
# Add the serving metagraph tag
builder = tf.saved_model.builder.SavedModelBuilder(exportDir)
from tensorflow.saved_model import tag_constants
with tf.Session(graph= graph) as sess:
    builder.add_meta_graph_and_variables(sess, [tag_constants.SERVING, tag_constants.GPU], strip_default_attrs= True)
builder.save()
print("Built a SavedModel")

which doesn't work (still has the same error). I'm not giving up on this, but given that the code was written out with a Tensorflow example, this seems like an obvious use case to cover.
Submit a pull request?
If I'm able to solve this in a timely way, I'll submit a PR for the docs; at the moment it's a few steps away from me being there, however.

Solved the overall issue:
#!python3
"""
Assumes we've defined:

- A directory for our working files to live in, CONTAINER_DIR
- an arbitrary integer VERSION_INT
- We have established local and S3 paths for our model and their labels as variables
"""

# Create a versioned path for the models to live in
# See https://stackoverflow.com/a/54014480/1877527
modelVersionPath = os.path.join(CONTAINER_DIR, VERSION_INT)
if os.path.exists(modelVersionPath):
    shutil.rmtree(modelVersionPath)
os.mkdir(modelVersionPath)
import tensorflow as tf
def load_graph(model_file, returnElements= None):
    """
    Code from v1.6.0 of Tensorflow's label_image.py example
    """
    graph = tf.Graph()
    graph_def = tf.GraphDef()
    with open(model_file, "rb") as f:
        graph_def.ParseFromString(f.read())
    returns = None
    with graph.as_default():
        returns = tf.import_graph_def(graph_def, return_elements= returnElements)
    if returnElements is None:
        return graph
    return graph, returns
# Set up dirs
exportDir = modelVersionPath
# Clean up any existing one
import shutil
if os.path.exists(exportDir):
    shutil.rmtree(exportDir)
# Add the serving metagraph tag
# We need the inputLayerName; in Inception we're feeding the resized tensor
# corresponding to resized_input_tensor_name
# May be able to get away with auto-determining this if not using Inception,
# but for Inception this is the 11th layer
inputLayerName = "Mul:0"
# Load the graph
if inputLayerName is None:
    graph = load_graph(modelPath)
    inputTensor = None
else:
    graph, returns = load_graph(modelPath, returnElements= [inputLayerName])
    inputTensor = returns[0]
with tf.Session(graph= graph) as sess:
    # Read the layers
    try:
        from tensorflow.compat.v1.saved_model import simple_save
    except (ModuleNotFoundError, ImportError):
        from tensorflow.saved_model import simple_save
    with graph.as_default():
        layers = [n.name for n in graph.as_graph_def().node]
        outName = layers.pop() + ":0"
        if inputLayerName is None:
            inputLayerName = layers.pop(0) + ":0"
    print("Checking outlayer", outName)
    outLayer = tf.get_default_graph().get_tensor_by_name(outName)
    if inputTensor is None:
        print("Checking inlayer", inputLayerName)
        inputTensor = tf.get_default_graph().get_tensor_by_name(inputLayerName)
    inputs = {
        inputLayerName: inputTensor
    }
    outputs = {
        outName: outLayer
    }
    simple_save(sess, exportDir, inputs, outputs)
print("Built a SavedModel")
# Put the model label into the artifact dir
modelLabelDest = os.path.join(exportDir, "saved_model.txt")
!cp {modelLabel} {modelLabelDest}
# Prep for serving
modelName = f"livemodel_{dt.datetime.now().timestamp()}.tar.gz"
# Copy the version directory here to package
!cp -R {modelVersionPath} ./
# gziptar it
!tar -czvf {modelName} {VERSION_INT}
# Shove it back to S3 for serving
!aws s3 cp {modelName} {bucketPath}
shutil.rmtree(VERSION_INT) # Cleanup
shutil.rmtree(os.path.join(CONTAINER_DIR, VERSION_INT)) # Cleanup

This is a good baseline for the docs, I'll see if I can write up a PR around it in the next few days

@tigerhawkvok Please provide a link to the PR when you raise so that we will close this when you merge your PR. Thanks!


Remove max length on textfield

Instead of basing everything on a TextField, could we just remove the max_length specifically on the EncryptedTextField?

This was supposed to be an internal PR first.


Mobile Tab  Navigation

Project title
Mobile Tab Navigation
Project Description
Navigate same as mobile
Stack:
And in order to tick the check box just but x inside them for example - [x] like this. Please delete options that are not relevant.

[x] Html
[x] CSS
[x] JavaScript
[ ] ReactJS

/assign


bug: When a command fails during Labware Position Check, the error dialog is formatted wrongly and goes away on its own

Overview
The Opentrons App seems to be mishandling Protocol Engine command errors raised during Labware Position Check.
Steps to reproduce

Start a run on a robot and start Labware Position Check.
Wait for Labware Position Check to encounter a robot-side Protocol Engine command failure.

For example, on v6.0.0, it will probably error when it tries to move to a labware atop a Heater-Shaker, because of bug #11125.

Current behavior

The app displays a dialog with the literal text error_modal_text.
The dialog goes away on its own after a second or two, without you selecting its close button.

Expected behavior

The dialog should have a message that's meaningful to users, instead of the literal string error_modal_text.
The dialog should only go away when it's been closed.
We might also consider moving the movement command id abc123... part to the app's debugging logs, or to a "developer details" dropdown menu within the dialog. It seems like technobabble.

Some possibilities for what error_modal_text should say:

"The robot could not perform a required movement step."
"A movement command to the robot failed."

As a user, I'd also like a title more specific than "Something went wrong" (might as well just say "Error"). If this is an LPC-specific dialog it could say "Labware Position Check failed" or "Labware Position Check stopped".


Update Set-SPOSite.md

Updated conditional params. My module (16.0.9021.1201) was throwing an error
et-SPOSite : Cannot bind parameter 'ConditionalAccessPolicy'. Cannot convert value "LimitedAccess" to type "Microsoft.Online.SharePoint.TenantManagement.SPOConditionalAccessPolicyType".
Error: "Unable to match the identifier name LimitedAccess to a valid enumerator name. Specify one of the following enumerator names and try again:
AllowFullAccess, AllowLimitedAccess, BlockAccess"
At line:1 char:57

Set-SPOSite -Identity $siteUrl -ConditionalAccessPolicy LimitedAccess

                                                    ~~~~~~~~~~~~~

CategoryInfo          : InvalidArgument: (:) [Set-SPOSite], ParameterBindingException
FullyQualifiedErrorId : CannotConvertArgumentNoMessage,Microsoft.Online.SharePoint.PowerShell.SetSite

Docs Build status updates of commit deecc1b:
:clock10: Full build: the average full build time is 12 min(s) 13 sec(s), this is based on the last 601 build(s) for this repository.

Docs Build status updates of commit deecc1b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9efb45b:
:clock10: Full build: the average full build time is 12 min(s) 5 sec(s), this is based on the last 647 build(s) for this repository.

Docs Build status updates of commit 9efb45b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Error after updating to DotNet v8

2023-11-18 23:27:03|dotnet-5756|INFO|ASF|InitCore() ArchiSteamFarm V<IP_ADDRESS> (generic/98d541a0-893c-4ebb-91b8-45e2b65a4245 | .NET 8.0.0; win-x64; Microsoft Windows 10.0.19045)
2023-11-18 23:27:04|dotnet-5756|INFO|ASF|InitPlugins() Chargement FreePackages V<IP_ADDRESS>...

2023-11-18 23:27:07|dotnet-5756|ERROR|ASF|OnBotLoggedOn() System.MissingMethodException: Method not found: 'System.Threading.Tasks.Task`1<ArchiSteamFarm.Web.Responses.ObjectResponse`1<!!0>> ArchiSteamFarm.Steam.Integration.ArchiWebHandler.UrlGetToJsonObjectWithSession(System.Uri, System.Collections.Generic.IReadOnlyCollection`1<System.Collections.Generic.KeyValuePair`2<System.String,System.String>>, System.Uri, ERequestOptions, Boolean, Byte, Int32, Boolean)'.
   at FreePackages.WebRequest.GetUserData(Bot bot)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at FreePackages.WebRequest.GetUserData(Bot bot)
   at FreePackages.PackageHandler.FetchUserData()
   at FreePackages.PackageHandler.OnBotLoggedOn(Bot bot)
   at FreePackages.FreePackages.OnBotLoggedOn(Bot bot)
   at ArchiSteamFarm.Core.Utilities.InParallel(IEnumerable`1 tasks)
   at ArchiSteamFarm.Plugins.PluginsCore.OnBotLoggedOn(Bot bot)

References:

https://github.com/JustArchiNET/ArchiSteamFarm/releases/tag/<IP_ADDRESS>
https://github.com/Citrinate/BoosterManager/issues/7

Acknowledged, but won't be fixing this or Citrinate/BoosterManager#7 yet as ASF V5.5 is still pre-release.  I'd like to address this before the stable release, but I'm not sure when that will happen.

Just added a pre-release version for use with ASF 5.5: https://github.com/Citrinate/FreePackages/releases/tag/1.3.0


Correction for raw affiliation Department of Mechanical and Energy Engineering, De Montfort University Dubai, United Arab Emirates

Correction needed for raw affiliation Department of Mechanical and Energy Engineering, De Montfort University Dubai, United Arab Emirates
raw_affiliation_name: Department of Mechanical and Energy Engineering, De Montfort University Dubai, United Arab Emirates
new_rors: 0312pnr83
previous_rors:
works_examples: W4394935662
contact: bf97d860dadbb8d1cc0add93e36f65e8:1288d0 @ dmu.ac.uk

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Focus not working correctly in Material

Description
I set focus: true on a field in my form. When the form is shown focus goes to the control but is then immediately lost.
Minimal Reproduction
https://github.com/craigsh/ngx-formly-focus-test
Your Environment

Angular version: 11.2.0
Formly version: 5.0.0

Additional context
Haven't been able to reproduce in a StackBlitz but reproduced in my repo above.

Interestingly, hacking ngx-formly-core.js to put a setTimeout around the focus call solves the issue:
   toggleFocus(value) {         /** @type {?} */         const element = this.fieldAttrElements ? this.fieldAttrElements[0] : null;         if (!element || !element.nativeElement.focus) {             return;         }         /** @type {?} */         const isFocused = !!this.document.activeElement             && this.fieldAttrElements                 .some((/**              * @param {?} __0              * @return {?}              */             ({ nativeElement }) => this.document.activeElement === nativeElement || nativeElement.contains(this.document.activeElement)));         if (value && !isFocused) { 			setTimeout(() => { 				element.nativeElement.focus(); 			});         }         else if (!value && isFocused) {             element.nativeElement.blur();         }     }

This issue has been fixed and released as part of v5.10.20 release.
Please let us know, in case you are still encountering a similar issue/problem.
Thank you!

Great, thanks for the quick action on this - much appreciated, and a fantastic library!


Regarding the usage of the ToolContext class

When using FunctionCall, I found that the ToolContext class cannot be used with DashScopeChatModel.
In my project, I previously integrated the Spring AI framework, but defining the DashScope ChatModel myself was quite difficult. So, I wanted to use Spring AI Alibaba, but I found that some ability is missing.
For example:

When dynamically registering Functions, only the name can be passed in, and passing in a FunctionCallBack object is not very convenient.
Does not support calling the ToolContext class.

I am using the spring-ai-alibaba jar version 1.0.0.M2. I am not sure if it is a version issue.
Could you please look into optimizing the above issues?

@xibeiyizhi could you show me some examples?


[FLINK-13168] [table] clarify isBatch/isStreaming/isBounded flag in flink planner and blink planner

What is the purpose of the change
clarify isBatch/isStreaming/isBounded flag in flink planner and blink planner

isBatch in ConnectorCatalogTable, which tells if the tableSource/tableSink is BatchTableSource/BatchTableSink
isBatch in TableSourceQueryOperation, which tells if the tableSource is BatchTableSource
isStreaming in TableSourceTable, which tells if if the current table is on stream planner
bounded StreamTableSource could be used for both batch and stream, while unbounded StreamTableSource could only be used for stream.

Brief change log

Add comments for isBatch in ConnectorCatalogTable&TableSourceQueryOperation, and where to use it
Add isBatchMode flag into XXXSchema to tell if the current planner should work in a batch or streaming mode in blink planner
rename isStreaming to isStreamMode to distinguish isBatch flag in (TableSourceTable)

Verifying this change
all existing test should be passed, and add several tests to validate bounded & unbounded table source in blink planner
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @KurtYoung @twalthr @dawidwys


Enable an institution to be the complainant when creating a new case

Business Context:
When a new case is created, would like there to be be a new "institution" field, for cases where an organization is submitting a complaint.
In Scope

Add a new field for institution. Both are text, optional fields.
Add this to the DB

Out of Scope

Refer to comments for the other cards

Open Questions
Mockups

Acceptance Criteria

Scenario:
When I create a new case
Then I can add the institution
OR leave it blank
And I still need to enter First and Last name to proceed (existing behavior)

Checklist

[ ] Ensure to include all necessary mockups to this card.
[ ] Discuss what success/failure user feedback messages would be present, if any occur (front end/back end).
[ ] Discuss Feature Flag: Where could a development flag go to flag off incomplete work? Do we want to keep the flag long-term?
[ ] If this card is part of a sequence of cards, discuss if this card should be blocked until the testing of previous cards in the sequence have been finished.
[ ] Have we added edge cases as ACs that we're considered from a QA perspective
[ ] Should the new functionalities be offered only to users with certain permissions?
[ ] How should this functionality differ between different orgs, and if it does differ, what is the hinge point we should use for that functionality?

Notes:

To discuss w/ Shak, Karhan, Reshmi first

Checked w/ Christin:

She is OK with just adding “organization” as new field (impt to be able to export this info later)
Edge case when org is known but name of person unknown (to think about a solution in future, esp for new redesign)

Add a new story for:

showing it in the Case Details
Editing Case Details

Stories

Creating and Showing
Editting in Case details


Consider replacing GNU Make with Gradle (or something else?)

I went to ToorCamp 2022 recently and had a conversation with someone who suggested I use Gradle for the build system of Headway instead of Make. They mentioned a few benefits, including the fact that if a build step fails then the artifacts from that build step aren't cached or written to disk. It would also cache build artifacts in a smarter way, meaning things don't get evicted from the cache needlessly.
In other words if I ran:
make Adelaide
make Seattle
make Adelaide

In step 3, Gradle would use the cached Adelaide artifacts from step 1.
Both of these seem huge to me, because they would completely negate the benefits of using docker build instead of docker run, reduce docker image clutter, and reduce wasted effort spent on updating Makefile style to work on various platforms/versions.
If nobody objects to the use of Gradle in the near future, I think I'll begin work on this. I'm entirely open to using just about anything that provides the cache and reproducibility-on-error benefits that Gradle seems to, just want to evaluate everything on its merits. :)

Not sure if you have pings set up, or are still following development here but I'm curious what you think @3nprob. I know we discussed how goofy it is to use docker build for data processing and I think this would give all of the benefits of that without any of the goofiness. A few people I've talked to have objected to the idea of using a heavyweight build system for this so I'm curious if you have any insight. The input you've provided so far has been really valuable.

Some observations:
The headway build process (all managed through make configured by the Makefile) currently concerns itself with building code (compilation), images (packaging) and data (data processing).
Compilation is the primary use-case for make. Processing data through make and other code-build-tools is not necessarily super uncommon or a bad idea per se but clunky ergonomics are not a big surprise. Similarly with docker build.
So I think the three main directions here I see would be

Keep current general Makefile+docker build combo but try to improve on it
Separate the concerns and move the data processing part out of the build system to something different (probably something more made for the purpose)
Replace the build system with something different

So 3 would be what's proposed in this issue (Replace Make with Gradle). Just listing this explicitly to highlight that it doesn't have to be all-or-nothing either.
As for gradle itself, I have to say that while I have used it superficially from time to time, I do have a bit of a (perhaps irrational) aversion to it and I would grumble a bit to have to dive into it. But again, this opinion is not a well-educated one so take it for what it is.
I did stumble upon a project a while back that I think could be interesting to check out for this, I'll see if I can find it again.

The three main directions here would be:
1. Keep current general Makefile+docker build combo but try to improve on it

2. Separate the concerns and move the data processing part out of the build system to something different (probably something more made for the purpose)

3. Replace the build system with something different

Seeing this spelled out makes me less eager to make a switch right now. The main downside of the current build system is that it relies excessively on docker images and bloats the disk usage, which is painful. Migrating the build system now might be a distraction though because Headway has pretty unique requirements and getting something that works well will take time away from other tasks. I'm currently pushing on #46, and moving towards a planet-scale demo of the system. A friend I trust has offered me a server with enough CPUs for this and 256GB of RAM on a gigabit connection, which should unblock a proper demo site. I'm really hoping that'll help the project attract more contributors who can help with frontend and productionization. That should probably be the priority for now because I think those are the main areas that are really lacking.

Finally found what I was thinking about: Earthly. It seems like it could have a pretty nice migration path from the current setup.

Implemented by #81


use isolated-vm instead of vm?

Questions & Answers
Context of your question
I feel like vm module is not secure enough to allow running arbitrary code and would like to ask, why didn't you instead opt-in for v8 isolates like Deno did?

Yes, we're exploring moving on the implementation to use isolated-vm instead 🙂


Sizle - Front-end

The repo : https://github.com/christoga/sizle
The demo : http://christo.js.org/sizle/
Category: Front-end
Useful for: scale size
Can this be on the repo list?
I create this tool to make my job more easier. :smile:

what are you using for?
looks like a little. please look sample of projects on this list.
this repo name is awesome and certainly a lot of people using it.

I use it to scale image size,
Div size and other things.
Maybe it will go into Front-end Development repo list.

Yeah, but you can make big projects and many people use your project. Its cool and this repo not started for promotion :)
http://contributor-covenant.org
Look http://ibacor.com - https://github.com/bachors He also from indonesia and make great stuff
And don't thumb for starting discuss, it's weird.

Now you child and can make it like this, I think in the future you can make great things. :+1:

I was only testing dude :grin:

I will change the desc in the readme, thank dude :smile:

Ok, nope. :smile:

greatt

Ya @wicky-info . Dia masih smp. Dan ngoding nya lumayan. Hahaha

Thanks dude :smile: :sunglasses: @dikiaap

wow ...kereeen broo ..sukses !!


Add custom origins for Bridge and Verifier modules

This is pretty important to ensure that target applications can trust the messages being passed onto them by the verifier.
See https://github.com/Snowfork/polkadot-ethereum/pull/5/files#r453729105

Obsoleted by #79


[NFL/TV] — Titans vs Colts LiVe 𝐒𝐭𝐫𝐞𝐚𝐦𝐬 FrEe BrOaDcAsT oN tV cHaNnEl 13 October 2024

!@>HERE’S** WAY TO WATCH Titans vs Colts LIVE STREAMS ON TV CHANNEL
Titans-Colts: Start time, channel, how to watch and stream
🔴📺LIVE==►►📲👉NFL LIVE STREAM WEEK 6
🔴📺LIVE==►►📲👉NFL LIVE STREAM WEEK 6
🔴📺LIVE==►►📲👉NFL LIVE STREAM WEEK 6
Tennessee Titans vs Indianapolis Colts score today: Live updates, stats, how to watch, game predictions
The Indianapolis Colts and wide receiver Alec Pierce meet the Tennessee Titans, led by quarterback Will Levis in Week 6 of the NFL season on Sunday, Oct. 13, 2024 (10/13/24) at Nissan Stadium in Nashville, Tenn.
How to watch: Fans can watch the game for free via a trial of DirecTV Stream or fuboTV. You can also watch via a subscription to Sling TV, which is offering $10 off your first month.
Here’s what you need to know:
What: NFL Week 6
Who: Colts vs. Titans
When: Sunday, Oct. 13, 2024 (10/13/24)
Where: Nissan Stadium
Time: 1 p.m. ET
TV: CBS
Live stream: fuboTV and DirecTVStream
Colts player to watch
Alec Pierce. The third-year receiver has provided Indy with the big-play threat it’s lacked in recent seasons. He leads the NFL at 28.3 yards per catch, already has established a new single-season career high with three TD catches and last week he almost single-handedly brought the Colts back at Jacksonville with three straight catches for a career-best 134 yards. He’s looking for a strong encore this week.
Titans player to watch
QB Will Levis. He and Anthony Richardson both were drafted in 2023, and Levis has started more games than the fourth overall pick out of Florida. But both are tied with six interceptions this season — most in the NFL. Patrick Mahomes has been picked off six times, but the Chiefs have played five games. Levis has finished only three of his four starts this season after hurting his throwing shoulder trying to run for a first down against Miami.
Key injuries
Colts QB Anthony Richardson (hip) and Pro Bowl C Ryan Kelly (neck) both practiced. The NFL’s 2021 rushing champ Jonathan Taylor (ankle) didn’t in a similar scenario to last week when all three sat out. The Colts also must decide on starting DE Kwity Paye (quadricep) and Pro Bowl CB Kenny Moore II (hip), who also sat out last week. If Richardson misses another game, Joe Flacco will make his second straight start. If Kelly is out, the Colts may starting two rookies — center Tanor Bortolini and right guard Dalton Tucker — with Will Fries on injured reserve following surgery on his injured lower right leg. WR Michael Pittman Jr. has a back injury that may force the Colts to put him on injured reserve. ... Titans QB Will Levis will start after working his way back from an injury to his throwing shoulder that knocked him out of their previous game. ... Two-time Pro Bowl DL Jeffery Simmons said he’ll be back after two weeks because of an injury to his left elbow. The Titans, who declared S Jamal Adams out for this game with an injured hip, put the three-time Pro Bowler on reserve with a non-football injury Saturday. DL Keondre Coburn (knee) will not play.
How to buy Titans vs. Colts tickets
Tickets for Sunday's game on StubHub are priced from $51 before fees.
Titans vs. Colts weather
The National Weather Service forecast for Sunday in Nashville calls for warm temperatures and some wind during the afternoon.


[Web Portal] Modify button styles for user view

Coverage decreased (-0.01%) to 53.345% when pulling e5df7c742a2a68214bce5b762996ac2e2a8f49dc on lchao/AdjustButtonStyle into 1d9c99df260b841727b0ed907da58223246c6b79 on master.


Do success codes get lost now?

For example DoDragDrop returns DRAGDROP_S_DROP on successful drop. However there doesn't seem to be any way to retrieve this value, since windows-rs immediately calls ok() on the HRESULT. And given that DRAGDROP_S_DROP doesn't have the error bit set it is not passed as error in the Result.
Is this an oversight?

If you check here, and place the value of DRAGDROP_S_DROP(262400) where self.0 is, it returns true. but so does DRAGDROP_S_CANCEL(262401). So you want identify which one you got?

That's not really the point. The problem is that you can not get the original hresult, because if positive it never leaves DoDragDrop(). This is what generated DoDragDrop() code looks like:
pub unsafe fn DoDragDrop<'a>(
    pdataobj: impl ::windows::IntoParam<'a, IDataObject>,
    pdropsource: impl ::windows::IntoParam<'a, IDropSource>,
    dwokeffects: u32,
    pdweffect: *mut u32,
) -> ::windows::Result<()> {
    #[cfg(windows)]
    {
        #[link(name = "OLE32")]
        extern "system" {
            fn DoDragDrop(
                pdataobj: ::windows::RawPtr,
                pdropsource: ::windows::RawPtr,
                dwokeffects: u32,
                pdweffect: *mut u32,
            ) -> ::windows::HRESULT;
        }
        DoDragDrop(
            pdataobj.into_param().abi(),
            pdropsource.into_param().abi(),
            ::std::mem::transmute(dwokeffects),
            ::std::mem::transmute(pdweffect),
        )
        // Here a positive HRESULT gets swallowed.
        .ok()
    }
    #[cfg(not(windows))]
    unimplemented!("Unsupported target OS");
}

This potential issue has been acknowledged. I don't know whether this has been missed in the implementation, or OLE just being odd. Either way it's an issue that would need to be addressed.

Yes, I'm considering a few options for dealing with this. One is to preserve the original signature as a fallback (#737) or a custom Result<T> that retains the HRESULT even in the success case. I'd prefer the latter because the former would lead to an explosion of the API surface or two different flavors of the Windows API, which I'd like to avoid.

For me custom result object would definitely solve the issue. The object could also implement Deref/DerefMut for convenient access to actual value.

I'm unsure which way to achieve this is best. Result is used a lot in the ecosystem, and people will expect any type named Result to behave like std::result::Result does (with its many helper methods).
Two variants I see:

Methods return std::result::Result<SomeWrapper<T>, window::Error>. The SomeWrapper derefs to the inner T so the inner T's methods can still be used. Passing this value to methods which expect T will require a call to some method like into() or using deref doing *wrapper.
Methods return windows::Result<T> which derefs to std::result::Result<T, windows::Error> but also contains the success HRESULT. This makes pattern matching more difficult though as the user would either have to deref the value to cast it to std::result::Result or use whatever structure windows::Result<T> uses.

The vast majority of APIs behave nicely and only ever return S_OK on success.  For those that return S_FALSE or any of the other non-error result codes, we should get those tagged in the metadata so that projections can behave differently.  I don't think that this problem will be unique to rust.

I love @damyanp's suggestion. He's absolutely right of course. The vast majority of APIs don't need this and penalizing every API to accommodate the handful that use odd success codes doesn't make sense. Transferring to the win32 metadata repo - hopefully they can add an attribute to such functions/methods and then languages like Rust can simply project their signatures accordingly.


I have Component with props { foo: string };
Then I will perform mapping:
type ContainerProps = {
  bar: number
}
type ComponentProps = {
  foo: string
}

const Composed = inject<ComponentProps, ContainerProps>((stores, props) =>
    ({ foo: stores.some[props.bar]}))(Component);

The problem is that the returning component has props of type ComponentProps. so, when I try to use this component:
<Composed bar={4}  />

I get error that foo parameter is missing. That's obviously incorrect, as the composed component should only receive bar.

Looking at the definition:
export function inject<P>(...stores: string[]): (<TFunction extends IReactComponent<P>>(target: TFunction) => (TFunction & IWrappedComponent<P>)); // decorator signature
export function inject<T, P>(storesToProps : IStoresToProps<T, P>): (<TFunction extends IReactComponent<T | P>>(target: TFunction) => (TFunction & IWrappedComponent<P>)); // decorator

This did the trick
export function inject<P>(...stores: string[]): (<TFunction extends IReactComponent<P>>(target: TFunction) => (IReactComponent<P>)); // decorator signature
export function inject<T, P>(storesToProps : IStoresToProps<T, P>): (<TFunction extends IReactComponent<T | P>>(target: TFunction) => (IReactComponent<P>)); // decorator

Not sure if it is what you meant, but in my opinion it is more correct. But I'm probably wrong here ;) What is the reasoning of the returning component also having props of the wrapped component?

I think this is a duplicate of #256 ?


afterSend test: Replace fs.existsSync with the async counterpart

It seems existsSync will be deprecated, despite the async being uglier might make more sense?
-- @flockonus  https://github.com/axiomzen/express-interceptor/pull/24#discussion_r34631491

https://github.com/axiomzen/express-interceptor/blob/master/tests/afterSend.test.js

fs.exists() is an anachronism and exists only for historical reasons. There should almost never be a reason to use it in your own code.
In particular, checking if a file exists before opening it is an anti-pattern that leaves you vulnerable to race conditions: another process may remove the file between the calls to fs.exists() and fs.open(). Just open the file and handle the error when it's not there.
fs.exists() will be deprecated.
https://nodejs.org/api/fs.html#fs_fs_exists_path_callback

Apparently the same is true for fs.exists.

Replaced this issue with the PR #28

Sidenote @gustavnikolaj : You shouldn't close an issue that is not fixed yet (not merged into master).

Oh, sorry about that. I just thought that the PR would replace the issue, and that was where we would continue the discussion. :-)

Agreed, also it's the beauty of the syntax Fixes #26 it just auto closes :)


End up with ..* in the label

Precheck

Do not use the issues tracker for help or support, try Stack Overflow.
For bugs, do a quick search and make sure the bug has not yet been reported
Finally, be nice and have fun!

Environment

Ruby ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux-gnu]
Rails 5.2.3
Simple Form 4.1.0

Current behavior
I added my first simple_form and for some reason I'm getting a ..* in front of my labels (email and password). any help would be appreciated
  <%= simple_form_for session_path(resource, as: resource_name, url: session_path(resource_name)) do |f| %>
  <%= f.label :email %>

  <%= f.input_field :email %>
  <%= f.error :username, id: 'user_name_error' %>
  <%= f.input :email, label:'Password', required: true, error: 'Password is mandatory, please specify one' %>
  <%= f.button :submit, "Login", id: "LogInButton" %>
  <% end %>

Expected behavior
The labels should read "email" or "password" not "..Email" or "..Password".

Please use StackOverflow for questions/help, where a wider community will be able to help you. We reserve the issues tracker for issues only.

I had this issue too, and it would be pretty easy for the simple_form maintainers to change, so it might be worth looking into. At the very least, I'd like to help if someone else runs into the problem using the gem combination I'm using. On a new rails 5.2.3 app, with bootstrap 4.3.1 and simple form 4.1.0,  I had the same issue with an ellipses under the asterisk.
I found a way to solve it, since it actually only happens when using the  tag. In locales/simple_form.en.yml, if you remove mark: '*', and change html: '*' to html: '*', this removes the ".." that appears under the asterisk. This occurs because there's an included style with bootstrap that adds an underlined dotted border to any abbreviation tags, which allow the user to select that text in order to view the rest of the word.
The reason I think it seems to make more sense to change this in simple_form is because there's more functionality with the bootstrap feature, and because there isn't a case where we need that functionality with the required asterisk in simple_form. It seems like it's simple enough to just replace  with . Hopefully this helps, and I'd be happy to submit a quick PR if you'd be interested in the change! :)


Creation of Poker subgames.

This PR implements creation of (possibly randomized) subgames in full-deck game of Poker, i.e 4 suits, 13 cards.
I attempt to replicate the libratus endgames although I am not entirely certain I understood the format correctly. If you happen to know exploitability of some small subgame (like subgame 4) that would be a good test to make.
It is now possible to create these subgames either by calling LoadGame("universal_poker(...)") with appropriately set parameters or by calling leduc_poker::MakeRandomSubgame( ... params ...). See the tests for an example.
The code can be extended to general implementation (different settings than HUNL) in subsequent PR.
Feel free to update the nomenclature / other parts of the code, I am not so well-versed in Poker terminology :)
@lifrordi  can you take look?

One test is failing due to not finding the proper test file... I added this and thought it should work, as it should be absolute path?
https://github.com/deepmind/open_spiel/pull/549/files#diff-8c2ac33c5241a858de3fe1534cfe8cf3bd9ba7e9de52be3fe036181b05f3ad73R578

Thanks, @ElnazDavoodi can you please have a look?

I just noticed I made a mistake, the chance probs would implicitly convert from int to doubles, this would lead to a very hard-to-detect bug ... I think a good way to really make sure the code is correct is to compute subgame's game value in another codebase and check this is indeed correct (via sequence-form LP on the loaded game).

@michalsustr @ElnazDavoodi is this ready to import now?


Format controller.dart of flutter_test

Format controller.dart of flutter_test
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan that's on me, sorry!
I felt this was a trivial change and was hoping to either close this one or land it quickly, especially since the upcoming autoformatter adoption will make this change obsolete.
I assumed the bot comment was a false positive and that a whitespace only change was auto-exempt. I should have double-checked the tree hygiene page; will do that next time.


Consider allowing 'unordered' verification inside 'ordered' verification.

Just a thought, not sure as to feasibility:
Phony::inOrder(
    $a,
    $b,
    Phony::anyOrder(
      $c,
      $d
    ),
    $e
);

Would allow for either:

a, b, c, d, e
a, b, d, c, e

This would ease construction of verification when it's critical that some calls happen before/after a group of calls, which seems to be quite common.

@koden-km look at all this miraculous bullshit.


fix(monitor): fix storage tag

What this PR does / why we need it:
Does this PR need to be backport to the previous release branch?:

release/3.5
release/3.6
release/3.7

/cc @zexi
/area monitor

Codecov Report

Merging #11172 (391b8b5) into master (8685e96) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11172      +/-   ##
==========================================
- Coverage    5.81%    5.57%   -0.25%
==========================================
  Files         899      518     -381
  Lines      138867    90536   -48331
==========================================
- Hits         8080     5047    -3033
+ Misses     130080    85087   -44993
+ Partials      707      402     -305

Flag
Coverage Δ

aFlag
5.57% <ø> (-0.25%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/validators/validators_cert.go
37.06% <0.00%> (ø)

pkg/cloudcommon/db/project.go

pkg/util/nodeid/nodeid.go

pkg/cloudcommon/db/managed.go

pkg/lbagent/models/keepalived.go

pkg/baremetal/utils/raid/raid.go

pkg/multicloud/ecloud/storage.go

pkg/util/stringutils2/stringutils.go

pkg/cloudcommon/db/keystonecache.go

pkg/apigateway/clientman/clientman.go

... and 372 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8685e96...391b8b5. Read the comment docs.


Implement request-responses protocols

Close #5536
Relates to #6604 #5433
Introduces a convenient API for request-response protocols to the NetworkService.
In order to use them, a new field is introduced in NetworkConfiguration that lets you specify the list of supported request-response protocols. As part of this field, you can pass a channel where incoming requests will be sent and can be answered.
Afterwards, call NetworkService::request in order to perform a request. This is a simple asynchronous method that returns a Result<Vec<u8>, SomeError>.
Request and responses are simply exposed as Vec<u8>, which I think ends up being less confusing than an API that automatically encodes/decodes requests and responses. Contrary to libp2p, we can't provide strong typing in Substrate because generics would cascade too much everywhere.
I went for an API that only allows sending requests to nodes we're already connected to, as request-reponse protocols aren't meant to be used to send requests to random peers, but rather to complement notifications. You are expected to start a request in response to a received notification, and not out of nowhere.
I've also modified the request-response-related metrics. in_total and out_finished have been replaced with in_success_total, in_failure_total, out_success_total and out_failure_total. The success variants include the time the request/response took, and the failure variants include the reason for the failure. Considering that requests/responses are very unidirectional in nature, it does make sense to me to not merge the in and out variants together.
This PR is marked as "inprogress" because tests haven't been written yet, but it can already be reviewed and feedback given.
Known caveats

Since there is now a channel between the network and the task that builds responses, and that channel has limited capacity, if a peer floods the local node with expensive requests, then we will start dropping the requests made by other peers. This isn't something new, and is the definition of a DoS attack. Before this PR, however, DoS attacks will slow down the entire networking of the node, while after this PR it will cause requests to be dropped (without slowing down the networking, hopefully). Ideally, there should be a mechanism that guarantees some equal distribution of the requests based on their origin, so that even if a node sends us thousands of requests, we will also process requests made by other nodes. An issue should be opened about that after this PR is merged.

Ideally I'd prefer to not do that, but we might have to provide a register_request_response_protocol method on the network service, in order to integrate it in Polkadot.

Future work
We could rather easily change sync/block-requests/finality-proof-requests/light-client-requests to become based on top of this API in the future. An issue should also be opened about this.

My review is in progress and will be finished later today.

Is it really beneficial to build-in the inbound request handling via requests_processing, pending_responses, InboundError::Busy etc. in this way as compared to just emitting an event for every inbound request on the API and offering NetworkWorker::respond complementary to NetworkWorker::request, analogous to libp2p-request-response? Essentially leaving it to client code how many, if any, queues are used per protocol, how to react to "too many requests" etc.?

In practice, the NetworkWorker is completely owned by sc-service, and exposing it to Polkadot would be a huge refactoring task. The API that we want general users to use is NetworkService.
These queues of incoming requests have to exist somewhere, and this PR implements them inside of the NetworkWorker. I don't really see any better solution that wouldn't involve a refactoring of sc-service.

It seems quite unfortunate that despite being "generic" (i.e. Vec) over protocols, requests and responses, the implementation needs to employ one RequestResponse behaviour per protocol with all the associated additional implementation complexity and runtime overhead. As far as I can tell, the only thing that stands between the usage of a single RequestResponse behaviour is the ability to have different request timeouts and protocol support per protocol. If this is true, it may be worth thinking about adding fn protocol_support(Self::Protocol) -> ... and fn request_timeout(Self::Protocol) -> ... to RequestResponseCodec with default implementations that are either complementary or complete replacements for the corresponding configuration done in RequestResponseConfig and RequestResponse::new. The idea would be that the GenericCodec then contains an Arc to a map of protocol configurations built at initialisation, which it can consult for: request timeout, protocol support, max payload sizes, ... If I didn't overlook a substantial roadblock and there is interest in this idea, I could prepare a libp2p PR for further discussion and this is not something that needs to stall this PR since it concerns implementation details and could be a subsequent refactoring.

I don't really have a strong opinion on the question of one-behaviour-per-protocol vs one-behaviour-that-groups-everything.
I'm not opposed to doing the changes in libp2p that allow that.
Unfortunately I'd strongly advocate for not blocking this pull request on this concern. I do realize that if I had answered this comment earlier, we could have done the change by now, sorry for that.
Similarly, since https://github.com/libp2p/rust-libp2p/pull/1715 isn't ready quite yet, I'd strongly prefer to merge this pull request beforehand. The work on Polkadot's collation protocol is blocked on this PR.

As mentioned, I'd like to merge this in the very near future.
I do realize that this PR isn't ideal, but this feature is quite important for parachains and we can't afford to take months to reach the perfect design.
Between merging this PR now and improving the feature later, and writing higher-level protocols using work-arounds, the former is very strongly preferable.

bot merge


Remove python3Packages.toonapi package

Project description
I'm the author of the source of the package, considering the way other requests have been handled by this project. I don't want to be associated with the project in any way.
Therefore requesting removal of packages associated with me, and upstream written by me.
Please remove: python3Packages.toonapi

Locked for now. Please see https://github.com/NixOS/nixpkgs/issues/126677#issuecomment-860071285.

I'm closing this request, as we seem to have reached an understanding.


Bosh level Autoscaling of component

Hi Team,
Is there a way to get cpu utilization/ metric of cf components and spin up an instance through bosh?

The core BOSH director does not currently have functionality for reactive scaling based on that information. Some basic metrics (e.g. CPU, memory, disk) are emitted by health monitor which you can forward to external systems, and you may be able to respond to those metrics within those systems; but no, there's not built-in support for this.

Closing as stale


windows 7 install

I am on windows 7  (ok poor me) as it is my dev platform . I try following your instructions on get-started.html. Now I have node 2.10.1 installed and step 3 fails:
Node modules not yet installed, attempting ...
events.js:85
throw er;     //unhandled 'error' event
or this image

I assume that this is the reason the src folder in a test project contains a script that does not exiist:

I must be missing a key step as it is hard to believe this is released code and if so where is QA

+1

This is related to the famous command line utility.
The same issue has already been filed there: Famous/famous-cli#11

I have to run "sudo famous dev" on my mac to get it to install the packages, might be worth mentioning on the tutorials as someone new to the Terminal and password protected might despair at this stage ; )

You need to install de dependencies first:
npm install
Then run:
famous dev

Closing this as fixes were merged into the CLI. https://github.com/Famous/famous-cli/issues/11
https://github.com/Famous/famous-cli/commit/92fbc75a0f7409c495bf75786d82baba531d9cbf

I have no idea how your merge process works but I am thinking if I do a new npm install -g famous-cli then I should pick up the changes. I tried doing this and things actually got worse as now famous command line is not found. I tried the process on a new machine and CLI installs but famous dev fails.
is there a way to unstall the cli on the first machine and do a clean start?
I am the javascript lead of a huge project where we have our own loader and am on verge of installing our loader as it works in windows. woud love to make your stuff work as we might be able to use it in a new project but seems to early.

I put this together as an outline on how to run famous on any version of Windows, as I too wasted countless hours trying to figure out various nuances of how to make all the pieces work together.  The following outline should cover most issues one should face trying to run node.js and famous on a Windows PC:
must have git available from command line (https://git-scm.com/download/win)
must have npm available from command line (install latest node.js for Windows)
make sure git, nodejs modules, and npm are available from command-line (make sure the following directories are on the path; directories may slightly differ based on version of Windows or base install directories):
C:\Program Files\git\bin
C:\Program Files\nodejs
C:\Documents and Settings\Administrator\Application Data\npm
npm cache clean -f  <- force clears node.js cache, just in case
npm install famous-cli -g <- install famous-cli globally
npm install serve -g <- install serve globally (if not, launching "famous dev" will give this warning)
npm install -g <- globally install any additional dependencies that may be needed
to load a famous demo, from the directory of your choice:
famous fork twitterus-tutorial
famous fork carousel-tutorial
trouble-shooting:
npm install npm-install-missing -g <- "npm-install-missing" command-line may help fix missing dependencies
New projects now worked correctly even in the browser with the spinning famous logo (ie. "famous create myFamousProject").
However, when I tried loading the twitterus or carousel demo with "famous dev", it would not listen on port 1618.  I traced it to this line in package.json:
"dev": "npm run watch & serve public/ -p 1618" <- for Windows, have to add "start", which will launch "npm run watch" in a separate Window, allowing the next command (the port listener) to execute...
for Windows, change to:  "dev": "start npm run watch & serve public/ -p 1618"
Finally, while I could now load the "twitterus" project in my browser, I unfortunately couldn't figure out why I could only see the "Home" header and nothing more in either Chrome or Firefox.  Perhaps someone else has an idea on this one.  I found no errors on the javascript Developer Console either.
However, the carousel demo seemed to work perfectly after the above change was made to package.json!

I figured out what to do to get "twitterus" working as well.  It seems the version downloaded via "famous fork twitterus-tutorial" is broken.  To get it working properly, download and unpack this file:
https://github.com/Famous/lesson-twitterus-starter-kit/archive/step-7.zip
Then add "start" to line 11 of package.json, so it should read:
"dev": "start npm run watch & serve public/ -p 1618"
Now run "famous dev" and go to your browser and it should work!


make ls more ls, add slash / after dir name

before:
(env_esptool) λ ampy -p COM7 ls
boot.py
lib

after:
(env_esptool) λ ampy -p COM7 ls
boot.py
lib/

I'm not sure you want to do this by default, for the same reason that ls doesn't do it by default (ls requires the -F flag to produce folder decorations like that): if you're relying on the command to generate a list of filenames for input to a subsequent script, you don't necessarily want the filename decorations.

Yeah agreed let's keep the current behavior without appending slashes as its easier to parse with tooling--thanks for sending the pull!


Nested Resource Suspense causes stack overflow

Describe the bug
I have a Component that uses Suspense to asynchronously load a Vec<String> from the server representing a list of file names in a directory. Once loaded I want to show the list to the user right away, and then asynchronously load in a thumbnail image for each file.
Each FileComponent retrieves it's thumbnail URL from the server via a respective Resource (as the thumbnail may not yet exist). Like so:
#[component]
fn Component() -> impl IntoView {
    let files = Resource::new(|| (), |_| async move {
        get_files_on_server().await
    });

    view! {
        <Suspense>
            <For
                each=move||files.get().unwrap()
                key=|file| file.clone()
                let:file
            >
                <FileComponent file=file />
            </For>
        </Suspense>
    }
}

#[component]
fn FileComponent(file: String) -> impl IntoView {
    let thumbnail = Resource::new(|| (), |_| async move {
        get_file_thumbnail_on_server().await
    });

    view! {
        <Suspense>

        </Suspense>

{ file }

    }
}

When the list of files returned by get_files_on_server() surpasses around 300, the server will throw an error:
thread 'tokio-runtime-worker' has overflowed its stack
fatal runtime error: stack overflow

I don't think it's infinite recursion, because lowering the file count to below 300 results in no error thrown.
Alternatively, removing the FileComponent Suspense (leaving the Component Suspense) throws no error either.

Perhaps I'm using Resource incorrectly, maybe the thumbnail should be loaded via a server function?
Leptos Dependencies
leptos = { version = "0.7.0-rc2" }
leptos_meta = { version = "0.7.0-rc2" }
leptos_axum = { version = "0.7.0-rc2", optional = true }
leptos_router = { version = "0.7.0-rc2" }

To Reproduce
I've created marcuswhybrow/leptos-issue-3288 which minimally reproduces the issue.
Expected behavior
Don't incur a stack overflow (and render the app as normal)
Screenshots
N/A
Additional context
N/A

Could you please provide a reproducible example? Without access to versions of those functions that cause the issue I'm not sure there is any action I can take to fix this.

Will do

Hi @gbj, I've create a repo you can checkout which reproduces the error, it's readme gives it some context:
https://github.com/marcuswhybrow/leptos-issue-3288

My suggestion for this pattern would be the following:

Your initial server function returns a list of N images, each with some kind of unique ID (like foo-bar-baz)
You have a plain Axum endpoint that takes image IDs as a path param, and returns the generated image (so, say it's /images/{id}.png or whatever)
You have a single Suspense that renders all the  elements in the list, with their src pointing to that Axum endpoint: so, )

That way it's the  element doing the work, here.

Thank you for your advice (and for Leptos).
Cheers


visibleIf compares numbers from text-type questions like strings

Steps to reproduce the issue:

Paste the following code in the JSON Editor:

{
 pages: [
  {
   name: "page1",
   questions: [
    {
     type: "text",
     name: "Number",
     title: "Enter a number",
     validators: [
      {
       type: "numeric"
      }
     ]
    },
    {
     type: "html",
     html: "
Greater than 1200
",
     name: "Greater",
     visible: false,
     visibleIf: "{Number} > 1200"
    },
    {
     type: "html",
     html: "
Less than 1200
",
     name: "Less",
     visible: false,
     visibleIf: "{Number} < 1200"
    }
   ]
  }
 ]
}

In the Test Survey tab enter the following values: 2, 100, 11111, gggg. After entering each value press Enter.

Expected behavior

When entering 2, the text underneath should say Less than 1200.
When entering 100, the text underneath should say Less than 1200.
When entering 11111, the text underneath should say Greater than 1200.
When entering gggg, the text underneath shouldn't say anything, as we already include validator for numerical values.

Observed behavior

When entering 2, the text underneath says Greater than 1200.
When entering 100, the text underneath says Less than 1200.
When entering 11111, the text underneath says Less than 1200.
When entering gggg, the text underneath says Greater than 1200.

Notes
Text is the only question type that allows entering custom numerical values, for example salary or car mileage. It looks like the values are compared like strings instead of numerical values. The current behavior is a major problem when using numerical value to customize survey logic.

@klvbdmh I may add inputType property to the QuestionText class.
The default is "text". There will be "numeric", "date", "datetime" and other options.
Will it work for you?

@klvbdmh However, I can see, there is an issue with numeric validator as well. I will look at it. Thank you.

@andrewtelnov

I may add inputType property to the QuestionText class.

That would be fantastic.

@klvbdmh It is implemented: https://github.com/andrewtelnov/surveyjs/issues/141

@klvbdmh validation works as expected. It is executed on clicking page next and complete.
I have tried your json with inputType: "number" and it works as expected now. Plus Chrome shows nice spin buttons.
I think, it is a better solution.

Yes, changing inputType to "number" works great now. Thank you.


rfc(git-clone) update repo and post pull script

Looking for thoughts on these two items, I'm willing to submit a PR if we like it.

If the repo already exists, we should fetch updates and perform a ff merge on an opt-in basis.
Something like below, I just added this to my dotfiles.
Might need to rework the merge logic to select the correct branch.

if [ -v PROJECT_DIRECTORY ]; then
  echo "Checking for project updates"
  current_branch=$(git rev-parse --abbrev-ref HEAD)
  # Sync remote changes
  git -C "${PROJECT_DIRECTORY}" fetch origin
  # Apply updates if no conflicts
  git -C "${PROJECT_DIRECTORY}" merge "origin/${current_branch}" --ff-only
fi

After successfully cloning, or performing a ff merge, we should run a "setup script" if found to perform repo specific setup.
This is currently what I have in my dotfiles, doesn't matter if the script is executable or not.

# Prep cloned workspace via any found `coder.bootstrap` executable files in the project directory.
if [ -v PROJECT_DIRECTORY ]; then
  echo "Prepping Project Workspace..."
  find "${PROJECT_DIRECTORY}" -name coder.bootstrap -type f -print -exec bash {} \;
fi

I agree with the proposal if we also add a switch to retain the previous behaviour of the git-clone module.
@johnstcn what do you think?

Re: 1) I think this is fine on an opt-in basis
Re: 2) This could be done as a separate step; there may be cases where this requires specific dependencies that are not yet available inside the workspace?

For me, 2) is out of scope for git-clone.

I like this, working on the same thing for myself; I would like to offer a suggestion: instead of all the different file locations that everybody is using, why not a standardized approach, I prefer myself the location of .coder/bootstrap or .coder/bootstrap.sh in my repositories, gives more flexibility for the future and allows for multiple files/scripts regarding coder workspaces to be organized in a .coder folder just like other platforms have either own folders, .gitlab .github etc. What do yo think?

Sorry I've been MIA for a month.
RE 2) I think it would still be in scope, at least until we can figure out module dependencies. If we added it as a separate module, then we wouldn't be able to tell if the clone completed or not.
I think having a .coder directory makes sense, then we could also match based on the other "init" style scripts that coder uses elsewhere.


Remove comments from tsconfig.json generated by 'tsc --init'

Fixes #46150
Fix the issue where the tsconfig.json generated by tsc --init is unreadable for humans.
A few questions for all before discussion.

Have you actually used tsc --init before?
How many of your projects have tsconfig.json files with a significant number of comments?
In the projects you have encountered, how many of them had tsconfig.json files with a significant number of comments?
What screen resolution do you use, or how many pages do you need to scroll through to view the entire tsconfig.json?
How much time do you spend searching for the actual effective configuration among a large number of comments in your tsconfig.json?
If your project's tsconfig.json is heavily commented, do you remove the comments?
If you dislike comments, how much time and effort do you spend removing them?
If you like the comments generated by tsc --init, how likely is it for the comments' indentation to become disordered when you edit the tsconfig.json configuration?
Does your development environment support formatting tsconfig.json and ensure that comment alignment remains undisturbed?
When formatting tsconfig.json, can you tolerate a misaligned configuration file if the comments' alignment becomes disrupted?

Before
{
  "compilerOptions": {
    /* Visit https://aka.ms/tsconfig to read more about this file */

    /* Projects */
    // "incremental": true,                              /* Save .tsbuildinfo files to allow for incremental compilation of projects. */
    // "composite": true,                                /* Enable constraints that allow a TypeScript project to be used with project references. */
    // "tsBuildInfoFile": "./.tsbuildinfo",              /* Specify the path to .tsbuildinfo incremental compilation file. */
    // "disableSourceOfProjectReferenceRedirect": true,  /* Disable preferring source files instead of declaration files when referencing composite projects. */
    // "disableSolutionSearching": true,                 /* Opt a project out of multi-project reference checking when editing. */
    // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */

    /* Language and Environment */
    "target": "es2016",                                  /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
    // "lib": [],                                        /* Specify a set of bundled library declaration files that describe the target runtime environment. */
    // "jsx": "preserve",                                /* Specify what JSX code is generated. */
    // "experimentalDecorators": true,                   /* Enable experimental support for legacy experimental decorators. */
    // "emitDecoratorMetadata": true,                    /* Emit design-type metadata for decorated declarations in source files. */
    // "jsxFactory": "",                                 /* Specify the JSX factory function used when targeting React JSX emit, e.g. 'React.createElement' or 'h'. */
    // "jsxFragmentFactory": "",                         /* Specify the JSX Fragment reference used for fragments when targeting React JSX emit e.g. 'React.Fragment' or 'Fragment'. */
    // "jsxImportSource": "",                            /* Specify module specifier used to import the JSX factory functions when using 'jsx: react-jsx*'. */
    // "reactNamespace": "",                             /* Specify the object invoked for 'createElement'. This only applies when targeting 'react' JSX emit. */
    // "noLib": true,                                    /* Disable including any library files, including the default lib.d.ts. */
    // "useDefineForClassFields": true,                  /* Emit ECMAScript-standard-compliant class fields. */
    // "moduleDetection": "auto",                        /* Control what method is used to detect module-format JS files. */

    /* Modules */
    "module": "commonjs",                                /* Specify what module code is generated. */
    // "rootDir": "./",                                  /* Specify the root folder within your source files. */
    // "moduleResolution": "node10",                     /* Specify how TypeScript looks up a file from a given module specifier. */
    // "baseUrl": "./",                                  /* Specify the base directory to resolve non-relative module names. */
    // "paths": {},                                      /* Specify a set of entries that re-map imports to additional lookup locations. */
    // "rootDirs": [],                                   /* Allow multiple folders to be treated as one when resolving modules. */
    // "typeRoots": [],                                  /* Specify multiple folders that act like './node_modules/@types'. */
    // "types": [],                                      /* Specify type package names to be included without being referenced in a source file. */
    // "allowUmdGlobalAccess": true,                     /* Allow accessing UMD globals from modules. */
    // "moduleSuffixes": [],                             /* List of file name suffixes to search when resolving a module. */
    // "allowImportingTsExtensions": true,               /* Allow imports to include TypeScript file extensions. Requires '--moduleResolution bundler' and either '--noEmit' or '--emitDeclarationOnly' to be set. */
    // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
    // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
    // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
    // "resolveJsonModule": true,                        /* Enable importing .json files. */
    // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
    // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

    /* JavaScript Support */
    // "allowJs": true,                                  /* Allow JavaScript files to be a part of your program. Use the 'checkJS' option to get errors from these files. */
    // "checkJs": true,                                  /* Enable error reporting in type-checked JavaScript files. */
    // "maxNodeModuleJsDepth": 1,                        /* Specify the maximum folder depth used for checking JavaScript files from 'node_modules'. Only applicable with 'allowJs'. */

    /* Emit */
    // "declaration": true,                              /* Generate .d.ts files from TypeScript and JavaScript files in your project. */
    // "declarationMap": true,                           /* Create sourcemaps for d.ts files. */
    // "emitDeclarationOnly": true,                      /* Only output d.ts files and not JavaScript files. */
    // "sourceMap": true,                                /* Create source map files for emitted JavaScript files. */
    // "inlineSourceMap": true,                          /* Include sourcemap files inside the emitted JavaScript. */
    // "outFile": "./",                                  /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
    // "outDir": "./",                                   /* Specify an output folder for all emitted files. */
    // "removeComments": true,                           /* Disable emitting comments. */
    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
    // "importHelpers": true,                            /* Allow importing helper functions from tslib once per project, instead of including them per-file. */
    // "importsNotUsedAsValues": "remove",               /* Specify emit/checking behavior for imports that are only used for types. */
    // "downlevelIteration": true,                       /* Emit more compliant, but verbose and less performant JavaScript for iteration. */
    // "sourceRoot": "",                                 /* Specify the root path for debuggers to find the reference source code. */
    // "mapRoot": "",                                    /* Specify the location where debugger should locate map files instead of generated locations. */
    // "inlineSources": true,                            /* Include source code in the sourcemaps inside the emitted JavaScript. */
    // "emitBOM": true,                                  /* Emit a UTF-8 Byte Order Mark (BOM) in the beginning of output files. */
    // "newLine": "crlf",                                /* Set the newline character for emitting files. */
    // "stripInternal": true,                            /* Disable emitting declarations that have '@internal' in their JSDoc comments. */
    // "noEmitHelpers": true,                            /* Disable generating custom helper functions like '__extends' in compiled output. */
    // "noEmitOnError": true,                            /* Disable emitting files if any type checking errors are reported. */
    // "preserveConstEnums": true,                       /* Disable erasing 'const enum' declarations in generated code. */
    // "declarationDir": "./",                           /* Specify the output directory for generated declaration files. */
    // "preserveValueImports": true,                     /* Preserve unused imported values in the JavaScript output that would otherwise be removed. */

    /* Interop Constraints */
    // "isolatedModules": true,                          /* Ensure that each file can be safely transpiled without relying on other imports. */
    // "verbatimModuleSyntax": true,                     /* Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting. */
    // "allowSyntheticDefaultImports": true,             /* Allow 'import x from y' when a module doesn't have a default export. */
    "esModuleInterop": true,                             /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables 'allowSyntheticDefaultImports' for type compatibility. */
    // "preserveSymlinks": true,                         /* Disable resolving symlinks to their realpath. This correlates to the same flag in node. */
    "forceConsistentCasingInFileNames": true,            /* Ensure that casing is correct in imports. */

    /* Type Checking */
    "strict": true,                                      /* Enable all strict type-checking options. */
    // "noImplicitAny": true,                            /* Enable error reporting for expressions and declarations with an implied 'any' type. */
    // "strictNullChecks": true,                         /* When type checking, take into account 'null' and 'undefined'. */
    // "strictFunctionTypes": true,                      /* When assigning functions, check to ensure parameters and the return values are subtype-compatible. */
    // "strictBindCallApply": true,                      /* Check that the arguments for 'bind', 'call', and 'apply' methods match the original function. */
    // "strictPropertyInitialization": true,             /* Check for class properties that are declared but not set in the constructor. */
    // "noImplicitThis": true,                           /* Enable error reporting when 'this' is given the type 'any'. */
    // "useUnknownInCatchVariables": true,               /* Default catch clause variables as 'unknown' instead of 'any'. */
    // "alwaysStrict": true,                             /* Ensure 'use strict' is always emitted. */
    // "noUnusedLocals": true,                           /* Enable error reporting when local variables aren't read. */
    // "noUnusedParameters": true,                       /* Raise an error when a function parameter isn't read. */
    // "exactOptionalPropertyTypes": true,               /* Interpret optional property types as written, rather than adding 'undefined'. */
    // "noImplicitReturns": true,                        /* Enable error reporting for codepaths that do not explicitly return in a function. */
    // "noFallthroughCasesInSwitch": true,               /* Enable error reporting for fallthrough cases in switch statements. */
    // "noUncheckedIndexedAccess": true,                 /* Add 'undefined' to a type when accessed using an index. */
    // "noImplicitOverride": true,                       /* Ensure overriding members in derived classes are marked with an override modifier. */
    // "noPropertyAccessFromIndexSignature": true,       /* Enforces using indexed accessors for keys declared using an indexed type. */
    // "allowUnusedLabels": true,                        /* Disable error reporting for unused labels. */
    // "allowUnreachableCode": true,                     /* Disable error reporting for unreachable code. */

    /* Completeness */
    // "skipDefaultLibCheck": true,                      /* Skip type checking .d.ts files that are included with TypeScript. */
    "skipLibCheck": true                                 /* Skip type checking all .d.ts files. */
  }
}

After
/* Visit https://aka.ms/tsconfig to read more about this file */
{
  "compilerOptions": {
    "module": "commonjs",
    "target": "es2016",
    "strict": true,
    "esModuleInterop": true,
    "forceConsistentCasingInFileNames": true,
    "skipLibCheck": true
  }
}

@microsoft-github-policy-service agree

I don't think this should happen, I think it's pretty valuable to have a reference when you use tsc --init

I don't think this should happen, I think it's pretty valuable to have a reference when you use tsc --init

Yes, it's very valuable, but only for the first time.
The tsconfig.json is not an API reference. Maybe you can try creating a project with tsc --init every day. I believe you will spend a lot of time deleting comments because a large number of comments seriously affect the readability of the actual configuration of the project.
The best documentation is code, not comments.
If you do need documentation, as mentioned in the comments, please visit https://aka.ms/tsconfig.

Let’s see if there are a lot of comments in various configuration files in popular repositories
microsoft/VSCode
tsconfig.json
tsconfig.base.json
tsconfig.monaco.json
tsconfig.tsec.json
tsconfig.vscode-dts.json
microsoft/fluentui
tsconfig.json
tsconfig.base.all.json
tsconfig.base.json
tsconfig.base.v0.json
tsconfig.base.v8.json
microsoft/playwright
tsconfig.json
DefinitelyTyped
tsconfig.json
types/*/tsconfig.json

types/webpack/tsconfig.json
types/react/tsconfig.json
types/node/tsconfig.json

Nest
tsconfig.json
tsconfig.spec.json
Vue
tsconfig.json
types/tsconfig.json
angular/angular
tsconfig.json
*/tsconfig.json

aio/tsconfig.json
aio/tsconfig.app.json
aio/tsconfig.spec.json
devtools/tsconfig.json

There are too many cases to support this PR, even Microsoft itself doesn't like writing a lot of comments in tsconfig.json 👍 .

Next, let's check if there are a significant number of comments in the template configuration file located in tsconfig/bases.
tsconfig/bases

bases/bun.json
bases/bun.json
bases/create-react-app.json
bases/create-react-app.json
bases/cypress.json
bases/cypress.json
bases/deno.json
bases/deno.json
bases/docusaurus.json
bases/docusaurus.json
bases/ember.json
bases/ember.json
bases/next.json
bases/next.json
bases/node-lts.json
bases/node-lts.json
bases/node10.json
bases/node10.json
bases/node12.json
bases/node12.json
bases/node14.json
bases/node14.json
bases/node16.json
bases/node16.json
bases/node17.json
bases/node17.json
bases/node18.json
bases/node18.json
bases/node19.json
bases/node19.json
bases/node20.json
bases/node20.json
bases/nuxt.json
bases/nuxt.json
bases/react-native.json
bases/react-native.json
bases/recommended.json
bases/recommended.json
bases/remix.json
bases/remix.json
bases/strictest.json
bases/strictest.json
bases/svelte.json
bases/svelte.json
bases/taro.json
bases/taro.json
bases/vite-react.json
bases/vite-react.json

It can be seen that an excellent tsconfig.json should be clean and tidy, without an abundance of unnecessary comments. However, if comments are considered valuable, they should be added to the tsconfig/bases template configuration. Please consider adding comments there rather than removing them 😭.

Pull requests are for implementing approved features. Please discuss whether or not you think the feature is a good idea in the feature issue.


Registration workflow crashes when registering model outputs with no design

Which is a problem if you want to get the ffx tsnr maps.

Closed with changes in #106