Fix wrong text getting saved on editing second comment on an issue.

Fixes: #5581.

Codecov Report

Merging #5608 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #5608      +/-   ##
=========================================
- Coverage   37.51%   37.5%   -0.01%
=========================================
  Files         322     322
  Lines       47458   47458
=========================================
- Hits        17804   17801       -3
- Misses      27097   27099       +2
- Partials     2557    2558       +1

Impacted Files
Coverage Δ

modules/process/manager.go
76.81% <0%> (-4.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945804f...10482fa. Read the comment docs.


[Docs] Nx automatic installation should have --project flag

Description
When I ran
npm install @ng-doc/add && npx nx g @ng-doc/add:ng-add

It configured the default project, but it was an alternative project that I wanted configured
I believe
npm install @ng-doc/add && npx nx g @ng-doc/add:ng-add --project project-name

Would be a better command on the docs website
I am willing to create a pull request.

I agree 👍 you can create a PR if you want

:tada: This issue has been resolved in version 17.6.13 :tada:
The release is available on:

v17.6.13
GitHub release

Your semantic-release bot :package::rocket:


Design and develop user research study

[ ] Talk to product owner and team
[ ] Determine product owner research goals
[ ] Identify participant types
[ ] Identify and study instruments; wireframes, screen share, prototype
[ ] Develop a research plan

Ongoing in Sprint 2.2

Compliance and Allowance Data User Study


Add PR template

I would like to add a pull request template for this repository. I believe that having a standardized template will help streamline the contribution process, ensuring that all necessary information is included and making it easier for maintainers to review and merge pull requests.
Could you please assign this issue to me under GSSOC'24.

could you refer me to a sample.

You could refer to this https://github.com/Akshat111111/Hedging-of-Financial-Derivatives/blob/main/.github/pull_request_template.md
I have added this pull request template in this repository.

Please add the label of appropriate level as per gssoc guidelines on this issue.


specific drawio file "*.drawio"

Feature request:
When we have many configuration file in XML an inside some drawio description, it is really slow to parse every file to known if it is a drawio file. Then is it possible to add in the drawio open/close a filtering of extension "*.drawio"
Thank you

seem to be added when save (mix with xml but it is good too)


Update login.md

Make it easier to copy curl commands

I did worry about putting the prompt in the commands. There are a lot of them. I can do a bulk search and replace if we want to get rid of them.


Version 3.0 Working Spec

This issue will serve as a working space for what a potential version 3.0 would look like with a new, more dynamic, and more powerful API.
High-Level Goals

The ability to defer type compression (imports) until emission.
Distinct code blocks as objects for composition.
And more, probably...

Deferred Type Compression
Currently, type compression via imports requires knowledge of all types up before the body of the file. In practice, this usually requires an awkward two-pass approach where you determine the imports based on a pass of dynamic contents and then emit the body based on a second pass.
The goal of this is to always emit fully-qualified types from the API and rely on a post-compression phase for emitting imports.
There are multiple ways to approach this. A non-exhaustive list:

Type location-aware parsing of code statements combined with type parameters.
Method which wraps a type in a token that can later be replaced.
Code blocks which are aware of which types they contain. (see below)

Code Block Objects
Objects which represents pieces of code lend themselves naturally to writing emission code in Java. The wins should hopefully be fairly obvious.
There is a potential for API explosion here to cover the diversity of the Java language. A potential also exists for adding an unacceptable amount of boilerplate to the API.

I'm closing this working spec issue.
Deferred type compression is done.
Code block objects are here:
https://github.com/square/javawriter/issues/171


Bugfix: Determination creation UI does not use default messages

In Hypha, the user has the ability to create default determination
messages. These messages were not being properly populated in the UI
shown when creating a determination for an application. This change
fixes that bug.
Fixes #2455

@hawkinsw I have added you to the Hypha repo (you as well @kfogel). Can you move this PR to the Hypha repo so we can run all the tests etc.?
And thanks for fixing this feature!

Closing this and reopening one from a branch within the hypha repo!


Allow more particles sharp and add cache to composite shapes

Description of the problem

When solving the flow around multiple particles with the Sharp solver, there was a too low limit on the number of particles (10)
The alternative of using composite shapes to define the packing was costly because of the multiple boolean operations

Description of the solution

The limit on the number of particles was increased (10 000)
The cache functionality was added for composite shapes

How Has This Been Tested?
No test was added, but all of them still pass.
Documentation
No change was required.

@oguevremont I don't understand why you need this feature? There is already a feature that loads N particles from a file (see https://lethe-cfd.github.io/lethe/parameters/sharp-immersed-boundary-solver/sharp-immersed-boundary-solver.html). Definitely we should write an example that uses this feature.
We can't instantiate 10k particles in the parameter file. It makes debugging the code impossible because generating the parameter file readout becomes a nightmare.
So this can't work. You either have to use the file mechanism (and if it does not work for your application, extend it) or find another solution...


Coordinates lost in URL

 Issue by DenisCarriere
Tuesday Oct 11, 2016 at 19:55 GMT
Originally opened as https://github.com/osmottawa/CrowdiD_archive/issues/2

Since you're using an iFrame (never use iFrames), you are losing all the metadata that the iD editor is pushing to the URL (lat, lng, zoom).
This is very useful when you want to give someone a link with those exact coordinates.

 Comment by DenisCarriere
Friday Oct 14, 2016 at 18:28 GMT

@Monduiz You got lots of work on your plate ;)

 Comment by Monduiz
Friday Oct 14, 2016 at 13:29 GMT

I agree. I will look into changing that after I have resolved the points of interest and the popup.

 Comment by Monduiz
Saturday Oct 15, 2016 at 02:01 GMT

One step at a time!


Add option for custom background image and custom font colors

title, customizablity is always great for users.


Backport: take storageClassConfigMap into account when creating disk patches

Backport of: #555
Signed-off-by: suomiy<EMAIL_ADDRESS>Signed-off-by: Marek Libra<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 2400

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.775%

Totals

Change from base Build 2399:
0.0%

Covered Lines:
4202

Relevant Lines:
4860

💛  - Coveralls

Descoped for 4.2.1, so not merging


remote write lose sample when target is unavailable

What did you do?
I'm using remote write to a receiver, which can be temporary down when updating.
What did you expect to see?
All samples should be evantualy written back when a receiver is running again.
What did you see instead? Under which circumstances?
After upgrading to 2.51.2 from 2.50.1 I started missing samples on a receiver in time when it was not running. I cheked this by quering some metrics samples in both prometheus and receiver. I can see drop in prometheus_remote_storage_samples_total but nothing in prometheus_remote_storage_samples_dropped_total or prometheus_remote_storage_samples_failed_total metrics. So the samples were probraly never tried to send and just skipped.
I'm suspecting changes made in #13583 and shared parameter tail bool between https://github.com/prometheus/prometheus/blob/3b8b57700c469c7cde84e1d8f9d383cb8fe11ab0/tsdb/wlog/watcher.go#L393 and https://github.com/prometheus/prometheus/blob/3b8b57700c469c7cde84e1d8f9d383cb8fe11ab0/tsdb/wlog/watcher.go#L533 First time is used to to tail the wal and second time to skip reading samples of checkpoint. Prior the change it stayed true once set. However now it can revert back to false when processing of samples is paused for some time and then resumed.
Reverting back to 2.50.1 fixed this.
System information
No response
Prometheus version
2.51.2

Prometheus configuration file
No response
Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

Is there any logs in prometheus? When use debug log level, is there any debug logs?

Thanks for the report,
That code also troubled me when I was looking at watcher.go lately, I agree with you.
I left the following comment:

I don't know if this was intentional (I cannot see it explicitly stated)
But I think that in order to help the watcher catch up, we started making it skip samples records now (tail=false here passed to readSegment makes it skip/ignore the samples records)
When this issue was discussed, the case <-segmentTicker.C block https://github.com/prometheus/prometheus/blob/8849b7dcadc2960c70467734efce35d737be25f5/tsdb/wlog/watcher.go#L451-L461 was ignored, even though it seems to be there for this same reason: "read the current segment until the end if a new one is there" and it checks that every segmentCheckPeriod = 100 * time.Millisecond which should be sufficient.

on that PR https://github.com/prometheus/prometheus/pull/13583/files#r1668166164 to check if this was intentional.
And opened https://github.com/prometheus/prometheus/pull/14434 to highlight the issue.

Closed by #14446


CKAN Launched Game Not Loading

I can not get my launched game to load past half way. I uninstalled all my mods to see if that was the problem but it still continues. There's no error code it just doesn't continue to load. CKAN v1.22.3 - KSP <IP_ADDRESS>4

I can not get my launched game to load past half way. I uninstalled all my mods to see if that was the problem but it still continues. CKAN v1.22.3 - KSP <IP_ADDRESS>4

I have a copy of the game so I cant update it...

It could be that CKAN is loading the 32bit version of KSP, which if you've modded it to heck and gone, will crash on loading. Check your Settings - KSP command-line


Implement "Follow mode" for Touchpad

Issue details
Some libraries and a lot of games are starting to use what's called "follow mode" for touchpads/joysticks.
See here: https://user-images.githubusercontent.com/3662930/128244909-184f62c9-b88f-4b6b-ba59-6f18dd76e070.mp4
Notice how the joystick follows your thumb instead of locking it in one spot.
Version of libGDX and/or relevant dependencies
Any
Please select the affected platforms
All

Do you know how this is implemented? Does it require a particular touchpad or drivers? Since, as far as I'm aware, the OS just sees mouse movement and scrolling from touchpads, but maybe the new ones are different from the PS/2 days, with their multitouch and all that? I failed to find any information on the subject - doesn't look like "follow mode" is a common term.

Ohhh, not like a laptop touchpad or physical controller joystick. Me me big dumb-dumb. Yeah, you can probably just set its position to the position where a touchDown event occurs*, then update its position to the difference between touchDragged and the TouchPad's centre point if positive (I have no clue if this makes any sense but just run with it). Also set the Touchpad's touched boolean to true when doing this.
*This is the part I think would be problematic to implement into libGDX itself, because Scene2D actors won't hear about events that occur outside their boundaries. The actor could maybe be made big and a default draw location defined, but best hear a Scene2D's experts opinion on that.

When I tried implementing this using an InputListener on the stage (to detect touches outside of the touchpad's region), whenever I moved the touchpads location the knob got stuck in a single location and couldn't be moved or reset. I tried to find examples but couldn't find any.

It's slightly messy to do with the touchpad in scene2d, but I spent a little time working up a sample. It'll take a bit more to get it right but it's mostly there. I'll try to get the sample posted here tomorrow.

Okay, I modified the TouchpadTest to make a close approximation of the way the Brawl Stars touchpad behaves.
Here's the full code, but the only changes are the InputListener added to the stage:
/*******************************************************************************
 * Copyright 2011 See AUTHORS file.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 ******************************************************************************/

package com.badlogic.gdx.tests;

import com.badlogic.gdx.Gdx;
import com.badlogic.gdx.graphics.GL20;
import com.badlogic.gdx.math.Circle;
import com.badlogic.gdx.math.Intersector;
import com.badlogic.gdx.math.Rectangle;
import com.badlogic.gdx.math.Vector2;
import com.badlogic.gdx.scenes.scene2d.InputEvent;
import com.badlogic.gdx.scenes.scene2d.InputListener;
import com.badlogic.gdx.scenes.scene2d.Stage;
import com.badlogic.gdx.scenes.scene2d.actions.Actions;
import com.badlogic.gdx.scenes.scene2d.ui.Skin;
import com.badlogic.gdx.scenes.scene2d.ui.Touchpad;
import com.badlogic.gdx.tests.utils.GdxTest;
import com.badlogic.gdx.utils.Align;

public class TouchpadTest extends GdxTest {
	Stage stage;
	Touchpad touchpad;

	public void create () {
		stage = new Stage();
		Gdx.input.setInputProcessor(stage);

		Skin skin = new Skin(Gdx.files.internal("data/uiskin.json"));

		touchpad = new Touchpad(20, skin);
		touchpad.setBounds(15, 15, 100, 100);
		stage.addListener(new InputListener() {

			Vector2 p1 = new Vector2();
			Rectangle b = new Rectangle();

			@Override
			public boolean touchDown(InputEvent event, float x, float y, int pointer, int button) {
				if (event.getTarget() != touchpad) {
					// If we didn't actually touch the touchpad, set position to our touch point
					b.set(touchpad.getX(), touchpad.getY(), touchpad.getWidth(), touchpad.getHeight());
					b.setCenter(x, y);
					touchpad.setBounds(b.x, b.y, b.width, b.height);

					// Let the touchpad know to start tracking touch
					touchpad.fire(event);
				}
				return true;
			}

			@Override
			public void touchDragged(InputEvent event, float x, float y, int pointer) {
				touchpad.stageToLocalCoordinates(p1.set(x, y));
				if (touchpad.hit(p1.x, p1.y, true) == null) {
					// If we moved outside of the touchpad, have it follow our touch position;
					// but we want to keep the direction of the knob, so shift to the edge of the
					// touchpad's radius with a small amount of smoothing, so it looks nice.
					p1.set(-touchpad.getKnobPercentX(), -touchpad.getKnobPercentY()).nor()
							.scl(Math.min(touchpad.getWidth(), touchpad.getHeight()) * 0.5f)
							.add(x, y);
					touchpad.addAction(Actions.moveToAligned(p1.x, p1.y, Align.center, 0.15f));
				}
			}

			@Override
			public void touchUp(InputEvent event, float x, float y, int pointer, int button) {
				// Put the touchpad back to its original position
				touchpad.clearActions();
				touchpad.addAction(Actions.moveTo(15, 15, 0.15f));
			}
		});
		stage.addActor(touchpad);
	}

	public void render () {
		Gdx.gl.glClear(GL20.GL_COLOR_BUFFER_BIT);
		stage.act(Gdx.graphics.getDeltaTime());
		stage.draw();
	}

	public void resize (int width, int height) {
		stage.getViewport().update(width, height, true);
	}

	public void dispose () {
		stage.dispose();
	}
}

Visual:

I'm going to go ahead and close this out as it can be done in user code with no changes to libgdx.


Fix kube master hostname check for multicluster hostnames

In image/wrapkubeadm, there's a test for whether a node is kubernetes master. The current test looks for a fixed name of "kube-master":
is_master=
if [[ "$(hostname)" = kube-master ]]; then
  is_master=y
fi

But the hostname for a kube master in a multicluster config wont match the expected kube-master:
root@kube-master-cluster-20:/usr/local/bin# echo $(hostname)
kube-master-cluster-20
root@kube-master-cluster-20:/usr/local/bin#

This check for master should be:
is_master=
if [[ "$(hostname)" == kube-master* ]]; then
  is_master=y
fi

Where this is used:
  if [[ ${is_master} ]]; then
    dind::frob-cluster
  fi

Fixes Issue #218

/lgtm  Good catch, as in multi-cluster mode it will not correctly match the kube-master naming for clusters that have a non-zero cluster ID (e.g. are not the first cluster).

/lgtm

/approve


Revert "Verify that exclusivity access marker producers are well-form…

…ed in SILVerifier."
This reverts commit 88a2b4360dca529d263faf1e3d97e9b9df7e2272.
Reverting while I attempt to reproduce debug mode failures.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci smoke test and merge.


luaharfbuzz breaks tostring

Email from Simon Dales:
When testing I spotted an issue with
tostring().

"Receives a value of any type and converts it to a string in a
human-readable format"[1].

///////////

Run:
//////////////////
for k,v in pairs(luaharfbuzz) do
  print(k,v)
end
//////////////////
Should only fail if your lua, say texlua, hasn't got luaharfbuzz. Else
it should list the elements of the table.

I have a more sophisticated version of this loop that does it
recursively. So your code breaks a recursive list of _G.

//////
I did a couple of versions of the same hack: remove __tostring. Either
subsequently in lua or by commenting out in the sources.

Then the above lua works as the lua manual says it should.

But this breaks the use of tostring in some of your lua code, that
expects the returned string to be an internal value, such as language's
4 letter code.

//////////
2 obvious solutions:
* rename the function, but this probably breaks existing lua code
* fix the __tostring so that it works as the default class behaviour.

Any other better ones?

//////////////////////

[1] https://www.lua.org/manual/5.3/manual.html#pdf-tostring

//////////////////////

Simon

Fixed by #57?


durability parameter does not work anymore on existing objects (health does)

in the past I could create "unbreakable" oaks via e.g. object id=woodwall radius=20 durability=1E30
now the oaks have default durability. Using object id=woodwall radius=20 health=1E30 still works
I also can now change the health of a hovered object, e.g.

I am not sure if this worked in the past.
spawning creature and setting durability aka health still works

Durability and health are the same operations but looks like durability was missing from the allowed operations. I will add it back for the next version.
Thanks foir the report!


Build(deps-dev): Bump @typescript-eslint/parser from 5.34.0 to 5.35.1 (#3946)

Pull request opened by the merge tool on behalf of #3946

Merged in e0c862c98e19f088ce965aaffa6c4d5b3b10d78b


Dependencies problem with qtbase5-dev

similar question to  https://github.com/googlecartographer/cartographer_ros/issues/263
My system is ubuntu14.04.5, ROS is indigo,  kernel  is  Linux PC-11 4.4.0-31-generic.  ROS repositories  is deb http://packages.ros.org/ros/ubuntu trusty main, i don't  want to upgrade my system. Because when i upgrade my system, my WiFi module crashed can not work normally.
When i run rosdep install --from-paths src --ignore-src --rosdistro=${ROS_DISTRO} -y to install cartographer_ros dependencies, output is here:

adv@PC-11:~/jxl_carto_ws$ rosdep install --from-paths src --ignore-src --rosdistro=${ROS_DISTRO} -y
executing command [sudo -H apt-get install -y qtbase5-dev]
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
qtbase5-dev : Depends: libgles2-mesa-dev but it is not going to be installed or
libgles2-dev but it is not installable
Depends: libqt5core5a (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is to be installed
Depends: libqt5dbus5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is to be installed
Depends: libqt5gui5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is to be installed
Depends: libqt5network5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is to be installed
Depends: libqt5printsupport5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is to be installed
Depends: libqt5sql5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is to be installed
Depends: libqt5test5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is to be installed
Depends: libqt5widgets5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is to be installed
Depends: libqt5xml5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is to be installed
Recommends: libqt5opengl5-dev (= 5.2.1+dfsg-1ubuntu14) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
ERROR: the following rosdeps failed to install
apt: command [sudo -H apt-get install -y qtbase5-dev] failed
adv@PC-11:~/jxl_carto_ws$
when i  install  qtbase5-dev with aptitude, output says that there are some confilicts:

adv@PC-11:~/jxl_carto_ws$ sudo aptitude install    qtbase5-dev
The following NEW packages will be installed:
libegl1-mesa{ab} libegl1-mesa-dev{a} libegl1-mesa-drivers{a} libglapi-mesa{a} libgles2-mesa{ab} libgles2-mesa-dev{a} libllvm3.4{a} libmirclient-dev{a} libmirclient7{a}
libmirclientplatform-mesa{a} libmirprotobuf-dev{a} libmirprotobuf0{a} libopenvg1-mesa{a} libqt5concurrent5{a} libqt5opengl5-dev{ab} libwayland-dev{ab} libwayland-egl1-mesa{ab}
mircommon-dev{a} qt5-qmake{a} qtbase5-dev{b} qtbase5-dev-tools{a}
0 packages upgraded, 21 newly installed, 0 to remove and 195 not upgraded.
Need to get 13.2 MB of archives. After unpacking 63.5 MB will be used.
The following packages have unmet dependencies:
libegl1-mesa : Conflicts: libegl1-x11 which is a virtual package.
libglapi-mesa-lts-xenial : Conflicts: libglapi-mesa but 10.1.0-4ubuntu5 is to be installed.
libglapi-mesa-lts-xenial:i386 : Conflicts: libglapi-mesa but 10.1.0-4ubuntu5 is to be installed.
libwayland-dev : Depends: libwayland-client0 (= 1.4.0-1ubuntu1) but 1.4.0-1ubuntu1.1 is installed.
Depends: libwayland-server0 (= 1.4.0-1ubuntu1) but 1.4.0-1ubuntu1.1 is installed.
Depends: libwayland-cursor0 (= 1.4.0-1ubuntu1) but 1.4.0-1ubuntu1.1 is installed.
libwayland-egl1-mesa-lts-xenial : Conflicts: libwayland-egl1 which is a virtual package.
Conflicts: libwayland-egl1-mesa but 10.1.0-4ubuntu5 is to be installed.
libegl1-mesa-lts-xenial : Conflicts: libegl1-mesa but 10.1.0-4ubuntu5 is to be installed.
Conflicts: libegl1-x11 which is a virtual package.
libgles2-mesa-lts-xenial : Conflicts: libgles2 which is a virtual package.
Conflicts: libgles2-mesa but 10.1.0-4ubuntu5 is to be installed.
libgles2-mesa : Conflicts: libgles2 which is a virtual package.
libwayland-egl1-mesa : Conflicts: libwayland-egl1 which is a virtual package.
libqt5opengl5-dev : Depends: libqt5opengl5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is installed.
xserver-xorg-lts-xenial : Conflicts: libegl1-mesa (>= 0~) but 10.1.0-4ubuntu5 is to be installed.
Conflicts: libegl1-mesa-drivers (>= 0~) but 10.1.0-4ubuntu5 is to be installed.
Conflicts: libglapi-mesa (>= 0~) but 10.1.0-4ubuntu5 is to be installed.
Conflicts: libgles2-mesa (>= 0~) but 10.1.0-4ubuntu5 is to be installed.
Conflicts: libopenvg1-mesa (>= 0~) but 10.1.0-4ubuntu5 is to be installed.
Conflicts: libwayland-egl1-mesa (>= 0~) but 10.1.0-4ubuntu5 is to be installed.
qtbase5-dev : Depends: libqt5core5a (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is installed.
Depends: libqt5dbus5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is installed.
Depends: libqt5gui5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is installed.
Depends: libqt5network5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is installed.
Depends: libqt5printsupport5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is installed.
Depends: libqt5sql5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is installed.
Depends: libqt5test5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is installed.
Depends: libqt5widgets5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is installed.
Depends: libqt5xml5 (= 5.2.1+dfsg-1ubuntu14) but 5.2.1+dfsg-1ubuntu14.3 is installed.
The following actions will resolve these dependencies
Keep the following packages at their current version
libegl1-mesa [Not Installed]
libegl1-mesa-dev [Not Installed]
libegl1-mesa-drivers [Not Installed]
libglapi-mesa [Not Installed]
libgles2-mesa [Not Installed]
libgles2-mesa-dev [Not Installed]
libopenvg1-mesa [Not Installed]
libqt5opengl5-dev [Not Installed]
libwayland-dev [Not Installed]
libwayland-egl1-mesa [Not Installed]
qtbase5-dev [Not Installed]

Accept this solution? [Y/n/q/?] q
Abandoning all efforts to resolve these dependencies.
Abort.
adv@PC-11:~/jxl_carto_ws$
when i  sudo apt-get install libgl1-mesa-dev-lts-trusty according to  ros  indigo install link(http://wiki.ros.org/indigo/Installation/Ubuntu) to fix dependency issues, output is:

adv@PC-11:~/jxl_carto_ws$ sudo apt-get install libgl1-mesa-dev-lts-trusty
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package libgl1-mesa-dev-lts-trusty
adv@PC-11:~/jxl_carto_ws$

Any suggestions???

According to this link [https://packages.ubuntu.com/en/trusty/amd64/qtbase5-dev/download](Download Page for qtbase5-dev), You should be able to use any of the listed mirrors by adding a line to your /etc/apt/sources.list like this,  deb http://security.ubuntu.com/ubuntu trusty-security main, then sudo apt-get update , it output like this:

adv@PC-11:~/jxl_carto_ws$ rosdep install --from-paths src --ignore-src --rosdistro=${ROS_DISTRO} -y
executing command [sudo -H apt-get install -y qtbase5-dev]
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
qtbase5-dev : Depends: libgles2-mesa-dev or
libgles2-dev but it is not installable
unity-control-center : Depends: libcheese-gtk23 (>= 3.4.0) but it is not going to be installed
Depends: libcheese7 (>= 3.0.1) but it is not going to be installed
E: Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages.
ERROR: the following rosdeps failed to install
apt: command [sudo -H apt-get install -y qtbase5-dev] failed
And then, according to this link https://packages.ubuntu.com/trusty/libgles2-mesa-dev, install libgles2 with sudo apt-get install libgles2-mesa-dev-lts-xenial, and then again run rosdep install --from-paths src --ignore-src --rosdistro=${ROS_DISTRO} -y, All required rosdeps installed successfully.


Docs: add info about forking and cloning to developer guide

Fixes #745

@googlebot I signed it!

@googlebot I fixed it.


Node/solo miner error

Getting an error when I try to solo mine on my node
fetchWork: invalid GetBlockTemplate response! Ensure that you use Riecoin Core 0.20+ and that it is properly configured and synced!
Unable to get mining data from the server :| !
Failure :| ! Check your connection, configuration or credentials. Retry in 10 s...
Was working yesterday ( did have the node offline for a few hours )

There is certainly an issue at your end, others don't have any problem.
You can ask for further help on Discord if needed, but then be sure to give the full details (configuration files, what you tried to do,...), else we cannot help...

There is certainly an issue at your end, others don't have any problem.
You can ask for further help on Discord if needed, but then be sure to give the full details (configuration files, what you tried to do,...), else we cannot help...


Andromeda crashes if ports aren't entered in initial configuration screen

Dunno if you know about this already, but the initial configuration screen implies that If i leave the port fields blank the defaults will be taken.   If I leave them blank, the app crashes right after I hit submit button.  Filling in the fields with values works.

Huh yeah didn't think of that. Developer UI design strikes again

Fixed this in the latest commit. It'll use a default value now. Next update will include this. Thanks for reporting!


move eslint modules to new @qooxdoo namespace

I moved the eslint qooxdoo packages into the @qooxdoo Namespace. Now the compiler should use this

Full approval, merged, thank you @hkollmann!


[Additional Parameter Request] Codeunit 80 Sales-Post - OnAfterSalesShptLineInsert

Hi Team,
In codeunit 90 we need possibility to have additional checks in the procedure InsertShipmentLine. Standard publisher OnAfterSalesShptLineInsert would suit us if it had additional parameter TempWhseShptHeader: Record "Warehouse Shipment Header" and TempWhseRcptHeader: Record "Warehouse Receipt Header".

local procedure OnAfterSalesShptLineInsert(var SalesShipmentLine: Record "Sales Shipment Line"; SalesLine: Record "Sales Line"; ItemShptLedEntryNo: Integer; WhseShip: Boolean; WhseReceive: Boolean; CommitIsSuppressed: Boolean; SalesInvoiceHeader: Record "Sales Invoice Header"; **TempWhseShptHeader: Record "Warehouse Shipment Header"; TempWhseRcptHeader: Record "Warehouse Receipt Header"**)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Support response file type

property that have type:file with relevant produces (for example application/pdf)


feat(Travis): Don't allow Node.js 8 testing fail

I felt like leaving these just uncommented so it helps in future when people want to add new versions here.
I can also remove them completely (or remove only allow_failures) if you think it's better.

So indeed seems like changin sudo:false to sudo:required in Travis config at another PR #1776 helps Node.js 8 pass.
So let's wait until that gets merged in first and then we can merge this one.

@simison build failed but I don't remember if it was actually green before I merged #1776

#1776 was all green (v6, 7 & 8) :thumbsup:

Yes it was when I merged it. I meant, was this PR green before?

@lirantal nope this was failing for v8, lemme rebase now and let's see again.

Aight, ✅  all green:

great! welcome to squash and merge.


T[keyof T] gives a union and not an intersect of all keys of T

TypeScript Version:  4.0.2

Search Terms:
T[keyof T], union, intersect, generics
Code
const foo = {
  bar: {
    bar_one: 'bar_one val 1',
    bar_two: 'bar_two val'
  },
  baz: {
    bar_one: 'bar_one val 2',
    baz_one: 'baz_one val'
  }
};

class Clazz<T> {
  props: T[keyof T] // acts like T["bar"] | T["baz"] instead of T["bar"] & T["baz"]

  constructor(obj: T) {
    //@ts-ignore
    this.props = Object.assign({}, ...Object.keys(obj).map(k => obj[k]));
  }
}

const quz = new Clazz<typeof foo>(foo);

console.log(quz.props) // { "bar_one": "bar_one val 2", "bar_two": "bar_two val", "baz_one": "baz_one val" }
console.log(quz.props.bar_one) // ok
// console.log(quz.props.baz_one) // error

Expected behavior:
console.log(quz.props.baz_one) should be allowed
Actual behavior:
console.log(quz.props.baz_one) not allowed
Playground Link:
Here
Related Issues:

That's how it's supposed to work under type theory. Here's easier to understand rational without going into theory:
const randomKey = () => Math.random() > 0.5 ? "a" : "b";
// randomKey :: () => "a" | "b"

const v = { a: 100, b: "100" }[randomKey()]
// v :: { a: number, b: string }["a" | "b"]

// you would expect v to be `number | string` right? rather than `number & string`.

You can convert unions to intersections via this type.
+ type UnionToIntersection<U> =
+   (U extends any ? (k: U) => void : never) extends ((k: infer I) => void) ? I : never
+
  class Clazz<T> {
-   props: T[keyof T]
+   props: UnionToIntersection<T[keyof T]>

And now it works
(This issue should be closed with "By Design" label)

The above explanation is correct. Type operations reflect the read type of properties.

That's how it's supposed to work under type theory. Here's easier to understand rational without going into theory:
const randomKey = () => Math.random() > 0.5 ? "a" : "b";
// randomKey :: () => "a" | "b"

const v = { a: 100, b: "100" }[randomKey()]
// v :: { a: number, b: string }["a" | "b"]

// you would expect v to be `number | string` right? rather than `number & string`.

You can convert unions to intersections via this type.
+ type UnionToIntersection<U> =
+   (U extends any ? (k: U) => void : never) extends ((k: infer I) => void) ? I : never
+
  class Clazz<T> {
-   props: T[keyof T]
+   props: UnionToIntersection<T[keyof T]>

And now it works
(This issue should be closed with "By Design" label)

Easy to understand indeed. Thanks for pointing that out and showing the solution!


miss IssueType of UNSAFE_CALL_TO_OPTIONAL_METHOD

the official website document https://fbinfer.com/docs/all-issue-types do not have IssueType of https://fbinfer.com/docs/all-issue-types

POINTER_TO_INTEGRAL_IMPLICIT_CAST
UNSAFE_CALL_TO_OPTIONAL_METHOD

Please make sure your issue is not addressed in the FAQ.

In linters.alhttps://github.com/facebook/infer/blob/master/infer/lib/linter_rules/linters.al


Add MinIO folder and credential creation to Storage repository

This ticket is to update the storage repository https://github.com/Project-MONAI/monai-deploy-storage to support the creation of a specific folder per workflow. Currently this repo has basic MinIO interaction functionality, we need to expand this to support both folder creation as well as credential creation for specific folders/resources.

Temporary credentials then need to be generated to allow access to the specified folder.
2.Create temporary credentials for MinIO (see https://docs.min.io/docs/minio-sts-quickstart-guide.html), and give them permissions to read all input artifact.

@elleyouseewhy  can we close this issue as complete?

Closed


lnd crash after lncli closechannel --force

Background
Tried to force close a zombie channel inactive foe 134 days
Your environment
lnd 0.9.2-beta
Linux btclnd 4.19.97-v7+ #1294 SMP Thu Jan 30 13:15:58 GMT 2020 armv7l GNU/Linux
Bitcoin Core version v<IP_ADDRESS>
Steps to reproduce
lncli closechannel --force 8860eafc5f8570e115bdad8e4e9379ede5f72e496fe8627107a5a2332d7457a9 0
Expected behaviour
close zombie channel
Actual behaviour
[lncli] rpc error: code = Unavailable desc = transport is closing
lnd.log:
2020-04-30 23:32:00.237 [INF] LTND: Active chain: Bitcoin (network=mainnet)
2020-04-30 23:34:16.626 [INF] CHDB: Checking for schema update: latest_version=12, db_version=12
2020-04-30 23:34:16.667 [INF] RPCS: password gRPC proxy started at <IP_ADDRESS>:8080
2020-04-30 23:34:16.667 [INF] RPCS: password RPC server listening on <IP_ADDRESS>:10009
2020-04-30 23:34:16.671 [INF] LTND: Waiting for wallet encryption password. Use lncli create to create a wallet, lncli unlock to unlock an existing wallet, or lncli changepassword to change the password of an existing wallet and unlock it.
2020-04-30 23:40:37.699 [INF] LNWL: Opened wallet
2020-04-30 23:40:38.177 [INF] LTND: Primary chain is set to: bitcoin
2020-04-30 23:40:38.221 [INF] LTND: Initializing bitcoind backed fee estimator
2020-04-30 23:40:38.221 [INF] LNWL: Started listening for bitcoind block notifications via ZMQ on <IP_ADDRESS>:28332
2020-04-30 23:40:38.221 [INF] LNWL: Started listening for bitcoind transaction notifications via ZMQ on <IP_ADDRESS>:28333
2020-04-30 23:40:43.780 [INF] LNWL: The wallet has been unlocked without a time limit
2020-04-30 23:40:43.969 [INF] LTND: LightningWallet opened
2020-04-30 23:40:44.145 [INF] HSWC: Restoring in-memory circuit state from disk
2020-04-30 23:40:44.157 [INF] HSWC: Payment circuits loaded: num_pending=0, num_open=0
2020-04-30 23:40:44.213 [INF] HSWC: Trimming open circuits for chan_id=622332:1781:1, start_htlc_id=2
2020-04-30 23:40:44.536 [INF] LTND: Channel backup proxy channel notifier starting
2020-04-30 23:40:44.536 [INF] ATPL: Instantiating autopilot with max_channels=5, allocation=0.600000, min_chan_size=20000, max_chan_size=16777215, private=false, min_confs=1, conf_target=3
2020-04-30 23:40:44.542 [INF] RPCS: RPC server listening on <IP_ADDRESS>:10009
2020-04-30 23:40:44.559 [INF] RPCS: gRPC proxy started at <IP_ADDRESS>:8080
2020-04-30 23:40:44.564 [INF] LTND: Waiting for chain backend to finish sync, start_height=628318
2020-04-30 23:40:45.397 [INF] LNWL: Started rescan from block<PHONE_NUMBER>0000000001b0d8d51c0ca48c97485f2edd1164d3586b2f2343b925 (height 628317) for 84 addresses
2020-04-30 23:40:48.605 [INF] LNWL: Catching up block hashes to height 628318, this might take a while
2020-04-30 23:40:48.628 [INF] LNWL: Done catching up block hashes
2020-04-30 23:40:48.628 [INF] LNWL: Finished rescan for 84 addresses (synced to block<PHONE_NUMBER>00000000108f550bec8eb344a86e76d5ccde31194dc7e9dd22f8e5, height 628318)
2020-04-30 23:40:48.842 [INF] LTND: Chain backend is fully synced (end_height=628318)!
2020-04-30 23:40:48.869 [INF] PRNF: PeerNotifier starting
2020-04-30 23:40:48.928 [INF] NTFN: New block epoch subscription
2020-04-30 23:40:48.935 [INF] HSWC: Starting HTLC Switch
2020-04-30 23:40:48.935 [INF] NTFN: New block epoch subscription
2020-04-30 23:40:49.063 [INF] LNWL: Removed invalid transaction: (*wire.MsgTx)(0x2c2c320)({
Version: (int32) 2,
TxIn: ([]*wire.TxIn) (len=3 cap=3) {
(*wire.TxIn)(0x2dfbb00)({
PreviousOutPoint: (wire.OutPoint) 3be18fbca03b3500c1467de0a31bfa0e2a1accaa32f1a30eb22907d700aa0b5c:1,
SignatureScript: ([]uint8) {
},
Witness: (wire.TxWitness) (len=2 cap=2) {
([]uint8) (len=72 cap=72) {
00000000  30 45 02 21 00 e4 2c ec  49 cb a6 db c7 fb 88 21  |0E.!..,.I......!|
00000010  59 22 ff 32 19 cc 18 39  39 37 45 1f 49 aa b9 31  |Y".2...997E.I..1|
00000020  af 6c 38 29 c9 02 20 7e  ff 5e 9f d3 fc 5b 93 44  |.l8).. ~.^...[.D|
00000030  9f 30 71 87 9c e6 89 5d  c7 2c 64 c2 df 3e 26 9d  |.0q....].,d..>&.|
00000040  8d 72 0f b3 3b b7 e2 01                           |.r..;...|
},
([]uint8) (len=33 cap=33) {
00000000  02 05 b7 33 59 ec b1 7f  50 b5 ac ea 62 dc 83 28  |...3Y...P...b..(|
00000010  15 1d 4b 8a e1 db 80 81  98 f0 48 ee 3e d1 9e 2b  |..K.......H.>..+|
00000020  d4                                                |.|
}
},
Sequence: (uint32) 0
}),
(*wire.TxIn)(0x2dfbb40)({
PreviousOutPoint: (wire.OutPoint) d9489bd02ca4406392a60d6e778f296ea2cf66edaf3f610061921eedcdf84c5f:1,
SignatureScript: ([]uint8) {
},
Witness: (wire.TxWitness) (len=2 cap=2) {
([]uint8) (len=71 cap=71) {
00000000  30 44 02 20 23 c3 fb 23  52 05 ee 6b 2d 90 de 35  |0D. #..#R..k-..5|
00000010  7e c8 91 4c 5b 9b 24 bb  b6 fa da e0 bf 29 fb d2  |~..L[.$......)..|
00000020  25 ae 64 3a 02 20 24 b9  a3 03 a6 f5 15 06 bb bc  |%.d:. $.........|
00000030  04 d4 6e 34 ca 7f a2 8b  6f bd bd 11 28 4a 83 fb  |..n4....o...(J..|
00000040  94 b8 57 ec 93 2f 01                              |..W../.|
},
([]uint8) (len=33 cap=33) {
00000000  03 71 71 dc 31 10 02 6b  6e 54 2e ee 27 74 0d 94  |.qq.1..knT..'t..|
00000010  e5 88 26 13 ca ee 47 a0  26 e8 e6 ca ef 4c 57 b4  |..&...G.&....LW.|
00000020  e1                                                |.|
}
},
Sequence: (uint32) 0
}),
(wire.TxIn)(0x2dfbb80)({
PreviousOutPoint: (wire.OutPoint) 8831bd4552604b6d350a77be308860aac4bee309bec5c2a33a06959dffeec101:0,
SignatureScript: ([]uint8) {
},
Witness: (wire.TxWitness) (len=2 cap=2) {
([]uint8) (len=72 cap=72) {
00000000  30 45 02 21 00 d5 3a b3  54 99 56 04 81 f2 02 ed  |0E.!..:.T.V.....|
00000010  17 64 ec 3a 76 46 2b c2  8d f9 85 54 47 98 d0 53  |.d.:vF+....TG..S|
00000020  fd e3 75 0e a3 02 20 2d  de 78 b0 2a a5 9e 99 21  |..u... -.x....!|
00000030  21 57 d2 97 86 05 35 f3  8a 47 74 29 81 f2 75 6d  |!W....5..Gt)..um|
00000040  ce db 61 8b bd 32 1f 01                           |..a..2..|
},
([]uint8) (len=33 cap=33) {
00000000  02 d0 e8 b9 75 ff 28 6e  8d 19 05 8e a2 48 1f 5d  |....u.(n.....H.]|
00000010  0d 3d b6 14 a8 3e 27 0f  ef 0a d3 eb 2e 6e 49 5d  |.=...>'......nI]|
00000020  da                                                |.|
}
},
Sequence: (uint32) 0
})
},
TxOut: ([]*wire.TxOut) (len=1 cap=1) {
(*wire.TxOut)(0x2c2c360)({
Value: (int64) 325286,
PkScript: ([]uint8) (len=22 cap=22) {
00000000  00 14 22 4a be ef 2f 91  a5 06 95 e2 a8 92 74 bd  |.."J../.......t.|
00000010  14 47 35 16 d6 71                                 |.G5..q|
}
})
},
LockTime: (uint32) 622147
})
2020-04-30 23:40:49.064 [INF] NTFN: New block epoch subscription
2020-04-30 23:40:49.101 [INF] NTFN: New block epoch subscription
2020-04-30 23:40:49.175 [INF] CNCT: Creating ChannelArbitrators for 3 active channels
2020-04-30 23:40:49.176 [INF] NTFN: New block epoch subscription
2020-04-30 23:40:49.176 [INF] NTFN: New block epoch subscription
2020-04-30 23:40:49.177 [INF] NTFN: New block epoch subscription
2020-04-30 23:40:49.204 [INF] NTFN: New spend subscription: spend_id=3, outpoint=b450e05e740a5da8ef9731ab50770e7f3ddc9aabc4d70533e7ffb9f7531ddda8:0, script=0 e399add0f329b4c9e81ce85bf79e0ec4aad6f75a3f72eaee27b86db71516326a, height_hint=623336
2020-04-30 23:40:49.205 [INF] NTFN: Dispatching historical spend rescan for outpoint=b450e05e740a5da8ef9731ab50770e7f3ddc9aabc4d70533e7ffb9f7531ddda8:0, script=0 e399add0f329b4c9e81ce85bf79e0ec4aad6f75a3f72eaee27b86db71516326a, start=623336, end=628318
2020-04-30 23:40:49.206 [INF] NTFN: New spend subscription: spend_id=1, outpoint=f029b45a579b89dabbd7b80b0ed84215dea37c8acfc0eda13ce9eebb82f8945f:1, script=0 55f813c2b6cace6cec9f9915e80484f01c234c99c451cd9412eb6f5f0965811e, height_hint=628317
2020-04-30 23:40:49.207 [INF] NTFN: Dispatching historical spend rescan for outpoint=f029b45a579b89dabbd7b80b0ed84215dea37c8acfc0eda13ce9eebb82f8945f:1, script=0 55f813c2b6cace6cec9f9915e80484f01c234c99c451cd9412eb6f5f0965811e, start=628317, end=628318
2020-04-30 23:40:49.208 [INF] NTFN: New spend subscription: spend_id=2, outpoint=8860eafc5f8570e115bdad8e4e9379ede5f72e496fe8627107a5a2332d7457a9:0, script=0 01828c8befde6fd248dbd6530b7aad657941b79044d7cbfc5ad41e29e7a5f801, height_hint=628317
2020-04-30 23:40:49.208 [INF] NTFN: Dispatching historical spend rescan for outpoint=8860eafc5f8570e115bdad8e4e9379ede5f72e496fe8627107a5a2332d7457a9:0, script=0 01828c8befde6fd248dbd6530b7aad657941b79044d7cbfc5ad41e29e7a5f801, start=628317, end=628318
2020-04-30 23:40:49.308 [INF] CNCT: Close observer for ChannelPoint(f029b45a579b89dabbd7b80b0ed84215dea37c8acfc0eda13ce9eebb82f8945f:1) active
2020-04-30 23:40:49.464 [INF] CNCT: Close observer for ChannelPoint(8860eafc5f8570e115bdad8e4e9379ede5f72e496fe8627107a5a2332d7457a9:0) active
2020-04-30 23:40:49.505 [INF] CNCT: Close observer for ChannelPoint(b450e05e740a5da8ef9731ab50770e7f3ddc9aabc4d70533e7ffb9f7531ddda8:0) active
2020-04-30 23:40:49.505 [INF] CNCT: ChannelArbitrator(f029b45a579b89dabbd7b80b0ed84215dea37c8acfc0eda13ce9eebb82f8945f:1): starting state=StateDefault
2020-04-30 23:40:49.516 [INF] CNCT: ChannelArbitrator(8860eafc5f8570e115bdad8e4e9379ede5f72e496fe8627107a5a2332d7457a9:0): starting state=StateBroadcastCommit
2020-04-30 23:40:49.938 [INF] CNCT: ChannelArbitrator(8860eafc5f8570e115bdad8e4e9379ede5f72e496fe8627107a5a2332d7457a9:0): force closing chan
2020-04-30 23:40:49.975 [INF] HSWC: Removing channel link with ChannelID(a957742d33a2a5077162e86f492ef7e5ed79934e8eadbd15e170855ffcea6088)
2020-04-30 23:40:50.027 [INF] RPCS: Stopping RPC Server
2020-04-30 23:40:50.027 [INF] RPCS: Stopping SignRPC Sub-RPC Server
2020-04-30 23:40:50.027 [INF] RPCS: Stopping AutopilotRPC Sub-RPC Server
2020-04-30 23:40:50.031 [INF] RPCS: Stopping ChainRPC Sub-RPC Server
2020-04-30 23:40:50.031 [INF] RPCS: Stopping InvoicesRPC Sub-RPC Server
2020-04-30 23:40:50.032 [INF] RPCS: Stopping WalletKitRPC Sub-RPC Server
2020-04-30 23:40:50.032 [INF] RPCS: Stopping WatchtowerClientRPC Sub-RPC Server
2020-04-30 23:40:50.032 [INF] RPCS: Stopping WatchtowerRPC Sub-RPC Server
2020-04-30 23:40:50.032 [INF] RPCS: Stopping RouterRPC Sub-RPC Server
2020-04-30 23:40:50.034 [INF] LTND: Shutdown complete
2020-04-30 23:41:50.875 [INF] LTND: Version: 0.9.2-beta commit=v0.9.2-beta, build=production, logging=default
2020-04-30 23:41:50.876 [INF] LTND: Active chain: Bitcoin (network=mainnet)
2020-04-30 23:44:09.672 [INF] CHDB: Checking for schema update: latest_version=12, db_version=12
2020-04-30 23:44:09.719 [INF] RPCS: password gRPC proxy started at <IP_ADDRESS>:8080
2020-04-30 23:44:09.719 [INF] RPCS: password RPC server listening on <IP_ADDRESS>:10009
2020-04-30 23:44:09.720 [INF] LTND: Waiting for wallet encryption password. Use lncli create to create a wallet, lncli unlock to unlock an existing wallet, or lncli changepassword to change the password of an existing wallet and unlock it.

In the future can you use some pastebin type site for logs, thanks! Also do you have stderr captured so we can see the actual trace?

sorry, my bad

lnd.txt

no errors in lnd.log
my guess is that this process is very memory hungry as I see a spike in memory use after I run lncli unlock

2020-04-30 22:39:51.096 [ERR] HSWC: Unable to find target channel for HTLC settle/fail: channel ID = 622332:1781:1, HTLC ID = 1
2020-04-30 22:39:51.096 [ERR] HSWC: ChannelLink(622332:1781:1): unhandled error while forwarding htlc packet over htlcswitch: Unable to find target channel for HTLC settle/fail: channel ID = 622332:1781:1, HTLC ID = 1

2020-04-30 22:39:51.096 [ERR] HSWC: Unable to find target channel for HTLC settle/fail: channel ID = 622332:1781:1, HTLC ID = 1

You can ignore this error.
Are you launching lnd with some kind of service manager, e.g., systemd? The crash trace won't be shown in the logs.

yes, systemd

Try sudo journalctl -u name_of_lnd_service.

it is the same error there
Apr 30 22:39:51 btclnd lnd[3632]: 2020-04-30 22:39:51.096 [ERR] HSWC: Unable to find target channel for HTLC settle/fail: channel ID = 622332:1781:1, HTLC ID = 1
Apr 30 22:39:51 btclnd lnd[3632]: 2020-04-30 22:39:51.096 [ERR] HSWC: ChannelLink(622332:1781:1): unhandled error while forwarding htlc packet over htlcswitch: Unable to find target channel for HTLC settle/fail: channel ID = 622332:1781:1, HTLC ID = 1
Apr 30 22:41:33 btclnd lnd[3632]: 2020-04-30 22:41:33.776 [ERR] CNCT: Unable to retrieve commitment point for channel(b450e05e740a5da8ef9731ab50770e7f3ddc9aabc4d70533e7ffb9f7531ddda8:0) with lost state: no commit point found. Retrying in 10m0s.
the funny thing is lnd is actually running but when I try to unlock the wallet it stops rpc server as per lnd.txt above

i have tried a few more times, no dice, it's the same problem with that damn zombie channel which shuts down rpc server
lnd.txt

@Roasbeef @wpaulino hate to bother you again. any ideas? this lnd node was created in late 2018 and survived a couple of hardware and software crashes. this is very unfortunate that a single lncli closechannel --force made it non-functional. debugging this crash might be useful for others trying to experiment with lightning on town hardware like rpi. any help is appreciated. thank you

this is the latest result of journalctl -u lnd -f
https://gist.github.com/bereska/2a3e1ff35ea37ed85b8a921ddcf6481a

Thanks for those latest logs, this should help us narrow down the issue. So just to confirm, you see the crash each time you start lnd, or when you go to force close?

@Roasbeef thanks for your response. This happens every time I run lncli unlock

@Roasbeef hi, any news for me?

Apologies for the delay, can you apply this patch and report back with these logged lines:
diff --git a/contractcourt/chain_arbitrator.go b/contractcourt/chain_arbitrator.go
index 552549f46..e257697a7 100644
--- a/contractcourt/chain_arbitrator.go
+++ b/contractcourt/chain_arbitrator.go
@@ -273,6 +273,8 @@ func newActiveChannelArbitrator(channel *channeldb.OpenChannel,
 				return nil, err
 			}

+			log.Infof("local commit: %v", channel.LocalCommitment.CommitTx)
+
 			// Finally, we'll force close the channel completing
 			// the force close workflow.
 			chanMachine, err := lnwallet.NewLightningChannel(
@@ -281,6 +283,7 @@ func newActiveChannelArbitrator(channel *channeldb.OpenChannel,
 			if err != nil {
 				return nil, err
 			}
+			log.Infof("Channel state machine: %v", chanMachine)
 			return chanMachine.ForceClose()
 		},
 		MarkCommitmentBroadcasted: channel.MarkCommitmentBroadcasted,

@Roasbeef it's ok, i know how busy you are, thanks.
Unfortunately I can't do that as mine was a binary install
wget https://github.com/lightningnetwork/lnd/releases/download/v0.9.2-beta/lnd-linux-armv7-v0.9.2-beta.tar.gz wget https://github.com/lightningnetwork/lnd/releases/download/v0.9.2-beta/manifest-v0.9.2-beta.txt wget https://github.com/lightningnetwork/lnd/releases/download/v0.9.2-beta/manifest-v0.9.2-beta.txt.sig tar -xzf lnd-linux-armv7-v0.9.2-beta.tar.gz sudo install -m 0755 -o root -g root -t /usr/local/bin lnd-linux-armv7-v0.9.2-beta/*
Is there another way to apply your patch?
thank you

We could provide you with a binary with the patch applied, but it's probably better for you to build from source and apply the patch yourself, given that we may need to give you additional patches for further debugging.

@Roasbeef @wpaulino sure, happy to help) just compiled with go from source on my rpi. Tried to run lnd again before the patch. It crashes the same way
https://gist.github.com/bereska/46b5a373fd0a36a4d07d07ac993f0bc2
not sure how to apply this patch now as my /contractcourt/chain_arbitrator.go in my arm build seems quite different from the one above in @Roasbeef's patch

lnd status
https://gist.github.com/bereska/0a4a2237585759fe7efbf8c4fe93635d

Ah, that's because you built the master branch rather than v0.9.2-beta. You won't be able to revert now due to a database migration, but this diff should work for you:
diff --git a/contractcourt/chain_arbitrator.go b/contractcourt/chain_arbitrator.go
index f5979ed8..c82f8673 100644
--- a/contractcourt/chain_arbitrator.go
+++ b/contractcourt/chain_arbitrator.go
@@ -10,6 +10,7 @@ import (
        "github.com/btcsuite/btcd/chaincfg/chainhash"
        "github.com/btcsuite/btcd/wire"
        "github.com/btcsuite/btcutil"
+       "github.com/davecgh/go-spew/spew"
        "github.com/lightningnetwork/lnd/chainntnfs"
        "github.com/lightningnetwork/lnd/channeldb"
        "github.com/lightningnetwork/lnd/clock"
@@ -291,6 +292,8 @@ func (a *arbChannel) ForceCloseChan() (*lnwallet.LocalForceCloseSummary, error)
                return nil, err
        }

+       log.Infof("local commit: %v", spew.Sdump(channel.LocalCommitment.CommitTx))
+
        // Finally, we'll force close the channel completing
        // the force close workflow.
        chanMachine, err := lnwallet.NewLightningChannel(
@@ -299,6 +302,9 @@ func (a *arbChannel) ForceCloseChan() (*lnwallet.LocalForceCloseSummary, error)
        if err != nil {
                return nil, err
        }
+
+       log.Infof("channel state machine: %v", spew.Sdump(chanMachine))
+
        return chanMachine.ForceClose()
 }

@wpaulino thank you
here is the log after patching
https://gist.github.com/bereska/a44aa05ea02cb33cd367b99ee996ca46

Looking at your version, it doesn't seem like you're running the binary with the patch:
2020-05-22 13:07:39.613 [INF] LTND: Version: 0.10.0-beta commit=v0.10.0-beta-197-g77a4bc97a7a8e3c29559996a9024a6a6edb52cf3, build=production, logging=default
The commit variable should have a -dirty suffix.

@wpaulino my apologies, here it is
https://gist.github.com/bereska/bd61abf6fc71dd525c925d4d74525565

This should let you boot, if this works then we'll have some new information
diff --git a/contractcourt/chain_arbitrator.go b/contractcourt/chain_arbitrator.go
index 9aa691a9b..f5ce0fc62 100644
--- a/contractcourt/chain_arbitrator.go
+++ b/contractcourt/chain_arbitrator.go
@@ -273,6 +273,12 @@ func (a *arbChannel) ForceCloseChan() (*lnwallet.LocalForceCloseSummary, error)
 		return nil, err
 	}

+	if a.channel.LocalCommitment.CommitTx == nil {
+
+		return nil, fmt.Errorf("nil commitment for: %v",
+			a.channel.FundingOutpoint)
+	}
+
 	// With the channel marked as borked, we'll now remove
 	// the link from the switch if its there. If the link
 	// is active, then this method will block until it
@@ -612,10 +618,11 @@ func (c *ChainArbitrator) Start() error {

 	// Finally, we'll launch all the goroutines for each arbitrator so they
 	// can carry out their duties.
-	for _, arbitrator := range c.activeChannels {
+	for chanPoint, arbitrator := range c.activeChannels {
 		if err := arbitrator.Start(); err != nil {
 			c.Stop()
-			return err
+			log.Errorf("unable to start arb for %v: %v", chanPoint, err)
+			continue
 		}
 	}

@Roasbeef thank you
here is the log
https://gist.github.com/bereska/95fd4d99bdab5ea0a56c93273e6ac1d8

@Roasbeef just fyi I applied this patch on top of the first one

Looks like it panicked again? Can you provide the journalctl logs?

@wpaulino thank you, sure, here it is
https://gist.github.com/bereska/b05834f80dc0c7a5f466ebeca56fd7a3

Ah I see, if you apply just the latest patch @Roasbeef provided, then you should be fine. Ignore any previous ones.

@wpaulino no nice, here is the log:
https://gist.github.com/bereska/27fdfb26718501367394208f464d6276

It's still crashing with the same stracktrace. I suggest running git reset --hard master and only applying the latest patch if you haven't done so already.

@wpaulino thank you
but it's only running the last patch now
commit 3dca3915016ff4be7a94f5707254820c655e2787 (HEAD -> master)
Author: bereska<EMAIL_ADDRESS>Date:   Fri Jun 5 02:13:24 2020 +0300
Revert "lnd crash after force close"

This reverts commit db47a0ce00b2c2a3108ec2b527c17654bfc71a38.

commit cefd7701679c59c3c4c37411549df3d787355fbe
Author: bereska<EMAIL_ADDRESS>Date:   Thu Jun 4 21:54:00 2020 +0300
lnd crash after force close 2

commit db47a0ce00b2c2a3108ec2b527c17654bfc71a38
Author: bereska<EMAIL_ADDRESS>Date:   Sat May 23 00:40:47 2020 +0300
lnd crash after force close

commit 77a4bc97a7a8e3c29559996a9024a6a6edb52cf3 (origin/master, origin/HEAD)
Merge: 64b8aa8f 42ac1879
Author: Wilmer Paulino<EMAIL_ADDRESS>Date:   Thu May 21 19:05:21 2020 +0000

Maybe part of the older patch was included in the latest one due to a conflict? I would go back to the base commit (https://github.com/lightningnetwork/lnd/commit/77a4bc97a7a8e3c29559996a9024a6a6edb52cf3) and re-apply the latest one.

@wpaulino thank you
I did go back to (77a4bc9):
git reset --hard origin/HEAD git clean -ffdx
then adit the file to apply the latest patch:
nano chain_arbitrator.go -c
then stage the changes:
git add . git commit -m "lnd crash after force closechannel
restart lnd, here is journalctl log:
https://gist.github.com/bereska/031973108b230139bc09803a1f2c0a0e

It's still crashing with the same output. It looks like you still have a stray line at contractcourt/chain_arbitrator.go:306 from one of the previous patches.

@wpaulino thank you
I started from scratch:
git reset --hard origin/HEAD
git clean -ffdx
git pull
make clean && make && make install
edited chain_arbitrator.go with the latest patch ONLY
nano chain_arbitrator.go -c
staged the changes and commited locally
git add .
git commit -m "patch for lnd crash after force closechannel
restarted lnd
sudo systemctl restart lnd
still NO dice, here is the log:
https://gist.github.com/bereska/5100b0124eab33f2e27d216f7260dce0
Am I doing something wrong?

@wpaulino is there anything we need to fix to prevent this in the future or can this be closed?

I don't know what caused the issue in the first place (nil commitment), maybe @Roasbeef knows.


[Godot 3.0.2 Stable] PoolArray types not passed by reference in case of function call?

Godot version:
Godot 3.0.2 stable
OS/device including version:
Windows 8.1, 64 Bit
Issue description:
The GDScript documentation states that only base types (int, float, string and the vector types) are passed by value. All other types should be passed by reference. For the built-in Array type this works as expected. But when it comes to Pool#Array types this does not work anymore. The '#' in Pool#Array could be replaced with Int, Byte, Vector2, Vector3, Color, String and Real. In all these cases the resulting Pool#Array is passed by value.
If this is the way it's meant to be then there should be more information within the documentation.
Steps to reproduce:
Section A:
1.) Create a new Godot 3.0.2 Project
2.) Add a node of type 'Node' to the scene
3.) Create the script given below in Section B
4.) Attach the script to the 'Node' node and run the project
Section B:
    extends Node

    func _ready():
        var test_array = [1, 2, 3]
	var pool_array = PoolIntArray()
	pool_array.push_back(1);
	pool_array.push_back(2);
	pool_array.push_back(3);

	print("[test_array] Before function call: " + str(test_array[0]) + " | " + str(test_array[1]) + " | " + str(test_array[2]))
	test_function(test_array)
	print("[test_array] After  function call: " + str(test_array[0]) + " | " + str(test_array[1]) + " | " + str(test_array[2]))

	print("[pool_array] Before function call: " + str(pool_array[0]) + " | " + str(pool_array[1]) + " | " + str(pool_array[2]))
	test_function(pool_array)
	print("[pool_array] After  function call: " + str(pool_array[0]) + " | " + str(pool_array[1]) + " | " + str(pool_array[2]))

    func test_function(arr):
        arr[0] = 4
	arr[1] = 5
	arr[2] = 6

Section C:
With the above script I get the following output:
[test_array] Before function call: 1 | 2 | 3
[test_array] After  function call: 4 | 5 | 6
[pool_array] Before function call: 1 | 2 | 3
[pool_array] After  function call: 1 | 2 | 3

Minimal reproduction project:

Yes, currently PoolXArrays are passed by value, not by reference (actually, they are still by reference, but with copy-on-write functionality).
It is a feature, which, as said by reduz, "works this way to avoid having difficult to trace bugs when sending and retrieving data from servers".
Related/Duplicate: #15265

Is that behavior specific to GDScript? In the example above I see no reason why COW would happen, since there is only one thread writing to the array and nothing else locks it.

Like to second that what @Zylann said. I am trying to get an image via GDNative into a texture. I can make it work but at the cost of leaking the old PoolByteArray at each frame (described here - Godot QA which is obviously a nogo.


emit raw msg of different schema & model type, how to "fromBuffer" based on the buffer object source's schema model type?

Hi all,  this is my first project that requrie sending raw data.
As normal string message, we have emit ( eventName, msg).   what is the proper way to handle the convertion of buffer data from server which are objects based on different schema & model?
Thanks for help.
I am using geckos raw emit method with the buffer generated from typed-array-buffer-schema module's toBuffer method

I have added (https://github.com/geckosio/typed-array-buffer-schema/commit/7b252769dc6e15686f9c4e45f155ce88b8f50e35) both functions as static helper functions to the Schema class.
You will be able to do:
const bufferId = Schema.getSchemaIdFromBuffer(buffer)
const schemaId = Schema.getSchemaIdFromSchema(schema)

I have already changed how it works. I think this is better. What do you think?
// get the schema id
const schemaId = BufferSchema.getIdFromSchema(schema)

// get the id of the top level schema (added via new Schema())
const modelId = BufferSchema.getIdFromModel(model)

// get the id of the top level schema
const bufferId = BufferSchema.getIdFromBuffer(buffer)

hi @yandeu ,  this looks very clear,  without any extra change or data to the schema or model.
I really like it.  Thank you for this quick fix.
I am making a web based mmo 2d game using several popular libs, pixijs, planckjs, threadsjs, your geckosio and the typed-array-buffer-schema, etc.  I might able to contribute to your projects later when I have enough understanding. :)
You did amazing work on this which saved me lots of time ~~


Donut Chart is not Displaying correctly.

Donut Chart is not Displaying correctly. Upon changing the size of screen it shows correctly.

This is happening to me too, as soon as I updated to 9.7,after reverting back it's working for me again.

@dmdevoss @SaadYasir Can you please post how you create this chart. Could you prepare an example that shows this behaviour?

@hansmaad  I am using NativeDroid2 JS Library for mobile development.
Here is link: http://nativedroid.scripter.click/charts/

This happens when we are using one page theme.
When populating values of chart from API ( Web services).

My tweaks: To overcome this solution:
$(document).ready(function() {
$("#loadinggraph").text('Loading Graph....');
$('.nd2-chart').hide();
$('.nd2-chart').delay(3000).queue(function() {
$("#loadinggraph").hide();
showgraph();
$('.nd2-chart').show();
$('.nd2-chart').dequeue();
});
});

Whats the status of this issue?

I moved to a different library so I don't have the specifics of what I did, but to make things work I needed to set heights on the svg pieces.


camerad: combine debayering and rgb_to_yuv opencl kernels

[x] make kernel match previous results
[ ] validate vignetting changes
[ ] test some different local work sizes for best performance

Looks like this breaks snapshot, and some other CI

This will also break some provisioning tests.


[WIP] Support lists to/from the GPU

This is blocked on https://github.com/rapidsai/cudf/pull/6749 going in.  After it is in this will support moving lists to/from the GPU., even nested lists.
There is also some refactoring of the code associated with this to try and make it cleaner/simpler to test/support.
I will likely still add in some tests for existing array operators to be sure that they are working correctly.

build

The dependency has is now in the SNAPSHOT build for cudf so this is no longer WIP


Here I am

Please follow Git messages guidelines next time to make them meaningful, i.e. "Add new member".


Update AboutUs page

Add my picture and update AboutUs doc

Codecov Report

Merging #25 (744be01) into master (1ef6aa1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #25   +/-   ##
=========================================
  Coverage     70.19%   70.19%
  Complexity      415      415
=========================================
  Files            75       75
  Lines          1322     1322
  Branches        137      137
=========================================
  Hits            928      928
  Misses          351      351
  Partials         43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef6aa1...744be01. Read the comment docs.


Is this project already dead?

Sorry to ask, but there was no progress recently, no questions answered, no issues commented, no contact available....
So my simple question is: is this project something to build on, or was it just a quick test?
I'm new to f7, so please bear with me if I'm completely wrong - but it would have been a great starting-point (or even 'is').
andy

Hey Andy, in fact I have current some other prios as we move to another city and we have to prepare everything for our baby. In addition, we expect Framework 2 to habe some update / simplification of the framework. So, there is a future and a more or less robust framework you can use :-)

Hi @scriptPilot ,
thx for the reply - good to hear - and good luck with your baby!!
I am just starting with F7, and checking my options... so app-framework seems to be a good real-world starting point, although some things didn't work as expected. But as I found out in the meantime, the F7 on GitHub is v2 already, but the documentation is still v1... So hopefully the move to v2 is done soon, to get me not even more confused 😉
Cheers

Congrats for your baby! :)
App-Framework works very well, but I really need Cloud Firestore, and I would like to switch soon on F7 v2 while my project is not too big.
The question is: you said "there is a future", but do you have any idea in which timeframe? :)
Thanks a lot for all the work done!


Fix heap pools to assert that the object being released is allocated.

The bitmap object pool has a corresponding assert.  The pool
implementations should not differ in behavior here.
Problem
Double-free not being caught.
Change overview
Catch the double-free.
Testing
Checked that without https://github.com/project-chip/connectedhomeip/pull/22403 this causes commissioning to fail.

Accepted for 1.0: high value fix, this would have caught a bug that was fixed in #22403


Upgrade to Mocha@10

Falling behind on 'mocha' dep here.
Even with mocha@10 there is one related security vulnerability that should be addressed via this issue: https://github.com/mochajs/mocha/issues/4903

This upgrades takes this library from 9 to 10
Here is the relevant changelog: https://github.com/mochajs/mocha/blob/master/CHANGELOG.md
Here are the breaking changes:

[ ] https://github.com/mochajs/mocha/issues/4845: Drop Node.js v12.x support (@juergba)

[ ] not much of an issue, but do need to ensure engines > 12 in package.json if not already set

[ ] https://github.com/mochajs/mocha/issues/4848: Drop Internet-Explorer-11 support (@juergba)
[ ] https://github.com/mochajs/mocha/issues/4857: Drop AMD/RequireJS support (@juergba)
[ ] https://github.com/mochajs/mocha/issues/4866: Drop Growl notification support (@juergba)
[ ] https://github.com/mochajs/mocha/issues/4863: Rename executable bin/mocha to bin/mocha.js (@juergba)
[ ] https://github.com/mochajs/mocha/issues/4865: --ignore option in Windows: upgrade Minimatch (@juergba)
[ ] https://github.com/mochajs/mocha/issues/4861: Remove deprecated Runner signature (@juergba)

Landed in https://github.com/digitalbazaar/bedrock-test/blob/main/CHANGELOG.md#810---2023-04-18


feat(option): to use different samplers

https://github.com/ggerganov/llama.cpp/pull/1126 introduced some new ones. Right now, we use repetition penalty. It does a decent job of avoiding repeated content for a while, but it's certainly not perfect. For example, a large window penalizes a lot of punctuation and causes run-on sentences. We can already change this by excluding tokens from the penalized list, but it's a balancing act that I'm not very good at.
First order of business is to get repeat_penalty working with the new API.

Seems to be working as before.
New sampling parameter defaults in llama.cpp are:
tfs_z = 1.0f;
typical_p = 1.0f;
frequency_penalty = 0.0f;
presence_penalty = 0.0f;

mirostat = 0;  // 0 disabled, 1 for v1, 2 for v2.
mirostat_tau = 5.0f;
mirostat_eta = 0.1f;

Hrm... for mirostat, it looks like we need to remember a mu value across subsequent calls. That's going to be a little tricky to maintain with undoing. Probably should make a structure that wraps the current context and maintains the array of mu values alongside context tokens.


Support SVG for saving snapshots

Enhancement idea.
One currently can save a snapshot of the current worksheet as PNG. It would be nice to be able to save as SVG too, since SVG can be scaled lossless and are more handy in a number of situations.

We've long talks about this with @fthevenet and unfortunately, it appears to be far from trivial. If you need to zoom on your snapshots like me, you might be happy to learn that he recently added an option in the settings to change the scale of snapshots, which results in bigger, more zoomable snapshots (still PNG, but the difference is noticeable).

Thanks for considering it. Never mind then, I will close the issue.


Fix/thread safe localeswitcher line endings

Fixed LocaleSwitcher to be thread-safe and properly restore to the original locale (which may not have been the global one)

Thanks Brian.
After reviewing this I'm starting to think we really should just have a check in the code that raises SIGHUP if locale isn't "C". ;-)

If I never set my eyes on setlocale again, I'll be ok with that.

On Jan 21, 2016, at 12:57 PM, Greg Landrum<EMAIL_ADDRESS>wrote:
Thanks Brian.
After reviewing this I'm starting to think we really should just have a check in the code that raises SIGHUP if locale isn't "C". ;-)
—
Reply to this email directly or view it on GitHub.


Test Only: Edit RATA Test Summary Data

As an ECMPS user, I want the ability to edit RATA Test Summary Data, so that I can make updates to the existing information
Acceptance Criteria:
Given the user clicks on the 'Edit' option in the RATA Test Summary Data section
When the user is on the 'Edit Test Summary Data' modal
Then the system displays the fields applicable
And the user can edit the data
Test Type Code
Unit or Stack Pipe ID (Text)
Monitoring System ID (Text)
Test Number (Text)
Test Reason Code (Dropdown)
Test Result Code (Dropdown)
Begin Date (Date Picker and Text)
Begin Hour (Dropdown 0-23)
Begin Minute (Dropdown 0-59)
End Date (Date Picker and Text)
End Hour (Dropdown 0-23)
End Minute (Dropdown 0-59)
Grace Period Indicator (Radiobutton Yes, No?)
Test Comment (Text)
Given the user has edited RATA Test Summary Data
When the user chooses to save and close
Then the data is saved
And the modal closes
And the user is returned to the Landing page for RATA Data
And the updates are reflected in the RATA Test Summary Data section
Warning message to pop up when a user updates data and closes the modal (Clicks Cancel/X)
Warning message to read: Closing this window will discard any unsaved changes
Invision Board Ref:
https://projects.invisionapp.com/freehand/document/SrHrFhGQ3?zoomToItems=Y2w1bXBuM3NiMDAwNjNiNnlvb3dpaXF1ag%3D%3D
https://projects.invisionapp.com/freehand/document/SrHrFhGQ3?zoomToItems=Y2w1bXBuM3NiMDAwNzNiNnk1aWtyNHA1eQ%3D%3D

Testing
Test Case: TC843
Tester: @JanellC

@addisgmichael @cw-cvp @mosesdeeCVP https://usepa.sharepoint.com/:x:/r/sites/CAMDCVPTeam/Shared Documents/TheEmissioners/3-Business Analysis/Test Data By Test Type Group.xlsx?d=waf4ed2ec4fca4b9aa5fc98b066be240a&csf=1&web=1&e=HGpvFY

TC843 passed


Reorganize example/test notebooks

The example notebooks currently in plot_testing/ should be moved to an examples/ directory.
The current examples/ directory contains PDF files generated by the usage_examples.ipynb notebook. We (DS and KC) discussed offline and agreed these don't need to be in the repo but can instead be moved to a gitignore'd directory like notebook_outputs/ for the user to manually inspect.

Addressed in #33.


Terminal window resize may crash the program

Quickly resizing from big window to small (~25 chars width) crashes the program. Tested using Kitty terminal.
thread 'main' panicked at /home/.../tui-logger-0.11.0/src/lib.rs:1203:33:
attempt to subtract with overflow

Thanks. Fix applied in 0.11.1

Thank you so much!


 Ugh, I guess, I should migrate everything on Github Actions someday.

This day is today!


az security auto-provisioning-setting update doesn't work

Describe the bug
Unable to set auto-provisioning setting to "on" or "off" using CLI.
To Reproduce
az security auto-provisioning-setting update -n default --auto-provision on or
az security auto-provisioning-setting update -n default --auto-provision off
The error is
az security auto-provisioning-setting update -n default --auto-provision on
'on' is not a valid AutoProvision
Traceback (most recent call last):
  File "/home/senthuran/.azure/cliextensions/interactive/azext_interactive/azclishell/app.py", line 659, in cli_execute
    result = invocation.execute(args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 328, in execute
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 386, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 379, in _run_job
    six.reraise(*sys.exc_info())
  File "/opt/az/lib/python3.6/site-packages/six.py", line 693, in reraise
    raise value
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 356, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 171, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/__init__.py", line 441, in default_command_handler
    return op(**command_args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/security/custom.py", line 145, in update_security_auto_provisioning_setting
    new_auto_provision = AutoProvision(auto_provision)
  File "/opt/az/lib/python3.6/enum.py", line 291, in __call__
    return cls.__new__(cls, value)
  File "/opt/az/lib/python3.6/enum.py", line 533, in __new__
    return cls._missing_(value)
  File "/opt/az/lib/python3.6/enum.py", line 546, in _missing_
    raise ValueError("%r is not a valid %s" % (value, cls.__name__))
ValueError: 'on' is not a valid AutoProvision

Expected behavior
The setting is changed and that I can view the update via
az security auto-provisioning-setting list
Environment summary
az -v
azure-cli (2.0.55)

acr (2.1.12)
acs (2.3.14)
advisor (2.0.0)
ams (0.3.2)
appservice (0.2.11)
backup (1.2.1)
batch (3.4.1)
batchai (0.4.6)
billing (0.2.0)
botservice (0.1.4)
cdn (0.2.0)
cloud (2.1.0)
cognitiveservices (0.2.4)
command-modules-nspkg (2.0.2)
configure (2.0.20)
consumption (0.4.2)
container (0.3.11)
core (2.0.55)
cosmosdb (0.2.7)
dla (0.2.3)
dls (0.1.7)
dms (0.1.1)
eventgrid (0.2.0)
eventhubs (0.3.2)
extension (0.2.3)
feedback (2.1.4)
find (0.2.13)
hdinsight (0.2.0)
interactive (0.4.1)
iot (0.3.4)
iotcentral (0.1.5)
keyvault (2.2.9)
lab (0.1.5)
maps (0.3.3)
monitor (0.2.8)
network (2.3.0)
nspkg (3.0.3)
policyinsights (0.1.0)
profile (2.1.2)
rdbms (0.3.5)
redis (0.3.2)
relay (0.1.2)
reservations (0.4.1)
resource (2.1.8)
role (2.3.0)
search (0.1.1)
security (0.1.0)
servicebus (0.3.2)
servicefabric (0.1.11)
signalr (1.0.0)
sql (2.1.7)
storage (2.3.0)
telemetry (1.0.0)
vm (2.2.12)

Extensions:
interactive (0.4.1)

Python location '/opt/az/bin/python3'
Extensions directory '/home/senthuran/.azure/cliextensions'

Python (Linux) 3.6.5 (default, Jan 11 2019, 04:47:05)
[GCC 4.8.4]

Additional context
I've also tested with Cloud Shell and got the same error.

I some digging in the repo to see what the expected values really should be.
It seems that the case stated in the docs does not match what is really required.
Instead of "on" or "off" the values must be
"On"
or
"Off"

I did some digging in the repo to see what the expected values should be.
The case stated in the docs does not match what is really required.
Instead of "on" or "off" the values must be
"On"
or
"Off"

that's correct. properties are case-sensitive.
closing issue due to client error.


id: 1278 Pin guava version to 18

desc: added 18.0 to pom.xml
reviewer: sayrer

Hi @fcalderonnearsoft, thanks for your contribution!
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

You did it @fcalderonnearsoft!
Thank you for signing the Contribution License Agreement.

@spmallette @dalaro is there any chance that someone could check this, please?

ha - that's going to have to be a @dalaro job. did you run the full test suite successfully?

@spmallette Yes, I did! :)

We shouldn't "pin" anything. There will always be version differences between different users. Instead either Titan uses shading or the user shades their jars.

yeah - looks like @dalaro had shading in mind: #1139

@spmallette @okram What do you mean with 'shading' ?

It basically would repackage guava for a particular version under the titan distribution. You can see how it's done here in TinkerPop for gremlin-shaded:
https://github.com/apache/incubator-tinkerpop/blob/49ed3612c54c4e056796d654c24de6bb9496e775/gremlin-shaded/pom.xml
Looking at that, you can see that we repackaged kryo, for example, with a org.apache.tinkerpop.shaded.kryo package name. That's at least one use case of shading anyway.  You should probably read up on the Maven shade plugin to learn more.


Can't reorder columns then some columns hidden.

Hi, I got error. I can't normally drag'n'drop columns then some columns hidden.

react-table-hoc-draggable-columns version 1.2.2
react-table version 6.10.3
Example: https://codesandbox.io/s/adoring-minsky-r23rw?fontsize=14&hidenavigation=1&theme=dark

Hi @NikolaevRoman
You forgot to include the custom css:
import 'react-table-hoc-draggable-columns/dist/styles.css';
Here is a forked example:  https://codesandbox.io/s/stoic-cloud-6izj9

I saw your example.
But if I set prop "show:false" for any column, I can't drag'n'drop columns normally.
Example based on your's: https://codesandbox.io/s/stoic-cloud-6izj9?fontsize=14&hidenavigation=1&theme=dark
Demonstration:

@NikolaevRoman   Thanks, I will look into this issue

@NikolaevRoman Updated the package. Please try with version 1.2.3

Hi, @patricktran
Check version 1.2.3. All work fine.
Thanks.


Take --instrumentation_filter into account in coverage phase

Description

Previously, all Scala code would be instrumented for coverage during a
bazel coverage run instead of only those source files that belong to
targets matching the instrumentation filter.

Motivation

Fixes https://github.com/bazelbuild/bazel/issues/15167.

@omerlh

Thanks, @fmeum!