Auto-saving from copying clipboard

Add feature that can automatically saving the link when copying. Then stored to default that can moved to folder.

Even better would be a button to quickly paste without adding any other option/confirmation
(and removing the  - button that shows the panels, that should be an option under settings)

Hello, @AdityaMH, I'm going to work on this now. If I understood correctly, whenever you copy a link outside Linkora, it should be auto-saved without manual input. Is that what you're saying?

Hello, @AdityaMH, I'm going to work on this now. If I understood correctly, whenever you copy a link outside Linkora, it should be auto-saved without manual input. Is that what you're saying?

Yeah

Hello, @AdityaMH, this cannot be implemented as Android restricts access to the clipboard.

Unless your app is the default input method editor (IME) or is the app that currently has focus, your app cannot access clipboard data on Android 10 or higher.

https://developer.android.com/about/versions/10/privacy/changes#clipboard-data


Symfony 5 support

Sentry is not supporting latest 5.* version of Symfony Framework.
Restricting packages listed in "symfony/symfony" to "5.0.*"
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - sentry/sentry-symfony 3.2.1 requires symfony/config ^2.8||^3.0||^4.0 -> no matching package found.
    - sentry/sentry-symfony 3.2.0 requires symfony/config ^2.8||^3.0||^4.0 -> no matching package found.
    - Installation request for sentry/sentry-symfony ^3.2 -> satisfiable by sentry/sentry-symfony[3.2.0, 3.2.1].

I'm not sure why, but the latest tag does not have the 5.0 version added: https://github.com/getsentry/sentry-symfony/blob/3.2.1/composer.json

It's already supported, but not released yet (I don't know why)
https://github.com/getsentry/sentry-symfony/issues/272
I'm also waiting to the release to be able to update some systems, in the midtime you can point to dev-master in your composer.json like this:
"sentry/sentry-symfony": "dev-master"

Any news on this @dcramer?

Most devs are on vacation right now, we will deal with this early January. Please do not ping individual ppl this will not speed up the process.
Thanks!

Any news on this?

Nah, they have no idea what the problem is.

Sorry for the delay, 3.3.0 is out! https://github.com/getsentry/sentry-symfony/releases/tag/3.3.0

I think something went wrong, because there are no changes between 3.2.1 and 3.3.0:
https://github.com/getsentry/sentry-symfony/compare/3.3.0...3.2.1

Yes, we already got reports about this: https://twitter.com/AlessandroLai/status/1217034197883375622
Something went wrong while releasing. We're fixing it, it seems correct now: https://github.com/getsentry/sentry-symfony/compare/3.2.1...3.3.0

Thanks for fixing and clarifying 👍

Issue with the tag is tracked in #297, already solved with 3.3.1.


Added Unit Tests

Adding Unit Tests and Fixing Errors

Codecov Report

Merging #13 into master will increase coverage by 12.04%.
The diff coverage is 0.76%.

@@            Coverage Diff             @@
##           master     #13       +/-   ##
==========================================
+ Coverage   27.85%   39.9%   +12.04%
==========================================
  Files          27      27
  Lines        1777    1689       -88
==========================================
+ Hits          495     674      +179
+ Misses       1242     977      -265
+ Partials       40      38        -2

Impacted Files
Coverage Δ

flasharray/pod.go
0% <0%> (ø)
:arrow_up:

flasharray/user.go
0% <0%> (ø)
:arrow_up:

flasharray/smtp.go
0% <0%> (ø)
:arrow_up:

flasharray/pgroup.go
0% <0%> (ø)
:arrow_up:

flasharray/offload.go
0% <0%> (ø)
:arrow_up:

flasharray/snmp.go
0% <0%> (ø)
:arrow_up:

flasharray/vgroup.go
0% <0%> (ø)
:arrow_up:

flasharray/network.go
100% <100%> (+100%)
:arrow_up:

flasharray/flasharray.go
28.19% <0%> (+2.12%)
:arrow_up:

flasharray/message.go
24% <0%> (+24%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d85e217...d5a8da5. Read the comment docs.


Create folders return split by datatype

This PR splits the output of create_folders by datatype. Now a Dict is returned with datatypes as keys and a list of created paths as values. If no datatype is created the dict keys are sub or ses.
Test and docs are updated. closes  #374.

Thanks @niksirbi for these catches 😱 a lot of mistakes! These should all be fixed now, I added a test to cover the previously broken behaviour. Cheers!


Connection Acquisition Hangs  After Network Disturbance.

Hello,
This is a follow-up to [https://github.com/brettwooldridge/HikariCP/issues/602](Issue #602). I closed the issue after upgrading and doing some more investigation, but I'd like to see if you have any suggestions for how to deal with this issue.
Same stack: Spring, HIbernate 4, Tomcat 7, Java 8, MySql 5.5. We're using the latest version of hikari (Currently 2.5.1), and still having intermittent failures.
I don't believe that this is a bug in the connection pool, but in our corporate environment, we've had a recurring problem where the network has some intermittent "blips". This is not a failure of the App or of MySql, but somehow the connection is momentarily lost.
So, what happens is that the Runnable in addBagItem
   @Override    public Future<Boolean> addBagItem()    {       return addConnectionExecutor.submit(POOL_ENTRY_CREATOR);    }
Is that the thread can't make a connection and sits and hangs while the idle threads expire and are evicted. Since the addConnection process is a single blocking queue, the thread never acquires a connection and the fillPool() method just sits there. This eventually results in having a total connection of 0 and the app crashes, because its unable to get a DB connection.
This has proven very difficult to replicate (there is a thread dump in the prior ticket), and since the issues seem to be rooted in some mysterious behavior on the ops side of things, it seems like there isn't too much we can actually do on the app side. At first we thought it was a connection issue on the VIP that sits in front of our Read-Only  / Slave boxes, but it has also happened on our direct connection to the RW / master. The other difficulty is that since the starvation doesn't happen until AFTER the existing DB threads timeout / are evicted, then we can't really pinpoint when the network issue happened.
So, in addition to the configuration as listed, I added a scheduled job to poll the MX Beans and perform a softEvict() if the Working / Idle threads drop to 0/0, but we're still having issues of eventually running out of connections.
My next course of action was to inject a ScheduledExecutor to enforce a timeout at the thread level. That seems a little extreme, but I'm honestly not sure where to go forward with this.
Below is a log of what the debug during one of these incidents. Both pools have the same config of Min/Max: 10/50 connections. In this case you can see that our Read-Only pool started dying at 4 connections:
Any thoughts?
 2016-10-21 04:29:02,975 [pool-6-thread-1] INFO  <redacted>.api.v3.util.HikariPoolRestartController - Read-Write-Pool - Pool stats (total=10, active=0, idle=10, waiting=0) 2016-10-21 04:29:02,975 [pool-6-thread-1] INFO  <redacted>.api.v3.util.HikariPoolRestartController - Read-Only-Pool - Pool stats (total=4, active=4, idle=0, waiting=2) 2016-10-21 04:29:03,084 [http-apr-7305-exec-38] DEBUG com.zaxxer.hikari.pool.HikariPool - Read-Only-Pool - Timeout failure stats (total=4, active=4, idle=0, waiting=1) 2016-10-21 04:29:03,084 [http-apr-7305-exec-38] WARN  org.hibernate.engine.jdbc.spi.SqlExceptionHelper - SQL Error: 0, SQLState: null 2016-10-21 04:29:03,084 [http-apr-7305-exec-38] ERROR org.hibernate.engine.jdbc.spi.SqlExceptionHelper - Read-Only-Pool - Connection is not available, request timed out after 10000ms. 2016-10-21 04:29:03,674 [http-apr-7305-exec-7] DEBUG com.zaxxer.hikari.pool.HikariPool - Read-Only-Pool - Timeout failure stats (total=4, active=4, idle=0, waiting=0) 2016-10-21 04:29:03,674 [http-apr-7305-exec-7] WARN  org.hibernate.engine.jdbc.spi.SqlExceptionHelper - SQL Error: 0, SQLState: null 2016-10-21 04:29:03,674 [http-apr-7305-exec-7] ERROR org.hibernate.engine.jdbc.spi.SqlExceptionHelper - Read-Only-Pool - Connection is not available, request timed out after 10000ms. 2016-10-21 04:29:05,363 [Read-Only-Pool housekeeper] DEBUG com.zaxxer.hikari.pool.HikariPool - Read-Only-Pool - Pool stats (total=4, active=4, idle=0, waiting=0) 2016-10-21 04:29:05,363 [Read-Write-Pool housekeeper] DEBUG com.zaxxer.hikari.pool.HikariPool - Read-Write-Pool - Pool stats (total=10, active=0, idle=10, waiting=0) 2016-10-21 04:29:12,976 [pool-6-thread-1] INFO  <redacted>.api.v3.util.HikariPoolRestartController - Read-Write-Pool - Pool stats (total=10, active=0, idle=10, waiting=0) 2016-10-21 04:29:12,976 [pool-6-thread-1] INFO  <redacted>.api.v3.util.HikariPoolRestartController - Read-Only-Pool - Pool stats (total=4, active=4, idle=0, waiting=1) 2016-10-21 04:29:19,504 [http-apr-7305-exec-5] DEBUG com.zaxxer.hikari.pool.HikariPool - Read-Only-Pool - Timeout failure stats (total=4, active=4, idle=0, waiting=0) 2016-10-21 04:29:19,504 [http-apr-7305-exec-5] WARN  org.hibernate.engine.jdbc.spi.SqlExceptionHelper - SQL Error: 0, SQLState: null 2016-10-21 04:29:19,504 [http-apr-7305-exec-5] ERROR org.hibernate.engine.jdbc.spi.SqlExceptionHelper - Read-Only-Pool - Connection is not available, request timed out after 10000ms. 2016-10-21 04:29:22,977 [pool-6-thread-1] INFO  <redacted>.api.v3.util.HikariPoolRestartController - Read-Write-Pool - Pool stats (total=10, active=0, idle=10, waiting=0) 2016-10-21 04:29:22,977 [pool-6-thread-1] INFO  <redacted>.api.v3.util.HikariPoolRestartController - Read-Only-Pool - Pool stats (total=4, active=4, idle=0, waiting=0) 2016-10-21 04:29:32,978 [pool-6-thread-1] INFO  <redacted>.api.v3.util.HikariPoolRestartController - Read-Write-Pool - Pool stats (total=10, active=0, idle=10, waiting=0) 2016-10-21 04:29:32,978 [pool-6-thread-1] INFO  <redacted>.api.v3.util.HikariPoolRestartController - Read-Only-Pool - Pool stats (total=4, active=4, idle=0, waiting=4) 2016-10-21 04:29:35,084 [http-apr-7305-exec-46] DEBUG com.zaxxer.hikari.pool.HikariPool - Read-Only-Pool - Timeout failure stats (total=4, active=4, idle=0, waiting=4) 2016-10-21 04:29:35,084 [http-apr-7305-exec-46] WARN  org.hibernate.engine.jdbc.spi.SqlExceptionHelper - SQL Error: 0, SQLState: null 2016-10-21 04:29:35,084 [http-apr-7305-exec-46] ERROR org.hibernate.engine.jdbc.spi.SqlExceptionHelper - Read-Only-Pool - Connection is not available, request timed out after 10000ms. 2016-10-21 04:29:35,363 [Read-Only-Pool housekeeper] DEBUG com.zaxxer.hikari.pool.HikariPool - Read-Only-Pool - Pool stats (total=4, active=4, idle=0, waiting=4) 2016-10-21 04:29:35,363 [Read-Write-Pool housekeeper] DEBUG com.zaxxer.hikari.pool.HikariPool - Read-Write-Pool - Pool stats (total=10, active=0, idle=10, waiting=0) 2016-10-21 04:29:35,685 [http-apr-7305-exec-17] DEBUG com.zaxxer.hikari.pool.HikariPool - Read-Only-Pool - Timeout failure stats (total=4, active=4, idle=0, waiting=3) 2016-10-21 04:29:35,685 [http-apr-7305-exec-17] WARN  org.hibernate.engine.jdbc.spi.SqlExceptionHelper - SQL Error: 0, SQLState: null 2016-10-21 04:29:35,685 [http-apr-7305-exec-17] ERROR org.hibernate.engine.jdbc.spi.SqlExceptionHelper - Read-Only-Pool - Connection is not available, request timed out after 10000ms. 2016-10-21 04:29:40,083 [http-apr-7305-exec-24] DEBUG com.zaxxer.hikari.pool.HikariPool - Read-Only-Pool - Timeout failure stats (total=4, active=4, idle=0, waiting=3) 2016-10-21 04:29:40,083 [http-apr-7305-exec-24] WARN  org.hibernate.engine.jdbc.spi.SqlExceptionHelper - SQL Error: 0, SQLState: null 2016-10-21 04:29:40,083 [http-apr-7305-exec-24] ERROR org.hibernate.engine.jdbc.spi.SqlExceptionHelper - Read-Only-Pool - Connection is not available, request timed out after 10000ms. 2016-10-21 04:29:40,695 [http-apr-7305-exec-4] DEBUG com.zaxxer.hikari.pool.HikariPool - Read-Only-Pool - Timeout failure stats (total=4, active=4, idle=0, waiting=2) 2016-10-21 04:29:40,695 [http-apr-7305-exec-4] WARN  org.hibernate.engine.jdbc.spi.SqlExceptionHelper - SQL Error: 0, SQLState: null 2016-10-21 04:29:40,695 [http-apr-7305-exec-4] ERROR org.hibernate.engine.jdbc.spi.SqlExceptionHelper - Read-Only-Pool - Connection is not available, request timed out after 10000ms. 2016-10-21 04:29:43,062 [pool-6-thread-1] INFO  <redacted>.api.v3.util.HikariPoolRestartController - Read-Write-Pool - Pool stats (total=10, active=0, idle=10, waiting=0) 2016-10-21 04:29:43,062 [pool-6-thread-1] INFO  <redacted>.api.v3.util.HikariPoolRestartController - Read-Only-Pool - Pool stats (total=4, active=4, idle=0, waiting=2)

@liamchristopher try adding following in mysqld section of your my.cnf
max_connections = 200
max_user_connections = 100

@liamchristopher First, I recommend reading this from top to bottom, but the important section for this discussion is entitled "What is Socket Timeout for JDBC Driver?" about 2/3 of the way down the page.
If a thread dump generated from HikariCP 2.5.1 is still showing the connection adder thread blocked, there are two things to check...
If the top of the thread stack is com.mysql.jdbc.StandardSocketFactory.connect(), you need to configure the Connector/J connectTimeout property.  This value can be your choice of:

the same value as the HikariCP connectionTimeout value
the same value as the HikariCP validationTimeout value
a value of your choosing less than the HikariCP connectionTimeout

If the top of the thread stack is java.net.SocketInputStream.socketRead0(Native Method), there are two further options...
You can configure the Connector/J socketTimeout property.  This must be more than the longest query you anticipate, but as short as you can tolerate.  But there is a annoying aspect about socketTimeout -- it applies not only to the connection handshake, but also to all future queries.  So, if you have a query that runs for 3 minutes, but you don't want to tolerate the connection adder thread hanging for 3 minutes, then socketTimeout is not a good lever to pull.
Investigating this issue lead me to a shocking discovery in the Connector/J code.  HikariCP sets the login timeout on the DataSource during initialization.  And the Connector/J StandardSocketFactory appears at first glance to use the login timeout.  But the value is picked up here, which seemed a little odd because using the MysqlDataSource rather than URL-based (driver) configuration could be excluded.  But maybe the MysqlDataSource.setLoginTimeout() does the right thing and calls DriverManager.setLoginTimeout().  Or maybe not so much.
So, in order to cover all bases, I would set the Connector/J connectTimeout property.  I would set the socketTimeout property to the lowest value you can tolerate.  And I would either switch to URL-based configuration (to ensure that the login timeout is applied) or if you continue with the DataSource-based configuration then somewhere in your code call java.sql.DriverManager.setLoginTimeout() with the same value as the HikariCP connectionTimeout/MySQL connectTimeout.

Wow, thank you for the awesome follow-up! Checking on your open bug in the last link actually looks like what the exact problem we're having is.
I created a mysql bug cribbed from your response, that you can see here. Its going to take me another day to get through this new suggested configuration, but this looks very promising.
Thanks!

@nitincchauhan
That's not really the problem. Our connection max's are actually higher than both of those, and we're dealing with multiple pools through load-balancers to many hosts.
In this case, turning up the knobs and setting longer timeouts just prolongs the problem, and makes it less predictable.
The issue here, as Brett pointed out above is a combination of configuration issues and a rather nasty set of bugs in the mysql connector that don't actually honor those timeouts.

@liamchristopher In that case, meanwhile I recommend [MariaDB Connector/J]  (https://downloads.mariadb.org/connector-java/)  driver instead.

@nitincchauhan Without studying the MariaDB driver code I cannot agree that a change of driver will improve anything.

Any news on this issue yet? Like it sounds to me very similar to these 2 other issues: #756 #761
We experienced something similar when we used HikariCP 2.5.1 (with Tomcat 8.0.35, mysql-connector-java-5.1.39, OpenJDK 1.8.0_91, Amazon RDS on MySQL 5.6) only after 2 weeks of using it.
For the while being we reverted to 2.4.6, since we have not had this kind of issue yet with that version for the ~4 months that we used it.
Our Tomcat configuration looked like:
    <Resource name="jdbc/shareddb" auth="Container"
                 type="javax.sql.DataSource"
                 factory="com.zaxxer.hikari.HikariJNDIFactory"
                 minimumIdle="5" maximumPoolSize="20"
                 connectionTimeout="3000" validationTimeout="2500"
                 poolName="sharedDbPool" registerMbeans="true"
                 dataSourceClassName="com.mysql.jdbc.jdbc2.optional.MysqlDataSource"

Unfortunately we don't have a full stack trace and we haven't had the time yet to thoroughly work on this issue to reproduce it again. Here is our partial stack trace:
org.skife.jdbi.v2.exceptions.UnableToObtainConnectionException: java.sql.SQLTransientConnectionException: sharedDbPool - Connection is not available, request timed out after 4000ms.
   org.skife.jdbi.v2.DBI.open(DBI.java:229)
   org.skife.jdbi.v2.sqlobject.OnDemandHandleDing.getHandle(OnDemandHandleDing.java:36)
   org.skife.jdbi.v2.sqlobject.OnDemandHandleDing.retain(OnDemandHandleDing.java:44)
   org.skife.jdbi.v2.sqlobject.SqlObject.invoke(SqlObject.java:211)
   org.skife.jdbi.v2.sqlobject.SqlObject$3.intercept(SqlObject.java:127)
   org.skife.jdbi.v2.sqlobject.CloseInternalDoNotUseThisClass$$EnhancerByCGLIB$$3d5dabd9.getHash(<generated>)
   com.ourcompany.util.Utils.checkForAndHandleChange(Utils.java:110)
   com.ourcompany.state.RequestedState.handleResponse(RequestedState.java:42)
   com.ourcompany.state.SessionImpl.handleResponse(SessionImpl.java:290)
   com.ourcompany.timer.TimerManager$2.runUnsafe(TimerManager.java:222)
   com.ourcompany.ussd.util.executors.NonClosableRunnable.run(NonClosableRunnable.java:28)
   java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   java.lang.Thread.run(Thread.java:745)
Caused by: java.sql.SQLTransientConnectionException: sharedDbPool - Connection is not available, request timed out after 4000ms.
   com.zaxxer.hikari.pool.HikariPool.createTimeoutException(HikariPool.java:548)
   com.zaxxer.hikari.pool.HikariPool.getConnection(HikariPool.java:186)
   com.zaxxer.hikari.pool.HikariPool.getConnection(HikariPool.java:145)
   com.zaxxer.hikari.HikariDataSource.getConnection(HikariDataSource.java:83)
   org.skife.jdbi.v2.DataSourceConnectionFactory.openConnection(DataSourceConnectionFactory.java:34)
   org.skife.jdbi.v2.DBI.open(DBI.java:211)
... 13 more

From our Zabbix graph, HikariCP thought it still had 1 Active connection during the time where the graph shows up to 89 threads waiting for a connection, even though our DB process list showed no connections from our app:

I've noticed the README was updated recently to include a warning regarding the usage of MysqlDataSource. Could the same notice be included for MariaDB's datasource as well? As far as I can tell, their latest release as of now (1.5.5) has the exact same broken behavior as the MySQL datasource: https://github.com/MariaDB/mariadb-connector-j/blob/1.5.5/src/main/java/org/mariadb/jdbc/MariaDbDataSource.java#L333

@mpontes It looks like the MariaDB DataSource implements fewer methods than MySQL. I would definitely use URL configuration in that case.  I'll update the README, thanks for the heads up.

@liamchristopher @PadaKwaak Are you still seeing this issue on the latest version (2.5.1) and after switching to jdbcURL/driverClassName-based configuration (rather than dataSourceClassName)?

@brettwooldridge We still use the datasource for the caching settings, but set the URL instead of the host host/DB/etc fields.
I ended up implementing a simple worker that checks the mbeans and does a soft reset when active/totalConnections hits zero. I just checked and saw a few instances over the last month, but it has not caused an app failure. It has happened with both of our pools, (so it's not completely the VIP/LB issue that I thought it was), but the soft-evict seems to force it to eventually recover.
The bug with mysql is acknowledged, but not updated. I'm not really holding my breath on that one.
Thanks for your help, I'm very impressed with your work!

Seems like mariadb is at least fixed: https://github.com/MariaDB/mariadb-connector-j/commit/d81eec3ed9fd68411242bd10347480890b73dfa3#diff-1681374bfde5af3b7ddcc7f029a31d42R331

@brettwooldridge would you kindly respond to Filipe over at https://bugs.mysql.com/bug.php?id=75615

Answered.  Had to go straight to the source, as arguing with that guy was a waste of time.


Clarifying Parameter for Blob Content Action

Added a clarifying sentence to use ID paramater in the Blob field of the "Get Blob Content" Action, as name with path do not work here.

@ecfan - Would you review the proposed changes? Thank you.

@rinaahmed : Thanks for your contribution! The author, @ ecfan, has been notified to review your proposed change.

@rinaahmed : Thanks for your contribution! The author, @ ecfan, has been notified to review your proposed change.

@rinaahmed : Thanks for your contribution! The author, @ ecfan, has been notified to review your proposed change.

@rinaahmed : Thanks for your contribution! The author, @ ecfan, has been notified to review your proposed change.

@rinaahmed : Thanks for your contribution! The author, @ ecfan, has been notified to review your proposed change.

@rinaahmed : Thanks for your contribution! The author, @ ecfan, has been notified to review your proposed change.

@rinaahmed : Thanks for your contribution! The author, @ ecfan, has been notified to review your proposed change.

@rinaahmed @ecfan  sorry I was testing as to why the labels were not appearing correctly. The issue is now resolved.


feat: update instrument code to use es2015+

This is an attempt to use some more modern language features in the instrument.js and the instrumentAllFiles command.  It's a cut back version of what I was proposing in #1003 as per conversation with @coreyfarrell.
As there's quite a bit here I'll drop in some notes and assumptions

Notes:

Refactor nyc-integration instrument tests so tests with output folder specified aren't in the no output folder suite
Refactor instrument.js and instrumentAllFiles command to use modern javascript
Remove call to deprecated process.exit() in instrument command
Removed unused transform metadata param relFile, this is an issue in other parts of the code.
Use file extension as an index to find the correct transform, rather than trying to match a transform name to the rightmost characters of a filename, this may be an issue in other parts of the code.

Assumptions:

That we want to use file extensions to find transforms, the existing implementation would use the .js instrumenter for both .js and .mjs files, these changes assume that was wrong.
When instrumentAllFiles fails to find the correct transform, it returns the uninstrumented source,
It looks like the relFile property isn't used anymore, so I'm assuming it can be safely removed

Coverage decreased (-0.07%) to 93.762% when pulling 1b238cb0b69b5dbc6224ca571e39078ba22f4a3f on AndrewFinlay:instrument-es2015+ into d3d95ffbb1441dc310b03371b656a848987742b8 on istanbuljs:master.

Coverage decreased (-0.07%) to 93.762% when pulling 1b238cb0b69b5dbc6224ca571e39078ba22f4a3f on AndrewFinlay:instrument-es2015+ into d3d95ffbb1441dc310b03371b656a848987742b8 on istanbuljs:master.

Coverage decreased (-0.07%) to 93.762% when pulling 1b238cb0b69b5dbc6224ca571e39078ba22f4a3f on AndrewFinlay:instrument-es2015+ into d3d95ffbb1441dc310b03371b656a848987742b8 on istanbuljs:master.

Coverage decreased (-0.07%) to 93.762% when pulling 1b238cb0b69b5dbc6224ca571e39078ba22f4a3f on AndrewFinlay:instrument-es2015+ into d3d95ffbb1441dc310b03371b656a848987742b8 on istanbuljs:master.


[docs-only] added services communication diagram

Added this diagram to the docs to show how our different services communicate with each other.
It's not complete, e.g. the nats service just "hangs in the air" because I didn't include the events stuff. There might also be some lines missing because it would make the diagram harder to grasp.

Great! You might wanna add some arrows from the ocis/ocs service to accounts and the reva gateway
Now we just need to remember to keep this up to date everytime we change something. ;-)

awesome! Small nitpick: next time remove the width and height attributes from the svg https://www.creativebloq.com/how-to/10-golden-rules-for-responsive-svgs

Oh thanks for the hint. I'll do it next time.


ResponseBody.create(MediaType, String) constructs an object which can be mutated into an invalid state using ResponseBody.string()

Basically we bumped into this when writing unit tests to our component which uses Retrofit and therefore OkHttp. The version of OkHttp is 2.5.0.
When you construct an object using the ResponseBody.create(MediaType, String), two subsequent calls to ResponseBody.string() will fail with an IOException so the getter seems to mutate the object and mutates it to corrupted state. The behaviour is not indicated by the javadoc of ResponseBody.string() and therefore it was a surprise and we did spend for a while wondering what's the problem here. RealResponseBody does not seem to be affected by the same issue.
To reproduce the problem:
    @Test
    public void testResponseBodyCreate() throws IOException {
        ResponseBody body = ResponseBody.create(MediaType.parse("text/plain"), "test");

        body.string();
        body.string(); // Fails with IOException when using okhttp 2.5.0
    }

Which reports
java.io.IOException: Content-Length and stream length disagree
	at com.squareup.okhttp.ResponseBody.bytes(ResponseBody.java:62)
	at com.squareup.okhttp.ResponseBody.string(ResponseBody.java:83)

This probably should be documented in the javadocs or the behaviour should be fixed.

Every ResponseBody instance can only be read once, in practice, as there's no automatic buffering happening. string() is effectively an exhaustive read of the input so on a subsequent call the underlying data source is empty (hence the exception message).

The documentation on this is not necessarily where you'll look first. It's on response which says, “Instances of this class are not immutable: the response body is a one-shot value that may be consumed only once.”
We could_also_ say that on the response body itself.
http://square.github.io/okhttp/2.x/okhttp/com/squareup/okhttp/Response.html

Yes, in Response it clearly says that ResponseBody retrieved from the response is a one-shot value. As @swankjesse mentions, it makes sense to document the behaviour also directly to ResponseBodythat some implementations may be consumed only once. Looks like instances of RealResponseBody can be consumed more than once.
Anyways, thanks for pointing us to the right direction! And in addition, OkHttp and Retrofit have made the implementation of our reactive RxJava RESTful WS clients a breeze.

Just a suggestion. Can refer to the similar function in rest-assured, it is idempotent. I guess it cached the http resp body, and return it in later calls.

Application code should cache the response themselves or replace the
RequestBody instance when consuming the stream.
On Wed, Nov 11, 2015, 3:18 AM mkatsoho<EMAIL_ADDRESS>wrote:

Just a suggestion. Can refer to the similar function in rest-assured, it
is idempotent. I guess it cached the http resp body, and return it in later
calls.
—
Reply to this email directly or view it on GitHub
https://github.com/square/okhttp/issues/1968#issuecomment-155701090.


fix: update to @dabh/colors for security vuln

A Security Vuln was identified in the Colors package for >1.4.0, offending packages being 1.4.1, 1.4.44-liberty

source1
source2
source3

This PR updates the color package to using @dabh/colors as stated on this colors issue #317 which is a safe alternative.

Hi @enricostara , when you have a moment to review, a PR for your consideration! 🙂

Hello Manny,
This project has not had a commit in 7 years?
NPM has already removed the offending version ( https://www.npmjs.com/package/colors )
There is no need for this change 👍
This project is not compromised


cloud_firestore snapshots should have stream errors when errors occur in Query

Originally posted by @ened in https://github.com/flutter/flutter/issues/13904#issuecomment-473118195
Can confirm Firestore does not crash anymore in case of a missing index. There is clear error description in the logs.
I would, however, expect the AsyncSnapshot to have the error field clearly set.
Sample code:
StreamBuilder<QuerySnapshot>(
  stream: state.myQuery,
  builder: (BuildContext context, AsyncSnapshot<QuerySnapshot> snapshot) {
    if (snapshot.hasError) {
      return Text('Error: ${snapshot.error}');
    }
    print('snapshot: ${snapshot.connectionState}');
    switch (snapshot.connectionState) {
      case ConnectionState.done:
      case ConnectionState.waiting:
        return Container(
          child: const Center(child: CircularProgressIndicator()),
        );

      default:
        if (snapshot.data.documents.isEmpty) {
          return _buildEmptyPage();
        }

        return _buildListView(snapshot, context);
    }
  },
),

snapshot.error & snapshot.hasError really should be set in that case.

@collinjackson
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/384. Any further collaboration will be done there.


(@Banded Body Press) gen9alphabetsoup: timer

@Banded Body Press: "timer"
Created via Iolanthe on Mon, 20 Nov 2023 14:14:08 GMT.

Superseded by https://github.com/OperationTourCode/OTC/pull/401


Add simplified Chinese support.

#815

Can you update LocaleType in client/src/types/general.ts:310?

Can you update LocaleType in client/src/types/general.ts:310?

Okey.

@anastasiya1155 It's done.

Perfect! Thanks for your contribution!


P-Chain Support

I focused on pchain and highlighed some nits and some Blueberry related changes. Going to have a pass over it again

Thanks for the review @abi87.
cc: @bilgehansahin for your visibility.

@joshua-kim
If you look at the commits you'll find all the smaller PR previously included and explained. ie(https://github.com/ava-labs/avalanche-rosetta/pull/122)

@joshua-kim
If you look at the commits you'll find all the smaller PR previously included and explained. ie(https://github.com/ava-labs/avalanche-rosetta/pull/122)

Didn't realize this was our feature branch and these were previously approved, thanks for the context 👍 .

@abi87 Seems like cchain get /block by ID is broken
curl --request POST \
  --url http://localhost:9090/block \
  --header 'Content-Type: application/json' \
  --data '{
        "network_identifier": {
                "blockchain": "Avalanche",
                "network": "Fuji"
        },
        "block_identifier": {
                "index":2
        }
}'
{"code":7,"message":"Client error","retriable":true,"details":{"error":"processing block 1 failed: engine finalization check failed: invalid block due to failed semanatic verify: failed to fetch import UTXOs from 2JVSBoinj9C2J33VntvzYtVJNZdN2NKiwwKjcumHUWEb5DbBrm due to: not found at height 1"}}

Not sure why it's complaining about UTXO in this case. Also typo in semanatic. How are you testing these changes?

@abi87
I'm getting an error fetch cchain blocks by height
curl --request POST \
  --url http://localhost:9090/block \
  --header 'Content-Type: application/json' \
  --data '{
        "network_identifier": {
                "blockchain": "Avalanche",
                "network": "Fuji"
        },
        "block_identifier": {
                "index":2
        }
}'
{"code":7,"message":"Client error","retriable":true,"details":{"error":"processing block 1 failed: engine
 finalization check failed: invalid block due to failed semanatic verify: failed to fetch import UTXOs
from 2JVSBoinj9C2J33VntvzYtVJNZdN2NKiwwKjcumHUWEb5DbBrm due to: not found at height 1"}}

How are you testing these changes?


Use revive instead of deprecated golint

Signed-off-by: Florian Froese<EMAIL_ADDRESS>

We should consider using https://github.com/marketplace/actions/revive-action for its GitHub Annotations support

There is also the general golangci-lint action. This also generates annotations and should hopefully also be able to include revive. Our make verify code currently does a bit more than just run the linter action. (it also formats the code and tidies up modules) This is probably not correct as the user commit should already format the code correctly and tidy up modules. (So that other users have a clean experience when they check out the code and build and not some formatting from a previous PR)


[Talessya] Version 1.1: NPCs support and bug fixes

Changes / Comments
New version of this sheet, includes support for adding NPCs characters and some bug fixes requested by the users.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[x] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


[BEAM-13064] [Playground] Implement search & filter logic

Implemented sorting functionality to Example Selector widget.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @damondouglas
cc: @pabloem

Hello @miamihotline, after deleting any existing playground/frontend/build directory and running ./gradlew playgroundPrecommit, I receive the following output:

Hello, @damondouglas , i fixed this issues 5 mins ago

Thank you, @miamihotline, I see the following output.  I ran flutter test in the playground/frontend directory.  I'm wondering if
the code for expect(state.categories, sortedCategories); should be changed?
00:04 +2: beam/playground/frontend/test/pages/playground/states/example_selector_state_test.dart: ExampleSelector state sortCategories should:- update categories and notify all listeners,but should NOT:- wait for full name of example,- be sensitive for register,- affect Example state categories
══╡ EXCEPTION CAUGHT BY FOUNDATION LIBRARY ╞════════════════════════════════════════════════════════
The following TestFailure object was thrown while dispatching notifications for
ExampleSelectorState:
  Expected: [Instance of 'CategoryModel']
  Actual: [Instance of 'CategoryModel']
   Which: at location [0] is <Instance of 'CategoryModel'> instead of <Instance of 'CategoryModel'>

When the exception was thrown, this was the stack:
#0      fail (package:test_api/src/expect/expect.dart:137:31)
#1      _expect (package:test_api/src/expect/expect.dart:132:3)
#2      expect (package:test_api/src/expect/expect.dart:46:3)
#3      expect (package:flutter_test/src/widget_tester.dart:461:3)
#4      main.<anonymous closure>.<anonymous closure> (beam/playground/frontend/test/pages/playground/states/example_selector_state_test.dart:65:7)
#5      ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:308:24)
#6      ExampleSelectorState.setCategories (package:playground/pages/playground/states/example_selector_state.dart:54:5)
#7      ExampleSelectorState.sortCategories (package:playground/pages/playground/states/example_selector_state.dart:64:5)
#8      main.<anonymous closure> (beam/playground/frontend/test/pages/playground/states/example_selector_state_test.dart:68:11)
#9      Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:199:19)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)

The ExampleSelectorState sending notification was:
  Instance of 'ExampleSelectorState'

@damondouglas  Thank you for pointing that out, fixed this problem


SharePoint wont respect it's own Connection: close header

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
When the server sends back Connection: close HTTP header, it should not allow for further communication with the server on the same socket
Observed Behavior
Sending a specific payload to the server (HTTP POST form) and getting back an HTTP response (400 the request is badly formed) (this is expected as it was a fuzzing session), the server return a Connection: close header, sending additional data to the socket is working, even doing select on the sending socket shows the socket is writable and readable and the other side has not closed the connection, this can take up to 5 minutes before the status of the socket changes.
Steps to Reproduce
I used a simple Ruby script to open a raw socket to the server, and send the request from a file (attached)

the file contains an HTTP request to the path /sites/test which is the root of the application site (it's basically a txt file).
7z
zip
Sending it to the site emulate the relevant fuzzed HTTP request which recreates this weird socket issue.

@VesaJuvonen, mind taking a loom at this please?

We closed this issue as it had not activity within last 180 days. This is a generic process we have decided to perform for issues, which have not been explicitly marked still to be "work in progress" based on tags. We are performing this cleaning to make sure that old issues that have already been solved (but not closed) or are no longer relevant are cleaned out and make the issues more manageable. If this issue still valid, we would ask you to open a new issue and follow the guidance in the issue template related on the recommended location. We do apologize any inconveniences this might cause. Please do remember that issues in the issue lists are also messages for others in the community, so you can also check if you can assist on any of them. “Sharing is caring!”


Closing checklist pdf

Changes

Changed the words "30 years" to "many years" in the closing checklist pdf

Screenshot

Review
@fna for making sure I didn't mess it up
@mthibos for content

Travis build failed because of this commit https://github.com/amymok/owning-a-home/commit/35746b43b622b5e38ae4ab01f0d93b3a45b8f1f4
As noted, all tests passed.
Everything should be fine after https://github.com/cfpb/owning-a-home/pull/490 is merged in.

Hey, I'm making accessibility updates to this PDF (eventually). We might as well wait and not merge this.

I'm going to close this PR, you can still make changes to your branch and reopen it when you're ready, @stephanieosan

:+1:


Community Resource should not be approved by default - change to SystemSetting

Community Resource default is current set to "yes" for approved in the form. This should be the purview of the group - add this as an option in Admin > SystemSetting

[ ] Add a SystemSetting field to allow groups to edit based on preference
[ ] set is_approved based on the system_setting when a Community Resource is created

I may pick this up as an excuse to refactor system settings


Backport updates to maintenance branch

Does what it says.
This includes various fixes and improvements to the CI system, including tests run without EDM and building wheels on a large number of platforms.

Wrong target


Telemetry integration

Integration with telemetry
ToDo

[ ] Add telemetry as optional dependency
[ ] Add Tesla.Middleware.Telemetry to send request event (with measured duration)
[ ] Decide on event names (single event? multiple? ok & error only?)
[ ] Decide what to send as metadata (full env?)

def call(...) do
  start = ...
  result = Tesla.run(...)
  stop = ...
  Telemetry.execute([:tesla, ...], stop - start, %{...})
  result
end

Closed with #276


Block types: allow saving NULL values

We must be able to save NULL values when we edit blocks.
So, we should check the values to be saved by using array_key_exists($key, $args) instead of isset($args[$key]) (that returns false if $args does not contain $key or if $args[$key] is null).

@mlocati I reverted this commit just now. I couldn't even get concrete5 to install with it. You're probably not wrong but I'm worried that this could be a huge backward compatibility problem. Thoughts?

@aembler What about https://github.com/concrete5/concrete5/pull/5259 ?


Regarding lambda packages

Will this new version of Zappa support lambda_packages?
I have a dependency for mysqlclient failing with the below error.
[ERROR] ImproperlyConfigured: Error loading MySQLdb module.

Did you install mysqlclient?
Traceback (most recent call last):
  File "/var/task/handler.py", line 631, in lambda_handler
    return LambdaHandler.lambda_handler(event, context)
  File "/var/task/handler.py", line 242, in lambda_handler
    handler = cls()
  File "/var/task/handler.py", line 148, in __init__
    wsgi_app_function = get_django_wsgi(self.settings.DJANGO_SETTINGS)
  File "/var/task/zappa/ext/django_zappa.py", line 20, in get_django_wsgi
    return get_wsgi_application()
  File "/var/task/django/core/wsgi.py", line 12, in get_wsgi_application
    django.setup(set_prefix=False)
  File "/var/task/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/var/task/django/apps/registry.py", line 114, in populate
    app_config.import_models()
  File "/var/task/django/apps/config.py", line 211, in import_models
    self.models_module = import_module(models_module_name)
  File "/var/lang/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/var/task/django/contrib/auth/models.py", line 2, in <module>
    from django.contrib.auth.base_user import AbstractBaseUser, BaseUserManager
  File "/var/task/django/contrib/auth/base_user.py", line 47, in <module>
    class AbstractBaseUser(models.Model):
  File "/var/task/django/db/models/base.py", line 117, in __new__
    new_class.add_to_class('_meta', Options(meta, app_label))
  File "/var/task/django/db/models/base.py", line 321, in add_to_class
    value.contribute_to_class(cls, name)
  File "/var/task/django/db/models/options.py", line 204, in contribute_to_class
    self.db_table = truncate_name(self.db_table, connection.ops.max_name_length())
  File "/var/task/django/db/__init__.py", line 28, in __getattr__
    return getattr(connections[DEFAULT_DB_ALIAS], item)
  File "/var/task/django/db/utils.py", line 201, in __getitem__
    backend = load_backend(db['ENGINE'])
  File "/var/task/django/db/utils.py", line 110, in load_backend
    return import_module('%s.base' % backend_name)
  File "/var/lang/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/var/task/django/db/backends/mysql/base.py", line 20, in <module>
    ) from err

Any ideas to include lambda_packages?

It's my understanding that lambda_packages is no longer needed for packages that have manylinux wheels available.
closing.

What should we do with the packages that don't have many Linux wheels?

For mysqlclient you may want to take a look at:
https://github.com/nonbeing/mysqlclient-python3-aws-lambda
I think what needs to be done is the client needs to be built for the lambda environment.
Then providing it as a lambda layer makes it easy to integrate with zappa.


Add new design for language and platforms to the package page

Add fields to the view model
Add the design markup

I think this is done, isn't it?

Yep, this is done!


message for Obsolete warning + updated README

Just a minor fix: message for Obsolete warning which tells what to use now + updated README (I was confused after update so fixed this)
PS. This tool is just awesome!!

Thanks!


IOS support

Geode Version
idk the latest one
Related Problem
No response
Your Solution
Please add IOS support for the love of god
Additional Information
No response

For the last time, its not that simple.
TL;DR it'd be extremely inconvenient for both devs and users, so not really worth it. Possibly if iOS makes some important changes, it could happen
iOS doesn't support dynamic library loading, so basically every mod would have to be built into the app, and that would be a major issue. You'd have to update the app every single time a mod released/updated and it'd allow piracy (which geode is against)

Does he know...

https://en.wikipedia.org/wiki/Fake_news

is not real, will never be real. do not believe people that tell you otherwise! refer to the link FireMario211 sent for more information!

you guys are weird. duplicate of #528


fix(stage): zooming behavior for trackpads + zoom center point

When the stage was dragged, the center of the zoom point wasn't the
cursor anymore. Additionally zooming on a macbook mousepad was very
fast.
Closes #11
Signed-off-by: Lukas Mertens<EMAIL_ADDRESS>
Stack:

#44
#43
#42
#34
#33
#32
#31
#29
#27
#26
#25 ⬅

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

✓ Commit merged in pull request #42


Replace loc based logic with function

Hi Alistair-
I just quickly had a go at rewriting logic around species assignment. I think its easier to follow when contained in a function like this?

Hi @hardingnj, looks good. Nit, but I would suggest to let the consolidate_species() function take a pandas series, so you could avoid the intermediate lambda function. I.e., so you could do:
df["species"] = df.apply(consolidate_species)

Hi @hardingnj, looks good. Nit, but I would suggest to let the consolidate_species() function take a pandas series, so you could avoid the intermediate lambda function. I.e., so you could do:
df["species"] = df.apply(consolidate_species)

Sorry- missed this first time around. Will amend this now.

No worries, thanks :smile:


Reduce the slam's base damage

I like the idea of this mod, but the slam is strong by itself already. Reducing the base damage so it's weaker than vanilla when Loader is not falling (and stronger than vanilla when Loader is falling) would make this more balanced.
Or at least adding configuration for the skill's base damage coefficient so it can be configured.

I see what you mean, I didn't have time to test it properly in a long run. I will look into this. My idea right now is to add a % value in config that will take the base damage and scale it.

Or at least adding configuration for the skill's base damage coefficient so it can be configured.

For now, there is a config value called 'DamageSpeedCoef'

Added baseValue coefficients

I will update other stuff and release a new version on thunderstore.
Closing for now


Bluetooth: Fix available LPN groups count

This fixes the LPN_GROUPS define.
Signed-off-by: Mariusz Skamra<EMAIL_ADDRESS>

Codecov Report

Merging #6480 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6480   +/-   ##
======================================
  Coverage    53.2%   53.2%
======================================
  Files         436     436
  Lines       41353   41353
  Branches     7937    7937
======================================
  Hits        22001   22001
  Misses      16128   16128
  Partials     3224    3224

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86b219...012e091. Read the comment docs.


Create unit tests for com.rgi.common.tile.store

Create unit tests coverage for the tile.store namespace in com.rgi.common.
Strive for 90% code coverage if possible.

TileClusterTest is just a shell at the moment


titlebar of box can "stick" out of titlebar in firefox - documentation problem?

Hi,
we have following code:

    pike

    node is git

      ssh |
      → goto

This is how it looks on Edge - as it should:

And this is how it looks on Firefox:

Notice how letter "p" goes just a little bit out of titlebar. There is also more shadow under it.

After adding to head of my page this (copied from missing.style):
<link rel="stylesheet" href="https://fonts.bunny.net/css?family=source-sans-3:400,700|m-plus-code-latin:400,700">

Now it display box titlebar correctly in all browsers.
It seems to be documentation problem - maybe you should add this line to installation instructions?

not a documentation problem -- missing.css should (within reason) work with any font. this seems to be an issue with the box shadow on the text, i'll look for a solution


🐛 Change password type from String to Char[]

Char[] is better to deal with password as it remains less in memory than String. The password from the user input to sending to the provider should be char[]. The char[] should be overridden after it is used.

I think it will be hard to do this without changing of library that generate password. Indeed passay library doesn't allowed to give a char[] for validating password

Left for later.


Temporary Helm values files not cleaned from temp dir

Describe the bug:
When using components of  'type: helm', fab generate leaves temporary values files behind after it completes. Over time, many thousands of these accumulate in Tempdir
To Reproduce:
'fab generate -v' on any 'type: helm' component; the temporary file name will be shown in the output. The file will still exist after fab generate has completed.
Expected behavior:
No temporary files are left after fab generate completes.
Additional context:
I suspect adding a simple
defer os.Remove(absOverriddenPath)

immediately after https://github.com/microsoft/fabrikate/blob/master/generators/helm.go#L163
will fix the issue.

Thanks for the feedback. There's a pr incorporating your suggestion: fabrikate/pull/282


Update jboss-modules to 1.4.3.Final

Linux Build 1577 is now running using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e

Windows Build 1228 is now running using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e

Core - Full Integration Build 829 is now running using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e

Linux Build 1577 outcome was SUCCESS using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e
Summary: Tests passed: 3098, ignored: 66 Build time: 0:19:26

Windows Build 1228 outcome was SUCCESS using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e
Summary: Tests passed: 3098, ignored: 66 Build time: 0:20:23

Core - Full Integration Build 829 outcome was FAILURE using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e
Summary: Tests failed: 2 (2 new), passed: 2854, ignored: 412, muted: 1 Build time: 0:48:47
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.security.callerprincipal.GetCallerPrincipalTestCase.testStatelessLifecycle: <no details avaliable>

org.jboss.as.test.integration.ejb.remote.view.LocalViewRemoteInvocationTestCase.testLocalViewInvocationRemotelyOnSFSB: <no details avaliable>

Retest this please

Core - Full Integration Build 831 is now running using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e

Windows Build 1230 is now running using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e

Linux Build 1579 is now running using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e

Linux Build 1579 outcome was SUCCESS using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e
Summary: Tests passed: 3098, ignored: 66 Build time: 0:19:27

Windows Build 1230 outcome was SUCCESS using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e
Summary: Tests passed: 3098, ignored: 66 Build time: 0:20:22

Core - Full Integration Build 831 outcome was FAILURE using a merge of 5e9adba51be6d7b2a8e11cab8713afe126d8742e
Summary: Tests failed: 1 (1 new), passed: 2856, ignored: 412 Build time: 0:50:27
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.stateful.passivation.PassivationTestCase.testPassivationMaxSize: <no details avaliable>

Merged


hyprpm: wlr includes completely broken

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit 33a7b7bb6b307d6e4a093f75ffdda0419cd7ffaf  (core: fix on-empty workspace being called too often (6026)).
Date: Sat May 11 19:03:32 2024
Tag: v0.40.0-65-g33a7b7bb, commits: 4671

flags: (if any)

System Information:
System name: Linux
Node name: blkheart
Release: 6.8.9-zen1-1-zen
Version: #1 ZEN SMP PREEMPT_DYNAMIC Thu, 02 May 2024 17:48:53 +0000

GPU information:
0d:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 21 [Radeon RX 6800/6800 XT / 6900 XT] [1002:73bf] (rev c0) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:
  XWayland Primary Display by Zakk ver 1.0
  N_Stack layout by Zakk ver 1.0
  hyprsplit by shezdy ver 1.0
  River Layout by Zakk ver 1.0
  Monocle layout by Zakk ver 1.0
  hypreasymotion by Zakk ver 1.0
  Workspace layouts by Zakk ver 1.0

Bug or Regression?
Bug
Description
Commit in the systeminfo output is the commit where it still works.
Something after 33a7b7b broke hyprpm. I'd paste an output but it's 200+ lines of recursive include errors
I think it was the changes to makefile/pkg-config to 'fix wlr dir'.
After these changes there is a headersRoot/include/hyprland/wlr directory, which also contains a 'wlr' directory.
All the include files in the top wlr directory (like wlr/types/wlr_keyboard.h) have an #include <wlr/types/wlr_keyboard.h>.
I assume they really want to include wlr/wlr/types/include.h but are instead including themselves infinitely.
How to reproduce
Use hyprpm
Crash reports, logs, images, videos
No response

@fufexan


How to change service path in Zuul route

I want to re-write my URL to map to a specific service path.
I want to route /orders** to /api/v1/** on the micro service. An example full endpoint could be /orders, and it would map to the microservice at this full endpoint /api/v1/function1.
I'm using Eureka Service Discovery, so I can't use uri. Here is my application.properties:
zuul.routes.orders.path=/orders/**
zuul.routes.orders.serviceId=order-service
zuul.routes.orders.stripPrefix= true

I tried using a custom path filter as mentioned here
    @Override
    public Object run() {
        RequestContext context = RequestContext.getCurrentContext();
        Object originalRequestPath = context.get(REQUEST_URI_KEY);
        String modifiedRequestPath = "/api/microservicePath" + originalRequestPath;
        context.put(REQUEST_URI_KEY, modifiedRequestPath);

        return null;
    }

Hello @nazrul-kabir. Spring Cloud Netflix Zuul has been out of support for quite some time now. We strongly recommend migrating over to Spring Cloud Gateway in order to avoid security issues.

I did it just like that, with a custom path filter, with the only difference i supplied custom configuration properties to not hard code the path on the service. And I had a specific order on it:
// Must run after the pre-decoration filter
protected static final int FILTER_ORDER =  PRE_DECORATION_FILTER_ORDER + 1;

When I saw this, I gave up completely

Rewrite the RequestContext requestURI only using Filter before RibbonRoutingFilter

Please do not use Spring Cloud Netflix Zuul. It has been out of maintenance for years now. You're exposing yourself to security vulnerabilities by using it. Please use Spring Cloud Gateway.


Create a docker build for the website and the api

The website and api will need to run inside docker containers - we should create docker files for each of them. These only need to be for the final application at this point - it is unclear whether the build steps could get information about where the build fails inside the docker file so we'll extend these files later.
It's important that the docker files only install the production dependencies (not dev-dependencies) in order to reduce the size of the image. They should also be based off a small image (e.g. node-alpine) to improve performance.
Acceptance Criteria

[x] A docker file exists, builds and runs for the website.
[x] A docker file exists, builds and runs for the api
[x] The base image should be a lightweight container unless a good technical reason is defined.

All acceptance criteria has been in the following ways:

A docker file exists, builds and runs for the website.

A docker file exists, builds and runs for the api.
A docker-compose file for the website/api exists in the src/Docker folder. docker-compose build and docker-compose up run with no error.

The base image should be a lightweight container unless a good technical reason is defined.
Alpine is being used, which is the lightest version of Node that can be used.


Automatically commit/create changesets on PR's from specific users

Affected Packages
None

Problem
We use https://github.com/apps/renovate to update our dependencies.
Is there a way to configure changeset so that it automatically commits the default template to the PR?
The default changeset looks like this:
---
"@apps/my-app": patch
---

chore(deps): update all non-major dependencies

Proposed solution

I'm just going to drop this here: https://github.com/mscharley/dependency-changesets-action


can't we get a link to the image we uploaded in the spreadsheet?

i have a image

but in json is empty

Unfortunately, my understanding is that the Google Sheets API doesn't allow for retrieving these images (e.g. https://stackoverflow.com/a/56140419).


Adding a Project Structure Map in the Documentation.

Add a clear structure map in the documentation to guide contributors on where specific files and folders are located and what they contain.
For example:
Project Root
├── src/                   # Core application files
│ ├── components/                              # Reusable UI components
│ ├── services/                                     # API calls and business logic
│ ├── utils/                                          # Utility functions
│ └── index.js                                     # Main entry file
├── assets/                                        # Images, icons, and other static assets
├── config/                                         # Configuration files (e.g., env variables)
└── README.md                                 # Project overview and instructions
This helps new contributors quickly understand the project layout and find files easily.
Note: please kindly assign this issue under gssoc-extd and hacktoberfest-accepted and level

@siri-chandana-macha You can get started

@siri-chandana-macha when can i expect you to complete this issue ?

By tomorrow I will complete


problem in csv when in comment column several lines or special characters

Hi
problem in csv when in comment column several lines or special characters

For example

if several lines in comments of the rules the CSV is cutted in several lines
if several lines in description of the objects the CSV is cutted in several lines

check also with host having a space in name ( Checkpoint convert it to special characters ) could be potentiel a issue
Thank you

Hi @pepjm ,
Could you please upload examples? Are you experiencing any failures due to this?
Regards,
Eden


test(DropdownMenu): DropdownMenu screenshot test

Summary
DropdownMenu
Github issue: #485
Permutation dimensions to include

[x] title: [sample title text], undefined
[x] search: false, true
[x] groupBy: [no], [yes]
[x] component: [Tag component], undefined

Exceptions, notes

[x] Find out how groupby options are specified, and how to not specify it
details is currently controlled by DropdownMenu, however it is not included in this test because it is going to soon be switched to be under the control / a prop of MenuItem instead.

Here's a screenshot of the layout:

Checklist

[ ] Default Story in Storybook
[ ] LivePreview Story in Storybook
[ ] Test Story in Storybook
[ ] Tests written
[ ] Variables from defaultTheme.ts used wherever possible
[ ] If updating an existing component, depreciate flag has been used where necessary
[ ] Chromatic build verified by @chanzuckerberg/sds-design

Copying a comment from @tihuan that was left in the TagFilter Screenshot Test PR, but I think was actually supposed to be a comment in this PR:

Looks like the DropdownMenu components are overlapping in the screenshot. Maybe we just need more spaces among the dropdowns?
Thank you!

I will make this change now! Hopefully it won't be messed up since I already clicked on "Update branch" (or something like that) button above, but I haven't merged it yet, so should be okay to still make changes

Oops I accidentally merged this one before making the update :( I will try to fix this by doing "Restore branch" and making the change...

EDIT: @tihuan I know why they are overlapping... bascially, the dropdowns automatically change whether they are above or below the input in order to ensure they are always visible on the screen. I didn't think it'd do it in the Chromatic screenshot, since I thought it took a pic of everything in the UI without any regard to a screensize... I will see if there's a way to force DropdownMenu to always be below.

Oops I accidentally merged this one before making the update :( I will try to fix this by doing "Restore branch" and making the change...

Actually I will just make a new branch + PR to fix this. And I will be just adding a LOT of top-margin to each iteration,  to ensure they never overlap each other, regardless of whether they render on top or bottom!


Create a subcommission site template

Each subcommission's mini site could use a template site created to ensure all subsites retain some ICS branding and a similar style.
Create a template repo and/or a repo per subcommission.

In progress: https://github.com/i-c-stratigraphy/subcommission-template

Used for lots of sites now


SSR Issue

Hi
Trying to use this on a NextJS 14 project, and  to render server side, it fails.
Using the 'use client'; directive, it works, the following is the error :
TypeError: (0 , react__WEBPACK_IMPORTED_MODULE_0__.createContext) is not a function
    at eval (webpack-internal:///(rsc)/./node_modules/@szhsin/react-accordion/dist/es/utils/constants.js:17:91)

The code at fault seems to be
const AccordionContext = /*#__PURE__*/createContext({}); which is trying to access the context which si only available client side and not server side.
Thanks.

Hi @Jimflip ,
thanks for bringing it up. I will be adding the 'use client' directives to the library in the next release to make it compatible with React Server Components.


[BUG] #import in custom kernels doesn't support relative paths

When I describe an include header for a custom kernel, I must provide full path. I.e. if I place the .metal file in the same folder as my python file it cannot find it. I assume the path at which the compile is executed must be different from where my python file is.
This is what my header looks like in order for it to work:
 header = '#import  "/Users/username/Dev/mlxray/loki.metal"'
I expect this to work given that I'm running it from a python file that's in the same folder as the loki.metal:
 header = '#import  "loki.metal"'

Getting paths working is a bit messy and I don't really advise doing it this way.  Instead you can have a lot more flexibility on where you put the header if you pass the custom_kernel the header source code directly. Concretely that would just be:
with open("loki.metal", 'r') as f:
  header = f.read()

## And then pass it to custom kernel
mx.custom_kernel(..., header=header, ...)

But I can in fact just write tooling around it that concatenates everything into one big header.

Exactly! We may add an includes argument in the future which would basically do exactly that. But it is tricky to get paths working correctly especially if you plan to distributed what you are building as a package.. so I think it's better to encourage the approach of putting it all in one big header.


Add command line switch to rename _apid_scope column

This column name will vary per-schema of users using the product. This should be as simple as a command line argument to set the column name

Initial diff for this is here: https://github.com/seatme/transicator/compare/feature/viper...seatme:feature/configure-scope-column?expand=1
It's stacked behind our viper & rocksdb work, so I'll wait until the pull requests start merging in order to get this up as a pull.

Taken care of with your patch and the new "-S" flag.


Is it possible to implement an adaptive dialog?

first of all, many thanks for this great package and great support.  👍😄
I thought of something. Is it possible to make the UI adaptive? For IOS and Android?
I don't know if Apple would say anything if you want to release an app with this package.
A suggestion and a question at the same time. 🙃
Greetings and thaaanks!

I added an example for a custom cupertino style like dialog.


How to structure large apis using hono?

Traditionally using express I would have this file structure:
── routes
    ├── index.js
    ├── users.route.js
── index.js

And then in users.route.js I would define all my routes relating to users e.g.
const router = express.Router();

router
  .route('/')
  .post(auth('manageUsers'), validate(userValidation.createUser), userController.createUser)
  .get(auth('getUsers'), validate(userValidation.getUsers), userController.getUsers);

router
  .route('/:userId')
  .get(auth('getUsers'), validate(userValidation.getUser), userController.getUser)
  .patch(auth('manageUsers'), validate(userValidation.updateUser), userController.updateUser)
  .delete(auth('manageUsers'), validate(userValidation.deleteUser), userController.deleteUser);

module.exports = router;

In routes/index.js I would apply the base urls to all my defined routes and then in the top level index.js I would import and enable them:
// v1 api routes
app.use('/v1', routes);

What is the recommended way of doing this in Hono?

Hi @OultimoCoder
Currently, we can write routing using route like this:
export const app = new Hono()

const root = app.route('/v1')
root.get('/', (c) => c.text('getUsers'))
root.post('/', (c) => c.text('createUser'))

And, This syntax may be available in the next release.
root.post('/', basicAuth(), cors(), (c) => c.text('getUsers')) // <--- this syntax is coming soon!

I think this is not such a smart design for large APIs, so I want to add another way for routing, such as below:
import { Hono, Route } from 'hono'

const app = new Hono()
const route = new Route()

route.get('/entry', handler, handler).post(handler, handler)

app.use('/v1', route)
app.fire()

This is still just the idea.
Conclusion, please use app.route method. Thank you.

@OultimoCoder
This feature is already implemented #203 .
We are planning to emit this feature in the next release v1.2.0. Maybe its' soon!

@OultimoCoder
We released v1.2.0. See: https://github.com/honojs/hono/releases/tag/v1.2.0.

Hi @OultimoCoder
Route is deprecated. Please use the Hono instance!
https://github.com/honojs/hono#grouping


Description too dense

The current description is too dense:
A way to automatically build websites with visualizations that help explore the implicit community of an Awesome List or other list of GitHub repos

improved a bit at least


[BUG] 4.0 does not detect manually configured MQTT integration

Describe the bug
When the MQTT integration is manually configured (i.e., in configuration.yaml), the addon does not pick up this configuration and repeatedly tries and fails to contact a (nonexistent) broker on localhost instead (see debug logs).
MQTT broker configuration:
mqtt:
  broker: ariadne.arkane-systems.lan
  client_id: hass-on-hass
  discovery: true
  discovery_prefix: homeassistant

Debug Logs
-------------------------------------------------------
| Ring Device Integration via MQTT                    |
| Addon for Hass.io                                   |
|                                                     |
| Report issues at:                                   |
| https://github.com/tsightler/ring-mqtt-hassio-addon |
-------------------------------------------------------
ring-mqtt.js version 4.0.0
Node version v12.18.3
NPM version 6.14.6
git version 2.26.2
-------------------------------------------------------
Running "npm audit fix" to update packages with any vulnerabilities...
up to date in 7.945s
25 packages are looking for funding
  run `npm fund` for details
fixed 0 of 1 vulnerability in 420 scanned packages
  1 vulnerability required manual review and could not be updated
-------------------------------------------------------
Running ring-mqtt...
[06:42:28] ERROR: Got unexpected response from the API: Service not enabled
2020-09-05T11:42:29.995Z ring-mqtt Using configuration file: /data/options.json
2020-09-05T11:42:30.001Z ring-mqtt Reading latest data from state file: /data/ring-state.json
2020-09-05T11:42:30.174Z ring-mqtt Attempting connection to Ring API using saved refresh token.
2020-09-05T11:42:32.047Z ring-mqtt Connection to Ring API successful
2020-09-05T11:42:32.048Z ring-mqtt Starting connection to MQTT broker...
2020-09-05T11:42:32.776Z ring-mqtt Unable to connect to MQTT broker. connect ECONNREFUSED <IP_ADDRESS>:1883
2020-09-05T11:42:32.782Z ring-mqtt File /data/ring-state.json saved with updated refresh token.
2020-09-05T11:42:33.782Z ring-mqtt Attempting to reconnect to MQTT broker...
2020-09-05T11:42:33.786Z ring-mqtt Unable to connect to MQTT broker. connect ECONNREFUSED <IP_ADDRESS>:1883
2020-09-05T11:42:34.788Z ring-mqtt Attempting to reconnect to MQTT broker...
2020-09-05T11:42:34.791Z ring-mqtt Unable to connect to MQTT broker. connect ECONNREFUSED <IP_ADDRESS>:1883
2020-09-05T11:42:35.793Z ring-mqtt Attempting to reconnect to MQTT broker...
2020-09-05T11:42:35.796Z ring-mqtt Unable to connect to MQTT broker. connect ECONNREFUSED <IP_ADDRESS>:1883
2020-09-05T11:42:36.798Z ring-mqtt Attempting to reconnect to MQTT broker...
2020-09-05T11:42:36.801Z ring-mqtt Unable to connect to MQTT broker. connect ECONNREFUSED <IP_ADDRESS>:1883
2020-09-05T11:42:37.803Z ring-mqtt Attempting to reconnect to MQTT broker...
2020-09-05T11:42:37.804Z ring-mqtt Unable to connect to MQTT broker. connect ECONNREFUSED <IP_ADDRESS>:1883
2020-09-05T11:42:38.806Z ring-mqtt Attempting to reconnect to MQTT broker...
2020-09-05T11:42:38.809Z ring-mqtt Unable to connect to MQTT broker. connect ECONNREFUSED <IP_ADDRESS>:1883
2020-09-05T11:42:39.811Z ring-mqtt Attempting to reconnect to MQTT broker...

Hmm...interesting.  The addon docs don't provide any indication that this information is only available for web configuration of the MQTT integration, although I admittedly didn't test that scenario.  What version of HA are you running?

To be clear, are you using an external MQTT broker, i.e. not the Mosquitto addon?

I thought I would comment here rather than raising a new bug, as I am facing a similar issue - however, please let me know if I should open a new bug.
My MQTT server has been set up using the UI (Integrations) and not via configuration.yaml. For some reason, the plugin logs show the same issue in that it attempts to connect to <IP_ADDRESS>. This has started happening from earlier today. I've tried to remove the MQTT integration and re add it, but I am still facing the same issue.
I am using an external MQTT broker - Mosquitto, but on a different machine on the network.
My HA version is 0.114.4

Same issue here and I'm using the Mosquitto addon.

@tsightler I'm running 0.114.4, supervisor 235.
And, yes, an external MQTT broker - Mosquitto, but independently installed on a different host. (I was using it for MQTT with Node-RED etal. before I started using Home Assistant, so...)

(Incidentally, for anyone looking for a workaround in the interim, I'm able to get things working by running
docker exec -it addon_a98c085d_ring_mqtt bash
then within the container
vi run.sh
and replace the latter parts of the four export MQTTfoo= lines with the relevant values. Then exit the container, and restart its contents (only) with
docker restart addon_a98c085d_ring_mqtt
This, of course, doesn't save the changes to the container back to the image, so you'll need to repeat this process whenever the add-on is restarted. But then, it's only a workaround and how often do we restart things anyway?)

Yeah, I think I didn't anticipate the case where people were using external brokers.  The docs talk about addons consuming the services API for this, but after a little digging it's clear that this only works if you are using a broker that supports the Home Assistant MQTT provider service API, such as the standard Mosquitto addon.  If you are using a broker that doesn't provide this service, Home Assistant obviously can't handle automatic account management or discovery.
That being said, I think it may still be possible to detect the Home Assistant MQTT configuration automatically and just use that.  If not, I'll push an update to allow manual override of the automatic detection, either later tonight or sometime tomorrow.  Thanks for the report!

I'm having the same issue. I am using a mosquitto broker installed on my synology NAS on a separate IP w/ username and password. Prior version of the Ring MQTT Hassio add-on worked with manual configuration options. It is trying unsuccessfully to connect to <IP_ADDRESS>
I tried to manually add variables in configuration, it does not read them:
enable_cameras: false
enable_modes: false
enable_panic: false
ring_token: ''
location_ids:
  - ''
host: <IP_ADDRESS>
port: 1883
mqtt_user: myusername
mqtt_pass: mypassword

Error:
-------------------------------------------------------
| Ring Device Integration via MQTT                    |
| Addon for Hass.io                                   |
|                                                     |
| Report issues at:                                   |
| https://github.com/tsightler/ring-mqtt-hassio-addon |
-------------------------------------------------------
ring-mqtt.js version 4.0.0
Node version v12.18.3
NPM version 6.14.6
git version 2.26.2
-------------------------------------------------------
Running "npm audit fix" to update packages with any vulnerabilities...
up to date in 1.679s

25 packages are looking for funding
  run `npm fund` for details

fixed 0 of 1 vulnerability in 420 scanned packages
  1 vulnerability required manual review and could not be updated
-------------------------------------------------------
Running ring-mqtt...
[23:38:22] ERROR: Got unexpected response from the API: Service not enabled
2020-09-06T05:38:23.123Z ring-mqtt Using configuration file: /data/options.json
2020-09-06T05:38:23.125Z ring-mqtt Reading latest data from state file: /data/ring-state.json
2020-09-06T05:38:23.175Z ring-mqtt Attempting connection to Ring API using saved refresh token.
2020-09-06T05:38:24.547Z ring-mqtt Connection to Ring API successful
2020-09-06T05:38:24.548Z ring-mqtt Starting connection to MQTT broker...
2020-09-06T05:38:24.656Z ring-mqtt Unable to connect to MQTT broker. connect ECONNREFUSED <IP_ADDRESS>:1883

As noted above, I'm working on this issue to allow manual override of the auto detection.  However, auto detection should work if you are using a recent version of the Mosquitto addon.  Can you share more details of you MQTT setup?  Are you using the Mosquitto addon and is it a recent version or are you using an external MQTT broker?

@tsightler I am using an external MQTT broker (on my Synology) that is configured manually in configuration.yaml. On latest version of home assistant. Thanks

Thanks @yieldhog, that's what I was expecting.  I guess I significantly underestimated the number of people using external brokers as I expected most would just use the default Mosquitto broker since it is now so highly integrated into the HA services model.  I'm currently working on re-introducing a method to manually override automatic service discovery.  Should be later today.

I'm using the most recent Mosquitto addon and integration versions and have the same "Unable to connect to MQTT broker. connect ECONNREFUSED <IP_ADDRESS>:1883" issue.
Mosquitto addon config:
`logins:

username: xxxxx
password: xxxxx
anonymous: false
customize:
active: false
folder: mosquitto
certfile: fullchain.pem
keyfile: privkey.pem
require_certificate: false`

The Integration host is set to 'localhost'.

I have pushed version 4.0.1 which includes improvements to the auto detection logic to cover more configurations and allows for manually overriding MQTT service auto detection.  Those that are having trouble please give it a try and thanks to those that shared details on their configuration.

All working now, although I have MQTT already set up via the UI, it picked up a random IP address for the MQTT server (<IP_ADDRESS>), so I ended up setting the mqtt_host manually. It's now it's all working as expected.
Many thanks for the update!

172.30.32,1 is not a random ip address, it should be the internal host adresses for the network used by docker containers which should work just like the host address.  The addon is hard coded to use this address if discovery via the API fails.

Hi @tsightler I am not getting any option to update to 4.0.1, using the Hassio add-on on HA 0.114.4

@saabirsa Sorry, didn't finish my message as I was on my mobile and accidentally sent the message prior to completion.  Are you saying that it didn't work with the <IP_ADDRESS> address?  What address did you have to use?  I debated over attempting to detect the actual host IP address from it's primary interface, there's actually a way to do it via bashio, but it didn't seem to be required as every single setup I checked had the <IP_ADDRESS> address on the host.
@yieldhog I don't really have any control over when your system decides to scan for an update, but you do.  You should be able to go to the Add-on store, click the three dots in the right corner, and choose reload and the update should become available immediately,  Worst case, removing and re-adding the repo will do it.

@tsightler not a problem. Yes that's correct, it didn't work with the auto-detected <IP_ADDRESS> address. To provide a bit of context on my setup, I have a Windows machine running a Mosquitto MQTT broker. This machine also has a Hyper-V install of HA with its own assigned IP address. HA was already set up with this MQTT broker via the UI during the initial setup process.
To allow this plugin to work, I had to manually configure the mqtt_host to the IP address of the Windows machine with the Mosquitto broker installed.
If it helps, here is the output from the log, when leaving mqtt_host to <auto_detect>:
-------------------------------------------------------
| Ring Device Integration via MQTT                    |
| Addon for Hass.io                                   |
|                                                     |
| Report issues at:                                   |
| https://github.com/tsightler/ring-mqtt-hassio-addon |
-------------------------------------------------------
ring-mqtt.js version 4.0.2
Node version v12.18.3
NPM version 6.14.6
git version 2.26.2
-------------------------------------------------------
Running "npm audit fix" to update packages with any vulnerabilities...
up to date in 2.802s
25 packages are looking for funding
  run `npm fund` for details
fixed 0 of 1 vulnerability in 420 scanned packages
  1 vulnerability required manual review and could not be updated
-------------------------------------------------------
No Home Assistant MQTT service found, using defaults
Using default MQTT Host: <IP_ADDRESS>
Using default MQTT Port: 1883
Using anonymous MQTT connection
-------------------------------------------------------
Running ring-mqtt...
2020-09-07T08:08:58.797Z ring-mqtt Using configuration file: /data/options.json
2020-09-07T08:08:58.799Z ring-mqtt Reading latest data from state file: /data/ring-state.json
2020-09-07T08:08:58.863Z ring-mqtt Attempting connection to Ring API using saved refresh token.
2020-09-07T08:09:01.136Z ring-mqtt Connection to Ring API successful
2020-09-07T08:09:01.137Z ring-mqtt Starting connection to MQTT broker...
2020-09-07T08:09:01.220Z ring-mqtt Unable to connect to MQTT broker. connect ECONNREFUSED <IP_ADDRESS>:1883

@saabirsa Thanks very much for the details and for sharing the output.  It looks as I would expect.  You were using an external broker, which cannot be automatically detected, but the script was configured for auto detection.  It properly report that it could not find a Home Assistant MQTT service (when using the locally installed Mosquitto addon it registers itself with the Home Assistant Services API so that it can be queried automatically).  Since the addon was configured for auto detection, but it was unable to find a service, it simply failed back to defaults, which is to use the internal IP of the host, default port, and anonymous connection.  I don't expect this will work for very many people, but at least some users have reported that it previously worked with the old defaults which used localhost/<IP_ADDRESS> and these new defaults are basically the same as that, but using the internal docker IP instead of localhost since I'm no longer running the addon on the host network, so I thought it was a decent fallback option for the case where discovery via the API service fails.
Basically, looks like everything is working as expected with 4.0.1.  Thanks for all of the additional details!

@tsightler not a problem, that all seems logical to me. Thank you once again for pushing out an update so quickly.

@cerebrate Any chance you could confirm that 4.0.1 or later (I also pushed another minor update to 4.0.2 related to volume support for base stations and keypads) has addressed this issue for you?  I don't see how it could not since you can now manually define the MQTT settings when using an external broker, but just to be sure before I close this issue.
Much thanks to everyone who shared their details while working through this issue.  I guess I was too optimistic over the method that HA provides for auto service discovery, perhaps it will cover more cases in the future.
For those that are using fully integrated Mosquitto addon with integrated user management, if you are still having an issue, sharing your details would be very useful.

@tsightler Sorry for the delay in getting back to you. 4.0.1 and 4.0.2 are working great for with manual configuration, so I'll go ahead and close this now. Thanks muchly for sorting it out so quickly!


Enumerate interactive cells and indicate corresponding output cell

It would be nice if the extra space available in the line number column thanks to the "Run Cell | Run Above | Run Below" commands above Python interactive cells was used to enumerate the cells and indicate the number of the (latest) corresponding output cell in the interactive window if one exists.

The format could be #1 [1] or just #1 if no output was generated for that cell yet.

Just saw this related PR: #6338.

Sorry that PR (#6338) has to do with debugging, not mapping cells in the code.
What you're asking for is not renderable at the moment. VS Code only allows icons in the gutter icon (like a breakpoint). We might be able to add a decorator into the editor itself though. Or perhaps change the Run Cell code lens.

Sorry that PR (#6338) has to do with debugging, not mapping cells in the code.

Oh, sorry for the confusion. I thought the same or similar association might have been reused for my suggestion.

We might be able to add a decorator into the editor itself though. Or perhaps change the Run Cell code lens.

Yep, that would certainly work as well!

Oh, sorry for the confusion. I thought the same or similar association might have been reused for my suggestion.

Actually the same service could probably be used to implement this as well. Good idea.

Would be nice to have the line numbers match too.

Line number match requires matching up a cell with the file it was in and figuring out that the exception trace is pointing at that cell/file.


Tracks...

Developing a track at CYF

@SallyMcGrath build a track template in the new curriculum format.
@CodeYourFuture/cyf-programme-team define review and approval process with @CodeYourFuture/syllabus-team before tracks can be accepted

Start criteria like Portfolios
Success criteria like SDC
Associated modules and backlogs
Mandatory project and demo (on Fridays we do demos)
Projects

Update on this
I'm porting Cloud and trying to get vols to respond
I've drafted Design and met with Alec about that
I think microcreds will help


Should we remove TriggeringEventFilterBox?

          IMO we should remove `TriggeringEventFilterBox` and have only `EventFilterBox`. Is there a good reason why we have it?

Originally posted by @mversic in https://github.com/hyperledger/iroha/pull/4375#discussion_r1530447568

Introduced in #3789


ID-18 – add Stripe customer ID to JWTs

Codecov Report
Base: 62.53% // Head: 62.72% // Increases project coverage by +0.19% :tada:

Coverage data is based on head (ba5b90d) compared to base (fe149ac).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #13      +/-   ##
=============================================
+ Coverage      62.53%   62.72%   +0.19%
- Complexity       129      130       +1
=============================================
  Files             23       23
  Lines            387      389       +2
=============================================
+ Hits             242      244       +2
  Misses           145      145

Impacted Files
Coverage Δ

src/Application/Actions/Login.php
52.00% <100.00%> (ø)

src/Application/Actions/Person/Create.php
87.09% <100.00%> (ø)

src/Application/Auth/Token.php
93.33% <100.00%> (+0.47%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Deleting my mask left the gray overlay

history-1091.txt

lolz. there's a super tiny rectangle you accidently drew. do you think the min size should be like... 5 pixels?

if you want me to bikeshed it, maybe 2 or 4 pixels. (I want to error on the small side because you never know what weird things users will want to do with the freedoms we give them. i don’t view this as a bad thing.)

On Apr 5, 2017, at 9:15 PM, Greg Ziegan<EMAIL_ADDRESS>wrote:
lolz. there's a super tiny rectangle you accidently drew. do you think the min size should be like... 5 pixels?
https://cloud.githubusercontent.com/assets/3099999/24737616/dc4509e2-1a44-11e7-9773-f47fe9310a5b.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/thebritican/goat/issues/25#issuecomment-292064384, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAamPGJn6j1WfjI0BZMwmFQvkde4DSfks5rtGbNgaJpZM4MzlZw.

I'm thinking we start the drawing at 0,0 and if the user draws anything smaller than 2 or 4 pixels we just cancel the drawing

oh FWIW a bigger min drawing distance makes sense for SPOTLIGHT shapes (e.g. the ones that created this issue) than REGULAR shapes. A spotlight shape so small you can't see 'through' it is dumb, and leads to confusion like mine.
I didn't fully understand earlier - i lacked context when I replied by email. My bad.


RS256 not working

I am currently using emqx broker on kubernetes with anonymous auth internally.
Now wanted to expose it through websocket and was trying to use this plugin for auth.
However it turns out only HS256 alg type works with a secret.
I am using the latest emqx/emqx docker image v3.2.3, see startup logs:
node.max_ports=1048576
listener.tcp.external.acceptors=64
auth.jwt.secret=secret
listener.ssl.external.acceptors=32
node.process_limit=2097152
node.max_ets_tables=2097152
auth.jwt.verify_claims=off
listener.ws.external.acceptors=16
auth.jwt.pubkey=/etc/certs/issuer_cert.pem
auth.jwt.from=password
<EMAIL_ADDRESS>EMQX_LOADED_PLUGINS=emqx_management | emqx_dashboard | emqx_retainer | emqx_recon | emqx_auth_jwt
emqx v3.2.3 is started successfully!

I've configured both secret and public key.
secret: secret (i know this is not secure)

This cred works with the password field:

eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJuYW1lIjoiYm9iIiwiYWdlIjoyOX0.pbkBN3mEWDb2a6mLkoLXRirneliafU8ww_OhmuC1kI4

This one gives invalid_signature as expected:

eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJuYW1lIjoiYm9iIiwiYWdlIjoyOX0.pbkBN3mEWDb2a6mLkoLXRirneliafU8ww_OhmuC1kI4

Both above token is HS256.
Now this RS256 token gives weird error:
eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.FThNm4IGfWKNfZxrVjrzqUz3p7l5lm3b-HpbhqZhukNylQWx643ulhGznn4JdZqL8eYwp9Vevk2IB5Jm_VoUWODK9mKOnlzd9wVHwuJ1I8YcQuDBqe1ySOhZwqWSQWhnLEtpk6MrDCV8qQDqmDFFvN0nvzdqoyQlJzrud32RdykvjrkJGgiNhTCCPSJUHnDv2GP2E7930IHPEU2HvQvhqYgXeO6e_xhC0KlAMUSlG5yaaVxOTMXlEgjKy9l_U0Mrg3W0Q5DcYLIrIkRjnxI_SE2OKAdKxre0Zj-HbU9aJqvSAIOgjDDfJ-ddV7VgF_llZlvOze87HfvTRB5VwIGHkA

Error in log:
2019-09-16 05:22:47.512 [warning] test_client@<IP_ADDRESS>:57430 [Protocol] Client test_client (Username: 'test_user') login failed for badarg

I used RS512 , when i tried to verify with pub key I get
login failed for {badmatch,[]}

@muhun Which emqx version used?
I have fixed the RS256/RS512 compatibility with others platform on v4.0.7 https://github.com/emqx/emqx-auth-jwt/pull/115
Maybe you can try it for settting:
auth.jwt.signature_format = raw


sanitycheck: fix --board-root parser to enable multiple path args

accidently? removed during sanitycheck refactor
Signed-off-by: Thomas Stilwell<EMAIL_ADDRESS>

accidently? removed during sanitycheck refactor

yes.