[WIP] Final page UI changes

This includes the design layout for the final UI page. It is WIP as more code refactoring will be needed to accommodate the channels components.

Codecov Report

Merging #1321 into master will decrease coverage by 0.6%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1321      +/-   ##
==========================================
- Coverage   93.67%   93.06%   -0.61%
==========================================
  Files          45       45
  Lines        4696     4776      +80
  Branches      513      806     +293
==========================================
+ Hits         4399     4445      +46
- Misses        297      304       +7
- Partials        0       27      +27

Impacted Files
Coverage Δ

browser/pages/start/controller.js
97.14% <83.33%> (-2.86%)
:arrow_down:

browser/model/devstudio-autoinstall.js
97.29% <0%> (-2.71%)
:arrow_down:

browser/services/request.js
97.61% <0%> (-2.39%)
:arrow_down:

browser/pages/install/controller.js
91.86% <0%> (-1.75%)
:arrow_down:

browser/model/helpers/downloader.js
95.53% <0%> (-1.68%)
:arrow_down:

browser/model/che.js
95% <0%> (-1.62%)
:arrow_down:

browser/services/platform.js
97.05% <0%> (-1.41%)
:arrow_down:

browser/pages/account/controller.js
98.61% <0%> (-1.39%)
:arrow_down:

browser/model/cdk.js
98.74% <0%> (-1.26%)
:arrow_down:

browser/model/devstudio-p2-zip.js
64.4% <0%> (-1.12%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8f38a...ed102d6. Read the comment docs.

Card structure for the Getting started page is added as a directive.

The links are working for the different components.

test this


pretrained_models.zip

HI, where is the file?

Have you got the pretrained_models.zip now? Really need it!

why are you using this in 2024? genuinely curious @GNOTAD

@apoorvumang Thanks so much for your response! I'm currently working on KGQA based on KGE. but the recent works of KGQA based on KGE either lack source code (e.g., GIRFM-KGQA, Hic-KGQA) or have issues with their code or have unclear instructions (e.g., Rce-KGQA, BiNet). As I'm not very experienced with programming, building models from scratch and tuning hyperparameters is quite challenging for me.
Your EmbedKGQA work is groundbreaking and has set a solid paradigm for the application of KGE in KGQA. So I still wish to explor based on this work. Do you still have the pretrained_models.zip? Alternatively, could you please share the best hyperparameter settings for pretraining ComplEx on MetaQA-full/half and WQSP-full/half?
Thank you very much for your help!

thank you for your compliments, but I have a bigger question:
Why are you working on KGQA? Is it solving a real world problem, or part of a solution to a problem? We have LLMs now which are pretty good reasoners - do they not solve the kind of problem you are working on?
Or is this part of a research project or course project? Just want to know what got you interested in this in the first place

@apoorvumang Thank you for your questions. It's my research project, which mainly focuses on KG and KGE. I completely agree with your views on LLMs. After my graduation, I may indeed shift my focus towards LLM-related area. However, at this stage, my work is still centered on KGQA.
I appreciate your understanding. If you could provide the pretrained_models.zip file, I would be very grateful!

I really need this file,too

@apoorvumang Thank you for your questions. It's my research project, which mainly focuses on KG and KGE. I completely agree with your views on LLMs. After my graduation, I may indeed shift my focus towards LLM-related area. However, at this stage, my work is still centered on KGQA.
I appreciate your understanding. If you could provide the pretrained_models.zip file, I would be very grateful!

I really need this file,too


[Sandbox - bug inspector] The inspector does not show up in the sandbox

Hi,
I saw that the inspector was not working on the sandbox.
https://sandbox.babylonjs.com/
I tried to find where the bug was and I saw that if I replaced  the preview.babylonjs.com version of the inspector by the cdn.babylonjs.com version it work.
I think it was working yesterday so it must be an update from the last 30 hours that brock it.

Good catch
will fix it asap!

Is this related ? i'm not able to use the inspector anymore :

Yes, it is related. I'm working on a fix right now, will commit a fix later today.
The sandbox now works, with a small issue of missing GUI elements.

The inspector is not working outside the sandbox either.
Running:
scene.debugLayer.show();
Gives the following error:
Inspector.ts:190 Uncaught ReferenceError: Split is not defined
at new e (Inspector.ts:190)
at t._createInspector (babylon.js:30)
at t.show (babylon.js:30)
at :1:18
Thanks!

It was merged a few minutes ago:)
I will push a nightly asap


Add local dev server

Add a local development server with livereload using the Grunt tasks grunt-contrib-connect and connect-livereload
Add demo link to README
Add instructions on how to start local development server to README

Notes:

I commented out line 97 in gruntfile.js out as the javascript files doesn't need to get build every time the site reloads
Lines 68-69 in index.html should be removed from production, I'm not sure how to do it
You should find a way to handle the import of the file deployment in gruntfile.js as I had to comment out the import to be able to run anything using grunt

Questions:

I'd like to add a lint task to this project which will require some work just to get the syntax looking the same, so before I begin I'd just like to get an OK from you. If it's an OK from you then please share your indentation preferences as it's obvious we're working in different IDEs (my IDE, WebStorm, shows that all indentation looks good but looking at the files in this commit on GitHub I see that's not the case).
Can the files in src/js/dependencies be installed via npm instead?

And finally, thanks for a very cool web app!

For point one, an .editorconfig would be a good option

Thanks for contributing! There are a lot going on in this PR.
I just fixed the readme part and added .editorconfig in the meantime, really good thing to have in the tool stack!
Including a local server and live reload is not so much my cup of tea since my version lives inside a Apache-based localhost...
I would be interested in seeing how dependencies can be handled via npm, maybe you can make a PR just for this purpose?

Nice job with the .editorconfig 👍.
About the dev server, why can't both options be available? Having a dev server based on grunt wont disturb your setup and improves the development environment for everyone else.
I'll see what I can do about the dependencies!

Not that I have any say in the matter, but for me, having the smallest barrier of entry to start contributing will help, even if that means you add LIve Reload and then never use it :+1:


Now that IBM is withdrawing from Swift, is Kitura going to die off?

Context and Description
A description of the issue.
As a new user of Kitura, and in light of the news IBM is going to withdraw from Swift I'm thinking about switching to Vapor, as I am very concerned now about putting a lot of effort into building something on a potentially dead end platform.
Thoughts?
Environment Details
Information about your OS, Swift version and Xcode version if on macOS.
Steps to Reproduce

...
...
etc

Expected vs. Actual Behaviour

[ ] Expected to happen...
[ ] Actually happened...

I'm wondering this as well.  I've been studying Kitura, working through tutorials,  and planning to build an extensive backend using Kitura but seeing the announcement just this morning I plan to abandon this plan.  I don't trust Vapor either, as that framework does not appear production ready, and is moving so fast it would be difficult to build a maintainable solution. It may also suffer from the version compatibilities as Kitura apparently does.
I'm looking at other solutions now - perhaps Python/Flask, where I can deploy micro services on AWS or other cloud services.  Staying with tried and true solutions appears safest and most maintainable for a server intended for production.

I've been using Kitura for the past 2 years. Now I'm in the middle of adding new features, while also migrating to Vapor. It certainly isn't a one-to-one process. Would also like to know the remaining lifecycle of Kitura.

Looks like IBM has abandoned Swift and Kitura:  https://www.theregister.co.uk/2019/12/20/ibm_istio_knative_tensorflow_should_be_under_open_governance/
It would be nice if Apple took up Kitura.

I rather like Kitura.  Are there any others in the community willing to join in keeping it going?

I would be more than pleased to keep it going.

IBM market oriented.

I think it should be community developed. Nice if Kitura and Vapor will interchangeable in case of packages and just possible to have two different coding styles

I've been using Kitura for several years now. And am also wondering where this is going to go.

I don't know where else to discuss this, but I'm considering just forking the project and doing what I can to help with pull requests.  @crspybits and @xeokeri what do you think?  Interested in helping to keep Kitura going?  Any others?

@dannys42 @crspybits I’m all for it. I’ve been using Kitura for my project for a few years. I tried refactoring to allow switching to another. Though, I was not happy with the end results. At this time, I would rather address fixing issues within Kitura, as well as adding features to it. Instead of jumping ship. Kitura was more stable than the other, too.

Thanks for reaching out @xeokeri. This is a large endeavor. For me, I have two concerns. I still want to continue work on my own personal project (currently, using Kitura). I emphasize personal here, as in I have limited time and no backing for server-side swift. Second, I'd have to figure out if my employer allows this. Like some employers, mine puts some limits on what I can do independently.
I'm curious about why your refactoring didn't work out. Sounds like you were trying to use Vapor. I haven't used others, but that's a definite possibility for me-- e.g., that I'd switch over to using, say, Vapor.
What would be great is if there could be some kind of other corporate backing behind Kitura. IBM has put a great deal of effort into this.

@crspybits For me, yes, it was Vapor. I fully converted the entire project over to Vapor 3, but had to wait for Vapor 4 to support my needs, that Kitura already did. I have 3 branches, other than master for my personal project. I kept both the Kitura and Vapor in parity, in separate branches. Although, the Vapor wasn’t as stable or reliable, to be honest. I also prefer the way Kitura works over Vapor. I need command line, web, and various parts. Vapor 3 wasn’t intended to work that way. Kitura was. Vapor 4, only in the last 48 hours, did I get a response to my issue posted to Vapor for the defects/docs/issues I was having to make it less forced to work as a web server always.

@crspybits I can totally sympathize.  I'm in a very similar situation with limited time and it's a purely personal endeavor.  I've tried using Perfect and Vapor, but I found Kitura is just much cleaner, functional, and consistent in behavior.  Vapor does seem to have a lot of community backing, but it just goes a little crazy with futures and I find it very difficult to work with.
I'd hate to see Kitura go away, so I was hoping to at least help keep it up-to-date with newer versions of swift and help with pull requests.  I'm not sure I'd be able to contribute significantly to any new features or issue requests.  But I figured an active maintainer is better than none especially if the community is willing to support it.

FYI there seems to be a few others interested on the Slack channel.  I'm going to make the fork, but I think to be safe trademark-wise we need a new name for the project.  Any ideas?

Maybe something with a play on the original name? Something prefixed with Kin, as in gold? Just a thought.

what is the current status of this framework?

@pckrishnadas88 I'm attempting to get this project to be community managed.  If you or anyone else is interested in contributing, please let me know!

@dannys42 Hey! Have you had contact with the IBM folks? It seems better if this can keep going under the present Git repos, IMO. It would give continuity to the location and branding of the code. Like I said before, I have limited time, but I am interested in this project, and could make sporadic contributions. E.g., previously I made a PR with the Kitura Credentials.

@pckrishnadas88 I'm attempting to get this project to be community managed. If you or anyone else is interested in contributing, please let me know!

I found only this framework promising in the swift world for web development in the enterprise world. Do you know why IBM dropped this project? People will contribute to the code as long as they feel there is someone really good leading the project.

Fenix? - new name :) @dannys42

Phoenix unless you want it spelled fenix.
On Thu, Aug 6, 2020 at 5:32 AM fabrijp<EMAIL_ADDRESS>wrote:

Fenix? - new name :) @dannys42 https://github.com/dannys42
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/IBM-Swift/Kitura/issues/1497#issuecomment-669899051,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABW4RF6NLWW4YAKTDIYF57TR7KPHVANCNFSM4KBZMWQQ
.

Hello all,
I have great news!  Kitura is going to be a community project from now on.  Please see https://forums.swift.org/t/kitura-is-now-a-community-project/39199 for the official announcement and discussions.  Don't hesitate to reach out if you have any interest in helping to shape the project in any way.
Thanks for the name contributions, but just to set the record straight there is no trademark issue after all, so Kitura will be keeping its name.  Sorry for any confusion I may have caused.
Thanks all and happy coding!

Very nice!! :). Congratulations!

Can we close this now?

Fine by me.  Thanks.
On Thu, Sep 17, 2020 at 6:11 PM Fouad Hatem<EMAIL_ADDRESS>wrote:

Can we close this now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Kitura/Kitura/issues/1497#issuecomment-694588974, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABW4RF32ZM2CVOQZ53U3C33SGKXTHANCNFSM4KBZMWQQ
.


Group messages broken?

I noticed that the current version does not seem to work for sending messages to groups.
(client.send returns True, but the message does not appear in the chat.)
I was able to get it working again, but was wondering if anyone else had this issue and if it warrants a PR.
Thanks.

Hi,
I have been trying to get the messages from a thread, and send one to a thread, but fbchat doesn't seem to allow a thread_id in client.send() or client.getThreadInfo(), as these methods require a user_id instead.
Currently I can only manipulate threads with a single person.
I am not very experienced, so if you found that this is something missing from fbchat, I would appreciate a fix !

See #89 for getting client.getThreadInfo working for groups. client.send is supposed to be able to support group threads with the message_type parameter.

Im also having trubbel with the group messages, not sure I'm using it in the right way.
One thing is I'm not sure what to use as recipient_id when sending to a group chat.
A simple example for a echobot working with group chat would be great :-)

Merged #89


wip: sock5s report error properly

This is kind of high cost to low payoff so probably will put this on
hold for now...

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


Fix invalid escape sequences

We should wait to merge this until we have CI set up.

TODO: when CI is merged, add W605 to ruff

Codecov Report

Merging #167 (6b575f2) into main (ab54797) will not change coverage.
The diff coverage is 40.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   60.75%   60.75%
=======================================
  Files         105      105
  Lines       18646    18646
=======================================
  Hits        11329    11329
  Misses       7317     7317

Flag
Coverage Δ

unittests
60.75% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/dendropy/calculate/phylogeneticdistance.py
85.40% <ø> (ø)

src/dendropy/calculate/popgenstat.py
77.51% <ø> (ø)

src/dendropy/dataio/newickyielder.py
100.00% <ø> (ø)

src/dendropy/dataio/nexmlyielder.py
29.03% <ø> (ø)

src/dendropy/dataio/nexusreader.py
75.00% <0.00%> (ø)

src/dendropy/dataio/nexusyielder.py
76.66% <ø> (ø)

src/dendropy/datamodel/charmatrixmodel.py
76.84% <ø> (ø)

src/dendropy/datamodel/charstatemodel.py
80.95% <ø> (ø)

src/dendropy/datamodel/datasetmodel.py
72.95% <ø> (ø)

src/dendropy/datamodel/taxonmodel.py
67.94% <ø> (ø)

... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


zsh-syntax-highlighting: init at 0.4.1

Motivation for this change
zsh-syntax-highlighting is a popular package (available in Ubuntu, homebrew, etc.), lacking in nixpkgs.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

It also requires something like source /run/current-system/sw/share/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh in programs.zsh.interactiveShellInit to work. Is it a good idea to leave a comment about it, or add an entry to config.programs.zsh, or do something else?

@loskutov You could add a new configuration option to  nixpkgs/nixos/modules/programs/zsh/zsh.nix that would automatically add that line at the end of the interactiveShellIni.

I would also leave a comment in the package itself.

I had to adapt the source line a little (https://github.com/NixOS/nixpkgs/commit/9f34b5595e28e64f80f6615eb99cbd5b98b97529#diff-0740f57e63af61694d14796286cb9204R132), but then it worked. Thanks!

Working perfectly. Thanks @Mic92, @loskutov!


Nullability support in Plank

Add nullability information into Schema IR
Render 'nonnull' or 'nullable' if a property is present in 'required'
property.
Update Cocoa examples to incorporate nullability cases
Improve unit test coverage in ObjCIR.swift
Add documentation for nullability support

          1 Warning

:warning:
Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

  Generated by :no_entry_sign: Danger

🚫 CI failed with log

@rahul-malik Here is a diff for adding nullability support to JS / Flow.
JSFlowNullable.diff.zip

@maicki - Please take a look when you get a chance, I've merged your patches and ensured the build compiles and tests pass locally.

          2 Warnings

:warning:
This is a big PR, please consider splitting it up to ease code review.

:warning:
Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

  Generated by :no_entry_sign: Danger


Add "set of" slot to the manifest

yes, sorry, i should have made a more detailed descriptions - this is just to support the set-slots in the manifest.
next steps would be to update strategies to only match consumed set-slots to provided set-slots,
and update to the slot-composer to actually support them (wip).
once that is done, we'll have a single annotations set slot in SP particle.


missing level numbers on guild window

Good afternoon,
Recently I came across something unusual and not sure why it would have happened, but if you have Noobtaco installed, if you go to your guild window and look at the levels of characters, every number is listed for which level they are, except lvl 60.
If a character is lvl 60, it just shows a ...
Here is a screenshot of it I took a day or so ago

Hello @xmcdizzle This could be from another addon or screen res. I will keep looking into being able to replicate but so far, I do not see the same issue.
Can you give me more information about other addons you might be running that could be conflicting?
Thanks

Super weird. I don’t think I have any other addons that affect it. Most notable ones are
Attune
DBM
PAWN
GatherMate2
Baggon
Auctioner
I will send the full list when I get back to my PC, but it used to work perfectly up until an update of some sort.
Sent from my iPhone

On May 31, 2021, at 12:42 PM, Mike Norton @.***> wrote:

Hello @xmcdizzle This could be from another addon or screen res. I will keep looking into being able to replicate but so far, I do not see the same issue.
Can you give me more information about other addons you might be running that could be conflicting?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Mike, here is the list of addons I am using all together on top of ElvUI/NoobTaco
AtlasLootClassic
Attune
AuctionatorBagonDecursiveDejamarkDismounterDominosGatherMate2ItemRackLeatrix MapsMik's SBTPawnPortal MageRCLootCouncilRecountThreatClassicWeakaurasCharacterStatsTBCDBM
Any of these you think could cause that issue with the lvl not showing for 60? I will try turning off each addon 1 at a time to see which one it could be.
On Monday, May 31, 2021, 02:50:04 PM EDT, Zack Gall @.***> wrote:
Super weird. I don’t think I have any other addons that affect it. Most notable ones are
AttuneDBMPAWNGatherMate2BaggonAuctioner
I will send the full list when I get back to my PC, but it used to work perfectly up until an update of some sort.
Sent from my iPhone
On May 31, 2021, at 12:42 PM, Mike Norton @.***> wrote:

Hello @xmcdizzle This could be from another addon or screen res. I will keep looking into being able to replicate but so far, I do not see the same issue.
Can you give me more information about other addons you might be running that could be conflicting?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

So the first Addon I disabled just to see, was NoobTacoUI. The level 60 now shows. I am going to reinstall NoobTaco and see if that does anything
On Monday, May 31, 2021, 09:13:27 PM EDT, Zack Gall @.***> wrote:
Mike, here is the list of addons I am using all together on top of ElvUI/NoobTaco
AtlasLootClassic
Attune
AuctionatorBagonDecursiveDejamarkDismounterDominosGatherMate2ItemRackLeatrix MapsMik's SBTPawnPortal MageRCLootCouncilRecountThreatClassicWeakaurasCharacterStatsTBCDBM
Any of these you think could cause that issue with the lvl not showing for 60? I will try turning off each addon 1 at a time to see which one it could be.
On Monday, May 31, 2021, 02:50:04 PM EDT, Zack Gall @.***> wrote:
Super weird. I don’t think I have any other addons that affect it. Most notable ones are
AttuneDBMPAWNGatherMate2BaggonAuctioner
I will send the full list when I get back to my PC, but it used to work perfectly up until an update of some sort.
Sent from my iPhone
On May 31, 2021, at 12:42 PM, Mike Norton @.***> wrote:

Hello @xmcdizzle This could be from another addon or screen res. I will keep looking into being able to replicate but so far, I do not see the same issue.
Can you give me more information about other addons you might be running that could be conflicting?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

FIXED the problem. It had to do with which font was selected. For whatever reason, 60 in a certain font, maybe it was just a fraction of a hair size too large, showed "..." rather than lvl 60.
On Monday, May 31, 2021, 09:15:15 PM EDT, Zack Gall @.***> wrote:
So the first Addon I disabled just to see, was NoobTacoUI. The level 60 now shows. I am going to reinstall NoobTaco and see if that does anything
On Monday, May 31, 2021, 09:13:27 PM EDT, Zack Gall @.***> wrote:
Mike, here is the list of addons I am using all together on top of ElvUI/NoobTaco
AtlasLootClassic
Attune
AuctionatorBagonDecursiveDejamarkDismounterDominosGatherMate2ItemRackLeatrix MapsMik's SBTPawnPortal MageRCLootCouncilRecountThreatClassicWeakaurasCharacterStatsTBCDBM
Any of these you think could cause that issue with the lvl not showing for 60? I will try turning off each addon 1 at a time to see which one it could be.
On Monday, May 31, 2021, 02:50:04 PM EDT, Zack Gall @.***> wrote:
Super weird. I don’t think I have any other addons that affect it. Most notable ones are
AttuneDBMPAWNGatherMate2BaggonAuctioner
I will send the full list when I get back to my PC, but it used to work perfectly up until an update of some sort.
Sent from my iPhone
On May 31, 2021, at 12:42 PM, Mike Norton @.***> wrote:

Hello @xmcdizzle This could be from another addon or screen res. I will keep looking into being able to replicate but so far, I do not see the same issue.
Can you give me more information about other addons you might be running that could be conflicting?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

FIXED the problem. It had to do with which font was selected. For whatever reason, 60 in a certain font, maybe it was just a fraction of a hair size too large, showed "..." rather than lvl 60.

Oh! Nice. I was about to suggest disabling my profile.
That is a good find, however. What language client are you using by chance? I had only tested for US and wonder if Montserrat font was causing the issue.
I will close this issue for now, but feel free to add more to the comments.
Glad you got it worked out.

FIXED the problem. It had to do with which font was selected. For whatever reason, 60 in a certain font, maybe it was just a fraction of a hair size too large, showed "..." rather than lvl 60.

Oh! Nice. I was about to suggest disabling my profile.
That is a good find, however. What language client are you using by chance? I had only tested for US and wonder if Montserrat font was causing the issue.
I will close this issue for now, but feel free to add more to the comments.
Glad you got it worked out.

Totally forgot to respond to you, I’m using the US English


Control Point Tower counts as a unit in the region for Return to the Fold, Sentinels quest

Need to test properly still and check if it's also the case elsewhere

Closed by https://github.com/AzerothWarsLR/WarcraftLegacies/commit/f4059fecc1fd65e95b853de51c0b4c5f7649b329


Version 11 hotfix

Please read the Pull Request Checklist to ensure you have everything that is needed to get your contribution merged.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


libgphoto2: update udev rules version

and add hwdb
https://github.com/gphoto/libgphoto2/blob/48d9bafe1fb9b8bd7485d554b1fec8a6a9bd3f71/packaging/generic/print-camera-list.c#L1407-L1416
paths from
https://github.com/gphoto/libgphoto2/blob/48d9bafe1fb9b8bd7485d554b1fec8a6a9bd3f71/packaging/generic/print-camera-list.c#L1426 and https://github.com/gphoto/libgphoto2/blob/48d9bafe1fb9b8bd7485d554b1fec8a6a9bd3f71/packaging/generic/print-camera-list.c#L1413
ref
https://github.com/archlinux/svntogit-packages/blob/acd9af4de4b07d4fcdb08142f7eb596ae75d81d2/trunk/PKGBUILD#L57 https://src.fedoraproject.org/rpms/libgphoto2/blob/rawhide/f/libgphoto2.spec#_105
Closes https://github.com/NixOS/nixpkgs/issues/145544
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

https://man.archlinux.org/man/core/systemd/hwdb.7.en

. hwdb files must have the extension .hwdb; other extensions are ignored.


Update Rep token to v2 for compound Safe-App

cc @lukasschor

Are you sure that Compound supports Repv2 already? If it see it correctly, they are still using the old REP for their market https://etherscan.io/token/0x158079ee67fce2f58472a96584a73c7ab9ac95c1#readContract

closing this for now, please reopen in case I got anything wrong about the token. @lukasschor @nicosampler


View prioritized events in dev mode

This PR adds a list of possible next events with their priorities in the lower left of the screen, if dev mode is turned on.

Wenig Platz? Da müssten wir dann so was wie Tabs einbauen. Wäre natürlich noch besser.


CI - remove python 3.6 from  python versions and adding 3.9 instead

Please update the python versions classifiers in setup.py https://github.com/nuclio/nuclio-jupyter/blob/development/setup.py#L87


Fix: remove clashing of ubuntu plugin with 'ag'

Ubuntu plugin defines an alias named 'ag'.
The improved-grep called 'the_silver_searcher' (https://github.com/ggreer/the_silver_searcher)
is installed as ag in /usr/bin.
This patch changed the Ubuntu plugin aliases in order not to clash with 'ag' and
changes other aliases to keep consistency.

i notice this conflict as well with silver searcher.
However with other plugins, like the suse zin is alias for sudo zypper install and sc-stop is alias for sudo systemctl stop so the sudo is usually not taken into account.  However about just changing the ag to age

@MenkeTechnologies I changed the other aliases as well to keep coherence among all the aliases defined in the ubuntu plugin.

@Marcholio conflicts resolved. Ready to be merged.

Fixed in #7700.


Update Quill Dependency to ^2.0.0

This PR updates the quill dependency in react-quill from an outdated version (1.3.7) to the latest release: 2.0.x, and adds support for<EMAIL_ADDRESS>This fork is now available on NPM until the original maintainers of this repository merge this PR<EMAIL_ADDRESS>I will keep publishing this package with any fixes and updates I discover. Visit the react-quill-new repository for an updated README and instructions.
Report any issues you find in on the react-quill-new issues page.
If you're using my forked NPM package and are getting errors like "Unexpected Token: export" or similar, and are using webpack with babel, make sure you have babel transpile this package by ignoring it in the exclude clause for babel-loader. Because Quill moved to being a native ESM module, this PR does the same, which requires ES5-compatible projects to use babel for it.
==============================================================================
The underlying<EMAIL_ADDRESS>release mainly includes security fixes and performance enhancement, but most relevant of all, it replaces a deprecated DOM API that will be dropped from Browsers on July 23, 2024 (source).
This means that the following issues will be addressed:

https://github.com/zenoamaro/react-quill/issues/943
https://github.com/zenoamaro/react-quill/issues/601

The code in this PR is based on the (already approved) https://github.com/zenoamaro/react-quill/pull/967, with the addition of:

The PR feedback on https://github.com/zenoamaro/react-quill/pull/967  by @adgoncal, @piesuke, and @luin.
Updates typescript dev dependency from 3.x to 5.x to be in line with Quill 2.0's typescript version. This ensures tsc runs correctly with the new type import syntax.
Fixes typescript compilation warnings and errors by upgrading some type dependencies

Note that Quill >2.0.0 uses ES modules natively, which breaks some of the tooling in this repository. This PR doesn't directly address that. Specifically, the test setup isn't compatible with the ES modules.
Next steps
Once this PR is merged, I suggest releasing it as 2.1.0-beta.1, to allow users to upgrade via NPM without suggesting it's completely stable yet. Given the timeline for the DOM API deprecation, we'll have at least a full month to bring this to users in beta state before it becomes advisable to release a full version.
Before a production release, we should revisit the test setup to ensure compatibility with the ES modules. This could take the form of updating the webpack setup to transpile the Quill dependency, or finding a version of Mocha that supports these natively.

Build command is running fine, see build step output:
yarn build                                                                                10s  18.20.2 15:33:18
yarn run v1.22.19
$ npm run build:lib && npm run build:dist && npm run build:css

><EMAIL_ADDRESS>build:lib
> tsc

><EMAIL_ADDRESS>build:dist
> webpack

Hash: 95cce68c8ae2eb1f8e21
Version: webpack 4.41.2
Time: 1038ms
Built at: 05/06/2024 3:33:25 PM
            Asset      Size  Chunks             Chunk Names
../lib/index.d.ts  5.05 KiB          [emitted]
   react-quill.js  31.4 KiB       0  [emitted]  main
Entrypoint main = react-quill.js
[11] external {"commonjs":"react","commonjs2":"react","amd":"react","root":"React"} 42 bytes {0} [built]
[12] external {"commonjs":"react-dom","commonjs2":"react-dom","amd":"react-dom","root":"ReactDOM"} 42 bytes {0} [built]
[22] (webpack)/buildin/module.js 497 bytes {0} [built]
[26] ./src/index.tsx 17.6 KiB {0} [built]
[41] (webpack)/buildin/global.js 472 bytes {0} [built]
    + 90 hidden modules

><EMAIL_ADDRESS>build:css
> cpx 'node_modules/quill/dist/quill.*.css' dist

✨  Done in 4.28s.

@hasangursoy I'm not a maintainer of this repository, and I think even they would be hard pressed to give you an estimate. If we don't have a beta release by June, however, I'll release this branch as a fork on npm and will link it here. If you need it sooner than that, I suggest making a fork and package yourself.

For everyone arriving at this PR, it looks like @hasangursoy published this fork as a new npm package (see this issue).
This might be a helpful intermediary solution for anyone testing their rollout for the react-quill upgrade. Note that this package is not endorsed or managed by the maintainers of this repository, and does not include a full test suite, so use at your own risk.

@VaguelySerious Thanks for the temporary NPM package!

If the author has no plans to update Quill, @VaguelySerious, will you continue to update react-quill-new? Thanks!

If the maintainer has no plans to update Quill, @VaguelySerious, will you continue to update react-quill-new? Thank you!

@luc345 Yes, I'll continue to update it for now, at least to keep it stable and compatible with Quill and newer versions of React, though I don't plan on addressing any issues or requests unrelated to basic functioning.

@VaguelySerious, I'm currently using react-quill-new but encountering an error:
"Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object."
Previously, I was using react-quill, which used Quill 1.x. I switched to react-quill-new because I need to utilize the table module. I'm developing with Next.js. Could you please assist me with this issue? Thank you in advance.

@ubaidrehman97 Have you tried using ESM's import syntax? See NextJS documentation on issues with using require for ESM modules.
If that doesn't work, what's typeof ReactQuill for you? If it's not function (which seems to be the case) then something is likely wrong with your bundler or import syntax. If you need to use require, try const ReactQuill = require('react-quill-new').default; (note the ".default" at the end).

@VaguelySerious
i'm using react-quill-new with highlight.js
    const modules = useMemo(         () => ({             syntax: { highlight: (text) => hljs.highlightAuto(text).value },
but, error occured
'Syntax module requires highlight.js. Please include the library on the page before Quill.'
How can I solve this problem?

@ParkAsher This likely has nothing to do with react-quill-new, rather, with Quill itself, and you should be able to find the solution by googling the error message. From what I recall offhand, it looks something like adding this code snippet somewhere in your code before you import react-quill-new or quill :
import "highlight.js/styles/monokai-sublime.css";
import hljsCore from "highlight.js/lib/core";
import javascript from "highlight.js/lib/languages/javascript";
// ... your other languages

hljsCore.registerLanguage("javascript", javascript);
// ... your other languages

// Quill will look for hljs on the window object when used with "syntax: true" or
// when using the "Quill.convert" method.
window.hljs = hljsCore;

Can you add this fix to your react-quill-new repo:
https://github.com/zenoamaro/react-quill/pull/980/commits/e38b344cca977166b624d4b8f634ae25504ab657

https://github.com/VaguelySerious/react-quill/pull/5 for deleting extra options and React 19 compatibility

@cpitzak @hamidrezahanafi Added the code and will publish a beta release on NPM later today after testing

Sorry, but how to install your fork?
npm install VaguelySerious/react-quill --save.
doesn't work, because the package directory (react-quill-new) contains only the package.json and node_modules directory.

Sorry, but how to install your fork?
npm install VaguelySerious/react-quill --save. doesn't work, because the package directory (react-quill-new) contains only the package.json and node_modules directory.

npm i react-quill-new --save

Do you know why unordered lists becomes ordered?

....

@MartinSilvaMX That is part of<EMAIL_ADDRESS>you can create an issue for the quill repo if you want.

I'm getting this error: quill__WEBPACK_IMPORTED_MODULE_1__ is not a constructor in my console.
Looks like it's breaking in the createEditor in index.js.
I'm guessing this is what is being referred to in the original comment with the native ESM modules. I've tried several different approaches, but none of them have worked so far. Has anyone else had this issue? If so, what was the fix?

@Jasen-Simedru-SHG Are you using babel-loader with webpack and using the exclude: /node_modules\/(?!(react-quill-new)\/).*/, rule with it?

Hi @VaguelySerious I just installed your fork cuz I was getting 'findDOMNode' warnings.
I have noticed some of the tools don't work properly such as list: bullet and check. Do you have any suggestions on how to fix the issues?

@unartcs This fork of react-quill updates quill to >=2.0, which changed a lot of things under the hood. It's very likely the problems you're facing are due to the quill upgrade itself, and I suggest looking in the quill github issue log for help. Some hunches:

Using quill plugins that aren't compatible with quill 2.0
Custom styling for html that has changed due to the quill 2.0 update
Other JS code you might have written that's no longer compatible

hey is there a way to move discourse to your fork @VaguelySerious ? i found this error Warning: unstable_flushDiscreteUpdates: Cannot flush updates when React is already rendering. caused by this line: https://github.com/VaguelySerious/react-quill/blame/master/src/index.tsx#L222. not sure if it's a serious issue, it seems benign but wanted to get it out there... in any case, thanks for being a badass.

@omgoshjosh I opened an issue page on my forked repo. Could you repost your issue there, preferably with steps for reproduction?

Hey @VaguelySerious  This is affecting our project, is there a way we can have this Merged soon or do you have an expected date on it?

@diegoruelasgalaviz The maintainers of this repository are not responsive, but I'm trying my best to maintain react-quill-new (the fork based on this PR) at https://github.com/VaguelySerious/react-quill/. You can install react-quill-new via npm and it should be a drop-in replacement with updated quill dependencies.

@VaguelySerious, hi!
I have a React application running on Vite. Today, I installed react-quill-new to get rid of the problem: findDOMNode is deprecated and will be removed in the next major release. However, there’s no result; the error still appears in the console.
Additionally, I get another error: Listener added for a 'DOMNodeInserted' mutation event.
Installed packages:
"react-quill": "^2.0.0"
"react-quill-new": "^3.3.1"
I’m working with yarn, and my React version is "react": "^18.3.1".
The component looks like this:
/* eslint-disable react-hooks/exhaustive-deps */
import { useState, useEffect, FC } from 'react';
import { useTranslation } from 'react-i18next';
import ReactQuill from 'react-quill';
import { toast } from 'react-toastify';
type Props = {
value: string;
onChange: (value: string) => void;
imageHandler?: (file: File) => void;
disabledBtn?: boolean;
placeholder?: string;
};
export const CustomReactQuill: FC = ({ value, onChange, imageHandler, disabledBtn = true, placeholder }) => {
const [fildSize, setFildSize] = useState(new Blob([value]).size);
const { t } = useTranslation();
const newFildSize = new Blob([value]).size;
useEffect(() => {
    if (newFildSize - fildSize > 10485760) {
        toast.error(t('QUILL_ERROR'), {
            position: 'bottom-right',
            autoClose: 5000,
            hideProgressBar: false,
            closeOnClick: true,
            pauseOnHover: true,
            draggable: true,
            progress: undefined,
            theme: 'colored',
        });
    } else {
        setFildSize(newFildSize);
    }
}, [value]);

return (
    <ReactQuill
        value={value}
        onChange={onChange}
        modules={{
            toolbar: {
                container: disabledBtn
                    ? [
                          [{ size: ['small', false, 'large', 'huge'] }],
                          [{ header: 1 }, { header: 2 }],
                          ['bold', 'italic', 'underline', 'strike'],
                          [{ align: [] }],
                          [{ list: 'ordered' }, { list: 'bullet' }],
                          [{ color: ['red', 'green', 'blue', 'black', 'yellow', 'orange', 'purple'] }],
                          [{ script: 'sub' }, { script: 'super' }],
                          ['link', 'image', 'video'],
                          ['clean'],
                      ]
                    : [
                          [{ size: ['small', false, 'large', 'huge'] }],
                          [{ header: 1 }, { header: 2 }],
                          ['bold', 'italic', 'underline', 'strike'],
                          [{ align: [] }],
                          [{ list: 'ordered' }, { list: 'bullet' }],
                          [{ color: ['red', 'green', 'blue', 'black', 'yellow', 'orange', 'purple'] }],
                          [{ script: 'sub' }, { script: 'super' }],
                          ['link'],
                          ['clean'],
                      ],
                handlers: {
                    image: imageHandler,
                },
            },
        }}
        placeholder={placeholder}
    />
);

};
I’d appreciate any help.
Thanks!

@leonid-br Please file such issues in the issues section of my repo instead.
In your case, these steps should likely fix your issue:

Uninstall react-quill
Replace import ReactQuill from 'react-quill'; with import ReactQuill from 'react-quill-new';
Make sure your package.json does not have any entries pinning the underlying quill package to an older version, e.g. in the resolutions field.


Add global chapter navigation

I agree that it's a good idea to go through the chapters sequentially. However, whenever I wanted to check something in a specific chapter, I kept clicking on the main link at the top of each page to get to the table of contents. From there I would navigate to specific chapters.
You can always use the search, of course, but I think it would be nice to have a more convenient way to browse the content of the guide and jump to specific chapters.

I was thinking this could be a dropdown in the top-right corner, next to the search, to keep the minimal look.
Maybe there's even a way to combine the two. A hamburger menu that shows a search box and the list of chapters. If you start searching, the list of chapters gets replaced with results....?


Check restake enabled

/statistics/get_statistics_validators
/statistics/get_statistics_validators__operator_address_
Seems, like it broken

@bro-n-bro-0 we discussed it with you few weeks ago, can you check, did we calculate it correctly?

        select JSONExtractString(_t, 'delegator_address') as address from (
            SELECT JSONExtractString(arrayJoin(JSONExtractArrayRaw(JSONExtractString(msgs)))) as _t FROM spacebox.exec_message
        where JSONExtractString(_t, '@type') = '/cosmos.staking.v1beta1.MsgDelegate')
        where address = 'cosmos106yp7zw35wftheyyv9f9pe69t8rteumjxjql7m' limit 1


[SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

What changes were proposed in this pull request?
A GROUPED_AGG pandas python udf can't work, if without group by clause, like select udf(id) from table.
This doesn't match with aggregate function like sum, count..., and also dataset API like df.agg(udf(df['id'])).
When we parse a udf (or an aggregate function) like that from SQL syntax, it is known as a function in a project. GlobalAggregates rule in analysis makes such project as aggregate, by looking for aggregate expressions. At the moment, we should also look for GROUPED_AGG pandas python udf.
How was this patch tested?
Added tests.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13715/
Test PASSed.

Test build #108628 has started for PR 25352 at commit 544e6aa.

Test build #108628 has finished for PR 25352 at commit 544e6aa.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108628/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13728/
Test PASSed.

Test build #108641 has started for PR 25352 at commit bd86ba8.

cc @HyukjinKwon

Test build #108644 has started for PR 25352 at commit 322c3f7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13731/
Test PASSed.

Test build #108644 has finished for PR 25352 at commit 322c3f7.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #108641 has finished for PR 25352 at commit bd86ba8.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108644/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108641/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13736/
Test PASSed.

Test build #108649 has started for PR 25352 at commit 2c6cd20.

Test build #108649 has finished for PR 25352 at commit 2c6cd20.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108649/
Test PASSed.

@HyukjinKwon any thought on this? thanks.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14101/
Test PASSed.

Test build #109040 has started for PR 25352 at commit 2c6cd20.

Merged to master.

FYI, the tests already passed.

Thanks @viirya and sorry for late response. I was stuck in some works for last some days.

No problem, and thanks @HyukjinKwon

Test build #109040 has finished for PR 25352 at commit 2c6cd20.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109040/
Test PASSed.


Operator does not scale well: hits client-go rate-limiting issues

Report
While testing a KEDA deployment, 1000 scaledObjects were created, and hours later the corresponding HPA objects were not created.
There were many throttling messages such as
I1101 19:43:15.887048       1 request.go:655] Throttling request took 33.944822108s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-879/status

It seems that there are throttling flags available for the apiserver, but not for the operator.  The need for throttling at all, also hints that the implementation could be exceedingly heavy on its use of the apiserver - perhaps there's some caching that's not engaged in all the places?
By the time it gets to the 600's range, it takes about 30s for each scaledObject! at that rate, getting to 1000 will take another 2 ½ hours, except that the rate will continue to decline, so more like 4 hours to get through all 1000; that means that the later deployments won't have any scaling whatsoever for quite a long time.
Nov 01 13:42:25 1000 688
Nov 01 13:42:29 1000 689
Nov 01 13:42:34 1000 689
Nov 01 13:42:38 1000 689
Nov 01 13:42:42 1000 689
Nov 01 13:42:47 1000 689
Nov 01 13:42:51 1000 689
Nov 01 13:42:56 1000 690

Furthermore, when all 1000 scaledObjects  were removed followed by removing the deployments, because the operator is so inefficient at reconciling, many errors were reported about the deployments missing; the operator just isn't very responsive in its reconciliation, and the time per reconcile seems to take longer and longer the more it slogs through - the definition of unscalable.
2021-11-01T19:52:25.581Z	ERROR	scalehandler	Error getting scalers	{"object": {"apiVersion": "keda.sh/v1alpha1", "kind": "ScaledObject", "namespace": "sieve-k8s", "name": "tinkerkeda-152"}, "error": "Deployment.apps \"tinkerkeda-152\" not found"}

Expected Behavior
Adding 1000 scaled objects would have 1000 HPA's created for them almost immediately.
Actual Behavior
1000 scaledObjects (type metrics-api with the previous external-metrics apiserver "behind" it in the same cluster) were added in about 4m, but an hour later, only about 710 HPA's were created.
Steps to Reproduce the Problem

Install an http server/service that returns some json that can be queried with metrics-api
Create 1,000 scaledObject / deployment pairs that use that http service as metrics-api
Watch the deployment with something like the following adjusted for your scaledObjects' namespace and some label on them:while :; do echo $(kubectl -n sieve-k8s get scaledObject -o name -l tinker| wc -l) $(kubectl -n sieve-k8s get hpa.v2beta2.autoscaling -l tinker | wc -l); sleep 1; done | ts | tee creation.out

Nov 01 13:53:44 1000 708
Nov 01 13:53:49 1000 709
Nov 01 13:53:58 1000 709
Nov 01 13:54:03 1000 709
Nov 01 13:54:07 1000 709
Nov 01 13:54:11 1000 709
Nov 01 13:54:16 1000 709
Nov 01 13:54:26 1000 709
Nov 01 13:54:30 1000 709
Nov 01 13:54:35 1000 710

Logs from KEDA operator
2021-11-01T20:55:44.483Z	INFO	controllers.ScaledObject	Initializing Scaling logic according to ScaledObject Specification	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-710"}
I1101 20:55:49.938056       1 request.go:655] Throttling request took 5.901866129s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-44/status
2021-11-01T20:55:50.486Z	INFO	controllers.ScaledObject	Reconciling ScaledObject	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-711"}
2021-11-01T20:55:50.486Z	INFO	controllers.ScaledObject	Adding Finalizer for the ScaledObject	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-711"}
I1101 20:55:59.988015       1 request.go:655] Throttling request took 5.916176076s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-18/status
I1101 20:56:09.988055       1 request.go:655] Throttling request took 5.887750161s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-97/status
2021-11-01T20:56:14.142Z	INFO	controllers.ScaledObject	Detected resource targeted for scaling	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-711", "resource": "apps/v1.Deployment", "name": "tinkerkeda-711"}
2021-11-01T20:56:14.142Z	INFO	controllers.ScaledObject	Creating a new HPA	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-711", "HPA.Namespace": "sieve-k8s", "HPA.Name": "keda-hpa-tinkerkeda-711"}
I1101 20:56:20.037992       1 request.go:655] Throttling request took 5.903630764s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-255/status
2021-11-01T20:56:20.235Z	INFO	controllers.ScaledObject	Initializing Scaling logic according to ScaledObject Specification	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-711"}
2021-11-01T20:56:26.106Z	INFO	controllers.ScaledObject	Reconciling ScaledObject	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-172"}
I1101 20:56:30.088110       1 request.go:655] Throttling request took 5.869286153s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-639/status
2021-11-01T20:56:38.064Z	INFO	controllers.ScaledObject	Reconciling ScaledObject	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-712"}
2021-11-01T20:56:38.064Z	INFO	controllers.ScaledObject	Adding Finalizer for the ScaledObject	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-712"}
I1101 20:56:40.137905       1 request.go:655] Throttling request took 5.915426294s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-315/status
I1101 20:56:50.137958       1 request.go:655] Throttling request took 5.965272135s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-161/status
I1101 20:57:00.138025       1 request.go:655] Throttling request took 5.905944269s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-197/status
2021-11-01T20:57:02.217Z	INFO	controllers.ScaledObject	Detected resource targeted for scaling	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-712", "resource": "apps/v1.Deployment", "name": "tinkerkeda-712"}
2021-11-01T20:57:02.217Z	INFO	controllers.ScaledObject	Creating a new HPA	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-712", "HPA.Namespace": "sieve-k8s", "HPA.Name": "keda-hpa-tinkerkeda-712"}
2021-11-01T20:57:08.334Z	INFO	controllers.ScaledObject	Initializing Scaling logic according to ScaledObject Specification	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-712"}
I1101 20:57:10.187944       1 request.go:655] Throttling request took 5.895825695s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-343/status
2021-11-01T20:57:14.232Z	INFO	controllers.ScaledObject	Reconciling ScaledObject	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-713"}
2021-11-01T20:57:14.232Z	INFO	controllers.ScaledObject	Adding Finalizer for the ScaledObject	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-713"}
I1101 20:57:20.188009       1 request.go:655] Throttling request took 5.928227608s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-652/status
I1101 20:57:30.237985       1 request.go:655] Throttling request took 5.962924853s, request: PATCH:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1/namespaces/sieve-k8s/scaledobjects/tinkerkeda-71/status
2021-11-01T20:57:38.163Z	INFO	controllers.ScaledObject	Detected resource targeted for scaling	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-713", "resource": "apps/v1.Deployment", "name": "tinkerkeda-713"}
2021-11-01T20:57:38.163Z	INFO	controllers.ScaledObject	Creating a new HPA	{"ScaledObject.Namespace": "sieve-k8s", "ScaledObject.Name": "tinkerkeda-713", "HPA.Namespace": "sieve-k8s", "HPA.Name": "keda-hpa-tinkerkeda-713"}

KEDA Version
2.3.0
Kubernetes Version
1.19
Platform
Any
Scaler Details
metrics-api
Anything else?
No response

That's indeed a lot of ScaledObjects to be processed at once. Do you see any errors in the log? We are using client from controller-runtime and it should be cached, when we are trying to patch the ScaledObject.Status.
I am not sure what causes the delay, if it is KEDA Operator we could try to add more concurrent reconciliation loops, but for me it look more like limitation on k8s server.
@coderanger any idea what can be improved here?

 Reconciliation should not be blocked by fetching and update I/O - avoid any external (non-control-plane/apiserver) I/O in the control-plane or APIService handling - find a way to do that out-of-band and either stash the results (in status, e.g.) or make the updates asynchronously; not in-line to the callback.

I generally agree, but sometimes it is hard to achieve this. We could spread out the processing of resources in Reconciliation loop and the requests to update metrics, but we still need to do the inital lookup to the external service and the creation of HPAs itself (which causes the increased load on k8s server in your case).

When we were designing and perf testing our previous, in-house external-metrics apiserver, we noticed that for control-plane things, it's not "friendly" to do "expensive" work. We wanted to use our (also) in-house metrics server and, while that responded in around the 100ms timeframe, putting it in the middle of HPA asking for the external metrics made all metrics slide by the delay (since HPA has a single worker for the entire cluster!!!). Instead, our controller schedules all the requests to the metrics and keeps the results in an object that it updates using sync.atomic, so that when the HPA asks for the data, we just give the last response in around the 100µs timeframe (1000x faster).

 There are certain plans to implement metrics caching on our Metrics Server to reduce the load on external services and be able to respond quickly.

Hi, we're starting to look at this again for various reasons - is there anything in the past year's worth of releases that has tackled this  scalability issue?
I would LOVE to see the loop split into one to convert ScaledObjects (e.g.) to HPA's and another for metrics gathering - and that one even to be asynchronous - if you wanted to use it just for "scheduling" that makes sense, but it would be great if it could just update the HPA directly rather than tying up the entire loop...
My favorite, if contrived, example is, say you wanted to query some metric on the Sun - what's that, like 16m round-trip… you'd be inflicting a 16m pause on EVERYTHING for this ONE metric - the opposite of scalable.

Thinking about this a little bit - it feels like something more event-driven would be really great here…
Even if you stayed with the reconcile loop - you could fire off events: "I want to inspect such and such metric" and the event listener for that could do the work and return a new event "please update such and such ScaledObject with this observation" whose listener would do the update…
I realize there's more to it than "just that" but the current design really does fall apart for larger clusters - where we had hoped to embrace KEDA and use it for more and more things, we instead had to abandon it.  I LOVE what it does from the external perspective - all the great gRPC and other APIs that it can talk are awesome-sauce and I really do wish the scheduling implementation could be made scalable.


🚀 Feature: Customize Backstage cli command that create plugins

🔖 Feature description
We'd like to run backstage-cli new --select plugin and have the option to generate a plugin that uses MUI 5 and custom eslint config.
🎤 Context
We have different eslint config than what the command currently generates, and we use MUI 5 instead of Material UI 4, which is the default of Backstage. Currently we have to manually update files after we generate the plugin. This is a common use case for us, since we have a steady stream of contributors who need to generate new plugins.
✌ Possible Implementation
No response
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else

Yep, thanks! I re-opened the old one, closing this one as a duplicate


Error calling client.get_item

When i call
client.get_item(collection_name, item_id)
i receive an error
{'error': "No data found for this request : 'data'"}
, while
client.get_items(collection_name, {"query": {"filter": {"id": {"_eq": "1"}}}})
works like expected.
In my directus-logs i found, that the first command calls the endpoint
SEARCH /items/collection_name/1
, which doesn't exist. Shouldn't it be a GET request
GET /items/collection_name/1
for getting a single item?
Calling the get method directly works fine:
client.get(f"/items/{collection_name}/{item_id}")
By the way, thanks for this library!

@Psychedelic-Engineering
Thanks for your report and your help, i correct this issue.


Systemd service for FlightSoftware

Introduces a systemd unit file for starting the flight software when the pi boots. The flight pi setup procedure has been updated: https://cornell.app.box.com/file/765928258516
and the functionality has been tested.

This functionality has been HITL tested and documented at: https://cornell.app.box.com/file/789090869993


Admin Router: Remove periodic AR reloading in favour of DNS queries

High Level Description
This PR:

performs some minor cleanup of docker files - CA bundle location sync
removes $upstream_marathon variable definition as it is no longer needed - all requests go through /service endpoint and the upstream is determined basing on Mesos' /state-summary endpoint
makes devkit as per-flavour. This enables running both EE and Open devkits side-by-side and permits differences between EE and Open devkits
exposes test harness logs in a log file, Jenkins should automatically pick it up and treat it as yet another artefact
removes period reloading of AR in favour of DNS queries, see DCOS_OSS-1446 for details
removes TTL override for AR DNS resolver. See the comments in the configuration for more details.

Related Issues

https://jira.mesosphere.com/browse/DCOS_OSS-1446 - Admin Router: Dynamic DNS resolution of upstreams

Related PRs:
Base PR from old AR repo: https://github.com/dcos/adminrouter/pull/50
Enterprise PR: https://github.com/mesosphere/dcos-enterprise/pull/1205

@mesosphere-mergebot label Ready for review

@mhrabovcin @gpaul @jgehrcke Please have a look, thanks!

Thanks for this work! I would very much appreciate if @gpaul could also give a quick review.

Thank you, everyone!

@vespian Can you please investigate the failures that were encountered when we tried to add this PR to train-195.
It looks like @jgehrcke already made a ticket to track debugging the failure in integration-test/vagrant-bash here: https://github.com/dcos/dcos/pull/1764#issuecomment-318036447

@vespian @jgehrcke
We need to resolve the vagrant-bash issue in this PR before this can be given a ship-it label.
I am strongly opposed to simply muting tests as this is an extremely unreliable and error prone process.
Rather, I see at least two ways forward:
(1) We add some pytest commands into the test suite to skip or xfail these test cases when we detect that platform==vagrant (very easy change)
(2) We declare the vagrant tests to be flawed at the vagrant level and then drop dcos-vagrant as a REQUIRED test. To do this, we would need to make sure the coverage provided by dcos-vagrant is handled elsewhere. More specifically, we would need to use one of the onprem integration test clusters (there are currently 2 per open PR) and set it to num_masters:3 and lb_enabled: false (also very easy)
The point is, we need to pick one of these definitive options. Muting in CI is just brushing something under the rug until the mute expires or until we see that the mute logic accidentally allowed other failed tests to be considered valid (this has happened before)

We need to resolve the vagrant-bash issue in this PR before this can be given a ship-it label.

@mellenburg given the technical details that I know your proposal from Slack to "make the tests aware they are running on vagrant and skip" would have been the sanest choice, I think. I am fine with "holding" this, but more for political/organizational reasons rather than technical reasons.
Because we know

Its a new test failure caused by a change that exposes an old bug.

(Karl's words)
and

The PR just exposes bugs and race conditions that were already present in DC/OS.

(Pawel's words)
Given all boundary conditions that I am aware of I find it appropriate to not block train 201 until DCOS_OSS-1524 and DCOS_OSS-1523 are addressed, but to move ahead with
This patch needs to land in 1.10 beta2 and if we want to wait for DCOS_OSS-1524 and DCOS_OSS-1523 before we land this patch, then I am fine -- but the release has to wait.

I want to add that when @vespian wrote

The tests that are failing and will need to be muted

he probably meant your option (1), Michael:

We add some pytest commands into the test suite to skip or xfail these test cases when we detect that platform==vagrant (very easy change)

Did you, @vespian? :)

Did you, @vespian? :)

It was never my intention to mute whole dcos-vagrant test, and I do not know where it stems from. Since the very beginning, I was always talking about five particular tests - can link slack messages if needed :D
As for the way how exactly they should be muted - I do not know what is the best way to suppress TC failures ATM. By:

The tests that are failing and will need to be muted after merging this PR:

I initially meant doing it in TC basing on our experience with i.e. strict cluster tests, but this can be anything that disables offending tests until the bugs are fixed. I try to trust that people responsible for maintaining tests will be able to choose the best option, hence I did not investigate how exactly it should be done and left it to domain experts to decide. I am sorry if this caused confusion.
I hope it helps :)

@mesosphere-mergebot label ship-it


Fix wrong branch to use in CodeSandbox

The branch uses master branch instead of main and causes invalid error.
Changelog
Changed

"master" in url to "main"

recheck


WIP: Add check constraints to tables/columns

Slowly making progress.

ok to test

tests break due to cast to symbol on visit, having a look

retest this please
I cannot reproduce locally with the seeds of the failed tests

retest this please
codecov failed to upload, I assume it was a disruption in the force

I have squashed the commits and now I will focus in documenting the feature and figuring out what is missing for a follow up PR (alter).


The vertical slider sample looks too short

Describe the bug

That's a rather unimpressive vertical slider.

Expected behavior

This slider should be taller.
Version Info

Gallery version (found on Settings page):

<IP_ADDRESS>

Please do not slider shame. That lil guy gets the job done.
(I wonder if this is a regression?)

Please do not slider shame. That lil guy gets the job done.
(I wonder if this is a regression?)

More likely it looks even shorter now the Thumb is a circle, and not a lozenge.

Fixed the issue with that PR


Errors when building with gcc ; make gcc required for CI

I removed -Werror to show all errors as warning
Click to expand
Waf: Entering directory `/home/david/workspace/cpp/cquery/build'
CLANG_INCLUDE_DIR: /home/david/workspace/cpp/cquery/build/clang+llvm-4.0.0-x86_64-linux-gnu-ubuntu-14.04/include
CLANG_LIB_DIR:     /home/david/workspace/cpp/cquery/build/clang+llvm-4.0.0-x86_64-linux-gnu-ubuntu-14.04/lib
[ 1/33] Compiling src/cache.cc
[ 2/33] Compiling src/clang_complete.cc
[ 3/33] Compiling src/clang_cursor.cc
[ 4/33] Compiling src/clang_index.cc
[ 5/33] Compiling src/clang_translation_unit.cc
[ 6/33] Compiling src/clang_utils.cc
[ 7/33] Compiling src/command_line.cc
[ 8/33] Compiling src/file_consumer.cc
[ 9/33] Compiling src/include_complete.cc
../src/clang_complete.cc: In member function ‘void LruSessionCache::InsertEntry(std::shared_ptr<CompletionSession>)’:
../src/clang_complete.cc:506:42: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (entries_.size() && entries_.size() >= max_entries_)
                          ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~

[10/33] Compiling src/indexer.cc
[11/33] Compiling src/ipc.cc
[12/33] Compiling src/ipc_manager.cc
../src/include_complete.cc: In function ‘std::__cxx11::string {anonymous}::ElideLongPath(Config*, const string&)’:
../src/include_complete.cc:23:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (path.size() <= config->includeCompletionMaximumPathLength)
       ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[13/33] Compiling src/language_server_api.cc
[14/33] Compiling src/lex_utils.cc
../src/lex_utils.cc: In function ‘lsPosition CharPos(const string&, char, int)’:
../src/lex_utils.cc:28:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   while (index < search.size()) {
          ~~~~~~^~~~~~~~~~~~~~~
In file included from /nix/store/dpza5shcrnf4m8rjsbxb34hf1vnppbbp-gcc-6.4.0/include/c++/6.4.0/cassert:44:0,
                 from ../third_party/rapidjson/include/rapidjson/rapidjson.h:401,
                 from ../third_party/rapidjson/include/rapidjson/allocators.h:18,
                 from ../third_party/rapidjson/include/rapidjson/reader.h:20,
                 from ../third_party/rapidjson/include/rapidjson/document.h:20,
                 from ../src/serializer.h:5,
                 from ../src/config.h:3,
                 from ../src/language_server_api.h:3,
                 from ../src/lex_utils.h:3,
                 from ../src/lex_utils.cc:1:
../src/lex_utils.cc:40:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   assert(index < search.size());
          ~~~~~~^~~~~~~~~~~~~~~
../src/lex_utils.cc: In function ‘std::experimental::optional<lsRange> ExtractQuotedRange(int, const string&)’:
../src/lex_utils.cc:56:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   while (start < line.size()) {
          ~~~~~~^~~~~~~~~~~~~
../src/lex_utils.cc:62:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (start == line.size())
       ~~~~~~^~~~~~~~~~~~~~
../src/lex_utils.cc: In function ‘void LexFunctionDeclaration(const string&, lsPosition, std::experimental::optional<std::__cxx11::basic_string<char> >, std::__cxx11::string*, int*)’:
../src/lex_utils.cc:90:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     while (name_end < buffer_content.size()) {
            ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
../src/lex_utils.cc:143:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   while (end < buffer_content.size()) {
          ~~~~^~~~~~~~~~~~~~~~~~~~~~~
../src/lex_utils.cc: In function ‘std::__cxx11::string LexWordAroundPos(lsPosition, const string&)’:
../src/lex_utils.cc:177:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   while ((end + 1) < content.size()) {
          ~~~~~~~~~~^~~~~~~~~~~~~~~~
../src/lex_utils.cc: In function ‘void _DOCTEST_ANON_FUNC_6()’:
../src/lex_utils.cc:226:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int i = 0; i < content.size(); ++i) {
                   ~~^~~~~~~~~~~~~~~~

[15/33] Compiling src/match.cc
../src/language_server_api.cc: In function ‘std::experimental::optional<std::__cxx11::basic_string<char> > ReadJsonRpcContentFrom(std::function<std::experimental::optional<char>()>)’:
../src/language_server_api.cc:73:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (size_t i = 0; i < content_length; ++i) {
                      ~~^~~~~~~~~~~~~~~~

[16/33] Compiling src/options.cc
[17/33] Compiling src/platform.cc
[18/33] Compiling src/platform_linux.cc
../src/indexer.cc: In member function ‘std::experimental::optional<std::__cxx11::basic_string<char> > {anonymous}::ConstructorCache::TryFindConstructorUsr(const string&, const std::vector<std::__cxx11::basic_string<char> >&)’:
../src/indexer.cc:178:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
            i < std::min(param_type_desc.size(), ctor.param_type_desc.size());
            ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[19/33] Compiling src/platform_win.cc
[20/33] Compiling src/position.cc
../src/platform_linux.cc: In function ‘std::__cxx11::string NormalizePath(const string&)’:
../src/platform_linux.cc:160:38: warning: ignoring return value of ‘char* realpath(const char*, char*)’, declared with attribute warn_unused_result [-Wunused-result]
   (void) realpath(path.c_str(), name);
                                      ^

[21/33] Compiling src/project.cc
[22/33] Compiling src/query.cc
[23/33] Compiling src/query_utils.cc
../src/project.cc: In function ‘int {anonymous}::ComputeGuessScore(const string&, const string&)’:
../src/project.cc:311:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (i = 0; i < a.length() && i < b.length(); ++i) {
               ~~^~~~~~~~~~~~
../src/project.cc:311:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (i = 0; i < a.length() && i < b.length(); ++i) {
                                 ~~^~~~~~~~~~~~
../src/project.cc:318:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int j = i; j < a.length(); ++j) {
                   ~~^~~~~~~~~~~~
../src/project.cc:322:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int j = i; j < b.length(); ++j) {
                   ~~^~~~~~~~~~~~
../src/project.cc:329:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int offset = 1; offset <= a.length() && offset <= b.length(); ++offset) {
                        ~~~~~~~^~~~~~~~~~~~~
../src/project.cc:329:55: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int offset = 1; offset <= a.length() && offset <= b.length(); ++offset) {
                                                ~~~~~~~^~~~~~~~~~~~~
../src/project.cc: In member function ‘void Project::Load(const std::vector<std::__cxx11::basic_string<char> >&, const string&, const string&)’:
../src/project.cc:366:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int i = 0; i < entries.size(); ++i)
                   ~~^~~~~~~~~~~~~~~~
../src/project.cc: In member function ‘void Project::ForAllFilteredFiles(Config*, std::function<void(int, const Project::Entry&)>)’:
../src/project.cc:400:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int i = 0; i < entries.size(); ++i) {
                   ~~^~~~~~~~~~~~~~~~
../src/project.cc: In function ‘void CheckFlags(const string&, const string&, std::vector<std::__cxx11::basic_string<char> >, std::vector<std::__cxx11::basic_string<char> >)’:
../src/project.cc:434:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int i = 0; i < std::min(result.args.size(), expected.size()); ++i) {
                   ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[24/33] Compiling src/serializer.cc
[25/33] Compiling src/standard_includes.cc
[26/33] Compiling src/task.cc
[27/33] Compiling src/test.cc
[28/33] Compiling src/third_party_impl.cc
../src/test.cc: In function ‘void DiffDocuments(std::__cxx11::string, std::__cxx11::string, rapidjson::Document&, rapidjson::Document&)’:
../src/test.cc:49:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int i = 0; i < len; ++i) {
                   ~~^~~~~

[29/33] Compiling src/timer.cc
[30/33] Compiling src/utils.cc
[31/33] Compiling src/work_thread.cc
[32/33] Compiling src/working_files.cc
../src/command_line.cc: In function ‘bool QueryDbMainLoop(Config*, QueryDatabase*, bool*, MultiQueueWaiter*, {anonymous}::QueueManager*, Project*, FileConsumer::SharedState*, {anonymous}::ImportManager*, {anonymous}::TimestampManager*, WorkingFiles*, ClangCompleteManager*, IncludeComplete*, {anonymous}::CodeCompleteCache*, {anonymous}::CodeCompleteCache*, {anonymous}::CodeCompleteCache*)’:
../src/command_line.cc:1974:39: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             msg->params.position.line < file->all_buffer_lines.size())
             ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/command_line.cc: In lambda function:
../src/command_line.cc:2134:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
                 if (active_param < response.result.signatures.size()) {
                     ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/command_line.cc: In function ‘bool QueryDbMainLoop(Config*, QueryDatabase*, bool*, MultiQueueWaiter*, {anonymous}::QueueManager*, Project*, FileConsumer::SharedState*, {anonymous}::ImportManager*, {anonymous}::TimestampManager*, WorkingFiles*, ClangCompleteManager*, IncludeComplete*, {anonymous}::CodeCompleteCache*, {anonymous}::CodeCompleteCache*, {anonymous}::CodeCompleteCache*)’:
../src/command_line.cc:2604:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             for (int i = 0; i < db->detailed_names.size(); ++i) {
                             ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/command_line.cc:2858:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         for (int i = 0; i < db->detailed_names.size(); ++i) {
                         ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/command_line.cc:2866:40: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             if (response.result.size() >= config->maxWorkspaceSearchResults)
                 ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/command_line.cc:2871:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         if (response.result.size() < config->maxWorkspaceSearchResults) {
             ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/command_line.cc:2872:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
           for (int i = 0; i < db->detailed_names.size(); ++i) {
                           ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/command_line.cc:2880:42: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
               if (response.result.size() >= config->maxWorkspaceSearchResults)
                   ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../src/working_files.cc: In function ‘lsPosition {anonymous}::GetPositionForOffset(const string&, int)’:
../src/working_files.cc:13:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (offset >= content.size())
       ~~~~~~~^~~~~~~~~~~~~~~~~
../src/working_files.cc: In member function ‘void WorkingFile::SetIndexContent(const string&)’:
../src/working_files.cc:47:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int i = 0; i < index_lines.size(); ++i) {
                   ~~^~~~~~~~~~~~~~~~~~~~
../src/working_files.cc: In member function ‘void WorkingFile::OnBufferContentUpdated()’:
../src/working_files.cc:64:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int i = 0; i < all_buffer_lines.size(); ++i) {
                   ~~^~~~~~~~~~~~~~~~~~~~~~~~~
../src/working_files.cc: In member function ‘std::experimental::optional<int> WorkingFile::GetBufferLineFromIndexLine(int) const’:
../src/working_files.cc:88:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (index_line < 1 || index_line > index_lines.size()) {
                         ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
../src/working_files.cc: In member function ‘std::experimental::optional<int> WorkingFile::GetIndexLineFromBufferLine(int) const’:
../src/working_files.cc:125:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (buffer_line < 1 || buffer_line > all_buffer_lines.size()) {
                          ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
../src/working_files.cc: In member function ‘std::experimental::optional<std::__cxx11::basic_string<char> > WorkingFile::GetBufferLineContentFromIndexLine(int, std::experimental::optional<int>*) const’:
../src/working_files.cc:167:40: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (*buffer_line < 1 || *buffer_line >= all_buffer_lines.size()) {
                           ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
../src/working_files.cc: In member function ‘void WorkingFiles::OnClose(const Ipc_TextDocumentDidClose::Params&)’:
../src/working_files.cc:361:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int i = 0; i < files.size(); ++i) {
                   ~~^~~~~~~~~~~~~~

../src/query.cc: In member function ‘QueryFuncId IdMap::ToQuery(IndexFuncId) const’:
../src/query.cc:307:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (id.id == -1)
       ~~~~~~^~~~~
../src/query.cc: In member function ‘void QueryDatabase::UpdateDetailedNames(size_t*, SymbolKind, size_t, const string&)’:
../src/query.cc:817:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (*qualified_name_index == -1) {
       ~~~~~~~~~~~~~~~~~~~~~~^~~~~

Waf: Leaving directory `/home/david/workspace/cpp/cquery/build'
Build commands will be stored in build/compile_commands.json
'build' finished successfully (33.769s)

Thanks, for the time being clang works as expected.

@jacobdufault how should I force waf to use gcc to compile even if clang is present on my system? Would adding CXX=g++ in front of command work?

You could try it, but I'm not entirely sure if it will work. Unfortunately sometimes the documentation for waf is a bit hard to read.
CXX=g++ ./waf configure
CXX=g++ ./waf build

I'll try it sometime later or hack around the build system to explicitly point to gcc.

https://github.com/jacobdufault/cquery/pull/80


add fluidsynth via lv2

fluidsynth should be easy to support. Since aap-sfizz is taking longer time than I thought and it will be fairly complicated to identify issues, fluidsynth is easier to diagnose any issues. Especially we know that it works because of fluidsynth-midi-service-j.
What we need:

android-friendly lv2 plugin.
fluidsynth binary package for Android - they have CircleCI build artifacts.
build integration.

Artifact from https://app.circleci.com/pipelines/github/FluidSynth/fluidsynth/390/workflows/e11d4807-66d2-4272-8eab-d53d0453392e/jobs/387/artifacts
https://drive.google.com/uc?export=download&confirm=P-3m&id=1FkVoeHRDq9xRaqG2XGQ6LTDcsZ_DOago

It's on the fluidsynth branch now.

It is merged to main.


Installation Instructions

Clear Installation instructions are needed and readily avaialble.

C++/CUDA

Binary from github release
From source
Docker?

Python

Binary from github release whl.
From source
Docker?
Recommend the use of venvs when isntalling from whl/source.

Pre-requisite dependencies will need listing for each platform for each install method?
If visusalisation is the only option for binaries then additional steps may be required.

Torch has a very nice method of providing installation isntructions for different versions of torch:

source
Rapids provide a similar / more complex version of this too:


Tenant UI Library updates

Update Node and Vue app packages.
Fix unit test issues as vitetest after update was not cool with the path
import { testErrorResponse, testSuccessResponse } from 'test/commonTests';
Primevue update. See https://github.com/bcgov/traction/issues/753
Thanks to @jamshale for figuring out Unit test changes from PrimeVue (see files changed for relevant issues with expect(wrapper.getComponent({ name: 'Dialog' }).vm.visible).toBe(true);

Regression tested with
6214611c-1d95-4c30-92a1-15242e2213d4
af2ce738-5224-4737-bc94-e3491b7f8ecb

I don't think I can approve but looks good to me :+1:


UIINREACH-33: INN-Reach Record Contribution: Configure Item Contribution Options

Purpose
Added item contribution options according to UIINREACH-33
Screenshots

yarn run v1.22.5
$ eslint ./ && stylelint "src/**/*.css"
/home/jenkins/workspace/folio-org_ui-inn-reach_PR-31/project/src/settings/routes/ContributionOptionsRoute/ContributionOptionsCreateEditRoute.js
229:9  error  Callbacks must be listed after all other props  react/jsx-sort-props
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the --fix option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.


Do method private in hystrix client.

Currently the do function is private
https://github.com/gojektech/heimdall/blob/6ce64ecf951195bdff9db6b754d81253a22f4235/hystrix_client.go#L124
This prevents from using heimdall as true http.Client wrapper.

https://github.com/gojektech/heimdall/issues/3

This is fixed in #10. Thanks to @sohamkamani


take care of the naming

make a decision about the name of the drive plugin as well as the base plugin in order to load them in the right order

eviltrouts suggestion:
discourse-sync-base
discourse-sync-googledrive
discourse-sync-dropbox
discourse-sync-etc…

Someone in Discourse has suggested:

discourse-sync-base
discourse-sync-to-amazon-glacier
discourse-sync-to-googledrive
…

As most probably there will be an amazon-something plugin too. I say +1 for that.


Why is Client Secret Needed

The lock should be able to function with a redirect without needing the client secret at all.

Lock does not need the client secret, nor can it use it in any way. The client secret in this plugin is used to make Auth0 API calls such as sending verification emails or exchanging OAuth codes for tokens.

@rolodato
Why is that needed by the WP plugin and not any other webpage using the Lock?

@cancan101 I think @rolodato was clear. It is needed to make api requests from the backend. Lock doesnt use the secret for ovbious security reasons, but is always needed in the backend.


Remove append partition hack from Hive parquet sources when moving to Execution completely

This hack doesn't work for the Execution stuff and we got a different approach in Maestro to work around it. We should remove this approach when we have moved away from the old API.
The approach in Maestro also fixes #43.

@stephanh What's the current status of this issue?

Not an issue now that there is no Hive parquet source


Stop sending time commands then in Print Summary mode (PS=1). Increase compatibility with Domoticz.

This issue can be closed.
Sending SC is disabled on latest stable 0.10.1


Error compiling example code in PlatformIO

I am receiving the following error when attempting to compile an example in PlatformIO.
Here is the example sketch:
`#include <Arduino.h>
#include <FastX9CXXX.h>
/*
Example project to control a X9CXXX digital potentiometer
https://github.com/GitMoDu/FastX9CXXX
modified 30 Aug 2017
by MoDu
*/
#define X9_CS_PIN 3
#define X9_UD_PIN 4
#define X9_INC_PIN 5
FastX9CXXX Potentiometer;
void setup() {
Serial.begin(9600);
Serial.println();
Serial.print(F("X9C104 Digital Potentiometer setup..."));
randomSeed(analogRead(0));
//Potentiometer.Begin();
Potentiometer.Setup(X9_CS_PIN, X9_UD_PIN, X9_INC_PIN);
Serial.println(F(" complete."));
}
void loop() {
Potentiometer.JumpToStep(100);
Serial.print(F("Potentiometer current step: "));
Serial.print(Potentiometer.GetStep(), DEC);
Serial.println();
delay(1000);    // wait for a second
}`
Here is the error being returned.
src/main.cpp:18:1: error: invalid use of template-name 'FastX9CXXX' without an argument list  FastX9CXXX Potentiometer;  ^~~~~~~~~~ src/main.cpp:18:1: note: class template argument deduction is only available with -std=c++1z or -std=gnu++1z In file included from src/main.cpp:12:0: lib/FastX9CXXX/src/FastX9CXXX.h:23:7: note: 'template<long unsigned int Resistance> class FastX9CXXX' declared here  class FastX9CXXX        ^~~~~~~~~~
Any help would be appreciated
Thanks, Mitch

Ok so the WiperTest works fine. I see now that the code above we not implementing the class correctly.

You were just missing the pins on the constructor. It seems like some examples haven't been updated, I'll can fix that quick.


closes #3665 - Show original exception in error messages.

Updated init function to include Original Exception attribute as originalExc.
Updated individual error classes to display originalExc.
Updated convert_os_errors to pass exception type into init function for each error type.
Tested by raising various types of errors within local fs implementation.

Thanks for the response.  I actually intended to push to a forked version
and forgot to change my source.
On Fri, Oct 14, 2016 at 11:29 AM, Will McGugan<EMAIL_ADDRESS>wrote:

@willmcgugan commented on this pull request.
Sorry, I don't think this adds much. I see what you are trying to do. But
often the 'original exception' isn't helpful and even misleading. Better to
store any exception object in the 'details' parameter.
In fs/errors.py
https://github.com/PyFilesystem/pyfilesystem/pull/266#pullrequestreview-4290054
:

@@ -49,30 +49,31 @@ class FSError(Exception):
"""Base exception class for the FS module."""
default_message = "Unspecified error"

def init(self,msg=None,details=None):

def init(self, msg=None, details=None, originalExc=None):

Parameters should be lower_case_and_underscores
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PyFilesystem/pyfilesystem/pull/266#pullrequestreview-4290054,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVsXDSJ9WQslBKyKNuGGLuCzS-iWeroTks5qz5_DgaJpZM4KXHXF
.

--
David Lund
Developer
SmartFile
p:<PHONE_NUMBER>  e<EMAIL_ADDRESS>a: 1025 N. Senate Ave. Indianapolis, IN 46202
https://facebook.com/smartfile https://twitter.com/smartfile
https://linkedin.com/company/smartfile
https://www.smartfile.com/email-cta