Concurrency compile error when compiled as a dependency of an Swift 6/Xcode 16 package

Hello,
I am using Xcode 16b3 on Apple silicon. When I create a fresh, Swift 6 package (swift-tools-version: 6.0) and take a dependency on swift-html and attempt to use the vended HtmlSnapshotTesting library, I get a compile error allegedly from this line
https://github.com/pointfreeco/swift-html/blob/e9497dcfbe19e433297f7f9dbea91f90cea63a65/Sources/HtmlSnapshotTesting/HtmlSnapshotTesting.swift#L14
The error is:
🛑 Static property 'html' is not concurrency-safe because non-'Sendable' type 'Snapshotting<Array<Node>.ArrayLiteralElement, String>' (aka 'Snapshotting<Node, String>') may have shared mutable state

I am a little confused because I thought it was an explicit feature of the Swift 6 language mode that I could adopt Swift 6 and my dependencies would continue to compile in their earlier declared language mode. But perhaps I misunderstood.
I have created a sample consumer package that demonstrates the issue. Open with Xcode 16 and attempt to run the sole test. I expect the test to run, but instead it fails to compile. If you drop the package's swift-tools-version from 6.0 to 5.10, the package should then compile and the test will run.
Happy to be told if I am holding it wrong and feel free to close this issue. Thank you.
Test-swift-html-compile.zip

Possibly related discussion on the Swift forums.
And the Swift PR mentioned within: swiftlang/swift#74614
If we think that's it, happy to close this as an Apple bug.

I believe Xcode 16b4 has resolved this issue, so I will close it.


Fixed describe block that should be test

Ran into a testing issue while working on #134 and saw describe being used instead of test.

Pull Request Test Coverage Report for Build 0d0cc4b6d4fc64599eabe41626b91675ca96db33-PR-135
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.448%

Totals

Change from base Build d42dc90bcfa8a2b6c1f082fb47869e4769f9e9de:
0.0%

Covered Lines:
271

Relevant Lines:
290

💛  - Coveralls


Errors using Elastalert to post to https://

I am using the rule file below and getting the following error.  The email part works.
SSLError: HTTPSConnectionPool(host='<IP_ADDRESS>', port=9200): Max retries exceeded with url: / (Caused by SSLError(SSLError("bad handshake: Error([('SSL routines', 'ssl3_get_record', 'wrong version number')],)",),))

name: snmp data ingest pipeline down
type: flatline
index: snmplogger-*
ca_certs:  /etc/ssl/certs/ca-bundle.pem
threshold: 500000
use_count_query: true
doc_type: "doc"
realert:
hours: 12
threshold_cur: 10
timeframe:
minutes: 15
alert:

"email"
"post"

email:

<EMAIL_ADDRESS>smtp_host: "imap.imapdomain.com"
from_addr<EMAIL_ADDRESS>
post:
http_post_url: "https://notify.domain.com"
http_post_payload:
notification_type: "SNMPtrap"
identifier: "name-string-here"
end_date_time: "2050-12-31 02:00:00"
description: "This is a test"
communication_types: ["zendesk", "email", "noc_notification"]
http_post_headers:
content-type: "application/json"
Authorization: "N6a777vFju"

Hi, @JenniferSilverman
Is your Elasticsearch(<IP_ADDRESS>:9200) work with HTTPS?
Please paste your result of curl -vk https://<IP_ADDRESS>:9200.

Im using the rules file bellow and i don't getting any error in elastalert logs, but i don't recieve any alert in ZAMMAD
alert: post
http_post_url: "https://itsm.xxxxxxx.de/api/v1/tickets"
http_post_payload:  #List of keys:values to use as the content of the POST. Example - ip:clientip will map the value from the clientip index of Elasticsearch to JSON key named ip.
description: "this is a test"
http_post_headers:
Content-Type: "application/json"
authorization: "Bearer ah6cjMAzZ4mkU8"


Updated dutch minute abbreviation to min

As discussed in this PR: https://github.com/desktop-dart/duration/pull/46#issuecomment-951871036
Changing minute m to min to avoid confusion with month

Thanks for the PR


Rework the device icons

Is your feature request related to a problem? Please describe.
It  is time to re-work the device icons in the settings UI.
Describe the solution you'd like
They should be bigger.
All devices should have their own distinct icon.
Icons should relate to their device.
Describe alternatives you've considered
Leave it as it is.
Additional context
Nothing.

Äre these PNG or is it easy to render SVG?

At the moment they have to be png... but I would create them with a Vector based program like Inkscape and then export them as PNG files.

I can work on these. Will do them in SVG but align to pixel grid so they look crisp. What size does the list widget expect them in if you specify a larger size?

Some ideas for feedback.
Button:

LED:

I'm thinking of color coding inputs and outputs so that inputs are blue for example, and outputs are red, so it is easier to tell them apart at a glance.

Potentiometer:

Encoder:

New approachj, wtih 16x16 icons.
Also trying to have distinct visual silhouettes for icons.

i like them! i think color coding would help on top of the shape. the led stands out in style with the gradient. Maybe we can find a representation that is more like the other ones?

I adding these nice board images made by @tigert, originally mentioned in #756
Uno:

Mega:

Mega Mini (we can still show it in a list even though it is just a "mega" technically)

Pro Micro:

Adding the icons here.

Outputs
Led/output:

Led/7segment:

Servo:

Stepper:

LCD Display:

Output shift register:

Inputs
Encoder:

Button:

Analog input:

Input shift register:

Input multiplexer:

This zip contains the svg files too.
mobiflight-icons-2023-11-11.zip

updated the analog input icon and the zip


Handle inbound tx messages in PushTransaction in the Inbound service

Is your feature request related to a problem? Please describe.
The inbound network service should handle PushTransaction requests correctly.
This implements handling an unsolicited tx message from a remote peer, when a transaction is added to that peer's mempool.
Describe the solution you'd like
Dependent on RFC6 design, update this description when that design is finalized.
Additional context
Part of #889.
Blocked on having a mempool.
Blocked on RFC6 design (#1006) and implementation (#1008).

https://developer.bitcoin.org/reference/p2p_networking.html#tx

I've clarified this ticket to focus on inbound transactions from peer mempools

This may be the same as https://github.com/ZcashFoundation/zebra/issues/2692 ?

Closed by https://github.com/ZcashFoundation/zebra/pull/2727


Optionally silence CLI commands in integration tests

Sometimes during troubleshooting integration tests, we have commands
that either run several times due to Eventually-ies, or are just
chatty (like discover commands that return peers and their information).
This information is many times distracting and makes focusing on the logs
printed by the nodes harder.
This change set adds an option to silence CLIs via a flag.
Change-Id: I3480c4286dc8880b402831c1f9c8de7bd3538feb
Signed-off-by: yacovm<EMAIL_ADDRESS>

Without this change, ginkgo simply buffers the output and will only dump it when tests fail. This seems like appropriate and expected behavior.

With this change, this is the default behavior.
Only if you opt out of logging CLI output, this has any effect.

Suppressing all output at the network level discards everything written by the command. As soon as someone enables that, there will be no debug data.

There will be debug data of all nodes (peers, orderers) and sometimes that's all that is interesting to a developer that is running the integration test.

Only if you opt out of logging CLI output, this has any effect.

The concern is that you're enabling this behavior at the level of all command sessions - programatically. If this is only intended for local debug, it's easy enough to change the code to use ioutil.Discard. If the proposal enabled a more fine-grained approach, I would be less concerned.

There will be debug data of all nodes (peers, orderers) and sometimes that's all that is interesting to a developer that is running the integration test.

And it should come as no surprise that the session output code in nwo behaves the same as ginkgomon - and for the same reasons.
If you only want to see output from a peer or an orderer, each line of output is prefixed with the process type so it's pretty trivial to capture output and filter it with grep. If you want to remove noise from a command, that's also easy to suppress.
While I understand that the noise is annoying (I feel the same way), in automated environments, I'd rather have more data than less.


fix remove the field writer which only differ in first character that one is upper case the other is lower case

What this PR does / why we need it?
fix remove the field writer which only differ in first character that one is upper case the other is lower case
Summary of your change
Please indicate you've done the following:

[ ] Made sure tests are passing and test coverage is added if needed.
[ ] Made sure commit message follow the rule of Conventional Commits specification.
[ ] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Codecov Report
Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.83%. Comparing base (f6cdd54) to head (fdb4e06).
Report is 58 commits behind head on main.

Files with missing lines
Patch %
Lines

.../alibaba/fastjson2/writer/ObjectWriterCreator.java
55.55%
1 Missing and 3 partials :warning:

...ibaba/fastjson2/writer/ObjectWriterCreatorASM.java
66.66%
1 Missing and 2 partials :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3222      +/-   ##
============================================
- Coverage     74.27%   72.83%   -1.44%
+ Complexity    23542    22781     -761
============================================
  Files           659      656       -3
  Lines         91870    91574     -296
  Branches      20539    20427     -112
============================================
- Hits          68238    66702    -1536
- Misses        15240    16312    +1072
- Partials       8392     8560     +168

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

没有单测？


Add network topology tab

Add network tab to the topology page.
Add support for passing react components to the translate function.
Add additional Sort functions to facilitate sorting objects and arrays
of objects.

The subject of the last commit should say "control plane tab", not "control panel tab". But since we are going to squash and merge, that should all just disappear when the pull request is accepted.


Add Social Media Links to the Placeholder in Website

Description: We want to improve the LisBook website by adding social media links in a designated placeholder (such as the footer or header). These links will allow users to easily connect with the project's maintainer on various social media platforms.
Tasks:
Identify the placeholder section:
Locate where the social media icons or text links should be added (e.g., footer, header, or sidebar).
Add the following social media links:
Instagram: dev_with_ctoic
Twitter: Ct0ic
LinkedIn: ctoic
YouTube: Ishowsciencee
Link Icons:
Add appropriate icons for each social media platform (you can use FontAwesome icons or similar).
Style them to match the current theme of the website.
Responsive Design:
Ensure the social media icons or links are responsive and display properly across devices (desktop, tablet, and mobile).
Hover Effects (Optional):
Optionally, add hover effects to the icons, such as changing colors or increasing the size slightly when hovered over.
Acceptance Criteria:
Social media icons or links are correctly added in the designated placeholder (footer, header, or sidebar).
The icons are functional, linking to the respective social media platforms.
The design is responsive and fits the current website theme.
Resources:
You can use FontAwesome or another library for icons.

Go ahead @PModhe09

Don't forget to ⭐ the repo


shape(...) declaration seems to break syntax highlighting.

It seems that the shape annotation seems to break syntax highlighting in vscode-hack. Here is a slack thread with an image and related discussion: https://slack-pde.slack.com/archives/C8Y5M8FRQ/p1571191558002100

Related issue #58

Related: https://github.com/slackhq/vscode-hack/pull/69 brings in the latest changes from the Facebook IDE team.  I think this may correct the issue.

This appears to be solved with the latest revision to the grammar:


feat: implement ecall API, remove AWS API

Oops, the GitHub UI played me a trick there - of course this was supposed to be a MR against our fork. Sorry for the noise!
PS: Thanks for your all your work on all things keycloak. I've found the videos super helpful! :100:


Implement ArrayFission

This PR adds the ArrayFission pass, which is the array counterpart of the existing ScalarFission pass. The main functionality is outsourced in a separate pass (VariableFission), which will be used in a future PR for a new version of Scalar Fission.

This seems to overlap with the write set approximation review that is being merged. Could you please remove those aspects that are already included there?

You are right. I will fix that as soon as the other PR is closed.


[BUG] assert referenced_declaration is not None

  File "C:\Users\pfapostol\AppData\Local\Programs\Python\Python38\lib\site-packages\woke\lsp\server.py", line 268, in _task_done_callback
    task.result()
  File "C:\Users\pfapostol\AppData\Local\Programs\Python\Python38\lib\site-packages\woke\lsp\lsp_compiler.py", line 187, in run
    await self.__compilation_loop()
  File "C:\Users\pfapostol\AppData\Local\Programs\Python\Python38\lib\site-packages\woke\lsp\lsp_compiler.py", line 977, in __compilation_loop
    await self.__compile(self.__discovered_files)
  File "C:\Users\pfapostol\AppData\Local\Programs\Python\Python38\lib\site-packages\woke\lsp\lsp_compiler.py", line 876, in __compile
    await self.__compile(files_to_recompile, False)
  File "C:\Users\pfapostol\AppData\Local\Programs\Python\Python38\lib\site-packages\woke\lsp\lsp_compiler.py", line 848, in __compile
    self.__ir_reference_resolver.run_post_process_callbacks(
  File "C:\Users\pfapostol\AppData\Local\Programs\Python\Python38\lib\site-packages\woke\ast\ir\reference_resolver.py", line 174, in run_post_process_callbacks
    callback(callback_params)
  File "C:\Users\pfapostol\AppData\Local\Programs\Python\Python38\lib\site-packages\woke\ast\ir\meta\import_directive.py", line 165, in _post_process
    assert referenced_declaration is not None
AssertionError

https://github.com/code-423n4/2023-10-wildcat
When you try the ctrl+cliсk function, but sometimes it’s just like that.

This is the same issue as https://github.com/Ackee-Blockchain/woke/issues/274. The problem is overloaded functions imported in import directives.

The issue should be fixed in Tools for Solidity 1.10.4.


Introducing .NET IL Linker

Introducing .NET IL Linker
The .NET Core team has been working on a linker in collaboration with the Mono team. It is based on the Mono Linker project, and by extension, on the Cecil project.
The goal of the .NET IL Linker project is two part:

Provide a capable linker for .NET Core to make it easy to significantly reduce .NET Core application sizes.
Establish the Mono Linker as the primary linker for the .NET ecosystem.

You can start using the linker today, using the following instructions:

Using the .NET IL Linker
Using IL Linker Advanced Features

Details
In trivial cases, the linker can reduce the size of applications by 50%. The size wins may be more favorable or more moderate for larger applications. The linker removes code in your application and dependent libraries that are not reached by any code paths. It is effectively an application-specific dead code analysis.
The IL Linker currently only supports .NET Core Self Contained Applications with this first preview version. You can try using the linker with an example self-contained .NET Core application sample. The primary difference with this application is that it has a reference to the ILLink.Tasks package in its cspoj project file.
The Linker provides an option to print a size improvement chart that describes binaries that have been removed from an application or that have been reduced in size. It also provides the total % size reduction for the application. You can see an example of one of these charts in the following example.

Please provide feedback on your use of the linker. We are actively looking for feedback to improve the linker. In particular, we are looking for feedback on the following topics:

Linker throughput.
Cases where the linker can be more aggressive.
Cases where the link is too aggressive and causes applications to fail at runtime.
The linker provided an excellent result for a large application.

Please create issue with your feedback at either mono/linker or dotnet/core. Also feel free to contact the team at<EMAIL_ADDRESS>And, it wouldn't be right to announce this linker without a hat tip to Joel Spolsky who we can give the honorary and historical distinction of feature requestor.

Is the end goal here smaller deployments or does this get us closer to being able to ship single file self contained applications executable?

@AlgorithmsAreCool The primary goal is smaller deployments that only have the code you need in them (better pay-for-play). The self contained executable scenario will definitely benefit from this but I don't think they are neccessarily tied.

Is the end goal here smaller deployments or does this get us closer to being able to ship single file self contained applications executable?

I wonder if after linting we could leverage something like ILMerge as a secondary (and optional) build step for a single executable scenario.

@galvesribeiro Yes. ILMerge (or something like it, like mkbundle would be step 2.
We will probably build a single file toolchain at some point, but it is a ways off right now.
As @Petermarcu suggests, the primary goal is smaller deployments.

And, it wouldn't be right to announce this linker without a hat tip to Joel Spolsky who we can give the honorary and historical distinction of feature requestor.

13 years.  Better late than never, I suppose...

The IL Linker currently only supports .NET Core Self Contained Applications with this first preview version.

Does this mean the linker will eventually support .NET Framework / Mono, or is it planned to be Core-only?

And, it wouldn't be right to announce this linker without a hat tip to Joel Spolsky who we can give the honorary and historical distinction of feature requestor.

nit: I bet, or rather, I know, if you look at the MS internal distribution group discussions back about the time C# was released you will find others that asked for this also.
I'm incredibly happy this is finally becoming a reality.

My project has references to some (large) libraries but only a small part of them are actually used. (No reflection is used)
According to the docs, non-framework assemblies are all root assemblies by default. Can I remove some of them from LinkerRootAssemblies without adding the ILLink to the csproj?

The IL Linker currently only supports .NET Core Self Contained Applications with this first preview version.
Does this mean the linker will eventually support .NET Framework / Mono, or is it planned to be Core-only?
@Phrohdoh The Core linker shares the same base linking tool with Mono (so good news, that already works).  We've started to think about bringing ILLinker to .NET Framework but we don't have a concrete plan yet - so stay tuned.

@hjc4869, if you don't want to specify all of the inputs to ILLink by using the task in your .csproj, you should be able to do this by inserting your own target that removes these assemblies from LinkerRootAssemblies, like this:
<Target Name="UnrootAssemblies" AfterTargets="_ComputeLinkerRootAssemblies">
  <ItemGroup>
    <LinkerRootAssemblies Remove="Assembly.Name.Without.Dll.Extension" />
  </ItemGroup>
</Target>

This relies on the private target _ComputeLinkerRootAssemblies, so consider this unsupported. :) We should probably make the default behavior more configurable to make this easier in the future.

Will this be chainable with the /t:LinkNative target from CoreRT? So I can trim down my assemblies before AOT compilation?

@markrendle Why would you do that? AOT compilation does this by default.

Great idea, but unfortunately it can potentially break our product, so I’d like to describe our scenario:
My team works on an APM product which is basically a Profiler with IL Rewriting. We use the profiler API to inject our code with AssemblytRefs and TypeRefs to existing types into the customers application. Now these references can be trimmed, which leads to crashes.
Until this point our approach for .NET Core was that we only used references to Types that are part of Netstandard. We thought with that we are on the safe side, now it turns out this is not the case.
I looked at this  and I understand that we can exclude dlls from trimming, but we do our injection runtime, so our customers with this approach have to recompile their applications and we have to extra maintain the list of Types we use. This is extremely hard in our case -I’d say this is not feasible at all. (I can go into more details, but I guess you can imagine the situation…e.g.: what if we update our stuff, etc. ).
Did you consider this scenario? The problem itself is similar to the problem with reflection I guess. Our goal would be that we don’t have to say that “this is an unsupported scenario”. Furthermore, crashes caused by this are I think very problematic and we should figure out a solution to at least prevent TypeLoad-crashes caused by this.
Maybe one option that comes to my mind:
Would it be an option to implement a flag within the Linker that ensures that e.g. no Netstandard types will be removed? That way we can at least have a fix set of APIs that we can use and customers then compile the application with this single flag. Of course, we also should somehow handle scenarios where the application is not built with this flag.
Thanks!
cc @richlander @terrajobst @karelz

It seems like providing a convenient way to root .NET Standard types would be pretty straight forward.

@Petermarcu thanks for the feedback. That's good news. Of course the question is: does mono linker make sense with that setup? I mean, if with that setup the application only gets a few percent smaller, then the idea isn't so good. Anyway, this was just my first suggestion... Maybe somone comes up with another solution.
And please don't forget the other part: it would still be nice if a profiler could somehow figure out that important dlls (Like System.Runtime, System.Threading.*, System.Collections)  were trimmed, so we can prevent crashes.

It definitely takes away some of the value. The only other way I can think of is to come up with a good way to be explicit about the dependencies that could be added by your rewriter. You said that wasn't feasible but it may be worth digging into that a little more.

What about something like anotations? Maybe some kind of attribute that specifies to the linker which types to consider as roots. The linker then would mark those types as roots and combine that information with the other channels (like creating your own target).
Finally, the linker would remove from the final assembly the references to the attributes used to annotate.
I think that would be a very easy way of protecting a type you know you are going to use with reflection or whatever.
What do you think?

Closing as we plan on keeping these announcements open for about 30 days.

@Petermarcu, I hope this wasn't intentional that the announcement failed to answer one basic question: is ILLink an open source tech? If so where can I find the EXACT sources of package we are using?
The first line in announcement do note:

The .NET Core team has been working on a linker in collaboration with the Mono team. It is based on the Mono Linker project, and by extension, on the Cecil project.

But where are the sources of https://dotnet.myget.org/feed/dotnet-core/package/nuget/Illink.Tasks package that the end consumer is using?

@kasper3 I’m pretty sure the source are going to appear at some level of maturity. I don’t think that was a good reason to open an issue on announcements which as result will spam us all ;)

@kasper3

But where are the sources of https://dotnet.myget.org/feed/dotnet-core/package/nuget/Illink.Tasks package that the end consumer is using?
Here they are:
https://github.com/mono/linker/tree/master/corebuild/integration/ILLink.Tasks

Is this project dead? The latest NuGet package was from 2018 and there has been no recent news (that I can find).

@RehanSaeed the current package has many issues because the extension points it uses to hook into the SDK have drifted (see https://github.com/dotnet/sdk/issues/2583). We are reworking the experience with what will hopefully be a longer-term solution, and the plan is for it to be a part of the SDK. You can follow the work going on at https://github.com/mono/linker if you're interested. Stay tuned for updates from the .NET team! :)
The trimming tool is indeed similar. The linker is potentially able to do a more fine-grained analysis (based on code it thinks will be executed), depending on the settings. This also has the potential to break code that uses reflection.
UWP apps aren't supported - I'm no expert, but my understanding is that UWP release builds use the .NET Native toolchain, which has its own dependency reducer, similar in spirit to the linker.


Unable to find events against ownCloud server

I don't know enough about CalDAV to diagnose this by poking around, but I can't seem to get any events from my server with find_events.
2.6.0 :007 > cal.find_events(start: '1970-01-01', end: '2019-12-31')
 => false

I have a few events registered as all-day events within the past few weeks. I've tried a more restrictive query that's one day either side of the event I'm looking for.

Closing, stale.


Last get started wording update

I finished my review, committed a few fixes. Otherwise, it's perfect.
Please wait until we know if you can rebase this branch directly on the docusaurus branch before merging.


Add JustList: {JustList name}

{"address":"dnt3agxsl5emenxrg7cbc7hgc5df6abtpui7yvfdagpbgkkecj4rcqad.onion","status"data":[70016,"/Satoshi:22.0.0(RoninDojo 1.14.1)/",1665382865,1037,758012,bitcoin address:1HqJKQ2KeDishV5SJmFxmCJ2q4foQNcjjA{"address":"dnt3agxsl5emenxrg7cbc7hgc5df6abtpui7yvfdagpbgkkecj4rcqad.onion","status":","data":[70016,"/Satoshi:22.0.0(RoninDojo 1.14.1)/",1665382865,1037,758012,Bitcoin address :1HqJKQ2KeDishV5SJmFxmCJ2q4foQNcjjA 0.0,0.0,null,"TOR","Tor network"],"mbps":0.0,0.0, Bitcoin address :1HqJKQ2KeDishV5SJmFxmCJ2q4foQNcjjA,"TOR","Tor network"],"mbps"bitcoin:1HqJKQ2KeDishV5SJmFxmCJ2q4foQNcjjA

Please submit the correct information, invalid information will cause the issue to close


support for Ubuntu 16.04?

Any chance for this module support Ubuntu 16.04?

We're currently not working on adding support for 16.04. We would probably accept pull requests to add it. Also I wonder if it might just work anyway.


Fixed error in new pg!vibecheck

Bruh avaxar, why did you modify the LICENSE but not this?
Anyways, it should work now

:mike:


Write output to file

Not sure if i'm the only one having this issue, but i ran amass -o out.txt -d domain.com against a domain which has only 3 subdomains and the out.txt was empty. Then i ran amass against a domain which has 11 subdomains and the subdomains was add to the out.txt file. Any ideas?

I think I know the reason

hey @caffix I will let you know. Thanks for your time.

Looks great. Thanks once again


S3mock-junit5 extensions not working with spring-context-indexer enabled

When an application has configured spring-context-indexer annotationProcessor in order to generate spring indexs, S3mock-junit5 extensions fails during unit test because beans contained in the artifact is not being found because it hasn´t got META-INF/spring.components in it.
You can reproduce this case using example test found at S3MockExtensionDeclarativeTest or S3MockExtensionProgrammaticTest and using a simple project generated with spring initializer.
Attached demo.zip contains a simplest application with this configuration as described above

Version affected: all s3mock-junit5 including 2.4.16

SB version: 2.7.2

Possible solution: Include spring-context-indexer as maven-compiler-annotation-processor in order to generate META-INF/spring.components . If an application don´t use spring-indexer, component scan will work as usal, in the other hand if an application use spring-indexer all works fine because artifact has META-INF/spring.components in it

Error obtained:

***************************
APPLICATION FAILED TO START
***************************

Description:

Field kmsKeyStore in com.adobe.testing.s3mock.S3MockApplication required a bean of type 'com.adobe.testing.s3mock.store.KmsKeyStore' that could not be found.

The injection point has the following annotations:
        - @org.springframework.beans.factory.annotation.Autowired(required=true)

Action:

Consider defining a bean of type 'com.adobe.testing.s3mock.store.KmsKeyStore' in your configuration.

@ilopezv thanks for this issue, I'll add spring indixes to the S3Mock since it does not seem to have adverse effects if somebody is not using them, and it may speed up the start of S3Mock itself as well.
Other than that, I would like to point out that when you're directly using the S3Mock in a unit test, both the libraries of your application and the libraries of the S3Mock are mixed together, and there are all kinds of problems with this approach.
I recommend that you look into using S3Mock as a Docker container to avoid these problems.
Have a look at #418 for a longer explanation.

when is the release planned?

@ilopezv I was planning to release this week, but I am currently in the process of refactoring the whole application to better accommodate the various open feature requests.
This is taking longer than expected.
I have merged several 1000+ lines PRs already and I'll need a few more before I can release again, sorry.
Hopefully I'll be done by next week :(

@ilopezv I finished the refactoring, this was quite a big one...
Now, with smaller classes and less duplicated code, it should be easier to implement the missing features like versions, ACLs, additional metadata, ...
I just released 2.5.0 for your convenience. :)

Thanks a lot!!! It seems to be a big release.
Great work!!

@ilopezv I have bad news - this is actually a breaking change for any application using Spring Boot.
I will have to revert this change and make a new release, sorry.
Reading through the documentation the first time, I did not notice that if even one library is found on the classpath including a Component Index, Spring will ignore all other configuration in the service, or other libraries.
For this to work, literally every library you depend on (that provides Spring services) has to provide those indexes.

this was discovered by another customer (where the application did break after updating) in #782

will close this as "won't fix", as I'm not able to solve this for you without breaking other people's integrations, sorry. :(

Sorry, i'm on vacations without computer so i can't review the Code.
As simple solution, could you expose the configuration classes as public so people with indexer could use @import / @contextconfiguration directly on them?

yeah, that is possible. :)

released 2.5.4 earlier today, now all @Configuration / @ConfigurationProperties classes are public.
Have a nice vacation!


How to use scaling parameter in PyWavelet?

I'm using wavelet transform for crop phenology detection. In this i'm using Modis ndvi time series (9 months 8-days composite). I want to apply wavelet transform with scale 32. I know to apply wavelet transform. What i want to know is how to give scaling parameter.
Thanks in advance
Rajasivaranjan

@Rajasivaranjan sorry no one replied to your question yet. This repo isn't really active anymore so not the best place to ask. I suggest the mailing list https://groups.google.com/forum/#!forum/pywavelets and/or StackOverflow, you might have better luck.

Also, some more details may help get a response. For example show the code you have that works and ask how to add scaling to that. That's more concrete and hence easier to answer.


Unpersisted /var/lib/nixos warning doesn't consider regular mounts

Commit 467e24bd041e16a9752de7700d067b2efb9329c9 doesn't take into account situations such as when /var is mounted from a regular filesystem

I got the warning while setting btrfs subvol as /var. Consider adding an option for disabling the warning?

I have /var/lib mounted as a btrfs subvolume so it persists, but I still get the warning:
Neither /var/lib/nixos nor any of its parents are persisted. This means all users/groups without specified uids/gids will have them reassigned on reboot.


Remove create-user

Signed-off-by: Plamen Doychev<EMAIL_ADDRESS>

Coverage decreased (-0.3%) to 90.672% when pulling 9b385b8b12f3f5a604aeae12780b99c78ec00efc on SAP:remove_create_user into 0bab98def401370457b225427160bf51f4076f5b on cloudfoundry-incubator:master.

Coverage decreased (-0.02%) to 90.916% when pulling 4d7b0f49980374066e0f4962dd1e0946492ac23e on SAP:remove_create_user into 0bab98def401370457b225427160bf51f4076f5b on cloudfoundry-incubator:master.

Coverage decreased (-0.02%) to 90.916% when pulling 4d7b0f49980374066e0f4962dd1e0946492ac23e on SAP:remove_create_user into 0bab98def401370457b225427160bf51f4076f5b on cloudfoundry-incubator:master.

Coverage decreased (-0.02%) to 90.916% when pulling 4d7b0f49980374066e0f4962dd1e0946492ac23e on SAP:remove_create_user into 0bab98def401370457b225427160bf51f4076f5b on cloudfoundry-incubator:master.

Coverage decreased (-0.05%) to 90.891% when pulling 61898e0015433fc2d7c5e850d7f64b15348d706e on SAP:remove_create_user into 0bab98def401370457b225427160bf51f4076f5b on cloudfoundry-incubator:master.


ALPHA: Add Support for Kafka Connect

https://github.com/redpanda-data/docs/pull/458/files docs pr
https://github.com/redpanda-data/redpanda-ansible-collection/pull/92 rac pr


Add a search functionality that does not rely on engine modifications.

Description
I have implemented a new search functionality for the FlowGraph plugin that does not rely on engine modifications. This enhancement preserves the original plugin's features while improving compatibility and ease of integration. Key features include:

Changes Made

Independent Search Functionality: Operates without engine modifications, ensuring compatibility with standard Unreal Engine setups.
Node Description Search: Added support to search within node descriptions, this is equivalent to searching for configuration content, which I think is very meaningful.
SubGraph Search: Supports searching within SubGraphs, with user control via a checkbox.

Motivation
The previous search implementation required engine modifications, posing challenges for users preferring a standard engine setup. This update enhances flexibility and ease of use by decoupling the search functionality from engine changes.

Please review the changes and let me know if any further modifications are needed. The FlowGraph plugin has been incredibly helpful for my project. Thank you for your contribution to this fantastic plugin.

just took a look at the code, and I feel like this would be even better than the "Asset Search" plugin...
Since the asset search plugin does not jump to the specific node (at least not for me).
So I'm wondering if it shouldn't be a straight up replacement, instead of #if/else

It is a wonderful idea since Epic hasn't merged my pull requests yet.
The search mechanism used here is a custom logic, not using Asset Search db? If the end result isn't different from what users get while doing global Asset Search, I would gladly pull it in :)

Thank you for your feedback, MothDoctor!

The search functionality leverages a custom widget mechanism, with the logic inspired by FindInBT.h and FindInBT.cpp. Thus, its behavior is similar to the search results seen in Behavior Trees.
After seeing your reply, I took the time to compile the source code. The functionality is mainly consistent. and in custom logic supports searching within SubGraphs and jumping directly to SubGraph nodes.
The search also indexes information from GetNodeDescription, which is frequently searched in my project. This feature is valuable as it allows searching for configuration content rather than just node names.
I’ve attached a GIF below demonstrating the actual effect. I hope this provides a clear picture of the effect.

what maybe might be nice: providing a function on the FlowNode base class "GetSearchKeywords" that returns an array of searchable keywords, for things that don't get added to the title or description!?

The current search contents are: NodeTitle, Description, NodeType, Node Comment.
From my experience, I feel that Description is similar to adding a new SearchKeywords. Of course, if it is for greater clarity, I am also happy to add this item

I'm currently using this PR in our project and so far it has been a nice upgrade over the unreal asset search plugin!

From my experience, I feel that Description is similar to adding a new SearchKeywords. Of course, if it is for greater clarity, I am also happy to add this item

hm. some of our nodes have quite a lot of configurable data, that is not always shown in the description in text form since it would overload the description, or is written in natural language in the description, but that might not be how I'd search for it.
But yeah, right now its working quite nicely so I would not complain if it would be added as is right now :)

We have some interest in this PR at Riot.
Any idea when it can get merged to main?


hashkit: Add correct fnv1* implementations.

Old fnv1* implementations(fnv1_64/fnv1a_64/fnv1_32/fnv1a_32) are not correct as per spec but are compatible with libmemcachd. The corresponding correct implementations are fnv1_64a/fnv1a_64a/fnv1_32a/fnv1a_32a.
This issue is similar to 653b05f861ae3ce0ff143e1067af378f677a4d29 (@manjuraj).
http://en.wikipedia.org/wiki/Fowler–Noll–Vo_hash_function says:
The XOR is an 8-bit operation that modifies only the lower 8-bits of the hash value.

Suppose key is a utf-8 encoded string "\xe4\xb8\xad"(Chinese Character中 in UTF-8). Let's take \xe4(0xe4 >= 0b10000000) as an example:
(uint32_t)(char)0xe4 =<PHONE_NUMBER> // buggy
(uint32_t)(uint8_t)(char)0xe4 = 228 // correct
(uint32_t)(unsigned char)(char)0xe4 = 228 // also correct

cc @windreamer

@manjuraj @idning Would you please review the PR?

I don't think this make sense. anyone else support it?

@idning The old implementation is just wrong. In our real production environment, this buggy fnv1a implementation may lead to unbalanced data distribution.
Also in the fnv home page, there are some solved Zero-hash challenges, which can be used as a sanity test. For example:
SOLVED! What is the shortest binary data set for which the 32-bit FNV-1a hash is 0?
32-bit solution by Russ Cox <rcs Email address> on 2011-Mar-02:
The solutions of length 4 are:

FNV32_1a(cc 24 31 c4) = 0
FNV32_1a(e0 4d 9f cb) = 0

The old fnv1a_32 implementation will not pass this case.
#include <stdio.h>
#include <stdint.h>

static uint32_t FNV_32_INIT =<PHONE_NUMBER>UL;
static uint32_t FNV_32_PRIME = 16777619UL;

uint32_t
hash_fnv1a_32(const char *key, size_t key_length)
{
    uint32_t hash = FNV_32_INIT;
    size_t x;

    for (x= 0; x < key_length; x++) {
      uint32_t val = (uint32_t)key[x];
      hash ^= val;
      hash *= FNV_32_PRIME;
    }

    return hash;
}

uint32_t
hash_fnv1a_32a(const char *key, size_t key_length)
{
    uint32_t hash = FNV_32_INIT;
    size_t x;
    const uint8_t* unsigned_key = (uint8_t*)key;

    for (x= 0; x < key_length; x++) {
      uint32_t val = (uint32_t)unsigned_key[x];
      hash ^= val;
      hash *= FNV_32_PRIME;
    }

    return hash;
}

int main(int argc, const char *argv[])
{
    const char key[] = "\xcc\x24\x31\xc4";
    uint32_t v1 = hash_fnv1a_32(key, 4U);
    uint32_t v2 = hash_fnv1a_32a(key, 4U);
    printf("old: %u, new: %u\n", v1, v2);
    return 0;
}

I guess the bug is originally introduced in libmemcached.

Unittest support is added in #315 .  Please review that first. I'll add unittest for this PR after #315 is merged to make sure the new added implementation is bugfree (hopefully :smile: ).

@manjuraj  @idning please review.

we don't need a correct algorithm here, we just need a algorithm which can distribute keys evenly.
adding 4 more hash function may make user more confuse.

evenly? Technically no. SMHasher is a test suite designed to test the distribution, collision, and performance properties of non-cryptographic hash functions. fnv32 implementation in twemproxy won't pass test cases in that.
You can checkout the latest code of SMHasher on svn and apply the patch based on revision 152 to reproduce.

In my opinion we need any algorithm we use, which is externally defined, to return the correct results. If others correctly implement them, our results must match. I'll take consistency over "even" any day. If our results, given the same inputs, are different we should not call the algorithm by the name of one we don't match.
Cheers,
Bill

On Mar 14, 2015, at 07:08, ning<EMAIL_ADDRESS>wrote:
we don't need a correct algorithm here, we just need a algorithm which can distribute keys evenly.
adding 4 more hash function may make user more confuse.
—
Reply to this email directly or view it on GitHub.

@mckelvin @therealbill sorry for delay such a long time.
in our production environment, fnv1a_64 is even enough, but recently I found that if we want to map a key to a server with python or other language, the buggy algorithms is a problem, so I agree that we need a correct algorithm.
I will merge this ASAP, thanks guys

@idning :smiley:

It is good to correct the hash function, but I wonder if we exactly need more hash functions.
Is it possible to revise fnv1* functions in place instead of creating new functions? are there any necessary to be compatible with libmemcachd?

@Marcus366
If just revise hash functions.
There is a problem, if some one upgrade twemproxy, key hashing will be broken.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing the stale PR.


Add rate limiting for tenants

It would be nice to implement rate limiting mechanism in Capsule proxy to stop a client (tenant) from making too many requests during a window of time. Many techniques are available in HTTP proxies, even more sophisticated. For our purpose, a simple rate limit for tenants should be enough, just as a matter of keeping upstream kubernetes APIS server usage fair.

Actually, Kubernetes offers a flow control set of APIs starting from v1.20.
I wouldn't reinvent the wheel, what we have to check if during the impersonate these constraints are honored, or not.

Ok, just tested and verified that impersonation applies the FlowSchema rules and related PriorityLevelConfiguration.
I think we could avoid the implementation and, rather, document how to use this Kubernetes feature: WDTY @bsctl ?

I think we could avoid the implementation and, rather, document how to use this Kubernetes feature: WDTY @bsctl ?

Totally agree. Thanks!


Refine InjectionPoint Idea

A InjectionPoint (IP) is a abstract access to inject(Object).
Idea 1
Use IPs in constructor binds. The injection strategy could be asked to compute InjectionPoint[] pointsOf(Class<?>). This is passed to a constructor Supplier who will later invoke them after the new instance has been created. In order to know what instance should be passed there could be a second method Instance<T> getInstance(); in the InjectionPoint<T> interface. This way the strategy can analyse in various ways and tell the general code what each point wants to get.
Typical IPs

Fields
Methods (setters in most cases, but also init-methods and such)

Macros and other customisations offer all that is needed to build this on top of the core - not a concept worth having in the library. Maybe not even a good idea.


Log exceptions in dumped crash logs

So the user won't need to screenshot the crash screen.

The thing is, sometimes the exception does appear in the log file. When I first looked at this a while ago, I couldn't even reproduce the missing exception from the logs, even with a release build compile.

The thing is, sometimes the exception does appear in the log file. When I first looked at this a while ago, I couldn't even reproduce the missing exception from the logs, even with a release build compile.

It's just a few bytes more even if it's duplicate, I think we can afford that.

The thing is, sometimes the exception does appear in the log file. When I first looked at this a while ago, I couldn't even reproduce the missing exception from the logs, even with a release build compile.

It's just a few bytes more even if it's duplicate, I think we can afford that.

Oh, absolutely, I'd love to not have to ask people to give me the screenshot, only for them to have already restarted the app (or never respond in the first place).
Looking forward to this.
Would it be too much to put a "Latest Exception" header before it or something like that? To differentiate it from later ones

The thing is, sometimes the exception does appear in the log file. When I first looked at this a while ago, I couldn't even reproduce the missing exception from the logs, even with a release build compile.

It's just a few bytes more even if it's duplicate, I think we can afford that.

Oh, absolutely, I'd love to not have to ask people to give me the screenshot, only for them to have already restarted the app (or never respond in the first place). Looking forward to this.
Would it be too much to put a "Latest Exception" header before it or something like that? To differentiate it from later ones

The following log will have something like
--------- beginning of main


Better behaviour if lego provider fails to be created

At the minute the default for certificate-providers is lego selfsigned. If the lego supplier fails to start up[^1], a warning will be logged but everything will carry on as normal and eventually all certs will be replaced with self-signed ones. The only indication that anything is wrong in the logs is a single warning on startup.
This is the desired behaviour if you aren't using lego (e.g. when using selfsigned, or when using tailscale): you simply don't configure lego and it fails through to self-signed. It's very much not desirable if you do intend to use lego and it fails though.
Some options:
1. Explicitly check on startup if the acme-email setting is valid, and if it is bail out if the lego supplier fails.
I don't like this as I'd prefer Centauri to carry on working as much as it can for as long as it can.
2. Try to create the supplier every time it's needed
This seems like it will end up spamming the ACME service if the problem is with the config, and I'm not confident we can actually tell from the errors we get through lego whether the error is caused by us or not.
It would also make a complete mess of the architecture as the cert manager would need to be able to create suppliers, but that's probably solvable.
3. Change the default setting to just lego and error out if the specified providers don't exist
See option one for arguments against bailing out
4. Add more logging when checking a cert if a preferred supplier isn't available
Probably a good idea, but still hides the problem away in the logs. Also a little spammy if you're not intending on using lego, but left everything as defaults.
5. Do nothing, wait for the healthcheck endpoint (#23) to exist and let that sort it out
Healthcheck endpoint would at least expose the problem in a nicer way than a single warning in the logs, but still means there's some OOB thing you have to look at to figure out everything is going wrong. (But I think that's always going to be the case when I want the behaviour to be "serve as much as possible at all costs"...)
[^1]: which I previously assumed would only happen due to config issues, but can actually happen if there's no network connectivity when Centauri starts (or the ACME provider is down)

Number 2 seems like the best approach to me - assuming that is "once per renewal cycle", not once per certificate then it would at least only try every 12 hours so not too spammy


Editor save html takes longer after upgrade to 1.6.1

VSCode Version: 1.6.1
OS Version: Win 7 64bit

Steps to Reproduce:

Upgrade from 1.6 to 1.6.1
Enabled "editor.formatOnSave": true,
When I try to save index.html with 2164 lines. It save after 2 minute or so.
with this configuration code  --disable-extensions .

Sometimes when I try to do something it freezes.

Can you please upload the file for which it takes you a long time to save?

Sorry I am out of office. I will post it next Monday.

Here you go,
Here is link to file, I was not able to upload zip.
https://drive.google.com/file/d/0Bw_W5Yz5MtywTnZoVWdhTzZ0YTQ/view?usp=sharing

@rayzik What extensions do you have installed?

Also, note that format on save will timeout after 750ms

@jrieken
All extensions are latest except HookyQR.beautify
extensions:
dbaeumer.vscode-eslint
HookyQR.beautify 0.4.0
joelday.docthis
seanmcbreen.Spell
Shan.code-settings-sync
TwentyChung.jsx

Do you have beautify configured to format html and format on save?

Closing until steps that allow to reproduce this are supplied


Bring a.n object access into builtins

Currently we create this function on the fly in the elaborator, which is ugly though.

Sorry, because we cannot pass the key around for now, it's impossible to implement this in builtins.


Getting undefined: genny.GoBin when installing from Docker

When installing from Docker I get the following error:
Step 2/19 : RUN go get github.com/gobuffalo/pop/...
 ---> Running in 2fd0d7765966
# github.com/gobuffalo/gogen/gomods
src/github.com/gobuffalo/gogen/gomods/init.go:61:24: undefined: genny.GoBin
src/github.com/gobuffalo/gogen/gomods/tidy.go:17:24: undefined: genny.GoBin

This is using the golang:1.13 image (also fails with 1.11 and 1.12)
FROM golang:1.13 as soda-builder

RUN go get github.com/gobuffalo/pop/...
RUN go install github.com/gobuffalo/pop/soda
....

Fixed, please try again. :)


Throw error if the type is specified wrong

instead of just defaulting back to md5, throw an error if the type is specified wrong.

Changes some of how #4 works, so that #4 determination is only done when a hash type is not also passed.

Fixed for 0.2.0


"Ceanu Mare", "Andici", "Boian", "Bolduț", "Ciurgău", "Dosu Napului", "Fânațe", "Hodăi-Boian", "Iacobeni", "Morțești", "Stârcu", "Strucut", "Valea lui Cati" are listed in the drop-down

Description:
When user writes "Ceanu Mare", "Andici", "Boian", "Bolduț", "Ciurgău", "Dosu Napului", "Fânațe", "Hodăi-Boian", "Iacobeni", "Morțești", "Stârcu", "Strucut" and "Valea lui Cati" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Ceanu Mare"
Expected results
The location appears in the drop-down menu as "Sat Ceanu Mare, CLUJ (Ceanu Mare)"

Step 3
Write in the search bar "Andici"
Expected results
The location appears in the drop-down menu as "Sat Andici, CLUJ (Ceanu Mare)"

Step 4
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Boian"
Expected results
The location appears in the drop-down menu as "Sat Boian, CLUJ (Ceanu Mare)"

Step 6
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Bolduț"
Expected results
The location appears in the drop-down menu as "Sat Bolduț, CLUJ (Ceanu Mare)"

Step 8
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 9
Write in the search bar "Ciurgău"
Expected results
The location appears in the drop-down menu as "Sat Ciurgău, CLUJ (Ceanu Mare)"

Step 10
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 11
Write in the search bar "Dosu Napului"
Expected results
The location appears in the drop-down menu as "Sat Dosu Napului, CLUJ (Ceanu Mare)"

Step 12
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 13
Write in the search bar "Fânațe"
Expected results
The location appears in the drop-down menu as "Sat Fânațe, CLUJ (Ceanu Mare)"

Step 14
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 15
Write in the search bar "Hodăi-Boian"
Expected results
The location appears in the drop-down menu as "Sat Hodăi-Boian, CLUJ (Ceanu Mare)"

Step 16
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 17
Write in the search bar "Iacobeni"
Expected results
The location appears in the drop-down menu as "Sat Iacobeni, CLUJ (Ceanu Mare)"

Step 18
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 19
Write in the search bar "Morțești"
Expected results
The location appears in the drop-down menu as "Sat Morțești, CLUJ (Ceanu Mare)"

Step 20
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 21
Write in the search bar "Stârcu"
Expected results
The location appears in the drop-down menu as "Sat Stârcu, CLUJ (Ceanu Mare)"

Step 22
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 23
Write in the search bar "Strucut"
Expected results
The location appears in the drop-down menu as "Sat Strucut, CLUJ (Ceanu Mare)"

Step 24
Press "x" button.
Expected results
The location was deleted from the search bar

Step 25
Write in the search bar "Valea lui Cati"
Expected results
The location appears in the drop-down menu as "Sat Valea lui Cati, CLUJ (Ceanu Mare)"


Add Reverse the Array Question solution

Description
Problem - Reverse the array
Examples:-
Input : 1, 2, 3, 4, 5
Output :5, 4, 3, 2, 1
Input : 10, 20, 30, 40
Output : 40, 30, 20, 10
Time Complexity - O(n)
Space Comlexity - O(1)

Please assign me this issue.

@Abhay3819 pls assign me. Its a good start problem, I can contribute to it...
Thanks

Please assign it to me as my first issue

Please assign it to me to solve in c++

@Kumar-laxmi  sir please assign me this issue . i can solve it using C,C++,JAVA.

I would suggest you to raise issue pertaining to standard algorithms rather than discrete operations


bug: Cannot change planetscale to postgres.js

Provide environment information
System:
OS: Linux 6.2 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor
Memory: 17.46 GB / 31.24 GB
Container: Yes
Shell: 5.8.1 - /usr/bin/zsh
Binaries:
Node: 20.9.0 - ~/.nvm/versions/node/v20.9.0/bin/node
npm: 10.1.0 - ~/.nvm/versions/node/v20.9.0/bin/npm
Describe the bug
After changing planetscale to postgres.js in drizzle error occurs in nextjs.
Error:
ModuleBuildError: Module build failed: UnhandledSchemeError: Reading from "cloudflare:sockets" is not handled by plugins (Unhandled scheme).
Webpack supports "data:" and "file:" URIs by default.
You may need an additional plugin to handle "cloudflare:" URIs.

Link to reproduction
https://github.com/maxifom/test-qqq/commit/04c7cb783ba47a41d6558df07484b7e7f8599511
To reproduce
pnpm i && pnpm --filter nextjs dev
go to http://localhost:3000
See error:
ModuleBuildError: Module build failed: UnhandledSchemeError: Reading from "cloudflare:sockets" is not handled by plugins (Unhandled scheme).
Webpack supports "data:" and "file:" URIs by default.
You may need an additional plugin to handle "cloudflare:" URIs.

Additional information
No response

fixed by https://github.com/t3-oss/create-t3-turbo/issues/634#issuecomment-1730240214
I think it should be really nice to include it in the README to avoid confusion. Not everybody in the world uses edge runtimes.

Sorry to reopen this.
By commenting runtime = "edge" everywhere, and by using the drizzle postgres.js driver for local development with a local pg database, it kinda works (as in it can read and write from the db) but for every tRPC query an error like this is thrown:
@acme/nextjs:dev:  << query  #1 post.all  {
@acme/nextjs:dev:   input: undefined,
@acme/nextjs:dev:   result: TRPCClientError: fetch failed
@acme/nextjs:dev:       at TRPCClientError.from (webpack-internal:///(ssr)/../../node_modules/@trpc/client/dist/TRPCClientError-0de4d231.mjs:41:16)
@acme/nextjs:dev:       at eval (webpack-internal:///(ssr)/../../node_modules/@trpc/client/dist/httpBatchLink-204206a5.mjs:207:101)
@acme/nextjs:dev:       at runNextTicks (node:internal/process/task_queues:60:5)
@acme/nextjs:dev:       at process.processTimers (node:internal/timers:504:9) {
@acme/nextjs:dev:     meta: undefined,
@acme/nextjs:dev:     shape: undefined,
@acme/nextjs:dev:     data: undefined,
@acme/nextjs:dev:     [cause]: TypeError: fetch failed
@acme/nextjs:dev:         at Object.fetch (node:internal/deps/undici/undici:14062:11)
@acme/nextjs:dev:         at runNextTicks (node:internal/process/task_queues:60:5)
@acme/nextjs:dev:         at process.processTimers (node:internal/timers:504:9) {
@acme/nextjs:dev:       cause: [InvalidArgumentError]
@acme/nextjs:dev:     }
@acme/nextjs:dev:   },
@acme/nextjs:dev:   elapsedMs: 9
@acme/nextjs:dev: }
@acme/nextjs:dev:  ⨯<EMAIL_ADDRESS>(37:15) @ TRPCClientError.from
@acme/nextjs:dev:  ⨯ Internal error: TRPCClientError: fetch failed
@acme/nextjs:dev:     at TRPCClientError.from (../../node_modules/@trpc/client/dist/TRPCClientError-0de4d231.mjs:41:16)
@acme/nextjs:dev:     at eval (../../node_modules/@trpc/client/dist/httpBatchLink-204206a5.mjs:207:101)
@acme/nextjs:dev:     at runNextTicks (node:internal/process/task_queues:60:5)
@acme/nextjs:dev:     at process.processTimers (node:internal/timers:504:9)
@acme/nextjs:dev: Cause: TypeError: fetch failed
@acme/nextjs:dev:     at Object.fetch (node:internal/deps/undici/undici:14062:11)
@acme/nextjs:dev:     at runNextTicks (node:internal/process/task_queues:60:5)
@acme/nextjs:dev:     at process.processTimers (node:internal/timers:504:9) {
@acme/nextjs:dev:   cause: InvalidArgumentError: invalid connection header
@acme/nextjs:dev:       at processHeader (node:internal/deps/undici/undici:7595:15)
@acme/nextjs:dev:       at new Request (node:internal/deps/undici/undici:7478:13)
@acme/nextjs:dev:       at [dispatch] (node:internal/deps/undici/undici:8645:25)
@acme/nextjs:dev:       at Intercept (node:internal/deps/undici/undici:8392:20)
@acme/nextjs:dev:       at [Intercepted Dispatch] (node:internal/deps/undici/undici:7764:16)
@acme/nextjs:dev:       at Client.dispatch (node:internal/deps/undici/undici:7780:44)
@acme/nextjs:dev:       at [dispatch] (node:internal/deps/undici/undici:9942:32)
@acme/nextjs:dev:       at [Intercepted Dispatch] (node:internal/deps/undici/undici:7757:33)
@acme/nextjs:dev:       at Pool.dispatch (node:internal/deps/undici/undici:7780:44)
@acme/nextjs:dev:       at [dispatch] (node:internal/deps/undici/undici:10282:27)
@acme/nextjs:dev:       at Agent.Intercept (node:internal/deps/undici/undici:8392:20)
@acme/nextjs:dev:       at Agent.dispatch (node:internal/deps/undici/undici:7780:44)
@acme/nextjs:dev:       at node:internal/deps/undici/undici:13956:83
@acme/nextjs:dev:       at new Promise (<anonymous>)
@acme/nextjs:dev:       at dispatch (node:internal/deps/undici/undici:13956:16)
@acme/nextjs:dev:       at httpNetworkFetch (node:internal/deps/undici/undici:13864:65)
@acme/nextjs:dev:       at httpNetworkOrCacheFetch (node:internal/deps/undici/undici:13766:39)
@acme/nextjs:dev:       at httpFetch (node:internal/deps/undici/undici:13618:43)
@acme/nextjs:dev:       at schemeFetch (node:internal/deps/undici/undici:13546:24)
@acme/nextjs:dev:       at node:internal/deps/undici/undici:13422:26
@acme/nextjs:dev:       at mainFetch (node:internal/deps/undici/undici:13439:11)
@acme/nextjs:dev:       at fetching (node:internal/deps/undici/undici:13396:7)
@acme/nextjs:dev:       at fetch2 (node:internal/deps/undici/undici:13274:20)
@acme/nextjs:dev:       at Object.fetch (node:internal/deps/undici/undici:14060:18)
@acme/nextjs:dev:       at fetch (node:internal/process/pre_execution:237:25)
@acme/nextjs:dev:       at R (/Users/ldx/Repositories/t3-turbo-appdir/node_modules/next/dist/compiled/next-server/app-page.runtime.dev.js:35:340205)
@acme/nextjs:dev:       at doOriginalFetch (webpack-internal:///(rsc)/../../node_modules/next/dist/server/lib/patch-fetch.js:376:24)
@acme/nextjs:dev:       at eval (webpack-internal:///(rsc)/../../node_modules/next/dist/server/lib/patch-fetch.js:504:20)
@acme/nextjs:dev:       at eval (webpack-internal:///(rsc)/../../node_modules/next/dist/server/lib/trace/tracer.js:125:36)
@acme/nextjs:dev:       at NoopContextManager.with (webpack-internal:///(rsc)/../../node_modules/next/dist/compiled/@opentelemetry/api/index.js:360:30)
@acme/nextjs:dev:       at ContextAPI.with (webpack-internal:///(rsc)/../../node_modules/next/dist/compiled/@opentelemetry/api/index.js:30:58)
@acme/nextjs:dev:       at NoopTracer.startActiveSpan (webpack-internal:///(rsc)/../../node_modules/next/dist/compiled/@opentelemetry/api/index.js:953:34)
@acme/nextjs:dev:       at ProxyTracer.startActiveSpan (webpack-internal:///(rsc)/../../node_modules/next/dist/compiled/@opentelemetry/api/index.js:993:36)
@acme/nextjs:dev:       at eval (webpack-internal:///(rsc)/../../node_modules/next/dist/server/lib/trace/tracer.js:114:103)
@acme/nextjs:dev:       at NoopContextManager.with (webpack-internal:///(rsc)/../../node_modules/next/dist/compiled/@opentelemetry/api/index.js:360:30)
@acme/nextjs:dev:       at ContextAPI.with (webpack-internal:///(rsc)/../../node_modules/next/dist/compiled/@opentelemetry/api/index.js:30:58)
@acme/nextjs:dev:       at NextTracerImpl.trace (webpack-internal:///(rsc)/../../node_modules/next/dist/server/lib/trace/tracer.js:114:28)
@acme/nextjs:dev:       at globalThis.fetch (webpack-internal:///(rsc)/../../node_modules/next/dist/server/lib/patch-fetch.js:194:47)
@acme/nextjs:dev:       at fetchHTTPResponse (webpack-internal:///(ssr)/../../node_modules/@trpc/client/dist/httpUtils-f58ceda1.mjs:108:32)
@acme/nextjs:dev:       at runNextTicks (node:internal/process/task_queues:60:5)
@acme/nextjs:dev:       at process.processTimers (node:internal/timers:504:9) {
@acme/nextjs:dev:     code: 'UND_ERR_INVALID_ARG'
@acme/nextjs:dev:   }
@acme/nextjs:dev: }

By removing the headers function from the unstable_httpBatchStreamLink in the TRPCReactProvider (apps/nextjs/src/app/providers.tsx) the error disappears, but we do lose the session context in some cases.
I tried with httpBatchLink but I get the same exact error.
I general, what's the suggested solution for local development?
I know we might be limited by the state of current technologies and how they interplay with each other, but developing locally against a remote database is really not the best DX.
And at the same time, developing locally on a different runtime from the one used in production can lead to disasters.

@juliusmarminge bumping the comment made by @ludalex above, since this is closed and you have probably not seen it.


Best way to track moving locations?

I'm looking to use your library to track things that are moving (ie, cars/people/etc) and to find other things that are nearby. From what I can gather, your library seems to be primarily designed to handle stationary things with a single moving search location.
If my understanding is correct, how would you advise using your library to track moving things?
I think I will need to keep track of each thing's current location hash so that I can remove the old one and create a new one when the thing moves.
Thanks for any advice.
Glenn.

I feel like there are a few ways this could be done, however this isn't really an issue, so I'd be inclined to close it. A question like this would probably be better for stack overflow.
If you know what you're tracking you could just attach a onSnapshot listener to an individual doc and use that to change to query what's near it (I'd use a get for that as you won't need to worry about killing a subscription considering you'll likely make a lot of requests for what's near by).
Also consider applying a threshold for how far a user needs to move before you requery.


Slot locking can sometimes fail/crash

Not 100% sure on how to reproduce the crash, but I got a log and was able to reproduce the underlying ArrayIndexOutOfBoundsException:

[Server thread/ERROR] [MinecraftServer]: Encountered an unexpected exception
net.minecraft.class_148: Ticking block entity
at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:875) ~[intermediary-minecraft-1.16.5-client.jar:?]
at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:811) ~[intermediary-minecraft-1.16.5-client.jar:?]
at net.minecraft.class_1132.method_3748(class_1132.java:91) ~[intermediary-minecraft-1.16.5-client.jar:?]
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:670) ~[intermediary-minecraft-1.16.5-client.jar:?]
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) ~[intermediary-minecraft-1.16.5-client.jar:?]
at java.lang.Thread.run(Thread.java:831) [?:?]
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 38 out of bounds for length 0
at tfar.dankstorage.inventory.DankInventory.isLocked(DankInventory.java:95) ~[dankstorage-1.10a-1.16.5.jar:?]
at tfar.dankstorage.inventory.DankInventory.method_5434(DankInventory.java:55) ~[dankstorage-1.10a-1.16.5.jar:?]
at tfar.dankstorage.blockentity.DockBlockEntity.method_5434(DockBlockEntity.java:163) ~[dankstorage-1.10a-1.16.5.jar:?]
at net.minecraft.class_2614.method_11261(class_2614.java:223) ~[intermediary-minecraft-1.16.5-client.jar:?]
at net.minecraft.class_2614.method_17768(class_2614.java:206) ~[intermediary-minecraft-1.16.5-client.jar:?]
at java.util.stream.MatchOps$2MatchSink.accept(MatchOps.java:119) ~[?:?]
at java.util.stream.Streams$RangeIntSpliterator.tryAdvance(Streams.java:82) ~[?:?]
at java.util.stream.IntPipeline.forEachWithCancel(IntPipeline.java:163) ~[?:?]
at java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:502) ~[?:?]
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:488) ~[?:?]
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?]
at java.util.stream.MatchOps$MatchOp.evaluateSequential(MatchOps.java:230) ~[?:?]
at java.util.stream.MatchOps$MatchOp.evaluateSequential(MatchOps.java:196) ~[?:?]
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
at java.util.stream.IntPipeline.anyMatch(IntPipeline.java:537) ~[?:?]
at net.minecraft.class_2614.method_11241(class_2614.java:206) ~[intermediary-minecraft-1.16.5-client.jar:?]
at net.minecraft.class_2614.method_11249(class_2614.java:109) ~[intermediary-minecraft-1.16.5-client.jar:?]
at net.minecraft.class_2614.method_11243(class_2614.java:125) ~[intermediary-minecraft-1.16.5-client.jar:?]
at net.minecraft.class_2614.method_16896(class_2614.java:109) ~[intermediary-minecraft-1.16.5-client.jar:?]
at net.minecraft.class_1937.method_18471(class_1937.java:510) ~[intermediary-minecraft-1.16.5-client.jar:?]
at net.minecraft.class_3218.method_18765(class_3218.java:429) ~[intermediary-minecraft-1.16.5-client.jar:?]
at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:871) ~[intermediary-minecraft-1.16.5-client.jar:?]

To reproduce, put a fresh dank in a dock and try to lock any slot.
This happens even when an item is put into the slot right before trying to lock it and when retrieving the dank from the dock and putting it back in.
Opening the dank in your hand once seems to fix the issue.
edit: The crash happens when there's a hopper below a dock and you put in a fresh dank, open it and put an item in it.

fixed in 2.0


Improve support for Svelte's "bind:group"

Description:
When using Svelte's "bind:group" for multiple checkboxes sharing the same field along with client-side validation (schema being an array of enums), we currently get some odd behavior.
It works partially, in that the group binding array values are correctly updated in the "$form" store. However, upon interacting with a checkbox in the group, "$errors.MY_FIELD_NAME" will contain an object with numbered keys and "undefined" as the values (per-touched checkbox). Despite this object existing in "$errors", form submission succeeds on both the client-side and server-side.
An example of this behavior below:

<SuperDebug data={$form} />

<form method="POST" use:enhance>
	<CheckboxGroup {options} field="options" superForm={mySuperForm} />
	<button>Submit</button>
</form>

		{#if $errors}
			{#each Object.entries($errors) as error, idx}

					Option {Number(error[0]) + 1}: {error[1]}

			{/each}
		{/if}

	{#each options as { value: checkboxValue, label }}

			<input
				type="checkbox"
				value={checkboxValue}
				bind:group={$value}
				{...$constraints}
				{...$$restProps}
			/>
			{label}

	{/each}

//+page.server.ts

import { schema } from './schema';
import { fail } from '@sveltejs/kit';
import { superValidate } from 'sveltekit-superforms/server';

export const load = async () => {
    const form = await superValidate(schema);
    return { form };
};

export const actions = {
    default: async ({ request }) => {
        const form = await superValidate(request, schema);
        console.log(form);

        if (!form.valid) {
            return fail(400, { form });
        }

        return { form };
    },
};

//schema.ts

import { z } from 'zod';

export const schema = z.object({
    options: z.enum(['option_1', 'option_2', 'option_3']).optional().array()
});

Using this example, if you were to check all three checkboxes, the top-level "$errors" will be this object:
{ options: {0: undefined, 1: undefined, 2: undefined}}

Preferred functionality:
Client-side validation would ideally automatically remove the property for a given field from the "$errors" object if validations pass (i.e. In this example, the top-level $errors object would have no properties)

This is a hidden "feature" used to track what fields have been touched, so errors can be displayed directly during client-side validation, instead of waiting until on:blur. You should make an extra falsy check for each field.

This is a hidden "feature" used to track what fields have been touched, so errors can be displayed directly during client-side validation, instead of waiting until on:blur. You should make an extra falsy check for each field.

Ahh that makes sense. Thank you for clearing that up, and thank your work on this awesome library!
Closing this issue.


[2765.2.4] 5.10.37 kernel oops in __domain_mapping+0xa7/0x3a0

Description
The 5.10.37-flatcar kernel (2765.2.4 stable release) panics on boot each time on a Dell server with a Intel Xeon E5-2640 v3 processor.

[    5.316760] BUG: kernel NULL pointer dereference, address:<PHONE_NUMBER>000008
[    5.317108] #PF: supervisor read access in kernel mode
[    5.317108] #PF: error_code(0x0000) - not-present page
[    5.317108] PGD 0 P4D 0
[    5.317108] Oops: 0000 [#1] SMP PTI
[    5.317108] CPU: 8 PID: 1 Comm: swapper/0 Not tainted 5.10.37-flatcar #1
[    5.317108] Hardware name:  /086D43, BIOS 2.7.1 001/22/2018
[    5.317108] RIP: 0010:__domain_mapping+0xa7/0x3a0
[    5.317108] Code: 0a 00 00 02 0f 85 17 02 00 00 4c 89 d3 45 31 e4 31 ed 45 31 c9 48 c1 e3 0c 4c 09 fb 4d 85 c0 0f 84 26 01 00 00 4d 85 e4 75 5d <41> 8b 55 08 41 8b 45 0c 49 8b 5d 00 89 d1 48 89 c6 81 e1 ff 0f 00
[    5.317108] RSP: 0000:ffffa3bf0004fbd0 EFLAGS: 00010246
[    5.317108] RAX:<PHONE_NUMBER>000000 RBX: 000000007ae07003 RCX:<PHONE_NUMBER>00002d
[    5.317108] RDX:<PHONE_NUMBER>000000 RSI:<PHONE_NUMBER>07ae07 RDI: ffff90c50a11c200
[    5.317108] RBP:<PHONE_NUMBER>000000 R08:<PHONE_NUMBER>000001 R09:<PHONE_NUMBER>000000
[    5.317108] R10:<PHONE_NUMBER>07ae07 R11: ffff90c50a11c200 R12:<PHONE_NUMBER>000000
[    5.317108] R13:<PHONE_NUMBER>000000 R14:<PHONE_NUMBER>07ae07 R15:<PHONE_NUMBER>000003
[    5.317108] FS:<PHONE_NUMBER>000000(0000) GS:ffff90d43fc00000(0000) knlGS:0000000000000000
[    5.317108] CS:  0010 DS: 0000 ES: 0000 CR0:<PHONE_NUMBER>050033
[    5.317108] CR2:<PHONE_NUMBER>000008 CR3: 00000005e960a001 CR4:<PHONE_NUMBER>1706e0
[    5.317108] Call Trace:
[    5.317108]  ? set_next_entity+0xa3/0x1e0
[    5.317108]  domain_mapping+0x1b/0xa0
[    5.317108]  __iommu_map+0xfd/0x1f0
[    5.317108]  _iommu_map+0x15/0x40
[    5.317108]  iommu_create_device_direct_mappings.isra.0+0x179/0x1e0
[    5.317108]  bus_iommu_probe+0x165/0x280
[    5.317108]  bus_set_iommu+0x88/0xe0
[    5.317108]  intel_iommu_init+0xef0/0x10e8
[    5.317108]  ? mntput_no_expire+0x47/0x240
[    5.317108]  ? e820__memblock_setup+0x7d/0x7d
[    5.317108]  pci_iommu_init+0x16/0x3f
[    5.317108]  do_one_initcall+0x44/0x1d0
[    5.317108]  kernel_init_freeable+0x1c9/0x20e
[    5.317108]  ? rest_init+0xb4/0xb4
[    5.317108]  kernel_init+0xa/0x10c
[    5.317108]  ret_from_fork+0x22/0x30
[    5.317108] Modules linked in:
[    5.317108] CR2:<PHONE_NUMBER>000008
[    5.317108] ---[ end trace 7bb64b28ae710c73 ]---
[    5.317108] RIP: 0010:__domain_mapping+0xa7/0x3a0
[    5.317108] Code: 0a 00 00 02 0f 85 17 02 00 00 4c 89 d3 45 31 e4 31 ed 45 31 c9 48 c1 e3 0c 4c 09 fb 4d 85 c0 0f 84 26 01 00 00 4d 85 e4 75 5d <41> 8b 55 08 41 8b 45 0c 49 8b 5d 00 89 d1 48 89 c6 81 e1 ff 0f 00
[    5.317108] RSP: 0000:ffffa3bf0004fbd0 EFLAGS: 00010246
[    5.317108] RAX:<PHONE_NUMBER>000000 RBX: 000000007ae07003 RCX:<PHONE_NUMBER>00002d
[    5.317108] RDX:<PHONE_NUMBER>000000 RSI:<PHONE_NUMBER>07ae07 RDI: ffff90c50a11c200
[    5.317108] RBP:<PHONE_NUMBER>000000 R08:<PHONE_NUMBER>000001 R09:<PHONE_NUMBER>000000
[    5.317108] R10:<PHONE_NUMBER>07ae07 R11: ffff90c50a11c200 R12:<PHONE_NUMBER>000000
[    5.317108] R13:<PHONE_NUMBER>000000 R14:<PHONE_NUMBER>07ae07 R15:<PHONE_NUMBER>000003
[    5.317108] FS:<PHONE_NUMBER>000000(0000) GS:ffff90d43fc00000(0000) knlGS:0000000000000000
[    5.317108] CS:  0010 DS: 0000 ES: 0000 CR0:<PHONE_NUMBER>050033
[    5.317108] CR2:<PHONE_NUMBER>000008 CR3: 00000005e960a001 CR4:<PHONE_NUMBER>1706e0
[    5.317108] Kernel panic - not syncing: Fatal exception

After the panic, the system boots back up on the previous 2765.2.3 stable release and tries again.
It appears others are seeing the same issue with 5.10.37, and looks like the patch was not backported correctly:
<EMAIL_ADDRESS>Impact
2765.2.4 stable release is not usable on this hardware.
Environment and steps to reproduce

Set-up: Flatcar Linux stable on a Dell Haswell server
Task: automatic update to 2765.2.4 stable release
Action(s):
a. update-engine pulls 2765.2.4 stable release
b. reboot
Error: 5.10.37-flatcar kernel panics on boot

Expected behavior
Boot succeeds.
Additional information

Thanks for reporting, the rollout of the 2765.2.4 Stable update got stopped in the update server and it announces 2765.2.3 as latest version for the mean time. A new kernel bux fix release already got published and we will include the fix soon in a follow-up release.

The Stable 2765.2.5 update will be published now

2765.2.5 works great.  Thank you!


Handle changes to Field validate/warn props

This will ensure that changes to these functions are reflected in form
validation. Achieved by re-registing the Field with reduxForm when new
validate or warn props are recieved.
See issue: https://github.com/erikras/redux-form/issues/3012

Codecov Report

Merging #3094 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3094   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          68      68
  Lines        1449    1451    +2
======================================
+ Hits         1449    1451    +2

Impacted Files
Coverage Δ

src/createField.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994e46f...ec3667f. Read the comment docs.

Published in v7.0.0.


Use the Default Format set by the ErrorLogHandler

Issue
Currently, the defaultFormatter, set in Writer.php adds a \n at the end of each log, while the ErrorLogHandler removes that \n in its own getDefaultFormatter().
ErrorLogHandler.php:60
    /**
     * {@inheritDoc}
     */
    public function getDefaultFormatter()
    {
        return new LineFormatter('[%datetime%] %channel%.%level_name%: %message% %context% %extra%');
    }

Proposal
My proposal is to remove the hard setting of a formatter, however, we could also set a new format that simply does not include the \n, either way will work for me.
Current output looks like this:
[2017-05-11 14:17:09] local.INFO: Here is a log message [] []

Context
I am sending to error_log which end up in Loggly (12 Factor Application) and the incorrect format causes every log to have an empty log after it.

@taylorotwell I'm unfamiliar with how this works, will this get merged into 5.2, 5.3, etc, or should I make PRs for each version?
Thanks!


package_for_correction.py - move to SCT?

I needed to package data for manual correction for the INSPIRED project. I did not want to duplicate scripts; thus, I used the package_for_correction.py from this CanProCo repo. To make the script compatible with INSPIRED's filenames (e.g., sub-torontoDCM001_acq-cspineAxial_T2w.nii.gz), I had to make get_subject and get_ses functions more robust. Namely, I used regular expressions instead of the .split method in https://github.com/ivadomed/canproco/commit/2f06bf47061f4267b07fd613ceb192010ea650bf.
Also, for the INSPIRED project, I'm currently using the _label-SC_mask.nii.gz suffix instead of _seg.nii.gz (as discussed here). For this reason, I added an optional argument to the package_for_correction.py script in https://github.com/ivadomed/canproco/commit/5c5e2ac5b87feccde2732187ed492a2af71d2b18.
Since the package_for_correction.py script is more universal and can be used for any project, maybe, we could implement that into the SCT?
For the context, package_for_correction.py was first introduced for spine-generic.
Note: I realize that this PR is not relevant to CanProCo itself, but I wanted to discuss this somewhere. After talking about it, the PR can be closed without merging.

Closing since manual correction scripts will be integrated under separate repo


hasp dark theme - use black (no gradient) for the background

It does not so look really cool to have gradient and border in the dark screen background. Use just plain dark, but keep background gradient for widgets.

What looks good is up to each own personal taste. This will possibly break existing layouts...
I think it is better to create a different theme or adjust it on the local devices.

The gradient as dark background is really nonsense in my eyes, but I can create a new theme, too. Will you accept it? Name may be "Hasp Black" with id = 6 ?

At second thought, I think the border can be safely removed in the existing theme.
Just for the background color, it's easy to set these in the pages.jsonl too without the need of a new theme.

Just throwing my 2c in here but I also disliked the gradient background, and I changed it to a solid black.  My LCD is 16-bit (I think most of these small screens are?) which caused the gradient to look blocky and not smooth.  But even if it were smooth I'd prefer the solid background.

How did you change the background to solid black? I'd like to do same, but curious if I have to apply to each page (i.e. create a black object)?

Yes it needs to be applied to each page.  But you don't need to create an object.
{"page":1}
{"id":0,"bg_color":"Black","bg_grad_dir":0,"border_side":0}

Thanks @presslab-us . I can also live with this solution.
@fvanroie : Let me know, if I should remove only border or close this MR.

I think we can safely remove the page border without any issues.
In order to remove the gradient, there needs to be a wider acceptance then just a personal preference.
I suggest you'd create a Poll in the discussions and we'll await the outcome. Either way is fine by me.

I create a pollhere


Configure dependabot for docs dependencies

Description
Added dependabot for documentation dependencies (sphinx, etc.).
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have read the contribution guidelines and followed it as far as possible.
[x] I have performed a self-review of my own code (if applicable)
[x] I have commented my code, particularly in hard-to-understand areas (if applicable)
[ ] I have made corresponding changes to the documentation (if applicable)
[x] My changes generate no new warnings
[x] I have enabled the pre-commit hook and it's not detecting any issue.
[x] Any dependent and pending changes have been merged and published

Codecov Report

Merging #130 (be47770) into master (b28ccf3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   87.02%   87.02%
=======================================
  Files           3        3
  Lines         316      316
  Branches       53       53
=======================================
  Hits          275      275
  Misses         29       29
  Partials       12       12

Flag
Coverage Δ

unittests
87.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28ccf3...be47770. Read the comment docs.

Codecov Report

Merging #130 (be47770) into master (b28ccf3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   87.02%   87.02%
=======================================
  Files           3        3
  Lines         316      316
  Branches       53       53
=======================================
  Hits          275      275
  Misses         29       29
  Partials       12       12

Flag
Coverage Δ

unittests
87.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28ccf3...be47770. Read the comment docs.


Add few more checks in topology tests

@miq-bot add_label test, providers/containers

@miq-bot add_label topology


Always report  "InstantiateRuntime" event to telemetry

Description
In PR #13305, @vladsud added telemetry to the runtime-instantiation event, but wrapped it in a ReportIfTooLong call.
I think it would be best to always report the instantiation duration. That way we can always rely on it for telemetry (today, we instead have some of our containers add the telemetry, but not all containers do -- so it would be great to be able to standardize our telemetry to always use the Fluid Framework's reported duration).
Here's an example of what the event looks like, compared with the existing event from one of the containers. The top one is the new one, the bottom one is the one that the container reported today (so by having the framework report it, we'd also eliminate the slight gap):

Reviewer Guidance
@vladsud , note that for consistency with other event names, I also changed the capitalization of instantiateRuntime to InstantiateRuntime. To my knowledge, none of our main hosts have picked up the latest FF version yet, so it's unlikely we'll need to worry about the old name. But if you'd rather me keep the old capitalization, let me know.

@vladsud , @tylerbutler : since this change already has Vlad's approval, is there anything else it's waiting on before being merged? Ditto for related PR #13429

@Zlatkovsky - I'd think you have merge permissions (if not, we should probably fix it). That said, I'm happy to merge it if that works for you :)

@vladsud , it says that I'm not authorized to merge this pull request:

For now, if you can just merge the two PRs in, that'd be great. This one and #https://github.com/microsoft/FluidFramework/pull/13429

@Zlatkovsky - I've merged both, and will take a look at permissions for future.


mTLS migration and policy definition

We are using istio-operator and we are currently migrating a project to use mTLS.
We do not enable mTLS on all our pods so we need to manually create a policy to set mTLS permissive mode for all the services talking to the no-mtls pods.
To do that we manually create a policy like this
apiVersion: "authentication.istio.io/v1alpha1"
kind: "Policy"
metadata:
name: "migration-policy"
spec:
targets:

name: svc1
name: svc2
mtls:
mode: PERMISSIVE

Is there a way to create a policy like the one described above using the operator?
If not, could this be a feature that you would consider to add?
Thanks in advance and sorry if this is not the right place to ask this question

Hi @mc1711,
It's great to hear that you use the operator!
Honestly, it feels like this feature is out of scope of the operator, but it is definitely something that we would consider adding to our Backyards product.
It is not on our short term roadmap right now, but we will let you know as soon as we have a feature which can help you achieve what you described.
Until then, I would recommend you to follow our community Slack channel, specifically the #istio-operator and #backyards channels.

Thanks a lot @Laci21 .. I will follow the istio-operator and backyards project.

Hi @mc1711,
As I mentioned earlier, we hadn't planned to add this feature to the operator rather we wanted to add it to Backyards, which we did in Backyards 1.1.
In Backyards, you don't need to manually create the aformentioned Policy resources, you can achieve the same result by using the Backyards UI or CLI tool. You can read more about the details in our blog post or in the docs.
The instructions are documented how easily you can try out Backyards and this feature, let us know what you think of it!


Add explicit 'animated' parameter to navigation actions (default true)

Codecov Report

Merging #3 (3af6e88) into main (b2cb628) will increase coverage by 0.23%.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   93.86%   94.09%   +0.23%
==========================================
  Files          12       12
  Lines         277      305      +28
==========================================
+ Hits          260      287      +27
- Misses         17       18       +1

Impacted Files
Coverage Δ

...avigation/TabNavigation/TabNavigationHandler.swift
95.34% <85.71%> (-2.16%)
:arrow_down:

...ation/ModalNavigation/ModalNavigationHandler.swift
86.84% <94.73%> (+0.92%)
:arrow_up:

...leNavigation/ModalNavigation/ModalNavigation.swift
100.00% <100.00%> (ø)

...leNavigation/StackNavigation/StackNavigation.swift
100.00% <100.00%> (ø)

...ation/StackNavigation/StackNavigationHandler.swift
100.00% <100.00%> (ø)

...osableNavigation/TabNavigation/TabNavigation.swift
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2cb628...3af6e88. Read the comment docs.


Fix lights

Fix lights
Originally posted by @Alaaryad in https://github.com/Alaaryad/scaling-engine/issues/7#issuecomment-1553859489

I'm not sure what you are talking about. If you explain in more detail I'll reopen the issues.

I'm not sure what you are talking about. If you explain in more detail I'll reopen the issue.


add figures with the deformation parameter as a function of \vec{j} and A

Added in [this commit]

Added in this commit.


resolvedOptions order

This is a rehash of https://github.com/tc39/proposal-intl-duration-format/issues/30.
The ordering was fixed in https://github.com/tc39/proposal-intl-duration-format/commit/02584a571517ae261fefeae7234f0c83d7b428a4, but then reordered again in https://github.com/tc39/proposal-intl-duration-format/pull/150.
I wonder if the decision was intentional, since it makes locale come out second. This is observable at runtime.
JSC currently still puts numberingSystem last and locale first.

[[Locale]] and [[NumberingSystem]] should be switched, so that the order is

[[Locale]]
[[NumberingSystem]]
[[Style]]
[[YearsStyle]], [[YearsDisplay]], etc.
And [[FractionalDigits]] as the last entry.

Normative-wise, yes, because [[NumberingSystem]] is now second instead of last.

The spec which passed Stage 3 is in the following order
locale
style
years
yearsDisplay
months
monthsDisplay
weeks
weeksDisplay
days
daysDisplay
hours
hoursDisplay
minutes
minutesDisplay
seconds
secondsDisplay
milliseconds
millisecondsDisplay
microseconds
microsecondsDisplay
nanoseconds
nanosecondsDisplay
fractionalDigits
numberingSystem

the order got changed accidentially while merging PR 150 then I just merged PR 165 to correct that accidental change.
So I reopen this issue if we want to chagne the order. That need to be discuss and reach consensus in TC39 with a Normative PR

@anba, could you explain why you say
[[Locale]]
[[NumberingSystem]]
[[Style]]
[[YearsStyle]], [[YearsDisplay]], etc.
And [[FractionalDigits]] as the last entry.

I am not agree (nor disagree) with you. Just want to make sure we all understand the reasoning of that.

[[NumberingSystem]] should appear right after [[Locale]] to match other Intl constructors, which generally have properties from Unicode extension keys right after [[Locale]] [1, 2]:
For example:

Intl.DateTimeFormat has [[Calendar]] and [[NumberingSystem]] right after [[Locale]].
Intl.NumberFormat has [[NumberingSystem]] right after [[Locale]].

Is that because that align with the access order of the information from the option bag?

Yes, I think so. Intl.NumberFormat doesn't match this anymore, but I think the other constructors still align the resolvedOptions object with the access order in the constructor function. (Maybe except hour12, which got reordered later when support for hourCycle was added.)

[1] Intl.Collator is an exception, because its Unicode extension properties numeric and caseFirst are optional, because support for kn and kf is optional.
[2] Intl.RelativeTimeFormat does not have [[NumberingSystem]] right after [[Locale]]. We probably overlooked this when adding it in https://github.com/tc39/proposal-intl-relative-time/pull/100. We may want to consider reordering the output of Intl.RelativeTimeFormat.prototype.resolvedOptions.


test(core): add some component tests

Added simple tests for some components of the core package.
I'm adding tests with a policy of fulfilling coverage to some extent.

If this policy is acceptable, it will be reflected in all other components in the next PR.

@MH4GF
Thank you for your PR! I've taken a look at the PR and have a few points of feedback:

The test title mentions checking the "allowed shorthand style props", but it currently only verifies that the Grid component renders. It would be beneficial to ensure that each prop is correctly applied and reflects the desired styles.
Some of the prop values, like auto-flow, might not be appropriate for properties such as grid, gridArea, etc. Please double-check the valid values for these properties.

Thank you for your response 😄

The test title mentions checking the "allowed shorthand style props", but it currently only verifies that the Grid component renders. It would be beneficial to ensure that each prop is correctly applied and reflects the desired styles.

By default, the Grid component should have the style display: grid;. It might be good to have a test that verifies this even without any style props provided.

I thought the point you made was valid when I thought of "testing in the kuma ui component.". However, this component of @kuma-ui/core does not convert shorthand props, so it seems to be ignored even if props are passed as this component.
With that in mind, it seemed like it would be of little value as a test to perform component testing here.
Rendering after transformation by babel, more like an e2e test, might be more desirable.
What do you think? For my part, I think it might be best to close this PR once it is done.

@MH4GF
I was a bit puzzled by your comment. When you mentioned @kuma-ui/core does not convert shorthand props, could you clarify that? I was under the impression it did.

@poteboy
Sorry for the late reply! I'm in the process of reading and debugging the code and trying to understand it better. Please wait a little longer as we will contact you within 3 days.

Sorry, I will not do this one now. I am rooting of this project, Thanks!